From xen-devel-bounces@lists.xenproject.org Mon Mar 01 01:33:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 01:33:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91205.172269 (Exim 4.92) (envelope-from ) id 1lGXQa-0007yH-Qe; Mon, 01 Mar 2021 01:32:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91205.172269; Mon, 01 Mar 2021 01:32:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGXQa-0007y9-Kp; Mon, 01 Mar 2021 01:32:52 +0000 Received: by outflank-mailman (input) for mailman id 91205; Mon, 01 Mar 2021 01:32:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGXQY-0007xy-GJ; Mon, 01 Mar 2021 01:32:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGXQX-00076l-IV; Mon, 01 Mar 2021 01:32:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGXQX-0004jA-1M; Mon, 01 Mar 2021 01:32:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lGXQX-0006bB-0P; Mon, 01 Mar 2021 01:32:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=19wsLjqqhgh/bwH5O+6ewMA4Fjk1T0+L1BR5oXExzAY=; b=cAMfK8dA3j7thLY5UJMlKoFT4H MAi4D5L4C+0XrngQZTBI3yNz2mCvAW2aKEmr6B1tT/6KISsSxD1I0WOvutp4NU/PEATC2SpmOABWS jA6JMWfGNGDOjhaUWouTefWybWY2TSDX2d97tPdyTFHYKZtkDiq7LkzEv8M6fyVLJ6+o=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159785: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=51db2d7cf26d05a961ec0ee0eb773594b32cc4a1 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Mon, 01 Mar 2021 01:32:49 +0000 flight 159785 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/159785/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 159780 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 159780 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 51db2d7cf26d05a961ec0ee0eb773594b32cc4a1 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 192 days Failing since 152659 2020-08-21 14:07:39 Z 191 days 369 attempts Testing same since 159700 2021-02-26 08:46:59 Z 2 days 5 attempts ------------------------------------------------------------ 428 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 117941 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 01 02:12:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 02:12:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91213.172284 (Exim 4.92) (envelope-from ) id 1lGY3H-00034B-SX; Mon, 01 Mar 2021 02:12:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91213.172284; Mon, 01 Mar 2021 02:12:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGY3H-000344-OV; Mon, 01 Mar 2021 02:12:51 +0000 Received: by outflank-mailman (input) for mailman id 91213; Mon, 01 Mar 2021 02:12:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGY3G-00033w-FB for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 02:12:50 +0000 Received: from mga02.intel.com (unknown [134.134.136.20]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 28bb75c4-3929-4aca-bafd-fdb8cfab03a9; Mon, 01 Mar 2021 02:12:46 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2021 18:12:44 -0800 Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga002.fm.intel.com with ESMTP; 28 Feb 2021 18:12:18 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 28 Feb 2021 18:08:50 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 28 Feb 2021 18:08:50 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sun, 28 Feb 2021 18:08:50 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Sun, 28 Feb 2021 18:08:49 -0800 Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by MWHPR1101MB2270.namprd11.prod.outlook.com (2603:10b6:301:54::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Mon, 1 Mar 2021 02:08:48 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::f1b4:bace:1e44:4a46]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::f1b4:bace:1e44:4a46%6]) with mapi id 15.20.3890.028; Mon, 1 Mar 2021 02:08:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28bb75c4-3929-4aca-bafd-fdb8cfab03a9 IronPort-SDR: KF4fSGHsjIZw2VW2jNx/Wvi/w8rz3iAAxL9mM0dvIpTNdIoq8nTweaNJmz9p3IpivpHqOLU7a1 NisTRZVP6KdQ== X-IronPort-AV: E=McAfee;i="6000,8403,9909"; a="173465183" X-IronPort-AV: E=Sophos;i="5.81,214,1610438400"; d="scan'208";a="173465183" IronPort-SDR: xXo7xspist5dqf5Csg5euK3q349+HgTTe/1TtahnOfd2nNu+08IxQq51oNkfn5LubYtCqd+eQK +HHCkF/Dz4lw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,214,1610438400"; d="scan'208";a="435243854" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lFdwTK38ywkuOJHoiv+ykYs2Sojq71nAD96WWCydlnMX9rylWje1aH1AYYhQcjwqOJvdRYzrSmPSX/w/nmdHj5QTYwGuGMazf3nU8S4JjgG7poJeSUXR/01BEQenIXuavlTEWlrOiqjnL81shz6upFj6b37Xp4HmAo/AiuqAJJEmi3O1B21MHqzd4Hx1M6S0GZPq/OwovYDV7NCp/U9pDwWdH9/EHmAJe2WRF3r4Xzjht0MQvpTDlrN9JA04R3WnHzWl4zdyZ1wEb5SEdxHKeP9wLMQ552wrLafpL7XXFBEZ7+4SMHHE15J5kGuuGThuKl7+6QzrD8EvNyREW6HBsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SM6fWWQYALeaONjtsblI/MM+unLUBrW10cVDx5gLMoM=; b=G60hVbfgkMhk5a5ZaVLs9t1L+B4cMO3oLdNUmwp+ERlGJ98NCBjTfrA5g3oDmw02uu3UhGnUQ5DRYPszolEgrDQZCLU02gDBdSv3Zmz5s1VeJQmAiaxFZwlkNqEQVzDmTbtWcqCEQ3FW2aZIlS0bjnJm4F2Taaxi/JdSJ63K7SmfSeRnTT8BjxuC/ZhQp6Y97glOhaEqgIjgMnJSZu33lECN3qmkJayb20kIUSKyE7L6+jmciw4fkWWM+48iADmrzd/6P1gTrlRsEOXUymFt36Lx7bpEhFbHtW8g/GwYMSMF14y8/IZYrMU/FOzuz0uDlH+CHjUCvvuy8Y3F/vSxsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SM6fWWQYALeaONjtsblI/MM+unLUBrW10cVDx5gLMoM=; b=opwWfw067tzSYDQmQ58BNuqXeJveE1Q9+w0A1J/3w0IZX/AQtR5p52Cot/g6v7aAGr7Vw5MC3d8dYlmYALUAaT5JPvQhwh+GQazDR/LxKFd0l4FA7gkIsZBZgMvSP3lxyndV/fDN6wFR3awyizTxvpWDp2rUZEMAwuPWVAUWTSs= From: "Tian, Kevin" To: Jan Beulich , "Cooper, Andrew" CC: Julien Grall , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH] VMX: use a single, global APIC access page Thread-Topic: [PATCH] VMX: use a single, global APIC access page Thread-Index: AQHW/8yZa97+qDgbIE6iwG3wuPN9papRnNEAgAABAgCAHOIDYA== Date: Mon, 1 Mar 2021 02:08:48 +0000 Message-ID: References: <1b6a411b-84e7-bfb1-647e-511a13df838c@suse.com> <3c7a4cff-3f11-22e1-ed46-e76f62cc08f4@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9eb57eeb-79ed-4227-21b1-08d8dc56f3bc x-ms-traffictypediagnostic: MWHPR1101MB2270: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r7ivZ8AL4jqZTV9tW/MgtFMAH9Twv2uVDiv+p6DGegAqaCyABehLAARw4Z1Fzwg2efl6HTDfihLC9eBaoJHzxgGIJTKucoGXhKeYk0Q3gNcrbcs+g/OVnk+L3RPPOyO30Xq852wB7Wl01vC223eV14UcKC0TUS4ci2ey83Xu2kLm3kcQvkkK7bfiqAuMP9VBEXeqGEzArLZVaYVIpQsOAxdVkNBOHZX4xOtQOoJLZhVgBm3yGq3Nzei6fJ++wnT1sX9J1U31kHsu9ITM5vV6vKXLsjoaFfsSsHoVKTON1DUVv1VkfO2Us4WVCjh8nKHOZpKCC/R4ynEbWm9VRRsrHy8Q9FLlJDIPoHqujz0+dBb+t3fs2dVRH6l47Hka0WfI+gHOiceSXoIk1uzsjmOKyeR4OMXL/jiMtjwWfEmsgqADoID7Lgtjwtp1EdnlgGGzQVpoCvy2DyZDPLA5N32QYvcZhhuLsJaTohqHOs/nBbIZ4BE6eacwd/q3uknYSHKlLRtXykKKEzYNnDu0R9FaGA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1886.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(396003)(376002)(346002)(366004)(8676002)(76116006)(66476007)(66446008)(2906002)(5660300002)(4744005)(9686003)(26005)(64756008)(86362001)(66556008)(186003)(71200400001)(55016002)(8936002)(66946007)(52536014)(478600001)(110136005)(53546011)(54906003)(33656002)(316002)(7696005)(4326008)(83380400001)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?utf-8?B?U1dlaVpWcEVZdXYyaVJNUUNJTDAyaHhkSVBqcVM0K2t3Tkc4VTlHQzFyVGhl?= =?utf-8?B?MmppZ2trNzJ5emVTSTgvUzhXNnFEcERrSXNPRHd3ejlsdEtZTHVmRWd2ZTFM?= =?utf-8?B?aER5aTdkcFU2SU11YTZUcG4xOE1MaWR1Z3dSaWR0azNUMmpkT3lwSGladC9I?= =?utf-8?B?U01oZDhJVEZjL0hFeENtVWg5SEgyQTY0a2xrdzlEVUxROXZ6eVZ0UzlwbTNI?= =?utf-8?B?QUxrZ213MzgvNTQwdzZpQk5icG1aaDE5a3MyNEtCSXpUeUQzYmZSN1RwTWFF?= =?utf-8?B?WXFKU3FFbXoyZTJNaU5vTm9nL2grQ3hRK2ZIME1pSXl2eWVURVZCbGZlUEFY?= =?utf-8?B?d2JBc0taWHVJNDV4VnVLU01aZ0hGNU9SNXdEWjF2aC9kMk1GMFJLWmxIS2Jk?= =?utf-8?B?ZlB3U3luRzVzQ0h3YTNadlE4Y1F4cy9paTFrMGpSMnFHK2Q5RkpodlVYbDgv?= =?utf-8?B?b2lDOVhmS1hiUnZDSC9ndVZlOGNMSnJDWllJSnBLNVNvS0Q5VGtVcE1EMkov?= =?utf-8?B?aG1rZEJ2MXVaU1pQRzE0UUxoU3d1RTlMbkVuZzQ4WjdvK1hyV05kQU92MUMv?= =?utf-8?B?U1J4c2VxTWtIMTJiNWFFcjlmV1B5TXNzK1YrS2ZXaFUzWGVLVE5aZTR2QjR0?= =?utf-8?B?aFNabUQ1N0U5a0JYTFg1NmFvSU50MlJyemJTdHBuSFRQc3Vld01XaDdRaXYw?= =?utf-8?B?RVIzQWJ4SEtJSVdSdE15b3hOUXFtYVpHQmM3bVpkVm1MeFNDb2x6M0U0RStw?= =?utf-8?B?bHFKZityY0lEN2prUkwzaDVuZ0J4Si9SNFY0V1EwQ0dQdUw0KzJ2ZHY2bG5l?= =?utf-8?B?NTJZd1U3NnBxWFQ2aVJpd2wrdVhwSnc1Zno3bzIxZDVVTWE3N29YazhsalY2?= =?utf-8?B?RllBYWVyRkM1d20xY1NieEJKRllZWXp3ajVkaXpCK2R0RFY5ZlhEeG16TnZk?= =?utf-8?B?ZE9DSlNLdFNjcnZZRXNubjdJYWcwdXFncWZidDJRTlpGcU91UnQvL0hIMHhH?= =?utf-8?B?eUVHQkltcEY0SEZMZ0E3QXlybURmOFNLWnp6WXpGMVM5eHpTcUhvSXBQbkQw?= =?utf-8?B?UVlDZUhjZnV0WTBid2NyK1pCVVRyRW9tL3hkKzdtWTF5MUJSR2NYWFhrY0d2?= =?utf-8?B?QjRuWXNudmxxQU52VXUxaXZXZFBBbk4yZWV0ZE83RnBlQTRvb0M3VS9BRU51?= =?utf-8?B?SzF5UnMxWDJ2S2x5ZGR2YlF1N3F4YVRjNGE4a1p6VEdzMENPUE5ETTh3MGRm?= =?utf-8?B?eWFKVldYL0lwTnJTdnpHT20za05xL2Z1Z3hRdU94N0YwWVpIYmFMbXpYRmEw?= =?utf-8?B?cjVVTWs0WHUwUnJnQjV4amJsNDI0eEtrTUxGZ1M4eXhwUnl0SVVtT0g5eEF0?= =?utf-8?B?M0ZNTVhVM1NmQzhVbjM2THJLa3FNZGJJTk03V2RZWllSUnZ6UURGUFRBMkZC?= =?utf-8?B?Z3IvUm5ObkZKZTZ0MFkyQVV0STF4Y0pYV0s5Si80cFRSY085dExQNDlER1Bs?= =?utf-8?B?V2ZSME93eFdTNkpkR25BUTdOWTREYnJmWkNIVytyMW9vSTBKTDZqMWxVb0Y4?= =?utf-8?B?RzdoZm5RbmxSVjRseGI3LzRyNHFYbjFlSFIxTzIvN1VvbUkzTTlZbHJ2Y05L?= =?utf-8?B?bkJyTEMyWmgxc3ZGU295SEtGUmFIa2FPL0orRmpSemprd2xjREpzbHNxWmFZ?= =?utf-8?B?L1VDSUhMNWVneGpjaURGTlpLaU1rTzFmYVV3N2VhREh1Q2tGL2hrbGJsQjdu?= =?utf-8?Q?1wsLHAzPloj4eRXfRm4CNcU2hJoiDGt+q8pizN0?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9eb57eeb-79ed-4227-21b1-08d8dc56f3bc X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2021 02:08:48.5926 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r1ZvAnw///Vyo40W4ITG7PpGamjUHJMcm8XL6xDnafvhAxPOKa1D6OuCHTcia1amKSWczBUjhO5INy9eXHwAtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2270 X-OriginatorOrg: intel.com PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFRodXJzZGF5 LCBGZWJydWFyeSAxMSwgMjAyMSAxOjA0IEFNDQo+IA0KPiBPbiAxMC4wMi4yMDIxIDE4OjAwLCBB bmRyZXcgQ29vcGVyIHdyb3RlOg0KPiA+IE9uIDEwLzAyLzIwMjEgMTY6NDgsIEphbiBCZXVsaWNo IHdyb3RlOg0KPiA+PiBUaGUgYWRkcmVzcyBvZiB0aGlzIHBhZ2UgaXMgdXNlZCBieSB0aGUgQ1BV IG9ubHkgdG8gcmVjb2duaXplIHdoZW4gdG8NCj4gPj4gaW5zdGVhZCBhY2Nlc3MgdGhlIHZpcnR1 YWwgQVBJQyBwYWdlIGluc3RlYWQuIE5vIGFjY2Vzc2VzIHdvdWxkIGV2ZXIgZ28NCj4gPj4gdG8g dGhpcyBwYWdlLiBJdCBvbmx5IG5lZWRzIHRvIGJlIHByZXNlbnQgaW4gdGhlIChDUFUpIHBhZ2Ug dGFibGVzIHNvDQo+ID4+IHRoYXQgYWRkcmVzcyB0cmFuc2xhdGlvbiB3aWxsIHByb2R1Y2UgaXRz IGFkZHJlc3MgYXMgcmVzdWx0IGZvcg0KPiA+PiByZXNwZWN0aXZlIGFjY2Vzc2VzLg0KPiA+Pg0K PiA+PiBCeSBtYWtpbmcgdGhpcyBwYWdlIGdsb2JhbCwgd2UgYWxzbyBlbGltaW5hdGUgdGhlIG5l ZWQgdG8gcmVmY291bnQgaXQsDQo+ID4+IG9yIHRvIGFzc2lnbiBpdCB0byBhbnkgZG9tYWluIGlu IHRoZSBmaXJzdCBwbGFjZS4NCj4gPj4NCj4gPj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2gg PGpiZXVsaWNoQHN1c2UuY29tPg0KPiA+DQo+ID4gSG93IGNlcnRhaW4gYXJlIHlvdSBhYm91dCB0 aGlzPw0KPiANCj4gVGhlIGRvY3VtZW50YXRpb24gKEknbSBpbmNsaW5lZCB0byBzYXk6IHVuZXhw ZWN0ZWRseSkgaXMgdmVyeQ0KPiBjbGVhciBhYm91dCB0aGlzOyBJIGRvbid0IHRoaW5rIGl0IGhh ZCBiZWVuIHRoaXMgY2xlYXIgYmFjayBhdA0KPiB0aGUgdGltZS4gSSdtIGhvcGluZyBmb3IgS2V2 aW4gdG8gc2hvdXQgaWYgaGUncyBhd2FyZSBvZiBpc3N1ZXMNCj4gaGVyZS4NCj4gDQoNCk5vLCBJ IGRpZG4ndCBzZWUgYW4gaXNzdWUgaGVyZS4NCg0KVGhhbmtzDQpLZXZpbg0K From xen-devel-bounces@lists.xenproject.org Mon Mar 01 02:18:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 02:18:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91217.172296 (Exim 4.92) (envelope-from ) id 1lGY8m-0003Fo-KC; Mon, 01 Mar 2021 02:18:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91217.172296; Mon, 01 Mar 2021 02:18:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGY8m-0003Fh-H1; Mon, 01 Mar 2021 02:18:32 +0000 Received: by outflank-mailman (input) for mailman id 91217; Mon, 01 Mar 2021 02:18:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGY8l-0003Fc-7B for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 02:18:31 +0000 Received: from mga03.intel.com (unknown [134.134.136.65]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id aa50b3be-5b33-4c92-88a3-882ee32fdafb; Mon, 01 Mar 2021 02:18:28 +0000 (UTC) Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2021 18:18:27 -0800 Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 28 Feb 2021 18:18:26 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 28 Feb 2021 18:18:25 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sun, 28 Feb 2021 18:18:25 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Sun, 28 Feb 2021 18:18:25 -0800 Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by CO1PR11MB5091.namprd11.prod.outlook.com (2603:10b6:303:6c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.23; Mon, 1 Mar 2021 02:18:25 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::f1b4:bace:1e44:4a46]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::f1b4:bace:1e44:4a46%6]) with mapi id 15.20.3890.028; Mon, 1 Mar 2021 02:18:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa50b3be-5b33-4c92-88a3-882ee32fdafb IronPort-SDR: fBH/Mrjyz3e+Un1gBdPQc1+q6lcWfYRZPR6ij46kiqzK6SBh2x9vg2nrENI8Oc5Mx+GreJmkH1 kBPY9oKLg6Fg== X-IronPort-AV: E=McAfee;i="6000,8403,9909"; a="186388510" X-IronPort-AV: E=Sophos;i="5.81,214,1610438400"; d="scan'208";a="186388510" IronPort-SDR: YvwSSqPtcfxGLROnapjH8prtQMyvQ/oSKkKI4A7pqGghZa3gNm4grmKldgw4YVIX4eqLDqyyo8 J7w5oXRKav3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,214,1610438400"; d="scan'208";a="397256789" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bT67WWLDTj3UydlOggPOcDTvZ9EScpii98WUFweQBl3Fna4xaTPCtrFECj965Od5FRmV3yf8gOWzGdMxBFaMOmp3glBzHwHbl4JntibeU7sRSzO5ZEYoIt1dcvX3r0+rVwf5cs9yEKHleMQv38TsAlGYVhfnqOTWUZnThtCiL/zPVT54AyjGuWTmhvbfBahvpQCHwuJWAWPwcJoTOA0fzjqNGSxVhtaQQtTKcInq0juVd2ADj3efUEPSgLZEspwmifswmFL7Kwr5c4ytOCH2Gt0hH2ae91z+PkZJl5G00E9v8naqVmICQViRUXlB62T1W2WbInFb1boBMnsTBsdPvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jAu6irp7v+fxrd8gveebhEvkfkKzguA4v1weEOsoW98=; b=VqrpazdcFufs1MeGcHXMae6J54CZYHFEuRIKtok/bczKhvVYLnHTcoODReVVIJBB8GMCGyYBfdmk4bS7g+6jhc/klRzYlj/z2clXP80AjjpnCZp0IRmrWLQa+hGRrU3oaZV71kX/ThlfQtAbBp8zw0hTIxgd8zl4uYVa67l5Kp7kNzI72YPya5NK+OQLsoicsY23CKcN5+V28kfQPLV1wNZ9EEu+tVDN5R7kQQ+0n1AJZa+KAS8+eia0uw6aR1eADwniLbIpggdIoQdyE6WfeFacSo6IuhpYGdnP/Z8U35xRlNsqkh8xmJbp2HuqYaxu1t5NQV9O72F/CX6QXQwmXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jAu6irp7v+fxrd8gveebhEvkfkKzguA4v1weEOsoW98=; b=XyS0n83kIGQ2LzvP3BwlSW34ApwWN0LPmp8iGuOb2Cor/bwOFWW60xw4TOVSdTjv7uCGdZ9hdj890nGh+5RsspoHwtg8+rT9GWCbfayu0K7bkAaYPUQ7kyCTqQhYb0O3MRbf6UqreS3NlLVWw2+OE7+sfGfV+NyKeH/EvlWOg0U= From: "Tian, Kevin" To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Julien Grall" , "Cooper, Andrew" , "Wei Liu" Subject: RE: [PATCH] VMX: use a single, global APIC access page Thread-Topic: [PATCH] VMX: use a single, global APIC access page Thread-Index: AQHW/8yZa97+qDgbIE6iwG3wuPN9papSpOiAgAAfJYCAAAsJgIAAAbyAgAASBACAG55hYA== Date: Mon, 1 Mar 2021 02:18:24 +0000 Message-ID: References: <1b6a411b-84e7-bfb1-647e-511a13df838c@suse.com> <7abc515b-d652-3d39-6038-99966deafdf8@suse.com> <547b40f2-3b7b-10cb-30f6-9445c784eb0b@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d5c9546e-88dd-4aa3-5726-08d8dc584b31 x-ms-traffictypediagnostic: CO1PR11MB5091: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s05eae9jpGQRN2kiVANFbV5O7OCYlRX+kNqyQuNpMudGRS5zN8DXp4xpbFSZmyEnaKkPM9aF83UpHlklw7YGGGFJzi84R36moz/7T4gFIvfHALlsiS/yVDXj61Dh1FNE5YDNBbzOKBfV243CdJsMAAu9i11kRnRaKWN+adxWelvV6V2pkBYO9a6AUyhbebvYq5RBaDxh97nZ34Pni6L5vS3cQFKeDMwaJx1rH7T1iWKGu5gR9jwFg+X9v2QU7o6OV/EUMKe6Lrbtziz1vw/Z4xTiPaRUkOpyADe/MlNLzL3fvBFfiH9ndmyXNzSh766X7U7wo44a8vHeltfLU7HdvCS0DM4O+iicBAZPMCCFi3g68kZYSYiSyrLmmXUFoFIvdrPaFY7AErZARh0dg32V9ydXu3KQ9rgSt5H1fRUyWGuM1/RBLgLPAyp1AT91H/S7/wUPn6ykgn4g5LcPnLQed5iaO5Jp1HHI+iB5tmRhoFlovU/RQMJvCQLUhxzCHOnbDbxRlAc4LTPU5Rkoq3DQXQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1886.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(39860400002)(136003)(396003)(346002)(366004)(8936002)(54906003)(71200400001)(55016002)(5660300002)(8676002)(52536014)(86362001)(83380400001)(9686003)(186003)(4326008)(2906002)(316002)(478600001)(26005)(64756008)(53546011)(66446008)(7696005)(66946007)(66556008)(66476007)(76116006)(33656002)(6506007)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?utf-8?B?dnk3dG9meVFRcDF4MFBFMFYrTWs4UXMxQUhITXlHOUcvbVJlZC9YYXQ0Undq?= =?utf-8?B?c3c3Z1Jvb3NLTzFPL0V1K2JFYXRZYjZuZGtQOGdqRzBBT1BwMlExNTZUditj?= =?utf-8?B?M2x4Q2Jja1RtSzdEMGtMekdwa0FKWUM3N1E0cEFROUpxM1VLcW05TzVwdDFt?= =?utf-8?B?dzdtNXlqVFdKdURaKzdiNDFmZWdiRS84ejhrZ1p1Tk03dFBPSHl0bnEyL2oz?= =?utf-8?B?bTZpVGN5RzhFMmpSMm11dmMxNTIvQmtTSEg1cjEwbWhvRjgyYmFBTWRxTEZ3?= =?utf-8?B?QTVySkdWQ0pnYXBnNU1yUDN6LzAyMUlZSXJJNEVUaGtKbTg4TnRocGV1Zlpj?= =?utf-8?B?N2tvM0tsUXZZK0FHajU3NHBxd3Mvb3VTOXZkOFdZS3k0eG1PWllUYU5RWC9I?= =?utf-8?B?azBpcXlYSGFxcUo3NUhuVHpPMDk3eElOV0haRnVGYzE5Sys0NmJhY0c4c0Zl?= =?utf-8?B?N1ljQStTSDVLa3liNzBJTS90SnlXYlBUN0FFYVdoVzRGakYwam1GSjlFM3Er?= =?utf-8?B?VW9QZWxsQnRocW13dUJWbVdxbEFGREUxQzZSaWRqV3JJUkJZUHo1bEwydjEz?= =?utf-8?B?VklZVXdkM2tLeFFTdUlIWHdkeEc3WjQ2a2VNUGVwNjBtRjdNYzBqNU5LTENF?= =?utf-8?B?Zm9zWlpjdVJaL2l1c1h6U2JNelZKdHQvRFNVQkZydlZVQU9sa2J0LzRoc2g1?= =?utf-8?B?c3VqZXVUaU1ZdHJhZFRkNVl3ZVhTMjl4N1Y5Y0hTaGs5WGpQdUJvakEyQWxZ?= =?utf-8?B?RFIrQkMwZ3lOTllTcnRxS1luNUhSd3pjZDFtY2RWNUlQVFViYXc2YWpUUUtl?= =?utf-8?B?WU5iQ1lpTFJaRDJmNVA0Uk14S0cwMTEvWEVoVjU0c0RjVGNyRkdpakZiR0tN?= =?utf-8?B?ZG4yYTVtd0pOUG5aVDNBeCtEWHAwOVJFZi9XbmRyYzE4WndrQkVYQ1J5R0F5?= =?utf-8?B?VmU5TkhqN2ZLdENXS3ZzRDJOVkNzUzREY0phNlhHZkdnbUlLcm5OaEdXRFE0?= =?utf-8?B?OEVoV1ZzRjFqejJCL2VBTy9FdG5oak1nMHNxYTR1MlNLbE9QL081eU9ZcmlM?= =?utf-8?B?M05meEhxWnkvblhZT2xiKzZDUXNTN0orbUpiaGhrVk5hRW5QN3ZpcFFVWk95?= =?utf-8?B?VjJHRmV4Ti9FZmVGeFVnOU9yRW5WTzkvbm9aUnVwR0tlaXVQMWhkNlhzbGts?= =?utf-8?B?RlRvSHUwdjBxTFRZOHM4WTdnN2tSRHdmaERlWGQ4RzE5M20ra2VSemZqQWcw?= =?utf-8?B?T0NENXFkd1kxMWEzaE5JUlp1a2h6dWRnNm5vTDdKK01jMCtHREdSMXFkMThS?= =?utf-8?B?Mkczc09mMUcydWZuTkRSNVFwdTdzRFd4WU8yZjRWRjYvWFowU1krdzVheWti?= =?utf-8?B?ejhveGI2d1pTTmlvSE5PSkRsSTVWL2s5WWo4dkxDM2VtTnB4RGdaZi9NTkN0?= =?utf-8?B?ZG9aTkhRUzlvOWY2R2dPSmlKeG9pRlR6RGVFQnNUOExZc0RzZFVBeE94T2tx?= =?utf-8?B?c2Z2VlMxd3BodFI0eDMvaFJXZUxUdnFtZXliY2RqVnQ2TFhrMG1zblZGZ2JT?= =?utf-8?B?d05JYTBFWEpucUVYWFJSOSt1U0VvRWVodDhBbnVybnVWemZJU2l5aHMveHFj?= =?utf-8?B?Z3VzYk54TVRsOTd5ZzlLVWJhSGZWVzRpdk5PWVE0ekp4RnpmaFp0VkhPSzE2?= =?utf-8?B?SGFSVTJaallWa0w3OWtmcWhVUTJoSkpQQjRKTE9vK2lkL3NDSWhHMWNsOXBR?= =?utf-8?Q?y49o12AZIbENJL2uZVakfuXyosa5jLJ1oKedIvC?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5c9546e-88dd-4aa3-5726-08d8dc584b31 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2021 02:18:24.8653 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LqDNa852+T7QxTHZbeTfmbso8gp7LWfcWYiUcK5+ZP8JkgxDfgugSubdKpLVbwerbVfYkV3WpBF7R4SreIEtrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5091 X-OriginatorOrg: intel.com PiBGcm9tOiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gU2VudDog VGh1cnNkYXksIEZlYnJ1YXJ5IDExLCAyMDIxIDg6MjcgUE0NCj4gDQo+IE9uIFRodSwgRmViIDEx LCAyMDIxIGF0IDEyOjIyOjQxUE0gKzAxMDAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiA+IE9uIDEx LjAyLjIwMjEgMTI6MTYsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+ID4gPiBPbiBUaHUsIEZl YiAxMSwgMjAyMSBhdCAxMTozNjo1OUFNICswMTAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gPiA+ PiBPbiAxMS4wMi4yMDIxIDA5OjQ1LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiA+ID4+PiBP biBXZWQsIEZlYiAxMCwgMjAyMSBhdCAwNTo0ODoyNlBNICswMTAwLCBKYW4gQmV1bGljaCB3cm90 ZToNCj4gPiA+Pj4+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgNCj4gPiA+Pj4+ICsr KyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgNCj4gPiA+Pj4+IEBAIC05MzUsNiArOTM1LDkg QEAgc3RhdGljIGlubGluZSB1bnNpZ25lZCBpbnQgcDJtX2dldF9pb21tdQ0KPiA+ID4+Pj4gICAg ICAgICAgZmxhZ3MgPSBJT01NVUZfcmVhZGFibGU7DQo+ID4gPj4+PiAgICAgICAgICBpZiAoICFy YW5nZXNldF9jb250YWluc19zaW5nbGV0b24obW1pb19yb19yYW5nZXMsIG1mbl94KG1mbikpICkN Cj4gPiA+Pj4+ICAgICAgICAgICAgICBmbGFncyB8PSBJT01NVUZfd3JpdGFibGU7DQo+ID4gPj4+ PiArICAgICAgICAvKiBWTVgnZXMgQVBJQyBhY2Nlc3MgcGFnZSBpcyBnbG9iYWwgYW5kIGhlbmNl IGhhcyBubyBvd25lci4NCj4gKi8NCj4gPiA+Pj4+ICsgICAgICAgIGlmICggbWZuX3ZhbGlkKG1m bikgJiYgIXBhZ2VfZ2V0X293bmVyKG1mbl90b19wYWdlKG1mbikpICkNCj4gPiA+Pj4+ICsgICAg ICAgICAgICBmbGFncyA9IDA7DQo+ID4gPj4+DQo+ID4gPj4+IElzIGl0IGZpbmUgdG8gaGF2ZSB0 aGlzIHBhZ2UgYWNjZXNzaWJsZSB0byBkZXZpY2VzIGlmIHRoZSBwYWdlIHRhYmxlcw0KPiA+ID4+ PiBhcmUgc2hhcmVkIGJldHdlZW4gdGhlIENQVSBhbmQgdGhlIElPTU1VPw0KPiA+ID4+DQo+ID4g Pj4gTm8sIGl0J3Mgbm90LCBidXQgd2hhdCBkbyB5b3UgZG8/IEFzIHNhaWQgZWxzZXdoZXJlLCBk ZXZpY2VzDQo+ID4gPj4gZ2FpbmluZyBtb3JlIGFjY2VzcyB0aGFuIGlzIGhlbHBmdWwgaXMgdGhl IHByaWNlIHdlIHBheSBmb3INCj4gPiA+PiBiZWluZyBhYmxlIHRvIHNoYXJlIHBhZ2UgdGFibGVz LiBCdXQgLi4uDQo+ID4gPg0KPiA+ID4gSSdtIGNvbmNlcm5lZCBhYm91dCBhbGxvd2luZyBkZXZp Y2VzIHRvIHdyaXRlIHRvIHRoaXMgc2hhcmVkIHBhZ2UsIGFzDQo+ID4gPiBjb3VsZCBiZSB1c2Vk IGFzIGFuIHVuaW50ZW5kZWQgd2F5IHRvIGV4Y2hhbmdlIGluZm9ybWF0aW9uIGJldHdlZW4NCj4g PiA+IGRvbWFpbnM/DQo+ID4NCj4gPiBXZWxsLCBzdWNoIGFuIGFidXNlIHdvdWxkIGJlIHBvc3Np YmxlLCBidXQgaXQgd291bGRuJ3QgYmUgcGFydA0KPiA+IG9mIGFuIEFCSSBhbmQgaGVuY2UgY291 bGQgYnJlYWsgYXQgYW55IHRpbWUuIFNpbWlsYXJseSBJDQo+ID4gd291bGRuJ3QgY29uc2lkZXIg aXQgYW4gaW5mb3JtYXRpb24gbGVhayBpZiBhIGd1ZXN0IGFidXNlZA0KPiA+IHRoaXMuDQo+IA0K PiBIbSwgSSdtIGtpbmQgb2Ygd29ycmllZCBhYm91dCBoYXZpbmcgc3VjaCBzaGFyZWQgcGFnZSBh Y2Nlc3NpYmxlIHRvDQo+IGd1ZXN0cy4gQ291bGQgSW50ZWwgY29uZmlybSB3aGV0aGVyIHBhZ2Vz IGluIHRoZSAweEZFRXh4eHh4IHJhbmdlIGFyZQ0KPiBhY2Nlc3NpYmxlIHRvIGRldmljZXMgaW4g YW55IHdheSB3aGVuIHVzaW5nIElPTU1VIHNoYXJlZCBwYWdlDQo+IHRhYmxlcz8NCg0KMHhGRUV4 eHh4eCByYW5nZSBpcyBzcGVjaWFsLiBSZXF1ZXN0cyB0byB0aGlzIHJhbmdlIGFyZSBub3Qgc3Vi amVjdCB0bw0KRE1BIHJlbWFwcGluZyAoZXZlbiBpZiBhIHZhbGlkIG1hcHBpbmcgZm9yIHRoaXMg cmFuZ2UgZXhpc3RzIGluIHRoZSANCklPTU1VIHBhZ2UgdGFibGUpLiBBbmQgdGhpcyBzcGVjaWFs IHRyZWF0bWVudCBpcyB0cnVlIHJlZ2FyZGxlc3Mgb2YNCndoZXRoZXIgaW50ZXJydXB0IHJlbWFw cGluZyBpcyBlbmFibGVkICh3aGljaCBjb21lcyBvbmx5IGFmdGVyIGFuIA0KaW50ZXJydXB0IG1l c3NhZ2UgdG8gdGhpcyByYW5nZSBpcyByZWNvZ25pemVkKS4NCg0KVGhhbmtzDQpLZXZpbg0K From xen-devel-bounces@lists.xenproject.org Mon Mar 01 02:38:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 02:38:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91220.172308 (Exim 4.92) (envelope-from ) id 1lGYSJ-0005Ez-7Q; Mon, 01 Mar 2021 02:38:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91220.172308; Mon, 01 Mar 2021 02:38:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGYSJ-0005Es-3b; Mon, 01 Mar 2021 02:38:43 +0000 Received: by outflank-mailman (input) for mailman id 91220; Mon, 01 Mar 2021 02:38:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGYSH-0005En-Rv for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 02:38:41 +0000 Received: from mga02.intel.com (unknown [134.134.136.20]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5c1cfa0c-d708-4ff7-86f0-753e4c2e3cfb; Mon, 01 Mar 2021 02:38:39 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2021 18:38:38 -0800 Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga002.fm.intel.com with ESMTP; 28 Feb 2021 18:38:07 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 28 Feb 2021 18:34:27 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 28 Feb 2021 18:34:26 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sun, 28 Feb 2021 18:34:26 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Sun, 28 Feb 2021 18:34:24 -0800 Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by MWHPR11MB1472.namprd11.prod.outlook.com (2603:10b6:301:d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.28; Mon, 1 Mar 2021 02:34:21 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::f1b4:bace:1e44:4a46]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::f1b4:bace:1e44:4a46%6]) with mapi id 15.20.3890.028; Mon, 1 Mar 2021 02:34:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c1cfa0c-d708-4ff7-86f0-753e4c2e3cfb IronPort-SDR: N4kQXeF5K/u1yNqfUQQ/383h/x/VI4hz4ZxpStc9zqyPb5bPD5SAQJ0aWXVRd4+YpWAnLaiUH9 hl75kzPs0rCg== X-IronPort-AV: E=McAfee;i="6000,8403,9909"; a="173468144" X-IronPort-AV: E=Sophos;i="5.81,214,1610438400"; d="scan'208";a="173468144" IronPort-SDR: VEhzljH7TWYK1jEcpGZu+XxEi8iga09sw8SALvGseImlMXRbNaXF3vdiWWlPv7lAWiUyBtprD1 VykHwaiuBsyg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,214,1610438400"; d="scan'208";a="435250398" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ApLB/zSplgY28r3v7eGOx1hQoPAv18UYopGKrnRXPSsuqxwHOCyFVlKCRAxEgQE/EIUS7kp1nKkiS86EROZ7KKCsFe3Ag/3ae5yJXyt02Jd1hkdecnmUq7akDwsSlm6XPDVQL4WK4BPFa3pXrT8tK9Buuj7mnopTAFOr9njO0lW9gLCMCMm4Pb5PwwYKVCj6ECVIhsoNdh8GCeFFrvVnIXk+Z+0uKSJ9ViaJiGvqDpda7AEINbO3eFitMK+XX4f88+FxO02pcb8cQ8O8/uCh4EFult8mphDAE5/3etT+f+kS/1sW7UcWBwcXaXmhStcVTWevHvnaBT00VfKXwy+zPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o0eQSDURXlKeu3XnQMoLBl/z4GiC3XaNCrR0btMof6U=; b=awipn2vX7nbKoTTrQgDc282kivZiBOjK7UhPbIhvuZA/9D2zGJpMGdeHViZOQJyX/hT+rUY2eMhRLcUcAP5C3Yo+neMXsnNMw1grkoIqkpuci9HFDgxdHVZYSDZ+r0odTSNhgKwzwy8f6wRXuBuqAN8jQ4IxcaUT8bs2FQI5GLF4Xdu+n/46Dk7hBm1XMDcrwmqEmdto3ZO5dVEJeKiYxuZViE3sZL2e1rXbSK4lyVP2ib582cmovbZzMvdnvuCeqycCmKH/wjEDpZfDcbhof5Ljgh5vuwJbb0GZWIUmURMWrKPxctWOL9PKs+lSDIvf/j+IWFjmAOTT1X8YzhYtUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o0eQSDURXlKeu3XnQMoLBl/z4GiC3XaNCrR0btMof6U=; b=lWEDK+MckT/LnRVIPr1PR6/npeVus+J+cyv7ZLi76lMjZwh1hVz1/rx2DvKKGkjVOIbsHr17zazAa1phUAAp9fHNWXRm7HFdqmX/sCjFNRXz5il90+7ZErQVo+8OfTJ2i2B8ZKNUOXX61JDeXZZy+2pmDdLwlcWUnxD36Ln0Xmk= From: "Tian, Kevin" To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: "Cooper, Andrew" , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Ian Jackson , George Dunlap , "Nakajima, Jun" Subject: RE: [PATCH v3 2/2] VMX: use a single, global APIC access page Thread-Topic: [PATCH v3 2/2] VMX: use a single, global APIC access page Thread-Index: AQHXCQmBRdBcMCCJUUaaKANK6r4GfapucSbw Date: Mon, 1 Mar 2021 02:34:20 +0000 Message-ID: References: <4731a3a3-906a-98ac-11ba-6a0723903391@suse.com> <774a0bf2-d2a4-7dba-bf15-fec8b0ec8c5f@suse.com> In-Reply-To: <774a0bf2-d2a4-7dba-bf15-fec8b0ec8c5f@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 549fac52-e672-4cc6-7437-08d8dc5a8519 x-ms-traffictypediagnostic: MWHPR11MB1472: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LZAZDKZP/qHjHEJG5K2A8zf+MDdJRk0kLb4HCTVACPi40pXD3MryaHqcz8RZjvRnGbTgOl18XKcynFRHqDExVr899E15orGKTS8PO5emGhAqHLMblbpW7hE/T8mvIRoHcOqoRE2154vfzQJWWdYKmTcpAaTUS+irC6ZpD2hNyoh4ULc4dPJw5bp496PJQRBA0eARWzLQ8feazz5gK8vqBOp7hLztpdYmL021JOq808t0ZfZQMKuztoYY82XfRPBvKDNBO6/cTaCBCJWjPBJbHLBgSfWAKDrdH2Jhb++SkT9PR7doj2JusQ5vzUEWf66jbLxdLUBg4+KKTn7yQBN/5YXWOld8oZR2GyoaZ+aY2bDAwi5eXQBm8ostgdyq6C7/55qptftvwVEM94ZTyij3SGRBPyiY6vugWli+dH9RCZ7qsVF5K+oimNlPHrAacwiA+Y2C02NsWev40CL3/8D/Z/28tkykcQ2oq8swaBxH6wBRtNBWqQrNzjHRsTmHQAFbMkb6Qq15nn43HM0fxC5/gg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1886.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(376002)(366004)(396003)(136003)(39860400002)(4326008)(8936002)(107886003)(2906002)(478600001)(86362001)(8676002)(9686003)(52536014)(55016002)(5660300002)(316002)(64756008)(66446008)(33656002)(110136005)(76116006)(66556008)(66946007)(66476007)(83380400001)(26005)(71200400001)(7696005)(186003)(54906003)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?utf-8?B?S01teTJjekhhL09pQ3VXZXBQV0ZBM2FQZXA3eDlZU3diWHBkMkF1a1ViRDFj?= =?utf-8?B?bDZ4UENBSi9iU1d0UTRrOFZQOXY5bmd1UllzZGFKZkE3bGprc1gycVlOb3JS?= =?utf-8?B?ZHFTS1hDeXowYWc2UUVQVUhMWHZHVmw3dzRUSjNsZzR4cUF4QndVUDJlRzh1?= =?utf-8?B?Slg3RVV6U0NhSXNwMXJUMFJKK2FVV3lFV0Y5Z3ZMSVFhNi8vRFJLOGVDVTN2?= =?utf-8?B?cGVyT2NxNy9sVDNZN2ZqVnJEbjJxbHRkdjd3Vm02UjhNeFBpaXlwbjhTMGFI?= =?utf-8?B?Q0F6dGdsQUNZUkwxUlA2Z1JUTi84UmVPMEVXWWZpS1poRnI3OGhrcEtpZ01h?= =?utf-8?B?bEc2ZHdqUFNkdVViVTRTQUUxK1VzZjYwdFMzQ2RncnZ1T29NYytqK3hLWlpE?= =?utf-8?B?TElWQ0lETW1mUjFhellPdGhCOUt5UXFtWDJoVStlK0dSSkFxWWxrWXNSU2dv?= =?utf-8?B?cjFUc0h2bkNZeC9VRDRLRzZ3UzdiRjNYZ0dNVGtyM1FxNkNGMjJwSFl0L2J0?= =?utf-8?B?NXFYT0dpTjczOEJVb2N5ZU9UUDZxVHdWRGN5Wi9YekxzakZETUVwK2twYVE2?= =?utf-8?B?TWtMSVozbFdxK1NGTWhLNysvQ2tCRGxXR0EyZEQxb3RMODU5N2YzaXN4YW5P?= =?utf-8?B?R3BFQXYrUVNnL0x3bnkwWXRDOHhQRlJud2tvQnpVbVU1WkZRMkJTckpsZ08z?= =?utf-8?B?N1Nob1crZDNUZUFneFRHM3FiUnpGT2xpcU8rdGM3cVlBdU9NMWJ5OXBOVHNr?= =?utf-8?B?UFlGbGJxelNNSW85em93Y1p5U0V3ZHRSbkpMV0NGRHQzT29sUDR3SVVOdkU0?= =?utf-8?B?MFRkOUV1MHowSlNaNUpsRGxzdzBJRjRoRTlNUFFXaVpzUm0rNHZTTFlxZU9v?= =?utf-8?B?MzhBVkdCMEtHZzJ0MFpwZ1ZWTXFQRXphdjNqZmFwTEJMb1FCVkVCZzBjMjEy?= =?utf-8?B?RzIxc2NTUi8xeHJ3a3cwYWsvZWRoZmxiY25CN3lScHp2aGhKUnJRSVJDcGti?= =?utf-8?B?elVaWkR2Y1JHZmdXaWYvZVlYWDdkN0lBaUE0MFFKd2kvOUFtd3lrNzFJdzQr?= =?utf-8?B?cWJiMGRqaDRFaTl6alRDd1hyT3dPdEx3SVRiYjZ4c0J6S0lyYzNkenp5Rk1M?= =?utf-8?B?RXZWWVptNTFGalhVQ2tLcWNOTzZBZTdzRW9Xc1RCclBQRHRuVEVCcU9zVzc1?= =?utf-8?B?T1Yyd2hpMmpRRURyNjUrM2pVMzNPdStRczZsYW42RU1CZ3RxY283Q3AwS3Nv?= =?utf-8?B?VStvNElNZGpCTS9zQVRwTnRPVmtHdFg1L0Q0MnhEVWFZU2NXbzlZakRvWFJK?= =?utf-8?B?V0F2NFhIUVc3OUo1K2pJSjRYZGNxbTlZQkFtWmdNSG1MWTV5eHl2RmpBdEg0?= =?utf-8?B?dzY2eXFvWGUxR1J3cUpGY2JQVkc3OEM3WkJmRlpYcUdpWUlnTmZwOU9FZTdT?= =?utf-8?B?T01qcmt4YlVDYUhFT3czTG9IWWFMNjc1Qy83U3cvb2pWRXROTFRuR1E0Vkx2?= =?utf-8?B?UFRrTXIvOGF3aXdkangxSlZWTVhhWml0RG4xZTlqaW5HWXZzMGd0M2p6alRr?= =?utf-8?B?Z1hJNjR1V05KTTE5MzdrUWZ6dkcycUhzTHRYM0ZzV1g3OHJ6WFNXbkc5enBS?= =?utf-8?B?aHlicnJRczgxNlIzc0tSeWhrVzkyZFhoWmJDYUZLWEVxL2hXVm0wUk5zK1BD?= =?utf-8?B?NHJZZlQ1c2gveGdLdWp0aXRiVHo2TW42NnpYQ3JOdDB3aDVXYUpNTG0rNXdy?= =?utf-8?Q?DRLX2hmgLmtq0T/NYB3IIzPqCtO2jao8LNjKolZ?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 549fac52-e672-4cc6-7437-08d8dc5a8519 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2021 02:34:20.9890 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: o4tjwTagNKU22rOtOk//Sn6IOKWjmjacDhMIk9oWHA1GDRuHeK2Cp4xFeP6Ad7w+u6iNdc6vwkfwKxWJ/JXsZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1472 X-OriginatorOrg: intel.com PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg RmVicnVhcnkgMjIsIDIwMjEgNjo1NyBQTQ0KPiANCj4gVGhlIGFkZHJlc3Mgb2YgdGhpcyBwYWdl IGlzIHVzZWQgYnkgdGhlIENQVSBvbmx5IHRvIHJlY29nbml6ZSB3aGVuIHRvDQo+IGFjY2VzcyB0 aGUgdmlydHVhbCBBUElDIHBhZ2UgaW5zdGVhZC4gTm8gYWNjZXNzZXMgd291bGQgZXZlciBnbyB0 byB0aGlzDQo+IHBhZ2UuIEl0IG9ubHkgbmVlZHMgdG8gYmUgcHJlc2VudCBpbiB0aGUgKENQVSkg cGFnZSB0YWJsZXMgc28gdGhhdA0KPiBhZGRyZXNzIHRyYW5zbGF0aW9uIHdpbGwgcHJvZHVjZSBp dHMgYWRkcmVzcyBhcyByZXN1bHQgZm9yIHJlc3BlY3RpdmUNCj4gYWNjZXNzZXMuDQo+IA0KPiBC eSBtYWtpbmcgdGhpcyBwYWdlIGdsb2JhbCwgd2UgYWxzbyBlbGltaW5hdGUgdGhlIG5lZWQgdG8g cmVmY291bnQgaXQsDQo+IG9yIHRvIGFzc2lnbiBpdCB0byBhbnkgZG9tYWluIGluIHRoZSBmaXJz dCBwbGFjZS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl LmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPg0K DQo+IC0tLQ0KPiB2MzogU3BsaXQgcDJtIGluc2VydGlvbiBjaGFuZ2UgdG8gYSBzZXBhcmF0ZSBw YXRjaC4NCj4gdjI6IEF2b2lkIGluc2VydGlvbiB3aGVuICFoYXNfdmxhcGljKCkuIFNwbGl0IG9m ZiBjaGFuZ2UgdG8NCj4gICAgIHAybV9nZXRfaW9tbXVfZmxhZ3MoKS4NCj4gLS0tDQo+IEkgZGlk IGZ1cnRoZXIgY29uc2lkZXIgbm90IGFsbG9jYXRpbmcgYW55IHJlYWwgcGFnZSBhdCBhbGwsIGJ1 dCBqdXN0DQo+IHVzaW5nIHRoZSBhZGRyZXNzIG9mIHNvbWUgdW5wb3B1bGF0ZWQgc3BhY2UgKHdo aWNoIHdvdWxkIHJlcXVpcmUNCj4gYW5ub3VuY2luZyB0aGlzIHBhZ2UgYXMgcmVzZXJ2ZWQgdG8g RG9tMCwgc28gaXQgd291bGRuJ3QgcHV0IGFueSBQQ0kNCj4gTU1JTyBCQVJzIHRoZXJlKS4gQnV0 IEkgdGhvdWdodCB0aGlzIHdvdWxkIGJlIHRvbyBjb250cm92ZXJzaWFsLCBiZWNhdXNlDQo+IG9m IHRoZSBwb3NzaWJsZSByaXNrcyBhc3NvY2lhdGVkIHdpdGggdGhpcy4NCj4gDQo+IC0tLSBhL3hl bi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vdm14L3Zt eC5jDQo+IEBAIC02Niw4ICs2Niw3IEBAIGJvb2xlYW5fcGFyYW0oImZvcmNlLWVwdCIsIG9wdF9m b3JjZV9lcHQNCj4gIHN0YXRpYyB2b2lkIHZteF9jdHh0X3N3aXRjaF9mcm9tKHN0cnVjdCB2Y3B1 ICp2KTsNCj4gIHN0YXRpYyB2b2lkIHZteF9jdHh0X3N3aXRjaF90byhzdHJ1Y3QgdmNwdSAqdik7 DQo+IA0KPiAtc3RhdGljIGludCAgdm14X2FsbG9jX3ZsYXBpY19tYXBwaW5nKHN0cnVjdCBkb21h aW4gKmQpOw0KPiAtc3RhdGljIHZvaWQgdm14X2ZyZWVfdmxhcGljX21hcHBpbmcoc3RydWN0IGRv bWFpbiAqZCk7DQo+ICtzdGF0aWMgaW50IGFsbG9jX3ZsYXBpY19tYXBwaW5nKHZvaWQpOw0KPiAg c3RhdGljIHZvaWQgdm14X2luc3RhbGxfdmxhcGljX21hcHBpbmcoc3RydWN0IHZjcHUgKnYpOw0K PiAgc3RhdGljIHZvaWQgdm14X3VwZGF0ZV9ndWVzdF9jcihzdHJ1Y3QgdmNwdSAqdiwgdW5zaWdu ZWQgaW50IGNyLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBp bnQgZmxhZ3MpOw0KPiBAQCAtNzgsNiArNzcsOCBAQCBzdGF0aWMgaW50IHZteF9tc3JfcmVhZF9p bnRlcmNlcHQodW5zaWduDQo+ICBzdGF0aWMgaW50IHZteF9tc3Jfd3JpdGVfaW50ZXJjZXB0KHVu c2lnbmVkIGludCBtc3IsIHVpbnQ2NF90IG1zcl9jb250ZW50KTsNCj4gIHN0YXRpYyB2b2lkIHZt eF9pbnZscGcoc3RydWN0IHZjcHUgKnYsIHVuc2lnbmVkIGxvbmcgbGluZWFyKTsNCj4gDQo+ICtz dGF0aWMgbWZuX3QgX19yZWFkX21vc3RseSBhcGljX2FjY2Vzc19tZm47DQo+ICsNCj4gIC8qIFZh bHVlcyBmb3IgZG9tYWluJ3MgLT5hcmNoLmh2bV9kb21haW4ucGlfb3BzLmZsYWdzLiAqLw0KPiAg I2RlZmluZSBQSV9DU1dfRlJPTSAoMXUgPDwgMCkNCj4gICNkZWZpbmUgUElfQ1NXX1RPICAgKDF1 IDw8IDEpDQo+IEBAIC00MDEsNyArNDAyLDYgQEAgc3RhdGljIGludCB2bXhfZG9tYWluX2luaXRp YWxpc2Uoc3RydWN0DQo+ICAgICAgICAgIC50byAgID0gdm14X2N0eHRfc3dpdGNoX3RvLA0KPiAg ICAgICAgICAudGFpbCA9IHZteF9kb19yZXN1bWUsDQo+ICAgICAgfTsNCj4gLSAgICBpbnQgcmM7 DQo+IA0KPiAgICAgIGQtPmFyY2guY3R4dF9zd2l0Y2ggPSAmY3N3Ow0KPiANCj4gQEAgLTQxMSwy OCArNDExLDE0IEBAIHN0YXRpYyBpbnQgdm14X2RvbWFpbl9pbml0aWFsaXNlKHN0cnVjdA0KPiAg ICAgICAqLw0KPiAgICAgIGQtPmFyY2guaHZtLnZteC5leGVjX3NwID0gaXNfaGFyZHdhcmVfZG9t YWluKGQpIHx8IG9wdF9lcHRfZXhlY19zcDsNCj4gDQo+IC0gICAgaWYgKCAhaGFzX3ZsYXBpYyhk KSApDQo+IC0gICAgICAgIHJldHVybiAwOw0KPiAtDQo+IC0gICAgaWYgKCAocmMgPSB2bXhfYWxs b2NfdmxhcGljX21hcHBpbmcoZCkpICE9IDAgKQ0KPiAtICAgICAgICByZXR1cm4gcmM7DQo+IC0N Cj4gICAgICByZXR1cm4gMDsNCj4gIH0NCj4gDQo+IC1zdGF0aWMgdm9pZCB2bXhfZG9tYWluX3Jl bGlucXVpc2hfcmVzb3VyY2VzKHN0cnVjdCBkb21haW4gKmQpDQo+IC17DQo+IC0gICAgaWYgKCAh aGFzX3ZsYXBpYyhkKSApDQo+IC0gICAgICAgIHJldHVybjsNCj4gLQ0KPiAtICAgIHZteF9mcmVl X3ZsYXBpY19tYXBwaW5nKGQpOw0KPiAtfQ0KPiAtDQo+ICBzdGF0aWMgdm9pZCBkb21haW5fY3Jl YXRpb25fZmluaXNoZWQoc3RydWN0IGRvbWFpbiAqZCkNCj4gIHsNCj4gLSAgICBpZiAoIGhhc192 bGFwaWMoZCkgJiYgIW1mbl9lcShkLT5hcmNoLmh2bS52bXguYXBpY19hY2Nlc3NfbWZuLA0KPiBf bWZuKDApKSAmJg0KPiArICAgIGlmICggaGFzX3ZsYXBpYyhkKSAmJiAhbWZuX2VxKGFwaWNfYWNj ZXNzX21mbiwgX21mbigwKSkgJiYNCj4gICAgICAgICAgIHNldF9tbWlvX3AybV9lbnRyeShkLCBn YWRkcl90b19nZm4oQVBJQ19ERUZBVUxUX1BIWVNfQkFTRSksDQo+IC0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgZC0+YXJjaC5odm0udm14LmFwaWNfYWNjZXNzX21mbiwgUEFHRV9PUkRFUl80 SykgKQ0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFwaWNfYWNjZXNzX21mbiwgUEFH RV9PUkRFUl80SykgKQ0KPiAgICAgICAgICBkb21haW5fY3Jhc2goZCk7DQo+ICB9DQo+IA0KPiBA QCAtMjQxNSw3ICsyNDAxLDYgQEAgc3RhdGljIHN0cnVjdCBodm1fZnVuY3Rpb25fdGFibGUgX19p bml0ZA0KPiAgICAgIC5jcHVfdXBfcHJlcGFyZSAgICAgICA9IHZteF9jcHVfdXBfcHJlcGFyZSwN Cj4gICAgICAuY3B1X2RlYWQgICAgICAgICAgICAgPSB2bXhfY3B1X2RlYWQsDQo+ICAgICAgLmRv bWFpbl9pbml0aWFsaXNlICAgID0gdm14X2RvbWFpbl9pbml0aWFsaXNlLA0KPiAtICAgIC5kb21h aW5fcmVsaW5xdWlzaF9yZXNvdXJjZXMgPSB2bXhfZG9tYWluX3JlbGlucXVpc2hfcmVzb3VyY2Vz LA0KPiAgICAgIC5kb21haW5fY3JlYXRpb25fZmluaXNoZWQgPSBkb21haW5fY3JlYXRpb25fZmlu aXNoZWQsDQo+ICAgICAgLnZjcHVfaW5pdGlhbGlzZSAgICAgID0gdm14X3ZjcHVfaW5pdGlhbGlz ZSwNCj4gICAgICAudmNwdV9kZXN0cm95ICAgICAgICAgPSB2bXhfdmNwdV9kZXN0cm95LA0KPiBA QCAtMjY2Miw3ICsyNjQ3LDcgQEAgY29uc3Qgc3RydWN0IGh2bV9mdW5jdGlvbl90YWJsZSAqIF9f aW5pdA0KPiAgew0KPiAgICAgIHNldF9pbl9jcjQoWDg2X0NSNF9WTVhFKTsNCj4gDQo+IC0gICAg aWYgKCB2bXhfdm1jc19pbml0KCkgKQ0KPiArICAgIGlmICggdm14X3ZtY3NfaW5pdCgpIHx8IGFs bG9jX3ZsYXBpY19tYXBwaW5nKCkgKQ0KPiAgICAgIHsNCj4gICAgICAgICAgcHJpbnRrKCJWTVg6 IGZhaWxlZCB0byBpbml0aWFsaXNlLlxuIik7DQo+ICAgICAgICAgIHJldHVybiBOVUxMOw0KPiBA QCAtMzIxNyw3ICszMjAyLDcgQEAgZ3BfZmF1bHQ6DQo+ICAgICAgcmV0dXJuIFg4NkVNVUxfRVhD RVBUSU9OOw0KPiAgfQ0KPiANCj4gLXN0YXRpYyBpbnQgdm14X2FsbG9jX3ZsYXBpY19tYXBwaW5n KHN0cnVjdCBkb21haW4gKmQpDQo+ICtzdGF0aWMgaW50IF9faW5pdCBhbGxvY192bGFwaWNfbWFw cGluZyh2b2lkKQ0KPiAgew0KPiAgICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnOw0KPiAgICAgIG1m bl90IG1mbjsNCj4gQEAgLTMyMjUsNTIgKzMyMTAsMjggQEAgc3RhdGljIGludCB2bXhfYWxsb2Nf dmxhcGljX21hcHBpbmcoc3RydQ0KPiAgICAgIGlmICggIWNwdV9oYXNfdm14X3ZpcnR1YWxpemVf YXBpY19hY2Nlc3NlcyApDQo+ICAgICAgICAgIHJldHVybiAwOw0KPiANCj4gLSAgICBwZyA9IGFs bG9jX2RvbWhlYXBfcGFnZShkLCBNRU1GX25vX3JlZmNvdW50KTsNCj4gKyAgICBwZyA9IGFsbG9j X2RvbWhlYXBfcGFnZShOVUxMLCAwKTsNCj4gICAgICBpZiAoICFwZyApDQo+ICAgICAgICAgIHJl dHVybiAtRU5PTUVNOw0KPiANCj4gLSAgICBpZiAoICFnZXRfcGFnZV9hbmRfdHlwZShwZywgZCwg UEdUX3dyaXRhYmxlX3BhZ2UpICkNCj4gLSAgICB7DQo+IC0gICAgICAgIC8qDQo+IC0gICAgICAg ICAqIFRoZSBkb21haW4gY2FuJ3QgcG9zc2libHkga25vdyBhYm91dCB0aGlzIHBhZ2UgeWV0LCBz byBmYWlsdXJlDQo+IC0gICAgICAgICAqIGhlcmUgaXMgYSBjbGVhciBpbmRpY2F0aW9uIG9mIHNv bWV0aGluZyBmaXNoeSBnb2luZyBvbi4NCj4gLSAgICAgICAgICovDQo+IC0gICAgICAgIGRvbWFp bl9jcmFzaChkKTsNCj4gLSAgICAgICAgcmV0dXJuIC1FTk9EQVRBOw0KPiAtICAgIH0NCj4gLQ0K PiAgICAgIG1mbiA9IHBhZ2VfdG9fbWZuKHBnKTsNCj4gICAgICBjbGVhcl9kb21haW5fcGFnZSht Zm4pOw0KPiAtICAgIGQtPmFyY2guaHZtLnZteC5hcGljX2FjY2Vzc19tZm4gPSBtZm47DQo+ICsg ICAgYXBpY19hY2Nlc3NfbWZuID0gbWZuOw0KPiANCj4gICAgICByZXR1cm4gMDsNCj4gIH0NCj4g DQo+IC1zdGF0aWMgdm9pZCB2bXhfZnJlZV92bGFwaWNfbWFwcGluZyhzdHJ1Y3QgZG9tYWluICpk KQ0KPiAtew0KPiAtICAgIG1mbl90IG1mbiA9IGQtPmFyY2guaHZtLnZteC5hcGljX2FjY2Vzc19t Zm47DQo+IC0NCj4gLSAgICBkLT5hcmNoLmh2bS52bXguYXBpY19hY2Nlc3NfbWZuID0gX21mbigw KTsNCj4gLSAgICBpZiAoICFtZm5fZXEobWZuLCBfbWZuKDApKSApDQo+IC0gICAgew0KPiAtICAg ICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZyA9IG1mbl90b19wYWdlKG1mbik7DQo+IC0NCj4gLSAg ICAgICAgcHV0X3BhZ2VfYWxsb2NfcmVmKHBnKTsNCj4gLSAgICAgICAgcHV0X3BhZ2VfYW5kX3R5 cGUocGcpOw0KPiAtICAgIH0NCj4gLX0NCj4gLQ0KPiAgc3RhdGljIHZvaWQgdm14X2luc3RhbGxf dmxhcGljX21hcHBpbmcoc3RydWN0IHZjcHUgKnYpDQo+ICB7DQo+ICAgICAgcGFkZHJfdCB2aXJ0 X3BhZ2VfbWEsIGFwaWNfcGFnZV9tYTsNCj4gDQo+IC0gICAgaWYgKCBtZm5fZXEodi0+ZG9tYWlu LT5hcmNoLmh2bS52bXguYXBpY19hY2Nlc3NfbWZuLCBfbWZuKDApKSApDQo+ICsgICAgaWYgKCAh aGFzX3ZsYXBpYyh2LT5kb21haW4pIHx8IG1mbl9lcShhcGljX2FjY2Vzc19tZm4sIF9tZm4oMCkp ICkNCj4gICAgICAgICAgcmV0dXJuOw0KPiANCj4gICAgICBBU1NFUlQoY3B1X2hhc192bXhfdmly dHVhbGl6ZV9hcGljX2FjY2Vzc2VzKTsNCj4gDQo+ICAgICAgdmlydF9wYWdlX21hID0gcGFnZV90 b19tYWRkcih2Y3B1X3ZsYXBpYyh2KS0+cmVnc19wYWdlKTsNCj4gLSAgICBhcGljX3BhZ2VfbWEg PSBtZm5fdG9fbWFkZHIodi0+ZG9tYWluLQ0KPiA+YXJjaC5odm0udm14LmFwaWNfYWNjZXNzX21m bik7DQo+ICsgICAgYXBpY19wYWdlX21hID0gbWZuX3RvX21hZGRyKGFwaWNfYWNjZXNzX21mbik7 DQo+IA0KPiAgICAgIHZteF92bWNzX2VudGVyKHYpOw0KPiAgICAgIF9fdm13cml0ZShWSVJUVUFM X0FQSUNfUEFHRV9BRERSLCB2aXJ0X3BhZ2VfbWEpOw0KPiAtLS0gYS94ZW4vaW5jbHVkZS9hc20t eDg2L2h2bS92bXgvdm1jcy5oDQo+ICsrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL3ZteC92 bWNzLmgNCj4gQEAgLTU4LDcgKzU4LDYgQEAgc3RydWN0IGVwdF9kYXRhIHsNCj4gICNkZWZpbmUg X1ZNWF9ET01BSU5fUE1MX0VOQUJMRUQgICAgMA0KPiAgI2RlZmluZSBWTVhfRE9NQUlOX1BNTF9F TkFCTEVEICAgICAoMXVsIDw8DQo+IF9WTVhfRE9NQUlOX1BNTF9FTkFCTEVEKQ0KPiAgc3RydWN0 IHZteF9kb21haW4gew0KPiAtICAgIG1mbl90IGFwaWNfYWNjZXNzX21mbjsNCj4gICAgICAvKiBW TVhfRE9NQUlOXyogKi8NCj4gICAgICB1bnNpZ25lZCBpbnQgc3RhdHVzOw0KPiANCg0K From xen-devel-bounces@lists.xenproject.org Mon Mar 01 02:52:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 02:52:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91224.172320 (Exim 4.92) (envelope-from ) id 1lGYft-0007AW-L4; Mon, 01 Mar 2021 02:52:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91224.172320; Mon, 01 Mar 2021 02:52:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGYft-0007AP-Hp; Mon, 01 Mar 2021 02:52:45 +0000 Received: by outflank-mailman (input) for mailman id 91224; Mon, 01 Mar 2021 02:52:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGYfs-0007AK-5d for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 02:52:44 +0000 Received: from mga01.intel.com (unknown [192.55.52.88]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9be897fb-1e24-42fa-b63f-0ea08d55cee7; Mon, 01 Mar 2021 02:52:42 +0000 (UTC) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2021 18:52:41 -0800 Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga002.jf.intel.com with ESMTP; 28 Feb 2021 18:52:40 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 28 Feb 2021 18:52:40 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 28 Feb 2021 18:52:40 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sun, 28 Feb 2021 18:52:40 -0800 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.57) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Sun, 28 Feb 2021 18:52:39 -0800 Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by MWHPR1101MB2224.namprd11.prod.outlook.com (2603:10b6:301:52::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Mon, 1 Mar 2021 02:52:36 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::f1b4:bace:1e44:4a46]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::f1b4:bace:1e44:4a46%6]) with mapi id 15.20.3890.028; Mon, 1 Mar 2021 02:52:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9be897fb-1e24-42fa-b63f-0ea08d55cee7 IronPort-SDR: 4cevuxp8ExrZAmVtRar53iIZhLNvNxpW3AbhCpl4pXBD8S4nzgfgWuXZ4YEV59lJRnkfv16rUM MsLfK0r1tHfw== X-IronPort-AV: E=McAfee;i="6000,8403,9909"; a="205938084" X-IronPort-AV: E=Sophos;i="5.81,214,1610438400"; d="scan'208";a="205938084" IronPort-SDR: bgA17OzRQcppSLiy27xALfUYr7jCA7mEYJf8nMtjcL7xvH8n1ZV2RtZ7aw+lSVs90mFTw1TU2R FBq4aIhoVBRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,214,1610438400"; d="scan'208";a="382882638" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SNxKvc/9TE396I0IM28K4ECYRvx4TiEEBx/LUDm1OZHw7hbn6LceCWem09tii02XGmusc1p+daLUFn0HZcT2nsbjd2Imo7U0eaqCmZ7mR12cruqzKx04TzfT/oHmc68q2wIkdKh09ZFaRLzywlbT4+QS5Cwno+qxOu9sQavOv9V5SoEbbyGCIRe1Xyv1KEXSaepR8pAP2nnBbpl6DWlCunj4FwaiiCZYw9iN9WLSAXnQ+PGRqMrRebJQk5WW0kRWHxnbfY144jIys7O8UKHAekKHZ0gSc+vdtZV3uD5I8xuRrsmqYd294GSHrTyuj7U9mtKgrU3Cw0pr1KejBQ8cSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aILytKuA4trhDczi4N5AjWd4nrddsCiPITIvjPKRfNQ=; b=FckQgO1nMYKBWorMGEfJRSDPJMRVGfjxV+jMmAO1THwW9Bxu0Wf5/62VDCWiZVO3J+d9gJ9GaQ6SSuSghKUzemchDmR6LetNe7WGznkMEY8kyLEVAi5zu3+au3PxpPqhwgA64GPr9KQWFchqB32rCHco8pXlRArIoI6RTpVYrfk/nmKXR4d9B8QrvD4M94+K7bP+MvvNxZFwpG41Q4TiYAqmqRvtRYKSDFcGhl4fnhw6tS9RDW8YWE9gZZyqqX9yK9l/ifxxrt0dW3z8LAK5J6kVNpK4W5pewLWHWvr6CjpRd4JRvK7BEU0IprPBPPfECmPcf8xtVcX5Q6Q3cyJ3xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aILytKuA4trhDczi4N5AjWd4nrddsCiPITIvjPKRfNQ=; b=U1jSm76XNSGN4SrdLT1WrYVbsTnlSK8Ix3zvr9C7xzUoPobfdRS+L5csmZifenYfkrb0xLLv9g+IQH41KF4DuND4zm54ajQ75rYHwu2Cj8tZr72kz+NhB0YNzlTvMjpL0pQ9rFprrw1D8MnX8MiUMlFKZbg574DUt/Y2WcRyEso= From: "Tian, Kevin" To: Julien Grall , "xen-devel@lists.xenproject.org" CC: "hongyxia@amazon.co.uk" , "iwj@xenproject.org" , Julien Grall , Jan Beulich , "Cooper, Andrew" , "Paul Durrant" Subject: RE: [PATCH for-4.15 v5 2/3] xen/x86: iommu: Ignore IOMMU mapping requests when a domain is dying Thread-Topic: [PATCH for-4.15 v5 2/3] xen/x86: iommu: Ignore IOMMU mapping requests when a domain is dying Thread-Index: AQHXDC4avJrRD3TJLUOJC7HwMM6WPqpubplg Date: Mon, 1 Mar 2021 02:52:35 +0000 Message-ID: References: <20210226105640.12037-1-julien@xen.org> <20210226105640.12037-3-julien@xen.org> In-Reply-To: <20210226105640.12037-3-julien@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c835b1fa-ce4a-4780-84d4-08d8dc5d11c0 x-ms-traffictypediagnostic: MWHPR1101MB2224: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2150; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G0UMGl0tm86S61QIYXX0oq7SK945e147LZPXLNA+qxMlBRNEQ9+NmB4p9E2mWSA7Z3EwDf+og05PLbj5Xk8pxLnojGl/aIEnGl2DnFjtryxxPk75BhVdgAjjV6kiuXkT+iD3gtnoDGMRTOTyaW/8jVXCXHRQZKt9LNFS1IdyXtQ7TZkISRv/SaGOKw8lxMKjXUBMT2rq+buEDmVFCLmXpnb878sVYfiMwNNmSg+40qlnh/xHdF6VbrBNMXaydpS6+WuCMn3sw/1fEMCcBgnVa2DaoX1HOWvGXWfJwkUH5JUoWAOCG55GhmoHheYC/m0FfHHSkse5xMVvMqjingmslkzhn0SENsReqwLdg26/YNme8wdK8Tm5sa6wHW5Arf1wEvQ4eO+yGPFpcRnvkn3XB1xpd13mfneJsMcQlNNwlzldCEaH3foXLdKgHbCMpdKW6hKrp/XsUUmHqhHmB/scbd3L09kO8c62ZdaTIWJazO5uyn/0BJVHwbEYVi0qxLuiZKbXBAdqaqAfI42ms6zJsg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1886.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(136003)(346002)(39860400002)(376002)(366004)(110136005)(54906003)(4326008)(7696005)(86362001)(478600001)(316002)(6506007)(66556008)(66946007)(2906002)(64756008)(66446008)(76116006)(66476007)(52536014)(5660300002)(83380400001)(186003)(33656002)(26005)(71200400001)(8936002)(8676002)(55016002)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?wdQ3022aojlsjnEcQjKo7ZBWd3RLCZJfeloxWWfcukBcuy775CrnH5iy/Yfs?= =?us-ascii?Q?X8cpKYxlGP7EDdKAJZthRvqtNuiuep+10KOyV6GSyheAeA/D8/MPCd/tITYl?= =?us-ascii?Q?PQtbsMKxVJQ+Dz1Zl6F+CC/x41hBlgPRJtUiGjJFPB7QnNBEF6FoSNACIN5A?= =?us-ascii?Q?IeUULdadvS0a4kRcxM3snXy80xUJtH/j4JMqy9SiNIohr6h284ppmlcCVsMP?= =?us-ascii?Q?UP76CIFnvNLaiccA7+1WQ4WH2+lOmqxXakM+VnivQ4/YFpWYJ6yya7nQ/coY?= =?us-ascii?Q?Xs9OZNqnwrAQ46rFNuOOd/uvZYzr6JhFHyv+fr+y4cqJRKI9fSQ1DkW/AJbA?= =?us-ascii?Q?Nyc82IbhNmwKD5qoId0OAjlZSlEVc7azoQsr2OVOyWI7iZL/wNBABukSODnD?= =?us-ascii?Q?CeQG7vY6rctruv/RYYtzHoMAYrKc5rwx+9IXsdppHJcSMeY9IDOQlutujiC1?= =?us-ascii?Q?lwOjzpBb0Tqlzyyc3eaEJoEzAqs8JjjGrXbN4YNDZSJajvMMfG6+kRtgooQJ?= =?us-ascii?Q?ku+lSeLOh2/qEu7Sgb5b8vBFIaSxY8VIKBD8FpCG+pzl2qcx/jihHX2zGs+f?= =?us-ascii?Q?33Hlg2mCUPW3s2nopYxWMMANHIlgfE5TQsOiK4kDCoaJzMYFz4H9F5W7nrO/?= =?us-ascii?Q?E+IOhdi52kTo5ZQ/6JUoaVXjE1Jxr1U8BWsSQuAGxEcVMM2fX8mTMqPYSPqn?= =?us-ascii?Q?HVK03AKBxbNY0ZOmjzfyZFWG5Hvtj/pdwOiJP//PYLAuheqJXzg27DZ3gUTM?= =?us-ascii?Q?UQRgpseZzbfQOksFD+78yDHV8+4EjbNo47Nn4Kqvus1TYBKN+ArLKgTWe6Ys?= =?us-ascii?Q?UHwmoCMAFiqKlfvgpRlgQgDj4MLZVqsmikrCCvolswIcl3o2npRVGRVyIljT?= =?us-ascii?Q?dBktgeRYF8U3aI6A/bKPjdYOIsdzGWfeKscJPqDsevvLUkNtvv75WM8dS0og?= =?us-ascii?Q?cLa3QJzOB/dfc50rXKOnRDJvaUVw5sPKozhccWXtRJSQRuqgiBTvPvGrpo19?= =?us-ascii?Q?/qPQ62iEdaXejahFEeXbO831WwK142RfZVXWMupct3e8vTJV28UJ/Vp23vMI?= =?us-ascii?Q?tPelOELJSMEtA+05WSlcxYkVET8jM3ZYkRun4k9HIQZsjpIfby4ttoxQLZ9h?= =?us-ascii?Q?xVjb5prdZfJGxfULZOzGI34nf0dNMi/J8glsqW4U9XiJctYOGsY/iMhG3YUz?= =?us-ascii?Q?i2vDA4YCWJF0/UQPfk3IKhBD8QQ3BXxuH3cHg5RsP6EMKJnBmf++lRs3IMlJ?= =?us-ascii?Q?u0b9MxTx/pV3XUDvY/F2gZUX4aFXH1GA8NezJwBpPgFn2Jf7s4vOgyUPhGZJ?= =?us-ascii?Q?4FieGV9rwBCX76M2R75rafIB?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c835b1fa-ce4a-4780-84d4-08d8dc5d11c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2021 02:52:35.9804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j8SNATN64n4ZAi7EgPjgIm3h1lUG1mXFOapouCoATPnoJenRBP7twms5ylPedEEJFlM1NA/mbHBjWLU80/8XtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2224 X-OriginatorOrg: intel.com > From: Julien Grall > Sent: Friday, February 26, 2021 6:57 PM >=20 > From: Julien Grall >=20 > The new x86 IOMMU page-tables allocator will release the pages when > relinquishing the domain resources. However, this is not sufficient > when the domain is dying because nothing prevents page-table to be > allocated. >=20 > As the domain is dying, it is not necessary to continue to modify the > IOMMU page-tables as they are going to be destroyed soon. >=20 > At the moment, page-table allocates will only happen when iommu_map(). > So after this change there will be no more page-table allocation > happening because we don't use superpage mappings yet when not sharing > page tables. >=20 > In order to observe d->is_dying correctly, we need to rely on per-arch > locking, so the check to ignore IOMMU mapping is added on the per-driver > map_page() callback. >=20 > Signed-off-by: Julien Grall Reviewed-by: Kevin Tian >=20 > --- >=20 > As discussed in v3, this is only covering 4.15. We can discuss > post-4.15 how to catch page-table allocations if another caller (e.g. > iommu_unmap() if we ever decide to support superpages) start to use the > page-table allocator. >=20 > Changes in v5: > - Clarify in the commit message why fixing iommu_map() is enough > - Split "if ( !is_iommu_enabled(d) )" in a separate patch > - Update the comment on top of the spin_barrier() >=20 > Changes in v4: > - Move the patch to the top of the queue > - Reword the commit message >=20 > Changes in v3: > - Patch added. This is a replacement of "xen/iommu: iommu_map: Don't > crash the domain if it is dying" > --- > xen/drivers/passthrough/amd/iommu_map.c | 12 ++++++++++++ > xen/drivers/passthrough/vtd/iommu.c | 12 ++++++++++++ > xen/drivers/passthrough/x86/iommu.c | 3 +++ > 3 files changed, 27 insertions(+) >=20 > diff --git a/xen/drivers/passthrough/amd/iommu_map.c > b/xen/drivers/passthrough/amd/iommu_map.c > index d3a8b1aec766..560af54b765b 100644 > --- a/xen/drivers/passthrough/amd/iommu_map.c > +++ b/xen/drivers/passthrough/amd/iommu_map.c > @@ -285,6 +285,18 @@ int amd_iommu_map_page(struct domain *d, dfn_t > dfn, mfn_t mfn, >=20 > spin_lock(&hd->arch.mapping_lock); >=20 > + /* > + * IOMMU mapping request can be safely ignored when the domain is > dying. > + * > + * hd->arch.mapping_lock guarantees that d->is_dying will be observe= d > + * before any page tables are freed (see iommu_free_pgtables()). > + */ > + if ( d->is_dying ) > + { > + spin_unlock(&hd->arch.mapping_lock); > + return 0; > + } > + > rc =3D amd_iommu_alloc_root(d); > if ( rc ) > { > diff --git a/xen/drivers/passthrough/vtd/iommu.c > b/xen/drivers/passthrough/vtd/iommu.c > index d136fe36883b..b549a71530d5 100644 > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -1762,6 +1762,18 @@ static int __must_check > intel_iommu_map_page(struct domain *d, dfn_t dfn, >=20 > spin_lock(&hd->arch.mapping_lock); >=20 > + /* > + * IOMMU mapping request can be safely ignored when the domain is > dying. > + * > + * hd->arch.mapping_lock guarantees that d->is_dying will be observe= d > + * before any page tables are freed (see iommu_free_pgtables()) > + */ > + if ( d->is_dying ) > + { > + spin_unlock(&hd->arch.mapping_lock); > + return 0; > + } > + > pg_maddr =3D addr_to_dma_page_maddr(d, dfn_to_daddr(dfn), 1); > if ( !pg_maddr ) > { > diff --git a/xen/drivers/passthrough/x86/iommu.c > b/xen/drivers/passthrough/x86/iommu.c > index 58a330e82247..ad19b7dd461c 100644 > --- a/xen/drivers/passthrough/x86/iommu.c > +++ b/xen/drivers/passthrough/x86/iommu.c > @@ -270,6 +270,9 @@ int iommu_free_pgtables(struct domain *d) > if ( !is_iommu_enabled(d) ) > return 0; >=20 > + /* After this barrier, no new IOMMU mappings can be inserted. */ > + spin_barrier(&hd->arch.mapping_lock); > + > while ( (pg =3D page_list_remove_head(&hd->arch.pgtables.list)) ) > { > free_domheap_page(pg); > -- > 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 02:54:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 02:54:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91227.172332 (Exim 4.92) (envelope-from ) id 1lGYhb-0007HX-1a; Mon, 01 Mar 2021 02:54:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91227.172332; Mon, 01 Mar 2021 02:54:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGYha-0007HQ-Uj; Mon, 01 Mar 2021 02:54:30 +0000 Received: by outflank-mailman (input) for mailman id 91227; Mon, 01 Mar 2021 02:54:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGYhZ-0007HL-TZ for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 02:54:29 +0000 Received: from mga11.intel.com (unknown [192.55.52.93]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cab11424-ae6d-451e-b4cf-ad2687b85987; Mon, 01 Mar 2021 02:54:28 +0000 (UTC) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2021 18:54:27 -0800 Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 28 Feb 2021 18:54:27 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 28 Feb 2021 18:54:27 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sun, 28 Feb 2021 18:54:27 -0800 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.55) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Sun, 28 Feb 2021 18:54:26 -0800 Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by MWHPR1101MB2224.namprd11.prod.outlook.com (2603:10b6:301:52::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Mon, 1 Mar 2021 02:54:24 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::f1b4:bace:1e44:4a46]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::f1b4:bace:1e44:4a46%6]) with mapi id 15.20.3890.028; Mon, 1 Mar 2021 02:54:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cab11424-ae6d-451e-b4cf-ad2687b85987 IronPort-SDR: I2PTngH+kXPIMRNcrNXfHe6EDrSWYAFvA64uKKuvGCIVkrah/h7ZbSsT5yDEdi/mOJvA6Xca0o /ykXjbOi1OLw== X-IronPort-AV: E=McAfee;i="6000,8403,9909"; a="182938083" X-IronPort-AV: E=Sophos;i="5.81,214,1610438400"; d="scan'208";a="182938083" IronPort-SDR: 7Om0hpx9mFJOY15MbI61vDhaZTFw6Cd40pbu4tdkP24dMZNbbBElfyAgXMFr1xNiQQy55G32g3 4kX7cM++6w8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,214,1610438400"; d="scan'208";a="366559411" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PKXWYf86QudRxWalkgLHEKcxX23PiYkmE7BY5DNjfp1RIWglUfNCm0VCWjDMiiGgU96UNY83bes9f03ZoaZZkbT7c6yXSv8wPvjoavuSJFPsc20mmnX+10BgAzsLgZiF9PlkoPiSVxbQTfEIX72eZ+HfNw+BEZXZ7/rRH4TpOGcQgU3JJdB/dDPubD4qHq9fTx+AqYb4nfuJxM/KBgG+FSCoShYsan0i2otjJOVcR9SgeGzRdDgJfkCcDYMIGCujhovblSIeHvOYuQdjOoGch++7C0/9JaMqCaWBnEk/+BlYj7tMiccVs4bFbzomoZU73sgb9XzoFZScp4gl9DpPaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DZxTLy4zDG/KoZLGFJYJg7VHVh0CrYyXqnkOjpTcIbM=; b=Kz5rWz7Bc7GszNqooGY1inQOonI2h71xkthSQ4O3Wsi/Gx0CZB8rGZTHkUkp/rs2M9ZAsbeunJ/T0or8RZNU/ZhRwee5urEPvIxKLfVgRpS4kHItWPTRn8GQRwu9H0cSzgZOhzJMKxfUKvMBo9wbhQGrv3XsEIHEWC1fKupdnGXZbu/nYiekTIEyU666jzamuR+OIoSpI6zCA+PVRxvL3bYHPej1GQJ9t3U/RX2lNoKiVGoVix1MGzaLNdwu2BrxUQZAf76qutkvlRisDX7Yt0RgWrmCh0UX2zwLcvz9+x2xpDJgrjxukoH5g5XebJ/4IefjKHzNsE7cv/EuWSv2Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DZxTLy4zDG/KoZLGFJYJg7VHVh0CrYyXqnkOjpTcIbM=; b=CyVGi42i6laArrt//h6bABdBwDGCfrjxElHkj2cvjbI3aEeM0LVTUS0FLcbdtvq+E1sWoIexQKIidvvh2AROQpObyMQlxoOLitxLLEzu522UNw/2wgPlWD8+C6MYaarNS43CkRO8Qw6FtKhtnoxMx74KqbRkI9iiv1XMY795yYo= From: "Tian, Kevin" To: Julien Grall , "xen-devel@lists.xenproject.org" CC: "hongyxia@amazon.co.uk" , "iwj@xenproject.org" , Julien Grall , Jan Beulich , "Cooper, Andrew" , "Paul Durrant" Subject: RE: [PATCH for-4.15 v5 3/3] xen/iommu: x86: Clear the root page-table before freeing the page-tables Thread-Topic: [PATCH for-4.15 v5 3/3] xen/iommu: x86: Clear the root page-table before freeing the page-tables Thread-Index: AQHXDC4c+ANUTO2s/0S1EiKjaE2Gtqpuc4ZA Date: Mon, 1 Mar 2021 02:54:23 +0000 Message-ID: References: <20210226105640.12037-1-julien@xen.org> <20210226105640.12037-4-julien@xen.org> In-Reply-To: <20210226105640.12037-4-julien@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af38ba33-a6ff-4a48-68a5-08d8dc5d522c x-ms-traffictypediagnostic: MWHPR1101MB2224: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C70i+GBMkXR4qo9IKPpfB1vyUNBl+RGZe+cAR9f1fXTTcoOSp5D7xqntodeXP1LEttq5nGPZjSmMaH7v+UBaeLcaftAT26jJVJ2LBiArjhex2JnteAgQDrh+5lH/l2KzW8XOy0I1iuHdORxYdwM65MP6BwGVHM/953wWdoqNu+A7BX4+B5zrYi4rrrJrJEA1L/DHl+9Nwl/k+w/bLLANqUzEYrJLkRol7+WV4dAPy2lbiR6xgzsubHHh5WqNtSRwc7fB+xk5vxsG9wyPBLGcWntW9vp1T1oiDR8PbYMOJAhhEqlhQ27jGYSV2FIP9GKGc/HailukJZcP+tNbvaluNzUuDtrNhmBuCiOkwrJmKt2wIt3DW3QcR9uef7WdfIOGlXRlasrWVUBsfKSOzHDSq64ikwWwNXHnn2LO6AaIUtkBhOihuiGTCCTNcJXDYfqLYl21sc8z9McMUJ2cZfAGP2Nx9ptjRsR+Zq8ZljX3lj2TkpurJbhmf+tTD7cfopVDE8swFzImIWUJU+DN4AyzYA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1886.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(376002)(39860400002)(346002)(396003)(136003)(33656002)(186003)(71200400001)(26005)(55016002)(9686003)(8676002)(8936002)(7696005)(86362001)(478600001)(54906003)(110136005)(4326008)(52536014)(5660300002)(83380400001)(6506007)(316002)(66556008)(64756008)(66446008)(76116006)(66476007)(2906002)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?5xZbJz/vfie1WMBtStTnIqFeWn3C22Q4tbvP2vy7JsnIeO0ne5TZsKg/8cAP?= =?us-ascii?Q?vgT+4txR2h+7rl++GVrkbmAOnv6MZ6T/gqYW1YhA67B5/gslcQc6mYRbfDfx?= =?us-ascii?Q?O07uzLXMS3FunDirrIwbw59w8uLg/YwI28MQHQIIb05XfxEDvxEPDPnOwzrO?= =?us-ascii?Q?eHwh5gZFYnhYIRxoTOoq+t/oeRaROP57aBlMouo0pmQLb7XPzxWeN3a0mTsI?= =?us-ascii?Q?j8Ek0xUL2P98ZrW9lhdNgqSfgDROzaROl3cbKrUs8l/h6E573oNM+od1kFS0?= =?us-ascii?Q?CGM771cL80Rm5bX/az5HgP33UukkJRbfOxeHVPWAijekrErjOq0zS91dI9vH?= =?us-ascii?Q?BPRUlBgkZ4uKUZtmPmyB6bMzd52+FwtKb4hQ1CA21PPACJp0tyyNGw6XoCAH?= =?us-ascii?Q?dq2CMfYukd+S74UscqOuQ6mgRvhLewYPxyxXoB721i7jhBCgfdlp0tvhv9Dc?= =?us-ascii?Q?sav324gRs9ciIlO6s/RbgmFEYzNQEq6ImC4yLU2w/hB88goa6TQZ+AB2bK9M?= =?us-ascii?Q?+feRaP+caxU9qjXUHNK87hKfufQCw1RtQWpN7psPVEEH0XH71w1r2TmFnuhk?= =?us-ascii?Q?bWmKKEyJDFDqOj8dyvVQYPHZ3yC77TPr2GqnEcMGCl51gnSuLk5BajkphmMM?= =?us-ascii?Q?U7CnkFX39+2VhgnOTSBC9Aqh5RQL0/PMR/xV+7sQ9Rp/Fee3JEz6Q9GW/CAb?= =?us-ascii?Q?E72XaYokstAJG3JZxxb+TXIijziS4LVpXwyRNXkA571eOueLdVAvubVytpib?= =?us-ascii?Q?s4XEejs4wtuWbqrnJqf5yOe1L1L1N5k8j3HWmSWDiRlEzxS9avdxo5xadHRh?= =?us-ascii?Q?Cv2ex4By9qKtTa0Uqu324ZkpJ97nKAzBvoGVWI7t3dOo6U3z6nV+TKz7OcoC?= =?us-ascii?Q?NXj6u8AwX7ysc4gb7Mhfl4eQL3j4JMuc/swvmBTMCgtPZFwxfE+1ZiB9g8Yt?= =?us-ascii?Q?jzUKmb+W34wR3baWJ2Wb7yPcDguUT9RfKiReUiFL+jzjg7iToTonCYQokvZB?= =?us-ascii?Q?jOwzXFXY6Jcf9ENDbXgmTe04ospprJdUscciAbF+51+FgwBwb5J7Tm4pbEGq?= =?us-ascii?Q?VHhH8H79n9cTzBLqgHkniIf60jDLO8QLkmps09Cl9DEwva555CW12bf57cXi?= =?us-ascii?Q?QWHQ5486mVYMikMIDnzjRrgLTBQ8PDmla5CTkxBtSkDXW1BRr8gCTuZac+fw?= =?us-ascii?Q?FaTVUvx50OQMBNdEQynz7KQvDZocq3mDR2OHfyvfYw/MnXe/6x/oLUwHK4rS?= =?us-ascii?Q?/zy+qWnV0C+c4yRGbw0oSC7wXA112zKiH5jXZKgP9VHZb96rqFHh9YTSIf0q?= =?us-ascii?Q?FrCrhkqLkI9NvexUb4QkGvXw?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af38ba33-a6ff-4a48-68a5-08d8dc5d522c X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2021 02:54:24.0077 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NNn23MbGZXo8rApACwhA6kbh7yPQ0WUYxCQUw7cFiwC/XPjEINZwG/X6j4llX0SR+s5++/LuD+LIqtqsRAt0Iw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2224 X-OriginatorOrg: intel.com > From: Julien Grall > Sent: Friday, February 26, 2021 6:57 PM >=20 > From: Julien Grall >=20 > The new per-domain IOMMU page-table allocator will now free the > page-tables when domain's resources are relinquished. However, the > per-domain IOMMU structure will still contain a dangling pointer to > the root page-table. >=20 > Xen may access the IOMMU page-tables afterwards at least in the case of > PV domain: >=20 > (XEN) Xen call trace: > (XEN) [] R > iommu.c#addr_to_dma_page_maddr+0x12e/0x1d8 > (XEN) [] F > iommu.c#intel_iommu_unmap_page+0x5d/0xf8 > (XEN) [] F iommu_unmap+0x9c/0x129 > (XEN) [] F iommu_legacy_unmap+0x26/0x63 > (XEN) [] F mm.c#cleanup_page_mappings+0x139/0x144 > (XEN) [] F put_page+0x4b/0xb3 > (XEN) [] F put_page_from_l1e+0x136/0x13b > (XEN) [] F devalidate_page+0x256/0x8dc > (XEN) [] F mm.c#_put_page_type+0x236/0x47e > (XEN) [] F mm.c#put_pt_page+0x6f/0x80 > (XEN) [] F mm.c#put_page_from_l2e+0x8a/0xcf > (XEN) [] F devalidate_page+0x3a3/0x8dc > (XEN) [] F mm.c#_put_page_type+0x236/0x47e > (XEN) [] F mm.c#put_pt_page+0x6f/0x80 > (XEN) [] F mm.c#put_page_from_l3e+0x8a/0xcf > (XEN) [] F devalidate_page+0x56c/0x8dc > (XEN) [] F mm.c#_put_page_type+0x236/0x47e > (XEN) [] F mm.c#put_pt_page+0x6f/0x80 > (XEN) [] F mm.c#put_page_from_l4e+0x69/0x6d > (XEN) [] F devalidate_page+0x6a0/0x8dc > (XEN) [] F mm.c#_put_page_type+0x236/0x47e > (XEN) [] F put_page_type_preemptible+0x13/0x15 > (XEN) [] F domain.c#relinquish_memory+0x1ff/0x4e9 > (XEN) [] F domain_relinquish_resources+0x2b6/0x36a > (XEN) [] F domain_kill+0xb8/0x141 > (XEN) [] F do_domctl+0xb6f/0x18e5 > (XEN) [] F pv_hypercall+0x2f0/0x55f > (XEN) [] F lstar_enter+0x112/0x120 >=20 > This will result to a use after-free and possibly an host crash or > memory corruption. >=20 > It would not be possible to free the page-tables further down in > domain_relinquish_resources() because cleanup_page_mappings() will only > be called when the last reference on the page dropped. This may happen > much later if another domain still hold a reference. >=20 > After all the PCI devices have been de-assigned, nobody should use the > IOMMU page-tables and it is therefore pointless to try to modify them. >=20 > So we can simply clear any reference to the root page-table in the > per-domain IOMMU structure. This requires to introduce a new callback of > the method will depend on the IOMMU driver used. >=20 > Take the opportunity to add an ASSERT() in arch_iommu_domain_destroy() > to check if we freed all the IOMMU page tables. >=20 > Fixes: 3eef6d07d722 ("x86/iommu: convert VT-d code to use new page table > allocator") > Signed-off-by: Julien Grall > Reviewed-by: Jan Beulich Reviewed-by: Kevin Tian >=20 > --- > Changes in v5: > - Add Jan's reviewed-by > - Fix typo > - Use ! rather than =3D=3D NULL >=20 > Changes in v4: > - Move the patch later in the series as we need to prevent > iommu_map() to allocate memory first. > - Add an ASSERT() in arch_iommu_domain_destroy(). >=20 > Changes in v3: > - Move the patch earlier in the series > - Reword the commit message >=20 > Changes in v2: > - Introduce clear_root_pgtable() > - Move the patch later in the series > --- > xen/drivers/passthrough/amd/pci_amd_iommu.c | 12 +++++++++++- > xen/drivers/passthrough/vtd/iommu.c | 12 +++++++++++- > xen/drivers/passthrough/x86/iommu.c | 13 +++++++++++++ > xen/include/xen/iommu.h | 1 + > 4 files changed, 36 insertions(+), 2 deletions(-) >=20 > diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c > b/xen/drivers/passthrough/amd/pci_amd_iommu.c > index 42b5a5a9bec4..085fe2f5771e 100644 > --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c > +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c > @@ -381,9 +381,18 @@ static int amd_iommu_assign_device(struct domain > *d, u8 devfn, > return reassign_device(pdev->domain, d, devfn, pdev); > } >=20 > +static void amd_iommu_clear_root_pgtable(struct domain *d) > +{ > + struct domain_iommu *hd =3D dom_iommu(d); > + > + spin_lock(&hd->arch.mapping_lock); > + hd->arch.amd.root_table =3D NULL; > + spin_unlock(&hd->arch.mapping_lock); > +} > + > static void amd_iommu_domain_destroy(struct domain *d) > { > - dom_iommu(d)->arch.amd.root_table =3D NULL; > + ASSERT(!dom_iommu(d)->arch.amd.root_table); > } >=20 > static int amd_iommu_add_device(u8 devfn, struct pci_dev *pdev) > @@ -565,6 +574,7 @@ static const struct iommu_ops __initconstrel > _iommu_ops =3D { > .remove_device =3D amd_iommu_remove_device, > .assign_device =3D amd_iommu_assign_device, > .teardown =3D amd_iommu_domain_destroy, > + .clear_root_pgtable =3D amd_iommu_clear_root_pgtable, > .map_page =3D amd_iommu_map_page, > .unmap_page =3D amd_iommu_unmap_page, > .iotlb_flush =3D amd_iommu_flush_iotlb_pages, > diff --git a/xen/drivers/passthrough/vtd/iommu.c > b/xen/drivers/passthrough/vtd/iommu.c > index b549a71530d5..475efb3be3bd 100644 > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -1726,6 +1726,15 @@ out: > return ret; > } >=20 > +static void iommu_clear_root_pgtable(struct domain *d) > +{ > + struct domain_iommu *hd =3D dom_iommu(d); > + > + spin_lock(&hd->arch.mapping_lock); > + hd->arch.vtd.pgd_maddr =3D 0; > + spin_unlock(&hd->arch.mapping_lock); > +} > + > static void iommu_domain_teardown(struct domain *d) > { > struct domain_iommu *hd =3D dom_iommu(d); > @@ -1740,7 +1749,7 @@ static void iommu_domain_teardown(struct > domain *d) > xfree(mrmrr); > } >=20 > - hd->arch.vtd.pgd_maddr =3D 0; > + ASSERT(!hd->arch.vtd.pgd_maddr); > } >=20 > static int __must_check intel_iommu_map_page(struct domain *d, dfn_t dfn= , > @@ -2731,6 +2740,7 @@ static struct iommu_ops __initdata vtd_ops =3D { > .remove_device =3D intel_iommu_remove_device, > .assign_device =3D intel_iommu_assign_device, > .teardown =3D iommu_domain_teardown, > + .clear_root_pgtable =3D iommu_clear_root_pgtable, > .map_page =3D intel_iommu_map_page, > .unmap_page =3D intel_iommu_unmap_page, > .lookup_page =3D intel_iommu_lookup_page, > diff --git a/xen/drivers/passthrough/x86/iommu.c > b/xen/drivers/passthrough/x86/iommu.c > index ad19b7dd461c..b90bb31bfeea 100644 > --- a/xen/drivers/passthrough/x86/iommu.c > +++ b/xen/drivers/passthrough/x86/iommu.c > @@ -149,6 +149,13 @@ int arch_iommu_domain_init(struct domain *d) >=20 > void arch_iommu_domain_destroy(struct domain *d) > { > + /* > + * There should be not page-tables left allocated by the time the > + * domain is destroyed. Note that arch_iommu_domain_destroy() is > + * called unconditionally, so pgtables may be uninitialized. > + */ > + ASSERT(!dom_iommu(d)->platform_ops || > + page_list_empty(&dom_iommu(d)->arch.pgtables.list)); > } >=20 > static bool __hwdom_init hwdom_iommu_map(const struct domain *d, > @@ -273,6 +280,12 @@ int iommu_free_pgtables(struct domain *d) > /* After this barrier, no new IOMMU mappings can be inserted. */ > spin_barrier(&hd->arch.mapping_lock); >=20 > + /* > + * Pages will be moved to the free list below. So we want to > + * clear the root page-table to avoid any potential use after-free. > + */ > + hd->platform_ops->clear_root_pgtable(d); > + > while ( (pg =3D page_list_remove_head(&hd->arch.pgtables.list)) ) > { > free_domheap_page(pg); > diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h > index 863a68fe1622..d59ed7cbad43 100644 > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -272,6 +272,7 @@ struct iommu_ops { >=20 > int (*adjust_irq_affinities)(void); > void (*sync_cache)(const void *addr, unsigned int size); > + void (*clear_root_pgtable)(struct domain *d); > #endif /* CONFIG_X86 */ >=20 > int __must_check (*suspend)(void); > -- > 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 03:56:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 03:56:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91235.172344 (Exim 4.92) (envelope-from ) id 1lGZfa-00057b-Jj; Mon, 01 Mar 2021 03:56:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91235.172344; Mon, 01 Mar 2021 03:56:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGZfa-00057U-Fl; Mon, 01 Mar 2021 03:56:30 +0000 Received: by outflank-mailman (input) for mailman id 91235; Mon, 01 Mar 2021 03:56:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGZfY-00057M-Tf; Mon, 01 Mar 2021 03:56:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGZfY-0006fU-JD; Mon, 01 Mar 2021 03:56:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGZfY-0001rl-8A; Mon, 01 Mar 2021 03:56:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lGZfY-0006kF-7P; Mon, 01 Mar 2021 03:56:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BtME82R2kI0NQl2A89GyFJNKV6tKmcVUIqWuSMRUqas=; b=GE2Fht8SqI5wdqxciaRhddLfau 24LIBFg44by+XE1JGU3iEat0RPfVaw3cvTVdMM1zWjvn/ddGGl1/DMOqnD95JWPZYpCPM03c5yvEo HFB7WpC3QkbcfbUHV6WL5uwh+T4NZy9DB89RUbuWHJCpmNoZKNDZ7u9lCDt7NLdIMupc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159786: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=5695e51619745d4fe3ec2506a2f0cd982c5e27a4 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 01 Mar 2021 03:56:28 +0000 flight 159786 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159786/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux 5695e51619745d4fe3ec2506a2f0cd982c5e27a4 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 212 days Failing since 152366 2020-08-01 20:49:34 Z 211 days 365 attempts Testing same since 159781 2021-02-28 03:37:54 Z 1 days 2 attempts ------------------------------------------------------------ 5130 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1268443 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 01 06:08:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 06:08:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91244.172359 (Exim 4.92) (envelope-from ) id 1lGbj9-0001Dj-9H; Mon, 01 Mar 2021 06:08:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91244.172359; Mon, 01 Mar 2021 06:08:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGbj9-0001Dc-5z; Mon, 01 Mar 2021 06:08:19 +0000 Received: by outflank-mailman (input) for mailman id 91244; Mon, 01 Mar 2021 06:08:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGbj8-0001DX-GE for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 06:08:18 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 235ddf9c-572c-41ca-b4c3-60119b80160c; Mon, 01 Mar 2021 06:08:17 +0000 (UTC) Received: from pps.filterd (m0174681.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12167Bb9009863; Mon, 1 Mar 2021 06:08:15 GMT Received: from eur01-db5-obe.outbound.protection.outlook.com (mail-db5eur01lp2058.outbound.protection.outlook.com [104.47.2.58]) by mx0b-0039f301.pphosted.com with ESMTP id 36ymwuuep7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Mar 2021 06:08:15 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17) by AM0PR03MB4147.eurprd03.prod.outlook.com (2603:10a6:208:cf::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.23; Mon, 1 Mar 2021 06:08:13 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::6156:8f40:92f3:de55]) by AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::6156:8f40:92f3:de55%8]) with mapi id 15.20.3890.028; Mon, 1 Mar 2021 06:08:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 235ddf9c-572c-41ca-b4c3-60119b80160c ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NbItb5ix7MwQv5oAs5/YF3nvJgCIs6lbqvWnv1B2+kj+D8NuQaafqKO50fNfQilfTNEo1GPGgT7/X8MMSKrMqx0r5B9yIccuxb68xlVQ00KMYcC63skGkUyaKKH6zDj7+HU3WVj9ZvkWW2nGeBnlN04tejl7SdbWSLmxKr8S3Vt+BCznVltkoZhefb0L8VEVQCTPAmJ2g+6jQXk8niSti2eXKVlKJP2rrBSSLu4TNwAxlK82dVA6AKC9SIWQwjtiMUz+PXFZd7WxYdi3etkR5K2ruzOf0nHAGxhKIoW4GI9Q0zTTq7JuaYqDNVafQaVvBu0nbEADfgzuGtmEJ/In8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MiSnG0ZCZwzJDbpZtCiJDkQf60zQman8rTk5+V8RSw0=; b=hhs0OmO6m7b+FksGUjWiP8hRJ90P+RVBb+04Da3Fp5nOuf72jiYmbqRAjsiUXue2+Wo55yYsf0ODW5DZQ7TxHhZkqNUZL6+DgOpG2T5SYMgeaRL3g1c9rQfVYgHFQTAFpSewFW1d1TMaBMt9SP5RfshBTCQfgPH6Gvxg6NxefqrM5xv9O/GkNmp4BIps69lfW2xgmazkW1nQzziiDJsV+stV6nCtsgZk/ByeztqrRnJF1d0T/9EjiH6bTozQS/vkSQloFVh8sDkJnRA47Mk/owHGLmdxnJiCEUM7B8nlkF/Ec6dLd9zwesOS00j+Xeal6iJbx26/uOFJRnTFRof7FA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MiSnG0ZCZwzJDbpZtCiJDkQf60zQman8rTk5+V8RSw0=; b=yjUdPxV87FpS6+R3n6/figK1m33dER7SYW9dSkKYpkuHbzi91sGGzEWnzcCXzLdwF+jXC+lo7coFbLn9EhiHRQLz2eR2YNRIu5SYfQY/qb9E++yxNEvdXApvzjD11mq2TX/aqOBq77KvF5iU91ufgJQbgcBA55mh6pSIP78KfOnh1pzPi1CGOYAlM+jHcQbcTH3wLi27y3TwpEM5yvputCUuUyUTnZgOgrPmIIwXQ0Hk/ZZraihL3ls9q6XVlIX+UVjYpCZtzVPTFQLReAlqy1qm+/3ebMljX3RDWLh8HceqdFMwHPlqyO2xmvYdSWuIHv59/oYwRmQBhBmYL8TMew== From: Oleksandr Andrushchenko To: Daniel Vetter CC: Jan Beulich , "xen-devel@lists.xenproject.org" , "dri-devel@lists.freedesktop.org" Subject: Re: [PATCH] drm/xen: adjust Kconfig Thread-Topic: [PATCH] drm/xen: adjust Kconfig Thread-Index: AQHXCgKuZuE2hAvl4Eu58Fslz5uDM6pm3hiAgACe54CABzF/gA== Date: Mon, 1 Mar 2021 06:08:12 +0000 Message-ID: References: <54ae54f9-1ba9-900b-a56f-f48e2c9a82b0@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: ffwll.ch; dkim=none (message not signed) header.d=none;ffwll.ch; dmarc=none action=none header.from=epam.com; x-originating-ip: [185.199.97.5] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 852417ba-da1c-4774-8a2a-08d8dc786546 x-ms-traffictypediagnostic: AM0PR03MB4147: x-ms-exchange-minimumurldomainage: lists.freedesktop.org#0 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AL3OnfzBFAzPKifTyLHPVhKHXx6AcK/VQ0/T9V6cjBwfNsC9q6O1Qr0gGDudN9jmQCYNirWj5DFOowhFZSIn8EmQsUrXdKts2IPfOQL1f0Zu9YqWu1LG0u7DBCwqYFW6tye9I3Re4juow0WJQt3zdXgdvUijfA1zPMIqC7BkF6nOk2GGKEwUEllPSY4S+lSEAz9xVmhzTn5EBJixlbuXwehsg8kV/o89jw6cZO1ZU3PBdfvxcTP+6T7eq9Ivt7zqwP55vMMEjgCPLEGtmWaVVsSdd+yAB/iFRyXpElNkakLgMcKqrO3xh77ApnROb0fYNiyp84/m27kBf0RcqXn+HvFmZv4JKjcoKt7/q42BxXM7Ycvm7o5hSoBdC880veekRiadAOZpaM9Xgq3lRSLZd/BYZOWQMh8CtNmc9X47fgvyQLr40PhLCDIj4Uz2laklDaE4hHXqHD4t8dJTiVizfvHfqihNfXdgNxuplMeiC8uZaNY4FBs0DJd/f/ERhZfTCm3rTTjObKms3DC3UpKFbwowx4bdPEd1GzWULcsj6mymo/8t5Gfjm1kcse9yJHFB+puzPRawbhAMi7kKMUdvhcWfZ8PjqKdw1AV6TcefT+fFSwyogX5QqSGSV0WZKuSy x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(76116006)(8676002)(71200400001)(4326008)(26005)(31696002)(66946007)(478600001)(966005)(5660300002)(66476007)(6486002)(2616005)(6512007)(186003)(2906002)(6506007)(36756003)(64756008)(83380400001)(66556008)(316002)(6916009)(8936002)(54906003)(66446008)(86362001)(31686004)(53546011)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?dnNZQTE1ZWI3bUV4WVlESnBidkpEL2hia3lGdDFQR2p6K2RPdWtDL3kxY3hW?= =?utf-8?B?TEFZVFhwUm9sa0tXM0hzM1VjOUxqYWtNQ2ZEYUYzMDZJQnh1eHZBRE9DTzI4?= =?utf-8?B?UkNPeWJ4dDZkNVMxb2szS3o4K2xvQlkyRmo4WmJiUFRMdVU2T0ZRSDlHVVFz?= =?utf-8?B?UlB5OElwZ25PdjBzL2ZIYmtDbTNLRU1taVo0TktIbGFncGppeTM5b0lNOHJr?= =?utf-8?B?azlvWWNLeW9OOWpJSHNPY0pEdTNEeG4vVm5HOStSZ0NIMnVlNWZnYU9FNUI0?= =?utf-8?B?L0RPZUMzLzg1VG5keUJTd081b1BMSTRCUmlkYnAwOTUrcWMwVWsvaGsxNE1T?= =?utf-8?B?alMvMFVUZnc2L0U2UTFDcUNaeHRkeHpxcWI1WS83WHYxMDdKWmFkekVKOGV0?= =?utf-8?B?a1NkRWp1NW5hODJxQVNkTFVUQjAxRmdoL0lhcXAwek5HR3BVbzBjOGdYSDZ6?= =?utf-8?B?UDkxQXFSNU5MVjB3TjlJL2g0cXUzTml5b05YS3JyQWs3MkVvWFBWYWlIZXBM?= =?utf-8?B?QkRBbnBYMUt0WjdlYTRqZjhTdDU1ODlvd1NJcHI4MHIra2FhdTM0WFVlbFBj?= =?utf-8?B?NURQNEtqdXJqVW5FaWJtaXpoVktncG1IQ0FqblIvb2lXcVdQVlNhem0yNzVE?= =?utf-8?B?SGZwUVk5WmZMMzhMalVSRFBOaW1TdjFXTFlLeGE5aUlSRHM2b0hMSy9TZjJZ?= =?utf-8?B?YWlnd2M2N3dHekpNbTdCTk9wY0dFTDlCZFlmb2ZUaHl5dXEvR3VwUG1EL2s2?= =?utf-8?B?KzhGRTE1dG1QR3pnZHAzMjE1Q05IV3cwdEZnK2dIaHM1em42aHduNkdhUk55?= =?utf-8?B?amlpelQ5YVcrY00xaXJkY0dCTlBMRkJDZWdndkdxbzdVUEYxSFJzZU9odG55?= =?utf-8?B?RFhvL3pUVHVSTGVyTk1OaUw5d3lVNFVuTTdnczIxZUVDQWJPcXN1ajdjZGpI?= =?utf-8?B?YkJ3UlVlbmJTdTNFTzFEM1g2NFRjb3FrRTZwR0R6UllxclIvL3lKNGtQWFJW?= =?utf-8?B?VjdESDdIdFFWRzZNL3FhM0YvUVBKNG5aSzI5aDk0YUdGVC9yUjRhS3hha3hu?= =?utf-8?B?WDNJTGgyTTdRNUdlaXdXc0FsZ0FkUDRmaEpwNm96a2RmZ1l2R2l4eHY3OExC?= =?utf-8?B?WTBZaXhhQWxXTWJqQzNWUnZ3dksydjczcFBOa0IvUm1IVUtqQlpWY09LTm1X?= =?utf-8?B?UjZod2liUVMwemx5MTZpSGk1dkRyNTV3Tmc0T1QzV1BuZ3NTOEpmRUw3eW5x?= =?utf-8?B?M2MxRGdxZ1FsTW5IazVDZURDbk1YZlZ6UFZLOU5xSllVVlYrN2piV2lqQXhl?= =?utf-8?B?R0IvT0xWbDZkUlZqNEJMb1dWTnJ3aGRONktTU05OcndDVVNqZUQvUkZ3QkVy?= =?utf-8?B?bGF2TGRxMFlUUGJ1Snl5dVdPbHFsVEpSQ1B1ejVyaW9uZUVMcTQ0N1hPbUhJ?= =?utf-8?B?b2p4TlZySVFaVzZpRWExSy9HWEdlQm13RjBYaFhQYnhKdzdhd21KYWVVc052?= =?utf-8?B?RTRIUUtIOFhmbVQydjlIVzJVZmRWVThNU0tPSDNoOEdGeDVzUHhybDhWaHFj?= =?utf-8?B?L0pUSlB4QnBYZjB0c055UHdPL1cwb3NYaGo5TGgwRy9yakVZd1NKNXJlbGY1?= =?utf-8?B?eEM4VWNVNUxRRXgvUHBZTnpHY01POHVETjBoV0ZCSkNCdVM5ZThRS1gwT3lx?= =?utf-8?B?Mmg2UFlVUGFLZjkrd2VtbHM0ZHZZcmdBKzk1aWFlK0FLQTY4bnRIZ2ZMTlpZ?= =?utf-8?Q?l2pRcp75Mlmek5OExQ3AmxDhuOIBu54SjuCbNiC?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 852417ba-da1c-4774-8a2a-08d8dc786546 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2021 06:08:12.5954 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9kgj6Q3dlN70/iETMojAfONpIJ39qX9i7GlKoUw/VDwH3PJwT+4r+5LoHPcHx5YoGtG9jezSVll1b/2JIXeh9dyg/HRqjsxjj8nhz2J9Lip+FaTEb/cLAEbjnz8a/9JA X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4147 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 phishscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103010050 DQpPbiAyLzI0LzIxIDY6MTcgUE0sIERhbmllbCBWZXR0ZXIgd3JvdGU6DQo+IE9uIFdlZCwgRmVi IDI0LCAyMDIxIGF0IDg6NTUgQU0gT2xla3NhbmRyIEFuZHJ1c2hjaGVua28NCj4gPE9sZWtzYW5k cl9BbmRydXNoY2hlbmtvQGVwYW0uY29tPiB3cm90ZToNCj4+IEhlbGxvLCBKYW4hDQo+Pg0KPj4g T24gMi8yMy8yMSA2OjQxIFBNLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+PiBCeSBoYXZpbmcgc2Vs ZWN0ZWQgRFJNX1hFTiwgSSB3YXMgYXNzdW1pbmcgSSB3b3VsZCBidWlsZCB0aGUgZnJvbnRlbmQN Cj4+PiBkcml2ZXIuIEFzIGl0IHR1cm5zIG91dCB0aGlzIGlzIGEgZHVtbXkgb3B0aW9uLCBhbmQg SSBoYXZlIHJlYWxseSBub3QNCj4+PiBiZWVuIGJ1aWxkaW5nIHRoaXMgKGJlY2F1c2UgSSBoYWQg RFJNIGRpc2FibGVkKS4gTWFrZSBpdCBhIHByb21wdGxlc3MNCj4+PiBvbmUsIG1vdmluZyB0aGUg ImRlcGVuZHMgb24iIHRvIHRoZSBvdGhlciwgcmVhbCBvcHRpb24sIGFuZCAic2VsZWN0ImluZw0K Pj4+IHRoZSBkdW1teSBvbmUuDQo+Pj4NCj4+PiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8 amJldWxpY2hAc3VzZS5jb20+DQo+PiBSZXZpZXdlZC1ieTogT2xla3NhbmRyIEFuZHJ1c2hjaGVu a28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPiBTaW5jZSB5b3UncmUgbWFp bnRhaW5lci9jb21taXR0ZXIsIEknbSBhc3N1bWluZyB5b3UnbGwgYWxzbyBtZXJnZQ0KPiB0aGlz PyBBbHdheXMgY29uZnVzaW5nIHdoZW4gdGhlcmUncyBhbiByLWIgYnV0IG5vdGhpbmcgYWJvdXQg d2hldGhlcg0KPiB0aGUgcGF0Y2ggd2lsbCBnZXQgbWVyZ2VkIG9yIG5vdC4NCg0KQXBwbGllZCB0 byBkcm0tbWlzYy1uZXh0LA0KDQp0aGFuayB5b3UNCg0KPiAtRGFuaWVsDQo+DQo+Pj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL3hlbi9LY29uZmlnDQo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3hl bi9LY29uZmlnDQo+Pj4gQEAgLTEsMTUgKzEsMTEgQEANCj4+PiAgICAjIFNQRFgtTGljZW5zZS1J ZGVudGlmaWVyOiBHUEwtMi4wLW9ubHkNCj4+PiAgICBjb25maWcgRFJNX1hFTg0KPj4+IC0gICAg IGJvb2wgIkRSTSBTdXBwb3J0IGZvciBYZW4gZ3Vlc3QgT1MiDQo+Pj4gLSAgICAgZGVwZW5kcyBv biBYRU4NCj4+PiAtICAgICBoZWxwDQo+Pj4gLSAgICAgICBDaG9vc2UgdGhpcyBvcHRpb24gaWYg eW91IHdhbnQgdG8gZW5hYmxlIERSTSBzdXBwb3J0DQo+Pj4gLSAgICAgICBmb3IgWGVuLg0KPj4+ ICsgICAgIGJvb2wNCj4+Pg0KPj4+ICAgIGNvbmZpZyBEUk1fWEVOX0ZST05URU5EDQo+Pj4gICAg ICAgIHRyaXN0YXRlICJQYXJhLXZpcnR1YWxpemVkIGZyb250ZW5kIGRyaXZlciBmb3IgWGVuIGd1 ZXN0IE9TIg0KPj4+IC0gICAgIGRlcGVuZHMgb24gRFJNX1hFTg0KPj4+IC0gICAgIGRlcGVuZHMg b24gRFJNDQo+Pj4gKyAgICAgZGVwZW5kcyBvbiBYRU4gJiYgRFJNDQo+Pj4gKyAgICAgc2VsZWN0 IERSTV9YRU4NCj4+PiAgICAgICAgc2VsZWN0IERSTV9LTVNfSEVMUEVSDQo+Pj4gICAgICAgIHNl bGVjdCBWSURFT01PREVfSEVMUEVSUw0KPj4+ICAgICAgICBzZWxlY3QgWEVOX1hFTkJVU19GUk9O VEVORA0KPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18N Cj4+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QNCj4+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcNCj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbF9fOyEhR0ZfMjlkYmNRSVVCUEEh bDhJVG55bHZqbjNUdUFOTGFodHJ5ZUxKaGpIMjBpLTlPaV8xdFlrZEE1OXZYVXBCSHRLbmxRLUtn LXpVUldfcnVVa0tLYVVBWlEkIFtsaXN0c1suXWZyZWVkZXNrdG9wWy5db3JnXQ0KPg0KPg== From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:45:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:45:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91258.172383 (Exim 4.92) (envelope-from ) id 1lGdEv-0002VZ-O5; Mon, 01 Mar 2021 07:45:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91258.172383; Mon, 01 Mar 2021 07:45:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdEv-0002VQ-Kf; Mon, 01 Mar 2021 07:45:13 +0000 Received: by outflank-mailman (input) for mailman id 91258; Mon, 01 Mar 2021 07:45:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdEu-0002U2-8f for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:45:12 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e972874d-e2ae-475e-9525-0ade0ca379b4; Mon, 01 Mar 2021 07:45:05 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdEa-00FR4x-UN; Mon, 01 Mar 2021 07:44:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e972874d-e2ae-475e-9525-0ade0ca379b4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=jOUIvbpH1p3Q/dfE+7zDHmmKowLb7E/HssGmywq4qaM=; b=iiWXchTzp1z6tMwlARGVdg7qFd Jl5fCXY5v6vpmDrkF3TdnBigIdjyRi1EYbprKN/1D4IWDPlTOnJ7qGmZuPx8fCSdhV6gYXkdVXilz lMRq0qveYM+qGvCgIg+kOUnvXAV2GvvUvDQNP6xUFLQw1EBbP4PWEhY5Dt7Efsr5yOvBwA+G5tdDL IXM4bsZPzfNakZV6/kSBDPUsMIZLv9Shumi2xDaFpURz7TXDi9YPfYWJ+n8Xb4hRpph8JY36bzgpN I1aPhiWMrPFf4XDSHTeM18WNJetLSA8Rk2qjCMPvrj9Zx9X1OfH9nLC1/QFByOA9CBTSSNP3VF0/O sAzslN5g==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 01/14] powerpc/svm: stop using io_tlb_start Date: Mon, 1 Mar 2021 08:44:23 +0100 Message-Id: <20210301074436.919889-2-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301074436.919889-1-hch@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Use the local variable that is passed to swiotlb_init_with_tbl for freeing the memory in the failure case to isolate the code a little better from swiotlb internals. Signed-off-by: Christoph Hellwig --- arch/powerpc/platforms/pseries/svm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/pseries/svm.c b/arch/powerpc/platforms/pseries/svm.c index 7b739cc7a8a93e..1d829e257996fb 100644 --- a/arch/powerpc/platforms/pseries/svm.c +++ b/arch/powerpc/platforms/pseries/svm.c @@ -55,9 +55,9 @@ void __init svm_swiotlb_init(void) if (vstart && !swiotlb_init_with_tbl(vstart, io_tlb_nslabs, false)) return; - if (io_tlb_start) - memblock_free_early(io_tlb_start, - PAGE_ALIGN(io_tlb_nslabs << IO_TLB_SHIFT)); + + memblock_free_early(__pa(vstart), + PAGE_ALIGN(io_tlb_nslabs << IO_TLB_SHIFT)); panic("SVM: Cannot allocate SWIOTLB buffer"); } -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:45:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:45:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91259.172395 (Exim 4.92) (envelope-from ) id 1lGdF1-0002Yc-0l; Mon, 01 Mar 2021 07:45:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91259.172395; Mon, 01 Mar 2021 07:45:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdF0-0002YT-Tq; Mon, 01 Mar 2021 07:45:18 +0000 Received: by outflank-mailman (input) for mailman id 91259; Mon, 01 Mar 2021 07:45:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdEz-0002U2-8p for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:45:17 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7de0bb2f-46fe-43ad-b5f7-e752f15ae060; Mon, 01 Mar 2021 07:45:13 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdEi-00FR5G-79; Mon, 01 Mar 2021 07:45:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7de0bb2f-46fe-43ad-b5f7-e752f15ae060 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=tKaBu0f6sdjk6bNW9s6/VvP1+ZEbLxuaNFQMHAfVp5Q=; b=tKh68XQqoLQiyHvT+9s1iAuWb2 A5FHu4Y6qdjG086l6/NN4x9mA8n+M0pOWZfnYJ9MIs+c2dF9phYH13gQTwrBdGbDygjmQEB5aQ6gF FxLIE7L6N3XRkmMcDsP2rOd3gZFrjhkzFt0/gUTcIe6o8Nn5gFpgG+aEcKvT8pMEh9FFy0RrINRpi 8+9SrARqXNgIkfp0fvZ72NB6BSU7FRO1tCOwwexDYXjY0p6pS0BBHifNAGlXCOHfbfTbfW1o2k9wz VNO74OsM9eHlp+EhF0Og7xcINd/5VkklKfsO0g9ny3Vj4yGHzy0GJpxvy3jmjQapduX5elWVYyn8j TBscHQNg==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 02/14] swiotlb: remove the alloc_size parameter to swiotlb_tbl_unmap_single Date: Mon, 1 Mar 2021 08:44:24 +0100 Message-Id: <20210301074436.919889-3-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301074436.919889-1-hch@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Now that swiotlb remembers the allocation size there is no need to pass it back to swiotlb_tbl_unmap_single. Signed-off-by: Christoph Hellwig --- drivers/iommu/dma-iommu.c | 11 +++------- drivers/xen/swiotlb-xen.c | 4 ++-- include/linux/swiotlb.h | 1 - kernel/dma/direct.h | 2 +- kernel/dma/swiotlb.c | 45 ++++++++++++++++++++------------------- 5 files changed, 29 insertions(+), 34 deletions(-) diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index 9ab6ee22c11088..da2bd8f0885e6e 100644 --- a/drivers/iommu/dma-iommu.c +++ b/drivers/iommu/dma-iommu.c @@ -493,8 +493,6 @@ static void __iommu_dma_unmap_swiotlb(struct device *dev, dma_addr_t dma_addr, unsigned long attrs) { struct iommu_domain *domain = iommu_get_dma_domain(dev); - struct iommu_dma_cookie *cookie = domain->iova_cookie; - struct iova_domain *iovad = &cookie->iovad; phys_addr_t phys; phys = iommu_iova_to_phys(domain, dma_addr); @@ -504,8 +502,7 @@ static void __iommu_dma_unmap_swiotlb(struct device *dev, dma_addr_t dma_addr, __iommu_dma_unmap(dev, dma_addr, size); if (unlikely(is_swiotlb_buffer(phys))) - swiotlb_tbl_unmap_single(dev, phys, size, - iova_align(iovad, size), dir, attrs); + swiotlb_tbl_unmap_single(dev, phys, size, dir, attrs); } static bool dev_is_untrusted(struct device *dev) @@ -580,10 +577,8 @@ static dma_addr_t __iommu_dma_map_swiotlb(struct device *dev, phys_addr_t phys, } iova = __iommu_dma_map(dev, phys, aligned_size, prot, dma_mask); - if ((iova == DMA_MAPPING_ERROR) && is_swiotlb_buffer(phys)) - swiotlb_tbl_unmap_single(dev, phys, org_size, - aligned_size, dir, attrs); - + if (iova == DMA_MAPPING_ERROR && is_swiotlb_buffer(phys)) + swiotlb_tbl_unmap_single(dev, phys, org_size, dir, attrs); return iova; } diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 2b385c1b4a99cb..d47f1b311caac0 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -406,7 +406,7 @@ static dma_addr_t xen_swiotlb_map_page(struct device *dev, struct page *page, * Ensure that the address returned is DMA'ble */ if (unlikely(!dma_capable(dev, dev_addr, size, true))) { - swiotlb_tbl_unmap_single(dev, map, size, size, dir, + swiotlb_tbl_unmap_single(dev, map, size, dir, attrs | DMA_ATTR_SKIP_CPU_SYNC); return DMA_MAPPING_ERROR; } @@ -445,7 +445,7 @@ static void xen_swiotlb_unmap_page(struct device *hwdev, dma_addr_t dev_addr, /* NOTE: We use dev_addr here, not paddr! */ if (is_xen_swiotlb_buffer(hwdev, dev_addr)) - swiotlb_tbl_unmap_single(hwdev, paddr, size, size, dir, attrs); + swiotlb_tbl_unmap_single(hwdev, paddr, size, dir, attrs); } static void diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 5857a937c63722..59f421d041ed9e 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -57,7 +57,6 @@ phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys, extern void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, size_t mapping_size, - size_t alloc_size, enum dma_data_direction dir, unsigned long attrs); diff --git a/kernel/dma/direct.h b/kernel/dma/direct.h index b9861557873768..e1bf721591c0cf 100644 --- a/kernel/dma/direct.h +++ b/kernel/dma/direct.h @@ -114,6 +114,6 @@ static inline void dma_direct_unmap_page(struct device *dev, dma_addr_t addr, dma_direct_sync_single_for_cpu(dev, addr, size, dir); if (unlikely(is_swiotlb_buffer(phys))) - swiotlb_tbl_unmap_single(dev, phys, size, size, dir, attrs); + swiotlb_tbl_unmap_single(dev, phys, size, dir, attrs); } #endif /* _KERNEL_DMA_DIRECT_H */ diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index c10e855a03bc16..03aa614565e417 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -102,7 +102,7 @@ static phys_addr_t *io_tlb_orig_addr; /* * The mapped buffer's size should be validated during a sync operation. */ -static size_t *io_tlb_orig_size; +static size_t *io_tlb_alloc_size; /* * Protect the above data structures in the map and unmap calls @@ -253,15 +253,15 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) __func__, alloc_size, PAGE_SIZE); alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t)); - io_tlb_orig_size = memblock_alloc(alloc_size, PAGE_SIZE); - if (!io_tlb_orig_size) + io_tlb_alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); + if (!io_tlb_alloc_size) panic("%s: Failed to allocate %zu bytes align=0x%lx\n", __func__, alloc_size, PAGE_SIZE); for (i = 0; i < io_tlb_nslabs; i++) { io_tlb_list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); io_tlb_orig_addr[i] = INVALID_PHYS_ADDR; - io_tlb_orig_size[i] = 0; + io_tlb_alloc_size[i] = 0; } io_tlb_index = 0; no_iotlb_memory = false; @@ -393,18 +393,18 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) if (!io_tlb_orig_addr) goto cleanup4; - io_tlb_orig_size = (size_t *) + io_tlb_alloc_size = (size_t *) __get_free_pages(GFP_KERNEL, get_order(io_tlb_nslabs * sizeof(size_t))); - if (!io_tlb_orig_size) + if (!io_tlb_alloc_size) goto cleanup5; for (i = 0; i < io_tlb_nslabs; i++) { io_tlb_list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); io_tlb_orig_addr[i] = INVALID_PHYS_ADDR; - io_tlb_orig_size[i] = 0; + io_tlb_alloc_size[i] = 0; } io_tlb_index = 0; no_iotlb_memory = false; @@ -436,7 +436,7 @@ void __init swiotlb_exit(void) return; if (late_alloc) { - free_pages((unsigned long)io_tlb_orig_size, + free_pages((unsigned long)io_tlb_alloc_size, get_order(io_tlb_nslabs * sizeof(size_t))); free_pages((unsigned long)io_tlb_orig_addr, get_order(io_tlb_nslabs * sizeof(phys_addr_t))); @@ -447,7 +447,7 @@ void __init swiotlb_exit(void) } else { memblock_free_late(__pa(io_tlb_orig_addr), PAGE_ALIGN(io_tlb_nslabs * sizeof(phys_addr_t))); - memblock_free_late(__pa(io_tlb_orig_size), + memblock_free_late(__pa(io_tlb_alloc_size), PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t))); memblock_free_late(__pa(io_tlb_list), PAGE_ALIGN(io_tlb_nslabs * sizeof(int))); @@ -639,7 +639,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, */ for (i = 0; i < nr_slots(alloc_size + offset); i++) { io_tlb_orig_addr[index + i] = slot_addr(orig_addr, i); - io_tlb_orig_size[index+i] = alloc_size - (i << IO_TLB_SHIFT); + io_tlb_alloc_size[index+i] = alloc_size - (i << IO_TLB_SHIFT); } tlb_addr = slot_addr(io_tlb_start, index) + offset; if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) && @@ -648,14 +648,14 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, return tlb_addr; } -static void validate_sync_size_and_truncate(struct device *hwdev, size_t orig_size, size_t *size) +static void validate_sync_size_and_truncate(struct device *hwdev, size_t alloc_size, size_t *size) { - if (*size > orig_size) { + if (*size > alloc_size) { /* Warn and truncate mapping_size */ dev_WARN_ONCE(hwdev, 1, "Attempt for buffer overflow. Original size: %zu. Mapping size: %zu.\n", - orig_size, *size); - *size = orig_size; + alloc_size, *size); + *size = alloc_size; } } @@ -663,16 +663,17 @@ static void validate_sync_size_and_truncate(struct device *hwdev, size_t orig_si * tlb_addr is the physical address of the bounce buffer to unmap. */ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, - size_t mapping_size, size_t alloc_size, - enum dma_data_direction dir, unsigned long attrs) + size_t mapping_size, enum dma_data_direction dir, + unsigned long attrs) { unsigned long flags; unsigned int offset = swiotlb_align_offset(hwdev, tlb_addr); - int i, count, nslots = nr_slots(alloc_size + offset); int index = (tlb_addr - offset - io_tlb_start) >> IO_TLB_SHIFT; phys_addr_t orig_addr = io_tlb_orig_addr[index]; + size_t alloc_size = io_tlb_alloc_size[index]; + int i, count, nslots = nr_slots(alloc_size + offset); - validate_sync_size_and_truncate(hwdev, io_tlb_orig_size[index], &mapping_size); + validate_sync_size_and_truncate(hwdev, alloc_size, &mapping_size); /* * First, sync the memory before unmapping the entry @@ -701,7 +702,7 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, for (i = index + nslots - 1; i >= index; i--) { io_tlb_list[i] = ++count; io_tlb_orig_addr[i] = INVALID_PHYS_ADDR; - io_tlb_orig_size[i] = 0; + io_tlb_alloc_size[i] = 0; } /* @@ -721,13 +722,13 @@ void swiotlb_tbl_sync_single(struct device *hwdev, phys_addr_t tlb_addr, enum dma_sync_target target) { int index = (tlb_addr - io_tlb_start) >> IO_TLB_SHIFT; - size_t orig_size = io_tlb_orig_size[index]; + size_t alloc_size = io_tlb_alloc_size[index]; phys_addr_t orig_addr = io_tlb_orig_addr[index]; if (orig_addr == INVALID_PHYS_ADDR) return; - validate_sync_size_and_truncate(hwdev, orig_size, &size); + validate_sync_size_and_truncate(hwdev, alloc_size, &size); switch (target) { case SYNC_FOR_CPU: @@ -770,7 +771,7 @@ dma_addr_t swiotlb_map(struct device *dev, phys_addr_t paddr, size_t size, /* Ensure that the address returned is DMA'ble */ dma_addr = phys_to_dma_unencrypted(dev, swiotlb_addr); if (unlikely(!dma_capable(dev, dma_addr, size, true))) { - swiotlb_tbl_unmap_single(dev, swiotlb_addr, size, size, dir, + swiotlb_tbl_unmap_single(dev, swiotlb_addr, size, dir, attrs | DMA_ATTR_SKIP_CPU_SYNC); dev_WARN_ONCE(dev, 1, "swiotlb addr %pad+%zu overflow (mask %llx, bus limit %llx).\n", -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:45:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:45:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91257.172371 (Exim 4.92) (envelope-from ) id 1lGdEr-0002UG-FT; Mon, 01 Mar 2021 07:45:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91257.172371; Mon, 01 Mar 2021 07:45:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdEr-0002U9-CU; Mon, 01 Mar 2021 07:45:09 +0000 Received: by outflank-mailman (input) for mailman id 91257; Mon, 01 Mar 2021 07:45:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdEp-0002U2-CL for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:45:08 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2144fc4c-6bd5-4041-a05d-8a153779f684; Mon, 01 Mar 2021 07:45:03 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdEK-00FR4S-Vc; Mon, 01 Mar 2021 07:44:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2144fc4c-6bd5-4041-a05d-8a153779f684 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=oZQdON2UeZGDjeY8BOuus4h51xz4D0PS1kfJ4kEC/6s=; b=rO8ALAJQqrZEeZ4iEOjPwi1WE+ 6R34dC8dSkDj+qIvIr6UcSiPxULXK+/lCvDQd59+1pjrXB8xmT7INZhQqgIGvc15iyacmBouUpYHq Do7OPE+zdqCAtk9VUQgSfWkGNCcxTuVUCNnmCtbqSRZctaKJeHAXhPDtIpyY5e7l26gK4ai4ARYuQ OrjO3c1J2ThGSimBb9YbvGnJZi0U/G5QKDNtYkU1CeadFjBoTIqGdPxrVjI5KeB/y+kcasXY76qMt ipKwlZlorTKY6C1UI0lpRn30rJKpqd3RD55IINoQG4ssYdZ6Z3/RZxvk8rBrRkpkhd5xp+qwszJTN W0EYGG9g==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: swiotlb cleanups v2 Date: Mon, 1 Mar 2021 08:44:22 +0100 Message-Id: <20210301074436.919889-1-hch@lst.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Hi Konrad, this series contains a bunch of swiotlb cleanups, mostly to reduce the amount of internals exposed to code outside of swiotlb.c, which should helper to prepare for supporting multiple different bounce buffer pools. Changes since v1: - rebased to v5.12-rc1 - a few more cleanups - merge and forward port the patch from Claire to move all the global variables into a struct to prepare for multiple instances From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:45:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:45:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91260.172407 (Exim 4.92) (envelope-from ) id 1lGdF5-0002c3-A5; Mon, 01 Mar 2021 07:45:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91260.172407; Mon, 01 Mar 2021 07:45:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdF5-0002bt-68; Mon, 01 Mar 2021 07:45:23 +0000 Received: by outflank-mailman (input) for mailman id 91260; Mon, 01 Mar 2021 07:45:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdF4-0002U2-96 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:45:22 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e9697837-920a-42cb-a2bc-a6e2cf0c2a7c; Mon, 01 Mar 2021 07:45:19 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdEq-00FRBJ-Uh; Mon, 01 Mar 2021 07:45:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9697837-920a-42cb-a2bc-a6e2cf0c2a7c DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=Ds/ACDNRu58btmZG/NqJ4lBgbf4+MYCDj5+pQ+XVzpM=; b=Woztf5KlRadzF1qDJdsaN2b6jM F8qWgj/k/tKZ4TYWm/AYmy26ne94IWhyXBXotmr6ZMC2165WaVQ0HTcxuOZlbeVPRgeaDbU9tPbk6 b1+viMTPj3CMaTXoXiKCSmZ7osK63GGeshw5QNx/sYvqsaDd+dXbdEpaqbUF7xUXVaqz1aTIQ+sXB NgnUGMgUWy//zxAqn8O6EvVL4sb4zQrrgB8TYz0XC/mJGicpRKi4j6KyFM7g0lV1wMwCAPkPNUjoK 59SY3DMBp5chNynkNLgir+OXDa4hEDqhRh8xvDXl/lPGZGPo5vMoG0sUo/Zfva4X8S0ufaB4hAII9 2/ISnCMw==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 03/14] swiotlb: move orig addr and size validation into swiotlb_bounce Date: Mon, 1 Mar 2021 08:44:25 +0100 Message-Id: <20210301074436.919889-4-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301074436.919889-1-hch@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Move the code to find and validate the original buffer address and size from the callers into swiotlb_bounce. This means a tiny bit of extra work in the swiotlb_map path, but avoids code duplication and a leads to a better code structure. Signed-off-by: Christoph Hellwig --- kernel/dma/swiotlb.c | 59 +++++++++++++++++--------------------------- 1 file changed, 23 insertions(+), 36 deletions(-) diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 03aa614565e417..a9063092f6f566 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -460,12 +460,25 @@ void __init swiotlb_exit(void) /* * Bounce: copy the swiotlb buffer from or back to the original dma location */ -static void swiotlb_bounce(phys_addr_t orig_addr, phys_addr_t tlb_addr, - size_t size, enum dma_data_direction dir) +static void swiotlb_bounce(struct device *dev, phys_addr_t tlb_addr, size_t size, + enum dma_data_direction dir) { + int index = (tlb_addr - io_tlb_start) >> IO_TLB_SHIFT; + size_t alloc_size = io_tlb_alloc_size[index]; + phys_addr_t orig_addr = io_tlb_orig_addr[index]; unsigned long pfn = PFN_DOWN(orig_addr); unsigned char *vaddr = phys_to_virt(tlb_addr); + if (orig_addr == INVALID_PHYS_ADDR) + return; + + if (size > alloc_size) { + dev_WARN_ONCE(dev, 1, + "Buffer overflow detected. Allocation size: %zu. Mapping size: %zu.\n", + alloc_size, size); + size = alloc_size; + } + if (PageHighMem(pfn_to_page(pfn))) { /* The buffer does not have a mapping. Map it in and copy */ unsigned int offset = orig_addr & ~PAGE_MASK; @@ -644,21 +657,10 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, tlb_addr = slot_addr(io_tlb_start, index) + offset; if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) && (dir == DMA_TO_DEVICE || dir == DMA_BIDIRECTIONAL)) - swiotlb_bounce(orig_addr, tlb_addr, mapping_size, DMA_TO_DEVICE); + swiotlb_bounce(dev, tlb_addr, mapping_size, DMA_TO_DEVICE); return tlb_addr; } -static void validate_sync_size_and_truncate(struct device *hwdev, size_t alloc_size, size_t *size) -{ - if (*size > alloc_size) { - /* Warn and truncate mapping_size */ - dev_WARN_ONCE(hwdev, 1, - "Attempt for buffer overflow. Original size: %zu. Mapping size: %zu.\n", - alloc_size, *size); - *size = alloc_size; - } -} - /* * tlb_addr is the physical address of the bounce buffer to unmap. */ @@ -669,19 +671,15 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, unsigned long flags; unsigned int offset = swiotlb_align_offset(hwdev, tlb_addr); int index = (tlb_addr - offset - io_tlb_start) >> IO_TLB_SHIFT; - phys_addr_t orig_addr = io_tlb_orig_addr[index]; - size_t alloc_size = io_tlb_alloc_size[index]; - int i, count, nslots = nr_slots(alloc_size + offset); - - validate_sync_size_and_truncate(hwdev, alloc_size, &mapping_size); + int nslots = nr_slots(io_tlb_alloc_size[index] + offset); + int count, i; /* * First, sync the memory before unmapping the entry */ - if (orig_addr != INVALID_PHYS_ADDR && - !(attrs & DMA_ATTR_SKIP_CPU_SYNC) && - ((dir == DMA_FROM_DEVICE) || (dir == DMA_BIDIRECTIONAL))) - swiotlb_bounce(orig_addr, tlb_addr, mapping_size, DMA_FROM_DEVICE); + if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) && + (dir == DMA_FROM_DEVICE || dir == DMA_BIDIRECTIONAL)) + swiotlb_bounce(hwdev, tlb_addr, mapping_size, DMA_FROM_DEVICE); /* * Return the buffer to the free list by setting the corresponding @@ -721,27 +719,16 @@ void swiotlb_tbl_sync_single(struct device *hwdev, phys_addr_t tlb_addr, size_t size, enum dma_data_direction dir, enum dma_sync_target target) { - int index = (tlb_addr - io_tlb_start) >> IO_TLB_SHIFT; - size_t alloc_size = io_tlb_alloc_size[index]; - phys_addr_t orig_addr = io_tlb_orig_addr[index]; - - if (orig_addr == INVALID_PHYS_ADDR) - return; - - validate_sync_size_and_truncate(hwdev, alloc_size, &size); - switch (target) { case SYNC_FOR_CPU: if (likely(dir == DMA_FROM_DEVICE || dir == DMA_BIDIRECTIONAL)) - swiotlb_bounce(orig_addr, tlb_addr, - size, DMA_FROM_DEVICE); + swiotlb_bounce(hwdev, tlb_addr, size, DMA_FROM_DEVICE); else BUG_ON(dir != DMA_TO_DEVICE); break; case SYNC_FOR_DEVICE: if (likely(dir == DMA_TO_DEVICE || dir == DMA_BIDIRECTIONAL)) - swiotlb_bounce(orig_addr, tlb_addr, - size, DMA_TO_DEVICE); + swiotlb_bounce(hwdev, tlb_addr, size, DMA_TO_DEVICE); else BUG_ON(dir != DMA_FROM_DEVICE); break; -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:45:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:45:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91262.172419 (Exim 4.92) (envelope-from ) id 1lGdFH-0002l3-Jc; Mon, 01 Mar 2021 07:45:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91262.172419; Mon, 01 Mar 2021 07:45:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdFH-0002kv-FK; Mon, 01 Mar 2021 07:45:35 +0000 Received: by outflank-mailman (input) for mailman id 91262; Mon, 01 Mar 2021 07:45:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdFG-0002i6-Cq for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:45:34 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 69718da5-0bc2-47df-8d61-ef1be52e02d2; Mon, 01 Mar 2021 07:45:31 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdEv-00FRBY-PX; Mon, 01 Mar 2021 07:45:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69718da5-0bc2-47df-8d61-ef1be52e02d2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=dcvL651kX+/+tDC/vc46FsoJZklOjDE98QeeBFDCLlE=; b=t5bTAovDUHg7PpXkFQaiN6GS+l rkEIHPA6OhDt3ss3PZEGfvrl8GQrzKXAqN22LEPl3yalumIEbug2Mu3ZsVTlLRPfpqzmgn4u29+Pw ZhjNV/YNPlJKM7XgqRRv34XplHbctmeg7RJ3KgGkyClBZAmTvDJrEpqcPR4+m/bo3kUD/VlOKKmlT p4Z/hoChDLtFgMHzWcInci8zLGCyhU9l1JIlIA3uJMnES6B0KRUI7Oys99vUcnkChl95PxYeWgubf dJrGji3sLeseANLPZPDcjriDIvMgIvbCdlTwdK8prS9HkHh1sUXjgHiPJpP/OP24o6JodkPxa7avY sCMcSA5w==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 04/14] swiotlb: split swiotlb_tbl_sync_single Date: Mon, 1 Mar 2021 08:44:26 +0100 Message-Id: <20210301074436.919889-5-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301074436.919889-1-hch@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Split swiotlb_tbl_sync_single into two separate funtions for the to device and to cpu synchronization. Signed-off-by: Christoph Hellwig --- drivers/iommu/dma-iommu.c | 12 ++++++------ drivers/xen/swiotlb-xen.c | 4 ++-- include/linux/swiotlb.h | 17 ++++------------- kernel/dma/direct.c | 8 ++++---- kernel/dma/direct.h | 4 ++-- kernel/dma/swiotlb.c | 34 +++++++++++++++------------------- 6 files changed, 33 insertions(+), 46 deletions(-) diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index da2bd8f0885e6e..b57a0e3e21f6c7 100644 --- a/drivers/iommu/dma-iommu.c +++ b/drivers/iommu/dma-iommu.c @@ -749,7 +749,7 @@ static void iommu_dma_sync_single_for_cpu(struct device *dev, arch_sync_dma_for_cpu(phys, size, dir); if (is_swiotlb_buffer(phys)) - swiotlb_tbl_sync_single(dev, phys, size, dir, SYNC_FOR_CPU); + swiotlb_sync_single_for_cpu(dev, phys, size, dir); } static void iommu_dma_sync_single_for_device(struct device *dev, @@ -762,7 +762,7 @@ static void iommu_dma_sync_single_for_device(struct device *dev, phys = iommu_iova_to_phys(iommu_get_dma_domain(dev), dma_handle); if (is_swiotlb_buffer(phys)) - swiotlb_tbl_sync_single(dev, phys, size, dir, SYNC_FOR_DEVICE); + swiotlb_sync_single_for_device(dev, phys, size, dir); if (!dev_is_dma_coherent(dev)) arch_sync_dma_for_device(phys, size, dir); @@ -783,8 +783,8 @@ static void iommu_dma_sync_sg_for_cpu(struct device *dev, arch_sync_dma_for_cpu(sg_phys(sg), sg->length, dir); if (is_swiotlb_buffer(sg_phys(sg))) - swiotlb_tbl_sync_single(dev, sg_phys(sg), sg->length, - dir, SYNC_FOR_CPU); + swiotlb_sync_single_for_cpu(dev, sg_phys(sg), + sg->length, dir); } } @@ -800,8 +800,8 @@ static void iommu_dma_sync_sg_for_device(struct device *dev, for_each_sg(sgl, sg, nelems, i) { if (is_swiotlb_buffer(sg_phys(sg))) - swiotlb_tbl_sync_single(dev, sg_phys(sg), sg->length, - dir, SYNC_FOR_DEVICE); + swiotlb_sync_single_for_device(dev, sg_phys(sg), + sg->length, dir); if (!dev_is_dma_coherent(dev)) arch_sync_dma_for_device(sg_phys(sg), sg->length, dir); diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index d47f1b311caac0..4e8a4e14942afd 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -462,7 +462,7 @@ xen_swiotlb_sync_single_for_cpu(struct device *dev, dma_addr_t dma_addr, } if (is_xen_swiotlb_buffer(dev, dma_addr)) - swiotlb_tbl_sync_single(dev, paddr, size, dir, SYNC_FOR_CPU); + swiotlb_sync_single_for_cpu(dev, paddr, size, dir); } static void @@ -472,7 +472,7 @@ xen_swiotlb_sync_single_for_device(struct device *dev, dma_addr_t dma_addr, phys_addr_t paddr = xen_dma_to_phys(dev, dma_addr); if (is_xen_swiotlb_buffer(dev, dma_addr)) - swiotlb_tbl_sync_single(dev, paddr, size, dir, SYNC_FOR_DEVICE); + swiotlb_sync_single_for_device(dev, paddr, size, dir); if (!dev_is_dma_coherent(dev)) { if (pfn_valid(PFN_DOWN(dma_to_phys(dev, dma_addr)))) diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 59f421d041ed9e..0696bdc8072e97 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -42,14 +42,6 @@ extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs); extern int swiotlb_late_init_with_default_size(size_t default_size); extern void __init swiotlb_update_mem_attributes(void); -/* - * Enumeration for sync targets - */ -enum dma_sync_target { - SYNC_FOR_CPU = 0, - SYNC_FOR_DEVICE = 1, -}; - phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys, size_t mapping_size, size_t alloc_size, enum dma_data_direction dir, unsigned long attrs); @@ -60,11 +52,10 @@ extern void swiotlb_tbl_unmap_single(struct device *hwdev, enum dma_data_direction dir, unsigned long attrs); -extern void swiotlb_tbl_sync_single(struct device *hwdev, - phys_addr_t tlb_addr, - size_t size, enum dma_data_direction dir, - enum dma_sync_target target); - +void swiotlb_sync_single_for_device(struct device *dev, phys_addr_t tlb_addr, + size_t size, enum dma_data_direction dir); +void swiotlb_sync_single_for_cpu(struct device *dev, phys_addr_t tlb_addr, + size_t size, enum dma_data_direction dir); dma_addr_t swiotlb_map(struct device *dev, phys_addr_t phys, size_t size, enum dma_data_direction dir, unsigned long attrs); diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c index 002268262c9ad8..f737e334705945 100644 --- a/kernel/dma/direct.c +++ b/kernel/dma/direct.c @@ -344,8 +344,8 @@ void dma_direct_sync_sg_for_device(struct device *dev, phys_addr_t paddr = dma_to_phys(dev, sg_dma_address(sg)); if (unlikely(is_swiotlb_buffer(paddr))) - swiotlb_tbl_sync_single(dev, paddr, sg->length, - dir, SYNC_FOR_DEVICE); + swiotlb_sync_single_for_device(dev, paddr, sg->length, + dir); if (!dev_is_dma_coherent(dev)) arch_sync_dma_for_device(paddr, sg->length, @@ -370,8 +370,8 @@ void dma_direct_sync_sg_for_cpu(struct device *dev, arch_sync_dma_for_cpu(paddr, sg->length, dir); if (unlikely(is_swiotlb_buffer(paddr))) - swiotlb_tbl_sync_single(dev, paddr, sg->length, dir, - SYNC_FOR_CPU); + swiotlb_sync_single_for_cpu(dev, paddr, sg->length, + dir); if (dir == DMA_FROM_DEVICE) arch_dma_mark_clean(paddr, sg->length); diff --git a/kernel/dma/direct.h b/kernel/dma/direct.h index e1bf721591c0cf..50afc05b6f1dcb 100644 --- a/kernel/dma/direct.h +++ b/kernel/dma/direct.h @@ -57,7 +57,7 @@ static inline void dma_direct_sync_single_for_device(struct device *dev, phys_addr_t paddr = dma_to_phys(dev, addr); if (unlikely(is_swiotlb_buffer(paddr))) - swiotlb_tbl_sync_single(dev, paddr, size, dir, SYNC_FOR_DEVICE); + swiotlb_sync_single_for_device(dev, paddr, size, dir); if (!dev_is_dma_coherent(dev)) arch_sync_dma_for_device(paddr, size, dir); @@ -74,7 +74,7 @@ static inline void dma_direct_sync_single_for_cpu(struct device *dev, } if (unlikely(is_swiotlb_buffer(paddr))) - swiotlb_tbl_sync_single(dev, paddr, size, dir, SYNC_FOR_CPU); + swiotlb_sync_single_for_cpu(dev, paddr, size, dir); if (dir == DMA_FROM_DEVICE) arch_dma_mark_clean(paddr, size); diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index a9063092f6f566..388d9be35b5795 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -715,26 +715,22 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, spin_unlock_irqrestore(&io_tlb_lock, flags); } -void swiotlb_tbl_sync_single(struct device *hwdev, phys_addr_t tlb_addr, - size_t size, enum dma_data_direction dir, - enum dma_sync_target target) +void swiotlb_sync_single_for_device(struct device *dev, phys_addr_t tlb_addr, + size_t size, enum dma_data_direction dir) { - switch (target) { - case SYNC_FOR_CPU: - if (likely(dir == DMA_FROM_DEVICE || dir == DMA_BIDIRECTIONAL)) - swiotlb_bounce(hwdev, tlb_addr, size, DMA_FROM_DEVICE); - else - BUG_ON(dir != DMA_TO_DEVICE); - break; - case SYNC_FOR_DEVICE: - if (likely(dir == DMA_TO_DEVICE || dir == DMA_BIDIRECTIONAL)) - swiotlb_bounce(hwdev, tlb_addr, size, DMA_TO_DEVICE); - else - BUG_ON(dir != DMA_FROM_DEVICE); - break; - default: - BUG(); - } + if (dir == DMA_TO_DEVICE || dir == DMA_BIDIRECTIONAL) + swiotlb_bounce(dev, tlb_addr, size, DMA_TO_DEVICE); + else + BUG_ON(dir != DMA_FROM_DEVICE); +} + +void swiotlb_sync_single_for_cpu(struct device *dev, phys_addr_t tlb_addr, + size_t size, enum dma_data_direction dir) +{ + if (dir == DMA_FROM_DEVICE || dir == DMA_BIDIRECTIONAL) + swiotlb_bounce(dev, tlb_addr, size, DMA_FROM_DEVICE); + else + BUG_ON(dir != DMA_TO_DEVICE); } /* -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:45:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:45:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91269.172430 (Exim 4.92) (envelope-from ) id 1lGdFY-0002tt-1P; Mon, 01 Mar 2021 07:45:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91269.172430; Mon, 01 Mar 2021 07:45:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdFX-0002tl-U9; Mon, 01 Mar 2021 07:45:51 +0000 Received: by outflank-mailman (input) for mailman id 91269; Mon, 01 Mar 2021 07:45:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdFW-0002sK-EB for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:45:50 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 83d1d930-5506-416b-9373-1512f9c8c7f4; Mon, 01 Mar 2021 07:45:49 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdF4-00FRBm-On; Mon, 01 Mar 2021 07:45:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83d1d930-5506-416b-9373-1512f9c8c7f4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=waRM0pjuhEeQaBWUrgK7ZdelZaRqodVDxZI32WcdEMs=; b=l9A9+OrFX2akSpcdSbJffe1kyf 38IwDgTDdrgca89MW5mliDcOLO5Nd0YTAd+ofoshJOMHMQ4O35SMjrqUSU9BIHBTrFAacTJCjWAH3 MmKvzN6NMpMwvvP6g0ZXvkrEF4XoDYt1DYcZ7SUrX+oWzfjcZJ1GA4dM4UpRcUm7kFnJARpBEfYgI A3Sdb4LCU5WFHZbbQwkGeNAkJDOEECqd0DCf7dqLDGdhg10VJK800H5RapjGPVmj1QIBsBNLQ0dey tGbmmvR/4HsSuRkqrabDlZRDAgwFImpxNnkr11nYp5NPR3J5sG9CcFaruHrnGOM9tkBPSZNeSHJPt 25rxC34A==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 05/14] xen-swiotlb: use is_swiotlb_buffer in is_xen_swiotlb_buffer Date: Mon, 1 Mar 2021 08:44:27 +0100 Message-Id: <20210301074436.919889-6-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301074436.919889-1-hch@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Use the is_swiotlb_buffer to check if a physical address is a swiotlb buffer. This works because xen-swiotlb does use the same buffer as the main swiotlb code, and xen_io_tlb_{start,end} are just the addresses for it that went through phys_to_virt. Signed-off-by: Christoph Hellwig Reviewed-by: Konrad Rzeszutek Wilk --- drivers/xen/swiotlb-xen.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 4e8a4e14942afd..bffb35993c9d5f 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -111,10 +111,8 @@ static int is_xen_swiotlb_buffer(struct device *dev, dma_addr_t dma_addr) * have the same virtual address as another address * in our domain. Therefore _only_ check address within our domain. */ - if (pfn_valid(PFN_DOWN(paddr))) { - return paddr >= virt_to_phys(xen_io_tlb_start) && - paddr < virt_to_phys(xen_io_tlb_end); - } + if (pfn_valid(PFN_DOWN(paddr))) + return is_swiotlb_buffer(paddr); return 0; } -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:46:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:46:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91271.172443 (Exim 4.92) (envelope-from ) id 1lGdFj-0002z6-AC; Mon, 01 Mar 2021 07:46:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91271.172443; Mon, 01 Mar 2021 07:46:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdFj-0002yx-78; Mon, 01 Mar 2021 07:46:03 +0000 Received: by outflank-mailman (input) for mailman id 91271; Mon, 01 Mar 2021 07:46:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdFi-0002yc-EZ for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:46:02 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 39a37b42-4e08-4a33-8ddc-30ce59f6d3b8; Mon, 01 Mar 2021 07:45:59 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdFQ-00FRCL-0I; Mon, 01 Mar 2021 07:45:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39a37b42-4e08-4a33-8ddc-30ce59f6d3b8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=OCILNlokJCxmLaXrgvg794b6b4atNJeGi+QbETqZtzY=; b=n2VQKtfAYQonjn8kWQvsXpZj00 EL3jl9UA5+wN2UQu9NxyAYOuJG12NX6uYa2qLyFZLMxl5fbXDop5kVsZqCdyIIEt29aRzatWQNkqA OB32u9XjFpGo6wSQwtWRgvklyPmyuzphmHFTWaISqvgVzYH/0+SL5NXnpAQR1qI8SO9VWURLQ/L4n I58qbE6gV6GeOQgJJDsqODfRzK69AeitDS/OZpoBARnsIv2KwoMN7N7xiB+e4O9LnfWUlocfnSzlr lnJBcw8Dvv2laYJlgev77JFgu8iEqDd6mVEcY0zRgaRY3lx3eyp9LomM4YYkhb+Z/UHcQnIhmcpoM JcA5BOhQ==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 06/14] xen-swiotlb: use io_tlb_end in xen_swiotlb_dma_supported Date: Mon, 1 Mar 2021 08:44:28 +0100 Message-Id: <20210301074436.919889-7-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301074436.919889-1-hch@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Use the existing variable that holds the physical address for xen_io_tlb_end to simplify xen_swiotlb_dma_supported a bit, and remove the otherwise unused xen_io_tlb_end variable and the xen_virt_to_bus helper. Signed-off-by: Christoph Hellwig Reviewed-by: Konrad Rzeszutek Wilk --- drivers/xen/swiotlb-xen.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index bffb35993c9d5f..e99f0614dcb979 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -46,7 +46,7 @@ * API. */ -static char *xen_io_tlb_start, *xen_io_tlb_end; +static char *xen_io_tlb_start; static unsigned long xen_io_tlb_nslabs; /* * Quick lookup value of the bus address of the IOTLB. @@ -82,11 +82,6 @@ static inline phys_addr_t xen_dma_to_phys(struct device *dev, return xen_bus_to_phys(dev, dma_to_phys(dev, dma_addr)); } -static inline dma_addr_t xen_virt_to_bus(struct device *dev, void *address) -{ - return xen_phys_to_dma(dev, virt_to_phys(address)); -} - static inline int range_straddles_page_boundary(phys_addr_t p, size_t size) { unsigned long next_bfn, xen_pfn = XEN_PFN_DOWN(p); @@ -250,7 +245,6 @@ int __ref xen_swiotlb_init(int verbose, bool early) rc = swiotlb_late_init_with_tbl(xen_io_tlb_start, xen_io_tlb_nslabs); end: - xen_io_tlb_end = xen_io_tlb_start + bytes; if (!rc) swiotlb_set_max_segment(PAGE_SIZE); @@ -558,7 +552,7 @@ xen_swiotlb_sync_sg_for_device(struct device *dev, struct scatterlist *sgl, static int xen_swiotlb_dma_supported(struct device *hwdev, u64 mask) { - return xen_virt_to_bus(hwdev, xen_io_tlb_end - 1) <= mask; + return xen_phys_to_dma(hwdev, io_tlb_end - 1) <= mask; } const struct dma_map_ops xen_swiotlb_dma_ops = { -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:46:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:46:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91273.172455 (Exim 4.92) (envelope-from ) id 1lGdFm-000320-LB; Mon, 01 Mar 2021 07:46:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91273.172455; Mon, 01 Mar 2021 07:46:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdFm-00031r-GR; Mon, 01 Mar 2021 07:46:06 +0000 Received: by outflank-mailman (input) for mailman id 91273; Mon, 01 Mar 2021 07:46:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdFl-0002yc-BV for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:46:05 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ce8998b2-166e-4703-93ae-db34b11e3ad7; Mon, 01 Mar 2021 07:46:04 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdFa-00FRD5-OZ; Mon, 01 Mar 2021 07:45:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce8998b2-166e-4703-93ae-db34b11e3ad7 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=n4a5R9+ylbvoibBv9Gp4RRSzd949UJhfH+kdgUzXMIA=; b=ZdtJkSTQoBpw/cdu0C97cG13/n hnkW6A3RrPzYaXlCcieHyhVXiP8MF2ep7TS+aJyf3GZe66+xpZWgToyCzgiH5ydTo5cY6SWeh6gSp eWAP2epI/P5SHOeCxT2yVEQus8aSEgI/HaWdf01Lw1tEj/ySKW/4yU6vt8dK7QexOzT/AK9BnwVJQ vkWA9I7c0R9uCfQWQvxfOa4meVFZhWV8w/VdbMi/iGnvdTMEwEiaN3spsgAGnkyV0mYLo6Wst8PQ4 lqZEwHRsz0EIbqJE4HY4ZT1Oxo8rFdW+q5SvmOCXv0E3WMX1TpKxeP8ykm/dSx13AmIi0JJJusybs 1oZ+I7pA==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 07/14] xen-swiotlb: remove xen_set_nslabs Date: Mon, 1 Mar 2021 08:44:29 +0100 Message-Id: <20210301074436.919889-8-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301074436.919889-1-hch@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html The xen_set_nslabs function is a little weird, as it has just one caller, that caller passes a global variable as the argument, which is then overriden in the function and a derivative of it returned. Just add a cpp symbol for the default size using a readable constant and open code the remaining three lines in the caller. Signed-off-by: Christoph Hellwig --- drivers/xen/swiotlb-xen.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index e99f0614dcb979..5352655432e724 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -138,16 +138,6 @@ xen_swiotlb_fixup(void *buf, size_t size, unsigned long nslabs) } while (i < nslabs); return 0; } -static unsigned long xen_set_nslabs(unsigned long nr_tbl) -{ - if (!nr_tbl) { - xen_io_tlb_nslabs = (64 * 1024 * 1024 >> IO_TLB_SHIFT); - xen_io_tlb_nslabs = ALIGN(xen_io_tlb_nslabs, IO_TLB_SEGSIZE); - } else - xen_io_tlb_nslabs = nr_tbl; - - return xen_io_tlb_nslabs << IO_TLB_SHIFT; -} enum xen_swiotlb_err { XEN_SWIOTLB_UNKNOWN = 0, @@ -170,6 +160,9 @@ static const char *xen_swiotlb_error(enum xen_swiotlb_err err) } return ""; } + +#define DEFAULT_NSLABS ALIGN(SZ_64M >> IO_TLB_SHIFT, IO_TLB_SEGSIZE) + int __ref xen_swiotlb_init(int verbose, bool early) { unsigned long bytes, order; @@ -179,8 +172,10 @@ int __ref xen_swiotlb_init(int verbose, bool early) xen_io_tlb_nslabs = swiotlb_nr_tbl(); retry: - bytes = xen_set_nslabs(xen_io_tlb_nslabs); - order = get_order(xen_io_tlb_nslabs << IO_TLB_SHIFT); + if (!xen_io_tlb_nslabs) + xen_io_tlb_nslabs = DEFAULT_NSLABS; + bytes = xen_io_tlb_nslabs << IO_TLB_SHIFT; + order = get_order(bytes); /* * IO TLB memory already allocated. Just use it. -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:46:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:46:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91274.172467 (Exim 4.92) (envelope-from ) id 1lGdFt-00039S-TM; Mon, 01 Mar 2021 07:46:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91274.172467; Mon, 01 Mar 2021 07:46:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdFt-000392-Ox; Mon, 01 Mar 2021 07:46:13 +0000 Received: by outflank-mailman (input) for mailman id 91274; Mon, 01 Mar 2021 07:46:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdFs-00036y-67 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:46:12 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 668e4dd6-2686-475b-b19f-30dda4cde3d0; Mon, 01 Mar 2021 07:46:10 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdFg-00FRDV-0p; Mon, 01 Mar 2021 07:46:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 668e4dd6-2686-475b-b19f-30dda4cde3d0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=Nv2PzTFaNuvZMLFLXyjuLWvrF97az/7ZIuedCeQXxXo=; b=dcs28v1gCq97Kg7VGkzZDNtfBS 5/Y9BWSDEFQ0ue8+GeO+pvfl9PH2Fa9smNuJM50LF1Mq+3hEEaB1VHWSyj/dcpsRTIinzTOpuTC5b feXtU4Are3eTutHu0jUVtlOEMlSECtX4EqblBryk1+ow7zc7Ho2mKmJuNtqugq8wrtI9IWLt5URtJ dtiRRCH0oKGw4/2bPQZciYOP1nmZ+lVgZRpEj8aALss9KfVEZMW/4Wav8dkCb6S8RJ4IdMSDjoWBZ yDBMCcgb9k+zD7C6KTqH3FoHhADuq5RVyDNDgVLKekqcZPdb4nQ04/3MhFlJfGsbra7rrfrT2bPfn 8gl8q2lA==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 08/14] xen-swiotlb: remove xen_io_tlb_start and xen_io_tlb_nslabs Date: Mon, 1 Mar 2021 08:44:30 +0100 Message-Id: <20210301074436.919889-9-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301074436.919889-1-hch@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html The xen_io_tlb_start and xen_io_tlb_nslabs variables ar now only used in xen_swiotlb_init, so replace them with local variables. Signed-off-by: Christoph Hellwig --- drivers/xen/swiotlb-xen.c | 57 +++++++++++++++++---------------------- 1 file changed, 25 insertions(+), 32 deletions(-) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 5352655432e724..1a31ddf7139799 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -40,14 +40,7 @@ #include #define MAX_DMA_BITS 32 -/* - * Used to do a quick range check in swiotlb_tbl_unmap_single and - * swiotlb_tbl_sync_single_*, to see if the memory was in fact allocated by this - * API. - */ -static char *xen_io_tlb_start; -static unsigned long xen_io_tlb_nslabs; /* * Quick lookup value of the bus address of the IOTLB. */ @@ -169,75 +162,75 @@ int __ref xen_swiotlb_init(int verbose, bool early) int rc = -ENOMEM; enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN; unsigned int repeat = 3; + char *start; + unsigned long nslabs; - xen_io_tlb_nslabs = swiotlb_nr_tbl(); + nslabs = swiotlb_nr_tbl(); retry: - if (!xen_io_tlb_nslabs) - xen_io_tlb_nslabs = DEFAULT_NSLABS; - bytes = xen_io_tlb_nslabs << IO_TLB_SHIFT; + if (!nslabs) + nslabs = DEFAULT_NSLABS; + bytes = nslabs << IO_TLB_SHIFT; order = get_order(bytes); /* * IO TLB memory already allocated. Just use it. */ - if (io_tlb_start != 0) { - xen_io_tlb_start = phys_to_virt(io_tlb_start); + if (io_tlb_start != 0) goto end; - } /* * Get IO TLB memory from any location. */ if (early) { - xen_io_tlb_start = memblock_alloc(PAGE_ALIGN(bytes), + start = memblock_alloc(PAGE_ALIGN(bytes), PAGE_SIZE); - if (!xen_io_tlb_start) + if (!start) panic("%s: Failed to allocate %lu bytes align=0x%lx\n", __func__, PAGE_ALIGN(bytes), PAGE_SIZE); } else { #define SLABS_PER_PAGE (1 << (PAGE_SHIFT - IO_TLB_SHIFT)) #define IO_TLB_MIN_SLABS ((1<<20) >> IO_TLB_SHIFT) while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) { - xen_io_tlb_start = (void *)xen_get_swiotlb_free_pages(order); - if (xen_io_tlb_start) + start = (void *)xen_get_swiotlb_free_pages(order); + if (start) break; order--; } if (order != get_order(bytes)) { pr_warn("Warning: only able to allocate %ld MB for software IO TLB\n", (PAGE_SIZE << order) >> 20); - xen_io_tlb_nslabs = SLABS_PER_PAGE << order; - bytes = xen_io_tlb_nslabs << IO_TLB_SHIFT; + nslabs = SLABS_PER_PAGE << order; + bytes = nslabs << IO_TLB_SHIFT; } } - if (!xen_io_tlb_start) { + if (!start) { m_ret = XEN_SWIOTLB_ENOMEM; goto error; } /* * And replace that memory with pages under 4GB. */ - rc = xen_swiotlb_fixup(xen_io_tlb_start, + rc = xen_swiotlb_fixup(start, bytes, - xen_io_tlb_nslabs); + nslabs); if (rc) { if (early) - memblock_free(__pa(xen_io_tlb_start), + memblock_free(__pa(start), PAGE_ALIGN(bytes)); else { - free_pages((unsigned long)xen_io_tlb_start, order); - xen_io_tlb_start = NULL; + free_pages((unsigned long)start, order); + start = NULL; } m_ret = XEN_SWIOTLB_EFIXUP; goto error; } if (early) { - if (swiotlb_init_with_tbl(xen_io_tlb_start, xen_io_tlb_nslabs, + if (swiotlb_init_with_tbl(start, nslabs, verbose)) panic("Cannot allocate SWIOTLB buffer"); rc = 0; } else - rc = swiotlb_late_init_with_tbl(xen_io_tlb_start, xen_io_tlb_nslabs); + rc = swiotlb_late_init_with_tbl(start, nslabs); end: if (!rc) @@ -246,17 +239,17 @@ int __ref xen_swiotlb_init(int verbose, bool early) return rc; error: if (repeat--) { - xen_io_tlb_nslabs = max(1024UL, /* Min is 2MB */ - (xen_io_tlb_nslabs >> 1)); + nslabs = max(1024UL, /* Min is 2MB */ + (nslabs >> 1)); pr_info("Lowering to %luMB\n", - (xen_io_tlb_nslabs << IO_TLB_SHIFT) >> 20); + (nslabs << IO_TLB_SHIFT) >> 20); goto retry; } pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc); if (early) panic("%s (rc:%d)", xen_swiotlb_error(m_ret), rc); else - free_pages((unsigned long)xen_io_tlb_start, order); + free_pages((unsigned long)start, order); return rc; } -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:46:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:46:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91277.172479 (Exim 4.92) (envelope-from ) id 1lGdG0-0003Fl-6y; Mon, 01 Mar 2021 07:46:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91277.172479; Mon, 01 Mar 2021 07:46:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdG0-0003Fd-2K; Mon, 01 Mar 2021 07:46:20 +0000 Received: by outflank-mailman (input) for mailman id 91277; Mon, 01 Mar 2021 07:46:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdFy-00036y-E0 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:46:18 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3f8fe213-b4ce-4d70-a9c9-b55cac12f660; Mon, 01 Mar 2021 07:46:15 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdFm-00FRDp-Lh; Mon, 01 Mar 2021 07:46:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f8fe213-b4ce-4d70-a9c9-b55cac12f660 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=JFey0nQH0q27BLg8sKUeuXSyZDiQiQFLOD6BixvKeyU=; b=NOzDrThXk5sQLHtG3a7GXeBGS9 H2XGITYrLulEacH0a8AvtD4GcR3a2s77sP1xJjnehH3ArsbGm+hD5Yg+R4px9hPi+g+Hqawj5XasA USCZkvxqssnycydmnC4rU9Kn3Dp7ojnB+xcinZ1+dr2f3ywKfxV6zOcD7Kwh/7lBlruP/9QUg21lZ FZB2z4KkS3r112xjPrzwRHn0SffHvc9LiSxaQmlgIEzvoxWUQ9A+bGnTQDUWoUtbAOlVvg3mcywgr 5zo9Ej6FKEwbLIhTjZHYLebzvkQLYCHjA/PtqDXKiu7RlyNYJviJ7iXcpJ36kfbd/1Ijq+NNQpDOs QO9Tuoyw==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 09/14] swiotlb: lift the double initialization protection from xen-swiotlb Date: Mon, 1 Mar 2021 08:44:31 +0100 Message-Id: <20210301074436.919889-10-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301074436.919889-1-hch@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Lift the double initialization protection from xen-swiotlb to the core code to avoid exposing too many swiotlb internals. Also upgrade the check to a warning as it should not happen. Signed-off-by: Christoph Hellwig --- drivers/xen/swiotlb-xen.c | 7 ------- kernel/dma/swiotlb.c | 8 ++++++++ 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 1a31ddf7139799..060eeb056486f5 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -172,12 +172,6 @@ int __ref xen_swiotlb_init(int verbose, bool early) bytes = nslabs << IO_TLB_SHIFT; order = get_order(bytes); - /* - * IO TLB memory already allocated. Just use it. - */ - if (io_tlb_start != 0) - goto end; - /* * Get IO TLB memory from any location. */ @@ -232,7 +226,6 @@ int __ref xen_swiotlb_init(int verbose, bool early) } else rc = swiotlb_late_init_with_tbl(start, nslabs); -end: if (!rc) swiotlb_set_max_segment(PAGE_SIZE); diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 388d9be35b5795..ebe7c123e27e52 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -229,6 +229,10 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) unsigned long i, bytes; size_t alloc_size; + /* protect against double initialization */ + if (WARN_ON_ONCE(io_tlb_start)) + return -ENOMEM; + bytes = nslabs << IO_TLB_SHIFT; io_tlb_nslabs = nslabs; @@ -367,6 +371,10 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) { unsigned long i, bytes; + /* protect against double initialization */ + if (WARN_ON_ONCE(io_tlb_start)) + return -ENOMEM; + bytes = nslabs << IO_TLB_SHIFT; io_tlb_nslabs = nslabs; -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:46:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:46:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91279.172491 (Exim 4.92) (envelope-from ) id 1lGdG4-0003Ka-IC; Mon, 01 Mar 2021 07:46:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91279.172491; Mon, 01 Mar 2021 07:46:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdG4-0003KQ-DR; Mon, 01 Mar 2021 07:46:24 +0000 Received: by outflank-mailman (input) for mailman id 91279; Mon, 01 Mar 2021 07:46:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdG3-00036y-EK for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:46:23 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 59568fdb-0e0b-468d-bfce-b5d40220191a; Mon, 01 Mar 2021 07:46:19 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdFr-00FRE9-3o; Mon, 01 Mar 2021 07:46:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59568fdb-0e0b-468d-bfce-b5d40220191a DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=brl7E8YVp1JaasQZUSI4zOCBNU3VX5lh7I+3ZpJVKoQ=; b=cO0/CICsxS0v4hTlVtR0AshwTW BsQP4SA3okIlBHconzJAwHO1GHs+WlrszQeZX8PaBKPE4sTe4Pr60XvEotfhISYYsfb9GHUs6mxn5 +LUPeX4e+PyqKPmerxpZOsSOplktgII87t8Q57xX5Wdtdc6sPRJ57juxwYJQ5uVZFhq9uXQY/vibm POlSfDXa1pP3OWLz54nN2HRVZh6xiQ91PsdXS5Qqon+lvO2cQD6Qc2bfExgGVpbGTpzis4zBJTAon zOhhS34/GFAL7SGt20X25yTtEm0DWXZEh1aPLIImYDKVUb9adcUs9rZkJP08CohwnsBQYdzbUs5V+ gW+ODGhQ==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 10/14] xen-swiotlb: split xen_swiotlb_init Date: Mon, 1 Mar 2021 08:44:32 +0100 Message-Id: <20210301074436.919889-11-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301074436.919889-1-hch@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Split xen_swiotlb_init into a normal an an early case. That makes both much simpler and more readable, and also allows marking the early code as __init and x86-only. Signed-off-by: Christoph Hellwig --- arch/arm/xen/mm.c | 2 +- arch/x86/xen/pci-swiotlb-xen.c | 4 +- drivers/xen/swiotlb-xen.c | 124 +++++++++++++++++++-------------- include/xen/swiotlb-xen.h | 3 +- 4 files changed, 75 insertions(+), 58 deletions(-) diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c index 467fa225c3d0ed..aae950cd053fea 100644 --- a/arch/arm/xen/mm.c +++ b/arch/arm/xen/mm.c @@ -140,7 +140,7 @@ static int __init xen_mm_init(void) struct gnttab_cache_flush cflush; if (!xen_initial_domain()) return 0; - xen_swiotlb_init(1, false); + xen_swiotlb_init(); cflush.op = 0; cflush.a.dev_bus_addr = 0; diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c index 19ae3e4fe4e98e..54f9aa7e845739 100644 --- a/arch/x86/xen/pci-swiotlb-xen.c +++ b/arch/x86/xen/pci-swiotlb-xen.c @@ -59,7 +59,7 @@ int __init pci_xen_swiotlb_detect(void) void __init pci_xen_swiotlb_init(void) { if (xen_swiotlb) { - xen_swiotlb_init(1, true /* early */); + xen_swiotlb_init_early(); dma_ops = &xen_swiotlb_dma_ops; #ifdef CONFIG_PCI @@ -76,7 +76,7 @@ int pci_xen_swiotlb_init_late(void) if (xen_swiotlb) return 0; - rc = xen_swiotlb_init(1, false /* late */); + rc = xen_swiotlb_init(); if (rc) return rc; diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 060eeb056486f5..00adeb95ebb9df 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -156,96 +156,112 @@ static const char *xen_swiotlb_error(enum xen_swiotlb_err err) #define DEFAULT_NSLABS ALIGN(SZ_64M >> IO_TLB_SHIFT, IO_TLB_SEGSIZE) -int __ref xen_swiotlb_init(int verbose, bool early) +int __ref xen_swiotlb_init(void) { - unsigned long bytes, order; - int rc = -ENOMEM; enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN; + unsigned long nslabs, bytes, order; unsigned int repeat = 3; + int rc = -ENOMEM; char *start; - unsigned long nslabs; nslabs = swiotlb_nr_tbl(); -retry: if (!nslabs) nslabs = DEFAULT_NSLABS; +retry: + m_ret = XEN_SWIOTLB_ENOMEM; bytes = nslabs << IO_TLB_SHIFT; order = get_order(bytes); /* * Get IO TLB memory from any location. */ - if (early) { - start = memblock_alloc(PAGE_ALIGN(bytes), - PAGE_SIZE); - if (!start) - panic("%s: Failed to allocate %lu bytes align=0x%lx\n", - __func__, PAGE_ALIGN(bytes), PAGE_SIZE); - } else { #define SLABS_PER_PAGE (1 << (PAGE_SHIFT - IO_TLB_SHIFT)) #define IO_TLB_MIN_SLABS ((1<<20) >> IO_TLB_SHIFT) - while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) { - start = (void *)xen_get_swiotlb_free_pages(order); - if (start) - break; - order--; - } - if (order != get_order(bytes)) { - pr_warn("Warning: only able to allocate %ld MB for software IO TLB\n", - (PAGE_SIZE << order) >> 20); - nslabs = SLABS_PER_PAGE << order; - bytes = nslabs << IO_TLB_SHIFT; - } + while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) { + start = (void *)xen_get_swiotlb_free_pages(order); + if (start) + break; + order--; } - if (!start) { - m_ret = XEN_SWIOTLB_ENOMEM; + if (!start) goto error; + if (order != get_order(bytes)) { + pr_warn("Warning: only able to allocate %ld MB for software IO TLB\n", + (PAGE_SIZE << order) >> 20); + nslabs = SLABS_PER_PAGE << order; + bytes = nslabs << IO_TLB_SHIFT; } + /* * And replace that memory with pages under 4GB. */ - rc = xen_swiotlb_fixup(start, - bytes, - nslabs); + rc = xen_swiotlb_fixup(start, bytes, nslabs); if (rc) { - if (early) - memblock_free(__pa(start), - PAGE_ALIGN(bytes)); - else { - free_pages((unsigned long)start, order); - start = NULL; - } + free_pages((unsigned long)start, order); m_ret = XEN_SWIOTLB_EFIXUP; goto error; } - if (early) { - if (swiotlb_init_with_tbl(start, nslabs, - verbose)) - panic("Cannot allocate SWIOTLB buffer"); - rc = 0; - } else - rc = swiotlb_late_init_with_tbl(start, nslabs); - - if (!rc) - swiotlb_set_max_segment(PAGE_SIZE); - - return rc; + rc = swiotlb_late_init_with_tbl(start, nslabs); + if (rc) + return rc; + swiotlb_set_max_segment(PAGE_SIZE); + return 0; error: if (repeat--) { - nslabs = max(1024UL, /* Min is 2MB */ - (nslabs >> 1)); + /* Min is 2MB */ + nslabs = max(1024UL, (nslabs >> 1)); pr_info("Lowering to %luMB\n", (nslabs << IO_TLB_SHIFT) >> 20); goto retry; } pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc); - if (early) - panic("%s (rc:%d)", xen_swiotlb_error(m_ret), rc); - else - free_pages((unsigned long)start, order); + free_pages((unsigned long)start, order); return rc; } +#ifdef CONFIG_X86 +void __init xen_swiotlb_init_early(void) +{ + unsigned long nslabs, bytes; + unsigned int repeat = 3; + char *start; + int rc; + + nslabs = swiotlb_nr_tbl(); + if (!nslabs) + nslabs = DEFAULT_NSLABS; +retry: + /* + * Get IO TLB memory from any location. + */ + bytes = nslabs << IO_TLB_SHIFT; + start = memblock_alloc(PAGE_ALIGN(bytes), PAGE_SIZE); + if (!start) + panic("%s: Failed to allocate %lu bytes align=0x%lx\n", + __func__, PAGE_ALIGN(bytes), PAGE_SIZE); + + /* + * And replace that memory with pages under 4GB. + */ + rc = xen_swiotlb_fixup(start, bytes, nslabs); + if (rc) { + memblock_free(__pa(start), PAGE_ALIGN(bytes)); + if (repeat--) { + /* Min is 2MB */ + nslabs = max(1024UL, (nslabs >> 1)); + pr_info("Lowering to %luMB\n", + (nslabs << IO_TLB_SHIFT) >> 20); + goto retry; + } + panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc); + } + + if (swiotlb_init_with_tbl(start, nslabs, false)) + panic("Cannot allocate SWIOTLB buffer"); + swiotlb_set_max_segment(PAGE_SIZE); +} +#endif /* CONFIG_X86 */ + static void * xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size, dma_addr_t *dma_handle, gfp_t flags, diff --git a/include/xen/swiotlb-xen.h b/include/xen/swiotlb-xen.h index d5eaf9d682b804..6206b1ec99168a 100644 --- a/include/xen/swiotlb-xen.h +++ b/include/xen/swiotlb-xen.h @@ -9,7 +9,8 @@ void xen_dma_sync_for_cpu(struct device *dev, dma_addr_t handle, void xen_dma_sync_for_device(struct device *dev, dma_addr_t handle, size_t size, enum dma_data_direction dir); -extern int xen_swiotlb_init(int verbose, bool early); +int xen_swiotlb_init(void); +void __init xen_swiotlb_init_early(void); extern const struct dma_map_ops xen_swiotlb_dma_ops; #endif /* __LINUX_SWIOTLB_XEN_H */ -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:46:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:46:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91283.172503 (Exim 4.92) (envelope-from ) id 1lGdGF-0003US-1h; Mon, 01 Mar 2021 07:46:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91283.172503; Mon, 01 Mar 2021 07:46:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdGE-0003UK-Tv; Mon, 01 Mar 2021 07:46:34 +0000 Received: by outflank-mailman (input) for mailman id 91283; Mon, 01 Mar 2021 07:46:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdGD-0003Px-FD for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:46:33 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f8907fb7-1183-41fc-8ced-cf8aac6b1f92; Mon, 01 Mar 2021 07:46:26 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdFu-00FREl-Fr; Mon, 01 Mar 2021 07:46:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8907fb7-1183-41fc-8ced-cf8aac6b1f92 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=mXkVhFtn8HeR3wavy6jqxTMaaOwapdi0UDpQuxnpggo=; b=MbcvSu3J2A/2YUuOQNftUQ40jQ oUyLNnz0N1TEM4xM+lm4M86OFbd+5jWcWV5H8fJ+wevrT5rjsxPmbvlkku5a6L6YhDxVew8znrmgZ Cf4ecqDKrnijw22rBE/MZaMd92C/DYnWIjSgWuViL9Ymn0FdRFdRKjFO/m6MuCJK/C08WYdQ4wXJw RCCZEzP9gpPvK7pZcDtyRKDuANbg/bRDXobijdkIyKk1Kl6on4DGYufGNrrPCBvvUVmZ0qyKVx7a7 Z565H9liCHB8m+RNFQsMXMoPrF3YD83Axz+iZTxR69IH2XG69+UqAc6OkrTK4pIgFoNfVbM/GwwPA 87TI1Fjg==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 11/14] xen-swiotlb: remove the unused size argument from xen_swiotlb_fixup Date: Mon, 1 Mar 2021 08:44:33 +0100 Message-Id: <20210301074436.919889-12-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301074436.919889-1-hch@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Signed-off-by: Christoph Hellwig --- drivers/xen/swiotlb-xen.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 00adeb95ebb9df..4ecfce2c6f7263 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -104,8 +104,7 @@ static int is_xen_swiotlb_buffer(struct device *dev, dma_addr_t dma_addr) return 0; } -static int -xen_swiotlb_fixup(void *buf, size_t size, unsigned long nslabs) +static int xen_swiotlb_fixup(void *buf, unsigned long nslabs) { int i, rc; int dma_bits; @@ -195,7 +194,7 @@ int __ref xen_swiotlb_init(void) /* * And replace that memory with pages under 4GB. */ - rc = xen_swiotlb_fixup(start, bytes, nslabs); + rc = xen_swiotlb_fixup(start, nslabs); if (rc) { free_pages((unsigned long)start, order); m_ret = XEN_SWIOTLB_EFIXUP; @@ -243,7 +242,7 @@ void __init xen_swiotlb_init_early(void) /* * And replace that memory with pages under 4GB. */ - rc = xen_swiotlb_fixup(start, bytes, nslabs); + rc = xen_swiotlb_fixup(start, nslabs); if (rc) { memblock_free(__pa(start), PAGE_ALIGN(bytes)); if (repeat--) { -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:46:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:46:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91284.172515 (Exim 4.92) (envelope-from ) id 1lGdGK-0003ZY-BE; Mon, 01 Mar 2021 07:46:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91284.172515; Mon, 01 Mar 2021 07:46:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdGK-0003ZN-7Q; Mon, 01 Mar 2021 07:46:40 +0000 Received: by outflank-mailman (input) for mailman id 91284; Mon, 01 Mar 2021 07:46:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdGI-0003Px-HT for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:46:38 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 37320e27-4c2c-4bb2-bd03-bf2f4de314cc; Mon, 01 Mar 2021 07:46:36 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdG1-00FRFO-Qp; Mon, 01 Mar 2021 07:46:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37320e27-4c2c-4bb2-bd03-bf2f4de314cc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=81M6EJPI3vkCtYnpFa0x4gniskFZXPw81KUK+OV+b2E=; b=HUTc/sQJH9VIyxfTKlMOFXA8mh 1hx2sw1uXE8i9EXaUGwspaQ5tiNwyZayIKCm2EBLLamUOrDVgrR3x+jzSCV3A7+ZFClygClxqJAzI WCQhx1P7IBp93xu0Wgqj7bGXMiIXAn8dFlUDsD7EAJpwF0+Dz6PHM09tCTxcW1dWXCUh+DS7uvJwB 9hX5wP43qtWNKxLup518cW2MhEFWy/79IxhX4iyy7Q6AFNPKH7GMLk+phrlo/VE/z5hb0yoUDmTLa HcZl+u4kGVipTyyV83ID7PcJLANbYevmwLYwvy9Bi0U+4ByqmfrTM/34J9nribzAetC+Ba/2MNiSS dyY8up2g==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 12/14] swiotlb: move global variables into a new io_tlb_mem structure Date: Mon, 1 Mar 2021 08:44:34 +0100 Message-Id: <20210301074436.919889-13-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301074436.919889-1-hch@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html From: Claire Chang Added a new struct, io_tlb_mem, as the IO TLB memory pool descriptor and moved relevant global variables into that struct. This will be useful later to allow for restricted DMA pool. Signed-off-by: Claire Chang [hch: rebased] Signed-off-by: Christoph Hellwig --- drivers/xen/swiotlb-xen.c | 2 +- include/linux/swiotlb.h | 43 ++++- kernel/dma/swiotlb.c | 354 +++++++++++++++++--------------------- 3 files changed, 203 insertions(+), 196 deletions(-) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 4ecfce2c6f7263..5329ad54a5f34e 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -548,7 +548,7 @@ xen_swiotlb_sync_sg_for_device(struct device *dev, struct scatterlist *sgl, static int xen_swiotlb_dma_supported(struct device *hwdev, u64 mask) { - return xen_phys_to_dma(hwdev, io_tlb_end - 1) <= mask; + return xen_phys_to_dma(hwdev, io_tlb_default_mem.end - 1) <= mask; } const struct dma_map_ops xen_swiotlb_dma_ops = { diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 0696bdc8072e97..5ec5378b17c333 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -6,6 +6,7 @@ #include #include #include +#include struct device; struct page; @@ -61,11 +62,49 @@ dma_addr_t swiotlb_map(struct device *dev, phys_addr_t phys, #ifdef CONFIG_SWIOTLB extern enum swiotlb_force swiotlb_force; -extern phys_addr_t io_tlb_start, io_tlb_end; + +/** + * struct io_tlb_mem - IO TLB Memory Pool Descriptor + * + * @start: The start address of the swiotlb memory pool. Used to do a quick + * range check to see if the memory was in fact allocated by this + * API. + * @end: The end address of the swiotlb memory pool. Used to do a quick + * range check to see if the memory was in fact allocated by this + * API. + * @nslabs: The number of IO TLB blocks (in groups of 64) between @start and + * @end. This is command line adjustable via setup_io_tlb_npages. + * @used: The number of used IO TLB block. + * @list: The free list describing the number of free entries available + * from each index. + * @index: The index to start searching in the next round. + * @orig_addr: The original address corresponding to a mapped entry. + * @alloc_size: Size of the allocated buffer. + * @lock: The lock to protect the above data structures in the map and + * unmap calls. + * @debugfs: The dentry to debugfs. + * @late_alloc: %true if allocated using the page allocator + */ +struct io_tlb_mem { + phys_addr_t start; + phys_addr_t end; + unsigned long nslabs; + unsigned long used; + unsigned int *list; + unsigned int index; + phys_addr_t *orig_addr; + size_t *alloc_size; + spinlock_t lock; + struct dentry *debugfs; + bool late_alloc; +}; +extern struct io_tlb_mem io_tlb_default_mem; static inline bool is_swiotlb_buffer(phys_addr_t paddr) { - return paddr >= io_tlb_start && paddr < io_tlb_end; + struct io_tlb_mem *mem = &io_tlb_default_mem; + + return paddr >= mem->start && paddr < mem->end; } void __init swiotlb_exit(void); diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index ebe7c123e27e52..6aa84fa3b1467e 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -59,32 +59,11 @@ */ #define IO_TLB_MIN_SLABS ((1<<20) >> IO_TLB_SHIFT) -enum swiotlb_force swiotlb_force; - -/* - * Used to do a quick range check in swiotlb_tbl_unmap_single and - * swiotlb_tbl_sync_single_*, to see if the memory was in fact allocated by this - * API. - */ -phys_addr_t io_tlb_start, io_tlb_end; - -/* - * The number of IO TLB blocks (in groups of 64) between io_tlb_start and - * io_tlb_end. This is command line adjustable via setup_io_tlb_npages. - */ -static unsigned long io_tlb_nslabs; +#define INVALID_PHYS_ADDR (~(phys_addr_t)0) -/* - * The number of used IO TLB block - */ -static unsigned long io_tlb_used; +enum swiotlb_force swiotlb_force; -/* - * This is a free list describing the number of free entries available from - * each index - */ -static unsigned int *io_tlb_list; -static unsigned int io_tlb_index; +struct io_tlb_mem io_tlb_default_mem; /* * Max segment that we can provide which (if pages are contingous) will @@ -92,32 +71,15 @@ static unsigned int io_tlb_index; */ static unsigned int max_segment; -/* - * We need to save away the original address corresponding to a mapped entry - * for the sync operations. - */ -#define INVALID_PHYS_ADDR (~(phys_addr_t)0) -static phys_addr_t *io_tlb_orig_addr; - -/* - * The mapped buffer's size should be validated during a sync operation. - */ -static size_t *io_tlb_alloc_size; - -/* - * Protect the above data structures in the map and unmap calls - */ -static DEFINE_SPINLOCK(io_tlb_lock); - -static int late_alloc; - static int __init setup_io_tlb_npages(char *str) { + struct io_tlb_mem *mem = &io_tlb_default_mem; + if (isdigit(*str)) { - io_tlb_nslabs = simple_strtoul(str, &str, 0); + mem->nslabs = simple_strtoul(str, &str, 0); /* avoid tail segment of size < IO_TLB_SEGSIZE */ - io_tlb_nslabs = ALIGN(io_tlb_nslabs, IO_TLB_SEGSIZE); + mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); } if (*str == ',') ++str; @@ -125,7 +87,7 @@ setup_io_tlb_npages(char *str) swiotlb_force = SWIOTLB_FORCE; } else if (!strcmp(str, "noforce")) { swiotlb_force = SWIOTLB_NO_FORCE; - io_tlb_nslabs = 1; + mem->nslabs = 1; } return 0; @@ -136,7 +98,7 @@ static bool no_iotlb_memory; unsigned long swiotlb_nr_tbl(void) { - return unlikely(no_iotlb_memory) ? 0 : io_tlb_nslabs; + return unlikely(no_iotlb_memory) ? 0 : io_tlb_default_mem.nslabs; } EXPORT_SYMBOL_GPL(swiotlb_nr_tbl); @@ -158,13 +120,14 @@ unsigned long swiotlb_size_or_default(void) { unsigned long size; - size = io_tlb_nslabs << IO_TLB_SHIFT; + size = io_tlb_default_mem.nslabs << IO_TLB_SHIFT; return size ? size : (IO_TLB_DEFAULT_SIZE); } void __init swiotlb_adjust_size(unsigned long new_size) { + struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned long size; /* @@ -172,10 +135,10 @@ void __init swiotlb_adjust_size(unsigned long new_size) * architectures such as those supporting memory encryption to * adjust/expand SWIOTLB size for their use. */ - if (!io_tlb_nslabs) { + if (!mem->nslabs) { size = ALIGN(new_size, IO_TLB_SIZE); - io_tlb_nslabs = size >> IO_TLB_SHIFT; - io_tlb_nslabs = ALIGN(io_tlb_nslabs, IO_TLB_SEGSIZE); + mem->nslabs = size >> IO_TLB_SHIFT; + mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); pr_info("SWIOTLB bounce buffer size adjusted to %luMB", size >> 20); } @@ -183,14 +146,15 @@ void __init swiotlb_adjust_size(unsigned long new_size) void swiotlb_print_info(void) { - unsigned long bytes = io_tlb_nslabs << IO_TLB_SHIFT; + struct io_tlb_mem *mem = &io_tlb_default_mem; + unsigned long bytes = mem->nslabs << IO_TLB_SHIFT; if (no_iotlb_memory) { pr_warn("No low mem\n"); return; } - pr_info("mapped [mem %pa-%pa] (%luMB)\n", &io_tlb_start, &io_tlb_end, + pr_info("mapped [mem %pa-%pa] (%luMB)\n", &mem->start, &mem->end, bytes >> 20); } @@ -212,68 +176,65 @@ static inline unsigned long nr_slots(u64 val) */ void __init swiotlb_update_mem_attributes(void) { + struct io_tlb_mem *mem = &io_tlb_default_mem; void *vaddr; unsigned long bytes; - if (no_iotlb_memory || late_alloc) + if (no_iotlb_memory || mem->late_alloc) return; - vaddr = phys_to_virt(io_tlb_start); - bytes = PAGE_ALIGN(io_tlb_nslabs << IO_TLB_SHIFT); + vaddr = phys_to_virt(mem->start); + bytes = PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT); set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT); memset(vaddr, 0, bytes); } int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) { + struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned long i, bytes; size_t alloc_size; /* protect against double initialization */ - if (WARN_ON_ONCE(io_tlb_start)) + if (WARN_ON_ONCE(mem->start)) return -ENOMEM; bytes = nslabs << IO_TLB_SHIFT; - io_tlb_nslabs = nslabs; - io_tlb_start = __pa(tlb); - io_tlb_end = io_tlb_start + bytes; + mem->nslabs = nslabs; + mem->start = __pa(tlb); + mem->end = mem->start + bytes; + mem->index = 0; + spin_lock_init(&mem->lock); /* * Allocate and initialize the free list array. This array is used * to find contiguous free memory regions of size up to IO_TLB_SEGSIZE - * between io_tlb_start and io_tlb_end. + * between mem->start and mem->end. */ - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(int)); - io_tlb_list = memblock_alloc(alloc_size, PAGE_SIZE); - if (!io_tlb_list) + alloc_size = PAGE_ALIGN(mem->nslabs * sizeof(int)); + mem->list = memblock_alloc(alloc_size, PAGE_SIZE); + if (!mem->list) panic("%s: Failed to allocate %zu bytes align=0x%lx\n", __func__, alloc_size, PAGE_SIZE); - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(phys_addr_t)); - io_tlb_orig_addr = memblock_alloc(alloc_size, PAGE_SIZE); - if (!io_tlb_orig_addr) + alloc_size = PAGE_ALIGN(mem->nslabs * sizeof(phys_addr_t)); + mem->orig_addr = memblock_alloc(alloc_size, PAGE_SIZE); + if (!mem->orig_addr) panic("%s: Failed to allocate %zu bytes align=0x%lx\n", __func__, alloc_size, PAGE_SIZE); - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t)); - io_tlb_alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); - if (!io_tlb_alloc_size) - panic("%s: Failed to allocate %zu bytes align=0x%lx\n", - __func__, alloc_size, PAGE_SIZE); - - for (i = 0; i < io_tlb_nslabs; i++) { - io_tlb_list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); - io_tlb_orig_addr[i] = INVALID_PHYS_ADDR; - io_tlb_alloc_size[i] = 0; + for (i = 0; i < mem->nslabs; i++) { + mem->list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); + mem->orig_addr[i] = INVALID_PHYS_ADDR; + mem->alloc_size[i] = 0; } - io_tlb_index = 0; no_iotlb_memory = false; if (verbose) swiotlb_print_info(); - swiotlb_set_max_segment(io_tlb_nslabs << IO_TLB_SHIFT); + swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT); return 0; } @@ -284,26 +245,27 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) void __init swiotlb_init(int verbose) { + struct io_tlb_mem *mem = &io_tlb_default_mem; size_t default_size = IO_TLB_DEFAULT_SIZE; unsigned char *vstart; unsigned long bytes; - if (!io_tlb_nslabs) { - io_tlb_nslabs = (default_size >> IO_TLB_SHIFT); - io_tlb_nslabs = ALIGN(io_tlb_nslabs, IO_TLB_SEGSIZE); + if (!mem->nslabs) { + mem->nslabs = (default_size >> IO_TLB_SHIFT); + mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); } - bytes = io_tlb_nslabs << IO_TLB_SHIFT; + bytes = mem->nslabs << IO_TLB_SHIFT; /* Get IO TLB memory from the low pages */ vstart = memblock_alloc_low(PAGE_ALIGN(bytes), PAGE_SIZE); - if (vstart && !swiotlb_init_with_tbl(vstart, io_tlb_nslabs, verbose)) + if (vstart && !swiotlb_init_with_tbl(vstart, mem->nslabs, verbose)) return; - if (io_tlb_start) { - memblock_free_early(io_tlb_start, - PAGE_ALIGN(io_tlb_nslabs << IO_TLB_SHIFT)); - io_tlb_start = 0; + if (mem->start) { + memblock_free_early(mem->start, + PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT)); + mem->start = 0; } pr_warn("Cannot allocate buffer"); no_iotlb_memory = true; @@ -317,22 +279,23 @@ swiotlb_init(int verbose) int swiotlb_late_init_with_default_size(size_t default_size) { - unsigned long bytes, req_nslabs = io_tlb_nslabs; + struct io_tlb_mem *mem = &io_tlb_default_mem; + unsigned long bytes, req_nslabs = mem->nslabs; unsigned char *vstart = NULL; unsigned int order; int rc = 0; - if (!io_tlb_nslabs) { - io_tlb_nslabs = (default_size >> IO_TLB_SHIFT); - io_tlb_nslabs = ALIGN(io_tlb_nslabs, IO_TLB_SEGSIZE); + if (!mem->nslabs) { + mem->nslabs = (default_size >> IO_TLB_SHIFT); + mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); } /* * Get IO TLB memory from the low pages */ - order = get_order(io_tlb_nslabs << IO_TLB_SHIFT); - io_tlb_nslabs = SLABS_PER_PAGE << order; - bytes = io_tlb_nslabs << IO_TLB_SHIFT; + order = get_order(mem->nslabs << IO_TLB_SHIFT); + mem->nslabs = SLABS_PER_PAGE << order; + bytes = mem->nslabs << IO_TLB_SHIFT; while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) { vstart = (void *)__get_free_pages(GFP_DMA | __GFP_NOWARN, @@ -343,15 +306,15 @@ swiotlb_late_init_with_default_size(size_t default_size) } if (!vstart) { - io_tlb_nslabs = req_nslabs; + mem->nslabs = req_nslabs; return -ENOMEM; } if (order != get_order(bytes)) { pr_warn("only able to allocate %ld MB\n", (PAGE_SIZE << order) >> 20); - io_tlb_nslabs = SLABS_PER_PAGE << order; + mem->nslabs = SLABS_PER_PAGE << order; } - rc = swiotlb_late_init_with_tbl(vstart, io_tlb_nslabs); + rc = swiotlb_late_init_with_tbl(vstart, mem->nslabs); if (rc) free_pages((unsigned long)vstart, order); @@ -360,26 +323,32 @@ swiotlb_late_init_with_default_size(size_t default_size) static void swiotlb_cleanup(void) { - io_tlb_end = 0; - io_tlb_start = 0; - io_tlb_nslabs = 0; + struct io_tlb_mem *mem = &io_tlb_default_mem; + + mem->end = 0; + mem->start = 0; + mem->nslabs = 0; max_segment = 0; } int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) { + struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned long i, bytes; /* protect against double initialization */ - if (WARN_ON_ONCE(io_tlb_start)) + if (WARN_ON_ONCE(mem->start)) return -ENOMEM; bytes = nslabs << IO_TLB_SHIFT; - io_tlb_nslabs = nslabs; - io_tlb_start = virt_to_phys(tlb); - io_tlb_end = io_tlb_start + bytes; + mem->nslabs = nslabs; + mem->start = virt_to_phys(tlb); + mem->end = mem->start + bytes; + mem->index = 0; + mem->late_alloc = 1; + spin_lock_init(&mem->lock); set_memory_decrypted((unsigned long)tlb, bytes >> PAGE_SHIFT); memset(tlb, 0, bytes); @@ -387,52 +356,45 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) /* * Allocate and initialize the free list array. This array is used * to find contiguous free memory regions of size up to IO_TLB_SEGSIZE - * between io_tlb_start and io_tlb_end. + * between mem->start and mem->end. */ - io_tlb_list = (unsigned int *)__get_free_pages(GFP_KERNEL, - get_order(io_tlb_nslabs * sizeof(int))); - if (!io_tlb_list) + mem->list = (unsigned int *)__get_free_pages(GFP_KERNEL, + get_order(mem->nslabs * sizeof(int))); + if (!mem->list) goto cleanup3; - io_tlb_orig_addr = (phys_addr_t *) + mem->orig_addr = (phys_addr_t *) __get_free_pages(GFP_KERNEL, - get_order(io_tlb_nslabs * + get_order(mem->nslabs * sizeof(phys_addr_t))); - if (!io_tlb_orig_addr) + if (!mem->orig_addr) goto cleanup4; - io_tlb_alloc_size = (size_t *) + mem->alloc_size = (size_t *) __get_free_pages(GFP_KERNEL, - get_order(io_tlb_nslabs * + get_order(mem->nslabs * sizeof(size_t))); - if (!io_tlb_alloc_size) + if (!mem->alloc_size) goto cleanup5; - - for (i = 0; i < io_tlb_nslabs; i++) { - io_tlb_list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); - io_tlb_orig_addr[i] = INVALID_PHYS_ADDR; - io_tlb_alloc_size[i] = 0; + for (i = 0; i < mem->nslabs; i++) { + mem->list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); + mem->orig_addr[i] = INVALID_PHYS_ADDR; + mem->alloc_size[i] = 0; } - io_tlb_index = 0; no_iotlb_memory = false; swiotlb_print_info(); - - late_alloc = 1; - - swiotlb_set_max_segment(io_tlb_nslabs << IO_TLB_SHIFT); - + swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT); return 0; cleanup5: - free_pages((unsigned long)io_tlb_orig_addr, get_order(io_tlb_nslabs * - sizeof(phys_addr_t))); - + free_pages((unsigned long)mem->orig_addr, + get_order(mem->nslabs * sizeof(phys_addr_t))); cleanup4: - free_pages((unsigned long)io_tlb_list, get_order(io_tlb_nslabs * - sizeof(int))); - io_tlb_list = NULL; + free_pages((unsigned long)mem->list, + get_order(mem->nslabs * sizeof(int))); + mem->list = NULL; cleanup3: swiotlb_cleanup(); return -ENOMEM; @@ -440,27 +402,29 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) void __init swiotlb_exit(void) { - if (!io_tlb_orig_addr) + struct io_tlb_mem *mem = &io_tlb_default_mem; + + if (!mem->orig_addr) return; - if (late_alloc) { - free_pages((unsigned long)io_tlb_alloc_size, - get_order(io_tlb_nslabs * sizeof(size_t))); - free_pages((unsigned long)io_tlb_orig_addr, - get_order(io_tlb_nslabs * sizeof(phys_addr_t))); - free_pages((unsigned long)io_tlb_list, get_order(io_tlb_nslabs * - sizeof(int))); - free_pages((unsigned long)phys_to_virt(io_tlb_start), - get_order(io_tlb_nslabs << IO_TLB_SHIFT)); + if (mem->late_alloc) { + free_pages((unsigned long)mem->alloc_size, + get_order(mem->nslabs * sizeof(size_t))); + free_pages((unsigned long)mem->orig_addr, + get_order(mem->nslabs * sizeof(phys_addr_t))); + free_pages((unsigned long)mem->list, + get_order(mem->nslabs * sizeof(int))); + free_pages((unsigned long)phys_to_virt(mem->start), + get_order(mem->nslabs << IO_TLB_SHIFT)); } else { - memblock_free_late(__pa(io_tlb_orig_addr), - PAGE_ALIGN(io_tlb_nslabs * sizeof(phys_addr_t))); - memblock_free_late(__pa(io_tlb_alloc_size), - PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t))); - memblock_free_late(__pa(io_tlb_list), - PAGE_ALIGN(io_tlb_nslabs * sizeof(int))); - memblock_free_late(io_tlb_start, - PAGE_ALIGN(io_tlb_nslabs << IO_TLB_SHIFT)); + memblock_free_late(__pa(mem->alloc_size), + PAGE_ALIGN(mem->nslabs * sizeof(size_t))); + memblock_free_late(__pa(mem->orig_addr), + PAGE_ALIGN(mem->nslabs * sizeof(phys_addr_t))); + memblock_free_late(__pa(mem->list), + PAGE_ALIGN(mem->nslabs * sizeof(int))); + memblock_free_late(mem->start, + PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT)); } swiotlb_cleanup(); } @@ -471,9 +435,10 @@ void __init swiotlb_exit(void) static void swiotlb_bounce(struct device *dev, phys_addr_t tlb_addr, size_t size, enum dma_data_direction dir) { - int index = (tlb_addr - io_tlb_start) >> IO_TLB_SHIFT; - size_t alloc_size = io_tlb_alloc_size[index]; - phys_addr_t orig_addr = io_tlb_orig_addr[index]; + struct io_tlb_mem *mem = &io_tlb_default_mem; + int index = (tlb_addr - mem->start) >> IO_TLB_SHIFT; + phys_addr_t orig_addr = mem->orig_addr[index]; + size_t alloc_size = mem->alloc_size[index]; unsigned long pfn = PFN_DOWN(orig_addr); unsigned char *vaddr = phys_to_virt(tlb_addr); @@ -538,9 +503,9 @@ static inline unsigned long get_max_slots(unsigned long boundary_mask) return nr_slots(boundary_mask + 1); } -static unsigned int wrap_index(unsigned int index) +static unsigned int wrap_index(struct io_tlb_mem *mem, unsigned int index) { - if (index >= io_tlb_nslabs) + if (index >= mem->nslabs) return 0; return index; } @@ -552,9 +517,10 @@ static unsigned int wrap_index(unsigned int index) static int find_slots(struct device *dev, phys_addr_t orig_addr, size_t alloc_size) { + struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned long boundary_mask = dma_get_seg_boundary(dev); dma_addr_t tbl_dma_addr = - phys_to_dma_unencrypted(dev, io_tlb_start) & boundary_mask; + phys_to_dma_unencrypted(dev, mem->start) & boundary_mask; unsigned long max_slots = get_max_slots(boundary_mask); unsigned int iotlb_align_mask = dma_get_min_align_mask(dev) & ~(IO_TLB_SIZE - 1); @@ -573,15 +539,15 @@ static int find_slots(struct device *dev, phys_addr_t orig_addr, if (alloc_size >= PAGE_SIZE) stride = max(stride, stride << (PAGE_SHIFT - IO_TLB_SHIFT)); - spin_lock_irqsave(&io_tlb_lock, flags); - if (unlikely(nslots > io_tlb_nslabs - io_tlb_used)) + spin_lock_irqsave(&mem->lock, flags); + if (unlikely(nslots > mem->nslabs - mem->used)) goto not_found; - index = wrap = wrap_index(ALIGN(io_tlb_index, stride)); + index = wrap = wrap_index(mem, ALIGN(mem->index, stride)); do { if ((slot_addr(tbl_dma_addr, index) & iotlb_align_mask) != (orig_addr & iotlb_align_mask)) { - index = wrap_index(index + 1); + index = wrap_index(mem, index + 1); continue; } @@ -593,34 +559,34 @@ static int find_slots(struct device *dev, phys_addr_t orig_addr, if (!iommu_is_span_boundary(index, nslots, nr_slots(tbl_dma_addr), max_slots)) { - if (io_tlb_list[index] >= nslots) + if (mem->list[index] >= nslots) goto found; } - index = wrap_index(index + stride); + index = wrap_index(mem, index + stride); } while (index != wrap); not_found: - spin_unlock_irqrestore(&io_tlb_lock, flags); + spin_unlock_irqrestore(&mem->lock, flags); return -1; found: for (i = index; i < index + nslots; i++) - io_tlb_list[i] = 0; + mem->list[i] = 0; for (i = index - 1; io_tlb_offset(i) != IO_TLB_SEGSIZE - 1 && - io_tlb_list[i]; i--) - io_tlb_list[i] = ++count; + mem->list[i]; i--) + mem->list[i] = ++count; /* * Update the indices to avoid searching in the next round. */ - if (index + nslots < io_tlb_nslabs) - io_tlb_index = index + nslots; + if (index + nslots < mem->nslabs) + mem->index = index + nslots; else - io_tlb_index = 0; - io_tlb_used += nslots; + mem->index = 0; + mem->used += nslots; - spin_unlock_irqrestore(&io_tlb_lock, flags); + spin_unlock_irqrestore(&mem->lock, flags); return index; } @@ -628,6 +594,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, size_t mapping_size, size_t alloc_size, enum dma_data_direction dir, unsigned long attrs) { + struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned int offset = swiotlb_align_offset(dev, orig_addr); unsigned int index, i; phys_addr_t tlb_addr; @@ -649,7 +616,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, if (!(attrs & DMA_ATTR_NO_WARN)) dev_warn_ratelimited(dev, "swiotlb buffer is full (sz: %zd bytes), total %lu (slots), used %lu (slots)\n", - alloc_size, io_tlb_nslabs, io_tlb_used); + alloc_size, mem->nslabs, mem->used); return (phys_addr_t)DMA_MAPPING_ERROR; } @@ -659,10 +626,10 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, * needed. */ for (i = 0; i < nr_slots(alloc_size + offset); i++) { - io_tlb_orig_addr[index + i] = slot_addr(orig_addr, i); - io_tlb_alloc_size[index+i] = alloc_size - (i << IO_TLB_SHIFT); + mem->orig_addr[index + i] = slot_addr(orig_addr, i); + mem->alloc_size[index + i] = alloc_size - (i << IO_TLB_SHIFT); } - tlb_addr = slot_addr(io_tlb_start, index) + offset; + tlb_addr = slot_addr(mem->start, index) + offset; if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) && (dir == DMA_TO_DEVICE || dir == DMA_BIDIRECTIONAL)) swiotlb_bounce(dev, tlb_addr, mapping_size, DMA_TO_DEVICE); @@ -676,10 +643,11 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, size_t mapping_size, enum dma_data_direction dir, unsigned long attrs) { + struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned long flags; unsigned int offset = swiotlb_align_offset(hwdev, tlb_addr); - int index = (tlb_addr - offset - io_tlb_start) >> IO_TLB_SHIFT; - int nslots = nr_slots(io_tlb_alloc_size[index] + offset); + int index = (tlb_addr - offset - mem->start) >> IO_TLB_SHIFT; + int nslots = nr_slots(mem->alloc_size[index] + offset); int count, i; /* @@ -695,9 +663,9 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, * While returning the entries to the free list, we merge the entries * with slots below and above the pool being returned. */ - spin_lock_irqsave(&io_tlb_lock, flags); + spin_lock_irqsave(&mem->lock, flags); if (index + nslots < ALIGN(index + 1, IO_TLB_SEGSIZE)) - count = io_tlb_list[index + nslots]; + count = mem->list[index + nslots]; else count = 0; @@ -706,9 +674,9 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, * superceeding slots */ for (i = index + nslots - 1; i >= index; i--) { - io_tlb_list[i] = ++count; - io_tlb_orig_addr[i] = INVALID_PHYS_ADDR; - io_tlb_alloc_size[i] = 0; + mem->list[i] = ++count; + mem->orig_addr[i] = INVALID_PHYS_ADDR; + mem->alloc_size[i] = 0; } /* @@ -716,11 +684,11 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, * available (non zero) */ for (i = index - 1; - io_tlb_offset(i) != IO_TLB_SEGSIZE - 1 && io_tlb_list[i]; + io_tlb_offset(i) != IO_TLB_SEGSIZE - 1 && mem->list[i]; i--) - io_tlb_list[i] = ++count; - io_tlb_used -= nslots; - spin_unlock_irqrestore(&io_tlb_lock, flags); + mem->list[i] = ++count; + mem->used -= nslots; + spin_unlock_irqrestore(&mem->lock, flags); } void swiotlb_sync_single_for_device(struct device *dev, phys_addr_t tlb_addr, @@ -783,21 +751,21 @@ size_t swiotlb_max_mapping_size(struct device *dev) bool is_swiotlb_active(void) { /* - * When SWIOTLB is initialized, even if io_tlb_start points to physical - * address zero, io_tlb_end surely doesn't. + * When SWIOTLB is initialized, even if mem->start points to physical + * address zero, mem->end surely doesn't. */ - return io_tlb_end != 0; + return io_tlb_default_mem.end != 0; } #ifdef CONFIG_DEBUG_FS static int __init swiotlb_create_debugfs(void) { - struct dentry *root; + struct io_tlb_mem *mem = &io_tlb_default_mem; - root = debugfs_create_dir("swiotlb", NULL); - debugfs_create_ulong("io_tlb_nslabs", 0400, root, &io_tlb_nslabs); - debugfs_create_ulong("io_tlb_used", 0400, root, &io_tlb_used); + mem->debugfs = debugfs_create_dir("swiotlb", NULL); + debugfs_create_ulong("io_tlb_nslabs", 0400, mem->debugfs, &mem->nslabs); + debugfs_create_ulong("io_tlb_used", 0400, mem->debugfs, &mem->used); return 0; } -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:47:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:47:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91292.172527 (Exim 4.92) (envelope-from ) id 1lGdGd-0003mN-Tv; Mon, 01 Mar 2021 07:46:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91292.172527; Mon, 01 Mar 2021 07:46:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdGd-0003mE-QP; Mon, 01 Mar 2021 07:46:59 +0000 Received: by outflank-mailman (input) for mailman id 91292; Mon, 01 Mar 2021 07:46:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdGc-0003Px-Fo for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:46:58 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e632e6a4-91a5-43c2-a0ab-a484934d2c5c; Mon, 01 Mar 2021 07:46:46 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdG9-00FRGI-DD; Mon, 01 Mar 2021 07:46:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e632e6a4-91a5-43c2-a0ab-a484934d2c5c DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=IRx+Pi1pD2z501lxg6zw7GkdxsvxCqbOuoP9Ueee5qA=; b=duV9FY07kMgTOlwKmQNCqAWEUf HjMyR8HaEfGmccKEKenMvn/1dBX50Ok55KK5MtUOkSpqafeHtQNadPiMrKGb3QbBwegZbFGao8obV mY5aLxa4tn+8dC3UpfhNc7lQs2fv48Mp3fvXx+Qa3Vqk8W4a51I32NP0SxrbjdhsyOZb2HlKshJSQ CAe/Ix/J5ywCjLm/dpsBpRfxR+7jf6rLLA7/mey+AAV1WC0Y/jSVRYwHrtBDRp1rTsPZDqweuy4xd Kt7hacQU3L56juNbddmIoZa0LvXOBR+1MjpQVBgh4IuuzLlpBcV+l3J3wTJGR26wUi2xv3tNdm3xB wvRgJZpw==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 13/14] swiotlb: dynamically allocate io_tlb_default_mem Date: Mon, 1 Mar 2021 08:44:35 +0100 Message-Id: <20210301074436.919889-14-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301074436.919889-1-hch@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Instead of allocating ->list and ->orig_addr separately just do one dynamic allocation for the actual io_tlb_mem structure. This simplifies a lot of the initialization code, and also allows to just check io_tlb_default_mem to see if swiotlb is in use. Signed-off-by: Christoph Hellwig --- drivers/xen/swiotlb-xen.c | 22 +-- include/linux/swiotlb.h | 18 ++- kernel/dma/swiotlb.c | 300 +++++++++++++------------------------- 3 files changed, 117 insertions(+), 223 deletions(-) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 5329ad54a5f34e..4c89afc0df6289 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -158,17 +158,14 @@ static const char *xen_swiotlb_error(enum xen_swiotlb_err err) int __ref xen_swiotlb_init(void) { enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN; - unsigned long nslabs, bytes, order; - unsigned int repeat = 3; + unsigned long bytes = swiotlb_size_or_default(); + unsigned long nslabs = bytes >> IO_TLB_SHIFT; + unsigned int order, repeat = 3; int rc = -ENOMEM; char *start; - nslabs = swiotlb_nr_tbl(); - if (!nslabs) - nslabs = DEFAULT_NSLABS; retry: m_ret = XEN_SWIOTLB_ENOMEM; - bytes = nslabs << IO_TLB_SHIFT; order = get_order(bytes); /* @@ -221,19 +218,16 @@ int __ref xen_swiotlb_init(void) #ifdef CONFIG_X86 void __init xen_swiotlb_init_early(void) { - unsigned long nslabs, bytes; + unsigned long bytes = swiotlb_size_or_default(); + unsigned long nslabs = bytes >> IO_TLB_SHIFT; unsigned int repeat = 3; char *start; int rc; - nslabs = swiotlb_nr_tbl(); - if (!nslabs) - nslabs = DEFAULT_NSLABS; retry: /* * Get IO TLB memory from any location. */ - bytes = nslabs << IO_TLB_SHIFT; start = memblock_alloc(PAGE_ALIGN(bytes), PAGE_SIZE); if (!start) panic("%s: Failed to allocate %lu bytes align=0x%lx\n", @@ -248,8 +242,8 @@ void __init xen_swiotlb_init_early(void) if (repeat--) { /* Min is 2MB */ nslabs = max(1024UL, (nslabs >> 1)); - pr_info("Lowering to %luMB\n", - (nslabs << IO_TLB_SHIFT) >> 20); + bytes = nslabs << IO_TLB_SHIFT; + pr_info("Lowering to %luMB\n", bytes >> 20); goto retry; } panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc); @@ -548,7 +542,7 @@ xen_swiotlb_sync_sg_for_device(struct device *dev, struct scatterlist *sgl, static int xen_swiotlb_dma_supported(struct device *hwdev, u64 mask) { - return xen_phys_to_dma(hwdev, io_tlb_default_mem.end - 1) <= mask; + return xen_phys_to_dma(hwdev, io_tlb_default_mem->end - 1) <= mask; } const struct dma_map_ops xen_swiotlb_dma_ops = { diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 5ec5378b17c333..63f7a63f61d098 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -90,28 +90,30 @@ struct io_tlb_mem { phys_addr_t end; unsigned long nslabs; unsigned long used; - unsigned int *list; unsigned int index; - phys_addr_t *orig_addr; - size_t *alloc_size; spinlock_t lock; struct dentry *debugfs; bool late_alloc; + struct io_tlb_slot { + phys_addr_t orig_addr; + size_t alloc_size; + unsigned int list; + } slots[]; }; -extern struct io_tlb_mem io_tlb_default_mem; +extern struct io_tlb_mem *io_tlb_default_mem; static inline bool is_swiotlb_buffer(phys_addr_t paddr) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; - return paddr >= mem->start && paddr < mem->end; + return mem && paddr >= mem->start && paddr < mem->end; } void __init swiotlb_exit(void); unsigned int swiotlb_max_segment(void); size_t swiotlb_max_mapping_size(struct device *dev); bool is_swiotlb_active(void); -void __init swiotlb_adjust_size(unsigned long new_size); +void __init swiotlb_adjust_size(unsigned long size); #else #define swiotlb_force SWIOTLB_NO_FORCE static inline bool is_swiotlb_buffer(phys_addr_t paddr) @@ -135,7 +137,7 @@ static inline bool is_swiotlb_active(void) return false; } -static inline void swiotlb_adjust_size(unsigned long new_size) +static inline void swiotlb_adjust_size(unsigned long size) { } #endif /* CONFIG_SWIOTLB */ diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 6aa84fa3b1467e..b7bcd7b804bfe8 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -63,7 +63,7 @@ enum swiotlb_force swiotlb_force; -struct io_tlb_mem io_tlb_default_mem; +struct io_tlb_mem *io_tlb_default_mem; /* * Max segment that we can provide which (if pages are contingous) will @@ -71,15 +71,15 @@ struct io_tlb_mem io_tlb_default_mem; */ static unsigned int max_segment; +static unsigned long default_nslabs = IO_TLB_DEFAULT_SIZE >> IO_TLB_SHIFT; + static int __init setup_io_tlb_npages(char *str) { - struct io_tlb_mem *mem = &io_tlb_default_mem; - if (isdigit(*str)) { - mem->nslabs = simple_strtoul(str, &str, 0); /* avoid tail segment of size < IO_TLB_SEGSIZE */ - mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); + default_nslabs = + ALIGN(simple_strtoul(str, &str, 0), IO_TLB_SEGSIZE); } if (*str == ',') ++str; @@ -87,24 +87,22 @@ setup_io_tlb_npages(char *str) swiotlb_force = SWIOTLB_FORCE; } else if (!strcmp(str, "noforce")) { swiotlb_force = SWIOTLB_NO_FORCE; - mem->nslabs = 1; + default_nslabs = 1; } return 0; } early_param("swiotlb", setup_io_tlb_npages); -static bool no_iotlb_memory; - unsigned long swiotlb_nr_tbl(void) { - return unlikely(no_iotlb_memory) ? 0 : io_tlb_default_mem.nslabs; + return io_tlb_default_mem ? io_tlb_default_mem->nslabs : 0; } EXPORT_SYMBOL_GPL(swiotlb_nr_tbl); unsigned int swiotlb_max_segment(void) { - return unlikely(no_iotlb_memory) ? 0 : max_segment; + return io_tlb_default_mem ? max_segment : 0; } EXPORT_SYMBOL_GPL(swiotlb_max_segment); @@ -118,44 +116,32 @@ void swiotlb_set_max_segment(unsigned int val) unsigned long swiotlb_size_or_default(void) { - unsigned long size; - - size = io_tlb_default_mem.nslabs << IO_TLB_SHIFT; - - return size ? size : (IO_TLB_DEFAULT_SIZE); + return default_nslabs << IO_TLB_SHIFT; } -void __init swiotlb_adjust_size(unsigned long new_size) +void __init swiotlb_adjust_size(unsigned long size) { - struct io_tlb_mem *mem = &io_tlb_default_mem; - unsigned long size; - /* * If swiotlb parameter has not been specified, give a chance to * architectures such as those supporting memory encryption to * adjust/expand SWIOTLB size for their use. */ - if (!mem->nslabs) { - size = ALIGN(new_size, IO_TLB_SIZE); - mem->nslabs = size >> IO_TLB_SHIFT; - mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); - - pr_info("SWIOTLB bounce buffer size adjusted to %luMB", size >> 20); - } + size = ALIGN(size, IO_TLB_SIZE); + default_nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE); + pr_info("SWIOTLB bounce buffer size adjusted to %luMB", size >> 20); } void swiotlb_print_info(void) { - struct io_tlb_mem *mem = &io_tlb_default_mem; - unsigned long bytes = mem->nslabs << IO_TLB_SHIFT; + struct io_tlb_mem *mem = io_tlb_default_mem; - if (no_iotlb_memory) { + if (!mem) { pr_warn("No low mem\n"); return; } pr_info("mapped [mem %pa-%pa] (%luMB)\n", &mem->start, &mem->end, - bytes >> 20); + (mem->nslabs << IO_TLB_SHIFT) >> 20); } static inline unsigned long io_tlb_offset(unsigned long val) @@ -176,13 +162,12 @@ static inline unsigned long nr_slots(u64 val) */ void __init swiotlb_update_mem_attributes(void) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; void *vaddr; unsigned long bytes; - if (no_iotlb_memory || mem->late_alloc) + if (!mem || mem->late_alloc) return; - vaddr = phys_to_virt(mem->start); bytes = PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT); set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT); @@ -191,49 +176,33 @@ void __init swiotlb_update_mem_attributes(void) int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) { - struct io_tlb_mem *mem = &io_tlb_default_mem; - unsigned long i, bytes; + unsigned long bytes = nslabs << IO_TLB_SHIFT, i; + struct io_tlb_mem *mem; size_t alloc_size; /* protect against double initialization */ - if (WARN_ON_ONCE(mem->start)) + if (WARN_ON_ONCE(io_tlb_default_mem)) return -ENOMEM; - bytes = nslabs << IO_TLB_SHIFT; - + alloc_size = PAGE_ALIGN(struct_size(mem, slots, nslabs)); + mem = memblock_alloc(alloc_size, PAGE_SIZE); + if (!mem) + panic("%s: Failed to allocate %zu bytes align=0x%lx\n", + __func__, alloc_size, PAGE_SIZE); mem->nslabs = nslabs; mem->start = __pa(tlb); mem->end = mem->start + bytes; mem->index = 0; spin_lock_init(&mem->lock); - - /* - * Allocate and initialize the free list array. This array is used - * to find contiguous free memory regions of size up to IO_TLB_SEGSIZE - * between mem->start and mem->end. - */ - alloc_size = PAGE_ALIGN(mem->nslabs * sizeof(int)); - mem->list = memblock_alloc(alloc_size, PAGE_SIZE); - if (!mem->list) - panic("%s: Failed to allocate %zu bytes align=0x%lx\n", - __func__, alloc_size, PAGE_SIZE); - - alloc_size = PAGE_ALIGN(mem->nslabs * sizeof(phys_addr_t)); - mem->orig_addr = memblock_alloc(alloc_size, PAGE_SIZE); - if (!mem->orig_addr) - panic("%s: Failed to allocate %zu bytes align=0x%lx\n", - __func__, alloc_size, PAGE_SIZE); - for (i = 0; i < mem->nslabs; i++) { - mem->list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); - mem->orig_addr[i] = INVALID_PHYS_ADDR; - mem->alloc_size[i] = 0; + mem->slots[i].list = IO_TLB_SEGSIZE - io_tlb_offset(i); + mem->slots[i].orig_addr = INVALID_PHYS_ADDR; + mem->slots[i].alloc_size = 0; } - no_iotlb_memory = false; + io_tlb_default_mem = mem; if (verbose) swiotlb_print_info(); - swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT); return 0; } @@ -245,30 +214,21 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) void __init swiotlb_init(int verbose) { - struct io_tlb_mem *mem = &io_tlb_default_mem; - size_t default_size = IO_TLB_DEFAULT_SIZE; - unsigned char *vstart; - unsigned long bytes; - - if (!mem->nslabs) { - mem->nslabs = (default_size >> IO_TLB_SHIFT); - mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); - } - - bytes = mem->nslabs << IO_TLB_SHIFT; + size_t bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT); + void *tlb; /* Get IO TLB memory from the low pages */ - vstart = memblock_alloc_low(PAGE_ALIGN(bytes), PAGE_SIZE); - if (vstart && !swiotlb_init_with_tbl(vstart, mem->nslabs, verbose)) - return; - - if (mem->start) { - memblock_free_early(mem->start, - PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT)); - mem->start = 0; - } + tlb = memblock_alloc_low(bytes, PAGE_SIZE); + if (!tlb) + goto fail; + if (swiotlb_init_with_tbl(tlb, default_nslabs, verbose)) + goto fail_free_mem; + return; + +fail_free_mem: + memblock_free_early(__pa(tlb), bytes); +fail: pr_warn("Cannot allocate buffer"); - no_iotlb_memory = true; } /* @@ -279,23 +239,19 @@ swiotlb_init(int verbose) int swiotlb_late_init_with_default_size(size_t default_size) { - struct io_tlb_mem *mem = &io_tlb_default_mem; - unsigned long bytes, req_nslabs = mem->nslabs; + unsigned long nslabs = + ALIGN(default_size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE); + unsigned long bytes; unsigned char *vstart = NULL; unsigned int order; int rc = 0; - if (!mem->nslabs) { - mem->nslabs = (default_size >> IO_TLB_SHIFT); - mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); - } - /* * Get IO TLB memory from the low pages */ - order = get_order(mem->nslabs << IO_TLB_SHIFT); - mem->nslabs = SLABS_PER_PAGE << order; - bytes = mem->nslabs << IO_TLB_SHIFT; + order = get_order(nslabs << IO_TLB_SHIFT); + nslabs = SLABS_PER_PAGE << order; + bytes = nslabs << IO_TLB_SHIFT; while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) { vstart = (void *)__get_free_pages(GFP_DMA | __GFP_NOWARN, @@ -305,43 +261,35 @@ swiotlb_late_init_with_default_size(size_t default_size) order--; } - if (!vstart) { - mem->nslabs = req_nslabs; + if (!vstart) return -ENOMEM; - } + if (order != get_order(bytes)) { pr_warn("only able to allocate %ld MB\n", (PAGE_SIZE << order) >> 20); - mem->nslabs = SLABS_PER_PAGE << order; + nslabs = SLABS_PER_PAGE << order; } - rc = swiotlb_late_init_with_tbl(vstart, mem->nslabs); + rc = swiotlb_late_init_with_tbl(vstart, nslabs); if (rc) free_pages((unsigned long)vstart, order); return rc; } -static void swiotlb_cleanup(void) -{ - struct io_tlb_mem *mem = &io_tlb_default_mem; - - mem->end = 0; - mem->start = 0; - mem->nslabs = 0; - max_segment = 0; -} - int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) { - struct io_tlb_mem *mem = &io_tlb_default_mem; - unsigned long i, bytes; + unsigned long bytes = nslabs << IO_TLB_SHIFT, i; + struct io_tlb_mem *mem; /* protect against double initialization */ - if (WARN_ON_ONCE(mem->start)) + if (WARN_ON_ONCE(io_tlb_default_mem)) return -ENOMEM; - bytes = nslabs << IO_TLB_SHIFT; + mem = (void *)__get_free_pages(GFP_KERNEL, + get_order(struct_size(mem, slots, nslabs))); + if (!mem) + return -ENOMEM; mem->nslabs = nslabs; mem->start = virt_to_phys(tlb); @@ -349,84 +297,35 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) mem->index = 0; mem->late_alloc = 1; spin_lock_init(&mem->lock); + for (i = 0; i < mem->nslabs; i++) { + mem->slots[i].list = IO_TLB_SEGSIZE - io_tlb_offset(i); + mem->slots[i].orig_addr = INVALID_PHYS_ADDR; + mem->slots[i].alloc_size = 0; + } set_memory_decrypted((unsigned long)tlb, bytes >> PAGE_SHIFT); memset(tlb, 0, bytes); - /* - * Allocate and initialize the free list array. This array is used - * to find contiguous free memory regions of size up to IO_TLB_SEGSIZE - * between mem->start and mem->end. - */ - mem->list = (unsigned int *)__get_free_pages(GFP_KERNEL, - get_order(mem->nslabs * sizeof(int))); - if (!mem->list) - goto cleanup3; - - mem->orig_addr = (phys_addr_t *) - __get_free_pages(GFP_KERNEL, - get_order(mem->nslabs * - sizeof(phys_addr_t))); - if (!mem->orig_addr) - goto cleanup4; - - mem->alloc_size = (size_t *) - __get_free_pages(GFP_KERNEL, - get_order(mem->nslabs * - sizeof(size_t))); - if (!mem->alloc_size) - goto cleanup5; - - for (i = 0; i < mem->nslabs; i++) { - mem->list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); - mem->orig_addr[i] = INVALID_PHYS_ADDR; - mem->alloc_size[i] = 0; - } - no_iotlb_memory = false; - + io_tlb_default_mem = mem; swiotlb_print_info(); swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT); return 0; - -cleanup5: - free_pages((unsigned long)mem->orig_addr, - get_order(mem->nslabs * sizeof(phys_addr_t))); -cleanup4: - free_pages((unsigned long)mem->list, - get_order(mem->nslabs * sizeof(int))); - mem->list = NULL; -cleanup3: - swiotlb_cleanup(); - return -ENOMEM; } void __init swiotlb_exit(void) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; + size_t size; - if (!mem->orig_addr) + if (!mem) return; - if (mem->late_alloc) { - free_pages((unsigned long)mem->alloc_size, - get_order(mem->nslabs * sizeof(size_t))); - free_pages((unsigned long)mem->orig_addr, - get_order(mem->nslabs * sizeof(phys_addr_t))); - free_pages((unsigned long)mem->list, - get_order(mem->nslabs * sizeof(int))); - free_pages((unsigned long)phys_to_virt(mem->start), - get_order(mem->nslabs << IO_TLB_SHIFT)); - } else { - memblock_free_late(__pa(mem->alloc_size), - PAGE_ALIGN(mem->nslabs * sizeof(size_t))); - memblock_free_late(__pa(mem->orig_addr), - PAGE_ALIGN(mem->nslabs * sizeof(phys_addr_t))); - memblock_free_late(__pa(mem->list), - PAGE_ALIGN(mem->nslabs * sizeof(int))); - memblock_free_late(mem->start, - PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT)); - } - swiotlb_cleanup(); + size = struct_size(mem, slots, mem->nslabs); + if (mem->late_alloc) + free_pages((unsigned long)mem, get_order(size)); + else + memblock_free_late(__pa(mem), PAGE_ALIGN(size)); + io_tlb_default_mem = NULL; } /* @@ -435,10 +334,10 @@ void __init swiotlb_exit(void) static void swiotlb_bounce(struct device *dev, phys_addr_t tlb_addr, size_t size, enum dma_data_direction dir) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; int index = (tlb_addr - mem->start) >> IO_TLB_SHIFT; - phys_addr_t orig_addr = mem->orig_addr[index]; - size_t alloc_size = mem->alloc_size[index]; + phys_addr_t orig_addr = mem->slots[index].orig_addr; + size_t alloc_size = mem->slots[index].alloc_size; unsigned long pfn = PFN_DOWN(orig_addr); unsigned char *vaddr = phys_to_virt(tlb_addr); @@ -517,7 +416,7 @@ static unsigned int wrap_index(struct io_tlb_mem *mem, unsigned int index) static int find_slots(struct device *dev, phys_addr_t orig_addr, size_t alloc_size) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; unsigned long boundary_mask = dma_get_seg_boundary(dev); dma_addr_t tbl_dma_addr = phys_to_dma_unencrypted(dev, mem->start) & boundary_mask; @@ -559,7 +458,7 @@ static int find_slots(struct device *dev, phys_addr_t orig_addr, if (!iommu_is_span_boundary(index, nslots, nr_slots(tbl_dma_addr), max_slots)) { - if (mem->list[index] >= nslots) + if (mem->slots[index].list >= nslots) goto found; } index = wrap_index(mem, index + stride); @@ -571,11 +470,11 @@ static int find_slots(struct device *dev, phys_addr_t orig_addr, found: for (i = index; i < index + nslots; i++) - mem->list[i] = 0; + mem->slots[i].list = 0; for (i = index - 1; io_tlb_offset(i) != IO_TLB_SEGSIZE - 1 && - mem->list[i]; i--) - mem->list[i] = ++count; + mem->slots[i].list; i--) + mem->slots[i].list = ++count; /* * Update the indices to avoid searching in the next round. @@ -594,12 +493,12 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, size_t mapping_size, size_t alloc_size, enum dma_data_direction dir, unsigned long attrs) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; unsigned int offset = swiotlb_align_offset(dev, orig_addr); unsigned int index, i; phys_addr_t tlb_addr; - if (no_iotlb_memory) + if (!mem) panic("Can not allocate SWIOTLB buffer earlier and can't now provide you with the DMA bounce buffer"); if (mem_encrypt_active()) @@ -626,8 +525,9 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, * needed. */ for (i = 0; i < nr_slots(alloc_size + offset); i++) { - mem->orig_addr[index + i] = slot_addr(orig_addr, i); - mem->alloc_size[index + i] = alloc_size - (i << IO_TLB_SHIFT); + mem->slots[index + i].orig_addr = slot_addr(orig_addr, i); + mem->slots[index + i].alloc_size = + alloc_size - (i << IO_TLB_SHIFT); } tlb_addr = slot_addr(mem->start, index) + offset; if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) && @@ -643,11 +543,11 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, size_t mapping_size, enum dma_data_direction dir, unsigned long attrs) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; unsigned long flags; unsigned int offset = swiotlb_align_offset(hwdev, tlb_addr); int index = (tlb_addr - offset - mem->start) >> IO_TLB_SHIFT; - int nslots = nr_slots(mem->alloc_size[index] + offset); + int nslots = nr_slots(mem->slots[index].alloc_size + offset); int count, i; /* @@ -665,7 +565,7 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, */ spin_lock_irqsave(&mem->lock, flags); if (index + nslots < ALIGN(index + 1, IO_TLB_SEGSIZE)) - count = mem->list[index + nslots]; + count = mem->slots[index + nslots].list; else count = 0; @@ -674,9 +574,9 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, * superceeding slots */ for (i = index + nslots - 1; i >= index; i--) { - mem->list[i] = ++count; - mem->orig_addr[i] = INVALID_PHYS_ADDR; - mem->alloc_size[i] = 0; + mem->slots[i].list = ++count; + mem->slots[i].orig_addr = INVALID_PHYS_ADDR; + mem->slots[i].alloc_size = 0; } /* @@ -684,9 +584,9 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, * available (non zero) */ for (i = index - 1; - io_tlb_offset(i) != IO_TLB_SEGSIZE - 1 && mem->list[i]; + io_tlb_offset(i) != IO_TLB_SEGSIZE - 1 && mem->slots[i].list; i--) - mem->list[i] = ++count; + mem->slots[i].list = ++count; mem->used -= nslots; spin_unlock_irqrestore(&mem->lock, flags); } @@ -750,19 +650,17 @@ size_t swiotlb_max_mapping_size(struct device *dev) bool is_swiotlb_active(void) { - /* - * When SWIOTLB is initialized, even if mem->start points to physical - * address zero, mem->end surely doesn't. - */ - return io_tlb_default_mem.end != 0; + return io_tlb_default_mem != NULL; } #ifdef CONFIG_DEBUG_FS static int __init swiotlb_create_debugfs(void) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; + if (!mem) + return 0; mem->debugfs = debugfs_create_dir("swiotlb", NULL); debugfs_create_ulong("io_tlb_nslabs", 0400, mem->debugfs, &mem->nslabs); debugfs_create_ulong("io_tlb_used", 0400, mem->debugfs, &mem->used); -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:47:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:47:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91295.172539 (Exim 4.92) (envelope-from ) id 1lGdGo-0003sT-8H; Mon, 01 Mar 2021 07:47:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91295.172539; Mon, 01 Mar 2021 07:47:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdGo-0003sM-3i; Mon, 01 Mar 2021 07:47:10 +0000 Received: by outflank-mailman (input) for mailman id 91295; Mon, 01 Mar 2021 07:47:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdGm-0003Px-G6 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:47:08 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 150bf699-19f9-4e2b-9394-11bc25ca000a; Mon, 01 Mar 2021 07:46:54 +0000 (UTC) Received: from [2001:4bb8:19b:e4b7:cdf9:733f:4874:8eb4] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lGdGJ-00FRGy-Ot; Mon, 01 Mar 2021 07:46:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 150bf699-19f9-4e2b-9394-11bc25ca000a DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=EvDfqiSn3rulcjf6po/DEAzkDiYY8dbrnWHudBCB31U=; b=NuEeiEt+jz2nL+G8tqDzAjhDCT sk6sMFuu25E/9wU2JOTtwf+LIn3rI3KgAlpoyZOe+7Mx17+VbccT2ZU56rfmAJ587I+611Cv6Eua9 P05heQ5oMUcxoDbrElSx3XK56ZAjA7Ykza3keQrj7x2FYuE2HaI2HKli9tU4e3LXIpv8p6snIXBJt U6oC4aVDBLMcWx4CBS5dL7ZoC00Q0Vb8WtjON8vC6PlFKcqIg2ugdoyrWD9bS7LJoxzsTUJ5t2Ska yp+PFgZ3gDWG1NEsIbSXfPb156pc19QFB4tERdHFZHJNeq9oZObZ81KUJSGDAB7JWDe9bxrRiQzY1 UkjKlPYg==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 14/14] swiotlb: remove swiotlb_nr_tbl Date: Mon, 1 Mar 2021 08:44:36 +0100 Message-Id: <20210301074436.919889-15-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301074436.919889-1-hch@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html All callers just use it to check if swiotlb is active at all, for which they can just use is_swiotlb_active. In the longer run drivers need to stop using is_swiotlb_active as well, but let's do the simple step first. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/i915/gem/i915_gem_internal.c | 2 +- drivers/gpu/drm/nouveau/nouveau_ttm.c | 2 +- drivers/pci/xen-pcifront.c | 2 +- include/linux/swiotlb.h | 1 - kernel/dma/swiotlb.c | 7 +------ 5 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_internal.c b/drivers/gpu/drm/i915/gem/i915_gem_internal.c index ad22f42541bda6..a9d65fc8aa0eab 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_internal.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_internal.c @@ -42,7 +42,7 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj) max_order = MAX_ORDER; #ifdef CONFIG_SWIOTLB - if (swiotlb_nr_tbl()) { + if (is_swiotlb_active()) { unsigned int max_segment; max_segment = swiotlb_max_segment(); diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index a37bc3d7b38b3b..9662522aa0664a 100644 --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c @@ -321,7 +321,7 @@ nouveau_ttm_init(struct nouveau_drm *drm) } #if IS_ENABLED(CONFIG_SWIOTLB) && IS_ENABLED(CONFIG_X86) - need_swiotlb = !!swiotlb_nr_tbl(); + need_swiotlb = is_swiotlb_active(); #endif ret = ttm_bo_device_init(&drm->ttm.bdev, &nouveau_bo_driver, diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c index c6fe0cfec0f681..a549e822033fd6 100644 --- a/drivers/pci/xen-pcifront.c +++ b/drivers/pci/xen-pcifront.c @@ -693,7 +693,7 @@ static int pcifront_connect_and_init_dma(struct pcifront_device *pdev) spin_unlock(&pcifront_dev_lock); - if (!err && !swiotlb_nr_tbl()) { + if (!err && !is_swiotlb_active()) { err = pci_xen_swiotlb_init_late(); if (err) dev_err(&pdev->xdev->dev, "Could not setup SWIOTLB!\n"); diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 63f7a63f61d098..216854a5e5134b 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -37,7 +37,6 @@ enum swiotlb_force { extern void swiotlb_init(int verbose); int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose); -extern unsigned long swiotlb_nr_tbl(void); unsigned long swiotlb_size_or_default(void); extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs); extern int swiotlb_late_init_with_default_size(size_t default_size); diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index b7bcd7b804bfe8..809d5fdc204675 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -94,12 +94,6 @@ setup_io_tlb_npages(char *str) } early_param("swiotlb", setup_io_tlb_npages); -unsigned long swiotlb_nr_tbl(void) -{ - return io_tlb_default_mem ? io_tlb_default_mem->nslabs : 0; -} -EXPORT_SYMBOL_GPL(swiotlb_nr_tbl); - unsigned int swiotlb_max_segment(void) { return io_tlb_default_mem ? max_segment : 0; @@ -652,6 +646,7 @@ bool is_swiotlb_active(void) { return io_tlb_default_mem != NULL; } +EXPORT_SYMBOL_GPL(is_swiotlb_active); #ifdef CONFIG_DEBUG_FS -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 07:57:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 07:57:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91307.172550 (Exim 4.92) (envelope-from ) id 1lGdQe-0005Bo-9u; Mon, 01 Mar 2021 07:57:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91307.172550; Mon, 01 Mar 2021 07:57:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdQe-0005Bh-6p; Mon, 01 Mar 2021 07:57:20 +0000 Received: by outflank-mailman (input) for mailman id 91307; Mon, 01 Mar 2021 07:57:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdQc-0005Bc-Bt for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 07:57:18 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f5c1ae32-e259-421f-8712-e8c3d8f3f140; Mon, 01 Mar 2021 07:57:16 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C8DBFAAC5; Mon, 1 Mar 2021 07:57:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f5c1ae32-e259-421f-8712-e8c3d8f3f140 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614585435; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Bm618ENHOLlPwZbs+NnfWMXdyQyfD9kLXr1Ug/4Lg1k=; b=JCakssBrBePqAAzizP9LOlOF43sKGgMfHEd0ChrLAksTVJPRuyKQ7SVk86rlQ9Uei15JCh iohchgdET0NjgqExnHkZPZiyYnRnyCYyZ7gMUkBTSJvtw50tsGlObo+sb2E54L8rS+Yn60 5X88fiA7yNHfbQajWm/cwza9u3jyec8= To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu From: Jan Beulich Subject: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11 Message-ID: <05fe3295-7993-2eb5-37bc-a6d04fde1fbc@suse.com> Date: Mon, 1 Mar 2021 08:57:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit The upcoming release complains, not entirely unreasonably: In file included from rijndael.c:33: .../xen/include/crypto/rijndael.h:55:53: note: previously declared as 'const unsigned char[]' 55 | void rijndaelEncrypt(const unsigned int [], int, const unsigned char [], | ^~~~~~~~~~~~~~~~~~~~~~ rijndael.c:865:8: error: argument 4 of type 'u8[16]' {aka 'unsigned char[16]'} with mismatched bound [-Werror=array-parameter=] 865 | u8 ct[16]) | ~~~^~~~~~ In file included from rijndael.c:33: .../xen/include/crypto/rijndael.h:56:13: note: previously declared as 'unsigned char[]' 56 | unsigned char []); | ^~~~~~~~~~~~~~~~ While it's not really clear to me why it would complain only for arg 4, the adjustment to make is obvious and riskfree also for arg 3: Simply declare the correct array dimension right away. This then allows compilers to apply checking at call sites, which seems desirable anyway. For the moment I'm leaving untouched the disagreement between u8/u32 used in the function definition and unsigned {char,int} used in the declaration, as making this consistent would call for touching further functions. Reported-by: Charles Arnold Signed-off-by: Jan Beulich --- There are quite a few more issues with gcc11, but from my brief initial inspection I'm suspecting (hoping) it'll rather be the compiler which will get further changed by the time their release gets finalized. Just one example: .../xen/include/xen/string.h:101:27: error: '__builtin_memcmp' specified bound 4 exceeds source size 0 [-Werror=stringop-overread] 101 | #define memcmp(s1, s2, n) __builtin_memcmp(s1, s2, n) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ mpparse.c:722:13: note: in expansion of macro 'memcmp' 722 | if (memcmp(mpf->mpf_signature, "_MP_", 4) == 0 && | ^~~~~~ Clearly neither the 1st nor the 2nd argument have a "source size" of 0. --- a/xen/include/crypto/rijndael.h +++ b/xen/include/crypto/rijndael.h @@ -52,7 +52,7 @@ int rijndaelKeySetupEnc(unsigned int [], const unsigned char [], int); int rijndaelKeySetupDec(unsigned int [], const unsigned char [], int); -void rijndaelEncrypt(const unsigned int [], int, const unsigned char [], - unsigned char []); +void rijndaelEncrypt(const unsigned int [], int, const unsigned char [16], + unsigned char [16]); #endif /* __RIJNDAEL_H */ From xen-devel-bounces@lists.xenproject.org Mon Mar 01 08:11:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 08:11:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91316.172581 (Exim 4.92) (envelope-from ) id 1lGddu-0007kM-26; Mon, 01 Mar 2021 08:11:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91316.172581; Mon, 01 Mar 2021 08:11:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGddt-0007kF-Ue; Mon, 01 Mar 2021 08:11:01 +0000 Received: by outflank-mailman (input) for mailman id 91316; Mon, 01 Mar 2021 08:11:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdds-0007k1-Qh for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 08:11:00 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 36c5a0b4-6fa5-460a-a2fa-16e82c7ad008; Mon, 01 Mar 2021 08:10:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id ECA42AAC5; Mon, 1 Mar 2021 08:10:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36c5a0b4-6fa5-460a-a2fa-16e82c7ad008 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614586259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=swrp9hl6sdidetG22tkJhfXywPsPVmZJSgAo0ZbE4xY=; b=EPkjV+4w5iYTXuSe1blZL+oFnjO0GpusvSRec8agcbf4DKkfGKme/iPFfkjldx5IBz2YUf TfeiY2Ui4WetcS9LegCXG8ipTyj+3wMG3aO59cmkLW2sLZB9c+vy7TI0jmPqQb1P0zwBG1 WTOU+/3P4w+MoLO3EUoOBlP57+awDqI= Subject: Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits To: Tim Deegan , Ian Jackson Cc: "xen-devel@lists.xenproject.org" , George Dunlap , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: From: Jan Beulich Message-ID: <72c3c863-7465-ce26-1f57-b71227bb2b19@suse.com> Date: Mon, 1 Mar 2021 09:10:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 26.02.2021 18:07, Tim Deegan wrote: > At 14:03 +0100 on 25 Feb (1614261809), Jan Beulich wrote: >> When none of the physical address bits in PTEs are reserved, we can't >> create any 4k (leaf) PTEs which would trigger reserved bit faults. Hence >> the present SHOPT_FAST_FAULT_PATH machinery needs to be suppressed in >> this case, which is most easily achieved by never creating any magic >> entries. >> >> To compensate a little, eliminate sh_write_p2m_entry_post()'s impact on >> such hardware. >> >> While at it, also avoid using an MMIO magic entry when that would >> truncate the incoming GFN. >> >> Requested-by: Andrew Cooper >> Signed-off-by: Jan Beulich > > Acked-by: Tim Deegan Thanks. >> I wonder if subsequently we couldn't arrange for SMEP/SMAP faults to be >> utilized instead, on capable hardware (which might well be all having >> such large a physical address width). > > I don't immediately see how, since we don't control the access type > that the guest will use. >> I further wonder whether SH_L1E_MMIO_GFN_MASK couldn't / shouldn't be >> widened. I don't see a reason why it would need confining to the low >> 32 bits of the PTE - using the full space up to bit 50 ought to be fine >> (i.e. just one address bit left set in the magic mask), and we wouldn't >> even need that many to encode a 40-bit GFN (i.e. the extra guarding >> added here wouldn't then be needed in the first place). > > Yes, I think it could be reduced to use just one reserved address bit. > IIRC we just used such a large mask so the magic entries would be > really obvious in debugging, and there was no need to support arbitrary > address widths for emulated devices. Will cook a patch, albeit I guess I'll keep as many of the bits set as possible, while still being able to encode a full-40-bit GFN. Ian - I don't suppose you'd consider this a reasonable thing to do for 4.15? It would allow limiting the negative (performance) effect the change here has. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 01 08:16:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 08:16:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91336.172593 (Exim 4.92) (envelope-from ) id 1lGdik-00086D-M8; Mon, 01 Mar 2021 08:16:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91336.172593; Mon, 01 Mar 2021 08:16:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdik-000866-J6; Mon, 01 Mar 2021 08:16:02 +0000 Received: by outflank-mailman (input) for mailman id 91336; Mon, 01 Mar 2021 08:16:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdii-000861-TY for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 08:16:00 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c78fb315-9691-428d-a6ad-545080b2472b; Mon, 01 Mar 2021 08:15:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E3B96AA4F; Mon, 1 Mar 2021 08:15:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c78fb315-9691-428d-a6ad-545080b2472b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614586559; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5ofFX9alUHmnWh7rLXoiRIRxd5GFw4k820+4nvB8bV0=; b=FjVecW7z3QJWG9udQe+smhRa6nGNh5u79uDDsuZM4UzSMiYaJxyNYwWwQtII6mT8AgOJ1g 4KN1l1uT+diPnzPHFKmw0b/d75pcUFAeEWBGXYVO3UBh+TFYpT/gDxekQ9FAQS9Fya99o+ JxgnD1nYPNKlGYoDktvkOJudynQBsLc= Subject: Re: [PATCH] VMX: use a single, global APIC access page To: "Tian, Kevin" Cc: "xen-devel@lists.xenproject.org" , Julien Grall , "Cooper, Andrew" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <1b6a411b-84e7-bfb1-647e-511a13df838c@suse.com> <7abc515b-d652-3d39-6038-99966deafdf8@suse.com> <547b40f2-3b7b-10cb-30f6-9445c784eb0b@suse.com> From: Jan Beulich Message-ID: Date: Mon, 1 Mar 2021 09:15:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.03.2021 03:18, Tian, Kevin wrote: >> From: Roger Pau Monné >> Sent: Thursday, February 11, 2021 8:27 PM >> >> On Thu, Feb 11, 2021 at 12:22:41PM +0100, Jan Beulich wrote: >>> On 11.02.2021 12:16, Roger Pau Monné wrote: >>>> On Thu, Feb 11, 2021 at 11:36:59AM +0100, Jan Beulich wrote: >>>>> On 11.02.2021 09:45, Roger Pau Monné wrote: >>>>>> On Wed, Feb 10, 2021 at 05:48:26PM +0100, Jan Beulich wrote: >>>>>>> --- a/xen/include/asm-x86/p2m.h >>>>>>> +++ b/xen/include/asm-x86/p2m.h >>>>>>> @@ -935,6 +935,9 @@ static inline unsigned int p2m_get_iommu >>>>>>> flags = IOMMUF_readable; >>>>>>> if ( !rangeset_contains_singleton(mmio_ro_ranges, mfn_x(mfn)) ) >>>>>>> flags |= IOMMUF_writable; >>>>>>> + /* VMX'es APIC access page is global and hence has no owner. >> */ >>>>>>> + if ( mfn_valid(mfn) && !page_get_owner(mfn_to_page(mfn)) ) >>>>>>> + flags = 0; >>>>>> >>>>>> Is it fine to have this page accessible to devices if the page tables >>>>>> are shared between the CPU and the IOMMU? >>>>> >>>>> No, it's not, but what do you do? As said elsewhere, devices >>>>> gaining more access than is helpful is the price we pay for >>>>> being able to share page tables. But ... >>>> >>>> I'm concerned about allowing devices to write to this shared page, as >>>> could be used as an unintended way to exchange information between >>>> domains? >>> >>> Well, such an abuse would be possible, but it wouldn't be part >>> of an ABI and hence could break at any time. Similarly I >>> wouldn't consider it an information leak if a guest abused >>> this. >> >> Hm, I'm kind of worried about having such shared page accessible to >> guests. Could Intel confirm whether pages in the 0xFEExxxxx range are >> accessible to devices in any way when using IOMMU shared page >> tables? > > 0xFEExxxxx range is special. Requests to this range are not subject to > DMA remapping (even if a valid mapping for this range exists in the > IOMMU page table). And this special treatment is true regardless of > whether interrupt remapping is enabled (which comes only after an > interrupt message to this range is recognized). For my/our education, could you outline what happens to device accesses to that range when interrupt remapping is off? And perhaps also what happens to accesses to this range that don't match the pattern of an MSI initiation (dword write)? I don't think I've been able to spot anything to this effect in the docs. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 01 08:18:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 08:18:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91340.172605 (Exim 4.92) (envelope-from ) id 1lGdlX-0008Fc-5a; Mon, 01 Mar 2021 08:18:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91340.172605; Mon, 01 Mar 2021 08:18:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdlX-0008FV-1d; Mon, 01 Mar 2021 08:18:55 +0000 Received: by outflank-mailman (input) for mailman id 91340; Mon, 01 Mar 2021 08:18:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdlW-0008FP-K6 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 08:18:54 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 291ffcec-4e9b-4004-8e85-8eab7209a0e2; Mon, 01 Mar 2021 08:18:53 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E8ACFAA4F; Mon, 1 Mar 2021 08:18:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 291ffcec-4e9b-4004-8e85-8eab7209a0e2 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614586733; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Fg3Op08Ae+lWyBT8vLNohsrZlkxK1zqicsFMcN/sa8=; b=EOfeChJi4QJOflr7XBYMJQkEWz/c8ILMVxLsuYig6q25DKtKudiPg3biF1xiQxsrEkDnKT 7Qcmwz65EvleuYeKa3xDe7qfj0Ql1j/9kZ9OXd+KcKfwU/K91o0c3cp2JWjGHZ3nK/i7bw WTGHE5D4pGAkgv+90bYJU+qjTpMjDRw= Subject: Re: [PATCH v3 2/2] VMX: use a single, global APIC access page To: "Tian, Kevin" Cc: "Cooper, Andrew" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson , George Dunlap , "Nakajima, Jun" , "xen-devel@lists.xenproject.org" References: <4731a3a3-906a-98ac-11ba-6a0723903391@suse.com> <774a0bf2-d2a4-7dba-bf15-fec8b0ec8c5f@suse.com> From: Jan Beulich Message-ID: Date: Mon, 1 Mar 2021 09:18:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.03.2021 03:34, Tian, Kevin wrote: >> From: Jan Beulich >> Sent: Monday, February 22, 2021 6:57 PM >> >> The address of this page is used by the CPU only to recognize when to >> access the virtual APIC page instead. No accesses would ever go to this >> page. It only needs to be present in the (CPU) page tables so that >> address translation will produce its address as result for respective >> accesses. >> >> By making this page global, we also eliminate the need to refcount it, >> or to assign it to any domain in the first place. >> >> Signed-off-by: Jan Beulich > > Reviewed-by: Kevin Tian Thanks, but for the record: As said on an unrelated thread already, I also need to make an adjustment to shadow mode code here. Since that doesn't affect VMX code itself, I'll retain the R-b on v4 (which I intend to submit only once we have 4.15 branched). Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 01 08:27:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 08:27:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91346.172617 (Exim 4.92) (envelope-from ) id 1lGdtk-0000sv-23; Mon, 01 Mar 2021 08:27:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91346.172617; Mon, 01 Mar 2021 08:27:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdtj-0000so-VC; Mon, 01 Mar 2021 08:27:23 +0000 Received: by outflank-mailman (input) for mailman id 91346; Mon, 01 Mar 2021 08:27:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdtj-0000sj-14 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 08:27:23 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c046ffd3-3237-4b60-a3e7-de7c05e65e54; Mon, 01 Mar 2021 08:27:22 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 661C7AA4F; Mon, 1 Mar 2021 08:27:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c046ffd3-3237-4b60-a3e7-de7c05e65e54 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614587241; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dNADWKwQDdlSEZj5GL9Dlcu8bOaDjERraCVrAxpqxjA=; b=ufw7JE5ieSHRZ2kmX0atf8fpV1NsJ+MV345ux35KMVqr183mYu2H/8iNjRog3AaHnHpmrI XJWxVSCsYvPcZHVDyS6iYmfUCcuxc8a7J5OFnXk35H28i8FkVMnVo8+BEHPYCdJoZM2SSc Jrr6WFR1KEHycU+jwSk25929NX4OdFU= To: "xen-devel@lists.xenproject.org" Cc: Connor Davis , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Dario Faggioli , Ian Jackson From: Jan Beulich Subject: [PATCH 0/2][4.15?] fix build when NR_CPUS == 1 Message-ID: Date: Mon, 1 Mar 2021 09:27:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit While we've long done away with CONFIG_SMP, we still allow CONFIG_NR_CPUS to be set to 1. Hence at least randconfig builds may fail, and the first of the two issues addressed was actually observed in the RISC-V bring-up work. I didn't check whether Arm would also have issues like these. 1: sched: fix build when NR_CPUS == 1 2: x86: fix build when NR_CPUS == 1 Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 01 08:30:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 08:30:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91349.172629 (Exim 4.92) (envelope-from ) id 1lGdwY-0001pA-Jb; Mon, 01 Mar 2021 08:30:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91349.172629; Mon, 01 Mar 2021 08:30:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdwY-0001p3-EM; Mon, 01 Mar 2021 08:30:18 +0000 Received: by outflank-mailman (input) for mailman id 91349; Mon, 01 Mar 2021 08:30:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdwX-0001ov-Fd for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 08:30:17 +0000 Received: from mga17.intel.com (unknown [192.55.52.151]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 79aa9515-8652-4759-8f21-edc7f9329439; Mon, 01 Mar 2021 08:30:13 +0000 (UTC) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 00:30:12 -0800 Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 01 Mar 2021 00:30:12 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Mar 2021 00:30:12 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 1 Mar 2021 00:30:12 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 1 Mar 2021 00:30:12 -0800 Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by CO1PR11MB4979.namprd11.prod.outlook.com (2603:10b6:303:99::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.20; Mon, 1 Mar 2021 08:30:11 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::f1b4:bace:1e44:4a46]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::f1b4:bace:1e44:4a46%6]) with mapi id 15.20.3890.028; Mon, 1 Mar 2021 08:30:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79aa9515-8652-4759-8f21-edc7f9329439 IronPort-SDR: cjfPUpDtib6lwKCd30c0C9KGTDcugerQxAumtP+X1g2G2OoWVlZ6iM9rJhCy5M0uB1XJ6yKhh3 yjcGxvpdVA8Q== X-IronPort-AV: E=McAfee;i="6000,8403,9909"; a="166270899" X-IronPort-AV: E=Sophos;i="5.81,215,1610438400"; d="scan'208";a="166270899" IronPort-SDR: pYocEsMr9L3MAwltRmJe3HfRScGLILrch5bTP0gzmhbHQBf5wTUjouo5dpw3zwKiXBvkwLrYcR y/8ErJbms+SA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,215,1610438400"; d="scan'208";a="585422223" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TJIaigB2Rl8s7mZIabCTvBWhmzjTyMMHKRxmqIIEpE+qFjOvEAmlmuevzCuSkJi1KvnspDoOSNV6u6wkiaKVedciNWZTWp9Jniq1zGM9Z4fdyISNX+uC+rpXNjgkewf0ul8nkKJFQ6/T/rRigx8JpvxXuTxf7m6W1gEZLfwsHWNtF8wO+3muYXNsTKU8135QDkzYVY1UCLvqpu5BwTxLb0TbsUqIb9JnS/EWiwemmw5CfljRiFT+2GzpDbWOavoWNnZPXz85IXhS9aNerl6gCKFwFv/2QSUp+0HZCh93j+B3hwaZ+vhIBl2ajOh/rpIQwBi5hfDO4jqHnx08nJi9qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nu+o87Y+YoIAgqdFwKdtjzbEgxiI6CuKtU/sUct9ZN8=; b=KKLIclr7/RZiedqd/fEnVxCZbbLEevVVnZIeKjvTudwK4RJZu35epBAEXzmRuRKgDAwP0quL+YoQuKSYfAiGAFeYQDLzcBZ4olRVKgtbAm3yRc6RMelpcLG0q32s9K+U7FL3+w056Yfnh21L1DBFw6cyJYem7bhM5gCaXHxGWESYkuggxS7pETC7Tiai9eVLxpoyy09/hasnyMOe7/GPCm5LZR1trAlbASIWLp9gafp/tBc57172uUJ5mU6M4qK7fP4EdBbuly9ciz5TfKOgR4nmh+6LInUZICWlojq+Ye147JTflUm4Bo/gUay66ErvwOyLxTFm/ocKDj7q+bJ+YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nu+o87Y+YoIAgqdFwKdtjzbEgxiI6CuKtU/sUct9ZN8=; b=Nt+FybPXTPZ9WN3Ie0CX+CK6pQ83mI/qn7twAzCW6RRBeMJ5CQcIMAXw5yL6EmCBwktragKOq5hmVaQKFz67Cv6suwU3qZ2Vpp05ideMr+KvXxO8ynLOxdoTYFVoNkeMi2cVhwXCQ7UvPa95Uy6yd2F30+Bs2pfUphMpdirRKGI= From: "Tian, Kevin" To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Julien Grall" , "Cooper, Andrew" , "Wei Liu" , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: RE: [PATCH] VMX: use a single, global APIC access page Thread-Topic: [PATCH] VMX: use a single, global APIC access page Thread-Index: AQHW/8yZa97+qDgbIE6iwG3wuPN9papSpOiAgAAfJYCAAAsJgIAAAbyAgAASBACAG55hYIAAZWcAgAABLbA= Date: Mon, 1 Mar 2021 08:30:11 +0000 Message-ID: References: <1b6a411b-84e7-bfb1-647e-511a13df838c@suse.com> <7abc515b-d652-3d39-6038-99966deafdf8@suse.com> <547b40f2-3b7b-10cb-30f6-9445c784eb0b@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08f9edbc-a2f7-4f89-a51d-08d8dc8c3abc x-ms-traffictypediagnostic: CO1PR11MB4979: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z0v/3RVXSSRRMiCrqUjuAh+pTxp1gI+F5bG2i5bDaWPO+HZywaDH4fYPCM2QSgtJ2rWQrU54Tt6wCQMn+9SXMmmrdLT1JhjKWvjXJBTfTr/dpem3k6aVBZRWDIa6OH3MrRL9PYmlBpyFnYJL0IAPSL/aHH/hj7bK6XKg1MMmwEMHpcUfhyF/f+YSN2548ODuAT44cmMFe76XGK3dFE8HqSYfcYp1a4Xtqu/5IoYqhV/GuxEpWQ3hZSRxRqmI5+6EEkyikYHfYwcAwcjcsYKs1S6uIbvu7T1C+TQ9o+STGVKaDSBERPc8GZ7DC8AdpAsZOD458Bmobs416wW0gPxbiv+TZ5Hg0T2y/WdEX9crgQw0n6mxnk4Fa4G48Q1dJVkbd9Ae9mnQogY+VYlvzdiDqLh9pNftW0xsWIrYDnjQbtoTg4MwtiQ4WyycacSUsEumle1fSfbWvR3ryO7XSPN/xmmYrMWfFHh1cpCLA5gg5WXLA3fTcgV28z6mJCjGnWE/zcspWUGj9lHHKJaNCxVIdQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1886.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(346002)(136003)(396003)(366004)(376002)(7696005)(83380400001)(86362001)(6916009)(8936002)(52536014)(66946007)(33656002)(53546011)(5660300002)(76116006)(64756008)(66556008)(66476007)(66446008)(6506007)(9686003)(2906002)(71200400001)(186003)(55016002)(26005)(54906003)(4326008)(8676002)(316002)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?utf-8?B?RXFibXFEYjduSlQ4RWEvMmVIanRKeVA3U1N5Vm9rQXZ1ZktrMjk4aWpjMHRF?= =?utf-8?B?OWdqbVBuZWJOdVpGZ2F2Y3hPMnhtUXEzY1JJTmM1c3VGLzNnOGlKRkp4UXlD?= =?utf-8?B?M2M5elRQa2c2SldJUUlkR1JFdnVUN1VNMG5Ra1Z1SzZZUmUrZngxRU1HOUQr?= =?utf-8?B?STlBNFdONmlPRHU1enpnN2psRHNCb2R0dEtweE83MjdmZFNqcEV1YmZSUGRz?= =?utf-8?B?emp4MHMxYWVBR1NhSWZEUmtJRmNIMy9Qd1ZCMzh5UlJUR21TQ1Y1T1B0QVZC?= =?utf-8?B?d251QWNyZThxVHV2aVVKaElxT2NOd08yeThrU3F3Z3N0NkREVm9WR1hodmVJ?= =?utf-8?B?MFY1Nm1kdTRLQm5mTVUxN2NLNC9YR042UzVzcnY1OC9FczQ1aXVXOFRaZHF3?= =?utf-8?B?QmxmdjNaTVVmM1FOWHNGcHVodUR0Wk1KSklUaWt1djlJTDdvT0MreWxUTUxr?= =?utf-8?B?L0VCZllUQ2xhVUhQdUlORnkrS2hxelBtQUdCaVlVQ0p5VkdXNENpZG9HeVRh?= =?utf-8?B?TmtydEd0c2d5S1VzbUNBVlY1NnhKYjI3WGNtYzJ4aUpuRHVaQUlIdmR2dCs1?= =?utf-8?B?NWE2dmRIdjM2UWhDbjlEQ2pOT1dzK0oxdkQyRm1SSWEwOW5KYXM3c0ZFbVBQ?= =?utf-8?B?aXk0RDNGZzNIZlJuV1dtUGR4NWptZkkwQmhYUFdON2xBTmlOck1KcXBER2Nm?= =?utf-8?B?UHF1KzM5YWRlYlQ5U3BKUE0rSUxHOXdudTZ4TGsyYXdJSDE5YkFwa0RuNVo5?= =?utf-8?B?YWtZbEFmWnNMR3hwK0tUclBHN1dXMnJDWG4zdUtTZDRsZGdBWHp5MUFXbGl3?= =?utf-8?B?SHNteURPN21pUmw1RU8xZ3ZML2FyU3BGckpGMVhVdk9BNHRRWFBZQ3Q2NkxP?= =?utf-8?B?RXZwQkg2WDdmVmtNbHoyN2hzWGVDU08vQitWS01FSm5hQWFFeWlTRGZYayt4?= =?utf-8?B?SjR4aFdoaUl6dE1kNURwdzQxekllcGdLV1EwT1RheFR0amFueThhaUVqUVJJ?= =?utf-8?B?T25oRlZJL3BmS0NIYXl6NHRmRU9Tc2l4QWpKaDh1amZjU0t5dWordWtVZnoy?= =?utf-8?B?QlRvNmNLdkYyMHVUbWtsY2F4V1YrVXg2MDNKU24xOEo2WTJNalFkZnJ6VDdm?= =?utf-8?B?cE5uWEVQelZDY2pKUFduUGlFRzQvcFBWc3B2U3BJNFRWQ2pEM3p5NFVxcmw5?= =?utf-8?B?VG9zTVNWSjRVTlVxTzJuRkZPSmk2blBDVmhJU044NGE0azk4VXF2M1R5d3Yw?= =?utf-8?B?NlVNeElFdlh4VnJVUXVTQnJ3ZXRwdU83WEEraUlIbkZPRTJud3pXMThDY3JU?= =?utf-8?B?SmwyblZKWFN1VndVWGVmeDAvYU9YVkRzVFN1ak9CeVhzS1RVejV0UElhdUEr?= =?utf-8?B?L1NqTlIwcjQyOUdPRG1QUTNOSE9KSk1JMS9MSDhDelExdXV5dEI4dWlrSm5E?= =?utf-8?B?SWd1Vm10Znk5aUw3VDg5QWFpOWdVc3JnSHZVTlU2eDRsTHhGN011MkNGa25i?= =?utf-8?B?VlUvWmlPWGQwbWRzUUJhb2JhU20yV202Sm40M0d2SjVCNjQ1U0pkSkpQekNa?= =?utf-8?B?T1haclViSHV4cndMclFpcTNDcm0xcS9ZQXZVdlhWd3BRWjZVT3lxVjFKcXlw?= =?utf-8?B?c1RDS01BVXJ5VDhZWUsvZytWSEtrakx5OUVoMExYVFB3VHNCMkdxWFduLzhZ?= =?utf-8?B?U0dDTUlLdmZCTFpYamtXaHpRTEZQMlA5ZXc4eHJ1QzgvZmErRWxFOWVvZ3BM?= =?utf-8?Q?DDWobDTCOkD+k2EmltNKH5BQodBMaAn7O8nnvpk?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08f9edbc-a2f7-4f89-a51d-08d8dc8c3abc X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2021 08:30:11.0639 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y5UZ7znBtQDO1OD+td+hNvQT//2hP/oqsSEHvGVDsSZCTI0liBl9gx97WGKspge7HkJr15Rfy6jeZseinr7EzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4979 X-OriginatorOrg: intel.com PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg TWFyY2ggMSwgMjAyMSA0OjE2IFBNDQo+IA0KPiBPbiAwMS4wMy4yMDIxIDAzOjE4LCBUaWFuLCBL ZXZpbiB3cm90ZToNCj4gPj4gRnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJp eC5jb20+DQo+ID4+IFNlbnQ6IFRodXJzZGF5LCBGZWJydWFyeSAxMSwgMjAyMSA4OjI3IFBNDQo+ ID4+DQo+ID4+IE9uIFRodSwgRmViIDExLCAyMDIxIGF0IDEyOjIyOjQxUE0gKzAxMDAsIEphbiBC ZXVsaWNoIHdyb3RlOg0KPiA+Pj4gT24gMTEuMDIuMjAyMSAxMjoxNiwgUm9nZXIgUGF1IE1vbm7D qSB3cm90ZToNCj4gPj4+PiBPbiBUaHUsIEZlYiAxMSwgMjAyMSBhdCAxMTozNjo1OUFNICswMTAw LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gPj4+Pj4gT24gMTEuMDIuMjAyMSAwOTo0NSwgUm9nZXIg UGF1IE1vbm7DqSB3cm90ZToNCj4gPj4+Pj4+IE9uIFdlZCwgRmViIDEwLCAyMDIxIGF0IDA1OjQ4 OjI2UE0gKzAxMDAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiA+Pj4+Pj4+IC0tLSBhL3hlbi9pbmNs dWRlL2FzbS14ODYvcDJtLmgNCj4gPj4+Pj4+PiArKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3Ay bS5oDQo+ID4+Pj4+Pj4gQEAgLTkzNSw2ICs5MzUsOSBAQCBzdGF0aWMgaW5saW5lIHVuc2lnbmVk IGludCBwMm1fZ2V0X2lvbW11DQo+ID4+Pj4+Pj4gICAgICAgICAgZmxhZ3MgPSBJT01NVUZfcmVh ZGFibGU7DQo+ID4+Pj4+Pj4gICAgICAgICAgaWYgKCAhcmFuZ2VzZXRfY29udGFpbnNfc2luZ2xl dG9uKG1taW9fcm9fcmFuZ2VzLA0KPiBtZm5feChtZm4pKSApDQo+ID4+Pj4+Pj4gICAgICAgICAg ICAgIGZsYWdzIHw9IElPTU1VRl93cml0YWJsZTsNCj4gPj4+Pj4+PiArICAgICAgICAvKiBWTVgn ZXMgQVBJQyBhY2Nlc3MgcGFnZSBpcyBnbG9iYWwgYW5kIGhlbmNlIGhhcyBubyBvd25lci4NCj4g Pj4gKi8NCj4gPj4+Pj4+PiArICAgICAgICBpZiAoIG1mbl92YWxpZChtZm4pICYmICFwYWdlX2dl dF9vd25lcihtZm5fdG9fcGFnZShtZm4pKSApDQo+ID4+Pj4+Pj4gKyAgICAgICAgICAgIGZsYWdz ID0gMDsNCj4gPj4+Pj4+DQo+ID4+Pj4+PiBJcyBpdCBmaW5lIHRvIGhhdmUgdGhpcyBwYWdlIGFj Y2Vzc2libGUgdG8gZGV2aWNlcyBpZiB0aGUgcGFnZSB0YWJsZXMNCj4gPj4+Pj4+IGFyZSBzaGFy ZWQgYmV0d2VlbiB0aGUgQ1BVIGFuZCB0aGUgSU9NTVU/DQo+ID4+Pj4+DQo+ID4+Pj4+IE5vLCBp dCdzIG5vdCwgYnV0IHdoYXQgZG8geW91IGRvPyBBcyBzYWlkIGVsc2V3aGVyZSwgZGV2aWNlcw0K PiA+Pj4+PiBnYWluaW5nIG1vcmUgYWNjZXNzIHRoYW4gaXMgaGVscGZ1bCBpcyB0aGUgcHJpY2Ug d2UgcGF5IGZvcg0KPiA+Pj4+PiBiZWluZyBhYmxlIHRvIHNoYXJlIHBhZ2UgdGFibGVzLiBCdXQg Li4uDQo+ID4+Pj4NCj4gPj4+PiBJJ20gY29uY2VybmVkIGFib3V0IGFsbG93aW5nIGRldmljZXMg dG8gd3JpdGUgdG8gdGhpcyBzaGFyZWQgcGFnZSwgYXMNCj4gPj4+PiBjb3VsZCBiZSB1c2VkIGFz IGFuIHVuaW50ZW5kZWQgd2F5IHRvIGV4Y2hhbmdlIGluZm9ybWF0aW9uIGJldHdlZW4NCj4gPj4+ PiBkb21haW5zPw0KPiA+Pj4NCj4gPj4+IFdlbGwsIHN1Y2ggYW4gYWJ1c2Ugd291bGQgYmUgcG9z c2libGUsIGJ1dCBpdCB3b3VsZG4ndCBiZSBwYXJ0DQo+ID4+PiBvZiBhbiBBQkkgYW5kIGhlbmNl IGNvdWxkIGJyZWFrIGF0IGFueSB0aW1lLiBTaW1pbGFybHkgSQ0KPiA+Pj4gd291bGRuJ3QgY29u c2lkZXIgaXQgYW4gaW5mb3JtYXRpb24gbGVhayBpZiBhIGd1ZXN0IGFidXNlZA0KPiA+Pj4gdGhp cy4NCj4gPj4NCj4gPj4gSG0sIEknbSBraW5kIG9mIHdvcnJpZWQgYWJvdXQgaGF2aW5nIHN1Y2gg c2hhcmVkIHBhZ2UgYWNjZXNzaWJsZSB0bw0KPiA+PiBndWVzdHMuIENvdWxkIEludGVsIGNvbmZp cm0gd2hldGhlciBwYWdlcyBpbiB0aGUgMHhGRUV4eHh4eCByYW5nZSBhcmUNCj4gPj4gYWNjZXNz aWJsZSB0byBkZXZpY2VzIGluIGFueSB3YXkgd2hlbiB1c2luZyBJT01NVSBzaGFyZWQgcGFnZQ0K PiA+PiB0YWJsZXM/DQo+ID4NCj4gPiAweEZFRXh4eHh4IHJhbmdlIGlzIHNwZWNpYWwuIFJlcXVl c3RzIHRvIHRoaXMgcmFuZ2UgYXJlIG5vdCBzdWJqZWN0IHRvDQo+ID4gRE1BIHJlbWFwcGluZyAo ZXZlbiBpZiBhIHZhbGlkIG1hcHBpbmcgZm9yIHRoaXMgcmFuZ2UgZXhpc3RzIGluIHRoZQ0KPiA+ IElPTU1VIHBhZ2UgdGFibGUpLiBBbmQgdGhpcyBzcGVjaWFsIHRyZWF0bWVudCBpcyB0cnVlIHJl Z2FyZGxlc3Mgb2YNCj4gPiB3aGV0aGVyIGludGVycnVwdCByZW1hcHBpbmcgaXMgZW5hYmxlZCAo d2hpY2ggY29tZXMgb25seSBhZnRlciBhbg0KPiA+IGludGVycnVwdCBtZXNzYWdlIHRvIHRoaXMg cmFuZ2UgaXMgcmVjb2duaXplZCkuDQo+IA0KPiBGb3IgbXkvb3VyIGVkdWNhdGlvbiwgY291bGQg eW91IG91dGxpbmUgd2hhdCBoYXBwZW5zIHRvIGRldmljZQ0KPiBhY2Nlc3NlcyB0byB0aGF0IHJh bmdlIHdoZW4gaW50ZXJydXB0IHJlbWFwcGluZyBpcyBvZmY/IEFuZA0KPiBwZXJoYXBzIGFsc28g d2hhdCBoYXBwZW5zIHRvIGFjY2Vzc2VzIHRvIHRoaXMgcmFuZ2UgdGhhdCBkb24ndA0KPiBtYXRj aCB0aGUgcGF0dGVybiBvZiBhbiBNU0kgaW5pdGlhdGlvbiAoZHdvcmQgd3JpdGUpPyBJIGRvbid0 DQo+IHRoaW5rIEkndmUgYmVlbiBhYmxlIHRvIHNwb3QgYW55dGhpbmcgdG8gdGhpcyBlZmZlY3Qg aW4gdGhlIGRvY3MuDQo+IA0KDQpJbiBWVC1kIHNwZWMgIjMuMTQgSGFuZGxpbmcgUmVxdWVzdHMg dG8gSW50ZXJydXB0IEFkZHJlc3MgUmFuZ2UiDQotLQ0KT24gSW50ZWzCriBhcmNoaXRlY3R1cmUg cGxhdGZvcm1zLCBwaHlzaWNhbCBhZGRyZXNzIHJhbmdlIDB4RkVFeF94eHh4IGlzIA0KZGVzaWdu YXRlZCBhcyB0aGUgaW50ZXJydXB0IGFkZHJlc3MgcmFuZ2UuIFJlcXVlc3RzIHdpdGhvdXQgUEFT SUQgdG8gDQp0aGlzIHJhbmdlIGFyZSBub3Qgc3ViamVjdGVkIHRvIERNQSByZW1hcHBpbmcgKGV2 ZW4gaWYgdHJhbnNsYXRpb24gDQpzdHJ1Y3R1cmVzIHNwZWNpZnkgYSBtYXBwaW5nIGZvciB0aGlz IHJhbmdlKS4NCi0tDQpUaGUgZm9sbG93aW5nIHR5cGVzIG9mIHJlcXVlc3RzIHRvIHRoaXMgcmFu Z2UgYXJlIGlsbGVnYWwgcmVxdWVzdHMuIA0KVGhleSBhcmUgYmxvY2tlZCBhbmQgcmVwb3J0ZWQg YXMgSW50ZXJydXB0IFJlbWFwcGluZyBmYXVsdHMuDQrigKIgUmVhZCByZXF1ZXN0cyB3aXRob3V0 IFBBU0lEIHRoYXQgYXJlIG5vdCBaTFIuDQrigKIgQXRvbWljcyByZXF1ZXN0cyB3aXRob3V0IFBB U0lELg0K4oCiIE5vbi1EV09SRCBsZW5ndGggd3JpdGUgcmVxdWVzdHMgd2l0aG91dCBQQVNJRC4g DQotLQ0KDQpJbnRlcnJ1cHQgcmVtYXBwaW5nIGRlY2lkZXMgaG93IHRvIGludGVycHJldCB0aGUg Zm9ybWF0IG9mIHRoZQ0KcmVjb2duaXplZCBpbnRlcnJ1cHQgbWVzc2FnZSBhbmQgd2hldGhlciB0 byBnbyB0aHJvdWdoIElSVEUsDQphcyBleHBsYWluZWQgaW4gIjUuMS40IEludGVycnVwdC1SZW1h cHBpbmcgSGFyZHdhcmUgT3BlcmF0aW9uIjoNCi0tDQpBbiBpbnRlcnJ1cHQgcmVxdWVzdCBpcyBp ZGVudGlmaWVkIGJ5IGhhcmR3YXJlIGFzIGEgRFdPUkQgc2l6ZWQgDQp3cml0ZSByZXF1ZXN0IHRv IGludGVycnVwdCBhZGRyZXNzIHJhbmdlcyAweEZFRXhfeHh4eC4NCuKAoiBXaGVuIGludGVycnVw dC1yZW1hcHBpbmcgaXMgbm90IGVuYWJsZWQgKElSRVMgZmllbGQgQ2xlYXIgaW4gR2xvYmFsIA0K U3RhdHVzIFJlZ2lzdGVyKSwgYWxsIGludGVycnVwdCByZXF1ZXN0cyBhcmUgcHJvY2Vzc2VkIHBl ciB0aGUgQ29tcGF0aWJpbGl0eSANCmludGVycnVwdCByZXF1ZXN0IGZvcm1hdCBkZXNjcmliZWQg aW4gU2VjdGlvbiA1LjEuMi4xLg0K4oCiIFdoZW4gaW50ZXJydXB0LXJlbWFwcGluZyBpcyBlbmFi bGVkIChJUkVTIGZpZWxkIFNldCBpbiBHbG9iYWwgU3RhdHVzIA0KUmVnaXN0ZXIpLCBpbnRlcnJ1 cHQgcmVxdWVzdHMgYXJlIHByb2Nlc3NlZCBhcyBmb2xsb3dzOg0KLi4uDQotLQ0KDQpUaGFua3MN CktldmluDQo= From xen-devel-bounces@lists.xenproject.org Mon Mar 01 08:30:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 08:30:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91350.172641 (Exim 4.92) (envelope-from ) id 1lGdwk-0001tI-09; Mon, 01 Mar 2021 08:30:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91350.172641; Mon, 01 Mar 2021 08:30:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdwj-0001tB-SO; Mon, 01 Mar 2021 08:30:29 +0000 Received: by outflank-mailman (input) for mailman id 91350; Mon, 01 Mar 2021 08:30:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdwi-0001sh-A4 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 08:30:28 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 499a38d8-94f2-4bbf-a116-88bf048ef6bd; Mon, 01 Mar 2021 08:30:27 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 77340AF57; Mon, 1 Mar 2021 08:30:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 499a38d8-94f2-4bbf-a116-88bf048ef6bd X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614587426; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aOzC6w3LpS+/WUDq1gZ9j35Z2qxwwgvDhiN0ayxn28k=; b=QJsun6zmDjAD6AuASuQFahgLLq3KCoYBoZ8e2jwIOA/NqXegi5TueXE7C+xBeGSGsAmWyu whnr34SVQCRysf/aiTJgOa5Yyyf1xGoynn5/CaxjaDqqGUNf9ku2TZtHfrBuGsKqP14pXS sUrD3fe2bouaw32uWjHPioZQVNhrTi0= Subject: [PATCH 1/2][4.15?] sched: fix build when NR_CPUS == 1 From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Connor Davis , George Dunlap , Dario Faggioli , Ian Jackson References: Message-ID: <171d1da4-e87a-b154-5c63-a5627d4f93bc@suse.com> Date: Mon, 1 Mar 2021 09:30:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit In this case the compiler is recognizing that no valid array indexes remain, and hence e.g. reports: core.c: In function 'cpu_schedule_up': core.c:2769:19: error: array subscript 1 is above array bounds of 'struct vcpu *[1]' [-Werror=array-bounds] 2769 | if ( idle_vcpu[cpu] == NULL ) | ~~~~~~~~~^~~~~ Reported-by: Connor Davis Signed-off-by: Jan Beulich --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -2768,6 +2768,12 @@ static int cpu_schedule_up(unsigned int if ( cpu == 0 ) return 0; + /* + * Guard in particular against the compiler suspecting out-of-bounds + * array accesses below when NR_CPUS=1. + */ + BUG_ON(cpu >= NR_CPUS); + if ( idle_vcpu[cpu] == NULL ) vcpu_create(idle_vcpu[0]->domain, cpu); else From xen-devel-bounces@lists.xenproject.org Mon Mar 01 08:31:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 08:31:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91356.172653 (Exim 4.92) (envelope-from ) id 1lGdxP-00022B-AL; Mon, 01 Mar 2021 08:31:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91356.172653; Mon, 01 Mar 2021 08:31:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdxP-000224-7B; Mon, 01 Mar 2021 08:31:11 +0000 Received: by outflank-mailman (input) for mailman id 91356; Mon, 01 Mar 2021 08:31:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdxO-00021y-5Y for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 08:31:10 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b125c18e-96fe-4663-914d-60f14e5a1a87; Mon, 01 Mar 2021 08:31:09 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 871A8AF69; Mon, 1 Mar 2021 08:31:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b125c18e-96fe-4663-914d-60f14e5a1a87 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614587468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A01l/OBBr08TMbu0YIVKBEMymVcxLcoIlRWngXXvXyE=; b=JZ5KAqDEqJQq+aPB67RDlJMED6f3XTI577hNCsi8VcyhzNlktA65YjlFaT2XvwZejxl5qC bRL5AohL9Z21/gavkWRPU/C+Tf7wX2jYYDufDozqI18YHdyA8Crz7U6on3nFvd5b8hdeNP o9oh96qCIa7BtuogHSugvU5No2N+ABs= Subject: [PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1 From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Ian Jackson References: Message-ID: <1d8d5089-32a9-9c42-5949-8f9cd20f33e0@suse.com> Date: Mon, 1 Mar 2021 09:31:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit In this case the compiler is recognizing that no valid array indexes remain (in x2apic_cluster()'s access to per_cpu(cpu_2_logical_apicid, ...)), but oddly enough isn't really consistent about the checking it does (see the code comment). Signed-off-by: Jan Beulich --- a/xen/arch/x86/genapic/x2apic.c +++ b/xen/arch/x86/genapic/x2apic.c @@ -54,7 +54,17 @@ static void init_apic_ldr_x2apic_cluster per_cpu(cluster_cpus, this_cpu) = cluster_cpus_spare; for_each_online_cpu ( cpu ) { - if (this_cpu == cpu || x2apic_cluster(this_cpu) != x2apic_cluster(cpu)) + if ( this_cpu == cpu ) + continue; + /* + * Guard in particular against the compiler suspecting out-of-bounds + * array accesses below when NR_CPUS=1 (oddly enough with gcc 10 it + * is the 1st of these alone which actually helps, not the 2nd, nor + * are both required together there). + */ + BUG_ON(this_cpu >= NR_CPUS); + BUG_ON(cpu >= NR_CPUS); + if ( x2apic_cluster(this_cpu) != x2apic_cluster(cpu) ) continue; per_cpu(cluster_cpus, this_cpu) = per_cpu(cluster_cpus, cpu); break; From xen-devel-bounces@lists.xenproject.org Mon Mar 01 08:33:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 08:33:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91359.172665 (Exim 4.92) (envelope-from ) id 1lGdzc-0002D3-NT; Mon, 01 Mar 2021 08:33:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91359.172665; Mon, 01 Mar 2021 08:33:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdzc-0002Cw-Kb; Mon, 01 Mar 2021 08:33:28 +0000 Received: by outflank-mailman (input) for mailman id 91359; Mon, 01 Mar 2021 08:33:27 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGdzb-0002Cq-83 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 08:33:27 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 53762bc6-7901-4236-8bd3-2b3a3bd2d099; Mon, 01 Mar 2021 08:33:26 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 96E59AAC5; Mon, 1 Mar 2021 08:33:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53762bc6-7901-4236-8bd3-2b3a3bd2d099 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614587605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pqhfnyH9L6Rou+FpVgtBbRJOQNYLqRsohcmJGbMbmTo=; b=bDhmyRQHtrJtCOYRqEx5TXMES4u6lSOK3kSLenMpLTBdGebjA21m1b7SRr6Ejc8+b2uZQ3 R6/W3kaOZAoulifIMWEsLHLbp6m9BOVBXxwYxvp4FroSst/ECryKhYz/PatULx06Ep9G6h rSAL32tRsJGnqDmyWPvf8GYjb0ixaUE= Subject: Re: [PATCH 0/2][4.15?] fix build when NR_CPUS == 1 From: Jan Beulich To: Ian Jackson Cc: Connor Davis , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Dario Faggioli , "xen-devel@lists.xenproject.org" References: Message-ID: <8a1adfcf-fb9b-ec44-5222-25016a031ad4@suse.com> Date: Mon, 1 Mar 2021 09:33:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.03.2021 09:27, Jan Beulich wrote: > While we've long done away with CONFIG_SMP, we still allow > CONFIG_NR_CPUS to be set to 1. Hence at least randconfig builds > may fail, and the first of the two issues addressed was actually > observed in the RISC-V bring-up work. I didn't check whether Arm > would also have issues like these. > > 1: sched: fix build when NR_CPUS == 1 > 2: x86: fix build when NR_CPUS == 1 I've tagged this with a question mark because on one hand such configurations are unusual and hence unlikely to be overly relevant for the release. Otoh randconfig failures would better be avoided. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 01 08:59:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 08:59:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91364.172677 (Exim 4.92) (envelope-from ) id 1lGeOB-0004Fe-Q4; Mon, 01 Mar 2021 08:58:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91364.172677; Mon, 01 Mar 2021 08:58:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGeOB-0004FX-ML; Mon, 01 Mar 2021 08:58:51 +0000 Received: by outflank-mailman (input) for mailman id 91364; Mon, 01 Mar 2021 08:58:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGeOA-0004FS-P7 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 08:58:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 75b847a2-e877-47b2-80bf-d380ccc5da0b; Mon, 01 Mar 2021 08:58:49 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D96AEAAC5; Mon, 1 Mar 2021 08:58:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75b847a2-e877-47b2-80bf-d380ccc5da0b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614589129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VW7aTzKJMG/9lvuNGTCk2tHEC7RSmdSWyonB2EQUG94=; b=tyRifih9k6578QYGqPhZDyzNphR6jv667CeJxoIWc8ylzOdYH8no73q+W9/wygWZM0QNll m3KzlktGVukzL7bAcZTU1oYOnXE4pBNNqOauo5DT7PPxH2lYM320JIR3P79qZJfNs6Wtve DQgPF1ieXDvNc11Mgsj9DtnySy/Pxj0= Subject: Re: [PATCH for-4.15] automation: Fix the Alpine clang builds to use clang To: Stefano Stabellini Cc: Xen-devel , Doug Goldstein , Ian Jackson , roger.pau@citrix.com, Andrew Cooper References: <20210226110233.27991-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: Date: Mon, 1 Mar 2021 09:58:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 26.02.2021 23:48, Stefano Stabellini wrote: > On Fri, 26 Feb 2021, Andrew Cooper wrote: >> Looks like a copy&paste error. >> >> Fixes: f6e1d8515d7 ("automation: add alpine linux x86 build jobs") >> Signed-off-by: Andrew Cooper > > Thanks for the patch and of course it is correct > > Acked-by: Stefano Stabellini > > > However unfortunately it breaks the Alpine Linux gitlab-ci again :-( > I created a branch with Roger's patches plus this patch. The two clang > Alpine Linux build jobs fail: > > https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/1059686530 > https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/1059686532 > > > The error is the following: > > :3:10: fatal error: 'cstring' file not found > #include "cstring" > ^~~~~~~~~ > 1 error generated. > make[10]: *** [Makefile:120: headers++.chk] Error 1 > make[10]: *** Waiting for unfinished jobs.... Doesn't this suggest there's a C++ compiler installed without the headers also being available? The headers++.chk rule requires neither or both to be present. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 01 09:08:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 09:08:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91367.172689 (Exim 4.92) (envelope-from ) id 1lGeWy-0005KV-Mr; Mon, 01 Mar 2021 09:07:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91367.172689; Mon, 01 Mar 2021 09:07:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGeWy-0005KO-J4; Mon, 01 Mar 2021 09:07:56 +0000 Received: by outflank-mailman (input) for mailman id 91367; Mon, 01 Mar 2021 09:07:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGeWw-0005KJ-VJ for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 09:07:55 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5ddd0361-8489-406e-adf6-5bede8c625ca; Mon, 01 Mar 2021 09:07:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ddd0361-8489-406e-adf6-5bede8c625ca DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614589673; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=IO4TRb+8qfDaDAfoFZmZvmFo6hAgK+6Iksy+OSUbW6g=; b=eeR39tNvrDmodWew+uyfTU0mi/sgicMlWrBKsDHr7g8rHZ2GUMjcvshl 900ckXzWpmhvIgb8QqKz0aNDxLJAvZ+Sd6Os4W0WGj79t6eJGHP9L7JkE OJSE2eTHHWWr1/ITtXMPLv/f2JtvCquevhyDeEojojmaamlClXHqHusYl s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: CUTbo1FkNWhhsV4REikeTX72b65wm72oHsRW/5hwGSQQoSU517uM1KPEkIK0IxEIBfehc1M+ZG HUDBrYpbfawKQFWrNj295vIqu5WaOZBq6cRkVBYpmAiX5rTuaPeO5lrjGWL6j7bua4fwLTkTc8 SBau1zkBhYor7iCrKxz/TPqAaCkQL6Cdw4a/Nu75jTvwdj6lmlkqWBhE09TqfeHdawIvlUqO5X rsvdZSMTKb+wOFJkwEgbAWF/WvlveNP3LGufwo96RWKmhTUnu05No/MasYTY3/w0TwLILcdt/T nX0= X-SBRS: 5.2 X-MesageID: 39616653 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="39616653" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YV/SKS32bhDCJZQNxltk65WMV397fBMfk5D/HQJlX2+AnSpfmDVb2GuhrIm3I/4KBATvOeppHiaAHjghzZZ/IzdkVnrzV9eRjmISSL7Ys5oYi9UYb6hFvEjPaFUqOw7A6Ujdqmg7CbmuqgKu+CtRAuVj4hoZmfZPCc6NJ0an2XSSxJvnnQWp3durtRfyxR7ciCB3pTRLGuqjXZW0rn8Guiq2Lgdq/Oq2U6biYTZZxaz8gZhLBjKoIfQxY2Kh+5JOImeVfNdVmWT4uUtvUEyerJeMlbjs9UseSaB7Y84/87xKVp8A9SptYSSAtHRcwA0v8xyf24ttLb9psXunPcAtJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5huOBLLy9OiE8vIPLa7AJ5tUwdEztGNpNWZRhLiB8KA=; b=CYKgDrnysqKO09Ibtd4ekhjSL787kXaV/4M1oe4TqznQVptRbHmDFWGQW6XtWqWKsg3efyU+SFdHcJKPqwog0KkMfKMufxROOvhV7fnhaUOIqg0sVaNgYLdoIXuN91QkFR8PY474sAy+thbV2qeX9phyDFBaoDIkqbovP+S+uI7Ggo1kLhcOc9rWG0H7wg/0pBK1tU8mqp80uC+FBXzUIrzK+9b8RHsIQoyG8OxDoX19DD5Uy3as06oZqfrAP9AF2eGjBg4sQchsQYUcyzingNGJ6XOrzpz3iTQVcc1BN8di/vCVBN6f5tpPaRX5ByWYMgUKWvFBw1i5siUu6JqYyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5huOBLLy9OiE8vIPLa7AJ5tUwdEztGNpNWZRhLiB8KA=; b=DsoHogaurcVtbwX6G7E8Xmck3Ul+AgDtVUXbhXvpsIeVaxqGWDpxFomXK/yMA6MHJ1KXxy9hh6wUSJIGoDWQxENERYIGVpe7H2SGpv8Pn6KJ8pMgILf462M5ytsONj2Mjcq3KF3EByB2+axfER07hvycRZp6pR/afyd9qYWVN50= Date: Mon, 1 Mar 2021 10:07:42 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Subject: Re: [PATCH for-4.15 2/3] firmware: provide a stand alone set of headers Message-ID: References: <20210226085908.21254-1-roger.pau@citrix.com> <20210226085908.21254-3-roger.pau@citrix.com> <2133ba4c-5120-30ca-1328-c8700fd2db94@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2133ba4c-5120-30ca-1328-c8700fd2db94@suse.com> X-ClientProxiedBy: PR0P264CA0251.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100::23) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bc731300-ec97-4522-6915-08d8dc917cb4 X-MS-TrafficTypeDiagnostic: DM6PR03MB3578: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4QRNpPKxHOSCu1K/RWx/mAwCwxRH7uKAIamH2KCVMzeCjs2Byck/gluS3x6tnvqxEb5sfzEXuzBCCaXXTRX/5cgtM3KhTKcXzYgltl+44A5NV8i8TmCciaGhBYXsQj3ymcH+dwVITyLR8jPGKI9+S31glFmwl4sWWUPMseZU8IDzKrS8b1I97CxuxUwjj6wO2+wbq4xhZzU6wrVIVywoezMj2f+/O2+PeDy4lGUN2dgGJsuJVgO2R7cH9Pq43olfV0J0e5MUGBwhacuuNKHtjIuZNWDQgUFMwg0vMJ4+scOCxkpP5Rdma5P/ysLn/8LUc/oDp5bAME5hpPQRQ65ry79ReiHNufWKO2JrwQZm+13Gu50C8ehi54I+7e8jPlMU8w0iU4cI7OO/bHHWOBeELXlmMEl8+nqLFmY3pYa1XUW6O86TyLXVpKonPHDUKCi6HpO9MvWBMwYEVQw1iLwVgD/phIqd7larXbA4udSuKcq8L2k4xGAqG3LToFSaSFGAwdowktuC43vmgd5o3ye9og== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(396003)(376002)(346002)(136003)(366004)(39850400004)(186003)(16526019)(6496006)(54906003)(478600001)(9686003)(4326008)(6666004)(85182001)(6916009)(316002)(26005)(86362001)(6486002)(53546011)(33716001)(5660300002)(66946007)(66556008)(66476007)(8676002)(2906002)(8936002)(956004)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UGxkZDNZalRseUp3d0FTRE9XZStHMmQrcmprMGZLdm9RZ2hzeDIwbUdLdWdQ?= =?utf-8?B?RUhMYVc1Q2EwUzhxWDUzZWdpdk92QXk1a2xIS0ZKS2VHbEtXY1FacUYvT3Y0?= =?utf-8?B?U00xTlhuSkhFQnl3NW4vUVFrNkNKTFdZWVVhMWFIMU5JTVlhWkxKQ2NoN2l5?= =?utf-8?B?eXV1KzBBZ1dBU3FHR0NkdUR0Sld3ZzRGZ0JjcW01Q3dwMm50TVlOUklZOFB6?= =?utf-8?B?Q0FVSkJqVEx4aHJQbXZqQzluS1ZSTEs1N0V5bENzOVo3S2xSZDZ3UXVBbGRO?= =?utf-8?B?MTgwWkw3R1V0aEJRQStySXQ4a0dQVmtTZkRMUEJLcGwwZW5aZGxqd2FYaDJk?= =?utf-8?B?RHcvVkFUWTZkR1AyTldRU3pNMjluUkRZK3FPa0lCVUg3NUJjYXMzR3F0amFa?= =?utf-8?B?d3k2WnJMZGpyWW01ZnJ1cEJtQzlTMlVRa3l1Vkl4RnhzNk16aGRGUERiK3d4?= =?utf-8?B?cTdkWHh1R1FkYTZ0OEw3K1Z3OFFWeVlsbFdHVTNDbllIVFJYeWs0ZVNrZm1a?= =?utf-8?B?N3FCbk5GTExsS2pxbFRDL2p5YXd2bnkvOUVuOW0waHUzNkFKZnV4c1dqK3dS?= =?utf-8?B?SmR1eSsrU3dBRVJGQXlLTWgySVFVUEVpMWIzWnU2elZGamhuM1F4UDhvc0NF?= =?utf-8?B?cG9ZR1UvYWE5Vy9sQXNzRG11L1p5VFlQdThPeHIwcDMxRGY3SU1ZRFBsRkJZ?= =?utf-8?B?V093dTVaQU5QWUFLVWJSU2NQekkwaEhibmwzeTJVOCtMcktpSEQ0dE9WWXRS?= =?utf-8?B?LzIzYTF0MVgvL25IOTk4dTNOc1BnN1IzUVpRUUM5VGladGprdTIyUTlMeXFr?= =?utf-8?B?cHNIZTUwMlBlU2tFNzV1TkxTSHhtOVNxRCtaNUlxQWdjT09ZUjRacTU1eTgy?= =?utf-8?B?QXlDN0RsL1RiYU94clBHOGYzUC9LZkU2TkhsdE5VNGFHbUxHNzVZRWhscTJR?= =?utf-8?B?cVZiNExXbDJQaGtUbTZZbDFpbXBveDNrd2ZSM05pOWlDTU9IbXpnNGg1a2hH?= =?utf-8?B?M3BoVVovTWh3czNDMEFNRjI5K21EVERKZ3RlVWFpV2hacnVGU21zbGlkQTBo?= =?utf-8?B?WmtBeXUzMy9LSTFYTk15Y3FQakI2OVNzam5SWTVuL2VHV1JicEIzaWhWaDFF?= =?utf-8?B?MHNKblcwRTI0eEZ5UTZnOG9icDdENWZpNGZlTmFpYlU2Q1cxNXM2cFc2YXN2?= =?utf-8?B?M0Vsd3JoSzBzNzBOZ29HazM1bis0Wk91UW9zUXJxdFFMQ0pQTENDeWZBd1dK?= =?utf-8?B?bncva1FadVpsTXphb3FjMUx4RFV2VzJZZFcyM2VEYkRkTDJqdFJrZjhrN3Zx?= =?utf-8?B?OHhIaURqY2NjSnJMQ0V0dEVUNW9acFN2WXgwNitBT2x1NnZDYmtyVEREZjN5?= =?utf-8?B?ai9LNlp3cURTQTRHQ2o5Rnh2a0VLdUdGSFZUeWh5b3N4YWkwZElQNDhpUUFo?= =?utf-8?B?aVJpUDMrWUNlSVA0ZWtZcjZBWkkrVVpEcmtmdCtZWEc2MVI1cXFKbE9oamJB?= =?utf-8?B?d1VRY1dHbWM2b2hWc1FWUUNZTE9INDQ1TWdza3EwRXI1ZjhwdlhJYVMrUWNB?= =?utf-8?B?ZjBBV2ZsWVZPTWIxdUUzN2IwMmx5NGlhOThhekx1TS8rVlltdlRtM3Z1bzZw?= =?utf-8?B?V293WlBQdU83L3ZOQU9jOExRNDB4dlREWFBnc3pnb2V0amc2eEFaSDBQNDhJ?= =?utf-8?B?Rm4vVjQzdWgwSmV3N2FZTGx1c1RPRFVndXZUeE1iRTBXa0MxaVk5TlIvVW95?= =?utf-8?Q?GLd2ARg6pGTczF2ncjJ9IIZhOlXk20j44KXtIe9?= X-MS-Exchange-CrossTenant-Network-Message-Id: bc731300-ec97-4522-6915-08d8dc917cb4 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 09:07:49.5991 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +b4iHx1vC6IhH6GyHw1rfL3xj9SRhOhnaCohl7zbwTQT9Ou/2M5S4du0CuCyS3W+IFmGdtxD8w0T7jFmWnLdKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3578 X-OriginatorOrg: citrix.com On Fri, Feb 26, 2021 at 02:24:43PM +0100, Jan Beulich wrote: > On 26.02.2021 09:59, Roger Pau Monne wrote: > > The current build of the firmware relies on having 32bit compatible > > headers installed in order to build some of the 32bit firmware, but > > that usually requires multilib support and installing a i386 libc when > > building from an amd64 environment which is cumbersome just to get > > some headers. > > > > Usually this could be solved by using the -ffreestanding compiler > > option which drops the usage of the system headers in favor of a > > private set of freestanding headers provided by the compiler itself > > that are not tied to libc. However such option is broken at least > > in the gcc compiler provided in Alpine Linux, as the system include > > path (ie: /usr/include) takes precedence over the gcc private include > > path: > > > > #include <...> search starts here: > > /usr/include > > /usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/include > > > > Since -ffreestanding is currently broken on at least that distro, and > > for resilience against future compilers also having the option broken > > provide a set of stand alone 32bit headers required for the firmware > > build. > > > > This allows to drop the build time dependency on having a i386 > > compatible set of libc headers on amd64. > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Jan Beulich > with possibly small adjustments: > > > --- > > There's the argument of fixing gcc in Alpine and instead just use > > -ffreestanding. I think that's more fragile than providing our own set > > of stand alone headers for the firmware bits. Having the include paths > > wrongly sorted can easily make the system headers being picked up > > instead of the gcc ones, and then building can randomly fail because > > the system headers could be amd64 only (like the musl ones). > > > > I've also seen clang-9 on Debian with the following include paths: > > > > #include "..." search starts here: > > #include <...> search starts here: > > /usr/local/include > > /usr/lib/llvm-9/lib/clang/9.0.1/include > > /usr/include/x86_64-linux-gnu > > /usr/include > > > > Which also seems slightly dangerous as local comes before the compiler > > private path. > > > > IMO using our own set of stand alone headers is more resilient. > > I agree (in particular given the observations), but I don't view > this as an argument against use of -ffreestanding. In fact I'd > rather see this change re-based on top of Andrew's changes. Then ... But doesn't using -nostdinc kind of defeats the purpose of -ffreestanding, as it would remove all default paths from the include search, and thus prevent using the gcc private headers? > > --- /dev/null > > +++ b/tools/firmware/include/stdint.h > > @@ -0,0 +1,39 @@ > > +#ifndef _STDINT_H_ > > +#define _STDINT_H_ > > + > > +#ifdef __LP64__ > > +#error "32bit only header" > > +#endif > > Could I talk you into extending this to also cover __P64__? (The > alternative I see would be to omit this altogether.) Sure. I'm having a hard time finding any documentation for __P64__ however. Does it stand for pointers are 64 bits, while longs are 32bits? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 09:10:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 09:10:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91370.172701 (Exim 4.92) (envelope-from ) id 1lGeZ3-0005rD-4D; Mon, 01 Mar 2021 09:10:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91370.172701; Mon, 01 Mar 2021 09:10:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGeZ3-0005qU-0a; Mon, 01 Mar 2021 09:10:05 +0000 Received: by outflank-mailman (input) for mailman id 91370; Mon, 01 Mar 2021 09:10:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGeZ2-0005nq-5u for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 09:10:04 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5519d4c5-4ea9-42a2-80c8-e3895efc59c6; Mon, 01 Mar 2021 09:10:03 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5FBC9ADDD; Mon, 1 Mar 2021 09:10:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5519d4c5-4ea9-42a2-80c8-e3895efc59c6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614589802; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vpIjoIF/4xtxEiq/P5y5V6xvRl0P36DV4+b9ggmFKIQ=; b=YmvxN6IETBxbloKnrf2S22U4ieQ79m+hQjLPXANTsJS8n66Tk18VTuztopoG+w84GGhrj+ L2MePqSnNVzUsJeBGXR8M8lfe0t130aBsrxihH/bhZiwwpUT+uJhuzpXNSX7fTNicw+v8S Nco5abfWeNjAvMsSGi+lJFP6/ObX1FY= Subject: Re: [PATCH v2] xen: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped To: Stefano Stabellini Cc: Stefano Stabellini , andrew.cooper3@citrix.com, julien@xen.org, xen-devel@lists.xenproject.org References: <20210226225217.2137-1-sstabellini@kernel.org> From: Jan Beulich Message-ID: Date: Mon, 1 Mar 2021 10:10:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226225217.2137-1-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 26.02.2021 23:52, Stefano Stabellini wrote: > Introduce two feature flags to tell the domain whether it is > direct-mapped or not. It allows the guest kernel to make informed > decisions on things such as swiotlb-xen enablement. > > The introduction of both flags (XENFEAT_direct_mapped and > XENFEAT_not_direct_mapped) allows the guest kernel to avoid any > guesswork if one of the two is present, or fallback to the current > checks if neither of them is present. > > XENFEAT_direct_mapped is always set for not auto-translated guests. > > For auto-translated guests, only Dom0 on ARM is direct-mapped. Also, > see is_domain_direct_mapped() which refers to auto-translated guests: > xen/include/asm-arm/domain.h:is_domain_direct_mapped > xen/include/asm-x86/domain.h:is_domain_direct_mapped > > Signed-off-by: Stefano Stabellini Reviewed-by: Jan Beulich preferably with one cosmetic aspect taken care of: > --- a/xen/common/kernel.c > +++ b/xen/common/kernel.c > @@ -560,6 +560,10 @@ DO(xen_version)(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > (1U << XENFEAT_hvm_callback_vector) | > (has_pirq(d) ? (1U << XENFEAT_hvm_pirqs) : 0); > #endif > + if ( is_domain_direct_mapped(d) || !paging_mode_translate(d) ) While I realize the left side of the || is what you're after, I'd generally see the more common/universal/whatever-you-want- to-call-it condition be checked first, and the most special purpose one last. IOW I'd prefer if both side of the || could be swapped. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 01 09:17:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 09:17:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91374.172713 (Exim 4.92) (envelope-from ) id 1lGegL-0006UT-22; Mon, 01 Mar 2021 09:17:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91374.172713; Mon, 01 Mar 2021 09:17:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGegK-0006UM-VA; Mon, 01 Mar 2021 09:17:36 +0000 Received: by outflank-mailman (input) for mailman id 91374; Mon, 01 Mar 2021 09:17:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGegJ-0006UC-Db for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 09:17:35 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 66ec7c3f-2764-47f2-8de7-8cd5ccca5761; Mon, 01 Mar 2021 09:17:34 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 47EE3ADDD; Mon, 1 Mar 2021 09:17:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66ec7c3f-2764-47f2-8de7-8cd5ccca5761 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614590253; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M14uPrvFxLxc0/X3wB9P9zqSnpxas/vDs5aupFBoG5M=; b=ZppUbrP/P6jly3aXVhOiWV0QMXc/SNe/LDxy4GwgFZmyL3kEjfP8LP/bZ3IrWHqeosRFrX c4PoBuCZ92v0Lqg5Yp8uKlS5btd0SCK4jTa59Vb59jNasusoMxOzDlepp7dwE7YFM2GMCb oABZXHbd9KVts5Oqa7mcm1K8aCUyI1k= Subject: Re: [PATCH for-4.15 2/3] firmware: provide a stand alone set of headers To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210226085908.21254-1-roger.pau@citrix.com> <20210226085908.21254-3-roger.pau@citrix.com> <2133ba4c-5120-30ca-1328-c8700fd2db94@suse.com> From: Jan Beulich Message-ID: <445b205b-0a0b-da53-b7ba-98a1ac51aab4@suse.com> Date: Mon, 1 Mar 2021 10:17:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.03.2021 10:07, Roger Pau Monné wrote: > On Fri, Feb 26, 2021 at 02:24:43PM +0100, Jan Beulich wrote: >> On 26.02.2021 09:59, Roger Pau Monne wrote: >>> The current build of the firmware relies on having 32bit compatible >>> headers installed in order to build some of the 32bit firmware, but >>> that usually requires multilib support and installing a i386 libc when >>> building from an amd64 environment which is cumbersome just to get >>> some headers. >>> >>> Usually this could be solved by using the -ffreestanding compiler >>> option which drops the usage of the system headers in favor of a >>> private set of freestanding headers provided by the compiler itself >>> that are not tied to libc. However such option is broken at least >>> in the gcc compiler provided in Alpine Linux, as the system include >>> path (ie: /usr/include) takes precedence over the gcc private include >>> path: >>> >>> #include <...> search starts here: >>> /usr/include >>> /usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/include >>> >>> Since -ffreestanding is currently broken on at least that distro, and >>> for resilience against future compilers also having the option broken >>> provide a set of stand alone 32bit headers required for the firmware >>> build. >>> >>> This allows to drop the build time dependency on having a i386 >>> compatible set of libc headers on amd64. >>> >>> Signed-off-by: Roger Pau Monné >> >> Reviewed-by: Jan Beulich >> with possibly small adjustments: >> >>> --- >>> There's the argument of fixing gcc in Alpine and instead just use >>> -ffreestanding. I think that's more fragile than providing our own set >>> of stand alone headers for the firmware bits. Having the include paths >>> wrongly sorted can easily make the system headers being picked up >>> instead of the gcc ones, and then building can randomly fail because >>> the system headers could be amd64 only (like the musl ones). >>> >>> I've also seen clang-9 on Debian with the following include paths: >>> >>> #include "..." search starts here: >>> #include <...> search starts here: >>> /usr/local/include >>> /usr/lib/llvm-9/lib/clang/9.0.1/include >>> /usr/include/x86_64-linux-gnu >>> /usr/include >>> >>> Which also seems slightly dangerous as local comes before the compiler >>> private path. >>> >>> IMO using our own set of stand alone headers is more resilient. >> >> I agree (in particular given the observations), but I don't view >> this as an argument against use of -ffreestanding. In fact I'd >> rather see this change re-based on top of Andrew's changes. Then ... > > But doesn't using -nostdinc kind of defeats the purpose of > -ffreestanding, as it would remove all default paths from the include > search, and thus prevent using the gcc private headers? I guess I don't understand: It is the purpose of this change here to not use compiler provided headers (nor libc provided ones), so why would it matter to retain any kind of built-in include paths? >>> --- /dev/null >>> +++ b/tools/firmware/include/stdint.h >>> @@ -0,0 +1,39 @@ >>> +#ifndef _STDINT_H_ >>> +#define _STDINT_H_ >>> + >>> +#ifdef __LP64__ >>> +#error "32bit only header" >>> +#endif >> >> Could I talk you into extending this to also cover __P64__? (The >> alternative I see would be to omit this altogether.) > > Sure. I'm having a hard time finding any documentation for __P64__ > however. Does it stand for pointers are 64 bits, while longs are > 32bits? Yeah, it's uncommon in Linux/Unix, but it's the model Windows uses for 64-bit environments. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 01 09:21:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 09:21:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91377.172725 (Exim 4.92) (envelope-from ) id 1lGejk-0007R1-Hz; Mon, 01 Mar 2021 09:21:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91377.172725; Mon, 01 Mar 2021 09:21:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGejk-0007Qu-Eg; Mon, 01 Mar 2021 09:21:08 +0000 Received: by outflank-mailman (input) for mailman id 91377; Mon, 01 Mar 2021 09:21:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGeji-0007Qo-Jf for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 09:21:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGejf-0004h4-RJ; Mon, 01 Mar 2021 09:21:03 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lGejf-0002HM-Kw; Mon, 01 Mar 2021 09:21:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=KOYXLhZnfAj7XipIznzkQEH2B+/1Ena6X7YsaKpMW5s=; b=jcbDCbPuEmliFLu8pRLgrKHPcl dbK4kPsP5JKvs+S4EbTQqfd9wpYmqlktJZpjEQjF+M4NX17Z2Rx0N9PmYTaRtKZqbl1tfW5XnYuN3 4TywZJ7tyfTJgE7fGChQkc5BQ5t2hSNjBF4g7REipEuXThtZ5swPnTw1a5UJ2eN1LdBs=; Subject: Re: [PATCH for-4.15 v5 2/3] xen/x86: iommu: Ignore IOMMU mapping requests when a domain is dying To: Jan Beulich Cc: hongyxia@amazon.co.uk, iwj@xenproject.org, Julien Grall , Andrew Cooper , Kevin Tian , Paul Durrant , xen-devel@lists.xenproject.org References: <20210226105640.12037-1-julien@xen.org> <20210226105640.12037-3-julien@xen.org> <1a386635-9c7d-3880-7e99-d87722fe5075@suse.com> From: Julien Grall Message-ID: <78e3ec89-a022-c234-6c73-0abd2fb74f61@xen.org> Date: Mon, 1 Mar 2021 09:21:01 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1a386635-9c7d-3880-7e99-d87722fe5075@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 26/02/2021 13:30, Jan Beulich wrote: > On 26.02.2021 11:56, Julien Grall wrote: >> From: Julien Grall >> >> The new x86 IOMMU page-tables allocator will release the pages when >> relinquishing the domain resources. However, this is not sufficient >> when the domain is dying because nothing prevents page-table to be >> allocated. >> >> As the domain is dying, it is not necessary to continue to modify the >> IOMMU page-tables as they are going to be destroyed soon. >> >> At the moment, page-table allocates will only happen when iommu_map(). >> So after this change there will be no more page-table allocation >> happening because we don't use superpage mappings yet when not sharing >> page tables. >> >> In order to observe d->is_dying correctly, we need to rely on per-arch >> locking, so the check to ignore IOMMU mapping is added on the per-driver >> map_page() callback. >> >> Signed-off-by: Julien Grall > > Reviewed-by: Jan Beulich Thanks! > > Does this also want a Fixes: tag (the same as patch 1)? I think so. I will add it when committing the series. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Mar 01 09:26:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 09:26:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91380.172737 (Exim 4.92) (envelope-from ) id 1lGeoe-0007bN-6C; Mon, 01 Mar 2021 09:26:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91380.172737; Mon, 01 Mar 2021 09:26:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGeoe-0007bG-2P; Mon, 01 Mar 2021 09:26:12 +0000 Received: by outflank-mailman (input) for mailman id 91380; Mon, 01 Mar 2021 09:26:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGeod-0007bB-6T for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 09:26:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGeoa-0004m7-Sk; Mon, 01 Mar 2021 09:26:08 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lGeoa-0002id-K0; Mon, 01 Mar 2021 09:26:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=e8IoOGOS2VNvbulO6qebbGkyehu9GJHO/7V9fcrscjE=; b=JjHSzgK91a/zDWE29K5b6zKWFv RgfqAxg59DpMgBh3DPuxfs8hnX+DpQZSKWiVDD77hXFfXVMX+L69M7iUZDelejeiv98d0dsJ9kaop yKPy4Gj33mRCQm/aq+cM3NcPpafJp0TzQQiTwpB4G2GIZfZs5lQ6OL7d3G10xlv9nVWY=; Subject: Re: [PATCH v2] xen: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , jbeulich@suse.com, andrew.cooper3@citrix.com References: <20210226225217.2137-1-sstabellini@kernel.org> From: Julien Grall Message-ID: <2517d743-c91f-e47c-29c8-41355724252d@xen.org> Date: Mon, 1 Mar 2021 09:26:07 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226225217.2137-1-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Stefano, On 26/02/2021 22:52, Stefano Stabellini wrote: > Introduce two feature flags to tell the domain whether it is > direct-mapped or not. It allows the guest kernel to make informed > decisions on things such as swiotlb-xen enablement. > > The introduction of both flags (XENFEAT_direct_mapped and > XENFEAT_not_direct_mapped) allows the guest kernel to avoid any > guesswork if one of the two is present, or fallback to the current > checks if neither of them is present. > > XENFEAT_direct_mapped is always set for not auto-translated guests. > > For auto-translated guests, only Dom0 on ARM is direct-mapped. Also, > see is_domain_direct_mapped() which refers to auto-translated guests: > xen/include/asm-arm/domain.h:is_domain_direct_mapped > xen/include/asm-x86/domain.h:is_domain_direct_mapped > > Signed-off-by: Stefano Stabellini > CC: jbeulich@suse.com > CC: andrew.cooper3@citrix.com > CC: julien@xen.org > --- > Changes in v2: > - code style improvements > - better comments > - better commit message > - not auto_translated domains are direct_mapped > --- > xen/common/kernel.c | 4 ++++ > xen/include/public/features.h | 12 ++++++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/xen/common/kernel.c b/xen/common/kernel.c > index 7a345ae45e..431447326c 100644 > --- a/xen/common/kernel.c > +++ b/xen/common/kernel.c > @@ -560,6 +560,10 @@ DO(xen_version)(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > (1U << XENFEAT_hvm_callback_vector) | > (has_pirq(d) ? (1U << XENFEAT_hvm_pirqs) : 0); > #endif > + if ( is_domain_direct_mapped(d) || !paging_mode_translate(d) ) > + fi.submap |= (1U << XENFEAT_direct_mapped); > + else > + fi.submap |= (1U << XENFEAT_not_direct_mapped); > break; > default: > return -EINVAL; > diff --git a/xen/include/public/features.h b/xen/include/public/features.h > index 1613b2aab8..4aebfd359a 100644 > --- a/xen/include/public/features.h > +++ b/xen/include/public/features.h > @@ -114,6 +114,18 @@ > */ > #define XENFEAT_linux_rsdp_unrestricted 15 > > +/* > + * A direct-mapped (or 1:1 mapped) domain is a domain for which its > + * local pages have gfn == mfn. If a domain is direct-mapped, > + * XENFEAT_direct_mapped is set; otherwise XENFEAT_not_direct_mapped > + * is set. An OS developper may interpret it as there will always be one of the two flags set. However, this will not be the case for existing Xen release. In addion to that, in the past, we removed support for some XENFEAT_* because they were broken. Although, it is unlikely the case here. Therefore, I think we want to explain that it may be possible to have neither of the two flags set and what to do. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Mar 01 09:31:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 09:31:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91383.172749 (Exim 4.92) (envelope-from ) id 1lGeu8-0000Av-Ow; Mon, 01 Mar 2021 09:31:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91383.172749; Mon, 01 Mar 2021 09:31:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGeu8-0000Ao-Lo; Mon, 01 Mar 2021 09:31:52 +0000 Received: by outflank-mailman (input) for mailman id 91383; Mon, 01 Mar 2021 09:31:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGeu7-0000Aj-79 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 09:31:51 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 35ff5e09-a63d-42e2-be7f-a31152ad6744; Mon, 01 Mar 2021 09:31:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35ff5e09-a63d-42e2-be7f-a31152ad6744 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614591109; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=emrEn4bzA/FIoA0ektzRYWh9isLrCqbZtL51hNPlLdc=; b=RsoaJjTrCG+FiY/O92z3xUKQXEWZ4fF608v4tYbM42ahzQBu4TDEOaCJ 6f+LO2ACpeqRFod0SjEu1mTieXFo2sN0TA8KRQQgi3YjUcJIZUdlkVylW ILABzYG/5HTNa8Bz3iWhOj3vneUq9JsmKLztP9nFgKf1rDx9agZ1cwBsu g=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: UPcTxmatAYx10PeP5PAyrxuPp1nsdqHW1zNsCXkDF6PXx/9UC+pFRUQlEuTYLQFIUeJJlysPec V1pp0RER2+i7UQ9uLsgWjG+xM2dOg4EcQ7/iikkoeNluKvvhaQOb+NHelDgtPaj+BCozFT78CR kgiXUMTQDD8qgKCcGMYhSLN8peW2pj+NcVPcBRQ6NKDNTJPIXxUySN4b639YSfxwQUydTaGm32 vpQkn47YaRQFspMVHTLjwncWqx9TSaThN7rkXzYsNboSwF4mZQo7/6WPKtjbQVsUBt/heHuAMZ IC8= X-SBRS: 5.2 X-MesageID: 38234415 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38234415" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XWWbJQ6lHDZC7Zoz+xRHSQKeP12OlLsyo/xBp/awUdTRQS15vZUyUin9emIPYk89RPV++5gETNfXWhKa17aQfTBy9XgJV3lT4Rj/SiShScILaaAI9Nq3AVSWV1nUJyS1cqTrWpGo+nceeCivJZnKBzWIvAUMl3qSi0dsKkuP/sSodf1D354AL6ORvoRgvDTlGJR5rZuCuec9xo8bElpWWYZRR5hrrggusHvJjbp6nt36Trn6R9pk5IdN2uJSqECMTcpAWRw2SS1XxKhWqIUFeKZiJU+NeezKc2tv3N4XjbbcCaFt5uQqq5XS8t9jf5UV7gx4sVLAxl817HMuOsp4BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KYZkX7geCxLSO9G0LY8wuBLG4qVdOP9FeM2/vBRf5d8=; b=F5DesffL9UHcq9RFWhFVBZI3k9h/EBrhmkPTz48gzLjWoOmt6i9VOQ7fDbYtePeAt1znX16HzvoKqkP3oT10rKvNqzlGUcEQxPlgJHsv/cJdi04IDEpS2rdx4TBlZ0321mYAUuwxguBQJPCpYkVyeZKxUHiwQbX5QbI87NgE5xjGqMXgqImHYjxcM4KxwWRPYlzXwzK8RBbDq+EcBEv7Zs5rVZMSNjOcr2x9okr+Io4bmQctk6p/GmLtlkd4ydLHV6hxtCTZmB88Q+KgSSIvRPMaKMN39IG0LibxS+X4hdzHSE8sbE++/XOoDQlNUNUy6YhxvieW/jlauOyG2rtz9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KYZkX7geCxLSO9G0LY8wuBLG4qVdOP9FeM2/vBRf5d8=; b=iXLdwHefOhJFoJbsP5rSwAzYFVTZkRXJhx9XTYflNeV/AHybTJyoTu1pcczIxDdUpSRdaYkeIKhsam2NtOwuq6RFjngKHT8TBmVaJ+mMNGVzhIbgIjDfDne1cbQ7HZDuIw3ha5/dUroAwj6M3ptpzQRUqmL/yx4M7sZ/cHJ5LrM= Date: Mon, 1 Mar 2021 10:31:41 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Stefano Stabellini , Xen-devel , Doug Goldstein , Ian Jackson , Andrew Cooper Subject: Re: [PATCH for-4.15] automation: Fix the Alpine clang builds to use clang Message-ID: References: <20210226110233.27991-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: PR2PR09CA0015.eurprd09.prod.outlook.com (2603:10a6:101:16::27) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e8319ef4-f95a-453a-ec06-08d8dc94d516 X-MS-TrafficTypeDiagnostic: DM5PR03MB3210: X-MS-Exchange-MinimumUrlDomainAge: gitlab.com#6255 X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2fZFJmQj2yvxOiduhi4nQxwDhkLXYUKG2TtMvPRVaAXll7NBRjX8AneCsBEZUMnKmA5XTKyfw10P4q6+oOdvqyAWZWfSQiA/sxosyHK0JuN70yt3Qxeg+deXuJzJmWTHcdsLmFNVRHIcBGcrp6hJRDi4qRdOjL8/KW+UN2AlDrS4z3v5nKIB59s91JD3wyS7gXF5fHYNulFbx2UBoycJSqYrkgTOhctj8o2FBSJ6veiFyH+vY+2F3KVkuzVe53+JXoWWBiLBZlu93pul9Q0DkZAwzXkuW4hDt21JIYLLQB5G0zPyHE6npNSbCzRvmrJHpxtnONwxP4X0atEaSH/WtttFKQ3+tawUfuAjBQ3sA1sKb8kd1NJFcc0SOsniiKSCAx4nZmIzw8716XYxlPHzQ8xUmhYk6ywyBwdlph+xqD+mw7M9mH//eEEZ+dCO3xSanrUMAmXFsQSHNVIonkwmDKnvgXTVKvkXNilGVVO4eIlAaLeLrPrQlgSrDBWawvcSi0hZk5Kj5t+jy1R2QOBFPin5feVgOclf79vwM/9X9Kb8dxO7fLfx9JZxf5Oj4jPieNp2j99yOT8es/+AUNCuIie813yjoRZuz8QnqQ07X1w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(136003)(396003)(346002)(376002)(39850400004)(366004)(54906003)(86362001)(4326008)(6496006)(316002)(107886003)(5660300002)(53546011)(956004)(33716001)(66556008)(6486002)(186003)(26005)(16526019)(66946007)(66476007)(6666004)(8676002)(8936002)(9686003)(6916009)(966005)(2906002)(478600001)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dGJSaTlXbDJNVmt2YjNmazg4bWU1c1JQYklyT01NcWV0M0tlSjZYVUVLb2E3?= =?utf-8?B?dVgzOXEwMnJnV0xTTHdHV3V6K211Uk83VGVLNStETi9GNGJIaHZIR0JiQ2U2?= =?utf-8?B?MjhqRzM4eVNFMTAyVHc0aExOL2V3Z1lwY3Z4S2RsTjlOaDJTN09DVkUwa0Q2?= =?utf-8?B?aXk3VzM4Q3RYOW5TeWVyUWIzSFVSeG9YcXpWUzhsVGwxQlNwMkpad0VTNGJj?= =?utf-8?B?TGRBTVJEV201V3lFeUJ2YkZYa3hWK0tTK1JMTmU0M0YxdjIrUnBWOTdWMWo0?= =?utf-8?B?T2hLR3Uxdm1XSTU4NDNhVVFab2FaeWhRWkkyTTFwY3NUZW56TWxTWWt3R1pj?= =?utf-8?B?azc0anMyN0hnSS9VUi9SMmRodXBBZXBndWdWMVp6WXpNalRRZ0x5K1ZWRXJM?= =?utf-8?B?Q3ZlV20rWEkva3pOZXBwME5SY25ZK25yN01PV1BMR08ySW45YjV6ZmFzeHRH?= =?utf-8?B?QVNGc0pqVjVlbWx1QkwyWkFUc3BObTJWdkpGMHNrUXZSMGJVd1RlTmlHaGpH?= =?utf-8?B?OXA0eGJqM3o3S2Z4V2h2bW9HU0hEL1hpRFF3Vk1mVE84MVVrNnpLRlpHNlNU?= =?utf-8?B?OVFLS3R0UzBZVjQ5YUVIYTRiTWdpNk9YZ244UTk4cG9MeWVMTmxkWFg2OVln?= =?utf-8?B?L2x4RUt4TjdTNWl4WFRqRklPODBxWEIzalYrbjlKT2g1dklZVCtVcVg2RnpU?= =?utf-8?B?dE9GKzhRZVB2bXNjRVFVdTJJMVpERkw3WTE4R1VKaEJDeE9xck92QlRwT2dF?= =?utf-8?B?MUdzY01FVTlhRk5GUUJkYTdHcCtKSlhCM1hCbWxyOWFSYnBQUitWWW5YRlFO?= =?utf-8?B?QUR2eE42QXdmOTRxd0tKblIzUitqNE44YzI2WU5mUWdnOXVCSVV6UlJXcUxV?= =?utf-8?B?OThFcG5hNElPOG90bkJqQXhTVlMwQjFGRTRvU2tHTm1TbUs1TXZZVTB1NmlY?= =?utf-8?B?eVFzam1HZGxPa3o0clhDbHkwNDZwUHFBSDJnU2RNYUxJemVYQVFBeWg0VkJ3?= =?utf-8?B?UW1McDdGVXpTOE8xRTdlODhPMUIyUnJNY2N4U3R6M1dWUytTR2s1VDc3Rzc1?= =?utf-8?B?QzA2Y0tZc1BiZk1QUWhTNmMvOUUySVFXT29aQjA1R2IyTUxrd0pKR1NjSFpT?= =?utf-8?B?TDErYy8wS2RwczBSaU1INHdTOVk5c1F6UVI3TVpVaXFNRWpyaXhLVTlPbXJs?= =?utf-8?B?cHJPUU9kMzlrUm9PNmRaVkIzUnlremxpU1BmRDdYa3Z4ZG5TKzY1U3F2aTVn?= =?utf-8?B?bEg2ZUNwZFQzTG9jVElqWjF2UDVCeWdiNi9ZQ25VYXFpZjFxdExVeDJETmF4?= =?utf-8?B?UTdzc0J2SzJocmg1YUZCc0ttbi85c2dwakdRcXNMLzk5eVNXMFA1Q0s3QjJC?= =?utf-8?B?RUFXRG9RZ3NXYWx5b3VmUWpST1BFemhrZTFueWgwY1B3czQzZDRFQlU1VGpW?= =?utf-8?B?TkErbzZUbjZ1cDlpc2p3enJLQ1ltWm1DMHZPWDcxcVdjV0F3L3NuK2VGZ1lV?= =?utf-8?B?WXNpZFV0R1VYMnhCZWMrckJOT0lsS1lCWDNDRVMyWExUSXJ3NkhpWmFyd2di?= =?utf-8?B?RUhJTjBrNG92d2RDWkJUOWppaHRSMjdubFE5NkJycUVuSzRaRStkbjVBaXdn?= =?utf-8?B?LzBFdUhrSjZVSXlERHN2cUxsby8rUXFjb203bXpzSDRlbWdjRzREajc2NTJH?= =?utf-8?B?MS9ZYkd1M01MV2lTWHZMOEVHSmU0cDZHMUFZZkNvUE8zaWRGcndBQ0pJazNh?= =?utf-8?Q?QciJnnmVOFXpkLNY2X65vbVWA74N7Iv2mJ7PS4u?= X-MS-Exchange-CrossTenant-Network-Message-Id: e8319ef4-f95a-453a-ec06-08d8dc94d516 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 09:31:46.3206 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lpl7vY7iEqPpCICJGGJ9IEdlA5K73CG2sFb82ipwgsbopZwGLwsvYjLDZUjyGWqB5Bb2lbgSfP4fKfsc5/Xduw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3210 X-OriginatorOrg: citrix.com On Mon, Mar 01, 2021 at 09:58:48AM +0100, Jan Beulich wrote: > On 26.02.2021 23:48, Stefano Stabellini wrote: > > On Fri, 26 Feb 2021, Andrew Cooper wrote: > >> Looks like a copy&paste error. > >> > >> Fixes: f6e1d8515d7 ("automation: add alpine linux x86 build jobs") > >> Signed-off-by: Andrew Cooper > > > > Thanks for the patch and of course it is correct > > > > Acked-by: Stefano Stabellini > > > > > > However unfortunately it breaks the Alpine Linux gitlab-ci again :-( > > I created a branch with Roger's patches plus this patch. The two clang > > Alpine Linux build jobs fail: > > > > https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/1059686530 > > https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/1059686532 > > > > > > The error is the following: > > > > :3:10: fatal error: 'cstring' file not found > > #include "cstring" > > ^~~~~~~~~ > > 1 error generated. > > make[10]: *** [Makefile:120: headers++.chk] Error 1 > > make[10]: *** Waiting for unfinished jobs.... > > Doesn't this suggest there's a C++ compiler installed without > the headers also being available? The headers++.chk rule > requires neither or both to be present. Right, that's because the include path for clang++ seems to rely on the gcc c++ headers: #include <...> search starts here: /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1 /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1/x86_64-alpine-linux-musl /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1/backward /usr/include /usr/lib/clang/10.0.1/include It's solved by installing g++, I will prepare a patch against the docker file. I've got no idea why clang doesn't install the required c++ headers (or simply pull in g++ if that's required). It's unrelated to the -ffreestanding issue. Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 09:33:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 09:33:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91386.172760 (Exim 4.92) (envelope-from ) id 1lGevS-0000HN-4o; Mon, 01 Mar 2021 09:33:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91386.172760; Mon, 01 Mar 2021 09:33:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGevS-0000H7-1Z; Mon, 01 Mar 2021 09:33:14 +0000 Received: by outflank-mailman (input) for mailman id 91386; Mon, 01 Mar 2021 09:33:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGevQ-0000Gz-EF; Mon, 01 Mar 2021 09:33:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGevQ-0004vR-7v; Mon, 01 Mar 2021 09:33:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGevP-0002an-TT; Mon, 01 Mar 2021 09:33:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lGevP-0005HC-T1; Mon, 01 Mar 2021 09:33:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qKlYqxrHVEPZLa9bAkEOSEY7uhRruNbUAgvLgSOcfKs=; b=Vg/8WGh8RVtz9OdVl069NY0f1n vxmw3aFr1RS2DwF4C6SvGLBawK613QUKQqfGsFeUjhsJkosTXMUAM4v1uqJxaE0m+q2rdfUFDRi3m J5xPibUYp+a32Mi8eytr0CUK5A2sJwURymGvia63cplQEvEHAR9/1MjY1mPtkK3HjY58=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 159790: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=eaaf9397f40a7a893a04ee86676478cca3c80d9d X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 01 Mar 2021 09:33:11 +0000 flight 159790 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/159790/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt eaaf9397f40a7a893a04ee86676478cca3c80d9d baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 234 days Failing since 151818 2020-07-11 04:18:52 Z 233 days 226 attempts Testing same since 159693 2021-02-26 04:18:55 Z 3 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 44231 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 01 09:50:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 09:50:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91396.172776 (Exim 4.92) (envelope-from ) id 1lGfCM-0002Gk-JU; Mon, 01 Mar 2021 09:50:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91396.172776; Mon, 01 Mar 2021 09:50:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfCM-0002Gd-GP; Mon, 01 Mar 2021 09:50:42 +0000 Received: by outflank-mailman (input) for mailman id 91396; Mon, 01 Mar 2021 09:50:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfCL-0002GY-GZ for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 09:50:41 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ae3df5c9-f3ee-47b0-bef5-8595ba7f5e39; Mon, 01 Mar 2021 09:50:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae3df5c9-f3ee-47b0-bef5-8595ba7f5e39 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614592239; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=70/vg9076WuDhTUnCoiX9kM0gFDuP5EJBWi+Dr4MbAw=; b=f7j1W3aMYhOcHAclF1ChZUB8EYU8y+bQew3BzDQU+L82QsJqjgfSSR3L mEXmuPp9/ikGR4o6vsyuKva/kKhATQppgk4XbIqbXem/jYTOWv9ObG2cD V9N0mBDr8ejH9S/gS3+eSPZDszEVZAXpexG5YKrFCuhlwb5AB/bcqm7CT w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: HoVcazeYWRLOLRplX2SVyrVk0x8ncm5VHw1sVDibmZxJTeIc0k2mqoP9AdLYD8JO5AqKVTzCov xrKWsYZTPLqtNhTqqSgQjIc5vADSuLmNbYbx+C8w7WGOmqi9TRjzRmQUWTVG/jepIygZ5PIkDp rqGrETIHTaqHqLCtt6olO4QXh8GbWrtOjjcx/CKe1GAk1Yw50rlWbPoSATeFnxJ6v0z3dZOJxG mPUel0/syoi2WTY/3v/zgikLafVaj61pFkEkxarhHRPF0vuzehxvOJb67UNbB1rddYaOB6iwQ8 t7U= X-SBRS: 5.2 X-MesageID: 38217057 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38217057" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hiduWv9fLHGZRgvhcL6hHSAF3dxFT3SZcfnJXaVlevwHWGE3GbmFYJ3keTKbG67hxzTJzdMBoHZokRU0Epq0HSMaM3TprxxHBdlYdYdDL9QHeUam4DMZMlk+5w47Rq9pQGtzy4FA1Ug53IYpnflpp3imLO0ADJTFchzZM85a37z3GSav4aAJ8k8FoI91WzSybGGbud8sNmhEFrOkG6Mk59MwBOKeNCf3r8/3MDtFIJm3AtEizpC46RmokB3PJC5en7ZIejamBuBfB84MK//EGEgceV99k9JaLxaA1xAL3tqZJys9s9SYNk2OF8UZM+9SKbkazurrojTeqrxlbtnH2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bj0A3XNBNmYfiUFJWf2oZqZXqotWiR9g5xoLgr/pom8=; b=FTaqp89N2ZmfIXGJgDRwSj01e9OkBwjXbgDOwSX5XAiEjH1famGlkdqoew1ejmy5fa3gaiLtd/ZoWp3d95KtwF8/ndQjAPt3up6iGWkvewHmkm7f5HhlWOBHD2nOkBcvmb7nZqbmWA9jHjk9AV8sNf4I9pJCxGVmMew3YBK6Z68sKuauR43KVWLd6AhY2L7nf2E3dcilgtl0UV3IoYG7KiARzUf7tp2etXuaXcgwR4qLDAus/EBct2rFTPfIry9dMEqvxEo8X6YiiTo0OaqXwmo5ozgIaWXT3XEiaOAVAT7dcYwyN1Ca5Fa/zGNjR78P5HqUH5GJTCeYJzM/1QVKmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bj0A3XNBNmYfiUFJWf2oZqZXqotWiR9g5xoLgr/pom8=; b=aBJN0kKHGAeXOLKH1ioadbvO/RbeZ1We/qTenMiVgMBmqg75l/T3wwe0QOUMqwGWfULTNiokplV4aLYIRFpeGN0bXVGUCGMg66bHzgoCPtkNV1imylkDkqacsJrOQClcV2SRox2S8mKuhkj6TlH25HME5wQ/r/6z9gcekdMn7CM= Date: Mon, 1 Mar 2021 10:50:30 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Subject: Re: [PATCH for-4.15 2/3] firmware: provide a stand alone set of headers Message-ID: References: <20210226085908.21254-1-roger.pau@citrix.com> <20210226085908.21254-3-roger.pau@citrix.com> <2133ba4c-5120-30ca-1328-c8700fd2db94@suse.com> <445b205b-0a0b-da53-b7ba-98a1ac51aab4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <445b205b-0a0b-da53-b7ba-98a1ac51aab4@suse.com> X-ClientProxiedBy: MR2P264CA0094.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e527ea1c-dad9-4362-733e-08d8dc977636 X-MS-TrafficTypeDiagnostic: DM6PR03MB3483: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FfAYJgK207WKKI6CQABrtl4aUn1bXFe9EZz03hoXy7j6+m2BKo2BjIkI6gilzpOcIqdW2f6mOvMb7ljJCHUNwVoC58rOodcswI7qysaULicW7ItTvOsXbfyNPQTbkf8NNOcRp8qru/FCrSPfq9JGjdBscGDiXbdbq9ET5EplU5T3nIPWeYyV5C8lUEA1hFebj/qt5oD8bsJB6y6+pfEHbVu+6jJaxaLJDkUJDtPL/gnNKDOz/ymoRkkZ6Mdw/FrccTKIaGLQ+YXXJ1cjVEn8qd7WatN1FBzxaC0m9kRfB+ZcluYC4Oir4NqJiO/XycbmwZL4J0HtxKiRYgXEg/HgIsZ/MSGHdkA6vwgxOWjBwn3kHAATIfx5M7WC/g4OQScc1G6cisDppa2bDT4r07UuENA9hnIDmcdd8wjZ1NoyuPZyc6H6Zad4qCEejisp2m3UQgHl567yiuYS1fn6aPR1Ca+9d3BC5WX7oikJzZBwOqoYTLWRNoXpyKoJJ2Ky9jpk6Xsl5I81bCsHzAlrBeG5rw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(376002)(366004)(136003)(346002)(396003)(39850400004)(6666004)(8936002)(66946007)(54906003)(8676002)(186003)(316002)(5660300002)(16526019)(26005)(4326008)(86362001)(66556008)(66476007)(33716001)(6486002)(6496006)(478600001)(85182001)(83380400001)(6916009)(53546011)(9686003)(2906002)(956004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?S2ZuYjFtVDQrUVc0b2cyUG9sVjgySDEzNkkwN3lWRk50bWE5NHBFM0pMT2ZD?= =?utf-8?B?UHdmWFdXajljZkk3K3ZJN05NVVNCZmZnVWpuU2taanFCT3Q0QnMxQ2t2QzBW?= =?utf-8?B?ZENsZkZyU21mV0FJdDlzdHgrRU0yRkY2SFFxc0NIc3lBNExQRWpqaTlCempE?= =?utf-8?B?alg3ZlVNZU4zNUVNWll6MjY0SnEvb1ZXRDJPU0lQankxbWMrV0YvOHRNK1lB?= =?utf-8?B?ZnFiMlA5dE1RMTFmcFNMTm56VGZQZmlseHF4S2dWZ3VqeGVmNThoODlKU05s?= =?utf-8?B?azBpeFBPQmNLbElLNUFlaXVCZDdjVXZSV1p2d2FUZ204bkxudHQ5NTBJMzVW?= =?utf-8?B?QkRDNHlUNEFqNW9qaXAzck5CdktVVHVPMCtHM280NnlGeUtBNzNHYnZDMkFz?= =?utf-8?B?dEZWUmEycjE4NWtMcTFtMzhwam9rSzV3cDNYck9QYW9CbldZdnBzMzVMSFZC?= =?utf-8?B?eEtFUFlmUWJ6M3VRSFVOalBYVFdna2hsUHlTRkdFaWQ1aUNLOW1pYlVGbEhk?= =?utf-8?B?cjVWNDJkYTZlUjJTeFFlKzQ3WStBV0N0UnRVdmpQWWZaWWFISGZSNnRCODZM?= =?utf-8?B?MTlKYjNyZkhqekNOc3V6Y1YvYXZrR2RzUGtUQW5MRC9hK0JES0JDQVhoVXFR?= =?utf-8?B?OEh0cTBNSlhPT1JPd1JuVzAvUXRwZC9LQ1pVdkIyMGxoQ3BsK1puQmd0Nlhi?= =?utf-8?B?VFM0T3RST283NVlLMWxseDRRQ2xBeW0vYXorTHJmdklLSy9MUG94UVBRNXZL?= =?utf-8?B?em55U1FzemJyOERkVXdXSHJ3ZUhuQ0M4eXZvSjEzbUdveEJpeGx2bEhuY2FZ?= =?utf-8?B?T3VKdFh0MWxaUTRaa1lESE8yVFUrS3VnZEFMaXl1NVd2dks3RXQ4UWdGeWV5?= =?utf-8?B?SEFyMTcwd0FWSFlOdjRpRGJOWGllQitHVklONVVqRExNLzBodFI4ZnRzd3pX?= =?utf-8?B?NDRqMDVvbWVmL2hGNElhdlpyUU9YMG5yaDJBdVlUY2FjQ2ZQVGJ0Sjh1M0Y5?= =?utf-8?B?RExOa1BHSkFLSFZ0dEZMV3ZkNmxWNjJvRTNnT0xQbXEzZmFLYSt0a0VDUUpC?= =?utf-8?B?VGlxRTI3cUJBTzV4cXpvZktZemlWSEFia2dQc2l2aVE2eERNcyt2cVhxTk5U?= =?utf-8?B?Z0VvNVZzQVNMdW1OV2VLY29lNE1ReVZDN0wwREhtblNFQkU4bGJiTjlnZlh2?= =?utf-8?B?VDNzMVExdUYyTmUxaVpvcjVvUGRhZ09aZ2dGSEZWTkU0dWlHbE51VEMxZExG?= =?utf-8?B?RDE5K1R3dWtCbXhmdkRxajFtaElLd0lMNURaMUhVclE0N1dvUlFUclFDV3l1?= =?utf-8?B?SmlCaUZocGxaVWwwUEFGanRFcEZndzBucHJBeVE4blczdzJpdVNnUGRqb3FH?= =?utf-8?B?czcyNnVEM2JEcjVQQXMwSzcwc21OdFM0VklTZDJTK2dJakRnVWh6TEdoTWVP?= =?utf-8?B?dHorV1JwelBhV094dmhjSkhseFV2dERxQkwwV2hGaGR0bDViS2V5Rm1hbUZa?= =?utf-8?B?b2RWUXV5bFNSc1IyYUlaSk9vWWtaMEVsME9UQXZkMHNqZ1dKUkw1WWV1UUd6?= =?utf-8?B?bkZUVjJxWk1NRnhhV1JaWkV1S05DMEFNWVNkNGtKOGRQa2hoR1cxOTJ6Wm81?= =?utf-8?B?QUxNT2FQdUp5L3JQaXVSb2RVMTlFTWs5SG5GLzVuaUFPN0xIaVY3RWh0cmxa?= =?utf-8?B?UllPbHpHUEUwQS9UN3NodkQ3MlRZY1RsSjlmU2RXa2pWTWV2a2hxdWVJcU11?= =?utf-8?Q?GUSN2Wnl+Zb5UoVCmqwCne2yYtrGoFH1RNQ8AD6?= X-MS-Exchange-CrossTenant-Network-Message-Id: e527ea1c-dad9-4362-733e-08d8dc977636 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 09:50:35.6358 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +FOWAfF8Xh1kiVWIWR0u0CESI5C4mcC6hPZvD9QecIgFYchomj/cC2oCY5U32LgtQb42wmHd11li6vj9/kv2aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3483 X-OriginatorOrg: citrix.com On Mon, Mar 01, 2021 at 10:17:32AM +0100, Jan Beulich wrote: > On 01.03.2021 10:07, Roger Pau Monné wrote: > > On Fri, Feb 26, 2021 at 02:24:43PM +0100, Jan Beulich wrote: > >> On 26.02.2021 09:59, Roger Pau Monne wrote: > >>> The current build of the firmware relies on having 32bit compatible > >>> headers installed in order to build some of the 32bit firmware, but > >>> that usually requires multilib support and installing a i386 libc when > >>> building from an amd64 environment which is cumbersome just to get > >>> some headers. > >>> > >>> Usually this could be solved by using the -ffreestanding compiler > >>> option which drops the usage of the system headers in favor of a > >>> private set of freestanding headers provided by the compiler itself > >>> that are not tied to libc. However such option is broken at least > >>> in the gcc compiler provided in Alpine Linux, as the system include > >>> path (ie: /usr/include) takes precedence over the gcc private include > >>> path: > >>> > >>> #include <...> search starts here: > >>> /usr/include > >>> /usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/include > >>> > >>> Since -ffreestanding is currently broken on at least that distro, and > >>> for resilience against future compilers also having the option broken > >>> provide a set of stand alone 32bit headers required for the firmware > >>> build. > >>> > >>> This allows to drop the build time dependency on having a i386 > >>> compatible set of libc headers on amd64. > >>> > >>> Signed-off-by: Roger Pau Monné > >> > >> Reviewed-by: Jan Beulich > >> with possibly small adjustments: > >> > >>> --- > >>> There's the argument of fixing gcc in Alpine and instead just use > >>> -ffreestanding. I think that's more fragile than providing our own set > >>> of stand alone headers for the firmware bits. Having the include paths > >>> wrongly sorted can easily make the system headers being picked up > >>> instead of the gcc ones, and then building can randomly fail because > >>> the system headers could be amd64 only (like the musl ones). > >>> > >>> I've also seen clang-9 on Debian with the following include paths: > >>> > >>> #include "..." search starts here: > >>> #include <...> search starts here: > >>> /usr/local/include > >>> /usr/lib/llvm-9/lib/clang/9.0.1/include > >>> /usr/include/x86_64-linux-gnu > >>> /usr/include > >>> > >>> Which also seems slightly dangerous as local comes before the compiler > >>> private path. > >>> > >>> IMO using our own set of stand alone headers is more resilient. > >> > >> I agree (in particular given the observations), but I don't view > >> this as an argument against use of -ffreestanding. In fact I'd > >> rather see this change re-based on top of Andrew's changes. Then ... > > > > But doesn't using -nostdinc kind of defeats the purpose of > > -ffreestanding, as it would remove all default paths from the include > > search, and thus prevent using the gcc private headers? > > I guess I don't understand: It is the purpose of this change here to > not use compiler provided headers (nor libc provided ones), so why > would it matter to retain any kind of built-in include paths? Sorry, I'm also confused. It's my understanding that the point of using -ffreestanding is that the compiler will set __STDC_HOSTED__ == 0, and then the built in compiler headers will be used to provide a freestanding environment instead of the libc ones. However if -nostdinc is used the header search path becomes: #include <...> search starts here: End of search list. At which point setting __STDC_HOSTED__ == 0 is pointless as the built in compiler headers are not used, and hence the compiler will always resort to the stand alone environment provided in this patch. -ffreestanding also allows the program to have a non-standard main, but I don't think we care much about that since we already use a custom linker script. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 09:57:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 09:57:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91399.172788 (Exim 4.92) (envelope-from ) id 1lGfIw-0002TE-B1; Mon, 01 Mar 2021 09:57:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91399.172788; Mon, 01 Mar 2021 09:57:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfIw-0002T7-7A; Mon, 01 Mar 2021 09:57:30 +0000 Received: by outflank-mailman (input) for mailman id 91399; Mon, 01 Mar 2021 09:57:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfIu-0002T2-S9 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 09:57:28 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3628850e-6187-4bac-a803-5e14ec134fc4; Mon, 01 Mar 2021 09:57:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3628850e-6187-4bac-a803-5e14ec134fc4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614592647; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=461i7/kBtwoY05/rEnMeopCmAP2JXdWB8cJ7lyzKu8g=; b=g+d6TTmS/FzJgSIA/1pxARxAHNo2Tj0z4wSFs8as0ZsmBBicZ13UCHf7 Fh3NRjed3yEgbExRaQLeku/H/0rgC9+a9U3MHa1avDPUNQ9pxTX2xZjAK eyfXPdGktgEFNvNHPD0aeuhjnI1IyJRV/oPh0UHvQeWS+aw50urXFU1HV c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Bbo9kRyiHSoJtM++yqRGYyUuGHmjW4LC7vXMRLXCeX1GL4256elhCpvcOz9BQajiaTKUN8hUhv DLzYH198gzkRZtw7Z0q22h7bBhC08x1VhVE66yLzO0s3aSErDZfE7n9+8MCLq53E6bKpSA3hoj 8UPEfn257FVU54D3QLH1G+aSdmPw/XPTI9v1KDklj1GrTDzHz7I4OuDGrg5Z1YHppPoVluQdag Dh1ZplPtv26Ts6d0whtwxiPIXlZKQ+5A2RL08QvIpWPflur2uocgXr3qZN32/2qDb0vsvihjXo 3jw= X-SBRS: 5.2 X-MesageID: 38411180 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38411180" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=deStf3yh4mMNYcUalizCX3qAJYOBeqVZ85x/sqbLZln8hMNu5Q6JTSPUpy9+PFvU9dRXLJWepY/UvTRc4ER4b9PDt3+WWPWOYt9+NwRo8zmRDriMCtjdjmy/6IqVSmc/kuXR7yVawVyUnGiKOdxCaWyl2oHOeYFBJE6IKS/ATQBiVhLVxh1iDrzFzeESUevT/ZjoLJGX/3GJQdobXQCpb1ZQrdeoY5ibra4R6xaxScZS5MkgwZsut7KV2ad1dIiUpUVspZ/knsd3SkSwCM1Dpy0trWeoPu7z3Lt7f1dAPA0feHECPT8Tg0wscwWWUGNhlOkQuvCyy5umHiNf5EfsGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k4RoEXHGAbtddftviS5x58yhBnv9NpZ0rEaiIIfG260=; b=i1H44w0JBu9EcABKIJNfLIrhXS+n7Fbbq7o0q9Z12VJRBpI6Mj+ME5hkFwa55MFNHLHikAVUluOsHY5BWPxdgXyhP5jnFAhDNVgmewENBGNW9BRW3uwqukWHD0i/W0kFVqeaKLajZCXwBFFbFGVzBH/iLfsgaW/VRBTK/OqIHJG3xTRUD36U4YAYshi/Psapp8zRE/YMBIOLjc5fj6UlnDwPmQv4+haGub5/4sgmoqgAURfX/qFk+FUqCo9+K36l12YPUJle+vBOfiTWoJ+7Yu/I7au0/nTl8PMd616KhtpxlQOYeCi80l4JA2IIzk43kv2EFi9OoI4mF4IuwFBulQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k4RoEXHGAbtddftviS5x58yhBnv9NpZ0rEaiIIfG260=; b=uW87zMakjyNskJ2G7PupJWZjxSj+gnJsaT955kK8O65g2g73mGNh5PSVsxOrge16YUSSv4aFqJ5IyYXYEmhKUnIu70vRa4l6d4MN6OKjMVX+R5pycpO5OUcSN9j8K2wo7XsGSGf/KhxKlzH+YCt51ntS671rV+Am0ZInWNFpIaQ= From: Roger Pau Monne To: CC: Roger Pau Monne , Doug Goldstein , Stefano Stabellini Subject: [PATCH for-4.15] automation/alpine: add g++ to the list of build depends Date: Mon, 1 Mar 2021 10:57:14 +0100 Message-ID: <20210301095714.68335-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0046.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::34) To SA0PR03MB5610.namprd03.prod.outlook.com (2603:10b6:806:b2::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 95232a16-30ab-401d-a288-08d8dc986871 X-MS-TrafficTypeDiagnostic: SN2PR03MB2416: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: brJc7XQGugJ/z5FUas8Y0YVN5oLbUUAB5wuZLSNFVXere4LpGB2sXJ1wdzJT0plTbDPPVsC44H2ChJ7myWTjuKmcTd0X4Vb5ie+quOcV+CIk8T+1kWqQXmv8gThEPatPQk8DPBD4jkBYqES13xXaPqkAD/IOZcUV2hJylgDCDMaW25KN52QmT6+76Q63PIiywPAdbTCkqq3penwrizoXKTO1QccQ5xje+SquGf5w9WH1tFRa2b+Yecly345Rw2poeGT4I6WdGCN7jWLl7vGBuKs7dx4OBYCfmJtVL0eiVJjWRSnbKW9pRghLWqcGEfCx1bsDy7GwG2Uag/0QuooMzbwL4Jgj7HDbZfuJXIr3krA7jT49OdjNifo0CVUUPgdat1Pu1S8goK4890qBy91KYU5Cb/dQw0ZBrHwIC83EtNhwaLL2urWy/prLY2Zcm1QW98JkSxOqOvTz+Vmnq0NZivL3uk/4pO6YZeFag8jRikeQcT4XBNN3+09e8yZYY/85dxDK6WDy9oxVlQdNbw/ZmQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(396003)(376002)(39850400004)(366004)(6496006)(83380400001)(6486002)(2616005)(4326008)(6916009)(316002)(478600001)(54906003)(8936002)(66476007)(8676002)(36756003)(86362001)(66556008)(1076003)(956004)(6666004)(5660300002)(186003)(16526019)(66946007)(2906002)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?N2doRWZ1bys2aXRZRjBmK1d0NnhXUU52MlcrRHRkeHZJMHVKZkptamlSWG11?= =?utf-8?B?UkhXRHFtSmZteStldmQxYW5mKzJRVUo1bkNPdk41ektWalBHaWtxRExhUklJ?= =?utf-8?B?aWduVFJZU0dIZ3FnaXF0RGdGWmdSbyt2dGM4ZkZsZ0JTUW1VTnBYcEFZZEVF?= =?utf-8?B?NFFtbG9LdVRCYlVqU1FOd1NMYVBsbzVQTU5Ibk9VY2NocElGbS9aSmRhNjZT?= =?utf-8?B?ZVY4R2JWWW1kcUhvSi85cTVVWlVLRUdYVjN1Um1VUzZrdzRReXZHZjcvOU5G?= =?utf-8?B?QklOZzh3MzAycVdGZmhwY1JBVU9weExRY1p2b3dYeHl1UU9rcHRYeTQzUEZ5?= =?utf-8?B?K014dU5QU1JCWE4vNWwrN1h0bzV2c3BDZzZPWTJxaHhEay85OVZRaEJvWGhV?= =?utf-8?B?YVhXQTdXZUh2T0pCSnZjTnF4TEY4YVMzS2R0WUtkQ2k5TVIxTnhwbjBZc3g0?= =?utf-8?B?ZFdtcGxKS1hpcTN5YUtrMlQvY0hoYXZIM2tnM1ZMMkxacG9hTFFaSk5uR1dK?= =?utf-8?B?NXh6NnpxY0lYQzVQYTFhWDdWOURYM2dLS3VPckNTRmpLS3k3NjNDNjI5aENn?= =?utf-8?B?TGdkUTY5OUdYM0FaT2ZXQm82TXNrWjU4SENGRGp4MWhQRnB4UEJ5bWhpZlpH?= =?utf-8?B?bDl4L2RJZVpVbmlxREhXVGpIRXVtWUFPSHUxOVg0RXFHbi9HV0pxSDZZMTEz?= =?utf-8?B?ZUtkVDdta0RlSDZ0Z3RlUlJ1ejlLTmYwVmVIWWhyK1Q0Z3d5RkRZMEFVZ2JJ?= =?utf-8?B?YTdhRkhsL3FUcU91SmxGclpKRDRuVU1DMjBiRHVFL2g0dXdxQXJyL1lVL3B3?= =?utf-8?B?QXV1WXUyd0hSZDczc1l1anA3Snd3N3RhalM5S0Y2WCtvSldaOHprUGtWQVN4?= =?utf-8?B?b0V2Wnl6c1RBN213Sy9kMngrUXloT3Y0dHJNelZJWW15VFI3dStyMk9iL3NF?= =?utf-8?B?b0RBOWhrOU1peTJydGlmZTJZSlVsWHFPUXp4NFA5MXlEK1VoNXRuNHVxRlh1?= =?utf-8?B?bGVPbTQyVng1RnhFZng2cjYvRCtUam5BUmdxdnNpM2c1YU90ODAvQTE0ZmVX?= =?utf-8?B?ZHpuZzEyOWxBcHhIUWY2bnpTUUd1MmxQZGczeHlRUGhLWVpOOFNxcWJlN1lY?= =?utf-8?B?Tm9Mb2VJQm9zNUJCWiszZlIyVmVaL3RvdHZvOUl4Tk5KWk5adzRTNG1RNzEy?= =?utf-8?B?UUVhNXJVNmVOVndoUXlmc3k1MDg5WFlxY2dyK0laSmc2UTFVMkhEVGhKc24y?= =?utf-8?B?N25sQmxGcUZVUnJLNGdseG9HNUR1SGRtU0lIbTZ5Ulo0YVhhQmIrV2FRYU5I?= =?utf-8?B?SzdhemVPc0JrV0JXVHgvOExpNjRzbDBsSHE3azdkVGM3azZzdlBOSGlzeWJO?= =?utf-8?B?T1ZDWWpzNnZ0MjI5NUFIQnI0QXA0U2RBQ01Ib1N2a21HTmdHQzVOSmFjR3F1?= =?utf-8?B?WWV5amVEYlR1UUtDbktXeDI0clNiTWhQSTBGNWVGZFNtUDI3Q1NGaW56R3RX?= =?utf-8?B?U2dOYzNaRG1BMTRvOWpMbE1qeWNHQUtyaUNNV2F6QmEzaEYydnRVR2VneEx3?= =?utf-8?B?U3RCRGpVVE10ZUF1UG9ITDNLVWsvcUhsSzJwZmF6QXVBdkdUR1Q5MmV2MEJp?= =?utf-8?B?Z0E3U3czYlZEdHFDT0RROWFQUnZXbFI3SERrWk1HNnNaT0hqampPbk5mNngz?= =?utf-8?B?NkUyT3NuSElIYjd2Ynh3dTRMQnhvUTU1NWJCZDJqOUpjZ0FTT1RBNnVpckUw?= =?utf-8?Q?HJR9ZnGtZs4lYtwYjpY4yQ0atbKXbjbLNyiV4/v?= X-MS-Exchange-CrossTenant-Network-Message-Id: 95232a16-30ab-401d-a288-08d8dc986871 X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 09:57:22.0881 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +14enx79RJf4sAuRsryRvBLLDrxakh3GglKn3I9R965QkDFEfvRvzGfxChrxtUDcv0foGVLyO5/K5AmOA7R/EQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2416 X-OriginatorOrg: citrix.com clang++ relies on the C++ headers installed by g++, or else a clang build will hit the following error: :3:10: fatal error: 'cstring' file not found #include "cstring" ^~~~~~~~~ 1 error generated. make[10]: *** [Makefile:120: headers++.chk] Error 1 Reported-by: Stefano Stabellini Signed-off-by: Roger Pau Monné --- No real risk here from a release PoV, it's just pulling a package required for the Alpine clang build. Worse that cold happen is that the Alpine clang build broke, but it's already broken. --- automation/build/alpine/3.12.dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/automation/build/alpine/3.12.dockerfile b/automation/build/alpine/3.12.dockerfile index 2c02417ee6..94557e239b 100644 --- a/automation/build/alpine/3.12.dockerfile +++ b/automation/build/alpine/3.12.dockerfile @@ -21,6 +21,7 @@ RUN \ apk add curl-dev && \ apk add dev86 && \ apk add gcc && \ + apk add g++ && \ apk add clang && \ apk add gettext && \ apk add git && \ -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 09:58:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 09:58:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91402.172800 (Exim 4.92) (envelope-from ) id 1lGfJl-0002ZS-Jk; Mon, 01 Mar 2021 09:58:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91402.172800; Mon, 01 Mar 2021 09:58:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfJl-0002ZL-Ga; Mon, 01 Mar 2021 09:58:21 +0000 Received: by outflank-mailman (input) for mailman id 91402; Mon, 01 Mar 2021 09:58:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfJk-0002ZA-7y for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 09:58:20 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3e9b40c0-f306-4f10-9b35-dfeff908cb57; Mon, 01 Mar 2021 09:58:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e9b40c0-f306-4f10-9b35-dfeff908cb57 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614592699; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=qQR7ddJN5R+Q3RbE226cAd1XlC28dCz0NxE2649b70A=; b=QJfsICAQUDgq+cjRNt+ORfYxL+LzllfLf0h5sVbdY9u+sUDzBpBR5Qfh reU3oBwqM5IvnHMOB+YEOg4QTHJmH1FFEK5INsLBMqC8J4S5iT3MMfv2J 4OSuKuNAKEzAx1nPRiwQawCTuVmXpF/hq4t+MxsedIKne361d0mFZI2Au k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 436USzCtW2QipQtEDdyTz4HfFrTV62tvnanfAhUkTHBHF6cWTQjuuHlw2e918TYJVSuY3D+Cqe AM+u3FSV+n2o5o+x13aUxyf8jIRyLLdFDIikXPOzFZDh/8lLIExA2xDQFnbqY+1hQ/ZJ+MZDtH +c1aUJ6XweZ9gcoeEegdCqZDlslaKWK04JkIZeyqcMo5sFbVf7enGt75vv/R9tirz6kQQ+Oitq MgVwUELjFJMDDnd2eUpwkmPgXyTiLxXARBnZwjo2I4xk+aHzDUFB/6+5KpeJ1XAKQJk+0eubum SaQ= X-SBRS: 5.2 X-MesageID: 38217503 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38217503" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vvh7pKhwkq1oNbXVuQTyirYHOkdnKPpW3XDlMBvz/BqtOhbYoalZ26YzxTybU75/lFZWc2GwmQWgS4tSi4Mz30/f4r+VI/wOCRW8/0su70RnsygFodI+8Gq30MtXzuA09kj3IQYluOsQNOkr+jZq+r4GRNrGbYWkpLQwKWslQIL7xUZEyCGvFVIu4lIwWU/6CcO2W5BoTaJtXLpY+QIsH2Hu7aCCkQQej1fjem71T0kbzKDtJejMUx20yTzZ/8NAuuSnu1fte1Uvz8rzkrDgTiRcrrbcpA5hv2XB84R8J9fMTR3GtcXr3GjiAAg90X5mOOW81T4gMzUCJtYaMcoL2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FxnUDfnA1JCw3Vo8l99dfHW8RyAEk5OJssZEnQ2vSko=; b=Lzp9Cj8NGqe3YxXRafZ/LaNEF+eCaHPC0gc+Y8Cbj6zbXtCD9kE3rtmIYtVbDuS4PwXRDpbgYNnlsmpLkPtXbQIERULrlUJbLVIF8vcAjbiBlF1VCxBn02D7eECA5SkHRC+v/zTsaAECDv41l3lJkylLxq/DzVpbIFNwLcppEw860EQXei7/aWW2lF9jIBsx0z24Epl9FVfZG87vVi2hEokGACRQp/6iCGz1CAESgR4lFEN1BLetFgpkO2GMiRzhnKdW20vFBX87RPSqA/lnBlA9Q74oBtQK1lLtD3zWVEfHj2Sql5g/rcmEfplvaT0AdUyPfKv+6g+4pREpyihwNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FxnUDfnA1JCw3Vo8l99dfHW8RyAEk5OJssZEnQ2vSko=; b=U0pTMd8zPDV0N1JgpQjly/gQ492x2vwhk/y1n2T63UvDhTX+uMhEy5+t94opHYcI67L7hOrDvxIxWxi4ApUwmcxe5m2D1SHEoy+j26D0GhVDv+b6eUMhCuLrbL/4P01MWNQW2L9wLMMJctIVn9eSwsx2GNt4Jur11W84qJwJaOs= From: Roger Pau Monne To: CC: Roger Pau Monne , Doug Goldstein , Stefano Stabellini , Ian Jackson Subject: [PATCH for-4.15] automation/alpine: add g++ to the list of build depends Date: Mon, 1 Mar 2021 10:58:06 +0100 Message-ID: <20210301095806.68518-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0049.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:31::13) To SA0PR03MB5610.namprd03.prod.outlook.com (2603:10b6:806:b2::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 63c36009-3e83-418f-12f1-08d8dc9887f8 X-MS-TrafficTypeDiagnostic: SN2PR03MB2416: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6M6XvIw74Rn4THGKr2SOc0w4Ght3WGYqgrHsFjI2pHCgSRKz1qfYQ0B6lDGTm1fFkP7zCuuE6SIQOdnxOAc+TpX2sJwBpgCTB9VzCFqH1iQ0CSGt/AS2agggcJ/a/8oPRO8y5MusWtb9Jqu2d4JNA3Swy/hef7cNxVfsU5puF6bDVYnn0qGgDGA2jbvZCI3yKTHj4QSi7gDUNhBSWzRPSSD37Ra/9LbATh2760mPKK9Mrcs9Mz6TjWbqpMhNRbhT2cuCZw5Wiz2ViaE6crsIkPbpf6Unym7dkgavUb0BcXSQyRBSMtTZka6gj5wqelsI/7MQBE0Y1qbUIFPsDWY8E7IHRbCUW+r0kRIB2vBL0Pyqj77wvp4i1Sg7BK6cUNewVVPqYL5uipAtDLMgTarpqIN6DzwM8+G6MNxyFYLVM4qfacjTxoIUMSwPxWOQ7UPzTQIk5ciZDVYZAEOdNzdNdBWl8Q8P528aScCMegaJUHW3OHVXWQqMNBbHE6vEp0ZUtHctmlXvTVt+TMLcNfnZ2w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(396003)(376002)(39850400004)(366004)(6496006)(83380400001)(6486002)(2616005)(4326008)(6916009)(316002)(478600001)(54906003)(8936002)(66476007)(8676002)(36756003)(86362001)(66556008)(1076003)(956004)(6666004)(5660300002)(186003)(16526019)(66946007)(2906002)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?QzdtbTN4by9BT0hMTnVPcE5IY0JOTnNXRjFzb3dkRWlvaWZ1SUFSbWxDNjE1?= =?utf-8?B?ZHNSby8zWEc0L0JzVHJtQmgzK3NSWlpIRjBQNW9FZlFwTHBEQnNVUm5SNHgv?= =?utf-8?B?d0dLdzQvTzFidEdxNWgwaW5mYW1JVmcvWllueXZpU1BudDlSS3lhMWdnV0xu?= =?utf-8?B?SkhZY2xGaDJ5NUhpWmhNNWN5TkJQaytselhmTTU4TTVpSGYrSFprSlFIMlV0?= =?utf-8?B?WUNBOTlGVU9QakNrTHFzc0tQMFFsTFliV014bU9xZ21NMGRINGlhd3d1ZDZk?= =?utf-8?B?NG5RMlFmQmZRS2h1U3RDMUJVMXI0dEp0eFRWak9iSUtLcnMxd1NoSW9sV1hv?= =?utf-8?B?bXFTK2J5K1BhNG1MK2RIeUlrMU55eXJYcUE4b0ZUNHFSL0tiN0Fldm42VFZX?= =?utf-8?B?TUNQQ1l6YWdIa3ZQTWh6WE5TK3ZBemNEZVZHTmU3bUxtT2E4Zm5JWTE0SzRM?= =?utf-8?B?K00ySml6WUF2TFYxem0xMWlWZWhFemJFKythVUt2MWI3RzZQMTJsYWZoQ1pl?= =?utf-8?B?emk4OGhXN3F3eXoyZHVYSnd0a1lYNTA0c28zYXJUV09hY2tRQlVDSTV5WTJQ?= =?utf-8?B?a2lldGlaQVFJRlVWUkdDcFNFS2tKbHMzN1plQ3hEZXhnZE04QVVKRm5sd09F?= =?utf-8?B?aUZJd3p6QW5kNTJOK1Fodk5kblRxK29hTlZaczl6bHQ3SEdPeGxNTlFpYm5y?= =?utf-8?B?ejBEMjcvRlpwSFNPVllOWXNqOVE4L25LZnBSdUNoTDdYMzlsMFBoVVNIUnJz?= =?utf-8?B?VzZXRnc1M09jcGV3NDk3b293TjhCTFpCc1oyRW81S3daUGJIT1d0M25qTVc5?= =?utf-8?B?M2hXZjNiZDFOdDFMSUtsNjFBWFBxeFA1QXQ4VitONHE4RVVnNEdmVEYrZXZq?= =?utf-8?B?b2pEdEVNMXQ0ZC9hQzV2Y0FwZWpyZ1Z6Q1BQUzN1NTV2d3BiZWt1bE1pZDdD?= =?utf-8?B?azlidE9ZVTJBdGEyL2trcEJ3KzBpVmRheENVc1FvWXVSelhVYm9vMWRTMVBG?= =?utf-8?B?UDMzdlFTK05QTlBvRGZuUERGT0dNL2VCeDRIOGZTUndWd21LWGFKMkYrSmtj?= =?utf-8?B?OHZaWmxReGlQalEydWpDQW91aUNSV3YyT3kzWTRrRGJ1dkpENmpkN2drNUJX?= =?utf-8?B?dTlwelNsUzNWRTlqb2JsaUZ4V2MreW0yWXRrdVJ6VE9SL0dYQmJrOGZ6SEwy?= =?utf-8?B?MmtTaHNuZmI0L1JFcWhhNnpYM0JvOEJ5MGVPMDZGY1ZDVi9pUUNuWkJLOFN1?= =?utf-8?B?d2VxenRPQ00vaW9rcmc5SHg4Sk5GY0lXRGpPMFRLTWdlMXpEZWhxd1oya1hU?= =?utf-8?B?V3g5RHNRa3kyWjlMTy9iQzNaVHBkZnRVZHpDV0YwVlUrcUprQi9LT0JQM0Jl?= =?utf-8?B?TEdieEgwRUtLTEVCbENyclRnclBEcUx2d1ZHcnhwNkRKbFdvK0s2b20vWEZq?= =?utf-8?B?bXRzTGZwTGNOdXRMNE1uTXozNW8rOVZ6Sml5azJLdnJQeEg3ak1yMkh0eGFI?= =?utf-8?B?NHM3ZWdyekxqTmgvcVNhUk55V1hYUWNldXJqY3lKTU1IYktkMExJMis0TC9z?= =?utf-8?B?K29xenN4R2tHRjFiNXFiWlpQNS9KaEZTWENOSTNnL1piaW5CNUFmODI1anBh?= =?utf-8?B?eVc4MHl6YjRpU2dCMFByK3lXRGpQWUQ2MWZidDFEOGxOTk1tWHRNT2Z0ZUJW?= =?utf-8?B?YWNLZE9pQmMrSEkwQS9hREJhWmdVb2dZZjcxa3gvUVZkQm1rVTJ1UStYTVho?= =?utf-8?Q?VwluAZoTxeUmAiliO0WrLQieeHQh0xlR5BYXdjH?= X-MS-Exchange-CrossTenant-Network-Message-Id: 63c36009-3e83-418f-12f1-08d8dc9887f8 X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 09:58:14.9676 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k3vK0sLC2Gk/sL/knAlzChDm4KK5fMo1AZOyLjLiRpXfgbmhYSYB11nRjBpJf390q8UplO1PwuHcrYTC3VNS+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2416 X-OriginatorOrg: citrix.com clang++ relies on the C++ headers installed by g++, or else a clang build will hit the following error: :3:10: fatal error: 'cstring' file not found #include "cstring" ^~~~~~~~~ 1 error generated. make[10]: *** [Makefile:120: headers++.chk] Error 1 Reported-by: Stefano Stabellini Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson No real risk here from a release PoV, it's just pulling a package required for the Alpine clang build. Worse that cold happen is that the Alpine clang build broke, but it's already broken. --- automation/build/alpine/3.12.dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/automation/build/alpine/3.12.dockerfile b/automation/build/alpine/3.12.dockerfile index 2c02417ee6..94557e239b 100644 --- a/automation/build/alpine/3.12.dockerfile +++ b/automation/build/alpine/3.12.dockerfile @@ -21,6 +21,7 @@ RUN \ apk add curl-dev && \ apk add dev86 && \ apk add gcc && \ + apk add g++ && \ apk add clang && \ apk add gettext && \ apk add git && \ -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 09:59:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 09:59:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91406.172812 (Exim 4.92) (envelope-from ) id 1lGfKQ-0002iq-35; Mon, 01 Mar 2021 09:59:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91406.172812; Mon, 01 Mar 2021 09:59:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfKP-0002ii-Vf; Mon, 01 Mar 2021 09:59:01 +0000 Received: by outflank-mailman (input) for mailman id 91406; Mon, 01 Mar 2021 09:59:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfKO-0002iX-Rm for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 09:59:00 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2a663c28-97b7-4f75-af72-e6139f22d2c5; Mon, 01 Mar 2021 09:58:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A18D2AAC5; Mon, 1 Mar 2021 09:58:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a663c28-97b7-4f75-af72-e6139f22d2c5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614592738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lmJvU2yxrLG2j4y9KegRIA0ARLcJM5dSnacLdTPlvxE=; b=sNkUgJooJqSffzEn/LZ1FE5tSJOcEuaLWTR7URAD1eby4mUC6eGnVP4zrziLwhw8qo8xh0 L9T00O14hM3UKOlLHdJ1xqUrVGquij1U/4fVx/KHFJnLco8pTvGs1eKNJbMSJxVNQmkz8O q5IS3hSbFh6L6W+N770Iy+LdvMAD+tY= Subject: Re: [PATCH] VMX: use a single, global APIC access page To: "Tian, Kevin" Cc: "xen-devel@lists.xenproject.org" , Julien Grall , "Cooper, Andrew" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <1b6a411b-84e7-bfb1-647e-511a13df838c@suse.com> <7abc515b-d652-3d39-6038-99966deafdf8@suse.com> <547b40f2-3b7b-10cb-30f6-9445c784eb0b@suse.com> From: Jan Beulich Message-ID: Date: Mon, 1 Mar 2021 10:58:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.03.2021 09:30, Tian, Kevin wrote: >> From: Jan Beulich >> Sent: Monday, March 1, 2021 4:16 PM >> >> On 01.03.2021 03:18, Tian, Kevin wrote: >>>> From: Roger Pau Monné >>>> Sent: Thursday, February 11, 2021 8:27 PM >>>> >>>> On Thu, Feb 11, 2021 at 12:22:41PM +0100, Jan Beulich wrote: >>>>> On 11.02.2021 12:16, Roger Pau Monné wrote: >>>>>> On Thu, Feb 11, 2021 at 11:36:59AM +0100, Jan Beulich wrote: >>>>>>> On 11.02.2021 09:45, Roger Pau Monné wrote: >>>>>>>> On Wed, Feb 10, 2021 at 05:48:26PM +0100, Jan Beulich wrote: >>>>>>>>> --- a/xen/include/asm-x86/p2m.h >>>>>>>>> +++ b/xen/include/asm-x86/p2m.h >>>>>>>>> @@ -935,6 +935,9 @@ static inline unsigned int p2m_get_iommu >>>>>>>>> flags = IOMMUF_readable; >>>>>>>>> if ( !rangeset_contains_singleton(mmio_ro_ranges, >> mfn_x(mfn)) ) >>>>>>>>> flags |= IOMMUF_writable; >>>>>>>>> + /* VMX'es APIC access page is global and hence has no owner. >>>> */ >>>>>>>>> + if ( mfn_valid(mfn) && !page_get_owner(mfn_to_page(mfn)) ) >>>>>>>>> + flags = 0; >>>>>>>> >>>>>>>> Is it fine to have this page accessible to devices if the page tables >>>>>>>> are shared between the CPU and the IOMMU? >>>>>>> >>>>>>> No, it's not, but what do you do? As said elsewhere, devices >>>>>>> gaining more access than is helpful is the price we pay for >>>>>>> being able to share page tables. But ... >>>>>> >>>>>> I'm concerned about allowing devices to write to this shared page, as >>>>>> could be used as an unintended way to exchange information between >>>>>> domains? >>>>> >>>>> Well, such an abuse would be possible, but it wouldn't be part >>>>> of an ABI and hence could break at any time. Similarly I >>>>> wouldn't consider it an information leak if a guest abused >>>>> this. >>>> >>>> Hm, I'm kind of worried about having such shared page accessible to >>>> guests. Could Intel confirm whether pages in the 0xFEExxxxx range are >>>> accessible to devices in any way when using IOMMU shared page >>>> tables? >>> >>> 0xFEExxxxx range is special. Requests to this range are not subject to >>> DMA remapping (even if a valid mapping for this range exists in the >>> IOMMU page table). And this special treatment is true regardless of >>> whether interrupt remapping is enabled (which comes only after an >>> interrupt message to this range is recognized). >> >> For my/our education, could you outline what happens to device >> accesses to that range when interrupt remapping is off? And >> perhaps also what happens to accesses to this range that don't >> match the pattern of an MSI initiation (dword write)? I don't >> think I've been able to spot anything to this effect in the docs. >> > > In VT-d spec "3.14 Handling Requests to Interrupt Address Range" > -- > On Intel® architecture platforms, physical address range 0xFEEx_xxxx is > designated as the interrupt address range. Requests without PASID to > this range are not subjected to DMA remapping (even if translation > structures specify a mapping for this range). > -- > The following types of requests to this range are illegal requests. > They are blocked and reported as Interrupt Remapping faults. > • Read requests without PASID that are not ZLR. > • Atomics requests without PASID. > • Non-DWORD length write requests without PASID. > -- Ah, I see. That's (according to the change bars) a relatively recent addition. So the above clarifies things for the !PASID case. Am I interpreting "Requests-with-PASID with input address in range 0xFEEx_xxxx are translated normally like any other request-with-PASID through DMA-remapping hardware. However, if such a request is processed using pass-through translation, it will be blocked as described in the paragraph below. Software must not program paging-structure entries to remap any address to the interrupt address range. Untranslated requests and translation requests that result in an address in the interrupt range will be blocked with condition code LGN.4 or SGN.8. Translated requests with an address in the interrupt address range are treated as Unsupported Request (UR)." right in that _with_ PASID translation entries for this range would still be used, so long as they translate to an area outside of the FEExxxxx range? If so this would mean that with PASID (whenever we get to enabling this mode of operation) we'd need to avoid sharing page tables, and we'd need to suppress mirroring of EPT insertions for this range in the IOMMU page tables. (All of this independent of the particular choice of the APIC access page.) Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 01 10:05:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 10:05:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91412.172824 (Exim 4.92) (envelope-from ) id 1lGfQX-0003n9-Rb; Mon, 01 Mar 2021 10:05:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91412.172824; Mon, 01 Mar 2021 10:05:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfQX-0003n2-NB; Mon, 01 Mar 2021 10:05:21 +0000 Received: by outflank-mailman (input) for mailman id 91412; Mon, 01 Mar 2021 10:05:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfQW-0003mx-OS for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 10:05:20 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6af40abd-bfb4-4b09-93c9-ed14bd420163; Mon, 01 Mar 2021 10:05:19 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 64DC1ADE5; Mon, 1 Mar 2021 10:05:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6af40abd-bfb4-4b09-93c9-ed14bd420163 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614593118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I85YvG63xiKI1EdSmWPpVQXUBthXlkkhb07ihuINFm4=; b=mV6Ex57eM8Kw7T7+p0XfQfNpzI4pOEr+qDrOJ394Lk2Arxx+hAR9ILgxPRUdLa5EaSFHZX KXz/RdlCo3iANO0vRfYUwmyvKywhPo4V3CEaKb9h9T8dJ/83mN8fDDPOXq1/oVKq1ZXTyp s2mUnd9DJeqokYglrnzdSO2oajQCpps= Subject: Re: [PATCH for-4.15 2/3] firmware: provide a stand alone set of headers To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210226085908.21254-1-roger.pau@citrix.com> <20210226085908.21254-3-roger.pau@citrix.com> <2133ba4c-5120-30ca-1328-c8700fd2db94@suse.com> <445b205b-0a0b-da53-b7ba-98a1ac51aab4@suse.com> From: Jan Beulich Message-ID: Date: Mon, 1 Mar 2021 11:05:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.03.2021 10:50, Roger Pau Monné wrote: > On Mon, Mar 01, 2021 at 10:17:32AM +0100, Jan Beulich wrote: >> On 01.03.2021 10:07, Roger Pau Monné wrote: >>> On Fri, Feb 26, 2021 at 02:24:43PM +0100, Jan Beulich wrote: >>>> On 26.02.2021 09:59, Roger Pau Monne wrote: >>>>> The current build of the firmware relies on having 32bit compatible >>>>> headers installed in order to build some of the 32bit firmware, but >>>>> that usually requires multilib support and installing a i386 libc when >>>>> building from an amd64 environment which is cumbersome just to get >>>>> some headers. >>>>> >>>>> Usually this could be solved by using the -ffreestanding compiler >>>>> option which drops the usage of the system headers in favor of a >>>>> private set of freestanding headers provided by the compiler itself >>>>> that are not tied to libc. However such option is broken at least >>>>> in the gcc compiler provided in Alpine Linux, as the system include >>>>> path (ie: /usr/include) takes precedence over the gcc private include >>>>> path: >>>>> >>>>> #include <...> search starts here: >>>>> /usr/include >>>>> /usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/include >>>>> >>>>> Since -ffreestanding is currently broken on at least that distro, and >>>>> for resilience against future compilers also having the option broken >>>>> provide a set of stand alone 32bit headers required for the firmware >>>>> build. >>>>> >>>>> This allows to drop the build time dependency on having a i386 >>>>> compatible set of libc headers on amd64. >>>>> >>>>> Signed-off-by: Roger Pau Monné >>>> >>>> Reviewed-by: Jan Beulich >>>> with possibly small adjustments: >>>> >>>>> --- >>>>> There's the argument of fixing gcc in Alpine and instead just use >>>>> -ffreestanding. I think that's more fragile than providing our own set >>>>> of stand alone headers for the firmware bits. Having the include paths >>>>> wrongly sorted can easily make the system headers being picked up >>>>> instead of the gcc ones, and then building can randomly fail because >>>>> the system headers could be amd64 only (like the musl ones). >>>>> >>>>> I've also seen clang-9 on Debian with the following include paths: >>>>> >>>>> #include "..." search starts here: >>>>> #include <...> search starts here: >>>>> /usr/local/include >>>>> /usr/lib/llvm-9/lib/clang/9.0.1/include >>>>> /usr/include/x86_64-linux-gnu >>>>> /usr/include >>>>> >>>>> Which also seems slightly dangerous as local comes before the compiler >>>>> private path. >>>>> >>>>> IMO using our own set of stand alone headers is more resilient. >>>> >>>> I agree (in particular given the observations), but I don't view >>>> this as an argument against use of -ffreestanding. In fact I'd >>>> rather see this change re-based on top of Andrew's changes. Then ... >>> >>> But doesn't using -nostdinc kind of defeats the purpose of >>> -ffreestanding, as it would remove all default paths from the include >>> search, and thus prevent using the gcc private headers? >> >> I guess I don't understand: It is the purpose of this change here to >> not use compiler provided headers (nor libc provided ones), so why >> would it matter to retain any kind of built-in include paths? > > Sorry, I'm also confused. > > It's my understanding that the point of using -ffreestanding is that > the compiler will set __STDC_HOSTED__ == 0, and then the built in > compiler headers will be used to provide a freestanding environment > instead of the libc ones. > > However if -nostdinc is used the header search path becomes: > > #include <...> search starts here: > End of search list. > > At which point setting __STDC_HOSTED__ == 0 is pointless as the built > in compiler headers are not used, and hence the compiler will always > resort to the stand alone environment provided in this patch. > > -ffreestanding also allows the program to have a non-standard main, > but I don't think we care much about that since we already use a custom > linker script. While indeed we don't care about this specific last aspect, we do e.g. care about the implied -fno-builtin (which currently we specify explicitly, yes). So while with -nostdinc added we _might_ indeed be fine already, I think we're better off going the full step and specify what we mean, even if - right now - we're unaware of further effects which are relevant to us. (For example, I don't see why in principle we couldn't ourselves grow a use of __STDC_HOSTED__ somewhere.) Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 01 10:17:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 10:17:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91417.172836 (Exim 4.92) (envelope-from ) id 1lGfbv-0004tm-Tj; Mon, 01 Mar 2021 10:17:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91417.172836; Mon, 01 Mar 2021 10:17:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfbv-0004tf-Pw; Mon, 01 Mar 2021 10:17:07 +0000 Received: by outflank-mailman (input) for mailman id 91417; Mon, 01 Mar 2021 10:17:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfbt-0004tX-LO; Mon, 01 Mar 2021 10:17:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfbt-0005lk-Fa; Mon, 01 Mar 2021 10:17:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfbt-0005J1-5t; Mon, 01 Mar 2021 10:17:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lGfbt-0001tm-5O; Mon, 01 Mar 2021 10:17:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gvo0djP3NoGMMJFSPPa6+4kUpDe5mv6VAWOB/ciEHtg=; b=hQ6qooqiCRDTUAIxZAFcRuwdJI tZ7unV/W/1pvW17tShEXG4jCATsa0aZltZ+c3keXhVqkeX1+5uD6tKwPON3Dq0+Ah4CICAtco9fR7 3GFkk3LnoC/EDDk6kXyYqFebVla8RobW1gpKOfvpvnuwQRvsfSGip0U8Esy58hLYOhx8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159787: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=51db2d7cf26d05a961ec0ee0eb773594b32cc4a1 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Mon, 01 Mar 2021 10:17:05 +0000 flight 159787 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/159787/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 159780 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 51db2d7cf26d05a961ec0ee0eb773594b32cc4a1 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 193 days Failing since 152659 2020-08-21 14:07:39 Z 191 days 370 attempts Testing same since 159700 2021-02-26 08:46:59 Z 3 days 6 attempts ------------------------------------------------------------ 428 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 117941 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 01 10:19:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 10:19:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91423.172851 (Exim 4.92) (envelope-from ) id 1lGfeA-0005AY-Gc; Mon, 01 Mar 2021 10:19:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91423.172851; Mon, 01 Mar 2021 10:19:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfeA-0005AR-DU; Mon, 01 Mar 2021 10:19:26 +0000 Received: by outflank-mailman (input) for mailman id 91423; Mon, 01 Mar 2021 10:19:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfe9-0005AL-Gg for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 10:19:25 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c6ca8687-7b72-42a9-a3da-91ecc3a9b6f8; Mon, 01 Mar 2021 10:19:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6ca8687-7b72-42a9-a3da-91ecc3a9b6f8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614593964; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=6gyDb2GchfbEV7JPwhm+tQh8KYUarTuUS3KcD+2MCxk=; b=Df2RBqOypSMxBDuoeE36Y7rFRJ0Q56Jdc13mRdVdw3Bjtz5rmnwchUxP /7uHCR4En4/f5AghYCcOTnEs8jdTONQLkHH40FhY2PDCHiqlvws6DuGH9 UWVG92dvwtQwfjDGO33CCTj4+xFo5jEGqSzBfuBzfPj6/SB/HZcJZ5nBO E=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 01hj9QZmK1y52vf8FKyJCBpry1/bF8ngdxS71iZsznm4xAr3hrAO8O+n+2YUAQUj+bH1WdZpuc ophbVES1s1Ia/a/wYQHJqY4BL7pqlvqNxAwNQE/H11c/DGFq8BXfHVu1QvHyxIlqeBccpQuApO MxFXhtxMDWPD82HksclOTVh6YIMToTzUtNpD+rcGBSzeYAaPXhU+E5nWj3TLCg8ZHPjpKOOXnf 94Ba/AQMkFfkUkwK80rk28bI4tfrpib4nHvuWYml5E6bb+eLVaR63tEqAw4dIB8jVkaNvbLRHB fcQ= X-SBRS: 5.2 X-MesageID: 39620697 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="39620697" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=couwiq9NdfdJ6rGeUFVX9gsnZNWLpNa8Gq3Pw8uL08H+ocnABOm89Rsrzony4abE46KzK13AIXspPYcq2+GJIzkt/jZTbvdxsGAMOJBEWfJRGHuPKBiJjMdQM7f7v45dair07zLSOhV/CrPgjymVl+5fe2rym7JYpnxoNXlk0QZhD5wQv/1wJNz4UNgysJPt0U9Wr4g5py8b1XCrMt6DC7Zc6mrusWlxOTU4HtBtVHupxJWKziUMr/JyBugmu1U1lrPp2lqYkPVebWo7NRfJioydpxz6+2iiwaR47Dk/l3vaoQbsqbwFcAbSXS0+IwYbxIrE9ZJrCLEh0KI+V6oKTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H3IOzOSEpi6QczcRKspuL6MFgP5LtVvDSMFGKJ7htHw=; b=ne2FTqRcg2iIHpn8xyKg3dyFUoAnv4ZuhtaUwwHeilWm6HVfRzfAH6hJ508z+mpflz747Mq2UnZK8gW0btThVcg1fGgt6ZxPan6AxOmRMGXwQkEPPP0jiWZppSpn4p/VwRcbrRhhCohZHv1uJ2erx41f9/uHF6bCgm6CUW9YrypCysEc+1O9DRhuoHvVWRE39E5eX+I11LtAqS/W6w7mfYA3LWz3E4YVGyr1+YzVVLIMLWARVD3tODKYGrHnK5YXaJ+xK3Y5YNRbITgCSSXOmgTWoU2KynWu+w446lUIXiEL6EFWqGswiY16qapt8lfchXmt1CjQmY6u/xT4g5MpTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H3IOzOSEpi6QczcRKspuL6MFgP5LtVvDSMFGKJ7htHw=; b=eiFCfsRR3DGADPu/gJgBYfJsu0+9t3vKExIbBi+0NrsY+waH3SCFZxvR2J2M9wVdH5bjebySc/xjMnxqKnRHumQQS0tHVP4KzfarMqdNnop4oMqgVYwVsJ3c3MHfzf+QgE8+Bk5PCcBR5NMpti5StEoXGdXcTVadAvPhwisRxsY= Date: Mon, 1 Mar 2021 11:19:13 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Subject: Re: [PATCH for-4.15 2/3] firmware: provide a stand alone set of headers Message-ID: References: <20210226085908.21254-1-roger.pau@citrix.com> <20210226085908.21254-3-roger.pau@citrix.com> <2133ba4c-5120-30ca-1328-c8700fd2db94@suse.com> <445b205b-0a0b-da53-b7ba-98a1ac51aab4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AM6PR08CA0020.eurprd08.prod.outlook.com (2603:10a6:20b:b2::32) To SA0PR03MB5610.namprd03.prod.outlook.com (2603:10b6:806:b2::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d931a6ca-7559-4065-f7af-08d8dc9b7912 X-MS-TrafficTypeDiagnostic: SA2PR03MB5915: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SJCiISNQ3UtuNG78BN2pKftbe6j0Y71KraiEteTX/6VFKQ60Q+7rgSKWyhzl26eF5A4A7gm519hf2vjc/aV/wudbHxCyc1KDaQk9FWfFVjxnS6y7RDXlj2TK7q2GKkpva3JLGFImA3odtflEUsIqPt42YNcvq/dAkoXPRoOyPesyfDw2KqScIPr4FmSY6/N50kC14gI4CsZ+liVNzQwGc2ZhFALmkqUMvYk07hg9dMVlyeX2xbbzOYmOIhbiV5+rwpaK4rfH5gLDQ1LuORJ28hdVlVQhw4UNSadhzQbT2Ef3XhSf+HPG5B4i8QHTe6jOypR1Rds9S4UPPgWUuk7qWjFPokvLLOn0woXTf8Vj4mzs8qiyftAUzsQKLy5nEwUI8fqrkXRslA2X3XcHr/dijuykpYaU7P390T6UK4RKIG+F/9Dek39Js27YITx3V65CbkTEd6hOv+SHpzHpWSVzG077EhFtImt5ch0z6i5yxZEDYWbHV1+umnJ5DnxmDLi5Tn+Q8x0ySCzegHs6o+Ok+A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(39860400002)(396003)(366004)(346002)(136003)(376002)(66556008)(6496006)(6666004)(53546011)(6916009)(8676002)(186003)(16526019)(956004)(26005)(33716001)(6486002)(83380400001)(8936002)(5660300002)(66476007)(85182001)(54906003)(66946007)(86362001)(478600001)(9686003)(316002)(2906002)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?RGVBZGNtczZvYUtnSWVMM1ByT1R5WVZmL3MwNnJMV1F6MFNyQ21zSkFTZ1ZU?= =?utf-8?B?R2tmSHcxTlc0cXhwd1NBM2ZVeUdyQ2VFYzFTZHFQMjlnZExNVkwwUVNuQjhV?= =?utf-8?B?cUdEcjRIemY1SnNYSk9rYnUvc2ZjWEFkSVUyS25qbWZaMS9LUzlqRWo5NkEv?= =?utf-8?B?VE56RG1xVkZjZTg5RmJ3N3kwZnlQUHhITTNxVnA0RHJZbDNRZldsYUxHc2g0?= =?utf-8?B?Tmsybytyb2VIMTF1NnNQcXRmSW5TcVFGcGRiRzI3RDAxZGlqWElBTlQxdTB1?= =?utf-8?B?VzBEc0JJblJjVlh1Y09GNHVyRjBYSlBIVHBYTGNuK2FaUkczaFMrM3c1aHIy?= =?utf-8?B?YmZJZzhoSHYrdVp3MmNnODkzb2VKeDdGZzhOeUpzVjBBckptYUpONWFzcUFt?= =?utf-8?B?OCsvU09PRHZQaStWdE10c1ZmcnlrQ1BsMWlYNFBNekVIY2t0ZS9qSmxnSHYz?= =?utf-8?B?MHdVOVd4MXBDK1lhdHhManA5MkRYdXlRcUl3bFVEeUhkRWpucDhDaTY5djlv?= =?utf-8?B?OU90Mk95dTFBNXg3Rm5iWEw5ckJJUzJaL3ZlMWljZzhra044L01HU3g0OE91?= =?utf-8?B?UnFBWExlc2I2VGtKWHBoQmZ6b3NpU1dBZDNSMGRuMG55UlhWMVh1RGM0aEFM?= =?utf-8?B?a3hBSU5paFZnZFgxWldzeUpabGQ1MHJ3RmwzaVVTQWI0NVR2VVplQVR2Q3di?= =?utf-8?B?RDBrUit2RnR1QjZqU0JWZjNGZ2VkUHJndjhhM3JEZkRJWWc0WkRYQ2ZUV1pV?= =?utf-8?B?Sk8zMUJpdmNCRmJDYUVVNlM1SVcxTFBRSmJhMWhxUEZCR29tcm8zNUpIeDRJ?= =?utf-8?B?a2RqakhZTmR1YVFEWWl0UlgzUEVhZEsxWHBGYnc3QTE0MUNJZ3psZEx5cGdn?= =?utf-8?B?aVM3aVVJVVppaGF6cDc4a2xwaHV3eEhFT3lFamRaTlloZC9VUVkzRG8wOEtG?= =?utf-8?B?cmVwdURMS01BNWNTTUZFNi9WVFhQMGpVTEo1aHF6dHYrTVl3a1ZnYzcvdTNz?= =?utf-8?B?N2lhTEhWeUtxcTVWNG1BbUk5S2pQMW83dy9yUDJXYlNFNzUwTmhiNHEvUHdz?= =?utf-8?B?dXRFdjJud096c2hGYUR2SzFZSUVGNXdXU01COFkvV0JlZ0c1YzM3UjdOS3ZD?= =?utf-8?B?V09DYXEveDhBdkhpZnVBQTF5SU9Pb0pQbWRxalM1STVyc0JiZDg1ekVadWVm?= =?utf-8?B?RWJZTWlHS0FjN3A3ckZOL2pTajREazhHU2pPbUhjL0xiRHFZYXRWYnFIWGtq?= =?utf-8?B?akpJNGZhNndNbGFDbmovM3hlZ2l2cFZmUys4ejRYZmZlM1F6dUZwQkcxN3la?= =?utf-8?B?cG1oYUpFVlVadHJZR3lQQ3FYcXRaWFMvQVZucURtMllKSUtMZzdMaFhtamNj?= =?utf-8?B?R2VqeG4vanljQXBldkxlOFRvck9BNUZTeG5EczZtR3FVdER1UnhSTGg3SzAr?= =?utf-8?B?dDJGdGxSNDlQMXdKb2QyeTA5NUM4OHg5K1pZc0w5aXNiazV2ckxGTEJPUVpP?= =?utf-8?B?dnRNVVJYZktDb0RMQ2gybmYvRE9NTGJ3SlowbkhwVUJKNkovZUxZNlhyYlhY?= =?utf-8?B?SEJKREFXbDJHelV6ejBoNFpsRU5WMExwaFZoZjNlZEZUOG54MC9qbWk1S3Fx?= =?utf-8?B?andKV3BwSzRFTktHTGplTXZYajluQmRVVXlwM25iamQ0WlhoQlNGeXpaRm9k?= =?utf-8?B?Y0JjTFNvOWVRcStaUkUrVW1IMDJTOGkyRWwwanlqdjJadkhzYXFvaXJjWUJJ?= =?utf-8?Q?6acCLREZ5stv4X2ZjcoCTprARQY7wwlaxjJW2Cr?= X-MS-Exchange-CrossTenant-Network-Message-Id: d931a6ca-7559-4065-f7af-08d8dc9b7912 X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 10:19:18.3666 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RkY4fuOkZDz7avFXFC/BX4+viwqp0RR+JvWgHRRl6PrDm4iti5r1HFZO+dRTcuJQxq2uOFjVqBl9yypekCfXew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5915 X-OriginatorOrg: citrix.com On Mon, Mar 01, 2021 at 11:05:17AM +0100, Jan Beulich wrote: > On 01.03.2021 10:50, Roger Pau Monné wrote: > > On Mon, Mar 01, 2021 at 10:17:32AM +0100, Jan Beulich wrote: > >> On 01.03.2021 10:07, Roger Pau Monné wrote: > >>> On Fri, Feb 26, 2021 at 02:24:43PM +0100, Jan Beulich wrote: > >>>> On 26.02.2021 09:59, Roger Pau Monne wrote: > >>>>> The current build of the firmware relies on having 32bit compatible > >>>>> headers installed in order to build some of the 32bit firmware, but > >>>>> that usually requires multilib support and installing a i386 libc when > >>>>> building from an amd64 environment which is cumbersome just to get > >>>>> some headers. > >>>>> > >>>>> Usually this could be solved by using the -ffreestanding compiler > >>>>> option which drops the usage of the system headers in favor of a > >>>>> private set of freestanding headers provided by the compiler itself > >>>>> that are not tied to libc. However such option is broken at least > >>>>> in the gcc compiler provided in Alpine Linux, as the system include > >>>>> path (ie: /usr/include) takes precedence over the gcc private include > >>>>> path: > >>>>> > >>>>> #include <...> search starts here: > >>>>> /usr/include > >>>>> /usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/include > >>>>> > >>>>> Since -ffreestanding is currently broken on at least that distro, and > >>>>> for resilience against future compilers also having the option broken > >>>>> provide a set of stand alone 32bit headers required for the firmware > >>>>> build. > >>>>> > >>>>> This allows to drop the build time dependency on having a i386 > >>>>> compatible set of libc headers on amd64. > >>>>> > >>>>> Signed-off-by: Roger Pau Monné > >>>> > >>>> Reviewed-by: Jan Beulich > >>>> with possibly small adjustments: > >>>> > >>>>> --- > >>>>> There's the argument of fixing gcc in Alpine and instead just use > >>>>> -ffreestanding. I think that's more fragile than providing our own set > >>>>> of stand alone headers for the firmware bits. Having the include paths > >>>>> wrongly sorted can easily make the system headers being picked up > >>>>> instead of the gcc ones, and then building can randomly fail because > >>>>> the system headers could be amd64 only (like the musl ones). > >>>>> > >>>>> I've also seen clang-9 on Debian with the following include paths: > >>>>> > >>>>> #include "..." search starts here: > >>>>> #include <...> search starts here: > >>>>> /usr/local/include > >>>>> /usr/lib/llvm-9/lib/clang/9.0.1/include > >>>>> /usr/include/x86_64-linux-gnu > >>>>> /usr/include > >>>>> > >>>>> Which also seems slightly dangerous as local comes before the compiler > >>>>> private path. > >>>>> > >>>>> IMO using our own set of stand alone headers is more resilient. > >>>> > >>>> I agree (in particular given the observations), but I don't view > >>>> this as an argument against use of -ffreestanding. In fact I'd > >>>> rather see this change re-based on top of Andrew's changes. Then ... > >>> > >>> But doesn't using -nostdinc kind of defeats the purpose of > >>> -ffreestanding, as it would remove all default paths from the include > >>> search, and thus prevent using the gcc private headers? > >> > >> I guess I don't understand: It is the purpose of this change here to > >> not use compiler provided headers (nor libc provided ones), so why > >> would it matter to retain any kind of built-in include paths? > > > > Sorry, I'm also confused. > > > > It's my understanding that the point of using -ffreestanding is that > > the compiler will set __STDC_HOSTED__ == 0, and then the built in > > compiler headers will be used to provide a freestanding environment > > instead of the libc ones. > > > > However if -nostdinc is used the header search path becomes: > > > > #include <...> search starts here: > > End of search list. > > > > At which point setting __STDC_HOSTED__ == 0 is pointless as the built > > in compiler headers are not used, and hence the compiler will always > > resort to the stand alone environment provided in this patch. > > > > -ffreestanding also allows the program to have a non-standard main, > > but I don't think we care much about that since we already use a custom > > linker script. > > While indeed we don't care about this specific last aspect, we > do e.g. care about the implied -fno-builtin (which currently we > specify explicitly, yes). So while with -nostdinc added we > _might_ indeed be fine already, I think we're better off going > the full step and specify what we mean, even if - right now - > we're unaware of further effects which are relevant to us. (For > example, I don't see why in principle we couldn't ourselves > grow a use of __STDC_HOSTED__ somewhere.) OK I will rebase once Andrew posts an updated version and adjust the commit message and comment to notice what we have discussed above. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 10:28:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 10:28:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91427.172862 (Exim 4.92) (envelope-from ) id 1lGfn0-00066G-Dh; Mon, 01 Mar 2021 10:28:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91427.172862; Mon, 01 Mar 2021 10:28:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfn0-000669-AQ; Mon, 01 Mar 2021 10:28:34 +0000 Received: by outflank-mailman (input) for mailman id 91427; Mon, 01 Mar 2021 10:28:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGfmy-00065l-UI for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 10:28:32 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1b11b183-2410-4fbf-baaf-2ccbebbb1510; Mon, 01 Mar 2021 10:28:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b11b183-2410-4fbf-baaf-2ccbebbb1510 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614594511; h=from:to:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=4p6vOgGgpqTEuKoZ6o1srBL3CupbXELEbGPZ41JgdJk=; b=VtIaDZmsmAjF6JHcWGYeplURhuVur0tSUGk4/RcsgiUS0H/3rvODvrBc wBH7qHs5Uf9h2uQqWjH0qKCuBRLPdFLO4JLmHg9AUJBxEtpQZPz6VRtSE B0zX2F3YhZe5ejqB69XMI627BvSdxVQ18ksBwSYiEGp05hiEa9s6ado9/ o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 90g6ugrqQAnla3kXZci7lDC1QZwjffyuupxJCQR19wbfsVjHWixUwABnkJW+KjHoUoEodGPg0H dVhLRmhtgUL4QktSmTKVD69YRT+l6wo/eqnWv1cXD67INo3DHNE8Yl7TuNHktbrR3BAVWlsN67 j2EGj/3HsAWQXhZUM/ZfKW6biQB33VhzRDHWGGpcQ7tcia78yNyLsl+V7gIAst7pv+CBXdRSNN XF3kjQbMcMAPE2qV/s73lBZg7pwuAh3Aew4JDadDDJ640PZMudoJCHWj9mzaPXXDRixcPM/LOk u64= X-SBRS: 5.2 X-MesageID: 38237403 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38237403" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Au+lzRP4MSa9NvedH5/weHDSH3Gi7E6YOgck2s6krrjv6H8EnAl5HUNmyInIlbqIxT/h5rjWJBG2wW9be6H1a4TSLw109EGh2XINChenGE5thNSocPoRzipB6+irvkVTGqNcr4oZOHIz9o67qlD6Onlc+s90RYnc+8w4mCCo5qTqdaW9gA9Soh+5dZLAr4hBCxRZVGbT4rBa2PSP0bYM8qjZD6SG+UvDJVlraPCnwT9VCiqhri3JrUKPg02pIe5do1K6a7D6liNBIQUR5ZiTxXb0MTVhNrZsxI5ZgChWdOVXEugo4L8c2arjqE48aaepcEAGCQAHoBbUA7ol6mHW5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4p6vOgGgpqTEuKoZ6o1srBL3CupbXELEbGPZ41JgdJk=; b=Na0DYAdzpSwgfNraaj21NXiT1f4XP+2ia0d3bnhG3E4XuWK90ynkRFF/GpB5pGQ/t0XtH0NyTjLJ6YE/O4VxCHyPSlKu1OhS9wL/xxWuYOgxEfjYH7UzlxgXMNuC7ooNggo+QtXnU1S2psNpGXsGx8ii7ch+q2AYJTyirifnuWphMGRflRBzCexoVjtUmEflDG6TO94m+ZJCXZEiQy/jRtCChUB7Q0oesmJHcUzPPyGVspAAA28chxJQzccq/xfOoyzMSUKBhvEL8Vfqued4qhKcZ2WREXGzM3Dj0eHr0pT0D19KzqEQGZ+CUPxvPKv3d0ww44/f2XQdirJBzMPrGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4p6vOgGgpqTEuKoZ6o1srBL3CupbXELEbGPZ41JgdJk=; b=KQz12FUc5j4lUA4K/zO9GCZ/FCrh4nVGyu9T8MyVi6JcbZEdTUb4v9uOboVDjsP6L/9zS7dsfGL5X+p5+d63QTldszRa8KBRUwBlXKL7/b29imJtvMzpr/ykmSzS+9LRTHKxJqOYUWYYxzOr9AYzUh+GG4bLDwp6OwVNTjH+4ZM= From: George Dunlap To: "open list:X86" Subject: [ANNOUNCE] Call for agenda items for 4 March Community Call @ 16:00 UTC Thread-Topic: [ANNOUNCE] Call for agenda items for 4 March Community Call @ 16:00 UTC Thread-Index: AQHXDoWcA7IBXVquOEeGxSOPEpK0Ww== Date: Mon, 1 Mar 2021 10:28:25 +0000 Message-ID: <3BDC2651-9FC0-409C-BED3-46114C6E0696@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7ba238c6-6fe8-4271-809b-08d8dc9cbf3a x-ms-traffictypediagnostic: PH0PR03MB5799: x-ms-exchange-minimumurldomainage: cryptpad.fr#2293 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3Bg07WBZ2+u0rpIb+7+cEWSS6gvZl7bHFKZ93O30ciHAAmCuvo+MA7DL+rvdQxM+/3fn3fkP5h/BzICPsdyMdvn42nOm6jnRUFky5FGCdPRpzaFAfkt745mD5GC3O0YGKO3rUQjw5o4rLP9W9kiWFy75UOzWlGhlBYTl6tsUV9tXMINcP/FntJ3G1uWeNtO3UKC+N5dG7bjYdHQAu5eCX5mm4j7MN11mL6I+Rm+Yg8dx9xR0J4bR7YGS0Cett9U2IZBPMqjZ9Thd7gegUjOGVcNEJUgxzO8wejDdvQkzo2A3J9+xNss8KDQ/qkMlXqxDX8Z0ArHSIBvHRiR85JULFbhi/xs36/oLaexqbHuqpjvZEY5oO/cwsUO+iPBtNuSa/w2oCSl7E5SdTanoEkzcuuBwh6crbpaIsxYZ+wvaH9uM6pihlsxPeyTB2YZuIwd6k+darNs0vDs+dNVq3peTPahyp9If8BE2srjL/rkywDjdtSReU4d/eeMgIWjaFgw2GZUcLz/i14Kheeul4EzSzC7FqlBJ4PqFO5xkaz0v5fX1T9VjEEEGVon/LPRY1Uf2xvzDnVVPTZEf8ebQCKFI1ssrupjHJbINtPEXSsCZB3MWkY6G8mvgARh6F6VKd0PqkBCtO1u/KUquV8X1cVALGg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(366004)(136003)(39850400004)(396003)(36756003)(7416002)(8936002)(5660300002)(6512007)(6916009)(316002)(91956017)(2616005)(86362001)(6486002)(4743002)(7406005)(76116006)(33656002)(8676002)(66446008)(66946007)(966005)(2906002)(71200400001)(478600001)(64756008)(6506007)(66476007)(26005)(186003)(83380400001)(66556008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?ZW1HVi9RMmxGYjFueFYvZzNoSktQNlhocXh2bC9waS9RdTNXWEpkY2ttd0Qr?= =?utf-8?B?WDNsQ0tZZmNIb1c0a2ZET01Rc3laTi9OSTJ5RHNJVkZHbzFYZzRTSGFaV1VV?= =?utf-8?B?ck9nY0JkMTM0N3VaZ3dURlJjZjU2ZklHOHFjVXA5UzBoUjA2cHJ3YXBKenA5?= =?utf-8?B?ZDJuTDBnL2p3TU16K3BJYmc5dWo4MkxTS3d2ZUR5L2tNNThBNExxUVR2TWhh?= =?utf-8?B?ZXNqQnRHYzhqVEFBKzd2NTlqWDk2Z1NJTC9XRmZBaW1TbjNCT2hkT0ROeUlY?= =?utf-8?B?RzlMdFJnQWxNWDRXYmRUSFAzNm1FUjA1Y25nSVk0alJCYkt1QnJtdHV1cVM3?= =?utf-8?B?aHU1em1McUxmbU9wM3lHUEdnM2RZeGNXUWpUTVJHVXBnQStuL0RxMERGS0Fy?= =?utf-8?B?RTRoTEF2Vlk4aVNjWkpseWcvcGtDTFJQMlFSdnpWbjltVGRIVGxNbWlLSzRO?= =?utf-8?B?dHJQLzllZEFIMC8xaTlmSHBrQUhiRDREVXI0OU41R0ZlWis2WU5ETHNvWXBt?= =?utf-8?B?Y0ZpejR0elYzRFlHSXRxVVh1dklLWDJwU2hYK3ljR1hjZ1pJYVZuL0QrV1l5?= =?utf-8?B?eVVGbk55TVJwQ2dVRjFBeWhBSDRQNk1NYTVDZm5HeWFqTGx0bGJrNnJRdFNH?= =?utf-8?B?WXNObWFNbkJZK0hyQmp3dFZscWpmZXhNLzliTFR3L0FyMzNxUEZTS3NzTEFv?= =?utf-8?B?QnloM09YTlMwMFNCc1NoZjkyaWVPdEJTSWVLRHAxNFBiV3hyOHVTRTF3anR6?= =?utf-8?B?UTV2NVRVUmxsYk9KMnNjWjBxMTZnK0hrZkd4MTFnSDRBOURCUHNlRi9oRk5x?= =?utf-8?B?clR5TGFlM3Jka2dMWUEzb05OL0J4b1lJSTJmQUE0VjVJRnVKdVIwYjF4RHhz?= =?utf-8?B?ZGlNYm1uWkQ0UUVsWW94Z1lLY2ZCdm5TZ3AyRWQ3T0JobG0vU2FjdmtHVml0?= =?utf-8?B?Q0svdlpWY2ZDRUpHTGgvSTNHeXc2U1BCc0cvM0VXNk9qT2MvZU9nNEJiQlZE?= =?utf-8?B?Z24yWEh6M2xWbUM1QXlYaUxmOWVad3UyQVdWVVZQVmlFRFJlai9Eb3VId3Rz?= =?utf-8?B?emphUmk0LzM5UDNRVU5PUnNaaU5KZ1M4US9nS2NGaFhnY3VvRjhEWDRDbExu?= =?utf-8?B?bHJ4akMyRWdHQlM5RC9XWUtycXRCNGU1NnNwNlVGSVNtaUtZSHM5NzlJRS9p?= =?utf-8?B?QlVnRkVEZ2dqZk1ybTA0TkNKazdNc3JaZk0vNitPYTViWGp3NkR2UEVZSE9E?= =?utf-8?B?cDZTNFZCd2ZDYlFyd2VmKzJuTGNhUjdLcVVnUDZMMjE0K2FBU2JDTFVYT0E3?= =?utf-8?B?OHJQY0ZBRUZ0Rk41SWxpdng0TzJ0ZWVjTWFzM2wvSlFQN2NvQjFXRU1GU3Bt?= =?utf-8?B?VlMxdDBpY1FSZnBqWDdybnUrT3UwMU5UZ2ZSQ3dkNG1LbzlEcmFuclhsRnpz?= =?utf-8?B?VFUxN0toNTBYMk5mbTE3OG9LZTh1TUZLWDAwNEpTajR3d21rN1Y4UHZXY0Vw?= =?utf-8?B?T25Pbnp2bGFzcDd1V29NWS8zRHhoSjlEZGdBRUhRc2trenRZVnNiV2NMZDRn?= =?utf-8?B?S2dxMTg5Z1A0aVk1NFRIOHFkOXl5SGlvLzF4ZmV5ZHpmVXVFUllURVd0bHlp?= =?utf-8?B?OEZWZmxSb2czdlZkdUNpb1JtTkFNQ3RBRXgxTGpiTTJZN1A1am91ZkMwQVFp?= =?utf-8?B?aDhVUVhIYyttVWN3OXFQM0V2UlREQUtJV0MzZjRNb0VtSmUxT0dNVXpDVU1a?= =?utf-8?B?K0EzUjdnZjdhUGxnYXZRM3I3OFpsaHpqUXZZZ1grQWN5ZHp4WDBoQUl6YjZV?= =?utf-8?B?RTk5aTRpcjBtc050MWNiQT09?= Content-Type: text/plain; charset="utf-8" Content-ID: <8EC44C406A19F148886E0A5E15E06D1C@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ba238c6-6fe8-4271-809b-08d8dc9cbf3a X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2021 10:28:25.1518 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zn/LroW4DR1yRdf6C+mQkTwmk5ozw96Pc7asaG0+0EMk49QBgAhBbNDetqyvXtED6Toxy9ZWYtuJfKaU4bjyBXGhQ+/5z01f0NdxR/YaRfU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5799 X-OriginatorOrg: citrix.com DQpIaSBhbGwsDQoNClRoZSBwcm9wb3NlZCBhZ2VuZGEgaXMgaW4gaHR0cHM6Ly9jcnlwdHBhZC5m ci9wYWQvIy8yL3BhZC9lZGl0L2ZCanpuUWxHWUdjSHdxVDAtTXUrbDI2MC8gYW5kIHlvdSBjYW4g ZWRpdCB0byBhZGQgaXRlbXMuICBBbHRlcm5hdGl2ZWx5LCB5b3UgY2FuIHJlcGx5IHRvIHRoaXMg bWFpbCBkaXJlY3RseS4NCg0KQWdlbmRhIGl0ZW1zIGFwcHJlY2lhdGVkIGEgZmV3IGRheXMgYmVm b3JlIHRoZSBjYWxsOiBwbGVhc2UgcHV0IHlvdXIgbmFtZSBiZXNpZGVzIGl0ZW1zIGlmIHlvdSBl ZGl0IHRoZSBkb2N1bWVudC4NCg0KTm90ZSB0aGUgZm9sbG93aW5nIGFkbWluaXN0cmF0aXZlIGNv bnZlbnRpb25zIGZvciB0aGUgY2FsbDoNCiogVW5sZXNzLCBhZ3JlZWQgaW4gdGhlIHBlcnZpb3Vz IG1lZXRpbmcgb3RoZXJ3aXNlLCB0aGUgY2FsbCBpcyBvbiB0aGUgMXN0IFRodXJzZGF5IG9mIGVh Y2ggbW9udGggYXQgMTYwMCBCcml0aXNoIFRpbWUgKGVpdGhlciBHTVQgb3IgQlNUKQ0KKiBJIHVz dWFsbHkgc2VuZCBvdXQgYSBtZWV0aW5nIHJlbWluZGVyIGEgZmV3IGRheXMgYmVmb3JlIHdpdGgg YSBwcm92aXNpb25hbCBhZ2VuZGENCg0KKiBUbyBhbGxvdyB0aW1lIHRvIHN3aXRjaCBiZXR3ZWVu IG1lZXRpbmdzLCB3ZSdsbCBwbGFuIG9uIHN0YXJ0aW5nIHRoZSBhZ2VuZGEgYXQgMTY6MDUgc2hh cnAuICBBaW0gdG8gam9pbiBieSAxNjowMyBpZiBwb3NzaWJsZSB0byBhbGxvY2F0ZSB0aW1lIHRv IHNvcnQgb3V0IHRlY2huaWNhbCBkaWZmaWN1bHRpZXMgJmMNCg0KKiBJZiB5b3Ugd2FudCB0byBi ZSBDQydlZCBwbGVhc2UgYWRkIG9yIHJlbW92ZSB5b3Vyc2VsZiBmcm9tIHRoZSBzaWduLXVwLXNo ZWV0IGF0IGh0dHBzOi8vY3J5cHRwYWQuZnIvcGFkLyMvMi9wYWQvZWRpdC9EOXZHemloUHh4QU9l NlJGUHowc1JDZisvDQoNCkJlc3QgUmVnYXJkcw0KR2VvcmdlDQoNCg0KDQo9PSBEaWFsLWluIElu Zm9ybWF0aW9uID09DQojIyBNZWV0aW5nIHRpbWUNCjE2OjAwIC0gMTc6MDAgVVRDDQpGdXJ0aGVy IEludGVybmF0aW9uYWwgbWVldGluZyB0aW1lczogaHR0cHM6Ly93d3cudGltZWFuZGRhdGUuY29t L3dvcmxkY2xvY2svbWVldGluZ2RldGFpbHMuaHRtbD95ZWFyPTIwMjAmbW9udGg9MTEmZGF5PTUm aG91cj0xNiZtaW49MCZzZWM9MCZwMT0xMjM0JnAyPTM3JnAzPTIyNCZwND0xNzkNCg0KDQojIyBE aWFsIGluIGRldGFpbHMNCldlYjogaHR0cHM6Ly9tZWV0LmppdC5zaS9YZW5Qcm9qZWN0Q29tbXVu aXR5Q2FsbA0KDQpEaWFsLWluIGluZm8gYW5kIHBpbiBjYW4gYmUgZm91bmQgaGVyZToNCg0KaHR0 cHM6Ly9tZWV0LmppdC5zaS9zdGF0aWMvZGlhbEluSW5mby5odG1sP3Jvb209WGVuUHJvamVjdENv bW11bml0eUNhbGw= From xen-devel-bounces@lists.xenproject.org Mon Mar 01 10:42:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 10:42:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91432.172874 (Exim 4.92) (envelope-from ) id 1lGg0J-00080b-Kf; Mon, 01 Mar 2021 10:42:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91432.172874; Mon, 01 Mar 2021 10:42:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGg0J-00080U-Hj; Mon, 01 Mar 2021 10:42:19 +0000 Received: by outflank-mailman (input) for mailman id 91432; Mon, 01 Mar 2021 10:42:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGg0I-00080P-2E for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 10:42:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGg0H-0006Ae-Tq for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 10:42:17 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGg0H-0000PH-R9 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 10:42:17 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGg0E-0003xI-G7; Mon, 01 Mar 2021 10:42:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID: Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=kXXWbCgjSJs0IRrH/59fj5mBp1lN/CcyDE0xepKa8XU=; b=nBpZLuPZlGGWH8R84Ga3hFuqqY wqRFczGGE9n8SkUkx0T690RNPLR6CpqgCMAaNKYkr0JVMWQeI1qgGXDyqHVFxVi1kmOhT1vXa/pQ4 VdnvutVK84wX0qhiWkbEy1c2S79Bj8D6x6E4T9kBcP1IUHAJwHDM1gVtxVXcC0NESMEc=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24636.50438.204769.9038@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 10:42:14 +0000 To: committers@xenproject.org CC: xen-devel@lists.xenproject.org Subject: Commit moratorium for Xen 4.15.0-rc1 X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) I am going to be cutting this RC shortly. So please don't commit anything now, even fixes which already have a release-ack. Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 11:16:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 11:16:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91435.172886 (Exim 4.92) (envelope-from ) id 1lGgX0-0002ZY-6v; Mon, 01 Mar 2021 11:16:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91435.172886; Mon, 01 Mar 2021 11:16:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGgX0-0002ZR-42; Mon, 01 Mar 2021 11:16:06 +0000 Received: by outflank-mailman (input) for mailman id 91435; Mon, 01 Mar 2021 11:16:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGgWy-0002ZL-1d for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 11:16:04 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id d1bdd6d5-dbb7-4621-8083-47171dc20600; Mon, 01 Mar 2021 11:16:01 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-65-ODy2Ef9OM0WM6VBrQGnVAA-1; Mon, 01 Mar 2021 06:15:58 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 589AA106BB23; Mon, 1 Mar 2021 11:15:56 +0000 (UTC) Received: from merkur.fritz.box (ovpn-114-165.ams2.redhat.com [10.36.114.165]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B4DCB60BFA; Mon, 1 Mar 2021 11:15:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1bdd6d5-dbb7-4621-8083-47171dc20600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614597360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UW5EAhRq01zAlhshGr6Cj14eUZMgDl5l2wepDZBjdqk=; b=Mq38vOakwCAA9ufqoSCEW/o6psBIIBqrO1XIwMmVYZg7o4cT7pTABX+VFagCMMSgwT4Dc3 f1n5jNyiEoFoqAfmg4RrHZcPuTOhocmHQhMJRckfVmBPDpEhS3FwszdtdtLMNdL0YYat7A yqlZr9ziv/wHkpCUsQdNFxPZ0eihTDg= X-MC-Unique: ODy2Ef9OM0WM6VBrQGnVAA-1 Date: Mon, 1 Mar 2021 12:15:34 +0100 From: Kevin Wolf To: Jim Fehlig Cc: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , qemu-devel@nongnu.org, Fam Zheng , "Michael S. Tsirkin" , libvir-list@redhat.com, Mark Cave-Ayland , Gerd Hoffmann , qemu-block@nongnu.org, Juan Quintela , Wainer dos Santos Moschetta , Marcel Apfelbaum , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , "Dr. David Alan Gilbert" , Greg Kurz , Cleber Rosa , John Snow , David Gibson , Vladimir Sementsov-Ogievskiy , Max Reitz , qemu-ppc@nongnu.org, Paolo Bonzini , xen-devel Subject: Re: [PATCH 00/14] deprecations: remove many old deprecations Message-ID: <20210301111534.GD7698@merkur.fritz.box> References: <20210224131142.1952027-1-berrange@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Am 25.02.2021 um 18:32 hat Jim Fehlig geschrieben: > Adding xen-devel and Ian to cc. > > On 2/24/21 6:11 AM, Daniel P. Berrang wrote: > > The following features have been deprecated for well over the 2 > > release cycle we promise > > This reminded me of a bug report we received late last year when updating to > 5.2.0. 'virsh setvcpus' suddenly stopped working for Xen HVM guests. Turns > out libxl uses cpu-add under the covers. > > > > > ``-usbdevice`` (since 2.10.0) > > ``-drive file=3Djson:{...{'driver':'file'}}`` (since 3.0) > > ``-vnc acl`` (since 4.0.0) > > ``-mon ...,control=3Dreadline,pretty=3Don|off`` (since 4.1) > > ``migrate_set_downtime`` and ``migrate_set_speed`` (since 2.8.0) > > ``query-named-block-nodes`` result ``encryption_key_missing`` (since 2.10.0) > > ``query-block`` result ``inserted.encryption_key_missing`` (since 2.10.0) > > ``migrate-set-cache-size`` and ``query-migrate-cache-size`` (since 2.11.0) > > ``query-named-block-nodes`` and ``query-block`` result dirty-bitmaps[i].sta= > > tus (ince 4.0) > > ``query-cpus`` (since 2.12.0) > > ``query-cpus-fast`` ``arch`` output member (since 3.0.0) > > ``query-events`` (since 4.0) > > chardev client socket with ``wait`` option (since 4.0) > > ``acl_show``, ``acl_reset``, ``acl_policy``, ``acl_add``, ``acl_remove`` (s= > > ince 4.0.0) > > ``ide-drive`` (since 4.2) > > ``scsi-disk`` (since 4.2) > > > > AFAICT, libvirt has ceased to use all of these too. > > A quick grep of the libxl code shows it uses -usbdevice, query-cpus, and scsi-disk. > > > There are many more similarly old deprecations not (yet) tackled. > > The Xen tools maintainers will need to be more vigilant of the deprecations. > I don't follow Xen development close enough to know if this topic has > already been discussed. MAINTAINERS has a section for "Incompatible changes" that covers docs/system/deprecated.rst. Maybe if the Xen maintainers are interested in that, we could add another list or individual people there so they would see patches that deprecate something? But either way, it would probably be useful to check the full deprecation list rather than just what we're going to remove right now. Kevin From xen-devel-bounces@lists.xenproject.org Mon Mar 01 14:01:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 14:01:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91537.172934 (Exim 4.92) (envelope-from ) id 1lGj7G-0002ZL-1L; Mon, 01 Mar 2021 14:01:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91537.172934; Mon, 01 Mar 2021 14:01:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGj7F-0002ZE-UO; Mon, 01 Mar 2021 14:01:41 +0000 Received: by outflank-mailman (input) for mailman id 91537; Mon, 01 Mar 2021 14:01:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGj7E-0002Z7-F6 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 14:01:40 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 28cbd892-144d-41c3-94c9-a9c4839e7bb2; Mon, 01 Mar 2021 14:01:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28cbd892-144d-41c3-94c9-a9c4839e7bb2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614607298; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=O5AEz9nTmvG94Dz/cZ00sMyD8v8tmrNrIFGLwZqaMJE=; b=fw0rDzhBFYFXKNCgQKoVMlnaRo/nlVhiZkdDOFBdjlqOWzuyABtjShpW WfVMbVCBD20b0HtNxpDr6lxjy8DyzZV8Cryt+lxhUy6Lv3vvTPFLsm11G UftABkdDCXiEqs8rd6fQjN+KcJlNuIUAbfWaQCgpz0xZyld2H7HlmUt81 M=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: rMLn6bj7Mxcp9bZvQjv/xeZlwnfurQ4gHBMWzf0587OqCyUPCvxkOjQB0NJuWcUcfFi9Txq0qz U2EN+NRxn2LdCk0c8YTZ31Z2cEZMrQrXGJtHZvUiOsNtcqyOG1ejVVLKCWhVTeJu+aqqwAUvm0 dbT2Y5qXCb3w6C7HF3tHb8FvdHBioyiJ0VUSKeIcaKBWg3rQleKtfdXkAmWZMu+IAIb9IMNdhc qafBahFFhcw3pjws/cw05Dt8tFG3sRKKvpRsUK7OKYxnEnzP19nbuxsiIPn5yBejgF/oIYD4Nw NCc= X-SBRS: 5.2 X-MesageID: 39636946 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="39636946" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QaQtpyi+hhGoZnXIOJUIgUXbFCcGQeq1fsFY0y75PVyFAoFUHBWeEUYbpdTNXw3h5h+YCLPDHvZs5CMlZG73kpfR4zaHSD0d7fAjlD6MGjwmapCTE+Sh0kPIbwNagGYdXK9wrZ9nsyh9lxZMzSBmtXa3ooTR5DbHPCmqkeylbZTg6jXwYf8RmqFxCKPs1FjtGB85Eh36PJ9B59UhbwdYFX8OfNpCdPHBxNJdTfh8SKojZsSUCIxacYkrxGpIIdZbzUymjux5yOeZALSuFH+BmrAMViHBwtok150MBY6cw0fIoP3tSrMdTpuqcU+jd+GaAmOa/o6OqNpBR/+P7OH4AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O5AEz9nTmvG94Dz/cZ00sMyD8v8tmrNrIFGLwZqaMJE=; b=JmsUifwB91IyR5j7bybixCSAjXBCfStIFgIDW3mA28qrF0Q8FmtQGk6xQRyaptJbAvLyBgxGosqr2gBEjun1OG/XB80bRCr2zIk8f7tWVpEHsKXXAKR0I4lFmYIGfl6A5Lf1kCNAiAwgOIqXLkRaU/lVYSKHK7+8YjwXJTpbQmocaqMaLIDPFYyItc4wj5pDsCeU9RYpIv0F0wJChat/4DZZ1HiqmFYRMRMsyVWL8NKRyhwQYE20QQt/9vmQOnNxurTIbLVovwRUSXN7e7iEqeYbjyVqaeIhLCUR3NPxti933GTemg16+a7JgMV7BaTunbgqYx0oA5I0f536guihTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O5AEz9nTmvG94Dz/cZ00sMyD8v8tmrNrIFGLwZqaMJE=; b=Y2Xausy7RaT5Kd08+m2oyq76nLW+EQWczvKXCP6Fc0XV6bkU7qiOojwkp2s+CS59LWsPZvRDn/gfLRuX040WUPTd/QCbeYLmB2snVEShRWUYkdjsvbz6kbxzknEfRtmAKoy9hXAsQBswrpEF1R1Qa9bzXY8SFGwgFjI1GSdU1Ik= Date: Mon, 1 Mar 2021 15:01:27 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , George Dunlap , Ian Jackson Subject: Re: [PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1 Message-ID: References: <1d8d5089-32a9-9c42-5949-8f9cd20f33e0@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1d8d5089-32a9-9c42-5949-8f9cd20f33e0@suse.com> X-ClientProxiedBy: AM6PR0202CA0058.eurprd02.prod.outlook.com (2603:10a6:20b:3a::35) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3ee85fe5-65e4-43e8-d3db-08d8dcba85eb X-MS-TrafficTypeDiagnostic: DM6PR03MB3740: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lTV8hxWTm8VQvuM2XC7ItXCB7PkG2DX5DF/THOpzdY/PPUwjT+AaTcnAA5BibbynnRJUsHBZgHnAgBXvtEQGZ09f4wNUQPwHyyol8uGiE+AHDr03xExvMab5hs4o7LEUSZVS8JSF1p4YFYZfdYhGPEUP+1D55SkaXtj7z2aQdxIiQg76R9VcBAhxJHjgyv13o6ikBOZxSrSuXv2VVN6kJqvOYguxZXL3/INUF2xjgY3tTKqApbZVr+RlOucf+fasuBJMad4098ESfWRaS2j965ZyaK3AUf2uHJ/YM3cIpTAHqdtiqz7bwoftLyWViMih+ZNZD9XCtkV3bdsiUHOhfcUbm+E0WvXTX0z06ykCNmXsfVD0Szzx09x//LPKbkSS4f4kK696FRpWMdTxX4EFzU0wXyAMMmCvQX6Aj/O3pOD3Hxm6+qins5+OP7T+PkSsPPdY3NzJcSVLjb4Gn1bcsVq/Q+sHsf7eAr3wK3aELuUHaBujfGFR5lFBxYTbjhfzQCh5dHmemkI+m+jUXU5obw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(39860400002)(136003)(366004)(376002)(396003)(346002)(33716001)(5660300002)(2906002)(8936002)(6486002)(956004)(8676002)(66946007)(66556008)(66476007)(83380400001)(85182001)(4326008)(186003)(6496006)(16526019)(54906003)(316002)(26005)(4744005)(6666004)(478600001)(9686003)(86362001)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?R2FiaFZuTnF0ZEZWZ3FneUwwTUhqd2k5elEzQmlmY2wwQkUxcjlWMXFvSUZM?= =?utf-8?B?c1hRb2xpYThWS050UnNwc3BtWXFtSDhBcGh6SUhlMmh0dmcrbGJYTGN2M1kv?= =?utf-8?B?NU0vNnhKV05seWRZK29VTnNNOUUxZFFlbXBQU081cWltWnIyTWU2b083K1dK?= =?utf-8?B?Myt6Y0NHZ1dacUFkWHpxdWtTeUVySUYvNXBrZE1nTzNzTXJhdEtXTjJCMHJr?= =?utf-8?B?WVFTdmVTUGs5RnhaUnNrd240NzZQNzJsWHgwUUFzemtjV1EraFlHOGcwb1JK?= =?utf-8?B?Q3BJeW1VaFI2WFFwd3haZ1NXeVVHcXlOWDNiSWpMY0ViYjJmMTZVNGF1YlNp?= =?utf-8?B?RDVRMUV0UENoSjNuRXVidmNINHdXVGQ4NFlwT1pOQmc2R0tBUDM4bVN0ZG12?= =?utf-8?B?ZUJsaWNiNE9MN1EyQlNjcTRsN3luVHVHd2tOVENVRjMydWtTVytkckNkbHo4?= =?utf-8?B?MXYxLzZtMjF3S1JOVm5DNWM1Vldpa1l5ek1JNEdRN0FveE84VVMyQXRCMUhN?= =?utf-8?B?U1pzOW5yTU95cFRwajJEY1djcVBPNVVOcHpzWlpldTBqdjRlNUY5eXpoYUdO?= =?utf-8?B?WWViRWJIVkthckV4MThuTU5kK3p4VnpHdm8weTU5V0xieXNoMURObEppaTN0?= =?utf-8?B?Vnh2ZEZPQVFNS3ZlSW5UNTNTZWlHSUpqMFd5Z0xhZVdhdmxtd3RuTzluYlU1?= =?utf-8?B?bFc5eGlldTRPeDFmb0pmT0M0ZUF0aDhWOUlMckduZ1U3cXFTZ3JqL3BxczNo?= =?utf-8?B?VWpmRmhXTFVoUDh0UXRCQ0ZSMlNaU0p3WWVIdm9oTFBZVHBOZWpuVnpOWXM3?= =?utf-8?B?cnBiMDhVeTB3OU8vL0JLRkFZVXo2RzF3amtzeWRiWHQ5Q25BMmtpQitnVXZN?= =?utf-8?B?V0F0RjFUWUpySjcxRVJkWU1yL3pjVUM4S3hsVjRMZmt5K0hyME5jMVhDUWlo?= =?utf-8?B?a29WdmxJdVdhTDRYcmFaZ1NSclpnc3JOb2xxQTFkQ05JNnRjV0dLVmdNbFB2?= =?utf-8?B?RjdOZzNyU0JqNFRxOEp2VXl4UjkwU09tVkJpTm4rRDlheFJIdW1ndFFIcHJX?= =?utf-8?B?dFkvSDRKTHd5emFLZTZSUEpONHhpUGVHa1A2UVk3SXJYMHNGSy84RnFYeS9L?= =?utf-8?B?Ui9VOVVMd2M2N09HWXFBT0YvVnJQcDNERTRDVnljUVdad1lxeGJ1d29nd284?= =?utf-8?B?RVExWTdVbitWZFBEK29CdFgwMnhuYlZCVi8welhLM3hKVzh2Y2lBRUNvTEpo?= =?utf-8?B?dTJDODZ5a0ZUZE50bWdET1dVL0x4OERHMmVSYkhPZHFQWVNQMVppSEFqMEFv?= =?utf-8?B?c29DbGZHNWhUWnd5aWVVNG94VFVuSGNDWGVIbFIzMU85MnlMN3Y3VXZrc1ZR?= =?utf-8?B?cGdydFZ4STJpbUdaV3ZIUm1WZHZCZDBQK3dvZE53VG9RbDVUWTIvb3Y1c0I0?= =?utf-8?B?VDhOREdPL1QrdDNtL08wV0l5S3N4T0U5c3hyTysvUVB3Y21aQk5pSUUwVHFZ?= =?utf-8?B?cnJWV1VtV2RIeHJZbnJ2SE5yUm9VSWt5NVFkN1o0QndhOFhqbWdZMTIxNTNL?= =?utf-8?B?YkkrQVQzcUQwakxnZzRRaUVhYXEzUUlTSmlvWWtQMGREYnJnMG1LRUhvYTRN?= =?utf-8?B?K1VaZ3QvZDRkVThheHdzVXZSSDNwK1ZiNzI4U3Z0c0w2NVFGUDJvT3ErRHd1?= =?utf-8?B?ZjlHWlFIU21xWTdDajVTTnFFNFNLS1hIMmxGRDF6OFpPdmpRSlNpWmZ3QU5s?= =?utf-8?Q?7hcFEHFfZzneVlyxlXUPpzO98jF+VW3fj+OXx1f?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3ee85fe5-65e4-43e8-d3db-08d8dcba85eb X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 14:01:34.3052 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RQy8mSHv0qOZ/8qHomC5tmOR+sCsyKE9o3ii/AvyZny7aPAuyErXxvMCECYh0Yx5ZPCUVYILziGepiq4s1eFHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3740 X-OriginatorOrg: citrix.com On Mon, Mar 01, 2021 at 09:31:07AM +0100, Jan Beulich wrote: > In this case the compiler is recognizing that no valid array indexes > remain (in x2apic_cluster()'s access to per_cpu(cpu_2_logical_apicid, > ...)), but oddly enough isn't really consistent about the checking it > does (see the code comment). I assume this is because of the underlying per_cpu access to __per_cpu_offset using cpu as the index, in which case wouldn't it be better to place the BUG_ON there? Also I wonder why the accesses the same function does to the per_cpu area before the modified chunk using this_cpu as index don't also trigger such warnings. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 14:11:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 14:11:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91544.172947 (Exim 4.92) (envelope-from ) id 1lGjGv-0003bo-W0; Mon, 01 Mar 2021 14:11:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91544.172947; Mon, 01 Mar 2021 14:11:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGjGv-0003bh-T3; Mon, 01 Mar 2021 14:11:41 +0000 Received: by outflank-mailman (input) for mailman id 91544; Mon, 01 Mar 2021 14:11:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGjGu-0003ba-Oa for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 14:11:40 +0000 Received: from mail-oi1-f176.google.com (unknown [209.85.167.176]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c4fd77bb-b0bd-43a3-b9f4-538ce7612c05; Mon, 01 Mar 2021 14:11:39 +0000 (UTC) Received: by mail-oi1-f176.google.com with SMTP id d20so18111367oiw.10 for ; Mon, 01 Mar 2021 06:11:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4fd77bb-b0bd-43a3-b9f4-538ce7612c05 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lod01F2gi753lgz6hSX8V0Vv54kwq8xzww6I7WJ5rRk=; b=fqMxrPj2TENBSe/A7Z2d9jZI3Rc0Df0zmHXrGP4ftWKoesNDJB3WEKBu7xKBtM1yVK Jh5m9grWsknVdXimJg/XTsMoy2109ZrJFhC3jNPbwUkmb2w9EophqGi1JEkkNP6WRhnm 0sYCKHToGNa1Nv5MsVwBDi8V2yeNvWv/VVfcdw8e2Vpe9lbAXqDB93w5au14VJdPvGPM 47mtUvfBmYuxHXRJvW1ICcw22pC4iud8JY+x0VAoOOZrtxcVaIi57hjQUvFj9PW5RQMZ bp7rW9bUqF2/DwdcFBXoC3P9jrA9FcY65bxv88+ElpQY5z4fyxNDCBUk544BaocXicwm kq1w== X-Gm-Message-State: AOAM532snyuOU+sxC5FFiVc0NmOAYxGoR4rImg+9ovoTX7GtNK7cYxaF 8auZAHBl2fgox0Zg1ZtLZ1NAgjP252L1pGPdW8w= X-Google-Smtp-Source: ABdhPJznWYEz0nSJMAIKsm/EiLQc07fLscL4z3c1Nc5/ixWrTp2TGuNmjEBDbNVT+qpzuvGPQkXfa3Wu2bCv3qYBF9w= X-Received: by 2002:aca:5dc4:: with SMTP id r187mr11284327oib.69.1614607898492; Mon, 01 Mar 2021 06:11:38 -0800 (PST) MIME-Version: 1.0 References: <1709720.Zl72FGBfpD@kreacher> In-Reply-To: From: "Rafael J. Wysocki" Date: Mon, 1 Mar 2021 15:11:21 +0100 Message-ID: Subject: Re: [PATCH v1] xen: ACPI: Get rid of ACPICA message printing To: Boris Ostrovsky Cc: "Rafael J. Wysocki" , Linux ACPI , LKML , Stefano Stabellini , Juergen Gross , xen-devel@lists.xenproject.org, Konrad Wilk Content-Type: text/plain; charset="UTF-8" On Sun, Feb 28, 2021 at 2:49 AM Boris Ostrovsky wrote: > > > On 2/24/21 1:47 PM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > The ACPI_DEBUG_PRINT() macro is used in a few places in > > xen-acpi-cpuhotplug.c and xen-acpi-memhotplug.c for printing debug > > messages, but that is questionable, because that macro belongs to > > ACPICA and it should not be used elsewhere. In addition, > > ACPI_DEBUG_PRINT() requires special enabling to allow it to actually > > print the message and the _COMPONENT symbol generally needed for > > that is not defined in any of the files in question. > > > > For this reason, replace all of the ACPI_DEBUG_PRINT() instances in > > the Xen code with acpi_handle_debug() (with the additional benefit > > that the source object can be identified more easily after this > > change) and drop the ACPI_MODULE_NAME() definitions that are only > > used by the ACPICA message printing macros from that code. > > > > Signed-off-by: Rafael J. Wysocki > > --- > > drivers/xen/xen-acpi-cpuhotplug.c | 12 +++++------- > > drivers/xen/xen-acpi-memhotplug.c | 16 +++++++--------- > > > As I was building with this patch I (re-)discovered that since 2013 it depends on BROKEN (commit 76fc253723add). Despite commit message there saying that it's a temporary patch it seems to me by now that it's more than that. > > > And clearly noone tried to build these files since at least 2015 because memhotplug file doesn't compile due to commit cfafae940381207. > > > While this is easily fixable the question is whether we want to keep these files. Obviously noone cares about this functionality. Well, I would be for dropping them. Do you want me to send a patch to do that? From xen-devel-bounces@lists.xenproject.org Mon Mar 01 14:35:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 14:35:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91549.172967 (Exim 4.92) (envelope-from ) id 1lGjdn-0005dr-VW; Mon, 01 Mar 2021 14:35:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91549.172967; Mon, 01 Mar 2021 14:35:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGjdn-0005dk-Rx; Mon, 01 Mar 2021 14:35:19 +0000 Received: by outflank-mailman (input) for mailman id 91549; Mon, 01 Mar 2021 14:35:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGjdm-0005dc-15; Mon, 01 Mar 2021 14:35:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGjdl-0001at-2R; Mon, 01 Mar 2021 14:35:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGjdk-0008Kh-PY; Mon, 01 Mar 2021 14:35:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lGjdk-0005rq-Ol; Mon, 01 Mar 2021 14:35:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kKWZXlvbrDMPjTUdzYCjDQBu84LHkfupVmoKND+wuSo=; b=4EwRQdqfN1hDavP8L5MyCJhzWL hmNWy/Ba6hVetNq4r4WA1/3TGVJ9zHYLJGZ/QGK04rpX2SkJtu8PeF4rDsFz1tIumc8Fk4wEWEt0+ bubNdl5zOAlfp0sNwnXFunuLKnMe9/WRIRoHueg1JLlMQXmeUfv7TAWTejoRZi4kTcDs=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159788: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c4441ab1f1d506a942002ccc55fdde2fe30ef626 X-Osstest-Versions-That: xen=c4441ab1f1d506a942002ccc55fdde2fe30ef626 From: osstest service owner Date: Mon, 01 Mar 2021 14:35:16 +0000 flight 159788 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/159788/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 159779 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159779 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159779 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159779 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159779 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159779 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159779 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159779 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159779 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159779 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159779 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159779 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen c4441ab1f1d506a942002ccc55fdde2fe30ef626 baseline version: xen c4441ab1f1d506a942002ccc55fdde2fe30ef626 Last test of basis 159788 2021-03-01 01:51:22 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 14:39:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 14:39:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91558.172981 (Exim 4.92) (envelope-from ) id 1lGjhs-0005xR-Nt; Mon, 01 Mar 2021 14:39:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91558.172981; Mon, 01 Mar 2021 14:39:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGjhs-0005xK-Kn; Mon, 01 Mar 2021 14:39:32 +0000 Received: by outflank-mailman (input) for mailman id 91558; Mon, 01 Mar 2021 14:39:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGjhr-0005xF-M5 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 14:39:31 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a9ea0d4b-b117-468c-ac42-f1b3196a2cca; Mon, 01 Mar 2021 14:39:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9ea0d4b-b117-468c-ac42-f1b3196a2cca DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614609570; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=2s7/jpucbryLMd/CgBEC63KtswULGB+1xWcUaD9hRqw=; b=V386zDBmJiBB1IPkvZKstcDbLl4sKd+T9yVPcPaF8P4xximb3F1yIZED 4MAbnhfoRHmb3zJRzDWKwJLuIA8lGaHo9SIyOKJ2TVeIWhd4IFon+i/hj ny6zCLKqu5cgP+PuPVxKDAPDNZSRu+CjovjLK12hThLqTe0iE5WwfCJNJ w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: WixwaUwfPGjh23YRBqHwapn7I0xlNemX5rq86OFdbR1/dsW7/3H86cOH99Uc3pkEJy+SrTdhXK bsg5hdhiIRMR1+j4paXeFikAsYP0WEXjjZB3S8vVgcaWxnqjsgPBgLLrys0wjc7jgnTgCGex8c iKvaEbM/gLgYpir0YUqfvTW0rKD+pjsktwUbEtW1IYj+ZvgHuXs3RxHhcwFfDscIyWEEOGtuni ASP5UoPKV6lQ80T1HMbZiDeed4GpmwOKGcuhtPiBL0XxnZJURIjhd1tRECl3tevAJJ+fQ66DWA qgs= X-SBRS: 5.2 X-MesageID: 38258231 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38258231" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AILkgrJAbRqHBI+HmkDIWtQDISsL7zNU6xoVte5R5FTGDXSjLRRwk8xpegRZbuzj+pXGbMGNNDvcBDhUyY7ag+Memj53P5lJ1jcApfo+OG2XEjVUj0lWbvPtKlbvPw/2ZdfOkdSYCd2F0ejU9DPYBfkFWF1LG5UEmaZUYBgPqWAOJoqf22dX0G4YFlcrZZT+5gWAYA4GXtBHyP4RitVjiBIYMT4WW9qiLEk0965J127COtucqd5LAnUT4U/dROb5JFiJJFlhABomZUxfiO42LfHp0ZBkPX+ds/cMFPwDwKMeO+zDNEOYkdc2DQW+r6hCNwEUrQZPDVx7F5w5X4rgPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2s7/jpucbryLMd/CgBEC63KtswULGB+1xWcUaD9hRqw=; b=HCO04tomrdpPhAEDe8rVyjG2rlIpw6O+bIaKJrGtxuWorxgCH9OBqINi4oeV8uKoqL1NcjFqns/ag7ze3dkrkzLxPSK4cCOggVZFpwkHBBDGMkMim5GW+0fF9QiFsbooPnPIuhp4PBR+AjJFT0qfXWGyD0+4NRCrHyatheGvM/CCJ/0U5eJ1Uttvclue08EJ1MtOiTfqY5rikMOx53xZdjZL+G4uWaqv2le4whjzA87V6qHzSCVEAkUpf4kqyfCgwpFDa6280oIQlirTNs20KrZ6S1mOYFV8IK4CvhTcfRV9SjpBDFiE7f3BF4tLwP7UjB0C5+UIBouEJJN+l10vzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2s7/jpucbryLMd/CgBEC63KtswULGB+1xWcUaD9hRqw=; b=OXa1XwSc0DWMTBqYeuAzlxQPhP5o+ZJw+5VBxHUWRsPPvNB9ua0I+9S81StKtSncXVe3NwvyD/4Y4tJPhjWlNpuKtqvQK39xromaKcM72Xr4yuTJjnsX9gjygPAWmEvFqZ/HrHmQrht3VV+U2dWVCWhX5y7WBbg6imJE1dZcv80= From: George Dunlap To: Volodymyr Babchuk CC: Andrew Cooper , "xen-devel@lists.xenproject.org" , "Dario Faggioli" , Meng Xu , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [RFC PATCH 00/10] Preemption in hypervisor (ARM only) Thread-Topic: [RFC PATCH 00/10] Preemption in hypervisor (ARM only) Thread-Index: AQHXCYx4A6OUUHr1gkqxWv1TEOLkuqpnnLaAgABcP4CAB0VMgA== Date: Mon, 1 Mar 2021 14:39:26 +0000 Message-ID: References: <20210223023428.757694-1-volodymyr_babchuk@epam.com> <25034a7a-83ed-0848-8d23-67ed9d02c61c@citrix.com> <87k0qx9gw0.fsf@epam.com> In-Reply-To: <87k0qx9gw0.fsf@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 994ead64-15df-4f5f-6189-08d8dcbfd047 x-ms-traffictypediagnostic: PH0PR03MB5718: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y86HmnN7av9at1rUtMW8fOxpZHk2CqTfRI0QI+tPZl/DpPmF/iFTE7xeTDAeRcDZGUBeHRmSJXCi8KKRKZ5SXP+bp/Rf9/nR3L7Zh/xX3cTDx0xMTCOZW4FceMp4gA9tPcfiyZ74vGLHK7DCk5uCHr6p0C9vN8Y9+aaaAtL+5IjgB7XyWSqh9lFhsPrjDm0ugUB0FgVnOgn1YPa3zOMl7g8J1MGTgGBdAIuTlMBgJ8WmGcOY1sBOfGEN+CIrbG9HdGOhqEBfOBXe7P5Xh+ISWVCk7/ysDl0cqugCLHPnfXqfsc/uuvy8GxuAf+2/NCoSo7vIqvErMUYjudNU51TZRwRCIMnB4CLodM4mNMHWJ8rqcLe27VT7UPl2vcpYkJbRcuyL6HrQuBWv8+6Qug9cGWErnsxItnFlnD4I7FQTl6Y+0dDi1UPDKuGhUmSdVH2/MCijJTl5YPJ46Y89cjIbHrVloHaiLM/nPoXhg8eSsW1UTO6uyJVZr0n30IXkzc3l1yoTwtv9JBk9L84AOsZzdQdNX3UU76Rd5uJLEM6Afiv9WTHzqp3/Hu6BSUQLv5974wUK94bokxH7oxnt1viA/Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(136003)(39860400002)(376002)(396003)(66446008)(66556008)(71200400001)(66946007)(53546011)(6512007)(5660300002)(83380400001)(6916009)(4326008)(66476007)(64756008)(76116006)(86362001)(6506007)(91956017)(2616005)(8676002)(186003)(6486002)(8936002)(26005)(54906003)(2906002)(478600001)(36756003)(316002)(33656002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?TlhoM2FEQTBaWnpCTlFrYTVMNnNMczdKTGZ6N1NKQUplVm9VV05VU0xtaDhz?= =?utf-8?B?QjQ2bVFnQmlKYUZGdVlmYzdqUlVaUWZlall1NFB4V1Fkc0lqYm0rdUduSkl2?= =?utf-8?B?TERUWkhyZ3RxZll4aFIyY2dnRmNPb09zb0JwUC80TitGZjV1YzJuOFFyMmpO?= =?utf-8?B?aDEydzI4MkxMdWVxUFM3elJlcXNOb096VDFUaFkrUnEyUFlocE90dGdhOUNi?= =?utf-8?B?eE5iVFZwOUwwUjZaVHIrUHVhZWFqa0ZSR0ZzcnN3emZyZzYwSXl0LzVhZDdI?= =?utf-8?B?NHdLMVNNUUlPVlRVWEEyNk1TVzVCUWZmdHlmbCs2SEgxY3p0VnFhNlFHS1NZ?= =?utf-8?B?QnlaQkdFWDROL0tnQXNSNk9vYThhOWJKdGRqYjFWVkxsUE12NXVNTS9WSGIw?= =?utf-8?B?bitHWU5ENEhMOEY0WmxVWmM3Wkx3YzNmeks5cHhOaktsTjF3aDI1QjNPVHRz?= =?utf-8?B?bjdwT04zMzRpcVFNbWQ4b3pnbWQ3NlFpQi9ybnVXLzhoT3lLa1BlMTg4bFlR?= =?utf-8?B?cTJMcGUwdlJaSDlMR1FDRWltVG1OUVBTM3hGWnJuTlgwK3pSQk1CTWZwSUdl?= =?utf-8?B?ZFdld0ZFODRwUVlHd1pBMmppT1IwazZ4RmsxekxXMmh3UlY5Wm9IMXl3UWV3?= =?utf-8?B?YnNCdUdLYk84b3BwRUpiaEpoczRLRVJGQ1NZcCsrWlBJM2MxbFVlZENGRGdx?= =?utf-8?B?UERwc3pGVFZCY2NycGhtVjl1TWh1TENkaHRMQ1dBeU9IcUZHc0JHT1FzaGVM?= =?utf-8?B?VGNRbG51L2pxQTc0S053aG5QaGVoeXcrRlN4TTNsZUUyYzkyR3BQbU9UUGp5?= =?utf-8?B?alVFSjE0QWpCTGJSL0EwSzVRK3RCVUtVbEM4WDRoTXN0NlFqL0l0dEZ0dk5R?= =?utf-8?B?ZkhKS0E4emZtWE5CbFlXWXlhenZyOUM3WWdTNldxcktLZEFlZ1J4L1JicnI2?= =?utf-8?B?WkF2SFFob2xDL1Z3Tm92UzNOcWNpUzZpZi8xQjkrZ0VOck1vTUVwanBDSGor?= =?utf-8?B?eTNiZlhoQXZRQ3JTaTFiSndMdDEyeWh3Y054VitZNkFHVlpKWlpudlcrM3VJ?= =?utf-8?B?c1dObFRQRVVMVnZaZUxycWdIRUphK2VtMlhyWGJoNHIvT0ZteVEydzRWc1Mz?= =?utf-8?B?MFZtZ1RQQ0dhTmZhaVJ6WEQ3T0h1UnNGb05YaTZOR2hLem5sWVVmeFJHRzdR?= =?utf-8?B?d3ZqRUV0MWVHT1E3MDdRMFlEWXozVXRVdjA4cmlCWkRHdS8rYWgrbmMvZUdQ?= =?utf-8?B?OG1IaWtQTzhZWHJpem5QdHB6K0gvSW9zbWNHWFBoUThZcGYrM3pGajFGeTdr?= =?utf-8?B?S214SE1rdk1DTVlrdjNRZStJd1d6THZjRlRBUHFJb041ZGhpUmJtWSt4cnRL?= =?utf-8?B?M1BxWktHRWFwQ3VPeW0rT21CTkU1a3RKWWJHWEovRUpSYzROZlh2VzRSZUxt?= =?utf-8?B?K08yb3plOUE5WmltbkVzZi81cWpFMEFyUGZxSlRweTdCL0M5NHl2OGZ5WGF3?= =?utf-8?B?S0lZRmhOY0w4ajJqOFNKSDAySjM0WWt0S3F4TDNSbjJFdkcwUHZPTHZJMjNn?= =?utf-8?B?N0VTQjBVeVdzL0NWMTl4TThXL1hYUDJPUGp5ajZvVStSdU5iWk44cVJYVFBa?= =?utf-8?B?Mjl1WWZNa08vZG1UNVY5RHJELzB1K2tyMUZhY1dKS0RIVFZic2tYREdsSlE1?= =?utf-8?B?V3E0RmZFak5EbkFyY0xyWEhWa1dsV2xNODJ5c2xPT0JGM2l4QW9hT3FKaytj?= =?utf-8?B?SGJ5L09sWCtuSisyS1FxaGl1bWcxdVVOR0l0RUxqUVlNdVh2QW1Qc1pMcVNX?= =?utf-8?B?N2JXamYvakt3N1F5eWIwQT09?= Content-Type: text/plain; charset="utf-8" Content-ID: <918A185FDC64A24DAB7FFD6070AB38C7@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 994ead64-15df-4f5f-6189-08d8dcbfd047 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2021 14:39:26.2973 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m58b0YYjaYiCc/NwlsOmpLKVEbbJ5jyG0SO6v6M/oV3umaZHPxUCW3d9EWXFfrn/D2/yTtbd8ashbyK7DCC77TTnCWN88pJ7GmBy9pIX+Tc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5718 X-OriginatorOrg: citrix.com DQoNCj4gT24gRmViIDI0LCAyMDIxLCBhdCAxMTozNyBQTSwgVm9sb2R5bXlyIEJhYmNodWsgPHZv bG9keW15cl9iYWJjaHVrQGVwYW0uY29tPiB3cm90ZToNCj4gDQo+IA0KPj4gSHlwZXJ2aXNvci92 aXJ0IHByb3BlcnRpZXMgYXJlIGRpZmZlcmVudCB0byBib3RoIGEga2VybmVsLW9ubHktUlRPUywg YW5kDQo+PiByZWd1bGFyIHVzZXNwYWNlLiAgVGhpcyB3YXMgd2h5IEkgZ2F2ZSB5b3Ugc29tZSBz cGVjaWZpYyBleHRyYSBzY2VuYXJpb3MNCj4+IHRvIGRvIGxhdGVuY3kgdGVzdGluZyB3aXRoLCBz byB5b3UgY291bGQgbWFrZSBhIGZhaXIgY29tcGFyaXNvbiBvZg0KPj4gImV4dHJhIG92ZXJoZWFk IGNhdXNlZCBieSBYZW4iIHNlcGFyYXRlIGZyb20gIm92ZXJoZWFkIGR1ZSB0bw0KPj4gZnVuZGFt ZW50YWwgZGVzaWduIGNvbnN0cmFpbnRzIG9mIHVzaW5nIHZpcnQiLg0KPiANCj4gSSBjYW4ndCBz ZWUgYW55IGZ1bmRhbWVudGFsIGNvbnN0cmFpbnRzIHRoZXJlLiBJIHNlZSBob3cgdmlydHVhbGl6 YXRpb24NCj4gYXJjaGl0ZWN0dXJlIGNhbiBpbmZsdWVuY2UgY29udGV4dCBzd2l0Y2ggdGltZTog aG93IG1hbnkgYWN0aW9ucyB5b3UNCj4gbmVlZCB0byBzd2l0Y2ggb25lIHZDUFUgdG8gYW5vdGhl ci4gSSBoYXZlIGluIG1pbmQgbG93IGxldmVsIHRoaW5ncw0KPiB0aGVyZTogcmVwcm9ncmFtIE1N VSB0byB1c2UgYW5vdGhlciBzZXQgb2YgdGFibGVzLCByZXByb2dyYW0geW91cg0KPiBpbnRlcnJ1 cHQgY29udHJvbGxlciwgdGltZXIsIGV0Yy4gT2YgY291cnNlLCB5b3UgY2FuJ3QgZ2V0IGxhdGVu Y3kgbG93ZXINCj4gdGhhdCBjb250ZXh0IHN3aXRjaCB0aW1lLiBUaGlzIGlzIHRoZSBvbmx5IGZ1 bmRhbWVudGFsIGNvbnN0cmFpbnQgSSBjYW4NCj4gc2VlLg0KDQpXZWxsIHN1cHBvc2UgeW91IGhh dmUgdHdvIGRvbWFpbnMsIEEgYW5kIEIsIGJvdGggb2Ygd2hpY2ggY29udHJvbCAgaGFyZHdhcmUg d2hpY2ggaGF2ZSBoYXJkIHJlYWwtdGltZSByZXF1aXJlbWVudHMuDQoNCkFuZCBzdXBwb3NlIHRo YXQgQSBoYXMganVzdCBzdGFydGVkIGhhbmRsaW5nIGhhbmRsaW5nIGEgbGF0ZW5jeS1zZW5zaXRp dmUgaW50ZXJydXB0LCB3aGVuIGEgbGF0ZW5jeS1zZW5zaXRpdmUgaW50ZXJydXB0IGNvbWVzIGlu IGZvciBCLiAgWW91IG1pZ2h0IHdlbGwgcHJlZW1wdCBBIGFuZCBsZXQgQiBydW4gZm9yIGEgZnVs bCB0aW1lc2xpY2UsIGNhdXNpbmcgQeKAmXMgaW50ZXJydXB0IGhhbmRsZXIgdG8gYmUgZGVsYXll ZCBieSBhIHNpZ25pZmljYW50IGFtb3VudC4NCg0KUHJldmVudGluZyB0aGF0IHNvcnQgb2YgdGhp bmcgd291bGQgYmUgYSBtdWNoIG1vcmUgdHJpY2t5IGlzc3VlIHRvIGdldCByaWdodC4NCg0KPj4g SWYgeW91IHdhbnQgdGltZWx5IGludGVycnVwdCBoYW5kbGluZywgeW91IGVpdGhlciBuZWVkIHRv IHBhcnRpdGlvbiB5b3VyDQo+PiB3b3JrbG9hZHMgYnkgdGhlIGxvbmctcnVubmluZy1uZXNzIG9m IHRoZWlyIGh5cGVyY2FsbHMsIG9yIG5vdCBoYXZlDQo+PiBsb25nLXJ1bm5pbmcgaHlwZXJjYWxs cy4NCj4gDQo+IC4uLiBvciBkbyBsb25nLXJ1bm5pbmcgdGFza3MgYXN5bmNocm9ub3VzbHkuIEkg YmVsaWV2ZSwgZm9yIG1vc3QNCj4gZG9tY3RscyBhbmQgc3lzY3RscyB0aGVyZSBpcyBubyBuZWVk IHRvIGhvbGQgY2FsbGluZyB2Q1BVIGluIGh5cGVydmlzb3INCj4gbW9kZSBhdCBhbGwuDQo+IA0K Pj4gSSByZW1haW4gdW5jb252aW5jZWQgdGhhdCBwcmVlbXB0aW9uIGlzIGFuIHNlbnNpYmxlIGZp eCB0byB0aGUgcHJvYmxlbQ0KPj4geW91J3JlIHRyeWluZyB0byBzb2x2ZS4NCj4gDQo+IFdlbGws IHRoaXMgaXMgdGhlIHB1cnBvc2Ugb2YgdGhpcyBsaXR0bGUgZXhwZXJpbWVudC4gSSB3YW50IHRv IGRpc2N1c3MNCj4gZGlmZmVyZW50IGFwcHJvYWNoZXMgYW5kIHRvIGVzdGltYXRlIGFtb3VudCBv ZiByZXF1aXJlZCBlZmZvcnRzLiBCeSB0aGUNCj4gd2F5LCBmcm9tIHg4NiBwb2ludCBvZiB2aWV3 LCBob3cgaGFyZCB0byBzd2l0Y2ggdkNQVSBjb250ZXh0IHdoaWxlIGl0IGlzDQo+IHJ1bm5pbmcg aW4gaHlwZXJ2aXNvciBtb2RlPw0KDQpJ4oCZbSBub3QgbmVjZXNzYXJpbHkgb3Bwb3NlZCB0byBp bnRyb2R1Y2luZyBwcmVlbXB0aW9uLCBidXQgdGhlIG1vcmUgd2UgYXNrIGFib3V0IHRoaW5ncywg dGhlIG1vcmUgY29tcGxleCB0aGluZ3MgYmVnaW4gdG8gbG9vay4gIFRoZSBpZGVhIG9mIGludHJv ZHVjaW5nIGFuIGFzeW5jIGZyYW1ld29yayB0byBkZWFsIHdpdGggbG9uZy1ydW5uaW5nIGh5cGVy Y2FsbHMgaXMgYSBodWdlIGVuZ2luZWVyaW5nIGFuZCBkZXNpZ24gZWZmb3J0LCBub3QganVzdCBm b3IgWGVuLCBidXQgZm9yIGFsbCBmdXR1cmUgY2FsbGVycyBvZiB0aGUgaW50ZXJmYWNlLg0KDQpU aGUgY2xhaW0gaW4gdGhlIGNvdmVyIGxldHRlciB3YXMgdGhhdCDigJxbc11vbWUgaHlwZXJjYWxs cyBjYW4gbm90IGJlIHByZWVtcHRlZCBhdCBhbGzigJ0uICBJIGxvb2tlZCBhdCB0aGUgcmVmZXJl bmNlLCBhbmQgaXQgbG9va3MgbGlrZSB5b3XigJlyZSByZWZlcnJpbmcgdG8gdGhpczoNCg0KIkkg YnJvb2RlZCBvdmVyIHdheXMgdG8gbWFrZSBbYWxsb2NfZG9taGVhcF9wYWdlcygpXSBwcmVlbXB0 aWJsZS4gQnV0IGl0IGlzIGEpIGxvY2F0ZWQgZGVlcCBpbiBjYWxsIGNoYWluIGFuZCBiKSB1c2Vk IG5vdCBvbmx5IGJ5IGh5cGVyY2FsbHMuIFNvIEkgY2FuJ3Qgc2VlIGFuIGVhc3kgd2F5IHRvIG1h a2UgaXQgcHJlZW1wdGlibGUuIg0KDQpMZXTigJlzIGFzc3VtZSBmb3IgdGhlIHNha2Ugb2YgYXJn dW1lbnQgdGhhdCBwcmV2ZW50aW5nIGRlbGF5cyBkdWUgdG8gYWxsb2NfZG9taGVhcF9wYWdlcygp IHdvdWxkIHJlcXVpcmUgc2lnbmlmaWNhbnQgcmVhcmNoaXRlY3Rpbmcgb2YgdGhlIGNvZGUuICBB bmQgbGV04oCZcyBldmVuIGFzc3VtZSB0aGF0IHRoZXJlIGFyZSAyLTMgb3RoZXIgc3VjaCBrbm90 dHkgaXNzdWVzIG1ha2luZyBmb3IgdW5hY2NlcHRhYmx5IGxvbmcgaHlwZXJjYWxscy4gIFdpbGwg aWRlbnRpZnlpbmcgYW5kIHRyYWNraW5nIGRvd24gdGhvc2UgaXNzdWVzIHJlYWxseSBiZSBtb3Jl IGVmZm9ydCB0aGFuIGludHJvZHVjaW5nIHByZWVtcHRpb24sIGludHJvZHVjaW5nIGFzeW5jIG9w ZXJhdGlvbnMsIGFuZCBhbGwgdGhlIG90aGVyIHRoaW5ncyB3ZeKAmXZlIGJlZW4gdGFsa2luZyBh Ym91dD8NCg0KT25lIHRoaW5nIHRoYXQgbWlnaHQgYmUgaW50ZXJlc3RpbmcgaXMgdG8gYWRkIHNv bWUgc29ydCBvZiBtZXRyaWNzIChkaXNhYmxlZCBpbiBLY29uZmlnIGJ5IGRlZmF1bHQpOyBlLmcu Og0KDQoxLiBPbiBlbnRyeSB0byBhIGh5cGVyY2FsbCwgdGFrZSBhIHRpbWVzdGFtcA0KDQoyLiBP biBldmVyeSBoeXBlcmNhbGxfcHJlZW1wdCgpIGNhbGwsIHRha2UgYW5vdGhlciB0aW1lc3RhbXAg YW5kIHNlZSBob3cgbXVjaCB0aW1lIGhhcyBwYXNzZWQgd2l0aG91dCBhIHByZWVtcHQsIGFuZCBy ZXNldCB0aGUgdGltZXN0YW1wIGNvdW50OyBhbHNvIGRvIGEgY2hlY2sgb24gZXhpdCBvZiB0aGUg aHlwZXJjYWxsDQoNCldlIGNvdWxkIHN0YXJ0IGJ5IHRyeWluZyB0byBkbyBzdGF0cyBhbmQgZmln dXJpbmcgb3V0IHdoaWNoIGh5cGVyY2FsbHMgZ28gdGhlIGxvbmdlc3Qgd2l0aG91dCBwcmVlbXB0 aW9uLCBhcyBhIHdheSB0byBndWlkZSB0aGUgb3B0aW1pemF0aW9uIGVmZm9ydHMuICBUaGVuIGFz IHdlIGdldCB0aGF0IG51bWJlciBkb3duLCB3ZSBjb3VsZCBhZGQgYW4gQVNTRVJUKClzIHRoYXQg dGhlIHRpbWUgaXMgbmV2ZXIgbG9uZ2VyIHRoYW4gYSBjZXJ0YWluIGFtb3VudCwgYW5kIGFkZCBy dW5zIGxpa2UgdGhhdCB0byBvc3N0ZXN0IHRvIG1ha2Ugc3VyZSB0aGVyZSBhcmUgbm8gcmVncmVz c2lvbnMgaW50cm9kdWNlZC4NCg0KSSBhZ3JlZSB0aGF0IGh5cGVyY2FsbCBjb250aW51YXRpb25z IGFyZSBjb21wbGV4OyBhbmQgeW914oCZcmUgcmlnaHQgdGhhdCB0aGUgZmFjdCB0aGF0IHRoZSBo eXBlcmNhbGwgY29udGludWF0aW9uIG1heSBuZXZlciBiZSBjYWxsZWQgbGltaXRzIHdoZXJlIHBy ZWVtcHRpb24gY2FuIGhhcHBlbi4gIEJ1dCBtYWtpbmcgdGhlIGVudGlyZSBoeXBlcnZpc29yIHBy ZWVtcHRpb24tZnJpZW5kbHkgaXMgYWxzbyBxdWl0ZSBjb21wbGV4IGluIGl0cyBvd24gd2F5OyBp dOKAmXMgbm90IGltbWVkaWF0ZWx5IG9idmlvdXMgdG8gbWUgZnJvbSB0aGlzIHRocmVhZCB0aGF0 IGh5cGVydmlzb3IgcHJlZW1wdGlvbiBpcyBsZXNzIGNvbXBsZXguDQoNCiAtR2Vvcmdl From xen-devel-bounces@lists.xenproject.org Mon Mar 01 14:48:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 14:48:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91562.172993 (Exim 4.92) (envelope-from ) id 1lGjq3-0006ry-KA; Mon, 01 Mar 2021 14:47:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91562.172993; Mon, 01 Mar 2021 14:47:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGjq3-0006rr-HE; Mon, 01 Mar 2021 14:47:59 +0000 Received: by outflank-mailman (input) for mailman id 91562; Mon, 01 Mar 2021 14:47:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGjq2-0006rc-9w for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 14:47:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGjq2-0001oK-97 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 14:47:58 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGjq2-0002Ud-5D for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 14:47:58 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGjpy-0004Y6-7q; Mon, 01 Mar 2021 14:47:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID: Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=M2WkUt006XUcXBS6ZdOOEsbGxq1SqeHeM11823JqgI8=; b=kFRgc5LrT+BP3gRzUXXbt3hJrw baC5bWRo0GuB8vdg+SLGBNPZrKPRyRNeYq5mIx2QMpHGddZW4hiGa13Z+sVGJ8oCc33hF2I14i2LM erQt4YNkEW7VD1S47UtLU7t2vwGWX4dMSc/tabgecGU9a+OGsPi1d41DC7c4Ph3uYQLg=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24636.65178.20011.678957@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 14:47:54 +0000 To: xen-announce@lists.xenproject.org CC: xen-devel@lists.xenproject.org, xen-users@lists.xenproject.org Subject: Xen 4.15 RC1 X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Xen 4.15 RC1 is now available. It is available from git: git clone https://xenbits.xenproject.org/git-http/xen.git -b 4.15.0-rc1 For your convenience a tarball is available: https://downloads.xenproject.org/release/xen/4.15.0-rc1/xen-4.15.0-rc1.tar.gz https://downloads.xenproject.org/release/xen/4.15.0-rc1/xen-4.15.0-rc1.tar.gz.sig Please send bug reports and test reports to xen-devel@lists.xenproject.org. When sending bug reports, please CC relevant maintainers and me (iwj@xenproject.org). We will have Xen Test Days from RC2 onwards. Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 15:14:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 15:14:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91728.173057 (Exim 4.92) (envelope-from ) id 1lGkFj-0002IU-1c; Mon, 01 Mar 2021 15:14:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91728.173057; Mon, 01 Mar 2021 15:14:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGkFi-0002IN-Uo; Mon, 01 Mar 2021 15:14:30 +0000 Received: by outflank-mailman (input) for mailman id 91728; Mon, 01 Mar 2021 15:14:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGkFh-0002II-5y for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 15:14:29 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 18885b9b-e16c-4da0-bfbc-d3cbd611aa4c; Mon, 01 Mar 2021 15:14:28 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6FDBEAF59; Mon, 1 Mar 2021 15:14:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18885b9b-e16c-4da0-bfbc-d3cbd611aa4c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614611667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PoO1/fDL0ExPzQjEi0DBvTkmnPW4j7s6jpqYlEpbTkA=; b=H8qm4FKnuLjH3uvoa1zCaPTq+x1SaPZbRtTDfYs5OT81E+49px3+NG4iqs4Be5l3TMpjlE KR7+iVHpie2HdAvr7grdoATSSR7S4v+Vf9zWAWDnRRvX5wAp0ZfghYgYWCKg8EjAdyS+GO 7XhbzZPSU9mXxVZYNcQpvMjbuM/JT30= Subject: Re: [PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1 To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , George Dunlap , Ian Jackson References: <1d8d5089-32a9-9c42-5949-8f9cd20f33e0@suse.com> From: Jan Beulich Message-ID: Date: Mon, 1 Mar 2021 16:14:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.03.2021 15:01, Roger Pau Monné wrote: > On Mon, Mar 01, 2021 at 09:31:07AM +0100, Jan Beulich wrote: >> In this case the compiler is recognizing that no valid array indexes >> remain (in x2apic_cluster()'s access to per_cpu(cpu_2_logical_apicid, >> ...)), but oddly enough isn't really consistent about the checking it >> does (see the code comment). > > I assume this is because of the underlying per_cpu access to > __per_cpu_offset using cpu as the index, in which case wouldn't it be > better to place the BUG_ON there? Not sure, to be honest. It seemed more logical to me to place it next to where the issue is. > Also I wonder why the accesses the same function does to the per_cpu > area before the modified chunk using this_cpu as index don't also > trigger such warnings. The compiler appears to be issuing the warning when it can prove that no legitimate index can make it to a respective use. in this case it means that is is if ( this_cpu == cpu ) continue; which makes it possible for the compiler to know that what gets past this would be an out of bounds access, since for NR_CPUS=1 both this_cpu and cpu can only validly both be zero. (This also plays into my choice of placement, because it is not x2apic_cluster() on its own which has this issue.) Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 01 15:58:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 15:58:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91756.173069 (Exim 4.92) (envelope-from ) id 1lGkva-0006E2-BC; Mon, 01 Mar 2021 15:57:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91756.173069; Mon, 01 Mar 2021 15:57:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGkva-0006Dv-7e; Mon, 01 Mar 2021 15:57:46 +0000 Received: by outflank-mailman (input) for mailman id 91756; Mon, 01 Mar 2021 15:57:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGkvY-0006Dq-Lr for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 15:57:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGkvY-0002y7-Hi for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 15:57:44 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGkvY-00005H-Eh for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 15:57:44 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGkvU-0004kk-TO; Mon, 01 Mar 2021 15:57:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=D6ber2Y4v3368Vq2zqGOCcZQ0X8vbXNk5rYjNgWHM7g=; b=moU0gcLGQakxbsDeGu7klJNbOR BRNLqyNA8O2H2GS0CJLLONBUo/ij2pBa/5XTD2bfs5hEzP5fYi2xEhGFBdl6Vs5EAu0+EtcT5ORsG g5uK5PXvW9rxW7PI/DjBRyEkI0wKoVTcY73SGM8P/h1qIDvoES4cdSb/qrille4VrNqk=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.3828.576373.217715@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 15:57:40 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Connor Davis , George Dunlap , Dario Faggioli Subject: Re: [PATCH 1/2][4.15?] sched: fix build when NR_CPUS == 1 In-Reply-To: <171d1da4-e87a-b154-5c63-a5627d4f93bc@suse.com> References: <171d1da4-e87a-b154-5c63-a5627d4f93bc@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH 1/2][4.15?] sched: fix build when NR_CPUS == 1"): > In this case the compiler is recognizing that no valid array indexes > remain, and hence e.g. reports: Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Mon Mar 01 16:03:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 16:03:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91764.173081 (Exim 4.92) (envelope-from ) id 1lGl10-0007k8-Va; Mon, 01 Mar 2021 16:03:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91764.173081; Mon, 01 Mar 2021 16:03:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGl10-0007k1-Sc; Mon, 01 Mar 2021 16:03:22 +0000 Received: by outflank-mailman (input) for mailman id 91764; Mon, 01 Mar 2021 16:03:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGl0z-0007jw-UB for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:03:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGl0z-0003c4-QV for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:03:21 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGl0z-0000fU-OM for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:03:21 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGl0v-0004lj-Li; Mon, 01 Mar 2021 16:03:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=ZxYWS+rnnb7blXjibjG9YU4SYx60p8jdQQGtcHnDqeQ=; b=Yy2H11I1wF603eb2Pxh7KPJFet NFTxZP9kUJ3c5KOu/b4S5DnXuzEnXwBS3Qsz/2XlH1sWhT7qRlaDsXlsXvp+ppPatwjnoPo4zJ8q7 QojSICsTdUZV3dIKwYVAOB694VBY11S+LyOWJ54EmEV+yWtqb4zLFvG1dz6/BOAbLWX8=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.4165.400955.400473@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 16:03:17 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , George Dunlap Subject: Re: [PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1 In-Reply-To: <1d8d5089-32a9-9c42-5949-8f9cd20f33e0@suse.com> References: <1d8d5089-32a9-9c42-5949-8f9cd20f33e0@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1"): > In this case the compiler is recognizing that no valid array indexes > remain (in x2apic_cluster()'s access to per_cpu(cpu_2_logical_apicid, > ...)), but oddly enough isn't really consistent about the checking it > does (see the code comment). ... > - if (this_cpu == cpu || x2apic_cluster(this_cpu) != x2apic_cluster(cpu)) > + if ( this_cpu == cpu ) > + continue; > + /* > + * Guard in particular against the compiler suspecting out-of-bounds > + * array accesses below when NR_CPUS=1 (oddly enough with gcc 10 it > + * is the 1st of these alone which actually helps, not the 2nd, nor > + * are both required together there). > + */ > + BUG_ON(this_cpu >= NR_CPUS); > + BUG_ON(cpu >= NR_CPUS); > + if ( x2apic_cluster(this_cpu) != x2apic_cluster(cpu) ) > continue; Is there some particular reason for not putting the BUG_ON before the if test ? That would avoid the refactoring. Of course putting it in next to the array indexing would address that too. Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 16:11:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 16:11:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91767.173093 (Exim 4.92) (envelope-from ) id 1lGl8q-0000Kk-Q3; Mon, 01 Mar 2021 16:11:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91767.173093; Mon, 01 Mar 2021 16:11:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGl8q-0000Kd-Mw; Mon, 01 Mar 2021 16:11:28 +0000 Received: by outflank-mailman (input) for mailman id 91767; Mon, 01 Mar 2021 16:11:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGl8p-0000KY-TI for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:11:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGl8p-0003jE-NA for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:11:27 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGl8p-0001Wv-Hh for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:11:27 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGl8m-0004nA-B1; Mon, 01 Mar 2021 16:11:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=rGta2sxNDj7OM2vE/hx8i1toDGEBo3TyFpIkweKSEeA=; b=WjeWpvq2m//S1J5LL+Gx2aI49P HuxxP8OvtYvt6Lz+xj2AxdcDeO3PAxgwcVRVJajgyrhcfpOU+c5dpQWdtMzffQ4gHnpVYe6gh5TbW LeLPtKYGAtpZqzCnnmKqdsFdQwgi41e2+K4c8I3xA9gFCOZASxiiiz+JRBCoMYzj2jrI=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.4652.84564.294199@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 16:11:24 +0000 To: Andrew Cooper Cc: Xen-devel , Doug Goldstein , Wei Liu Subject: Re: [PATCH 3/3] automation: Annotate that a 32bit libc is no longer a dependency In-Reply-To: <20210225203010.11378-4-andrew.cooper3@citrix.com> References: <20210225203010.11378-1-andrew.cooper3@citrix.com> <20210225203010.11378-4-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH 3/3] automation: Annotate that a 32bit libc is no longer a dependency"): > We can't drop the 32bit libc from the existing containers, because they are > used on older Xen branches as well. > > However, we can avoid the dependency being propagated into newer conainers > derived from our dockerfiles. > > No functional change. > > Signed-off-by: Andrew Cooper > --- > CC: Doug Goldstein > CC: Wei Liu > CC: Ian Jackson > > For 4.15. Documentation changes only Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Mon Mar 01 16:12:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 16:12:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91768.173105 (Exim 4.92) (envelope-from ) id 1lGl9X-0000R5-8S; Mon, 01 Mar 2021 16:12:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91768.173105; Mon, 01 Mar 2021 16:12:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGl9X-0000Qy-3i; Mon, 01 Mar 2021 16:12:11 +0000 Received: by outflank-mailman (input) for mailman id 91768; Mon, 01 Mar 2021 16:12:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGl9V-0000Qr-9f for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:12:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGl9V-0003lN-8t for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:12:09 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGl9V-0001bD-7e for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:12:09 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGl9S-0004nU-2p; Mon, 01 Mar 2021 16:12:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:To:Date: Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=W3370fIQGpW7ie29cqRDW7F4D27s3A36roKk5XpbwBg=; b=65YraLKsdJANDd/uPkIierFEIT tj93ciOFsLhzs+xw3XkNpXg9QbOX21C1bu5Lpc+9HfbDoYwopsjsbf9e/FU/Bcbz+OChDTI/ezYzZ EVvyKlrWxH4QcKI19en4Pznvz0c5vHZZupM1hG+T5bzDY9NE0k8QX2y+3TM/s7t3wpyo=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.4693.875561.826546@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 16:12:05 +0000 To: committers@xenproject.org, xen-devel@lists.xenproject.org Subject: Re: Commit moratorium for Xen 4.15.0-rc1 In-Reply-To: <24636.50438.204769.9038@mariner.uk.xensource.com> References: <24636.50438.204769.9038@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Ian Jackson writes ("Commit moratorium for Xen 4.15.0-rc1"): > I am going to be cutting this RC shortly. So please don't commit > anything now, even fixes which already have a release-ack. The moratorium is lifted. You may commit patches again. Note that the freeze is still in force: every change needs a release-ack. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 16:13:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 16:13:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91770.173117 (Exim 4.92) (envelope-from ) id 1lGlAm-0000Yo-Hk; Mon, 01 Mar 2021 16:13:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91770.173117; Mon, 01 Mar 2021 16:13:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlAm-0000Yh-Ek; Mon, 01 Mar 2021 16:13:28 +0000 Received: by outflank-mailman (input) for mailman id 91770; Mon, 01 Mar 2021 16:13:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlAk-0000Yb-Um for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:13:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlAk-0003ml-U0 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:13:26 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGlAk-0001fQ-T2 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:13:26 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGlAh-0004no-Kd; Mon, 01 Mar 2021 16:13:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=GAKFCH2OxcmAQyqGrVGrYsO3iFQuMNHTtj7p+hjdfyI=; b=hP9hHYGklTz28eDSx3d87M2mbi YvzIXi8p/hHUfEBbszaf6iwl0XdSo1qlkm66Ma7MATWJ/GiIib1abr6v/ejdFsVKEomFrYJ+zIwi5 yYpqBMROZo1rkAonCkS5uPdMSP1ZaLAPbsBkw0V9AfFQe+7HYNhOKvPEYSUCdyHMZOQo=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.4771.419064.686112@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 16:13:23 +0000 To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu Subject: [PATCH 2/3] tools/firmware: Build firmware as -ffreestanding In-Reply-To: <20210225203010.11378-3-andrew.cooper3@citrix.com> References: <20210225203010.11378-1-andrew.cooper3@citrix.com> <20210225203010.11378-3-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH 2/3] tools/firmware: Build firmware as -ffreestanding"): > firmware should always have been -ffreestanding, as it doesn't execute in the > host environment. > > inttypes.h isn't a freestanding header, but the 32bitbios_support.c only wants > the stdint.h types so switch to the more appropriate include. > > This removes the build time dependency on a 32bit libc just to compile the > hvmloader and friends. > > Update README and the TravisCI configuration. > For 4.15. Build tested in Travis (Ubuntu) and XenServer (CentOS) - no change > in the compiled HVMLoader binary. I'm currently rebuilding the containers > locally to check Arch, Debian and OpenSUSE, but don't anticipate any problems. Release-Acked-by: Ian Jackson Reviewed-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Mon Mar 01 16:14:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 16:14:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91774.173129 (Exim 4.92) (envelope-from ) id 1lGlBI-0000er-Qr; Mon, 01 Mar 2021 16:14:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91774.173129; Mon, 01 Mar 2021 16:14:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlBI-0000ej-Nl; Mon, 01 Mar 2021 16:14:00 +0000 Received: by outflank-mailman (input) for mailman id 91774; Mon, 01 Mar 2021 16:14:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlBI-0000ee-9w for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:14:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlBI-0003n8-8i for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:14:00 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGlBI-0001iM-7p for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:14:00 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGlBE-0004o6-VF; Mon, 01 Mar 2021 16:13:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=SvujKVnHxX+c+pmZGpFcUGlU7CNVNkeTfmMhkQE7tlY=; b=o927IR/gKZ3HoCU4mcIdL3DioD sQSfoDGfPkTElFn8rNOcRpMmy8966sV1wjzz/XYf11zFdQsTagZyjesFwHesRvr1FFMiLPozv/GyQ QGrByC9JTlZhD9+IvADwfJrZBtwhre8Hh3RPwTKS5Y+chcoaARdlXnkw9O2LxCq2z4JI=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.4804.738599.535374@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 16:13:56 +0000 To: Andrew Cooper Cc: Xen-devel , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH for-4.15] cirrus-ci: Drop obsolete dependency In-Reply-To: <20210226124647.19596-1-andrew.cooper3@citrix.com> References: <20210226124647.19596-1-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH for-4.15] cirrus-ci: Drop obsolete dependency"): > markdown as a dependency was dropped in 4.12 > > Fixes: 5d94433a66 ("cirrus-ci: introduce some basic FreeBSD testing") > Signed-off-by: Andrew Cooper Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Mon Mar 01 16:16:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 16:16:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91777.173141 (Exim 4.92) (envelope-from ) id 1lGlDy-0000qQ-A5; Mon, 01 Mar 2021 16:16:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91777.173141; Mon, 01 Mar 2021 16:16:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlDy-0000qJ-64; Mon, 01 Mar 2021 16:16:46 +0000 Received: by outflank-mailman (input) for mailman id 91777; Mon, 01 Mar 2021 16:16:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlDw-0000q6-NP for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:16:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlDw-0003pZ-Lq for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:16:44 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGlDw-0001zk-KY for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:16:44 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGlDt-0004p6-AM; Mon, 01 Mar 2021 16:16:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=WSrPqNTjWrbEMz+d1CfOT5/3mHfcOqB+xu01MU7CfFM=; b=5jG761t9swKf3kgFPcDhUuilmX F5KEBMIj3HHbq5kX9rhsaHMhkd/g1GG3Jhn+xaHCyh0HE6dvh5pORTmMJciLXTJ5S4/oMhfTmmCfc WMKUD03T+Fo3AQuXJ4GACYmdLM0ba+dsfem4CTeQjExq8eQaw8b9YvflbO1KSrcJrkuA=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.4969.80009.849868@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 16:16:41 +0000 To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu Subject: Re: [PATCH 1/3] tools/hvmloader: Drop machelf include as well In-Reply-To: <20210225203010.11378-2-andrew.cooper3@citrix.com> References: <20210225203010.11378-1-andrew.cooper3@citrix.com> <20210225203010.11378-2-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH 1/3] tools/hvmloader: Drop machelf include as well"): > The logic behind switching to elfstructs applies to sun builds as well. > > Fixes: 81b2b328a2 ("hvmloader: use Xen private header for elf structs") > Signed-off-by: Andrew Cooper I would have preferred this patch to come after the one that is actually justified for 4.15, so that it could be held off to after 4.15. After all I see no substantive reason why this should get a freeze exception. However, it looks fine based on code review and I don't want to add risk by asking you to transpose the two patches, so: Release-Acked-by: Ian Jackson Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 16:16:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 16:16:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91778.173153 (Exim 4.92) (envelope-from ) id 1lGlDz-0000rO-HQ; Mon, 01 Mar 2021 16:16:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91778.173153; Mon, 01 Mar 2021 16:16:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlDz-0000rH-E7; Mon, 01 Mar 2021 16:16:47 +0000 Received: by outflank-mailman (input) for mailman id 91778; Mon, 01 Mar 2021 16:16:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlDx-0000qE-QW for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:16:45 +0000 Received: from userp2120.oracle.com (unknown [156.151.31.85]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f9a8e350-1b54-4175-acb1-e84fb2ead0e6; Mon, 01 Mar 2021 16:16:44 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 121GFf1G104821; Mon, 1 Mar 2021 16:16:42 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 36yeqmveb7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 01 Mar 2021 16:16:42 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 121GEv2d037659; Mon, 1 Mar 2021 16:16:41 GMT Received: from nam04-bn3-obe.outbound.protection.outlook.com (mail-bn3nam04lp2055.outbound.protection.outlook.com [104.47.46.55]) by aserp3030.oracle.com with ESMTP id 36yynmxxrw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 01 Mar 2021 16:16:41 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BYAPR10MB3526.namprd10.prod.outlook.com (2603:10b6:a03:11c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.20; Mon, 1 Mar 2021 16:16:39 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3890.028; Mon, 1 Mar 2021 16:16:39 +0000 Received: from [192.168.1.104] (73.249.50.119) by BYAPR04CA0016.namprd04.prod.outlook.com (2603:10b6:a03:40::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.20 via Frontend Transport; Mon, 1 Mar 2021 16:16:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9a8e350-1b54-4175-acb1-e84fb2ead0e6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=eJLtvPdTzSz6fWxMQvTZRoSvMTzT7uQH+PWL/40YmZc=; b=ZFsz8O+dukBYjrP60ld86sAGCKa6LY6rOe0xtNp4pm1u42T7lTkCVQQkdVhJXo4OLp9C CXPrq7eUfZzrlvKpk9dpL5lM4edgoEGPXQfEfnHYqHAksAxhSU126oK5dETxLcABcYQw iS56Ww4PPMImRUAQCk9rh9EenUXeZSQm1fvIQ6y5Vl4NR0zERdmCb6tXC/rxHb6Z4w54 2JnJv4CrDBeYFEVs3q+6S9Ma00RH02uGO/sbU7z8VNQf5BjGO1BhxD/y+cZKCf3C2evw y/1vug1kJSEZ5quIbXKPB6wVpaFiBJx49osBPbqH0VIxpGXjyzYxWDGEhdd8KDTLnDwX /w== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oEzshJiZcOV33AGdbLjp8MnEeJ56Jis/t68tGhyLW0ALghTZGEz+l21IK1Z2v1nCKtuY7UwDClVnFWbWXzrVCczs/tHRMZFG/IQ11trw7z/7J27eGRYjpVz3fISpfiOMVxKmZVxRDzjQAFo53olm/vN/e4bWNUpjI8RABpcJqGuhc0K+ty1rx/vYzAoy17ZdXV40UyraQpg9YdFpjmW4v8Hw5IR/gVNpFIEQ34YjDAGGPOLs0jIQnwKLG2f8wT47wvnBktyWZrcyxoXyo5JI1md7FNIsUs2fPWpVPcb6X+0GXqkHNyN4jwT/iPO41tvVMRwt92cCG8EKbTeYhcQJ3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eJLtvPdTzSz6fWxMQvTZRoSvMTzT7uQH+PWL/40YmZc=; b=F2qGVkdqW8s2JcP+D/gOo5rGIXEhnhFj+yqFNK/ugMno1fQT7iB2yFNZcFfGG6W8dcovDNnAGRszcmZ3b0Q/H7N9eUzi7igHzNPur83l+50u3535Gvyib0f/ts+Z/G8zpvjaqMCMOu8Rn0qnlzdtn0F4QMoU5Vb9iu86Aofh8yrQbJuu05fByJ06PAmLFfURXzuJh8x2zBVafIcgCTKCipk8hGCqOf66j9EatU4yNxu7WXiHvXUymw/msMrDTbE6jAzno3oxGATP9r3ZcalARuzUhjAyTwg5ffbUHEihHzcbpcq5WVDdu8rgj6ZNVokjpGSDMJNwhdV0yES9Adn3xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eJLtvPdTzSz6fWxMQvTZRoSvMTzT7uQH+PWL/40YmZc=; b=inq4BtgnySmG75oTAf/GyCVclZhZbsum+IMRidugBF/KQuqrbOJbuys3dBS2ANpheeCpVVv0lZBK5J6MatCtLyqjd43R4ZeicUTXiZ5i7wLG/1cxCRMp0Jd3QBYVFxJhccHePF88TWh5fONNV7btnqjYZ4YSKlOnUM/Lzm1UnbM= Subject: Re: [PATCH v1] xen: ACPI: Get rid of ACPICA message printing To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Linux ACPI , LKML , Stefano Stabellini , Juergen Gross , xen-devel@lists.xenproject.org, Konrad Wilk References: <1709720.Zl72FGBfpD@kreacher> From: Boris Ostrovsky Message-ID: <7c313ae8-6f3a-1281-a88a-1393e54f26a1@oracle.com> Date: Mon, 1 Mar 2021 11:16:35 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [73.249.50.119] X-ClientProxiedBy: BYAPR04CA0016.namprd04.prod.outlook.com (2603:10b6:a03:40::29) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24553bd6-2f32-42bd-19eb-08d8dccd64e7 X-MS-TrafficTypeDiagnostic: BYAPR10MB3526: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gEsC8dA+FfjwXI7lIw3Mp9cUcAFpchjnb8UBzwc8wcVGEOOfITp7iWf9xbyKJ/ZYqs6XayYkBwR060tMHP1T3m4tCmKwKtic6kBDm0e+rI1xQapbPGcFGvNRn7cc4AUMqUpmas9s4D9SPQmNi4OtALFz9oAr8nDBShhmwBqsutIHYXFzXzUY2tAxv/6aSGKuvjhKMjVH4HSLAMuwHzKMhCbbxJuOVgSY13lVNVjgRxTkfthIb2QhhkAXaVBGskkwhEFeJH3nS6mG2pTOOQaXnYxp6YZdILnlU3qwZ77zRvYkN+m09QXekBRRN3v26tXCDwvCGMMbW92h6x7Trniv1NZa0vItTltVYrNXlZiysPob9fhSaklJPvddEHpBfu18bncjJPUWq7qE5flaglfLL0URG9g8eUxmkBMBWtthM4+6nJRfEz9MELqm8lWTyqS5F4mW57A5es6qDBaMQnmbBa1rnx0phQCkSmrMMc1d5WtfEpQYvW1nauLcyC3RNJrrDVPGtZIkPi6Ge2pozkfoADdXbgKQiVCbKpJXiLg0wxBPAHIR5auouc0jLlrdnYXz0FRHpU8z+A2pNBkf812ua4LHPv3KMRwxZt0kyuyxWDOCEntOa15U1TxSXZvY6koPt1GMRloEg6ydX35vOeK0Rg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(366004)(376002)(39860400002)(396003)(136003)(186003)(53546011)(4326008)(16576012)(107886003)(66946007)(66556008)(86362001)(66476007)(316002)(83380400001)(31696002)(478600001)(26005)(2906002)(16526019)(6916009)(5660300002)(15650500001)(8676002)(6486002)(36756003)(54906003)(956004)(44832011)(8936002)(31686004)(6666004)(2616005)(26583001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WE5wV2JORDNYajh5MVpCc0RBc1JCNzZZekk0TmJudlA4eUpNOWthb0w4WWlL?= =?utf-8?B?QVZpclMzSDd6dWFjVTdRaVlrcFA2dkVsRy9WY1p2YVdSNEtONHNqQ0dqUCtj?= =?utf-8?B?eGg3R01pMllZbVYrdWFqMUJsSFc3bU9tTzZZWG15VmVta1d0L3Y4SFQwTjRB?= =?utf-8?B?ZXFRbHFzR3lJRUpjUm96b05mbHBZREw0VGZ3L2xpVDBpVnNYd1VXMk9kT1RD?= =?utf-8?B?TDJXNy80RXVkZkxvVXFXajRGMzFyTHlTWWRtT01reDhlUmFMa09IZG1sdU10?= =?utf-8?B?S1c3WlFCL2pHd0tJTEJMdUhWT1NDT0I2WnJVbnJsQkJndUtjYkN6ZFpUY3Ar?= =?utf-8?B?SDl0R1k3UlU4d2J2SGlkUllRVHdIZVVwZ2NIN3BFSW9pS0MwSEJHbS9LRlBs?= =?utf-8?B?UERqREtwNDNMT2JCK0ptRitaWWdaT0lSV25CdEZEbEk1YXFTOGd1alFwbmI2?= =?utf-8?B?RTUwM3duQ3RXUkFkVnlXUkZWUnp4am1TTm5VVE1UeExnUG9BRGcrVC9veGxu?= =?utf-8?B?cnZDZVQ2OTFBS2tHL29LZVdqWUlsYmNJQ1dCM0lKMEx5cml5dEtuNWpOZ00y?= =?utf-8?B?WUJqc2NVNVFjYmhndUZnMFRIKzNzVXI3WWZjQWdQWURxbDlZSmYyVnlqOU8z?= =?utf-8?B?TzJ1Q3NDZjRUR2QxM3oyUFdMblVNMHNQdlljMzJkQWhrYjAzc2lreUV0ZWY4?= =?utf-8?B?cjZCMVNHTUp0b1NqQkJiVkUwSjVXblpRelRiQkc4N0RSUUxoRVdveVNNeWJv?= =?utf-8?B?MHNvYnVvRVhFL0pjRmdMakRDejgrOE5qK2w2enJVdHhUclg0Q3Y4d0RyQ0RL?= =?utf-8?B?QmJOd3lRdjFvcXdYMzFOcjRnZ3pyZm5ya2ZmZExPN0FxSFV3d1U5MWpVMzZl?= =?utf-8?B?d1FJQ0daZFZIaUFKbGtXd0dqL25uTmtPcWpGNlpBVTBuRitpaFZ3azlZaHNy?= =?utf-8?B?S2JuL2Q0clRZSnFLa3Q1bkJtZUIydUN3MmoycURXVzlNM3RieVRwS2JyR01N?= =?utf-8?B?SjNDbzhFdHpyUDVwZjQwckZKbkdmNHlRa3BsVEkvSjVEb3ZGVW54dzhaSHB4?= =?utf-8?B?cTVNRmh0SzlPQjkwM1lXd3Y1VHNwTDZqTDg3TTl2OFpybktNVk5yUUhjWFhm?= =?utf-8?B?Q2I0dFhtMVVsWjE3b0hYZXUwSGk3cEQvTFJyVitkbUlCMUFRUlVtT1ZRaFJV?= =?utf-8?B?K1lEa0RmWXRmczBiTlFhNFNJbFpxRHhhMXNhSi9oSW5IVDFCZkt6dG56ZlZN?= =?utf-8?B?ZWpBSlc1OUJzWGpHN0NTdVN1Z2hHL2VEdlZFMURXUm96M0pRUFpTalVKZXRo?= =?utf-8?B?UW5KRFdTR1gxckVOUTBMSVFXMHhUYzBSMjBHc2RreUFMdDRxWjlMUDRiVTFL?= =?utf-8?B?WkFkNWdGUWQ5aEtXR05BUzg1NUZQWHkvWHV1dk50VTJqdU8ySW0zVUJacmVF?= =?utf-8?B?MUpZQ2djZHR5NXhaWmFlTGZ4cVFvMkdLcmhLNFNVNDlmaWVOZXVDQ0o1V29r?= =?utf-8?B?L2x0enhScURKdGR3WWN0OVBDUDBRbXprOU54SGlNZkVDbU1NZU5PZHRyeGR1?= =?utf-8?B?MVp0SU1xdFZlVmowZVlTdEV5Q25tdEhScjE5Nnc3dHVGRGxkZFlVQzNqL1hi?= =?utf-8?B?TzZXWWphblN1NkttcTNjcGdWYnpGSy9xTmlBVnA4OEsrc2thaVlJMS9DZzFH?= =?utf-8?B?YkVFai9Uc2ZnUG5BejRlTjhZbi81clBxL0tVY2J0VHQ1TEIrTlZqWDRucUNt?= =?utf-8?Q?KTWfZdi64inM4kC0mS4dKQUn5LUnTo0PY9iLvFe?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24553bd6-2f32-42bd-19eb-08d8dccd64e7 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 16:16:39.4407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SBOTVokuHgyBLRJJx8HtIsnEkcpkXXiZLhIpZnAWv+xjTPPRDFgKnvMmbFFdSQHgeMGYyuWGvg7f7eSnG/xU9ZQfzqnvpOg1B6Bzp81mUBo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3526 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9910 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 spamscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103010134 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9910 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 clxscore=1011 priorityscore=1501 mlxlogscore=999 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0 adultscore=0 mlxscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103010134 On 3/1/21 9:11 AM, Rafael J. Wysocki wrote: > On Sun, Feb 28, 2021 at 2:49 AM Boris Ostrovsky > wrote: >> >> On 2/24/21 1:47 PM, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> The ACPI_DEBUG_PRINT() macro is used in a few places in >>> xen-acpi-cpuhotplug.c and xen-acpi-memhotplug.c for printing debug >>> messages, but that is questionable, because that macro belongs to >>> ACPICA and it should not be used elsewhere. In addition, >>> ACPI_DEBUG_PRINT() requires special enabling to allow it to actually >>> print the message and the _COMPONENT symbol generally needed for >>> that is not defined in any of the files in question. >>> >>> For this reason, replace all of the ACPI_DEBUG_PRINT() instances in >>> the Xen code with acpi_handle_debug() (with the additional benefit >>> that the source object can be identified more easily after this >>> change) and drop the ACPI_MODULE_NAME() definitions that are only >>> used by the ACPICA message printing macros from that code. >>> >>> Signed-off-by: Rafael J. Wysocki >>> --- >>> drivers/xen/xen-acpi-cpuhotplug.c | 12 +++++------- >>> drivers/xen/xen-acpi-memhotplug.c | 16 +++++++--------- >> >> As I was building with this patch I (re-)discovered that since 2013 it depends on BROKEN (commit 76fc253723add). Despite commit message there saying that it's a temporary patch it seems to me by now that it's more than that. >> >> >> And clearly noone tried to build these files since at least 2015 because memhotplug file doesn't compile due to commit cfafae940381207. >> >> >> While this is easily fixable the question is whether we want to keep these files. Obviously noone cares about this functionality. > Well, I would be for dropping them. > > Do you want me to send a patch to do that? Yes, if you don't mind (but let's give this a few days for people to have a chance to comment). -boris From xen-devel-bounces@lists.xenproject.org Mon Mar 01 16:24:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 16:24:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91784.173165 (Exim 4.92) (envelope-from ) id 1lGlLC-0001wj-CZ; Mon, 01 Mar 2021 16:24:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91784.173165; Mon, 01 Mar 2021 16:24:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlLC-0001wc-92; Mon, 01 Mar 2021 16:24:14 +0000 Received: by outflank-mailman (input) for mailman id 91784; Mon, 01 Mar 2021 16:24:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlLA-0001wX-3X for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:24:12 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 01187b4a-a34f-4b79-b5c9-d48aae380bfa; Mon, 01 Mar 2021 16:24:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01187b4a-a34f-4b79-b5c9-d48aae380bfa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614615850; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=L/P0mpMUUNghf52mTKN+x+sVATYe+KXYWa/zIU8uaTc=; b=gpWlSerNIoMbbKZzKtc+3acx+0yFDb5Lx/thE2OxNR/t9gi7zxgNz1TR uY4e0DtkiC5lH11rKXRMa5Dc+fFOBsnZmLu4e6rJAP7AGeewCcf+WiEhB YcjbXMHRZJpIc2+3qQ2l/0qdjjjI6SzPOt5HpQSB99ZJdXU6lw2j8NDmr E=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Ou4bAb5gwR8HbugNqZCY6L80s/5vZQlwYx17Si2ZQSabIhejkYZga+ZEBhFh0NflaS5SmM8j9G 2lbAG56dwWx1isNVAYvCOqgxt34d2dcovmsG6Il6ytVOHDQkQApsXx9iW5s9TB1tz4HMJpN84P rj0RvBV5itFLOFRDx38fB/vNMSARjXXE2n2VSLihJvdBnpMzR9+I4rX6whvxGbieUEor54IDHb lCuA1l84pnoC25vsNMsmV7tiiyUVFccs0miBMJhTWhrTz7X13Lt+fadp04eZLbKHen6uWsa8dO mUY= X-SBRS: 5.2 X-MesageID: 38624870 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38624870" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aHspOr2Qkgc2WBQfGMEwoPT4ns9/350mgNLmfQyR3dg+ZGMlhW8YLb9Bjx2+EWX90fYT/apq3pOofgWpXoDOtHYQDJQ4YRYVP+adUc6t3I69e+JJHhmdW8I2//r78V175apUFzOfB0JpgV4z2tqNOoyyJH+zBOqz6+XrrQJxTNJX57GrS3w83bxgYA0qhwESlurLpAhxR4eddKQb4MwCEozp0DXqPNxxuYkXX4SGi+3sjwLBticNdbALVNfDTvPGgP9wx93ZO6lnwEZikyLZxNoIRIUAjZoIdA8O0eg9THYHTe4BPFGIhfSSccPizSlLr4ozzNjzb8aA8cOX74CGKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9RC7mBTH8yFWH4JJP7/8eNT3uB9uzY9/brAacouFZM8=; b=WzckbRv7x8G/+qxRwigMEPqXyCyZWtdDvNlDClTSA/GObR/BwRZDHvuIfhXcQoHV90ZP1W/a1inBTukguIAAk3acUnzY5mKgI2Gl8IvIT8uy0uYGuB559LHA4bUL3Khzg0tfSH2tTfJ368BloVoMr4P6MTfadvxF+EDCbykGNdK8ggcyw4jcI1fHhD2n4g+Oem++hbZtOI6K3caPNCuwdt2XYpXV8YT11+QhI75gzW9X9gsHWK8Urcz+khgELmuY5quoP1/G0FPJ2lI4wVsQ+hb1Ei32zl3eIataYos0YGMF56PGjBK6CS0wa2seHrLxx9AJ1pY4RgKvIUNhSMBktA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9RC7mBTH8yFWH4JJP7/8eNT3uB9uzY9/brAacouFZM8=; b=CwbbPQP4AKfhpzAZIdypN+tK4EKTkdgnSN8TdozZUPPpEJmNEDOnp9uoidLcxBk8pFe3widwQFVZEFtzkbm+LBcrDpZPyX8dkOtBwdXIJlsaWqVwkMsSXE4/vBRFBfD6YHv4j3V0Fuj7qmB36p4OWP/FJE4QzXhc+Nt/6hx0dMw= From: Roger Pau Monne To: CC: Roger Pau Monne , Ian Jackson , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection Date: Mon, 1 Mar 2021 17:23:57 +0100 Message-ID: <20210301162357.76527-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0108.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::24) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c995f108-bcc2-4a84-021a-08d8dcce6d61 X-MS-TrafficTypeDiagnostic: DM6PR03MB4970: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E8T4vxK3lpeBmmO/3GGjN7DK+SmyVtJtt5F5fyxZ3gWdjbMGsa46XkUGGxteud0yQ4Sf2r9H0dq2HURiwxTk1omA0MgKb2jKzdef5WPrEMv1DKdaGzTrgzHOBDeRcWoOVerRzkXNVigXW8NkdyWtXhpZNuZ37mbVETsublYTlQDqRMknTA0mB4ENKSX1IjYqGGUC0c9z3Czh2uJoRDuSkzntxQpQBhm3EPv4ticN1U29StA4MfTGsubaPgX6eQOFZkBN8ncnET6TsfG0wWR4ErIyaS0/0uuDHjBSI0P7lWwBXK7u6A4eXA5ZGhEx2d9T6WyySiQ4szgbqLUGpQSW1ywz06QennRAbRkVC3rFfDqUdssnCAiMb/Ozku/OSRuoQusSQgRRKjA3U2HxtDhLaNZQzt8YUAa0LDedinCk4f4v60j6sLXgc0zoC0dqk1nyqgH3MlVLbis5SuoZILOriot1WkCFTOqTjAiKVjxaYCMyuVskG/XoLILcmvLzB3vqFH8aeYzBv2C9/32l//tvTg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(396003)(376002)(136003)(346002)(5660300002)(2616005)(36756003)(956004)(316002)(186003)(6496006)(4326008)(16526019)(26005)(83380400001)(8936002)(2906002)(6916009)(6666004)(66946007)(86362001)(478600001)(1076003)(54906003)(8676002)(66556008)(66476007)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?cVp4UWU0L0VtYW8wdjYxcXpkWmN6TEhESmVPS3RIM0tlODZuM1orMloya0t4?= =?utf-8?B?UFMrWnFVb0ZqcUtnWTNDOE9JcTN1MDV0WFg4cjlYRFdJVkpXek9Ic1JBRTBX?= =?utf-8?B?WFhuSSt0SS9oN2RLNWQ1ZmFLWDN5QW1iNXpXem94eFpqWTczZVJmMmtlNDBG?= =?utf-8?B?RFVmZ0ZQT0NqZjdHMjhsaFJIYlBsU2w0OElWVEVsQ29MbEFLVFB1OFhKd1lK?= =?utf-8?B?TENNWlY3RUVPNHpNVjBOcDZiUVVab2szVHdENnRtdzA3OGRoaDJNRndpa2t5?= =?utf-8?B?ZVQ5WktCS3pISVJWaDlwNjl2L3NxaExYV0hYbUhEYkpNbjduMmJMcEthdU4y?= =?utf-8?B?cU0yc0NUSGJQZlRxZmZvSlZWTGZNSUhjVDFxVTdZcmNMalhMT2RaTU1JeFd0?= =?utf-8?B?NjBaMDhjQzNiSG5XbmM5U1VYUXhrNWFPZXVKVkRROGNJdUZhbUEwRlJRYkVa?= =?utf-8?B?R1l0ZWJnallnL0IyaVZweVZaYWFmbzMzZG5UVjVMMHJEdXZobnVRV1RZNERF?= =?utf-8?B?MDA4V29jdlJ4YW9Bb3hvMi9sQ3krQ25aNlFaazgzdXVTM3k4MTNsSVh3NXRC?= =?utf-8?B?V05reG9GYlJnakx4TnA5c0NqRkFLa21BUm12TXpxOGxqNjRTdnFpaGROc0hH?= =?utf-8?B?aEZNOEw3TXJGVjcrTFlhS3RzaU15OU0wL05FUHVqU1FuYjQvWTZLY0tFTkVT?= =?utf-8?B?a2lQL1J0bkp6UE5UY3NjK0lYbWM4WDVML2N4MGpLeDE5dmw5Smt0Sk9IckZI?= =?utf-8?B?Vys2WTAvRVI1NnBrQ3hnS2VGMXBpSU93MVd1WTdLaTM3cm1UelZGK2NHOUtp?= =?utf-8?B?dll3M1doUHdpRzBSRk13blgwSWtOa3o3UFgydjdFWlFpNUxWY2w3dVZRS2Fh?= =?utf-8?B?NjhoQ24wMEhIZEhzNUJXWUdUam1vN3dKQW5yYW4yL2pMN0lxM216RFI1RUd3?= =?utf-8?B?cFd5K2RUdzF1cXhOYWVXTkw1R21qSkl4VnpKVVNRTGszUEo0QUtYOW1vbmlt?= =?utf-8?B?MGVsSjN0QVNPZ2VpdTNKTEt5MXdoYkpIVHJPUGNuL24wMnBKSCsyL29hb0hM?= =?utf-8?B?cnNXdGxNbHd0NVBjTjhETVBVSjgvZm1JY3pmb1E1Q3hlQ015VW85WDhoRUZt?= =?utf-8?B?MU9xUVEvdGFhMk5FSTBoVk1BbThlN0dhZEltUkdWcmd6Si84NVZkekovZUVn?= =?utf-8?B?ZWZBNzdTQVVBSGpmWTRRQU9UeFdYRXJicXNRbGhPaGM2OVYwWkZQdWxrVjBU?= =?utf-8?B?TWZEbW43eGhEWk9sWXA1S252ZDM3OU5pMUVVZzB2QmxVK0QzbUZUOGxHZVBo?= =?utf-8?B?ZU91SUh2V1g2M096cDc0czY0UTA5K1o4NENkeXhQQjhYbmlEUzVmcSswazdQ?= =?utf-8?B?bU1CTmRScmpUSGdvdE1qSE1JeWtsZTF4WFZQdVlyVVQydTlyWWNwL1Y1RHdJ?= =?utf-8?B?dm9aekpmTEFLZ08rdlhiRVovTjYyOTRBYWZKZmlBRGZHbDI5TDFmb0RIWENZ?= =?utf-8?B?OWlaSFBNZWRjcmUxcXY5L2pxRDduaDB1cnpleEdvT3dYa3I0RDVsOUk4cFd5?= =?utf-8?B?Sy8wZUlId0FlU1VYRUpCUFBzYmpubWFqeTk2d3cwbE5TK1Vqa1FrZzVsQlVa?= =?utf-8?B?NGg3SnYycCtsWCttcng2UGRwQ0xXeHFtM0lCQnF1SUxHSDhMWTQySWNacG54?= =?utf-8?B?cjZWTjREQ0U3VVhDaTZSclZlNEdKRzBOZGFXbU1FTkszWnllOTBMTStGQmdt?= =?utf-8?Q?3y7CVX+tw2EYfSJy4OkC57CbHt+nWbdXjPn+zVL?= X-MS-Exchange-CrossTenant-Network-Message-Id: c995f108-bcc2-4a84-021a-08d8dcce6d61 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 16:24:03.0766 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4duPEQ88rBz2JAxM9VaXSh6hBVIbSkUiTn7jQuj4te+kkEg58QUnRiLTLsCqCIKpQQ+WH7bJSl4qUZfaUyt09Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4970 X-OriginatorOrg: citrix.com Introduce an option to allow selecting the legacy behavior for accesses to MSRs not explicitly handled. Since commit 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly handled by Xen result in the injection of a #GP to the guest. This is a behavior change since previously a #GP was only injected if accessing the MSR on the real hardware will also trigger a #GP. This seems to be problematic for some guests, so introduce an option to fallback to this legacy behavior. The main difference between what was previously done is that the hardware MSR value is not leaked to the guests on reads. Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky --- Note that this option is not made available to dom0. I'm not sure whether it makes sense to do so, since anyone updating Xen to such newer version will also likely pair it with a newish kernel that doesn't require such workarounds. RFC because there's still some debate as to how we should solve the MSR issue, this is one possible way, but IMO we need to make a decision soon-ish because of the release timeline. Boris, could you please test with Solaris to see if this fixes the issue? --- docs/man/xl.cfg.5.pod.in | 11 +++++++++++ tools/include/libxl.h | 8 ++++++++ tools/libs/light/libxl_types.idl | 2 ++ tools/libs/light/libxl_x86.c | 5 +++++ tools/xl/xl_parse.c | 3 +++ xen/arch/x86/domain.c | 3 +++ xen/arch/x86/hvm/svm/svm.c | 9 +++++++++ xen/arch/x86/hvm/vmx/vmx.c | 11 +++++++++++ xen/arch/x86/pv/emul-priv-op.c | 10 ++++++++++ xen/include/asm-x86/domain.h | 3 +++ xen/include/public/arch-x86/xen.h | 3 +++ 11 files changed, 68 insertions(+) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 040374dcd6..78dadcdfdd 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -2861,6 +2861,17 @@ No MCA capabilities in above list are enabled. =back +=item B + +Select whether to use the legacy behaviour for accesses to MSRs not explicitly +handled by Xen instead of injecting a #GP to the guest. Such legacy access +mode will force Xen to replicate the behaviour from the hardware it's currently +running on in order to decide whether a #GP is injected to the guest. Note +that the guest is never allowed access to unhandled MSRs, this option only +changes whether a #GP might be injected or not. + +=back + =back =head1 SEE ALSO diff --git a/tools/include/libxl.h b/tools/include/libxl.h index a7b673e89d..3bf6aded97 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -495,6 +495,14 @@ */ #define LIBXL_HAVE_VMTRACE_BUF_KB 1 +/* + * LIBXL_HAVE_MSR_LEGACY_HANDLING indicates the toolstack has support for + * switching the MSR handling in the hypervisor to legacy mode, where #GP is + * only injected to guests for unhandled MSRs if accessing the MSR on the + * physical hardware also triggers a #GP. + */ +#define LIBXL_HAVE_MSR_LEGACY_HANDLING 1 + /* * libxl ABI compatibility * diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 5b85a7419f..5bb12bc70d 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -644,6 +644,8 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), ("vuart", libxl_vuart_type), ])), + ("arch_x86", Struct(None, [("msr_legacy_handling", libxl_defbool), + ])), # Alternate p2m is not bound to any architecture or guest type, as it is # supported by x86 HVM and ARM support is planned. ("altp2m", libxl_altp2m_mode), diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c index 58187ed760..4b2b5d69a6 100644 --- a/tools/libs/light/libxl_x86.c +++ b/tools/libs/light/libxl_x86.c @@ -19,6 +19,10 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, abort(); } + config->arch.domain_flags = 0; + if (libxl_defbool_val(d_config->b_info.arch_x86.msr_legacy_handling)) + config->arch.domain_flags |= XEN_X86_LEGACY_MSR_HANDLING; + return 0; } @@ -809,6 +813,7 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc, libxl_domain_build_info *b_info) { libxl_defbool_setdefault(&b_info->acpi, true); + libxl_defbool_setdefault(&b_info->arch_x86.msr_legacy_handling, false); } int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 1893cfc086..fc79b6cc83 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2741,6 +2741,9 @@ skip_usbdev: xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat", &c_info->xend_suspend_evtchn_compat, 0); + xlu_cfg_get_defbool(config, "msr_legacy_handling", + &b_info->arch_x86.msr_legacy_handling, 0); + xlu_cfg_destroy(config); } diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 6c7ee25f3b..28805d50b8 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -852,6 +852,9 @@ int arch_domain_create(struct domain *d, domain_cpu_policy_changed(d); + d->arch.msr_legacy_handling = config->arch.domain_flags & + XEN_X86_LEGACY_MSR_HANDLING; + return 0; fail: diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index b819897a4a..b535c5927a 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -1795,6 +1795,7 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) const struct domain *d = v->domain; struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; const struct nestedsvm *nsvm = &vcpu_nestedsvm(v); + uint64_t tmp; switch ( msr ) { @@ -1965,6 +1966,11 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) break; default: + if ( d->arch.msr_legacy_handling && !rdmsr_safe(msr, tmp) ) + { + *msr_content = 0; + break; + } gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", msr); goto gpf; } @@ -2151,6 +2157,9 @@ static int svm_msr_write_intercept(unsigned int msr, uint64_t msr_content) break; default: + if ( d->arch.msr_legacy_handling && !rdmsr_safe(msr, msr_content) ) + break; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", msr, msr_content); diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index faba95d057..7707ae8cbc 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3114,6 +3114,7 @@ static int is_last_branch_msr(u32 ecx) static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content) { struct vcpu *curr = current; + uint64_t tmp; HVM_DBG_LOG(DBG_LEVEL_MSR, "ecx=%#x", msr); @@ -3195,6 +3196,12 @@ static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content) break; } + if ( curr->domain->arch.msr_legacy_handling && !rdmsr_safe(msr, tmp) ) + { + *msr_content = 0; + break; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", msr); goto gp_fault; } @@ -3497,6 +3504,10 @@ static int vmx_msr_write_intercept(unsigned int msr, uint64_t msr_content) is_last_branch_msr(msr) ) break; + if ( v->domain->arch.msr_legacy_handling && + !rdmsr_safe(msr, msr_content) ) + break; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", msr, msr_content); diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c index e5a22b9347..ecf98c4a05 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -875,6 +875,7 @@ static int read_msr(unsigned int reg, uint64_t *val, const struct domain *currd = curr->domain; const struct cpuid_policy *cp = currd->arch.cpuid; bool vpmu_msr = false; + uint64_t tmp; int ret; if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) @@ -986,6 +987,12 @@ static int read_msr(unsigned int reg, uint64_t *val, } /* fall through */ default: + if ( currd->arch.msr_legacy_handling && !rdmsr_safe(reg, tmp) ) + { + *val = 0; + return X86EMUL_OKAY; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); break; @@ -1148,6 +1155,9 @@ static int write_msr(unsigned int reg, uint64_t val, } /* fall through */ default: + if ( currd->arch.msr_legacy_handling && !rdmsr_safe(reg, val) ) + return X86EMUL_OKAY; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", reg, val); diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h index 3900d7b48b..213557fc2c 100644 --- a/xen/include/asm-x86/domain.h +++ b/xen/include/asm-x86/domain.h @@ -437,6 +437,9 @@ struct arch_domain /* Mem_access emulation control */ bool_t mem_access_emulate_each_rep; + /* Legacy handling of MSR accesses. */ + bool msr_legacy_handling; + /* Emulated devices enabled bitmap. */ uint32_t emulation_flags; } __cacheline_aligned; diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h index 629cb2ba40..0a6b40bb89 100644 --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -304,6 +304,9 @@ struct xen_arch_domainconfig { XEN_X86_EMU_PIT | XEN_X86_EMU_USE_PIRQ |\ XEN_X86_EMU_VPCI) uint32_t emulation_flags; + +#define XEN_X86_LEGACY_MSR_HANDLING (1u << 0) + uint32_t domain_flags; }; /* Location of online VCPU bitmap. */ -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 16:26:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 16:26:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91787.173176 (Exim 4.92) (envelope-from ) id 1lGlNh-00027M-Vg; Mon, 01 Mar 2021 16:26:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91787.173176; Mon, 01 Mar 2021 16:26:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlNh-00027F-Rb; Mon, 01 Mar 2021 16:26:49 +0000 Received: by outflank-mailman (input) for mailman id 91787; Mon, 01 Mar 2021 16:26:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlNh-00027A-6U for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:26:49 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 29a7500d-690f-46ef-b0bb-b8f1b6a6aed0; Mon, 01 Mar 2021 16:26:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29a7500d-690f-46ef-b0bb-b8f1b6a6aed0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614616007; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=sQBsmoyaJPX0GelAMgQC7RBiGk65h0W2uJ5xFsBdwzM=; b=bn7i23AGhEMhCwORlh12/lzxFxyWmyioD3dnyBx5ePTN1sz3UyuR18hs e6LGs65YiTVPJ/vHpIwaGLweNTvocHw2z1yEfxNUg29uTf9zDNZJAPr// jpT+TXstuYNujYYtZLjONNSXtEf9SfQwhBER6VS+1/Ky4Ndf2rLXHwLbR I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: a5vYofSjpJ5Kr8pJyeXZLGME0Aah/w/McgYx82Qqw2XJYPbyEq5UvpBADRj49I1oJcuvxT85RQ pR/xNyD2+rNssyJO5oOTUZcH1fO74DS5npngQe/NgsgdHyMyIjSZr1nyyCDbFt0fXM591udQcA 8YnyPv3clOtPUItOsbooEJwh/wDj9BNlgyXABGXOgy86QSi0zMPdcIcxVOrbgOKmAZmu4jbZD/ Ll1ql8Cqm99mPDuReDCfOA27kIcGVg7cJVBAyymP77HPQ8htuYX9118BqdSTujWsXqOtTBfoUZ 9/A= X-SBRS: 5.2 X-MesageID: 38446660 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38446660" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k5ly2dDnpkZS+Xi0HwkPWdEs6N+j+9Yjs6Z/AsprvXgLaSoVcUYp2ARGDuVuSprg51RBip9hIIw7fyoZwnltCzKz7b9rDNwEKl01XqtApLdji278sz9oJodnw2OQI1/4c+u57Sa9aCTak3grKDVAez5Ykv2kgTYapATrw4jsHvnrnVcQXVxhOKaarpJ7TXg2X5Ylm+68/dhvqB4Q3oxpHBjG9cH0Kjvo3MOPlDDY3GuZaBosZpCPeNlZ75dEz5B5+v8yym8/7ydv3Eipb2xMf7sWKJvUVgYn7n+Sy4HrFJjWU4aAgif63mCDCYvPDZZiwjjv0ZdhowEq8XJjidpeyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=munAJo8p+PPZUKRMAFwJ9Q9tctpNjFJNpa9dCymRVNM=; b=XQGit4wfJMWRyzr40OKE2jzkuaWRXQhX4maEHJrjlbubzxGYnEJt4AP3640fcGBe4nqJcPzguCi1f5ANsluHgVwsVb6zF/tkN9WXrcTobsRcdKH5Vlmds/l8RBTg8TYf/C5xke8vbvf09qfRBkQjmxxC0GaA5hu21clED+ECoVrDYtc1R9DW6/As/bd9jeSVJnCaQ6ls7HRsOzSI37EWEYFhkpxkD3uI8NvaR5ealDc0Ao0TI7R9owZpWwIH76NRh2Z7XTDs1GqOFOZTWODt/6gNU+5Pb4wPWJSPHGoKNn2xt/V87nDijsjnS4A8ZrlKFcspMjLVeHXVgAAEiByCkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=munAJo8p+PPZUKRMAFwJ9Q9tctpNjFJNpa9dCymRVNM=; b=VpGiYvRzetxgEpB+dllWK+dENzFtCuktQDw+MrpYfVz5GN3dV8MOyMxJDsiUUSeobZFCJZLYLj8GuP1CwIO385vSzQrhzHS5/q0ko44PmrKX2uANIa/O2MZZDJy+IHwSaq5qvoW3e0bA4xgtCUO443P955P1K4R9WGlfaSXpn9k= Subject: Re: [PATCH 1/3] tools/hvmloader: Drop machelf include as well To: Ian Jackson CC: Xen-devel , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20210225203010.11378-1-andrew.cooper3@citrix.com> <20210225203010.11378-2-andrew.cooper3@citrix.com> <24637.4969.80009.849868@mariner.uk.xensource.com> From: Andrew Cooper Message-ID: <7ff076d2-3e73-4326-1bc8-ed5efd37c937@citrix.com> Date: Mon, 1 Mar 2021 16:26:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <24637.4969.80009.849868@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0033.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ce33a691-8d5c-4d5d-76f3-08d8dccecb18 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5584: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RPAkh4OkF/hGFDmfSYZz4QbHhWUK70EWCRCuUEDTUsIeokgidk8Md32GpUveIlIItvsSWhIevHxJid8YiGGupj77pF0wLpShysk2W++FD89U2qzDoQVpi0OxiqAGdXGvLGFuErnMDLGy4ZkckxUHjb+FAW2f+7Wzylpq0wh9NnUr6Fl3P9ZDfWBNo0OWa+HM33d4EEU4XyrhpPRGCm6Yzqo0AZQbB8UuIOHRSTmDE2Ib9uwJx582GkDiaDOfvhWiHPk73WSuXI+h8lV35wNvuT04ev5m76s/vqJ/7WQyV2GpKaFH4zl5lnPPa6c762uNcYuMVe01h2HuHS8SPnOQ3YnOLkuVNhbEmLEOY53H0DvJk2iTFSRonByqhEVZng06VXwBd9PK2WHraM84G8EIFY1G84862S5hwWEK40pEkpwVkhJBrBnQrKCVx6xPGZM25vOqANZGaFn5X8pSWlO+SM/hYAJ/uktDpDCgDGjzeuvuyhe/gXnkmgsHkTSJH/T762wlFsa8SNcvcny15EWCWndNhAxM5eA/h3TnQEoH1kRCLS96Wg38NcPtl2gwpM8yLa8pAxRKe86sYZLGxHxOP/JXkjoPk79okf3LQL0m4zY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(366004)(136003)(39860400002)(376002)(31696002)(2616005)(956004)(316002)(8936002)(6916009)(6486002)(54906003)(86362001)(8676002)(16576012)(2906002)(83380400001)(31686004)(4744005)(5660300002)(478600001)(16526019)(26005)(186003)(53546011)(66476007)(6666004)(66556008)(66946007)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?T1NCcll4MjlCcnhoYXRCWkFqREZWUTNnL21XbmdXbjNpR2NaeGxkRVRFZGhI?= =?utf-8?B?V3ZQb1hQVDlqK3owRE5udy8ySk5LYndUdmY1MEtGUEhpaXdzVUVCWUlXNE03?= =?utf-8?B?QlB1MFVLMUZ2a1RkV0xoZW11NkoybjdQbndTQ2cwV3hodjdGQzNNNXpWdU9y?= =?utf-8?B?WENCZjNNZDRic1VoNjRwRWFjMXE1aWhFUFFSQjN2YVBWTEMwVURwOTBsSFZ3?= =?utf-8?B?Q2RBOGsxZkdGUGVqbVdpeFRNaHIxVm1HK1kwUURWUGZxdDYzcDVaa3RmRUIw?= =?utf-8?B?dnJucTBQMEI2NDFaQTByYXVwL0M5QXhzajgxeWxCOFdqZGlxc2pGTzVtRWdF?= =?utf-8?B?bzExSXdTcyt0V1g5TVBqNUUzSk81WG1ndm52ZFRWSFFnMWM5V0l2bFdURmZ6?= =?utf-8?B?d0xBMHVLY05QTTgyby84aE5Bb3pETVE1ek8yVjBleWpySjNUbFNWaTUrekM4?= =?utf-8?B?Vmd6ZDFUanVSYlp5dzJQMStXeEoxWnBoVVY5YmZwMGRDSkxkY1hxTFVieDNj?= =?utf-8?B?c2NPZXBiRTBHT2hWTmpuNGRYN1ZqSElwS3RPZzd5SXZUVDVlczZpTjc3eUE4?= =?utf-8?B?amFOTTBXcm0wMndqK0FxYjVKa2k0YWhoRmVWamtEZ3JtVFVqMFdTRUh0cGdN?= =?utf-8?B?cVplTXFmbExiU1kyYjdLWVg0bTFIcmJmR3NmemwrbEFHS0JhMlhualRVWVJH?= =?utf-8?B?Q0FXVWU3WVBtSmZaNHBrZC9aZ1ZETCtUMXNGVUswaGFUWEVqRjhIOEFNUENr?= =?utf-8?B?WW5wTmUxZFV1K0tlaXlQUzB0ek52aklsV0JnMXFDMnBxV1ZZQWowMWw2YXZU?= =?utf-8?B?Z3cxZTBoTlZibEtzQUhCa2FPR0JzZ2dJd0RQclhXWkpyQzhubjZmbFBzVFBs?= =?utf-8?B?VVhVdHJha0I2SUdMZDhmL1QrYjAvVnIramVZQkpLTFE1VWprTG9rcUN2Z0h4?= =?utf-8?B?NTdZSUlVQVFGblN6UkFGZUMwRXQzQXoveWdwMUVNY3doZVFOMmExOFZZM0dr?= =?utf-8?B?OEhSRHJkMS82bUpnbG9xeTIvNVlhdFpkZitPd3NqSU1oWWVWbFBmSThBUEpH?= =?utf-8?B?U0M1cDMwR0R2eDhuMzAweXBNTjJDbnJZOHVjY2FCYUoxcng2akF6ako3UTZt?= =?utf-8?B?UGJRQzNvc28xWm9JOGU1Z1pmK1dZQ25uc2o3dlpSSjVFMmo2MmZNeStnZ3Br?= =?utf-8?B?TnpINlZENFJFY1dpYkduNFkrL3pwTGxJNHY0OU44bkE4RmFKMjF5RS9NWnpL?= =?utf-8?B?UVo1cGhWNWQwU3k1MTZPRyszRWlEZWtSSFZpNG5EbFNRNm5GTVlFNnU4UGZm?= =?utf-8?B?NXUvNk9qazliOHk4RWhVcnN2QXUvVW1FYkxxM1grU1NRSk1Ic0VXYTFuQWdi?= =?utf-8?B?MGJoMW1QUThVbjBHRkh0RHJyeU9XVUF5TjR5Z0R1TUVlYUcxR0V1YUVvVmVQ?= =?utf-8?B?WnNWb08welhWUGI4WU1HYkppc29RT1plU2lUdWgxT2dkcnZKQ0V3aE83NEUy?= =?utf-8?B?VFQvK2dzQ2hnbEpKSXdIY3hSaWYwRk40QUZRUFBLWnpQRFdtQTJjZ2hvV3Vx?= =?utf-8?B?MEZNc2Y2azJ4YUx1M0VPbzBZcXljNmdaWnBUK3BwcGdNVDFPT3VjNlJiMXhq?= =?utf-8?B?dE4rUlFXWlViS3V3TWlTMVdUaG5JSHFub2RrNm0zc05ZaUxpTmVoblBFcUE5?= =?utf-8?B?REFrSlV6azNJMVA2N0lwWWk1NmUvekRJY2F6OGxMWEpnelcyMjFCN1dXUjJW?= =?utf-8?Q?L5EooSdYqbo7ik6h/BvlOMoBNDDD7JaFT9M6ae4?= X-MS-Exchange-CrossTenant-Network-Message-Id: ce33a691-8d5c-4d5d-76f3-08d8dccecb18 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 16:26:40.3476 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jT33Ytd5vjUkg6ZGiwyTbzf8VU9JSJZrFjzEaYfPG00K8FN39F7Di+zS45Dj32xbc1FBICCCvY9Nq7TbDmnNIzVcvCn97etNVHoHZExF7L4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5584 X-OriginatorOrg: citrix.com On 01/03/2021 16:16, Ian Jackson wrote: > Andrew Cooper writes ("[PATCH 1/3] tools/hvmloader: Drop machelf include as well"): >> The logic behind switching to elfstructs applies to sun builds as well. >> >> Fixes: 81b2b328a2 ("hvmloader: use Xen private header for elf structs") >> Signed-off-by: Andrew Cooper > I would have preferred this patch to come after the one that is > actually justified for 4.15, so that it could be held off to after > 4.15. After all I see no substantive reason why this should get a > freeze exception. It is a bugfix to a very recent patch which already already got a release ack. If this doesn't get an ack, then 81b2b328a2 should be reverted.  (Except obviously that would be a bad move.) > > However, it looks fine based on code review and I don't want to add > risk by asking you to transpose the two patches, so: > > Release-Acked-by: Ian Jackson Thanks. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 01 16:29:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 16:29:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91792.173189 (Exim 4.92) (envelope-from ) id 1lGlQ2-0002H5-D7; Mon, 01 Mar 2021 16:29:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91792.173189; Mon, 01 Mar 2021 16:29:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlQ2-0002Gy-9w; Mon, 01 Mar 2021 16:29:14 +0000 Received: by outflank-mailman (input) for mailman id 91792; Mon, 01 Mar 2021 16:29:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlQ1-0002Gt-IW for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 16:29:13 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 10cc2fcf-02eb-44d4-9ce0-99221349d863; Mon, 01 Mar 2021 16:29:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10cc2fcf-02eb-44d4-9ce0-99221349d863 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614616152; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=LykhiyzEKqzLpE/Bxub2iXflwNxjV0ISzXDM2pVTuzE=; b=Gq9uAf8ESvF8XAA7iJ6a2ZySBvuvs68IWj8mXD0x/utTlqF5MEtH7ugg g72jSHYX1TxQeQRvCDU9iOW8R91cVJqhbnH/97sjBlqYew2TeZbzZtC0Q zPF8vyJNC6QfxoTfSFSQHtyq/di/1e+2bVSz0mhVWoe7W+0G1dcNkcqoZ 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: MCQYJ/UTQuK2kgZYQtECQ+F/ki4deWRNPfH4ue+HdmHcHUvJBfs1JNivtwQ3Ysj/rd5FP3FFc0 bwf1IvmqXeSimDHkV1lN581KcsqfH/0EwJl9vYHORko1TxUaXpV4lVQ/iruCqltTP3Sy9pJc3G 77ZLEUaDDQ0A8na89uppfCBkkfy7rN7unHe9VgmQWM3lkMiWMwTSCeLelGMe9W/FblhTAR/nbU sXF09G5Ssdkf7B1acxeLsjZ4JIugB85W6+DT/R9dw+HcGn+xND5I6iyHvexIlqc7xzm+Xgd/Ze 7+U= X-SBRS: 5.2 X-MesageID: 38251893 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38251893" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kvuWfI1t8fo24AGQN2t+2DOuPDHN/Lx1toO/+lWs83CUy9b5OjZ96FBsIN4vVanBl9peNBbo6X18U9ztERVEW5pw35ZIsV8XBnIQBCMeB6Z0THr/LpecfU0cRkEgaWb2fUEmvMBqEUEwupiWdgFcWqrST3LlvwU0stHB4bEYfrYT4numr4H1tGeh5jL6GRTbQMgi2A5cg5P50/0HcIUHe4O0CVyrB2Fayrwo1a30HTWyzgi1qTFy5qeAb32YO7LehTiuP1tw2QqyWXsZydhX1FAKNQhimgGIVwiiIXGkxBTPTRXkAq0S26XND8BlaQio0p2JRcTWUaBaUQZJsbiO9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=22T9Ps9M+0+8OeV/vYT2CpzRp/Jj31Q2DFynmGyUkmo=; b=hsPb4V6bBihmYtK55fHsESQLdRVPc/FMjR5he5Kpio4KUQkrY5bXy8OLHzqDfE2ihDxbcA2p/ZbEEhVCiZa5o3s/R+piLIklILyPUC4s1tMJZrxPULxYbfQKrtQi1GJ5iDyE6hlHkjw6e79QyTKqYnSfC+EjW1lrSvRNbuP/9Q8EdKY+F7789ylrJ3WjkNspHqREMX0YkacgX9P0dZhox0cR9WWLktePTkmoIeUC9IWwHwa8H2NbAR/QwcWmdWikIrNVALMBfNsEpggAY2JhyukW0+LDnpFJG+aRKVimJlXFiRH4xZKC4YKvWoN0U1KH3suqkQdAPq39zv1b55TA+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=22T9Ps9M+0+8OeV/vYT2CpzRp/Jj31Q2DFynmGyUkmo=; b=FOzRHwJJlf1xflhZ6v+VbiOGLczCbfwqWRarA5NxNNGD5IKuRoM4BMqqLbZdwI2u90f3DBIX+IM60OsAItCZLupMoq00jAQHB+7m0cNx6p5EFxNxwVU0io27ir0kVzcXrzpagwbZI5ZWT6gJ5kRu/wPQXGL9OEI8aI4SyewgFr0= Date: Mon, 1 Mar 2021 17:29:03 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Xen-devel , Ian Jackson Subject: Re: [PATCH for-4.15] cirrus-ci: Drop obsolete dependency Message-ID: References: <20210226124647.19596-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210226124647.19596-1-andrew.cooper3@citrix.com> X-ClientProxiedBy: MR2P264CA0070.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:31::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 97fbaf75-b6cb-4d05-09a7-08d8dccf22e5 X-MS-TrafficTypeDiagnostic: DM6PR03MB3676: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2n1v8D4uL9qyBsaDiIqaUSpOg/LGbpJbbUG7sI+rFAWEe46A5SfBAHZy2koLCjdvpKCiHCcoRoKveI0LUfumJjU4+ZcwHdf807Wo/LS2AJ/fyCkJPiYBlMsv8OCHtYZyEzZD/45kRcMCIpCKgvpGH2I9Li7r6un1Z46z1yIl8ioiiRPuWOmX9noHcyNY6VBOmQItFiRrXq2PcOMA4mFNpXExUmQMs4OcXVHvQ9tZaUm8nYCglnwqKrrz1gpmCppaavfFe+PtKbOAWH9E0Dhxe1qj3rEKlUiNeEFo5i/ja11lX40fgnjh022b1oKbI+FIf8XDVrc9Ui2TkQTV090CNmmrxpBYMxiQ5Ilz/+g0+MeC7V2I3tA+xHhHBuyXNUjnQ7xHJKoBBIh6DvKcd1PN/S7yANFqD0nXcd30z3BVc8TK4kpI7TfpCOhEwu7DEHJ55Ga8DKD8djytXfbCm9kAW6aMBy9rTUQzBZ7tNj04zFloKzfnpOmLMEXq9+Vpo7BdfMrnQ25nepJfiiyMQtGWgQpM28b3i/miLYNn5p0yIvT+CG5SFBIwMgYfp7e9oCRb X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(346002)(366004)(39860400002)(376002)(136003)(396003)(83380400001)(186003)(956004)(4744005)(6636002)(26005)(66946007)(6862004)(16526019)(5660300002)(8936002)(8676002)(4326008)(6666004)(85182001)(6496006)(6486002)(66556008)(54906003)(2906002)(316002)(9686003)(86362001)(478600001)(33716001)(66476007)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aFh5Y1VvQ1JiRXh1ZWRVTUNWZDZEemp1cXY1YkdFN1lOaW81cGV2YWtzOWYr?= =?utf-8?B?TkxRL2c5UHRXVjZOYzZqbS8xUVBWeFJ4OUFaRXNJVVNpNTRWTDVxeHZFcTFZ?= =?utf-8?B?TEtWSy9IdENNS1BCQTJKNzhGRWUvTUszL0JJMlVzTTRaSHViS1huNzM2NjlH?= =?utf-8?B?YWQrVGtwdTNVdUh0Nzh6c3FQVjc2SGRwaHd6SFhhamFwYkM1dnVzaGl6bjdp?= =?utf-8?B?Q2ZPdXRveURxQkF4OWt6bElnSFoyWm5WSG9hdEdjdFA3TXlLVHZGaWUycnNa?= =?utf-8?B?NWx4NUlTTzFFMkFFME12czNoOUhvSldCOStqQTN3WldZOTM3N3AwRFozZmxF?= =?utf-8?B?Tm1qbFY4VlNaMG1ZVlJveFF3Y2lQTXRpdlJEdm8yb3ErMzVRVEZFaEcwaDc0?= =?utf-8?B?MnFWWDdDWjBkOVUwM00wOEkrcStRTkoyR2ZDM1JXQWRESG5WcTZzOHlTMUkv?= =?utf-8?B?clZBaU00emRuYy9pc0NCM2g1OTBMemNxU3hJNXFxSDRJSGYvVFdDc2RMUFRG?= =?utf-8?B?ZEpPY2lZaUJ6ZU9LUnMrK1ZRWXA2cHhNelA3VGkwT21TQ0p3dGx6cVhpNy9T?= =?utf-8?B?emc5T3dsbHdaNEhVYTdEc3MvSC8zSDhaZU1rZ3Q4eGsvMFVVT0p3TWRZZlps?= =?utf-8?B?THVRTUltd3V0VW9qU21lR0VQZzB0LzlPTDZBL2tqdU9vbjZvWUl4MEw5Qmpi?= =?utf-8?B?VGd1MDE5YWdmVlJXK09NUk1ycjVnYWYzMnBBS2pXNkFmcGw3NWI4Qk0xYzVY?= =?utf-8?B?ZXhoWU5KaXdBcFhEOU1SYmlMbzdLSGNYTk15Nkg4VG5RTGh4RVd1aExXQVNh?= =?utf-8?B?eHkwQWEvWU92L1B0ZFF1V1lZcGdESVhaRVY0Y1l2Vkt0UDFRVmQydVd1cGhB?= =?utf-8?B?Y1d4MzBYVTV3WEpwTUxmdnBuVFFlWCtYMXNJUnNJbzhraUZrZHAyakhvS212?= =?utf-8?B?d1IxZ2pDdTJlcllKckJRL3oyS3dUZERnRlJKTUUvVWNGY0sxWE41UlUwQ1ZL?= =?utf-8?B?YW50R2Z0ckNMZDNPVXFDaThOczRWeFl6ZWZvd2lrREtSWkZiZ2ltd1lCQzFF?= =?utf-8?B?Zm1vOUVBKzNsRGtuUGFVWVNkZ1BXTWQzdnBZREppelRwRzc0cVFJYWp5M09t?= =?utf-8?B?eEMxVStmdFF0c2I0NCtRVmdoMDh6ZXVqZ1Fzd0QvTDdRTFV6SSs2MHpvU0VR?= =?utf-8?B?c3gvdVc4TDZnbVJUQzVXY0JWNEtVK1BjY0VqZ0NOZWJiajBIVWRnTFhrc3Ez?= =?utf-8?B?cHlaR21kaUdKZEtaMW9RejA3bG9zZjM0WjV0eE9vNjIrSVJPekFoa3pCOVZo?= =?utf-8?B?a1JpVHVqenRyeGF2NnZtaTVKdWV2K2xkbEdTZVU0WGJsTDJOVmpacUhXR1Jy?= =?utf-8?B?ZVZ3THNJc0c0WTJBTXgrQTNqc0pyMk9IZThScWZNOFo4dElzNUJ1SFBDcEFl?= =?utf-8?B?TU9PTXNucjNFajBEaWNtaEFvNXBKcHV5U1JVSlFZZmxYaVBGUmZ5UWhGdnJ2?= =?utf-8?B?NFdNc2hPRTYyN05NTytWZmE3RUxiMzRpd0hCRGc0MDZuQVVUb2tmNXo5SEJ4?= =?utf-8?B?eWY0a1RMRzhmT2o1TWl1NGpGaUpmSFF3MFA0TWQ4VVY2ejZxYWlxQ2t0RkFR?= =?utf-8?B?byt1OFRpS3BYRzV4bDVKUng1c2VsQVNiSUlyL2R0cGNaM3JOSzIzYWhMbC9R?= =?utf-8?B?VlA2YkNMZ2hPMGtEWGJFTTF6c3IwSytoWEJycFlPMmp4RFJOUklDMndaYjNZ?= =?utf-8?B?a1UyK2VsQ250RHpPdVY5ckZTMkIvckhlNEp0SU1ZMVNLellTTGt4OFRjN2dQ?= =?utf-8?B?SkNicEJnaDJXbHZycS9RZz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 97fbaf75-b6cb-4d05-09a7-08d8dccf22e5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 16:29:07.5806 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZC+69EP5Q5FfnB1iyrNvaVmhU/7clJxl75M6WtoD7iDFK/jDvP87o10FB591HUwtTaNBkOOXqsfEYKpDktPrVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3676 X-OriginatorOrg: citrix.com On Fri, Feb 26, 2021 at 12:46:47PM +0000, Andrew Cooper wrote: > markdown as a dependency was dropped in 4.12 > > Fixes: 5d94433a66 ("cirrus-ci: introduce some basic FreeBSD testing") > Signed-off-by: Andrew Cooper Urg, I should update my list of dependencies. Reviewed-by: Roger Pau Monné Will add the required ones for the docs build in a separate patch. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:01:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:01:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91801.173206 (Exim 4.92) (envelope-from ) id 1lGluy-00062u-03; Mon, 01 Mar 2021 17:01:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91801.173206; Mon, 01 Mar 2021 17:01:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlux-00062n-TK; Mon, 01 Mar 2021 17:01:11 +0000 Received: by outflank-mailman (input) for mailman id 91801; Mon, 01 Mar 2021 17:01:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGluw-00062i-Cv for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:01:10 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3960c46e-8c32-4cd4-a32d-4ec41a0b4b2c; Mon, 01 Mar 2021 17:01:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3960c46e-8c32-4cd4-a32d-4ec41a0b4b2c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614618069; h=from:to:cc:subject:date:message-id:mime-version; bh=lYtMvIpYuWI/bvPALsefbxZrve6XvUtyOc1OkhsXeKg=; b=Cg8XhYgjgLBiWYdw+bjyhr+6mW22l0gkFk2h2hlH5331b8IPiAicxDEk 61t8dEIJH/SmD1wlG724cbR1j5XIblDSd560QhV1L/kUwTMrXiDQoUOaI VRVgw0wpP4EkDsQym3HpuMNevbTPMzDorXyMuHSTFoCfRhdywnfPvnDfN k=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: OFHdRIWBO7xTwzDntzzH7kxZiPIJm/4GyA1W4Dq7McWKYuhTdbJmfvdHLNM+THmcgBOBuG7KAH iaXZ2T7LuMbMcJr9xelccqNMquhMbPbhPMO2f58hDSNLbEqsdDBoLEvqNBDz/pt0SCVROaE1Rg KPQ+seFKrWE977gSpiEOA8SQMrFXIVMtzlGD+uF0KKue8tJKH3XAE0YggUluO8nlB//rmvlJhv Gog7AsXGiVLov41e89lTiq9w7jZcEcHunD0JU+biAUNY2VjutO138CoKb70pOYZmP62mgCijU6 JgM= X-SBRS: 5.2 X-MesageID: 39657544 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="39657544" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall , Juergen Gross Subject: [PATCH for-4.15 0/3] tools: ABI checking Date: Mon, 1 Mar 2021 17:00:41 +0000 Message-ID: <20210301170044.23295-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain Support in-tree ABI checking for stable libs. This series highlights a regression from 4.14, which needs fixing before the 3rd patch can be committed. abi-compliance-checker reports: Removed Symbols 3 xentoolcore_internal.h xentoolcore__deregister_active_handle ( Xentoolcore__Active_Handle* ah ) xentoolcore__register_active_handle ( Xentoolcore__Active_Handle* ah ) xentoolcore__restrict_by_dup2_null ( int fd ) Another RFC question - this only applies to x86_64 at the moment. For other architectures, we'd need to commit other ABI files. Andrew Cooper (3): tools: Check for abi-compliance-checker in ./configure tools/libs: Stash the 4.14 API/ABIs for the stable libraries tools/libs: Check ABI # DO NOT APPLY YET config/Tools.mk.in | 1 + tools/configure | 41 + tools/configure.ac | 1 + tools/libs/.gitignore | 2 + tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump | 924 +++++++++++ .../abi/libxendevicemodel.so.1.3-x86_64-abi.dump | 1491 +++++++++++++++++ tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump | 719 ++++++++ .../abi/libxenforeignmemory.so.1.3-x86_64-abi.dump | 847 ++++++++++ tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump | 1199 ++++++++++++++ tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump | 597 +++++++ .../libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump | 1711 ++++++++++++++++++++ .../libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump | 239 +++ .../libs/abi/libxentoollog.so.1.0-x86_64-abi.dump | 882 ++++++++++ tools/libs/call/Makefile | 2 + tools/libs/devicemodel/Makefile | 2 + tools/libs/evtchn/Makefile | 2 + tools/libs/foreignmemory/Makefile | 2 + tools/libs/gnttab/Makefile | 2 + tools/libs/hypfs/Makefile | 2 + tools/libs/libs.mk | 15 +- tools/libs/store/Makefile | 2 + tools/libs/toolcore/Makefile | 2 + tools/libs/toollog/Makefile | 2 + 23 files changed, 8683 insertions(+), 4 deletions(-) create mode 100644 tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump create mode 100644 tools/libs/abi/libxendevicemodel.so.1.3-x86_64-abi.dump create mode 100644 tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump create mode 100644 tools/libs/abi/libxenforeignmemory.so.1.3-x86_64-abi.dump create mode 100644 tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump create mode 100644 tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump create mode 100644 tools/libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump create mode 100644 tools/libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump create mode 100644 tools/libs/abi/libxentoollog.so.1.0-x86_64-abi.dump -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:01:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:01:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91802.173219 (Exim 4.92) (envelope-from ) id 1lGlv3-00065s-8C; Mon, 01 Mar 2021 17:01:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91802.173219; Mon, 01 Mar 2021 17:01:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlv3-00065l-56; Mon, 01 Mar 2021 17:01:17 +0000 Received: by outflank-mailman (input) for mailman id 91802; Mon, 01 Mar 2021 17:01:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlv1-00062i-Be for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:01:15 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 50051d20-5e5d-4b78-8405-480cb8369e0c; Mon, 01 Mar 2021 17:01:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50051d20-5e5d-4b78-8405-480cb8369e0c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614618070; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=X0/GB4CAinlU2bd2Nnz46CPqRoIoBMMDymVSzGexTAk=; b=d3kL2qWvT9eBr6HU+n7I1jrSSvpalLvXPQk8mHy7YGqqgPbsa/ObzCjJ 3+J4LT8/8H1ZX/s8mRK6zgTl+tQnmXWyWPu72yU6eKqhrXKNdcJJ328xs Bpl2rEM8q89tUInt8xQbeGZENmgCfTgNqKsXMOrp462fY/8EvuNI5oJUC 0=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: zAgcpBW/a8KTBJBGF7NGVISZB9r478yOLjt6pAwcTD1q0IR4gVQ4oIZ1DTmHvm7XWIcQ/P5EJ6 BKpJRMwINT6IOfksguSm4K16ZhHh09j90uFfnZISXOhbPQIHTls5JnQe/EE3BrJyUtuLn89z6o 5PonzNhOLWqar48+CWZ5bkbu7WutWSLqzfX2iZNFf2vS8Uen8iktpl8gBha46TvmauY6faBymI WQ6q1oFsgXqwDxeEdYRybA3xFarK9VDlBida+pYfkt6q7gTsDEFSfcaS7mo3wyHL9wwe6A/fjp f1M= X-SBRS: 5.2 X-MesageID: 39657548 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="39657548" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Ian Jackson , Wei Liu Subject: [PATCH 1/3] tools: Check for abi-compliance-checker in ./configure Date: Mon, 1 Mar 2021 17:00:42 +0000 Message-ID: <20210301170044.23295-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210301170044.23295-1-andrew.cooper3@citrix.com> References: <20210301170044.23295-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain This will be optional. No functional change Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu --- config/Tools.mk.in | 1 + tools/configure | 41 +++++++++++++++++++++++++++++++++++++++++ tools/configure.ac | 1 + 3 files changed, 43 insertions(+) diff --git a/config/Tools.mk.in b/config/Tools.mk.in index d47936686b..8e2268da3e 100644 --- a/config/Tools.mk.in +++ b/config/Tools.mk.in @@ -20,6 +20,7 @@ IASL := @IASL@ AWK := @AWK@ FETCHER := @FETCHER@ ABI_DUMPER := @ABI_DUMPER@ +ABI_COMPLIANCE_CHECKER := @ABI_COMPLIANCE_CHECKER@ # Extra folder for libs/includes PREPEND_INCLUDES := @PREPEND_INCLUDES@ diff --git a/tools/configure b/tools/configure index bb5acf9d43..f77bf6f66d 100755 --- a/tools/configure +++ b/tools/configure @@ -682,6 +682,7 @@ OCAMLOPT OCAMLLIB OCAMLVERSION OCAMLC +ABI_COMPLIANCE_CHECKER ABI_DUMPER INSTALL_DATA INSTALL_SCRIPT @@ -5483,6 +5484,46 @@ $as_echo "no" >&6; } fi +# Extract the first word of "abi-compliance-checker", so it can be a program name with args. +set dummy abi-compliance-checker; ac_word=$2 +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 +$as_echo_n "checking for $ac_word... " >&6; } +if ${ac_cv_path_ABI_COMPLIANCE_CHECKER+:} false; then : + $as_echo_n "(cached) " >&6 +else + case $ABI_COMPLIANCE_CHECKER in + [\\/]* | ?:[\\/]*) + ac_cv_path_ABI_COMPLIANCE_CHECKER="$ABI_COMPLIANCE_CHECKER" # Let the user override the test with a path. + ;; + *) + as_save_IFS=$IFS; IFS=$PATH_SEPARATOR +for as_dir in $PATH +do + IFS=$as_save_IFS + test -z "$as_dir" && as_dir=. + for ac_exec_ext in '' $ac_executable_extensions; do + if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then + ac_cv_path_ABI_COMPLIANCE_CHECKER="$as_dir/$ac_word$ac_exec_ext" + $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5 + break 2 + fi +done + done +IFS=$as_save_IFS + + ;; +esac +fi +ABI_COMPLIANCE_CHECKER=$ac_cv_path_ABI_COMPLIANCE_CHECKER +if test -n "$ABI_COMPLIANCE_CHECKER"; then + { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ABI_COMPLIANCE_CHECKER" >&5 +$as_echo "$ABI_COMPLIANCE_CHECKER" >&6; } +else + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 +$as_echo "no" >&6; } +fi + + # Extract the first word of "perl", so it can be a program name with args. set dummy perl; ac_word=$2 { $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 diff --git a/tools/configure.ac b/tools/configure.ac index 636e7077be..d84f2edcdc 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -311,6 +311,7 @@ AC_PROG_MAKE_SET AC_PROG_INSTALL AC_PATH_PROG([FLEX], [flex]) AC_PATH_PROG([ABI_DUMPER], [abi-dumper]) +AC_PATH_PROG([ABI_COMPLIANCE_CHECKER], [abi-compliance-checker]) AX_PATH_PROG_OR_FAIL([PERL], [perl]) AX_PATH_PROG_OR_FAIL([AWK], [awk]) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:01:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:01:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91805.173230 (Exim 4.92) (envelope-from ) id 1lGlv7-00069K-Rd; Mon, 01 Mar 2021 17:01:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91805.173230; Mon, 01 Mar 2021 17:01:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlv7-00069C-OA; Mon, 01 Mar 2021 17:01:21 +0000 Received: by outflank-mailman (input) for mailman id 91805; Mon, 01 Mar 2021 17:01:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlv6-00062i-Bv for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:01:20 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2756f48d-8e71-41c6-9676-8669975f102a; Mon, 01 Mar 2021 17:01:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2756f48d-8e71-41c6-9676-8669975f102a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614618073; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=FjUnGPVEAyWud86DM21udaJ75FfBw2ymxYDma8YblGY=; b=Gk1B5LmGOsbeKAVMilN6Cjwy2dNGND2l2eRU8SVwyaFOKKGkFIl5wykU 36y0RwDwqkyVq/g3/9ovzyvMsUUK20y7VSxUG5GH0cl4w2GjWGyzJhNBk hGjfe7pMDec83xX1AGNqn+O7c/du9ep6OfR0SiE1hlH6q5+xEFOQR9XUF w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: k1jckH8qiAXyMvWlee/mBx99CGcwRw0gaUEDd8Drr9NkOz39+Nw/7Jyxtf1EMdLhpGyCvusVMA kGiW2XYgvp4D1cJaBC8v41TrFPJmxEZ/gNH4h7Ge1q4ZIacV+XZqJDxX2eAZxYxigEx1UKeVvD QyYgR6Ydn5cCvVUjXXkFrUGAfmIpPoEYgY1Khdsx69Hg9C9WSj0Jpaj8O+/KMeYOl7RFayXPM+ tAidUuS1aKD2fKCg4X8MVHUvZ7qtwFC0wjeECE29TKu79npVl9G0jipyxwAZkv3644hHZR8BzQ OWM= X-SBRS: 5.2 X-MesageID: 38182446 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38182446" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH 3/3] tools/libs: Check ABI # DO NOT APPLY YET Date: Mon, 1 Mar 2021 17:00:44 +0000 Message-ID: <20210301170044.23295-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210301170044.23295-1-andrew.cooper3@citrix.com> References: <20210301170044.23295-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Juergen Gross --- tools/libs/.gitignore | 2 ++ tools/libs/libs.mk | 15 +++++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/tools/libs/.gitignore b/tools/libs/.gitignore index 4a13126144..655f46a6e8 100644 --- a/tools/libs/.gitignore +++ b/tools/libs/.gitignore @@ -1 +1,3 @@ +*/abi.chk +*/compat_reports/ */headers.lst diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk index a68cec244c..c12e779e63 100644 --- a/tools/libs/libs.mk +++ b/tools/libs/libs.mk @@ -96,12 +96,19 @@ lib$(LIB_FILE_NAME).so.$(MAJOR): lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxen$(LIBNAME).map $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,lib$(LIB_FILE_NAME).so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDUSELIBS) $(APPEND_LDFLAGS) -# If abi-dumper is available, write out the ABI analysis -ifneq ($(ABI_DUMPER),) -libs: $(PKG_ABI) $(PKG_ABI): lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) headers.lst $(ABI_DUMPER) $< -o $@ -public-headers headers.lst -lver $(MAJOR).$(MINOR) + +abi.chk: $(PKG_OLD_ABI) $(PKG_ABI) + $(ABI_COMPLIANCE_CHECKER) -l lib$(LIB_FILE_NAME) -old $(PKG_OLD_ABI) -new $(PKG_ABI) + touch $@ + +ifneq ($(ABI_COMPLIANCE_CHECKER),) +ifeq ($(debug_symbols),y) +libs: abi.chk endif +endif + .PHONY: install install: build @@ -131,7 +138,7 @@ TAGS: clean: rm -rf *.rpm $(LIB) *~ $(DEPS_RM) $(LIB_OBJS) $(PIC_OBJS) rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR) - rm -f headers.chk headers.lst + rm -f headers.chk headers.lst abi.chk rm -f $(PKG_CONFIG) rm -f _paths.h -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:02:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:02:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91803.173243 (Exim 4.92) (envelope-from ) id 1lGlwI-0006Mk-9t; Mon, 01 Mar 2021 17:02:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91803.173243; Mon, 01 Mar 2021 17:02:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlwI-0006Mc-5H; Mon, 01 Mar 2021 17:02:34 +0000 Received: by outflank-mailman (input) for mailman id 91803; Mon, 01 Mar 2021 17:01:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGlv3-00066A-F5 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:01:17 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9325cab7-4829-4722-86cd-4cea12367b9f; Mon, 01 Mar 2021 17:01:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9325cab7-4829-4722-86cd-4cea12367b9f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614618075; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=LgJyYPhmenBkPDcAThn79TvCAA3+QdlNK24z5O6FXqg=; b=W8C6cSOx7DwcJJXCMtwhIaKzpO01RhuSF2sGecVF1osTzhCtcpUnHJ5R aDarw2ag7kzuAKSC8Zdc24+jjla0srxXTZ7qLmz1CLE7drroALxMXEL5O 1qZ15dL+OP5NuG+wJxKLMpGohYEOL6HqTZriEjzGdKvoMApccmBjJ32Zq I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: qkN4It76dLBPp7Kw6/R5/uXC42dU5kCco1ClHTF9DE4dYebLuKebVWX5l/IFr0A0OIwLvq7Zfn ivVref4xJ8IEsMm1JyA2ddiN/4H3ZV8Xxqcbk3+oNBc+HYxYtwIQUiAiS7qfpRD/ntn0WlqAiI z7FTkWKgRRcDj8pruxCR2oqPARFLtVx8P0kvwpknPyKF4tBveCg6ksMlMCKaG9L+DA1jExKQou OH8DvdTqPkKAiqXHxdb35jka+siRTVa+xGBZNE4hPezCMcZiArJ7jtPqSrF9s8U2z8THg7h9kM prQ= X-SBRS: 5.2 X-MesageID: 38450122 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38450122" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH 2/3] tools/libs: Stash the 4.14 API/ABIs for the stable libraries Date: Mon, 1 Mar 2021 17:00:43 +0000 Message-ID: <20210301170044.23295-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210301170044.23295-1-andrew.cooper3@citrix.com> References: <20210301170044.23295-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain These dumps were produced from the RELEASE-4.14.0 tag, with the abi-dumper tooling backported from staging. For each stable library, add a PKG_OLD_ABI variable pointing at the 4.14 ABI. No functional change. Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Juergen Gross --- tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump | 924 +++++++++++ .../abi/libxendevicemodel.so.1.3-x86_64-abi.dump | 1491 +++++++++++++++++ tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump | 719 ++++++++ .../abi/libxenforeignmemory.so.1.3-x86_64-abi.dump | 847 ++++++++++ tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump | 1199 ++++++++++++++ tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump | 597 +++++++ .../libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump | 1711 ++++++++++++++++++++ .../libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump | 239 +++ .../libs/abi/libxentoollog.so.1.0-x86_64-abi.dump | 882 ++++++++++ tools/libs/call/Makefile | 2 + tools/libs/devicemodel/Makefile | 2 + tools/libs/evtchn/Makefile | 2 + tools/libs/foreignmemory/Makefile | 2 + tools/libs/gnttab/Makefile | 2 + tools/libs/hypfs/Makefile | 2 + tools/libs/store/Makefile | 2 + tools/libs/toolcore/Makefile | 2 + tools/libs/toollog/Makefile | 2 + 18 files changed, 8627 insertions(+) create mode 100644 tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump create mode 100644 tools/libs/abi/libxendevicemodel.so.1.3-x86_64-abi.dump create mode 100644 tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump create mode 100644 tools/libs/abi/libxenforeignmemory.so.1.3-x86_64-abi.dump create mode 100644 tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump create mode 100644 tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump create mode 100644 tools/libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump create mode 100644 tools/libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump create mode 100644 tools/libs/abi/libxentoollog.so.1.0-x86_64-abi.dump diff --git a/tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump b/tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump new file mode 100644 index 0000000000..4d04ddd692 --- /dev/null +++ b/tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump @@ -0,0 +1,924 @@ +$VAR1 = { + 'ABI_DUMPER_VERSION' => '0.99.16', + 'ABI_DUMP_VERSION' => '3.2', + 'Arch' => 'x86_64', + 'GccVersion' => '6.3.0', + 'Headers' => { + 'xencall.h' => 1 + }, + 'Language' => 'C', + 'LibraryName' => 'libxencall.so.1.2', + 'LibraryVersion' => '1.2', + 'NameSpaces' => {}, + 'Needed' => { + 'libc.so.6' => 1, + 'libpthread.so.0' => 1, + 'libxentoolcore.so.1' => 1, + 'libxentoollog.so.1' => 1 + }, + 'PublicABI' => '1', + 'Sources' => { + 'buffer.c' => 1, + 'core.c' => 1, + 'linux.c' => 1 + }, + 'SymbolInfo' => { + '1580' => { + 'Header' => 'xencall.h', + 'Param' => { + '0' => { + 'name' => 'xcall', + 'type' => '1758' + }, + '1' => { + 'name' => 'op', + 'type' => '74' + }, + '2' => { + 'name' => 'arg1', + 'type' => '1128' + }, + '3' => { + 'name' => 'arg2', + 'type' => '1128' + }, + '4' => { + 'name' => 'arg3', + 'type' => '1128' + }, + '5' => { + 'name' => 'arg4', + 'type' => '1128' + }, + '6' => { + 'name' => 'arg5', + 'offset' => '0', + 'type' => '1128' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '67', + 'ShortName' => 'xencall5', + 'Source' => 'core.c', + 'SourceLine' => '153' + }, + '1764' => { + 'Header' => 'xencall.h', + 'Param' => { + '0' => { + 'name' => 'xcall', + 'type' => '1758' + }, + '1' => { + 'name' => 'op', + 'type' => '74' + }, + '2' => { + 'name' => 'arg1', + 'type' => '1128' + }, + '3' => { + 'name' => 'arg2', + 'type' => '1128' + }, + '4' => { + 'name' => 'arg3', + 'type' => '1128' + }, + '5' => { + 'name' => 'arg4', + 'type' => '1128' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '67', + 'ShortName' => 'xencall4', + 'Source' => 'core.c', + 'SourceLine' => '141' + }, + '1928' => { + 'Header' => 'xencall.h', + 'Param' => { + '0' => { + 'name' => 'xcall', + 'type' => '1758' + }, + '1' => { + 'name' => 'op', + 'type' => '74' + }, + '2' => { + 'name' => 'arg1', + 'type' => '1128' + }, + '3' => { + 'name' => 'arg2', + 'type' => '1128' + }, + '4' => { + 'name' => 'arg3', + 'type' => '1128' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8' + }, + 'Return' => '67', + 'ShortName' => 'xencall3', + 'Source' => 'core.c', + 'SourceLine' => '130' + }, + '2077' => { + 'Header' => 'xencall.h', + 'Param' => { + '0' => { + 'name' => 'xcall', + 'type' => '1758' + }, + '1' => { + 'name' => 'op', + 'type' => '74' + }, + '2' => { + 'name' => 'arg1', + 'type' => '1128' + }, + '3' => { + 'name' => 'arg2', + 'type' => '1128' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '67', + 'ShortName' => 'xencall2', + 'Source' => 'core.c', + 'SourceLine' => '119' + }, + '2211' => { + 'Header' => 'xencall.h', + 'Param' => { + '0' => { + 'name' => 'xcall', + 'type' => '1758' + }, + '1' => { + 'name' => 'op', + 'type' => '74' + }, + '2' => { + 'name' => 'arg1', + 'type' => '1128' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '67', + 'ShortName' => 'xencall1', + 'Source' => 'core.c', + 'SourceLine' => '108' + }, + '2330' => { + 'Header' => 'xencall.h', + 'Param' => { + '0' => { + 'name' => 'xcall', + 'type' => '1758' + }, + '1' => { + 'name' => 'op', + 'type' => '74' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '67', + 'ShortName' => 'xencall0', + 'Source' => 'core.c', + 'SourceLine' => '99' + }, + '2434' => { + 'Header' => 'xencall.h', + 'Param' => { + '0' => { + 'name' => 'xcall', + 'type' => '1758' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '67', + 'ShortName' => 'xencall_fd', + 'Source' => 'core.c', + 'SourceLine' => '94' + }, + '2481' => { + 'Header' => 'xencall.h', + 'Param' => { + '0' => { + 'name' => 'xcall', + 'type' => '1758' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '67', + 'ShortName' => 'xencall_close', + 'Source' => 'core.c', + 'SourceLine' => '79' + }, + '2649' => { + 'Header' => 'xencall.h', + 'Param' => { + '0' => { + 'name' => 'logger', + 'type' => '1558' + }, + '1' => { + 'name' => 'open_flags', + 'type' => '74' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '1758', + 'ShortName' => 'xencall_open', + 'Source' => 'core.c', + 'SourceLine' => '34' + }, + '5101' => { + 'Header' => 'xencall.h', + 'Param' => { + '0' => { + 'name' => 'xcall', + 'type' => '1758' + }, + '1' => { + 'name' => 'p', + 'type' => '152' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '1', + 'ShortName' => 'xencall_free_buffer', + 'Source' => 'buffer.c', + 'SourceLine' => '172' + }, + '5216' => { + 'Header' => 'xencall.h', + 'Param' => { + '0' => { + 'name' => 'xcall', + 'type' => '1758' + }, + '1' => { + 'name' => 'size', + 'type' => '49' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '152', + 'ShortName' => 'xencall_alloc_buffer', + 'Source' => 'buffer.c', + 'SourceLine' => '157' + }, + '5358' => { + 'Header' => 'xencall.h', + 'Param' => { + '0' => { + 'name' => 'xcall', + 'type' => '1758' + }, + '1' => { + 'name' => 'p', + 'type' => '152' + }, + '2' => { + 'name' => 'nr_pages', + 'type' => '49' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '1', + 'ShortName' => 'xencall_free_buffer_pages', + 'Source' => 'buffer.c', + 'SourceLine' => '143' + }, + '5499' => { + 'Header' => 'xencall.h', + 'Param' => { + '0' => { + 'name' => 'xcall', + 'type' => '1758' + }, + '1' => { + 'name' => 'nr_pages', + 'type' => '49' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '152', + 'ShortName' => 'xencall_alloc_buffer_pages', + 'Source' => 'buffer.c', + 'SourceLine' => '128' + }, + '8185' => { + 'Header' => 'xencall.h', + 'Param' => { + '0' => { + 'name' => 'xcall', + 'type' => '1758' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '67', + 'ShortName' => 'xencall_buffers_never_fault', + 'Source' => 'linux.c', + 'SourceLine' => '176' + } + }, + 'SymbolVersion' => { + '_ITM_deregisterTMCloneTable' => 'xtl_logger_destroy@@VERS_1.0', + '_ITM_registerTMCloneTable' => 'xtl_logger_destroy@@VERS_1.0', + '_Jv_RegisterClasses' => 'xtl_logger_destroy@@VERS_1.0', + '__gmon_start__' => 'xtl_logger_destroy@@VERS_1.0', + 'xencall0' => 'xencall0@@VERS_1.0', + 'xencall1' => 'xencall1@@VERS_1.0', + 'xencall2' => 'xencall2@@VERS_1.0', + 'xencall3' => 'xencall3@@VERS_1.0', + 'xencall4' => 'xencall4@@VERS_1.0', + 'xencall5' => 'xencall5@@VERS_1.0', + 'xencall_alloc_buffer' => 'xencall_alloc_buffer@@VERS_1.0', + 'xencall_alloc_buffer_pages' => 'xencall_alloc_buffer_pages@@VERS_1.0', + 'xencall_buffers_never_fault' => 'xencall_buffers_never_fault@@VERS_1.1', + 'xencall_close' => 'xencall_close@@VERS_1.0', + 'xencall_fd' => 'xencall_fd@@VERS_1.2', + 'xencall_free_buffer' => 'xencall_free_buffer@@VERS_1.0', + 'xencall_free_buffer_pages' => 'xencall_free_buffer_pages@@VERS_1.0', + 'xencall_open' => 'xencall_open@@VERS_1.0' + }, + 'Symbols' => { + 'libxencall.so.1.2' => { + 'xencall0@@VERS_1.0' => 1, + 'xencall1@@VERS_1.0' => 1, + 'xencall2@@VERS_1.0' => 1, + 'xencall3@@VERS_1.0' => 1, + 'xencall4@@VERS_1.0' => 1, + 'xencall5@@VERS_1.0' => 1, + 'xencall_alloc_buffer@@VERS_1.0' => 1, + 'xencall_alloc_buffer_pages@@VERS_1.0' => 1, + 'xencall_buffers_never_fault@@VERS_1.1' => 1, + 'xencall_close@@VERS_1.0' => 1, + 'xencall_fd@@VERS_1.2' => 1, + 'xencall_free_buffer@@VERS_1.0' => 1, + 'xencall_free_buffer_pages@@VERS_1.0' => 1, + 'xencall_open@@VERS_1.0' => 1 + } + }, + 'Target' => 'unix', + 'TypeInfo' => { + '1' => { + 'Name' => 'void', + 'Type' => 'Intrinsic' + }, + '102' => { + 'Name' => 'unsigned short', + 'Size' => '2', + 'Type' => 'Intrinsic' + }, + '1046' => { + 'BaseType' => '560', + 'Name' => 'struct __va_list_tag*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1052' => { + 'Name' => 'void(*)(struct xentoollog_logger*, xentoollog_level, int, char const*, char const*, struct __va_list_tag*)', + 'Param' => { + '0' => { + 'type' => '1558' + }, + '1' => { + 'type' => '933' + }, + '2' => { + 'type' => '67' + }, + '3' => { + 'type' => '768' + }, + '4' => { + 'type' => '768' + }, + '5' => { + 'type' => '1046' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1094' => { + 'Name' => 'void(*)(struct xentoollog_logger*, char const*, char const*, int, unsigned long, unsigned long)', + 'Param' => { + '0' => { + 'type' => '1558' + }, + '1' => { + 'type' => '768' + }, + '2' => { + 'type' => '768' + }, + '3' => { + 'type' => '67' + }, + '4' => { + 'type' => '60' + }, + '5' => { + 'type' => '60' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1111' => { + 'Name' => 'void(*)(struct xentoollog_logger*)', + 'Param' => { + '0' => { + 'type' => '1558' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1117' => { + 'BaseType' => '102', + 'Header' => 'stdint.h', + 'Line' => '49', + 'Name' => 'uint16_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '1128' => { + 'BaseType' => '60', + 'Header' => 'stdint.h', + 'Line' => '55', + 'Name' => 'uint64_t', + 'Size' => '8', + 'Type' => 'Typedef' + }, + '1139' => { + 'BaseType' => '1117', + 'Header' => 'xen.h', + 'Line' => '623', + 'Name' => 'domid_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '1151' => { + 'BaseType' => '1162', + 'Header' => 'xentoolcore_internal.h', + 'Line' => '83', + 'Name' => 'Xentoolcore__Active_Handle', + 'Size' => '24', + 'Type' => 'Typedef' + }, + '1162' => { + 'Header' => 'xentoolcore_internal.h', + 'Line' => '88', + 'Memb' => { + '0' => { + 'name' => 'restrict_callback', + 'offset' => '0', + 'type' => '1275' + }, + '1' => { + 'name' => 'entry', + 'offset' => '8', + 'type' => '1236' + } + }, + 'Name' => 'struct Xentoolcore__Active_Handle', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '1199' => { + 'BaseType' => '1210', + 'Header' => 'xentoolcore_internal.h', + 'Line' => '85', + 'Name' => 'Xentoolcore__Restrict_Callback', + 'Type' => 'Typedef' + }, + '1210' => { + 'Name' => 'int()(Xentoolcore__Active_Handle*, domid_t)', + 'Param' => { + '0' => { + 'type' => '1230' + }, + '1' => { + 'type' => '1139' + } + }, + 'Return' => '67', + 'Type' => 'Func' + }, + '1230' => { + 'BaseType' => '1151', + 'Name' => 'Xentoolcore__Active_Handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1236' => { + 'Header' => 'xentoolcore_internal.h', + 'Line' => '90', + 'Memb' => { + '0' => { + 'name' => 'le_next', + 'offset' => '0', + 'type' => '1230' + }, + '1' => { + 'name' => 'le_prev', + 'offset' => '8', + 'type' => '1269' + } + }, + 'Name' => 'anon-struct-xentoolcore_internal.h-90', + 'PrivateABI' => 1, + 'Size' => '16', + 'Type' => 'Struct' + }, + '1269' => { + 'BaseType' => '1230', + 'Name' => 'Xentoolcore__Active_Handle**', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1275' => { + 'BaseType' => '1199', + 'Name' => 'Xentoolcore__Restrict_Callback*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1281' => { + 'BaseType' => '1292', + 'Header' => 'xencall.h', + 'Line' => '31', + 'Name' => 'xencall_handle', + 'Size' => '128', + 'Type' => 'Typedef' + }, + '1292' => { + 'Header' => 'private.h', + 'Line' => '20', + 'Memb' => { + '0' => { + 'name' => 'logger', + 'offset' => '0', + 'type' => '1558' + }, + '1' => { + 'name' => 'logger_tofree', + 'offset' => '8', + 'type' => '1558' + }, + '10' => { + 'name' => 'buffer_current_allocations', + 'offset' => '104', + 'type' => '67' + }, + '11' => { + 'name' => 'buffer_maximum_allocations', + 'offset' => '108', + 'type' => '67' + }, + '12' => { + 'name' => 'buffer_cache_hits', + 'offset' => '112', + 'type' => '67' + }, + '13' => { + 'name' => 'buffer_cache_misses', + 'offset' => '116', + 'type' => '67' + }, + '14' => { + 'name' => 'buffer_cache_toobig', + 'offset' => '120', + 'type' => '67' + }, + '2' => { + 'name' => 'flags', + 'offset' => '16', + 'type' => '74' + }, + '3' => { + 'name' => 'fd', + 'offset' => '20', + 'type' => '67' + }, + '4' => { + 'name' => 'buf_fd', + 'offset' => '24', + 'type' => '67' + }, + '5' => { + 'name' => 'tc_ah', + 'offset' => '32', + 'type' => '1151' + }, + '6' => { + 'name' => 'buffer_cache_nr', + 'offset' => '56', + 'type' => '67' + }, + '7' => { + 'name' => 'buffer_cache', + 'offset' => '64', + 'type' => '1564' + }, + '8' => { + 'name' => 'buffer_total_allocations', + 'offset' => '96', + 'type' => '67' + }, + '9' => { + 'name' => 'buffer_total_releases', + 'offset' => '100', + 'type' => '67' + } + }, + 'Name' => 'struct xencall_handle', + 'PrivateABI' => 1, + 'Size' => '128', + 'Type' => 'Struct' + }, + '152' => { + 'BaseType' => '1', + 'Name' => 'void*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1558' => { + 'BaseType' => '944', + 'Name' => 'xentoollog_logger*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1564' => { + 'BaseType' => '152', + 'Name' => 'void*[4]', + 'Size' => '32', + 'Type' => 'Array' + }, + '160' => { + 'Name' => 'char', + 'Size' => '1', + 'Type' => 'Intrinsic' + }, + '167' => { + 'BaseType' => '160', + 'Name' => 'char const', + 'Size' => '1', + 'Type' => 'Const' + }, + '1758' => { + 'BaseType' => '1281', + 'Name' => 'xencall_handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '49' => { + 'BaseType' => '60', + 'Header' => 'stddef.h', + 'Line' => '216', + 'Name' => 'size_t', + 'Size' => '8', + 'Type' => 'Typedef' + }, + '560' => { + 'Memb' => { + '0' => { + 'name' => 'gp_offset', + 'offset' => '0', + 'type' => '74' + }, + '1' => { + 'name' => 'fp_offset', + 'offset' => '4', + 'type' => '74' + }, + '2' => { + 'name' => 'overflow_arg_area', + 'offset' => '8', + 'type' => '152' + }, + '3' => { + 'name' => 'reg_save_area', + 'offset' => '16', + 'type' => '152' + } + }, + 'Name' => 'struct __va_list_tag', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '60' => { + 'Name' => 'unsigned long', + 'Size' => '8', + 'Type' => 'Intrinsic' + }, + '67' => { + 'Name' => 'int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '74' => { + 'Name' => 'unsigned int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '768' => { + 'BaseType' => '167', + 'Name' => 'char const*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '850' => { + 'Header' => 'xentoollog.h', + 'Line' => '30', + 'Memb' => { + '0' => { + 'name' => 'XTL_NONE', + 'value' => '0' + }, + '1' => { + 'name' => 'XTL_DEBUG', + 'value' => '1' + }, + '10' => { + 'name' => 'XTL_NUM_LEVELS', + 'value' => '10' + }, + '2' => { + 'name' => 'XTL_VERBOSE', + 'value' => '2' + }, + '3' => { + 'name' => 'XTL_DETAIL', + 'value' => '3' + }, + '4' => { + 'name' => 'XTL_PROGRESS', + 'value' => '4' + }, + '5' => { + 'name' => 'XTL_INFO', + 'value' => '5' + }, + '6' => { + 'name' => 'XTL_NOTICE', + 'value' => '6' + }, + '7' => { + 'name' => 'XTL_WARN', + 'value' => '7' + }, + '8' => { + 'name' => 'XTL_ERROR', + 'value' => '8' + }, + '9' => { + 'name' => 'XTL_CRITICAL', + 'value' => '9' + } + }, + 'Name' => 'enum xentoollog_level', + 'PrivateABI' => 1, + 'Size' => '4', + 'Type' => 'Enum' + }, + '933' => { + 'BaseType' => '850', + 'Header' => 'xentoollog.h', + 'Line' => '42', + 'Name' => 'xentoollog_level', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '944' => { + 'BaseType' => '955', + 'Header' => 'xentoollog.h', + 'Line' => '44', + 'Name' => 'xentoollog_logger', + 'Size' => '24', + 'Type' => 'Typedef' + }, + '955' => { + 'Header' => 'xentoollog.h', + 'Line' => '45', + 'Memb' => { + '0' => { + 'name' => 'vmessage', + 'offset' => '0', + 'type' => '1052' + }, + '1' => { + 'name' => 'progress', + 'offset' => '8', + 'type' => '1094' + }, + '2' => { + 'name' => 'destroy', + 'offset' => '16', + 'type' => '1111' + } + }, + 'Name' => 'struct xentoollog_logger', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + } + }, + 'UndefinedSymbols' => { + 'libxencall.so.1.2' => { + '_ITM_deregisterTMCloneTable' => 0, + '_ITM_registerTMCloneTable' => 0, + '_Jv_RegisterClasses' => 0, + '__cxa_finalize@GLIBC_2.2.5' => 0, + '__errno_location@GLIBC_2.2.5' => 0, + '__gmon_start__' => 0, + 'close@GLIBC_2.2.5' => 0, + 'free@GLIBC_2.2.5' => 0, + 'ioctl@GLIBC_2.2.5' => 0, + 'madvise@GLIBC_2.2.5' => 0, + 'malloc@GLIBC_2.2.5' => 0, + 'memset@GLIBC_2.2.5' => 0, + 'mmap@GLIBC_2.2.5' => 0, + 'munmap@GLIBC_2.2.5' => 0, + 'open@GLIBC_2.2.5' => 0, + 'pthread_mutex_lock@GLIBC_2.2.5' => 0, + 'pthread_mutex_unlock@GLIBC_2.2.5' => 0, + 'stderr@GLIBC_2.2.5' => 0, + 'xentoolcore__deregister_active_handle@VERS_1.0' => 0, + 'xentoolcore__register_active_handle@VERS_1.0' => 0, + 'xentoolcore__restrict_by_dup2_null@VERS_1.0' => 0, + 'xtl_createlogger_stdiostream@VERS_1.0' => 0, + 'xtl_log@VERS_1.0' => 0, + 'xtl_logger_destroy@VERS_1.0' => 0 + } + }, + 'WordSize' => '8' + }; diff --git a/tools/libs/abi/libxendevicemodel.so.1.3-x86_64-abi.dump b/tools/libs/abi/libxendevicemodel.so.1.3-x86_64-abi.dump new file mode 100644 index 0000000000..edc32506fa --- /dev/null +++ b/tools/libs/abi/libxendevicemodel.so.1.3-x86_64-abi.dump @@ -0,0 +1,1491 @@ +$VAR1 = { + 'ABI_DUMPER_VERSION' => '0.99.16', + 'ABI_DUMP_VERSION' => '3.2', + 'Arch' => 'x86_64', + 'GccVersion' => '6.3.0', + 'Headers' => { + 'xendevicemodel.h' => 1 + }, + 'Language' => 'C', + 'LibraryName' => 'libxendevicemodel.so.1.3', + 'LibraryVersion' => '1.3', + 'NameSpaces' => {}, + 'Needed' => { + 'libc.so.6' => 1, + 'libpthread.so.0' => 1, + 'libxencall.so.1' => 1, + 'libxentoolcore.so.1' => 1, + 'libxentoollog.so.1' => 1 + }, + 'PublicABI' => '1', + 'Sources' => { + 'core.c' => 1 + }, + 'SymbolInfo' => { + '3021' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_restrict', + 'Source' => 'core.c', + 'SourceLine' => '615' + }, + '3126' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'start', + 'type' => '1197' + }, + '3' => { + 'name' => 'end', + 'type' => '1197' + }, + '4' => { + 'name' => 'type', + 'type' => '1186' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_pin_memory_cacheattr', + 'Source' => 'core.c', + 'SourceLine' => '596' + }, + '3326' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'size', + 'type' => '1186' + }, + '3' => { + 'name' => 'src_gfn', + 'type' => '1197' + }, + '4' => { + 'name' => 'dst_gfn', + 'type' => '1197' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_relocate_memory', + 'Source' => 'core.c', + 'SourceLine' => '576' + }, + '3526' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'reason', + 'type' => '74' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_shutdown', + 'Source' => 'core.c', + 'SourceLine' => '560' + }, + '3694' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'vcpu', + 'type' => '67' + }, + '3' => { + 'name' => 'vector', + 'type' => '1164' + }, + '4' => { + 'name' => 'type', + 'type' => '1164' + }, + '5' => { + 'name' => 'error_code', + 'type' => '1186' + }, + '6' => { + 'name' => 'insn_len', + 'offset' => '0', + 'type' => '1164' + }, + '7' => { + 'name' => 'extra', + 'offset' => '8', + 'type' => '1197' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_inject_event', + 'Source' => 'core.c', + 'SourceLine' => '538' + }, + '3940' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'mem_type', + 'type' => '2720' + }, + '3' => { + 'name' => 'first_pfn', + 'type' => '1197' + }, + '4' => { + 'name' => 'nr', + 'type' => '1186' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_set_mem_type', + 'Source' => 'core.c', + 'SourceLine' => '519' + }, + '4139' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'first_pfn', + 'type' => '1197' + }, + '3' => { + 'name' => 'nr', + 'type' => '1186' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_modified_memory', + 'Source' => 'core.c', + 'SourceLine' => '507' + }, + '4295' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'extents', + 'type' => '4495' + }, + '3' => { + 'name' => 'nr', + 'type' => '1186' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_modified_memory_bulk', + 'Source' => 'core.c', + 'SourceLine' => '487' + }, + '4507' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'first_pfn', + 'type' => '1197' + }, + '3' => { + 'name' => 'nr', + 'type' => '1186' + }, + '4' => { + 'name' => 'dirty_bitmap', + 'type' => '4707' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_track_dirty_vram', + 'Source' => 'core.c', + 'SourceLine' => '468' + }, + '4719' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'msi_addr', + 'type' => '1197' + }, + '3' => { + 'name' => 'msi_data', + 'type' => '1186' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_inject_msi', + 'Source' => 'core.c', + 'SourceLine' => '450' + }, + '4903' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'link', + 'type' => '1164' + }, + '3' => { + 'name' => 'irq', + 'type' => '1164' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_set_pci_link_route', + 'Source' => 'core.c', + 'SourceLine' => '433' + }, + '5087' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'irq', + 'type' => '1164' + }, + '3' => { + 'name' => 'level', + 'type' => '74' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_set_isa_irq_level', + 'Source' => 'core.c', + 'SourceLine' => '415' + }, + '5271' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'segment', + 'type' => '1175' + }, + '3' => { + 'name' => 'bus', + 'type' => '1164' + }, + '4' => { + 'name' => 'device', + 'type' => '1164' + }, + '5' => { + 'name' => 'intx', + 'type' => '1164' + }, + '6' => { + 'name' => 'level', + 'offset' => '0', + 'type' => '74' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_set_pci_intx_level', + 'Source' => 'core.c', + 'SourceLine' => '394' + }, + '5502' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'id', + 'type' => '1311' + }, + '3' => { + 'name' => 'enabled', + 'type' => '67' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_set_ioreq_server_state', + 'Source' => 'core.c', + 'SourceLine' => '377' + }, + '5685' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'id', + 'type' => '1311' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_destroy_ioreq_server', + 'Source' => 'core.c', + 'SourceLine' => '361' + }, + '5852' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'id', + 'type' => '1311' + }, + '3' => { + 'name' => 'segment', + 'type' => '1175' + }, + '4' => { + 'name' => 'bus', + 'type' => '1164' + }, + '5' => { + 'name' => 'device', + 'type' => '1164' + }, + '6' => { + 'name' => 'function', + 'offset' => '0', + 'type' => '1164' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_unmap_pcidev_from_ioreq_server', + 'Source' => 'core.c', + 'SourceLine' => '329' + }, + '6099' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'id', + 'type' => '1311' + }, + '3' => { + 'name' => 'segment', + 'type' => '1175' + }, + '4' => { + 'name' => 'bus', + 'type' => '1164' + }, + '5' => { + 'name' => 'device', + 'type' => '1164' + }, + '6' => { + 'name' => 'function', + 'offset' => '0', + 'type' => '1164' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_map_pcidev_to_ioreq_server', + 'Source' => 'core.c', + 'SourceLine' => '297' + }, + '6340' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'id', + 'type' => '1311' + }, + '3' => { + 'name' => 'type', + 'type' => '1175' + }, + '4' => { + 'name' => 'flags', + 'type' => '1186' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_map_mem_type_to_ioreq_server', + 'Source' => 'core.c', + 'SourceLine' => '272' + }, + '6556' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'id', + 'type' => '1311' + }, + '3' => { + 'name' => 'is_mmio', + 'type' => '67' + }, + '4' => { + 'name' => 'start', + 'type' => '1197' + }, + '5' => { + 'name' => 'end', + 'type' => '1197' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_unmap_io_range_from_ioreq_server', + 'Source' => 'core.c', + 'SourceLine' => '252' + }, + '6758' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'id', + 'type' => '1311' + }, + '3' => { + 'name' => 'is_mmio', + 'type' => '67' + }, + '4' => { + 'name' => 'start', + 'type' => '1197' + }, + '5' => { + 'name' => 'end', + 'type' => '1197' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_map_io_range_to_ioreq_server', + 'Source' => 'core.c', + 'SourceLine' => '232' + }, + '6958' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'id', + 'type' => '1311' + }, + '3' => { + 'name' => 'ioreq_gfn', + 'type' => '1276' + }, + '4' => { + 'name' => 'bufioreq_gfn', + 'type' => '1276' + }, + '5' => { + 'name' => 'bufioreq_port', + 'type' => '1305' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_get_ioreq_server_info', + 'Source' => 'core.c', + 'SourceLine' => '192' + }, + '7170' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + }, + '1' => { + 'name' => 'domid', + 'type' => '1282' + }, + '2' => { + 'name' => 'handle_bufioreq', + 'type' => '67' + }, + '3' => { + 'name' => 'id', + 'type' => '7352' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_create_ioreq_server', + 'Source' => 'core.c', + 'SourceLine' => '168' + }, + '7987' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'dmod', + 'type' => '3120' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '67', + 'ShortName' => 'xendevicemodel_close', + 'Source' => 'core.c', + 'SourceLine' => '78' + }, + '8144' => { + 'Header' => 'xendevicemodel.h', + 'Param' => { + '0' => { + 'name' => 'logger', + 'type' => '2972' + }, + '1' => { + 'name' => 'open_flags', + 'type' => '74' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '3120', + 'ShortName' => 'xendevicemodel_open', + 'Source' => 'core.c', + 'SourceLine' => '34' + } + }, + 'SymbolVersion' => { + '_ITM_deregisterTMCloneTable' => 'xtl_logger_destroy@@VERS_1.0', + '_ITM_registerTMCloneTable' => 'xtl_logger_destroy@@VERS_1.0', + '_Jv_RegisterClasses' => 'xtl_logger_destroy@@VERS_1.0', + '__gmon_start__' => 'xtl_logger_destroy@@VERS_1.0', + 'xendevicemodel_close' => 'xendevicemodel_close@@VERS_1.0', + 'xendevicemodel_create_ioreq_server' => 'xendevicemodel_create_ioreq_server@@VERS_1.0', + 'xendevicemodel_destroy_ioreq_server' => 'xendevicemodel_destroy_ioreq_server@@VERS_1.0', + 'xendevicemodel_get_ioreq_server_info' => 'xendevicemodel_get_ioreq_server_info@@VERS_1.0', + 'xendevicemodel_inject_event' => 'xendevicemodel_inject_event@@VERS_1.0', + 'xendevicemodel_inject_msi' => 'xendevicemodel_inject_msi@@VERS_1.0', + 'xendevicemodel_map_io_range_to_ioreq_server' => 'xendevicemodel_map_io_range_to_ioreq_server@@VERS_1.0', + 'xendevicemodel_map_mem_type_to_ioreq_server' => 'xendevicemodel_map_mem_type_to_ioreq_server@@VERS_1.0', + 'xendevicemodel_map_pcidev_to_ioreq_server' => 'xendevicemodel_map_pcidev_to_ioreq_server@@VERS_1.0', + 'xendevicemodel_modified_memory' => 'xendevicemodel_modified_memory@@VERS_1.0', + 'xendevicemodel_modified_memory_bulk' => 'xendevicemodel_modified_memory_bulk@@VERS_1.3', + 'xendevicemodel_open' => 'xendevicemodel_open@@VERS_1.0', + 'xendevicemodel_pin_memory_cacheattr' => 'xendevicemodel_pin_memory_cacheattr@@VERS_1.2', + 'xendevicemodel_relocate_memory' => 'xendevicemodel_relocate_memory@@VERS_1.2', + 'xendevicemodel_restrict' => 'xendevicemodel_restrict@@VERS_1.0', + 'xendevicemodel_set_ioreq_server_state' => 'xendevicemodel_set_ioreq_server_state@@VERS_1.0', + 'xendevicemodel_set_isa_irq_level' => 'xendevicemodel_set_isa_irq_level@@VERS_1.0', + 'xendevicemodel_set_mem_type' => 'xendevicemodel_set_mem_type@@VERS_1.0', + 'xendevicemodel_set_pci_intx_level' => 'xendevicemodel_set_pci_intx_level@@VERS_1.0', + 'xendevicemodel_set_pci_link_route' => 'xendevicemodel_set_pci_link_route@@VERS_1.0', + 'xendevicemodel_shutdown' => 'xendevicemodel_shutdown@@VERS_1.1', + 'xendevicemodel_track_dirty_vram' => 'xendevicemodel_track_dirty_vram@@VERS_1.0', + 'xendevicemodel_unmap_io_range_from_ioreq_server' => 'xendevicemodel_unmap_io_range_from_ioreq_server@@VERS_1.0', + 'xendevicemodel_unmap_pcidev_from_ioreq_server' => 'xendevicemodel_unmap_pcidev_from_ioreq_server@@VERS_1.0' + }, + 'Symbols' => { + 'libxendevicemodel.so.1.3' => { + 'xendevicemodel_close@@VERS_1.0' => 1, + 'xendevicemodel_create_ioreq_server@@VERS_1.0' => 1, + 'xendevicemodel_destroy_ioreq_server@@VERS_1.0' => 1, + 'xendevicemodel_get_ioreq_server_info@@VERS_1.0' => 1, + 'xendevicemodel_inject_event@@VERS_1.0' => 1, + 'xendevicemodel_inject_msi@@VERS_1.0' => 1, + 'xendevicemodel_map_io_range_to_ioreq_server@@VERS_1.0' => 1, + 'xendevicemodel_map_mem_type_to_ioreq_server@@VERS_1.0' => 1, + 'xendevicemodel_map_pcidev_to_ioreq_server@@VERS_1.0' => 1, + 'xendevicemodel_modified_memory@@VERS_1.0' => 1, + 'xendevicemodel_modified_memory_bulk@@VERS_1.3' => 1, + 'xendevicemodel_open@@VERS_1.0' => 1, + 'xendevicemodel_pin_memory_cacheattr@@VERS_1.2' => 1, + 'xendevicemodel_relocate_memory@@VERS_1.2' => 1, + 'xendevicemodel_restrict@@VERS_1.0' => 1, + 'xendevicemodel_set_ioreq_server_state@@VERS_1.0' => 1, + 'xendevicemodel_set_isa_irq_level@@VERS_1.0' => 1, + 'xendevicemodel_set_mem_type@@VERS_1.0' => 1, + 'xendevicemodel_set_pci_intx_level@@VERS_1.0' => 1, + 'xendevicemodel_set_pci_link_route@@VERS_1.0' => 1, + 'xendevicemodel_shutdown@@VERS_1.1' => 1, + 'xendevicemodel_track_dirty_vram@@VERS_1.0' => 1, + 'xendevicemodel_unmap_io_range_from_ioreq_server@@VERS_1.0' => 1, + 'xendevicemodel_unmap_pcidev_from_ioreq_server@@VERS_1.0' => 1 + } + }, + 'Target' => 'unix', + 'TypeInfo' => { + '1' => { + 'Name' => 'void', + 'Type' => 'Intrinsic' + }, + '1002' => { + 'Header' => 'xentoollog.h', + 'Line' => '45', + 'Memb' => { + '0' => { + 'name' => 'vmessage', + 'offset' => '0', + 'type' => '1099' + }, + '1' => { + 'name' => 'progress', + 'offset' => '8', + 'type' => '1141' + }, + '2' => { + 'name' => 'destroy', + 'offset' => '16', + 'type' => '1158' + } + }, + 'Name' => 'struct xentoollog_logger', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '102' => { + 'Name' => 'unsigned short', + 'Size' => '2', + 'Type' => 'Intrinsic' + }, + '1093' => { + 'BaseType' => '607', + 'Name' => 'struct __va_list_tag*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1099' => { + 'Name' => 'void(*)(struct xentoollog_logger*, xentoollog_level, int, char const*, char const*, struct __va_list_tag*)', + 'Param' => { + '0' => { + 'type' => '2972' + }, + '1' => { + 'type' => '980' + }, + '2' => { + 'type' => '67' + }, + '3' => { + 'type' => '179' + }, + '4' => { + 'type' => '179' + }, + '5' => { + 'type' => '1093' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1141' => { + 'Name' => 'void(*)(struct xentoollog_logger*, char const*, char const*, int, unsigned long, unsigned long)', + 'Param' => { + '0' => { + 'type' => '2972' + }, + '1' => { + 'type' => '179' + }, + '2' => { + 'type' => '179' + }, + '3' => { + 'type' => '67' + }, + '4' => { + 'type' => '60' + }, + '5' => { + 'type' => '60' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1158' => { + 'Name' => 'void(*)(struct xentoollog_logger*)', + 'Param' => { + '0' => { + 'type' => '2972' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1164' => { + 'BaseType' => '95', + 'Header' => 'stdint.h', + 'Line' => '48', + 'Name' => 'uint8_t', + 'Size' => '1', + 'Type' => 'Typedef' + }, + '1175' => { + 'BaseType' => '102', + 'Header' => 'stdint.h', + 'Line' => '49', + 'Name' => 'uint16_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '1186' => { + 'BaseType' => '74', + 'Header' => 'stdint.h', + 'Line' => '51', + 'Name' => 'uint32_t', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '1197' => { + 'BaseType' => '60', + 'Header' => 'stdint.h', + 'Line' => '55', + 'Name' => 'uint64_t', + 'Size' => '8', + 'Type' => 'Typedef' + }, + '1224' => { + 'BaseType' => '60', + 'Header' => 'xen.h', + 'Line' => '76', + 'Name' => 'xen_pfn_t', + 'Size' => '8', + 'Type' => 'Typedef' + }, + '1276' => { + 'BaseType' => '1224', + 'Name' => 'xen_pfn_t*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1282' => { + 'BaseType' => '1175', + 'Header' => 'xen.h', + 'Line' => '623', + 'Name' => 'domid_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '1294' => { + 'BaseType' => '1186', + 'Header' => 'event_channel.h', + 'Line' => '79', + 'Name' => 'evtchn_port_t', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '1305' => { + 'BaseType' => '1294', + 'Name' => 'evtchn_port_t*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1311' => { + 'BaseType' => '1175', + 'Header' => 'dm_op.h', + 'Line' => '56', + 'Name' => 'ioservid_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '152' => { + 'BaseType' => '1', + 'Name' => 'void*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '160' => { + 'Name' => 'char', + 'Size' => '1', + 'Type' => 'Intrinsic' + }, + '167' => { + 'BaseType' => '160', + 'Name' => 'char const', + 'Size' => '1', + 'Type' => 'Const' + }, + '179' => { + 'BaseType' => '167', + 'Name' => 'char const*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1833' => { + 'Header' => 'dm_op.h', + 'Line' => '269', + 'Memb' => { + '0' => { + 'name' => 'nr', + 'offset' => '0', + 'type' => '1186' + }, + '1' => { + 'name' => 'pad', + 'offset' => '4', + 'type' => '1186' + }, + '2' => { + 'name' => 'first_pfn', + 'offset' => '8', + 'type' => '1197' + } + }, + 'Name' => 'struct xen_dm_op_modified_memory_extent', + 'PrivateABI' => 1, + 'Size' => '16', + 'Type' => 'Struct' + }, + '2720' => { + 'Header' => 'hvm_op.h', + 'Line' => '129', + 'Memb' => { + '0' => { + 'name' => 'HVMMEM_ram_rw', + 'value' => '0' + }, + '1' => { + 'name' => 'HVMMEM_ram_ro', + 'value' => '1' + }, + '2' => { + 'name' => 'HVMMEM_mmio_dm', + 'value' => '2' + }, + '3' => { + 'name' => 'HVMMEM_unused', + 'value' => '3' + }, + '4' => { + 'name' => 'HVMMEM_ioreq_server', + 'value' => '4' + } + }, + 'Name' => 'enum hvmmem_type_t', + 'PrivateABI' => 1, + 'Size' => '4', + 'Type' => 'Enum' + }, + '2731' => { + 'BaseType' => '2742', + 'Header' => 'xendevicemodel.h', + 'Line' => '31', + 'Name' => 'xendevicemodel_handle', + 'Size' => '64', + 'Type' => 'Typedef' + }, + '2742' => { + 'Header' => 'private.h', + 'Line' => '12', + 'Memb' => { + '0' => { + 'name' => 'logger', + 'offset' => '0', + 'type' => '2972' + }, + '1' => { + 'name' => 'logger_tofree', + 'offset' => '8', + 'type' => '2972' + }, + '2' => { + 'name' => 'flags', + 'offset' => '16', + 'type' => '74' + }, + '3' => { + 'name' => 'xcall', + 'offset' => '24', + 'type' => '2978' + }, + '4' => { + 'name' => 'fd', + 'offset' => '32', + 'type' => '67' + }, + '5' => { + 'name' => 'tc_ah', + 'offset' => '40', + 'type' => '2842' + } + }, + 'Name' => 'struct xendevicemodel_handle', + 'PrivateABI' => 1, + 'Size' => '64', + 'Type' => 'Struct' + }, + '2826' => { + 'BaseType' => '2837', + 'Header' => 'xencall.h', + 'Line' => '31', + 'Name' => 'xencall_handle', + 'Type' => 'Typedef' + }, + '2837' => { + 'Name' => 'struct xencall_handle', + 'PrivateABI' => 1, + 'Type' => 'Struct' + }, + '2842' => { + 'BaseType' => '2853', + 'Header' => 'xentoolcore_internal.h', + 'Line' => '83', + 'Name' => 'Xentoolcore__Active_Handle', + 'Size' => '24', + 'Type' => 'Typedef' + }, + '2853' => { + 'Header' => 'xentoolcore_internal.h', + 'Line' => '88', + 'Memb' => { + '0' => { + 'name' => 'restrict_callback', + 'offset' => '0', + 'type' => '2966' + }, + '1' => { + 'name' => 'entry', + 'offset' => '8', + 'type' => '2927' + } + }, + 'Name' => 'struct Xentoolcore__Active_Handle', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '2890' => { + 'BaseType' => '2901', + 'Header' => 'xentoolcore_internal.h', + 'Line' => '85', + 'Name' => 'Xentoolcore__Restrict_Callback', + 'Type' => 'Typedef' + }, + '2901' => { + 'Name' => 'int()(Xentoolcore__Active_Handle*, domid_t)', + 'Param' => { + '0' => { + 'type' => '2921' + }, + '1' => { + 'type' => '1282' + } + }, + 'Return' => '67', + 'Type' => 'Func' + }, + '2921' => { + 'BaseType' => '2842', + 'Name' => 'Xentoolcore__Active_Handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '2927' => { + 'Header' => 'xentoolcore_internal.h', + 'Line' => '90', + 'Memb' => { + '0' => { + 'name' => 'le_next', + 'offset' => '0', + 'type' => '2921' + }, + '1' => { + 'name' => 'le_prev', + 'offset' => '8', + 'type' => '2960' + } + }, + 'Name' => 'anon-struct-xentoolcore_internal.h-90', + 'PrivateABI' => 1, + 'Size' => '16', + 'Type' => 'Struct' + }, + '2960' => { + 'BaseType' => '2921', + 'Name' => 'Xentoolcore__Active_Handle**', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '2966' => { + 'BaseType' => '2890', + 'Name' => 'Xentoolcore__Restrict_Callback*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '2972' => { + 'BaseType' => '991', + 'Name' => 'xentoollog_logger*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '2978' => { + 'BaseType' => '2826', + 'Name' => 'xencall_handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '3120' => { + 'BaseType' => '2731', + 'Name' => 'xendevicemodel_handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '4495' => { + 'BaseType' => '1833', + 'Name' => 'struct xen_dm_op_modified_memory_extent*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '4707' => { + 'BaseType' => '60', + 'Name' => 'unsigned long*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '60' => { + 'Name' => 'unsigned long', + 'Size' => '8', + 'Type' => 'Intrinsic' + }, + '607' => { + 'Memb' => { + '0' => { + 'name' => 'gp_offset', + 'offset' => '0', + 'type' => '74' + }, + '1' => { + 'name' => 'fp_offset', + 'offset' => '4', + 'type' => '74' + }, + '2' => { + 'name' => 'overflow_arg_area', + 'offset' => '8', + 'type' => '152' + }, + '3' => { + 'name' => 'reg_save_area', + 'offset' => '16', + 'type' => '152' + } + }, + 'Name' => 'struct __va_list_tag', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '67' => { + 'Name' => 'int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '7352' => { + 'BaseType' => '1311', + 'Name' => 'ioservid_t*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '74' => { + 'Name' => 'unsigned int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '897' => { + 'Header' => 'xentoollog.h', + 'Line' => '30', + 'Memb' => { + '0' => { + 'name' => 'XTL_NONE', + 'value' => '0' + }, + '1' => { + 'name' => 'XTL_DEBUG', + 'value' => '1' + }, + '10' => { + 'name' => 'XTL_NUM_LEVELS', + 'value' => '10' + }, + '2' => { + 'name' => 'XTL_VERBOSE', + 'value' => '2' + }, + '3' => { + 'name' => 'XTL_DETAIL', + 'value' => '3' + }, + '4' => { + 'name' => 'XTL_PROGRESS', + 'value' => '4' + }, + '5' => { + 'name' => 'XTL_INFO', + 'value' => '5' + }, + '6' => { + 'name' => 'XTL_NOTICE', + 'value' => '6' + }, + '7' => { + 'name' => 'XTL_WARN', + 'value' => '7' + }, + '8' => { + 'name' => 'XTL_ERROR', + 'value' => '8' + }, + '9' => { + 'name' => 'XTL_CRITICAL', + 'value' => '9' + } + }, + 'Name' => 'enum xentoollog_level', + 'PrivateABI' => 1, + 'Size' => '4', + 'Type' => 'Enum' + }, + '95' => { + 'Name' => 'unsigned char', + 'Size' => '1', + 'Type' => 'Intrinsic' + }, + '980' => { + 'BaseType' => '897', + 'Header' => 'xentoollog.h', + 'Line' => '42', + 'Name' => 'xentoollog_level', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '991' => { + 'BaseType' => '1002', + 'Header' => 'xentoollog.h', + 'Line' => '44', + 'Name' => 'xentoollog_logger', + 'Size' => '24', + 'Type' => 'Typedef' + } + }, + 'UndefinedSymbols' => { + 'libxendevicemodel.so.1.3' => { + '_ITM_deregisterTMCloneTable' => 0, + '_ITM_registerTMCloneTable' => 0, + '_Jv_RegisterClasses' => 0, + '__cxa_finalize@GLIBC_2.2.5' => 0, + '__errno_location@GLIBC_2.2.5' => 0, + '__gmon_start__' => 0, + 'calloc@GLIBC_2.2.5' => 0, + 'close@GLIBC_2.2.5' => 0, + 'free@GLIBC_2.2.5' => 0, + 'ioctl@GLIBC_2.2.5' => 0, + 'memcpy@GLIBC_2.14' => 0, + 'open@GLIBC_2.2.5' => 0, + 'stderr@GLIBC_2.2.5' => 0, + 'xencall3@VERS_1.0' => 0, + 'xencall_alloc_buffer@VERS_1.0' => 0, + 'xencall_close@VERS_1.0' => 0, + 'xencall_free_buffer@VERS_1.0' => 0, + 'xencall_open@VERS_1.0' => 0, + 'xentoolcore__deregister_active_handle@VERS_1.0' => 0, + 'xentoolcore__register_active_handle@VERS_1.0' => 0, + 'xtl_createlogger_stdiostream@VERS_1.0' => 0, + 'xtl_log@VERS_1.0' => 0, + 'xtl_logger_destroy@VERS_1.0' => 0 + } + }, + 'WordSize' => '8' + }; diff --git a/tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump b/tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump new file mode 100644 index 0000000000..d8db4f4387 --- /dev/null +++ b/tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump @@ -0,0 +1,719 @@ +$VAR1 = { + 'ABI_DUMPER_VERSION' => '0.99.16', + 'ABI_DUMP_VERSION' => '3.2', + 'Arch' => 'x86_64', + 'GccVersion' => '6.3.0', + 'Headers' => { + 'xenevtchn.h' => 1 + }, + 'Language' => 'C', + 'LibraryName' => 'libxenevtchn.so.1.1', + 'LibraryVersion' => '1.1', + 'NameSpaces' => {}, + 'Needed' => { + 'libc.so.6' => 1, + 'libpthread.so.0' => 1, + 'libxentoolcore.so.1' => 1, + 'libxentoollog.so.1' => 1 + }, + 'PublicABI' => '1', + 'Sources' => { + 'core.c' => 1, + 'linux.c' => 1 + }, + 'SymbolInfo' => { + '1409' => { + 'Header' => 'xenevtchn.h', + 'Param' => { + '0' => { + 'name' => 'xce', + 'type' => '1505' + }, + '1' => { + 'name' => 'domid', + 'type' => '1190' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '91', + 'ShortName' => 'xenevtchn_restrict', + 'Source' => 'core.c', + 'SourceLine' => '79' + }, + '1511' => { + 'Header' => 'xenevtchn.h', + 'Param' => { + '0' => { + 'name' => 'xce', + 'type' => '1505' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '91', + 'ShortName' => 'xenevtchn_close', + 'Source' => 'core.c', + 'SourceLine' => '65' + }, + '1655' => { + 'Header' => 'xenevtchn.h', + 'Param' => { + '0' => { + 'name' => 'logger', + 'type' => '1403' + }, + '1' => { + 'name' => 'open_flags', + 'type' => '63' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '1505', + 'ShortName' => 'xenevtchn_open', + 'Source' => 'core.c', + 'SourceLine' => '31' + }, + '3779' => { + 'Header' => 'xenevtchn.h', + 'Param' => { + '0' => { + 'name' => 'xce', + 'type' => '1505' + }, + '1' => { + 'name' => 'port', + 'type' => '3550' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '91', + 'ShortName' => 'xenevtchn_unmask', + 'Source' => 'linux.c', + 'SourceLine' => '132' + }, + '3888' => { + 'Header' => 'xenevtchn.h', + 'Param' => { + '0' => { + 'name' => 'xce', + 'type' => '1505' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '3561', + 'ShortName' => 'xenevtchn_pending', + 'Source' => 'linux.c', + 'SourceLine' => '121' + }, + '3990' => { + 'Header' => 'xenevtchn.h', + 'Param' => { + '0' => { + 'name' => 'xce', + 'type' => '1505' + }, + '1' => { + 'name' => 'port', + 'type' => '3550' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '91', + 'ShortName' => 'xenevtchn_unbind', + 'Source' => 'linux.c', + 'SourceLine' => '111' + }, + '4111' => { + 'Header' => 'xenevtchn.h', + 'Param' => { + '0' => { + 'name' => 'xce', + 'type' => '1505' + }, + '1' => { + 'name' => 'virq', + 'type' => '63' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '3561', + 'ShortName' => 'xenevtchn_bind_virq', + 'Source' => 'linux.c', + 'SourceLine' => '100' + }, + '4232' => { + 'Header' => 'xenevtchn.h', + 'Param' => { + '0' => { + 'name' => 'xce', + 'type' => '1505' + }, + '1' => { + 'name' => 'domid', + 'type' => '2427' + }, + '2' => { + 'name' => 'remote_port', + 'type' => '3550' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '3561', + 'ShortName' => 'xenevtchn_bind_interdomain', + 'Source' => 'linux.c', + 'SourceLine' => '87' + }, + '4368' => { + 'Header' => 'xenevtchn.h', + 'Param' => { + '0' => { + 'name' => 'xce', + 'type' => '1505' + }, + '1' => { + 'name' => 'domid', + 'type' => '2427' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '3561', + 'ShortName' => 'xenevtchn_bind_unbound_port', + 'Source' => 'linux.c', + 'SourceLine' => '76' + }, + '4489' => { + 'Header' => 'xenevtchn.h', + 'Param' => { + '0' => { + 'name' => 'xce', + 'type' => '1505' + }, + '1' => { + 'name' => 'port', + 'type' => '3550' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '91', + 'ShortName' => 'xenevtchn_notify', + 'Source' => 'linux.c', + 'SourceLine' => '66' + }, + '4610' => { + 'Header' => 'xenevtchn.h', + 'Param' => { + '0' => { + 'name' => 'xce', + 'type' => '1505' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '91', + 'ShortName' => 'xenevtchn_fd', + 'Source' => 'linux.c', + 'SourceLine' => '61' + } + }, + 'SymbolVersion' => { + '_ITM_deregisterTMCloneTable' => 'xtl_logger_destroy@@VERS_1.0', + '_ITM_registerTMCloneTable' => 'xtl_logger_destroy@@VERS_1.0', + '_Jv_RegisterClasses' => 'xtl_logger_destroy@@VERS_1.0', + '__gmon_start__' => 'xtl_logger_destroy@@VERS_1.0', + 'xenevtchn_bind_interdomain' => 'xenevtchn_bind_interdomain@@VERS_1.0', + 'xenevtchn_bind_unbound_port' => 'xenevtchn_bind_unbound_port@@VERS_1.0', + 'xenevtchn_bind_virq' => 'xenevtchn_bind_virq@@VERS_1.0', + 'xenevtchn_close' => 'xenevtchn_close@@VERS_1.0', + 'xenevtchn_fd' => 'xenevtchn_fd@@VERS_1.0', + 'xenevtchn_notify' => 'xenevtchn_notify@@VERS_1.0', + 'xenevtchn_open' => 'xenevtchn_open@@VERS_1.0', + 'xenevtchn_pending' => 'xenevtchn_pending@@VERS_1.0', + 'xenevtchn_restrict' => 'xenevtchn_restrict@@VERS_1.1', + 'xenevtchn_unbind' => 'xenevtchn_unbind@@VERS_1.0', + 'xenevtchn_unmask' => 'xenevtchn_unmask@@VERS_1.0' + }, + 'Symbols' => { + 'libxenevtchn.so.1.1' => { + 'xenevtchn_bind_interdomain@@VERS_1.0' => 1, + 'xenevtchn_bind_unbound_port@@VERS_1.0' => 1, + 'xenevtchn_bind_virq@@VERS_1.0' => 1, + 'xenevtchn_close@@VERS_1.0' => 1, + 'xenevtchn_fd@@VERS_1.0' => 1, + 'xenevtchn_notify@@VERS_1.0' => 1, + 'xenevtchn_open@@VERS_1.0' => 1, + 'xenevtchn_pending@@VERS_1.0' => 1, + 'xenevtchn_restrict@@VERS_1.1' => 1, + 'xenevtchn_unbind@@VERS_1.0' => 1, + 'xenevtchn_unmask@@VERS_1.0' => 1 + } + }, + 'Target' => 'unix', + 'TypeInfo' => { + '1' => { + 'Name' => 'void', + 'Type' => 'Intrinsic' + }, + '1006' => { + 'BaseType' => '1017', + 'Header' => 'xentoollog.h', + 'Line' => '44', + 'Name' => 'xentoollog_logger', + 'Size' => '24', + 'Type' => 'Typedef' + }, + '1017' => { + 'Header' => 'xentoollog.h', + 'Line' => '45', + 'Memb' => { + '0' => { + 'name' => 'vmessage', + 'offset' => '0', + 'type' => '1114' + }, + '1' => { + 'name' => 'progress', + 'offset' => '8', + 'type' => '1156' + }, + '2' => { + 'name' => 'destroy', + 'offset' => '16', + 'type' => '1173' + } + }, + 'Name' => 'struct xentoollog_logger', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '1108' => { + 'BaseType' => '622', + 'Name' => 'struct __va_list_tag*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1114' => { + 'Name' => 'void(*)(struct xentoollog_logger*, xentoollog_level, int, char const*, char const*, struct __va_list_tag*)', + 'Param' => { + '0' => { + 'type' => '1403' + }, + '1' => { + 'type' => '995' + }, + '2' => { + 'type' => '91' + }, + '3' => { + 'type' => '830' + }, + '4' => { + 'type' => '830' + }, + '5' => { + 'type' => '1108' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1156' => { + 'Name' => 'void(*)(struct xentoollog_logger*, char const*, char const*, int, unsigned long, unsigned long)', + 'Param' => { + '0' => { + 'type' => '1403' + }, + '1' => { + 'type' => '830' + }, + '2' => { + 'type' => '830' + }, + '3' => { + 'type' => '91' + }, + '4' => { + 'type' => '70' + }, + '5' => { + 'type' => '70' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1173' => { + 'Name' => 'void(*)(struct xentoollog_logger*)', + 'Param' => { + '0' => { + 'type' => '1403' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1179' => { + 'BaseType' => '56', + 'Header' => 'stdint.h', + 'Line' => '49', + 'Name' => 'uint16_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '1190' => { + 'BaseType' => '1179', + 'Header' => 'xen.h', + 'Line' => '623', + 'Name' => 'domid_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '1202' => { + 'BaseType' => '1213', + 'Header' => 'xenevtchn.h', + 'Line' => '33', + 'Name' => 'xenevtchn_handle', + 'Size' => '48', + 'Type' => 'Typedef' + }, + '1213' => { + 'Header' => 'private.h', + 'Line' => '11', + 'Memb' => { + '0' => { + 'name' => 'logger', + 'offset' => '0', + 'type' => '1403' + }, + '1' => { + 'name' => 'logger_tofree', + 'offset' => '8', + 'type' => '1403' + }, + '2' => { + 'name' => 'fd', + 'offset' => '16', + 'type' => '91' + }, + '3' => { + 'name' => 'tc_ah', + 'offset' => '24', + 'type' => '1273' + } + }, + 'Name' => 'struct xenevtchn_handle', + 'PrivateABI' => 1, + 'Size' => '48', + 'Type' => 'Struct' + }, + '1273' => { + 'BaseType' => '1284', + 'Header' => 'xentoolcore_internal.h', + 'Line' => '83', + 'Name' => 'Xentoolcore__Active_Handle', + 'Size' => '24', + 'Type' => 'Typedef' + }, + '1284' => { + 'Header' => 'xentoolcore_internal.h', + 'Line' => '88', + 'Memb' => { + '0' => { + 'name' => 'restrict_callback', + 'offset' => '0', + 'type' => '1397' + }, + '1' => { + 'name' => 'entry', + 'offset' => '8', + 'type' => '1358' + } + }, + 'Name' => 'struct Xentoolcore__Active_Handle', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '1321' => { + 'BaseType' => '1332', + 'Header' => 'xentoolcore_internal.h', + 'Line' => '85', + 'Name' => 'Xentoolcore__Restrict_Callback', + 'Type' => 'Typedef' + }, + '1332' => { + 'Name' => 'int()(Xentoolcore__Active_Handle*, domid_t)', + 'Param' => { + '0' => { + 'type' => '1352' + }, + '1' => { + 'type' => '1190' + } + }, + 'Return' => '91', + 'Type' => 'Func' + }, + '134' => { + 'BaseType' => '1', + 'Name' => 'void*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1352' => { + 'BaseType' => '1273', + 'Name' => 'Xentoolcore__Active_Handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1358' => { + 'Header' => 'xentoolcore_internal.h', + 'Line' => '90', + 'Memb' => { + '0' => { + 'name' => 'le_next', + 'offset' => '0', + 'type' => '1352' + }, + '1' => { + 'name' => 'le_prev', + 'offset' => '8', + 'type' => '1391' + } + }, + 'Name' => 'anon-struct-xentoolcore_internal.h-90', + 'PrivateABI' => 1, + 'Size' => '16', + 'Type' => 'Struct' + }, + '1391' => { + 'BaseType' => '1352', + 'Name' => 'Xentoolcore__Active_Handle**', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1397' => { + 'BaseType' => '1321', + 'Name' => 'Xentoolcore__Restrict_Callback*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1403' => { + 'BaseType' => '1006', + 'Name' => 'xentoollog_logger*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '142' => { + 'Name' => 'char', + 'Size' => '1', + 'Type' => 'Intrinsic' + }, + '149' => { + 'BaseType' => '142', + 'Name' => 'char const', + 'Size' => '1', + 'Type' => 'Const' + }, + '1505' => { + 'BaseType' => '1202', + 'Name' => 'xenevtchn_handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '2427' => { + 'BaseType' => '63', + 'Header' => 'stdint.h', + 'Line' => '51', + 'Name' => 'uint32_t', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '3550' => { + 'BaseType' => '2427', + 'Header' => 'event_channel.h', + 'Line' => '79', + 'Name' => 'evtchn_port_t', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '3561' => { + 'BaseType' => '91', + 'Header' => 'xenevtchn.h', + 'Line' => '31', + 'Name' => 'xenevtchn_port_or_error_t', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '56' => { + 'Name' => 'unsigned short', + 'Size' => '2', + 'Type' => 'Intrinsic' + }, + '622' => { + 'Memb' => { + '0' => { + 'name' => 'gp_offset', + 'offset' => '0', + 'type' => '63' + }, + '1' => { + 'name' => 'fp_offset', + 'offset' => '4', + 'type' => '63' + }, + '2' => { + 'name' => 'overflow_arg_area', + 'offset' => '8', + 'type' => '134' + }, + '3' => { + 'name' => 'reg_save_area', + 'offset' => '16', + 'type' => '134' + } + }, + 'Name' => 'struct __va_list_tag', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '63' => { + 'Name' => 'unsigned int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '70' => { + 'Name' => 'unsigned long', + 'Size' => '8', + 'Type' => 'Intrinsic' + }, + '830' => { + 'BaseType' => '149', + 'Name' => 'char const*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '91' => { + 'Name' => 'int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '912' => { + 'Header' => 'xentoollog.h', + 'Line' => '30', + 'Memb' => { + '0' => { + 'name' => 'XTL_NONE', + 'value' => '0' + }, + '1' => { + 'name' => 'XTL_DEBUG', + 'value' => '1' + }, + '10' => { + 'name' => 'XTL_NUM_LEVELS', + 'value' => '10' + }, + '2' => { + 'name' => 'XTL_VERBOSE', + 'value' => '2' + }, + '3' => { + 'name' => 'XTL_DETAIL', + 'value' => '3' + }, + '4' => { + 'name' => 'XTL_PROGRESS', + 'value' => '4' + }, + '5' => { + 'name' => 'XTL_INFO', + 'value' => '5' + }, + '6' => { + 'name' => 'XTL_NOTICE', + 'value' => '6' + }, + '7' => { + 'name' => 'XTL_WARN', + 'value' => '7' + }, + '8' => { + 'name' => 'XTL_ERROR', + 'value' => '8' + }, + '9' => { + 'name' => 'XTL_CRITICAL', + 'value' => '9' + } + }, + 'Name' => 'enum xentoollog_level', + 'PrivateABI' => 1, + 'Size' => '4', + 'Type' => 'Enum' + }, + '995' => { + 'BaseType' => '912', + 'Header' => 'xentoollog.h', + 'Line' => '42', + 'Name' => 'xentoollog_level', + 'Size' => '4', + 'Type' => 'Typedef' + } + }, + 'UndefinedSymbols' => { + 'libxenevtchn.so.1.1' => { + '_ITM_deregisterTMCloneTable' => 0, + '_ITM_registerTMCloneTable' => 0, + '_Jv_RegisterClasses' => 0, + '__cxa_finalize@GLIBC_2.2.5' => 0, + '__gmon_start__' => 0, + 'close@GLIBC_2.2.5' => 0, + 'free@GLIBC_2.2.5' => 0, + 'ioctl@GLIBC_2.2.5' => 0, + 'malloc@GLIBC_2.2.5' => 0, + 'open@GLIBC_2.2.5' => 0, + 'read@GLIBC_2.2.5' => 0, + 'stderr@GLIBC_2.2.5' => 0, + 'write@GLIBC_2.2.5' => 0, + 'xentoolcore__deregister_active_handle@VERS_1.0' => 0, + 'xentoolcore__register_active_handle@VERS_1.0' => 0, + 'xtl_createlogger_stdiostream@VERS_1.0' => 0, + 'xtl_logger_destroy@VERS_1.0' => 0 + } + }, + 'WordSize' => '8' + }; diff --git a/tools/libs/abi/libxenforeignmemory.so.1.3-x86_64-abi.dump b/tools/libs/abi/libxenforeignmemory.so.1.3-x86_64-abi.dump new file mode 100644 index 0000000000..1c3b5bf2eb --- /dev/null +++ b/tools/libs/abi/libxenforeignmemory.so.1.3-x86_64-abi.dump @@ -0,0 +1,847 @@ +$VAR1 = { + 'ABI_DUMPER_VERSION' => '0.99.16', + 'ABI_DUMP_VERSION' => '3.2', + 'Arch' => 'x86_64', + 'GccVersion' => '6.3.0', + 'Headers' => { + 'xenforeignmemory.h' => 1 + }, + 'Language' => 'C', + 'LibraryName' => 'libxenforeignmemory.so.1.3', + 'LibraryVersion' => '1.3', + 'NameSpaces' => {}, + 'Needed' => { + 'libc.so.6' => 1, + 'libpthread.so.0' => 1, + 'libxentoolcore.so.1' => 1, + 'libxentoollog.so.1' => 1 + }, + 'PublicABI' => '1', + 'Sources' => { + 'core.c' => 1 + }, + 'SymbolInfo' => { + '1529' => { + 'Header' => 'xenforeignmemory.h', + 'Param' => { + '0' => { + 'name' => 'fmem', + 'type' => '1658' + }, + '1' => { + 'name' => 'fres', + 'type' => '1664' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '67', + 'ShortName' => 'xenforeignmemory_unmap_resource', + 'Source' => 'core.c', + 'SourceLine' => '182' + }, + '1670' => { + 'Header' => 'xenforeignmemory.h', + 'Param' => { + '0' => { + 'name' => 'fmem', + 'type' => '1658' + }, + '1' => { + 'name' => 'domid', + 'type' => '1167' + }, + '2' => { + 'name' => 'type', + 'type' => '74' + }, + '3' => { + 'name' => 'id', + 'type' => '74' + }, + '4' => { + 'name' => 'frame', + 'type' => '60' + }, + '5' => { + 'name' => 'nr_frames', + 'type' => '60' + }, + '6' => { + 'name' => 'paddr', + 'offset' => '0', + 'type' => '1971' + }, + '7' => { + 'name' => 'prot', + 'offset' => '8', + 'type' => '67' + }, + '8' => { + 'name' => 'flags', + 'offset' => '16', + 'type' => '67' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '1664', + 'ShortName' => 'xenforeignmemory_map_resource', + 'Source' => 'core.c', + 'SourceLine' => '140' + }, + '1977' => { + 'Header' => 'xenforeignmemory.h', + 'Param' => { + '0' => { + 'name' => 'fmem', + 'type' => '1658' + }, + '1' => { + 'name' => 'domid', + 'type' => '1167' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '67', + 'ShortName' => 'xenforeignmemory_restrict', + 'Source' => 'core.c', + 'SourceLine' => '134' + }, + '2073' => { + 'Header' => 'xenforeignmemory.h', + 'Param' => { + '0' => { + 'name' => 'fmem', + 'type' => '1658' + }, + '1' => { + 'name' => 'addr', + 'type' => '152' + }, + '2' => { + 'name' => 'num', + 'type' => '49' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '67', + 'ShortName' => 'xenforeignmemory_unmap', + 'Source' => 'core.c', + 'SourceLine' => '128' + }, + '2187' => { + 'Header' => 'xenforeignmemory.h', + 'Param' => { + '0' => { + 'name' => 'fmem', + 'type' => '1658' + }, + '1' => { + 'name' => 'dom', + 'type' => '1128' + }, + '2' => { + 'name' => 'prot', + 'type' => '67' + }, + '3' => { + 'name' => 'num', + 'type' => '49' + }, + '4' => { + 'name' => 'arr', + 'type' => '1161' + }, + '5' => { + 'name' => 'err', + 'type' => '1155' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '152', + 'ShortName' => 'xenforeignmemory_map', + 'Source' => 'core.c', + 'SourceLine' => '120' + }, + '2363' => { + 'Header' => 'xenforeignmemory.h', + 'Param' => { + '0' => { + 'name' => 'fmem', + 'type' => '1658' + }, + '1' => { + 'name' => 'dom', + 'type' => '1128' + }, + '2' => { + 'name' => 'addr', + 'type' => '152' + }, + '3' => { + 'name' => 'prot', + 'type' => '67' + }, + '4' => { + 'name' => 'flags', + 'type' => '67' + }, + '5' => { + 'name' => 'num', + 'type' => '49' + }, + '6' => { + 'name' => 'arr', + 'offset' => '0', + 'type' => '1161' + }, + '7' => { + 'name' => 'err', + 'offset' => '8', + 'type' => '1155' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '152', + 'ShortName' => 'xenforeignmemory_map2', + 'Source' => 'core.c', + 'SourceLine' => '83' + }, + '2724' => { + 'Header' => 'xenforeignmemory.h', + 'Param' => { + '0' => { + 'name' => 'fmem', + 'type' => '1658' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '67', + 'ShortName' => 'xenforeignmemory_close', + 'Source' => 'core.c', + 'SourceLine' => '69' + }, + '2868' => { + 'Header' => 'xenforeignmemory.h', + 'Param' => { + '0' => { + 'name' => 'logger', + 'type' => '1523' + }, + '1' => { + 'name' => 'open_flags', + 'type' => '74' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '1658', + 'ShortName' => 'xenforeignmemory_open', + 'Source' => 'core.c', + 'SourceLine' => '34' + } + }, + 'SymbolVersion' => { + '_ITM_deregisterTMCloneTable' => 'xtl_logger_destroy@@VERS_1.0', + '_ITM_registerTMCloneTable' => 'xtl_logger_destroy@@VERS_1.0', + '_Jv_RegisterClasses' => 'xtl_logger_destroy@@VERS_1.0', + '__gmon_start__' => 'xtl_logger_destroy@@VERS_1.0', + 'xenforeignmemory_close' => 'xenforeignmemory_close@@VERS_1.0', + 'xenforeignmemory_map' => 'xenforeignmemory_map@@VERS_1.0', + 'xenforeignmemory_map2' => 'xenforeignmemory_map2@@VERS_1.2', + 'xenforeignmemory_map_resource' => 'xenforeignmemory_map_resource@@VERS_1.3', + 'xenforeignmemory_open' => 'xenforeignmemory_open@@VERS_1.0', + 'xenforeignmemory_restrict' => 'xenforeignmemory_restrict@@VERS_1.1', + 'xenforeignmemory_unmap' => 'xenforeignmemory_unmap@@VERS_1.0', + 'xenforeignmemory_unmap_resource' => 'xenforeignmemory_unmap_resource@@VERS_1.3' + }, + 'Symbols' => { + 'libxenforeignmemory.so.1.3' => { + 'xenforeignmemory_close@@VERS_1.0' => 1, + 'xenforeignmemory_map2@@VERS_1.2' => 1, + 'xenforeignmemory_map@@VERS_1.0' => 1, + 'xenforeignmemory_map_resource@@VERS_1.3' => 1, + 'xenforeignmemory_open@@VERS_1.0' => 1, + 'xenforeignmemory_restrict@@VERS_1.1' => 1, + 'xenforeignmemory_unmap@@VERS_1.0' => 1, + 'xenforeignmemory_unmap_resource@@VERS_1.3' => 1 + } + }, + 'Target' => 'unix', + 'TypeInfo' => { + '1' => { + 'Name' => 'void', + 'Type' => 'Intrinsic' + }, + '102' => { + 'Name' => 'unsigned short', + 'Size' => '2', + 'Type' => 'Intrinsic' + }, + '1046' => { + 'BaseType' => '560', + 'Name' => 'struct __va_list_tag*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1052' => { + 'Name' => 'void(*)(struct xentoollog_logger*, xentoollog_level, int, char const*, char const*, struct __va_list_tag*)', + 'Param' => { + '0' => { + 'type' => '1523' + }, + '1' => { + 'type' => '933' + }, + '2' => { + 'type' => '67' + }, + '3' => { + 'type' => '768' + }, + '4' => { + 'type' => '768' + }, + '5' => { + 'type' => '1046' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1094' => { + 'Name' => 'void(*)(struct xentoollog_logger*, char const*, char const*, int, unsigned long, unsigned long)', + 'Param' => { + '0' => { + 'type' => '1523' + }, + '1' => { + 'type' => '768' + }, + '2' => { + 'type' => '768' + }, + '3' => { + 'type' => '67' + }, + '4' => { + 'type' => '60' + }, + '5' => { + 'type' => '60' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1111' => { + 'Name' => 'void(*)(struct xentoollog_logger*)', + 'Param' => { + '0' => { + 'type' => '1523' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1117' => { + 'BaseType' => '102', + 'Header' => 'stdint.h', + 'Line' => '49', + 'Name' => 'uint16_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '1128' => { + 'BaseType' => '74', + 'Header' => 'stdint.h', + 'Line' => '51', + 'Name' => 'uint32_t', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '1139' => { + 'BaseType' => '60', + 'Header' => 'xen.h', + 'Line' => '76', + 'Name' => 'xen_pfn_t', + 'Size' => '8', + 'Type' => 'Typedef' + }, + '1150' => { + 'BaseType' => '1139', + 'Name' => 'xen_pfn_t const', + 'Size' => '8', + 'Type' => 'Const' + }, + '1155' => { + 'BaseType' => '67', + 'Name' => 'int*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1161' => { + 'BaseType' => '1150', + 'Name' => 'xen_pfn_t const*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1167' => { + 'BaseType' => '1117', + 'Header' => 'xen.h', + 'Line' => '623', + 'Name' => 'domid_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '1179' => { + 'BaseType' => '1190', + 'Header' => 'xenforeignmemory.h', + 'Line' => '32', + 'Name' => 'xenforeignmemory_handle', + 'Size' => '56', + 'Type' => 'Typedef' + }, + '1190' => { + 'Header' => 'private.h', + 'Line' => '21', + 'Memb' => { + '0' => { + 'name' => 'logger', + 'offset' => '0', + 'type' => '1523' + }, + '1' => { + 'name' => 'logger_tofree', + 'offset' => '8', + 'type' => '1523' + }, + '2' => { + 'name' => 'flags', + 'offset' => '16', + 'type' => '74' + }, + '3' => { + 'name' => 'fd', + 'offset' => '20', + 'type' => '67' + }, + '4' => { + 'name' => 'tc_ah', + 'offset' => '24', + 'type' => '1393' + }, + '5' => { + 'name' => 'unimpl_errno', + 'offset' => '48', + 'type' => '67' + } + }, + 'Name' => 'struct xenforeignmemory_handle', + 'PrivateABI' => 1, + 'Size' => '56', + 'Type' => 'Struct' + }, + '1274' => { + 'BaseType' => '1285', + 'Header' => 'xenforeignmemory.h', + 'Line' => '141', + 'Name' => 'xenforeignmemory_resource_handle', + 'Size' => '48', + 'Type' => 'Typedef' + }, + '1285' => { + 'Header' => 'private.h', + 'Line' => '46', + 'Memb' => { + '0' => { + 'name' => 'domid', + 'offset' => '0', + 'type' => '1167' + }, + '1' => { + 'name' => 'type', + 'offset' => '4', + 'type' => '74' + }, + '2' => { + 'name' => 'id', + 'offset' => '8', + 'type' => '74' + }, + '3' => { + 'name' => 'frame', + 'offset' => '16', + 'type' => '60' + }, + '4' => { + 'name' => 'nr_frames', + 'offset' => '24', + 'type' => '60' + }, + '5' => { + 'name' => 'addr', + 'offset' => '32', + 'type' => '152' + }, + '6' => { + 'name' => 'prot', + 'offset' => '40', + 'type' => '67' + }, + '7' => { + 'name' => 'flags', + 'offset' => '44', + 'type' => '67' + } + }, + 'Name' => 'struct xenforeignmemory_resource_handle', + 'PrivateABI' => 1, + 'Size' => '48', + 'Type' => 'Struct' + }, + '1393' => { + 'BaseType' => '1404', + 'Header' => 'xentoolcore_internal.h', + 'Line' => '83', + 'Name' => 'Xentoolcore__Active_Handle', + 'Size' => '24', + 'Type' => 'Typedef' + }, + '1404' => { + 'Header' => 'xentoolcore_internal.h', + 'Line' => '88', + 'Memb' => { + '0' => { + 'name' => 'restrict_callback', + 'offset' => '0', + 'type' => '1517' + }, + '1' => { + 'name' => 'entry', + 'offset' => '8', + 'type' => '1478' + } + }, + 'Name' => 'struct Xentoolcore__Active_Handle', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '1441' => { + 'BaseType' => '1452', + 'Header' => 'xentoolcore_internal.h', + 'Line' => '85', + 'Name' => 'Xentoolcore__Restrict_Callback', + 'Type' => 'Typedef' + }, + '1452' => { + 'Name' => 'int()(Xentoolcore__Active_Handle*, domid_t)', + 'Param' => { + '0' => { + 'type' => '1472' + }, + '1' => { + 'type' => '1167' + } + }, + 'Return' => '67', + 'Type' => 'Func' + }, + '1472' => { + 'BaseType' => '1393', + 'Name' => 'Xentoolcore__Active_Handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1478' => { + 'Header' => 'xentoolcore_internal.h', + 'Line' => '90', + 'Memb' => { + '0' => { + 'name' => 'le_next', + 'offset' => '0', + 'type' => '1472' + }, + '1' => { + 'name' => 'le_prev', + 'offset' => '8', + 'type' => '1511' + } + }, + 'Name' => 'anon-struct-xentoolcore_internal.h-90', + 'PrivateABI' => 1, + 'Size' => '16', + 'Type' => 'Struct' + }, + '1511' => { + 'BaseType' => '1472', + 'Name' => 'Xentoolcore__Active_Handle**', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1517' => { + 'BaseType' => '1441', + 'Name' => 'Xentoolcore__Restrict_Callback*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '152' => { + 'BaseType' => '1', + 'Name' => 'void*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1523' => { + 'BaseType' => '944', + 'Name' => 'xentoollog_logger*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '160' => { + 'Name' => 'char', + 'Size' => '1', + 'Type' => 'Intrinsic' + }, + '1658' => { + 'BaseType' => '1179', + 'Name' => 'xenforeignmemory_handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1664' => { + 'BaseType' => '1274', + 'Name' => 'xenforeignmemory_resource_handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '167' => { + 'BaseType' => '160', + 'Name' => 'char const', + 'Size' => '1', + 'Type' => 'Const' + }, + '1971' => { + 'BaseType' => '152', + 'Name' => 'void**', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '49' => { + 'BaseType' => '60', + 'Header' => 'stddef.h', + 'Line' => '216', + 'Name' => 'size_t', + 'Size' => '8', + 'Type' => 'Typedef' + }, + '560' => { + 'Memb' => { + '0' => { + 'name' => 'gp_offset', + 'offset' => '0', + 'type' => '74' + }, + '1' => { + 'name' => 'fp_offset', + 'offset' => '4', + 'type' => '74' + }, + '2' => { + 'name' => 'overflow_arg_area', + 'offset' => '8', + 'type' => '152' + }, + '3' => { + 'name' => 'reg_save_area', + 'offset' => '16', + 'type' => '152' + } + }, + 'Name' => 'struct __va_list_tag', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '60' => { + 'Name' => 'unsigned long', + 'Size' => '8', + 'Type' => 'Intrinsic' + }, + '67' => { + 'Name' => 'int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '74' => { + 'Name' => 'unsigned int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '768' => { + 'BaseType' => '167', + 'Name' => 'char const*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '850' => { + 'Header' => 'xentoollog.h', + 'Line' => '30', + 'Memb' => { + '0' => { + 'name' => 'XTL_NONE', + 'value' => '0' + }, + '1' => { + 'name' => 'XTL_DEBUG', + 'value' => '1' + }, + '10' => { + 'name' => 'XTL_NUM_LEVELS', + 'value' => '10' + }, + '2' => { + 'name' => 'XTL_VERBOSE', + 'value' => '2' + }, + '3' => { + 'name' => 'XTL_DETAIL', + 'value' => '3' + }, + '4' => { + 'name' => 'XTL_PROGRESS', + 'value' => '4' + }, + '5' => { + 'name' => 'XTL_INFO', + 'value' => '5' + }, + '6' => { + 'name' => 'XTL_NOTICE', + 'value' => '6' + }, + '7' => { + 'name' => 'XTL_WARN', + 'value' => '7' + }, + '8' => { + 'name' => 'XTL_ERROR', + 'value' => '8' + }, + '9' => { + 'name' => 'XTL_CRITICAL', + 'value' => '9' + } + }, + 'Name' => 'enum xentoollog_level', + 'PrivateABI' => 1, + 'Size' => '4', + 'Type' => 'Enum' + }, + '933' => { + 'BaseType' => '850', + 'Header' => 'xentoollog.h', + 'Line' => '42', + 'Name' => 'xentoollog_level', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '944' => { + 'BaseType' => '955', + 'Header' => 'xentoollog.h', + 'Line' => '44', + 'Name' => 'xentoollog_logger', + 'Size' => '24', + 'Type' => 'Typedef' + }, + '955' => { + 'Header' => 'xentoollog.h', + 'Line' => '45', + 'Memb' => { + '0' => { + 'name' => 'vmessage', + 'offset' => '0', + 'type' => '1052' + }, + '1' => { + 'name' => 'progress', + 'offset' => '8', + 'type' => '1094' + }, + '2' => { + 'name' => 'destroy', + 'offset' => '16', + 'type' => '1111' + } + }, + 'Name' => 'struct xentoollog_logger', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + } + }, + 'UndefinedSymbols' => { + 'libxenforeignmemory.so.1.3' => { + '_ITM_deregisterTMCloneTable' => 0, + '_ITM_registerTMCloneTable' => 0, + '_Jv_RegisterClasses' => 0, + '__cxa_finalize@GLIBC_2.2.5' => 0, + '__errno_location@GLIBC_2.2.5' => 0, + '__gmon_start__' => 0, + 'calloc@GLIBC_2.2.5' => 0, + 'close@GLIBC_2.2.5' => 0, + 'free@GLIBC_2.2.5' => 0, + 'ioctl@GLIBC_2.2.5' => 0, + 'malloc@GLIBC_2.2.5' => 0, + 'memcpy@GLIBC_2.14' => 0, + 'mmap@GLIBC_2.2.5' => 0, + 'munmap@GLIBC_2.2.5' => 0, + 'open@GLIBC_2.2.5' => 0, + 'stderr@GLIBC_2.2.5' => 0, + 'usleep@GLIBC_2.2.5' => 0, + 'xentoolcore__deregister_active_handle@VERS_1.0' => 0, + 'xentoolcore__register_active_handle@VERS_1.0' => 0, + 'xtl_createlogger_stdiostream@VERS_1.0' => 0, + 'xtl_log@VERS_1.0' => 0, + 'xtl_logger_destroy@VERS_1.0' => 0 + } + }, + 'WordSize' => '8' + }; diff --git a/tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump b/tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump new file mode 100644 index 0000000000..94036c4192 --- /dev/null +++ b/tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump @@ -0,0 +1,1199 @@ +$VAR1 = { + 'ABI_DUMPER_VERSION' => '0.99.16', + 'ABI_DUMP_VERSION' => '3.2', + 'Arch' => 'x86_64', + 'GccVersion' => '6.3.0', + 'Headers' => { + 'xengnttab.h' => 1 + }, + 'Language' => 'C', + 'LibraryName' => 'libxengnttab.so.1.2', + 'LibraryVersion' => '1.2', + 'NameSpaces' => {}, + 'Needed' => { + 'libc.so.6' => 1, + 'libpthread.so.0' => 1, + 'libxentoolcore.so.1' => 1, + 'libxentoollog.so.1' => 1 + }, + 'PublicABI' => '1', + 'Sources' => { + 'gntshr_core.c' => 1, + 'gnttab_core.c' => 1 + }, + 'SymbolInfo' => { + '1575' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgt', + 'type' => '1666' + }, + '1' => { + 'name' => 'fd', + 'type' => '1139' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '67', + 'ShortName' => 'xengnttab_dmabuf_imp_release', + 'Source' => 'gnttab_core.c', + 'SourceLine' => '159' + }, + '1672' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgt', + 'type' => '1666' + }, + '1' => { + 'name' => 'domid', + 'type' => '1139' + }, + '2' => { + 'name' => 'fd', + 'type' => '1139' + }, + '3' => { + 'name' => 'count', + 'type' => '1139' + }, + '4' => { + 'name' => 'refs', + 'type' => '1167' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8' + }, + 'Return' => '67', + 'ShortName' => 'xengnttab_dmabuf_imp_to_refs', + 'Source' => 'gnttab_core.c', + 'SourceLine' => '153' + }, + '1829' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgt', + 'type' => '1666' + }, + '1' => { + 'name' => 'fd', + 'type' => '1139' + }, + '2' => { + 'name' => 'wait_to_ms', + 'type' => '1139' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '67', + 'ShortName' => 'xengnttab_dmabuf_exp_wait_released', + 'Source' => 'gnttab_core.c', + 'SourceLine' => '147' + }, + '1942' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgt', + 'type' => '1666' + }, + '1' => { + 'name' => 'domid', + 'type' => '1139' + }, + '2' => { + 'name' => 'flags', + 'type' => '1139' + }, + '3' => { + 'name' => 'count', + 'type' => '1139' + }, + '4' => { + 'name' => 'refs', + 'type' => '1173' + }, + '5' => { + 'name' => 'fd', + 'type' => '1167' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '67', + 'ShortName' => 'xengnttab_dmabuf_exp_from_refs', + 'Source' => 'gnttab_core.c', + 'SourceLine' => '139' + }, + '2121' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgt', + 'type' => '1666' + }, + '1' => { + 'name' => 'count', + 'type' => '1139' + }, + '2' => { + 'name' => 'segs', + 'type' => '2235' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '67', + 'ShortName' => 'xengnttab_grant_copy', + 'Source' => 'gnttab_core.c', + 'SourceLine' => '132' + }, + '2241' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgt', + 'type' => '1666' + }, + '1' => { + 'name' => 'start_address', + 'type' => '152' + }, + '2' => { + 'name' => 'count', + 'type' => '1139' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '67', + 'ShortName' => 'xengnttab_unmap', + 'Source' => 'gnttab_core.c', + 'SourceLine' => '127' + }, + '2355' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgt', + 'type' => '1666' + }, + '1' => { + 'name' => 'domid', + 'type' => '1139' + }, + '2' => { + 'name' => 'ref', + 'type' => '1139' + }, + '3' => { + 'name' => 'prot', + 'type' => '67' + }, + '4' => { + 'name' => 'notify_offset', + 'type' => '1139' + }, + '5' => { + 'name' => 'notify_port', + 'type' => '1309' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '152', + 'ShortName' => 'xengnttab_map_grant_ref_notify', + 'Source' => 'gnttab_core.c', + 'SourceLine' => '116' + }, + '2529' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgt', + 'type' => '1666' + }, + '1' => { + 'name' => 'count', + 'type' => '1139' + }, + '2' => { + 'name' => 'domid', + 'type' => '1139' + }, + '3' => { + 'name' => 'refs', + 'type' => '1167' + }, + '4' => { + 'name' => 'prot', + 'type' => '67' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8' + }, + 'Return' => '152', + 'ShortName' => 'xengnttab_map_domain_grant_refs', + 'Source' => 'gnttab_core.c', + 'SourceLine' => '106' + }, + '2691' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgt', + 'type' => '1666' + }, + '1' => { + 'name' => 'count', + 'type' => '1139' + }, + '2' => { + 'name' => 'domids', + 'type' => '1167' + }, + '3' => { + 'name' => 'refs', + 'type' => '1167' + }, + '4' => { + 'name' => 'prot', + 'type' => '67' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8' + }, + 'Return' => '152', + 'ShortName' => 'xengnttab_map_grant_refs', + 'Source' => 'gnttab_core.c', + 'SourceLine' => '97' + }, + '2854' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgt', + 'type' => '1666' + }, + '1' => { + 'name' => 'domid', + 'type' => '1139' + }, + '2' => { + 'name' => 'ref', + 'type' => '1139' + }, + '3' => { + 'name' => 'prot', + 'type' => '67' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '152', + 'ShortName' => 'xengnttab_map_grant_ref', + 'Source' => 'gnttab_core.c', + 'SourceLine' => '89' + }, + '2998' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgt', + 'type' => '1666' + }, + '1' => { + 'name' => 'count', + 'type' => '1139' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '67', + 'ShortName' => 'xengnttab_set_max_grants', + 'Source' => 'gnttab_core.c', + 'SourceLine' => '84' + }, + '3090' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgt', + 'type' => '1666' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '67', + 'ShortName' => 'xengnttab_fd', + 'Source' => 'gnttab_core.c', + 'SourceLine' => '79' + }, + '3137' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgt', + 'type' => '1666' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '67', + 'ShortName' => 'xengnttab_close', + 'Source' => 'gnttab_core.c', + 'SourceLine' => '65' + }, + '3281' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'logger', + 'type' => '1569' + }, + '1' => { + 'name' => 'open_flags', + 'type' => '74' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '1666', + 'ShortName' => 'xengnttab_open', + 'Source' => 'gnttab_core.c', + 'SourceLine' => '31' + }, + '5244' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgs', + 'type' => '5358' + }, + '1' => { + 'name' => 'start_address', + 'type' => '152' + }, + '2' => { + 'name' => 'count', + 'type' => '1139' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '67', + 'ShortName' => 'xengntshr_unshare', + 'Source' => 'gntshr_core.c', + 'SourceLine' => '88' + }, + '5364' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xcg', + 'type' => '5358' + }, + '1' => { + 'name' => 'domid', + 'type' => '1139' + }, + '2' => { + 'name' => 'ref', + 'type' => '1167' + }, + '3' => { + 'name' => 'writable', + 'type' => '67' + }, + '4' => { + 'name' => 'notify_offset', + 'type' => '1139' + }, + '5' => { + 'name' => 'notify_port', + 'type' => '1309' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '152', + 'ShortName' => 'xengntshr_share_page_notify', + 'Source' => 'gntshr_core.c', + 'SourceLine' => '79' + }, + '5542' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xcg', + 'type' => '5358' + }, + '1' => { + 'name' => 'domid', + 'type' => '1139' + }, + '2' => { + 'name' => 'count', + 'type' => '67' + }, + '3' => { + 'name' => 'refs', + 'type' => '1167' + }, + '4' => { + 'name' => 'writable', + 'type' => '67' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8' + }, + 'Return' => '152', + 'ShortName' => 'xengntshr_share_pages', + 'Source' => 'gntshr_core.c', + 'SourceLine' => '73' + }, + '5706' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgs', + 'type' => '5358' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '67', + 'ShortName' => 'xengntshr_fd', + 'Source' => 'gntshr_core.c', + 'SourceLine' => '68' + }, + '5753' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'xgs', + 'type' => '5358' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '67', + 'ShortName' => 'xengntshr_close', + 'Source' => 'gntshr_core.c', + 'SourceLine' => '55' + }, + '5873' => { + 'Header' => 'xengnttab.h', + 'Param' => { + '0' => { + 'name' => 'logger', + 'type' => '1569' + }, + '1' => { + 'name' => 'open_flags', + 'type' => '74' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '5358', + 'ShortName' => 'xengntshr_open', + 'Source' => 'gntshr_core.c', + 'SourceLine' => '25' + } + }, + 'SymbolVersion' => { + '_ITM_deregisterTMCloneTable' => 'xtl_logger_destroy@@VERS_1.0', + '_ITM_registerTMCloneTable' => 'xtl_logger_destroy@@VERS_1.0', + '_Jv_RegisterClasses' => 'xtl_logger_destroy@@VERS_1.0', + '__gmon_start__' => 'xtl_logger_destroy@@VERS_1.0', + 'xengntshr_close' => 'xengntshr_close@@VERS_1.0', + 'xengntshr_fd' => 'xengntshr_fd@@VERS_1.2', + 'xengntshr_open' => 'xengntshr_open@@VERS_1.0', + 'xengntshr_share_page_notify' => 'xengntshr_share_page_notify@@VERS_1.0', + 'xengntshr_share_pages' => 'xengntshr_share_pages@@VERS_1.0', + 'xengntshr_unshare' => 'xengntshr_unshare@@VERS_1.0', + 'xengnttab_close' => 'xengnttab_close@@VERS_1.0', + 'xengnttab_dmabuf_exp_from_refs' => 'xengnttab_dmabuf_exp_from_refs@@VERS_1.2', + 'xengnttab_dmabuf_exp_wait_released' => 'xengnttab_dmabuf_exp_wait_released@@VERS_1.2', + 'xengnttab_dmabuf_imp_release' => 'xengnttab_dmabuf_imp_release@@VERS_1.2', + 'xengnttab_dmabuf_imp_to_refs' => 'xengnttab_dmabuf_imp_to_refs@@VERS_1.2', + 'xengnttab_fd' => 'xengnttab_fd@@VERS_1.2', + 'xengnttab_grant_copy' => 'xengnttab_grant_copy@@VERS_1.1', + 'xengnttab_map_domain_grant_refs' => 'xengnttab_map_domain_grant_refs@@VERS_1.0', + 'xengnttab_map_grant_ref' => 'xengnttab_map_grant_ref@@VERS_1.0', + 'xengnttab_map_grant_ref_notify' => 'xengnttab_map_grant_ref_notify@@VERS_1.0', + 'xengnttab_map_grant_refs' => 'xengnttab_map_grant_refs@@VERS_1.0', + 'xengnttab_open' => 'xengnttab_open@@VERS_1.0', + 'xengnttab_set_max_grants' => 'xengnttab_set_max_grants@@VERS_1.0', + 'xengnttab_unmap' => 'xengnttab_unmap@@VERS_1.0' + }, + 'Symbols' => { + 'libxengnttab.so.1.2' => { + 'xengntshr_close@@VERS_1.0' => 1, + 'xengntshr_fd@@VERS_1.2' => 1, + 'xengntshr_open@@VERS_1.0' => 1, + 'xengntshr_share_page_notify@@VERS_1.0' => 1, + 'xengntshr_share_pages@@VERS_1.0' => 1, + 'xengntshr_unshare@@VERS_1.0' => 1, + 'xengnttab_close@@VERS_1.0' => 1, + 'xengnttab_dmabuf_exp_from_refs@@VERS_1.2' => 1, + 'xengnttab_dmabuf_exp_wait_released@@VERS_1.2' => 1, + 'xengnttab_dmabuf_imp_release@@VERS_1.2' => 1, + 'xengnttab_dmabuf_imp_to_refs@@VERS_1.2' => 1, + 'xengnttab_fd@@VERS_1.2' => 1, + 'xengnttab_grant_copy@@VERS_1.1' => 1, + 'xengnttab_map_domain_grant_refs@@VERS_1.0' => 1, + 'xengnttab_map_grant_ref@@VERS_1.0' => 1, + 'xengnttab_map_grant_ref_notify@@VERS_1.0' => 1, + 'xengnttab_map_grant_refs@@VERS_1.0' => 1, + 'xengnttab_open@@VERS_1.0' => 1, + 'xengnttab_set_max_grants@@VERS_1.0' => 1, + 'xengnttab_unmap@@VERS_1.0' => 1 + } + }, + 'Target' => 'unix', + 'TypeInfo' => { + '1' => { + 'Name' => 'void', + 'Type' => 'Intrinsic' + }, + '102' => { + 'Name' => 'unsigned short', + 'Size' => '2', + 'Type' => 'Intrinsic' + }, + '1057' => { + 'BaseType' => '571', + 'Name' => 'struct __va_list_tag*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1063' => { + 'Name' => 'void(*)(struct xentoollog_logger*, xentoollog_level, int, char const*, char const*, struct __va_list_tag*)', + 'Param' => { + '0' => { + 'type' => '1569' + }, + '1' => { + 'type' => '944' + }, + '2' => { + 'type' => '67' + }, + '3' => { + 'type' => '779' + }, + '4' => { + 'type' => '779' + }, + '5' => { + 'type' => '1057' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1105' => { + 'Name' => 'void(*)(struct xentoollog_logger*, char const*, char const*, int, unsigned long, unsigned long)', + 'Param' => { + '0' => { + 'type' => '1569' + }, + '1' => { + 'type' => '779' + }, + '2' => { + 'type' => '779' + }, + '3' => { + 'type' => '67' + }, + '4' => { + 'type' => '60' + }, + '5' => { + 'type' => '60' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1122' => { + 'Name' => 'void(*)(struct xentoollog_logger*)', + 'Param' => { + '0' => { + 'type' => '1569' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1128' => { + 'BaseType' => '102', + 'Header' => 'stdint.h', + 'Line' => '49', + 'Name' => 'uint16_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '1139' => { + 'BaseType' => '74', + 'Header' => 'stdint.h', + 'Line' => '51', + 'Name' => 'uint32_t', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '1150' => { + 'BaseType' => '1139', + 'Name' => 'uint32_t const', + 'Size' => '4', + 'Type' => 'Const' + }, + '1155' => { + 'BaseType' => '1128', + 'Header' => 'xen.h', + 'Line' => '623', + 'Name' => 'domid_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '116' => { + 'Name' => 'short', + 'Size' => '2', + 'Type' => 'Intrinsic' + }, + '1167' => { + 'BaseType' => '1139', + 'Name' => 'uint32_t*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1173' => { + 'BaseType' => '1150', + 'Name' => 'uint32_t const*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1179' => { + 'BaseType' => '1190', + 'Header' => 'xentoolcore_internal.h', + 'Line' => '83', + 'Name' => 'Xentoolcore__Active_Handle', + 'Size' => '24', + 'Type' => 'Typedef' + }, + '1190' => { + 'Header' => 'xentoolcore_internal.h', + 'Line' => '88', + 'Memb' => { + '0' => { + 'name' => 'restrict_callback', + 'offset' => '0', + 'type' => '1303' + }, + '1' => { + 'name' => 'entry', + 'offset' => '8', + 'type' => '1264' + } + }, + 'Name' => 'struct Xentoolcore__Active_Handle', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '1227' => { + 'BaseType' => '1238', + 'Header' => 'xentoolcore_internal.h', + 'Line' => '85', + 'Name' => 'Xentoolcore__Restrict_Callback', + 'Type' => 'Typedef' + }, + '1238' => { + 'Name' => 'int()(Xentoolcore__Active_Handle*, domid_t)', + 'Param' => { + '0' => { + 'type' => '1258' + }, + '1' => { + 'type' => '1155' + } + }, + 'Return' => '67', + 'Type' => 'Func' + }, + '1258' => { + 'BaseType' => '1179', + 'Name' => 'Xentoolcore__Active_Handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1264' => { + 'Header' => 'xentoolcore_internal.h', + 'Line' => '90', + 'Memb' => { + '0' => { + 'name' => 'le_next', + 'offset' => '0', + 'type' => '1258' + }, + '1' => { + 'name' => 'le_prev', + 'offset' => '8', + 'type' => '1297' + } + }, + 'Name' => 'anon-struct-xentoolcore_internal.h-90', + 'PrivateABI' => 1, + 'Size' => '16', + 'Type' => 'Struct' + }, + '1297' => { + 'BaseType' => '1258', + 'Name' => 'Xentoolcore__Active_Handle**', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1303' => { + 'BaseType' => '1227', + 'Name' => 'Xentoolcore__Restrict_Callback*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1309' => { + 'BaseType' => '1139', + 'Header' => 'event_channel.h', + 'Line' => '79', + 'Name' => 'evtchn_port_t', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '1320' => { + 'BaseType' => '1331', + 'Header' => 'xengnttab.h', + 'Line' => '110', + 'Name' => 'xengnttab_handle', + 'Size' => '48', + 'Type' => 'Typedef' + }, + '1331' => { + 'Header' => 'private.h', + 'Line' => '14', + 'Memb' => { + '0' => { + 'name' => 'logger', + 'offset' => '0', + 'type' => '1569' + }, + '1' => { + 'name' => 'logger_tofree', + 'offset' => '8', + 'type' => '1569' + }, + '2' => { + 'name' => 'fd', + 'offset' => '16', + 'type' => '67' + }, + '3' => { + 'name' => 'tc_ah', + 'offset' => '24', + 'type' => '1179' + } + }, + 'Name' => 'struct xengntdev_handle', + 'PrivateABI' => 1, + 'Size' => '48', + 'Type' => 'Struct' + }, + '1391' => { + 'Header' => 'xengnttab.h', + 'Line' => '274', + 'Memb' => { + '0' => { + 'name' => 'ref', + 'offset' => '0', + 'type' => '1139' + }, + '1' => { + 'name' => 'offset', + 'offset' => '4', + 'type' => '1128' + }, + '2' => { + 'name' => 'domid', + 'offset' => '6', + 'type' => '1128' + } + }, + 'Name' => 'anon-struct-xengnttab.h-274', + 'Size' => '8', + 'Type' => 'Struct' + }, + '1440' => { + 'Header' => 'xengnttab.h', + 'Line' => '272', + 'Memb' => { + '0' => { + 'name' => 'virt', + 'offset' => '0', + 'type' => '152' + }, + '1' => { + 'name' => 'foreign', + 'offset' => '0', + 'type' => '1391' + } + }, + 'Name' => 'union xengnttab_copy_ptr', + 'Size' => '8', + 'Type' => 'Union' + }, + '1478' => { + 'Header' => 'xengnttab.h', + 'Line' => '271', + 'Memb' => { + '0' => { + 'name' => 'source', + 'offset' => '0', + 'type' => '1440' + }, + '1' => { + 'name' => 'dest', + 'offset' => '8', + 'type' => '1440' + }, + '2' => { + 'name' => 'len', + 'offset' => '16', + 'type' => '1128' + }, + '3' => { + 'name' => 'flags', + 'offset' => '18', + 'type' => '1128' + }, + '4' => { + 'name' => 'status', + 'offset' => '20', + 'type' => '172' + } + }, + 'Name' => 'struct xengnttab_grant_copy_segment', + 'Size' => '24', + 'Type' => 'Struct' + }, + '152' => { + 'BaseType' => '1', + 'Name' => 'void*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1557' => { + 'BaseType' => '1478', + 'Header' => 'xengnttab.h', + 'Line' => '285', + 'Name' => 'xengnttab_grant_copy_segment_t', + 'Size' => '24', + 'Type' => 'Typedef' + }, + '1569' => { + 'BaseType' => '955', + 'Name' => 'xentoollog_logger*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '160' => { + 'Name' => 'char', + 'Size' => '1', + 'Type' => 'Intrinsic' + }, + '1666' => { + 'BaseType' => '1320', + 'Name' => 'xengnttab_handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '167' => { + 'BaseType' => '160', + 'Name' => 'char const', + 'Size' => '1', + 'Type' => 'Const' + }, + '172' => { + 'BaseType' => '116', + 'Header' => 'types.h', + 'Line' => '195', + 'Name' => 'int16_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '2235' => { + 'BaseType' => '1557', + 'Name' => 'xengnttab_grant_copy_segment_t*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '5226' => { + 'BaseType' => '1331', + 'Header' => 'xengnttab.h', + 'Line' => '363', + 'Name' => 'xengntshr_handle', + 'Size' => '48', + 'Type' => 'Typedef' + }, + '5358' => { + 'BaseType' => '5226', + 'Name' => 'xengntshr_handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '571' => { + 'Memb' => { + '0' => { + 'name' => 'gp_offset', + 'offset' => '0', + 'type' => '74' + }, + '1' => { + 'name' => 'fp_offset', + 'offset' => '4', + 'type' => '74' + }, + '2' => { + 'name' => 'overflow_arg_area', + 'offset' => '8', + 'type' => '152' + }, + '3' => { + 'name' => 'reg_save_area', + 'offset' => '16', + 'type' => '152' + } + }, + 'Name' => 'struct __va_list_tag', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '60' => { + 'Name' => 'unsigned long', + 'Size' => '8', + 'Type' => 'Intrinsic' + }, + '67' => { + 'Name' => 'int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '74' => { + 'Name' => 'unsigned int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '779' => { + 'BaseType' => '167', + 'Name' => 'char const*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '861' => { + 'Header' => 'xentoollog.h', + 'Line' => '30', + 'Memb' => { + '0' => { + 'name' => 'XTL_NONE', + 'value' => '0' + }, + '1' => { + 'name' => 'XTL_DEBUG', + 'value' => '1' + }, + '10' => { + 'name' => 'XTL_NUM_LEVELS', + 'value' => '10' + }, + '2' => { + 'name' => 'XTL_VERBOSE', + 'value' => '2' + }, + '3' => { + 'name' => 'XTL_DETAIL', + 'value' => '3' + }, + '4' => { + 'name' => 'XTL_PROGRESS', + 'value' => '4' + }, + '5' => { + 'name' => 'XTL_INFO', + 'value' => '5' + }, + '6' => { + 'name' => 'XTL_NOTICE', + 'value' => '6' + }, + '7' => { + 'name' => 'XTL_WARN', + 'value' => '7' + }, + '8' => { + 'name' => 'XTL_ERROR', + 'value' => '8' + }, + '9' => { + 'name' => 'XTL_CRITICAL', + 'value' => '9' + } + }, + 'Name' => 'enum xentoollog_level', + 'PrivateABI' => 1, + 'Size' => '4', + 'Type' => 'Enum' + }, + '944' => { + 'BaseType' => '861', + 'Header' => 'xentoollog.h', + 'Line' => '42', + 'Name' => 'xentoollog_level', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '955' => { + 'BaseType' => '966', + 'Header' => 'xentoollog.h', + 'Line' => '44', + 'Name' => 'xentoollog_logger', + 'Size' => '24', + 'Type' => 'Typedef' + }, + '966' => { + 'Header' => 'xentoollog.h', + 'Line' => '45', + 'Memb' => { + '0' => { + 'name' => 'vmessage', + 'offset' => '0', + 'type' => '1063' + }, + '1' => { + 'name' => 'progress', + 'offset' => '8', + 'type' => '1105' + }, + '2' => { + 'name' => 'destroy', + 'offset' => '16', + 'type' => '1122' + } + }, + 'Name' => 'struct xentoollog_logger', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + } + }, + 'UndefinedSymbols' => { + 'libxengnttab.so.1.2' => { + '_ITM_deregisterTMCloneTable' => 0, + '_ITM_registerTMCloneTable' => 0, + '_Jv_RegisterClasses' => 0, + '__cxa_finalize@GLIBC_2.2.5' => 0, + '__errno_location@GLIBC_2.2.5' => 0, + '__gmon_start__' => 0, + 'close@GLIBC_2.2.5' => 0, + 'free@GLIBC_2.2.5' => 0, + 'ioctl@GLIBC_2.2.5' => 0, + 'malloc@GLIBC_2.2.5' => 0, + 'memcpy@GLIBC_2.14' => 0, + 'mmap@GLIBC_2.2.5' => 0, + 'munmap@GLIBC_2.2.5' => 0, + 'open@GLIBC_2.2.5' => 0, + 'stderr@GLIBC_2.2.5' => 0, + 'usleep@GLIBC_2.2.5' => 0, + 'xentoolcore__deregister_active_handle@VERS_1.0' => 0, + 'xentoolcore__register_active_handle@VERS_1.0' => 0, + 'xentoolcore__restrict_by_dup2_null@VERS_1.0' => 0, + 'xtl_createlogger_stdiostream@VERS_1.0' => 0, + 'xtl_log@VERS_1.0' => 0, + 'xtl_logger_destroy@VERS_1.0' => 0 + } + }, + 'WordSize' => '8' + }; diff --git a/tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump b/tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump new file mode 100644 index 0000000000..c08096c2a8 --- /dev/null +++ b/tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump @@ -0,0 +1,597 @@ +$VAR1 = { + 'ABI_DUMPER_VERSION' => '0.99.16', + 'ABI_DUMP_VERSION' => '3.2', + 'Arch' => 'x86_64', + 'GccVersion' => '6.3.0', + 'Headers' => { + 'xenhypfs.h' => 1 + }, + 'Language' => 'C', + 'LibraryName' => 'libxenhypfs.so.1.0', + 'LibraryVersion' => '1.0', + 'NameSpaces' => {}, + 'Needed' => { + 'libc.so.6' => 1, + 'libpthread.so.0' => 1, + 'libxencall.so.1' => 1, + 'libxentoolcore.so.1' => 1, + 'libxentoollog.so.1' => 1, + 'libz.so.1' => 1 + }, + 'PublicABI' => '1', + 'Sources' => { + 'core.c' => 1 + }, + 'SymbolInfo' => { + '2102' => { + 'Header' => 'xenhypfs.h', + 'Param' => { + '0' => { + 'name' => 'fshdl', + 'type' => '3759' + }, + '1' => { + 'name' => 'path', + 'type' => '263' + }, + '2' => { + 'name' => 'val', + 'type' => '263' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '89', + 'ShortName' => 'xenhypfs_write', + 'Source' => 'core.c', + 'SourceLine' => '427' + }, + '3771' => { + 'Header' => 'xenhypfs.h', + 'Param' => { + '0' => { + 'name' => 'fshdl', + 'type' => '3759' + }, + '1' => { + 'name' => 'path', + 'type' => '263' + }, + '2' => { + 'name' => 'num_entries', + 'type' => '1949' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '4188', + 'ShortName' => 'xenhypfs_readdir', + 'Source' => 'core.c', + 'SourceLine' => '369' + }, + '4200' => { + 'Header' => 'xenhypfs.h', + 'Param' => { + '0' => { + 'name' => 'fshdl', + 'type' => '3759' + }, + '1' => { + 'name' => 'path', + 'type' => '263' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '60', + 'ShortName' => 'xenhypfs_read', + 'Source' => 'core.c', + 'SourceLine' => '281' + }, + '4829' => { + 'Header' => 'xenhypfs.h', + 'Param' => { + '0' => { + 'name' => 'fshdl', + 'type' => '3759' + }, + '1' => { + 'name' => 'path', + 'type' => '263' + }, + '2' => { + 'name' => 'dirent', + 'type' => '5448' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '296', + 'ShortName' => 'xenhypfs_read_raw', + 'Source' => 'core.c', + 'SourceLine' => '210' + }, + '6110' => { + 'Header' => 'xenhypfs.h', + 'Param' => { + '0' => { + 'name' => 'fshdl', + 'type' => '3759' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '89', + 'ShortName' => 'xenhypfs_close', + 'Source' => 'core.c', + 'SourceLine' => '83' + }, + '6205' => { + 'Header' => 'xenhypfs.h', + 'Param' => { + '0' => { + 'name' => 'logger', + 'type' => '2090' + }, + '1' => { + 'name' => 'open_flags', + 'type' => '213' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '3759', + 'ShortName' => 'xenhypfs_open', + 'Source' => 'core.c', + 'SourceLine' => '45' + } + }, + 'SymbolVersion' => { + '_ITM_deregisterTMCloneTable' => 'xtl_logger_destroy@@VERS_1.0', + '_ITM_registerTMCloneTable' => 'xtl_logger_destroy@@VERS_1.0', + '_Jv_RegisterClasses' => 'xtl_logger_destroy@@VERS_1.0', + '__gmon_start__' => 'xtl_logger_destroy@@VERS_1.0', + 'inflate' => 'xtl_logger_destroy@@VERS_1.0', + 'inflateEnd' => 'xtl_logger_destroy@@VERS_1.0', + 'inflateInit2_' => 'xtl_logger_destroy@@VERS_1.0', + 'xenhypfs_close' => 'xenhypfs_close@@VERS_1.0', + 'xenhypfs_open' => 'xenhypfs_open@@VERS_1.0', + 'xenhypfs_read' => 'xenhypfs_read@@VERS_1.0', + 'xenhypfs_read_raw' => 'xenhypfs_read_raw@@VERS_1.0', + 'xenhypfs_readdir' => 'xenhypfs_readdir@@VERS_1.0', + 'xenhypfs_write' => 'xenhypfs_write@@VERS_1.0' + }, + 'Symbols' => { + 'libxenhypfs.so.1.0' => { + 'xenhypfs_close@@VERS_1.0' => 1, + 'xenhypfs_open@@VERS_1.0' => 1, + 'xenhypfs_read@@VERS_1.0' => 1, + 'xenhypfs_read_raw@@VERS_1.0' => 1, + 'xenhypfs_readdir@@VERS_1.0' => 1, + 'xenhypfs_write@@VERS_1.0' => 1 + } + }, + 'Target' => 'unix', + 'TypeInfo' => { + '1' => { + 'Name' => 'void', + 'Type' => 'Intrinsic' + }, + '1433' => { + 'Header' => 'xentoollog.h', + 'Line' => '30', + 'Memb' => { + '0' => { + 'name' => 'XTL_NONE', + 'value' => '0' + }, + '1' => { + 'name' => 'XTL_DEBUG', + 'value' => '1' + }, + '10' => { + 'name' => 'XTL_NUM_LEVELS', + 'value' => '10' + }, + '2' => { + 'name' => 'XTL_VERBOSE', + 'value' => '2' + }, + '3' => { + 'name' => 'XTL_DETAIL', + 'value' => '3' + }, + '4' => { + 'name' => 'XTL_PROGRESS', + 'value' => '4' + }, + '5' => { + 'name' => 'XTL_INFO', + 'value' => '5' + }, + '6' => { + 'name' => 'XTL_NOTICE', + 'value' => '6' + }, + '7' => { + 'name' => 'XTL_WARN', + 'value' => '7' + }, + '8' => { + 'name' => 'XTL_ERROR', + 'value' => '8' + }, + '9' => { + 'name' => 'XTL_CRITICAL', + 'value' => '9' + } + }, + 'Name' => 'enum xentoollog_level', + 'PrivateABI' => 1, + 'Size' => '4', + 'Type' => 'Enum' + }, + '1516' => { + 'BaseType' => '1433', + 'Header' => 'xentoollog.h', + 'Line' => '42', + 'Name' => 'xentoollog_level', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '1527' => { + 'BaseType' => '1538', + 'Header' => 'xentoollog.h', + 'Line' => '44', + 'Name' => 'xentoollog_logger', + 'Size' => '24', + 'Type' => 'Typedef' + }, + '1538' => { + 'Header' => 'xentoollog.h', + 'Line' => '45', + 'Memb' => { + '0' => { + 'name' => 'vmessage', + 'offset' => '0', + 'type' => '1635' + }, + '1' => { + 'name' => 'progress', + 'offset' => '8', + 'type' => '1677' + }, + '2' => { + 'name' => 'destroy', + 'offset' => '16', + 'type' => '1694' + } + }, + 'Name' => 'struct xentoollog_logger', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '1629' => { + 'BaseType' => '365', + 'Name' => 'struct __va_list_tag*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1635' => { + 'Name' => 'void(*)(struct xentoollog_logger*, xentoollog_level, int, char const*, char const*, struct __va_list_tag*)', + 'Param' => { + '0' => { + 'type' => '2090' + }, + '1' => { + 'type' => '1516' + }, + '2' => { + 'type' => '89' + }, + '3' => { + 'type' => '263' + }, + '4' => { + 'type' => '263' + }, + '5' => { + 'type' => '1629' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1677' => { + 'Name' => 'void(*)(struct xentoollog_logger*, char const*, char const*, int, unsigned long, unsigned long)', + 'Param' => { + '0' => { + 'type' => '2090' + }, + '1' => { + 'type' => '263' + }, + '2' => { + 'type' => '263' + }, + '3' => { + 'type' => '89' + }, + '4' => { + 'type' => '231' + }, + '5' => { + 'type' => '231' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1694' => { + 'Name' => 'void(*)(struct xentoollog_logger*)', + 'Param' => { + '0' => { + 'type' => '2090' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1700' => { + 'BaseType' => '1711', + 'Header' => 'xenhypfs.h', + 'Line' => '27', + 'Name' => 'xenhypfs_handle', + 'Size' => '32', + 'Type' => 'Typedef' + }, + '1711' => { + 'Line' => '39', + 'Memb' => { + '0' => { + 'name' => 'logger', + 'offset' => '0', + 'type' => '2090' + }, + '1' => { + 'name' => 'logger_tofree', + 'offset' => '8', + 'type' => '2090' + }, + '2' => { + 'name' => 'flags', + 'offset' => '16', + 'type' => '213' + }, + '3' => { + 'name' => 'xcall', + 'offset' => '24', + 'type' => '2096' + } + }, + 'Name' => 'struct xenhypfs_handle', + 'PrivateABI' => 1, + 'Size' => '32', + 'Source' => 'core.c', + 'Type' => 'Struct' + }, + '1854' => { + 'Header' => 'xenhypfs.h', + 'Line' => '43', + 'Memb' => { + '0' => { + 'name' => 'name', + 'offset' => '0', + 'type' => '60' + }, + '1' => { + 'name' => 'size', + 'offset' => '8', + 'type' => '238' + }, + '2' => { + 'name' => 'type', + 'offset' => '16', + 'type' => '195' + }, + '3' => { + 'name' => 'encoding', + 'offset' => '18', + 'type' => '195' + }, + '4' => { + 'name' => 'flags', + 'offset' => '20', + 'type' => '213' + } + }, + 'Name' => 'struct xenhypfs_dirent', + 'Size' => '24', + 'Type' => 'Struct' + }, + '1927' => { + 'BaseType' => '1938', + 'Header' => 'xencall.h', + 'Line' => '31', + 'Name' => 'xencall_handle', + 'Type' => 'Typedef' + }, + '1938' => { + 'Name' => 'struct xencall_handle', + 'PrivateABI' => 1, + 'Type' => 'Struct' + }, + '1949' => { + 'BaseType' => '213', + 'Name' => 'unsigned int*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '195' => { + 'Name' => 'unsigned short', + 'Size' => '2', + 'Type' => 'Intrinsic' + }, + '2090' => { + 'BaseType' => '1527', + 'Name' => 'xentoollog_logger*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '2096' => { + 'BaseType' => '1927', + 'Name' => 'xencall_handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '213' => { + 'Name' => 'unsigned int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '231' => { + 'Name' => 'unsigned long', + 'Size' => '8', + 'Type' => 'Intrinsic' + }, + '238' => { + 'BaseType' => '231', + 'Header' => 'stddef.h', + 'Line' => '216', + 'Name' => 'size_t', + 'Size' => '8', + 'Type' => 'Typedef' + }, + '263' => { + 'BaseType' => '73', + 'Name' => 'char const*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '296' => { + 'BaseType' => '1', + 'Name' => 'void*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '365' => { + 'Memb' => { + '0' => { + 'name' => 'gp_offset', + 'offset' => '0', + 'type' => '213' + }, + '1' => { + 'name' => 'fp_offset', + 'offset' => '4', + 'type' => '213' + }, + '2' => { + 'name' => 'overflow_arg_area', + 'offset' => '8', + 'type' => '296' + }, + '3' => { + 'name' => 'reg_save_area', + 'offset' => '16', + 'type' => '296' + } + }, + 'Name' => 'struct __va_list_tag', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '3759' => { + 'BaseType' => '1700', + 'Name' => 'xenhypfs_handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '4188' => { + 'BaseType' => '1854', + 'Name' => 'struct xenhypfs_dirent*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '5448' => { + 'BaseType' => '4188', + 'Name' => 'struct xenhypfs_dirent**', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '60' => { + 'BaseType' => '66', + 'Name' => 'char*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '66' => { + 'Name' => 'char', + 'Size' => '1', + 'Type' => 'Intrinsic' + }, + '73' => { + 'BaseType' => '66', + 'Name' => 'char const', + 'Size' => '1', + 'Type' => 'Const' + }, + '89' => { + 'Name' => 'int', + 'Size' => '4', + 'Type' => 'Intrinsic' + } + }, + 'UndefinedSymbols' => { + 'libxenhypfs.so.1.0' => { + '_ITM_deregisterTMCloneTable' => 0, + '_ITM_registerTMCloneTable' => 0, + '_Jv_RegisterClasses' => 0, + '__cxa_finalize@GLIBC_2.2.5' => 0, + '__errno_location@GLIBC_2.2.5' => 0, + '__gmon_start__' => 0, + 'asprintf@GLIBC_2.2.5' => 0, + 'calloc@GLIBC_2.2.5' => 0, + 'free@GLIBC_2.2.5' => 0, + 'inflate' => 0, + 'inflateEnd' => 0, + 'inflateInit2_' => 0, + 'malloc@GLIBC_2.2.5' => 0, + 'memcpy@GLIBC_2.14' => 0, + 'realloc@GLIBC_2.2.5' => 0, + 'stderr@GLIBC_2.2.5' => 0, + 'strcmp@GLIBC_2.2.5' => 0, + 'strcpy@GLIBC_2.2.5' => 0, + 'strrchr@GLIBC_2.2.5' => 0, + 'strtoll@GLIBC_2.2.5' => 0, + 'strtoull@GLIBC_2.2.5' => 0, + 'xencall5@VERS_1.0' => 0, + 'xencall_alloc_buffer@VERS_1.0' => 0, + 'xencall_close@VERS_1.0' => 0, + 'xencall_free_buffer@VERS_1.0' => 0, + 'xencall_open@VERS_1.0' => 0, + 'xtl_createlogger_stdiostream@VERS_1.0' => 0, + 'xtl_logger_destroy@VERS_1.0' => 0 + } + }, + 'WordSize' => '8' + }; diff --git a/tools/libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump b/tools/libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump new file mode 100644 index 0000000000..5237521138 --- /dev/null +++ b/tools/libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump @@ -0,0 +1,1711 @@ +$VAR1 = { + 'ABI_DUMPER_VERSION' => '0.99.16', + 'ABI_DUMP_VERSION' => '3.2', + 'Arch' => 'x86_64', + 'GccVersion' => '6.3.0', + 'Headers' => { + 'xenstore.h' => 1, + 'xenstore_lib.h' => 1 + }, + 'Language' => 'C', + 'LibraryName' => 'libxenstore.so.3.0.3', + 'LibraryVersion' => '3.0.3', + 'NameSpaces' => {}, + 'Needed' => { + 'libc.so.6' => 1, + 'libdl.so.2' => 1, + 'libpthread.so.0' => 1, + 'libxentoolcore.so.1' => 1 + }, + 'PublicABI' => '1', + 'Sources' => { + 'xs.c' => 1, + 'xs_lib.c' => 1 + }, + 'SymbolInfo' => { + '10479' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 'num', + 'type' => '3872' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '1800', + 'ShortName' => 'xs_read_watch', + 'Source' => 'xs.c', + 'SourceLine' => '975' + }, + '10577' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '1800', + 'ShortName' => 'xs_check_watch', + 'Source' => 'xs.c', + 'SourceLine' => '962' + }, + '11607' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 'path', + 'type' => '1777' + }, + '2' => { + 'name' => 'token', + 'type' => '1777' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '4499', + 'ShortName' => 'xs_watch', + 'Source' => 'xs.c', + 'SourceLine' => '811' + }, + '12375' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 'domid', + 'type' => '68' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '4499', + 'ShortName' => 'xs_restrict', + 'Source' => 'xs.c', + 'SourceLine' => '801' + }, + '12436' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 't', + 'type' => '3777' + }, + '2' => { + 'name' => 'path', + 'type' => '1777' + }, + '3' => { + 'name' => 'perms', + 'type' => '12799' + }, + '4' => { + 'name' => 'num_perms', + 'type' => '68' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8' + }, + 'Return' => '4499', + 'ShortName' => 'xs_set_permissions', + 'Source' => 'xs.c', + 'SourceLine' => '763' + }, + '12840' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 't', + 'type' => '3777' + }, + '2' => { + 'name' => 'path', + 'type' => '1777' + }, + '3' => { + 'name' => 'num', + 'type' => '3872' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '12799', + 'ShortName' => 'xs_get_permissions', + 'Source' => 'xs.c', + 'SourceLine' => '729' + }, + '13192' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 't', + 'type' => '3777' + }, + '2' => { + 'name' => 'path', + 'type' => '1777' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '4499', + 'ShortName' => 'xs_rm', + 'Source' => 'xs.c', + 'SourceLine' => '720' + }, + '13333' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 't', + 'type' => '3777' + }, + '2' => { + 'name' => 'path', + 'type' => '1777' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '4499', + 'ShortName' => 'xs_mkdir', + 'Source' => 'xs.c', + 'SourceLine' => '711' + }, + '13474' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 't', + 'type' => '3777' + }, + '2' => { + 'name' => 'path', + 'type' => '1777' + }, + '3' => { + 'name' => 'data', + 'type' => '1862' + }, + '4' => { + 'name' => 'len', + 'type' => '68' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8' + }, + 'Return' => '4499', + 'ShortName' => 'xs_write', + 'Source' => 'xs.c', + 'SourceLine' => '694' + }, + '13666' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 't', + 'type' => '3777' + }, + '2' => { + 'name' => 'path', + 'type' => '1777' + }, + '3' => { + 'name' => 'len', + 'type' => '3872' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '259', + 'ShortName' => 'xs_read', + 'Source' => 'xs.c', + 'SourceLine' => '685' + }, + '13808' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 't', + 'type' => '3777' + }, + '2' => { + 'name' => 'path', + 'type' => '1777' + }, + '3' => { + 'name' => 'num', + 'type' => '3872' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '1800', + 'ShortName' => 'xs_directory', + 'Source' => 'xs.c', + 'SourceLine' => '664' + }, + '16916' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'xsh', + 'type' => '5580' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '1', + 'ShortName' => 'xs_close', + 'Source' => 'xs.c', + 'SourceLine' => '385' + }, + '16984' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '1', + 'ShortName' => 'xs_daemon_close', + 'Source' => 'xs.c', + 'SourceLine' => '363' + }, + '17253' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '1', + 'ShortName' => 'xs_daemon_destroy_postfork', + 'Source' => 'xs.c', + 'SourceLine' => '357' + }, + '17797' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'flags', + 'type' => '75' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '5580', + 'ShortName' => 'xs_open', + 'Source' => 'xs.c', + 'SourceLine' => '313' + }, + '17942' => { + 'Header' => 'xenstore.h', + 'Return' => '5580', + 'ShortName' => 'xs_domain_open', + 'Source' => 'xs.c', + 'SourceLine' => '308' + }, + '17996' => { + 'Header' => 'xenstore.h', + 'Return' => '5580', + 'ShortName' => 'xs_daemon_open_readonly', + 'Source' => 'xs.c', + 'SourceLine' => '303' + }, + '18050' => { + 'Header' => 'xenstore.h', + 'Return' => '5580', + 'ShortName' => 'xs_daemon_open', + 'Source' => 'xs.c', + 'SourceLine' => '298' + }, + '19113' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '96', + 'ShortName' => 'xs_fileno', + 'Source' => 'xs.c', + 'SourceLine' => '174' + }, + '19920' => { + 'Header' => 'xenstore_lib.h', + 'Param' => { + '0' => { + 'name' => 'strings', + 'type' => '1777' + }, + '1' => { + 'name' => 'len', + 'type' => '68' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '68', + 'ShortName' => 'xs_count_strings', + 'Source' => 'xs_lib.c', + 'SourceLine' => '177' + }, + '20032' => { + 'Header' => 'xenstore_lib.h', + 'Param' => { + '0' => { + 'name' => 'perm', + 'type' => '21550' + }, + '1' => { + 'name' => 'buffer', + 'type' => '294' + }, + '2' => { + 'name' => 'buf_len', + 'type' => '312' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '4499', + 'ShortName' => 'xs_perm_to_string', + 'Source' => 'xs_lib.c', + 'SourceLine' => '152' + }, + '20055' => { + 'Header' => 'xenstore_lib.h', + 'Param' => { + '0' => { + 'name' => 'perms', + 'type' => '12799' + }, + '1' => { + 'name' => 'num', + 'type' => '68' + }, + '2' => { + 'name' => 'strings', + 'type' => '1777' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '4499', + 'ShortName' => 'xs_strings_to_perms', + 'Source' => 'xs_lib.c', + 'SourceLine' => '114' + }, + '20104' => { + 'Header' => 'xenstore_lib.h', + 'Param' => { + '0' => { + 'name' => 'fd', + 'type' => '96' + }, + '1' => { + 'name' => 'data', + 'type' => '1862' + }, + '2' => { + 'name' => 'len', + 'type' => '68' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '4499', + 'ShortName' => 'xs_write_all', + 'Source' => 'xs_lib.c', + 'SourceLine' => '96' + }, + '20149' => { + 'Header' => 'xenstore_lib.h', + 'Line' => '61', + 'Return' => '1777', + 'ShortName' => 'xs_daemon_socket_ro', + 'Source' => 'xs_lib.c', + 'SourceLine' => '64' + }, + '20160' => { + 'Header' => 'xenstore_lib.h', + 'Line' => '60', + 'Return' => '1777', + 'ShortName' => 'xs_daemon_socket', + 'Source' => 'xs_lib.c', + 'SourceLine' => '59' + }, + '20171' => { + 'Header' => 'xenstore_lib.h', + 'Line' => '62', + 'Return' => '1777', + 'ShortName' => 'xs_domain_dev', + 'Source' => 'xs_lib.c', + 'SourceLine' => '75' + }, + '22199' => { + 'Header' => 'xenstore_lib.h', + 'Return' => '1777', + 'ShortName' => 'xs_daemon_tdb', + 'Source' => 'xs_lib.c', + 'SourceLine' => '52' + }, + '22473' => { + 'Header' => 'xenstore_lib.h', + 'Return' => '1777', + 'ShortName' => 'xs_daemon_rundir', + 'Source' => 'xs_lib.c', + 'SourceLine' => '34' + }, + '22547' => { + 'Header' => 'xenstore_lib.h', + 'Return' => '1777', + 'ShortName' => 'xs_daemon_rootdir', + 'Source' => 'xs_lib.c', + 'SourceLine' => '28' + }, + '4506' => { + 'Header' => 'xenstore_lib.h', + 'Param' => { + '0' => { + 'name' => 'out', + 'type' => '294' + }, + '1' => { + 'name' => 'out_len_r', + 'type' => '3872' + }, + '2' => { + 'name' => 'in', + 'type' => '1777' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '1', + 'ShortName' => 'unsanitise_value', + 'Source' => 'xs.c', + 'SourceLine' => '1425' + }, + '4736' => { + 'Header' => 'xenstore_lib.h', + 'Param' => { + '0' => { + 'name' => 'ebuf', + 'type' => '5164' + }, + '1' => { + 'name' => 'val', + 'type' => '1777' + }, + '2' => { + 'name' => 'len', + 'type' => '68' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '294', + 'ShortName' => 'sanitise_value', + 'Source' => 'xs.c', + 'SourceLine' => '1375' + }, + '5191' => { + 'Header' => 'xenstore_lib.h', + 'Param' => { + '0' => { + 'name' => 'ebuf', + 'type' => '5164' + }, + '1' => { + 'name' => 'min_avail', + 'type' => '96' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '294', + 'ShortName' => 'expanding_buffer_ensure', + 'Source' => 'xs.c', + 'SourceLine' => '1354' + }, + '6983' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 'cmd', + 'type' => '1777' + }, + '2' => { + 'name' => 'data', + 'type' => '259' + }, + '3' => { + 'name' => 'len', + 'type' => '68' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '294', + 'ShortName' => 'xs_debug_command', + 'Source' => 'xs.c', + 'SourceLine' => '1229' + }, + '7122' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 'cmd', + 'type' => '1777' + }, + '2' => { + 'name' => 'data', + 'type' => '259' + }, + '3' => { + 'name' => 'len', + 'type' => '68' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '294', + 'ShortName' => 'xs_control_command', + 'Source' => 'xs.c', + 'SourceLine' => '1215' + }, + '7297' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'domid', + 'type' => '96' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '96', + 'ShortName' => 'xs_suspend_evtchn_port', + 'Source' => 'xs.c', + 'SourceLine' => '1187' + }, + '7669' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 'domid', + 'type' => '68' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '4499', + 'ShortName' => 'xs_is_domain_introduced', + 'Source' => 'xs.c', + 'SourceLine' => '1178' + }, + '7912' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'parent', + 'type' => '1777' + }, + '1' => { + 'name' => 'child', + 'type' => '1777' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '4499', + 'ShortName' => 'xs_path_is_subpath', + 'Source' => 'xs.c', + 'SourceLine' => '1161' + }, + '8044' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 'domid', + 'type' => '68' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '294', + 'ShortName' => 'xs_get_domain_path', + 'Source' => 'xs.c', + 'SourceLine' => '1152' + }, + '8230' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 'domid', + 'type' => '68' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '4499', + 'ShortName' => 'xs_resume_domain', + 'Source' => 'xs.c', + 'SourceLine' => '1147' + }, + '8345' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 'domid', + 'type' => '68' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '4499', + 'ShortName' => 'xs_release_domain', + 'Source' => 'xs.c', + 'SourceLine' => '1141' + }, + '8647' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 'domid', + 'type' => '68' + }, + '2' => { + 'name' => 'target', + 'type' => '68' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '4499', + 'ShortName' => 'xs_set_target', + 'Source' => 'xs.c', + 'SourceLine' => '1111' + }, + '8936' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 'domid', + 'type' => '68' + }, + '2' => { + 'name' => 'mfn', + 'type' => '75' + }, + '3' => { + 'name' => 'eventchn', + 'type' => '68' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx' + }, + 'Return' => '4499', + 'ShortName' => 'xs_introduce_domain', + 'Source' => 'xs.c', + 'SourceLine' => '1087' + }, + '9338' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 't', + 'type' => '3777' + }, + '2' => { + 'name' => 'abort', + 'type' => '4499' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '4499', + 'ShortName' => 'xs_transaction_end', + 'Source' => 'xs.c', + 'SourceLine' => '1070' + }, + '9495' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '3777', + 'ShortName' => 'xs_transaction_start', + 'Source' => 'xs.c', + 'SourceLine' => '1050' + }, + '9682' => { + 'Header' => 'xenstore.h', + 'Param' => { + '0' => { + 'name' => 'h', + 'type' => '5580' + }, + '1' => { + 'name' => 'path', + 'type' => '1777' + }, + '2' => { + 'name' => 'token', + 'type' => '1777' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '4499', + 'ShortName' => 'xs_unwatch', + 'Source' => 'xs.c', + 'SourceLine' => '983' + } + }, + 'SymbolVersion' => { + '_ITM_deregisterTMCloneTable' => 'xentoolcore__restrict_by_dup2_null@@VERS_1.0', + '_ITM_registerTMCloneTable' => 'xentoolcore__restrict_by_dup2_null@@VERS_1.0', + '_Jv_RegisterClasses' => 'xentoolcore__restrict_by_dup2_null@@VERS_1.0', + '__gmon_start__' => 'xentoolcore__restrict_by_dup2_null@@VERS_1.0' + }, + 'Symbols' => { + 'libxenstore.so.3.0.3' => { + '_fini' => 1, + '_init' => 1, + 'expanding_buffer_ensure' => 1, + 'sanitise_value' => 1, + 'unsanitise_value' => 1, + 'xs_check_watch' => 1, + 'xs_close' => 1, + 'xs_control_command' => 1, + 'xs_count_strings' => 1, + 'xs_daemon_close' => 1, + 'xs_daemon_destroy_postfork' => 1, + 'xs_daemon_open' => 1, + 'xs_daemon_open_readonly' => 1, + 'xs_daemon_rootdir' => 1, + 'xs_daemon_rundir' => 1, + 'xs_daemon_socket' => 1, + 'xs_daemon_socket_ro' => 1, + 'xs_daemon_tdb' => 1, + 'xs_debug_command' => 1, + 'xs_directory' => 1, + 'xs_domain_dev' => 1, + 'xs_domain_open' => 1, + 'xs_fileno' => 1, + 'xs_get_domain_path' => 1, + 'xs_get_permissions' => 1, + 'xs_introduce_domain' => 1, + 'xs_is_domain_introduced' => 1, + 'xs_mkdir' => 1, + 'xs_open' => 1, + 'xs_path_is_subpath' => 1, + 'xs_perm_to_string' => 1, + 'xs_read' => 1, + 'xs_read_watch' => 1, + 'xs_release_domain' => 1, + 'xs_restrict' => 1, + 'xs_resume_domain' => 1, + 'xs_rm' => 1, + 'xs_set_permissions' => 1, + 'xs_set_target' => 1, + 'xs_strings_to_perms' => 1, + 'xs_suspend_evtchn_port' => 1, + 'xs_transaction_end' => 1, + 'xs_transaction_start' => 1, + 'xs_unwatch' => 1, + 'xs_watch' => 1, + 'xs_write' => 1, + 'xs_write_all' => 1 + } + }, + 'Target' => 'unix', + 'TypeInfo' => { + '1' => { + 'Name' => 'void', + 'Type' => 'Intrinsic' + }, + '103' => { + 'Name' => 'long', + 'Size' => '8', + 'Type' => 'Intrinsic' + }, + '12799' => { + 'BaseType' => '3704', + 'Name' => 'struct xs_permissions*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1777' => { + 'BaseType' => '307', + 'Name' => 'char const*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1800' => { + 'BaseType' => '294', + 'Name' => 'char**', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1862' => { + 'BaseType' => '1868', + 'Name' => 'void const*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1868' => { + 'BaseType' => '1', + 'Name' => 'void const', + 'Type' => 'Const' + }, + '209' => { + 'BaseType' => '96', + 'Name' => 'int[2]', + 'Size' => '8', + 'Type' => 'Array' + }, + '21313' => { + 'BaseType' => '3704', + 'Name' => 'struct xs_permissions const', + 'Size' => '8', + 'Type' => 'Const' + }, + '21550' => { + 'BaseType' => '21313', + 'Name' => 'struct xs_permissions const*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '259' => { + 'BaseType' => '1', + 'Name' => 'void*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '294' => { + 'BaseType' => '300', + 'Name' => 'char*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '300' => { + 'Name' => 'char', + 'Size' => '1', + 'Type' => 'Intrinsic' + }, + '307' => { + 'BaseType' => '300', + 'Name' => 'char const', + 'Size' => '1', + 'Type' => 'Const' + }, + '312' => { + 'BaseType' => '75', + 'Header' => 'stddef.h', + 'Line' => '216', + 'Name' => 'size_t', + 'Size' => '8', + 'Type' => 'Typedef' + }, + '3287' => { + 'BaseType' => '61', + 'Header' => 'stdint.h', + 'Line' => '49', + 'Name' => 'uint16_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '3298' => { + 'BaseType' => '68', + 'Header' => 'stdint.h', + 'Line' => '51', + 'Name' => 'uint32_t', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '3657' => { + 'Header' => 'xenstore_lib.h', + 'Line' => '30', + 'Memb' => { + '0' => { + 'name' => 'XS_PERM_NONE', + 'value' => '0' + }, + '1' => { + 'name' => 'XS_PERM_READ', + 'value' => '1' + }, + '2' => { + 'name' => 'XS_PERM_WRITE', + 'value' => '2' + }, + '3' => { + 'name' => 'XS_PERM_ENOENT_OK', + 'value' => '4' + }, + '4' => { + 'name' => 'XS_PERM_OWNER', + 'value' => '8' + } + }, + 'Name' => 'enum xs_perm_type', + 'Size' => '4', + 'Type' => 'Enum' + }, + '3704' => { + 'Header' => 'xenstore_lib.h', + 'Line' => '39', + 'Memb' => { + '0' => { + 'name' => 'id', + 'offset' => '0', + 'type' => '68' + }, + '1' => { + 'name' => 'perms', + 'offset' => '4', + 'type' => '3657' + } + }, + 'Name' => 'struct xs_permissions', + 'Size' => '8', + 'Type' => 'Struct' + }, + '3740' => { + 'Header' => 'xenstore_lib.h', + 'Line' => '80', + 'Memb' => { + '0' => { + 'name' => 'buf', + 'offset' => '0', + 'type' => '294' + }, + '1' => { + 'name' => 'avail', + 'offset' => '8', + 'type' => '96' + } + }, + 'Name' => 'struct expanding_buffer', + 'Size' => '16', + 'Type' => 'Struct' + }, + '3777' => { + 'BaseType' => '3298', + 'Header' => 'xenstore.h', + 'Line' => '51', + 'Name' => 'xs_transaction_t', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '3788' => { + 'Header' => 'list.h', + 'Line' => '32', + 'Memb' => { + '0' => { + 'name' => 'next', + 'offset' => '0', + 'type' => '3825' + }, + '1' => { + 'name' => 'prev', + 'offset' => '8', + 'type' => '3825' + } + }, + 'Name' => 'struct list_head', + 'PrivateABI' => 1, + 'Size' => '16', + 'Type' => 'Struct' + }, + '3825' => { + 'BaseType' => '3788', + 'Name' => 'struct list_head*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '3872' => { + 'BaseType' => '68', + 'Name' => 'unsigned int*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '3878' => { + 'BaseType' => '3287', + 'Header' => 'xen.h', + 'Line' => '623', + 'Name' => 'domid_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '3890' => { + 'BaseType' => '3901', + 'Header' => 'xentoolcore_internal.h', + 'Line' => '83', + 'Name' => 'Xentoolcore__Active_Handle', + 'Size' => '24', + 'Type' => 'Typedef' + }, + '3901' => { + 'Header' => 'xentoolcore_internal.h', + 'Line' => '88', + 'Memb' => { + '0' => { + 'name' => 'restrict_callback', + 'offset' => '0', + 'type' => '4014' + }, + '1' => { + 'name' => 'entry', + 'offset' => '8', + 'type' => '3975' + } + }, + 'Name' => 'struct Xentoolcore__Active_Handle', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '3938' => { + 'BaseType' => '3949', + 'Header' => 'xentoolcore_internal.h', + 'Line' => '85', + 'Name' => 'Xentoolcore__Restrict_Callback', + 'Type' => 'Typedef' + }, + '3949' => { + 'Name' => 'int()(Xentoolcore__Active_Handle*, domid_t)', + 'Param' => { + '0' => { + 'type' => '3969' + }, + '1' => { + 'type' => '3878' + } + }, + 'Return' => '96', + 'Type' => 'Func' + }, + '3969' => { + 'BaseType' => '3890', + 'Name' => 'Xentoolcore__Active_Handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '3975' => { + 'Header' => 'xentoolcore_internal.h', + 'Line' => '90', + 'Memb' => { + '0' => { + 'name' => 'le_next', + 'offset' => '0', + 'type' => '3969' + }, + '1' => { + 'name' => 'le_prev', + 'offset' => '8', + 'type' => '4008' + } + }, + 'Name' => 'anon-struct-xentoolcore_internal.h-90', + 'PrivateABI' => 1, + 'Size' => '16', + 'Type' => 'Struct' + }, + '4008' => { + 'BaseType' => '3969', + 'Name' => 'Xentoolcore__Active_Handle**', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '4014' => { + 'BaseType' => '3938', + 'Name' => 'Xentoolcore__Restrict_Callback*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '419' => { + 'BaseType' => '75', + 'Header' => 'pthreadtypes.h', + 'Line' => '60', + 'Name' => 'pthread_t', + 'Size' => '8', + 'Type' => 'Typedef' + }, + '4329' => { + 'Line' => '56', + 'Memb' => { + '0' => { + 'name' => 'fd', + 'offset' => '0', + 'type' => '96' + }, + '1' => { + 'name' => 'tc_ah', + 'offset' => '8', + 'type' => '3890' + }, + '10' => { + 'name' => 'reply_mutex', + 'offset' => '184', + 'type' => '713' + }, + '11' => { + 'name' => 'reply_condvar', + 'offset' => '224', + 'type' => '901' + }, + '12' => { + 'name' => 'request_mutex', + 'offset' => '272', + 'type' => '713' + }, + '2' => { + 'name' => 'read_thr', + 'offset' => '32', + 'type' => '419' + }, + '3' => { + 'name' => 'read_thr_exists', + 'offset' => '40', + 'type' => '96' + }, + '4' => { + 'name' => 'watch_list', + 'offset' => '48', + 'type' => '3788' + }, + '5' => { + 'name' => 'watch_mutex', + 'offset' => '64', + 'type' => '713' + }, + '6' => { + 'name' => 'watch_condvar', + 'offset' => '104', + 'type' => '901' + }, + '7' => { + 'name' => 'watch_pipe', + 'offset' => '152', + 'type' => '209' + }, + '8' => { + 'name' => 'unwatch_filter', + 'offset' => '160', + 'type' => '4499' + }, + '9' => { + 'name' => 'reply_list', + 'offset' => '168', + 'type' => '3788' + } + }, + 'Name' => 'struct xs_handle', + 'PrivateABI' => 1, + 'Size' => '312', + 'Source' => 'xs.c', + 'Type' => 'Struct' + }, + '4499' => { + 'Name' => '_Bool', + 'Size' => '1', + 'Type' => 'Intrinsic' + }, + '492' => { + 'Header' => 'pthreadtypes.h', + 'Line' => '75', + 'Memb' => { + '0' => { + 'name' => '__prev', + 'offset' => '0', + 'type' => '529' + }, + '1' => { + 'name' => '__next', + 'offset' => '8', + 'type' => '529' + } + }, + 'Name' => 'struct __pthread_internal_list', + 'PrivateABI' => 1, + 'Size' => '16', + 'Type' => 'Struct' + }, + '5164' => { + 'BaseType' => '3740', + 'Name' => 'struct expanding_buffer*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '529' => { + 'BaseType' => '492', + 'Name' => 'struct __pthread_internal_list*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '535' => { + 'BaseType' => '492', + 'Header' => 'pthreadtypes.h', + 'Line' => '79', + 'Name' => '__pthread_list_t', + 'Size' => '16', + 'Type' => 'Typedef' + }, + '546' => { + 'Header' => 'pthreadtypes.h', + 'Line' => '92', + 'Memb' => { + '0' => { + 'name' => '__lock', + 'offset' => '0', + 'type' => '96' + }, + '1' => { + 'name' => '__count', + 'offset' => '4', + 'type' => '68' + }, + '2' => { + 'name' => '__owner', + 'offset' => '8', + 'type' => '96' + }, + '3' => { + 'name' => '__nusers', + 'offset' => '12', + 'type' => '68' + }, + '4' => { + 'name' => '__kind', + 'offset' => '16', + 'type' => '96' + }, + '5' => { + 'name' => '__spins', + 'offset' => '20', + 'type' => '89' + }, + '6' => { + 'name' => '__elision', + 'offset' => '22', + 'type' => '89' + }, + '7' => { + 'name' => '__list', + 'offset' => '24', + 'type' => '535' + } + }, + 'Name' => 'struct __pthread_mutex_s', + 'PrivateABI' => 1, + 'Size' => '40', + 'Type' => 'Struct' + }, + '5580' => { + 'BaseType' => '4329', + 'Name' => 'struct xs_handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '61' => { + 'Name' => 'unsigned short', + 'Size' => '2', + 'Type' => 'Intrinsic' + }, + '68' => { + 'Name' => 'unsigned int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '697' => { + 'BaseType' => '300', + 'Name' => 'char[40]', + 'Size' => '40', + 'Type' => 'Array' + }, + '713' => { + 'Header' => 'pthreadtypes.h', + 'Line' => '128', + 'Memb' => { + '0' => { + 'name' => '__data', + 'offset' => '0', + 'type' => '546' + }, + '1' => { + 'name' => '__size', + 'offset' => '0', + 'type' => '697' + }, + '2' => { + 'name' => '__align', + 'offset' => '0', + 'type' => '103' + } + }, + 'Name' => 'union pthread_mutex_t', + 'PrivateABI' => 1, + 'Size' => '40', + 'Type' => 'Union' + }, + '724' => { + 'Header' => 'pthreadtypes.h', + 'Line' => '141', + 'Memb' => { + '0' => { + 'name' => '__lock', + 'offset' => '0', + 'type' => '96' + }, + '1' => { + 'name' => '__futex', + 'offset' => '4', + 'type' => '68' + }, + '2' => { + 'name' => '__total_seq', + 'offset' => '8', + 'type' => '829' + }, + '3' => { + 'name' => '__wakeup_seq', + 'offset' => '16', + 'type' => '829' + }, + '4' => { + 'name' => '__woken_seq', + 'offset' => '24', + 'type' => '829' + }, + '5' => { + 'name' => '__mutex', + 'offset' => '32', + 'type' => '259' + }, + '6' => { + 'name' => '__nwaiters', + 'offset' => '40', + 'type' => '68' + }, + '7' => { + 'name' => '__broadcast_seq', + 'offset' => '44', + 'type' => '68' + } + }, + 'Name' => 'anon-struct-pthreadtypes.h-141', + 'PrivateABI' => 1, + 'Size' => '48', + 'Type' => 'Struct' + }, + '75' => { + 'Name' => 'unsigned long', + 'Size' => '8', + 'Type' => 'Intrinsic' + }, + '829' => { + 'Name' => 'unsigned long long', + 'Size' => '8', + 'Type' => 'Intrinsic' + }, + '878' => { + 'BaseType' => '300', + 'Name' => 'char[48]', + 'Size' => '48', + 'Type' => 'Array' + }, + '89' => { + 'Name' => 'short', + 'Size' => '2', + 'Type' => 'Intrinsic' + }, + '894' => { + 'Name' => 'long long', + 'Size' => '8', + 'Type' => 'Intrinsic' + }, + '901' => { + 'Header' => 'pthreadtypes.h', + 'Line' => '154', + 'Memb' => { + '0' => { + 'name' => '__data', + 'offset' => '0', + 'type' => '724' + }, + '1' => { + 'name' => '__size', + 'offset' => '0', + 'type' => '878' + }, + '2' => { + 'name' => '__align', + 'offset' => '0', + 'type' => '894' + } + }, + 'Name' => 'union pthread_cond_t', + 'PrivateABI' => 1, + 'Size' => '48', + 'Type' => 'Union' + }, + '96' => { + 'Name' => 'int', + 'Size' => '4', + 'Type' => 'Intrinsic' + } + }, + 'UndefinedSymbols' => { + 'libxenstore.so.3.0.3' => { + '_ITM_deregisterTMCloneTable' => 0, + '_ITM_registerTMCloneTable' => 0, + '_Jv_RegisterClasses' => 0, + '__assert_fail@GLIBC_2.2.5' => 0, + '__cxa_finalize@GLIBC_2.2.5' => 0, + '__errno_location@GLIBC_2.2.5' => 0, + '__gmon_start__' => 0, + '__pthread_register_cancel@GLIBC_2.3.3' => 0, + '__pthread_unregister_cancel@GLIBC_2.3.3' => 0, + '__pthread_unwind_next@GLIBC_2.3.3' => 0, + '__sigsetjmp@GLIBC_2.2.5' => 0, + '__strdup@GLIBC_2.2.5' => 0, + '__xstat@GLIBC_2.2.5' => 0, + 'access@GLIBC_2.2.5' => 0, + 'close@GLIBC_2.2.5' => 0, + 'connect@GLIBC_2.2.5' => 0, + 'dlsym@GLIBC_2.2.5' => 0, + 'fcntl@GLIBC_2.2.5' => 0, + 'free@GLIBC_2.2.5' => 0, + 'getenv@GLIBC_2.2.5' => 0, + 'malloc@GLIBC_2.2.5' => 0, + 'memcmp@GLIBC_2.2.5' => 0, + 'memcpy@GLIBC_2.14' => 0, + 'open@GLIBC_2.2.5' => 0, + 'pipe@GLIBC_2.2.5' => 0, + 'pthread_attr_destroy@GLIBC_2.2.5' => 0, + 'pthread_attr_init@GLIBC_2.2.5' => 0, + 'pthread_attr_setstacksize@GLIBC_2.2.5' => 0, + 'pthread_cancel@GLIBC_2.2.5' => 0, + 'pthread_cond_broadcast@GLIBC_2.3.2' => 0, + 'pthread_cond_init@GLIBC_2.3.2' => 0, + 'pthread_cond_signal@GLIBC_2.3.2' => 0, + 'pthread_cond_wait@GLIBC_2.3.2' => 0, + 'pthread_create@GLIBC_2.2.5' => 0, + 'pthread_join@GLIBC_2.2.5' => 0, + 'pthread_mutex_init@GLIBC_2.2.5' => 0, + 'pthread_mutex_lock@GLIBC_2.2.5' => 0, + 'pthread_mutex_unlock@GLIBC_2.2.5' => 0, + 'pthread_sigmask@GLIBC_2.2.5' => 0, + 'read@GLIBC_2.2.5' => 0, + 'realloc@GLIBC_2.2.5' => 0, + 'sigaction@GLIBC_2.2.5' => 0, + 'sigemptyset@GLIBC_2.2.5' => 0, + 'sigfillset@GLIBC_2.2.5' => 0, + 'snprintf@GLIBC_2.2.5' => 0, + 'socket@GLIBC_2.2.5' => 0, + 'sprintf@GLIBC_2.2.5' => 0, + 'sscanf@GLIBC_2.2.5' => 0, + 'strcmp@GLIBC_2.2.5' => 0, + 'strcpy@GLIBC_2.2.5' => 0, + 'strncpy@GLIBC_2.2.5' => 0, + 'strtol@GLIBC_2.2.5' => 0, + 'strtoul@GLIBC_2.2.5' => 0, + 'write@GLIBC_2.2.5' => 0, + 'xentoolcore__deregister_active_handle@VERS_1.0' => 0, + 'xentoolcore__register_active_handle@VERS_1.0' => 0, + 'xentoolcore__restrict_by_dup2_null@VERS_1.0' => 0 + } + }, + 'WordSize' => '8' + }; diff --git a/tools/libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump b/tools/libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump new file mode 100644 index 0000000000..d47e757e43 --- /dev/null +++ b/tools/libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump @@ -0,0 +1,239 @@ +$VAR1 = { + 'ABI_DUMPER_VERSION' => '0.99.16', + 'ABI_DUMP_VERSION' => '3.2', + 'Arch' => 'x86_64', + 'GccVersion' => '6.3.0', + 'Headers' => { + 'xentoolcore.h' => 1, + 'xentoolcore_internal.h' => 1 + }, + 'Language' => 'C', + 'LibraryName' => 'libxentoolcore.so.1.0', + 'LibraryVersion' => '1.0', + 'NameSpaces' => {}, + 'Needed' => { + 'libc.so.6' => 1, + 'libpthread.so.0' => 1 + }, + 'PublicABI' => '1', + 'Sources' => { + 'handlereg.c' => 1 + }, + 'SymbolInfo' => { + '1090' => { + 'Header' => 'xentoolcore_internal.h', + 'Param' => { + '0' => { + 'name' => 'ah', + 'type' => '232' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '1', + 'ShortName' => 'xentoolcore__deregister_active_handle', + 'Source' => 'handlereg.c', + 'SourceLine' => '52' + }, + '1160' => { + 'Header' => 'xentoolcore_internal.h', + 'Param' => { + '0' => { + 'name' => 'ah', + 'type' => '232' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '1', + 'ShortName' => 'xentoolcore__register_active_handle', + 'Source' => 'handlereg.c', + 'SourceLine' => '46' + }, + '742' => { + 'Header' => 'xentoolcore_internal.h', + 'Param' => { + '0' => { + 'name' => 'fd', + 'type' => '63' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '63', + 'ShortName' => 'xentoolcore__restrict_by_dup2_null', + 'Source' => 'handlereg.c', + 'SourceLine' => '74' + }, + '943' => { + 'Header' => 'xentoolcore.h', + 'Param' => { + '0' => { + 'name' => 'domid', + 'type' => '141' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '63', + 'ShortName' => 'xentoolcore_restrict_all', + 'Source' => 'handlereg.c', + 'SourceLine' => '58' + } + }, + 'SymbolVersion' => { + '_ITM_deregisterTMCloneTable' => 'pthread_mutex_unlock@@GLIBC_2.2.5', + '_ITM_registerTMCloneTable' => 'pthread_mutex_unlock@@GLIBC_2.2.5', + '_Jv_RegisterClasses' => 'pthread_mutex_unlock@@GLIBC_2.2.5', + '__gmon_start__' => 'pthread_mutex_unlock@@GLIBC_2.2.5', + 'xentoolcore__deregister_active_handle' => 'xentoolcore__deregister_active_handle@@VERS_1.0', + 'xentoolcore__register_active_handle' => 'xentoolcore__register_active_handle@@VERS_1.0', + 'xentoolcore__restrict_by_dup2_null' => 'xentoolcore__restrict_by_dup2_null@@VERS_1.0', + 'xentoolcore_restrict_all' => 'xentoolcore_restrict_all@@VERS_1.0' + }, + 'Symbols' => { + 'libxentoolcore.so.1.0' => { + 'xentoolcore__deregister_active_handle@@VERS_1.0' => 1, + 'xentoolcore__register_active_handle@@VERS_1.0' => 1, + 'xentoolcore__restrict_by_dup2_null@@VERS_1.0' => 1, + 'xentoolcore_restrict_all@@VERS_1.0' => 1 + } + }, + 'Target' => 'unix', + 'TypeInfo' => { + '1' => { + 'Name' => 'void', + 'Type' => 'Intrinsic' + }, + '102' => { + 'Name' => 'unsigned short', + 'Size' => '2', + 'Type' => 'Intrinsic' + }, + '141' => { + 'BaseType' => '91', + 'Header' => 'xen.h', + 'Line' => '623', + 'Name' => 'domid_t', + 'Size' => '2', + 'Type' => 'Typedef' + }, + '153' => { + 'BaseType' => '164', + 'Header' => 'xentoolcore_internal.h', + 'Line' => '83', + 'Name' => 'Xentoolcore__Active_Handle', + 'Size' => '24', + 'Type' => 'Typedef' + }, + '164' => { + 'Header' => 'xentoolcore_internal.h', + 'Line' => '88', + 'Memb' => { + '0' => { + 'name' => 'restrict_callback', + 'offset' => '0', + 'type' => '277' + }, + '1' => { + 'name' => 'entry', + 'offset' => '8', + 'type' => '238' + } + }, + 'Name' => 'struct Xentoolcore__Active_Handle', + 'Size' => '24', + 'Type' => 'Struct' + }, + '201' => { + 'BaseType' => '212', + 'Header' => 'xentoolcore_internal.h', + 'Line' => '85', + 'Name' => 'Xentoolcore__Restrict_Callback', + 'Type' => 'Typedef' + }, + '212' => { + 'Name' => 'int()(Xentoolcore__Active_Handle*, domid_t)', + 'Param' => { + '0' => { + 'type' => '232' + }, + '1' => { + 'type' => '141' + } + }, + 'Return' => '63', + 'Type' => 'Func' + }, + '232' => { + 'BaseType' => '153', + 'Name' => 'Xentoolcore__Active_Handle*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '238' => { + 'Header' => 'xentoolcore_internal.h', + 'Line' => '90', + 'Memb' => { + '0' => { + 'name' => 'le_next', + 'offset' => '0', + 'type' => '232' + }, + '1' => { + 'name' => 'le_prev', + 'offset' => '8', + 'type' => '271' + } + }, + 'Name' => 'anon-struct-xentoolcore_internal.h-90', + 'Size' => '16', + 'Type' => 'Struct' + }, + '271' => { + 'BaseType' => '232', + 'Name' => 'Xentoolcore__Active_Handle**', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '277' => { + 'BaseType' => '201', + 'Name' => 'Xentoolcore__Restrict_Callback*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '63' => { + 'Name' => 'int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '91' => { + 'BaseType' => '102', + 'Header' => 'stdint.h', + 'Line' => '49', + 'Name' => 'uint16_t', + 'Size' => '2', + 'Type' => 'Typedef' + } + }, + 'UndefinedSymbols' => { + 'libxentoolcore.so.1.0' => { + '_ITM_deregisterTMCloneTable' => 0, + '_ITM_registerTMCloneTable' => 0, + '_Jv_RegisterClasses' => 0, + '__assert_fail@GLIBC_2.2.5' => 0, + '__cxa_finalize@GLIBC_2.2.5' => 0, + '__gmon_start__' => 0, + 'close@GLIBC_2.2.5' => 0, + 'dup2@GLIBC_2.2.5' => 0, + 'open@GLIBC_2.2.5' => 0, + 'pthread_mutex_lock@GLIBC_2.2.5' => 0, + 'pthread_mutex_unlock@GLIBC_2.2.5' => 0 + } + }, + 'WordSize' => '8' + }; diff --git a/tools/libs/abi/libxentoollog.so.1.0-x86_64-abi.dump b/tools/libs/abi/libxentoollog.so.1.0-x86_64-abi.dump new file mode 100644 index 0000000000..9f6a82ec98 --- /dev/null +++ b/tools/libs/abi/libxentoollog.so.1.0-x86_64-abi.dump @@ -0,0 +1,882 @@ +$VAR1 = { + 'ABI_DUMPER_VERSION' => '0.99.16', + 'ABI_DUMP_VERSION' => '3.2', + 'Arch' => 'x86_64', + 'GccVersion' => '6.3.0', + 'Headers' => { + 'xentoollog.h' => 1 + }, + 'Language' => 'C', + 'LibraryName' => 'libxentoollog.so.1.0', + 'LibraryVersion' => '1.0', + 'NameSpaces' => {}, + 'Needed' => { + 'libc.so.6' => 1, + 'libpthread.so.0' => 1 + }, + 'PublicABI' => '1', + 'Sources' => { + 'xtl_core.c' => 1, + 'xtl_logger_stdio.c' => 1 + }, + 'SymbolInfo' => { + '1176' => { + 'Header' => 'xentoollog.h', + 'Param' => { + '0' => { + 'name' => 'logger', + 'type' => '5234' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '1', + 'ShortName' => 'xtl_logger_destroy', + 'Source' => 'xtl_core.c', + 'SourceLine' => '80' + }, + '1238' => { + 'Header' => 'xentoollog.h', + 'Param' => { + '0' => { + 'name' => 'logger', + 'type' => '5234' + }, + '1' => { + 'name' => 'context', + 'type' => '790' + }, + '2' => { + 'name' => 'doing_what', + 'type' => '790' + }, + '3' => { + 'name' => 'done', + 'type' => '60' + }, + '4' => { + 'name' => 'total', + 'type' => '60' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8' + }, + 'Return' => '1', + 'ShortName' => 'xtl_progress', + 'Source' => 'xtl_core.c', + 'SourceLine' => '65' + }, + '1388' => { + 'Header' => 'xentoollog.h', + 'Param' => { + '0' => { + 'name' => 'logger', + 'type' => '5234' + }, + '1' => { + 'name' => 'level', + 'type' => '966' + }, + '2' => { + 'name' => 'errnoval', + 'type' => '102' + }, + '3' => { + 'name' => 'context', + 'type' => '790' + }, + '4' => { + 'name' => 'format', + 'type' => '790' + }, + '5' => { + 'type' => '-1' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8' + }, + 'Return' => '1', + 'ShortName' => 'xtl_log', + 'Source' => 'xtl_core.c', + 'SourceLine' => '53' + }, + '1529' => { + 'Header' => 'xentoollog.h', + 'Param' => { + '0' => { + 'name' => 'logger', + 'type' => '5234' + }, + '1' => { + 'name' => 'level', + 'type' => '966' + }, + '2' => { + 'name' => 'errnoval', + 'type' => '102' + }, + '3' => { + 'name' => 'context', + 'type' => '790' + }, + '4' => { + 'name' => 'format', + 'type' => '790' + }, + '5' => { + 'name' => 'al', + 'type' => '1068' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx', + '3' => 'rcx', + '4' => 'r8', + '5' => 'r9' + }, + 'Return' => '1', + 'ShortName' => 'xtl_logv', + 'Source' => 'xtl_core.c', + 'SourceLine' => '41' + }, + '1830' => { + 'Header' => 'xentoollog.h', + 'Param' => { + '0' => { + 'name' => 'level', + 'type' => '966' + } + }, + 'Reg' => { + '0' => 'rdi' + }, + 'Return' => '790', + 'ShortName' => 'xtl_level_to_string', + 'Source' => 'xtl_core.c', + 'SourceLine' => '36' + }, + '3611' => { + 'Header' => 'xentoollog.h', + 'Param' => { + '0' => { + 'name' => 'f', + 'type' => '3598' + }, + '1' => { + 'name' => 'min_level', + 'type' => '966' + }, + '2' => { + 'name' => 'flags', + 'type' => '81' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '3869', + 'ShortName' => 'xtl_createlogger_stdiostream', + 'Source' => 'xtl_logger_stdio.c', + 'SourceLine' => '166' + }, + '3875' => { + 'Header' => 'xentoollog.h', + 'Param' => { + '0' => { + 'name' => 'lg', + 'type' => '3869' + }, + '1' => { + 'name' => 'set_flags', + 'type' => '81' + }, + '2' => { + 'name' => 'clear_flags', + 'type' => '81' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi', + '2' => 'rdx' + }, + 'Return' => '1', + 'ShortName' => 'xtl_stdiostream_adjust_flags', + 'Source' => 'xtl_logger_stdio.c', + 'SourceLine' => '158' + }, + '3977' => { + 'Header' => 'xentoollog.h', + 'Param' => { + '0' => { + 'name' => 'lg', + 'type' => '3869' + }, + '1' => { + 'name' => 'min_level', + 'type' => '966' + } + }, + 'Reg' => { + '0' => 'rdi', + '1' => 'rsi' + }, + 'Return' => '1', + 'ShortName' => 'xtl_stdiostream_set_minlevel', + 'Source' => 'xtl_logger_stdio.c', + 'SourceLine' => '153' + } + }, + 'SymbolVersion' => { + '_ITM_deregisterTMCloneTable' => 'vfprintf@@GLIBC_2.2.5', + '_ITM_registerTMCloneTable' => 'vfprintf@@GLIBC_2.2.5', + '_Jv_RegisterClasses' => 'vfprintf@@GLIBC_2.2.5', + '__gmon_start__' => 'vfprintf@@GLIBC_2.2.5', + 'xtl_createlogger_stdiostream' => 'xtl_createlogger_stdiostream@@VERS_1.0', + 'xtl_level_to_string' => 'xtl_level_to_string@@VERS_1.0', + 'xtl_log' => 'xtl_log@@VERS_1.0', + 'xtl_logger_destroy' => 'xtl_logger_destroy@@VERS_1.0', + 'xtl_logv' => 'xtl_logv@@VERS_1.0', + 'xtl_progress' => 'xtl_progress@@VERS_1.0', + 'xtl_stdiostream_adjust_flags' => 'xtl_stdiostream_adjust_flags@@VERS_1.0', + 'xtl_stdiostream_set_minlevel' => 'xtl_stdiostream_set_minlevel@@VERS_1.0' + }, + 'Symbols' => { + 'libxentoollog.so.1.0' => { + 'xtl_createlogger_stdiostream@@VERS_1.0' => 1, + 'xtl_level_to_string@@VERS_1.0' => 1, + 'xtl_log@@VERS_1.0' => 1, + 'xtl_logger_destroy@@VERS_1.0' => 1, + 'xtl_logv@@VERS_1.0' => 1, + 'xtl_progress@@VERS_1.0' => 1, + 'xtl_stdiostream_adjust_flags@@VERS_1.0' => 1, + 'xtl_stdiostream_set_minlevel@@VERS_1.0' => 1 + } + }, + 'Target' => 'unix', + 'TypeInfo' => { + '-1' => { + 'Name' => '...', + 'Type' => 'Intrinsic' + }, + '1' => { + 'Name' => 'void', + 'Type' => 'Intrinsic' + }, + '102' => { + 'Name' => 'int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '1068' => { + 'BaseType' => '582', + 'Name' => 'struct __va_list_tag*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '1074' => { + 'Name' => 'void(*)(struct xentoollog_logger*, xentoollog_level, int, char const*, char const*, struct __va_list_tag*)', + 'Param' => { + '0' => { + 'type' => '5234' + }, + '1' => { + 'type' => '966' + }, + '2' => { + 'type' => '102' + }, + '3' => { + 'type' => '790' + }, + '4' => { + 'type' => '790' + }, + '5' => { + 'type' => '1068' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '109' => { + 'Name' => 'long', + 'Size' => '8', + 'Type' => 'Intrinsic' + }, + '1116' => { + 'Name' => 'void(*)(struct xentoollog_logger*, char const*, char const*, int, unsigned long, unsigned long)', + 'Param' => { + '0' => { + 'type' => '5234' + }, + '1' => { + 'type' => '790' + }, + '2' => { + 'type' => '790' + }, + '3' => { + 'type' => '102' + }, + '4' => { + 'type' => '60' + }, + '5' => { + 'type' => '60' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '1133' => { + 'Name' => 'void(*)(struct xentoollog_logger*)', + 'Param' => { + '0' => { + 'type' => '5234' + } + }, + 'Return' => '1', + 'Size' => '8', + 'Type' => 'FuncPtr' + }, + '116' => { + 'BaseType' => '109', + 'Header' => 'types.h', + 'Line' => '131', + 'Name' => '__off_t', + 'Size' => '8', + 'Type' => 'Typedef' + }, + '127' => { + 'BaseType' => '109', + 'Header' => 'types.h', + 'Line' => '132', + 'Name' => '__off64_t', + 'Size' => '8', + 'Type' => 'Typedef' + }, + '145' => { + 'BaseType' => '1', + 'Name' => 'void*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '147' => { + 'BaseType' => '153', + 'Name' => 'char*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '153' => { + 'Name' => 'char', + 'Size' => '1', + 'Type' => 'Intrinsic' + }, + '160' => { + 'BaseType' => '153', + 'Name' => 'char const', + 'Size' => '1', + 'Type' => 'Const' + }, + '165' => { + 'Header' => 'libio.h', + 'Line' => '241', + 'Memb' => { + '0' => { + 'name' => '_flags', + 'offset' => '0', + 'type' => '102' + }, + '1' => { + 'name' => '_IO_read_ptr', + 'offset' => '8', + 'type' => '147' + }, + '10' => { + 'name' => '_IO_backup_base', + 'offset' => '80', + 'type' => '147' + }, + '11' => { + 'name' => '_IO_save_end', + 'offset' => '88', + 'type' => '147' + }, + '12' => { + 'name' => '_markers', + 'offset' => '96', + 'type' => '699' + }, + '13' => { + 'name' => '_chain', + 'offset' => '104', + 'type' => '705' + }, + '14' => { + 'name' => '_fileno', + 'offset' => '112', + 'type' => '102' + }, + '15' => { + 'name' => '_flags2', + 'offset' => '116', + 'type' => '102' + }, + '16' => { + 'name' => '_old_offset', + 'offset' => '120', + 'type' => '116' + }, + '17' => { + 'name' => '_cur_column', + 'offset' => '128', + 'type' => '74' + }, + '18' => { + 'name' => '_vtable_offset', + 'offset' => '130', + 'type' => '88' + }, + '19' => { + 'name' => '_shortbuf', + 'offset' => '131', + 'type' => '711' + }, + '2' => { + 'name' => '_IO_read_end', + 'offset' => '16', + 'type' => '147' + }, + '20' => { + 'name' => '_lock', + 'offset' => '136', + 'type' => '727' + }, + '21' => { + 'name' => '_offset', + 'offset' => '144', + 'type' => '127' + }, + '22' => { + 'name' => '__pad1', + 'offset' => '152', + 'type' => '145' + }, + '23' => { + 'name' => '__pad2', + 'offset' => '160', + 'type' => '145' + }, + '24' => { + 'name' => '__pad3', + 'offset' => '168', + 'type' => '145' + }, + '25' => { + 'name' => '__pad4', + 'offset' => '176', + 'type' => '145' + }, + '26' => { + 'name' => '__pad5', + 'offset' => '184', + 'type' => '49' + }, + '27' => { + 'name' => '_mode', + 'offset' => '192', + 'type' => '102' + }, + '28' => { + 'name' => '_unused2', + 'offset' => '196', + 'type' => '733' + }, + '3' => { + 'name' => '_IO_read_base', + 'offset' => '24', + 'type' => '147' + }, + '4' => { + 'name' => '_IO_write_base', + 'offset' => '32', + 'type' => '147' + }, + '5' => { + 'name' => '_IO_write_ptr', + 'offset' => '40', + 'type' => '147' + }, + '6' => { + 'name' => '_IO_write_end', + 'offset' => '48', + 'type' => '147' + }, + '7' => { + 'name' => '_IO_buf_base', + 'offset' => '56', + 'type' => '147' + }, + '8' => { + 'name' => '_IO_buf_end', + 'offset' => '64', + 'type' => '147' + }, + '9' => { + 'name' => '_IO_save_base', + 'offset' => '72', + 'type' => '147' + } + }, + 'Name' => 'struct _IO_FILE', + 'PrivateABI' => 1, + 'Size' => '216', + 'Type' => 'Struct' + }, + '2177' => { + 'BaseType' => '165', + 'Header' => 'stdio.h', + 'Line' => '48', + 'Name' => 'FILE', + 'Size' => '216', + 'Type' => 'Typedef' + }, + '3000' => { + 'BaseType' => '977', + 'Header' => 'xentoollog.h', + 'Line' => '44', + 'Name' => 'xentoollog_logger', + 'Size' => '24', + 'Type' => 'Typedef' + }, + '3173' => { + 'BaseType' => '3184', + 'Header' => 'xentoollog.h', + 'Line' => '73', + 'Name' => 'xentoollog_logger_stdiostream', + 'Size' => '56', + 'Type' => 'Typedef' + }, + '3184' => { + 'Line' => '32', + 'Memb' => { + '0' => { + 'name' => 'vtable', + 'offset' => '0', + 'type' => '3000' + }, + '1' => { + 'name' => 'f', + 'offset' => '24', + 'type' => '3598' + }, + '2' => { + 'name' => 'min_level', + 'offset' => '32', + 'type' => '966' + }, + '3' => { + 'name' => 'flags', + 'offset' => '36', + 'type' => '81' + }, + '4' => { + 'name' => 'progress_erase_len', + 'offset' => '40', + 'type' => '102' + }, + '5' => { + 'name' => 'progress_last_percent', + 'offset' => '44', + 'type' => '102' + }, + '6' => { + 'name' => 'progress_use_cr', + 'offset' => '48', + 'type' => '3604' + } + }, + 'Name' => 'struct xentoollog_logger_stdiostream', + 'PrivateABI' => 1, + 'Size' => '56', + 'Source' => 'xtl_logger_stdio.c', + 'Type' => 'Struct' + }, + '3598' => { + 'BaseType' => '2177', + 'Name' => 'FILE*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '3604' => { + 'Name' => '_Bool', + 'Size' => '1', + 'Type' => 'Intrinsic' + }, + '3869' => { + 'BaseType' => '3173', + 'Name' => 'xentoollog_logger_stdiostream*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '49' => { + 'BaseType' => '60', + 'Header' => 'stddef.h', + 'Line' => '216', + 'Name' => 'size_t', + 'Size' => '8', + 'Type' => 'Typedef' + }, + '5234' => { + 'BaseType' => '3000', + 'Name' => 'xentoollog_logger*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '582' => { + 'Memb' => { + '0' => { + 'name' => 'gp_offset', + 'offset' => '0', + 'type' => '81' + }, + '1' => { + 'name' => 'fp_offset', + 'offset' => '4', + 'type' => '81' + }, + '2' => { + 'name' => 'overflow_arg_area', + 'offset' => '8', + 'type' => '145' + }, + '3' => { + 'name' => 'reg_save_area', + 'offset' => '16', + 'type' => '145' + } + }, + 'Name' => 'struct __va_list_tag', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '60' => { + 'Name' => 'unsigned long', + 'Size' => '8', + 'Type' => 'Intrinsic' + }, + '643' => { + 'Header' => 'libio.h', + 'Line' => '150', + 'Name' => '_IO_lock_t', + 'Type' => 'Typedef' + }, + '650' => { + 'Header' => 'libio.h', + 'Line' => '156', + 'Memb' => { + '0' => { + 'name' => '_next', + 'offset' => '0', + 'type' => '699' + }, + '1' => { + 'name' => '_sbuf', + 'offset' => '8', + 'type' => '705' + }, + '2' => { + 'name' => '_pos', + 'offset' => '16', + 'type' => '102' + } + }, + 'Name' => 'struct _IO_marker', + 'PrivateABI' => 1, + 'Size' => '24', + 'Type' => 'Struct' + }, + '699' => { + 'BaseType' => '650', + 'Name' => 'struct _IO_marker*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '705' => { + 'BaseType' => '165', + 'Name' => 'struct _IO_FILE*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '711' => { + 'BaseType' => '153', + 'Name' => 'char[1]', + 'Size' => '1', + 'Type' => 'Array' + }, + '727' => { + 'BaseType' => '643', + 'Name' => '_IO_lock_t*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '733' => { + 'BaseType' => '153', + 'Name' => 'char[20]', + 'Size' => '20', + 'Type' => 'Array' + }, + '74' => { + 'Name' => 'unsigned short', + 'Size' => '2', + 'Type' => 'Intrinsic' + }, + '790' => { + 'BaseType' => '160', + 'Name' => 'char const*', + 'Size' => '8', + 'Type' => 'Pointer' + }, + '81' => { + 'Name' => 'unsigned int', + 'Size' => '4', + 'Type' => 'Intrinsic' + }, + '88' => { + 'Name' => 'signed char', + 'Size' => '1', + 'Type' => 'Intrinsic' + }, + '883' => { + 'Header' => 'xentoollog.h', + 'Line' => '30', + 'Memb' => { + '0' => { + 'name' => 'XTL_NONE', + 'value' => '0' + }, + '1' => { + 'name' => 'XTL_DEBUG', + 'value' => '1' + }, + '10' => { + 'name' => 'XTL_NUM_LEVELS', + 'value' => '10' + }, + '2' => { + 'name' => 'XTL_VERBOSE', + 'value' => '2' + }, + '3' => { + 'name' => 'XTL_DETAIL', + 'value' => '3' + }, + '4' => { + 'name' => 'XTL_PROGRESS', + 'value' => '4' + }, + '5' => { + 'name' => 'XTL_INFO', + 'value' => '5' + }, + '6' => { + 'name' => 'XTL_NOTICE', + 'value' => '6' + }, + '7' => { + 'name' => 'XTL_WARN', + 'value' => '7' + }, + '8' => { + 'name' => 'XTL_ERROR', + 'value' => '8' + }, + '9' => { + 'name' => 'XTL_CRITICAL', + 'value' => '9' + } + }, + 'Name' => 'enum xentoollog_level', + 'Size' => '4', + 'Type' => 'Enum' + }, + '966' => { + 'BaseType' => '883', + 'Header' => 'xentoollog.h', + 'Line' => '42', + 'Name' => 'xentoollog_level', + 'Size' => '4', + 'Type' => 'Typedef' + }, + '977' => { + 'Header' => 'xentoollog.h', + 'Line' => '45', + 'Memb' => { + '0' => { + 'name' => 'vmessage', + 'offset' => '0', + 'type' => '1074' + }, + '1' => { + 'name' => 'progress', + 'offset' => '8', + 'type' => '1116' + }, + '2' => { + 'name' => 'destroy', + 'offset' => '16', + 'type' => '1133' + } + }, + 'Name' => 'struct xentoollog_logger', + 'Size' => '24', + 'Type' => 'Struct' + } + }, + 'UndefinedSymbols' => { + 'libxentoollog.so.1.0' => { + '_IO_putc@GLIBC_2.2.5' => 0, + '_ITM_deregisterTMCloneTable' => 0, + '_ITM_registerTMCloneTable' => 0, + '_Jv_RegisterClasses' => 0, + '__assert_fail@GLIBC_2.2.5' => 0, + '__cxa_finalize@GLIBC_2.2.5' => 0, + '__errno_location@GLIBC_2.2.5' => 0, + '__gmon_start__' => 0, + '__tzname@GLIBC_2.2.5' => 0, + 'fflush@GLIBC_2.2.5' => 0, + 'fileno@GLIBC_2.2.5' => 0, + 'fprintf@GLIBC_2.2.5' => 0, + 'free@GLIBC_2.2.5' => 0, + 'getpid@GLIBC_2.2.5' => 0, + 'isatty@GLIBC_2.2.5' => 0, + 'localtime_r@GLIBC_2.2.5' => 0, + 'malloc@GLIBC_2.2.5' => 0, + 'strerror@GLIBC_2.2.5' => 0, + 'time@GLIBC_2.2.5' => 0, + 'tzname@GLIBC_2.2.5' => 0, + 'tzset@GLIBC_2.2.5' => 0, + 'vfprintf@GLIBC_2.2.5' => 0 + } + }, + 'WordSize' => '8' + }; diff --git a/tools/libs/call/Makefile b/tools/libs/call/Makefile index 4ed201b3b3..37a7db5395 100644 --- a/tools/libs/call/Makefile +++ b/tools/libs/call/Makefile @@ -11,4 +11,6 @@ SRCS-$(CONFIG_SunOS) += solaris.c SRCS-$(CONFIG_NetBSD) += netbsd.c SRCS-$(CONFIG_MiniOS) += minios.c +PKG_OLD_ABI = ../abi/libxen$(LIBNAME).so.1.2-$(XEN_TARGET_ARCH)-abi.dump + include $(XEN_ROOT)/tools/libs/libs.mk diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile index 3e50ff6d90..95161ae123 100644 --- a/tools/libs/devicemodel/Makefile +++ b/tools/libs/devicemodel/Makefile @@ -11,4 +11,6 @@ SRCS-$(CONFIG_SunOS) += compat.c SRCS-$(CONFIG_NetBSD) += compat.c SRCS-$(CONFIG_MiniOS) += compat.c +PKG_OLD_ABI = ../abi/libxen$(LIBNAME).so.1.3-$(XEN_TARGET_ARCH)-abi.dump + include $(XEN_ROOT)/tools/libs/libs.mk diff --git a/tools/libs/evtchn/Makefile b/tools/libs/evtchn/Makefile index b8c37b5b97..300d131f74 100644 --- a/tools/libs/evtchn/Makefile +++ b/tools/libs/evtchn/Makefile @@ -11,4 +11,6 @@ SRCS-$(CONFIG_SunOS) += solaris.c SRCS-$(CONFIG_NetBSD) += netbsd.c SRCS-$(CONFIG_MiniOS) += minios.c +PKG_OLD_ABI = ../abi/libxen$(LIBNAME).so.1.1-$(XEN_TARGET_ARCH)-abi.dump + include $(XEN_ROOT)/tools/libs/libs.mk diff --git a/tools/libs/foreignmemory/Makefile b/tools/libs/foreignmemory/Makefile index 0eb9a3a712..3f2388cf79 100644 --- a/tools/libs/foreignmemory/Makefile +++ b/tools/libs/foreignmemory/Makefile @@ -11,4 +11,6 @@ SRCS-$(CONFIG_SunOS) += compat.c solaris.c SRCS-$(CONFIG_NetBSD) += netbsd.c SRCS-$(CONFIG_MiniOS) += minios.c +PKG_OLD_ABI = ../abi/libxen$(LIBNAME).so.1.3-$(XEN_TARGET_ARCH)-abi.dump + include $(XEN_ROOT)/tools/libs/libs.mk diff --git a/tools/libs/gnttab/Makefile b/tools/libs/gnttab/Makefile index ae390ce60f..a4c7abe0c5 100644 --- a/tools/libs/gnttab/Makefile +++ b/tools/libs/gnttab/Makefile @@ -13,4 +13,6 @@ SRCS-$(CONFIG_FreeBSD) += $(SRCS-GNTTAB) $(SRCS-GNTSHR) freebsd.c SRCS-$(CONFIG_NetBSD) += $(SRCS-GNTTAB) $(SRCS-GNTSHR) netbsd.c SRCS-$(CONFIG_SunOS) += gnttab_unimp.c gntshr_unimp.c +PKG_OLD_ABI = ../abi/libxen$(LIBNAME).so.1.2-$(XEN_TARGET_ARCH)-abi.dump + include $(XEN_ROOT)/tools/libs/libs.mk diff --git a/tools/libs/hypfs/Makefile b/tools/libs/hypfs/Makefile index 39feca87e8..fb6f6bc467 100644 --- a/tools/libs/hypfs/Makefile +++ b/tools/libs/hypfs/Makefile @@ -8,4 +8,6 @@ APPEND_LDFLAGS += -lz SRCS-y += core.c +PKG_OLD_ABI = ../abi/libxen$(LIBNAME).so.1.0-$(XEN_TARGET_ARCH)-abi.dump + include ../libs.mk diff --git a/tools/libs/store/Makefile b/tools/libs/store/Makefile index bee57b5629..59ae142928 100644 --- a/tools/libs/store/Makefile +++ b/tools/libs/store/Makefile @@ -13,6 +13,8 @@ SRCS-y += xs.c LIBHEADER = xenstore.h xenstore_lib.h +PKG_OLD_ABI = ../abi/libxen$(LIBNAME).so.3.0.3-$(XEN_TARGET_ARCH)-abi.dump + include ../libs.mk # Include configure output (config.h) diff --git a/tools/libs/toolcore/Makefile b/tools/libs/toolcore/Makefile index 1cf30733c9..fbb11979e6 100644 --- a/tools/libs/toolcore/Makefile +++ b/tools/libs/toolcore/Makefile @@ -7,6 +7,8 @@ AUTOINCS := $(XEN_INCLUDE)/_xentoolcore_list.h SRCS-y += handlereg.c +PKG_OLD_ABI = ../abi/libxen$(LIBNAME).so.1.0-$(XEN_TARGET_ARCH)-abi.dump + include $(XEN_ROOT)/tools/libs/libs.mk PKG_CONFIG_DESC := Central support for Xen Hypervisor userland libraries diff --git a/tools/libs/toollog/Makefile b/tools/libs/toollog/Makefile index dce1b2de85..c4a61a99cf 100644 --- a/tools/libs/toollog/Makefile +++ b/tools/libs/toollog/Makefile @@ -7,4 +7,6 @@ MINOR = 0 SRCS-y += xtl_core.c SRCS-y += xtl_logger_stdio.c +PKG_OLD_ABI = ../abi/libxen$(LIBNAME).so.1.0-$(XEN_TARGET_ARCH)-abi.dump + include $(XEN_ROOT)/tools/libs/libs.mk -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:16:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:16:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91816.173255 (Exim 4.92) (envelope-from ) id 1lGm9u-0007Xg-VJ; Mon, 01 Mar 2021 17:16:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91816.173255; Mon, 01 Mar 2021 17:16:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGm9u-0007XZ-SC; Mon, 01 Mar 2021 17:16:38 +0000 Received: by outflank-mailman (input) for mailman id 91816; Mon, 01 Mar 2021 17:16:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGm9u-0007XU-78 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:16:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGm9u-0004qy-2u for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:16:38 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGm9u-0002V6-1x for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:16:38 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGm9q-0004xS-NV; Mon, 01 Mar 2021 17:16:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=13Kj7RzqmVCzVZETaSPuaFP8XdUIobXKzSnObUsCibA=; b=WOiNlCUpOk+TNTyZOfE6ZqhgqL v2MHHEml4KYs+nraDZxLmOGRLycDMZ3WgU8g6oJaVm+olcMHpNB+cctSFvzicAn+LhxWsyS69+W/v qO/Q6Fqk/Ua4hmfCF9azujPFF6hoqUPZVEkwppEc358rKMPPqcL+wQlKs0OiMOAhZVxc=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24637.8562.514355.845883@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 17:16:34 +0000 To: Roger Pau Monne Cc: , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection In-Reply-To: <20210301162357.76527-1-roger.pau@citrix.com> References: <20210301162357.76527-1-roger.pau@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monne writes ("[PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection"): > Introduce an option to allow selecting the legacy behavior for > accesses to MSRs not explicitly handled. Since commit > 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly > handled by Xen result in the injection of a #GP to the guest. This is > a behavior change since previously a #GP was only injected if > accessing the MSR on the real hardware will also trigger a #GP. > > This seems to be problematic for some guests, so introduce an option > to fallback to this legacy behavior. The main difference between what > was previously done is that the hardware MSR value is not leaked to > the guests on reads. > > Signed-off-by: Roger Pau Monn > --- > Cc: Boris Ostrovsky > --- > Note that this option is not made available to dom0. I'm not sure > whether it makes sense to do so, since anyone updating Xen to such > newer version will also likely pair it with a newish kernel that > doesn't require such workarounds. > > RFC because there's still some debate as to how we should solve the > MSR issue, this is one possible way, but IMO we need to make a > decision soon-ish because of the release timeline. > > Boris, could you please test with Solaris to see if this fixes the > issue? So AIUI this patch is to make it possible for Xen 4.15 to behave like Xen 4.14, thus avoiding a regression for these troublesome guests. Have we diffed the result of this against 4.14 and if not would it be a sensible thing to do ? Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:17:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:17:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91819.173267 (Exim 4.92) (envelope-from ) id 1lGmAo-0007d9-8t; Mon, 01 Mar 2021 17:17:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91819.173267; Mon, 01 Mar 2021 17:17:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmAo-0007d2-5V; Mon, 01 Mar 2021 17:17:34 +0000 Received: by outflank-mailman (input) for mailman id 91819; Mon, 01 Mar 2021 17:17:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmAm-0007cu-Rk for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:17:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmAm-0004uX-R0 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:17:32 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGmAm-0002Zt-Q4 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:17:32 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGmAj-0004yU-MM; Mon, 01 Mar 2021 17:17:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=g+MEZypoAgH3TyF2eulc4CLER4DU0JKZS3c5P4t6lyw=; b=VKQletlaYo7uAk3d7RAY2Dr8bP aJPk/S8UTZsrBV6cr8Ee90oG7zcGYO8FNRHp5jL2RJjo6NfUBOEHC929m9YyonhT8BAqcY3VVUTPW HjbLacQvcwl7Ggi8ho7x499vje0mQ2o/fhxzdOAKI0Jy8VlcukmuyKC19qmJ7Z0t+VKM=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.8617.478842.771632@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 17:17:29 +0000 To: Andrew Cooper Cc: Xen-devel , Wei Liu Subject: Re: [PATCH 1/3] tools: Check for abi-compliance-checker in ./configure In-Reply-To: <20210301170044.23295-2-andrew.cooper3@citrix.com> References: <20210301170044.23295-1-andrew.cooper3@citrix.com> <20210301170044.23295-2-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH 1/3] tools: Check for abi-compliance-checker in ./configure"): > This will be optional. No functional change Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:19:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:19:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91822.173279 (Exim 4.92) (envelope-from ) id 1lGmCC-0007nH-Jc; Mon, 01 Mar 2021 17:19:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91822.173279; Mon, 01 Mar 2021 17:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmCC-0007n8-GA; Mon, 01 Mar 2021 17:19:00 +0000 Received: by outflank-mailman (input) for mailman id 91822; Mon, 01 Mar 2021 17:18:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmCB-0007mx-Ka for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:18:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmCB-0004vc-J2 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:18:59 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGmCB-0002iw-IE for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:18:59 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGmC8-0004yo-E3; Mon, 01 Mar 2021 17:18:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=9cKCkrTetJ5mUuJj4qq8jrrlq+cBEBhidajVNs72y/M=; b=IzSF4rnWE0DkYhlajaciqhROua dUQQy/lY+BY5pCMBaoNsqJ50HlvDXf7Si0pq+0HXEevmI3Oo9oszgUW9snv/CgJ04Q4H8MDavIacA cd+98OJ9qUUxi1geZ8A67hvFFI5fgKO5MQu51sH51xTDQ71uRerogkSZMqFdglHwgNlQ=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.8704.214350.199547@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 17:18:56 +0000 To: Andrew Cooper Cc: Xen-devel , Wei Liu , Juergen Gross Subject: Re: [PATCH 2/3] tools/libs: Stash the 4.14 API/ABIs for the stable libraries In-Reply-To: <20210301170044.23295-3-andrew.cooper3@citrix.com> References: <20210301170044.23295-1-andrew.cooper3@citrix.com> <20210301170044.23295-3-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH 2/3] tools/libs: Stash the 4.14 API/ABIs for the stable libraries"): > These dumps were produced from the RELEASE-4.14.0 tag, with the abi-dumper > tooling backported from staging. > > For each stable library, add a PKG_OLD_ABI variable pointing at the 4.14 ABI. > > No functional change. Release-Acked-by: Ian Jackson I would like a nother set of eyes to look at this, so Wei, I would appreciate if you would do the maintainer review. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:20:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:20:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91827.173290 (Exim 4.92) (envelope-from ) id 1lGmDp-0000Bs-V3; Mon, 01 Mar 2021 17:20:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91827.173290; Mon, 01 Mar 2021 17:20:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmDp-0000Bl-S6; Mon, 01 Mar 2021 17:20:41 +0000 Received: by outflank-mailman (input) for mailman id 91827; Mon, 01 Mar 2021 17:20:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmDo-0000Bg-O6 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:20:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmDo-0004xE-NQ for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:20:40 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGmDo-0002ri-L3 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:20:40 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGmDl-0004zl-Ek; Mon, 01 Mar 2021 17:20:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=BDMyj64U5QPXri/Yn/CnXt6gBLjC8mPDXeq1WEUGsks=; b=mQ2TumlOS7V+x938eoyFdKrji+ TgcALwgpfR716zUa+DxSq9AK/9v0EEyusePBHUYom5KxklrX6h0tKHeu2ExF58S8DtyKbTal3BuVt BTv284ECnerdng7Hvwfi5FTXh3fky4CTBPoLVsOfDa0sPtR5FD0W+6N9dFlAXI2DIp/0=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24637.8805.239765.656484@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 17:20:37 +0000 To: Roger Pau Monne Cc: , Doug Goldstein , Stefano Stabellini , Ian Jackson Subject: Re: [PATCH for-4.15] automation/alpine: add g++ to the list of build depends In-Reply-To: <20210301095806.68518-1-roger.pau@citrix.com> References: <20210301095806.68518-1-roger.pau@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monne writes ("[PATCH for-4.15] automation/alpine: add g++ to the list of build depends"): > clang++ relies on the C++ headers installed by g++, or else a clang > build will hit the following error: > > :3:10: fatal error: 'cstring' file not found > #include "cstring" > ^~~~~~~~~ > 1 error generated. > make[10]: *** [Makefile:120: headers++.chk] Error 1 > > Reported-by: Stefano Stabellini > Signed-off-by: Roger Pau Monn > --- > Cc: Ian Jackson > No real risk here from a release PoV, it's just pulling a package > required for the Alpine clang build. Worse that cold happen is that > the Alpine clang build broke, but it's already broken. Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:23:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:23:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91830.173303 (Exim 4.92) (envelope-from ) id 1lGmG8-0000Lg-DE; Mon, 01 Mar 2021 17:23:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91830.173303; Mon, 01 Mar 2021 17:23:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmG8-0000LZ-9C; Mon, 01 Mar 2021 17:23:04 +0000 Received: by outflank-mailman (input) for mailman id 91830; Mon, 01 Mar 2021 17:23:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmG7-0000LU-VS for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:23:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmG7-00051F-Rt for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:23:03 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGmG7-0003FG-NU for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:23:03 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGmG4-00050L-Ft; Mon, 01 Mar 2021 17:23:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=WbpzYTsRS88Sja6k7+DSNQhIBS6w6XPw9uybmNVBtDo=; b=rSvxa+UYE40LtAd3TrHHrrk8B0 ZESIlRGAsnLg5GeNLxoh6k15f3CISZiUJQ/KE9TY0FBWhAKLyOaC2finXosmrHcrIJfgR9F6YAr5u j9r80LzMPCv/vrwBZ3nfgKg69PrBn3mZCgl50cFob382Y2/kVeZOcv6hvlpk7ZrLcY8g=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.8948.259850.836226@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 17:23:00 +0000 To: Roger Pau Monne Cc: , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH for-4.15 2/3] firmware: provide a stand alone set of headers In-Reply-To: <20210226085908.21254-3-roger.pau@citrix.com> References: <20210226085908.21254-1-roger.pau@citrix.com> <20210226085908.21254-3-roger.pau@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monne writes ("[PATCH for-4.15 2/3] firmware: provide a stand alone set of headers"): > The current build of the firmware relies on having 32bit compatible > headers installed in order to build some of the 32bit firmware, but > that usually requires multilib support and installing a i386 libc when > building from an amd64 environment which is cumbersome just to get > some headers. Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:26:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:26:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91833.173315 (Exim 4.92) (envelope-from ) id 1lGmJS-0000VU-Se; Mon, 01 Mar 2021 17:26:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91833.173315; Mon, 01 Mar 2021 17:26:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmJS-0000VN-Or; Mon, 01 Mar 2021 17:26:30 +0000 Received: by outflank-mailman (input) for mailman id 91833; Mon, 01 Mar 2021 17:26:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmJR-0000VI-Qq for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:26:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmJR-00054I-PH for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:26:29 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGmJR-0003TG-ON for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:26:29 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGmJG-00051n-Pf; Mon, 01 Mar 2021 17:26:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=bA+VldAs5jFc9WhNWonTKwUQ2a0vJTe4ls32tzRPy8U=; b=GNxUwV/Utui3UDx+0VN3eXKYLX mbQT2oOUpgleFtNk6YWhkEEQNZm62D25fnSa0Wgh5a09KA+3+ozRsKmsaiFeHBewDScO3Ze9WNMNF qO5azUCWj89h40K+8kG2oGh3rwdvLJuaP4knVv8vAbY4wuOUhD2Pvr4XJ+2vFCO0yOrU=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.9146.479629.762290@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 17:26:18 +0000 To: Jan Beulich Cc: Tim Deegan , George Dunlap , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , "xen-devel\@lists.xenproject.org" Subject: Re: [PATCH][4.15] x86/shadow: replace bogus return path in shadow_get_page_from_l1e() In-Reply-To: <8bb04a4d-70ad-c557-c334-e1e55a429353@suse.com> References: <8bb04a4d-70ad-c557-c334-e1e55a429353@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH][4.15] x86/shadow: replace bogus return path in shadow_get_page_from_l1e()"): > On 26.02.2021 16:08, Jan Beulich wrote: > > Prior to be640b1800bb ("x86: make get_page_from_l1e() return a proper > > error code") a positive return value did indicate an error. Said commit > > failed to adjust this return path, but luckily the only caller has > > always been inside a shadow_mode_refcounts() conditional. > > > > Subsequent changes caused 1 to end up at the default (error) label in > > the caller's switch() again, but the returning of 1 (== _PAGE_PRESENT) > > is still rather confusing here, and a latent risk. > > The confusion on my part was so significant that I screwed up > the shadow mode fix for "VMX: use a single, global APIC access > page" (which turned out to be necessary) initially. Hence my > proposing this for 4.15. Right. I'm sympathetic, but I would like to hear from another maintainer of this code, as to their opinion about how much this change removes the potential for confusion. > I'm on the edge at this point whether > I'd even consider this a backporting candidate. I think you mean you think that even though the code does not compile to something actually buggy now, this is sufficiently bad a confusion that it risks bugs in stable trees, so you are considering backporting. Thanks, that is a useful piece of perspective. Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:26:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:26:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91835.173326 (Exim 4.92) (envelope-from ) id 1lGmJm-0000aS-4f; Mon, 01 Mar 2021 17:26:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91835.173326; Mon, 01 Mar 2021 17:26:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmJm-0000aL-1a; Mon, 01 Mar 2021 17:26:50 +0000 Received: by outflank-mailman (input) for mailman id 91835; Mon, 01 Mar 2021 17:26:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmJk-0000aC-Qp for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:26:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmJk-00055p-Q7 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:26:48 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGmJk-0003Wm-P6 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:26:48 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGmJf-00052J-0N; Mon, 01 Mar 2021 17:26:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=+FEMkIATtnZI7BsizNrwoeGSCwC1sVnqxPyGZaV7X8w=; b=g2I0GaITg+hx+V+j5DQBzVbJSC yYN6fcIqzEg3mw0xi1tPpZAehIaBzPq43l5tPAItSxzCsDwbm9UIf/bOAOOUkPEn3C4ia9bRQhmgH HUQnDHirdMD+LnNI/vNcxvv2/S0Hd+AqzQ1z5A+EReaKFo87QTG62nt77VUQxMxT1Pxc=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.9170.803610.335317@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 17:26:42 +0000 To: Andrew Cooper Cc: Jan Beulich , "xen-devel\@lists.xenproject.org" , Tim Deegan , George Dunlap , "Wei Liu" , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH][4.15] x86/shadow: replace bogus return path in shadow_get_page_from_l1e() In-Reply-To: <1ef6a569-f6c1-f20c-6b63-a5577cf95e36@citrix.com> References: <1ef6a569-f6c1-f20c-6b63-a5577cf95e36@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("Re: [PATCH][4.15] x86/shadow: replace bogus return path in shadow_get_page_from_l1e()"): > On 26/02/2021 15:08, Jan Beulich wrote: > > Prior to be640b1800bb ("x86: make get_page_from_l1e() return a proper > > error code") a positive return value did indicate an error. Said commit > > failed to adjust this return path, but luckily the only caller has > > always been inside a shadow_mode_refcounts() conditional. > > > > Subsequent changes caused 1 to end up at the default (error) label in > > the caller's switch() again, but the returning of 1 (== _PAGE_PRESENT) > > is still rather confusing here, and a latent risk. > > > > Convert to an ASSERT() instead, just in case any new caller would > > appear. > > > > Signed-off-by: Jan Beulich > > Yikes, and only 9 years to notice. > > Reviewed-by: Andrew Cooper Ah here we are, Release-Acked-by: Ian Jackson Thanks From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:30:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:30:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91845.173339 (Exim 4.92) (envelope-from ) id 1lGmN9-0001fB-Kr; Mon, 01 Mar 2021 17:30:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91845.173339; Mon, 01 Mar 2021 17:30:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmN9-0001f4-Hh; Mon, 01 Mar 2021 17:30:19 +0000 Received: by outflank-mailman (input) for mailman id 91845; Mon, 01 Mar 2021 17:30:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmN7-0001ey-9s for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:30:17 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0e9c89c6-9e0e-4b8c-af53-2761d26f755b; Mon, 01 Mar 2021 17:30:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e9c89c6-9e0e-4b8c-af53-2761d26f755b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614619816; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=lR/HYCIecE6kf2pG3OiqtR694KCh+SeXFHj7wbqsah0=; b=EZaf1t046eRJhVA/EVPqKvvsxuH2M9b4GxLWCRaCgWMD5jg0LTmhWlPe xk0AHHywnRvdDk8mtpRo1+4QT9JCGpnsICZ/jw89VxbXzHpKHfwEC2//Z BMfYIAqTMkLSNHPIc4RBZc90IcOOjHYYxLNhOZ058YpxCVgFB5e/92BQi Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: l1h6jFfLfxf5qBGBHLppmhL/2BFanr6MYrqn1zG7TcvGN4JhMmL+g54cThvP48ja/cVfhB4j9p 9cEjP52gMkO9c2Xsr8oL5ZOFVtnFtRhYhUvD45RrVhn1ca4jZB+j6zLtjycgEj9Fv6Jcqv59i0 Vyv4xFi8FlypsXW9ojPlyAQ2lq7n35yt69IxNnzq4x8AfrzBnc4UYnVCHNmj+0gZkJinCGqZV9 KEdMI1yBN4GMyZ4+WtSETIH+53swlUWlbtMzBjEvvhv0lF1g1UdViX5MHs5NlNgF84IVBcMhM2 2C8= X-SBRS: 5.2 X-MesageID: 38632535 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38632535" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UCrk13pYIE+QoRoWAsNpgToWQfDcB1KY3/JioEuZVmmF+/AM9F7q4hi/XrRmcHGtWsW2XnTCq9INs/PCMngn7de1sw1iQMMk9+tAFPRurVCoeAfWXbS81HJg0f2gUj2i6FNqq/XZJx0SfNZAAtRZjuwwyGjj6XGv6Uj04pmPEt3Zz/3eEIeO5rQBFPljm3PoyQnS++QXlv8ytO5crKYV01uJ6RAyehlTYgQ154Gx4zwmnjzV9VDPPIcfBx81aUccX9rIFnKbFPTnUEtk4jpY/McsEyvsnlzrfyjwNKQSCeQAAnSqKWeH9S0BmoA8TQwpG+3VucNBb0bGEPFW1kmjyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2qEcyVjdWqgAXa3p4YmBkzcGUrlehgofx17zUGsZcdA=; b=I1pEDjx9jKWjKdHDNzMAtkrxiO6A7L7/gM71KRFqqja8Qh9oH9RwOJF7G8UoedgApg6tTkqAN2jEHQ27KIl+vLKtYoB9Mxy3BLFg+5FXGWQMFCMZtXC14mupSBDSEMjNs/nh2fTEY/Ipaq13VEL7aG5ze+TgjApovOtY+X/cnRKpW4Pik8qPGtVxO6TfowBdTkOaoDwsOfPAUznolbAgNgEFfJPFATGdQJmcLzCY4U6c2NAIkEdG0TCmcDidCUwuN3BuKom7CcPMUUDze4dnS8wUFU4DkdaqHc3lPdqr0uynVzBtvICMIR/+L2Tcn2kD0ub9zXrG0MrZRUuX/8SMAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2qEcyVjdWqgAXa3p4YmBkzcGUrlehgofx17zUGsZcdA=; b=kF0vZaVFPPINxKCuox5biSoVNEbTkVbx7p1Et8MpW/BCxjSYQpA0EiJVTMlhzk9DLeafGNYn8UNLZmKfFINcvmRol2M9MIU79bWJWlaqLJ0dzVWZf+8mmKSrM4GGCPFmLsSq5SXg0ECkqrgpbjzH6gMK8HgoXbAg2qt/1XIEJkI= Subject: Re: [PATCH for-4.15 0/3] tools: ABI checking To: Xen-devel CC: George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall , Juergen Gross References: <20210301170044.23295-1-andrew.cooper3@citrix.com> From: Andrew Cooper Message-ID: Date: Mon, 1 Mar 2021 17:30:04 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <20210301170044.23295-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0093.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::33) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de85a261-c26e-43ca-e978-08d8dcd7ab7a X-MS-TrafficTypeDiagnostic: BY5PR03MB5047: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E8T/dEebbDFX3QJ8ujfIl/5EQz8q3WFAQHexVN6kJvapjd9NudYEFNORfWqVskTkHn9MFyK8/5pTePsFKRmaEWgIuHNI4F7zlA+8dVqgDBcTLshDeprbHxUXB9iYuKtfZajiieKQx4i/XdJceQQOCE/mZnS8XcC4odkZffp69gH5ENMH5bKvuJ5UOt2R1kqqq8kZPec2ThAgc1zqnoLOf8XjFAR6665089oiD9LYssVYAvnM6+j2GryNDNJw8yVwoLRPqOhn7wf1Y7xEZriZcP4m7kdiYvnxVAnvZZ3nx9JzJBf0TqBcvZ1lD37wH4/1ZgcpqiE4HNkit4Hy1jaqUifH84YVaV5sDLdHufdSThcWQ5WVvFYkGBeNK8L96zs1wsNNP6MHBizEPfz8Y3aLLo07AvKnXirFdaECFD+JpKsCrmHhQQ6+5mJrnpIa0UDUgiHAO/MXycl9747UkoM7MbBmwOrViulAYwFy/g4k5m9dsyURNYD+2FylZJzgpRpk3vE5lY3MiGmljvhFezt9O7ZSnZKzmuJdilagH+RI4fhujI1XLBEkFyzWhAAeAU7exL33FG2DaVWBD851yGj6d5BEHchtfth7g8/p1qciTYA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(346002)(376002)(136003)(366004)(2616005)(6666004)(5660300002)(53546011)(66476007)(16576012)(956004)(316002)(31686004)(4744005)(54906003)(66946007)(86362001)(66556008)(26005)(31696002)(6486002)(6916009)(36756003)(8936002)(2906002)(4326008)(186003)(16526019)(8676002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aEdackQvblJIcTNrUTEwUjZFY3pDVUErNTVJOEdydUdONVZhQU5QK1hBRUZn?= =?utf-8?B?cXRBaXZ3QmMxS0JrcjRYSEluZXVlK3pFN0NNYUdVcVh6aXEzanBhNWoyVTYr?= =?utf-8?B?cGt1blZOT3VqREpHbE9qTEwzQnFTK1YzbEtDajV5RnZxQmFjU283WWNqMlFH?= =?utf-8?B?OUJScHdyejQ5RkREUjFieDhKQmlOTG8zQ2dFaEs2ek5lY3hYVmlzUVdtWmNp?= =?utf-8?B?QjZJT3cvbUNiVGRrcFgzQVJucjNuTituRGZaR2ttaWkzM2w4U2FVT2cvQU5H?= =?utf-8?B?eVFXUVR0cWlqUU9NNStaVUJ3b3o3NDkxVW9veHBIR1RsWGl2bkQzTnVFN3U2?= =?utf-8?B?VGtEME5hSTdsM2xCWmtycCt4YmV2R0g4dzFmd3hxTWxpRzFCZ3M2OG84SEJi?= =?utf-8?B?RnRSbk14TnFyVjdCdFh6U1loOEZKVE5CQjB0WVZIdHBmK2FmL3hzRlN1V3Rw?= =?utf-8?B?b2s0RkExcVBEazJhNENGK2hydkpXbTRrSWk5RkUzMXJub0FGYmI4QVNuQjY0?= =?utf-8?B?bHF5RDRlTHBsbTRSV3g0NHNRS0p5T1IxdjE1OW9uZDlhNjhBemR3b1lrc2Vw?= =?utf-8?B?LzllMEJCbjZRWWMyRDBEOGVkdUNmb3o5WUFKaVIrcWdSSUk1UGloT0s3OG9G?= =?utf-8?B?T2E1cVVkN3FQRUtMWlBrRlF2ZCtqbi9mYjNUWXBZQkZpVUtqYzJ3Y0RzditO?= =?utf-8?B?ekpWcHp4TU1oK2Z1SFkwOEdyLy9seGJOWEY2QVNyN0RZbE1IaU5VY2h5Q0ls?= =?utf-8?B?OWUrci9YcysxbmxpLzFMRGxMdis3RjAxblVmVWhhdlJnSWMyNk93aGRIbldj?= =?utf-8?B?bnFjaXhwNXpiVzQva1pqZVczNi9vdGhyOXBqVXRiMVMzVnMzWVlCZnMxT2RO?= =?utf-8?B?OXAweE0wMThZRUFtOXhiTklGWEt0dTdSc1YwNnR3QzE0dG1lV2xkNW05VW90?= =?utf-8?B?QUtRTk5OUllpUkdVQi9hNFh4VVB2N3VsM0NYWkZGQW80ZWhSaXl1REdwMy9w?= =?utf-8?B?OVU5akFTV2VMcFh5OTFVZjRoS2kyK2haREZ4VVhlTHNYYll3QVFmc1JhQS9G?= =?utf-8?B?aVVFNFdKSkxKOSt1L0RpaXQwMVM4d0hlMDVraWExNWovaW5RTU1XMWhWM0RZ?= =?utf-8?B?VldJYXlwL1VSam5DZlU5Ry9zQXJabGYwMTRCbitIS1NKWmRNRkdCbjNCc0ZT?= =?utf-8?B?NWlzYzJaQnJMYmtFNDd2OGdWdDJOWEN5d1Rsa1hXcGV6MndEZ1BOM2lrWEdG?= =?utf-8?B?WnBWZTRWVGk2MG40UWlGYlJsSGtiOWh3cTRNSGpkZmtFWGgvbGhDVmp3OUxC?= =?utf-8?B?VTVJWWVyeDArc3NudjZOdVBOdEdHcU02MWJRMHlwT2crKzZTRDJMQ3FVN1d4?= =?utf-8?B?YXpjK05oeXg5aHYyUmxQZVlNVHRuZjUzUUtROUZJbDFYL3dQWlRuU28ra1NZ?= =?utf-8?B?UDNSWnB3N1lXN0ZOQjhhblZpRDNsNmJsQXFiZThpZ09CZVYybktSOEUrL0hq?= =?utf-8?B?UFBQUDVGRFJxYndKS2djTlp2SWtxdnBPamlKdE8vbUdmaXFjY1poS0dNSG1w?= =?utf-8?B?alhxbDFZZ1F2KzROSUk3OExFZWlnMHgyaElib1RjL25Hd2cwMjBrZXlzeC81?= =?utf-8?B?UkdYOWJGS21XREphdnpiRWpLWHYyS2dKclpCbGFuMDIwdzcvY2JELytmcEdP?= =?utf-8?B?RlRCQ3NkdlRCSEZTMkF3RmljR0VSaVRlNnUxY1pNRDRLcHdMU1pxN2Q5a0xP?= =?utf-8?Q?FDaF9Cprn7UUXmYAEErATvNkjj/OCgj+t+4SHtm?= X-MS-Exchange-CrossTenant-Network-Message-Id: de85a261-c26e-43ca-e978-08d8dcd7ab7a X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 17:30:12.7802 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZOewLPALO/m2dzu/AcJdxWhXcVdTf5YIKzmFpa2IsFQVSYrfXpEMmLqiec1XhRH68ackf7/bgc86Mg/yQYob49QFQNMSGrvn2NDuMnCYOsk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5047 X-OriginatorOrg: citrix.com On 01/03/2021 17:00, Andrew Cooper wrote: > Support in-tree ABI checking for stable libs. > > This series highlights a regression from 4.14, which needs fixing before the > 3rd patch can be committed. > > abi-compliance-checker reports: > > Removed Symbols 3 > xentoolcore_internal.h > xentoolcore__deregister_active_handle ( Xentoolcore__Active_Handle* ah ) > xentoolcore__register_active_handle ( Xentoolcore__Active_Handle* ah ) > xentoolcore__restrict_by_dup2_null ( int fd ) Actually, this is fairly easy: --- ../tools/libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump +++ ../tools/libs/toolcore/libxentoolcore.so.1.0-x86_64-abi.dump @@ -4,8 +4,7 @@            'Arch' => 'x86_64',            'GccVersion' => '6.3.0',            'Headers' => { -                         'xentoolcore.h' => 1, -                         'xentoolcore_internal.h' => 1 +                         'xentoolcore.h' => 1                         },            'Language' => 'C',            'LibraryName' => 'libxentoolcore.so.1.0', I'll throw a fix into v2. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:30:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:30:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91848.173351 (Exim 4.92) (envelope-from ) id 1lGmNb-0001lP-2q; Mon, 01 Mar 2021 17:30:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91848.173351; Mon, 01 Mar 2021 17:30:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmNa-0001lI-Vf; Mon, 01 Mar 2021 17:30:46 +0000 Received: by outflank-mailman (input) for mailman id 91848; Mon, 01 Mar 2021 17:30:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmNa-0001l9-32 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:30:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmNZ-00059d-V9 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:30:45 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGmNZ-0003m0-Tj for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:30:45 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGmNV-00053X-2W; Mon, 01 Mar 2021 17:30:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=Nmmne9Iw80A/Bd5bhKzBIv2n5PkRVbRY2Iui4VpFNXg=; b=JFI5qkwKwkc95kHG/labq1fbbJ iKOm2J2l8XRUvRHBuAeR8TQpgBcIYaethpVQlsD8ar9LHKlXTWBYl2g3mw8cFz0t/CtUEbUDv8cds coqEIXY6d8aKlRXH20v7RdYPUZzyPzqdjRUpRRqU4qW8J7rCnsJ7o8CY9tUrK8ECqvPE=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.9408.839033.439930@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 17:30:40 +0000 To: Jan Beulich Cc: Tim Deegan , "xen-devel\@lists.xenproject.org" , George Dunlap , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits In-Reply-To: <72c3c863-7465-ce26-1f57-b71227bb2b19@suse.com> References: <72c3c863-7465-ce26-1f57-b71227bb2b19@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits"): > On 26.02.2021 18:07, Tim Deegan wrote: > > Yes, I think it could be reduced to use just one reserved address bit. > > IIRC we just used such a large mask so the magic entries would be > > really obvious in debugging, and there was no need to support arbitrary > > address widths for emulated devices. > > Will cook a patch, albeit I guess I'll keep as many of the bits set > as possible, while still being able to encode a full-40-bit GFN. > > Ian - I don't suppose you'd consider this a reasonable thing to do > for 4.15? It would allow limiting the negative (performance) effect > the change here has. I'm afraid I don't follow enough of the background here to have an opinion right now. Can someone explain to me the risks (and, correspondingly, upsides) of the options ? Sorry to be dim, I don't seem to be firing on all cylinders today. Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:34:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:34:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91852.173362 (Exim 4.92) (envelope-from ) id 1lGmR9-0001wh-IS; Mon, 01 Mar 2021 17:34:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91852.173362; Mon, 01 Mar 2021 17:34:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmR9-0001wa-FQ; Mon, 01 Mar 2021 17:34:27 +0000 Received: by outflank-mailman (input) for mailman id 91852; Mon, 01 Mar 2021 17:34:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmR8-0001wV-T3 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:34:26 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7af00e26-e017-48df-b8cf-0c1b8628f957; Mon, 01 Mar 2021 17:34:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7af00e26-e017-48df-b8cf-0c1b8628f957 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614620065; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=bBZGwdEsMgCCCGBsaeq28+hzp7+XbceDPK7QYidNwW8=; b=BGss/6l+MFoFP2EDF0zR/HGM+Hg6mjIWOw8t9uKm1IM5XyfiuhTvsbJ/ xfGfohlZGfwna7D+KHHTI/05KGr2M96QFNy7Rhq+yScQbuqBqOFFBtLPL /XFa+Pc8hIFF8zD4VEG5qXGChHEZW2F5E/Ron4dhJG8lz9bqRSqG2eUw+ Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: acOxFDHKlY+t2BvIEz25gkiFzPtLxVJWMFqNwWgLSH0lDCeamDh8v7OFRziwEwsqzO9QAp8rSR mjPsUEMEsj4d2+VVzTY3XJAkPSO9g7BzdVp9/2sxip426yBio/gJ2koRWTHDkIov9mNx6bc7Cx NjZ8MLNIQQVh6fKHeUCfOWyiv+2G9het3c55/3fXd/0l5jI+fjqwBzCwe5zPHbH5E91dL/dOSV Xf4kCPIwmiuPxRVMorTc+SJnJhng05YiUAaDO+IL1baleoeiP1YGIB4lJVnR6P01rg2wcZUO7E Voc= X-SBRS: 5.2 X-MesageID: 38258181 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38258181" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q5O4z6U9EjluUpk9o9e4HHPsY+aWFrxeIZjSm8SwnIYc282RxVx0AMj4rfWD0REM03849HEvhzq9k5qa21ZBpzUzmyGGTwpDmiIboYVF9EeFGgvy5y76ZN5KUFqYtT2yBY2WfnCG7Gk6NP9c9Xr3FJ6piIOVSL1PCFZLLvje/6HDYPD2hVlK7MT66Rvwnd6u6ZIDn++GJHCTdP9G1DB6SPi65TERweoowZD+sQ4lyc70u+EfCEQFjuGvzU6lmrsk/rkYt+UkBBVENmCzV2QjjmZlzUK5OfAdg0XOid3qkyK32TLebg6g5VnyVJ79uPt++5FG1st1C2KQrSqPXqY5nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SwQ2z7c558Ji6M3CPWbw5WzYaOJmV2STZbVt+okV4FY=; b=dQyk+E+13DJ97b2wdkiFwGqc4Wbbucx0HEwfpw38sGt9pUMExBbiIJhnLxs2iQBQzCvPie4VgZAuBxZf3w5rAdiUgrkwUKf2MIPABQChlEh86mYUAJ/WXVPJeYzqOHcJtrqSnWAJLphgdpHR3YVoRbQ4Pd/4TBeXApfKE9Z3V8GyzQcghCnfUAzfbyHpoVSyQRaX/3F/LBaaVIasF/hVQECXhxRnSG6DAzfGU9gLRWBDUAKAOso4lu0bUqm7qrmj9OYp66zk5AjKpl2tKrHisRYfFyOQV5uW0iO3bRvnaNdCB4M6kEHTqwRXgIh1ZENKY6huN3kF/1OUPxJWgTAzGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SwQ2z7c558Ji6M3CPWbw5WzYaOJmV2STZbVt+okV4FY=; b=TKF2Ot0PAi7pVFjE8bFlYyTtQOHvXsPK7yvLRiycFnX/zwTR6sqT7pJJXdIsbvECAHQxHWIGkLyn/jew2qVlv4oSyWyB4YMKxwPwAopzCI1sequsycH4TcTgpBiFf2r06s8NGKOQLPqG1QYZbX55qZu+yyBSxDxsEfFwzbB+y+g= Subject: Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits To: Ian Jackson , Jan Beulich CC: Tim Deegan , "xen-devel@lists.xenproject.org" , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <72c3c863-7465-ce26-1f57-b71227bb2b19@suse.com> <24637.9408.839033.439930@mariner.uk.xensource.com> From: Andrew Cooper Message-ID: <99db39fd-e479-f71d-9cb9-5903ff6c12f4@citrix.com> Date: Mon, 1 Mar 2021 17:34:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <24637.9408.839033.439930@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0212.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::19) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 76dd7209-9e30-4560-232c-08d8dcd83fdd X-MS-TrafficTypeDiagnostic: SJ0PR03MB5438: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zVkrQhCskH9Ios1dKIHmg6pWJaKwZgekrRADmZQSS7h5hGNbMKAQtOOh3cZaPIkVhEGa4ExtEm2r0i6AIomEhELuqUDrsikcJ2V3T8QY9eb4GA2AcYQOguGTwBIz4Occb3OjyX3MYcEVV2ntEftMLZijDfB0hjeJFkaT5rvM5Rra+HodWN7N9Px3Dc9ISqaHQQrIYo67l+3V1kravd5mj31kz7HWllGgYavjgzUVH+RI5dUSK89oJBtqqa7XD75ITNyet4geIlTGHrz+Tk024b12ZTOMahoLu1+J/wzourSfV+ckkEAFqXwh4psaDcKr0Hm5HfzaZcbi+KCO14ltxx9uUJH4uLydGhGHJgg8IzROg94OUZuTneBnBnlLZxnINXpqUv+sV+gYbqA5WU+YNJcB1t73WczvupIDE93KHyJneoZu/1d3ilfT9rPlR0BA9uyuD5wDuEWSUaS6UGDTqUT5EMgT/HD6VYszMLkCSRGInH90YBK/f2QCTHbjnHe6SsNdxlJpJ+vfYMMFXaINSuMBY1DbfQiZd8Vk6Jakehtp8Jrsvt5yutSrVm8bEVMwfe2LshWtMpsSb40CmzzBYiigZz38Gwbf/fD2+5Fsdg4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(366004)(136003)(376002)(346002)(4326008)(31696002)(107886003)(316002)(478600001)(6666004)(26005)(16526019)(186003)(86362001)(36756003)(31686004)(53546011)(83380400001)(66946007)(2906002)(2616005)(66556008)(66476007)(5660300002)(54906003)(16576012)(8936002)(8676002)(6486002)(110136005)(956004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZWFCN1loRzFvZXcwQVhObVdLdlVJRkQwcHlTQm1qR1d3Ly8rTjFYSzJ4cUhn?= =?utf-8?B?aDlNbjZEc2RrOFNkODhLYzV4VWU0N1JmcHZRWjNrMlhxWVZHWC8yZEYzQ2U1?= =?utf-8?B?SzIxMjQraTEvT1BKK0ZEMDB2d1ZMcU5idEd3amVRM3Z3dTEzSTNaQ1lCVkxv?= =?utf-8?B?NFd2Q1pCMHYwUEc5c2NXY2V1UEM1RjhKWFpTQ0t5WGNQNnFOd29XN3ZqUlAw?= =?utf-8?B?MFNwcndEcVJ6THhsSS9abDNLNXJIcjJycjJ2QnB0MmNTZVZXZHg0UVNiQ1c1?= =?utf-8?B?YmxSNjdNYjY5MkhjSGhWS3d6THY0SkVoUy90d3RGaUJ6Z2hFMG1zbnFjVmlV?= =?utf-8?B?V0xEL3ZHa0s3UVdTcWFPRFZtelFBOC8vWnVVZStiMU41WlVUd09RL1M1blBz?= =?utf-8?B?alJWUTY0TmdKdkYrYjBrNTRFQXV3eXNWRTBlVzlHZ1Y3S29DajVVd2VCcTM4?= =?utf-8?B?RjZ1NjZFSkh2bXdMeUdwRjgzWk02bUt1Sm9iWDdvbzRiK1BLWVJXL1hYSzlt?= =?utf-8?B?MDRLYlhscWpJc3JoTUdLVmp5bTdPb3pQb2hlb2tmZXBHZUIrYlBnb2Jxd1dZ?= =?utf-8?B?U1pBdDIwRXU3RmswTXRDUnJ6SDNNdmZjVWE2aHJqYXdLTGE2L0hacjhGMXBS?= =?utf-8?B?QzRiL0Njb3JJcDhsMXM3UCt5dTZvSmd5VW56TVRXWEZ1MVJVVXY0elA0d3NK?= =?utf-8?B?SHg2V3JOWlhpTkFnY2JJOWt0VURMS05BTGJRUUJwMVFVdXlSR1F5YkppSzJ2?= =?utf-8?B?RVV0a0ZQaTE4c3RRRTJTaHRoU2JSc2IxWk10bXNZYW1UVGlWK2IrZzJ1T24r?= =?utf-8?B?NS9XdUZURnA1eDM0SitjK1M3aTVpUzYwZXFZaGxrZkVEZVVRTkM4WmRvQmJw?= =?utf-8?B?WStVSGxqRlRvbTR0WndBa0NKdG9sTm9mblNDbEJvdGJnZHcyeTBXcWdzcnEv?= =?utf-8?B?UVNTZ1BsSlNmMzNtdEVsT1k2ZlVoWklpWXVLbW9lcWpCc2l5RFV4NmVzNEZO?= =?utf-8?B?YmY0SkZJZE0zbXdpT0Nub0c2TnQrMWNONGNubDlVUzFKRmtGM2g4ZitZM3FR?= =?utf-8?B?YnRmLzNpUmJHRU1MaFpDdzBqcTBnNUsvZWplZG1yeURldloyVXRkZVRJbk1W?= =?utf-8?B?eVBzQis2WjJISDloRU1nWmQ2TVRncEtoc2pDUWdsejNldnJROFZjMGFGdUhJ?= =?utf-8?B?L3VPbnE0aEJQVFgxQnNxOVMyWnJwdmZoQmNVRVRtY2hXYm1jUm1NNko0YitQ?= =?utf-8?B?c1NZYWhtNDQzR1pZNFdEWEsvSnZRbGdoMXIyeWtHTm9rK2NkZm9HOHJZbjM4?= =?utf-8?B?SEMrdVBodjR3TDRBS1llS0pUYU9tTGcvRTJPYzF4MHBkTjhuQzJZU21aY1dO?= =?utf-8?B?akFoWlFHS0plczJzalJzUDFadHZhbkpWYWVGaXlaVEZhUWFEUWZIdXQyMDJl?= =?utf-8?B?SGRuUUpQNWN0VHd2RjdndWcrYUk1MUJadUFFRTRPMCtVcFVuY3FES1hQYzVq?= =?utf-8?B?SmtCV2w1bE1KaUpGM1lVeHYrSWFocjRLekRPV2RlRDdPVFVoSllhREVRYkk1?= =?utf-8?B?WW45amFLK09WbGdOanFBVzBuWitwR3ZUc2wvYXFKcG12QWorcDJlODJ2VjRl?= =?utf-8?B?UU1mT3MvVEM0SVV4V2VOdWNqTkpWYWtHdThMUENqSlVDVWd3U01RSW1yYjVN?= =?utf-8?B?RVA1MEs0TDM0Z0hEWU56dXNrV2w3OUhaMHh4L29kMHdsYmdXYkJYY3pDaVQy?= =?utf-8?Q?Q82WWj3EA8l0S4kBFvPCssY/hA676nEv4KdEy5R?= X-MS-Exchange-CrossTenant-Network-Message-Id: 76dd7209-9e30-4560-232c-08d8dcd83fdd X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 17:34:21.7697 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yarW3jlFYHZ5C1LR+egpxkljEqOOR5SK761vvSQgH0VVdNcxqrrX4ETkLlzD0k0/QqVcHvBo0rhUC2jMjKepqM+sqbdWplAYfqUU5jUXP8I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5438 X-OriginatorOrg: citrix.com On 01/03/2021 17:30, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits"): >> On 26.02.2021 18:07, Tim Deegan wrote: >>> Yes, I think it could be reduced to use just one reserved address bit. >>> IIRC we just used such a large mask so the magic entries would be >>> really obvious in debugging, and there was no need to support arbitrary >>> address widths for emulated devices. >> Will cook a patch, albeit I guess I'll keep as many of the bits set >> as possible, while still being able to encode a full-40-bit GFN. >> >> Ian - I don't suppose you'd consider this a reasonable thing to do >> for 4.15? It would allow limiting the negative (performance) effect >> the change here has. > I'm afraid I don't follow enough of the background here to have an > opinion right now. Can someone explain to me the risks (and, > correspondingly, upsides) of the options ? Sorry to be dim, I don't > seem to be firing on all cylinders today. Intel IceLake CPUs (imminently coming out) have no reserved bits in pagetable entries, so these "optimisations" malfunction.  It is definitely an issue for HVM Shadow guests, and possibly migration of PV guests (I can never remember whether we use the GNP fastpath on PV or not). It is arguably wrong that we ever depended on reserved behaviour. I've got a (not-yet-upsteamed) XTF test which can comprehensively test this.  I'll find some time to give them a spin and give a T-by. Without this fix, some combinations of "normal" VM settings will malfunction. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:34:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:34:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91853.173375 (Exim 4.92) (envelope-from ) id 1lGmRd-00021w-SC; Mon, 01 Mar 2021 17:34:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91853.173375; Mon, 01 Mar 2021 17:34:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmRd-00021p-P1; Mon, 01 Mar 2021 17:34:57 +0000 Received: by outflank-mailman (input) for mailman id 91853; Mon, 01 Mar 2021 17:34:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmRc-00021i-Dm for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:34:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmRc-0005EY-AK for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:34:56 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGmRc-0004FG-9U for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:34:56 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGmRZ-000552-0x; Mon, 01 Mar 2021 17:34:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=Q+8XN0d3qYX7XfRqB5/FPpslPfpdv3ZBVMyg4pSoVJI=; b=QT0NslL7Q87R5lAkkkq39Pf7tS FO4IAmCr+f+M0mYIH70V1HrUrk3csaar9FGX9ciiI7+zOHgyVJ4i6WrMflGsbE1V/Wc8vcCxjT2wx 3ycJXMj3/ei4z6YOUBqHVbgafFGJL0JwFROJdNuO6/gIlILCWb2fT+0IE/O6btj7AQ2c=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.9660.724649.505079@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 17:34:52 +0000 To: Hubert Jasudowicz Cc: xen-devel@lists.xenproject.org, Wei Liu , =?iso-8859-2?Q?Micha=B3_Leszczy=F1ski?= Subject: Re: [PATCH] tools: Improve signal handling in xen-vmtrace In-Reply-To: <26720bf5c8258e1b7b4600af3648039b5b9ee18d.1614336820.git.hubert.jasudowicz@cert.pl> References: <26720bf5c8258e1b7b4600af3648039b5b9ee18d.1614336820.git.hubert.jasudowicz@cert.pl> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Hubert Jasudowicz writes ("[PATCH] tools: Improve signal handling in xen-vmtrace"): > Make sure xen-vmtrace exits cleanly in case SIGPIPE is sent. This can > happen when piping the output to some other program. > > Additionaly, add volatile qualifier to interrupted flag to avoid > it being optimized away by the compiler. Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:39:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:39:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91862.173386 (Exim 4.92) (envelope-from ) id 1lGmWD-0002Mk-E0; Mon, 01 Mar 2021 17:39:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91862.173386; Mon, 01 Mar 2021 17:39:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmWD-0002Md-Au; Mon, 01 Mar 2021 17:39:41 +0000 Received: by outflank-mailman (input) for mailman id 91862; Mon, 01 Mar 2021 17:39:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmWB-0002MY-If for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:39:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmWB-0005K0-EX for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:39:39 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGmWB-0004fC-DZ for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:39:39 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGmW5-00056B-Hb; Mon, 01 Mar 2021 17:39:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=Qvrhwslv7ahGD8X6RC4cULWCcw+pYjGYuF+RgcPIFvE=; b=I2dR5ef3heBctkhaot5V1HfO6l g+vsDv91/H5KH8GtbK7/O5XnFZoRWzBAoYXtosW2d/KjrpNX6shLaam3yycFGKV4bXkatzhh2xtbj rKcyx6uI0rOkAXOD3INcbvJ3c+jZc5dA0M8+XNAQDAnHVajcpe9ZPBluUCF3PK/D+2ac=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24637.9941.299951.66421@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 17:39:33 +0000 To: Andrew Cooper Cc: Hubert Jasudowicz , , Wei Liu , =?iso-8859-2?Q?Micha=B3_Leszczy=F1ski?= Subject: Re: [PATCH] tools: Improve signal handling in xen-vmtrace In-Reply-To: References: <26720bf5c8258e1b7b4600af3648039b5b9ee18d.1614336820.git.hubert.jasudowicz@cert.pl> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("Re: [PATCH] tools: Improve signal handling in xen-vmtrace"): > In which case, what other signals potentially need dealing with? Lets > get them all fixed in one go. > > When that's done, we should make it installed by default, to match its > expected usecase. With my tools maintainer hat on: TERM INT HUP PIPE QUIT Not sure if we can be bothered with SIGTSTP. If you want to be nice, when a signal occurs. arrange to re-raise it after cleanup. After all, exiting with stderr blather and a non-zero exit status, merely for SIGPIPE, is rather unfriendly. This means writing the signal number to the volatile. With my release manager hat on: I do not intend to give a release ack to install this by default, at this stage. It would have been better to have made this program a proper utility from the start, but it has now missed the boat for being a supported feature for 4.15. OTOH given that it is not installed by default, nor supported, I would welcome impreovements to it that I don't think will break the build. Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:40:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:40:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91864.173399 (Exim 4.92) (envelope-from ) id 1lGmWe-00036q-ND; Mon, 01 Mar 2021 17:40:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91864.173399; Mon, 01 Mar 2021 17:40:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmWe-00036J-JY; Mon, 01 Mar 2021 17:40:08 +0000 Received: by outflank-mailman (input) for mailman id 91864; Mon, 01 Mar 2021 17:40:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmWd-00034T-52 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:40:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmWd-0005KQ-45 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:40:07 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGmWd-0004i6-1h for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:40:07 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGmWZ-00056i-NK; Mon, 01 Mar 2021 17:40:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=qgtapO+c1+Y+53b3XfTDDeXeOJrFPIfE+5uS3cFh9nc=; b=gDBk02pQWy4sCyVyOMAorgiom4 AlSqNdYKuxIT1e+cOb1/rdlbobmTdlE6VVTEwsG4uvO3jpSs+fdx4Cq/gI+S1DzrLqPvT+7e+cs70 tdSkt8asYdhnCFlQYqgntTpvs9yhRJndW6jsvTe/XcFl+3ON4QFLg82h1rztRe0kp1Mo=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24637.9971.519283.948123@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 17:40:03 +0000 To: Julien Grall Cc: xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall , Wei Liu , Juergen Gross Subject: Re: [PATCH for-4.15] tools/xenstored: Avoid dereferencing a NULL pointer if LiveUpdate is failing In-Reply-To: <20210226182655.2499-1-julien@xen.org> References: <20210226182655.2499-1-julien@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("[PATCH for-4.15] tools/xenstored: Avoid dereferencing a NULL pointer if LiveUpdate is failing"): > From: Julien Grall > > In case of failure in do_lu_start(), XenStored will first free lu_start > and then try to dereference it. > > This will result to a NULL dereference as the destruction callback will > set lu_start to NULL. > > The crash can be avoided by freeing lu_start *after* the reply has been > set. > > Fixes: af216a99fb4a ("tools/xenstore: add the basic framework for doing the live update") > Signed-off-by: Julien Grall Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:43:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:43:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91868.173410 (Exim 4.92) (envelope-from ) id 1lGmZm-0003K4-57; Mon, 01 Mar 2021 17:43:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91868.173410; Mon, 01 Mar 2021 17:43:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmZm-0003Jx-27; Mon, 01 Mar 2021 17:43:22 +0000 Received: by outflank-mailman (input) for mailman id 91868; Mon, 01 Mar 2021 17:43:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmZl-0003Js-0r for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:43:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmZl-0005Og-00 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:43:21 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGmZk-0004uH-UT for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:43:20 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGmZd-00058Q-6i; Mon, 01 Mar 2021 17:43:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=U0CreRcQ5HyG0Zvfrs3/RntpCAxbuwUTGhco0LWVEUw=; b=kLTDbOqGLa4gKlD20i826701tH RVoCNycZ8I47InaFY3Z1pwDTQlA17aKX8N/KUy1ftCqExDBvE45nYVNd+/vKjwZvMSN5sBucw3jJ6 gzEKZSADrquI3zdvLYif2lEostmN6TQY2C3Z8ro49tmBP6aol3yF5oklVIH/o2XIAI4Q=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24637.10160.977640.808417@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 17:43:12 +0000 To: Andrew Cooper Cc: Jan Beulich , Tim Deegan , "xen-devel\@lists.xenproject.org" , George Dunlap , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits In-Reply-To: <99db39fd-e479-f71d-9cb9-5903ff6c12f4@citrix.com> References: <72c3c863-7465-ce26-1f57-b71227bb2b19@suse.com> <24637.9408.839033.439930@mariner.uk.xensource.com> <99db39fd-e479-f71d-9cb9-5903ff6c12f4@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits"): > On 01/03/2021 17:30, Ian Jackson wrote: > > Jan Beulich writes ("Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits"): > >> On 26.02.2021 18:07, Tim Deegan wrote: > >>> Yes, I think it could be reduced to use just one reserved address bit. > >>> IIRC we just used such a large mask so the magic entries would be > >>> really obvious in debugging, and there was no need to support arbitrary > >>> address widths for emulated devices. > >> Will cook a patch, albeit I guess I'll keep as many of the bits set > >> as possible, while still being able to encode a full-40-bit GFN. > >> > >> Ian - I don't suppose you'd consider this a reasonable thing to do > >> for 4.15? It would allow limiting the negative (performance) effect > >> the change here has. > > I'm afraid I don't follow enough of the background here to have an > > opinion right now. Can someone explain to me the risks (and, > > correspondingly, upsides) of the options ? Sorry to be dim, I don't > > seem to be firing on all cylinders today. > > Intel IceLake CPUs (imminently coming out) have no reserved bits in > pagetable entries, so these "optimisations" malfunction. It is > definitely an issue for HVM Shadow guests, and possibly migration of PV > guests (I can never remember whether we use the GNP fastpath on PV or not). > > It is arguably wrong that we ever depended on reserved behaviour. > > I've got a (not-yet-upsteamed) XTF test which can comprehensively test > this. I'll find some time to give them a spin and give a T-by. > > Without this fix, some combinations of "normal" VM settings will > malfunction. Thanks for that explanation. I don't quite follow how that relates to Jan's comment >> Will cook a patch, albeit I guess I'll keep as many of the bits set >> as possible, while still being able to encode a full-40-bit GFN. >> >> Ian - I don't suppose you'd consider this a reasonable thing to do >> for 4.15? It would allow limiting the negative (performance) effect >> the change here has. I already gave a release-ack for the original patch. I think Jan is asking for a release-ack for a different way of fixing the problem. Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:43:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:43:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91869.173423 (Exim 4.92) (envelope-from ) id 1lGmZv-0003Nu-IE; Mon, 01 Mar 2021 17:43:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91869.173423; Mon, 01 Mar 2021 17:43:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmZv-0003Nn-Dj; Mon, 01 Mar 2021 17:43:31 +0000 Received: by outflank-mailman (input) for mailman id 91869; Mon, 01 Mar 2021 17:43:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmZu-0003NR-47; Mon, 01 Mar 2021 17:43:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmZu-0005PE-01; Mon, 01 Mar 2021 17:43:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmZt-0007My-HT; Mon, 01 Mar 2021 17:43:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lGmZt-0004cN-H2; Mon, 01 Mar 2021 17:43:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DjAUgtXKxprraIPQMk/Pmhya5r7/bRtL867prj6Rhfw=; b=ZWyi2zNku0C4lJfly8jiYDiNnU gtz+zuCNHlgrM04xxl+Po/7K8UBU0HflEzj68Q4uaBQQgVLiJNrszMxHhjrgaTiq/u+MIeuMy2QO0 lAZYL/x1W3naW3VW4wfa9+a/3ujqf9Dfz2VFgPtLR4V9UaCPxq1nxrMAOba28D/aIWD4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159789: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-localmigrate/x10:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 01 Mar 2021 17:43:29 +0000 flight 159789 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159789/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 19 guest-localmigrate/x10 fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 212 days Failing since 152366 2020-08-01 20:49:34 Z 211 days 366 attempts Testing same since 159789 2021-03-01 03:59:22 Z 0 days 1 attempts ------------------------------------------------------------ 5135 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1270853 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:51:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:51:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91894.173437 (Exim 4.92) (envelope-from ) id 1lGmhA-0004Uh-Cg; Mon, 01 Mar 2021 17:51:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91894.173437; Mon, 01 Mar 2021 17:51:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmhA-0004Ua-9p; Mon, 01 Mar 2021 17:51:00 +0000 Received: by outflank-mailman (input) for mailman id 91894; Mon, 01 Mar 2021 17:50:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmh8-0004UV-Qv for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:50:58 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0348337c-8ea9-4830-a1e1-536fe6aafd1d; Mon, 01 Mar 2021 17:50:57 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0E7E8AF4C; Mon, 1 Mar 2021 17:50:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0348337c-8ea9-4830-a1e1-536fe6aafd1d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614621057; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e5HKoGfB+y3kGY6j/M2cTra3AtFkg6Jyv/agP8L4YLE=; b=fE9yIycheN9ey4oOYZxyu5EHgROYIq5Uv60QQfQDCwi5GiSlLTNslO8CaPqLQNtdmv/6VY YrnXBQiYXeqgnAELupqBK/X1hMDkgAp+49P7SGBbKXtE8+eg0dGzTfueLvYGfRjetOUSGF dz1rGkFi1G3KGlOJ9/2RmtCeahBwpqo= Message-ID: Subject: Re: [PATCH 1/2][4.15?] sched: fix build when NR_CPUS == 1 From: Dario Faggioli To: Ian Jackson , Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Connor Davis , George Dunlap Date: Mon, 01 Mar 2021 18:50:55 +0100 In-Reply-To: <24637.3828.576373.217715@mariner.uk.xensource.com> References: <171d1da4-e87a-b154-5c63-a5627d4f93bc@suse.com> <24637.3828.576373.217715@mariner.uk.xensource.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-fccuFZjL47jbsyiNtCxn" User-Agent: Evolution 3.38.4 (by Flathub.org) MIME-Version: 1.0 --=-fccuFZjL47jbsyiNtCxn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2021-03-01 at 15:57 +0000, Ian Jackson wrote: > Jan Beulich writes ("[PATCH 1/2][4.15?] sched: fix build when NR_CPUS > =3D=3D 1"): > > In this case the compiler is recognizing that no valid array > > indexes > > remain, and hence e.g. reports: >=20 > Release-Acked-by: Ian Jackson > Reviewed-by: Dario Faggioli Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-fccuFZjL47jbsyiNtCxn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmA9KX8ACgkQFkJ4iaW4 c+6ymA//RFzhIH5gRtTneO0vzKGGRudW8BWVKRCWCz1vMtrH/68At6K1n2217jXn ETwdEVC2pmccK3zYDN5cnnV0Qg/assfeuB0mD/Emikw5dFKdOSk5hKxcYBaO0ltM lAE8L2LBXRkZjLG8ae2X1OV+ekoNHMs0Oo14lNNqTy+eJfq0zpy6UKdeN4ly61Q7 7bNG7LruOQGE2HwAPZ5Kf+W83NzhVt+sh6lbITsJ2ybGNvIOisuSkysazHmczigC yfukvxXM5/RXu36j1f2x/9LoDo0CoU4T2g/ULFh3ozKUpzqitL7IqEu+2Vk6iDHh h3Bfef96mLPl8mTJ9qD/iMY8PWFxX/z06xdP1Je7a6XKZxfxIwt7YuEpn0G/X/iy v9hNKr/pDA10vRpWTUlKbxrMEtb4DNiwcAHI2YeTnl3+oJEZL78H9/VwYblYWj/a wXwA4UphglrEsJRwgmg9h1iHJVM5c0z/BZLRfn4ztz++diW6GD2oHCymCILM79ZI oM8qQ+RzhEV7uYqHPqzGJ2PT+Bf3OTYDN9YmBe2Co7giVwJsviS9QjPihgTsHF8q uEwyRKip1JAgpDvCltqvZHGDkm+NeqytHx0y16B75wV1+fj7L9XrAXMwPptpB0qQ p65EFxCk9yAmz/td3tH2pNHb7AJlf1XFDxM8nq7WldGzcYfZQfs= =TGRu -----END PGP SIGNATURE----- --=-fccuFZjL47jbsyiNtCxn-- From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:52:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:52:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91896.173450 (Exim 4.92) (envelope-from ) id 1lGmiM-0004cF-Nt; Mon, 01 Mar 2021 17:52:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91896.173450; Mon, 01 Mar 2021 17:52:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmiM-0004c8-K7; Mon, 01 Mar 2021 17:52:14 +0000 Received: by outflank-mailman (input) for mailman id 91896; Mon, 01 Mar 2021 17:52:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmiL-0004c1-DZ for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:52:13 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 83a2bf0d-b35b-4ab9-a9c4-77d8c34fbaea; Mon, 01 Mar 2021 17:52:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83a2bf0d-b35b-4ab9-a9c4-77d8c34fbaea DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614621132; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=FZXC0VidLQL6hHv3Yur34SirW1hs57x5e35Io7PoxC0=; b=bGXkzaJc1+dhCgZ76qedToNO5Uhl9iiDfiqA42UkMLX8mJVniJMME2NO beESQspGQQKrrdoAyCs8hI/ZcSH+UQjA9ZRMYZQPYkSjrezzkBxV9uuAa MABG1LD4IAkoL5CjuA/hqAeZbctPJlmZjJlA2HnRm5fh5MFZQPmCZN+YK I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: AsyBMN6QSkhSGzmL8LJDNrCe06uCBmzwnwZLeW6y5UDKaMoYE8Ep7Gf3k5wpTLRUjFh4ZIleRG A23q6Y0tVOVTvaF81kb0D5qTTXQ7Y5/xus1yEvugdedrskpzPimFLlcmn5a/lLy6w7dwq+keXX 0Js3GtBlkoOQqb5ksbAJIpo5RB7+Df6gDx6XaJa/cMViHhsB6DCt6HIab7k6jie7Yxt5GTjswe VzCDzGYYEK6nP6X0PViY3SlDIjIJ52wq+2HRQmI387zaY06A9p0+462uuLzERRTaFuPbNJRimV hmg= X-SBRS: 5.2 X-MesageID: 38634359 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38634359" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GYp5REqLBxXGBNlci4MDrHTaY+zh+fl/BscA5MrYJj6NjoUBupA71oMRFWdx2Fkz7vuoyTbK4F8o5nfhqpwqnRV6t0odO0B1aAyaTBn/QjJxpFVoH5NS8wagVWjMpJQ6W7lj8sSgFLaQ90UofrYOOvpi39+HdRMPoy3eImMN2PdNBYXcqwD0m3AuXbOAo3O5k7hdcVveFTDQueiofTjWr16LepmdYDokjv0cUxX5bbxZ+0q+c1gLwNIk2DvpbTyT53UY/GAlZ1X0Ex7o8GQN5pHrSdjbfeXVNeNH50h2wLYv7vyQPp/2fja1LnPjsXCiOPrEcmcP/GhSDLtvICvdkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+vO6ge7pGSUMm0wQHeGn2y/o0F5PADTZi596ljeQehg=; b=CBGoX7L3rb4/W36upR+7b5G4vySVsyV48JewgsVqsuWhq0uSO9Olx505KN52NERN4A4aZibRcmmfyiP4kiUFdYHq0iPXnBLldZMg2IJUbLNs8sEpcoVDuWYF2NwpnL4aD7axbf38DNihDTQfPgedaIPjoCDV9p7id/yOXq1r3SjgNHbNG+sh2riVw4a68vHR9Xpkn9z7OHEzN6DvJVpH4H/hjQx9SelVC/vwuot7qWBOsc6hQ8h5RXbnmUnY1o37VU76XgfgKASNlDy5d6r/IAXQmvIapoi3V2cqSoI3CfJ6X5SCvzBEsMdRhi6AXiWp+GdbQ1ywtYkmiHIoSvCHgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+vO6ge7pGSUMm0wQHeGn2y/o0F5PADTZi596ljeQehg=; b=jm3xXDxH5thdz/2ILmz3N7sq4eHvjBSOB5wsRtFNgGhOG5xqT3sSVITavjbqQLs9rJtviH1CU2n+67QMwBzvc1GQ3zj9YLWRWhGe1jW32MoUOrovnuL7o2wl3GexPAjYIqwUAW+mD55Cy8KxQsnIcFbISKb94dRw9InXdvNqJNQ= Date: Mon, 1 Mar 2021 18:52:02 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ian Jackson CC: , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection Message-ID: References: <20210301162357.76527-1-roger.pau@citrix.com> <24637.8562.514355.845883@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <24637.8562.514355.845883@mariner.uk.xensource.com> X-ClientProxiedBy: MRXP264CA0025.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:14::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 33d0c404-ef86-4297-798b-08d8dcdabc24 X-MS-TrafficTypeDiagnostic: DM5PR03MB2554: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hU/ODPY+A/uuIvyWZoES1teoG+Ta2fh/rxik520Y3XpxU6cFCGqIM6ZwBakVkzwVzxSXaSe1ODkZOO5xz1wd/JaRBdXwTBr/Bb5Hszcgy56na3y1jz66SbNt5vFDTJ2oYCDPa4LTaDLEeIxpspXaxZPIHYRx60hkRniJPzeeFADTHYzyUVtt8tCZ1CReJ+Csp6WycuBc5IDETY7CGkx8/0Xxd0vTPo+1ZxKt2wNV2yiDACLDmar5zTjvGz+ze21ohGNE3kGF1BJMkBydBBsiWcpcm1xb/nJkm3tgPrcND30V3Ag2n0dKlDmDe3BiCHChntEHkoZXlnQrubjHrjAg0viTVNoKGtx1JANzqiGAXXi3JZFMnfDB5mvZu8QanPbDk2/wGrLJEQmrDkWKYiAw9IxpKQLJ10V0e2mGTjVhv1hYgjkgrK5RTmUcE7MvVXj75KY4EbaLny4mRJHAN5Kh6X26VFbvLOXousgVI5SXf0QHiiaYUBhX4g6j4zCR0MH4lMI8YGGN7Nqo50XOjN5u/g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(346002)(376002)(39860400002)(136003)(396003)(4326008)(478600001)(5660300002)(54906003)(85182001)(83380400001)(6486002)(316002)(6916009)(2906002)(66946007)(66476007)(9686003)(6496006)(6666004)(86362001)(8936002)(33716001)(8676002)(186003)(956004)(66556008)(16526019)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?QjBNWEhUbW9VSTJyVURJa1VLNk10RU5ya2t3eEZMSjFVM3hNWldTYU4wSkVs?= =?utf-8?B?Nm9mVjFjY0E5dWZDTmxXTWduNjB0Mm1JUlhYNUk1YlVnYXc2ak9KWWsrNFFY?= =?utf-8?B?MEg2bW1WUFViWlplSzJqQ2hXWEVJUnc5dFhOL0ZuQm8zalQzVHExV3M3ZnNl?= =?utf-8?B?bUhocXRXRGxRdHFyVzhjUVhBNHBBUzRUUG5FVExhbGFvd1FGSWJWWU03a25q?= =?utf-8?B?WXZ6Y0hpOStTUnJ4TnFua3U4OG92dStnODg4bEljMDM2SVNqcjNPYjg5dWxs?= =?utf-8?B?c3dUSzF4RWFxb2pzMXk3RSsyKzRxOFJSRTQ1cDNMRFdLOTUxV2hMelFhWU9i?= =?utf-8?B?ODZaVXBlQ2oyUTVQSUF0aUZEblR2ZmpIdVNLdG1zYUdDeU9hTEJDTDZsanpX?= =?utf-8?B?ODVkVkRkaEg2QjAzZXpkb21UeTZnaHB5dnVMWUhSYWNZVWZ0QkJnY0M3RTVj?= =?utf-8?B?KzQxajM0MFlacTRaV3dUUElzNmc4Y1J5bVh1Vnl3RTFGaXlpUzl6eXdwSFI0?= =?utf-8?B?R0p5c0x0ek8yNWpVd0ZCMEVYbTUzcHBtTWwvY0tzMG1aYWhadzNCQjlNb0p3?= =?utf-8?B?UEdjQ3J2VUNyTmdxSHhLZ1FQeFMwOERRT1ArbGdDbUJ5bHNPOHZBRUtpemFr?= =?utf-8?B?M05zdDc3R3BsTDJrSXNRR3Uvb0NkZCtRYWxPMzZCM0tLMjQ0NW1lbDdTblR3?= =?utf-8?B?QW1oRWphSW50TUdIR29KbDdDaittaFVYK1U3Y3NyeTJKczQ5WmgrRGtVWVlh?= =?utf-8?B?bkgrYmRIalV5VUxQejB3T3YzSVVUekViRGsvVnRVUFowZmJRcWlMNGVqVS93?= =?utf-8?B?eXBkU1JoUklmSjhqclB4UUNac3B4WnFJTjBKRUkxcitRRmVkblQ2ZEhMbHVp?= =?utf-8?B?TFRTbG96Y3hwWHhPMFJ5T1lVN3FOY0NMU1ZuVUE1dExvN0pPL2l4YUNVS0dp?= =?utf-8?B?N3QrTERubEFpejZoNkMyQmpYamxuSjNObHpOL21hVldhNTdLTlZ2RUo2aE1s?= =?utf-8?B?MmNleXJLS2xKWnJKb1JuZkY5UjloTy9GWXVUMUJLaUJ3dWd3dDU0QnNQcjQx?= =?utf-8?B?L2VWT1ZLT2RkTlROd1FET0Ryam9qdlVoaXhvdnFFVzR2eHhyRkpWNm9IcWJp?= =?utf-8?B?OXRWRUFWOUtTS01XZi9ycjA5SXZaVmFHb3FqVjJlQVhQcGRscmRha2Z2d1RR?= =?utf-8?B?T1ZFY0NuVEZmVGRiVEYzK1BGT0c1cWxvK1B1Uk9jNW55NjNmbGYzVGduQi9n?= =?utf-8?B?SEpVUnMyY0dqV3BPM0p1ZHU3L1d1TWJteGwxb3AwKzNyNTBzdjlldUtHc2Nm?= =?utf-8?B?aXdYaE5qdG1tOXFXSGowdnNMNzRXQ2dsQ0s5Q0RJZTFBRVFzZ1MxT0dneWl4?= =?utf-8?B?SjhEamVRU21WVkNyK1UzRUdJZGhnUzdDazBHN1J5bjEyditGTVQ4alNLd25Q?= =?utf-8?B?SWhmVW55Ui9RUldQNWUxbjA2eFRhQ3g4VlFoZk03V1FkaUpsQS9VYW53NkdX?= =?utf-8?B?QzBsYUVpNFcvNU02Y1JtTnhRdjVWVWtFbUZ0aWI5MU1EWUd2MSs3MjRmVmlo?= =?utf-8?B?bktjYmJiQTgvT2tKdlVLVGljekNQbWIvdXlVQk5FUnlmeDdzYkUzU0lBc1BP?= =?utf-8?B?bG53SnNMTEIydUxGdktMRlhBZUk4R0FIZWhuNk03RlR0YUpIU3gvNWdYZXkw?= =?utf-8?B?Nk12bVpSWEJ2Mmw1YjRuQlpLZ2hvMXgzZ2dWNVN2V2R4T3JnYnpCV0tSWWFX?= =?utf-8?B?dGI2OE0xaElnNzROajVoU1AyVm41WkxQTlIzdzRZeU9FV2h0eDJpdGJoblor?= =?utf-8?B?VkxXNU9WcU9yS2RCb0FTdz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 33d0c404-ef86-4297-798b-08d8dcdabc24 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 17:52:09.2773 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EnUhtw3lNg6z8yhEqiAUnyWwE2nrIyBj5/f37LSkMMZpV1D/PwqddZgacd/8dV0cQBNic7TE74boZXXLBZZ4XA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2554 X-OriginatorOrg: citrix.com On Mon, Mar 01, 2021 at 05:16:34PM +0000, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection"): > > Introduce an option to allow selecting the legacy behavior for > > accesses to MSRs not explicitly handled. Since commit > > 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly > > handled by Xen result in the injection of a #GP to the guest. This is > > a behavior change since previously a #GP was only injected if > > accessing the MSR on the real hardware will also trigger a #GP. > > > > This seems to be problematic for some guests, so introduce an option > > to fallback to this legacy behavior. The main difference between what > > was previously done is that the hardware MSR value is not leaked to > > the guests on reads. > > > > Signed-off-by: Roger Pau Monné > > --- > > Cc: Boris Ostrovsky > > --- > > Note that this option is not made available to dom0. I'm not sure > > whether it makes sense to do so, since anyone updating Xen to such > > newer version will also likely pair it with a newish kernel that > > doesn't require such workarounds. > > > > RFC because there's still some debate as to how we should solve the > > MSR issue, this is one possible way, but IMO we need to make a > > decision soon-ish because of the release timeline. > > > > Boris, could you please test with Solaris to see if this fixes the > > issue? > > So AIUI this patch is to make it possible for Xen 4.15 to behave like > Xen 4.14, thus avoiding a regression for these troublesome guests. Yes, sorry I haven't provided a release executive summary, as I wasn't sure this would be acceptable in it's current form. Can do if there's consensus this is an acceptable fix. > Have we diffed the result of this against 4.14 and if not would it be > a sensible thing to do ? I think there will likely bee too much noise, we have changed the MSR handling a bit from 4.14, so it's likely a diff to 4.14 is not going to be helpful as the context will have too many changes (albeit I haven't tried the exercise myself). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:57:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:57:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91900.173462 (Exim 4.92) (envelope-from ) id 1lGmn9-0004ov-GR; Mon, 01 Mar 2021 17:57:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91900.173462; Mon, 01 Mar 2021 17:57:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmn9-0004oo-Cn; Mon, 01 Mar 2021 17:57:11 +0000 Received: by outflank-mailman (input) for mailman id 91900; Mon, 01 Mar 2021 17:57:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmn8-0004oi-NP for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:57:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmn8-0005dX-Hy for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:57:10 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lGmn8-0006Af-Ey for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:57:10 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lGmn5-0005Av-7H; Mon, 01 Mar 2021 17:57:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=/tsqDgDiCXCBV/dlxEtU4ZyBhohY5NbuMKO23ydx0Ac=; b=Fd8eZPyttvCHYPOI8z/Y4ahAbm rWzwcxzMUbn+iNZWCQILcd+4l5Vop1GoQYsp5qgXkIck1x5KvDe4+MCXiHrx5fKzQkgT68teA0tNa kw/PqP2cpehQE/HnTAtOfOqtLXgwqAKRGKFtDGm527yO2vOC0dPsKi02exJFJichmWRg=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24637.10994.995547.72710@mariner.uk.xensource.com> Date: Mon, 1 Mar 2021 17:57:06 +0000 To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection In-Reply-To: References: <20210301162357.76527-1-roger.pau@citrix.com> <24637.8562.514355.845883@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monn writes ("Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection"): > On Mon, Mar 01, 2021 at 05:16:34PM +0000, Ian Jackson wrote: > > So AIUI this patch is to make it possible for Xen 4.15 to behave like > > Xen 4.14, thus avoiding a regression for these troublesome guests. > > Yes, sorry I haven't provided a release executive summary, as I wasn't > sure this would be acceptable in it's current form. Can do if there's > consensus this is an acceptable fix. Thanks for the information. I am in favour of fixing this issue. I have it on my 4.15 blockers list. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 17:59:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 17:59:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91908.173474 (Exim 4.92) (envelope-from ) id 1lGmpY-00053x-Uh; Mon, 01 Mar 2021 17:59:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91908.173474; Mon, 01 Mar 2021 17:59:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmpY-00053q-Ql; Mon, 01 Mar 2021 17:59:40 +0000 Received: by outflank-mailman (input) for mailman id 91908; Mon, 01 Mar 2021 17:59:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmpY-00053l-05 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 17:59:40 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id adc30c75-6da9-4b44-a643-2940c724ddc6; Mon, 01 Mar 2021 17:59:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: adc30c75-6da9-4b44-a643-2940c724ddc6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614621578; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=HtEbb7+yjILyEipvhEJ/t0xFBDZKakY0hz3Ddxvp1Ng=; b=SueSg2cZF/h/fa7OcCMJSY3nZOT6vbZ2bsd6H0XIwuV1C0pjaM2RzHcE oz2zOwayhxcJnb8hU8EKRxLWghF6Xo1zKNUc+NIGe9puqTVbVTBeXmSRR nElo1tqxKTA7mVWSH2ATuOULuwbjbceQBg4bz0yn9Dos8ODcTDJ9k48bI I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: TGBOvHx8lMx0MkIa56QrgFGalQzgNFy68i5jBIf8kWn3X8wsDL68zL9muBhBrIZFYzyJvTPGTS 1RMbYKM+fbmqZoAgwQLjyHtM0fmZWvIm/WrH0aC1N+iZ/uCkVqHH8O58EE8qBD9kbzqd+jyBol XxbDS1l2hzG1N2cYybEu2FA5NrhwR9MmTCDCJ/3EG9h/iiQ5qr5q2HxofrYGH3Dtfg6S52B3my 0j7KnnOSjW4d1N7utF4BPS4O5Pk3x17tRAojNOd2oXgV+1IwXtpzPTAtu8ZtgwBBTqa8fAnYC/ Bls= X-SBRS: 5.2 X-MesageID: 38187969 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38187969" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A9XQ7h+AY0yZijgfAYomS3Pwc252QKhRpUgxYBLY/kmA0f6iZQIbW4nFB9bEzUuwKd3l1GTA9F5mDodHkJVvme0FPMxsI6xQDf/si3O0YVaIwbyXPSJ0IXdfZDNBCfKuvXaHgX2naIWVpf+4Ly/gEQt91NiUEpxPR6xcGsrG0Ha3lHdcZazMWG3RELgAdtIpzyIiPOmIFqO/voR1Q87g2go5h9ejocbDYTRmwXwaSuq2mNacbie74aeDezVIJWGDivNDi0Hmz/uDwHP2+8xKSjZiQWkHwteqwUFVXEVBJdpmJ13GwoMVmUNZtcPmDGAYO+qCb30ql/TuATUdzU+acw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EbE2TLslXZAIN/rh7uQ2isg/FWiaHHj3AnL6pkxUJZ4=; b=dGj6eBPc1DytpPlaUahcwLcoCy2PkEonIkBXLL6hFkiAgfUU+QewbARcP/iM+tXjd9lSupf8EH1tguNxZxxITHMSMt5MGnYccjX9wmopNC4sNM4azyi245wJpAAKQdrR1hBudC8hSC0rLGTKdMfJOJPQEBrR6gBIwT9Af2zVobs8ISUARQV7k/IScA2HbjAcATDUPhc6pskoBI1JKI5v5PnKoStmxPRg7+LC+pUAUcE0yDtukKCIZtOwR909glNu1XJV28Rboe07viJ6Qs4RtqV0D93KNmqXFq3actu4DQV2Sbu/TUav4cAz2ec8Mxs7kmxBkJJCC8DxlOV9VDk8cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EbE2TLslXZAIN/rh7uQ2isg/FWiaHHj3AnL6pkxUJZ4=; b=k98Ag43fkiy7X4FLA3a+BkMFIP/bSxSB8TNKk+UAOm3uPGeJOBKuPgIX/bU59+mTYjtLzSQzy6yucrN3IoiVe+3AmBlL8Gg/JVlwPaTaRSmb1q5t6V5imuuj8kkpAwtWpgepXAXvATgLYyRIE1qLsrCQucCA9R108ig70yQJQ+c= Subject: Re: [PATCH for-4.15] automation/alpine: add g++ to the list of build depends To: Roger Pau Monne , CC: Doug Goldstein , Stefano Stabellini , Ian Jackson References: <20210301095806.68518-1-roger.pau@citrix.com> From: Andrew Cooper Message-ID: Date: Mon, 1 Mar 2021 17:59:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <20210301095806.68518-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LNXP265CA0003.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c8369d2b-d0f8-4537-9651-08d8dcdbc5a9 X-MS-TrafficTypeDiagnostic: BYAPR03MB3623: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XEfhG7sEpixQ0KnfKDxmip7rtYEI+hlJ8k0iEHb67T02eGJOT2TmXwrCTWNsVwbsflNYvfjwN4kC2LUMpJ27TOZ39fX13lBki5CxW8FCG03SOsytRq4YVhWpe+Oif/rjc5Nx/yyllbH9nJK6Z251bikLIemIyapB+xr+T7lGFNATlBlyprXdMOcJOLigXK8PBAw8UqgkCBicTRgRFmebiLObu3gnuorBdwcn3StUgSj+5X6MCOf4cWaA9vnE3AvjWamzBeZactmHyvTaDPD6TbUFzID5eqny4R4UWoyXE94wNmGyDbcuEF4tUMq6ZrKgHipuDWzRkZ2Bm3sQY4tdKhT7Ir9d0osFH4zoQq4Pz57de/3Tm8PNTaFxH0IFjS+izfEXz4eiA/XZEiVnsfB6/uqaZz5kjZakla37ykGfiMFBYe+3ArUy/MXdHWMhtk3hi4/Ha17RG2QW+yEkSRLxGt0EDPvzU1Rbew1SP3fsLhbj7defuxZmnyEn+JjoT957bTCehJe4bYiITE4m3XuXbMm5pKJ88Ebeoy4zW4KJXBRNogiA0xtZjKdNGbqXS+3u1PKBiRCspwHgx4oevPS06vmzMPJC8B76g6jBxXbJR4g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(54906003)(86362001)(6666004)(36756003)(478600001)(8936002)(83380400001)(16526019)(8676002)(31696002)(31686004)(2906002)(6486002)(16576012)(26005)(186003)(2616005)(53546011)(316002)(5660300002)(66946007)(66556008)(4326008)(66476007)(4744005)(956004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MlMyMUdsN3JlNDBlYUo5Z2hrelVrbWdhclVTQVUvYS9EK0YwTjlPMU9kN1BR?= =?utf-8?B?dExTc1NOYTJ5SEZyb256OEgvdjdHcy9nNzA1SFdzMGJ6aStuQ3lvSUxxaURQ?= =?utf-8?B?NWpBcGlnNzkwaG1ucGZ4NWdDMVhVU25vcjMxeE1VYXFFSGQybFFxaG9Xa0JN?= =?utf-8?B?Qm0vaEtlVUFiU1RCcWVzYVlhczlWM21VL3NXMENuMW9hTW0ySWRxSVdqd2Nw?= =?utf-8?B?Zmt2K3dlNnl5bDQwMFIxSEczemE4Q1NmTjNVVlJQaVRqT3R0VkFhVUI1cWlJ?= =?utf-8?B?TU5FdGJXbHFteS9ybFhaOEZrZUlwSjFtSWd4TG14WHFSTW9pRkV4QkdnM2ZU?= =?utf-8?B?WGlmTkc2VU9oWlZ0aVFBM0hFY09Oa1c1aE5ISWFMbzhUcEx4VzV6Y2k3Tllx?= =?utf-8?B?ZGVuZXcwOUtwUzBwdmVDTUtpenNoR1cyQk1UeStlMjFyejdXRG9hTkJSdDJW?= =?utf-8?B?SGQ0czRZMktCczlXZkhxeDNkZGs2di9hczNlTWZuSFF3SjJKOEhvWEpSSEQ2?= =?utf-8?B?dHNNVXFKZ3FXdDhsNXhhMG1STEkvMFoxSTgwdU1QZ3pwYjYxQ2lXNjEzUkp1?= =?utf-8?B?V2Z2QVg0eU9BeTdYNzNpWVFpQjU2RlV6ckJHcnJrWTNXa0Z4YW1DT1Q2OEZZ?= =?utf-8?B?NVZYdjV4UkZpeElnRWJMaG94YlJDVzN2MlgwcXpKbXVuekExWXl3cGtIRXJE?= =?utf-8?B?OXV3LytLVHlBcEtBSnZwdUFhL3FGSDhXMGphVDlSNGNEMzhNbXBlQWpyZWFR?= =?utf-8?B?UjJDU1psS2xIazgyMjhXLzVnQy9KOEcrRmYybXl6aGM4bmtGOTQ5S0k1b0FN?= =?utf-8?B?YW5OZWFtZkJCS2NhS0RxQVArZVZFdUNYL2pjMEZYT0JHUmV6aTdpbWUzWlBZ?= =?utf-8?B?TTdmRkQ2Z2tVQkwyNklOVHN1cVZOaFJKQUphY1htVGh1RlFVSDBpeUNsVVVM?= =?utf-8?B?SXVucDBid3REaFBtVEw0cWl3Yy9uS1Jmcml2Zk1UbVJnVVhtN0dKeExFRExi?= =?utf-8?B?dnRXZWQrcmFhcWJQS2tHRGUxdHgya3VxZzBldnYzQmp6ZEJMMDJqYzVUVFZB?= =?utf-8?B?VFZSU2VIbVRuMmh5dVJnOTBRSzFQWWhIcEx5aEJTcXVrZUNaTmlpSndacGJC?= =?utf-8?B?WXkrT2YzMk92UW9DSnNoNWhqaVBZRmtiVGRadU1ObUZxQlZ5a1RSVkt1YjVr?= =?utf-8?B?S0hENktDTW43d2kzQ2htMUpaUnA2MXhIbFYzRUM1cUtUSHBzZ1U3UnhZQkJz?= =?utf-8?B?dlJUL0lIQitVV2pqOEo0ck84SGRmNkJjK2l6UWI1OUZ6eHA3Q2l1RGFGNEM3?= =?utf-8?B?bUdqQ1hzWWllbUgxbmxGQ0xka213UGZxVnZtaFRDY0JrWktsalRUUkxBS3R0?= =?utf-8?B?WDQ3LzN6eU5kU3B0Y1hCc3lUV3R3SmZzWUZKdmtwc1krODA1aXdadUhmekZj?= =?utf-8?B?Uk5Ycys2L2lSNHgvL0VCOVhnUzRTRUQyNnlsTjYwNWIwSnVHbG55dVcxa2xN?= =?utf-8?B?OUl5SHpCZmJpc3FEMW1UaXdPU0JHU0RvVE9OZklVbWdrQk80MFlGMnR5Q1Rx?= =?utf-8?B?dlZKVXVyWXpXekM0SENJbjhOZXllZEJia1VKeGNXTCtpdWV0V1FMbkYyMVVF?= =?utf-8?B?MVFST1JWWXpTYUx4OCtTZXpVMGdpVXNoQzRaUGdlNUpBODFJMHE5OFV2WUhT?= =?utf-8?B?L3lGVEMyZjZOeHZKcVIvN3hlRDJ3MThCTTlxSWJ5OGtOdFdhUElkNHFxRHh2?= =?utf-8?Q?SQMOiPtEb4y1O9NOH+OA86YB/eVljMAeltVjvDB?= X-MS-Exchange-CrossTenant-Network-Message-Id: c8369d2b-d0f8-4537-9651-08d8dcdbc5a9 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 17:59:34.8887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aq1SVlu0fcYdoegvaK9PuCKCa9OYLpzadQhZQQeg/gAubjvTtvXcw5JmrVodACGBEHTEMe9lXPCGLimCzPGe/i06JWeAl69ZVhVOioZ2XVE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3623 X-OriginatorOrg: citrix.com On 01/03/2021 09:58, Roger Pau Monne wrote: > clang++ relies on the C++ headers installed by g++, or else a clang > build will hit the following error: > > :3:10: fatal error: 'cstring' file not found > #include "cstring" > ^~~~~~~~~ > 1 error generated. > make[10]: *** [Makefile:120: headers++.chk] Error 1 > > Reported-by: Stefano Stabellini > Signed-off-by: Roger Pau Monné > --- > Cc: Ian Jackson > No real risk here from a release PoV, it's just pulling a package > required for the Alpine clang build. Worse that cold happen is that > the Alpine clang build broke, but it's already broken. Shouldn't this be fixed upstream in Alpine?  Its clearly a packaging bug. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 01 18:00:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 18:00:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91914.173485 (Exim 4.92) (envelope-from ) id 1lGmqR-0005yt-7y; Mon, 01 Mar 2021 18:00:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91914.173485; Mon, 01 Mar 2021 18:00:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmqR-0005ym-4z; Mon, 01 Mar 2021 18:00:35 +0000 Received: by outflank-mailman (input) for mailman id 91914; Mon, 01 Mar 2021 18:00:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmqP-0005yf-91 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 18:00:33 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ea9c4435-d502-4f61-879b-4466df48a07e; Mon, 01 Mar 2021 18:00:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea9c4435-d502-4f61-879b-4466df48a07e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614621632; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=IsYFfZc0UJWeaW+md1gW2qg6L820YYdIBgvTPeIdKTw=; b=SZ74jQhxjY2z7f5zS6VEOm8cT3Z5A43NcwtasyRwVWtW49t1CuB4ONIE IzH3BPynHkIhRmczsfFe81IPB4mbVeF/hZskrMWsmlJ54svuC2GOOUUzX h5k7BaJA/fnzfLE7qE59TcaTsbnHL7GGzT0cYznPm7lQWJ1EtDPRBVYGo 8=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: J9oxg10ClAMHhvD9nQD78YW+e5e3SZ4p9xmQNwOl3ix0B1jxZfCdVC2GglV6JWR4FniOgjGPfJ Nq6vVtwlY0tdKW/y6FY2uq967BjQv6igkal11219cC38bXqDHId4CM8IjE5ZhYTPsnFBYET/Wh typR+LiPrBKAYFjA8MaUf915fOyhR6Himxkwey5/x8dKf2fZfWR6ZmGsYHu0BZQt6zvXmc7SZ1 4o7JlD8TfAWXixDoBn0NXbtr3/aL1xazSNS2O5ciSVuRzltFa/yy2rqUSwJg2c0fCobHTcG771 iPc= X-SBRS: 5.2 X-MesageID: 39663258 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="39663258" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RkyanwfCvnNHVLb0BFyA/zahEPqaIOs8pPtD+WfC/N6kSAfctB2CVz17L+r+9qdWBwlneNK5Ah7jinYFXwbW/Pt7fJ9HLfL0OqQuyETlYTLfWit7HOZRAmIMznS6Grt6ZO7z3ixFfbU/KTAMpOsSXxFp/mbZ5GuxKFTv++u3CZ9zxw+lILJeQW/Asei3aUtR2KD9bg1GjaZY4zX0x7Uzx4FnpVD/XIle0UpCTWbixyhRdtvkr1EJ9o4OHwtspAj2cK3DWOoqWVPjkFcFRoBP1zFdzSzUnLZIz5Kr2EFIQ9TkqCu+gDbE1HMlxk7PdjF6dB0csrC5C341UwB0FnN9RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UcG1mWCLe/SWiqsP06+QG1dmbGdRnRy4uXk+hjWYqmY=; b=LtInf6fXzmihb1zZlykvhXUCirQ/7pxoVrGn27TOWYOU9w6miqqhcDPjnAgqTXpOT3wHzLO+sbK2+swYms430dBqqwYublNib0VzFsb7X2qwsRxranThk5/iMpvFk5Si7lBkaljudWXQTCRsNvnmGao1UadChMwZzCRaQhoI3fgnRCrJkJi5ZCtBAZRH9V60H5bIzvoTuPVkBrDUKozaEzPtp4hBtdfAC4qLA+NBY4DxqdaLC8O/4nCHZOc8BNFBIo0BSKYgOG0h8/SFyUbGFEEczkGof9JGiKMpLcdQdrRe3mgnibGXnQOzwUksc9fsBvbVVUmaE9InKfXBO2sxrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UcG1mWCLe/SWiqsP06+QG1dmbGdRnRy4uXk+hjWYqmY=; b=hqxw4RWPfzRRg9E61pwvdH3XZauuztyH33gtDw7bGSV09/dhEF0RAABbbNt7kcGQ7iEy7YAi7sEsKha+iGrvk3WuC6+JDkJA5wuBWMI2KAJsv6ol/iRbyh2e3vod7DInJ1eRlyjsynxJrEx1I1FUJED4p8mECw4jj1grdzDJ/n0= Date: Mon, 1 Mar 2021 19:00:22 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , George Dunlap , Ian Jackson Subject: Re: [PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1 Message-ID: References: <1d8d5089-32a9-9c42-5949-8f9cd20f33e0@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AM5PR0601CA0059.eurprd06.prod.outlook.com (2603:10a6:206::24) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9fbb0d8f-e140-4127-2476-08d8dcdbe581 X-MS-TrafficTypeDiagnostic: DM6PR03MB5065: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NIM+0SyWDCmzLypJd9+V4X2dgO16XJr7ha79/lbO9pSjxofd26/qT3hArHVh+0KrYVaPdPQqSJKl36+RZNGTkelnLvj6D6d+bcTA+krYemwW8W6+6kDKEqkUgGWxrDj+zCCOxlmrSiFSmYvm8S3vIvg2K+7Bua0OgtC3JAAXYAfaD/1iwGOrDi891D8BelpI3tydOt6qTeUSlyr16ETuiS48FHHYRM+oqtd5IkUv7Z6oYOzBtbm1N56U2AxxujnQDKFLwUEaciofGsdv3QSoD2J2ZwxkahgFRaPDCn370HxoWOhEDbXGp1ed3667DoPHgETfRBJqBsuCh4lurFyjaPuvgIvCDFUIE/0IyVqTEMvSiS/MrLbeFrMcNPoWqFEagDK4ZngIuCAlrL4jjAxAnmpN9G5wQqTglMbAOvCI7bV1FaBDqiIidFyNLEB4965Stj6eOimZpK8PhcBMUvTuXY8KpsjLcA3ajh6S8w7Idg5Bw5KYteuMK7/eDW9b35vYEUAzj6jQCdS3AGcYMv9+iQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(39860400002)(376002)(346002)(396003)(366004)(136003)(9686003)(956004)(26005)(6666004)(66476007)(33716001)(66556008)(66946007)(478600001)(83380400001)(16526019)(8676002)(86362001)(2906002)(85182001)(6486002)(54906003)(186003)(5660300002)(8936002)(53546011)(6496006)(316002)(4326008)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WitkOG9JWHlWYW00VjZiS2huN2dSQUJQUW5hbzA5US9haWJtWUNWbEx0Zk5q?= =?utf-8?B?SjZWSmZycTZkZUFKRm1TNlNxYm9tWk5WcUxzVnVNTWtvejhudC92bk1EN28r?= =?utf-8?B?M3EzU1QxVTZQYlJpV0pVb3lXL0VxM3VKMERPZ01Dd1A5bTFuZUtrdU5HcVZI?= =?utf-8?B?aHFIa1J5VGJrVjdNcGpCT0M5QncwN250ZHF0azRSVjNaWFpmb2tBY3lIQkNE?= =?utf-8?B?N1FRVjZzL1RtUmR3YWpNUE5Rd0wxWFNuUzNRYnQ3NTZxL3BwNHptQ205eVV2?= =?utf-8?B?Zm5yamZCTk0wNEp6SE5MZ091Y0kzYkZYWWl6M1dKK0c3b2hJajdHWDJtREJU?= =?utf-8?B?ck5aa2VFTlZRb1JSWTV0c05MMzVNUjFuY0VsSlZoeFhFajNXUHY0S2gzTitt?= =?utf-8?B?cUdRNW5jVUk0UTRuSnNvaS8reGxTWE02bExLelVxUS9wSFNrRWdzQlZrUDBN?= =?utf-8?B?YXg3N05LcU9rUHRLb2g2MFc3ZVBXMitHY2V2SWZiblY2Wk5QVHRNOGxaWGFt?= =?utf-8?B?bTVsU3pxWHpuTWlEN2QxOURaenVTanBJR3B1Nk9mS0QwcDArOEJVa21vdEho?= =?utf-8?B?V0J5WUhFM3c1UlRrd2JaNy95MGZJNVdOZ1V6OXhjR2F3VVhNWjMwQ1VwVEJv?= =?utf-8?B?WXRnWmw5RnpZSFFLT2RsdFlKcmdHYW01TURoQkx6NHlMaFh6TFF2Y2VYY21q?= =?utf-8?B?TGhaWTdYM3J5ZWw4VWoxU0ZwNjdLRmhvL0VmZlcyVDBZc0s3RGFCaG9KMVhT?= =?utf-8?B?RHVZZXFzTzBwVTVtd2RUZXRJL3Z0NFJFMSs3WU1YQzFLYjBXcnVLM1F4MjNC?= =?utf-8?B?bm9SSlhCcUZxWm1QNE0xc0VHQ3NjZDBSWVh6WDRtczhmRW5qMGRMeXc3L2Yz?= =?utf-8?B?U2Q5VURtR0R3RjFlRUJYR2ZqQ0pLUFFZcXhvZG1EQ2tNODRoUDgxWHUrVERY?= =?utf-8?B?SzV0LzlxbllOeWFQM0dNdklrcXRPdTFzbEpiL0xXbDRyWnlmSnVoMXMvWTJO?= =?utf-8?B?R2U0TU0vN3BOdW1CV0d1a05xZ0VhdVBjdXUyWmlscStWU0x5T2t5YkdLNTJG?= =?utf-8?B?ZkdKQml6SHltbTFkUHBaQ2RGejBqODV1WnljaTdpR2ptSFdDUFQzY1ZUT2dj?= =?utf-8?B?dk02Y0xoQ0E3TXQ3Y2o5YW9CdFkzK3g1NVBLWjlPODRreWVRb0ZSQ2JJdXBM?= =?utf-8?B?YWhrTkVPc1NmRTFJMDYvQ3FpUUlOOFpic0pqVFE1am1qRzhGSUpTajd2N0Zs?= =?utf-8?B?YVkyVmdDc1hlaHBaZkhoNEwzdE02ZHlxUzlCSk9JQmpxMW90cCtKMzNuMXZV?= =?utf-8?B?dHI3czJ3M0lPMlQvVVVzMGF1SDFTNDZzU3JTR01DbTdHVmRpL1AxR000aWRq?= =?utf-8?B?djFuZTZQRFRZREFvby9xelgvNDRTMjhUNzFzU3FXMnZ1R0VHQitIOWJrYlda?= =?utf-8?B?MmNwdEdkdG1ZemVCZ3U4ZzRDMTgvRVVQWjc0UWNqd1MyUnpMeTdPTXBEMWFB?= =?utf-8?B?aTBnOXFPc2ZUNWkrQXF0TVRzdlM4SGhOVitKeVhCMEFZRXYwRkhHbWsxa1dv?= =?utf-8?B?SnNjc3kwOUdsRG9DYmdOeG1najVQQ0I0QnVaMmlzbXM2MThZVUJKd0lZK1RC?= =?utf-8?B?ckhGc2hWaU85SzJQL2RwdmR0cGxPVUVFdDdKanJQcWwvKzc0SkdKSW1SSnJL?= =?utf-8?B?aFFTV2pwbVVBWkJLcFo4ZGNmWU1mU3g4YlZsYTNCZDdXMkRGWUZTTE5Nc2hS?= =?utf-8?B?a1doaFY1N3BXRlRVNlJtM0ZLRVRNdWRPV2xCR3V0UTlQM1ZzNWJVcUNubVJT?= =?utf-8?B?dCtST2RXQUthV2JnSncrUT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9fbb0d8f-e140-4127-2476-08d8dcdbe581 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 18:00:28.4387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YGkbZKobj96WuXEc2pT+cGy63gCPQuqGM6YeTwo+6xYvoL9otRHlxn+BsbRN7lMD/3Uh0BTKXygLb7ZsvMuU0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5065 X-OriginatorOrg: citrix.com On Mon, Mar 01, 2021 at 04:14:26PM +0100, Jan Beulich wrote: > On 01.03.2021 15:01, Roger Pau Monné wrote: > > On Mon, Mar 01, 2021 at 09:31:07AM +0100, Jan Beulich wrote: > >> In this case the compiler is recognizing that no valid array indexes > >> remain (in x2apic_cluster()'s access to per_cpu(cpu_2_logical_apicid, > >> ...)), but oddly enough isn't really consistent about the checking it > >> does (see the code comment). > > > > I assume this is because of the underlying per_cpu access to > > __per_cpu_offset using cpu as the index, in which case wouldn't it be > > better to place the BUG_ON there? > > Not sure, to be honest. It seemed more logical to me to place it > next to where the issue is. I'm not sure whether I would prefer to place it in per_cpu directly to avoid similar issues popping up in other parts of the code in the future? Maybe that's not likely. TBH it seems kind of random to be placing this BUG_ON conditionals to make the compilers happy, but maybe there's no other option. > > Also I wonder why the accesses the same function does to the per_cpu > > area before the modified chunk using this_cpu as index don't also > > trigger such warnings. > > The compiler appears to be issuing the warning when it can prove > that no legitimate index can make it to a respective use. in this > case it means that is is > > if ( this_cpu == cpu ) > continue; > > which makes it possible for the compiler to know that what gets > past this would be an out of bounds access, since for NR_CPUS=1 > both this_cpu and cpu can only validly both be zero. (This also > plays into my choice of placement, because it is not > x2apic_cluster() on its own which has this issue.) I see, thanks for the explanation. It makes me wonder whether other random issues like this will pop up in other parts of the code. We should have a gitlab build with NR_CPUS=1 in order to assert we don't regress it. Speaking for myself I certainly won't be able to detect whether something broke this support in the future. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 01 18:01:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 18:01:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91917.173497 (Exim 4.92) (envelope-from ) id 1lGmrC-00066n-HM; Mon, 01 Mar 2021 18:01:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91917.173497; Mon, 01 Mar 2021 18:01:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmrC-00066g-EH; Mon, 01 Mar 2021 18:01:22 +0000 Received: by outflank-mailman (input) for mailman id 91917; Mon, 01 Mar 2021 18:01:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmrA-00066V-KQ for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 18:01:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmr7-0005n5-Lf; Mon, 01 Mar 2021 18:01:17 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lGmr7-0006bV-Cv; Mon, 01 Mar 2021 18:01:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=EqTkK1Obth/uelctgemBgB6AfCcwT1n6aNzuOY9QFmw=; b=5clfxH0yfmlJ1SgVlRTtvenPOp Mf1ATYtx/ewTLTAehK1LpRgYemx5eAyHgEn077/ePNIhGIYUW5tMxTkGuY1Ik+iYBlltUOXbe1bPS IerCAPTiqnSKK4Pqi9Gg2k0RR7SxC8WXvW532CDi2yAo4lceOwOa1IIuhJ3hCD3UYegI=; Subject: [for-4.15] Re: [PATCH XENSTORE v1 00/10] Code analysis fixes To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> From: Julien Grall Message-ID: <759336de-727b-db67-b082-709d5ee735f8@xen.org> Date: Mon, 1 Mar 2021 18:01:15 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226144144.9252-1-nmanthey@amazon.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi, I have tagged the e-mail with 4.15 as I think we likely want some of the patches to be in the next release. As a minimum, we get the following: - patch #7: xenstore: handle do_mkdir and do_rm failure - patch #8: xenstore: add missing NULL check - patch #10: xs: add error handling The first two add missing NULL check in runtime code in XenStored. The 3rd one adds a missing NULL check in xs_is_domain_introduced() in libxenstore (can be used at runtime by xenpaging at least). In addition to that, I would like to consider patch #3: xenstore: check formats of trace. It is allowing the compiler to check the format printf for trace(). This should be low-risk. For the rest is a mix of silencing coverity and potential errors either at init or in a standalone binaries. The init ones would be useful (patch #1, #5, #9) for Xenstored LiveUpdate as they would be potential triggered when upgrading the binary. But I am not sure whether we consider LiveUpdate supported. Any thoughts? Cheers, On 26/02/2021 14:41, Norbert Manthey wrote: > Dear all, > > we have been running some code analysis tools on the xenstore code, and triaged > the results. This series presents the robustness fixes we identified. > > Best, > Norbert > > Michael Kurth (1): > xenstore: add missing NULL check > > Norbert Manthey (9): > xenstore: add missing NULL check > xenstore: fix print format string > xenstore: check formats of trace > xenstore_client: handle memory on error > xenstore: handle daemon creation errors > xenstored: handle port reads correctly > xenstore: handle do_mkdir and do_rm failure > xs: handle daemon socket error > xs: add error handling > > tools/libs/store/xs.c | 10 +++++++++- > tools/xenstore/xenstore_client.c | 3 +++ > tools/xenstore/xenstored_core.c | 16 ++++++++++++++++ > tools/xenstore/xenstored_core.h | 2 +- > tools/xenstore/xenstored_posix.c | 6 +++++- > tools/xenstore/xs_tdb_dump.c | 6 +++--- > 6 files changed, 37 insertions(+), 6 deletions(-) > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Mar 01 18:01:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 18:01:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91920.173510 (Exim 4.92) (envelope-from ) id 1lGmre-0006CN-Qb; Mon, 01 Mar 2021 18:01:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91920.173510; Mon, 01 Mar 2021 18:01:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmre-0006CG-NI; Mon, 01 Mar 2021 18:01:50 +0000 Received: by outflank-mailman (input) for mailman id 91920; Mon, 01 Mar 2021 18:01:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGmre-0006CA-Aj for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 18:01:50 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 132ef57f-1241-4eaa-8947-1957ea5d71ac; Mon, 01 Mar 2021 18:01:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 132ef57f-1241-4eaa-8947-1957ea5d71ac DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614621709; h=subject:from:to:cc:references:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=Q8RL6R1NEP2U23lTP1xr3Ot5HUu/hkXssXVJ80doq4g=; b=asOZdJsrfDkEGVTnQqfDJvwVtS0FTEerb0rehEo86JCBWG8laVW/GwKW fBNd6XZwU3waU7YDR8RXyrpFtyEpYDpU+RTSVC2OTRM9MCPC9krWgwb8H wtwyxkV5siBBR9l5Us2XFX52w6/RBup9a/UAGiO8zqpOf6QJcc2KPrn8q k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 5kID+Bg7W6SJhrtta6/MtVYkivadpNyPChXuTN9Xq4zyKd8JIY5gQDLbyVl6MSt8xDeqc7woUU g4uxriYXHp/NhrG9i+Xt6+ahUi+2Xy21XtAUm/2+o2fhLyoc0P/kFMxpB/FKz0LNWRNnHL+Dth i4Cxsy//ROC/m+ADj9GuwEnsCpyZNOdKzVBPEP0Ab4+OlXViyONFMOVyBIO5csRCB3PFsWWkfe 537Q7vS7EUIO+N7Bt4Y5DAhslkkpQQtMBdw1ykqPfqjBvYP5zJVLhhgJ2F0Deq2yWx/NeXCZee 2Rw= X-SBRS: 5.2 X-MesageID: 38279631 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="38279631" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PwZ3taDABVuR5k4xRQKZIgxXGGJFUuA9UpshhCprbeHUxyU8/l5l6sD9TLqeCmWGfF2d362yPd5JfK/mzIuuziXUw+kMRTwWe8PQYH01Zb9Z0V+n9vBd/vXgWIoe1iv5XRll+QiaQp9AY76tkmnFhoHUWMIiTKOUXLb0UQFvP15gcaW1Mfyivl/umQfq3pR2hqdKyH1nkJ5U9zpoaVo9HFAswAWVkO/hwBuoCuC6CzV4lUtjJR5lffd/Afme0HUbRa3oiRzgwXtwBCm+ZqgORukVNa6ib5gBbx4NSVsqSDfhotTGWUTgktjExTP8X5uQ52j041F5+FchnI9YGth68A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tg09GtKNi5LILMUgCDejGPKjpl4a1uVUaqPshwqYcek=; b=OYP5BHtewHpnbLWgLCrq6iCeLOXaBYdNP2VdD2TN0NYh1J1Cc9ClCHQhSIR0Wt9ZpjhmD7NpM4fFBYpkzlRVyNLWAW+dmN8L177CiywtuVYVmwDoNndKTRgPby+AnEXWR0xN8sXgV+TeEXmu9/6LXweVu1Q2xsUn+3JaiWafi6EFQwqlrchMJSMnQftcNknDtvslXIJ5tDcMM+ognH8DeqqArAc1xz/GEwg3xFJY6OEkiXX48FEcYDGBrIXVZOMV8b4pEijLc1WHdm1vewFHbT5K6h9uMRUMUoMEqxnp3tKPiz8zYGZzFHw9J33VBGJ7d6wiOWgAmTI00OSZf5rw6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tg09GtKNi5LILMUgCDejGPKjpl4a1uVUaqPshwqYcek=; b=tjnFmQtBhir12QDvfVV7R5Q25NJWTb6daITSLpi+KLCgv0bJQB/8RS13W/KkpwaWW7emRM2s3610zGhNCgRr+Gu98rqqIuGvFHW43xTgkZok1/XqojvIMLrbsqgKiwvYDUC28kef2iWXmJfxYq4ZdhIVtQ3o+ABmNuIj6bFmSwM= Subject: Re: [PATCH for-4.15] automation/alpine: add g++ to the list of build depends From: Andrew Cooper To: Roger Pau Monne , CC: Doug Goldstein , Stefano Stabellini , Ian Jackson References: <20210301095806.68518-1-roger.pau@citrix.com> Message-ID: <27ec9db0-69bc-df9a-8511-109f57972046@citrix.com> Date: Mon, 1 Mar 2021 18:01:36 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0419.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::23) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d42b1311-8278-49b7-ff9b-08d8dcdc129d X-MS-TrafficTypeDiagnostic: BY5PR03MB5169: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FKwiXFG34OcMr6SAmoaSLuUpr+AMukMRJvCqrGmTtQACW6JVUplJYaCXwejKCZm7QffacCkP4FFPf+8agT/YlwG24PrBhK7VyG/eWNCaDieUnBc0LPXGbybowhh7g0f5ITM7s1T8Os3UPrNLJvJRCcvSomrKvUslyuYZ8LjJCOVYaMLkhhmfjyEhYkLA7b+WYrhditk4EwQghAgHCHzWTQtaZalwQvzz2HdjTNkU1mptQjSb+3vKPJxI5CJtthBT8Js9SuPQKi5IwmrTtO5Fmad4ou7YnLxPyalHsRxJPuLXejdHf7NY51mJhxkk9d7I6kcIOv9CsB/bosntH78U78bOlzdAOXq4wJsSM45EiyuNJ91YI4n29tjM/e99k4qXBS3DKlVp6VlbDYQq9k6iGu3DXsKn82BsYEGjXXJH4ZE8oTfiDKkgfn7mTkgrJ0kFW+XFYHTTDpajsFWfgkP2orjPhqn/N+0LO+MINXHhXNy7Y37FbL6OQiWNhXVSF6CT5zp0K2dUsA03wfl1sPneols4gS7FCtQg6sYkNzbVRJrWwUL65myLCr7siGZlqfkrrK/nrCDs302Dxp1qf7S0s7gMBS7DdZxsQuFosMF3zD4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(31686004)(83380400001)(4326008)(66946007)(66556008)(86362001)(31696002)(66476007)(6486002)(36756003)(5660300002)(8936002)(16526019)(2616005)(16576012)(186003)(2906002)(478600001)(53546011)(316002)(4744005)(26005)(54906003)(6666004)(956004)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?K2tCV0R0VG1pNHNqZm9POHFHQm1uaSt6Q09tc3lDTTZOcTB3aGtpaWJLWk41?= =?utf-8?B?RFRyd0dMWGxJcWJaa28rQVZSZmN3bTVLckV0SnZBZU9wWGZ5UTd6TDNhK1Vv?= =?utf-8?B?YkpHWnFrT25yc2FjdWdncjNuSVB2VXBLVktERERNcUFiZWFEYjRVRVlGUVRD?= =?utf-8?B?cHNqNW4rNjNSNjZmSk1aRGRIbENKc2RwZGZ0RkRKVCtpbjcyM1VqeXZUaVRr?= =?utf-8?B?QVgrSGIwRUt3enZjSmNUcUdUWWtjUWRhSENOcmdRTE53SVRrV2pTTHJuZ3gx?= =?utf-8?B?Ykw1bUxFQWNoL0hLbVZVNU5zMWJrOG1uTmxieGxjaFZJMzNRMVJhbEZoMUQr?= =?utf-8?B?WFZPdVhOQ3ZrdUVFSmJVMTlxQ3MwdFNscmp0eitha1dsOWxOdmprZGU5b25S?= =?utf-8?B?dlBwRTNTaU5sUXFCWlJzM1EyS2R0UUJLR3JpVHlJdzdhYU9NOWFNZjRJekwv?= =?utf-8?B?SElmejQvR1BEcVRTTHBYa1plQWR3empveGxGcW1qUTNIcmZZclE2bHhnRi9m?= =?utf-8?B?WkZ4V2I0VjJqWkw1QmZNZmp1S3lCQzJhSG9xdnNlVkN1bDR5RitoaDlReFFp?= =?utf-8?B?Vk04aE50d0d5dnZCWFZWbWNEamYyUEdHbUJwbnRkWWZTRXF2NStwTjlBd0lK?= =?utf-8?B?Z3J6cXFUWTE3UUhDWTdxeWVUYVhJbytTMnpzWmFxclpKajhwd1RuL3ZrQ2xu?= =?utf-8?B?Yk9icXY5Q0xQQTZqWjdPRklRTGJPMjJZTkpQWXRKV3Rkd0hYQjdxOVQ4MXlF?= =?utf-8?B?SnAyOWRwcTVHMklhRUg3UHp3cllpVzZCR2ZaTmNFQld6YTRQT3E5NkxFbVNz?= =?utf-8?B?bEJLTm5wQ2xkYm5WVGZ2Qjd4d2c5YnNCQ0NCc1JjbVBaKzBMakVVL0xubVJE?= =?utf-8?B?Si9GZ21LSFdhMmt1YnBQVjJ2MkFPZldMRkVzVXVCc3JOTWhWMkhJQk5TNndU?= =?utf-8?B?OTFvMnUyeSswSlM3cnNOSldiOG1hSDNIOExRTHVkVTVObHlYeUx4Y2tCRDlt?= =?utf-8?B?SUt2OTB1TFJURVdiRzhEanZ6NXZGbURhaDRjNE5qNnhQRkRuSnlyaVZOTkd2?= =?utf-8?B?amp1WHhvRTRoYmt1M3JmclFLOEUxS1k5MVQzdms3QWtyWWpBcEpYUXhGdk5h?= =?utf-8?B?MklHNlRnOW41Ny9id3JLUUlyVmROdnlMQ2hoRWJTcTlGSkFkVXFPYUtBaG9j?= =?utf-8?B?S2JaVmNTNWVraU56biswaFBUUEI5RXRwV3BHTFRYa09ucXRhR1Z6eGttcTJx?= =?utf-8?B?TG1hNjB0b0ZpYXdCbTZFTnErYkJjblgvS3B3YXEvdWoxbUwySEwwZm0rZVdY?= =?utf-8?B?d3ZKdlI1akxWRXZndGNBUCtmdENzRkN4SzZ1YWdVSmROa3VNc1hTUGRTQ3NE?= =?utf-8?B?V3JvRitKOFN4MEM1eFV5RnlTT3liZzg1ZlE5T20rQm41M3drUzBJbllOd3ls?= =?utf-8?B?QTBIZTVhR0ZwMmRYdENPYXFSMjFkR09aQTZ4NFRidnVsYnNIcTdKdnpQTDdN?= =?utf-8?B?OTNMT1I3dnQyRFNPOGl5YklNMXlzVWprS3NRRXl0ckQ2Rk9jT282SndUYVNP?= =?utf-8?B?ZU1aeWcrVUhudUh2K0VXbFVwYkhRM0Q5T1ArQjg4SUVobm1iV01IaUpvc2Zx?= =?utf-8?B?OU5YSG1SYXhzV1RMYmJqd3NuZDdHNjBGb2g4YkEwSTloQXV3QkpEMWZ1MzIz?= =?utf-8?B?WXN0aTN3VDNySjNsVUZMb0IzZEttWlkzYjhldFRWTjVrblZPdk5hQ2wwSnkz?= =?utf-8?Q?12r7WAT9gFnxPuyjYadIl/3QsWcHdHdHUn2b3U6?= X-MS-Exchange-CrossTenant-Network-Message-Id: d42b1311-8278-49b7-ff9b-08d8dcdc129d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 18:01:43.9243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wIUAfFUGAWHmUhuO7hUHXaZ98yBDvQDSMVIpqmjwiDlMPYA6q21b66AS1vDtqUdHxpR/K259j0Rq/hfFTT6tYTw2gdT4M4ADZHdUi2/oF+s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5169 X-OriginatorOrg: citrix.com On 01/03/2021 17:59, Andrew Cooper wrote: > On 01/03/2021 09:58, Roger Pau Monne wrote: >> clang++ relies on the C++ headers installed by g++, or else a clang >> build will hit the following error: >> >> :3:10: fatal error: 'cstring' file not found >> #include "cstring" >> ^~~~~~~~~ >> 1 error generated. >> make[10]: *** [Makefile:120: headers++.chk] Error 1 >> >> Reported-by: Stefano Stabellini >> Signed-off-by: Roger Pau Monné >> --- >> Cc: Ian Jackson >> No real risk here from a release PoV, it's just pulling a package >> required for the Alpine clang build. Worse that cold happen is that >> the Alpine clang build broke, but it's already broken. > Shouldn't this be fixed upstream in Alpine?  Its clearly a packaging bug. Or (thinking about it), we've got a build system bug using g++ when it should be using clang++. How does this check work (without g++) on a non-clang build? ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 01 18:26:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 18:26:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91926.173522 (Exim 4.92) (envelope-from ) id 1lGnFO-0008K2-QQ; Mon, 01 Mar 2021 18:26:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91926.173522; Mon, 01 Mar 2021 18:26:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGnFO-0008Jv-N8; Mon, 01 Mar 2021 18:26:22 +0000 Received: by outflank-mailman (input) for mailman id 91926; Mon, 01 Mar 2021 18:26:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGnFN-0008Jn-VU; Mon, 01 Mar 2021 18:26:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGnFN-0006BO-M6; Mon, 01 Mar 2021 18:26:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGnFN-0000aU-CU; Mon, 01 Mar 2021 18:26:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lGnFN-0007SO-By; Mon, 01 Mar 2021 18:26:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UPtwYgp48uIJNH+75r29YVuBoSI/sfDnSaiP04OG1AI=; b=6lSRrI5uBr0YLYXfyyppp8VgQ6 YJL7W2XuFRwW9PgFq0fomu0pVjbyxu7U9jXJwXscBLvr9FGtR0SMDnHtG7v7pAiodJAwSJEgENf6i 8uE8J3nB74ATHJl2h44iV3gKuTR1xgEFH9woN4DJ+AJrJEVC29NNMPL+bZK3AHSsveVw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159793: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=77d7b3540c12b9bebba67dca8eb2d939d9e8b5df X-Osstest-Versions-That: xen=c4441ab1f1d506a942002ccc55fdde2fe30ef626 From: osstest service owner Date: Mon, 01 Mar 2021 18:26:21 +0000 flight 159793 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159793/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 77d7b3540c12b9bebba67dca8eb2d939d9e8b5df baseline version: xen c4441ab1f1d506a942002ccc55fdde2fe30ef626 Last test of basis 159716 2021-02-26 17:00:25 Z 3 days Testing same since 159793 2021-03-01 15:02:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ian Jackson jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c4441ab1f1..77d7b3540c 77d7b3540c12b9bebba67dca8eb2d939d9e8b5df -> smoke From xen-devel-bounces@lists.xenproject.org Mon Mar 01 18:38:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 18:38:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91932.173537 (Exim 4.92) (envelope-from ) id 1lGnRL-0000ya-Vl; Mon, 01 Mar 2021 18:38:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91932.173537; Mon, 01 Mar 2021 18:38:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGnRL-0000yT-SM; Mon, 01 Mar 2021 18:38:43 +0000 Received: by outflank-mailman (input) for mailman id 91932; Mon, 01 Mar 2021 18:38:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGnRK-0000yL-EX; Mon, 01 Mar 2021 18:38:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGnRK-0006Og-8L; Mon, 01 Mar 2021 18:38:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGnRJ-00019e-TQ; Mon, 01 Mar 2021 18:38:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lGnRJ-0002H3-Ss; Mon, 01 Mar 2021 18:38:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HG08BJ+xfeulYl+PULEa1W8ZXINwCOB9REeJ6E+hceM=; b=FOfMYnBXGTyizunCtaoJLFXkAf uVVz76sXNZWYwWlx4GIY2sNpYbeSrrgyVztv3TcJOWv0nX3xOyiCfC/ArzbHafAiHMD9CphiNR/5Z kVQZGGGimzP09QGnkCYLQ8fOzox3VfbVMoaxLIHvADycbkmXW81HWKOEltQvIFL5Hfvc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 159792: all pass - PUSHED X-Osstest-Versions-This: ovmf=0996a7883c6dd939d6e769b1ce1fd2b2e250bcfb X-Osstest-Versions-That: ovmf=31eaefd4df78d58ad4087a13f6fc7607b266d04e From: osstest service owner Date: Mon, 01 Mar 2021 18:38:41 +0000 flight 159792 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/159792/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0996a7883c6dd939d6e769b1ce1fd2b2e250bcfb baseline version: ovmf 31eaefd4df78d58ad4087a13f6fc7607b266d04e Last test of basis 159741 2021-02-27 11:09:44 Z 2 days Testing same since 159792 2021-03-01 13:39:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel # QEMU/kvm guest on ThunderX2 Ming Huang Quan Nguyen jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 31eaefd4df..0996a7883c 0996a7883c6dd939d6e769b1ce1fd2b2e250bcfb -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Mar 01 19:18:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 19:18:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91943.173551 (Exim 4.92) (envelope-from ) id 1lGo3W-0004v5-W4; Mon, 01 Mar 2021 19:18:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91943.173551; Mon, 01 Mar 2021 19:18:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGo3W-0004uy-T4; Mon, 01 Mar 2021 19:18:10 +0000 Received: by outflank-mailman (input) for mailman id 91943; Mon, 01 Mar 2021 19:18:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGo3V-0004ut-3m for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 19:18:09 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1aee2df5-866b-453e-832d-85c644e3f135; Mon, 01 Mar 2021 19:18:07 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 010B4AF35; Mon, 1 Mar 2021 19:18:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1aee2df5-866b-453e-832d-85c644e3f135 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614626287; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3j/0D9ZA7ezAtEP4Nk3+f0xENC++ECPVLz2dgRTsCxI=; b=r1srcnqfeZUiQ0xnlWVjFCTUVG4ZpnVmnB2gjAkhAjdEf+FPeRl4xZQT9zSl80nS50IY95 liuwzkMBhoLK+WLikoku4/ZC03NEOaYPwZNXl5lEwsH0pwlAkM7n1NPNJGpOvDKMBGpFKP e8FDvOHsUgwj7WG4qSh5WrEHX0yApmM= Subject: Re: [PATCH v1] xen: ACPI: Get rid of ACPICA message printing To: Boris Ostrovsky , "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Linux ACPI , LKML , Stefano Stabellini , xen-devel@lists.xenproject.org, Konrad Wilk References: <1709720.Zl72FGBfpD@kreacher> <7c313ae8-6f3a-1281-a88a-1393e54f26a1@oracle.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Mon, 1 Mar 2021 20:18:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <7c313ae8-6f3a-1281-a88a-1393e54f26a1@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Y6WqBR9s8HPASVufSY807FC9ROBrepWk0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Y6WqBR9s8HPASVufSY807FC9ROBrepWk0 Content-Type: multipart/mixed; boundary="IMu2UHGcUE6GoRXxvT3hkijSEV94m109Z"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Boris Ostrovsky , "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Linux ACPI , LKML , Stefano Stabellini , xen-devel@lists.xenproject.org, Konrad Wilk Message-ID: Subject: Re: [PATCH v1] xen: ACPI: Get rid of ACPICA message printing References: <1709720.Zl72FGBfpD@kreacher> <7c313ae8-6f3a-1281-a88a-1393e54f26a1@oracle.com> In-Reply-To: <7c313ae8-6f3a-1281-a88a-1393e54f26a1@oracle.com> --IMu2UHGcUE6GoRXxvT3hkijSEV94m109Z Content-Type: multipart/mixed; boundary="------------2E3C1A1D1E83919451AF1165" Content-Language: en-US This is a multi-part message in MIME format. --------------2E3C1A1D1E83919451AF1165 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 01.03.21 17:16, Boris Ostrovsky wrote: >=20 > On 3/1/21 9:11 AM, Rafael J. Wysocki wrote: >> On Sun, Feb 28, 2021 at 2:49 AM Boris Ostrovsky >> wrote: >>> >>> On 2/24/21 1:47 PM, Rafael J. Wysocki wrote: >>>> From: Rafael J. Wysocki >>>> >>>> The ACPI_DEBUG_PRINT() macro is used in a few places in >>>> xen-acpi-cpuhotplug.c and xen-acpi-memhotplug.c for printing debug >>>> messages, but that is questionable, because that macro belongs to >>>> ACPICA and it should not be used elsewhere. In addition, >>>> ACPI_DEBUG_PRINT() requires special enabling to allow it to actually= >>>> print the message and the _COMPONENT symbol generally needed for >>>> that is not defined in any of the files in question. >>>> >>>> For this reason, replace all of the ACPI_DEBUG_PRINT() instances in >>>> the Xen code with acpi_handle_debug() (with the additional benefit >>>> that the source object can be identified more easily after this >>>> change) and drop the ACPI_MODULE_NAME() definitions that are only >>>> used by the ACPICA message printing macros from that code. >>>> >>>> Signed-off-by: Rafael J. Wysocki >>>> --- >>>> drivers/xen/xen-acpi-cpuhotplug.c | 12 +++++------- >>>> drivers/xen/xen-acpi-memhotplug.c | 16 +++++++--------- >>> >>> As I was building with this patch I (re-)discovered that since 2013 i= t depends on BROKEN (commit 76fc253723add). Despite commit message there = saying that it's a temporary patch it seems to me by now that it's more t= han that. >>> >>> >>> And clearly noone tried to build these files since at least 2015 beca= use memhotplug file doesn't compile due to commit cfafae940381207. >>> >>> >>> While this is easily fixable the question is whether we want to keep = these files. Obviously noone cares about this functionality. >> Well, I would be for dropping them. >> >> Do you want me to send a patch to do that? >=20 >=20 > Yes, if you don't mind (but let's give this a few days for people to ha= ve a chance to comment). I'm fine with removing those files. Juergen --------------2E3C1A1D1E83919451AF1165 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------2E3C1A1D1E83919451AF1165-- --IMu2UHGcUE6GoRXxvT3hkijSEV94m109Z-- --Y6WqBR9s8HPASVufSY807FC9ROBrepWk0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA9Pe4FAwAAAAAACgkQsN6d1ii/Ey/X Xwf/T5pILtrP2Vss5K6gmbbQFUxpMalP1uWUEX87zmFAKMOaiivPnoqmUw6FAyS88slClsPNlwOf kXPGM2fx4EbVWbinGHHm8LZlWQZLKVeJSGbieq+mKSnbnq5XIkksC1VHjfD8D3/tEmSSvSVfuYuo PYja1K2LFCdQtAtzi0VXqqUTttDNLiJT6oTtsiJHvAoE1CXTdBiVZju0UrTLKIVbJpxccooRgVCR /XT3SBsWrnb15J1JyApNIMtJ/P36In17JunTv8U7UcOjC1liH94XvXOQsrO+XzxJNFSW1Dz2Q3Mm zSXwdlv1I9IYl414ZVdzJ2U+UAxW1zv/TmEusYJtbQ== =baql -----END PGP SIGNATURE----- --Y6WqBR9s8HPASVufSY807FC9ROBrepWk0-- From xen-devel-bounces@lists.xenproject.org Mon Mar 01 19:19:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 19:19:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91946.173564 (Exim 4.92) (envelope-from ) id 1lGo4S-00058r-BP; Mon, 01 Mar 2021 19:19:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91946.173564; Mon, 01 Mar 2021 19:19:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGo4S-00058k-7l; Mon, 01 Mar 2021 19:19:08 +0000 Received: by outflank-mailman (input) for mailman id 91946; Mon, 01 Mar 2021 19:19:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGo4R-00058f-84 for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 19:19:07 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2246f6a6-1d96-49e1-bb04-c00f0700121b; Mon, 01 Mar 2021 19:19:05 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E4425ADCD; Mon, 1 Mar 2021 19:19:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2246f6a6-1d96-49e1-bb04-c00f0700121b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614626345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rY5C7IvYwu59F1WelQcHMBQMJDl5Ojn/Usn1v7uuQ5A=; b=AomzcFELmWZY+5UY38dBmIVHXeX3GHw25NXiSN9FDvT0hWP1x/22IxhZupiImjwhtK0qYN mKN7QqQlCIiq+Y2LXl0ZPQDc5X/BHBHqU9RvNRzbpMBIPKfxjtrVpkkRoFsVgXdbMEaRq2 Xt9JadVE+hMt5J23QjAG7r5AJl4Pe9g= Subject: Re: [PATCH for-4.15] tools/xenstored: Avoid dereferencing a NULL pointer if LiveUpdate is failing To: Julien Grall , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu References: <20210226182655.2499-1-julien@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <842a4189-c7a9-e3c1-6e21-740eb352aadf@suse.com> Date: Mon, 1 Mar 2021 20:19:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226182655.2499-1-julien@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4bqH9syYQgV1ZtCDKD2Ycvw54aeWoLp3B" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4bqH9syYQgV1ZtCDKD2Ycvw54aeWoLp3B Content-Type: multipart/mixed; boundary="X9bU5BXn78AV5se16MHxSKnFbAXqKx3HN"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu Message-ID: <842a4189-c7a9-e3c1-6e21-740eb352aadf@suse.com> Subject: Re: [PATCH for-4.15] tools/xenstored: Avoid dereferencing a NULL pointer if LiveUpdate is failing References: <20210226182655.2499-1-julien@xen.org> In-Reply-To: <20210226182655.2499-1-julien@xen.org> --X9bU5BXn78AV5se16MHxSKnFbAXqKx3HN Content-Type: multipart/mixed; boundary="------------F49DFD30BD801625132A3719" Content-Language: en-US This is a multi-part message in MIME format. --------------F49DFD30BD801625132A3719 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 26.02.21 19:26, Julien Grall wrote: > From: Julien Grall >=20 > In case of failure in do_lu_start(), XenStored will first free lu_start= > and then try to dereference it. >=20 > This will result to a NULL dereference as the destruction callback will= > set lu_start to NULL. >=20 > The crash can be avoided by freeing lu_start *after* the reply has been= > set. >=20 > Fixes: af216a99fb4a ("tools/xenstore: add the basic framework for doing= the live update") > Signed-off-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------F49DFD30BD801625132A3719 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------F49DFD30BD801625132A3719-- --X9bU5BXn78AV5se16MHxSKnFbAXqKx3HN-- --4bqH9syYQgV1ZtCDKD2Ycvw54aeWoLp3B Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA9PigFAwAAAAAACgkQsN6d1ii/Ey/v kQf+JdHV/lFtCQ8XasEuuNpNdPMqRzwR2oD483KWwgLqNFTzDY61DFFfWOPmujKrjdNctans2Mzb lvp7sZlaim8vL5mvFmP5ZdL3lTe5EP7tn2pq9aDAHS2cVFJX0E70CzluBJgNy95ekX+otl5xpXJB 4n3cGELKYr8JktS5DYdG6ovDPrRASFOt/tE5cE4phsr2ev4wEiyO1+QxTYRuPOtXbSuPCFQ1NX/K HTnR3/U6fw+FFocn+ka9bxmhj3pRt+8Ip1zELRbRZD0L7E510Qc/IE507Qy0YnB/9EfKkxzZF+sx LrIhid8WAGr3HRQ88tSUyByyzG5RIGft3PaAv5UxHA== =hgQL -----END PGP SIGNATURE----- --4bqH9syYQgV1ZtCDKD2Ycvw54aeWoLp3B-- From xen-devel-bounces@lists.xenproject.org Mon Mar 01 19:33:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 19:33:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91949.173577 (Exim 4.92) (envelope-from ) id 1lGoIV-0006zY-OR; Mon, 01 Mar 2021 19:33:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91949.173577; Mon, 01 Mar 2021 19:33:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGoIV-0006zR-IK; Mon, 01 Mar 2021 19:33:39 +0000 Received: by outflank-mailman (input) for mailman id 91949; Mon, 01 Mar 2021 19:33:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGoIU-0006z5-0R for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 19:33:38 +0000 Received: from userp2120.oracle.com (unknown [156.151.31.85]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9fd20482-7dd0-4ec6-9cb0-f0b072e2918e; Mon, 01 Mar 2021 19:33:36 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 121JTY7f007103; Mon, 1 Mar 2021 19:33:32 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 36yeqmw2r3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 01 Mar 2021 19:33:32 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 121JV6l2176356; Mon, 1 Mar 2021 19:33:31 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by userp3030.oracle.com with ESMTP id 37000w0359-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 01 Mar 2021 19:33:31 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by SJ0PR10MB4672.namprd10.prod.outlook.com (2603:10b6:a03:2af::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.20; Mon, 1 Mar 2021 19:33:29 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3890.028; Mon, 1 Mar 2021 19:33:29 +0000 Received: from [192.168.1.104] (73.249.50.119) by SJ0PR03CA0298.namprd03.prod.outlook.com (2603:10b6:a03:39e::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19 via Frontend Transport; Mon, 1 Mar 2021 19:33:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fd20482-7dd0-4ec6-9cb0-f0b072e2918e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=lym6hu6XGzAXanq41vcm2QQ2W5A+OouXzdcmIBXCN6A=; b=ZdpvdFlkJ4llXwvXB73H1hrJw5ulDfgeEzbRTbPXfTttx8XpOG5YgS4Br0HuHHDC/SBe DFzawc/egQOmKLivSD5xpgSJevwJ52ze1OWMH+7o+ErzIkEBpBuTKkAfRhI0THLV+iKb uu4hlZqqY7BafJ1oKb/FCyUe/38XSpc6JL6DjAYKc9wqEw1nm+SgtxG7rjuOD3KDJiYK 55fuoJNRK1mEKZj97cO+lrViORhHiwuPODvBUpknr7XQnWOESuEPE0ZAcGSoMEkSUGbp 4mXMjnLw+UAmIih0Dzp4drdjGvv4uehGV9bt316SgNATqpX80DsnWnfvWuoQzSu3+e/y aA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eLYos+IB58vDZ5z/sU9H8bcmgQdIyLFMB8w/pvdkJBfsiz/94pGPrhH41z4CCL2Vj65TbOpfMZtlrQGimzLqGaSOJVY5fsrfTqC0Ln9YnePrhVNnCrRqSc3COhlhbipk7VzmlT6IWkZekdmd/ZOuzwaAquAYKGD/CJGgo7xjc/2uL1Xa0D9SxeyupKW+lCwKB9XqHt1u+sq8yrF0AbM+JnoHfZBk3qiDxY5k6D8abdQiMLm+ud+En/wsJGB+IRJz17gB4SouE0KtDjH3I5vSm/6HSCZW8sFO3D+IXaSIiA/NA4q9aQvEkNHBUFiaPre+w8nTX2e/k0GPaFsfEF1rww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lym6hu6XGzAXanq41vcm2QQ2W5A+OouXzdcmIBXCN6A=; b=doXHNNd5rtAAjGEMl1Ul9T96edfd7vn+imFvki/JwqyBAThvxV0hpk1RkOfSNgZ4tvNXUjHqc7/UIzwe9m2RKgC7pqrhzBVXD79Uxo9yvqu80q5/zTDtoLd8iIEkYAuNVfqZt7GWCZ9RyOCZYDmwGy1bCR5tS+xcE+Lj7FYfHX3dZ5s7RtGU+NLsAzeo+f/F4q05nlWOR+WKFRggu7gTMRNm7axYkIdYWVuCQ9BfpPD+0jJs6Jy1jJKKcBWHkiwatI65EbXQ8PX8zOa6NnLXsjGsLQGt0flFbxtzVlCS4+gFuEdD0kzW9kB4ca19EpdmxeVHollxeXDTlyDTiVv55Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lym6hu6XGzAXanq41vcm2QQ2W5A+OouXzdcmIBXCN6A=; b=CbS675pHYkZRnGVvC2n946MY/Wu1yqYSCENegYKm9MeZhEjxkcqLMN7r9NR+SoAPsfCNGu0xmgK9zY/EeGKBSluByULDh9n+lJM476ySUjUD39PKkUX3xvf18Z8+zEHNkkYaEpxpSeb8XMEmwPSctLF06ZV7uoqJiyjzyi5E+Yw= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian References: <20210301162357.76527-1-roger.pau@citrix.com> From: Boris Ostrovsky Message-ID: Date: Mon, 1 Mar 2021 14:33:25 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <20210301162357.76527-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [73.249.50.119] X-ClientProxiedBy: SJ0PR03CA0298.namprd03.prod.outlook.com (2603:10b6:a03:39e::33) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b739f04f-1d14-4638-9dc2-08d8dce8e433 X-MS-TrafficTypeDiagnostic: SJ0PR10MB4672: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8hSSpr3Rl9lhN2+6O9vBdgj27Hc2BCjGN4YX5nVMJUrrnOt2JmeQ9F3f3fmP95VM9s/evc4xaovoVYGkUWkw9GKu7TCGRxovUxqynHU1uQZSDZ/sfndGIfwwgA6tBnl9ezG4wX58Yunl7j3yfkgx4km2wEsTbyf17MsDhwS7h2UzdNUJsdoojE55eCR3q1wL51vhdnxFZstnq8wN2BdS9NpBRucOZc7lzIZD9mnOyALiDSy0yHsqh4i1wAJ4oEACXEJqNBTY9pPNz7mFBqKIDrBgdQ+CjLIeDWWLPBRHHjqVr0mympgwZeAPkHCoXpb5pO4yTO73cCzYjta68Dm76J5/ayYxoRNB46TQIYfxPUUKp2SSYgSkpq3uE5D2WnWCrm1H1etZXnw8o9jnD6pZqg+2lnT7kX2PSQ7HDnhPlIkCu/LUJFOS8yM3w+AzIDWtPXCUIcVNwB1+fwc/BRGpghojIPKgHcBFR2weYpiBVYVfwGjGiwuDFkBC0ysgA9mXAliWag/WDnpxK/yfoTkIMnN+LKrNKbbLF7ipuiIks5VIdUz2cBBIzuFQL202yO39RCuCTImpnaGZ/KqG1srxwRdUrNGJ3cz3UAb6b8q1e7g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(366004)(39860400002)(136003)(396003)(376002)(5660300002)(83380400001)(8676002)(2616005)(8936002)(53546011)(54906003)(26005)(956004)(316002)(186003)(16526019)(6486002)(16576012)(2906002)(44832011)(478600001)(31686004)(6666004)(66946007)(66556008)(66476007)(86362001)(31696002)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?V3BEdDdGTXJ5QWxnUmFmbGRRVnh3ZFBYcm9IS0hQaURjVXdzU05MWjdIcVBT?= =?utf-8?B?anBra2pIc2F1cVVRRlZ0eFJxQ2QyQVk1am4vSHcrWjRVVmJUdkU4QVVUN3Ra?= =?utf-8?B?MXN4VEdEUWd4RFkvUjczOFV3Tjc2UXY5T1E2UCtUMlNSQ3piS3J4Qkx0eHRL?= =?utf-8?B?WnlOTzc5anpDOUxYM2N2SXJHVnBUVDJjVDJvdnVyMXU5MTF5dUF6R1BTUDhH?= =?utf-8?B?RTJVUGhQZ2hOME80SkFWeS9IWllVVGNaVzJGbEQ1MmRhREVsb2VsNEtTbzJz?= =?utf-8?B?NGJJcUlqQld3ZXNJbVZramNQVFNDQVRBTXVVMkhLVC8ycHU3SGw5VUhXQ3l4?= =?utf-8?B?cGQ2YXdyOHUxVys5MXcwNTZIWGE0MlBvTWtQQmRWU21PeTI0SFpncGNBdnZo?= =?utf-8?B?NXh6RlZwWTdNd1RRSDgzSWJsODZTZTJpWCtTbEhaYjliL1ZBcUxNbk5DbUk4?= =?utf-8?B?bElZL0xFd3dyS2ZqMDlyZS80bW02c0FiSEYyUXpVMDFXb3poQ2QrUGdFZWxq?= =?utf-8?B?UUVjSnlMWHg5MTlYVlNwRW9tUzB3Zk1iWDB3SzY2MVVOdE1YVVZaTjcxQTV1?= =?utf-8?B?bW00SFJIZUpxNEpPaHl0bGlDWG81Yi9CZVAvYm5aRkkrTm5xUTVZNU5uUm1O?= =?utf-8?B?dkxRT250ZSt1L3dFekFqUEFnK1JtRzZvRXYyMDQvYWl0RGJuUFBObjlDM0lZ?= =?utf-8?B?ZXk0N0FmYmtlcmdkZUNzUzhSV3h3UTBsMTJIblBaQWpsY09hUllBRWVXanhL?= =?utf-8?B?cUdjRVRzM0ZHaFVzVmR3dEV6RXpqSTYxbDVUaGdwOG5UekxIUnU4ZzJ0NE5I?= =?utf-8?B?QVpQbU9PUzIzSG1RZWhROXE0V2pSMFVuc2poK0lKdkRWQTVrc1Z0SlIzbnV5?= =?utf-8?B?ZTQ1aXg2dXhSb2pxOTJMWU5jejBZMTBVQTlHeHI5TmlmYXRJb2IxTUpoMzBy?= =?utf-8?B?eC96bGx0YkxsMzlCWmM1RjdwVFJLeFVFNHVOU0h0VVByZi95OXZZL0pYOG5T?= =?utf-8?B?V2swYUc0SlZvSjI1WlRJVTlRT0NlYjlaQzNPVHR1bndyZ21xWkZaZDF5Nk9H?= =?utf-8?B?NVpkRnJtQVlvZnFzTzhsdnpxeUNjclRMM0dXYmFoeGd3VVlCYkdQK3hFTWhl?= =?utf-8?B?RXpyMDZ2TloxQVVHY0FQKy9HaE9vcHpobzhaUHpWUlRlWXpOZVBjcGFwVjJ6?= =?utf-8?B?S28wZC8rRkd5SzVlbGRZTkZBeGxsbTNQNzYwWjJkS0trMUF6UUYrcEdLMks0?= =?utf-8?B?Y1h0U0FkNC80bGxPclFoRndtUndKeVVicmNpbFlvcWdSY2pwM1ZQRm13UDdK?= =?utf-8?B?MXJvMjJtVHhROWEvaVB6SnBwd29WNGhDTXEvdDBzV2VXUnhOaVJMeDlKOEtw?= =?utf-8?B?dlYzYW1oZ1A5Wkh3RHlaelJ0Q1hkUko1L091bWZ2a2ErQVp2YmNVcmIzWm9a?= =?utf-8?B?cUdWc2hBRlNsVjBVemdEMUFOc2lzL1VmQ2pxcTVlRy9aOVRCb1pUem8xb3BH?= =?utf-8?B?dzVQM3NkSkRJU2NrUlpHSVg3MzhUeDd3em5UWkY5K1BWQWF3bGVvaS9rZGhh?= =?utf-8?B?VEJWOEdZamN3TFVlNzNVSEdDUG03RzdhbXd1R1pGK3lESk5zL3oxUGs0d2dF?= =?utf-8?B?VXU3Vm1GYzNlTTBxeTNHd3VBd0NSYlF0bEJReCswUUFFU3pzQ1AyNXVHM1BZ?= =?utf-8?B?bEFiVlZWUVJlOFBzWlVmcTlzeERrZHFGKzROQnhwS0RncHc4d2RUbmdDUU16?= =?utf-8?Q?5yvLuzV1kyCP4+xnMVy0AG2M8sNAP6E05RbfKP2?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b739f04f-1d14-4638-9dc2-08d8dce8e433 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 19:33:29.5134 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mXVyO3ygmYAN5c/PN0SVEgVKQ2UgENTQjs+RIuiJ19M7SPw2GhGExt40WESJ9ur/+AMApEFk2Dd5ZkcW8fbXj+5/8bbs195+rf83JELv/uk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4672 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9910 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103010155 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9910 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 mlxlogscore=999 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0 adultscore=0 mlxscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103010155 On 3/1/21 11:23 AM, Roger Pau Monne wrote: > Introduce an option to allow selecting the legacy behavior for > accesses to MSRs not explicitly handled. Since commit > 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly > handled by Xen result in the injection of a #GP to the guest. This is > a behavior change since previously a #GP was only injected if > accessing the MSR on the real hardware will also trigger a #GP. > > This seems to be problematic for some guests, so introduce an option > to fallback to this legacy behavior. The main difference between what > was previously done is that the hardware MSR value is not leaked to > the guests on reads. > > Signed-off-by: Roger Pau Monné > --- > Cc: Boris Ostrovsky > --- > Note that this option is not made available to dom0. I'm not sure > whether it makes sense to do so, since anyone updating Xen to such > newer version will also likely pair it with a newish kernel that > doesn't require such workarounds. > > RFC because there's still some debate as to how we should solve the > MSR issue, this is one possible way, but IMO we need to make a > decision soon-ish because of the release timeline. > > Boris, could you please test with Solaris to see if this fixes the > issue? Yes, it does. Thanks. -boris From xen-devel-bounces@lists.xenproject.org Mon Mar 01 19:40:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 19:40:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91953.173588 (Exim 4.92) (envelope-from ) id 1lGoOn-00080b-Gv; Mon, 01 Mar 2021 19:40:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91953.173588; Mon, 01 Mar 2021 19:40:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGoOn-00080U-Dw; Mon, 01 Mar 2021 19:40:09 +0000 Received: by outflank-mailman (input) for mailman id 91953; Mon, 01 Mar 2021 19:40:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGoOl-0007wR-Jr for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 19:40:07 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ffb6400e-c950-429a-bcc3-27c6ea3368a6; Mon, 01 Mar 2021 19:40:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ffb6400e-c950-429a-bcc3-27c6ea3368a6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614627605; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=K57017YMNXRpO3MY3QcSzcXK9lKnE84DB0+wh2OlDw0=; b=L5qrat81VTWyGnhxfQ4jnM+X0cELecuksq4of1+LIum7l7FhA7s71no6 vIPEn28UMipu987x9GrZ+jqiLY7nAdqHmU9TYw3KcMB92mQtgiYonORQB aFj+rwgBs5VClIpt2fHo2BfmVIp9QtskH7qwVCj/bWx5+VlAI5080SIip 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: y5ld+cTLDv8A7u1j6WCrYBQrAknbR4MrSxkz4noFOBdjeqao9TjJSeoZ98xqyS5NRRD/9O0SjN ztF1IC5tjvXTMo/hGrqWrO9qXffPDfAXPqXGM66jI55w9va00A/Ju5ZJkvmhW3/Ti8Nac6c3Co t1S0Ghr7SfKYxzsqXFZBy47LXVhJxOSKXyIqD3lF9hmkeQNGjaLkxZNdg/12fwIVqO/kj7KTR4 2W1zK1Su3OejiPOroj1gUREGAKkOMtyYrSDCd4j6JJMc2X9x85F/IdcPtOuopUIcOb/tNEBsQo aJA= X-SBRS: 5.2 X-MesageID: 39672513 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,215,1610427600"; d="scan'208";a="39672513" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eDSQUeUvRZcKDJZPHLTMt+QPCNEiXuiZ7RFK6MnC7faI7Rg4BlYYeQSl/4Twtp/5FlRUxf4XLmUzImxQFHZtEqxc8f7ogJI5l0pGkQd/1lWT5PMPJ4W3mXn16hJymIZiTfuFLuD0AbIQdEHbkZ83jFa2m3VBoPR2VhJrt0FPqp5cNJtNNcXreLuVLSMpsYCbv1/s3yqdIQf2Q/nysJWDPv2K9Te7NE1sIM4oZWsP26xhbn6Ct4E/dviT+L2nnB2TvZzgzQv0JhNogDViTqczjznVpoOYtVwkCWlX3Twxt6/hxvCx3XZvQ1qbRt0BmeeR+fTtpYdGj7Iu31K9XwaYnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K57017YMNXRpO3MY3QcSzcXK9lKnE84DB0+wh2OlDw0=; b=SEQj2Z6dgj7ehvMri7tALddPhmVOBuMUTqXl5TFSrebkRlVwHjj0TVUnaXfk6Wo89UtiuRsuOk+uFzzm2m235+2jpwgomYNk/nglE2DBN3V/RxfMOvUbo3129h2bRGj79tl0YYv4XpLpTL+88WrYMbwFW3l8mHl5A883rvN1j++P95s1oPrrRp/s/1doaPF9miE1AJhrbVvRfQRk6HKijeVUw8ZM+sQIhnULX7f2tIdQ9k8gMK/AGay6aV03usfzN28vbvHlNcQrK+NSFJrDjBYtCwaVn6+4AOxnIx5ir8IsPd8Vu22lAsMKFIEZf2apnxROd0pB/aLSXtTD1TKF2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K57017YMNXRpO3MY3QcSzcXK9lKnE84DB0+wh2OlDw0=; b=Dmg4cUWMtEdYsNI9SjGpKjhmc4lJvz7Ig7ZGVKxlio5xhjLOAml6ie0V1S/7bdDk7RLeks8X93zyBRqJqcPoVw948aNRqPfJDkFaCGZ8aVTktBPG32NE9DEt2g8Zl+Nmqfvth9S8XwJVK2FPFFsNt5OgoLQwy7FMnpiDN+ljQ6U= Subject: Re: [for-4.15] Re: [PATCH XENSTORE v1 00/10] Code analysis fixes To: Julien Grall , Norbert Manthey , CC: Ian Jackson , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <759336de-727b-db67-b082-709d5ee735f8@xen.org> From: Andrew Cooper Message-ID: <144f2b06-d563-a699-8481-48b6787d502a@citrix.com> Date: Mon, 1 Mar 2021 19:39:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <759336de-727b-db67-b082-709d5ee735f8@xen.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0441.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 42286d66-27e7-478b-693d-08d8dce9c3d6 X-MS-TrafficTypeDiagnostic: BY5PR03MB5079: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ds73RmjOQPgNvdm6pZVnkfF4zVxRdNY5nvIM1j89Oak53DrsAL3MawYi7fJOkZfeyedi2Kd/WDy4sTtRuhy3S+E61RdsZIHQ31YLg/d3BJ/YcMAhZ5dlafVVTaGXQhIOaewn9bvbbozkL9a9FrOMyL63b3uehxH7IWddVZKaOvmgy2RYm6L3cQ/sJnGdXy/C+b7VN+Y5RN9luZgXYH1lKBOQsBED1FCntBnFWzod25RttBdY6Gimu8hBwYC3IymIFACr3SCbxQE+8rW3nXe6MiyYWy/DayiwWIJc/BmJu82We5NBH0T0a5BZMxs3owVIHAEKQnQowxIAuZrnOB5gckUHJVyJczGHSZ0nXfMbybb80bIxKxsrKERfQbcbhzWcFtsuIfFZHLQZh8H5AKSEVW4OXT4nUUJTiRKCiuW/zkma/LMWEhaJkPDWHhX8moRMvxUb+t3EP9bzOspn2wuCfqiFv6liNQDW7Duu+mMqga9MNoUv+Mr48+s4V1g9/jpJBucAw27p+0z4PkNjW1ReoJBvrCAe8AB0BN9LOJEm3bMJ3acgwLKMAOuJuqAk1/vO+c/OEDefARmlnpWjBQl6LPD6HmYO03VwE0HthleJgHg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(346002)(366004)(136003)(39860400002)(186003)(86362001)(8936002)(6486002)(8676002)(4326008)(36756003)(2906002)(83380400001)(31696002)(478600001)(6666004)(16526019)(316002)(54906003)(31686004)(53546011)(110136005)(16576012)(66946007)(66556008)(66476007)(26005)(956004)(5660300002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?M1laQmpyTk5meVQ1eWdHUG9oUzNua29WTEhVa0I1OUN1ZVBtSXVib3FOZWRK?= =?utf-8?B?YTA5T2Z3c1diNVkwaHIvQUxWQ1BoR1g5YTRDallvQWJUS0RQdi9MMFpIVkw3?= =?utf-8?B?M24wMjlhTmpWYWhGck4vbWU2dC9SNi9UNWxVWWJRSTFGRzVURUhVeVB6U3Yr?= =?utf-8?B?b3dQQW5sQSttdGhwczFTZFRGR0R6VXRSSXRFMG5MMlZyM0JzM01mWHA5V2Ey?= =?utf-8?B?OXdZN3NCbXgweHVqTWM4U0FJcmF3cTUwTklkRjZtWitRL29mUE4vMWZCKzBu?= =?utf-8?B?SUFBSVpkSmI1MVJlVnFndnc2UUxLTGJJVHhEZENwR1c2cmY5VVlVcmhSMTR4?= =?utf-8?B?cHFsdlNmN2g5c3NwRHNVWHErdE1GZ1pVTk43UnVyK3Vxb0VCeVNrdjF2RlhU?= =?utf-8?B?NkxxdW9UK01CWitsTnlJUE5NemswNEhGb251QUM5ZjBWUWhlV0hybkU2em5C?= =?utf-8?B?dmEwYWVLbmRuVTdFelRla3NuMElLZWVmcGNxVG5PRnhXZDVPbzZhMjZIOWFQ?= =?utf-8?B?YVBuNlFoQnFGSDBEcTh6RG4vY056eFBXVmJuRGFvaWpMWWU1TUxZM2xGcEE1?= =?utf-8?B?SGZJeFVSMHpKZllGWGczQ2dicUxMSlQ0a0tXRk45bUVjQ2IyQVVCNmRWaHNK?= =?utf-8?B?Q0k0VjNFVnB2WkVKS2RpSHdGS1hrRE9pbmFIeTkwT01GUGU0cjZLUXBzUytt?= =?utf-8?B?ckdpcmEyeWJZMjlSS1ZZT0psaFl6MjJpUjNtTTBPMUU5RlJHNVgzZDBIbUVa?= =?utf-8?B?K1hPZU0zNlh3K1RTenFSTUhGRjUvVUhhdVc3aHVOZklaaG1mYTdXbXk4RU9B?= =?utf-8?B?UWUxR3N1Wk1ybWlLTWU5aFhkQ2xGWXVHd0QyWnk2ZWgvUVg0Z1JCWDVBQ1lY?= =?utf-8?B?UFdBb216ZGo3SkxveVNIQUhVRzltYVNDM0pFVDR2N1BvY2RKWHo2WVFQK1B0?= =?utf-8?B?RWUrTzBKWnd5UHk3OElwLzBqSXU1TWJFeG11eC9EV2pQR3JuMzU3cStYNXVl?= =?utf-8?B?RFlEemVFT3BsU1pJVlNydEF2bTcvSTdWRU9mcDVzVlFNOXkvTE5paHBmQnNJ?= =?utf-8?B?QjgrZWRXaXNIV0dzZ2dWeGJ3cTRhYm1GTHo2TDZ0VW1IQWx2SVptcUw5dzU0?= =?utf-8?B?dWF3K2gveDI0TDYrdVBBVWpnWEJVMUhqb3NaQTBGc2x3ZlR4MmRYbHYzM3VP?= =?utf-8?B?cWVqdFUwUFh3SndrcUl5Q3d0QngvblBpMnRzVFV6ZTFhbnNjTXMrOGE2dEV3?= =?utf-8?B?UkEzOUJsWS9jcXBObkt3OVNGZkJxMVl3c29uTzFkWmVHc0M2enNueFl6clo5?= =?utf-8?B?cy9HaHcrbXNDc1NMTnZRMHh1VTF1S0FNeDhXbTlXNHFVc0V2b05RQno3dEJV?= =?utf-8?B?dm4zSDUyYWVMTStDNklEYVJjc0xCR3BDckVKS01GRlFjK3JDVnhhd3pNc1hy?= =?utf-8?B?U1dSTWMvYWNxMVYzcEtIcUE0SHRPdnVDa25JMEp0T0pwWEh0SWpDVmJ5VVhi?= =?utf-8?B?UituMTczREpwTGZUOGJiZElQSFNLcFB5OXpjV0JFVnNucTlYWi8zZWRhaXk4?= =?utf-8?B?V09KRll0bHlNV3JkS3NjcVJzMWF1L0VjVGFwRm92eHNVc0ZlRG1RYi9GcTdn?= =?utf-8?B?eGJ2MXVmc0VUc0tmQTZ6bU1DUVI2WXNJK1FIRXhsSGtGQVBUM21Gc0g4WnRQ?= =?utf-8?B?azdIb0lxcmtkb2YreG9XUGszdUxIUG5xVUFrVTRTczAvNktMNk55dnBRS1F0?= =?utf-8?Q?JPQTa3BATlOx7fnREh6c/m50LHiYlK96WerrJ5A?= X-MS-Exchange-CrossTenant-Network-Message-Id: 42286d66-27e7-478b-693d-08d8dce9c3d6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 19:39:44.5943 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aBdVXMHrvAXB/XRVowqG/Fxa1C3SSc0lVI/IndgvJnNj98o65htqMjvLOpUBdwQSFo4hSMRbmeRPen8jfPRXtyEPR90ckepErz+xkbaxGjo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5079 X-OriginatorOrg: citrix.com On 01/03/2021 18:01, Julien Grall wrote: > Hi, > > I have tagged the e-mail with 4.15 as I think we likely want some of > the patches to be in the next release. > > As a minimum, we get the following: >   - patch #7: xenstore: handle do_mkdir and do_rm failure >   - patch #8: xenstore: add missing NULL check >   - patch #10: xs: add error handling > > The first two add missing NULL check in runtime code in XenStored. The > 3rd one adds a missing NULL check in xs_is_domain_introduced() in > libxenstore (can be used at runtime by xenpaging at least). > > In addition to that, I would like to consider patch #3: xenstore: > check formats of trace. It is allowing the compiler to check the > format printf for trace(). This should be low-risk. > > For the rest is a mix of silencing coverity and potential errors > either at init or in a standalone binaries. > > The init ones would be useful (patch #1, #5, #9) for Xenstored > LiveUpdate as they would be potential triggered when upgrading the > binary. But I am not sure whether we consider LiveUpdate supported. > > Any thoughts? Live Update is a headline feature, even if only tech preview. I'd say that all bugfixes are fair game, and low risk.  All these fixes (other than the evtchn one which has an outstanding question) look to be reasonable to take.  They're all simple and obvious fixes pointed out by static analysis. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 01 21:10:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 21:10:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91971.173599 (Exim 4.92) (envelope-from ) id 1lGpnt-0008OG-B0; Mon, 01 Mar 2021 21:10:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91971.173599; Mon, 01 Mar 2021 21:10:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGpnt-0008O9-7h; Mon, 01 Mar 2021 21:10:09 +0000 Received: by outflank-mailman (input) for mailman id 91971; Mon, 01 Mar 2021 21:10:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGpns-0008K6-3i for xen-devel@lists.xenproject.org; Mon, 01 Mar 2021 21:10:08 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dd75525f-aa01-441b-a188-82c6886b75a9; Mon, 01 Mar 2021 21:10:07 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPS id B1F67600CD; Mon, 1 Mar 2021 21:10:06 +0000 (UTC) Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id 9A97660C1E; Mon, 1 Mar 2021 21:10:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd75525f-aa01-441b-a188-82c6886b75a9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614633006; bh=10f66vRrDYObGPqDTKUGYf/ghz73u8i/BH9WbY3ERq0=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=TAdxXkv5//SGIll546yMVvLtcxmA29ufr+h+VL103orZWse3heXqtLXzXEVF7Hbi/ wQLiUZEqho5ozwEN9ZK/OOAXoOZPJlVq06cMRt2rW0E+3BBMNHiDYlSEcSjH/XisFf dnu/yyAuPfE5I3JZMLA68u8b+h+8TLYI0df0ighed0kKZLPalqi/7JWfDKi5xVd4A1 h8C90laa+A7MMwdmLkHTlWCc9NrPKCBSb+KQ0SdaUQsL/Kb60yUN+T/Us9jRdbgLK/ uARGl3bIU+Kv3EXPZ+1MjFl3gu2Dmw1O8wA3HtHb/p2cOH45ILIMLpTotoE9RBbx29 rWsT06Di3zfqQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating From: patchwork-bot+netdevbpf@kernel.org Message-Id: <161463300662.4342.7670414356889270416.git-patchwork-notify@kernel.org> Date: Mon, 01 Mar 2021 21:10:06 +0000 References: <6604dec2-4460-3339-f797-e5f8a7df848f@suse.com> In-Reply-To: <6604dec2-4460-3339-f797-e5f8a7df848f@suse.com> To: Jan Beulich Cc: wl@xen.org, paul@xen.org, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 25 Feb 2021 16:39:01 +0100 you wrote: > shinfo already holds the result of skb_shinfo(skb) at this point - no > need to re-invoke the construct even twice. > > Signed-off-by: Jan Beulich Here is the summary with links: - xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating https://git.kernel.org/netdev/net/c/826d82170b53 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From xen-devel-bounces@lists.xenproject.org Mon Mar 01 22:51:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 01 Mar 2021 22:51:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.91980.173611 (Exim 4.92) (envelope-from ) id 1lGrNm-0001B2-El; Mon, 01 Mar 2021 22:51:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 91980.173611; Mon, 01 Mar 2021 22:51:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGrNm-0001Av-BN; Mon, 01 Mar 2021 22:51:18 +0000 Received: by outflank-mailman (input) for mailman id 91980; Mon, 01 Mar 2021 22:51:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGrNl-0001Am-5D; Mon, 01 Mar 2021 22:51:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGrNk-00023a-UI; Mon, 01 Mar 2021 22:51:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGrNk-00053k-MW; Mon, 01 Mar 2021 22:51:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lGrNk-0006Gj-Li; Mon, 01 Mar 2021 22:51:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L20EMPabNsWBI5EGeNo8GXQnun/fUEuL9rUMc0zwpWc=; b=qhnbpvIRwIRwi+gAKy3XFrDdhB lSRaDJLqF9syNw98Ach8rEJ448aT+JycTYlbUzNd0qlseUPEeobbVZnk1D00bHOmKXh1/W46xER5z hC9oH2m2RHp8vLF5vPLeF3vTvKUt53ceRBOnrb3nDitcyJuLnTOOWeSP/KN+pC+gA/Yc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159791: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=51db2d7cf26d05a961ec0ee0eb773594b32cc4a1 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Mon, 01 Mar 2021 22:51:16 +0000 flight 159791 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/159791/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 159780 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 51db2d7cf26d05a961ec0ee0eb773594b32cc4a1 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 193 days Failing since 152659 2020-08-21 14:07:39 Z 192 days 371 attempts Testing same since 159700 2021-02-26 08:46:59 Z 3 days 7 attempts ------------------------------------------------------------ 428 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 117941 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 02 00:44:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 00:44:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92003.173643 (Exim 4.92) (envelope-from ) id 1lGt9T-0003zh-Rb; Tue, 02 Mar 2021 00:44:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92003.173643; Tue, 02 Mar 2021 00:44:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGt9T-0003za-Oa; Tue, 02 Mar 2021 00:44:39 +0000 Received: by outflank-mailman (input) for mailman id 92003; Tue, 02 Mar 2021 00:44:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGt9S-0003zT-9u for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 00:44:38 +0000 Received: from mail.bitfolk.com (unknown [2001:ba8:1f1:f019::25]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a4609805-f63f-42a7-9926-6670dc830d81; Tue, 02 Mar 2021 00:44:36 +0000 (UTC) Received: from andy by mail.bitfolk.com with local (Exim 4.84_2) (envelope-from ) id 1lGt9O-0002Fw-NQ for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 00:44:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4609805-f63f-42a7-9926-6670dc830d81 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=bitfolk.com; s=alpha; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date; bh=VRgcg4bkoQUiZiUmSrKnYj32LjVYxw8K7GbLGase1jw=; b=aQ1rkjAV04C6Ud4WGk3tnrFaLA7IvA9lJHEcEAJKE/HTALV2OxC5CO3NHDemrqCzGHY9j0xneVPWWQcwWXjMXZGcQzeQ03V4YDFGdDCUgovpfW8RFH4wN36TiBg/11YNtzriQC8QmVk794SpQn8piHKLKMR7mHITHWbn7gKTGE05MJgeT1w1d2wZvpRvypTWNdxqK5B7yy5lmy6OvfkuvT7HyMzj7sGhUVvu2lY8bx74mcewR04N1qSKRfk36zcLVeSH03HjyGIWkV7YzQFspb5kGInt/L0HR6SfOuM5t79emU968uvmbG0wcYv7oBq16aRlG9PnLD94/L/VBlWkLA==; Date: Tue, 2 Mar 2021 00:44:34 +0000 From: Andy Smith To: xen-devel@lists.xenproject.org Subject: Re: dom0 suddenly blocking on all access to md device Message-ID: <20210302004434.GG29212@bitfolk.com> References: <20210226223927.GQ29212@bitfolk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210226223927.GQ29212@bitfolk.com> OpenPGP: id=BF15490B; url=http://strugglers.net/~andy/pubkey.asc X-URL: http://strugglers.net/wiki/User:Andy User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: andy@strugglers.net X-SA-Exim-Scanned: No (on mail.bitfolk.com); SAEximRunCond expanded to false Hello, On Fri, Feb 26, 2021 at 10:39:27PM +0000, Andy Smith wrote: > just lately I've been sporadically having issues where dom0 blocks > or severely slows down on all access to the particular md device > that hosts all domU block devices. This just happened again on the same server as the previous occurrence on 26th February. Again I was able to get things going again and avoid having to destroy all guests and hard reset the host by doing a destroy on a guest that was seen to be trying to do the most block IO (through xentop). This means that this particular host is still on Debian buster kernel 4.19.0-13-amd64 and credit2 scheduler. As it's been only a few days this might present itself again on this host quite soon. Is there any useful information I can provide when it does? Unfortunately there were no logs of interest neither in the dom0 syslog, guest syslog nor dom0 serial console. After the heavy IO guest was destroyed dom0 syslog did give: Mar 2 00:14:08 clockwork kernel: [6732447.973298] xen-blkback: Scheduled work from previous purge is still busy, cannot purge list …but I assume that is just a result of IO springing back to life. Thanks, Andy From xen-devel-bounces@lists.xenproject.org Tue Mar 02 02:38:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 02:38:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92029.173673 (Exim 4.92) (envelope-from ) id 1lGuv8-0002VK-Ca; Tue, 02 Mar 2021 02:37:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92029.173673; Tue, 02 Mar 2021 02:37:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGuv8-0002VD-91; Tue, 02 Mar 2021 02:37:58 +0000 Received: by outflank-mailman (input) for mailman id 92029; Tue, 02 Mar 2021 02:37:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGuv6-0002V5-Kz; Tue, 02 Mar 2021 02:37:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGuv6-00025f-BS; Tue, 02 Mar 2021 02:37:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGuv6-0000tZ-14; Tue, 02 Mar 2021 02:37:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lGuv5-0005qU-W6; Tue, 02 Mar 2021 02:37:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/kgtpuGZTzMhD+GIw74UuJPuKr31t4F8YsxqAeAZj5c=; b=roAfBo9jn4Rv6hr1u4ue13mxv/ XYGncxqT16rT8DLwxaC+xP4osMvyFj8T9CYJWwMJ6LLdv4HjaVg2fyNRosotcjWOoODaIUxT4X5v6 msF/kRIvVsUQwovapKldPn0k/Qp9SvCDrfuYBF0ep5ess9+FKMRxCXe3k6jnO133Xj5s=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159794: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Tue, 02 Mar 2021 02:37:55 +0000 flight 159794 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159794/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 213 days Failing since 152366 2020-08-01 20:49:34 Z 212 days 367 attempts Testing same since 159789 2021-03-01 03:59:22 Z 0 days 2 attempts ------------------------------------------------------------ 5135 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1270853 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 02 03:31:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 03:31:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92041.173688 (Exim 4.92) (envelope-from ) id 1lGvkW-0008Bu-GJ; Tue, 02 Mar 2021 03:31:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92041.173688; Tue, 02 Mar 2021 03:31:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGvkW-0008Bn-DE; Tue, 02 Mar 2021 03:31:04 +0000 Received: by outflank-mailman (input) for mailman id 92041; Tue, 02 Mar 2021 03:31:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGvkU-0008Be-Pa; Tue, 02 Mar 2021 03:31:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGvkU-0002vJ-DE; Tue, 02 Mar 2021 03:31:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGvkU-0002yY-5f; Tue, 02 Mar 2021 03:31:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lGvkU-0001I7-5C; Tue, 02 Mar 2021 03:31:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=y1q8CprR69nMqiWWC0uaEnrxL7SvV9GQ7YLnk2G+hks=; b=yhp8Rs2F1MjrIigL2u7O6/uI2m 9aq+H9huZP11gdliG0Bz/awCPSHWhmq+b8w5j+L1ynPYDuzcf4tfohahpmQ7H2Ids67kim0X2aLTl XQqNXz4X1d4XVUcNpfUwmTvLAp0bGkgW/t33d/eM3SFji+N3S5FujQbWkzIGVBMl2xS4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159797: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6b4d4dd38470c2293caddf0a5f7034bb832bb574 X-Osstest-Versions-That: xen=77d7b3540c12b9bebba67dca8eb2d939d9e8b5df From: osstest service owner Date: Tue, 02 Mar 2021 03:31:02 +0000 flight 159797 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159797/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 6b4d4dd38470c2293caddf0a5f7034bb832bb574 baseline version: xen 77d7b3540c12b9bebba67dca8eb2d939d9e8b5df Last test of basis 159793 2021-03-01 15:02:33 Z 0 days Testing same since 159797 2021-03-02 00:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 77d7b3540c..6b4d4dd384 6b4d4dd38470c2293caddf0a5f7034bb832bb574 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Mar 02 05:07:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 05:07:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92058.173703 (Exim 4.92) (envelope-from ) id 1lGxFW-0000aB-Ka; Tue, 02 Mar 2021 05:07:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92058.173703; Tue, 02 Mar 2021 05:07:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxFW-0000a4-HX; Tue, 02 Mar 2021 05:07:10 +0000 Received: by outflank-mailman (input) for mailman id 92058; Tue, 02 Mar 2021 05:07:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxFV-0000Zz-Oa for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 05:07:09 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 14774113-8cae-4023-a375-5a1c08c3008f; Tue, 02 Mar 2021 05:07:08 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8721BAF38; Tue, 2 Mar 2021 05:07:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14774113-8cae-4023-a375-5a1c08c3008f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614661627; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/IorC4s2wguYf/TWKF1UoKaRHVR/RQCF2tBaHCx77fo=; b=YwW8DRoClrU6b4NnnUSM7lopGuM/fowAimlrA7EN6gGk7RZCYT+SQYjdooVKNUNecpH2Ux sLRwvHlPmN9wNu+s74pOibbhkTWuPT45p94bjIyljDs+8us6EwXsvxmHmxE8tFyW8Jt/U/ MVH+avhqo5UdZWYP068UE8O/zKcJm/I= Subject: Re: [PATCH XENSTORE v1 01/10] xenstore: add missing NULL check To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-2-nmanthey@amazon.de> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <00f5c8f5-4bff-105f-87d5-76cde5ac1667@suse.com> Date: Tue, 2 Mar 2021 06:07:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226144144.9252-2-nmanthey@amazon.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Jxt1DNP9e167imzNBBiLKWQeTgWkCAbIT" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Jxt1DNP9e167imzNBBiLKWQeTgWkCAbIT Content-Type: multipart/mixed; boundary="LKiQb9IqPWqNL1GMztrV5YsR8CQ4qNYdz"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth Message-ID: <00f5c8f5-4bff-105f-87d5-76cde5ac1667@suse.com> Subject: Re: [PATCH XENSTORE v1 01/10] xenstore: add missing NULL check References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-2-nmanthey@amazon.de> In-Reply-To: <20210226144144.9252-2-nmanthey@amazon.de> --LKiQb9IqPWqNL1GMztrV5YsR8CQ4qNYdz Content-Type: multipart/mixed; boundary="------------B23E4785A4355A1652956303" Content-Language: en-US This is a multi-part message in MIME format. --------------B23E4785A4355A1652956303 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 26.02.21 15:41, Norbert Manthey wrote: > In case of allocation error, we should not dereference the obtained > NULL pointer. Hence, fail early. >=20 > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. >=20 > Signed-off-by: Norbert Manthey > Reviewed-by: Thomas Friebel > Reviewed-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------B23E4785A4355A1652956303 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------B23E4785A4355A1652956303-- --LKiQb9IqPWqNL1GMztrV5YsR8CQ4qNYdz-- --Jxt1DNP9e167imzNBBiLKWQeTgWkCAbIT Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA9x/oFAwAAAAAACgkQsN6d1ii/Ey8x 9gf/SAWnqbV/OHThAxUhNNoYnkgk3TQ7QrazdazNaT4LU7LiRiOGYjC5U/cxLSpLfEq6xXlRwy96 bv4JqbrogRbBFuUNLxFKM6kIwlo0r0LgWd5wqsbB3MXBVXWmO8pI3T9MbCuxPTyppmNwER5bmm32 Gjwk5dTIRBlmSsa+1X6QPaxlOx3l/HkywK0pMbtT7QqQhBX00Q1CUTi043K7mo/ozC8iskElE6fB SMpKFPHzBV5m7sdBzApTxuA3971M2HMv4fmImar4PIvAEtf2VV/jSmfppeWB4EcjmvQnXpLkn2YT 9GS/Tmo91rMLUOsRr9gEVe2xv4ng9V6xbF2KrQ/9XA== =pH6L -----END PGP SIGNATURE----- --Jxt1DNP9e167imzNBBiLKWQeTgWkCAbIT-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 05:07:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 05:07:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92059.173715 (Exim 4.92) (envelope-from ) id 1lGxFw-0000e7-TK; Tue, 02 Mar 2021 05:07:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92059.173715; Tue, 02 Mar 2021 05:07:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxFw-0000dz-Q6; Tue, 02 Mar 2021 05:07:36 +0000 Received: by outflank-mailman (input) for mailman id 92059; Tue, 02 Mar 2021 05:07:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxFv-0000dm-TZ for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 05:07:35 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 667f7717-0b9f-4331-8bae-4ab92f2dcaa0; Tue, 02 Mar 2021 05:07:34 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 08255AAC5; Tue, 2 Mar 2021 05:07:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 667f7717-0b9f-4331-8bae-4ab92f2dcaa0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614661654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zhd56q2h40yf4CYwyVp1J0Yqjyjn/Qq0s2SUWt6v318=; b=P+c1C7vdHpFnSHPWx8bYJSb6v395/iIeVQybU1ErFGA1d+Tu6Ip70hAfCye8A+WfNaEqfa Wl9t+LzoxKbaD5ijXylDZqhduJMFZT9MODSo85rczQamkGjzDorI/deysiFHqqA+1PPOlp +B37tioOuWVkEo66WFa8wI1lKE6nb0U= Subject: Re: [PATCH XENSTORE v1 02/10] xenstore: fix print format string To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-3-nmanthey@amazon.de> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <8416bc5a-2b22-ec0f-45c5-c2c9b86bbc12@suse.com> Date: Tue, 2 Mar 2021 06:07:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226144144.9252-3-nmanthey@amazon.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9xVuo9y3JK8BNgRTfDA76bmJEPU6oxCWN" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9xVuo9y3JK8BNgRTfDA76bmJEPU6oxCWN Content-Type: multipart/mixed; boundary="ANqM4DtVSQI2qDhEIO4PPxDLfI427vRfE"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth Message-ID: <8416bc5a-2b22-ec0f-45c5-c2c9b86bbc12@suse.com> Subject: Re: [PATCH XENSTORE v1 02/10] xenstore: fix print format string References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-3-nmanthey@amazon.de> In-Reply-To: <20210226144144.9252-3-nmanthey@amazon.de> --ANqM4DtVSQI2qDhEIO4PPxDLfI427vRfE Content-Type: multipart/mixed; boundary="------------C08D011092BAC5186A0CA174" Content-Language: en-US This is a multi-part message in MIME format. --------------C08D011092BAC5186A0CA174 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 26.02.21 15:41, Norbert Manthey wrote: > Use the correct format specifier for unsigned values. Additionally, a > cast was dropped, as the format specifier did not require it anymore. >=20 > This was reported by analysis with cppcheck. >=20 > Signed-off-by: Norbert Manthey > Reviewed-by: Thomas Friebel > Reviewed-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------C08D011092BAC5186A0CA174 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------C08D011092BAC5186A0CA174-- --ANqM4DtVSQI2qDhEIO4PPxDLfI427vRfE-- --9xVuo9y3JK8BNgRTfDA76bmJEPU6oxCWN Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA9yBUFAwAAAAAACgkQsN6d1ii/Ey96 nQf/YKtgLQ59zozz9M3hjFJyUv263zdM9wYenYHtxobWRKgZB8aeXtBhKJO7LRq6KCIpmPv8yOuN /yZIy40PETWRUnuZV0rYzeoSn3cIDhI/QtXbPS57RF6bB5JsBq3OjIi3yYtkg8U1zGHYcXrsb9Mn gXEgr36o14XgUMYzA8Miyron8rkGAdjXTGfrIUq1zkp3AhoI5L8nt1sqoczNe56+v1olT43nZjsQ Vy239p17e4Hft3ZP/Ur9yR4XL2ioq6hY+qh+SR1k62f97G/B+RWse7WcvfZYAXalXmDNiF304tET g6PCnX4Vrt0+C+Xvm3L1n+oT7vHWMqHcdcvxPUHfog== =9VnZ -----END PGP SIGNATURE----- --9xVuo9y3JK8BNgRTfDA76bmJEPU6oxCWN-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 05:08:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 05:08:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92064.173727 (Exim 4.92) (envelope-from ) id 1lGxGR-0000kz-79; Tue, 02 Mar 2021 05:08:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92064.173727; Tue, 02 Mar 2021 05:08:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxGR-0000ks-38; Tue, 02 Mar 2021 05:08:07 +0000 Received: by outflank-mailman (input) for mailman id 92064; Tue, 02 Mar 2021 05:08:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxGP-0000kl-4e for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 05:08:05 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3b9d276e-ce2b-4630-be92-ac4adabfe403; Tue, 02 Mar 2021 05:08:04 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 63C75AF42; Tue, 2 Mar 2021 05:08:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b9d276e-ce2b-4630-be92-ac4adabfe403 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614661683; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GuPZpo92mMF+eXi6V19Vtb/4pJKfhfEYrUYSFqHjDmk=; b=S47VMpFzGJECagFt08ef+/cNVDp3A1t05DfChgiYp30J6xEBgFeb7rOxVVo6+vTEJjLxuJ I5aV6WC0zunL33R3czkMIC1Ekm/QW5aV75qCdy0wuPtxPrrU5rbqBv/VQRQtAmb4wHr0B4 47sr5n56onPD/xc6lCqGEpU02gjihV0= Subject: Re: [PATCH XENSTORE v1 03/10] xenstore: check formats of trace To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-4-nmanthey@amazon.de> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <1e5c80c2-9306-0332-8bc1-cc95dbc83ccd@suse.com> Date: Tue, 2 Mar 2021 06:08:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226144144.9252-4-nmanthey@amazon.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Keagi0xqEvXvT3adLijyfQDquxNsqqZJl" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Keagi0xqEvXvT3adLijyfQDquxNsqqZJl Content-Type: multipart/mixed; boundary="gWtHmy5wJhNcNSgWhJCaTrueVwJ9Jbn3R"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth Message-ID: <1e5c80c2-9306-0332-8bc1-cc95dbc83ccd@suse.com> Subject: Re: [PATCH XENSTORE v1 03/10] xenstore: check formats of trace References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-4-nmanthey@amazon.de> In-Reply-To: <20210226144144.9252-4-nmanthey@amazon.de> --gWtHmy5wJhNcNSgWhJCaTrueVwJ9Jbn3R Content-Type: multipart/mixed; boundary="------------78D29FABA71603A07543D28D" Content-Language: en-US This is a multi-part message in MIME format. --------------78D29FABA71603A07543D28D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 26.02.21 15:41, Norbert Manthey wrote: > When passing format strings to the trace function, allow gcc to analyze= > those and warn on issues. >=20 > Signed-off-by: Norbert Manthey > Reviewed-by: Thomas Friebel > Reviewed-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------78D29FABA71603A07543D28D Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------78D29FABA71603A07543D28D-- --gWtHmy5wJhNcNSgWhJCaTrueVwJ9Jbn3R-- --Keagi0xqEvXvT3adLijyfQDquxNsqqZJl Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA9yDIFAwAAAAAACgkQsN6d1ii/Ey9S pAf/aZh55vA2pSBMZ/NKBSV7co6h8issEZueJArDV1eLor0mBHH2gd/02251QvodbI9Db14mdpnE onFiXMRoBD1Tt3iPBGm/WP9TVd08utw+YOvntZhwnJb/NCVvog6frfkyt41t2zomWpr850OL3E8V E8TWT9w/WoiFViWEndpALbzoQkH8D7zzUtPxdVltPEMtFdhRgyJfgsDjgcnXAB9s94bzJtZ61ttZ e3+qoecNeR8d270L1GfP2pfHLkJd1t9c2XfzMAmq+iqvgcx7W1lYC++p6P5iJqqMHHIhVBWpUglD Bqc+epMF3HWUucDE0wH+/DACnsOc8Ddq8prh7ClxAA== =t7mE -----END PGP SIGNATURE----- --Keagi0xqEvXvT3adLijyfQDquxNsqqZJl-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 05:08:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 05:08:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92066.173738 (Exim 4.92) (envelope-from ) id 1lGxGt-0000r3-FW; Tue, 02 Mar 2021 05:08:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92066.173738; Tue, 02 Mar 2021 05:08:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxGt-0000qw-Cd; Tue, 02 Mar 2021 05:08:35 +0000 Received: by outflank-mailman (input) for mailman id 92066; Tue, 02 Mar 2021 05:08:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxGs-0000qo-VF for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 05:08:34 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 71b11b7f-4269-45c4-b02e-76871cac8642; Tue, 02 Mar 2021 05:08:34 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 69413AF3D; Tue, 2 Mar 2021 05:08:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71b11b7f-4269-45c4-b02e-76871cac8642 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614661713; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XGlmdWCcxPIoZ/5IbtfMq6LZi/5JaokMs/dNhoe3CDA=; b=mN0/xPQ42BQUgs74nSnclrqJc6fSAsVvYyb+GF511ioULuqr8GjosrOrPLvf/ua5UE/2Y0 TePxZuVirG3VvPZmJg3ub7nCT1ddUlhKJOCy4GqH+bH8gzli3dy+nk0c4HKFfRflMx06l+ ddiqPuyUdvIgBKiBy14Dr/dORRVEvNs= Subject: Re: [PATCH XENSTORE v1 04/10] xenstore_client: handle memory on error To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-5-nmanthey@amazon.de> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <0b6cfcc1-21ec-c7b6-f108-ee7fa6220494@suse.com> Date: Tue, 2 Mar 2021 06:08:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226144144.9252-5-nmanthey@amazon.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4bU43dAFurs5IHJjtf46bJf4HoqrMj3cy" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4bU43dAFurs5IHJjtf46bJf4HoqrMj3cy Content-Type: multipart/mixed; boundary="4p3yzyqxSP3Hf1jQJNvArxeC7ffeGmLIg"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth Message-ID: <0b6cfcc1-21ec-c7b6-f108-ee7fa6220494@suse.com> Subject: Re: [PATCH XENSTORE v1 04/10] xenstore_client: handle memory on error References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-5-nmanthey@amazon.de> In-Reply-To: <20210226144144.9252-5-nmanthey@amazon.de> --4p3yzyqxSP3Hf1jQJNvArxeC7ffeGmLIg Content-Type: multipart/mixed; boundary="------------289FCFF9E29771528664BC5B" Content-Language: en-US This is a multi-part message in MIME format. --------------289FCFF9E29771528664BC5B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 26.02.21 15:41, Norbert Manthey wrote: > In case a command fails, also free the memory. As this is for the CLI > client, currently the leaked memory is freed right after receiving the > error, as the application terminates next. >=20 > Similarly, if the allocation fails, do not use the NULL pointer > afterwards, but instead error out. >=20 > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. >=20 > Signed-off-by: Norbert Manthey > Reviewed-by: Thomas Friebel > Reviewed-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------289FCFF9E29771528664BC5B Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------289FCFF9E29771528664BC5B-- --4p3yzyqxSP3Hf1jQJNvArxeC7ffeGmLIg-- --4bU43dAFurs5IHJjtf46bJf4HoqrMj3cy Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA9yFAFAwAAAAAACgkQsN6d1ii/Ey93 3AgAlAxbYGVSjEVm8fkARtVlLTAXTN6L1oKWUPKP9U3OzUmxT6DC+t5lVJMzyf2adJDjD+1WkXEx i4ZzjRsmfr44z8pDjEc1CuiVsbSlngrJCLrO3q6AjBoC48T3aTyn4ZujTZPz9LzO5SWg5zkSY3ec MUPwjI8oz7C3MoZZixTZV296AfqPQttPrYvny2JxBCYQI5Am9qBaZ1izdoZnjqVu5sTSnWnKFHBY ZGCLkaQQmam8z5gbINauBqu7z2UlXzSlxxip6QAFl5QLOE+/1YDvbZAqB21gF2Sw9gFgieCNanip 5vZnBx81CkHJP/IM39AqIw5WvcKdy8+3rF0/VFHU6g== =UZP7 -----END PGP SIGNATURE----- --4bU43dAFurs5IHJjtf46bJf4HoqrMj3cy-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 05:09:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 05:09:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92071.173751 (Exim 4.92) (envelope-from ) id 1lGxHQ-000189-Um; Tue, 02 Mar 2021 05:09:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92071.173751; Tue, 02 Mar 2021 05:09:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxHQ-000181-RZ; Tue, 02 Mar 2021 05:09:08 +0000 Received: by outflank-mailman (input) for mailman id 92071; Tue, 02 Mar 2021 05:09:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxHP-0000yA-TF for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 05:09:07 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2c880729-846f-4376-aa2f-8c94ae6ce6bb; Tue, 02 Mar 2021 05:09:01 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2F7E1AF3D; Tue, 2 Mar 2021 05:09:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c880729-846f-4376-aa2f-8c94ae6ce6bb X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614661740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1TW9pSjgpzjkAnqQ0WdScwVRo3/WOwaa14r67YRRcPY=; b=oGeSZNCdl4QEjpkRcqSSEzGRsiSCt4HB7tF2rT16Vd6Ib40yO8npM8UquSkeSvTM06YlUY imX3gz1SpQBwUPyukv7FRbXkroBFSxWvNIEcPpyU9BzWAtpfRBRPl/BYiNnEyVGfiRD/Ub tjbBtUHMAt44aSqfhNMf7BjuMKIIhkY= Subject: Re: [PATCH XENSTORE v1 05/10] xenstore: handle daemon creation errors To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-6-nmanthey@amazon.de> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <959bc8f3-bcda-7209-84f1-8045e5fc9907@suse.com> Date: Tue, 2 Mar 2021 06:08:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226144144.9252-6-nmanthey@amazon.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="W8uV8cJ8SLIuU9EoP39igu1rc3GRlhg2f" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --W8uV8cJ8SLIuU9EoP39igu1rc3GRlhg2f Content-Type: multipart/mixed; boundary="tADIUG5tdBSDxjD6OLwCzgpj6icznqtDI"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth Message-ID: <959bc8f3-bcda-7209-84f1-8045e5fc9907@suse.com> Subject: Re: [PATCH XENSTORE v1 05/10] xenstore: handle daemon creation errors References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-6-nmanthey@amazon.de> In-Reply-To: <20210226144144.9252-6-nmanthey@amazon.de> --tADIUG5tdBSDxjD6OLwCzgpj6icznqtDI Content-Type: multipart/mixed; boundary="------------83840B20186CF4C0319A64C6" Content-Language: en-US This is a multi-part message in MIME format. --------------83840B20186CF4C0319A64C6 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 26.02.21 15:41, Norbert Manthey wrote: > In rare cases, the path to the daemon socket cannot be created as it is= > longer than PATH_MAX. Instead of failing with a NULL pointer dereferenc= e, > terminate the application with an error message. >=20 > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. >=20 > Signed-off-by: Norbert Manthey > Reviewed-by: Thomas Friebel > Reviewed-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------83840B20186CF4C0319A64C6 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------83840B20186CF4C0319A64C6-- --tADIUG5tdBSDxjD6OLwCzgpj6icznqtDI-- --W8uV8cJ8SLIuU9EoP39igu1rc3GRlhg2f Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA9yGsFAwAAAAAACgkQsN6d1ii/Ey8n nwf9FoM1pbGyVHBE9mefXeonmfaq9QwTaVJokrYHRusPTJTBy5RCzdLtlFRUmk+jMosYJTQ+BV9C hw6wEG/tpM299MyMk+7LqQyjI5+cfSIaXbjOFYZqALEViAJLjP2IQK8SEvUgK0I8rBrlLQ/kuSWD u1/5qUCnpCFWttKC5vIsscAVpm63O9+IfYqZgVnLOUfWtFO0Bvp2EX9xezeCwgl2ePiHUpj45FsD D0CyECn4ebpOullAOW3L0pMk+SuGfg5XkbnZUXONyHNNw2O2iPXFL9EdZZDbH2WugsavxQvS2wjy g3jr7oUpJEow6lO4rg5giAPqShXfVRhugASbsJkNgw== =h9Cw -----END PGP SIGNATURE----- --W8uV8cJ8SLIuU9EoP39igu1rc3GRlhg2f-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 05:09:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 05:09:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92074.173763 (Exim 4.92) (envelope-from ) id 1lGxHw-0001F3-9k; Tue, 02 Mar 2021 05:09:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92074.173763; Tue, 02 Mar 2021 05:09:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxHw-0001Ew-4u; Tue, 02 Mar 2021 05:09:40 +0000 Received: by outflank-mailman (input) for mailman id 92074; Tue, 02 Mar 2021 05:09:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxHu-0001Ek-Ul for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 05:09:38 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5147cfbd-9f68-4722-b412-7af76dd54a20; Tue, 02 Mar 2021 05:09:38 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 30BBEAAC5; Tue, 2 Mar 2021 05:09:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5147cfbd-9f68-4722-b412-7af76dd54a20 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614661777; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xqt2DdK7P9EhLZRxH/HRNfAaIVhmUGAArlMd9FEdguY=; b=lAMo7CvgRyRTrirWFycMFaBwNl2ivpH/7i007mb/QjVy4HoT3938Wqb0DwofcT+l0pbVOB K9VuhEybE/tJTupa8e8g3JgR5IuZxToajJoUQGUmkqHslec91d4crirI8l5kAQTSobUWg5 z+tfti2YkF3s1XuY6J91dLt/C6288aM= Subject: Re: [PATCH XENSTORE v1 07/10] xenstore: handle do_mkdir and do_rm failure To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-8-nmanthey@amazon.de> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <913c60fb-e9f8-eedc-ba75-985acd4d4c71@suse.com> Date: Tue, 2 Mar 2021 06:09:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226144144.9252-8-nmanthey@amazon.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Igii1kS1py62tVLzn22gEaNbyGMfkpxJ1" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Igii1kS1py62tVLzn22gEaNbyGMfkpxJ1 Content-Type: multipart/mixed; boundary="Byvk58AUib3gaQlepEAXeKOtLDDqWe9gx"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth Message-ID: <913c60fb-e9f8-eedc-ba75-985acd4d4c71@suse.com> Subject: Re: [PATCH XENSTORE v1 07/10] xenstore: handle do_mkdir and do_rm failure References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-8-nmanthey@amazon.de> In-Reply-To: <20210226144144.9252-8-nmanthey@amazon.de> --Byvk58AUib3gaQlepEAXeKOtLDDqWe9gx Content-Type: multipart/mixed; boundary="------------A47CB70527E16902772CFC51" Content-Language: en-US This is a multi-part message in MIME format. --------------A47CB70527E16902772CFC51 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 26.02.21 15:41, Norbert Manthey wrote: > In the out of memory case, we might return a NULL pointer when > canonicalizing node names. This NULL pointer is not checked when > creating a directory, or when removing a node. This change handles > the NULL pointer for these two cases. >=20 > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. >=20 > Signed-off-by: Norbert Manthey > Reviewed-by: Thomas Friebel > Reviewed-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------A47CB70527E16902772CFC51 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------A47CB70527E16902772CFC51-- --Byvk58AUib3gaQlepEAXeKOtLDDqWe9gx-- --Igii1kS1py62tVLzn22gEaNbyGMfkpxJ1 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA9yJAFAwAAAAAACgkQsN6d1ii/Ey9a MAf8CmLUKjB5+xwa9pytyEVQXyYSzNJUeRlAwN0ku9gErXKmiNtR/rjjhZltmiDfPlFOfFzJzIbU 0NgecTm56Z/ex11gEii0pSnTOACN9hn8kNT/zil8vI06YJvY+2FiHs/J+z0JuJpauE+DewgC/5gT z3RmT0WMsbv2/cQfThbi/1XR1wxbZFHyeoQjbLvY2PYoQOXcFg7/01/C1eoiVRtGWY+adn0dtF4H viHZHMPJdit4XngVgIv39rSkZ9Sx+YrZOCEHAHwCjxkx+lJmYKa784BV11Yo9dIjtE/ZVW37FBih fEO2NxePLefyWywZ2gn4Xn+zIimfbwDrvFARrSK89w== =1HUO -----END PGP SIGNATURE----- --Igii1kS1py62tVLzn22gEaNbyGMfkpxJ1-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 05:10:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 05:10:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92076.173775 (Exim 4.92) (envelope-from ) id 1lGxIO-00022X-Hf; Tue, 02 Mar 2021 05:10:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92076.173775; Tue, 02 Mar 2021 05:10:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxIO-00022Q-EN; Tue, 02 Mar 2021 05:10:08 +0000 Received: by outflank-mailman (input) for mailman id 92076; Tue, 02 Mar 2021 05:10:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxIM-00022E-L6 for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 05:10:06 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bc0c1dd6-573c-4d10-97eb-7ad7022ff83f; Tue, 02 Mar 2021 05:10:05 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CEE0DAC24; Tue, 2 Mar 2021 05:10:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc0c1dd6-573c-4d10-97eb-7ad7022ff83f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614661805; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i+aWBUW10JFZQ15sm0Po72B4JVJcG1lJ8O5kCTxYz00=; b=t2Ja0jM++lh5Z5nrnfnRze0RTDs2wDYpYz5uR+1Oetz2RsgOKxpEy7euoORPxfxydtvOrF mvw8SFp/lc9zGv9dFHNUcGAT7X4wCCf1uWdQBQo2CmQ19WeAnR9Fgurmb57nkk4QgphP77 rzY4uyzNzTPwmh6LxkCrVvy5oYeLjBM= Subject: Re: [PATCH XENSTORE v1 08/10] xenstore: add missing NULL check To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-9-nmanthey@amazon.de> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Tue, 2 Mar 2021 06:10:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226144144.9252-9-nmanthey@amazon.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N0a0mA34IKNXOnY2ZMg7HDNdxXJMBN1ZF" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --N0a0mA34IKNXOnY2ZMg7HDNdxXJMBN1ZF Content-Type: multipart/mixed; boundary="fb5sDVGWiVyYS6VRSFpAJNWLs7h53aHT5"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth , Michael Kurth Message-ID: Subject: Re: [PATCH XENSTORE v1 08/10] xenstore: add missing NULL check References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-9-nmanthey@amazon.de> In-Reply-To: <20210226144144.9252-9-nmanthey@amazon.de> --fb5sDVGWiVyYS6VRSFpAJNWLs7h53aHT5 Content-Type: multipart/mixed; boundary="------------7ED876177E0966D0C5866238" Content-Language: en-US This is a multi-part message in MIME format. --------------7ED876177E0966D0C5866238 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 26.02.21 15:41, Norbert Manthey wrote: > From: Michael Kurth >=20 > In case of allocation error, we should not dereference the obtained > NULL pointer. >=20 > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. >=20 > Signed-off-by: Michael Kurth > Signed-off-by: Norbert Manthey > Reviewed-by: Thomas Friebel > Reviewed-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------7ED876177E0966D0C5866238 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------7ED876177E0966D0C5866238-- --fb5sDVGWiVyYS6VRSFpAJNWLs7h53aHT5-- --N0a0mA34IKNXOnY2ZMg7HDNdxXJMBN1ZF Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA9yKwFAwAAAAAACgkQsN6d1ii/Ey+N sQf+NTLE9VNvfrbbV8xhiiaMBvcJweq+5xYT2y0ADmyf3pUPSYpieCFtDlSlB3But3rxjfiTwAi4 uRlFrrvRraM5OuWRncXvZm39FXEFqM0+f0qNIpMc2q6FXfy4daB0mm5q3oOyJqk5vKdSQSNLayQm UXvaKkWvhrtoEO0k4AuIEZqRZypI6xLX5BPVSl5sQ4v2pf8ljuorWT+GasvZnj5vOM/Lk7TwXwf3 yACuksfzJHRRJNgto9d9CsHkYM5ZvsnqHYJPu+X9UXNY1KERUmn5foxg1C/zZSjrb8DQ5Y8rOpKj GhBXPsFH4mCaNbNHeKgCHHHpjiiOORXR7wITYqi4kQ== =Bpqh -----END PGP SIGNATURE----- --N0a0mA34IKNXOnY2ZMg7HDNdxXJMBN1ZF-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 05:10:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 05:10:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92080.173787 (Exim 4.92) (envelope-from ) id 1lGxIm-00028v-R9; Tue, 02 Mar 2021 05:10:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92080.173787; Tue, 02 Mar 2021 05:10:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxIm-00028o-NO; Tue, 02 Mar 2021 05:10:32 +0000 Received: by outflank-mailman (input) for mailman id 92080; Tue, 02 Mar 2021 05:10:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxIl-00028d-Ur for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 05:10:31 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 26d97c93-f8b7-45b2-a501-41496f83b660; Tue, 02 Mar 2021 05:10:31 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5209AAF38; Tue, 2 Mar 2021 05:10:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26d97c93-f8b7-45b2-a501-41496f83b660 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614661830; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R8hHGbj2eDzTJYtkPxAG7KVnYgXfpxFtisnYSa9L3pI=; b=ZIWwW8EWCw2vW8egv9i12+ZIgdGu2eyn3+oTSZqVT3h4JFaYjCZWKTP5RsWtMpcHgH9QaA N4kvPRC0nz9420k09YTNdYb0FwxayAUHN2tsW2JWmSMBxesv4z19CipmPULtvBAwoSZoeK z39ItxZSM3ldGVr6Ch3xAZY/0FfA5ck= Subject: Re: [PATCH XENSTORE v1 09/10] xs: handle daemon socket error To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-10-nmanthey@amazon.de> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Tue, 2 Mar 2021 06:10:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226144144.9252-10-nmanthey@amazon.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="weu4EHGynY5IRS7wkdyYEh1LnHRcpHS8Z" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --weu4EHGynY5IRS7wkdyYEh1LnHRcpHS8Z Content-Type: multipart/mixed; boundary="efXblqgM0Nt8eiU3STcXoQ7g9TJXFBC1k"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth Message-ID: Subject: Re: [PATCH XENSTORE v1 09/10] xs: handle daemon socket error References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-10-nmanthey@amazon.de> In-Reply-To: <20210226144144.9252-10-nmanthey@amazon.de> --efXblqgM0Nt8eiU3STcXoQ7g9TJXFBC1k Content-Type: multipart/mixed; boundary="------------8A1348E5C31A983F07E88702" Content-Language: en-US This is a multi-part message in MIME format. --------------8A1348E5C31A983F07E88702 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 26.02.21 15:41, Norbert Manthey wrote: > When starting the daemon, we might see a NULL pointer instead of the > path to the socket. >=20 > Only relevant in case we start the process in a very deep directory > path, with a length close to 4096 so that appending "/socket" would > exceed the limit. Hence, such an error is unlikely, but should still be= > fixed to not result in a NULL pointer dereference. >=20 > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. >=20 > Signed-off-by: Norbert Manthey > Reviewed-by: Thomas Friebel > Reviewed-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------8A1348E5C31A983F07E88702 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------8A1348E5C31A983F07E88702-- --efXblqgM0Nt8eiU3STcXoQ7g9TJXFBC1k-- --weu4EHGynY5IRS7wkdyYEh1LnHRcpHS8Z Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA9yMUFAwAAAAAACgkQsN6d1ii/Ey8V lwf+NabH3m6Ow2zyO6dIrg0cJIlkiLZM0TwuwSE9BJN9alxS605TzgkoielJrrBGgS2LJDORwSXY om8QfWh8DJJC69czwIwdjKvXF/s0vhrnV1HldVRXE4iQ75uJ/SAtzq2ig2URvfOeWqdr0jxvf5Ha Dt5d04v0GdLmLx0PmwKiuQYRfj9zaqcv37NBeHcG7o0JcLeK13aJtkUjG1uu+6vmMltsX1HNPGYB TiGkFtIfsPGShlrwI2azwiZ22mn8aJW4LwlffxX343VnCsrGeOApa+HlDH9kLntcXtdqAsyvuvmS /NhlYZvzxo6q7wLkKS6y7mLFzXmlWShK6XQFzJ63oQ== =yTHN -----END PGP SIGNATURE----- --weu4EHGynY5IRS7wkdyYEh1LnHRcpHS8Z-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 05:11:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 05:11:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92084.173799 (Exim 4.92) (envelope-from ) id 1lGxJq-0002Kw-94; Tue, 02 Mar 2021 05:11:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92084.173799; Tue, 02 Mar 2021 05:11:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxJq-0002Kp-5w; Tue, 02 Mar 2021 05:11:38 +0000 Received: by outflank-mailman (input) for mailman id 92084; Tue, 02 Mar 2021 05:11:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxJo-0002Kg-PE for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 05:11:36 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9b868ab8-e4c0-4b6f-a798-223d335bc8dd; Tue, 02 Mar 2021 05:11:36 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3B280AAC5; Tue, 2 Mar 2021 05:11:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b868ab8-e4c0-4b6f-a798-223d335bc8dd X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614661895; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ieqJjZduduZPTxRgFb41qXRs8Z/JIuWf8tlRwGj0ceE=; b=u7wrrE6CBMp7nmUkerxQFLeozzE1Gfk+Ii0V0AeaoBeHOkDZPXOSeSRwx0FexHUXLpFdYf E1Z/BpV1enLRWUY7IxQLukJX+pZo/sOUIj38PVvHOYB0Y5AtiCZ/8frhn7Nw2aEo1vwu7B OLsixJ4H0ExEstvr+rDV7Alc+MqN1v8= Subject: Re: [PATCH XENSTORE v1 10/10] xs: add error handling To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-11-nmanthey@amazon.de> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <2e8a0983-c6dd-e016-b4e8-c49795c0084c@suse.com> Date: Tue, 2 Mar 2021 06:11:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226144144.9252-11-nmanthey@amazon.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1kEzha21uE6D8HRzv4V6DOmcoBBcrMPPY" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1kEzha21uE6D8HRzv4V6DOmcoBBcrMPPY Content-Type: multipart/mixed; boundary="0lTuGIZDrhzQo6PK71BUGoKMbSIqJulhi"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth Message-ID: <2e8a0983-c6dd-e016-b4e8-c49795c0084c@suse.com> Subject: Re: [PATCH XENSTORE v1 10/10] xs: add error handling References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-11-nmanthey@amazon.de> In-Reply-To: <20210226144144.9252-11-nmanthey@amazon.de> --0lTuGIZDrhzQo6PK71BUGoKMbSIqJulhi Content-Type: multipart/mixed; boundary="------------B140342196A812B5A086D90C" Content-Language: en-US This is a multi-part message in MIME format. --------------B140342196A812B5A086D90C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 26.02.21 15:41, Norbert Manthey wrote: > In case of a failure deep in the call tree, we might return NULL as the= > value of the domain. In that case, error out instead of dereferencing > the NULL pointer. >=20 > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. >=20 > Signed-off-by: Norbert Manthey > Reviewed-by: Julien Grall > Reviewed-by: Raphael Ning Reviewed-by: Juergen Gross Juergen --------------B140342196A812B5A086D90C Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------B140342196A812B5A086D90C-- --0lTuGIZDrhzQo6PK71BUGoKMbSIqJulhi-- --1kEzha21uE6D8HRzv4V6DOmcoBBcrMPPY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA9yQYFAwAAAAAACgkQsN6d1ii/Ey8r kQgAlYvrtiKZXr1qZ6M+CzGNa1ukKXsyJNbEbYRW+EZa95yCe8toJDB4EXeO9ssdP4lJHqCPus3i PaGSYr/PUQLA5uGv5JQFvR+A+qNLQkFyqt8t3l8WqlqukOrKoWb9TvIYmjjiYO1H3mM6PxKQMDx6 55wq1thHD/E16FWyRT2P0OOOpJEqfwMTS4E8OEPJV4CHrVVrumv8n7SWwQqPx4hG5ZmEt7ig4P7x htLxSz8YVfj5aSpkN5xorOwO5wGoUNKUcVtBwcuI48F3NXCtoVuNa9zWdLZoxUsfLUW80wI7xwmo +4GWmLeqAKnojM+QTRarOBVvQej9xK1XeHNpBXYlGA== =Luh3 -----END PGP SIGNATURE----- --1kEzha21uE6D8HRzv4V6DOmcoBBcrMPPY-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 05:15:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 05:15:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92087.173810 (Exim 4.92) (envelope-from ) id 1lGxNa-0002Uo-Pf; Tue, 02 Mar 2021 05:15:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92087.173810; Tue, 02 Mar 2021 05:15:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxNa-0002Uh-Mb; Tue, 02 Mar 2021 05:15:30 +0000 Received: by outflank-mailman (input) for mailman id 92087; Tue, 02 Mar 2021 05:15:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGxNZ-0002Uc-6j for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 05:15:29 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7e434e1f-7586-48fc-a9c6-615da07a2748; Tue, 02 Mar 2021 05:15:28 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 453BAAAC5; Tue, 2 Mar 2021 05:15:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e434e1f-7586-48fc-a9c6-615da07a2748 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614662127; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P1HJmEBLe02gdILdBiKZ8//oVn+6DgIMWtesj9tNA4w=; b=Yca6tVZzhzmzIyDu/Q/7LIx39sG66Y+vlKZsWF4k8qAnMJKSPAUx5r5rOssijX29q5U/uH 1tNkK8H29W/ljVVGvtw+3fEfSPHOMNc82T0rP6dIt+QPUdlMEah3ylVX2chnnagI01FJsw hfBw4PlkkFOG75fnfAu9j6novWnTKF0= Subject: Re: [PATCH XENSTORE v1 06/10] xenstored: handle port reads correctly To: Andrew Cooper , Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-7-nmanthey@amazon.de> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Tue, 2 Mar 2021 06:15:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NFF5TYVYjkXxGTm1P7LrRVHjTR0sLkBga" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NFF5TYVYjkXxGTm1P7LrRVHjTR0sLkBga Content-Type: multipart/mixed; boundary="5windFdbY919aeLwnnvFDDlYv8vQI5ROv"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Andrew Cooper , Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth Message-ID: Subject: Re: [PATCH XENSTORE v1 06/10] xenstored: handle port reads correctly References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-7-nmanthey@amazon.de> In-Reply-To: --5windFdbY919aeLwnnvFDDlYv8vQI5ROv Content-Type: multipart/mixed; boundary="------------A427817A38666E490C6069FB" Content-Language: en-US This is a multi-part message in MIME format. --------------A427817A38666E490C6069FB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 26.02.21 16:36, Andrew Cooper wrote: > On 26/02/2021 14:41, Norbert Manthey wrote: >> The read value could be larger than a signed 32bit integer. As -1 is >> used as error value, we should not rely on using the full 32 bits. >> Hence, when reading the port number, we should make sure we only retur= n >> valid values. >> >> This change sanity checks the input. >> The issue is that the value for the port is >> 1. transmitted as a string, with a fixed amount of digits. >> 2. Next, this string is parsed by a function that can deal with stri= ngs >> representing 64bit integers >> 3. A 64bit integer is returned, and will be truncated to it's lower >> 32bits, resulting in a wrong port number (in case the sender of t= he >> string decides to craft a suitable 64bit value). >> >> The value is typically provided by the kernel, which has this value ha= rd >> coded in the proper range. As we use the function strtoul, non-digit >> character are considered as end of the input, and hence do not require= >> checking. Therefore, this change only covers the corner case to make >> sure we stay in the 32 bit range. >> >> This bug was discovered and resolved using Coverity Static Analysis >> Security Testing (SAST) by Synopsys, Inc. >> >> Signed-off-by: Norbert Manthey >> Reviewed-by: Thomas Friebel >> Reviewed-by: Julien Grall >=20 > Port numbers are currently limited at 2^17, with easy extension to 2^29= > (iirc), but the entire event channel infrastructure would have to > undergo another redesign to get beyond that. >=20 > I think we can reasonably make an ABI statement saying that a port > number will never exceed 2^31.=C2=A0 This is already pseudo-encoded in = the > evtchn_port_or_error_t mouthful. I agree. There is no need for this patch. Juergen --------------A427817A38666E490C6069FB Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------A427817A38666E490C6069FB-- --5windFdbY919aeLwnnvFDDlYv8vQI5ROv-- --NFF5TYVYjkXxGTm1P7LrRVHjTR0sLkBga Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA9ye4FAwAAAAAACgkQsN6d1ii/Ey9H qQf/b+gKtN2eeSBenccE1vlTHjfoLUQ/PePp8lHGU5LA3X4QP5mT0vp9a3/qBWzhV/1LlhE50q8m 55LSdPuqGJ4wbRdu14M3FHrhHdZ/NE2Zi+dxBkawb8FAkzO29Cchi+4+FqaufVzZR8ZuHpz8jkfG +UijdMXvfCW/hceJYes3y+nO5+eqS2ymXCuVC4vz1Zsh2ewhb3ZTuRyAoQPzc4yYbgUF63pD9E8Y rajE4yfyDyBnGM5ecFC5GZeOLvPgB6mNAu5GL2e7AfHFsoB4kYrCbHl0Nz4daSCfFicqEGOqzm/g mOdCkcGR66niJHP+XSoHn06x3NHHHqcdCmvZQfiiag== =5aEa -----END PGP SIGNATURE----- --NFF5TYVYjkXxGTm1P7LrRVHjTR0sLkBga-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 06:02:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 06:02:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92105.173849 (Exim 4.92) (envelope-from ) id 1lGy6r-0007lR-OX; Tue, 02 Mar 2021 06:02:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92105.173849; Tue, 02 Mar 2021 06:02:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGy6r-0007lJ-LQ; Tue, 02 Mar 2021 06:02:17 +0000 Received: by outflank-mailman (input) for mailman id 92105; Tue, 02 Mar 2021 06:02:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGy6q-0007lA-Vr; Tue, 02 Mar 2021 06:02:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGy6q-0005zA-K9; Tue, 02 Mar 2021 06:02:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGy6q-0000zI-83; Tue, 02 Mar 2021 06:02:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lGy6q-0005am-7I; Tue, 02 Mar 2021 06:02:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2OsuWJl1JLHZxRU4hlnw2Dfxd000JtztF+Rks/H/u64=; b=cTPZ9g0JQVUjQXdYLPIHhYCG6J PVPf8RMnio+v+pPW9x5ruXO5NqeZfF1/vLR/FSQkeoRXpzHJtLxAkOeysGvS8uV4Hquri3oxyAAsq tZBtN6j/8O2ea5u+hnbt1FxegUrLdouRsdLODpLS2cLj1cS0IP3pCUwzRwdn7Yhiv3MY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159795: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=77d7b3540c12b9bebba67dca8eb2d939d9e8b5df X-Osstest-Versions-That: xen=c4441ab1f1d506a942002ccc55fdde2fe30ef626 From: osstest service owner Date: Tue, 02 Mar 2021 06:02:16 +0000 flight 159795 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/159795/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159788 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159788 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159788 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159788 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159788 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159788 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159788 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159788 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159788 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159788 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159788 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 77d7b3540c12b9bebba67dca8eb2d939d9e8b5df baseline version: xen c4441ab1f1d506a942002ccc55fdde2fe30ef626 Last test of basis 159788 2021-03-01 01:51:22 Z 1 days Testing same since 159795 2021-03-01 18:36:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ian Jackson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c4441ab1f1..77d7b3540c 77d7b3540c12b9bebba67dca8eb2d939d9e8b5df -> master From xen-devel-bounces@lists.xenproject.org Tue Mar 02 07:34:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 07:34:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92157.173882 (Exim 4.92) (envelope-from ) id 1lGzYC-00009A-4J; Tue, 02 Mar 2021 07:34:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92157.173882; Tue, 02 Mar 2021 07:34:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGzYB-000093-WC; Tue, 02 Mar 2021 07:34:36 +0000 Received: by outflank-mailman (input) for mailman id 92157; Tue, 02 Mar 2021 07:34:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGzY9-00008v-VP; Tue, 02 Mar 2021 07:34:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGzY9-0007Ug-Nv; Tue, 02 Mar 2021 07:34:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGzY9-0006BS-G4; Tue, 02 Mar 2021 07:34:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lGzY9-0003rP-FT; Tue, 02 Mar 2021 07:34:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=T2H1dmsUHJK23J5Rb5IKLob9o1UDA6yVoP/HXJAw5VI=; b=XD5Yi8k6Sn6BK3GgfwAXkBpuNn IDnbTpKjz11OEX7bpkkVcF0ofLFsBJ7z9Eimp/jcbrlADfGcVjweN9WZ6lBEAsfCKZAI/yfU3VPRW Z4E8QMX7I6kEhs3Bk4QC+cw2/+RFjvRJ433WxIM9j1PmHbQ1kDGPR4ncfh2imIiroyS8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 159799: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=78879650e4aa177d3069e2c2cc28ed98009243c1 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 02 Mar 2021 07:34:33 +0000 flight 159799 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/159799/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 78879650e4aa177d3069e2c2cc28ed98009243c1 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 235 days Failing since 151818 2020-07-11 04:18:52 Z 234 days 227 attempts Testing same since 159799 2021-03-02 04:19:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 44726 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 02 07:48:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 07:48:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92163.173897 (Exim 4.92) (envelope-from ) id 1lGzlu-0001HZ-Ea; Tue, 02 Mar 2021 07:48:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92163.173897; Tue, 02 Mar 2021 07:48:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGzlu-0001HS-Ay; Tue, 02 Mar 2021 07:48:46 +0000 Received: by outflank-mailman (input) for mailman id 92163; Tue, 02 Mar 2021 07:48:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lGzls-0001HN-O2 for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 07:48:44 +0000 Received: from smtp-fw-6001.amazon.com (unknown [52.95.48.154]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 83103da2-0679-4a27-afef-ef31bdb0fea2; Tue, 02 Mar 2021 07:48:43 +0000 (UTC) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2a-6e2fc477.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP; 02 Mar 2021 07:48:37 +0000 Received: from EX13D02EUB001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2a-6e2fc477.us-west-2.amazon.com (Postfix) with ESMTPS id AF490A15CA; Tue, 2 Mar 2021 07:48:35 +0000 (UTC) Received: from u6fc700a6f3c650.ant.amazon.com (10.43.161.146) by EX13D02EUB001.ant.amazon.com (10.43.166.150) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 2 Mar 2021 07:48:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 83103da2-0679-4a27-afef-ef31bdb0fea2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1614671324; x=1646207324; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=BWwsoGlcNWU1zQsTfXX3ZgSgdwgW2SF2KC6gbDfIXfY=; b=GyaiTnSzdKd+R5q7y3LXeTmDIgJECr8hEzU3Nk98qjxWBRWRL2QrQ5MF z6DI73B4A9kanXEnkSAoy3hY/wL6ucGXiXo4oEckhPFbExbGFxRVTt5Zu qiCjU/cawijGBopyM0wFx6DPUaLQwdofQBBUNSnJAv80+HtHtQhd3bx0H 0=; X-IronPort-AV: E=Sophos;i="5.81,216,1610409600"; d="scan'208";a="94286766" Subject: Re: [PATCH XENSTORE v1 06/10] xenstored: handle port reads correctly To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Andrew Cooper , CC: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-7-nmanthey@amazon.de> From: Norbert Manthey Autocrypt: addr=nmanthey@amazon.de; prefer-encrypt=mutual; keydata= xsFNBFoJQc0BEADM8Z7hB7AnW6ErbSMsYkKh4HLAPfoM+wt7Fd7axHurcOgFJEBOY2gz0isR /EDiGxYyTgxt5PZHJIfra0OqXRbWuLltbjhJACbu35eaAo8UM4/awgtYx3O1UCbIlvHGsYDg kXjF8bBrVjPu0+g55XizX6ot/YPAgmWTdH8qXoLYVZVWJilKlTqpYEVvarSn/BVgCbIsQIps K93sOTN9eJKDSqHvbkgKl9XG3WsZ703431egIpIZpfN0zZtzumdZONb7LiodcFHJ717vvd89 3Hv2bYv8QLSfYsZcSnyU0NVzbPhb1WtaduwXwNmnX1qHJuExzr8EnRT1pyhVSqouxt+xkKbV QD9r+cWLChumg3g9bDLzyrOTlEfAUNxIqbzSt03CRR43dWgfgGiLDcrqC2b1QR886WDpz4ok xX3fdLaqN492s/3c59qCGNG30ebAj8AbV+v551rsfEba+IWTvvoQnbstc6vKJCc2uG8rom5o eHG/bP1Ug2ht6m/0uWRyFq9C27fpU9+FDhb0ZsT4UwOCbthe35/wBZUg72zDpT/h5lm64G6C 0TRqYRgYcltlP705BJafsymmAXOZ1nTCuXnYAB9G9LzZcKKq5q0rP0kp7KRDbniirCUfp7jK VpPCOUEc3tS1RdCCSeWNuVgzLnJdR8W2h9StuEbb7hW4aFhwRQARAQABzSROb3JiZXJ0IE1h bnRoZXkgPG5tYW50aGV5QGFtYXpvbi5kZT7CwX0EEwEIACcFAloJQc0CGyMFCQlmAYAFCwkI BwIGFQgJCgsCBBYCAwECHgECF4AACgkQZ+8yS8zN62ajmQ/6AlChoY5UlnUaH/jgcabyAfUC XayHgCcpL1SoMKvc2rCA8PF0fza3Ep2Sw0idLqC/LyAYbI6gMYavSZsLcsvY6KYAZKeaEriG 7R6cSdrbmRcKpPjwvv4iY6G0DBTeaqfNjGe1ECY8u522LprDQVquysJIf3YaEyxoK/cLSb0c kjzpqI1P9Vh+8BQb5H9gWpakbhFIwbRGHdAF1roT7tezmEshFS0IURJ2ZFEI+ZgWgtl1MBwN sBt65im7x5gDo25h8A5xC9gLXTc4j3tk+3huaZjUJ9mCbtI12djVtspjNvDyUPQ5Mxw2Jwar C3/ZC+Nkb+VlymmErpnEUZNltcq8gsdYND4TlNbZ2JhD0ibiYFQPkyuCVUiVtimXfh6po9Yt OkE0DIgEngxMYfTTx01Zf6iwrbi49eHd/eQQw3zG5nn+yZsEG8UcP1SCrUma8p93KiKOedoL n43kTg4RscdZMjj4v6JkISBcGTR4uotMYP4M0zwjklnFXPmrZ6/E5huzUpH9B7ZIe/SUu8Ur xww/4dN6rfqbNzMxmya8VGlEQZgUMWcck+cPrRLB09ZOk4zq9i/yaHDEZA1HNOfQ9UCevXV5 7seXSX7PCY6WDAdsT3+FuaoQ7UoWN3rdpb+064QKZ0FsHeGzUd7MZtlgU4EKrh25mTSNZYRs nTz2zT/J33fOwU0EWglBzQEQAKioD1gSELj3Y47NE11oPkzWWdxKZdVr8B8VMu6nVAAGFRSf Dms4ZmwGY27skMmOH2srnZyTfm9FaTKr8RI+71Fh9nfB9PMmwzA7OIY9nD73/HqPywzTTleG MlALmnuY6xFRSDmqmvxDHgWyzB4TgPWt8+hW3+TJKCx2RgLAdSuULZla4lia+NlS8WNRUDGK sFJCCB3BW5I/cocfpBEUqLbbmnPuD9UKpEnFcYWD9YaDNcBTjSc7iDsvtpdrBXg5VETOz/TQ /CmVs9h/5zug8O4bXxHEEJpCAxs4cGKxowBqx/XJfkwdWeo/LdaeR+LRbXvq4A32HSkyj9sV vygwt2OFEk493JGik8qtAA/oPvuqVPJGacxmZ7zKR12c0mnKCHiexFJzFbC7MSiUhhe8nNiM p6Sl6EZmsTUXhV2bd2M12Bqcss3TTJ1AcW04T4HYHVCSxwl0dVfcf3TIaH0BSPiwFxz0FjMk 10umoRvUhYYoYpPFCz8dujXBlfB8q2tnHltEfoi/EIptt1BMNzTYkHKArj8Fwjf6K+nQ3a8p 1cWfkYpA5bRqbhbplzpa0u1Ex0hZk6pka0qcVgqmH31O2OcSsqeKfUfHkzj3Q6dmuwm1je/f HWH9N1gDPEp1RB5bIxPnOG1Z4SNl9oVQJhc4qoJiqbvkciivYcH7u2CBkboFABEBAAHCwWUE GAEIAA8FAloJQc0CGwwFCQlmAYAACgkQZ+8yS8zN62YU9Q//WTnN28aBX1EhDidVho80Ql2b tV1cDRh/vWTcM4qoM8vzW4+F/Ive6wDVAJ7zwAv8F8WPzy+acxtHLkyYk14M6VZ1eSy0kV0+ RZQdQ+nPtlb1MoDKw2N5zhvs8A+WD8xjDIA9i21hQ/BNILUBINuYKyR19448/41szmYIEhuJ R2fHoLzNdXNKWQnN3/NPTuvpjcrkXKJm2k32qfiys9KBcZX8/GpuMCc9hMuymzOr+YlXo4z4 1xarEJoPOQOXnrmxN4Y30/qmf70KHLZ0GQccIm/o/XSOvNGluaYv0ZVJXHoCnYvTbi0eYvz5 OfOcndqLOfboq9kVHC6Yye1DLNGjIVoShJGSsphxOx2ryGjHwhzqDrLiRkV82gh6dUHKxBWd DXfirT8a4Gz/tY9PMxan67aSxQ5ONpXe7g7FrfrAMe91XRTf50G3rHb8+AqZfxZJFrBn+06i p1cthq7rJSlYCqna2FedTUT+tK1hU9O0aK4ZYYcRzuTRxjd4gKAWDzJ1F/MQ12ftrfCAvs7U sVbXv2TndGIleMnheYv1pIrXEm0+sdz5v91l2/TmvkyyWT8s2ksuZis9luh+OubeLxHq090C hfavI9WxhitfYVsfo2kr3EotGG1MnW+cOkCIX68w+3ZS4nixZyJ/TBa7RcTDNr+gjbiGMtd9 pEddsOqYwOs= Message-ID: <8e7c8953-f75a-36d2-e853-de4f88fbe01c@amazon.de> Date: Tue, 2 Mar 2021 08:48:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US X-Originating-IP: [10.43.161.146] X-ClientProxiedBy: EX13D19UWA003.ant.amazon.com (10.43.160.170) To EX13D02EUB001.ant.amazon.com (10.43.166.150) Precedence: Bulk Content-Transfer-Encoding: base64 T24gMy8yLzIxIDY6MTUgQU0sIErDvHJnZW4gR3Jvw58gd3JvdGU6Cj4gT24gMjYuMDIuMjEgMTY6 MzYsIEFuZHJldyBDb29wZXIgd3JvdGU6Cj4+IE9uIDI2LzAyLzIwMjEgMTQ6NDEsIE5vcmJlcnQg TWFudGhleSB3cm90ZToKPj4+IFRoZSByZWFkIHZhbHVlIGNvdWxkIGJlIGxhcmdlciB0aGFuIGEg c2lnbmVkIDMyYml0IGludGVnZXIuIEFzIC0xIGlzCj4+PiB1c2VkIGFzIGVycm9yIHZhbHVlLCB3 ZSBzaG91bGQgbm90IHJlbHkgb24gdXNpbmcgdGhlIGZ1bGwgMzIgYml0cy4KPj4+IEhlbmNlLCB3 aGVuIHJlYWRpbmcgdGhlIHBvcnQgbnVtYmVyLCB3ZSBzaG91bGQgbWFrZSBzdXJlIHdlIG9ubHkg cmV0dXJuCj4+PiB2YWxpZCB2YWx1ZXMuCj4+Pgo+Pj4gVGhpcyBjaGFuZ2Ugc2FuaXR5IGNoZWNr cyB0aGUgaW5wdXQuCj4+PiBUaGUgaXNzdWUgaXMgdGhhdCB0aGUgdmFsdWUgZm9yIHRoZSBwb3J0 IGlzCj4+PiDCoCAxLiB0cmFuc21pdHRlZCBhcyBhIHN0cmluZywgd2l0aCBhIGZpeGVkIGFtb3Vu dCBvZiBkaWdpdHMuCj4+PiDCoCAyLiBOZXh0LCB0aGlzIHN0cmluZyBpcyBwYXJzZWQgYnkgYSBm dW5jdGlvbiB0aGF0IGNhbiBkZWFsIHdpdGgKPj4+IHN0cmluZ3MKPj4+IMKgwqDCoMKgIHJlcHJl c2VudGluZyA2NGJpdCBpbnRlZ2Vycwo+Pj4gwqAgMy4gQSA2NGJpdCBpbnRlZ2VyIGlzIHJldHVy bmVkLCBhbmQgd2lsbCBiZSB0cnVuY2F0ZWQgdG8gaXQncyBsb3dlcgo+Pj4gwqDCoMKgwqAgMzJi aXRzLCByZXN1bHRpbmcgaW4gYSB3cm9uZyBwb3J0IG51bWJlciAoaW4gY2FzZSB0aGUgc2VuZGVy IG9mCj4+PiB0aGUKPj4+IMKgwqDCoMKgIHN0cmluZyBkZWNpZGVzIHRvIGNyYWZ0IGEgc3VpdGFi bGUgNjRiaXQgdmFsdWUpLgo+Pj4KPj4+IFRoZSB2YWx1ZSBpcyB0eXBpY2FsbHkgcHJvdmlkZWQg YnkgdGhlIGtlcm5lbCwgd2hpY2ggaGFzIHRoaXMgdmFsdWUKPj4+IGhhcmQKPj4+IGNvZGVkIGlu IHRoZSBwcm9wZXIgcmFuZ2UuIEFzIHdlIHVzZSB0aGUgZnVuY3Rpb24gc3RydG91bCwgbm9uLWRp Z2l0Cj4+PiBjaGFyYWN0ZXIgYXJlIGNvbnNpZGVyZWQgYXMgZW5kIG9mIHRoZSBpbnB1dCwgYW5k IGhlbmNlIGRvIG5vdCByZXF1aXJlCj4+PiBjaGVja2luZy4gVGhlcmVmb3JlLCB0aGlzIGNoYW5n ZSBvbmx5IGNvdmVycyB0aGUgY29ybmVyIGNhc2UgdG8gbWFrZQo+Pj4gc3VyZSB3ZSBzdGF5IGlu IHRoZSAzMiBiaXQgcmFuZ2UuCj4+Pgo+Pj4gVGhpcyBidWcgd2FzIGRpc2NvdmVyZWQgYW5kIHJl c29sdmVkIHVzaW5nIENvdmVyaXR5IFN0YXRpYyBBbmFseXNpcwo+Pj4gU2VjdXJpdHkgVGVzdGlu ZyAoU0FTVCkgYnkgU3lub3BzeXMsIEluYy4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBOb3JiZXJ0 IE1hbnRoZXkgPG5tYW50aGV5QGFtYXpvbi5kZT4KPj4+IFJldmlld2VkLWJ5OiBUaG9tYXMgRnJp ZWJlbCA8ZnJpZWJlbHRAYW1hem9uLmRlPgo+Pj4gUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jby51az4KPj4KPj4gUG9ydCBudW1iZXJzIGFyZSBjdXJyZW50bHkgbGlt aXRlZCBhdCAyXjE3LCB3aXRoIGVhc3kgZXh0ZW5zaW9uIHRvIDJeMjkKPj4gKGlpcmMpLCBidXQg dGhlIGVudGlyZSBldmVudCBjaGFubmVsIGluZnJhc3RydWN0dXJlIHdvdWxkIGhhdmUgdG8KPj4g dW5kZXJnbyBhbm90aGVyIHJlZGVzaWduIHRvIGdldCBiZXlvbmQgdGhhdC4KPj4KPj4gSSB0aGlu ayB3ZSBjYW4gcmVhc29uYWJseSBtYWtlIGFuIEFCSSBzdGF0ZW1lbnQgc2F5aW5nIHRoYXQgYSBw b3J0Cj4+IG51bWJlciB3aWxsIG5ldmVyIGV4Y2VlZCAyXjMxLsKgIFRoaXMgaXMgYWxyZWFkeSBw c2V1ZG8tZW5jb2RlZCBpbiB0aGUKPj4gZXZ0Y2huX3BvcnRfb3JfZXJyb3JfdCBtb3V0aGZ1bC4K Pgo+IEkgYWdyZWUuIFRoZXJlIGlzIG5vIG5lZWQgZm9yIHRoaXMgcGF0Y2guCgpJIHVuZGVyc3Rh bmQsIGFuZCBhbSBmaW5lIHdpdGggZHJvcHBpbmcgdGhpcyBwYXRjaC4KCk91dCBvZiBjdXJpb3Np dHksIGlmIHRoZSBhY3R1YWwgbGltaXQgaXMgbG93ZXIgdGhhbiB3aGF0IHRoZSBwYXRjaApjdXJy ZW50bHkgZW5mb3JjZXMsIHdvdWxkIGl0IG1ha2Ugc2Vuc2UgdG8gYWRhcHQgdGhlIGJvdW5kIGNo ZWNrIHRvIHRoYXQKbnVtYmVyPwoKQmVzdCwKTm9yYmVydAoKPgo+Cj4gSnVlcmdlbgo+CgoKCgpB bWF6b24gRGV2ZWxvcG1lbnQgQ2VudGVyIEdlcm1hbnkgR21iSApLcmF1c2Vuc3RyLiAzOAoxMDEx NyBCZXJsaW4KR2VzY2hhZWZ0c2Z1ZWhydW5nOiBDaHJpc3RpYW4gU2NobGFlZ2VyLCBKb25hdGhh biBXZWlzcwpFaW5nZXRyYWdlbiBhbSBBbXRzZ2VyaWNodCBDaGFybG90dGVuYnVyZyB1bnRlciBI UkIgMTQ5MTczIEIKU2l0ejogQmVybGluClVzdC1JRDogREUgMjg5IDIzNyA4NzkKCgo= From xen-devel-bounces@lists.xenproject.org Tue Mar 02 08:12:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 08:12:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92174.173908 (Exim 4.92) (envelope-from ) id 1lH08V-0004kW-Kk; Tue, 02 Mar 2021 08:12:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92174.173908; Tue, 02 Mar 2021 08:12:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH08V-0004kP-Ha; Tue, 02 Mar 2021 08:12:07 +0000 Received: by outflank-mailman (input) for mailman id 92174; Tue, 02 Mar 2021 08:12:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH08T-0004kK-Sw for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 08:12:05 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 782b3db3-c6c3-473f-a1f1-3037a77be25d; Tue, 02 Mar 2021 08:12:04 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8FC7EAE47; Tue, 2 Mar 2021 08:12:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 782b3db3-c6c3-473f-a1f1-3037a77be25d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614672723; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1hJRPiybZjyv+cnRIG11H1nxfrg8yfGJ2OEZU2mIilc=; b=LkaU7mXXv7+EEj+nsxRt9VfohXtfbfQ7cONuuqMJm+f48iO5hlHTivi0ZKKkfF0uSGKtry tRHHZWAxVc9ODfeiucJ2qctX0SNMyctRqctOB+oswCFi8BOS/8lJun+hhuG8DO8LlnzyDV tuX5KtJhDZXN4hLZzG73lZf2V+Q/Tj4= Subject: Re: [PATCH XENSTORE v1 06/10] xenstored: handle port reads correctly To: Norbert Manthey , Andrew Cooper , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-7-nmanthey@amazon.de> <8e7c8953-f75a-36d2-e853-de4f88fbe01c@amazon.de> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Tue, 2 Mar 2021 09:12:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <8e7c8953-f75a-36d2-e853-de4f88fbe01c@amazon.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9mN57cvgJJG0rwQo0fcFDPO0ODV69PeCu" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9mN57cvgJJG0rwQo0fcFDPO0ODV69PeCu Content-Type: multipart/mixed; boundary="6XNgxB1aKluftOJxsE1fMoV2nlSqBRla3"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Norbert Manthey , Andrew Cooper , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall , Michael Kurth Message-ID: Subject: Re: [PATCH XENSTORE v1 06/10] xenstored: handle port reads correctly References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-7-nmanthey@amazon.de> <8e7c8953-f75a-36d2-e853-de4f88fbe01c@amazon.de> In-Reply-To: <8e7c8953-f75a-36d2-e853-de4f88fbe01c@amazon.de> --6XNgxB1aKluftOJxsE1fMoV2nlSqBRla3 Content-Type: multipart/mixed; boundary="------------1EF74A65DE5E9FC51CF28778" Content-Language: en-US This is a multi-part message in MIME format. --------------1EF74A65DE5E9FC51CF28778 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 02.03.21 08:48, Norbert Manthey wrote: > On 3/2/21 6:15 AM, J=C3=BCrgen Gro=C3=9F wrote: >> On 26.02.21 16:36, Andrew Cooper wrote: >>> On 26/02/2021 14:41, Norbert Manthey wrote: >>>> The read value could be larger than a signed 32bit integer. As -1 is= >>>> used as error value, we should not rely on using the full 32 bits. >>>> Hence, when reading the port number, we should make sure we only ret= urn >>>> valid values. >>>> >>>> This change sanity checks the input. >>>> The issue is that the value for the port is >>>> =C2=A0 1. transmitted as a string, with a fixed amount of digits. >>>> =C2=A0 2. Next, this string is parsed by a function that can deal w= ith >>>> strings >>>> =C2=A0=C2=A0=C2=A0=C2=A0 representing 64bit integers >>>> =C2=A0 3. A 64bit integer is returned, and will be truncated to it'= s lower >>>> =C2=A0=C2=A0=C2=A0=C2=A0 32bits, resulting in a wrong port number (= in case the sender of >>>> the >>>> =C2=A0=C2=A0=C2=A0=C2=A0 string decides to craft a suitable 64bit v= alue). >>>> >>>> The value is typically provided by the kernel, which has this value >>>> hard >>>> coded in the proper range. As we use the function strtoul, non-digit= >>>> character are considered as end of the input, and hence do not requi= re >>>> checking. Therefore, this change only covers the corner case to make= >>>> sure we stay in the 32 bit range. >>>> >>>> This bug was discovered and resolved using Coverity Static Analysis >>>> Security Testing (SAST) by Synopsys, Inc. >>>> >>>> Signed-off-by: Norbert Manthey >>>> Reviewed-by: Thomas Friebel >>>> Reviewed-by: Julien Grall >>> >>> Port numbers are currently limited at 2^17, with easy extension to 2^= 29 >>> (iirc), but the entire event channel infrastructure would have to >>> undergo another redesign to get beyond that. >>> >>> I think we can reasonably make an ABI statement saying that a port >>> number will never exceed 2^31.=C2=A0 This is already pseudo-encoded i= n the >>> evtchn_port_or_error_t mouthful. >> >> I agree. There is no need for this patch. >=20 > I understand, and am fine with dropping this patch. >=20 > Out of curiosity, if the actual limit is lower than what the patch > currently enforces, would it make sense to adapt the bound check to tha= t > number? No, I don't think so. Especially as the boundary to check against isn't known by Xenstore (the boundary value depends on 2-level or fifo events being used, and this information is not exported to user land). The value is coming from the kernel, and it is used with another kernel interface. So if the kernel wants to play dirty tricks with Xenstore, it doesn't need to deliver a wrong event channel number, it can just play those games in the event channel driver. Juergen --------------1EF74A65DE5E9FC51CF28778 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------1EF74A65DE5E9FC51CF28778-- --6XNgxB1aKluftOJxsE1fMoV2nlSqBRla3-- --9mN57cvgJJG0rwQo0fcFDPO0ODV69PeCu Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA981IFAwAAAAAACgkQsN6d1ii/Ey+g Twf/Suxp9D3b9/rvurbTPJ3SFtWXrgIyyf5v8Eplh8O6zMoBztCFQL39gkM8rulbz8zXDUSSkNnt 6+ka1Md2ClcBwDX1BKdLhguPwQ8KQY8YMjUxZ+5HYOBq18XW1KNBzGQVS9CiIt2lMeE53AUOrG0i VhIdTAVexmYaBbGRRB+L4+fKsNOeRCpbQRQxc5y8MYqbGsmKWYHMTwJuSkRQcxQj1mZnj4R6qgUv hoxfWOaudK96rSNAAotW+3xTXVhX+c93KZ7rMTUa0AZze2hNmxCwtcxHZzyXXmCCGPBDVVnAHGKU q64HjIAVuOdqN7/6ws8QX/iOzA44yc2WAw/7apAQZA== =5bcJ -----END PGP SIGNATURE----- --9mN57cvgJJG0rwQo0fcFDPO0ODV69PeCu-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 08:14:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 08:14:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92177.173920 (Exim 4.92) (envelope-from ) id 1lH0BG-0004t5-8P; Tue, 02 Mar 2021 08:14:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92177.173920; Tue, 02 Mar 2021 08:14:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH0BG-0004sy-5N; Tue, 02 Mar 2021 08:14:58 +0000 Received: by outflank-mailman (input) for mailman id 92177; Tue, 02 Mar 2021 08:14:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH0BF-0004st-7F for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 08:14:57 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0318466f-0369-4cbc-b8c0-9cd3dd555162; Tue, 02 Mar 2021 08:14:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0318466f-0369-4cbc-b8c0-9cd3dd555162 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614672896; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=tBpvr+jtOURdNRVLQ+jynUJ2gNvQ6OrYPr243Nziiwk=; b=ZFp4O9q8AM7xdnE1yZJ0g0ApDdnK/+tBXnwP2sDTT0EQl243jeVu31Hb zV9kXUQ2vXLyWQK7Fv5yFJ0Ao+CvpAO13LdAAzYWXBpWnTnAkTrDdOiSC /Br5KsY3Zbz73ydDupyrBp4v05MiwxLTPEu9yE21o29WzoDJEvWWt8BQG 0=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Rk29h0pua5VNOheRRIUYNdeoS8Q1YOsOaWCgIsTUkUUH64q+NjaPXNg8PWoNquvIjc3MSDLCf/ 4CewCH7VKVSR65vHjGi5KPsvsZnb/g+qyFLtij6Wmw9zvOiLs1mkD6W+MfkYEU/Y9+Sp0hDVHI xhsti+6t6lowO14OMlH2I9xCbTAroDFc+T8R99OMZvgS9xne0mpetnJDzaZYDeovLGEP7Q55+r +8OOgk2FnSCKVTL9QogScnNw0V20pGMPoi3dIRVTJJPYr4qLNlr4s35Rn7YqtgB1pmVJ6A9FLP HCU= X-SBRS: 5.2 X-MesageID: 39710801 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,216,1610427600"; d="scan'208";a="39710801" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V1sJELANcE07129bXmUM5fzyPp1GnV6pz99xGGXNggyOE3i5Dmhp+7kRWIM+m8HZdWx/n6wJNYbBBPIgFMzMvPc0ke0tEYs1e9U50TqRBA0ajTr4tjuOn1IFh5clqqlP5vtQ9J0RUzpe8vcwjQUyVyCS/p3ZB4g8XYJ2dGCgP4pRQlFgrenRPEDjOIipIBhFm3IUkYUK2B8Cr3wdw9/RH60U7vte+/fvQhjELlX5uIlPXphuvjo5wfSh2n1D9jGNQNte3V0yjwNYRZpcESRZiQEl51dwH3r6MxE6jSMRM0GrX73omHijGzDOjcnFVK4LadMXe6H/bozmPZlEKUofig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9mASKKHPaFRe5yQZgz7bVJnp0oWA64tl9OWZueHvhBo=; b=NjXLDXMzGedhxvAc+EVPPAJdgnmeo5LRgLz9QlrO2AxT0jgcCPHjkRlPVATYFVrr7i/+JzBVri97BgLk0lBrNVCpC8ow4N9G4NgKiAz/r+dunrrW9pPs3lXsB+mjXUXoebUwsZJZ/wQ/QQmaRUZM0R5HHZsBbehUurCAAXyGIg2/9gU8nT2H9uksmiaLWebGctbodRvCIkTXhemlwR1T/kvvJ27DXQ6N51w8kyjx0Xy75G7DZqlFGVfs+zBeJssAZOGOqa647zxhzHSA7xwRyQT/13w1o8+7KXmbZiQTCp1dWMZxt9HowpejsjfxwWS6NZA0N7IBcfAtW/RmpPEIiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9mASKKHPaFRe5yQZgz7bVJnp0oWA64tl9OWZueHvhBo=; b=v4A2hL/MnJDmrGKTmMOfF/331YROL3sQAVOMGfSIRDoFnZw3ClyFRfHYZ/6Ntlz3upe00gfLAApejp5Ljc+LeH1oQktmGcyUKqLzRNuTTWvKe9ftYBqVucdBuz5tx2ioYedCE0E6alqC3a4x7IJnp137oCNOtGYPrAaSjEIItP4= Date: Tue, 2 Mar 2021 09:14:44 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: , Doug Goldstein , Stefano Stabellini , Ian Jackson Subject: Re: [PATCH for-4.15] automation/alpine: add g++ to the list of build depends Message-ID: References: <20210301095806.68518-1-roger.pau@citrix.com> <27ec9db0-69bc-df9a-8511-109f57972046@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <27ec9db0-69bc-df9a-8511-109f57972046@citrix.com> X-ClientProxiedBy: MR2P264CA0119.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::35) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8b495ae4-6a59-45c6-58cb-08d8dd5340fe X-MS-TrafficTypeDiagnostic: DS7PR03MB5591: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xJf61a8WAXXJ/CcwNQjHZ06zaHopVfzrdfd/nXNmACaULQoprv17pF8QUh8NCKe2m9laHgyYMLJrkujTaASsf1tt6PS2BHAzGOJj0YwNKuPj9Pom3dtvf9G1stvhmv9OHprGLzn+BWTqoNN7OM9JPO3O8irkuYyeiQmXaXTQ4QI5LMPyzSx0Fjarid4CPEfG0wrMTd56mYX0kwMhRIDxoz7/LCHtSzyxBdXGf36KQJuyprVFTdf8jR2xrxs8lLmrk5tiZvuEsRmadQFpFVxGdyYrwV7lxn2qCOTmMDeZUS5k6e3u0TtCRQl6KMSAdwmdPZbAVxNZUabQwgPybRBBTwFpvFaqzrOBtc7CC899xJvlNbWWPxsPAJ7zykC+f0GYRD4JeO7Bj9hKpNBRxCaYl7lPOvtPmUw3H1iwfhcmTDBSTMv9+r+Ro2XpP4dvE0wvIATZmkcBfPRrMVgq4jBpCNQaGnWJ2Kv7uMNl+rx6qQJzCuHbaNkuV06Q69psjflYoDDGhkRJwSc3LmIjtXPyQA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(376002)(396003)(39860400002)(136003)(346002)(86362001)(8676002)(9686003)(83380400001)(2906002)(6862004)(956004)(33716001)(26005)(4326008)(186003)(6486002)(6666004)(16526019)(66946007)(66556008)(66476007)(6636002)(316002)(53546011)(54906003)(478600001)(8936002)(6496006)(85182001)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dnMzblFGU0NPc1o2ejM3QUQzc1VPZ21oQVVGMWg0RHphbHJEcldYR3ZFZkFv?= =?utf-8?B?MXk1eTRIRDhBMDl6Tmp3aTYzdjZoVWdOeklFZUFGR1FDcCtTTGpOcEhpR2hm?= =?utf-8?B?WDh1b1RCTHFSK0llMlZaZmEyOW40bk0xZy9rZmpFQWNITzVIMDRMNFVYOEtv?= =?utf-8?B?dU9uajdoSTVXL2RMTjRHNEJGTHRmTWdGcVNRWVVWU0lLZzV3SzB4L2dwdkVv?= =?utf-8?B?STFCSEhnQUc0aUE3ZkxxT1BVUXhab3E4YlhHNHFaNjVCTFdYQVZvUHNIUURQ?= =?utf-8?B?V3RhVUFBc1BmdThta1lIUmtWNU1pUlFGVno0TU9ObVpKWjBKdFEwSkZFRFJa?= =?utf-8?B?T0Qwd2VNZ0ZQYXBiK3VEcUFMVmNnN2NUSUdsOGo0bW9HeWRyUTdiS2ROdTdr?= =?utf-8?B?RUpYaExsOWMwM3laMDBXTmZWVStYUjBVWkdJeFNvdTduT3p0QlVrY1Yvazho?= =?utf-8?B?NWRWSE5RTjhkVm9oYkF2QXN0RzR1VkowL3NXZWJGYk5kajVjMXBUcnlqU3ky?= =?utf-8?B?em9lMjUxS09Bam44WFNzZUQ4Qkc5U0ZvZzYraGJIVWtLV1RpU1dldTJUMmRx?= =?utf-8?B?NDd3VnljYXdtV2tsbzJhS1lTOWkzck9sbEhsVmVtL1RlYVlHQ0ZwTkE1K2FR?= =?utf-8?B?UHc3TTBLL3c4cUdLQmxVQytrZWVVT1BkaEpKRnRKV3pFOWVjK2N0Q1JjbWE1?= =?utf-8?B?SlNwcjlBaWM5djJuY3pRYVVhMEVwR2dhaWUrZFdvZEE3NC9CL0VoV2dXY1di?= =?utf-8?B?cUluR1RVZlJEOTJIbEZZaWRFTU5mZUxCaWlGNHEvdWxRK1JOZnFrZHBBUVE5?= =?utf-8?B?V0h5WndHQ3NCTkRkMlVHTjNvd2hOclo2S2xaZzBpKzNRclZtR0JoaGFLeldO?= =?utf-8?B?Y2RtaVlTMVl0Z3UwSHhJV29HR21CdDRPYkYzV3NwZWZKN3RjSlBZQ3NIWXJs?= =?utf-8?B?YlRVV3d5RWROYlhTL20vTThuNk8zT01RME5ET3prVXpibFRxMDAxMitQOEdn?= =?utf-8?B?aFNyL0EyNWs0dVRJdklNc2xQU093NGZtV2ZSSndQaTRMUnFCVStBWm5QVXR0?= =?utf-8?B?OVJUbC9Ja2VNSlpWSHdMbW5GVE1ZQkxZTkluLzFMTXMwK3M5MHdtWEVqTlBm?= =?utf-8?B?TDVNVEFQYXhUMktDOFZxZEVycHVNS2lBMEF5QVpJNVpIUEU5SGtKMjJaUlha?= =?utf-8?B?a3YvY3JtN3c4cklYMHBKMStzcEdvbXFpb1Q0cjJrMXZCNlpUTFpsejY3ZDV2?= =?utf-8?B?U2Y5eXI5ZldoVldWcEJSOWVxVUlOTmxZbjNLVnQ3UjN4K3ZJZGcra2NKeUI3?= =?utf-8?B?NVlnYnhXOERGd2dlYjN4ZjRIcXAxU1JmTHZodm5HSGt5SVNyTEhYYXo5Y2Zo?= =?utf-8?B?MXBVeCsybUJNNVhacjFqNHBLT0t1eFIrNXF1VVZpVkJXeE1DUVpLVVpiMHlh?= =?utf-8?B?anNqYzFWZDB5dHZYK1ZFZjgxRkw4dHJFMm1uaFdQaThWRS9BVUNubzBxU25i?= =?utf-8?B?anVSL2ZGcFVVczhtRGdzWjR1b2E3RlV6d2FBMis2TkV2RWprZit4WVk5QlJv?= =?utf-8?B?dWFmTTlueHhSU1hzYk9RNmJocThPdkN4MFAwZjc5c3hLRXZndXR6eDE3MjVO?= =?utf-8?B?dG5uYzc5dFU1Q3Z1MzNmNlRRcXJaeTNSRlVtOGlDLzFVS2h0RFcyaEZHZzNZ?= =?utf-8?B?dGZIUHBzMkM2ckthQmJEUlkwRUpxSUJNaVd4S0Z0UjNhbGszSDl5Z0JyMHps?= =?utf-8?Q?Yd2Ed5/Bq0PVETX+jwLl1TA/zym5/fsbFZ0snz4?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8b495ae4-6a59-45c6-58cb-08d8dd5340fe X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2021 08:14:51.8207 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4twD7yEMr6CEsr5lYu1wgyDmzdrBDYUAZX2Eljgu+VqCEuovmVEPFCwM5iQWtoXkzZeO2Jcpe20O5N/x7BTRLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5591 X-OriginatorOrg: citrix.com On Mon, Mar 01, 2021 at 06:01:36PM +0000, Andrew Cooper wrote: > On 01/03/2021 17:59, Andrew Cooper wrote: > > On 01/03/2021 09:58, Roger Pau Monne wrote: > >> clang++ relies on the C++ headers installed by g++, or else a clang > >> build will hit the following error: > >> > >> :3:10: fatal error: 'cstring' file not found > >> #include "cstring" > >> ^~~~~~~~~ > >> 1 error generated. > >> make[10]: *** [Makefile:120: headers++.chk] Error 1 > >> > >> Reported-by: Stefano Stabellini > >> Signed-off-by: Roger Pau Monné > >> --- > >> Cc: Ian Jackson > >> No real risk here from a release PoV, it's just pulling a package > >> required for the Alpine clang build. Worse that cold happen is that > >> the Alpine clang build broke, but it's already broken. > > Shouldn't this be fixed upstream in Alpine?  Its clearly a packaging bug. > > Or (thinking about it), we've got a build system bug using g++ when it > should be using clang++. No, the check is using clang++, the issue is that clang++ doesn't install the standard c++ headers, and thus trying to use them (cstring in this case) fails. Installing the g++ package solves the issue because it installs the headers. > How does this check work (without g++) on a non-clang build? It works because on a non-clang Alpine build g++ wasn't installed, so the check wasd just skipped. The headers++.chk target in xen/include/Makefile has a explicit check for a functional CXX. I do think this is some kind of error in the Alpine clang package, as I assume installing clang++ without the standard c++ headers is an error. Regardless of that, I also think installing g++ on the Alpine container is fine, as we would then also perform the C++ header checks with g++ on the normal build. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 02 08:54:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 08:54:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92184.173932 (Exim 4.92) (envelope-from ) id 1lH0mq-0000Nm-Nl; Tue, 02 Mar 2021 08:53:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92184.173932; Tue, 02 Mar 2021 08:53:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH0mq-0000Nf-Kc; Tue, 02 Mar 2021 08:53:48 +0000 Received: by outflank-mailman (input) for mailman id 92184; Tue, 02 Mar 2021 08:53:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH0mp-0000NK-DM for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 08:53:47 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0a212ef9-bd53-4814-9d15-b312a3845a3b; Tue, 02 Mar 2021 08:53:46 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 48F3BABF4; Tue, 2 Mar 2021 08:53:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a212ef9-bd53-4814-9d15-b312a3845a3b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614675225; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/FO/OM0qLgcrTjbuqRcnANmHmXtqLBI8kYRJad7qdLo=; b=n2oJ0uYfPolJcLE+d2E3GtDUreQ87rD3/TUT0aKWiRpzr3CmeS9t9rB74Ukuzgu2tpZEOi zaIBwrs1W9fsdfeetQu1gUNC0lMUcFskRimdOcI2biN4FT9INYn5Toc8D1F6Jh3yVMPfo1 ih7aSIRX3tg5EKJzYybWckxHiuK+Rvw= Subject: Re: [PATCH for-4.15] automation/alpine: add g++ to the list of build depends To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini , Ian Jackson , Andrew Cooper References: <20210301095806.68518-1-roger.pau@citrix.com> <27ec9db0-69bc-df9a-8511-109f57972046@citrix.com> From: Jan Beulich Message-ID: Date: Tue, 2 Mar 2021 09:53:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 02.03.2021 09:14, Roger Pau Monné wrote: > On Mon, Mar 01, 2021 at 06:01:36PM +0000, Andrew Cooper wrote: >> On 01/03/2021 17:59, Andrew Cooper wrote: >>> On 01/03/2021 09:58, Roger Pau Monne wrote: >>>> clang++ relies on the C++ headers installed by g++, or else a clang >>>> build will hit the following error: >>>> >>>> :3:10: fatal error: 'cstring' file not found >>>> #include "cstring" >>>> ^~~~~~~~~ >>>> 1 error generated. >>>> make[10]: *** [Makefile:120: headers++.chk] Error 1 >>>> >>>> Reported-by: Stefano Stabellini >>>> Signed-off-by: Roger Pau Monné >>>> --- >>>> Cc: Ian Jackson >>>> No real risk here from a release PoV, it's just pulling a package >>>> required for the Alpine clang build. Worse that cold happen is that >>>> the Alpine clang build broke, but it's already broken. >>> Shouldn't this be fixed upstream in Alpine?  Its clearly a packaging bug. >> >> Or (thinking about it), we've got a build system bug using g++ when it >> should be using clang++. > > No, the check is using clang++, the issue is that clang++ doesn't > install the standard c++ headers, and thus trying to use them (cstring > in this case) fails. Installing the g++ package solves the issue > because it installs the headers. I have to admit that I consider this odd. The g++ package should neither provide nor depend on the headers. It may recommend their installation. On my distro (SLES) the headers come from the libstdc++-devel package, as I would have expected. There additionally is a dependency of libclang5 (no -devel suffix!) on libstdc++-devel (I suppose this is an indication that things aren't quite right here either; I haven't checked an up-to-date version of the distro yet, though). Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 02 09:37:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 09:37:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92211.173945 (Exim 4.92) (envelope-from ) id 1lH1Sk-0004Ph-Vl; Tue, 02 Mar 2021 09:37:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92211.173945; Tue, 02 Mar 2021 09:37:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1Sk-0004Pa-SC; Tue, 02 Mar 2021 09:37:06 +0000 Received: by outflank-mailman (input) for mailman id 92211; Tue, 02 Mar 2021 09:37:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1Sj-0004PV-JB for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 09:37:05 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5d8e1e58-a09a-4751-9679-11060f904f9d; Tue, 02 Mar 2021 09:37:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d8e1e58-a09a-4751-9679-11060f904f9d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614677824; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=1TEZgdVIkdgu/VjQrgyHcEq99hsw4HlSh0UTR2w7MuM=; b=iI8fseYiJFpojSNgYMCOEXSOm+SCE0jEEv54BBvl/xRjjir1FzWFiMgg 0mgfq5nvHhIP2w4/qPCGmziDNBsg6geJC+TUkOnBB9jA8zsPBiIm9MkVr Jvqz5CWE63R7FpLwY0yoHhLSBwbiaBtHN3LlHe5auGhKdTJjULBA1Kg7u w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: q2ufSHc/nWBWG47euwiO9lmFT1VQrur8rjxjN2kYldhLYenyEofHzXxI5anXtrl9b41lZ3xb8K nT1VAYX6kk9kRf3q9iwj+UToMv9c5cu8Ce6A5KED5ymzSIOum6mxHm4SOSj2VuI6nikrc/w5+I XteKk+icJ9XFA51L3c8wNdcZC2wCNn3QDbc1uz96C49VqffJkIO1y32Bek/IbMVu8pVQXTCx// EhqjpQiA+Qh2GNC3y0FKs8+WNb161C1dvNCTtmaa+zui5iKrHCA95H3SFCUXJvFZ81+ljJqtrc 7lc= X-SBRS: 5.2 X-MesageID: 38309385 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,216,1610427600"; d="scan'208";a="38309385" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cRr5p7AUIGUsSHeSkuVVfiFHpnrfcp6b/NuH4IpYKhyjEkIYdRmzPV5aselm9KM/tvXaCB9pNQP0Z2sdHztnS1uxnTj6YzgYYli8bK+zHtsD6wGkRq67pefIA/TWzWWzNZIdK4IVtRTA6VhJ2kxh/kCnf5XHJxFL3oUVIX+YoTBkwWeCKJb7CXaWMt0YkBeuVgozkNmbEZOvD44RGkXiPvCUnnwwvlcWsMzrMVvFbhPalCp/SzL/ooiHMF5G8djT03HfM2coQK4YY/hHz1t6mT2d11X/Ap9KvPa8zpfldH1DIrWSwY8Z6S0DT9J/eab3Cg29nv3qFRki1YpKjtwiUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q1V4qtXOqAZV214T8ZG4+w9fSzWEz4yMli4sz2t59/E=; b=LC4FDXw4iFdF7HMk+pho5uGWB/Zwahz3a+yV29v9tUegmlG8tAP6amz6yxfjydZ5SEVHvt2NqTzBXV3VI9X1R16UKsoOJrGObXHxrj5G0IAH2haQhIJbJqjCFP0zPRY15itAXTlSEk8X/F1aIvmjuI92czgPmC/swOwe9Y6Dinixwh4y7h8fRLiH/pADfoTc3qE1HSkLzBZ/kNTeUupvOqBMtgOQBbD/llPR7tO7R3XjxZt/e0gCZgK4p9lhApWFKW6utTsff22wtlG0JlV306EM+c9lRhhgr2YezcPO9KNXA7FRKdw5fJV+RYX+R9rNmGJTYZ5zhqH7K6PlA1SzwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q1V4qtXOqAZV214T8ZG4+w9fSzWEz4yMli4sz2t59/E=; b=IMuL9sX4A7alj0EnQxFe9TsicsPheEBw78eM5iTbqR5VOeBotyzj/BHSjPCqAP/pLK9K51PAU1170n6C55ZwusqmKQMnCmssIUKXxJOF3ZrhZ/2tjeqeifFm6KnelD5QNHGgY211PF2JyQaqhatAZTBdQNk08A9cd7QplAsrsjg= Date: Tue, 2 Mar 2021 10:36:51 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: , Doug Goldstein , Stefano Stabellini , Ian Jackson , Andrew Cooper Subject: Re: [PATCH for-4.15] automation/alpine: add g++ to the list of build depends Message-ID: References: <20210301095806.68518-1-roger.pau@citrix.com> <27ec9db0-69bc-df9a-8511-109f57972046@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AM5PR0201CA0012.eurprd02.prod.outlook.com (2603:10a6:203:3d::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6fb12b84-104d-4ea1-fb53-08d8dd5ebaa4 X-MS-TrafficTypeDiagnostic: DM6PR03MB3484: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dAE5AtJAVnsDlcdyyTPZxiUPRQc01SC6n2rO8Uah22OmTwBSA/It8f5UCSsRHELloWn/vxcVMfOAD04pco2IqnjpRspvxb/ExJIgIRalrqZdVH9E9OHPaXdF2dpfmsIV/xWcWKm6L++RB5nEm4DUwUX6id4g/izDpA0aHMfXSmgM+BUcdP9IZss2oBADF8WlUi3gE1LYRO9uIuQINRzajevNUNntUD6E0PKHQlJe1ZKMPk2OPvh8dpJBzuttU7tCAa1kuDwCweB6PR/l4hUv3Kp9WpuSX917LwmQ0L943mWiMeRXi1lp9MrgYHmRv4F9hDnFqDITlllQJScytMO8zTO6927fMQ6evbqIQMTTHD39PMrQIC7Is8+MuWVVE9bbx7L2U84Q+2zQTD9fKqbaXq4ctCn4oSS1AKoYBoNHRbJ+0YL1O80WKYoCVQG+EFj1oaPArd7eQyIcY/FcoUZz+0H+Kvjnwo980ozlc9SY0PGsrDsVEpqFxHnyhfaEWqrvdSL+Ww8gaKQnsnpj8mbiaw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(39860400002)(396003)(366004)(346002)(376002)(136003)(6666004)(33716001)(316002)(6496006)(66946007)(86362001)(66556008)(53546011)(956004)(5660300002)(54906003)(26005)(8936002)(8676002)(83380400001)(66476007)(478600001)(85182001)(2906002)(107886003)(4326008)(186003)(16526019)(6486002)(6916009)(9686003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZW1PbWtDN0FHaFlDR1I5VnZZVThJMXFadysxVXFCQjFoU09xdGNJcjRmcGVV?= =?utf-8?B?Vm1TRnltb2RMK1J5eWFaUk1lb3VWTEd0cmZ1UWYzRWhwdHB3NnI4bnNmSkJs?= =?utf-8?B?L3k0N3g4cEtoVWNZWjl4K2tiVDdiQ0R4UGgzaGNicllxZGRJeGp1azROYkRK?= =?utf-8?B?TDVPQkNnMWRnWFNDYWFRUlEva1RkTktjU004TzQwblJFTnVoSWNld1VTTENh?= =?utf-8?B?MkVUTFNlR2hGZ0RlSnpHWHphMWs2WDN2akRINE4vK2JjaG9leGY3R0QyZ0FE?= =?utf-8?B?RU9MMnFnSEUyd2s0TGNtcmFIYm1BVEhNMnNTOUdWWDZvMU5lWWZzN1pUNlFB?= =?utf-8?B?YVplU0UzRkRtMUs1VTh5VWVaekhsVXB2bGdrTXo5WHhEU1J6NjNpd0pFZGty?= =?utf-8?B?b3VSZHVjei90V0YzbnRaS0tBMXNOMWFCbHdPQzRkd0FGUFFRQzZabFVkeWNC?= =?utf-8?B?Z0s0eEF6MjZLOUlBNE8rYUVXTUROSlQ1SnRjS2dtN2tOQS9YTmx5aHJMQllV?= =?utf-8?B?VEJ2cFVTWWNqMUVOUEdIcVhGYmFtVEJJWlR6Z0FjWWMwZzlKc2lyU0Y3ejFU?= =?utf-8?B?VGwrZWljRHI3eXJoZ0NSYjBLQSs1Nkg3enJRcXNEcG9NOU1hSW04YkV3VW45?= =?utf-8?B?YWtCOEl6RFdEN2ZaMGRjYkc4eDQrajlWV1RxMy9mN2l0aGh1OHBOUnRMN3cw?= =?utf-8?B?T2NIcDZLZEVKemRLOFEyU2RtU1lxbjh0SkhySldwK0YwSkVpSmVUeTFEeUtY?= =?utf-8?B?M1FsL3dGenAxbTZ4WXRJQk0xL0Q2MUhPb0FMWUkxVjllalRrQ0JRTTd6emRW?= =?utf-8?B?Sm43VkFZVTAvMWlDc1ZvS3lYNHdxTjk0ZDBCeENMZXJvb0lBU1ZOOWg3RkJP?= =?utf-8?B?VndoandmWEpFRUhJRlBvN1RVRnFTeDY1ZDB4VGdZNTlkWFdFazBxVjJWT3RH?= =?utf-8?B?TlNWa0ROM3B6SitiUW5wMnZTemN6TUpKNVVzWm42elBPbjRaY3lYTXJkRkxp?= =?utf-8?B?K0FRNGJmb3JzQlRHSjBYeEpPNkU2VENod2NsQWJkaGNveHR3RUVISzhsLzhT?= =?utf-8?B?TXMzU01pTGR1SjNkV1ZORmtqbjExaTdVNkl2WGtMdnZpVTE4S0R1aHp5VU9l?= =?utf-8?B?b0Z0Q2pnTklhQy9Gb0xxRWVMV2psZHV2anZxbktBOUl5ZDhrcGJNVVBiUDBV?= =?utf-8?B?c0x2K0N5STk3bUpWd05xb1JjV1JPVHp5SmJEV2hja0daMFJGRUF2dWdJcVdx?= =?utf-8?B?ZVBqblpYVXpDVFFPZVp1WlQxSy9VZTBud0thU1BlUzhEUDhhMEw4aUNPcWhF?= =?utf-8?B?ODI0OEcreTJ1bVRIY2U5aVkvV1NCZzVnTnZZdTNmVzFGQmpCNWYvQzlYQmtw?= =?utf-8?B?M2E2a3NTTEVGN2YwSzIxMG9LbGVxQ2NqdVI5VTY5ZFdvZEhXVVNncm9nZnlB?= =?utf-8?B?cGsyNTFBcEZHZWd1OEx6b3FLL0VoY0Z5TTdrdFBjMnBoQnBSVjM0NWhTUGhE?= =?utf-8?B?YUJaaktzOE9QbmJ3bkFBNStSTXRWbWVkWW1Yd0F5ZmNLTU9DbWM2NmtXMHJw?= =?utf-8?B?d09Vd3FDbGdMVnFtR1hHQ2FEd1RyLzdZQWxoMmVVWU5KZTBtSklXWUxiUHlR?= =?utf-8?B?RVE1dGw0UGx3eDU3QThOekxxL0lLOElTSDJTMTdmL1YrMUNTL09DZmhDZjBL?= =?utf-8?B?ZTc2YlZVNTl6MmRTT1hKVW9Fa2lPbWIveHRHVUR5bmI2cUpad2UzNkhhQk1j?= =?utf-8?B?SE5rc3NodE9Ld3BFbndSZDJwcmxLU3luUUNkdjR3SWJVNHhudG0zQUljaUE3?= =?utf-8?B?cTJWU3pLWHNRSFRNNFNQZz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6fb12b84-104d-4ea1-fb53-08d8dd5ebaa4 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2021 09:37:00.2238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iZxIE8c3lWG1hGrQWzkhO+FNXzqJJ5DlGSAnU6o02afu8KDrnxcIGM4bFwq5peQoLSeZtBlbiXULEU5q9LsBwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3484 X-OriginatorOrg: citrix.com On Tue, Mar 02, 2021 at 09:53:41AM +0100, Jan Beulich wrote: > On 02.03.2021 09:14, Roger Pau Monné wrote: > > On Mon, Mar 01, 2021 at 06:01:36PM +0000, Andrew Cooper wrote: > >> On 01/03/2021 17:59, Andrew Cooper wrote: > >>> On 01/03/2021 09:58, Roger Pau Monne wrote: > >>>> clang++ relies on the C++ headers installed by g++, or else a clang > >>>> build will hit the following error: > >>>> > >>>> :3:10: fatal error: 'cstring' file not found > >>>> #include "cstring" > >>>> ^~~~~~~~~ > >>>> 1 error generated. > >>>> make[10]: *** [Makefile:120: headers++.chk] Error 1 > >>>> > >>>> Reported-by: Stefano Stabellini > >>>> Signed-off-by: Roger Pau Monné > >>>> --- > >>>> Cc: Ian Jackson > >>>> No real risk here from a release PoV, it's just pulling a package > >>>> required for the Alpine clang build. Worse that cold happen is that > >>>> the Alpine clang build broke, but it's already broken. > >>> Shouldn't this be fixed upstream in Alpine?  Its clearly a packaging bug. > >> > >> Or (thinking about it), we've got a build system bug using g++ when it > >> should be using clang++. > > > > No, the check is using clang++, the issue is that clang++ doesn't > > install the standard c++ headers, and thus trying to use them (cstring > > in this case) fails. Installing the g++ package solves the issue > > because it installs the headers. > > I have to admit that I consider this odd. The g++ package should > neither provide nor depend on the headers. It may recommend their > installation. On my distro (SLES) the headers come from the > libstdc++-devel package, as I would have expected. There > additionally is a dependency of libclang5 (no -devel suffix!) on > libstdc++-devel (I suppose this is an indication that things > aren't quite right here either; I haven't checked an up-to-date > version of the distro yet, though). Yes, that was indeed my first attempt as I've tried to install libstdc++, but there's no -devel counterpart for the package, and it only installs the libraries but not the headers. Then if I list the contents of the g++ package, I do see: ... usr/include/c++/10.2.1/cstring ... And clang++'s include path is: #include <...> search starts here: /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1 /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1/x86_64-alpine-linux-musl /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1/backward /usr/include /usr/lib/clang/10.0.1/include So it does seem clang depends on the gcc c++ headers, I assume this is done in order to avoid having a duplicate set of c++ headers for clang and gcc? I really have no idea, but I do think clang package should depend on g++. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 02 09:43:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 09:43:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92216.173957 (Exim 4.92) (envelope-from ) id 1lH1Z6-0005Qc-N5; Tue, 02 Mar 2021 09:43:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92216.173957; Tue, 02 Mar 2021 09:43:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1Z6-0005QV-Jc; Tue, 02 Mar 2021 09:43:40 +0000 Received: by outflank-mailman (input) for mailman id 92216; Tue, 02 Mar 2021 09:43:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1Z5-0005QQ-KV for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 09:43:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1Z4-0001eS-3G; Tue, 02 Mar 2021 09:43:38 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lH1Z3-0007jY-NL; Tue, 02 Mar 2021 09:43:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=LL80vY0iGQtsgZdQlSTohRJseGhslfirDALRsvBsW2U=; b=pFytgKEN4V4hni9ftiS8WoDoys y2fpOqCyjAilX8y/7jrARk1LKwwE2kvC0P6a5kOJhm1OwQUjRKtKaOGZgc9SBzjbbi5mh5aCxWfhz xa9caO158al80fGaJKPP3bpj1QU1Otq+HeSkQMnRkTiH5Uxm/fp7DT0Gjf7dZ/C3oZ9U=; Subject: Re: [PATCH for-4.15] tools/xenstored: Avoid dereferencing a NULL pointer if LiveUpdate is failing To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu References: <20210226182655.2499-1-julien@xen.org> <842a4189-c7a9-e3c1-6e21-740eb352aadf@suse.com> From: Julien Grall Message-ID: Date: Tue, 2 Mar 2021 09:43:35 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <842a4189-c7a9-e3c1-6e21-740eb352aadf@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Juergen, On 01/03/2021 19:19, Jürgen Groß wrote: > On 26.02.21 19:26, Julien Grall wrote: >> From: Julien Grall >> >> In case of failure in do_lu_start(), XenStored will first free lu_start >> and then try to dereference it. >> >> This will result to a NULL dereference as the destruction callback will >> set lu_start to NULL. >> >> The crash can be avoided by freeing lu_start *after* the reply has been >> set. >> >> Fixes: af216a99fb4a ("tools/xenstore: add the basic framework for >> doing the live update") >> Signed-off-by: Julien Grall > > Reviewed-by: Juergen Gross Thanks! I have committed the patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 02 09:54:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 09:54:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92223.173972 (Exim 4.92) (envelope-from ) id 1lH1jX-0006X3-S8; Tue, 02 Mar 2021 09:54:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92223.173972; Tue, 02 Mar 2021 09:54:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1jX-0006Ww-PF; Tue, 02 Mar 2021 09:54:27 +0000 Received: by outflank-mailman (input) for mailman id 92223; Tue, 02 Mar 2021 09:54:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1jV-0006Wr-PS for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 09:54:25 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3828a715-c3d8-4f45-9d01-4e1a22d3b99a; Tue, 02 Mar 2021 09:54:24 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 97C9CAAC5; Tue, 2 Mar 2021 09:54:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3828a715-c3d8-4f45-9d01-4e1a22d3b99a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614678863; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Syiqv1/pu44MTaF/MBEmaXXJjHWJbeze2Yi7Z9whYAQ=; b=SgpnjEjHg/yrpt/bnCdk9TdbSHS8mndTr0KCaYsiCbppvQx09sX4N6TXkoo+k0TJY0lxl2 +KX03H4rdz5ASBepSQ994eQSxZ2BDP+eBKoirbGZ3asdHpwFiUgELO7WVI9O1vSxUGPf6j eEyBEa0TruU4yxx+G4Mqrgnzn3Pych4= Subject: Re: [PATCH for-4.15] automation/alpine: add g++ to the list of build depends To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini , Ian Jackson , Andrew Cooper References: <20210301095806.68518-1-roger.pau@citrix.com> <27ec9db0-69bc-df9a-8511-109f57972046@citrix.com> From: Jan Beulich Message-ID: <77e7004f-8a73-e868-1ccd-318de5886f4a@suse.com> Date: Tue, 2 Mar 2021 10:54:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 02.03.2021 10:36, Roger Pau Monné wrote: > On Tue, Mar 02, 2021 at 09:53:41AM +0100, Jan Beulich wrote: >> On 02.03.2021 09:14, Roger Pau Monné wrote: >>> On Mon, Mar 01, 2021 at 06:01:36PM +0000, Andrew Cooper wrote: >>>> On 01/03/2021 17:59, Andrew Cooper wrote: >>>>> On 01/03/2021 09:58, Roger Pau Monne wrote: >>>>>> clang++ relies on the C++ headers installed by g++, or else a clang >>>>>> build will hit the following error: >>>>>> >>>>>> :3:10: fatal error: 'cstring' file not found >>>>>> #include "cstring" >>>>>> ^~~~~~~~~ >>>>>> 1 error generated. >>>>>> make[10]: *** [Makefile:120: headers++.chk] Error 1 >>>>>> >>>>>> Reported-by: Stefano Stabellini >>>>>> Signed-off-by: Roger Pau Monné >>>>>> --- >>>>>> Cc: Ian Jackson >>>>>> No real risk here from a release PoV, it's just pulling a package >>>>>> required for the Alpine clang build. Worse that cold happen is that >>>>>> the Alpine clang build broke, but it's already broken. >>>>> Shouldn't this be fixed upstream in Alpine?  Its clearly a packaging bug. >>>> >>>> Or (thinking about it), we've got a build system bug using g++ when it >>>> should be using clang++. >>> >>> No, the check is using clang++, the issue is that clang++ doesn't >>> install the standard c++ headers, and thus trying to use them (cstring >>> in this case) fails. Installing the g++ package solves the issue >>> because it installs the headers. >> >> I have to admit that I consider this odd. The g++ package should >> neither provide nor depend on the headers. It may recommend their >> installation. On my distro (SLES) the headers come from the >> libstdc++-devel package, as I would have expected. There >> additionally is a dependency of libclang5 (no -devel suffix!) on >> libstdc++-devel (I suppose this is an indication that things >> aren't quite right here either; I haven't checked an up-to-date >> version of the distro yet, though). > > Yes, that was indeed my first attempt as I've tried to install > libstdc++, but there's no -devel counterpart for the package, and it > only installs the libraries but not the headers. > > Then if I list the contents of the g++ package, I do see: > > ... > usr/include/c++/10.2.1/cstring > ... > > And clang++'s include path is: > > #include <...> search starts here: > /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1 > /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1/x86_64-alpine-linux-musl > /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1/backward > /usr/include > /usr/lib/clang/10.0.1/include > > So it does seem clang depends on the gcc c++ headers, I assume this is > done in order to avoid having a duplicate set of c++ headers for clang > and gcc? I really have no idea, but I do think clang package should > depend on g++. As long as the g++ package is what provides the headers (i.e. if that's their concept), I agree. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 02 09:56:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 09:56:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92226.173985 (Exim 4.92) (envelope-from ) id 1lH1lQ-0006fZ-8J; Tue, 02 Mar 2021 09:56:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92226.173985; Tue, 02 Mar 2021 09:56:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1lQ-0006fS-59; Tue, 02 Mar 2021 09:56:24 +0000 Received: by outflank-mailman (input) for mailman id 92226; Tue, 02 Mar 2021 09:56:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1lO-0006fN-RW for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 09:56:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1lJ-0001qD-V5; Tue, 02 Mar 2021 09:56:17 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lH1lJ-0000JT-MD; Tue, 02 Mar 2021 09:56:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:References:Cc:To:From:Subject; bh=lENsukwlNnLMK0Qh29VzSxBn3vWHV9C/wvN/UYPAlNM=; b=rs7sIHaXW1z7c0Fc+zUVRyKbL8 O/kYrIshmdxPUBxRHNrtioozosvCkv/f611GAVRqMEZRA4ufFQG72JtUjUKqaMVFkrHnSFsij2hNJ rG2FWDUuiTP/DbbiExoruAEpb89lp+ydT0pWXvg384t/BXWC9Iq3WpuM6gqLt7eawGoo=; Subject: Re: [PATCH for-4.15 v5 0/3] xen/iommu: Collection of bug fixes for IOMMU teardown From: Julien Grall To: xen-devel@lists.xenproject.org Cc: hongyxia@amazon.co.uk, iwj@xenproject.org, Julien Grall , Jan Beulich , Paul Durrant , Andrew Cooper , Kevin Tian References: <20210226105640.12037-1-julien@xen.org> Message-ID: <26a0736a-0597-cfe8-8ff1-e491d372d0d4@xen.org> Date: Tue, 2 Mar 2021 09:56:15 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226105640.12037-1-julien@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi, On 26/02/2021 10:56, Julien Grall wrote: > Julien Grall (3): > xen/iommu: x86: Don't try to free page tables is the IOMMU is not > enabled > xen/x86: iommu: Ignore IOMMU mapping requests when a domain is dying > xen/iommu: x86: Clear the root page-table before freeing the > page-tables I have committed the 3 patches. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 02 09:59:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 09:59:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92229.173997 (Exim 4.92) (envelope-from ) id 1lH1of-0006xa-NX; Tue, 02 Mar 2021 09:59:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92229.173997; Tue, 02 Mar 2021 09:59:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1of-0006xT-KU; Tue, 02 Mar 2021 09:59:45 +0000 Received: by outflank-mailman (input) for mailman id 92229; Tue, 02 Mar 2021 09:59:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1oe-0006xO-0i for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 09:59:44 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 204ac472-efce-46a1-a494-63e22654fb5c; Tue, 02 Mar 2021 09:59:38 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DBA4FAAC5; Tue, 2 Mar 2021 09:59:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 204ac472-efce-46a1-a494-63e22654fb5c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614679178; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jIvbhuwtHC10Th47xyFwLVZVOw7nEaNqt4wmiMaGGS8=; b=fthk2TpRcXcrzEjET/AjTBCaAn1CrujaYRJFOSYHUenB2AXcXw+lTfF1gMvlZLBWkNuT8d RVEXlISfQLv2u1fpFJsg7bBz3f4ld4qTq4Jod+NpD9ctQiDOCriO/RGauvMDdI5L9eReUV nmfHKN7y04yj4mc+eGgn3jewRTrKyY8= Subject: Re: [PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1 To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , George Dunlap , Ian Jackson References: <1d8d5089-32a9-9c42-5949-8f9cd20f33e0@suse.com> From: Jan Beulich Message-ID: <9b0a5689-fced-d986-3bfb-9ade47cf3635@suse.com> Date: Tue, 2 Mar 2021 10:59:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.03.2021 19:00, Roger Pau Monné wrote: > On Mon, Mar 01, 2021 at 04:14:26PM +0100, Jan Beulich wrote: >> On 01.03.2021 15:01, Roger Pau Monné wrote: >>> On Mon, Mar 01, 2021 at 09:31:07AM +0100, Jan Beulich wrote: >>>> In this case the compiler is recognizing that no valid array indexes >>>> remain (in x2apic_cluster()'s access to per_cpu(cpu_2_logical_apicid, >>>> ...)), but oddly enough isn't really consistent about the checking it >>>> does (see the code comment). >>> >>> I assume this is because of the underlying per_cpu access to >>> __per_cpu_offset using cpu as the index, in which case wouldn't it be >>> better to place the BUG_ON there? >> >> Not sure, to be honest. It seemed more logical to me to place it >> next to where the issue is. > > I'm not sure whether I would prefer to place it in per_cpu directly to > avoid similar issues popping up in other parts of the code in the > future? That's going to be a lot of BUG_ON(), and hence a lot of "ud2" instances. Not something I'm keen on having. The more that it's not the per_cpu() which triggers the warning, but separate conditionals allowing the compiler to deduce value ranges of variables. > Maybe that's not likely. TBH it seems kind of random to be placing > this BUG_ON conditionals to make the compilers happy, but maybe > there's no other option. In principle I agree - hence the longish comment. >>> Also I wonder why the accesses the same function does to the per_cpu >>> area before the modified chunk using this_cpu as index don't also >>> trigger such warnings. >> >> The compiler appears to be issuing the warning when it can prove >> that no legitimate index can make it to a respective use. in this >> case it means that is is >> >> if ( this_cpu == cpu ) >> continue; >> >> which makes it possible for the compiler to know that what gets >> past this would be an out of bounds access, since for NR_CPUS=1 >> both this_cpu and cpu can only validly both be zero. (This also >> plays into my choice of placement, because it is not >> x2apic_cluster() on its own which has this issue.) > > I see, thanks for the explanation. It makes me wonder whether other > random issues like this will pop up in other parts of the code. We > should have a gitlab build with NR_CPUS=1 in order to assert we don't > regress it. Speaking for myself I certainly won't be able to detect > whether something broke this support in the future. I guess I'll carry on having such a build test locally. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 02 10:02:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 10:02:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92235.174021 (Exim 4.92) (envelope-from ) id 1lH1rB-0007vB-9b; Tue, 02 Mar 2021 10:02:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92235.174021; Tue, 02 Mar 2021 10:02:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1rB-0007v4-5Q; Tue, 02 Mar 2021 10:02:21 +0000 Received: by outflank-mailman (input) for mailman id 92235; Tue, 02 Mar 2021 10:02:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1r9-0007uy-ML for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 10:02:19 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2ba1421b-d65f-424b-bb0d-582ced201441; Tue, 02 Mar 2021 10:02:18 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C1AD8AD74; Tue, 2 Mar 2021 10:02:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ba1421b-d65f-424b-bb0d-582ced201441 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614679337; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a6g4Mjjf8sjhNeIrAXR0tJkEZNDVJRke9j41eMR8MCk=; b=TEHOQTBYl9UOLfd/tdAjm8OykW7MOM8OXBqBbf36B5zOUUa1tMty+qL2D8NK0CyHb0/I+4 KBGm3Zz5UTDaJRZpFbgSgE2mutwWXfp1UwZzU1l7TCTyN/jCNJgpLrSMPF5/IzfnFUr7pP p1wlmh/UUDvNYnffjlESh9z0HGAyDJw= Subject: Re: [PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1 To: Ian Jackson Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap References: <1d8d5089-32a9-9c42-5949-8f9cd20f33e0@suse.com> <24637.4165.400955.400473@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <7b4c0c51-5a3c-b9bb-7c9c-62285095183b@suse.com> Date: Tue, 2 Mar 2021 11:02:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24637.4165.400955.400473@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.03.2021 17:03, Ian Jackson wrote: > Jan Beulich writes ("[PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1"): >> In this case the compiler is recognizing that no valid array indexes >> remain (in x2apic_cluster()'s access to per_cpu(cpu_2_logical_apicid, >> ...)), but oddly enough isn't really consistent about the checking it >> does (see the code comment). > ... >> - if (this_cpu == cpu || x2apic_cluster(this_cpu) != x2apic_cluster(cpu)) >> + if ( this_cpu == cpu ) >> + continue; >> + /* >> + * Guard in particular against the compiler suspecting out-of-bounds >> + * array accesses below when NR_CPUS=1 (oddly enough with gcc 10 it >> + * is the 1st of these alone which actually helps, not the 2nd, nor >> + * are both required together there). >> + */ >> + BUG_ON(this_cpu >= NR_CPUS); >> + BUG_ON(cpu >= NR_CPUS); >> + if ( x2apic_cluster(this_cpu) != x2apic_cluster(cpu) ) >> continue; > > Is there some particular reason for not putting the BUG_ON before the > if test ? That would avoid the refactoring. I want it to be as close as possible to the place where the issue is. I also view the refactoring as a good thing, since it allows a style correction as a side effect. > Of course putting it in next to the array indexing would address that > too. See my earlier reply to Roger's similar remark (which still was along the lines of what I've said above). Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 02 10:04:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 10:04:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92238.174033 (Exim 4.92) (envelope-from ) id 1lH1sy-00082p-Ky; Tue, 02 Mar 2021 10:04:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92238.174033; Tue, 02 Mar 2021 10:04:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1sy-00082i-Hj; Tue, 02 Mar 2021 10:04:12 +0000 Received: by outflank-mailman (input) for mailman id 92238; Tue, 02 Mar 2021 10:04:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1sx-00082c-3s for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 10:04:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH1sv-00026P-GI; Tue, 02 Mar 2021 10:04:09 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lH1sv-0000s8-49; Tue, 02 Mar 2021 10:04:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=eMlQRcsvHQkCMZvlA+s3Z/ToSY7JnS2YblrzhoWsYk0=; b=FzPSEG1HmvHrRFmBnPCqSMbYpR uIqHBdKqW90WgMw48rPpGKUpFpSPTF2bUCqQoJbYj6CB34CUNqoWhZ9T6jQ1xxFJwA8lbVsJGFSzX r5wYvs5PIDUpo19f5yGLUSFnCBVOuCZLyEkud5jAe0wTLoSOZcuP0ckOrAsbA2ZRdmYA=; Subject: Re: [for-4.15] Re: [PATCH XENSTORE v1 00/10] Code analysis fixes To: Andrew Cooper , Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <759336de-727b-db67-b082-709d5ee735f8@xen.org> <144f2b06-d563-a699-8481-48b6787d502a@citrix.com> From: Julien Grall Message-ID: <6ef77f63-85d1-c4cf-be45-828668ae272e@xen.org> Date: Tue, 2 Mar 2021 10:04:07 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <144f2b06-d563-a699-8481-48b6787d502a@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Andrew, On 01/03/2021 19:39, Andrew Cooper wrote: > On 01/03/2021 18:01, Julien Grall wrote: >> Hi, >> >> I have tagged the e-mail with 4.15 as I think we likely want some of >> the patches to be in the next release. >> >> As a minimum, we get the following: >>   - patch #7: xenstore: handle do_mkdir and do_rm failure >>   - patch #8: xenstore: add missing NULL check >>   - patch #10: xs: add error handling >> >> The first two add missing NULL check in runtime code in XenStored. The >> 3rd one adds a missing NULL check in xs_is_domain_introduced() in >> libxenstore (can be used at runtime by xenpaging at least). >> >> In addition to that, I would like to consider patch #3: xenstore: >> check formats of trace. It is allowing the compiler to check the >> format printf for trace(). This should be low-risk. >> >> For the rest is a mix of silencing coverity and potential errors >> either at init or in a standalone binaries. >> >> The init ones would be useful (patch #1, #5, #9) for Xenstored >> LiveUpdate as they would be potential triggered when upgrading the >> binary. But I am not sure whether we consider LiveUpdate supported. >> >> Any thoughts? > > Live Update is a headline feature, even if only tech preview. I thought it was a tech preview but I couldn't find the statement in SUPPORT.MD. I guess we should update it before 4.15 is released. > > I'd say that all bugfixes are fair game, and low risk.  All these fixes > (other than the evtchn one which has an outstanding question) look to be > reasonable to take.  They're all simple and obvious fixes pointed out by > static analysis. That's a fair point. I wanted to set an order as I know the rules are getting tighter. So this gives an opportunity to Ian to have enough data to decide what's the best. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 02 10:12:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 10:12:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92241.174045 (Exim 4.92) (envelope-from ) id 1lH20v-0000gu-Fq; Tue, 02 Mar 2021 10:12:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92241.174045; Tue, 02 Mar 2021 10:12:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH20v-0000gn-Cb; Tue, 02 Mar 2021 10:12:25 +0000 Received: by outflank-mailman (input) for mailman id 92241; Tue, 02 Mar 2021 10:12:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH20u-0000gi-7I for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 10:12:24 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 468f6091-f605-4f78-ba61-cd0d5e94f5a4; Tue, 02 Mar 2021 10:12:22 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 05955B07B; Tue, 2 Mar 2021 10:12:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 468f6091-f605-4f78-ba61-cd0d5e94f5a4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614679942; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=szHirBvso4lFOuhDZ+6qXj/QgrQ5QHCh8GMH8PsBcGs=; b=FwvXTQMDnNFerIcp/fBmbx+NtS+2+lWa76956P1xGkzSXEysA/LVw7EYhIYWfpsDJCRQe/ 6EggSbfG1+hxE0o8g7jaJi/PsFHKhvUZATelmYNIyQbe/u/20W2n+fQwXMsvN2PVa5is+q MLXJVmV1Me62GXltOqzJ6OayP4kzkNc= Subject: Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits To: Andrew Cooper Cc: Tim Deegan , "xen-devel@lists.xenproject.org" , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: <72c3c863-7465-ce26-1f57-b71227bb2b19@suse.com> <24637.9408.839033.439930@mariner.uk.xensource.com> <99db39fd-e479-f71d-9cb9-5903ff6c12f4@citrix.com> From: Jan Beulich Message-ID: <47fd3ea6-f8f1-7da4-5167-69e1e2876200@suse.com> Date: Tue, 2 Mar 2021 11:12:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <99db39fd-e479-f71d-9cb9-5903ff6c12f4@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.03.2021 18:34, Andrew Cooper wrote: > On 01/03/2021 17:30, Ian Jackson wrote: >> Jan Beulich writes ("Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits"): >>> On 26.02.2021 18:07, Tim Deegan wrote: >>>> Yes, I think it could be reduced to use just one reserved address bit. >>>> IIRC we just used such a large mask so the magic entries would be >>>> really obvious in debugging, and there was no need to support arbitrary >>>> address widths for emulated devices. >>> Will cook a patch, albeit I guess I'll keep as many of the bits set >>> as possible, while still being able to encode a full-40-bit GFN. >>> >>> Ian - I don't suppose you'd consider this a reasonable thing to do >>> for 4.15? It would allow limiting the negative (performance) effect >>> the change here has. >> I'm afraid I don't follow enough of the background here to have an >> opinion right now. Can someone explain to me the risks (and, >> correspondingly, upsides) of the options ? Sorry to be dim, I don't >> seem to be firing on all cylinders today. > > Intel IceLake CPUs (imminently coming out) have no reserved bits in > pagetable entries, so these "optimisations" malfunction.  It is > definitely an issue for HVM Shadow guests, and possibly migration of PV > guests (I can never remember whether we use the GNP fastpath on PV or not). We do for not-present entries afaict, while (I guess obviously) we don't for MMIO ones. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 02 10:22:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 10:22:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92244.174057 (Exim 4.92) (envelope-from ) id 1lH2AX-0001lG-9M; Tue, 02 Mar 2021 10:22:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92244.174057; Tue, 02 Mar 2021 10:22:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH2AX-0001l9-6Q; Tue, 02 Mar 2021 10:22:21 +0000 Received: by outflank-mailman (input) for mailman id 92244; Tue, 02 Mar 2021 10:22:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH2AV-0001l4-TI for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 10:22:19 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 560dbc99-9b95-4d00-8631-b8ad988b08ec; Tue, 02 Mar 2021 10:22:18 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D9783B06A; Tue, 2 Mar 2021 10:22:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 560dbc99-9b95-4d00-8631-b8ad988b08ec X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614680538; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zgkd6i+z7dykHrVUeaj1fYkOWXNgHv+lvxBNXCbv3Bs=; b=iRMhX6NjfuV4y/AAkR2EWecl/lo4kuXw48gA/FN9ic2SyU21iIORonT85ITfzqtoQtywou rvcS9xjtmlkORwJAqA/b7iFhOKiPN1ytHZVjG1Fgd/QTZetWGFrfAJKAQZn3wGLhGp6mhs uUSWzlEEZZff1lSUGl9YrSqqA5qF/7s= Subject: Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits To: Ian Jackson Cc: Tim Deegan , "xen-devel@lists.xenproject.org" , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper References: <72c3c863-7465-ce26-1f57-b71227bb2b19@suse.com> <24637.9408.839033.439930@mariner.uk.xensource.com> <99db39fd-e479-f71d-9cb9-5903ff6c12f4@citrix.com> <24637.10160.977640.808417@mariner.uk.xensource.com> From: Jan Beulich Message-ID: Date: Tue, 2 Mar 2021 11:22:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24637.10160.977640.808417@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.03.2021 18:43, Ian Jackson wrote: > Andrew Cooper writes ("Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits"): >> On 01/03/2021 17:30, Ian Jackson wrote: >>> Jan Beulich writes ("Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits"): >>>> On 26.02.2021 18:07, Tim Deegan wrote: >>>>> Yes, I think it could be reduced to use just one reserved address bit. >>>>> IIRC we just used such a large mask so the magic entries would be >>>>> really obvious in debugging, and there was no need to support arbitrary >>>>> address widths for emulated devices. >>>> Will cook a patch, albeit I guess I'll keep as many of the bits set >>>> as possible, while still being able to encode a full-40-bit GFN. >>>> >>>> Ian - I don't suppose you'd consider this a reasonable thing to do >>>> for 4.15? It would allow limiting the negative (performance) effect >>>> the change here has. >>> I'm afraid I don't follow enough of the background here to have an >>> opinion right now. Can someone explain to me the risks (and, >>> correspondingly, upsides) of the options ? Sorry to be dim, I don't >>> seem to be firing on all cylinders today. I guess the risk from that patch is no different than that from the patch here. It would merely improve performance for guests using very large GFNs for memory areas needing emulation by qemu, which I suppose originally wasn't expected to be happening in the first place. In fact if I would have been certain there are no side effects of the too narrow GFN representation used so far, I would probably have submitted the patches in reverse order, or even folded them. >> Intel IceLake CPUs (imminently coming out) have no reserved bits in >> pagetable entries, so these "optimisations" malfunction.  It is >> definitely an issue for HVM Shadow guests, and possibly migration of PV >> guests (I can never remember whether we use the GNP fastpath on PV or not). >> >> It is arguably wrong that we ever depended on reserved behaviour. >> >> I've got a (not-yet-upsteamed) XTF test which can comprehensively test >> this.  I'll find some time to give them a spin and give a T-by. >> >> Without this fix, some combinations of "normal" VM settings will >> malfunction. > > Thanks for that explanation. > > I don't quite follow how that relates to Jan's comment > > >> Will cook a patch, albeit I guess I'll keep as many of the bits set > >> as possible, while still being able to encode a full-40-bit GFN. > >> > >> Ian - I don't suppose you'd consider this a reasonable thing to do > >> for 4.15? It would allow limiting the negative (performance) effect > >> the change here has. > > I already gave a release-ack for the original patch. I think Jan is > asking for a release-ack for a different way of fixing the problem. Well, I was trying to negotiate whether I should submit that patch for 4.15, or only later for 4.16. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 02 10:45:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 10:45:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92248.174069 (Exim 4.92) (envelope-from ) id 1lH2XF-0003qQ-68; Tue, 02 Mar 2021 10:45:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92248.174069; Tue, 02 Mar 2021 10:45:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH2XF-0003qJ-2m; Tue, 02 Mar 2021 10:45:49 +0000 Received: by outflank-mailman (input) for mailman id 92248; Tue, 02 Mar 2021 10:45:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH2XD-0003qE-Rn for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 10:45:47 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a91e02d3-337d-4315-ae0e-aa14b9b431f7; Tue, 02 Mar 2021 10:45:45 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7D03DADCD; Tue, 2 Mar 2021 10:45:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a91e02d3-337d-4315-ae0e-aa14b9b431f7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614681944; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4cnznGCDDMg+u497gGuDn7NkHjWumuEUE26kdVrLTdc=; b=U8+mNCROBlUCtMveqfuG3DkOP2BKrdPZ5CDn0a3EdKC1UncYiyXh3PNPnETGAl6kEq2U8r xhRL7hGHNOIVUhLw8bB3syHrPx6rFarmxdxZM6BOL5/ISt6lPaGHOd621u8yOXnYBwFcHi 0HphvuCZs1NdaBwLE7KgMEU6zevoQEw= To: Andrew Cooper , Xen-devel Cc: Ian Jackson , Wei Liu References: <20210301170044.23295-1-andrew.cooper3@citrix.com> <20210301170044.23295-3-andrew.cooper3@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: [PATCH 2/3] tools/libs: Stash the 4.14 API/ABIs for the stable libraries Message-ID: <677223c5-e661-a132-35b8-2e9424817c7b@suse.com> Date: Tue, 2 Mar 2021 11:45:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210301170044.23295-3-andrew.cooper3@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qT09KfmBFOVnsPA7LfIZeD4sXdjSKLwlp" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qT09KfmBFOVnsPA7LfIZeD4sXdjSKLwlp Content-Type: multipart/mixed; boundary="PSFzeLbKXobhW6sICOEpE0y50c9lsgypy"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Andrew Cooper , Xen-devel Cc: Ian Jackson , Wei Liu Message-ID: <677223c5-e661-a132-35b8-2e9424817c7b@suse.com> Subject: Re: [PATCH 2/3] tools/libs: Stash the 4.14 API/ABIs for the stable libraries References: <20210301170044.23295-1-andrew.cooper3@citrix.com> <20210301170044.23295-3-andrew.cooper3@citrix.com> In-Reply-To: <20210301170044.23295-3-andrew.cooper3@citrix.com> --PSFzeLbKXobhW6sICOEpE0y50c9lsgypy Content-Type: multipart/mixed; boundary="------------D715ADE0B491DA52709A3841" Content-Language: en-US This is a multi-part message in MIME format. --------------D715ADE0B491DA52709A3841 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 01.03.21 18:00, Andrew Cooper wrote: > These dumps were produced from the RELEASE-4.14.0 tag, with the abi-dum= per > tooling backported from staging. >=20 > For each stable library, add a PKG_OLD_ABI variable pointing at the 4.1= 4 ABI. >=20 > No functional change. >=20 > Signed-off-by: Andrew Cooper > --- > CC: Ian Jackson > CC: Wei Liu > CC: Juergen Gross > --- > tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump | 924 +++++++++++= > .../abi/libxendevicemodel.so.1.3-x86_64-abi.dump | 1491 +++++++++++= ++++++ > tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump | 719 ++++++++ > .../abi/libxenforeignmemory.so.1.3-x86_64-abi.dump | 847 ++++++++++ > tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump | 1199 +++++++++++= +++ > tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump | 597 +++++++ > .../libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump | 1711 +++++++++++= +++++++++ > .../libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump | 239 +++ > .../libs/abi/libxentoollog.so.1.0-x86_64-abi.dump | 882 ++++++++++ > tools/libs/call/Makefile | 2 + > tools/libs/devicemodel/Makefile | 2 + > tools/libs/evtchn/Makefile | 2 + > tools/libs/foreignmemory/Makefile | 2 + > tools/libs/gnttab/Makefile | 2 + > tools/libs/hypfs/Makefile | 2 + > tools/libs/store/Makefile | 2 + > tools/libs/toolcore/Makefile | 2 + > tools/libs/toollog/Makefile | 2 + > 18 files changed, 8627 insertions(+) > create mode 100644 tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump > create mode 100644 tools/libs/abi/libxendevicemodel.so.1.3-x86_64-abi= =2Edump > create mode 100644 tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump= > create mode 100644 tools/libs/abi/libxenforeignmemory.so.1.3-x86_64-a= bi.dump > create mode 100644 tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump= > create mode 100644 tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump > create mode 100644 tools/libs/abi/libxenstore.so.3.0.3-x86_64-abi.dum= p > create mode 100644 tools/libs/abi/libxentoolcore.so.1.0-x86_64-abi.du= mp > create mode 100644 tools/libs/abi/libxentoollog.so.1.0-x86_64-abi.dum= p >=20 > diff --git a/tools/libs/call/Makefile b/tools/libs/call/Makefile > index 4ed201b3b3..37a7db5395 100644 > --- a/tools/libs/call/Makefile > +++ b/tools/libs/call/Makefile > @@ -11,4 +11,6 @@ SRCS-$(CONFIG_SunOS) +=3D solaris.c > SRCS-$(CONFIG_NetBSD) +=3D netbsd.c > SRCS-$(CONFIG_MiniOS) +=3D minios.c > =20 > +PKG_OLD_ABI =3D ../abi/libxen$(LIBNAME).so.1.2-$(XEN_TARGET_ARCH)-abi.= dump > + Any reason you don't add PKG_OLD_ABI =3D=20 =2E./abi/libxen$(LIBNAME).so.$(MAJOR).$(MINOR)-$(XEN_TARGET_ARCH)-abi.dum= p to tools/libs/libs.mk, maybe with some way to override/disable the setting (e.g. by setting a different value for PKG_OLD_ABI just after including $(XEN_ROOT)/tools/libs/libs.mk) ? You could even disable the ABI check if there is no map file provided, which will be the case for all the unstable libs. This would the need to touch all the stable library Makefiles. Juergen --------------D715ADE0B491DA52709A3841 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------D715ADE0B491DA52709A3841-- --PSFzeLbKXobhW6sICOEpE0y50c9lsgypy-- --qT09KfmBFOVnsPA7LfIZeD4sXdjSKLwlp Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA+F1cFAwAAAAAACgkQsN6d1ii/Ey/m OwgAikJJuGkc8NwJCgmcAwWq2nS4s6qIxKxLpuwBslmHvUIlDy1uANhivJm37a2je/3KqtIu89XQ KeHYmEfam+9blfx5h6LMCF6fJF5Dw7LyBllHNfPqJF8wmCsdd+pemnsPxq22UfF7DEFOAgKjdVej J71ZAHGzAU3/gPuwhPkcMQDjzdayxqF5vpWsoJFTLZ9OmWuiwpUjRBaJEgOksOtze80AfLSOLBNw 3h2Z1XyTdh5p4q++b4nSSovWgeSYQ0DK+IlBU1Pj+yWUrzImGZZ2fGvmft1/35ToPImjbZI/KxdS 9zBGbAddSdV/zdx41EJmPHip1pOKhA1jkvcXgjhf1Q== =L/Ds -----END PGP SIGNATURE----- --qT09KfmBFOVnsPA7LfIZeD4sXdjSKLwlp-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 10:58:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 10:58:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92253.174080 (Exim 4.92) (envelope-from ) id 1lH2j2-0004xk-9J; Tue, 02 Mar 2021 10:58:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92253.174080; Tue, 02 Mar 2021 10:58:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH2j2-0004xd-6G; Tue, 02 Mar 2021 10:58:00 +0000 Received: by outflank-mailman (input) for mailman id 92253; Tue, 02 Mar 2021 10:57:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH2j0-0004xY-U5 for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 10:57:59 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7040fd48-3aa7-48be-a8be-6d47ac49b06a; Tue, 02 Mar 2021 10:57:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7040fd48-3aa7-48be-a8be-6d47ac49b06a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614682677; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=3YiH4boUD9uVzVjax6AS1na6eviDKN8qhkHBZr+wnYE=; b=iSy/DSRE+N9z2ueTdHlmbPJLe6ZzOdKNBOfwu7N5IGGxK5hmoPpmMU81 v/VH1+ej5O9Be3OWLa7KaS/RQlBva3ChjjW335k1emeMd13Zra8AhK5ER M1X8cphQePmQYsM3xi94qqkpxZq893N6gzFZQnYruNyDkVo/E8Gs22IGi 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ZdLZAyCGI0nirchg8rANmjWaj8RCAyPNC1em6vHuqC1kDut7l6BbvRqnA9lsyrye3WGhUEmzpU aNCvpNTAPo6EZ6fZuGkm67/XM79/k+I9uhbSdKF5DjQ7oorOOYiAYWxs9ADUpzWzmcOfP1p/lB lrXLrRe6Wj9bSLlgQALBgVPaa9TTpoHy+3bAVN1joQXAcmCtdCRHQ849jjlUrdfJiNe4PUIWjo ZVjX++R4WiQ6FJt3cqwWd6UOfSXwIRfB6sYue5hQOdvBCzhUYmbXAJV1J5XtJteaEC6A8N9KNS bXQ= X-SBRS: 5.2 X-MesageID: 38334043 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,216,1610427600"; d="scan'208";a="38334043" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NdSt8j6TH/uOCGYw9ayQuhBopBnH6/wS+IuH/gtbbJXEzAP5camwJhq5eWP5PEdeMqAdv02NFV6XHLwGs8oCH48i2KekKJHonjgpIb3nt/i8mJnOBsliQ5MZi7mxf7fB5jE0ul4H5cCnVgoXdD4o2Elb6R+A8ymDBZhJsizYUA/zU6uJ0sI1aPBOGNlKurH7E+dPRnn3mJH9xBIJCduVQ8nfUY1dZ2aHuT3mosYfBNjWtxSn2Ty5+s5hv0czbTTEx87YTdAd98f70DAW/orAxz7UhYqUBHRITQZ5jZpM50cUMV9BkpqhiANAN3xwaFYZ2a1pqDh6ryi6XDFZL7S1zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a4b9FBabi2Zvy5ESdh9529MReJHNaekB3PL7uFvPI3g=; b=X5aP70ckAgOrStnFuZ6v8MMOV+/M7LsIYX7RvPV+JbrAA0Zmx/F9DPa/40PcooLli0TWhRaIk0v3uWk8XQSfq6zKhUvCMFrfPticj07g0LlToqNs/foT3m1nFhEEuYrcH99dSFXx0TTSVc7qKnmbiLAyCz8GqoTnv9z9y1UbkFnQdEzfhl/zkJrtJRL7UurD+Vz4lf3lj8E/2+cj42gLezcbUAVjdjsD1p5TeH4qobsEI33CSMNJ3Om/GFQejUYHChy4mNgdFPlBfF+hXGYQgGfX9LbukG2v6FiI8v8yv4BF3B1aCe7p5772/EYS8G68wuslQDSRseIn4lwdMkr+IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a4b9FBabi2Zvy5ESdh9529MReJHNaekB3PL7uFvPI3g=; b=K84O7HglJRBVJx5yjDu/XPph/mtar4qxMmgC9NansM/i5UiY6UQ3qnvQ+TiObn3R2YskK5pf41TzfrFvut40bZwwBfOKSmncWn2lg0z7LHKQ1r94Lqh1+SDhL0IO67Q0Yb3f8MTGou6t+6xXPK/CokjPZW1nK+dhCVTra2l6rMY= Date: Tue, 2 Mar 2021 11:57:46 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , George Dunlap , Ian Jackson Subject: Re: [PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1 Message-ID: References: <1d8d5089-32a9-9c42-5949-8f9cd20f33e0@suse.com> <9b0a5689-fced-d986-3bfb-9ade47cf3635@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9b0a5689-fced-d986-3bfb-9ade47cf3635@suse.com> X-ClientProxiedBy: AM6P191CA0015.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::28) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1c2c2c17-5ace-4f25-a64d-08d8dd6a076d X-MS-TrafficTypeDiagnostic: DM6PR03MB3833: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j2So5KjjKi8jhuNBEeRfQvDyEcq1Bb+Ol0qbhQPwvPt5UfmWOLXqZUjyx+lS9xCzSfcUvlRtPXeVfLCGidrGA+OBncJ7sqVblCM9U24BG4tXb+FGBaOSEYD52Kn+G7Sc1DgNeoau5ZtLoFO07aTIdoGXzT0zRDgI/5QyFJfI782rtkrpuvHoMfDd6BqY2IaqfWID2Qe1OiKR9KaKJKOwv65zqxvS+LKnSyrVeAnJQVUb3sKVPIqenQfjlQ56nXQuBZIZ51k+MylHB1Mevxx26k9ZAjomNqZTJ0X4rxcSJsYCmKwOdTYKcLWRsy5i3j9a1QVKFxI7GsiByX6NElMfLpaNMiA+f3n9GiNoYRPtou9huMACaUScNVNAHZP6MmeaZCmM8srGCW1WEsp9wowVHXT9HOdgw+432/JdddiSmqxahC2yxH2dL5M5tSsutZcZu0u+XChrJSXGvOx5rLcagih3y6Dp2O6lNRWj+gyffmVLDp+we8lr7LgLgehw8oKlOb4MZvge8Os5rB4k4dXA4Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(136003)(396003)(376002)(39860400002)(346002)(366004)(956004)(316002)(8936002)(186003)(16526019)(478600001)(53546011)(86362001)(9686003)(6486002)(5660300002)(2906002)(6496006)(83380400001)(85182001)(66556008)(66476007)(33716001)(8676002)(6916009)(54906003)(4326008)(6666004)(26005)(66946007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?RmJlUWwzVkhaNjVQMEtlNTc4cXF1dUs3eXdRdG1CclMrTHdFM1dxM0pUOHc0?= =?utf-8?B?UWx3UGlMakZCbzBsd25EODU3dVNnenIvZjZRU1AwTk5kVE1IOTFGcHBPbjMy?= =?utf-8?B?TTV0WDJrdWtHSmhNQ1BPaFRBU2dmYXVwWi82TGhCSzVMRHFTVS9iRU5CSUxC?= =?utf-8?B?aEN4OFh2V3VSWGVSMlU4dmdtOGNicFNRREEvdzNlTE5MSEhNdDJLWGo1UHZE?= =?utf-8?B?VGwxOUlBaFVvQ3ROWW9HNktZeWszRCt5VjgwbW9TSnBKTUQvZFh1WHljcC9L?= =?utf-8?B?UlVWU3pYb2dRN2hHSmltVjFMaEwwZnE1cTliVVhMdzMwUHBVY2xBdmxTWVNM?= =?utf-8?B?MG5EZXRSVGlmNnE5OHdydG1RYjZIeHpnM080Ump6Ujh1Uno1bUtTSkxhMnU0?= =?utf-8?B?MlFnWGpIQW05ejMvZlVkTGdPVEsxVzZsZzZseVRBTUREL0NGUDAwL1BPd0Fz?= =?utf-8?B?YXNMUDJiamJ3ZVRxdmcwMFMyZEVGeVZMTml6TWxVQ3ZTa2tHcW5VdDd3TXBr?= =?utf-8?B?SWEwaEZEejYreWRJRXdoTXYzMWR6ckkyUHhnQ2VwRUEreXY2TVVHeEd6U1hS?= =?utf-8?B?TlZqOTgwYm9uUG9EejRFQVQyK3YxTE1ISXJSaVNqSStySnR1Wmkxemg0SkJD?= =?utf-8?B?Y2NCVmZuZ3NISEFLQzZFRnVCYkFHS21GeXlxSVQ1OG5jK284VVErSjZqSWty?= =?utf-8?B?WFFFNDlMY3V5cXBMdEF4QmFDdHRtbk8zRnhFOC9VcmVzZUNaRjRKYlVZVjhv?= =?utf-8?B?OTkrVTkxQ2FzMXNiWmR3dTd0dHlTQy9BN0RDOUx5R1RUWUhYSXVrMnE5SGlz?= =?utf-8?B?bjE4R2tDU2NDeW9EOWtvR2sxdC9jZXRUelExQlNlY25jSnkwdGd2OElWVXoy?= =?utf-8?B?Nld3ZXZCekJqY2hGa2d5SlhPMnl5TmZWM0F5TDdlODZlQmZsQXpIcnY5Zm9T?= =?utf-8?B?amNTR0hKZ0hXeUgxSEg3TjJXV1dXQm5iRnNXVEdEdUpWT2Zvc1dCeWwrZmxt?= =?utf-8?B?MTd4SmpQa25tMGNWNzhCVUhNNEN3Smx2VSt4SGM0U0NJcW53dTI2Y0kxNnMx?= =?utf-8?B?eGltL2ptZzFJT1dBWWIzQTV0aElxdXYrREtTZGZUSVZEN3VDM0ppakdLVDBC?= =?utf-8?B?aFBZeit6RnZpMFFBdWRFM0lmWWVJWU54anhaeHFVUytUTndQdzJhcVBkekNh?= =?utf-8?B?aFJKclYxR2prV3VPRUtMSnNnL0dxTG9FU2pPaGEyVm1jWHFuS28zOFZVWmhl?= =?utf-8?B?eHg3RUZrenJvbTZjOFEvN21PdndBV0ljMktXUzFmK3ZqVFlSUTB6ZVpRL3dE?= =?utf-8?B?WDI1L3BicEZxZ1FWWUxTb2JRc3NqVzFOOFJ4b0Y2VmhQdlJCMk90Q0ZybUVK?= =?utf-8?B?ZGpXRFBvTFh6dVg0K0R2aXNrTjN1dFd2SmlOMTk4TzZUQlRHOEN2NkJhMFNC?= =?utf-8?B?LzllUzNCa1BFK2dHb09zOVNCaW1EOFZJSDNzT3VUTnBvTmljMzN2RXJCVFc4?= =?utf-8?B?dmt1eUpXMGx1OHZHNkVyMnVOS1Z5UEdBUkMxdWpQdzNXSG0vN1JHWDFSWjF6?= =?utf-8?B?NTdHcU5SOTdITkhsMG1xWDUvV2NXcWxqVWI1OUtScnlLVHlzYkNEU0xhcVpy?= =?utf-8?B?MUdLZU8ycGdXelRzMUVkUENBMEZyYzI5VmdzQS9PaTlQTVowR1VlajdJbTJK?= =?utf-8?B?d1lZQkMyL0RlY0Z6Yk5IMjZQMjVlVGtHd0QzVmdxcU1HQ01hdXkzZ0J1YytQ?= =?utf-8?B?clc4S2d0b0kvMWlWM1pxbmxpU3NwSUJtOStqL2QzcDNZdXNSQVRLbTEwYWt2?= =?utf-8?B?ZFUvZWN6bFZGM1NwQTdDUT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1c2c2c17-5ace-4f25-a64d-08d8dd6a076d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2021 10:57:53.5446 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qmF0OKbg2pWJ8yCvTm78cFV6AolCNrzgk/r3P4t7aow48X0IyjEDWLQR8OALNTAdvinQHILW3kXXf+crixj8kQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3833 X-OriginatorOrg: citrix.com On Tue, Mar 02, 2021 at 10:59:37AM +0100, Jan Beulich wrote: > On 01.03.2021 19:00, Roger Pau Monné wrote: > > On Mon, Mar 01, 2021 at 04:14:26PM +0100, Jan Beulich wrote: > >> On 01.03.2021 15:01, Roger Pau Monné wrote: > >>> On Mon, Mar 01, 2021 at 09:31:07AM +0100, Jan Beulich wrote: > >>>> In this case the compiler is recognizing that no valid array indexes > >>>> remain (in x2apic_cluster()'s access to per_cpu(cpu_2_logical_apicid, > >>>> ...)), but oddly enough isn't really consistent about the checking it > >>>> does (see the code comment). > >>> > >>> I assume this is because of the underlying per_cpu access to > >>> __per_cpu_offset using cpu as the index, in which case wouldn't it be > >>> better to place the BUG_ON there? > >> > >> Not sure, to be honest. It seemed more logical to me to place it > >> next to where the issue is. > > > > I'm not sure whether I would prefer to place it in per_cpu directly to > > avoid similar issues popping up in other parts of the code in the > > future? > > That's going to be a lot of BUG_ON(), and hence a lot of "ud2" > instances. Not something I'm keen on having. The more that it's > not the per_cpu() which triggers the warning, but separate > conditionals allowing the compiler to deduce value ranges of > variables. Right. I don't see much other way around this then. Did you check with clang also? Acked-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 02 11:16:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 11:16:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92269.174093 (Exim 4.92) (envelope-from ) id 1lH30i-00072I-Rl; Tue, 02 Mar 2021 11:16:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92269.174093; Tue, 02 Mar 2021 11:16:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH30i-00072B-OI; Tue, 02 Mar 2021 11:16:16 +0000 Received: by outflank-mailman (input) for mailman id 92269; Tue, 02 Mar 2021 11:16:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH30h-000726-0b for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 11:16:15 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4a60960a-f6db-4878-9b97-759ce7e0c4a1; Tue, 02 Mar 2021 11:16:13 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EDED9ABF4; Tue, 2 Mar 2021 11:16:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a60960a-f6db-4878-9b97-759ce7e0c4a1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614683773; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9LzKs6jtTA0+43+bDdsyzXetTlbJKjal/V5TPQ+4HY8=; b=OL9ppcCjnnRWUSaJlQownA93CXIX/DWoskuvzcz0jW2Wa8VCCUXcOBwql2NsQuhIhue1VE +112XkAtOyewXtEyQDMm7shmw52Ki+LWACysri3gpxcvo9hdyA9sLuI2aDNIflBQUxlDDR h88NxaFjxZAggi20sV2H4RvOMIQu12U= Subject: Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection To: Roger Pau Monne , Andrew Cooper Cc: Ian Jackson , Wei Liu , Anthony PERARD , Jun Nakajima , Kevin Tian , Boris Ostrovsky , xen-devel@lists.xenproject.org References: <20210301162357.76527-1-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Tue, 2 Mar 2021 12:16:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210301162357.76527-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.03.2021 17:23, Roger Pau Monne wrote: > Introduce an option to allow selecting the legacy behavior for > accesses to MSRs not explicitly handled. Since commit > 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly > handled by Xen result in the injection of a #GP to the guest. This is > a behavior change since previously a #GP was only injected if > accessing the MSR on the real hardware will also trigger a #GP. > > This seems to be problematic for some guests, so introduce an option > to fallback to this legacy behavior. The main difference between what > was previously done is that the hardware MSR value is not leaked to > the guests on reads. Looking at the WRMSR behavior for PV, what you introduce isn't matching 4.14 behavior: If rdmsr_safe() failed, all that effected was the issuing of a log message. The behavior you propose is better, no question, but it shouldn't be described as matching legacy behavior then. Somewhat related to this I wonder whether MSR reads and writes wouldn't better be controllable independently. It seems quite likely that a kernel may have an issue only with reads. Additionally I wonder whether it is a good idea to let these events go silently. > Note that this option is not made available to dom0. I'm not sure > whether it makes sense to do so, since anyone updating Xen to such > newer version will also likely pair it with a newish kernel that > doesn't require such workarounds. No, that's not an option imo. It was a Dom0 where I ran into the problem causing me to submit "x86/PV: conditionally avoid raising #GP for early guest MSR accesses". While I could upgrade that system, I have reasons for not doing so. And while I could put a more modern kernel on there, I'd prefer if the distro kernel continued to work. (That's leaving aside that for unrelated reasons building and using my own, newer kernel there is quite a bit more difficult than on all other of my test systems.) > RFC because there's still some debate as to how we should solve the > MSR issue, this is one possible way, but IMO we need to make a > decision soon-ish because of the release timeline. Generally I think it would be far better from a user pov if things worked out of the box, at least in cases where it can be made work. Arguably for Solaris this isn't going to be possible (leaving aside the non-option of fully returning back to original behavior), but for the old-Linux-PV case I still think my proposed change is better in this regard. I realize Andrew said (on irc) that this is making the behavior even weaker. I take a different perspective: Considering a guest will install exception handlers at some point, I continue to fail to see what good it will do to try to inject a #GP(0) when we know the guest will die because of not having a handler registered just yet. It is a kernel flaw, yes, but they ended up living with it merely because of our odd prior behavior, so we can't put all the blame on them. This isn't to say that I'm against propagating exceptions where there's no alternative to delivering one. Also I'm certainly open to further tighten the condition of when to zap such an exception (e.g. only as long as there's no handler _and_ the guest is still in UP mode, assuming of course this would still address the observed issue). > --- a/docs/man/xl.cfg.5.pod.in > +++ b/docs/man/xl.cfg.5.pod.in > @@ -2861,6 +2861,17 @@ No MCA capabilities in above list are enabled. > > =back > > +=item B > + > +Select whether to use the legacy behaviour for accesses to MSRs not explicitly > +handled by Xen instead of injecting a #GP to the guest. Such legacy access > +mode will force Xen to replicate the behaviour from the hardware it's currently > +running on in order to decide whether a #GP is injected to the guest. Note > +that the guest is never allowed access to unhandled MSRs, this option only > +changes whether a #GP might be injected or not. This description is appropriate for reads, but not for writes: Whether a write would fault can only be known by trying a write, yet for safety reasons we can't risk doing more than a read. An option might be to make writes fault is the to be written value differs from that which the probing read has returned (i.e. the same condition which originally had caused a log message to appear in 4.14 for PV guests). > --- a/tools/libs/light/libxl_types.idl > +++ b/tools/libs/light/libxl_types.idl > @@ -644,6 +644,8 @@ libxl_domain_build_info = Struct("domain_build_info",[ > ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), > ("vuart", libxl_vuart_type), > ])), > + ("arch_x86", Struct(None, [("msr_legacy_handling", libxl_defbool), > + ])), Seeing this I'm wondering whether the entire set of arch_* shouldn't be within a union. But afaics this would have further implications on code elsewhere, so surely wouldn't want doing right now. > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -852,6 +852,9 @@ int arch_domain_create(struct domain *d, > > domain_cpu_policy_changed(d); > > + d->arch.msr_legacy_handling = config->arch.domain_flags & > + XEN_X86_LEGACY_MSR_HANDLING; Somewhere you'd also need to refuse processing requests with any of the other 31 bits set. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 02 11:18:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 11:18:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92273.174105 (Exim 4.92) (envelope-from ) id 1lH32R-0007A8-CU; Tue, 02 Mar 2021 11:18:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92273.174105; Tue, 02 Mar 2021 11:18:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH32R-0007A1-8H; Tue, 02 Mar 2021 11:18:03 +0000 Received: by outflank-mailman (input) for mailman id 92273; Tue, 02 Mar 2021 11:18:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH32P-00079v-Np for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 11:18:01 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d78ab7d7-ab35-487d-8d8e-e2da07e68bfa; Tue, 02 Mar 2021 11:18:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d78ab7d7-ab35-487d-8d8e-e2da07e68bfa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614683880; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=1+3UQ8r09124ZiDtcgSdGhpoQNNN1AuuzpSWBpCoAGg=; b=ebn7Uml61M1CDLj8sMJBtPB4HU0l/Q+sUNHktfFK2ItHyK8DlRQnBDW7 76ASb1sDPtBFxUsy06A0JaUzs/7blj45KB4tXwS7+AXAiT8sBrZJAOwlk KdGf4DFZqRagt571ZRTPQ2K08amux9lk3Y0WbXQWCl9cSo6KenBUx9gy1 A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: kBAGlCPNB7DpegBl8LUtnmwHpjFU/zQmuX++L11Rh2ZdYCn/RnYTJbCRLlTUZT3Cc4AqjcITLy hLxY8H1xOV7nt8USP2bwpnBXcL+TpEBWdAA87bq4T+09DyuJ4ZKalzPXo4Y2m++LaHuc50/3wc P+7grxi+MTDcKWV1Lgw4emSxfxXQ4DRrSck0958QY6N1X/U9jRdZMS8cNkDFCT5RzPD/4p+BJk U9ERWcDgAujI4VMjdgywovUXbWOhlEddYnrF4FMMjiatmhfN5aqrrqnsyBfBe0Ur45iW0ch4by whU= X-SBRS: 5.2 X-MesageID: 38692060 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,216,1610427600"; d="scan'208";a="38692060" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D0vNL4CRtJqFbQtLicS9X1UmdVhrpPVT7BfkIllNwTsYdnbBCzgO6WNf9fogwQwpDxDKwlmetlRfDcTrIrA7RK2S3Vu9C7ItFJzSZ60GmxV8Wyv8VNhStVgPNq8ClJ98kR99sZO3rXdDYaP1G5Rv7TwRF+9VMdgNBjMoMZze8jFBUZ1yNWAa1oIr33NmrwTSExGSI7VxbWD/S9vNJD68DNPKKePQYfLmyxQEF2BXK99yUkJe8IyDkZu3dqFz0cbqkB+uFpIMB5JdfrAF3FFToLz+ozLJ9POplISQSllH3FKKKf3mn0tNbr12jt+gIkuAXvzfshs/P3LBCLpD0PI1nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1+3UQ8r09124ZiDtcgSdGhpoQNNN1AuuzpSWBpCoAGg=; b=JRHPn8C3+FiGrIWO8PssI3VMBEETyDxXCA7E/EbfI95L+nrB3CxMZgg9DGVJQX8cTdhm0X99BKdGoxawUSKdyI42NRwnJTzY858eU4VU+JZpg1uZ6CJWNVmqUmN5bTDmQ0uTDLWQounY5Fj7c8AvvfLD8xgpsVxf3DZpMAHSytH8uc4N7ZeeDb/sbULxhUSm0y/O/knPnkg7/qoQC7VibDiEHUXwuPWVdje1SpGXlpuu1wrvicOq/mFjGeLct48iiUj5GIxRLKmU07qNaxPmqHN/BDRDu2mexHG8ZG5be7rGxXdQSIvneNY8HY6Z8QV/zUrFx3uVooabgq5TLn+z4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1+3UQ8r09124ZiDtcgSdGhpoQNNN1AuuzpSWBpCoAGg=; b=aKdFcgXSa+r/16ZCXRFA2Zjtrt8PShg7NSAptrRTBxZhXNtrGNL2I6FAsDfjWScc1vM7HnhTOAhaKXvQIeygjaJmRIfpKH+rdIL80XRhBnEU/g0FIb8QFE+QfxaBPGpTtlNRBBeGBlL9X4Lzf0AmI+8wSYGGjuKD3G4skE0o73M= Subject: Re: [PATCH 2/3] tools/libs: Stash the 4.14 API/ABIs for the stable libraries To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Xen-devel CC: Ian Jackson , Wei Liu References: <20210301170044.23295-1-andrew.cooper3@citrix.com> <20210301170044.23295-3-andrew.cooper3@citrix.com> <677223c5-e661-a132-35b8-2e9424817c7b@suse.com> From: Andrew Cooper Message-ID: Date: Tue, 2 Mar 2021 11:17:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <677223c5-e661-a132-35b8-2e9424817c7b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0345.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::8) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ad030fb-31f1-4cd3-63b3-08d8dd6cd487 X-MS-TrafficTypeDiagnostic: BYAPR03MB3671: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rPmWq2H0bEyS7nXpQ9iGhv/7ZxISPjmfWz+aYe/jYEYF1QMzZ/5nicI3dLM0hxf15CjcraC5Manknqxfm8TxFjKASdu/Jct++WvRkly44oGljrvb8cs8+b5JwBcJJzBOdHhT7NvHVCrZbFssfpZqE6qhiPib9JhirkO/Mdm9D6GRW+EVyi+K84gJVRXKDoYZyac1ITzys4fA6EdeZcbExXjArHkjqboQ3nLxzvUHfckKWaMlUFHNGnu/Ylu5jr/0G9fq4q1ktXZXWULRw2kGbGzwf6Q38uJIiqKtxL3QKStfAfPqRi3O3UuDCbGOXukIBmOYVzenSJFl5EfQGfebbOsFowxXIokcDIhbgH9kIh4c3w13eVbWDYdfHAxSqdP+IdaeIdoPfStbby5qnRtjgIPY62N48PZzNluiJy2CvgNoPdtp0ux86CvaEfoLO10cYcVy+CQ3bdL6Ca3WWdG56fqMgJX9Vd5d5FmJ+JlEQqHhRz+tz9h6pUZXi3ksWGViEPRNRHmSsShEtXdgL9NJhtReTMzv6TJ2YmPDqLEkaan42x1idrw1iDcd25pxGIfcZis0pQ9oik2LV6gLS7HHZYu1QBCpRUBAJ3wmB5xctJs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(396003)(136003)(366004)(346002)(376002)(26005)(31696002)(4326008)(53546011)(110136005)(186003)(16526019)(8936002)(86362001)(5660300002)(16576012)(2616005)(956004)(316002)(6486002)(31686004)(478600001)(6666004)(2906002)(8676002)(36756003)(66556008)(66476007)(66946007)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bzduS21IVmIvV3FqNjFNTHJlODJnMDZoVGFhUXlZZnFDMWN0dWVHOVZwd2d3?= =?utf-8?B?dU1PK25yL3B5RkRPbU1XNjdzd2J3dmVnZldjQnBFSFNCT3ZJNi81Tmw3ZnYr?= =?utf-8?B?bHdBQlBiOWYwUDRRdFBPSHl5ZmRPelp6QWFrN1RweTZpdFB3VjdzSjlUeWg4?= =?utf-8?B?N3ZTVjFXK1psMjkwUVROWVJXMFdnQU1yL1YvUmFOUi92eXZMd3JKa0RGc2hj?= =?utf-8?B?bUVrN0dPb3hiQ1lvV0R4ckd1Zm1sVE9acFRxVTJxZ01KM1FjTzRJSS94V1Q4?= =?utf-8?B?Z1V0K0k4NlpHMTBTUUVLZFlSenpOMDd3RENNRXlqZGVCTGtibkhYT2xoRjhE?= =?utf-8?B?SE53aWM4VlIvanpPc0cxQlVlQXRMS3M1UjcrQlE2WWtSTWlGVFRoajZvQld2?= =?utf-8?B?bWlLT1R4RVlaQTY5dkVzRFgxSFBESExBRGpWTlptVTVJdi8vbVV2TmtDclI4?= =?utf-8?B?aTlXRzVtUitKMURZdUxsU2w0b1V6ZVBGNURhb0VnQWZ1M3hUWW9DUGlFMnFE?= =?utf-8?B?dGlRWjNsSTU0YndzUGF5d01jTFU2eHBkbVRweDVOQnJNUWNwcUFYY0xhUHFh?= =?utf-8?B?UUtJNUFmRzlzVHdldFoyMzdIODhsVWk1QlhEZ0Zua0FRVWE1b0U3dzlNbXJJ?= =?utf-8?B?VE9rUWZZR1hjYmpBQ0hTSTVKL0lQNFh3aTNwZS9uOWl6Z1lKUjFDRWhYV3I3?= =?utf-8?B?aGRHekUzcTZsTGxXbVZYS25yNExLWlluN2dMcmo4MlMxdm9QbVhVTUcyLysz?= =?utf-8?B?Vm9TTmREVzBMOWIxQ0ZKM0ErM1FqYXR6NUJoWFJwWndtNFN2OUtaRjcveTJl?= =?utf-8?B?cXptWkdhQlV5MktMSTRzVGdaSEllU29GSkNVdmJnVEhlMEltNTE0T0lLNGhk?= =?utf-8?B?TkR5SnRobjFVT1g3bXBEdWp1M3AyandUTjNESy80eHoxcm1BR0F2L2tic2du?= =?utf-8?B?ZGRSOFpGbGdlZWlWUTlTdzBEZDBvdUowdEpjb2pmTnRDTjFJWkY4enZmT3BH?= =?utf-8?B?WlErdlRtam4xcVZDeEpwRENlcDBoVndwRmNqaDAvbzYxK2RaSms3eWdBUXVN?= =?utf-8?B?R25wMEtOeUc4ZUc2RFVLakhTQmtQYUpYbkRTdTVaV1laRXVsZlNGUXloQk5O?= =?utf-8?B?UDh4akgzbldncEphRHlScUtSQ292bUxEL2p1WE1ZZURXTlU5UWhoRDVUcEdU?= =?utf-8?B?aSt6bms0eFJ6dDJ1UXFqeERDUnh3SFFqbVFBT0FXRDEwYnhMSWxacjJOZk1V?= =?utf-8?B?U3NIK0oya09JQ3R4Y25wbDJFUk1RWGEvQnlqK0UzdHZ1Z200eVFLeUZLZlJW?= =?utf-8?B?bFN1UVB6U3hJRElKYVJwTWhDRGJyNG9Gd0h0eFQvRGlFN2xzWGhxdU1FWk1W?= =?utf-8?B?ZGpOMjJlRmFoTEdXRGgrSHpSaGtQNk9tU2YrK2U3NnF1eG9wVDRCb0wzTXhC?= =?utf-8?B?bjBNVEFnWmh6U2ZzSnY3ZnVCWWxtdWpnWEhORWs3VUpHbk05WUlJWEpFRTFr?= =?utf-8?B?WFJ1R1lPcENQUGFQbjdtK2RNSGFWTU1KZWI4aWh4d1pET0NWUVJJbUJSQ0dM?= =?utf-8?B?eDF2RWZsVFhUUHJoMDlqMGhOSUlBWHBLUkZBekRlMys3MGZHRTVpM0lxaDUx?= =?utf-8?B?LzloVDUrK3Jwcjd3bmQwQXZaSnBhdi9PSVFlK0twc05FZHNhQm1kUC9tQ0Vl?= =?utf-8?B?Mzk0K0JrMG5qL0JDbTBzQUVUU29pRUlUV1V3RzlzQUt5dm1LeDR4REp2Sm1F?= =?utf-8?Q?Cj5OLN9bG4WKMSHj8yPUffnNuaORRzekCRp6wnf?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5ad030fb-31f1-4cd3-63b3-08d8dd6cd487 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2021 11:17:56.6463 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y6yvEREX3L7b/QRkFvmDVHCbKcSkAXN9ynF94mOxj7a0D41xkXpkz3uPUYrQMlPWFvuC222v1b/qO5sCgVbb820GgrzujmnLnXxyjM92ZCk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3671 X-OriginatorOrg: citrix.com On 02/03/2021 10:45, Jürgen Groß wrote: > On 01.03.21 18:00, Andrew Cooper wrote: >> These dumps were produced from the RELEASE-4.14.0 tag, with the >> abi-dumper >> tooling backported from staging. >> >> For each stable library, add a PKG_OLD_ABI variable pointing at the >> 4.14 ABI. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper >> --- >> CC: Ian Jackson >> CC: Wei Liu >> CC: Juergen Gross >> --- >>   tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump   |  924 +++++++++++ >>   .../abi/libxendevicemodel.so.1.3-x86_64-abi.dump   | 1491 >> +++++++++++++++++ >>   tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump |  719 ++++++++ >>   .../abi/libxenforeignmemory.so.1.3-x86_64-abi.dump |  847 ++++++++++ >>   tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump | 1199 >> ++++++++++++++ >>   tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump  |  597 +++++++ >>   .../libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump  | 1711 >> ++++++++++++++++++++ >>   .../libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump |  239 +++ >>   .../libs/abi/libxentoollog.so.1.0-x86_64-abi.dump  |  882 ++++++++++ >>   tools/libs/call/Makefile                           |    2 + >>   tools/libs/devicemodel/Makefile                    |    2 + >>   tools/libs/evtchn/Makefile                         |    2 + >>   tools/libs/foreignmemory/Makefile                  |    2 + >>   tools/libs/gnttab/Makefile                         |    2 + >>   tools/libs/hypfs/Makefile                          |    2 + >>   tools/libs/store/Makefile                          |    2 + >>   tools/libs/toolcore/Makefile                       |    2 + >>   tools/libs/toollog/Makefile                        |    2 + >>   18 files changed, 8627 insertions(+) >>   create mode 100644 tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump >>   create mode 100644 >> tools/libs/abi/libxendevicemodel.so.1.3-x86_64-abi.dump >>   create mode 100644 tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump >>   create mode 100644 >> tools/libs/abi/libxenforeignmemory.so.1.3-x86_64-abi.dump >>   create mode 100644 tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump >>   create mode 100644 tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump >>   create mode 100644 tools/libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump >>   create mode 100644 >> tools/libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump >>   create mode 100644 tools/libs/abi/libxentoollog.so.1.0-x86_64-abi.dump >> > >> diff --git a/tools/libs/call/Makefile b/tools/libs/call/Makefile >> index 4ed201b3b3..37a7db5395 100644 >> --- a/tools/libs/call/Makefile >> +++ b/tools/libs/call/Makefile >> @@ -11,4 +11,6 @@ SRCS-$(CONFIG_SunOS)   += solaris.c >>   SRCS-$(CONFIG_NetBSD)  += netbsd.c >>   SRCS-$(CONFIG_MiniOS)  += minios.c >>   +PKG_OLD_ABI = >> ../abi/libxen$(LIBNAME).so.1.2-$(XEN_TARGET_ARCH)-abi.dump >> + > > Any reason you don't add > > PKG_OLD_ABI = > ../abi/libxen$(LIBNAME).so.$(MAJOR).$(MINOR)-$(XEN_TARGET_ARCH)-abi.dump > > to tools/libs/libs.mk, maybe with some way to override/disable the > setting (e.g. by setting a different value for PKG_OLD_ABI just > after including $(XEN_ROOT)/tools/libs/libs.mk) ? The problem is with libraries which have changed in staging, where $MINOR differs by 1.  I chose not to wildcard in ../abi/ to reduce the chance of picking up the wrong ABI to check against. Something needs to be a statement of which is the appropriate $MINOR to use, and it shouldn't be the change to bump the soname, as that is a change we want to be tested. (That said, I'm actually struggling to get abi-compliance-checker to catch all the things it ought to catch.  Its better than nothing, but has some shortcomings.) > You could even disable the ABI check if there is no map file > provided, which will be the case for all the unstable libs. That would be nice, but I don't see any way to do it. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Mar 02 11:18:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 11:18:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92276.174116 (Exim 4.92) (envelope-from ) id 1lH33A-0007Fu-LY; Tue, 02 Mar 2021 11:18:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92276.174116; Tue, 02 Mar 2021 11:18:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH33A-0007Fn-IW; Tue, 02 Mar 2021 11:18:48 +0000 Received: by outflank-mailman (input) for mailman id 92276; Tue, 02 Mar 2021 11:18:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH339-0007Fh-2W for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 11:18:47 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0a60a581-d842-4e71-9d19-8237bb75449b; Tue, 02 Mar 2021 11:18:46 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BACC3ABF4; Tue, 2 Mar 2021 11:18:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a60a581-d842-4e71-9d19-8237bb75449b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614683925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ZZglwz4ylrWmHpmpqth6+F07GG7xvHr4x3S8gM8slw=; b=I/nR6SiTPKIHtpA9zHOsjzmm/vO8PD7KIQV2bKeah+BxX0T8938h6FAth6o6l9hhHwHcYU qf2AT1XoYeib0ui5GCteXBngmwc7P7U9tGNXHrNvMM+wCKpHK3rGlXLDQmN2EeGrZPgiOw L6+fB1BcsnyUrNCZb2SIa4jdmSwovRM= Subject: Re: [PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1 To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , George Dunlap , Ian Jackson References: <1d8d5089-32a9-9c42-5949-8f9cd20f33e0@suse.com> <9b0a5689-fced-d986-3bfb-9ade47cf3635@suse.com> From: Jan Beulich Message-ID: <638c8ff4-d853-69b1-a6a0-1778b342ac8f@suse.com> Date: Tue, 2 Mar 2021 12:18:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 02.03.2021 11:57, Roger Pau Monné wrote: > On Tue, Mar 02, 2021 at 10:59:37AM +0100, Jan Beulich wrote: >> On 01.03.2021 19:00, Roger Pau Monné wrote: >>> On Mon, Mar 01, 2021 at 04:14:26PM +0100, Jan Beulich wrote: >>>> On 01.03.2021 15:01, Roger Pau Monné wrote: >>>>> On Mon, Mar 01, 2021 at 09:31:07AM +0100, Jan Beulich wrote: >>>>>> In this case the compiler is recognizing that no valid array indexes >>>>>> remain (in x2apic_cluster()'s access to per_cpu(cpu_2_logical_apicid, >>>>>> ...)), but oddly enough isn't really consistent about the checking it >>>>>> does (see the code comment). >>>>> >>>>> I assume this is because of the underlying per_cpu access to >>>>> __per_cpu_offset using cpu as the index, in which case wouldn't it be >>>>> better to place the BUG_ON there? >>>> >>>> Not sure, to be honest. It seemed more logical to me to place it >>>> next to where the issue is. >>> >>> I'm not sure whether I would prefer to place it in per_cpu directly to >>> avoid similar issues popping up in other parts of the code in the >>> future? >> >> That's going to be a lot of BUG_ON(), and hence a lot of "ud2" >> instances. Not something I'm keen on having. The more that it's >> not the per_cpu() which triggers the warning, but separate >> conditionals allowing the compiler to deduce value ranges of >> variables. > > Right. I don't see much other way around this then. Did you check with > clang also? No, I didn't. But if anything it would require further additions, surely no less. > Acked-by: Roger Pau Monné Thanks. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 02 11:21:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 11:21:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92279.174129 (Exim 4.92) (envelope-from ) id 1lH35q-0008Hv-3v; Tue, 02 Mar 2021 11:21:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92279.174129; Tue, 02 Mar 2021 11:21:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH35q-0008Ho-0i; Tue, 02 Mar 2021 11:21:34 +0000 Received: by outflank-mailman (input) for mailman id 92279; Tue, 02 Mar 2021 11:21:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH35o-0008Hj-M8 for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 11:21:32 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ecd13e1a-7d21-47bb-a6c8-f3c728b2b81e; Tue, 02 Mar 2021 11:21:31 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F2C33AAC5; Tue, 2 Mar 2021 11:21:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecd13e1a-7d21-47bb-a6c8-f3c728b2b81e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614684091; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sGPAB5S61zjztiSLu+LQA71756ntUrrWCIg+SgnA3Tc=; b=mrsC1cQVk2HmAz1AXDOUGa2m0Iggt6epMpS8evOhshj5oydgMKgPqXthGK0bIkcLZIfWVD pWTLefWAy6C/12bXmu6oMrWX4U9n5zaj9x/UTzLuspxMHA0hOKtxpWNOoeHmU3a2LG+utT KIhwUcqhfN64mC+iZuz7EhZuzLaS17A= Subject: Re: [PATCH 2/3] tools/libs: Stash the 4.14 API/ABIs for the stable libraries To: Andrew Cooper Cc: Ian Jackson , Wei Liu , Xen-devel , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= References: <20210301170044.23295-1-andrew.cooper3@citrix.com> <20210301170044.23295-3-andrew.cooper3@citrix.com> <677223c5-e661-a132-35b8-2e9424817c7b@suse.com> From: Jan Beulich Message-ID: Date: Tue, 2 Mar 2021 12:21:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 02.03.2021 12:17, Andrew Cooper wrote: > On 02/03/2021 10:45, Jürgen Groß wrote: >> On 01.03.21 18:00, Andrew Cooper wrote: >>> These dumps were produced from the RELEASE-4.14.0 tag, with the >>> abi-dumper >>> tooling backported from staging. >>> >>> For each stable library, add a PKG_OLD_ABI variable pointing at the >>> 4.14 ABI. >>> >>> No functional change. >>> >>> Signed-off-by: Andrew Cooper >>> --- >>> CC: Ian Jackson >>> CC: Wei Liu >>> CC: Juergen Gross >>> --- >>>   tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump   |  924 +++++++++++ >>>   .../abi/libxendevicemodel.so.1.3-x86_64-abi.dump   | 1491 >>> +++++++++++++++++ >>>   tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump |  719 ++++++++ >>>   .../abi/libxenforeignmemory.so.1.3-x86_64-abi.dump |  847 ++++++++++ >>>   tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump | 1199 >>> ++++++++++++++ >>>   tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump  |  597 +++++++ >>>   .../libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump  | 1711 >>> ++++++++++++++++++++ >>>   .../libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump |  239 +++ >>>   .../libs/abi/libxentoollog.so.1.0-x86_64-abi.dump  |  882 ++++++++++ >>>   tools/libs/call/Makefile                           |    2 + >>>   tools/libs/devicemodel/Makefile                    |    2 + >>>   tools/libs/evtchn/Makefile                         |    2 + >>>   tools/libs/foreignmemory/Makefile                  |    2 + >>>   tools/libs/gnttab/Makefile                         |    2 + >>>   tools/libs/hypfs/Makefile                          |    2 + >>>   tools/libs/store/Makefile                          |    2 + >>>   tools/libs/toolcore/Makefile                       |    2 + >>>   tools/libs/toollog/Makefile                        |    2 + >>>   18 files changed, 8627 insertions(+) >>>   create mode 100644 tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump >>>   create mode 100644 >>> tools/libs/abi/libxendevicemodel.so.1.3-x86_64-abi.dump >>>   create mode 100644 tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump >>>   create mode 100644 >>> tools/libs/abi/libxenforeignmemory.so.1.3-x86_64-abi.dump >>>   create mode 100644 tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump >>>   create mode 100644 tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump >>>   create mode 100644 tools/libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump >>>   create mode 100644 >>> tools/libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump >>>   create mode 100644 tools/libs/abi/libxentoollog.so.1.0-x86_64-abi.dump >>> >> >>> diff --git a/tools/libs/call/Makefile b/tools/libs/call/Makefile >>> index 4ed201b3b3..37a7db5395 100644 >>> --- a/tools/libs/call/Makefile >>> +++ b/tools/libs/call/Makefile >>> @@ -11,4 +11,6 @@ SRCS-$(CONFIG_SunOS)   += solaris.c >>>   SRCS-$(CONFIG_NetBSD)  += netbsd.c >>>   SRCS-$(CONFIG_MiniOS)  += minios.c >>>   +PKG_OLD_ABI = >>> ../abi/libxen$(LIBNAME).so.1.2-$(XEN_TARGET_ARCH)-abi.dump >>> + >> >> Any reason you don't add >> >> PKG_OLD_ABI = >> ../abi/libxen$(LIBNAME).so.$(MAJOR).$(MINOR)-$(XEN_TARGET_ARCH)-abi.dump >> >> to tools/libs/libs.mk, maybe with some way to override/disable the >> setting (e.g. by setting a different value for PKG_OLD_ABI just >> after including $(XEN_ROOT)/tools/libs/libs.mk) ? > > The problem is with libraries which have changed in staging, where > $MINOR differs by 1.  I chose not to wildcard in ../abi/ to reduce the > chance of picking up the wrong ABI to check against. > > Something needs to be a statement of which is the appropriate $MINOR to > use, and it shouldn't be the change to bump the soname, as that is a > change we want to be tested. Introduce OLD_MINOR or ABI_OLD_MINOR? Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 02 11:26:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 11:26:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92282.174141 (Exim 4.92) (envelope-from ) id 1lH3Ad-0008S9-NO; Tue, 02 Mar 2021 11:26:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92282.174141; Tue, 02 Mar 2021 11:26:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH3Ad-0008S2-KK; Tue, 02 Mar 2021 11:26:31 +0000 Received: by outflank-mailman (input) for mailman id 92282; Tue, 02 Mar 2021 11:26:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH3Ab-0008Rx-Cs for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 11:26:29 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b3a6ae94-4311-4399-9aa7-bacb8a530588; Tue, 02 Mar 2021 11:26:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3a6ae94-4311-4399-9aa7-bacb8a530588 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614684388; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=6FinklHekSRnE/OkXoVhmc5CQrTHXKLzB4oIVOIqNLg=; b=F3z4jXel6cK2WLxfhSQ7Je0z56QvP4gqkAWSjN5uxGPYH+D/uqiZ32YC /9l6rmhyYdf54oQSh413sNJsVuMzURXGNiwEdu9tuP4Nr9wWiiH6xz2TQ 9tnhp3eDGsVz0Irq6Ocl4F3aigq2c5Pe1uIg03LLizAoK01UQ/8vqA4y7 o=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: epuHac8kzC4q49WAiQLeTtQg5uewIRm4b3KIi0pAaWERrtnfkEoZI49l+5w05M0cioi0jGdvt9 l189lKLc6VXaMYK7usb4+1YYTLoa29qh2xDzUq+p4lFhy2ulEe9bJtUq2YlXhxRF8JbaeF09oL JkwJMAz1/CZKeVbSUEKp5+6DEem8jiqfdiG2Uj0HzoDA/PfJSxlM5jgVmPvxSucRQykgyqxmFZ pksY14ZhzqLf3mCWEvizQkup6KLqOktQ0/rP41Lhhx7j9xOo1qlkt7lusZCpGtS/Wtas/aX1Wd O6o= X-SBRS: 5.2 X-MesageID: 38315656 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,216,1610427600"; d="scan'208";a="38315656" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WGrjQV+j6n1aCRNDVNAsJXbj1spCkS2Y2npranEp1jjT9sMRCLE/3DVpq9ytUYsz5GAQMJc5N6ENsmvl6AiAUJicXigyFkJdlQolduU0TeSRyW7EIhyx7r9llWxAwgua7fiMZB+vbTFvuw8g2frf2hUFyffVuylPatNXSdqNAYQB7TYWfGnFdc6K7LsGfKQ9GC+0s61NbZ0bzlVn2wz9CYIxBiwX4uD+DE1E2UC2t27LVz2B4a44EI9cYcV6DQFfbQs65jYcE9Qr4TYIHRcT/fiJs2wW0/tG9LRuoIhMdKxDTnrG6ZBOYjP1ypkbwQTz6FPbTeje9zcyqeKQQfBjGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6FinklHekSRnE/OkXoVhmc5CQrTHXKLzB4oIVOIqNLg=; b=Lsp1i6xW9fgfdfXDbBSS91/B2643oppbBZhGFaRTArFAELf0k7RxBGZexzj3iqiEPK9o1xYvq43T3GueKKieOr27wxFFGPBoHla9vLxc+3Sj6K5/4LvExZEH/Gw8OvwgDuKFJH686Rdvm2aj3mvkVt6lZM003LITpNP6Q1Gv8VD/aKG5pvTUFpF+i0zBFZVOikMs+nINJRugpuPpu03QIQ7aQagrD9o6eqQk84uS36zUjOG3YTolhrR7eRvy6WX087ao26QaJ0/imHRdT+mg1Cguh/iSOWrtF1kdHhzd6IF5njD/wczRE6HJG6AoL2d2J7NCoCxQdsOQZozozjfAsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6FinklHekSRnE/OkXoVhmc5CQrTHXKLzB4oIVOIqNLg=; b=v9sx1GkFp23lUL6QwTQytq6dOiMyDGSRBWq0pGZxm2c2WUdiaLHsXRU3kSjnZ7Hc6LCcJGhsSx7RqHCh31aCQUwPOqDqM912HXUxJW9lZxoZ7QN2v2Yg6mwZbEH/7KeN+xx9cMBVu/EGPYO0oM4dxyCgIlIT0AD1/Lz8kNYLiTs= Subject: Re: [PATCH 2/3] tools/libs: Stash the 4.14 API/ABIs for the stable libraries To: Jan Beulich CC: Ian Jackson , Wei Liu , Xen-devel , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= References: <20210301170044.23295-1-andrew.cooper3@citrix.com> <20210301170044.23295-3-andrew.cooper3@citrix.com> <677223c5-e661-a132-35b8-2e9424817c7b@suse.com> From: Andrew Cooper Message-ID: Date: Tue, 2 Mar 2021 11:26:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0119.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::35) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef37f3a6-31fe-4ecc-3b71-08d8dd6e0376 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5949: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VG7xLMii1q0b48FSYpPM5dGe/MYxbIOENnx0JD2QUAFOXoRcUPYCIejCjoYnUPW8vdpB7i41njNFYvgK/41EAGj0e0F3HjuB6FKm7FjUsPBo/U9yfqrPV6K5YvYAQz5fqTGo6SZxYRrkHwyjc0aVr8+ia9Q+L4t7uwsFTzqleuPylIta/1pDkNlx6a9G2HyjlRXDcjbwyks+pyEnWJ93Mk/61ln067lRhvDmsJ2oxRGa9yllukU8oyKPiW4GD7DzXS+SCq/2LAkp9ieC1A3yi3QQt2eS00z1pr7ku11WoiGqYrRz3vfTwvfaI2zgB9gSDZYUlEnbrdcqsuU704l8f0C7LjJAWShhCh/5JujvgepaxSpEQdAq+K85q1oJJRzLRtKi4SH2OizFbyZPmtK1YIP8qKdAHoLcMbBlkwwdC0wUSFs3kLbrUhleO3Zj1HTQezo7WQ9wUOSeYX/0myXkrb8uW8ThoUO1UCwHC+OPUABNDqsUQSdzOiZ0aCEtqYU8IrUzhtUw/BKdeXoZ/AI8iiBfIzBPmARuxx18p5Y019G/1/vZg7e3phddA6A8xj6d9xe0/EnTdi2Xl3vMTBtCzOaAC98jZx4ypnQrJV8u008= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(136003)(39860400002)(396003)(346002)(53546011)(31686004)(5660300002)(2616005)(4326008)(31696002)(36756003)(956004)(6666004)(26005)(86362001)(54906003)(6486002)(6916009)(8936002)(16526019)(316002)(8676002)(66556008)(478600001)(2906002)(66476007)(66946007)(186003)(16576012)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?V1hJbUxaQlhBTEd3YTFMeEJIWTAzZyt2TGgxQzc4dnFmQVBIaWlKTVNXRE9P?= =?utf-8?B?UUQwT0J1eDROSkhoNWVNcnVwbUo1MXBSb2Q0ZXVxL2lkTFB4eFk4MTBpNU84?= =?utf-8?B?Mzl2NVRVbThMbEYyalRkK3FtR3g5c2VEdlVycG1icFBHSVhaK1BTeGhIOVFS?= =?utf-8?B?Nkp0Z0ZtbFFYejJzR0s4WllDMUpUSktyVElwdUxOaHpXR01sZHpyUEVaZERp?= =?utf-8?B?TnFUb1Mrc05WdEIzeG5IdnZyQjVVZlB1Z0Q5M3FkMDZZamF3V1I3MDdjVVRB?= =?utf-8?B?eE8vNDdvcmZ4SjJ0Z0I3NWF3cWFDSlVUSHEyUDZ1N0hWY3NoUVREeVFVcm4z?= =?utf-8?B?d2g0TUE2OXp4QUJXUU9MVnJ3YXM3dFB4NGhUMDBvTWdWSlNnYUYxV1hQVGNQ?= =?utf-8?B?c0tBQ1RNUE1YT1dXb2I1ZFY1VVA4T3BFbDZmOHduancvSDlqWFljbWd1UlIr?= =?utf-8?B?ek5NQlRxUDFXcGtiaUFJTUo4WnFzVFJRN01qMkk2T3Q5UUdSR29KaFVEUWlT?= =?utf-8?B?VVU5eHB0V1ZKQWl2SHRzNS92S2F3R1pPeStXeHVpdy9NWXFrY0Vrdm1hZDFr?= =?utf-8?B?STJjQldGc2JqOFhaeWxHWFhGdkVzYWJkSWVyS2FRNVZTNWYxNjRwdnRIL2ox?= =?utf-8?B?WENka0pDMkNYSTZ2ZEJpczdUamgwTU11bmd0aEpGekgzczdtRkNtRkphb3pv?= =?utf-8?B?K0RuQjlrNzZ3TFBLNi91TDgyWHcyTnAzdTNCTUV0a1NKRU84enhLOGhUMFB3?= =?utf-8?B?enVGTWtveTBVcWFhVjhGTE5HT040L285d1JSVmt0dUZuRDBTTjBkbjdzekla?= =?utf-8?B?MG82ZTlPbDBBS1hPc0xTaWNqaVFPSURldkxWbGZlbUcwS0NPekd6VXkyeVNl?= =?utf-8?B?U1pGQVBPK21YeXZWampPWEJGbE4rSlowQ1VRN1g5QVdTY3lYaCs5SWdZZkJx?= =?utf-8?B?VU05TUxmSkFVS0VPNllqUXRCbTloMXdFM2lQRkJHbVBlZi8xUzcvaDlyMUN0?= =?utf-8?B?QnNGYVRYT3VkTDEwR3dNMyt3VTdYVWZCOTRHRldQejRBQWE3WjdvK3EwK2FC?= =?utf-8?B?R3JYL3VmU2JodUFzdWMyejJKNDh1TjIyT0pzN01GRFQ0RjVndFMzWEJxMnVD?= =?utf-8?B?c3E2aVN4eGFWeWZZN2IrZk5Ga3FaUXZpUmJ6c3NIY2pXbHFZWXdpaHVIT2JB?= =?utf-8?B?TThaTmpleDdycU1EcTBzRjFicGJxT0FBRTdzdW94NENhSndqcmVDbnMxS0ha?= =?utf-8?B?TExUR1hvQmVMblpyTnZXd29FNDQ4dGFlUzZ3UjFjVzlKekJJSVNiWXlSMXdz?= =?utf-8?B?eWQ1OU8xMHQ5Und4Z05OOXdsSGxGbmJLcHhGQkNIb3UxczJFeElsell0WDBU?= =?utf-8?B?WEo2TnZ5ZHJjUWdVdUs4WVNIN3NYM1lTdmRLd0M4Q2RLTVIvL0tQOThSVnl4?= =?utf-8?B?dkF3bCtpMitra1VObDZzQTBzdzJweWhqVjFoRzh5U0t5UG5aUDNqNzhvaXVC?= =?utf-8?B?VWpNays3Rm9NNnJ1Tm9zdWtQNll5cXg5VEZpM3lvdXhlNnN5eXVVendGejUw?= =?utf-8?B?ck12UUN5a01vTFc3eUMrREhlSFVId0xXdWtJc2twOTJFbUpaUGxqWUdhYWJn?= =?utf-8?B?U3NpMWdVVU52V05paHoxZnJ4cGV1bnBLUXlLb3k5M1Z1ektrQWdSY3cxQnU5?= =?utf-8?B?MGNkTkxhbGUvYUs2WWs4OTJPQjUrUlh1eEZHUTJGTU82TU1BdHFMTjVlcUJG?= =?utf-8?Q?ZcDnaomoSc3mbFTia7VfSVPB/B21BG6aSwijmn+?= X-MS-Exchange-CrossTenant-Network-Message-Id: ef37f3a6-31fe-4ecc-3b71-08d8dd6e0376 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2021 11:26:24.9505 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MIEcmdAlq2jaKBYlEgxHPn6vnLk37zuq8W9G09oRO30YHx/YK/APFs2bAI+KJR+mFzm0Hu4qKppTVEt1wAAWx+2VvVp2OI5u3n4JiPerdzg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5949 X-OriginatorOrg: citrix.com On 02/03/2021 11:21, Jan Beulich wrote: > On 02.03.2021 12:17, Andrew Cooper wrote: >> On 02/03/2021 10:45, Jürgen Groß wrote: >>> On 01.03.21 18:00, Andrew Cooper wrote: >>>> These dumps were produced from the RELEASE-4.14.0 tag, with the >>>> abi-dumper >>>> tooling backported from staging. >>>> >>>> For each stable library, add a PKG_OLD_ABI variable pointing at the >>>> 4.14 ABI. >>>> >>>> No functional change. >>>> >>>> Signed-off-by: Andrew Cooper >>>> --- >>>> CC: Ian Jackson >>>> CC: Wei Liu >>>> CC: Juergen Gross >>>> --- >>>>   tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump   |  924 +++++++++++ >>>>   .../abi/libxendevicemodel.so.1.3-x86_64-abi.dump   | 1491 >>>> +++++++++++++++++ >>>>   tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump |  719 ++++++++ >>>>   .../abi/libxenforeignmemory.so.1.3-x86_64-abi.dump |  847 ++++++++++ >>>>   tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump | 1199 >>>> ++++++++++++++ >>>>   tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump  |  597 +++++++ >>>>   .../libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump  | 1711 >>>> ++++++++++++++++++++ >>>>   .../libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump |  239 +++ >>>>   .../libs/abi/libxentoollog.so.1.0-x86_64-abi.dump  |  882 ++++++++++ >>>>   tools/libs/call/Makefile                           |    2 + >>>>   tools/libs/devicemodel/Makefile                    |    2 + >>>>   tools/libs/evtchn/Makefile                         |    2 + >>>>   tools/libs/foreignmemory/Makefile                  |    2 + >>>>   tools/libs/gnttab/Makefile                         |    2 + >>>>   tools/libs/hypfs/Makefile                          |    2 + >>>>   tools/libs/store/Makefile                          |    2 + >>>>   tools/libs/toolcore/Makefile                       |    2 + >>>>   tools/libs/toollog/Makefile                        |    2 + >>>>   18 files changed, 8627 insertions(+) >>>>   create mode 100644 tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump >>>>   create mode 100644 >>>> tools/libs/abi/libxendevicemodel.so.1.3-x86_64-abi.dump >>>>   create mode 100644 tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump >>>>   create mode 100644 >>>> tools/libs/abi/libxenforeignmemory.so.1.3-x86_64-abi.dump >>>>   create mode 100644 tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump >>>>   create mode 100644 tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump >>>>   create mode 100644 tools/libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump >>>>   create mode 100644 >>>> tools/libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump >>>>   create mode 100644 tools/libs/abi/libxentoollog.so.1.0-x86_64-abi.dump >>>> >>>> diff --git a/tools/libs/call/Makefile b/tools/libs/call/Makefile >>>> index 4ed201b3b3..37a7db5395 100644 >>>> --- a/tools/libs/call/Makefile >>>> +++ b/tools/libs/call/Makefile >>>> @@ -11,4 +11,6 @@ SRCS-$(CONFIG_SunOS)   += solaris.c >>>>   SRCS-$(CONFIG_NetBSD)  += netbsd.c >>>>   SRCS-$(CONFIG_MiniOS)  += minios.c >>>>   +PKG_OLD_ABI = >>>> ../abi/libxen$(LIBNAME).so.1.2-$(XEN_TARGET_ARCH)-abi.dump >>>> + >>> Any reason you don't add >>> >>> PKG_OLD_ABI = >>> ../abi/libxen$(LIBNAME).so.$(MAJOR).$(MINOR)-$(XEN_TARGET_ARCH)-abi.dump >>> >>> to tools/libs/libs.mk, maybe with some way to override/disable the >>> setting (e.g. by setting a different value for PKG_OLD_ABI just >>> after including $(XEN_ROOT)/tools/libs/libs.mk) ? >> The problem is with libraries which have changed in staging, where >> $MINOR differs by 1.  I chose not to wildcard in ../abi/ to reduce the >> chance of picking up the wrong ABI to check against. >> >> Something needs to be a statement of which is the appropriate $MINOR to >> use, and it shouldn't be the change to bump the soname, as that is a >> change we want to be tested. > Introduce OLD_MINOR or ABI_OLD_MINOR? That's not bisectable if it isn't in the changeset which bumps the soname. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Mar 02 11:38:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 11:38:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92289.174161 (Exim 4.92) (envelope-from ) id 1lH3Lq-0001Aj-2a; Tue, 02 Mar 2021 11:38:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92289.174161; Tue, 02 Mar 2021 11:38:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH3Lp-0001Ac-VP; Tue, 02 Mar 2021 11:38:05 +0000 Received: by outflank-mailman (input) for mailman id 92289; Tue, 02 Mar 2021 11:38:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH3Lo-0001AX-Vs for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 11:38:05 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 11dd1e75-bba0-45c2-b88f-de2031be9196; Tue, 02 Mar 2021 11:38:03 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F423FAAC5; Tue, 2 Mar 2021 11:38:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11dd1e75-bba0-45c2-b88f-de2031be9196 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614685083; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R328YbjKRhvm6UTdxCFfC4dyum1um6fW9vGE8Zeqb+I=; b=ReK53fbFTavXNxq7tHAwsHybQ76JFCQRWONXYiPXDTBj0UcE2EEjZTyVDaK5AoeNzBKE5V YbFmMJvTJLng+jA5A2vxpkj5VkGac8Gbxn38VZCNt0P9qo7lwS5A4F0Qs7aknZfxmLoEqn Js1Ghbu4b9uQ2r/h8fPL7AEddDti+lg= Subject: Re: [PATCH 2/3] tools/libs: Stash the 4.14 API/ABIs for the stable libraries To: Andrew Cooper Cc: Ian Jackson , Wei Liu , Xen-devel , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= References: <20210301170044.23295-1-andrew.cooper3@citrix.com> <20210301170044.23295-3-andrew.cooper3@citrix.com> <677223c5-e661-a132-35b8-2e9424817c7b@suse.com> From: Jan Beulich Message-ID: <241f7ac5-2ba4-d0e6-32e9-5b327d56f6ca@suse.com> Date: Tue, 2 Mar 2021 12:38:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 02.03.2021 12:26, Andrew Cooper wrote: > On 02/03/2021 11:21, Jan Beulich wrote: >> On 02.03.2021 12:17, Andrew Cooper wrote: >>> On 02/03/2021 10:45, Jürgen Groß wrote: >>>> On 01.03.21 18:00, Andrew Cooper wrote: >>>>> These dumps were produced from the RELEASE-4.14.0 tag, with the >>>>> abi-dumper >>>>> tooling backported from staging. >>>>> >>>>> For each stable library, add a PKG_OLD_ABI variable pointing at the >>>>> 4.14 ABI. >>>>> >>>>> No functional change. >>>>> >>>>> Signed-off-by: Andrew Cooper >>>>> --- >>>>> CC: Ian Jackson >>>>> CC: Wei Liu >>>>> CC: Juergen Gross >>>>> --- >>>>>   tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump   |  924 +++++++++++ >>>>>   .../abi/libxendevicemodel.so.1.3-x86_64-abi.dump   | 1491 >>>>> +++++++++++++++++ >>>>>   tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump |  719 ++++++++ >>>>>   .../abi/libxenforeignmemory.so.1.3-x86_64-abi.dump |  847 ++++++++++ >>>>>   tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump | 1199 >>>>> ++++++++++++++ >>>>>   tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump  |  597 +++++++ >>>>>   .../libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump  | 1711 >>>>> ++++++++++++++++++++ >>>>>   .../libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump |  239 +++ >>>>>   .../libs/abi/libxentoollog.so.1.0-x86_64-abi.dump  |  882 ++++++++++ >>>>>   tools/libs/call/Makefile                           |    2 + >>>>>   tools/libs/devicemodel/Makefile                    |    2 + >>>>>   tools/libs/evtchn/Makefile                         |    2 + >>>>>   tools/libs/foreignmemory/Makefile                  |    2 + >>>>>   tools/libs/gnttab/Makefile                         |    2 + >>>>>   tools/libs/hypfs/Makefile                          |    2 + >>>>>   tools/libs/store/Makefile                          |    2 + >>>>>   tools/libs/toolcore/Makefile                       |    2 + >>>>>   tools/libs/toollog/Makefile                        |    2 + >>>>>   18 files changed, 8627 insertions(+) >>>>>   create mode 100644 tools/libs/abi/libxencall.so.1.2-x86_64-abi.dump >>>>>   create mode 100644 >>>>> tools/libs/abi/libxendevicemodel.so.1.3-x86_64-abi.dump >>>>>   create mode 100644 tools/libs/abi/libxenevtchn.so.1.1-x86_64-abi.dump >>>>>   create mode 100644 >>>>> tools/libs/abi/libxenforeignmemory.so.1.3-x86_64-abi.dump >>>>>   create mode 100644 tools/libs/abi/libxengnttab.so.1.2-x86_64-abi.dump >>>>>   create mode 100644 tools/libs/abi/libxenhypfs.so.1.0-x86_64-abi.dump >>>>>   create mode 100644 tools/libs/abi/libxenstore.so.3.0.3-x86_64-abi.dump >>>>>   create mode 100644 >>>>> tools/libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump >>>>>   create mode 100644 tools/libs/abi/libxentoollog.so.1.0-x86_64-abi.dump >>>>> >>>>> diff --git a/tools/libs/call/Makefile b/tools/libs/call/Makefile >>>>> index 4ed201b3b3..37a7db5395 100644 >>>>> --- a/tools/libs/call/Makefile >>>>> +++ b/tools/libs/call/Makefile >>>>> @@ -11,4 +11,6 @@ SRCS-$(CONFIG_SunOS)   += solaris.c >>>>>   SRCS-$(CONFIG_NetBSD)  += netbsd.c >>>>>   SRCS-$(CONFIG_MiniOS)  += minios.c >>>>>   +PKG_OLD_ABI = >>>>> ../abi/libxen$(LIBNAME).so.1.2-$(XEN_TARGET_ARCH)-abi.dump >>>>> + >>>> Any reason you don't add >>>> >>>> PKG_OLD_ABI = >>>> ../abi/libxen$(LIBNAME).so.$(MAJOR).$(MINOR)-$(XEN_TARGET_ARCH)-abi.dump >>>> >>>> to tools/libs/libs.mk, maybe with some way to override/disable the >>>> setting (e.g. by setting a different value for PKG_OLD_ABI just >>>> after including $(XEN_ROOT)/tools/libs/libs.mk) ? >>> The problem is with libraries which have changed in staging, where >>> $MINOR differs by 1.  I chose not to wildcard in ../abi/ to reduce the >>> chance of picking up the wrong ABI to check against. >>> >>> Something needs to be a statement of which is the appropriate $MINOR to >>> use, and it shouldn't be the change to bump the soname, as that is a >>> change we want to be tested. >> Introduce OLD_MINOR or ABI_OLD_MINOR? > > That's not bisectable if it isn't in the changeset which bumps the soname. Setting OLD_MINOR isn't tied to bumping of the soname, is it? Instead I thought it would be part of the release process, i.e. for every stable library OLD_MINOR would latch the value of the present MINOR at the same time as the previous version's dumps get installed, and maybe also at the same time as the Xen version gets bumped (and the tree re-opened). You said you didn't use wildcards - are you intending to have more than a single prior version's dumps to be in the tree? Otherwise it would seem to me that wildcard use could be precisely the way to avoid having to record the old MINOR anywhere (else). Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 02 12:00:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 12:00:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92295.174172 (Exim 4.92) (envelope-from ) id 1lH3hc-0004BI-DZ; Tue, 02 Mar 2021 12:00:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92295.174172; Tue, 02 Mar 2021 12:00:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH3hc-0004BB-Ac; Tue, 02 Mar 2021 12:00:36 +0000 Received: by outflank-mailman (input) for mailman id 92295; Tue, 02 Mar 2021 12:00:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH3hb-0004B2-Mu; Tue, 02 Mar 2021 12:00:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH3hb-00040m-Dy; Tue, 02 Mar 2021 12:00:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH3hb-0002CB-0q; Tue, 02 Mar 2021 12:00:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lH3hb-0002Fh-0L; Tue, 02 Mar 2021 12:00:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/ZgKykD1uYbvnywinc5XsnKUQFbsFzc2e0h0goUlZAw=; b=VrQth65QWeFZUoyhJeDa1Umuzs AVSRr8PiAwfc7DLzDT0UMR6DjE4KDMP8kR4Fcn1a/5HaSNyc8K9io+DdM51GwaRF3UIe2K1F9a6i5 7TdjIos8RzDLKzZOXsh9NHjrjOz+Bgf8xiuw2sIU6moLB6dFSVqQQDL2L/PrwWXewKXo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159796: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=51db2d7cf26d05a961ec0ee0eb773594b32cc4a1 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Tue, 02 Mar 2021 12:00:35 +0000 flight 159796 qemu-mainline real [real] flight 159803 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159796/ http://logs.test-lab.xenproject.org/osstest/logs/159803/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 51db2d7cf26d05a961ec0ee0eb773594b32cc4a1 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 194 days Failing since 152659 2020-08-21 14:07:39 Z 192 days 372 attempts Testing same since 159700 2021-02-26 08:46:59 Z 4 days 8 attempts ------------------------------------------------------------ 428 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 117941 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 02 12:14:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 12:14:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92310.174187 (Exim 4.92) (envelope-from ) id 1lH3ub-0005OS-Kt; Tue, 02 Mar 2021 12:14:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92310.174187; Tue, 02 Mar 2021 12:14:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH3ub-0005OL-Hv; Tue, 02 Mar 2021 12:14:01 +0000 Received: by outflank-mailman (input) for mailman id 92310; Tue, 02 Mar 2021 12:14:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH3ua-0005OD-3g; Tue, 02 Mar 2021 12:14:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH3uZ-0004E4-RH; Tue, 02 Mar 2021 12:13:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH3uZ-0002gV-H4; Tue, 02 Mar 2021 12:13:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lH3uZ-0006so-GU; Tue, 02 Mar 2021 12:13:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=krWrXMEHN7dYdJ0UwyMZpIpAEXQTIhDvRzlY87ynaHg=; b=TaRfbsdjRlTcbCcGtbEHCnRaIH QGn7HEVcpiSws4iKC46dQkdxqFVgY7SgkXO4hIT3jb0FdOBWhEtsfs4i7Q0AKveEizfbPptZFlmBe 5FdNrpk79qgKjXvh5hFH2yuBo8tfBsHSBRItl1V3GlXjtf65FgHRZx/D+mvnutOzrTWk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159802: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9bd9695a8bc72a86b98c0683736d2310838558fe X-Osstest-Versions-That: xen=6b4d4dd38470c2293caddf0a5f7034bb832bb574 From: osstest service owner Date: Tue, 02 Mar 2021 12:13:59 +0000 flight 159802 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159802/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9bd9695a8bc72a86b98c0683736d2310838558fe baseline version: xen 6b4d4dd38470c2293caddf0a5f7034bb832bb574 Last test of basis 159797 2021-03-02 00:00:25 Z 0 days Testing same since 159802 2021-03-02 10:02:36 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6b4d4dd384..9bd9695a8b 9bd9695a8bc72a86b98c0683736d2310838558fe -> smoke From xen-devel-bounces@lists.xenproject.org Tue Mar 02 12:28:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 12:28:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92322.174202 (Exim 4.92) (envelope-from ) id 1lH48Q-0006YE-33; Tue, 02 Mar 2021 12:28:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92322.174202; Tue, 02 Mar 2021 12:28:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH48Q-0006Y7-04; Tue, 02 Mar 2021 12:28:18 +0000 Received: by outflank-mailman (input) for mailman id 92322; Tue, 02 Mar 2021 12:28:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH48O-0006Y2-D3 for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 12:28:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH48O-0004SU-8i for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 12:28:16 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lH48O-0002ZY-7W for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 12:28:16 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lH48K-0007Q3-UP; Tue, 02 Mar 2021 12:28:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=qYeYni0fVxOwJMUANxe21QD/smSLcjBLuyfubwGjUUg=; b=rNrK90XRZMxIfrYr5XtoilNAzw AOrnQqC9Q0G90oIHob3IlIo4I2fBLCyKdHQfCcv/PqEEP+0jl4SQTdp9IbNKY4Di8lSNjITFESUMA wy8wrq6d1s8L0tlAmTPhXqmH2iBT65H/bMpAPu/8WZjGF3rvSILW779DuxJFaVuR4Utk=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24638.12124.687863.290191@mariner.uk.xensource.com> Date: Tue, 2 Mar 2021 12:28:12 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , George Dunlap Subject: Re: [PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1 In-Reply-To: <7b4c0c51-5a3c-b9bb-7c9c-62285095183b@suse.com> References: <1d8d5089-32a9-9c42-5949-8f9cd20f33e0@suse.com> <24637.4165.400955.400473@mariner.uk.xensource.com> <7b4c0c51-5a3c-b9bb-7c9c-62285095183b@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1"): > On 01.03.2021 17:03, Ian Jackson wrote: > > Jan Beulich writes ("[PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1"): > >> In this case the compiler is recognizing that no valid array indexes > >> remain (in x2apic_cluster()'s access to per_cpu(cpu_2_logical_apicid, > >> ...)), but oddly enough isn't really consistent about the checking it > >> does (see the code comment). > > ... > >> - if (this_cpu == cpu || x2apic_cluster(this_cpu) != x2apic_cluster(cpu)) > >> + if ( this_cpu == cpu ) > >> + continue; > >> + /* > >> + * Guard in particular against the compiler suspecting out-of-bounds > >> + * array accesses below when NR_CPUS=1 (oddly enough with gcc 10 it > >> + * is the 1st of these alone which actually helps, not the 2nd, nor > >> + * are both required together there). > >> + */ > >> + BUG_ON(this_cpu >= NR_CPUS); > >> + BUG_ON(cpu >= NR_CPUS); > >> + if ( x2apic_cluster(this_cpu) != x2apic_cluster(cpu) ) > >> continue; > > > > Is there some particular reason for not putting the BUG_ON before the > > if test ? That would avoid the refactoring. > > I want it to be as close as possible to the place where the issue > is. I also view the refactoring as a good thing, since it allows > a style correction as a side effect. I'm afraid that at this stage of the release I would prefer changes to be as small as reasonably sensible. So unless there is some reason, other than taste, style or formatting, could we please just introduce the new BUG_ON and not also do other refactoring. Ian. From xen-devel-bounces@lists.xenproject.org Tue Mar 02 12:32:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 12:32:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92329.174215 (Exim 4.92) (envelope-from ) id 1lH4CY-0007Zd-Kv; Tue, 02 Mar 2021 12:32:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92329.174215; Tue, 02 Mar 2021 12:32:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH4CY-0007ZW-HY; Tue, 02 Mar 2021 12:32:34 +0000 Received: by outflank-mailman (input) for mailman id 92329; Tue, 02 Mar 2021 12:32:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH4CX-0007ZR-8N for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 12:32:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH4CX-0004XK-7A for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 12:32:33 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lH4CX-0002l6-6J for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 12:32:33 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lH4CS-0007Qy-HJ; Tue, 02 Mar 2021 12:32:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=UyB5hHBrgZUFCyUiaWXC03VstJoaqZ5B8dHkonOfd9Q=; b=1s1xyoqw1BB1STUuNJeamcfAJ+ mefAgQkY/8Mx5DqBXSn2+x9TfFuPXfK/oPqGQtYmy7ngTtOT0oe3hBLZpJcMtPn9Ke3nn/+t9uyUU Q+xu5MsIdyfbfTj0WpaAcvGDXD4BmnFBMfok1BL248ejjKrdV6I1VrgVR5TtOPSbgYzM=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24638.12380.286845.325678@mariner.uk.xensource.com> Date: Tue, 2 Mar 2021 12:32:28 +0000 To: Jan Beulich Cc: Tim Deegan , "xen-devel\@lists.xenproject.org" , George Dunlap , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Andrew Cooper Subject: Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits In-Reply-To: References: <72c3c863-7465-ce26-1f57-b71227bb2b19@suse.com> <24637.9408.839033.439930@mariner.uk.xensource.com> <99db39fd-e479-f71d-9cb9-5903ff6c12f4@citrix.com> <24637.10160.977640.808417@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits"): > On 01.03.2021 18:43, Ian Jackson wrote: > > Andrew Cooper writes ("Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits"): > >> On 01/03/2021 17:30, Ian Jackson wrote: > >>> I'm afraid I don't follow enough of the background here to have an > >>> opinion right now. Can someone explain to me the risks (and, > >>> correspondingly, upsides) of the options ? Sorry to be dim, I don't > >>> seem to be firing on all cylinders today. > > I guess the risk from that patch is no different than that from the > patch here. It would merely improve performance for guests using > very large GFNs for memory areas needing emulation by qemu, which I > suppose originally wasn't expected to be happening in the first place. > In fact if I would have been certain there are no side effects of the > too narrow GFN representation used so far, I would probably have > submitted the patches in reverse order, or even folded them. I am still confused. You are saying that the existing patch, and your proposal that you are wanting me to have an opinion on, have the same risk. So, what aspect of the proposed other way of fixing it might make me say no ? > >> Without this fix, some combinations of "normal" VM settings will > >> malfunction. > > > > Thanks for that explanation. > > > > I don't quite follow how that relates to Jan's comment > > > > >> Will cook a patch, albeit I guess I'll keep as many of the bits set > > >> as possible, while still being able to encode a full-40-bit GFN. > > >> > > >> Ian - I don't suppose you'd consider this a reasonable thing to do > > >> for 4.15? It would allow limiting the negative (performance) effect > > >> the change here has. > > > > I already gave a release-ack for the original patch. I think Jan is > > asking for a release-ack for a different way of fixing the problem. > > Well, I was trying to negotiate whether I should submit that patch > for 4.15, or only later for 4.16. Precisely. I was hoping someone (eg Andy) would be able to help explain to me why this is a good idea, or a bad idea. Ian. From xen-devel-bounces@lists.xenproject.org Tue Mar 02 13:17:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 13:17:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92337.174227 (Exim 4.92) (envelope-from ) id 1lH4u5-0003Gs-BB; Tue, 02 Mar 2021 13:17:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92337.174227; Tue, 02 Mar 2021 13:17:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH4u5-0003Gl-7v; Tue, 02 Mar 2021 13:17:33 +0000 Received: by outflank-mailman (input) for mailman id 92337; Tue, 02 Mar 2021 13:17:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH4u3-0003Gg-Cx for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 13:17:31 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8661fcfe-ecfb-407e-b8c4-ebe1983c32f7; Tue, 02 Mar 2021 13:17:30 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8886CABF4; Tue, 2 Mar 2021 13:17:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8661fcfe-ecfb-407e-b8c4-ebe1983c32f7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614691049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q3YLJ/1TbX5vgLaUMxs+xbO9ahunRESEPXHHc3rxuY4=; b=ZFHMWdImzcYvH6ZhCyw6FgCv+N9PKRoaA33IFE+dX+4gjvaj2hvz1lQUC4mahkN0vKtJ5o gNkfIZGinu3wupfZMb/AvSgOom1I6uWY8X6E2OwuXpWP2dlLkvpYwac8J6gmuiUxJtqZWl 94VVLo0aFqnP67xkS+WgoJ9psapTyfw= Subject: Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits To: Ian Jackson Cc: Tim Deegan , "xen-devel@lists.xenproject.org" , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper References: <72c3c863-7465-ce26-1f57-b71227bb2b19@suse.com> <24637.9408.839033.439930@mariner.uk.xensource.com> <99db39fd-e479-f71d-9cb9-5903ff6c12f4@citrix.com> <24637.10160.977640.808417@mariner.uk.xensource.com> <24638.12380.286845.325678@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <4cde5206-9c9e-c1fa-ad2e-bc1f16450aca@suse.com> Date: Tue, 2 Mar 2021 14:17:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24638.12380.286845.325678@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02.03.2021 13:32, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits"): >> On 01.03.2021 18:43, Ian Jackson wrote: >>> Andrew Cooper writes ("Re: [PATCH][4.15] x86/shadow: suppress "fast fault path" optimization without reserved bits"): >>>> On 01/03/2021 17:30, Ian Jackson wrote: >>>>> I'm afraid I don't follow enough of the background here to have an >>>>> opinion right now. Can someone explain to me the risks (and, >>>>> correspondingly, upsides) of the options ? Sorry to be dim, I don't >>>>> seem to be firing on all cylinders today. >> >> I guess the risk from that patch is no different than that from the >> patch here. It would merely improve performance for guests using >> very large GFNs for memory areas needing emulation by qemu, which I >> suppose originally wasn't expected to be happening in the first place. >> In fact if I would have been certain there are no side effects of the >> too narrow GFN representation used so far, I would probably have >> submitted the patches in reverse order, or even folded them. > > I am still confused. You are saying that the existing patch, and your > proposal that you are wanting me to have an opinion on, have the same > risk. So, what aspect of the proposed other way of fixing it might > make me say no ? Yet another change / yet more code churn for merely improving what got fixed already. But, oh, there looks to be a misunderstanding nevertheless - I'm not proposing another way of addressing the same issue, but instead a performance improvement (for perhaps just an unlikely case) on top of the fix that you did give your ack for already. (As said - had I been certain of no aspect that I might be overlooking, I might have folded that. But I wasn't certain, and hence I did post the basic fix first / individually.) Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 02 13:37:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 13:37:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92365.174257 (Exim 4.92) (envelope-from ) id 1lH5Cz-0005aI-7L; Tue, 02 Mar 2021 13:37:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92365.174257; Tue, 02 Mar 2021 13:37:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH5Cz-0005aB-3a; Tue, 02 Mar 2021 13:37:05 +0000 Received: by outflank-mailman (input) for mailman id 92365; Tue, 02 Mar 2021 13:37:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH5Cx-0005a6-Vx for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 13:37:04 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 66384db7-8090-4698-b605-773ada8995cc; Tue, 02 Mar 2021 13:37:02 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BB811ABF4; Tue, 2 Mar 2021 13:37:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66384db7-8090-4698-b605-773ada8995cc X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614692221; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uupFA4C/fn0xh5XLyYOHw8bwB3n8qy4DmkdFn37v9VQ=; b=mbEvQB7Eya4rDU8W3pf+ztp/vCfGJ7T3oKaxxqAYwerqdkH6g9niijgI4DVIKinb0vtoR6 OHuHk1V0aeG3wtZADQSy5pJHwm5sT2CjmODzo5sBHGCkgspAUr8c372spP9G4vPGYLSAgH MsNUFnUSmu/x7RW44SP00/SrnjPVwuo= Subject: Re: [PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1 To: Ian Jackson Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap References: <1d8d5089-32a9-9c42-5949-8f9cd20f33e0@suse.com> <24637.4165.400955.400473@mariner.uk.xensource.com> <7b4c0c51-5a3c-b9bb-7c9c-62285095183b@suse.com> <24638.12124.687863.290191@mariner.uk.xensource.com> From: Jan Beulich Message-ID: Date: Tue, 2 Mar 2021 14:37:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24638.12124.687863.290191@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02.03.2021 13:28, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1"): >> On 01.03.2021 17:03, Ian Jackson wrote: >>> Jan Beulich writes ("[PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1"): >>>> In this case the compiler is recognizing that no valid array indexes >>>> remain (in x2apic_cluster()'s access to per_cpu(cpu_2_logical_apicid, >>>> ...)), but oddly enough isn't really consistent about the checking it >>>> does (see the code comment). >>> ... >>>> - if (this_cpu == cpu || x2apic_cluster(this_cpu) != x2apic_cluster(cpu)) >>>> + if ( this_cpu == cpu ) >>>> + continue; >>>> + /* >>>> + * Guard in particular against the compiler suspecting out-of-bounds >>>> + * array accesses below when NR_CPUS=1 (oddly enough with gcc 10 it >>>> + * is the 1st of these alone which actually helps, not the 2nd, nor >>>> + * are both required together there). >>>> + */ >>>> + BUG_ON(this_cpu >= NR_CPUS); >>>> + BUG_ON(cpu >= NR_CPUS); >>>> + if ( x2apic_cluster(this_cpu) != x2apic_cluster(cpu) ) >>>> continue; >>> >>> Is there some particular reason for not putting the BUG_ON before the >>> if test ? That would avoid the refactoring. >> >> I want it to be as close as possible to the place where the issue >> is. I also view the refactoring as a good thing, since it allows >> a style correction as a side effect. > > I'm afraid that at this stage of the release I would prefer changes to > be as small as reasonably sensible. So unless there is some > reason, other than taste, style or formatting, could we please just > introduce the new BUG_ON and not also do other refactoring. FAOD: That's fine - I'll keep this queued for 4.16 then. I did put a question mark behind the version anyway. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 02 13:41:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 13:41:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92370.174269 (Exim 4.92) (envelope-from ) id 1lH5HG-0006bp-QF; Tue, 02 Mar 2021 13:41:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92370.174269; Tue, 02 Mar 2021 13:41:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH5HG-0006bi-Me; Tue, 02 Mar 2021 13:41:30 +0000 Received: by outflank-mailman (input) for mailman id 92370; Tue, 02 Mar 2021 13:41:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH5HF-0006bd-JB for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 13:41:29 +0000 Received: from out4-smtp.messagingengine.com (unknown [66.111.4.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 03c1edf3-7e52-4a69-b18e-48cc1fc4f785; Tue, 02 Mar 2021 13:41:28 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 3E7715C0050 for ; Tue, 2 Mar 2021 08:41:28 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 02 Mar 2021 08:41:28 -0500 Received: from mail-itl (ip5b434f04.dynamic.kabel-deutschland.de [91.67.79.4]) by mail.messagingengine.com (Postfix) with ESMTPA id A5BFB108005F for ; Tue, 2 Mar 2021 08:41:27 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03c1edf3-7e52-4a69-b18e-48cc1fc4f785 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=bfykdhqW1pbs8W/A+KfC9/i9W6sQE 52oi/IdW1s/LRg=; b=HrsxXZ747Y6uFKAqTstqyT2Y+0JBFgy2/WNW6weTPCZEL vR7/ALE8ujXasc0mYJg0ANCN6t3hQ+OOxSoJiKGldfzzkIlMk9Y4aASaVm0hu5QA 7K11LAF9Mz9dlM9RQTXG/I0/syomKqxbWmVWSTPnqze8q+Hhb+t33SV2Tm8ebpJ5 S0pwY6s/aKvGQDdhWsTwcZ1HaP10ev8hqLC6NNASgQcHMRmatC429bBZmiE2jKLx PSwEmRMHHzltUIvrog8eYJOk3nOMyvhT7CBZLyVX0dXFe75lYW6VfsVx1+hdaWSi 49dcmwA+tYdq17HSvJ28PWlOW5x+lFvKGLPX7Lpvg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddttddgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugesghdtreertd dtjeenucfhrhhomhepofgrrhgvkhcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhi uceomhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqne cuggftrfgrthhtvghrnhepteduteeiudevkeegvefhtdekhfelgffhhedukedvvdeuuddv jeehvddtieehudfgnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepledurd eijedrjeelrdegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Date: Tue, 2 Mar 2021 14:41:24 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: Linux >= 5.9 PV dom0 crash when starting a HVM - AMD Ryzen 4750U, Xen 4.14.1 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V4+c/tmaqDsS6m6l" Content-Disposition: inline --V4+c/tmaqDsS6m6l Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 2 Mar 2021 14:41:24 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: Linux >= 5.9 PV dom0 crash when starting a HVM - AMD Ryzen 4750U, Xen 4.14.1 Hi, I've got a report about a Linux regression on AMD hardware, this time with a backtrace! Reportedly, the last functional kernel was 5.8.x (.16, but that's because we moved to 5.9.x and skipped .17 and .18). This is consistent with other reports that anything >=3D 5.9 is unstable on some AMD machines. Details of this config: - Xen 4.14.1 close to vanilla hypervisor-wise - PV dom0 - Dom0 kernel also very close to vanilla - HVM domains in question both have PCI passthrough and qemu in stubdomain (but that's probably not relevant here) - AMD Ryzen 4750U The backtrace: [ 43.497440] kernel BUG at arch/x86/xen/p2m.c:656! [ 43.497923] invalid opcode: 0000 [#1] SMP NOPTI [ 43.498404] CPU: 0 PID: 2347 Comm: xenstored Tainted: G W = 5.10.16-1.fc32.qubes.x86_64 #1 [ 43.498874] Hardware name: HP HP EliteBook 835 G7 Notebook PC/8760, BIOS= S77 Ver. 01.02.03 11/27/2020 [ 43.499362] RIP: e030:___set_phys_to_machine+0x71/0x190 [ 43.499847] Code: 85 c0 75 28 b8 01 00 00 00 48 8b 4c 24 08 65 48 2b 0c = 25 28 00 00 00 0f 85 0a 01 00 00 00 48 83 c4 10 5b 5d c3 48 83 fe ff 74 da = <0f> 0b 48 03 3d ce [ 43.500368] RSP: e02b:ffffc90001ff7cc8 EFLAGS: 00010293 [ 43.500895] RAX: 0000000000000000 RBX: 0000000000000001 RCX: ffff888139c= 18a88 [ 43.501426] RDX: 00000000ffffffd8 RSI: 0000000000a51101 RDI: 00000000001= 47fff [ 43.501958] RBP: 0000000000a51101 B08: 0000000000000000 B09: ffffc90001f= f7b30 [ 43.502407] R10: ffffc90001ff7b28 R11: ffffffff82944488 R12: ffff8881071= 4c6a8 [ 43.503020] R13: 0000000000a51101 R14: 0000000000147fff R15: 00000000000= 00000 [ 43.503557] FS: 00007813cd907d00(0000) GS:ffff888139c00000(0000) kn1GS:0= 000000000000000 [ 43.504101] CS: e030 DS: 0000 ES: 0000 CR0: 0000000000050033 [ 43.504651] CR2: 000000000000d8c038 CR3: 0000000102ae4000 CR4: 000000000= 0050660 [ 43.505203] Call Trace: [ 43.505744] set_foreign_p2m_mapping.part.0+0x164/0x320 [ 43.506302] gntdev_map_grant_pages+0x5d/0x350 (xen_gntdev) [ 43.506852] gntdev_mmap+0x199/0x2f9 (xen_gntdev) [ 43.507408] mmap_region+0x47e/0x720 [ 43.507957] do_mmap+0x438/0x540 [ 43.508514] ? security_mmap_file+0x81/0xd0 [ 43.509054] vm_mmap_pgoff+0xdf/0x130 [ 43.509606] ksys_mmap_pgoff+Ox1d6/0x240 [ 43.510170] do_syscall_64+0x33/0x40 [ 43.510714] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 43.511263] RIP: 0033:0x7813cdbfa2e6 [ 43.511835] Code: 01 00 66 90 f3 0f 1e fa 41 f7 c1 ff 0f 00 00 75 2b 55 = 48 89 fd 53 89 cb 48 85 ff 74 37 41 89 da 48 89 ef b8 09 00 00 00 0f 05 <48= > 3d 00 f0 ff ff 77 [ 43.512442] RSP: 002b:00007ffeb83042f8 EGLAGS 00000246 ORIG_RAX: 0000000= 000000009 [ 43.513045] RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 00007813cdb= fa2c6 [ 43.513654] RDX: 0000000000000003 RSI: 0000000000001000 RDI: 00000000000= 00000 [ 43.514276] RBP: 0000000000000000 R08: 000000000000000f R09: 00000000000= 00000 [ 43.514688] R10: 0000000000000001 R11: 0000000000000246 R12: 00007ffcb83= 04310 [ 43.515498] R13: 0000000000000003 Ri4: 000000000000000f R15: 00000000000= 00001 [ 43.516188] Modules linked in: nf_tables nfnetlink vfat fat hp_smi spars= e_keymap wmi_bmof uvcvideo videobuf2_vmalloc videobuf2_memops videobuf2_v41= 2 videobuf2_common=20 da_codec_generic k10temp i2c_piix4 snd_pci_acp3x lcdtrig_audio mc snd_hda_c= odec_hdmi snd_hda_intel btusb snd_intel_dspcfg joydev btrtl snd_hda_codec b= tbcm btintel snd_hda=20 pcm snd_timer iwlwifi snd soundcore cfg80211 ucsi_acpi typec_ucsi rfkill ty= pec wmi cm32181 video industrialio hp_wireless fuse xenfs ip_tables dm_thin= _pool dm_persistent titouch amdgpu crct10duf_pclmul crc32_pclmul crc32c_intel nvme iommu_v2 gpu= _sched ttm i2c_algo_bit drm_kms_helper cec drm ghash_cimuini_intel xhci_pci= xhci_pci_renesas=20 back xen_blkback xen_gntalloc xen_gntdev [ 43.516186] xen_evtchn uinput [ 43.528491] ---[ end trace 0f195b254c08766c ]--- [ 43.689504] RIP: e030:__set_phys_to_machine+0x71/0x190 [ 43.618326] Code: 05 c0 75 28 b8 01 00 00 00 48 0b 4c 24 O8 65 48 2b 0c = 25 28 00 00 00 Of 05 0a 01 00 00 48 83 c4 10 5b 5d c3 48 83 fe ff 74 da 0b 48 03 34 ce 31 [ 43.611124] RSP: e02b:ffffc90001ff7cc8 EFLAGS: 00010293 [ 43.611933] RAX: 0000000000000000 RBX: 0000000000000001 RCX: ffff888139c= 18a88 [ 43.612736] RDX: 00000000ffffffd8 RSI: 0000000000a51101 RDI: 00000000001= 47fff [ 43.613534] RBP: 9999999999a51101 R08: 0000000000000000 R09: ffffc90001f= f7b38 [ 43.614320] R10: ffffc90001ff7b20 R11: fffffffff8294488 R12: ffff8881871= 4c6a8 [ 43.615119] R13: 0000000000a51101 R14: 0000000000147fff R15: 00000000000= 00000 [ 43.615925] FS: 00007813cd987d00(0000) GS:ffff888139c00000(0000) kn1GS:= 0000000000000000 [ 43.616714] CS: e030 DS: 0000 ES: 0000 CRO: 0000000000050033 [ 43.617519] CR2: 0000000000d8c038 CR3: 0000000102ae4000 CR4: 00000000000= 58660 [ 43.618313] Kernel panic - not syncing: Fatal exception [ 43.619137] Kernel Offset: disabled The original report: https://github.com/QubesOS/qubes-issues/issues/6397#issuecomment-788879968 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --V4+c/tmaqDsS6m6l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmA+QIQACgkQ24/THMrX 1yw3Tgf+NqLQwCMP2OtD1gQvM4yl6152K6LEOqo+sq9tma4e91nPZUSgy5BRJnI/ Gd8y/kz9bOn3fskqxeXlTCV/4vn4tFIdu2kjFphICIm/2hrgtWm0ts077ysl3g/t F0rYlkcUpmk5CYTrSLdAEf9O9ibMqhkYYzR6ua9/9B6n52AdmamhZK7dp7sn4N9w EPAtqDSkd9hftyAbXHdtPa24K/ImOg6sUOHDUPg7tLjsHzGmhTPte1/G/lrxUm7r 0TmawpYfR4LnNszBMl6tXRk3YSJC5Xd6p+vaRwPUfVyOb5B1/hWoDDX1ghqCQXGE eTPSjukVUr+WUpWdAx0AfFMRdxyNzA== =N8IZ -----END PGP SIGNATURE----- --V4+c/tmaqDsS6m6l-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 15:02:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 15:02:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92397.174280 (Exim 4.92) (envelope-from ) id 1lH6Ww-0006H2-GU; Tue, 02 Mar 2021 15:01:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92397.174280; Tue, 02 Mar 2021 15:01:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH6Ww-0006Gv-DZ; Tue, 02 Mar 2021 15:01:46 +0000 Received: by outflank-mailman (input) for mailman id 92397; Tue, 02 Mar 2021 15:01:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH6Wv-0006Gq-5s for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 15:01:45 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ae5133b3-6538-46fc-a092-0a6106e44bd1; Tue, 02 Mar 2021 15:01:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae5133b3-6538-46fc-a092-0a6106e44bd1 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614697302; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=C1ctjyifuLgKotDqKZrUYexPmT/bCj8TTpx7Q/FbiYM=; b=YczOcuAZ8Q6+U4TFXIr3s654a7m9OFioWErPIwseD2H07ZL1u/R7SaGA A000cafwFbSKlb/RXwumNYBSlXMGYcLI2R8UYPrMm1MEnzjGw3xeghw1k vdur05tZHQui2hUfNAzgVBnpX3Ukmlmi3Hk7ZYSJjbEHyD5S5yWb1uwFl M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 9PEQjBZwdAHsWsKM1Uk7PhPKBs0L3HLvLbelO+EDykXZ2z+yLBeE1AxVongbTGAa7WXFPFmEJP DWbfgCMohd/W4RacT34cCis0rch97U+mm8xM0B6MtBVAoprLRO4mgYeqWXkNxs9IWEKUi7EF1G BVdfNlNqM5EDQByWDR6x8jOjNMCgRzRW3HAjvDq5Ll7t/nIUICBpxA2ETwm4Z4Jfwp1vz+Xy16 sjMp/1UwS7A8k0Fyo5TqnYB5fTWkCNvgFlvbGWVqcFZiyIwQCa05ey8aa76fHlFMI1i/f9C83Z 0Zk= X-SBRS: 5.2 X-MesageID: 38710780 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,216,1610427600"; d="scan'208";a="38710780" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VapDLthl+lDC0N7JsGjrjS8kDP7W4qFR3Jg1ZNCg5Da8GCGYSt6dvxCv47CmWniYaoj7TsY4pJkWneqczkwMTEHhusXjOjhkpsb0dQzj6XwwdMXc5zYdo3/uPAuk+NA3EuL5I5UiPc9MaVuwCghf6AzyMhWGRkOkSrop2gV2ubZ50WTt27ZBPlo2iGTXkhtBbIvKH/SIIKGB3ndZxxcot3KlpCmFyBuf2Ldg547omP31qWON7VC8WbDNHC6yQQvJjkLCIsryz5FoSCG7K4bPb0M+yltBbbYV7/tx1DLLkBTLRCaouCUsR9fe/dYiiHP1ll6G7w1lT/rW3SAyY1y38A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f6GGem3553ZQJ2A8xBoubF1bosk6d1m7VHnE/mfJrcg=; b=KLUAE7xrEk8TKjWtIrhQFcm4f5PCa3O354aYw7eAkAJ3enyPGOCOSN5/wH02vKN5YKD6IB7VUeHLENIbaLYC05Cqbvvv5EPvGSCBx4wkvs+6tQBs0xWNRILX7xKuNMh9miW4VUc4rpyjLkNnq3DuWmoa+hHnPL0iGZHU2LjkfDJXNFhonpEB3p3/UeTDRaMX5ujB8QVMHlCKetC49yLhoPMdGvOjty1X6uaEN6vLJy6Y1LMPyTgiNHdH2AZJ/RmN9U14RU2YGkE2iTMx/LSzvbrOeyGn8VcqcP6MxYO3CuWG+Rt1bsxqO0Qy1Xc2nI6TTBGVEjQh0TyRtipW+/3/ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f6GGem3553ZQJ2A8xBoubF1bosk6d1m7VHnE/mfJrcg=; b=tYBQECkDzq1xnCAMf5zrGlf4zYd8gIioMOcEAMwsMytl+tyottmB35YruLydZQ3uIXoM5KvAFRJhDPdPqkbmbscHJ1QJ1vLvWxnyQ5Y6TMyPSCK+65Bb0zXCE5eEqaG+Dupte8vO5mPM3SzmPuT1yK9BwRJoXA6xF0mP4afk1/I= Date: Tue, 2 Mar 2021 16:00:21 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , Ian Jackson , Wei Liu , Anthony PERARD , Jun Nakajima , Kevin Tian , Boris Ostrovsky , Subject: Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection Message-ID: References: <20210301162357.76527-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MR2P264CA0119.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::35) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 987de990-3fa3-4b35-2d34-08d8dd8beb13 X-MS-TrafficTypeDiagnostic: DM6PR03MB3739: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pg6NPQMqzUZgBNfFapfaEgogdAsQOjWclHIF3CiSprUO+L1EpyIPYR3+9YG7PWbmy618nhWByLA5w/CQt7DhJbTcyFwiueopqun7fycKxB/0t1I7ECFGH0dTkYfDsJBz5mILlgilvHPa1BsgfmctzmCaBWxN2BbrR1B8X1n5elJg4lAkmkjhVFRkdyZ4vcKoCIv6HNqozd9Xc/uufHHmT9kGgozlWEuqYJnsDKfyd+Tq4lv+BHigEGoigNtd5TPwHkON7EZiiXEH746ZIunYWxickF1xoTOzozkwkR6XR+6Osc6XOA4PiX3NwsM5lQAXcuHSJlx6jMsDUP5p0jls9pBQih/RDl3bGpsIxrdWelPQcucqQKuYzfBut4KhnzMN7BMiJz/GmObI3UxNqUlBHh/czBeAwVnI3R42Om4Y4B0UKgdIHvV1ElhU/7/GY5foZamQWphV0j9gLe0cFjxF6KOiouV1lmCGJicFZEpAXeb8+Y7Ql7OIAETBxLWlVuLgHpn/ASPxDUcnFr+BqDjZ5A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(346002)(376002)(136003)(396003)(39860400002)(66556008)(66476007)(85182001)(4326008)(5660300002)(6916009)(86362001)(6486002)(9686003)(66946007)(186003)(956004)(8936002)(2906002)(53546011)(316002)(33716001)(54906003)(83380400001)(6666004)(478600001)(6496006)(16526019)(8676002)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NmxUbCtMYUcyU25iTHBUTVM1elNxN1BlV3BNeFZWSzhsWmlOQ3pQWUdPWGZs?= =?utf-8?B?L1ZROElnWUhidFZPZnBhbHhVcmFDYmxqazl3cHlkVWh6S21OdWcwcWVmVlA4?= =?utf-8?B?dXJ1ODA2cGxnMjJDTUp3QU1SdDBWb2VzY3BIb2lrdnBJUm02bG94L0cxMi9N?= =?utf-8?B?eDE5RVlkM3dJUXc2NG1POHgraHZ4ZGtYeDUxWnI5QUoxd3JESFJKRERYMDVq?= =?utf-8?B?MEJzVVVNZ0d1bkdVc2drQXRmalZDTzRPanRyTjB0UFFFdWJRUGQyMkRyS0Mv?= =?utf-8?B?YkFPYjRwODc0Z2VwVG9aNkNEWWY1TnRlMkJ5Z0N6eEJCa0IrYnZwcUlOS25Q?= =?utf-8?B?b09RVXhtb3JFTDRvS25KQmNkMi8ybE5KQU1ZWEVZQXJlUGZ5dW4rUjU1aHIw?= =?utf-8?B?SjFZNFlSRm9FRkRkRlViWm9POGRYUG9zdkduNEkwTytmMk5yN09QajlrL1ZY?= =?utf-8?B?NnFFMkRzR21peHN3dy9iMUE2bHd1UlFxY05tSkVmV3FncHlULzJKOUErU1po?= =?utf-8?B?cStodDhCeThSbEdUb1pPRDNkK0ltKzhXUnhJbTEvVm5Ld3hXOUUxSEw0YURm?= =?utf-8?B?VmY4RVprM3ZhUTRWN2JIWWMzOC8vTllFSDZwbjRmOVFQTkV1d3A2cjhURnFI?= =?utf-8?B?UWNIa05TOUlBdmVFSzlLVmdlMFAydFZYSkJJNlk4REhCZlFrbDNmL1BTTTQ4?= =?utf-8?B?M2FiTi8yQ1I1LzF4Q1hvdjZZQ256ZTlGODVtVFJqVGNYV21XWXNHYTFTVzFY?= =?utf-8?B?MVMrSmFlVkhsRjc4V2lnM2JiMjhjYkp4aXpyRTNtZkVuOEhUY3ArSkExS3Mv?= =?utf-8?B?VTZxTnZ6MVNQK29NN3pZM3RnTlY3Vzh1blVURURqUGpqM1JONmhNMlZNTWZR?= =?utf-8?B?UVhhbXEvanQycVExc0wzUm1QWHA2WmRBQlFSUkRoTmIvQUEzb015TlhwZGJ2?= =?utf-8?B?TDgwUGM4bU94RENEQlA5WTVRd2laNTlBU2M3OGdnUHN3QmtCanFPTHBjM0Yv?= =?utf-8?B?cXJrZHAyNGxqN1JBenFUTGNSZW9PMnpPbG1JcytjdXJMWjEzY05tZlVaOXRr?= =?utf-8?B?NENqWUM0SlhNYm5wTndjRXRqYzlmMnVEaThCSTJOVlZkR2g1Sk1HbVJKUXZh?= =?utf-8?B?U09KTEI0L1dzUDNSbDV4QUJUQm9rL3h1UmpCckFaQ202T1pJU0hWa1lGTndI?= =?utf-8?B?YmE4dVJ2SDZRcEhGNXMrR0lZZmNWb2hGYVcxSHd0WE1zKzBQNjVlS1dwTDl2?= =?utf-8?B?eUV0eVZLeU81UXUxYlAyNGhOdzRlNXZtcXpGKzFOSWdpbFJZQ0tyNDJ4ZEx4?= =?utf-8?B?MTFGeFNLd0w3aW5tOVZpZW9maUNYL2NrdGluWDU0UWF3RmZsdkZnQ0llM0Z5?= =?utf-8?B?WHpvSFcvTUE4V2Fxb2xZcnpNMjRIdExBR2JtR1JoczQxNnNQNVhFbU1Hbkhm?= =?utf-8?B?b0xCZUhzZ0xHZTVnTkZZdnRONnN2T0V1dEF6b2VqdHY3aWdvcVF2Tm5uMXN4?= =?utf-8?B?Zis0QXo2Um56NzFoUy9xR2d1c3ZPRWw1TTY4T2ovU2RTWURhOXQvNlZCUG9F?= =?utf-8?B?ZWNueXRvTUEraUdzTDg5Si9nSklTN2V0VDVvWHRyNXRVRXZndDA5MG82c3Vj?= =?utf-8?B?N0dpVHJTc0pYUW0vM2w3NG9WVXRQeFUrQkVTdmY2eExoMFlYekNPcjRXSHBL?= =?utf-8?B?SE5JVzAyWWZsWHdibkRHY1MxYXFqcWJ4dFM3N1NXMEhqYjJlNkNhQWEyN0J2?= =?utf-8?B?YlF0SHBGeFJNQmpiSHY5NkVXUkdKaHlkcUJRVXVhS0JSQ2dMemdOelI0V2Va?= =?utf-8?B?aVFiY1RMd1NZN2Z6THUzQT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 987de990-3fa3-4b35-2d34-08d8dd8beb13 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2021 15:00:28.9648 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qFo9Dwf+e5Kda/A2TiOXDGCWqV73CMU671tj7UghTH1eOxjHFSsDbT1htZgdxVgP86ys8aw8gFJZCBzGwlUlPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3739 X-OriginatorOrg: citrix.com On Tue, Mar 02, 2021 at 12:16:12PM +0100, Jan Beulich wrote: > On 01.03.2021 17:23, Roger Pau Monne wrote: > > Introduce an option to allow selecting the legacy behavior for > > accesses to MSRs not explicitly handled. Since commit > > 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly > > handled by Xen result in the injection of a #GP to the guest. This is > > a behavior change since previously a #GP was only injected if > > accessing the MSR on the real hardware will also trigger a #GP. > > > > This seems to be problematic for some guests, so introduce an option > > to fallback to this legacy behavior. The main difference between what > > was previously done is that the hardware MSR value is not leaked to > > the guests on reads. > > Looking at the WRMSR behavior for PV, what you introduce isn't > matching 4.14 behavior: If rdmsr_safe() failed, all that effected > was the issuing of a log message. The behavior you propose is > better, no question, but it shouldn't be described as matching > legacy behavior then. > > Somewhat related to this I wonder whether MSR reads and writes > wouldn't better be controllable independently. It seems quite > likely that a kernel may have an issue only with reads. > > Additionally I wonder whether it is a good idea to let these > events go silently. > > > Note that this option is not made available to dom0. I'm not sure > > whether it makes sense to do so, since anyone updating Xen to such > > newer version will also likely pair it with a newish kernel that > > doesn't require such workarounds. > > No, that's not an option imo. It was a Dom0 where I ran into the > problem causing me to submit "x86/PV: conditionally avoid raising > #GP for early guest MSR accesses". While I could upgrade that > system, I have reasons for not doing so. And while I could put a > more modern kernel on there, I'd prefer if the distro kernel > continued to work. (That's leaving aside that for unrelated > reasons building and using my own, newer kernel there is quite a > bit more difficult than on all other of my test systems.) > > > RFC because there's still some debate as to how we should solve the > > MSR issue, this is one possible way, but IMO we need to make a > > decision soon-ish because of the release timeline. > > Generally I think it would be far better from a user pov if > things worked out of the box, at least in cases where it can be > made work. Arguably for Solaris this isn't going to be possible > (leaving aside the non-option of fully returning back to original > behavior), but for the old-Linux-PV case I still think my proposed > change is better in this regard. I realize Andrew said (on irc) > that this is making the behavior even weaker. I take a different > perspective: Considering a guest will install exception handlers > at some point, I continue to fail to see what good it will do to > try to inject a #GP(0) when we know the guest will die because of > not having a handler registered just yet. It is a kernel flaw, > yes, but they ended up living with it merely because of our odd > prior behavior, so we can't put all the blame on them. My concern with this would mostly be with newer guests, in the sense that people could come to rely on this behavior of not injecting a #GP if the handler is not setup, which I think we should try to avoid. One option would be to introduce a feature that could be used in the elfnotes to signal that the kernel doesn't require such workarounds for MSR #GP handling, maybe: /* * Signal that the kernel doesn't require suppressing the #GP on * unknown MSR accesses if the handler is not setup. New kernels * should always have this set. */ #define XENFEAT_msr_early_gp 16 We could try to backport this on the Linux kernel as far as we can that we know it's safe to do so. If this is not acceptable then I guess your solution is fine. Arguably PV has it's own (weird) architecture, in which it might be safe to say that no #GP will be injected as a result of a MSR access unless the handler is setup. Ideally we should document this behaviour somewhere. Maybe we could add a rdmsr_safe to your path akin to what's done here? > > This isn't to say that I'm against propagating exceptions where > there's no alternative to delivering one. Also I'm certainly open > to further tighten the condition of when to zap such an exception > (e.g. only as long as there's no handler _and_ the guest is still > in UP mode, assuming of course this would still address the > observed issue). > > > --- a/docs/man/xl.cfg.5.pod.in > > +++ b/docs/man/xl.cfg.5.pod.in > > @@ -2861,6 +2861,17 @@ No MCA capabilities in above list are enabled. > > > > =back > > > > +=item B > > + > > +Select whether to use the legacy behaviour for accesses to MSRs not explicitly > > +handled by Xen instead of injecting a #GP to the guest. Such legacy access > > +mode will force Xen to replicate the behaviour from the hardware it's currently > > +running on in order to decide whether a #GP is injected to the guest. Note > > +that the guest is never allowed access to unhandled MSRs, this option only > > +changes whether a #GP might be injected or not. > > This description is appropriate for reads, but not for writes: > Whether a write would fault can only be known by trying a write, > yet for safety reasons we can't risk doing more than a read. An > option might be to make writes fault is the to be written value > differs from that which the probing read has returned (i.e. the > same condition which originally had caused a log message to appear > in 4.14 for PV guests). Read values for unhandled MSRs will always be 0 with the proposed code, so we would inject a #GP to the guest for any write attempt to unhandled MSRs with a value different than 0. Maybe we should just inject a #GP to the guest for any attempts to write to unhandled MSRs? > > --- a/tools/libs/light/libxl_types.idl > > +++ b/tools/libs/light/libxl_types.idl > > @@ -644,6 +644,8 @@ libxl_domain_build_info = Struct("domain_build_info",[ > > ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), > > ("vuart", libxl_vuart_type), > > ])), > > + ("arch_x86", Struct(None, [("msr_legacy_handling", libxl_defbool), > > + ])), > > Seeing this I'm wondering whether the entire set of arch_* > shouldn't be within a union. But afaics this would have further > implications on code elsewhere, so surely wouldn't want doing > right now. Right, I thought the same but I'm not sure we can change this now, as it's part of the API. Adding new fields is fine, but adding a union field with arch_arm would change the structure as we would need to add a 'u' (or equivalent) field here. > > --- a/xen/arch/x86/domain.c > > +++ b/xen/arch/x86/domain.c > > @@ -852,6 +852,9 @@ int arch_domain_create(struct domain *d, > > > > domain_cpu_policy_changed(d); > > > > + d->arch.msr_legacy_handling = config->arch.domain_flags & > > + XEN_X86_LEGACY_MSR_HANDLING; > > Somewhere you'd also need to refuse processing requests with any > of the other 31 bits set. Yes, I need to sanitize the flags. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 02 15:05:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 15:05:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92401.174293 (Exim 4.92) (envelope-from ) id 1lH6aw-0006QW-6d; Tue, 02 Mar 2021 15:05:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92401.174293; Tue, 02 Mar 2021 15:05:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH6aw-0006QP-37; Tue, 02 Mar 2021 15:05:54 +0000 Received: by outflank-mailman (input) for mailman id 92401; Tue, 02 Mar 2021 15:05:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH6au-0006QH-ME; Tue, 02 Mar 2021 15:05:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH6au-00074n-FC; Tue, 02 Mar 2021 15:05:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH6au-0002lz-2j; Tue, 02 Mar 2021 15:05:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lH6au-0007Og-2I; Tue, 02 Mar 2021 15:05:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Q4vQ/rmk1PczLnRqLySEaZnrc5QV1Oof44DCJ0x6Da8=; b=PxnagAXprxqK1JrGDyXzxNZzlb F8MAXGTnRUUSBwfXjyIc5aazyndXWTrAVM4c3mek4gUndDfKvsiz9pRqi1pgRnAbfkbEJzQmeyXcG DW3mkDzAccBWqsbHLwTRXGPxg1E/WizjcDrkuL9oroRdIouguq5+rEQ+SCwITGnX9034=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159798: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7a7fd0de4a9804299793e564a555a49c1fc924cb X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Tue, 02 Mar 2021 15:05:52 +0000 flight 159798 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159798/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux 7a7fd0de4a9804299793e564a555a49c1fc924cb baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 213 days Failing since 152366 2020-08-01 20:49:34 Z 212 days 368 attempts Testing same since 159798 2021-03-02 02:40:53 Z 0 days 1 attempts ------------------------------------------------------------ 5135 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1271848 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 02 15:19:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 15:19:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92410.174308 (Exim 4.92) (envelope-from ) id 1lH6nf-0007iU-Cy; Tue, 02 Mar 2021 15:19:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92410.174308; Tue, 02 Mar 2021 15:19:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH6nf-0007iN-A5; Tue, 02 Mar 2021 15:19:03 +0000 Received: by outflank-mailman (input) for mailman id 92410; Tue, 02 Mar 2021 15:19:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH6ne-0007iI-94 for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 15:19:02 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id abec5732-6fe2-49db-a6ab-f2978f068986; Tue, 02 Mar 2021 15:19:01 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3F556ADDD; Tue, 2 Mar 2021 15:19:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abec5732-6fe2-49db-a6ab-f2978f068986 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614698340; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mtCzxsZn2zPf6nev5Uf/3bXdldq+SRjnqG+YEaSoHlA=; b=Qf1W1yYV/0yYcA1h1ij42Wwv4U5egbLhZ1626qkV+RbC6KUNHljRYRucwsIZpKp484rTtc cogVu1MyiV9nX8ktLekJqDqUQirjtTF16TXsbUUG5Y+HSIzuR0BpkiVHqQJfM/pHvUHEJu t7AotRcMF6XTWZGoYYRBQ3ns/s/xtKc= Subject: Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Ian Jackson , Wei Liu , Anthony PERARD , Jun Nakajima , Kevin Tian , Boris Ostrovsky , xen-devel@lists.xenproject.org References: <20210301162357.76527-1-roger.pau@citrix.com> From: Jan Beulich Message-ID: <62be2084-e5fa-e439-8426-6d129a10c379@suse.com> Date: Tue, 2 Mar 2021 16:18:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 02.03.2021 16:00, Roger Pau Monné wrote: > On Tue, Mar 02, 2021 at 12:16:12PM +0100, Jan Beulich wrote: >> On 01.03.2021 17:23, Roger Pau Monne wrote: >>> RFC because there's still some debate as to how we should solve the >>> MSR issue, this is one possible way, but IMO we need to make a >>> decision soon-ish because of the release timeline. >> >> Generally I think it would be far better from a user pov if >> things worked out of the box, at least in cases where it can be >> made work. Arguably for Solaris this isn't going to be possible >> (leaving aside the non-option of fully returning back to original >> behavior), but for the old-Linux-PV case I still think my proposed >> change is better in this regard. I realize Andrew said (on irc) >> that this is making the behavior even weaker. I take a different >> perspective: Considering a guest will install exception handlers >> at some point, I continue to fail to see what good it will do to >> try to inject a #GP(0) when we know the guest will die because of >> not having a handler registered just yet. It is a kernel flaw, >> yes, but they ended up living with it merely because of our odd >> prior behavior, so we can't put all the blame on them. > > My concern with this would mostly be with newer guests, in the sense > that people could come to rely on this behavior of not injecting a > #GP if the handler is not setup, which I think we should try to avoid. > > One option would be to introduce a feature that could be used in the > elfnotes to signal that the kernel doesn't require such workarounds > for MSR #GP handling, maybe: > > /* > * Signal that the kernel doesn't require suppressing the #GP on > * unknown MSR accesses if the handler is not setup. New kernels > * should always have this set. > */ > #define XENFEAT_msr_early_gp 16 > > We could try to backport this on the Linux kernel as far as we can > that we know it's safe to do so. I too did consider something like this. While I'm not opposed, it effectively requires well-behaved consumers who haven't been well- behaved in the past. > If this is not acceptable then I guess your solution is fine. Arguably > PV has it's own (weird) architecture, in which it might be safe to say > that no #GP will be injected as a result of a MSR access unless the > handler is setup. Ideally we should document this behaviour somewhere. > > Maybe we could add a rdmsr_safe to your path akin to what's done > here? Probably. Would need trying out on the affected older version, just like ... >>> --- a/docs/man/xl.cfg.5.pod.in >>> +++ b/docs/man/xl.cfg.5.pod.in >>> @@ -2861,6 +2861,17 @@ No MCA capabilities in above list are enabled. >>> >>> =back >>> >>> +=item B >>> + >>> +Select whether to use the legacy behaviour for accesses to MSRs not explicitly >>> +handled by Xen instead of injecting a #GP to the guest. Such legacy access >>> +mode will force Xen to replicate the behaviour from the hardware it's currently >>> +running on in order to decide whether a #GP is injected to the guest. Note >>> +that the guest is never allowed access to unhandled MSRs, this option only >>> +changes whether a #GP might be injected or not. >> >> This description is appropriate for reads, but not for writes: >> Whether a write would fault can only be known by trying a write, >> yet for safety reasons we can't risk doing more than a read. An >> option might be to make writes fault is the to be written value >> differs from that which the probing read has returned (i.e. the >> same condition which originally had caused a log message to appear >> in 4.14 for PV guests). > > Read values for unhandled MSRs will always be 0 with the proposed > code, so we would inject a #GP to the guest for any write attempt to > unhandled MSRs with a value different than 0. > > Maybe we should just inject a #GP to the guest for any attempts to > write to unhandled MSRs? ... doing this would need to. Iirc I did add the write side of the handling in my patch just for symmetry. I'd prefer handling to be symmetric, but I can see why we may not want it to be so. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 02 15:23:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 15:23:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92415.174321 (Exim 4.92) (envelope-from ) id 1lH6s1-0000Am-56; Tue, 02 Mar 2021 15:23:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92415.174321; Tue, 02 Mar 2021 15:23:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH6s0-0000Af-WF; Tue, 02 Mar 2021 15:23:33 +0000 Received: by outflank-mailman (input) for mailman id 92415; Tue, 02 Mar 2021 15:23:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH6rz-0000Aa-Mg for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 15:23:31 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e5f6120b-aa4f-45a7-ae37-e4f0183050a9; Tue, 02 Mar 2021 15:23:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5f6120b-aa4f-45a7-ae37-e4f0183050a9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614698610; h=to:cc:from:subject:message-id:date: content-transfer-encoding:mime-version; bh=9VcRKyDuvif0fqvHO93oxjhFwe+QYqaOTVNf3w5hsP8=; b=dc0n+9qXFMzmDMr7Rb2I7FvcYkQy+6JE4alcEq3sqU3LD1gpkI1FpLj5 eyETAQQcTLXU7VjGePoRG/jno9+/a4thtj2sF1WSnBwrqYY0Ez/CXrFo7 KIozHvJm2nxjnnD2k2FpNBew6Qe9kpTF92cvSvr9knWOlih9YkM0OVvu6 A=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: OwFxmp9OBFhbdO7rB51ZeJYnpqYYWoU1spF1WSBNkp6+MVKemd7bY5wQjlTKE5zjFQEIJKcai3 rvF9QAF9WbWnxdDjZ3Vg06uO1XQJvODC7Kq2PjUPI4AQfGVLdvVF7kKSNf8Vv/7pfLntd7+6S3 BtGX9V5tEg9ARrhvyvcM6yhyawsl/BS2VoJPG7l7wl4U4pKAeFFi3/TmU/f7p4677nK1pZjCQA A9Bk3Mkz+IluXs8qV42cK13eGLUahCrLZ9a8HblSYchPkBIZcfCsIyEFdKH97/kEsKGaIGswoA 9Ws= X-SBRS: 5.2 X-MesageID: 38337520 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,216,1610427600"; d="scan'208";a="38337520" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BQb53SkQXGwgKv1gOSARlE0ruliWM1yY4ZKLzKB2OeaZECQ8lDuVNlddGM981o6ycBur7aT7J16+fhZFWZ2/QH4P5gsLWFHI1jy5cUOUoCYDtzeUZqEsb1Z6oeuwi1QbHIb2pyRWk8GFGxo1cfvE2hEHBGskykH8bHzYTunRTwefmS6BkPAqIFrLV51nGdYMIa+ZaSFRZGnvWjCpesUIgl2chS+RABk7/d7yvm3lym8KcMfoNTlijlrczofCR1ZWoH8t+VjSqbQni3A0RDqnDNSunPhwpEgJNAgn4HADAl+BRUYodX6n8HoKqbbzXtLyViAvhBZEbdV9iD+jMgKBog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9VcRKyDuvif0fqvHO93oxjhFwe+QYqaOTVNf3w5hsP8=; b=awivJZx84eiszFWPylNATEUTQA8zhqLyr90PhV7566wgRom/X7RLzpBpY0x6tkLRU2jeubS/759UF7f1FntstD6qpptGfYH65P83pv6b2ne+gYvziCfpP1SnKuuF69YAKxk14vuQn8sCCD6xvDaCK2EEKfoYAZQ36MpwIDEuxYW2NEbD/yGuJCvv6ktuBEOdP7b2otrXPs8aFWtUT7uaCoWRGPgsthPrDx+slvk0cEFHnGgBzgr17F3vMd3oZDPZYpVoe5Jn/RQ4XOLjSWso3vWQoM1qx9/7UgvFa1iOjQjmqR4axM5MNxI5aNtYdO3Lx+vjTuzxlT0IUlcE5a18LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9VcRKyDuvif0fqvHO93oxjhFwe+QYqaOTVNf3w5hsP8=; b=ahKuhTnxl2MfsFVyLgiOJwZmefjUYFg/NtzO6cxzBabhQBV/v4KhFoCQIPpHGaTD1FQSHSsbf4Tbak370h70sZMayhL2PveG1JbFaItLPuqsEMugf+Dninwr+nDTDr7gHWmR1b4E+db8PxSF5SgsSyOgoXM9pScD+LzoY+qXHcw= To: xen-devel CC: Juergen Gross , Ian Jackson , Wei Liu , Jan Beulich From: Andrew Cooper Subject: xenstore_lib.h and libxenstore API/ABI problems Message-ID: Date: Tue, 2 Mar 2021 15:23:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO3P123CA0009.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 05b43f74-6c43-4383-cb71-08d8dd8f202f X-MS-TrafficTypeDiagnostic: BYAPR03MB3560: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kUAvmSKhYQMN+HeG2lvJlHjgXv2P07ltpruQEulwpgO/+/A9ubeI3ChQpZaoL8bUWRrdBkyUMwHNwSRSjhgv1wySlZcyV+FuUDS/oI7LCTP0BAsC3X0D+un+OP+z7/ABR5tmqLJUZwmgFfeYHsNuUHxjJckDv3IVlF2KiFse45LXJBDuBj5QQBM+uVxXibWIRm66YEkEe9qbE3jKBtgabkb1tc51ZdzUit52J0srKznNurdPfp/0TmFQQ1jgLKdprciW5bPtOsdRrFEhWR3jOhIWSt1STvHDO27F0MOLRjzMSmTLp0oolb+28fLgHe5Gn2ojHtYwJwrVRu9NuZanKSQMseJNT7yU7glxeij4Gz1NV2Uuf2XGkP71IzLQ5Cp74lXm/DpiSyMgI6mwe4k0M8JXJoyhvVtp5GEcM+1yC8iAGGK+Eua9FgONe2xWR/kM07R9RZFg2Z7K75LkVZUcZDCN9KqwEFKQacxK36sQls267T/yDFOzXluOUbaAos6QoVF0iqz+u8PHEGCB2I6nwKlYpteMtBIgfvhAjRmQ34a/P/aYYUEd0XSPA94jejR/b8jBkNAz17p5gtYTUedYX+13B2gGeH1iiGAlARMNahE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(366004)(396003)(376002)(39860400002)(478600001)(8676002)(6486002)(54906003)(8936002)(4326008)(16576012)(316002)(186003)(2906002)(86362001)(31696002)(83380400001)(6666004)(26005)(2616005)(16526019)(956004)(5660300002)(6916009)(66476007)(36756003)(66556008)(66946007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aUZTY1g3RXUxOEhKY3lsSnZZYXZsQXgzWlVHdlRUcXFkaXRUZEVSUDdCQjdI?= =?utf-8?B?bU1OUC8wS0ZYSWdKd0FwdEVJVm91K3EyK1BLS3ZZQ3N0bXBvYmZRd1FCeHVk?= =?utf-8?B?UVBzSzVhVFBtdzdhR05uV3VMZi8rRUpPK29yRTk0aDBqcUZsOE5TdVVaaWp0?= =?utf-8?B?NkkwUUFxVGZMcDdLWVB5REtyS2ZGclN3akZTVWgrOXE2Tk1GL3ZIK1R6R284?= =?utf-8?B?V3dEcHBMN3NyNFFPT2JzcCtkNUtpRHBISlVpblR2NFJNOUJGM0ZydVpFT0dG?= =?utf-8?B?ajJrd2swTEl4LzRsVi9RYVIzeHFLUTdtVVFIRXlNRzEwTFhsb0RDT2oyeWx4?= =?utf-8?B?bENTazBnWDZnbjRFNGxrcDBKT0FVU2k4aWtDRVZCZHo0ZUZsYXY1eXp3OGI1?= =?utf-8?B?TytJclNMRkRDNVAyTHlNWHk5K1RxbVp5Q3FHSmx1SENoc1c3OCtzV3UwYlh0?= =?utf-8?B?c3RyNitXQ08xdFJGUDBXa1BqdEFkM0lFZy9iNFM4VHAyRTFIR0g1UEhwVDJm?= =?utf-8?B?U1pORVVYN0lWOExoM0dKKzdiL0w0YkozcFFaSllSWnRHQmgxanVjRmd1RHJG?= =?utf-8?B?bThRUDg0cGhtaS9OTjIwWU5XR2plZFRJc1BUb0dKUVFEZ3M1NXhvRUNVSlFl?= =?utf-8?B?T1M1QWNZNkJUNVdCZGFiWXRNWDErdzF1dFVUWEV6TFYyakZhYzl1MU9JREpY?= =?utf-8?B?VTl2MncxN0ZoUGlTNllHUHVkSk1OdWdKOUVJc2VEcHpKTzZxTEl2a0JKZE8x?= =?utf-8?B?NjlSZHZnZy80V1RORjBZYVB5M1RhYlZLSko0MXpzcW1qU1pzNzQrZER4WHBi?= =?utf-8?B?V0RHelREbGxwS2lHWStXVXk4SjJnZ2Z5SHVGYVlJbWZqMFB6TUo1ODdQNTUy?= =?utf-8?B?WHFiclNVV2xacFJRMXZDYmcxdlFBRmg2SktYUVNiRUQxVlZRYmlSbStRYUZ3?= =?utf-8?B?MElpWnVYNXhqd1M1WEJOeG1jMjY0aDdJWmdhVHlrMFU4N3FCOE9pVENQWWpU?= =?utf-8?B?MHNxNisxaXZ6U1dkb0JsU2k1YnRvWWRlVTUwYVhEQWYydEhlSEM4UXg1WW8x?= =?utf-8?B?VTNGMS9POTc2ZGROYmlTbVM1V0t3di9FWHg5aTFmS1IwcEdiZmg2OXl5RXFy?= =?utf-8?B?WS9xbFYvZTAyc1NseW5qbkRJY0tpZUFSY1BYZHVHSnhqTkZZZ2ZXNUFpVm1u?= =?utf-8?B?QmpWaU84ZGI5TFArRGxzS0Z1ektWR0F3TlRmOUlqV1B1UEVYdDZEYmtFMEZX?= =?utf-8?B?TWhIYXRiVGR0WW11blR3WFlJM2hKNTBycnZDVXFLL2x5K2JWMzhqTUNKdmpr?= =?utf-8?B?YVhwWDJFdERqMHFXOEZoTzk4NkN2L3dKMWowUDd5TmpEOVdXNXQ2UU9HdEZy?= =?utf-8?B?RzlldjNDTFhWU09tZ285d2w4QTI5SDl2elNxQ0FvZlg5QlFsNkVBOHlscTJP?= =?utf-8?B?MTJrdFNMbEFpWDlSYkpDSHRRS3RDbjBKNzFwaUgrdVdoZWhxVCtQajFDZXNN?= =?utf-8?B?aC9OeW11WnJoWDJJT1FlNTU4Vy8wRFRaaVlPY1ZQL1p1bmF6b2JENEdOdk4w?= =?utf-8?B?U29MbFVBUm5mWFI5a2xOTkdiWWxnUlExRWZpQThqMWVMWDlnSk5oZzlRVjQz?= =?utf-8?B?NEZkUW1WR1JGcDZub1o3ZjhMYlk2STM4OG43cmhnNDUzeExuV1JyTHpZcmJR?= =?utf-8?B?NDZJWUhOOXBPeVBOenpkbVhkQVRoLzdySHRZWm5RaWNIV2l2WTB5MFM3SmF1?= =?utf-8?Q?ZEN5HEl/FDZy4Bu11V7LQIERdTJVOFMC4LLN55p?= X-MS-Exchange-CrossTenant-Network-Message-Id: 05b43f74-6c43-4383-cb71-08d8dd8f202f X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2021 15:23:26.4409 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ju+gT8TDt3ht+ZkKe0Kq8HIxoqW2O8GQZmsVnFyzL/lpItYsSOY006vM4t/bfANUClMddtSK83UxipFofq5CSdKpq6QF+V1EzXqPR0td3nI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3560 X-OriginatorOrg: citrix.com Hello, This is a total mess. libxenstored does not have a stable ABI.  xenstore_lib.h contains: * struct xs_permissions, which contains an enum - one of the very common ABI traps. * the prototypes for expanding_buffer_ensure(), sanitise_value() and unsanitise_value(), which are inappropriately-namespaced symbols in libxenstore * struct expanding_buffer with a classic string-handling trap (int len). * Various xenstored-internal details such as struct xs_tdb_record_hdr, the internal permission bits, as well as stuff like xs_daemon_{root,run}dir(), and worse xs_daemon_tdb(),  which have absolutely no business being external to xenstored. Its clear that most of this shouldn't be part of libxenstore, but that ship has sailed.  3.0.3 is broken and cannot be fixed. My best suggestion is that we freeze 3.0.3 where it is, and create a 4.0 which has all of the xenstore_lib.h content deleted.  That, AFAICT, gets us something which is 99% compatible, and stands a chance of being able to kept properly stable. Thoughts? ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Mar 02 15:33:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 15:33:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92459.174368 (Exim 4.92) (envelope-from ) id 1lH71U-0001jU-00; Tue, 02 Mar 2021 15:33:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92459.174368; Tue, 02 Mar 2021 15:33:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH71T-0001jN-SQ; Tue, 02 Mar 2021 15:33:19 +0000 Received: by outflank-mailman (input) for mailman id 92459; Tue, 02 Mar 2021 15:33:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH71S-0001jI-Os for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 15:33:18 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 66eeeeda-9ab0-4c9c-b4bc-9de135446c72; Tue, 02 Mar 2021 15:33:18 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 252F4ABF4; Tue, 2 Mar 2021 15:33:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66eeeeda-9ab0-4c9c-b4bc-9de135446c72 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614699197; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VUbQBz0+/7UJgiejbhrKKI+eu6d5ntlrWmo6Po66sHY=; b=Lx4L6a2iGTfPq4EWv2NtoQQ8ktOcIzg2I98vsP9kBK5KBiSPKMaIOKdP/wKwYdHJcxz0r7 aNvR2KaG1TvL/gOzFmn1TOqRAHhMBNC03SNgVBhDDTsQWnvyftpT2U1MMP7h0VFT9ngUdY Q+l/CGi1BUJ9XNbOPnaALjLgqplXrdw= To: Andrew Cooper , xen-devel Cc: Ian Jackson , Wei Liu , Jan Beulich References: From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: xenstore_lib.h and libxenstore API/ABI problems Message-ID: Date: Tue, 2 Mar 2021 16:33:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a88a10rAWhm449WhO6nBDZTmHAzESCZZT" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --a88a10rAWhm449WhO6nBDZTmHAzESCZZT Content-Type: multipart/mixed; boundary="yU1obsVrD3PEktxFSwlBcY6o4XSgMmuD7"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Andrew Cooper , xen-devel Cc: Ian Jackson , Wei Liu , Jan Beulich Message-ID: Subject: Re: xenstore_lib.h and libxenstore API/ABI problems References: In-Reply-To: --yU1obsVrD3PEktxFSwlBcY6o4XSgMmuD7 Content-Type: multipart/mixed; boundary="------------D6B0B3E97EAA32A83E8B76D1" Content-Language: en-US This is a multi-part message in MIME format. --------------D6B0B3E97EAA32A83E8B76D1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 02.03.21 16:23, Andrew Cooper wrote: > Hello, >=20 > This is a total mess. >=20 > libxenstored does not have a stable ABI.=C2=A0 xenstore_lib.h contains:= >=20 > * struct xs_permissions, which contains an enum - one of the very commo= n > ABI traps. >=20 > * the prototypes for expanding_buffer_ensure(), sanitise_value() and > unsanitise_value(), which are inappropriately-namespaced symbols in > libxenstore >=20 > * struct expanding_buffer with a classic string-handling trap (int len)= =2E >=20 > * Various xenstored-internal details such as struct xs_tdb_record_hdr, > the internal permission bits, as well as stuff like > xs_daemon_{root,run}dir(), and worse xs_daemon_tdb(),=C2=A0 which have > absolutely no business being external to xenstored. >=20 >=20 > Its clear that most of this shouldn't be part of libxenstore, but that > ship has sailed.=C2=A0 3.0.3 is broken and cannot be fixed. >=20 > My best suggestion is that we freeze 3.0.3 where it is, and create a 4.= 0 > which has all of the xenstore_lib.h content deleted.=C2=A0 That, AFAICT= , gets > us something which is 99% compatible, and stands a chance of being able= > to kept properly stable. >=20 > Thoughts? How would that work in practice? Would we ship both libraries, or only 4.0? Juergen --------------D6B0B3E97EAA32A83E8B76D1 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------D6B0B3E97EAA32A83E8B76D1-- --yU1obsVrD3PEktxFSwlBcY6o4XSgMmuD7-- --a88a10rAWhm449WhO6nBDZTmHAzESCZZT Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA+WrwFAwAAAAAACgkQsN6d1ii/Ey9B Lgf7BiOfDePi4gXvrOKvEAnWPXi3LfzhFRufdBFK6IJTJf1QzpugZveYmeSkhAnoQrMXqAd6XyXm IcPT5wtqK1NM4kBLJ/jJiQQ1ZYlSpTxBR+fAqPNb9LTlRchh5McAnGMcgCaYgWmGL/hyhS3urzUb iwJ1xEbdHz5iEjz6q1TaLRYPxK5AEASYRgBhFQ+CF1CF4Srn5jCr5aAqDc5o7uxlS+TEPHhq5uhY QtnFO2827g1pRqZvwo8upyyFqXzIBBKTCKLQU2SKoTuI16l1bsCQ0E0nELDHib9UQGhrvfPtg7oU MepaUJhxs/YDq8bIj9ixtkhxPXpu9LNnw+/bUNyNFw== =dT+o -----END PGP SIGNATURE----- --a88a10rAWhm449WhO6nBDZTmHAzESCZZT-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 15:33:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 15:33:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92460.174380 (Exim 4.92) (envelope-from ) id 1lH71s-0001np-7E; Tue, 02 Mar 2021 15:33:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92460.174380; Tue, 02 Mar 2021 15:33:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH71s-0001ni-4C; Tue, 02 Mar 2021 15:33:44 +0000 Received: by outflank-mailman (input) for mailman id 92460; Tue, 02 Mar 2021 15:33:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH71q-0001nX-Q0; Tue, 02 Mar 2021 15:33:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH71q-0007X6-GA; Tue, 02 Mar 2021 15:33:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH71q-0003yD-6w; Tue, 02 Mar 2021 15:33:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lH71q-0001np-6R; Tue, 02 Mar 2021 15:33:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YYP//o24WolSQ2TjHAcIb3wrE1rkLFCAn5fgqC2bTOs=; b=cPoYZE8Np+w+fXZESgm4PTIu6S 7ZmFGl9w5Rl8XTbeHLpptkdwL8YWSk0dsss6UYDcjiA6EGmmE0v8yqJig8js1yTzxQxSqXjys0xn2 KLNkUJMW8PAczh9kEIjW+sT3QgPsOc9aU90RcnxWYv/UtIqnWvlcpRHVNCXIivugHDDM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 159800: all pass - PUSHED X-Osstest-Versions-This: ovmf=ef91b07388e1c0a50c604e5350eeda98428ccea6 X-Osstest-Versions-That: ovmf=0996a7883c6dd939d6e769b1ce1fd2b2e250bcfb From: osstest service owner Date: Tue, 02 Mar 2021 15:33:42 +0000 flight 159800 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/159800/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ef91b07388e1c0a50c604e5350eeda98428ccea6 baseline version: ovmf 0996a7883c6dd939d6e769b1ce1fd2b2e250bcfb Last test of basis 159792 2021-03-01 13:39:45 Z 1 days Testing same since 159800 2021-03-02 05:40:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Sheng Wei jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 0996a7883c..ef91b07388 ef91b07388e1c0a50c604e5350eeda98428ccea6 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Mar 02 15:40:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 15:40:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92475.174394 (Exim 4.92) (envelope-from ) id 1lH77u-0002DX-UN; Tue, 02 Mar 2021 15:39:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92475.174394; Tue, 02 Mar 2021 15:39:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH77u-0002DQ-RF; Tue, 02 Mar 2021 15:39:58 +0000 Received: by outflank-mailman (input) for mailman id 92475; Tue, 02 Mar 2021 15:39:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH77s-0002DI-ON; Tue, 02 Mar 2021 15:39:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH77s-0007e0-GS; Tue, 02 Mar 2021 15:39:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH77s-0004Ot-8P; Tue, 02 Mar 2021 15:39:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lH77s-0003I2-7t; Tue, 02 Mar 2021 15:39:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TqH5dNVBizKJhN/O1Fmt5glgpnjRkX/reGD3qkoNCGM=; b=N2Ah1HLAGs1Jon0mWgHV6zlDF0 2Nlg8wj9Fggjkvmu9VczL3Z4vvxo2LY4DOimkGHbSDnnohhrSEEeVUYIdIC/WkLs/Saa4G0kyXLIr AQK27cbDIZQqD7vAjCV+/cmdYyS9BxoDHPmTqJIk3nFHAP6ueeNr+u4PlYQkD3xOXi+c=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159805: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4834936549f788378918da8e9bc97df7dd3ee16d X-Osstest-Versions-That: xen=9bd9695a8bc72a86b98c0683736d2310838558fe From: osstest service owner Date: Tue, 02 Mar 2021 15:39:56 +0000 flight 159805 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159805/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 4834936549f788378918da8e9bc97df7dd3ee16d baseline version: xen 9bd9695a8bc72a86b98c0683736d2310838558fe Last test of basis 159802 2021-03-02 10:02:36 Z 0 days Testing same since 159805 2021-03-02 13:01:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Tim Deegan jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9bd9695a8b..4834936549 4834936549f788378918da8e9bc97df7dd3ee16d -> smoke From xen-devel-bounces@lists.xenproject.org Tue Mar 02 16:54:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 16:54:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92497.174409 (Exim 4.92) (envelope-from ) id 1lH8I3-00024E-9K; Tue, 02 Mar 2021 16:54:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92497.174409; Tue, 02 Mar 2021 16:54:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH8I3-000247-6L; Tue, 02 Mar 2021 16:54:31 +0000 Received: by outflank-mailman (input) for mailman id 92497; Tue, 02 Mar 2021 16:54:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH8I2-000242-4S for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 16:54:30 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 442ce265-ef4e-4851-9c62-ef0333e8a252; Tue, 02 Mar 2021 16:54:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 442ce265-ef4e-4851-9c62-ef0333e8a252 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614704068; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=e5yUiqCvuD4f+50vBDftQB9thcofM4ETGq9kM1dZUXA=; b=V/ZmpH2/p+A97iZ5qfIl08NaSSsO6b9ZYPmhETFVm4+t3wSPFgGeTTqF HGNAJhyEKwLigruNrZeungmvHSOxgpttCt1CHgFmUdIdKPwnnhgtYsbmB /eUO17TOPiFRObQSUyXAISB2wA2w3eCbZHplHFccY41R5VPewS/TRWOKJ o=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: V2e5z+RlzawdZSXba4phXi66VNDhKlB+Z2tp8AVhZ/lTqXNg4y2SycQ+2EjkJkxwl8Ei9l5n72 TRsXwUNpiPVMgRrraiT4nuN2ob9s+zRmzgxicO2mZ4xW8RHVxlbSDXuNDmJmAFNEmLtwdE8fCT CU+oELDCQBQac7szb/fK9exp79HxOass/cwvtcN6nqVr9c7f9P6/gKnyz7jYMwakoSs9e04r+C xSIC9i9PeNSEoMBqnxrPBRfUU8st0wQSEImngmPenOJpbYIOPKb6gNZ90kwLDrikPzs3O376jf /JU= X-SBRS: 5.2 X-MesageID: 38277625 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,217,1610427600"; d="scan'208";a="38277625" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bQyAx26lC0T+WhMAaHV8AaIJwwzpGrxy1vwSpqJugpLvig5CwD5i1YudRIY6s88PZdAHdkSbRcmg4PmcpR1OPbUPh84SAimlkIh1PfpW70Jvl1WLFc8MXKOgd1lCfnD9wTrVxqS0girb+KFpOyn1KwRajIYv11oSTO8xVGBJxjOidIzNn5ESfGRSDr0SvSNFn9HSaTNPl7ED8UhAsSx/Aekg6YLizKP4msxuxN0wgmLPdIuM7pzZTcRg3I2EG0+oFEyuWQeJQTNItaL6KV/FP8aOMRYtHo1WC2PksHnz6jdaC5775AMMOI6x9ATN9zBM3RVkYFeH1QJruqvsgM7tFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e5yUiqCvuD4f+50vBDftQB9thcofM4ETGq9kM1dZUXA=; b=AwROahZyRR/T9noj2x4yzOmi5s4Sw2V2SAo4kkr3GDHovZFwG6wDUavcu8E8xrm6efoNudEoz0J9bwoF+FsTgSKEfGtDphRJaRNBYemHb0RR4K7Cdw92KG0IOi1jwWoCe1+BbXrei4LR9gSg4VK2PHeJ2rYNQ8jSLsM0yBY1ucdY1MHtz2ZYCqJdaMMS0gi1IPapQ/w3GZ7S81lZW/L/tW6zBzO18ozHMq29yNU/rJq7qLSPUR+zXrJkmaedmdzK1AgOWDYtS05pkpx+9HXUfihc53hr5Uq8u1pp0B8iQMPs92EWGQPo/sxb4Bmzq5X0dUGXebjYGCRBRKX7e47cPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e5yUiqCvuD4f+50vBDftQB9thcofM4ETGq9kM1dZUXA=; b=D56wuazJPpVKAuGPPBZ9Dyetjc7hfxMr4SfWFu8XBkF1gi/JHy84VC04LLOCrIPZlOvkkqA+Q+co5PGUFaNqwiQYgIxQzbES6txuGPnBeytOEkkfCkmT/lqBiB9BiV+4LH4ntx3LP6On7zhcofsB7xKOR2vDuxhTtlVzkLiPtkw= Subject: Re: xenstore_lib.h and libxenstore API/ABI problems To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , xen-devel CC: Ian Jackson , Wei Liu , Jan Beulich References: From: Andrew Cooper Message-ID: Date: Tue, 2 Mar 2021 16:54:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0366.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d725d239-0973-4ecd-fc9e-08d8dd9bd57f X-MS-TrafficTypeDiagnostic: BYAPR03MB3688: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rz9NnStB+zBc2gxUmfRKuWEKeFhJLIAQ0Q96Py5BWfm9qkqCzGWSHnG4pB+qKlr/u7A2EbE9v/mfvKiT2Af77uTmZIte/gOEOE3Bi4eK5tZq8R1PeSBtfKUz/JvCM66EPe9NVbfd/eecn00ND1aiihNRijOwKGuKx37tOZ3IgRqxo0qZ+5TGYiorY7uueloELBV/E75VOUZk2IYlRFC+tiUNBVpcqX0912E5bTHoXo6GqOkHStDU1sMW7OTs9VDzjsxLtCNFInnblLFEPtNG23sUL5e6cDjsZBCUYQatjA67SL6WLiGeCh9YFJT5XrE4LtLdI/ocP9Noa7TWllcXZKYuEq1GpJJDQHQZ4tNG41c4qQTQspjsDL9YX6I78vT/jV9fsa865dCsUw1imkFQ7msM39ENNvPNvBONCnMVahSP3/BKWQerLt3QDDMeyiriprVx+q+tJmp2MiS7+L7uM5uEz2QPmo7tAV83aKHf6WVf3BRBApaVPtmoeHVbNKJ1ock53/6htELkkagjOt9cYLNLBLZR4Px8PPl9yy5WwYnGjWGVnM9QkY4lc3ffvfHc4BcZlnUPNW0WM9yQFr4us02HtC8icukXY0YItPYAob4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(376002)(346002)(39860400002)(396003)(8676002)(54906003)(53546011)(86362001)(110136005)(31696002)(36756003)(2906002)(66476007)(66574015)(8936002)(26005)(66946007)(66556008)(478600001)(16576012)(4326008)(186003)(316002)(5660300002)(31686004)(2616005)(956004)(83380400001)(6486002)(6666004)(16526019)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?SG9YbU1aY1R3N3ZiNmFjMHdyZnFwekJDbGdyQXkvNzVFNDRGUFNoL0xTa1Q0?= =?utf-8?B?MnphLyt2aEt5RGtHZUI0SVhWWFltN0laLzlXc2QwT29pSEV6aldPa01IeldF?= =?utf-8?B?MXBoTmlKaEpFa3g4Q2pjRVMvZEZ0emRoUEthT215MHlFVUlxWllROUFzK3Nj?= =?utf-8?B?TUE0TE90UU0zL3pxQUx2RktXMlN1ZzBsSnNjT0lEdjVTcXNhK2E1ckEzalp3?= =?utf-8?B?czdzV0YxRFpmTmlxSFNMNnFLMXFzOEtSK1RVQmlXZVFiWU90c0VCSzRZNi84?= =?utf-8?B?ai9ZK0RtWUlnKzhDNnFXVndhQUZGbzk1QzVvTEtPY0pCVGRRYVN2VWF0S0Iw?= =?utf-8?B?ZzZFQXRpRS9mMzV3QnBFTDVFM1ppMTBocFc3U1Fyd1BzdzRkZCs3aGdsbkIx?= =?utf-8?B?UUdiUStVR2N3K2NoWHE2UGZoaTlpNlhSTzlkV1pEWllqMzJyblZqOGxWd0FF?= =?utf-8?B?c1RLY2dvNnBqc2RnQUtGbE41KzU4Q1ZVYWllTWR4TFRzZ0w4bitxYi9PYlF4?= =?utf-8?B?S3VEZWdaSXcvOFFLdkZ1cUVPYW0rWGVvQjVIbEFWYW03RElaalorZFFtY0hk?= =?utf-8?B?Z3c1cHFlcXhyeTBGWHRQZkJTS0swNmZVMHlwUFJ4S1lSQ3BGcHdVeHJlMTNa?= =?utf-8?B?UVNBekNGT0RwcGcrUlU1N1NmQ1NtelZ2MTJlUEpXL1J6SzZyK1g2dDdRRWxi?= =?utf-8?B?SHQ0WVhpQ2U1eU1JV0YzZzkrU1BkN0xaNWdrdnZDTmhGb3hRZFQ1Sy9CVFJu?= =?utf-8?B?dnVaMzdVMUZHdjhGd3N2RDJndUJnQWJsMEVwQ0owY0JWNFpMQkVuSW9lSjZJ?= =?utf-8?B?czhYZDJGbC9HUm9EWERXTGgzeUtlUDZFWHRZSEkvdnR5L25sNE9oTFhwMis0?= =?utf-8?B?WnI2alRacjZpbDM0K2xIWDdXVzlQR1lPYklJT0ZrMW9PQUV5Y2hPbGltRW4z?= =?utf-8?B?VFRyN2RudU4zNHhGYjNxMnlQRkNiN3g3ZVdva0RPbWVqVkcvQjdBR090U0FW?= =?utf-8?B?VkhFV0t4bUREL1EzalNONHhONnFIVmxqelEzSnd2Vjd0WUVrNUUrZm10MmM2?= =?utf-8?B?cjhleGZvbnpmd1IxampUNExpVlBiSFdjU0dXMURwWGpFb0ErK0lUSC9hbTln?= =?utf-8?B?S3RBMUc1TEpMbXFCWTlTeTBRenJpYlNNU0lvQmNHU21LUE9KN1ZEcmkzUm9Z?= =?utf-8?B?cjlsYU1jL0RXYVo0d1d3M2pKQUhMVHhZQ2l2NXhGeG9iN25LTDIzTzFieDN5?= =?utf-8?B?QjRnMXVUZVJvai9YN2hOUGErSDlGcXF3R3BoN0swRU5iWFR5bXZWOFpmZ3lQ?= =?utf-8?B?L3JUdmFoWUdmQ0pHd2hGZUx4SlIwSmpKTDB3SUhqVjZYeEJtS25mVUhkZ2ZD?= =?utf-8?B?NFVWK3VEdzVJeWkvNVU0ZU1oSWlzODBUT0tFK0FXdENwcWtXaHVxdVpSK2d6?= =?utf-8?B?L1ZuNGd6bzhnNTA0eStOaFZsbkJOd2l4YldELzZIcnh5MmRlK0NEWGNJbDdI?= =?utf-8?B?bHRXMFB5VWc3enNzM01OcnVDa0xwYmxvbXNKbFNVWDZ2M3RWaGRFNitsaDZP?= =?utf-8?B?bjc5OXRIb21ocVYvMlJxdVBDb29Va3lJS1I2WUZZblFURkl4RzNaU3ZiOUNE?= =?utf-8?B?SEYyN1ZxZno2c2gyYVk3alYrTENiY3pCTkllMEVOUEtGRGFjWDlpQ3E2RWRG?= =?utf-8?B?aTF5dEJSR2tEdVQ2TmNwa1dCYzA1dE1CdVE1NW1jM3ZTZm5tQTh3Y3BhaWVv?= =?utf-8?Q?sTBgJdh00Yxmnr2acar6Gtgy6L+B8ANZBMjxDHn?= X-MS-Exchange-CrossTenant-Network-Message-Id: d725d239-0973-4ecd-fc9e-08d8dd9bd57f X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2021 16:54:24.7267 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h1DrXzVUkoZ1Hd9XaZFeI/zC8oNOeASlN/zRoSQN40ein49qWHIvfttDOGuT6BXEp5BmNrBPsmLc6ShAa2m8gVtZ13rzW5alJ1f6asztyHg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3688 X-OriginatorOrg: citrix.com On 02/03/2021 15:33, Jürgen Groß wrote: > On 02.03.21 16:23, Andrew Cooper wrote: >> Hello, >> >> This is a total mess. >> >> libxenstored does not have a stable ABI.  xenstore_lib.h contains: >> >> * struct xs_permissions, which contains an enum - one of the very common >> ABI traps. >> >> * the prototypes for expanding_buffer_ensure(), sanitise_value() and >> unsanitise_value(), which are inappropriately-namespaced symbols in >> libxenstore >> >> * struct expanding_buffer with a classic string-handling trap (int len). >> >> * Various xenstored-internal details such as struct xs_tdb_record_hdr, >> the internal permission bits, as well as stuff like >> xs_daemon_{root,run}dir(), and worse xs_daemon_tdb(),  which have >> absolutely no business being external to xenstored. >> >> >> Its clear that most of this shouldn't be part of libxenstore, but that >> ship has sailed.  3.0.3 is broken and cannot be fixed. >> >> My best suggestion is that we freeze 3.0.3 where it is, and create a 4.0 >> which has all of the xenstore_lib.h content deleted.  That, AFAICT, gets >> us something which is 99% compatible, and stands a chance of being able >> to kept properly stable. >> >> Thoughts? > > How would that work in practice? > > Would we ship both libraries, or only 4.0? I *think* we can create 4.0 with just a tweak to the map file.  Then, we could build 3.0.3 side by side with 4.0. We already have the compat for xenstore/xs{,lib}.h which adds to this mess.  I was thinking of adding a build time "want xenstore compat" option which gets you 3.0.3 and the badly-named headers. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Mar 02 17:24:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 17:24:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92512.174422 (Exim 4.92) (envelope-from ) id 1lH8kn-0005BP-OH; Tue, 02 Mar 2021 17:24:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92512.174422; Tue, 02 Mar 2021 17:24:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH8kn-0005BI-KI; Tue, 02 Mar 2021 17:24:13 +0000 Received: by outflank-mailman (input) for mailman id 92512; Tue, 02 Mar 2021 17:24:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH8km-0005BD-6Y for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 17:24:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH8km-0001US-2D for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 17:24:12 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lH8kl-0005AM-Vt for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 17:24:11 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lH8kh-00083h-4I; Tue, 02 Mar 2021 17:24:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=IUwfGLAvyw3DaspY6ewRjpbKrYG7c3TLvx2V98rwIsc=; b=gILBC3Qfv5OBpXA9U1xoRgalwp M9Z/bq3NRdrglfYQGNSrgamxcHoE0glTi28Jhr1BorXdDThXzAoABpd9Mx4dppIFV6RA9T1V09QRX /Eg8M3vXfgGMs6Ev80OkUJ+nEK9zokQ+NLUz32vTShNSbP2y0cpgrvTyJwx1Ev0sinZM=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24638.29878.870671.474761@mariner.uk.xensource.com> Date: Tue, 2 Mar 2021 17:24:06 +0000 To: Andrew Cooper Cc: xen-devel , Juergen Gross , Wei Liu , Jan Beulich Subject: Re: xenstore_lib.h and libxenstore API/ABI problems In-Reply-To: References: X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("xenstore_lib.h and libxenstore API/ABI problems"): > libxenstored does not have a stable ABI. xenstore_lib.h contains: > > * struct xs_permissions, which contains an enum - one of the very common > ABI traps. enums are a problem when used as paraeter or return values or in structs. The mere *definition* of an enum is not a problem, although it is a programmer hazard because it's an invitation to ABI fail. But I think this is less bad in practice than we fear because we need only concern ourselves with ABIs which can run on Xen-supported CPUs, and for which these tools libraries might plausibly have been compiled. That means modern 32- and 64-bit x86 and ARM. I think on all such systems, an enum with values that will fit into an int, is precisely an int in the ABI. (I checked that this is true in practice on an ARM32 Linux poerterbox belonging to the Debian Project.) In which case we can change all of the formal parameters and struct members from "enum xs_perm_type" to "int" and their ABI will remain the same on all supported platforms. > * the prototypes for expanding_buffer_ensure(), sanitise_value() and > unsanitise_value(), which are inappropriately-namespaced symbols in > libxenstore I think it is unlikely that anything outside the Xen tools libraries will link against these. If anything, it is more likely that any such linkage is a name clash. I also think that a breach of ABI rules has no actual bad consequences unless the symbol is actually referenced from a different executable or DSO - and, specifically, an executable or DSO which is not co-upgraded with the one at issue. > * struct expanding_buffer with a classic string-handling trap (int len). You mean that it should be a size_t, I suppose. But I think this is academic given that we want to de-publicise this. > * Various xenstored-internal details such as struct xs_tdb_record_hdr, > the internal permission bits, as well as stuff like > xs_daemon_{root,run}dir(), and worse xs_daemon_tdb(), which have > absolutely no business being external to xenstored. I think it is almost inconceivable that anyone has linked against these symbols. > My best suggestion is that we freeze 3.0.3 where it is, and create a 4.0 > which has all of the xenstore_lib.h content deleted. That, AFAICT, gets > us something which is 99% compatible, and stands a chance of being able > to kept properly stable. I suggest, instead, that we: In 4.15: * Retain the current soname, but: * Delete the tdb internals from the header file and cease to export those symbols. * Rename the expanding_buffer and sanitise_value functions, to properly namespace them, and move them to a private header. This is of course technically a breach of the ABI stability rules but for the reasons I giveabove I don't think it will cause anyone any trouble. In xen-next: * Prophilactically change the uses of "enum xs_perm_type" to "int" * Or, add XS__PERM_TYPE_ENSURE_ABI = 0x7fffffff to the enum. Ian. From xen-devel-bounces@lists.xenproject.org Tue Mar 02 18:02:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 18:02:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92536.174451 (Exim 4.92) (envelope-from ) id 1lH9Lo-00014m-2l; Tue, 02 Mar 2021 18:02:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92536.174451; Tue, 02 Mar 2021 18:02:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH9Ln-00014f-W3; Tue, 02 Mar 2021 18:02:27 +0000 Received: by outflank-mailman (input) for mailman id 92536; Tue, 02 Mar 2021 18:02:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH9Lm-00014a-8k for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 18:02:26 +0000 Received: from forwardcorp1o.mail.yandex.net (unknown [95.108.205.193]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0fdcadd3-8d89-4f3e-a28e-69a87c83f820; Tue, 02 Mar 2021 18:02:23 +0000 (UTC) Received: from myt5-23f0be3aa648.qloud-c.yandex.net (myt5-23f0be3aa648.qloud-c.yandex.net [IPv6:2a02:6b8:c12:3e29:0:640:23f0:be3a]) by forwardcorp1o.mail.yandex.net (Yandex) with ESMTP id 5F3452E159D; Tue, 2 Mar 2021 21:02:21 +0300 (MSK) Received: from myt5-70c90f7d6d7d.qloud-c.yandex.net (myt5-70c90f7d6d7d.qloud-c.yandex.net [2a02:6b8:c12:3e2c:0:640:70c9:f7d]) by myt5-23f0be3aa648.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id AabajxEOFm-2JxSLNDf; Tue, 02 Mar 2021 21:02:21 +0300 Received: from dynamic-vpn.dhcp.yndx.net (dynamic-vpn.dhcp.yndx.net [2a02:6b8:b080:8002::1:1a]) by myt5-70c90f7d6d7d.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id onVeXhLyoo-2Io02V9K; Tue, 02 Mar 2021 21:02:19 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 0fdcadd3-8d89-4f3e-a28e-69a87c83f820 Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1614708141; bh=mWKMmE6/68gzbOL2eN6sq4/sF3RMZWcJV9Nbs34UHA8=; h=Message-Id:Date:Subject:To:From:Cc; b=lbBmMabdS/ETQnzfWQmLx3rqK7Z0qGw/iIzMGVpEnz3zW1D1YoTC1ZMVVagWGearw Xftt/sFk8W4RDClGqymlft+mr27k+vTp59n0nREEdJqofysA4FEN4dv4o3MeMFll1P 1CjqNa9fVCXSNTJcsnNne7bCKjqWjR2639SQR4B4= Authentication-Results: myt5-23f0be3aa648.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Alexey Kirillov To: Jason Wang , Markus Armbruster , Thomas Huth , Eric Blake Cc: Laurent Vivier , Samuel Thibault , "Michael S. Tsirkin" , Michael Roth , Paolo Bonzini , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Stefan Weil , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, yc-core@yandex-team.ru Subject: [PATCH v6 0/5] Introducing QMP query-netdev command Date: Tue, 2 Mar 2021 21:02:00 +0300 Message-Id: <20210302180205.5009-1-lekiravi@yandex-team.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series introduces a new QMP command "query-netdev" to get information about currently attached backend network devices (netdevs). Also, since the "info_str" field of "NetClientState" is now deprecated, we no longer use it for netdevs, only for NIC/hubports. The HMP command "info network" now also uses QAPI structure inside. Usage example: -> { "execute": "query-netdev" } <- { "return": [ { "listen": "127.0.0.1:90", "type": "socket", "peer-id": "hub0port1", "id": "__org.qemu.net1" }, { "script": "/etc/qemu-ifup", "downscript": "/etc/qemu-ifdown", "ifname": "tap0", "type": "tap", "peer-id": "net5", "vnet_hdr": true, "id": "tap0" }, { "ipv6": true, "ipv4": true, "host": "10.0.2.2", "ipv6-dns": "fec0::3", "ipv6-prefix": "fec0::", "net": "10.0.2.0/255.255.255.0", "ipv6-host": "fec0::2", "type": "user", "peer-id": "net0", "dns": "10.0.2.3", "hostfwd": [ { "str": "tcp::20004-:22" } ], "ipv6-prefixlen": 64, "id": "netdev0", "restrict": false } ] } v5->v6: - Add QAPI visitor to generate info_str replacement directly from NetdevInfo. - Make info_str dynamically allocated. - Make commit messages more meaningful. v4->v5: - Enable qtest of query-netdevs for AVR and RX archs. - Bump "Since" version in QAPI to 6.0. v3->v4: - Rename "query-netdevs" to "query-netdev". - Copy netdev drivers to new QAPI enum "NetBackend". v2->v3: - Remove NIC and hubports from query-netdevs. - Remove several fields from NetdevInfo since they are unnecessary. - Rename field @peer to @peer-id. - Add support of vhost-vdpa. - Keep "info_str" for NIC/hubports, but remove it for netdevs. v1->v2: - Rewrite HMP "info network" to get information from results of QMP command. - Remove obsolete field "info_str" from "NetClientState". Alexey Kirillov (5): qapi: net: Add query-netdev command tests: Add tests for query-netdev command net: Move NetClientState.info_str to dynamic allocations hmp: Use QAPI NetdevInfo in hmp_info_network net: Do not fill legacy info_str for backends hw/net/xen_nic.c | 5 +- include/net/net.h | 5 +- include/qapi/hmp-output-visitor.h | 30 +++++ net/l2tpv3.c | 8 +- net/net.c | 75 ++++++++++-- net/netmap.c | 7 ++ net/slirp.c | 126 ++++++++++++++++++- net/socket.c | 92 ++++++++++---- net/tap-win32.c | 10 +- net/tap.c | 107 +++++++++++++++-- net/vde.c | 25 +++- net/vhost-user.c | 20 +++- net/vhost-vdpa.c | 15 ++- qapi/hmp-output-visitor.c | 193 ++++++++++++++++++++++++++++++ qapi/meson.build | 1 + qapi/net.json | 80 +++++++++++++ tests/qtest/meson.build | 3 + tests/qtest/test-query-netdev.c | 120 +++++++++++++++++++ 18 files changed, 860 insertions(+), 62 deletions(-) create mode 100644 include/qapi/hmp-output-visitor.h create mode 100644 qapi/hmp-output-visitor.c create mode 100644 tests/qtest/test-query-netdev.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 02 18:02:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 18:02:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92538.174476 (Exim 4.92) (envelope-from ) id 1lH9M7-0001AS-PM; Tue, 02 Mar 2021 18:02:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92538.174476; Tue, 02 Mar 2021 18:02:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH9M7-0001AL-La; Tue, 02 Mar 2021 18:02:47 +0000 Received: by outflank-mailman (input) for mailman id 92538; Tue, 02 Mar 2021 18:02:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH9M6-0001A7-Q0 for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 18:02:46 +0000 Received: from forwardcorp1p.mail.yandex.net (unknown [77.88.29.217]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 34ed40f2-4132-4554-974b-eafb4724af79; Tue, 02 Mar 2021 18:02:44 +0000 (UTC) Received: from myt5-23f0be3aa648.qloud-c.yandex.net (myt5-23f0be3aa648.qloud-c.yandex.net [IPv6:2a02:6b8:c12:3e29:0:640:23f0:be3a]) by forwardcorp1p.mail.yandex.net (Yandex) with ESMTP id 6CF852E09D4; Tue, 2 Mar 2021 21:02:42 +0300 (MSK) Received: from myt5-70c90f7d6d7d.qloud-c.yandex.net (myt5-70c90f7d6d7d.qloud-c.yandex.net [2a02:6b8:c12:3e2c:0:640:70c9:f7d]) by myt5-23f0be3aa648.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id lmUsbFKo90-2fxmmeFt; Tue, 02 Mar 2021 21:02:42 +0300 Received: from dynamic-vpn.dhcp.yndx.net (dynamic-vpn.dhcp.yndx.net [2a02:6b8:b080:8002::1:1a]) by myt5-70c90f7d6d7d.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id onVeXhLyoo-2Yo0BdQP; Tue, 02 Mar 2021 21:02:41 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 34ed40f2-4132-4554-974b-eafb4724af79 Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1614708162; bh=TClaDRzxQB4h6SlKaYxQXAsUYr6qhA7dXnvUiqCeKqs=; h=In-Reply-To:Message-Id:References:Date:Subject:To:From:Cc; b=o9ZrIKFKO4+fYG4dn+TTQGvl83wVWrPDV0Dx3djfpLfMIK1k8O4wIpzPMbmmGAdtq NXq07ecOb+0Ut+mx+DAy9nVCdCtj3dsskrr3ciSIXblKxenAZyZIt5YANUACJPgLEH 98+/NK09wDtO1WPdpXoiUlsELSxqvkl0Uskqt/M0= Authentication-Results: myt5-23f0be3aa648.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Alexey Kirillov To: Jason Wang , Markus Armbruster , Thomas Huth , Eric Blake Cc: Laurent Vivier , Samuel Thibault , "Michael S. Tsirkin" , Michael Roth , Paolo Bonzini , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Stefan Weil , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, yc-core@yandex-team.ru Subject: [PATCH v6 2/5] tests: Add tests for query-netdev command Date: Tue, 2 Mar 2021 21:02:02 +0300 Message-Id: <20210302180205.5009-3-lekiravi@yandex-team.ru> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210302180205.5009-1-lekiravi@yandex-team.ru> References: <20210302180205.5009-1-lekiravi@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A simply qtest that checks for correct number of netdevs in the response of the query-netdev. Signed-off-by: Alexey Kirillov Acked-by: Thomas Huth --- tests/qtest/meson.build | 3 + tests/qtest/test-query-netdev.c | 120 ++++++++++++++++++++++++++++++++ 2 files changed, 123 insertions(+) create mode 100644 tests/qtest/test-query-netdev.c diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index ba6ecaed32..fefe3da3c3 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -17,6 +17,9 @@ qtests_generic = [ if config_host.has_key('CONFIG_MODULES') qtests_generic += [ 'modules-test' ] endif +if slirp.found() + qtests_generic += [ 'test-query-netdev' ] +endif qtests_pci = \ (config_all_devices.has_key('CONFIG_VGA') ? ['display-vga-test'] : []) + \ diff --git a/tests/qtest/test-query-netdev.c b/tests/qtest/test-query-netdev.c new file mode 100644 index 0000000000..1118537a9f --- /dev/null +++ b/tests/qtest/test-query-netdev.c @@ -0,0 +1,120 @@ +/* + * QTest testcase for the query-netdev + * + * Copyright Yandex N.V., 2019 + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + * + */ + +#include "qemu/osdep.h" + +#include "libqos/libqtest.h" +#include "qapi/qmp/qdict.h" +#include "qapi/qmp/qlist.h" + +/* + * Events can get in the way of responses we are actually waiting for. + */ +GCC_FMT_ATTR(2, 3) +static QObject *wait_command(QTestState *who, const char *command, ...) +{ + va_list ap; + QDict *response; + QObject *result; + + va_start(ap, command); + qtest_qmp_vsend(who, command, ap); + va_end(ap); + + response = qtest_qmp_receive(who); + + result = qdict_get(response, "return"); + g_assert(result); + qobject_ref(result); + qobject_unref(response); + + return result; +} + +static void qmp_query_netdev_no_error(QTestState *qts, size_t netdevs_count) +{ + QObject *resp; + QList *netdevs; + + resp = wait_command(qts, "{'execute': 'query-netdev'}"); + + netdevs = qobject_to(QList, resp); + g_assert(netdevs); + g_assert(qlist_size(netdevs) == netdevs_count); + + qobject_unref(resp); +} + +static void test_query_netdev(void) +{ + const char *arch = qtest_get_arch(); + QObject *resp; + QTestState *state; + + /* Choosing machine for platforms without default one */ + if (g_str_equal(arch, "arm") || + g_str_equal(arch, "aarch64")) { + state = qtest_init( + "-nodefaults " + "-M virt " + "-netdev user,id=slirp0"); + } else if (g_str_equal(arch, "tricore")) { + state = qtest_init( + "-nodefaults " + "-M tricore_testboard " + "-netdev user,id=slirp0"); + } else if (g_str_equal(arch, "avr")) { + state = qtest_init( + "-nodefaults " + "-M mega2560 " + "-netdev user,id=slirp0"); + } else if (g_str_equal(arch, "rx")) { + state = qtest_init( + "-nodefaults " + "-M gdbsim-r5f562n8 " + "-netdev user,id=slirp0"); + } else { + state = qtest_init( + "-nodefaults " + "-netdev user,id=slirp0"); + } + g_assert(state); + + qmp_query_netdev_no_error(state, 1); + + resp = wait_command(state, + "{'execute': 'netdev_add', 'arguments': {" + " 'id': 'slirp1'," + " 'type': 'user'}}"); + qobject_unref(resp); + + qmp_query_netdev_no_error(state, 2); + + resp = wait_command(state, + "{'execute': 'netdev_del', 'arguments': {" + " 'id': 'slirp1'}}"); + qobject_unref(resp); + + qmp_query_netdev_no_error(state, 1); + + qtest_quit(state); +} + +int main(int argc, char **argv) +{ + int ret = 0; + g_test_init(&argc, &argv, NULL); + + qtest_add_func("/net/qapi/query_netdev", test_query_netdev); + + ret = g_test_run(); + + return ret; +} -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 02 18:02:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 18:02:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92539.174487 (Exim 4.92) (envelope-from ) id 1lH9MC-0001DV-23; Tue, 02 Mar 2021 18:02:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92539.174487; Tue, 02 Mar 2021 18:02:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH9MB-0001DG-Uy; Tue, 02 Mar 2021 18:02:51 +0000 Received: by outflank-mailman (input) for mailman id 92539; Tue, 02 Mar 2021 18:02:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH9MA-0001A7-5K for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 18:02:50 +0000 Received: from forwardcorp1p.mail.yandex.net (unknown [2a02:6b8:0:1472:2741:0:8b6:217]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 032fef6a-14cd-4f81-af75-f04b76daadb5; Tue, 02 Mar 2021 18:02:48 +0000 (UTC) Received: from myt5-23f0be3aa648.qloud-c.yandex.net (myt5-23f0be3aa648.qloud-c.yandex.net [IPv6:2a02:6b8:c12:3e29:0:640:23f0:be3a]) by forwardcorp1p.mail.yandex.net (Yandex) with ESMTP id 23B5C2E14F1; Tue, 2 Mar 2021 21:02:47 +0300 (MSK) Received: from myt5-70c90f7d6d7d.qloud-c.yandex.net (myt5-70c90f7d6d7d.qloud-c.yandex.net [2a02:6b8:c12:3e2c:0:640:70c9:f7d]) by myt5-23f0be3aa648.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id itqAQmwSu5-2jxqXt4S; Tue, 02 Mar 2021 21:02:47 +0300 Received: from dynamic-vpn.dhcp.yndx.net (dynamic-vpn.dhcp.yndx.net [2a02:6b8:b080:8002::1:1a]) by myt5-70c90f7d6d7d.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id onVeXhLyoo-2io0bRhB; Tue, 02 Mar 2021 21:02:45 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 032fef6a-14cd-4f81-af75-f04b76daadb5 Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1614708167; bh=4dP4btjH/JUluQZrX9OiL/COvOORU8agWRC4rEjZ/cw=; h=In-Reply-To:Message-Id:References:Date:Subject:To:From:Cc; b=g4K6OptbJ9pfErgzapKX07gXk0MxSoJLFK8KxtTqMf8/YjaBa1ezWVYCMUzJ916ea TTWTEf/erLYHxnRieJigvi8MRr1v35kKFHxQlFsGwpI6BqYDO0wRmtU/asT7prATh7 aeIrQWCSrAHtSsdzgRq/aMB1l7NSH4jZobn9XFOc= Authentication-Results: myt5-23f0be3aa648.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Alexey Kirillov To: Jason Wang , Markus Armbruster , Thomas Huth , Eric Blake Cc: Laurent Vivier , Samuel Thibault , "Michael S. Tsirkin" , Michael Roth , Paolo Bonzini , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Stefan Weil , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, yc-core@yandex-team.ru Subject: [PATCH v6 3/5] net: Move NetClientState.info_str to dynamic allocations Date: Tue, 2 Mar 2021 21:02:03 +0300 Message-Id: <20210302180205.5009-4-lekiravi@yandex-team.ru> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210302180205.5009-1-lekiravi@yandex-team.ru> References: <20210302180205.5009-1-lekiravi@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The info_str field of the NetClientState structure is static and has a size of 256 bytes. This amount is often unclaimed, and the field itself is used exclusively for HMP "info network". The patch translates info_str to dynamic memory allocation. This action is also allows us to painlessly discard usage of this field for backend devices. Signed-off-by: Alexey Kirillov --- hw/net/xen_nic.c | 5 ++--- include/net/net.h | 2 +- net/l2tpv3.c | 3 +-- net/net.c | 14 ++++++++------ net/slirp.c | 5 ++--- net/socket.c | 43 ++++++++++++++++++++++++------------------- net/tap-win32.c | 3 +-- net/tap.c | 13 +++++-------- net/vde.c | 3 +-- net/vhost-user.c | 3 +-- net/vhost-vdpa.c | 2 +- 11 files changed, 47 insertions(+), 49 deletions(-) diff --git a/hw/net/xen_nic.c b/hw/net/xen_nic.c index 5c815b4f0c..8431808ea0 100644 --- a/hw/net/xen_nic.c +++ b/hw/net/xen_nic.c @@ -296,9 +296,8 @@ static int net_init(struct XenLegacyDevice *xendev) netdev->nic = qemu_new_nic(&net_xen_info, &netdev->conf, "xen", NULL, netdev); - snprintf(qemu_get_queue(netdev->nic)->info_str, - sizeof(qemu_get_queue(netdev->nic)->info_str), - "nic: xenbus vif macaddr=%s", netdev->mac); + qemu_get_queue(netdev->nic)->info_str = g_strdup_printf( + "nic: xenbus vif macaddr=%s", netdev->mac); /* fill info */ xenstore_write_be_int(&netdev->xendev, "feature-rx-copy", 1); diff --git a/include/net/net.h b/include/net/net.h index 162fd3f1b5..7039eb280a 100644 --- a/include/net/net.h +++ b/include/net/net.h @@ -94,7 +94,7 @@ struct NetClientState { NetQueue *incoming_queue; char *model; char *name; - char info_str[256]; + char *info_str; NetdevInfo *stored_config; unsigned receive_disabled : 1; NetClientDestructor *destructor; diff --git a/net/l2tpv3.c b/net/l2tpv3.c index 8aa0a3e1a0..96611cb4af 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -730,8 +730,7 @@ int net_init_l2tpv3(const Netdev *netdev, QAPI_CLONE_MEMBERS(NetdevL2TPv3Options, &nc->stored_config->u.l2tpv3, l2tpv3); - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "l2tpv3: connected"); + s->nc.info_str = g_strdup_printf("l2tpv3: connected"); return 0; outerr: qemu_del_net_client(nc); diff --git a/net/net.c b/net/net.c index 9b213f72d2..cc83918d80 100644 --- a/net/net.c +++ b/net/net.c @@ -128,11 +128,12 @@ char *qemu_mac_strdup_printf(const uint8_t *macaddr) void qemu_format_nic_info_str(NetClientState *nc, uint8_t macaddr[6]) { - snprintf(nc->info_str, sizeof(nc->info_str), - "model=%s,macaddr=%02x:%02x:%02x:%02x:%02x:%02x", - nc->model, - macaddr[0], macaddr[1], macaddr[2], - macaddr[3], macaddr[4], macaddr[5]); + g_free(nc->info_str); + nc->info_str = g_strdup_printf( + "model=%s,macaddr=%02x:%02x:%02x:%02x:%02x:%02x", + nc->model, + macaddr[0], macaddr[1], macaddr[2], + macaddr[3], macaddr[4], macaddr[5]); } static int mac_table[256] = {0}; @@ -351,6 +352,7 @@ static void qemu_free_net_client(NetClientState *nc) } g_free(nc->name); g_free(nc->model); + g_free(nc->info_str); qapi_free_NetdevInfo(nc->stored_config); if (nc->destructor) { nc->destructor(nc); @@ -1197,7 +1199,7 @@ void print_net_client(Monitor *mon, NetClientState *nc) monitor_printf(mon, "%s: index=%d,type=%s,%s\n", nc->name, nc->queue_index, NetClientDriver_str(nc->info->type), - nc->info_str); + nc->info_str ? nc->info_str : ""); if (!QTAILQ_EMPTY(&nc->filters)) { monitor_printf(mon, "filters:\n"); } diff --git a/net/slirp.c b/net/slirp.c index 5f126d7cf5..f8b3636fcc 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -669,9 +669,8 @@ static int net_slirp_init(NetClientState *peer, const char *model, stored->tftp_server_name = g_strdup(tftp_server_name); } - snprintf(nc->info_str, sizeof(nc->info_str), - "net=%s,restrict=%s", inet_ntoa(net), - restricted ? "on" : "off"); + nc->info_str = g_strdup_printf("net=%s,restrict=%s", inet_ntoa(net), + restricted ? "on" : "off"); s = DO_UPCAST(SlirpState, nc, nc); diff --git a/net/socket.c b/net/socket.c index 1614523b82..98172347d7 100644 --- a/net/socket.c +++ b/net/socket.c @@ -180,7 +180,8 @@ static void net_socket_send(void *opaque) s->fd = -1; net_socket_rs_init(&s->rs, net_socket_rs_finalize, false); s->nc.link_down = true; - memset(s->nc.info_str, 0, sizeof(s->nc.info_str)); + g_free(s->nc.info_str); + s->nc.info_str = g_new0(char, 1); return; } @@ -400,16 +401,16 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer, stored->mcast = g_strdup(mcast); s->dgram_dst = saddr; - snprintf(nc->info_str, sizeof(nc->info_str), - "socket: fd=%d (cloned mcast=%s:%d)", - fd, inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); + nc->info_str = g_strdup_printf("socket: fd=%d (cloned mcast=%s:%d)", + fd, inet_ntoa(saddr.sin_addr), + ntohs(saddr.sin_port)); } else { if (sa_type == SOCKET_ADDRESS_TYPE_UNIX) { s->dgram_dst.sin_family = AF_UNIX; } - snprintf(nc->info_str, sizeof(nc->info_str), - "socket: fd=%d %s", fd, SocketAddressType_str(sa_type)); + nc->info_str = g_strdup_printf("socket: fd=%d %s", + fd, SocketAddressType_str(sa_type)); } return s; @@ -444,7 +445,7 @@ static NetSocketState *net_socket_fd_init_stream(NetClientState *peer, nc = qemu_new_net_client(&net_socket_info, peer, model, name); - snprintf(nc->info_str, sizeof(nc->info_str), "socket: fd=%d", fd); + nc->info_str = g_strdup_printf("socket: fd=%d", fd); s = DO_UPCAST(NetSocketState, nc, nc); @@ -528,9 +529,10 @@ static void net_socket_accept(void *opaque) stored->has_fd = true; stored->fd = g_strdup_printf("%d", fd); - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "socket: connection from %s:%d", - inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); + g_free(s->nc.info_str); + s->nc.info_str = g_strdup_printf("socket: connection from %s:%d", + inet_ntoa(saddr.sin_addr), + ntohs(saddr.sin_port)); } static int net_socket_listen_init(NetClientState *peer, @@ -645,9 +647,10 @@ static int net_socket_connect_init(NetClientState *peer, stored->has_connect = true; stored->connect = g_strdup(host_str); - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "socket: connect to %s:%d", - inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); + g_free(s->nc.info_str); + s->nc.info_str = g_strdup_printf("socket: connect to %s:%d", + inet_ntoa(saddr.sin_addr), + ntohs(saddr.sin_port)); return 0; } @@ -704,9 +707,10 @@ static int net_socket_mcast_init(NetClientState *peer, stored->localaddr = g_strdup(localaddr_str); } - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "socket: mcast=%s:%d", - inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); + g_free(s->nc.info_str); + s->nc.info_str = g_strdup_printf("socket: mcast=%s:%d", + inet_ntoa(saddr.sin_addr), + ntohs(saddr.sin_port)); return 0; } @@ -769,9 +773,10 @@ static int net_socket_udp_init(NetClientState *peer, stored->has_udp = true; stored->udp = g_strdup(rhost); - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "socket: udp=%s:%d", - inet_ntoa(raddr.sin_addr), ntohs(raddr.sin_port)); + g_free(s->nc.info_str); + s->nc.info_str = g_strdup_printf("socket: udp=%s:%d", + inet_ntoa(raddr.sin_addr), + ntohs(raddr.sin_port)); return 0; } diff --git a/net/tap-win32.c b/net/tap-win32.c index b60933bd1a..0888db8cce 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -787,8 +787,7 @@ static int tap_win32_init(NetClientState *peer, const char *model, stored->has_ifname = true; stored->ifname = g_strdup(ifname); - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "tap: ifname=%s", ifname); + s->nc.info_str = g_strdup_printf("tap: ifname=%s", ifname); s->handle = handle; diff --git a/net/tap.c b/net/tap.c index 8041245ba7..f864f434b2 100644 --- a/net/tap.c +++ b/net/tap.c @@ -625,8 +625,7 @@ int net_init_bridge(const Netdev *netdev, const char *name, stored->helper = g_strdup(helper); } - snprintf(s->nc.info_str, sizeof(s->nc.info_str), "helper=%s,br=%s", helper, - br); + s->nc.info_str = g_strdup_printf("helper=%s,br=%s", helper, br); return 0; } @@ -714,7 +713,7 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, g_free(tmp_s); } - snprintf(s->nc.info_str, sizeof(s->nc.info_str), "fd=%d", fd); + s->nc.info_str = g_strdup_printf("fd=%d", fd); } else if (tap->has_helper) { if (!stored->has_helper) { stored->has_helper = true; @@ -727,8 +726,7 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, g_strdup(DEFAULT_BRIDGE_INTERFACE); } - snprintf(s->nc.info_str, sizeof(s->nc.info_str), "helper=%s", - tap->helper); + s->nc.info_str = g_strdup_printf("helper=%s", tap->helper); } else { if (ifname && !stored->has_ifname) { stored->has_ifname = true; @@ -745,9 +743,8 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, stored->downscript = g_strdup(downscript); } - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "ifname=%s,script=%s,downscript=%s", ifname, script, - downscript); + s->nc.info_str = g_strdup_printf("ifname=%s,script=%s,downscript=%s", + ifname, script, downscript); if (strcmp(downscript, "no") != 0) { snprintf(s->down_script, sizeof(s->down_script), "%s", downscript); diff --git a/net/vde.c b/net/vde.c index b0b8800571..67de6eb0c5 100644 --- a/net/vde.c +++ b/net/vde.c @@ -100,8 +100,7 @@ static int net_vde_init(NetClientState *peer, const char *model, nc = qemu_new_net_client(&net_vde_info, peer, model, name); - snprintf(nc->info_str, sizeof(nc->info_str), "sock=%s,fd=%d", - sock, vde_datafd(vde)); + nc->info_str = g_strdup_printf("sock=%s,fd=%d", sock, vde_datafd(vde)); s = DO_UPCAST(VDEState, nc, nc); diff --git a/net/vhost-user.c b/net/vhost-user.c index 5b7056be25..49c9a740c2 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -327,8 +327,7 @@ static int net_vhost_user_init(NetClientState *peer, const char *device, user = g_new0(struct VhostUserState, 1); for (i = 0; i < queues; i++) { nc = qemu_new_net_client(&net_vhost_user_info, peer, device, name); - snprintf(nc->info_str, sizeof(nc->info_str), "vhost-user%d to %s", - i, chr->label); + nc->info_str = g_strdup_printf("vhost-user%d to %s", i, chr->label); nc->queue_index = i; if (!nc0) { nc0 = nc; diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 8c27ea0142..423d71770d 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -200,7 +200,7 @@ static int net_vhost_vdpa_init(NetClientState *peer, const char *device, stored->has_queues = true; stored->queues = 1; /* TODO: change when support multiqueue */ - snprintf(nc->info_str, sizeof(nc->info_str), TYPE_VHOST_VDPA); + nc->info_str = g_strdup_printf(TYPE_VHOST_VDPA); nc->queue_index = 0; s = DO_UPCAST(VhostVDPAState, nc, nc); vdpa_device_fd = qemu_open_old(vhostdev, O_RDWR); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 02 18:02:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 18:02:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92537.174464 (Exim 4.92) (envelope-from ) id 1lH9Ly-00016q-C5; Tue, 02 Mar 2021 18:02:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92537.174464; Tue, 02 Mar 2021 18:02:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH9Ly-00016j-8R; Tue, 02 Mar 2021 18:02:38 +0000 Received: by outflank-mailman (input) for mailman id 92537; Tue, 02 Mar 2021 18:02:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH9Lx-00016V-7q for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 18:02:37 +0000 Received: from forwardcorp1o.mail.yandex.net (unknown [2a02:6b8:0:1a2d::193]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9df8bc22-b4ef-47f5-ad28-c2bd68f87c26; Tue, 02 Mar 2021 18:02:33 +0000 (UTC) Received: from myt5-23f0be3aa648.qloud-c.yandex.net (myt5-23f0be3aa648.qloud-c.yandex.net [IPv6:2a02:6b8:c12:3e29:0:640:23f0:be3a]) by forwardcorp1o.mail.yandex.net (Yandex) with ESMTP id 13E5F2E15AF; Tue, 2 Mar 2021 21:02:32 +0300 (MSK) Received: from myt5-70c90f7d6d7d.qloud-c.yandex.net (myt5-70c90f7d6d7d.qloud-c.yandex.net [2a02:6b8:c12:3e2c:0:640:70c9:f7d]) by myt5-23f0be3aa648.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id fwSg3OsIo6-2SxaVl5v; Tue, 02 Mar 2021 21:02:31 +0300 Received: from dynamic-vpn.dhcp.yndx.net (dynamic-vpn.dhcp.yndx.net [2a02:6b8:b080:8002::1:1a]) by myt5-70c90f7d6d7d.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id onVeXhLyoo-2Ro0N7Ep; Tue, 02 Mar 2021 21:02:28 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 9df8bc22-b4ef-47f5-ad28-c2bd68f87c26 Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1614708151; bh=p3ojbQAEQAnD2NlGsm2y47eTVpEWHCrPa7vSf+hvjCo=; h=In-Reply-To:Message-Id:References:Date:Subject:To:From:Cc; b=Nen1Mxa0Gi3vj4AIwOo8xPV0LE6KCTlCpsA4PMsp2eyHEHI3AqFwl/PaLmps4s0b3 daIiH1Y5wkewai9muUuKcpJJxsZdiI3l6zBMLDP38we7zeqzTzUKxZjzf4aehmf3Cx CoPWX81q3AZGNxboYkBfombPjXDT9OfXvi0KHo0U= Authentication-Results: myt5-23f0be3aa648.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Alexey Kirillov To: Jason Wang , Markus Armbruster , Thomas Huth , Eric Blake Cc: Laurent Vivier , Samuel Thibault , "Michael S. Tsirkin" , Michael Roth , Paolo Bonzini , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Stefan Weil , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, yc-core@yandex-team.ru Subject: [PATCH v6 1/5] qapi: net: Add query-netdev command Date: Tue, 2 Mar 2021 21:02:01 +0300 Message-Id: <20210302180205.5009-2-lekiravi@yandex-team.ru> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210302180205.5009-1-lekiravi@yandex-team.ru> References: <20210302180205.5009-1-lekiravi@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The query-netdev command is used to get the configuration of the current network device backends (netdevs). This is the QMP analog of the HMP command "info network" but only for netdevs (i.e. excluding NIC and hubports). The query-netdev command returns an array of objects of the NetdevInfo type, which are an extension of Netdev type. It means that response can be used for netdev-add after small modification. This can be useful for recreate the same netdev configuration. Information about the network device is filled in when it is created or modified and is available through the NetClientState->stored_config. Signed-off-by: Alexey Kirillov Acked-by: Markus Armbruster --- include/net/net.h | 3 ++ net/l2tpv3.c | 7 +++ net/net.c | 32 +++++++++++- net/netmap.c | 7 +++ net/slirp.c | 124 ++++++++++++++++++++++++++++++++++++++++++++++ net/socket.c | 71 ++++++++++++++++++++++++++ net/tap-win32.c | 9 ++++ net/tap.c | 103 ++++++++++++++++++++++++++++++++++++-- net/vde.c | 22 ++++++++ net/vhost-user.c | 18 +++++-- net/vhost-vdpa.c | 14 ++++++ qapi/net.json | 80 ++++++++++++++++++++++++++++++ 12 files changed, 481 insertions(+), 9 deletions(-) diff --git a/include/net/net.h b/include/net/net.h index 919facaad2..162fd3f1b5 100644 --- a/include/net/net.h +++ b/include/net/net.h @@ -5,6 +5,8 @@ #include "qapi/qapi-types-net.h" #include "net/queue.h" #include "hw/qdev-properties-system.h" +#include "qapi/clone-visitor.h" +#include "qapi/qapi-visit-net.h" #define MAC_FMT "%02X:%02X:%02X:%02X:%02X:%02X" #define MAC_ARG(x) ((uint8_t *)(x))[0], ((uint8_t *)(x))[1], \ @@ -93,6 +95,7 @@ struct NetClientState { char *model; char *name; char info_str[256]; + NetdevInfo *stored_config; unsigned receive_disabled : 1; NetClientDestructor *destructor; unsigned int queue_index; diff --git a/net/l2tpv3.c b/net/l2tpv3.c index e4d4218db6..8aa0a3e1a0 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -723,6 +723,13 @@ int net_init_l2tpv3(const Netdev *netdev, l2tpv3_read_poll(s, true); + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_L2TPV3; + + QAPI_CLONE_MEMBERS(NetdevL2TPv3Options, + &nc->stored_config->u.l2tpv3, l2tpv3); + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "l2tpv3: connected"); return 0; diff --git a/net/net.c b/net/net.c index fb7b7dcc25..9b213f72d2 100644 --- a/net/net.c +++ b/net/net.c @@ -35,7 +35,6 @@ #include "monitor/monitor.h" #include "qemu/help_option.h" #include "qapi/qapi-commands-net.h" -#include "qapi/qapi-visit-net.h" #include "qapi/qmp/qdict.h" #include "qapi/qmp/qerror.h" #include "qemu/error-report.h" @@ -352,6 +351,7 @@ static void qemu_free_net_client(NetClientState *nc) } g_free(nc->name); g_free(nc->model); + qapi_free_NetdevInfo(nc->stored_config); if (nc->destructor) { nc->destructor(nc); } @@ -1260,6 +1260,36 @@ RxFilterInfoList *qmp_query_rx_filter(bool has_name, const char *name, return filter_list; } +NetdevInfoList *qmp_query_netdev(Error **errp) +{ + NetdevInfoList *list = NULL; + NetClientState *nc; + + QTAILQ_FOREACH(nc, &net_clients, next) { + /* + * Only look at netdevs (backend network devices), not for each queue + * or NIC / hubport + */ + if (nc->stored_config) { + NetdevInfoList *node = g_new0(NetdevInfoList, 1); + + node->value = QAPI_CLONE(NetdevInfo, nc->stored_config); + g_free(node->value->id); /* Need to dealloc default empty id */ + node->value->id = g_strdup(nc->name); + + node->value->has_peer_id = nc->peer != NULL; + if (node->value->has_peer_id) { + node->value->peer_id = g_strdup(nc->peer->name); + } + + node->next = list; + list = node; + } + } + + return list; +} + void hmp_info_network(Monitor *mon, const QDict *qdict) { NetClientState *nc, *peer; diff --git a/net/netmap.c b/net/netmap.c index 350f097f91..ad59d4ade4 100644 --- a/net/netmap.c +++ b/net/netmap.c @@ -427,6 +427,13 @@ int net_init_netmap(const Netdev *netdev, pstrcpy(s->ifname, sizeof(s->ifname), netmap_opts->ifname); netmap_read_poll(s, true); /* Initially only poll for reads. */ + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_NETMAP; + + QAPI_CLONE_MEMBERS(NetdevNetmapOptions, + &nc->stored_config->u.netmap, netmap_opts); + return 0; } diff --git a/net/slirp.c b/net/slirp.c index be914c0be0..5f126d7cf5 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -345,6 +345,14 @@ static SaveVMHandlers savevm_slirp_state = { .load_state = net_slirp_state_load, }; +#define APPEND_STRINGLIST(tail, new_val) \ + do { \ + *(tail) = g_new0(StringList, 1); \ + (*(tail))->value = g_new0(String, 1); \ + (*(tail))->value->str = g_strdup((new_val)); \ + (tail) = &((*(tail))->next); \ + } while (0) + static int net_slirp_init(NetClientState *peer, const char *model, const char *name, int restricted, bool ipv4, const char *vnetwork, const char *vhost, @@ -377,6 +385,9 @@ static int net_slirp_init(NetClientState *peer, const char *model, int shift; char *end; struct slirp_config_str *config; + NetdevUserOptions *stored; + StringList **stored_hostfwd; + StringList **stored_guestfwd; if (!ipv4 && (vnetwork || vhost || vnameserver)) { error_setg(errp, "IPv4 disabled but netmask/host/dns provided"); @@ -552,6 +563,112 @@ static int net_slirp_init(NetClientState *peer, const char *model, nc = qemu_new_net_client(&net_slirp_info, peer, model, name); + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_USER; + stored = &nc->stored_config->u.user; + + if (vhostname) { + stored->has_hostname = true; + stored->hostname = g_strdup(vhostname); + } + + stored->has_q_restrict = true; + stored->q_restrict = restricted; + + stored->has_ipv4 = true; + stored->ipv4 = ipv4; + + stored->has_ipv6 = true; + stored->ipv6 = ipv6; + + if (ipv4) { + uint8_t *net_bytes = (uint8_t *)&net; + uint8_t *mask_bytes = (uint8_t *)&mask; + + stored->has_net = true; + stored->net = g_strdup_printf("%d.%d.%d.%d/%d.%d.%d.%d", + net_bytes[0], net_bytes[1], + net_bytes[2], net_bytes[3], + mask_bytes[0], mask_bytes[1], + mask_bytes[2], mask_bytes[3]); + + stored->has_host = true; + stored->host = g_strdup(inet_ntoa(host)); + } + + if (tftp_export) { + stored->has_tftp = true; + stored->tftp = g_strdup(tftp_export); + } + + if (bootfile) { + stored->has_bootfile = true; + stored->bootfile = g_strdup(bootfile); + } + + if (vdhcp_start) { + stored->has_dhcpstart = true; + stored->dhcpstart = g_strdup(vdhcp_start); + } + + if (ipv4) { + stored->has_dns = true; + stored->dns = g_strdup(inet_ntoa(dns)); + } + + if (dnssearch) { + stored->has_dnssearch = true; + StringList **stored_list = &stored->dnssearch; + + for (int i = 0; dnssearch[i]; i++) { + APPEND_STRINGLIST(stored_list, dnssearch[i]); + } + } + + if (vdomainname) { + stored->has_domainname = true; + stored->domainname = g_strdup(vdomainname); + } + + if (ipv6) { + char addrstr[INET6_ADDRSTRLEN]; + const char *res; + + stored->has_ipv6_prefix = true; + stored->ipv6_prefix = g_strdup(vprefix6); + + stored->has_ipv6_prefixlen = true; + stored->ipv6_prefixlen = vprefix6_len; + + res = inet_ntop(AF_INET6, &ip6_host, + addrstr, sizeof(addrstr)); + + stored->has_ipv6_host = true; + stored->ipv6_host = g_strdup(res); + + res = inet_ntop(AF_INET6, &ip6_dns, + addrstr, sizeof(addrstr)); + + stored->has_ipv6_dns = true; + stored->ipv6_dns = g_strdup(res); + } + + if (smb_export) { + stored->has_smb = true; + stored->smb = g_strdup(smb_export); + } + + if (vsmbserver) { + stored->has_smbserver = true; + stored->smbserver = g_strdup(vsmbserver); + } + + if (tftp_server_name) { + stored->has_tftp_server_name = true; + stored->tftp_server_name = g_strdup(tftp_server_name); + } + snprintf(nc->info_str, sizeof(nc->info_str), "net=%s,restrict=%s", inet_ntoa(net), restricted ? "on" : "off"); @@ -581,15 +698,22 @@ static int net_slirp_init(NetClientState *peer, const char *model, s->poll_notifier.notify = net_slirp_poll_notify; main_loop_poll_add_notifier(&s->poll_notifier); + stored_hostfwd = &stored->hostfwd; + stored_guestfwd = &stored->guestfwd; + for (config = slirp_configs; config; config = config->next) { if (config->flags & SLIRP_CFG_HOSTFWD) { if (slirp_hostfwd(s, config->str, errp) < 0) { goto error; } + stored->has_hostfwd = true; + APPEND_STRINGLIST(stored_hostfwd, config->str); } else { if (slirp_guestfwd(s, config->str, errp) < 0) { goto error; } + stored->has_guestfwd = true; + APPEND_STRINGLIST(stored_guestfwd, config->str); } } #ifndef _WIN32 diff --git a/net/socket.c b/net/socket.c index 15b410e8d8..1614523b82 100644 --- a/net/socket.c +++ b/net/socket.c @@ -342,6 +342,7 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer, NetSocketState *s; SocketAddress *sa; SocketAddressType sa_type; + NetdevSocketOptions *stored; sa = socket_local_address(fd, errp); if (!sa) { @@ -385,8 +386,19 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer, net_socket_rs_init(&s->rs, net_socket_rs_finalize, false); net_socket_read_poll(s, true); + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_SOCKET; + stored = &nc->stored_config->u.socket; + + stored->has_fd = true; + stored->fd = g_strdup_printf("%d", fd); + /* mcast: save bound address as dst */ if (is_connected && mcast != NULL) { + stored->has_mcast = true; + stored->mcast = g_strdup(mcast); + s->dgram_dst = saddr; snprintf(nc->info_str, sizeof(nc->info_str), "socket: fd=%d (cloned mcast=%s:%d)", @@ -428,6 +440,7 @@ static NetSocketState *net_socket_fd_init_stream(NetClientState *peer, { NetClientState *nc; NetSocketState *s; + NetdevSocketOptions *stored; nc = qemu_new_net_client(&net_socket_info, peer, model, name); @@ -447,6 +460,15 @@ static NetSocketState *net_socket_fd_init_stream(NetClientState *peer, } else { qemu_set_fd_handler(s->fd, NULL, net_socket_connect, s); } + + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_SOCKET; + stored = &nc->stored_config->u.socket; + + stored->has_fd = true; + stored->fd = g_strdup_printf("%d", fd); + return s; } @@ -483,6 +505,7 @@ static void net_socket_accept(void *opaque) struct sockaddr_in saddr; socklen_t len; int fd; + NetdevSocketOptions *stored; for(;;) { len = sizeof(saddr); @@ -498,6 +521,13 @@ static void net_socket_accept(void *opaque) s->fd = fd; s->nc.link_down = false; net_socket_connect(s); + + /* Store additional startup parameters (extend net_socket_listen_init) */ + stored = &s->nc.stored_config->u.socket; + + stored->has_fd = true; + stored->fd = g_strdup_printf("%d", fd); + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "socket: connection from %s:%d", inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); @@ -513,6 +543,7 @@ static int net_socket_listen_init(NetClientState *peer, NetSocketState *s; struct sockaddr_in saddr; int fd, ret; + NetdevSocketOptions *stored; if (parse_host_port(&saddr, host_str, errp) < 0) { return -1; @@ -549,6 +580,15 @@ static int net_socket_listen_init(NetClientState *peer, net_socket_rs_init(&s->rs, net_socket_rs_finalize, false); qemu_set_fd_handler(s->listen_fd, net_socket_accept, NULL, s); + + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_SOCKET; + stored = &nc->stored_config->u.socket; + + stored->has_listen = true; + stored->listen = g_strdup(host_str); + return 0; } @@ -561,6 +601,7 @@ static int net_socket_connect_init(NetClientState *peer, NetSocketState *s; int fd, connected, ret; struct sockaddr_in saddr; + NetdevSocketOptions *stored; if (parse_host_port(&saddr, host_str, errp) < 0) { return -1; @@ -598,6 +639,12 @@ static int net_socket_connect_init(NetClientState *peer, return -1; } + /* Store additional startup parameters (extend net_socket_fd_init) */ + stored = &s->nc.stored_config->u.socket; + + stored->has_connect = true; + stored->connect = g_strdup(host_str); + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "socket: connect to %s:%d", inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); @@ -615,6 +662,7 @@ static int net_socket_mcast_init(NetClientState *peer, int fd; struct sockaddr_in saddr; struct in_addr localaddr, *param_localaddr; + NetdevSocketOptions *stored; if (parse_host_port(&saddr, host_str, errp) < 0) { return -1; @@ -643,6 +691,19 @@ static int net_socket_mcast_init(NetClientState *peer, s->dgram_dst = saddr; + /* Store additional startup parameters (extend net_socket_fd_init) */ + stored = &s->nc.stored_config->u.socket; + + if (!stored->has_mcast) { + stored->has_mcast = true; + stored->mcast = g_strdup(host_str); + } + + if (localaddr_str) { + stored->has_localaddr = true; + stored->localaddr = g_strdup(localaddr_str); + } + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "socket: mcast=%s:%d", inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); @@ -660,6 +721,7 @@ static int net_socket_udp_init(NetClientState *peer, NetSocketState *s; int fd, ret; struct sockaddr_in laddr, raddr; + NetdevSocketOptions *stored; if (parse_host_port(&laddr, lhost, errp) < 0) { return -1; @@ -698,6 +760,15 @@ static int net_socket_udp_init(NetClientState *peer, s->dgram_dst = raddr; + /* Store additional startup parameters (extend net_socket_fd_init) */ + stored = &s->nc.stored_config->u.socket; + + stored->has_localaddr = true; + stored->localaddr = g_strdup(lhost); + + stored->has_udp = true; + stored->udp = g_strdup(rhost); + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "socket: udp=%s:%d", inet_ntoa(raddr.sin_addr), ntohs(raddr.sin_port)); diff --git a/net/tap-win32.c b/net/tap-win32.c index 2b5dcda36e..b60933bd1a 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -768,6 +768,7 @@ static int tap_win32_init(NetClientState *peer, const char *model, NetClientState *nc; TAPState *s; tap_win32_overlapped_t *handle; + NetdevTapOptions *stored; if (tap_win32_open(&handle, ifname) < 0) { printf("tap: Could not open '%s'\n", ifname); @@ -778,6 +779,14 @@ static int tap_win32_init(NetClientState *peer, const char *model, s = DO_UPCAST(TAPState, nc, nc); + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_TAP; + stored = &nc->stored_config->u.tap; + + stored->has_ifname = true; + stored->ifname = g_strdup(ifname); + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "tap: ifname=%s", ifname); diff --git a/net/tap.c b/net/tap.c index b7512853f4..8041245ba7 100644 --- a/net/tap.c +++ b/net/tap.c @@ -590,6 +590,7 @@ int net_init_bridge(const Netdev *netdev, const char *name, const char *helper, *br; TAPState *s; int fd, vnet_hdr; + NetdevBridgeOptions *stored; assert(netdev->type == NET_CLIENT_DRIVER_BRIDGE); bridge = &netdev->u.bridge; @@ -609,6 +610,21 @@ int net_init_bridge(const Netdev *netdev, const char *name, } s = net_tap_fd_init(peer, "bridge", name, fd, vnet_hdr); + /* Store startup parameters */ + s->nc.stored_config = g_new0(NetdevInfo, 1); + s->nc.stored_config->type = NET_BACKEND_BRIDGE; + stored = &s->nc.stored_config->u.bridge; + + if (br) { + stored->has_br = true; + stored->br = g_strdup(br); + } + + if (helper) { + stored->has_helper = true; + stored->helper = g_strdup(helper); + } + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "helper=%s,br=%s", helper, br); @@ -656,11 +672,13 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, const char *model, const char *name, const char *ifname, const char *script, const char *downscript, const char *vhostfdname, - int vnet_hdr, int fd, Error **errp) + int vnet_hdr, int fd, NetdevInfo **common_stored, + Error **errp) { Error *err = NULL; TAPState *s = net_tap_fd_init(peer, model, name, fd, vnet_hdr); int vhostfd; + NetdevTapOptions *stored; tap_set_sndbuf(s->fd, tap, &err); if (err) { @@ -668,12 +686,65 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, return; } + /* Store startup parameters */ + if (!*common_stored) { + *common_stored = g_new0(NetdevInfo, 1); + (*common_stored)->type = NET_BACKEND_TAP; + s->nc.stored_config = *common_stored; + } + stored = &(*common_stored)->u.tap; + + if (tap->has_sndbuf && !stored->has_sndbuf) { + stored->has_sndbuf = true; + stored->sndbuf = tap->sndbuf; + } + + if (vnet_hdr && !stored->has_vnet_hdr) { + stored->has_vnet_hdr = true; + stored->vnet_hdr = true; + } + if (tap->has_fd || tap->has_fds) { + if (!stored->has_fds) { + stored->has_fds = true; + stored->fds = g_strdup_printf("%d", fd); + } else { + char *tmp_s = stored->fds; + stored->fds = g_strdup_printf("%s:%d", stored->fds, fd); + g_free(tmp_s); + } + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "fd=%d", fd); } else if (tap->has_helper) { + if (!stored->has_helper) { + stored->has_helper = true; + stored->helper = g_strdup(tap->helper); + } + + if (!stored->has_br) { + stored->has_br = true; + stored->br = tap->has_br ? g_strdup(tap->br) : + g_strdup(DEFAULT_BRIDGE_INTERFACE); + } + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "helper=%s", tap->helper); } else { + if (ifname && !stored->has_ifname) { + stored->has_ifname = true; + stored->ifname = g_strdup(ifname); + } + + if (script && !stored->has_script) { + stored->has_script = true; + stored->script = g_strdup(script); + } + + if (downscript && !stored->has_downscript) { + stored->has_downscript = true; + stored->downscript = g_strdup(downscript); + } + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "ifname=%s,script=%s,downscript=%s", ifname, script, downscript); @@ -689,9 +760,20 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, vhostfdname || (tap->has_vhostforce && tap->vhostforce)) { VhostNetOptions options; + stored->has_vhost = true; + stored->vhost = true; + + if (tap->has_vhostforce && tap->vhostforce) { + stored->has_vhostforce = true; + stored->vhostforce = true; + } + options.backend_type = VHOST_BACKEND_TYPE_KERNEL; options.net_backend = &s->nc; if (tap->has_poll_us) { + stored->has_poll_us = true; + stored->poll_us = tap->poll_us; + options.busyloop_timeout = tap->poll_us; } else { options.busyloop_timeout = 0; @@ -731,6 +813,15 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, } options.opaque = (void *)(uintptr_t)vhostfd; + if (!stored->has_vhostfds) { + stored->has_vhostfds = true; + stored->vhostfds = g_strdup_printf("%d", vhostfd); + } else { + char *tmp_s = stored->vhostfds; + stored->vhostfds = g_strdup_printf("%s:%d", stored->fds, vhostfd); + g_free(tmp_s); + } + s->vhost_net = vhost_net_init(&options); if (!s->vhost_net) { if (tap->has_vhostforce && tap->vhostforce) { @@ -783,6 +874,7 @@ int net_init_tap(const Netdev *netdev, const char *name, const char *vhostfdname; char ifname[128]; int ret = 0; + NetdevInfo *common_stored = NULL; /* will store configuration */ assert(netdev->type == NET_CLIENT_DRIVER_TAP); tap = &netdev->u.tap; @@ -829,7 +921,7 @@ int net_init_tap(const Netdev *netdev, const char *name, net_init_tap_one(tap, peer, "tap", name, NULL, script, downscript, - vhostfdname, vnet_hdr, fd, &err); + vhostfdname, vnet_hdr, fd, &common_stored, &err); if (err) { error_propagate(errp, err); close(fd); @@ -892,7 +984,7 @@ int net_init_tap(const Netdev *netdev, const char *name, net_init_tap_one(tap, peer, "tap", name, ifname, script, downscript, tap->has_vhostfds ? vhost_fds[i] : NULL, - vnet_hdr, fd, &err); + vnet_hdr, fd, &common_stored, &err); if (err) { error_propagate(errp, err); ret = -1; @@ -935,7 +1027,7 @@ free_fail: net_init_tap_one(tap, peer, "bridge", name, ifname, script, downscript, vhostfdname, - vnet_hdr, fd, &err); + vnet_hdr, fd, &common_stored, &err); if (err) { error_propagate(errp, err); close(fd); @@ -981,7 +1073,8 @@ free_fail: net_init_tap_one(tap, peer, "tap", name, ifname, i >= 1 ? "no" : script, i >= 1 ? "no" : downscript, - vhostfdname, vnet_hdr, fd, &err); + vhostfdname, vnet_hdr, fd, + &common_stored, &err); if (err) { error_propagate(errp, err); close(fd); diff --git a/net/vde.c b/net/vde.c index 99189cccb6..b0b8800571 100644 --- a/net/vde.c +++ b/net/vde.c @@ -84,6 +84,7 @@ static int net_vde_init(NetClientState *peer, const char *model, VDECONN *vde; char *init_group = (char *)group; char *init_sock = (char *)sock; + NetdevVdeOptions *stored; struct vde_open_args args = { .port = port, @@ -108,6 +109,27 @@ static int net_vde_init(NetClientState *peer, const char *model, qemu_set_fd_handler(vde_datafd(s->vde), vde_to_qemu, NULL, s); + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_VDE; + stored = &nc->stored_config->u.vde; + + if (sock) { + stored->has_sock = true; + stored->sock = g_strdup(sock); + } + + stored->has_port = true; + stored->port = port; + + if (group) { + stored->has_group = true; + stored->group = g_strdup(group); + } + + stored->has_mode = true; + stored->mode = mode; + return 0; } diff --git a/net/vhost-user.c b/net/vhost-user.c index ffbd94d944..5b7056be25 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -311,14 +311,15 @@ static void net_vhost_user_event(void *opaque, QEMUChrEvent event) } static int net_vhost_user_init(NetClientState *peer, const char *device, - const char *name, Chardev *chr, - int queues) + const char *name, const char *chardev, + Chardev *chr, int queues) { Error *err = NULL; NetClientState *nc, *nc0 = NULL; NetVhostUserState *s = NULL; VhostUserState *user; int i; + NetdevVhostUserOptions *stored; assert(name); assert(queues > 0); @@ -355,6 +356,16 @@ static int net_vhost_user_init(NetClientState *peer, const char *device, assert(s->vhost_net); + /* Store startup parameters */ + nc0->stored_config = g_new0(NetdevInfo, 1); + nc0->stored_config->type = NET_BACKEND_VHOST_USER; + stored = &nc0->stored_config->u.vhost_user; + + stored->chardev = g_strdup(chardev); + + stored->has_queues = true; + stored->queues = queues; + return 0; err: @@ -446,5 +457,6 @@ int net_init_vhost_user(const Netdev *netdev, const char *name, return -1; } - return net_vhost_user_init(peer, "vhost_user", name, chr, queues); + return net_vhost_user_init(peer, "vhost_user", name, + vhost_user_opts->chardev, chr, queues); } diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index fe659ec9e2..8c27ea0142 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -184,8 +184,22 @@ static int net_vhost_vdpa_init(NetClientState *peer, const char *device, VhostVDPAState *s; int vdpa_device_fd = -1; int ret = 0; + NetdevVhostVDPAOptions *stored; + assert(name); nc = qemu_new_net_client(&net_vhost_vdpa_info, peer, device, name); + + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_VHOST_VDPA; + stored = &nc->stored_config->u.vhost_vdpa; + + stored->has_vhostdev = true; + stored->vhostdev = g_strdup(vhostdev); + + stored->has_queues = true; + stored->queues = 1; /* TODO: change when support multiqueue */ + snprintf(nc->info_str, sizeof(nc->info_str), TYPE_VHOST_VDPA); nc->queue_index = 0; s = DO_UPCAST(VhostVDPAState, nc, nc); diff --git a/qapi/net.json b/qapi/net.json index c31748c87f..94130abdd1 100644 --- a/qapi/net.json +++ b/qapi/net.json @@ -714,3 +714,83 @@ ## { 'event': 'FAILOVER_NEGOTIATED', 'data': {'device-id': 'str'} } + +## +# @NetBackend: +# +# Available netdev backend drivers. +# +# Since: 6.0 +## +{ 'enum': 'NetBackend', + 'data': [ 'user', 'tap', 'l2tpv3', 'socket', 'vde', 'bridge', 'netmap', + 'vhost-user', 'vhost-vdpa' ] } + +## +# @NetdevInfo: +# +# Configuration of a network backend device (netdev). +# +# @id: Device identifier. +# +# @type: Specify the driver used for interpreting remaining arguments. +# +# @peer-id: The connected frontend network device name (absent if no frontend +# is connected). +# +# Since: 6.0 +## +{ 'union': 'NetdevInfo', + 'base': { 'id': 'str', + 'type': 'NetBackend', + '*peer-id': 'str' }, + 'discriminator': 'type', + 'data': { + 'user': 'NetdevUserOptions', + 'tap': 'NetdevTapOptions', + 'l2tpv3': 'NetdevL2TPv3Options', + 'socket': 'NetdevSocketOptions', + 'vde': 'NetdevVdeOptions', + 'bridge': 'NetdevBridgeOptions', + 'netmap': 'NetdevNetmapOptions', + 'vhost-user': 'NetdevVhostUserOptions', + 'vhost-vdpa': 'NetdevVhostVDPAOptions' } } + +## +# @query-netdev: +# +# Get a list of @NetdevInfo for all virtual network backend devices (netdevs). +# +# Returns: a list of @NetdevInfo describing each netdev. +# +# Since: 6.0 +# +# Example: +# +# -> { "execute": "query-netdev" } +# <- { "return": [ +# { +# "ipv6": true, +# "ipv4": true, +# "host": "10.0.2.2", +# "ipv6-dns": "fec0::3", +# "ipv6-prefix": "fec0::", +# "net": "10.0.2.0/255.255.255.0", +# "ipv6-host": "fec0::2", +# "type": "user", +# "peer-id": "net0", +# "dns": "10.0.2.3", +# "hostfwd": [ +# { +# "str": "tcp::20004-:22" +# } +# ], +# "ipv6-prefixlen": 64, +# "id": "netdev0", +# "restrict": false +# } +# ] +# } +# +## +{ 'command': 'query-netdev', 'returns': ['NetdevInfo'] } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 02 18:02:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 18:02:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92540.174500 (Exim 4.92) (envelope-from ) id 1lH9MG-0001He-CE; Tue, 02 Mar 2021 18:02:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92540.174500; Tue, 02 Mar 2021 18:02:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH9MG-0001HU-8a; Tue, 02 Mar 2021 18:02:56 +0000 Received: by outflank-mailman (input) for mailman id 92540; Tue, 02 Mar 2021 18:02:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH9ME-0001A7-Ts for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 18:02:54 +0000 Received: from forwardcorp1j.mail.yandex.net (unknown [5.45.199.163]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d8c24938-d4af-468a-956c-64fdb25aed80; Tue, 02 Mar 2021 18:02:52 +0000 (UTC) Received: from myt5-23f0be3aa648.qloud-c.yandex.net (myt5-23f0be3aa648.qloud-c.yandex.net [IPv6:2a02:6b8:c12:3e29:0:640:23f0:be3a]) by forwardcorp1j.mail.yandex.net (Yandex) with ESMTP id D2EC22E147C; Tue, 2 Mar 2021 21:02:50 +0300 (MSK) Received: from myt5-70c90f7d6d7d.qloud-c.yandex.net (myt5-70c90f7d6d7d.qloud-c.yandex.net [2a02:6b8:c12:3e2c:0:640:70c9:f7d]) by myt5-23f0be3aa648.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id TDVQdUt8yK-2nxSlevm; Tue, 02 Mar 2021 21:02:50 +0300 Received: from dynamic-vpn.dhcp.yndx.net (dynamic-vpn.dhcp.yndx.net [2a02:6b8:b080:8002::1:1a]) by myt5-70c90f7d6d7d.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id onVeXhLyoo-2mo0IAZV; Tue, 02 Mar 2021 21:02:49 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: d8c24938-d4af-468a-956c-64fdb25aed80 Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1614708170; bh=zwxRihApiUbG7mGl+navjv9Er7L50EpwkWcV1QK+m9Q=; h=In-Reply-To:Message-Id:References:Date:Subject:To:From:Cc; b=yJWCVTOdWu9BmJReGKKTJT/SAdTSV9fCDWxKx9ZqMUW9OLADANxuNIGnEf1Zl/i6/ nDneQCFqz4pdhkyxzEgLBvrOeRJWTDqy1syBkJRXuupELD+A3h3+yhaND3oUz/EN48 8zd2KJg0by/dz99bVtHW91783zWoHlm1Xy2Kgod4= Authentication-Results: myt5-23f0be3aa648.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Alexey Kirillov To: Jason Wang , Markus Armbruster , Thomas Huth , Eric Blake Cc: Laurent Vivier , Samuel Thibault , "Michael S. Tsirkin" , Michael Roth , Paolo Bonzini , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Stefan Weil , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, yc-core@yandex-team.ru Subject: [PATCH v6 4/5] hmp: Use QAPI NetdevInfo in hmp_info_network Date: Tue, 2 Mar 2021 21:02:04 +0300 Message-Id: <20210302180205.5009-5-lekiravi@yandex-team.ru> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210302180205.5009-1-lekiravi@yandex-team.ru> References: <20210302180205.5009-1-lekiravi@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace usage of legacy field info_str of NetClientState for backend network devices with QAPI NetdevInfo stored_config that already used in QMP query-netdev. This change increases the detail of the "info network" output and takes a more general approach to composing the output. NIC and hubports still use legacy info_str field. Signed-off-by: Alexey Kirillov --- include/qapi/hmp-output-visitor.h | 30 +++++ net/net.c | 31 ++++- qapi/hmp-output-visitor.c | 193 ++++++++++++++++++++++++++++++ qapi/meson.build | 1 + 4 files changed, 254 insertions(+), 1 deletion(-) create mode 100644 include/qapi/hmp-output-visitor.h create mode 100644 qapi/hmp-output-visitor.c diff --git a/include/qapi/hmp-output-visitor.h b/include/qapi/hmp-output-visitor.h new file mode 100644 index 0000000000..541e4002e3 --- /dev/null +++ b/include/qapi/hmp-output-visitor.h @@ -0,0 +1,30 @@ +/* + * HMP string output Visitor + * + * Copyright Yandex N.V., 2021 + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + * + */ + +#ifndef HMP_OUTPUT_VISITOR_H +#define HMP_OUTPUT_VISITOR_H + +#include "qapi/visitor.h" + +typedef struct HMPOutputVisitor HMPOutputVisitor; + +/** + * Create a HMP string output visitor for @obj + * + * Flattens dicts/structures, only shows arrays borders. + * + * Errors are not expected to happen. + * + * The caller is responsible for freeing the visitor with + * visit_free(). + */ +Visitor *hmp_output_visitor_new(char **result); + +#endif diff --git a/net/net.c b/net/net.c index cc83918d80..65b92bbdab 100644 --- a/net/net.c +++ b/net/net.c @@ -54,6 +54,7 @@ #include "sysemu/sysemu.h" #include "net/filter.h" #include "qapi/string-output-visitor.h" +#include "qapi/hmp-output-visitor.h" /* Net bridge is currently not supported for W32. */ #if !defined(_WIN32) @@ -1192,14 +1193,42 @@ static void netfilter_print_info(Monitor *mon, NetFilterState *nf) monitor_printf(mon, "\n"); } +static char *generate_info_str(NetClientState *nc) +{ + NetdevInfo *ni = nc->stored_config; + char *ret_out = NULL; + Visitor *v; + + /* Use legacy field info_str for NIC and hubports */ + if ((nc->info->type == NET_CLIENT_DRIVER_NIC) || + (nc->info->type == NET_CLIENT_DRIVER_HUBPORT)) { + return g_strdup(nc->info_str ? nc->info_str : ""); + } + + if (!ni) { + return g_malloc0(1); + } + + v = hmp_output_visitor_new(&ret_out); + if (visit_type_NetdevInfo(v, "", &ni, NULL)) { + visit_complete(v, &ret_out); + } + visit_free(v); + + return ret_out; +} + void print_net_client(Monitor *mon, NetClientState *nc) { NetFilterState *nf; + char *info_str = generate_info_str(nc); monitor_printf(mon, "%s: index=%d,type=%s,%s\n", nc->name, nc->queue_index, NetClientDriver_str(nc->info->type), - nc->info_str ? nc->info_str : ""); + info_str); + g_free(info_str); + if (!QTAILQ_EMPTY(&nc->filters)) { monitor_printf(mon, "filters:\n"); } diff --git a/qapi/hmp-output-visitor.c b/qapi/hmp-output-visitor.c new file mode 100644 index 0000000000..8036605f97 --- /dev/null +++ b/qapi/hmp-output-visitor.c @@ -0,0 +1,193 @@ +/* + * HMP string output Visitor + * + * Copyright Yandex N.V., 2021 + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + * + */ + +#include "qemu/osdep.h" +#include "qemu/cutils.h" +#include "qapi/hmp-output-visitor.h" +#include "qapi/visitor-impl.h" + +struct HMPOutputVisitor { + Visitor visitor; + char **result; + GString *buffer; + bool is_continue; +}; + +static HMPOutputVisitor *to_hov(Visitor *v) +{ + return container_of(v, HMPOutputVisitor, visitor); +} + +static void hmp_output_append_formatted(Visitor *v, const char *fmt, ...) +{ + HMPOutputVisitor *ov = to_hov(v); + va_list args; + + if (ov->is_continue) { + g_string_append(ov->buffer, ","); + } else { + ov->is_continue = true; + } + + va_start(args, fmt); + g_string_append_vprintf(ov->buffer, fmt, args); + va_end(args); +} + +static void hmp_output_skip_comma(Visitor *v) +{ + HMPOutputVisitor *ov = to_hov(v); + + ov->is_continue = false; +} + +static bool hmp_output_start_struct(Visitor *v, const char *name, + void **obj, size_t unused, Error **errp) +{ + return true; +} + +static void hmp_output_end_struct(Visitor *v, void **obj) {} + +static bool hmp_output_start_list(Visitor *v, const char *name, + GenericList **listp, size_t size, + Error **errp) +{ + hmp_output_append_formatted(v, "%s=[", name); + /* First element in array without comma before it */ + hmp_output_skip_comma(v); + + return true; +} + +static GenericList *hmp_output_next_list(Visitor *v, GenericList *tail, + size_t size) +{ + return tail->next; +} + +static void hmp_output_end_list(Visitor *v, void **obj) +{ + /* Don't need comma after last array element */ + hmp_output_skip_comma(v); + hmp_output_append_formatted(v, "]"); +} + +static bool hmp_output_type_int64(Visitor *v, const char *name, + int64_t *obj, Error **errp) +{ + hmp_output_append_formatted(v, "%s=%" PRId64, name, *obj); + + return true; +} + +static bool hmp_output_type_uint64(Visitor *v, const char *name, + uint64_t *obj, Error **errp) +{ + hmp_output_append_formatted(v, "%s=%" PRIu64, name, *obj); + + return true; +} + +static bool hmp_output_type_bool(Visitor *v, const char *name, bool *obj, + Error **errp) +{ + hmp_output_append_formatted(v, "%s=%s", name, *obj ? "true" : "false"); + + return true; +} + +static bool hmp_output_type_str(Visitor *v, const char *name, char **obj, + Error **errp) +{ + /* Skip already printed or unused fields */ + if (!*obj || g_str_equal(name, "id") || g_str_equal(name, "type")) { + return true; + } + + /* Do not print stub name for StringList elements */ + if (g_str_equal(name, "str")) { + hmp_output_append_formatted(v, "%s", *obj); + } else { + hmp_output_append_formatted(v, "%s=%s", name, *obj); + } + + return true; +} + +static bool hmp_output_type_number(Visitor *v, const char *name, + double *obj, Error **errp) +{ + hmp_output_append_formatted(v, "%s=%.17g", name, *obj); + + return true; +} + +/* TODO: remove this function? */ +static bool hmp_output_type_any(Visitor *v, const char *name, + QObject **obj, Error **errp) +{ + return true; +} + +static bool hmp_output_type_null(Visitor *v, const char *name, + QNull **obj, Error **errp) +{ + hmp_output_append_formatted(v, "%s=NULL", name); + + return true; +} + +static void hmp_output_complete(Visitor *v, void *opaque) +{ + HMPOutputVisitor *ov = to_hov(v); + + *ov->result = g_string_free(ov->buffer, false); + ov->buffer = NULL; +} + +static void hmp_output_free(Visitor *v) +{ + HMPOutputVisitor *ov = to_hov(v); + + if (ov->buffer) { + g_string_free(ov->buffer, true); + } + g_free(v); +} + +Visitor *hmp_output_visitor_new(char **result) +{ + HMPOutputVisitor *v; + + v = g_malloc0(sizeof(*v)); + + v->visitor.type = VISITOR_OUTPUT; + v->visitor.start_struct = hmp_output_start_struct; + v->visitor.end_struct = hmp_output_end_struct; + v->visitor.start_list = hmp_output_start_list; + v->visitor.next_list = hmp_output_next_list; + v->visitor.end_list = hmp_output_end_list; + v->visitor.type_int64 = hmp_output_type_int64; + v->visitor.type_uint64 = hmp_output_type_uint64; + v->visitor.type_bool = hmp_output_type_bool; + v->visitor.type_str = hmp_output_type_str; + v->visitor.type_number = hmp_output_type_number; + v->visitor.type_any = hmp_output_type_any; + v->visitor.type_null = hmp_output_type_null; + v->visitor.complete = hmp_output_complete; + v->visitor.free = hmp_output_free; + + v->result = result; + v->buffer = g_string_new(""); + v->is_continue = false; + + return &v->visitor; +} diff --git a/qapi/meson.build b/qapi/meson.build index 0652569bc4..94effbc052 100644 --- a/qapi/meson.build +++ b/qapi/meson.build @@ -8,6 +8,7 @@ util_ss.add(files( 'qobject-output-visitor.c', 'string-input-visitor.c', 'string-output-visitor.c', + 'hmp-output-visitor.c', )) if have_system or have_tools util_ss.add(files( -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 02 18:02:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 18:02:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92541.174512 (Exim 4.92) (envelope-from ) id 1lH9MH-0001K0-PW; Tue, 02 Mar 2021 18:02:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92541.174512; Tue, 02 Mar 2021 18:02:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH9MH-0001Jr-LJ; Tue, 02 Mar 2021 18:02:57 +0000 Received: by outflank-mailman (input) for mailman id 92541; Tue, 02 Mar 2021 18:02:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lH9MG-0001Io-Pz for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 18:02:56 +0000 Received: from forwardcorp1o.mail.yandex.net (unknown [95.108.205.193]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ae8789d2-33fd-4e2d-ac19-49bc1d53e060; Tue, 02 Mar 2021 18:02:55 +0000 (UTC) Received: from myt5-23f0be3aa648.qloud-c.yandex.net (myt5-23f0be3aa648.qloud-c.yandex.net [IPv6:2a02:6b8:c12:3e29:0:640:23f0:be3a]) by forwardcorp1o.mail.yandex.net (Yandex) with ESMTP id 609922E15C8; Tue, 2 Mar 2021 21:02:54 +0300 (MSK) Received: from myt5-70c90f7d6d7d.qloud-c.yandex.net (myt5-70c90f7d6d7d.qloud-c.yandex.net [2a02:6b8:c12:3e2c:0:640:70c9:f7d]) by myt5-23f0be3aa648.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id dc59eICpro-2rxe1tLf; Tue, 02 Mar 2021 21:02:54 +0300 Received: from dynamic-vpn.dhcp.yndx.net (dynamic-vpn.dhcp.yndx.net [2a02:6b8:b080:8002::1:1a]) by myt5-70c90f7d6d7d.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id onVeXhLyoo-2qo0XYka; Tue, 02 Mar 2021 21:02:53 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: ae8789d2-33fd-4e2d-ac19-49bc1d53e060 Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1614708174; bh=tqGbJUwXT9DHQMSmXyvwWHdwuWsscb7aSpvdvrgvkFc=; h=In-Reply-To:Message-Id:References:Date:Subject:To:From:Cc; b=tJHNcdp7lAAUX0AacvMrTOVv7Bgbf+8vbCMnjT8jKSjl/FsqnvxfC90R3EpWsEEWq FpuT/Lqk+XeM124B5pkdQI4+T6vtiZYabyl9MDlinCyGQafAiIyCFo1f5/GQzGmmU+ EDOwjOtbN+UwIs3FGjz2N5ldAYI+QZSc2KtzOlqQ= Authentication-Results: myt5-23f0be3aa648.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Alexey Kirillov To: Jason Wang , Markus Armbruster , Thomas Huth , Eric Blake Cc: Laurent Vivier , Samuel Thibault , "Michael S. Tsirkin" , Michael Roth , Paolo Bonzini , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Stefan Weil , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, yc-core@yandex-team.ru Subject: [PATCH v6 5/5] net: Do not fill legacy info_str for backends Date: Tue, 2 Mar 2021 21:02:05 +0300 Message-Id: <20210302180205.5009-6-lekiravi@yandex-team.ru> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210302180205.5009-1-lekiravi@yandex-team.ru> References: <20210302180205.5009-1-lekiravi@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As we use QAPI NetClientState->stored_config to store and get information about backend network devices, we can drop fill of legacy field info_str for them. We still use info_str field for NIC and hubports, so we can not completely remove it. Signed-off-by: Alexey Kirillov --- net/l2tpv3.c | 2 -- net/slirp.c | 3 --- net/socket.c | 28 ---------------------------- net/tap-win32.c | 2 -- net/tap.c | 9 --------- net/vde.c | 2 -- net/vhost-user.c | 1 - net/vhost-vdpa.c | 1 - 8 files changed, 48 deletions(-) diff --git a/net/l2tpv3.c b/net/l2tpv3.c index 96611cb4af..b7e1d84674 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -729,8 +729,6 @@ int net_init_l2tpv3(const Netdev *netdev, QAPI_CLONE_MEMBERS(NetdevL2TPv3Options, &nc->stored_config->u.l2tpv3, l2tpv3); - - s->nc.info_str = g_strdup_printf("l2tpv3: connected"); return 0; outerr: qemu_del_net_client(nc); diff --git a/net/slirp.c b/net/slirp.c index f8b3636fcc..99b131a3b0 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -669,9 +669,6 @@ static int net_slirp_init(NetClientState *peer, const char *model, stored->tftp_server_name = g_strdup(tftp_server_name); } - nc->info_str = g_strdup_printf("net=%s,restrict=%s", inet_ntoa(net), - restricted ? "on" : "off"); - s = DO_UPCAST(SlirpState, nc, nc); s->slirp = slirp_init(restricted, ipv4, net, mask, host, diff --git a/net/socket.c b/net/socket.c index 98172347d7..c0de10c0c0 100644 --- a/net/socket.c +++ b/net/socket.c @@ -180,8 +180,6 @@ static void net_socket_send(void *opaque) s->fd = -1; net_socket_rs_init(&s->rs, net_socket_rs_finalize, false); s->nc.link_down = true; - g_free(s->nc.info_str); - s->nc.info_str = g_new0(char, 1); return; } @@ -401,16 +399,10 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer, stored->mcast = g_strdup(mcast); s->dgram_dst = saddr; - nc->info_str = g_strdup_printf("socket: fd=%d (cloned mcast=%s:%d)", - fd, inet_ntoa(saddr.sin_addr), - ntohs(saddr.sin_port)); } else { if (sa_type == SOCKET_ADDRESS_TYPE_UNIX) { s->dgram_dst.sin_family = AF_UNIX; } - - nc->info_str = g_strdup_printf("socket: fd=%d %s", - fd, SocketAddressType_str(sa_type)); } return s; @@ -445,8 +437,6 @@ static NetSocketState *net_socket_fd_init_stream(NetClientState *peer, nc = qemu_new_net_client(&net_socket_info, peer, model, name); - nc->info_str = g_strdup_printf("socket: fd=%d", fd); - s = DO_UPCAST(NetSocketState, nc, nc); s->fd = fd; @@ -528,11 +518,6 @@ static void net_socket_accept(void *opaque) stored->has_fd = true; stored->fd = g_strdup_printf("%d", fd); - - g_free(s->nc.info_str); - s->nc.info_str = g_strdup_printf("socket: connection from %s:%d", - inet_ntoa(saddr.sin_addr), - ntohs(saddr.sin_port)); } static int net_socket_listen_init(NetClientState *peer, @@ -647,10 +632,6 @@ static int net_socket_connect_init(NetClientState *peer, stored->has_connect = true; stored->connect = g_strdup(host_str); - g_free(s->nc.info_str); - s->nc.info_str = g_strdup_printf("socket: connect to %s:%d", - inet_ntoa(saddr.sin_addr), - ntohs(saddr.sin_port)); return 0; } @@ -707,12 +688,7 @@ static int net_socket_mcast_init(NetClientState *peer, stored->localaddr = g_strdup(localaddr_str); } - g_free(s->nc.info_str); - s->nc.info_str = g_strdup_printf("socket: mcast=%s:%d", - inet_ntoa(saddr.sin_addr), - ntohs(saddr.sin_port)); return 0; - } static int net_socket_udp_init(NetClientState *peer, @@ -773,10 +749,6 @@ static int net_socket_udp_init(NetClientState *peer, stored->has_udp = true; stored->udp = g_strdup(rhost); - g_free(s->nc.info_str); - s->nc.info_str = g_strdup_printf("socket: udp=%s:%d", - inet_ntoa(raddr.sin_addr), - ntohs(raddr.sin_port)); return 0; } diff --git a/net/tap-win32.c b/net/tap-win32.c index 0888db8cce..21e451107b 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -787,8 +787,6 @@ static int tap_win32_init(NetClientState *peer, const char *model, stored->has_ifname = true; stored->ifname = g_strdup(ifname); - s->nc.info_str = g_strdup_printf("tap: ifname=%s", ifname); - s->handle = handle; qemu_add_wait_object(s->handle->tap_semaphore, tap_win32_send, s); diff --git a/net/tap.c b/net/tap.c index f864f434b2..12a08d54fe 100644 --- a/net/tap.c +++ b/net/tap.c @@ -625,8 +625,6 @@ int net_init_bridge(const Netdev *netdev, const char *name, stored->helper = g_strdup(helper); } - s->nc.info_str = g_strdup_printf("helper=%s,br=%s", helper, br); - return 0; } @@ -712,8 +710,6 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, stored->fds = g_strdup_printf("%s:%d", stored->fds, fd); g_free(tmp_s); } - - s->nc.info_str = g_strdup_printf("fd=%d", fd); } else if (tap->has_helper) { if (!stored->has_helper) { stored->has_helper = true; @@ -725,8 +721,6 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, stored->br = tap->has_br ? g_strdup(tap->br) : g_strdup(DEFAULT_BRIDGE_INTERFACE); } - - s->nc.info_str = g_strdup_printf("helper=%s", tap->helper); } else { if (ifname && !stored->has_ifname) { stored->has_ifname = true; @@ -743,9 +737,6 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, stored->downscript = g_strdup(downscript); } - s->nc.info_str = g_strdup_printf("ifname=%s,script=%s,downscript=%s", - ifname, script, downscript); - if (strcmp(downscript, "no") != 0) { snprintf(s->down_script, sizeof(s->down_script), "%s", downscript); snprintf(s->down_script_arg, sizeof(s->down_script_arg), diff --git a/net/vde.c b/net/vde.c index 67de6eb0c5..64bdb937ca 100644 --- a/net/vde.c +++ b/net/vde.c @@ -100,8 +100,6 @@ static int net_vde_init(NetClientState *peer, const char *model, nc = qemu_new_net_client(&net_vde_info, peer, model, name); - nc->info_str = g_strdup_printf("sock=%s,fd=%d", sock, vde_datafd(vde)); - s = DO_UPCAST(VDEState, nc, nc); s->vde = vde; diff --git a/net/vhost-user.c b/net/vhost-user.c index 49c9a740c2..e443c4b2b5 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -327,7 +327,6 @@ static int net_vhost_user_init(NetClientState *peer, const char *device, user = g_new0(struct VhostUserState, 1); for (i = 0; i < queues; i++) { nc = qemu_new_net_client(&net_vhost_user_info, peer, device, name); - nc->info_str = g_strdup_printf("vhost-user%d to %s", i, chr->label); nc->queue_index = i; if (!nc0) { nc0 = nc; diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 423d71770d..5a28bbcd7b 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -200,7 +200,6 @@ static int net_vhost_vdpa_init(NetClientState *peer, const char *device, stored->has_queues = true; stored->queues = 1; /* TODO: change when support multiqueue */ - nc->info_str = g_strdup_printf(TYPE_VHOST_VDPA); nc->queue_index = 0; s = DO_UPCAST(VhostVDPAState, nc, nc); vdpa_device_fd = qemu_open_old(vhostdev, O_RDWR); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 02 19:11:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 19:11:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92562.174524 (Exim 4.92) (envelope-from ) id 1lHAQ8-0000Kz-J5; Tue, 02 Mar 2021 19:11:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92562.174524; Tue, 02 Mar 2021 19:11:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHAQ8-0000Ks-Fu; Tue, 02 Mar 2021 19:11:00 +0000 Received: by outflank-mailman (input) for mailman id 92562; Tue, 02 Mar 2021 19:10:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHAQ7-0000Kn-98 for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 19:10:59 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 521920c3-08f4-4348-a12a-5ccfe7f23bf4; Tue, 02 Mar 2021 19:10:57 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-173-VIkJaDvLNzODWURBvDbnGg-1; Tue, 02 Mar 2021 14:10:55 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E349819611A0; Tue, 2 Mar 2021 19:10:52 +0000 (UTC) Received: from [10.3.113.12] (ovpn-113-12.phx2.redhat.com [10.3.113.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 313B46F447; Tue, 2 Mar 2021 19:10:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 521920c3-08f4-4348-a12a-5ccfe7f23bf4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614712257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1rJjCS8SfMd6EiWy+oL4Wkvtu28oL1WJmN+YYr+9Ai4=; b=RdNtJ6/CYxenIux0XlbojS6q3sBapviqNSFwfm909t7SRm84xa6ydB1nV4JuLfk+GECMuh StLEvx9cSiTqEk4Z5vO1mY0KC0tQGKvPIuLzB9qRSBXu4NEMZFgD67Joq7NgVs2Bp7tSPk px7Nk/0XwfUAipWwZdXJaxfAFm2Gaos= X-MC-Unique: VIkJaDvLNzODWURBvDbnGg-1 Subject: Re: [PATCH v6 1/5] qapi: net: Add query-netdev command To: Alexey Kirillov , Jason Wang , Markus Armbruster , Thomas Huth Cc: Laurent Vivier , Samuel Thibault , "Michael S. Tsirkin" , Michael Roth , Paolo Bonzini , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Stefan Weil , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, yc-core@yandex-team.ru References: <20210302180205.5009-1-lekiravi@yandex-team.ru> <20210302180205.5009-2-lekiravi@yandex-team.ru> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <79930db1-80fa-c810-7f72-131ec4671a71@redhat.com> Date: Tue, 2 Mar 2021 13:10:47 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210302180205.5009-2-lekiravi@yandex-team.ru> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/2/21 12:02 PM, Alexey Kirillov wrote: > The query-netdev command is used to get the configuration of the current > network device backends (netdevs). > This is the QMP analog of the HMP command "info network" but only for netdevs > (i.e. excluding NIC and hubports). > > The query-netdev command returns an array of objects of the NetdevInfo type, > which are an extension of Netdev type. It means that response can be used for > netdev-add after small modification. This can be useful for recreate the same > netdev configuration. > > Information about the network device is filled in when it is created or > modified and is available through the NetClientState->stored_config. > > Signed-off-by: Alexey Kirillov > Acked-by: Markus Armbruster > --- > +++ b/net/net.c > > +NetdevInfoList *qmp_query_netdev(Error **errp) > +{ > + NetdevInfoList *list = NULL; > + NetClientState *nc; > + > + QTAILQ_FOREACH(nc, &net_clients, next) { > + /* > + * Only look at netdevs (backend network devices), not for each queue > + * or NIC / hubport > + */ > + if (nc->stored_config) { > + NetdevInfoList *node = g_new0(NetdevInfoList, 1); Please use QAPI_LIST_PREPEND instead of open-coding it. > + > + node->value = QAPI_CLONE(NetdevInfo, nc->stored_config); > + g_free(node->value->id); /* Need to dealloc default empty id */ > + node->value->id = g_strdup(nc->name); > + > + node->value->has_peer_id = nc->peer != NULL; > + if (node->value->has_peer_id) { > + node->value->peer_id = g_strdup(nc->peer->name); > + } > + > + node->next = list; > + list = node; > + } > + } > + > +++ b/net/slirp.c > @@ -345,6 +345,14 @@ static SaveVMHandlers savevm_slirp_state = { > .load_state = net_slirp_state_load, > }; > > +#define APPEND_STRINGLIST(tail, new_val) \ > + do { \ > + *(tail) = g_new0(StringList, 1); \ > + (*(tail))->value = g_new0(String, 1); \ > + (*(tail))->value->str = g_strdup((new_val)); \ > + (tail) = &((*(tail))->next); \ > + } while (0) Please use QAPI_LIST_APPEND instead of re-coding it. > +++ b/qapi/net.json > @@ -714,3 +714,83 @@ > ## > { 'event': 'FAILOVER_NEGOTIATED', > 'data': {'device-id': 'str'} } > + > +## > +# @NetBackend: > +# > +# Available netdev backend drivers. > +# > +# Since: 6.0 > +## > +{ 'enum': 'NetBackend', > + 'data': [ 'user', 'tap', 'l2tpv3', 'socket', 'vde', 'bridge', 'netmap', > + 'vhost-user', 'vhost-vdpa' ] } Is it worth alphabetizing this list? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org From xen-devel-bounces@lists.xenproject.org Tue Mar 02 19:40:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 19:40:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92592.174553 (Exim 4.92) (envelope-from ) id 1lHAsH-0003Ud-AV; Tue, 02 Mar 2021 19:40:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92592.174553; Tue, 02 Mar 2021 19:40:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHAsH-0003U5-7T; Tue, 02 Mar 2021 19:40:05 +0000 Received: by outflank-mailman (input) for mailman id 92592; Tue, 02 Mar 2021 19:40:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHAsF-0003BP-Lj for xen-devel@lists.xenproject.org; Tue, 02 Mar 2021 19:40:03 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id abf5ef46-922e-4f57-90b2-e8a9a8f35b12; Tue, 02 Mar 2021 19:40:01 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4719A64F2C; Tue, 2 Mar 2021 19:40:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abf5ef46-922e-4f57-90b2-e8a9a8f35b12 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614714000; bh=Hzfg9485mh5UAZuP0YuPlDaGtR5kN4FKmW83z5H7ST0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=fQf+CDiw3mX2hIBOkrOZeUrgvQMyNffUTEg5W6kgCJyqP+Ci8b4YH/tQ+Pge/6sPP HbhA3UTsNiTds94jiKEN9Mx3EUzAh3FxKA8TuBuKX+IkANhQmTGpAdXcjtiTvYik5X kUeNDu28zuKbxHfwvDY/M4/xsC1V0VO50DAlU3VYcp9rN1lmhCmNDgldUYk448CWyg KaCoREUfK7kkCfiUOaoSh1Wznjglt2ktLrKN2Y41Q526izO9imsdVqAXlhXi3w5I5U pIBeGw6Jmp0VRB+lm0ZhnJrOfDQ+NTLsYbWfjPz2x+crhRZ7Or8wpMMIPU/1j4xk6V A/QXxnA7M+H4Q== Date: Tue, 2 Mar 2021 11:39:58 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini , Ian Jackson , Andrew Cooper Subject: Re: [PATCH for-4.15] automation/alpine: add g++ to the list of build depends In-Reply-To: <77e7004f-8a73-e868-1ccd-318de5886f4a@suse.com> Message-ID: References: <20210301095806.68518-1-roger.pau@citrix.com> <27ec9db0-69bc-df9a-8511-109f57972046@citrix.com> <77e7004f-8a73-e868-1ccd-318de5886f4a@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-308392656-1614714000=:2682" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-308392656-1614714000=:2682 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 2 Mar 2021, Jan Beulich wrote: > On 02.03.2021 10:36, Roger Pau Monné wrote: > > On Tue, Mar 02, 2021 at 09:53:41AM +0100, Jan Beulich wrote: > >> On 02.03.2021 09:14, Roger Pau Monné wrote: > >>> On Mon, Mar 01, 2021 at 06:01:36PM +0000, Andrew Cooper wrote: > >>>> On 01/03/2021 17:59, Andrew Cooper wrote: > >>>>> On 01/03/2021 09:58, Roger Pau Monne wrote: > >>>>>> clang++ relies on the C++ headers installed by g++, or else a clang > >>>>>> build will hit the following error: > >>>>>> > >>>>>> :3:10: fatal error: 'cstring' file not found > >>>>>> #include "cstring" > >>>>>> ^~~~~~~~~ > >>>>>> 1 error generated. > >>>>>> make[10]: *** [Makefile:120: headers++.chk] Error 1 > >>>>>> > >>>>>> Reported-by: Stefano Stabellini > >>>>>> Signed-off-by: Roger Pau Monné > >>>>>> --- > >>>>>> Cc: Ian Jackson > >>>>>> No real risk here from a release PoV, it's just pulling a package > >>>>>> required for the Alpine clang build. Worse that cold happen is that > >>>>>> the Alpine clang build broke, but it's already broken. > >>>>> Shouldn't this be fixed upstream in Alpine?  Its clearly a packaging bug. > >>>> > >>>> Or (thinking about it), we've got a build system bug using g++ when it > >>>> should be using clang++. > >>> > >>> No, the check is using clang++, the issue is that clang++ doesn't > >>> install the standard c++ headers, and thus trying to use them (cstring > >>> in this case) fails. Installing the g++ package solves the issue > >>> because it installs the headers. > >> > >> I have to admit that I consider this odd. The g++ package should > >> neither provide nor depend on the headers. It may recommend their > >> installation. On my distro (SLES) the headers come from the > >> libstdc++-devel package, as I would have expected. There > >> additionally is a dependency of libclang5 (no -devel suffix!) on > >> libstdc++-devel (I suppose this is an indication that things > >> aren't quite right here either; I haven't checked an up-to-date > >> version of the distro yet, though). > > > > Yes, that was indeed my first attempt as I've tried to install > > libstdc++, but there's no -devel counterpart for the package, and it > > only installs the libraries but not the headers. > > > > Then if I list the contents of the g++ package, I do see: > > > > ... > > usr/include/c++/10.2.1/cstring > > ... > > > > And clang++'s include path is: > > > > #include <...> search starts here: > > /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1 > > /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1/x86_64-alpine-linux-musl > > /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1/backward > > /usr/include > > /usr/lib/clang/10.0.1/include > > > > So it does seem clang depends on the gcc c++ headers, I assume this is > > done in order to avoid having a duplicate set of c++ headers for clang > > and gcc? I really have no idea, but I do think clang package should > > depend on g++. > > As long as the g++ package is what provides the headers (i.e. if that's > their concept), I agree. That makes sense to me too. Acked-by: Stefano Stabellini --8323329-308392656-1614714000=:2682-- From xen-devel-bounces@lists.xenproject.org Tue Mar 02 20:47:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 02 Mar 2021 20:47:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92608.174582 (Exim 4.92) (envelope-from ) id 1lHBvM-0001Xu-E0; Tue, 02 Mar 2021 20:47:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92608.174582; Tue, 02 Mar 2021 20:47:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHBvM-0001Xn-AO; Tue, 02 Mar 2021 20:47:20 +0000 Received: by outflank-mailman (input) for mailman id 92608; Tue, 02 Mar 2021 20:47:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHBvK-0001Xf-58; Tue, 02 Mar 2021 20:47:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHBvK-0004xW-0n; Tue, 02 Mar 2021 20:47:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHBvJ-00025a-LT; Tue, 02 Mar 2021 20:47:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHBvJ-0001Yl-Kg; Tue, 02 Mar 2021 20:47:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Mm6ka7XAVi6sQuAMPEz+Z0GE2JczOJ1xMRz+Auer0Ic=; b=e+QfkpX+DHzeY5OKmKfcurySuH m4TIY8cXrHR+nbxVEHVURZ1P4u/yqka5wqgx5RzfTy4Ux2+wYFv4WyTc4n1sqe8EJWHQmp8wXOGon kYFBkL+avyurm1klEu7hU1HrZvIqxSl/Dwqnqh0OWNYXRMwZizIDIh3R3UsN0EUIaDl0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159801: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6b4d4dd38470c2293caddf0a5f7034bb832bb574 X-Osstest-Versions-That: xen=77d7b3540c12b9bebba67dca8eb2d939d9e8b5df From: osstest service owner Date: Tue, 02 Mar 2021 20:47:17 +0000 flight 159801 xen-unstable real [real] flight 159807 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159801/ http://logs.test-lab.xenproject.org/osstest/logs/159807/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 159807-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 159795 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159795 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159795 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159795 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159795 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159795 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159795 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159795 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159795 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159795 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159795 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159795 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 6b4d4dd38470c2293caddf0a5f7034bb832bb574 baseline version: xen 77d7b3540c12b9bebba67dca8eb2d939d9e8b5df Last test of basis 159795 2021-03-01 18:36:29 Z 1 days Testing same since 159801 2021-03-02 06:04:18 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 77d7b3540c..6b4d4dd384 6b4d4dd38470c2293caddf0a5f7034bb832bb574 -> master From xen-devel-bounces@lists.xenproject.org Wed Mar 03 00:16:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 00:16:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92635.174596 (Exim 4.92) (envelope-from ) id 1lHFBZ-0005tQ-DE; Wed, 03 Mar 2021 00:16:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92635.174596; Wed, 03 Mar 2021 00:16:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHFBZ-0005tJ-AE; Wed, 03 Mar 2021 00:16:17 +0000 Received: by outflank-mailman (input) for mailman id 92635; Wed, 03 Mar 2021 00:16:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHFBX-0005tB-LQ; Wed, 03 Mar 2021 00:16:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHFBX-0000R4-G3; Wed, 03 Mar 2021 00:16:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHFBX-0002dx-6D; Wed, 03 Mar 2021 00:16:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHFBX-0000tR-5l; Wed, 03 Mar 2021 00:16:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4LWg9lSBP63NDCfexirn6NCMDAaC8dYa6SOe0ZpfcUA=; b=wNY90tE11xoxYjQNpi7jFIy6v6 5+0Smep4i0Iwy7Nrrdd9F1Fz2xfRnqOBCHN0A6QINsrP15aDQWPMLDSZTSUImk79J78J0oZ1VdAX8 qt94i67wHWucBR/cEqcPRwovOnoBMgi/uUYtg6NvAbZ7/zcHrc+X0r5lOKqweSVEUWBY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159804: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=51db2d7cf26d05a961ec0ee0eb773594b32cc4a1 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Wed, 03 Mar 2021 00:16:15 +0000 flight 159804 qemu-mainline real [real] flight 159809 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159804/ http://logs.test-lab.xenproject.org/osstest/logs/159809/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 51db2d7cf26d05a961ec0ee0eb773594b32cc4a1 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 194 days Failing since 152659 2020-08-21 14:07:39 Z 193 days 373 attempts Testing same since 159700 2021-02-26 08:46:59 Z 4 days 9 attempts ------------------------------------------------------------ 428 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 117941 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 03 01:46:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 01:46:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92642.174624 (Exim 4.92) (envelope-from ) id 1lHGat-00085b-Du; Wed, 03 Mar 2021 01:46:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92642.174624; Wed, 03 Mar 2021 01:46:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGat-00085U-An; Wed, 03 Mar 2021 01:46:31 +0000 Received: by outflank-mailman (input) for mailman id 92642; Wed, 03 Mar 2021 01:46:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGar-000841-Pq for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 01:46:29 +0000 Received: from mail-qv1-xf2c.google.com (unknown [2607:f8b0:4864:20::f2c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a9e9fbda-26c0-4664-8b1f-192141e9f5d7; Wed, 03 Mar 2021 01:46:24 +0000 (UTC) Received: by mail-qv1-xf2c.google.com with SMTP id r5so10907021qvv.9 for ; Tue, 02 Mar 2021 17:46:24 -0800 (PST) Received: from six.home (cpe-67-241-56-252.twcny.res.rr.com. [67.241.56.252]) by smtp.gmail.com with ESMTPSA id g21sm5406145qkk.72.2021.03.02.17.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 17:46:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9e9fbda-26c0-4664-8b1f-192141e9f5d7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=d3549LeDdOjw1wfdOgQuNmXcdgerSomgrqy3WUaXdIs=; b=S+W9hRMLlx9zEuE0+c4nDwmnRqQNsttx2156p9Nf12EOhJPyfgvIQ2+wxo8ondrl1J TSISvHwKtcFG99foz4tvClo3W7uqqVIfGiJy+zbbV+F/To6xe7UvF+5dQocBcdWmzQcG oI747VQDFc/GXZQtsWF+ujfvRAYwXzIdm+4YEEFmsu1q6vojCCm3btfoVMuvC7hsyEMX 6K+dChtfvRELSlck1Y5rh4fjsnW+mx0N+s0dSY5zrwHc+Kf/T3Z+e5SQDGIRY7jBNz8+ 4kjzZklUzxcicFr1mgTZWBpBKBZ0ghej3riwma3ZfEtzYNjCDi6rcLILRmWY3eO+aVt2 IUaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=d3549LeDdOjw1wfdOgQuNmXcdgerSomgrqy3WUaXdIs=; b=QKwG2B2wOPcwx2fsf7E9VgCHslhfI1a+OHV92xnj41pUGwFTTngr8kCbnptlz8iwcS YJObfVxRi7LvqbYB9zIg57iYGdgULmfQL7dFqdPJtNwx9H+5F0H1lTXJqtfoi3iWY4J6 DTewSHX4bNtocGfYT6uzCErtt96h1e27hs61l9HvoOqv++UoIwJK1lA8ntPr0BTtQlot 390ttpxwTVoFguPbP7CUsoiXWRCr90DHUoqe3jF0y4bEWI/fBFnQjPRIL0+g17thjsp1 Qi5OLfU49oFsCLDSL00LSYPkpJY31ckCnOVEebNzYYZBU55zudG9GNiFP4SaUyIoE/hh PWeQ== X-Gm-Message-State: AOAM533J7vLTnWW2vM10tzlPGYcftlFA6WcyK/s4vMoI7kiS1nziw0p6 eGLRjt+oJctnfW9gWkej8V33iqPZMIjOUg== X-Google-Smtp-Source: ABdhPJxLArmXxrobJohrB1yLe+OiwyMWj4S102WoUONDq1AiRM3wmVwOxT66SiWHbJpS0nqyQ13e0Q== X-Received: by 2002:a0c:fd63:: with SMTP id k3mr6421373qvs.30.1614735984461; Tue, 02 Mar 2021 17:46:24 -0800 (PST) From: Nick Rosbrook X-Google-Original-From: Nick Rosbrook To: xen-devel@lists.xenproject.org Cc: george.dunlap@citrix.com, Nick Rosbrook , Ian Jackson , Wei Liu , Anthony PERARD Subject: [RFC v2 1/7] libxl: remove extra whitespace from gentypes.py Date: Tue, 2 Mar 2021 20:46:13 -0500 Message-Id: <7a75b14f66acac499a0b17ab1c5595549421bac7.1614734296.git.rosbrookn@ainfosec.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: No functional change, just remove the extra whitespace from gentypes.py. Signed-off-by: Nick Rosbrook --- tools/libs/light/gentypes.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/libs/light/gentypes.py b/tools/libs/light/gentypes.py index 9a45e45acc..37de0f68b3 100644 --- a/tools/libs/light/gentypes.py +++ b/tools/libs/light/gentypes.py @@ -40,7 +40,7 @@ def libxl_C_type_define(ty, indent = ""): elif isinstance(ty, idl.Aggregate): if isinstance(ty, idl.KeyedUnion): s += libxl_C_instance_of(ty.keyvar.type, ty.keyvar.name) + ";\n" - + if ty.typename is None: s += "%s {\n" % ty.kind else: @@ -48,7 +48,7 @@ def libxl_C_type_define(ty, indent = ""): for f in ty.fields: if isinstance(ty, idl.KeyedUnion) and f.type is None: continue - + x = libxl_C_instance_of(f.type, f.name) if f.const: x = "const " + x @@ -164,7 +164,7 @@ def libxl_init_members(ty, nesting = 0): return [f for f in ty.fields if not f.const and isinstance(f.type,idl.KeyedUnion)] else: return [] - + def libxl_C_type_do_init(ty, pass_arg, need_zero=True, indent=" "): s=indent if ty.init_val is not None: @@ -229,20 +229,20 @@ def libxl_C_type_member_init(ty, field): raise Exception("Only KeyedUnion is supported for member init") ku = field.type - + s = "" s += "void %s(%s, %s)\n" % (ty.init_fn + "_" + ku.keyvar.name, ty.make_arg("p", passby=idl.PASS_BY_REFERENCE), ku.keyvar.type.make_arg(ku.keyvar.name)) s += "{\n" - + if ku.keyvar.init_val is not None: init_val = ku.keyvar.init_val elif ku.keyvar.type.init_val is not None: init_val = ku.keyvar.type.init_val else: init_val = None - + (nparent,fexpr) = ty.member(ty.pass_arg("p"), ku.keyvar, isref=True) if init_val is not None: s += " assert(%s == %s);\n" % (fexpr, init_val) @@ -732,7 +732,7 @@ if __name__ == '__main__': f.write(libxl_C_type_copy(ty, "dst", "src")) f.write("}\n") f.write("\n") - + for ty in [t for t in types if t.copy_deprecated_fn]: f.write("int %s(libxl_ctx *ctx, %s)\n" % (ty.copy_deprecated_fn, ty.make_arg("p", passby=idl.PASS_BY_REFERENCE))) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 01:46:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 01:46:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92644.174648 (Exim 4.92) (envelope-from ) id 1lHGb3-0008Cy-88; Wed, 03 Mar 2021 01:46:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92644.174648; Wed, 03 Mar 2021 01:46:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGb3-0008Cn-3k; Wed, 03 Mar 2021 01:46:41 +0000 Received: by outflank-mailman (input) for mailman id 92644; Wed, 03 Mar 2021 01:46:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGb1-000841-QL for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 01:46:39 +0000 Received: from mail-qk1-x72e.google.com (unknown [2607:f8b0:4864:20::72e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 88826741-7be0-4128-96f9-5c5fdacf9a8b; Wed, 03 Mar 2021 01:46:27 +0000 (UTC) Received: by mail-qk1-x72e.google.com with SMTP id g185so3229914qkf.6 for ; Tue, 02 Mar 2021 17:46:27 -0800 (PST) Received: from six.home (cpe-67-241-56-252.twcny.res.rr.com. [67.241.56.252]) by smtp.gmail.com with ESMTPSA id g21sm5406145qkk.72.2021.03.02.17.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 17:46:26 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88826741-7be0-4128-96f9-5c5fdacf9a8b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=NSsxG6jC6iAfi1izLJM576IbFfwdbov0QctCg+vigCk=; b=i7XvrduzFBb3vFjJ9h5JkKQLLbFxa5PxO1Guf6ZAdR1g6oa+fd0VX2/XAxWEY4a5OS pLDdYRz5wjNzvNtIj/LY4M9zIVmMV3E7jjbhUu5Zm5yGA9JaFvjSjC3nCJwTBsUwUzS7 UhzcTk6DJINxpem85hn0ACPx4UN2QImq9z8S/5lkcn2nh77h1LsWm2OmJvN9XWyAadYa KouzKt3/O3QmrWfNCztnD0RvJLYqPUVfZC+AEYf6WYNjNGl09PlXSbLIccC4FctWvGPq Un1jdV6gHcpnfjROwHd0GKIuqx92xhLzbYDKmEi/TdrVmpa4JBv4hbGfMYFpveRy/329 s5LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=NSsxG6jC6iAfi1izLJM576IbFfwdbov0QctCg+vigCk=; b=IkrnjDTh71bdfHphEsdykIGN+rXVsNlw3YDxsqGASsbDAnpthrznniAWe7d4phgM3Y vo9MB0hMAcfyH43Qnrpo3aIlzhrcESM505FMPqrq+TCjwpPjdcVGwlxb+yqQ6Bae6IgD 3WbHFVFQLhl6MIlEbjgeCinKpnBnh6QqsY7xsmWDXOvOYefY07fVwztcZjAKdce8uXHb NcWSU1AydTI4lE4PuGRzkqGmqX/NJ3P6klsVc233nmTz7clsjeE165y1IPMmwahfuLc4 JzxzVOuxxKAfC+odM8t6DYSpVwARWzcFT0oESBbqHwuWzCm+/YczNFQTJ18nK57+MgGH 6IBg== X-Gm-Message-State: AOAM530RwaZ0MnbrQOs7B20dIbcJhu3mRNq0AUB1UouwdxICFv4N8oXX 9/0EM9uUAmeHEDhxilgsiJ7cBT0ZtOiDYg== X-Google-Smtp-Source: ABdhPJz4Ks5EvlScGLnpU0G+C2xgzT2jcmx7EX7joUCoj1HPTIlcK/T/y6Vn8a8yV23XO9L4Tw/lww== X-Received: by 2002:ae9:eb57:: with SMTP id b84mr18756591qkg.271.1614735986824; Tue, 02 Mar 2021 17:46:26 -0800 (PST) From: Nick Rosbrook X-Google-Original-From: Nick Rosbrook To: xen-devel@lists.xenproject.org Cc: george.dunlap@citrix.com, Nick Rosbrook , Ian Jackson , Wei Liu , Anthony PERARD Subject: [RFC v2 3/7] libxl: add PASS_BY_CONST_REFERENCE to idl Date: Tue, 2 Mar 2021 20:46:15 -0500 Message-Id: <4b7f52dd28516aa286ab6db90536835b8caed022.1614734296.git.rosbrookn@ainfosec.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Currently, there is only support for PASS_BY_{REFERENCE,VALUE} in the IDL. As a piece of adding function support, add logic for PASS_BY_CONST_REFERENCE so that function generation code can use Type.make_arg() for function signatures that require const reference parameters. Signed-off-by: Nick Rosbrook --- tools/libs/light/idl.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/libs/light/idl.py b/tools/libs/light/idl.py index 20278c272a..a8a4768efc 100644 --- a/tools/libs/light/idl.py +++ b/tools/libs/light/idl.py @@ -4,6 +4,7 @@ import sys PASS_BY_VALUE = 1 PASS_BY_REFERENCE = 2 +PASS_BY_CONST_REFERENCE = 3 DIR_NONE = 0 DIR_IN = 1 @@ -40,7 +41,7 @@ class Type(object): raise ValueError self.passby = kwargs.setdefault('passby', PASS_BY_VALUE) - if self.passby not in [PASS_BY_VALUE, PASS_BY_REFERENCE]: + if self.passby not in [PASS_BY_VALUE, PASS_BY_REFERENCE, PASS_BY_CONST_REFERENCE]: raise ValueError self.private = kwargs.setdefault('private', False) @@ -109,6 +110,8 @@ class Type(object): if passby == PASS_BY_REFERENCE: return "%s *%s" % (self.typename, n) + elif passby == PASS_BY_CONST_REFERENCE: + return "const %s *%s" % (self.typename, n) else: return "%s %s" % (self.typename, n) @@ -116,7 +119,7 @@ class Type(object): if passby is None: passby = self.passby if isref is None: isref = self.passby == PASS_BY_REFERENCE - if passby == PASS_BY_REFERENCE: + if passby in [PASS_BY_REFERENCE, PASS_BY_CONST_REFERENCE]: if isref: return "%s" % (n) else: @@ -272,7 +275,7 @@ class KeyedUnion(Aggregate): raise ValueError kv_kwargs = dict([(x.lstrip('keyvar_'),y) for (x,y) in kwargs.items() if x.startswith('keyvar_')]) - + self.keyvar = Field(keyvar_type, keyvar_name, **kv_kwargs) for f in fields: @@ -392,6 +395,7 @@ def parse(f): elif isinstance(t,type(object)) and issubclass(t, Function): globs[n] = t elif n in ['PASS_BY_REFERENCE', 'PASS_BY_VALUE', + 'PASS_BY_CONST_REFERENCE', 'DIR_NONE', 'DIR_IN', 'DIR_OUT', 'DIR_BOTH', 'namespace', 'hidden']: globs[n] = t -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 01:46:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 01:46:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92641.174612 (Exim 4.92) (envelope-from ) id 1lHGao-00084E-8T; Wed, 03 Mar 2021 01:46:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92641.174612; Wed, 03 Mar 2021 01:46:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGao-000846-2l; Wed, 03 Mar 2021 01:46:26 +0000 Received: by outflank-mailman (input) for mailman id 92641; Wed, 03 Mar 2021 01:46:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGan-000841-4w for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 01:46:25 +0000 Received: from mail-qt1-x836.google.com (unknown [2607:f8b0:4864:20::836]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2e0d693a-253b-49b0-820b-4568eb680827; Wed, 03 Mar 2021 01:46:24 +0000 (UTC) Received: by mail-qt1-x836.google.com with SMTP id s15so16415257qtq.0 for ; Tue, 02 Mar 2021 17:46:23 -0800 (PST) Received: from six.home (cpe-67-241-56-252.twcny.res.rr.com. [67.241.56.252]) by smtp.gmail.com with ESMTPSA id g21sm5406145qkk.72.2021.03.02.17.46.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 17:46:22 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e0d693a-253b-49b0-820b-4568eb680827 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=FrLDylkw+U8rfdSCi7ScgTakUdJYNvinWBx5qALy/yI=; b=dB5bKhSmNpMUyQ1wVssPjTeTd1YoULzawIvCCGK23kfO7fMaZSz6I/Ani/7B9cVGqM zXsNtpENIwU3o1cP0HFwJqZS9XI6dpaYZgdVYF7HzqPgFO1Jo20M8ZpKEVavipG0zU7r VeAPnvoSYk6mD0aLPeDok+u3HF963rQ3LHGCr7cboJVRX2x7Kjg/T4Q8JqlI1K5DiQ35 VSrjhQErcMzUO13IKlO/L9vUncRoZYO1DIeM9uMnXFs+C+ClGCMLQty3KkGeNmypdfpn vSOVhsMbSMiLeQUNj1YibUSoND+ny79Xj9A7mV2UxfcHESaquidOf6raHxIlb6Bn+9/E yv2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FrLDylkw+U8rfdSCi7ScgTakUdJYNvinWBx5qALy/yI=; b=DUmW9yhZQlmObgrBEhO7IBbdg4XoCS4ovHsuzbLU8yU4WaKbAZ49xGM+3gkMad13zr tEaPnuTNT+3hksGQyHPfx+OMhuRZohecDZ2VK2jZ1RvzUmDuzGz6RgY2OO4oPfYf1c15 zaEaxfj0+ydbcqaxYOZ/g4j+eCeVDp+/w5Kj0F/KhCiSkv2CHq5O71DGTDm1S3Ec8bkD dUNU9rTGZBiiTBUMfwUNVhXKliDZaZkedNiuD25ikp66qcgBCLIcp7F2nnO7/aUcNyeH 55QzC/0B59Pft2gOFzFFoMnhtWGYzt0dd55NtdhBIP+kekWzHAxIKPnaCz5+klRcwZ64 QyqA== X-Gm-Message-State: AOAM5329b/LYxiAfp15W4WGMkUuvkxp5uhZZYYIAXojFroY0fPClaZLZ NapYpQ8O2vT4GfdQZV37DPEnVBJukkGIQA== X-Google-Smtp-Source: ABdhPJwUKEo6w7UoiiGFZp5YcggoA9/QEP7Ai3Xfp1O4MXEwEodzmyYUWMjg7qg1nZYyYbLoDCO9tw== X-Received: by 2002:ac8:74c9:: with SMTP id j9mr20998988qtr.369.1614735983341; Tue, 02 Mar 2021 17:46:23 -0800 (PST) From: Nick Rosbrook X-Google-Original-From: Nick Rosbrook To: xen-devel@lists.xenproject.org Cc: george.dunlap@citrix.com, Nick Rosbrook , Ian Jackson , Wei Liu , Anthony PERARD Subject: [RFC v2 0/7] add function support to IDL Date: Tue, 2 Mar 2021 20:46:12 -0500 Message-Id: X-Mailer: git-send-email 2.17.1 At a Xen Summit design session for the golang bindings (see [1]), we agreed that it would be beneficial to expand the libxl IDL with function support. In addition to benefiting libxl itself, this would allow other language bindings to easily generate function wrappers. The first version of this RFC is quite old [1]. I did address comments on the original RFC, but also expanded the scope a bit. As a way to evaluate function support, I worked on using this addition to the IDL to generate device add/remove/destroy functions, and removing the corresponding macros in libxl_internal.h. However, I stopped short of actually completing a build with this in place, as I thought it made sense to get feedback on the idea before working on the next step. [1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg00964.html [2] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg01352.html Nick Rosbrook (7): libxl: remove extra whitespace from gentypes.py libxl: add Function class to IDL libxl: add PASS_BY_CONST_REFERENCE to idl libxl: add DeviceFunction classes to IDL libxl: add device function definitions to libxl_types.idl libxl: implement device add/remove/destroy functions generation libxl: replace LIBXL_DEFINE_DEVICE* macro usage with generated code tools/golang/xenlight/gengotypes.py | 2 +- tools/libs/light/gentypes.py | 107 +++++++++++++-- tools/libs/light/idl.py | 69 +++++++++- tools/libs/light/libxl_9pfs.c | 2 - tools/libs/light/libxl_console.c | 2 - tools/libs/light/libxl_disk.c | 2 - tools/libs/light/libxl_nic.c | 2 - tools/libs/light/libxl_pvcalls.c | 2 - tools/libs/light/libxl_types.idl | 202 ++++++++++++++++++++++++++++ tools/libs/light/libxl_usb.c | 3 - tools/libs/light/libxl_vdispl.c | 2 - tools/libs/light/libxl_vkb.c | 1 - tools/libs/light/libxl_vsnd.c | 2 - tools/libs/light/libxl_vtpm.c | 2 - 14 files changed, 367 insertions(+), 33 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 01:46:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 01:46:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92643.174636 (Exim 4.92) (envelope-from ) id 1lHGax-00088I-Nl; Wed, 03 Mar 2021 01:46:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92643.174636; Wed, 03 Mar 2021 01:46:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGax-000889-Jq; Wed, 03 Mar 2021 01:46:35 +0000 Received: by outflank-mailman (input) for mailman id 92643; Wed, 03 Mar 2021 01:46:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGaw-000841-QA for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 01:46:34 +0000 Received: from mail-qk1-x732.google.com (unknown [2607:f8b0:4864:20::732]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a3077b7d-79b8-4b66-9feb-f6b58ccb2671; Wed, 03 Mar 2021 01:46:26 +0000 (UTC) Received: by mail-qk1-x732.google.com with SMTP id b130so10897584qkc.10 for ; Tue, 02 Mar 2021 17:46:26 -0800 (PST) Received: from six.home (cpe-67-241-56-252.twcny.res.rr.com. [67.241.56.252]) by smtp.gmail.com with ESMTPSA id g21sm5406145qkk.72.2021.03.02.17.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 17:46:25 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3077b7d-79b8-4b66-9feb-f6b58ccb2671 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=ITJlz1yVls1L4SWL3IJLaiNjFmwpPVqobYLq7BDZhNc=; b=RHLP7pwFdxbSwR7IR5byQQYXAWJ9le3sztKm+HRoyIm5Aa7VluQLhq1vaFjN0Z4Ebb PoQ+kx53UI5Mqs9qwqGPxzIjW6flbOuQCef7RWrdmz8+YjiyPdfK8ml3+LEyJ2deX1NO fx/bzEHQyhiUin0q+ltzqaQT9BVjdJtA8gLdTHVn0L6+Nqk4+W4/tAGw2LNge1RcXeN7 FQ44JKngxTm2a2ltU5IN9ukz5BV2ArtsbVE08Oe3itdCfAx0MATLg/QuVG+5nrCBu5oy qRU1x4OKbO+fypkqEJXeuvpXKzR3gQAjxCf5AE0fJ6QdHUMg3XyjW+zqUn7jCse+tQQP uR2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=ITJlz1yVls1L4SWL3IJLaiNjFmwpPVqobYLq7BDZhNc=; b=L3pK/pshSCqUjBFEtyBKAv8gEnCRn/zb0FaivDIgpNWhNs5Y7Ymu3rRLA9HmImv9U+ 86D0aVFY/CDvSkTi2akVyjJLPGCyiYCxKHZp/tTogiyQa6dkxqoQ1cA9T8BvvIXrbERs mcGvt6iuS/6uDg8VAzfTDRF88SBQcGCWkGc/npu2XN0URAqm1nsonXfUD9EsWSQ69LWy GPLiJ8hJqI3JWoPZ0JUMZetKmM593SdISSP2ZAMeC/jXahLzFR47m7Xts+Z1j7BPXEuh 1LloAlcZurlH0LESI4oPg87UZVCAnWx7rHiU8PrJiiqd+ECiOch435gs6H+UVl0I8VPC nzkg== X-Gm-Message-State: AOAM531og9/5xy5c68xK6b1f5tWMv6Yg/0lzDXMUVr1XovL3jLFM1VAT uuLdnlx2iMJ8AHHje6g6o/kaDVPFd0ybcw== X-Google-Smtp-Source: ABdhPJwf9vEmttoT9z+hs1iBJXF1N9mUVjBQHHeUJc29/71XkIQSrjGuiRR+Rdf5YH4ajF53eizOMw== X-Received: by 2002:a37:9385:: with SMTP id v127mr12608930qkd.131.1614735985760; Tue, 02 Mar 2021 17:46:25 -0800 (PST) From: Nick Rosbrook X-Google-Original-From: Nick Rosbrook To: xen-devel@lists.xenproject.org Cc: george.dunlap@citrix.com, Nick Rosbrook , Ian Jackson , Wei Liu , Anthony PERARD Subject: [RFC v2 2/7] libxl: add Function class to IDL Date: Tue, 2 Mar 2021 20:46:14 -0500 Message-Id: <2193e7fbc7c359b2e32551370ef57ba371658281.1614734296.git.rosbrookn@ainfosec.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Add a Function and CtxFunction classes to idl.py to allow generator scripts to generate wrappers which are repetitive and straight forward when doing so by hand. Examples of such functions are the device_add/remove functions. To start, a Function has attributes for namespace, name, parameters, and return type. The CtxFunction class extends this by indicating that a libxl_ctx is a required parmeter. Also, add logic to idl.parse to return the list of functions found in an IDL file. For now, have users of idl.py -- i.e. libxl/gentypes.py and golang/xenlight/gengotypes.py -- ignore the list of functions returned. Signed-off-by: Nick Rosbrook --- tools/golang/xenlight/gengotypes.py | 2 +- tools/libs/light/gentypes.py | 2 +- tools/libs/light/idl.py | 36 ++++++++++++++++++++++++++++- 3 files changed, 37 insertions(+), 3 deletions(-) diff --git a/tools/golang/xenlight/gengotypes.py b/tools/golang/xenlight/gengotypes.py index 3e40c3d5dc..484e121746 100644 --- a/tools/golang/xenlight/gengotypes.py +++ b/tools/golang/xenlight/gengotypes.py @@ -725,7 +725,7 @@ def xenlight_golang_fmt_name(name, exported = True): if __name__ == '__main__': idlname = sys.argv[1] - (builtins, types) = idl.parse(idlname) + (builtins, types, _) = idl.parse(idlname) for b in builtins: name = b.typename diff --git a/tools/libs/light/gentypes.py b/tools/libs/light/gentypes.py index 37de0f68b3..f9957b79a2 100644 --- a/tools/libs/light/gentypes.py +++ b/tools/libs/light/gentypes.py @@ -592,7 +592,7 @@ if __name__ == '__main__': (_, idlname, header, header_private, header_json, impl) = sys.argv - (builtins,types) = idl.parse(idlname) + (builtins,types,_) = idl.parse(idlname) print("outputting libxl type definitions to %s" % header) diff --git a/tools/libs/light/idl.py b/tools/libs/light/idl.py index d7367503b4..20278c272a 100644 --- a/tools/libs/light/idl.py +++ b/tools/libs/light/idl.py @@ -347,6 +347,35 @@ class OrderedDict(dict): def ordered_items(self): return [(x,self[x]) for x in self.__ordered] +class Function(object): + """ + A general description of a function signature. + + Attributes: + name (str): name of the function, excluding namespace. + params (list of (str,Type)): list of function parameters. + return_type (Type): the Type (if any), returned by the function. + """ + def __init__(self, name=None, params=None, return_type=None, namespace=None): + + if namespace is None: + self.namespace = _get_default_namespace() + else: + self.namespace = namespace + + self.name = self.namespace + name + self.rawname = name + self.params = params + self.return_type = return_type + +class CtxFunction(Function): + """ A function that requires a libxl_ctx. """ + def __init__(self, name=None, params=None, return_type=None): + ctx = Builtin("ctx", passby=PASS_BY_REFERENCE) + params.insert(0, ("ctx", ctx)) + + Function.__init__(self, name, params, return_type) + def parse(f): print("Parsing %s" % f, file=sys.stderr) @@ -358,6 +387,10 @@ def parse(f): globs[n] = t elif isinstance(t,type(object)) and issubclass(t, Type): globs[n] = t + elif isinstance(t, Function): + globs[n] = t + elif isinstance(t,type(object)) and issubclass(t, Function): + globs[n] = t elif n in ['PASS_BY_REFERENCE', 'PASS_BY_VALUE', 'DIR_NONE', 'DIR_IN', 'DIR_OUT', 'DIR_BOTH', 'namespace', 'hidden']: @@ -370,8 +403,9 @@ def parse(f): % (e.lineno, f, e.text)) types = [t for t in locs.ordered_values() if isinstance(t,Type)] + funcs = [f for f in locs.ordered_values() if isinstance(f,Function)] builtins = [t for t in types if isinstance(t,Builtin)] types = [t for t in types if not isinstance(t,Builtin)] - return (builtins,types) + return (builtins,types,funcs) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 01:46:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 01:46:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92645.174660 (Exim 4.92) (envelope-from ) id 1lHGb8-0008IH-Go; Wed, 03 Mar 2021 01:46:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92645.174660; Wed, 03 Mar 2021 01:46:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGb8-0008I9-DO; Wed, 03 Mar 2021 01:46:46 +0000 Received: by outflank-mailman (input) for mailman id 92645; Wed, 03 Mar 2021 01:46:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGb6-000841-QR for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 01:46:44 +0000 Received: from mail-qk1-x732.google.com (unknown [2607:f8b0:4864:20::732]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 556a758a-1727-4bff-b2e1-6901913f52b8; Wed, 03 Mar 2021 01:46:28 +0000 (UTC) Received: by mail-qk1-x732.google.com with SMTP id a9so7952555qkn.13 for ; Tue, 02 Mar 2021 17:46:28 -0800 (PST) Received: from six.home (cpe-67-241-56-252.twcny.res.rr.com. [67.241.56.252]) by smtp.gmail.com with ESMTPSA id g21sm5406145qkk.72.2021.03.02.17.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 17:46:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 556a758a-1727-4bff-b2e1-6901913f52b8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=NeaXDX2+Mvblx3YuOcY75d5cOiV30GS5wta6XWp6vVQ=; b=UkhmaFMyBysZaPiAAYUmbOmltiOZOyDhe1ox99Y69kNnkPCuhwwJOHv8A2PZZqtxqP qhlMrxz7U8kvTlZZLwP6SZ1+4IMe0JPc2ssj/HhxOoUSrltNcpWQu6cod57znEDiOeoe EVgoQ6UIqwphXFthBz+S32DBCGiaOkAwRnbqi46qn0tSixAIPn75XGa+ybZjQhbWC1fk cTNUvM4rc7CQjW9qX13O0JriI3RxH47QuCtSPTPJYXzJWH4pxIAVoK7A9bVn8UOxK0j2 IofhyF0li2QQWx9coiCYno0gyDFf5rYT7lhA8/BjibimPxz+m9ojttBEeXYSS5bPkaLf Uz6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=NeaXDX2+Mvblx3YuOcY75d5cOiV30GS5wta6XWp6vVQ=; b=fVHjK2hlmFDuko2wKGcVH3+Doqe7Nw6HTPkawPkxVsHnV5AE7mxDE1OrZBgbbNS2k0 Spb6Gk7cmJ2cXKLErnyxUcAEjnaC8k4GCZuNrBYcwEZzIuhDpSGHTYGskvEkdDauoTl9 vdd3WfmItDbT3w/AfzbLgV0NmlHXVCx1bVvis5L86IMgl0fgYOdQEKzMVwtokEOfYk05 kVTlcq1KNSw4ai7izgxVlb6Nrt+FOKe3813od6EXbz9F4+4Pp7063yXMiECcbuVHe3hO KXd+csmLUwsz0tX/5OuaUsRNjuVHi8XzuElxagdQcDukJStsRoPeErMmZg86KcFJs+Qn 6HmA== X-Gm-Message-State: AOAM5326XdwH+NR00x/3lD9S5NJs6F4PMVqu5A2VS/qESYXjmIWZeKtT bXqlVaIZZGAlL7yX9qKE8nAlRAHppZBLiQ== X-Google-Smtp-Source: ABdhPJyV9rkoVg4yxw6X9Mtgp+kwZR51+U7dCKeRs5TxPUaaKEVo6rH5xZGnyMfl7olyd5mCbzeApA== X-Received: by 2002:a37:ba03:: with SMTP id k3mr15691601qkf.336.1614735988001; Tue, 02 Mar 2021 17:46:28 -0800 (PST) From: Nick Rosbrook X-Google-Original-From: Nick Rosbrook To: xen-devel@lists.xenproject.org Cc: george.dunlap@citrix.com, Nick Rosbrook , Ian Jackson , Wei Liu , Anthony PERARD Subject: [RFC v2 4/7] libxl: add DeviceFunction classes to IDL Date: Tue, 2 Mar 2021 20:46:16 -0500 Message-Id: <5eba989c046387c17549d634841f8215c2fc5893.1614734296.git.rosbrookn@ainfosec.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Add a DeviceFunction base class, and Device{Add,Remove,Destroy}Function classes to idl.py. These classes will allow the device functions to be generated later in gentypes.py. The base class, DeviceFunction, extends CtxFunction and adds a domid parameter to the function's parameter list. When creating a DeviceFunction, the device parameter must be specified, and extra parameters can be specified if necessary. Rather than indicating specific device actions in the DeviceFunction class, child classes are created for each device function type. Right now, DeviceAddFunction does not extend the base class. DeviceRemoveFunction adds the option of specifying 'custom_remove' parameter when custom remove functions are needed. DeviceDestroyFunction is a child of DeviceRemoveFunction to inherit the custom_remove attribute. Signed-off-by: Nick Rosbrook --- tools/libs/light/idl.py | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/tools/libs/light/idl.py b/tools/libs/light/idl.py index a8a4768efc..570b168079 100644 --- a/tools/libs/light/idl.py +++ b/tools/libs/light/idl.py @@ -379,6 +379,29 @@ class CtxFunction(Function): Function.__init__(self, name, params, return_type) +class DeviceFunction(CtxFunction): + """ A function that modifies a domain's devices. """ + def __init__(self, name=None, device_param=None, extra_params=None, + return_type=None): + self.device_param = device_param + + params = [ ("domid", uint32), device_param ] + extra_params + + CtxFunction.__init__(self, name, params, return_type) + +class DeviceAddFunction(DeviceFunction): + pass + +class DeviceRemoveFunction(DeviceFunction): + def __init__(self, name=None, device_param=None, extra_params=None, + return_type=None, custom_remove=None): + self.custom_remove = custom_remove + + DeviceFunction.__init__(self, name, device_param, extra_params, return_type) + +class DeviceDestroyFunction(DeviceRemoveFunction): + pass + def parse(f): print("Parsing %s" % f, file=sys.stderr) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 01:46:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 01:46:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92647.174671 (Exim 4.92) (envelope-from ) id 1lHGbD-0008NP-Qj; Wed, 03 Mar 2021 01:46:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92647.174671; Wed, 03 Mar 2021 01:46:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGbD-0008NG-MF; Wed, 03 Mar 2021 01:46:51 +0000 Received: by outflank-mailman (input) for mailman id 92647; Wed, 03 Mar 2021 01:46:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGbB-000841-QS for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 01:46:49 +0000 Received: from mail-qv1-xf2b.google.com (unknown [2607:f8b0:4864:20::f2b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 09f5c152-e390-4f4d-b6f9-855b61d9817d; Wed, 03 Mar 2021 01:46:29 +0000 (UTC) Received: by mail-qv1-xf2b.google.com with SMTP id dj14so3383347qvb.1 for ; Tue, 02 Mar 2021 17:46:29 -0800 (PST) Received: from six.home (cpe-67-241-56-252.twcny.res.rr.com. [67.241.56.252]) by smtp.gmail.com with ESMTPSA id g21sm5406145qkk.72.2021.03.02.17.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 17:46:28 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09f5c152-e390-4f4d-b6f9-855b61d9817d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=V9qJff+98dFfqpPkCZweLxCXnXyOwxftISf2qu2jFAo=; b=nxoirzlyilLDZu27c+0cBEhVYn5Tx7APDjWJ+n0eC++T3KDUviuf+Pof+D3nV96SYH g3Lmx5Qfe6MDrgqGNHtoc+vpNzSLKkRBZytkaQw4a27AKat80mHXO8FIUwfnGrWtHqDl twL5deZRwi7HFx6kBLDmhCJBpFEztXl5k/kBb5zU4PYMnPPNG5misXwDaKdBbinBa1HJ +1OlGFTksjETj6OS4gYy3FEKeF6SFeMefODsvSq/UXL2XvbRWjVR3swZ2Zh4d4XKXfwb sDqGtzbbSA0eHIGIAjGsFhdVRMWJcZH49Nk0kDvVtg5UNFQ19n1za9fsMcTr53Ebewr8 4PMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=V9qJff+98dFfqpPkCZweLxCXnXyOwxftISf2qu2jFAo=; b=B/ORSFj7SdOv1dyp2Cx9FMfwM6F/cTnok3I1SyHgm6g5pFgQQEI33AVO8fbVxDcgeQ e6jlNwvpULZWbru4xMl+EJzynlJ0pIP2lTCTVky8iMKj8R22s2l8YYOrsYiSZ5Rl1M88 R4M3e+S7Dxvbx7Z8fdr3QM6edIr6OgvJGmip89/41I7QqOH175d3ICfhI3bAGnwk+EeN FORQT98j+PZEHC0GZHNwnPMkWr/IenT6Y78ZMRn9P5i85yS/zUkd74frUUcO+SbDssx1 ZDH1EFQudDE34qnUvPbj9vhIYQKSAIFupRgAsxOJlODOW0G8EZU0Ylc8PkIF0/nZ1098 Dthg== X-Gm-Message-State: AOAM531Aus3d192BGF8yjl3EXPqoA5IriaJ/PrE4s7brwedNVb9FZqJT 4V3tISows2eap0a+ie8IUqrpM1XLQfSwfw== X-Google-Smtp-Source: ABdhPJwkoby6QITo+fIBUYiHPnnJPafLiAMpJzRHMV6/0hpALc44HUW6gmcA5Pyupn2SYcCLUh3Ttw== X-Received: by 2002:ad4:542b:: with SMTP id g11mr6471580qvt.47.1614735989088; Tue, 02 Mar 2021 17:46:29 -0800 (PST) From: Nick Rosbrook X-Google-Original-From: Nick Rosbrook To: xen-devel@lists.xenproject.org Cc: george.dunlap@citrix.com, Nick Rosbrook , Ian Jackson , Wei Liu , Anthony PERARD Subject: [RFC v2 5/7] libxl: add device function definitions to libxl_types.idl Date: Tue, 2 Mar 2021 20:46:17 -0500 Message-Id: <2cd96b7e884c6f0c2667ef7499ff7179b99ea635.1614734296.git.rosbrookn@ainfosec.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Add definitions to libxl_type.idl for the device functions required by each device. In addition, add a Builtin definition for libxl_asyncop_how, since each device function requires this as a parameter. This is still prepatory work, and a later commit will make use of these new definitions to generate the code from gentypes.py. Signed-off-by: Nick Rosbrook --- tools/libs/light/libxl_types.idl | 202 +++++++++++++++++++++++++++++++ 1 file changed, 202 insertions(+) diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 5b85a7419f..550af7a1c7 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -33,6 +33,8 @@ libxl_hwcap = Builtin("hwcap", passby=PASS_BY_REFERENCE, json_parse_type="JSON_A libxl_ms_vm_genid = Builtin("ms_vm_genid", passby=PASS_BY_REFERENCE, check_default_fn="libxl_ms_vm_genid_is_zero", copy_fn="libxl_ms_vm_genid_copy") +libxl_asyncop_how = Builtin("asyncop_how", passby=PASS_BY_CONST_REFERENCE) + # # Specific integer types # @@ -666,6 +668,24 @@ libxl_device_vfb = Struct("device_vfb", [ ("keymap", string), ]) +libxl_device_vfb_add = DeviceAddFunction("device_vfb_add", + device_param=("vfb", libxl_device_vfb), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_vfb_remove = DeviceRemoveFunction("device_vfb_remove", + device_param=("vfb", libxl_device_vfb), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_vfb_destroy = DeviceDestroyFunction("device_vfb_destroy", + device_param=("vfb", libxl_device_vfb), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + libxl_device_vkb = Struct("device_vkb", [ ("backend_domid", libxl_domid), ("backend_domname", string), @@ -684,6 +704,24 @@ libxl_device_vkb = Struct("device_vkb", [ ("multi_touch_num_contacts", uint32) ]) +libxl_device_vkb_add = DeviceAddFunction("device_vkb_add", + device_param=("vkb", libxl_device_vkb), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_vkb_remove = DeviceRemoveFunction("device_vkb_remove", + device_param=("vkb", libxl_device_vkb), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_vkb_destroy = DeviceAddFunction("device_vkb_destroy", + device_param=("vkb", libxl_device_vkb), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + libxl_device_disk = Struct("device_disk", [ ("backend_domid", libxl_domid), ("backend_domname", string), @@ -708,6 +746,24 @@ libxl_device_disk = Struct("device_disk", [ ("hidden_disk", string) ]) +libxl_device_disk_add = DeviceAddFunction("device_disk_add", + device_param=("disk", libxl_device_disk), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_disk_remove = DeviceRemoveFunction("device_disk_remove", + device_param=("disk", libxl_device_disk), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_disk_destroy = DeviceDestroyFunction("device_disk_destroy", + device_param=("disk", libxl_device_disk), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + libxl_device_nic = Struct("device_nic", [ ("backend_domid", libxl_domid), ("backend_domname", string), @@ -776,6 +832,24 @@ libxl_device_nic = Struct("device_nic", [ ("colo_checkpoint_port", string) ]) +libxl_device_nic_add = DeviceAddFunction("device_nic_add", + device_param=("nic", libxl_device_nic), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_nic_remove = DeviceRemoveFunction("device_nic_remove", + device_param=("nic", libxl_device_nic), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_nic_destroy = DeviceDestroyFunction("device_nic_destroy", + device_param=("nic", libxl_device_nic), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + libxl_device_pci = Struct("device_pci", [ ("func", uint8), ("dev", uint8), @@ -791,6 +865,24 @@ libxl_device_pci = Struct("device_pci", [ ("name", string), ]) +libxl_device_pci_add = DeviceAddFunction("device_pci_add", + device_param=("pci", libxl_device_pci), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_pci_remove = DeviceRemoveFunction("device_pci_remove", + device_param=("pci", libxl_device_pci), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_pci_destroy = DeviceDestroyFunction("device_pci_destroy", + device_param=("pci", libxl_device_pci), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + libxl_device_rdm = Struct("device_rdm", [ ("start", uint64), ("size", uint64), @@ -817,6 +909,26 @@ libxl_device_usbctrl = Struct("device_usbctrl", [ ("backend_domname", string), ]) +libxl_device_usbctrl_add = DeviceAddFunction("device_usbctrl_add", + device_param=("usbctrl", libxl_device_usbctrl), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_usbctrl_remove = DeviceRemoveFunction("device_usbctrl_remove", + device_param=("usbctrl", libxl_device_usbctrl), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error, + custom_remove="usbctrl" +) + +libxl_device_usbctrl_destroy = DeviceDestroyFunction("device_usbctrl_destroy", + device_param=("usbctrl", libxl_device_usbctrl), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error, + custom_remove="usbctrl" +) + libxl_device_usbdev = Struct("device_usbdev", [ ("ctrl", libxl_devid), ("port", integer), @@ -827,6 +939,18 @@ libxl_device_usbdev = Struct("device_usbdev", [ ])), ]) +libxl_device_usbdev_add = DeviceAddFunction("device_usbdev_add", + device_param=("usbdev", libxl_device_usbdev), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_usbdev_remove = DeviceRemoveFunction("device_usbdev_remove", + device_param=("usbdev", libxl_device_usbdev), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + libxl_device_dtdev = Struct("device_dtdev", [ ("path", string), ]) @@ -838,6 +962,24 @@ libxl_device_vtpm = Struct("device_vtpm", [ ("uuid", libxl_uuid), ]) +libxl_device_vtpm_add = DeviceAddFunction("device_vtpm_add", + device_param=("vtpm", libxl_device_vtpm), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_vtpm_remove = DeviceRemoveFunction("device_vtpm_remove", + device_param=("vtpm", libxl_device_vtpm), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_vtpm_destroy = DeviceDestroyFunction("device_vtpm_destroy", + device_param=("vtpm", libxl_device_vtpm), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + libxl_device_p9 = Struct("device_p9", [ ("backend_domid", libxl_domid), ("backend_domname", string), @@ -847,12 +989,36 @@ libxl_device_p9 = Struct("device_p9", [ ("devid", libxl_devid), ]) +libxl_device_p9_remove = DeviceRemoveFunction("device_p9_remove", + device_param=("p9", libxl_device_p9), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_p9_destroy = DeviceDestroyFunction("device_p9_destroy", + device_param=("p9", libxl_device_p9), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + libxl_device_pvcallsif = Struct("device_pvcallsif", [ ("backend_domid", libxl_domid), ("backend_domname", string), ("devid", libxl_devid), ]) +libxl_device_pvcallsif_remove = DeviceRemoveFunction("device_pvcallsif_remove", + device_param=("pvcallsif", libxl_device_pvcallsif), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_pvcallsif_destroy = DeviceDestroyFunction("device_pvcallsif_destroy", + device_param=("pvcallsif", libxl_device_pvcallsif), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + libxl_device_channel = Struct("device_channel", [ ("backend_domid", libxl_domid), ("backend_domname", string), @@ -879,6 +1045,24 @@ libxl_device_vdispl = Struct("device_vdispl", [ ("connectors", Array(libxl_connector_param, "num_connectors")) ]) +libxl_device_vdispl_add = DeviceAddFunction("device_vdispl_add", + device_param=("vdispl", libxl_device_vdispl), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_vdispl_remove = DeviceRemoveFunction("device_vdispl_remove", + device_param=("vdispl", libxl_device_vdispl), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_vdispl_destroy = DeviceDestroyFunction("device_vdispl_destroy", + device_param=("vdispl", libxl_device_vdispl), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + libxl_vsnd_pcm_format = Enumeration("vsnd_pcm_format", [ (1, "S8"), (2, "U8"), @@ -942,6 +1126,24 @@ libxl_device_vsnd = Struct("device_vsnd", [ ("pcms", Array(libxl_vsnd_pcm, "num_vsnd_pcms")) ]) +libxl_device_vsnd_add = DeviceAddFunction("device_vsnd_add", + device_param=("vsnd", libxl_device_vsnd), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_vsnd_remove = DeviceRemoveFunction("device_vsnd_remove", + device_param=("vsnd", libxl_device_vsnd), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + +libxl_device_vsnd_destroy = DeviceDestroyFunction("device_vsnd_destroy", + device_param=("vsnd", libxl_device_vsnd), + extra_params=[("ao_how", libxl_asyncop_how)], + return_type=libxl_error +) + libxl_domain_config = Struct("domain_config", [ ("c_info", libxl_domain_create_info), ("b_info", libxl_domain_build_info), -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 01:46:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 01:46:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92648.174684 (Exim 4.92) (envelope-from ) id 1lHGbI-0008SD-4D; Wed, 03 Mar 2021 01:46:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92648.174684; Wed, 03 Mar 2021 01:46:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGbI-0008S5-0T; Wed, 03 Mar 2021 01:46:56 +0000 Received: by outflank-mailman (input) for mailman id 92648; Wed, 03 Mar 2021 01:46:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGbG-000841-QY for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 01:46:54 +0000 Received: from mail-qv1-xf30.google.com (unknown [2607:f8b0:4864:20::f30]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4152de8a-57c6-46b6-b772-e48621250722; Wed, 03 Mar 2021 01:46:31 +0000 (UTC) Received: by mail-qv1-xf30.google.com with SMTP id n4so8641165qvl.4 for ; Tue, 02 Mar 2021 17:46:31 -0800 (PST) Received: from six.home (cpe-67-241-56-252.twcny.res.rr.com. [67.241.56.252]) by smtp.gmail.com with ESMTPSA id g21sm5406145qkk.72.2021.03.02.17.46.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 17:46:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4152de8a-57c6-46b6-b772-e48621250722 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=ZBxo1ZZtGeZ/L0BM6vs2MRgDVAvnnL5QuvziUxZ+Mfs=; b=c/2/ARFN73/sZw/qonXPJ2alnC439EgjDE8nnYjsOEMkYU2zIXXiC60l8Jj5+SUVhV fPj6546TNsAxyqjYIg5iWcCUZREnxfsSx/bvLwg7x/QNEPySiTPAY6dsyB3LWdiP1WWd z+V/cLGCaFLjpnMNGUKZvneTiiNp7J2IVu3z/KTGAKtr9JXPecQq93znBsho5hb0TwuQ modv5t4aFo28hQ7mJeZM6q6dVrEGTxvYvRBDCfLro/cVVfn+2qyZIZoG0AJ0N5YcLHWo DHxI7365kLhovX0jQ40Cqg+lQHqOHym2iU5d+JbYJYWSXzCnqVnLYLrA7S09C/CvuhnQ v/ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=ZBxo1ZZtGeZ/L0BM6vs2MRgDVAvnnL5QuvziUxZ+Mfs=; b=kg6/j2gRJk+Dqti3F8juVU5u8VSCEUJz82bBCa7H6kQ3x6CN2OSiFGTylFMM3JNDNm ZMic6pr3nZApvwBsT1XyRwvciYl0TxocIXvnaJf1VcP0hO/MFUUuMw5C3xvgHyra1Jgt edBYHWmwLsZWDR2J5kdyW21WqNbUVNA0mcok0F0WNY3JFzvKYH0eBk5Oiyjz2vRIhXIT nKPHZM65j+a1mY5FGjKQfIsbVcPNE+Q0eoiWXlzPiuc7puVghU4JTOBVfw6hkN7vGcbH Pr/Q3b31uwMeiFUrhFxGUwTSOc+jMKjj7u0qPj7EelkvRMjrHCIEkiKI1EiKsrJAlJzS U7kQ== X-Gm-Message-State: AOAM533ctJN9f5sLHfrBSMSQsEzu4m3tip2EdcOVBo3V+Md4/3xohpyy 2D4BPbjQCWtCUlvjODIkDJs+mBKfEbX2hg== X-Google-Smtp-Source: ABdhPJwtuYq4lWi8WRY/KMlmq6VazCxMaPD9FCMWX5jPelkPzARQ/yVIFSB+00K4jzHx3dUmS6N8zA== X-Received: by 2002:a0c:c585:: with SMTP id a5mr662605qvj.60.1614735990468; Tue, 02 Mar 2021 17:46:30 -0800 (PST) From: Nick Rosbrook X-Google-Original-From: Nick Rosbrook To: xen-devel@lists.xenproject.org Cc: george.dunlap@citrix.com, Nick Rosbrook , Ian Jackson , Wei Liu , Anthony PERARD Subject: [RFC v2 6/7] libxl: implement device add/remove/destroy functions generation Date: Tue, 2 Mar 2021 20:46:18 -0500 Message-Id: <5986715fe1d677533b67c06e9561cd716716d46a.1614734296.git.rosbrookn@ainfosec.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Use the newly added function support in the IDL to generate the function definitions for the device add, remove, and destroy functions. The content of the generated functions is taken from the device fuction macro framework in libxl_internal.h. For now, the definitions are not actually written out to a .c file, but are invoked to ensure there is no build regression introduced. A later commit will replace the existing macros with this generated code. Signed-off-by: Nick Rosbrook --- tools/libs/light/gentypes.py | 91 +++++++++++++++++++++++++++++++++++- 1 file changed, 90 insertions(+), 1 deletion(-) diff --git a/tools/libs/light/gentypes.py b/tools/libs/light/gentypes.py index f9957b79a2..9f1856399a 100644 --- a/tools/libs/light/gentypes.py +++ b/tools/libs/light/gentypes.py @@ -584,6 +584,85 @@ def libxl_C_enum_from_string(ty, str, e, indent = " "): s = indent + s return s.replace("\n", "\n%s" % indent).rstrip(indent) +def libxl_func_define_device_add(func): + s = '' + + return_type = func.return_type.typename + if isinstance(func.return_type, idl.Enumeration): + return_type = idl.integer.typename + + params = ', '.join([ ty.make_arg(name) for (name,ty) in func.params ]) + + s += '{0} {1}({2})\n'.format(return_type, func.name, params) + s += '{\n' + s += '\tAO_CREATE(ctx, domid, ao_how);\n' + s += '\tlibxl__ao_device *aodev;\n\n' + s += '\tGCNEW(aodev);\n' + s += '\tlibxl__prepare_ao_device(ao, aodev);\n' + s += '\taodev->action = LIBXL__DEVICE_ACTION_ADD;\n' + s += '\taodev->callback = device_addrm_aocomplete;\n' + s += '\taodev->update_json = true;\n' + s += '\tlibxl__{0}(egc, domid, type, aodev);\n\n'.format(func.rawname) + s += '\treturn AO_INPROGRESS;\n' + s += '}\n' + + return s + +def libxl_func_define_device_remove_ext(func, action=None): + s = '' + + flag = None + if action == 'remove': + flag = 'LIBXL__FORCE_AUTO' + elif action == 'destroy': + flag = 'LIBXL__FORCE_ON' + else: + raise Exception('Unsupported action %s' % action) + + # This is used to formulate the function name libxl__device_from_ + devtype = func.device_param[1].rawname.replace('device_','') + + remtype = 'generic' + if func.custom_remove is not None: + remtype = func.custom_remove + + return_type = func.return_type.typename + if isinstance(func.return_type, idl.Enumeration): + return_type = idl.integer.typename + + params = ', '.join([ ty.make_arg(name) for (name,ty) in func.params ]) + + s += '{0} {1}({2})\n'.format(return_type, func.name, params) + s += '{\n' + s += '\tAO_CREATE(ctx, domid, ao_how);\n' + s += '\tlibxl__device *device;\n' + s += '\tlibxl__ao_device *aodev;\n' + s += '\tint rc;\n' + s += '\n' + s += '\tGCNEW(device);\n' + s += '\trc = libxl__device_from_{0}(gc, domid, type, device);\n'.format(devtype) + s += '\tif (rc != 0) goto out;\n' + s += '\n' + s += '\tGCNEW(aodev);\n' + s += '\tlibxl__prepare_ao_device(ao, aodev);\n' + s += '\taodev->action = LIBXL__DEVICE_ACTION_REMOVE;\n' + s += '\taodev->dev = device;\n' + s += '\taodev->callback = device_addrm_aocomplete;\n' + s += '\taodev->force.flag = {0};\n'.format(flag) + s += '\tlibxl__initiate_device_{0}_remove(egc, aodev);\n'.format(remtype) + s += '\n' + s += 'out:\n' + s += '\tif (rc) return AO_CREATE_FAIL(rc);\n' + s += '\treturn AO_INPROGRESS;\n' + s += '}\n' + + return s + +def libxl_func_define_device_remove(func): + return libxl_func_define_device_remove_ext(func, action='remove') + +def libxl_func_define_device_destroy(func): + return libxl_func_define_device_remove_ext(func, action='destroy') if __name__ == '__main__': if len(sys.argv) != 6: @@ -592,7 +671,7 @@ if __name__ == '__main__': (_, idlname, header, header_private, header_json, impl) = sys.argv - (builtins,types,_) = idl.parse(idlname) + (builtins,types,funcs) = idl.parse(idlname) print("outputting libxl type definitions to %s" % header) @@ -794,4 +873,14 @@ if __name__ == '__main__': f.write("}\n") f.write("\n") + for func in funcs: + if type(func) is idl.DeviceAddFunction: + _ = libxl_func_define_device_add(func) + elif type(func) is idl.DeviceRemoveFunction: + _ = libxl_func_define_device_remove(func) + elif type(func) is idl.DeviceDestroyFunction: + _ = libxl_func_define_device_destroy(func) + else: + raise Exception("Unexpected Function class %s" % type(func)) + f.close() -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 01:47:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 01:47:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92652.174696 (Exim 4.92) (envelope-from ) id 1lHGbN-00007l-KT; Wed, 03 Mar 2021 01:47:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92652.174696; Wed, 03 Mar 2021 01:47:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGbN-00007c-FY; Wed, 03 Mar 2021 01:47:01 +0000 Received: by outflank-mailman (input) for mailman id 92652; Wed, 03 Mar 2021 01:46:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHGbL-000841-Qj for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 01:46:59 +0000 Received: from mail-qv1-xf33.google.com (unknown [2607:f8b0:4864:20::f33]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f23ca88d-6216-4410-ad20-87b8e4b930a4; Wed, 03 Mar 2021 01:46:32 +0000 (UTC) Received: by mail-qv1-xf33.google.com with SMTP id h7so4011913qvm.2 for ; Tue, 02 Mar 2021 17:46:32 -0800 (PST) Received: from six.home (cpe-67-241-56-252.twcny.res.rr.com. [67.241.56.252]) by smtp.gmail.com with ESMTPSA id g21sm5406145qkk.72.2021.03.02.17.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 17:46:31 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f23ca88d-6216-4410-ad20-87b8e4b930a4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=nx6R5ORiCtnIpFZu+0txlPDpQ866FHk77wANc0bUqAI=; b=LiowHAHaHUAMpdlFR0qN7G4RMqMen6UvaUK6BX6rUY4JwiopRGc7CZbG/aDy/Xo+tY XOn5Qd/XdN78psWXxdDDoEXbBBcJmTUrO7ZjXb9/7VVKsusuEbvK8ezE3zqmeqQ/dBA0 maavLGertJurfR37hh0xN4KQw6z7KgOL8kdWwJmUgSS79DuSJG0hLtbb+G/TceGwlYEp jhYi5iNa9Yj/xbKb4XsZkKI3mDvlZsxNYgK89YTEvAWFvTwQRlpDMV6Fagb47uBvmeJ+ hyHkpZjCkph4o5A1Nn2bReSl3U837VyStkFsI1AUweSEvB+1DLXnrIWqMuczBFgZwtfy JxgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=nx6R5ORiCtnIpFZu+0txlPDpQ866FHk77wANc0bUqAI=; b=hE1vaHLu+DDuSTbgpa2/V1ygAoaMDFOwSMD0qP/leYtlafdCd+/DojOOe7L5Ytl7Ju 8toky+i4GvpZayXvRimMUmcyIn3SQGWOmsslK5Sm/h2RNCq/yobcf+nwZ8oOESmdxoJg E0ASTVTMLZo0a3kjg1Lk/8FW0XSkHS/LLTapNBE3fTURnmCjyjT4H6daTCNoPkTHEndK x9mmNa7OGi4kc/LP5eB+BlEi8Afj7Etsyn/tOj0acon5ffbU2IhwGilyi/PkvQcDcTUn 7G2gKyZGnvUpb7V33C1kJVwSnLj7zPOaaWeVBI/Rw/uKmfUFdOXQYKFgoSBtF6n+3KBu s24w== X-Gm-Message-State: AOAM5316phAANeDKaUYgZuLY63sXTSTFnuYMGUHv+XviDtgcMjAojA7I 5fwksXzbOJ0SZg1Bxn81LLkoqrPIk/vs4g== X-Google-Smtp-Source: ABdhPJw2+E75L/amcMYxB7PZVpDwE8JFQsGQc6/m+RgVKVFczfaVYlCvkNM5ek6oh86zQpbK4Vne1w== X-Received: by 2002:a0c:be86:: with SMTP id n6mr22740714qvi.61.1614735991489; Tue, 02 Mar 2021 17:46:31 -0800 (PST) From: Nick Rosbrook X-Google-Original-From: Nick Rosbrook To: xen-devel@lists.xenproject.org Cc: george.dunlap@citrix.com, Nick Rosbrook , Ian Jackson , Wei Liu , Anthony PERARD Subject: [RFC v2 7/7] libxl: replace LIBXL_DEFINE_DEVICE* macro usage with generated code Date: Tue, 2 Mar 2021 20:46:19 -0500 Message-Id: <25b500b54881b8ff3e86c7da5b8a977884471b01.1614734296.git.rosbrookn@ainfosec.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Allow the gentypes.py script to write generated function output to _libxl_types.c, and remove the LIBXL_DEFINE_DEVICE* macro calls in the appropriate locations. Signed-off-by: Nick Rosbrook --- Note: This commit does not build; there is more work to be done, particularly around accessing libxl__device_from* functions, as well as libxl__device__add functions. --- tools/libs/light/gentypes.py | 8 +++++--- tools/libs/light/libxl_9pfs.c | 2 -- tools/libs/light/libxl_console.c | 2 -- tools/libs/light/libxl_disk.c | 2 -- tools/libs/light/libxl_nic.c | 2 -- tools/libs/light/libxl_pvcalls.c | 2 -- tools/libs/light/libxl_usb.c | 3 --- tools/libs/light/libxl_vdispl.c | 2 -- tools/libs/light/libxl_vkb.c | 1 - tools/libs/light/libxl_vsnd.c | 2 -- tools/libs/light/libxl_vtpm.c | 2 -- 11 files changed, 5 insertions(+), 23 deletions(-) diff --git a/tools/libs/light/gentypes.py b/tools/libs/light/gentypes.py index 9f1856399a..5b72b4613e 100644 --- a/tools/libs/light/gentypes.py +++ b/tools/libs/light/gentypes.py @@ -874,12 +874,14 @@ if __name__ == '__main__': f.write("\n") for func in funcs: + f.write("\n") + if type(func) is idl.DeviceAddFunction: - _ = libxl_func_define_device_add(func) + f.write(libxl_func_define_device_add(func)) elif type(func) is idl.DeviceRemoveFunction: - _ = libxl_func_define_device_remove(func) + f.write(libxl_func_define_device_remove(func)) elif type(func) is idl.DeviceDestroyFunction: - _ = libxl_func_define_device_destroy(func) + f.write(libxl_func_define_device_destroy(func)) else: raise Exception("Unexpected Function class %s" % type(func)) diff --git a/tools/libs/light/libxl_9pfs.c b/tools/libs/light/libxl_9pfs.c index 5ab0d3aa21..f4875ea996 100644 --- a/tools/libs/light/libxl_9pfs.c +++ b/tools/libs/light/libxl_9pfs.c @@ -43,8 +43,6 @@ static int libxl__set_xenstore_p9(libxl__gc *gc, uint32_t domid, static LIBXL_DEFINE_UPDATE_DEVID(p9) static LIBXL_DEFINE_DEVICE_FROM_TYPE(p9) -LIBXL_DEFINE_DEVICE_REMOVE(p9) - DEFINE_DEVICE_TYPE_STRUCT(p9, 9PFS, p9s, .skip_attach = 1, .set_xenstore_config = (device_set_xenstore_config_fn_t) diff --git a/tools/libs/light/libxl_console.c b/tools/libs/light/libxl_console.c index d8b2bc5465..726bee3b16 100644 --- a/tools/libs/light/libxl_console.c +++ b/tools/libs/light/libxl_console.c @@ -723,8 +723,6 @@ static LIBXL_DEFINE_UPDATE_DEVID(vfb) static LIBXL_DEFINE_DEVICE_FROM_TYPE(vfb) /* vfb */ -LIBXL_DEFINE_DEVICE_REMOVE(vfb) - DEFINE_DEVICE_TYPE_STRUCT(vfb, VFB, vfbs, .skip_attach = 1, .set_xenstore_config = (device_set_xenstore_config_fn_t) diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.c index 411ffeaca6..16d2667d3a 100644 --- a/tools/libs/light/libxl_disk.c +++ b/tools/libs/light/libxl_disk.c @@ -1320,9 +1320,7 @@ out: * libxl_device_disk_destroy * libxl_device_disk_safe_remove */ -LIBXL_DEFINE_DEVICE_ADD(disk) LIBXL_DEFINE_DEVICES_ADD(disk) -LIBXL_DEFINE_DEVICE_REMOVE(disk) LIBXL_DEFINE_DEVICE_SAFE_REMOVE(disk) static int libxl_device_disk_compare(const libxl_device_disk *d1, diff --git a/tools/libs/light/libxl_nic.c b/tools/libs/light/libxl_nic.c index 0b45469dca..f77e1a07a5 100644 --- a/tools/libs/light/libxl_nic.c +++ b/tools/libs/light/libxl_nic.c @@ -525,9 +525,7 @@ static LIBXL_DEFINE_UPDATE_DEVID(nic) static LIBXL_DEFINE_DEVICE_FROM_TYPE(nic) LIBXL_DEFINE_DEVID_TO_DEVICE(nic) -LIBXL_DEFINE_DEVICE_ADD(nic) LIBXL_DEFINE_DEVICES_ADD(nic) -LIBXL_DEFINE_DEVICE_REMOVE(nic) DEFINE_DEVICE_TYPE_STRUCT(nic, VIF, nics, .update_config = libxl_device_nic_update_config, diff --git a/tools/libs/light/libxl_pvcalls.c b/tools/libs/light/libxl_pvcalls.c index 1fbedf651c..6816cc3d4d 100644 --- a/tools/libs/light/libxl_pvcalls.c +++ b/tools/libs/light/libxl_pvcalls.c @@ -32,6 +32,4 @@ static LIBXL_DEFINE_DEVICE_FROM_TYPE(pvcallsif) #define libxl_device_pvcallsif_list NULL #define libxl_device_pvcallsif_compare NULL -LIBXL_DEFINE_DEVICE_REMOVE(pvcallsif) - DEFINE_DEVICE_TYPE_STRUCT(pvcallsif, PVCALLS, pvcallsifs); diff --git a/tools/libs/light/libxl_usb.c b/tools/libs/light/libxl_usb.c index c5ae59681c..af5230b261 100644 --- a/tools/libs/light/libxl_usb.c +++ b/tools/libs/light/libxl_usb.c @@ -547,9 +547,7 @@ static void device_usbctrl_add_done(libxl__egc *egc, aodev->callback(egc, aodev); } -LIBXL_DEFINE_DEVICE_ADD(usbctrl) static LIBXL_DEFINE_DEVICES_ADD(usbctrl) -LIBXL_DEFINE_DEVICE_REMOVE_CUSTOM(usbctrl) static int libxl__device_usbdev_list_for_usbctrl(libxl__gc *gc, uint32_t domid, libxl_devid usbctrl, @@ -1865,7 +1863,6 @@ static void device_usbdev_add_done(libxl__egc *egc, aodev->callback(egc, aodev); } -LIBXL_DEFINE_DEVICE_ADD(usbdev) static LIBXL_DEFINE_DEVICES_ADD(usbdev) static void device_usbdev_remove_timeout(libxl__egc *egc, diff --git a/tools/libs/light/libxl_vdispl.c b/tools/libs/light/libxl_vdispl.c index 60427c76c2..13b6c2be99 100644 --- a/tools/libs/light/libxl_vdispl.c +++ b/tools/libs/light/libxl_vdispl.c @@ -202,8 +202,6 @@ static LIBXL_DEFINE_UPDATE_DEVID(vdispl) static LIBXL_DEFINE_DEVICES_ADD(vdispl) LIBXL_DEFINE_DEVID_TO_DEVICE(vdispl) -LIBXL_DEFINE_DEVICE_ADD(vdispl) -LIBXL_DEFINE_DEVICE_REMOVE(vdispl) LIBXL_DEFINE_DEVICE_LIST(vdispl) DEFINE_DEVICE_TYPE_STRUCT(vdispl, VDISPL, vdispls, diff --git a/tools/libs/light/libxl_vkb.c b/tools/libs/light/libxl_vkb.c index bb88059f93..5b552c262f 100644 --- a/tools/libs/light/libxl_vkb.c +++ b/tools/libs/light/libxl_vkb.c @@ -334,7 +334,6 @@ static LIBXL_DEFINE_UPDATE_DEVID(vkb) #define libxl_device_vkb_compare NULL LIBXL_DEFINE_DEVICE_LIST(vkb) -LIBXL_DEFINE_DEVICE_REMOVE(vkb) DEFINE_DEVICE_TYPE_STRUCT(vkb, VKBD, vkbs, .skip_attach = 1, diff --git a/tools/libs/light/libxl_vsnd.c b/tools/libs/light/libxl_vsnd.c index bb7942bbc9..16f448c74e 100644 --- a/tools/libs/light/libxl_vsnd.c +++ b/tools/libs/light/libxl_vsnd.c @@ -666,8 +666,6 @@ out: static LIBXL_DEFINE_UPDATE_DEVID(vsnd) static LIBXL_DEFINE_DEVICES_ADD(vsnd) -LIBXL_DEFINE_DEVICE_ADD(vsnd) -LIBXL_DEFINE_DEVICE_REMOVE(vsnd) LIBXL_DEFINE_DEVICE_LIST(vsnd) DEFINE_DEVICE_TYPE_STRUCT(vsnd, VSND, vsnds, diff --git a/tools/libs/light/libxl_vtpm.c b/tools/libs/light/libxl_vtpm.c index 0148c572d4..8dcc965860 100644 --- a/tools/libs/light/libxl_vtpm.c +++ b/tools/libs/light/libxl_vtpm.c @@ -227,8 +227,6 @@ static LIBXL_DEFINE_UPDATE_DEVID(vtpm) static LIBXL_DEFINE_DEVICE_FROM_TYPE(vtpm) static LIBXL_DEFINE_DEVICES_ADD(vtpm) -LIBXL_DEFINE_DEVICE_ADD(vtpm) -LIBXL_DEFINE_DEVICE_REMOVE(vtpm) LIBXL_DEFINE_DEVICE_LIST(vtpm) DEFINE_DEVICE_TYPE_STRUCT(vtpm, VTPM, vtpms, -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 03:10:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 03:10:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92687.174708 (Exim 4.92) (envelope-from ) id 1lHHtR-0000S9-SZ; Wed, 03 Mar 2021 03:09:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92687.174708; Wed, 03 Mar 2021 03:09:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHHtR-0000S2-P8; Wed, 03 Mar 2021 03:09:45 +0000 Received: by outflank-mailman (input) for mailman id 92687; Wed, 03 Mar 2021 03:09:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHHtQ-0000Ru-5k; Wed, 03 Mar 2021 03:09:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHHtP-0005IF-T8; Wed, 03 Mar 2021 03:09:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHHtP-0002Fu-HQ; Wed, 03 Mar 2021 03:09:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHHtP-00054V-Gv; Wed, 03 Mar 2021 03:09:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iX974g5apoLq0FdWe1QsuYHNUmYGxoELmqsS+Xrw8zE=; b=uzR6XOEfxTTBLBuSKeJ7k0flhV EmbQl2NQX0KDPfsfs6gDIwChglnnClTLEvL06sXB5DRdZ2mID2HBhv8iDH1wY091FTAAsRIAeptcH p87sZBG1l+HM7QCYd6WY5i8i9CMSiH2rOB200M+2pF3CsJ1OWsMlfWYoC9xQfNBjZD3Y=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159806: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-localmigrate:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7a7fd0de4a9804299793e564a555a49c1fc924cb X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Wed, 03 Mar 2021 03:09:43 +0000 flight 159806 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159806/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-coresched-amd64-xl 18 guest-localmigrate fail pass in 159798 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux 7a7fd0de4a9804299793e564a555a49c1fc924cb baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 214 days Failing since 152366 2020-08-01 20:49:34 Z 213 days 369 attempts Testing same since 159798 2021-03-02 02:40:53 Z 1 days 2 attempts ------------------------------------------------------------ 5135 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1271848 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 03 08:05:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 08:05:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92729.174741 (Exim 4.92) (envelope-from ) id 1lHMVu-0005kq-3h; Wed, 03 Mar 2021 08:05:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92729.174741; Wed, 03 Mar 2021 08:05:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHMVt-0005kj-Vo; Wed, 03 Mar 2021 08:05:45 +0000 Received: by outflank-mailman (input) for mailman id 92729; Wed, 03 Mar 2021 08:05:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHMVt-0005kb-Ip; Wed, 03 Mar 2021 08:05:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHMVt-0003EY-5V; Wed, 03 Mar 2021 08:05:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHMVs-0001pI-TX; Wed, 03 Mar 2021 08:05:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHMVs-0005HK-T2; Wed, 03 Mar 2021 08:05:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5wepomZuqWxnduOY2mtr6ozugeJl3jqc1rW8hA9xvz8=; b=4uHI7ZLM1WCnuRTBcJn3KfdcJ4 w7EaWWNyUxWX3xMXW3dRMORYJtZh+lO2gSnyJwD8MzDuzOuYnDk2e2tKdJSlMd6hkNrCQL9N6Pwam y0lUhHM2LzgdwG/XRuwK6PjrSqd20wobHn9K2LyHGS0SXtcWfaUJiaw9meswq9b4mfRw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 159812: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=ee3dc2c2c8e5b2d3976e43dde95bc0aeeafbef4f X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 03 Mar 2021 08:05:44 +0000 flight 159812 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/159812/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt ee3dc2c2c8e5b2d3976e43dde95bc0aeeafbef4f baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 236 days Failing since 151818 2020-07-11 04:18:52 Z 235 days 228 attempts Testing same since 159812 2021-03-03 04:19:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 45265 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 03 08:26:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 08:26:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92735.174756 (Exim 4.92) (envelope-from ) id 1lHMpT-0007ml-Gz; Wed, 03 Mar 2021 08:25:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92735.174756; Wed, 03 Mar 2021 08:25:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHMpT-0007me-Dp; Wed, 03 Mar 2021 08:25:59 +0000 Received: by outflank-mailman (input) for mailman id 92735; Wed, 03 Mar 2021 08:25:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHMpS-0007mZ-8d for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 08:25:58 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1e8b35b7-cbda-4c28-8aea-f25211b8e4a6; Wed, 03 Mar 2021 08:25:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e8b35b7-cbda-4c28-8aea-f25211b8e4a6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614759956; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=hcHZxn/yloaKbz4HuwpCWh+4xZp5v7qk/JNM42WjKUM=; b=A+A7KVXTah75pfvdVrR8+UEMouN6ZAZfeH3Z8ddOKKPz+jgynurD2+32 xg+PInDXURWf/bhcCDOAix0ZM8Iq2NBTyq7+m+E5RfsiJan4RDce96kQb j3Y2V1JlGWnAeiKhrwduSQbzT3HQjCMzuyo1Bq83/Hs//g4rjT8rrbzcu I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: uuDwz1FAh/1liOX7d3IO6wd6A601A9bFGNqAWHQumTENTR3oijsFFN3IjwFUQDqexZunHBCc+3 aXYtyba1A86TVLfu1e3RTbL5s5X0wazbqHAedmj+VtSJ3Q6vhtBCCTpgIF3ROBrdTO7vTr05yK DcTGz9sypdBWVksQwLTXaoeL+EtNJw6X6VNRCr/nYW1+VNN4/yvYH8CML8V8T1pNhjxp8KtGQY 45S70QbX0S0p3WL4W76y1ThBYgVKrPQo6LQ+YhykN5A70l2cCeyaPSDu38p79EXcSaL8WjF7U/ AXU= X-SBRS: 5.2 X-MesageID: 38330489 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,219,1610427600"; d="scan'208";a="38330489" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wslo/jYulT38fjCMMRYcjaQZOXzGADBtOzZ2slI1zBGNpEEgK/n5wdEntKPnKjG9B7QmArM0jIGi9J2XpGs1ce+coAc/ugg1utrlgPo0mednjyC2x88jOh3TPCJbctRXTqxS4+0946lC5hL8aH2kn0Dl8wbgsYjtCzh9p7lygEBYrnAFuruJydhfvjZBiop7JGAFqV4CnBZEuSfYJRrHmwFmF5kyx1osj5POWCOXqPUiF1c5ieEO3tT9bI+hv3WfbZLOztTixFVz949lhr07rLLxiWMqyI/h0GIBuZCBCWnxI1WTmTNpBsff87R7YBQQkzniVmijs/+HHylIRl2fZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cydJsAIez600M/vb94JozzdggeHZXjVoZDJiSVI8vdk=; b=PV8ve0gKJVXuIlXMjXjO2WRoD0Pb3w3j5oOe5LtHkJ11aQkFtMkM6D98FnJVgpKkVv+Y16YXYI6MOhfbZSF1p4LGcr9Z/KPptC5t3PSLKmJnT7l/NPkHbV5Gm0NAW8YnkfD/DUtGKJcJ6IEYPej6s3UIdJnlfh65kGBcV7j2qFt02eOden8Q90BcsEdmLXQhycSrgUIZeAxUigpRPfUljvt+yZEB4VG5EKjDw6cEpgVDQu74wwqPfUeFTs4XqH6jzciLnTqvlm8QXgClmE/GqdptagLzdblRT7arNXOUQgJKlpN0H5a/9BxW7IM1E5oLE0f0CYGGTJGOBQau2cA3+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cydJsAIez600M/vb94JozzdggeHZXjVoZDJiSVI8vdk=; b=PnOZaKCvkWYceAxyGtSN5B/MlnWQx7tpjJKsIZfiP1C+rokJtIcuARsyWfRWBgGZHS84fqJf4XM0GVXT5D0wZQQFVtT6wEcnwdQb7fjH26lZO7w8tA17NwCI/B5EiTz0BTwzc3ma//eMk+UyBWeJ4mWl2xOXZGumi9FE7C74BJU= From: Roger Pau Monne To: CC: Roger Pau Monne , Doug Goldstein , Ian Jackson , Stefano Stabellini Subject: [PATCH v2 for-4.15 2/2] automation: enable rombios build on Alpine Date: Wed, 3 Mar 2021 09:25:14 +0100 Message-ID: <20210303082514.8859-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210303082514.8859-1-roger.pau@citrix.com> References: <20210303082514.8859-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0105.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4af0a248-ee6c-41ec-0bf4-08d8de1dedcb X-MS-TrafficTypeDiagnostic: DM5PR03MB2971: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nLQlb27M+mENG/MRuNEDHtPzNx/lMn9A4ZWtgHK1XaeB/gWUTcEk4dnNe5a1AteUaKlaDUl4nrs5p2Hu0xpDN4fraSKqixRatBQMJLIcvCYST5jWxPjsm8URQgKahlcusB0AUlIZarneM7Qs0szMk1M+2MaL2IpRCoh9pMv+Uyk0zrsXnyGQW9s1pF+ETbujtWZOTNt7dC38vArSIIs0pOZoiKuI61UKLn4N+BIBHCgGWWk4lA7abu2ZOgXEEjlawssu/IT6/xKDa+QjpQAyVtAvro6RyrLaEU9DYEAkfj7xB7/K86F/O5E01RPsyoOKH8dvN0EhV4hUiVbiKKhjo3GO42f3hthMhThA+P2QdDp08izbXH0TRh26aoqA6Mw3daJK50jqVJ/IhUcmFilw2FVcFGc8g0TECYrkVoPkV0bDgyksBqHr0IxwNRsrOw8rXznE8+OIzPJ/EeTxi1GpTZkc2df3Drz/rRRtCN+onJsoAqjT93VSKZuC9BjkRBvnMZO0xF11nY6drUwYmxYzPw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(346002)(39840400004)(396003)(136003)(83380400001)(316002)(16526019)(186003)(6486002)(4326008)(6916009)(1076003)(54906003)(26005)(66946007)(36756003)(478600001)(86362001)(4744005)(6666004)(956004)(8676002)(8936002)(2906002)(66556008)(2616005)(66476007)(6496006)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?S29aM0x5QWx0WHVRMzJWNEk1UnBYR1hHeUQvdkFZQ1QrVU5ZNTlqSmVkMFFo?= =?utf-8?B?djNLK1o3S0dRZDN0K3NtL25RWEZLczdYL0hJV0tLRkJ1ZE1ZRnVFeXUwRnE4?= =?utf-8?B?bkF6Ykd6WG4vMTYwWnUzOG9NK2lJVzVlaUdtaS8rdlNhY1FyZ1hIQkg2cVMr?= =?utf-8?B?NC9HZmo4VElxcERlYWxkZG9UVTU4ZjQ5ZDFLMUtMNVExWDE5ZTlPb2RQb1ZH?= =?utf-8?B?S1V1TXFXUitad2FQOXYwQjJoMUN4ZlYrTmp5Z1R4WHFmNlhxUDBVR0l1N3NO?= =?utf-8?B?eHM5M09LSnBrVWd0KzBVTkduTEorQzNQYXY3VXFBc05aRDM5YVBIV1ptbjJR?= =?utf-8?B?WnR3eWQ0UmJQdFQ4WUdUMWZua1hReTZLaEhraUorZmFoRE15a0paMDhIMDdM?= =?utf-8?B?K3pJMjdXeUh5L0w0K2d2U2xCN1VXNW4vdGFUbFdWYU5hVHpiS2hzNDZuMGRG?= =?utf-8?B?UDRLM2dZeDl4UkQwUjRIY2l4bVhRTVVCM0R2NHZtbE52ejYxVjVRVUFhNDNU?= =?utf-8?B?NHhwK0lLSC9lU0JhTjhxQ1kwa213NE1wVGxWc2Q3WTIzSHVLbnR2ajBJekxz?= =?utf-8?B?L3daNXRpcUMyT29LNWZRTlVGb2RhTXR1Ym9ZWFhMUFJPTS9hQXZ1QjBuSHc0?= =?utf-8?B?QzFqTWQ4TzQ5c0JBKy82T2p0cnJEQXNhNUVjM1lIR29XZzF3R01LbUFSbGZj?= =?utf-8?B?WjMwQTc2bXZLZ3AraVR3cGFSK2pENzExWjFOR0IzOUdHeXlHZ1JJVTR4R2Zj?= =?utf-8?B?ekVwNnJ1M0IyMkRrUXJGTHIwVXNXUzQ4Ylk3NVV0OHNpZ1RQeEU1RVljLzJE?= =?utf-8?B?cFhvUE5FVDUrbzE1RE9LR3AzMWNCY1lqZzAyUFpwejhqc0JBdXYvcXNvTzRl?= =?utf-8?B?eGVlS3p2QnpIamQvcHh2endyVXFxN2UxN3JrWmFnV1BQQ2tuRlNpM1gwNGZU?= =?utf-8?B?RlZjYm8ybExpU0NEdzlpOW81K2NiSTdMWFJKTThCV1BSS1M2QXZQU1czMjJs?= =?utf-8?B?TW1zSktuOEEwY1ZvU21oNnp3TXFyMnFVRHRlUUc5a0JKbEN4VlRwcnN5dWZu?= =?utf-8?B?Z1dBQkJaSHBzTC9kOThhOTdjdnFxRndiTDJ4a1ZGN25RL0EySHV3aldGOGNn?= =?utf-8?B?a0wvRVZsbTF4UHh0N01pY09uOTB5ZHlpUGFvTWlPdkhhNE40NUZNY1FlUkF6?= =?utf-8?B?SnRkM0FGeHM3eVV0cmR6cW5yNE53WGNmbWp2ZlZtbnU2dG51TStET0xmQ3c0?= =?utf-8?B?U2RuMDNpOE0ySkNEQWpGTm1vb0VvTjlvWnlNY2RSaFlOS2tBb0Z0TW9jdmF3?= =?utf-8?B?UGZodmVVZmY2SnFBb2lyOEZQNmZxRUJoSXpsRDhUNW5tZDZCNGROK1daYzVR?= =?utf-8?B?YkZMNWRRbmhUV2dsUTJVc2Z1VWZxZVNQNko2aU9SVStJVlNTbklrb01oUm14?= =?utf-8?B?SEljbndLWU5xekJlRkhib2d5YnlhV0UwWkFGWEIraU80SW1JSVUxTkhreU54?= =?utf-8?B?ai83dnBOTDFLbEV4RFAzdEpWcndlTnp6TGovZ3ZHam4xVmxhNjY0OS9OaTQx?= =?utf-8?B?NFlKbW5XOFVjUVpueGlPYlk1QjAvbFFDdTQ3R3NXWFEwQUxuTGJydWI4SGQx?= =?utf-8?B?cHozVDdRQTZuMDJhaUNmS2pLU0l4QzgrOElvQmxxMnZSM1lyM0hDdEFha1Bq?= =?utf-8?B?aStVWlZRUWpxTFZ1UFJRRzdnWS9uNjhEbEJDaTdVOXMrWVI0dlJ3bkR3UlA5?= =?utf-8?Q?UUfb+UTRKeE9RwAL0d6LQE4xYL9i6at8c2Lo18S?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4af0a248-ee6c-41ec-0bf4-08d8de1dedcb X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 08:25:39.8865 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9kP0Ep7J5+sFpHypHBp1gzAkJWI1UOz+hrsCA9NfhZwctBF+rGz5wUkkuhltRqLUJZbkAlCiWALCD8BNSrx9wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2971 X-OriginatorOrg: citrix.com It's now safe to enable the build of rombios on Alpine systems, as hvmloader already builds fine there. Signed-off-by: Roger Pau Monné --- automation/scripts/build | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/automation/scripts/build b/automation/scripts/build index d8990c3bf4..87e44bb940 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -31,9 +31,8 @@ fi if ! test -z "$(ldd /bin/ls|grep musl|head -1)"; then # disable --disable-werror for QEMUU when building with MUSL cfgargs+=("--with-extra-qemuu-configure-args=\"--disable-werror\"") - # hvmloader doesn't build on MUSL systems - cfgargs+=("--disable-seabios") - cfgargs+=("--disable-rombios") + # SeaBIOS doesn't build on MUSL systems + cfgargs+=("--with-system-seabios=/bin/false") fi # Qemu requires Python 3.5 or later -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 08:26:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 08:26:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92736.174768 (Exim 4.92) (envelope-from ) id 1lHMpX-0007oJ-QL; Wed, 03 Mar 2021 08:26:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92736.174768; Wed, 03 Mar 2021 08:26:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHMpX-0007oC-Lv; Wed, 03 Mar 2021 08:26:03 +0000 Received: by outflank-mailman (input) for mailman id 92736; Wed, 03 Mar 2021 08:26:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHMpX-0007mZ-3u for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 08:26:03 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7e5071a3-8de0-4f9a-a884-eb1606359e18; Wed, 03 Mar 2021 08:25:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e5071a3-8de0-4f9a-a884-eb1606359e18 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614759957; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=Bowp7Wjx76RKiUGMtyN1bCNIOiEoEQH+54Xofmt6Xu8=; b=YbHuRwCsVsWD0MV8zihPXBq3euf/Nh/Eqc+Fzx6gSeLgRDndWkMQqri0 K77epKH95LiltdAex1XyPvo0qUozcTnwHQY2ohptpeC23NcwSbkE9+3Bh Ti59FZw+3bS2Bi0/3lrUAflPnBhHrrjX0fAhDCRW1NfcQAgPDBfYftvvZ 4=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: dLFieh7Zi3e1s0DJLqo8QBG2mPyZ/Iq5CYIm2WK8XEOVYdndkfdXPOVismd8n0jsOaUtocC2QG hNVykmRC8nuZrlwJgY9ashLGLyMKO6dXJka4vWIwlEEAIP6wIgvsfCi+YJ40fh8OE1zwNuu68y H4himy3URnNkjINS0X35G8ibDBqqXQGsX1i3DJ6VP9TOu3ozitkImYpWU+eTEewCcsXdFuBp9O I39i9opgWh8rjiIaIVnisyacfRlvmn4nTxmLgxUo/SuT7YmnKsCWV9bAJuxXD4xc44mlvg4/4g Z10= X-SBRS: 5.2 X-MesageID: 38330486 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,219,1610427600"; d="scan'208";a="38330486" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=III0ggyLBXW69OMXvG3EaFSo/79OHHLJV57yIlvojLHthBEBdWwiswyDgeIFajWjAV3Hn6OIuIMzNeP5k/i7ZPEL+EENcNu/FyzZnIafg6DyKk3xK8+J3vWzAKNSfJh3gdkMi3t1iYKkRPfii21VhCFlmNo7Vh1x9+w+WDHnetzT1Vs6nD4zKFrnoU35k4FzrJ9YLzJJULPLYCBih609ax8WfiBl6K9wbEvoMeEn70FsZtUYByPgy3te8DUWmaTgeEC9iG9SBF/N5SkH2B+DoAR77PSGlo+5tX0yWOxB3vLFLpMmJDmCpt2mekGKSkrZE+D0slW2xLvXsa0VfQcb0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P3LB65WjW0c6CvpRFxDabMFvI7fjVEVfNgsKLhiqLOo=; b=U4jHue1ZVwOnVw9OQHgYTfqA8O5qpU3lp8/pNHLafSAlXNXqIElRjkdhe7dPTZaVtN8tdBMmaMnNhREuV9ISezjw4+jYwXRtgLMYUUdLxyPemDXM93tCexBjZk1LemTcR0D3Xdh1OeezjLwZTPeDjsdeTL+/MpRGn6MchibWERFIXxMW02yrCe7cBaAhEBL/wTplTJ6vWRzvOEuGuiCAo2hRWYJE7GIBVm3DB1hQ84aVdLiCE09c1Ld3fPb5DvrJc/T52rtydQ2aFcZRbzDSllFOEyAu8EMObH76Rv0BV4yya3wCBWvrHu2ZjXNYmPahPuY7a6IEbuv6X+KYDw3WXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P3LB65WjW0c6CvpRFxDabMFvI7fjVEVfNgsKLhiqLOo=; b=XLmnEzlmcotL2o/Df9lSSS6hBeH07oWe54ohGQ3kEXF1puZ+ysaefErGB6f5LB6SZqUDvRBLOAPkXF03QjCH0Vc3culPv0YOyLGkMjNJOtcUjQVCA9Y6fysbEmO2RMnP2O25WG7EQ1kURFtpKJxe1lPNrwZqgaAFjP+LjxvvO8Q= From: Roger Pau Monne To: CC: Roger Pau Monne , Ian Jackson , Wei Liu , Jan Beulich , Andrew Cooper , Doug Goldstein Subject: [PATCH v2 for-4.15 0/2] firmware: fix build on Alpine Date: Wed, 3 Mar 2021 09:25:12 +0100 Message-ID: <20210303082514.8859-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0169.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::8) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b3d05af0-7d10-4671-f2d4-08d8de1de637 X-MS-TrafficTypeDiagnostic: DM5PR03MB2971: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O7VcekSjR/VFEPc5R+OF5Ukwcc0UgfV7x5/PuJLsW27ElS8ZAEOrfpAHqvhgPzExEeHNkBMJKTKAWxC+bH2CvwCNQWuZRCnl19zW3TmzEo33L45gz7e6PkI42uyUMX9yoA6sjrnIsbnscoyarjM2MKqOnpwjVSIPYcKDmF5YRwkW8e608xnQcro1XRY8YFlhxZ8ZTK8mivazIKcjiqKyHJFwyg/n/InoJFeUm50NqdCnla1vGBKJLZUBgDXKoPTT8/u8JL8GU0YgX7JjS+ygsptcS4Fm565RbEUvvW+KcsNkMS8fydZxFykslwVMhf//+iC8Jm9kwczi5teDw5eispNjaEbm82xWBVD1Q9ga4R+fVqALJ64FzhngvWY80YyKfKtON8h8mCGWLDEkCBuqLmrRyJe7x5VN4iHgvJrEaFwUvbI+64cLrY8C+4pcMH7o1d4vEng9CWjIEpuEzrujpOUFsj7780IW1f9rgEL1p6GyOzcdxWYVz836I6ELNlTdSiK5GsyB48PwPFwfQ/ZwJUZRwS9poGF/RZdxNZfCD0z2bLCuggzzYpgdZNz6HLElYjYf8sYdpOXyf2+oF44r9DyRWfEO8Z0UlCOWYE6vdyw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(346002)(39840400004)(396003)(136003)(83380400001)(316002)(16526019)(186003)(6486002)(4326008)(6916009)(966005)(1076003)(54906003)(26005)(66946007)(36756003)(478600001)(86362001)(6666004)(956004)(8676002)(8936002)(2906002)(66556008)(2616005)(66476007)(6496006)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?QVBBcG9nOUU2RENmb0Z5TGRPN2dQcGRaYTYra1I3MnJWYWpHTHY2NWY0VG5G?= =?utf-8?B?Tk5XQXk0L1hWTFhWTldIWE5TdXJURkN3ZlZReVZiTU4rZWN2bXp4Yjk1bTRs?= =?utf-8?B?VGhyaUtvYk1SeWVIcVREb3Z0QVdiMUpnc1VBei9qZXpBa3dLNDMzd1FIZnhI?= =?utf-8?B?b29OWVQ4OHZSeGxCZGFrcDBQMmo0dzZvNllabW9RZThiZjN0N1cxRGdnZmJQ?= =?utf-8?B?eU8yRUJvOEJVTzRjclVSekw1c1ZCZDFXU0Z5bnZSblhTUTlmQzhsZ2czd3dU?= =?utf-8?B?TlVkWFE3Rkljb3lyb2wza2xkbzRYSnk3Q0ZmaWs1NjlWekZaMkpPeTcvd2Zx?= =?utf-8?B?M2czbGhCbzFSZUlkejZNaXIwbDJUK2tSR1A4OFJMSXV4b1ExRjhLYjNkRU1p?= =?utf-8?B?RjFWWUNUc0JreTZ3ZDROTGpjcVJKMmRPV1lkVVp1b0hUYkNLVWFBRnlsc1JS?= =?utf-8?B?bXZUTFpQYXg3Z0JnZVMvcTVtWDZ2bXdFM2lmTnN4SEc5bDRud016dVg5ZXFq?= =?utf-8?B?Tnk5OE5UNytyTjJVc0hIajRyVFp5TGM1UzExdUVIQjdReGJYTkxoekdsWjRS?= =?utf-8?B?V2g3WDNmTnE4RWFPd1Fyd0h3QXBrNEF0K1g4cFgxUU1Ha1BtQUdxMi9pSGpl?= =?utf-8?B?b1BGTGJBemVYQXdqRDU2dkYyMVE4ZUd2OXhUM2grTlhjTG0zVTFoMnNoVjZB?= =?utf-8?B?clBtcHVPS3NXL3VBRjhqZzgrQ3B1eGlHMURCZmR4TzFGZjZ6T2g2bm5zYklO?= =?utf-8?B?cXJ1Lzg2eTNqV2xUK3ZCY3dTU2Q4WmtZMXZmUnd6V1ZYeC9vOUw3bkVTb0Zq?= =?utf-8?B?TllWOGRGQUw4L1hoUkx6NU5KL2lwYnFLZW1sWjVIU25jV0UwaFZrSTJpeEpr?= =?utf-8?B?UVo4eHBBOWcrZHJoQ2REOUpJUlU0S3ZZeisralVid1FWYllYYUF4UHFWM0Vo?= =?utf-8?B?SXpqZzRVemdXOXBJL2llOGdkbnlET2tlSU1XNUNXWUhyNEt4elg5SVN4OURi?= =?utf-8?B?eHNEMU5jOTRMNXZyM2IrcUFoNVltc1kxT2Y4cW1uWVlyK1pHbmVkRzJ6bmsy?= =?utf-8?B?RUQ4MlZyYXI2eUZ0OHZnOWl6TVcrMGlzMzRBNWpWdXBVYW1RRFpncFY2RDdw?= =?utf-8?B?VXZYMmw5YWp1WXN0R200Q1RjVkRZRmEzSTBVUFp4VlJSemhOaGh2aVFOMXR0?= =?utf-8?B?cXp2Kzdsb1d1L3p6aUtUTkNxNHlLc1Y0ZnVJa3ZVeGFxZXJoTEU3YnIwTjBE?= =?utf-8?B?YXhJQXdGT1cveWJ5elA2bHAyS2gwa2ZHT0JUVzdFTUFuSUZ3VTVOUFhQWTUr?= =?utf-8?B?WDZQZ0ZWanNWYmpaZVcwUlNCeGlXMUQ3ZUQvNkd3WWFzL09RR2lKSmNEeHNu?= =?utf-8?B?bkpkRFkvWGJPcDFpbkFnczQyOUVZVzNoRkc5TFp1eHlEQlZEY1FRdXRLRVN6?= =?utf-8?B?NkQzQkp1UUlKdldsdWVpSmsxZERkNDhCdGRaa2JSazRSenZZaU1pWlNWNDVu?= =?utf-8?B?TXZzUWRxanpCSXQ4bWFpRENXZ0RhdExnYXpDK0FDY3pmTDR2S3JJenNnYW94?= =?utf-8?B?L2JPdXJMRXNaY3FHTklnL2dWQXIrcG1PR3VJVzVqeURBMW83K3hDQ296bnZU?= =?utf-8?B?V0d4YzFBU2Vub3RtenFyRHNOUDdSbzg4YW1Xa1BOc2Z4WHovYmR5ZFdENmVi?= =?utf-8?B?cGJQcWE0SElRNUxQN0F1a1UxU0xqNFFqSCt3RTZ0NVBIVTFNRm16WVNRN1JO?= =?utf-8?Q?+Y7UR2d/E0tEpOq0xk5QXJMnWh8PSgLVVHUxOdQ?= X-MS-Exchange-CrossTenant-Network-Message-Id: b3d05af0-7d10-4671-f2d4-08d8de1de637 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 08:25:27.3228 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZuYXjDHR2BMK4cFyA834gj7LdCTNb/S6JWRX9yrOZF78QYdKSzaHas48tM+jkd3PldhbnvnuUf6nwwkqFEJxZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2971 X-OriginatorOrg: citrix.com Hello, While the series started as a build fix for Alpine I think they are interesting on their own for other OSes/distros. The main risk for patch 1 is breaking the build in some obscure distro/OS and toolchain combination. We aim to have this mostly covered by gitlab CI. Patch 2 main risk is breaking the Alpine containers in gitlab CI, but they are already failing. Wanted to send this yesterday but was waiting on gitlab CI output, it's now all green: https://gitlab.com/xen-project/people/royger/xen/-/pipelines/264321420 Thanks, Roger. Roger Pau Monne (2): firmware: provide a stand alone set of headers automation: enable rombios build on Alpine automation/scripts/build | 5 +-- tools/firmware/Rules.mk | 13 +++++++ tools/firmware/include/stdarg.h | 10 +++++ tools/firmware/include/stdbool.h | 9 +++++ tools/firmware/include/stddef.h | 10 +++++ tools/firmware/include/stdint.h | 39 +++++++++++++++++++ tools/firmware/rombios/32bit/rombios_compat.h | 4 +- 7 files changed, 84 insertions(+), 6 deletions(-) create mode 100644 tools/firmware/include/stdarg.h create mode 100644 tools/firmware/include/stdbool.h create mode 100644 tools/firmware/include/stddef.h create mode 100644 tools/firmware/include/stdint.h -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 08:26:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 08:26:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92737.174780 (Exim 4.92) (envelope-from ) id 1lHMpd-0007sH-6Q; Wed, 03 Mar 2021 08:26:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92737.174780; Wed, 03 Mar 2021 08:26:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHMpd-0007sA-2g; Wed, 03 Mar 2021 08:26:09 +0000 Received: by outflank-mailman (input) for mailman id 92737; Wed, 03 Mar 2021 08:26:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHMpc-0007mZ-49 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 08:26:08 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 63453bbd-cf41-463f-809b-e2fff7be1adf; Wed, 03 Mar 2021 08:26:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63453bbd-cf41-463f-809b-e2fff7be1adf DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614759964; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=oHuHX38srv3wzfUid8WUr7eIG/2a8lp5JbRPysRJmKY=; b=UcVpDvQnH9SkD80JsefmKa2QSB6GNCSyRotJXE4x8wMGPW0COREYL6Xr oZnRMXwzegtqGj4Z71/vRY26binA1eV46RwdHCx7ziYz1QNTsShs7+BOb psnzEf5SLNHD6ix4MowLUCGLmJw0jNPpDN02DQ5nAliRW9WKLw0LQuCpp o=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 8GlVVeZhJ/4VaCyz1PY+9c+Muf6qqennJIp7nK17P0EU8rdZuZ3CXCOyX4tyXOYfW79DGWhnBo T61VDnclTe3W/nU3uKoSF3VeuT/Rz5lU10uR4dlcppgmTpI2rQNErvdZuUdAjm02gf0jP1SpKg 3WQuPorYtGmrq1Rd3JnZXtfU9q0ed22HmKplQUKdAtI5xkfkc+e13z5uisfXrPcnLmsYdMNHi7 c6EXJcTRHVXv2YFfQtUYsDuYDQNzKwJvYSKEoHyRVUyDNC6oxwuGiQuxNsZxaILtFaPc/H8OFe 6X8= X-SBRS: 5.2 X-MesageID: 38600577 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,219,1610427600"; d="scan'208";a="38600577" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a1hmgoqKnc5o4rL/H/UqcdYV2dYhf5csWLLW0XETiywdIrbDIrQZ9mNa1CkIn9EEM+/rdo7zBwltKgv9xKJG0xraIVorI5V+d8rnSyxQzgQKuf3od0S8oY9hdBcAPX65sE0CrsBRoo3Z8+lngPvkAzxmgVC9/EQZ25Gi6bt4zgGbDxr6aPrdRmZQpuV/ZxVMC3eCV8Cfr55NmKXzFe+SV0ZTOS/FE+5WhFWhIxknNRHZz7Y3+FSlbNGI1AcMQrwd/EmEjvP/vk/Lu8GOC2lSQafRJ4DMYo7nS7kCzEVXFX1BEQFNUApwFMUevyF4p9Z12pYfGmvO2uFed8LNc3bp3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UveaccZp06KTjCJudT2M/QZr/Z5EGmNpCdWGdUyGE0A=; b=G2lN/EzMz6hquI52tWZNhjbWYPh0G8jC0sRmVZm7G0ayNEScI5Bqu3GTH2Enx0qOe24+SVoyvPLL2/J1mApFXXEEz0XZNsfStpQhnjz0jeHN2/pUgGqD8Y6U5VBkGHAuZSIzbeIqO6mjW1WtOofWUexXkYApVB895owDgvLYhHjZq+KZSoF/jIwRe+PLf9a5iSO17SinzJbH6IuIzEKcfkZs2wX/CGIN44l00rCZQNXc1gkkyHhBo1q8bTNQOeGw9CQ1inMTks9wMMWty/vJ4vcPPALCWt3By5xOy5LU8r2a7YNW9Tx92zNPwAxSE7D10EnlhBpGXuxTcecbJensLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UveaccZp06KTjCJudT2M/QZr/Z5EGmNpCdWGdUyGE0A=; b=a4a7iZPgnNUDwBQsq/VXE2g0coUY+cccQqCjIS6TrPnOlUjZH/OZLQwA1QUhGGltMTkuopnNFlmpwUbkgcs5K4SOyf9x2uNzWtB1DUByJfqsXPatF/3oDKUqmFf3j6ejD98tDLOpxJNm9U5RXOmK6N7p3ZfGcaYn0kgbh7GytmI= From: Roger Pau Monne To: CC: Roger Pau Monne , Ian Jackson , Wei Liu , Jan Beulich , Andrew Cooper Subject: [PATCH v2 for-4.15 1/2] firmware: provide a stand alone set of headers Date: Wed, 3 Mar 2021 09:25:13 +0100 Message-ID: <20210303082514.8859-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210303082514.8859-1-roger.pau@citrix.com> References: <20210303082514.8859-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0058.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:31::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4aea52e6-7327-45ec-7fd2-08d8de1dea0d X-MS-TrafficTypeDiagnostic: DM5PR03MB2971: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4UB93V/KFoq6gsAW/VDg3YO1kMAjOMxAiaUqen6EiCaIhJb4+cSR+pxXvAN1voe9TuxPCw19rniq9JZKOK0/EfLAVKB4J3HjiTv4shjU/WftUzvGn4VaX+PYXwkbHp3cD/r9u7xVpuheAImlHDvbQ+ph77XmE9+lZ/ZSZb64+BH4nC1C4wZgRGCoWyIoLDYM4pw8Wu2dF1kuAP/G6c3/zfniGB0Cpjs4ONq00xWy9Z9VjrqtbF6h1yEJT405QUKjAjffto+momSeJ213jLJnLln6pNkTJivVZasBGbMA/IXs7rnN3lEcOD9mTwrmIvq2/LH84X/xrdznhAq1/21hxZv2c4GcyfGYaU5VEQv+OEZTYs3bgX+sK3w9Lki+LxDWXKwoigQApHy4aAGSBPNyggAvgYFXeEipSglAto04htG9GB9/KlMWfOzVdJxksAXQCr+qQ+Arfp57yCuRSCgbSzZJAobrFT7massUfghl0n9aiB7913rP3EiMW2wglzUsntHOMHVedld+OiNYCx8hq5MFxbh01UgBJ2IgUoRKqQhjNnM15NOi99ztlyqGmExOWkCBQzdyRLiCLxA41alk+XMMAmlIONqqCTXKmwh1kEk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(346002)(39840400004)(396003)(136003)(83380400001)(316002)(16526019)(186003)(6486002)(4326008)(6916009)(966005)(107886003)(1076003)(54906003)(26005)(66946007)(36756003)(478600001)(86362001)(6666004)(956004)(8676002)(8936002)(2906002)(66556008)(2616005)(66476007)(6496006)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NCtMZE1oODJOVjlUVTJqL29mVFB6T01RVDNlTmt4YUJuMjJScUswYkFYN2xO?= =?utf-8?B?ZmNzTFFLaVJWOU9TeWt4OHdDdFdHeU42MXhCTlRWSGUzOTA5bTZYYkM0d3Qr?= =?utf-8?B?bXR6bkZYR3FXN3NuNlBVYkUxVTZNL2lEaDJKeE9MNzZQcTJJMWJ1ZituRDU4?= =?utf-8?B?OVlaMWZvM0x3dG5venR1cCttYTBrR0lwcG54NXVuT3Z4bHU4NUs3WjdSM3hT?= =?utf-8?B?TlNxVVc1ZVRXbXBRRDlNQ3BMR0g0U3VtT051ZWtJd1l0cld5QytEUmM5Mkph?= =?utf-8?B?WUxvRFE0d1NMNSsxSWk5b3hwclhFM3NmVnFuSFg2a05tSjIwMUdoZUNvczdp?= =?utf-8?B?bnAxdTQ3ZlpGek9BSHEzWWR5bU5UZUJPdXk1R0dCdjR4N1pZY2l0ay9DUEZL?= =?utf-8?B?NUthWVJKNGRkL1dKdFN4eFVubDNlWTIrck1kZDJlU1FrOW1Ib3BnazcwREE2?= =?utf-8?B?TTlCN2VTMVZoekY2dmFkOGRMdEdjdk5oSWRoek5BcThpTmRBQlIrR1REREJz?= =?utf-8?B?Z3g3Qk1KN2dWcEtodS9tNGVLODFOUXU5Y2dIRTlENUQ5U3FLbXc2ZXhNSXlv?= =?utf-8?B?cDBZZmZzeEhnWUdJd21HOForSEJZd2NmMEdaL0tzZmdvYjkvRzlVRE8rcStt?= =?utf-8?B?T0pQb3JmUGs0YXpyYjlNd0tLSVgzR2V5MXQ3OUNPWFZzUVc3am13eGZpcWNq?= =?utf-8?B?d1psWVZDQjczYVFzUW5FOUpYL0pNT0Nxb1BMQWE3SWNuUjYzUVNNZ0FJUWVu?= =?utf-8?B?ZW93YTFzRG9JK041eVZwcnlpNHRDdHpaRGlsQnUzaTBSdllLKzlBVUY1Q2J2?= =?utf-8?B?cE9Xd05GdEhTaTdXSXREMFpBd3VRVFhoZFRIeGpHM2t4WE1vbE5LWFN6YlFy?= =?utf-8?B?bDZoSDg3WC9JSXF2R2FnOW9iVVptMzNvOE1HN3Z0Z2prWTA2aWZlZllUQ1Nt?= =?utf-8?B?OW44QUIwUmtxWXM1U3AvYTZRQkxsTTlENmRsSDB0MmhMT3JOQ1JjOGMzdUc2?= =?utf-8?B?WERTK3FndW5jdUFoNTJ6MjVDZWJFbjJjWThWeFl2K3FFaDlwVVhma2h4WUZJ?= =?utf-8?B?UlRWMWcyVjV6UFRyWm1WSG5MTS9yR0IwVFExTXNtZDVGRGg5aFRVRkJnR1BD?= =?utf-8?B?NHBZZ0JhUEdqYUttVTM3YVIrTml4dmhEUWJraHJHb01QMXJTM2VDL1A1Rks3?= =?utf-8?B?YkJQWGM3SVFhVkk1MWM2aE1UaUNLRU4wTDZ2TmRScGhkd042RzZwdWxlS09G?= =?utf-8?B?TkZyTW92aXc1VDFtMGNxUWZPMDFhYTg0K282TXA3bUloL0x3eDh2S1FrSy9U?= =?utf-8?B?bm5Sd3lYSHFjTWJSaTdoRFBjcU1NNTF6ZlFiL2RkcUVtanM0NVJzREtuOUxY?= =?utf-8?B?bkZuVUMxUFBPSkcyUkNQV3JpRGRXWnc2QVZ4OFJxUVpFVHFsanhESXhLUzBL?= =?utf-8?B?M1FYS0J6Q091ODdENUliQVFQak5FbFIxYXBCYU8yYTN3aUM4SWRGeG4rWWVZ?= =?utf-8?B?ZnF0QkQvSGgvejVzK3cyRjhiVEg3VTgrRkZpYnNDNlBZaW10T3RnSjB0aHNy?= =?utf-8?B?L0NjWTgreHZWM1JMSDR3Y3JaUjFwNzJXc1V6dlM0N2VPbWNpVjVjdFdVclVR?= =?utf-8?B?c3lxbVFjc1hmZUlUbnprL1o3cm5JcWsrRE5jSGovdVF3a05wc1VCSU1DRmFy?= =?utf-8?B?Zzd2MHdOdjk2ZndqVFUydVdLTklzYTkrb0tpMTJ2eURFSDYxamVVVFJZVnpw?= =?utf-8?Q?uNlXCJ4pSvO1o6zOVbvDDd11iuJLeclc3+j35K7?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4aea52e6-7327-45ec-7fd2-08d8de1dea0d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 08:25:33.6450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: prbkIVCP0t5ZJeTmdpnNNylF3BSxr6fvM915FCYu7Eq470SdXNU1BoHWflUH8mjKCinxkYKwexV+Zp+wv3RMlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2971 X-OriginatorOrg: citrix.com The current build of the firmware relies on having 32bit compatible headers installed in order to build some of the 32bit firmware. Usually this can be solved by using the -ffreestanding compiler option which drops the usage of the system headers in favor of a private set of freestanding headers provided by the compiler itself that are not tied to libc. However such option is broken at least in the gcc compiler provided in Alpine Linux, as the system include path (ie: /usr/include) takes precedence over the gcc private include path: #include <...> search starts here: /usr/include /usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/include And the headers in /usr/include are exclusively 64bit. Since -ffreestanding is currently broken on at least that distro, and for resilience against future compilers also having the option broken provide a set of stand alone 32bit headers required for the firmware build. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Release-Acked-by: Ian Jackson --- Using -ffreestanding alone seems fragile, as it's broken on some distros. Compensate for this by providing our own set of stand alone headers for the firmware bits. Having the include paths wrongly sorted can easily make the system headers being picked up instead of the gcc ones, and then building can randomly fail because the system headers could be amd64 only (like the musl ones). I've also seen clang-9 on Debian with the following include paths: #include "..." search starts here: #include <...> search starts here: /usr/local/include /usr/lib/llvm-9/lib/clang/9.0.1/include /usr/include/x86_64-linux-gnu /usr/include Which also seems slightly dangerous as local comes before the compiler private path. IMO using -ffreestanding and our own set of stand alone headers is more resilient. Regarding the release risks, the main one would be breaking the build (as it's currently broken on Alpine). I think there's a very low risk of this change successfully producing a binary image that's broken, and hence with enough build testing it should be safe to merge. --- Changes since v2: - Add a __P64__ check to stdint.h. - Reword the comment in Rules.mk. --- tools/firmware/Rules.mk | 13 +++++++ tools/firmware/include/stdarg.h | 10 +++++ tools/firmware/include/stdbool.h | 9 +++++ tools/firmware/include/stddef.h | 10 +++++ tools/firmware/include/stdint.h | 39 +++++++++++++++++++ tools/firmware/rombios/32bit/rombios_compat.h | 4 +- 6 files changed, 82 insertions(+), 3 deletions(-) create mode 100644 tools/firmware/include/stdarg.h create mode 100644 tools/firmware/include/stdbool.h create mode 100644 tools/firmware/include/stddef.h create mode 100644 tools/firmware/include/stdint.h diff --git a/tools/firmware/Rules.mk b/tools/firmware/Rules.mk index dc372a86d8..9f78a7dec9 100644 --- a/tools/firmware/Rules.mk +++ b/tools/firmware/Rules.mk @@ -17,3 +17,16 @@ $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) # Extra CFLAGS suitable for an embedded type of environment. CFLAGS += -ffreestanding -msoft-float + +# Use our own set of stand alone headers to build firmware. +# +# Ideally using -ffreestanding should be enough, but that relies on the +# compiler having the right order for include paths (ie: compiler private +# headers before system ones) or the libc headers having proper arch-agnostic +# freestanding support. This is not the case in Alpine at least which searches +# system headers before compiler ones and has arch-specific libc headers. This +# has been reported upstream: +# https://gitlab.alpinelinux.org/alpine/aports/-/issues/12477 +# In the meantime (and for resilience against broken systems) use our own set +# of headers that provide what's needed for the firmware build. +CFLAGS += -nostdinc -I$(XEN_ROOT)/tools/firmware/include diff --git a/tools/firmware/include/stdarg.h b/tools/firmware/include/stdarg.h new file mode 100644 index 0000000000..c5e3761cd2 --- /dev/null +++ b/tools/firmware/include/stdarg.h @@ -0,0 +1,10 @@ +#ifndef _STDARG_H_ +#define _STDARG_H_ + +typedef __builtin_va_list va_list; +#define va_copy(dest, src) __builtin_va_copy(dest, src) +#define va_start(ap, last) __builtin_va_start(ap, last) +#define va_end(ap) __builtin_va_end(ap) +#define va_arg __builtin_va_arg + +#endif diff --git a/tools/firmware/include/stdbool.h b/tools/firmware/include/stdbool.h new file mode 100644 index 0000000000..0cf76b106c --- /dev/null +++ b/tools/firmware/include/stdbool.h @@ -0,0 +1,9 @@ +#ifndef _STDBOOL_H_ +#define _STDBOOL_H_ + +#define bool _Bool +#define true 1 +#define false 0 +#define __bool_true_false_are_defined 1 + +#endif diff --git a/tools/firmware/include/stddef.h b/tools/firmware/include/stddef.h new file mode 100644 index 0000000000..c7f974608a --- /dev/null +++ b/tools/firmware/include/stddef.h @@ -0,0 +1,10 @@ +#ifndef _STDDEF_H_ +#define _STDDEF_H_ + +typedef __SIZE_TYPE__ size_t; + +#define NULL ((void*)0) + +#define offsetof(t, m) __builtin_offsetof(t, m) + +#endif diff --git a/tools/firmware/include/stdint.h b/tools/firmware/include/stdint.h new file mode 100644 index 0000000000..16a0b6de19 --- /dev/null +++ b/tools/firmware/include/stdint.h @@ -0,0 +1,39 @@ +#ifndef _STDINT_H_ +#define _STDINT_H_ + +#if defined(__LP64__) || defined(__P64__) +#error "32bit only header" +#endif + +typedef unsigned char uint8_t; +typedef signed char int8_t; + +typedef unsigned short uint16_t; +typedef signed short int16_t; + +typedef unsigned int uint32_t; +typedef signed int int32_t; + +typedef unsigned long long uint64_t; +typedef signed long long int64_t; + +#define INT8_MIN (-0x7f-1) +#define INT16_MIN (-0x7fff-1) +#define INT32_MIN (-0x7fffffff-1) +#define INT64_MIN (-0x7fffffffffffffffll-1) + +#define INT8_MAX 0x7f +#define INT16_MAX 0x7fff +#define INT32_MAX 0x7fffffff +#define INT64_MAX 0x7fffffffffffffffll + +#define UINT8_MAX 0xff +#define UINT16_MAX 0xffff +#define UINT32_MAX 0xffffffffu +#define UINT64_MAX 0xffffffffffffffffull + +typedef uint32_t uintptr_t; + +#define UINTPTR_MAX UINT32_MAX + +#endif diff --git a/tools/firmware/rombios/32bit/rombios_compat.h b/tools/firmware/rombios/32bit/rombios_compat.h index 3fe7d67721..8ba4c17ffd 100644 --- a/tools/firmware/rombios/32bit/rombios_compat.h +++ b/tools/firmware/rombios/32bit/rombios_compat.h @@ -8,9 +8,7 @@ #define ADDR_FROM_SEG_OFF(seg, off) (void *)((((uint32_t)(seg)) << 4) + (off)) -typedef unsigned char uint8_t; -typedef unsigned short int uint16_t; -typedef unsigned int uint32_t; +#include typedef uint8_t Bit8u; typedef uint16_t Bit16u; -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 08:33:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 08:33:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92747.174792 (Exim 4.92) (envelope-from ) id 1lHMwy-0000ec-1Y; Wed, 03 Mar 2021 08:33:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92747.174792; Wed, 03 Mar 2021 08:33:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHMwx-0000eV-U3; Wed, 03 Mar 2021 08:33:43 +0000 Received: by outflank-mailman (input) for mailman id 92747; Wed, 03 Mar 2021 08:33:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHMww-0000eQ-JG for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 08:33:42 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cce3b294-f02a-4a30-803f-e90f070ce014; Wed, 03 Mar 2021 08:33:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cce3b294-f02a-4a30-803f-e90f070ce014 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614760421; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=jVp0Ab0d7U2rSkuKwKMSGLQvJ4fl1JtFSBlBGcboiYQ=; b=b1umHP1gIDXj63+qbRxeQNJLVzNfI4OfGfom47+z1dbIE5EigQJwXunV 3+ChyFJk6Za8/1alRDp1RrCr1bLKHrVFgvGMduEJsokAYK/2Nhs7dBh+Q 76bBH0YDNleh1EaY40GerujpH/pzJvFkso0UlAnmrZnyV0ehyJ2UWS8ff Q=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: UIghFGS46+V3BwI8nW8Sa5f3Rj8ORxCzRTSJsa2MsSVWw76JopwI+VWy/BZZNXuVEIVTjsCkqJ vV5BRI+7btqWQvfbnJH0igtKLtPNRp68frkDXYWypUmx0Ubq2hIIwbj7NMcoVZipPvE9/mrcnG e4tUsFpg8pITLwOepvyxkWl7gMzvYzM/rAgifylxz5zLi7TUZoxZPjXgIYTDmafn8BCVqk3OLQ A9y3/AXQxW598JwWhJAQJUUJdP07N1eCLMv74YzcHcpbIYQxNNgY1bVljwsSlFxHfi7f6WXCNA ky4= X-SBRS: 5.2 X-MesageID: 38600871 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,219,1610427600"; d="scan'208";a="38600871" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lQa6jiXsm9pRE9JVyqfRHn8h/Gzlr7svu1ugWSfGmYO9Yq7uF2QNzd+g4Ye0miNSzo/mfcXjaDkoaEvYYjbHzGbN80mZba5Qsn8N0MIwgg5Cq8TRHpXopa/w+LGQjiMSfpq5mgQvsHwCi/fSiF1LdQZT7wrLSPnZi6ZBLcKrYzrJG8PXdumda1kTZr0Koa+/nr6RuOjg5VDUiJPuavSyg0xrsFXowexb4acAXGqazW1ntrZOmvGYNz2gf+Q3h1kzyIkcuAAAd/V52eZYdPqSllj8Z6DR2gt2RtfCsi51NPlVVYUD8hqXmRx+rQA8Ep0DPKGsQZYzPtOn+0QKaKmwnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DA0FWokpjYq037HIImyhagSWwTj4PIDror+eKAb0YL4=; b=O+jDyfSt7lznZ7BjcbzGduKojIaw76RdQnNLLprmTTDoVmIYmSgZUu5f6ERvfPZipDLaPtWPgZ6sy6/yEjeVA/Tgq9kqaxlFnIdaMfisIsa0ELCmfkPggpwLjwFkitKQ/ma27wycismhnjYOoV70JcZ2gWIoN4fX1CNDawiCdIqFHDYTeFUiW+gqTgwOhK7uSPS8hqTpIliKEgzNeKqzjspbs//tywm6x+11hZSEAUpjaWcCyqgyEgDLVzC1RN1Yd4FFhQely6NWWQB0QdX8yfa3rrHpVnMc7fsSF/dKC6FsDLI2dFjH3VhSRBEOfEUR2XuLkRwKbdLT9eREZRdI2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DA0FWokpjYq037HIImyhagSWwTj4PIDror+eKAb0YL4=; b=E+lM79Y+io2jPYLR8YEp/l8aTfgGTxi7qSb2w669nws8CjC/gCL3XU9UF6K9NmBQyJX/zdCiT8Dq/HxCSLhrvctoHgvOapJfTddwH/beu/RoOrOmw87YSGzhtr8Yngkgg/C4eJ2Xv+H9m98wEPL0MTixJfX2ixw7d4ssieU6FZk= From: Roger Pau Monne To: CC: Roger Pau Monne , Doug Goldstein , Jan Beulich Subject: [PATCH] automation: add a build job with NR_CPUS == 1 Date: Wed, 3 Mar 2021 09:33:18 +0100 Message-ID: <20210303083318.9363-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0144.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::36) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ab36b66a-57ba-421c-4162-08d8de1f037d X-MS-TrafficTypeDiagnostic: DM6PR03MB5339: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SdCHODbJpPCCla81XGYiyEHjq7yUYRYWmizeCoxfxFSZObJ0t9y1h/1rDFpxxcH6mUPESfSuyvWt1ELOQGNcIz9icsdByP3JzwRy4qHghOGQEtbTSM58rG8D8WZt7xRxuZW5oHBeqYPFk2Soz0zNbzfA0E4ln53GvocZKBiX4RRH1iQOyYBV8Ed5VLi3gEmrmi/BBEcDS+X4gM3+MQ3z3izpxRlBgrmV8xOuDx4TpFlcamyMldq6924QEUnJixgnDBhVa5ovcIn2/FnxM7QUmJPEA9SLRmzYJxkt7O8zLhoLATCHOjoS5CJZU0dP5fBy+NRvIWqZe8tlHHMybQ6EQ1PNI4HrrGiDqz+kEth5UDrnhGzojU6ko6UrCXhYHk6th3bzuzp3+8BozQJZZgdVGz4jnTPV2FpysxvVBh+h0LBAyfdxhT89UxhJCUAA5bBH+taRcc4a4Fl95IvVDyA5xaTjXwSNIt5hB2HUnYAolp040CLJgPBAslRwXzcLhWFmJLefNXnVJNfpeSE/2CXlxg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(136003)(39850400004)(366004)(376002)(478600001)(6916009)(6496006)(956004)(5660300002)(316002)(54906003)(6486002)(83380400001)(4326008)(6666004)(26005)(66556008)(1076003)(8936002)(8676002)(66946007)(86362001)(186003)(2906002)(2616005)(66476007)(16526019)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ckM5MS9iTVN3WlZxK0NKbUgwMm51dkg0eHB0cWJ2azZ1S0krU0lVYUQvb1o1?= =?utf-8?B?Mnltb1ZiaDM4SUFoaHFCR0s2RnU0elI4UURXQ1hpRmpNeEsxU1U3UkpTdmNa?= =?utf-8?B?Qi9vN2IvcFYzelBSbDRmM0ZDMEN0VnRuZDQ1QjJkcTZpbG9tOElJTWwrQUZu?= =?utf-8?B?aFJjcjQvWjYxM21KczZxTVVUV3RHL0o1b2o1MXQxRUJvcjFBRi9oaGtDRW51?= =?utf-8?B?V0w4TVRUV1VnTVgzZEVtdVZ2Qk90OTZQRjh3WG1qRG5jT24yZ3p3TlRoaWVR?= =?utf-8?B?UzYvNlEwNmt6Yy9QKzhPSnZaQWpvZW5rV3pSNkw3QVdLaCtwU1pNOUd6SHpI?= =?utf-8?B?RWdKMEdIaXJoL3lhNWZSbXJnd0xUU0ptUzZxNkNmSUt5THV1MitGakRIZVlr?= =?utf-8?B?S2hyWThjNXFQWkIxV1dGRVc1Z3FadEhpZ3BtVU9DcmQrY2ZWa0VQUG5oQ25x?= =?utf-8?B?YXJuZEcvcWdlTUl2YkxDREYvYjZyeEFiUFFMN3ZyUFh1Z3NreThtYkdZa2hR?= =?utf-8?B?TDVWVzdxemw0L0VDY3ZHaU5LUjlKNkF0SzIreTJ4dmt3d0ZwZjNEM1Y1aEs3?= =?utf-8?B?VWlyN081MUVVRTIrangvSURpcW1oOTE4UEd0NnB3VW9lVDhLTlYxZFo3Rkl3?= =?utf-8?B?MjA4dHpLOVo2V084MW8xMHMxMEtWRlA5NGJyYk1CUjVkRk1KYVk4T3JyNzdH?= =?utf-8?B?alkzMG5MTnpPS093QVo5THA4aC9XS0FGSXhVUERCVlJFbENNNC9ZNFBlenRQ?= =?utf-8?B?cndvWmZvWGxZTDlUckRDWWFkSzFuV05rNldHN1dhTmJaTjdmQ3Flc3IvWFU1?= =?utf-8?B?bVJsbWQ0WUw4eGwxdXJnUE5rdlZwUDVpZmtrZ09Leml2bDNWOXhXc1IybGlp?= =?utf-8?B?ZzlocVc0czlzczZxTmNTbFFxZk9CU1lxZm9pdk04V1RHT1ZsekVrUEZleTNu?= =?utf-8?B?ZUpaRkpEWUJXUHFINWR2bC9ra3MyRVo0eVhkZ2lCRjV6S3hESW9oYlA0WnE1?= =?utf-8?B?bUlSOEVzbERnQ1I1S3dVOFJPZk9CT1gxU09TSmloZWlLSTNZOHMza0hmRVJ4?= =?utf-8?B?WWJxZG1XMzh6RzNwcnJ4K2h2dUV5YkQ5a1AvbUZCNStlak5WMDJzRjdRRHFk?= =?utf-8?B?cXF0ak1wSVJSSG5iRzM2ZS9SVkRTU0JYc3kxaEQrYXE5SFlvOFBZV1JmZWx4?= =?utf-8?B?MWJXY3htOStCY1FKcEdvbjZNZGxsbjh2ZVJFZGVjcFVvS3lWRnM3Rkh4aFBa?= =?utf-8?B?SWt0ajkvZytOLzhPZHBNSnJ4eEFEVnhVUWFsbncwcFFaU3pWRDFvVHBPQWV5?= =?utf-8?B?ZUEwaU5kK3FkMkI3dmVHZU94WkVEbVRNK2tIT0ZYQ1BIOVBrZENkWkVVSW1s?= =?utf-8?B?enBrOFRxSm9ZajNISWFPN29pTEV1NmY0RDRaT0ZFblJ3REQ2NG1rSHFTZE0r?= =?utf-8?B?eDZ2Uk5NTElEUGJQVUw3dEg0VUNGU3JZSnU0Zlo3eDIybGhEMUhVYytBQ2Ju?= =?utf-8?B?eXVyeEx4cWJqZXc1THdNeXlTV1BMc2VQdlhEWUtoWlhRY21TZkl4TkJRSUdS?= =?utf-8?B?eGFiMVFWR2tWSVdqMUZsTUZtVjNaQ2Q0SzMwMGpOSjZML3dLWGxJZlUvc3lN?= =?utf-8?B?RHlXTGxqSExKbnQ1NW5UMzAvaWg3NXdMUUh0b0NkR2E0RGJTMldRODdGeE9Q?= =?utf-8?B?NXZqWmdJNXhSNE0wUGx3T0RneEIwMURkWHdHWmlUbTd2K1VuYjd2TGt3Tml2?= =?utf-8?B?aTI3ZWFWVWVUOUQ0YVJiaHFpalJVc0paMmhTaW1Rb0hqazBLLyt6d2FSMm5D?= =?utf-8?B?MERBcEgxVklZVlcvdWcydz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: ab36b66a-57ba-421c-4162-08d8de1f037d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 08:33:25.8968 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B4HbA7rqr4BtB++G/tU3x702GP0ZRdnK0YbUkj/VdRk3evyYmgA0TgUvVDyU5s2Hc+zlSzhjHompz8XHoZSfSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5339 X-OriginatorOrg: citrix.com This requires adding some logic in the build script in order to be able to pass specific Xen Kconfig options. Setting any CONFIG_* environment variable when executing the build script will set such variable in the empty .config file before running the olddefconfig target. The .config file is also checked afterwards to assert the option has not been lost as part of the configuration process. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich --- Not sure whether there's some easiest way to force a config option to a set value from the command line. --- automation/gitlab-ci/build.yaml | 12 ++++++++++++ automation/scripts/build | 16 ++++++++++++++++ 2 files changed, 28 insertions(+) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index d00b8a5123..06d943de83 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -308,6 +308,18 @@ debian-unstable-gcc-debug-randconfig: CONTAINER: debian:unstable RANDCONFIG: y +debian-unstable-gcc-nrcpus1: + extends: .gcc-x86-64-build + variables: + CONTAINER: debian:unstable + CONFIG_NR_CPUS: 1 + +debian-unstable-gcc-debug-nrcpus1: + extends: .gcc-x86-64-build-debug + variables: + CONTAINER: debian:unstable + CONFIG_NR_CPUS: 1 + debian-unstable-32-clang: extends: .clang-x86-32-build variables: diff --git a/automation/scripts/build b/automation/scripts/build index 87e44bb940..4c331b6b57 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -11,6 +11,22 @@ cc-ver() # random config or default config if [[ "${RANDCONFIG}" == "y" ]]; then make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig +elif [[ "${!CONFIG_@}" != "" ]]; then + for config in "${!CONFIG_@}"; do + printf '%s=%s\n' "$config" "${!config}" >> xen/.config + done + make -j$(nproc) -C xen olddefconfig + for config in "${!CONFIG_@}"; do + if [[ "${!config}" != "n" ]]; then + option=$(printf '%s=%s' "$config" "${!config}") + else + option=$(printf '# %s is not set' "$config") + fi + if ! grep -q "^${option}$" xen/.config; then + echo "Failed to set ${config} in Kconfig" + exit 1; + fi + done else make -j$(nproc) -C xen defconfig fi -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 08:50:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 08:50:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92752.174803 (Exim 4.92) (envelope-from ) id 1lHNCi-0001vj-Gx; Wed, 03 Mar 2021 08:50:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92752.174803; Wed, 03 Mar 2021 08:50:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHNCi-0001vc-Ds; Wed, 03 Mar 2021 08:50:00 +0000 Received: by outflank-mailman (input) for mailman id 92752; Wed, 03 Mar 2021 08:49:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHNCh-0001vU-15; Wed, 03 Mar 2021 08:49:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHNCg-0003wH-No; Wed, 03 Mar 2021 08:49:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHNCg-0003fD-Dh; Wed, 03 Mar 2021 08:49:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHNCg-0000Eu-DB; Wed, 03 Mar 2021 08:49:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GDOAwTm73nx5BzEzVmtPs4SBBQ1E0KLJ0JGGlzGFM18=; b=jDiTEn2DLM4fS2Au09GenZMSUY nTuJ5zXya3IH19tvxILaVFymYtvocoIrgb+qerrWITieX9ioaUHc9bn+FwSKEUwYwP0d2bG7zFt27 aSBtPWqvcdzRyG2pV+3bhPFHIgLjWcfoFMVubEKivzZOFIWYUTPm822tIcG/bLu3Lf0o=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159808: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4834936549f788378918da8e9bc97df7dd3ee16d X-Osstest-Versions-That: xen=6b4d4dd38470c2293caddf0a5f7034bb832bb574 From: osstest service owner Date: Wed, 03 Mar 2021 08:49:58 +0000 flight 159808 xen-unstable real [real] flight 159813 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159808/ http://logs.test-lab.xenproject.org/osstest/logs/159813/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 159813-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159801 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159801 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159801 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159801 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159801 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159801 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159801 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159801 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159801 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159801 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159801 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 4834936549f788378918da8e9bc97df7dd3ee16d baseline version: xen 6b4d4dd38470c2293caddf0a5f7034bb832bb574 Last test of basis 159801 2021-03-02 06:04:18 Z 1 days Testing same since 159808 2021-03-02 21:07:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Julien Grall Tim Deegan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6b4d4dd384..4834936549 4834936549f788378918da8e9bc97df7dd3ee16d -> master From xen-devel-bounces@lists.xenproject.org Wed Mar 03 09:18:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 09:18:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92774.174843 (Exim 4.92) (envelope-from ) id 1lHNeC-00055d-CQ; Wed, 03 Mar 2021 09:18:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92774.174843; Wed, 03 Mar 2021 09:18:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHNeC-00055W-8Y; Wed, 03 Mar 2021 09:18:24 +0000 Received: by outflank-mailman (input) for mailman id 92774; Wed, 03 Mar 2021 09:18:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHNeA-00055R-OP for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:18:22 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 531c667e-f275-4b53-8f1c-533da5b00fb7; Wed, 03 Mar 2021 09:18:20 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-z2mwH7LGPUu9fIoPrLmpkg-1; Wed, 03 Mar 2021 04:18:18 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B5FA985B67D; Wed, 3 Mar 2021 09:18:07 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-154.ams2.redhat.com [10.36.112.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B36D7101E246; Wed, 3 Mar 2021 09:18:06 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 46C841800D4D; Wed, 3 Mar 2021 10:18:04 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 531c667e-f275-4b53-8f1c-533da5b00fb7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614763100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K8aDa2UBbBwRUbFTjc/tN0MwEJhUi+K8J5A19XMIEA8=; b=Zue1MYoIrp4Vrbr8G0gsU8UbTAD6sGgIdUH6JxGi7+eyxK7GLF17GtgK4bbAFjGq207TwV z+CZY+J88J4x/aJt7ptuGUz5bpa4L5GkUTHNSQYXw7nbmYmEFdRtaV4BARxyAg9Pyn1iYX BPBLaqpvdj85Jvf7W41sy2f1TnmwLUU= X-MC-Unique: z2mwH7LGPUu9fIoPrLmpkg-1 Date: Wed, 3 Mar 2021 10:18:04 +0100 From: Gerd Hoffmann To: Akihiko Odaki Cc: qemu Developers , xen-devel@lists.xenproject.org, "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Paul Durrant Subject: Re: [PATCH] virtio-gpu: Respect graphics update interval for EDID Message-ID: <20210303091804.5fm4esvd2iixbgew@sirius.home.kraxel.org> References: <20210221133414.7262-1-akihiko.odaki@gmail.com> <20210222105738.w2q6vp5pi4p6bx5m@sirius.home.kraxel.org> <20210224111540.xd5a6yszql6wln7m@sirius.home.kraxel.org> <20210225114626.dn7wevr3fozp5rcu@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Fri, Feb 26, 2021 at 01:47:38PM +0900, Akihiko Odaki wrote: > 2021年2月25日(木) 20:46 Gerd Hoffmann : > > > > Hi, > > > > > > Because of the wasted frames I'd like this to be an option you can > > > > enable when needed. For the majority of use cases this seems to be > > > > no problem ... > > > > > > I see blinks with GNOME on Wayland on Ubuntu 20.04 and virtio-gpu with > > > the EDID change included in this patch. > > > > /me looks closely at the patch again. > > > > So you update the edid dynamically, each time the refresh rate changes. > > Problem with that approach is software doesn't expect edid to change > > dynamically because on physical hardware it is static information about > > the connected monitor. > > > > So what the virtio-gpu guest driver does is emulate a monitor hotplug > > event to notify userspace. If you resize the qemu window on the host > > it'll look like the monitor with the old window size was unplugged and > > a new monitor with the new window size got plugged instead, so gnome > > shell goes adapt the display resolution to the new virtual monitor size. > > > > The blink you are seeing probably comes from gnome-shell processing the > > monitor hotplug event. > > > > We could try to skip generating a monitor hotplug event in case only the > > refresh rate did change. That would fix the blink, but it would also > > have the effect that nobody will notice the update. > > > > Bottom line: I think making the edid refresh rate configurable might be > > useful, but changing it dynamically most likely isn't. > > > > take care, > > Gerd > > The "hotplug" implementation is probably what other combinations of > devices and guests will do if they want to respond to the changes of > the refresh rate, or display mode in general. That makes telling the > dynamic refresh rate to guests infeasible. > > As you wrote, making the refresh rate configurable should be still > useful, and I think matching it to the backend physical display is > even better. GTK, the sole implementer of gfx_update_interval in my > patch reports the refresh rate of the physical display the window > resides in. It means the value may change when the physical display > changes its refresh rate, which should be rare if it does, or the > window moves to another physical display. Yes. Added debug printf, can see that it changes exactly twice for me, once to the default value and then to the real refresh rate. That rules out the hotplug event as source for the blinks. I'm wondering where they are coming from, and I can't reproduce them on my machine ... > consistent. The only inconsistency I see in my patch is that the > refresh rate change has no throttling while the window size change > has. I don't think it is problematic because it should be rare to move > the window across physical displays, but I can implement one if you > don't agree or know other cases the refresh rate frequently changes. I think it would be best to just add a new field for the refresh rate to QemuUIInfo. That avoids a new callback you also get the throttling for free ;) take care, Gerd From xen-devel-bounces@lists.xenproject.org Wed Mar 03 09:42:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 09:42:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92779.174854 (Exim 4.92) (envelope-from ) id 1lHO1C-00084B-CO; Wed, 03 Mar 2021 09:42:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92779.174854; Wed, 03 Mar 2021 09:42:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHO1C-000844-9R; Wed, 03 Mar 2021 09:42:10 +0000 Received: by outflank-mailman (input) for mailman id 92779; Wed, 03 Mar 2021 09:37:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHNwp-00079k-Fu for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:37:39 +0000 Received: from regular1.263xmail.com (unknown [211.150.70.199]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 66fa1b46-4540-4129-b0ea-d0bbcdc0e417; Wed, 03 Mar 2021 09:37:35 +0000 (UTC) Received: from localhost (unknown [192.168.167.16]) by regular1.263xmail.com (Postfix) with ESMTP id 13F5512AE; Wed, 3 Mar 2021 17:37:33 +0800 (CST) Received: from localhost.localdomain (unknown [124.126.19.250]) by smtp.263.net (postfix) whith ESMTP id P32470T140679588607744S1614764247776371_; Wed, 03 Mar 2021 17:37:33 +0800 (CST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66fa1b46-4540-4129-b0ea-d0bbcdc0e417 X-MAIL-GRAY:0 X-MAIL-DELIVERY:1 X-ADDR-CHECKED4:1 X-ANTISPAM-LEVEL:2 X-SKE-CHECKED:1 X-ABS-CHECKED:1 X-IP-DOMAINF:1 X-UNIQUE-TAG: X-RL-SENDER:maqianga@uniontech.com X-SENDER:maqianga@uniontech.com X-LOGIN-NAME:maqianga@uniontech.com X-FST-TO:boris.ostrovsky@oracle.com X-SENDER-IP:124.126.19.250 X-ATTACHMENT-NUM:0 X-System-Flag:0 From: maqiang To: boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, maqiang Subject: [PATCH] efi: x86/xen: fix -Wmissing-prototypes warning Date: Wed, 3 Mar 2021 17:36:51 +0800 Message-Id: <20210303093651.6801-1-maqianga@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We get 1 warning when building kernel with W=1: arch/x86/xen/efi.c:130:13: warning: no previous prototype for ‘xen_efi_init’ [-Wmissing-prototypes] void __init xen_efi_init(struct boot_params *boot_params) In fact, this function is declared as a static inline function in header file, but is not decorated as a static inline function in source file. So this patch marks this function with 'static inline'. Signed-off-by: maqiang --- arch/x86/xen/efi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/efi.c b/arch/x86/xen/efi.c index 7d7ffb9c826a..cf2e9ff3866d 100644 --- a/arch/x86/xen/efi.c +++ b/arch/x86/xen/efi.c @@ -127,7 +127,7 @@ static enum efi_secureboot_mode xen_efi_get_secureboot(void) return efi_secureboot_mode_enabled; } -void __init xen_efi_init(struct boot_params *boot_params) +static inline void __init xen_efi_init(struct boot_params *boot_params) { efi_system_table_t *efi_systab_xen; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 09:44:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 09:44:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92783.174867 (Exim 4.92) (envelope-from ) id 1lHO3S-0008Bp-RE; Wed, 03 Mar 2021 09:44:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92783.174867; Wed, 03 Mar 2021 09:44:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHO3S-0008Bi-Ne; Wed, 03 Mar 2021 09:44:30 +0000 Received: by outflank-mailman (input) for mailman id 92783; Wed, 03 Mar 2021 09:44:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHO3R-0008Bd-AH for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:44:29 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 06593551-3f10-4e5f-8606-65ad8265a4db; Wed, 03 Mar 2021 09:44:28 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 78B53AC54; Wed, 3 Mar 2021 09:44:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06593551-3f10-4e5f-8606-65ad8265a4db X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614764667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0eQBWFaY+hfpppgdoHy3KgIb/hWTcuY6Y9bjqFpaLwo=; b=adLmFtxyY5F+7eKFqKB0GbFKmAcNyqI0QJJRYIKEWQZS4QAtfd+Q8obA/TDjT5xuq0B0uR NuksD/023giBQbpHu3v0ocpllcdJXeyph1YclOfbwCLQ3K9x9jO09PaV/7EROjvcppwBLX 8qZEg8FTzfzntQUQvHnfXBU8Y9EJAyg= Subject: Re: [PATCH] efi: x86/xen: fix -Wmissing-prototypes warning To: maqiang , boris.ostrovsky@oracle.com, sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20210303093651.6801-1-maqianga@uniontech.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <153688d9-e4f3-fd93-5300-0732e0bddfab@suse.com> Date: Wed, 3 Mar 2021 10:44:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210303093651.6801-1-maqianga@uniontech.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gsB2zVgEDaHkEhFZK58kWsnSfLaBdI847" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gsB2zVgEDaHkEhFZK58kWsnSfLaBdI847 Content-Type: multipart/mixed; boundary="Lyzg1M5AwBmFicUVozbLG4FQnBANBQJ1L"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: maqiang , boris.ostrovsky@oracle.com, sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: <153688d9-e4f3-fd93-5300-0732e0bddfab@suse.com> Subject: Re: [PATCH] efi: x86/xen: fix -Wmissing-prototypes warning References: <20210303093651.6801-1-maqianga@uniontech.com> In-Reply-To: <20210303093651.6801-1-maqianga@uniontech.com> --Lyzg1M5AwBmFicUVozbLG4FQnBANBQJ1L Content-Type: multipart/mixed; boundary="------------D2FF094F8A371A408A393371" Content-Language: en-US This is a multi-part message in MIME format. --------------D2FF094F8A371A408A393371 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 03.03.21 10:36, maqiang wrote: > We get 1 warning when building kernel with W=3D1: > arch/x86/xen/efi.c:130:13: warning: > no previous prototype for =E2=80=98xen_efi_init=E2=80=99 [-Wmissing-p= rototypes] > void __init xen_efi_init(struct boot_params *boot_params) >=20 > In fact, this function is declared as a static inline function > in header file, but is not decorated as a static inline function > in source file. > So this patch marks this function with 'static inline'. >=20 > Signed-off-by: maqiang > --- > arch/x86/xen/efi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/x86/xen/efi.c b/arch/x86/xen/efi.c > index 7d7ffb9c826a..cf2e9ff3866d 100644 > --- a/arch/x86/xen/efi.c > +++ b/arch/x86/xen/efi.c > @@ -127,7 +127,7 @@ static enum efi_secureboot_mode xen_efi_get_secureb= oot(void) > return efi_secureboot_mode_enabled; > } > =20 > -void __init xen_efi_init(struct boot_params *boot_params) > +static inline void __init xen_efi_init(struct boot_params *boot_params= ) This is an absolutely wrong "fix". You are breaking a normal build as xen_efi_init() will no longer be callable from other sources. Juergen --------------D2FF094F8A371A408A393371 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------D2FF094F8A371A408A393371-- --Lyzg1M5AwBmFicUVozbLG4FQnBANBQJ1L-- --gsB2zVgEDaHkEhFZK58kWsnSfLaBdI847 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmA/WnoFAwAAAAAACgkQsN6d1ii/Ey91 Vgf8DXDzaxMx46XQ1TEMYyqiHJXzNnOqq5+0qjL5M+zF8ZOT03eembA9mIiz6IS2nX4bReouhgNk Fp5jAPuPro8ucxPJ1vXl0QL5CofTr7EE2o1yFuIR4lYE6dLVRHtCtoP0NbzgBCgaipunoNNLrcoe h1idRfOG+j30cdwl0KWf2QGLRirHeTbDW/Ytzu3YQ3fbs4Dh+371M2mKBwtQien7pT91BR+mvFVA gp58d913cqQCsIQ9pYAk06aFQ5Ex0U9C4FH60IoBWpp4um2RnKZh5yUfNIffCYp8sSa2ssPV8ztg Bhrgs95/xUFAnLVhl+wu04/q9KopwV+O1JN1zEEXLA== =wcBO -----END PGP SIGNATURE----- --gsB2zVgEDaHkEhFZK58kWsnSfLaBdI847-- From xen-devel-bounces@lists.xenproject.org Wed Mar 03 09:48:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 09:48:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92786.174878 (Exim 4.92) (envelope-from ) id 1lHO6x-0008M2-Ap; Wed, 03 Mar 2021 09:48:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92786.174878; Wed, 03 Mar 2021 09:48:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHO6x-0008Lv-7g; Wed, 03 Mar 2021 09:48:07 +0000 Received: by outflank-mailman (input) for mailman id 92786; Wed, 03 Mar 2021 09:48:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHO6w-0008Lq-D1 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:48:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHO6w-0004u1-AN for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:48:06 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHO6w-0004Cj-9B for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:48:06 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHO6s-0001hl-VT; Wed, 03 Mar 2021 09:48:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=esCPhHYB03o8fuy+NHk7sy/LvsUVkr6R1iBk4ZvqtJU=; b=PxhGoUx+1K3/V0roEoUTSmrglj E4cY4U3Y/A5QR3qxUKJGp8mCKoMYzLAQZHaNodoogxPn2FH+NheKopWgqBZfA/CKsLqIndLD91sH1 MbsMXUu9d4Dppe5huKPEF5Rw8/kEB8cnHF9FOdPo4czwNJP4rvjuS6ezdCfMMKojz3rI=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24639.23378.722148.653250@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 09:48:02 +0000 To: Nick Rosbrook Cc: xen-devel@lists.xenproject.org, george.dunlap@citrix.com, Nick Rosbrook , Wei Liu , Anthony PERARD Subject: Re: [RFC v2 0/7] add function support to IDL In-Reply-To: References: X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Nick Rosbrook writes ("[RFC v2 0/7] add function support to IDL"): > At a Xen Summit design session for the golang bindings (see [1]), we > agreed that it would be beneficial to expand the libxl IDL with function > support. In addition to benefiting libxl itself, this would allow other > language bindings to easily generate function wrappers. > > The first version of this RFC is quite old [1]. I did address comments > on the original RFC, but also expanded the scope a bit. As a way to > evaluate function support, I worked on using this addition to the IDL to > generate device add/remove/destroy functions, and removing the > corresponding macros in libxl_internal.h. However, I stopped short of > actually completing a build with this in place, as I thought it made > sense to get feedback on the idea before working on the next step. This is exciting! I hope to find time to look at it, but I'm the release manager for Xen 4.15 and that's taking most of my time right now. Regards, Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 03 09:48:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 09:48:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92789.174891 (Exim 4.92) (envelope-from ) id 1lHO7a-0008RQ-Jj; Wed, 03 Mar 2021 09:48:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92789.174891; Wed, 03 Mar 2021 09:48:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHO7a-0008RJ-Gk; Wed, 03 Mar 2021 09:48:46 +0000 Received: by outflank-mailman (input) for mailman id 92789; Wed, 03 Mar 2021 09:48:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHO7Y-0008RB-Tp for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:48:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHO7Y-0004uP-RX for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:48:44 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHO7Y-0004HR-Pz for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:48:44 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHO7V-0001i5-Gy; Wed, 03 Mar 2021 09:48:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=H2bZ7OlHlMOOf01rU4s4AbmOgMFAlrZyGw4FUyvdKgM=; b=grLLib3dt1jQ5HVd30EnYTm+pl jJksngJX8ol6YEqyEpD3EVvU6uboTZ/Xj3y78mFc/raOr4hmUK277rcXq0LhOuIIy7Hv3973UUb78 bZ1WS1qvy2kou6Cyu3Hfp9CJEDmMmP3E7HXFkR+4Q17QQbBSnxpniz7EcWAZOxoQLgek=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24639.23417.324037.570116@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 09:48:41 +0000 To: Roger Pau Monne Cc: , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 for-4.15 2/2] automation: enable rombios build on Alpine In-Reply-To: <20210303082514.8859-3-roger.pau@citrix.com> References: <20210303082514.8859-1-roger.pau@citrix.com> <20210303082514.8859-3-roger.pau@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monne writes ("[PATCH v2 for-4.15 2/2] automation: enable rombios build on Alpine"): > It's now safe to enable the build of rombios on Alpine systems, as > hvmloader already builds fine there. Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Wed Mar 03 09:56:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 09:56:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92793.174902 (Exim 4.92) (envelope-from ) id 1lHOEx-00016V-Cp; Wed, 03 Mar 2021 09:56:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92793.174902; Wed, 03 Mar 2021 09:56:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOEx-00016O-9t; Wed, 03 Mar 2021 09:56:23 +0000 Received: by outflank-mailman (input) for mailman id 92793; Wed, 03 Mar 2021 09:56:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOEv-00016F-Iy; Wed, 03 Mar 2021 09:56:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOEv-00051I-B2; Wed, 03 Mar 2021 09:56:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOEu-0006Xj-9a; Wed, 03 Mar 2021 09:56:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHOEu-0003pl-95; Wed, 03 Mar 2021 09:56:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1tS8efy4ykp6mLwQ/z0RMqwqu1PxBXBUmWaQK0M/tLk=; b=GQ6R8c3o4jDuDKVVPjdBQRqQKc 96/dHisHf+xboGJKAdOLIVVt7TteAxAQI2uCAfala+Fo9a6moLepmv8TCFQsubCwROIHUVEQCqhfE kkfzK0NQrX7CVMGKcGv3HX11KQAbIddLk3j5sYtop0sIBBHVpkpssHZLhivx6hMWL9Ts=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 159815: all pass - PUSHED X-Osstest-Versions-This: xen=4834936549f788378918da8e9bc97df7dd3ee16d X-Osstest-Versions-That: xen=c4441ab1f1d506a942002ccc55fdde2fe30ef626 From: osstest service owner Date: Wed, 03 Mar 2021 09:56:20 +0000 flight 159815 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/159815/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 4834936549f788378918da8e9bc97df7dd3ee16d baseline version: xen c4441ab1f1d506a942002ccc55fdde2fe30ef626 Last test of basis 159783 2021-02-28 09:19:28 Z 3 days Testing same since 159815 2021-03-03 09:19:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Ian Jackson Jan Beulich Julien Grall Tim Deegan jobs: coverity-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c4441ab1f1..4834936549 4834936549f788378918da8e9bc97df7dd3ee16d -> coverity-tested/smoke From xen-devel-bounces@lists.xenproject.org Wed Mar 03 09:59:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 09:59:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92800.174918 (Exim 4.92) (envelope-from ) id 1lHOHu-0001PZ-0B; Wed, 03 Mar 2021 09:59:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92800.174918; Wed, 03 Mar 2021 09:59:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOHt-0001PS-SF; Wed, 03 Mar 2021 09:59:25 +0000 Received: by outflank-mailman (input) for mailman id 92800; Wed, 03 Mar 2021 09:59:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOHs-0001PK-D5 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:59:24 +0000 Received: from forwardcorp1o.mail.yandex.net (unknown [2a02:6b8:0:1a2d::193]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a408df4d-be1d-4b82-bccb-2f2374b324dd; Wed, 03 Mar 2021 09:59:21 +0000 (UTC) Received: from vla1-fdfb804fb3f3.qloud-c.yandex.net (vla1-fdfb804fb3f3.qloud-c.yandex.net [IPv6:2a02:6b8:c0d:3199:0:640:fdfb:804f]) by forwardcorp1o.mail.yandex.net (Yandex) with ESMTP id 0F2642E159C; Wed, 3 Mar 2021 12:59:19 +0300 (MSK) Received: from vla5-d6d5ce7a4718.qloud-c.yandex.net (vla5-d6d5ce7a4718.qloud-c.yandex.net [2a02:6b8:c18:341e:0:640:d6d5:ce7a]) by vla1-fdfb804fb3f3.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id Yde6ClwwhQ-xIxSMHKG; Wed, 03 Mar 2021 12:59:18 +0300 Received: from dynamic-red3.dhcp.yndx.net (dynamic-red3.dhcp.yndx.net [2a02:6b8:0:107:880d:3c89:fcd8:ca75]) by vla5-d6d5ce7a4718.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id w0BjtEeJGw-xInKm6qD; Wed, 03 Mar 2021 12:59:18 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: a408df4d-be1d-4b82-bccb-2f2374b324dd Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1614765558; bh=13Oc7DM6MmyK0eAsUQqEpz94FAGI8joGzd7oyzYKa04=; h=Message-Id:Date:Subject:To:From:Cc; b=lsjkEAg8bmshp+24u6p+ZrCu8qCeGK3XkCx20rlU2rdTOCNRpN0T+Bhk+rM8P65Wh jXSOSAsrj8apT0LPvYY2kSBOK5KYY1i2vU+oP/Q5KDIKQZa79PIG8hu/77pmkQKOLv YDFOsosnNqsIV6QltOwlhvMJfxDgW76hpjost+7c= Authentication-Results: vla1-fdfb804fb3f3.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Alexey Kirillov To: Jason Wang , Markus Armbruster , Thomas Huth , Eric Blake Cc: Laurent Vivier , Samuel Thibault , "Michael S. Tsirkin" , Michael Roth , Paolo Bonzini , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Stefan Weil , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, yc-core@yandex-team.ru Subject: [PATCH v7 0/5] Introducing QMP query-netdev command Date: Wed, 3 Mar 2021 12:59:05 +0300 Message-Id: <20210303095910.78277-1-lekiravi@yandex-team.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series introduces a new QMP command "query-netdev" to get information about currently attached backend network devices (netdevs). Also, since the "info_str" field of "NetClientState" is now deprecated, we no longer use it for netdevs, only for NIC/hubports. The HMP command "info network" now also uses QAPI structure inside. Usage example: -> { "execute": "query-netdev" } <- { "return": [ { "listen": "127.0.0.1:90", "type": "socket", "peer-id": "hub0port1", "id": "__org.qemu.net1" }, { "script": "/etc/qemu-ifup", "downscript": "/etc/qemu-ifdown", "ifname": "tap0", "type": "tap", "peer-id": "net5", "vnet_hdr": true, "id": "tap0" }, { "ipv6": true, "ipv4": true, "host": "10.0.2.2", "ipv6-dns": "fec0::3", "ipv6-prefix": "fec0::", "net": "10.0.2.0/255.255.255.0", "ipv6-host": "fec0::2", "type": "user", "peer-id": "net0", "dns": "10.0.2.3", "hostfwd": [ { "str": "tcp::20004-:22" } ], "ipv6-prefixlen": 64, "id": "netdev0", "restrict": false } ] } v6->v7: - Use macroses QAPI_LIST_PREPEND and QAPI_LIST_APPEND for lists. - Reorder NetBackend entries in alphabetical order. v5->v6: - Add QAPI visitor to generate info_str replacement directly from NetdevInfo. - Make info_str dynamically allocated. - Make commit messages more meaningful. v4->v5: - Enable qtest of query-netdevs for AVR and RX archs. - Bump "Since" version in QAPI to 6.0. v3->v4: - Rename "query-netdevs" to "query-netdev". - Copy netdev drivers to new QAPI enum "NetBackend". v2->v3: - Remove NIC and hubports from query-netdevs. - Remove several fields from NetdevInfo since they are unnecessary. - Rename field @peer to @peer-id. - Add support of vhost-vdpa. - Keep "info_str" for NIC/hubports, but remove it for netdevs. v1->v2: - Rewrite HMP "info network" to get information from results of QMP command. - Remove obsolete field "info_str" from "NetClientState". Alexey Kirillov (5): qapi: net: Add query-netdev command tests: Add tests for query-netdev command net: Move NetClientState.info_str to dynamic allocations hmp: Use QAPI NetdevInfo in hmp_info_network net: Do not fill legacy info_str for backends hw/net/xen_nic.c | 5 +- include/net/net.h | 5 +- include/qapi/hmp-output-visitor.h | 30 +++++ net/l2tpv3.c | 8 +- net/net.c | 73 +++++++++-- net/netmap.c | 7 ++ net/slirp.c | 124 ++++++++++++++++++- net/socket.c | 92 ++++++++++---- net/tap-win32.c | 10 +- net/tap.c | 107 +++++++++++++++-- net/vde.c | 25 +++- net/vhost-user.c | 20 +++- net/vhost-vdpa.c | 15 ++- qapi/hmp-output-visitor.c | 193 ++++++++++++++++++++++++++++++ qapi/meson.build | 1 + qapi/net.json | 80 +++++++++++++ tests/qtest/meson.build | 3 + tests/qtest/test-query-netdev.c | 120 +++++++++++++++++++ 18 files changed, 856 insertions(+), 62 deletions(-) create mode 100644 include/qapi/hmp-output-visitor.h create mode 100644 qapi/hmp-output-visitor.c create mode 100644 tests/qtest/test-query-netdev.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 09:59:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 09:59:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92801.174930 (Exim 4.92) (envelope-from ) id 1lHOHy-0001RR-7a; Wed, 03 Mar 2021 09:59:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92801.174930; Wed, 03 Mar 2021 09:59:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOHy-0001RJ-4C; Wed, 03 Mar 2021 09:59:30 +0000 Received: by outflank-mailman (input) for mailman id 92801; Wed, 03 Mar 2021 09:59:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOHx-0001PK-CC for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:59:29 +0000 Received: from forwardcorp1o.mail.yandex.net (unknown [2a02:6b8:0:1a2d::193]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 03bc414c-1d27-4163-aa22-dc3a6fffd42b; Wed, 03 Mar 2021 09:59:24 +0000 (UTC) Received: from vla1-fdfb804fb3f3.qloud-c.yandex.net (vla1-fdfb804fb3f3.qloud-c.yandex.net [IPv6:2a02:6b8:c0d:3199:0:640:fdfb:804f]) by forwardcorp1o.mail.yandex.net (Yandex) with ESMTP id 778DD2E159D; Wed, 3 Mar 2021 12:59:23 +0300 (MSK) Received: from vla5-d6d5ce7a4718.qloud-c.yandex.net (vla5-d6d5ce7a4718.qloud-c.yandex.net [2a02:6b8:c18:341e:0:640:d6d5:ce7a]) by vla1-fdfb804fb3f3.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id 3wSchzD0qs-xNx0Kbbh; Wed, 03 Mar 2021 12:59:23 +0300 Received: from dynamic-red3.dhcp.yndx.net (dynamic-red3.dhcp.yndx.net [2a02:6b8:0:107:880d:3c89:fcd8:ca75]) by vla5-d6d5ce7a4718.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id w0BjtEeJGw-xNnKfM56; Wed, 03 Mar 2021 12:59:23 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 03bc414c-1d27-4163-aa22-dc3a6fffd42b Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1614765563; bh=TClaDRzxQB4h6SlKaYxQXAsUYr6qhA7dXnvUiqCeKqs=; h=In-Reply-To:Message-Id:References:Date:Subject:To:From:Cc; b=ECfrZx48XAaCBOEwbhj1JgVAsg8v9direbd7oanzOnhLwMqHZ+vl/7eqref57HsGc xmQgPHA8N5kCiM0H3sB8+XjNNdnPOYdsKcocuHkg0MI6kTNlPFbf4p0Bk36Uwr3TL9 Br3swnWxJY+Ny5qVkGUwSzkLtVnpKRnCZfxCu76Y= Authentication-Results: vla1-fdfb804fb3f3.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Alexey Kirillov To: Jason Wang , Markus Armbruster , Thomas Huth , Eric Blake Cc: Laurent Vivier , Samuel Thibault , "Michael S. Tsirkin" , Michael Roth , Paolo Bonzini , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Stefan Weil , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, yc-core@yandex-team.ru Subject: [PATCH v7 2/5] tests: Add tests for query-netdev command Date: Wed, 3 Mar 2021 12:59:07 +0300 Message-Id: <20210303095910.78277-3-lekiravi@yandex-team.ru> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303095910.78277-1-lekiravi@yandex-team.ru> References: <20210303095910.78277-1-lekiravi@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A simply qtest that checks for correct number of netdevs in the response of the query-netdev. Signed-off-by: Alexey Kirillov Acked-by: Thomas Huth --- tests/qtest/meson.build | 3 + tests/qtest/test-query-netdev.c | 120 ++++++++++++++++++++++++++++++++ 2 files changed, 123 insertions(+) create mode 100644 tests/qtest/test-query-netdev.c diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index ba6ecaed32..fefe3da3c3 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -17,6 +17,9 @@ qtests_generic = [ if config_host.has_key('CONFIG_MODULES') qtests_generic += [ 'modules-test' ] endif +if slirp.found() + qtests_generic += [ 'test-query-netdev' ] +endif qtests_pci = \ (config_all_devices.has_key('CONFIG_VGA') ? ['display-vga-test'] : []) + \ diff --git a/tests/qtest/test-query-netdev.c b/tests/qtest/test-query-netdev.c new file mode 100644 index 0000000000..1118537a9f --- /dev/null +++ b/tests/qtest/test-query-netdev.c @@ -0,0 +1,120 @@ +/* + * QTest testcase for the query-netdev + * + * Copyright Yandex N.V., 2019 + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + * + */ + +#include "qemu/osdep.h" + +#include "libqos/libqtest.h" +#include "qapi/qmp/qdict.h" +#include "qapi/qmp/qlist.h" + +/* + * Events can get in the way of responses we are actually waiting for. + */ +GCC_FMT_ATTR(2, 3) +static QObject *wait_command(QTestState *who, const char *command, ...) +{ + va_list ap; + QDict *response; + QObject *result; + + va_start(ap, command); + qtest_qmp_vsend(who, command, ap); + va_end(ap); + + response = qtest_qmp_receive(who); + + result = qdict_get(response, "return"); + g_assert(result); + qobject_ref(result); + qobject_unref(response); + + return result; +} + +static void qmp_query_netdev_no_error(QTestState *qts, size_t netdevs_count) +{ + QObject *resp; + QList *netdevs; + + resp = wait_command(qts, "{'execute': 'query-netdev'}"); + + netdevs = qobject_to(QList, resp); + g_assert(netdevs); + g_assert(qlist_size(netdevs) == netdevs_count); + + qobject_unref(resp); +} + +static void test_query_netdev(void) +{ + const char *arch = qtest_get_arch(); + QObject *resp; + QTestState *state; + + /* Choosing machine for platforms without default one */ + if (g_str_equal(arch, "arm") || + g_str_equal(arch, "aarch64")) { + state = qtest_init( + "-nodefaults " + "-M virt " + "-netdev user,id=slirp0"); + } else if (g_str_equal(arch, "tricore")) { + state = qtest_init( + "-nodefaults " + "-M tricore_testboard " + "-netdev user,id=slirp0"); + } else if (g_str_equal(arch, "avr")) { + state = qtest_init( + "-nodefaults " + "-M mega2560 " + "-netdev user,id=slirp0"); + } else if (g_str_equal(arch, "rx")) { + state = qtest_init( + "-nodefaults " + "-M gdbsim-r5f562n8 " + "-netdev user,id=slirp0"); + } else { + state = qtest_init( + "-nodefaults " + "-netdev user,id=slirp0"); + } + g_assert(state); + + qmp_query_netdev_no_error(state, 1); + + resp = wait_command(state, + "{'execute': 'netdev_add', 'arguments': {" + " 'id': 'slirp1'," + " 'type': 'user'}}"); + qobject_unref(resp); + + qmp_query_netdev_no_error(state, 2); + + resp = wait_command(state, + "{'execute': 'netdev_del', 'arguments': {" + " 'id': 'slirp1'}}"); + qobject_unref(resp); + + qmp_query_netdev_no_error(state, 1); + + qtest_quit(state); +} + +int main(int argc, char **argv) +{ + int ret = 0; + g_test_init(&argc, &argv, NULL); + + qtest_add_func("/net/qapi/query_netdev", test_query_netdev); + + ret = g_test_run(); + + return ret; +} -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 09:59:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 09:59:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92802.174942 (Exim 4.92) (envelope-from ) id 1lHOHz-0001TK-H9; Wed, 03 Mar 2021 09:59:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92802.174942; Wed, 03 Mar 2021 09:59:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOHz-0001TA-Cl; Wed, 03 Mar 2021 09:59:31 +0000 Received: by outflank-mailman (input) for mailman id 92802; Wed, 03 Mar 2021 09:59:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOHx-0001R5-G0 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:59:29 +0000 Received: from forwardcorp1j.mail.yandex.net (unknown [5.45.199.163]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2f29e6d3-31d5-43d7-832c-8ea62129d81e; Wed, 03 Mar 2021 09:59:26 +0000 (UTC) Received: from vla1-fdfb804fb3f3.qloud-c.yandex.net (vla1-fdfb804fb3f3.qloud-c.yandex.net [IPv6:2a02:6b8:c0d:3199:0:640:fdfb:804f]) by forwardcorp1j.mail.yandex.net (Yandex) with ESMTP id A151B2E1332; Wed, 3 Mar 2021 12:59:25 +0300 (MSK) Received: from vla5-d6d5ce7a4718.qloud-c.yandex.net (vla5-d6d5ce7a4718.qloud-c.yandex.net [2a02:6b8:c18:341e:0:640:d6d5:ce7a]) by vla1-fdfb804fb3f3.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id GQMvhqpKQa-xPx0b0C5; Wed, 03 Mar 2021 12:59:25 +0300 Received: from dynamic-red3.dhcp.yndx.net (dynamic-red3.dhcp.yndx.net [2a02:6b8:0:107:880d:3c89:fcd8:ca75]) by vla5-d6d5ce7a4718.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id w0BjtEeJGw-xPnKGPHs; Wed, 03 Mar 2021 12:59:25 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 2f29e6d3-31d5-43d7-832c-8ea62129d81e Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1614765565; bh=3xaewMFazOtEOhmAX9L2qiolW885HNMJSqIVvauR6mA=; h=In-Reply-To:Message-Id:References:Date:Subject:To:From:Cc; b=okXjIIdLuDRC0sj05f2wTTjT8cJk8tnMOgU5p0ti7aIkcP0nOlOqR6TVKP+5RyM9X L2v22GPHEObingBB1phSBHzQB1BD7iaplNBHszV/DHZheVwHgNdKSohOCyo+eVEjCU TMrOqZ0qZR6LDPZqODM0l76iY5Dl7dGuSJMV/nlo= Authentication-Results: vla1-fdfb804fb3f3.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Alexey Kirillov To: Jason Wang , Markus Armbruster , Thomas Huth , Eric Blake Cc: Laurent Vivier , Samuel Thibault , "Michael S. Tsirkin" , Michael Roth , Paolo Bonzini , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Stefan Weil , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, yc-core@yandex-team.ru Subject: [PATCH v7 4/5] hmp: Use QAPI NetdevInfo in hmp_info_network Date: Wed, 3 Mar 2021 12:59:09 +0300 Message-Id: <20210303095910.78277-5-lekiravi@yandex-team.ru> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303095910.78277-1-lekiravi@yandex-team.ru> References: <20210303095910.78277-1-lekiravi@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace usage of legacy field info_str of NetClientState for backend network devices with QAPI NetdevInfo stored_config that already used in QMP query-netdev. This change increases the detail of the "info network" output and takes a more general approach to composing the output. NIC and hubports still use legacy info_str field. Signed-off-by: Alexey Kirillov --- include/qapi/hmp-output-visitor.h | 30 +++++ net/net.c | 31 ++++- qapi/hmp-output-visitor.c | 193 ++++++++++++++++++++++++++++++ qapi/meson.build | 1 + 4 files changed, 254 insertions(+), 1 deletion(-) create mode 100644 include/qapi/hmp-output-visitor.h create mode 100644 qapi/hmp-output-visitor.c diff --git a/include/qapi/hmp-output-visitor.h b/include/qapi/hmp-output-visitor.h new file mode 100644 index 0000000000..541e4002e3 --- /dev/null +++ b/include/qapi/hmp-output-visitor.h @@ -0,0 +1,30 @@ +/* + * HMP string output Visitor + * + * Copyright Yandex N.V., 2021 + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + * + */ + +#ifndef HMP_OUTPUT_VISITOR_H +#define HMP_OUTPUT_VISITOR_H + +#include "qapi/visitor.h" + +typedef struct HMPOutputVisitor HMPOutputVisitor; + +/** + * Create a HMP string output visitor for @obj + * + * Flattens dicts/structures, only shows arrays borders. + * + * Errors are not expected to happen. + * + * The caller is responsible for freeing the visitor with + * visit_free(). + */ +Visitor *hmp_output_visitor_new(char **result); + +#endif diff --git a/net/net.c b/net/net.c index 88d70d0e4d..e186b44e9a 100644 --- a/net/net.c +++ b/net/net.c @@ -54,6 +54,7 @@ #include "sysemu/sysemu.h" #include "net/filter.h" #include "qapi/string-output-visitor.h" +#include "qapi/hmp-output-visitor.h" /* Net bridge is currently not supported for W32. */ #if !defined(_WIN32) @@ -1192,14 +1193,42 @@ static void netfilter_print_info(Monitor *mon, NetFilterState *nf) monitor_printf(mon, "\n"); } +static char *generate_info_str(NetClientState *nc) +{ + NetdevInfo *ni = nc->stored_config; + char *ret_out = NULL; + Visitor *v; + + /* Use legacy field info_str for NIC and hubports */ + if ((nc->info->type == NET_CLIENT_DRIVER_NIC) || + (nc->info->type == NET_CLIENT_DRIVER_HUBPORT)) { + return g_strdup(nc->info_str ? nc->info_str : ""); + } + + if (!ni) { + return g_malloc0(1); + } + + v = hmp_output_visitor_new(&ret_out); + if (visit_type_NetdevInfo(v, "", &ni, NULL)) { + visit_complete(v, &ret_out); + } + visit_free(v); + + return ret_out; +} + void print_net_client(Monitor *mon, NetClientState *nc) { NetFilterState *nf; + char *info_str = generate_info_str(nc); monitor_printf(mon, "%s: index=%d,type=%s,%s\n", nc->name, nc->queue_index, NetClientDriver_str(nc->info->type), - nc->info_str ? nc->info_str : ""); + info_str); + g_free(info_str); + if (!QTAILQ_EMPTY(&nc->filters)) { monitor_printf(mon, "filters:\n"); } diff --git a/qapi/hmp-output-visitor.c b/qapi/hmp-output-visitor.c new file mode 100644 index 0000000000..8036605f97 --- /dev/null +++ b/qapi/hmp-output-visitor.c @@ -0,0 +1,193 @@ +/* + * HMP string output Visitor + * + * Copyright Yandex N.V., 2021 + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + * + */ + +#include "qemu/osdep.h" +#include "qemu/cutils.h" +#include "qapi/hmp-output-visitor.h" +#include "qapi/visitor-impl.h" + +struct HMPOutputVisitor { + Visitor visitor; + char **result; + GString *buffer; + bool is_continue; +}; + +static HMPOutputVisitor *to_hov(Visitor *v) +{ + return container_of(v, HMPOutputVisitor, visitor); +} + +static void hmp_output_append_formatted(Visitor *v, const char *fmt, ...) +{ + HMPOutputVisitor *ov = to_hov(v); + va_list args; + + if (ov->is_continue) { + g_string_append(ov->buffer, ","); + } else { + ov->is_continue = true; + } + + va_start(args, fmt); + g_string_append_vprintf(ov->buffer, fmt, args); + va_end(args); +} + +static void hmp_output_skip_comma(Visitor *v) +{ + HMPOutputVisitor *ov = to_hov(v); + + ov->is_continue = false; +} + +static bool hmp_output_start_struct(Visitor *v, const char *name, + void **obj, size_t unused, Error **errp) +{ + return true; +} + +static void hmp_output_end_struct(Visitor *v, void **obj) {} + +static bool hmp_output_start_list(Visitor *v, const char *name, + GenericList **listp, size_t size, + Error **errp) +{ + hmp_output_append_formatted(v, "%s=[", name); + /* First element in array without comma before it */ + hmp_output_skip_comma(v); + + return true; +} + +static GenericList *hmp_output_next_list(Visitor *v, GenericList *tail, + size_t size) +{ + return tail->next; +} + +static void hmp_output_end_list(Visitor *v, void **obj) +{ + /* Don't need comma after last array element */ + hmp_output_skip_comma(v); + hmp_output_append_formatted(v, "]"); +} + +static bool hmp_output_type_int64(Visitor *v, const char *name, + int64_t *obj, Error **errp) +{ + hmp_output_append_formatted(v, "%s=%" PRId64, name, *obj); + + return true; +} + +static bool hmp_output_type_uint64(Visitor *v, const char *name, + uint64_t *obj, Error **errp) +{ + hmp_output_append_formatted(v, "%s=%" PRIu64, name, *obj); + + return true; +} + +static bool hmp_output_type_bool(Visitor *v, const char *name, bool *obj, + Error **errp) +{ + hmp_output_append_formatted(v, "%s=%s", name, *obj ? "true" : "false"); + + return true; +} + +static bool hmp_output_type_str(Visitor *v, const char *name, char **obj, + Error **errp) +{ + /* Skip already printed or unused fields */ + if (!*obj || g_str_equal(name, "id") || g_str_equal(name, "type")) { + return true; + } + + /* Do not print stub name for StringList elements */ + if (g_str_equal(name, "str")) { + hmp_output_append_formatted(v, "%s", *obj); + } else { + hmp_output_append_formatted(v, "%s=%s", name, *obj); + } + + return true; +} + +static bool hmp_output_type_number(Visitor *v, const char *name, + double *obj, Error **errp) +{ + hmp_output_append_formatted(v, "%s=%.17g", name, *obj); + + return true; +} + +/* TODO: remove this function? */ +static bool hmp_output_type_any(Visitor *v, const char *name, + QObject **obj, Error **errp) +{ + return true; +} + +static bool hmp_output_type_null(Visitor *v, const char *name, + QNull **obj, Error **errp) +{ + hmp_output_append_formatted(v, "%s=NULL", name); + + return true; +} + +static void hmp_output_complete(Visitor *v, void *opaque) +{ + HMPOutputVisitor *ov = to_hov(v); + + *ov->result = g_string_free(ov->buffer, false); + ov->buffer = NULL; +} + +static void hmp_output_free(Visitor *v) +{ + HMPOutputVisitor *ov = to_hov(v); + + if (ov->buffer) { + g_string_free(ov->buffer, true); + } + g_free(v); +} + +Visitor *hmp_output_visitor_new(char **result) +{ + HMPOutputVisitor *v; + + v = g_malloc0(sizeof(*v)); + + v->visitor.type = VISITOR_OUTPUT; + v->visitor.start_struct = hmp_output_start_struct; + v->visitor.end_struct = hmp_output_end_struct; + v->visitor.start_list = hmp_output_start_list; + v->visitor.next_list = hmp_output_next_list; + v->visitor.end_list = hmp_output_end_list; + v->visitor.type_int64 = hmp_output_type_int64; + v->visitor.type_uint64 = hmp_output_type_uint64; + v->visitor.type_bool = hmp_output_type_bool; + v->visitor.type_str = hmp_output_type_str; + v->visitor.type_number = hmp_output_type_number; + v->visitor.type_any = hmp_output_type_any; + v->visitor.type_null = hmp_output_type_null; + v->visitor.complete = hmp_output_complete; + v->visitor.free = hmp_output_free; + + v->result = result; + v->buffer = g_string_new(""); + v->is_continue = false; + + return &v->visitor; +} diff --git a/qapi/meson.build b/qapi/meson.build index 0652569bc4..94effbc052 100644 --- a/qapi/meson.build +++ b/qapi/meson.build @@ -8,6 +8,7 @@ util_ss.add(files( 'qobject-output-visitor.c', 'string-input-visitor.c', 'string-output-visitor.c', + 'hmp-output-visitor.c', )) if have_system or have_tools util_ss.add(files( -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 09:59:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 09:59:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92803.174954 (Exim 4.92) (envelope-from ) id 1lHOI3-0001XU-Qq; Wed, 03 Mar 2021 09:59:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92803.174954; Wed, 03 Mar 2021 09:59:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOI3-0001XN-MR; Wed, 03 Mar 2021 09:59:35 +0000 Received: by outflank-mailman (input) for mailman id 92803; Wed, 03 Mar 2021 09:59:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOI2-0001PK-CT for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:59:34 +0000 Received: from forwardcorp1j.mail.yandex.net (unknown [2a02:6b8:0:1619::183]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 36ffdee9-8546-4120-9c3d-0b615b9ab418; Wed, 03 Mar 2021 09:59:23 +0000 (UTC) Received: from vla1-fdfb804fb3f3.qloud-c.yandex.net (vla1-fdfb804fb3f3.qloud-c.yandex.net [IPv6:2a02:6b8:c0d:3199:0:640:fdfb:804f]) by forwardcorp1j.mail.yandex.net (Yandex) with ESMTP id 35B822E14DE; Wed, 3 Mar 2021 12:59:22 +0300 (MSK) Received: from vla5-d6d5ce7a4718.qloud-c.yandex.net (vla5-d6d5ce7a4718.qloud-c.yandex.net [2a02:6b8:c18:341e:0:640:d6d5:ce7a]) by vla1-fdfb804fb3f3.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id Xoqon3kIuD-xLxmSA11; Wed, 03 Mar 2021 12:59:22 +0300 Received: from dynamic-red3.dhcp.yndx.net (dynamic-red3.dhcp.yndx.net [2a02:6b8:0:107:880d:3c89:fcd8:ca75]) by vla5-d6d5ce7a4718.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id w0BjtEeJGw-xLnK0Pgv; Wed, 03 Mar 2021 12:59:21 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 36ffdee9-8546-4120-9c3d-0b615b9ab418 Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1614765562; bh=j7dzJEohXLsDUv+0KOvhWh+CMnUxLraIRiBhTUt7E4s=; h=In-Reply-To:Message-Id:References:Date:Subject:To:From:Cc; b=nLWCtqvEFSzGCD8ex/7yGZcEuZHdL9/HSHdO223dqhadmy6JqxmnugxsG3vUXe5eT Pb4mlGnMsjL/hhEhVvaPGFYTTUpCcxkZq0Dn8H3axRsncAE6eP4ORH93NgJUy16R4C aSXnVonDN7+HSR8cEJawAKvyZ+PlXRYHlFd0ZDCg= Authentication-Results: vla1-fdfb804fb3f3.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Alexey Kirillov To: Jason Wang , Markus Armbruster , Thomas Huth , Eric Blake Cc: Laurent Vivier , Samuel Thibault , "Michael S. Tsirkin" , Michael Roth , Paolo Bonzini , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Stefan Weil , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, yc-core@yandex-team.ru Subject: [PATCH v7 1/5] qapi: net: Add query-netdev command Date: Wed, 3 Mar 2021 12:59:06 +0300 Message-Id: <20210303095910.78277-2-lekiravi@yandex-team.ru> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303095910.78277-1-lekiravi@yandex-team.ru> References: <20210303095910.78277-1-lekiravi@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The query-netdev command is used to get the configuration of the current network device backends (netdevs). This is the QMP analog of the HMP command "info network" but only for netdevs (i.e. excluding NIC and hubports). The query-netdev command returns an array of objects of the NetdevInfo type, which are an extension of Netdev type. It means that response can be used for netdev-add after small modification. This can be useful for recreate the same netdev configuration. Information about the network device is filled in when it is created or modified and is available through the NetClientState->stored_config. Signed-off-by: Alexey Kirillov Acked-by: Markus Armbruster --- include/net/net.h | 3 ++ net/l2tpv3.c | 7 +++ net/net.c | 30 +++++++++++- net/netmap.c | 7 +++ net/slirp.c | 122 ++++++++++++++++++++++++++++++++++++++++++++++ net/socket.c | 71 +++++++++++++++++++++++++++ net/tap-win32.c | 9 ++++ net/tap.c | 103 ++++++++++++++++++++++++++++++++++++-- net/vde.c | 22 +++++++++ net/vhost-user.c | 18 +++++-- net/vhost-vdpa.c | 14 ++++++ qapi/net.json | 80 ++++++++++++++++++++++++++++++ 12 files changed, 477 insertions(+), 9 deletions(-) diff --git a/include/net/net.h b/include/net/net.h index 919facaad2..162fd3f1b5 100644 --- a/include/net/net.h +++ b/include/net/net.h @@ -5,6 +5,8 @@ #include "qapi/qapi-types-net.h" #include "net/queue.h" #include "hw/qdev-properties-system.h" +#include "qapi/clone-visitor.h" +#include "qapi/qapi-visit-net.h" #define MAC_FMT "%02X:%02X:%02X:%02X:%02X:%02X" #define MAC_ARG(x) ((uint8_t *)(x))[0], ((uint8_t *)(x))[1], \ @@ -93,6 +95,7 @@ struct NetClientState { char *model; char *name; char info_str[256]; + NetdevInfo *stored_config; unsigned receive_disabled : 1; NetClientDestructor *destructor; unsigned int queue_index; diff --git a/net/l2tpv3.c b/net/l2tpv3.c index e4d4218db6..8aa0a3e1a0 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -723,6 +723,13 @@ int net_init_l2tpv3(const Netdev *netdev, l2tpv3_read_poll(s, true); + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_L2TPV3; + + QAPI_CLONE_MEMBERS(NetdevL2TPv3Options, + &nc->stored_config->u.l2tpv3, l2tpv3); + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "l2tpv3: connected"); return 0; diff --git a/net/net.c b/net/net.c index fb7b7dcc25..1e50222a6e 100644 --- a/net/net.c +++ b/net/net.c @@ -35,7 +35,6 @@ #include "monitor/monitor.h" #include "qemu/help_option.h" #include "qapi/qapi-commands-net.h" -#include "qapi/qapi-visit-net.h" #include "qapi/qmp/qdict.h" #include "qapi/qmp/qerror.h" #include "qemu/error-report.h" @@ -352,6 +351,7 @@ static void qemu_free_net_client(NetClientState *nc) } g_free(nc->name); g_free(nc->model); + qapi_free_NetdevInfo(nc->stored_config); if (nc->destructor) { nc->destructor(nc); } @@ -1260,6 +1260,34 @@ RxFilterInfoList *qmp_query_rx_filter(bool has_name, const char *name, return filter_list; } +NetdevInfoList *qmp_query_netdev(Error **errp) +{ + NetdevInfoList *list = NULL; + NetClientState *nc; + + QTAILQ_FOREACH(nc, &net_clients, next) { + /* + * Only look at netdevs (backend network devices), not for each queue + * or NIC / hubport + */ + if (nc->stored_config) { + NetdevInfo *element = QAPI_CLONE(NetdevInfo, nc->stored_config); + + g_free(element->id); /* Need to dealloc empty id after clone */ + element->id = g_strdup(nc->name); + + element->has_peer_id = nc->peer != NULL; + if (element->has_peer_id) { + element->peer_id = g_strdup(nc->peer->name); + } + + QAPI_LIST_PREPEND(list, element); + } + } + + return list; +} + void hmp_info_network(Monitor *mon, const QDict *qdict) { NetClientState *nc, *peer; diff --git a/net/netmap.c b/net/netmap.c index 350f097f91..ad59d4ade4 100644 --- a/net/netmap.c +++ b/net/netmap.c @@ -427,6 +427,13 @@ int net_init_netmap(const Netdev *netdev, pstrcpy(s->ifname, sizeof(s->ifname), netmap_opts->ifname); netmap_read_poll(s, true); /* Initially only poll for reads. */ + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_NETMAP; + + QAPI_CLONE_MEMBERS(NetdevNetmapOptions, + &nc->stored_config->u.netmap, netmap_opts); + return 0; } diff --git a/net/slirp.c b/net/slirp.c index be914c0be0..6ab348b943 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -377,6 +377,9 @@ static int net_slirp_init(NetClientState *peer, const char *model, int shift; char *end; struct slirp_config_str *config; + NetdevUserOptions *stored; + StringList **stored_hostfwd; + StringList **stored_guestfwd; if (!ipv4 && (vnetwork || vhost || vnameserver)) { error_setg(errp, "IPv4 disabled but netmask/host/dns provided"); @@ -552,6 +555,115 @@ static int net_slirp_init(NetClientState *peer, const char *model, nc = qemu_new_net_client(&net_slirp_info, peer, model, name); + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_USER; + stored = &nc->stored_config->u.user; + + if (vhostname) { + stored->has_hostname = true; + stored->hostname = g_strdup(vhostname); + } + + stored->has_q_restrict = true; + stored->q_restrict = restricted; + + stored->has_ipv4 = true; + stored->ipv4 = ipv4; + + stored->has_ipv6 = true; + stored->ipv6 = ipv6; + + if (ipv4) { + uint8_t *net_bytes = (uint8_t *)&net; + uint8_t *mask_bytes = (uint8_t *)&mask; + + stored->has_net = true; + stored->net = g_strdup_printf("%d.%d.%d.%d/%d.%d.%d.%d", + net_bytes[0], net_bytes[1], + net_bytes[2], net_bytes[3], + mask_bytes[0], mask_bytes[1], + mask_bytes[2], mask_bytes[3]); + + stored->has_host = true; + stored->host = g_strdup(inet_ntoa(host)); + } + + if (tftp_export) { + stored->has_tftp = true; + stored->tftp = g_strdup(tftp_export); + } + + if (bootfile) { + stored->has_bootfile = true; + stored->bootfile = g_strdup(bootfile); + } + + if (vdhcp_start) { + stored->has_dhcpstart = true; + stored->dhcpstart = g_strdup(vdhcp_start); + } + + if (ipv4) { + stored->has_dns = true; + stored->dns = g_strdup(inet_ntoa(dns)); + } + + if (dnssearch) { + stored->has_dnssearch = true; + StringList **stored_list = &stored->dnssearch; + + for (int i = 0; dnssearch[i]; i++) { + String *element = g_new0(String, 1); + + element->str = g_strdup(dnssearch[i]); + QAPI_LIST_APPEND(stored_list, element); + } + } + + if (vdomainname) { + stored->has_domainname = true; + stored->domainname = g_strdup(vdomainname); + } + + if (ipv6) { + char addrstr[INET6_ADDRSTRLEN]; + const char *res; + + stored->has_ipv6_prefix = true; + stored->ipv6_prefix = g_strdup(vprefix6); + + stored->has_ipv6_prefixlen = true; + stored->ipv6_prefixlen = vprefix6_len; + + res = inet_ntop(AF_INET6, &ip6_host, + addrstr, sizeof(addrstr)); + + stored->has_ipv6_host = true; + stored->ipv6_host = g_strdup(res); + + res = inet_ntop(AF_INET6, &ip6_dns, + addrstr, sizeof(addrstr)); + + stored->has_ipv6_dns = true; + stored->ipv6_dns = g_strdup(res); + } + + if (smb_export) { + stored->has_smb = true; + stored->smb = g_strdup(smb_export); + } + + if (vsmbserver) { + stored->has_smbserver = true; + stored->smbserver = g_strdup(vsmbserver); + } + + if (tftp_server_name) { + stored->has_tftp_server_name = true; + stored->tftp_server_name = g_strdup(tftp_server_name); + } + snprintf(nc->info_str, sizeof(nc->info_str), "net=%s,restrict=%s", inet_ntoa(net), restricted ? "on" : "off"); @@ -581,15 +693,25 @@ static int net_slirp_init(NetClientState *peer, const char *model, s->poll_notifier.notify = net_slirp_poll_notify; main_loop_poll_add_notifier(&s->poll_notifier); + stored_hostfwd = &stored->hostfwd; + stored_guestfwd = &stored->guestfwd; + for (config = slirp_configs; config; config = config->next) { + String *element = g_new0(String, 1); + + element->str = g_strdup(config->str); if (config->flags & SLIRP_CFG_HOSTFWD) { if (slirp_hostfwd(s, config->str, errp) < 0) { goto error; } + stored->has_hostfwd = true; + QAPI_LIST_APPEND(stored_hostfwd, element); } else { if (slirp_guestfwd(s, config->str, errp) < 0) { goto error; } + stored->has_guestfwd = true; + QAPI_LIST_APPEND(stored_guestfwd, element); } } #ifndef _WIN32 diff --git a/net/socket.c b/net/socket.c index 15b410e8d8..1614523b82 100644 --- a/net/socket.c +++ b/net/socket.c @@ -342,6 +342,7 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer, NetSocketState *s; SocketAddress *sa; SocketAddressType sa_type; + NetdevSocketOptions *stored; sa = socket_local_address(fd, errp); if (!sa) { @@ -385,8 +386,19 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer, net_socket_rs_init(&s->rs, net_socket_rs_finalize, false); net_socket_read_poll(s, true); + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_SOCKET; + stored = &nc->stored_config->u.socket; + + stored->has_fd = true; + stored->fd = g_strdup_printf("%d", fd); + /* mcast: save bound address as dst */ if (is_connected && mcast != NULL) { + stored->has_mcast = true; + stored->mcast = g_strdup(mcast); + s->dgram_dst = saddr; snprintf(nc->info_str, sizeof(nc->info_str), "socket: fd=%d (cloned mcast=%s:%d)", @@ -428,6 +440,7 @@ static NetSocketState *net_socket_fd_init_stream(NetClientState *peer, { NetClientState *nc; NetSocketState *s; + NetdevSocketOptions *stored; nc = qemu_new_net_client(&net_socket_info, peer, model, name); @@ -447,6 +460,15 @@ static NetSocketState *net_socket_fd_init_stream(NetClientState *peer, } else { qemu_set_fd_handler(s->fd, NULL, net_socket_connect, s); } + + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_SOCKET; + stored = &nc->stored_config->u.socket; + + stored->has_fd = true; + stored->fd = g_strdup_printf("%d", fd); + return s; } @@ -483,6 +505,7 @@ static void net_socket_accept(void *opaque) struct sockaddr_in saddr; socklen_t len; int fd; + NetdevSocketOptions *stored; for(;;) { len = sizeof(saddr); @@ -498,6 +521,13 @@ static void net_socket_accept(void *opaque) s->fd = fd; s->nc.link_down = false; net_socket_connect(s); + + /* Store additional startup parameters (extend net_socket_listen_init) */ + stored = &s->nc.stored_config->u.socket; + + stored->has_fd = true; + stored->fd = g_strdup_printf("%d", fd); + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "socket: connection from %s:%d", inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); @@ -513,6 +543,7 @@ static int net_socket_listen_init(NetClientState *peer, NetSocketState *s; struct sockaddr_in saddr; int fd, ret; + NetdevSocketOptions *stored; if (parse_host_port(&saddr, host_str, errp) < 0) { return -1; @@ -549,6 +580,15 @@ static int net_socket_listen_init(NetClientState *peer, net_socket_rs_init(&s->rs, net_socket_rs_finalize, false); qemu_set_fd_handler(s->listen_fd, net_socket_accept, NULL, s); + + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_SOCKET; + stored = &nc->stored_config->u.socket; + + stored->has_listen = true; + stored->listen = g_strdup(host_str); + return 0; } @@ -561,6 +601,7 @@ static int net_socket_connect_init(NetClientState *peer, NetSocketState *s; int fd, connected, ret; struct sockaddr_in saddr; + NetdevSocketOptions *stored; if (parse_host_port(&saddr, host_str, errp) < 0) { return -1; @@ -598,6 +639,12 @@ static int net_socket_connect_init(NetClientState *peer, return -1; } + /* Store additional startup parameters (extend net_socket_fd_init) */ + stored = &s->nc.stored_config->u.socket; + + stored->has_connect = true; + stored->connect = g_strdup(host_str); + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "socket: connect to %s:%d", inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); @@ -615,6 +662,7 @@ static int net_socket_mcast_init(NetClientState *peer, int fd; struct sockaddr_in saddr; struct in_addr localaddr, *param_localaddr; + NetdevSocketOptions *stored; if (parse_host_port(&saddr, host_str, errp) < 0) { return -1; @@ -643,6 +691,19 @@ static int net_socket_mcast_init(NetClientState *peer, s->dgram_dst = saddr; + /* Store additional startup parameters (extend net_socket_fd_init) */ + stored = &s->nc.stored_config->u.socket; + + if (!stored->has_mcast) { + stored->has_mcast = true; + stored->mcast = g_strdup(host_str); + } + + if (localaddr_str) { + stored->has_localaddr = true; + stored->localaddr = g_strdup(localaddr_str); + } + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "socket: mcast=%s:%d", inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); @@ -660,6 +721,7 @@ static int net_socket_udp_init(NetClientState *peer, NetSocketState *s; int fd, ret; struct sockaddr_in laddr, raddr; + NetdevSocketOptions *stored; if (parse_host_port(&laddr, lhost, errp) < 0) { return -1; @@ -698,6 +760,15 @@ static int net_socket_udp_init(NetClientState *peer, s->dgram_dst = raddr; + /* Store additional startup parameters (extend net_socket_fd_init) */ + stored = &s->nc.stored_config->u.socket; + + stored->has_localaddr = true; + stored->localaddr = g_strdup(lhost); + + stored->has_udp = true; + stored->udp = g_strdup(rhost); + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "socket: udp=%s:%d", inet_ntoa(raddr.sin_addr), ntohs(raddr.sin_port)); diff --git a/net/tap-win32.c b/net/tap-win32.c index 2b5dcda36e..b60933bd1a 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -768,6 +768,7 @@ static int tap_win32_init(NetClientState *peer, const char *model, NetClientState *nc; TAPState *s; tap_win32_overlapped_t *handle; + NetdevTapOptions *stored; if (tap_win32_open(&handle, ifname) < 0) { printf("tap: Could not open '%s'\n", ifname); @@ -778,6 +779,14 @@ static int tap_win32_init(NetClientState *peer, const char *model, s = DO_UPCAST(TAPState, nc, nc); + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_TAP; + stored = &nc->stored_config->u.tap; + + stored->has_ifname = true; + stored->ifname = g_strdup(ifname); + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "tap: ifname=%s", ifname); diff --git a/net/tap.c b/net/tap.c index b7512853f4..8041245ba7 100644 --- a/net/tap.c +++ b/net/tap.c @@ -590,6 +590,7 @@ int net_init_bridge(const Netdev *netdev, const char *name, const char *helper, *br; TAPState *s; int fd, vnet_hdr; + NetdevBridgeOptions *stored; assert(netdev->type == NET_CLIENT_DRIVER_BRIDGE); bridge = &netdev->u.bridge; @@ -609,6 +610,21 @@ int net_init_bridge(const Netdev *netdev, const char *name, } s = net_tap_fd_init(peer, "bridge", name, fd, vnet_hdr); + /* Store startup parameters */ + s->nc.stored_config = g_new0(NetdevInfo, 1); + s->nc.stored_config->type = NET_BACKEND_BRIDGE; + stored = &s->nc.stored_config->u.bridge; + + if (br) { + stored->has_br = true; + stored->br = g_strdup(br); + } + + if (helper) { + stored->has_helper = true; + stored->helper = g_strdup(helper); + } + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "helper=%s,br=%s", helper, br); @@ -656,11 +672,13 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, const char *model, const char *name, const char *ifname, const char *script, const char *downscript, const char *vhostfdname, - int vnet_hdr, int fd, Error **errp) + int vnet_hdr, int fd, NetdevInfo **common_stored, + Error **errp) { Error *err = NULL; TAPState *s = net_tap_fd_init(peer, model, name, fd, vnet_hdr); int vhostfd; + NetdevTapOptions *stored; tap_set_sndbuf(s->fd, tap, &err); if (err) { @@ -668,12 +686,65 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, return; } + /* Store startup parameters */ + if (!*common_stored) { + *common_stored = g_new0(NetdevInfo, 1); + (*common_stored)->type = NET_BACKEND_TAP; + s->nc.stored_config = *common_stored; + } + stored = &(*common_stored)->u.tap; + + if (tap->has_sndbuf && !stored->has_sndbuf) { + stored->has_sndbuf = true; + stored->sndbuf = tap->sndbuf; + } + + if (vnet_hdr && !stored->has_vnet_hdr) { + stored->has_vnet_hdr = true; + stored->vnet_hdr = true; + } + if (tap->has_fd || tap->has_fds) { + if (!stored->has_fds) { + stored->has_fds = true; + stored->fds = g_strdup_printf("%d", fd); + } else { + char *tmp_s = stored->fds; + stored->fds = g_strdup_printf("%s:%d", stored->fds, fd); + g_free(tmp_s); + } + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "fd=%d", fd); } else if (tap->has_helper) { + if (!stored->has_helper) { + stored->has_helper = true; + stored->helper = g_strdup(tap->helper); + } + + if (!stored->has_br) { + stored->has_br = true; + stored->br = tap->has_br ? g_strdup(tap->br) : + g_strdup(DEFAULT_BRIDGE_INTERFACE); + } + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "helper=%s", tap->helper); } else { + if (ifname && !stored->has_ifname) { + stored->has_ifname = true; + stored->ifname = g_strdup(ifname); + } + + if (script && !stored->has_script) { + stored->has_script = true; + stored->script = g_strdup(script); + } + + if (downscript && !stored->has_downscript) { + stored->has_downscript = true; + stored->downscript = g_strdup(downscript); + } + snprintf(s->nc.info_str, sizeof(s->nc.info_str), "ifname=%s,script=%s,downscript=%s", ifname, script, downscript); @@ -689,9 +760,20 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, vhostfdname || (tap->has_vhostforce && tap->vhostforce)) { VhostNetOptions options; + stored->has_vhost = true; + stored->vhost = true; + + if (tap->has_vhostforce && tap->vhostforce) { + stored->has_vhostforce = true; + stored->vhostforce = true; + } + options.backend_type = VHOST_BACKEND_TYPE_KERNEL; options.net_backend = &s->nc; if (tap->has_poll_us) { + stored->has_poll_us = true; + stored->poll_us = tap->poll_us; + options.busyloop_timeout = tap->poll_us; } else { options.busyloop_timeout = 0; @@ -731,6 +813,15 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, } options.opaque = (void *)(uintptr_t)vhostfd; + if (!stored->has_vhostfds) { + stored->has_vhostfds = true; + stored->vhostfds = g_strdup_printf("%d", vhostfd); + } else { + char *tmp_s = stored->vhostfds; + stored->vhostfds = g_strdup_printf("%s:%d", stored->fds, vhostfd); + g_free(tmp_s); + } + s->vhost_net = vhost_net_init(&options); if (!s->vhost_net) { if (tap->has_vhostforce && tap->vhostforce) { @@ -783,6 +874,7 @@ int net_init_tap(const Netdev *netdev, const char *name, const char *vhostfdname; char ifname[128]; int ret = 0; + NetdevInfo *common_stored = NULL; /* will store configuration */ assert(netdev->type == NET_CLIENT_DRIVER_TAP); tap = &netdev->u.tap; @@ -829,7 +921,7 @@ int net_init_tap(const Netdev *netdev, const char *name, net_init_tap_one(tap, peer, "tap", name, NULL, script, downscript, - vhostfdname, vnet_hdr, fd, &err); + vhostfdname, vnet_hdr, fd, &common_stored, &err); if (err) { error_propagate(errp, err); close(fd); @@ -892,7 +984,7 @@ int net_init_tap(const Netdev *netdev, const char *name, net_init_tap_one(tap, peer, "tap", name, ifname, script, downscript, tap->has_vhostfds ? vhost_fds[i] : NULL, - vnet_hdr, fd, &err); + vnet_hdr, fd, &common_stored, &err); if (err) { error_propagate(errp, err); ret = -1; @@ -935,7 +1027,7 @@ free_fail: net_init_tap_one(tap, peer, "bridge", name, ifname, script, downscript, vhostfdname, - vnet_hdr, fd, &err); + vnet_hdr, fd, &common_stored, &err); if (err) { error_propagate(errp, err); close(fd); @@ -981,7 +1073,8 @@ free_fail: net_init_tap_one(tap, peer, "tap", name, ifname, i >= 1 ? "no" : script, i >= 1 ? "no" : downscript, - vhostfdname, vnet_hdr, fd, &err); + vhostfdname, vnet_hdr, fd, + &common_stored, &err); if (err) { error_propagate(errp, err); close(fd); diff --git a/net/vde.c b/net/vde.c index 99189cccb6..b0b8800571 100644 --- a/net/vde.c +++ b/net/vde.c @@ -84,6 +84,7 @@ static int net_vde_init(NetClientState *peer, const char *model, VDECONN *vde; char *init_group = (char *)group; char *init_sock = (char *)sock; + NetdevVdeOptions *stored; struct vde_open_args args = { .port = port, @@ -108,6 +109,27 @@ static int net_vde_init(NetClientState *peer, const char *model, qemu_set_fd_handler(vde_datafd(s->vde), vde_to_qemu, NULL, s); + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_VDE; + stored = &nc->stored_config->u.vde; + + if (sock) { + stored->has_sock = true; + stored->sock = g_strdup(sock); + } + + stored->has_port = true; + stored->port = port; + + if (group) { + stored->has_group = true; + stored->group = g_strdup(group); + } + + stored->has_mode = true; + stored->mode = mode; + return 0; } diff --git a/net/vhost-user.c b/net/vhost-user.c index ffbd94d944..5b7056be25 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -311,14 +311,15 @@ static void net_vhost_user_event(void *opaque, QEMUChrEvent event) } static int net_vhost_user_init(NetClientState *peer, const char *device, - const char *name, Chardev *chr, - int queues) + const char *name, const char *chardev, + Chardev *chr, int queues) { Error *err = NULL; NetClientState *nc, *nc0 = NULL; NetVhostUserState *s = NULL; VhostUserState *user; int i; + NetdevVhostUserOptions *stored; assert(name); assert(queues > 0); @@ -355,6 +356,16 @@ static int net_vhost_user_init(NetClientState *peer, const char *device, assert(s->vhost_net); + /* Store startup parameters */ + nc0->stored_config = g_new0(NetdevInfo, 1); + nc0->stored_config->type = NET_BACKEND_VHOST_USER; + stored = &nc0->stored_config->u.vhost_user; + + stored->chardev = g_strdup(chardev); + + stored->has_queues = true; + stored->queues = queues; + return 0; err: @@ -446,5 +457,6 @@ int net_init_vhost_user(const Netdev *netdev, const char *name, return -1; } - return net_vhost_user_init(peer, "vhost_user", name, chr, queues); + return net_vhost_user_init(peer, "vhost_user", name, + vhost_user_opts->chardev, chr, queues); } diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index fe659ec9e2..8c27ea0142 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -184,8 +184,22 @@ static int net_vhost_vdpa_init(NetClientState *peer, const char *device, VhostVDPAState *s; int vdpa_device_fd = -1; int ret = 0; + NetdevVhostVDPAOptions *stored; + assert(name); nc = qemu_new_net_client(&net_vhost_vdpa_info, peer, device, name); + + /* Store startup parameters */ + nc->stored_config = g_new0(NetdevInfo, 1); + nc->stored_config->type = NET_BACKEND_VHOST_VDPA; + stored = &nc->stored_config->u.vhost_vdpa; + + stored->has_vhostdev = true; + stored->vhostdev = g_strdup(vhostdev); + + stored->has_queues = true; + stored->queues = 1; /* TODO: change when support multiqueue */ + snprintf(nc->info_str, sizeof(nc->info_str), TYPE_VHOST_VDPA); nc->queue_index = 0; s = DO_UPCAST(VhostVDPAState, nc, nc); diff --git a/qapi/net.json b/qapi/net.json index c31748c87f..87361ebd9a 100644 --- a/qapi/net.json +++ b/qapi/net.json @@ -714,3 +714,83 @@ ## { 'event': 'FAILOVER_NEGOTIATED', 'data': {'device-id': 'str'} } + +## +# @NetBackend: +# +# Available netdev backend drivers. +# +# Since: 6.0 +## +{ 'enum': 'NetBackend', + 'data': [ 'bridge', 'l2tpv3', 'netmap', 'socket', 'tap', 'user', 'vde', + 'vhost-user', 'vhost-vdpa' ] } + +## +# @NetdevInfo: +# +# Configuration of a network backend device (netdev). +# +# @id: Device identifier. +# +# @type: Specify the driver used for interpreting remaining arguments. +# +# @peer-id: The connected frontend network device name (absent if no frontend +# is connected). +# +# Since: 6.0 +## +{ 'union': 'NetdevInfo', + 'base': { 'id': 'str', + 'type': 'NetBackend', + '*peer-id': 'str' }, + 'discriminator': 'type', + 'data': { + 'bridge': 'NetdevBridgeOptions', + 'l2tpv3': 'NetdevL2TPv3Options', + 'netmap': 'NetdevNetmapOptions', + 'socket': 'NetdevSocketOptions', + 'tap': 'NetdevTapOptions', + 'user': 'NetdevUserOptions', + 'vde': 'NetdevVdeOptions', + 'vhost-user': 'NetdevVhostUserOptions', + 'vhost-vdpa': 'NetdevVhostVDPAOptions' } } + +## +# @query-netdev: +# +# Get a list of @NetdevInfo for all virtual network backend devices (netdevs). +# +# Returns: a list of @NetdevInfo describing each netdev. +# +# Since: 6.0 +# +# Example: +# +# -> { "execute": "query-netdev" } +# <- { "return": [ +# { +# "ipv6": true, +# "ipv4": true, +# "host": "10.0.2.2", +# "ipv6-dns": "fec0::3", +# "ipv6-prefix": "fec0::", +# "net": "10.0.2.0/255.255.255.0", +# "ipv6-host": "fec0::2", +# "type": "user", +# "peer-id": "net0", +# "dns": "10.0.2.3", +# "hostfwd": [ +# { +# "str": "tcp::20004-:22" +# } +# ], +# "ipv6-prefixlen": 64, +# "id": "netdev0", +# "restrict": false +# } +# ] +# } +# +## +{ 'command': 'query-netdev', 'returns': ['NetdevInfo'] } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 09:59:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 09:59:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92804.174965 (Exim 4.92) (envelope-from ) id 1lHOI8-0001cj-7H; Wed, 03 Mar 2021 09:59:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92804.174965; Wed, 03 Mar 2021 09:59:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOI8-0001ca-3x; Wed, 03 Mar 2021 09:59:40 +0000 Received: by outflank-mailman (input) for mailman id 92804; Wed, 03 Mar 2021 09:59:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOI7-0001PK-Cg for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:59:39 +0000 Received: from forwardcorp1o.mail.yandex.net (unknown [2a02:6b8:0:1a2d::193]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9d3cd9ae-3831-454b-94ca-afeb03441a89; Wed, 03 Mar 2021 09:59:25 +0000 (UTC) Received: from vla1-fdfb804fb3f3.qloud-c.yandex.net (vla1-fdfb804fb3f3.qloud-c.yandex.net [IPv6:2a02:6b8:c0d:3199:0:640:fdfb:804f]) by forwardcorp1o.mail.yandex.net (Yandex) with ESMTP id 990FB2E15BD; Wed, 3 Mar 2021 12:59:24 +0300 (MSK) Received: from vla5-d6d5ce7a4718.qloud-c.yandex.net (vla5-d6d5ce7a4718.qloud-c.yandex.net [2a02:6b8:c18:341e:0:640:d6d5:ce7a]) by vla1-fdfb804fb3f3.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id U464HtyxDo-xOxSQLKe; Wed, 03 Mar 2021 12:59:24 +0300 Received: from dynamic-red3.dhcp.yndx.net (dynamic-red3.dhcp.yndx.net [2a02:6b8:0:107:880d:3c89:fcd8:ca75]) by vla5-d6d5ce7a4718.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id w0BjtEeJGw-xOnKhJsv; Wed, 03 Mar 2021 12:59:24 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 9d3cd9ae-3831-454b-94ca-afeb03441a89 Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1614765564; bh=tKLqAXYmQttCAaAlU3fBYVvZyqpt/IoO0XRXm/czWeY=; h=In-Reply-To:Message-Id:References:Date:Subject:To:From:Cc; b=AkZnkvJFo+ECjj66JzKbBbTOtDX6hKqNbh4xeP96UYVqIETfkaXHjnZoO1fNDedkg 0ebA/ed1usEe3C7S/PJ9ksh40p89acXsAxfhd0+yb+1cGtWm7TVfIlnaLDCtHJc/D+ zAafC/aPEWlto+FIOWMdYRW0VYMfyYW0EitDeQ50= Authentication-Results: vla1-fdfb804fb3f3.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Alexey Kirillov To: Jason Wang , Markus Armbruster , Thomas Huth , Eric Blake Cc: Laurent Vivier , Samuel Thibault , "Michael S. Tsirkin" , Michael Roth , Paolo Bonzini , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Stefan Weil , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, yc-core@yandex-team.ru Subject: [PATCH v7 3/5] net: Move NetClientState.info_str to dynamic allocations Date: Wed, 3 Mar 2021 12:59:08 +0300 Message-Id: <20210303095910.78277-4-lekiravi@yandex-team.ru> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303095910.78277-1-lekiravi@yandex-team.ru> References: <20210303095910.78277-1-lekiravi@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The info_str field of the NetClientState structure is static and has a size of 256 bytes. This amount is often unclaimed, and the field itself is used exclusively for HMP "info network". The patch translates info_str to dynamic memory allocation. This action is also allows us to painlessly discard usage of this field for backend devices. Signed-off-by: Alexey Kirillov --- hw/net/xen_nic.c | 5 ++--- include/net/net.h | 2 +- net/l2tpv3.c | 3 +-- net/net.c | 14 ++++++++------ net/slirp.c | 5 ++--- net/socket.c | 43 ++++++++++++++++++++++++------------------- net/tap-win32.c | 3 +-- net/tap.c | 13 +++++-------- net/vde.c | 3 +-- net/vhost-user.c | 3 +-- net/vhost-vdpa.c | 2 +- 11 files changed, 47 insertions(+), 49 deletions(-) diff --git a/hw/net/xen_nic.c b/hw/net/xen_nic.c index 5c815b4f0c..8431808ea0 100644 --- a/hw/net/xen_nic.c +++ b/hw/net/xen_nic.c @@ -296,9 +296,8 @@ static int net_init(struct XenLegacyDevice *xendev) netdev->nic = qemu_new_nic(&net_xen_info, &netdev->conf, "xen", NULL, netdev); - snprintf(qemu_get_queue(netdev->nic)->info_str, - sizeof(qemu_get_queue(netdev->nic)->info_str), - "nic: xenbus vif macaddr=%s", netdev->mac); + qemu_get_queue(netdev->nic)->info_str = g_strdup_printf( + "nic: xenbus vif macaddr=%s", netdev->mac); /* fill info */ xenstore_write_be_int(&netdev->xendev, "feature-rx-copy", 1); diff --git a/include/net/net.h b/include/net/net.h index 162fd3f1b5..7039eb280a 100644 --- a/include/net/net.h +++ b/include/net/net.h @@ -94,7 +94,7 @@ struct NetClientState { NetQueue *incoming_queue; char *model; char *name; - char info_str[256]; + char *info_str; NetdevInfo *stored_config; unsigned receive_disabled : 1; NetClientDestructor *destructor; diff --git a/net/l2tpv3.c b/net/l2tpv3.c index 8aa0a3e1a0..96611cb4af 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -730,8 +730,7 @@ int net_init_l2tpv3(const Netdev *netdev, QAPI_CLONE_MEMBERS(NetdevL2TPv3Options, &nc->stored_config->u.l2tpv3, l2tpv3); - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "l2tpv3: connected"); + s->nc.info_str = g_strdup_printf("l2tpv3: connected"); return 0; outerr: qemu_del_net_client(nc); diff --git a/net/net.c b/net/net.c index 1e50222a6e..88d70d0e4d 100644 --- a/net/net.c +++ b/net/net.c @@ -128,11 +128,12 @@ char *qemu_mac_strdup_printf(const uint8_t *macaddr) void qemu_format_nic_info_str(NetClientState *nc, uint8_t macaddr[6]) { - snprintf(nc->info_str, sizeof(nc->info_str), - "model=%s,macaddr=%02x:%02x:%02x:%02x:%02x:%02x", - nc->model, - macaddr[0], macaddr[1], macaddr[2], - macaddr[3], macaddr[4], macaddr[5]); + g_free(nc->info_str); + nc->info_str = g_strdup_printf( + "model=%s,macaddr=%02x:%02x:%02x:%02x:%02x:%02x", + nc->model, + macaddr[0], macaddr[1], macaddr[2], + macaddr[3], macaddr[4], macaddr[5]); } static int mac_table[256] = {0}; @@ -351,6 +352,7 @@ static void qemu_free_net_client(NetClientState *nc) } g_free(nc->name); g_free(nc->model); + g_free(nc->info_str); qapi_free_NetdevInfo(nc->stored_config); if (nc->destructor) { nc->destructor(nc); @@ -1197,7 +1199,7 @@ void print_net_client(Monitor *mon, NetClientState *nc) monitor_printf(mon, "%s: index=%d,type=%s,%s\n", nc->name, nc->queue_index, NetClientDriver_str(nc->info->type), - nc->info_str); + nc->info_str ? nc->info_str : ""); if (!QTAILQ_EMPTY(&nc->filters)) { monitor_printf(mon, "filters:\n"); } diff --git a/net/slirp.c b/net/slirp.c index 6ab348b943..bfa07e3432 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -664,9 +664,8 @@ static int net_slirp_init(NetClientState *peer, const char *model, stored->tftp_server_name = g_strdup(tftp_server_name); } - snprintf(nc->info_str, sizeof(nc->info_str), - "net=%s,restrict=%s", inet_ntoa(net), - restricted ? "on" : "off"); + nc->info_str = g_strdup_printf("net=%s,restrict=%s", inet_ntoa(net), + restricted ? "on" : "off"); s = DO_UPCAST(SlirpState, nc, nc); diff --git a/net/socket.c b/net/socket.c index 1614523b82..98172347d7 100644 --- a/net/socket.c +++ b/net/socket.c @@ -180,7 +180,8 @@ static void net_socket_send(void *opaque) s->fd = -1; net_socket_rs_init(&s->rs, net_socket_rs_finalize, false); s->nc.link_down = true; - memset(s->nc.info_str, 0, sizeof(s->nc.info_str)); + g_free(s->nc.info_str); + s->nc.info_str = g_new0(char, 1); return; } @@ -400,16 +401,16 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer, stored->mcast = g_strdup(mcast); s->dgram_dst = saddr; - snprintf(nc->info_str, sizeof(nc->info_str), - "socket: fd=%d (cloned mcast=%s:%d)", - fd, inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); + nc->info_str = g_strdup_printf("socket: fd=%d (cloned mcast=%s:%d)", + fd, inet_ntoa(saddr.sin_addr), + ntohs(saddr.sin_port)); } else { if (sa_type == SOCKET_ADDRESS_TYPE_UNIX) { s->dgram_dst.sin_family = AF_UNIX; } - snprintf(nc->info_str, sizeof(nc->info_str), - "socket: fd=%d %s", fd, SocketAddressType_str(sa_type)); + nc->info_str = g_strdup_printf("socket: fd=%d %s", + fd, SocketAddressType_str(sa_type)); } return s; @@ -444,7 +445,7 @@ static NetSocketState *net_socket_fd_init_stream(NetClientState *peer, nc = qemu_new_net_client(&net_socket_info, peer, model, name); - snprintf(nc->info_str, sizeof(nc->info_str), "socket: fd=%d", fd); + nc->info_str = g_strdup_printf("socket: fd=%d", fd); s = DO_UPCAST(NetSocketState, nc, nc); @@ -528,9 +529,10 @@ static void net_socket_accept(void *opaque) stored->has_fd = true; stored->fd = g_strdup_printf("%d", fd); - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "socket: connection from %s:%d", - inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); + g_free(s->nc.info_str); + s->nc.info_str = g_strdup_printf("socket: connection from %s:%d", + inet_ntoa(saddr.sin_addr), + ntohs(saddr.sin_port)); } static int net_socket_listen_init(NetClientState *peer, @@ -645,9 +647,10 @@ static int net_socket_connect_init(NetClientState *peer, stored->has_connect = true; stored->connect = g_strdup(host_str); - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "socket: connect to %s:%d", - inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); + g_free(s->nc.info_str); + s->nc.info_str = g_strdup_printf("socket: connect to %s:%d", + inet_ntoa(saddr.sin_addr), + ntohs(saddr.sin_port)); return 0; } @@ -704,9 +707,10 @@ static int net_socket_mcast_init(NetClientState *peer, stored->localaddr = g_strdup(localaddr_str); } - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "socket: mcast=%s:%d", - inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); + g_free(s->nc.info_str); + s->nc.info_str = g_strdup_printf("socket: mcast=%s:%d", + inet_ntoa(saddr.sin_addr), + ntohs(saddr.sin_port)); return 0; } @@ -769,9 +773,10 @@ static int net_socket_udp_init(NetClientState *peer, stored->has_udp = true; stored->udp = g_strdup(rhost); - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "socket: udp=%s:%d", - inet_ntoa(raddr.sin_addr), ntohs(raddr.sin_port)); + g_free(s->nc.info_str); + s->nc.info_str = g_strdup_printf("socket: udp=%s:%d", + inet_ntoa(raddr.sin_addr), + ntohs(raddr.sin_port)); return 0; } diff --git a/net/tap-win32.c b/net/tap-win32.c index b60933bd1a..0888db8cce 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -787,8 +787,7 @@ static int tap_win32_init(NetClientState *peer, const char *model, stored->has_ifname = true; stored->ifname = g_strdup(ifname); - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "tap: ifname=%s", ifname); + s->nc.info_str = g_strdup_printf("tap: ifname=%s", ifname); s->handle = handle; diff --git a/net/tap.c b/net/tap.c index 8041245ba7..f864f434b2 100644 --- a/net/tap.c +++ b/net/tap.c @@ -625,8 +625,7 @@ int net_init_bridge(const Netdev *netdev, const char *name, stored->helper = g_strdup(helper); } - snprintf(s->nc.info_str, sizeof(s->nc.info_str), "helper=%s,br=%s", helper, - br); + s->nc.info_str = g_strdup_printf("helper=%s,br=%s", helper, br); return 0; } @@ -714,7 +713,7 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, g_free(tmp_s); } - snprintf(s->nc.info_str, sizeof(s->nc.info_str), "fd=%d", fd); + s->nc.info_str = g_strdup_printf("fd=%d", fd); } else if (tap->has_helper) { if (!stored->has_helper) { stored->has_helper = true; @@ -727,8 +726,7 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, g_strdup(DEFAULT_BRIDGE_INTERFACE); } - snprintf(s->nc.info_str, sizeof(s->nc.info_str), "helper=%s", - tap->helper); + s->nc.info_str = g_strdup_printf("helper=%s", tap->helper); } else { if (ifname && !stored->has_ifname) { stored->has_ifname = true; @@ -745,9 +743,8 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, stored->downscript = g_strdup(downscript); } - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "ifname=%s,script=%s,downscript=%s", ifname, script, - downscript); + s->nc.info_str = g_strdup_printf("ifname=%s,script=%s,downscript=%s", + ifname, script, downscript); if (strcmp(downscript, "no") != 0) { snprintf(s->down_script, sizeof(s->down_script), "%s", downscript); diff --git a/net/vde.c b/net/vde.c index b0b8800571..67de6eb0c5 100644 --- a/net/vde.c +++ b/net/vde.c @@ -100,8 +100,7 @@ static int net_vde_init(NetClientState *peer, const char *model, nc = qemu_new_net_client(&net_vde_info, peer, model, name); - snprintf(nc->info_str, sizeof(nc->info_str), "sock=%s,fd=%d", - sock, vde_datafd(vde)); + nc->info_str = g_strdup_printf("sock=%s,fd=%d", sock, vde_datafd(vde)); s = DO_UPCAST(VDEState, nc, nc); diff --git a/net/vhost-user.c b/net/vhost-user.c index 5b7056be25..49c9a740c2 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -327,8 +327,7 @@ static int net_vhost_user_init(NetClientState *peer, const char *device, user = g_new0(struct VhostUserState, 1); for (i = 0; i < queues; i++) { nc = qemu_new_net_client(&net_vhost_user_info, peer, device, name); - snprintf(nc->info_str, sizeof(nc->info_str), "vhost-user%d to %s", - i, chr->label); + nc->info_str = g_strdup_printf("vhost-user%d to %s", i, chr->label); nc->queue_index = i; if (!nc0) { nc0 = nc; diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 8c27ea0142..423d71770d 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -200,7 +200,7 @@ static int net_vhost_vdpa_init(NetClientState *peer, const char *device, stored->has_queues = true; stored->queues = 1; /* TODO: change when support multiqueue */ - snprintf(nc->info_str, sizeof(nc->info_str), TYPE_VHOST_VDPA); + nc->info_str = g_strdup_printf(TYPE_VHOST_VDPA); nc->queue_index = 0; s = DO_UPCAST(VhostVDPAState, nc, nc); vdpa_device_fd = qemu_open_old(vhostdev, O_RDWR); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 09:59:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 09:59:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92807.174978 (Exim 4.92) (envelope-from ) id 1lHOID-0001it-It; Wed, 03 Mar 2021 09:59:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92807.174978; Wed, 03 Mar 2021 09:59:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOID-0001ik-El; Wed, 03 Mar 2021 09:59:45 +0000 Received: by outflank-mailman (input) for mailman id 92807; Wed, 03 Mar 2021 09:59:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHOIC-0001PK-D0 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 09:59:44 +0000 Received: from forwardcorp1p.mail.yandex.net (unknown [2a02:6b8:0:1472:2741:0:8b6:217]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 327e15ac-ad34-4215-b7df-9175459da989; Wed, 03 Mar 2021 09:59:28 +0000 (UTC) Received: from vla1-fdfb804fb3f3.qloud-c.yandex.net (vla1-fdfb804fb3f3.qloud-c.yandex.net [IPv6:2a02:6b8:c0d:3199:0:640:fdfb:804f]) by forwardcorp1p.mail.yandex.net (Yandex) with ESMTP id 9C0592E14C6; Wed, 3 Mar 2021 12:59:26 +0300 (MSK) Received: from vla5-d6d5ce7a4718.qloud-c.yandex.net (vla5-d6d5ce7a4718.qloud-c.yandex.net [2a02:6b8:c18:341e:0:640:d6d5:ce7a]) by vla1-fdfb804fb3f3.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id 75vXZVylHd-xQxmaOHu; Wed, 03 Mar 2021 12:59:26 +0300 Received: from dynamic-red3.dhcp.yndx.net (dynamic-red3.dhcp.yndx.net [2a02:6b8:0:107:880d:3c89:fcd8:ca75]) by vla5-d6d5ce7a4718.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id w0BjtEeJGw-xQnKju6j; Wed, 03 Mar 2021 12:59:26 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 327e15ac-ad34-4215-b7df-9175459da989 Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1614765566; bh=n9oFPL9OFWeJlaeULAx/nFzDl5X6l0o+RbDsoPiDwA8=; h=In-Reply-To:Message-Id:References:Date:Subject:To:From:Cc; b=UAUNLgnZriZKGRK85M7zFCyv9d4AAuwbFhNOc6ovPv/2y1bLP6O3Je+7lGyLvs4gW CN46OFG91U3TkAiFAVK+jJCU/55Z4GGL2xvkyY8npnRIDDS/qnW7x8xm73ZgwBhtPo GuwkGH/zjHVyvFLRd604KCe6CnHJY7wk2bKiN0cY= Authentication-Results: vla1-fdfb804fb3f3.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Alexey Kirillov To: Jason Wang , Markus Armbruster , Thomas Huth , Eric Blake Cc: Laurent Vivier , Samuel Thibault , "Michael S. Tsirkin" , Michael Roth , Paolo Bonzini , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Stefan Weil , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, yc-core@yandex-team.ru Subject: [PATCH v7 5/5] net: Do not fill legacy info_str for backends Date: Wed, 3 Mar 2021 12:59:10 +0300 Message-Id: <20210303095910.78277-6-lekiravi@yandex-team.ru> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303095910.78277-1-lekiravi@yandex-team.ru> References: <20210303095910.78277-1-lekiravi@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As we use QAPI NetClientState->stored_config to store and get information about backend network devices, we can drop fill of legacy field info_str for them. We still use info_str field for NIC and hubports, so we can not completely remove it. Signed-off-by: Alexey Kirillov --- net/l2tpv3.c | 2 -- net/slirp.c | 3 --- net/socket.c | 28 ---------------------------- net/tap-win32.c | 2 -- net/tap.c | 9 --------- net/vde.c | 2 -- net/vhost-user.c | 1 - net/vhost-vdpa.c | 1 - 8 files changed, 48 deletions(-) diff --git a/net/l2tpv3.c b/net/l2tpv3.c index 96611cb4af..b7e1d84674 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -729,8 +729,6 @@ int net_init_l2tpv3(const Netdev *netdev, QAPI_CLONE_MEMBERS(NetdevL2TPv3Options, &nc->stored_config->u.l2tpv3, l2tpv3); - - s->nc.info_str = g_strdup_printf("l2tpv3: connected"); return 0; outerr: qemu_del_net_client(nc); diff --git a/net/slirp.c b/net/slirp.c index bfa07e3432..9454a673d6 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -664,9 +664,6 @@ static int net_slirp_init(NetClientState *peer, const char *model, stored->tftp_server_name = g_strdup(tftp_server_name); } - nc->info_str = g_strdup_printf("net=%s,restrict=%s", inet_ntoa(net), - restricted ? "on" : "off"); - s = DO_UPCAST(SlirpState, nc, nc); s->slirp = slirp_init(restricted, ipv4, net, mask, host, diff --git a/net/socket.c b/net/socket.c index 98172347d7..c0de10c0c0 100644 --- a/net/socket.c +++ b/net/socket.c @@ -180,8 +180,6 @@ static void net_socket_send(void *opaque) s->fd = -1; net_socket_rs_init(&s->rs, net_socket_rs_finalize, false); s->nc.link_down = true; - g_free(s->nc.info_str); - s->nc.info_str = g_new0(char, 1); return; } @@ -401,16 +399,10 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer, stored->mcast = g_strdup(mcast); s->dgram_dst = saddr; - nc->info_str = g_strdup_printf("socket: fd=%d (cloned mcast=%s:%d)", - fd, inet_ntoa(saddr.sin_addr), - ntohs(saddr.sin_port)); } else { if (sa_type == SOCKET_ADDRESS_TYPE_UNIX) { s->dgram_dst.sin_family = AF_UNIX; } - - nc->info_str = g_strdup_printf("socket: fd=%d %s", - fd, SocketAddressType_str(sa_type)); } return s; @@ -445,8 +437,6 @@ static NetSocketState *net_socket_fd_init_stream(NetClientState *peer, nc = qemu_new_net_client(&net_socket_info, peer, model, name); - nc->info_str = g_strdup_printf("socket: fd=%d", fd); - s = DO_UPCAST(NetSocketState, nc, nc); s->fd = fd; @@ -528,11 +518,6 @@ static void net_socket_accept(void *opaque) stored->has_fd = true; stored->fd = g_strdup_printf("%d", fd); - - g_free(s->nc.info_str); - s->nc.info_str = g_strdup_printf("socket: connection from %s:%d", - inet_ntoa(saddr.sin_addr), - ntohs(saddr.sin_port)); } static int net_socket_listen_init(NetClientState *peer, @@ -647,10 +632,6 @@ static int net_socket_connect_init(NetClientState *peer, stored->has_connect = true; stored->connect = g_strdup(host_str); - g_free(s->nc.info_str); - s->nc.info_str = g_strdup_printf("socket: connect to %s:%d", - inet_ntoa(saddr.sin_addr), - ntohs(saddr.sin_port)); return 0; } @@ -707,12 +688,7 @@ static int net_socket_mcast_init(NetClientState *peer, stored->localaddr = g_strdup(localaddr_str); } - g_free(s->nc.info_str); - s->nc.info_str = g_strdup_printf("socket: mcast=%s:%d", - inet_ntoa(saddr.sin_addr), - ntohs(saddr.sin_port)); return 0; - } static int net_socket_udp_init(NetClientState *peer, @@ -773,10 +749,6 @@ static int net_socket_udp_init(NetClientState *peer, stored->has_udp = true; stored->udp = g_strdup(rhost); - g_free(s->nc.info_str); - s->nc.info_str = g_strdup_printf("socket: udp=%s:%d", - inet_ntoa(raddr.sin_addr), - ntohs(raddr.sin_port)); return 0; } diff --git a/net/tap-win32.c b/net/tap-win32.c index 0888db8cce..21e451107b 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -787,8 +787,6 @@ static int tap_win32_init(NetClientState *peer, const char *model, stored->has_ifname = true; stored->ifname = g_strdup(ifname); - s->nc.info_str = g_strdup_printf("tap: ifname=%s", ifname); - s->handle = handle; qemu_add_wait_object(s->handle->tap_semaphore, tap_win32_send, s); diff --git a/net/tap.c b/net/tap.c index f864f434b2..12a08d54fe 100644 --- a/net/tap.c +++ b/net/tap.c @@ -625,8 +625,6 @@ int net_init_bridge(const Netdev *netdev, const char *name, stored->helper = g_strdup(helper); } - s->nc.info_str = g_strdup_printf("helper=%s,br=%s", helper, br); - return 0; } @@ -712,8 +710,6 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, stored->fds = g_strdup_printf("%s:%d", stored->fds, fd); g_free(tmp_s); } - - s->nc.info_str = g_strdup_printf("fd=%d", fd); } else if (tap->has_helper) { if (!stored->has_helper) { stored->has_helper = true; @@ -725,8 +721,6 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, stored->br = tap->has_br ? g_strdup(tap->br) : g_strdup(DEFAULT_BRIDGE_INTERFACE); } - - s->nc.info_str = g_strdup_printf("helper=%s", tap->helper); } else { if (ifname && !stored->has_ifname) { stored->has_ifname = true; @@ -743,9 +737,6 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer, stored->downscript = g_strdup(downscript); } - s->nc.info_str = g_strdup_printf("ifname=%s,script=%s,downscript=%s", - ifname, script, downscript); - if (strcmp(downscript, "no") != 0) { snprintf(s->down_script, sizeof(s->down_script), "%s", downscript); snprintf(s->down_script_arg, sizeof(s->down_script_arg), diff --git a/net/vde.c b/net/vde.c index 67de6eb0c5..64bdb937ca 100644 --- a/net/vde.c +++ b/net/vde.c @@ -100,8 +100,6 @@ static int net_vde_init(NetClientState *peer, const char *model, nc = qemu_new_net_client(&net_vde_info, peer, model, name); - nc->info_str = g_strdup_printf("sock=%s,fd=%d", sock, vde_datafd(vde)); - s = DO_UPCAST(VDEState, nc, nc); s->vde = vde; diff --git a/net/vhost-user.c b/net/vhost-user.c index 49c9a740c2..e443c4b2b5 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -327,7 +327,6 @@ static int net_vhost_user_init(NetClientState *peer, const char *device, user = g_new0(struct VhostUserState, 1); for (i = 0; i < queues; i++) { nc = qemu_new_net_client(&net_vhost_user_info, peer, device, name); - nc->info_str = g_strdup_printf("vhost-user%d to %s", i, chr->label); nc->queue_index = i; if (!nc0) { nc0 = nc; diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 423d71770d..5a28bbcd7b 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -200,7 +200,6 @@ static int net_vhost_vdpa_init(NetClientState *peer, const char *device, stored->has_queues = true; stored->queues = 1; /* TODO: change when support multiqueue */ - nc->info_str = g_strdup_printf(TYPE_VHOST_VDPA); nc->queue_index = 0; s = DO_UPCAST(VhostVDPAState, nc, nc); vdpa_device_fd = qemu_open_old(vhostdev, O_RDWR); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 11:48:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 11:48:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92821.174990 (Exim 4.92) (envelope-from ) id 1lHPya-0004GC-6j; Wed, 03 Mar 2021 11:47:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92821.174990; Wed, 03 Mar 2021 11:47:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHPya-0004G5-36; Wed, 03 Mar 2021 11:47:36 +0000 Received: by outflank-mailman (input) for mailman id 92821; Wed, 03 Mar 2021 11:47:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHPyY-0004G0-8h for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 11:47:34 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a317676f-3be9-4547-9822-22cc71b3299f; Wed, 03 Mar 2021 11:47:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a317676f-3be9-4547-9822-22cc71b3299f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614772052; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=enl88DST0Ml9Qdz9BTXneN6SvP5rs+OmPrTeHTem2P4=; b=LfhVdhuwGXJ5SpRURk8Ftp/jYPiFmh19Ljp+v/4FUe5VaeFgXkWmZTj6 NA3+XKH6MBLyCS2sRksQjsGB2YQ9MSpp8jshsE3RBWq7DBFrUT6/y5Z8f mBMDvpH5vYgwKUTwo/Bdu9LIztqgiKiejvOOGj0oywmlWbBHsT/HeGj8k Q=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: +jeeHrDWaqT2cPX1aXaWqPBw7Md7k6u/00O7eLm7zsEEaHO70yApyyMXWAzAo2fQMTujb9Kp/J D0+6xz9YC200GPlvXU+5ATpKlFdSIrfMbPP19h+bPk934j8N4Z4H0NM3hLPobEZq3WuwomciBI oQUWT6QU06qWSUpLFSmalVpj+bKF1irg7aLYuBB11tFJIrrS6oFXGrK04oTfU85Rv5X2+Ubk1n KXOGB447Brw3U4uRP9AvhUHSDUPtGJqwa7opdMfH2zNiVUbcG6fOAzhE5pGRvS7UTLmbbNr1T2 js4= X-SBRS: 5.2 X-MesageID: 38340508 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,219,1610427600"; d="scan'208";a="38340508" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L7ArtUWIml8vk1MWb6sCYZVmuOVHdltQlFy5REplH6WbQsYDl4hdT80jQqy0XNPJjqkicogVABlNjbjcjpBgEj0d715UQ3Mq6odviTzoFmebpT5MemrrRu9d4OVUqM++yR20Lo/vyl+geBd5NC7fVldOlNybb8qdkk8S56JBKf4O3nTiXmgNRJr3e1Uh6IeiD+cZnVz4i6aGCE4TJ6dgjisX5Os6nbYx1RZn8guS5aKXwI8vtKDIhl7T3q56r1JXlh3RZ87YpETxXzY+qiUtvIF6bAlE2WtY0MoK4Q3TkTIWutMmBNx8NaPY1ji/m4lMQ8W4ysTL+fqeRFGWrIDG8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=enl88DST0Ml9Qdz9BTXneN6SvP5rs+OmPrTeHTem2P4=; b=Invz9TzkT4HHwE+91WKceqH5504DtXdOxa+iXW6wBJwwmz615ngFsVfgOCP/ZG9V/VxYTQgrQrhkI/5dDEXWXD1y8BxvGDTq8FWj9OaAk5Pv/as/u6Y/IX4i1wi9NA9AbFBLpt5cVdeMBLgjUhmBzF2oxwmyV6YsTp1npPBB0FOicZgcwih844MJTBbrylQt8nwVFkPwLe9ooJI0zr7QjGBdp9aQ66+aLmVAFt4/aGqWLBRKpgBqvdysVM23W59HJjM2zorv33wzn3XugCp5RxVyNEJnEe78bw/HirkGjEulvZBSPqdNI7q8F9VF2ADVa/1klnvn6h6mthGcXVLdQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=enl88DST0Ml9Qdz9BTXneN6SvP5rs+OmPrTeHTem2P4=; b=HxR+QGy0kNgVuS6Yr+k7JejNXzo/eK9b8Iq3jmnF8B7y1hbh3MUstatsF3+hLYKI2vfgUChRM9d9cnEvzpnFF5XzHyhNp0Ehm+k3c6Qt6mmK6sL3GzfmFLD602jOS4RSgv9DJtQc8K+ASlQsNIgcho866Rcb6KgUS/8Wph2HPZY= Subject: Re: [PATCH] automation: add a build job with NR_CPUS == 1 To: Roger Pau Monne , CC: Doug Goldstein , Jan Beulich References: <20210303083318.9363-1-roger.pau@citrix.com> From: Andrew Cooper Message-ID: <5dda8f5f-0d91-e956-383b-41060ef8f3de@citrix.com> Date: Wed, 3 Mar 2021 11:46:44 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210303083318.9363-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO3P123CA0001.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::6) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a39245b-49a2-49f1-f5d1-08d8de3a092a X-MS-TrafficTypeDiagnostic: BYAPR03MB3942: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9Kf/xY6stsBtzyjfA4maf0THjqtbf2gzXEYx74Xj3OBxMu4696cZCLaldkXlF9+zOdE8y6gCw3/HL1ntid+M59R4UrSSf11v9fIwPxzkGVY3784KKuj7zKXkTE8/O+NoCUa6Wm8ht7HqLRQstzjOjVdwEazNtvxtY8F5Nk6nuVASdWP124Gpo34MyoLRMv0kFEKT/kjtgLy4wZbD6jpOpmhMK96hLhZWhpoAi1pejgR25SQa0b+bEsrvO6TX39cE0OtqjLz7tn6jcvnWjsQHnxC9nXlXQ7GODcGUJJ6YRZJIKjKrF+qN973FgJgdT62SVTNASNBl1WwloZRDX3QC76EViQYrDch17R62wgH3YhPC1z75Xp6ARniIRjbF9ye3BZkMHHE1f5NaSF2sg6+OL7MHI2M3JLkiRBxg1Y1cCCyqtrQZvaBQFkQXHP2P+0IDB+RmBbokQLyYLU13GqZ3lh3vWZA890kV97/2Zgaxv9wH6FqUaEGcO2HL5qmcQvam0vRIymh3gaVMW0e8QAx9HFwgMh4nD53CO0NUW6SMJGWM4Wh6yAa/5qA9g+tXuILS0skelSg3sUGN94GA6tb3rnvQY7OnZCUiGodNyOmiWjg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(39850400004)(396003)(376002)(366004)(2906002)(5660300002)(54906003)(26005)(86362001)(36756003)(316002)(66476007)(4326008)(16576012)(83380400001)(31696002)(186003)(66556008)(8936002)(66946007)(6666004)(53546011)(2616005)(4744005)(8676002)(478600001)(16526019)(956004)(31686004)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?REx3RHZwRnlhbythaFRTZWtUcmUwQjBBcWF0QzBDRHl0Tk1raHlwcldoa3l5?= =?utf-8?B?a2dOZWsxYkJhMkpHVys4czQyY010eWRkMVYzcHF3ektwMFJ2MWhGaDV6UHBz?= =?utf-8?B?UlMrQ3pCdFk1ckJQZ09jZ2R0SlFOeCtEMnh1cWE4N01DUlJ5NndLd1UweFpo?= =?utf-8?B?eDlkWGdjd0djT2duVkJpcWF4eDRYL21vSzVyektrNlBsNFY5M3Z0Ny9BWFRl?= =?utf-8?B?NTJhWFhlNnB3N3dlYzdTUThVSkdoQ3VyUnFPZCtXenVxS1duL09udjlMOGF4?= =?utf-8?B?aTUzdU9HQUdZb2xTT09pS091Z1lTdDdSYXFhdTNuZFJLMDhUQU5zV0xNcUZs?= =?utf-8?B?Y2NRMjZjd2JUL0RJZy9Vc2hoc0R0L05zR2hVaGlmeDZNR0t1OEdENWwvOTM5?= =?utf-8?B?ZldWUEF1YXpTNlBvNnBjTGxPamw1VnhuOVFCYzc0WTFVY2RnNmVJVGttVUxT?= =?utf-8?B?YnBkcXZKRllJRFpBSVpMOXdhaUdGTDZhYkx0aGR0Z2JTdEhKSVFsWFBXRFZq?= =?utf-8?B?K0U3RWJUdm9QdlFOdCtrRWl4RUlhUHBhYzU3WlNJVG15NHczM0k3Y0lZWGlN?= =?utf-8?B?L1BpYzk0NjRqYk9ZMFpjSVNTU3ZxN1htQ1RQajFQSmFFNk9QS28zblAzVnhW?= =?utf-8?B?Q1ByOEhza2xXRmxzWkxpWVR6WHQrbDdiamhuckMxZUw2dUZ4RzVwby9pYnVH?= =?utf-8?B?a0xZWFp6VHdvZDZXajJ0eVBsa3ZXc01oNzJyMlFwL3RWalo0WmU0Zml5bU5z?= =?utf-8?B?U3QwVkVlcENzdC81ZjFRZGtmTTYvSFlVT3BqZTh4NkhyQ1lnZFROT241N3V6?= =?utf-8?B?THlSa3g4amV5RzM3ZmtBeEZSVVk1UGh6ZjJRQzVRWjg0aXdURTNIN3U0QXFO?= =?utf-8?B?c3NLeDJtUEg1R29GZks4VDNzOU10aUNvK1EwTEEzeEowQ09rKy83TThpT3BR?= =?utf-8?B?bmhBRUlRbW1pNnFCb2lrY2tCclBGTG1HVUdaUUFicXI0djVobnVRcjhKekhy?= =?utf-8?B?c2VObkVHMkJ5bkJXU1l0WlpYTVY0QUhBdUd0byt0dHBvYjdkdWRnbldHRGlS?= =?utf-8?B?OTBzZ29LWnlzMW1tek9uU3l3OG1MeHlOcm9sNjZjMTVBWWNsMnByV0g5TGtB?= =?utf-8?B?OGlsU0g5d2VtdzhBZlhlYlBDV2oveXZEWWZ0SklFditVWFI2dFJLcmRySlJa?= =?utf-8?B?dTRKaW9WM3hXUXluREhvZVUwK2xURmMyQWpYaitKNU5GZHlIZjZ2YlExbmtQ?= =?utf-8?B?L0xSK0JUQUI3RWR6SjE2V3laTFYzVGVsb2d3MlUzL3JUMHNBV00yUVpQSXk3?= =?utf-8?B?WlhVNGl6RmpkUEVwK2RBUUdOVDJqdllTL0hYRlRqUjVlaEpwUDdxS1FLZzNW?= =?utf-8?B?K1J3RlZIREhzb3hYQ2tIaUFHeXBtQjZqVUEwOGlpT2JISm1BRlg3YU4zeEZU?= =?utf-8?B?b2l5czErZ1B6ZmhTaDduSUpKbVZLNzlQVWlJTlVSL2s2djhJKzZvcjZ2YWRQ?= =?utf-8?B?VkVScE5NSWM5c1ovTHV6MkU0Zi85QXEwWHpLMWZMS1BjOFdDMmVUckpOb2VL?= =?utf-8?B?L3JFcVRUbjZ4eGMzYmxnaWtJZm4xVHFBaHBuVWF6VUJaeCtTd0hWNzFodzFL?= =?utf-8?B?RmJJcUxSMTlUMFRiLzRPZVc5Umc2NVREcFdacVhxUDF0cmlYSWlwd1V4cmZr?= =?utf-8?B?SXRQdTRMZ0k2NDcrRHFYQ0tLdVRMRklnVjgzUGorbjhjQng4dUptYm5lVGNo?= =?utf-8?Q?3o1loYBY1WnYosxcnAdSIYzlDlK1nv8O0YQPYNu?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1a39245b-49a2-49f1-f5d1-08d8de3a092a X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 11:46:51.9363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bOPRFGJn9mYed+NSkZQB+p/y2/W/lgs3gOh4gM4LYxUBnaxzysV7J8S6RpJ9DzsRddvMUH7lH9KtrZv/VUbCSdTTXaEJH3c8S+oMb/WvIoI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3942 X-OriginatorOrg: citrix.com On 03/03/2021 08:33, Roger Pau Monne wrote: > This requires adding some logic in the build script in order to be > able to pass specific Xen Kconfig options. > > Setting any CONFIG_* environment variable when executing the build > script will set such variable in the empty .config file before > running the olddefconfig target. The .config file is also checked > afterwards to assert the option has not been lost as part of the > configuration process. > > Signed-off-by: Roger Pau Monné > --- > Cc: Jan Beulich > --- > Not sure whether there's some easiest way to force a config option to > a set value from the command line. I'm -2 to this.  We've already use thousands of machine minutes per push, and this corner case isn't worth adding another 30 minutes or so per push. What would be far more useful is for randconfig to be weighted to choose 1, something around BITS_PER_LONG, and something around max preferentially. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Mar 03 11:58:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 11:58:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92826.175001 (Exim 4.92) (envelope-from ) id 1lHQ94-0005Ni-C2; Wed, 03 Mar 2021 11:58:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92826.175001; Wed, 03 Mar 2021 11:58:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHQ94-0005Nb-98; Wed, 03 Mar 2021 11:58:26 +0000 Received: by outflank-mailman (input) for mailman id 92826; Wed, 03 Mar 2021 11:58:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHQ93-0005NV-0e for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 11:58:25 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1c1d4f5a-19c1-4da0-a432-0ed5f9b1730c; Wed, 03 Mar 2021 11:58:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c1d4f5a-19c1-4da0-a432-0ed5f9b1730c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614772704; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=XoH8fAGBrW3105VTDDvSPPzoMqQr9HAgGTJTdyahT+w=; b=Mh7Vin0sO68Pw7Jo2V6gHAEtrKqIzXOkZlYXkFv0oIP+N2kZr5cAQd2Y 7WG8oiP9x4IBQV7DNGu0HnMMg1Llpu3E11p91Ncr8EkLuOpZfDbDnOAJN lFQ06olg3vo38GL8KK64B+vP+jAzyScUjpGB4ABYxAY6v9l22zDvNrgJG s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: LQ68EadTl2Pjqcz9bbB3gkMEGXZB+Am/PNjr8zfJnQTrjLpCROox5891k7KBRw51tkC7Qjq3aw cEn49iqX43m1gC6fLBbrpS4vj2IbsaDmwCahojKkMBPGd1/4+jOoV8QKp3OJSAdHzzUFBzCGJG n+iNUvrHCyjFN6Wl912dP7va4jf1yvssIaKGFzJTlfyuj2nii5akfY1I5YctTBgWh3ePCFxkj+ 1XCfSytwK5tJgKL0cMUuktY5E9G71ZyJBBRjicIx+Gp1VKA/awYhTdnMywFMMvAg2iff/+1EJb 8aI= X-SBRS: 5.2 X-MesageID: 39825637 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,219,1610427600"; d="scan'208";a="39825637" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i8cUMVp0wBbYlu78a7j25/4QqEVJ321vxUXsUI8oXUvtE7Dm4vFfpZNx/Xae81v6RA9LQRBnpECZO31VM0EUXdS2NnafLzRx1dZl5hBmjar4B0qXMQ1F/HkVHZPtuJecYGqzpHhIy3UcPuixDkjViCF0/s7xXI8HP2ufuEyun/j+3ReniX8XI/rKYkFs4l1cGG86G4XkgN6ZIEhoLUwXqdZH7K92K85NyWf/z146S5xKqPPhll9H+NTf+FR4gni7RJxWyWLcjmJgUnqkVfG0sjUWg6RrM6jGUntB/l3jDcp6CRPYIh9/OP7glNZjN/1tSPUwrnep7BIfjjW/6ah4dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LznaiZPkrQDxsg0osJgpGB9a1nFePR57uEAvEfipNMg=; b=PjQG9JJOgR+4PK91RoffUxJ9vr+oaqgh2LdOMukLkYM/SSTY85/24vdiQxNfuqrx1G+GDiiVH/7UZjSnr3cLUGI7WAvtU66AlZPjK/yAbw/NwLMSP03RcXMHIZYXPkLJjS5Z+6xKZebBGAWvr9Ztt8u2lWcxhGoGoEtz388XKa4UWVRZFHOXYIaHAtIB4E0KML1EVTDQF62fx4G1XEHPju7846lAMG7rGmL7I4PEARfQ19EZvgyVJhLeU7Wo8qf6jAE4Cmg6uKh4eoEq4c8++GD0CN9VHw+qnqmNtKamYk956zXsCwMcIePftgr6vKQVW6LzdxVBMjjgoIzevknqYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LznaiZPkrQDxsg0osJgpGB9a1nFePR57uEAvEfipNMg=; b=Dnika7I3C6TYiIn1S1iL/+bGjZT2NvS29fReueBlzcjKunEyuQXQQD5rqO3+q4r9AZKF/HqDGT5csPKw2df8yyMPkocQ7VIKb3ON8MDr94hJ760aQ2PquIEaQ3MDqnJaCLF5GYsGujAuRZ9jMYaeAt9HUM2FdedfUjbBJWGCddw= Date: Wed, 3 Mar 2021 12:57:52 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: , Doug Goldstein , Jan Beulich Subject: Re: [PATCH] automation: add a build job with NR_CPUS == 1 Message-ID: References: <20210303083318.9363-1-roger.pau@citrix.com> <5dda8f5f-0d91-e956-383b-41060ef8f3de@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5dda8f5f-0d91-e956-383b-41060ef8f3de@citrix.com> X-ClientProxiedBy: MRXP264CA0041.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:14::29) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f06b8a52-c9ba-40c5-0b17-08d8de3b953b X-MS-TrafficTypeDiagnostic: DM5PR03MB2633: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8ZVZvzlZjeTZDdflsD8kNakBH37iBLPnyVRS2ifTE7BPeV0f8A+1lFfV/KqjwGT/kZYiLrQmpPiQwFxrBeOdAd3ImwnrH/fj20g2Z8klmpAN9RYTPleUDj8FjgcXmMlgi8Cs8P9r4JqZN+zenN98NBzh/DGQCDpaMhg3vudxB765RmqneDDaw2gAEN6S+To2lk+Geu170mwjpJu25vD1Du0rxGkezV+MmKqWu/IN1YEEmzYsd32QklFs0+f1qEvDKGzJgumiWROcGA/O8RId8wztk5EPuoN4hAxnnLHUkWFfcocvvHdMnTVsYguuTAf3qFsUm3GCZeb/a/jSXPrndsZiRMKvjl4EIuLHA9/kGTDvLRbAGhGc+EreK5+tIqizZsRxhbb/UZ2xA3/lOovg52/SZrAyPhCxNrbRZiJ0ZIBMNgaob2HTqu6MAltMQ3jicrtIQX7RtsxGFBc47ntY71UJuba4iqgBse2IREB3SZtMhegi+AmDujnSoSwRRV3WvZUPMqGWaT0kKDbJjmFLBw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(136003)(346002)(396003)(366004)(376002)(39850400004)(53546011)(54906003)(6496006)(478600001)(86362001)(6636002)(316002)(66556008)(5660300002)(66476007)(66946007)(8676002)(16526019)(4326008)(6486002)(85182001)(956004)(2906002)(83380400001)(8936002)(6862004)(6666004)(33716001)(186003)(9686003)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?RlQrTVVJd05SNmpCRHE2VjFUVkFmOEVKbG90d1RucFpUTDBIWXJ3aVpwT3Nw?= =?utf-8?B?TXpiMDVBek5tR3BIZkNQTjB1eEtESk9uMHI1MWFHOG56ODVvaVUzcUo1RmxU?= =?utf-8?B?NVZaSnA3bFhJRkhrL3A5b1hTSTAvWDBLVHJLZ1pHUElYY0NMSHQyRUtqY3NR?= =?utf-8?B?a0FueDJpMUVncTBvTXo4U2dGd1pkcVhVeCtJT1VvSTNYdnZ1MGgyOXZLa1dV?= =?utf-8?B?Mkt1YTRhL3ZDaU41WEdsWVlUQWR0bEp1dElodndnUW9kaWh6V2ljMkZFaXpl?= =?utf-8?B?NWdtV1pyWkRPRHRvYm9GQUE0cjhaU0UrSjFYVC9BT0FUNmZyUzcrbE1ZRC9C?= =?utf-8?B?VDk0SHJsUmF3aWVkWmc0ZHpUSkhXai8xeWx0a1VJRkh6Y2VmOVhSZWh5WEFE?= =?utf-8?B?Znc1SzVJbjA2b2xJcGdhRDVDNnNwNG8zZWtpdDdRYk9Xd2RYOUhTTVB1ZmZ4?= =?utf-8?B?YitBem5hcDBEUGR3a0lzWk5ZUVhyMFIxU0F1RXZNSlY4YXQ0ZjI4SE1FSXRI?= =?utf-8?B?UFVqU082T0pjN0ZXRGNYWXMxeXZhSU9WWWV0bTBUQS85QkFWbFlWZUJod21D?= =?utf-8?B?R3JLd2VXMGJHWGhtOTNFWlhIenIwRWc3aC9na2kxaURSVlFQR3QzclhKNHQr?= =?utf-8?B?VzQwRFBJMy9TMlBSUWlzQitUa1hXelNHYzBQaW5wQjlVTFNjcjE4Z0xGSW9l?= =?utf-8?B?SlQ5ZkRQQmxyRUczNmM2RlFGOXNrSGhVTVY5WUUzMXZ5cE5PVWZzMnJrS0dJ?= =?utf-8?B?bjVvYjJ3NzJOQlVua2pNRDkyMXB1ZmNxRzY5SDM4TjQrb3NLbThPajlnSXla?= =?utf-8?B?QVpNSVVlTkFPcWZHNEh2MGdWa3k3Qm5HYjVmeCtiV1p2Y2hBcFRBYzVzRUpG?= =?utf-8?B?SEl5V0QzV3JNMXpzMEQvNkJ2d3Z1QURuK3pZZW5wMFlSOVFIM3VhQXBxNGFR?= =?utf-8?B?ZFU3cE14MVRjeTZCWTFiSlcrU1JCbDNiZjZUWjBxM0NWdXFjNE9kMFR4eUhK?= =?utf-8?B?SkJYdzdGS2U1enNSRU42UzgvZXEzOUNvM1k5Zi9aWUFBb2N2aDlPTjQzMmt4?= =?utf-8?B?OGlCbXRxR2VPWWNuMG03Y0NoTzNrVEQrcjlielgzYldIQ2JmMEpmVGJmVEtp?= =?utf-8?B?WEtnSEt1OHZ5Yk41akJzM1JlTER4T095UG9aMlJPMFJLbTFaUWJGZnBITzFj?= =?utf-8?B?UVR4aXVJQk53NW5CYW04VCtnNExydFNicE42Zk5IRUxPRHhMNi9MUVc4ZnZu?= =?utf-8?B?OHArU1JyVkhkZmxucVMyN2NGVTFJV3BkYjFHRHpXMVlxcGpKeWF1SmhFczV3?= =?utf-8?B?Zkw0ZHR0UkxsNUIrdDY0VFNPcXoyNVc1amZLUi9aMUFWdDVtNFFScXdJbEl4?= =?utf-8?B?UDVVb1c5V1M1NzRNYVFGcUJxWUVWQ01SM1FIWWFRUHR1WWpmYmF4cVVHY2hL?= =?utf-8?B?Q3htVFppVm9IZEduNkgrT0YrNi9SZGZSbjhVbmgwYjdyYkU2MlMwQzVYemxp?= =?utf-8?B?a2MrNFNWT2g4ZWpITVp3OVNwSGI3REtmK1VyWTdoL2xSb3EzVGpqSXNOaGh1?= =?utf-8?B?OXE3cnhMbllSU3dOa242RmFGdElldEpjSmtaN1lXd2x6RjdDa2o1d1NDOWlC?= =?utf-8?B?ZUVNYXVtMzN3VThxc0tYQXVNaXRZeC9qYkFhSW1IVVZrUTg5SHhtbjI2cDJx?= =?utf-8?B?bnJQVkhUSHFoZU8wQXVnZlRtVGF2eksyVUpyMWpPTDB0UGFqejRkTUI2b1VJ?= =?utf-8?B?dzNpQzI1TGxIenUvQ1BBaEg2N0wxeVBZN0dnTk9BdDJlYksyWXlUMWI2ZFg5?= =?utf-8?B?NXF4MTZZZ0FxK3F3ckx6UT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: f06b8a52-c9ba-40c5-0b17-08d8de3b953b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 11:57:56.3276 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yLF4nC+NbjBiGvpuRIbEA35y88WkVMOBfNZIaz6sBYZNsvCZmnCsSlOjWmTcuBuNuvKFZJCxSqk4iDFZQuXSKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2633 X-OriginatorOrg: citrix.com On Wed, Mar 03, 2021 at 11:46:44AM +0000, Andrew Cooper wrote: > On 03/03/2021 08:33, Roger Pau Monne wrote: > > This requires adding some logic in the build script in order to be > > able to pass specific Xen Kconfig options. > > > > Setting any CONFIG_* environment variable when executing the build > > script will set such variable in the empty .config file before > > running the olddefconfig target. The .config file is also checked > > afterwards to assert the option has not been lost as part of the > > configuration process. > > > > Signed-off-by: Roger Pau Monné > > --- > > Cc: Jan Beulich > > --- > > Not sure whether there's some easiest way to force a config option to > > a set value from the command line. > > I'm -2 to this.  We've already use thousands of machine minutes per > push, and this corner case isn't worth adding another 30 minutes or so > per push. In fact I think those builds could be hypervisor only, which will limit them to a couple of minutes? Would that be an acceptable compromise? Not just to test NR_CPUS, but in general for testing specific Kconfg options. Likely randconfig should also be an hypervisor build only, there's no reason to do a build test of the tools with a hypervisor randconfig. Let me prepare a patch for that. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 03 12:01:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 12:01:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92833.175014 (Exim 4.92) (envelope-from ) id 1lHQBn-0006Sp-9a; Wed, 03 Mar 2021 12:01:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92833.175014; Wed, 03 Mar 2021 12:01:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHQBn-0006Si-5o; Wed, 03 Mar 2021 12:01:15 +0000 Received: by outflank-mailman (input) for mailman id 92833; Wed, 03 Mar 2021 12:01:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHQBl-0006S2-Lj for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 12:01:13 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9940920d-26fc-4669-8ea4-3c05d91a4171; Wed, 03 Mar 2021 12:01:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9940920d-26fc-4669-8ea4-3c05d91a4171 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614772872; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=nllq/LR5NUkr2g40riYpZbZo/deabKkVCzcCfDWoVzg=; b=K5lkd+d/3T6dyb3BGQciCry0zf4hbBasVkUtVc8b+KDcoT57HPa0ozqA I9D5QlOclwAOwiZv8Ba/YjYQtuCXxAFLZAMPeJdiAAwFJAKmi7MNFckNK IQLqQvsqq3j948Tmjky9uZrgHh6PuA3muwTrEYBsBcn5uoMkl3/q5sOt+ g=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: wUZhNSJmRzhrMDm2S0Xk+vjYcTOurCEAvsUG+CAEn3rWC8dPlh5S1MQb1aFhPeVheYxeIOt9TZ 6AQMXN1aiL+LCt11YWG09MoafAx3h8o2PVmLtQlFhQ1lUmgaYZp353yRWBcy3iuQKlBXSmdxYp DunaExFF5RwVt/CT7PPyKCh7zJQ2u3dHR0FzBULnOuUdDFq90x9WTrEQUW4AAA63jx+7T1FDLe Ub+2FCVfCLmJGM/NmA9dV1zzJhiREzX+TZC4mfxKmnUo0aK+swVi92fUoauAjEWg5xr1U2HpF6 f4A= X-SBRS: 5.2 X-MesageID: 38790462 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,219,1610427600"; d="scan'208";a="38790462" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JkIDvbVodf68MZl8MX2MPwSkewcAJACYfu4HCwrfSX1leR/sToSn0Ez1FoVjA/TIi+5cSe27pnDWKHYvpoxCHsYkY+vm6zoQsT6VhmtEp4AUe0zZlx/OYkJNHdW8i/anzi0JL7JpFHqqhxiXH0zFa/ubXlH2gX+ONmnYxoBrWxQAgttvDWFUkiHm02Jkkpl7973ECF1hqsJ4Q0EUQv7tX9AZBR6BE69gEbwS2L5mtaiFM5Du5MJwLOOW7lDNvbXF9FotAEdlA3obOhncwsiqknJNKce6mycls3k6jGuecrcK9rnvvJsBoqBLXVE58O0T0dh4vpoW1M1lPCEWR9ygFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nllq/LR5NUkr2g40riYpZbZo/deabKkVCzcCfDWoVzg=; b=XBfAkbfrOJAjqJKVtGOwQwJ15bI1NE35+pH9CsNZ78/xK26wSRw66ZAxFKdk8irSJkOlYNIqtFhH2L3IsDAg5ZGpMxQ07vaSTSO9Q/9puDQZya0PX18wdFdgxcmkkgcdT4lwGrytXHkP1za3fuRqCZIfUj4X72GXSg9aTxzNGaHrMsyXZ+/t1Q8k7uaxrjaKpXNt5bBuRYFQqB96cwr34D3NdNE4AjHi+Cb+Frl/Vcmg5EofFvZ98BlyARoFakz6DUOyGfoYbBk5EPTS3ZSa0Q/3By3gMIkjkt4SFZgyZ9S/hCB+y31hqh2H3Z4+P5bzo0/ty5Hji5+qaWKTgnPgFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nllq/LR5NUkr2g40riYpZbZo/deabKkVCzcCfDWoVzg=; b=ZBrYbxQWaHg7P9eHJosbZBosB2bjFx9OvPO2hrx3ifiMItOUGEt5zRbnVrU8Zo30dCf31gxY/kfmcS103N/zFrDMaVDWBr1vAOpgoQu7J9A0llmOGdly96nVqM81x3YKnInhVFF+oS3X/if+1NXrwrD/BDlB0V5DvMnWWMckPUU= Subject: Re: [PATCH] automation: add a build job with NR_CPUS == 1 To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: , Doug Goldstein , "Jan Beulich" References: <20210303083318.9363-1-roger.pau@citrix.com> <5dda8f5f-0d91-e956-383b-41060ef8f3de@citrix.com> From: Andrew Cooper Message-ID: <2cc48689-2d25-dd14-e407-9ec996674e2a@citrix.com> Date: Wed, 3 Mar 2021 12:00:44 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0111.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::8) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ba9d2961-278b-4725-1e98-08d8de3bfcfd X-MS-TrafficTypeDiagnostic: BYAPR03MB3622: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SWdsTvZKC/tEC5E1hh6i2kOBtq6v/D40ID4Gnyx9dIQC1rklEvpgfMBEkiJGz+Cc4pzIaQa+//K3lGZAOGOr2W+05K9BdYKM+MipUJDUhtEnlVUg7169RHtQeNg3k6AGQ70CvQ/9L04V/mq2gtBZobO9Tz4S4fIraU/K7IzQ6RUKjmF3pDIGK0EvuHlqQigJqkO+QlkipleuVhvlZjgjhl7+9LUWx/rPaV0PQegnO3uP7Nu/IebhoVu9oruK5zMB3RssO4IJiCoemMFbwDd1Wngj4dhal/wQWf0btkgM4zbXclCQLZBi8/9grh1ccV+tl3k/BMO5fYeTByj6Ik7h9YsGhh/7jopekgca1Df1mXTGGbMlp+Nfi3NoegOKgQz1AGAMyg8ao+LzNFB2w4dJl/ZmuRIIMlVUYZdoBczGMVr4PA2dWu2a4VZUBtnDFTyEgrYofn+1bzCilK2Kip2/BxwPTB1Chfc3qAdDIUuVueVtRFG0jYrSm8Ux5pG9l3F6RuZDq0kAKH32ioCzNEhGC+IMRA7rzdzluplBwKvyAt+FLk5S/GuhtCQGdNrhlavPH024qoqY455nULj0t/L3jn5LPxCC6zZLHdVUprs2F5g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(136003)(39860400002)(346002)(376002)(8936002)(8676002)(6862004)(83380400001)(6666004)(66946007)(31696002)(53546011)(66476007)(66556008)(6636002)(31686004)(478600001)(4326008)(86362001)(36756003)(2906002)(956004)(54906003)(37006003)(6486002)(2616005)(16526019)(186003)(26005)(316002)(5660300002)(16576012)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MkZ0M1V6Z1FNK0F4YURpWTcxMHlBNWVUQUxOSkE5R205dXphbWN5a2srQWl0?= =?utf-8?B?c25RUVhBUFhpeGJYY21KNTB4NEsvMWI3WVJYUDJyZ3VuYVJhelZpakpLUVNw?= =?utf-8?B?TDE2WXo0TEN6N3VmdXhTUVRpQ2V3bjVDa3k2aSs0Nk5rOWlZR1FFMzFka3J3?= =?utf-8?B?SFhndmEwTEVyOXZLVW1STGk4RkVzUVM0UnNCcC9NOGZncDE3Nk9TVlVzTm04?= =?utf-8?B?bXdOcStjbHJzcjZnZHQwQTIvdUlYM2daNWphQ25lM2wva1dsWUFaZE83L2x3?= =?utf-8?B?MDFKS2M5ZzY2MUpTWmlvQXFDUHNmYWc5UkpGWVlqeUo4WEovdTNHYlZGbkY1?= =?utf-8?B?U1RWR0ovcVNaYVpQSDcyWUZWY3NaQzQ1N2c3NGRONWM5R3pzcnVyS0ZzMVpu?= =?utf-8?B?ay8vMU1xT1BqN3A2ZlZ3ZTA5S1QvSGZDS0wyNHU1a1U0NWpwM0cwUHZUZnhy?= =?utf-8?B?KzV3ZzJzdjllWSsxUm1EZytqSTJ6M3dwZElERHNzcmtRKzA3WjFJaWNzOHpY?= =?utf-8?B?bWl2aFZ6TlBXRFRQSC9xM0hvYXlWcDVQR3dpZWtORlRoUXBYbi9ZYjJOY1p5?= =?utf-8?B?SHUybmloazFVVU1YeTBpbjZkVytndHVVR05XUU9TeFYzeWdXUFdiR3l2YURn?= =?utf-8?B?OTc2OE9aY1BNMURqZ1BJcXBBZnQrdmRyUXUrbUhZSEwxTDU3ZEZTOUJBVkRv?= =?utf-8?B?SnBxaE81Yys5MjlGV1pLTHltSm5DTU92dVloUWJTa0tmUm43RVcwU1hGU2ht?= =?utf-8?B?Vk8wVXRXWEp3WVNzNE9yZTNRM0RSeUs1b29DWm04RkQ2NVRtdVlKcklGTkVE?= =?utf-8?B?dWRhWlpBZFNJdWQrbTJYcEF0OC9xSkZKdW84SHB3a0FrbjQxeDNzNXlXQkd2?= =?utf-8?B?eGsyQk9LNThuMjlBRGZ3eVRiQWZ4Q3VVUkJqZDVJaHJQZXp4d1lheWUyelpm?= =?utf-8?B?TlhKWDk0SHlZdlZrNWhXUVVOU3NjeXVUdElzekhpUGRiU1hUSUlmQ0d4Zk0r?= =?utf-8?B?Y2RFSGtrYk11NlZmUFR6aCtUd0N0RmlVSHNyRkdXbkllTnBCcUV5bS90bVF2?= =?utf-8?B?QVNMSWpSUUF0dEF5TFRDUDY3WnFzWk1Bb0tWQVZjMWlWS0NsbGpQcUJ5U1Bp?= =?utf-8?B?bUJqVWVYM1BXNllFS1FDWGVPU2FtS2VPYnJOajlkdnZZdkErZUdnREdNNWlv?= =?utf-8?B?RUZkMnFsTk5scjgxOVc0NHRCUWE3aG96b25Ba1RzOFo4dVROMFpsR3prRmNr?= =?utf-8?B?dzYzbnpJOWtlZjcveTRZYlZPU2JzZFBuUXN0RTF5WUowS3hFblkzUy9MTkxv?= =?utf-8?B?djBIODBybmxTRWxWQmVWbGpOT2xoQWRxd1NBaVVxSnNGdjB1dTZkd0U0a0JO?= =?utf-8?B?VGdWaVlLNzlmY2J5MXVCemtxL29aanJaWE81aHRiUDFTOEdMQStYRHhHa2lC?= =?utf-8?B?V0VUbjZoYmEzNVF4cHZHNUVCQTcrWG9EN2VVNE5PSW9PRTBqS2dkazJ6Ym1n?= =?utf-8?B?NnRWUTBuQUF5ckJLU2ZPSnNVd2tkSVl5YTM5blpsOXQ4L2x5KysraEptVVNw?= =?utf-8?B?K2s3NDBnSDR1NWgwdk4renMwMkpYNEJBUytLRDVWMXNveDVoMXNYMkgwdlJo?= =?utf-8?B?dlZ4ZHBnSnRpV2gxWDJqZXRvWTFic3VFKzk5b2FNS284WUUveGZJbzdZYStD?= =?utf-8?B?OE5GTEQ4VzdiQTlaUWtwcmc3QWhEd1A2YlFtQmtnbE9qY2o0alZaMDhpMW1L?= =?utf-8?Q?Mx9308FhTLLratfq3Vsr3nnNqL4CCQkgsRiXp1j?= X-MS-Exchange-CrossTenant-Network-Message-Id: ba9d2961-278b-4725-1e98-08d8de3bfcfd X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 12:00:50.4467 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DYT+4V973NdgLZ/NPQVNUONRkO20xDIoJvcmMkfsmurEgqbzG0OtPTYanFC76xyizSkbNT3Ue/29lBT1JVKw35hlF07WCNmdsqrzpPO1IwA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3622 X-OriginatorOrg: citrix.com On 03/03/2021 11:57, Roger Pau Monné wrote: > On Wed, Mar 03, 2021 at 11:46:44AM +0000, Andrew Cooper wrote: >> On 03/03/2021 08:33, Roger Pau Monne wrote: >>> This requires adding some logic in the build script in order to be >>> able to pass specific Xen Kconfig options. >>> >>> Setting any CONFIG_* environment variable when executing the build >>> script will set such variable in the empty .config file before >>> running the olddefconfig target. The .config file is also checked >>> afterwards to assert the option has not been lost as part of the >>> configuration process. >>> >>> Signed-off-by: Roger Pau Monné >>> --- >>> Cc: Jan Beulich >>> --- >>> Not sure whether there's some easiest way to force a config option to >>> a set value from the command line. >> I'm -2 to this.  We've already use thousands of machine minutes per >> push, and this corner case isn't worth adding another 30 minutes or so >> per push. > In fact I think those builds could be hypervisor only, which will > limit them to a couple of minutes? > > Would that be an acceptable compromise? > > Not just to test NR_CPUS, but in general for testing specific Kconfg > options. > > Likely randconfig should also be an hypervisor build only, there's no > reason to do a build test of the tools with a hypervisor randconfig. > Let me prepare a patch for that. This is already a plan for the CI working group (along with other randconfig improvements) but it has yet to be implemented. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Mar 03 13:29:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 13:29:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92841.175026 (Exim 4.92) (envelope-from ) id 1lHRYX-0006CB-Rv; Wed, 03 Mar 2021 13:28:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92841.175026; Wed, 03 Mar 2021 13:28:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHRYX-0006C4-Oq; Wed, 03 Mar 2021 13:28:49 +0000 Received: by outflank-mailman (input) for mailman id 92841; Wed, 03 Mar 2021 13:28:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHRYV-0006Bw-MN; Wed, 03 Mar 2021 13:28:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHRYV-0000ok-Gn; Wed, 03 Mar 2021 13:28:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHRYV-0007pX-67; Wed, 03 Mar 2021 13:28:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHRYV-0000ub-5a; Wed, 03 Mar 2021 13:28:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bJxTfnXO6U+lCO/X2eorWlELB026jA+PGESGdnhkVWs=; b=EHRGpZVxEWpr+e4KwntNG45zL7 429Wbgl2Yyfq7/7DEJTKHfV+qUnNbsHLTYSAE6J5bE83Bj/q0CZMu8HTJjggfjcmYJUkTy3UKwhVH yvLmoNK3NLs8/qGcfgy4NJgT5puxQ3rf+4gopf0IbJ46pjma8L9ysVT+F8LEhibFm3Mo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159810: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=cbcf09872a936ccefef6a34298046d3b9aefc148 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Wed, 03 Mar 2021 13:28:47 +0000 flight 159810 qemu-mainline real [real] flight 159816 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159810/ http://logs.test-lab.xenproject.org/osstest/logs/159816/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu cbcf09872a936ccefef6a34298046d3b9aefc148 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 195 days Failing since 152659 2020-08-21 14:07:39 Z 193 days 374 attempts Testing same since 159810 2021-03-03 00:37:02 Z 0 days 1 attempts ------------------------------------------------------------ 428 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 118088 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 03 13:41:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 13:41:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92849.175041 (Exim 4.92) (envelope-from ) id 1lHRks-0008Bv-3i; Wed, 03 Mar 2021 13:41:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92849.175041; Wed, 03 Mar 2021 13:41:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHRkr-0008Bo-W7; Wed, 03 Mar 2021 13:41:33 +0000 Received: by outflank-mailman (input) for mailman id 92849; Wed, 03 Mar 2021 13:41:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHRkr-0008Bj-14 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 13:41:33 +0000 Received: from mail-qv1-xf29.google.com (unknown [2607:f8b0:4864:20::f29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4582f87e-b412-4d67-bedf-46f4583d382a; Wed, 03 Mar 2021 13:41:32 +0000 (UTC) Received: by mail-qv1-xf29.google.com with SMTP id r5so11614270qvv.9 for ; Wed, 03 Mar 2021 05:41:32 -0800 (PST) Received: from FED-nrosbr-BE.crux.rad.ainfosec.com (209-217-208-226.northland.net. [209.217.208.226]) by smtp.gmail.com with ESMTPSA id n5sm11450708qkp.133.2021.03.03.05.41.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Mar 2021 05:41:31 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4582f87e-b412-4d67-bedf-46f4583d382a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=whEpbR7WTbtRDMaD+RUjMVHegptTMi8I2/fBd5p79hQ=; b=gKarmlPK8ZldDK+R56MY4YjAAzNvVeGqNKLHPM5yqK8czmX7ScgPXP8wQsbM2e8K3S SVkpqP4dC4aYeTyGQYrTqyu54I94/dfi656SV19KXeNnkWDWp73wC+rOMSHOVtjmuZb+ Yzms0wMxRK4c73kGflkqSNXMrAAEsEUMnU4b4QYNFf4R/scDpdAVmdoGeH9ZWAA5y6ih ma7MJYJKp0rn3TObm/33q6U5yMCDOQ4ps6bFqacc0oH0iXCktgxbwpCr/lE2rZaH2qQk kUPOogXUjYY/sGNPKuDKqqTuLvlS9Sacnlno80Rw+pm7Ih81TpvyR5927WIh+KkjFowu nBiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=whEpbR7WTbtRDMaD+RUjMVHegptTMi8I2/fBd5p79hQ=; b=MF/xw1K7qo7eq+nBmW5rTfOH9ajh5h/yfYVoI62/drMnsBUpc8SO31YqFQ+xfc85MX vLURVnHLXmIxmaoxtQPNA/oqCgCTwiX9CUHn6Y9XThZFt1PjvKc/JFCnE9TB81k1LAxG L8kVvXrckAcJW45aNp7Fsx2fcLJAzMBv9T+YTdaywdf7bMGMvs0IXC6kum8HMlvSlD1i RaOIL0RD0zkVZ80METTJ8sy2xEbk4Kmszo0h7MnYjb84jU3hrKGg2O5FgCcsg/vjUHuW UqO0o7aypREUbDjcvDXV668vBAOW7uhKhwS95VhJXv+tY+OYhRa4p8dto2UmVEPUFvkt cENw== X-Gm-Message-State: AOAM531ZfTX04ZnRMeSwENMl2+0x4s50xJl/NArvu/tJ2VzaY2i9LpJ+ JYvST//U9ughjfwUlLeuS0c= X-Google-Smtp-Source: ABdhPJxHiw+hVs6DHqlSXtEPTn30G2zZsJ9TL2FN+VBV6ypZexgoNkPFvAhz6y8XQk+/59TLNfA0bA== X-Received: by 2002:a05:6214:194f:: with SMTP id q15mr24786748qvk.46.1614778891756; Wed, 03 Mar 2021 05:41:31 -0800 (PST) Date: Wed, 3 Mar 2021 08:41:28 -0500 From: Nick Rosbrook To: Ian Jackson Cc: xen-devel@lists.xenproject.org, george.dunlap@citrix.com, Nick Rosbrook , Wei Liu , Anthony PERARD Subject: Re: [RFC v2 0/7] add function support to IDL Message-ID: References: <24639.23378.722148.653250@mariner.uk.xensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24639.23378.722148.653250@mariner.uk.xensource.com> On Wed, Mar 03, 2021 at 09:48:02AM +0000, Ian Jackson wrote: > Nick Rosbrook writes ("[RFC v2 0/7] add function support to IDL"): > > At a Xen Summit design session for the golang bindings (see [1]), we > > agreed that it would be beneficial to expand the libxl IDL with function > > support. In addition to benefiting libxl itself, this would allow other > > language bindings to easily generate function wrappers. > > > > The first version of this RFC is quite old [1]. I did address comments > > on the original RFC, but also expanded the scope a bit. As a way to > > evaluate function support, I worked on using this addition to the IDL to > > generate device add/remove/destroy functions, and removing the > > corresponding macros in libxl_internal.h. However, I stopped short of > > actually completing a build with this in place, as I thought it made > > sense to get feedback on the idea before working on the next step. > > This is exciting! I hope to find time to look at it, but I'm the > release manager for Xen 4.15 and that's taking most of my time right > now. Of course, I understand. Thank you for expressing interest, I look forward to hearing your thoughts when time permits. Thanks, NR From xen-devel-bounces@lists.xenproject.org Wed Mar 03 14:34:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 14:34:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92854.175053 (Exim 4.92) (envelope-from ) id 1lHSZQ-0004r2-IR; Wed, 03 Mar 2021 14:33:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92854.175053; Wed, 03 Mar 2021 14:33:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHSZQ-0004qv-FL; Wed, 03 Mar 2021 14:33:48 +0000 Received: by outflank-mailman (input) for mailman id 92854; Wed, 03 Mar 2021 14:33:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHSZP-0004qq-1n for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 14:33:47 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ee3ff13c-ba6a-4695-b773-0f15a782219e; Wed, 03 Mar 2021 14:33:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee3ff13c-ba6a-4695-b773-0f15a782219e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614782025; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=5zpGPDdBdvPoacuMSXSL+Llo16lv3MIqiM9IqX+Tls4=; b=Uk1+SHRi999k8hdRKVlm8a9+JoPBHT5aeVzkWLUDTHUzgI+jIHnBPaPc xrkwqXeqd7hJPnKuiSc4Z9JDMBdEMaVeGf6NzE3GUEAO4Cbbf98DtMxs4 DBfzhx+03OYJ755zpVQGk/ICGvGC7s5OoR0j/yi2KCpWFzIhKUtI+hiQ0 Q=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 1egYPNoWOup/IkFR7UcOwAzErzjbMN9rhZqC0y1khIvA3V/k285mUkjYZz5VaDsyZN+CJ4bot6 k5JBW3RQjkT6WpwvkhbaEzBz9FNmdxyM13NXcF7fSzMpdPZfez6D8Aym6eGg/S+2V8szCWF8A8 BSYgs6VKF4ghL0K5CZMmhcr+1Q+hWuyZ3EVPN5Z2yAhWudcpd+dlTzJuVwJ5SxCK2B18JddfP+ PeXW+5v/KfeqifvJTXxuI1eCcbm2js7cIpKiBFMMIRrqmb69848h77c9GIWrmVjJRIqcFmQLdj TI8= X-SBRS: 5.2 X-MesageID: 38353694 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,220,1610427600"; d="scan'208";a="38353694" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n+eyvvvqoBhNROXe6B5c1fKN0AlIx52kbEan1JE/agVXt8hhzx4O2lPGgw/6cHiiUwyH1u3SoTcFFlgZ6W/GC4VEkZzGG2gKO70hzqQ2tQn6s7mH8Qi8sWYCNiWAbrNgKeKz5oMKsaVcXNUdfIE9GfM6ep69dChbNSKrczyFvLQyDIBUZXXLNHKUrd+8Omb5L6WeWw+zzRMRivuvtKesakNVQaLdptjELaN1n7VTcfyT73q1uBspFEDkJGgxNQUuigMnghy0i5rRxnyetnY8qE7yNiWZEfdWkDQdvQXdYf4/HDdcdCMBUaoJVoJRJxQuPBHhM/pZYiKia203jxScgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q5gijShhHPd5cTg9a+dSKZE64FiyKP6Lk5iwnZ8l7pM=; b=Bf2hAIx1ox08J8paDWMPAW7so4Bxb8eFNqqomfiVxI7p/Sblbdz0rZmdlhJqcPZmkKFGR5BpVSrrmWZk3bybHBlhZLBLwUUJQU/doW6eJ32wVsb6cicJOmmR4uJb0awG4rp6MuGkCpiiFazllLw/vS3yxi8a9YvKfIdHHYyP73z+G5U6icaFKwY+FHHinmBrwFcrnWAM7j99G5Ai9LoHU/IgXN+dwmirXPsucVrLezWEOYAGTdfhYbgr0FDbU5OOONOERPhXnAoCJ4MMDVMfM730zX7i4ZBtk9JfMYp9bDx49aPqRW3T63xEwxoRn3aabFGNEy6PrFVHWfEhG057ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q5gijShhHPd5cTg9a+dSKZE64FiyKP6Lk5iwnZ8l7pM=; b=hd1vK6kDq+2E1Cx2nXM7l743gJITjY7GP6T42eMnenHtUo8OVVJk8AfI9VENRkWN96d9YdA24+ZXHOaZcHYzGrOyX2MU37VrApguLai1aGenSpuTdxOYXMl0FI53VFWsIQ+Ey0OT2ePff7jcWaK48lqV0SD7iCro/4shAZTPthM= From: Roger Pau Monne To: CC: Roger Pau Monne , Doug Goldstein , Ian Jackson Subject: [PATCH for-4.15] automation: allow doing hypervisor only builds Date: Wed, 3 Mar 2021 15:33:16 +0100 Message-ID: <20210303143316.16840-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR1P264CA0022.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2f::9) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9c55d299-5384-40a6-f931-08d8de5156bf X-MS-TrafficTypeDiagnostic: DM6PR03MB3481: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /Z36JUMFkotM4XV/mH/EXMv80nL7b0ckFhfNJUwQu9id4Agix2jjIpyxFnKkUjMSgBVIiA8H9psulaFbI3P8y1qIbfTNC0CgnIygSqpuwPweKiIjGysW69DXamy9jUAlnDDYjX0HVuFXDZr9PedEatD3v8D3bOVferwsbZTTbMn5ranMq7579L3+IviVL0X/YC5GjeGH2BOIUpZ01s+DYDFeKoFSPxjYAYrD7e8zZiPu7IgrUpqj2YkJs3tKw7Rz16wD5hLJqiIa/yD/3e1Ra7/9SFSsdbN/x4AMnh47aK2G8Dlwk4c/YLTTqcwrqLDbf5U0J8GCdXPs+FJlcEJO9sLVMZWjBqrvJ/IutLO27dBBQ+HuzR9BeMkuHinFXkL1a/SVj++dOuokIPYG4NeAS20hfnDhDXPVZAOuFC9ypXakxe8yKLwzAqZd/0myMnvXiPIMvNagK79oWisE0KDOP3lKE7lVzCaxOOnI1XUJlpA8f/8nzvkvxrjS0PfCLyGO+2ghv62KeCWmmCt9ze/2gMGrF13lEj7Jk8WsE9Vmi0e1YGibHRzOfGNs1F3enLFGJzuPTQIDcHqO4yNVf62FisZQJPYgsNj8h78Ee/r8WH0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(366004)(396003)(346002)(136003)(83380400001)(5660300002)(6916009)(1076003)(54906003)(478600001)(66556008)(36756003)(8676002)(6496006)(66476007)(66946007)(6666004)(26005)(8936002)(186003)(86362001)(6486002)(956004)(966005)(2616005)(4326008)(2906002)(316002)(16526019);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VkpBUnd2QnJyQmE4K2g0Rm1QUVlNOHJpMEJBZGNCSFdxZXhFVnpYOWdqRk4x?= =?utf-8?B?TzJoMWk1K0I0eTFOcnkrYkMrRHhCVkZHa3p2K1A3NlRvY3JoSlFVS0RCbDl2?= =?utf-8?B?YXRPaTJKb1RpZWlJNjlMWTBuaUhydVN0VC9DdnBrQjJYNDNKUzVyVS9XMUpK?= =?utf-8?B?M3A0ZysrRlJQcUZvQlZORjBRZjZJcTBsZ1Y5SzFtaWRTb3Y5VklQTFhKRjlV?= =?utf-8?B?d1lnQ0w2UTBTUzdua0tlYVo0UVJBL0h2aUpROUFvNGhISzlNSTRSbXJTMXV6?= =?utf-8?B?eXFNd1I2QnJ5cUhJSllQaDErOWpoelRNUStpb0UxR2FsOVR0VzYzb0J0WE0r?= =?utf-8?B?ZDd0NUhrSUh4MVEyVEtDSUcyRG1VL2g4eDZ5MEQ2eGorYVlJeGVqRXpLZFIx?= =?utf-8?B?TG9wMW9jRXVjSWNnc0YxbDFYdHBKazlnR2d6Ui9aUllSZGFZWGloZ1BVYlh5?= =?utf-8?B?NnJkK0xDV0ZuSkV0K2dOUmVzcUU3ekZoUU9iTWFmWlJ2aVl6ZXRYZjlmWk8w?= =?utf-8?B?NjlvK3ptc2krRU83TWZpNEdNSnhDOWxSdkYwMGNISFVoSkllTnBzQUVuNVhm?= =?utf-8?B?cFRWbWh6NVl6MW8zcUJFY3BmRXhoeXJmdUo4NDVXTnJwSFk3VnJqTVUydUZn?= =?utf-8?B?K296QXRib3ZLVm1zS2JCWFdKTnNYWkRXelY2UE9BUlZObnVXYXYxLytOTjl1?= =?utf-8?B?RUh0WGtvdGZYSFlhRVhZelJxUm1nNTJJc1AwMUp5Sno0M1dSdHpGL1VXWW1k?= =?utf-8?B?QjBvejJPRnZKNmtkZVZRVjBVVGkxL0liTmkxQkdCVHowREJ4UlhDSGtEWlRH?= =?utf-8?B?bHFJZjBZOC9ydEdERGNtUlNubmRKT1ByYXVuMmk0cFg2QzU2c0JIUXNZWGEr?= =?utf-8?B?Rk41VXZVNWJOMUJxVkgrQWVWclJtMFRVZXhZeE5sTFBhdlZFZEIvTEpDVG1y?= =?utf-8?B?bjZ1WkI5MEJPYVRHSWZldVBLVzJ6TG1aY2g4OGFzZkZTaDlLVlBXMmJtcE1P?= =?utf-8?B?Wm9kOHl2aVdHVWJnR1phSmJWaDNSMmlDd3Q4dUpjMTU3VXhOaDNVRS8wWUth?= =?utf-8?B?VUJjWnVWQ2ViVGFnY1lhcmZZcGdSTUxDOTZGTTVEZURBMHBaSTlIV2w3REJK?= =?utf-8?B?cGxoaVUvdkRhVnFDR3k2TVFDTTk4Z09BYnhLN0xVZlZDN0IxS3RMZG95V3NG?= =?utf-8?B?Y3ZYVXF1NGlpcjdncjczYXpuVkhQZm9JazRrc2U5blMwU3A0djVZN3ZsMjd1?= =?utf-8?B?cmJ2L0dFVXpqeXg1T29KZ0JhcHhBN3M2TWExRW1YQVRnWmxJb2NvUjJ0Vjl1?= =?utf-8?B?NkFWd1kzdkpwRWMzLy85NE43REluU3A3Y0J3Q0g2OXIyNW44bkRqQ3JjZFVT?= =?utf-8?B?MVAraVRMWnQ2bXhDdVVSQ21jMndoK01pRWU2b2pNTE5DYzIyQjBOb00wQ3RP?= =?utf-8?B?WjZHWnBQSGJBVjFMZDhvVXBLaWxxcGl2a2ZURHQvSWxMOWlGZDRmMTVkTUk5?= =?utf-8?B?Ky9kTDlmWFFydWhIUFEycnl3UDMrcW9VUGNuQXZSQWJGbm0zSjY3ZXJJenAy?= =?utf-8?B?Q1Z3d2pYTjc0Y0RkeWlTTGFTNUJhUnFVT0Q5R1pmTEYrcG8vWFcyc1NZTTNi?= =?utf-8?B?L1hNMEdxZFhkdFB1QkJyQmtrU2FnZThqK1dlNFhiTXIyOVU1RDVZVE45Sjc2?= =?utf-8?B?cENnNi9qcm9xdlZHK0tQWGFnQUVZZ25vUGZiQlhEOGp2OVhSNTlGOWFUMzlu?= =?utf-8?Q?Bln+QO0k6YWPjB35eUvoLgzQFV/CmUbpvcJigsI?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9c55d299-5384-40a6-f931-08d8de5156bf X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 14:33:40.3995 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JYx1xs+Erb8RmCPb4GPW/ZWU3Ckiw+pTA+fvSiXmL5lA0BPjwoKZWL9uk/Bq3HxEj0VX5QupmAbgitCx/82FZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3481 X-OriginatorOrg: citrix.com For things like randconfig there's no need to do a full Xen build, a hypervisor build only will be much faster and will achieve the same level of testing, as randconfig only changes the hypervisor build options. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson I think it might be good to get this in ASAP in order to reduce the load of the gitlab CI loop. Release wise the worse that could happen is that gitlab testing is broken by this, but I've already done a run myself: https://gitlab.com/xen-project/people/royger/xen/-/pipelines/264757821 --- automation/scripts/build | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/automation/scripts/build b/automation/scripts/build index 87e44bb940..1b752edfe6 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -11,6 +11,7 @@ cc-ver() # random config or default config if [[ "${RANDCONFIG}" == "y" ]]; then make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig + hypervisor_only="y" else make -j$(nproc) -C xen defconfig fi @@ -45,16 +46,27 @@ if [[ "${CC}" == "gcc" && `cc-ver` -lt 0x040600 ]]; then cfgargs+=("--with-system-seabios=/bin/false") fi -./configure "${cfgargs[@]}" - -make -j$(nproc) dist +if [[ "${hypervisor_only}" == "y" ]]; then + make -j$(nproc) xen +else + ./configure "${cfgargs[@]}" + make -j$(nproc) dist +fi # Extract artifacts to avoid getting rewritten by customised builds cp xen/.config xen-config mkdir binaries if [[ "${XEN_TARGET_ARCH}" != "x86_32" ]]; then cp xen/xen binaries/xen - cp -r dist binaries/ + if [[ "${hypervisor_only}" != "y" ]]; then + cp -r dist binaries/ + fi +fi + +if [[ "${hypervisor_only}" == "y" ]]; then + # If we are build testing a specific Kconfig exit now, there's no point in + # testing all the possible configs. + exit 0 fi # Build all the configs we care about -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 14:47:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 14:47:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92859.175065 (Exim 4.92) (envelope-from ) id 1lHSmk-0005zB-QW; Wed, 03 Mar 2021 14:47:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92859.175065; Wed, 03 Mar 2021 14:47:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHSmk-0005z4-NO; Wed, 03 Mar 2021 14:47:34 +0000 Received: by outflank-mailman (input) for mailman id 92859; Wed, 03 Mar 2021 14:47:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHSmj-0005yz-D1 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 14:47:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHSmj-000290-95 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 14:47:33 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHSmj-0004tH-81 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 14:47:33 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHSmf-0002Jc-Sv; Wed, 03 Mar 2021 14:47:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=Ot4Yx/xN/Ozx9OX9CMmq+oFuLVqtAULwfs6UtmfkIXw=; b=2NBYccBzEcSzAxPfxDgxzOFHb2 EePnRH1cHEwb/bGmkc4GZAEByNkgVpmbbC9ntbJRCquQ07oubFlQyTJ4N1LTmiqd85B8bCszxLC3x xS0jYS7z/ArvB4E7Ak0UDLGMWHdiIdFn3C8CZuEumbbeSqMZH78b6ofxGvKw/da/F1yA=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24639.41345.637093.963846@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 14:47:29 +0000 To: Roger Pau Monne Cc: , Doug Goldstein , Ian Jackson Subject: Re: [PATCH for-4.15] automation: allow doing hypervisor only builds In-Reply-To: <20210303143316.16840-1-roger.pau@citrix.com> References: <20210303143316.16840-1-roger.pau@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monne writes ("[PATCH for-4.15] automation: allow doing hypervisor only builds"): > For things like randconfig there's no need to do a full Xen build, a > hypervisor build only will be much faster and will achieve the same > level of testing, as randconfig only changes the hypervisor build > options. > > Signed-off-by: Roger Pau Monn > --- > Cc: Ian Jackson > I think it might be good to get this in ASAP in order to reduce the > load of the gitlab CI loop. > > Release wise the worse that could happen is that gitlab testing is > broken by this, but I've already done a run myself: Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Wed Mar 03 15:17:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 15:17:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92864.175077 (Exim 4.92) (envelope-from ) id 1lHTFB-0000cF-8E; Wed, 03 Mar 2021 15:16:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92864.175077; Wed, 03 Mar 2021 15:16:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHTFB-0000c8-5B; Wed, 03 Mar 2021 15:16:57 +0000 Received: by outflank-mailman (input) for mailman id 92864; Wed, 03 Mar 2021 15:16:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHTF9-0000c0-SU; Wed, 03 Mar 2021 15:16:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHTF9-0002dJ-Jl; Wed, 03 Mar 2021 15:16:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHTF9-00042m-7i; Wed, 03 Mar 2021 15:16:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHTF9-0005E3-73; Wed, 03 Mar 2021 15:16:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LBtdvWHyGuGrLa1Bisr6ajcW9hjwpiQJ2VuoYy5sOBQ=; b=MA/BxZBiP5KjQ7fMjT3tE29b7H Xc67voRZmWm2FndV5qGONWI896vq5vUC31hG9ZNpQbW+mRNrxObrs1DcVH2B4TUCQhnZ7uI/qscF4 78f7VFGvU4qX2XVAnQY7cU40+kVfZpLirKWsCyJdShYbGmFoFjGaWNSovGWwah4lB9j0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159811: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f69d02e37a85645aa90d18cacfff36dba370f797 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Wed, 03 Mar 2021 15:16:55 +0000 flight 159811 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159811/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux f69d02e37a85645aa90d18cacfff36dba370f797 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 214 days Failing since 152366 2020-08-01 20:49:34 Z 213 days 370 attempts Testing same since 159811 2021-03-03 03:12:26 Z 0 days 1 attempts ------------------------------------------------------------ 5136 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1271901 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 03 15:31:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 15:31:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92872.175092 (Exim 4.92) (envelope-from ) id 1lHTTX-0002dJ-RV; Wed, 03 Mar 2021 15:31:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92872.175092; Wed, 03 Mar 2021 15:31:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHTTX-0002dC-OH; Wed, 03 Mar 2021 15:31:47 +0000 Received: by outflank-mailman (input) for mailman id 92872; Wed, 03 Mar 2021 15:31:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHTTV-0002d7-WA for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 15:31:46 +0000 Received: from mail-pf1-x42b.google.com (unknown [2607:f8b0:4864:20::42b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6553670c-8a9f-482d-8d5a-29de82ceef80; Wed, 03 Mar 2021 15:31:45 +0000 (UTC) Received: by mail-pf1-x42b.google.com with SMTP id 192so9508933pfv.0 for ; Wed, 03 Mar 2021 07:31:45 -0800 (PST) Received: from localhost.localdomain ([2400:4050:c360:8200:5c52:1484:d5e9:8785]) by smtp.gmail.com with ESMTPSA id j125sm26705574pfd.27.2021.03.03.07.31.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Mar 2021 07:31:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6553670c-8a9f-482d-8d5a-29de82ceef80 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HzvFVW88qJpeaN3PjiFjAaeml33FklJwImSBaghimzw=; b=LmLXlOEuOBa4KXlpnGJDtuvGZ971Oqx6hQRwB4XSUkkxWqzDIoB7O8AQl1wDiE5Aet zkCL89ORXECWQgF1ayZ2reO0+zlL7Qv7obWd3Cxl0FbY4XNBFxgX9IrnfDamhGRE2fd9 D4Xqjf+xyZdnuMd90P0xPKt0p74ihOEtINjlEB1ozccXUihPdad5Nj4HoV7wMW0Eh0YI EHbYePWrmKeZ8RW00MQleXUpJPh5xh8KrzJvsn65/TG3SWJXzGNrIrycNZ1B5cS+M1VA C1Mum6jEW8zQjWMO6DXEldM/xNEUoEqFFyRh2R1HY4CAqUPB3ytAAmlJR91b2JFuaTmj KN8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HzvFVW88qJpeaN3PjiFjAaeml33FklJwImSBaghimzw=; b=sOyEFRVrbFuMFu1whg1nu/bLNIVWbpeUijJ9hDZgxagK6YPA+HxCiNT+3Dp0SkA6vx bg5R/zLUeOJDMqPPwp6CGknmBcrBcrllaqlnXRzdI705uockCn/XZgswdBge6CUYOqSV Gb1yRhiN1JkLMay3xMRkyN8jJEu57Xp9nWSefUM1v9go8vTHtiOprk/JW+bWsMcEFbTq UBZ+WsqQz1pTXG0vUTLJDteENz878D/LmXljZsinAupFX57yKi2te7j31SyX0sRAyHg9 2suMKse5MU7An8D51n5iI0INqGb6KLJ6OtrL9f0csTK7usKIQFTgp0tzhWw4OIKw8g69 lPCw== X-Gm-Message-State: AOAM531xG1g7lxsxpvlOlW3Omy1AvrSoRtimkGemOuINYIa0mOLti1vd d6PzlkBRtQUjPipKYF1a9Vc= X-Google-Smtp-Source: ABdhPJz2v3aiEl2W3d0pgwVGvm8Dt1xQchoU1/bnxxhnp3Q7IZdvIzzh69s+bt6Jt50r+ED8MnBvXA== X-Received: by 2002:a05:6a00:14d5:b029:1ec:c5e5:6041 with SMTP id w21-20020a056a0014d5b02901ecc5e56041mr24355361pfu.36.1614785504405; Wed, 03 Mar 2021 07:31:44 -0800 (PST) From: Akihiko Odaki To: Cc: qemu Developers , xen-devel@lists.xenproject.org, Gerd Hoffmann , "Michael S . Tsirkin" , Stefano Stabellini , Anthony Perard , Paul Durrant , Akihiko Odaki Subject: [PATCH v2 1/2] edid: Make refresh rate configurable Date: Thu, 4 Mar 2021 00:29:47 +0900 Message-Id: <20210303152948.59943-1-akihiko.odaki@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Akihiko Odaki --- hw/display/edid-generate.c | 9 +++++---- include/hw/display/edid.h | 12 +++++++----- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/hw/display/edid-generate.c b/hw/display/edid-generate.c index 1665b7cbb29..b0ce583d436 100644 --- a/hw/display/edid-generate.c +++ b/hw/display/edid-generate.c @@ -203,7 +203,7 @@ static void edid_desc_dummy(uint8_t *desc) edid_desc_type(desc, 0x10); } -static void edid_desc_timing(uint8_t *desc, +static void edid_desc_timing(uint8_t *desc, uint32_t refresh_rate, uint32_t xres, uint32_t yres, uint32_t xmm, uint32_t ymm) { @@ -216,9 +216,9 @@ static void edid_desc_timing(uint8_t *desc, uint32_t ysync = yres * 5 / 1000; uint32_t yblank = yres * 35 / 1000; - uint32_t clock = 75 * (xres + xblank) * (yres + yblank); + uint64_t clock = (uint64_t)refresh_rate * (xres + xblank) * (yres + yblank); - stl_le_p(desc, clock / 10000); + stl_le_p(desc, clock / 10000000); desc[2] = xres & 0xff; desc[3] = xblank & 0xff; @@ -303,6 +303,7 @@ void qemu_edid_generate(uint8_t *edid, size_t size, uint8_t *xtra3 = NULL; uint8_t *dta = NULL; uint32_t width_mm, height_mm; + uint32_t refresh_rate = info->refresh_rate ? info->refresh_rate : 75000; uint32_t dpi = 100; /* if no width_mm/height_mm */ /* =============== set defaults =============== */ @@ -400,7 +401,7 @@ void qemu_edid_generate(uint8_t *edid, size_t size, /* =============== descriptor blocks =============== */ - edid_desc_timing(edid + desc, info->prefx, info->prefy, + edid_desc_timing(edid + desc, refresh_rate, info->prefx, info->prefy, width_mm, height_mm); desc += 18; diff --git a/include/hw/display/edid.h b/include/hw/display/edid.h index 1f8fc9b3750..520f8ec2027 100644 --- a/include/hw/display/edid.h +++ b/include/hw/display/edid.h @@ -11,6 +11,7 @@ typedef struct qemu_edid_info { uint32_t prefy; uint32_t maxx; uint32_t maxy; + uint32_t refresh_rate; } qemu_edid_info; void qemu_edid_generate(uint8_t *edid, size_t size, @@ -21,10 +22,11 @@ void qemu_edid_region_io(MemoryRegion *region, Object *owner, uint32_t qemu_edid_dpi_to_mm(uint32_t dpi, uint32_t res); -#define DEFINE_EDID_PROPERTIES(_state, _edid_info) \ - DEFINE_PROP_UINT32("xres", _state, _edid_info.prefx, 0), \ - DEFINE_PROP_UINT32("yres", _state, _edid_info.prefy, 0), \ - DEFINE_PROP_UINT32("xmax", _state, _edid_info.maxx, 0), \ - DEFINE_PROP_UINT32("ymax", _state, _edid_info.maxy, 0) +#define DEFINE_EDID_PROPERTIES(_state, _edid_info) \ + DEFINE_PROP_UINT32("xres", _state, _edid_info.prefx, 0), \ + DEFINE_PROP_UINT32("yres", _state, _edid_info.prefy, 0), \ + DEFINE_PROP_UINT32("xmax", _state, _edid_info.maxx, 0), \ + DEFINE_PROP_UINT32("ymax", _state, _edid_info.maxy, 0), \ + DEFINE_PROP_UINT32("refresh_rate", _state, _edid_info.refresh_rate, 0) #endif /* EDID_H */ -- 2.24.3 (Apple Git-128) From xen-devel-bounces@lists.xenproject.org Wed Mar 03 15:31:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 15:31:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92873.175104 (Exim 4.92) (envelope-from ) id 1lHTTc-0002f8-3O; Wed, 03 Mar 2021 15:31:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92873.175104; Wed, 03 Mar 2021 15:31:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHTTc-0002f1-01; Wed, 03 Mar 2021 15:31:52 +0000 Received: by outflank-mailman (input) for mailman id 92873; Wed, 03 Mar 2021 15:31:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHTTa-0002d7-U3 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 15:31:50 +0000 Received: from mail-pj1-x1033.google.com (unknown [2607:f8b0:4864:20::1033]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 39a3335d-6d4d-4b61-a38f-0e7838884c2c; Wed, 03 Mar 2021 15:31:47 +0000 (UTC) Received: by mail-pj1-x1033.google.com with SMTP id e9so4560668pjj.0 for ; Wed, 03 Mar 2021 07:31:47 -0800 (PST) Received: from localhost.localdomain ([2400:4050:c360:8200:5c52:1484:d5e9:8785]) by smtp.gmail.com with ESMTPSA id j125sm26705574pfd.27.2021.03.03.07.31.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Mar 2021 07:31:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39a3335d-6d4d-4b61-a38f-0e7838884c2c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XZCD1gaPmOF4fzquo49Q5QPSu+gMDmYGiB+c2jR/sN0=; b=CtUmKjK1S+RM6N/iNxFStCDkvq12EIAiuobMiOj9wbSQkWHmAxGm/IRvAApX1eaZon xpVYpuA+S7C/WDK8U/5kmJJCHOKSGslTMnicLBOT/MaIN9IyrFt64tNDrAQjY4PiTgAU kdH3/0Cuv/WXbqE8zEnCDEzA05vmIPbu8u1CO1nDdgpTVNFQaeKVjnKCxA7wy0JzIrJc hb6/UmAqlidk7YUsdq5PPrcQPUoVvt6+rKMAAqnfS3DaHOvZiizvkVj5ZE7+PjYtnnZ/ fHvwsr0U1Yreotf83fiy4OtlqJDqtUKpVJ+P1ZuvGHZWfpphMNCNDFxluxZJdL7u/Zcu nuzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XZCD1gaPmOF4fzquo49Q5QPSu+gMDmYGiB+c2jR/sN0=; b=hsgUhXj9VliPvtIjliwCoii4MYAOpjY24kmYSJ3YStFGZ1wkfBJ+I//wJ+07lQ5Xox J5Ww+G6oIywlXjWhLQxv5M+Z7EqjQge9jqo70aEs7TfwqS9+HPTotN5einwWvtuhO/4N kutT2fm9g3OdyIajpx8mjwSTUJwb7FhIrwGfWt3M3uEGgoCQw3i1+jSOrxSpfkddGYe4 eXDuzsssLYlwb8CzrzDXhkOl4+0ALZmGGmkKpMA9z/cQs3y/ABSQph2Emwh3S5XNFLpa h72YcfKbOhwsZGvnTLpgkgG3WsFrc+qxOK6+q16qj05tvNQrvnLQLZP+j3wd5sVfh9C9 Ge7w== X-Gm-Message-State: AOAM532JSJqJzVYXAgBCw4oYb0gRGWqejO/LpwLxx6M7QWwDW5P5jD2F Vb9ZxvIvwhkWGEOZJGfW1Ao= X-Google-Smtp-Source: ABdhPJyn6dOKSQSF5oQeK4Oq3zDMfKyMb+LvXZkL2C7JkwipSshEm8XyxC3GXm/sPr/6CgfJsDnujw== X-Received: by 2002:a17:90a:9303:: with SMTP id p3mr9575355pjo.201.1614785507070; Wed, 03 Mar 2021 07:31:47 -0800 (PST) From: Akihiko Odaki To: Cc: qemu Developers , xen-devel@lists.xenproject.org, Gerd Hoffmann , "Michael S . Tsirkin" , Stefano Stabellini , Anthony Perard , Paul Durrant , Akihiko Odaki Subject: [PATCH v2 2/2] virtio-gpu: Respect UI refresh rate for EDID Date: Thu, 4 Mar 2021 00:29:48 +0900 Message-Id: <20210303152948.59943-2-akihiko.odaki@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20210303152948.59943-1-akihiko.odaki@gmail.com> References: <20210303152948.59943-1-akihiko.odaki@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This change adds a new member, refresh_rate to QemuUIInfo in include/ui/console.h. It represents the refresh rate of the physical display backend, and it is more appropriate than GUI update interval as the refresh rate which the emulated device reports: - sdl may set GUI update interval shorter than the refresh rate of the physical display to respond to user-generated events. - sdl and vnc aggressively changes GUI update interval, but a guests is typically not designed to respond to frequent refresh rate changes, or frequent "display mode" changes in general. The frequency of refresh rate changes of the physical display backend matches better to the guest's expectation. QemuUIInfo also has other members representing "display mode", which makes it suitable for refresh rate representation. It has a throttling of update notifications, and prevents frequent changes of the display mode. Signed-off-by: Akihiko Odaki --- hw/display/virtio-gpu-base.c | 1 + hw/display/virtio-gpu.c | 1 + hw/display/xenfb.c | 14 ++++++++--- include/hw/virtio/virtio-gpu.h | 1 + include/ui/console.h | 2 +- include/ui/gtk.h | 2 +- ui/console.c | 6 ----- ui/gtk-egl.c | 4 +-- ui/gtk.c | 45 ++++++++++++++++++++-------------- 9 files changed, 44 insertions(+), 32 deletions(-) diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c index 4a57350917c..86ed208d031 100644 --- a/hw/display/virtio-gpu-base.c +++ b/hw/display/virtio-gpu-base.c @@ -80,6 +80,7 @@ static int virtio_gpu_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info) g->req_state[idx].x = info->xoff; g->req_state[idx].y = info->yoff; + g->req_state[idx].refresh_rate = info->refresh_rate; g->req_state[idx].width = info->width; g->req_state[idx].height = info->height; g->req_state[idx].width_mm = info->width_mm; diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 2e4a9822b6a..eee22b18e8a 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -216,6 +216,7 @@ virtio_gpu_generate_edid(VirtIOGPU *g, int scanout, .height_mm = b->req_state[scanout].height_mm, .prefx = b->req_state[scanout].width, .prefy = b->req_state[scanout].height, + .refresh_rate = b->req_state[scanout].refresh_rate, }; edid->size = cpu_to_le32(sizeof(edid->edid)); diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index 838260b6ad1..a53341ef673 100644 --- a/hw/display/xenfb.c +++ b/hw/display/xenfb.c @@ -777,16 +777,24 @@ static void xenfb_update(void *opaque) xenfb->up_fullscreen = 0; } -static void xenfb_update_interval(void *opaque, uint64_t interval) +static void xenfb_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info) { struct XenFB *xenfb = opaque; + uint32_t refresh_rate; if (xenfb->feature_update) { #ifdef XENFB_TYPE_REFRESH_PERIOD if (xenfb_queue_full(xenfb)) { return; } - xenfb_send_refresh_period(xenfb, interval); + + refresh_rate = info->refresh_rate; + if (!refresh_rate) { + refresh_rate = 75; + } + + /* T = 1 / f = 1 [s*Hz] / f = 1000*1000 [ms*mHz] / f */ + xenfb_send_refresh_period(xenfb, 1000 * 1000 / refresh_rate); #endif } } @@ -983,5 +991,5 @@ struct XenDevOps xen_framebuffer_ops = { static const GraphicHwOps xenfb_ops = { .invalidate = xenfb_invalidate, .gfx_update = xenfb_update, - .update_interval = xenfb_update_interval, + .ui_info = xenfb_ui_info, }; diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h index fae149235c5..876c4a51a67 100644 --- a/include/hw/virtio/virtio-gpu.h +++ b/include/hw/virtio/virtio-gpu.h @@ -64,6 +64,7 @@ struct virtio_gpu_scanout { struct virtio_gpu_requested_state { uint16_t width_mm, height_mm; uint32_t width, height; + uint32_t refresh_rate; int x, y; }; diff --git a/include/ui/console.h b/include/ui/console.h index d30e972d0b5..6c4eb4df718 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -127,6 +127,7 @@ typedef struct QemuUIInfo { int yoff; uint32_t width; uint32_t height; + uint32_t refresh_rate; } QemuUIInfo; /* cursor data format is 32bit RGBA */ @@ -384,7 +385,6 @@ typedef struct GraphicHwOps { void (*gfx_update)(void *opaque); bool gfx_update_async; /* if true, calls graphic_hw_update_done() */ void (*text_update)(void *opaque, console_ch_t *text); - void (*update_interval)(void *opaque, uint64_t interval); int (*ui_info)(void *opaque, uint32_t head, QemuUIInfo *info); void (*gl_block)(void *opaque, bool block); void (*gl_flushed)(void *opaque); diff --git a/include/ui/gtk.h b/include/ui/gtk.h index 3c1cd98db8b..1fde553c0f0 100644 --- a/include/ui/gtk.h +++ b/include/ui/gtk.h @@ -87,7 +87,7 @@ extern bool gtk_use_gl_area; /* ui/gtk.c */ void gd_update_windowsize(VirtualConsole *vc); -int gd_monitor_update_interval(GtkWidget *widget); +void gd_update_monitor_refresh_rate(VirtualConsole *vc, GtkWidget *widget); /* ui/gtk-egl.c */ void gd_egl_init(VirtualConsole *vc); diff --git a/ui/console.c b/ui/console.c index c5d11bc7017..3f5a0c113e2 100644 --- a/ui/console.c +++ b/ui/console.c @@ -203,7 +203,6 @@ static void gui_update(void *opaque) uint64_t dcl_interval; DisplayState *ds = opaque; DisplayChangeListener *dcl; - QemuConsole *con; ds->refreshing = true; dpy_refresh(ds); @@ -218,11 +217,6 @@ static void gui_update(void *opaque) } if (ds->update_interval != interval) { ds->update_interval = interval; - QTAILQ_FOREACH(con, &consoles, next) { - if (con->hw_ops->update_interval) { - con->hw_ops->update_interval(con->hw, interval); - } - } trace_console_refresh(interval); } ds->last_update = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index 588e7b1bb19..1a32888e08b 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -116,8 +116,8 @@ void gd_egl_refresh(DisplayChangeListener *dcl) { VirtualConsole *vc = container_of(dcl, VirtualConsole, gfx.dcl); - vc->gfx.dcl.update_interval = gd_monitor_update_interval( - vc->window ? vc->window : vc->gfx.drawing_area); + gd_update_monitor_refresh_rate( + vc, vc->window ? vc->window : vc->gfx.drawing_area); if (!vc->gfx.esurface) { gd_egl_init(vc); diff --git a/ui/gtk.c b/ui/gtk.c index 79dc2401203..c3e20806877 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -726,11 +726,20 @@ static gboolean gd_window_close(GtkWidget *widget, GdkEvent *event, return TRUE; } -static void gd_set_ui_info(VirtualConsole *vc, gint width, gint height) +static void gd_set_ui_refresh_rate(VirtualConsole *vc, int refresh_rate) { QemuUIInfo info; - memset(&info, 0, sizeof(info)); + info = *dpy_get_ui_info(vc->gfx.dcl.con); + info.refresh_rate = refresh_rate; + dpy_set_ui_info(vc->gfx.dcl.con, &info); +} + +static void gd_set_ui_size(VirtualConsole *vc, gint width, gint height) +{ + QemuUIInfo info; + + info = *dpy_get_ui_info(vc->gfx.dcl.con); info.width = width; info.height = height; dpy_set_ui_info(vc->gfx.dcl.con, &info); @@ -754,33 +763,32 @@ static void gd_resize_event(GtkGLArea *area, { VirtualConsole *vc = (void *)opaque; - gd_set_ui_info(vc, width, height); + gd_set_ui_size(vc, width, height); } #endif -/* - * If available, return the update interval of the monitor in ms, - * else return 0 (the default update interval). - */ -int gd_monitor_update_interval(GtkWidget *widget) +void gd_update_monitor_refresh_rate(VirtualConsole *vc, GtkWidget *widget) { #ifdef GDK_VERSION_3_22 GdkWindow *win = gtk_widget_get_window(widget); + int refresh_rate; if (win) { GdkDisplay *dpy = gtk_widget_get_display(widget); GdkMonitor *monitor = gdk_display_get_monitor_at_window(dpy, win); - int refresh_rate = gdk_monitor_get_refresh_rate(monitor); /* [mHz] */ - - if (refresh_rate) { - /* T = 1 / f = 1 [s*Hz] / f = 1000*1000 [ms*mHz] / f */ - return MIN(1000 * 1000 / refresh_rate, - GUI_REFRESH_INTERVAL_DEFAULT); - } + refresh_rate = gdk_monitor_get_refresh_rate(monitor); /* [mHz] */ + } else { + refresh_rate = 0; } + + gd_set_ui_refresh_rate(vc, refresh_rate); + + /* T = 1 / f = 1 [s*Hz] / f = 1000*1000 [ms*mHz] / f */ + vc->gfx.dcl.update_interval = refresh_rate ? + MIN(1000 * 1000 / refresh_rate, GUI_REFRESH_INTERVAL_DEFAULT) : + GUI_REFRESH_INTERVAL_DEFAULT; #endif - return 0; } static gboolean gd_draw_event(GtkWidget *widget, cairo_t *cr, void *opaque) @@ -810,8 +818,7 @@ static gboolean gd_draw_event(GtkWidget *widget, cairo_t *cr, void *opaque) return FALSE; } - vc->gfx.dcl.update_interval = - gd_monitor_update_interval(vc->window ? vc->window : s->window); + gd_update_monitor_refresh_rate(vc, vc->window ? vc->window : s->window); fbw = surface_width(vc->gfx.ds); fbh = surface_height(vc->gfx.ds); @@ -1655,7 +1662,7 @@ static gboolean gd_configure(GtkWidget *widget, { VirtualConsole *vc = opaque; - gd_set_ui_info(vc, cfg->width, cfg->height); + gd_set_ui_size(vc, cfg->width, cfg->height); return FALSE; } -- 2.24.3 (Apple Git-128) From xen-devel-bounces@lists.xenproject.org Wed Mar 03 15:39:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 15:39:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92885.175115 (Exim 4.92) (envelope-from ) id 1lHTb0-00036y-Ub; Wed, 03 Mar 2021 15:39:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92885.175115; Wed, 03 Mar 2021 15:39:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHTb0-00036r-Ri; Wed, 03 Mar 2021 15:39:30 +0000 Received: by outflank-mailman (input) for mailman id 92885; Wed, 03 Mar 2021 15:39:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHTaz-00036m-Ab for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 15:39:29 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 86d6db25-f9a6-463d-ad70-44b21dd5eb80; Wed, 03 Mar 2021 15:39:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86d6db25-f9a6-463d-ad70-44b21dd5eb80 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614785967; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=5WqOM5a7AgG0CkA3zpuMcvBDUKpT/78Kaja3BhtQ+HE=; b=SU08M8SUKgLD4YJd9ngWuezC1/fNkwIAcJfiYE972smCgS8jPvqPH2/7 hvnxFo2Mt+6PgJhhxqWH09/J0tRZxY+8uld8EboiewJpDjQxbXeGxKKlX 0OpmPvz7v3yX0dQZd2EAlBAq+eVPWCUJCwIciQZ6+5N7rRjOuJfhXHDTO k=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: lO3lmTKz5xh03vy0Gh7lf9hYgXTeObTXGw6X5rOOPeQmcQuKnVkM96E6OEgxt3axzp2T9oq92T 3EVc7s++7bTXgzrLh9+NtsgDy+xXHoEd26fw+zDeIoTnJvTrzjHyD5tXKtxeiKiBjWSxBtLQor TPBKpbqz+2ANVZ3K4/uHKe0KYheiadOaiP35C6UBB3TX4uGWRVIVYqIFTHowH1oK1W1SwQzBgy gZTpMbvIP89fViUuAL1X5wnK9YWXIEH+WjhjMxBktpl95X47nrDydIy4vvjoXQIjAAd4t8YEvN fPY= X-SBRS: 5.2 X-MesageID: 39847576 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,220,1610427600"; d="scan'208";a="39847576" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VvswhddtmLDJaAoSnJHn7WRmK/JgzsTdrl5gVWVrKC7KUz4b9lt/UxA5zRAk25NeA6ZUo5FUZ93VgswD1Rg9qHcDUNUk3E1VpYsTIUKlQDwCia/p6kkxjAsoG/5QzJyZunvCsuCFHXRo6vXDpj0DjgZyicNLdvMQf7k+d+17Ndav7yaKwvuoy/xBdCBWsvRE/mn9qG4C9d0oaBJWljeWscFriZAzM8Xp193hjzcKN8x+YYMwL7/dBzjoTgVqIK1BR1/PbpRXv9cg3G2cL/N/XfNEGe1u8EqCT90pn9GlOBqiMmWPHC29aFOk5+lZ3B42CbdYdStQ0kZ+pSo/d84TRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eFkGrp1LEur/92qyuJerjH8KSSFT0YAAEpNUTFcxPgE=; b=HL2uaGW7Zw+pPN+dzb9P90qHzxq06b6AnPuOTlpbz75KNzyiVnkrFcVpO8ZiB3Ex6AeZacd92bntDyVlNQnDqzgxFnWgQjjItDByCujKbNpN3v2rMeylaq9amGlp+n7hjB6jmVnzCFkgCpueIYfdIVig/oJmxYviJ9IYDkXe2/dqJQyTsHmzIFoulyN4lnEgWt6xpogSs2dwXrjgkCgT9qKBYyhVc4ClQRW8zcHFBHOQn3ie2f+YeyiTD/7PT5h2d3DiXdTYdaERIvF9BUW++M8QbPo81uO2KCJwtl714l5gDHvYEfNMaBpNibtXVmmx5JPbTI/LYT1JFKPprpwMCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eFkGrp1LEur/92qyuJerjH8KSSFT0YAAEpNUTFcxPgE=; b=CorstVwFJG/WPNMSNaVK73KpIisg47HT5cYZcIf8mx4QMbwxAgZqDrDy5reVwsT0MKPzXBv7pyW7AdPwKqbw2CcXQSA0LFjtcGQo6uAxPyuTqkrQ1N56VHWXFJY/n5zB6GDtQzzGe8C60cnHGYFh/cd3h3uhKwGEGJNke5upq38= Date: Wed, 3 Mar 2021 16:38:33 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich , Andrew Cooper , Ian Jackson CC: Wei Liu , Anthony PERARD , Jun Nakajima , Kevin Tian , Boris Ostrovsky , Subject: Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection Message-ID: References: <20210301162357.76527-1-roger.pau@citrix.com> <62be2084-e5fa-e439-8426-6d129a10c379@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <62be2084-e5fa-e439-8426-6d129a10c379@suse.com> X-ClientProxiedBy: PR1PR01CA0019.eurprd01.prod.exchangelabs.com (2603:10a6:102::32) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6cca290f-6943-4df8-f912-08d8de5a6aad X-MS-TrafficTypeDiagnostic: DM6PR03MB4843: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zMCJdoUQgVfS0PgweYf0xOAe8kxIvxTidB6mLnKjk0ciOT1FNrTOuvWyqgV0U1VatudGCFQqktL50P/S/E5id0EA1LV/8rtMKJ2PK+DmXHLtrl3mG68wN0KxEzbBzGbbTndt2ZmKUoyli/g2ukI+kEif//rJ3hEcQY0Ngqv8F3ONHC3acHeQbBJGYBrDW9cPQK1AEH1jNk1bhmJ3jZOS06o/1CxaYQa+7iuih4njKXdd1OjlfLJMdzBvrwJ4iGnOdWMpJVvd8vIbz/jbO38O0Z/puDtm4/LJ23qFYn1olVZK7olqxiAfVqjWs4AVZamIl0v/387Xj+iZQ3xM7z67pDey8hBCurokJWYX2F7nOWQjzm/5Qa05qRroJxQqpx0MeYEbK1HEiQQ8Naifh54jAjZogtt8mv5lEy/b1UpkLUjnTYvmu0besodCcmyMgl7FbAIE+VIst2a0KhCsf2Q7z2cOCEIG1dMI1n111KRAYkIKAndvBmaS3LwT2AhP33jSA6Ng3EFhhYJ+B/bEsXzrPNXWJXUo9uecfN2Ilq3Pc+PIvEZ9iieCVTHYql6OSc6NSC+AD/cFppa/OXW7OlXxqU2dA0GJHdCMyu10SnCmYDijz44ojZPCKYk0V5H0e/FEUvF0Y26UnPcGakWRSSKmNQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(136003)(346002)(39860400002)(376002)(366004)(396003)(110136005)(5660300002)(316002)(186003)(8676002)(66476007)(83380400001)(6666004)(8936002)(86362001)(53546011)(26005)(16526019)(54906003)(6496006)(4326008)(956004)(9686003)(85182001)(66946007)(2906002)(478600001)(966005)(33716001)(66556008)(6486002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?blp3Njdic3lIUVYrclBCNEtZcmkzYjRRcnl3SnZHd3RvZTBjSDA5YjRmbmRV?= =?utf-8?B?SE9uSDhWRERxQVR2WnVOYzkzcUNtdWU3WkhwSzZRQWxuU3NwcHE4NElsODdQ?= =?utf-8?B?TUNzZnZ3b0h5aTEyVjNubU5hbmFWOVUwT2tyUlBnc2F5eE1LRGc1cHZFY29u?= =?utf-8?B?MEx5elBVeDd5N1FlNUNNdlRnTS91TVYycjVEZHhTRkYrbHpha1lXby9BaGt6?= =?utf-8?B?MUZlMGtTUWV4QUlqU2dwbXJ1ZnRPWmNyUnRCdERxUzVNYW1Xd1lmbWo2TzNi?= =?utf-8?B?bm1Id2Zyb0t6ZFc2Qy9VS2ZoWFRKRU1weC8ybktPVVFINTh1UkErNjc2c0Uz?= =?utf-8?B?YWdna0ZqZzJCQmQ2bzhWWWFTUS82YVk0eHVTNEkyZVlZSWFZV1NxUXFMMW55?= =?utf-8?B?OVM5OHIzRFRYTXhZT0F6eDBiUzJVMTdUWWZGOTduMzJ0VHZNZUlJS3ZtczBs?= =?utf-8?B?NFdmUHZBU0hxTytmRlFWSTY5NkxnZGhsQnd0cm5VNnY4YXRGRTVoaDljVE9T?= =?utf-8?B?Q0J3M0VsdWdUOWV1aUY0WUlLWG9GbjM2UjVwOG9teGVlNnRLNzN3K01nbERx?= =?utf-8?B?akdyTE1GWGxOQVk0bUhZUXQ3QUJ2VkRiTXhxcElUWEVNMGd4QVZQRHR2N1dP?= =?utf-8?B?ZDduSllqUXNKU2krZnVOUC8xN0tkclRRUnpWMlBFS0J0d2ZqU3NETTNNOXpP?= =?utf-8?B?WjhEZTlzVVlmWmNXNURiTkhPZEJCNlIzZUdQWVZ5dW56b0FKNW04RmtMRm9h?= =?utf-8?B?RVdISFVCZHBYWGFIOG54ZFpJUnFBUm9uSWlVSkE0OEllc2xVUVV4WWZMODRV?= =?utf-8?B?VXorRzRoU3k4a0k5RDVDRm04Y1VLVGxlNVdHT1NPcTl0R3EzMy9jRzMxQW5n?= =?utf-8?B?N05WTE5NOFlOcU5EaDFFMmVnTXozcHlOZm5OVFhpbEFsa0lZdklDTkEvQ2dw?= =?utf-8?B?N3lWWVYxeEdXTEdzSEE4OXRuT3N4WWFjWmkvZW5UWFNqM2J6Q0h3MXpxU011?= =?utf-8?B?VlMwUkp4c2c1SC8zS3o5N3FaU2VLamdNMnh4Vy9aNUdRdlVHWXBXSHdaNzdG?= =?utf-8?B?cWJOTU54MjdzclgzMGdBNEVPQ1h6aVNYL1NCVVkzcXdaVnFtWEtqWXI4WEd3?= =?utf-8?B?V09MbC91M0hYZnBqM3ZYL0k5ZzBDdmVKT1NsVzVoYy8xWFhGdXkwMXM3eXFi?= =?utf-8?B?WEloK3dkSjUwZElZb1Y5dksrVXZGckkzNVN6RSt2TGdDNVpVcVRLNUlQUVN3?= =?utf-8?B?MTRjUGs2R2RKdTBmVmRGdGZkTnR2T1hLd0wvampoSHJRUDhxeTkzZFl4OVFC?= =?utf-8?B?emRnLzUzcTVMcHBMeHBGTW1abFd3d3hKSjF5UElESTdIVjMvSGVLcFlWK1VI?= =?utf-8?B?eVdyaXlPbGp4K0Z4OVVxVEx5azdTTms4bGx4V0JWZUxYVXcwbGdadE4wNGpy?= =?utf-8?B?WmhoRjNLVTZwM1Frc3VlQVdDZ0hMWUs0NnJRbGVjdjd3TStWbEwxSHZ0L1N2?= =?utf-8?B?MHJtSzdOU2JiZDM0VTVrSmdKSFpnQUxhaEk3V25SWVJNU0hpWnNnNWlmYmZJ?= =?utf-8?B?NVJvSDhhaEZQMUJLdTc0VnlLYXpCd29ZMzgxM0dNL09CV25vWXc2a1BOOXd4?= =?utf-8?B?UklFQjBobzl2U0dtU0lDQlJ5UVVCajNKYnduZjR2UkFIODlqMEZuSE85YkV6?= =?utf-8?B?U1ljc21pRGZBOThyT0JrbDYrVmRvV0NycEdJbFJtY3dsU1o2NEs3NWFrNVh6?= =?utf-8?Q?llUWzL7r3QoegZsIlIvtxs9qX6sx2L5BFiwcdz8?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6cca290f-6943-4df8-f912-08d8de5a6aad X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 15:38:39.2608 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 215U1bCIELaqLaonSRjYRdPdn4EMmqI4xF6kiAGcf1NaLO/E5VkQQGGFeaqRERmZ8OWegsx2eWh1fon2G0Tw4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4843 X-OriginatorOrg: citrix.com On Tue, Mar 02, 2021 at 04:18:59PM +0100, Jan Beulich wrote: > On 02.03.2021 16:00, Roger Pau Monné wrote: > > On Tue, Mar 02, 2021 at 12:16:12PM +0100, Jan Beulich wrote: > >> On 01.03.2021 17:23, Roger Pau Monne wrote: > >>> RFC because there's still some debate as to how we should solve the > >>> MSR issue, this is one possible way, but IMO we need to make a > >>> decision soon-ish because of the release timeline. > >> > >> Generally I think it would be far better from a user pov if > >> things worked out of the box, at least in cases where it can be > >> made work. Arguably for Solaris this isn't going to be possible > >> (leaving aside the non-option of fully returning back to original > >> behavior), but for the old-Linux-PV case I still think my proposed > >> change is better in this regard. I realize Andrew said (on irc) > >> that this is making the behavior even weaker. I take a different > >> perspective: Considering a guest will install exception handlers > >> at some point, I continue to fail to see what good it will do to > >> try to inject a #GP(0) when we know the guest will die because of > >> not having a handler registered just yet. It is a kernel flaw, > >> yes, but they ended up living with it merely because of our odd > >> prior behavior, so we can't put all the blame on them. > > > > My concern with this would mostly be with newer guests, in the sense > > that people could come to rely on this behavior of not injecting a > > #GP if the handler is not setup, which I think we should try to avoid. > > > > One option would be to introduce a feature that could be used in the > > elfnotes to signal that the kernel doesn't require such workarounds > > for MSR #GP handling, maybe: > > > > /* > > * Signal that the kernel doesn't require suppressing the #GP on > > * unknown MSR accesses if the handler is not setup. New kernels > > * should always have this set. > > */ > > #define XENFEAT_msr_early_gp 16 > > > > We could try to backport this on the Linux kernel as far as we can > > that we know it's safe to do so. > > I too did consider something like this. While I'm not opposed, it > effectively requires well-behaved consumers who haven't been well- > behaved in the past. > > > If this is not acceptable then I guess your solution is fine. Arguably > > PV has it's own (weird) architecture, in which it might be safe to say > > that no #GP will be injected as a result of a MSR access unless the > > handler is setup. Ideally we should document this behaviour somewhere. > > > > Maybe we could add a rdmsr_safe to your path akin to what's done > > here? > > Probably. Would need trying out on the affected older version, > just like ... > > >>> --- a/docs/man/xl.cfg.5.pod.in > >>> +++ b/docs/man/xl.cfg.5.pod.in > >>> @@ -2861,6 +2861,17 @@ No MCA capabilities in above list are enabled. > >>> > >>> =back > >>> > >>> +=item B > >>> + > >>> +Select whether to use the legacy behaviour for accesses to MSRs not explicitly > >>> +handled by Xen instead of injecting a #GP to the guest. Such legacy access > >>> +mode will force Xen to replicate the behaviour from the hardware it's currently > >>> +running on in order to decide whether a #GP is injected to the guest. Note > >>> +that the guest is never allowed access to unhandled MSRs, this option only > >>> +changes whether a #GP might be injected or not. > >> > >> This description is appropriate for reads, but not for writes: > >> Whether a write would fault can only be known by trying a write, > >> yet for safety reasons we can't risk doing more than a read. An > >> option might be to make writes fault is the to be written value > >> differs from that which the probing read has returned (i.e. the > >> same condition which originally had caused a log message to appear > >> in 4.14 for PV guests). > > > > Read values for unhandled MSRs will always be 0 with the proposed > > code, so we would inject a #GP to the guest for any write attempt to > > unhandled MSRs with a value different than 0. > > > > Maybe we should just inject a #GP to the guest for any attempts to > > write to unhandled MSRs? > > ... doing this would need to. Iirc I did add the write side of the > handling in my patch just for symmetry. I'd prefer handling to be > symmetric, but I can see why we may not want it to be so. Kind of in the wrong context, but I will reply here because it's the last message related to the MSR stuff. Jan: would you be fine with modifying your path to not change the behaviour for writes (ie: always inject #GP to the guest for unhandled accesses), and then add a rdmsr_safe to the read path in order to decide whether to inject a #GP to the guest even if the #GP handler is not setup? I can modify the option introduced on this patch to always inject #GP on unhandled writes and only inject #GP on reads if the physical MSR access on the hardware also triggers a #GP. HVM guests with broken behavior will require having the option enabled in order to work, but I think that's likely OK as long term we expect all HVM guests to be well behaved. My main worry with this approach is that we end up requiring half of the common HVM guests OSes to have the 'legacy MSR handling' option enabled in order to work. I think it's unlikely for this to happen, as we are only aware of Solaris requiring it at the moment. It also raises the question whether we will allow any more exceptions to the MSR policy, like we did for Windows and OpenBSD in: http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=ca88a43e660c75796656a544e54a648c60d26ef0 http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=4175fd3ccd17face664036fa98e9329aa317f7b6 Or if we are just going to require those guests to enable the legacy MSR handling instead. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 03 16:07:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 16:07:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92891.175128 (Exim 4.92) (envelope-from ) id 1lHU1x-0006X7-BV; Wed, 03 Mar 2021 16:07:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92891.175128; Wed, 03 Mar 2021 16:07:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU1x-0006X0-8N; Wed, 03 Mar 2021 16:07:21 +0000 Received: by outflank-mailman (input) for mailman id 92891; Wed, 03 Mar 2021 16:07:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU1v-0006Wv-Fo for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:07:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU1v-0003yS-7i for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:07:19 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHU1v-00058q-5U for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:07:19 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHU1r-0002UN-Q7; Wed, 03 Mar 2021 16:07:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=Jap/lmAbctN+mtVe0fGTv7j6G5xaS53ElkXV5yjKUP0=; b=LQbOFzLzD6cCBk1L0xoR+WUEy/ 4cWTR1gy03kg7daBVubyr1uWEFImx7wG6BcvvQIRZW0SaqW8NC4yihU0t9sO0gkUTlBT46CNBaXja D5U8Zeo07EXFp18ZwrI6/5oInMoQUrHNf5UNiSB/Yc58g+uCa8lhZ9bdJtbgyAxJ2lXs=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24639.46131.485802.8646@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 16:07:15 +0000 To: Norbert Manthey Cc: , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth Subject: [PATCH XENSTORE v1 01/10] xenstore: add missing NULL check In-Reply-To: <20210226144144.9252-2-nmanthey@amazon.de> References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-2-nmanthey@amazon.de> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Norbert Manthey writes ("[PATCH XENSTORE v1 01/10] xenstore: add missing NULL check"): > In case of allocation error, we should not dereference the obtained > NULL pointer. Hence, fail early. > > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. > > Signed-off-by: Norbert Manthey > Reviewed-by: Thomas Friebel > Reviewed-by: Julien Grall Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Wed Mar 03 16:08:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 16:08:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92894.175140 (Exim 4.92) (envelope-from ) id 1lHU3D-0006dL-NG; Wed, 03 Mar 2021 16:08:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92894.175140; Wed, 03 Mar 2021 16:08:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU3D-0006dE-JN; Wed, 03 Mar 2021 16:08:39 +0000 Received: by outflank-mailman (input) for mailman id 92894; Wed, 03 Mar 2021 16:08:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU3B-0006d7-M9 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:08:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU3B-0003zS-LJ for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:08:37 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHU3B-0005Wp-KG for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:08:37 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHU38-0002Un-9E; Wed, 03 Mar 2021 16:08:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=b6Y2ILNtXyy6F4Wi0+hE/oc2Zw9GEarWcGvHfh8GfmY=; b=UUHX7PbBDJdLbU0Ns++HWVFhIY d9cSSXniDRdC5BCs3q6BQbJBzxrGWLUdihH6RyykJfKJdk0Bm5IuZzvL0Xa83gSKXleq1URFk6B/R K1Jd+H467t2AahkmuPRZdYfBUiwpVbpCBvefRwtLOiImggz8q/7kJF3m9R/75qAalRHU=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24639.46209.972182.673496@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 16:08:33 +0000 To: Norbert Manthey Cc: , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth Subject: [PATCH XENSTORE v1 02/10] xenstore: fix print format string In-Reply-To: <20210226144144.9252-3-nmanthey@amazon.de> References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-3-nmanthey@amazon.de> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Norbert Manthey writes ("[PATCH XENSTORE v1 02/10] xenstore: fix print format string"): > Use the correct format specifier for unsigned values. Additionally, a > cast was dropped, as the format specifier did not require it anymore. > > This was reported by analysis with cppcheck. > > Signed-off-by: Norbert Manthey > Reviewed-by: Thomas Friebel > Reviewed-by: Julien Grall Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Wed Mar 03 16:08:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 16:08:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92895.175152 (Exim 4.92) (envelope-from ) id 1lHU3O-0006h0-26; Wed, 03 Mar 2021 16:08:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92895.175152; Wed, 03 Mar 2021 16:08:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU3N-0006gr-Sk; Wed, 03 Mar 2021 16:08:49 +0000 Received: by outflank-mailman (input) for mailman id 92895; Wed, 03 Mar 2021 16:08:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU3N-0006gb-3K for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:08:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU3N-0003zk-2F for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:08:49 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHU3N-0005YX-1J for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:08:49 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHU3J-0002V7-O7; Wed, 03 Mar 2021 16:08:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=8U79bQjaPvJAPE9FcD1NwDJIjVKHdU/u6q7g9cU3elw=; b=dMHV/JvB9DAgU8n34K6I+t6Jvx 6B5jR8bpMPNiLuaGxYoBWgSAJtKuk3FyQGCBaM1jg9D4xHJp60wAL7QJuS3uTIJZEaYmu/+L96Fac tU/mz90VYIsdaq0klrmOS266kkZD8GyUikJvgvxxDqxpIA3IYNEaWt/vBph1bmZ+688w=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24639.46221.478411.522161@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 16:08:45 +0000 To: Norbert Manthey Cc: , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth Subject: [PATCH XENSTORE v1 03/10] xenstore: check formats of trace In-Reply-To: <20210226144144.9252-4-nmanthey@amazon.de> References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-4-nmanthey@amazon.de> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Norbert Manthey writes ("[PATCH XENSTORE v1 03/10] xenstore: check formats of trace"): > When passing format strings to the trace function, allow gcc to analyze > those and warn on issues. > > Signed-off-by: Norbert Manthey > Reviewed-by: Thomas Friebel > Reviewed-by: Julien Grall Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Wed Mar 03 16:10:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 16:10:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92900.175163 (Exim 4.92) (envelope-from ) id 1lHU4h-0007iF-Bs; Wed, 03 Mar 2021 16:10:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92900.175163; Wed, 03 Mar 2021 16:10:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU4h-0007i8-8o; Wed, 03 Mar 2021 16:10:11 +0000 Received: by outflank-mailman (input) for mailman id 92900; Wed, 03 Mar 2021 16:10:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU4g-0007i3-DO for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:10:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU4g-00041a-CZ for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:10:10 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHU4g-0005fT-Bk for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:10:10 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHU4d-0002Ve-1T; Wed, 03 Mar 2021 16:10:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=DVLSgcK5zaBMulebW4DcYpNeqdnCO5So83EVAKndzdQ=; b=k3uk8JwIhG95qcDjQZwzIQl+sc HsTBzByX4fsn4C8sIyktNWb7ilro/HoIUToCjuNZogDoWtUuwlh/WytpHAkknR6YMeC10pLDVM4Tt +EauS0byOp1dxdINMVdPMSvPnUlYrrxyo/7iwNdcx1hJBFr2tFYFdWKK9AKIiIxXCkNU=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24639.46302.755089.845426@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 16:10:06 +0000 To: Norbert Manthey Cc: , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth Subject: Re: [PATCH XENSTORE v1 04/10] xenstore_client: handle memory on error In-Reply-To: <20210226144144.9252-5-nmanthey@amazon.de> References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-5-nmanthey@amazon.de> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Norbert Manthey writes ("[PATCH XENSTORE v1 04/10] xenstore_client: handle memory on error"): > In case a command fails, also free the memory. As this is for the CLI > client, currently the leaked memory is freed right after receiving the > error, as the application terminates next. > > Similarly, if the allocation fails, do not use the NULL pointer > afterwards, but instead error out. I think this is not for 4.15. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 03 16:10:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 16:10:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92902.175176 (Exim 4.92) (envelope-from ) id 1lHU5K-0007oP-Lh; Wed, 03 Mar 2021 16:10:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92902.175176; Wed, 03 Mar 2021 16:10:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU5K-0007oI-Hn; Wed, 03 Mar 2021 16:10:50 +0000 Received: by outflank-mailman (input) for mailman id 92902; Wed, 03 Mar 2021 16:10:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU5J-0007o9-8H for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:10:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU5J-000426-7X for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:10:49 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHU5J-0005iX-6j for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:10:49 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHU5F-0002Vy-Sj; Wed, 03 Mar 2021 16:10:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=C1Fqyb7V7hJSUZYOzcyx0OltK1CH/43qR6Zd9Ejy3fw=; b=dVe6fQUubGyYSDCMuWVsMBKb57 qF83nVtQgpYGvX/5sa23RbCa8HiMsynT6NlMjyvmoqqjtl+42yrqERuxMHZSbK3a1YAyF0cWSCQTH ChIlMhyRKtHqfILZDeYUs3hXzK52acV1nhO87Yl8fF8PNQbDzeS8t8MQsd7B2uYBJvqk=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24639.46341.638952.338740@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 16:10:45 +0000 To: Norbert Manthey Cc: , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth Subject: [PATCH XENSTORE v1 05/10] xenstore: handle daemon creation errors In-Reply-To: <20210226144144.9252-6-nmanthey@amazon.de> References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-6-nmanthey@amazon.de> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Norbert Manthey writes ("[PATCH XENSTORE v1 05/10] xenstore: handle daemon creation errors"): > In rare cases, the path to the daemon socket cannot be created as it is > longer than PATH_MAX. Instead of failing with a NULL pointer dereference, > terminate the application with an error message. > > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. Again, not for 4.15 I think. Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 03 16:11:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 16:11:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92904.175188 (Exim 4.92) (envelope-from ) id 1lHU63-0007xl-VX; Wed, 03 Mar 2021 16:11:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92904.175188; Wed, 03 Mar 2021 16:11:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU63-0007xe-RJ; Wed, 03 Mar 2021 16:11:35 +0000 Received: by outflank-mailman (input) for mailman id 92904; Wed, 03 Mar 2021 16:11:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU62-0007xX-Fg for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:11:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU62-000438-Ec for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:11:34 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHU62-0005ys-Dh for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:11:34 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHU5z-0002WO-2f; Wed, 03 Mar 2021 16:11:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=lHQe29hLqTsq8OcNFbc6CpPeVV9UP9J37niA80Iu3ZE=; b=DSV3oQQvAtEXVGwmgUy7OtWSHa yvHe2ovTRj3qJ4tn4ejqWvwaZUdiqAeHWLSqlFeMtLHz5fQspSNjdIieuCa9IfzBOhtQqAiFiHiSz RbhPn4gW7UKQbrSfO6zJgepMGUKCZxqvRcUmDvUYwu/KIfElriLqokbRk1SaTT6JMo2Y=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24639.46386.759552.737449@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 16:11:30 +0000 To: Norbert Manthey Cc: , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth Subject: [PATCH XENSTORE v1 07/10] xenstore: handle do_mkdir and do_rm failure In-Reply-To: <20210226144144.9252-8-nmanthey@amazon.de> References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-8-nmanthey@amazon.de> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Norbert Manthey writes ("[PATCH XENSTORE v1 07/10] xenstore: handle do_mkdir and do_rm failure"): > In the out of memory case, we might return a NULL pointer when > canonicalizing node names. This NULL pointer is not checked when > creating a directory, or when removing a node. This change handles > the NULL pointer for these two cases. > > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. > > Signed-off-by: Norbert Manthey > Reviewed-by: Thomas Friebel > Reviewed-by: Julien Grall Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Wed Mar 03 16:11:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 16:11:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92906.175199 (Exim 4.92) (envelope-from ) id 1lHU6R-00083E-6f; Wed, 03 Mar 2021 16:11:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92906.175199; Wed, 03 Mar 2021 16:11:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU6R-000837-3q; Wed, 03 Mar 2021 16:11:59 +0000 Received: by outflank-mailman (input) for mailman id 92906; Wed, 03 Mar 2021 16:11:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU6P-000830-Vi for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:11:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU6P-00045N-Uy for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:11:57 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHU6P-00061N-SZ for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:11:57 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHU6M-0002Wi-IK; Wed, 03 Mar 2021 16:11:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=3N0j/XZLBt6R15yiPeoLLv2WWdZz7CmBECKMG6nfxBU=; b=pilxf7oYqjKVR6ooZH6MkzQM+T saA2K+3tpiGKFnD7IR7WHQd/+FGEXmM5+y5ZbZrknH/lfqDJUhI2vfpx9lI2F6XtADBmcxKg3eASF Z7QA2uZFYC/In1BJYEBEYZ64EHZWDhR+SssTo8Q+4qLH0d1oJkpOzyMHwD83fcKTxwMQ=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24639.46410.250728.101211@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 16:11:54 +0000 To: Norbert Manthey Cc: , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth , Michael Kurth Subject: [PATCH XENSTORE v1 08/10] xenstore: add missing NULL check In-Reply-To: <20210226144144.9252-9-nmanthey@amazon.de> References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-9-nmanthey@amazon.de> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Norbert Manthey writes ("[PATCH XENSTORE v1 08/10] xenstore: add missing NULL check"): > From: Michael Kurth > > In case of allocation error, we should not dereference the obtained > NULL pointer. > > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. > > Signed-off-by: Michael Kurth > Signed-off-by: Norbert Manthey > Reviewed-by: Thomas Friebel > Reviewed-by: Julien Grall Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Wed Mar 03 16:13:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 16:13:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92911.175212 (Exim 4.92) (envelope-from ) id 1lHU7u-0008DR-JE; Wed, 03 Mar 2021 16:13:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92911.175212; Wed, 03 Mar 2021 16:13:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU7u-0008DK-F1; Wed, 03 Mar 2021 16:13:30 +0000 Received: by outflank-mailman (input) for mailman id 92911; Wed, 03 Mar 2021 16:13:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU7t-0008DE-7e for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:13:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU7t-00047G-6a for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:13:29 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHU7t-000671-4g for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:13:29 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHU7p-0002XI-R3; Wed, 03 Mar 2021 16:13:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=t9zfV1xj2E20FwAy3XESBfB5/2UjYWjQDHlxNRG89NE=; b=Qtg5495PJx6mbn5b6lCkwSK8Rt dvbCXghdUBCvTF3+OkYLxPoG57+ND/TcBUcI6wX+m5aOE68kURFZkq8JyjXBc22tuXGGVg5+QKgkh bxDl/Mb8TghKLdXjqss0U+UbH+1+ksHfUtX3y1m4GisuvMoJMUV03D7kxXV0etdG6n4o=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24639.46501.489245.30690@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 16:13:25 +0000 To: Norbert Manthey Cc: , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth Subject: Re: [PATCH XENSTORE v1 09/10] xs: handle daemon socket error In-Reply-To: <20210226144144.9252-10-nmanthey@amazon.de> References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-10-nmanthey@amazon.de> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Norbert Manthey writes ("[PATCH XENSTORE v1 09/10] xs: handle daemon socket error"): > When starting the daemon, we might see a NULL pointer instead of the > path to the socket. > > Only relevant in case we start the process in a very deep directory > path, with a length close to 4096 so that appending "/socket" would > exceed the limit. Hence, such an error is unlikely, but should still be > fixed to not result in a NULL pointer dereference. This description talks about starting the daemon ... > --- > tools/libs/store/xs.c | 3 +++ > 1 file changed, 3 insertions(+) But I think ... > + if (!connect_to) > + return NULL; > + ... this is client code ? Apologies if I am confused. Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 03 16:14:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 16:14:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92912.175224 (Exim 4.92) (envelope-from ) id 1lHU8P-0008IR-R9; Wed, 03 Mar 2021 16:14:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92912.175224; Wed, 03 Mar 2021 16:14:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU8P-0008IK-O7; Wed, 03 Mar 2021 16:14:01 +0000 Received: by outflank-mailman (input) for mailman id 92912; Wed, 03 Mar 2021 16:14:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU8O-0008IC-Ev for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:14:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU8O-00047r-E9 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:14:00 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHU8O-00069t-DN for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:14:00 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHU8L-0002Xc-2d; Wed, 03 Mar 2021 16:13:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=p4sREm35iyBY7TBcQKfjhYDaCyL95jjsV8ZAUaDmBhg=; b=IaTZrVBmSvi7XsK8IaMwg4rDNu mhW2yw3ErixvnhpQa5cG6Zq3gzcaP9TaPFHfkLUzAWjm8YAqWfrxx5Kg1ntc1+jZ6qVHEZAtuBDS9 SffRCQ3UBy/ioCTxnWtsdqeRn50oy+L6CoSNFj6hK/9zMGR/lShmTJNr8pLi8ZOxQxcM=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24639.46532.800022.313673@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 16:13:56 +0000 To: Norbert Manthey Cc: , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth Subject: Re: [PATCH XENSTORE v1 10/10] xs: add error handling In-Reply-To: <20210226144144.9252-11-nmanthey@amazon.de> References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-11-nmanthey@amazon.de> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Norbert Manthey writes ("[PATCH XENSTORE v1 10/10] xs: add error handling"): > In case of a failure deep in the call tree, we might return NULL as the > value of the domain. In that case, error out instead of dereferencing > the NULL pointer. > > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. > > Signed-off-by: Norbert Manthey > Reviewed-by: Julien Grall > Reviewed-by: Raphael Ning Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Wed Mar 03 17:06:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 17:06:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92922.175248 (Exim 4.92) (envelope-from ) id 1lHUwI-00054s-5P; Wed, 03 Mar 2021 17:05:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92922.175248; Wed, 03 Mar 2021 17:05:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHUwI-00054l-1P; Wed, 03 Mar 2021 17:05:34 +0000 Received: by outflank-mailman (input) for mailman id 92922; Wed, 03 Mar 2021 17:05:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHUwG-00054f-M4 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 17:05:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHUwF-0004yA-4M; Wed, 03 Mar 2021 17:05:31 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHUwE-0005q4-Ip; Wed, 03 Mar 2021 17:05:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=9yPzP18IxQGu4Rh4EpOr1irO50bzzkHI1YvhVzGWuy8=; b=TmaV2u0t8q9F/Mbs3Bj88nGH4o Z1RRUcYfDXy1PM2L4g096zfl4uEjtehqGrl/Yd279G+iwYw4IEkUiTx+Di/xiq09v0c8Cil4LsoPJ mmTZL/S/TVKUxB9E2kflpg2mJm8uc712hhgrDjN5bd8+7QRLKqxi0OnvuppxEHz1N0EQ=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , Juergen Gross , Bjoern Doebel Subject: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction Date: Wed, 3 Mar 2021 17:05:26 +0000 Message-Id: <20210303170526.15903-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall As XenStored is single-threaded, conn->ta_start_time will always be smaller than now. As we substract the latter from the former, it means a transaction will never be considered long running. Invert the two operands of the substraction in both lu_reject_reason() and lu_check_allowed(). In addition to that, the former also needs to check that conn->ta_start_time is not 0 (i.e the transaction is not active). Take the opportunity to document the return condition of lu_check_allowed(). Fixes: e04e53a5be20 ("tools/xenstore: allow live update only with no transaction active") Reported-by: Bjoern Doebel Signed-off-by: Julien Grall --- I am a bit puzzled on how -F is implemented. From my understanding we will force LiveUpdate when one of the following conditions is met: 1) All the active transactions are long running 2) If we didn't manage to LiveUpdate after N sec It is not quite clear why we need the both as 2) would indirectly cover 1). However 2) is probably unsafe as we may reset transactions for "well-behaving" guest. So I am thinking to send a patch to drop 2). Any opinions? This patch is candidate for 4.15. Without it, the long-running transactions are not properly accounted. --- tools/xenstore/xenstored_control.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index d7ad112138b2..8e470f2b2056 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -459,11 +459,18 @@ static bool lu_check_lu_allowed(void) list_for_each_entry(conn, &connections, list) { if (conn->ta_start_time) { ta_total++; - if (conn->ta_start_time - now >= lu_status->timeout) + if (now - conn->ta_start_time >= lu_status->timeout) ta_long++; } } + /* + * Allow LiveUpdate if one of the following conditions is met: + * - There is no active transactions + * - All transactions are long running (e.g. they have been + * active for more than lu_status->timeout sec) and the admin as + * requested to force the operation. + */ return ta_total ? (lu_status->force && ta_long == ta_total) : true; } @@ -474,11 +481,12 @@ static const char *lu_reject_reason(const void *ctx) time_t now = time(NULL); list_for_each_entry(conn, &connections, list) { - if (conn->ta_start_time - now >= lu_status->timeout) { + if (conn->ta_start_time && + (now - conn->ta_start_time >= lu_status->timeout)) { ret = talloc_asprintf(ctx, "%s\nDomain %u: %ld s", ret ? : "Domains with long running transactions:", conn->id, - conn->ta_start_time - now); + now - conn->ta_start_time); } } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 17:36:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 17:36:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92927.175260 (Exim 4.92) (envelope-from ) id 1lHVQV-0008CX-MT; Wed, 03 Mar 2021 17:36:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92927.175260; Wed, 03 Mar 2021 17:36:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVQV-0008CQ-JK; Wed, 03 Mar 2021 17:36:47 +0000 Received: by outflank-mailman (input) for mailman id 92927; Wed, 03 Mar 2021 17:36:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVQT-0008CL-VA for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 17:36:46 +0000 Received: from mail-wr1-x42d.google.com (unknown [2a00:1450:4864:20::42d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6533d9fe-48b3-484e-a409-0a954603f8a3; Wed, 03 Mar 2021 17:36:44 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id u16so6596949wrt.1 for ; Wed, 03 Mar 2021 09:36:44 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id f14sm6528499wmf.7.2021.03.03.09.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 09:36:43 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 4253E1FF7E; Wed, 3 Mar 2021 17:36:42 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6533d9fe-48b3-484e-a409-0a954603f8a3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tycmjp6CJiWbZvVw6Aok39MbRvYMS6RtER+7yrB8OAA=; b=YULpRfZUogvoBjS7IKX4NXSjOLdIbt0oqgCZlNxkM4Vg3XZlaR8yKSykZ2svwrC2gK cZBzTdpvGE/LjH2vM3J0GbKWBh+3LS1PpoVSLRkDHmg9jF4ZA1UCKSjacxnVFfSi51v5 gFPktTEhl0kutYJSB5N2NU7vOTwPFMaLkm9zAM2yeR9xYVRhHWgRBrjFDB/jK+CLp4Gr HUiKolu2a9Oenj/glmKfavTIH+5Ge+nNJkq5/p/6y6Ih1Yyi/jJqRKrMkSLJ54Mz5u7F D8vVuB4geNcKyf98IjwqUKtmF+Gczsg0MPQtPyBHX1mJg2ZjNO24hj92ccgOELiWToY1 yotg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tycmjp6CJiWbZvVw6Aok39MbRvYMS6RtER+7yrB8OAA=; b=SG4NYrR5XErGM5inQDwx+1ubDU6zx/Uc3hEWQSaLPdm0iX1oVkq4dqh4CSUQKUKmnh BIuWTHnZ0buKt+cM7pVyGLcUcy7LLrV+s7VJ4CECxAe+6jQZImInel2x9obbqv+iu8Jg IET5fORjh5G0vKNSyjclJigntEeQtc20m/BTudAw0S5YzCf3L4Vy6zcmU+Y3brvQS2sj 7Zg3XByADaJzNH00CxNjxtAM5Pz7z0kxWEcAlgFBWLRDpDThNNmsgQsawOuS+Km5FaBn nOeKq6pRe+XYPjhbYxcOxUOGvFWsiIrDSbHKFWC2aNThEKlMLFp0OyR8PXmUal/DC/I3 27Gw== X-Gm-Message-State: AOAM530DabmtudPQs9z8GOrn1MLa7cG0EkamzPvGZf8aYWPilS5mY64N Mkd8NSEJIhO4ubqPzL56Q8fNig== X-Google-Smtp-Source: ABdhPJxRUCcHeBftPQjidg5ANnhVVk7OaZCMfovO8zD1hlzAWv4XeFe4Or+MxE+8iGqAwrh754sPJA== X-Received: by 2002:adf:ed46:: with SMTP id u6mr28044204wro.350.1614793004070; Wed, 03 Mar 2021 09:36:44 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: julien@xen.org, stefano.stabellini@linaro.org, stefano.stabellini@xilinx.com, andre.przywara@arm.com, stratos-dev@op-lists.linaro.org, xen-devel@lists.xenproject.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH v3 0/7] Xen guest-loader support, pre-PR Date: Wed, 3 Mar 2021 17:36:35 +0000 Message-Id: <20210303173642.3805-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, Trying to get my ducks in a row for a merge of this before softfreeze so this is my pre-PR posting of the Xen guest-loader support. Everything apart from the loader itself is reviewed and given it's been tested in other patches and I'm going to maintain it I don't see a reason to hold it up from going in. However if you would like to review it please do ;-) The only real change is a tweak to the final patch where I've added a stable archive URL for the Debian Xen packages. Alex Bennée (7): hw/board: promote fdt from ARM VirtMachineState to MachineState hw/riscv: migrate fdt field to generic MachineState device_tree: add qemu_fdt_setprop_string_array helper hw/core: implement a guest-loader to support static hypervisor guests docs: move generic-loader documentation into the main manual docs: add some documentation for the guest-loader tests/avocado: add boot_xen tests docs/generic-loader.txt | 92 --------- docs/system/generic-loader.rst | 117 +++++++++++ docs/system/guest-loader.rst | 54 +++++ docs/system/index.rst | 2 + hw/core/guest-loader.h | 34 ++++ include/hw/arm/virt.h | 1 - include/hw/boards.h | 1 + include/hw/riscv/virt.h | 1 - include/sysemu/device_tree.h | 17 ++ hw/arm/virt.c | 356 +++++++++++++++++---------------- hw/core/guest-loader.c | 145 ++++++++++++++ hw/riscv/virt.c | 20 +- softmmu/device_tree.c | 26 +++ MAINTAINERS | 9 +- hw/core/meson.build | 2 + tests/acceptance/boot_xen.py | 118 +++++++++++ 16 files changed, 719 insertions(+), 276 deletions(-) delete mode 100644 docs/generic-loader.txt create mode 100644 docs/system/generic-loader.rst create mode 100644 docs/system/guest-loader.rst create mode 100644 hw/core/guest-loader.h create mode 100644 hw/core/guest-loader.c create mode 100644 tests/acceptance/boot_xen.py -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 17:36:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 17:36:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92928.175272 (Exim 4.92) (envelope-from ) id 1lHVQZ-0008Dw-Uf; Wed, 03 Mar 2021 17:36:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92928.175272; Wed, 03 Mar 2021 17:36:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVQZ-0008Dp-Rd; Wed, 03 Mar 2021 17:36:51 +0000 Received: by outflank-mailman (input) for mailman id 92928; Wed, 03 Mar 2021 17:36:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVQY-0008CL-SJ for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 17:36:50 +0000 Received: from mail-wr1-x430.google.com (unknown [2a00:1450:4864:20::430]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4e806233-47ab-4952-919c-50e0a1938d16; Wed, 03 Mar 2021 17:36:45 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id b18so18122692wrn.6 for ; Wed, 03 Mar 2021 09:36:45 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id m2sm6316827wml.34.2021.03.03.09.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 09:36:43 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7DDF21FF8C; Wed, 3 Mar 2021 17:36:42 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e806233-47ab-4952-919c-50e0a1938d16 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1mhDoxefyC/VVw7zUuqfiHo+BNITfl2gfYDxMgzesU4=; b=y8ZioLIGZvHKVdZXRlv1Zar1mcJF3BAo55XTeclyWG7L1Ra+fookeVnBv1QaxXwyMD 3/tNFOUq9PlV7eQ+ejutHRg8QEXH8Wk/zTPau7KzdQACukH7fFZDs4AQ0sFK2epAtH9+ aixZob2k3D61ulHEcxY+dJRI0xinFr9lNeIr35PfAc30pBrfH54QrNhwf89w013Nhr0f UDGgJ2pMGm0e+tSXuEj5wAOOAyz/bDgYSQ2A6DtSmWQBquJ0FduvnWFRsPQbjvDJcnFc 3rQRTqczwqbcwKyUbVbhbhmnEIVMDcK/hLttLiJTnpGOLHl/UmzYsgIwbo2dF/qJZPPU sz7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1mhDoxefyC/VVw7zUuqfiHo+BNITfl2gfYDxMgzesU4=; b=nr1zFjrOBPIoHy/woUBggjG7XuwGcrBgXlEALS285Eckunh3c8q5U/GH+E77wry2ao xFq/S7YwwLAn6S1FvmVqyUVDGbX/ChLvp6nOG8edH5L9dbme06XPhun8w/JE2rL2OI22 wMDC0omiPJ5fMl8fs6mm3OxkEOIRKVT3k0eLJ349+7trqndwTxBBiUnElkzP5LvQbiv2 LRslo07qqbyWPkcwhCfm8FkB8iKPuFrLnROwv4Zl84EQ2lS2ccyTGBcHlRlg46PXQM6p 1AjfICQ7xPXhS4neGB/x5K6/eWqsqvTS4uQ9bGoECtoIBQyespBtTfotUiPJe6KV2H2r WQjg== X-Gm-Message-State: AOAM531fxPDRBP6i8yp8m4eFfD5cV4EBzPGMKiLOCXOKHjhIzUXlcWOW CiFVRDr7ChtoJQvqeZnLJNfqXQ== X-Google-Smtp-Source: ABdhPJyZSxtpc4fcGhtaCFDlXly5Tpm9D42Lg+8EXzRiM52nT+tOhOeLiZfd9lGfRgooTwIG8FgzQg== X-Received: by 2002:adf:c752:: with SMTP id b18mr5625686wrh.233.1614793004917; Wed, 03 Mar 2021 09:36:44 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: julien@xen.org, stefano.stabellini@linaro.org, stefano.stabellini@xilinx.com, andre.przywara@arm.com, stratos-dev@op-lists.linaro.org, xen-devel@lists.xenproject.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Palmer Dabbelt , Alistair Francis , Sagar Karandikar , Bastian Koppelmann , qemu-riscv@nongnu.org (open list:RISC-V TCG CPUs) Subject: [PATCH v3 2/7] hw/riscv: migrate fdt field to generic MachineState Date: Wed, 3 Mar 2021 17:36:37 +0000 Message-Id: <20210303173642.3805-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210303173642.3805-1-alex.bennee@linaro.org> References: <20210303173642.3805-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a mechanical change to make the fdt available through MachineState. Signed-off-by: Alex Bennée Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210211171945.18313-3-alex.bennee@linaro.org> --- include/hw/riscv/virt.h | 1 - hw/riscv/virt.c | 20 ++++++++++---------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/include/hw/riscv/virt.h b/include/hw/riscv/virt.h index 84b7a3848f..632da52018 100644 --- a/include/hw/riscv/virt.h +++ b/include/hw/riscv/virt.h @@ -41,7 +41,6 @@ struct RISCVVirtState { DeviceState *plic[VIRT_SOCKETS_MAX]; PFlashCFI01 *flash[2]; - void *fdt; int fdt_size; }; diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 2299b3a6be..8d0ba72d78 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -189,14 +189,14 @@ static void create_fdt(RISCVVirtState *s, const struct MemmapEntry *memmap, hwaddr flashbase = virt_memmap[VIRT_FLASH].base; if (mc->dtb) { - fdt = s->fdt = load_device_tree(mc->dtb, &s->fdt_size); + fdt = mc->fdt = load_device_tree(mc->dtb, &s->fdt_size); if (!fdt) { error_report("load_device_tree() failed"); exit(1); } goto update_bootargs; } else { - fdt = s->fdt = create_device_tree(&s->fdt_size); + fdt = mc->fdt = create_device_tree(&s->fdt_size); if (!fdt) { error_report("create_device_tree() failed"); exit(1); @@ -434,12 +434,12 @@ static void create_fdt(RISCVVirtState *s, const struct MemmapEntry *memmap, g_free(name); name = g_strdup_printf("/soc/flash@%" PRIx64, flashbase); - qemu_fdt_add_subnode(s->fdt, name); - qemu_fdt_setprop_string(s->fdt, name, "compatible", "cfi-flash"); - qemu_fdt_setprop_sized_cells(s->fdt, name, "reg", + qemu_fdt_add_subnode(mc->fdt, name); + qemu_fdt_setprop_string(mc->fdt, name, "compatible", "cfi-flash"); + qemu_fdt_setprop_sized_cells(mc->fdt, name, "reg", 2, flashbase, 2, flashsize, 2, flashbase + flashsize, 2, flashsize); - qemu_fdt_setprop_cell(s->fdt, name, "bank-width", 4); + qemu_fdt_setprop_cell(mc->fdt, name, "bank-width", 4); g_free(name); update_bootargs: @@ -631,9 +631,9 @@ static void virt_machine_init(MachineState *machine) hwaddr end = riscv_load_initrd(machine->initrd_filename, machine->ram_size, kernel_entry, &start); - qemu_fdt_setprop_cell(s->fdt, "/chosen", + qemu_fdt_setprop_cell(machine->fdt, "/chosen", "linux,initrd-start", start); - qemu_fdt_setprop_cell(s->fdt, "/chosen", "linux,initrd-end", + qemu_fdt_setprop_cell(machine->fdt, "/chosen", "linux,initrd-end", end); } } else { @@ -654,12 +654,12 @@ static void virt_machine_init(MachineState *machine) /* Compute the fdt load address in dram */ fdt_load_addr = riscv_load_fdt(memmap[VIRT_DRAM].base, - machine->ram_size, s->fdt); + machine->ram_size, machine->fdt); /* load the reset vector */ riscv_setup_rom_reset_vec(machine, &s->soc[0], start_addr, virt_memmap[VIRT_MROM].base, virt_memmap[VIRT_MROM].size, kernel_entry, - fdt_load_addr, s->fdt); + fdt_load_addr, machine->fdt); /* SiFive Test MMIO device */ sifive_test_create(memmap[VIRT_TEST].base); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 17:36:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 17:36:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92929.175284 (Exim 4.92) (envelope-from ) id 1lHVQf-0008HP-7a; Wed, 03 Mar 2021 17:36:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92929.175284; Wed, 03 Mar 2021 17:36:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVQf-0008HI-4K; Wed, 03 Mar 2021 17:36:57 +0000 Received: by outflank-mailman (input) for mailman id 92929; Wed, 03 Mar 2021 17:36:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVQd-0008CL-SG for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 17:36:55 +0000 Received: from mail-wr1-x432.google.com (unknown [2a00:1450:4864:20::432]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 595badfa-9111-40ec-b0f7-625827251f94; Wed, 03 Mar 2021 17:36:48 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id d15so9372500wrv.5 for ; Wed, 03 Mar 2021 09:36:48 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id u20sm6484722wru.6.2021.03.03.09.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 09:36:43 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 630801FF87; Wed, 3 Mar 2021 17:36:42 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 595badfa-9111-40ec-b0f7-625827251f94 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0OYLtffMHjoeULYxORVSwyMDS5IixWGI4yHOSzBjN8g=; b=CTxEFHao09x0mVNR15UBaQCNm95KAPCvyFCYc+2S3Pq52/Z33meUC253V0H5aXnPqC DlKpOr6iqWDbyGG+u1Nn3Tlb8vlX/u8x/AhY54VoUORa2GoBW43L3Y+JCu1+CRweUZ0M 7yU8ZdxmLepUI+l1flReLVKkGUPIeNwuCXSMwfuqJSJmMIx8B8tUyc0tlxRwkOTVfOjf 0SdcIXyavBI6WPoHvyiqMsyJ+IEecn7/Jq8Izdka9rlw5oWpl4mhGvD8Nf5x7gW3w6DD hG2swfB7pB6EWSKo0QM/Dhhd7pEtG6icfoiOo1C/hVO4jjW+4vVK9ZXYkGLvXSmuiHfp CztQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0OYLtffMHjoeULYxORVSwyMDS5IixWGI4yHOSzBjN8g=; b=hVKl+y0rAhnm9gCWLxZRXf+lcQI2boZwQmVQH5fsEOeMFuyxiKV0DuxKeg+J52SkP+ hmgbn2UCvrYfh9XKmbHFgAzDg9hRPKBd8vOQjweD6oYGSNiZubzmdpA/4DIdPRTYgdHr mMW9+wvCHD+Bfwk3OZ2VUuuQTzIbFNWMBR7oAe2aq67J2mknV7oaDGqMV50dwfowY6y/ BwwkHxkwVDCMFwZTm850i6BemOFuI2s4Bt6xHJRSzCERXpVlzoa9gwN880ffr7jP5AKr eRxUa6lAuz6akoV+5MOVoLCCHp0yJViuvEknvc6oBuADCcz6FT7F102EEaU2brB0/MhG YjlA== X-Gm-Message-State: AOAM531x8veNtr1xSfZXvF21aexq5A+hEfwTLMGhIw5Olpnpn4/tjJQE O4v4EukQu1rEBnHtileFFF1S1A== X-Google-Smtp-Source: ABdhPJxbdxTK2JI4/kLmBhz91HUyT64aL1xs811lS97/wMHiyIFtAX2Zh6XpYs1z94zYG+0LEVGSnQ== X-Received: by 2002:a5d:5047:: with SMTP id h7mr17732275wrt.111.1614793007061; Wed, 03 Mar 2021 09:36:47 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: julien@xen.org, stefano.stabellini@linaro.org, stefano.stabellini@xilinx.com, andre.przywara@arm.com, stratos-dev@op-lists.linaro.org, xen-devel@lists.xenproject.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell , Eduardo Habkost , Marcel Apfelbaum , qemu-arm@nongnu.org (open list:Virt) Subject: [PATCH v3 1/7] hw/board: promote fdt from ARM VirtMachineState to MachineState Date: Wed, 3 Mar 2021 17:36:36 +0000 Message-Id: <20210303173642.3805-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210303173642.3805-1-alex.bennee@linaro.org> References: <20210303173642.3805-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The use of FDT's is quite common across our various platforms. To allow the guest loader to tweak it we need to make it available in the generic state. This creates the field and migrates the initial user to use the generic field. Other boards will be updated in later patches. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210211171945.18313-2-alex.bennee@linaro.org> --- include/hw/arm/virt.h | 1 - include/hw/boards.h | 1 + hw/arm/virt.c | 356 ++++++++++++++++++++++-------------------- 3 files changed, 186 insertions(+), 172 deletions(-) diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h index ee9a93101e..921416f918 100644 --- a/include/hw/arm/virt.h +++ b/include/hw/arm/virt.h @@ -153,7 +153,6 @@ struct VirtMachineState { MemMapEntry *memmap; char *pciehb_nodename; const int *irqmap; - void *fdt; int fdt_size; uint32_t clock_phandle; uint32_t gic_phandle; diff --git a/include/hw/boards.h b/include/hw/boards.h index a46dfe5d1a..5fda5fd128 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -258,6 +258,7 @@ struct MachineState { /*< public >*/ + void *fdt; char *dtb; char *dumpdtb; int phandle_start; diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 371147f3ae..c08bf11297 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -218,14 +218,14 @@ static bool cpu_type_valid(const char *cpu) return false; } -static void create_kaslr_seed(VirtMachineState *vms, const char *node) +static void create_kaslr_seed(MachineState *ms, const char *node) { uint64_t seed; if (qemu_guest_getrandom(&seed, sizeof(seed), NULL)) { return; } - qemu_fdt_setprop_u64(vms->fdt, node, "kaslr-seed", seed); + qemu_fdt_setprop_u64(ms->fdt, node, "kaslr-seed", seed); } static void create_fdt(VirtMachineState *vms) @@ -239,7 +239,7 @@ static void create_fdt(VirtMachineState *vms) exit(1); } - vms->fdt = fdt; + ms->fdt = fdt; /* Header */ qemu_fdt_setprop_string(fdt, "/", "compatible", "linux,dummy-virt"); @@ -248,11 +248,11 @@ static void create_fdt(VirtMachineState *vms) /* /chosen must exist for load_dtb to fill in necessary properties later */ qemu_fdt_add_subnode(fdt, "/chosen"); - create_kaslr_seed(vms, "/chosen"); + create_kaslr_seed(ms, "/chosen"); if (vms->secure) { qemu_fdt_add_subnode(fdt, "/secure-chosen"); - create_kaslr_seed(vms, "/secure-chosen"); + create_kaslr_seed(ms, "/secure-chosen"); } /* Clock node, for the benefit of the UART. The kernel device tree @@ -316,6 +316,7 @@ static void fdt_add_timer_nodes(const VirtMachineState *vms) ARMCPU *armcpu; VirtMachineClass *vmc = VIRT_MACHINE_GET_CLASS(vms); uint32_t irqflags = GIC_FDT_IRQ_FLAGS_LEVEL_HI; + MachineState *ms = MACHINE(vms); if (vmc->claim_edge_triggered_timers) { irqflags = GIC_FDT_IRQ_FLAGS_EDGE_LO_HI; @@ -327,19 +328,19 @@ static void fdt_add_timer_nodes(const VirtMachineState *vms) (1 << MACHINE(vms)->smp.cpus) - 1); } - qemu_fdt_add_subnode(vms->fdt, "/timer"); + qemu_fdt_add_subnode(ms->fdt, "/timer"); armcpu = ARM_CPU(qemu_get_cpu(0)); if (arm_feature(&armcpu->env, ARM_FEATURE_V8)) { const char compat[] = "arm,armv8-timer\0arm,armv7-timer"; - qemu_fdt_setprop(vms->fdt, "/timer", "compatible", + qemu_fdt_setprop(ms->fdt, "/timer", "compatible", compat, sizeof(compat)); } else { - qemu_fdt_setprop_string(vms->fdt, "/timer", "compatible", + qemu_fdt_setprop_string(ms->fdt, "/timer", "compatible", "arm,armv7-timer"); } - qemu_fdt_setprop(vms->fdt, "/timer", "always-on", NULL, 0); - qemu_fdt_setprop_cells(vms->fdt, "/timer", "interrupts", + qemu_fdt_setprop(ms->fdt, "/timer", "always-on", NULL, 0); + qemu_fdt_setprop_cells(ms->fdt, "/timer", "interrupts", GIC_FDT_IRQ_TYPE_PPI, ARCH_TIMER_S_EL1_IRQ, irqflags, GIC_FDT_IRQ_TYPE_PPI, ARCH_TIMER_NS_EL1_IRQ, irqflags, GIC_FDT_IRQ_TYPE_PPI, ARCH_TIMER_VIRT_IRQ, irqflags, @@ -375,35 +376,35 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms) } } - qemu_fdt_add_subnode(vms->fdt, "/cpus"); - qemu_fdt_setprop_cell(vms->fdt, "/cpus", "#address-cells", addr_cells); - qemu_fdt_setprop_cell(vms->fdt, "/cpus", "#size-cells", 0x0); + qemu_fdt_add_subnode(ms->fdt, "/cpus"); + qemu_fdt_setprop_cell(ms->fdt, "/cpus", "#address-cells", addr_cells); + qemu_fdt_setprop_cell(ms->fdt, "/cpus", "#size-cells", 0x0); for (cpu = smp_cpus - 1; cpu >= 0; cpu--) { char *nodename = g_strdup_printf("/cpus/cpu@%d", cpu); ARMCPU *armcpu = ARM_CPU(qemu_get_cpu(cpu)); CPUState *cs = CPU(armcpu); - qemu_fdt_add_subnode(vms->fdt, nodename); - qemu_fdt_setprop_string(vms->fdt, nodename, "device_type", "cpu"); - qemu_fdt_setprop_string(vms->fdt, nodename, "compatible", + qemu_fdt_add_subnode(ms->fdt, nodename); + qemu_fdt_setprop_string(ms->fdt, nodename, "device_type", "cpu"); + qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", armcpu->dtb_compatible); if (vms->psci_conduit != QEMU_PSCI_CONDUIT_DISABLED && smp_cpus > 1) { - qemu_fdt_setprop_string(vms->fdt, nodename, + qemu_fdt_setprop_string(ms->fdt, nodename, "enable-method", "psci"); } if (addr_cells == 2) { - qemu_fdt_setprop_u64(vms->fdt, nodename, "reg", + qemu_fdt_setprop_u64(ms->fdt, nodename, "reg", armcpu->mp_affinity); } else { - qemu_fdt_setprop_cell(vms->fdt, nodename, "reg", + qemu_fdt_setprop_cell(ms->fdt, nodename, "reg", armcpu->mp_affinity); } if (ms->possible_cpus->cpus[cs->cpu_index].props.has_node_id) { - qemu_fdt_setprop_cell(vms->fdt, nodename, "numa-node-id", + qemu_fdt_setprop_cell(ms->fdt, nodename, "numa-node-id", ms->possible_cpus->cpus[cs->cpu_index].props.node_id); } @@ -414,71 +415,74 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms) static void fdt_add_its_gic_node(VirtMachineState *vms) { char *nodename; + MachineState *ms = MACHINE(vms); - vms->msi_phandle = qemu_fdt_alloc_phandle(vms->fdt); + vms->msi_phandle = qemu_fdt_alloc_phandle(ms->fdt); nodename = g_strdup_printf("/intc/its@%" PRIx64, vms->memmap[VIRT_GIC_ITS].base); - qemu_fdt_add_subnode(vms->fdt, nodename); - qemu_fdt_setprop_string(vms->fdt, nodename, "compatible", + qemu_fdt_add_subnode(ms->fdt, nodename); + qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "arm,gic-v3-its"); - qemu_fdt_setprop(vms->fdt, nodename, "msi-controller", NULL, 0); - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_setprop(ms->fdt, nodename, "msi-controller", NULL, 0); + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, vms->memmap[VIRT_GIC_ITS].base, 2, vms->memmap[VIRT_GIC_ITS].size); - qemu_fdt_setprop_cell(vms->fdt, nodename, "phandle", vms->msi_phandle); + qemu_fdt_setprop_cell(ms->fdt, nodename, "phandle", vms->msi_phandle); g_free(nodename); } static void fdt_add_v2m_gic_node(VirtMachineState *vms) { + MachineState *ms = MACHINE(vms); char *nodename; nodename = g_strdup_printf("/intc/v2m@%" PRIx64, vms->memmap[VIRT_GIC_V2M].base); - vms->msi_phandle = qemu_fdt_alloc_phandle(vms->fdt); - qemu_fdt_add_subnode(vms->fdt, nodename); - qemu_fdt_setprop_string(vms->fdt, nodename, "compatible", + vms->msi_phandle = qemu_fdt_alloc_phandle(ms->fdt); + qemu_fdt_add_subnode(ms->fdt, nodename); + qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "arm,gic-v2m-frame"); - qemu_fdt_setprop(vms->fdt, nodename, "msi-controller", NULL, 0); - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_setprop(ms->fdt, nodename, "msi-controller", NULL, 0); + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, vms->memmap[VIRT_GIC_V2M].base, 2, vms->memmap[VIRT_GIC_V2M].size); - qemu_fdt_setprop_cell(vms->fdt, nodename, "phandle", vms->msi_phandle); + qemu_fdt_setprop_cell(ms->fdt, nodename, "phandle", vms->msi_phandle); g_free(nodename); } static void fdt_add_gic_node(VirtMachineState *vms) { + MachineState *ms = MACHINE(vms); char *nodename; - vms->gic_phandle = qemu_fdt_alloc_phandle(vms->fdt); - qemu_fdt_setprop_cell(vms->fdt, "/", "interrupt-parent", vms->gic_phandle); + vms->gic_phandle = qemu_fdt_alloc_phandle(ms->fdt); + qemu_fdt_setprop_cell(ms->fdt, "/", "interrupt-parent", vms->gic_phandle); nodename = g_strdup_printf("/intc@%" PRIx64, vms->memmap[VIRT_GIC_DIST].base); - qemu_fdt_add_subnode(vms->fdt, nodename); - qemu_fdt_setprop_cell(vms->fdt, nodename, "#interrupt-cells", 3); - qemu_fdt_setprop(vms->fdt, nodename, "interrupt-controller", NULL, 0); - qemu_fdt_setprop_cell(vms->fdt, nodename, "#address-cells", 0x2); - qemu_fdt_setprop_cell(vms->fdt, nodename, "#size-cells", 0x2); - qemu_fdt_setprop(vms->fdt, nodename, "ranges", NULL, 0); + qemu_fdt_add_subnode(ms->fdt, nodename); + qemu_fdt_setprop_cell(ms->fdt, nodename, "#interrupt-cells", 3); + qemu_fdt_setprop(ms->fdt, nodename, "interrupt-controller", NULL, 0); + qemu_fdt_setprop_cell(ms->fdt, nodename, "#address-cells", 0x2); + qemu_fdt_setprop_cell(ms->fdt, nodename, "#size-cells", 0x2); + qemu_fdt_setprop(ms->fdt, nodename, "ranges", NULL, 0); if (vms->gic_version == VIRT_GIC_VERSION_3) { int nb_redist_regions = virt_gicv3_redist_region_count(vms); - qemu_fdt_setprop_string(vms->fdt, nodename, "compatible", + qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "arm,gic-v3"); - qemu_fdt_setprop_cell(vms->fdt, nodename, + qemu_fdt_setprop_cell(ms->fdt, nodename, "#redistributor-regions", nb_redist_regions); if (nb_redist_regions == 1) { - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, vms->memmap[VIRT_GIC_DIST].base, 2, vms->memmap[VIRT_GIC_DIST].size, 2, vms->memmap[VIRT_GIC_REDIST].base, 2, vms->memmap[VIRT_GIC_REDIST].size); } else { - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, vms->memmap[VIRT_GIC_DIST].base, 2, vms->memmap[VIRT_GIC_DIST].size, 2, vms->memmap[VIRT_GIC_REDIST].base, @@ -488,22 +492,22 @@ static void fdt_add_gic_node(VirtMachineState *vms) } if (vms->virt) { - qemu_fdt_setprop_cells(vms->fdt, nodename, "interrupts", + qemu_fdt_setprop_cells(ms->fdt, nodename, "interrupts", GIC_FDT_IRQ_TYPE_PPI, ARCH_GIC_MAINT_IRQ, GIC_FDT_IRQ_FLAGS_LEVEL_HI); } } else { /* 'cortex-a15-gic' means 'GIC v2' */ - qemu_fdt_setprop_string(vms->fdt, nodename, "compatible", + qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "arm,cortex-a15-gic"); if (!vms->virt) { - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, vms->memmap[VIRT_GIC_DIST].base, 2, vms->memmap[VIRT_GIC_DIST].size, 2, vms->memmap[VIRT_GIC_CPU].base, 2, vms->memmap[VIRT_GIC_CPU].size); } else { - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, vms->memmap[VIRT_GIC_DIST].base, 2, vms->memmap[VIRT_GIC_DIST].size, 2, vms->memmap[VIRT_GIC_CPU].base, @@ -512,13 +516,13 @@ static void fdt_add_gic_node(VirtMachineState *vms) 2, vms->memmap[VIRT_GIC_HYP].size, 2, vms->memmap[VIRT_GIC_VCPU].base, 2, vms->memmap[VIRT_GIC_VCPU].size); - qemu_fdt_setprop_cells(vms->fdt, nodename, "interrupts", + qemu_fdt_setprop_cells(ms->fdt, nodename, "interrupts", GIC_FDT_IRQ_TYPE_PPI, ARCH_GIC_MAINT_IRQ, GIC_FDT_IRQ_FLAGS_LEVEL_HI); } } - qemu_fdt_setprop_cell(vms->fdt, nodename, "phandle", vms->gic_phandle); + qemu_fdt_setprop_cell(ms->fdt, nodename, "phandle", vms->gic_phandle); g_free(nodename); } @@ -526,6 +530,7 @@ static void fdt_add_pmu_nodes(const VirtMachineState *vms) { ARMCPU *armcpu = ARM_CPU(first_cpu); uint32_t irqflags = GIC_FDT_IRQ_FLAGS_LEVEL_HI; + MachineState *ms = MACHINE(vms); if (!arm_feature(&armcpu->env, ARM_FEATURE_PMU)) { assert(!object_property_get_bool(OBJECT(armcpu), "pmu", NULL)); @@ -538,12 +543,12 @@ static void fdt_add_pmu_nodes(const VirtMachineState *vms) (1 << MACHINE(vms)->smp.cpus) - 1); } - qemu_fdt_add_subnode(vms->fdt, "/pmu"); + qemu_fdt_add_subnode(ms->fdt, "/pmu"); if (arm_feature(&armcpu->env, ARM_FEATURE_V8)) { const char compat[] = "arm,armv8-pmuv3"; - qemu_fdt_setprop(vms->fdt, "/pmu", "compatible", + qemu_fdt_setprop(ms->fdt, "/pmu", "compatible", compat, sizeof(compat)); - qemu_fdt_setprop_cells(vms->fdt, "/pmu", "interrupts", + qemu_fdt_setprop_cells(ms->fdt, "/pmu", "interrupts", GIC_FDT_IRQ_TYPE_PPI, VIRTUAL_PMU_IRQ, irqflags); } } @@ -749,6 +754,7 @@ static void create_uart(const VirtMachineState *vms, int uart, const char clocknames[] = "uartclk\0apb_pclk"; DeviceState *dev = qdev_new(TYPE_PL011); SysBusDevice *s = SYS_BUS_DEVICE(dev); + MachineState *ms = MACHINE(vms); qdev_prop_set_chr(dev, "chardev", chr); sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); @@ -757,28 +763,28 @@ static void create_uart(const VirtMachineState *vms, int uart, sysbus_connect_irq(s, 0, qdev_get_gpio_in(vms->gic, irq)); nodename = g_strdup_printf("/pl011@%" PRIx64, base); - qemu_fdt_add_subnode(vms->fdt, nodename); + qemu_fdt_add_subnode(ms->fdt, nodename); /* Note that we can't use setprop_string because of the embedded NUL */ - qemu_fdt_setprop(vms->fdt, nodename, "compatible", + qemu_fdt_setprop(ms->fdt, nodename, "compatible", compat, sizeof(compat)); - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, base, 2, size); - qemu_fdt_setprop_cells(vms->fdt, nodename, "interrupts", + qemu_fdt_setprop_cells(ms->fdt, nodename, "interrupts", GIC_FDT_IRQ_TYPE_SPI, irq, GIC_FDT_IRQ_FLAGS_LEVEL_HI); - qemu_fdt_setprop_cells(vms->fdt, nodename, "clocks", + qemu_fdt_setprop_cells(ms->fdt, nodename, "clocks", vms->clock_phandle, vms->clock_phandle); - qemu_fdt_setprop(vms->fdt, nodename, "clock-names", + qemu_fdt_setprop(ms->fdt, nodename, "clock-names", clocknames, sizeof(clocknames)); if (uart == VIRT_UART) { - qemu_fdt_setprop_string(vms->fdt, "/chosen", "stdout-path", nodename); + qemu_fdt_setprop_string(ms->fdt, "/chosen", "stdout-path", nodename); } else { /* Mark as not usable by the normal world */ - qemu_fdt_setprop_string(vms->fdt, nodename, "status", "disabled"); - qemu_fdt_setprop_string(vms->fdt, nodename, "secure-status", "okay"); + qemu_fdt_setprop_string(ms->fdt, nodename, "status", "disabled"); + qemu_fdt_setprop_string(ms->fdt, nodename, "secure-status", "okay"); - qemu_fdt_setprop_string(vms->fdt, "/secure-chosen", "stdout-path", + qemu_fdt_setprop_string(ms->fdt, "/secure-chosen", "stdout-path", nodename); } @@ -792,19 +798,20 @@ static void create_rtc(const VirtMachineState *vms) hwaddr size = vms->memmap[VIRT_RTC].size; int irq = vms->irqmap[VIRT_RTC]; const char compat[] = "arm,pl031\0arm,primecell"; + MachineState *ms = MACHINE(vms); sysbus_create_simple("pl031", base, qdev_get_gpio_in(vms->gic, irq)); nodename = g_strdup_printf("/pl031@%" PRIx64, base); - qemu_fdt_add_subnode(vms->fdt, nodename); - qemu_fdt_setprop(vms->fdt, nodename, "compatible", compat, sizeof(compat)); - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_add_subnode(ms->fdt, nodename); + qemu_fdt_setprop(ms->fdt, nodename, "compatible", compat, sizeof(compat)); + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, base, 2, size); - qemu_fdt_setprop_cells(vms->fdt, nodename, "interrupts", + qemu_fdt_setprop_cells(ms->fdt, nodename, "interrupts", GIC_FDT_IRQ_TYPE_SPI, irq, GIC_FDT_IRQ_FLAGS_LEVEL_HI); - qemu_fdt_setprop_cell(vms->fdt, nodename, "clocks", vms->clock_phandle); - qemu_fdt_setprop_string(vms->fdt, nodename, "clock-names", "apb_pclk"); + qemu_fdt_setprop_cell(ms->fdt, nodename, "clocks", vms->clock_phandle); + qemu_fdt_setprop_string(ms->fdt, nodename, "clock-names", "apb_pclk"); g_free(nodename); } @@ -821,32 +828,30 @@ static void virt_powerdown_req(Notifier *n, void *opaque) } } -static void create_gpio_keys(const VirtMachineState *vms, - DeviceState *pl061_dev, +static void create_gpio_keys(char *fdt, DeviceState *pl061_dev, uint32_t phandle) { gpio_key_dev = sysbus_create_simple("gpio-key", -1, qdev_get_gpio_in(pl061_dev, 3)); - qemu_fdt_add_subnode(vms->fdt, "/gpio-keys"); - qemu_fdt_setprop_string(vms->fdt, "/gpio-keys", "compatible", "gpio-keys"); - qemu_fdt_setprop_cell(vms->fdt, "/gpio-keys", "#size-cells", 0); - qemu_fdt_setprop_cell(vms->fdt, "/gpio-keys", "#address-cells", 1); + qemu_fdt_add_subnode(fdt, "/gpio-keys"); + qemu_fdt_setprop_string(fdt, "/gpio-keys", "compatible", "gpio-keys"); + qemu_fdt_setprop_cell(fdt, "/gpio-keys", "#size-cells", 0); + qemu_fdt_setprop_cell(fdt, "/gpio-keys", "#address-cells", 1); - qemu_fdt_add_subnode(vms->fdt, "/gpio-keys/poweroff"); - qemu_fdt_setprop_string(vms->fdt, "/gpio-keys/poweroff", + qemu_fdt_add_subnode(fdt, "/gpio-keys/poweroff"); + qemu_fdt_setprop_string(fdt, "/gpio-keys/poweroff", "label", "GPIO Key Poweroff"); - qemu_fdt_setprop_cell(vms->fdt, "/gpio-keys/poweroff", "linux,code", + qemu_fdt_setprop_cell(fdt, "/gpio-keys/poweroff", "linux,code", KEY_POWER); - qemu_fdt_setprop_cells(vms->fdt, "/gpio-keys/poweroff", + qemu_fdt_setprop_cells(fdt, "/gpio-keys/poweroff", "gpios", phandle, 3, 0); } #define SECURE_GPIO_POWEROFF 0 #define SECURE_GPIO_RESET 1 -static void create_secure_gpio_pwr(const VirtMachineState *vms, - DeviceState *pl061_dev, +static void create_secure_gpio_pwr(char *fdt, DeviceState *pl061_dev, uint32_t phandle) { DeviceState *gpio_pwr_dev; @@ -860,22 +865,22 @@ static void create_secure_gpio_pwr(const VirtMachineState *vms, qdev_connect_gpio_out(pl061_dev, SECURE_GPIO_POWEROFF, qdev_get_gpio_in_named(gpio_pwr_dev, "shutdown", 0)); - qemu_fdt_add_subnode(vms->fdt, "/gpio-poweroff"); - qemu_fdt_setprop_string(vms->fdt, "/gpio-poweroff", "compatible", + qemu_fdt_add_subnode(fdt, "/gpio-poweroff"); + qemu_fdt_setprop_string(fdt, "/gpio-poweroff", "compatible", "gpio-poweroff"); - qemu_fdt_setprop_cells(vms->fdt, "/gpio-poweroff", + qemu_fdt_setprop_cells(fdt, "/gpio-poweroff", "gpios", phandle, SECURE_GPIO_POWEROFF, 0); - qemu_fdt_setprop_string(vms->fdt, "/gpio-poweroff", "status", "disabled"); - qemu_fdt_setprop_string(vms->fdt, "/gpio-poweroff", "secure-status", + qemu_fdt_setprop_string(fdt, "/gpio-poweroff", "status", "disabled"); + qemu_fdt_setprop_string(fdt, "/gpio-poweroff", "secure-status", "okay"); - qemu_fdt_add_subnode(vms->fdt, "/gpio-restart"); - qemu_fdt_setprop_string(vms->fdt, "/gpio-restart", "compatible", + qemu_fdt_add_subnode(fdt, "/gpio-restart"); + qemu_fdt_setprop_string(fdt, "/gpio-restart", "compatible", "gpio-restart"); - qemu_fdt_setprop_cells(vms->fdt, "/gpio-restart", + qemu_fdt_setprop_cells(fdt, "/gpio-restart", "gpios", phandle, SECURE_GPIO_RESET, 0); - qemu_fdt_setprop_string(vms->fdt, "/gpio-restart", "status", "disabled"); - qemu_fdt_setprop_string(vms->fdt, "/gpio-restart", "secure-status", + qemu_fdt_setprop_string(fdt, "/gpio-restart", "status", "disabled"); + qemu_fdt_setprop_string(fdt, "/gpio-restart", "secure-status", "okay"); } @@ -889,6 +894,7 @@ static void create_gpio_devices(const VirtMachineState *vms, int gpio, int irq = vms->irqmap[gpio]; const char compat[] = "arm,pl061\0arm,primecell"; SysBusDevice *s; + MachineState *ms = MACHINE(vms); pl061_dev = qdev_new("pl061"); s = SYS_BUS_DEVICE(pl061_dev); @@ -896,33 +902,33 @@ static void create_gpio_devices(const VirtMachineState *vms, int gpio, memory_region_add_subregion(mem, base, sysbus_mmio_get_region(s, 0)); sysbus_connect_irq(s, 0, qdev_get_gpio_in(vms->gic, irq)); - uint32_t phandle = qemu_fdt_alloc_phandle(vms->fdt); + uint32_t phandle = qemu_fdt_alloc_phandle(ms->fdt); nodename = g_strdup_printf("/pl061@%" PRIx64, base); - qemu_fdt_add_subnode(vms->fdt, nodename); - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_add_subnode(ms->fdt, nodename); + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, base, 2, size); - qemu_fdt_setprop(vms->fdt, nodename, "compatible", compat, sizeof(compat)); - qemu_fdt_setprop_cell(vms->fdt, nodename, "#gpio-cells", 2); - qemu_fdt_setprop(vms->fdt, nodename, "gpio-controller", NULL, 0); - qemu_fdt_setprop_cells(vms->fdt, nodename, "interrupts", + qemu_fdt_setprop(ms->fdt, nodename, "compatible", compat, sizeof(compat)); + qemu_fdt_setprop_cell(ms->fdt, nodename, "#gpio-cells", 2); + qemu_fdt_setprop(ms->fdt, nodename, "gpio-controller", NULL, 0); + qemu_fdt_setprop_cells(ms->fdt, nodename, "interrupts", GIC_FDT_IRQ_TYPE_SPI, irq, GIC_FDT_IRQ_FLAGS_LEVEL_HI); - qemu_fdt_setprop_cell(vms->fdt, nodename, "clocks", vms->clock_phandle); - qemu_fdt_setprop_string(vms->fdt, nodename, "clock-names", "apb_pclk"); - qemu_fdt_setprop_cell(vms->fdt, nodename, "phandle", phandle); + qemu_fdt_setprop_cell(ms->fdt, nodename, "clocks", vms->clock_phandle); + qemu_fdt_setprop_string(ms->fdt, nodename, "clock-names", "apb_pclk"); + qemu_fdt_setprop_cell(ms->fdt, nodename, "phandle", phandle); if (gpio != VIRT_GPIO) { /* Mark as not usable by the normal world */ - qemu_fdt_setprop_string(vms->fdt, nodename, "status", "disabled"); - qemu_fdt_setprop_string(vms->fdt, nodename, "secure-status", "okay"); + qemu_fdt_setprop_string(ms->fdt, nodename, "status", "disabled"); + qemu_fdt_setprop_string(ms->fdt, nodename, "secure-status", "okay"); } g_free(nodename); /* Child gpio devices */ if (gpio == VIRT_GPIO) { - create_gpio_keys(vms, pl061_dev, phandle); + create_gpio_keys(ms->fdt, pl061_dev, phandle); } else { - create_secure_gpio_pwr(vms, pl061_dev, phandle); + create_secure_gpio_pwr(ms->fdt, pl061_dev, phandle); } } @@ -930,6 +936,7 @@ static void create_virtio_devices(const VirtMachineState *vms) { int i; hwaddr size = vms->memmap[VIRT_MMIO].size; + MachineState *ms = MACHINE(vms); /* We create the transports in forwards order. Since qbus_realize() * prepends (not appends) new child buses, the incrementing loop below will @@ -979,15 +986,15 @@ static void create_virtio_devices(const VirtMachineState *vms) hwaddr base = vms->memmap[VIRT_MMIO].base + i * size; nodename = g_strdup_printf("/virtio_mmio@%" PRIx64, base); - qemu_fdt_add_subnode(vms->fdt, nodename); - qemu_fdt_setprop_string(vms->fdt, nodename, + qemu_fdt_add_subnode(ms->fdt, nodename); + qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "virtio,mmio"); - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, base, 2, size); - qemu_fdt_setprop_cells(vms->fdt, nodename, "interrupts", + qemu_fdt_setprop_cells(ms->fdt, nodename, "interrupts", GIC_FDT_IRQ_TYPE_SPI, irq, GIC_FDT_IRQ_FLAGS_EDGE_LO_HI); - qemu_fdt_setprop(vms->fdt, nodename, "dma-coherent", NULL, 0); + qemu_fdt_setprop(ms->fdt, nodename, "dma-coherent", NULL, 0); g_free(nodename); } } @@ -1068,17 +1075,18 @@ static void virt_flash_fdt(VirtMachineState *vms, { hwaddr flashsize = vms->memmap[VIRT_FLASH].size / 2; hwaddr flashbase = vms->memmap[VIRT_FLASH].base; + MachineState *ms = MACHINE(vms); char *nodename; if (sysmem == secure_sysmem) { /* Report both flash devices as a single node in the DT */ nodename = g_strdup_printf("/flash@%" PRIx64, flashbase); - qemu_fdt_add_subnode(vms->fdt, nodename); - qemu_fdt_setprop_string(vms->fdt, nodename, "compatible", "cfi-flash"); - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_add_subnode(ms->fdt, nodename); + qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "cfi-flash"); + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, flashbase, 2, flashsize, 2, flashbase + flashsize, 2, flashsize); - qemu_fdt_setprop_cell(vms->fdt, nodename, "bank-width", 4); + qemu_fdt_setprop_cell(ms->fdt, nodename, "bank-width", 4); g_free(nodename); } else { /* @@ -1086,21 +1094,21 @@ static void virt_flash_fdt(VirtMachineState *vms, * only visible to the secure world. */ nodename = g_strdup_printf("/secflash@%" PRIx64, flashbase); - qemu_fdt_add_subnode(vms->fdt, nodename); - qemu_fdt_setprop_string(vms->fdt, nodename, "compatible", "cfi-flash"); - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_add_subnode(ms->fdt, nodename); + qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "cfi-flash"); + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, flashbase, 2, flashsize); - qemu_fdt_setprop_cell(vms->fdt, nodename, "bank-width", 4); - qemu_fdt_setprop_string(vms->fdt, nodename, "status", "disabled"); - qemu_fdt_setprop_string(vms->fdt, nodename, "secure-status", "okay"); + qemu_fdt_setprop_cell(ms->fdt, nodename, "bank-width", 4); + qemu_fdt_setprop_string(ms->fdt, nodename, "status", "disabled"); + qemu_fdt_setprop_string(ms->fdt, nodename, "secure-status", "okay"); g_free(nodename); nodename = g_strdup_printf("/flash@%" PRIx64, flashbase); - qemu_fdt_add_subnode(vms->fdt, nodename); - qemu_fdt_setprop_string(vms->fdt, nodename, "compatible", "cfi-flash"); - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_add_subnode(ms->fdt, nodename); + qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "cfi-flash"); + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, flashbase + flashsize, 2, flashsize); - qemu_fdt_setprop_cell(vms->fdt, nodename, "bank-width", 4); + qemu_fdt_setprop_cell(ms->fdt, nodename, "bank-width", 4); g_free(nodename); } } @@ -1167,17 +1175,17 @@ static FWCfgState *create_fw_cfg(const VirtMachineState *vms, AddressSpace *as) fw_cfg_add_i16(fw_cfg, FW_CFG_NB_CPUS, (uint16_t)ms->smp.cpus); nodename = g_strdup_printf("/fw-cfg@%" PRIx64, base); - qemu_fdt_add_subnode(vms->fdt, nodename); - qemu_fdt_setprop_string(vms->fdt, nodename, + qemu_fdt_add_subnode(ms->fdt, nodename); + qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "qemu,fw-cfg-mmio"); - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, base, 2, size); - qemu_fdt_setprop(vms->fdt, nodename, "dma-coherent", NULL, 0); + qemu_fdt_setprop(ms->fdt, nodename, "dma-coherent", NULL, 0); g_free(nodename); return fw_cfg; } -static void create_pcie_irq_map(const VirtMachineState *vms, +static void create_pcie_irq_map(const MachineState *ms, uint32_t gic_phandle, int first_irq, const char *nodename) { @@ -1205,10 +1213,10 @@ static void create_pcie_irq_map(const VirtMachineState *vms, } } - qemu_fdt_setprop(vms->fdt, nodename, "interrupt-map", + qemu_fdt_setprop(ms->fdt, nodename, "interrupt-map", full_irq_map, sizeof(full_irq_map)); - qemu_fdt_setprop_cells(vms->fdt, nodename, "interrupt-map-mask", + qemu_fdt_setprop_cells(ms->fdt, nodename, "interrupt-map-mask", cpu_to_be16(PCI_DEVFN(3, 0)), /* Slot 3 */ 0, 0, 0x7 /* PCI irq */); @@ -1225,6 +1233,7 @@ static void create_smmu(const VirtMachineState *vms, hwaddr size = vms->memmap[VIRT_SMMU].size; const char irq_names[] = "eventq\0priq\0cmdq-sync\0gerror"; DeviceState *dev; + MachineState *ms = MACHINE(vms); if (vms->iommu != VIRT_IOMMU_SMMUV3 || !vms->iommu_phandle) { return; @@ -1242,26 +1251,26 @@ static void create_smmu(const VirtMachineState *vms, } node = g_strdup_printf("/smmuv3@%" PRIx64, base); - qemu_fdt_add_subnode(vms->fdt, node); - qemu_fdt_setprop(vms->fdt, node, "compatible", compat, sizeof(compat)); - qemu_fdt_setprop_sized_cells(vms->fdt, node, "reg", 2, base, 2, size); + qemu_fdt_add_subnode(ms->fdt, node); + qemu_fdt_setprop(ms->fdt, node, "compatible", compat, sizeof(compat)); + qemu_fdt_setprop_sized_cells(ms->fdt, node, "reg", 2, base, 2, size); - qemu_fdt_setprop_cells(vms->fdt, node, "interrupts", + qemu_fdt_setprop_cells(ms->fdt, node, "interrupts", GIC_FDT_IRQ_TYPE_SPI, irq , GIC_FDT_IRQ_FLAGS_EDGE_LO_HI, GIC_FDT_IRQ_TYPE_SPI, irq + 1, GIC_FDT_IRQ_FLAGS_EDGE_LO_HI, GIC_FDT_IRQ_TYPE_SPI, irq + 2, GIC_FDT_IRQ_FLAGS_EDGE_LO_HI, GIC_FDT_IRQ_TYPE_SPI, irq + 3, GIC_FDT_IRQ_FLAGS_EDGE_LO_HI); - qemu_fdt_setprop(vms->fdt, node, "interrupt-names", irq_names, + qemu_fdt_setprop(ms->fdt, node, "interrupt-names", irq_names, sizeof(irq_names)); - qemu_fdt_setprop_cell(vms->fdt, node, "clocks", vms->clock_phandle); - qemu_fdt_setprop_string(vms->fdt, node, "clock-names", "apb_pclk"); - qemu_fdt_setprop(vms->fdt, node, "dma-coherent", NULL, 0); + qemu_fdt_setprop_cell(ms->fdt, node, "clocks", vms->clock_phandle); + qemu_fdt_setprop_string(ms->fdt, node, "clock-names", "apb_pclk"); + qemu_fdt_setprop(ms->fdt, node, "dma-coherent", NULL, 0); - qemu_fdt_setprop_cell(vms->fdt, node, "#iommu-cells", 1); + qemu_fdt_setprop_cell(ms->fdt, node, "#iommu-cells", 1); - qemu_fdt_setprop_cell(vms->fdt, node, "phandle", vms->iommu_phandle); + qemu_fdt_setprop_cell(ms->fdt, node, "phandle", vms->iommu_phandle); g_free(node); } @@ -1269,22 +1278,23 @@ static void create_virtio_iommu_dt_bindings(VirtMachineState *vms) { const char compat[] = "virtio,pci-iommu"; uint16_t bdf = vms->virtio_iommu_bdf; + MachineState *ms = MACHINE(vms); char *node; - vms->iommu_phandle = qemu_fdt_alloc_phandle(vms->fdt); + vms->iommu_phandle = qemu_fdt_alloc_phandle(ms->fdt); node = g_strdup_printf("%s/virtio_iommu@%d", vms->pciehb_nodename, bdf); - qemu_fdt_add_subnode(vms->fdt, node); - qemu_fdt_setprop(vms->fdt, node, "compatible", compat, sizeof(compat)); - qemu_fdt_setprop_sized_cells(vms->fdt, node, "reg", + qemu_fdt_add_subnode(ms->fdt, node); + qemu_fdt_setprop(ms->fdt, node, "compatible", compat, sizeof(compat)); + qemu_fdt_setprop_sized_cells(ms->fdt, node, "reg", 1, bdf << 8, 1, 0, 1, 0, 1, 0, 1, 0); - qemu_fdt_setprop_cell(vms->fdt, node, "#iommu-cells", 1); - qemu_fdt_setprop_cell(vms->fdt, node, "phandle", vms->iommu_phandle); + qemu_fdt_setprop_cell(ms->fdt, node, "#iommu-cells", 1); + qemu_fdt_setprop_cell(ms->fdt, node, "phandle", vms->iommu_phandle); g_free(node); - qemu_fdt_setprop_cells(vms->fdt, vms->pciehb_nodename, "iommu-map", + qemu_fdt_setprop_cells(ms->fdt, vms->pciehb_nodename, "iommu-map", 0x0, vms->iommu_phandle, 0x0, bdf, bdf + 1, vms->iommu_phandle, bdf + 1, 0xffff - bdf); } @@ -1309,6 +1319,7 @@ static void create_pcie(VirtMachineState *vms) char *nodename; int i, ecam_id; PCIHostState *pci; + MachineState *ms = MACHINE(vms); dev = qdev_new(TYPE_GPEX_HOST); sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); @@ -1369,27 +1380,27 @@ static void create_pcie(VirtMachineState *vms) } nodename = vms->pciehb_nodename = g_strdup_printf("/pcie@%" PRIx64, base); - qemu_fdt_add_subnode(vms->fdt, nodename); - qemu_fdt_setprop_string(vms->fdt, nodename, + qemu_fdt_add_subnode(ms->fdt, nodename); + qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "pci-host-ecam-generic"); - qemu_fdt_setprop_string(vms->fdt, nodename, "device_type", "pci"); - qemu_fdt_setprop_cell(vms->fdt, nodename, "#address-cells", 3); - qemu_fdt_setprop_cell(vms->fdt, nodename, "#size-cells", 2); - qemu_fdt_setprop_cell(vms->fdt, nodename, "linux,pci-domain", 0); - qemu_fdt_setprop_cells(vms->fdt, nodename, "bus-range", 0, + qemu_fdt_setprop_string(ms->fdt, nodename, "device_type", "pci"); + qemu_fdt_setprop_cell(ms->fdt, nodename, "#address-cells", 3); + qemu_fdt_setprop_cell(ms->fdt, nodename, "#size-cells", 2); + qemu_fdt_setprop_cell(ms->fdt, nodename, "linux,pci-domain", 0); + qemu_fdt_setprop_cells(ms->fdt, nodename, "bus-range", 0, nr_pcie_buses - 1); - qemu_fdt_setprop(vms->fdt, nodename, "dma-coherent", NULL, 0); + qemu_fdt_setprop(ms->fdt, nodename, "dma-coherent", NULL, 0); if (vms->msi_phandle) { - qemu_fdt_setprop_cells(vms->fdt, nodename, "msi-parent", + qemu_fdt_setprop_cells(ms->fdt, nodename, "msi-parent", vms->msi_phandle); } - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, base_ecam, 2, size_ecam); if (vms->highmem) { - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "ranges", + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "ranges", 1, FDT_PCI_RANGE_IOPORT, 2, 0, 2, base_pio, 2, size_pio, 1, FDT_PCI_RANGE_MMIO, 2, base_mmio, @@ -1398,23 +1409,23 @@ static void create_pcie(VirtMachineState *vms) 2, base_mmio_high, 2, base_mmio_high, 2, size_mmio_high); } else { - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "ranges", + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "ranges", 1, FDT_PCI_RANGE_IOPORT, 2, 0, 2, base_pio, 2, size_pio, 1, FDT_PCI_RANGE_MMIO, 2, base_mmio, 2, base_mmio, 2, size_mmio); } - qemu_fdt_setprop_cell(vms->fdt, nodename, "#interrupt-cells", 1); - create_pcie_irq_map(vms, vms->gic_phandle, irq, nodename); + qemu_fdt_setprop_cell(ms->fdt, nodename, "#interrupt-cells", 1); + create_pcie_irq_map(ms, vms->gic_phandle, irq, nodename); if (vms->iommu) { - vms->iommu_phandle = qemu_fdt_alloc_phandle(vms->fdt); + vms->iommu_phandle = qemu_fdt_alloc_phandle(ms->fdt); switch (vms->iommu) { case VIRT_IOMMU_SMMUV3: create_smmu(vms, vms->bus); - qemu_fdt_setprop_cells(vms->fdt, nodename, "iommu-map", + qemu_fdt_setprop_cells(ms->fdt, nodename, "iommu-map", 0x0, vms->iommu_phandle, 0x0, 0x10000); break; default: @@ -1466,17 +1477,18 @@ static void create_secure_ram(VirtMachineState *vms, char *nodename; hwaddr base = vms->memmap[VIRT_SECURE_MEM].base; hwaddr size = vms->memmap[VIRT_SECURE_MEM].size; + MachineState *ms = MACHINE(vms); memory_region_init_ram(secram, NULL, "virt.secure-ram", size, &error_fatal); memory_region_add_subregion(secure_sysmem, base, secram); nodename = g_strdup_printf("/secram@%" PRIx64, base); - qemu_fdt_add_subnode(vms->fdt, nodename); - qemu_fdt_setprop_string(vms->fdt, nodename, "device_type", "memory"); - qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg", 2, base, 2, size); - qemu_fdt_setprop_string(vms->fdt, nodename, "status", "disabled"); - qemu_fdt_setprop_string(vms->fdt, nodename, "secure-status", "okay"); + qemu_fdt_add_subnode(ms->fdt, nodename); + qemu_fdt_setprop_string(ms->fdt, nodename, "device_type", "memory"); + qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, base, 2, size); + qemu_fdt_setprop_string(ms->fdt, nodename, "status", "disabled"); + qemu_fdt_setprop_string(ms->fdt, nodename, "secure-status", "okay"); if (secure_tag_sysmem) { create_tag_ram(secure_tag_sysmem, base, size, "mach-virt.secure-tag"); @@ -1489,9 +1501,11 @@ static void *machvirt_dtb(const struct arm_boot_info *binfo, int *fdt_size) { const VirtMachineState *board = container_of(binfo, VirtMachineState, bootinfo); + MachineState *ms = MACHINE(board); + *fdt_size = board->fdt_size; - return board->fdt; + return ms->fdt; } static void virt_build_smbios(VirtMachineState *vms) @@ -1539,7 +1553,7 @@ void virt_machine_done(Notifier *notifier, void *data) * while qemu takes charge of the qom stuff. */ if (info->dtb_filename == NULL) { - platform_bus_add_all_fdt_nodes(vms->fdt, "/intc", + platform_bus_add_all_fdt_nodes(ms->fdt, "/intc", vms->memmap[VIRT_PLATFORM_BUS].base, vms->memmap[VIRT_PLATFORM_BUS].size, vms->irqmap[VIRT_PLATFORM_BUS]); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 17:37:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 17:37:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92930.175296 (Exim 4.92) (envelope-from ) id 1lHVQj-0008LE-PZ; Wed, 03 Mar 2021 17:37:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92930.175296; Wed, 03 Mar 2021 17:37:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVQj-0008L5-MA; Wed, 03 Mar 2021 17:37:01 +0000 Received: by outflank-mailman (input) for mailman id 92930; Wed, 03 Mar 2021 17:37:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVQi-0008CL-SK for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 17:37:00 +0000 Received: from mail-wr1-x42b.google.com (unknown [2a00:1450:4864:20::42b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7289c2ca-f3bd-458a-a3da-5a236f322048; Wed, 03 Mar 2021 17:36:49 +0000 (UTC) Received: by mail-wr1-x42b.google.com with SMTP id u14so24616596wri.3 for ; Wed, 03 Mar 2021 09:36:49 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id h19sm6231629wmq.47.2021.03.03.09.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 09:36:45 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id B07741FF90; Wed, 3 Mar 2021 17:36:42 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7289c2ca-f3bd-458a-a3da-5a236f322048 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iHRfGlUF89rzuFd8QIBdIG6ipsTcEiSa/7G6DKHjb/Y=; b=UOi2W9Dajv94ODNf3/ndcLHC6JWe1BQOkEN2kAEHGDw5p5RBgH4uz0tXKuArDs5yN0 nJJ+VRAVNrSSWVLHxU4qDHQLwi9/6j4lLig/7nZ4YeoSXnYZ9rGgtZbZUs/bW4Co+vBN suRS7evWcePgIzOxwSRZWeOlPsx6sdixObqGqan8hgtb8do8DHvh3HlEzE4vbaFeuPbo +tgoLte9xfzOBFARBUzx2cCEqcXd9TGmsaKsJZezRhSUoCeCGm5ZyF7De2UMhlbV62h7 NgXjCsV1XF+pH4KxrDSeFhSxhzcHTy7rCqws0yOOZNoBUuAdUV7O9PcHay08tmSnbaNN oMtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iHRfGlUF89rzuFd8QIBdIG6ipsTcEiSa/7G6DKHjb/Y=; b=iiC2p7ejzcqP3HLgp/1oREjWQK10usBW/HwZEzsgrCOkwWL5ifS7iPyUxVLKX9m1TY rg3BiX0aPA43lRkRClfKp5RcKi8aw56jdYOXsD3hszDpveehtWXWRQSwJL45qixdwDDf R3+0ko2dsKKabXPjni+epDpEzXP0HgGKOSahHUoJWvmON5ju9lkE/9N1GJ2wkLIV/lZO 600FIwnPb64IGokMhJwdJlzen6DBShxHdqX03qtVJk4vcjOm387XIJgHgWk3amaXRuh3 siPhEUvXMdL/BQXeRM7ISAGu7PmOCOOPl/o6RUp362488SBVn7RHaqswHc3PlR1yM8rA NK/w== X-Gm-Message-State: AOAM532zPRPFlOJ+x9R2mqOwFQsmc2PbsXb2Ehw/bG8N2QzyEh6vjd3P +t3mf4vzCBqOoJ7619dz9svp5A== X-Google-Smtp-Source: ABdhPJzH5LNshn4liYj21qEXwr6UDgNeTa8jKYfPwDETPglDH26uQdqZqjvZV6ov7HY6Hklz3lKKNA== X-Received: by 2002:adf:e582:: with SMTP id l2mr28610370wrm.207.1614793008181; Wed, 03 Mar 2021 09:36:48 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: julien@xen.org, stefano.stabellini@linaro.org, stefano.stabellini@xilinx.com, andre.przywara@arm.com, stratos-dev@op-lists.linaro.org, xen-devel@lists.xenproject.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH v3 4/7] hw/core: implement a guest-loader to support static hypervisor guests Date: Wed, 3 Mar 2021 17:36:39 +0000 Message-Id: <20210303173642.3805-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210303173642.3805-1-alex.bennee@linaro.org> References: <20210303173642.3805-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hypervisors, especially type-1 ones, need the firmware/bootcode to put their initial guest somewhere in memory and pass the information to it via platform data. The guest-loader is modelled after the generic loader for exactly this sort of purpose: $QEMU $ARGS -kernel ~/xen.git/xen/xen \ -append "dom0_mem=1G,max:1G loglvl=all guest_loglvl=all" \ -device guest-loader,addr=0x42000000,kernel=Image,bootargs="root=/dev/sda2 ro console=hvc0 earlyprintk=xen" \ -device guest-loader,addr=0x47000000,initrd=rootfs.cpio Signed-off-by: Alex Bennée Message-Id: <20201105175153.30489-5-alex.bennee@linaro.org> Message-Id: <20210211171945.18313-5-alex.bennee@linaro.org> --- hw/core/guest-loader.h | 34 ++++++++++ hw/core/guest-loader.c | 145 +++++++++++++++++++++++++++++++++++++++++ MAINTAINERS | 5 ++ hw/core/meson.build | 2 + 4 files changed, 186 insertions(+) create mode 100644 hw/core/guest-loader.h create mode 100644 hw/core/guest-loader.c diff --git a/hw/core/guest-loader.h b/hw/core/guest-loader.h new file mode 100644 index 0000000000..07f4b4884b --- /dev/null +++ b/hw/core/guest-loader.h @@ -0,0 +1,34 @@ +/* + * Guest Loader + * + * Copyright (C) 2020 Linaro + * Written by Alex Bennée + * (based on the generic-loader by Li Guang ) + * + * SPDX-License-Identifier: GPL-2.0-or-later + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + */ + +#ifndef GUEST_LOADER_H +#define GUEST_LOADER_H + +#include "hw/qdev-core.h" +#include "qom/object.h" + +struct GuestLoaderState { + /* */ + DeviceState parent_obj; + + /* */ + uint64_t addr; + char *kernel; + char *args; + char *initrd; +}; + +#define TYPE_GUEST_LOADER "guest-loader" +OBJECT_DECLARE_SIMPLE_TYPE(GuestLoaderState, GUEST_LOADER) + +#endif diff --git a/hw/core/guest-loader.c b/hw/core/guest-loader.c new file mode 100644 index 0000000000..bde44e27b4 --- /dev/null +++ b/hw/core/guest-loader.c @@ -0,0 +1,145 @@ +/* + * Guest Loader + * + * Copyright (C) 2020 Linaro + * Written by Alex Bennée + * (based on the generic-loader by Li Guang ) + * + * SPDX-License-Identifier: GPL-2.0-or-later + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + */ + +/* + * Much like the generic-loader this is treated as a special device + * inside QEMU. However unlike the generic-loader this device is used + * to load guest images for hypervisors. As part of that process the + * hypervisor needs to have platform information passed to it by the + * lower levels of the stack (e.g. firmware/bootloader). If you boot + * the hypervisor directly you use the guest-loader to load the Dom0 + * or equivalent guest images in the right place in the same way a + * boot loader would. + * + * This is only relevant for full system emulation. + */ + +#include "qemu/osdep.h" +#include "hw/core/cpu.h" +#include "hw/sysbus.h" +#include "sysemu/dma.h" +#include "hw/loader.h" +#include "hw/qdev-properties.h" +#include "qapi/error.h" +#include "qemu/module.h" +#include "guest-loader.h" +#include "sysemu/device_tree.h" +#include "hw/boards.h" + +/* + * Insert some FDT nodes for the loaded blob. + */ +static void loader_insert_platform_data(GuestLoaderState *s, int size, + Error **errp) +{ + MachineState *machine = MACHINE(qdev_get_machine()); + void *fdt = machine->fdt; + g_autofree char *node = g_strdup_printf("/chosen/module@0x%08" PRIx64, + s->addr); + uint64_t reg_attr[2] = {cpu_to_be64(s->addr), cpu_to_be64(size)}; + + if (!fdt) { + error_setg(errp, "Cannot modify FDT fields if the machine has none"); + return; + } + + qemu_fdt_add_subnode(fdt, node); + qemu_fdt_setprop(fdt, node, "reg", ®_attr, sizeof(reg_attr)); + + if (s->kernel) { + const char *compat[2] = { "multiboot,module", "multiboot,kernel" }; + if (qemu_fdt_setprop_string_array(fdt, node, "compatible", + (char **) &compat, + ARRAY_SIZE(compat)) < 0) { + error_setg(errp, "couldn't set %s/compatible", node); + return; + } + if (s->args) { + if (qemu_fdt_setprop_string(fdt, node, "bootargs", s->args) < 0) { + error_setg(errp, "couldn't set %s/bootargs", node); + } + } + } else if (s->initrd) { + const char *compat[2] = { "multiboot,module", "multiboot,ramdisk" }; + if (qemu_fdt_setprop_string_array(fdt, node, "compatible", + (char **) &compat, + ARRAY_SIZE(compat)) < 0) { + error_setg(errp, "couldn't set %s/compatible", node); + return; + } + } +} + +static void guest_loader_realize(DeviceState *dev, Error **errp) +{ + GuestLoaderState *s = GUEST_LOADER(dev); + char *file = s->kernel ? s->kernel : s->initrd; + int size = 0; + + /* Perform some error checking on the user's options */ + if (s->kernel && s->initrd) { + error_setg(errp, "Cannot specify a kernel and initrd in same stanza"); + return; + } else if (!s->kernel && !s->initrd) { + error_setg(errp, "Need to specify a kernel or initrd image"); + return; + } else if (!s->addr) { + error_setg(errp, "Need to specify the address of guest blob"); + return; + } else if (s->args && !s->kernel) { + error_setg(errp, "Boot args only relevant to kernel blobs"); + } + + /* Default to the maximum size being the machine's ram size */ + size = load_image_targphys_as(file, s->addr, current_machine->ram_size, + NULL); + if (size < 0) { + error_setg(errp, "Cannot load specified image %s", file); + return; + } + + /* Now the image is loaded we need to update the platform data */ + loader_insert_platform_data(s, size, errp); +} + +static Property guest_loader_props[] = { + DEFINE_PROP_UINT64("addr", GuestLoaderState, addr, 0), + DEFINE_PROP_STRING("kernel", GuestLoaderState, kernel), + DEFINE_PROP_STRING("bootargs", GuestLoaderState, args), + DEFINE_PROP_STRING("initrd", GuestLoaderState, initrd), + DEFINE_PROP_END_OF_LIST(), +}; + +static void guest_loader_class_init(ObjectClass *klass, void *data) +{ + DeviceClass *dc = DEVICE_CLASS(klass); + + dc->realize = guest_loader_realize; + device_class_set_props(dc, guest_loader_props); + dc->desc = "Guest Loader"; + set_bit(DEVICE_CATEGORY_MISC, dc->categories); +} + +static TypeInfo guest_loader_info = { + .name = TYPE_GUEST_LOADER, + .parent = TYPE_DEVICE, + .instance_size = sizeof(GuestLoaderState), + .class_init = guest_loader_class_init, +}; + +static void guest_loader_register_type(void) +{ + type_register_static(&guest_loader_info); +} + +type_init(guest_loader_register_type) diff --git a/MAINTAINERS b/MAINTAINERS index 9b2aa18e1f..a5b87d5e30 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2007,6 +2007,11 @@ F: hw/core/generic-loader.c F: include/hw/core/generic-loader.h F: docs/generic-loader.txt +Guest Loader +M: Alex Bennée +S: Maintained +F: hw/core/guest-loader.c + Intel Hexadecimal Object File Loader M: Su Hang S: Maintained diff --git a/hw/core/meson.build b/hw/core/meson.build index 032576f571..9cd72edf51 100644 --- a/hw/core/meson.build +++ b/hw/core/meson.build @@ -37,6 +37,8 @@ softmmu_ss.add(files( 'clock-vmstate.c', )) +softmmu_ss.add(when: 'CONFIG_TCG', if_true: files('guest-loader.c')) + specific_ss.add(when: 'CONFIG_SOFTMMU', if_true: files( 'machine-qmp-cmds.c', 'numa.c', -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 17:37:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 17:37:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92931.175307 (Exim 4.92) (envelope-from ) id 1lHVQp-0008Px-3Z; Wed, 03 Mar 2021 17:37:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92931.175307; Wed, 03 Mar 2021 17:37:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVQo-0008Pn-W2; Wed, 03 Mar 2021 17:37:06 +0000 Received: by outflank-mailman (input) for mailman id 92931; Wed, 03 Mar 2021 17:37:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVQn-0008CL-SR for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 17:37:05 +0000 Received: from mail-wr1-x42b.google.com (unknown [2a00:1450:4864:20::42b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 32c99325-d7fc-43db-9d09-2b7195803c1d; Wed, 03 Mar 2021 17:36:50 +0000 (UTC) Received: by mail-wr1-x42b.google.com with SMTP id h98so24580675wrh.11 for ; Wed, 03 Mar 2021 09:36:50 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id y9sm30040997wrm.88.2021.03.03.09.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 09:36:47 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 94A5E1FF8F; Wed, 3 Mar 2021 17:36:42 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32c99325-d7fc-43db-9d09-2b7195803c1d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JnSGMCd2oTmwo2vSuC8sn+Sw5LdMPM7rvDdngVJ3Vpc=; b=l7YLMSTXH1L2EhLS/wpOol4cxnwNY+b6qg4d1oL0nwUoHJF4/9gIKUziXUJbxPF8Er y2A/FQlt0bP6rYhQ9hYqXOVLbq2VOsaPLCxYD+t9xtBDIPxl9KRMvlIo7vPbfc6FZmqe 7ANjZ077NrONFmzK8E9YnvzcJyDzYkKL6sa/N1DFqPbAasoHTv2yRF99bW2lpZO4ZxZH UAI5w5VCswgqU0ErH6m1CShRyqniM+UpyQoqXZa0jZgNrfNbaUgefKEJjSJc6wOmcyUi mSbAdYO8Eqi6hW/XvUfSBiIh43fDyKUn82DmdZLv5SBRwiyXsRTkNiUh5y6IRNXKUS4q wGAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JnSGMCd2oTmwo2vSuC8sn+Sw5LdMPM7rvDdngVJ3Vpc=; b=toFa1IDtdOgD3PMFce08LaAZ3aGa5wRH9cxtIP6G9XlNbi6qZsrYRXoFXxNAFKRmw8 sszEG17pbcashTS1d7aTO9Njg48vcmdYrDYotqqKXwi5vdLENEZm/ewK+GHZVerRnj2i DF0gWfxAmPuJzeipIRY3mG2OEJhYYoLPnzKghxmeY0L2wRen3IwcPZ35BNYiNnmKp7oi trv+gOLFyLjVTsi0DyqoFTrAzjSMz8WNBx0WBhO6bLFDqtnag3Qqp4lOzGcSZTUiwBGA 3qvp16zQDzFq+SjcPhslC824LUvY+/gMtVSsKtY4jqe8FkJdzRGK5Hw0piCPF2WSePAE qebg== X-Gm-Message-State: AOAM5315ENbeY4QFJu49O0L+zyzYO7L8LBfMfu/zFGjxwTL8jK62+CZA fwzr76GR82kSEzFHXy1ciltDAw== X-Google-Smtp-Source: ABdhPJzjfn8ZGclDW0qOWpMkkVTkGxv3y4tdAyXeYN21guSZuG9roaTtcaNBrL1aLUfecjPPxGX9uw== X-Received: by 2002:adf:e5c8:: with SMTP id a8mr28825898wrn.352.1614793010061; Wed, 03 Mar 2021 09:36:50 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: julien@xen.org, stefano.stabellini@linaro.org, stefano.stabellini@xilinx.com, andre.przywara@arm.com, stratos-dev@op-lists.linaro.org, xen-devel@lists.xenproject.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Alistair Francis , David Gibson Subject: [PATCH v3 3/7] device_tree: add qemu_fdt_setprop_string_array helper Date: Wed, 3 Mar 2021 17:36:38 +0000 Message-Id: <20210303173642.3805-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210303173642.3805-1-alex.bennee@linaro.org> References: <20210303173642.3805-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A string array in device tree is simply a series of \0 terminated strings next to each other. As libfdt doesn't support that directly we need to build it ourselves. Signed-off-by: Alex Bennée Reviewed-by: Alistair Francis Message-Id: <20201105175153.30489-4-alex.bennee@linaro.org> Message-Id: <20210211171945.18313-4-alex.bennee@linaro.org> --- include/sysemu/device_tree.h | 17 +++++++++++++++++ softmmu/device_tree.c | 26 ++++++++++++++++++++++++++ 2 files changed, 43 insertions(+) diff --git a/include/sysemu/device_tree.h b/include/sysemu/device_tree.h index 982c89345f..8a2fe55622 100644 --- a/include/sysemu/device_tree.h +++ b/include/sysemu/device_tree.h @@ -70,6 +70,23 @@ int qemu_fdt_setprop_u64(void *fdt, const char *node_path, const char *property, uint64_t val); int qemu_fdt_setprop_string(void *fdt, const char *node_path, const char *property, const char *string); + +/** + * qemu_fdt_setprop_string_array: set a string array property + * + * @fdt: pointer to the dt blob + * @name: node name + * @prop: property array + * @array: pointer to an array of string pointers + * @len: length of array + * + * assigns a string array to a property. This function converts and + * array of strings to a sequential string with \0 separators before + * setting the property. + */ +int qemu_fdt_setprop_string_array(void *fdt, const char *node_path, + const char *prop, char **array, int len); + int qemu_fdt_setprop_phandle(void *fdt, const char *node_path, const char *property, const char *target_node_path); diff --git a/softmmu/device_tree.c b/softmmu/device_tree.c index b9a3ddc518..2691c58cf6 100644 --- a/softmmu/device_tree.c +++ b/softmmu/device_tree.c @@ -21,6 +21,7 @@ #include "qemu/error-report.h" #include "qemu/option.h" #include "qemu/bswap.h" +#include "qemu/cutils.h" #include "sysemu/device_tree.h" #include "sysemu/sysemu.h" #include "hw/loader.h" @@ -397,6 +398,31 @@ int qemu_fdt_setprop_string(void *fdt, const char *node_path, return r; } +/* + * libfdt doesn't allow us to add string arrays directly but they are + * test a series of null terminated strings with a length. We build + * the string up here so we can calculate the final length. + */ +int qemu_fdt_setprop_string_array(void *fdt, const char *node_path, + const char *prop, char **array, int len) +{ + int ret, i, total_len = 0; + char *str, *p; + for (i = 0; i < len; i++) { + total_len += strlen(array[i]) + 1; + } + p = str = g_malloc0(total_len); + for (i = 0; i < len; i++) { + int len = strlen(array[i]) + 1; + pstrcpy(p, len, array[i]); + p += len; + } + + ret = qemu_fdt_setprop(fdt, node_path, prop, str, total_len); + g_free(str); + return ret; +} + const void *qemu_fdt_getprop(void *fdt, const char *node_path, const char *property, int *lenp, Error **errp) { -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 17:37:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 17:37:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92933.175320 (Exim 4.92) (envelope-from ) id 1lHVQu-0008Vv-Dx; Wed, 03 Mar 2021 17:37:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92933.175320; Wed, 03 Mar 2021 17:37:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVQu-0008Vl-A7; Wed, 03 Mar 2021 17:37:12 +0000 Received: by outflank-mailman (input) for mailman id 92933; Wed, 03 Mar 2021 17:37:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVQs-0008CL-Sj for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 17:37:10 +0000 Received: from mail-wm1-x329.google.com (unknown [2a00:1450:4864:20::329]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8d2d5621-1927-4c27-9e20-64f765630ef9; Wed, 03 Mar 2021 17:36:51 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id i9so5864308wml.0 for ; Wed, 03 Mar 2021 09:36:51 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id x13sm32378438wrt.75.2021.03.03.09.36.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 09:36:47 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id CD7991FF91; Wed, 3 Mar 2021 17:36:42 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d2d5621-1927-4c27-9e20-64f765630ef9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C4OH1UjeiJ8djx+g35HMcQPeesTsGZkmXqfeV0TYj8w=; b=hqMX4fq3KsnQxGP8BBbiWE1wlucQW1oImfKMxmvKEQ4odjpL3OdCWEyNW3CotSt1F+ OCB7717CSyr+j5hITkVxfeu4gxQmRZ/BsjL3k6NRecPFX3uN7YTqCVHBEkGA3XyXzDoa SpRMDdIGFCArKaSZRq9XMzuNzX73KWPz43f8SUX/r6osS4tADxqeazpkRL5w/Alevla3 W3UtUAVaGGSxUMvWbj3nsYVMEuM9l/Wexlh900j9Gpu/5szDLUXPW7VyGovCzrr+mfbA cQ4hBIaSrqcZz8EcUOh294ouF4s+bDgWEIojyaqJJYxuSLvgipF0gqm3iPyfmZ50wSS+ T8YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C4OH1UjeiJ8djx+g35HMcQPeesTsGZkmXqfeV0TYj8w=; b=euQeAuezcXaqIdndWn8zCjIHibXW2etANV0s5L7Ug5tBvqOFlteSLSu+NgqFeIdOkO dTwUnG9gDVseI8SVicDAnm7fju5M/PQ3EJlhd+HOVfk2L6RJEJ8kZ9XqIiYYUnB0h9J/ MHMnFVv7SUCYrmKF4+NrxWO8CZbfTdm0q/hK8G6uVhBUHyI60gKraD+w+9e8sEtmT6Ar IZ3BWlouXRIP1sRBX7WZJ18Jt+cDn/5G7ngY88zbnC79KdE0GSiDYIFSPIYzoPlu+6NV QDn0zxE5Q1LNOjz+J87B2Yigo+lySaAI3tjS7jfyd1oMlbtE19oz342GDH1wmL1P7Wab 9Fkw== X-Gm-Message-State: AOAM530Rnrxo3KDtwRMvWNWFfqdpZtLnxOrL7tvZ0pSWEPz1SZaGFqjX Wx8+uD2iai/6tlh/AmlZBKGemA== X-Google-Smtp-Source: ABdhPJwk3n+g1rRKcRyIHHEWTYD1lV/s+k61cAclZDa1OpP7L7vMHec8bTu03E8Vj36KyQVMN0oxgQ== X-Received: by 2002:a7b:c303:: with SMTP id k3mr91022wmj.67.1614793010784; Wed, 03 Mar 2021 09:36:50 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: julien@xen.org, stefano.stabellini@linaro.org, stefano.stabellini@xilinx.com, andre.przywara@arm.com, stratos-dev@op-lists.linaro.org, xen-devel@lists.xenproject.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Alistair Francis , Alistair Francis Subject: [PATCH v3 5/7] docs: move generic-loader documentation into the main manual Date: Wed, 3 Mar 2021 17:36:40 +0000 Message-Id: <20210303173642.3805-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210303173642.3805-1-alex.bennee@linaro.org> References: <20210303173642.3805-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We might as well surface this useful information in the manual so users can find it easily. It is a fairly simple conversion to rst with the only textual fixes being QemuOps to QemuOpts. Signed-off-by: Alex Bennée Reviewed-by: Alistair Francis Message-Id: <20201105175153.30489-6-alex.bennee@linaro.org> Message-Id: <20210211171945.18313-6-alex.bennee@linaro.org> --- docs/generic-loader.txt | 92 -------------------------- docs/system/generic-loader.rst | 117 +++++++++++++++++++++++++++++++++ docs/system/index.rst | 1 + MAINTAINERS | 2 +- 4 files changed, 119 insertions(+), 93 deletions(-) delete mode 100644 docs/generic-loader.txt create mode 100644 docs/system/generic-loader.rst diff --git a/docs/generic-loader.txt b/docs/generic-loader.txt deleted file mode 100644 index a9603a2af7..0000000000 --- a/docs/generic-loader.txt +++ /dev/null @@ -1,92 +0,0 @@ -Copyright (c) 2016 Xilinx Inc. - -This work is licensed under the terms of the GNU GPL, version 2 or later. See -the COPYING file in the top-level directory. - - -The 'loader' device allows the user to load multiple images or values into -QEMU at startup. - -Loading Data into Memory Values -------------------------------- -The loader device allows memory values to be set from the command line. This -can be done by following the syntax below: - - -device loader,addr=,data=,data-len= - [,data-be=][,cpu-num=] - - - The address to store the data in. - - The value to be written to the address. The maximum size of - the data is 8 bytes. - - The length of the data in bytes. This argument must be - included if the data argument is. - - Set to true if the data to be stored on the guest should be - written as big endian data. The default is to write little - endian data. - - The number of the CPU's address space where the data should - be loaded. If not specified the address space of the first - CPU is used. - -All values are parsed using the standard QemuOps parsing. This allows the user -to specify any values in any format supported. By default the values -will be parsed as decimal. To use hex values the user should prefix the number -with a '0x'. - -An example of loading value 0x8000000e to address 0xfd1a0104 is: - -device loader,addr=0xfd1a0104,data=0x8000000e,data-len=4 - -Setting a CPU's Program Counter -------------------------------- -The loader device allows the CPU's PC to be set from the command line. This -can be done by following the syntax below: - - -device loader,addr=,cpu-num= - - - The value to use as the CPU's PC. - - The number of the CPU whose PC should be set to the - specified value. - -All values are parsed using the standard QemuOps parsing. This allows the user -to specify any values in any format supported. By default the values -will be parsed as decimal. To use hex values the user should prefix the number -with a '0x'. - -An example of setting CPU 0's PC to 0x8000 is: - -device loader,addr=0x8000,cpu-num=0 - -Loading Files -------------- -The loader device also allows files to be loaded into memory. It can load ELF, -U-Boot, and Intel HEX executable formats as well as raw images. The syntax is -shown below: - - -device loader,file=[,addr=][,cpu-num=][,force-raw=] - - - A file to be loaded into memory - - The memory address where the file should be loaded. This is - required for raw images and ignored for non-raw files. - - This specifies the CPU that should be used. This is an - optional argument and will cause the CPU's PC to be set to - the memory address where the raw file is loaded or the entry - point specified in the executable format header. This option - should only be used for the boot image. - This will also cause the image to be written to the specified - CPU's address space. If not specified, the default is CPU 0. - - Setting force-raw=on forces the file to be treated as a raw - image. This can be used to load supported executable formats - as if they were raw. - -All values are parsed using the standard QemuOps parsing. This allows the user -to specify any values in any format supported. By default the values -will be parsed as decimal. To use hex values the user should prefix the number -with a '0x'. - -An example of loading an ELF file which CPU0 will boot is shown below: - -device loader,file=./images/boot.elf,cpu-num=0 - -Restrictions and ToDos ----------------------- - - At the moment it is just assumed that if you specify a cpu-num then you - want to set the PC as well. This might not always be the case. In future - the internal state 'set_pc' (which exists in the generic loader now) should - be exposed to the user so that they can choose if the PC is set or not. diff --git a/docs/system/generic-loader.rst b/docs/system/generic-loader.rst new file mode 100644 index 0000000000..6bf8a4eb48 --- /dev/null +++ b/docs/system/generic-loader.rst @@ -0,0 +1,117 @@ +.. + Copyright (c) 2016, Xilinx Inc. + +This work is licensed under the terms of the GNU GPL, version 2 or later. See +the COPYING file in the top-level directory. + +Generic Loader +-------------- + +The 'loader' device allows the user to load multiple images or values into +QEMU at startup. + +Loading Data into Memory Values +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +The loader device allows memory values to be set from the command line. This +can be done by following the syntax below:: + + -device loader,addr=,data=,data-len= \ + [,data-be=][,cpu-num=] + +```` + The address to store the data in. + +```` + The value to be written to the address. The maximum size of the data + is 8 bytes. + +```` + The length of the data in bytes. This argument must be included if + the data argument is. + +```` + Set to true if the data to be stored on the guest should be written + as big endian data. The default is to write little endian data. + +```` + The number of the CPU's address space where the data should be + loaded. If not specified the address space of the first CPU is used. + +All values are parsed using the standard QemuOps parsing. This allows the user +to specify any values in any format supported. By default the values +will be parsed as decimal. To use hex values the user should prefix the number +with a '0x'. + +An example of loading value 0x8000000e to address 0xfd1a0104 is:: + + -device loader,addr=0xfd1a0104,data=0x8000000e,data-len=4 + +Setting a CPU's Program Counter +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +The loader device allows the CPU's PC to be set from the command line. This +can be done by following the syntax below:: + + -device loader,addr=,cpu-num= + +```` + The value to use as the CPU's PC. + +```` + The number of the CPU whose PC should be set to the specified value. + +All values are parsed using the standard QemuOpts parsing. This allows the user +to specify any values in any format supported. By default the values +will be parsed as decimal. To use hex values the user should prefix the number +with a '0x'. + +An example of setting CPU 0's PC to 0x8000 is:: + + -device loader,addr=0x8000,cpu-num=0 + +Loading Files +^^^^^^^^^^^^^ + +The loader device also allows files to be loaded into memory. It can load ELF, +U-Boot, and Intel HEX executable formats as well as raw images. The syntax is +shown below: + + -device loader,file=[,addr=][,cpu-num=][,force-raw=] + +```` + A file to be loaded into memory + +```` + The memory address where the file should be loaded. This is required + for raw images and ignored for non-raw files. + +```` + This specifies the CPU that should be used. This is an + optional argument and will cause the CPU's PC to be set to the + memory address where the raw file is loaded or the entry point + specified in the executable format header. This option should only + be used for the boot image. This will also cause the image to be + written to the specified CPU's address space. If not specified, the + default is CPU 0. - Setting force-raw=on forces the file + to be treated as a raw image. This can be used to load supported + executable formats as if they were raw. + +All values are parsed using the standard QemuOpts parsing. This allows the user +to specify any values in any format supported. By default the values +will be parsed as decimal. To use hex values the user should prefix the number +with a '0x'. + +An example of loading an ELF file which CPU0 will boot is shown below:: + + -device loader,file=./images/boot.elf,cpu-num=0 + +Restrictions and ToDos +^^^^^^^^^^^^^^^^^^^^^^ + +At the moment it is just assumed that if you specify a cpu-num then +you want to set the PC as well. This might not always be the case. In +future the internal state 'set_pc' (which exists in the generic loader +now) should be exposed to the user so that they can choose if the PC +is set or not. + + diff --git a/docs/system/index.rst b/docs/system/index.rst index 625b494372..cee1c83540 100644 --- a/docs/system/index.rst +++ b/docs/system/index.rst @@ -25,6 +25,7 @@ Contents: usb ivshmem linuxboot + generic-loader vnc-security tls gdb diff --git a/MAINTAINERS b/MAINTAINERS index a5b87d5e30..34cdd20672 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2005,7 +2005,7 @@ M: Alistair Francis S: Maintained F: hw/core/generic-loader.c F: include/hw/core/generic-loader.h -F: docs/generic-loader.txt +F: docs/system/generic-loader.rst Guest Loader M: Alex Bennée -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 17:37:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 17:37:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92934.175332 (Exim 4.92) (envelope-from ) id 1lHVQz-0000AW-1O; Wed, 03 Mar 2021 17:37:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92934.175332; Wed, 03 Mar 2021 17:37:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVQy-0000AJ-Sr; Wed, 03 Mar 2021 17:37:16 +0000 Received: by outflank-mailman (input) for mailman id 92934; Wed, 03 Mar 2021 17:37:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVQx-0008CL-Sv for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 17:37:15 +0000 Received: from mail-wr1-x42b.google.com (unknown [2a00:1450:4864:20::42b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 06c96479-fabf-424f-9418-338e290f6d7d; Wed, 03 Mar 2021 17:36:53 +0000 (UTC) Received: by mail-wr1-x42b.google.com with SMTP id d15so9372821wrv.5 for ; Wed, 03 Mar 2021 09:36:53 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id v13sm7752139wrt.45.2021.03.03.09.36.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 09:36:48 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id E80CC1FF92; Wed, 3 Mar 2021 17:36:42 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06c96479-fabf-424f-9418-338e290f6d7d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PmQ9WuVuI0VGnZuuNn7EAfs0gdyLaSensm8NVod8pVg=; b=HWZI308TJukFvtbSn2loLICxIM06pNa74CZg42QaWzfoaKYQ+genJTnkvoaM9IXVld 2b5hR4qm8XIP6VW1wuB58ITdyIHJcPuUHPgK3wlq8wIp2EQ7D6pw1V+0IqAQpBYPei1H XHZlOovl9TlWKnnfs2/wmowMAPi/7bUooNTs0ZOeaj7ae6gtczIbKANrUMoIhlQTGM9G m7uy34F/TPNZ799fsSXEIkNJCTpcGFfzfPAMNK5QlQcpb6zzq10ipWQbf7AoV8ympQIi bFAciZJCUY8q0/wiDDBOf9JD1ofxx+H2TA5cxGqlbidXkHQtuNAP3UJeQRTuRhqxVC4I zEnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PmQ9WuVuI0VGnZuuNn7EAfs0gdyLaSensm8NVod8pVg=; b=WPkXNDIvW6lHRm1DLg6PsV8lNO6owfMopxqns3VHGRCO4OCV8mXwvTEqChaF15RaGi b7EIpGKZl/YBcjoGFbHxPs/mrGgbN4xC7PwtoYN7Ub4pcH7pi36j6FOxAXB5lxOJ6TX5 Oy4Htj4jV1tNLQwWDm3Q2sxDgaJefu7+cRHXE6xM6I1kT6AljP/IEim28jnhjFD+M+Ls Py8c4UHabXNSTLnuI1OMogiARQfgX+Q0USY8z5WlkfsBScahr/tDoJPqbocBdZPLRbmt RI9wfCz34RyEqINwaCTCjPy1yZPJ2Eub0tq3/nCO3KDGdEf3cSewSmid77/nG9B5v1P6 3d0g== X-Gm-Message-State: AOAM530PO+hYJcYo9C+S0fugSdYE9JWq2nIyg/X/fP0qR10eb5nMdpWH ZDZ8Q2Fl+rRk9e6rCqqXSHUz1Q== X-Google-Smtp-Source: ABdhPJy26X6i0Wu/nkBtfpoLZsbBTaHgfgWyBsKvtkLCsqrS9ybg7BnEbcUgmQFGAk8CrTvbGndY9Q== X-Received: by 2002:adf:ea0e:: with SMTP id q14mr9538076wrm.389.1614793012908; Wed, 03 Mar 2021 09:36:52 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: julien@xen.org, stefano.stabellini@linaro.org, stefano.stabellini@xilinx.com, andre.przywara@arm.com, stratos-dev@op-lists.linaro.org, xen-devel@lists.xenproject.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Alistair Francis Subject: [PATCH v3 6/7] docs: add some documentation for the guest-loader Date: Wed, 3 Mar 2021 17:36:41 +0000 Message-Id: <20210303173642.3805-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210303173642.3805-1-alex.bennee@linaro.org> References: <20210303173642.3805-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Alex Bennée Reviewed-by: Alistair Francis Message-Id: <20201105175153.30489-7-alex.bennee@linaro.org> Message-Id: <20210211171945.18313-7-alex.bennee@linaro.org> --- docs/system/guest-loader.rst | 54 ++++++++++++++++++++++++++++++++++++ docs/system/index.rst | 1 + MAINTAINERS | 1 + 3 files changed, 56 insertions(+) create mode 100644 docs/system/guest-loader.rst diff --git a/docs/system/guest-loader.rst b/docs/system/guest-loader.rst new file mode 100644 index 0000000000..37d03cbd89 --- /dev/null +++ b/docs/system/guest-loader.rst @@ -0,0 +1,54 @@ +.. + Copyright (c) 2020, Linaro + +Guest Loader +------------ + +The guest loader is similar to the `generic-loader` although it is +aimed at a particular use case of loading hypervisor guests. This is +useful for debugging hypervisors without having to jump through the +hoops of firmware and boot-loaders. + +The guest loader does two things: + + - load blobs (kernels and initial ram disks) into memory + - sets platform FDT data so hypervisors can find and boot them + +This is what is typically done by a boot-loader like grub using it's +multi-boot capability. A typical example would look like: + +.. parsed-literal:: + + |qemu_system| -kernel ~/xen.git/xen/xen \ + -append "dom0_mem=1G,max:1G loglvl=all guest_loglvl=all" \ + -device guest-loader,addr=0x42000000,kernel=Image,bootargs="root=/dev/sda2 ro console=hvc0 earlyprintk=xen" \ + -device guest-loader,addr=0x47000000,initrd=rootfs.cpio + +In the above example the Xen hypervisor is loaded by the -kernel +parameter and passed it's boot arguments via -append. The Dom0 guest +is loaded into the areas of memory. Each blob will get +`/chosen/module@` entry in the FDT to indicate it's location and +size. Additional information can be passed with by using additional +arguments. + +Currently the only supported machines which use FDT data to boot are +the ARM and RiscV `virt` machines. + +Arguments +^^^^^^^^^ + +The full syntax of the guest-loader is:: + + -device guest-loader,addr=[,kernel=,[bootargs=]][,initrd=] + +``addr=`` + This is mandatory and indicates the start address of the blob. + +``kernel|initrd=`` + Indicates the filename of the kernel or initrd blob. Both blobs will + have the "multiboot,module" compatibility string as well as + "multiboot,kernel" or "multiboot,ramdisk" as appropriate. + +``bootargs=`` + This is an optional field for kernel blobs which will pass command + like via the `/chosen/module@/bootargs` node. diff --git a/docs/system/index.rst b/docs/system/index.rst index cee1c83540..6ad9c93806 100644 --- a/docs/system/index.rst +++ b/docs/system/index.rst @@ -26,6 +26,7 @@ Contents: ivshmem linuxboot generic-loader + guest-loader vnc-security tls gdb diff --git a/MAINTAINERS b/MAINTAINERS index 34cdd20672..8ec6fbc259 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2011,6 +2011,7 @@ Guest Loader M: Alex Bennée S: Maintained F: hw/core/guest-loader.c +F: docs/system/guest-loader.rst Intel Hexadecimal Object File Loader M: Su Hang -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 17:37:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 17:37:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92937.175344 (Exim 4.92) (envelope-from ) id 1lHVR4-0000GN-Bm; Wed, 03 Mar 2021 17:37:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92937.175344; Wed, 03 Mar 2021 17:37:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVR4-0000GG-8Y; Wed, 03 Mar 2021 17:37:22 +0000 Received: by outflank-mailman (input) for mailman id 92937; Wed, 03 Mar 2021 17:37:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVR2-0008CL-T9 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 17:37:20 +0000 Received: from mail-wr1-x42a.google.com (unknown [2a00:1450:4864:20::42a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 04d00bc9-00f0-4b59-8322-33959d34ecb6; Wed, 03 Mar 2021 17:36:54 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id v15so24615771wrx.4 for ; Wed, 03 Mar 2021 09:36:54 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id p11sm20276392wrs.80.2021.03.03.09.36.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 09:36:48 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 0B4521FF93; Wed, 3 Mar 2021 17:36:43 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04d00bc9-00f0-4b59-8322-33959d34ecb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=U9iSjEArbqzySzfWYr1jVba9A0vkpxyXtE5lXtqiuxQ=; b=QkZ4+I0UDpSvUuM6j9zR42K7w3A2L2AHm/f+ZZK4RUE+Ffn9zz8hQSwxTyJ2TUReU4 zgDzV/97/j31++cM2xV89yt0VJFylUFp95U4LJde/bH4MDXIWf415v1HTY+WGzB7M+Ex MwwKjCtlsn0IBSZAHY4HQ7e4EajLNYoJc2zI02oo7Jv9Lc6yugWdKaoCQ4fLmpkSAaHv Nk03YdddkeGd22qhZLBFaqXHKWo3lfekB1UmuQOXS0x3lhJbJTtlpysoOHJlNolkSOgY YSWnMtxoZKT1MKMSyuUko6s5//OOCUWE3KCdulaejN/o5jduqUlkiINuB3D4rvE4hL6Q dKmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U9iSjEArbqzySzfWYr1jVba9A0vkpxyXtE5lXtqiuxQ=; b=L3GxcnqKmqeDdsuiHTYeG2iNv9Xx5RLK6jzzVt5h+R8cKi9bbBps0WvN2+kF4ZP08Z HLQuRMz+Dbos9ocPPJDWISvGgZhji8FDhMVtCcfGdZpKvjqLCAHYW5LNXLiO+qNA+MAp iLuUGCe+EfGGS/TsjXFb/uc/NB6CfJHMdsOYHba7VYaEpMTy5DilCFMOP5KhDyBakX4C 6oLZG4ZeEMP1BJbli9u8nVOBN2e2oPeXNtsowxOPeqN/QLbq6fHdKFbMrhGtTgDKjiyY nVke6GXqHow9HyKWLTntY8V7G9CyI8LYZ+OIn5RgFuyXf6xO8hPo4sBHttDDfn+zzorz TXnw== X-Gm-Message-State: AOAM532Kq9UlfqH7P+EH5NPPEWtCUdCAAeZGLpWgd3BzdQSFlTBZ5xmn s792yUPCQWyEZyfJlJuCaQJlmQ== X-Google-Smtp-Source: ABdhPJwHJEGYQRagTqSQuFGI9o7UXybhtS7HZ//7eyDJsekl4usOiTqh9Tevim0CkBarrdiUvbvMWA== X-Received: by 2002:a5d:4903:: with SMTP id x3mr24575862wrq.143.1614793013902; Wed, 03 Mar 2021 09:36:53 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: julien@xen.org, stefano.stabellini@linaro.org, stefano.stabellini@xilinx.com, andre.przywara@arm.com, stratos-dev@op-lists.linaro.org, xen-devel@lists.xenproject.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta Subject: [PATCH v3 7/7] tests/avocado: add boot_xen tests Date: Wed, 3 Mar 2021 17:36:42 +0000 Message-Id: <20210303173642.3805-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210303173642.3805-1-alex.bennee@linaro.org> References: <20210303173642.3805-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These tests make sure we can boot the Xen hypervisor with a Dom0 kernel using the guest-loader. We currently have to use a kernel I built myself because there are issues using the Debian kernel images. Signed-off-by: Alex Bennée Tested-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cleber Rosa Message-Id: <20210211171945.18313-8-alex.bennee@linaro.org> --- v3 - archive stable links on fileserver.linaro.org - remove skip for CI stuff --- MAINTAINERS | 1 + tests/acceptance/boot_xen.py | 118 +++++++++++++++++++++++++++++++++++ 2 files changed, 119 insertions(+) create mode 100644 tests/acceptance/boot_xen.py diff --git a/MAINTAINERS b/MAINTAINERS index 8ec6fbc259..1b4b2cf163 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2012,6 +2012,7 @@ M: Alex Bennée S: Maintained F: hw/core/guest-loader.c F: docs/system/guest-loader.rst +F: tests/acceptance/boot_xen.py Intel Hexadecimal Object File Loader M: Su Hang diff --git a/tests/acceptance/boot_xen.py b/tests/acceptance/boot_xen.py new file mode 100644 index 0000000000..75c2d44492 --- /dev/null +++ b/tests/acceptance/boot_xen.py @@ -0,0 +1,118 @@ +# Functional test that boots a Xen hypervisor with a domU kernel and +# checks the console output is vaguely sane . +# +# Copyright (c) 2020 Linaro +# +# Author: +# Alex Bennée +# +# SPDX-License-Identifier: GPL-2.0-or-later +# +# This work is licensed under the terms of the GNU GPL, version 2 or +# later. See the COPYING file in the top-level directory. + +import os + +from avocado import skipIf +from avocado_qemu import wait_for_console_pattern +from boot_linux_console import LinuxKernelTest + + +class BootXenBase(LinuxKernelTest): + """ + Boots a Xen hypervisor with a Linux DomU kernel. + """ + + timeout = 90 + XEN_COMMON_COMMAND_LINE = 'dom0_mem=128M loglvl=all guest_loglvl=all' + + def fetch_guest_kernel(self): + # Using my own built kernel - which works + kernel_url = ('https://fileserver.linaro.org/' + 's/JSsewXGZ6mqxPr5/download?path=%2F&files=' + 'linux-5.9.9-arm64-ajb') + kernel_sha1 = '4f92bc4b9f88d5ab792fa7a43a68555d344e1b83' + kernel_path = self.fetch_asset(kernel_url, + asset_hash=kernel_sha1) + + return kernel_path + + def launch_xen(self, xen_path): + """ + Launch Xen with a dom0 guest kernel + """ + self.log.info("launch with xen_path: %s", xen_path) + kernel_path = self.fetch_guest_kernel() + + self.vm.set_console() + + xen_command_line = self.XEN_COMMON_COMMAND_LINE + self.vm.add_args('-machine', 'virtualization=on', + '-cpu', 'cortex-a57', + '-m', '768', + '-kernel', xen_path, + '-append', xen_command_line, + '-device', + 'guest-loader,addr=0x47000000,kernel=%s,bootargs=console=hvc0' + % (kernel_path)) + + self.vm.launch() + + console_pattern = 'VFS: Cannot open root device' + wait_for_console_pattern(self, console_pattern, "Panic on CPU 0:") + + +class BootXen(BootXenBase): + + def test_arm64_xen_411_and_dom0(self): + """ + :avocado: tags=arch:aarch64 + :avocado: tags=accel:tcg + :avocado: tags=cpu:cortex-a57 + :avocado: tags=machine:virt + """ + + # archive of file from https://deb.debian.org/debian/pool/main/x/xen/ + xen_url = ('https://fileserver.linaro.org/s/JSsewXGZ6mqxPr5/' + 'download?path=%2F&files=' + 'xen-hypervisor-4.11-arm64_4.11.4%2B37-g3263f257ca-1_arm64.deb') + xen_sha1 = '034e634d4416adbad1212d59b62bccdcda63e62a' + xen_deb = self.fetch_asset(xen_url, asset_hash=xen_sha1) + xen_path = self.extract_from_deb(xen_deb, "/boot/xen-4.11-arm64") + + self.launch_xen(xen_path) + + def test_arm64_xen_414_and_dom0(self): + """ + :avocado: tags=arch:aarch64 + :avocado: tags=accel:tcg + :avocado: tags=cpu:cortex-a57 + :avocado: tags=machine:virt + """ + + # archive of file from https://deb.debian.org/debian/pool/main/x/xen/ + xen_url = ('https://fileserver.linaro.org/s/JSsewXGZ6mqxPr5/' + 'download?path=%2F&files=' + 'xen-hypervisor-4.14-arm64_4.14.0%2B80-gd101b417b7-1_arm64.deb') + xen_sha1 = 'b9d209dd689ed2b393e625303a225badefec1160' + xen_deb = self.fetch_asset(xen_url, asset_hash=xen_sha1) + xen_path = self.extract_from_deb(xen_deb, "/boot/xen-4.14-arm64") + + self.launch_xen(xen_path) + + def test_arm64_xen_415_and_dom0(self): + """ + :avocado: tags=arch:aarch64 + :avocado: tags=accel:tcg + :avocado: tags=cpu:cortex-a57 + :avocado: tags=machine:virt + """ + + xen_url = ('https://fileserver.linaro.org/' + 's/JSsewXGZ6mqxPr5/download' + '?path=%2F&files=xen-upstream-4.15-unstable.deb') + xen_sha1 = 'fc191172b85cf355abb95d275a24cc0f6d6579d8' + xen_deb = self.fetch_asset(xen_url, asset_hash=xen_sha1) + xen_path = self.extract_from_deb(xen_deb, "/boot/xen-4.15-unstable") + + self.launch_xen(xen_path) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 03 17:41:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 17:41:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92955.175355 (Exim 4.92) (envelope-from ) id 1lHVUh-0001Zl-Uf; Wed, 03 Mar 2021 17:41:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92955.175355; Wed, 03 Mar 2021 17:41:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVUh-0001Ze-Rj; Wed, 03 Mar 2021 17:41:07 +0000 Received: by outflank-mailman (input) for mailman id 92955; Wed, 03 Mar 2021 17:41:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVUg-0001ZY-Fu for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 17:41:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVUg-0005Xf-E2 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 17:41:06 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHVUg-0001G2-BA for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 17:41:06 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHVUc-0002k0-Qw; Wed, 03 Mar 2021 17:41:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=77yGCMQlUlkllciv5PI8xDDFSgFjn6qktwQBzbvMo70=; b=006B8qhPQHPD/U2X/gLHWeOwoh uqcLEKUTytxg6sZg7SDFjpsDcTNJWwopwgwhTlTueMFDUB9+hDTofujGIIEGrf+uoLnQDhQpVxYK/ AegtvMo7C0Vr9gG37bCj8v7YZXlHS4Y4Ak9MoKrjaDqR3KZdtfA1a+xVfI32XJyWf+co=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24639.51758.530818.933444@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 17:41:02 +0000 To: Julien Grall Cc: xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall , Wei Liu , Juergen Gross , Bjoern Doebel Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction In-Reply-To: <20210303170526.15903-1-julien@xen.org> References: <20210303170526.15903-1-julien@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("[PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction"): > From: Julien Grall > > As XenStored is single-threaded, conn->ta_start_time will always be > smaller than now. As we substract the latter from the former, it means > a transaction will never be considered long running. > > Invert the two operands of the substraction in both lu_reject_reason() > and lu_check_allowed(). In addition to that, the former also needs to > check that conn->ta_start_time is not 0 (i.e the transaction is not > active). > > Take the opportunity to document the return condition of > lu_check_allowed(). AFAICT this only affects live updated which is not security-supported in 4.15 and which won't block our tests. So: Release-Acked-by: Ian Jackson Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 03 18:09:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 18:09:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92957.175368 (Exim 4.92) (envelope-from ) id 1lHVvT-0003sj-7O; Wed, 03 Mar 2021 18:08:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92957.175368; Wed, 03 Mar 2021 18:08:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVvT-0003sc-4D; Wed, 03 Mar 2021 18:08:47 +0000 Received: by outflank-mailman (input) for mailman id 92957; Wed, 03 Mar 2021 18:08:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVvR-0003sX-OY for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 18:08:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHVvQ-00065t-18; Wed, 03 Mar 2021 18:08:44 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lHVvP-000446-Ll; Wed, 03 Mar 2021 18:08:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=NyJ73P3bQHFqcw0vKIRcuIkPNDOKYqDain6zidlOdIE=; b=TMGzD3KPHS9Yrk6LIYc3/jm554 QXQSemwawvMO0kmZ8o4xZh6TkgVATuufi3J5Ourom6F+3RklcuSYzi3uS4Dr1HU84EpZf8UwcfaZD fHtcphSICml8w5arGqdAkifAnamT51UU8o86d3ebKKw8QkGC3aM67g1bVlriej9My1Kw=; Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction To: Ian Jackson Cc: xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall , Wei Liu , Juergen Gross , Bjoern Doebel References: <20210303170526.15903-1-julien@xen.org> <24639.51758.530818.933444@mariner.uk.xensource.com> From: Julien Grall Message-ID: <2ee798da-bb57-919d-f35e-1be5aa1abcce@xen.org> Date: Wed, 3 Mar 2021 18:08:41 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24639.51758.530818.933444@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Ian, On 03/03/2021 17:41, Ian Jackson wrote: > Julien Grall writes ("[PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction"): >> From: Julien Grall >> >> As XenStored is single-threaded, conn->ta_start_time will always be >> smaller than now. As we substract the latter from the former, it means >> a transaction will never be considered long running. >> >> Invert the two operands of the substraction in both lu_reject_reason() >> and lu_check_allowed(). In addition to that, the former also needs to >> check that conn->ta_start_time is not 0 (i.e the transaction is not >> active). >> >> Take the opportunity to document the return condition of >> lu_check_allowed(). > > AFAICT this only affects live updated which is not security-supported > in 4.15 and which won't block our tests. That's correct. > So: > > Release-Acked-by: Ian Jackson Thanks! Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 03 18:14:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 18:14:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92960.175379 (Exim 4.92) (envelope-from ) id 1lHW0l-0004wD-RY; Wed, 03 Mar 2021 18:14:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92960.175379; Wed, 03 Mar 2021 18:14:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHW0l-0004w6-OZ; Wed, 03 Mar 2021 18:14:15 +0000 Received: by outflank-mailman (input) for mailman id 92960; Wed, 03 Mar 2021 18:14:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHW0k-0004w1-AV for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 18:14:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHW0k-0006BN-7u for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 18:14:14 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHW0k-0004b4-54 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 18:14:14 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHW0g-0002oT-N7; Wed, 03 Mar 2021 18:14:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=GcZD63ujFNhMiwY30q/mq8tYgYMIEZyRuz0cJJbXkIc=; b=RNb0VYqOWOC2Sc7aSiB0ckhLOm pt6/UJ3wohclmY7iYko7LCdg4QpRdiXmnN0pj3iptptVej0cUM4cHS4bbT6M57t67JDWZS+LUWJ8P Q6Wm7XKQpz95fTq3E4XFs/qJVq7HmxZvvXgSwUT3VWxuamGjk8Z4hP/aU0Qquw0VcUfE=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24639.53746.413795.352879@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 18:14:10 +0000 To: Julien Grall Cc: xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall , Wei Liu , Juergen Gross , Bjoern Doebel Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction In-Reply-To: <2ee798da-bb57-919d-f35e-1be5aa1abcce@xen.org> References: <20210303170526.15903-1-julien@xen.org> <24639.51758.530818.933444@mariner.uk.xensource.com> <2ee798da-bb57-919d-f35e-1be5aa1abcce@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction"): > On 03/03/2021 17:41, Ian Jackson wrote: > > AFAICT this only affects live updated which is not security-supported > > in 4.15 and which won't block our tests. > > That's correct. > > > So: > > > > Release-Acked-by: Ian Jackson > > Thanks! PS, notwithstanding the above, submissions of tests for this feature would be very welcome. (If they turn out to block things during the release, I always have the force push hammer.) Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 03 18:33:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 18:33:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92964.175396 (Exim 4.92) (envelope-from ) id 1lHWJ2-00072Q-F0; Wed, 03 Mar 2021 18:33:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92964.175396; Wed, 03 Mar 2021 18:33:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHWJ2-00072J-Bu; Wed, 03 Mar 2021 18:33:08 +0000 Received: by outflank-mailman (input) for mailman id 92964; Wed, 03 Mar 2021 18:33:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHWJ0-00072E-P3 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 18:33:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHWIz-0006UB-Hp; Wed, 03 Mar 2021 18:33:05 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lHWIz-00069j-9s; Wed, 03 Mar 2021 18:33:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=QIPtXw1boiCbdDdKjeLjR0PtcC97uD4XpZO1CKKrN04=; b=msPcxsAyG5aHv8JZX/yxna8/H6 WqSSReoy9fs3H+YlQPSzyeW0u6q1GNHWDu+yLZItRPxc6oZYrry7WhfoPf447BFNNzw1KLq1CEyp7 7Rh5HfV9pZeePra2cYbJ5ZZssUjlgenwnsKFAnCcwqOPNhjaikTE7j67zvh6Ev3QjrdQ=; Subject: Re: [PATCH for-next] xen/arm: mm: flush_page_to_ram() only need to clean to PoC To: Stefano Stabellini Cc: Bertrand Marquis , "xen-devel@lists.xenproject.org" , Julien Grall , Volodymyr Babchuk References: <20210220175413.14640-1-julien@xen.org> <45cd6455-3ad0-f052-65d8-37adb658f003@xen.org> From: Julien Grall Message-ID: <551b09ec-cee1-767c-a7d7-9248e677d80b@xen.org> Date: Wed, 3 Mar 2021 18:33:03 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Stefano, On 23/02/2021 01:22, Stefano Stabellini wrote: >> Thanks! I am thinking to create a branch next again for queuing 4.15+ patches. >> Would that be fine with you? > > yes good idea I have created the branch for-next/4.16 on my public tree and push the patch: https://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=shortlog;h=refs/heads/for-next/4.16 This will be merged once the tree is re-opened. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 03 18:37:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 18:37:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92973.175428 (Exim 4.92) (envelope-from ) id 1lHWN4-0007Ka-7X; Wed, 03 Mar 2021 18:37:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92973.175428; Wed, 03 Mar 2021 18:37:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHWN4-0007KT-4W; Wed, 03 Mar 2021 18:37:18 +0000 Received: by outflank-mailman (input) for mailman id 92973; Wed, 03 Mar 2021 18:37:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHWN2-0007KO-JD for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 18:37:16 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 6d11f08a-3d45-4c1a-b83c-6ad184e78014; Wed, 03 Mar 2021 18:37:15 +0000 (UTC) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-583-GSnoplegN86kfwvadSeyXQ-1; Wed, 03 Mar 2021 13:37:13 -0500 Received: by mail-wr1-f71.google.com with SMTP id z17so4967458wrv.23 for ; Wed, 03 Mar 2021 10:37:13 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id a21sm8546595wmb.5.2021.03.03.10.37.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Mar 2021 10:37:12 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d11f08a-3d45-4c1a-b83c-6ad184e78014 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614796635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RTSPxmhFtQEoaalhYZBAGdSBxMSx5X/iJhZ5W1nMsvk=; b=DlOYXuTAMxHN9LbZsKAgmcH7h17Po3Y8zqocMFiGShPTZNHGp5Yjd+n+8qIoXQDh35kw/W Q6GY5QhCiUEYbqcs49xHOB6r/EXyO3qDqqcN6jwgpsejlZTmgEqUjL/vx8ndv+qbCDo1Hu xccvPqy2Qrx1vgIG+w/7ZTJEW73fOs0= X-MC-Unique: GSnoplegN86kfwvadSeyXQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RTSPxmhFtQEoaalhYZBAGdSBxMSx5X/iJhZ5W1nMsvk=; b=NQv1Rn+3o6LwEDsXa3XNu65Iy1ZIhVYa1iBEHxGBhbZkrPXAPtL/5Yc+47RjesOigU IW5koz16qqNPKVlvbA2EpIO2fhs1pdPcJSygPbBUKhfOcWUGrqr64JlTRSB7c2jhCdIA nbUvXxZRyz4Q6LaPMOUuCJl7NOjRaKaquYzTmmNKUYD/QUovvVnLnTJ+owE7ziYP4Zba Wiy48oKZ8T/E1I7b5yYnoQKF7dRIYwOAAwaaiA38HjTDT4BxwImQIUoq5nxpWp4+7jLP DeKCB1Py8xiCvi2JDt5OopFGnOC0j5EUUBIxRNr13XNnvtz+ajfKXvS+0lbJPQ8N2Vvx KIIQ== X-Gm-Message-State: AOAM533uwiimCa8NEoqC6TIMXoajyce2YSvuNpFn0uVmUA87AUaokgQw L4Z/ycEQ+LbnPreOnoaoRiUUjMmly3qGzghba3DUPKHHZF0Tl3Eq4w71cuwRVml7DRXh9UAWS7d ELVDOcXbEn3UgtyzKV2+OKGhiTQ8= X-Received: by 2002:a1c:804e:: with SMTP id b75mr289085wmd.113.1614796632705; Wed, 03 Mar 2021 10:37:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJzuj8vt04Hsk5gOEGXUt4RmQwBOp07gxAmhTiUTv03/ZKOEd8ZI2pDCU4/BxBnozQiG+4ON0Q== X-Received: by 2002:a1c:804e:: with SMTP id b75mr289072wmd.113.1614796632571; Wed, 03 Mar 2021 10:37:12 -0800 (PST) Subject: Re: [PATCH v3 4/7] hw/core: implement a guest-loader to support static hypervisor guests To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org Cc: julien@xen.org, andre.przywara@arm.com, stefano.stabellini@linaro.org, xen-devel@lists.xenproject.org, stefano.stabellini@xilinx.com, stratos-dev@op-lists.linaro.org References: <20210303173642.3805-1-alex.bennee@linaro.org> <20210303173642.3805-5-alex.bennee@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <224e4bad-6185-a457-ddb5-f04d5c16e2dc@redhat.com> Date: Wed, 3 Mar 2021 19:37:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210303173642.3805-5-alex.bennee@linaro.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 3/3/21 6:36 PM, Alex Bennée wrote: > Hypervisors, especially type-1 ones, need the firmware/bootcode to put > their initial guest somewhere in memory and pass the information to it > via platform data. The guest-loader is modelled after the generic > loader for exactly this sort of purpose: > > $QEMU $ARGS -kernel ~/xen.git/xen/xen \ > -append "dom0_mem=1G,max:1G loglvl=all guest_loglvl=all" \ > -device guest-loader,addr=0x42000000,kernel=Image,bootargs="root=/dev/sda2 ro console=hvc0 earlyprintk=xen" \ > -device guest-loader,addr=0x47000000,initrd=rootfs.cpio > > Signed-off-by: Alex Bennée > Message-Id: <20201105175153.30489-5-alex.bennee@linaro.org> > Message-Id: <20210211171945.18313-5-alex.bennee@linaro.org> > --- > hw/core/guest-loader.h | 34 ++++++++++ > hw/core/guest-loader.c | 145 +++++++++++++++++++++++++++++++++++++++++ > MAINTAINERS | 5 ++ > hw/core/meson.build | 2 + > 4 files changed, 186 insertions(+) > create mode 100644 hw/core/guest-loader.h > create mode 100644 hw/core/guest-loader.c Missing documentation, otherwise: Reviewed-by: Philippe Mathieu-Daudé From xen-devel-bounces@lists.xenproject.org Wed Mar 03 18:38:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 18:38:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92976.175440 (Exim 4.92) (envelope-from ) id 1lHWNw-0007Ql-IQ; Wed, 03 Mar 2021 18:38:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92976.175440; Wed, 03 Mar 2021 18:38:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHWNw-0007Qe-Em; Wed, 03 Mar 2021 18:38:12 +0000 Received: by outflank-mailman (input) for mailman id 92976; Wed, 03 Mar 2021 18:38:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHWNv-0007QY-Fa for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 18:38:11 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id d98d31c6-5b3e-41d0-939b-8ef3ea793d6b; Wed, 03 Mar 2021 18:38:10 +0000 (UTC) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-259-vc7ok9OUPp29oZuXZa1ZMw-1; Wed, 03 Mar 2021 13:38:08 -0500 Received: by mail-wr1-f69.google.com with SMTP id z17so4968514wrv.23 for ; Wed, 03 Mar 2021 10:38:08 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id r10sm8601151wmh.45.2021.03.03.10.38.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Mar 2021 10:38:06 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d98d31c6-5b3e-41d0-939b-8ef3ea793d6b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614796689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Azs7r5hzq+oJhnDSjjywtW9vxKYDAae858wPljQ2F1w=; b=CrfhmtRRjqAIXhdPjcvQGMMJJr/We1eGMbi0Hzh2B4a5Fa3v+0uxF9CTRk5ptAyKZh2i8k nADLdDktZDrPtZsmLXVl2NorWdaNKtBSJR/YBw8yS52YP3BbK+84j/Sc5TdYSW0vnX0ElD Kf02PP9+BZmwVY0LtBllDAAFnMnp2aQ= X-MC-Unique: vc7ok9OUPp29oZuXZa1ZMw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Azs7r5hzq+oJhnDSjjywtW9vxKYDAae858wPljQ2F1w=; b=r3yk/cNJvS+K2xJfeMpETzDhbR8TjGr/+W3Ze+GVRlPFnNY7Fbjj5ZFf2NoJqB0lOj NL0pCcLde+/SVo/LgfOZfcuTvb2IcR3WnQ7ddynF7+fbUulBrwnCOwDNI3TewZLqL15h JUsLLHTOEa1l4KHgweAYD7oz8y8qDgbIP0CDj15uGvq7qRssogSP1mfyM5LjDyFbKRbP GqE17OV6rPJdfhMC+XiBKNKmf0JRClvzcuyiVcXILTLDU6ktOvv8WNKZMZEk+vrkhbI0 OlLgslyQXujaRo5zK5qb4oliUdbBYIv3hNGBrMjIxqPgl4qRM9BGGUZ0xgBYkxtsHiHX TRlQ== X-Gm-Message-State: AOAM531MLI2Ih4xZCm5jmO+XgBLFkxnJS64d2e2mQAhVB3cebbsSG5SP lJa4PSYNrj0dQeZtoNJlscupw/tMzXcplrEr6j3LFXOQ1zTPW0wXUMBi/cNjIPlG1y5vRei8iXS Hztm5UtDMPAfOE5Fmc821jFklTfA= X-Received: by 2002:adf:828e:: with SMTP id 14mr27636556wrc.123.1614796687173; Wed, 03 Mar 2021 10:38:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJwH/Hw0IbejeS6DgJJnJUnpPbEdOJiVBVsy5hA87NNUcL1xbXFsMP09GxNLjcIFhY0X+cBFOA== X-Received: by 2002:adf:828e:: with SMTP id 14mr27636541wrc.123.1614796687008; Wed, 03 Mar 2021 10:38:07 -0800 (PST) Subject: Re: [PATCH v3 4/7] hw/core: implement a guest-loader to support static hypervisor guests From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org Cc: julien@xen.org, andre.przywara@arm.com, stefano.stabellini@linaro.org, xen-devel@lists.xenproject.org, stefano.stabellini@xilinx.com, stratos-dev@op-lists.linaro.org References: <20210303173642.3805-1-alex.bennee@linaro.org> <20210303173642.3805-5-alex.bennee@linaro.org> <224e4bad-6185-a457-ddb5-f04d5c16e2dc@redhat.com> Message-ID: Date: Wed, 3 Mar 2021 19:38:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <224e4bad-6185-a457-ddb5-f04d5c16e2dc@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 3/3/21 7:37 PM, Philippe Mathieu-Daudé wrote: > On 3/3/21 6:36 PM, Alex Bennée wrote: >> Hypervisors, especially type-1 ones, need the firmware/bootcode to put >> their initial guest somewhere in memory and pass the information to it >> via platform data. The guest-loader is modelled after the generic >> loader for exactly this sort of purpose: >> >> $QEMU $ARGS -kernel ~/xen.git/xen/xen \ >> -append "dom0_mem=1G,max:1G loglvl=all guest_loglvl=all" \ >> -device guest-loader,addr=0x42000000,kernel=Image,bootargs="root=/dev/sda2 ro console=hvc0 earlyprintk=xen" \ >> -device guest-loader,addr=0x47000000,initrd=rootfs.cpio >> >> Signed-off-by: Alex Bennée >> Message-Id: <20201105175153.30489-5-alex.bennee@linaro.org> >> Message-Id: <20210211171945.18313-5-alex.bennee@linaro.org> >> --- >> hw/core/guest-loader.h | 34 ++++++++++ >> hw/core/guest-loader.c | 145 +++++++++++++++++++++++++++++++++++++++++ >> MAINTAINERS | 5 ++ >> hw/core/meson.build | 2 + >> 4 files changed, 186 insertions(+) >> create mode 100644 hw/core/guest-loader.h >> create mode 100644 hw/core/guest-loader.c > > Missing documentation, And I now see the following patches... > Reviewed-by: Philippe Mathieu-Daudé > From xen-devel-bounces@lists.xenproject.org Wed Mar 03 18:45:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 18:45:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92979.175452 (Exim 4.92) (envelope-from ) id 1lHWUr-0008Vp-Ap; Wed, 03 Mar 2021 18:45:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92979.175452; Wed, 03 Mar 2021 18:45:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHWUr-0008Vi-6r; Wed, 03 Mar 2021 18:45:21 +0000 Received: by outflank-mailman (input) for mailman id 92979; Wed, 03 Mar 2021 18:45:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHWUq-0008Vd-AM for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 18:45:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHWUo-0006gi-8a; Wed, 03 Mar 2021 18:45:18 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lHWUn-0007Xc-UD; Wed, 03 Mar 2021 18:45:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=aoDhiAAJ9xQuzM22SyJNcyS6Wir5HYSXnKHllgaD5fs=; b=0ChI2jp9Prlz9AtiG6ObhWFAz4 q0z244vak/VIy/x8S/4w4mgdF608R9dZKuCTDV673DJjuKuZ3juzjfR1LX4nu69bUn4bDRHKqmGgI yq48Vr+4fC5F8bPZx7biIGoNbCKx9PKKS/KKHfrBF1pDUp0oY40k8TUT0Fy4F9NJLCxo=; Subject: Re: [PATCH XENSTORE v1 00/10] Code analysis fixes To: Norbert Manthey , xen-devel@lists.xenproject.org Cc: Ian Jackson , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> From: Julien Grall Message-ID: <5ec05aca-9ba5-74b3-154a-603b06d307cf@xen.org> Date: Wed, 3 Mar 2021 18:45:16 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226144144.9252-1-nmanthey@amazon.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Norbert, Thank you for the patches. Please find below a state for each patches. On 26/02/2021 14:41, Norbert Manthey wrote: For the following patches: > xenstore: add missing NULL check > xenstore: fix print format string > xenstore: check formats of trace > xenstore: handle do_mkdir and do_rm failure > xenstore: add missing NULL check > xs: add error handling They are fully reviewed and Ian provided a release-acked-by. So I have merged them to staging. Note that last one was merged with the commit message/title tweaked. For the following patches: > xenstore_client: handle memory on error > xenstore: handle daemon creation errors They are fully reviewed but so far Ian didn't provided a release-acked-by. If you (or someone else) think they should be merged, then please reply on each patch. For now, I have merged them to my for-next/4.16 branch [1]. The patches will be folded in staging when the tree is re-opened. For the following patch: > xenstored: handle port reads correctly IIUC, this was dropped. For the following patch: > xs: handle daemon socket error Ian had one question about it. I haven't committed it in any branch for now. Cheers, [1] https://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=shortlog;h=refs/heads/for-next/4.16 -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 03 19:09:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 19:09:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92989.175480 (Exim 4.92) (envelope-from ) id 1lHWrs-0002YH-Em; Wed, 03 Mar 2021 19:09:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92989.175480; Wed, 03 Mar 2021 19:09:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHWrs-0002YA-Ba; Wed, 03 Mar 2021 19:09:08 +0000 Received: by outflank-mailman (input) for mailman id 92989; Wed, 03 Mar 2021 19:09:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHWrq-0002Qz-P8 for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 19:09:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHWro-00075y-Oj; Wed, 03 Mar 2021 19:09:04 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lHWro-0000u1-EN; Wed, 03 Mar 2021 19:09:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=HHl7CbKe842x6L3ZBNTiCkfdEnWUugn9UObJELtoTFw=; b=WmjBwNs27okyH9PLTp92pglpSV YFTZ4U9B43dpzGi6tz3C1q2KVOKfCMATkAk58hUUS8VR+wJNNdERrD58e4yGBPJUfchL1ocNXIZsU r0TcnJ/SJFJcpycnkQd4968MniaKtrM80QRxZWNWsnczGINSohe4uaIaG5RdyB+UNJ80=; Subject: Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11 To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu References: <05fe3295-7993-2eb5-37bc-a6d04fde1fbc@suse.com> From: Julien Grall Message-ID: <7e0584ab-8923-cb59-fac2-c2908d736f0c@xen.org> Date: Wed, 3 Mar 2021 19:09:02 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <05fe3295-7993-2eb5-37bc-a6d04fde1fbc@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 01/03/2021 07:57, Jan Beulich wrote: > The upcoming release complains, not entirely unreasonably: > > In file included from rijndael.c:33: > .../xen/include/crypto/rijndael.h:55:53: note: previously declared as 'const unsigned char[]' > 55 | void rijndaelEncrypt(const unsigned int [], int, const unsigned char [], > | ^~~~~~~~~~~~~~~~~~~~~~ > rijndael.c:865:8: error: argument 4 of type 'u8[16]' {aka 'unsigned char[16]'} with mismatched bound [-Werror=array-parameter=] > 865 | u8 ct[16]) > | ~~~^~~~~~ > In file included from rijndael.c:33: > .../xen/include/crypto/rijndael.h:56:13: note: previously declared as 'unsigned char[]' > 56 | unsigned char []); > | ^~~~~~~~~~~~~~~~ > > While it's not really clear to me why it would complain only for arg 4, > the adjustment to make is obvious and riskfree also for arg 3: Simply > declare the correct array dimension right away. This then allows > compilers to apply checking at call sites, which seems desirable anyway. I am a bit confused, if GCC is not complaining for arg3, then what is the following error message for: > In file included from rijndael.c:33: > .../xen/include/crypto/rijndael.h:55:53: note: previously declared as 'const unsigned char[]' > 55 | void rijndaelEncrypt(const unsigned int [], int, const unsigned char [], > | ^~~~~~~~~~~~~~~~~~~~~~ > For the moment I'm leaving untouched the disagreement between u8/u32 > used in the function definition and unsigned {char,int} used in the > declaration, as making this consistent would call for touching further > functions. > > Reported-by: Charles Arnold > Signed-off-by: Jan Beulich > --- > There are quite a few more issues with gcc11, but from my brief initial > inspection I'm suspecting (hoping) it'll rather be the compiler which > will get further changed by the time their release gets finalized. Just > one example: > > .../xen/include/xen/string.h:101:27: error: '__builtin_memcmp' specified bound 4 exceeds source size 0 [-Werror=stringop-overread] > 101 | #define memcmp(s1, s2, n) __builtin_memcmp(s1, s2, n) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > mpparse.c:722:13: note: in expansion of macro 'memcmp' > 722 | if (memcmp(mpf->mpf_signature, "_MP_", 4) == 0 && > | ^~~~~~ > > Clearly neither the 1st nor the 2nd argument have a "source size" of 0. It looks like there is a report on the redhat bug tracker for it [1]. Do you know if there is a bug report on the GCC tracker as well? > > --- a/xen/include/crypto/rijndael.h > +++ b/xen/include/crypto/rijndael.h > @@ -52,7 +52,7 @@ > > int rijndaelKeySetupEnc(unsigned int [], const unsigned char [], int); > int rijndaelKeySetupDec(unsigned int [], const unsigned char [], int); > -void rijndaelEncrypt(const unsigned int [], int, const unsigned char [], > - unsigned char []); > +void rijndaelEncrypt(const unsigned int [], int, const unsigned char [16], > + unsigned char [16]); > > #endif /* __RIJNDAEL_H */ > Cheers, [1] https://bugzilla.redhat.com/show_bug.cgi?id=1892100 -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 03 19:36:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 19:36:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92992.175492 (Exim 4.92) (envelope-from ) id 1lHXIW-0005TI-NZ; Wed, 03 Mar 2021 19:36:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92992.175492; Wed, 03 Mar 2021 19:36:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHXIW-0005TB-KC; Wed, 03 Mar 2021 19:36:40 +0000 Received: by outflank-mailman (input) for mailman id 92992; Wed, 03 Mar 2021 19:36:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHXIU-0005Sy-AL; Wed, 03 Mar 2021 19:36:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHXIP-0007X3-Qm; Wed, 03 Mar 2021 19:36:33 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lHXIP-0002sj-EV; Wed, 03 Mar 2021 19:36:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:Cc:References:To:Subject; bh=sDk3J6ex41e5UOfMIFRJGkpw25WoxzOov78X8K+E68k=; b=aHEncM9LyU60KAaFMrmYIgDhiF E9yYqh02QvUhvsQxqZKNJiY4+SSLF9tUm22UHMB5uXdtSTwc3QX0uH9r6iEYYHeFIXejsMvaouwqf loMV7EKupzGZ2xOSCDS+gpjsXaaW1Ff7d3ELVtOzaSPYpX56puu8ozLWtYgNO9GuXwFo=; Subject: Re: dom0less boot two compressed kernel images out-of-memory work-around To: Charles Chiou , "xen-devel@lists.xenproject.org" References: Cc: Jan Beulich , Stefano Stabellini , Ian Jackson , Andrew Cooper From: Julien Grall Message-ID: <58aaf68f-4499-9400-6eb2-f1ad3b620c73@xen.org> Date: Wed, 3 Mar 2021 19:36:31 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit (BCCing xen-users, CCing xen-devel + a few folks) Hi, Moving the discussion to xen-devel. On 22/02/2021 05:02, Charles Chiou wrote: > When trying to boot two zImage using dom0less boot on ARM, we encountered this problem when xen runs gunzip on second guest: > > (XEN) **************************************** > (XEN) Panic on CPU 0: > (XEN) Out of memory > (XEN) **************************************** > > And worked around it with the following patch. We'd like to check to see if this is a known issue and if the work-around looks reasonable. Thank you I haven't seen any similar report in the past. > > > diff --git a/xen/common/gunzip.c b/xen/common/gunzip.c > index db4efcd34b..e5bd19ba7f 100644 > --- a/xen/common/gunzip.c > +++ b/xen/common/gunzip.c > @@ -113,8 +113,10 @@ __init int perform_gunzip(char *output, char *image, unsigned long image_len) > > window = (unsigned char *)output; > > + if (!free_mem_ptr) { > free_mem_ptr = (unsigned long)alloc_xenheap_pages(HEAPORDER, 0); > free_mem_end_ptr = free_mem_ptr + (PAGE_SIZE << HEAPORDER); > + } > > inbuf = (unsigned char *)image; > insize = image_len; > @@ -131,7 +133,12 @@ __init int perform_gunzip(char *output, char *image, unsigned long image_len) > rc = 0; > } > > + if (free_mem_ptr) { > free_xenheap_pages((void *)free_mem_ptr, HEAPORDER); > + free_mem_ptr = 0; > + } > + > + bytes_out = 0; > > return rc; > } > diff --git a/xen/common/inflate.c b/xen/common/inflate.c > index f99c985d61..de96002188 100644 > --- a/xen/common/inflate.c > +++ b/xen/common/inflate.c > @@ -244,7 +244,7 @@ static void *INIT malloc(int size) > > if (size < 0) > error("Malloc error"); > - if (!malloc_ptr) > + if ((!malloc_ptr) || (!malloc_count)) > malloc_ptr = free_mem_ptr; > IMHO, this is a bit risky to assume that malloc_count will always be 0 after each gunzip. Instead I think, it would be better if we re-initialize the allocator every time. How about the following (untested): commit e1cd2d85234c8d0aa62ad32c824a5568a57be930 (HEAD -> dev) Author: Julien Grall Date: Wed Mar 3 19:27:56 2021 +0000 xen/gunzip: Allow perform_gunzip() to be called multiple times Currently perform_gunzip() can only be called once because the the internal allocator is not fully re-initialized. This works fine if you are only booting dom0. But this will break when booting multiple using the dom0less that uses compressed kernel images. This can be resolved by re-initializing malloc_ptr and malloc_count every time perform_gunzip() is called. Note the latter is only re-initialized for hardening purpose as there is no guarantee that every malloc() are followed by free() (It should in theory!). Take the opportunity to check the return of alloc_heap_pages() to return an error rather than dereferencing a NULL pointer later on failure. Reported-by: Charles Chiou Signed-off-by: Julien Grall --- This patch is candidate for Xen 4.15. Without this patch, it will not be possible to boot multiple domain using dom0less when they are using compressed kernel images. diff --git a/xen/common/gunzip.c b/xen/common/gunzip.c index db4efcd34b77..a5c2e25efc0f 100644 --- a/xen/common/gunzip.c +++ b/xen/common/gunzip.c @@ -114,7 +114,11 @@ __init int perform_gunzip(char *output, char *image, unsigned long image_len) window = (unsigned char *)output; free_mem_ptr = (unsigned long)alloc_xenheap_pages(HEAPORDER, 0); + if ( !free_mem_ptr ) + return -ENOMEM; + free_mem_end_ptr = free_mem_ptr + (PAGE_SIZE << HEAPORDER); + init_allocator(); inbuf = (unsigned char *)image; insize = image_len; diff --git a/xen/common/inflate.c b/xen/common/inflate.c index f99c985d6135..d8c28a3e9593 100644 --- a/xen/common/inflate.c +++ b/xen/common/inflate.c @@ -238,6 +238,12 @@ STATIC const ush mask_bits[] = { static unsigned long INITDATA malloc_ptr; static int INITDATA malloc_count; +static void init_allocator(void) +{ + malloc_ptr = free_mem_ptr; + malloc_count = 0; +} + static void *INIT malloc(int size) { void *p; Best regards, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 03 19:58:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 19:58:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.92998.175504 (Exim 4.92) (envelope-from ) id 1lHXdD-0007bl-IY; Wed, 03 Mar 2021 19:58:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92998.175504; Wed, 03 Mar 2021 19:58:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHXdD-0007be-FR; Wed, 03 Mar 2021 19:58:03 +0000 Received: by outflank-mailman (input) for mailman id 92998; Wed, 03 Mar 2021 19:58:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHXdC-0007bW-CR; Wed, 03 Mar 2021 19:58:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHXdC-0007ss-3i; Wed, 03 Mar 2021 19:58:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHXdB-0002Tm-Og; Wed, 03 Mar 2021 19:58:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHXdB-0005jo-OD; Wed, 03 Mar 2021 19:58:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dLREO563o8piwlH8UT38pEDh30adwj5VW82mYCDCic8=; b=3RFojEuAMOmXCaL+p5ij05I4x5 VuY6lnCV3grCtGDCPLr9K3hvryWvtXDjfBq6TUeRMBFuHIdt/vgslrtFJdoATGlWvM969Nu1pzube jtdg8ymVUxPkQpm2NEaELgCfkM2Qyuu4n932PpD0mIVQGjX4oHvDus0xGw2W71MbUEds=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159814: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4834936549f788378918da8e9bc97df7dd3ee16d X-Osstest-Versions-That: xen=4834936549f788378918da8e9bc97df7dd3ee16d From: osstest service owner Date: Wed, 03 Mar 2021 19:58:01 +0000 flight 159814 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/159814/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 159808 pass in 159814 test-amd64-amd64-examine 4 memdisk-try-append fail pass in 159808 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 159808 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159808 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159808 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159808 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159808 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159808 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159808 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159808 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159808 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159808 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159808 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159808 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 4834936549f788378918da8e9bc97df7dd3ee16d baseline version: xen 4834936549f788378918da8e9bc97df7dd3ee16d Last test of basis 159814 2021-03-03 08:51:49 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed Mar 03 22:02:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 03 Mar 2021 22:02:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93009.175523 (Exim 4.92) (envelope-from ) id 1lHZYs-00049F-Rh; Wed, 03 Mar 2021 22:01:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93009.175523; Wed, 03 Mar 2021 22:01:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHZYs-000498-OX; Wed, 03 Mar 2021 22:01:42 +0000 Received: by outflank-mailman (input) for mailman id 93009; Wed, 03 Mar 2021 22:01:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHZYr-000490-Jm; Wed, 03 Mar 2021 22:01:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHZYr-0001WD-AD; Wed, 03 Mar 2021 22:01:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHZYr-0007vW-0U; Wed, 03 Mar 2021 22:01:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHZYq-0007mX-WF; Wed, 03 Mar 2021 22:01:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tlsDqtut7XXBxHQmHrK032BenkcaW2kDPV+rjLgc72o=; b=NGOAjcvKsUdDzck01BwRZyMVvP HJiHEFz7JS1RRfGOSfS+JlDt/+yEqKWs4fiRWIpPd/0tRGg25fdNR1oWqsm1ucCme3+sHab4C6jNA ye+CWrJed6kPgYzfOmI1yH9zeTdMbaibxSXmY+EabS0nr0l7vWqqDOeqbhd9TM8kDwAE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159819: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=243036df0d55673de59c214e240b9b914d278b65 X-Osstest-Versions-That: xen=4834936549f788378918da8e9bc97df7dd3ee16d From: osstest service owner Date: Wed, 03 Mar 2021 22:01:40 +0000 flight 159819 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159819/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 243036df0d55673de59c214e240b9b914d278b65 baseline version: xen 4834936549f788378918da8e9bc97df7dd3ee16d Last test of basis 159805 2021-03-02 13:01:32 Z 1 days Testing same since 159819 2021-03-03 19:01:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kurth Norbert Manthey jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4834936549..243036df0d 243036df0d55673de59c214e240b9b914d278b65 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Mar 04 02:02:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 02:02:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93018.175538 (Exim 4.92) (envelope-from ) id 1lHdJZ-00057c-Mo; Thu, 04 Mar 2021 02:02:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93018.175538; Thu, 04 Mar 2021 02:02:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHdJZ-00057V-Il; Thu, 04 Mar 2021 02:02:09 +0000 Received: by outflank-mailman (input) for mailman id 93018; Thu, 04 Mar 2021 02:02:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHdJY-00057N-NJ; Thu, 04 Mar 2021 02:02:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHdJX-0007yw-Mb; Thu, 04 Mar 2021 02:02:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHdJX-0001e0-CL; Thu, 04 Mar 2021 02:02:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHdJX-0003lW-As; Thu, 04 Mar 2021 02:02:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=01xMDHg6NoCoZBMgm+oXLcTgSr4P7wHlyZ12zYp0BJg=; b=HItpSPpNtwfCvBEkE7l/YWNLga sqER2YaVBPtcXAsz8ySpVuHsA6TCvCfxDsAskGo0d33ITaYjn1WZI0vRxFRkOPOG1ocKSYO/hA/WU cxWqU1Cl4ByBUiF91cL/OzyYYY8ubeEilpeaPzR+JdmmfK41PGLChDNBVmLBVmIDjrxE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159817: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=cbcf09872a936ccefef6a34298046d3b9aefc148 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Thu, 04 Mar 2021 02:02:07 +0000 flight 159817 qemu-mainline real [real] flight 159821 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159817/ http://logs.test-lab.xenproject.org/osstest/logs/159821/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu cbcf09872a936ccefef6a34298046d3b9aefc148 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 195 days Failing since 152659 2020-08-21 14:07:39 Z 194 days 375 attempts Testing same since 159810 2021-03-03 00:37:02 Z 1 days 2 attempts ------------------------------------------------------------ 428 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 118088 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 04 03:13:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 03:13:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93026.175552 (Exim 4.92) (envelope-from ) id 1lHeQc-0003UO-30; Thu, 04 Mar 2021 03:13:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93026.175552; Thu, 04 Mar 2021 03:13:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHeQb-0003UH-Vw; Thu, 04 Mar 2021 03:13:29 +0000 Received: by outflank-mailman (input) for mailman id 93026; Thu, 04 Mar 2021 03:13:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHeQb-0003U9-3r; Thu, 04 Mar 2021 03:13:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHeQa-0000fO-Tm; Thu, 04 Mar 2021 03:13:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHeQa-00051d-Ja; Thu, 04 Mar 2021 03:13:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHeQa-0006hI-J6; Thu, 04 Mar 2021 03:13:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1JJv7M3zKUPm6Ca5G/Jgd5xhvFQXktBqdHtNUxyDI0Q=; b=h28fPnFoHFdFdhx+Qu8gB1HiYW VOtBcD9QQnfx9ojTjyvYLl0UlMdNhFfHbUb0mU+h20ZuI6U6OCTSXFvicrQPOJFYGY2Zcz02ra7Fk mf2qSQaUenUkdR54PIlTUJjo8BqMQ8/BPclzBZX8diZ79u8/VPZxWEyaCMfvwaeO9hJY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159818: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f69d02e37a85645aa90d18cacfff36dba370f797 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Thu, 04 Mar 2021 03:13:28 +0000 flight 159818 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159818/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 159811 pass in 159818 test-amd64-amd64-examine 4 memdisk-try-append fail pass in 159811 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux f69d02e37a85645aa90d18cacfff36dba370f797 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 215 days Failing since 152366 2020-08-01 20:49:34 Z 214 days 371 attempts Testing same since 159811 2021-03-03 03:12:26 Z 0 days 2 attempts ------------------------------------------------------------ 5136 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1271901 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 04 07:51:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 07:51:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93036.175568 (Exim 4.92) (envelope-from ) id 1lHilW-0005MQ-SW; Thu, 04 Mar 2021 07:51:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93036.175568; Thu, 04 Mar 2021 07:51:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHilW-0005MJ-Ob; Thu, 04 Mar 2021 07:51:22 +0000 Received: by outflank-mailman (input) for mailman id 93036; Thu, 04 Mar 2021 07:51:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHilV-0005ME-0l for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 07:51:21 +0000 Received: from mga11.intel.com (unknown [192.55.52.93]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7e496c94-a208-4d20-8d42-8c11be1ed978; Thu, 04 Mar 2021 07:51:17 +0000 (UTC) Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2021 23:51:15 -0800 Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga008.jf.intel.com with ESMTP; 03 Mar 2021 23:51:15 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 3 Mar 2021 23:51:14 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 3 Mar 2021 23:51:14 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 3 Mar 2021 23:51:14 -0800 Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by CO1PR11MB5108.namprd11.prod.outlook.com (2603:10b6:303:92::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Thu, 4 Mar 2021 07:51:13 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::f1b4:bace:1e44:4a46]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::f1b4:bace:1e44:4a46%6]) with mapi id 15.20.3890.031; Thu, 4 Mar 2021 07:51:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e496c94-a208-4d20-8d42-8c11be1ed978 IronPort-SDR: QFQdcMwgTqG0wPiNjkoA5ExfB+nHOK0tjm+GY+gQQHmNyHt4rthQx7iZSomcxD1VhEPlCJjQ9o zGBjHsZSdN2w== X-IronPort-AV: E=McAfee;i="6000,8403,9912"; a="183987839" X-IronPort-AV: E=Sophos;i="5.81,222,1610438400"; d="scan'208";a="183987839" IronPort-SDR: KWjhXRXCityOAZpAK4ZkP2aB0aztzNMeFSfx+80q8dK9IMh9NuB0Q2cQCDqV2nU3qTlXPOL2xI fF5rGtkubnMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,222,1610438400"; d="scan'208";a="407659330" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YKUyYK6S7UkPJqRpS3qITfc9ALun7d4wwvEtLke5eosSWnSHc+ObhndsAqw/z0KMIh6eerq6FzCFZYXb77LpXlIu08lF2PoF7DfRn64tLyPNCwWVObCrFpcwfvetQIYADpJFKfVSbjovHuGJf04kMcPNywCVQT17Kwd2hOZk1yA1c16zIfLWlowgyBui1YGnfQt11LfK37itcPOvxuE4k+qpVQ6BbihpzXLshFU9bMLbA8kqNHYW4JXx2S91o7fnoQT80XA0lrWSRYJSaKnS03mBMYH+GfVGrFA9nLuJ9Wro13jGWp3kAn+NgnR3JgQQ6jQTsKA/kuW4UrDnXAOCcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wxgJzFs0tRBBf4a6bUY+PB6jxjVfNGu0WK0yLzcXvoA=; b=QQhBdfp1aXleqWJ/fyp4LAmiXVq52aSy7P1UnF7J6PQEBH0UeEACTGkoYVNayrMPsFIqU2Hja+gAn0kQwNXA3P31if+X3MBVxuzvw/t6dL0Is3HMrTyIT3LJhJU+tnw94Ckvbszz4eA7zp2TMGfMP9XTHBogenVlEifdWw++qxu0BlPhIjYtdvKHqbXY/mBoYJ5XiI//2/CSc1kbjdpodBcefE/dzioHFJKODw7bh1rNN1ul6DYUeiLCQZMkpF0iBS9RaoCWlYVzehEI7x0jfgQon18XIgdeamxQ6dbxJt8LoVyOGRlNHnizCoG1SMGwBTMN+gZhp6eltBx+0RhK9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wxgJzFs0tRBBf4a6bUY+PB6jxjVfNGu0WK0yLzcXvoA=; b=qc6wEy3zcxGX5Hiu52lIcazqDuv60x8Au/yo9NWbdd5HnWslAhSxSjOANC8vQT48LW6OTl6RnUeSiaB5oUjMNTuFjL4Y/lfktrhzOnwX2Klotuy42nKHIGzrDnKfrh1l9bfSCGqiMZCBpRnOJVb2SzzgQQYrkX9/YE8HQrS+QDg= From: "Tian, Kevin" To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Julien Grall" , "Cooper, Andrew" , "Wei Liu" , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: RE: [PATCH] VMX: use a single, global APIC access page Thread-Topic: [PATCH] VMX: use a single, global APIC access page Thread-Index: AQHW/8yZa97+qDgbIE6iwG3wuPN9papSpOiAgAAfJYCAAAsJgIAAAbyAgAASBACAG55hYIAAZWcAgAABLbCAABuaAIAEjifQ Date: Thu, 4 Mar 2021 07:51:12 +0000 Message-ID: References: <1b6a411b-84e7-bfb1-647e-511a13df838c@suse.com> <7abc515b-d652-3d39-6038-99966deafdf8@suse.com> <547b40f2-3b7b-10cb-30f6-9445c784eb0b@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 27ad954e-bfcb-4502-be75-08d8dee24835 x-ms-traffictypediagnostic: CO1PR11MB5108: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: apuHNXyPGwgt3UfcrqzksiRVgbc/fV8y9wjc7UwRf2YgtTosJA3Qi5O8GlZndtzdV5GiXfr+yn8CB58n/XTpRgs8U4Daqc5Nu6dzFJVbXTy/97GHE2yPIviL7ieJDMprN2dF5vd5S8QK4QlWc5j9BgTg7huQyeSM4mwyJFbA04+vQUecIIkzHmeb2vI8JGDZD6nHhZZKZCIz/PM8AD7Ldsm44dN8JBPPiyoz0ot5tqyaW4/rwRvAEAI/oRPZPivhpyLmtx+0+emdjl4VJNXU1YaCoh7bGgIe9In4riZHC2jV9OMWKu8RzdewDR9UoQvhrwXkn8Fa+EC0BwiXh5XmP2jLVBnXwi7lPWFLX+0BSK7cjP5yM+NJm4NFjjcikVxbYiNeBHFAygCej5uQCmEOfb6wysHbRfoGAGLTJCJCZXoB+MyRlmlChKnvAKyWK+vOkBFzOMiflPCF8BV77eJgkka0DcG/Jq6Lse7ifXAo95CGqZcQrMh9q2670Pj7wbQMuF7DzblfyVrL14HiR4veBA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1886.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(366004)(396003)(346002)(39860400002)(316002)(55016002)(7696005)(86362001)(4326008)(66446008)(6916009)(54906003)(9686003)(8936002)(8676002)(33656002)(71200400001)(2906002)(66556008)(26005)(5660300002)(52536014)(83380400001)(76116006)(66946007)(53546011)(6506007)(478600001)(66476007)(64756008)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?utf-8?B?ZUsxY2RBbTFZbGZnbmt1QXFLYnVZdHNVQUE0RVZoQmdDcVVBTjIza3ZucHZS?= =?utf-8?B?QmZZWmRlRFYyZ1pZdDV6VEtOSjFsY3Zwd0NtZ05EY2dEZXJqZmxkU3BZSmYv?= =?utf-8?B?RWZyR2xxeGg4UE1OOUR4N3V5Y2NFa2xTSXBKRys1RldhY01OZkpQM3l0SXV5?= =?utf-8?B?UFM1ei9RVHhTTEZxYzZ3bjJvcWFGZEJDYUJrTzE5UnVNVzNrQzNyTk1iRHRW?= =?utf-8?B?b3ByQ2hhdDR0VzZXZit1Mitab3JkWndIcmJ5ckNzZUdjNGlKdjRYNTgySWJz?= =?utf-8?B?MDFhWnRBSlBDSmNnUjVoL0JCZnQ2dmErMmV0ZGxucUhUSkZRT1ZRWUxDWnV4?= =?utf-8?B?M0RGbzF2S1BSYXFuTzYvaGw4VXNuTkplSmVQMVR6QmZOYnRKckhKWDRJMEs4?= =?utf-8?B?NmtFMGpYY1N4QXJPSkx5cUJJTndQeEd6OEZMeGFwTkNIcTUzb05aYlZQTWpU?= =?utf-8?B?dlJlc1RmSFk2dlVCTFh0OGVyUVlRam1jRHpjS0gwdFNkdUZsL2dUWE5ZZHp2?= =?utf-8?B?djRYbHhIdHd4N3lwd1JYTXlqdC9adExwL3J1d053QWxTT1dmZUN6OEJWb2ZU?= =?utf-8?B?RTJVM3ZhRHV2WVFIRE1YMHJSSXgxMHpWSDhqSHlqZk9ZWkNVUm5RckNMNllz?= =?utf-8?B?bWhzZGtLMEY3bVhQRm1zYWgxcHFNUFJaSjlmaERzUGNzZ1RxSmNQcmcxYmRr?= =?utf-8?B?NGJHTXdMWDVoT2h1R010cU1aRm1pTERhVEV2VnUxK3FvcUZuajFYdzEvRW1r?= =?utf-8?B?N1BZc0lZS0JDTTVWN0wvYVp3VWN2U2JjVmhHaStndW0wQ3Bzc0tKMUUwOHVY?= =?utf-8?B?d1hFWjRGVUpKQmhIclFJd2ZnSjdBc1BaWTc5bDNhaXc2eUt4UGgzSldJZUtz?= =?utf-8?B?eFl2YTVHWGhoeTQ2TzRVVDQ2SHRpMzNhS0ZqTXU1TG1UdjlhandvYUdGdXhn?= =?utf-8?B?YXVhdjJ0SlVTWXFuV2VVbDdOcjNhZThQb1pmRUlaYTFvdE5rUGhLT1Z1SWtT?= =?utf-8?B?c3NxL0J1UFBtazVSSW9YZGxCY3JOK1RjazlHTlh3anRjeUVrYng1QXFYdzl3?= =?utf-8?B?Y0xueWptTFVOTWFWK2VmckJaVEE0QmlaajhrS2tDSkdDY1pwVXJ4Q3ZETy84?= =?utf-8?B?ZVVQc3djVWZrSkJjQ1NvMllzdzFyUGhpRE8xMU1kYnJkZEFqZXMzYmVTRGZB?= =?utf-8?B?OGxIQjVqQTdONHphVERpMWdsQkpxd3BrMU1CYWdSbG0vZGpZVSthV296Qy9l?= =?utf-8?B?UjNHUEl0VVEvOXBTdDN3Ym83TU54aHJFZjV0NFZOV1pWbjFWOW1PU0EvZnVR?= =?utf-8?B?dkNBc2RlcUd1SHhLclRwZ1ZETkp3YlYyeGlUY2RIQjEvQW4xQjF6RVlXUTdM?= =?utf-8?B?QUhEMWtMWHNYZWRvTEZ5ODUvZ1VaVUV0cHBxbDFpL1RxVU5INHpVcFFrbVFs?= =?utf-8?B?bHVXNzRKOXk1a1RNSEh4dmtqdmdRTlZWRTZLRjJWazRLOThoOHdhZkRaRld5?= =?utf-8?B?amYzc29OMXJFSVQrdHBTVFNRWGxTUXBKU1JZcG9QaGcyNWExTG9BekRvaWds?= =?utf-8?B?REZBZHRyTThkTG9nK2hKK1IxbFVzd3JLZXdjQjZIa25zVHdXZGxMQlV2VDBZ?= =?utf-8?B?Wk9Qc1lYRkhJVm04dng3TWdjcFpnT1daV3l3UGlhQWZOOEtIaTRIZVQwcXk1?= =?utf-8?B?YnEvdERjNnlBRkViUmRvNlZQeEZHTnhsRGdZdnpVK2wzK3pzRTJSMTBicW1I?= =?utf-8?Q?74rnNT79gbGXZQotgB4mZmub32+GIC5ZMt5a3QU?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27ad954e-bfcb-4502-be75-08d8dee24835 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2021 07:51:12.7282 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ohm6dpgIvuP2sWmt0eWtpLPjkIwDYef7un+AyYwF7NPK4t9xIQC6Ny2WGdBHL4If6igz9TVsCIVz8OWWDsPK1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5108 X-OriginatorOrg: intel.com PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg TWFyY2ggMSwgMjAyMSA1OjU5IFBNDQo+IA0KPiBPbiAwMS4wMy4yMDIxIDA5OjMwLCBUaWFuLCBL ZXZpbiB3cm90ZToNCj4gPj4gRnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0K PiA+PiBTZW50OiBNb25kYXksIE1hcmNoIDEsIDIwMjEgNDoxNiBQTQ0KPiA+Pg0KPiA+PiBPbiAw MS4wMy4yMDIxIDAzOjE4LCBUaWFuLCBLZXZpbiB3cm90ZToNCj4gPj4+PiBGcm9tOiBSb2dlciBQ YXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gPj4+PiBTZW50OiBUaHVyc2RheSwg RmVicnVhcnkgMTEsIDIwMjEgODoyNyBQTQ0KPiA+Pj4+DQo+ID4+Pj4gT24gVGh1LCBGZWIgMTEs IDIwMjEgYXQgMTI6MjI6NDFQTSArMDEwMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+ID4+Pj4+IE9u IDExLjAyLjIwMjEgMTI6MTYsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+ID4+Pj4+PiBPbiBU aHUsIEZlYiAxMSwgMjAyMSBhdCAxMTozNjo1OUFNICswMTAwLCBKYW4gQmV1bGljaCB3cm90ZToN Cj4gPj4+Pj4+PiBPbiAxMS4wMi4yMDIxIDA5OjQ1LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0K PiA+Pj4+Pj4+PiBPbiBXZWQsIEZlYiAxMCwgMjAyMSBhdCAwNTo0ODoyNlBNICswMTAwLCBKYW4g QmV1bGljaCB3cm90ZToNCj4gPj4+Pj4+Pj4+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJt LmgNCj4gPj4+Pj4+Pj4+ICsrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgNCj4gPj4+Pj4+ Pj4+IEBAIC05MzUsNiArOTM1LDkgQEAgc3RhdGljIGlubGluZSB1bnNpZ25lZCBpbnQgcDJtX2dl dF9pb21tdQ0KPiA+Pj4+Pj4+Pj4gICAgICAgICAgZmxhZ3MgPSBJT01NVUZfcmVhZGFibGU7DQo+ ID4+Pj4+Pj4+PiAgICAgICAgICBpZiAoICFyYW5nZXNldF9jb250YWluc19zaW5nbGV0b24obW1p b19yb19yYW5nZXMsDQo+ID4+IG1mbl94KG1mbikpICkNCj4gPj4+Pj4+Pj4+ICAgICAgICAgICAg ICBmbGFncyB8PSBJT01NVUZfd3JpdGFibGU7DQo+ID4+Pj4+Pj4+PiArICAgICAgICAvKiBWTVgn ZXMgQVBJQyBhY2Nlc3MgcGFnZSBpcyBnbG9iYWwgYW5kIGhlbmNlIGhhcyBubw0KPiBvd25lci4N Cj4gPj4+PiAqLw0KPiA+Pj4+Pj4+Pj4gKyAgICAgICAgaWYgKCBtZm5fdmFsaWQobWZuKQ0KPiAm JiAhcGFnZV9nZXRfb3duZXIobWZuX3RvX3BhZ2UobWZuKSkgKQ0KPiA+Pj4+Pj4+Pj4gKyAgICAg ICAgICAgIGZsYWdzID0gMDsNCj4gPj4+Pj4+Pj4NCj4gPj4+Pj4+Pj4gSXMgaXQgZmluZSB0byBo YXZlIHRoaXMgcGFnZSBhY2Nlc3NpYmxlIHRvIGRldmljZXMgaWYgdGhlIHBhZ2UgdGFibGVzDQo+ ID4+Pj4+Pj4+IGFyZSBzaGFyZWQgYmV0d2VlbiB0aGUgQ1BVIGFuZCB0aGUgSU9NTVU/DQo+ID4+ Pj4+Pj4NCj4gPj4+Pj4+PiBObywgaXQncyBub3QsIGJ1dCB3aGF0IGRvIHlvdSBkbz8gQXMgc2Fp ZCBlbHNld2hlcmUsIGRldmljZXMNCj4gPj4+Pj4+PiBnYWluaW5nIG1vcmUgYWNjZXNzIHRoYW4g aXMgaGVscGZ1bCBpcyB0aGUgcHJpY2Ugd2UgcGF5IGZvcg0KPiA+Pj4+Pj4+IGJlaW5nIGFibGUg dG8gc2hhcmUgcGFnZSB0YWJsZXMuIEJ1dCAuLi4NCj4gPj4+Pj4+DQo+ID4+Pj4+PiBJJ20gY29u Y2VybmVkIGFib3V0IGFsbG93aW5nIGRldmljZXMgdG8gd3JpdGUgdG8gdGhpcyBzaGFyZWQgcGFn ZSwgYXMNCj4gPj4+Pj4+IGNvdWxkIGJlIHVzZWQgYXMgYW4gdW5pbnRlbmRlZCB3YXkgdG8gZXhj aGFuZ2UgaW5mb3JtYXRpb24NCj4gYmV0d2Vlbg0KPiA+Pj4+Pj4gZG9tYWlucz8NCj4gPj4+Pj4N Cj4gPj4+Pj4gV2VsbCwgc3VjaCBhbiBhYnVzZSB3b3VsZCBiZSBwb3NzaWJsZSwgYnV0IGl0IHdv dWxkbid0IGJlIHBhcnQNCj4gPj4+Pj4gb2YgYW4gQUJJIGFuZCBoZW5jZSBjb3VsZCBicmVhayBh dCBhbnkgdGltZS4gU2ltaWxhcmx5IEkNCj4gPj4+Pj4gd291bGRuJ3QgY29uc2lkZXIgaXQgYW4g aW5mb3JtYXRpb24gbGVhayBpZiBhIGd1ZXN0IGFidXNlZA0KPiA+Pj4+PiB0aGlzLg0KPiA+Pj4+ DQo+ID4+Pj4gSG0sIEknbSBraW5kIG9mIHdvcnJpZWQgYWJvdXQgaGF2aW5nIHN1Y2ggc2hhcmVk IHBhZ2UgYWNjZXNzaWJsZSB0bw0KPiA+Pj4+IGd1ZXN0cy4gQ291bGQgSW50ZWwgY29uZmlybSB3 aGV0aGVyIHBhZ2VzIGluIHRoZSAweEZFRXh4eHh4IHJhbmdlIGFyZQ0KPiA+Pj4+IGFjY2Vzc2li bGUgdG8gZGV2aWNlcyBpbiBhbnkgd2F5IHdoZW4gdXNpbmcgSU9NTVUgc2hhcmVkIHBhZ2UNCj4g Pj4+PiB0YWJsZXM/DQo+ID4+Pg0KPiA+Pj4gMHhGRUV4eHh4eCByYW5nZSBpcyBzcGVjaWFsLiBS ZXF1ZXN0cyB0byB0aGlzIHJhbmdlIGFyZSBub3Qgc3ViamVjdCB0bw0KPiA+Pj4gRE1BIHJlbWFw cGluZyAoZXZlbiBpZiBhIHZhbGlkIG1hcHBpbmcgZm9yIHRoaXMgcmFuZ2UgZXhpc3RzIGluIHRo ZQ0KPiA+Pj4gSU9NTVUgcGFnZSB0YWJsZSkuIEFuZCB0aGlzIHNwZWNpYWwgdHJlYXRtZW50IGlz IHRydWUgcmVnYXJkbGVzcyBvZg0KPiA+Pj4gd2hldGhlciBpbnRlcnJ1cHQgcmVtYXBwaW5nIGlz IGVuYWJsZWQgKHdoaWNoIGNvbWVzIG9ubHkgYWZ0ZXIgYW4NCj4gPj4+IGludGVycnVwdCBtZXNz YWdlIHRvIHRoaXMgcmFuZ2UgaXMgcmVjb2duaXplZCkuDQo+ID4+DQo+ID4+IEZvciBteS9vdXIg ZWR1Y2F0aW9uLCBjb3VsZCB5b3Ugb3V0bGluZSB3aGF0IGhhcHBlbnMgdG8gZGV2aWNlDQo+ID4+ IGFjY2Vzc2VzIHRvIHRoYXQgcmFuZ2Ugd2hlbiBpbnRlcnJ1cHQgcmVtYXBwaW5nIGlzIG9mZj8g QW5kDQo+ID4+IHBlcmhhcHMgYWxzbyB3aGF0IGhhcHBlbnMgdG8gYWNjZXNzZXMgdG8gdGhpcyBy YW5nZSB0aGF0IGRvbid0DQo+ID4+IG1hdGNoIHRoZSBwYXR0ZXJuIG9mIGFuIE1TSSBpbml0aWF0 aW9uIChkd29yZCB3cml0ZSk/IEkgZG9uJ3QNCj4gPj4gdGhpbmsgSSd2ZSBiZWVuIGFibGUgdG8g c3BvdCBhbnl0aGluZyB0byB0aGlzIGVmZmVjdCBpbiB0aGUgZG9jcy4NCj4gPj4NCj4gPg0KPiA+ IEluIFZULWQgc3BlYyAiMy4xNCBIYW5kbGluZyBSZXF1ZXN0cyB0byBJbnRlcnJ1cHQgQWRkcmVz cyBSYW5nZSINCj4gPiAtLQ0KPiA+IE9uIEludGVswq4gYXJjaGl0ZWN0dXJlIHBsYXRmb3Jtcywg cGh5c2ljYWwgYWRkcmVzcyByYW5nZSAweEZFRXhfeHh4eCBpcw0KPiA+IGRlc2lnbmF0ZWQgYXMg dGhlIGludGVycnVwdCBhZGRyZXNzIHJhbmdlLiBSZXF1ZXN0cyB3aXRob3V0IFBBU0lEIHRvDQo+ ID4gdGhpcyByYW5nZSBhcmUgbm90IHN1YmplY3RlZCB0byBETUEgcmVtYXBwaW5nIChldmVuIGlm IHRyYW5zbGF0aW9uDQo+ID4gc3RydWN0dXJlcyBzcGVjaWZ5IGEgbWFwcGluZyBmb3IgdGhpcyBy YW5nZSkuDQo+ID4gLS0NCj4gPiBUaGUgZm9sbG93aW5nIHR5cGVzIG9mIHJlcXVlc3RzIHRvIHRo aXMgcmFuZ2UgYXJlIGlsbGVnYWwgcmVxdWVzdHMuDQo+ID4gVGhleSBhcmUgYmxvY2tlZCBhbmQg cmVwb3J0ZWQgYXMgSW50ZXJydXB0IFJlbWFwcGluZyBmYXVsdHMuDQo+ID4g4oCiIFJlYWQgcmVx dWVzdHMgd2l0aG91dCBQQVNJRCB0aGF0IGFyZSBub3QgWkxSLg0KPiA+IOKAoiBBdG9taWNzIHJl cXVlc3RzIHdpdGhvdXQgUEFTSUQuDQo+ID4g4oCiIE5vbi1EV09SRCBsZW5ndGggd3JpdGUgcmVx dWVzdHMgd2l0aG91dCBQQVNJRC4NCj4gPiAtLQ0KPiANCj4gQWgsIEkgc2VlLiBUaGF0J3MgKGFj Y29yZGluZyB0byB0aGUgY2hhbmdlIGJhcnMpIGEgcmVsYXRpdmVseSByZWNlbnQNCj4gYWRkaXRp b24uIFNvIHRoZSBhYm92ZSBjbGFyaWZpZXMgdGhpbmdzIGZvciB0aGUgIVBBU0lEIGNhc2UuIEFt IEkNCj4gaW50ZXJwcmV0aW5nDQo+IA0KPiAiUmVxdWVzdHMtd2l0aC1QQVNJRCB3aXRoIGlucHV0 IGFkZHJlc3MgaW4gcmFuZ2UgMHhGRUV4X3h4eHggYXJlDQo+ICB0cmFuc2xhdGVkIG5vcm1hbGx5 IGxpa2UgYW55IG90aGVyIHJlcXVlc3Qtd2l0aC1QQVNJRCB0aHJvdWdoDQo+ICBETUEtcmVtYXBw aW5nIGhhcmR3YXJlLiBIb3dldmVyLCBpZiBzdWNoIGEgcmVxdWVzdCBpcyBwcm9jZXNzZWQNCj4g IHVzaW5nIHBhc3MtdGhyb3VnaCB0cmFuc2xhdGlvbiwgaXQgd2lsbCBiZSBibG9ja2VkIGFzIGRl c2NyaWJlZA0KPiAgaW4gdGhlIHBhcmFncmFwaCBiZWxvdy4NCj4gDQo+ICBTb2Z0d2FyZSBtdXN0 IG5vdCBwcm9ncmFtIHBhZ2luZy1zdHJ1Y3R1cmUgZW50cmllcyB0byByZW1hcCBhbnkNCj4gIGFk ZHJlc3MgdG8gdGhlIGludGVycnVwdCBhZGRyZXNzIHJhbmdlLiBVbnRyYW5zbGF0ZWQgcmVxdWVz dHMgYW5kDQo+ICB0cmFuc2xhdGlvbiByZXF1ZXN0cyB0aGF0IHJlc3VsdCBpbiBhbiBhZGRyZXNz IGluIHRoZSBpbnRlcnJ1cHQNCj4gIHJhbmdlIHdpbGwgYmUgYmxvY2tlZCB3aXRoIGNvbmRpdGlv biBjb2RlIExHTi40IG9yIFNHTi44Lg0KPiAgVHJhbnNsYXRlZCByZXF1ZXN0cyB3aXRoIGFuIGFk ZHJlc3MgaW4gdGhlIGludGVycnVwdCBhZGRyZXNzDQo+ICByYW5nZSBhcmUgdHJlYXRlZCBhcyBV bnN1cHBvcnRlZCBSZXF1ZXN0IChVUikuIg0KPiANCj4gcmlnaHQgaW4gdGhhdCBfd2l0aF8gUEFT SUQgdHJhbnNsYXRpb24gZW50cmllcyBmb3IgdGhpcyByYW5nZSB3b3VsZA0KPiBzdGlsbCBiZSB1 c2VkLCBzbyBsb25nIGFzIHRoZXkgdHJhbnNsYXRlIHRvIGFuIGFyZWEgb3V0c2lkZSBvZiB0aGUN Cj4gRkVFeHh4eHggcmFuZ2U/IElmIHNvIHRoaXMgd291bGQgbWVhbiB0aGF0IHdpdGggUEFTSUQg KHdoZW5ldmVyIHdlDQoNCnllcw0KDQo+IGdldCB0byBlbmFibGluZyB0aGlzIG1vZGUgb2Ygb3Bl cmF0aW9uKSB3ZSdkIG5lZWQgdG8gYXZvaWQgc2hhcmluZw0KPiBwYWdlIHRhYmxlcywgYW5kIHdl J2QgbmVlZCB0byBzdXBwcmVzcyBtaXJyb3Jpbmcgb2YgRVBUIGluc2VydGlvbnMNCj4gZm9yIHRo aXMgcmFuZ2UgaW4gdGhlIElPTU1VIHBhZ2UgdGFibGVzLiAoQWxsIG9mIHRoaXMgaW5kZXBlbmRl bnQNCj4gb2YgdGhlIHBhcnRpY3VsYXIgY2hvaWNlIG9mIHRoZSBBUElDIGFjY2VzcyBwYWdlLikN Cj4gDQoNCk9yIHlvdSBjYW4gc3RpbGwgc2hhcmUgcGFnZSB0YWJsZXMgYXMgbG9uZyBhcyBubyBE TUEgd2lsbCB0YXJnZXQgYXQNCnRoaXMgcmFuZ2UgKHdoaWNoIHNob3VsZCBiZSB0aGUgbm9ybWFs IGNhc2UgYW5kIGFueSBpbmFkdmVydGVudA0Kb3IgbWFsaWNpb3VzIGF0dGVtcHQgaXMgYmxvY2tl ZCBhbnl3YXkpLg0KDQoNClRoYW5rcw0KS2V2aW4NCg== From xen-devel-bounces@lists.xenproject.org Thu Mar 04 07:56:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 07:56:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93039.175580 (Exim 4.92) (envelope-from ) id 1lHiq4-0005Vo-EQ; Thu, 04 Mar 2021 07:56:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93039.175580; Thu, 04 Mar 2021 07:56:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHiq4-0005Vh-BE; Thu, 04 Mar 2021 07:56:04 +0000 Received: by outflank-mailman (input) for mailman id 93039; Thu, 04 Mar 2021 07:56:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHiq3-0005VZ-Cr; Thu, 04 Mar 2021 07:56:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHiq3-0005ik-6N; Thu, 04 Mar 2021 07:56:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHiq2-0002Lu-VD; Thu, 04 Mar 2021 07:56:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHiq2-0004fK-Um; Thu, 04 Mar 2021 07:56:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PqGQ2o6uQceRrA7Tya8hsRcIcj0T+S8iVKPYNg+U4Ac=; b=HY6JSsxKDGmdycZVH7r2blHSB9 6CJvK8DnMpFC8ELQHklC3KMM3Qp7aNP+UWMS5q/ACRJYxcMFfH9O6IOykmhs2uqrHWI67DnjXA5kY D/iTsnctmlWVz2j6YNtQxI5G0nx6SbvHz4hJnE8i4taDxK7EM+za9zg8eM96o2qKel0k=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 159824: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=ee3dc2c2c8e5b2d3976e43dde95bc0aeeafbef4f X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 04 Mar 2021 07:56:02 +0000 flight 159824 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/159824/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt ee3dc2c2c8e5b2d3976e43dde95bc0aeeafbef4f baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 237 days Failing since 151818 2020-07-11 04:18:52 Z 236 days 229 attempts Testing same since 159812 2021-03-03 04:19:54 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 45265 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 04 08:06:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 08:06:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93051.175594 (Exim 4.92) (envelope-from ) id 1lHj00-0007An-QD; Thu, 04 Mar 2021 08:06:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93051.175594; Thu, 04 Mar 2021 08:06:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHj00-0007Ag-NE; Thu, 04 Mar 2021 08:06:20 +0000 Received: by outflank-mailman (input) for mailman id 93051; Thu, 04 Mar 2021 08:06:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHizz-0007AL-7c for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 08:06:19 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6e9b019f-05ba-47bb-a47d-82270b3aad3e; Thu, 04 Mar 2021 08:06:16 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 07AD8AAC5; Thu, 4 Mar 2021 08:06:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e9b019f-05ba-47bb-a47d-82270b3aad3e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614845175; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=krSJvY97LjFT9owHpe9435Nt8idspbtsA3qQyzbp5Jc=; b=uluZiPgXX8Y34Au83jf/DYtpIDFep/CbR6Njk207MwexDd1MODlWIp4RfCmyssxLvGBMXH GzSSLr70VbJdp74PvOBm+8m79QuBngwA1NP6/1GF7T7QptlgC4s0cDURO1ztwDhTx+X66c w7vRyzw2WubaqFhh5ZCnz8eQ7kui8e0= Subject: Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11 To: Julien Grall , Charles Arnold Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <05fe3295-7993-2eb5-37bc-a6d04fde1fbc@suse.com> <7e0584ab-8923-cb59-fac2-c2908d736f0c@xen.org> From: Jan Beulich Message-ID: <1e625665-7a14-a1f6-5b93-cac6e3640c1f@suse.com> Date: Thu, 4 Mar 2021 09:06:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <7e0584ab-8923-cb59-fac2-c2908d736f0c@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03.03.2021 20:09, Julien Grall wrote: > On 01/03/2021 07:57, Jan Beulich wrote: >> The upcoming release complains, not entirely unreasonably: >> >> In file included from rijndael.c:33: >> .../xen/include/crypto/rijndael.h:55:53: note: previously declared as 'const unsigned char[]' >> 55 | void rijndaelEncrypt(const unsigned int [], int, const unsigned char [], >> | ^~~~~~~~~~~~~~~~~~~~~~ >> rijndael.c:865:8: error: argument 4 of type 'u8[16]' {aka 'unsigned char[16]'} with mismatched bound [-Werror=array-parameter=] >> 865 | u8 ct[16]) >> | ~~~^~~~~~ >> In file included from rijndael.c:33: >> .../xen/include/crypto/rijndael.h:56:13: note: previously declared as 'unsigned char[]' >> 56 | unsigned char []); >> | ^~~~~~~~~~~~~~~~ >> >> While it's not really clear to me why it would complain only for arg 4, >> the adjustment to make is obvious and riskfree also for arg 3: Simply >> declare the correct array dimension right away. This then allows >> compilers to apply checking at call sites, which seems desirable anyway. > > I am a bit confused, if GCC is not complaining for arg3, then what is > the following error message for: > > > In file included from rijndael.c:33: > > .../xen/include/crypto/rijndael.h:55:53: note: previously declared as > 'const unsigned char[]' > > 55 | void rijndaelEncrypt(const unsigned int [], int, const > unsigned char [], > > | > ^~~~~~~~~~~~~~~~~~~~~~ Hmm, good point. I didn't observe this myself, and simply copied the part of the error message that I was handed. I suppose there was an "error: argument 3 of type ..." there then as well. Charles - any chance you could confirm this, and perhaps even quote the full set of error messages in our internal patch? I'll adjust the wording of the description in any event. >> There are quite a few more issues with gcc11, but from my brief initial >> inspection I'm suspecting (hoping) it'll rather be the compiler which >> will get further changed by the time their release gets finalized. Just >> one example: >> >> .../xen/include/xen/string.h:101:27: error: '__builtin_memcmp' specified bound 4 exceeds source size 0 [-Werror=stringop-overread] >> 101 | #define memcmp(s1, s2, n) __builtin_memcmp(s1, s2, n) >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> mpparse.c:722:13: note: in expansion of macro 'memcmp' >> 722 | if (memcmp(mpf->mpf_signature, "_MP_", 4) == 0 && >> | ^~~~~~ >> >> Clearly neither the 1st nor the 2nd argument have a "source size" of 0. > > It looks like there is a report on the redhat bug tracker for it [1]. Do > you know if there is a bug report on the GCC tracker as well? I have no idea, to be honest. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 04 08:34:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 08:34:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93052.175607 (Exim 4.92) (envelope-from ) id 1lHjRZ-0001dx-0f; Thu, 04 Mar 2021 08:34:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93052.175607; Thu, 04 Mar 2021 08:34:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHjRY-0001dq-TC; Thu, 04 Mar 2021 08:34:48 +0000 Received: by outflank-mailman (input) for mailman id 93052; Thu, 04 Mar 2021 08:34:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHjRX-0001dl-Kv for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 08:34:47 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5b8f25ac-40e6-4eb5-954f-cba9451488cf; Thu, 04 Mar 2021 08:34:46 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2285EAD87; Thu, 4 Mar 2021 08:34:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b8f25ac-40e6-4eb5-954f-cba9451488cf X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614846885; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h0MY4nLW/KZYUIkQoS7r900zeWrKxEpze568X7juTKQ=; b=uoE72CDeY4f0UX2mSekTNBKAC1/k2B1kK7/cbvsOzcQqslAPGl4p4BfY8VVGGEri8v0sJn 5QCirdBe6CUwwrZ3u8hoZ3xfh7vSb0AONqq2KXX7oz82h5KOQewt+nPk2WJJ5A3JBRntK6 5WvezQoodWGEx70+lFK4GpQNns0Enxk= Subject: Re: dom0less boot two compressed kernel images out-of-memory work-around To: Julien Grall Cc: Stefano Stabellini , Ian Jackson , Andrew Cooper , Charles Chiou , "xen-devel@lists.xenproject.org" References: <58aaf68f-4499-9400-6eb2-f1ad3b620c73@xen.org> From: Jan Beulich Message-ID: <511603c8-40b4-5e22-7eba-7722d89895fe@suse.com> Date: Thu, 4 Mar 2021 09:34:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <58aaf68f-4499-9400-6eb2-f1ad3b620c73@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03.03.2021 20:36, Julien Grall wrote: > (BCCing xen-users, CCing xen-devel + a few folks) > > Hi, > > Moving the discussion to xen-devel. > > On 22/02/2021 05:02, Charles Chiou wrote: >> When trying to boot two zImage using dom0less boot on ARM, we encountered this problem when xen runs gunzip on second guest: >> >> (XEN) **************************************** >> (XEN) Panic on CPU 0: >> (XEN) Out of memory >> (XEN) **************************************** >> >> And worked around it with the following patch. We'd like to check to see if this is a known issue and if the work-around looks reasonable. Thank you > > I haven't seen any similar report in the past. > >> >> >> diff --git a/xen/common/gunzip.c b/xen/common/gunzip.c >> index db4efcd34b..e5bd19ba7f 100644 >> --- a/xen/common/gunzip.c >> +++ b/xen/common/gunzip.c >> @@ -113,8 +113,10 @@ __init int perform_gunzip(char *output, char *image, unsigned long image_len) >> >> window = (unsigned char *)output; >> >> + if (!free_mem_ptr) { >> free_mem_ptr = (unsigned long)alloc_xenheap_pages(HEAPORDER, 0); >> free_mem_end_ptr = free_mem_ptr + (PAGE_SIZE << HEAPORDER); >> + } >> >> inbuf = (unsigned char *)image; >> insize = image_len; >> @@ -131,7 +133,12 @@ __init int perform_gunzip(char *output, char *image, unsigned long image_len) >> rc = 0; >> } >> >> + if (free_mem_ptr) { >> free_xenheap_pages((void *)free_mem_ptr, HEAPORDER); >> + free_mem_ptr = 0; >> + } >> + >> + bytes_out = 0; >> >> return rc; >> } >> diff --git a/xen/common/inflate.c b/xen/common/inflate.c >> index f99c985d61..de96002188 100644 >> --- a/xen/common/inflate.c >> +++ b/xen/common/inflate.c >> @@ -244,7 +244,7 @@ static void *INIT malloc(int size) >> >> if (size < 0) >> error("Malloc error"); >> - if (!malloc_ptr) >> + if ((!malloc_ptr) || (!malloc_count)) >> malloc_ptr = free_mem_ptr; >> > > IMHO, this is a bit risky to assume that malloc_count will always be 0 > after each gunzip. > > Instead I think, it would be better if we re-initialize the allocator > every time. I agree. > How about the following (untested): > > commit e1cd2d85234c8d0aa62ad32c824a5568a57be930 (HEAD -> dev) > Author: Julien Grall > Date: Wed Mar 3 19:27:56 2021 +0000 > > xen/gunzip: Allow perform_gunzip() to be called multiple times > > Currently perform_gunzip() can only be called once because the the > internal allocator is not fully re-initialized. > > This works fine if you are only booting dom0. But this will break when > booting multiple using the dom0less that uses compressed kernel images. > > This can be resolved by re-initializing malloc_ptr and malloc_count > every time perform_gunzip() is called. > > Note the latter is only re-initialized for hardening purpose as > there is > no guarantee that every malloc() are followed by free() (It should in > theory!). > > Take the opportunity to check the return of alloc_heap_pages() to > return > an error rather than dereferencing a NULL pointer later on failure. > > Reported-by: Charles Chiou > Signed-off-by: Julien Grall > > --- > > This patch is candidate for Xen 4.15. Without this patch, it will > not be > possible to boot multiple domain using dom0less when they are using > compressed kernel images. Other decompression methods are unaffected? > --- a/xen/common/gunzip.c > +++ b/xen/common/gunzip.c > @@ -114,7 +114,11 @@ __init int perform_gunzip(char *output, char > *image, unsigned long image_len) > window = (unsigned char *)output; > > free_mem_ptr = (unsigned long)alloc_xenheap_pages(HEAPORDER, 0); > + if ( !free_mem_ptr ) > + return -ENOMEM; > + > free_mem_end_ptr = free_mem_ptr + (PAGE_SIZE << HEAPORDER); > + init_allocator(); > > inbuf = (unsigned char *)image; > insize = image_len; > diff --git a/xen/common/inflate.c b/xen/common/inflate.c > index f99c985d6135..d8c28a3e9593 100644 > --- a/xen/common/inflate.c > +++ b/xen/common/inflate.c > @@ -238,6 +238,12 @@ STATIC const ush mask_bits[] = { > static unsigned long INITDATA malloc_ptr; > static int INITDATA malloc_count; > > +static void init_allocator(void) Please add INIT here. (I wouldn't mind if you used __init instead, as there's going to be file-wide replacement after 4.15 anyway, but of course this would render things inconsistent until then.) Jan > +{ > + malloc_ptr = free_mem_ptr; > + malloc_count = 0; > +} > + > static void *INIT malloc(int size) > { > void *p; > > Best regards, > From xen-devel-bounces@lists.xenproject.org Thu Mar 04 08:47:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 08:47:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93060.175642 (Exim 4.92) (envelope-from ) id 1lHjdb-0002qs-Cw; Thu, 04 Mar 2021 08:47:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93060.175642; Thu, 04 Mar 2021 08:47:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHjdb-0002ql-9d; Thu, 04 Mar 2021 08:47:15 +0000 Received: by outflank-mailman (input) for mailman id 93060; Thu, 04 Mar 2021 08:47:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHjda-0002qd-3U; Thu, 04 Mar 2021 08:47:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHjda-00077b-10; Thu, 04 Mar 2021 08:47:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHjdZ-0005kO-K0; Thu, 04 Mar 2021 08:47:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHjdZ-00052r-JW; Thu, 04 Mar 2021 08:47:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ndSsIeVMBWdsaanI2t9ONM/Cr0YmYFGLoXeGVIzqUGs=; b=QghZnIGlRZ7GC/zPxgHvB+5Bsq FVciU7TVjxnrLsxshg4ob2whIvQr9yGuUcq52z+Z1ZVpWeXUTZ98eGfbwags685R8WGNaBxL+IUSU SiMVny8/cQ1ivaqDYYZiQH+osrKown1zea8AY4Yoh4b1AdyDo8lDiMNAWQ2xaNdYX+Z4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159820: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=243036df0d55673de59c214e240b9b914d278b65 X-Osstest-Versions-That: xen=4834936549f788378918da8e9bc97df7dd3ee16d From: osstest service owner Date: Thu, 04 Mar 2021 08:47:13 +0000 flight 159820 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/159820/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 159814 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159814 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159814 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159814 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159814 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159814 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159814 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159814 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159814 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159814 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159814 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159814 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 243036df0d55673de59c214e240b9b914d278b65 baseline version: xen 4834936549f788378918da8e9bc97df7dd3ee16d Last test of basis 159814 2021-03-03 08:51:49 Z 0 days Testing same since 159820 2021-03-03 22:07:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kurth Norbert Manthey jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4834936549..243036df0d 243036df0d55673de59c214e240b9b914d278b65 -> master From xen-devel-bounces@lists.xenproject.org Thu Mar 04 08:48:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 08:48:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93066.175657 (Exim 4.92) (envelope-from ) id 1lHjep-0002z4-RV; Thu, 04 Mar 2021 08:48:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93066.175657; Thu, 04 Mar 2021 08:48:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHjep-0002yx-Ob; Thu, 04 Mar 2021 08:48:31 +0000 Received: by outflank-mailman (input) for mailman id 93066; Thu, 04 Mar 2021 08:48:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHjeo-0002yq-8q for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 08:48:30 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 99a92e54-bc47-408f-bb67-230ec33923b8; Thu, 04 Mar 2021 08:48:26 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 43F78ABE4; Thu, 4 Mar 2021 08:48:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99a92e54-bc47-408f-bb67-230ec33923b8 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614847705; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q5CVSiSPtQOZFjLb8netFK9yShe88dLqRGOS/dUHIGo=; b=K4EHi8GFmgN/4tETTmCFgfSDmn7jMOpDI4yeGJw5OozUbI58EIdOSvdmJlivwCeJs1BDkr mrdEfKfS0TG3wtZ6e9LYPlkjvTTl/MN+TXeZ4LIH7hjLseH5jdNTeWAsaFxtObPEMyU24V KtcAIAmbg1VGA0j9yzzzaQP6c5500wY= Subject: Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper Cc: Wei Liu , Anthony PERARD , Jun Nakajima , Kevin Tian , Boris Ostrovsky , xen-devel@lists.xenproject.org, Ian Jackson References: <20210301162357.76527-1-roger.pau@citrix.com> <62be2084-e5fa-e439-8426-6d129a10c379@suse.com> From: Jan Beulich Message-ID: Date: Thu, 4 Mar 2021 09:48:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 03.03.2021 16:38, Roger Pau Monné wrote: > On Tue, Mar 02, 2021 at 04:18:59PM +0100, Jan Beulich wrote: >> On 02.03.2021 16:00, Roger Pau Monné wrote: >>> On Tue, Mar 02, 2021 at 12:16:12PM +0100, Jan Beulich wrote: >>>> On 01.03.2021 17:23, Roger Pau Monne wrote: >>>>> RFC because there's still some debate as to how we should solve the >>>>> MSR issue, this is one possible way, but IMO we need to make a >>>>> decision soon-ish because of the release timeline. >>>> >>>> Generally I think it would be far better from a user pov if >>>> things worked out of the box, at least in cases where it can be >>>> made work. Arguably for Solaris this isn't going to be possible >>>> (leaving aside the non-option of fully returning back to original >>>> behavior), but for the old-Linux-PV case I still think my proposed >>>> change is better in this regard. I realize Andrew said (on irc) >>>> that this is making the behavior even weaker. I take a different >>>> perspective: Considering a guest will install exception handlers >>>> at some point, I continue to fail to see what good it will do to >>>> try to inject a #GP(0) when we know the guest will die because of >>>> not having a handler registered just yet. It is a kernel flaw, >>>> yes, but they ended up living with it merely because of our odd >>>> prior behavior, so we can't put all the blame on them. >>> >>> My concern with this would mostly be with newer guests, in the sense >>> that people could come to rely on this behavior of not injecting a >>> #GP if the handler is not setup, which I think we should try to avoid. >>> >>> One option would be to introduce a feature that could be used in the >>> elfnotes to signal that the kernel doesn't require such workarounds >>> for MSR #GP handling, maybe: >>> >>> /* >>> * Signal that the kernel doesn't require suppressing the #GP on >>> * unknown MSR accesses if the handler is not setup. New kernels >>> * should always have this set. >>> */ >>> #define XENFEAT_msr_early_gp 16 >>> >>> We could try to backport this on the Linux kernel as far as we can >>> that we know it's safe to do so. >> >> I too did consider something like this. While I'm not opposed, it >> effectively requires well-behaved consumers who haven't been well- >> behaved in the past. >> >>> If this is not acceptable then I guess your solution is fine. Arguably >>> PV has it's own (weird) architecture, in which it might be safe to say >>> that no #GP will be injected as a result of a MSR access unless the >>> handler is setup. Ideally we should document this behaviour somewhere. >>> >>> Maybe we could add a rdmsr_safe to your path akin to what's done >>> here? >> >> Probably. Would need trying out on the affected older version, >> just like ... >> >>>>> --- a/docs/man/xl.cfg.5.pod.in >>>>> +++ b/docs/man/xl.cfg.5.pod.in >>>>> @@ -2861,6 +2861,17 @@ No MCA capabilities in above list are enabled. >>>>> >>>>> =back >>>>> >>>>> +=item B >>>>> + >>>>> +Select whether to use the legacy behaviour for accesses to MSRs not explicitly >>>>> +handled by Xen instead of injecting a #GP to the guest. Such legacy access >>>>> +mode will force Xen to replicate the behaviour from the hardware it's currently >>>>> +running on in order to decide whether a #GP is injected to the guest. Note >>>>> +that the guest is never allowed access to unhandled MSRs, this option only >>>>> +changes whether a #GP might be injected or not. >>>> >>>> This description is appropriate for reads, but not for writes: >>>> Whether a write would fault can only be known by trying a write, >>>> yet for safety reasons we can't risk doing more than a read. An >>>> option might be to make writes fault is the to be written value >>>> differs from that which the probing read has returned (i.e. the >>>> same condition which originally had caused a log message to appear >>>> in 4.14 for PV guests). >>> >>> Read values for unhandled MSRs will always be 0 with the proposed >>> code, so we would inject a #GP to the guest for any write attempt to >>> unhandled MSRs with a value different than 0. >>> >>> Maybe we should just inject a #GP to the guest for any attempts to >>> write to unhandled MSRs? >> >> ... doing this would need to. Iirc I did add the write side of the >> handling in my patch just for symmetry. I'd prefer handling to be >> symmetric, but I can see why we may not want it to be so. > > Kind of in the wrong context, but I will reply here because it's the > last message related to the MSR stuff. > > Jan: would you be fine with modifying your path to not change the > behaviour for writes (ie: always inject #GP to the guest for unhandled > accesses), and then add a rdmsr_safe to the read path in order to > decide whether to inject a #GP to the guest even if the #GP handler is > not setup? I don't mind as long as it ends up making things work (I have no reason to believe it won't). I'll give that a try. > I can modify the option introduced on this patch to always inject #GP > on unhandled writes and only inject #GP on reads if the physical MSR > access on the hardware also triggers a #GP. HVM guests with broken > behavior will require having the option enabled in order to work, > but I think that's likely OK as long term we expect all HVM guests to > be well behaved. > > My main worry with this approach is that we end up requiring half of > the common HVM guests OSes to have the 'legacy MSR handling' option > enabled in order to work. I think it's unlikely for this to happen, as > we are only aware of Solaris requiring it at the moment. > > It also raises the question whether we will allow any more exceptions > to the MSR policy, like we did for Windows and OpenBSD in: > > http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=ca88a43e660c75796656a544e54a648c60d26ef0 > http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=4175fd3ccd17face664036fa98e9329aa317f7b6 > > Or if we are just going to require those guests to enable the legacy > MSR handling instead. It is my understanding that Andrew's view is that adding such special cases is the only acceptable thing. As voiced before I don't share this view, as it means we're going to be entirely reactive to people reporting issues, when I think we should be pro-active as far as is reasonable. Independent of any pro-active measures there'll still be enough reasons for reactive changes - for example I assume Linux would now issue the log message from if (cpu_has(c, X86_FEATURE_CONSTANT_TSC)) { if (c->x86 > 0x10 || (c->x86 == 0x10 && c->x86_model >= 0x2)) { u64 val; rdmsrl(MSR_K7_HWCR, val); if (!(val & BIT(24))) pr_warn(FW_BUG "TSC doesn't count with P0 frequency!\n"); } } since we surface a zero value right now (but I didn't verify this in practice yet). Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 04 09:01:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 09:01:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93071.175670 (Exim 4.92) (envelope-from ) id 1lHjqu-0004uW-Vk; Thu, 04 Mar 2021 09:01:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93071.175670; Thu, 04 Mar 2021 09:01:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHjqu-0004uP-SY; Thu, 04 Mar 2021 09:01:00 +0000 Received: by outflank-mailman (input) for mailman id 93071; Thu, 04 Mar 2021 09:00:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHjqt-0004uK-0o for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 09:00:59 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c22dbca4-8ebf-4407-a251-a4980932c483; Thu, 04 Mar 2021 09:00:53 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C6157AB8C; Thu, 4 Mar 2021 09:00:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c22dbca4-8ebf-4407-a251-a4980932c483 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614848453; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2C8AyqE1WF7pAZ9d6V+W4Zot3vDpwYZNi8Xt5jOq3+0=; b=gYDdjk7ErNrl+p5CWxnYefQO0jUP8hDpRQuR6JOn84OR5wO58HfOGh0/f0WsNqR9IUc11R oMVZ6Q3zJZTWD8bzY/UgK47FZZrGDSnyJuTIB1PW5Z1BJudvTTiDez3bYxOySBhAgeylHY cOgzyI7Hk1hVBMphqEqYP1c3LPpN/1E= Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction To: Julien Grall , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , Bjoern Doebel References: <20210303170526.15903-1-julien@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <9f81d0c8-1ec8-7cd0-d943-fd31bc86de13@suse.com> Date: Thu, 4 Mar 2021 10:00:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210303170526.15903-1-julien@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5zCISIgWIZALxrk492rh0kxYoGBcIcE0A" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5zCISIgWIZALxrk492rh0kxYoGBcIcE0A Content-Type: multipart/mixed; boundary="9qgGOivyYseSvuW6H8ba4XCIUSNaWiopF"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , Bjoern Doebel Message-ID: <9f81d0c8-1ec8-7cd0-d943-fd31bc86de13@suse.com> Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction References: <20210303170526.15903-1-julien@xen.org> In-Reply-To: <20210303170526.15903-1-julien@xen.org> --9qgGOivyYseSvuW6H8ba4XCIUSNaWiopF Content-Type: multipart/mixed; boundary="------------6B26A7C4A42E59EEBD9A7C80" Content-Language: en-US This is a multi-part message in MIME format. --------------6B26A7C4A42E59EEBD9A7C80 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 03.03.21 18:05, Julien Grall wrote: > From: Julien Grall >=20 > As XenStored is single-threaded, conn->ta_start_time will always be > smaller than now. As we substract the latter from the former, it means > a transaction will never be considered long running. >=20 > Invert the two operands of the substraction in both lu_reject_reason() > and lu_check_allowed(). In addition to that, the former also needs to > check that conn->ta_start_time is not 0 (i.e the transaction is not > active). >=20 > Take the opportunity to document the return condition of > lu_check_allowed(). >=20 > Fixes: e04e53a5be20 ("tools/xenstore: allow live update only with no tr= ansaction active") > Reported-by: Bjoern Doebel > Signed-off-by: Julien Grall Reviewed-by: Juergen Gross >=20 > --- >=20 > I am a bit puzzled on how -F is implemented. From my understanding we > will force LiveUpdate when one of the following conditions is met: > 1) All the active transactions are long running > 2) If we didn't manage to LiveUpdate after N sec >=20 > It is not quite clear why we need the both as 2) would indirectly cover= > 1). However 2) is probably unsafe as we may reset transactions for > "well-behaving" guest. >=20 > So I am thinking to send a patch to drop 2). Any opinions? This will enable two guests working together to block LU by using overlapping transactions: Guest 1: ----- ----- ----- ... Guest 2: -- ----- ----- --- ... There is always a transaction active, but none is regarded to be long running. Juergen --------------6B26A7C4A42E59EEBD9A7C80 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------6B26A7C4A42E59EEBD9A7C80-- --9qgGOivyYseSvuW6H8ba4XCIUSNaWiopF-- --5zCISIgWIZALxrk492rh0kxYoGBcIcE0A Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBAocMFAwAAAAAACgkQsN6d1ii/Ey+K cAf+LV/v6h9RJNqcaVKuHCxBkZXR3LMPKpFiX3k4YGm05T3Id9svuFnZi9RhZxAeHiMYyVbUhJJw weNMpqeq6o7yC5d0xXFG3eXiUqELjruPELDODwEaoVERXOXRkJpopXdYxNw319k0jcQMcNv7rFW0 lYyvhXiBkTaQuQw5lznpZv3Dg/yDuH/JIXqI48nxL2vjVWUYz7KXcrp/XjDWEvuYBvwROtFfCbOs ljwgxxHlkF7QFqKquQQlsnzMfiqQc2TdhZiCtLbSH2YhnyFadLFF5hiX8PUBBPcmOASzk0K8hUm9 Th1yXoEr+a5gkRBc24PYzM3OBkFs2tTufzEMHYJHrA== =xH1P -----END PGP SIGNATURE----- --5zCISIgWIZALxrk492rh0kxYoGBcIcE0A-- From xen-devel-bounces@lists.xenproject.org Thu Mar 04 09:39:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 09:39:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93074.175681 (Exim 4.92) (envelope-from ) id 1lHkSB-00085K-Ug; Thu, 04 Mar 2021 09:39:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93074.175681; Thu, 04 Mar 2021 09:39:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHkSB-00085D-Rn; Thu, 04 Mar 2021 09:39:31 +0000 Received: by outflank-mailman (input) for mailman id 93074; Thu, 04 Mar 2021 09:39:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHkSA-000858-Ga for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 09:39:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHkS9-0007xl-2Z; Thu, 04 Mar 2021 09:39:29 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lHkS8-0004Xo-Mm; Thu, 04 Mar 2021 09:39:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=1C5pfvFivTPIGOBAnmXMsiW8PgkMElblzFfAjvNacds=; b=KYZg/ZIncLC54i+Hr3h4ytTYEj St+69h+VGYeUrCeRYFAzz4uvSetqjN55e0zzTSOs/MEtINXQQxj5awBQYmFMtbnkrCWhR5z4Kpmou VW2ulMKpIvMavHNnePL2XO+wIMvtb5ib3kXN7qvZsH+u2FoUTqSWvSiSiAcJPp6FXIy0=; Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , Bjoern Doebel References: <20210303170526.15903-1-julien@xen.org> <9f81d0c8-1ec8-7cd0-d943-fd31bc86de13@suse.com> From: Julien Grall Message-ID: <6c2f8459-b109-9a16-79c1-ab92969c4ece@xen.org> Date: Thu, 4 Mar 2021 09:39:26 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <9f81d0c8-1ec8-7cd0-d943-fd31bc86de13@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 04/03/2021 09:00, Jürgen Groß wrote: > On 03.03.21 18:05, Julien Grall wrote: >> From: Julien Grall >> >> As XenStored is single-threaded, conn->ta_start_time will always be >> smaller than now. As we substract the latter from the former, it means >> a transaction will never be considered long running. >> >> Invert the two operands of the substraction in both lu_reject_reason() >> and lu_check_allowed(). In addition to that, the former also needs to >> check that conn->ta_start_time is not 0 (i.e the transaction is not >> active). >> >> Take the opportunity to document the return condition of >> lu_check_allowed(). >> >> Fixes: e04e53a5be20 ("tools/xenstore: allow live update only with no >> transaction active") >> Reported-by: Bjoern Doebel >> Signed-off-by: Julien Grall > > Reviewed-by: Juergen Gross > >> >> --- >> >> I am a bit puzzled on how -F is implemented. From my understanding we >> will force LiveUpdate when one of the following conditions is met: >>    1) All the active transactions are long running >>    2) If we didn't manage to LiveUpdate after N sec >> >> It is not quite clear why we need the both as 2) would indirectly cover >> 1). However 2) is probably unsafe as we may reset transactions for >> "well-behaving" guest. >> >> So I am thinking to send a patch to drop 2). Any opinions? > > This will enable two guests working together to block LU by using > overlapping transactions: > > Guest 1: ----- ----- -----  ... > Guest 2: -- ----- ----- --- ... > > There is always a transaction active, but none is regarded to be > long running. Right, how do you know whether two guests are working together? I understand that "-F" means that things could break... However, I am not entirely sure who can realistically use this option without risking breaking other guests. For instance, there might be a 3rd guest that has an active transaction and not cooperating with the first two. Rather than forcing in this case, how about we quiesce the connection if it starts a transaction when LiveUpdate is pending? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 04 09:48:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 09:48:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93077.175694 (Exim 4.92) (envelope-from ) id 1lHkaS-0000Yf-Qk; Thu, 04 Mar 2021 09:48:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93077.175694; Thu, 04 Mar 2021 09:48:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHkaS-0000YY-NI; Thu, 04 Mar 2021 09:48:04 +0000 Received: by outflank-mailman (input) for mailman id 93077; Thu, 04 Mar 2021 09:48:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHkaR-0000YT-H7 for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 09:48:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 09273a78-555a-4923-a1f1-a682da1f2acc; Thu, 04 Mar 2021 09:48:02 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1A19CAEAC; Thu, 4 Mar 2021 09:48:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09273a78-555a-4923-a1f1-a682da1f2acc X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614851281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hNCliMiWjuNKLe9+7OmYrOs8H3BaU4HXm8Cy/g03jRU=; b=jlZ2vZzNQux1EsaezpTcAcZTem7LhovRaMRS+mbFaKgo2MVcbuS4wMCOpXuNyXYD11Gw16 On7hTlwcHJ+Gu2bqhwUG6hubOI/vxExO5zq/gnlToky9g5benHXZxq5u3jaOJFkEszbrke 1JyxGrtX0gTkKDWPPoCtJmVguNUMY7c= To: Julien Grall , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , Bjoern Doebel References: <20210303170526.15903-1-julien@xen.org> <9f81d0c8-1ec8-7cd0-d943-fd31bc86de13@suse.com> <6c2f8459-b109-9a16-79c1-ab92969c4ece@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction Message-ID: <78a79740-925e-559c-f5ff-b365cc1c2732@suse.com> Date: Thu, 4 Mar 2021 10:48:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <6c2f8459-b109-9a16-79c1-ab92969c4ece@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4FJtJm7VioPd3KrKlZYUOoK1hlasfX5jH" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4FJtJm7VioPd3KrKlZYUOoK1hlasfX5jH Content-Type: multipart/mixed; boundary="UOnplTyCZImNu9TEhUGHVUFLN6LLbxJVb"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , Bjoern Doebel Message-ID: <78a79740-925e-559c-f5ff-b365cc1c2732@suse.com> Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction References: <20210303170526.15903-1-julien@xen.org> <9f81d0c8-1ec8-7cd0-d943-fd31bc86de13@suse.com> <6c2f8459-b109-9a16-79c1-ab92969c4ece@xen.org> In-Reply-To: <6c2f8459-b109-9a16-79c1-ab92969c4ece@xen.org> --UOnplTyCZImNu9TEhUGHVUFLN6LLbxJVb Content-Type: multipart/mixed; boundary="------------308BB69F3F64F76DD9E12309" Content-Language: en-US This is a multi-part message in MIME format. --------------308BB69F3F64F76DD9E12309 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 04.03.21 10:39, Julien Grall wrote: >=20 >=20 > On 04/03/2021 09:00, J=C3=BCrgen Gro=C3=9F wrote: >> On 03.03.21 18:05, Julien Grall wrote: >>> From: Julien Grall >>> >>> As XenStored is single-threaded, conn->ta_start_time will always be >>> smaller than now. As we substract the latter from the former, it mean= s >>> a transaction will never be considered long running. >>> >>> Invert the two operands of the substraction in both lu_reject_reason(= ) >>> and lu_check_allowed(). In addition to that, the former also needs to= >>> check that conn->ta_start_time is not 0 (i.e the transaction is not >>> active). >>> >>> Take the opportunity to document the return condition of >>> lu_check_allowed(). >>> >>> Fixes: e04e53a5be20 ("tools/xenstore: allow live update only with no = >>> transaction active") >>> Reported-by: Bjoern Doebel >>> Signed-off-by: Julien Grall >> >> Reviewed-by: Juergen Gross >> >>> >>> --- >>> >>> I am a bit puzzled on how -F is implemented. From my understanding we= >>> will force LiveUpdate when one of the following conditions is met: >>> =C2=A0=C2=A0 1) All the active transactions are long running >>> =C2=A0=C2=A0 2) If we didn't manage to LiveUpdate after N sec >>> >>> It is not quite clear why we need the both as 2) would indirectly cov= er >>> 1). However 2) is probably unsafe as we may reset transactions for >>> "well-behaving" guest. >>> >>> So I am thinking to send a patch to drop 2). Any opinions? >> >> This will enable two guests working together to block LU by using >> overlapping transactions: >> >> Guest 1: ----- ----- -----=C2=A0 ... >> Guest 2: -- ----- ----- --- ... > >> There is always a transaction active, but none is regarded to be >> long running. >=20 > Right, how do you know whether two guests are working together? We can't know that. And this is the reason why you have to use the -F option to force a LU. > I understand that "-F" means that things could break... However, I am=20 > not entirely sure who can realistically use this option without risking= =20 > breaking other guests. For instance, there might be a 3rd guest that ha= s=20 > an active transaction and not cooperating with the first two. Yes. OTOH the chances are rather low that multiple LU attempts are failing due to transactions being active all the time. > Rather than forcing in this case, how about we quiesce the connection i= f=20 > it starts a transaction when LiveUpdate is pending? Yes, this should work, too. Juergen --------------308BB69F3F64F76DD9E12309 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------308BB69F3F64F76DD9E12309-- --UOnplTyCZImNu9TEhUGHVUFLN6LLbxJVb-- --4FJtJm7VioPd3KrKlZYUOoK1hlasfX5jH Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBArNAFAwAAAAAACgkQsN6d1ii/Ey+j 3Af/UXMe6UpNATWuh0q02Cek7CUUtyc6h13JPdWQnrYAdhELLFXYQ0XgLsik72EPIrsahrfsfxtY uF3beMBXuEE0bynxDY8fv5n7JyL4yMAyPdJ+ZZWXsc18HAqaO2JI4za6YqqhLogRQWc6FPcFGkDW /yVxYsExwTxutViEbsQgRU0FbtMqEjdKQ8qTm1WzzilE+hmp+hCrAyKpZqzHJDoIFz7Abe+sxgKy opxK70CF9ISVs/tHbUCkZUaCIXbbJGeEakEcmUoZCaVLLtkZQaptkky7o85ZPMI68VBa+siA+INn toERcl5ehCZGyYdg7AaR6/VrIkU5MFib0EU6aZgBqA== =GABA -----END PGP SIGNATURE----- --4FJtJm7VioPd3KrKlZYUOoK1hlasfX5jH-- From xen-devel-bounces@lists.xenproject.org Thu Mar 04 10:06:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 10:06:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93082.175706 (Exim 4.92) (envelope-from ) id 1lHkrx-0002dF-Gp; Thu, 04 Mar 2021 10:06:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93082.175706; Thu, 04 Mar 2021 10:06:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHkrx-0002d8-Dc; Thu, 04 Mar 2021 10:06:09 +0000 Received: by outflank-mailman (input) for mailman id 93082; Thu, 04 Mar 2021 10:06:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHkrv-0002d3-8U for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 10:06:07 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 612a3535-eef4-4aeb-8cb0-7f4419e93864; Thu, 04 Mar 2021 10:06:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 612a3535-eef4-4aeb-8cb0-7f4419e93864 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614852366; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=h4en8N1TlkvCuQbtkvFwBfG0XeJRSLF8028ytPJkADQ=; b=Yp6W5hHfTtB1ZfL0UmwSx4oCDX0rPZ4ZYd6QE53VWyWNpBD9OTas4TzB wAqw+PwTpWJOLTnuTnhabdowYIfjZ9OleXeFAEgXb1ma7KqGhu6Ln72jN D3E+3Zu/DQF/9/IwRwGN8tI1h4/BAzaCDSDcSMpWMIxZO1znrEAs/kIx3 o=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: GGv6lxoxgfneJ55/vwWZpT08loLatW1spWwcI4PxfjWfo021kosvozYae5L4Gxa28IwIcUBs7M iK1PhCfyWgSzV6iuF0QTK7KAC3erF1uZpcPSzVi117khqdwj0XUkYZhOxCFyQBDhe9e6ZEFMx9 P5fJ9YR5ESj8fmKcewoUPkrW7FA8WYjKjHQGfiuykJjATKG0a2fFnmsIYvkQrXFpP3g0vSENdX xIOJoVewr7vJqDw4yYDQSrn+Eh/7beIYG0HSx92B3ZEQn2tkDMywzk4hI8DkQOm6SXBCoTBBvI sPA= X-SBRS: 5.2 X-MesageID: 38508494 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,222,1610427600"; d="scan'208";a="38508494" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DKcFrz+2w41voW3zxlX536tGiCTBM2mvjUCeLy8VCRZgA7zxw9G9GZiT/r/OAkx/pbbXSHIPkVGtaqzpr3RY947zAHjAGIP5XsqdQfqVzudmHR0XFFoPsmSpj7hoWTVzkffExXsORmrc6Wosx6ZhKSlXeyZZxmyq9c2B1ArlJikQtPw0I+vqjm+QHTAq/S61Sj9my9CQoZIvW9HxDJris5JNz6niEgHcCX7wqFTL8N6OtjTsmH4NFsCk+Wp9lOd6EexE2mh5H+m+gqVlAm/gQuVduCZD6AMbKlTS+M8Njl9mpHdvnNXAfpo78caQd0b2WcYveoo70GiV18AZ3a3qOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2fsWI6E6O7DgltfOR5/kTLyqGBQLV+JN0brcn3DTcow=; b=AP4ThztIM9RkEvHIgzfE3RC898SxyY4UQnK2QuegoFKNsf7zh/CPYa6qrRUGxifry5d+u2+omZRBZaZptEqq6lcBsoa79A2K1D378kHXWX/xBKnZ5ogIOuTfhGrVpKhtZtR34f5z1lfj/c9C3d+yZ0LKO5b5zv77joDIHAuBuy8U5E7hG1Kh5zom7jtVaR3jyP8LoSahAuU17lajrnSTR/cJZoYIgncQse1t23FMQkRMGvUBHG7to2ukHPkD2R5ZHlyTsGCBPqj4MUhCXJeutL3Turh1EBDeS5FU2xyPtA8H+519TNlc66fLgt92W14BJ1N1CYm38J0Cpjy7LE7YnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2fsWI6E6O7DgltfOR5/kTLyqGBQLV+JN0brcn3DTcow=; b=lwei6la2aKCmAWrSDNMFutsr5JvqsOF6b0mU6PFUhZsKj/aST8gELy6jzHy8lPFPJdzDNk2cWXpCP2lI71yImIZ7f/1MDbujun3FtIgeNpZPEbY7b/cqNvOXD0FmrHV4dFDQ12ObdQuFQMp49TeaT62EQUl9HE4v6RyfJPZUCdo= Date: Thu, 4 Mar 2021 11:05:44 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , Wei Liu , "Anthony PERARD" , Jun Nakajima , Kevin Tian , Boris Ostrovsky , , Ian Jackson Subject: Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection Message-ID: References: <20210301162357.76527-1-roger.pau@citrix.com> <62be2084-e5fa-e439-8426-6d129a10c379@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0392.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::20) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 07e57b7d-1e63-492e-e3ca-08d8def51673 X-MS-TrafficTypeDiagnostic: DM6PR03MB4603: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YquV0VxJjTDRddoj25BUaQuh3KmMzJG84MIZ6uhjrQzJKYdiD9GbWk+2KH0gHK0VvAPuCSfBsX+AqQW0QJrq9H4UuPoZUKHA24Y4MQX9Y+3VLsCkr3pW6n5fsumnIGZVTi6obBnVEyp3The7hnRtCSsHb/Qt6/I6nTlt9CWg46fr1OwDtsbz1Xy2xT6/kK3LhHGJUPHlZtLNaJeLjZd178BRjAM1UQDCXii1opwIxlUrWhwKM+a5J6fObTzS3XiKHHziqJrDHMTocXWEoHsOPee7ZEAXXbrI0B7UpDD7OmListQ1NIXxzTvGOKOFX626oOurjjy/c3MJ/EMysJitlIe5hCwk7J8H3he3x0scgNt1qIljKVE6ZOjAeyXJSPCltrtoC+AfAfy1+WlMH91x2prmjyPx6/p5KlphmQE9dr1w0dBaARrbhWP0sSv0glUORjaePrP9td9skzaSKj9DHpS5xh53UfaGt8TtPkAmPlcogNrtztbVbO4CYYZ4LuIyVW8vRs4aNIquhoGVNiiqdwHYUd334dBvVmsauvm83aO5IoJh925/PbBf55eeG/jS40ZKmDDyDPU7qLYMDIWFPfS8Ilocty1aXkHPopxcNpMVo+I475omC+YMKemwpqgtwAevNmTBttLpB9O6qSdQyQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(136003)(396003)(376002)(366004)(346002)(39860400002)(16526019)(6666004)(33716001)(316002)(8676002)(186003)(478600001)(6916009)(966005)(85182001)(956004)(26005)(54906003)(86362001)(2906002)(66556008)(6486002)(53546011)(6496006)(5660300002)(9686003)(83380400001)(8936002)(66946007)(66476007)(4326008)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MXRmTTc3UzRWRm05L0gxeHVxdEYvU1hLMGV4UHlTM0RZMEFydEQzZ3NxbFdr?= =?utf-8?B?UUs0c0tMcFAyZmhXRTRHalFtcGRoeHRRYW9zNGRTZ2JXYmlaL2VtYXZ2TnRt?= =?utf-8?B?R0FCamhXYTN1NndBMGV3dmNEYnVYMG1renpIU0p3d3ZBN2lVWEl2a0IrcmJj?= =?utf-8?B?TmlhWGJMV2c2a2JLWllCMHhaTkZNYWRlTVZNeDRzT0RzbHAwNW13SDFpbXc3?= =?utf-8?B?ZSt1bXdXek9DZDJnM0tuS2s4S3NQRStwUkg3djNpbFF4WTRSeVdybDUyTkJE?= =?utf-8?B?VzBNeHh4TFFVOElIYy9uTEQ5Zmh1T0hLMXRNa0JhMzdaTW9peUJ1MmdiZkxx?= =?utf-8?B?aTZObFZOQWN6eHRkRmZIZXNMQkdLQXc0U0JTbS9TL2MzZFVLSXdpR3loWTFD?= =?utf-8?B?UWg5Zk9ZOUVZWXk2TzJrMlV0dkZ6MHNaUjBGbnlUaC9jLytLS2V2NUZJczVi?= =?utf-8?B?amNYbkwrTE1Ed0x4OWFaY2I4Qzc1L0g2cEFtNFJFb1pVQm1VVm1VNmIzTEJJ?= =?utf-8?B?am9MVmhIdVFPOEpzSHVmRHVyQ3Jtby8weEd2TDJyWVp2NVNiSEV1WWR1ZVV1?= =?utf-8?B?QTlqVkpDSWNOTlFReEhtbW11QkRpR0lJcDZ4MksxZUVMWWJsVWcwdXlKYjQ3?= =?utf-8?B?UHZIalF3ejFBRGlRYW90VzhvT3NlOFR6V3dqZlNqbzZjQlFpYnVIRHV2bm5Y?= =?utf-8?B?R2kzOEp6OTNpQ0J2TUxTMytpUWJZZWdFazNxL0JyNDUvZ2xpTGdadXBPR0lI?= =?utf-8?B?WXN2V0hxNXB0T0dML2FnZ08wMzgvNk9OYmprd05iQnFYUVE0NDY0ZFQvemlL?= =?utf-8?B?WE9jN0ZhM00wb3BmVGhZYnlTTW9teTVRSDBXVVJBMVdJNnFJclRzVDAwazNq?= =?utf-8?B?UEZocHIycGhkUXJRZlZDbDN1QWgrMW9ja3VTWGJtR1hlMEovV3hYQzVta2JT?= =?utf-8?B?RGFCR0o0RmtHWVE2V00zQnRKamVPaUxOUFlma2drcExEK3hXZ0J5TXdmUHNU?= =?utf-8?B?Wlc3L2M3dGtPKzlPTW1OV2tUdGNNSjBFNVkxMkFOVU1SVzdjdEdEdXJ6Z0xR?= =?utf-8?B?MlhpdDFPTVJjNzEwQjRtQ25adExQaGplSEVvVUQxTzJmcUlRVkNodmM1Rlk0?= =?utf-8?B?aFp1UU9UaFQwdUVwaW5lSERyRG5yWTJQSzRNZUdvMVIrdlVlRjlTU2l4Mkg4?= =?utf-8?B?eU1rNGJ0eXVlbEwwc2ZwNlNPV0V6Wk1sSWFBQ1N6NjFRSC9YbHJsbmFJT3VR?= =?utf-8?B?V3hoVWN6ZGdRRDkrMHNGaTl4MUo2bVJaTS80UFpieGZWaEFWa3B3NEpNRmVr?= =?utf-8?B?S0daamM1ZHF6VjdJakFXSGxjSVY3Y2QrSzBhY3BhVEJTdmtxU2Q0VUxoREFj?= =?utf-8?B?YlkxaDgzQjQxT1BDSHBQZmdhaVcvdEFyM0U2Z2FGMEV1RU9Qc0xSbENlUUkr?= =?utf-8?B?akt2d2YxMm1jaVV3c3IyNkF3Q0NyL3lmdnorS0FzaFFhL1lUZVdqSjB2Z3Ju?= =?utf-8?B?dmhMTVg4bkNrQ1VMbGNINHVJVDRxMXRCZXFnWWFUN1BqSHdMVnYxUkJaTUNt?= =?utf-8?B?TUlWcmxkRGxlUGpPZzJiNGRQb2VnMldnWGsyZEtORi9sTXYra0hEVWdXQkty?= =?utf-8?B?OGtJSUwzUlRHYUlON2QvSDg0OHFTL2trUURFOURLS2ZhbU9xdlAwb2YveEQ3?= =?utf-8?B?VjVOY1JmUk0vSk81WkZrV3J1Z1lLN0l4V2xYTnNtd0RQMjNiendVcG4xRjNx?= =?utf-8?Q?Q+wArj2m1QIi7GExjiFGSeNvIYOb7FbDVBEIVca?= X-MS-Exchange-CrossTenant-Network-Message-Id: 07e57b7d-1e63-492e-e3ca-08d8def51673 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 10:05:49.9834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QLuJQJF7n2ERXqLAqoS3YneHiTaByyMYkjA8VUeGzZux9aza/rb90xuUcGt3yFLbgGToukb01fT0qFtBkanRgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4603 X-OriginatorOrg: citrix.com On Thu, Mar 04, 2021 at 09:48:25AM +0100, Jan Beulich wrote: > On 03.03.2021 16:38, Roger Pau Monné wrote: > > On Tue, Mar 02, 2021 at 04:18:59PM +0100, Jan Beulich wrote: > >> On 02.03.2021 16:00, Roger Pau Monné wrote: > >>> On Tue, Mar 02, 2021 at 12:16:12PM +0100, Jan Beulich wrote: > >>>> On 01.03.2021 17:23, Roger Pau Monne wrote: > >>>>> RFC because there's still some debate as to how we should solve the > >>>>> MSR issue, this is one possible way, but IMO we need to make a > >>>>> decision soon-ish because of the release timeline. > >>>> > >>>> Generally I think it would be far better from a user pov if > >>>> things worked out of the box, at least in cases where it can be > >>>> made work. Arguably for Solaris this isn't going to be possible > >>>> (leaving aside the non-option of fully returning back to original > >>>> behavior), but for the old-Linux-PV case I still think my proposed > >>>> change is better in this regard. I realize Andrew said (on irc) > >>>> that this is making the behavior even weaker. I take a different > >>>> perspective: Considering a guest will install exception handlers > >>>> at some point, I continue to fail to see what good it will do to > >>>> try to inject a #GP(0) when we know the guest will die because of > >>>> not having a handler registered just yet. It is a kernel flaw, > >>>> yes, but they ended up living with it merely because of our odd > >>>> prior behavior, so we can't put all the blame on them. > >>> > >>> My concern with this would mostly be with newer guests, in the sense > >>> that people could come to rely on this behavior of not injecting a > >>> #GP if the handler is not setup, which I think we should try to avoid. > >>> > >>> One option would be to introduce a feature that could be used in the > >>> elfnotes to signal that the kernel doesn't require such workarounds > >>> for MSR #GP handling, maybe: > >>> > >>> /* > >>> * Signal that the kernel doesn't require suppressing the #GP on > >>> * unknown MSR accesses if the handler is not setup. New kernels > >>> * should always have this set. > >>> */ > >>> #define XENFEAT_msr_early_gp 16 > >>> > >>> We could try to backport this on the Linux kernel as far as we can > >>> that we know it's safe to do so. > >> > >> I too did consider something like this. While I'm not opposed, it > >> effectively requires well-behaved consumers who haven't been well- > >> behaved in the past. > >> > >>> If this is not acceptable then I guess your solution is fine. Arguably > >>> PV has it's own (weird) architecture, in which it might be safe to say > >>> that no #GP will be injected as a result of a MSR access unless the > >>> handler is setup. Ideally we should document this behaviour somewhere. > >>> > >>> Maybe we could add a rdmsr_safe to your path akin to what's done > >>> here? > >> > >> Probably. Would need trying out on the affected older version, > >> just like ... > >> > >>>>> --- a/docs/man/xl.cfg.5.pod.in > >>>>> +++ b/docs/man/xl.cfg.5.pod.in > >>>>> @@ -2861,6 +2861,17 @@ No MCA capabilities in above list are enabled. > >>>>> > >>>>> =back > >>>>> > >>>>> +=item B > >>>>> + > >>>>> +Select whether to use the legacy behaviour for accesses to MSRs not explicitly > >>>>> +handled by Xen instead of injecting a #GP to the guest. Such legacy access > >>>>> +mode will force Xen to replicate the behaviour from the hardware it's currently > >>>>> +running on in order to decide whether a #GP is injected to the guest. Note > >>>>> +that the guest is never allowed access to unhandled MSRs, this option only > >>>>> +changes whether a #GP might be injected or not. > >>>> > >>>> This description is appropriate for reads, but not for writes: > >>>> Whether a write would fault can only be known by trying a write, > >>>> yet for safety reasons we can't risk doing more than a read. An > >>>> option might be to make writes fault is the to be written value > >>>> differs from that which the probing read has returned (i.e. the > >>>> same condition which originally had caused a log message to appear > >>>> in 4.14 for PV guests). > >>> > >>> Read values for unhandled MSRs will always be 0 with the proposed > >>> code, so we would inject a #GP to the guest for any write attempt to > >>> unhandled MSRs with a value different than 0. > >>> > >>> Maybe we should just inject a #GP to the guest for any attempts to > >>> write to unhandled MSRs? > >> > >> ... doing this would need to. Iirc I did add the write side of the > >> handling in my patch just for symmetry. I'd prefer handling to be > >> symmetric, but I can see why we may not want it to be so. > > > > Kind of in the wrong context, but I will reply here because it's the > > last message related to the MSR stuff. > > > > Jan: would you be fine with modifying your path to not change the > > behaviour for writes (ie: always inject #GP to the guest for unhandled > > accesses), and then add a rdmsr_safe to the read path in order to > > decide whether to inject a #GP to the guest even if the #GP handler is > > not setup? > > I don't mind as long as it ends up making things work (I have no > reason to believe it won't). I'll give that a try. Thanks. I think this behavior would be a fine solution for PV guests because: - It's unlikely we will see any new ports to x86 PV mode, and hence we mostly need to care about the existing ones which we already fixed in new versions, so this behavior is not to be propagated. - The Xen PV architecture is already different from the x86 architecture, and hence we can slightly bend the rules to our liking. - It's not feasible for us to figure out what MSRs older Linux versions tried to access without having a #GP handler setup. Not sure whether this also affects NetBSD. I would like to suggest to introduce a comment to document this behaviour for x86 PV in the public headers, but I'm afraid I cannot find a suitable location. > > I can modify the option introduced on this patch to always inject #GP > > on unhandled writes and only inject #GP on reads if the physical MSR > > access on the hardware also triggers a #GP. HVM guests with broken > > behavior will require having the option enabled in order to work, > > but I think that's likely OK as long term we expect all HVM guests to > > be well behaved. > > > > My main worry with this approach is that we end up requiring half of > > the common HVM guests OSes to have the 'legacy MSR handling' option > > enabled in order to work. I think it's unlikely for this to happen, as > > we are only aware of Solaris requiring it at the moment. > > > > It also raises the question whether we will allow any more exceptions > > to the MSR policy, like we did for Windows and OpenBSD in: > > > > http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=ca88a43e660c75796656a544e54a648c60d26ef0 > > http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=4175fd3ccd17face664036fa98e9329aa317f7b6 > > > > Or if we are just going to require those guests to enable the legacy > > MSR handling instead. > > It is my understanding that Andrew's view is that adding such special > cases is the only acceptable thing. As voiced before I don't share > this view, as it means we're going to be entirely reactive to people > reporting issues, when I think we should be pro-active as far as is > reasonable. Independent of any pro-active measures there'll still be > enough reasons for reactive changes - for example I assume Linux > would now issue the log message from > > if (cpu_has(c, X86_FEATURE_CONSTANT_TSC)) { > > if (c->x86 > 0x10 || > (c->x86 == 0x10 && c->x86_model >= 0x2)) { > u64 val; > > rdmsrl(MSR_K7_HWCR, val); > if (!(val & BIT(24))) > pr_warn(FW_BUG "TSC doesn't count with P0 frequency!\n"); > } > } > > since we surface a zero value right now (but I didn't verify this in > practice yet). I think we inject a #GP to the guest if it tries to access MSR_K7_HWCR? As I don't see this MSR handled explicitly in svm_msr_read_intercept. So Linux would complain from the unchecked MSR access and the MSR value not having the bit set. This one seems like a fine candidate to implement in svm_msr_read_intercept, because Xen needs to return a specific value for this MSR. Regarding the global approach to fixing the fallout from the MSR policy change, I don't see why we couldn't do a mix between pro-active and reactive. I think we must have an option to fallback to something similar to the old policy for HVM guests so that users have a way to get their guests running after an update without requiring a code change. That doesn't mean we can't reactively add the missing MSRs as we go discovering them. I would even print a warning when using such fallback legacy MSR handling option that you need to report the issue to xen-devel because the option might be removed in future releases. Does the above seem like a sensible plan? Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 04 10:15:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 10:15:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93085.175718 (Exim 4.92) (envelope-from ) id 1lHl0T-0003he-Ci; Thu, 04 Mar 2021 10:14:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93085.175718; Thu, 04 Mar 2021 10:14:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHl0T-0003hX-9o; Thu, 04 Mar 2021 10:14:57 +0000 Received: by outflank-mailman (input) for mailman id 93085; Thu, 04 Mar 2021 10:14:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHl0S-0003hS-UC for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 10:14:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHl0R-0000Bw-8v; Thu, 04 Mar 2021 10:14:55 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lHl0Q-0007CC-Uu; Thu, 04 Mar 2021 10:14:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Z+Ek5plrpZHur5ElbzzeRuQcVCv/vgkINKN8S4YeLVs=; b=zHP5A5gfPpi+wewaQaboquQ384 Bab1l21uXnSSTlMp5BJgR7NY/Dc3ph2lrfgU8a0Zy51Y70TJa2pPZI9nhgZNhzWHCap0wmmQC83PA yOnfaa/ZypxUIsbIUUEdCkH27OhEkRzsEEjC4cZQMA5+IfR4iPSSEv2YtObXjm9j+8wo=; Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , Bjoern Doebel References: <20210303170526.15903-1-julien@xen.org> <9f81d0c8-1ec8-7cd0-d943-fd31bc86de13@suse.com> <6c2f8459-b109-9a16-79c1-ab92969c4ece@xen.org> <78a79740-925e-559c-f5ff-b365cc1c2732@suse.com> From: Julien Grall Message-ID: Date: Thu, 4 Mar 2021 10:14:53 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <78a79740-925e-559c-f5ff-b365cc1c2732@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Juergen, On 04/03/2021 09:48, Jürgen Groß wrote: > On 04.03.21 10:39, Julien Grall wrote: >> >> >> On 04/03/2021 09:00, Jürgen Groß wrote: >>> On 03.03.21 18:05, Julien Grall wrote: >>>> From: Julien Grall >>>> >>>> As XenStored is single-threaded, conn->ta_start_time will always be >>>> smaller than now. As we substract the latter from the former, it means >>>> a transaction will never be considered long running. >>>> >>>> Invert the two operands of the substraction in both lu_reject_reason() >>>> and lu_check_allowed(). In addition to that, the former also needs to >>>> check that conn->ta_start_time is not 0 (i.e the transaction is not >>>> active). >>>> >>>> Take the opportunity to document the return condition of >>>> lu_check_allowed(). >>>> >>>> Fixes: e04e53a5be20 ("tools/xenstore: allow live update only with no >>>> transaction active") >>>> Reported-by: Bjoern Doebel >>>> Signed-off-by: Julien Grall >>> >>> Reviewed-by: Juergen Gross >>> >>>> >>>> --- >>>> >>>> I am a bit puzzled on how -F is implemented. From my understanding we >>>> will force LiveUpdate when one of the following conditions is met: >>>>    1) All the active transactions are long running >>>>    2) If we didn't manage to LiveUpdate after N sec >>>> >>>> It is not quite clear why we need the both as 2) would indirectly cover >>>> 1). However 2) is probably unsafe as we may reset transactions for >>>> "well-behaving" guest. >>>> >>>> So I am thinking to send a patch to drop 2). Any opinions? >>> >>> This will enable two guests working together to block LU by using >>> overlapping transactions: >>> >>> Guest 1: ----- ----- -----  ... >>> Guest 2: -- ----- ----- --- ... > >>> There is always a transaction active, but none is regarded to be >>> long running. >> >> Right, how do you know whether two guests are working together? > > We can't know that. And this is the reason why you have to use the -F > option to force a LU. I understand that... But the consequence are potentially devastating on all the other connections, correct? > >> I understand that "-F" means that things could break... However, I am >> not entirely sure who can realistically use this option without >> risking breaking other guests. For instance, there might be a 3rd >> guest that has an active transaction and not cooperating with the >> first two. > > Yes. OTOH the chances are rather low that multiple LU attempts are > failing due to transactions being active all the time. Give me access to your server and I can run you a workload that prevent LiveUpdate without -F ;). Joke aside, a guest crashing in the middle of the transaction can prevent LiveUpdate to succeed. As the guest owner may not be the host owner, you don't necessarily know when the problem will be remediated. This is where I would expect -F to be useful as breaking transaction for such guest is low-risk. However, the side-effect of -F looks quite undesirable so far. > >> Rather than forcing in this case, how about we quiesce the connection >> if it starts a transaction when LiveUpdate is pending? > > Yes, this should work, too. I will have a look. It is not going to be material for 4.15 though. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 04 10:28:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 10:28:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93090.175730 (Exim 4.92) (envelope-from ) id 1lHlDX-0004qe-Jy; Thu, 04 Mar 2021 10:28:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93090.175730; Thu, 04 Mar 2021 10:28:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlDX-0004qX-H1; Thu, 04 Mar 2021 10:28:27 +0000 Received: by outflank-mailman (input) for mailman id 93090; Thu, 04 Mar 2021 10:28:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlDV-0004qS-Uh for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 10:28:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlDV-0000QQ-FT; Thu, 04 Mar 2021 10:28:25 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lHlDV-00086q-6b; Thu, 04 Mar 2021 10:28:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=mNlFm4VQb0yj1aHmxWN+nnGSg9MTFU5612d/9trK7yo=; b=r8ytQ6KB26mfbhMRxY1vY824jH 04nT3B4/wAugiVlmyIOocsSVYArRfLZIsiE71dSk8ujZIcvPWA33o2go5AxwyHC/SrAeKEp9btRcM Gcrh5J6SY8ErIskn1nQqkstJobqcO+dZhlLD/PWZXIHk9axA3EoeQD5djpvO1PH+afq4=; Subject: Re: dom0less boot two compressed kernel images out-of-memory work-around To: Jan Beulich Cc: Stefano Stabellini , Ian Jackson , Andrew Cooper , Charles Chiou , "xen-devel@lists.xenproject.org" References: <58aaf68f-4499-9400-6eb2-f1ad3b620c73@xen.org> <511603c8-40b4-5e22-7eba-7722d89895fe@suse.com> From: Julien Grall Message-ID: Date: Thu, 4 Mar 2021 10:28:23 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <511603c8-40b4-5e22-7eba-7722d89895fe@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 04/03/2021 08:34, Jan Beulich wrote: > On 03.03.2021 20:36, Julien Grall wrote: >> (BCCing xen-users, CCing xen-devel + a few folks) >> How about the following (untested): >> >> commit e1cd2d85234c8d0aa62ad32c824a5568a57be930 (HEAD -> dev) >> Author: Julien Grall >> Date: Wed Mar 3 19:27:56 2021 +0000 >> >> xen/gunzip: Allow perform_gunzip() to be called multiple times >> >> Currently perform_gunzip() can only be called once because the the >> internal allocator is not fully re-initialized. >> >> This works fine if you are only booting dom0. But this will break when >> booting multiple using the dom0less that uses compressed kernel images. >> >> This can be resolved by re-initializing malloc_ptr and malloc_count >> every time perform_gunzip() is called. >> >> Note the latter is only re-initialized for hardening purpose as >> there is >> no guarantee that every malloc() are followed by free() (It should in >> theory!). >> >> Take the opportunity to check the return of alloc_heap_pages() to >> return >> an error rather than dereferencing a NULL pointer later on failure. >> >> Reported-by: Charles Chiou >> Signed-off-by: Julien Grall >> >> --- >> >> This patch is candidate for Xen 4.15. Without this patch, it will >> not be >> possible to boot multiple domain using dom0less when they are using >> compressed kernel images. > > Other decompression methods are unaffected? Arm is only using gzip so far. I quickly looked through bunzip2 and unlz4 (I know there are others), they look fine because they don't allocate a large global pool. We probably want to check the others. > >> --- a/xen/common/gunzip.c >> +++ b/xen/common/gunzip.c >> @@ -114,7 +114,11 @@ __init int perform_gunzip(char *output, char >> *image, unsigned long image_len) >> window = (unsigned char *)output; >> >> free_mem_ptr = (unsigned long)alloc_xenheap_pages(HEAPORDER, 0); >> + if ( !free_mem_ptr ) >> + return -ENOMEM; >> + >> free_mem_end_ptr = free_mem_ptr + (PAGE_SIZE << HEAPORDER); >> + init_allocator(); >> >> inbuf = (unsigned char *)image; >> insize = image_len; >> diff --git a/xen/common/inflate.c b/xen/common/inflate.c >> index f99c985d6135..d8c28a3e9593 100644 >> --- a/xen/common/inflate.c >> +++ b/xen/common/inflate.c >> @@ -238,6 +238,12 @@ STATIC const ush mask_bits[] = { >> static unsigned long INITDATA malloc_ptr; >> static int INITDATA malloc_count; >> >> +static void init_allocator(void) > > Please add INIT here. (I wouldn't mind if you used __init instead, > as there's going to be file-wide replacement after 4.15 anyway, > but of course this would render things inconsistent until then.) I will use INIT. I will wait a bit before sending the patch formally (I'd like a confirmation that it solves the problem reported). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 04 10:40:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 10:40:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93104.175780 (Exim 4.92) (envelope-from ) id 1lHlOp-0006qS-ID; Thu, 04 Mar 2021 10:40:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93104.175780; Thu, 04 Mar 2021 10:40:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlOp-0006qL-E7; Thu, 04 Mar 2021 10:40:07 +0000 Received: by outflank-mailman (input) for mailman id 93104; Thu, 04 Mar 2021 10:40:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlOo-00065n-Qu for xen-devel@lists.xen.org; Thu, 04 Mar 2021 10:40:06 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 371d9cdb-5c63-454a-9f7f-84cd4103e0dc; Thu, 04 Mar 2021 10:39:51 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlOS-0000bP-VK; Thu, 04 Mar 2021 10:39:44 +0000 Received: from iwj by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHlOS-0000Se-RY; Thu, 04 Mar 2021 10:39:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 371d9cdb-5c63-454a-9f7f-84cd4103e0dc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=my0l2403/dVXAUYLCcMAG2vIG582kdfMfEvrO9lUiLo=; b=v9RdhD+AJ/fpTm0ck/gSTXVE/S yPUcPnw0xBszoN8OQaV+Twztk3899MbFf0NZ3n2hK1fRVmadGWHaw3SbVd1lq9OZ7EprB8jF+C2HA PadLCN5HWot1YqOfN2AxT26NWyCiiscF+MjULXNcjFIKi1jflXsfZrBNQ4mEytaNvw4s=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 367 v1 - Linux: netback fails to honor grant mapping errors Message-Id: Date: Thu, 04 Mar 2021 10:39:44 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory XSA-367 Linux: netback fails to honor grant mapping errors ISSUE DESCRIPTION ================= XSA-362 tried to address issues here, but in the case of the netback driver the changes were insufficient: It left the relevant function invocation with, effectively, no error handling at all. As a result, memory allocation failures there could still lead to frontend-induced crashes of the backend. IMPACT ====== A malicious or buggy networking frontend driver may be able to crash the corresponding backend driver, potentially affecting the entire domain running the backend driver. In a typical (non-disaggregated) system that is a host-wide denial of service (DoS). VULNERABLE SYSTEMS ================== Linux versions from at least 2.6.39 onwards are vulnerable, when run in PV mode. Earlier versions differ significantly in behavior and may therefore instead surface other issues under the same conditions. Linux run in HVM / PVH modes is not vulnerable. MITIGATION ========== For Linux, running the backends in HVM or PVH domains will avoid the vulnerability. For example, by running the dom0 in PVH mode. In all other cases there is no known mitigation. RESOLUTION ========== Applying the attached patch resolves this issue. xsa367-linux.patch Linux 5.12-rc $ sha256sum xsa367* b0244bfddee91cd7986172893e70664b74e698c5d44f25865870f179f80f9a92 xsa367-linux.patch $ CREDITS ======= This issue was reported by Intel's kernel test robot and recognized as a security issue by Jan Beulich of SUSE. NOTE REGARDING LACK OF EMBARGO ============================== This issue was reported publicly, before the XSA could be issued. -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmBAuOYMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZUCAH/1zw5d2l1R3k+nvJ659plwOYDe8Cmh4GeJ02PoUv fC/5efe7l/tXEmfg4rg5WiY8JZqQGeGmhwiOs8bI/8c5IXucaPOM1wDUaHUMkWTA tl/P/tbDamzd1/dSK4DdILTApibU+M/nmUn0sBBYpu53VUbeyXq2EAtjmliKgCG9 Oo4PW4ys5ro+hwrPtYdLD1ktIN64+C+TqkKUdJset7po5sWX4nV1Cwp/4oKaNyeF Alh495TUCnhgc8gnXUgXhmxWKp3Iag/tHjmtu34mT5HHZdBrNBShFKhHSP5bJHE2 CxYD1b/KbkRiLPOgZXNec+ikDQT4bTCeVLpnWvOXQ1FTXR4= =hY2s -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa367-linux.patch" Content-Disposition: attachment; filename="xsa367-linux.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBYZW4vZ250dGFiOiBoYW5kbGUgcDJtIHVwZGF0ZSBlcnJvcnMgb24gYSBw ZXItc2xvdCBiYXNpcwoKQmFpbGluZyBpbW1lZGlhdGVseSBmcm9tIHNldF9m b3JlaWduX3AybV9tYXBwaW5nKCkgdXBvbiBhIHAybSB1cGRhdGluZwplcnJv ciBsZWF2ZXMgdGhlIGZ1bGwgYmF0Y2ggaW4gYW4gYW1iaWd1b3VzIHN0YXRl IGFzIGZhciBhcyB0aGUgY2FsbGVyCmlzIGNvbmNlcm5lZC4gSW5zdGVhZCBm bGFncyByZXNwZWN0aXZlIHNsb3RzIGFzIGJhZCwgdW5tYXBwaW5nIHdoYXQK d2FzIG1hcHBlZCB0aGVyZSByaWdodCBhd2F5LgoKSFlQRVJWSVNPUl9ncmFu dF90YWJsZV9vcCgpJ3MgcmV0dXJuIHZhbHVlIGFuZCB0aGUgaW5kaXZpZHVh bCB1bm1hcApzbG90cycgc3RhdHVzIGZpZWxkcyBnZXQgdXNlZCBvbmx5IGZv ciBhIG9uZS10aW1lIC0gdGhlcmUncyBub3QgbXVjaCB3ZQpjYW4gZG8gaW4g Y2FzZSBvZiBhIGZhaWx1cmUuCgpOb3RlIHRoYXQgdGhlcmUncyBubyBHTlRT VF9lbm9tZW0gb3IgYWxpa2UsIHNvIEdOVFNUX2dlbmVyYWxfZXJyb3IgZ2V0 cwp1c2VkLgoKVGhlIG1hcCBvcHMnIGhhbmRsZSBmaWVsZHMgZ2V0IG92ZXJ3 cml0dGVuIGp1c3QgdG8gYmUgb24gdGhlIHNhZmUgc2lkZS4KClRoaXMgaXMg WFNBLTM2Ny4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj aEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFdlaSBMaXUgPHdlaS5saXVAa2Vy bmVsLm9yZz4KLS0tCnYyOiBMb2cgbWVzc2FnZS4gSW52YWxpZGF0ZSBtYXAg b3BzJyBoYW5kbGVzLgoKLS0tIGEvYXJjaC9hcm0veGVuL3AybS5jCisrKyBi L2FyY2gvYXJtL3hlbi9wMm0uYwpAQCAtOTMsMTIgKzkzLDM5IEBAIGludCBz ZXRfZm9yZWlnbl9wMm1fbWFwcGluZyhzdHJ1Y3QgZ250dGEKIAlpbnQgaTsK IAogCWZvciAoaSA9IDA7IGkgPCBjb3VudDsgaSsrKSB7CisJCXN0cnVjdCBn bnR0YWJfdW5tYXBfZ3JhbnRfcmVmIHVubWFwOworCQlpbnQgcmM7CisKIAkJ aWYgKG1hcF9vcHNbaV0uc3RhdHVzKQogCQkJY29udGludWU7Ci0JCWlmICh1 bmxpa2VseSghc2V0X3BoeXNfdG9fbWFjaGluZShtYXBfb3BzW2ldLmhvc3Rf YWRkciA+PiBYRU5fUEFHRV9TSElGVCwKLQkJCQkgICAgbWFwX29wc1tpXS5k ZXZfYnVzX2FkZHIgPj4gWEVOX1BBR0VfU0hJRlQpKSkgewotCQkJcmV0dXJu IC1FTk9NRU07Ci0JCX0KKwkJaWYgKGxpa2VseShzZXRfcGh5c190b19tYWNo aW5lKG1hcF9vcHNbaV0uaG9zdF9hZGRyID4+IFhFTl9QQUdFX1NISUZULAor CQkJCSAgICBtYXBfb3BzW2ldLmRldl9idXNfYWRkciA+PiBYRU5fUEFHRV9T SElGVCkpKQorCQkJY29udGludWU7CisKKwkJLyoKKwkJICogU2lnbmFsIGFu IGVycm9yIGZvciB0aGlzIHNsb3QuIFRoaXMgaW4gdHVybiByZXF1aXJlcwor CQkgKiBpbW1lZGlhdGUgdW5tYXBwaW5nLgorCQkgKi8KKwkJbWFwX29wc1tp XS5zdGF0dXMgPSBHTlRTVF9nZW5lcmFsX2Vycm9yOworCQl1bm1hcC5ob3N0 X2FkZHIgPSBtYXBfb3BzW2ldLmhvc3RfYWRkciwKKwkJdW5tYXAuaGFuZGxl ID0gbWFwX29wc1tpXS5oYW5kbGU7CisJCW1hcF9vcHNbaV0uaGFuZGxlID0g fjA7CisJCWlmIChtYXBfb3BzW2ldLmZsYWdzICYgR05UTUFQX2RldmljZV9t YXApCisJCQl1bm1hcC5kZXZfYnVzX2FkZHIgPSBtYXBfb3BzW2ldLmRldl9i dXNfYWRkcjsKKwkJZWxzZQorCQkJdW5tYXAuZGV2X2J1c19hZGRyID0gMDsK KworCQkvKgorCQkgKiBQcmUtcG9wdWxhdGUgdGhlIHN0YXR1cyBmaWVsZCwg dG8gYmUgcmVjb2duaXphYmxlIGluCisJCSAqIHRoZSBsb2cgbWVzc2FnZSBi ZWxvdy4KKwkJICovCisJCXVubWFwLnN0YXR1cyA9IDE7CisKKwkJcmMgPSBI WVBFUlZJU09SX2dyYW50X3RhYmxlX29wKEdOVFRBQk9QX3VubWFwX2dyYW50 X3JlZiwKKwkJCQkJICAgICAgICZ1bm1hcCwgMSk7CisJCWlmIChyYyB8fCB1 bm1hcC5zdGF0dXMgIT0gR05UU1Rfb2theSkKKwkJCXByX2Vycl9vbmNlKCJn bnR0YWIgdW5tYXAgZmFpbGVkOiByYz0lZCBzdD0lZFxuIiwKKwkJCQkgICAg cmMsIHVubWFwLnN0YXR1cyk7CiAJfQogCiAJcmV0dXJuIDA7Ci0tLSBhL2Fy Y2gveDg2L3hlbi9wMm0uYworKysgYi9hcmNoL3g4Ni94ZW4vcDJtLmMKQEAg LTcxMCw2ICs3MTAsOCBAQCBpbnQgc2V0X2ZvcmVpZ25fcDJtX21hcHBpbmco c3RydWN0IGdudHRhCiAKIAlmb3IgKGkgPSAwOyBpIDwgY291bnQ7IGkrKykg ewogCQl1bnNpZ25lZCBsb25nIG1mbiwgcGZuOworCQlzdHJ1Y3QgZ250dGFi X3VubWFwX2dyYW50X3JlZiB1bm1hcFsyXTsKKwkJaW50IHJjOwogCiAJCS8q IERvIG5vdCBhZGQgdG8gb3ZlcnJpZGUgaWYgdGhlIG1hcCBmYWlsZWQuICov CiAJCWlmIChtYXBfb3BzW2ldLnN0YXR1cyAhPSBHTlRTVF9va2F5IHx8CkBA IC03MjcsMTAgKzcyOSw0NiBAQCBpbnQgc2V0X2ZvcmVpZ25fcDJtX21hcHBp bmcoc3RydWN0IGdudHRhCiAKIAkJV0FSTihwZm5fdG9fbWZuKHBmbikgIT0g SU5WQUxJRF9QMk1fRU5UUlksICJwYWdlIG11c3QgYmUgYmFsbG9vbmVkIik7 CiAKLQkJaWYgKHVubGlrZWx5KCFzZXRfcGh5c190b19tYWNoaW5lKHBmbiwg Rk9SRUlHTl9GUkFNRShtZm4pKSkpIHsKLQkJCXJldCA9IC1FTk9NRU07Ci0J CQlnb3RvIG91dDsKKwkJaWYgKGxpa2VseShzZXRfcGh5c190b19tYWNoaW5l KHBmbiwgRk9SRUlHTl9GUkFNRShtZm4pKSkpCisJCQljb250aW51ZTsKKwor CQkvKgorCQkgKiBTaWduYWwgYW4gZXJyb3IgZm9yIHRoaXMgc2xvdC4gVGhp cyBpbiB0dXJuIHJlcXVpcmVzCisJCSAqIGltbWVkaWF0ZSB1bm1hcHBpbmcu CisJCSAqLworCQltYXBfb3BzW2ldLnN0YXR1cyA9IEdOVFNUX2dlbmVyYWxf ZXJyb3I7CisJCXVubWFwWzBdLmhvc3RfYWRkciA9IG1hcF9vcHNbaV0uaG9z dF9hZGRyLAorCQl1bm1hcFswXS5oYW5kbGUgPSBtYXBfb3BzW2ldLmhhbmRs ZTsKKwkJbWFwX29wc1tpXS5oYW5kbGUgPSB+MDsKKwkJaWYgKG1hcF9vcHNb aV0uZmxhZ3MgJiBHTlRNQVBfZGV2aWNlX21hcCkKKwkJCXVubWFwWzBdLmRl dl9idXNfYWRkciA9IG1hcF9vcHNbaV0uZGV2X2J1c19hZGRyOworCQllbHNl CisJCQl1bm1hcFswXS5kZXZfYnVzX2FkZHIgPSAwOworCisJCWlmIChrbWFw X29wcykgeworCQkJa21hcF9vcHNbaV0uc3RhdHVzID0gR05UU1RfZ2VuZXJh bF9lcnJvcjsKKwkJCXVubWFwWzFdLmhvc3RfYWRkciA9IGttYXBfb3BzW2ld Lmhvc3RfYWRkciwKKwkJCXVubWFwWzFdLmhhbmRsZSA9IGttYXBfb3BzW2ld LmhhbmRsZTsKKwkJCWttYXBfb3BzW2ldLmhhbmRsZSA9IH4wOworCQkJaWYg KGttYXBfb3BzW2ldLmZsYWdzICYgR05UTUFQX2RldmljZV9tYXApCisJCQkJ dW5tYXBbMV0uZGV2X2J1c19hZGRyID0ga21hcF9vcHNbaV0uZGV2X2J1c19h ZGRyOworCQkJZWxzZQorCQkJCXVubWFwWzFdLmRldl9idXNfYWRkciA9IDA7 CiAJCX0KKworCQkvKgorCQkgKiBQcmUtcG9wdWxhdGUgYm90aCBzdGF0dXMg ZmllbGRzLCB0byBiZSByZWNvZ25pemFibGUgaW4KKwkJICogdGhlIGxvZyBt ZXNzYWdlIGJlbG93LgorCQkgKi8KKwkJdW5tYXBbMF0uc3RhdHVzID0gMTsK KwkJdW5tYXBbMV0uc3RhdHVzID0gMTsKKworCQlyYyA9IEhZUEVSVklTT1Jf Z3JhbnRfdGFibGVfb3AoR05UVEFCT1BfdW5tYXBfZ3JhbnRfcmVmLAorCQkJ CQkgICAgICAgdW5tYXAsIDEgKyAhIWttYXBfb3BzKTsKKwkJaWYgKHJjIHx8 IHVubWFwWzBdLnN0YXR1cyAhPSBHTlRTVF9va2F5IHx8CisJCSAgICB1bm1h cFsxXS5zdGF0dXMgIT0gR05UU1Rfb2theSkKKwkJCXByX2Vycl9vbmNlKCJn bnR0YWIgdW5tYXAgZmFpbGVkOiByYz0lZCBzdDA9JWQgc3QxPSVkXG4iLAor CQkJCSAgICByYywgdW5tYXBbMF0uc3RhdHVzLCB1bm1hcFsxXS5zdGF0dXMp OwogCX0KIAogb3V0Ogo= --=separator-- From xen-devel-bounces@lists.xenproject.org Thu Mar 04 10:48:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 10:48:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93148.175793 (Exim 4.92) (envelope-from ) id 1lHlWv-0007WM-J7; Thu, 04 Mar 2021 10:48:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93148.175793; Thu, 04 Mar 2021 10:48:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlWv-0007WF-Ft; Thu, 04 Mar 2021 10:48:29 +0000 Received: by outflank-mailman (input) for mailman id 93148; Thu, 04 Mar 2021 10:48:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlWt-0007WA-UT for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 10:48:28 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fbb662c5-27b3-4e1c-bf79-ef50688e3df4; Thu, 04 Mar 2021 10:48:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fbb662c5-27b3-4e1c-bf79-ef50688e3df4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614854903; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=VytRFVs1Z/CjA5kL238k+P7x0SlBNPkobG/zuRvSCII=; b=U4oPRomGYsudgTbor7tt+mliJaREXu24wYn8w+yz3SSEkAE1Lym+dQGK Z12kKRW/clAzx29qxBd3Od9dCVmUdoOnre9y9jK3CdEYphAQAncCoQ5qC C2VyHf6ciYGUZw++o0wcX2e2tj6b/PHYlJ+Ji6qTPvws8Ubgs0++UjvQX U=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: e7CstDsFVPQpa3pxM8s6Ow3MM1ir998+dSYiaZe2AlsHrsfGXbZeeK9i0ZD0SkMAV89Uqk+vDB PichbhNyzIfCoBW1NLlxiKPPz1VOVusiy82p9XP+KXVWs8WNLlCB1R2M+EnncqoC044DCs0pQi AQhw9EBQTfYVY5XvBoqq7jKddrb3ou3yxJUr4jltElILRp79xBTQsxWW8v9kAJF0epaX+gkLQ5 +ycPzx5g0YMuaXbqXkUlAI4X7mR754aSRcqfcDXMSi7wajZkXcC9ecXPm0NcIn+0HD4x9abQHw gTo= X-SBRS: 5.1 X-MesageID: 38437466 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,222,1610427600"; d="scan'208";a="38437466" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Ian Jackson Subject: [PATCH for-4.15] xen/dmop: Fix XEN_DMOP_nr_vcpus to actually return data Date: Thu, 4 Mar 2021 10:48:05 +0000 Message-ID: <20210304104805.27601-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The const_op boolean needs clobbering to cause data to be written back to the caller. Fixes: c4441ab1f1 ("dmop: Add XEN_DMOP_nr_vcpus") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Ian Jackson If we weren't in a release freeze, I'd rewrite large chunks of this. 'const_op' is what we call 'copyback' everywhere else, but with inverted sense. I'll guess this gets added to the pile of other unbreakage work which might happen in 4.16 My ad-hoc unit test appears to have had a false positive for the success case, which I've fixed. However, the chances of the full test landing in 4.15 is getting slimmer, not to mention the fact that it curretly takes out Xen with reference counting error... As for 4.15, this is a bug in a brand-newly introduced hypercall, and is of 0 risk for other areas of the release. If this bugfix is not taken, we should revert c4441ab1f1 to take the hypercall out, but this would be a bad move. --- xen/arch/arm/dm.c | 1 + xen/arch/x86/hvm/dm.c | 1 + 2 files changed, 2 insertions(+) diff --git a/xen/arch/arm/dm.c b/xen/arch/arm/dm.c index d689e336fd..1b3fd6bc7d 100644 --- a/xen/arch/arm/dm.c +++ b/xen/arch/arm/dm.c @@ -128,6 +128,7 @@ int dm_op(const struct dmop_args *op_args) struct xen_dm_op_nr_vcpus *data = &op.u.nr_vcpus; data->vcpus = d->max_vcpus; + const_op = false; rc = 0; break; } diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c index f4f0910463..b60b9f3364 100644 --- a/xen/arch/x86/hvm/dm.c +++ b/xen/arch/x86/hvm/dm.c @@ -612,6 +612,7 @@ int dm_op(const struct dmop_args *op_args) struct xen_dm_op_nr_vcpus *data = &op.u.nr_vcpus; data->vcpus = d->max_vcpus; + const_op = false; rc = 0; break; } -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Mar 04 10:57:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 10:57:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93151.175805 (Exim 4.92) (envelope-from ) id 1lHlfH-00007q-Dk; Thu, 04 Mar 2021 10:57:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93151.175805; Thu, 04 Mar 2021 10:57:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlfH-00007j-AX; Thu, 04 Mar 2021 10:57:07 +0000 Received: by outflank-mailman (input) for mailman id 93151; Thu, 04 Mar 2021 10:57:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlfF-00007e-0a for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 10:57:05 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 02ebc281-e0fe-47bc-b891-c7a2873f4d64; Thu, 04 Mar 2021 10:57:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02ebc281-e0fe-47bc-b891-c7a2873f4d64 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614855423; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=sBsmYgSrTxn2Q6M+cNiQJzrBURlwWGMyXNHpBNFF8Yw=; b=KjoNFUPU4Kk6heDIykcOTWNVBR5wlyOVxZA9hCO2+VyuoyxS16wKU7dv RAfiBKEMNSWsNST32xjCKcT6e0xJuE1z1zHmuRQ8G2iiXob8FZcFscYNd A1cJ/+BxLsgLjjuJ9lEqM7GTAuRQ8WEntJ/oqPej5c9wkVYPeTG2BCtTv Q=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 0ceMOUWtGyCb5D/IbUVr4gYcx2HGfeO2450FEidOk2dwlife9s4axOEwKSFgVq4LNEkc2qO9aj AtyQsv60PYjSoh2PRcUyuGKrddBoU6UpSgaLPvo+AgZ5uhy/3mI2CI8o1X9KmVa33HihyBAgoS 5yqX1RVh0YdhAC0n29q9yCVVotceO1dkMXnD3BG+iigYSO0wqpLk5HIJpESa/S54lbMKBsIMQQ Om5N22gy1vFwgijywqSfK31rTIyEadvWYKE1V5wnCXO4U8Wk8nv8nHXBMeJoSX5mVS+/SgqKSH CuQ= X-SBRS: 5.2 X-MesageID: 38533059 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,222,1610427600"; d="scan'208";a="38533059" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kSZ3ZABBApuoSYqArZrLrJUz515IBb6hk2363zoAwrY0K5EpXZOjefn5Vj7G/sPtAowsOaOvKC6XrEvMYGWPLoQaWWSFSruoWk+ZIBznYBLW5eAIRKRZXRFVWLh2PlGKaafGvmLttZ15tndvwJRPX4np/2ILw8rk+iTJByo2KQ1vSlSVSXcB7W464NfPM78NdR/EvQ2Yv3WLD3ILO7OyI0ede8o9QOF1AkxpXXhcBBYjm7bwIBiN137CnqkKtFRevtauwGbFy+Ymyz8BeELBjqJzrbbaTEZSZNONsbKoeI7PE1aeSaUJG/EWyE7+LOFMqfVfiO4wj+6BMwThoPraqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FpzA0SYDxh60NY7+SBP6DGL13PLo6Fn+q0ukRqOziFI=; b=SKAI3+XjDoz0RD5CgT6atVA/gXQXoCSMMOgtfi5RJJJcTLltLoUSBz/3m9iOQugGYXt6Dnt/LNQRpJCxLCx32v6/tYGgQe0LLKQ7yyfzLk8faMR7gBN1G/P0UfxwyVAev59M3y3eCbT1O2XohLB2EQI2NJSIEtPfLU1ezCDONSEls2P7Khcgy5eOh5M7x1L21lhcWttAkBAiy1LCYVaznZNd/O1aLodXWu23OHSOiawp68In4b/00qn6C5oeAo/Ok83n4Z0VSTaUKQkparKToXwjNuw7EdkyJkcjVRxvPtaxXrWvX+iXj6rI2Jgt/YlhzWKDVR3o+UG9M65kiUiFdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FpzA0SYDxh60NY7+SBP6DGL13PLo6Fn+q0ukRqOziFI=; b=NM4FUP07TiI0iOA8DMxSt5jCfb+GQL9eYwUIM852Bhuc0QtnCL9F0UastiJiWA0FjX6qz+WiUNn6+/uTgqjjSFYTD30myEvMrgRFex14sla7s2cW6vQr58p2nJxFDlEpSr03sPu1oT33ALfOBW0nPNRSLbhVLUJDnR/253CKsnE= Date: Thu, 4 Mar 2021 11:56:37 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Xen-devel , Jan Beulich , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Ian Jackson Subject: Re: [PATCH for-4.15] xen/dmop: Fix XEN_DMOP_nr_vcpus to actually return data Message-ID: References: <20210304104805.27601-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210304104805.27601-1-andrew.cooper3@citrix.com> X-ClientProxiedBy: PR3P195CA0029.EURP195.PROD.OUTLOOK.COM (2603:10a6:102:b6::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 67f38662-40bd-4df0-b356-08d8defc3262 X-MS-TrafficTypeDiagnostic: DM6PR03MB4971: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:901; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kuWyXy7JajhthSxMmpivi7Z4kzERGbtc/s7AZ8C6XuORjlPt3oUpaCGoJ77PXRPY56iWmvy5qzgJUAOUi7ep4lo+S0v4rAIEV6oTxhlq+IjZ94KjCwpYNKPiE+9Zej9+kfIrWtckYf0podsfxKh+XA/58ieCVqX2Rund0Q5wJbpLmjN5UGEEU8xtX+5L16KTiW+iM75OX78VttnJO2N9ar8T4GC0RpktH/vBXe0zLsEgpOri9m2CY+p1mRfgygH/f6W1PaINyxRysdlIoHOcxFQUP8C2QUoRPijA6HCkyxb3mGRzMmJRzt7fodWqotdI4JO6RSL8ULYitZMstW2uO49FqwdYN4o3ZoKMazUkRpdotSSRZVHq7O4OivVE5lrhoM1VEexzUMByTwV3OxalPfmStBFcbD0B7OONWKAaLMsNGqoa6YFE3nMlS7IfY5HQii4mNxNpDHfyb7u9iILEnLXWQQMXW/IfmkkBfQdG1/MUDTUb/1PkrE4ecZoptBnptfYr/tvEyJBjHs+/+ZH3PutGp8vBmx0e0iKb11teqFtiF14l8ulX9WPvQns7T30Z X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(136003)(366004)(396003)(376002)(346002)(39860400002)(6862004)(6486002)(54906003)(5660300002)(9686003)(956004)(4326008)(2906002)(6496006)(26005)(186003)(8676002)(478600001)(85182001)(8936002)(6636002)(86362001)(66556008)(6666004)(66946007)(316002)(16526019)(66476007)(33716001)(4744005)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VEp0U2lOakpZQk9ieS9sWkpBeVg2YWQ5YWVZU2dCUDlqSVdPaEhldVhvNGwy?= =?utf-8?B?MmpsaGNCbzF6ZGd3K2dCQWt4cDk2OG9hYklmTi8zcTVjVVpVQnFFSzFxOVZx?= =?utf-8?B?eGN6TmllWCtOeURiK1hoSjRDRWY4VkRSRStvc3ovYzNwRUgyelRzRlZjbzlq?= =?utf-8?B?T1piY01pWDF6TmwxL3BRT1ZGZXRvQkFiVG5TankwZTdMalk2NVlvOWFXS0Nh?= =?utf-8?B?WmFqKzZwSHdTQkxmSmpiZ3NpU3piL3RBSkNTQ2F1NE9VZG1nalg3VUF2THpI?= =?utf-8?B?czZIUjAvNUt4dWI4R0hmRFVTbTVoVDYvR3kvUmc2OTB5b2ZzaUUxVlRmNFFE?= =?utf-8?B?ZCtwQkh0MitHcHdqeHhHYnVQVkNhMTU1WklQVkVZbklncitoTW4wNXhWcTdB?= =?utf-8?B?c1Jyb0srUWZkdldWQTJIMXVkUks2SGpxNTY3cFlBaXJvMHdPT3BaQ1QxalIw?= =?utf-8?B?WFdIeEVGR1ZMdUtnQ0MzWVdHRkJJVng2bjN5dXhGNjR6TUc1L2Y0bkVLN2hX?= =?utf-8?B?OTFuZmx1UE84YXhVdGl6OEsvci9sK3VueWhkdjhBRGlhTDNPSm9iL05ab2hq?= =?utf-8?B?Q0lQbnk1aTk2bmRPMkNsQThtRE1lcFlQZXFpRTd1MTZKVGNmTTlreGNndExX?= =?utf-8?B?V3NneHAzTWJvdkdpeDk5dnFOZ1BjN1VrS3RmNTBtK0UyajIrcTNFU1lkbUE1?= =?utf-8?B?REZqYk5oN2ZlM2wwVUMrUDNtbWk4RGZaK2F4UmJ2MlhyTVlzUjdBcmJubE84?= =?utf-8?B?eFhOWExRcENtMmFhRmNueFMxRlVvK3UwMHd1UFRJaU1sSlRvUmRNMGdSVlJx?= =?utf-8?B?dXI2OTBKQmc4b0o1WDg2Rmk5WjZ3UDEyOUpFaThpL1NDNDVoSXBINlQ2RVN4?= =?utf-8?B?K0srZEFxV2VONDNTNWw2aXh2UlgrS3ZET1VnS05IdS8wSmJOaWI2bGFJR0Nx?= =?utf-8?B?RmtUUE1SL2NUaXNYcm81T1E0VU5UeU5YZmtZTG81NDBFYThaRWtSN3RXNHRi?= =?utf-8?B?YmpSUjBkZWlZRU9ZU0NEZFl3QWRENkdaZTVtTFBlS1hMeWNzRW9qbXhwTDd5?= =?utf-8?B?cmVIdjRGYmRQd3NDU1l0Vlp0bjhJNWNmcnFiQyt6RjBCY3JWTVVlWGs3VEpY?= =?utf-8?B?WEZ3bjQ0cU1Qck80WVgrSkJGREk0NHBSaDVrUStzZnY0V1NSblJtK2ErcEhy?= =?utf-8?B?SG10QUt5bHJXQ2JmNi9MQmk5ZjluaGxyK20wYWdrdXFjRjVYTVJnc0dydS9i?= =?utf-8?B?R1hlRXlnWnlublNseE4xa29Cb2NLaGhPOFRZUUFZbTUzMGUzaElOTXpyV2gx?= =?utf-8?B?Z1pjbTVIN0pyVDY3VzBDTktHMUY1eVhid0tOWGtNU3V6ZVVFRG00dDV1Y0hC?= =?utf-8?B?YzlRcUo0L3lxTzd3UDJ6N1RHSVI5YTFUcjVBUkZLV0FVM3duMGQ1UXhyeStL?= =?utf-8?B?Mjd3aDc0dFE4d1hDaGpPTXdUcXdXTGdwNWdUWVh3QjhJTmNOcFFGTFhCWUs3?= =?utf-8?B?em1CYkgybzlkOGRvcW9ocnVuQXJmQVpNSU1QVTZFcmVvRHhWU1ZLcEtPdGZH?= =?utf-8?B?SDBqWS9zZCthRk1RbkxVdGh4N0FJMTROMkV1MW9zcytKOXI0cTN2emY3QVRP?= =?utf-8?B?WmI0Q0RHblRxNjY3VS9saVV5REJwdVkwWjR0WksxT3dRUFpsWnRhL0NDOEJu?= =?utf-8?B?SHZ3WCtkdmVMdTFkZUdCa2Erb1NkN1pvMVIzeElLUmtqZUdXZ3NpVTk1NktF?= =?utf-8?Q?vWycs5+JbMe8+3DR21fI+KMm6o8fGnxg8bdTJDo?= X-MS-Exchange-CrossTenant-Network-Message-Id: 67f38662-40bd-4df0-b356-08d8defc3262 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 10:56:43.3121 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FxYjpItPQ94rGbK+4aG6etgH+CjcQiIyK3f72LoKW7y0uYP2qMbJ7MAzPne0lZiI97ZKX35WadWxf0OUu1IxIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4971 X-OriginatorOrg: citrix.com On Thu, Mar 04, 2021 at 10:48:05AM +0000, Andrew Cooper wrote: > The const_op boolean needs clobbering to cause data to be written back to the > caller. > > Fixes: c4441ab1f1 ("dmop: Add XEN_DMOP_nr_vcpus") > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 04 10:58:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 10:58:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93158.175852 (Exim 4.92) (envelope-from ) id 1lHlgf-0000K4-Gs; Thu, 04 Mar 2021 10:58:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93158.175852; Thu, 04 Mar 2021 10:58:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlgf-0000Jv-CQ; Thu, 04 Mar 2021 10:58:33 +0000 Received: by outflank-mailman (input) for mailman id 93158; Thu, 04 Mar 2021 10:58:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlge-0000EB-2x for xen-devel@lists.xen.org; Thu, 04 Mar 2021 10:58:32 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 49a6fae3-d2a5-4eaf-90f4-e1164d2812c4; Thu, 04 Mar 2021 10:58:16 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlgJ-0000v8-Qb; Thu, 04 Mar 2021 10:58:11 +0000 Received: from iwj by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHlgJ-0003KK-Ms; Thu, 04 Mar 2021 10:58:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49a6fae3-d2a5-4eaf-90f4-e1164d2812c4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=9//W9NVX0OPw4RURgTZOd9DdR5TW685wHuUJYEASpTA=; b=boeON9A0IU4UYFlMt57H2R5tPx /zVYJKzXqEuKmYwn5g27xheTjrHiRO7YohfblG50cUIzgFMEWZuZ4C+TcI8gI7lVcyEgwEjqhABvD /i3jb/HKsIJhHyIEyJYOs2bq1fkwoXwgEb6yw5fsoWM45/VARHeN7FfucR//kiIZ5nTs=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 369 v1 - Linux: special config may crash when trying to map foreign pages Message-Id: Date: Thu, 04 Mar 2021 10:58:11 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory XSA-369 Linux: special config may crash when trying to map foreign pages ISSUE DESCRIPTION ================= With CONFIG_XEN_BALLOON_MEMORY_HOTPLUG disabled and CONFIG_XEN_UNPOPULATED_ALLOC enabled the Linux kernel will use guest physical addresses allocated via the ZONE_DEVICE functionality for mapping foreign guest's pages. This will result in problems, as the p2m list will only cover the initial memory size of the domain plus some padding at the end. Most ZONE_DEVICE allocated addresses will be outside the p2m range and thus a mapping can't be established with those memory addresses, resulting in a crash. The attack involves doing I/O requiring large amounts of data to be mapped by the Dom0 or driver domain. The amount of data needed to result in a crash can vary depending on the memory layout of the affected Dom0 or driver domain. IMPACT ====== A Dom0 or driver domain based on a Linux kernel (configured as described above) can be crashed by a malicious guest administrator, or possibly malicious unprivileged guest processes. VULNERABLE SYSTEMS ================== Only x86 paravirtualized (PV) Dom0 or driver domains are affected. Only Linux kernels configured *with* CONFIG_XEN_UNPOPULATED_ALLOC and *without* CONFIG_XEN_BALLOON_MEMORY_HOTPLUG are vulnerable. Only kernels from kernel version 5.9 onwards are affected. CONFIG_XEN_BALLOON_MEMORY_HOTPLUG is enabled by default in upstream Linux when Xen support is enabled, so kernels using upstream default Kconfig are not affected. Most distribution kernels supporting Xen dom0 use are likewise not vulnerable. Arm systems or x86 PVH or x86 HVM driver domains are not affected. MITIGATION ========== There is no mitigation available. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. xsa369-linux.patch Linux 5.9-stable - 5.12-rc $ sha256sum xsa369* 937df4f078a070cf47bdd718c6b8a042ec6bee255eedc422d833c2ae3dd561c7 xsa369-linux.patch $ CREDITS ======= This issue was discovered by Marek Marczykowski-Górecki of Invisible Things Lab. For patch: Reported-by: Marek Marczykowski-Górecki NOTE REGARDING LACK OF EMBARGO ============================== This was reported publicly multiple times, before the XSA could be issued. -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmBAvMQMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZ5PoH/2EY28X1Fe+2RW5SrnAo2dZWLXeIrXQIXbsDCdlI GKhFChUhYHJP3wLhE4F7J5SAjl48ta/gtdpbpJWXsZSS+2KIdV/dDZ3ZA6cxWFAI DuVvqqt5O0xpF02bgTZrL1GUL8975L0O7cwtGmsIbPjVSF5UktuLS0Q1zRAiYvG9 l5Xu32nekxz2fGebMYrJTIPYNc8LOg3d+MIAE4W1u3Wj46S8yRJhyNQmsPQXZTEk nlTp0ed8ScAt7pIZn7dbnLz8zUAQ64h2yar0UBih51kd3Bss5E4PXsS0zlXlVNfk 046nBhbFfB3dgM49NlJ3oHhiZh6dN5LpMblmGK4Tb+FJqNE= =QwG+ -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa369-linux.patch" Content-Disposition: attachment; filename="xsa369-linux.patch" Content-Transfer-Encoding: base64 RnJvbTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpTdWJqZWN0 OiB4ZW46IGZpeCBwMm0gc2l6ZSBpbiBkb20wIGZvciBkaXNhYmxlZCBtZW1v cnkgaG90cGx1ZyBjYXNlCgpTaW5jZSBjb21taXQgOWUyMzY5YzA2YzhhMTgg KCJ4ZW46IGFkZCBoZWxwZXJzIHRvIGFsbG9jYXRlIHVucG9wdWxhdGVkCm1l bW9yeSIpIGZvcmVpZ24gbWFwcGluZ3MgYXJlIHVzaW5nIGd1ZXN0IHBoeXNp Y2FsIGFkZHJlc3NlcyBhbGxvY2F0ZWQKdmlhIFpPTkVfREVWSUNFIGZ1bmN0 aW9uYWxpdHkuCgpUaGlzIHdpbGwgcmVzdWx0IGluIHByb2JsZW1zIGZvciB0 aGUgY2FzZSBvZiBubyBiYWxsb29uIG1lbW9yeSBob3RwbHVnCmJlaW5nIGNv bmZpZ3VyZWQsIGFzIHRoZSBwMm0gbGlzdCB3aWxsIG9ubHkgY292ZXIgdGhl IGluaXRpYWwgbWVtb3J5CnNpemUgb2YgdGhlIGRvbWFpbi4gQW55IFpPTkVf REVWSUNFIGFsbG9jYXRlZCBhZGRyZXNzIHdpbGwgYmUgb3V0c2lkZQp0aGUg cDJtIHJhbmdlIGFuZCB0aHVzIGEgbWFwcGluZyBjYW4ndCBiZSBlc3RhYmxp c2hlZCB3aXRoIHRoYXQgbWVtb3J5CmFkZHJlc3MuCgpGaXggdGhhdCBieSBl eHRlbmRpbmcgdGhlIHAybSBzaXplIGZvciB0aGF0IGNhc2UuIEF0IHRoZSBz YW1lIHRpbWUgYWRkCmEgY2hlY2sgZm9yIGEgdG8gYmUgY3JlYXRlZCBtYXBw aW5nIHRvIGJlIHdpdGhpbiB0aGUgcDJtIGxpbWl0cyBpbgpvcmRlciB0byBk ZXRlY3QgZXJyb3JzIGVhcmx5LgoKV2hpbGUgY2hhbmdpbmcgYSBjb21tZW50 LCByZW1vdmUgc29tZSAzMi1iaXQgbGVmdG92ZXJzLgoKVGhpcyBpcyBYU0Et MzY5LgoKRml4ZXM6IDllMjM2OWMwNmM4YTE4ICgieGVuOiBhZGQgaGVscGVy cyB0byBhbGxvY2F0ZSB1bnBvcHVsYXRlZCBtZW1vcnkiKQpDYzogPHN0YWJs ZUB2Z2VyLmtlcm5lbC5vcmc+ICMgNS45ClJlcG9ydGVkLWJ5OiBNYXJlayBN YXJjenlrb3dza2ktR8OzcmVja2kgPG1hcm1hcmVrQGludmlzaWJsZXRoaW5n c2xhYi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj aEBzdXNlLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdy b3NzQHN1c2UuY29tPgotLS0KIGFyY2gveDg2L2luY2x1ZGUvYXNtL3hlbi9w YWdlLmggfCAxMiArKysrKysrKysrKysKIGFyY2gveDg2L3hlbi9wMm0uYyAg ICAgICAgICAgICAgfCAxMCArKysrKystLS0tCiBhcmNoL3g4Ni94ZW4vc2V0 dXAuYyAgICAgICAgICAgIHwgMjUgKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQogMyBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCAyNiBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9hcmNoL3g4Ni9pbmNsdWRlL2FzbS94 ZW4vcGFnZS5oIGIvYXJjaC94ODYvaW5jbHVkZS9hc20veGVuL3BhZ2UuaApp bmRleCAxYTE2MmU1NTk3NTMuLjcwNjhlNGJiMDU3ZCAxMDA2NDQKLS0tIGEv YXJjaC94ODYvaW5jbHVkZS9hc20veGVuL3BhZ2UuaAorKysgYi9hcmNoL3g4 Ni9pbmNsdWRlL2FzbS94ZW4vcGFnZS5oCkBAIC04Niw2ICs4NiwxOCBAQCBj bGVhcl9mb3JlaWduX3AybV9tYXBwaW5nKHN0cnVjdCBnbnR0YWJfdW5tYXBf Z3JhbnRfcmVmICp1bm1hcF9vcHMsCiB9CiAjZW5kaWYKIAorLyoKKyAqIFRo ZSBtYXhpbXVtIGFtb3VudCBvZiBleHRyYSBtZW1vcnkgY29tcGFyZWQgdG8g dGhlIGJhc2Ugc2l6ZS4gIFRoZQorICogbWFpbiBzY2FsaW5nIGZhY3RvciBp cyB0aGUgc2l6ZSBvZiBzdHJ1Y3QgcGFnZS4gIEF0IGV4dHJlbWUgcmF0aW9z CisgKiBvZiBiYXNlOmV4dHJhLCBhbGwgdGhlIGJhc2UgbWVtb3J5IGNhbiBi ZSBmaWxsZWQgd2l0aCBwYWdlCisgKiBzdHJ1Y3R1cmVzIGZvciB0aGUgZXh0 cmEgbWVtb3J5LCBsZWF2aW5nIG5vIHNwYWNlIGZvciBhbnl0aGluZworICog ZWxzZS4KKyAqCisgKiAxMHggc2VlbXMgbGlrZSBhIHJlYXNvbmFibGUgYmFs YW5jZSBiZXR3ZWVuIHNjYWxpbmcgZmxleGliaWxpdHkgYW5kCisgKiBsZWF2 aW5nIGEgcHJhY3RpY2FsbHkgdXNhYmxlIHN5c3RlbS4KKyAqLworI2RlZmlu ZSBYRU5fRVhUUkFfTUVNX1JBVElPCSgxMCkKKwogLyoKICAqIEhlbHBlciBm dW5jdGlvbnMgdG8gd3JpdGUgb3IgcmVhZCB1bnNpZ25lZCBsb25nIHZhbHVl cyB0by9mcm9tCiAgKiBtZW1vcnksIHdoZW4gdGhlIGFjY2VzcyBtYXkgZmF1 bHQuCmRpZmYgLS1naXQgYS9hcmNoL3g4Ni94ZW4vcDJtLmMgYi9hcmNoL3g4 Ni94ZW4vcDJtLmMKaW5kZXggOTU0NWI4ZGY1MzE1Li5lZDM1ODVlZWJjNGUg MTAwNjQ0Ci0tLSBhL2FyY2gveDg2L3hlbi9wMm0uYworKysgYi9hcmNoL3g4 Ni94ZW4vcDJtLmMKQEAgLTQxNiw2ICs0MTYsOSBAQCB2b2lkIF9faW5pdCB4 ZW5fdm1hbGxvY19wMm1fdHJlZSh2b2lkKQogCXhlbl9wMm1fbGFzdF9wZm4g PSB4ZW5fbWF4X3AybV9wZm47CiAKIAlwMm1fbGltaXQgPSAocGh5c19hZGRy X3QpUDJNX0xJTUlUICogMTAyNCAqIDEwMjQgKiAxMDI0IC8gUEFHRV9TSVpF OworCWlmICghcDJtX2xpbWl0ICYmIElTX0VOQUJMRUQoQ09ORklHX1hFTl9V TlBPUFVMQVRFRF9BTExPQykpCisJCXAybV9saW1pdCA9IHhlbl9zdGFydF9p bmZvLT5ucl9wYWdlcyAqIFhFTl9FWFRSQV9NRU1fUkFUSU87CisKIAl2bS5m bGFncyA9IFZNX0FMTE9DOwogCXZtLnNpemUgPSBBTElHTihzaXplb2YodW5z aWduZWQgbG9uZykgKiBtYXgoeGVuX21heF9wMm1fcGZuLCBwMm1fbGltaXQp LAogCQkJUE1EX1NJWkUgKiBQTURTX1BFUl9NSURfUEFHRSk7CkBAIC02NTIs MTAgKzY1NSw5IEBAIGJvb2wgX19zZXRfcGh5c190b19tYWNoaW5lKHVuc2ln bmVkIGxvbmcgcGZuLCB1bnNpZ25lZCBsb25nIG1mbikKIAlwdGVfdCAqcHRl cDsKIAl1bnNpZ25lZCBpbnQgbGV2ZWw7CiAKLQlpZiAodW5saWtlbHkocGZu ID49IHhlbl9wMm1fc2l6ZSkpIHsKLQkJQlVHX09OKG1mbiAhPSBJTlZBTElE X1AyTV9FTlRSWSk7Ci0JCXJldHVybiB0cnVlOwotCX0KKwkvKiBPbmx5IGlu dmFsaWQgZW50cmllcyBhbGxvd2VkIGFib3ZlIHRoZSBoaWdoZXN0IHAybSBj b3ZlcmVkIGZyYW1lLiAqLworCWlmICh1bmxpa2VseShwZm4gPj0geGVuX3Ay bV9zaXplKSkKKwkJcmV0dXJuIG1mbiA9PSBJTlZBTElEX1AyTV9FTlRSWTsK IAogCS8qCiAJICogVGhlIGludGVyZmFjZSByZXF1aXJlcyBhdG9taWMgdXBk YXRlcyBvbiBwMm0gZWxlbWVudHMuCmRpZmYgLS1naXQgYS9hcmNoL3g4Ni94 ZW4vc2V0dXAuYyBiL2FyY2gveDg2L3hlbi9zZXR1cC5jCmluZGV4IDdlYWIx NGQ1NjM2OS4uMWEzYjc1NjUyZmE0IDEwMDY0NAotLS0gYS9hcmNoL3g4Ni94 ZW4vc2V0dXAuYworKysgYi9hcmNoL3g4Ni94ZW4vc2V0dXAuYwpAQCAtNTks MTggKzU5LDYgQEAgc3RhdGljIHN0cnVjdCB7CiB9IHhlbl9yZW1hcF9idWYg X19pbml0ZGF0YSBfX2FsaWduZWQoUEFHRV9TSVpFKTsKIHN0YXRpYyB1bnNp Z25lZCBsb25nIHhlbl9yZW1hcF9tZm4gX19pbml0ZGF0YSA9IElOVkFMSURf UDJNX0VOVFJZOwogCi0vKiAKLSAqIFRoZSBtYXhpbXVtIGFtb3VudCBvZiBl eHRyYSBtZW1vcnkgY29tcGFyZWQgdG8gdGhlIGJhc2Ugc2l6ZS4gIFRoZQot ICogbWFpbiBzY2FsaW5nIGZhY3RvciBpcyB0aGUgc2l6ZSBvZiBzdHJ1Y3Qg cGFnZS4gIEF0IGV4dHJlbWUgcmF0aW9zCi0gKiBvZiBiYXNlOmV4dHJhLCBh bGwgdGhlIGJhc2UgbWVtb3J5IGNhbiBiZSBmaWxsZWQgd2l0aCBwYWdlCi0g KiBzdHJ1Y3R1cmVzIGZvciB0aGUgZXh0cmEgbWVtb3J5LCBsZWF2aW5nIG5v IHNwYWNlIGZvciBhbnl0aGluZwotICogZWxzZS4KLSAqIAotICogMTB4IHNl ZW1zIGxpa2UgYSByZWFzb25hYmxlIGJhbGFuY2UgYmV0d2VlbiBzY2FsaW5n IGZsZXhpYmlsaXR5IGFuZAotICogbGVhdmluZyBhIHByYWN0aWNhbGx5IHVz YWJsZSBzeXN0ZW0uCi0gKi8KLSNkZWZpbmUgRVhUUkFfTUVNX1JBVElPCQko MTApCi0KIHN0YXRpYyBib29sIHhlbl81MTJnYl9saW1pdCBfX2luaXRkYXRh ID0gSVNfRU5BQkxFRChDT05GSUdfWEVOXzUxMkdCKTsKIAogc3RhdGljIHZv aWQgX19pbml0IHhlbl9wYXJzZV81MTJnYih2b2lkKQpAQCAtNzkwLDIwICs3 NzgsMTMgQEAgY2hhciAqIF9faW5pdCB4ZW5fbWVtb3J5X3NldHVwKHZvaWQp CiAJCWV4dHJhX3BhZ2VzICs9IG1heF9wYWdlcyAtIG1heF9wZm47CiAKIAkv KgotCSAqIENsYW1wIHRoZSBhbW91bnQgb2YgZXh0cmEgbWVtb3J5IHRvIGEg RVhUUkFfTUVNX1JBVElPCi0JICogZmFjdG9yIHRoZSBiYXNlIHNpemUuICBP biBub24taGlnaG1lbSBzeXN0ZW1zLCB0aGUgYmFzZQotCSAqIHNpemUgaXMg dGhlIGZ1bGwgaW5pdGlhbCBtZW1vcnkgYWxsb2NhdGlvbjsgb24gaGlnaG1l bSBpdAotCSAqIGlzIGxpbWl0ZWQgdG8gdGhlIG1heCBzaXplIG9mIGxvd21l bSwgc28gdGhhdCBpdCBkb2Vzbid0Ci0JICogZ2V0IGNvbXBsZXRlbHkgZmls bGVkLgorCSAqIENsYW1wIHRoZSBhbW91bnQgb2YgZXh0cmEgbWVtb3J5IHRv IGEgWEVOX0VYVFJBX01FTV9SQVRJTworCSAqIGZhY3RvciB0aGUgYmFzZSBz aXplLgogCSAqCiAJICogTWFrZSBzdXJlIHdlIGhhdmUgbm8gbWVtb3J5IGFi b3ZlIG1heF9wYWdlcywgYXMgdGhpcyBhcmVhCiAJICogaXNuJ3QgaGFuZGxl ZCBieSB0aGUgcDJtIG1hbmFnZW1lbnQuCi0JICoKLQkgKiBJbiBwcmluY2lw bGUgdGhlcmUgY291bGQgYmUgYSBwcm9ibGVtIGluIGxvd21lbSBzeXN0ZW1z IGlmCi0JICogdGhlIGluaXRpYWwgbWVtb3J5IGlzIGFsc28gdmVyeSBsYXJn ZSB3aXRoIHJlc3BlY3QgdG8KLQkgKiBsb3dtZW0sIGJ1dCB3ZSB3b24ndCB0 cnkgdG8gZGVhbCB3aXRoIHRoYXQgaGVyZS4KIAkgKi8KLQlleHRyYV9wYWdl cyA9IG1pbjMoRVhUUkFfTUVNX1JBVElPICogbWluKG1heF9wZm4sIFBGTl9E T1dOKE1BWE1FTSkpLAorCWV4dHJhX3BhZ2VzID0gbWluMyhYRU5fRVhUUkFf TUVNX1JBVElPICogbWluKG1heF9wZm4sIFBGTl9ET1dOKE1BWE1FTSkpLAog CQkJICAgZXh0cmFfcGFnZXMsIG1heF9wYWdlcyAtIG1heF9wZm4pOwogCWkg PSAwOwogCWFkZHIgPSB4ZW5fZTgyMF90YWJsZS5lbnRyaWVzWzBdLmFkZHI7 Ci0tIAoyLjI2LjIKCg== --=separator-- From xen-devel-bounces@lists.xenproject.org Thu Mar 04 10:58:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 10:58:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93160.175864 (Exim 4.92) (envelope-from ) id 1lHlgo-0000Qe-Pq; Thu, 04 Mar 2021 10:58:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93160.175864; Thu, 04 Mar 2021 10:58:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlgo-0000QV-MO; Thu, 04 Mar 2021 10:58:42 +0000 Received: by outflank-mailman (input) for mailman id 93160; Thu, 04 Mar 2021 10:58:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlgn-0000Ph-UY for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 10:58:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 910c1d67-2e59-4f61-a71d-223a7a070051; Thu, 04 Mar 2021 10:58:40 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8A70AAAC5; Thu, 4 Mar 2021 10:58:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 910c1d67-2e59-4f61-a71d-223a7a070051 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614855519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I5w785pZDJPZh6Oa1/lqNKxccSspHQkiAPaH+D6nh4U=; b=Zt1DTCMpLYBqYj+d9cmRJgoZZ+ERGZphYeE4LWSBCoJI4MzM1X11Z993inyNFzoXa/z2mG MM8oKfu1SbOiOcB2s77Eud0ZH6GrSiNeWFb4gZ2qZ2J5QnKam2ul53BmCrpXqE6Z7FY6pQ rlG2oN7GoItTVl0oxd5FRArZTlNXA5U= Subject: Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , Anthony PERARD , Jun Nakajima , Kevin Tian , Boris Ostrovsky , xen-devel@lists.xenproject.org, Ian Jackson References: <20210301162357.76527-1-roger.pau@citrix.com> <62be2084-e5fa-e439-8426-6d129a10c379@suse.com> From: Jan Beulich Message-ID: <7e9ac991-f575-aa92-5fd8-33c8193cad67@suse.com> Date: Thu, 4 Mar 2021 11:58:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 04.03.2021 11:05, Roger Pau Monné wrote: > On Thu, Mar 04, 2021 at 09:48:25AM +0100, Jan Beulich wrote: >> On 03.03.2021 16:38, Roger Pau Monné wrote: >>> It also raises the question whether we will allow any more exceptions >>> to the MSR policy, like we did for Windows and OpenBSD in: >>> >>> http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=ca88a43e660c75796656a544e54a648c60d26ef0 >>> http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=4175fd3ccd17face664036fa98e9329aa317f7b6 >>> >>> Or if we are just going to require those guests to enable the legacy >>> MSR handling instead. >> >> It is my understanding that Andrew's view is that adding such special >> cases is the only acceptable thing. As voiced before I don't share >> this view, as it means we're going to be entirely reactive to people >> reporting issues, when I think we should be pro-active as far as is >> reasonable. Independent of any pro-active measures there'll still be >> enough reasons for reactive changes - for example I assume Linux >> would now issue the log message from >> >> if (cpu_has(c, X86_FEATURE_CONSTANT_TSC)) { >> >> if (c->x86 > 0x10 || >> (c->x86 == 0x10 && c->x86_model >= 0x2)) { >> u64 val; >> >> rdmsrl(MSR_K7_HWCR, val); >> if (!(val & BIT(24))) >> pr_warn(FW_BUG "TSC doesn't count with P0 frequency!\n"); >> } >> } >> >> since we surface a zero value right now (but I didn't verify this in >> practice yet). > > I think we inject a #GP to the guest if it tries to access > MSR_K7_HWCR? As I don't see this MSR handled explicitly in > svm_msr_read_intercept. So Linux would complain from the unchecked MSR > access and the MSR value not having the bit set. Right - my description was of the behavior with my workaround already in place. > This one seems like a fine candidate to implement in > svm_msr_read_intercept, because Xen needs to return a specific value > for this MSR. > > Regarding the global approach to fixing the fallout from the MSR > policy change, I don't see why we couldn't do a mix between pro-active > and reactive. > > I think we must have an option to fallback to something similar to the > old policy for HVM guests so that users have a way to get their guests > running after an update without requiring a code change. > > That doesn't mean we can't reactively add the missing MSRs as we go > discovering them. I would even print a warning when using such > fallback legacy MSR handling option that you need to report the issue > to xen-devel because the option might be removed in future releases. > > Does the above seem like a sensible plan? I think so, yes. I wonder what Andrew thinks, though. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 04 11:00:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 11:00:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93189.175876 (Exim 4.92) (envelope-from ) id 1lHliz-0001fp-E5; Thu, 04 Mar 2021 11:00:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93189.175876; Thu, 04 Mar 2021 11:00:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHliz-0001fi-9M; Thu, 04 Mar 2021 11:00:57 +0000 Received: by outflank-mailman (input) for mailman id 93189; Thu, 04 Mar 2021 11:00:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHlix-0001fX-Io for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 11:00:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dfdf0f78-ddf7-47c3-8db2-f60b05fa3060; Thu, 04 Mar 2021 11:00:55 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2F411AE1F; Thu, 4 Mar 2021 11:00:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfdf0f78-ddf7-47c3-8db2-f60b05fa3060 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614855654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=WXqHPe+Ifnv5Vf7F0Ne6BsKMUPRrUe3g+NOcm0DY8Po=; b=Wb2k58m2tPyw8HJWGN4OpsnluwahwTkXLlCH83ups3omce9KolKDdUZKnr/01mnQARefe6 zdjprHYQ/al8PYmwTYY3Rq8ttMQj/0SNMlm663huu2nT5pLiph5X/3ZaxSkSR750/lMIrJ 7ERgKTScfUWv8MxgMKMRzBnsI93uAhQ= From: Juergen Gross To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com Subject: [GIT PULL] xen: branch for v5.12-rc2 Date: Thu, 4 Mar 2021 12:00:53 +0100 Message-Id: <20210304110053.8787-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.12b-rc2-tag xen: branch for v5.12-rc2 It contains fixes for 2 security issues (XSA-367 and XSA-369). Thanks. Juergen arch/arm/xen/p2m.c | 35 ++++++++++++++++++++++--- arch/x86/include/asm/xen/page.h | 12 +++++++++ arch/x86/xen/p2m.c | 54 ++++++++++++++++++++++++++++++++++----- arch/x86/xen/setup.c | 25 +++--------------- drivers/net/xen-netback/netback.c | 12 ++++++++- 5 files changed, 104 insertions(+), 34 deletions(-) Jan Beulich (2): Xen/gnttab: handle p2m update errors on a per-slot basis xen-netback: respect gnttab_map_refs()'s return value Juergen Gross (1): xen: fix p2m size in dom0 for disabled memory hotplug case From xen-devel-bounces@lists.xenproject.org Thu Mar 04 11:22:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 11:22:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93208.175888 (Exim 4.92) (envelope-from ) id 1lHm3E-0003u8-65; Thu, 04 Mar 2021 11:21:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93208.175888; Thu, 04 Mar 2021 11:21:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHm3E-0003u1-2W; Thu, 04 Mar 2021 11:21:52 +0000 Received: by outflank-mailman (input) for mailman id 93208; Thu, 04 Mar 2021 11:21:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHm3C-0003tw-9f for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 11:21:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHm3C-0001Lz-4b for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 11:21:50 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHm3C-0006yO-3f for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 11:21:50 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHm2y-00050F-TZ; Thu, 04 Mar 2021 11:21:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=xsQlyatzXrok8XO8ymfSBI8MKz1Bcgiyw9bZ+/YS5qg=; b=eNXFTkksJp1G6AqwrikeHx/vzd Z1ffECpBG3Ddw67dRwipNtS7IkrK5YhxbMp422VfQmaonOjnibetrQ1Cr7hdmvr1PUn9YFr5CXyHX XLQEmxRnv+NZWPmt1pXWWYKO+uHO/BUaItodT1QjtCNgjb2NH7WicxAoB6Bs21wTlgSE=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24640.49856.639416.385729@mariner.uk.xensource.com> Date: Thu, 4 Mar 2021 11:21:36 +0000 To: Jan Beulich Cc: Julien Grall , Charles Arnold , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel\@lists.xenproject.org" Subject: Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11 In-Reply-To: <1e625665-7a14-a1f6-5b93-cac6e3640c1f@suse.com> References: <05fe3295-7993-2eb5-37bc-a6d04fde1fbc@suse.com> <7e0584ab-8923-cb59-fac2-c2908d736f0c@xen.org> <1e625665-7a14-a1f6-5b93-cac6e3640c1f@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11"): > On 03.03.2021 20:09, Julien Grall wrote: > > On 01/03/2021 07:57, Jan Beulich wrote: > >> The upcoming release complains, not entirely unreasonably: > >> > >> In file included from rijndael.c:33: > >> .../xen/include/crypto/rijndael.h:55:53: note: previously declared as 'const unsigned char[]' > >> 55 | void rijndaelEncrypt(const unsigned int [], int, const unsigned char [], > >> | ^~~~~~~~~~~~~~~~~~~~~~ > >> rijndael.c:865:8: error: argument 4 of type 'u8[16]' {aka 'unsigned char[16]'} with mismatched bound [-Werror=array-parameter=] > >> 865 | u8 ct[16]) I think this is an erroneous compiler warning. It has been idiomatic in some codebases for a long time to write const unsigned char[] as a formal parameter for an array (of whatever size). > >> .../xen/include/xen/string.h:101:27: error: '__builtin_memcmp' specified bound 4 exceeds source size 0 [-Werror=stringop-overread] > >> 101 | #define memcmp(s1, s2, n) __builtin_memcmp(s1, s2, n) > >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> mpparse.c:722:13: note: in expansion of macro 'memcmp' > >> 722 | if (memcmp(mpf->mpf_signature, "_MP_", 4) == 0 && > >> | ^~~~~~ > >> > >> Clearly neither the 1st nor the 2nd argument have a "source size" of 0. > > > > It looks like there is a report on the redhat bug tracker for it [1]. Do > > you know if there is a bug report on the GCC tracker as well? > > I have no idea, to be honest. This erroneous message makes me think that there is simply a bug in this version of GCC, where formal parameters declared as const unsigned char[] are treated as const unsigned char[0] rather than as const unsigned char* Ian. From xen-devel-bounces@lists.xenproject.org Thu Mar 04 11:24:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 11:24:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93211.175900 (Exim 4.92) (envelope-from ) id 1lHm6D-00041z-LK; Thu, 04 Mar 2021 11:24:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93211.175900; Thu, 04 Mar 2021 11:24:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHm6D-00041s-I0; Thu, 04 Mar 2021 11:24:57 +0000 Received: by outflank-mailman (input) for mailman id 93211; Thu, 04 Mar 2021 11:24:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHm6B-00041n-TV for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 11:24:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHm6B-0001Of-Sk for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 11:24:55 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHm6B-0007Hs-S2 for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 11:24:55 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHm5y-00050y-78; Thu, 04 Mar 2021 11:24:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=PcE0OBT03GbBGogYo4Yi9bdSbXqeF8kmUyHeV8im1GI=; b=u2NJsczXWqPLU03Pf/sTOHo9eL Cy4dOU5sO0GWxtZ0I6ia4Gv4OKDvdnDOdERuFTiKAgHSBXV9iQNwOGhjwxvQDOfW8XIayjs1b5kQ0 IJdsuYM5qKLUG+AH5/IEeaGCIqyIWuMpEybw2GnpZegHVNv6WKBzka62x3XSKB4ntWxQ=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24640.50041.969590.549237@mariner.uk.xensource.com> Date: Thu, 4 Mar 2021 11:24:41 +0000 To: Jan Beulich Cc: Roger Pau =?iso-8859-1?Q?Monn=E9?= , Andrew Cooper , Wei Liu , Anthony PERARD , Jun Nakajima , Kevin Tian , Boris Ostrovsky , xen-devel@lists.xenproject.org Subject: Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection In-Reply-To: <7e9ac991-f575-aa92-5fd8-33c8193cad67@suse.com> References: <20210301162357.76527-1-roger.pau@citrix.com> <62be2084-e5fa-e439-8426-6d129a10c379@suse.com> <7e9ac991-f575-aa92-5fd8-33c8193cad67@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection"): > On 04.03.2021 11:05, Roger Pau Monn wrote: ... > > This one seems like a fine candidate to implement in > > svm_msr_read_intercept, because Xen needs to return a specific value > > for this MSR. > > > > Regarding the global approach to fixing the fallout from the MSR > > policy change, I don't see why we couldn't do a mix between pro-active > > and reactive. > > > > I think we must have an option to fallback to something similar to the > > old policy for HVM guests so that users have a way to get their guests > > running after an update without requiring a code change. > > > > That doesn't mean we can't reactively add the missing MSRs as we go > > discovering them. I would even print a warning when using such > > fallback legacy MSR handling option that you need to report the issue > > to xen-devel because the option might be removed in future releases. > > > > Does the above seem like a sensible plan? > > I think so, yes. I wonder what Andrew thinks, though. FTR I am on board with this plan. I would like to see quick progress on this issue as it seems like one of the major risks in the release. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Thu Mar 04 11:31:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 11:31:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93214.175912 (Exim 4.92) (envelope-from ) id 1lHmCj-000547-Eq; Thu, 04 Mar 2021 11:31:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93214.175912; Thu, 04 Mar 2021 11:31:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHmCj-000540-AY; Thu, 04 Mar 2021 11:31:41 +0000 Received: by outflank-mailman (input) for mailman id 93214; Thu, 04 Mar 2021 11:31:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHmCi-00053t-Pm for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 11:31:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHmCh-0001VJ-Q1; Thu, 04 Mar 2021 11:31:39 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lHmCh-0007bI-Ez; Thu, 04 Mar 2021 11:31:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=/l7up3m4WXyABM2TrZc5O5gr85g7Q8Xd8tdHAP1m9Rs=; b=DtQGRXXjUjgem46HeEcR+juwi6 yAA9C6LFtWROT3n9xzm79gp399K0hyRhsEm8VHdd5QP2SJ9bZ/eO2IT7BN8Vyp4Y5M/BFXtzwbcgK RIoBygw1zFYixjpAmmqW4LmlMb0hxiCuWgSKkX1GgiNUXwcYfriXhuzXiZ1V7a1bBiBc=; Subject: Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11 To: Jan Beulich , Charles Arnold Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <05fe3295-7993-2eb5-37bc-a6d04fde1fbc@suse.com> <7e0584ab-8923-cb59-fac2-c2908d736f0c@xen.org> <1e625665-7a14-a1f6-5b93-cac6e3640c1f@suse.com> From: Julien Grall Message-ID: <820bfbcc-8c9d-1059-b5a8-e8603cb95d45@xen.org> Date: Thu, 4 Mar 2021 11:31:37 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1e625665-7a14-a1f6-5b93-cac6e3640c1f@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 04/03/2021 08:06, Jan Beulich wrote: > On 03.03.2021 20:09, Julien Grall wrote: >> On 01/03/2021 07:57, Jan Beulich wrote: >>> The upcoming release complains, not entirely unreasonably: >>> >>> In file included from rijndael.c:33: >>> .../xen/include/crypto/rijndael.h:55:53: note: previously declared as 'const unsigned char[]' >>> 55 | void rijndaelEncrypt(const unsigned int [], int, const unsigned char [], >>> | ^~~~~~~~~~~~~~~~~~~~~~ >>> rijndael.c:865:8: error: argument 4 of type 'u8[16]' {aka 'unsigned char[16]'} with mismatched bound [-Werror=array-parameter=] >>> 865 | u8 ct[16]) >>> | ~~~^~~~~~ >>> In file included from rijndael.c:33: >>> .../xen/include/crypto/rijndael.h:56:13: note: previously declared as 'unsigned char[]' >>> 56 | unsigned char []); >>> | ^~~~~~~~~~~~~~~~ >>> >>> While it's not really clear to me why it would complain only for arg 4, >>> the adjustment to make is obvious and riskfree also for arg 3: Simply >>> declare the correct array dimension right away. This then allows >>> compilers to apply checking at call sites, which seems desirable anyway. >> >> I am a bit confused, if GCC is not complaining for arg3, then what is >> the following error message for: >> >> > In file included from rijndael.c:33: >> > .../xen/include/crypto/rijndael.h:55:53: note: previously declared as >> 'const unsigned char[]' >> > 55 | void rijndaelEncrypt(const unsigned int [], int, const >> unsigned char [], >> > | >> ^~~~~~~~~~~~~~~~~~~~~~ > > Hmm, good point. I didn't observe this myself, and simply copied the > part of the error message that I was handed. I suppose there was an > "error: argument 3 of type ..." there then as well. Charles - any > chance you could confirm this, and perhaps even quote the full set > of error messages in our internal patch? > > I'll adjust the wording of the description in any event. With the description adjusted: Reviewed-by: Julien Grall > >>> There are quite a few more issues with gcc11, but from my brief initial >>> inspection I'm suspecting (hoping) it'll rather be the compiler which >>> will get further changed by the time their release gets finalized. Just >>> one example: >>> >>> .../xen/include/xen/string.h:101:27: error: '__builtin_memcmp' specified bound 4 exceeds source size 0 [-Werror=stringop-overread] >>> 101 | #define memcmp(s1, s2, n) __builtin_memcmp(s1, s2, n) >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> mpparse.c:722:13: note: in expansion of macro 'memcmp' >>> 722 | if (memcmp(mpf->mpf_signature, "_MP_", 4) == 0 && >>> | ^~~~~~ >>> >>> Clearly neither the 1st nor the 2nd argument have a "source size" of 0. >> >> It looks like there is a report on the redhat bug tracker for it [1]. Do >> you know if there is a bug report on the GCC tracker as well? > > I have no idea, to be honest. I had a look and couldn't find any. It might be worth to fill one in case they are not aware. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 04 11:40:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 11:40:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93216.175924 (Exim 4.92) (envelope-from ) id 1lHmLA-0005yR-AM; Thu, 04 Mar 2021 11:40:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93216.175924; Thu, 04 Mar 2021 11:40:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHmLA-0005yK-7C; Thu, 04 Mar 2021 11:40:24 +0000 Received: by outflank-mailman (input) for mailman id 93216; Thu, 04 Mar 2021 11:40:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHmL9-0005yF-Ci for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 11:40:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHmL8-0001eJ-D6; Thu, 04 Mar 2021 11:40:22 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lHmL7-0008Ga-TG; Thu, 04 Mar 2021 11:40:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=o0SMcl0QrVeTLwMwPJSNeX/vgFbrRmjMnl1DVxkGznI=; b=16eMAih6S92geEqU897DgP1VlE gr60zs0EI65z6CEo7RjPJ0Nt1/D3EBd7V3PeBYnkiPpz4BN0UweEtvftI2XDp94YTg36HkyU+gFKf VjQ0Bx3kOPPEs03cquGNBxS+XlPAbcV0EZb3awBlVHUCW9FwYc9Hq152pS4npdDrS/E0=; Subject: Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11 To: Ian Jackson , Jan Beulich Cc: Charles Arnold , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <05fe3295-7993-2eb5-37bc-a6d04fde1fbc@suse.com> <7e0584ab-8923-cb59-fac2-c2908d736f0c@xen.org> <1e625665-7a14-a1f6-5b93-cac6e3640c1f@suse.com> <24640.49856.639416.385729@mariner.uk.xensource.com> From: Julien Grall Message-ID: <027e1854-1500-306a-eac8-8571e09df71c@xen.org> Date: Thu, 4 Mar 2021 11:40:20 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24640.49856.639416.385729@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 04/03/2021 11:21, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11"): >> On 03.03.2021 20:09, Julien Grall wrote: >>> On 01/03/2021 07:57, Jan Beulich wrote: >>>> The upcoming release complains, not entirely unreasonably: >>>> >>>> In file included from rijndael.c:33: >>>> .../xen/include/crypto/rijndael.h:55:53: note: previously declared as 'const unsigned char[]' >>>> 55 | void rijndaelEncrypt(const unsigned int [], int, const unsigned char [], >>>> | ^~~~~~~~~~~~~~~~~~~~~~ >>>> rijndael.c:865:8: error: argument 4 of type 'u8[16]' {aka 'unsigned char[16]'} with mismatched bound [-Werror=array-parameter=] >>>> 865 | u8 ct[16]) > > I think this is an erroneous compiler warning. > > It has been idiomatic in some codebases for a long time to write > const unsigned char[] > as a formal parameter for an array (of whatever size). AFAICT, this is not what GCC is trying to warn about. It is complaining that the prototype and the declaration doesn't use the same signature. Indeed, the former is using [] while the declaration is using [16]. So compiler is working as intended when -Warray-parameter is selected (see [1]). [1] https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 04 12:40:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 12:40:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93231.175936 (Exim 4.92) (envelope-from ) id 1lHnGe-0002tN-Bn; Thu, 04 Mar 2021 12:39:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93231.175936; Thu, 04 Mar 2021 12:39:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnGe-0002tG-8H; Thu, 04 Mar 2021 12:39:48 +0000 Received: by outflank-mailman (input) for mailman id 93231; Thu, 04 Mar 2021 12:39:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnGd-0002tB-Cw for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 12:39:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnGd-0002dO-9k for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 12:39:47 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHnGd-0004Is-7P for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 12:39:47 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHnGZ-0005CM-Lv; Thu, 04 Mar 2021 12:39:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=+sJ/Iqqz5CVnxk9Dgf+BePZdsK98/VHQg/Xbl4ewAGE=; b=wuikK5XfHEt6ynyc1H5LkSMjyp ld0/NOdoG5gWp3Fzev7b/otvM1q8x8VSh3lln9x09bBdnyhGViQC1gi2NbkiPYSD3ugFSVeWwmfiG RetavTma+7SOnuhqUkFk9U2iqzSsHafg+YTF6lHlCyQUJTOhSCtOQLrP7a+m/xBCR7YY=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24640.54543.374794.840345@mariner.uk.xensource.com> Date: Thu, 4 Mar 2021 12:39:43 +0000 To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH for-4.15] xen/dmop: Fix XEN_DMOP_nr_vcpus to actually return data In-Reply-To: <20210304104805.27601-1-andrew.cooper3@citrix.com> References: <20210304104805.27601-1-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH for-4.15] xen/dmop: Fix XEN_DMOP_nr_vcpus to actually return data"): > The const_op boolean needs clobbering to cause data to be written back to the > caller. > > Fixes: c4441ab1f1 ("dmop: Add XEN_DMOP_nr_vcpus") > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monn > CC: Wei Liu > CC: Stefano Stabellini > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Ian Jackson > > If we weren't in a release freeze, I'd rewrite large chunks of this. > 'const_op' is what we call 'copyback' everywhere else, but with inverted > sense. I'll guess this gets added to the pile of other unbreakage work which > might happen in 4.16 > > My ad-hoc unit test appears to have had a false positive for the success case, > which I've fixed. However, the chances of the full test landing in 4.15 is > getting slimmer, not to mention the fact that it curretly takes out Xen with > reference counting error... > > As for 4.15, this is a bug in a brand-newly introduced hypercall, and is of 0 > risk for other areas of the release. If this bugfix is not taken, we should > revert c4441ab1f1 to take the hypercall out, but this would be a bad move. Thanks for that explanation. Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Thu Mar 04 12:41:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 12:41:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93234.175948 (Exim 4.92) (envelope-from ) id 1lHnIS-0003jv-ON; Thu, 04 Mar 2021 12:41:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93234.175948; Thu, 04 Mar 2021 12:41:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnIS-0003jo-KW; Thu, 04 Mar 2021 12:41:40 +0000 Received: by outflank-mailman (input) for mailman id 93234; Thu, 04 Mar 2021 12:41:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnIR-0003jj-TO for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 12:41:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnIR-0002fC-Sl for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 12:41:39 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHnIR-0004Rv-Ru for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 12:41:39 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHnIE-0005De-V5; Thu, 04 Mar 2021 12:41:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=qT6MKAvCPuhlFO5GVRsNEpCfK44QKnwV0Q2oMXtFXWA=; b=SjKVusWWbtbyUVcFDBn/oAPt4g wIm2alwTXPVHH4fKuXlKnHGir5vr3cenxuIaXXAaPRQdSf9e4Ss0bGgJTkkV6BVI4UUjJytQbGL00 r4SiuELd6NGMq7VqMjme89By0DOVcEF3YTx8qlGvgfS8C2Fs1G6awkl6WOgCLSHCssvA=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24640.54646.699914.490087@mariner.uk.xensource.com> Date: Thu, 4 Mar 2021 12:41:26 +0000 To: Julien Grall Cc: Jan Beulich , Charles Arnold , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel\@lists.xenproject.org" Subject: Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11 In-Reply-To: <027e1854-1500-306a-eac8-8571e09df71c@xen.org> References: <05fe3295-7993-2eb5-37bc-a6d04fde1fbc@suse.com> <7e0584ab-8923-cb59-fac2-c2908d736f0c@xen.org> <1e625665-7a14-a1f6-5b93-cac6e3640c1f@suse.com> <24640.49856.639416.385729@mariner.uk.xensource.com> <027e1854-1500-306a-eac8-8571e09df71c@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11"): > On 04/03/2021 11:21, Ian Jackson wrote: > > Jan Beulich writes ("Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11"): ... > > It has been idiomatic in some codebases for a long time to write > > const unsigned char[] > > as a formal parameter for an array (of whatever size). > > AFAICT, this is not what GCC is trying to warn about. It is complaining > that the prototype and the declaration doesn't use the same signature. Oh! I would have to check whether that is legal (I would guess probably it is UB because the C authors hate us all) but I agree that the warning is justified and the code should be changed. Sorry for the misunderstanding. Ian. From xen-devel-bounces@lists.xenproject.org Thu Mar 04 12:46:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 12:46:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93237.175959 (Exim 4.92) (envelope-from ) id 1lHnNR-0003uw-BB; Thu, 04 Mar 2021 12:46:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93237.175959; Thu, 04 Mar 2021 12:46:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnNR-0003up-8I; Thu, 04 Mar 2021 12:46:49 +0000 Received: by outflank-mailman (input) for mailman id 93237; Thu, 04 Mar 2021 12:46:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnNQ-0003uk-27 for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 12:46:48 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f64a84d8-8178-474d-ad7d-38a6ecd9970a; Thu, 04 Mar 2021 12:46:47 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2735AAD57; Thu, 4 Mar 2021 12:46:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f64a84d8-8178-474d-ad7d-38a6ecd9970a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614862006; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mwj2HQHeusMyMTvaCLqraxJYhYwSQU7C56BvhhcYU9Q=; b=oeckAsjOMUou2JqgpIUNsKQVaHs6qDsSZWsK2iD5seDBxpIkOYSYQ+xyPpVZBG3xJSY7Mz oR324IWx++l8fAWmpqTNqi+xzAyTWzWljvGWGeNqWyPrbaaq+vVeO7jRfb7RfmN1eO7aZb VYeWNaSHfymDBlGgAHegzv82r8HoRI8= Subject: Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11 To: Ian Jackson Cc: Julien Grall , Charles Arnold , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <05fe3295-7993-2eb5-37bc-a6d04fde1fbc@suse.com> <7e0584ab-8923-cb59-fac2-c2908d736f0c@xen.org> <1e625665-7a14-a1f6-5b93-cac6e3640c1f@suse.com> <24640.49856.639416.385729@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <68e4d40b-c2ea-75d3-c605-99f8bdf6d0d6@suse.com> Date: Thu, 4 Mar 2021 13:46:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24640.49856.639416.385729@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04.03.2021 12:21, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11"): >> On 03.03.2021 20:09, Julien Grall wrote: >>> On 01/03/2021 07:57, Jan Beulich wrote: >>>> The upcoming release complains, not entirely unreasonably: >>>> >>>> In file included from rijndael.c:33: >>>> .../xen/include/crypto/rijndael.h:55:53: note: previously declared as 'const unsigned char[]' >>>> 55 | void rijndaelEncrypt(const unsigned int [], int, const unsigned char [], >>>> | ^~~~~~~~~~~~~~~~~~~~~~ >>>> rijndael.c:865:8: error: argument 4 of type 'u8[16]' {aka 'unsigned char[16]'} with mismatched bound [-Werror=array-parameter=] >>>> 865 | u8 ct[16]) > > I think this is an erroneous compiler warning. > > It has been idiomatic in some codebases for a long time to write > const unsigned char[] > as a formal parameter for an array (of whatever size). > >>>> .../xen/include/xen/string.h:101:27: error: '__builtin_memcmp' specified bound 4 exceeds source size 0 [-Werror=stringop-overread] >>>> 101 | #define memcmp(s1, s2, n) __builtin_memcmp(s1, s2, n) >>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>> mpparse.c:722:13: note: in expansion of macro 'memcmp' >>>> 722 | if (memcmp(mpf->mpf_signature, "_MP_", 4) == 0 && >>>> | ^~~~~~ >>>> >>>> Clearly neither the 1st nor the 2nd argument have a "source size" of 0. >>> >>> It looks like there is a report on the redhat bug tracker for it [1]. Do >>> you know if there is a bug report on the GCC tracker as well? >> >> I have no idea, to be honest. > > This erroneous message makes me think that there is simply a bug in > this version of GCC, where formal parameters declared as > const unsigned char[] > are treated as > const unsigned char[0] > rather than as > const unsigned char* I don't think so, no. In addition to what Julien has said, I think the intention here is that the compiler can check that both consumer and producers of arguments obey to the strictest available bounds of such an array, no matter that at the syntactic level char[N] and char[] both convert to char* when used in prototypes. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 04 12:47:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 12:47:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93240.175972 (Exim 4.92) (envelope-from ) id 1lHnOG-00040v-LT; Thu, 04 Mar 2021 12:47:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93240.175972; Thu, 04 Mar 2021 12:47:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnOG-00040o-Hg; Thu, 04 Mar 2021 12:47:40 +0000 Received: by outflank-mailman (input) for mailman id 93240; Thu, 04 Mar 2021 12:47:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnOF-00040i-AF for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 12:47:39 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1e509575-c425-4e39-a4ed-959bfb4e90dd; Thu, 04 Mar 2021 12:47:38 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EAADEAAC5; Thu, 4 Mar 2021 12:47:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e509575-c425-4e39-a4ed-959bfb4e90dd X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614862058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1tTcjsmmM/8/WzrDjWgvW5PTrsiWd7E1gB3Q1G5DCak=; b=jsv3FWf8evLTgq5HYo0Xo0GBrfokr7Iu3HVtMxYLCIO1KmxZy7X7PqUmmLx1v92gamLClQ 1VC4LYhEDofa0/y2wmQznD2xFerM1MQvkEcwctSQNjySQBUo/iAktFX/33Cu0r5icXOQxZ bNpIZtGuFt1b2sx5WkiPlxeMp/qWCcg= Subject: Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11 To: Ian Jackson Cc: Charles Arnold , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" , Julien Grall References: <05fe3295-7993-2eb5-37bc-a6d04fde1fbc@suse.com> <7e0584ab-8923-cb59-fac2-c2908d736f0c@xen.org> <1e625665-7a14-a1f6-5b93-cac6e3640c1f@suse.com> <24640.49856.639416.385729@mariner.uk.xensource.com> <027e1854-1500-306a-eac8-8571e09df71c@xen.org> <24640.54646.699914.490087@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <16b56df5-ab56-f09d-89c0-218eac3d556e@suse.com> Date: Thu, 4 Mar 2021 13:47:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24640.54646.699914.490087@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04.03.2021 13:41, Ian Jackson wrote: > Julien Grall writes ("Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11"): >> On 04/03/2021 11:21, Ian Jackson wrote: >>> Jan Beulich writes ("Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11"): > ... >>> It has been idiomatic in some codebases for a long time to write >>> const unsigned char[] >>> as a formal parameter for an array (of whatever size). >> >> AFAICT, this is not what GCC is trying to warn about. It is complaining >> that the prototype and the declaration doesn't use the same signature. > > Oh! I would have to check whether that is legal (I would guess > probably it is UB because the C authors hate us all) but I agree that > the warning is justified and the code should be changed. May I translate this into a release ack then? Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 04 13:00:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 13:00:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93243.175984 (Exim 4.92) (envelope-from ) id 1lHnaS-0005xS-OR; Thu, 04 Mar 2021 13:00:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93243.175984; Thu, 04 Mar 2021 13:00:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnaS-0005xL-Kd; Thu, 04 Mar 2021 13:00:16 +0000 Received: by outflank-mailman (input) for mailman id 93243; Thu, 04 Mar 2021 13:00:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnaQ-0005xG-U1 for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 13:00:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnaQ-00030t-Qe for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 13:00:14 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHnaQ-0005kI-O0 for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 13:00:14 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHnaN-0005GY-CI; Thu, 04 Mar 2021 13:00:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=K7KXHwp6Sl8MAn+0wEKK+surykuLXrrgxgWCvRMSCXU=; b=5sYAyCAu/yVd1IxnvG23jB+vAN 56jqtuGU3++RPs0EOO1QXqqJ/5+qakUmmJOsIH5EgCsuiEkvBV6AZsgVtxFP51ni94XiSf2mu9iQL fVVr/8Mwx3IBFG0wycsIjROG5mDWIbiROXRJeC9G+8+C7sAOych21Srh84gYaLUoopgw=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24640.55771.89150.389969@mariner.uk.xensource.com> Date: Thu, 4 Mar 2021 13:00:11 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11 In-Reply-To: <05fe3295-7993-2eb5-37bc-a6d04fde1fbc@suse.com> References: <05fe3295-7993-2eb5-37bc-a6d04fde1fbc@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH][4.15] crypto: adjust rijndaelEncrypt() prototype for gcc11"): > Clearly neither the 1st nor the 2nd argument have a "source size" of 0. > > --- a/xen/include/crypto/rijndael.h > +++ b/xen/include/crypto/rijndael.h > @@ -52,7 +52,7 @@ > > int rijndaelKeySetupEnc(unsigned int [], const unsigned char [], int); > int rijndaelKeySetupDec(unsigned int [], const unsigned char [], int); > -void rijndaelEncrypt(const unsigned int [], int, const unsigned char [], > - unsigned char []); > +void rijndaelEncrypt(const unsigned int [], int, const unsigned char [16], > + unsigned char [16]); > > #endif /* __RIJNDAEL_H */ Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Thu Mar 04 13:02:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 13:02:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93246.175996 (Exim 4.92) (envelope-from ) id 1lHncT-000660-4Z; Thu, 04 Mar 2021 13:02:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93246.175996; Thu, 04 Mar 2021 13:02:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHncT-00065t-1W; Thu, 04 Mar 2021 13:02:21 +0000 Received: by outflank-mailman (input) for mailman id 93246; Thu, 04 Mar 2021 13:02:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHncR-00065m-Sy for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 13:02:19 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3c7ff942-9040-4b11-8293-a61178d4a683; Thu, 04 Mar 2021 13:02:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c7ff942-9040-4b11-8293-a61178d4a683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614862938; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=f8xQsxSfztGXF9Zuo5QPBfwNWbESjWufzUav+BWFt4Y=; b=cxzFOOJ7qTx8PlfkTOZzkNtbJtbzANb6kqr9tY6IhVIJsuPHqHTzn7VD tOjNVoA9oDWYwEyP9FqPIoc8mrmZMqsDP/UXI/vDhiBXukxR/E5VFEyxV FkCCefPGbtdLfukbx+WC4Yk1AY+vPvNlPxeZLiCAzV0woKOas0xdpp4nO 0=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: fdSu2OVB4m91qMyFIrwWFELzmhwi5/KUpxElkWqvrN8yGLiXsTJaiEuUSvu8b8+3Wy3AC5pQw3 MzLamkBPVtTuUCshiJ5+3IO0tr8/VULn377CgrbfcMQYjemBCcqTFPQKU0GKnMa1Ejea3z85tQ XmV4aqhILBknesSDaFG6vYdVyFX1cXKPOVd+J7P9FIboY0HiKxcWca4/mmRPoGpf2OvVC8+ujA cpPCKZkPJ5UkEEdmNCKZLLZxU2bqz+/2rpphxSzG7jIR5n5PmSEeJjuWetJ7g/lfMFRWYC8EhH 9tE= X-SBRS: 5.1 X-MesageID: 39936652 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,222,1610427600"; d="scan'208";a="39936652" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper Subject: [PATCH for-4.15 1/2] xen/dmop: Fix XEN_DMOP_nr_vcpus to actually return data Date: Thu, 4 Mar 2021 13:01:59 +0000 Message-ID: <20210304130200.10521-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The const_op boolean needs clobbering to cause data to be written back to the caller. Fixes: c4441ab1f1 ("dmop: Add XEN_DMOP_nr_vcpus") Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Release-Acked-by: Ian Jackson --- xen/arch/arm/dm.c | 1 + xen/arch/x86/hvm/dm.c | 1 + 2 files changed, 2 insertions(+) diff --git a/xen/arch/arm/dm.c b/xen/arch/arm/dm.c index d689e336fd..1b3fd6bc7d 100644 --- a/xen/arch/arm/dm.c +++ b/xen/arch/arm/dm.c @@ -128,6 +128,7 @@ int dm_op(const struct dmop_args *op_args) struct xen_dm_op_nr_vcpus *data = &op.u.nr_vcpus; data->vcpus = d->max_vcpus; + const_op = false; rc = 0; break; } diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c index f4f0910463..b60b9f3364 100644 --- a/xen/arch/x86/hvm/dm.c +++ b/xen/arch/x86/hvm/dm.c @@ -612,6 +612,7 @@ int dm_op(const struct dmop_args *op_args) struct xen_dm_op_nr_vcpus *data = &op.u.nr_vcpus; data->vcpus = d->max_vcpus; + const_op = false; rc = 0; break; } -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Mar 04 13:04:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 13:04:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93249.176008 (Exim 4.92) (envelope-from ) id 1lHne6-0006Dk-Fs; Thu, 04 Mar 2021 13:04:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93249.176008; Thu, 04 Mar 2021 13:04:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHne6-0006Dd-Cb; Thu, 04 Mar 2021 13:04:02 +0000 Received: by outflank-mailman (input) for mailman id 93249; Thu, 04 Mar 2021 13:04:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHne5-0006DY-7j for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 13:04:01 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id eaf45cda-b1d2-4979-8a68-49fe884de5fe; Thu, 04 Mar 2021 13:04:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eaf45cda-b1d2-4979-8a68-49fe884de5fe DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614863040; h=from:to:cc:subject:date:message-id:mime-version; bh=6yeqZ2hyEsOZnGmzk5/LzUrXnUcg/Pev2FcGRnugMjo=; b=NzQSDxipAIVOZwPzXyVQWWoJNJglScR8PpE12PIb5SMxdDFKJPAB87Sd EGYqXuIhuToI0k48uqUpil/z/fpv239LSfvA3H0Ln1fhCTxu7/VFnRpS2 l1U+5a88Ftrbuj+L7UyS3s4EoqHEi/WZcHqQ2yANDk3Iu7UlHk1R+RF45 A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: HEPw8YoRK2tzwwUtRR+AO7OO7L8AUlhvzVTYqvR8/IwfCpDsVVJbaJ7jfe+6j3nLNtLZmd2xpQ AoPkfPeIyYKLbimGiUMPHYlZ68JOgGTgKINJZEhduVC/csrQmYzihgg7G7hA2ignlsCUDikp1g /GkO6KGny4u1Tam4hwFkkJ/CHZEj+mhkv2eUKeqFnMlZ7F93/bxmKtXm2fgsAMRVj8HfU1WAgY eAJVFIC6IjI+XSWq71XvvO/nK3pj3FX4pK5TjGNgS6scS8Y+72/qM45lnltUlFwWFYVQT3/v6M t34= X-SBRS: 5.1 X-MesageID: 39936864 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,222,1610427600"; d="scan'208";a="39936864" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Ian Jackson , Wei Liu Subject: [PATCH for-4.15] tools/libxendevicemodel: Strip __XEN_TOOLS__ header guard Date: Thu, 4 Mar 2021 13:03:19 +0000 Message-ID: <20210304130319.10719-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain This is inappropriate for the header file of a standalone library with stable API and ABI. Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu Discovered when trying to actually remove the use of unstable libraries from a trivial userspace emulator. Current users of xendevicemodel.h inherit __XEN_TOOLS__ from libxenctrl.h (or equiv). --- tools/include/xendevicemodel.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/include/xendevicemodel.h b/tools/include/xendevicemodel.h index 33698d67f3..797e0c6b29 100644 --- a/tools/include/xendevicemodel.h +++ b/tools/include/xendevicemodel.h @@ -17,8 +17,6 @@ #ifndef XENDEVICEMODEL_H #define XENDEVICEMODEL_H -#ifdef __XEN_TOOLS__ - #include #include @@ -377,8 +375,6 @@ int xendevicemodel_nr_vcpus( */ int xendevicemodel_restrict(xendevicemodel_handle *dmod, domid_t domid); -#endif /* __XEN_TOOLS__ */ - #endif /* XENDEVICEMODEL_H */ /* -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Mar 04 13:05:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 13:05:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93252.176019 (Exim 4.92) (envelope-from ) id 1lHnfB-0006KK-Q1; Thu, 04 Mar 2021 13:05:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93252.176019; Thu, 04 Mar 2021 13:05:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnfB-0006KD-N2; Thu, 04 Mar 2021 13:05:09 +0000 Received: by outflank-mailman (input) for mailman id 93252; Thu, 04 Mar 2021 13:05:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnfA-0006K8-OW for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 13:05:08 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6b22e9d5-8b18-4c68-8af3-813e6eec1f37; Thu, 04 Mar 2021 13:05:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b22e9d5-8b18-4c68-8af3-813e6eec1f37 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614863107; h=subject:to:references:from:message-id:date:in-reply-to: content-transfer-encoding:mime-version; bh=0DIh/okI9xmy+VhqN46rptPSCx+sAw8vsVrdOeHdlOs=; b=ct9C2RE4waOCiEtOroBDZJrnHVI5AwoNoGkjdYzKG2R79sBiNOG0l4LG yQ6FZkokXzLHbpqFZpGTpUhFVtl2csqmgV9FPS5uC4ssBdTzHiEV0+Bpu iCEWBi4rlTTsjyRnH+o72m3JahS2Q/2cBYqUMJufvh1QFrSPj6zK9I5cU s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: I0einA/3+wRUOyZtR020a5K34qBBwtP57nVVNqow1sutT9K8A+Oqe+7LsOsUiCWA+f50OqksaL i21tB9B5IFw1dW6E3mnlIMMLCUGgFcEK8PIFC0KQUS+rTZHbDdoMfzoHjnLTNq15/c7Y5yrEfQ bHtZXi1m8rYxWBSl9ooZ1H+Ht6xPDZEp62l+HvRI8szIN1CvlynqmtVHnicMZYO2hjvye8BzNd nPhTAkaI4sI21RpjGXSCycqhIoMhGOSM+Csix1pn4LChh8dY+Bs8uhfGqhU2mN99qm3deyqolB j+8= X-SBRS: 5.2 X-MesageID: 38542140 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,222,1610427600"; d="scan'208";a="38542140" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nef2iYJNv+dqZL1ro6FAJSa7/cyw8C/AqgOmKLoycQPhYKgK4tNnGfBV4MJjQ4TiMLxPEtgWNPd+C8r0shSfcKw2U5ffC3fJz/33r07hzjJiAP+6+eL9+keEb1qY3LIR20DzxQp8ldtrk15vJC42ea/XrUpTuHlAkN8ezwhpprbvga8K7BH68CXg1uWMIDIxOL/l/sbqXeKjA+evfqbfl5TJHhO4HgrTvtrRPmN7CwqOBDoV1d50iFFKROtxwU30EjA2yqFixF2asdnZacrRzhjGRiRxwfTQHuZuzp6pu4+Gsyh/oLWEIhlTbEZ7Lzd8UQ7E5Pwa/uxo6ob7VC2zzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0DIh/okI9xmy+VhqN46rptPSCx+sAw8vsVrdOeHdlOs=; b=kkB+i7IM0FXQvDiRp1c+XrIQUIoEdgl1ZMCYovzY0Por5hemEWrkC++yPrEMMEQW9P/9kLH4yYQYpL81LB2w4CmlLJ8DyUdSdeh6/rOBOHBKcTMyKZ0MC4oDVysQB9n7PcTILZmW+O4oWeOCBf/JNnEd386cLir/tsAfHpy46xTDtNWTbLUpY43KpizQlgbW6lEibKQZl/2GgTIxNZTd9Gl4SThFE9HE1pZLosoZN5ktPCX0EGoXfG/a+ZvoAPlIfF/aVV93cYZbk1IxIw9tZMhqVHHcY+hcDVSUfxMkgoyJsBbAk51zjAT6NA1L95dPGR9eLc06VLkM/IzJ+jnkog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0DIh/okI9xmy+VhqN46rptPSCx+sAw8vsVrdOeHdlOs=; b=N4fwQ3SScVfOYMwjM6NVQBdPSkZMeYmpNmZkSd8vk/OxiAGDqoiGkfUVwZEALjA2/hfyFE7IokPsmZGYwIEO1WRcv5dbzi0uAI7Ec57nr/WxX/f37KtKZ3yndfIOqaCOjRENRoag3hby/nTnp7uK5o3HDntz2kjaEnrKhn9Pnlw= Subject: Re: [PATCH for-4.15 1/2] xen/dmop: Fix XEN_DMOP_nr_vcpus to actually return data To: xen-devel References: <20210304130200.10521-1-andrew.cooper3@citrix.com> From: Andrew Cooper Message-ID: Date: Thu, 4 Mar 2021 13:04:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210304130200.10521-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0214.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 93a82f0a-2611-46b6-d498-08d8df0e08be X-MS-TrafficTypeDiagnostic: BYAPR03MB4679: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1923; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v5FiZ89pv0Zd9Jeu7FV9eNMUtIlsiwCo1vaNcjghPUWqXlDaGB35RQyXM8oh01/omB8g22FIvmJMK8sS9gFD8wsL7Ze5M/pCyI3OVqASJXzyY8n73kQXMyxpmqml6xxS85FLNDFdAjMsaTq1dy8dWAKb1ByJ7u4qR9RsV4h0l6+Tdo5lMNofvQ3Tgf1GDyzEEngF2bt+ztS6LWZwidIyQiNiJagORJH7ZEmvJIeAVehMXL+BuYVmMJGga9MXBAGhQbdgt7kkx2q9gd9N2WMmR0gxmRh7JVnVLgaWo72faxcJ7nCRjJUUYeEzLyVacOFDmo1TIQE+IX8Bu6pTydcXog03qtQur6vvXk+RzPjCw7tYaHSpb0bTu2jexqdOi/Xer9/5viRZcg5kcbBf+8cuJHTHlYMYenwHSnKLslW4G6mTmj6MbbLc2tjSa5DV1GJv/RavfOv+KFIjw2y1JsnqV7k2/KWEY4NYUbkZ7p3rKIat3aM6GG6e3dgGmrYUPzSwa8wy4ya/LBh8aoQEkoTqhJr4NzZAgI65GKKpcLtmyvtOMFQqDHaAy5GNlV1eQ29jXxzbPATntVWsAo6MnVKQSB2NzC8nP7pf/d8vnwGSmsw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(366004)(376002)(346002)(396003)(956004)(86362001)(6916009)(66476007)(2616005)(66556008)(478600001)(66946007)(53546011)(31686004)(16576012)(6666004)(16526019)(6486002)(316002)(8936002)(5660300002)(31696002)(2906002)(26005)(8676002)(36756003)(186003)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eDd5WUhneGdTWEY2ZDBBaVVlbk1xczFqVmo4Ykg2SzcyUG9FK3kxUkRveVIx?= =?utf-8?B?Z3Jja0xJZ1BzTTZtTWFxUTU5aUc3Y1RPVmFFdGlKZnJYTGVISE01ek9Xb29N?= =?utf-8?B?d0tJQ204ajR1cTJPMFQ1Q3ZrWHVXYnF3Rm8vS3NmUnBsT1lENElHdmwrbjVR?= =?utf-8?B?cTgwYlZKUWE4Njd3R3BDdlRBdXA0aVZ2UnIrZ2NWS0UrVE5rM2orRkNUTE5z?= =?utf-8?B?SlBBbngydG50QTl1WVd2djF2WXd1WUttTXhhck96RjdwTzJHSlgvOGpTQmdt?= =?utf-8?B?V2V6emROdTBmM0ZPdENvTUNGU1lCS2xXQnF5dXp3VS9hTGdDenM5WUcweTFF?= =?utf-8?B?bWt6MTFiRHU5MlF4WHBNZ01lR3pwVDkvaHdNUlNMaFNmWFExSG9uZ1Q0amFH?= =?utf-8?B?anRJYnNhc0d6YXdyeERiSXpWSFFkUGxBTzhWdWlzTDFZK0FRUHM5YWljVU5q?= =?utf-8?B?VnpMZnd2ZitYVElBcXRUeVpjZXJEcFRCUXpIeGVHcTV6UGQyOEZ2dEtYMUJy?= =?utf-8?B?bDdKZHlaRUlUbWNrbU5UN1lTY0M1eW44bFdhbm1HOFVLQ1JLK1J1UmlaTUxM?= =?utf-8?B?cmcxWTNINDBVM2pwcGxoQnVIT1hBWndPaDhPTDR4SUFudGUvRnBWdVUwWDZC?= =?utf-8?B?SS9PUEsrdGNDM3N0VTNnR3ZpMkJWTUV6bDkzY2ZZY2s4SHlWaXFvYzZ4eFVD?= =?utf-8?B?UTQyais3SmcycVNMTkJSUWo1Vi9RYk5EQjlSQXJ0b2JyNFQ5RFZSNzhuQ2dY?= =?utf-8?B?VktlR1NqN3BCWlVLbHdHNW5xRlUwT0EybU55alJiSzlYcnhrN3U4SFFIeHhL?= =?utf-8?B?Y1JqaDVzemhHTXlobUxhUVl5QlYvcUNhWmpEa28zVjlxeTNjdU1rUk9GUE9X?= =?utf-8?B?ZTVzTVVJaThFOHN1WlUwYlU4K0l3Tm1RS0xWSzFrZXlXdVB4Qys5eXFqMEV0?= =?utf-8?B?S1dYcm5hTmhVTVBzbVRndCtmZDJ4aXhiUGVkTS9mT3JrSmxuRXdnMDBDLytn?= =?utf-8?B?blo3TlBPYjV1UjBtU0c2d1RFM2YvRnFxQ2p3OEFDcXV5dnR6M0dlNDRpK0xL?= =?utf-8?B?WVl6Qy90RTJEZlZiYTRGdnJJMEt1OVZITEErUVBhU29XOHhQRlYydDVGa1RZ?= =?utf-8?B?aGNPcDQwOE5xVkVtL3FOUWN6N2pwaEJ4d3hIc1Z0a0crdm9sOWpSVUFrSnVI?= =?utf-8?B?aGhFeUFGdVhRR2dhTFZvaFZweWtuYVFmR0JTYTZzaXNPS1dNck9VV0VTbWtk?= =?utf-8?B?Vlp0NUhsVTFCWExKRXVIQzZJMHNyZ0hUdkVnVytpMm4waStrMnN1dmRpOHNn?= =?utf-8?B?WmxlSVo0d1UybmIzaDdxL3p6NTU5cTIxejQ0c0VNbHQ3THhQbUVUdHROc0Zs?= =?utf-8?B?Nmo5UktmSjIreWZUSjhaaStwUjR2TXI1T0lIbWNnQ1Fzam1kZldKcVdZUjA3?= =?utf-8?B?Sis2ZDVXYkVGLzV0b1IzT2xMU05kZFpuTHhlSURmZU9YTzVSeWoySnFLTXdN?= =?utf-8?B?WG5nNThKMWp4Qm9GaVlEdElCUTBGdjRkbzBDYnhLajNpbVloK29DOFJnY3BW?= =?utf-8?B?M2R6N0FkWlhhRlA0WHR3djV3WU5XSldoWEFBWkxKNjNvektHQWRNUzlLRGhh?= =?utf-8?B?YnlZdUREeEpwRHV4SmZRU1VHZSt6M09SbjVMa21ydU84WGFOSFRpZWkrVVlF?= =?utf-8?B?RlErbEUydERmRDhRNmIxaFBlY2NHZW5MZnBlQVh5R3A4blpVM2Y5c3lBQzZw?= =?utf-8?Q?D101vkMdCgP4lVt7g5jJ2nvWYVnjloTNjnQqFQt?= X-MS-Exchange-CrossTenant-Network-Message-Id: 93a82f0a-2611-46b6-d498-08d8df0e08be X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 13:04:24.4873 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VKHyD9mEBGf1ATTlTVyRJcJx6yHNKb+IbmnOJMxu5Ie9tGhUl6g/vWmtxVZnch9iJNT6ADVQaB0gOJP1QpKArwtTGmlLGsfVPxYZK93szxQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4679 X-OriginatorOrg: citrix.com On 04/03/2021 13:01, Andrew Cooper wrote: > The const_op boolean needs clobbering to cause data to be written back to the > caller. > > Fixes: c4441ab1f1 ("dmop: Add XEN_DMOP_nr_vcpus") > Signed-off-by: Andrew Cooper > Reviewed-by: Roger Pau Monné > Release-Acked-by: Ian Jackson Apologies - I made a mistake with git-send-email.  No further action required. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Mar 04 13:42:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 13:42:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93259.176031 (Exim 4.92) (envelope-from ) id 1lHoF4-0001oT-UH; Thu, 04 Mar 2021 13:42:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93259.176031; Thu, 04 Mar 2021 13:42:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoF4-0001oM-R6; Thu, 04 Mar 2021 13:42:14 +0000 Received: by outflank-mailman (input) for mailman id 93259; Thu, 04 Mar 2021 13:42:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoF3-0001oH-Ip for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 13:42:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoF3-0003ib-G0 for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 13:42:13 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHoF3-0000Db-EU for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 13:42:13 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHoF0-0005Lr-3M; Thu, 04 Mar 2021 13:42:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=3SRdSTzymaBRDF96qiFo4YlIWh9G48EwBjsnKXqr1DI=; b=PiRQ48gn/KK7n8vg5QRvZpff/Y IYS200QRjJRnC62Ncf3FEntV1c1R8/yLcaXoPfEQqOSRqplLJJyKBjWvaT9ZY32gqut3NWI/Nw8DH Fb3qs7rPGdAJ4djuL0yGhpHyJiVkdI6pIWKZseKm9x1eA/o5u/TUE6dqt4ptl6z5zESM=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24640.58289.822243.338643@mariner.uk.xensource.com> Date: Thu, 4 Mar 2021 13:42:09 +0000 To: Andrew Cooper Cc: Xen-devel , Wei Liu Subject: Re: [PATCH for-4.15] tools/libxendevicemodel: Strip __XEN_TOOLS__ header guard In-Reply-To: <20210304130319.10719-1-andrew.cooper3@citrix.com> References: <20210304130319.10719-1-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH for-4.15] tools/libxendevicemodel: Strip __XEN_TOOLS__ header guard"): > This is inappropriate for the header file of a standalone library with stable > API and ABI. wat > Discovered when trying to actually remove the use of unstable libraries from a > trivial userspace emulator. Current users of xendevicemodel.h inherit > __XEN_TOOLS__ from libxenctrl.h (or equiv). Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Thu Mar 04 13:55:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 13:55:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93262.176044 (Exim 4.92) (envelope-from ) id 1lHoSG-0002ti-4P; Thu, 04 Mar 2021 13:55:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93262.176044; Thu, 04 Mar 2021 13:55:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoSG-0002tb-1F; Thu, 04 Mar 2021 13:55:52 +0000 Received: by outflank-mailman (input) for mailman id 93262; Thu, 04 Mar 2021 13:55:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoSE-0002tT-Vx; Thu, 04 Mar 2021 13:55:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoSE-0003vb-Pt; Thu, 04 Mar 2021 13:55:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoSE-0003DD-Gt; Thu, 04 Mar 2021 13:55:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHoSE-0000G0-Dl; Thu, 04 Mar 2021 13:55:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1K5Jo3QLQKdt9UgRK12gqRp8wBjnjSxEWilkuy7GlGY=; b=foRPnvn2cpMB5EbygjnqL3y4SM sug/Lpe6AnFO1GebYs4dI4I6tErnslJZFiB3TARE7q3IGZAvN3PB9L7YZE19VFriyW+KxQaFz+CnB f3T5SBuxiJsgn7hRb8Io6rnqvX5RNjU0/f3Il5lqE9UkpV7n2sqPNFiSDst56OOd53VI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159822: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=c40ae5a3ee387b13116948cbfe7824f03311db7e X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Thu, 04 Mar 2021 13:55:50 +0000 flight 159822 qemu-mainline real [real] flight 159827 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159822/ http://logs.test-lab.xenproject.org/osstest/logs/159827/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu c40ae5a3ee387b13116948cbfe7824f03311db7e baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 196 days Failing since 152659 2020-08-21 14:07:39 Z 194 days 376 attempts Testing same since 159822 2021-03-04 02:04:12 Z 0 days 1 attempts ------------------------------------------------------------ 433 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 118695 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 04 14:08:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 14:08:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93268.176059 (Exim 4.92) (envelope-from ) id 1lHoeU-000459-9s; Thu, 04 Mar 2021 14:08:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93268.176059; Thu, 04 Mar 2021 14:08:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoeU-000452-6j; Thu, 04 Mar 2021 14:08:30 +0000 Received: by outflank-mailman (input) for mailman id 93268; Thu, 04 Mar 2021 14:08:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoeS-00044x-S8 for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 14:08:29 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 99d0fd85-1fe5-4335-b703-154b7bbd7ef5; Thu, 04 Mar 2021 14:08:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99d0fd85-1fe5-4335-b703-154b7bbd7ef5 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614866907; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=9kY1RiySxJVmmLrMh4G/PkrsIu4+mS6ldgF6SoRjiL0=; b=bd0IKa85ogjK6o/GWvziehUeSl1C/Zcr/BbwK6bqdADWpXXbMD+b4Ou2 A6yEfv9B2WAEddEIedjJ8Z8MIv1lUUR6TwoCkaFIOys9T6q7v4i080FcK ym0Tc6tXfK4jj149GbQcRhU41pGdDIDf/FgoqEnYGV0xJ97sLR1JcBC2j w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: jKOASyZRbuJvcKIjLWOyyETmKBNpP2RoSclQvuIhQ66R7/Y7gxJVULjJrwismzVLGcS5mis7yE 4Be44oh5pOEtzkg1y0/rrqe0dQ2+Whav0YVG1M7eOdl3284bm49G4VnphbOepwRtidkws5zBdK jaFnxLcJhMc1v68asveIEqcfknD3NoavS3qOHlWAIqocu+JJujudV2EaFPa1fpGQO6EzbXF1kn xM/T6+AHbxCwDpdHQ6cbNwpy99fgFVcvzJFX7ZWJltQ9mNnunv5qYq67L7plZQEa51HBT1YoHv fkw= X-SBRS: 5.2 X-MesageID: 38452962 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,222,1610427600"; d="scan'208";a="38452962" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VvFj4TWZevPa1/zBdke4C4RditX4s3wjEGkfw5r5BezKe0bvMrtkxSjUboQAmZv1VOR6ihyu7aNNb68YuqtkQlgHni1aXnfdWjJ8hf0m/9QnzDHKJ2CPfZMZrr30iTaPNIbbrvgG2FPJsdFuJ2yXgJNl2hNsWkh+8lBpYbkDNC9auO0cvwbkUN8ClG37v5o5rmWLNyQsh5nek9KfcXhj03XdmF21JGIukHU38DfyaAxb823/SH0GaKisI9QOfjAWXsK1PatCITC80SlRbH3TJXY/oLw5vM2Yg+AHw1JREHyhFtC+ti4yR1whC4Z738oodJBT278yFrs1xEAMb/W20w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9kY1RiySxJVmmLrMh4G/PkrsIu4+mS6ldgF6SoRjiL0=; b=dTxJJ5ft/SctA2hprj257n2zafSCyGtcjWWz3qHiyXqFp9Wb4fWCTqM6kJtfRa9pGh+JC0c/E6nsn3GJOOoSyCZ5PIfYRfmpzKqcQZ2ZBrTNaTMh5zAMRwitoTaJjLEyVxrK8tnSNvnj1irWkm9h/jeWvtWfIufOd4AcEalSIhvlpy0oUqAN4dYBPvHbcMrtFwih7cUA4PBy8C1nb4je5lDT6fyjZY4VHIUyOVvfSd6g3LeU8GlwQpodjPVYwXKARcHAxUWmBr12vradfu706hIw6mYrQ8w/n0V2J7nZRBGKAkDLh3UYk2itqpmfS5Oowwunf9GZcbnsMc2Z7l5dPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9kY1RiySxJVmmLrMh4G/PkrsIu4+mS6ldgF6SoRjiL0=; b=hRWes+xGolaS7wV/AdCXAHibCfFnV5zrbQ8Fuli80QTeSPjnOLASRR/TS1HDB4jvrjxGIN3Zsas6pzZtvsh3ELVZbTU2hUJxeU4g0o8gwR9eVBZ/zLvu5WgYqF4STg9xQCJYZmaqiW9N7urt+ph5SptnJj2Jbe674zrB7il4lfs= Subject: Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection To: Boris Ostrovsky , Roger Pau Monne , CC: Ian Jackson , Wei Liu , Anthony PERARD , Jan Beulich , Jun Nakajima , Kevin Tian References: <20210301162357.76527-1-roger.pau@citrix.com> From: Andrew Cooper Message-ID: Date: Thu, 4 Mar 2021 14:02:46 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0350.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::26) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 45aaecde-6ab7-4a0a-57f2-08d8df16345d X-MS-TrafficTypeDiagnostic: BYAPR03MB3429: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MDqO4W/GqxgpEkymOCb0VbA7cKbNyYzlApa/LFOQ2CQRgVL0I4lGyD8bAo8J2GwKD4HdPFC2sUzoCAU9pG0GmdQRvILYeQJbSm2W7bzcOYP2sjMxL5qhzMmkHSSo+z1blrp+Z9A7g4AWUYsNw9BjG8UGHGWjtl1v1DVYGwjVO8mQtLszOH0Vb9gA4P+bzIZuVntzS22892Ey9pMcH6h4qJ300LkyEm7x0yj2mNlwYhdls8xo9VMieQWtzk2fcK6izIfwXdmso9MqD9HTaO02GZCdEGsT12TFCdmcaurLSk6f5YEiNK+taAgW8WbYgF+A7P2QXwFMVFPrDsT6E+VIwEdPC2LFKqX26Qhxwf5mYTBHo6tz8rZqRjNzoKNN3wQZfMn1JEKq3+QKldwhZN7jCCtYiF/RNKUGkMRh63wRoXt/NUcfKd6L1Kdrl9u0zLrdrkOnZzQJ3QWlij5YFjU47Fv2lI/LfT3JEWM66s9wFTDvWQDnHxhypKME5sMZp/L+XjxrzP3LrkRXBwcviO66rFgaU65/JatUFgrGDn5pkt1GNGl7lmzMtK1qRPBInTu3PBcESN5jjpWKZC6jWL4KlwBSqYh8LKs1cAVUnvVhRUY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(5660300002)(2616005)(66556008)(956004)(8676002)(6666004)(6486002)(110136005)(66476007)(31696002)(36756003)(53546011)(31686004)(4326008)(8936002)(86362001)(316002)(26005)(186003)(16526019)(66946007)(2906002)(478600001)(83380400001)(54906003)(16576012)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?enNIenhYbWRZdnJpTDdKdDBoRzdoVm9OT2VMOVNXYk1XTS85QnlzSStpTmFY?= =?utf-8?B?T2NzUDJEVkZWTERUazR4OHFmelZKWU5kOWs2YWd1ampmZm1ndnk3VDhPcGl0?= =?utf-8?B?cUdIZXp5S0sySm5QNXJWdDE1QmYxTktPeVQyRHRRK2hYTU8rVDBHOWY0L1Jz?= =?utf-8?B?S1BhU29XZjM5cmNFQjFkUG1RRmV2NXJLQlBibmtHRHk4bUZvd2N0cFlxWms4?= =?utf-8?B?N0xtaXplSlFJWWlFNy9lRTRpSTFMa3VOdnZFamtORmJIUWRiL0pBR2lrclhO?= =?utf-8?B?SjE0MnVFQ0VLVG5vdzd0YTdpVk1NSE1wanZVdk8vZ2VxbnVBb2tJMFZNSGQ2?= =?utf-8?B?cTRqYlYwUE5OR1ljdUc0b0pPMHJPTmxaR2toSVlzbU85NWk4K0V5ODFpbnMw?= =?utf-8?B?OUo5dHRQWlRlZ1pjSTJyUUdwWHdNbXd5R3F5MHpHbzVCdW5ocEdsdlJFNVlN?= =?utf-8?B?Yk5GZ1dPVElzclVRQk5nK0kvSGFOZ1gvTnBTNHlOZnErcmxibUZ2MFE1VHlV?= =?utf-8?B?TDErUUNRSmNGazFGQUhIZHRybTFjKzU3TzA1NHBlWVlvTzdCM0ZiMEhPL2pI?= =?utf-8?B?S21HdnBQcXRnM3hYY25OcXh0UVI0ZFkvUWtoT3d4M0pCb1BFK2NLV2Q4clhO?= =?utf-8?B?YWw3YzcwK2MwTWtjeEIzcERmOWh0RFBMRERQdndGWk04eGZwRytoRTBFbU1q?= =?utf-8?B?UmFXUktRdHVBcXJHY2NWWGZHWGlLTkhqcWJqOGdKTmVoeUdZOC90NWxnM1Qy?= =?utf-8?B?RExLSmVWMk5MejVVbTZCQWxnRnJ2UUREKy9GU25JMW15RDBNVnVFUnNNV2Rj?= =?utf-8?B?VUtlQ0Q1aWVWNzZRd2dCZlR5R0FOUktNVGJHNVljemxaMENEZHJXdWFoQ0Nw?= =?utf-8?B?aEg5M1lla05WY0pNMld5eCtKcjFLeEhibmJuT1ZsK2E5NWxIZ3lpMFUvV1NF?= =?utf-8?B?dkhlK09ES0RJUHh3UFp5RHk2eDZwalZZZzF3aFkweW5iTFI0dE82dDNxSlNj?= =?utf-8?B?Uy9ORWlPZmFFdFJMTTkwZGZ6aTR2aC9TUEhMTG9FRml6WGpSTXNIRlB4MDdr?= =?utf-8?B?L1gwY1BXMTZVTm1VZExrdWlCREpDOE80d2NmTkVIQWFhYm45eDByUFlnaWVN?= =?utf-8?B?QUNUSW51K0lnWEpLMEVzbWREUGlXQlNGNnB3cHU3anlYdnlkc0QrSDlyK3RV?= =?utf-8?B?QlozcGFOajZsSXZHdWpFdm5wMmxzeEs3NWN5ZW02SG9FRGtXL3ZOT3JpN3hy?= =?utf-8?B?N2tmVWtURTNwbnpXZlUyUWZpa0ZuTU9tRDlmNEpmT093WWdWalpYYkpiL0hN?= =?utf-8?B?N1czSWE2cnlSbzlsNS92ZTgxdlF5TktHYjhXNzZTYlVRd0ZHQXFlb0RYem1Q?= =?utf-8?B?ZzdlVE56SXdBcnB6aG9abEd4ZVZkRkdWcUNEdzRMODQyWC9OK1RzTFNiRTNw?= =?utf-8?B?TFlGSnFOZG04NlRVMXgvSTFKYWJGMmQ4YjhUcnZFdmpvTG40MmRlVnJubjVz?= =?utf-8?B?dm9Fd1BLU0hRWEU1dCs5RUVhcmNXcndjTno5ak9STThzWTN3RXE3b0FYSndi?= =?utf-8?B?T3RwY3E3aE8xVklHV2Zad0QxWU1BUDV1M0hMaEZyeDc3OHVKQXhoTUFZdXQy?= =?utf-8?B?aUpQYlhqQ3BCbW54NFRDL1JJa2dyb2N0ZXBNb0wyOUtYK3Jxa2ozOUNEWXJv?= =?utf-8?B?R2k0cHVuZ0IyVlhCY0tmUTlvaHhUVXVOR0VPellMc3ZwMlJLM2hzOHkrV0pY?= =?utf-8?Q?9fz082DfayDpRlKR2lBPYqS3zwvMRFV7mEG5oPq?= X-MS-Exchange-CrossTenant-Network-Message-Id: 45aaecde-6ab7-4a0a-57f2-08d8df16345d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 14:02:54.0498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ccqnGI9sMDR/E+ZMaKmVYfU7dkGakV2EVqnn2nZs44I5gBxE2CyQJwwben/RTuKeW56H07ZFkmqak3dEDoz1jTCUDSSb3725rYIc0igv1Qk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3429 X-OriginatorOrg: citrix.com On 01/03/2021 19:33, Boris Ostrovsky wrote: > On 3/1/21 11:23 AM, Roger Pau Monne wrote: >> Introduce an option to allow selecting the legacy behavior for >> accesses to MSRs not explicitly handled. Since commit >> 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly >> handled by Xen result in the injection of a #GP to the guest. This is >> a behavior change since previously a #GP was only injected if >> accessing the MSR on the real hardware will also trigger a #GP. >> >> This seems to be problematic for some guests, so introduce an option >> to fallback to this legacy behavior. The main difference between what >> was previously done is that the hardware MSR value is not leaked to >> the guests on reads. >> >> Signed-off-by: Roger Pau Monné >> --- >> Cc: Boris Ostrovsky >> --- >> Note that this option is not made available to dom0. I'm not sure >> whether it makes sense to do so, since anyone updating Xen to such >> newer version will also likely pair it with a newish kernel that >> doesn't require such workarounds. >> >> RFC because there's still some debate as to how we should solve the >> MSR issue, this is one possible way, but IMO we need to make a >> decision soon-ish because of the release timeline. >> >> Boris, could you please test with Solaris to see if this fixes the >> issue? > > Yes, it does. Thanks. Really?  This doesn't stop #GP being raised for RAPL_POWER_LIMIT AFAICT.  Or am I mistaken about how the bug manifested? ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Mar 04 14:15:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 14:15:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93273.176071 (Exim 4.92) (envelope-from ) id 1lHokk-00056O-5a; Thu, 04 Mar 2021 14:14:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93273.176071; Thu, 04 Mar 2021 14:14:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHokk-00056H-1X; Thu, 04 Mar 2021 14:14:58 +0000 Received: by outflank-mailman (input) for mailman id 93273; Thu, 04 Mar 2021 14:14:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoki-00056C-95 for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 14:14:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoki-0004Me-6B for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 14:14:56 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHoki-0002u4-3C for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 14:14:56 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHoke-0005Q1-P0; Thu, 04 Mar 2021 14:14:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=ilTSBOQcaJfKfwwLDwvDkIwXAN/2O/+CIOpiTgfqddc=; b=NCwx4WE+loLVX4C9Q15Vqrf9x0 HJx7vtf+2sQ6c0V/qTTkop/NNUmP3PgDwuK/7lun5HVEccsCsmTv5SoDcyx5uxlskRQsERHGEsCBi 3yBhxFqjB5e0HHQPcsGNBgy66Nt66wE322ej+MBt+dcjqBszTe6LSN84vCVOC7BIEVZU=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24640.60252.467968.279717@mariner.uk.xensource.com> Date: Thu, 4 Mar 2021 14:14:52 +0000 To: Andrew Cooper Cc: Xen-devel , Wei Liu Subject: Re: [PATCH for-4.15] tools/libxendevicemodel: Strip __XEN_TOOLS__ header guard In-Reply-To: <20210304130319.10719-1-andrew.cooper3@citrix.com> References: <20210304130319.10719-1-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH for-4.15] tools/libxendevicemodel: Strip __XEN_TOOLS__ header guard"): > This is inappropriate for the header file of a standalone library with stable > API and ABI. > > Signed-off-by: Andrew Cooper Reviewed-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Thu Mar 04 14:18:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 14:18:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93275.176083 (Exim 4.92) (envelope-from ) id 1lHoo9-0005G8-LA; Thu, 04 Mar 2021 14:18:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93275.176083; Thu, 04 Mar 2021 14:18:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoo9-0005G1-I8; Thu, 04 Mar 2021 14:18:29 +0000 Received: by outflank-mailman (input) for mailman id 93275; Thu, 04 Mar 2021 14:18:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoo8-0005Fw-8V for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 14:18:28 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fcc6d47e-9f60-4f93-81a2-fefed51fe8fb; Thu, 04 Mar 2021 14:18:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcc6d47e-9f60-4f93-81a2-fefed51fe8fb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614867507; h=subject:from:to:cc:references:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=+n979Kpzz3wOb0UKzWhsUCl9o6Pi8vFOEIIokHfCfXo=; b=h51B/1f0+FQNHM1wBSZFO4wKp7bo5pFjMDJu1aJkbJ68MWCgCj9vKTXJ QYJQ07fhBR5c3PEuRaockPGH7CMRviIO+Qq2SJezePacm3PvV1VQXB1a9 vqAhPU4L1PrbNoYu9nWtaa3pnUKnO7TfbrSy4n3HBmjS+jAApzJeTye86 M=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: aYXISfdobRBRLsnE99fSDYABW+YJxhXhnATtlMnDKrwA10lJPuHbOUPV4BblQIHogQttc0RT76 lCZDlfgVwabsGAOsgtN1P0sPFpwSDLPWcEfW15GgKRwYsjWlicf+V9a5xJt/qzxGkElHjApHmQ U19l7oZjGvDIfT16DQcLM6PumD0aRnxAeAMARRjgScVe5iHKtDpQnWv2+knNpjsBGAWGOwe7Hr IKfo5VOTnBk+naNuhgpDDqTNHs9uK/KG+yWoY3SIqEZMj3XH29wfwxYmZaRU1a5jyGfKKSh0J9 eBI= X-SBRS: 5.2 X-MesageID: 38551321 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,222,1610427600"; d="scan'208";a="38551321" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RBC7jsPxlYoQs9kFAp216EJTHU/6ybnGkmswRQBoV30m0stC/O5M13y2F4zBuUTZdnwU0APo6ev439r3Kfeq7iVT3W08oJYPBWM+B/fSjvjoeXqhh4zW2RAbsZEpF4j7F8b+A7YjEZcUjSPYKuP+mTTf7SDw43xst4tZ2kUawm0IBgfWtxOLEHxXtCY3Sbp8zPAX0+F18V/ABtca3DhYwO+CSQOapyEO4pAxdRua+OZJhsHl0VEaj8vn3sW94+4u0YKh3ZbydanOxsPl1w8HTzbKsmFiyf9eeufP21YltHAYCWngdU8BJbhJLMSRfrOZ9dYziC3WZJ4pzi8xBZio7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+n979Kpzz3wOb0UKzWhsUCl9o6Pi8vFOEIIokHfCfXo=; b=A15GCECx6rVJDPINYoFGVwG28RlwoUTib+J7uEOWVzSKMXE3iJ05mdY+9a9HhOIQ/7uT4QzqRNvwfWySozyISk95dwLVqNsHEkpbx6luSFG/VtK9tELEnkKxqsg6hJj+2dgiAKgO/uZNmYAsP2G6jF0eYyOaCOu04iTgOsr/nV2N5e6Jzn2a0s55LwB8aLlFhqnKhAqUoCYiaLs3Py4/qA6Lr8SnaTiqFv/rgDnaKfXuDP1JrxN9bKPXRnmU4pfwldP1nIvgxflhZUPsX5sqiXwQwSVnxPCWyFddwyOEPZnsfoPjFYAkkTt+KB8mROZIYYJHoo0QXneFJ/ATUXJwMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+n979Kpzz3wOb0UKzWhsUCl9o6Pi8vFOEIIokHfCfXo=; b=H4aX7pdMZ+oUNOpGURL8a6MRFuEMcR/7eTKn80JTrq4jIk32vWyEnbSEU00/VkTyUh9T4Ab21wwZDUfwJEaYOBucbFHtiylppw1/2RBMNS0CyMcPl+ApbxzCVV7IGRoUNzWKBDgrViqgwGO79aGo4DLaZFdhwgyCVh8mBmTks2U= Subject: Re: [PATCH RFC for-4.15] x86/msr: introduce an option for legacy MSR behavior selection From: Andrew Cooper To: Boris Ostrovsky , Roger Pau Monne , CC: Ian Jackson , Wei Liu , Anthony PERARD , Jan Beulich , Jun Nakajima , Kevin Tian References: <20210301162357.76527-1-roger.pau@citrix.com> Message-ID: <9e679925-5d1c-3a43-10ff-dba1bd2ddff9@citrix.com> Date: Thu, 4 Mar 2021 14:17:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0475.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::12) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b45c8074-8635-4dd1-b699-08d8df185304 X-MS-TrafficTypeDiagnostic: BN6PR03MB3186: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ru8WQPDfLJK4dJUw8FU7C/cr6KxgqU4t8pjFf1lOtr6SVloRqigdlyEVLCo7mqjw1YavohL6D5hb+oWee4KeG9QRAubUKGddh45s92vjK/dpXxYIoNvc8+hUJ6hktw1KrdjhbbhRInTBZ6QTe/B6FKmbhtLJ6NlG7hrB6c61rupDiF0KlbT1jllVJ9pMIDfu1lyzkQxvnIh+Bm7CGxkW33KOfiBoNQ7JMl/JPbknFytOyJLVuPfqaHx8WCmCLtmW91yKZoT6a54ok7PjqSVTrsZFR4Q1LOcFVT83KIpnEKWJmU4/GioThviOjHjss8LAcI8ZPEEZITiUc0AToeuf4YhHoMFJdr/ho+2I8xxXXLj7zJdMohns59n3H0Mkkcj5KDYNTHPeubsh1bYwIuQJel6qbij32yCbnt9qwpha8YBAq1rvIz/F3K9iY2Vuu6MMWdUXh9eNfaLOJmufE+ziBgjiKVMizjX8+N5bbbCkQ3wxVtdhF8AyLWsIXWryjXaJT7Gp7i1BWJ8tuo6Zc22oWnZ2S8mlqZYRQh+j/FjQXqNzQD31qCPkFaXR0b3fh2CBbNhMMyKmHljDWBZn67aw00K8mfPpKAxCqBwrl0M6Xzw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39860400002)(366004)(396003)(346002)(376002)(66476007)(66556008)(26005)(66946007)(53546011)(6486002)(83380400001)(5660300002)(16526019)(2616005)(6666004)(4326008)(186003)(478600001)(956004)(2906002)(16576012)(54906003)(36756003)(110136005)(31686004)(316002)(8676002)(31696002)(86362001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YXIyT1dtVkpHU291SmdUWTZnbURhTllNUmJ5dndMajB4WmhOdjQ4bDl5ZWo3?= =?utf-8?B?UVhuSWJ2REx0YjFVL0YxQmc4bkRhamlHNjlxMUhWSmFaNjdHck1WL2daRnNU?= =?utf-8?B?RW51bWk2UlNhaVZmejdqMnhEL0toWE9JVEF0OThlWStHdGpoN05WZ3BLMS9k?= =?utf-8?B?Z0lwTi96NmprdVJ0cUxJUFM3akZxakZsQVdvcW5SUkh3eEsrWkhmQmxBQ0ox?= =?utf-8?B?NjVkUEVzWURIYUFrTzJMQVFUREZFZXExaTBST2ZGYTBVSkxic0dyUlBQeVRw?= =?utf-8?B?ZFRGdHRocW1tSlVuemNCVlNabnVvRnNielFwSm1xMTJxRW9tNWNiWlFteFh4?= =?utf-8?B?aXRUSzl4OGRXNmQvRUJjS2VnMmlzUVFpbUlWcjgzcEdJdVJyWnNIOWZGZ004?= =?utf-8?B?dHFjSVZzSEJDMHZBM3dPdnRXMWNUbmgzYUVaSVZ1MERBWlZnUURLUDJGS1Aw?= =?utf-8?B?SkFwMkJBemp2N1ZvdDVPUGROZFNEM2V6QW1hVDFwMDV3clcwQWo2L0tkSXFu?= =?utf-8?B?cFN3dlhRWXg2TlNpeGxhNlRrK25aTlp3Mk1hMld5UVhRS3ZrTVJSY0pGS3BS?= =?utf-8?B?SUp5eGlNVjIvcVcxbDc5aDQzb2xxZmVWMGhaUm03aUVNdVg3aHpKaFd1QlB6?= =?utf-8?B?UTQ2VkprNjl1WTVlcHBRUFoxbHlMa2djOGZuNkVxc3VsSlBqckdXM3NVS0lS?= =?utf-8?B?R1dFWDlZWjlhWDBYbkFGRTVhTkt4NmZSK0RLVWdYSDg0ejdkZ2x1OTlWbzZO?= =?utf-8?B?T29wM1BFM2k2RDlSUjZkblRERk9Jc2puVW9IV0JjcVZRTUFRWUpzTmNtN1BI?= =?utf-8?B?Qjk5cW1qU1hDak50TW0yTUQza1l5Z1VvU25oOVRZY0tCMlpnaXRUZGdxcUJR?= =?utf-8?B?MVBlSEtqLzdyZDV6cDNtWjlkTEU3dUhpcjFUR0pYWW56cDAwaWZYT0FXbkJy?= =?utf-8?B?RURMUEtwbmJjOFpvSHNBV3FxZ0R6ZkwySTJIMWN6bk9ZS1RnQzh5V2IwV3da?= =?utf-8?B?Zk1XejRGMWJsWjdFNGlxeGdmNWZWV1JvazByRm13SFFWTnZzL2dicHNYdWpL?= =?utf-8?B?Ui8xR1hqSFBjaEVud3o1ZHp3dlZqZWU4b2lBM3ZqbWkwajRyVE1OcXpESWZU?= =?utf-8?B?SUllV1RWVHB2L1lxSTFvbm9jbmVCR2NxZjdFOTgxcjB3SVY2N0dGK3M0VWpK?= =?utf-8?B?YnZHWXVpeGllQXF4Ull0U1Q1aEZqQWZxdGNpRmMza0pyTmNUZDFKRlV1RUwv?= =?utf-8?B?RG5VQm43c29jK2NaaDZsUlB2OVVJYmlHelF5T1gzMjlscGhQMUtpQzQzUVAv?= =?utf-8?B?Qy9VVko0bW9adGdQQ3hxa0JMWm1FYWNObVRMenpoY3AyWVd6OHNKWGdRQjFX?= =?utf-8?B?RkVMQk0vZUNNZDdEZUVuSmxwendQS0drMEY1cFl3Yyt2RkpuOWVsVTZwSWVu?= =?utf-8?B?UzJRRUw3YS9vbStqNlFQRmkrZ2ovbVFSczMxeFRKZGFqeUFIVksvVjV3YUR3?= =?utf-8?B?ZlpjdGRVWmRUeXlpS2xaNGY2K2RVOWRudWlCQW4vQlVrc000Z2xhSzBUa1ZY?= =?utf-8?B?dS9zcEdmd2F6T0g4bW1hVnFpbmhCYUVKYzdzVmRzUzZBcGJ6TmVOck1UQktY?= =?utf-8?B?SHlOY3lQYW43dk9sSVNMaTE2eHNFT2FZWFptY2NuRlhtT1lGbXpTc2lsNWdI?= =?utf-8?B?L3NOMHpXQnNIRzVJTjRCaVIrN3pPT21kRjdVNGVueUxVYklXQ1U1cm9xV3Q0?= =?utf-8?Q?wvbCN3YOlpj5VI+r3/gRcz4oNxxvCVEUNu3obrU?= X-MS-Exchange-CrossTenant-Network-Message-Id: b45c8074-8635-4dd1-b699-08d8df185304 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 14:18:04.0520 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XBvCavDtZhRJNwsTgoLgD7sdO2xHraB7MoqOmmePfWzil2JCz2QjAQTF+iu4yuTfWCI8/AZpiHKojE2B94QlJUIko+obF9owsTHe2dhlLWQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3186 X-OriginatorOrg: citrix.com On 04/03/2021 14:02, Andrew Cooper wrote: > On 01/03/2021 19:33, Boris Ostrovsky wrote: >> On 3/1/21 11:23 AM, Roger Pau Monne wrote: >>> Introduce an option to allow selecting the legacy behavior for >>> accesses to MSRs not explicitly handled. Since commit >>> 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly >>> handled by Xen result in the injection of a #GP to the guest. This is >>> a behavior change since previously a #GP was only injected if >>> accessing the MSR on the real hardware will also trigger a #GP. >>> >>> This seems to be problematic for some guests, so introduce an option >>> to fallback to this legacy behavior. The main difference between what >>> was previously done is that the hardware MSR value is not leaked to >>> the guests on reads. >>> >>> Signed-off-by: Roger Pau Monné >>> --- >>> Cc: Boris Ostrovsky >>> --- >>> Note that this option is not made available to dom0. I'm not sure >>> whether it makes sense to do so, since anyone updating Xen to such >>> newer version will also likely pair it with a newish kernel that >>> doesn't require such workarounds. >>> >>> RFC because there's still some debate as to how we should solve the >>> MSR issue, this is one possible way, but IMO we need to make a >>> decision soon-ish because of the release timeline. >>> >>> Boris, could you please test with Solaris to see if this fixes the >>> issue? >> Yes, it does. Thanks. > Really?  This doesn't stop #GP being raised for RAPL_POWER_LIMIT > AFAICT.  Or am I mistaken about how the bug manifested? Actually never mind.  I've figured out why.  I have another bugfix to submit. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Mar 04 14:53:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 14:53:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93316.176131 (Exim 4.92) (envelope-from ) id 1lHpLl-00015S-9I; Thu, 04 Mar 2021 14:53:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93316.176131; Thu, 04 Mar 2021 14:53:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpLl-00015L-5w; Thu, 04 Mar 2021 14:53:13 +0000 Received: by outflank-mailman (input) for mailman id 93316; Thu, 04 Mar 2021 14:53:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpLk-00015G-FQ for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 14:53:12 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 21639180-9e91-4789-b59c-db53f127194b; Thu, 04 Mar 2021 14:53:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21639180-9e91-4789-b59c-db53f127194b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614869589; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=w42WT7O2QH2cfRu8u+NxK2WDp7Jcpjgfi1UVGv2ZK2s=; b=O8LCT9/iTnaQVmKN3Fb93Y4OA7SePRFXiIjnEqgcZ6QZzLNms6z9QJkv sCciy8KtpQWx5HX1ClyjyRue9a+51E3+nrGu2PzCI7Xoo7BavBUbOtjNO Nb2JoDfvfQ9dPAGqjlxDtCNXFHz2PR2Lf3d9N6wWhukMik5kmog4a3heX s=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: M4CVk+yExLYCaAbS8v9iEsAcaxFgPQrqcoCJF9NjApPMFMp/IpLluTNTxljrSO00F621HEVi0/ KmjU99aE/7mWKr0pyOAfJdCUeIEUO6rxfxMV1YlP9U8eHN2NcLXS7AKt22dw2C1K6gf4N0Cr2w I6j3DHvQgCP0x6Xzb2R/KW2GhMBvSEkiwFHuWdoN8nq5E5jI8+dCLsytUfi1k05Lc1VerdHSl2 lu5WSaC7Uay9WuT9NwQgO4hiou5/L2Y7M3xxjI3nprpl+8BEvxSJx4xI5XamfDNEkXXjlKKk0v cMw= X-SBRS: 5.2 X-MesageID: 38459263 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,222,1610427600"; d="scan'208";a="38459263" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S2WPJsKNvje7T5XikABuU8YAZpOYC4VbzqShiUdY8pUT1wjRbKInFhwPR6Sk9NXmTRUXVDXzpYgnTUGXoU7u9KJlxY9mpLb8YX+htEB0ebbf5OotHZ5a3SRle1cNiOadLYoMMIfhEqnoeB4N2P0Vu0+qd4KGqZ67vXD3D638UPd61iNACx5b6aAue2BlODQv5amN0A9ngGjNSsIV0WsUR9xwzHfGSLDLXzCgysl111JqGxCMd8A30sUMbLSOKTycWFjbA9hRM2m/XSZRD6ibH75xpoCRzfCwVDdiVpE7lB7Ek4RTY90pMzN2/WCH0vrAYTI8sIdU9uEbZfEPYGYsGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L2pdlnYkK6NZGcE+3Ae/ki7kRac06cOdBxcW+JVkJzA=; b=MLCSzK8wBu0y9pADBQwLIDPWBjuGAYlGEYBKZlc7zEx4GseRhqwbFcD7vUwO6YF1zJe1ksWLSWLKxDmh84OFc1c5oNvy8gq3AtUrvTKCBBp9On1x6YrpiGjJ9CT68JRpMTWi6b/egYzDVTPh2dNl6fgImceMPkueBhmZTnB7ZLKZFe8a4Nz5YwO+5ew1GKw2i0Prc/tJ4bGyvcaEAM/V7N2AW+3t6zPcVm1RatBt2R093desa00dkyFwLLTPDqELZnRxRdein1wPuTibIcug8CRn/U3VoQYXLvxIwkpJ1/GemK7ngpTTksLTgAQcxKJ4Ks8ugV1rm5yu0RrZ6od8sA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L2pdlnYkK6NZGcE+3Ae/ki7kRac06cOdBxcW+JVkJzA=; b=oPdjXu4fJkq3Je83wRqiHvtdhsYq9d9sDbLkVKPhIIzIOir3lgYGiBm/eNU2RsyHRo736r9ozuWCiMf2EcPdxRWSdqNWZc1bRnSlC8GFgCAcDF5ODKFKJnO47Wt0KZc+OWpmpEC/5f/PwUQFMlRykv+PlJQMRvmr10IhX2uGA/g= From: Roger Pau Monne To: CC: Roger Pau Monne , Ian Jackson , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior Date: Thu, 4 Mar 2021 15:47:55 +0100 Message-ID: <20210304144755.35891-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0094.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::9) To SA0PR03MB5610.namprd03.prod.outlook.com (2603:10b6:806:b2::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 53b59604-9366-4dce-df87-08d8df1d34d0 X-MS-TrafficTypeDiagnostic: SA2PR03MB5772: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J4wfbGdnx7fgWiJbTy5Wm7XzPWCGESwo6fsf/lLgzatFICt5GrZu6nv27TXC3iEKLbSjn/48177G3Vkg8iAWXTNd/9YFs/YeSwE0tDVif+KimVaJB8VZFVuJf+NJiOpdmYrWJSFW9gmg31UnYLh28CFhqUGu80I6wF+oUwbssenaQIhw3hc939bTFHlmz15+x1j6FvU8wGoUxDZjERTtD2bpsgLes4ItoO8R8KI0o4iEFjrFylma6//d8qvO5f8BBjZKjZtyLo2m5PSlIyts7ZTryqYcjiARMiZRZdt1uS0sjSfbeM1P/POBgxmLK9STTJDHU1g7x5OybXBDu2oL3JzPiBy262MG81PGKkB/yW4CsAAMnC9+1v3hdsxpuVMGI1Q9fsG8ViHXePFhk49Q6QU0tSJu9p4ptQD/45sxDGHafx/IBWjKrhyo6LEW9pjVj7K4WrIMZpILNZFKQZ4ynqWedH7/AkdMEcB1oPp14Wd6nukY19HpUwAqSCImJGalTn6hJQGpapMUNJ856ek/Hw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(39860400002)(346002)(366004)(376002)(6916009)(316002)(86362001)(6496006)(54906003)(6486002)(6666004)(956004)(2906002)(2616005)(16526019)(66556008)(5660300002)(8676002)(8936002)(186003)(66476007)(478600001)(26005)(66946007)(83380400001)(1076003)(4326008)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?RmNpMUFTRHptaGVqdktQNmpnc3l3ZFpwYnJubm1nQ0FOb0hJRnd3UWcyOWJG?= =?utf-8?B?cE8rNjlhaFhOLzV6bjgvN0xjSlRDbVlza1U4RjJqVEJVTFFGeTlrK0Voai9H?= =?utf-8?B?OFpaTDNFQnplVWN3V3pNL05mZ0lQTTV6NkUvbDRzc1J1Rklsbk1QMGwyREFV?= =?utf-8?B?VnE4K05hMnJHeFE4djhuaGFKNHY4bWxZUzA5UVlzeEtPa21icFA3b1Q0b3hh?= =?utf-8?B?OHdxc1E1VkkwelZPZ1d5TXlIS2RRUk1uSk9ISDB1SWwzUnZUdkZUQVBWbU9K?= =?utf-8?B?RnI3Rm5tVFB3VCtaQ0Vrei9sQlY3d1VUdGszSmhGQkJWUWJlV2lRMzNMMmt2?= =?utf-8?B?Wkg0TFJtcXBnVmFSTWxuazFlMDNwM05ucFE3T2FBcUJ4LzV2UXgyRHpQdW5O?= =?utf-8?B?TlFkaGtsOGMwWWhyRHlsS0FHZDIxSUhNRW5UdTQyay9rb2tTU21OSm1tZ2dZ?= =?utf-8?B?anFSTWRML1JLcWI2djdqTG41L1paZUdGeEdNMnVKNWtlTkhrTkVzaFpQTUZv?= =?utf-8?B?Mmo2Yit4elVKOU96aG9zaWVmR2xFY2ZKc0kxdVRWNHRZVDc4Zk81OGFBVUgw?= =?utf-8?B?V2Q5ajI1cjRZODduOThJNmt0WFBMelgyc2l3cXRJV2Mxc1dCYjZ5U2t1SHYw?= =?utf-8?B?bXlVN3JNRHU1MHZBNnE3ckVFcVBSR2wwTit6R3dVZjJtVTh0Z1loVHVxSjll?= =?utf-8?B?VDhOb3pUT2hJZnQ4Q1JtWEFmbk9CVXpXM2NEcVBadU9tVnNQQ3pZbXdWN21R?= =?utf-8?B?dGVKYXdFNWlvMHhYNUlpcHVLMU5vM2Z0alBPbzR6czFRd2dMOU03a3pINGdz?= =?utf-8?B?dmlKZ1YyWkp6N21lNFd6WlEyTUdxSk9PRTRzeVdjb1kvWFQ5bW1XWWxHR2NE?= =?utf-8?B?MFQ2eURhemtiVEtCaHJqUklxcVErNE1ONms0SVFib1VwYVAxNlhrTjdqMjFv?= =?utf-8?B?MitlY3hjYTZqOUpCT2RLMFZQempic0o1NW5nNzJEV3dsamd5MnpINkNEREJt?= =?utf-8?B?aXI2U1RDajRyVFFjNW5CN2wwNk8xdGRIS2lCRFdFZ2R1TmlBQSsvUEUvRlBS?= =?utf-8?B?Y2hBSWlYcldIMm5qbzRsc1hNRHFNR0hQT013YzVkQU9mNVN4Vmp5LzZ6cGxC?= =?utf-8?B?a202TnBzM2lUdVU1VU5Cc0l6MThmbEUwc2NOVGFSdkQzb2NjaDdjVXZPOGo5?= =?utf-8?B?VUxJdU84VHJ0Y3JuYVJlODZtR3hDcEQ3d0FQUXdXQXBmMGNNTmxkait4NlpQ?= =?utf-8?B?bWtJcTJ2c2NTSjhUMzNqQlhseVc5NFhzUlJza2twQmhHWkdJRVZHQ1VMT2NW?= =?utf-8?B?Zy9Pa1c5bUsva01aMXlreU5OOHM4SC85OTNQTDFnWUp1VnJrbmh4UE9IL1pa?= =?utf-8?B?dzZ1Z1UvT3hlY3JWZTBnMG9Pa3U2VS8wR2lTdTBGbW4zOHprSFhNOGZoTnVs?= =?utf-8?B?QW8vek1LUWNKYzBVV21jTFVoTlpmamhNRENOa2U5UTBlSS92ODB2S1BheTJx?= =?utf-8?B?dTdzWHNkdGtrQTVRUUR5YXZxY1dBOWtyaGpzMXV0RE9YSitxcWN1UG9XbDBL?= =?utf-8?B?VjVXem8rbU1VUXRBbzFKeUtsdzNOT0J0ajd1VVh1aEFqTU9SSXg0MER0aWlW?= =?utf-8?B?N0pBU2YxV1BHOWFoR2JCeWlTRVllRDYvcFlDQWxuSG9WTUVJd3RpdTJhWHFO?= =?utf-8?B?WjB0aHRDOGw4RFpvenRQOUpUVGFvS3BtcWFISUZLbUlaMm15a01hSXFqaXow?= =?utf-8?Q?xeCHEFYnv8yVhfdgj69ENZTQ8EnXl5xRXcA+DPc?= X-MS-Exchange-CrossTenant-Network-Message-Id: 53b59604-9366-4dce-df87-08d8df1d34d0 X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 14:53:00.8543 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NFca3N1Yiq7fTemOMGz4mXVAXOrptu3lgBTJu7PV+Vuxbcsr+iPWo7RXQrLazKUKbvvLQg5gzFBHsPQovQ0plg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5772 X-OriginatorOrg: citrix.com Introduce an option to allow selecting a less strict behaviour for rdmsr accesses targeting a MSR not explicitly handled by Xen. Since commit 84e848fd7a162f669 accesses to MSRs not explicitly handled by Xen result in the injection of a #GP to the guest. This is a behavior change since previously a #GP was only injected if accessing the MSR on the real hardware will also trigger a #GP. This commit attempts to offer a fallback option similar to the previous behavior. Note however that the value of the underlying MSR is never leaked to the guest, as the newly introduced option only changes whether a #GP is injected or not. Long term the plan is to properly handle all the MSRs, so the option introduced here should be considered a temporary resort for OSes that don't work properly with the new MSR policy. Any OS that requires this option to be enabled should be reported to xen-devel@lists.xenproject.org. Signed-off-by: Roger Pau Monné --- Changes since v1: - Only apply the option to HVM guests. - Only apply the special handling to MSR reads. - Sanitize the newly introduced flags field. - Print a warning message when the option is used. --- Cc: Boris Ostrovsky --- Boris, could you please test with Solaris to see if this fixes the issue? I wonder whether we need to to enable this option by default for guests being migrated from previous Xen versions? Maybe that's not required as the option is helpful mostly for early boot I would assume, afterwards an OS should already have the #GP handler setup when accessing MSRs. >From a release PoV the biggest risk would be breaking some of the existing MSR functionality. I think that's a necessary risk in order to offer such fallback option, or else we might discover after the release that guests that worked on Xen 4.14 don't work anymore in Xen 4.15. --- docs/man/xl.cfg.5.pod.in | 17 +++++++++++++++++ tools/include/libxl.h | 8 ++++++++ tools/libs/light/libxl_types.idl | 2 ++ tools/libs/light/libxl_x86.c | 4 ++++ tools/xl/xl_parse.c | 7 +++++++ xen/arch/x86/domain.c | 10 ++++++++++ xen/arch/x86/hvm/svm/svm.c | 6 ++++++ xen/arch/x86/hvm/vmx/vmx.c | 7 +++++++ xen/include/asm-x86/hvm/domain.h | 3 +++ xen/include/public/arch-x86/xen.h | 8 ++++++++ 10 files changed, 72 insertions(+) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 040374dcd6..62178b9829 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -2861,6 +2861,23 @@ No MCA capabilities in above list are enabled. =back +=item B + +Select whether to use a relaxed behavior for read accesses to MSRs not +explicitly handled by Xen instead of injecting a #GP to the guest. Such access +mode will force Xen to replicate the behaviour from the hardware it's currently +running on in order to decide whether a #GP is injected to the guest. Note +that the guest is never allowed to read the value of unhandled MSRs, this +option only changes whether a #GP might be injected or not. + +This option is only relevant for HVM guests, and will be removed in future +releases once we are certain the default MSR access policy has been properly +tested by a wide variety of guests. If you need to use this option please send +a bug report to xen-devel@lists.xenproject.org with the details of the guests +you are running that require it. + +=back + =back =head1 SEE ALSO diff --git a/tools/include/libxl.h b/tools/include/libxl.h index a7b673e89d..1cc40a2d67 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -495,6 +495,14 @@ */ #define LIBXL_HAVE_VMTRACE_BUF_KB 1 +/* + * LIBXL_HAVE_RDMSR_RELAXED indicates the toolstack has support for switching + * the rdmsr handling in the hypervisor to relaxed mode, where #GP is only + * injected to guests for unhandled MSRs if accessing the MSR on the physical + * hardware also triggers a #GP. + */ +#define LIBXL_HAVE_RDMSR_RELAXED 1 + /* * libxl ABI compatibility * diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 5b85a7419f..03b0c80146 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -644,6 +644,8 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), ("vuart", libxl_vuart_type), ])), + ("arch_x86", Struct(None, [("rdmsr_relaxed", libxl_defbool), + ])), # Alternate p2m is not bound to any architecture or guest type, as it is # supported by x86 HVM and ARM support is planned. ("altp2m", libxl_altp2m_mode), diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c index 58187ed760..c9cff44088 100644 --- a/tools/libs/light/libxl_x86.c +++ b/tools/libs/light/libxl_x86.c @@ -5,9 +5,12 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, libxl_domain_config *d_config, struct xen_domctl_createdomain *config) { + config->arch.domain_flags = 0; switch(d_config->c_info.type) { case LIBXL_DOMAIN_TYPE_HVM: config->arch.emulation_flags = (XEN_X86_EMU_ALL & ~XEN_X86_EMU_VPCI); + if (libxl_defbool_val(d_config->b_info.arch_x86.rdmsr_relaxed)) + config->arch.domain_flags |= XEN_X86_RDMSR_RELAXED; break; case LIBXL_DOMAIN_TYPE_PVH: config->arch.emulation_flags = XEN_X86_EMU_LAPIC; @@ -809,6 +812,7 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc, libxl_domain_build_info *b_info) { libxl_defbool_setdefault(&b_info->acpi, true); + libxl_defbool_setdefault(&b_info->arch_x86.rdmsr_relaxed, false); } int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 1893cfc086..9f52c7e914 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2636,6 +2636,13 @@ skip_usbdev: xlu_cfg_replace_string (config, "spice_streaming_video", &b_info->u.hvm.spice.streaming_video, 0); xlu_cfg_get_defbool(config, "nographic", &b_info->u.hvm.nographic, 0); + if (!xlu_cfg_get_defbool(config, "rdmsr_relaxed", + &b_info->arch_x86.rdmsr_relaxed, 0)) + fprintf(stderr, + "WARNING: rdmsr_relaxed will be removed in future versions.\n" + "If it fixes an issue you are having please report to " + "xen-devel@lists.xenproject.org.\n"); + if (!xlu_cfg_get_long(config, "gfx_passthru", &l, 1)) { libxl_defbool_set(&b_info->u.hvm.gfx_passthru, l); } else if (!xlu_cfg_get_string(config, "gfx_passthru", &buf, 0)) { diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 5e3c94d3fa..c06b17d338 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -760,6 +760,13 @@ int arch_domain_create(struct domain *d, d->domain_id); } + if ( config->arch.domain_flags & ~XEN_X86_RDMSR_RELAXED ) + { + printk(XENLOG_G_ERR "d%d: Invalid arch domain flags: %#x\n", + d->domain_id, config->arch.domain_flags); + return -EINVAL; + } + emflags = config->arch.emulation_flags; if ( is_hardware_domain(d) && is_pv_domain(d) ) @@ -824,6 +831,9 @@ int arch_domain_create(struct domain *d, { if ( (rc = hvm_domain_initialise(d)) != 0 ) goto fail; + + d->arch.hvm.rdmsr_relaxed = config->arch.domain_flags & + XEN_X86_RDMSR_RELAXED; } else if ( is_pv_domain(d) ) { diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index b819897a4a..d036809bd3 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -1795,6 +1795,7 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) const struct domain *d = v->domain; struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; const struct nestedsvm *nsvm = &vcpu_nestedsvm(v); + uint64_t tmp; switch ( msr ) { @@ -1965,6 +1966,11 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) break; default: + if ( d->arch.hvm.rdmsr_relaxed && !rdmsr_safe(msr, tmp) ) + { + *msr_content = 0; + break; + } gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", msr); goto gpf; } diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index bfea1b0f8a..883e43a0bb 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3123,6 +3123,7 @@ static int is_last_branch_msr(u32 ecx) static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content) { struct vcpu *curr = current; + uint64_t tmp; HVM_DBG_LOG(DBG_LEVEL_MSR, "ecx=%#x", msr); @@ -3204,6 +3205,12 @@ static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content) break; } + if ( curr->domain->arch.hvm.rdmsr_relaxed && !rdmsr_safe(msr, tmp) ) + { + *msr_content = 0; + break; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", msr); goto gp_fault; } diff --git a/xen/include/asm-x86/hvm/domain.h b/xen/include/asm-x86/hvm/domain.h index 7b60e9125f..fdc1b36513 100644 --- a/xen/include/asm-x86/hvm/domain.h +++ b/xen/include/asm-x86/hvm/domain.h @@ -122,6 +122,9 @@ struct hvm_domain { bool_t is_s3_suspended; + /* Don't unconditionally inject #GP for unhandled MSRs reads. */ + bool rdmsr_relaxed; + /* * TSC value that VCPUs use to calculate their tsc_offset value. * Used during initialization and save/restore. diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h index 629cb2ba40..fbf91bf3b9 100644 --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -304,6 +304,14 @@ struct xen_arch_domainconfig { XEN_X86_EMU_PIT | XEN_X86_EMU_USE_PIRQ |\ XEN_X86_EMU_VPCI) uint32_t emulation_flags; + +/* + * HVM only: select whether to use a relaxed behavior for read accesses to MSRs + * not explicitly handled by Xen instead of injecting a #GP to the guest. Note + * this option doesn't allow the guest to read the hardware value. + */ +#define XEN_X86_RDMSR_RELAXED (1u << 0) + uint32_t domain_flags; }; /* Location of online VCPU bitmap. */ -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Thu Mar 04 14:59:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 14:59:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93321.176143 (Exim 4.92) (envelope-from ) id 1lHpRQ-0001UY-1O; Thu, 04 Mar 2021 14:59:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93321.176143; Thu, 04 Mar 2021 14:59:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpRP-0001UR-UY; Thu, 04 Mar 2021 14:59:03 +0000 Received: by outflank-mailman (input) for mailman id 93321; Thu, 04 Mar 2021 14:59:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpRO-0001UM-TV for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 14:59:02 +0000 Received: from smtp-fw-6002.amazon.com (unknown [52.95.49.90]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2722c3cc-e878-4004-96de-abc9702d16de; Thu, 04 Mar 2021 14:59:01 +0000 (UTC) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2c-579b7f5b.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-6002.iad6.amazon.com with ESMTP; 04 Mar 2021 14:58:50 +0000 Received: from EX13D02EUB001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2c-579b7f5b.us-west-2.amazon.com (Postfix) with ESMTPS id 6F722A02DD; Thu, 4 Mar 2021 14:58:48 +0000 (UTC) Received: from u6fc700a6f3c650.ant.amazon.com (10.43.162.118) by EX13D02EUB001.ant.amazon.com (10.43.166.150) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Mar 2021 14:58:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 2722c3cc-e878-4004-96de-abc9702d16de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1614869942; x=1646405942; h=to:cc:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding:subject; bh=Gye21up+a473ZZF07bM1W7OMnqVri8uunRmrXLB55W0=; b=EmjTfA//82ojjtMnd9bUjk7nNgnWXzP4/LLK24AFcQpQTaLej1Vd+aPI MBapYjrMSnkxNqEaY5yb5h1ej7OfHUu8P5GZbHl2O8XnUeJid9xJEpmR4 4H7g1DcM72A3hY4g3ppUjMcpJWvDYVlBF1ViPswwAUQU3Au3JjgUzQgSk c=; X-IronPort-AV: E=Sophos;i="5.81,222,1610409600"; d="scan'208";a="94242996" Subject: Re: [PATCH XENSTORE v1 09/10] xs: handle daemon socket error To: Ian Jackson CC: , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-10-nmanthey@amazon.de> <24639.46501.489245.30690@mariner.uk.xensource.com> From: Norbert Manthey Autocrypt: addr=nmanthey@amazon.de; prefer-encrypt=mutual; keydata= xsFNBFoJQc0BEADM8Z7hB7AnW6ErbSMsYkKh4HLAPfoM+wt7Fd7axHurcOgFJEBOY2gz0isR /EDiGxYyTgxt5PZHJIfra0OqXRbWuLltbjhJACbu35eaAo8UM4/awgtYx3O1UCbIlvHGsYDg kXjF8bBrVjPu0+g55XizX6ot/YPAgmWTdH8qXoLYVZVWJilKlTqpYEVvarSn/BVgCbIsQIps K93sOTN9eJKDSqHvbkgKl9XG3WsZ703431egIpIZpfN0zZtzumdZONb7LiodcFHJ717vvd89 3Hv2bYv8QLSfYsZcSnyU0NVzbPhb1WtaduwXwNmnX1qHJuExzr8EnRT1pyhVSqouxt+xkKbV QD9r+cWLChumg3g9bDLzyrOTlEfAUNxIqbzSt03CRR43dWgfgGiLDcrqC2b1QR886WDpz4ok xX3fdLaqN492s/3c59qCGNG30ebAj8AbV+v551rsfEba+IWTvvoQnbstc6vKJCc2uG8rom5o eHG/bP1Ug2ht6m/0uWRyFq9C27fpU9+FDhb0ZsT4UwOCbthe35/wBZUg72zDpT/h5lm64G6C 0TRqYRgYcltlP705BJafsymmAXOZ1nTCuXnYAB9G9LzZcKKq5q0rP0kp7KRDbniirCUfp7jK VpPCOUEc3tS1RdCCSeWNuVgzLnJdR8W2h9StuEbb7hW4aFhwRQARAQABzSROb3JiZXJ0IE1h bnRoZXkgPG5tYW50aGV5QGFtYXpvbi5kZT7CwX0EEwEIACcFAloJQc0CGyMFCQlmAYAFCwkI BwIGFQgJCgsCBBYCAwECHgECF4AACgkQZ+8yS8zN62ajmQ/6AlChoY5UlnUaH/jgcabyAfUC XayHgCcpL1SoMKvc2rCA8PF0fza3Ep2Sw0idLqC/LyAYbI6gMYavSZsLcsvY6KYAZKeaEriG 7R6cSdrbmRcKpPjwvv4iY6G0DBTeaqfNjGe1ECY8u522LprDQVquysJIf3YaEyxoK/cLSb0c kjzpqI1P9Vh+8BQb5H9gWpakbhFIwbRGHdAF1roT7tezmEshFS0IURJ2ZFEI+ZgWgtl1MBwN sBt65im7x5gDo25h8A5xC9gLXTc4j3tk+3huaZjUJ9mCbtI12djVtspjNvDyUPQ5Mxw2Jwar C3/ZC+Nkb+VlymmErpnEUZNltcq8gsdYND4TlNbZ2JhD0ibiYFQPkyuCVUiVtimXfh6po9Yt OkE0DIgEngxMYfTTx01Zf6iwrbi49eHd/eQQw3zG5nn+yZsEG8UcP1SCrUma8p93KiKOedoL n43kTg4RscdZMjj4v6JkISBcGTR4uotMYP4M0zwjklnFXPmrZ6/E5huzUpH9B7ZIe/SUu8Ur xww/4dN6rfqbNzMxmya8VGlEQZgUMWcck+cPrRLB09ZOk4zq9i/yaHDEZA1HNOfQ9UCevXV5 7seXSX7PCY6WDAdsT3+FuaoQ7UoWN3rdpb+064QKZ0FsHeGzUd7MZtlgU4EKrh25mTSNZYRs nTz2zT/J33fOwU0EWglBzQEQAKioD1gSELj3Y47NE11oPkzWWdxKZdVr8B8VMu6nVAAGFRSf Dms4ZmwGY27skMmOH2srnZyTfm9FaTKr8RI+71Fh9nfB9PMmwzA7OIY9nD73/HqPywzTTleG MlALmnuY6xFRSDmqmvxDHgWyzB4TgPWt8+hW3+TJKCx2RgLAdSuULZla4lia+NlS8WNRUDGK sFJCCB3BW5I/cocfpBEUqLbbmnPuD9UKpEnFcYWD9YaDNcBTjSc7iDsvtpdrBXg5VETOz/TQ /CmVs9h/5zug8O4bXxHEEJpCAxs4cGKxowBqx/XJfkwdWeo/LdaeR+LRbXvq4A32HSkyj9sV vygwt2OFEk493JGik8qtAA/oPvuqVPJGacxmZ7zKR12c0mnKCHiexFJzFbC7MSiUhhe8nNiM p6Sl6EZmsTUXhV2bd2M12Bqcss3TTJ1AcW04T4HYHVCSxwl0dVfcf3TIaH0BSPiwFxz0FjMk 10umoRvUhYYoYpPFCz8dujXBlfB8q2tnHltEfoi/EIptt1BMNzTYkHKArj8Fwjf6K+nQ3a8p 1cWfkYpA5bRqbhbplzpa0u1Ex0hZk6pka0qcVgqmH31O2OcSsqeKfUfHkzj3Q6dmuwm1je/f HWH9N1gDPEp1RB5bIxPnOG1Z4SNl9oVQJhc4qoJiqbvkciivYcH7u2CBkboFABEBAAHCwWUE GAEIAA8FAloJQc0CGwwFCQlmAYAACgkQZ+8yS8zN62YU9Q//WTnN28aBX1EhDidVho80Ql2b tV1cDRh/vWTcM4qoM8vzW4+F/Ive6wDVAJ7zwAv8F8WPzy+acxtHLkyYk14M6VZ1eSy0kV0+ RZQdQ+nPtlb1MoDKw2N5zhvs8A+WD8xjDIA9i21hQ/BNILUBINuYKyR19448/41szmYIEhuJ R2fHoLzNdXNKWQnN3/NPTuvpjcrkXKJm2k32qfiys9KBcZX8/GpuMCc9hMuymzOr+YlXo4z4 1xarEJoPOQOXnrmxN4Y30/qmf70KHLZ0GQccIm/o/XSOvNGluaYv0ZVJXHoCnYvTbi0eYvz5 OfOcndqLOfboq9kVHC6Yye1DLNGjIVoShJGSsphxOx2ryGjHwhzqDrLiRkV82gh6dUHKxBWd DXfirT8a4Gz/tY9PMxan67aSxQ5ONpXe7g7FrfrAMe91XRTf50G3rHb8+AqZfxZJFrBn+06i p1cthq7rJSlYCqna2FedTUT+tK1hU9O0aK4ZYYcRzuTRxjd4gKAWDzJ1F/MQ12ftrfCAvs7U sVbXv2TndGIleMnheYv1pIrXEm0+sdz5v91l2/TmvkyyWT8s2ksuZis9luh+OubeLxHq090C hfavI9WxhitfYVsfo2kr3EotGG1MnW+cOkCIX68w+3ZS4nixZyJ/TBa7RcTDNr+gjbiGMtd9 pEddsOqYwOs= Message-ID: <99bc1eef-7e1f-39b4-f0b7-59b6f52185aa@amazon.de> Date: Thu, 4 Mar 2021 15:58:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <24639.46501.489245.30690@mariner.uk.xensource.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US X-Originating-IP: [10.43.162.118] X-ClientProxiedBy: EX13D10UWB003.ant.amazon.com (10.43.161.106) To EX13D02EUB001.ant.amazon.com (10.43.166.150) Precedence: Bulk Content-Transfer-Encoding: base64 T24gMy8zLzIxIDU6MTMgUE0sIElhbiBKYWNrc29uIHdyb3RlOgo+IENBVVRJT046IFRoaXMgZW1h aWwgb3JpZ2luYXRlZCBmcm9tIG91dHNpZGUgb2YgdGhlIG9yZ2FuaXphdGlvbi4gRG8gbm90IGNs aWNrIGxpbmtzIG9yIG9wZW4gYXR0YWNobWVudHMgdW5sZXNzIHlvdSBjYW4gY29uZmlybSB0aGUg c2VuZGVyIGFuZCBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUuCj4KPgo+Cj4gTm9yYmVydCBNYW50 aGV5IHdyaXRlcyAoIltQQVRDSCBYRU5TVE9SRSB2MSAwOS8xMF0geHM6IGhhbmRsZSBkYWVtb24g c29ja2V0IGVycm9yIik6Cj4+IFdoZW4gc3RhcnRpbmcgdGhlIGRhZW1vbiwgd2UgbWlnaHQgc2Vl IGEgTlVMTCBwb2ludGVyIGluc3RlYWQgb2YgdGhlCj4+IHBhdGggdG8gdGhlIHNvY2tldC4KVGhp cyBmaXJzdCBzZW50ZW5jZSBjb3VsZCBiZSBtb3JlIHNwZWNpZmljLCBpLmUuOgoKV2hlbiBjb25u ZWN0aW5nIHRvIHRoZSBkZWFtb24gaW4geHNfb3BlbiwgdGhlIGZ1bmN0aW9ucyB0aGF0IHJldHVy biB0aGUKc29ja2V0IG9yIGRldmljZSBsb2NhdGlvbiBtaWdodCByZXR1cm4gTlVMTCBpbiBjb3Ju ZXIgY2FzZXMuCj4+Cj4+IE9ubHkgcmVsZXZhbnQgaW4gY2FzZSB3ZSBzdGFydCB0aGUgcHJvY2Vz cyBpbiBhIHZlcnkgZGVlcCBkaXJlY3RvcnkKPj4gcGF0aCwgd2l0aCBhIGxlbmd0aCBjbG9zZSB0 byA0MDk2IHNvIHRoYXQgYXBwZW5kaW5nICIvc29ja2V0IiB3b3VsZAo+PiBleGNlZWQgdGhlIGxp bWl0LiBIZW5jZSwgc3VjaCBhbiBlcnJvciBpcyB1bmxpa2VseSwgYnV0IHNob3VsZCBzdGlsbCBi ZQo+PiBmaXhlZCB0byBub3QgcmVzdWx0IGluIGEgTlVMTCBwb2ludGVyIGRlcmVmZXJlbmNlLgo+ IFRoaXMgZGVzY3JpcHRpb24gdGFsa3MgYWJvdXQgc3RhcnRpbmcgdGhlIGRhZW1vbiAuLi4KPgo+ PiAtLS0KPj4gIHRvb2xzL2xpYnMvc3RvcmUveHMuYyB8IDMgKysrCj4+ICAxIGZpbGUgY2hhbmdl ZCwgMyBpbnNlcnRpb25zKCspCj4gQnV0IEkgdGhpbmsgLi4uCj4KPj4gKyAgICAgaWYgKCFjb25u ZWN0X3RvKQo+PiArICAgICAgICAgICAgIHJldHVybiBOVUxMOwo+PiArCj4gLi4uIHRoaXMgaXMg Y2xpZW50IGNvZGUgPwoKVGhpcyBpcyBjbGllbnQgY29kZSwgeWVzLiBUaGUgcGF0Y2hlZCAnZ2V0 X2hhbmRsZScgZnVuY3Rpb24gcmVjZWl2ZXMgdGhlCnBhcmFtZXRlciAnY29ubmVjdF90bycgaW4g dGhlIGZ1bmN0aW9uIHhzX29wZW4uIFRoZXJlLCB0aGUgdmFsdWUgb2YgdGhlCmZ1bmN0aW9ucyAn eHNfZGVhbW9uX3NvY2tldF9ybycsICd4c19kZWFtb25fc29ja2V0JyBhbmQgJ3hzX2RvbWFpbl9k ZXYnCmFyZSBwYXNzZWQgdG8gdGhpcyBmdW5jdGlvbiwgd2l0aG91dCBjaGVja2luZyBmb3IgdGhl IHZhbHVlIE5VTEwuCgpJIGFncmVlIHRoYXQgdGhlIGRlc2NyaXB0aW9uIG1pZ2h0IGJlIGNvbmZ1 c2luZywgYXMgdGhlIGZpeCBpcyBhcHBsaWVkCnRvIGEgZnVuY3Rpb24gdGhhdCBkb2VzIG5vdCBj YXVzZSB0aGUgYWN0dWFsIHByb2JsZW0uIEhvdyBhYm91dApyZXBocmFzaW5nIHRoZSBmaXJzdCBw YXJ0IG9mIHRoZSBjb21taXQgbWVzc2FnZSB0byB0aGUgYWJvdmUgcHJvcG9zYWw/CgpCZXN0LApO b3JiZXJ0Cgo+Cj4gQXBvbG9naWVzIGlmIEkgYW0gY29uZnVzZWQuCj4KPiBJYW4uCgoKCgpBbWF6 b24gRGV2ZWxvcG1lbnQgQ2VudGVyIEdlcm1hbnkgR21iSApLcmF1c2Vuc3RyLiAzOAoxMDExNyBC ZXJsaW4KR2VzY2hhZWZ0c2Z1ZWhydW5nOiBDaHJpc3RpYW4gU2NobGFlZ2VyLCBKb25hdGhhbiBX ZWlzcwpFaW5nZXRyYWdlbiBhbSBBbXRzZ2VyaWNodCBDaGFybG90dGVuYnVyZyB1bnRlciBIUkIg MTQ5MTczIEIKU2l0ejogQmVybGluClVzdC1JRDogREUgMjg5IDIzNyA4NzkKCgo= From xen-devel-bounces@lists.xenproject.org Thu Mar 04 14:59:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 14:59:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93324.176155 (Exim 4.92) (envelope-from ) id 1lHpS3-0001ad-B2; Thu, 04 Mar 2021 14:59:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93324.176155; Thu, 04 Mar 2021 14:59:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpS3-0001aV-7h; Thu, 04 Mar 2021 14:59:43 +0000 Received: by outflank-mailman (input) for mailman id 93324; Thu, 04 Mar 2021 14:59:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpS2-0001aP-60 for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 14:59:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpS2-0005J0-2p for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 14:59:42 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHpS2-0006AX-1T for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 14:59:42 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHpRy-0005YO-M1; Thu, 04 Mar 2021 14:59:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=SKifOTVH4K20PQ20KfxjuWzSJP4teiRuzKbwZSfJ8K0=; b=F5DMOHCSrFvOTaSu5cJTfIdM2t lzRWLM3fw631gUhL67mGQnpDw2y5emeNrd+gXuCtQFFxsVVOYoLYGiz5GX/gcd2Mg2+h0U/uXzEdc hgmKDSykvuoNedxDVXcEmvYdzUs1aUI3xaprdqCZloIH5l3xW0NyHrxz3Y2aCo60h+Xw=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24640.62938.427877.757656@mariner.uk.xensource.com> Date: Thu, 4 Mar 2021 14:59:38 +0000 To: Roger Pau Monne Cc: , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior In-Reply-To: <20210304144755.35891-1-roger.pau@citrix.com> References: <20210304144755.35891-1-roger.pau@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monne writes ("[PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior"): > Introduce an option to allow selecting a less strict behaviour for > rdmsr accesses targeting a MSR not explicitly handled by Xen. Since > commit 84e848fd7a162f669 accesses to MSRs not explicitly handled by > Xen result in the injection of a #GP to the guest. This is a behavior > change since previously a #GP was only injected if accessing the MSR > on the real hardware will also trigger a #GP. ... > I wonder whether we need to to enable this option by default for > guests being migrated from previous Xen versions? Maybe that's not > required as the option is helpful mostly for early boot I would > assume, afterwards an OS should already have the #GP handler setup > when accessing MSRs. I think it's almost as bad to have guests which can be migrated in, but which then cannot reboot. Historically we have taken the view that new Xen must support old guests, even if that means being bug-compatible. So I am strongly in favour of avoiding such a usability regression. Which I think means enabling this option by default ? > >From a release PoV the biggest risk would be breaking some of the > existing MSR functionality. I think that's a necessary risk in order > to offer such fallback option, or else we might discover after the > release that guests that worked on Xen 4.14 don't work anymore in Xen > 4.15. Yes. Release-Acked-by: Ian Jackson Ian. From xen-devel-bounces@lists.xenproject.org Thu Mar 04 15:04:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 15:04:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93327.176167 (Exim 4.92) (envelope-from ) id 1lHpWn-0002UY-UE; Thu, 04 Mar 2021 15:04:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93327.176167; Thu, 04 Mar 2021 15:04:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpWn-0002UR-Qp; Thu, 04 Mar 2021 15:04:37 +0000 Received: by outflank-mailman (input) for mailman id 93327; Thu, 04 Mar 2021 15:04:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpWm-0002UG-7v for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 15:04:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpWm-0005Qj-4l for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 15:04:36 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHpWm-0006eq-3m for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 15:04:36 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHpWi-0005ZY-Nr; Thu, 04 Mar 2021 15:04:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=uT4CK0PIEjqmIu89qdI07TfJkHCeNCiWC0InLxpYT2Y=; b=qoY5DOkNL+0boGCDTvGw1/OGAy gqQzkHWAdO9+DT63KyFF5wyGGSUptTcAbH4sgN5acHfOKD90e6+RQ0ClJZF5VFMfpcHpL8QX0dKHq PGkCBQ02qKrhgljpXEUFWZ581FPzoaDGPhkq3MdknfnVAmQLhpePliOEieHWc16JzRjo=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24640.63232.437509.771806@mariner.uk.xensource.com> Date: Thu, 4 Mar 2021 15:04:32 +0000 To: Norbert Manthey Cc: , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth Subject: Re: [PATCH XENSTORE v1 09/10] xs: handle daemon socket error In-Reply-To: <99bc1eef-7e1f-39b4-f0b7-59b6f52185aa@amazon.de> References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-10-nmanthey@amazon.de> <24639.46501.489245.30690@mariner.uk.xensource.com> <99bc1eef-7e1f-39b4-f0b7-59b6f52185aa@amazon.de> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Norbert Manthey writes ("Re: [PATCH XENSTORE v1 09/10] xs: handle daemon socket error"): > On 3/3/21 5:13 PM, Ian Jackson wrote: > > Norbert Manthey writes ("[PATCH XENSTORE v1 09/10] xs: handle daemon socket error"): > >> When starting the daemon, we might see a NULL pointer instead of the > >> path to the socket. .. > > ... this is client code ? > > This is client code, yes. The patched 'get_handle' function receives the > parameter 'connect_to' in the function xs_open. There, the value of the > functions 'xs_deamon_socket_ro', 'xs_deamon_socket' and 'xs_domain_dev' > are passed to this function, without checking for the value NULL. > > I agree that the description might be confusing, as the fix is applied > to a function that does not cause the actual problem. How about > rephrasing the first part of the commit message to the above proposal? Improving the commit message seems to me to be needed in any case since as far as I can tell from what I read here, the existing one is actualy wrong :-). With my maintainer/reviewer hat on, I think this new exit path involves returning an error from this function without setting errno, so it's wrong ? As for the release, I think this is a very low-impact bug and now it seems not 100% obvious, so unless someone would like to explain why it should go into 4.15 I'd like to see it in -next. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Thu Mar 04 15:13:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 15:13:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93330.176178 (Exim 4.92) (envelope-from ) id 1lHpfR-0003Xq-Qv; Thu, 04 Mar 2021 15:13:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93330.176178; Thu, 04 Mar 2021 15:13:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpfR-0003Xj-Ns; Thu, 04 Mar 2021 15:13:33 +0000 Received: by outflank-mailman (input) for mailman id 93330; Thu, 04 Mar 2021 15:13:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpfQ-0003Xe-As for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 15:13:32 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 17d7fd51-760c-4bca-bf9b-e89f9c788037; Thu, 04 Mar 2021 15:13:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17d7fd51-760c-4bca-bf9b-e89f9c788037 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614870810; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=ldpjuXIS+rY5GR6s/hovUHOquDD9AgFBnBmj/RuxrDg=; b=VqHSinL+pw4dTXVivqGzm6QS+bFGyQ3eRqXkyATanwE9LmChS33cwkKj 0QNJlQ+Vz9gLq9LApkLVvg/suq2XB+DatPza8VcU5fTeCQ9CPVss94UJV 3WZuV8oK4gO0tqRSnL1J2/MnR/9jtURJk0X4cV+4Z7sTQkY/YW5Bw2amT s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: qp7zNqE4w3bNLoQzvrh7KjDMhQ7LujK2fnBnO88/QXEA10AXaGLLBvpm3wL/FQL3E4ZpqUQOPE 2wTf+X7toAc/dYCwS26BbYUM/eOnuVpCAXbAnbUBPT2Z1ZZRmACuIfTswejYN0riscfhrh3MgL NXZ5fdaotFrW65J8Bd5drNkJ8eK2mLhGamkLr9vkcFHwEvvZrRVw6tQIhE+eZ3YV4DNqmMsp2T SgYABcMmrg+71KcD8NC/UpOu46YwmaoChqWnrABLrWdgV2rgIG0FGkglN2Ks9B/STI4wb9jhGt L0Q= X-SBRS: 5.2 X-MesageID: 38558239 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,222,1610427600"; d="scan'208";a="38558239" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R3dfIWWWbITxt3Y5Cvh1zWX9bI4xmcaa8092C72D4RFJy22YPN/QzxQzMqd8AoDEVv36g064JKy+ILFxZaFZNppbhbwUqf9PBlg9YJfMoKc5dgd5cp9afvdM9btLjUH3oUilm1rPFlCiTIDNORlAVblzfwU6ENMkT4a4kr53P7am53FUNv9troD/Ek14BG7kRyOiiKOW5BmDQJ/wN0GIUS7J4f8BVmiX7kWgdAHhTQyKkQqJAEpkgUAag3iT98gOH0Bj5KwHLlDbvOvSpmwwZyEH0yC3ohcF7DTSraMOBSCeieLk80M/mRJB/mOs8ojP3nIB4imdfrJXRLXedho7uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AEKHg+sw75mujriAG+HiLsQ2suVIWOFFpQLooMyeiPs=; b=WPRHaWnyhaVgbkqYH6h9Q0V1bUM4vFhg1p/1ksMff5TGlLWimdIgi1x6OmR02Wf8bQnPtfrP93MUPQrWIIRujnxcTTqmtQ8uaBEsn6+ajAwH3TiueQqoPpNQ3yi5zfkyEtp+EEXwbOudVm1ggBWV47mRkanfvjgPut1O8DYzJxdU6S3HgtV/CDrlmfepsaDte2zNwfftRsijLMe+KgVzVBvFbDYd+I0t3AfC8k3IWCHfPtVB4LTyzC0X12tyAmWeNWY2Pr+KxXVyyB3+Ez3izhR1xHz/0INukzRXiZbdpP0n1BKrkJWVX4IiYJyCc2uv3U47G1oiLH3dBNBzbr0FhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AEKHg+sw75mujriAG+HiLsQ2suVIWOFFpQLooMyeiPs=; b=hpzPYOXy241y14Dy0mEIYxKp/J+hPwiW/CNBweEZFwR+MW/qVyUQj0IuQ6fYCfunaLpUlKN3lFwh+oSPzx5m2R+CcdZTbqy3vpNuJZm7wL/H2Q42ESeIIv1k9aEGIAZlMxDSXbZ2lm+GFd+Sh6yCRoz6+1gMd12IikV5iPbRMeU= Date: Thu, 4 Mar 2021 16:13:15 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ian Jackson CC: , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior Message-ID: References: <20210304144755.35891-1-roger.pau@citrix.com> <24640.62938.427877.757656@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <24640.62938.427877.757656@mariner.uk.xensource.com> X-ClientProxiedBy: LO4P123CA0382.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::9) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f404b2e5-ac65-47ec-d4e2-08d8df200c53 X-MS-TrafficTypeDiagnostic: DM5PR03MB3146: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wZj02z7Pe3+HWBQDHUjiL4YUdTmZfqxn3tvMdr3yYC0u+iRaMR6DALueDjikFGmzUJDbAUGUU4EJxf0kvobG5UGzXCn50slhpzUgRFKhkdCMN/gd92aDvu6ZIbHbWp5VS109ss4LEh8w8EdmOMFPqRwfYzxM+B4mHg7sPF0U8C76FhLzAAzBpgYn8O7gYk0CEchFNzhWdCKa/OoNwBpxmFGCkGmUws18UAPeWmW9kXfroFdrLGaWFLGPd4z7+FZurfd1q3VyEnpGBnGhB40bxY7bRGittn7iWuKbaWGxzJXk+b5qax7+vfW66sRvCi6Jxv3TpSCfIn4LpL7+MevMBWG8aXUzV0eldbIUxhBwNuNHYp9WeJ64gEthVhFPGWAFMSoSoUOKvcB0RRBWktBJ/UIT0Z2R0zMFLfAiWcabJdt1Wt5hOqAgsGfSZx2ZEaeXBYKNa9IT7zW2dI9SeU9IsbQ8kWwNoqSMqzo43jco1D+8c59eFCVLVFqckXeKzvW+pe3HBbpn5eaB9n88CC7/MNmw0UfRHKCxOcfXvqiAyyl94Re2BVgedKdIV0Kptjp3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(136003)(39860400002)(346002)(376002)(396003)(366004)(6496006)(86362001)(2906002)(6916009)(6486002)(8676002)(85182001)(956004)(83380400001)(66556008)(316002)(8936002)(54906003)(4326008)(33716001)(66476007)(26005)(66946007)(6666004)(186003)(9686003)(5660300002)(16526019)(478600001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VG11MHBEOG1nSHZ3a0FRbmkvaExDeGhob3A0RGZQS0thaVVKamI4VjNya2Nt?= =?utf-8?B?T1pDc0ZwWTErRUgxa2cwRld1Y0Y2L3hDTWpoSDJ1Vk9sSjdjMy9sN0tZT0NX?= =?utf-8?B?WlFONWVtMWNUSXJhRG1VZTN2NGY5dnNKZlczYTAzS3dUSCtwSHZSVmxBTSs0?= =?utf-8?B?OVZUZmE2NHdsejhBQ2NjR1pvWGhjanFtZTJjWTdNL3lhNUxiOXdwOU9abUcy?= =?utf-8?B?a1BrRUNCTTA0bXltZzNGUnpBa0FpS3RldjNidGdNU2JmOUxndkVUYng0R2p3?= =?utf-8?B?TG0wMTZHSXRqVk5uYlkrUytDdWhCaHRvaW10bXhvQnNoVjBXdVZJM2dScXlZ?= =?utf-8?B?Si8wM0xrVDd6c3JncFpoUmg5TTlGVVpWazlsMW1hSTZzb0lKWkdWb1VjTHZB?= =?utf-8?B?Z2ZlRWY2emliS1BVSm01cGlHelF5Vkk3NXNFZkJ5UXB1TTg5eXppSDBtZHds?= =?utf-8?B?bWR5KzNveWYxaHU0UlBUZGwyYjl1Y2ZJb05rOUNYaE9pd1pFd1RUS1c0UE5k?= =?utf-8?B?M0xEbmo1c3luM2dBemFvTmpFWG1VTkxuRGFtN3F6NWFMcGhhRm5vbWtZSGJN?= =?utf-8?B?ZUNmOThYRmx2ZDVxRFdqeXBJaENFcEdwVnYxTjdMTGNvTDhnT3NIWXl0ZUxV?= =?utf-8?B?dzMzNWV6SHlEQ2tDZDZEWUJmblVGSXdIbGwyZjZ4dDlXYlB6Z2s5alhlb0tm?= =?utf-8?B?aUMrZ3hUVnZrQkFjZEYveFhkclBYMGNWSDBuL0ZjdUwrMU1LMFN2OWo4RXV5?= =?utf-8?B?L0U0ZW9sT05WSER6U1c1SnVVR3g0ejNjM1pTcDEzZ2RTaUtIQ3BDVnUxYlpt?= =?utf-8?B?YUQ2K3gxOE9RaExoTldvaHVyMXl5RXFnb09RaDMxaUVPMXpYUUc5cEEyT3BS?= =?utf-8?B?SVM1ZkYxc0JHWk54bHExRHg5cHlUb21SbnVIYVQ2OWFaNHFsSEdHSjhHL2l0?= =?utf-8?B?M1Y3YnZyWjQxcHVUdkU5ODRjTnhZMlBjcHZCS1RTWGJaSFZ2VlNVcktQNWU2?= =?utf-8?B?ZUlBQ3VMdE42OTRUQmhMZG5OSjIrTVNhV1J2Y0RuZ3RzM2o2VmJ3d2hBRjdi?= =?utf-8?B?WFJHbEx6UkVGLzdTOXFDZkJmQVVzVUtjdmpVcFdxZVpzRWg5a3BRSHUwOUNm?= =?utf-8?B?eFUyMUlUQURGTnpEY1YvRUQrRlF3ZlNJMjJRZ1lYTGNMNFBkc2hMNkxremky?= =?utf-8?B?WDhYQUZ0Ymg5dXFQTDZIVU1JU0d0aG9SL2tEWUJjRm5iakR1WnR0TXJpWEt4?= =?utf-8?B?K2I3bFJ3eGN5TkFLTTNZZWg1VkRXZTM2dzV0YVA4eTZyZnc3djh2eDRUck9t?= =?utf-8?B?bHRGZS9KMytIU3BBL1ZrSlhOSWpZMUN6REdMTWNibFZGMng5QnlwR2NvRXB3?= =?utf-8?B?Sitjaks3QU9hVEQwcGJPYkFNWVBSTk52UGdmK0IrQk5weDJlMzFTVzVMUHpW?= =?utf-8?B?ODRoZ2YzdXhwWENhb09DUVEwVzZtRTdjcEZUSklKRDBGRkhGODQ3dTlVUTdE?= =?utf-8?B?c0pGN1FnMEg5VUdPRXRVMy9ya3pzdmNNMkh2ellGVzlRVGtpMFI2M0p3b1Vs?= =?utf-8?B?eWljUnlkakJRNjh0TkdnT0dzL1ordjJXM25Pb0krSmxFRTNpVHlJRzA5Q0Qw?= =?utf-8?B?QlY5WDE0dk95K29aRUg0UjM0MTZnVW1PUm00VGZZWURqVTdCRDdWaVk5MjZY?= =?utf-8?B?WFhhVyt1K1kzcXpJRHNlTk11ajRwVGk5T05JNG5PUE1iUW93Z0FOazZwVDMv?= =?utf-8?Q?oXvI/kkNtCmj1CdndTlxoH5jPt3AAcj3/FhMioD?= X-MS-Exchange-CrossTenant-Network-Message-Id: f404b2e5-ac65-47ec-d4e2-08d8df200c53 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 15:13:21.8383 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oTXM9Els0B0DR8it4ti8jcjwpLO2CH9hv1fNcoT2qBrAE0vL2yLoJmE0WumYFvvDhhblScFlZNi0qUgTI7b12Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3146 X-OriginatorOrg: citrix.com On Thu, Mar 04, 2021 at 02:59:38PM +0000, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior"): > > Introduce an option to allow selecting a less strict behaviour for > > rdmsr accesses targeting a MSR not explicitly handled by Xen. Since > > commit 84e848fd7a162f669 accesses to MSRs not explicitly handled by > > Xen result in the injection of a #GP to the guest. This is a behavior > > change since previously a #GP was only injected if accessing the MSR > > on the real hardware will also trigger a #GP. > ... > > I wonder whether we need to to enable this option by default for > > guests being migrated from previous Xen versions? Maybe that's not > > required as the option is helpful mostly for early boot I would > > assume, afterwards an OS should already have the #GP handler setup > > when accessing MSRs. > > I think it's almost as bad to have guests which can be migrated in, > but which then cannot reboot. Ups, yes, right. > Historically we have taken the view that new Xen must support old > guests, even if that means being bug-compatible. So I am strongly in > favour of avoiding such a usability regression. I'm not a xl/libxl expert, but couldn't we set the option in a persistent way for migrated-in guests? IIRC at domain creation libxl knows whether it's a restore or a fresh domain, and hence we could set the option there? The part I'm not sure is about how to make it persistent. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 04 15:20:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 15:20:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93332.176191 (Exim 4.92) (envelope-from ) id 1lHpmJ-0004Sq-JQ; Thu, 04 Mar 2021 15:20:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93332.176191; Thu, 04 Mar 2021 15:20:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpmJ-0004Sj-GH; Thu, 04 Mar 2021 15:20:39 +0000 Received: by outflank-mailman (input) for mailman id 93332; Thu, 04 Mar 2021 15:20:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpmI-0004Se-43 for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 15:20:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHpmH-0005gw-VO for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 15:20:37 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHpmH-0007ml-Se for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 15:20:37 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHpmE-0005cl-MT; Thu, 04 Mar 2021 15:20:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=9x18qLadbxkQpIoQsoR+n91O/1aBxffFpXjJUt3fBMQ=; b=VGEH90BJDdM4enpv0Ljp/R5DuB 1aqUkmHJKrAIzOn+td44M51ukgWt49zWviisiY0UZvDUauuVckAC88roiQl05hDhBLiT1dP3iukkz FFpXjiJfWmBzux+V1VmGjjGS9KKUmBSyfJpHWJas2zzt+pfSVrqdI7i4HOjX+pMFpRow=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24640.64194.445736.52546@mariner.uk.xensource.com> Date: Thu, 4 Mar 2021 15:20:34 +0000 To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior In-Reply-To: References: <20210304144755.35891-1-roger.pau@citrix.com> <24640.62938.427877.757656@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monn writes ("Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior"): > On Thu, Mar 04, 2021 at 02:59:38PM +0000, Ian Jackson wrote: > > I think it's almost as bad to have guests which can be migrated in, > > but which then cannot reboot. > > Ups, yes, right. > > > Historically we have taken the view that new Xen must support old > > guests, even if that means being bug-compatible. So I am strongly in > > favour of avoiding such a usability regression. > > I'm not a xl/libxl expert, but couldn't we set the option in a > persistent way for migrated-in guests? > > IIRC at domain creation libxl knows whether it's a restore or a fresh > domain, and hence we could set the option there? > > The part I'm not sure is about how to make it persistent. The guest could be stopped with xl shutdown and then recrated with xl create, from the config file. I don't think we want to break that use case here either. Ian. From xen-devel-bounces@lists.xenproject.org Thu Mar 04 15:57:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 15:57:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93342.176223 (Exim 4.92) (envelope-from ) id 1lHqLq-0007kJ-Qh; Thu, 04 Mar 2021 15:57:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93342.176223; Thu, 04 Mar 2021 15:57:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHqLq-0007kC-Nh; Thu, 04 Mar 2021 15:57:22 +0000 Received: by outflank-mailman (input) for mailman id 93342; Thu, 04 Mar 2021 15:57:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHqLp-0007k4-Ir; Thu, 04 Mar 2021 15:57:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHqLp-0006Iw-FS; Thu, 04 Mar 2021 15:57:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHqLp-0000yK-5A; Thu, 04 Mar 2021 15:57:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHqLp-0007OJ-4g; Thu, 04 Mar 2021 15:57:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Lfh/dCaBnIUklabzrUZD0lKogiKKZaxwjq1JEVBjxzc=; b=c26b6S5k8bIF9i+Owc7gaHdKJY jSq/DvpRrAYAP7cxh7TUIpIrnjobNz+p9cEVsb4G+iNulaS9MaGETL6lEYmsIL20DeC6m4bXRKykr g7ZxCzlXVrV40x3+GVOP9Np7VFeq1Tu30CBAUDmAxmccv1/2OyMjWuKeTf0+VO8/o8ds=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159823: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f69d02e37a85645aa90d18cacfff36dba370f797 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Thu, 04 Mar 2021 15:57:21 +0000 flight 159823 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159823/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-examine 4 memdisk-try-append fail in 159818 pass in 159823 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 159818 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 159818 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux f69d02e37a85645aa90d18cacfff36dba370f797 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 215 days Failing since 152366 2020-08-01 20:49:34 Z 214 days 372 attempts Testing same since 159811 2021-03-03 03:12:26 Z 1 days 3 attempts ------------------------------------------------------------ 5136 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1271901 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 04 16:56:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 16:56:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93351.176238 (Exim 4.92) (envelope-from ) id 1lHrGd-0005eB-E2; Thu, 04 Mar 2021 16:56:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93351.176238; Thu, 04 Mar 2021 16:56:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHrGd-0005e4-Ay; Thu, 04 Mar 2021 16:56:03 +0000 Received: by outflank-mailman (input) for mailman id 93351; Thu, 04 Mar 2021 16:56:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHrGb-0005dz-JB for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 16:56:01 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 72ed6a25-e84a-4ea7-845c-034df5f6fd01; Thu, 04 Mar 2021 16:56:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72ed6a25-e84a-4ea7-845c-034df5f6fd01 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614876960; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=PJJlnvYNHcxT9lZlo/b5+Q0KHca4J59ZGhGT1OADYd8=; b=a+ZNs8ri6+CxRjwJmumXtoCD3zclgNrwTeTDnu8eLbWMHw6O+tn6LOKW EVrkjIEGrUeYFHr2B3zjPvnVEfjulhIdW3zUFhWqONxEg7DlXLXHUnsWx bDBBMSgQFiZBvaxfC0MxQudeLIN7LJU+gugBEBdsdngjtiYSUjf+pkhUF U=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: G3EsBo57MsW2HtMflzQ1AWWegbfShFRTctUHojlO49MqfQDwI+COPZqd29dyyYpO7LOChiRpIf 4dpVLaqbB5dGgJ/6qZ0ulckvLGI1o4EV2RQhfBonGIhYUNXQBi/kTa9IIVQEFuysCWxX1LZSB5 Atp0BFVkrVLF/+wco+CMyxzDAvlBRNNi3epB1Q6YECU0i9ioGpfrCVAG/ozZapyS+acN+GVLfa xjbRQ7mDT2Lz3+kWRs3IDsJMUAOFpdHebslKGJHhnd2mgMLLcsygnQmhNEoNtHYVMqIBgHkLc4 Wic= X-SBRS: 5.2 X-MesageID: 38744378 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,222,1610427600"; d="scan'208";a="38744378" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kWfWaqOf/8BLfbDQPtkRd3dzh3I4Uav8u77BtLZ857mNqMtwHcSDuhlSTIgwFhGcjzEVdyYkH6ypMN0jBsoP7Y4NKY9Uipxt5MRzSfIka9+YEzOYoNjC2mH4f92q45+HtHIKDCfCp8GsfVGUnAwuAsgH15cT+/wSeKJ/1qRqVTcL+L8GjI9IMq5iUVlJFvXVfj0lj//quHTS6Hdvu5iofmWGKiZYYskKraq041dlHLebU3jeYQpht/pTmENGRyk3N9ZBXJQ53yoHi1A6e4UGMwEs86XG81SL9yVgQgiclewAenmucmpqTRtR5vnZMeCYha3qUt+T0yKUCikgioxc7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/5SmDKXuVn7S3cH1SIFYf2ARGTPUYV/bVlvugpYHpXI=; b=bg8t7k6qHCVqF0RPiHrQUaaIX8Qzv04+a/3BZcpBioORG4ZbfhTxcXvAd9xQGIKumATnpfCdP85/mhzrU/7NB6dOzaMPlRfjHEcwbL+I6/t0sCUNU//dUk9zcg2ea95nM2ra3j2A6iFp2HSRatJXhWm1Jccts2aWsYmj1kM8MzofuK0oEHFkyrLBCC1UCTLFOiOaNNgYZeTNJTMHI1wv2/v/FrXk4MLIXw+tUWaKho3C4669feXtPrPC99CYLwwKqNN/FXtgcAuCwZa0OEdOqwCR2P3wl25MFjC7gWCHCO+BU32seXczYTT9vXGxUVR2PtW6gKqJAyJX7Y0wR9mvrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/5SmDKXuVn7S3cH1SIFYf2ARGTPUYV/bVlvugpYHpXI=; b=SnhIr3z9DLVBJZl+U7k0XhBqY4HYbaQnPfzWd5REbtOqi+jwoHhotD6v9/4zPwYSIGLRbQ7oWORvgrYzhz8DVebi9FsPZbs6cU9VxRghIV0nUsA8dgFaGur7CDWvegfGiCS8DacQNXL+CNtre3eMwGhKoo8CxCIQVDsyuKZWC8I= Date: Thu, 4 Mar 2021 17:55:32 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ian Jackson CC: , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Jun Nakajima , "Kevin Tian" , Boris Ostrovsky Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior Message-ID: References: <20210304144755.35891-1-roger.pau@citrix.com> <24640.62938.427877.757656@mariner.uk.xensource.com> <24640.64194.445736.52546@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <24640.64194.445736.52546@mariner.uk.xensource.com> X-ClientProxiedBy: AM5PR0701CA0050.eurprd07.prod.outlook.com (2603:10a6:203:2::12) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24c848dd-9c8e-4fdd-a61f-08d8df2e56a3 X-MS-TrafficTypeDiagnostic: DM6PR03MB4396: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xYJSAvKr3ibcgO3yOVt3MsoKQAmYLLJebJd47kksatjcyh9bQCyVOuFYxKlz+ZtS8ow92CzJZZzUseVNf8ERAjox2SJBIj8wOneLBA8Ks3ckdtAFOon7edgM5QquFztW93xCJEpGVtGOeiJyqR1N8/0Kf+E7wirH0J1z+EtduaF0yTg4fq47duPhyquXXRIdADtJw/CystHCmnUDaDO47i8V6yPt5dbAYY3MXhRXjbZRLwVT63JThUr+05KWjAg3+JQARn9HtZwX/4B9NEBu4rc3N2JKgAljGeyPx00QCQMMaO0Re2qnHiUV2PSmhzzcP8rTuXpYPdvdmAHpvW3/SOKcTdV12b1rJRDZ+7XM3kfM1tHSQavaf6jH3ZmLOKpxzxRf7ZFdQTThH9bpMbdv+M7aH7Gp0GMYFyZkk6HdRpcoC5KZelI+AI6eQjnYRhJWOtvVmHHsDpb/YBXYjJ7l8zS1+S32T01sNqT97rtMDmpoyP5C5ihJKtVhDXdJWaVgQ+93w7be3rKobbLIG51kxw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(396003)(366004)(346002)(376002)(136003)(39860400002)(6916009)(66476007)(6486002)(66556008)(66946007)(4326008)(5660300002)(86362001)(478600001)(9686003)(2906002)(8936002)(8676002)(85182001)(33716001)(956004)(6496006)(316002)(186003)(16526019)(26005)(54906003)(6666004)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?TWVqYVF4WGVYVWpXWmtMY1Y3aE5ZQnE5elVFMEZHYjNvcjVTU05BTjQvOGxy?= =?utf-8?B?ZlBlM1ZQRzRNNy9JVGZ5bnhwamZuQTd4ODNPZ0hWSWd1NnlPb0VkcnZvYnNi?= =?utf-8?B?SVRZSmwxTHZEZFhxT0FXVGt1UFhEdTRDVjl6QnFwU0wwMmJrTHppN1hWKzh3?= =?utf-8?B?SlZUR3JCeXBLNkRTTjQ0VlNIdGpGZGx4R3lGcVl2RHRuaHF3WEczSjluczFp?= =?utf-8?B?WDBNY0liakdRM1JLaW9McUhWZUgvSHNrVzI5RDB0WHlwUG0vaUsyRFRxM3Z2?= =?utf-8?B?TzRCbWlPNjE4N1VCbWJqT0toSkdyNzhIZUkvMHVsYlZLeTdtcmN2bFRoL2Q1?= =?utf-8?B?Tkl6SkFIQVhQMG5BeHE2UitCYjBEZWhicFVhZHpXM3ZMd1BXTmRoVFZteVJF?= =?utf-8?B?djg4UHJONDQrdllKSGhlY1Urckk1Nzg3QkRFaGdEZ2xwaWR5TGttRVBpemht?= =?utf-8?B?aW9mQ09FM0QrZXJLc0VCR1JFbTFlM0ppalpGQTRsK1hDVFU0andJdFRKOVBL?= =?utf-8?B?QStSK3VlNTQrdjhlSHBqbjE1WjU2ZnJUNmN2NzV6c2VrTVRVWnhyT2kwSXEw?= =?utf-8?B?eUJCMmlaUjdNeWNHbFRkYlFQKzlxWXZPckR0YjlZRlYwUm9tbEQzM205MUx0?= =?utf-8?B?aTU4NFQ2TVNhYnZDUWh0MVcwTCtwbWw2NndEamZleS9yV3loUENKRW5mTU0w?= =?utf-8?B?SzJKaEJqeC9QUlJDU1RyUktxZFluMDFnRTZzSCsvMnVhc1MxTmpiQjUwd2p2?= =?utf-8?B?OUJNQ0Z3aEJjYWcvVFJ4ZVRobEpZQ2IyYnZVcytuaURpL1V3VDRvWnlaWXBk?= =?utf-8?B?RzhQd3VMY3ZiNlVyRVQ3VHJtKzVZanQzVkI4bGdERXJEZDY0SEVETUJkZXBz?= =?utf-8?B?bVJtcGxzb09Fb2lOdldKdHJ4eHlCWHc4V2hjK1BtTnZvdTJBQnNuYnVBbFcw?= =?utf-8?B?bXlKcnNxMHZwdG90NE9oZkNxcmt5ZnY1aTlSTTNBeE5SZzhsL053dzNKbnNJ?= =?utf-8?B?OFV5SDlUc1NNaDVvejkyRUphRFlDcytXeGxXRWFRQ3F0UjlUdDNkUk1qZVB1?= =?utf-8?B?RU9JaFgxdk5vQ25BNW9xb1N2YkxYTlo4YVVhNmZJUEkvdHZoczc3a21yZDd2?= =?utf-8?B?VzNCRDYzS2wvTy84aS9LVmZ6YzVsSzVHbWNZZXYweE9LZmNPZHZyOFo5RENa?= =?utf-8?B?b0RyNWd0S3VjT2p3N2ZDUXZuT21WYityTEpvUEN0RDRJOTFONzFIaFZRU0Z1?= =?utf-8?B?UlFMQ2l6bk5jY2ZOYmV6SWt4bnFsdGxNSE1ycHdPdnJjc2kvQzlldk8wOU1D?= =?utf-8?B?eVd2bzMrZUpSMWJnblZhVFltek9Na2wveTMydk5KL1RXV2IvajQxbGtDQWVr?= =?utf-8?B?MUtuV3J2bWUzRm1USzhYTW1HcHM0WmFLNGtTVkJ4cmJHRmF2RXFGWnI5ZlZi?= =?utf-8?B?Qjg3dHdTY3VJQnNyMjI1aWsrOGc0RC9aL1preHJXVURvUzJEZ2dyYTdxajlk?= =?utf-8?B?MHZFYktxdFd4SUwyQkdUeEd3N1JaQjI5Q2tHeTAyYkpIVHUvV1U3d2ZNblMv?= =?utf-8?B?cGJPbEpETE53MHEwSm1JZzRHeEU2dlB6a3YzK2laNFFiZHVFeWN3TXFPMHJv?= =?utf-8?B?SVdka3pXbHpwaVJwWFZ1Z2QxRWlJbkV1YWVGNnJmSGU3Q0hjWTlxcGhCOW8v?= =?utf-8?B?d2c5MGdHL2dUUklGeXF4SXN6L2oxVHYxaEkzVjRqRGFqVWRiUmN3VmtpMW1W?= =?utf-8?Q?QukHMKbOkdQcW2dHhA6iEwursnF9eKtavW7EuaF?= X-MS-Exchange-CrossTenant-Network-Message-Id: 24c848dd-9c8e-4fdd-a61f-08d8df2e56a3 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 16:55:39.0110 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pIMDRYIuJWYltJl6RXF2cU3vwJe3RIbanq+g/R6PLZxhZZjBChXfWSO1fpRnYZab9mZhhf6e7Ervsw36VwbXYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4396 X-OriginatorOrg: citrix.com On Thu, Mar 04, 2021 at 03:20:34PM +0000, Ian Jackson wrote: > Roger Pau Monné writes ("Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior"): > > On Thu, Mar 04, 2021 at 02:59:38PM +0000, Ian Jackson wrote: > > > I think it's almost as bad to have guests which can be migrated in, > > > but which then cannot reboot. > > > > Ups, yes, right. > > > > > Historically we have taken the view that new Xen must support old > > > guests, even if that means being bug-compatible. So I am strongly in > > > favour of avoiding such a usability regression. > > > > I'm not a xl/libxl expert, but couldn't we set the option in a > > persistent way for migrated-in guests? > > > > IIRC at domain creation libxl knows whether it's a restore or a fresh > > domain, and hence we could set the option there? > > > > The part I'm not sure is about how to make it persistent. > > The guest could be stopped with xl shutdown and then recrated with xl > create, from the config file. I don't think we want to break that use > case here either. So my original approach was to actually risk breaking creation from config file and require the user to set the rdmsr_relaxed option, and report the problem upstream. I think ideally we would like to get to a point where we could drop the rdmsr_relaxed option, but maybe that's too optimistic. We have done quite a lot of testing of this new policy, but obviously it's not possible to test all possible guest OSes. Forcing the new policy by default might be too risky, so indeed falling back to enabling this by default could be the only solution. The main downside of enabling by default is that then we have to resign to always having this kind of quirky behavior for MSR accesses as the default. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 04 17:13:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 17:13:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93356.176250 (Exim 4.92) (envelope-from ) id 1lHrXN-0007gf-0z; Thu, 04 Mar 2021 17:13:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93356.176250; Thu, 04 Mar 2021 17:13:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHrXM-0007gY-UG; Thu, 04 Mar 2021 17:13:20 +0000 Received: by outflank-mailman (input) for mailman id 93356; Thu, 04 Mar 2021 17:13:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHrXL-0007gR-Dk for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 17:13:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHrXL-0008E1-7a for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 17:13:19 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHrXL-0003Vw-3Q for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 17:13:19 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHrXH-0005qi-MX; Thu, 04 Mar 2021 17:13:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=+3bPWeNO4cRWraA/arRquDBv6TCVSBgSkRs9wkbBh6g=; b=svo0Cpxu/XtfuEPluaMtfcP3Qx uFr+h31rbMDz+1728pxUp1r5xYKtVHkoVikUmiBzO04Y0vCvyJ5t9qoNIons6+UfzWjApnDikmqXY LTP8lCG8p/0ZlC9SLiRihOSIttqZgb2Ek410u+/XOevHp1iOomtBDGpW15rP7/WZRZDA=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24641.5419.379341.215528@mariner.uk.xensource.com> Date: Thu, 4 Mar 2021 17:13:15 +0000 To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Jun Nakajima , "Kevin Tian" , Boris Ostrovsky Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior In-Reply-To: References: <20210304144755.35891-1-roger.pau@citrix.com> <24640.62938.427877.757656@mariner.uk.xensource.com> <24640.64194.445736.52546@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monn writes ("Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior"): > On Thu, Mar 04, 2021 at 03:20:34PM +0000, Ian Jackson wrote: > > The guest could be stopped with xl shutdown and then recrated with xl > > create, from the config file. I don't think we want to break that use > > case here either. > > So my original approach was to actually risk breaking creation from > config file and require the user to set the rdmsr_relaxed option, and > report the problem upstream. I think ideally we would like to get to a > point where we could drop the rdmsr_relaxed option, but maybe that's > too optimistic. Isn't there some way we can move in this direction without the first thing that users experience being their guests not being able to be created ? Maybe we could print a warning on the console or something ? > We have done quite a lot of testing of this new policy, but obviously > it's not possible to test all possible guest OSes. Forcing the new > policy by default might be too risky, so indeed falling back to > enabling this by default could be the only solution. > > The main downside of enabling by default is that then we have to > resign to always having this kind of quirky behavior for MSR > accesses as the default. What would stop us changing the default later, when we had a better idea of the set of RDMSRs that need to be special-cased ? Ian. From xen-devel-bounces@lists.xenproject.org Thu Mar 04 17:44:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 17:44:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93359.176262 (Exim 4.92) (envelope-from ) id 1lHs0z-0002Dk-A5; Thu, 04 Mar 2021 17:43:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93359.176262; Thu, 04 Mar 2021 17:43:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHs0z-0002Dd-6p; Thu, 04 Mar 2021 17:43:57 +0000 Received: by outflank-mailman (input) for mailman id 93359; Thu, 04 Mar 2021 17:43:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHs0x-0002DY-Hc for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 17:43:55 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4fa647cf-ebad-45d8-a2bc-f3559f40d516; Thu, 04 Mar 2021 17:43:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4fa647cf-ebad-45d8-a2bc-f3559f40d516 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614879834; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Hm79e+OCa+e9Tm6AtQyhrXxWSkmiauxNJJC8IH5sNNE=; b=XeWwjRIxl6n7wiaM126d7EdPJXcqjLNlolg1+hUE1Ty6s7Gkhx1ucxO6 889EP/FieOQ2VkuH3bYkmUk0pG/6Ad7Kmz4m75bFdmwNSiykU75stvT68 i/tSD4+CVXL+y3UKgCIYiUNIx9pLglIoeTH60IPQSbGTW5NKy1c1aT2vn w=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: NbYSviL9vSXgLauD0vjMO07HeWU6M0V35KaAqG7Tmv+LKenc27fUBUHkyLyuGeHNbN5QN/hKQP fcDZ+VYKaOxWxIOLnp5J4KDF+AnFVjXnIFj5s5d6BJq6iOj2UIh8VG73mnK2RPkK/IHe1985GF anZMgPbp4U2wTXQDtKKp714xZEZpq3hetHItvW6tkL0EMzOUesLR8z9R1OQSwXNBJSSZbSN91A 0SNGtlFNCstZU78KZpYOOVX1ExhRgNEj5rSsCa7AjkoO9aRoAJGgwP8Gn7VYrgDEtXyRbvhjnw U4A= X-SBRS: 5.2 X-MesageID: 39971285 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,222,1610427600"; d="scan'208";a="39971285" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LqAdiI0mU6SrwDCdeQtNi9OcdeBNCp00BVgkunTipNEB94VQbTOAEsaQFNK+Mx6LF33NmS9Oo3fopB1DJGSb6KpAvaTycXYyDmn8yAYB+PwyucWMbWPOwQ6emtsRz7z22G7EDP4Vk0yFS/3RB8BbuEkz5EtiUjFh0vLWbDB3kVwD2OU2xx4YaxjWLBZQb7ClzxkqO8iATXZ9ntnMluxxXc39prpZQQwyu/ka+OavtQJDhPCOhn4M30xqrUzCZT5SNCgpFEXR/jdwy5A7YyZfLHMvCGOSajK7Fgj52wT4mez1UMiiG+eb8fSG4ZZBaHT/Ki98AHuz4FXYkxmjJuqS+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bSdFpfSRkuzbYTSqVwBf1q9Rq0x+HVWqOqbJ2/xel2U=; b=GFqREsYOJVBCykl5NVe6JvomorqZmsrFtuwASPTpqKiPIUOd7StlsdTMlXbGpwRcgJqmhHAspc6MRhG1aKijgs6pSaIH1FCupz88MPAcVDDVRERfd62KNyMYP0UzuAzbs1L3p66IzShfTb7nlG10XOqPyHmBqLJaDpJ4IDyU7q98XTSmdobykZlaEcrddbiNE3urAfz1w+vcgrVLCv44or4VXPgY0f9G7EUvkWxZmoWUI1l8QeMUILaXiIyaSGvz46WxN90juebgrwWULZHU0FDdD4xjEMQ89XaDUBKajkPAZCPI+M1GjK3sR39yzNibdjd+nMeu7F0EP2evGyhznw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bSdFpfSRkuzbYTSqVwBf1q9Rq0x+HVWqOqbJ2/xel2U=; b=BRy7aX24lEhp0dvpj5WKbUVdcYW/98Qd6Uj1phpv4G7o+UIAq3zrw+wXmkDa2Abh4D5Da+tICjO89cd8w1Cx1MwYSzDE2jiiHmK5y3gnEbwOiPU6ynakeB40q3qHdk+8dRsNTnWc132UBhPtrVtra/TIYnLGDtApxnJ3SZoZjoo= Date: Thu, 4 Mar 2021 18:43:35 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ian Jackson CC: , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior Message-ID: References: <20210304144755.35891-1-roger.pau@citrix.com> <24640.62938.427877.757656@mariner.uk.xensource.com> <24640.64194.445736.52546@mariner.uk.xensource.com> <24641.5419.379341.215528@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <24641.5419.379341.215528@mariner.uk.xensource.com> X-ClientProxiedBy: LO4P123CA0249.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::20) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7aa9e20d-7c62-4c78-af3a-08d8df350b9b X-MS-TrafficTypeDiagnostic: DM4PR03MB6047: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eHw5QFzDuAoBLHOB4dq44Jndvi6mid3WaJ+cKju+5v3wmA8JP5AHk+9kB+SjQOUtzGRp7eKA3W4dXH0rzJTfw6egaxKvDZk10+TN7dGKCpwDQWoJCXHlJDvFwJ1wr5RC8Zek9XwYSR3G4jr8DcvZxPF2bqvAWzVdburp6+yYWzJ2e78lDMNFXaTzglwrH+Y+P9/8PmP4Vrn0h0l4P3OaYmwEZh770vd3Btx9MJV9OmMs6IZLHO0TLldO3Xjyk3OXRvTSKFWaDdXAoXJLQN2DZ88QK8TmylS4raa8SyL++clM9fE/uB8ZbHJUwkguFdPmwB/H3lxjDTqv/mow96Nr0M4dIyeAdqxF38WycFaEVglwdcwJjz1roIymnn158L4rQVIhM3ENdWqncjT5Kbn/uyUl936kx7viFcbS1s+lVk0jdnnqz7GHQpGS3ligC6fdMvx1EPduEHwgWVM/SxC4ASyN04j8JzAY83rY2VNiU8RfKwPM6+wmmCYrFcvcDqcYTHC9f/EX4h8WrT5i0Zmtwg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(39860400002)(376002)(346002)(396003)(136003)(366004)(186003)(16526019)(83380400001)(26005)(6916009)(2906002)(54906003)(6666004)(6486002)(4326008)(86362001)(956004)(316002)(33716001)(66946007)(66556008)(66476007)(5660300002)(85182001)(8676002)(9686003)(8936002)(478600001)(6496006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZFNUUXpmdDdSOWMxalBLclBIUUQ1ZG9MaVFIL2dnbUJEb3I0cXFTU1BWYlVp?= =?utf-8?B?d3NjcW1PZWhNWmhHb0l2R2cxRDd4aUtJVGptcHN2UWVBeE85MUkzSmtURFh5?= =?utf-8?B?bktIQUUyeUQvZGdwUXJ6SUVGR1MxWFlqZTdmVWpOUFRuZnhkbjRzY1dXQ0lt?= =?utf-8?B?bFF0VTM5dmZxN0dteGRzaFVXTWU1TzJmeWVIMkpBdko1K25vNFUxclp0MDlj?= =?utf-8?B?T1FHeDRNMGtQdTYxdXZSUThNS09WTVRDc1VRMi9nSnVzeUVISGNTdFh2RXZO?= =?utf-8?B?T3lHRE5DaDNSZVdBdm5VS0tZY1VEZzJ5dVowa2tLaEFVWWw1NTRuZDFNemhK?= =?utf-8?B?RjQyS1dQeThBbit4L05WVTVwZ1NhU211dSswZURSUjVIQ1V1UWd4OC8wUTZv?= =?utf-8?B?dk1kZUlBc2ovQ2lSSDR6ZjRXU2xndzRwYkdmNjdHWmRsMTFiV0J5b0YyS3Rv?= =?utf-8?B?cDdpaU50c2Z6UzhkRlN4c3VJdk1RZldJYTd0OTlkRzBYK2VJUTNkU3hjNEpO?= =?utf-8?B?MnBxMlNKSW9vNG5UaW1KbmFKbFAvZDl4eENvUUJxbU10ZE9CTFp1MjhDRjBh?= =?utf-8?B?V1BUSmVjL25yaGtDMXBuQ1lQVTZLUGVjNFJ6RTNQalZ3T3Q4TGpKb0FjOWo5?= =?utf-8?B?Ni8zUVlMRDc5cVVCSlM2ZlZteC91VDJ2OWtMRUd3SFB3Z2l6bllMRk9PWTM5?= =?utf-8?B?RWhMbXlpVEgvNjJaNnZ5S3JNY1Jlb3FvTVpJM0VvTVRMN2JtZEtYRXZGbWRM?= =?utf-8?B?QlFDWEFxN0pEaHpHNU85dTA2Q3Yra1o2dURTVUlISjlmR2tPWjc1clg0Si9N?= =?utf-8?B?TVRuY0tScVNxa2x2c2FNUXN6TUx1ZEZnV3ZXVTg0aDNicHhNMmVwZnB0TWMy?= =?utf-8?B?dml3SlJDZi9NNml5ZDIvdlA5c0M5TFh6VUYvOGJuVzVvYlJweHRxR3IzR0Fs?= =?utf-8?B?WnVzUnpmVWtIclQyRXhjSHdJNEtSMlVNK1hBcXQzbk9CRGt1Zytzd2c4dnVT?= =?utf-8?B?bHpuYXgzb0szeWsxbG5xSTA3T1VtbWhyelV4YU1uVVN0aG81VDFBYUFWd1N3?= =?utf-8?B?Y0dnb0UrdXJkMW5kMmdkWTg4M2x4THJmSzloSEozd2U3Z3A4Y2MzTk0vWGl2?= =?utf-8?B?UEV6bjB0bmxWUUxwU2JsVFBmVFpLMVhMSkc3dCtScmZUdk01VjBCajY0aFll?= =?utf-8?B?dkhCUDhKYUt2ZmI2QUFIYjFpbHVFSUFYVmlhR3VKem1xUlNwQVNVTWRVdmV0?= =?utf-8?B?NkYyZnM0RWM5V21Gb0hXdCt1cXArUTM4Z0dhMGpsVElkQVA0cmp5cHdnMWY3?= =?utf-8?B?cmYzOUFqbDAxZlBIQXFtelFBdUJJaG1uT3htNXY2ZXVRR25UaWlqbXpKQVk0?= =?utf-8?B?by93ZDBaUjRhYXp3Z1E1ZmxQK2pjUjRMTE9saFVjZldEbk9XTG9sb1dac3Jh?= =?utf-8?B?dm5KLzRIZFRBMHlrNWppRzE4RDZweUEwbnBLVE1MU1U4ZEE5WXVzUVc5ZWZ6?= =?utf-8?B?TExDUHlUL29VZVRuaHJKSlJRWGVqWElOeFVwbmhHeE9TYUZUbHV1bm9Wak8w?= =?utf-8?B?cnNUUS9ucCsxbThQMk1FdEZOeENBSjMyM250V0dCaFpmeXpZMVQ3cFBsVVJU?= =?utf-8?B?Sk9WNXpoNStwMEpJTUVJOVBKTkRzV0pRU3AveTFxbWloamRFaUt1b2gwVVpi?= =?utf-8?B?THA4MXBwSlRnSm0zQWZvcTA5bWRXMlQrSWJJdEx6aU9CR2VWRTA0M0laL2Ix?= =?utf-8?Q?tLepCc2Z2UfiAUArFhfWkX3Nz4SnMezKA5zMtp5?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7aa9e20d-7c62-4c78-af3a-08d8df350b9b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 17:43:39.4993 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ltHxPcQtlvTTJxR+ZghCAj5R/fJpsy7EhJQpf4kLynFHbNwttgTb6NoiaVopTko/FFcx/7If4v0Rkm71T5pvXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6047 X-OriginatorOrg: citrix.com On Thu, Mar 04, 2021 at 05:13:15PM +0000, Ian Jackson wrote: > Roger Pau Monné writes ("Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior"): > > On Thu, Mar 04, 2021 at 03:20:34PM +0000, Ian Jackson wrote: > > > The guest could be stopped with xl shutdown and then recrated with xl > > > create, from the config file. I don't think we want to break that use > > > case here either. > > > > So my original approach was to actually risk breaking creation from > > config file and require the user to set the rdmsr_relaxed option, and > > report the problem upstream. I think ideally we would like to get to a > > point where we could drop the rdmsr_relaxed option, but maybe that's > > too optimistic. > > Isn't there some way we can move in this direction without the first > thing that users experience being their guests not being able to be > created ? > > Maybe we could print a warning on the console or something ? I (sadly) fear unless you get a guest crash no-one will ever look at the logs and notice those messages. > > We have done quite a lot of testing of this new policy, but obviously > > it's not possible to test all possible guest OSes. Forcing the new > > policy by default might be too risky, so indeed falling back to > > enabling this by default could be the only solution. > > > > The main downside of enabling by default is that then we have to > > resign to always having this kind of quirky behavior for MSR > > accesses as the default. > > What would stop us changing the default later, when we had a better > idea of the set of RDMSRs that need to be special-cased ? We could. From the Citrix side I'm afraid there's not much more testing that we can do however. We tested the new policy against all possible guests known by XenRT, but obviously that's not every possible OS. One option we could go for is making this behavior depend on Kconfig: enable strict MSR policy for debug builds and fallback to the 'relaxed' one for non-debug builds. That might get us some more data, but again I fear most people out there will run non-debug builds anyway. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 04 18:22:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 18:22:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93362.176274 (Exim 4.92) (envelope-from ) id 1lHsbo-0006sp-8o; Thu, 04 Mar 2021 18:22:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93362.176274; Thu, 04 Mar 2021 18:22:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHsbo-0006si-4I; Thu, 04 Mar 2021 18:22:00 +0000 Received: by outflank-mailman (input) for mailman id 93362; Thu, 04 Mar 2021 18:21:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHsbn-0006sd-CC for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 18:21:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHsbn-0000zK-9X for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 18:21:59 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHsbn-0007up-8N for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 18:21:59 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHsbj-000614-OY; Thu, 04 Mar 2021 18:21:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=ND12rZ5Ez5jZl94nI2lObK2kzWuMwdRLYIxcGyq+/lY=; b=MBdUCMIf/Q8uqYUJi7IPvB3YXQ 8yY0lKlePEBPqj0g3DFAgkbny7UHSa1sPwn3NueOSXXsb8LF9VUmd8SBKapGCkZ5NO6nYGz3jhmrh YnVBtY5QRdkrs+oMPDR+B0l5iNzictbD7Od6u8n+10RAAoMXiU83th8zJec0DaJFvPzU=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24641.9539.445996.796776@mariner.uk.xensource.com> Date: Thu, 4 Mar 2021 18:21:55 +0000 To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior In-Reply-To: References: <20210304144755.35891-1-roger.pau@citrix.com> <24640.62938.427877.757656@mariner.uk.xensource.com> <24640.64194.445736.52546@mariner.uk.xensource.com> <24641.5419.379341.215528@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monn writes ("Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior"): > One option we could go for is making this behavior depend on Kconfig: > enable strict MSR policy for debug builds and fallback to the > 'relaxed' one for non-debug builds. That might get us some more data, > but again I fear most people out there will run non-debug builds > anyway. Hmmm. Well, anyway, my R-A for this patch stands. I wanted to explore our options, but I won't try to insist on a change to the default configuration if you experts are against it. Ian. From xen-devel-bounces@lists.xenproject.org Thu Mar 04 18:27:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 18:27:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93365.176285 (Exim 4.92) (envelope-from ) id 1lHshH-00073a-SJ; Thu, 04 Mar 2021 18:27:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93365.176285; Thu, 04 Mar 2021 18:27:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHshH-00073T-PH; Thu, 04 Mar 2021 18:27:39 +0000 Received: by outflank-mailman (input) for mailman id 93365; Thu, 04 Mar 2021 18:27:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHshG-00073L-Uy; Thu, 04 Mar 2021 18:27:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHshG-00015D-OV; Thu, 04 Mar 2021 18:27:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHshG-0000PK-E2; Thu, 04 Mar 2021 18:27:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHshG-0004Hv-DZ; Thu, 04 Mar 2021 18:27:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BkhFIP5BW1M8MByivu8r/tm5nD/tOKeVkknW+OlIrgQ=; b=cbmmXPK2461hMWRVsIA0B8DT6w 0GTUn3PEua7DaauQJ0H+dEsR6/Br3h7bPoVQHCmTm9C7yFA0KRIhcyUUznQAJE926Q9LmY6tZ2/LR x3ma9UPRvUvmKm0vdZvZLxFahu4gnWlBoPfWmuReN0pgb95T/0zMl3KpCxnpRWp+/emo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159829: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f40e1c52e4e0a3e084b025ed6b68f1e6ebaea027 X-Osstest-Versions-That: xen=243036df0d55673de59c214e240b9b914d278b65 From: osstest service owner Date: Thu, 04 Mar 2021 18:27:38 +0000 flight 159829 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159829/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen f40e1c52e4e0a3e084b025ed6b68f1e6ebaea027 baseline version: xen 243036df0d55673de59c214e240b9b914d278b65 Last test of basis 159819 2021-03-03 19:01:33 Z 0 days Testing same since 159829 2021-03-04 16:02:36 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 243036df0d..f40e1c52e4 f40e1c52e4e0a3e084b025ed6b68f1e6ebaea027 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Mar 04 19:31:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 19:31:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93379.176304 (Exim 4.92) (envelope-from ) id 1lHtgS-0005XR-KD; Thu, 04 Mar 2021 19:30:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93379.176304; Thu, 04 Mar 2021 19:30:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHtgS-0005XK-Go; Thu, 04 Mar 2021 19:30:52 +0000 Received: by outflank-mailman (input) for mailman id 93379; Thu, 04 Mar 2021 19:30:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHtgR-0005XE-1H for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 19:30:51 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5129ac1e-7381-47fe-8ead-71ec9e44ea8b; Thu, 04 Mar 2021 19:30:50 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPS id B341064F69; Thu, 4 Mar 2021 19:30:49 +0000 (UTC) Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id AD9B5609E7; Thu, 4 Mar 2021 19:30:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5129ac1e-7381-47fe-8ead-71ec9e44ea8b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614886249; bh=4rtOfSqDL97WN4x/xn30QBXaCjSeLCLfKZRLZt6gHNU=; h=Subject:From:In-Reply-To:References:Date:To:Cc:From; b=ahaqvYvHEFcb9v0j5D0p/JPVEtLvAvbIRMH4nzHQ1G10KSqUZ8d0lHspWyu06AXxV fxFwtruwseYM39eGjnEs7dNItwgP802uwcLJLzN/2eyNM/hGHCHcmgjpmHEj5PFSLo bBsZhQc280fSTfXE8+H904Rf3NV2bNJtdzSaMxAczgIjdUIxEOB1Oy3gLmW3+hpj47 19oeE9FkhJDqEqblgqrdIPdc5AYvV3ElMAcklsizfkJvcWY888qqvGeyE7uA2CEc6I GhwMU21qIoNrGg5LNu0nUlFaWpHMmEp1Dr34iNnNWEEhCvRDc+ImycdLykGrLL4tfR sGc2rSoM+FhOw== Subject: Re: [GIT PULL] xen: branch for v5.12-rc2 From: pr-tracker-bot@kernel.org In-Reply-To: <20210304110053.8787-1-jgross@suse.com> References: <20210304110053.8787-1-jgross@suse.com> X-PR-Tracked-List-Id: X-PR-Tracked-Message-Id: <20210304110053.8787-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.12b-rc2-tag X-PR-Tracked-Commit-Id: 882213990d32fd224340a4533f6318dd152be4b2 X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: c5a58f877ca645a3303f7a57476f2de837fdb97a Message-Id: <161488624970.28500.3525125112340925480.pr-tracker-bot@kernel.org> Date: Thu, 04 Mar 2021 19:30:49 +0000 To: Juergen Gross Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com The pull request you sent on Thu, 4 Mar 2021 12:00:53 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.12b-rc2-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c5a58f877ca645a3303f7a57476f2de837fdb97a Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Thu Mar 04 20:21:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 20:21:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93382.176316 (Exim 4.92) (envelope-from ) id 1lHuTW-00025q-B5; Thu, 04 Mar 2021 20:21:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93382.176316; Thu, 04 Mar 2021 20:21:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHuTW-00025j-7g; Thu, 04 Mar 2021 20:21:34 +0000 Received: by outflank-mailman (input) for mailman id 93382; Thu, 04 Mar 2021 20:21:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHuTV-00025b-77; Thu, 04 Mar 2021 20:21:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHuTU-0002zw-Sf; Thu, 04 Mar 2021 20:21:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHuTU-00062T-KY; Thu, 04 Mar 2021 20:21:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHuTU-0001BW-HW; Thu, 04 Mar 2021 20:21:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4J415/gCgOLcOBFn96LK69ZyTTp1mAZfTRPGYOZzV5U=; b=oYSQGxm4A/NC9CCqtZw3o8j9HE lhn016/gYlqnanfjdjcJtNB7/Cc9Zcbslr/GHrJL9VNsap0WkKbkg3NphNGUSGMDWlh3jDpAdwcYR kYy6Z8xcWPXDl3aL7Af25+3Nfvxes6+xPKR0nLT5vFZa+/uSEqSbDG+Zcd54JxjlsVrA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159825: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=243036df0d55673de59c214e240b9b914d278b65 X-Osstest-Versions-That: xen=243036df0d55673de59c214e240b9b914d278b65 From: osstest service owner Date: Thu, 04 Mar 2021 20:21:32 +0000 flight 159825 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/159825/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 159820 pass in 159825 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 159820 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159820 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159820 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159820 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159820 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159820 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159820 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159820 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159820 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159820 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159820 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159820 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 243036df0d55673de59c214e240b9b914d278b65 baseline version: xen 243036df0d55673de59c214e240b9b914d278b65 Last test of basis 159825 2021-03-04 08:50:06 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Mar 04 22:25:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 22:25:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93394.176331 (Exim 4.92) (envelope-from ) id 1lHwOc-0005HT-MZ; Thu, 04 Mar 2021 22:24:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93394.176331; Thu, 04 Mar 2021 22:24:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHwOc-0005HM-Ii; Thu, 04 Mar 2021 22:24:38 +0000 Received: by outflank-mailman (input) for mailman id 93394; Thu, 04 Mar 2021 22:24:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHwOb-0005HG-4p for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 22:24:37 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 89fc3cdf-72cb-4eb5-a325-8ac7476718f1; Thu, 04 Mar 2021 22:24:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89fc3cdf-72cb-4eb5-a325-8ac7476718f1 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614896675; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=87eFYA642zQgH8yPsb4Mo6TuButVlMk/Pk8ZFdS3QJM=; b=fw2T0Ocjp4+PbiU2MvlWG6Kqn0Dd9qWnSzf8tFma+lH8tu0H7L1EnIdk +ib5SkCh6Jzm7ziDYilL8uEo9Hn6M0z2lh+TeisSwAPMLbKk9LowNYV/N 6Hgt79IGDOInPl/fy+tY5Zf0cAe1wYQzRPToJf7CkeEDueGtQy0wmmmt4 c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: DUuVPUC2wmOQBNbzrDpUn/DeAWuw8hajHjLfbEl3FRgLWtP1HBmN3RwgvfbbuC4Cv7HO+599aR S/SaxPmZ1xBALdySA68Bzxilq4n+29kR5aO10446fy/QjISAlZE/e1goiU1ETmBMp1CKIAGLMc 0KXBz3nsnD3BfSTqKXOKXI96Ih/YPZjR4GG+eX/cQxwIIEBO48tGLkDEN1e3yfyV+CQ1GI9Pjn Cp1Tfs4Z03Ie/4Zga7qd7XKvZKvWa6aQr83WkFOPJYCpQsAagHevnfPOUlgFeKpsfaCBYrINfR 3No= X-SBRS: 5.2 X-MesageID: 38582394 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,223,1610427600"; d="scan'208";a="38582394" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W6CsKd/pMptu2NE/BjHX6rZKrFhAdE10wzjDxukIUziFNR1DepdOmYNyo8jvERN6gS0UeW4/TAa+nuNs1l/DJ72fG/7TSVxKYiZ0d4YczQUTEp4C7h0eV9yw0Xuw+TsawLSkq7cMwsOKMNeWs6CH74kZHYb8u10ayla62Kcw2phhThNLZHKrZKlZG767o6Uhf2JM/DWVHRYzQDHk56ftJfIrvaOF2FddUEuzM25PiaJTnod3ehWZrM+nIqbcFz+ihDs0VzKq3GFPt1DsDN9J0mmO7/25zA6w0qAYYCKBR8sccsJsklLO6ygYK5iB5R3ZwbNtEGp9Sp71TH3cszxm5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HHGO3gHLGY48Ws0T1aa+wPfhzSC7Xj3ox0pREaBXfuU=; b=aQ5fG7r3Zu+2nOTlxlGlukPCrDuTvn5Xp262FWNsvYhb5ZIka29kTjvYtYiHs4c62sKDir66l27us7d4VDhXgV0Phyi+HyR51kCyHUK4udBQqb6qj2Dq81eKk888g/v5GMKoznHnydlmMfiax0dJWdFRTLx8SEP9wLZ42dO+LD7npHRYymP1noXMmSpI04Ih97RqhKWt9ZMKY4feyz9APWmRMKKpzxIbzRUONwtguB6lGpx9qhahpSyZX88uY8V4C9tbZWbAj9z1weT4AicG+pvA4CA+qJq2QMkSRDxhX1VmcjPpgqhso0UGBMUGB3+4Pex5jOIY6JTgnnMFHZqXyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HHGO3gHLGY48Ws0T1aa+wPfhzSC7Xj3ox0pREaBXfuU=; b=IMpkyBqBIcdJQk2QvDEyhwkm5geNSiON6b9Nd6TryJaZ7b9DRVfH5R1wUrmEyK+weJJZQi4rfLPhLhvCQtdjy49fthZ7ghbc8JYuTaPrKDrUSSKiGyJQC7qT1hWKpPZJxxGUnI+4nSK74MM6SaY9+7Z1f5g/oicEnlcxmbNYvYo= To: Xen-devel CC: Ian Jackson , Wei Liu References: <20210304130319.10719-1-andrew.cooper3@citrix.com> From: Andrew Cooper Subject: Re: [PATCH for-4.15] tools/libxendevicemodel: Strip __XEN_TOOLS__ header guard Message-ID: <5fe61a81-942f-f527-43a3-2496ca168186@citrix.com> Date: Thu, 4 Mar 2021 22:24:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210304130319.10719-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO3P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 43368fac-6b44-4c70-44d0-08d8df5c445c X-MS-TrafficTypeDiagnostic: BYAPR03MB3943: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uSmPBtmJChDQ2aeNRjcb8At3U3Ag8J2QbEsFG++1SLd+ZEyU+MAi75rKDhjFGsO32jdHrzO9O+lZldvivznaxAypnlwizOgO2E+W+Y1kp/UEZnUFSOuRX1+yFgi2Lx0JudVfCuz6uHOFaE9TjyqpKfz1Mr6EeVB+cT0MkPjQc2HNvaKWO4rWIlEjdhije50K00dN9saU5qhAEckXO6x5WWAB6TYD/X/E9+Vh66DeDI41HTDT9Cv5v+F7MPb7XgXk4NEbnUHfUKe/roLWJUZZmQqR6quL+AYIxHMh0r3iVJeTabyn705n5V3dl+hZbWO9phQ8l/QlYojJ2Ij1xoyGDNRHeEbhKou+faX76F9qpGWS8Gk2yvkHFaPYQE1CT993vHYnZFk6f5gnXGA4UwcCsQU1xsBEYybd3HDq0JxMu4nUxgb8Hjcmtyv5Ixaq2w72JGFBoLVXmCfu1eTvnnAAy3fhulQENUHwYkj6PNA54qspVIGL54CuhNe7VNoactF4xeU7jXazCiWUIDDHVFGcyqD35QQrfF/M1jKmvcyoaGg9v0OlmBErBUobtbhDNApy7LKn/T0jm1R2SnGqBYT4hmdT8XVoiuKHzOFBaN/GeOc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(396003)(346002)(136003)(366004)(6916009)(8936002)(54906003)(2906002)(31696002)(4326008)(31686004)(6486002)(16526019)(186003)(6666004)(26005)(478600001)(8676002)(16576012)(2616005)(86362001)(956004)(36756003)(66946007)(66556008)(316002)(5660300002)(53546011)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dTJVQk1RZXpuZitOem1id1dsdElYMkFrMjNtZnhjQUMrNUtuamd2dDU3NW5u?= =?utf-8?B?Q3k0WENTZit5N0V4cjZjT3F5cXByQWp3bEtxY2tkKzJLMFdQK0JnRjhUd3Fz?= =?utf-8?B?Q2ZrM013M0prakdLeDdEakU0YjkycUhGdTNvSTNhZi9nZitjb2xnUzdVNDB1?= =?utf-8?B?eFhGcUhXTlFaUWYzb3NEZWFJQmJ0eVVGVm1OU1BzaW04dldlVitYUVZTbTdj?= =?utf-8?B?ZU0xdzQ3TmxnZjBMTjhTRlBRUHM5aTdEQlB6QlJPRHI5M2ZLeFhkSEtnVUFW?= =?utf-8?B?Y1d4b3JCVXAvSjR5ZHRqSFRPN0w0ZE9CRjRLOGhKbXlzNUVWcC9qVFJSYWhX?= =?utf-8?B?QjA0dXUzelJDK21mNzVkbHZ3ZWFQM1NhMlVLTDZDQ1NtcThLaVZHRnk2YThV?= =?utf-8?B?QTJXM1JpQkt0VUlvYWFrMVU0NElOMHVxcmV4Q2picklKRWcxRWZralp6eTZo?= =?utf-8?B?ekxLbmZVOUQvZG9ZbEVKZFQxU2daN2R1RFBrazU1eEk4NVBuQ1psdHc4RzZF?= =?utf-8?B?a3lHbkZDSnhxenlmOXIyQ3YvZmErd1FYNFZNZlBsUHVlaFYzOTRlSFdDcEU0?= =?utf-8?B?VkVQeWtQQTY2enZiZXduMVlBV2ZuaDQ1b0JWSFE1dEw3YVhNemlmbGFqaVBR?= =?utf-8?B?M05GRHVyeWFuU3p4SnZYZXdic3ZEaGFGL0N6YXo1aE9jZ3hZWk9FcXppUGRr?= =?utf-8?B?NFB5aU1hV0tuV3hXNlkrdldWeGN3L2h3Z2pQcmNnK0R3TjNueHhiaXpuMWxL?= =?utf-8?B?aUVZVFcwK00zTzVmaHRqS2tSVVNXL0RwUE5HcGJZdmhrZnZuaXIrTDZTQkp6?= =?utf-8?B?TEdPOG9vNHNZTEtTV0hxS3VxSGdqbWVkaERybUtWSkp6Smxqb2sreDd1cC9q?= =?utf-8?B?YXlzcTJqaHVQSldwMWI3dGY0czVoZ0FBQVVRN1JpOURGbUhVK2hCSm5DUDVa?= =?utf-8?B?YWpvZ0U4WFRKVEIvL2RDVnE0dTVtdzFLVkZMZlRpU1hpejZYT2JFVEx4eW1V?= =?utf-8?B?dzVVanRjUnpBM1lFSllKMHZjR2ZITTVtb3NIV3RGZnBrdjAvSE9zcGxGbXdh?= =?utf-8?B?bzl2SWlZK2dJTldYMVQzSUFpVEFmVGh2dENxUTkzTURucEJsbU5HOG8yenBr?= =?utf-8?B?SnZSekF1RWgyOC9EWEVJc25wVVR0dFZyTlNRYTNydUVMdEtTTDF6T0RwSU44?= =?utf-8?B?NXFhb1R2V2M4Y3Zvak1QVUFjSFBEYTA0ZDZzT0VJL1g0Tit5NWlORFZQMVhE?= =?utf-8?B?aUthQ2Z1UjRhUmxrd1h6bUZJdFVTRzdKTC91TkJjYTU5MmtFYVQ0REFPWGFK?= =?utf-8?B?akVDdEg4WkY2bVlZc09JYTJuYXhLbVE3cmFSeFcrbGNmS0U0RnFzYmxuaWlv?= =?utf-8?B?c1h4cFNjNXk0a2dnQ2swYk4vVkhSdmZaMEhmTWFUMzd4c2lZSytlVTJzZjZh?= =?utf-8?B?UlFDQkpmd1RLN0hDakdmK0pmWjZWa2NZemR4OHFFbXRyUEVaOXNLMXBadVk4?= =?utf-8?B?L1ZDNFhTQTV0SU9HTy9TYTRaUmVSWXhsS1pRWDgxMk42VVlvWGpBaTF1eGdt?= =?utf-8?B?UGpsQ012b1ZIcDVTSC85UXk4SGZyMWx6alRjVk1QMTh3VWtqOUtKMHl6ekxL?= =?utf-8?B?WEJSTm1VUUNTMVVGVE5ZdVJZVisrMENvWWw3VjV6eDhpb3ZrWHhucUV5Wkdx?= =?utf-8?B?NDJ6a2R2NEpxbHRYSEV4OS9IdVV3RE9URVJCUXpLTGtqWVFXN0daSnhadklu?= =?utf-8?Q?d7jSgmwXn4JbI2hwrNSbxb0X+vemHIeAyLmjvTj?= X-MS-Exchange-CrossTenant-Network-Message-Id: 43368fac-6b44-4c70-44d0-08d8df5c445c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 22:24:25.2106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uGpX+uIKBOmDuGGM6avRCSR4NTpn3fnbCxAExZJHoEDYOt4Hx49RsZO1IENPL9N+aDlJvO4OunCCb9IuERyHeTBApWA6mNNVr43PIFklErk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3943 X-OriginatorOrg: citrix.com On 04/03/2021 13:03, Andrew Cooper wrote: > This is inappropriate for the header file of a standalone library with st= able > API and ABI. > > Signed-off-by: Andrew Cooper > --- > CC: Ian Jackson > CC: Wei Liu > > Discovered when trying to actually remove the use of unstable libraries f= rom a > trivial userspace emulator. Current users of xendevicemodel.h inherit > __XEN_TOOLS__ from libxenctrl.h (or equiv). > --- ... and this patch is broken. But CI doesn't pick it up because we've also broken the header check scripts as part of library refactoring. The 4.13 header checks do work, and point out that there is yet another set of bogus __XEN_TOOLS__ ifdef in the Xen public ABI, which hides the ioserverid_t type and (rightly) breaks the build. Which in turn proves that the header checks (for xendevicemodel.h at least) never ever checked anything originally, because they didn't pass __XEN_TOOLS__ in at the top and just saw an empty file. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Mar 04 22:35:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 22:35:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93400.176343 (Exim 4.92) (envelope-from ) id 1lHwZO-0006Le-Kw; Thu, 04 Mar 2021 22:35:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93400.176343; Thu, 04 Mar 2021 22:35:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHwZO-0006LX-Hp; Thu, 04 Mar 2021 22:35:46 +0000 Received: by outflank-mailman (input) for mailman id 93400; Thu, 04 Mar 2021 22:35:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHwZN-0006LS-Kl for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 22:35:45 +0000 Received: from mail-il1-x129.google.com (unknown [2607:f8b0:4864:20::129]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 03d28438-6e53-4cea-8d90-3c2b9e3a1546; Thu, 04 Mar 2021 22:35:44 +0000 (UTC) Received: by mail-il1-x129.google.com with SMTP id g9so202426ilc.3 for ; Thu, 04 Mar 2021 14:35:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03d28438-6e53-4cea-8d90-3c2b9e3a1546 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xZijENr2+zGNDTMY91mNb3XjWFQB+d3gIehbEGKDitY=; b=ZYn50Fmmt3BS8UaIsrDlnk8aeyb/CyGHELv6HVIiFc1SVVkUmrOlVgP/E+f/8bJnL4 ArnLNa/61x0hDaMp9VTFwZvKzzu53JrGbyHMJpd5yehD11RY4EV0mEP0mZHkS7htiwIL JnSP8qfMShd6NYUv/9VRmifwXglpxH2T+otFPg7J6OlulXBZbJbiNcX+byNs1/X22OQo 7wkOsHR5JoCMN876MzLmaFqhZnR+BxwJRTHHal0x9PYKiXIYqc6OSAtT+BPp5qsg8QXX LtJcFcCUafD8buEW1Ob7pHF+dB4Q2wry7r+yelUZRWaMoLZZJ4ZqpinMMojfM8oqoA2K /ysQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xZijENr2+zGNDTMY91mNb3XjWFQB+d3gIehbEGKDitY=; b=JrRm3Uyiqx/HMYv0U0QCkd9TH65E0zcIV413ajunkPsQDOhYgm4Gtt6lhvp/WXZ/4R 0sIX3ApJQu7s5636sT2ofvqDVdHMANfmEnIpdY9u5rSaRnpc7Cz+uJIc2qWAv+4Lr9rx 6gtg3xE25drtHQhp98zxxUgkcJR2BmTeG67sRJk6SbEVv3T+mycXbJM7Kb8m52ofFbND evlJjwMrE6C1ggtNLHeDwjmvgkILKOwIREuTa46Nzv9z9hv05goPim932ighz9rLDsS6 mL8/RYhPS8chPDbcsnXYVeLklqm3ERIna+Y62bs1jRq6rtVHyfe1/OXxiedD0buZ0lnt ayPw== X-Gm-Message-State: AOAM530w1TCty5bvtwsMp6Sqbp/h/qplcInpGQRh2rqRvnNkibn4GyfZ HrMeLLxHJMUPFPG7KfrA0ECZpKULjkTblw0bvAgEadDVkmI= X-Google-Smtp-Source: ABdhPJwp5uTMylSaYOtyIhPpVV741/4v9ltLoWOMIgkqDDk6EcErYwmAVCpr/6XqqwrYeRnyEdEdc2JYtsk3KI2+lHE= X-Received: by 2002:a92:cda1:: with SMTP id g1mr5816293ild.267.1614897343689; Thu, 04 Mar 2021 14:35:43 -0800 (PST) MIME-Version: 1.0 References: <20210303173642.3805-1-alex.bennee@linaro.org> <20210303173642.3805-5-alex.bennee@linaro.org> In-Reply-To: <20210303173642.3805-5-alex.bennee@linaro.org> From: Alistair Francis Date: Thu, 4 Mar 2021 17:34:27 -0500 Message-ID: Subject: Re: [PATCH v3 4/7] hw/core: implement a guest-loader to support static hypervisor guests To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Cc: "qemu-devel@nongnu.org Developers" , julien@xen.org, stefano.stabellini@linaro.org, stefano.stabellini@xilinx.com, andre.przywara@arm.com, stratos-dev@op-lists.linaro.org, "open list:X86" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 3, 2021 at 12:37 PM Alex Benn=C3=A9e w= rote: > > Hypervisors, especially type-1 ones, need the firmware/bootcode to put > their initial guest somewhere in memory and pass the information to it > via platform data. The guest-loader is modelled after the generic > loader for exactly this sort of purpose: > > $QEMU $ARGS -kernel ~/xen.git/xen/xen \ > -append "dom0_mem=3D1G,max:1G loglvl=3Dall guest_loglvl=3Dall" \ > -device guest-loader,addr=3D0x42000000,kernel=3DImage,bootargs=3D"roo= t=3D/dev/sda2 ro console=3Dhvc0 earlyprintk=3Dxen" \ > -device guest-loader,addr=3D0x47000000,initrd=3Drootfs.cpio > > Signed-off-by: Alex Benn=C3=A9e > Message-Id: <20201105175153.30489-5-alex.bennee@linaro.org> > Message-Id: <20210211171945.18313-5-alex.bennee@linaro.org> Reviewed-by: Alistair Francis Alistair > --- > hw/core/guest-loader.h | 34 ++++++++++ > hw/core/guest-loader.c | 145 +++++++++++++++++++++++++++++++++++++++++ > MAINTAINERS | 5 ++ > hw/core/meson.build | 2 + > 4 files changed, 186 insertions(+) > create mode 100644 hw/core/guest-loader.h > create mode 100644 hw/core/guest-loader.c > > diff --git a/hw/core/guest-loader.h b/hw/core/guest-loader.h > new file mode 100644 > index 0000000000..07f4b4884b > --- /dev/null > +++ b/hw/core/guest-loader.h > @@ -0,0 +1,34 @@ > +/* > + * Guest Loader > + * > + * Copyright (C) 2020 Linaro > + * Written by Alex Benn=C3=A9e > + * (based on the generic-loader by Li Guang ) > + * > + * SPDX-License-Identifier: GPL-2.0-or-later > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or la= ter. > + * See the COPYING file in the top-level directory. > + */ > + > +#ifndef GUEST_LOADER_H > +#define GUEST_LOADER_H > + > +#include "hw/qdev-core.h" > +#include "qom/object.h" > + > +struct GuestLoaderState { > + /* */ > + DeviceState parent_obj; > + > + /* */ > + uint64_t addr; > + char *kernel; > + char *args; > + char *initrd; > +}; > + > +#define TYPE_GUEST_LOADER "guest-loader" > +OBJECT_DECLARE_SIMPLE_TYPE(GuestLoaderState, GUEST_LOADER) > + > +#endif > diff --git a/hw/core/guest-loader.c b/hw/core/guest-loader.c > new file mode 100644 > index 0000000000..bde44e27b4 > --- /dev/null > +++ b/hw/core/guest-loader.c > @@ -0,0 +1,145 @@ > +/* > + * Guest Loader > + * > + * Copyright (C) 2020 Linaro > + * Written by Alex Benn=C3=A9e > + * (based on the generic-loader by Li Guang ) > + * > + * SPDX-License-Identifier: GPL-2.0-or-later > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or la= ter. > + * See the COPYING file in the top-level directory. > + */ > + > +/* > + * Much like the generic-loader this is treated as a special device > + * inside QEMU. However unlike the generic-loader this device is used > + * to load guest images for hypervisors. As part of that process the > + * hypervisor needs to have platform information passed to it by the > + * lower levels of the stack (e.g. firmware/bootloader). If you boot > + * the hypervisor directly you use the guest-loader to load the Dom0 > + * or equivalent guest images in the right place in the same way a > + * boot loader would. > + * > + * This is only relevant for full system emulation. > + */ > + > +#include "qemu/osdep.h" > +#include "hw/core/cpu.h" > +#include "hw/sysbus.h" > +#include "sysemu/dma.h" > +#include "hw/loader.h" > +#include "hw/qdev-properties.h" > +#include "qapi/error.h" > +#include "qemu/module.h" > +#include "guest-loader.h" > +#include "sysemu/device_tree.h" > +#include "hw/boards.h" > + > +/* > + * Insert some FDT nodes for the loaded blob. > + */ > +static void loader_insert_platform_data(GuestLoaderState *s, int size, > + Error **errp) > +{ > + MachineState *machine =3D MACHINE(qdev_get_machine()); > + void *fdt =3D machine->fdt; > + g_autofree char *node =3D g_strdup_printf("/chosen/module@0x%08" PRI= x64, > + s->addr); > + uint64_t reg_attr[2] =3D {cpu_to_be64(s->addr), cpu_to_be64(size)}; > + > + if (!fdt) { > + error_setg(errp, "Cannot modify FDT fields if the machine has no= ne"); > + return; > + } > + > + qemu_fdt_add_subnode(fdt, node); > + qemu_fdt_setprop(fdt, node, "reg", ®_attr, sizeof(reg_attr)); > + > + if (s->kernel) { > + const char *compat[2] =3D { "multiboot,module", "multiboot,kerne= l" }; > + if (qemu_fdt_setprop_string_array(fdt, node, "compatible", > + (char **) &compat, > + ARRAY_SIZE(compat)) < 0) { > + error_setg(errp, "couldn't set %s/compatible", node); > + return; > + } > + if (s->args) { > + if (qemu_fdt_setprop_string(fdt, node, "bootargs", s->args) = < 0) { > + error_setg(errp, "couldn't set %s/bootargs", node); > + } > + } > + } else if (s->initrd) { > + const char *compat[2] =3D { "multiboot,module", "multiboot,ramdi= sk" }; > + if (qemu_fdt_setprop_string_array(fdt, node, "compatible", > + (char **) &compat, > + ARRAY_SIZE(compat)) < 0) { > + error_setg(errp, "couldn't set %s/compatible", node); > + return; > + } > + } > +} > + > +static void guest_loader_realize(DeviceState *dev, Error **errp) > +{ > + GuestLoaderState *s =3D GUEST_LOADER(dev); > + char *file =3D s->kernel ? s->kernel : s->initrd; > + int size =3D 0; > + > + /* Perform some error checking on the user's options */ > + if (s->kernel && s->initrd) { > + error_setg(errp, "Cannot specify a kernel and initrd in same sta= nza"); > + return; > + } else if (!s->kernel && !s->initrd) { > + error_setg(errp, "Need to specify a kernel or initrd image"); > + return; > + } else if (!s->addr) { > + error_setg(errp, "Need to specify the address of guest blob"); > + return; > + } else if (s->args && !s->kernel) { > + error_setg(errp, "Boot args only relevant to kernel blobs"); > + } > + > + /* Default to the maximum size being the machine's ram size */ > + size =3D load_image_targphys_as(file, s->addr, current_machine->ram_= size, > + NULL); > + if (size < 0) { > + error_setg(errp, "Cannot load specified image %s", file); > + return; > + } > + > + /* Now the image is loaded we need to update the platform data */ > + loader_insert_platform_data(s, size, errp); > +} > + > +static Property guest_loader_props[] =3D { > + DEFINE_PROP_UINT64("addr", GuestLoaderState, addr, 0), > + DEFINE_PROP_STRING("kernel", GuestLoaderState, kernel), > + DEFINE_PROP_STRING("bootargs", GuestLoaderState, args), > + DEFINE_PROP_STRING("initrd", GuestLoaderState, initrd), > + DEFINE_PROP_END_OF_LIST(), > +}; > + > +static void guest_loader_class_init(ObjectClass *klass, void *data) > +{ > + DeviceClass *dc =3D DEVICE_CLASS(klass); > + > + dc->realize =3D guest_loader_realize; > + device_class_set_props(dc, guest_loader_props); > + dc->desc =3D "Guest Loader"; > + set_bit(DEVICE_CATEGORY_MISC, dc->categories); > +} > + > +static TypeInfo guest_loader_info =3D { > + .name =3D TYPE_GUEST_LOADER, > + .parent =3D TYPE_DEVICE, > + .instance_size =3D sizeof(GuestLoaderState), > + .class_init =3D guest_loader_class_init, > +}; > + > +static void guest_loader_register_type(void) > +{ > + type_register_static(&guest_loader_info); > +} > + > +type_init(guest_loader_register_type) > diff --git a/MAINTAINERS b/MAINTAINERS > index 9b2aa18e1f..a5b87d5e30 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2007,6 +2007,11 @@ F: hw/core/generic-loader.c > F: include/hw/core/generic-loader.h > F: docs/generic-loader.txt > > +Guest Loader > +M: Alex Benn=C3=A9e > +S: Maintained > +F: hw/core/guest-loader.c > + > Intel Hexadecimal Object File Loader > M: Su Hang > S: Maintained > diff --git a/hw/core/meson.build b/hw/core/meson.build > index 032576f571..9cd72edf51 100644 > --- a/hw/core/meson.build > +++ b/hw/core/meson.build > @@ -37,6 +37,8 @@ softmmu_ss.add(files( > 'clock-vmstate.c', > )) > > +softmmu_ss.add(when: 'CONFIG_TCG', if_true: files('guest-loader.c')) > + > specific_ss.add(when: 'CONFIG_SOFTMMU', if_true: files( > 'machine-qmp-cmds.c', > 'numa.c', > -- > 2.20.1 > > From xen-devel-bounces@lists.xenproject.org Thu Mar 04 22:50:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 22:50:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93404.176354 (Exim 4.92) (envelope-from ) id 1lHwnR-0008JH-PD; Thu, 04 Mar 2021 22:50:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93404.176354; Thu, 04 Mar 2021 22:50:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHwnR-0008JA-MI; Thu, 04 Mar 2021 22:50:17 +0000 Received: by outflank-mailman (input) for mailman id 93404; Thu, 04 Mar 2021 22:50:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHwnQ-0008J1-Gf; Thu, 04 Mar 2021 22:50:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHwnQ-0005NY-6o; Thu, 04 Mar 2021 22:50:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHwnP-00061I-VE; Thu, 04 Mar 2021 22:50:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lHwnP-00014Q-Uk; Thu, 04 Mar 2021 22:50:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CXsGL7uNjA7wIDrjNPJeYUs6fatXM+U9LYnRFuphwfg=; b=UEsWK4d1ECsp0lFt3+iRy8Avhx 47hqOeB02wcbUJyu89xvMZrh3oWBVdsRAai999m/s31dqTwGTvflNZIj7V8CYAb0594SJ6d8jNMA+ e+vEqIVnms/euIOACSxxIQdEsrIH01Ya3SojqjsAhDVMVW4DkdbUvCxm0ePwxCmrrTAU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 159826: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7f324ea75baa059ea126cddd4141198895880a69 X-Osstest-Versions-That: linux=ef1fcccf6e5fe3aabe7c3590964efac6d5220c43 From: osstest service owner Date: Thu, 04 Mar 2021 22:50:15 +0000 flight 159826 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/159826/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159702 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159702 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159702 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159702 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159702 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159702 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159702 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159702 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159702 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159702 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159702 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass version targeted for testing: linux 7f324ea75baa059ea126cddd4141198895880a69 baseline version: linux ef1fcccf6e5fe3aabe7c3590964efac6d5220c43 Last test of basis 159702 2021-02-26 09:41:36 Z 6 days Testing same since 159826 2021-03-04 09:40:07 Z 0 days 1 attempts ------------------------------------------------------------ 336 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git ef1fcccf6e5f..7f324ea75baa 7f324ea75baa059ea126cddd4141198895880a69 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Thu Mar 04 23:10:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 23:10:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93412.176370 (Exim 4.92) (envelope-from ) id 1lHx6k-0001wa-OY; Thu, 04 Mar 2021 23:10:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93412.176370; Thu, 04 Mar 2021 23:10:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHx6k-0001wT-L8; Thu, 04 Mar 2021 23:10:14 +0000 Received: by outflank-mailman (input) for mailman id 93412; Thu, 04 Mar 2021 23:10:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHx6j-0001wO-Ex for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 23:10:13 +0000 Received: from aserp2130.oracle.com (unknown [141.146.126.79]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bf5bb71f-6dcb-41cf-80b6-ea5da4d1f702; Thu, 04 Mar 2021 23:10:12 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 124N9PvK015877; Thu, 4 Mar 2021 23:10:09 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 36ybkbgvh1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 04 Mar 2021 23:10:09 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 124MpATc108501; Thu, 4 Mar 2021 23:10:08 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2175.outbound.protection.outlook.com [104.47.59.175]) by aserp3020.oracle.com with ESMTP id 3700038s3v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 04 Mar 2021 23:10:08 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BYAPR10MB3528.namprd10.prod.outlook.com (2603:10b6:a03:124::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.39; Thu, 4 Mar 2021 23:10:06 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3912.022; Thu, 4 Mar 2021 23:10:06 +0000 Received: from [10.74.111.75] (138.3.200.11) by SN4PR0501CA0073.namprd05.prod.outlook.com (2603:10b6:803:22::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.13 via Frontend Transport; Thu, 4 Mar 2021 23:10:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf5bb71f-6dcb-41cf-80b6-ea5da4d1f702 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=QaOVRjFYaGpbRWFnsRMzYv4gz95CwMM4bXbjeMzAa+I=; b=tp/X5mQPx0mStgkhZn+zf7Nox3tfTnew8CYFIjuBusMHlPQPPMntCGAXY8tWC0ad+k92 Z+IgAsvgIM0qTZbW8MZpTNrTfQl0c/6kIomwk5E8v6cGzHdHwDEt3UmRolAU7AokKYNB 7Ce0nQpYR1eGdpZC4jXptT2Il57191eNa4jBQr6Nrm4Ved7jbrj2+wmGVyrgLalW2ubm gKV8kpYlDiDCIuFzDHN0gSbk4sartKCC1Shu1F+7wDTexPxNctmsyl+rIuihNdfTnQci PO9ORu8yN5+HwJo2YJ3XDXb4ZpjLt8ANwTxT7rTrWzFZf3ViBC0rkz4ZtVZB9XC2CvZs ng== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CZYjvyjhOPiNgZuN5ZXn4WX6tqBkyZJ9OFhCL+TNDvXVMyk4UUV2NxlpWNYJ0szQgfkLtxTulTfl4JOK6g8L8iE/020+7GZEWtXR5A5tBlpHUP9kDocAq2IGs2yQHMRHcx69CeqwBNeRONtk+GuZ6W57em7H/jbJUVVEew/31BQYmWyV7ESwzsrv0exVbwQ5Q64v65SWh4jIzr9n0iIBWa2PO5Bgrcd/hQlXf4T7YAwDlogdIEzutZsGa12YWcfjo2bCf3NuMzuv3rhFVTw3Qtc5Zw4eqtMT/xcU1Ly2Q5y2T66FU0vLcQ9MMF6CUTlapb5T1ulaqCYae0BK4o7EBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QaOVRjFYaGpbRWFnsRMzYv4gz95CwMM4bXbjeMzAa+I=; b=eOgK2l/tL2no2FnGYEsB9GAfk/sB755urORafWpgh3Hc7IucEyF2OxLGKM+jtSReTKBrr7hWVJr27oFo5iYyMZQJMPwFhCU7mgW2fQi86m0QFsTlpPsBOGOWZXkqNj2OBAVH4Vq5h+cj5dCo9DExMmcSFVP+ae7Xr8G8NiikZiNAeSI10GOAgkqxGMiYgt/l+iiFNjYo+12c/S5n8nIPtFvINeRNOhNiL4c+GILVy54DmfJJtWgT74dMJh7RMy/o1OYK5uWRg8J1xmSdNcxC2Vf/eqRF7Lo/9Y9xTt6mdzkZUBBJ2W9OVM1sVZCJa5qG4twTP8vv91r5RJ83oyUMMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QaOVRjFYaGpbRWFnsRMzYv4gz95CwMM4bXbjeMzAa+I=; b=KHHYDE8kAT4sgeIkvNo1BTqDGibmxiSPBPwV6No0sH+mNWc0d8Yw6U8G8a821A7ZnI5Ck17kK6cbdjWXkHV6PrNkJNqgAigaJKddZr7z/t7yav3ksLFebI98AiU0vh7siZryxOeWdOiDMm1BxRvLM2uGRCIhVbm3kdNWuxfFqbk= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian References: <20210304144755.35891-1-roger.pau@citrix.com> From: Boris Ostrovsky Message-ID: <9fa2be52-9d1a-e841-5bb4-3180b4b5b033@oracle.com> Date: Thu, 4 Mar 2021 18:09:58 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <20210304144755.35891-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [138.3.200.11] X-ClientProxiedBy: SN4PR0501CA0073.namprd05.prod.outlook.com (2603:10b6:803:22::11) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ddc55f97-2baf-4867-bfce-08d8df62a687 X-MS-TrafficTypeDiagnostic: BYAPR10MB3528: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GIqT9Q7VDnjp0yti9w49Um1nDTOuA+Jm5ClyVInoNZq5GhYZA3f/4ql/6yqzWZy6jXnQ3e2Jebiz+E4cKVs9v0OgRahgtwT2/CBSlrWvkfDbVtR3XoA0nRKiuPesoLMqkX8sP254ygX1eHm0C6Gq4xd36Tjoo2LvpZnBHvOBV40d7lOV2MSKrsiOfxGNTvVaz1W4BD6ARHe0oOr4ztTeGFXFVkpm3Ns8hv6u8itJDCKdO1/PHGFUbPAu3AaNetCTZc6UQ1pSf1H+TMGN9x3iu2eG94MiosUww0mjF3vGGmrLQmg+/XxjL4kscBYsF93toE6EJQINf3tN5AhbdfKEmmi1cloemNUy96LP3vMgiW8GcNeGxBjP+DpM1d/5yb9Vz14BPskI85nUdC5rUgzwKSEP+nrwyd7VD3VYRyuRsstHEcWvxnF0ESezvItD3EO7jT96uj9PghD2wgMc9S8sTbkXOYXem/5bHqOgA/33W/BR0kJ/1B+b2ZquFagVDb6WgMnXnK+HfwHAO5G3FYlLIy+Iur7a1ABZELriDl2F9q18LkpUmTn+r+s9FtRCX1Qy2G2RSywKDjrY8UnDXJ6DeV5EAoyqHw9m5Qj2VX8D168= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(366004)(136003)(346002)(39860400002)(376002)(53546011)(26005)(66946007)(86362001)(54906003)(44832011)(478600001)(956004)(2616005)(8936002)(66556008)(5660300002)(83380400001)(31686004)(8676002)(186003)(316002)(16526019)(36756003)(2906002)(6666004)(4326008)(66476007)(31696002)(16576012)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eDRiTGYrQzBjRE9mQWV6cVBqcW4yTzdERkhCbndjSnZrS2UrQzF6eFJVL0Zm?= =?utf-8?B?VkRjRDhzNyt1K1FwaFl5TGZuVmlpemRVYmtQRW9CdWhyK2g2Qk5sM0xWdDd4?= =?utf-8?B?M1k2U0grRVBQbTVnRlFJcUNRZi9nRU5xNWFJZEZXTzI4SkhCYTFJeGdrVFB2?= =?utf-8?B?clFkSmt0NVh0dERVRVYvWWlHa3Nlb3F6Z2lQODRBcmFZcVJDaWVTTkViVWUy?= =?utf-8?B?dXk2N0Fmekp6aW5ycys1akorejN5clVxcGdEZnJLQjVSdlJqVi84WGZtZXFU?= =?utf-8?B?Mlk2Mm93NW91cXB6UDNtditQSDVXbUUxZ0puWVJiSk9DeTZlODNiWWhLVXNN?= =?utf-8?B?M1JFaEJ1K2ozRmM4aGdWVU5WelpabW1uU0dyK0huanZERU9vbVVrSnRUU1pv?= =?utf-8?B?Z3VRSlJ4TFVCNDF1M0U4YjhPN0c1SVRMNTdKZHQ0YUFBMlVLbmY1OUdNa0t0?= =?utf-8?B?ejlMS1ZFWmxiS3BoRit2L3Z3WU5PT20yNHdZbVF2Mm83U2trTGdVMk9tVDJm?= =?utf-8?B?U2ZsMG9WNXU0VzVuT2hCYWR2Z0FwYXJCbG9KN1hDaDBzOEZBazMzSXIxTHBz?= =?utf-8?B?T0l3a1YyL0cvd0RlSWFXcFlMZ1VNaUZaZncwVUI4bVBuZGc0bzNoZzdqZWRh?= =?utf-8?B?Y3UrdjlUYXF3WTlmMDZjdmQ1bUJubXc4ZXZuRWJpbjFibmhqY2ttU3VvUTVk?= =?utf-8?B?NjZGTlU2QVlOUkV6SlZWYVpOTnlPZmQ0dW9uZ1YwLzBzcmoweWtEVEZ0YjBr?= =?utf-8?B?WXNGMDJjS3h0b2lySUNHL01RVUk4VEw1eFA3c3JJVUkvMUR3bml1QWhFN0VW?= =?utf-8?B?b0N0ci9GZDd1Wk9BeDRhaG1lYXhKMnRzT29KUFl3eDJMdFZSQjNURkd2Vzk1?= =?utf-8?B?MWFlTUpTNVFwVDFGclBMRXE0aS9KaG51Zkp3R3VBQ1JUeHp3T2ZydGR3bTZi?= =?utf-8?B?Smg3NFltOG1QSHVlRGNNdm51bEtNdXd0YkRvN2dHdzMzcG54bldEWXhBakJB?= =?utf-8?B?Z20rT2hrY1hWZFRIUCtaajlPTzcyRHBlRmxxTkVSRGR3eWlpYzJBM0x6VFE5?= =?utf-8?B?QzlQUjlnTXFyZE9OMlR3ejlTSFVhOWdkdVlRVFN1cWJ1YmRQMG9iZFdydXVw?= =?utf-8?B?UmxZN3czRHk1WFpyS2dFSVhxTzFJcjM0Y0pCdE8renV2UzBmNktYV2ZyN2l4?= =?utf-8?B?ckFtNmxmNk1vN2NnY1RSUlBLd1pJNUU2Ym1lRGNjYVhYWUpaQmhLclM2YkQ5?= =?utf-8?B?SzYzanlqWEk2NXR2TWwzYk0vL0lqTFcyOTNmOFEzUjhNZXFXaVlkc3pCeUN1?= =?utf-8?B?ejBHUVJ6bVExMnEvczNabWxkMnpvaWlwck94TW54dFVad2JnQVFoZWNUWUhz?= =?utf-8?B?eHE3akYzb0hndUwxYjNCd0g1QlBvTjFuMVNleUhPc1FJU0ZTS25FUkVmSVJ5?= =?utf-8?B?b0FHVWdDOVNaM0t3K0hjVDZFTDUycmhodVV3M0UrVUF0UGowUEJXNkxsUzZ0?= =?utf-8?B?bVFOclljRThOTWZpYytGNWVhWGk2UXdxR3FyQWFnMktIbkFUZ0JONTZMNXBu?= =?utf-8?B?VXVPeGZQcE9wZ2JJcERVenlYZ1RHWktPNTViTW1BaXVockgvaWpMNFFYYld3?= =?utf-8?B?UnpjQnI1MmgrRDR3RHFvUlBLc282OVlrR2ZwOWRvSkdXWTBmWnRma2RFUm1K?= =?utf-8?B?ZFc5RmN1bUw2QUxuTXlwZ2ZmQkp0TzI4b05nRHpaZHBHYUMvNHhHUDZDL0xv?= =?utf-8?Q?/6/pAxMTaQKSSCCNQ+jS6/d/JyPwKfkn4OpDUwq?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddc55f97-2baf-4867-bfce-08d8df62a687 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 23:10:06.7787 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hnFFpSQShvpEMAwKvo9F+RFBeoQBmMhLo5FRiaw6lg7FZC3WxoEDv0ViTKK0FMx+RjpAk+mNeFEPFcONkyK7w4CpF5CIRDQJ+LAJAaGvtBk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3528 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9913 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 mlxscore=0 spamscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103040113 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9913 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 clxscore=1015 mlxlogscore=999 adultscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103040114 On 3/4/21 9:47 AM, Roger Pau Monne wrote: > Introduce an option to allow selecting a less strict behaviour for > rdmsr accesses targeting a MSR not explicitly handled by Xen. Since > commit 84e848fd7a162f669 accesses to MSRs not explicitly handled by > Xen result in the injection of a #GP to the guest. This is a behavior > change since previously a #GP was only injected if accessing the MSR > on the real hardware will also trigger a #GP. > > This commit attempts to offer a fallback option similar to the > previous behavior. Note however that the value of the underlying MSR > is never leaked to the guest, as the newly introduced option only > changes whether a #GP is injected or not. > > Long term the plan is to properly handle all the MSRs, so the option > introduced here should be considered a temporary resort for OSes that > don't work properly with the new MSR policy. Any OS that requires this > option to be enabled should be reported to > xen-devel@lists.xenproject.org. > > Signed-off-by: Roger Pau Monné > --- > Changes since v1: > - Only apply the option to HVM guests. > - Only apply the special handling to MSR reads. > - Sanitize the newly introduced flags field. > - Print a warning message when the option is used. > --- > Cc: Boris Ostrovsky > --- > Boris, could you please test with Solaris to see if this fixes the > issue? Yes, still works. (It worked especially well after I noticed new option name ;-)) -boris From xen-devel-bounces@lists.xenproject.org Thu Mar 04 23:29:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 04 Mar 2021 23:29:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93417.176382 (Exim 4.92) (envelope-from ) id 1lHxOn-00036s-Aj; Thu, 04 Mar 2021 23:28:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93417.176382; Thu, 04 Mar 2021 23:28:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHxOn-00036l-7m; Thu, 04 Mar 2021 23:28:53 +0000 Received: by outflank-mailman (input) for mailman id 93417; Thu, 04 Mar 2021 23:28:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHxOm-00036g-92 for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 23:28:52 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 62d51a98-76d4-439a-80b9-e7a529185aee; Thu, 04 Mar 2021 23:28:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62d51a98-76d4-439a-80b9-e7a529185aee DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614900530; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=p6PP0uN44K0TS1I3kmOFI4MwcXkRW+LjFnsAehpQr5c=; b=HVgAxpe9ELWtrI4FzWa91TvrYT46GPEQaL4XsQz7HxMn2IaDo49YKGJ7 QjCuQcMzI5aVaPwHXNwrQwgfvQc/WfbMLiwB3RUh68yVdT5MhYGHxQIiR H49OipwMhxoKYdaihjy7OiL/E7pDyYCCO6ZzVQe/2fgu64KhlZaqLAQ5g o=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: CF2w7RCLiGsHjt+NW/ENbAPKXuGXI7fcthHfZKH2VyhpQ22itbEtFygW37PRUWFFGYuNC1xUAF uprcyaRTP0y+FKTfOSNeghbgRQjeIpYCzYa/Js1aA+ONQbdu48/g6FjzK8aLov3vw51ycMub7p BvWwBm0+SAsMUxUJWqn7ViXUbhm99qhjE9oLIaHdZPcO3rlK2u5E83G4HKf1lKmKsEb82ex1YS O98PnQg9MzPSpxmWFQBog8GNQMGBSu14r4uY31Nuj4fDzN0KuCBv+dYLOzBFYAaGHzIidKA2l8 B84= X-SBRS: 5.2 X-MesageID: 38779846 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,223,1610427600"; d="scan'208";a="38779846" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g558SdPuxR4hjtvjqQweCKRHsl4hedoTXinq9DztVY3XNsivkSHUlr42sX6XjCzyX9kt+Y4qO3ABURI2wA+yFpgs5Z+UGcUS40zNOoCe7WhRdsSoBvI2skTYOcQga1d3lXBwCudFRs2asuh/NN29OkSsHY1Ob59ULpb8ci79Xo4xDlAgPfKoEfQTUyrwn6cUSmY/qp/23jlRidkC5+jzAYAlhOPbk5ZKubhzNYDcWMfZur23mBbBhvDEfjb22EEXgDE1VyacXyhWgpOKo/qJIwintvipyXQxPb8A2KQeHjJ9mEiMVQtYikNQEF4UvAvT0IISrgnXusgIc/0aqh5zFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zht4K8WtOcQDjXZ6cTEgTKJfAZyNi8lX3hG6b5f56Wk=; b=Cdoi9rCJiuIHw88ElKrF0PgUZX63P9ALXGWRYnXPbjPq4zZdMAFqogwg5duVTrQfR1iLLqNM9T8HbiuCDQGh405XRMuHrKVkyfAc6h5zMaLpczmoXNIBLFppsoJKtNqImQCkT3C/esIjK+V5bHSy1sDkLEmIMgg72VvlKRhDRmIO/LV7Ppj50Kds6fvn0vEaRpvKA3JqllKIFlbEexZKfY7HNbPtDveV5Bp7P05TVB5xMlsBE1ki9OkWWJ/BYX2EXd0DtE5UHg2+mkGCl/jzXz7Et7K47XkT14sw8FU2eipGDeopM3HmVeT38j0vqy5DZJAh8yYnOK1rI/trbu+4Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zht4K8WtOcQDjXZ6cTEgTKJfAZyNi8lX3hG6b5f56Wk=; b=TPuyKM0PmuNk2JIje16QAyNhUV96QFXPdkP5KvoumNNSA4GZLuhtz9sccPMaKd1+c7uv1yUCh7Q43qUeI6zwyKeuiov1I3K0tNNJ3Xy3X+v9aNQiwZTE0xx7dGolHhrcUezhcjAUKMbIZLfc5mRAi3oJUwziOeDha/hCmzoNEvE= Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior To: Boris Ostrovsky , Roger Pau Monne , CC: Ian Jackson , Wei Liu , Anthony PERARD , Jan Beulich , Jun Nakajima , Kevin Tian References: <20210304144755.35891-1-roger.pau@citrix.com> <9fa2be52-9d1a-e841-5bb4-3180b4b5b033@oracle.com> From: Andrew Cooper Message-ID: Date: Thu, 4 Mar 2021 23:28:16 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <9fa2be52-9d1a-e841-5bb4-3180b4b5b033@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0046.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::34) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3f1df0ee-2d16-4501-80bc-08d8df65341d X-MS-TrafficTypeDiagnostic: BYAPR03MB3671: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3L4rDwvuWNsqRiwv9JD96Ni+HJJpfsc/3twbQNOQzP5HfImfiZpxZd+6o6liaPPSGJrRxZlUSpUPDlP7howIOeXDmT8BfUt8+BAqofNIckUVWfk4aLRmiYYxz4RF+nhaJBxbKYzVgitN6aCPt8Oqe5OgM4ZupG50vHx/h91klQAOF+0De9HprKbiwJK/ol7sKrFNqyHkR+H9EsELhr2qHtzIaHxOoxGgORrCwow8TuIq5p9IGy2x4Maf0E1kRgih1UnoTYtR07S1oOEIHzIPtFl8CNSUpVEdnb6xfL56d85OVWVt4al8vr6zJMhn+VKCP9/ebJoCSeWH4Oxk9u/CBGN0EtWnu4WEEqc5nl3RrAeW9mIIXlbEPioq5+bF2kLq4vQ9JUhaAKIqxaGKsoFOU9oTTL3CA8CMwL2ES1ysjHAgJzHDhEVzSvlfqZpBx5oFsxs9p6W5C0g28zL/0kAKPpKtSNiRAXLqLnf0vBC+jVrYmI/8ny0tOSU8J/xbhn933xJdQzllMINWz5GSBiaCGh6+W37n/103i1elfwSQa/IT6D0aVp1QJWAePOJiw1w2Tnx2B4ezdLuN/tJBVFERY98Kq+B9OAoyZxyhuAg2BEk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(396003)(39860400002)(136003)(366004)(66476007)(53546011)(66946007)(2616005)(956004)(66556008)(26005)(2906002)(36756003)(6486002)(186003)(6666004)(86362001)(8676002)(478600001)(16576012)(110136005)(316002)(8936002)(54906003)(5660300002)(16526019)(83380400001)(4326008)(31696002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?a1hsdFJqTG1ORW5kRWliTWh0UnNxb0gzc1NnZ3V1Mm5Ld1NGaFhxTmc3aEdS?= =?utf-8?B?OWlHUzN2MnNlL0o2K2dXKzZFeUFqbWtaWG56Q1R4QUN0MExyT3hkbzhPaEM0?= =?utf-8?B?Tmx6eWZpZHU0MHQ5aXVTeGtYWVJ4b2oxN0pGbVNySEZKRmg1cDFvTVl3YVFk?= =?utf-8?B?WGNkRXlKc0lUZHZZUElXeHB4S0ppT05MYnBSQ2FKZU5JRzloSVlYeVRTbzZr?= =?utf-8?B?VEtteWFLRTgxTnBvT0dCRDFBMTFwV0xySW9jRExkSEg4bHczRGpJTVNpNWpy?= =?utf-8?B?NnI1Y3JyVXNod3JwblpUNHpOK3ZaZy84K1RiSFVVUmZoRURaNkx3aTVSdWpL?= =?utf-8?B?RmhSRThTeGJoTzk0YWxrcTQ0SktIZUdPSjE2bmJ3NjZqa1V0UWJaV1RnSEVW?= =?utf-8?B?azVMbW5aOFgzRjhPQ0tIL2RnSE9TVGt4NktpODNlc2dvSmJRSzFNOFZnaXJW?= =?utf-8?B?eHpzRERTWnhjMXlXSktRaG5zbkVScmJySVZ1L2NzZDUvQ2VOZk1UaUYvNEdZ?= =?utf-8?B?NDlxMTJDUlhVVGgwQUxNZmJhOTFkOG9HZEJRMUxJMXYvaWVaQndXd2ljekZK?= =?utf-8?B?bU4wWnlSQUJ2SlJNWWo4Q2Y1ZXd0a2JGZTBJTXlGUk11QmsvTlVwVFl1MURR?= =?utf-8?B?V1lIN2F3c0s3QloxeVVWZy9GQmU3MytCUEZUY0dzVGtTdmJqSlNGMnExZjhG?= =?utf-8?B?cTBQOUhCS2srNUxTVWpPMVYzUEJxSFBxZWg1NmE3UzRXNHE0SUF3UXZnL1BM?= =?utf-8?B?OGFpMlpIWHpQRkc2MEZKRFpzSmJYdjlaMWpMUm9pU1JJYnZqK1ZuUUYzYzY2?= =?utf-8?B?clF6cWhma0NVUnFKcE1XQjVZYTE4SVRvMDM1cDMvUjUzclpTcmlzUTAxYmRp?= =?utf-8?B?S01UQVNTV0ZVQzRhbmFCUWVSU1YvZmxTaVJ3YzVRbWJjRS9hc1k5Skl2R2c0?= =?utf-8?B?VVcxcXVzMk05SUtJZGQ5bkg2dnhqQUZTWVVuUFk5VzlWQ3J3K2lvaTF2OVJR?= =?utf-8?B?VkMxWUhIYzNydFdKK2taWm44VzhNRmQyeU4zdlVWaWlSQzAybUVGMkRWeUQv?= =?utf-8?B?am80Q3VvNEkrTGNhYTJjNFJmaktyN0tNeDZ6bVhzOTVqaTQ1cXZVZFEyYlJG?= =?utf-8?B?VllVT2d1R2JwRmJxWE1Md2txK1p0c2REanFFMjBCbnVxQk1hNGVzanM2Rnp3?= =?utf-8?B?OUlHaFpnVkxFYjRaQVVYK0lULzRNeG9XWFZJY2tJMWNsaXdMK2tGaHI5YUZZ?= =?utf-8?B?aG1GM3Z1UGQxYVgrZ0tzT2x5ZU0vei9ON2JBbjdvQXJLOUtwaERnZGR5NDNj?= =?utf-8?B?S21HQjdwNUJXd3RueE1NNWY5R0hwdG5tZGZrN25Gdjd1SG9vbTQrTlZVN215?= =?utf-8?B?NTNVRUlMQ2NUNmtRYUExRXluRnhVVTgrZTFTNk9OTjQwbEM0ZjdsS2JHb1d0?= =?utf-8?B?ZTYrQnk1WnhEVHpQc3NUeEkwbnhFMW5QTnhEQ3N1UGxlbW5ZLzJHb09FMnhp?= =?utf-8?B?emRpY0w1MzRPbHZsVGV6RGoyM0hXVEFCQzhnV3NoQmkzSnpKVzl5TVdESkNJ?= =?utf-8?B?ajJSR1hMK21vZ2NnZGFCQnQ1VDErWEcraEdCOGpXRUFVSG1HVFF6TTk2VUVI?= =?utf-8?B?OHNwd0dMUW8wQkFwd1orWktWRHNXQVFLZE9QQ3RoNXdUcHluWCtEZ21Jb2tJ?= =?utf-8?B?UnBZUkR3RUJHRzNpM05aa1U3TkJqR3dFSG14d3NacEF1RE0wR3BMZXNJc3VL?= =?utf-8?Q?VrvikfO9WohzwDWDy0so7jIw9xc98qonprW9MKB?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3f1df0ee-2d16-4501-80bc-08d8df65341d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 23:28:23.3583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wxnF4xOjGg8CVVJ1mc0R+A4YeqVHpWSiX9i45iW7TLDJGIBdG2nqxoWhz68b+5VjEfqgHMLuOCogItjuxGfBoWQBVSBuSSqaCeyrozKfXSQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3671 X-OriginatorOrg: citrix.com On 04/03/2021 23:09, Boris Ostrovsky wrote: > On 3/4/21 9:47 AM, Roger Pau Monne wrote: >> Introduce an option to allow selecting a less strict behaviour for >> rdmsr accesses targeting a MSR not explicitly handled by Xen. Since >> commit 84e848fd7a162f669 accesses to MSRs not explicitly handled by >> Xen result in the injection of a #GP to the guest. This is a behavior >> change since previously a #GP was only injected if accessing the MSR >> on the real hardware will also trigger a #GP. >> >> This commit attempts to offer a fallback option similar to the >> previous behavior. Note however that the value of the underlying MSR >> is never leaked to the guest, as the newly introduced option only >> changes whether a #GP is injected or not. >> >> Long term the plan is to properly handle all the MSRs, so the option >> introduced here should be considered a temporary resort for OSes that >> don't work properly with the new MSR policy. Any OS that requires this >> option to be enabled should be reported to >> xen-devel@lists.xenproject.org. >> >> Signed-off-by: Roger Pau Monné >> --- >> Changes since v1: >> - Only apply the option to HVM guests. >> - Only apply the special handling to MSR reads. >> - Sanitize the newly introduced flags field. >> - Print a warning message when the option is used. >> --- >> Cc: Boris Ostrovsky >> --- >> Boris, could you please test with Solaris to see if this fixes the >> issue? > > Yes, still works. (It worked especially well after I noticed new option name ;-)) I'm afraid I want to break and rework how this bugfix happens.  Solaris is still broken on all older branches and this isn't a suitable fix to backport. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 05 00:07:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 00:07:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93424.176394 (Exim 4.92) (envelope-from ) id 1lHxzf-0007ck-KG; Fri, 05 Mar 2021 00:06:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93424.176394; Fri, 05 Mar 2021 00:06:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHxzf-0007cd-GZ; Fri, 05 Mar 2021 00:06:59 +0000 Received: by outflank-mailman (input) for mailman id 93424; Fri, 05 Mar 2021 00:06:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHxzd-0007cY-JH for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 00:06:57 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8e61f5b4-f5b3-4e59-8fd5-082bc97b6337; Fri, 05 Mar 2021 00:06:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e61f5b4-f5b3-4e59-8fd5-082bc97b6337 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614902816; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=PY43vUwecCeP9YiG4TSdlc8XR1NZxFwuqVyMsUR19kA=; b=bqhBrasVpRsLF4ppT0kGfj7B7rdquhy0kQM1bycen3r13ymAmaSm3dkG 11V8kUzypXcLz4poXa7GGBd1uI7PB4VNK5D4s01WHK2NRu9kBpvDotgJe pl3ym2Ie/PGpMo3wd2Mwuv5XVegtAtUaDW8b07vD7oRnx9yDm0syP0TMh o=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: oVpAzfuWutzUkIEMDvCTipAWhI+/oTfvzFvHAJ39fHIrLb493IYhpx41dSE6LCpOX9Q7yoAPsI 5Z16uZH/TnirIEFEPvpxZ/ZH7etiVL5WV6ZBrXjAPDHJ4s5CC3W9gJY1uGxWqbgZIKt497/gck swR7BTiWvgw95XAcnY+ud0fP9pLXc5b43doeAPslHENMhCPuDG7nQUfxf7KaOPtLuUcA/nk/Uw MAxh7rkPn/niT4H3KmRJhJamjB3jt8m6vlmTCgxlGP/7ntYnPIjdqHkbXYx2gpZk0CqWsrOFUp J5w= X-SBRS: 5.2 X-MesageID: 40005099 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,224,1610427600"; d="scan'208";a="40005099" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l3xhbTxRlYfbtHzPzHpUTmYAM4c0geuTPwuawhzb7++Yb/oNk2COXL3jGXYLuNw9XO+SKWemIf8rtjxyR+5c5MktbMCZ7wwM8pW0hi6YWlAKmjCV4scsBEFnO0TZOLtyvCE6RO77JMecwR6fuHBd1s5qcVbP1ezVRp1idHMPWIH7iJMl2Tpq77ifnMLaivAzg22nZw2vSj6XBI5rmaenkj39uoqP5zvyWhQR+D0X8iE833u2PQ1ZbqpNnojz1C4rQM/gEeDstJe7abvoL/744Xw9QC8IGgBf0mi/SH41Jxrf8tFjK2e2ijyhfMIkc2sg1QsW3jwf2IZGFB+btUEFwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PLjNMZl5t8bw5dTdYDW/rfKTMbrOEUz/q6D5PT9dd0U=; b=BpAcCnyFtU85AQ2kWMxWnrbGKBHpLMC36GQPJXl+d0vZbm+C303vbi9WzL6hTae/Tom/UGspzqDzhrlWVMJ7vMGpBR1SRPFS0A+kBJJOJI/xmzp2L+Hy1dfydTiFPHooEMK3LiakfQnEd7WNyO86MzTsXKSmFuhxQdmLfzs5Vt7IpKLEPdxmOMb9kD2MR2BV5SreiLaemm/uxx2xEXTL0QnJIkGWLH9/bUtdqj07acvapCft4You9lGuFqywt1yt8KCCdJfjdwaLIX8Z2oBiLygGyJEHrDIx8Heb6sSgc5rAHCz2CTJopz3exR9CMOxC1IahdaDx7JWxX+gRNFjRIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PLjNMZl5t8bw5dTdYDW/rfKTMbrOEUz/q6D5PT9dd0U=; b=pIw6Y5N/k74I/rik7lqRdTrB2nerrtMGHKSShPlcAf3I7hGV0yp1KUjOZFcGYVJPaVUbJx+3APiocEQKFV/uZzytT0eklYvKx3A5jdZr5Dg76iqWAGr2zacV3fFsQQfEoqgtlopIZ/s65/ZI4J/7qNZ0mb14Da3dN8hIjnRHau8= To: Roger Pau Monne , CC: Ian Jackson , Wei Liu , Anthony PERARD , Jan Beulich , Jun Nakajima , Kevin Tian , Boris Ostrovsky References: <20210304144755.35891-1-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior Message-ID: <4cb7e1f3-0593-6d06-281a-e3bf06843221@citrix.com> Date: Fri, 5 Mar 2021 00:06:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210304144755.35891-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0386.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 302039d4-925e-4489-65b7-08d8df6a852a X-MS-TrafficTypeDiagnostic: BYAPR03MB3861: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: moA61SqhrTSkqwSZb8mmIAU10AbY4neO1JKw2y/MTiOplMrjv4q1tkeNlxInoZ4/NMrXyBqh3RT5SYM8uNGGxONfUMGve8r2NWNEajcVM0WlyEIaJhm3ruoRQRasNKzIPxuy9MkqPRGV7qqP/f+dRnJW8cKWsBAENgQn6J+p1B204x/mkXThfZnYWycuQsI1ie0MPqKSSQLiEiH5YqzbeArw52ZogYxZSrIdoIZZDh9+HpYRz4s5KGp9WgKrt3ipn3Vv0pP8W2LQnao20g266GSQvcQ+L55I0zP3m9PLeUAtNXKGS+4KBoqJmDhFUXehkh5J6yefIl9YoOpPcc/CLQbMHY5joYfEDlV1dA7Fc9wT4RKHiGlBD9RcOfr8TDlc5ptjiVVUgg8Iax8rxH8JThCnsgC0Ru7nBdQTcsH4qRgYlzZkwgKMHUBe3VO9zBKyNwUp0Jko5g/2qigyDgRYWQFLDnFVjXpnFJzyI5y4mVhaoAzRHe888VFbMtNVFoe9n9JBBLYrfupdvQ4Y14VtbYOZ0WPv3FgVxyXbdLHVL6EKvatmT/SwHYU7WJgLFsMGbiehXFWEFuGLuAp1/wlw4MFpB0O9oEWw4KfHGC7IccI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(8676002)(2616005)(26005)(31686004)(5660300002)(16526019)(86362001)(8936002)(31696002)(36756003)(6486002)(66946007)(186003)(66476007)(83380400001)(66556008)(478600001)(6666004)(316002)(54906003)(2906002)(16576012)(53546011)(4326008)(956004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZVJxdGtjRjhwdFcxbmtNdWJrWFNhM0g1VGlGdkVGTE1WTGhQOFF1NHlQMUZv?= =?utf-8?B?aXFUNkVZaEZLeGtYTGI0dFgzZDJQK2Y1VStYQVNkaWVhcVN0RW1ZQ0lkVTJ0?= =?utf-8?B?d3pONjZsd25ZVTdUUnZ2dzlPcWlTajVUUXgxZzE1dlBBcXd6WUlEZDN5QnFD?= =?utf-8?B?K2FkaHpiMytSM0VBNm42ZEdlZWVLc2FmTlgvejNGN28zeTlybGVCWSs3Zkk1?= =?utf-8?B?eThjNEJJWHFHZzg1bDhiOU1lMGlJeGNXQ2ttTkFUK1Jud0UxdkYvN3B5UjdY?= =?utf-8?B?SE0yMEpmblg4eUpsS1RURy9FK2g3NFVDN2g5bEdrOEtEbjBTK0RETWdhRUZi?= =?utf-8?B?Y3hNMENobUNkV1FuWGFwckFZZzRYcndMejRaTlJHM3c4ZzkwWXNDVldma2Ns?= =?utf-8?B?S0RpRXB4SEVkNVBRQXFSRVBRQmR0RlhqVVpkeHc2RnplZmdGRFhBRHNLSGZ5?= =?utf-8?B?MzRINklDRmJUSDJVdGxlNlo5ZE92ZUxKeEYxM1FXdnd3L2VWcE1kTVhjZjFI?= =?utf-8?B?b2xmN3dTSE40YlY4V1BNSUlqOVhsOW1BejBXVUxQWGZnamhpZ0RQQjFMVUZZ?= =?utf-8?B?a2pVK2RPdlNsMlBZN2EzVERvUjdOZ2QzV1RHb2ZpdFlPcjhabElFUFQ1M1du?= =?utf-8?B?eG1iNWkrS2xRWDF2UUpyM0w4My80MDIxUCt6OHNJV0luTDhjVnFjcUpSRjRG?= =?utf-8?B?WXA5LzdlQjZwNldFS1NucisrakR1aVZJa2JPM1I1NFltMnJEN1lldDVtOUpU?= =?utf-8?B?c3hUc1VsZ3dPUWd0UVNuZXhsc3ExZzdQbmNPZHpxSW8xVzJLNkpBeGRVWUE1?= =?utf-8?B?bFlicExyVUI2Z2M2ZTNKd2hiZG1RRkxteUFRcUoyMTQ4NGNObjQzOWxGT1lV?= =?utf-8?B?WFV6c2daU3o1YmNzWnFmQ2FwWU8wNnk0ZVdnNVlqOExSTjMydmJtQ2tDNHpv?= =?utf-8?B?UTJlN2JHdnIwcGswbDE2Rk4vMVN3eml2Vk9BUkNiRWo2Y00rTWQ2ZVRkUDZm?= =?utf-8?B?VkVwZjdBZ0xZYU1FT0ZJQ0dmQ0xGYm0rdTFXa2d1eTNDb1JjTVE0UXBVemhr?= =?utf-8?B?SW8xQXdta1ZqQkVqaU1nNTNFd1gyM0x5cTV3bC9IN0k4QjlCY1pQbFFDYTB3?= =?utf-8?B?eTV6cXRLdURvSDVnaEI2Q1R5V2t0eDU2dm5LQUF5NHlmb09wYk5CbjFFR0JX?= =?utf-8?B?Slp4cVFNbXBmRi85cHhlTEp0TXpMbldjUnkzcklDTlpldDZqdENkZlB0azdW?= =?utf-8?B?MWFraElYNTBGQTRKejkzaTR6Vm9HRm1LSVprY2lRYWkzVGVqVStDZENySzBI?= =?utf-8?B?MnN6VmJPUDg2SEtaaUFNZVNLaE50Rm1vNkRNeHQxZDVzYVYrSnltM2xFYi9U?= =?utf-8?B?aG9vbEErTC96VE9obC9vU3ZFVEphUlIvT1I0QzJEWEhrT1F3UWZBSjhxQ2VZ?= =?utf-8?B?TWdrOTFtM3h0cGJuLytMZHdnWXFFYXRLT3B0MlB1aW9lejkzNndPWW15cDdp?= =?utf-8?B?aEhXejE4N256Qjl2SE1EdXFBR2dia2lWSGw5VWhZc1RYbHdyek1zVk91TWM1?= =?utf-8?B?UmF5YnBXcldPVUxaZjJsdU1oNXl3TThDY3NodnpBNVRwUWRJWDdDZ1RmTzUy?= =?utf-8?B?LzY1MytnM3hBNjdjcW5sU2ZYdVBnRHlvL2F4V1ZlT1h0ZVoxa3o2MUgvbTBR?= =?utf-8?B?N2Z2V1dxQVFzSXFWMmNlb3JXUnZuVGNUUllQdVZYWS9xQVVXYVlmMmJHcUxk?= =?utf-8?Q?HkJXEbx9CoG4wPBjubCrW/KqnzMHGZ3htPaLqlW?= X-MS-Exchange-CrossTenant-Network-Message-Id: 302039d4-925e-4489-65b7-08d8df6a852a X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2021 00:06:27.0348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o4VBW4tq88zg28E49O3PHgLndJcr0MEb0bMJx6WFTnccYMsOkd+XdvW1ZfnzsPfTAxX9jCN2PEAZUKyMrW1jd8GauokpEcmYcOz5pbNr8wg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3861 X-OriginatorOrg: citrix.com On 04/03/2021 14:47, Roger Pau Monne wrote: > Introduce an option to allow selecting a less strict behaviour for > rdmsr accesses targeting a MSR not explicitly handled by Xen. Since > commit 84e848fd7a162f669 accesses to MSRs not explicitly handled by > Xen result in the injection of a #GP to the guest. This is a behavior > change since previously a #GP was only injected if accessing the MSR > on the real hardware will also trigger a #GP. > > This commit attempts to offer a fallback option similar to the > previous behavior. Note however that the value of the underlying MSR > is never leaked to the guest, as the newly introduced option only > changes whether a #GP is injected or not. > > Long term the plan is to properly handle all the MSRs, so the option > introduced here should be considered a temporary resort for OSes that > don't work properly with the new MSR policy. Any OS that requires this > option to be enabled should be reported to > xen-devel@lists.xenproject.org. > > Signed-off-by: Roger Pau Monn=C3=A9 > --- > Changes since v1: > - Only apply the option to HVM guests. > - Only apply the special handling to MSR reads. > - Sanitize the newly introduced flags field. > - Print a warning message when the option is used. > --- > Cc: Boris Ostrovsky > --- > Boris, could you please test with Solaris to see if this fixes the > issue? > > I wonder whether we need to to enable this option by default for > guests being migrated from previous Xen versions? Maybe that's not > required as the option is helpful mostly for early boot I would > assume, afterwards an OS should already have the #GP handler setup > when accessing MSRs. We know when building a domain whether it is a migrate or not, but don't recall any version information existing at an appropriate point in the migration stream to do this easily. We can buffer the stream forward and peek at the libxc domain header, which does have the source hypervisor version, but that is going to be very invasive to implement. > > From a release PoV the biggest risk would be breaking some of the > existing MSR functionality. I think that's a necessary risk in order > to offer such fallback option, or else we might discover after the > release that guests that worked on Xen 4.14 don't work anymore in Xen > 4.15. Much as I'd prefer not to have this, I agree with the sentiment that we should have an "emergency undo" which people can use, and carry it for at least a short while. However, to be useful for the purpose of unbreaking VMs, it must change both the read and write behaviour, because both are potential compatibility concerns (without reintroducing the information leak). > --- > docs/man/xl.cfg.5.pod.in | 17 +++++++++++++++++ > tools/include/libxl.h | 8 ++++++++ > tools/libs/light/libxl_types.idl | 2 ++ > tools/libs/light/libxl_x86.c | 4 ++++ > tools/xl/xl_parse.c | 7 +++++++ > xen/arch/x86/domain.c | 10 ++++++++++ > xen/arch/x86/hvm/svm/svm.c | 6 ++++++ > xen/arch/x86/hvm/vmx/vmx.c | 7 +++++++ > xen/include/asm-x86/hvm/domain.h | 3 +++ > xen/include/public/arch-x86/xen.h | 8 ++++++++ This needs changes to the Ocaml bindings as well.=C2=A0 I guess I'll add th= at to the todo list. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 05 07:25:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 07:25:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93450.176409 (Exim 4.92) (envelope-from ) id 1lI4q9-0002MS-35; Fri, 05 Mar 2021 07:25:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93450.176409; Fri, 05 Mar 2021 07:25:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI4q9-0002ML-00; Fri, 05 Mar 2021 07:25:37 +0000 Received: by outflank-mailman (input) for mailman id 93450; Fri, 05 Mar 2021 07:25:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI4q8-0002Lu-2y; Fri, 05 Mar 2021 07:25:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI4q7-0008TV-OP; Fri, 05 Mar 2021 07:25:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI4q7-0004Go-D0; Fri, 05 Mar 2021 07:25:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lI4q7-0004I8-Ca; Fri, 05 Mar 2021 07:25:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=y0L0ObEYSbVgrHJcNqdh6IqqeyB2umqWL9FT8D+mDv0=; b=C/VZ7TpqTKOKrTEo4SVsi0xCLz OVJqE5FpYcf9ME8mydbd6WjodiI0Zd06Ydquzl1r+sLUcC7Xq66ut6dwERz7GuEgxMMntjSRCJLje Zces7wQI51BOG1ljbZEWfWPqlz7mUXfT25r2/sUB0W/dpVkLyAkV/2XOL7ne+4tVOUkM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159828: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=cb90ecf9349198558569f6c86c4c27d215406095 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Fri, 05 Mar 2021 07:25:35 +0000 flight 159828 qemu-mainline real [real] flight 159833 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159828/ http://logs.test-lab.xenproject.org/osstest/logs/159833/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu cb90ecf9349198558569f6c86c4c27d215406095 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 196 days Failing since 152659 2020-08-21 14:07:39 Z 195 days 377 attempts Testing same since 159828 2021-03-04 14:08:29 Z 0 days 1 attempts ------------------------------------------------------------ 433 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 118747 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Mar 05 07:59:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 07:59:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93488.176425 (Exim 4.92) (envelope-from ) id 1lI5Mt-0005Y6-QR; Fri, 05 Mar 2021 07:59:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93488.176425; Fri, 05 Mar 2021 07:59:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI5Mt-0005Xz-ND; Fri, 05 Mar 2021 07:59:27 +0000 Received: by outflank-mailman (input) for mailman id 93488; Fri, 05 Mar 2021 07:59:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI5Mr-0005Xr-Ro; Fri, 05 Mar 2021 07:59:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI5Mr-0000Zo-Jv; Fri, 05 Mar 2021 07:59:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI5Mr-0005WV-99; Fri, 05 Mar 2021 07:59:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lI5Mr-00089X-8H; Fri, 05 Mar 2021 07:59:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=v48B7s+vGAgJja4hFI2n2hRols4vaeKx7VZUztx37Gk=; b=zlhyy+fE+7OwQc+Ztc4ZY9JnyD qgoEewXCoCOHdiFDPQFXYBl2Vp/SAwJYGxQaznRCq55vhFCfOc/pKP+FyHp0Clcx++DRiLnIgKDwz Iu/GDmrptkYM1SwfLKNM3V1xoBTiZXf9KclwaGSMTsAMCXBhJPIsgFMtgr+1Gww+VrJ0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 159832: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=f81d504b71a86ed501f8caca2f08613863784239 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 05 Mar 2021 07:59:25 +0000 flight 159832 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/159832/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt f81d504b71a86ed501f8caca2f08613863784239 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 238 days Failing since 151818 2020-07-11 04:18:52 Z 237 days 230 attempts Testing same since 159832 2021-03-05 04:21:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 45588 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Mar 05 08:27:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 08:27:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93506.176440 (Exim 4.92) (envelope-from ) id 1lI5nh-0000Vq-GN; Fri, 05 Mar 2021 08:27:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93506.176440; Fri, 05 Mar 2021 08:27:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI5nh-0000Vj-D6; Fri, 05 Mar 2021 08:27:09 +0000 Received: by outflank-mailman (input) for mailman id 93506; Fri, 05 Mar 2021 08:27:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI5ng-0000Ve-1W for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 08:27:08 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f8037fff-4e9e-4fdc-9c45-59f90a6fee8d; Fri, 05 Mar 2021 08:27:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8037fff-4e9e-4fdc-9c45-59f90a6fee8d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614932826; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=vh8POYMFxyx0VkNrX2N0alcZPj8n6yeCP8JvSUVPOA4=; b=HTOPLeJZS/p7cO/v/Ff6l1c8EpIXxrRUkQw5X1XUXzVYqbJi3dZ20BLq CNUHVH/n0zywuZSR20dxHX1WKApQJV3pk2PO3CZmPO5a4a2p1GCLwRqL1 ukaQUEj0qcLxAQZFWBT5bYwGwTGiJE+hYaNYmZRQnzhedkbh4/wZaCiZK Q=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: oB/TpDvz2UsCGoxyFxG+hM3jVLgMaSzl1Vsb7uib6LOH2oeMiSf3d5yLqotKESAYzEkq8X+6Fq ZRGcp/FrFhQWpeNwllKZ8Eyorar1HQBeozx9F50eRPHRqYuGcD6Jqd+iXr+54Rhtas+9BjM/Qn etOW2r68qeI3MEel1dqhQf3kEIMdvVJ1WgVc63AOwfZ7i3nX736unmz25PtDnN6z8wExwdJbJw ACOpM01mLUSPofE/AS6Z2keIonJYv9gxsDLLcaRHc0iC6tlDwo43DDdQWPjVweQO1nh9QLO3ik kQ0= X-SBRS: 5.2 X-MesageID: 40025730 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,224,1610427600"; d="scan'208";a="40025730" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dCCsthJtrbxHDRobbdgSXWJwHjwOmQYCzDafY5q12oDUSp4OIQW1PB7YO/xshaaBeNuPZjLmp7iWMlHfS3jWPyLyWX+eXJnq5vmqqJEFLoqQuY0kngZS7zs4yOgfAVMINzro2Q1VJ4F6pz23Se1kgHY/TPkTUq+3fdGAAVyc3LcOhyclQNDAa3P7xBcSaICboxeBMSIqOT58BMDeZFiX+mXsNl6+TZzNeW5X87cKGQu7Mx7cBlP5Q0DSxxMmUm5htohelnKecSWX9RqS/c+kaVtNt1uSkk5MVjgwRcFO2QXnQcfnRgSDpz0FSw2sfmtGd9RYiBI7FXI39GPVK74rcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x/a65TvFqrVTo8Q59SmXe5rwnFCzjuHoRiLLEmL9zKg=; b=UXzYEE9NoxDiVMY5ashFLOu0FvaAO282SmB7TqLlmOrukw2HeCNAniGoFqD2gHAxIEx6I2yOxK44ln0krcDfW7egVAtlBuGfWdRzMa47zoHXZJkGM14PH6QSDqbN2QQ2Hsbzqh+8V0Nm1Qn7d8nW2ECasMWutHtMszZ5JH6TFQgKH2z/PDW8WE9o/+O9/tqGYUiZ3NZt0mbQeO2jIRmKDCSCz/IpFSJEHyQXNK1VlwvUuwUdm20xEAGPJms6CdsrCL+9XyW5nQVfFXgjQqLFh5LX2nEWbaGYrsRv/PJWYJ1kKn9LgEv6yWl7EE0MFGFovwCFcO5KFCQ+TNYWnY5khg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x/a65TvFqrVTo8Q59SmXe5rwnFCzjuHoRiLLEmL9zKg=; b=wvXVHR1uah2vOYpTRq5yYZd0yECeq/Mkn/NmAtyjEbmmUlqg2u8ezKb3jYIX1siv9lm98jnlDARkarsOV6nkKc2rwdwAsM3vOZlVJeXb1kb+5xR1lfC5LHh9pGOyCIAG/PTA7l/XuqnLFqtP9YG6yLHpBzFdwsUAkJaWtbwNMyc= Date: Fri, 5 Mar 2021 09:26:36 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Boris Ostrovsky , , Ian Jackson , Wei Liu , Anthony PERARD , Jan Beulich , Jun Nakajima , Kevin Tian Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior Message-ID: References: <20210304144755.35891-1-roger.pau@citrix.com> <9fa2be52-9d1a-e841-5bb4-3180b4b5b033@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LNXP265CA0072.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::36) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 350d46bb-da99-4f61-1cc9-08d8dfb06805 X-MS-TrafficTypeDiagnostic: DS7PR03MB5607: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3PyBwov+TgqOdEngGmsWUyPtsFdQxKF2VbVB013w0gLyfsY9c+0Jwdt6eyfd+N8431l2WP3eStFToapcvdStiYfyNbmQGHEEjmckI8XmnTBUr11ltCAaUlsUKRbbhy8AEhoGjynV6vRuKMYtEDclnd4uvjynrj/H41AEaBW6/hxjBfYp6mNjtxaqD+FOHwVjByfDCIbxd0hEZYboQUfr/hZ4c0qv4lkPdy7mf7YjUUjECz+5ywSb9QN1rC81SbL2MlKws9j5CEShfk/Pm1IzVtWS5SPu0tEdH/eZRqqmf9Uyip32zU/xc/ORGYc9NnSY7ZaIBmH+qYxgReAGRirUCVhf81Re/SwNXYS0ynZ/XsaYDoLeW8NCsm54vxXwvYYslqrkqet3UgSEakvpyNEpkhm0wIvBpO/luaixeeR6u29W2KNBEu6eIjJ94Td4syWeamxDe7wj5zNC2fAz1BwrdRaWV7j3RKU4qyaPchpqZoEOMaTSpm2N0aKNvbaYbdGAgwzIGfE6ED8MkV+Dsw401ZAcRW8/TSOZ/yTyF4R5BpG3KCKRAEpQ1nNDA31rPhtn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(5660300002)(53546011)(9686003)(66556008)(316002)(478600001)(6496006)(83380400001)(6486002)(6666004)(2906002)(6636002)(85182001)(86362001)(26005)(186003)(6862004)(4326008)(8676002)(8936002)(33716001)(54906003)(66476007)(956004)(16526019)(66946007)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?SHF1NHNHelBxUTFsb05lNE44SXMyQnBSNUpoc3FOTHF4OWVxankza0NXMlRl?= =?utf-8?B?Z2J2eDQreVByK2tqT0xMWkFUV2pyaHA4bTF4RnREN2t5Y25Pb3R0ZVIxQUNq?= =?utf-8?B?RnpJTGsxcTBMaHBROU91WGhPYy8vTkZpY2hjMS9TVEZPdStpZTdDM3F5ZTlz?= =?utf-8?B?SDBJbU9zQzZRNXlYK0llMFpIcHNGMW9pbW9PS25lUWtabEw3dW9TenB0bWNV?= =?utf-8?B?RjJGMnFscEhJVWRGdFZ1Rnc5ZERQM0o4RFhEeEhJQml6YXNpNzVMVEdhWTh5?= =?utf-8?B?djBablU2d0VwdGxGUGRvclJtQmw5U0Exbi9xQlhXeHNteVpEOGlDeC9kbktP?= =?utf-8?B?ZzJnRU9JczdXbDlWRGhBTzdPUUw4N2VoKzMrMFpKOUJURTF4Sm40OE1DMFNC?= =?utf-8?B?bEZUN3owRVZaY2c5UUw4NGJWODA5Ulo3RUZWaFFnRG9ycUR2cC9GckVRQkdD?= =?utf-8?B?UEVDTWxJZFBwbEs0a2xsa3h5ZUI2UVRnTWJOOXNXYjAwRGdZZCswMjdIbU1l?= =?utf-8?B?SzFxd2NMbVJvdWQvSnpHbTdETkZ6ak9xVFYvMFhvWSs4aFk3cWdTV2hrb1BQ?= =?utf-8?B?N1krbmROckkvM0ZnSHoyS0t6M040VWRNMW1LZ3hjMUFiME9NdFJuL1Z4SGtX?= =?utf-8?B?S1hkTER4SHNTamE4b2JDNmRsb3dPd1NNS2lwbFgyVnNMdGRuZVZuOGs5eFpW?= =?utf-8?B?K2RkYzdaZ3dwSVBKZnRleEdHSVU4MXhtWVVaOCthbEhKcW91anZCcWswTEZh?= =?utf-8?B?aEZFaGtBZ1U2bWFXMFR3d2JhM3A5U215alExUnJReDY5dEZZUlVOcWttdVpm?= =?utf-8?B?VVlHa2FiTUwvRTRmOExXNUFSM1Q1ejlTRjVSWUhVc2dFU2FBWFc5ZXkzV0I2?= =?utf-8?B?SzJnWjZIT2xvMkY5N0ZlOEJQZWxjQnlPdlluVVFCcG9aZk0yREUyWlU2N3o5?= =?utf-8?B?cVJMTi9RY0RpUWN3czNUeThkNjR2bVV0cmpaZTNOMFNBRU1CK0I3QnRVbTFR?= =?utf-8?B?dXhVay9qNm1iLzNTSFU3VlNwd09BdTV1ZEtOaDRYamNBa0ZlU0g0UjBiQW5U?= =?utf-8?B?bk9aSTVRNFhaeUt1SzNJSmF2aThUZ3pEai9Pbm9RTUxHZHlyRVJPQktpQUgz?= =?utf-8?B?MUFFRi9rM1d6OGl1ODdEcDkvOTFJOS9lS2lhSzJTL0grNlJ0Wm1wZUJYM0Fa?= =?utf-8?B?TjhxL1ZoNC8wTnUyc1U4OEJkNWgyeHRTVnBRaWhUWkdRajBUOGd3L3JxQUky?= =?utf-8?B?Q3dtWlcrV1RzQ3NvVEdmTktTMmd0ZTBwUEJyTU9KSEZ2cEVkMUN2WDZ5djV2?= =?utf-8?B?b0hmTUYwSEVmR3N3VjE2cmxsR3FSWFY4M2V2Sm9GbC9hR3FBNnpuQ0phTDV0?= =?utf-8?B?bDZMMXgyVmlKMHZBdERoYXVkbExLTkVEVk1oTDh0WW1ZUVRsUmZNcElRL0w1?= =?utf-8?B?ZC9lUlUxdGQxalo2OVlJcFZYK1NaNWRxUkNERDQvZXdVMm5jb0pFaVlOemVL?= =?utf-8?B?WTUwTXB6cVJsc2t6U1JXSkszUlBKUjQzek51NGc0UC9tMzZPRnRtd1RKU0F0?= =?utf-8?B?RDRFcjZHV0MzdDBiVnVZSDh5L2daZk1OWU5wYnVyaTBGT1FlSlNHbURzQzg5?= =?utf-8?B?a2o0L0JsRmNNR1pmZHpqZlhmNlk4bitJazBYa2plWTRKc2RpVWJld0JoSjly?= =?utf-8?B?ZjNPcktlc0xrYVBrbVRRVHNpanJ1aW1yaGEyMmw4N2RKWGZLd2ljVkQ3VDVC?= =?utf-8?Q?9ETcFUsZXXf8zdgyvB+we53RSet0uGKBA5gDEnG?= X-MS-Exchange-CrossTenant-Network-Message-Id: 350d46bb-da99-4f61-1cc9-08d8dfb06805 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2021 08:26:42.6503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UrwJ8g+hCjcAARTbq7ghuJ5f7xWGQJTMHVj5jtR2slrRPJ+oGjYvm1w2wBNNL1M2RsjFx5tBAKXtaPg3a/TCAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5607 X-OriginatorOrg: citrix.com On Thu, Mar 04, 2021 at 11:28:16PM +0000, Andrew Cooper wrote: > On 04/03/2021 23:09, Boris Ostrovsky wrote: > > On 3/4/21 9:47 AM, Roger Pau Monne wrote: > >> Introduce an option to allow selecting a less strict behaviour for > >> rdmsr accesses targeting a MSR not explicitly handled by Xen. Since > >> commit 84e848fd7a162f669 accesses to MSRs not explicitly handled by > >> Xen result in the injection of a #GP to the guest. This is a behavior > >> change since previously a #GP was only injected if accessing the MSR > >> on the real hardware will also trigger a #GP. > >> > >> This commit attempts to offer a fallback option similar to the > >> previous behavior. Note however that the value of the underlying MSR > >> is never leaked to the guest, as the newly introduced option only > >> changes whether a #GP is injected or not. > >> > >> Long term the plan is to properly handle all the MSRs, so the option > >> introduced here should be considered a temporary resort for OSes that > >> don't work properly with the new MSR policy. Any OS that requires this > >> option to be enabled should be reported to > >> xen-devel@lists.xenproject.org. > >> > >> Signed-off-by: Roger Pau Monné > >> --- > >> Changes since v1: > >> - Only apply the option to HVM guests. > >> - Only apply the special handling to MSR reads. > >> - Sanitize the newly introduced flags field. > >> - Print a warning message when the option is used. > >> --- > >> Cc: Boris Ostrovsky > >> --- > >> Boris, could you please test with Solaris to see if this fixes the > >> issue? > > > > Yes, still works. (It worked especially well after I noticed new option name ;-)) > > I'm afraid I want to break and rework how this bugfix happens.  Solaris > is still broken on all older branches and this isn't a suitable fix to > backport. Right, I think that's the reactive part of the fixing that we spoke with Jan, but I think we would still need something similar to rdmsr_relaxed. There's at least one other MSR which Jan identified that we also want to handle MSR_K7_HWCR. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Mar 05 09:03:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 09:03:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93520.176452 (Exim 4.92) (envelope-from ) id 1lI6MH-0004M2-AZ; Fri, 05 Mar 2021 09:02:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93520.176452; Fri, 05 Mar 2021 09:02:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI6MH-0004Lv-7R; Fri, 05 Mar 2021 09:02:53 +0000 Received: by outflank-mailman (input) for mailman id 93520; Fri, 05 Mar 2021 09:02:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI6MF-0004Ln-If; Fri, 05 Mar 2021 09:02:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI6MF-0002Ag-AM; Fri, 05 Mar 2021 09:02:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI6ME-00015k-Uk; Fri, 05 Mar 2021 09:02:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lI6ME-0000wg-UH; Fri, 05 Mar 2021 09:02:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UA9eE0pqpWgSGwoYXf1Odvd8YO2vf5G+rcz94toPscA=; b=p0qdeHADFBolz0ZbabCkhRdYIJ RfRTgMQhPQoM2U5mHof3QV0R85zKZ6RI0UDh+5xmfEOrHf3t1apbCFRYQNbd7GshiQIyA7zTNo9a+ KdtzdkiPDiJGZ/6yM5bOg8+sRYDMSOljxBKkvPOwC8a9Q6SFxH3uaQEVZ6DE6O+LLmMc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159830: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f69d02e37a85645aa90d18cacfff36dba370f797 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Fri, 05 Mar 2021 09:02:50 +0000 flight 159830 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159830/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux f69d02e37a85645aa90d18cacfff36dba370f797 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 216 days Failing since 152366 2020-08-01 20:49:34 Z 215 days 373 attempts Testing same since 159811 2021-03-03 03:12:26 Z 2 days 4 attempts ------------------------------------------------------------ 5136 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1271901 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Mar 05 09:15:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 09:15:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93529.176467 (Exim 4.92) (envelope-from ) id 1lI6Yg-0005Rv-NF; Fri, 05 Mar 2021 09:15:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93529.176467; Fri, 05 Mar 2021 09:15:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI6Yg-0005Ro-K9; Fri, 05 Mar 2021 09:15:42 +0000 Received: by outflank-mailman (input) for mailman id 93529; Fri, 05 Mar 2021 09:15:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI6Yg-0005Rj-37 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 09:15:42 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b912cdc8-618a-4ff1-9200-81746f2b41c2; Fri, 05 Mar 2021 09:15:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b912cdc8-618a-4ff1-9200-81746f2b41c2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614935740; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=5WLW6xC1hb0LU3xrQHdVehbuDxwwHl4xlznZGb0zOwM=; b=bOnsVexKyudxtz0ix0YUQBAjWxv1TV4CemImmlghHTbnsZoshxQVFuzi g7FawgmEEYOfphMSeSgf8Q//swsTuvST0ZeKPmeoSqcV8bVDs0/EzSLTL XIApYT6fztpU/qNeWEEegbzk1Ew5YWj5D5x4zY8RWfpm5tXWvEsECe9v7 M=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: WZxMw46G7MlCecjbeiNHYDAqKc1c6lUoLDWzfrO+zkb8wkmanAGwnZ5LYyy+fl4OAYfPryqXf1 brsdoNTHMYeVdWFlx3x2emwq3INhdjkp5qsCLBMm4+jmXCn/E1/Jdnls58k6geFg/Py+Bpvaww nRyVD4CmQAsYCK2p0sZpiyNKPftiHFNp1uG32Ji/xFAiRULK8mYihBOLLUiSME3hUf8DNSJWHH 2OVM56DUYgB2YH7yhW4cEfGReElebH2pAYovAiVOUY5QLEblxVNdmNH/Ekx8zBOpbthhsDyu0r H0w= X-SBRS: 5.2 X-MesageID: 38536023 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,224,1610427600"; d="scan'208";a="38536023" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jdvgrkap3HRD13M81sY20CQAkeQpBrzilcYQ+QF5s4WC+6fzZr+zUbhwOmOLpeJoUqyJyeGxEbSsb1Opsbog0b/KmaTbZVrAD2ZgTG7eB8WpjZPwHlucHOhBS1a1zCNlg45VnsiZHyQ/2OkqvKy24ANLomnkAzgb/a/aphSQXsSB+1Gz8rOiuhebl5H7hBfhNgqg13BFssBAGKK4LDVgeuvsV7vAp9XLdXqCM42Xq2IQJrcFtEcjG+wbZX9OJMRpBIW7ubtbqS9FhnDWprKcxLaMTHPxqYtoprSCMCTbqNatDOyLwQgM3FV5AOIBYKJRIiIkxXmDgc1DfeOz8Dhwhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=STPnH53ZsQpCKQ9ZN7EFp5JtlTRdLtQXi0k0FIJDNpo=; b=cqKuR8tDSbVQSUhiF6KVymWMf6ketbN2Z8WRMWFiqek/+/4rQENX9GX4z5GribYRUwtZoo3nflB/2w7BYLxsdjzLMWrULfwejkaFNsGOEX6T5u5giy150cWT7LVN7AwRofRo9vYbGpg+J92gZH9r/w0lM5gxKTI1sJohANdWzZBZQ3sh2GFY+QyJllynMBz04sFUO+3kBRfcmuKp5bMeXh2F4360rIaT53fgnbkkoElzn4YKT9usuloQEg4Fwenv9Egb4jI8msjXfXMJ4Vkq3No2P+rBAozeqhel+rHTtyRIxptduD+KcgyLTGqWxdjYUAYmSgD8l28dyh7iGwue1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=STPnH53ZsQpCKQ9ZN7EFp5JtlTRdLtQXi0k0FIJDNpo=; b=YitAHVdjr4y8B9Pp+aAMZ+zrh4c/IHHtZS9ts7sTe4/CrgGQ/e9dJJQP/bEqTyymYQ1LM5Vy60pnFDcTK67eZkhM9pako26Rum7RERRvekraovjKKP5zCRwkDIxngrqQmme10rgKEo2ZTQV6JmitSmv0MVQwyZ5ZYF1BqQXhp+Q= Date: Fri, 5 Mar 2021 10:15:24 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: , Ian Jackson , "Wei Liu" , Anthony PERARD , Jan Beulich , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior Message-ID: References: <20210304144755.35891-1-roger.pau@citrix.com> <4cb7e1f3-0593-6d06-281a-e3bf06843221@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4cb7e1f3-0593-6d06-281a-e3bf06843221@citrix.com> X-ClientProxiedBy: LO3P123CA0001.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::6) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 65c9924d-4f62-4a87-8785-08d8dfb738d7 X-MS-TrafficTypeDiagnostic: DM6PR03MB3674: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KnfbRJ5UzEs6kwIiJEUSG+huRojxUl7t5BthWE9lLpcDWQmyUMps31o3i8qSLBUpvChHMkdpHRmnI/kZhMYaMdSZik2Vfeg65Kh1KqZoZ+NEfAj84V1VFCWxbc71u+mI8YMxOasFKG5jbNORLnnO8nWqdYF8q7eloufy2eFs36bkzCjw8Ze4BmwkUL1bbS1/drmLDwjljEfDnT46gUQItpH+Nfx3BF3+Kw6ro9qCWv2PoMJHDdfLtlRmJTfXHnG+GQsuObADuv3+Zr0ixrP7GKRxVgHcA3Ll2I+poM8QAvMK0wy8LPGEeVbTbj6cgtfQO9Ktzusz5mYyXHjrqGfLeJvkyYdIr5tnEYj8QtrrCmF5pbiU54q5QM6DbdOwhW9HW0iPdDp2pgXR4ZnmKu6prySZZGiqQU39ACTbvh/v+B+FdV7ERPaViOZKCTAVOJByd+J/8zwni+gU6q3RMA8BguLvSBHHdAR5+mQaHyMKm/R2ApNzudR+RBQFINrW8fLgYX1aDar1wOV2BZpSEVNW4g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(396003)(346002)(136003)(366004)(39860400002)(376002)(16526019)(186003)(26005)(6496006)(86362001)(2906002)(956004)(5660300002)(53546011)(66946007)(66556008)(83380400001)(66476007)(6486002)(33716001)(54906003)(8676002)(8936002)(85182001)(6636002)(4326008)(316002)(6666004)(6862004)(478600001)(9686003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?OFQxK00vREM5U1BjQ1hQL01sSUtrZXZPbm5seDkyS2ZRQld0QytDVDhJalpR?= =?utf-8?B?cmFFd2lTZ1QvdXk1ZE9PZi9SM0kreVFWaUc2N3ppQm9DQVUxWFdVaHVLZ2lo?= =?utf-8?B?Vy82NDdEM0MvVm9JV3ZFbWVaYXIvbVJMVGNDdVNQejRSNlNuZm1DNEhxSnJF?= =?utf-8?B?QU9lME11TzQvVWZWVDJzZXZnVnRONlUwUEFpdGVTQm5IdWQyNUhtLytkd1B3?= =?utf-8?B?TVo5OXpCMnJmRGFsNVZxMENhN2JFbHBnUllVbnB2SzRyOEkwVHpKNHRsa2dM?= =?utf-8?B?SmZLSTczSndMWWU2TVA0T0VidFBwTlVrOEM4bEhoRGRGKzRyZm42Y0RiQVM1?= =?utf-8?B?MWRZWHZ0KzVvbXIrUzBKUE9kQ1lDdTRHeVN1Y00rcnFOZ2RMVUdFb2k3SXN5?= =?utf-8?B?c1F3TFJoZkJaNWFuOXNmVTdNT1RjSWdBRGw0a0x4TFdTUjRpaDIyaERhRmdt?= =?utf-8?B?SmdvUEh3bTRqUnF3QTdYTngrcVUydlVQVWNEdzFKeEorT1VJb0hvRld5Y05M?= =?utf-8?B?UTNhQUdHTWZwOVpJVnEwbWJSQ0UxdkxBL2tQb1ovQTRmTFRhQUFPVy91clNq?= =?utf-8?B?RDlCWlg1TllCV2MwRncwNk04MXlpckhrVkJoUDFkYUM4bnpkK083UENDL0Mv?= =?utf-8?B?WHZZNnFxTWxCckdHSTl5TXhzRDc2MFQ1Yys5RU5lSUJicFFBSE5ldjNxT1ZM?= =?utf-8?B?NUF4bWpiVXFSYi9rUGJ3ZUljd2oxYkZoc3hkc01wYUtPeGFjRzJGL20vMXc5?= =?utf-8?B?amc2ZjdNR0RtNWJtOE1jTk9KOGREblBoZzlUWjhycDNnbm1LT29MMkRDNVli?= =?utf-8?B?cDRRbU1aY1hvd2FGdXVZcWhVUGpjSFJjNTllT3I0TWRMQS9IUUpBMUQ3TDRG?= =?utf-8?B?NTVNR1RrUlBCVDVXaFVKRXp6Rjh5Uk5JTktZcVM1YmV2Zjk0K0F2YzA4ZzJ1?= =?utf-8?B?dXpuaVYyS0lHQ0ZlRUowR0VzeWU2akNqUUd5b0lEem56Wlg0Q0ljREVPS0pT?= =?utf-8?B?SW9YZjA2YVVtQlRIVVB1eFhrclpudWxsT3V6a1VtN29XdDV1RnZVeE4rN2xZ?= =?utf-8?B?bnZBRUNSY01tS0NYVlRxR3l2anoxVEdDYnhjQnUveDNhYldjdUhMRlgwRW5K?= =?utf-8?B?UzNpMGN3dWNCMEE0VjI0YW5KLzV5MWs5Y0JOazlueng5b2pPTUIwTldrOHg0?= =?utf-8?B?SGs2YzVxbTdFM0dPZDl5V2dudFFZcEF2ZFRHa1JRdER2cytqZzFZa3J5NkJ3?= =?utf-8?B?dnJFOFZhY2J6R2FLOFFXS2syTlFudzY5Tjhsemo2cExYbGxRWHdRcHRHajdW?= =?utf-8?B?RFVMcmhld0pQYjBHNzdmQlVXZnZWMGx3dVdSMGRtZUZWUm5LM1Vuc3hSZkly?= =?utf-8?B?RmdyMy9WZmdjY0VUZmVDTkw1djl0TXBlSkx6SEJyQUxTc3dIK1pMK0t4NWlL?= =?utf-8?B?aE1PUHl2SVVrcEw4d0hkVmpJTnhtQUV1ZWNlS1VGYitYTG5lTldGRWdURmly?= =?utf-8?B?ajVlaHNJeXpZSDUyeVQzWnNuY1ZLMWt1MUFCQnVpTEwyLzMwTUpHOUphMzJp?= =?utf-8?B?alI2ZjB0U2ZURnlzdk5rKzI2TUNaT3JkaUZYak83SkdOcXVhZVhHUG5GL1Ns?= =?utf-8?B?QnNuR2xYbmFJV1gzS1BXeElDSGVFdmdVd3REckZVcmtWQjVmNUpFeVJZdzg2?= =?utf-8?B?MVc3YU5OZ0NCd0FIQkpuZmlvNjFqenNrRDdCdVpiS0tDYnZYc1NlWlFMMnI3?= =?utf-8?Q?zE7w/a9D3dv0sd/Ncy36SpkUv5qtDkUVLEXNUwg?= X-MS-Exchange-CrossTenant-Network-Message-Id: 65c9924d-4f62-4a87-8785-08d8dfb738d7 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2021 09:15:29.9937 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iLke7Y2YnKaZO1mhWARhITcJJs085BagzzNnOgbiz/Vtfv1IPDJUKj1mO5atWHYvIXp/5cePGyCorRGu3yApLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3674 X-OriginatorOrg: citrix.com On Fri, Mar 05, 2021 at 12:06:19AM +0000, Andrew Cooper wrote: > On 04/03/2021 14:47, Roger Pau Monne wrote: > > Introduce an option to allow selecting a less strict behaviour for > > rdmsr accesses targeting a MSR not explicitly handled by Xen. Since > > commit 84e848fd7a162f669 accesses to MSRs not explicitly handled by > > Xen result in the injection of a #GP to the guest. This is a behavior > > change since previously a #GP was only injected if accessing the MSR > > on the real hardware will also trigger a #GP. > > > > This commit attempts to offer a fallback option similar to the > > previous behavior. Note however that the value of the underlying MSR > > is never leaked to the guest, as the newly introduced option only > > changes whether a #GP is injected or not. > > > > Long term the plan is to properly handle all the MSRs, so the option > > introduced here should be considered a temporary resort for OSes that > > don't work properly with the new MSR policy. Any OS that requires this > > option to be enabled should be reported to > > xen-devel@lists.xenproject.org. > > > > Signed-off-by: Roger Pau Monné > > --- > > Changes since v1: > > - Only apply the option to HVM guests. > > - Only apply the special handling to MSR reads. > > - Sanitize the newly introduced flags field. > > - Print a warning message when the option is used. > > --- > > Cc: Boris Ostrovsky > > --- > > Boris, could you please test with Solaris to see if this fixes the > > issue? > > > > I wonder whether we need to to enable this option by default for > > guests being migrated from previous Xen versions? Maybe that's not > > required as the option is helpful mostly for early boot I would > > assume, afterwards an OS should already have the #GP handler setup > > when accessing MSRs. > > We know when building a domain whether it is a migrate or not, but don't > recall any version information existing at an appropriate point in the > migration stream to do this easily. > > We can buffer the stream forward and peek at the libxc domain header, > which does have the source hypervisor version, but that is going to be > very invasive to implement. I need to look at this more closely to have an opinion. Instead of figuring out if the source version is older maybe we could add something to the 4.15 stream in a suitable position to detect whether the source is new enough? > > > > From a release PoV the biggest risk would be breaking some of the > > existing MSR functionality. I think that's a necessary risk in order > > to offer such fallback option, or else we might discover after the > > release that guests that worked on Xen 4.14 don't work anymore in Xen > > 4.15. > > Much as I'd prefer not to have this, I agree with the sentiment that we > should have an "emergency undo" which people can use, and carry it for > at least a short while. > > However, to be useful for the purpose of unbreaking VMs, it must change > both the read and write behaviour, because both are potential > compatibility concerns (without reintroducing the information leak). I think I was confused here and assumed the previous behavior would check the written value to match the current underlying value before injecting a #GP. That's not the case. I can expand this patch to include the write side, I just thought having the rad side only would be enough to cover for the unhandled MSRs accesses. > > > --- > > docs/man/xl.cfg.5.pod.in | 17 +++++++++++++++++ > > tools/include/libxl.h | 8 ++++++++ > > tools/libs/light/libxl_types.idl | 2 ++ > > tools/libs/light/libxl_x86.c | 4 ++++ > > tools/xl/xl_parse.c | 7 +++++++ > > xen/arch/x86/domain.c | 10 ++++++++++ > > xen/arch/x86/hvm/svm/svm.c | 6 ++++++ > > xen/arch/x86/hvm/vmx/vmx.c | 7 +++++++ > > xen/include/asm-x86/hvm/domain.h | 3 +++ > > xen/include/public/arch-x86/xen.h | 8 ++++++++ > > This needs changes to the Ocaml bindings as well.  I guess I'll add that > to the todo list. Hm, would be better if someone else did those, as I don't know anything about Ocaml. I can try however in the next version, maybe it's trivial to add. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Mar 05 09:35:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 09:35:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93540.176479 (Exim 4.92) (envelope-from ) id 1lI6rG-0007RG-Bk; Fri, 05 Mar 2021 09:34:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93540.176479; Fri, 05 Mar 2021 09:34:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI6rG-0007R9-8X; Fri, 05 Mar 2021 09:34:54 +0000 Received: by outflank-mailman (input) for mailman id 93540; Fri, 05 Mar 2021 09:34:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI6rE-0007R2-UO for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 09:34:53 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 49635985-3d90-45b7-a5a0-30bb431fe37a; Fri, 05 Mar 2021 09:34:51 +0000 (UTC) Received: from pps.filterd (m0174682.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1259Ycjd007861; Fri, 5 Mar 2021 09:34:46 GMT Received: from eur05-am6-obe.outbound.protection.outlook.com (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by mx0b-0039f301.pphosted.com with ESMTP id 373fyugbah-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 05 Mar 2021 09:34:45 +0000 Received: from AM0PR03MB4372.eurprd03.prod.outlook.com (2603:10a6:208:cd::14) by AM4PR0302MB2738.eurprd03.prod.outlook.com (2603:10a6:200:8c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.19; Fri, 5 Mar 2021 09:31:03 +0000 Received: from AM0PR03MB4372.eurprd03.prod.outlook.com ([fe80::e5e8:38a0:1573:222c]) by AM0PR03MB4372.eurprd03.prod.outlook.com ([fe80::e5e8:38a0:1573:222c%5]) with mapi id 15.20.3890.029; Fri, 5 Mar 2021 09:31:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49635985-3d90-45b7-a5a0-30bb431fe37a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AX0qhKxyJzwEUPHHUfdELEo+hrjyalDHSmpbASzjfl9wm1LbX3WCrFTQYC5fYucacStthwqklAWvsepxd3A5BK/Wp/EPV5CxrKtUBP9yz6rnGUAYARud13OPptAS88f59HJcsNqEz0icakfShsNldhwrmFp1MpOOdyG3CxCO0QO3b2hUDIqhiOCn5QHjDhxMOfuAqBbKJgnTkUun1Et1p6igAW3qInIxBDTLAA3aa8fQKk3Ngf3hqN0C0NTxhBfi2eSLi2BWliqxsupNCfI7/CUWjURwWiCH3kkJh/P5kCRkYKkOjqWTHcJH7Av4ZlZY9M4ZARS3sHdt16wu0i2jCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QMBqWEWWYNRCX7em1yTs78D2mUBVX5lWHaH9h73/aug=; b=f3014upCBT8W6B5a4KcYDPJgC8ErQOOnEd/KbZ6mBC1wbD2n0CQ458ZU5ehnWLeeJblNPfHLvpZvnl3VNDDgqX4Jl7p7V7kC8HwD0EwwZbZpHwDj9xMybhm+3SOnnn+E2RjxVXgPMicXiKO38WcHLJUSXOiMOow77aN/QziG/rb5YIZ6pVcBtxK4qrsm806Yv1FvTLExJDJB5VXsCZdfhLCWDCILtP6BcYoArdMP0cxFZoweDnildMPq4PM4wQp2oVdxarK3EfDJr1QWjegvsZ9cd3NlkjIXxidY6qQAda6ckbemL1foU9AB4mSsaPppFgNywmIvalknjalhLL3K/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QMBqWEWWYNRCX7em1yTs78D2mUBVX5lWHaH9h73/aug=; b=h1dXIngMcGM835KOgaXSF/bJIhFpj8eLHYuHdRQLHf1xLULisEhSQh8FNCKw+mqGKsM4i4J5gHWQxWgpriivRk6dosSym4OJwy8qkHPl/Kv5mq4XGrb6eIBohhjsWoXZfY2Y2UdwERsQ/1svxFvmFomMxdrC5MgWsXhHjl+Tm3b94xD4sIs3QPjQJylB5rH8QCkqs+kpXIGX+xqmT4leTkRAt3T+/u1todvlxSp4sWGpg2R9N7octdTSY/l0mxwg0RPqUVOBs0VLpQJ08b7mlEruvhEPo9UkQDhg19NbP5xE0h5XF2JNSjufvxxI8JcmuTh9AmdOAdDZNDik66IN3g== From: Volodymyr Babchuk To: Andrew Cooper CC: Julien Grall , "xen-devel@lists.xenproject.org" , George Dunlap , Dario Faggioli , Meng Xu , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [RFC PATCH 00/10] Preemption in hypervisor (ARM only) Thread-Topic: [RFC PATCH 00/10] Preemption in hypervisor (ARM only) Thread-Index: AQHXCYx4A6OUUHr1gkqxWv1TEOLkuqplchSAgAAzdYCAAXE/AIAAtX0AgAAaNQCAABhvgIAAC3gAgADMQgCADFrIAA== Date: Fri, 5 Mar 2021 09:31:03 +0000 Message-ID: <87tupq9cbt.fsf@epam.com> References: <20210223023428.757694-1-volodymyr_babchuk@epam.com> <87zgzv56pm.fsf@epam.com> <87o8g99oal.fsf@epam.com> <87eeh59fwi.fsf@epam.com> <28f8ffcc-d2df-438c-4fa8-a8174d897109@citrix.com> <87a6rs9uq3.fsf@epam.com> In-Reply-To: <87a6rs9uq3.fsf@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.4.15; emacs 27.1 authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=epam.com; x-originating-ip: [176.36.48.175] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9ef5c8b1-49a2-4215-6f6f-08d8dfb96530 x-ms-traffictypediagnostic: AM4PR0302MB2738: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K5f7hoHXixkWR5cg/vVKuVdWCuxprorAQgn2byPvLIP+LSfEACCn9aPk9SGfzXFcxz9lQX8x8JHBtRXO5kXexfqhXTWe4BcTXUPTesVDKMCR+FD+/wpPslQKGhL5kYQHYyJiPICrUNsvXwqghxAUHxSPY/QksIrKNy4lgAi5LWZu92hW6Xtj0QOdF6YLDXNiEqyoMv3Hh28yQtmDUBf4lTfZArA30Lmc9sPlhTQBuDQEYpnBU0eNn1AIu77eshYBjZ50Xy3cqqSW/nnm0dEFDOhlTOcBMvX+F2bD03hxXmcjSS7SCbmHZvsgBK1ezgFUkJ47EPEl8BWxLQ7fOE4Tb4iRlrSppOEhRlvFiXjWa+Ue5rICs5N0Ii5aM1UkVUH2hqWt6WIOkWQwnViIrwhPYZUflEbIZA7VQ/Vcvn2uEzBd3/rpWFXJmwjdQp42AoTItPB/6/wVGejlpDMndiNl1eXYfUl9MKxOvOpB/w6uLrm6SpjIsZiS6GjOfAw4Ar/zsGfm9EivSRAITyLTHgCd3w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB4372.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(36756003)(5660300002)(4326008)(71200400001)(8676002)(8936002)(83380400001)(186003)(478600001)(26005)(54906003)(7416002)(6916009)(66446008)(86362001)(53546011)(2906002)(55236004)(76116006)(6486002)(66946007)(316002)(2616005)(64756008)(6506007)(66476007)(66556008)(6512007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?15XtGNwQ3Q4KN03S1KF0/R//RXX3X1H7VUtF1i/JgBcoMqWUz3MRWhgNMM?= =?iso-8859-1?Q?IhLn73rkc8lxtE4dK6yKRx34Y5q6JVxnmb3828ZTnLPvARGEzdnDPceGBm?= =?iso-8859-1?Q?TRlxwwhkbQZERdkjt3SwyNRw9vWSE8u8HX/ltWpv9+ivg4psJExXdk+AG5?= =?iso-8859-1?Q?p2sD4KiRUSaNVAJz4+iZTXOSyndckNTm3Rq/OtVkjaZZTcmW0RYZDP8U0Z?= =?iso-8859-1?Q?tuQOjwzOovAcgP/OJfB7yuVgp68ZXaIa715pH1mVbFu/aXyq3chP3Z1/ta?= =?iso-8859-1?Q?I///QE1IMbXMdFPlUR3SHZFrDlYKAhINkE/VIO0Co38R2+n3lNzBbFpbcR?= =?iso-8859-1?Q?U8eJc037YZun6vOcJrVWitHNxJEmVI6Rf71CUW27nrQZG7wXk6y3yBpEGP?= =?iso-8859-1?Q?63KeN8se0jl+GkofIylXVqEl2Qa1AexOxsxGLm9fBNA4P3sXKJnrZErQc3?= =?iso-8859-1?Q?KvQn12X1VjblavmOqr4gYSHWzzSM6N7Nm06tvC62qaNjK1gUH8eUZEQ//O?= =?iso-8859-1?Q?oIEHhSdD9gocsybYXU3bTC3pwZz0fm1jlxeowiaSuYAuwy6POMtTGf5rka?= =?iso-8859-1?Q?ksNECySRVq96f/py4INNYwMmMkBX4bq+G/aVqeYFthYFpHuLwn3iO/mjZa?= =?iso-8859-1?Q?0lQR4e/0S5kf3PPQY3NYzBn9dSji5aI4uL9Kytg60oy7sCrU9szRpRajS3?= =?iso-8859-1?Q?Z/QG+7ALFau6bY/t8a4gGsNxMvTgpf6LFtNHM1H8gLCvRi0+rmoN6giDLi?= =?iso-8859-1?Q?LJJgJ4J9eCzJRB+Z6k3zfO56wU/Rz4lQgEezORqidMCLb1hosEK1X1co7R?= =?iso-8859-1?Q?VmCgNplL7IUD0w8j0Rqz72FGCrp3X7s99IjAqyBzNQRVH2n4mEN5RoqwqC?= =?iso-8859-1?Q?6VSwfrubxHBLMggneNzQebrJeeWsmE6739h38O0Isc+YkOfkMeJRF6P6f2?= =?iso-8859-1?Q?jFaH7BMmMBHYLnZGQAsStyQvlIBIyy2pJFdQekEubYMkS9h6SYPqnBRVJu?= =?iso-8859-1?Q?MWV/aW69ucAZC2BQTSCsVH4gsSWAeS+nXpJ4Up3MkMgFNjF+JVp9cJdxbv?= =?iso-8859-1?Q?6Jp07YziZejW8MB43xwNtaG4GlklX3jegdlNKvvook8RhMbf5Ac7/ycePG?= =?iso-8859-1?Q?2F5MPQfTfBDvZwexyLmxMXjlXvvgFe1ph2RWBMraV/8qBBhpHCxHsgsQaN?= =?iso-8859-1?Q?QDgbxAKPPsWXa5uPHCicMrg2N/MCgcDJrkd6pqCfW+WecSHotipU/dDYuG?= =?iso-8859-1?Q?Bf0ZSlxPOXqByT+2S5ZyPuIeqqLo9KvEjH08s7UNSeWHGQd/CwTPwuDG6r?= =?iso-8859-1?Q?iqaNiWQ5WjafyTC950leEbkBoheZjGLukjOu4/j3X3mFFSvQOvtBwtIZQA?= =?iso-8859-1?Q?zKM7CohCmd?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB4372.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ef5c8b1-49a2-4215-6f6f-08d8dfb96530 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2021 09:31:03.1782 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /u+IddQATtN9QApbRfXd5OsOWXjt4xo7Pr7L/rfdzZ3F17Q2gXofAeenPvBEHdI0/s394aEhFHz9AuEmx4Idb2QelMchZufP2hmianJuLIU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0302MB2738 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 mlxlogscore=755 adultscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103050046 Hi, Volodymyr Babchuk writes: > Hi Andrew, > > Andrew Cooper writes: > >> On 24/02/2021 23:58, Volodymyr Babchuk wrote: >>> And I am not mentioning x86 support there... >> >> x86 uses per-pCPU stacks, not per-vCPU stacks. >> >> Transcribing from an old thread which happened in private as part of an >> XSA discussion, concerning the implications of trying to change this. >> >> ~Andrew >> >> -----8<----- >> >> Here is a partial list off the top of my head of the practical problems >> you're going to have to solve. >> >> Introduction of new SpectreRSB vulnerable gadgets. I'm really close to >> being able to drop RSB stuffing and recover some performance in Xen. >> >> CPL0 entrypoints need updating across schedule. SYSCALL entry would >> need to become a stub per vcpu, rather than the current stub per pcpu. >> This requires reintroducing a writeable mapping to the TSS (doable) and >> a shadow stack switch of active stacks (This corner case is so broken it >> looks to be a blocker for CET-SS support in Linux, and is resulting in >> some conversation about tweaking Shstk's in future processors). >> >> All per-cpu variables stop working. You'd need to rewrite Xen to use >> %gs for TLS which will have churn in the PV logic, and introduce the x86 >> architectural corner cases of running with an invalid %gs. Xen has been >> saved from a large number of privilege escalation vulnerabilities in >> common with Linux and Windows by the fact that we don't use %gs, so >> anyone trying to do this is going to have to come up with some concrete >> way of proving that the corner cases are covered. > > Thank you. This is exactly what I needed. I am not a big specialist in > x86, but from what I said, I can see that there is no easy way to switch > contexts while in hypervisor mode. > > Then I want to return to a task domain idea, which you mentioned in the > other thread. If I got it right, it would allow to > > 1. Implement asynchronous hypercalls for cases when there is no reason > to hold calling vCPU in hypervisor for the whole call duration > Okay, I was too overexcited there. I mean - surely it is possible to implement async hypercalls, but there is no immediate profit in this: such hypercall can't be preempted anyways. On a SMP system you can offload hypercall to another core, but that's basically all. > I skimmed through ML archives, but didn't found any discussion about it. Maybe you can give some hint how to find it? > As I see it, its implementation would be close to idle domain > implementation, but a little different. --=20 Volodymyr Babchuk at EPAM= From xen-devel-bounces@lists.xenproject.org Fri Mar 05 09:43:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 09:43:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93547.176490 (Exim 4.92) (envelope-from ) id 1lI6zv-0008Ty-7E; Fri, 05 Mar 2021 09:43:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93547.176490; Fri, 05 Mar 2021 09:43:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI6zv-0008Tr-49; Fri, 05 Mar 2021 09:43:51 +0000 Received: by outflank-mailman (input) for mailman id 93547; Fri, 05 Mar 2021 09:43:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI6zt-0008Tm-Hu for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 09:43:49 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3bba016d-431e-40b1-a5ea-bbb28c462f9a; Fri, 05 Mar 2021 09:43:48 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DF80AAC54; Fri, 5 Mar 2021 09:43:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3bba016d-431e-40b1-a5ea-bbb28c462f9a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614937428; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kp70BljORx7nBpfqdLEHZzzKMKQGsMpWt26fzlCub88=; b=nhVt5EvVTTX/gbT0dfHucX1mw9rM+f+XpBMcIIkof+JDqDwLrc1JiKR86aat1zAJALKGEx tbIWU7X8oW5zzyla3MYUjON9qxO5T5WNIJMnF4GsulsdDI7fpCF8SA0lCuP03OSrLGXN3U YdlKdZLJguQJwV5UVSVbl9NjS7ZRPPc= To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson From: Jan Beulich Subject: [PATCH v2 0/2][4.15] x86: guest MSR access handling tweaks Message-ID: Date: Fri, 5 Mar 2021 10:43:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit The first patch was stripped of its WRMSR adjustments, albeit I'm not convinced we'll get away with this - see there. v2 there also addresses further comments. The 2nd patch is new here, but the need for something like this was mentioned in v1 already. 1: PV: conditionally avoid raising #GP for early guest MSR reads 2: AMD: expose HWCR.TscFreqSel to guests Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 05 09:50:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 09:50:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93550.176503 (Exim 4.92) (envelope-from ) id 1lI76T-000130-Uf; Fri, 05 Mar 2021 09:50:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93550.176503; Fri, 05 Mar 2021 09:50:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI76T-00012t-Rc; Fri, 05 Mar 2021 09:50:37 +0000 Received: by outflank-mailman (input) for mailman id 93550; Fri, 05 Mar 2021 09:50:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI76S-00012Y-FA for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 09:50:36 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ce551b54-da3f-4b04-b17a-3ff2d3a02bd2; Fri, 05 Mar 2021 09:50:35 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4B058AD2B; Fri, 5 Mar 2021 09:50:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce551b54-da3f-4b04-b17a-3ff2d3a02bd2 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614937834; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rbp0ZeIs23as1aSnoDDNOra/cmQasCaFDr5FahgqHRA=; b=XisvG7VddzkHwQEWLGbNbccD2tZvfvbco3mvOAkUIG2iVdxwB/+FZrtW6KLPbdzqwXtbIT r2DbWmY7RT1ONJg6B3KKI57NFSoCJHYqArXX3jjNjnLSPTOLqNkRKioAuwRoFJxfSfBg/r 7ybUj9DDgvnW702WJsJq4i+eUkS5UQE= Subject: [PATCH v2 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: Message-ID: Date: Fri, 5 Mar 2021 10:50:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Prior to 4.15 Linux, when running in PV mode, did not install a #GP handler early enough to cover for example the rdmsrl_safe() of MSR_K8_TSEG_ADDR in bsp_init_amd() (not to speak of the unguarded read of MSR_K7_HWCR later in the same function). The respective change (42b3a4cb5609 "x86/xen: Support early interrupts in xen pv guests") was backported to 4.14, but no further - presumably since it wasn't really easy because of other dependencies. Therefore, to prevent our change in the handling of guest MSR accesses to render PV Linux 4.13 and older unusable on at least AMD systems, make the raising of #GP on this paths conditional upon the guest having installed a handler, provided of course the MSR can be read in the first place (we would have raised #GP in that case even before). Producing zero for reads isn't necessarily correct and may trip code trying to detect presence of MSRs early, but since such detection logic won't work without a #GP handler anyway, this ought to be a fair workaround. Signed-off-by: Jan Beulich --- v2: Probe MSR read. Exclude hypervisor range. Avoid issuing two log messages (in debug builds). Don't alter WRMSR behavior. --- I'm not convinced we can get away without also making the WRMSR path somewhat more permissive again, e.g. tolerating attempts to set bits which are already set. But of course this would require keeping in sync for which MSRs we "fake" reads, as then a kernel attempt to set a bit may also appear as an attempt to clear others (because of the zero value that we gave it for the read). --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -874,7 +874,7 @@ static int read_msr(unsigned int reg, ui struct vcpu *curr = current; const struct domain *currd = curr->domain; const struct cpuid_policy *cp = currd->arch.cpuid; - bool vpmu_msr = false; + bool vpmu_msr = false, warn = false; int ret; if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) @@ -882,7 +882,7 @@ static int read_msr(unsigned int reg, ui if ( ret == X86EMUL_EXCEPTION ) x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); - return ret; + goto done; } switch ( reg ) @@ -986,7 +986,7 @@ static int read_msr(unsigned int reg, ui } /* fall through */ default: - gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); + warn = true; break; normal: @@ -995,7 +995,19 @@ static int read_msr(unsigned int reg, ui return X86EMUL_OKAY; } - return X86EMUL_UNHANDLEABLE; + done: + if ( ret != X86EMUL_OKAY && !curr->arch.pv.trap_ctxt[X86_EXC_GP].address && + (reg >> 16) != 0x4000 && !rdmsr_safe(reg, *val) ) + { + gprintk(XENLOG_WARNING, "faking RDMSR 0x%08x\n", reg); + *val = 0; + x86_emul_reset_event(ctxt); + ret = X86EMUL_OKAY; + } + else if ( warn ) + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); + + return ret; } static int write_msr(unsigned int reg, uint64_t val, From xen-devel-bounces@lists.xenproject.org Fri Mar 05 09:50:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 09:50:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93552.176515 (Exim 4.92) (envelope-from ) id 1lI76n-000185-An; Fri, 05 Mar 2021 09:50:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93552.176515; Fri, 05 Mar 2021 09:50:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI76n-00017y-7l; Fri, 05 Mar 2021 09:50:57 +0000 Received: by outflank-mailman (input) for mailman id 93552; Fri, 05 Mar 2021 09:50:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI76m-00017n-EE for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 09:50:56 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 64d0340a-96d8-40c6-ad1f-325e59c9d747; Fri, 05 Mar 2021 09:50:55 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AFC80AC54; Fri, 5 Mar 2021 09:50:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64d0340a-96d8-40c6-ad1f-325e59c9d747 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614937854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oVKZh3/uSm8Vy987gAiUz/PvmulFvmzd8DFcMeXDKGs=; b=e21orVpX69D7jTX+qIfU6PX6lNvENMOiZFA7ZoLY9XmkYAjL7yCfFbFCVKU5PdAgpnTv0C dreT/pwo4nSEK2beUWLl5SDmW3n1vpgZmygumBC25+kqw1S8alzHZGSHp0luEls4IaQDzz 9fRy+baDOQCn5G/a3hV4giGXMduaCGY= Subject: [PATCH v2 2/2][4.15] x86/AMD: expose HWCR.TscFreqSel to guests From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: Message-ID: Date: Fri, 5 Mar 2021 10:50:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Linux has been warning ("firmware bug") about this bit being clear for a long time. While writable in older hardware it has been readonly on more than just most recent hardware. For simplicitly report it always set (if anything we may want to log the issue ourselves if it turns out to be clear on older hardware). Signed-off-by: Jan Beulich --- v2: New. --- There are likely more bits worthwhile to expose, but for about every one of them there would be the risk of a lengthy discussion, as there are clear downsides to exposing such information, the more that it would be tbd whether the hardware values should be surfaced, and if so what should happen when the guest gets migrated. The main risk with making the read not fault here is that guests might imply they can also write this MSR then. --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -315,6 +315,12 @@ int guest_rdmsr(struct vcpu *v, uint32_t *val = msrs->tsc_aux; break; + case MSR_K8_HWCR: + if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) + goto gp_fault; + *val = K8_HWCR_TSC_FREQ_SEL; + break; + case MSR_AMD64_DE_CFG: if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) goto gp_fault; --- a/xen/include/asm-x86/msr-index.h +++ b/xen/include/asm-x86/msr-index.h @@ -287,6 +287,8 @@ #define MSR_K7_HWCR 0xc0010015 #define MSR_K8_HWCR 0xc0010015 +#define K8_HWCR_TSC_FREQ_SEL (1ULL << 24) + #define MSR_K7_FID_VID_CTL 0xc0010041 #define MSR_K7_FID_VID_STATUS 0xc0010042 #define MSR_K8_PSTATE_LIMIT 0xc0010061 From xen-devel-bounces@lists.xenproject.org Fri Mar 05 10:26:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 10:26:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93598.176542 (Exim 4.92) (envelope-from ) id 1lI7fT-0004NE-D7; Fri, 05 Mar 2021 10:26:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93598.176542; Fri, 05 Mar 2021 10:26:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI7fT-0004N7-AD; Fri, 05 Mar 2021 10:26:47 +0000 Received: by outflank-mailman (input) for mailman id 93598; Fri, 05 Mar 2021 10:26:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI7fR-0004N2-8X for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 10:26:45 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 53cbc71e-dcfc-441e-af64-5c50e148d4ef; Fri, 05 Mar 2021 10:26:44 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2DF96AE6E; Fri, 5 Mar 2021 10:26:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53cbc71e-dcfc-441e-af64-5c50e148d4ef X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614940003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n+mlQsaxEZwAIkPVkyrnBX0ue2JX7Y/gWQgsNuZQEVc=; b=djpaAAFCHn0MArDpsA9URP1QFap4al8dObjCkNyob4AmsW3V7hKW9mSHLxO1oqIIdBuG76 LKIB3k/cP6ElFFfCDWOXNQmRODP16AQdwt9ZlYb/UzRJqz+JGsxhqVvVo/7opqj5wKQsAo JRe/49AVrVe1Ln7ekY3YlSFBzJjLiVY= Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Andrew Cooper , Jun Nakajima , Kevin Tian , Boris Ostrovsky , Ian Jackson References: <20210304144755.35891-1-roger.pau@citrix.com> <24640.62938.427877.757656@mariner.uk.xensource.com> <24640.64194.445736.52546@mariner.uk.xensource.com> <24641.5419.379341.215528@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <5d26997f-6ec6-00f2-3224-b079c1a2b9f4@suse.com> Date: Fri, 5 Mar 2021 11:26:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 04.03.2021 18:43, Roger Pau Monné wrote: > One option we could go for is making this behavior depend on Kconfig: > enable strict MSR policy for debug builds and fallback to the > 'relaxed' one for non-debug builds. That might get us some more data, > but again I fear most people out there will run non-debug builds > anyway. Plus of course we'd almost never test the "relaxed" code path(s). Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 05 10:36:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 10:36:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93615.176562 (Exim 4.92) (envelope-from ) id 1lI7oL-0005RT-C7; Fri, 05 Mar 2021 10:35:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93615.176562; Fri, 05 Mar 2021 10:35:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI7oL-0005RM-91; Fri, 05 Mar 2021 10:35:57 +0000 Received: by outflank-mailman (input) for mailman id 93615; Fri, 05 Mar 2021 10:35:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI7oJ-0005RH-Qq for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 10:35:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4ccef588-6c02-42e0-9dd0-2e246beba10e; Fri, 05 Mar 2021 10:35:55 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 116F8AC54; Fri, 5 Mar 2021 10:35:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ccef588-6c02-42e0-9dd0-2e246beba10e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614940554; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R09jOA2PM3Wd5x+6RaZQyLd9dqmNo7T6Vj0dK1AMmoA=; b=PJkSwPA4Omd4bejsaCDehcJQW9+vaZwm05KGC5oQVyjTpbZ8tv5dNDqmKMp0K1rVmTM18+ ufMHkif9gZbTLzE1Zr09iHgzs+C+8Y1MORHW6ypKYMfjx88YAUcOn2LDjhP0vs4x3dqz0l siXSTOwtsROYAAwLoCGxuRNyuOHM0NQ= Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu , Anthony PERARD , Jun Nakajima , Kevin Tian , Boris Ostrovsky , Andrew Cooper References: <20210304144755.35891-1-roger.pau@citrix.com> <4cb7e1f3-0593-6d06-281a-e3bf06843221@citrix.com> From: Jan Beulich Message-ID: <4353ffce-52ae-ec7f-01cb-57b24618eed0@suse.com> Date: Fri, 5 Mar 2021 11:35:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 05.03.2021 10:15, Roger Pau Monné wrote: > On Fri, Mar 05, 2021 at 12:06:19AM +0000, Andrew Cooper wrote: >> On 04/03/2021 14:47, Roger Pau Monne wrote: >>> From a release PoV the biggest risk would be breaking some of the >>> existing MSR functionality. I think that's a necessary risk in order >>> to offer such fallback option, or else we might discover after the >>> release that guests that worked on Xen 4.14 don't work anymore in Xen >>> 4.15. >> >> Much as I'd prefer not to have this, I agree with the sentiment that we >> should have an "emergency undo" which people can use, and carry it for >> at least a short while. >> >> However, to be useful for the purpose of unbreaking VMs, it must change >> both the read and write behaviour, because both are potential >> compatibility concerns (without reintroducing the information leak). > > I think I was confused here and assumed the previous behavior would > check the written value to match the current underlying value before > injecting a #GP. That's not the case. > > I can expand this patch to include the write side, I just thought > having the rad side only would be enough to cover for the unhandled > MSRs accesses. Both when seeing this patch's title and when ripping the write part out of my patch I meant to indicate the same - dealing with just reads may not be enough. Arguably people could be told to first try with just relaxing rdmsr handling, but ones anxious to get their VMs back into production use may ignore such an advice and use the bigger hammer right away. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 05 10:53:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 10:53:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93626.176579 (Exim 4.92) (envelope-from ) id 1lI85J-0007QW-Vc; Fri, 05 Mar 2021 10:53:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93626.176579; Fri, 05 Mar 2021 10:53:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI85J-0007QP-Rn; Fri, 05 Mar 2021 10:53:29 +0000 Received: by outflank-mailman (input) for mailman id 93626; Fri, 05 Mar 2021 10:53:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI85I-0007QK-HK for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 10:53:28 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a4c4fc5f-9a99-4889-90d0-13ed3560e1a2; Fri, 05 Mar 2021 10:53:27 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B6388AEB3; Fri, 5 Mar 2021 10:53:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4c4fc5f-9a99-4889-90d0-13ed3560e1a2 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614941606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t9yhPDURsr1qBZgJ3eTwq5iF3yZRze/MqoqPnLfQxQg=; b=b3d6Inoy4CO1P5Iu4Pgi7Sllh2M+TW/Q+sz8yJT073httTuYXhL0owKskdvCbqMI5LAj1K 1mPZ0sHBrwgsMRGlmRsAzsZmzPWeWvFrir3JjKnWnezlPdebWzNnA8tFJoLp46lm6O4iwr dxYLVmL/drdmxxNTJcRHP+PnYRiR/3c= Subject: Re: [PATCH v3 2/8] xen/events: don't unmask an event channel when an eoi is pending To: Ross Lagerwall , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Boris Ostrovsky , Stefano Stabellini , stable@vger.kernel.org, Julien Grall References: <20210219154030.10892-1-jgross@suse.com> <20210219154030.10892-3-jgross@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Fri, 5 Mar 2021 11:53:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vGgwMX0OVBhr9spvhVf2Y8thFVRPVW5Yi" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vGgwMX0OVBhr9spvhVf2Y8thFVRPVW5Yi Content-Type: multipart/mixed; boundary="5IJGrGLpJ892MRBD4wVWZEDLWV7f7e1BF"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Ross Lagerwall , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Boris Ostrovsky , Stefano Stabellini , stable@vger.kernel.org, Julien Grall Message-ID: Subject: Re: [PATCH v3 2/8] xen/events: don't unmask an event channel when an eoi is pending References: <20210219154030.10892-1-jgross@suse.com> <20210219154030.10892-3-jgross@suse.com> In-Reply-To: --5IJGrGLpJ892MRBD4wVWZEDLWV7f7e1BF Content-Type: multipart/mixed; boundary="------------E52438B6194F302B7C9C960C" Content-Language: en-US This is a multi-part message in MIME format. --------------E52438B6194F302B7C9C960C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 23.02.21 10:26, Ross Lagerwall wrote: > On 2021-02-19 15:40, Juergen Gross wrote: >> An event channel should be kept masked when an eoi is pending for it. >> When being migrated to another cpu it might be unmasked, though. >> >> In order to avoid this keep three different flags for each event chann= el >> to be able to distinguish "normal" masking/unmasking from eoi related >> masking/unmasking and temporary masking. The event channel should only= >> be able to generate an interrupt if all flags are cleared. >> >> Cc: stable@vger.kernel.org >> Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn fra= mework") >> Reported-by: Julien Grall >> Signed-off-by: Juergen Gross >=20 > I tested this patch series backported to a 4.19 kernel and found that > when doing a reboot loop of Windows with PV drivers, occasionally it wi= ll > end up in a state with some event channels pending and masked in dom0 > which breaks networking in the guest. >=20 > The issue seems to have been introduced with this patch, though at firs= t > glance it appears correct. I haven't yet looked into why it is happenin= g. > Have you seen anything like this with this patch? Sorry it took so long, but now I was able to look into this issue. I have managed to reproduce it with a pv Linux guest. I'm now adding some debug code to understand what is happening there. Juergen --------------E52438B6194F302B7C9C960C Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------E52438B6194F302B7C9C960C-- --5IJGrGLpJ892MRBD4wVWZEDLWV7f7e1BF-- --vGgwMX0OVBhr9spvhVf2Y8thFVRPVW5Yi Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBCDaUFAwAAAAAACgkQsN6d1ii/Ey9K lwgAmY0h0J7CF5hcFbKq0wA7XThfwQpzDiWzJ2fqKFB8fjbKcGNROqswr98QdoMkXGfGnfmBiIGH FFbFI8EP7Y1BjMlzgaIHPW32R7IFUu0UXqCGwLcJkv5alL4WhTGn6P9HGRNgBrQHcgL0TdrOC6xX glQhb86O45ZVSZvoDDa15VCzcxopfUxX04GYSwyd+30llU84wJSgqT39Z5a5vpWTkVMgeYzXVnTd +RcYQCyHiTnOcZhFT2DDhumxnWDaAZZnbOn06B2Le3P5A89F4KJpPleggYH3Fyn7TdabgE3XR4CT hrUq+9v34BjDOxt2I84T0y/yPt+/cYyK9nGntewDyQ== =TU82 -----END PGP SIGNATURE----- --vGgwMX0OVBhr9spvhVf2Y8thFVRPVW5Yi-- From xen-devel-bounces@lists.xenproject.org Fri Mar 05 10:56:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 10:56:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93629.176590 (Exim 4.92) (envelope-from ) id 1lI88K-0007a2-DN; Fri, 05 Mar 2021 10:56:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93629.176590; Fri, 05 Mar 2021 10:56:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI88K-0007Zv-AN; Fri, 05 Mar 2021 10:56:36 +0000 Received: by outflank-mailman (input) for mailman id 93629; Fri, 05 Mar 2021 10:56:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI88I-0007Zq-P7 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 10:56:34 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4d06de77-6b4e-428a-bd59-ac21c3bf37cc; Fri, 05 Mar 2021 10:56:34 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4E11BAEB3; Fri, 5 Mar 2021 10:56:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d06de77-6b4e-428a-bd59-ac21c3bf37cc X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614941793; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/W3UtJWOjRrTeKK5wk4/2/Gl3MyHMnhevMBiZarEcGk=; b=AjcTipQLyiPI/l8cdUc37pEjNUD4cVAcooawzpxN5s8uaUMQztwdatruXS7GdU6KbUu1Iz RB8BhBvC6mr4qTrtzRz+r6mntMHqLrkjP1Bs5DB+CtD4/ijkA3YV+vRfotx5dCIrpI9jAK 9ah5PhxOFtr9MrMCknfa+7X/2McLRNk= Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior To: Roger Pau Monne Cc: Ian Jackson , Wei Liu , Anthony PERARD , Andrew Cooper , Jun Nakajima , Kevin Tian , Boris Ostrovsky , xen-devel@lists.xenproject.org References: <20210304144755.35891-1-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Fri, 5 Mar 2021 11:56:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210304144755.35891-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04.03.2021 15:47, Roger Pau Monne wrote: > Introduce an option to allow selecting a less strict behaviour for > rdmsr accesses targeting a MSR not explicitly handled by Xen. Since > commit 84e848fd7a162f669 accesses to MSRs not explicitly handled by > Xen result in the injection of a #GP to the guest. This is a behavior > change since previously a #GP was only injected if accessing the MSR > on the real hardware will also trigger a #GP. > > This commit attempts to offer a fallback option similar to the > previous behavior. Note however that the value of the underlying MSR > is never leaked to the guest, as the newly introduced option only > changes whether a #GP is injected or not. > > Long term the plan is to properly handle all the MSRs, so the option > introduced here should be considered a temporary resort for OSes that > don't work properly with the new MSR policy. Any OS that requires this > option to be enabled should be reported to > xen-devel@lists.xenproject.org. While the title says this is limited to HVM guests, I have to admit that I fail to see why this is, and hence I would have hoped for some clarification in the description. In particular I don't think my "guest in early boot" workaround, of which I posted v2 earlier today, can be assumed to be enough in the longer run. Recall that it relaxes behavior only when the guest didn't install a handler for #GP yet - this means it wouldn't help with any unguarded RDMSR the guest might issue later, with a handler already installed. > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -760,6 +760,13 @@ int arch_domain_create(struct domain *d, > d->domain_id); > } > > + if ( config->arch.domain_flags & ~XEN_X86_RDMSR_RELAXED ) > + { > + printk(XENLOG_G_ERR "d%d: Invalid arch domain flags: %#x\n", > + d->domain_id, config->arch.domain_flags); > + return -EINVAL; > + } This would look to better go into arch_sanitise_domain_config(). And if the flag remains HVM-only, that aspect should then also be checked (i.e. the flag being set would then also need rejecting for PV guests). > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -1795,6 +1795,7 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) > const struct domain *d = v->domain; > struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; > const struct nestedsvm *nsvm = &vcpu_nestedsvm(v); > + uint64_t tmp; > > switch ( msr ) > { > @@ -1965,6 +1966,11 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) > break; > > default: > + if ( d->arch.hvm.rdmsr_relaxed && !rdmsr_safe(msr, tmp) ) > + { > + *msr_content = 0; > + break; > + } You don't really need "tmp" here, do you? You could as well read into *msr_content, as you're zapping the value afterwards anyway. > --- a/xen/include/asm-x86/hvm/domain.h > +++ b/xen/include/asm-x86/hvm/domain.h > @@ -122,6 +122,9 @@ struct hvm_domain { > > bool_t is_s3_suspended; > > + /* Don't unconditionally inject #GP for unhandled MSRs reads. */ > + bool rdmsr_relaxed; If, again, this is to remain HVM-only, then you insertion wants to honor the blank padding other field decls use. I'd also like to ask for your insertion to be moved up a few lines, to after "is_in_uc_mode". I have a patch queued already to also move "is_s3_suspended" into that hole; it's from November last year, so it looks like I simply forgot to post it. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 05 11:06:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 11:06:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93633.176602 (Exim 4.92) (envelope-from ) id 1lI8Hv-0000DO-Bk; Fri, 05 Mar 2021 11:06:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93633.176602; Fri, 05 Mar 2021 11:06:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI8Hv-0000DH-8V; Fri, 05 Mar 2021 11:06:31 +0000 Received: by outflank-mailman (input) for mailman id 93633; Fri, 05 Mar 2021 11:06:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI8Ht-0000DC-OA for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 11:06:29 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5fbf8a5c-4fde-4392-af05-8784c05dde33; Fri, 05 Mar 2021 11:06:29 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3CB18AE6E; Fri, 5 Mar 2021 11:06:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5fbf8a5c-4fde-4392-af05-8784c05dde33 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614942388; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p94vtB7FKC31ddClYAOCM9e6725Ol9Iweze/itf8DCk=; b=uQw/ACgnxSP7XRpuZHm9zEad3Ere7xruP3aB/DwGvnheXrM1XX4ETrgzjkQEHXAbMjsbtZ Ll3VQmwwCukLgpZ05+//25XloK7DPpOyCEAPssucncxowRkqudo+gomFxyN2Zr8b0Osbhp hG+OFWNgs2+jXgJH+LINesTGIo6HGtE= Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior From: Jan Beulich To: Roger Pau Monne Cc: Ian Jackson , Wei Liu , Anthony PERARD , Andrew Cooper , Jun Nakajima , Kevin Tian , Boris Ostrovsky , xen-devel@lists.xenproject.org References: <20210304144755.35891-1-roger.pau@citrix.com> Message-ID: <94338621-9068-8376-c810-0fe1a9c8f3e0@suse.com> Date: Fri, 5 Mar 2021 12:06:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05.03.2021 11:56, Jan Beulich wrote: > On 04.03.2021 15:47, Roger Pau Monne wrote: >> --- a/xen/arch/x86/hvm/svm/svm.c >> +++ b/xen/arch/x86/hvm/svm/svm.c >> @@ -1795,6 +1795,7 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) >> const struct domain *d = v->domain; >> struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; >> const struct nestedsvm *nsvm = &vcpu_nestedsvm(v); >> + uint64_t tmp; >> >> switch ( msr ) >> { >> @@ -1965,6 +1966,11 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) >> break; >> >> default: >> + if ( d->arch.hvm.rdmsr_relaxed && !rdmsr_safe(msr, tmp) ) >> + { >> + *msr_content = 0; >> + break; >> + } > > You don't really need "tmp" here, do you? You could as well read > into *msr_content, as you're zapping the value afterwards anyway. Actually, while perhaps indeed not strictly needed, it allows the compiler to produce better code, as it'll be able to recognize the value doesn't need writing to memory on any path. I guess I'll change the logic in my related patch along these lines then. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 05 12:10:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 12:10:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93649.176615 (Exim 4.92) (envelope-from ) id 1lI9Hu-0006s2-Fo; Fri, 05 Mar 2021 12:10:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93649.176615; Fri, 05 Mar 2021 12:10:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9Hu-0006rv-CJ; Fri, 05 Mar 2021 12:10:34 +0000 Received: by outflank-mailman (input) for mailman id 93649; Fri, 05 Mar 2021 12:10:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9Ht-0006ro-HI for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 12:10:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9Ht-0005IS-0Y; Fri, 05 Mar 2021 12:10:33 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lI9Hs-0005Ic-Jw; Fri, 05 Mar 2021 12:10:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=AkU/ANV9klxVdLN7G3kMf/GAXYSfZF8V6M9T6Dtmmvg=; b=sDlT0iBjxSNh9clhBwQph5ueUl tOwpM7MHbN1AOlrMRJ6ifZ17u6OPX8qrpA576AFWwp762E0/5/rZ1RB5Fv8p/YjvpwjpRXOM4p6Kp tBJSSipL/3U90eHb+qg9jCq9K12+1knS6fdYgutz+sMhecx3MJ4Wo+yBofobltj5X3Vw=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall Subject: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters Date: Fri, 5 Mar 2021 12:10:29 +0000 Message-Id: <20210305121029.7047-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall The longest possible command line for LiveUpdate is: liveupdate -s -t -F This is 5 parameters. However, the maximum is currently specified to 4. This means the some of the parameters will get ignored. Update the field max_pars to 5 so and admin can specify the timeout and force at the same time. Signed-off-by: Julien Grall --- This is a candidate for Xen 4.15. Without it, it would not be possible to pass -F and -t together. The change is only modifying behavior for XenStored LiveUpdate. --- tools/xenstore/xenstored_control.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index a1652219b247..8e470f2b2056 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -768,7 +768,7 @@ static struct cmd_s cmds[] = { */ { "live-update", do_control_lu, "[-c ] [-F] [-t ] \n" - " Default timeout is 60 seconds.", 4 }, + " Default timeout is 60 seconds.", 5 }, #endif #ifdef __MINIOS__ { "memreport", do_control_memreport, "" }, -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Mar 05 12:40:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 12:40:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93654.176644 (Exim 4.92) (envelope-from ) id 1lI9kb-0001W0-6O; Fri, 05 Mar 2021 12:40:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93654.176644; Fri, 05 Mar 2021 12:40:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9kb-0001Vt-17; Fri, 05 Mar 2021 12:40:13 +0000 Received: by outflank-mailman (input) for mailman id 93654; Fri, 05 Mar 2021 12:40:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9kZ-0001Ur-A5 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 12:40:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9kY-0005oV-0x; Fri, 05 Mar 2021 12:40:10 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lI9kX-0007BR-MZ; Fri, 05 Mar 2021 12:40:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=1fsPk6D4wrcBPoTOXONkzXRSuL3h5zuch3BSAYZOrp8=; b=ApSrvFI9sufdhxLqbxGeZuvSQ BMymlkbopaVI45dmFQqE+tEEdfPSYXsGsEQhaNXdv3wLAsqrdYgbC+mdcYJcOBGvlPgokuF2X8dzF c3gCIIbykQJjYGHl16iEgyyx8dOH0CW+t5r9TMwIdNqXsahgKuGejZewaDIz0qFYiRrVE=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , Juergen Gross Subject: [PATCH for-4.15 1/2] tools/xenstore: Consolidate PRINTF_ATTRIBUTE() in utils.h Date: Fri, 5 Mar 2021 12:40:02 +0000 Message-Id: <20210305124003.13582-2-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210305124003.13582-1-julien@xen.org> References: <20210305124003.13582-1-julien@xen.org> From: Julien Grall At the moment PRINTF_ATTRIBUTE() is defined in two places: - tdb.h: Defined as a NOP - talloc.h: Defined as a NOP for GCC older than 3.0 otherwise will add the attribute to check the printf format Xen requires to build with minimum GCC 4.1 and we want to check the printf format for all the printf-like functions. Only implement PRINTF_ATTRIBUTE() once in utils.h and drop the conditional check for GCC < 3.0. Signed-off-by: Julien Grall --- tools/xenstore/talloc.h | 15 ++------------- tools/xenstore/tdb.h | 6 ++---- tools/xenstore/utils.h | 2 ++ 3 files changed, 6 insertions(+), 17 deletions(-) diff --git a/tools/xenstore/talloc.h b/tools/xenstore/talloc.h index 71a36e7be06b..a0f4bff25788 100644 --- a/tools/xenstore/talloc.h +++ b/tools/xenstore/talloc.h @@ -26,6 +26,8 @@ #include +#include "utils.h" + /* this is only needed for compatibility with the old talloc */ typedef void TALLOC_CTX; @@ -84,19 +86,6 @@ typedef void TALLOC_CTX; #define talloc_destroy(ctx) talloc_free(ctx) #endif -#ifndef PRINTF_ATTRIBUTE -#if (__GNUC__ >= 3) -/** Use gcc attribute to check printf fns. a1 is the 1-based index of - * the parameter containing the format, and a2 the index of the first - * argument. Note that some gcc 2.x versions don't handle this - * properly **/ -#define PRINTF_ATTRIBUTE(a1, a2) __attribute__ ((format (__printf__, a1, a2))) -#else -#define PRINTF_ATTRIBUTE(a1, a2) -#endif -#endif - - /* The following definitions come from talloc.c */ void *_talloc(const void *context, size_t size); void talloc_set_destructor(const void *ptr, int (*destructor)(void *)); diff --git a/tools/xenstore/tdb.h b/tools/xenstore/tdb.h index 557cf727b869..ce3c7339f884 100644 --- a/tools/xenstore/tdb.h +++ b/tools/xenstore/tdb.h @@ -1,6 +1,8 @@ #ifndef __TDB_H__ #define __TDB_H__ +#include "utils.h" + /* Unix SMB/CIFS implementation. @@ -84,10 +86,6 @@ struct tdb_traverse_lock { uint32_t hash; }; -#ifndef PRINTF_ATTRIBUTE -#define PRINTF_ATTRIBUTE(a,b) -#endif - /* this is the context structure that is returned from a db open */ typedef struct tdb_context { char *name; /* the name of the database */ diff --git a/tools/xenstore/utils.h b/tools/xenstore/utils.h index df1cb9a3bac6..3dfb96b556dd 100644 --- a/tools/xenstore/utils.h +++ b/tools/xenstore/utils.h @@ -27,6 +27,8 @@ static inline bool strends(const char *a, const char *b) */ const char *dump_state_align(FILE *fp); +#define PRINTF_ATTRIBUTE(a1, a2) __attribute__((format (printf, a1, a2))) + void barf(const char *fmt, ...) __attribute__((noreturn)); void barf_perror(const char *fmt, ...) __attribute__((noreturn)); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Mar 05 12:40:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 12:40:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93655.176651 (Exim 4.92) (envelope-from ) id 1lI9kb-0001WT-HZ; Fri, 05 Mar 2021 12:40:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93655.176651; Fri, 05 Mar 2021 12:40:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9kb-0001WI-9S; Fri, 05 Mar 2021 12:40:13 +0000 Received: by outflank-mailman (input) for mailman id 93655; Fri, 05 Mar 2021 12:40:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9kZ-0001VA-TJ for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 12:40:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9kZ-0005oc-33; Fri, 05 Mar 2021 12:40:11 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lI9kY-0007BR-QY; Fri, 05 Mar 2021 12:40:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=wgkPNlXJWVNMPnSNmMg4BKeKpos8YR2z8Sau5csS4go=; b=hZJiT82GJ4XAGywHUbOpzJ8d/ raRb+SgQxUEVgzL4kYrkDYqdFjzLagB5dm0/0TpOrAjUC2IvHm16U7FjHnKSmH8Y1upkfEyUC1mWP apJ0RjMBZBuxUE+jEhyUM+HJPp6LXX4mkhwDaeRS/TttOqPCyS880ZY77t71eHUsmat8Y=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , Juergen Gross Subject: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() Date: Fri, 5 Mar 2021 12:40:03 +0000 Message-Id: <20210305124003.13582-3-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210305124003.13582-1-julien@xen.org> References: <20210305124003.13582-1-julien@xen.org> From: Julien Grall Allow GCC to analyze the format printf for xprintf() and barf{,_perror}(). Take the opportunity to define __noreturn to make the prototype for barf{,_perror})() easier to read. Signed-off-by: Julien Grall --- tools/xenstore/utils.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/xenstore/utils.h b/tools/xenstore/utils.h index 3dfb96b556dd..ccfb9b8fb699 100644 --- a/tools/xenstore/utils.h +++ b/tools/xenstore/utils.h @@ -29,10 +29,12 @@ const char *dump_state_align(FILE *fp); #define PRINTF_ATTRIBUTE(a1, a2) __attribute__((format (printf, a1, a2))) -void barf(const char *fmt, ...) __attribute__((noreturn)); -void barf_perror(const char *fmt, ...) __attribute__((noreturn)); +#define __noreturn __attribute__((noreturn)) -extern void (*xprintf)(const char *fmt, ...); +void barf(const char *fmt, ...) __noreturn PRINTF_ATTRIBUTE(1, 2); +void barf_perror(const char *fmt, ...) __noreturn PRINTF_ATTRIBUTE(1, 2); + +extern void (*xprintf)(const char *fmt, ...) PRINTF_ATTRIBUTE(1, 2); #define eprintf(_fmt, _args...) xprintf("[ERR] %s" _fmt, __FUNCTION__, ##_args) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Mar 05 12:40:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 12:40:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93653.176630 (Exim 4.92) (envelope-from ) id 1lI9kZ-0001V3-So; Fri, 05 Mar 2021 12:40:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93653.176630; Fri, 05 Mar 2021 12:40:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9kZ-0001Uw-Pu; Fri, 05 Mar 2021 12:40:11 +0000 Received: by outflank-mailman (input) for mailman id 93653; Fri, 05 Mar 2021 12:40:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9kY-0001Um-Di for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 12:40:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9kX-0005oP-0K; Fri, 05 Mar 2021 12:40:09 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lI9kW-0007BR-Ii; Fri, 05 Mar 2021 12:40:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=+VjLZQBhc666M8NTpQi/Yp6KL24Z+yakIHai6jv4bDs=; b=q9fmNvyNos17Zrk3/ZynkgP0cr 1Bt6ydYDzg/rYKW4nKralaDY8O3luOlsD+4whVa/rd2lXBmAGRclN4Ee3mcFvEEpVNOwR2KTOs/Ca KWmkykTm/PzkoPs3cSjzqsfVdhS3Be41vR1ye9xgkgnSdnw41q4HE1ZY2UA8o6lM5XAE=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , Juergen Gross Subject: [PATCH for-4.15 0/2] xenstore: Check format printf Date: Fri, 5 Mar 2021 12:40:01 +0000 Message-Id: <20210305124003.13582-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall This patch is a follow-up to Norbert's series [1]. The first patch will define PRINTF_ATTRIBUTE the same way everywhere. The second patch will check the format printf on a few more calls. Both patches are candidate for 4.15. They only affects the build system and therefore would consider them low-risk. Cheers, [1] https://lore.kernel.org/xen-devel/20210226144144.9252-1-nmanthey@amazon.de/ Julien Grall (2): tools/xenstore: Consolidate PRINTF_ATTRIBUTE() in utils.h tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() tools/xenstore/talloc.h | 15 ++------------- tools/xenstore/tdb.h | 6 ++---- tools/xenstore/utils.h | 10 +++++++--- 3 files changed, 11 insertions(+), 20 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Mar 05 12:44:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 12:44:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93662.176667 (Exim 4.92) (envelope-from ) id 1lI9ox-0001sb-V3; Fri, 05 Mar 2021 12:44:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93662.176667; Fri, 05 Mar 2021 12:44:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9ox-0001sU-S6; Fri, 05 Mar 2021 12:44:43 +0000 Received: by outflank-mailman (input) for mailman id 93662; Fri, 05 Mar 2021 12:44:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9ox-0001sP-1l for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 12:44:43 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e1c69b16-3cf5-4739-a555-2c213d981c49; Fri, 05 Mar 2021 12:44:42 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5D0F6AD73; Fri, 5 Mar 2021 12:44:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1c69b16-3cf5-4739-a555-2c213d981c49 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614948281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UgEXt0Qwt7wy8QnOI78KVOAYlqmowfFMOMsDCd28/Jo=; b=L/G1SxUbC/pnpb+8sN852+RkJtyVDIa8A/VlFNHuAmT21026P0I50kThR6M35VpR29GE9b I1TV4eO5KJc+0Bfbm7AwgWJiErX2Tf0YS8Ne4bOl5F+UdphhMcU5ZYE2rbRqx2tgp+slSO GRubVKhJn1y78NqM0RpwmTts2dkMRGU= To: Julien Grall , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall References: <20210305121029.7047-1-julien@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters Message-ID: Date: Fri, 5 Mar 2021 13:44:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210305121029.7047-1-julien@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V8gkYVIsfCj9kjdEWSKJTcnOBTUSs3mcn" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V8gkYVIsfCj9kjdEWSKJTcnOBTUSs3mcn Content-Type: multipart/mixed; boundary="KrjoczW6cyLekgCgUXVCbRLNkvrcCxv1K"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall Message-ID: Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters References: <20210305121029.7047-1-julien@xen.org> In-Reply-To: <20210305121029.7047-1-julien@xen.org> --KrjoczW6cyLekgCgUXVCbRLNkvrcCxv1K Content-Type: multipart/mixed; boundary="------------515F28EF306CE49F27B3E193" Content-Language: en-US This is a multi-part message in MIME format. --------------515F28EF306CE49F27B3E193 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 05.03.21 13:10, Julien Grall wrote: > From: Julien Grall >=20 > The longest possible command line for LiveUpdate is: >=20 > liveupdate -s -t -F >=20 > This is 5 parameters. However, the maximum is currently specified to 4.= > This means the some of the parameters will get ignored. >=20 > Update the field max_pars to 5 so and admin can specify the timeout and= > force at the same time. >=20 > Signed-off-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------515F28EF306CE49F27B3E193 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------515F28EF306CE49F27B3E193-- --KrjoczW6cyLekgCgUXVCbRLNkvrcCxv1K-- --V8gkYVIsfCj9kjdEWSKJTcnOBTUSs3mcn Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBCJ7gFAwAAAAAACgkQsN6d1ii/Ey9v Kwf+KgsyY1au0NDrjBl2bGUqnUQezBsNmztrfL56ccAvFxa/s2/3fdZzCw8ScQtiUF/fjJ1QVuZU JzmtBFUhfblC2pfG2akP6bFP2YIy7Hlpg0hiKF5BeaPtd2uq/V109e/hrTpdmBg5mCd+L5t5JHZ1 SHCFrACX9nWLhbASfrpY47Dzyay1zaIJjW+OIdhZSuY8IYk6Mu2uLcjYeMYMSGFllKzdrfiPjCVF hIooE8UEZjAD9Xg04gu9VkdgCyEHrt/lMZiOgT40iS8/z9w5sjgMoIby+uG6zpnCvOf2Ttf1yRpb X5r+4m0Z25yZrIVRRceeHEqeXr1sY6u/FoY7FtYnOw== =C410 -----END PGP SIGNATURE----- --V8gkYVIsfCj9kjdEWSKJTcnOBTUSs3mcn-- From xen-devel-bounces@lists.xenproject.org Fri Mar 05 12:50:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 12:50:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93665.176679 (Exim 4.92) (envelope-from ) id 1lI9uF-0002rH-Ir; Fri, 05 Mar 2021 12:50:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93665.176679; Fri, 05 Mar 2021 12:50:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9uF-0002rA-Fq; Fri, 05 Mar 2021 12:50:11 +0000 Received: by outflank-mailman (input) for mailman id 93665; Fri, 05 Mar 2021 12:50:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9uD-0002r5-Lz for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 12:50:09 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 58939bb7-5fb3-4810-b2a2-4fd69d64229f; Fri, 05 Mar 2021 12:50:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58939bb7-5fb3-4810-b2a2-4fd69d64229f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614948608; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=z1HelTmkuc3f0yOSIADiJ3232SVzO1AEpOdakbI14q0=; b=DdmbTNu6WcqpNwD81A5kIxSGJkkd69XFOpA9yeen0aOY4lyE5GIqZTlz NBJH/3UUpBToNuoKLfhe+XVWGW3QuN3kprQfr2Hflf1RN8l2k1qObhKQd XxeY84/ZD7Qdkk70e2PSYgcZZf8YaZvReYF8Q8aoa2oqo19yizFPCH8iw c=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: zV1m6LxsVZsEQc4Xjcsct9N3n2ffybb6svSYUFZtgaPA2rMjfLg6YhZ4XBM+FkVxsqci7+wO5Y t8BH7KDyoOPEHKDSUWikshYRvNwurdLFjOi8xAUn4wQoUge+ZbhbkFOHWx1OVPvIch69ZrBLuB ugJFKIupiREzsfdqHfHEfZ5ZTRePtlhwz+zvpoOSOinxMo3v1wmSpZml7wCr85XpT9ZkwKOIuu 0GieGKmwyG0h0ORXNaRhoxF+3a33NIxg1MLlqJ+iou7kYGt+UEVK9fQpVAiCueLiWSzk+GmDXB 7WY= X-SBRS: 5.1 X-MesageID: 38997299 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,224,1610427600"; d="scan'208";a="38997299" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH 1/3] tools/libxentoolcore: Fill in LIBHEADERS Date: Fri, 5 Mar 2021 12:49:47 +0000 Message-ID: <20210305124949.6719-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210305124949.6719-1-andrew.cooper3@citrix.com> References: <20210305124949.6719-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain c/s 4664034cd replaced a glob over include/*.h with an expectation that LIBHEADER was suitably set for libraries which didn't have a single, consistently named, header file. This wasn't true for xentoolcore, which lost xentoolcore_internal.h as a consequence, and failed an API/ABI check vs 4.14 Fixes: 4664034cd ("tools/libs: move official headers to common directory") Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Juergen Gross For 4.15. This is a regression from 4.14, even if AFAICT it only impacts the ABI checking at this point. I *think* this is the only impacted library, but I would appreciate a second pair of eyes. I did experiment with this: +ifeq ($(LIBHEADER),) +$(warning $(LIBNAME) - No headers) +endif LIBHEADER ?= $(LIB_FILE_NAME).h LIBHEADERS = $(foreach h, $(LIBHEADER), $(XEN_INCLUDE)/$(h)) which yields: andrewcoop@andrewcoop:/local/xen.git$ make -j4 -s -C tools/libs/ /local/xen.git/tools/libs/toollog/../../../tools/libs/libs.mk:50: toollog - No headers /local/xen.git/tools/libs/evtchn/../../../tools/libs/libs.mk:50: evtchn - No headers /local/xen.git/tools/libs/gnttab/../../../tools/libs/libs.mk:50: gnttab - No headers /local/xen.git/tools/libs/call/../../../tools/libs/libs.mk:50: call - No headers /local/xen.git/tools/libs/foreignmemory/../../../tools/libs/libs.mk:50: foreignmemory - No headers /local/xen.git/tools/libs/devicemodel/../../../tools/libs/libs.mk:50: devicemodel - No headers ../libs.mk:50: hypfs - No headers /local/xen.git/tools/libs/stat/../../../tools/libs/libs.mk:50: stat - No headers /local/xen.git/tools/libs/stat/../../../tools/libs/libs.mk:50: stat - No headers Headers aside for a moment, there are two bugs here. hypfs doesn't use the same include pattern as the others, and stat is entered twice. --- tools/libs/toolcore/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libs/toolcore/Makefile b/tools/libs/toolcore/Makefile index 1cf30733c9..3550786491 100644 --- a/tools/libs/toolcore/Makefile +++ b/tools/libs/toolcore/Makefile @@ -5,6 +5,8 @@ MAJOR = 1 MINOR = 0 AUTOINCS := $(XEN_INCLUDE)/_xentoolcore_list.h +LIBHEADER := xentoolcore.h xentoolcore_internal.h + SRCS-y += handlereg.c include $(XEN_ROOT)/tools/libs/libs.mk -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Mar 05 12:50:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 12:50:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93666.176691 (Exim 4.92) (envelope-from ) id 1lI9uI-0002sk-SW; Fri, 05 Mar 2021 12:50:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93666.176691; Fri, 05 Mar 2021 12:50:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9uI-0002sd-OF; Fri, 05 Mar 2021 12:50:14 +0000 Received: by outflank-mailman (input) for mailman id 93666; Fri, 05 Mar 2021 12:50:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9uH-0002s9-3W for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 12:50:13 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2e5a1ca4-5447-4c68-8fc9-e5a8778ae9ce; Fri, 05 Mar 2021 12:50:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e5a1ca4-5447-4c68-8fc9-e5a8778ae9ce DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614948611; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=eBkvGcYWDjOBL+srh6pm9g8FpW5ClCH/vq3XL3Y80S8=; b=JHcD43aosXSgt71sA0v40If9WEjZlXV6MaxxisA+iUkwP28BHwD48c5P W3VW4HIjs6nrbvI9hX/bnPN8MCJ0PAITCk1yqj+IV+FvvWBJYjpRhMnR7 sFuNQ0OeTuNqEKQYnco5EJlSZsDqGpsHL+5cv6ZRHvBOjzid8XV4xxMCz 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: adfsXxGQefkW6flCelYkRU8pzUCPhgh50dGIGU4dQaplJMI252JX3ADFusdc4i2ox/ga3raEmf n7CVlUO+hbvbilHUsPGmleYPx1sP/DT7/mGbgH9/a5BXfRROMWL9ruU6SNGf5VEgjXvx6B8T6V FVWPWy4Qp3AqlQD1VlFf7JpZS413TB9BdAQJcxFxmFaMXaVVX5i8b+7VTgy88atXUOp5RQaipv gvt9l62xUL6WfNMj5FRn/H3Io10joIpXI4iuxcc9ZUJl0WJ9SGye2npBFaUo0wLaBSxTueFe2A pKI= X-SBRS: 5.1 X-MesageID: 40038981 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,224,1610427600"; d="scan'208";a="40038981" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Juergen Gross , Ian Jackson Subject: [PATCH for-4.15 0/3] tools/libs: Multiple fixes to header handling Date: Fri, 5 Mar 2021 12:49:46 +0000 Message-ID: <20210305124949.6719-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This can of worms is festering. See patch 1 for yet more issues. Andrew Cooper (3): tools/libxentoolcore: Fill in LIBHEADERS xen/dmop: Strip __XEN_TOOLS__ header guard from public API tools/libs: Fix headers.chk logic tools/libs/devicemodel/private.h | 2 -- tools/libs/libs.mk | 2 +- tools/libs/toolcore/Makefile | 2 ++ xen/include/public/hvm/dm_op.h | 5 ----- 4 files changed, 3 insertions(+), 8 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Mar 05 12:50:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 12:50:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93667.176703 (Exim 4.92) (envelope-from ) id 1lI9uQ-0002xa-9q; Fri, 05 Mar 2021 12:50:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93667.176703; Fri, 05 Mar 2021 12:50:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9uQ-0002xS-61; Fri, 05 Mar 2021 12:50:22 +0000 Received: by outflank-mailman (input) for mailman id 93667; Fri, 05 Mar 2021 12:50:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9uP-0002x5-Ek for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 12:50:21 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3a65fd52-4119-400a-9090-9e60c8b83d25; Fri, 05 Mar 2021 12:50:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a65fd52-4119-400a-9090-9e60c8b83d25 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614948620; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FKWKNNS8zeB+e6A5j+ecHtMlcXfb4/SSo+PatHCy8Ts=; b=e/ZbU0K6q2abucZcny24+9xwuwuE3jMFx5mzCqve7cmZp4cbeGNRMR8B bV5V2L+sdB/rxUH7WQVEB5Io1Kd5Iart5UNWXzQMYnFnFEvPxgzMk6vlk s2fzTfNSTwhgB0qa+DviLzPOx5UAsIzykapY88ZV+TwhGEzwEAKxPsKqp Q=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: gDfgj/tGi2uTIKC6wNER95ZO5fbcuwAD+5NsNnMb1Hu6XNHraemPv/vpZpaGWHCmhkiRoUCIP8 VjyuD5K7uRXHbZDv5ih+QawLOGlNOg4kExZc68kpWngwZaUYYmXB7bGXj3If4tBvcm19DWkcDw JX+G7K7ZUJIRaSK8SU/ka2Hj8cj2fHIh7+G+3mgOei9wbq5wIoi6gZxg/XsMge1paVG33+LtJg yAuBIAOCj3TePSa/SDuUzLPmFeODaeaTn8BW8S14fdOkc2/8sOnGbgtpE8IcZQU1j9c2nMq40V +ro= X-SBRS: 5.1 X-MesageID: 38547171 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,224,1610427600"; d="scan'208";a="38547171" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Juergen Gross , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 3/3] tools/libs: Fix headers.chk logic Date: Fri, 5 Mar 2021 12:49:49 +0000 Message-ID: <20210305124949.6719-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210305124949.6719-1-andrew.cooper3@citrix.com> References: <20210305124949.6719-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit c/s 4664034cd dropped the $(LIBHEADERSGLOB) dependency for the headers.chk rule, without replacing it. As headers.chk uses $^, a typical build looks like: andrewcoop@andrewcoop:/local/xen.git$ make -C tools/libs/devicemodel/ make: Entering directory '/local/xen.git/tools/libs/devicemodel' for i in ; do \ gcc -x c -ansi -Wall -Werror -I/local/xen.git/tools/libs/devicemodel/../../../tools/include \ -S -o /dev/null $i || exit 1; \ echo $i; \ done >headers.chk.new mv headers.chk.new headers.chk i.e. with an empty for loop, and checking only the $(AUTOINCS). Reinsert a $(LIBHEADERS) dependency. Fixes: 4664034cd ("tools/libs: move official headers to common directory") Signed-off-by: Andrew Cooper --- CC: Juergen Gross CC: Roger Pau Monné CC: Wei Liu --- tools/libs/libs.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk index a68cec244c..2d973ccb95 100644 --- a/tools/libs/libs.mk +++ b/tools/libs/libs.mk @@ -76,7 +76,7 @@ else .PHONY: headers.chk endif -headers.chk: $(AUTOINCS) +headers.chk: $(LIBHEADERS) $(AUTOINCS) headers.lst: FORCE @{ set -e; $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Mar 05 12:50:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 12:50:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93672.176715 (Exim 4.92) (envelope-from ) id 1lI9um-00037e-JN; Fri, 05 Mar 2021 12:50:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93672.176715; Fri, 05 Mar 2021 12:50:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9um-00037X-Fr; Fri, 05 Mar 2021 12:50:44 +0000 Received: by outflank-mailman (input) for mailman id 93672; Fri, 05 Mar 2021 12:50:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lI9ul-00034k-Nq for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 12:50:43 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8c69cd3e-2afb-40fd-92b6-c28aaf925f35; Fri, 05 Mar 2021 12:50:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c69cd3e-2afb-40fd-92b6-c28aaf925f35 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614948635; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bjbbijXY3Quk6aaO7tZzhGLPPA5Tof1s8Ux56AsuWVA=; b=ER4qGNg49UkbY5BceFcgoznZcnQoae8bsmgTqZEcFqElnpb0lIM1svAZ IgIv/yRIh0tEVQBCWAKrSfoHn5gzda7BJUqEtwIju5hUlD7z2IO508g2Z kh/5HAoHBIGbgLqD4ssshJNex31hBuDC3OCcYR2tY7erp5rZziTGOAyY/ s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: BF4f4GdbBtHTAFCGu3ev5zVe1heqgu4zA3pccQd8JISXJwWZyO7Wcdh+0h4wS1Q+yg+ZwExZlm ZEgjy4/xPiyWNtmEEER15vEGhx0iY3ZKMo5P1P00HFTcFWCDne7hVtp+1yuNXvEOvwpN1d28+f xYgkN2ib0XmuIBDSogoSQUhPfkrztjkHdKIG/AxeDXO1aUthThE6URm1CIhT4bDm071MYhI2VT mtb0I8aHBihjdoTKZs2tRAxJfh07uFxoGX64iHZ9MN1tyyfjW9gc1xZDMbkZnSlcj/gRn5j94E GXU= X-SBRS: 5.1 X-MesageID: 38643897 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,224,1610427600"; d="scan'208";a="38643897" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant , Ian Jackson Subject: [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API Date: Fri, 5 Mar 2021 12:49:48 +0000 Message-ID: <20210305124949.6719-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210305124949.6719-1-andrew.cooper3@citrix.com> References: <20210305124949.6719-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Exactly as with c/s f40e1c52e4, this is inappropriate for a stable library. That change actually broke the build with: include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t' ioservid_t *id); ^ as libxendevicemodel.h now uses a type it can't see a typedef for. However, nothing noticed because the header.chk logic is also broken (fixed subsequently). Strip the guard from the public header, and remove compensation from devicemodel's private.h Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Paul Durrant CC: Ian Jackson For 4.15. This is a build fix, even if current staging can't spot the breakage. These two issues highlight that libxendevcemodel.h has never been checked since its introduction, because the checking logic only saw an empty file. --- tools/libs/devicemodel/private.h | 2 -- xen/include/public/hvm/dm_op.h | 5 ----- 2 files changed, 7 deletions(-) diff --git a/tools/libs/devicemodel/private.h b/tools/libs/devicemodel/private.h index c4a225f8af..c24f3396bb 100644 --- a/tools/libs/devicemodel/private.h +++ b/tools/libs/devicemodel/private.h @@ -1,8 +1,6 @@ #ifndef XENDEVICEMODEL_PRIVATE_H #define XENDEVICEMODEL_PRIVATE_H -#define __XEN_TOOLS__ 1 - #include #include #include diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h index ef7fbc0d3d..fa3f083fed 100644 --- a/xen/include/public/hvm/dm_op.h +++ b/xen/include/public/hvm/dm_op.h @@ -25,9 +25,6 @@ #define __XEN_PUBLIC_HVM_DM_OP_H__ #include "../xen.h" - -#if defined(__XEN__) || defined(__XEN_TOOLS__) - #include "../event_channel.h" #ifndef uint64_aligned_t @@ -491,8 +488,6 @@ struct xen_dm_op { } u; }; -#endif /* __XEN__ || __XEN_TOOLS__ */ - struct xen_dm_op_buf { XEN_GUEST_HANDLE(void) h; xen_ulong_t size; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:00:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:00:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93679.176727 (Exim 4.92) (envelope-from ) id 1lIA3y-0004GY-HY; Fri, 05 Mar 2021 13:00:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93679.176727; Fri, 05 Mar 2021 13:00:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIA3y-0004GR-DW; Fri, 05 Mar 2021 13:00:14 +0000 Received: by outflank-mailman (input) for mailman id 93679; Fri, 05 Mar 2021 13:00:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIA3w-0004GM-Po for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:00:12 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b154e5b4-b06a-479f-96c8-d87ef9c7df17; Fri, 05 Mar 2021 13:00:11 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E6111AE3C; Fri, 5 Mar 2021 13:00:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b154e5b4-b06a-479f-96c8-d87ef9c7df17 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614949211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fqPFFEXxRn+iLNAl6ARcX7hpFyaZ22cTsCmarIGybCE=; b=shrzf7c4xYqFiIrYokDL0RoF2BKE9fqgF8LscJynYpPheckAynlQgA1Cs3kQimr4gNKRcX L8mgoasZiyVsep/UplJiD7BHL8SpGMMRSJrIU0KmbVkT0yUfbNPML2q2eYYe05n7kAnWtD PipCMz4sHEMv1VKgDehhhTzQfWihz1I= Subject: Re: [PATCH for-4.15 1/2] tools/xenstore: Consolidate PRINTF_ATTRIBUTE() in utils.h To: Julien Grall , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-2-julien@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Fri, 5 Mar 2021 14:00:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210305124003.13582-2-julien@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xa030PwzxeFYZePFlNYfPQjgqVXhHFt1I" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xa030PwzxeFYZePFlNYfPQjgqVXhHFt1I Content-Type: multipart/mixed; boundary="Z3BhJ0Nm3JMkACTRK4cX3yc0paXAySkt0"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu Message-ID: Subject: Re: [PATCH for-4.15 1/2] tools/xenstore: Consolidate PRINTF_ATTRIBUTE() in utils.h References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-2-julien@xen.org> In-Reply-To: <20210305124003.13582-2-julien@xen.org> --Z3BhJ0Nm3JMkACTRK4cX3yc0paXAySkt0 Content-Type: multipart/mixed; boundary="------------0C8A056C013D922393496A8F" Content-Language: en-US This is a multi-part message in MIME format. --------------0C8A056C013D922393496A8F Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 05.03.21 13:40, Julien Grall wrote: > From: Julien Grall >=20 > At the moment PRINTF_ATTRIBUTE() is defined in two places: > - tdb.h: Defined as a NOP > - talloc.h: Defined as a NOP for GCC older than 3.0 otherwise will= > add the attribute to check the printf format >=20 > Xen requires to build with minimum GCC 4.1 and we want to check the > printf format for all the printf-like functions. >=20 > Only implement PRINTF_ATTRIBUTE() once in utils.h and drop the > conditional check for GCC < 3.0. >=20 > Signed-off-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------0C8A056C013D922393496A8F Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0C8A056C013D922393496A8F-- --Z3BhJ0Nm3JMkACTRK4cX3yc0paXAySkt0-- --xa030PwzxeFYZePFlNYfPQjgqVXhHFt1I Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBCK1oFAwAAAAAACgkQsN6d1ii/Ey/1 BQf/YnLAst5UUldnEmQIpWFZVi6rtDrclj8/XHyi+fyXtyPPo++Sew2azMBk1kAkt8orxiwj2RrW +8OTO+3e0AiG8vKtQFjJrJwLhgulUBAMZtcS8Mez7T0krO2Wx3uY4nfrdq8Xf1G0p23NBk1e37Fi oVUPp72XtcxkoK8zIvlCIFHvaq5e7NHkCTjxsBDwrz+/vRnVvryT3w9HAQSpNXoycboen4f4TFuf +FZCvjY+yJ2M42O+2O3z+0QhJX4qxSF3Wv397gg3A+2KEFRK4JVM9pHAIPGUD1mo7EdV7OagHSq2 Bmre1QrYOS+/nbyqfKUyzlZT9lRGepr/2t3hMJIFSg== =zR+B -----END PGP SIGNATURE----- --xa030PwzxeFYZePFlNYfPQjgqVXhHFt1I-- From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:01:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:01:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93682.176739 (Exim 4.92) (envelope-from ) id 1lIA5T-0004On-TZ; Fri, 05 Mar 2021 13:01:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93682.176739; Fri, 05 Mar 2021 13:01:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIA5T-0004Og-P4; Fri, 05 Mar 2021 13:01:47 +0000 Received: by outflank-mailman (input) for mailman id 93682; Fri, 05 Mar 2021 13:01:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIA5R-0004OX-P7 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:01:45 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4bd2f7b4-7265-4931-a817-ac057e71e627; Fri, 05 Mar 2021 13:01:45 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3591EACCF; Fri, 5 Mar 2021 13:01:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bd2f7b4-7265-4931-a817-ac057e71e627 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614949304; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rsxoReKn9MrwQi7ejbrYfG0FViibXB3KIFAPlgBYwzA=; b=ZikIOC4X7bxOEqJNqv/cDRtdrZmW2hRFdlUcNizLFunmYRIYDydqfVs/Yg7xmZdEe6dOLX 8R+nWznvWqGMVf+QfqBXJsVf1YrXTpcISO69CuR9kx/2+FZOkPntNBWm9OmB6w9d9wLtFn /mlgQ6sSX39ubi5dvKaldddFlE1Ox10= Subject: Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() To: Julien Grall , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-3-julien@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <0994b7a0-c537-b312-b134-caf54c79c87f@suse.com> Date: Fri, 5 Mar 2021 14:01:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210305124003.13582-3-julien@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nPCh1PrCabwHDmkmoi7B3pmslQaupr2Lr" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nPCh1PrCabwHDmkmoi7B3pmslQaupr2Lr Content-Type: multipart/mixed; boundary="ueus3LmqTx4JjMIZllSUAzb3M5mJfEm0m"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu Message-ID: <0994b7a0-c537-b312-b134-caf54c79c87f@suse.com> Subject: Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-3-julien@xen.org> In-Reply-To: <20210305124003.13582-3-julien@xen.org> --ueus3LmqTx4JjMIZllSUAzb3M5mJfEm0m Content-Type: multipart/mixed; boundary="------------047863EADE8604BFEA9A9852" Content-Language: en-US This is a multi-part message in MIME format. --------------047863EADE8604BFEA9A9852 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 05.03.21 13:40, Julien Grall wrote: > From: Julien Grall >=20 > Allow GCC to analyze the format printf for xprintf() and > barf{,_perror}(). >=20 > Take the opportunity to define __noreturn to make the prototype for > barf{,_perror})() easier to read. >=20 > Signed-off-by: Julien Grall Reviewed-by: Juergen Gross But I would prefer, if ... > --- > tools/xenstore/utils.h | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/tools/xenstore/utils.h b/tools/xenstore/utils.h > index 3dfb96b556dd..ccfb9b8fb699 100644 > --- a/tools/xenstore/utils.h > +++ b/tools/xenstore/utils.h > @@ -29,10 +29,12 @@ const char *dump_state_align(FILE *fp); > =20 > #define PRINTF_ATTRIBUTE(a1, a2) __attribute__((format (printf, a1, a= 2))) > =20 > -void barf(const char *fmt, ...) __attribute__((noreturn)); > -void barf_perror(const char *fmt, ...) __attribute__((noreturn)); > +#define __noreturn __attribute__((noreturn)) > =20 > -extern void (*xprintf)(const char *fmt, ...); > +void barf(const char *fmt, ...) __noreturn PRINTF_ATTRIBUTE(1, 2); > +void barf_perror(const char *fmt, ...) __noreturn PRINTF_ATTRIBUTE(1, = 2); > + > +extern void (*xprintf)(const char *fmt, ...) PRINTF_ATTRIBUTE(1, 2); =2E.. the extern here would be dropped. Juergen --------------047863EADE8604BFEA9A9852 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------047863EADE8604BFEA9A9852-- --ueus3LmqTx4JjMIZllSUAzb3M5mJfEm0m-- --nPCh1PrCabwHDmkmoi7B3pmslQaupr2Lr Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBCK7cFAwAAAAAACgkQsN6d1ii/Ey8t ZggAnQdBE4sLax4WcIe1buBFQeyRbYNbnO6SpHQX63G/ky4+xfn/moRP2ppVoPxX38avZ/5mfhkl YP+AOUjV0XKjw4m9ZNblXqfw5bVGfeio98XlZZjU3MgsMXl5HcSYChawAuOZ6IYgvPC/kXOtkpTh zfpYInKMGJbt88Bg0U7CK69EsT0gyzdVeq+E3zoitaWOq2tHR2M1NjLyI+7FgpEdBdrRrYxBf1ma FqvrInzHfHSblOf+YEr2PUZTrT2FmVe8TtL4gpblzFf7HvkItVJolzrQGUxqwnP7BOxYAxzjihFY zgYaDqfMe7n4vs5HwpbxE64VfFDeoCUogQTjfLlywg== =E646 -----END PGP SIGNATURE----- --nPCh1PrCabwHDmkmoi7B3pmslQaupr2Lr-- From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:22:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:22:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93686.176751 (Exim 4.92) (envelope-from ) id 1lIAPG-0006NR-GQ; Fri, 05 Mar 2021 13:22:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93686.176751; Fri, 05 Mar 2021 13:22:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAPG-0006NK-DN; Fri, 05 Mar 2021 13:22:14 +0000 Received: by outflank-mailman (input) for mailman id 93686; Fri, 05 Mar 2021 13:22:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAPF-0006NF-Pg for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:22:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAPF-0006fT-ML for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:22:13 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIAPF-0001eF-J9 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:22:13 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIAPC-0008NU-06; Fri, 05 Mar 2021 13:22:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=U+oSM8NTf2wdmz90OwMqDCXJpXj1kjl1csmbly+z8YA=; b=UofpYBbIXLshve0XJcezXUiSvc tDmbJA4zNzlQRwP7FI9h3pR/falPcbTa29C7tUV/hMnlbuAvE6/tvb6qHsD9sMK3s6TmSpYe+ixLC nuruCWwe9DtFvIiAHtRbiIGNxinkFA+B18swjn5JUewTqhfW07y3mewKEddoOroofnlk=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24642.12417.651929.972294@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 13:22:09 +0000 To: Julien Grall Cc: xen-devel@lists.xenproject.org, raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Juergen Gross Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters In-Reply-To: <20210305121029.7047-1-julien@xen.org> References: <20210305121029.7047-1-julien@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("[PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters"): > From: Julien Grall > > The longest possible command line for LiveUpdate is: > > liveupdate -s -t -F > > This is 5 parameters. However, the maximum is currently specified to 4. > This means the some of the parameters will get ignored. Why are the extra parameters ignored rather than treated as errors ? This seems like an invitation to making code with bad behaviour (perhaps bad security-relevant behaviour). CC Juergen who seems to have written the code... > Update the field max_pars to 5 so and admin can specify the timeout and > force at the same time. Anyway, for this patch, Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:24:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:24:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93691.176763 (Exim 4.92) (envelope-from ) id 1lIAR4-0006Uk-W2; Fri, 05 Mar 2021 13:24:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93691.176763; Fri, 05 Mar 2021 13:24:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAR4-0006Ud-Sr; Fri, 05 Mar 2021 13:24:06 +0000 Received: by outflank-mailman (input) for mailman id 93691; Fri, 05 Mar 2021 13:24:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAR3-0006UW-MS for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:24:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAR3-0006h5-G8 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:24:05 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIAR3-0001kA-El for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:24:05 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIAR0-0008Nz-3O; Fri, 05 Mar 2021 13:24:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=v8BwmWVXumSpTnT5yALGy/i+hc30fZFIsTozBDrd3RA=; b=VmJUv5lPXCiIVUPX1JUAkBK+G6 Uq+uxth/eNdGz2JvqmLKnSNP/6RTEHfXGpSPoFHH9VxRwHOl1sLeaeyviFeTYQ6fZokLDnY+ywRRb wls8qPTN/gdmW3nQ0VdPcvXrHA98gdi5jo2+qWXkc4cJF2Y4DMY/dhUCcFOr0YeIBRLg=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24642.12529.753822.114284@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 13:24:01 +0000 To: Julien Grall Cc: xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall , Wei Liu , Juergen Gross Subject: [PATCH for-4.15 1/2] tools/xenstore: Consolidate PRINTF_ATTRIBUTE() in utils.h In-Reply-To: <20210305124003.13582-2-julien@xen.org> References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-2-julien@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("[PATCH for-4.15 1/2] tools/xenstore: Consolidate PRINTF_ATTRIBUTE() in utils.h"): > From: Julien Grall > > At the moment PRINTF_ATTRIBUTE() is defined in two places: > - tdb.h: Defined as a NOP > - talloc.h: Defined as a NOP for GCC older than 3.0 otherwise will > add the attribute to check the printf format > > Xen requires to build with minimum GCC 4.1 and we want to check the > printf format for all the printf-like functions. > > Only implement PRINTF_ATTRIBUTE() once in utils.h and drop the > conditional check for GCC < 3.0. Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:24:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:24:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93694.176775 (Exim 4.92) (envelope-from ) id 1lIARs-0006bR-9d; Fri, 05 Mar 2021 13:24:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93694.176775; Fri, 05 Mar 2021 13:24:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIARs-0006bJ-6i; Fri, 05 Mar 2021 13:24:56 +0000 Received: by outflank-mailman (input) for mailman id 93694; Fri, 05 Mar 2021 13:24:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIARr-0006bD-8o for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:24:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIARr-0006i3-85 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:24:55 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIARr-0001oa-7E for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:24:55 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIARn-0008OQ-QZ; Fri, 05 Mar 2021 13:24:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=h3cfrY8MA3VSc5TALv7Rc6fduNBtb3sFNMgBZL07nF0=; b=OXOEO8t0dqwGC4l6IOw4//Z6in F9LZSpuc2wqncBSwzWjg8iWtA43BEWmIJ4t2X9ZzH8bDGP6VLxXQxT11SR9FryJoplq2G96WSBeaC J+k8vdz0gpzIv2iB2E2N9NvEZCZi8CQnRIaxHw2upnvcPTCKt0kd8bagDt7ckOxS0g+s=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24642.12579.543046.234448@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 13:24:51 +0000 To: Julien Grall Cc: xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall , Wei Liu , Juergen Gross Subject: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() In-Reply-To: <20210305124003.13582-3-julien@xen.org> References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-3-julien@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("[PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}()"): > From: Julien Grall > > Allow GCC to analyze the format printf for xprintf() and > barf{,_perror}(). > > Take the opportunity to define __noreturn to make the prototype for > barf{,_perror})() easier to read. Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:25:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:25:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93696.176787 (Exim 4.92) (envelope-from ) id 1lIASo-0006if-KL; Fri, 05 Mar 2021 13:25:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93696.176787; Fri, 05 Mar 2021 13:25:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIASo-0006iY-GE; Fri, 05 Mar 2021 13:25:54 +0000 Received: by outflank-mailman (input) for mailman id 93696; Fri, 05 Mar 2021 13:25:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIASn-0006iP-CQ for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:25:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIASn-0006it-Bi for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:25:53 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIASn-0001t0-Ar for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:25:53 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIASj-0008Ot-Li; Fri, 05 Mar 2021 13:25:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=TR33K6zlYTlf0L931+VL20bYC5fZ2PKK1LMzinsc2yo=; b=RPSR7y+ux50jNb8wqgTSICsLN0 TLcRLyLhZg3+yK1o041xTuH/sA8GKX5pbZ3/ZYHJ3IOBn0oPohbqopYNbKJedj176VqqWdm61Da2v Z9WoYQj36vaiFOLmEOcr6DTu+ISxL+zIjwA4DahsNzweOVEjq325XwvsFXq9TSozN4lc=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24642.12637.396968.875901@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 13:25:49 +0000 To: Andrew Cooper Cc: Xen-devel , Wei Liu , Juergen Gross Subject: [PATCH 1/3] tools/libxentoolcore: Fill in LIBHEADERS In-Reply-To: <20210305124949.6719-2-andrew.cooper3@citrix.com> References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-2-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH 1/3] tools/libxentoolcore: Fill in LIBHEADERS"): > c/s 4664034cd replaced a glob over include/*.h with an expectation that > LIBHEADER was suitably set for libraries which didn't have a single, > consistently named, header file. > > This wasn't true for xentoolcore, which lost xentoolcore_internal.h as a > consequence, and failed an API/ABI check vs 4.14 > > Fixes: 4664034cd ("tools/libs: move official headers to common directory") > Signed-off-by: Andrew Cooper Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:26:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:26:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93698.176798 (Exim 4.92) (envelope-from ) id 1lIATB-0006pe-S7; Fri, 05 Mar 2021 13:26:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93698.176798; Fri, 05 Mar 2021 13:26:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIATB-0006pX-P7; Fri, 05 Mar 2021 13:26:17 +0000 Received: by outflank-mailman (input) for mailman id 93698; Fri, 05 Mar 2021 13:26:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAT9-0006pJ-M7 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:26:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAT9-0006jW-LO for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:26:15 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIAT9-0001xq-KZ for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:26:15 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIAT5-0008PD-9B; Fri, 05 Mar 2021 13:26:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=UCfUwpWMCIJsgTt0fuDfo/59MmUPhJuOtuM86PxmU5Q=; b=mi7Lzapb18Y5L1VSfeH5bTEwUb regfP/J64HXhFFQR6RIG5A4U+wDUUPj/2nfONpAOD1Rg2T4AAQMytu0r7vfrcuPvRLbxriLT5n3aU G7SHVGdRNfc5lK7akQ/u/4UhgYmT8R3L8SYS0WxOAbiajoUbEqaJ/THvEI3glNIINbyg=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24642.12659.29219.954222@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 13:26:11 +0000 To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Paul Durrant Subject: Re: [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API In-Reply-To: <20210305124949.6719-3-andrew.cooper3@citrix.com> References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-3-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API"): > Exactly as with c/s f40e1c52e4, this is inappropriate for a stable library. > > That change actually broke the build with: > > include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t' > ioservid_t *id); > ^ > > as libxendevicemodel.h now uses a type it can't see a typedef for. However, > nothing noticed because the header.chk logic is also broken (fixed > subsequently). > > Strip the guard from the public header, and remove compensation from > devicemodel's private.h Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:27:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:27:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93702.176810 (Exim 4.92) (envelope-from ) id 1lIAUb-0006ys-7r; Fri, 05 Mar 2021 13:27:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93702.176810; Fri, 05 Mar 2021 13:27:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAUb-0006yl-4l; Fri, 05 Mar 2021 13:27:45 +0000 Received: by outflank-mailman (input) for mailman id 93702; Fri, 05 Mar 2021 13:27:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAUa-0006yc-DT for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:27:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAUa-0006mf-BH for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:27:44 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIAUa-000245-AV for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:27:44 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIAUV-0008Pl-E5; Fri, 05 Mar 2021 13:27:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=FVddYPRvUs8u+pd+WUgmO30Y4O7uGJrllArfzOYlnNs=; b=hH+jhuGtHny3amSn5NmzvyJUG+ U8WgFcFknuq4EohL+z1eFIf8FAHcjKBRwMWyUfmr9Tu25boUT5ZwnUyWYP9kxpuja6L3F4xvlWALd CYc0AktArPkHuhWUloSPpM1q9oZBKvJRU/ntk7gN+D9eIFYiaJPnw4cSu6asadLXcNUY=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24642.12747.126941.615066@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 13:27:39 +0000 To: =?iso-8859-1?Q?J=FCrgen_Gro=DF?= Cc: Julien Grall , xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall , Wei Liu Subject: Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() In-Reply-To: <0994b7a0-c537-b312-b134-caf54c79c87f@suse.com> References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-3-julien@xen.org> <0994b7a0-c537-b312-b134-caf54c79c87f@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jrgen Gro writes ("Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}()"): > On 05.03.21 13:40, Julien Grall wrote: > > -extern void (*xprintf)(const char *fmt, ...); > > +void barf(const char *fmt, ...) __noreturn PRINTF_ATTRIBUTE(1, 2); > > +void barf_perror(const char *fmt, ...) __noreturn PRINTF_ATTRIBUTE(1, 2); > > + > > +extern void (*xprintf)(const char *fmt, ...) PRINTF_ATTRIBUTE(1, 2); > > ... the extern here would be dropped. With my RM hat on I don't have an opinion on that and my R-A can stand. With my maintainer hat on I agree with Jrgen's style opinion - it's nicer without the "extern", but I'm also happy with the patch as is. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:32:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:32:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93705.176823 (Exim 4.92) (envelope-from ) id 1lIAZ2-0007zU-RL; Fri, 05 Mar 2021 13:32:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93705.176823; Fri, 05 Mar 2021 13:32:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAZ2-0007zN-OQ; Fri, 05 Mar 2021 13:32:20 +0000 Received: by outflank-mailman (input) for mailman id 93705; Fri, 05 Mar 2021 13:32:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAZ1-0007zI-SJ for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:32:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAZ0-0006s3-G4; Fri, 05 Mar 2021 13:32:18 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lIAZ0-0002J0-6L; Fri, 05 Mar 2021 13:32:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=66aZ25rC7UlA+4HECzBjvALagpwec2olmCIUDyveOiw=; b=NKTpllAOaO9aOaDsXv4iSew1Gj aTS17Kup8tqpEQdaQ0xtVx3BseVbs1Qi5AkCMjyxdWodDq+hHNHL/W1XLprZe+6EMTODnq9Q+ydP8 qPuhq8tnfEnik18MnamofzoaRdcCLTDTac6C9g5y5Cmg4pi2TPfIee7vHfNE7/hLXrQA=; Subject: Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() To: Ian Jackson , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall , Wei Liu References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-3-julien@xen.org> <0994b7a0-c537-b312-b134-caf54c79c87f@suse.com> <24642.12747.126941.615066@mariner.uk.xensource.com> From: Julien Grall Message-ID: Date: Fri, 5 Mar 2021 13:32:15 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24642.12747.126941.615066@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Ian, On 05/03/2021 13:27, Ian Jackson wrote: > Jürgen Groß writes ("Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}()"): >> On 05.03.21 13:40, Julien Grall wrote: >>> -extern void (*xprintf)(const char *fmt, ...); >>> +void barf(const char *fmt, ...) __noreturn PRINTF_ATTRIBUTE(1, 2); >>> +void barf_perror(const char *fmt, ...) __noreturn PRINTF_ATTRIBUTE(1, 2); >>> + >>> +extern void (*xprintf)(const char *fmt, ...) PRINTF_ATTRIBUTE(1, 2); >> >> ... the extern here would be dropped. > > With my RM hat on I don't have an opinion on that and my R-A can > stand. > > With my maintainer hat on I agree with Jürgen's style opinion - it's > nicer without the "extern", but I'm also happy with the patch as is. I agree with Juergen's style opinion. I will do the modification on commit. I will also update the last sentence of the commit to: " Take the opportunity to: * remove extern from the function prototype for consistency * define __noreturn to make the prototype for barf{,_perror})() easier to read. " Cheers, > Ian. > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:39:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:39:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93708.176835 (Exim 4.92) (envelope-from ) id 1lIAfd-0008Cg-JD; Fri, 05 Mar 2021 13:39:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93708.176835; Fri, 05 Mar 2021 13:39:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAfd-0008CZ-F6; Fri, 05 Mar 2021 13:39:09 +0000 Received: by outflank-mailman (input) for mailman id 93708; Fri, 05 Mar 2021 13:39:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAfc-0008CU-Bo for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:39:08 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3e184123-8b4b-44ff-8e88-81fec1225734; Fri, 05 Mar 2021 13:39:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e184123-8b4b-44ff-8e88-81fec1225734 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614951547; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=255sxRsZFPhMkMJClT+45Zmcz2S1ESOv10SDQzCsULQ=; b=hJH4PWr+bk1Lc3yNA6OY/fB5L7ttmMC0tf/n+rAGpBu0M71oJ9PqqMJm 1Tw/yfyifuQUYg83rATYwbBTWLYurWWoyj45BihLMc+c4x1LpIkDAj3b1 GgSEhyCOJYjFdeQdLjmvW2hvuSm9tJ9M1IYETzNBVDR73xG8k/CaV4sK+ k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Np9k7AOFFUMllDBAU68I5EVK982G1YgzrCHuF/hryP9krIJNcdL2j5XZeT0z/ZnooD+tExliS6 B/g0E0pVFo74As/VEnocxMnj6WFDGxgFFgAlu7qo1lb7RXRKeYByQxkRxHD32LC5aTUyNFLF8m ycM3ZoWRAsAuebgNQ4hMOoGHXoDwUjuyYMFuUJxa5mMac8ygvllHVpeB40BrVJ7ekuQkZjo4f6 /R6w+SU1yG2UE9K/aAHzdvES22HA+kiXwaOHwcb/KOJc991xauXSV9iL97ZwBxKSVeMNdrCNmp h2k= X-SBRS: 5.2 X-MesageID: 38626148 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,224,1610427600"; d="scan'208";a="38626148" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HArdjncKaiRjkJxFnWEJo/r1DlytVQzge66qivDq4907QJM/Uv8KiTDZlJ5R8RQbqggjVTfbUaWhckXnYmpcdCp5Z5jTz05v/h++UScwpukQnJ8Eruf5IHiTNuQsU2/Ps0HsYDSukGON7KCg/kjFoljz6xJ8dsVxqzP7vs7Dtzgee6xUNsY5//WLE9bxj8P2f01WeV1dmK2HWknOdHCM3GdwiNXiwZy+pr365FuS6Cu8UCN2MtyOUljM72+/m5NnOKgdwY/MnucUw+ndkWiMPUvIwsDRlLZSC1RW3RyKTvTeSghneh8JEq9kSvXvpIZJ4ulgCBbt4y2h3dXeFGydbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PGUL/fVldIoxWNj+dCeZWEcNQG9ZzVAw7e1+qXhsVuI=; b=my31I57KpgKgdpA65akD868zSfQxLv+oujmhp9UUdVro0H3vnVxEqpokox4zs5YdSlBY63hrXDvQSEnpBDcFXGabXEFZGbM6IMxblyFpUtFU05BeuiKo07FakAPPNDFoCn/MHTQnSAfE+6+HdxnlBTgQtpiZbNgA7Xtq3mp73b2erdWBsFUXfTBJ13WuxGc89I1HSgidQ/A/sXBro8pujVf5Z4qivgXA3qc1xyJwQ0wPLhgTV2wYp5aH+5fsK0QTlGmg0+4akmZEdfPA8eFfJzYyXzHlCpXFGLLaQzbbK+LUXUx0ymNR/ffn07QJioSxGH9y8X4s7HLzTgdsDRkwkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PGUL/fVldIoxWNj+dCeZWEcNQG9ZzVAw7e1+qXhsVuI=; b=KfnSV7cc2IF7AkzzPA6d2HMqWmgWruljjFM0FJgjRB/G+1RGhgjQjs/192HWDr+Qkd+tQrv2YGoD/bi2eAk/SsNor6abvqt8EH76pjh1MVsC6JHzsBvBcy4OLQoIN2fCqIWl1YbxET/jfPkcw5rB1OUPE3piMkuQQbNU4eNRiEc= Subject: Re: [PATCH 3/3] tools/libs: Fix headers.chk logic To: Xen-devel CC: Juergen Gross , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-4-andrew.cooper3@citrix.com> From: Andrew Cooper Message-ID: <291c999a-19aa-2863-8154-4acc1774b4b8@citrix.com> Date: Fri, 5 Mar 2021 13:38:35 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210305124949.6719-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LNXP265CA0034.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::22) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a8d65704-5e96-42e6-0ce6-08d8dfdbfd93 X-MS-TrafficTypeDiagnostic: BY5PR03MB4998: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TO6RtOqhc4+VXgCW/4IDItFQ3EZbtpON994AlCTj14D/tp7S5cQ/PAwSeVJCjGqb7zzW+p2Dblj2uZC5UERizqOIkZG/H/XHrQ0YIm39NQboz0cP2Hrmsjrd3GJonYhNjwKL971mczHN7+7d/+JTSXDNNoDo2irivF4WKgvowt9W6p01VCaOp2f4AMYKZHFuR50exD1zz3+VQzqwAyvf/1cgFW8uq5ooDg/nvtPJrsTyymlTSxeMFYBouEXbMjPaYWcS/7+ofjYhxrW3I8ZFfxdIyT69EdT8TTXweAi2h596xmhNVCthll/oLWgOhGSLHIJNBnyvkGQo5yyqoJULpttlJadP5Wb8c04sb17GDQgjKD3ZPTSiNqXE9yREGs7XrJ6O81Nv+iSy6ZNoAgkpJlZl5UUpVOiBkaklIIDqYncr3z4Ji5Kz+gKOKBu18X+7iCCQuYo9yiomWzPomkQ9e1W1tATb/MUgGwWcp5pJXqOqWmJoeZjpG4xLqD6V+c+ffiPiQbR+hIiAPV+Kvo+R85vJbmEyOz/erqtpx+GC5JjuWE+4WMGDsMQMtyQg8/XPz/OBZ+s0pyR6NmBcgvARwKOiduIzFxPk1sv2X4bbGhc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(16576012)(66556008)(26005)(31686004)(8676002)(6486002)(16526019)(54906003)(66946007)(2906002)(186003)(4326008)(956004)(36756003)(478600001)(5660300002)(53546011)(316002)(6916009)(66476007)(31696002)(6666004)(83380400001)(8936002)(86362001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ano3Wml1Q0NjeTBtT0docURPR2Z2VzArWEJWNFNsZGhTelpWRzEvQlF0aTYv?= =?utf-8?B?dVU3bDRnWnJaM0UxMWhOcUNjZjZBTEFTaHJYRHdlWnphRTZmaVlJeXBFUDEr?= =?utf-8?B?T2JYanZjNE84a0ttOFVGZklBb25sM1hHTTVZeU9CWUlaV1VqcEVoV2hjNXJC?= =?utf-8?B?eTdIUEE1dHlsTUlyRkI2bVQ2UlV1VEtHOFhTNEQ4eGg3eXZSSjY0WXM4c1NG?= =?utf-8?B?bkRIM3lhTmhHVHZwbndtNnhvZm14TkFXZFg0UUFMZXR0QmFJRFo1SUpWUHVK?= =?utf-8?B?SnoySUpMcVU2alhJKzNMTURoN0VOZUlScjZWVlFRU2ZkMXdtdlNIc2JrTUJ1?= =?utf-8?B?OThuckNSTHpGTWpTSGdvK1V3eWU1bHBVdzdkQTlJL1ZFbEIwaHNsTEVJejJo?= =?utf-8?B?aTNIMFRGdHVlY3p6RW0xRVkzV0gyVWhJV0JQQlFOb2lJcjI5UWtCbDVrSWtJ?= =?utf-8?B?UXJxMEVRQmx0ZnZ2UEN2OGRqYkVXWjcvbStlQ2NSWEFRSHBCT25jSGR1MHdu?= =?utf-8?B?T2svV0YzamFQeWp2di9sZFlTcU5SVGwxVHpxNS9Ubk90K0dLS0E4SjR4TWZa?= =?utf-8?B?Z0lkMTRVSDJUT3h6VFc3ajErd0VMMjkzcy9OV01tVzdZR3F1ckR5Y1o3WVUy?= =?utf-8?B?MzFZbHZIby9VdXNHbVE4b3duU1RqaXRrUHY0SUppUFN4Ynh5dTlQdEFwUnlU?= =?utf-8?B?b29xVE81bzdvaU9UWVdKQzMyNmVleC9VK0RvRm5EZFV0MXB5Ym5jN1gxWmdq?= =?utf-8?B?K21pZS80RE40TnRoTk9NS2FjOUFvelQrNDFkS2k5eFJtMnlBVE5vdDJxdTl6?= =?utf-8?B?VjBkY3p1bXRqVHBXZHNvSXJZQkZKRmV1TWFLR2xWTzNlaTVCYmR5YjlFL1ph?= =?utf-8?B?ZkVsTkJkWkZYZWgvSXRDUG1NVHU5THZkMTN4ZURNUzJGNWcwWVhMSWFIbkxk?= =?utf-8?B?dEFHdlliY1E5elJGYkExamNwbFFMNG5oOFpBMUZDMkRTbnNPNEp6TTQ0R0NO?= =?utf-8?B?WmtuZi9oaDlsbzNxN2FJclJGdWwyaTNxRVdPakhTZHVsbkxESlVRdE90MjdB?= =?utf-8?B?eDdDZFU4dmJkSWhkTVc1L1FTWWhlbkxoTzQxQzd6M3JzN3VLeXhxN3Y0ZWVX?= =?utf-8?B?ZmJxVVVRa1F5U01QaTcrTWJyeTVEQStRNTdTOTB3T0FvRDFWR2dPeW1CemQ4?= =?utf-8?B?RVB2MTdWNUJrL1EydjlyYUk0azN6YVZSbHlXZlYxZWs2UU4wdFd0RWNCdjBo?= =?utf-8?B?aVNhMXo1MVdHLzkwTnc4eDBDc25WVU1POVdQd2F2ZkRDeDM3a3IzWUp4ZFYy?= =?utf-8?B?TTlFUm1raEZ4V2NpbXJ6OUJxZ0ViazBUdlYwbUF4ZExhYTViSDhqWFEyQWxF?= =?utf-8?B?Y0tWc2drZmRUUnB5Rm1RdkI0Q1lJbWZJUy96NGczbFhEZ3o1Mmx0YndKMFNm?= =?utf-8?B?UWRTQmVnMCtnbVg5UTNrUnRMclc0bzlzckJZeGo5b3pBZXJRUFdCZlhadHdB?= =?utf-8?B?NWxqQWxKaUJXNUx6eUkwcFBCdzRYUzVIM3p3VUxJeW1ZTWNTeWNDMEd4NFhX?= =?utf-8?B?eDBWcDJ6SU9USjVxd05kK1BSb01RczhzNVRHck5HNlROY01HTmQ0WEJOUHc5?= =?utf-8?B?bDZyNG5aZ285dDdsYmZVd2txTkpGaG5vZWxpWEF4aWJyQ1RNTGRhVGRRc2dZ?= =?utf-8?B?cC9BaVBoQVlhNWtzWU1MbHFubzJhUktxVTlaYVlXYkgzRE9aVEd3NzNOWGRG?= =?utf-8?Q?ok/C/HGbn1HynCJrLtYd0641Q1NBZSDfKUB5Avl?= X-MS-Exchange-CrossTenant-Network-Message-Id: a8d65704-5e96-42e6-0ce6-08d8dfdbfd93 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2021 13:38:42.0578 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AjLZlCCWq8D8Uma5YT03t20XMcpMijC2IcVHClD+1uC2ZAItYwTHPRQSNnHuL8RssyTJ+3xAubgYYhC8S0qAxPt/Rf3BblvtJlxU/CH6c0E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4998 X-OriginatorOrg: citrix.com On 05/03/2021 12:49, Andrew Cooper wrote: > c/s 4664034cd dropped the $(LIBHEADERSGLOB) dependency for the headers.chk > rule, without replacing it. > > As headers.chk uses $^, a typical build looks like: > > andrewcoop@andrewcoop:/local/xen.git$ make -C tools/libs/devicemodel/ > make: Entering directory '/local/xen.git/tools/libs/devicemodel' > for i in ; do \ > gcc -x c -ansi -Wall -Werror > -I/local/xen.git/tools/libs/devicemodel/../../../tools/include \ > -S -o /dev/null $i || exit 1; \ > echo $i; \ > done >headers.chk.new > mv headers.chk.new headers.chk > > i.e. with an empty for loop, and checking only the $(AUTOINCS). > > Reinsert a $(LIBHEADERS) dependency. > > Fixes: 4664034cd ("tools/libs: move official headers to common directory") > Signed-off-by: Andrew Cooper > --- > CC: Juergen Gross > CC: Roger Pau Monné > CC: Wei Liu Apologies - I totally messed up the CC list here. For 4.15.  Regression from 4.14, in some build-time checking logic. ~Andrew > --- > tools/libs/libs.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk > index a68cec244c..2d973ccb95 100644 > --- a/tools/libs/libs.mk > +++ b/tools/libs/libs.mk > @@ -76,7 +76,7 @@ else > .PHONY: headers.chk > endif > > -headers.chk: $(AUTOINCS) > +headers.chk: $(LIBHEADERS) $(AUTOINCS) > > headers.lst: FORCE > @{ set -e; $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:43:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:43:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93714.176848 (Exim 4.92) (envelope-from ) id 1lIAjp-0000jo-9W; Fri, 05 Mar 2021 13:43:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93714.176848; Fri, 05 Mar 2021 13:43:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAjp-0000jh-48; Fri, 05 Mar 2021 13:43:29 +0000 Received: by outflank-mailman (input) for mailman id 93714; Fri, 05 Mar 2021 13:43:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAjn-0000jc-T3 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:43:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAjn-00073C-QO for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:43:27 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIAjn-00033f-Nu for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:43:27 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIAjj-0008Sq-Fn; Fri, 05 Mar 2021 13:43:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=ouQnAMoWXtR27g+cqZQHKPWR3HTi9bKIkcaxOUt0/is=; b=PGCXC6/zsjNV9Zc25r5cApDcQn gfce5EoYZzyXHuQiTglpJ83gZlwzEXR71AG5V4fJQRnW3mrv+LcqC3L87J9OKGIey3KqTfYPwx7Q5 nrWaliSYwRGoa/bmteFjUg6naoCH/BQq9748essX3QkT6wj6dFuaUO1CpUFS0X2YLcm8=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24642.13691.227259.144604@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 13:43:23 +0000 To: Andrew Cooper Cc: Xen-devel , Juergen Gross , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu Subject: Re: [PATCH 3/3] tools/libs: Fix headers.chk logic In-Reply-To: <291c999a-19aa-2863-8154-4acc1774b4b8@citrix.com> References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-4-andrew.cooper3@citrix.com> <291c999a-19aa-2863-8154-4acc1774b4b8@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("Re: [PATCH 3/3] tools/libs: Fix headers.chk logic"): > On 05/03/2021 12:49, Andrew Cooper wrote: > > c/s 4664034cd dropped the $(LIBHEADERSGLOB) dependency for the headers.chk > > rule, without replacing it. > > > > As headers.chk uses $^, a typical build looks like: > > > > andrewcoop@andrewcoop:/local/xen.git$ make -C tools/libs/devicemodel/ > > make: Entering directory '/local/xen.git/tools/libs/devicemodel' > > for i in ; do \ > > gcc -x c -ansi -Wall -Werror > > -I/local/xen.git/tools/libs/devicemodel/../../../tools/include \ > > -S -o /dev/null $i || exit 1; \ > > echo $i; \ > > done >headers.chk.new > > mv headers.chk.new headers.chk > > > > i.e. with an empty for loop, and checking only the $(AUTOINCS). > > > > Reinsert a $(LIBHEADERS) dependency. Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:45:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:45:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93717.176859 (Exim 4.92) (envelope-from ) id 1lIAm2-0000rM-K7; Fri, 05 Mar 2021 13:45:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93717.176859; Fri, 05 Mar 2021 13:45:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAm2-0000rF-H2; Fri, 05 Mar 2021 13:45:46 +0000 Received: by outflank-mailman (input) for mailman id 93717; Fri, 05 Mar 2021 13:45:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAm1-0000rA-Vp for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:45:46 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f77f0d07-863c-4cb3-b99d-fa1791666909; Fri, 05 Mar 2021 13:45:44 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DBDFDACCF; Fri, 5 Mar 2021 13:45:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f77f0d07-863c-4cb3-b99d-fa1791666909 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614951944; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QItXiLHhbawd4RWeqUi0SmHM2kV61WO9rM9s0jqHWGQ=; b=WueFinaiTEwXKPPQ7GRThskgJTID8gPJuwvNjb6zyP53qxLKEZvbxeJIdZgtEV+E55Duv7 6HTebr6D9okqtLVCTKxMQ1hfLNF5SJbTz+gzWxLbg45SlvkzfdFnRnfZk4cW65F9h4W358 x+8ycifR8TgsCC05sF8QPAE/BqVpo/M= Subject: Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Julien Grall Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-3-julien@xen.org> <0994b7a0-c537-b312-b134-caf54c79c87f@suse.com> From: Jan Beulich Message-ID: <74568cd7-143b-48ad-b9be-bf4229655376@suse.com> Date: Fri, 5 Mar 2021 14:45:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <0994b7a0-c537-b312-b134-caf54c79c87f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 05.03.2021 14:01, Jürgen Groß wrote: > On 05.03.21 13:40, Julien Grall wrote: >> From: Julien Grall >> --- a/tools/xenstore/utils.h >> +++ b/tools/xenstore/utils.h >> @@ -29,10 +29,12 @@ const char *dump_state_align(FILE *fp); >> >> #define PRINTF_ATTRIBUTE(a1, a2) __attribute__((format (printf, a1, a2))) >> >> -void barf(const char *fmt, ...) __attribute__((noreturn)); >> -void barf_perror(const char *fmt, ...) __attribute__((noreturn)); >> +#define __noreturn __attribute__((noreturn)) >> >> -extern void (*xprintf)(const char *fmt, ...); >> +void barf(const char *fmt, ...) __noreturn PRINTF_ATTRIBUTE(1, 2); >> +void barf_perror(const char *fmt, ...) __noreturn PRINTF_ATTRIBUTE(1, 2); >> + >> +extern void (*xprintf)(const char *fmt, ...) PRINTF_ATTRIBUTE(1, 2); > > ... the extern here would be dropped. But this isn't a function declaration, but that of a data object. With the extern dropped, a common symbol will appear in every CU. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:48:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:48:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93720.176870 (Exim 4.92) (envelope-from ) id 1lIAon-00010o-23; Fri, 05 Mar 2021 13:48:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93720.176870; Fri, 05 Mar 2021 13:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAom-00010h-VI; Fri, 05 Mar 2021 13:48:36 +0000 Received: by outflank-mailman (input) for mailman id 93720; Fri, 05 Mar 2021 13:48:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAom-00010a-06 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:48:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAok-00078z-6V; Fri, 05 Mar 2021 13:48:34 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lIAoj-0003W0-UY; Fri, 05 Mar 2021 13:48:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=dv+N6RdVDmczLpfjevY38fA9Jc+MVb2JB6pD52FpeZA=; b=WXNBY/AykSxch9tSX774p6J27/ pyfxfWMuRqn5GS5u8aWsTjNHW5cjs8OzTmy/b1HfVfN7OpqiGnT1r4ezXNFAhwzw3F6hgp1XJG3zK hNpoZNwQcH2tlij+4TG+Z3dF3d8JY64gIgXpAA7rhpjvVlzHnP1ITlylxVFJkrb5bKtk=; Subject: Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() To: Jan Beulich , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-3-julien@xen.org> <0994b7a0-c537-b312-b134-caf54c79c87f@suse.com> <74568cd7-143b-48ad-b9be-bf4229655376@suse.com> From: Julien Grall Message-ID: <7eb12174-3268-ccdb-df9c-c4fe23d3a332@xen.org> Date: Fri, 5 Mar 2021 13:48:32 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <74568cd7-143b-48ad-b9be-bf4229655376@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Jan, On 05/03/2021 13:45, Jan Beulich wrote: > On 05.03.2021 14:01, Jürgen Groß wrote: >> On 05.03.21 13:40, Julien Grall wrote: >>> From: Julien Grall >>> --- a/tools/xenstore/utils.h >>> +++ b/tools/xenstore/utils.h >>> @@ -29,10 +29,12 @@ const char *dump_state_align(FILE *fp); >>> >>> #define PRINTF_ATTRIBUTE(a1, a2) __attribute__((format (printf, a1, a2))) >>> >>> -void barf(const char *fmt, ...) __attribute__((noreturn)); >>> -void barf_perror(const char *fmt, ...) __attribute__((noreturn)); >>> +#define __noreturn __attribute__((noreturn)) >>> >>> -extern void (*xprintf)(const char *fmt, ...); >>> +void barf(const char *fmt, ...) __noreturn PRINTF_ATTRIBUTE(1, 2); >>> +void barf_perror(const char *fmt, ...) __noreturn PRINTF_ATTRIBUTE(1, 2); >>> + >>> +extern void (*xprintf)(const char *fmt, ...) PRINTF_ATTRIBUTE(1, 2); >> >> ... the extern here would be dropped. > > But this isn't a function declaration, but that of a data object. > With the extern dropped, a common symbol will appear in every CU. Urgh, you are right. Actually, the extern was added recently by Anthony: dacdbf7088d6a3705a9831e73991c2b14c519a65 ("tools/xenstore: mark variable in header as extern") I completely forgot it despite I needed to backport the patch to our downstream Xen. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:49:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:49:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93724.176883 (Exim 4.92) (envelope-from ) id 1lIApS-0001Ev-Bu; Fri, 05 Mar 2021 13:49:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93724.176883; Fri, 05 Mar 2021 13:49:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIApS-0001Eo-8Y; Fri, 05 Mar 2021 13:49:18 +0000 Received: by outflank-mailman (input) for mailman id 93724; Fri, 05 Mar 2021 13:49:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIApQ-0001Eg-GU for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:49:16 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7ede6fcd-7556-46bc-9bf6-e6636e77dd9f; Fri, 05 Mar 2021 13:49:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ede6fcd-7556-46bc-9bf6-e6636e77dd9f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614952155; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=k3ZIs3mseuS7LrOwKLH9sP0SqOp+precY0i6rm8p+ks=; b=HRgZNimgJF33mzgih9hZn9/yd8D1jNkIVs7t0E4NytFuqJqrY1feJnw7 Zpre9bZc3d4pT5vgnU6bh9Gxir0VX+TY/SeOtr3ayRBavOid4z+oATJyf M5aEYKSslCkwfFpRebnYBDSN5MHxnGVENLWy7tKczj3mShGEt/DNxa9/h g=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: vPIbbWU41yKwEh3SeL18d52kuTvNNU/y+wXWIm4uTsfqkYwj/4lPFPO1zct03FqEQTuZF2s8fR Xd1OS1Mv57QrkjQZXmqDvuCB8aaqI7QZrWiVG4IxkJx/LGXzReOa+Aff0lwrRD88iK7lmHJ5CU EHiNjFER7SLT4lGSOzaQXAY3f+rwM/gWoHObua8fhFT+Z3QvtJK9AP4QNu4XHy1DMIY97s+QPO fsrc9jinoh0huj+DlmNxB8093TS7cEiEDKiZL/kjaM+n5hjEZflA9aB54t3ktgSg7lBKx9PFRr Q0A= X-SBRS: 5.2 X-MesageID: 38551232 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,224,1610427600"; d="scan'208";a="38551232" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hGUyHfKNFSncMRkFTl6v9Fnrh+puBzLAYGxGP+vY5S8WbNyRAVcRpCsxZ2bSqu/AgOwEnbuPTPN/iVUISM6oe5aksOsCSglKxzPk1ZNQV09pH4+8NbBx6A0DbqdshZ/Shw+QdO8skYJBNNSIa0SuRgtidEualc6I+ZKwaHzEWNEvkzatvwwVCh7yIl0cfZwuAZJ1Ebmwg74OEErdmSSHbflYp6aFIVMb6hWoHdaArOQ4oncHGtWyGsIMU9dAoH1yDOMj0HR0qsxBlvwZAFMC2NW0u7BucRk9bjal03GCVTgjAPV2XEaL+R/teF0caMkklkxMfHBbuEEcrTgFI0nQ3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RuTTmgQf0YyiuQJRDFN+U13wsziN6B9FJBfsoWOI+zg=; b=OQNwnCVjEH9mJk2TaAcZJk/QgGpPqfXoEQkUW2XEOiGNWNA8QKdAzq/snmuM9zUelcu/9zNp7CAy4JZR8cuRwNb7sVB5JqTdZZCqQ3elOXKZCsRHIN8h2ScVYBOWnjjw5HrS8KYk55faTmjwvE1Yld5fMOsk1MB5WX+a9BUV96N5LMc2RAx02B52fwCHp5f/CDrKQ9absIAzSyLrDqTOX63rstT144MO08MtOrf6CDSF5495ARVHGeFHFOanI/NkFXXrouol/bIBRTEp1pHIXU+aKIf/JnIpTmvogTbuCJUcBFK9of8grBYs2G69M3V4FZqIK9jkT1KpVDGhKTNHDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RuTTmgQf0YyiuQJRDFN+U13wsziN6B9FJBfsoWOI+zg=; b=kLk7/iV8tDyEzuEsPMAhD67J9+YM7Uf6fD29CkLRLrZim0LP2hoS10Dd6PwxPSOtk1WKI7zjOTVbsgn4/DnbtM0KnOegBmW1MR5niZR2UP+/cpmMsJgQn9V1cgUarV5fHHb4TBKccI0kClFMPr+WN9Ax3+g7iCdAFoTtPxA7Fqk= Subject: Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() To: Jan Beulich , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Julien Grall CC: , , Julien Grall , Wei Liu , References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-3-julien@xen.org> <0994b7a0-c537-b312-b134-caf54c79c87f@suse.com> <74568cd7-143b-48ad-b9be-bf4229655376@suse.com> From: Andrew Cooper Message-ID: Date: Fri, 5 Mar 2021 13:48:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <74568cd7-143b-48ad-b9be-bf4229655376@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LNXP265CA0019.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::31) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7d39844d-d36c-4618-b405-08d8dfdd5771 X-MS-TrafficTypeDiagnostic: BYAPR03MB3494: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FarLoOMqnOodN+XhEcJHm7p+V11F2lDcOSUdymMFGDbkjM7dG5kPLFuQsXNVPkHewOBFKBRWyk9zGDJX8AU75Y8jCzj0X9g7AuqezHIogb9r5ZYonDv9D/TdY8lv9/UFb/6QhICO0DNAYtLGvIIXcPtgxr2ZedkDmQSKdvFL+JXb07BdZJNSQJeoDRwyVXVtoI+J5zATfpE/k+irYIfcbodqObN+P1CYB7XGZ75y1PRhUUj1ryb2JlhjYekQQJEtOYh4fllKNUj1P7Ic9qDvVYf5DpFKAXyxt70nGmOxssZCqTKxga6kZL8UOcyc881nUhYWkkB8uH5KtwdlTTIZ/KKSlnpplDJTNhiByyKPR8uczhaU41TyVGwWItp3F51q8u/h5XmmX/OBxBAAkCAmOTRWoHkY0sUMcH521HTjPV5ytl0irHgJiu3Yhaaq6c2ftMPVbs4XzCX0Rf168T/h6WJdyqAj/7TWHJoEw7T9t2PnTVTNL870oiwdPS8isnZ+qoivMfGRwpj5fWWmcnOCcnEwV+jXxUQTbovNFcJGCmK8jPlUAabZPkGc62F4Ga3bZKbO0glgW87/q28/LetsqJeVxaWbO445owQi8l4As44= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(396003)(346002)(136003)(39860400002)(31696002)(6486002)(186003)(110136005)(26005)(5660300002)(8676002)(956004)(316002)(83380400001)(16576012)(478600001)(4326008)(53546011)(16526019)(54906003)(31686004)(66946007)(86362001)(66574015)(2906002)(8936002)(6666004)(66556008)(2616005)(66476007)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aWRhUm96LzMybkhMRFpTa2d2UXJrdjBHaE9teGhqU2NlYU1lR2tMdGdiMFdS?= =?utf-8?B?dk9hbCszVldJMGI5NEZHQTRzV3FaZk5TcnlPdVNWcFhsQnJ0aXYrdXNQMDVM?= =?utf-8?B?eE4wT1Z2c3N3dDZCUjVPVVMxSHpYNUJydmpXaVNWQi9hdElpdnJySzdEdVBH?= =?utf-8?B?bVhtUkdUQzdzMy95U2hYdmk3WFV6MkxmTUg0OTlkUCtiM3VSSzJWai8wMy9V?= =?utf-8?B?TjVEampFL0hSVVJKRVZGcHovcWlIU0RRNjJKZHZKOHRCVE93djFBbWNlTExw?= =?utf-8?B?R0xYaVBZOUo3bEVkeGlDVDNzd0VYTFNCOVBrenAyVlM5Y0RKbmdxZW9WZXZr?= =?utf-8?B?WTlHdzBSdjhIbVo5MFRWZTNJTzZjMHErK2ppaHpuVVYxOE5GMGVCczFkdGEy?= =?utf-8?B?Y1Z4UnZ5QmIxSHZQQTcwT3N2NHRCenNIeFE4ZUNHWm5pTVBUT1NaNThnaUVt?= =?utf-8?B?a3RGK2xuU1FlQlhRQU4zUG0rYm5JVm8zZWdYYmRIYklaM0g4RHgwWGoybytK?= =?utf-8?B?TGlsc0pMeTlVbzBGNWE5Vm04S3VxTjRqSUtaYms3b2xwUlRIZUJKa1h2QWVV?= =?utf-8?B?TzBFeHlCK04yRG9kWEU3eCtXYzBld1ZLM0JHM1FGZHptNUF4VlljSFpwNEJy?= =?utf-8?B?TTY4RDg0U1VXYTBtdmpOWE11RUwxaWZTQi9ycStHdFA3aGo2T2F1c2J0VTJE?= =?utf-8?B?VitvbEw0aERCamthR1pJckR6dmY0UWhYdWp2VEFVWTlFMDlVMUJHcVh3bWtq?= =?utf-8?B?Vjl6NmE4S0tCTUNid1NCdUpneHdlRUsxQkFZWGIzMldleFo5MGNwYVFCWHlN?= =?utf-8?B?Z3E3Qno3OTRhcktoalRTTmVpWnVaNXN1WTVWcDM2dmtzcC9xdEpjZUlJVWly?= =?utf-8?B?SDRPVjRRRVFsSWhDOEdIb2dUV2ZxVWVoaFFLWmdGZHU5Q0NkQW1idTJLMVFQ?= =?utf-8?B?RnA2Qis3R2w5THJSb0pPYXc1UmRLQVFGalFtNWZ3TEZyWHZpc2w0T1AvOTJC?= =?utf-8?B?ZEQ3TFlNakZ1R2VUQ0w2S3BGNEx1NFdkTDRLaUFtWjI0RTZ2ZFJmUG5GNy9L?= =?utf-8?B?OUF3SmVLd0Nmd2FBU2tORnFpWGZaTEsvUmNUcmVKL09VSHRuT3JKSHBJUTZn?= =?utf-8?B?L1FrZ3FrMkhJV25jcEV4NlhXeEladkZxVHY4THJ4ZXM1NVczcVZBcEl0NGZ6?= =?utf-8?B?ZldFQUVyc3psOTh6ZEZpaE9Ka01QZStpTllBYVc0bkNlRXVnYnpaTGlNQ2hS?= =?utf-8?B?UG52N0FIWGZhWitHblcvNWVMeWlkeE1XQm82eGQyTHkzRnJleXZKMERieFY4?= =?utf-8?B?MStzeWNJOTBNRkQ3dEdkSE94SGRvWm1oc2oxeTNUQVkwdWJad0xRR01vam5l?= =?utf-8?B?RVJ6UXRJQXlEUVJ5ZmZaMHpvRTdCM2kwRXdCTnc3SmVVeGZwZ1VOVk1CWUF2?= =?utf-8?B?MXJKWDJWMVd2OFI1OGFuNXJQNVdNbVJYUUFWdVhxSmlsZXRmVXl1c3g4QTNN?= =?utf-8?B?VTFrMWFyOTRLbGdGU3ZKa0dsNW1NQ0ZRNkxhV2hSL0UwbCtKN3IyZEwwMHJk?= =?utf-8?B?NjlVZDVCdDY3QzhOVFNnVU55U09rQmZ4cGxKUHRQMUNaUUNtRXJ1QVFzNUhr?= =?utf-8?B?L2JENStnSC9PS2puVE5BZ3NseVArTjczd1VLZXZIa1pzMEoveksxam1FaTYy?= =?utf-8?B?MzNiWm9WWGhvWjd3dkhGQXV1ZmliN3Vqa0J4NlZDZ3VHcWdsTmRpVHFBbUlO?= =?utf-8?Q?U56nVNQjKNcObXA4eHtjx4ZGMiQY6OsEcpKDWue?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7d39844d-d36c-4618-b405-08d8dfdd5771 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2021 13:48:22.2769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /QdJq2Bp7qpYouJZzTqRum+/xuLI48lFHyBRfstgbltIE7GPbQ7zYR5sBzbkpeBZP2GjW54APDdMRdPzYPrJt+Cl/CIGzGpgV6EYhPlKGqc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3494 X-OriginatorOrg: citrix.com On 05/03/2021 13:45, Jan Beulich wrote: > On 05.03.2021 14:01, Jürgen Groß wrote: >> On 05.03.21 13:40, Julien Grall wrote: >>> From: Julien Grall >>> --- a/tools/xenstore/utils.h >>> +++ b/tools/xenstore/utils.h >>> @@ -29,10 +29,12 @@ const char *dump_state_align(FILE *fp); >>> >>> #define PRINTF_ATTRIBUTE(a1, a2) __attribute__((format (printf, a1, a2))) >>> >>> -void barf(const char *fmt, ...) __attribute__((noreturn)); >>> -void barf_perror(const char *fmt, ...) __attribute__((noreturn)); >>> +#define __noreturn __attribute__((noreturn)) >>> >>> -extern void (*xprintf)(const char *fmt, ...); >>> +void barf(const char *fmt, ...) __noreturn PRINTF_ATTRIBUTE(1, 2); >>> +void barf_perror(const char *fmt, ...) __noreturn PRINTF_ATTRIBUTE(1, 2); >>> + >>> +extern void (*xprintf)(const char *fmt, ...) PRINTF_ATTRIBUTE(1, 2); >> ... the extern here would be dropped. > But this isn't a function declaration, but that of a data object. > With the extern dropped, a common symbol will appear in every CU. Correct, and some of the containers in Gitlab CI really ought to notice because GCC 9(? IIRC) defaulted to -fno-common. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:54:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:54:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93727.176895 (Exim 4.92) (envelope-from ) id 1lIAu1-000274-Vb; Fri, 05 Mar 2021 13:54:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93727.176895; Fri, 05 Mar 2021 13:54:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAu1-00026x-Rt; Fri, 05 Mar 2021 13:54:01 +0000 Received: by outflank-mailman (input) for mailman id 93727; Fri, 05 Mar 2021 13:54:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAu0-00026p-95 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:54:00 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 07bafc3f-8c11-433f-becc-d4ec35d47e08; Fri, 05 Mar 2021 13:53:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A8145AD73; Fri, 5 Mar 2021 13:53:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07bafc3f-8c11-433f-becc-d4ec35d47e08 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614952438; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B+aJikjIHMoZvlv3QKPajBjgFVCPPf7CauYprTe52Ec=; b=Rp84SWD8DN0x/cyeUalgaP5uRHg4A8YE07LOIPpeS8dRLEr7hGZIW1VxXdEk76UcP15TQH UjvMOyPl/Qva6+rK/myepyEYf2U8wmz9N6104ECRvZppAHOnFIFo8WsQyjIuJaR3wTmD79 qaU9h3opMsULsU2ivBD6+bcxHykQQ8s= Subject: Re: [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Ian Jackson , Xen-devel References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-3-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <9b4acfc5-6d96-7922-7fde-5d0d543f8201@suse.com> Date: Fri, 5 Mar 2021 14:53:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210305124949.6719-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05.03.2021 13:49, Andrew Cooper wrote: > Exactly as with c/s f40e1c52e4, this is inappropriate for a stable library. > > That change actually broke the build with: > > include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t' > ioservid_t *id); > ^ > > as libxendevicemodel.h now uses a type it can't see a typedef for. However, > nothing noticed because the header.chk logic is also broken (fixed > subsequently). While I agree up to here, ... > Strip the guard from the public header, and remove compensation from > devicemodel's private.h ... I'm unconvinced that entirely dropping the guard from the public header is wanted (or needed): We use these to make clear that in particular kernels aren't supposed to make use of the enclosed entities. If a type needs exposing, it (and only it) wants moving ou of the guarded region imo. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 05 13:58:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 13:58:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93730.176906 (Exim 4.92) (envelope-from ) id 1lIAyb-0002HV-IJ; Fri, 05 Mar 2021 13:58:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93730.176906; Fri, 05 Mar 2021 13:58:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAyb-0002HO-Eo; Fri, 05 Mar 2021 13:58:45 +0000 Received: by outflank-mailman (input) for mailman id 93730; Fri, 05 Mar 2021 13:58:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAya-0002HJ-E6 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:58:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAya-0007Ji-AH for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:58:44 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIAya-0004Hx-9K for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:58:44 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIAyO-0008WR-Ad; Fri, 05 Mar 2021 13:58:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=JbLIdJa8ltxCPlR7yJ6aaM9xgZFJx/500fdHj3QwQUg=; b=ITg8grlM+mLqyQSaXPjuuLIyDx AvEGVGSHKNEth/tIb3TGL2jBjnUaWIjlm2i49aV23PpJx0OW4iGpAKsuv2DCnlg33d4traLCDPEcd PwuFiS0yUa8Y1PsG0azP1SrpHYlUAaeccbj8st1YZFleeSHuXqEUNLYewdegb/X6Xx5k=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24642.14600.124181.19574@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 13:58:32 +0000 To: Julien Grall Cc: Jan Beulich , =?iso-8859-1?Q?J=FCrgen_Gro=DF?= , raphning@amazon.co.uk, Julien Grall , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() In-Reply-To: <7eb12174-3268-ccdb-df9c-c4fe23d3a332@xen.org> References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-3-julien@xen.org> <0994b7a0-c537-b312-b134-caf54c79c87f@suse.com> <74568cd7-143b-48ad-b9be-bf4229655376@suse.com> <7eb12174-3268-ccdb-df9c-c4fe23d3a332@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}()"): > Urgh, you are right. Actually, the extern was added recently by Anthony: > > dacdbf7088d6a3705a9831e73991c2b14c519a65 ("tools/xenstore: mark variable > in header as extern") > > I completely forgot it despite I needed to backport the patch to our > downstream Xen. How horrible. Maybe we could add a comment to the code, next to the declaration, about this crazy situation. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 05 14:01:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 14:01:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93738.176939 (Exim 4.92) (envelope-from ) id 1lIB1T-0003R1-7D; Fri, 05 Mar 2021 14:01:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93738.176939; Fri, 05 Mar 2021 14:01:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIB1T-0003Qu-2v; Fri, 05 Mar 2021 14:01:43 +0000 Received: by outflank-mailman (input) for mailman id 93738; Fri, 05 Mar 2021 14:01:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIB1R-0003Qm-Mb; Fri, 05 Mar 2021 14:01:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIB1R-0007Sg-IJ; Fri, 05 Mar 2021 14:01:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIB1R-0007dh-58; Fri, 05 Mar 2021 14:01:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIB1R-0004sp-4e; Fri, 05 Mar 2021 14:01:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9Au5NxIVuzMi/N6EH9R91REUJSeT5fPzio5+7pzOy5g=; b=AYGitYsW86II0FBVYTLvyFRcrU jwkneQUm0elJ+kM+rpeL7vzdNYBHPq98sshEH/AgQm1HoHHWBfXZ3DvnlMGVQPn0GGXpZevHR5pHl 4pEPnMnohtOsF769uv760spqMfg4H8duFafYMKL9WYMPk9I+qUE4LfGN563IsU1TDc1Y=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159831: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f40e1c52e4e0a3e084b025ed6b68f1e6ebaea027 X-Osstest-Versions-That: xen=243036df0d55673de59c214e240b9b914d278b65 From: osstest service owner Date: Fri, 05 Mar 2021 14:01:41 +0000 flight 159831 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/159831/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 159820 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159825 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159825 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159825 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159825 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159825 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159825 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159825 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159825 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159825 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159825 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159825 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen f40e1c52e4e0a3e084b025ed6b68f1e6ebaea027 baseline version: xen 243036df0d55673de59c214e240b9b914d278b65 Last test of basis 159825 2021-03-04 08:50:06 Z 1 days Testing same since 159831 2021-03-04 20:38:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 243036df0d..f40e1c52e4 f40e1c52e4e0a3e084b025ed6b68f1e6ebaea027 -> master From xen-devel-bounces@lists.xenproject.org Fri Mar 05 14:13:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 14:13:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93748.176954 (Exim 4.92) (envelope-from ) id 1lIBCX-0004W0-Cq; Fri, 05 Mar 2021 14:13:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93748.176954; Fri, 05 Mar 2021 14:13:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBCX-0004Vt-9S; Fri, 05 Mar 2021 14:13:09 +0000 Received: by outflank-mailman (input) for mailman id 93748; Fri, 05 Mar 2021 14:13:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBCV-0004Vo-SX for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:13:07 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4fcc8a2b-bb9f-4e8d-9f61-1891cc0f93b1; Fri, 05 Mar 2021 14:13:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4fcc8a2b-bb9f-4e8d-9f61-1891cc0f93b1 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614953586; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=GBwMzzIBv2c51cbGOKnUT/yzJPxd8UcPS5r3U2+XnNQ=; b=bCdZVc/b8WSXK4dclEE298pQBv/OBeDIvCxNB2IoLuxw3o74y0osxTa+ a/nGiDnVyIr5F0KIsbnDxMbyUJ/soq4/q44aOq5CET6Cz4FbWvkLQmrvh PYYgN0sAWCtR8G2oV3y09DEhZlvil7kYuf6r9mvtULfq2Vft8doQH74On Y=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: WvWV7ACoavcuhoL/Ftfuevooblrkv2p8d6+rVpS92f0ZSdDok5VkNpZTmBcvt1wzrdBXpdwHyz qkmnvqzBgtdqNYyNvrhCbz00BwPJ0LsJS+k7Ug1LO6vCbFbNEZAHCnJkBs83pkxL1mG8UnQkV5 tQM+RJBVUgRsy9vRpFdIyjmnOcA28V08UyJXUy1yGj9ZaZnomfMijDI9Efh32vgwuS7hz1HLIZ Y7v5SyhCJHTG5ebTnd+C2bx6pjZ+jBqDXUpy5BrdtCwg55rSGDuNvY8+BDKlONkKfnu0447WGz 66s= X-SBRS: 5.2 X-MesageID: 38650209 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,225,1610427600"; d="scan'208";a="38650209" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kpMBc+AGYHC6fwqQ6lJd9NVHdM8O5a5qNKdpOPEJwaOK5xjmYVWohl+uwPGVtTEQhy44xBrezNk90sItA2oOGpUsCn+5gSm4HrALpHf6NAPnw+t4fgtELeg3ulHLcVrQRUcOpZHewgKgQT4ooJND355ftMPasxc68yy1DtwbMZeQ0UuaxEnDiv/K9AxUXzKcFXjtgxvr+BMOyVvg1pzo3DRaj4s5qTCeOB+gJpKA0/dS5fT1rFRbVSrEN6fA/4k9eJ/RsneajO/HGXgP1IJxXUjpVacelmClABGXykv+jbod+Qhg/AH7OQ+wWfCsmOsgkpZo1f0p+guv2LGe8JP3aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=db6kB8vegPIS52yAWhLRx1GVwoRd6y5faVL6HOqWIH8=; b=m7sqExvWx8d+5eJ9Tqc2DR3ECusgSvpOvnDgC2tviB68E9Q8ubfuav8xNYo64W694riU1DDILWqmAJx5w+fZMKdAcoAd2qTmTP/nBEicB3sdNzykRDL0KFqLsv6Wxj7HuL4LCRW4MGmj+thVHkQDtemTHMTGyoRF86JmZmJ60VSK3Iqf/+6Mnd5wbM5TjP5YmARr78KFRtpe0t8G+UEHsEsARaA1em1C6S1YPP0Bjrav/iaPLfv2Qwa3YWHU3S638E4VN4UnonP4ZxbJ/fOZ6oVzZY07XW4BSI+SQPkHMdbKQGHIAcJ2ZAC30Hxm/22nJ6QNLS9IKeNcYelV74+lcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=db6kB8vegPIS52yAWhLRx1GVwoRd6y5faVL6HOqWIH8=; b=uJeCpaGFjn9dwoA3IK0jtWkVDAOhcb5V78TkCDDb34MTZwFMOt+XPQy6JKqSQ/WDbQN7II2KiPHhVY2laF+zvXGEcTa4RzZWs+jK100r1LgGg3FHQ1jBnpbVYgvaFmQUakxKoLj+AKegVgVFCkGshhtOGMud9VSuqyXZXgUvp2A= To: Jan Beulich CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Ian Jackson , Xen-devel References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-3-andrew.cooper3@citrix.com> <9b4acfc5-6d96-7922-7fde-5d0d543f8201@suse.com> From: Andrew Cooper Subject: Re: [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API Message-ID: <68a69e57-66b5-6f59-39f4-40649112fe40@citrix.com> Date: Fri, 5 Mar 2021 14:12:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <9b4acfc5-6d96-7922-7fde-5d0d543f8201@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0057.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::8) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ccb14c86-05cb-4f66-07a2-08d8dfe0c762 X-MS-TrafficTypeDiagnostic: BYAPR03MB4744: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tjRaQUeTPcY2elaib/tR7QFD3wZcOkqUqBRWnuReGTRZxVQ4301gkmfi9Nw3E7NpHIsUdeLjmBREHCSQkFw8Uy30rZCGclNFR2G1384vl/oqO8PLmNM4TFfrbfESjmZVqsKf0ezaywmPhawC5gMXn+apSap23L3Oo7bqrqPTSx5f+psOGYwmQ85lMFhzHIh2iGjuCTJWuH/3ulom/m9ApvjxAoc8tPact2CKfw7dIHuk2QUvLR0kOH72SipE1uQlFtZ1wteCRB7wsbsuXhTGsJeA2eTBEb3Ln85nFdF9jHxlE2UEGB63BAi1p/RPam4nV/2MqFx37DWnkpa9JJ1oBooAQV9luvqOKmM5TPcr+YUmCUWbNF0VGKiskaebV1FU2gfccxRUFFlCPRhwJhnQwTVfm9Vz6t66AmLZlm/piEMKJsR5DXB2aLDUszu5cBdjW4PrcLTtOL23Gmv+7ODWOmFonAElS5JcjgfF8SrSuGn12Oxm7JMxWGt0tds/WvdCx2FijeYYuOSzBhISUJyE/ASNYdZQA0r3vK2QdF+GAjWg9zuBBHWCmrsUgpKkaDongLxQXcLR6xwsSrc++L9rNfL7OjQ+SqUV6Mxsx0REvaA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(136003)(39860400002)(366004)(396003)(31696002)(36756003)(86362001)(53546011)(8676002)(2616005)(6666004)(26005)(8936002)(54906003)(316002)(956004)(16526019)(186003)(4326008)(6486002)(478600001)(16576012)(6916009)(2906002)(66556008)(31686004)(66476007)(66946007)(5660300002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NHRkYm1CeU1ISzhKRDFvQ0RKcmVya2ptQUgySzhLUUJyNlhkUlJyWm1LbytF?= =?utf-8?B?alc3S25vVC85Y1ZHNmgwYlNBWTk4OUxVM1RRdEFFVjhPbzVkNkxWck5TRlRo?= =?utf-8?B?a1I1M0tiU2FuQUJIczBRd3RodG9hMk5wL3JDTnF2MXNqbnV5T3U2ZG5zbGZL?= =?utf-8?B?UmROS05VYnNOdTFQWXFWZzlzcjdVREFycGliYm1zeWw5MWRIM1A0enNsTFN1?= =?utf-8?B?OUNCSVUyYnNkZFF1Sk1GaGU4eWpzN0JaNWVmTVVmTXhXa0tPalFySENsRFJy?= =?utf-8?B?V2ZvYUFlOWJybDR1cmpDcU9wN1FFVy9vR0t0TUhFZDNzekN1aCtwOFdJdWdn?= =?utf-8?B?UlorOWV3d3RCK0R0a3FSOE85b0hzY2dRdDJSd0wwVFRUMmNwWTlSVUpxVzFH?= =?utf-8?B?Smh6VHpzTFVsMUVDbTBjS3pBbGswMEZ3ZHJwdU5QNHhmS1VHa2t0THNWQlIr?= =?utf-8?B?aFIyeEZuMTRrZzdvanhyTklkN1dxYkIzK3BmMnI2ODhzZ1ZNOWxjN051RFZo?= =?utf-8?B?VUt0bzBsb3NvTENvYTFCeEUyZFhNV0dsZkdwY3ZPZjNCQmhmdytRUVptSTV6?= =?utf-8?B?NTFMRmZudm5WblROUVpJT2dybUgvRGovZlJQa04zaDc0L0VlVHk3QjlVNjBQ?= =?utf-8?B?N2FSbVpWRkUxRzdiM3hMdzdReks1c1YvUTU2Qm1tWWlOWC9aQzY4QWl0bDZZ?= =?utf-8?B?Nzk5eUM5WmQ0WlR6dDI1V2ZQaWF0a0VGQW9pQnRPaUVIOTZuanVEbWFXWUlt?= =?utf-8?B?YUtlbXdGRkVDTzNMdTFwNGZPVDFBcEZnWng0YjBZaGFYZDdkYit2YndUQXdz?= =?utf-8?B?NlZuVlpSVVlBWkJ5akVZVy92aEJGZlVBM0F0NTFvWXl3WG00dGhMTGl6Rkg5?= =?utf-8?B?M2hna0VNanVXcFpHbUhiUUluTERFaGd4bzV1SGl0cUExRlovNS9HNWVKdmNN?= =?utf-8?B?T3d5dXpLaEZMQ2xDMUROem1MMlhYTVoydGo3aExWRDFyR3FWU3hvWmpLdFZh?= =?utf-8?B?OFNoZjhYQnBibVU1N0gxd3FBOHpCSFJPVmJmT1JIYWN5aStLUzB5bk5qUTVm?= =?utf-8?B?Nzh6RS9LYWRKMEU4aGRwNDVZMGM1alNJajlsRVhmSUJicmhCdFk2RjRNaXBl?= =?utf-8?B?SDNEUUtraXJ4VG5tblRqRFZpeXJyN3BOUWlsRVVtV3QyWkE1NTBHaXl6Z2ta?= =?utf-8?B?Z1ZkVzNBR0NBdVU1a0hPQ2J5T1d6L3Irc1Jhd2lLbW9WQ2hyUjU1UUE5RnZW?= =?utf-8?B?QkZUN0xGbUt5S1NtSnd1L0EyNmhKOHZOWURmYm1HWWZHVW8wNjUxOThKRTVZ?= =?utf-8?B?RjBxMC9xVWwwdHZVeDI5WVRibkJHMmFPdGswTHZ5Umc3ZXNRbXZnUVIreXpO?= =?utf-8?B?ODBBUXhFWms5Z2hDNzgzVUYvaU4zOTRVRUxqVy8xdU5QMDkyNHM1cFpsaHdY?= =?utf-8?B?ekV5Q1k2c1FrU3J0UndXTGVjUXZGa0M0cjdoMU9FVWFLTTJoMXhxaWNUYlJj?= =?utf-8?B?MXNnMURGMS9oM1REbjA1WkJScGhpWFZ0YTJBMlFsVms4M0tqdk9HSEJxMldG?= =?utf-8?B?K0pWR3hSb2RIS0x1N0wwdmRXd21FdkNmZ0FjR2g5a0V4ckFZNUo0b1QwdnI3?= =?utf-8?B?M1RzTGZhNUNzWS9vRG1UdGFzSnBDbjcyRjVvOUc4ZW5BVFgrNTEvdlM3eHkz?= =?utf-8?B?YTZqTlMvQ1d6OTk5MFN1Q0FTU1didGlHYXU1V0tpVjlnb3lZV3UydXU3b2li?= =?utf-8?Q?XKOJcOu9nsZ1KYbl0BEsCCy+wY8LNi6m2GlCzHP?= X-MS-Exchange-CrossTenant-Network-Message-Id: ccb14c86-05cb-4f66-07a2-08d8dfe0c762 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2021 14:12:58.5253 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fQXhCCiNZz9npAr3D538g5VX5oFagMBfvrikqnFtd5zbLPntgwFJnCPIlTfHcmbvaarmf934U0ySEAvoar2TYzkptjz+sJG4y1GHtaFbcxw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4744 X-OriginatorOrg: citrix.com On 05/03/2021 13:53, Jan Beulich wrote: > On 05.03.2021 13:49, Andrew Cooper wrote: >> Exactly as with c/s f40e1c52e4, this is inappropriate for a stable libra= ry. >> >> That change actually broke the build with: >> >> include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t' >> ioservid_t *id); >> ^ >> >> as libxendevicemodel.h now uses a type it can't see a typedef for. Howe= ver, >> nothing noticed because the header.chk logic is also broken (fixed >> subsequently). > While I agree up to here, ... > >> Strip the guard from the public header, and remove compensation from >> devicemodel's private.h > ... I'm unconvinced that entirely dropping the guard from the > public header is wanted (or needed): We use these to make clear > that in particular kernels aren't supposed to make use of the > enclosed entities. If a type needs exposing, it (and only it) > wants moving ou of the guarded region imo. DMOP was invented specifically so a kernel module (i915, for Intel gVT-g) was independent of the domctl ABI version. Improving the life of dom0 userspace was an intended consequence, but not the driving force behind the change. Exactly the same is true for stubdoms currently, and I am very serious about purging unstable interfaces eventually. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 05 14:19:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 14:19:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93751.176966 (Exim 4.92) (envelope-from ) id 1lIBI7-0004gu-1x; Fri, 05 Mar 2021 14:18:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93751.176966; Fri, 05 Mar 2021 14:18:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBI6-0004gn-Uh; Fri, 05 Mar 2021 14:18:54 +0000 Received: by outflank-mailman (input) for mailman id 93751; Fri, 05 Mar 2021 14:18:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBI5-0004gi-D1 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:18:53 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9a3542f2-71ac-4141-b035-6ccc909632b1; Fri, 05 Mar 2021 14:18:52 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id ABE76AE7F; Fri, 5 Mar 2021 14:18:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a3542f2-71ac-4141-b035-6ccc909632b1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614953931; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QE1oMHfMKIpHXiWkPNaaeJeFc0FNto2L7oIYC8PMrvo=; b=dgnJePxPf/ZM+Uz4tUswa0cic21pRxRrI23cUdCe7Mf1HhclutIGP9NAJsS+i6CxJAKMOs aV4WnBuwITdIjVIQR4LEf5qJGx+63XLcGCCmPYsD7IGFT3oOHzuSiU3eLfoPKTKozG7Q15 ryYs3tJVImN/GqZKu9c1MKdRBt13upw= Subject: Re: [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Ian Jackson , Xen-devel References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-3-andrew.cooper3@citrix.com> <9b4acfc5-6d96-7922-7fde-5d0d543f8201@suse.com> <68a69e57-66b5-6f59-39f4-40649112fe40@citrix.com> From: Jan Beulich Message-ID: <6b9fa11e-353e-8e10-8bec-f5c7930aae94@suse.com> Date: Fri, 5 Mar 2021 15:18:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <68a69e57-66b5-6f59-39f4-40649112fe40@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05.03.2021 15:12, Andrew Cooper wrote: > On 05/03/2021 13:53, Jan Beulich wrote: >> On 05.03.2021 13:49, Andrew Cooper wrote: >>> Exactly as with c/s f40e1c52e4, this is inappropriate for a stable library. >>> >>> That change actually broke the build with: >>> >>> include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t' >>> ioservid_t *id); >>> ^ >>> >>> as libxendevicemodel.h now uses a type it can't see a typedef for. However, >>> nothing noticed because the header.chk logic is also broken (fixed >>> subsequently). >> While I agree up to here, ... >> >>> Strip the guard from the public header, and remove compensation from >>> devicemodel's private.h >> ... I'm unconvinced that entirely dropping the guard from the >> public header is wanted (or needed): We use these to make clear >> that in particular kernels aren't supposed to make use of the >> enclosed entities. If a type needs exposing, it (and only it) >> wants moving ou of the guarded region imo. > > DMOP was invented specifically so a kernel module (i915, for Intel > gVT-g) was independent of the domctl ABI version. > > Improving the life of dom0 userspace was an intended consequence, but > not the driving force behind the change. This is news to me - so far it had been my understanding that it was introduced to have a way for the kernel to audit and hand on requests to the hypervisor without needing to know all the inner details. I wasn't even aware a kernel module was using any of these. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 05 14:21:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 14:21:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93756.176978 (Exim 4.92) (envelope-from ) id 1lIBL0-0005fP-H2; Fri, 05 Mar 2021 14:21:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93756.176978; Fri, 05 Mar 2021 14:21:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBL0-0005fI-DB; Fri, 05 Mar 2021 14:21:54 +0000 Received: by outflank-mailman (input) for mailman id 93756; Fri, 05 Mar 2021 14:21:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBKz-0005fD-PO for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:21:53 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e44b34a9-e64c-4c3b-9119-643131566e71; Fri, 05 Mar 2021 14:21:53 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 70C19ACCF; Fri, 5 Mar 2021 14:21:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e44b34a9-e64c-4c3b-9119-643131566e71 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614954112; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Maf5+seAJP9houpVGhSc0Pz3xlkC2RXDJ/2J8QqQ8vM=; b=JuQ1ZR1sqlCgcZyXjZY79N6BoZm9dQmSEO9+JsGljM8tyrKSBm8QdF71Y2a9abdeD+NJx6 pUYx/OliE8XI8fpfwNsO5E7nWYdw2jckrkLpI/FS3qg+b0Jbpf3n+tR2KDqCuOvqxkOQ2j M9/Aj760SNxC6gogMQVqPtxh7KGzAfs= Subject: Re: [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API From: Jan Beulich To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Ian Jackson , Xen-devel References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-3-andrew.cooper3@citrix.com> <9b4acfc5-6d96-7922-7fde-5d0d543f8201@suse.com> <68a69e57-66b5-6f59-39f4-40649112fe40@citrix.com> <6b9fa11e-353e-8e10-8bec-f5c7930aae94@suse.com> Message-ID: <0e0fe64c-0834-a3e9-e85c-c17d8a510941@suse.com> Date: Fri, 5 Mar 2021 15:21:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <6b9fa11e-353e-8e10-8bec-f5c7930aae94@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05.03.2021 15:18, Jan Beulich wrote: > On 05.03.2021 15:12, Andrew Cooper wrote: >> On 05/03/2021 13:53, Jan Beulich wrote: >>> On 05.03.2021 13:49, Andrew Cooper wrote: >>>> Exactly as with c/s f40e1c52e4, this is inappropriate for a stable library. >>>> >>>> That change actually broke the build with: >>>> >>>> include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t' >>>> ioservid_t *id); >>>> ^ >>>> >>>> as libxendevicemodel.h now uses a type it can't see a typedef for. However, >>>> nothing noticed because the header.chk logic is also broken (fixed >>>> subsequently). >>> While I agree up to here, ... >>> >>>> Strip the guard from the public header, and remove compensation from >>>> devicemodel's private.h >>> ... I'm unconvinced that entirely dropping the guard from the >>> public header is wanted (or needed): We use these to make clear >>> that in particular kernels aren't supposed to make use of the >>> enclosed entities. If a type needs exposing, it (and only it) >>> wants moving ou of the guarded region imo. >> >> DMOP was invented specifically so a kernel module (i915, for Intel >> gVT-g) was independent of the domctl ABI version. >> >> Improving the life of dom0 userspace was an intended consequence, but >> not the driving force behind the change. > > This is news to me - so far it had been my understanding that it > was introduced to have a way for the kernel to audit and hand on > requests to the hypervisor without needing to know all the inner > details. I wasn't even aware a kernel module was using any of > these. And indeed, quote from docs/designs/dmop.markdown: "The aim of DMOP is to prevent a compromised device model from compromising domains other than the one it is providing emulation for (which is therefore likely already compromised)." And it goes on discussing only the purpose that I've been aware of. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 05 14:29:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 14:29:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93759.176990 (Exim 4.92) (envelope-from ) id 1lIBRm-0005qj-8H; Fri, 05 Mar 2021 14:28:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93759.176990; Fri, 05 Mar 2021 14:28:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBRm-0005qc-52; Fri, 05 Mar 2021 14:28:54 +0000 Received: by outflank-mailman (input) for mailman id 93759; Fri, 05 Mar 2021 14:28:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBRk-0005qX-PM for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:28:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBRk-0007w0-Mt for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:28:52 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIBRk-0006rQ-KR for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:28:52 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIBRa-0000BB-DX; Fri, 05 Mar 2021 14:28:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=HmdyoUkvVh6m6lSYy4eOVmyqFa7WnmbTYwXUvL/RqMc=; b=muWW6eIXcwvaDHcqhFTecSLNyD 0u9O57v5LMJ1mQyCq9hmH9GN3iJGCowgkw53mBOIC8WhqppJHwJ0P3U5Nomi+fpYXvThG43waVDAb I7p2ijA5LcFMyQeH4P1kzDcL/g/UZYN0t4YCNV5AEBIEvdoA1T2kdIcLqspfS/OqiSds=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24642.16410.120896.773820@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 14:28:42 +0000 To: Jan Beulich Cc: Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Paul Durrant , Xen-devel Subject: Re: [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API In-Reply-To: <6b9fa11e-353e-8e10-8bec-f5c7930aae94@suse.com> References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-3-andrew.cooper3@citrix.com> <9b4acfc5-6d96-7922-7fde-5d0d543f8201@suse.com> <68a69e57-66b5-6f59-39f4-40649112fe40@citrix.com> <6b9fa11e-353e-8e10-8bec-f5c7930aae94@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API"): > This is news to me - so far it had been my understanding that it > was introduced to have a way for the kernel to audit and hand on > requests to the hypervisor without needing to know all the inner > details. I wasn't even aware a kernel module was using any of > these. Quite so. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 05 14:33:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 14:33:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93761.177002 (Exim 4.92) (envelope-from ) id 1lIBWZ-0006ps-Rv; Fri, 05 Mar 2021 14:33:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93761.177002; Fri, 05 Mar 2021 14:33:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBWZ-0006pl-Od; Fri, 05 Mar 2021 14:33:51 +0000 Received: by outflank-mailman (input) for mailman id 93761; Fri, 05 Mar 2021 14:33:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBWY-0006pg-P5 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:33:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 139eb328-1550-4d93-96bb-d6ca7b1cd511; Fri, 05 Mar 2021 14:33:50 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 23082ACCF; Fri, 5 Mar 2021 14:33:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 139eb328-1550-4d93-96bb-d6ca7b1cd511 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614954829; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HY7VA4WlavSs8rrOM4kbIGFkTRXgPec3TtU7A86W6CY=; b=IcTn7YG9WmU/wq6AgjJzrkuCbuR8LoB/8oaG807GWU7sXUpkYbDhy+4/uqBhq75ha7xtLA +vVpAqzv3kCL7pv2SX+gcamr7YT8I0TUSqwAp8WpjYXx3hxR4X9t9/aq/r428gubntwToV khusX4VaNaKwGxKZzUBLFA62QKPx6eE= Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters To: Ian Jackson , Julien Grall Cc: xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall References: <20210305121029.7047-1-julien@xen.org> <24642.12417.651929.972294@mariner.uk.xensource.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Fri, 5 Mar 2021 15:33:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24642.12417.651929.972294@mariner.uk.xensource.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3jOVDupz9YmR2v9RtbCs3JU1avoga0cdj" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3jOVDupz9YmR2v9RtbCs3JU1avoga0cdj Content-Type: multipart/mixed; boundary="mwPqcd5P5Nyo9bDNwWOMHTRXLjPFKwsGG"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Ian Jackson , Julien Grall Cc: xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall Message-ID: Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters References: <20210305121029.7047-1-julien@xen.org> <24642.12417.651929.972294@mariner.uk.xensource.com> In-Reply-To: <24642.12417.651929.972294@mariner.uk.xensource.com> --mwPqcd5P5Nyo9bDNwWOMHTRXLjPFKwsGG Content-Type: multipart/mixed; boundary="------------CBF00FAA24D3A24640D9B3B5" Content-Language: en-US This is a multi-part message in MIME format. --------------CBF00FAA24D3A24640D9B3B5 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 05.03.21 14:22, Ian Jackson wrote: > Julien Grall writes ("[PATCH for-4.15] tools/xenstored: liveupdate: Inc= rease the maximum number of parameters"): >> From: Julien Grall >> >> The longest possible command line for LiveUpdate is: >> >> liveupdate -s -t -F >> >> This is 5 parameters. However, the maximum is currently specified to 4= =2E >> This means the some of the parameters will get ignored. >=20 > Why are the extra parameters ignored rather than treated as errors ? > This seems like an invitation to making code with bad behaviour > (perhaps bad security-relevant behaviour). >=20 > CC Juergen who seems to have written the code... This is the max number of 0 delimited string parameters. Especially the stubdom case needs a binary blob (with length, of course) as parameter, and the number of 0 bytes in this data is just limited by the allowed payload length. See the comment in line 111 of xenstored_control.c. Juergen --------------CBF00FAA24D3A24640D9B3B5 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------CBF00FAA24D3A24640D9B3B5-- --mwPqcd5P5Nyo9bDNwWOMHTRXLjPFKwsGG-- --3jOVDupz9YmR2v9RtbCs3JU1avoga0cdj Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBCQUwFAwAAAAAACgkQsN6d1ii/Ey99 DQf9HwIK6tzgs7OxEejwOQQySJVug+tFsVr6huRRq9I8LMcClkJ3H41aSoRApjXvq4kicurGKaOz 8qcF5i7S5W2smmJx86BHXtRDXJk+IlsjIjfU4aJ1Zz0OePtBqVMF0QtPS7mQ0qI46I3vMKBG21vR qB5Cg0Ztt3ERlwXzy1YUSELW0RAvVDu97KQlz8kMl6UUESlAW+cTbQiqUCsKZjlYz4rehHHyT460 7uqvamxCzKJSFmBwzIcSO4GEIWXDC+9C3yMyeogVp3BtUIyqtuot6LKGk2zP/NAhl05wEDkoTiXy s/hNwWmvWY0f6KUgCn7jEtLTxTVQmhQoDhCejz+fQQ== =Q2xn -----END PGP SIGNATURE----- --3jOVDupz9YmR2v9RtbCs3JU1avoga0cdj-- From xen-devel-bounces@lists.xenproject.org Fri Mar 05 14:38:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 14:38:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93766.177014 (Exim 4.92) (envelope-from ) id 1lIBag-00071d-Il; Fri, 05 Mar 2021 14:38:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93766.177014; Fri, 05 Mar 2021 14:38:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBag-00071W-Ei; Fri, 05 Mar 2021 14:38:06 +0000 Received: by outflank-mailman (input) for mailman id 93766; Fri, 05 Mar 2021 14:38:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBae-00071R-LE for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:38:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBae-00086J-J7 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:38:04 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIBae-0007du-GF for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:38:04 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIBaZ-0000Dv-Og; Fri, 05 Mar 2021 14:37:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=hBMdAiyuWqXTpvFW6O/BDdSDnZWGiXULNTEl4t9KdEc=; b=24AWhZvhJI5E54w0ShIlk0ZXht reJRBekaReyDWvPW9LbqzB7YwVhLFrRNwF/2ftYRvtG5vzI8PZcpSmBp3No89h5S3voGZagw1Hwdz bDutCSMSC9VPT0n/LW2UBaZQ+GGYv39+X1fmCAnweF0gjD7q/JUzZ8WVv5na10Nfz6Ek=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24642.16967.563767.105312@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 14:37:59 +0000 To: =?iso-8859-1?Q?J=FCrgen_Gro=DF?= Cc: Julien Grall , xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters In-Reply-To: References: <20210305121029.7047-1-julien@xen.org> <24642.12417.651929.972294@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jrgen Gro writes ("Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters"): > This is the max number of 0 delimited string parameters. Especially the > stubdom case needs a binary blob (with length, of course) as parameter, > and the number of 0 bytes in this data is just limited by the allowed > payload length. > > See the comment in line 111 of xenstored_control.c. AFAICT this "live-update" command is variadic. So why is this parameter set here it all then ? Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 05 14:41:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 14:41:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93772.177025 (Exim 4.92) (envelope-from ) id 1lIBdk-00080G-0h; Fri, 05 Mar 2021 14:41:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93772.177025; Fri, 05 Mar 2021 14:41:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBdj-000809-Tw; Fri, 05 Mar 2021 14:41:15 +0000 Received: by outflank-mailman (input) for mailman id 93772; Fri, 05 Mar 2021 14:41:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBdj-000804-ED for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:41:15 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6a5865a0-ed79-41ef-9a11-0534f7b1203e; Fri, 05 Mar 2021 14:41:14 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 79AB6AD21; Fri, 5 Mar 2021 14:41:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a5865a0-ed79-41ef-9a11-0534f7b1203e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614955273; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HzQNZCrEbw4KTTCdbM/r1ka691FZnsHvloTqftMum1E=; b=GebOF6MlGCInyA18gBbPvvQC2Q+ITdljyKgUbT0Z92noyx2FHPLL4AqCL/YwAUtqfVKtyC NH9NdQf5NUSxsKvID4s3wLtbaFr0A3PmTdEg24A2ICk3ECpGG0k2cLZMA2bFV2fhWFBGii lq21+mI3BDOsWhmAec15AwMKLctlido= Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters To: Ian Jackson Cc: Julien Grall , xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall References: <20210305121029.7047-1-julien@xen.org> <24642.12417.651929.972294@mariner.uk.xensource.com> <24642.16967.563767.105312@mariner.uk.xensource.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <817a49d7-5f11-e53f-5bf5-55d22b157bec@suse.com> Date: Fri, 5 Mar 2021 15:41:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24642.16967.563767.105312@mariner.uk.xensource.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="l7UXiVopusa6i4qlPzRzSNnH7vT4HwEJO" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --l7UXiVopusa6i4qlPzRzSNnH7vT4HwEJO Content-Type: multipart/mixed; boundary="Eo0EOk00XuwapJAXfiYGYbOH1HdH0lZXZ"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Ian Jackson Cc: Julien Grall , xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall Message-ID: <817a49d7-5f11-e53f-5bf5-55d22b157bec@suse.com> Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters References: <20210305121029.7047-1-julien@xen.org> <24642.12417.651929.972294@mariner.uk.xensource.com> <24642.16967.563767.105312@mariner.uk.xensource.com> In-Reply-To: <24642.16967.563767.105312@mariner.uk.xensource.com> --Eo0EOk00XuwapJAXfiYGYbOH1HdH0lZXZ Content-Type: multipart/mixed; boundary="------------E7E2648399477CF9AE129148" Content-Language: en-US This is a multi-part message in MIME format. --------------E7E2648399477CF9AE129148 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 05.03.21 15:37, Ian Jackson wrote: > J=C3=BCrgen Gro=C3=9F writes ("Re: [PATCH for-4.15] tools/xenstored: li= veupdate: Increase the maximum number of parameters"): >> This is the max number of 0 delimited string parameters. Especially th= e >> stubdom case needs a binary blob (with length, of course) as parameter= , >> and the number of 0 bytes in this data is just limited by the allowed >> payload length. >> >> See the comment in line 111 of xenstored_control.c. >=20 > AFAICT this "live-update" command is variadic. So why is this > parameter set here it all then ? In order to avoid allocating an array for 4000 arguments when there are only 5 which need to be treated as strings. Juergen --------------E7E2648399477CF9AE129148 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------E7E2648399477CF9AE129148-- --Eo0EOk00XuwapJAXfiYGYbOH1HdH0lZXZ-- --l7UXiVopusa6i4qlPzRzSNnH7vT4HwEJO Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBCQwgFAwAAAAAACgkQsN6d1ii/Ey+Z 1wf/RNo7R8EKNMo1/Omn9iAh9vEw28V4QPJQlEk241u/cgNGy/TMKRTQgtMeHQ5byPXZMhtZC6ba jtawH0FptDhfE2hSlr904BoWSjAEe5MoP+tGEYkGDVRwfr7AjMA+PXyDoGMS168i+5578Tp1sB6n 77Pw+90oxsCAaewqWj0ugXXAv+NjPIwdJCJU8HARz+R0xgGi9DRWk64sohDZaCohOZ1mFekCBSEH sk1EA28mkKIKwMCu+HjLg85Ydqos5DcHw5KHL+EskBVRGbtZWjQR6VbArY8s7lZKUMR8AitcCRH3 wlUrbbcvVSxWXHXd94X31eiWjwGIDtOV2sEkUjKmoA== =517D -----END PGP SIGNATURE----- --l7UXiVopusa6i4qlPzRzSNnH7vT4HwEJO-- From xen-devel-bounces@lists.xenproject.org Fri Mar 05 14:46:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 14:46:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93788.177093 (Exim 4.92) (envelope-from ) id 1lIBik-0008S1-6Z; Fri, 05 Mar 2021 14:46:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93788.177093; Fri, 05 Mar 2021 14:46:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBik-0008Ru-3g; Fri, 05 Mar 2021 14:46:26 +0000 Received: by outflank-mailman (input) for mailman id 93788; Fri, 05 Mar 2021 14:46:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBii-0008Rm-Ty for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:46:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBii-0008Ff-TK for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:46:24 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIBii-0008NL-SX for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:46:24 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIBid-0000Fj-LR; Fri, 05 Mar 2021 14:46:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=BNuckCE/o0CrtmCmA33TR6XmxlAEzePgEuzuc6i1otc=; b=wueXlo0KZ3Qi5kVmBR28pBSMVQ 0CgymVuhmam86mTw13g3JQZ3sl0MJI7054DFZSNM3ZN1NF3xTTl47UfyQwmMErCjlGpvIjTo6qskw jgNxd07NO3G83+WBzecJchHgNTaO1tP0RwkoTmKpu/hcJbpMLhnVpcg6xhnd33wzA2GI=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24642.17467.425438.233285@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 14:46:19 +0000 To: =?iso-8859-1?Q?J=FCrgen_Gro=DF?= Cc: Julien Grall , xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters In-Reply-To: <817a49d7-5f11-e53f-5bf5-55d22b157bec@suse.com> References: <20210305121029.7047-1-julien@xen.org> <24642.12417.651929.972294@mariner.uk.xensource.com> <24642.16967.563767.105312@mariner.uk.xensource.com> <817a49d7-5f11-e53f-5bf5-55d22b157bec@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jrgen Gro writes ("Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters"): > On 05.03.21 15:37, Ian Jackson wrote: > > Jrgen Gro writes ("Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters"): > >> This is the max number of 0 delimited string parameters. Especially the > >> stubdom case needs a binary blob (with length, of course) as parameter, > >> and the number of 0 bytes in this data is just limited by the allowed > >> payload length. > >> > >> See the comment in line 111 of xenstored_control.c. > > > > AFAICT this "live-update" command is variadic. So why is this > > parameter set here it all then ? > > In order to avoid allocating an array for 4000 arguments when there > are only 5 which need to be treated as strings. So this parameter is doing two jobs: 1. enabling non-variadic commands to take binary input; 2. preventing variadic commands from allocating unbounded memory. The problem with this is that in case 1 exceeding the value is normal and the final argument is binary data; whereas in case 2 glomming together the arguments together with zeroes is wrong and potentially hazrdous. I suggest we solve problem 2 by imposing a higher fixed (for all commands, variadic or not) limit (20 or something) which causes errors when exceeded, rather than silent argument misinterpretation. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 05 14:49:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 14:49:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93795.177118 (Exim 4.92) (envelope-from ) id 1lIBlo-0000F9-SX; Fri, 05 Mar 2021 14:49:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93795.177118; Fri, 05 Mar 2021 14:49:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBlo-0000F2-Nz; Fri, 05 Mar 2021 14:49:36 +0000 Received: by outflank-mailman (input) for mailman id 93795; Fri, 05 Mar 2021 14:49:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBln-0000Er-VY for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:49:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBln-0008KL-QE for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:49:35 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIBln-0000FI-OJ for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:49:35 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIBlj-0000GN-28; Fri, 05 Mar 2021 14:49:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:To:Date: Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=ycvcziwXB7CGSNsNAjqdOV0q4LEw4DTNaPuccAc7Eno=; b=b/hRLWuLKL1Uk/AHZYza6eXOkH LC9xc0kRZRk8fSlzD++yzsouNptzKjl5b5ytxXIfzZyLslB3dtshyrYZCBra534NEFq8IxgiA3H5H Qvjop+IYRbaIFfnV2vR/0Nipa3I2fAdpkic4D3ccxzTGfFd0BnHWACR3MrFO5h1doiKQ=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24642.17658.843482.352849@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 14:49:30 +0000 To: =?iso-8859-1?Q?J=FCrgen_Gro=DF?= , Julien Grall , xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters In-Reply-To: <24642.17467.425438.233285@mariner.uk.xensource.com> References: <20210305121029.7047-1-julien@xen.org> <24642.12417.651929.972294@mariner.uk.xensource.com> <24642.16967.563767.105312@mariner.uk.xensource.com> <817a49d7-5f11-e53f-5bf5-55d22b157bec@suse.com> <24642.17467.425438.233285@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Ian Jackson writes ("Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters"): > Jrgen Gro writes ("Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters"): > > On 05.03.21 15:37, Ian Jackson wrote: > > > Jrgen Gro writes ("Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters"): > > >> This is the max number of 0 delimited string parameters. Especially the > > >> stubdom case needs a binary blob (with length, of course) as parameter, > > >> and the number of 0 bytes in this data is just limited by the allowed > > >> payload length. > > >> > > >> See the comment in line 111 of xenstored_control.c. > > > > > > AFAICT this "live-update" command is variadic. So why is this > > > parameter set here it all then ? > > > > In order to avoid allocating an array for 4000 arguments when there > > are only 5 which need to be treated as strings. > > So this parameter is doing two jobs: 1. enabling non-variadic commands > to take binary input; 2. preventing variadic commands from allocating > unbounded memory. > > The problem with this is that in case 1 exceeding the value is normal > and the final argument is binary data; whereas in case 2 glomming > together the arguments together with zeroes is wrong and potentially > hazrdous. > > I suggest we solve problem 2 by imposing a higher fixed (for all > commands, variadic or not) limit (20 or something) which causes errors > when exceeded, rather than silent argument misinterpretation. Also, this use of max_pars to do job 2 seems very inconsistent. It is applied only to "live-update". If it is necessary for "live-update", which is it not necessary for "check" or whatever ? Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 05 14:56:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 14:56:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93808.177150 (Exim 4.92) (envelope-from ) id 1lIBrt-0001L0-Pr; Fri, 05 Mar 2021 14:55:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93808.177150; Fri, 05 Mar 2021 14:55:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBrt-0001Kt-Mj; Fri, 05 Mar 2021 14:55:53 +0000 Received: by outflank-mailman (input) for mailman id 93808; Fri, 05 Mar 2021 14:55:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBrs-0001Km-7D for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:55:52 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id db4daecf-010d-473c-9070-db0d49d89970; Fri, 05 Mar 2021 14:55:51 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1C2F0AE85; Fri, 5 Mar 2021 14:55:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db4daecf-010d-473c-9070-db0d49d89970 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614956150; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JlmVnUdfqpPlY5D2J/A/rW5yGaXaU1QP08qiofZ/ntY=; b=UZEUXRFLyo2/uaGp9zHomDhomedlEC7/qKUYDJ7359CffX+1jvgL1mplGs/J/EgYoELjQy oC4n1Loiea9k4Y+LYbzRPFscDSzf4QP3lsHrTJVy6ULORvXScjsKZvbC9yc+OjllAW2PPh FaFqXg6nVP3WOicxp2CdWHuVJuyPCWg= Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters To: Ian Jackson , Julien Grall , xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall References: <20210305121029.7047-1-julien@xen.org> <24642.12417.651929.972294@mariner.uk.xensource.com> <24642.16967.563767.105312@mariner.uk.xensource.com> <817a49d7-5f11-e53f-5bf5-55d22b157bec@suse.com> <24642.17467.425438.233285@mariner.uk.xensource.com> <24642.17658.843482.352849@mariner.uk.xensource.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Fri, 5 Mar 2021 15:55:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24642.17658.843482.352849@mariner.uk.xensource.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XLKtTpvcC8ftJfvlvJ9HoZDm1e7dp0NKB" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XLKtTpvcC8ftJfvlvJ9HoZDm1e7dp0NKB Content-Type: multipart/mixed; boundary="dYnWJC0exz3qXt5xXFK3UG2eVNulXQeZN"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Ian Jackson , Julien Grall , xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall Message-ID: Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters References: <20210305121029.7047-1-julien@xen.org> <24642.12417.651929.972294@mariner.uk.xensource.com> <24642.16967.563767.105312@mariner.uk.xensource.com> <817a49d7-5f11-e53f-5bf5-55d22b157bec@suse.com> <24642.17467.425438.233285@mariner.uk.xensource.com> <24642.17658.843482.352849@mariner.uk.xensource.com> In-Reply-To: <24642.17658.843482.352849@mariner.uk.xensource.com> --dYnWJC0exz3qXt5xXFK3UG2eVNulXQeZN Content-Type: multipart/mixed; boundary="------------0598BDE6253E476000556D85" Content-Language: en-US This is a multi-part message in MIME format. --------------0598BDE6253E476000556D85 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 05.03.21 15:49, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH for-4.15] tools/xenstored: liveupdate: = Increase the maximum number of parameters"): >> J=C3=BCrgen Gro=C3=9F writes ("Re: [PATCH for-4.15] tools/xenstored: l= iveupdate: Increase the maximum number of parameters"): >>> On 05.03.21 15:37, Ian Jackson wrote: >>>> J=C3=BCrgen Gro=C3=9F writes ("Re: [PATCH for-4.15] tools/xenstored:= liveupdate: Increase the maximum number of parameters"): >>>>> This is the max number of 0 delimited string parameters. Especially= the >>>>> stubdom case needs a binary blob (with length, of course) as parame= ter, >>>>> and the number of 0 bytes in this data is just limited by the allow= ed >>>>> payload length. >>>>> >>>>> See the comment in line 111 of xenstored_control.c. >>>> >>>> AFAICT this "live-update" command is variadic. So why is this >>>> parameter set here it all then ? >>> >>> In order to avoid allocating an array for 4000 arguments when there >>> are only 5 which need to be treated as strings. >> >> So this parameter is doing two jobs: 1. enabling non-variadic commands= >> to take binary input; 2. preventing variadic commands from allocating >> unbounded memory. >> >> The problem with this is that in case 1 exceeding the value is normal >> and the final argument is binary data; whereas in case 2 glomming >> together the arguments together with zeroes is wrong and potentially >> hazrdous. >> >> I suggest we solve problem 2 by imposing a higher fixed (for all >> commands, variadic or not) limit (20 or something) which causes errors= >> when exceeded, rather than silent argument misinterpretation. >=20 > Also, this use of max_pars to do job 2 seems very inconsistent. It is > applied only to "live-update". >=20 > If it is necessary for "live-update", which is it not necessary for > "check" or whatever ? live-update is the only command with binary data. The other commands are checking all parameters to be valid, similar to normal parameter parsing in a main() function of a user program. Juergen --------------0598BDE6253E476000556D85 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0598BDE6253E476000556D85-- --dYnWJC0exz3qXt5xXFK3UG2eVNulXQeZN-- --XLKtTpvcC8ftJfvlvJ9HoZDm1e7dp0NKB Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBCRnUFAwAAAAAACgkQsN6d1ii/Ey8z lAf/T/YKikRuBHGzTy2oXpA/wnsW+KfyOFyiOjCq4zO8+uECBLy3LEOkhhxAOX3cKWkhbvoBxWaL Cw6hkEzNAfAeUCgGSYncgISL7+0fmbC7ikix0WQlow+F4RTZXmkqvSwFQVYXS46Kxo27Q+7AM9Jo D5Kq7zAwfVRszf0jWZX9rAXTfcY2n/9lKg8HMdxr7nWFZwi4OS2Si0eZ/cLNiKksSS1Y95D8Qa+b wHgppO3UzAMprVK1cyj2jZEyBrICw+eaORyaJdWX0EeqayfRZAhnEpxa2D5zN/vNIg0WsrW6jHS2 xx19J2mFdV6urukkaHBVcCF2ezrqxLkzbgDg9vchEQ== =1RVa -----END PGP SIGNATURE----- --XLKtTpvcC8ftJfvlvJ9HoZDm1e7dp0NKB-- From xen-devel-bounces@lists.xenproject.org Fri Mar 05 14:56:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 14:56:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93811.177169 (Exim 4.92) (envelope-from ) id 1lIBsD-0001TA-Am; Fri, 05 Mar 2021 14:56:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93811.177169; Fri, 05 Mar 2021 14:56:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBsD-0001T3-75; Fri, 05 Mar 2021 14:56:13 +0000 Received: by outflank-mailman (input) for mailman id 93811; Fri, 05 Mar 2021 14:56:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIBsC-0001S1-Kw for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 14:56:12 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2d4b5170-67d1-42ab-9799-0ee723e3293e; Fri, 05 Mar 2021 14:56:11 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B28DEAE89; Fri, 5 Mar 2021 14:56:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d4b5170-67d1-42ab-9799-0ee723e3293e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614956170; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EsmfXO2Opci0SDdeA3H78wsnKr507wkVL8Sq52e5JX4=; b=ZILXrTu12w4mLs+wvaFiaLk8QhOLmPfn6E4sq4hjojMik5rUSC00Gs7otibqnfghIG2k80 7WtMgOD5id4jjWArW0gdRpjbU+zTDtxbVBTVLZpEWfUg3rZuldSc+PO/ZXl+MWeZDVA1Tu pxDTolU5QhnV6l9STqljaSHJF4yyrFQ= Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters To: Ian Jackson Cc: Julien Grall , xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall References: <20210305121029.7047-1-julien@xen.org> <24642.12417.651929.972294@mariner.uk.xensource.com> <24642.16967.563767.105312@mariner.uk.xensource.com> <817a49d7-5f11-e53f-5bf5-55d22b157bec@suse.com> <24642.17467.425438.233285@mariner.uk.xensource.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <15dde93e-5121-bc13-f931-38c2269a9271@suse.com> Date: Fri, 5 Mar 2021 15:56:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24642.17467.425438.233285@mariner.uk.xensource.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="704O8yJh8rHZpGTF2vPlcr7NyTUAQbm2c" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --704O8yJh8rHZpGTF2vPlcr7NyTUAQbm2c Content-Type: multipart/mixed; boundary="9sOmaYRQCh84d0NzIPpia1XqKmHJwUykI"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Ian Jackson Cc: Julien Grall , xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall Message-ID: <15dde93e-5121-bc13-f931-38c2269a9271@suse.com> Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters References: <20210305121029.7047-1-julien@xen.org> <24642.12417.651929.972294@mariner.uk.xensource.com> <24642.16967.563767.105312@mariner.uk.xensource.com> <817a49d7-5f11-e53f-5bf5-55d22b157bec@suse.com> <24642.17467.425438.233285@mariner.uk.xensource.com> In-Reply-To: <24642.17467.425438.233285@mariner.uk.xensource.com> --9sOmaYRQCh84d0NzIPpia1XqKmHJwUykI Content-Type: multipart/mixed; boundary="------------B0CD4AE6E2177962E1CFA04C" Content-Language: en-US This is a multi-part message in MIME format. --------------B0CD4AE6E2177962E1CFA04C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 05.03.21 15:46, Ian Jackson wrote: > J=C3=BCrgen Gro=C3=9F writes ("Re: [PATCH for-4.15] tools/xenstored: li= veupdate: Increase the maximum number of parameters"): >> On 05.03.21 15:37, Ian Jackson wrote: >>> J=C3=BCrgen Gro=C3=9F writes ("Re: [PATCH for-4.15] tools/xenstored: = liveupdate: Increase the maximum number of parameters"): >>>> This is the max number of 0 delimited string parameters. Especially = the >>>> stubdom case needs a binary blob (with length, of course) as paramet= er, >>>> and the number of 0 bytes in this data is just limited by the allowe= d >>>> payload length. >>>> >>>> See the comment in line 111 of xenstored_control.c. >>> >>> AFAICT this "live-update" command is variadic. So why is this >>> parameter set here it all then ? >> >> In order to avoid allocating an array for 4000 arguments when there >> are only 5 which need to be treated as strings. >=20 > So this parameter is doing two jobs: 1. enabling non-variadic commands > to take binary input; 2. preventing variadic commands from allocating > unbounded memory. >=20 > The problem with this is that in case 1 exceeding the value is normal > and the final argument is binary data; whereas in case 2 glomming > together the arguments together with zeroes is wrong and potentially > hazrdous. >=20 > I suggest we solve problem 2 by imposing a higher fixed (for all > commands, variadic or not) limit (20 or something) which causes errors > when exceeded, rather than silent argument misinterpretation. Patches welcome. Juergen --------------B0CD4AE6E2177962E1CFA04C Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------B0CD4AE6E2177962E1CFA04C-- --9sOmaYRQCh84d0NzIPpia1XqKmHJwUykI-- --704O8yJh8rHZpGTF2vPlcr7NyTUAQbm2c Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBCRooFAwAAAAAACgkQsN6d1ii/Ey/w oAgAlttEnZaw9EKw8lFU+hhPKXLL75ERO1U/KKKHQEmdlT3i0jG0hwBVf7vjutCbItNv3xiKihne jBCAsfKQKX6GT5yNw+iupnVHarPeeJom92OAbWHCyZUDAJTtxZiaq7+lLRDNwJZLu3WuC/ByE4+r idarCADAKbqt6Jm4BbGI4b77zMMns4+QXUvBXoMsp8RdeEFPCpg2Q83nJiY5MEWB3jkvnadZrQzU zs4CpilF/6lB0c29gJSZ+zZug/cejvfEY1SLiDoIyK2vxGA1rdrT4g9DXq1oZp7ixNCEbTuOEY+n Zp5jY6e0PVurshUuF/iFdo7ycD7M/m28NA4jFBqAuw== =N0dy -----END PGP SIGNATURE----- --704O8yJh8rHZpGTF2vPlcr7NyTUAQbm2c-- From xen-devel-bounces@lists.xenproject.org Fri Mar 05 15:14:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 15:14:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93830.177222 (Exim 4.92) (envelope-from ) id 1lIC9x-0003ij-AY; Fri, 05 Mar 2021 15:14:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93830.177222; Fri, 05 Mar 2021 15:14:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIC9x-0003ic-7E; Fri, 05 Mar 2021 15:14:33 +0000 Received: by outflank-mailman (input) for mailman id 93830; Fri, 05 Mar 2021 15:14:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIC9v-0003iU-GH; Fri, 05 Mar 2021 15:14:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIC9v-0000MN-5z; Fri, 05 Mar 2021 15:14:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIC9u-0002Mk-Rx; Fri, 05 Mar 2021 15:14:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIC9u-0004F0-RV; Fri, 05 Mar 2021 15:14:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CA9h9pAIkxVH5NwaTbZ6/Nv5WfxW1zuYEq9XMXnp/HM=; b=eIHAFrKJIUFDNB3dlf5zqlSNmY WKka+r5DqjjS0/gs73qfXudhv5DWDywShYucUEJlLaIE0+qh1w2SCNlcDFOugreEZnyWJ14+Znnw/ w8l3hV6zFVjAIoq2r43lJ0hOYb4vxqQCw57QrrE8zBchCdHqdPtvxGgWfRquYAN8z6v4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159837: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9318fdf757ec234f0ee6c5cd381326b2f581d065 X-Osstest-Versions-That: xen=f40e1c52e4e0a3e084b025ed6b68f1e6ebaea027 From: osstest service owner Date: Fri, 05 Mar 2021 15:14:30 +0000 flight 159837 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159837/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9318fdf757ec234f0ee6c5cd381326b2f581d065 baseline version: xen f40e1c52e4e0a3e084b025ed6b68f1e6ebaea027 Last test of basis 159829 2021-03-04 16:02:36 Z 0 days Testing same since 159837 2021-03-05 13:01:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Tim Deegan jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f40e1c52e4..9318fdf757 9318fdf757ec234f0ee6c5cd381326b2f581d065 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Mar 05 15:14:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 15:14:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93832.177237 (Exim 4.92) (envelope-from ) id 1lICA9-0003lx-Ji; Fri, 05 Mar 2021 15:14:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93832.177237; Fri, 05 Mar 2021 15:14:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICA9-0003lq-GY; Fri, 05 Mar 2021 15:14:45 +0000 Received: by outflank-mailman (input) for mailman id 93832; Fri, 05 Mar 2021 15:14:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICA7-0003lX-AM for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 15:14:43 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id be3c866e-eacc-47af-962c-951d1d130572; Fri, 05 Mar 2021 15:14:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be3c866e-eacc-47af-962c-951d1d130572 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614957281; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=KE8xvHg8F3mCLeo0x3k1JDFaCnoCZky908qK8z6S1Nk=; b=JykXrHVq1DLfK1QGA6gqm9DxP/Mc0/vc/mPk8xhlwKaeAaOVf8avQzQU caJAU8xld2RszoU6oQWYpFr4kvy4VzoLLOxh+GIQnoxhar4JiEFxttbFr jpO8UgQ3vojhnXFSikN+auiWNOeIwf7F8cXmgZu6dv0Mha6p+gAz1JTbs E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 0r+i9otqIxmqKs7lpg1fwv2ZyeO44K8Lla0Q17SAAEoWrCsIcNIrGPWOHJlhKymDuEssN6nyUL Q4UmAVv9ghcf0NfsADJknT7h7DVELUJs2MgjLOMgX2wPMUuLK/BSOLt9vRxO4aZlWo67aRjKn2 L+D/mL3Re1r904HXgs9/usCRliu+jQ3r9XmNSvbbgUN8Oil9Ae6qHTXTYhj8MWqWEfpVAhO3xT YtYwp9ghy6jHRdkBbQyiEywHVcKelObKymfXi5VCACY9IoJTZAbOdygcvxfbohfzOBmy8rI5L5 eFI= X-SBRS: 5.2 X-MesageID: 38559275 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,225,1610427600"; d="scan'208";a="38559275" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FdDlREy+sVpmMlACqfUCsHjP58AHtQ4CklybXIohWl0MH2FJFMJhZwjXpTXirsVlcM61SsttxydKf+BISKhjowug27O/2sMIYwAgJUyU0LIxiL288e1D0PuZea+sL6Fc5Gi5cXH5qcZUVQ8tiD4Kf0XLt72jLjTUdTZiuVH5hhGtZa9+XoaMh0VZliBumTLfmSaukUfP/rvvKGtZ/jtdS4X5YStUrbQuImsZ3a/69AXZ4NnYre2KrCYPnqJfUVGU4XrYgdAuOjJGdFHmUlPl4YweVpd5btPNHQPauPYFqNjkGYf3MrXb0HYcy+WsA1tzU9gnpASBZtYKgrKgZ9K84g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ldD+TyTEd99yUtDPEHFx8m5z8iF8Yx1GfMg+4PNhkW8=; b=YudHY85hs0spFb0gyOnY6p1gtc8lf5e/cLjkcMwRAAU3a5QUYvxdsHfQBY+6qjIh29wF++AY2nn4qjnNxXeewy2WpQ/bHryzAmlwNai9AiQd9ZRh+G8zyK6WK87+2zquL5jOECsj3iB6ONXEhizizvby9RdelIEQgPhgfDo8IVmme2llFezn8JT0HySTpBY2NRE35gcLCiexAT4Bfa0NkpIShLp7T3dv7NaKg/Lze2McJZitichgTn/z0ZMRz0TiEw2QKUrrDIWaHmQtiWaIgnZtuOkL1IaCMbK/PfE+ldhjI3ef7SrR6ByQV1Z1pKH86BOxIz9HpCT5vvmFFf+nOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ldD+TyTEd99yUtDPEHFx8m5z8iF8Yx1GfMg+4PNhkW8=; b=F+So8khTFSHFOEFLTeVCeIhTbNLx3MKD6+5WES+HDAU8YjYe/0l+y+NA5zy5K20th51MIOUhH+kECbjOJ/5P4wi58AEAN45fDpNIpPGJ4XoYk6xai2GSMaag/6Anvv9uO4Yne1hhKLTSy+tUIEcjj4KuwKi10L5WJf567S2CwjQ= To: Jan Beulich CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Ian Jackson , Xen-devel References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-3-andrew.cooper3@citrix.com> <9b4acfc5-6d96-7922-7fde-5d0d543f8201@suse.com> <68a69e57-66b5-6f59-39f4-40649112fe40@citrix.com> <6b9fa11e-353e-8e10-8bec-f5c7930aae94@suse.com> <0e0fe64c-0834-a3e9-e85c-c17d8a510941@suse.com> From: Andrew Cooper Subject: Re: [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API Message-ID: Date: Fri, 5 Mar 2021 15:13:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <0e0fe64c-0834-a3e9-e85c-c17d8a510941@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0414.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 40ab6872-bd80-4bd6-2c76-08d8dfe94d7d X-MS-TrafficTypeDiagnostic: BY5PR03MB5284: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zbqxVwP5ddKUXVp4tHr7GyMvrUQv1smEcsnrqnqzZ4+MpkcXAquwi76tHuoo55Dz188H+IN2THoAMgzK//h4Vy5aAty3V9VVYsOu+cK60QL1RBzPapjIH2BdpLv30XWar36fe+HJRH2dCG5s1dGMl36JxoQHNzeBpSPbyfUJS2Vg4EFCBBqN3wNihxAkUe+nfP+lAcPx5sjwryEw42wzbne9lyA3PKS7vDXMRZ38UtLAfKjgIWkOS8/DlOPLSv48dnKZz2z1+K0Ffc4oRHoKKrEqpKg6iilVDs75plAlJYUD63i1/mdc8Dshff3BLvXsljbj9KjgVzET038KVuUSgxfo2Fi+IdrewoOp9HuZcg1zrcWy4/kOTnYwKtGD6eBKO7cgx/XxfV7KasbXOf3sfLdD/bYgOmvXPIP52StWcv0o+UiqsOj5OV5ehQfcY61fuY1RA1N1+OwBbypt79+MLXQf3fR0B2AVHprwo/Soig9qreSMbCG5nDxtZqDjBnVjlX9uCxzYgoUXuBV5ykWbAabS6+KFXni1OpaPXD8a+y1PWBjDkiWedcu5dNY1sAC75gYtjz8/Dox27Y35YOkNeZixysCefKU1b3o5OT5fyDM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(39860400002)(366004)(376002)(136003)(31696002)(4326008)(31686004)(2906002)(956004)(86362001)(26005)(6486002)(83380400001)(54906003)(6916009)(8936002)(2616005)(16526019)(66946007)(53546011)(16576012)(36756003)(8676002)(316002)(66476007)(5660300002)(186003)(6666004)(66556008)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aW9OY0R3U1FJV1dvSVQ2cXV2ek04a1RXZ096TkNkR044dUVrdXd1R3ZSWDZu?= =?utf-8?B?R3FWVTIyR3FpaUU4UTlHSWJTUXNZc2o3VjZ1aXBHbTZ1TTI3UnRQc2lPVFF1?= =?utf-8?B?dnZBQlY0UU5KRDBOYk1iVytmQ2o5RmFXWUh3VGZXWEY0SXBaQWlKalljcWNZ?= =?utf-8?B?ZnZvcDBvV3VLMUpDSU9PaUsvc085WHR1U1pXdXpmaEMwWDR6dmJwWmFweEo5?= =?utf-8?B?UWQ5T0szZFZ4cjRlZFpYbmRUTWZUWWgzeXplWTBOay9qZkpqS1dkcFc0cjVV?= =?utf-8?B?TStqOFAvNUNNNWtLK2svODZiWjVjeHMyVWlWRzBmQUt1WHVFOUhibjNkejMx?= =?utf-8?B?MTVlRmZLTmdyQUswZ2FxWWpWMDhYVDA0czUyaTJUSUNaQUtOQjlNU08wd1RC?= =?utf-8?B?cXV5U0U4bGEwOXVRT2Z2eHNOODdkSnoxcWhEL1RMU0cyUVd1VWl0ZGRiQ2lp?= =?utf-8?B?VGRQZ2M0RWVJcGJyZkpYVkg2NU5memVidmFTYlJld05tN0dVMkg2a1dNeXZ4?= =?utf-8?B?bFh3UGlnVmtTWlBuRWduOW5jTXRCaWdQd0Jza3gxbGJVT2dBeFlPTDlpTHFt?= =?utf-8?B?Z1FST0VyelBWQkdTak9wQjE3YlcwTWs1WHpDcjBxbTBJNEFIZHVIbHhjVTNX?= =?utf-8?B?VHdEZHFNaVpiVGc4cnowZUxVdnV6VnI5NzV5MUh5Kytxc3BwNDIwQ3psTE8v?= =?utf-8?B?NG1wYVBRRUp1ckw4YTZjRENqbEFjNThaK0pjMncyNVh6Z0pTU2lvNFoxUUNj?= =?utf-8?B?VVlNdTI4QXZLSWVxdjRZQkNDVmp1NGN1UEYrOEtQNTlTNFIwdTVJM0JoWHRD?= =?utf-8?B?NVpJQ0xsR3VTUXQrbkkrV1Q0SEQ1YnhoaW1nVExrYm1xek9jUERiaDBGaTQ1?= =?utf-8?B?Y0xQS0NhUENrWUlHdUpiS0VzaEZTU1NmdFA5R2dXbkIrbVdlOVdFYzdSVTQ1?= =?utf-8?B?SXlEK3IyNFBzYkdKeDhmVWo4dVlnNHN6RzhaR092Y2RGYmJvdXd0STE1bmNu?= =?utf-8?B?cXk1QWFzUmFVWkpCNTh3aW5wTUY0anhqK3FHd20yam0ydWIvMVNwL1hzVUd4?= =?utf-8?B?WHlaSzBCWHVtUTc2OXVQSW1KUlNqWlluR2drZU5lRzJwV3dPWVZEMXlabHF6?= =?utf-8?B?QWxPZXREcHo0dU9vRGpGZXlqYVhNY3Zuc0FPNk9BOEtNcTRocWE4ZUdPV21W?= =?utf-8?B?UE1xcGt4R0tha2dxQ2tJNkJ0a0gxKzdwUlZVUVlyc0lzSlY2TWVlMTVpS2dY?= =?utf-8?B?Z3gyWVY1Mk1Xc0xicTB1MHBRZkVpaDRzbmJMMytwaEl1TXVNbmM3SzZtWG9J?= =?utf-8?B?b3JKVXVsbkJHWmY2bUhIR3pPaEovVDhoeVJ0R3g0REhBMitxS054Q3BvOGha?= =?utf-8?B?KzhSUVZ5SWVDWUc2NDBCVVYrbldzYWl2OGlVV3k0VDRWeGNtLzlTQjBOL09E?= =?utf-8?B?Skk0TlMzTWoyaHlDM3ltd2JjQWF1cytxOGhrRWIvL1NEbGYvWlB5RStZU2Zp?= =?utf-8?B?bUVZZUJBVFpvc1BwMGltdm1HM2JBeEV6dGlEMEpVRVNGc1h2QlRoVkgySXI0?= =?utf-8?B?QlBhWFdhYzVURi9KK1JKK1E4UUV1amJsWmYvR3dsRUUybFFOTUQ5UlBjemxK?= =?utf-8?B?UEZHVVpZU0lLZ3RMZnkvNEc1RklVYXpLSzROODhxOXJ3bkNhR0l6Ny9TRmNZ?= =?utf-8?B?Qk1iL0VWdFd2ZXUwM2pIV1Vzak9uSzJ4cnhaM2RlSmxNVGFBU2xCVUVoZGpz?= =?utf-8?Q?YSPmM1d3vwwaDM1PW39QoWXWSBLvS9fTegNbYmY?= X-MS-Exchange-CrossTenant-Network-Message-Id: 40ab6872-bd80-4bd6-2c76-08d8dfe94d7d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2021 15:13:59.5616 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 99pBXGrxolvhvJFbF82S2X2MzepMLDwbMvkU45r1wp2YD341puKFeXYpemNa98tYeq3hLzavuLXWfe1Xg4XtZYyWWR7q8nVzASdbLgnNbZk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5284 X-OriginatorOrg: citrix.com On 05/03/2021 14:21, Jan Beulich wrote: > On 05.03.2021 15:18, Jan Beulich wrote: >> On 05.03.2021 15:12, Andrew Cooper wrote: >>> On 05/03/2021 13:53, Jan Beulich wrote: >>>> On 05.03.2021 13:49, Andrew Cooper wrote: >>>>> Exactly as with c/s f40e1c52e4, this is inappropriate for a stable li= brary. >>>>> >>>>> That change actually broke the build with: >>>>> >>>>> include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t= ' >>>>> ioservid_t *id); >>>>> ^ >>>>> >>>>> as libxendevicemodel.h now uses a type it can't see a typedef for. H= owever, >>>>> nothing noticed because the header.chk logic is also broken (fixed >>>>> subsequently). >>>> While I agree up to here, ... >>>> >>>>> Strip the guard from the public header, and remove compensation from >>>>> devicemodel's private.h >>>> ... I'm unconvinced that entirely dropping the guard from the >>>> public header is wanted (or needed): We use these to make clear >>>> that in particular kernels aren't supposed to make use of the >>>> enclosed entities. If a type needs exposing, it (and only it) >>>> wants moving ou of the guarded region imo. >>> DMOP was invented specifically so a kernel module (i915, for Intel >>> gVT-g) was independent of the domctl ABI version. >>> >>> Improving the life of dom0 userspace was an intended consequence, but >>> not the driving force behind the change. >> This is news to me - so far it had been my understanding that it >> was introduced to have a way for the kernel to audit and hand on >> requests to the hypervisor without needing to know all the inner >> details. I wasn't even aware a kernel module was using any of >> these. > And indeed, quote from docs/designs/dmop.markdown: > > "The aim of DMOP is to prevent a compromised device model from > compromising domains other than the one it is providing emulation > for (which is therefore likely already compromised)." > > And it goes on discussing only the purpose that I've been aware > of. The use in the dom0 kernel wasn't kept secret in the slightest.=C2=A0 It wa= s discussed on at the time, and at dev summits. But upstream tends to only remember/care about the bits which pertain directly to upstream, and the design particulars of the DMOP ABI were specifically for userspace. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 05 15:20:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 15:20:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93841.177249 (Exim 4.92) (envelope-from ) id 1lICFf-0004pe-Aj; Fri, 05 Mar 2021 15:20:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93841.177249; Fri, 05 Mar 2021 15:20:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICFf-0004pX-6F; Fri, 05 Mar 2021 15:20:27 +0000 Received: by outflank-mailman (input) for mailman id 93841; Fri, 05 Mar 2021 15:20:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICFd-0004pS-R7 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 15:20:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICFd-0000SP-P3 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 15:20:25 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lICFd-0002aF-Nl for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 15:20:25 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lICFU-0000Ki-FQ; Fri, 05 Mar 2021 15:20:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=YSi7ULddfUnPkUYhWh0A73+YlLdfr413xo1+z2q1PpE=; b=6tOF8AhH9pzQ33A2lamkA/ewEN ulngiZjQYakxER6mRFt4IoSie7Yph5u5lVbhtTnag6dyNi86s5twd2L/4zVqydMKB0jnY7vfYQRNu BEYdZwhbdpZvjJFt9Fz+navtUQnWb3xD7ifk6wBZKzaoGcsLp7jajV4iVCNAj/13K/wc=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24642.19504.207757.633803@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 15:20:16 +0000 To: Andrew Cooper Cc: Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Paul Durrant , Xen-devel Subject: Re: [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API In-Reply-To: References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-3-andrew.cooper3@citrix.com> <9b4acfc5-6d96-7922-7fde-5d0d543f8201@suse.com> <68a69e57-66b5-6f59-39f4-40649112fe40@citrix.com> <6b9fa11e-353e-8e10-8bec-f5c7930aae94@suse.com> <0e0fe64c-0834-a3e9-e85c-c17d8a510941@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("Re: [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API"): > The use in the dom0 kernel wasn't kept secret in the slightest. It was > discussed on at the time, and at dev summits. No-one is accusing anyone of keeping anything secret. > But upstream tends to only remember/care about the bits which pertain > directly to upstream, I would prefer to say that upstream only tends to remember things which are WRITTEN DOWN. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 05 15:36:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 15:36:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93846.177261 (Exim 4.92) (envelope-from ) id 1lICUx-0005zG-OK; Fri, 05 Mar 2021 15:36:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93846.177261; Fri, 05 Mar 2021 15:36:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICUx-0005z9-LB; Fri, 05 Mar 2021 15:36:15 +0000 Received: by outflank-mailman (input) for mailman id 93846; Fri, 05 Mar 2021 15:36:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICUw-0005z4-Ae for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 15:36:14 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2e24bb74-7643-4cc7-a9fb-4ec94f7ea29b; Fri, 05 Mar 2021 15:36:13 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AF84DAD72; Fri, 5 Mar 2021 15:36:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e24bb74-7643-4cc7-a9fb-4ec94f7ea29b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614958572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LKMg3/gTyoAPIQ6oDN88wxQX2CgJkK/YgqsHUdKYIxY=; b=GglIZltPpQH5hNeIVfT4p8GjoAHovwneZ0k2ypYVMmXlr2azCbs8C0/mFjDceoiG0u5PDG ATageAbctyT4eMUdr1TrELOQ5Q0eiQaXq7UD9Jre7G4Em7DL/t1Ppd3cSJ/AKFTrjOQTc3 bB6EZ1BnARzAGEsADF4iNUeiqKjMLjY= To: "xen-devel@lists.xenproject.org" Cc: Tim Deegan , George Dunlap , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson From: Jan Beulich Subject: [PATCH 0/2][4.15?] x86/shadow: further refinements to "fast fault path" suppression Message-ID: Date: Fri, 5 Mar 2021 16:36:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Andrew points out that 'x86/shadow: suppress "fast fault path" optimization without reserved bits' assumes firm knowledge of the physical machine's address width. When we run virtualized ourselves, we can't reasonably assume that we do, the more that the property may change as we may get migrated. Since we want to further refine this logic anyway, I thought I'd also include the other change that I've previously mentioned, at least for consideration whether to take for 4.15. This reduces the performance impact (albeit perhaps only for very large or exotic guests) that the earlier patch has. 1: suppress "fast fault path" optimization when running virtualized 2: encode full GFN in magic MMIO entries Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 05 15:37:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 15:37:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93849.177273 (Exim 4.92) (envelope-from ) id 1lICVn-00064R-2C; Fri, 05 Mar 2021 15:37:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93849.177273; Fri, 05 Mar 2021 15:37:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICVm-00064K-VG; Fri, 05 Mar 2021 15:37:06 +0000 Received: by outflank-mailman (input) for mailman id 93849; Fri, 05 Mar 2021 15:37:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICVl-00064D-Oa for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 15:37:05 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 42ba76b6-7de6-474b-b1eb-2e2f71fc828b; Fri, 05 Mar 2021 15:37:05 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 353ABACCF; Fri, 5 Mar 2021 15:37:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42ba76b6-7de6-474b-b1eb-2e2f71fc828b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614958624; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sH7fHFoNbJW0zjpZjVHFaY+IoMJaYqOtkkdLzA6ish4=; b=tzBpJXQ4S23JUuYr3Fgw/8FCEj79Sc+VyLP691NnZcutn0jAbPG9/Px7ZblJJk1sHybuOf wt1/6EY8f364BDBK1I+iASy3OVQtgt6voma8ceZrbnRdZ0jBc/ZRmD01+EfkztdPV7ctZo xX/hVUAleZuKhWXmIm9D9hK0cHESXA4= Subject: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Tim Deegan , George Dunlap , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: Message-ID: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> Date: Fri, 5 Mar 2021 16:37:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit We can't make correctness of our own behavior dependent upon a hypervisor underneath us correctly telling us the true physical address with hardware uses. Without knowing this, we can't be certain reserved bit faults can actually be observed. Therefore, besides evaluating the number of address bits when deciding whether to use the optimization, also check whether we're running virtualized ourselves. Requested-by: Andrew Cooper Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/types.h +++ b/xen/arch/x86/mm/shadow/types.h @@ -282,10 +282,16 @@ shadow_put_page_from_l1e(shadow_l1e_t sl * * This is only feasible for PAE and 64bit Xen: 32-bit non-PAE PTEs don't * have reserved bits that we can use for this. And even there it can only - * be used if the processor doesn't use all 52 address bits. + * be used if we can be certain the processor doesn't use all 52 address bits. */ #define SH_L1E_MAGIC 0xffffffff00000001ULL + +static inline bool sh_have_pte_rsvd_bits(void) +{ + return paddr_bits < PADDR_BITS && !cpu_has_hypervisor; +} + static inline bool sh_l1e_is_magic(shadow_l1e_t sl1e) { return (sl1e.l1 & SH_L1E_MAGIC) == SH_L1E_MAGIC; @@ -303,7 +309,7 @@ static inline shadow_l1e_t sh_l1e_gnp(vo * On systems with no reserved physical address bits we can't engage the * fast fault path. */ - return paddr_bits < PADDR_BITS ? sh_l1e_gnp_raw() + return sh_have_pte_rsvd_bits() ? sh_l1e_gnp_raw() : shadow_l1e_empty(); } @@ -326,7 +332,7 @@ static inline shadow_l1e_t sh_l1e_mmio(g { unsigned long gfn_val = MASK_INSR(gfn_x(gfn), SH_L1E_MMIO_GFN_MASK); - if ( paddr_bits >= PADDR_BITS || + if ( !sh_have_pte_rsvd_bits() || gfn_x(gfn) != MASK_EXTR(gfn_val, SH_L1E_MMIO_GFN_MASK) ) return shadow_l1e_empty(); From xen-devel-bounces@lists.xenproject.org Fri Mar 05 15:37:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 15:37:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93852.177284 (Exim 4.92) (envelope-from ) id 1lICWS-0006BG-Bi; Fri, 05 Mar 2021 15:37:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93852.177284; Fri, 05 Mar 2021 15:37:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICWS-0006B8-8U; Fri, 05 Mar 2021 15:37:48 +0000 Received: by outflank-mailman (input) for mailman id 93852; Fri, 05 Mar 2021 15:37:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICWQ-0006Az-OF for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 15:37:46 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0fca5747-23c0-4527-b8fe-b8fe6166462b; Fri, 05 Mar 2021 15:37:46 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 38258AED8; Fri, 5 Mar 2021 15:37:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fca5747-23c0-4527-b8fe-b8fe6166462b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614958665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zMJ7aPwr/7Y9nwA0xBptIGl4nEzbvFLoHnE4KtV2x+A=; b=WJWkDrFgfrDLIz8ZsKf7H7seWQ5qFEm5ETVeVqxHnjE4eGfIimWgDnfpMc6VZxI/qg5wYO 50PjQ4BTyxssKcHJ9p/dJcF0nFtXfgPahV3Xls4cfvHbxgwT5+hdR+LGjeuWht3nbGPJQZ 27/jBhCUunOIbJam+YtXo3SSqCGiXY4= Subject: [PATCH 2/2][4.15?] x86/shadow: encode full GFN in magic MMIO entries From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Tim Deegan , George Dunlap , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: Message-ID: Date: Fri, 5 Mar 2021 16:37:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Since we don't need to encode all of the PTE flags, we have enough bits in the shadow entry to store the full GFN. Don't use literal numbers - instead derive the involved values. Or, where derivation would become too ugly, sanity-check the result (invoking #error to identify failure). This then allows dropping from sh_l1e_mmio() again the guarding against too large GFNs. Signed-off-by: Jan Beulich --- I wonder if the respective check in sh_audit_l1_table() is actually useful to retain with these changes. --- a/xen/arch/x86/mm/shadow/types.h +++ b/xen/arch/x86/mm/shadow/types.h @@ -283,9 +283,17 @@ shadow_put_page_from_l1e(shadow_l1e_t sl * This is only feasible for PAE and 64bit Xen: 32-bit non-PAE PTEs don't * have reserved bits that we can use for this. And even there it can only * be used if we can be certain the processor doesn't use all 52 address bits. + * + * For the MMIO encoding (see below) we need the bottom 4 bits for + * identifying the kind of entry and a full GFN's worth of bits to encode + * the originating frame number. Set all remaining bits to trigger + * reserved bit faults, if (see above) the hardware permits triggering such. */ -#define SH_L1E_MAGIC 0xffffffff00000001ULL +#define SH_L1E_MAGIC_NR_META_BITS 4 +#define SH_L1E_MAGIC_MASK ((~0ULL << (PADDR_BITS - PAGE_SHIFT + \ + SH_L1E_MAGIC_NR_META_BITS)) | \ + _PAGE_PRESENT) static inline bool sh_have_pte_rsvd_bits(void) { @@ -294,7 +302,8 @@ static inline bool sh_have_pte_rsvd_bits static inline bool sh_l1e_is_magic(shadow_l1e_t sl1e) { - return (sl1e.l1 & SH_L1E_MAGIC) == SH_L1E_MAGIC; + BUILD_BUG_ON(!(PADDR_MASK & SH_L1E_MAGIC_MASK)); + return (sl1e.l1 & SH_L1E_MAGIC_MASK) == SH_L1E_MAGIC_MASK; } /* Guest not present: a single magic value */ @@ -320,20 +329,26 @@ static inline bool sh_l1e_is_gnp(shadow_ /* * MMIO: an invalid PTE that contains the GFN of the equivalent guest l1e. - * We store 28 bits of GFN in bits 4:32 of the entry. + * We store the GFN in bits 4:43 of the entry. * The present bit is set, and the U/S and R/W bits are taken from the guest. * Bit 3 is always 0, to differentiate from gnp above. */ -#define SH_L1E_MMIO_MAGIC 0xffffffff00000001ULL -#define SH_L1E_MMIO_MAGIC_MASK 0xffffffff00000009ULL -#define SH_L1E_MMIO_GFN_MASK 0x00000000fffffff0ULL +#define SH_L1E_MMIO_MAGIC SH_L1E_MAGIC_MASK +#define SH_L1E_MMIO_MAGIC_BIT ((_PAGE_PRESENT | _PAGE_RW | _PAGE_USER) + 1) +#if SH_L1E_MMIO_MAGIC_BIT & (SH_L1E_MMIO_MAGIC_BIT - 1) +# error SH_L1E_MMIO_MAGIC_BIT needs to be a power of 2 +#endif +#if SH_L1E_MMIO_MAGIC_BIT >> SH_L1E_MAGIC_NR_META_BITS +# error SH_L1E_MMIO_MAGIC_BIT and SH_L1E_MAGIC_NR_META_BITS are out of sync +#endif +#define SH_L1E_MMIO_MAGIC_MASK (SH_L1E_MAGIC_MASK | SH_L1E_MMIO_MAGIC_BIT) +#define SH_L1E_MMIO_GFN_MASK ~(SH_L1E_MMIO_MAGIC_MASK | _PAGE_RW | _PAGE_USER) static inline shadow_l1e_t sh_l1e_mmio(gfn_t gfn, u32 gflags) { unsigned long gfn_val = MASK_INSR(gfn_x(gfn), SH_L1E_MMIO_GFN_MASK); - if ( !sh_have_pte_rsvd_bits() || - gfn_x(gfn) != MASK_EXTR(gfn_val, SH_L1E_MMIO_GFN_MASK) ) + if ( !sh_have_pte_rsvd_bits() ) return shadow_l1e_empty(); return (shadow_l1e_t) { (SH_L1E_MMIO_MAGIC | gfn_val | From xen-devel-bounces@lists.xenproject.org Fri Mar 05 15:47:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 15:47:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93855.177297 (Exim 4.92) (envelope-from ) id 1lICfl-0007Gf-4N; Fri, 05 Mar 2021 15:47:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93855.177297; Fri, 05 Mar 2021 15:47:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICfl-0007GY-18; Fri, 05 Mar 2021 15:47:25 +0000 Received: by outflank-mailman (input) for mailman id 93855; Fri, 05 Mar 2021 15:47:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICfj-0007GT-PA for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 15:47:23 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ca871292-58e2-47d2-88bd-5b218e6620df; Fri, 05 Mar 2021 15:47:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca871292-58e2-47d2-88bd-5b218e6620df DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614959242; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=cBvmCpWeivhct2l3cWCJCAq+equeVvw0k7lCfio0RFo=; b=e+UKLPSAdC2FjnDRDb3KTA73FfubqFu49PSZU3g2dNCSpx9b237Q43DH +ZlhFZYhcMIatYeLexrieBrBNZ3RJhePYEQxMPYxONxkb3/4gmTO+67KN xOX7cVlNpjTA1zp4ShnK7HfkEWpuqhdhW5JvyNHp47GkmvWa3oE8ZXvHM o=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: eoluYMCfTLpbChRQx9AB3M27GVRXl6vrUfWtX/AmCXKBvwAy3OHyQy5BnJIDUg20VIPeizooyA iAC1zrJHeRGxLUqmRwOUXbTL75caeVihBrDCmX2mnXM5gyHoS8iZpuloxGZmEX/0dAeIACJoyw z8OrroT1r4rHoau7+7krLgD3xG8ddEWHaeAAR8Awa50pCkJq09mS8QhWXpdON1V5miQMm/c/nt 4C8gWsKC4zoppJ/WrDzzX85r2JGI1Bcw+kYgE3iA4dwp1ICrdojdmakMbHWHNnhBI/z7bBA/Ue FaU= X-SBRS: 5.2 X-MesageID: 38638124 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,225,1610427600"; d="scan'208";a="38638124" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c7cPw6nhmrEx+/2SGcs2B6dAEGq4uXzX+gah/zJD5Mc4k4hu1vQCQJdLdoaqsZ7ozaOKMIOXPrY2bmOpYS7ua6JUTQf8LfZFQG0rioWAfJAJPPkOw7DX+eiuhmDLXGfY8NlUCBOw34rz6/twlUyf5jqOkKfD2castnFurVmXQi+hUD5tMFAtqQJNA12f7ImRgh7WgHTRXF5dGfCaU+xbwiEDLelMirtJLHYMxQS0JeNOcOcfD9moBl/R5h0ooBZPe9EAXEhHtXunv+QaeGZlcxGmcywKNF2Xyr6oYGpO42t0015xk6wEJ7edCde+me+kpcyF67Jh3Tb5CPLVvfPGVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cBvmCpWeivhct2l3cWCJCAq+equeVvw0k7lCfio0RFo=; b=TUjjdwJb+N4Zx4eC35j2/93J/yAvDVCFyU1J0AWxBlA5OvrlwzprSWZf9dW58yRttlIRdGEZtFoVlzAdWVP62/rUXzKVLfQkUM2G9fmKck571Ly4h+RSugoS4/zqdByjjLS1tEm8pB8UK2So4J/cbQrmyl0sGGUMv5Em4anIjzxnzkJQek4NEOMWkTDASJBpmC58Z2yUJ0SXy1BvyodqhQbNVPv95vBaco1FwWXR7ixCDULn2VoLIRap29NK8GQvDh4Lk0mvA2utiPDAw0Ra4igFqaz8VIvcb6IQpbbMyaODzm4Dm3ij3cc/zd4173/eHiuV6IcNmQTAK3AtSMXs0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cBvmCpWeivhct2l3cWCJCAq+equeVvw0k7lCfio0RFo=; b=NBxpNHYJ3VEdpgklr6f6W3RnBMWLBdmfN0/V1gG8TvQIm1xNrkoZedoaYDyzylrJXfe46qdv+rkjeB1jMIRzs+sDZR5nnb+hJkAF+bzcN0mRZv7+ha9K5n4f5V9hsfOd0AfzSpZN00IOcce2kKAHshBrt5H26l5YZuloXBXPlQc= To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Tim Deegan , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> From: Andrew Cooper Subject: Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized Message-ID: <2e09dfd0-5da4-bdcc-900b-d40a112d832b@citrix.com> Date: Fri, 5 Mar 2021 15:47:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0496.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ee10b90e-086d-4447-d23b-08d8dfedf428 X-MS-TrafficTypeDiagnostic: BYAPR03MB4741: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bLTRl0Nmltg/gcPBTLGPpytt06/6/btTaNb02dJOzH58Hs4vlUh+IqjhGtpFOQM6GubHPxv9npkMVcXJrcWSSOAnvSmGYkwJVMcXzWe/BaMhQdgULueKQRAINzB9MWgCqlp06ELvZ+2tShtQDtqlIN1OxR1y9gRab/hvD3oMmNj7Wqc/O39hwesoH8Ougp7kAZwMGA4s9or9xV1QaWXVhSGJq4GmaKc06d9j2SX9zPfwlBizP5srvCQbU5it+ZhHOH0kzuXSPoRcUkKD6Hq2lqHkKpanPqq7UWLsM1B2axZUAz6kWW8IOIG89eEcLhgpqmiuvmeYpGHYLpvV9QRYBR6u1qEh9n7mmX+6sgcxz3tCM6Zp7QefTIRXyC242qSU6h5ALmIA/0ou+YKsD2OO8uqdjnDbQgS0fd2KgkVypcURIsA3OLBA8IjuA4K/eXLyDZtyoKQZsWpJcO2Xv0ey7HgoKdnZ7j079UT658wq7i+8A16rXJlOgb7Xc9gk74mzrcNYD6uXOvUQ/tLaEjcqoLvp0boJE8IqUf/SEHq+Y0mx4e3yxxN7wCGF/reQCzJkk2B57uUsaUdpcJ3UUWu+7dG0q8zEtBri6eqhNA7zhcw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(366004)(39860400002)(346002)(136003)(66476007)(2906002)(8676002)(36756003)(186003)(478600001)(316002)(31696002)(6666004)(16526019)(4326008)(66556008)(26005)(110136005)(6486002)(86362001)(16576012)(54906003)(53546011)(8936002)(956004)(31686004)(5660300002)(83380400001)(66946007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?N2RLSkFhcTl4ZUJtL2JFb0UwZVJCdndDOWVsZmYzbnplUmF2WDN0R3ZpSXln?= =?utf-8?B?UGRIV3owUGhVdXFHM2NkZ0NFVVdScmNrM3FBMzNIenJ1cCs2UmFvNFM0b0py?= =?utf-8?B?STExb2dWcUdmUXFGTzRYNUZ6Z2hVb2V0ckNTM3d0N0tFaUg4eGczN25iSHNY?= =?utf-8?B?S0oyR2tONVlyaUFRTHZBT3hpSVNLNUlNaTE0djkrRW9XWVIxTmpsOENJcytZ?= =?utf-8?B?T2Y5TG5WOHZlYXFzeGNDRThHT3BCS2pCcHdDcFpUMFpqSDBjdTMrZThaSFMx?= =?utf-8?B?TkkxSlR4ekpZYWcyT0ZnbXJ6MFowb3phb0NuS1V1cmdINGYybVZKMnJCRFV1?= =?utf-8?B?R0RFRWpBdEZINnh0YlVPZVJRbkMvTUpoZllEL3hOLzR5UDJPV3ZpRm9xVHFL?= =?utf-8?B?a2l4eEpLd0lrL3AvYTUrdFlseVN2QU43YnZLNXk1U0ZrTzlXdjNXWVRvbldt?= =?utf-8?B?dlhuaEE0SElTL3FCNU5BYkF4ZnBtQ0FBZU1XS3draUt0RVlTUFNXc3k0dlB3?= =?utf-8?B?UU5MMndRa05VMDFYUkUzRURsTGpDRFJ2SzNXRnlHWnBSWHExYWUza3AwWTVt?= =?utf-8?B?Q24yLzB6cy9CM2NFbzU0QXd6ckZVMVBzUmhHRTdleCtpakJtRzNobXBGR0Rm?= =?utf-8?B?bUJnNUhUeU9sZG1MSGlUNmQ1emZHd05QMkw1Z1NITTBzNStvcEtzQVN5Yk1T?= =?utf-8?B?ZWhGV2lMQWJ3TWlDdEhhVC9XS2V4MEFSNW1vZU9GRzdNb3E4dHhZU1c5ZTNk?= =?utf-8?B?dmhPVWtwaXhLbStxSVgvd0RmV1NoTXcyVjJCdksxdEZld2JpajE3K1hYZ2xa?= =?utf-8?B?ZExaNDNUb0NXNU42T2NncU9oSVhHcklRQUtvdk9YY1ZUdG9MNlpFUUIrTFRB?= =?utf-8?B?eEhqWW1BNnA4bHZVaVl2STFCSXBDaUZwa0o4Vi9nWHVVVldGcmxxSFpwcVpL?= =?utf-8?B?MGNLT1Z6VnRtSXZjc3pxSnBBZ0oxVDUvNEpsVGFoVmtVTTZsdlllUEJLM3I1?= =?utf-8?B?MnVUbzhzQjJMWFVZUmkzZE5vR3diNS9qd1A1bkNtdmdaQ3RhYUZBc0t5RUFV?= =?utf-8?B?aHdadVZrS096dDl2ODA4S2FhVHlYQndwK2V5VXl3K0VxaUswTXR3QmtaazlF?= =?utf-8?B?bFBONnJ4SEFVZ0lsdzJvQTROYklTU1RlTzk0L2tOdnpiNEliamZUdEpKbUY3?= =?utf-8?B?RmZFK3JuUUxHYStObzdGcXFXUm5aMXRwVFpsc0Q2TFJDckphZXdyZ1lRU1Q2?= =?utf-8?B?dlVqYU9BYmNUQnBtbGlZV2VYcFFSeVR1a1pjejRTV2xNSFJ6T2d4RjZ5SC9n?= =?utf-8?B?WXVPbDdsb0hKaXFvQXUwWVRHRytUSEhwOGh6MnVtcVJzanZ1K3ZzOEJxZXMv?= =?utf-8?B?ZjJ1M3ZoTzhyWlh0MUVvVnFLV2JWUTU5aTN5VVBEYTV5ekgrWVlnOTY1VWdV?= =?utf-8?B?ak5ORXVGY3F6a3JRRVIwN0xCYkhOd2ZZSjVaZ2ZtT2JHRlFSVEMvUDg0andv?= =?utf-8?B?eThncm1yd1FWRGlQMzJrSlJ4ZUtrTGVEd2xGOGMzZU9BNU1UNmpadmV5UmlI?= =?utf-8?B?V2JBRXFEWnhnSHJrZ2VpeS9vTTVrb0h5dWkyOG1zTWZtRE5BS1Z1RFVoZmI2?= =?utf-8?B?dWpyRXRmc0ZFOWptSDlBVmZjTnYzMW5nMzRlOXVyUUs3WHZBZHN1aURJQVFP?= =?utf-8?B?eUZmRWpsTXJpS01aU0VvTWtIYzRyLzloYXRqUlZQbkRwRzRUL2l6UmRJenpv?= =?utf-8?Q?gGtAFfcZQIyPGZ44v2ag68y/fzUEMDu3rmqc08Y?= X-MS-Exchange-CrossTenant-Network-Message-Id: ee10b90e-086d-4447-d23b-08d8dfedf428 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2021 15:47:17.2772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x5694hESdV9DPhphaHdeaKeeGNUb/c92JCTsTWkh8c1cnlSE0OojkXZLJqOKfIqqI8522JE6VDRIKvrT0/R82pgTVy+6f+xfs+QIqOzUYeM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4741 X-OriginatorOrg: citrix.com On 05/03/2021 15:37, Jan Beulich wrote: > We can't make correctness of our own behavior dependent upon a > hypervisor underneath us correctly telling us the true physical address > with hardware uses. Without knowing this, we can't be certain reserved > bit faults can actually be observed. Therefore, besides evaluating the > number of address bits when deciding whether to use the optimization, > also check whether we're running virtualized ourselves. I think it would be helpful to point out why we can't even probe at boot - the behaviour may genuinely change as we migrate, and if we ever end up on an IceLake system levelled down for compatibility with older CPUs, the "paddr_bits < PADDR_BITS" check will malfunction in an unsafe way. > > Requested-by: Andrew Cooper > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper This wants backporting to stable releases, so I would recommend for 4.15 even at this point. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 05 16:01:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 16:01:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93859.177309 (Exim 4.92) (envelope-from ) id 1lICtg-0001JD-DO; Fri, 05 Mar 2021 16:01:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93859.177309; Fri, 05 Mar 2021 16:01:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICtg-0001J6-AG; Fri, 05 Mar 2021 16:01:48 +0000 Received: by outflank-mailman (input) for mailman id 93859; Fri, 05 Mar 2021 16:01:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICtf-0001Iy-04; Fri, 05 Mar 2021 16:01:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICte-0001g1-Lk; Fri, 05 Mar 2021 16:01:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lICte-0004FW-DX; Fri, 05 Mar 2021 16:01:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lICte-0001SW-D6; Fri, 05 Mar 2021 16:01:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tK1NEKL7mcfE2/g3g1TU4vfS7U2LPKrr4qxrkACDkQI=; b=1758Th7SvuNOiykohOAypEY2mb KPoHMW7fn7rf9AR3IPMraC4v0c7NCtvC0gW5cF2S5eGBItuv7fYZRPpQ6v4EkKsD1UzxpD39Pm4LE d6WkAgL0m2sm3eIDCWQjwb4nuVuq1NeDL32V93fhUf88JCLtaR9zkMRyGdobdVSnKp/I=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 159836: all pass - PUSHED X-Osstest-Versions-This: ovmf=c5740f360636479fb91681093b1dee1cc366075c X-Osstest-Versions-That: ovmf=ef91b07388e1c0a50c604e5350eeda98428ccea6 From: osstest service owner Date: Fri, 05 Mar 2021 16:01:46 +0000 flight 159836 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/159836/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c5740f360636479fb91681093b1dee1cc366075c baseline version: ovmf ef91b07388e1c0a50c604e5350eeda98428ccea6 Last test of basis 159800 2021-03-02 05:40:45 Z 3 days Testing same since 159836 2021-03-05 09:09:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bandaru Bandaru, Purna Chandra Rao jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git ef91b07388..c5740f3606 c5740f360636479fb91681093b1dee1cc366075c -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Mar 05 16:25:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 16:25:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93880.177324 (Exim 4.92) (envelope-from ) id 1lIDG7-0003LG-9Z; Fri, 05 Mar 2021 16:24:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93880.177324; Fri, 05 Mar 2021 16:24:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDG7-0003L9-6R; Fri, 05 Mar 2021 16:24:59 +0000 Received: by outflank-mailman (input) for mailman id 93880; Fri, 05 Mar 2021 16:24:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDG5-0003L4-PN for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:24:57 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 7ea0c497-7950-46e9-a1a0-7b16d62c25e9; Fri, 05 Mar 2021 16:24:56 +0000 (UTC) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-xgHIlVA7Nke9YTXo2SF8IQ-1; Fri, 05 Mar 2021 11:24:54 -0500 Received: by mail-wr1-f70.google.com with SMTP id z17so1260876wrv.23 for ; Fri, 05 Mar 2021 08:24:54 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id z1sm5226754wru.95.2021.03.05.08.24.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 08:24:52 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ea0c497-7950-46e9-a1a0-7b16d62c25e9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614961496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MZDLO6AgAwZqZSFXjooFMmkuOmLvh4T78MBb11ItBM0=; b=fTlv0sdqCigpxZwb8FewDIc73RlAoMJ9MMR8grN6RLPFkywdIxRBVmHPkHglHWH3zefou1 bBUSAx6Ybb4bkQD2w7qKjNSGJHrDrhSX2HxVe1wXIEBLsz/rhjPc8teu/EGs9tKBPhftf+ nJtkQ5FOqS8E+O44K0XVNdnEcKD/b+M= X-MC-Unique: xgHIlVA7Nke9YTXo2SF8IQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MZDLO6AgAwZqZSFXjooFMmkuOmLvh4T78MBb11ItBM0=; b=GwgLFfxf6PU9Vju01KdRP4TTsKtv17wwq3e3mcSyYp40UMnZMAbXg/HOZYIhvnna4e aLdhdvQvPxEQ/O3n8JOsQkSBXr4B/2fmBUcUUB+M6xjybyseuo7oK4XA7PNj7IDyrhdQ Cb0y5GKu98lqqzZo/j7V24riWbmn5YalEiuiFjBICoGlPXXih/OkwfeVXJl7gtUneaOr xHdsgQE1P/rQA9XOdEVVmPMlgEwChIqcvbCjsZyKSrmuKhlApnu0oIBs7vN4vJaR2qZg 3+Fb+vnPnkugh2qkTxSwiRGMjFZcLaLiInc+zRPWiyRodUlFOyS/HuWnFxklzxiaJibA iMPg== X-Gm-Message-State: AOAM533kEK6n4Kjycp+QCoAGunUaFxQCLY2k9guXHjVG4JfITPC/fPi9 kBJX2zxaGpyq0tQCG22jEzHHYsA8fSX8F9pNz4VQzaDhJGdGtEcGMvXjlFGS0ko8RzFm/tNV+Sd dHBw5sgUSoIpa3P9nnvzIRXyVMxCeDrcmxrLgqTyuqJ6+gjpzanR0sFBmZKO+qluJ/k6IeLEDff Ef X-Received: by 2002:a5d:4d01:: with SMTP id z1mr10163653wrt.133.1614961492982; Fri, 05 Mar 2021 08:24:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJwhaGfuSDgbUvCEoNwU9vU3X+dGsovOI0z8QXVKWhHunJudgLUqDc6ePSfoV5mliOuqBAdvFg== X-Received: by 2002:a5d:4d01:: with SMTP id z1mr10163616wrt.133.1614961492677; Fri, 05 Mar 2021 08:24:52 -0800 (PST) Subject: Re: [RFC v4 30/33] target/arm: remove broad "else" statements when checking accels To: Claudio Fontana , Peter Maydell , Richard Henderson , =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: qemu-devel@nongnu.org, Roman Bolshakov , Eduardo Habkost , Paolo Bonzini , "xen-devel@lists.xenproject.org" References: <20210305145941.32020-1-cfontana@suse.de> <20210305145941.32020-31-cfontana@suse.de> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <36e4893f-8eeb-9e16-5d1f-4167d5dc0e7d@redhat.com> Date: Fri, 5 Mar 2021 17:24:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210305145941.32020-31-cfontana@suse.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc'ing Xen list On 3/5/21 3:59 PM, Claudio Fontana wrote: > There might be more than just KVM and TCG in the future, > so where appropriate, replace broad "else" statements > with the appropriate if (accel_enabled()) check. > > Also invert some checks for !kvm_enabled() or !tcg_enabled() > where it seems appropriate to do so. > > Note that to make qtest happy we need to perform gpio > initialization in the qtest_enabled() case as well. > > Signed-off-by: Claudio Fontana > --- > target/arm/cpu.c | 10 ++++++---- > target/arm/cpu64.c | 13 +++++++++---- > target/arm/machine.c | 19 ++++++------------- > 3 files changed, 21 insertions(+), 21 deletions(-) > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index be86bd4b8b..353cd652bc 100644 > --- a/target/arm/cpu.c > +++ b/target/arm/cpu.c > @@ -37,6 +37,7 @@ > #endif > > #include "sysemu/tcg.h" > +#include "sysemu/qtest.h" > #include "kvm/kvm_arm.h" > #include "disas/capstone.h" > #include "fpu/softfloat.h" > @@ -564,7 +565,8 @@ static void arm_cpu_initfn(Object *obj) > * the same interface as non-KVM CPUs. > */ > qdev_init_gpio_in(DEVICE(cpu), arm_cpu_kvm_set_irq, 4); > - } else { > + } > + if (tcg_enabled() || qtest_enabled()) { > qdev_init_gpio_in(DEVICE(cpu), arm_cpu_set_irq, 4); > } > > @@ -741,14 +743,14 @@ void arm_cpu_post_init(Object *obj) > ? cpu_isar_feature(aa64_fp_simd, cpu) > : cpu_isar_feature(aa32_vfp, cpu)) { > cpu->has_vfp = true; > - if (!kvm_enabled()) { > + if (tcg_enabled()) { > qdev_property_add_static(DEVICE(obj), &arm_cpu_has_vfp_property); > } > } > > if (arm_feature(&cpu->env, ARM_FEATURE_NEON)) { > cpu->has_neon = true; > - if (!kvm_enabled()) { > + if (tcg_enabled()) { > qdev_property_add_static(DEVICE(obj), &arm_cpu_has_neon_property); > } > } > @@ -849,7 +851,7 @@ void arm_cpu_finalize_features(ARMCPU *cpu, Error **errp) > * We have not registered the cpu properties when KVM > * is in use, so the user will not be able to set them. > */ > - if (!kvm_enabled()) { > + if (tcg_enabled()) { > arm_cpu_pauth_finalize(cpu, &local_err); > if (local_err != NULL) { > error_propagate(errp, local_err); > diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c > index 7c27b0febb..be3c1c6f36 100644 > --- a/target/arm/cpu64.c > +++ b/target/arm/cpu64.c > @@ -23,6 +23,7 @@ > #include "qemu/qemu-print.h" > #include "cpu.h" > #include "qemu/module.h" > +#include "sysemu/tcg.h" > #include "sysemu/kvm.h" > #include "kvm/kvm_arm.h" > #include "qapi/visitor.h" > @@ -296,7 +297,8 @@ void arm_cpu_sve_finalize(ARMCPU *cpu, Error **errp) > */ > bitmap_andnot(tmp, kvm_supported, cpu->sve_vq_init, max_vq); > bitmap_or(cpu->sve_vq_map, cpu->sve_vq_map, tmp, max_vq); > - } else { > + } > + if (tcg_enabled()) { > /* Propagate enabled bits down through required powers-of-two. */ > for (vq = pow2floor(max_vq); vq >= 1; vq >>= 1) { > if (!test_bit(vq - 1, cpu->sve_vq_init)) { > @@ -333,7 +335,8 @@ void arm_cpu_sve_finalize(ARMCPU *cpu, Error **errp) > "vector length must be enabled.\n"); > return; > } > - } else { > + } > + if (tcg_enabled()) { > /* Disabling a power-of-two disables all larger lengths. */ > if (test_bit(0, cpu->sve_vq_init)) { > error_setg(errp, "cannot disable sve128"); > @@ -415,7 +418,8 @@ void arm_cpu_sve_finalize(ARMCPU *cpu, Error **errp) > } > return; > } > - } else { > + } > + if (tcg_enabled()) { > /* Ensure all required powers-of-two are enabled. */ > for (vq = pow2floor(max_vq); vq >= 1; vq >>= 1) { > if (!test_bit(vq - 1, cpu->sve_vq_map)) { > @@ -609,7 +613,8 @@ static void aarch64_max_initfn(Object *obj) > > if (kvm_enabled()) { > kvm_arm_set_cpu_features_from_host(cpu); > - } else { > + } > + if (tcg_enabled()) { > uint64_t t; > uint32_t u; > aarch64_a57_initfn(obj); > diff --git a/target/arm/machine.c b/target/arm/machine.c > index 595ab94237..cfc2bb4982 100644 > --- a/target/arm/machine.c > +++ b/target/arm/machine.c > @@ -638,24 +638,21 @@ static int cpu_pre_save(void *opaque) > > if (tcg_enabled()) { > pmu_op_start(&cpu->env); > + if (!write_cpustate_to_list(cpu, false)) { > + /* This should never fail. */ > + abort(); > + } > } > - > if (kvm_enabled()) { > if (!write_kvmstate_to_list(cpu)) { > /* This should never fail */ > abort(); > } > - > /* > * kvm_arm_cpu_pre_save() must be called after > * write_kvmstate_to_list() > */ > kvm_arm_cpu_pre_save(cpu); > - } else { > - if (!write_cpustate_to_list(cpu, false)) { > - /* This should never fail. */ > - abort(); > - } > } > > cpu->cpreg_vmstate_array_len = cpu->cpreg_array_len; > @@ -754,20 +751,16 @@ static int cpu_post_load(void *opaque, int version_id) > */ > write_list_to_cpustate(cpu); > kvm_arm_cpu_post_load(cpu); > - } else { > + } > + if (tcg_enabled()) { > if (!write_list_to_cpustate(cpu)) { > return -1; > } > - } > - > - if (tcg_enabled()) { > hw_breakpoint_update_all(cpu); > hw_watchpoint_update_all(cpu); > - > pmu_op_finish(&cpu->env); > arm_rebuild_hflags(&cpu->env); > } > - > return 0; > } > > From xen-devel-bounces@lists.xenproject.org Fri Mar 05 16:29:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 16:29:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93885.177336 (Exim 4.92) (envelope-from ) id 1lIDK1-0003WL-UA; Fri, 05 Mar 2021 16:29:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93885.177336; Fri, 05 Mar 2021 16:29:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDK1-0003WE-R4; Fri, 05 Mar 2021 16:29:01 +0000 Received: by outflank-mailman (input) for mailman id 93885; Fri, 05 Mar 2021 16:28:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDJz-0003W9-SY for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:28:59 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fdba039f-2591-41cb-b087-f5625414504c; Fri, 05 Mar 2021 16:28:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 43FDAACBF; Fri, 5 Mar 2021 16:28:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdba039f-2591-41cb-b087-f5625414504c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614961738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/dFvgRp6OwKzIedO5BBFy/xt22+KtFLnejFnN6oawMY=; b=rokApWnhAxI+Pvw36mHyKEuyFmJDq2kA9/J7CFbNQyDEIyB4ivPLQ2dGVpC0h58sqkW4oz L1LhxxiHXKBnn8rJyzIDvQuKQVpcfbU8qwPtF4cA5U+2+T7uZyaFs/xhY/Vx5GHP2sQrGI TylL4WLRu1gUGrVtw+VbI4HKOkAmqaE= To: "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Wei Liu , Anthony Perard From: Jan Beulich Subject: [PATCH][4.15?] libxl/ACPI: add missing build dependency Message-ID: Date: Fri, 5 Mar 2021 17:28:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Just like all other object files - wherever *.o is mentioned, *.opic also needs mentioning to yield consistent behavior. Otherwise make may decide to (re)build the object before recursion into $(ACPI_PATH)/ (to update $(DSDT_FILES-y) and ssdt_*.h) was actually finished. Signed-off-by: Jan Beulich --- A related but separate issue is that build.o* get rebuilt even if none of their file dependencies changed, merely - aiui - because of their dependency on the phony "acpi" target. It may be possible to limit this rebuilding by making both depend on $(DSDT_FILES-y) instead, but then they would still get rebuilt for no reason when that file (if any) changed (but ssdt_*.h didn't). --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -32,7 +32,7 @@ ACPI_PATH = $(XEN_ROOT)/tools/libacpi DSDT_FILES-$(CONFIG_X86) = dsdt_pvh.c ACPI_OBJS = $(patsubst %.c,%.o,$(DSDT_FILES-y)) build.o static_tables.o ACPI_PIC_OBJS = $(patsubst %.o,%.opic,$(ACPI_OBJS)) -$(DSDT_FILES-y) build.o: acpi +$(DSDT_FILES-y) build.o build.opic: acpi vpath build.c $(ACPI_PATH)/ vpath static_tables.c $(ACPI_PATH)/ From xen-devel-bounces@lists.xenproject.org Fri Mar 05 16:32:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 16:32:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93894.177347 (Exim 4.92) (envelope-from ) id 1lIDNa-0004V0-Dr; Fri, 05 Mar 2021 16:32:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93894.177347; Fri, 05 Mar 2021 16:32:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDNa-0004Ut-Ae; Fri, 05 Mar 2021 16:32:42 +0000 Received: by outflank-mailman (input) for mailman id 93894; Fri, 05 Mar 2021 16:32:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDNZ-0004UY-DG for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:32:41 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0c3bcc94-cee5-42d0-be22-89ba5e19e16c; Fri, 05 Mar 2021 16:32:40 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9CE72ACCF; Fri, 5 Mar 2021 16:32:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c3bcc94-cee5-42d0-be22-89ba5e19e16c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614961959; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KQ2/vWMUuKzn9F3oHXv1LsJAwdrsxvRMcVPYk52WAWI=; b=bZ44BAmW4XcM1txeK4Q79K1bmCKG6D47K87eNyEZd9KyrCJYpkE/NigiJR2mPE/6O50GcF wmNt8WEtywjeSngbELztO+ABVNX9oSxAGbOxt+ZX2OpniF4YhDqugBeXMcbAzWcglC8jJz zpY5vejISlnyFb+LXc72cTPUsNPSB5Y= Subject: Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized To: Andrew Cooper Cc: Tim Deegan , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson , "xen-devel@lists.xenproject.org" References: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> <2e09dfd0-5da4-bdcc-900b-d40a112d832b@citrix.com> From: Jan Beulich Message-ID: <0f2a1a97-f062-fa2a-5f5c-ea776e463c44@suse.com> Date: Fri, 5 Mar 2021 17:32:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <2e09dfd0-5da4-bdcc-900b-d40a112d832b@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05.03.2021 16:47, Andrew Cooper wrote: > On 05/03/2021 15:37, Jan Beulich wrote: >> We can't make correctness of our own behavior dependent upon a >> hypervisor underneath us correctly telling us the true physical address >> with hardware uses. Without knowing this, we can't be certain reserved >> bit faults can actually be observed. Therefore, besides evaluating the >> number of address bits when deciding whether to use the optimization, >> also check whether we're running virtualized ourselves. > > I think it would be helpful to point out why we can't even probe at boot > - the behaviour may genuinely change as we migrate, and if we ever end > up on an IceLake system levelled down for compatibility with older CPUs, > the "paddr_bits < PADDR_BITS" check will malfunction in an unsafe way. I've added a sentence to this effect. >> Requested-by: Andrew Cooper >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper Thanks. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 05 16:33:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 16:33:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93897.177360 (Exim 4.92) (envelope-from ) id 1lIDOF-0004aW-Nn; Fri, 05 Mar 2021 16:33:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93897.177360; Fri, 05 Mar 2021 16:33:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDOF-0004aP-K6; Fri, 05 Mar 2021 16:33:23 +0000 Received: by outflank-mailman (input) for mailman id 93897; Fri, 05 Mar 2021 16:33:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDOD-0004aI-Tj for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:33:22 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 04bb71ca-854a-4d91-918b-0474c3336357; Fri, 05 Mar 2021 16:33:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04bb71ca-854a-4d91-918b-0474c3336357 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614962000; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=3KcCIxfmPJW8Z5moBG/o9/B6agiYtOl0+NMH+LNA6sY=; b=E1QkbNnXspm6T+3GQrqM4/IX7erfkyxrZlNT+iTPsu6mLpA5PXkZCk1f BHH/kkoJ9t8neXR4U1B50BkuhSSL2tMAt/Gc1O1Negavg5beC7N/FEya1 tZc5f4O+YEXk4xzQmr/KhNxXJ9kU3rkEZqgj39insYCUCIBjexUTLVMnc Y=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: V7UPt24OrqGRsTTWsI4AM9znFChnlbvllxDaOEwwFwBule7ChCKZuhhEvnDiok5cMwnjm4PRyu nHXBhEESnHOO4hS6IYoIfhGzdLWbd0RQVaAFgsfow8ZmlApO0z/6TAlYMncSDTcJpUVBcLJi7S b8qNglAHMDq1DaRPAHG1mYXWMGLDjcbu/YZz+Am3/BL7CHAtkQmsd1Y91sAOqIysytut5FzNHz lPHrJxqQF9xSSF18XUVixwvdeC2CDP7AdFJTP+j+1L/tEuB6KnRpZwWLNDKfb5odYnLqwv4uud zpU= X-SBRS: 5.2 X-MesageID: 38566661 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,225,1610427600"; d="scan'208";a="38566661" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MhfvXk8uikwcHhASUbkg6ZuL1B5YHhb7xeUFGosMX49Sh16cLbtxRpfRCWFAYP8v49M/eELKvUQdJwDQCvA3gXeDPWGqQQoU5GZlNA5q9+gb7yuDHNcuPNG1gUvHExFxXjLf1p0E9/uKq0IWOMZKCPkn9lC5ocOFviByFBrxWbkmR1eYMkVbf1OgonIP2wSmvOmmFqUQdpnUVUhcYWby5JFCRZGETqBq2gpaUvHkTiq9EHUX4U1C4otS0cltqYOTSEROXXwiqFtpyg9xxCtEJeDjJf7sztNk1A8F5XbXk7YtnoG+BtqH8LM30jHn86K7Zrdke7yWo+jfyoYMZ/0ufw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DJlnwKq9Bt5dEneSDOUnS+rOw4mZ/hf1iYSBu0DysHE=; b=Klg0NpWWyNRjCZnNqi2lQstUzYhqbTxop4f7D7ALI6awwPKjeWCSx8ve2lPdEhnsPUDeD5m4E4KecvgR/wD8jtFiR2NPCBsOWSRY8SSMBKSA5fEjD2W4qMRXDgPvjHsh4Ll2o1eRDcNAE0wds2Gxg3jlVu9mubiCakk1wuv1rimVI84ulDpVr6ElvRhjYOm08vN6mTGYQYEH8jpYalHkXB/hUgwPEVWoZpZkiA6tUZbHBnyeS7csDQLKxwVhOhf2lVBN1ZHtJzD7ege9xgVQhy4pPWfBlj5aB6TDQT+NDHBuVfjGIVHlnOR8s+Jkp0mVVTJaMuzJR9Zvby5GooAG+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DJlnwKq9Bt5dEneSDOUnS+rOw4mZ/hf1iYSBu0DysHE=; b=j5HngWWjgrZxaaOIOLUJU2Ub6CQbiABCq14ryrWtsNHAIESHVzhFGTU2AuJBOCiuAbrnulm2XJABfvui6LMP6vlkqXhKeFDthujGGD5VotHgeRpZJYykaS3PYhNaGbaVmPAn0lg2geR1ydDVkfnMjU1burVgTbsXfwP9r5QyFfM= To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Tim Deegan , George Dunlap , "Wei Liu" , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: From: Andrew Cooper Subject: Re: [PATCH 2/2][4.15?] x86/shadow: encode full GFN in magic MMIO entries Message-ID: <041aed42-929d-287d-f9e4-c12e5a71ab38@citrix.com> Date: Fri, 5 Mar 2021 16:32:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0008.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 917ea0b9-574e-466d-330b-08d8dff44a76 X-MS-TrafficTypeDiagnostic: BYAPR03MB4166: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9IRWvsQGwnO+ODpHxHqUMTagS7W7FKnmsMMResMFDhJrRtDvAm5gQKUgG3QIXTrG+SKqEXs5UPpIK3HRFGN3wiu0fUSVWBH0DYxZYGfFkA613zzI22W6B0OKCNejpe2NKnJsPiimmiXheAHOHuTUUPqkM/+pReenbOQvYCk/AOZhQ0aeEAtpQCzjbagHsUbkXggpLXafZhya6Nqof0w6cNGmOfbx80tcU3h/hefwBOcFb7okt5xI8NDq76qhs/9b31BFnAn/eK6TM0sh0BOWA4VCgAphnCYn8LsCpqxx9vt4rxfyMNaOK41TdE2M7VUhdoWpPK7AwIzySYUXbg2/wPoslDYeMxlK8n0WDxeBBNyWXUt7iEU9p6YxxwNOOWLjBtOsUTE/DWjExzHXo2atG5HhFWr67zN6WGkXbKm0d3cOPWPtP+Levrfn/Hc+LU6hD1GeIQR+DK2L1wKmikyx0KY7DgzeB+yNfbpT4ldzKDQBkihrIRnvaoX6uNDM8FvFcOzmBDZ4ryJtvP1FAyeGFNlAWghQICi+5j+bJlLtUZyHNxQehmB+E7sWeFF3uLAVEDgRqB2RTC+xfnK5BKmERKE+zze/hjQe8DpPQwajnKa389DK1WpWLZOZLux84N3K X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(346002)(376002)(136003)(396003)(16526019)(956004)(31696002)(186003)(478600001)(53546011)(26005)(2616005)(316002)(6486002)(16576012)(6666004)(5660300002)(66476007)(66946007)(66556008)(54906003)(31686004)(110136005)(8936002)(4326008)(2906002)(8676002)(83380400001)(36756003)(86362001)(43740500002)(45980500001)(357404004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WlRaUUtVYzA4dzhFZG1RRnpZV2lGdGJXWTJnZlJjRk8rRjVWSUg5N01vZzdj?= =?utf-8?B?YmJsTVlkYWppK2crYmpwVDlDSm41ZEVWRG1CYzY4bmVzZlluRnFpZDNOdlpD?= =?utf-8?B?NURvbnFvRUFOemJWUVNiRXlhaGpWZ2RaN1BCcHlEZTV6M3VWZzZvRUpsSlVa?= =?utf-8?B?MG83TnBNSDc0VHA1Y3NXRzJzMWhoOVVRME9SMVFmVEhWZkQybTBqdFlQdEVn?= =?utf-8?B?WlEyTEdySGNNa2ZQaWt4eTN2NjZGaytRRHNaWUcyeVl4S1ZGSFFJZXlaeEFD?= =?utf-8?B?dVJDNFhqeFl0TTVUNy9LRE1wdm9NYithR2Q1ZVJ2M3B2ekltRjFzeXB0Rno3?= =?utf-8?B?UzlCbU1tY1V1bUZOSzB2TmJFS2k0UEpOMkJjZEJTYkgrMGlMNXNtOGJnaFQ1?= =?utf-8?B?citPM2l0UkhTUUo5Z0dwQ1RLZ2hUQmVWeDF3c0xWVEs5ZGwrL3ZBaitUUjhq?= =?utf-8?B?VjBNMmtPNlZCdkxSdVpKRW52K3dtZEozbC9MMWZwTWRsUk1DazBTdjNZaGl3?= =?utf-8?B?Q0lxalFVZ09KbWFIVzNqRHJCcEY5VXFyNTRJbzhnTjhXQ281emJyT0V4YTdl?= =?utf-8?B?Njk5K3JBR3MwRTZtalQ2b3d2RkxXUUhCU3huNTlleXlPTWRPUWdJL0VuOE1P?= =?utf-8?B?a0lZbVZOaVpXQjU1TW9ubGpWTkFabEdoWHErQUpkK29GZm84bnZRL0ZXUExM?= =?utf-8?B?WTBUMy9kOTZBU09yUllCRHM2c1Jwb1lOZlNvb2pCS3NqWDNWWnV0NVNaUlQ0?= =?utf-8?B?VU9zTHVoMEpUNGt1R1ZjbVNPS3Q1ZzBacVhGdkhVNGZBTmxrallKc1JqdUhT?= =?utf-8?B?elVBSWhIWmxxNHpmWjEyQnllMzNFdmZ1NDlycUNPWGpPVkhZNW4yd1JvZGRM?= =?utf-8?B?N3liUlN1THBsWFdzdk1xTnNQOU84NU9ocDFIczd2b3UwZy9zQVg2b0xZOU1q?= =?utf-8?B?dVdRTHZiKzJrMkwxOTg2eVJUNk1oVVhLQ0hGLzFPYXFUMzdHdkFwNUlVa1NL?= =?utf-8?B?VGRwMzl0M0xIT2pEeXRyWTIzenJJSXRBVUE2a3AxVjFYdEJJSUFrN29wUitM?= =?utf-8?B?bGtVd1pjaVkraUNrcnVwNUpONyt0OEo1b25SaHVISUFyZ21jZFdGdTZXUkV5?= =?utf-8?B?NUVDOXJZZVhtL2RvTE8zU2FNQWJFN0doY1pac3N2bS9tcHRqVklvNmFIWHhr?= =?utf-8?B?MHpYRnd1YTJCRDBHalhFRzJmMWptS0wvYWZySW1vb2tiMDBIY2I3eXNyaUpP?= =?utf-8?B?L0srSTRaTHVwNXU0QS9LL0lmeDBQcnQrWW8vSTh0MUhOV3pXZmVDTWV2dnZt?= =?utf-8?B?UXVHdmYwTHBXMGY1Vy9wT1BrSGNIb3lMSmFHSVEvTFcxUnFKckNHanNDS3pG?= =?utf-8?B?TDA4TDlYK2xMRk51RWo3SnliVGZrZW9DSUsxVS9hM1k4ZlZ4cXFKcjNmU2FQ?= =?utf-8?B?bzI5TWxBdEpVN1ZtejZhOS9pdG9HejN0S2JNM1QwTWpNZjZGTTdrTFpEeW9k?= =?utf-8?B?TFVJWnNpQk9nMCtYS3g0MGVWbmJNREFLSTZqUWFmYUlKRDcxSU01eGpJOWl0?= =?utf-8?B?Z2FqdVNnNjQ1bUpDWEJKaDBPaGs1VDJLZERDUnd4NjBSemU1SW5oY1lLWjJC?= =?utf-8?B?bmplUTBwVWRYQjZ6MERkSEZuNnI0cTM4bkpRblZ6eUNSYk40N05QdXlhUzBt?= =?utf-8?B?M3Q2aG1mZG5kNm9YVy9ncEhFUDZjVkFGaE5mdmphTWVCZzUrUWhkekczUXBk?= =?utf-8?Q?z1rSQdn5XXGIE06+c7TzGC8PFnSaZpIRbWMJMIt?= X-MS-Exchange-CrossTenant-Network-Message-Id: 917ea0b9-574e-466d-330b-08d8dff44a76 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2021 16:32:38.9028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3UkQ+eOi0raOASg/CsrYzL/ZMhswuVo+eaBTw2FNarMO3m8PuQ3OCirbb1IcmuOLo9NVkWCUPPQXEPKJUiftdTbR9NAnOzdLZexO6G2BPz4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4166 X-OriginatorOrg: citrix.com On 05/03/2021 15:37, Jan Beulich wrote: > Since we don't need to encode all of the PTE flags, we have enough bits > in the shadow entry to store the full GFN. Don't use literal numbers - > instead derive the involved values. Or, where derivation would become > too ugly, sanity-check the result (invoking #error to identify failure). > > This then allows dropping from sh_l1e_mmio() again the guarding against > too large GFNs. > > Signed-off-by: Jan Beulich > --- > I wonder if the respective check in sh_audit_l1_table() is actually > useful to retain with these changes. > > --- a/xen/arch/x86/mm/shadow/types.h > +++ b/xen/arch/x86/mm/shadow/types.h > @@ -283,9 +283,17 @@ shadow_put_page_from_l1e(shadow_l1e_t sl > * This is only feasible for PAE and 64bit Xen: 32-bit non-PAE PTEs don'= t > * have reserved bits that we can use for this. And even there it can o= nly > * be used if we can be certain the processor doesn't use all 52 address= bits. > + * > + * For the MMIO encoding (see below) we need the bottom 4 bits for > + * identifying the kind of entry and a full GFN's worth of bits to encod= e > + * the originating frame number. Set all remaining bits to trigger > + * reserved bit faults, if (see above) the hardware permits triggering s= uch. > */ > =20 > -#define SH_L1E_MAGIC 0xffffffff00000001ULL > +#define SH_L1E_MAGIC_NR_META_BITS 4 > +#define SH_L1E_MAGIC_MASK ((~0ULL << (PADDR_BITS - PAGE_SHIFT + \ > + SH_L1E_MAGIC_NR_META_BITS)) | \ > + _PAGE_PRESENT) > =20 > static inline bool sh_have_pte_rsvd_bits(void) > { > @@ -294,7 +302,8 @@ static inline bool sh_have_pte_rsvd_bits > =20 > static inline bool sh_l1e_is_magic(shadow_l1e_t sl1e) > { > - return (sl1e.l1 & SH_L1E_MAGIC) =3D=3D SH_L1E_MAGIC; > + BUILD_BUG_ON(!(PADDR_MASK & SH_L1E_MAGIC_MASK)); > + return (sl1e.l1 & SH_L1E_MAGIC_MASK) =3D=3D SH_L1E_MAGIC_MASK; > } > =20 > /* Guest not present: a single magic value */ > @@ -320,20 +329,26 @@ static inline bool sh_l1e_is_gnp(shadow_ > =20 > /* > * MMIO: an invalid PTE that contains the GFN of the equivalent guest l1= e. > - * We store 28 bits of GFN in bits 4:32 of the entry. > + * We store the GFN in bits 4:43 of the entry. > * The present bit is set, and the U/S and R/W bits are taken from the g= uest. > * Bit 3 is always 0, to differentiate from gnp above. > */ > -#define SH_L1E_MMIO_MAGIC 0xffffffff00000001ULL > -#define SH_L1E_MMIO_MAGIC_MASK 0xffffffff00000009ULL > -#define SH_L1E_MMIO_GFN_MASK 0x00000000fffffff0ULL > +#define SH_L1E_MMIO_MAGIC SH_L1E_MAGIC_MASK > +#define SH_L1E_MMIO_MAGIC_BIT ((_PAGE_PRESENT | _PAGE_RW | _PAGE_USER)= + 1) > +#if SH_L1E_MMIO_MAGIC_BIT & (SH_L1E_MMIO_MAGIC_BIT - 1) > +# error SH_L1E_MMIO_MAGIC_BIT needs to be a power of 2 > +#endif > +#if SH_L1E_MMIO_MAGIC_BIT >> SH_L1E_MAGIC_NR_META_BITS > +# error SH_L1E_MMIO_MAGIC_BIT and SH_L1E_MAGIC_NR_META_BITS are out of s= ync > +#endif > +#define SH_L1E_MMIO_MAGIC_MASK (SH_L1E_MAGIC_MASK | SH_L1E_MMIO_MAGIC_B= IT) > +#define SH_L1E_MMIO_GFN_MASK ~(SH_L1E_MMIO_MAGIC_MASK | _PAGE_RW | _P= AGE_USER) In practice, it is 4:36, because we have to limit shadow guests to 32 bits of gfn for XSA-173 (width of the superpage backpointer IIRC). Also, this property is important for L1TF.=C2=A0 The more guest-controllabl= e bits we permit in here, the greater the chance of being vulnerable to L1TF on massive machines. (I'm a little concerned that I can't spot an L1TF comment which has been made stale by these changes...=C2=A0 Probably the fault of whichever numpty prepared the L1TF patches, because I'm certain we discussed this at the time) Going from 32 to 36 bits moves the upper safety barrier from TOP-4G to TOP-64G but I recall us agreed that that was ok, especially as the main safety guestimate is "no RAM in the top quarter of the address space". However, I don't think we want to accidentally creep beyond bit 36, so I'd suggest that the easy fix here is just adjusting a nibble in the MMIO masks. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 05 16:34:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 16:34:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93900.177372 (Exim 4.92) (envelope-from ) id 1lIDOx-0004gv-0k; Fri, 05 Mar 2021 16:34:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93900.177372; Fri, 05 Mar 2021 16:34:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDOw-0004go-U2; Fri, 05 Mar 2021 16:34:06 +0000 Received: by outflank-mailman (input) for mailman id 93900; Fri, 05 Mar 2021 16:34:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDOv-0004gj-KE for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:34:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDOv-0002Em-CE for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:34:05 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIDOv-0000EB-BF for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:34:05 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIDOs-0000Va-2e; Fri, 05 Mar 2021 16:34:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=BVVbvU6Mxw7mfr6DS/ozDlUqGXS4+6nfrpDLr4KXMEY=; b=HIyToMRUUg9PxJSU3q3AGI6D2r Cj2jTCae+q+ynW5XJiBZujWrW2jVQRiYcw7ux3oXA6EXXKRrfPxlU8+jSQrUOVAzH5UjpdFbO5nez KrBPZswAz++4oE0MkIte1RluKePYG2XFk4RBmHd1CR0REd1CCLf4M2iOYCI/eoNe6Jn4=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24642.23929.875373.263402@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 16:34:01 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Wei Liu , Anthony Perard Subject: Re: [PATCH][4.15?] libxl/ACPI: add missing build dependency In-Reply-To: References: X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH][4.15?] libxl/ACPI: add missing build dependency"): > Just like all other object files - wherever *.o is mentioned, *.opic > also needs mentioning to yield consistent behavior. Otherwise make may > decide to (re)build the object before recursion into $(ACPI_PATH)/ (to > update $(DSDT_FILES-y) and ssdt_*.h) was actually finished. > > Signed-off-by: Jan Beulich Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Fri Mar 05 16:40:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 16:40:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93904.177383 (Exim 4.92) (envelope-from ) id 1lIDUr-0005iF-Mo; Fri, 05 Mar 2021 16:40:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93904.177383; Fri, 05 Mar 2021 16:40:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDUr-0005i8-Jo; Fri, 05 Mar 2021 16:40:13 +0000 Received: by outflank-mailman (input) for mailman id 93904; Fri, 05 Mar 2021 16:40:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDUq-0005i3-L0 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:40:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDUq-0002Kw-I1 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:40:12 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIDUq-0000bf-Gx for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:40:12 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIDUl-0000Wf-Qk; Fri, 05 Mar 2021 16:40:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=+54daDSjbMQyxBm9Jhcjq7BckrOOxNI/SzCB8zdQlj8=; b=Y94JOgGLmwS8L06xrCzIvGn/Zw j4d5aVPeYmQIXZh1vgNE3j0ZYTds51VRt+sw0syo0fo1LJINxaZCYfhRUtVyauFrQ3b3QfAA0k/G5 NwGDkSh1UmxqofNcyFtdpDb8dZs9pXe7UeensbXsbIe8UTX26jAGXwllttME5KYlmu50=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24642.24295.466588.233219@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 16:40:07 +0000 To: Andrew Cooper Cc: Jan Beulich , "xen-devel\@lists.xenproject.org" , Tim Deegan , George Dunlap , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized In-Reply-To: <2e09dfd0-5da4-bdcc-900b-d40a112d832b@citrix.com> References: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> <2e09dfd0-5da4-bdcc-900b-d40a112d832b@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized"): > This wants backporting to stable releases, so I would recommend for 4.15 > even at this point. Can someone explain to me the implications of not taking these patch, and the risks of taking them ? AFIACT the implications of not taking 1/ are that we would misbehave in a security relevant way, sometimes, when we are running under another hypervisor ? And the implications of not taking 2/ is a performance problem ? As to the risks, 1/ looks obviously correct even to me. 2/ seems complex. What would go wrong if there were a misplaced ) or confused bit-twiddling or something ? Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 05 16:47:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 16:47:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93907.177396 (Exim 4.92) (envelope-from ) id 1lIDbi-0005uv-Fo; Fri, 05 Mar 2021 16:47:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93907.177396; Fri, 05 Mar 2021 16:47:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDbi-0005uo-CQ; Fri, 05 Mar 2021 16:47:18 +0000 Received: by outflank-mailman (input) for mailman id 93907; Fri, 05 Mar 2021 16:47:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDbg-0005uj-NQ for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:47:16 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 261ca835-97e0-4573-b077-83ee50fbc291; Fri, 05 Mar 2021 16:47:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 261ca835-97e0-4573-b077-83ee50fbc291 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614962835; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=j8sTpc/5AIaapHa7TN4lGNhh1vWXCBF+qWQWQRTTlcM=; b=Ar+vOigKcze90plnwTkaxqwkqWwVn9WKWpSDCusO+GAUjWNq+PrX9zsL Muv4VVBqIvlfXiRA+OstUwgBIPZde8QQSOa5he4FD8DS/MB31YZgFO3xB MBWqng1JJtVemNBxAFWJRBGr7l5vRSRq46Um4wevU/k/iArsbwCWgoz8G s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: VDqlEBfzRcO5ta8GCEO/cjTgjNjkcgdtEzjVlvsYfgK1i0uW0xs4mvpNY3AVgZ83I+/RTjy8+1 G2B3N8L3SjNc/Wz8mFpj8r2FOFWoylKWz4OsulMfhIPRAc60rbgQv2/bpifDu77za2z5YbUuP5 cSXOHYEOxPTAylbl5C4/VwqKdcWoXW7vrYY46HaRsWvX9NK3JRSGMXvIyQE6fl2l9GFMvPD5jQ eXHUoGlOsoZjxe0ScQ1Ft9AGbh5d7cRF+D6PU/+eJHh9yi+//LQC7RxGxwv8jE+SV+3DjyA4wV Ud8= X-SBRS: 5.2 X-MesageID: 39018158 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,225,1610427600"; d="scan'208";a="39018158" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=be+sUobR5F4g568HT7FcPuCnBco8umhAXzS5mHPc6cw9i7A5ijz9i6WngmBtMHFi7p0TvlmTpipYv4axbAvxXW4UEBNYC8GALyxq/U7ZNjodI3ZUjupwY3CmEYcsmlSFz08z1B229aZVw2dfPtLq7zj4GgX5Z8OeHA0cPUEb/9K6XBjUkDnxe+tOK14Y57uhWPiIdD/uvU+Q4jhe8q4H9wPFt1Md703ink6yq83rnmP3V0V5XX3zOAX3mPMarhmjV8rk7mcEKOrdqz2+gKLswsPnsyEDTtEjn/qyx+uoyVyj/jo1esZAFpU7Z7XNWsqBSuduFLflKIxuOSBymmPavw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KtuSCxMsLt2tLA7f7eJArRAh9WaD27gFXiZjNLKjPH4=; b=oFCTAVH23bD+qrhij+ctcYQUymPHLAZIMiFsOAML8OFK2JG5PA4dFPaNU/x4fgykLTJSuCiUhNFBNF0JuAvBXFEfX3ScGxq0EDNW1lHe/7LdLUSZBRDHRHUFd6nJY73qnYP8UwQrub7DIzzAI/TO+UQe7EGR/+EWf5hRSlrqbyICfiauWTueDtbeqNNC4uvXPubyKB1f2T6LSf1QSZgGd9JflM3/xb4UysuPPulsatL+kQwIg5bsNVyBFN9O9BTdCJzZcnpDQv+8uy1DmsozvLBjSLicT2MtmnR3IOlDKQyFoXDlemu2ZVfUE9s2nb4H3W7doVaiRPpGwBxB6N1asQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KtuSCxMsLt2tLA7f7eJArRAh9WaD27gFXiZjNLKjPH4=; b=QUcF6RUaajxAepu19Y7A/J7zzoQrdET4iVfdl/mTfz5MEv9N+aJHChuBr1jh6U0d5/1++xsg+mQtjd+cdd6W35ZG3XSLxiPOpmkiaFrGahpNGMP2pA5+cef9SKNFCVHsu8WMDyCKujx4u8C3RDuB8sVpj03ofJ2aqwR+LM3Ieas= To: Ian Jackson CC: Jan Beulich , "xen-devel@lists.xenproject.org" , Tim Deegan , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> <2e09dfd0-5da4-bdcc-900b-d40a112d832b@citrix.com> <24642.24295.466588.233219@mariner.uk.xensource.com> From: Andrew Cooper Subject: Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized Message-ID: <2983621d-c7bb-3cad-14bd-a26481be0109@citrix.com> Date: Fri, 5 Mar 2021 16:47:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <24642.24295.466588.233219@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0057.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52a15b9a-2a21-416d-f396-08d8dff65392 X-MS-TrafficTypeDiagnostic: BY5PR03MB5078: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: earu7nZuraB6icTkFMOX6ZB5QhvRAQVZEwDfv6Gg/ILe/ktWFJP/3soCYgcNGSI5BVP0mWVOoKu8LEm//ru5hAVih9rqpC3su1sSuG4n57LDXrgCJW7rXSEINIbHKvUfKZ8j+KErOS3gEl39qj3SxBRC0J8O6nDWRMQli5ZZ2MCJDJVfxm5n0bc8Tfn9Ynwz8pO8Cn8ZWwtawiPafhKNdB7kotUdvmSbzD21tdpguDI6RXoLhBwnYfbe18TsTMchWAlO/ia9BE6sCixiDu/SlxOEr+pLrSeKNkUOwkX3a9QKIMQajdBQVXFwIZusqd2YFsgCu9ut4FWcH/AyFqQdVDps/BvWTX/6lfmB/4fJTvbkagDZEEP2E6ttxxh2x8Rf0jjnn6BjPsSbojYDtGJNujzDzTOev4T76ag+BrvMSJJTr/xHPq4LQs+NSpJaWskQV56ktFLRxBlaNbTqHyG/EO0RDDhJpyOGJcgC1YVeyXtmcrEUJEDIrEz9NGBrejkneajlXn7S7nPXrYNLHiXQtXpYKnqVF/FBLrkrhcHElodrzz3zvMruC1FcPREOlG5oSOk9YryTG7zWv2+cW9TIPBPXcN6asCW6T4uXVJql6qM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(346002)(366004)(396003)(376002)(4326008)(66946007)(6486002)(53546011)(316002)(66476007)(66556008)(6666004)(16576012)(186003)(54906003)(16526019)(107886003)(2906002)(26005)(83380400001)(31686004)(6916009)(2616005)(956004)(8676002)(5660300002)(8936002)(86362001)(31696002)(478600001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UmFoNDMwU3UyRW90Vm1sYXB4cnBldzdjZHpBT1dGZzNFUmU5bWNvL1VqNDlm?= =?utf-8?B?V1UyTlh2QXd4OTh1QzR5NHhPU3U5S0UwSjk4YllscTBxUDBjRUl4Zk5meUMv?= =?utf-8?B?Z25vNTFRcG5aNWRobktYYUpLMWxZTlZaZDhtQWg1TU9ZWWY1NHlxNWQ0UWty?= =?utf-8?B?WWRwKzJyUnBUdzhHMDBLZnl6eWJSZUZmZkQyNVdrNmxTMW1TNFdyV2R3ejE1?= =?utf-8?B?bHk0c0VwMW9IL0gzWVIrUXNFMzlpZjhDRGk5aEFFM1IwVEluM3VaZ0V0bDFz?= =?utf-8?B?a2tiRFJMM3kySGtHYlN0ZTVGbUM3bVVueDR0WnUxSHU0dURMMnl6dkxOdC9H?= =?utf-8?B?WERRY0RMZEdaTHNTNGlCaGxPNFZFZDJER1EzMWM1amJMWmI1bVpTWk9WTCs3?= =?utf-8?B?SnJwdUJjY052cmFxamFQRnllYlpPQ1JYVUIydXlUS0h6UWU2Y2NvSXNDc3d1?= =?utf-8?B?OUVId3MwQXQvUEhaaFZ3UjNndzA1VlAwdWhJcDhGWUU2ZXhxWHYyVml5TEQ0?= =?utf-8?B?QkhXQlMvY1ZjOE85UHVBSHpBSFFySVYvNGVCTjJHcVZnWUxHR1VtN0E1bkJr?= =?utf-8?B?N2N0VytWWG5weUQyZ1NRdkJjWTNYVGFtRVdOYkJJUFZZRVBsRmYvQVRCYStP?= =?utf-8?B?Q1NPajFvQTc3ZG5YTkRsL1BRMjJ0UUZrMmYxMTBNQ3lycmMzV0NVeU1SbC9N?= =?utf-8?B?Q1FuUGx6YUdVNjdPS0FTUEd1cUxDa2xOUDFCMXBvSUhzdjIrYzZuTVBLNFQ2?= =?utf-8?B?U0s4VytMNHQ1MzFuM1FFcGErRVR6ZkN1bE5sa3R6UG5hZWYwdGc3U2V5K0dV?= =?utf-8?B?QkIyMEFBV1lkTnJxWmFoVWY4STlpdTZkcE1yRHZnTkVoTHY4NjBwVWhsUUdl?= =?utf-8?B?TDZkRlROVVRKaDgvS3h2eVMvY3hHTjJ5OXlzZHMvNnUySTNKcS9NUVkydUg4?= =?utf-8?B?UnBpUUU5WWxXdG52enE5L202S1djSCtITVRGdmdTSmhlUUhDNldhbTBrWm5Q?= =?utf-8?B?b1N0blhWOG95dlpFQjdDbU8rWHhqOXZTdXA5enlNYVFIRUVEa1lSQ1VRc3hT?= =?utf-8?B?bURGNHZJZ3czeUhCd2RvTHZ6eEpMWGN3UHRLK2lmUHNXcFJQdXNlNEp5SUNR?= =?utf-8?B?alkybThUNlZhaHdmdDRCN2UybitjbVlxcHJlZVYxWEtCenAyYy9JRmtDcXFi?= =?utf-8?B?aVQ5Yy9QTXhDU3R2RlgwR3NGV2x0bmFZWVN4VGkvcG9TOWdYLzN3cmFHTTJY?= =?utf-8?B?SFprbktxcEMxUHkweVRLYnkwYWkzNFdFOVZZSzhSOEI3SVBkeGJjTXdGaVNQ?= =?utf-8?B?M1NWVkxITkk4L3lKZ25BY2xESE1oSTdLRXA5QTNGUHUwbU1EY28raEMyOEFM?= =?utf-8?B?ZDFhTHZpNnp4akJkeEdKM2JCSXRXdTY0Q243TVFzeDFkdzBZYkNLbnBKalNY?= =?utf-8?B?NmpSd3BuV1FIN2VuYkZJdndwRkxuY0JRaUlmSXY4dEYvL2ROdUhxdzBHSHoy?= =?utf-8?B?N0d2LzIzd2lBQWlPekhLSFVaL3Mvc1YwaFJiQXB0SW40T09VUEhKTVRpeHI5?= =?utf-8?B?ZUQyL09oSEFUdG1JY1ZPdUF1K0VKM1RTMTJlaHRzY2RiZ2dkM3RMalhseG54?= =?utf-8?B?NU9KbE5seTdmN00xNE8vWXRiL3dITjdmMTNIMjNSZUxUNU44ejk2NGhsd3V3?= =?utf-8?B?MkVxS2VONGFDUkd5c1JTT2oxYUp1YmF0MzVHZDdCWWZiRERkZDFML0pPYXNU?= =?utf-8?Q?fOWNTlOGaPNO3xwYMWuMep8sfNgmMsO6WqQWYEx?= X-MS-Exchange-CrossTenant-Network-Message-Id: 52a15b9a-2a21-416d-f396-08d8dff65392 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2021 16:47:13.1363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6U7Ek25cLKJYNhhv+Jyv6ocmrn9T7RXrCMdQw6VAIrGcGuDCOCntqlfIy7J2gL/O+gyZaNTLeo4jFwZ/NoKJ1AP3KeRFylKsSjGrq9MKscM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5078 X-OriginatorOrg: citrix.com On 05/03/2021 16:40, Ian Jackson wrote: > Andrew Cooper writes ("Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast = fault path" optimization when running virtualized"): >> This wants backporting to stable releases, so I would recommend for 4.15 >> even at this point. > Can someone explain to me the implications of not taking these patch, > and the risks of taking them ? > > AFIACT the implications of not taking 1/ are that we would misbehave > in a security relevant way, sometimes, when we are running under > another hypervisor ? Correct.=C2=A0 Specifically if you've got a migration pool containing an IceLake server and something older. > And the implications of not taking 2/ is a performance problem ? Correct (I believe). > As to the risks, 1/ looks obviously correct even to me. I agree, although Tim has the deciding maintainer vote. > 2/ seems complex. What would go wrong if there were a misplaced ) or > confused bit-twiddling or something ? The bit twiddling can be independency checked by disassembling the binary. However, I have some concerns with the patch as-is, in relation to L1TF / XSA-273. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 05 16:51:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 16:51:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93912.177408 (Exim 4.92) (envelope-from ) id 1lIDfY-0006vQ-5X; Fri, 05 Mar 2021 16:51:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93912.177408; Fri, 05 Mar 2021 16:51:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDfY-0006vJ-20; Fri, 05 Mar 2021 16:51:16 +0000 Received: by outflank-mailman (input) for mailman id 93912; Fri, 05 Mar 2021 16:51:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDfW-0006vE-Rt for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:51:14 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 65ee316a-edd1-44af-8dc9-fea33ad1b892; Fri, 05 Mar 2021 16:51:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65ee316a-edd1-44af-8dc9-fea33ad1b892 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614963073; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=V38rJ8g+yoVrKnITUdeIW7NrWR3JYYscW2CC4cywW4o=; b=f9utsC7bgYNz3kCrq0mXKmmR4RC/1ASgp/ZC7gTuQAY6J84WnBu/7rFJ 09UBigJ4dNEyjwUM9WA8TzK6soKVnKACMF70c9g3LcZiXaEc2P/E1NR1E SnWNWCpfnA8BjX5C3K2wOe1lLQQiysZjmrnxpLETsyzR3fGUNBnEbjGE8 o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: DFBKb6zR1OQN+g9jLAE6AzMvo+38z6/ZH+InuM/yGOmM+uZ/iMBTIXvq/klg5Z91yjrkO1AAOi 3WV9yIpzxAtgUff2XcQ56wYaAgxahSPDif57bA6ZV6rYCxjXwkoBoTG6qsplzGpaWbeoGe5NdQ Tg1qVZqbmJUwfbLLpevi4ui+E7IQW+pVurQs2bGKBAzBxMFs7U5e3Y7vCy8Xc5z0Ti4EhTBWSu bVhivOFpobI8vo4Tc88MxLHTDgKrDY+w2sqSKQtvK1IvdVZnSJTubPveEJULrNO7/MtmEvhDtA 6WY= X-SBRS: 5.2 X-MesageID: 38664311 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,225,1610427600"; d="scan'208";a="38664311" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VWV07Wwx3L0LKqLxyTp14pCmw8goRMK3lQ+kurmkuBYsAd7lz1ncrEs8KDoF3ZAm8R01Ebm+qdlB/CymdC8rO2IVYTwLiT9SOMWlvIrOXEA8wz2cbIJrjWo9HcXTxc6x5avHWjwo9IP5m5NKuX9piZ8eG1o8664yQGBFnZxZY+SI+nwHDLaI8dqtxxg7qHbJJ7Egx5j08klE517QnNiFvYBFjuIgwnAFVLB3Adz1BWBZ44624F+g/dnOSLmvDJEcF0dB2hXQAb2TWq1FkCcDBjQbT2IoKZLuNUAP7RhVBN2Lvlawr9F5pZUJoxRK46m/bR39hZqN/f41T539VIIvAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V38rJ8g+yoVrKnITUdeIW7NrWR3JYYscW2CC4cywW4o=; b=LWX8gaIDBF8tuiNPpXNnTloD2AJfo5IDu57gBOGxJ/Q9GFV2DwGyyspfX358KU7t495meOmtLLq7til+VoZG90w1QeaxHc3clCQUls8yj4vVYG4w94GouNXQHesaWilrZ7gz/iAdmD/uKcBRzyKoz7CC2LOjNfTgBRUjPVZ65tBSjNbJEoWltkpvEvYgkqf2Lv4ppNHu5hWRQDpB6YCGlJqelpyBj9ua9I03eyylz1jztmY/04rPt+w9TkO4VkTzPdTnjhbx3Ds1yYD5RNYc/gBQZsLvV0PD1F9nmVGtAwVDXd4PWAniE9DTKa0WgRKcOfK9E/ruOzphMRNe4fih9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V38rJ8g+yoVrKnITUdeIW7NrWR3JYYscW2CC4cywW4o=; b=kE7LFGLIIrQwSg5QHvCg44lie2+Nru4LJ4tHQw/h81pZJ0fU+nEYvVm+U4o/Diqco4hPWDVRxjDT5KdGCcdeREyyVeO1OEGyu0I4+Vc7u+/UJp2+7UFkHEtVWXoQNuKlo1+jcnoou45udIqGRQI5vg0RHzRv9XTxODf4E6ov5+Q= To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Ian Jackson , Wei Liu , Anthony Perard References: From: Andrew Cooper Subject: Re: [PATCH][4.15?] libxl/ACPI: add missing build dependency Message-ID: <4776cb15-8f8a-e185-fdb7-196da4b70cc9@citrix.com> Date: Fri, 5 Mar 2021 16:50:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LNXP265CA0054.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2a047ee6-4f82-4fae-c08d-08d8dff6d8a0 X-MS-TrafficTypeDiagnostic: BYAPR03MB3942: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1186; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gK907xxYAmVjRbHPsZwWDuliVi7dsrmeJreXwrkUU+zdBueeFHrWmDRtoclv6LLRf2bg1qny7ayuUmpX9ITtEAqmcB10Ghg2eskXXG8E2Dln9m8tBKR2TiYDclkURkQgBdRn7270Gm8d7/403PjmrcAsHaQGniJZd9Hub3Awqp9BjMnJigy2XJiMaMHzgfZYWqK4RcZFQUtlcizVAhB1xw0wx1p2T2GmXLRhNc+Dmhcy9uC5hCgji/2LAkj+nuO7IcWFRo7MyjSEcKDPHTds5TKzVQ1x5Ni+s+367amesGn7C1uxP860GzvYfZHkwiStzxv/5sxLF4Ol//wjtZIjzLlrpelfoGr5vLpL+hJX0IlnXfI4YFZKM8nERS4SRy3hZKATUp0umaqCwo/ifTRjoitV3JTOPybiUgZ8+J8hFDRvt1h/2C+hz6eeWB8Ov3YcmhUXL9vrsVEF7jOioEZ5J+NDZiH5jbDlTlXsQkNwW7TIIVlDgFeo7t/mBVv9+blDt5SyJSlWMeAkFbMBzlbvgqmUakVHqZzQwzPaUkthVzo7Sm1XWxMeFZfilxpgU1uAKMII7uy1DaWRajvGUuhmV1SdEGRWbZxVLgRXLEVUUnmOiy3y1hXHXATNAymrYGmT/bqb5YEU0siqoSt05ifM4Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(396003)(366004)(136003)(346002)(2906002)(6486002)(316002)(86362001)(31686004)(54906003)(66476007)(16576012)(26005)(83380400001)(956004)(36756003)(4326008)(5660300002)(31696002)(2616005)(66556008)(110136005)(6666004)(66946007)(107886003)(186003)(4744005)(16526019)(478600001)(53546011)(8936002)(8676002)(11771555001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UHdML0RZQ1lsOU9QMndaZ1p1VG9BUlZMNDBkRkFyRjkxL2tNMzFYQnJMQk1p?= =?utf-8?B?SXFrdUJnVFZ0V3R6bUlNOWlDOHY5anBDdFQ3eEU3K2hkekozeXE2azY2dW1a?= =?utf-8?B?eWZQdTByVFRHclZ6Zy8rQUY4dWlQQVRmeGJQMnNxcDVoSExCdjVROVRSY0FO?= =?utf-8?B?UVNXakZDK3gvZEdGK1F6OVJ3YVdoWDhubHFHWmlIVFdodngxQWVFUGxzWk9G?= =?utf-8?B?N1lKa0JLOEtSck1CU25WUEtiTE1kRlN2bkNwbk5SbVE0QmNCQlNwN1g2U2wr?= =?utf-8?B?WEhxaVJDWi9Vam5nR01wWjF2bjVibkppcUY5WU55ZVgxNHByY0MzeFI5U2d1?= =?utf-8?B?cW80Q21Ec3BCUnJNU0FHVEorZUZwcGhlM0REQnQrbVBld0p0YjI4cWRjUUdp?= =?utf-8?B?TmxvSTRnSkxscTlJamVyMitvZk5EY1p1VnZwMFE3V2dLTXFQS0FUbWRVVkt2?= =?utf-8?B?REU2cTk5ZDA4czA1NUxGV2RpZE81ZTJWYkhKc2lEWlFpMlQ1Ny9FTkZtN1Ux?= =?utf-8?B?WUZNWXVjbUIyb2pLVlVxQUdKOEtDR0hlZ0hseUxlTmNaSjdHbGNIU1Mzd0Er?= =?utf-8?B?N0FMbUFaalNCaDNxejlUc2s5UmJreW1xOEVEYnEzeitkRXZ3Zi9Ick5nOC84?= =?utf-8?B?VnUzM3Y4NkhNL2xYVkRRMDhKeDhaaFVnL3ZFVUpYWEU0amxTUVI0YWNEYTQz?= =?utf-8?B?aHFrMDlJNWszVGlwZ0dFK2R2NjZ3QXAwajZJSm9NQTF6TWZpL3NrT2k4Qmd4?= =?utf-8?B?VFNsUTg2QjI3UE8yblBhVzhSZ3dVRVAwV29nV1h6UkxwdW81cFJQOE5sYU5O?= =?utf-8?B?KzUxTXkwcVBNSWtWb2tYQWw3b0xqNnFKaFV6VzZDTEFXS3h1UW1haWxJYmhW?= =?utf-8?B?RUIvbVFoTThQcENxYUloM1libjdielJFeDVOTU1yeVRoaUEvOUlpZWVXYk1q?= =?utf-8?B?emVrRU9OYlBsMm9vVGdHd2xkSW9PVkFyQ0w2T210Z1c3WkZoTGhudk51M2Vi?= =?utf-8?B?QjRNU0JsRW1rZnJVQUNhSTBJNVlJZU5HMERqSVNaTnRCMUM0UkNHbjU1M1FQ?= =?utf-8?B?YWwvaHlOVTBpTXczMW9uWWJyZHh4dUpodzVWaFpUdTFUZ00rR0hYbDlsNUp3?= =?utf-8?B?U3NCTTN4T3RXWlE5QWhNTmFnWlNVaithOU1ISFRwaE5MWEhmaDV4KzFVQnJZ?= =?utf-8?B?OWRtcDdsdFg1d0M3bXBnSlpoZk11Zncvb0NoMGZUQm4rMnI5bDgrdHN5cjF3?= =?utf-8?B?OEFyeTVEWk0vZW1kdE9QTmU0THFaTm5xZmFHY08wVWhYQWpJa25YQ3g2ZnlY?= =?utf-8?B?WklpQ3B4TnRmQkg4NWN0NTh6VDQ2TG4rcVJwRDJUY2RQZDRJTFNSMUF5dVcz?= =?utf-8?B?RG9mVW0yNlVGTU9Kem9UcXFEbjd3Uk1nSE1oZ3BPTys3elNuWGRDYmVUSnZO?= =?utf-8?B?L1YwRWNpNFBNZjdINEZ3ZTN0Rjhmbk1hTmN1bVBSVFZDeTRQYU1JcVoyNkFU?= =?utf-8?B?YjFTTjMxZVZaVnd1SkRRZWF4Z2lNaTJrcTZkbGorczQwQVdDUmg5UWdpN1Iw?= =?utf-8?B?S1dBTnh6L0NUZGl1VlhYemlRajlpbkJpelUvdXJFT0tmTE94WDZmWldLMnds?= =?utf-8?B?emo4SXpma0JLTlVOMUlRL3pqSmdIMjFsTEplc3hDWXluZ24xQ3ZrS0pOZHFZ?= =?utf-8?B?ejJKREZaYU05ZjFQb1NkYXF1SHpXTUtFS2hlQ2tROG9uQ0NtZ2RNeWZab0hF?= =?utf-8?Q?fYisgy9fuI0G8Xm+/ONiJwmvNb1ofpefT0KQGG6?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2a047ee6-4f82-4fae-c08d-08d8dff6d8a0 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2021 16:50:56.3966 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hJgPgJNdxhmMIJAk0YAPlsiXzSfmtTPK4N9qubytylY2Y3m+Z/OLyeIM6R9MtEvRBEpHkoXpVvkZpJT6Tw6elGqyy5RmHlm4XpvhXhhd97g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3942 X-OriginatorOrg: citrix.com On 05/03/2021 16:28, Jan Beulich wrote: > Just like all other object files - wherever *.o is mentioned, *.opic > also needs mentioning to yield consistent behavior. Otherwise make may > decide to (re)build the object before recursion into $(ACPI_PATH)/ (to > update $(DSDT_FILES-y) and ssdt_*.h) was actually finished. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Fri Mar 05 16:58:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 16:58:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93915.177420 (Exim 4.92) (envelope-from ) id 1lIDmS-00077Y-TN; Fri, 05 Mar 2021 16:58:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93915.177420; Fri, 05 Mar 2021 16:58:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDmS-00077R-Pu; Fri, 05 Mar 2021 16:58:24 +0000 Received: by outflank-mailman (input) for mailman id 93915; Fri, 05 Mar 2021 16:58:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDmR-00077M-EI for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:58:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDmR-0002dy-BM for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:58:23 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIDmR-0005WA-AN for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 16:58:23 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIDmM-0000Zd-J6; Fri, 05 Mar 2021 16:58:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=HTq3VOKpN2RVbgaeFuerPy6PXQRO3SOBWnBKI9W1qPY=; b=HPOcqC0PWvVYHr3iJe/f22xwft qmDaa+ndtJGq6cvOQTuuqZNtCMvfXsBuhCiUF6sNgG3TPDJakiIM6mTfuvN0QGs+0p4rFxJ/780Hn 3Q0WgdE0cdWGTTyBM8MTwrg9W+JBEsWQBctHFtB4aWRvLg2dMa0W016EWF/Ob+ji90Xg=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24642.25386.315054.76149@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 16:58:18 +0000 To: Andrew Cooper Cc: Jan Beulich , "xen-devel\@lists.xenproject.org" , Tim Deegan , George Dunlap , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized In-Reply-To: <2983621d-c7bb-3cad-14bd-a26481be0109@citrix.com> References: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> <2e09dfd0-5da4-bdcc-900b-d40a112d832b@citrix.com> <24642.24295.466588.233219@mariner.uk.xensource.com> <2983621d-c7bb-3cad-14bd-a26481be0109@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized"): > On 05/03/2021 16:40, Ian Jackson wrote: > > Andrew Cooper writes ("Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized"): > >> This wants backporting to stable releases, so I would recommend for 4.15 > >> even at this point. > > Can someone explain to me the implications of not taking these patch, > > and the risks of taking them ? > > > > AFIACT the implications of not taking 1/ are that we would misbehave > > in a security relevant way, sometimes, when we are running under > > another hypervisor ? > > Correct. Specifically if you've got a migration pool containing an > IceLake server and something older. > > > As to the risks, 1/ looks obviously correct even to me. > > I agree, although Tim has the deciding maintainer vote. Right, well, for patch 1 then Release-Acked-by: Ian Jackson > > And the implications of not taking 2/ is a performance problem ? > > Correct (I believe). > > > 2/ seems complex. What would go wrong if there were a misplaced ) or > > confused bit-twiddling or something ? > > The bit twiddling can be independency checked by disassembling the binary. > > However, I have some concerns with the patch as-is, in relation to L1TF > / XSA-273. I'm going to hold off on this for now. I think to give it a release-ack I would want someone to argue the case. Concerns would include Andy's comments (which I saw earlier but do not fully understand) and me wanting to to know (i) how bad is the perf impact without it (ii) how has this bit-twiddling been checked. I hope that makes sense. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 05 17:08:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 17:08:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93920.177467 (Exim 4.92) (envelope-from ) id 1lIDvw-0008G0-KG; Fri, 05 Mar 2021 17:08:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93920.177467; Fri, 05 Mar 2021 17:08:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDvw-0008Fr-GD; Fri, 05 Mar 2021 17:08:12 +0000 Received: by outflank-mailman (input) for mailman id 93920; Fri, 05 Mar 2021 17:08:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDvv-0008Bc-Eh for xen-devel@lists.xen.org; Fri, 05 Mar 2021 17:08:11 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0a23bac4-c977-4ec3-b76a-846840fe1beb; Fri, 05 Mar 2021 17:07:55 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDvZ-0002pj-SS; Fri, 05 Mar 2021 17:07:49 +0000 Received: from iwj by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIDvZ-0006Cd-QZ; Fri, 05 Mar 2021 17:07:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a23bac4-c977-4ec3-b76a-846840fe1beb DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=CL5PKWaZCv3kmSVfNkNFDGXqsmxIRvBTHwUcV6+gMtE=; b=HgZjDX/XM1XUUawK5lHjJsmDSz v4206n3lSNN0bumuAijuvL0OTaJSPMWrHu5aPBpz0lak7irCUqNBN0hIwpGTlwQqRvnwJSBuvRnM6 YQ7J09RJlEJBTqE0D9c6ZAKU+UHCjmNyoI8ZCASL69VFe2n0hBUZ/nbG9V0rm7IWoZss=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 367 v2 (CVE-2021-28038) - Linux: netback fails to honor grant mapping errors Message-Id: Date: Fri, 05 Mar 2021 17:07:49 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2021-28038 / XSA-367 version 2 Linux: netback fails to honor grant mapping errors UPDATES IN VERSION 2 ==================== CVE assigned. ISSUE DESCRIPTION ================= XSA-362 tried to address issues here, but in the case of the netback driver the changes were insufficient: It left the relevant function invocation with, effectively, no error handling at all. As a result, memory allocation failures there could still lead to frontend-induced crashes of the backend. IMPACT ====== A malicious or buggy networking frontend driver may be able to crash the corresponding backend driver, potentially affecting the entire domain running the backend driver. In a typical (non-disaggregated) system that is a host-wide denial of service (DoS). VULNERABLE SYSTEMS ================== Linux versions from at least 2.6.39 onwards are vulnerable, when run in PV mode. Earlier versions differ significantly in behavior and may therefore instead surface other issues under the same conditions. Linux run in HVM / PVH modes is not vulnerable. MITIGATION ========== For Linux, running the backends in HVM or PVH domains will avoid the vulnerability. For example, by running the dom0 in PVH mode. In all other cases there is no known mitigation. RESOLUTION ========== Applying the attached patch resolves this issue. xsa367-linux.patch Linux 5.12-rc $ sha256sum xsa367* b0244bfddee91cd7986172893e70664b74e698c5d44f25865870f179f80f9a92 xsa367-linux.patch $ CREDITS ======= This issue was reported by Intel's kernel test robot and recognized as a security issue by Jan Beulich of SUSE. NOTE REGARDING LACK OF EMBARGO ============================== This issue was reported publicly, before the XSA could be issued. -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmBCZVEMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZfqAH/i7ypTUP90UIxeyMB9XmNRiqD+LaTSBExt8xTowd zbsWrxFYnZRPSLqs/dVHlDQfF65eD40Agh/Hxp5f0hGHjv8x1kepvpo2di1ovA2h C8/WpOK2nFq77/GTG2mAsJA3ltDF0WJsr5oqaBNVf/lwQSmiescTWtI6+LDFmmpd q1EyKPUClKZW3PoZkCVmiWDtqhVJc3LaJJcy4x/Zd4EgV+uGi2wsYsiQzObrwPss 2D5laUr8RJcSTE7+bXlMA8KnzrOZ6UqK1YIPSGIYBOJnhizGf9CBZCxcNTONWQFC zh1d9GAv93fugE37xRHE7PRjgl/RVO5rn0k5EQw5GTa676A= =GKdV -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa367-linux.patch" Content-Disposition: attachment; filename="xsa367-linux.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBYZW4vZ250dGFiOiBoYW5kbGUgcDJtIHVwZGF0ZSBlcnJvcnMgb24gYSBw ZXItc2xvdCBiYXNpcwoKQmFpbGluZyBpbW1lZGlhdGVseSBmcm9tIHNldF9m b3JlaWduX3AybV9tYXBwaW5nKCkgdXBvbiBhIHAybSB1cGRhdGluZwplcnJv ciBsZWF2ZXMgdGhlIGZ1bGwgYmF0Y2ggaW4gYW4gYW1iaWd1b3VzIHN0YXRl IGFzIGZhciBhcyB0aGUgY2FsbGVyCmlzIGNvbmNlcm5lZC4gSW5zdGVhZCBm bGFncyByZXNwZWN0aXZlIHNsb3RzIGFzIGJhZCwgdW5tYXBwaW5nIHdoYXQK d2FzIG1hcHBlZCB0aGVyZSByaWdodCBhd2F5LgoKSFlQRVJWSVNPUl9ncmFu dF90YWJsZV9vcCgpJ3MgcmV0dXJuIHZhbHVlIGFuZCB0aGUgaW5kaXZpZHVh bCB1bm1hcApzbG90cycgc3RhdHVzIGZpZWxkcyBnZXQgdXNlZCBvbmx5IGZv ciBhIG9uZS10aW1lIC0gdGhlcmUncyBub3QgbXVjaCB3ZQpjYW4gZG8gaW4g Y2FzZSBvZiBhIGZhaWx1cmUuCgpOb3RlIHRoYXQgdGhlcmUncyBubyBHTlRT VF9lbm9tZW0gb3IgYWxpa2UsIHNvIEdOVFNUX2dlbmVyYWxfZXJyb3IgZ2V0 cwp1c2VkLgoKVGhlIG1hcCBvcHMnIGhhbmRsZSBmaWVsZHMgZ2V0IG92ZXJ3 cml0dGVuIGp1c3QgdG8gYmUgb24gdGhlIHNhZmUgc2lkZS4KClRoaXMgaXMg WFNBLTM2Ny4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj aEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFdlaSBMaXUgPHdlaS5saXVAa2Vy bmVsLm9yZz4KLS0tCnYyOiBMb2cgbWVzc2FnZS4gSW52YWxpZGF0ZSBtYXAg b3BzJyBoYW5kbGVzLgoKLS0tIGEvYXJjaC9hcm0veGVuL3AybS5jCisrKyBi L2FyY2gvYXJtL3hlbi9wMm0uYwpAQCAtOTMsMTIgKzkzLDM5IEBAIGludCBz ZXRfZm9yZWlnbl9wMm1fbWFwcGluZyhzdHJ1Y3QgZ250dGEKIAlpbnQgaTsK IAogCWZvciAoaSA9IDA7IGkgPCBjb3VudDsgaSsrKSB7CisJCXN0cnVjdCBn bnR0YWJfdW5tYXBfZ3JhbnRfcmVmIHVubWFwOworCQlpbnQgcmM7CisKIAkJ aWYgKG1hcF9vcHNbaV0uc3RhdHVzKQogCQkJY29udGludWU7Ci0JCWlmICh1 bmxpa2VseSghc2V0X3BoeXNfdG9fbWFjaGluZShtYXBfb3BzW2ldLmhvc3Rf YWRkciA+PiBYRU5fUEFHRV9TSElGVCwKLQkJCQkgICAgbWFwX29wc1tpXS5k ZXZfYnVzX2FkZHIgPj4gWEVOX1BBR0VfU0hJRlQpKSkgewotCQkJcmV0dXJu IC1FTk9NRU07Ci0JCX0KKwkJaWYgKGxpa2VseShzZXRfcGh5c190b19tYWNo aW5lKG1hcF9vcHNbaV0uaG9zdF9hZGRyID4+IFhFTl9QQUdFX1NISUZULAor CQkJCSAgICBtYXBfb3BzW2ldLmRldl9idXNfYWRkciA+PiBYRU5fUEFHRV9T SElGVCkpKQorCQkJY29udGludWU7CisKKwkJLyoKKwkJICogU2lnbmFsIGFu IGVycm9yIGZvciB0aGlzIHNsb3QuIFRoaXMgaW4gdHVybiByZXF1aXJlcwor CQkgKiBpbW1lZGlhdGUgdW5tYXBwaW5nLgorCQkgKi8KKwkJbWFwX29wc1tp XS5zdGF0dXMgPSBHTlRTVF9nZW5lcmFsX2Vycm9yOworCQl1bm1hcC5ob3N0 X2FkZHIgPSBtYXBfb3BzW2ldLmhvc3RfYWRkciwKKwkJdW5tYXAuaGFuZGxl ID0gbWFwX29wc1tpXS5oYW5kbGU7CisJCW1hcF9vcHNbaV0uaGFuZGxlID0g fjA7CisJCWlmIChtYXBfb3BzW2ldLmZsYWdzICYgR05UTUFQX2RldmljZV9t YXApCisJCQl1bm1hcC5kZXZfYnVzX2FkZHIgPSBtYXBfb3BzW2ldLmRldl9i dXNfYWRkcjsKKwkJZWxzZQorCQkJdW5tYXAuZGV2X2J1c19hZGRyID0gMDsK KworCQkvKgorCQkgKiBQcmUtcG9wdWxhdGUgdGhlIHN0YXR1cyBmaWVsZCwg dG8gYmUgcmVjb2duaXphYmxlIGluCisJCSAqIHRoZSBsb2cgbWVzc2FnZSBi ZWxvdy4KKwkJICovCisJCXVubWFwLnN0YXR1cyA9IDE7CisKKwkJcmMgPSBI WVBFUlZJU09SX2dyYW50X3RhYmxlX29wKEdOVFRBQk9QX3VubWFwX2dyYW50 X3JlZiwKKwkJCQkJICAgICAgICZ1bm1hcCwgMSk7CisJCWlmIChyYyB8fCB1 bm1hcC5zdGF0dXMgIT0gR05UU1Rfb2theSkKKwkJCXByX2Vycl9vbmNlKCJn bnR0YWIgdW5tYXAgZmFpbGVkOiByYz0lZCBzdD0lZFxuIiwKKwkJCQkgICAg cmMsIHVubWFwLnN0YXR1cyk7CiAJfQogCiAJcmV0dXJuIDA7Ci0tLSBhL2Fy Y2gveDg2L3hlbi9wMm0uYworKysgYi9hcmNoL3g4Ni94ZW4vcDJtLmMKQEAg LTcxMCw2ICs3MTAsOCBAQCBpbnQgc2V0X2ZvcmVpZ25fcDJtX21hcHBpbmco c3RydWN0IGdudHRhCiAKIAlmb3IgKGkgPSAwOyBpIDwgY291bnQ7IGkrKykg ewogCQl1bnNpZ25lZCBsb25nIG1mbiwgcGZuOworCQlzdHJ1Y3QgZ250dGFi X3VubWFwX2dyYW50X3JlZiB1bm1hcFsyXTsKKwkJaW50IHJjOwogCiAJCS8q IERvIG5vdCBhZGQgdG8gb3ZlcnJpZGUgaWYgdGhlIG1hcCBmYWlsZWQuICov CiAJCWlmIChtYXBfb3BzW2ldLnN0YXR1cyAhPSBHTlRTVF9va2F5IHx8CkBA IC03MjcsMTAgKzcyOSw0NiBAQCBpbnQgc2V0X2ZvcmVpZ25fcDJtX21hcHBp bmcoc3RydWN0IGdudHRhCiAKIAkJV0FSTihwZm5fdG9fbWZuKHBmbikgIT0g SU5WQUxJRF9QMk1fRU5UUlksICJwYWdlIG11c3QgYmUgYmFsbG9vbmVkIik7 CiAKLQkJaWYgKHVubGlrZWx5KCFzZXRfcGh5c190b19tYWNoaW5lKHBmbiwg Rk9SRUlHTl9GUkFNRShtZm4pKSkpIHsKLQkJCXJldCA9IC1FTk9NRU07Ci0J CQlnb3RvIG91dDsKKwkJaWYgKGxpa2VseShzZXRfcGh5c190b19tYWNoaW5l KHBmbiwgRk9SRUlHTl9GUkFNRShtZm4pKSkpCisJCQljb250aW51ZTsKKwor CQkvKgorCQkgKiBTaWduYWwgYW4gZXJyb3IgZm9yIHRoaXMgc2xvdC4gVGhp cyBpbiB0dXJuIHJlcXVpcmVzCisJCSAqIGltbWVkaWF0ZSB1bm1hcHBpbmcu CisJCSAqLworCQltYXBfb3BzW2ldLnN0YXR1cyA9IEdOVFNUX2dlbmVyYWxf ZXJyb3I7CisJCXVubWFwWzBdLmhvc3RfYWRkciA9IG1hcF9vcHNbaV0uaG9z dF9hZGRyLAorCQl1bm1hcFswXS5oYW5kbGUgPSBtYXBfb3BzW2ldLmhhbmRs ZTsKKwkJbWFwX29wc1tpXS5oYW5kbGUgPSB+MDsKKwkJaWYgKG1hcF9vcHNb aV0uZmxhZ3MgJiBHTlRNQVBfZGV2aWNlX21hcCkKKwkJCXVubWFwWzBdLmRl dl9idXNfYWRkciA9IG1hcF9vcHNbaV0uZGV2X2J1c19hZGRyOworCQllbHNl CisJCQl1bm1hcFswXS5kZXZfYnVzX2FkZHIgPSAwOworCisJCWlmIChrbWFw X29wcykgeworCQkJa21hcF9vcHNbaV0uc3RhdHVzID0gR05UU1RfZ2VuZXJh bF9lcnJvcjsKKwkJCXVubWFwWzFdLmhvc3RfYWRkciA9IGttYXBfb3BzW2ld Lmhvc3RfYWRkciwKKwkJCXVubWFwWzFdLmhhbmRsZSA9IGttYXBfb3BzW2ld LmhhbmRsZTsKKwkJCWttYXBfb3BzW2ldLmhhbmRsZSA9IH4wOworCQkJaWYg KGttYXBfb3BzW2ldLmZsYWdzICYgR05UTUFQX2RldmljZV9tYXApCisJCQkJ dW5tYXBbMV0uZGV2X2J1c19hZGRyID0ga21hcF9vcHNbaV0uZGV2X2J1c19h ZGRyOworCQkJZWxzZQorCQkJCXVubWFwWzFdLmRldl9idXNfYWRkciA9IDA7 CiAJCX0KKworCQkvKgorCQkgKiBQcmUtcG9wdWxhdGUgYm90aCBzdGF0dXMg ZmllbGRzLCB0byBiZSByZWNvZ25pemFibGUgaW4KKwkJICogdGhlIGxvZyBt ZXNzYWdlIGJlbG93LgorCQkgKi8KKwkJdW5tYXBbMF0uc3RhdHVzID0gMTsK KwkJdW5tYXBbMV0uc3RhdHVzID0gMTsKKworCQlyYyA9IEhZUEVSVklTT1Jf Z3JhbnRfdGFibGVfb3AoR05UVEFCT1BfdW5tYXBfZ3JhbnRfcmVmLAorCQkJ CQkgICAgICAgdW5tYXAsIDEgKyAhIWttYXBfb3BzKTsKKwkJaWYgKHJjIHx8 IHVubWFwWzBdLnN0YXR1cyAhPSBHTlRTVF9va2F5IHx8CisJCSAgICB1bm1h cFsxXS5zdGF0dXMgIT0gR05UU1Rfb2theSkKKwkJCXByX2Vycl9vbmNlKCJn bnR0YWIgdW5tYXAgZmFpbGVkOiByYz0lZCBzdDA9JWQgc3QxPSVkXG4iLAor CQkJCSAgICByYywgdW5tYXBbMF0uc3RhdHVzLCB1bm1hcFsxXS5zdGF0dXMp OwogCX0KIAogb3V0Ogo= --=separator-- From xen-devel-bounces@lists.xenproject.org Fri Mar 05 17:08:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 17:08:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.93925.177511 (Exim 4.92) (envelope-from ) id 1lIDwB-0008T1-O5; Fri, 05 Mar 2021 17:08:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93925.177511; Fri, 05 Mar 2021 17:08:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDwB-0008Sr-K6; Fri, 05 Mar 2021 17:08:27 +0000 Received: by outflank-mailman (input) for mailman id 93925; Fri, 05 Mar 2021 17:08:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDwA-0008Bc-FJ for xen-devel@lists.xen.org; Fri, 05 Mar 2021 17:08:26 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bba8bc0d-d8fe-4eec-91df-9b8f16d0d13c; Fri, 05 Mar 2021 17:07:57 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDvd-0002py-5g; Fri, 05 Mar 2021 17:07:53 +0000 Received: from iwj by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIDvd-0006DY-2i; Fri, 05 Mar 2021 17:07:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bba8bc0d-d8fe-4eec-91df-9b8f16d0d13c DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=pcs0J1LGYyWD7P7XSVjGHJrS5z474WyVnONCbcRttWs=; b=gbcqdpYStqyx7Nyz9vVFGxyCHM GUAajoYTHYe6983ylwOH7tzRQYsmpeh2+hDukRcJbIWUg/9VsWCXReZIND0B09e4HHFzqVcDOvFer cWQWwLMdgKjff9Tx+zaH6Uh3p7KyfExg0oFNPCbtJAEHSbtWtzqqbOEg7U++t7a/DiGw=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 369 v2 (CVE-2021-28039) - Linux: special config may crash when trying to map foreign pages Message-Id: Date: Fri, 05 Mar 2021 17:07:53 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2021-28039 / XSA-369 version 2 Linux: special config may crash when trying to map foreign pages UPDATES IN VERSION 2 ==================== CVE assigned. ISSUE DESCRIPTION ================= With CONFIG_XEN_BALLOON_MEMORY_HOTPLUG disabled and CONFIG_XEN_UNPOPULATED_ALLOC enabled the Linux kernel will use guest physical addresses allocated via the ZONE_DEVICE functionality for mapping foreign guest's pages. This will result in problems, as the p2m list will only cover the initial memory size of the domain plus some padding at the end. Most ZONE_DEVICE allocated addresses will be outside the p2m range and thus a mapping can't be established with those memory addresses, resulting in a crash. The attack involves doing I/O requiring large amounts of data to be mapped by the Dom0 or driver domain. The amount of data needed to result in a crash can vary depending on the memory layout of the affected Dom0 or driver domain. IMPACT ====== A Dom0 or driver domain based on a Linux kernel (configured as described above) can be crashed by a malicious guest administrator, or possibly malicious unprivileged guest processes. VULNERABLE SYSTEMS ================== Only x86 paravirtualized (PV) Dom0 or driver domains are affected. Only Linux kernels configured *with* CONFIG_XEN_UNPOPULATED_ALLOC and *without* CONFIG_XEN_BALLOON_MEMORY_HOTPLUG are vulnerable. Only kernels from kernel version 5.9 onwards are affected. CONFIG_XEN_BALLOON_MEMORY_HOTPLUG is enabled by default in upstream Linux when Xen support is enabled, so kernels using upstream default Kconfig are not affected. Most distribution kernels supporting Xen dom0 use are likewise not vulnerable. Arm systems or x86 PVH or x86 HVM driver domains are not affected. MITIGATION ========== There is no mitigation available. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. xsa369-linux.patch Linux 5.9-stable - 5.12-rc $ sha256sum xsa369* 937df4f078a070cf47bdd718c6b8a042ec6bee255eedc422d833c2ae3dd561c7 xsa369-linux.patch $ CREDITS ======= This issue was discovered by Marek Marczykowski-Górecki of Invisible Things Lab. For patch: Reported-by: Marek Marczykowski-Górecki NOTE REGARDING LACK OF EMBARGO ============================== This was reported publicly multiple times, before the XSA could be issued. -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmBCZVUMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZp8wIALvuzrh0iQDIg86Mx/eTtfVflmrz91YiDPfhrDj1 L1D2lR+uFPKFpb3CdDTlzKoby/1ym4wbTLCjnDdXxjmPTdn4KybcBNbNONt2p69X dr/3KsO6yW5tjSi3FRZnnyTnTJN/q65tijG23sAcF7KuNW+xT2d70tWMH+LeMQZO fGkztK08cZspFfZZiOJHuqi5qpzoaBw7/vqlCphoiDMeE1EOGpaa/+bGb4doehyj dN8dyEWbyWdTp5lAxmduJfDMuixeESIxPnXP8jV3Z9b+Gt5l9S0cM+DCWDRUkW3M W0Z7va35sFLCx4+N7fLuzMUkzoLWpTJq2i2m9lploexe3nY= =PtNk -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa369-linux.patch" Content-Disposition: attachment; filename="xsa369-linux.patch" Content-Transfer-Encoding: base64 RnJvbTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpTdWJqZWN0 OiB4ZW46IGZpeCBwMm0gc2l6ZSBpbiBkb20wIGZvciBkaXNhYmxlZCBtZW1v cnkgaG90cGx1ZyBjYXNlCgpTaW5jZSBjb21taXQgOWUyMzY5YzA2YzhhMTgg KCJ4ZW46IGFkZCBoZWxwZXJzIHRvIGFsbG9jYXRlIHVucG9wdWxhdGVkCm1l bW9yeSIpIGZvcmVpZ24gbWFwcGluZ3MgYXJlIHVzaW5nIGd1ZXN0IHBoeXNp Y2FsIGFkZHJlc3NlcyBhbGxvY2F0ZWQKdmlhIFpPTkVfREVWSUNFIGZ1bmN0 aW9uYWxpdHkuCgpUaGlzIHdpbGwgcmVzdWx0IGluIHByb2JsZW1zIGZvciB0 aGUgY2FzZSBvZiBubyBiYWxsb29uIG1lbW9yeSBob3RwbHVnCmJlaW5nIGNv bmZpZ3VyZWQsIGFzIHRoZSBwMm0gbGlzdCB3aWxsIG9ubHkgY292ZXIgdGhl IGluaXRpYWwgbWVtb3J5CnNpemUgb2YgdGhlIGRvbWFpbi4gQW55IFpPTkVf REVWSUNFIGFsbG9jYXRlZCBhZGRyZXNzIHdpbGwgYmUgb3V0c2lkZQp0aGUg cDJtIHJhbmdlIGFuZCB0aHVzIGEgbWFwcGluZyBjYW4ndCBiZSBlc3RhYmxp c2hlZCB3aXRoIHRoYXQgbWVtb3J5CmFkZHJlc3MuCgpGaXggdGhhdCBieSBl eHRlbmRpbmcgdGhlIHAybSBzaXplIGZvciB0aGF0IGNhc2UuIEF0IHRoZSBz YW1lIHRpbWUgYWRkCmEgY2hlY2sgZm9yIGEgdG8gYmUgY3JlYXRlZCBtYXBw aW5nIHRvIGJlIHdpdGhpbiB0aGUgcDJtIGxpbWl0cyBpbgpvcmRlciB0byBk ZXRlY3QgZXJyb3JzIGVhcmx5LgoKV2hpbGUgY2hhbmdpbmcgYSBjb21tZW50 LCByZW1vdmUgc29tZSAzMi1iaXQgbGVmdG92ZXJzLgoKVGhpcyBpcyBYU0Et MzY5LgoKRml4ZXM6IDllMjM2OWMwNmM4YTE4ICgieGVuOiBhZGQgaGVscGVy cyB0byBhbGxvY2F0ZSB1bnBvcHVsYXRlZCBtZW1vcnkiKQpDYzogPHN0YWJs ZUB2Z2VyLmtlcm5lbC5vcmc+ICMgNS45ClJlcG9ydGVkLWJ5OiBNYXJlayBN YXJjenlrb3dza2ktR8OzcmVja2kgPG1hcm1hcmVrQGludmlzaWJsZXRoaW5n c2xhYi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj aEBzdXNlLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdy b3NzQHN1c2UuY29tPgotLS0KIGFyY2gveDg2L2luY2x1ZGUvYXNtL3hlbi9w YWdlLmggfCAxMiArKysrKysrKysrKysKIGFyY2gveDg2L3hlbi9wMm0uYyAg ICAgICAgICAgICAgfCAxMCArKysrKystLS0tCiBhcmNoL3g4Ni94ZW4vc2V0 dXAuYyAgICAgICAgICAgIHwgMjUgKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQogMyBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCAyNiBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9hcmNoL3g4Ni9pbmNsdWRlL2FzbS94 ZW4vcGFnZS5oIGIvYXJjaC94ODYvaW5jbHVkZS9hc20veGVuL3BhZ2UuaApp bmRleCAxYTE2MmU1NTk3NTMuLjcwNjhlNGJiMDU3ZCAxMDA2NDQKLS0tIGEv YXJjaC94ODYvaW5jbHVkZS9hc20veGVuL3BhZ2UuaAorKysgYi9hcmNoL3g4 Ni9pbmNsdWRlL2FzbS94ZW4vcGFnZS5oCkBAIC04Niw2ICs4NiwxOCBAQCBj bGVhcl9mb3JlaWduX3AybV9tYXBwaW5nKHN0cnVjdCBnbnR0YWJfdW5tYXBf Z3JhbnRfcmVmICp1bm1hcF9vcHMsCiB9CiAjZW5kaWYKIAorLyoKKyAqIFRo ZSBtYXhpbXVtIGFtb3VudCBvZiBleHRyYSBtZW1vcnkgY29tcGFyZWQgdG8g dGhlIGJhc2Ugc2l6ZS4gIFRoZQorICogbWFpbiBzY2FsaW5nIGZhY3RvciBp cyB0aGUgc2l6ZSBvZiBzdHJ1Y3QgcGFnZS4gIEF0IGV4dHJlbWUgcmF0aW9z CisgKiBvZiBiYXNlOmV4dHJhLCBhbGwgdGhlIGJhc2UgbWVtb3J5IGNhbiBi ZSBmaWxsZWQgd2l0aCBwYWdlCisgKiBzdHJ1Y3R1cmVzIGZvciB0aGUgZXh0 cmEgbWVtb3J5LCBsZWF2aW5nIG5vIHNwYWNlIGZvciBhbnl0aGluZworICog ZWxzZS4KKyAqCisgKiAxMHggc2VlbXMgbGlrZSBhIHJlYXNvbmFibGUgYmFs YW5jZSBiZXR3ZWVuIHNjYWxpbmcgZmxleGliaWxpdHkgYW5kCisgKiBsZWF2 aW5nIGEgcHJhY3RpY2FsbHkgdXNhYmxlIHN5c3RlbS4KKyAqLworI2RlZmlu ZSBYRU5fRVhUUkFfTUVNX1JBVElPCSgxMCkKKwogLyoKICAqIEhlbHBlciBm dW5jdGlvbnMgdG8gd3JpdGUgb3IgcmVhZCB1bnNpZ25lZCBsb25nIHZhbHVl cyB0by9mcm9tCiAgKiBtZW1vcnksIHdoZW4gdGhlIGFjY2VzcyBtYXkgZmF1 bHQuCmRpZmYgLS1naXQgYS9hcmNoL3g4Ni94ZW4vcDJtLmMgYi9hcmNoL3g4 Ni94ZW4vcDJtLmMKaW5kZXggOTU0NWI4ZGY1MzE1Li5lZDM1ODVlZWJjNGUg MTAwNjQ0Ci0tLSBhL2FyY2gveDg2L3hlbi9wMm0uYworKysgYi9hcmNoL3g4 Ni94ZW4vcDJtLmMKQEAgLTQxNiw2ICs0MTYsOSBAQCB2b2lkIF9faW5pdCB4 ZW5fdm1hbGxvY19wMm1fdHJlZSh2b2lkKQogCXhlbl9wMm1fbGFzdF9wZm4g PSB4ZW5fbWF4X3AybV9wZm47CiAKIAlwMm1fbGltaXQgPSAocGh5c19hZGRy X3QpUDJNX0xJTUlUICogMTAyNCAqIDEwMjQgKiAxMDI0IC8gUEFHRV9TSVpF OworCWlmICghcDJtX2xpbWl0ICYmIElTX0VOQUJMRUQoQ09ORklHX1hFTl9V TlBPUFVMQVRFRF9BTExPQykpCisJCXAybV9saW1pdCA9IHhlbl9zdGFydF9p bmZvLT5ucl9wYWdlcyAqIFhFTl9FWFRSQV9NRU1fUkFUSU87CisKIAl2bS5m bGFncyA9IFZNX0FMTE9DOwogCXZtLnNpemUgPSBBTElHTihzaXplb2YodW5z aWduZWQgbG9uZykgKiBtYXgoeGVuX21heF9wMm1fcGZuLCBwMm1fbGltaXQp LAogCQkJUE1EX1NJWkUgKiBQTURTX1BFUl9NSURfUEFHRSk7CkBAIC02NTIs MTAgKzY1NSw5IEBAIGJvb2wgX19zZXRfcGh5c190b19tYWNoaW5lKHVuc2ln bmVkIGxvbmcgcGZuLCB1bnNpZ25lZCBsb25nIG1mbikKIAlwdGVfdCAqcHRl cDsKIAl1bnNpZ25lZCBpbnQgbGV2ZWw7CiAKLQlpZiAodW5saWtlbHkocGZu ID49IHhlbl9wMm1fc2l6ZSkpIHsKLQkJQlVHX09OKG1mbiAhPSBJTlZBTElE X1AyTV9FTlRSWSk7Ci0JCXJldHVybiB0cnVlOwotCX0KKwkvKiBPbmx5IGlu dmFsaWQgZW50cmllcyBhbGxvd2VkIGFib3ZlIHRoZSBoaWdoZXN0IHAybSBj b3ZlcmVkIGZyYW1lLiAqLworCWlmICh1bmxpa2VseShwZm4gPj0geGVuX3Ay bV9zaXplKSkKKwkJcmV0dXJuIG1mbiA9PSBJTlZBTElEX1AyTV9FTlRSWTsK IAogCS8qCiAJICogVGhlIGludGVyZmFjZSByZXF1aXJlcyBhdG9taWMgdXBk YXRlcyBvbiBwMm0gZWxlbWVudHMuCmRpZmYgLS1naXQgYS9hcmNoL3g4Ni94 ZW4vc2V0dXAuYyBiL2FyY2gveDg2L3hlbi9zZXR1cC5jCmluZGV4IDdlYWIx NGQ1NjM2OS4uMWEzYjc1NjUyZmE0IDEwMDY0NAotLS0gYS9hcmNoL3g4Ni94 ZW4vc2V0dXAuYworKysgYi9hcmNoL3g4Ni94ZW4vc2V0dXAuYwpAQCAtNTks MTggKzU5LDYgQEAgc3RhdGljIHN0cnVjdCB7CiB9IHhlbl9yZW1hcF9idWYg X19pbml0ZGF0YSBfX2FsaWduZWQoUEFHRV9TSVpFKTsKIHN0YXRpYyB1bnNp Z25lZCBsb25nIHhlbl9yZW1hcF9tZm4gX19pbml0ZGF0YSA9IElOVkFMSURf UDJNX0VOVFJZOwogCi0vKiAKLSAqIFRoZSBtYXhpbXVtIGFtb3VudCBvZiBl eHRyYSBtZW1vcnkgY29tcGFyZWQgdG8gdGhlIGJhc2Ugc2l6ZS4gIFRoZQot ICogbWFpbiBzY2FsaW5nIGZhY3RvciBpcyB0aGUgc2l6ZSBvZiBzdHJ1Y3Qg cGFnZS4gIEF0IGV4dHJlbWUgcmF0aW9zCi0gKiBvZiBiYXNlOmV4dHJhLCBh bGwgdGhlIGJhc2UgbWVtb3J5IGNhbiBiZSBmaWxsZWQgd2l0aCBwYWdlCi0g KiBzdHJ1Y3R1cmVzIGZvciB0aGUgZXh0cmEgbWVtb3J5LCBsZWF2aW5nIG5v IHNwYWNlIGZvciBhbnl0aGluZwotICogZWxzZS4KLSAqIAotICogMTB4IHNl ZW1zIGxpa2UgYSByZWFzb25hYmxlIGJhbGFuY2UgYmV0d2VlbiBzY2FsaW5n IGZsZXhpYmlsaXR5IGFuZAotICogbGVhdmluZyBhIHByYWN0aWNhbGx5IHVz YWJsZSBzeXN0ZW0uCi0gKi8KLSNkZWZpbmUgRVhUUkFfTUVNX1JBVElPCQko MTApCi0KIHN0YXRpYyBib29sIHhlbl81MTJnYl9saW1pdCBfX2luaXRkYXRh ID0gSVNfRU5BQkxFRChDT05GSUdfWEVOXzUxMkdCKTsKIAogc3RhdGljIHZv aWQgX19pbml0IHhlbl9wYXJzZV81MTJnYih2b2lkKQpAQCAtNzkwLDIwICs3 NzgsMTMgQEAgY2hhciAqIF9faW5pdCB4ZW5fbWVtb3J5X3NldHVwKHZvaWQp CiAJCWV4dHJhX3BhZ2VzICs9IG1heF9wYWdlcyAtIG1heF9wZm47CiAKIAkv KgotCSAqIENsYW1wIHRoZSBhbW91bnQgb2YgZXh0cmEgbWVtb3J5IHRvIGEg RVhUUkFfTUVNX1JBVElPCi0JICogZmFjdG9yIHRoZSBiYXNlIHNpemUuICBP biBub24taGlnaG1lbSBzeXN0ZW1zLCB0aGUgYmFzZQotCSAqIHNpemUgaXMg dGhlIGZ1bGwgaW5pdGlhbCBtZW1vcnkgYWxsb2NhdGlvbjsgb24gaGlnaG1l bSBpdAotCSAqIGlzIGxpbWl0ZWQgdG8gdGhlIG1heCBzaXplIG9mIGxvd21l bSwgc28gdGhhdCBpdCBkb2Vzbid0Ci0JICogZ2V0IGNvbXBsZXRlbHkgZmls bGVkLgorCSAqIENsYW1wIHRoZSBhbW91bnQgb2YgZXh0cmEgbWVtb3J5IHRv IGEgWEVOX0VYVFJBX01FTV9SQVRJTworCSAqIGZhY3RvciB0aGUgYmFzZSBz aXplLgogCSAqCiAJICogTWFrZSBzdXJlIHdlIGhhdmUgbm8gbWVtb3J5IGFi b3ZlIG1heF9wYWdlcywgYXMgdGhpcyBhcmVhCiAJICogaXNuJ3QgaGFuZGxl ZCBieSB0aGUgcDJtIG1hbmFnZW1lbnQuCi0JICoKLQkgKiBJbiBwcmluY2lw bGUgdGhlcmUgY291bGQgYmUgYSBwcm9ibGVtIGluIGxvd21lbSBzeXN0ZW1z IGlmCi0JICogdGhlIGluaXRpYWwgbWVtb3J5IGlzIGFsc28gdmVyeSBsYXJn ZSB3aXRoIHJlc3BlY3QgdG8KLQkgKiBsb3dtZW0sIGJ1dCB3ZSB3b24ndCB0 cnkgdG8gZGVhbCB3aXRoIHRoYXQgaGVyZS4KIAkgKi8KLQlleHRyYV9wYWdl cyA9IG1pbjMoRVhUUkFfTUVNX1JBVElPICogbWluKG1heF9wZm4sIFBGTl9E T1dOKE1BWE1FTSkpLAorCWV4dHJhX3BhZ2VzID0gbWluMyhYRU5fRVhUUkFf TUVNX1JBVElPICogbWluKG1heF9wZm4sIFBGTl9ET1dOKE1BWE1FTSkpLAog CQkJICAgZXh0cmFfcGFnZXMsIG1heF9wYWdlcyAtIG1heF9wZm4pOwogCWkg PSAwOwogCWFkZHIgPSB4ZW5fZTgyMF90YWJsZS5lbnRyaWVzWzBdLmFkZHI7 Ci0tIAoyLjI2LjIKCg== --=separator-- From xen-devel-bounces@lists.xenproject.org Fri Mar 05 17:27:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 17:27:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94026.177526 (Exim 4.92) (envelope-from ) id 1lIEEU-0002tr-Oz; Fri, 05 Mar 2021 17:27:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94026.177526; Fri, 05 Mar 2021 17:27:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIEEU-0002tk-Lf; Fri, 05 Mar 2021 17:27:22 +0000 Received: by outflank-mailman (input) for mailman id 94026; Fri, 05 Mar 2021 17:27:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIEET-0002tc-MU; Fri, 05 Mar 2021 17:27:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIEET-0003AS-H9; Fri, 05 Mar 2021 17:27:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIEET-0008R3-2P; Fri, 05 Mar 2021 17:27:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIEET-00019b-1w; Fri, 05 Mar 2021 17:27:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8fFme2oSm0SkjSiLr7xJopXXWU8C3NzJw1t1tX3ZYcU=; b=KW8Q9BTR+rsog5yqS/fMzdaS72 dVyvP3zbl7ufJiR5M0LEj4kAyeM/xqc/ZSBRKzL/BWWHQxGBCDURYAVDH0M0DHCH76UskFmtXlQVT RqUOaItfdTTQXzSYmHquZJD0TB8Z8bDEvj7FWMQuvBW/4GQNkuNXVd8GXyM7dlNduXzw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159834: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-saverestore:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=cb90ecf9349198558569f6c86c4c27d215406095 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Fri, 05 Mar 2021 17:27:21 +0000 flight 159834 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/159834/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 159828 REGR. vs. 152631 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 16 guest-saverestore fail pass in 159828 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 159828 like 152631 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu cb90ecf9349198558569f6c86c4c27d215406095 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 197 days Failing since 152659 2020-08-21 14:07:39 Z 196 days 378 attempts Testing same since 159828 2021-03-04 14:08:29 Z 1 days 2 attempts ------------------------------------------------------------ 433 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 118747 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Mar 05 20:10:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 05 Mar 2021 20:10:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94083.177540 (Exim 4.92) (envelope-from ) id 1lIGm6-0002Rk-M1; Fri, 05 Mar 2021 20:10:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94083.177540; Fri, 05 Mar 2021 20:10:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIGm6-0002Rd-Hx; Fri, 05 Mar 2021 20:10:14 +0000 Received: by outflank-mailman (input) for mailman id 94083; Fri, 05 Mar 2021 20:10:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIGm5-0002RV-7k; Fri, 05 Mar 2021 20:10:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIGm5-0005x4-2J; Fri, 05 Mar 2021 20:10:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIGm4-0000VF-P5; Fri, 05 Mar 2021 20:10:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIGm4-0000aY-OV; Fri, 05 Mar 2021 20:10:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=d8Emgk70A6dI1HDTu0FuXVNO3aNwMlrjC4dupprcFOE=; b=mrUfEPywvRbhm7e70xn4gifrSh okI+r9Sm5LFTmRJyqRym+o+pfq8+/GpytIn64fKTVegKu+0dIHfFRM4R9/5qJoCqplMphVQhKZJF9 zldMSWw8EZ6L0ZGL5CU/sOkT3bzNTDvUZkUphaZGsDM4/8z4qXQnhf/MwUkJtgUmuKbE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159835: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-localmigrate/x10:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=280d542f6ffac0e6d65dc267f92191d509b13b64 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Fri, 05 Mar 2021 20:10:12 +0000 flight 159835 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159835/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 19 guest-localmigrate/x10 fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux 280d542f6ffac0e6d65dc267f92191d509b13b64 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 217 days Failing since 152366 2020-08-01 20:49:34 Z 215 days 374 attempts Testing same since 159835 2021-03-05 09:06:41 Z 0 days 1 attempts ------------------------------------------------------------ 5144 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1273214 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 06 00:36:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 00:36:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94100.177556 (Exim 4.92) (envelope-from ) id 1lIKv4-0002CI-Bl; Sat, 06 Mar 2021 00:35:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94100.177556; Sat, 06 Mar 2021 00:35:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIKv4-0002CB-8Z; Sat, 06 Mar 2021 00:35:46 +0000 Received: by outflank-mailman (input) for mailman id 94100; Sat, 06 Mar 2021 00:35:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIKv2-0002C3-5s; Sat, 06 Mar 2021 00:35:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIKv1-0002Md-UH; Sat, 06 Mar 2021 00:35:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIKv1-0007Mm-Jm; Sat, 06 Mar 2021 00:35:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIKv1-00013g-HY; Sat, 06 Mar 2021 00:35:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=47/E7xnRX4+ummwKwV7odvwfUF7RQiV5a11If32U9aM=; b=SWZKKfXfUL8wQvGfvYIlUvJKXY xAtz1RTVqOxiSvqivngaLNytyWvOiS6xDmsab2cijcTdHI6W5RINR66IJymTSEn1kZEV07hQ6TmuI oDDAkw9SiQDe0Bh7UPbRaQPcjs6q5//VH4IqX93OjbN5i3TKfvayIlERbPJDvELRg6dc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159838: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f40e1c52e4e0a3e084b025ed6b68f1e6ebaea027 X-Osstest-Versions-That: xen=f40e1c52e4e0a3e084b025ed6b68f1e6ebaea027 From: osstest service owner Date: Sat, 06 Mar 2021 00:35:43 +0000 flight 159838 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/159838/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159831 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159831 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159831 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159831 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159831 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159831 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159831 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159831 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159831 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159831 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159831 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen f40e1c52e4e0a3e084b025ed6b68f1e6ebaea027 baseline version: xen f40e1c52e4e0a3e084b025ed6b68f1e6ebaea027 Last test of basis 159838 2021-03-05 14:04:34 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Mar 06 01:41:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 01:41:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94109.177571 (Exim 4.92) (envelope-from ) id 1lILw7-0002Gf-EK; Sat, 06 Mar 2021 01:40:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94109.177571; Sat, 06 Mar 2021 01:40:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lILw7-0002GW-7E; Sat, 06 Mar 2021 01:40:55 +0000 Received: by outflank-mailman (input) for mailman id 94109; Sat, 06 Mar 2021 01:40:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lILw5-0002GR-RQ for xen-devel@lists.xenproject.org; Sat, 06 Mar 2021 01:40:53 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 89551446-9c03-428f-b62b-66d3811d5b51; Sat, 06 Mar 2021 01:40:53 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id E2EF764FEE; Sat, 6 Mar 2021 01:40:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89551446-9c03-428f-b62b-66d3811d5b51 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614994852; bh=VwVZDWV1nSdGBwWMZFS5HrRiJom7YCQaAQfnELq9yQw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=bnYxafH4OZkv5sI7WKXT3rAh86FeWv89b6SVrZoOMmJG7bzVRFQySuw3eHLPI8qG+ am8u/bwIG2MaR9jOR3E0QnIbBb24bSs2k/MPXz8aa5uEGowLJc3jBro8F5a/BNDKgq RhlKS4K8/aFzH98LfQncp1UvQNldSpYcui0bINkD75RwOHYD48RQsWWewCeYttDAdA mMuOf1TmRP5Wvl0a/6ePlFWZtyEC0zf1ctwtvRwUN2oPZ/vmnVQAf/oAWDJRuaP0X7 naEtxVOI6mCYB1UBc521ctIcuG4z4zKgVSapkP1rESLTEx8B9dX1qg15+hY1AtjcX1 Mkb4cELWNtpaA== Date: Fri, 5 Mar 2021 17:40:51 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Stefano Stabellini cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org, Doug Goldstein , Ian Jackson , Andrew Cooper Subject: Re: [PATCH for-4.15] automation/alpine: add g++ to the list of build depends In-Reply-To: Message-ID: References: <20210301095806.68518-1-roger.pau@citrix.com> <27ec9db0-69bc-df9a-8511-109f57972046@citrix.com> <77e7004f-8a73-e868-1ccd-318de5886f4a@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-802107187-1614994852=:14213" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-802107187-1614994852=:14213 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 2 Mar 2021, Stefano Stabellini wrote: > On Tue, 2 Mar 2021, Jan Beulich wrote: > > On 02.03.2021 10:36, Roger Pau Monné wrote: > > > On Tue, Mar 02, 2021 at 09:53:41AM +0100, Jan Beulich wrote: > > >> On 02.03.2021 09:14, Roger Pau Monné wrote: > > >>> On Mon, Mar 01, 2021 at 06:01:36PM +0000, Andrew Cooper wrote: > > >>>> On 01/03/2021 17:59, Andrew Cooper wrote: > > >>>>> On 01/03/2021 09:58, Roger Pau Monne wrote: > > >>>>>> clang++ relies on the C++ headers installed by g++, or else a clang > > >>>>>> build will hit the following error: > > >>>>>> > > >>>>>> :3:10: fatal error: 'cstring' file not found > > >>>>>> #include "cstring" > > >>>>>> ^~~~~~~~~ > > >>>>>> 1 error generated. > > >>>>>> make[10]: *** [Makefile:120: headers++.chk] Error 1 > > >>>>>> > > >>>>>> Reported-by: Stefano Stabellini > > >>>>>> Signed-off-by: Roger Pau Monné > > >>>>>> --- > > >>>>>> Cc: Ian Jackson > > >>>>>> No real risk here from a release PoV, it's just pulling a package > > >>>>>> required for the Alpine clang build. Worse that cold happen is that > > >>>>>> the Alpine clang build broke, but it's already broken. > > >>>>> Shouldn't this be fixed upstream in Alpine?  Its clearly a packaging bug. > > >>>> > > >>>> Or (thinking about it), we've got a build system bug using g++ when it > > >>>> should be using clang++. > > >>> > > >>> No, the check is using clang++, the issue is that clang++ doesn't > > >>> install the standard c++ headers, and thus trying to use them (cstring > > >>> in this case) fails. Installing the g++ package solves the issue > > >>> because it installs the headers. > > >> > > >> I have to admit that I consider this odd. The g++ package should > > >> neither provide nor depend on the headers. It may recommend their > > >> installation. On my distro (SLES) the headers come from the > > >> libstdc++-devel package, as I would have expected. There > > >> additionally is a dependency of libclang5 (no -devel suffix!) on > > >> libstdc++-devel (I suppose this is an indication that things > > >> aren't quite right here either; I haven't checked an up-to-date > > >> version of the distro yet, though). > > > > > > Yes, that was indeed my first attempt as I've tried to install > > > libstdc++, but there's no -devel counterpart for the package, and it > > > only installs the libraries but not the headers. > > > > > > Then if I list the contents of the g++ package, I do see: > > > > > > ... > > > usr/include/c++/10.2.1/cstring > > > ... > > > > > > And clang++'s include path is: > > > > > > #include <...> search starts here: > > > /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1 > > > /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1/x86_64-alpine-linux-musl > > > /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1/backward > > > /usr/include > > > /usr/lib/clang/10.0.1/include > > > > > > So it does seem clang depends on the gcc c++ headers, I assume this is > > > done in order to avoid having a duplicate set of c++ headers for clang > > > and gcc? I really have no idea, but I do think clang package should > > > depend on g++. > > > > As long as the g++ package is what provides the headers (i.e. if that's > > their concept), I agree. > > That makes sense to me too. > > Acked-by: Stefano Stabellini If nobody speaks up, I'll commit this patch and this patch: https://marc.info/?l=xen-devel&m=161433737432684 (both of them already acked by Ian and only affecting automation/) within the next day or two. --8323329-802107187-1614994852=:14213-- From xen-devel-bounces@lists.xenproject.org Sat Mar 06 04:12:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 04:12:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94124.177583 (Exim 4.92) (envelope-from ) id 1lIOIi-0008Hw-71; Sat, 06 Mar 2021 04:12:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94124.177583; Sat, 06 Mar 2021 04:12:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIOIi-0008Hp-3r; Sat, 06 Mar 2021 04:12:24 +0000 Received: by outflank-mailman (input) for mailman id 94124; Sat, 06 Mar 2021 04:12:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIOIh-0008Hh-9w; Sat, 06 Mar 2021 04:12:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIOIh-0007tF-30; Sat, 06 Mar 2021 04:12:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIOIg-00008w-R4; Sat, 06 Mar 2021 04:12:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIOIg-0004mM-Po; Sat, 06 Mar 2021 04:12:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LXdzffgWgadB57pouIzAfgHI2laskCx4Z80cpcir/C0=; b=UR29HzEv5bYd85FoEE4Xbx5TJf APsbOmlcVnFFp93xdlK8++wQgO9QIbNdOvd/SwiIDt8+J5zOzXSKde3pEZ8cdvxLjzqaqAfCBjgSW zCCb9C0YZPDAWlwVPltxi/wpni0OqpxVtChh0rJ6IQyWxasJGzWZOM0d2PjH8nRuBLYM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 159841: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: ovmf=59a3ccb09e7a246913d88fbac31412f20f717a3c X-Osstest-Versions-That: ovmf=c5740f360636479fb91681093b1dee1cc366075c From: osstest service owner Date: Sat, 06 Mar 2021 04:12:22 +0000 flight 159841 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/159841/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-ovmf-amd64 3 hosts-allocate starved n/a version targeted for testing: ovmf 59a3ccb09e7a246913d88fbac31412f20f717a3c baseline version: ovmf c5740f360636479fb91681093b1dee1cc366075c Last test of basis 159836 2021-03-05 09:09:50 Z 0 days Testing same since 159841 2021-03-05 16:11:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Kun Qin Laszlo Ersek jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git c5740f3606..59a3ccb09e 59a3ccb09e7a246913d88fbac31412f20f717a3c -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Mar 06 07:10:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 07:10:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94156.177598 (Exim 4.92) (envelope-from ) id 1lIR4h-0000Ej-PJ; Sat, 06 Mar 2021 07:10:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94156.177598; Sat, 06 Mar 2021 07:10:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIR4h-0000Ec-LZ; Sat, 06 Mar 2021 07:10:07 +0000 Received: by outflank-mailman (input) for mailman id 94156; Sat, 06 Mar 2021 07:10:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIR4g-0000Cw-6p; Sat, 06 Mar 2021 07:10:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIR4g-0002np-1y; Sat, 06 Mar 2021 07:10:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIR4f-0001gC-ND; Sat, 06 Mar 2021 07:10:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIR4f-0004xH-Mk; Sat, 06 Mar 2021 07:10:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jbL3bRThlxBszwo0rYH5OeyAOn34Jg6C+l1AVohu0HY=; b=Vf9agtUUEkXkjEkbHWbg1p+LMH OjqxZqzJ46V4zH8aDlXfU6hj8xK8lhw9Zyd9hjhQwZL7C8lfhq+5nNBqu/Mj0KO/otrGAbxUD7Lvf 0rt6pkQWI1KL5PwKgMJFPi2YhVvOWsz4xOmMwUvrsUeJ2nH2FxCZXzaZH7Ek53ZBHqXg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 159840: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a1dab05393ec5654e2a88be296cc973595ffb1d0 X-Osstest-Versions-That: xen=b0b734a8b3e516ff1040884b755a8d47afed31ea From: osstest service owner Date: Sat, 06 Mar 2021 07:10:05 +0000 flight 159840 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/159840/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159450 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159450 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159450 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159450 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159450 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159450 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159450 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159450 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159450 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159450 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159450 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen a1dab05393ec5654e2a88be296cc973595ffb1d0 baseline version: xen b0b734a8b3e516ff1040884b755a8d47afed31ea Last test of basis 159450 2021-02-17 21:31:04 Z 16 days Testing same since 159840 2021-03-05 15:07:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Dario Faggioli Jan Beulich Jason Andryuk Julien Grall Roger Pau Monné Stefano Stabellini Tamas K Lengyel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b0b734a8b3..a1dab05393 a1dab05393ec5654e2a88be296cc973595ffb1d0 -> stable-4.14 From xen-devel-bounces@lists.xenproject.org Sat Mar 06 09:24:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 09:24:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94193.177681 (Exim 4.92) (envelope-from ) id 1lIT9z-00055t-8V; Sat, 06 Mar 2021 09:23:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94193.177681; Sat, 06 Mar 2021 09:23:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIT9z-00055m-4n; Sat, 06 Mar 2021 09:23:43 +0000 Received: by outflank-mailman (input) for mailman id 94193; Sat, 06 Mar 2021 09:23:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIT9w-00055h-Pn for xen-devel@lists.xenproject.org; Sat, 06 Mar 2021 09:23:41 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8ac7bbc6-1467-4920-9e6f-ab8cf3a1d243; Sat, 06 Mar 2021 09:23:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ac7bbc6-1467-4920-9e6f-ab8cf3a1d243 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615022618; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/CR+4IGwP3Q/UGGFSO04+uFKth4+7rdiuS7zh5x3k7g=; b=IP/BYXLv11tMrUJjZE21ygycGmVBe2HhwYflnv2B+NVeXKMqRiFzEPq+ IUJ0TyHqlHviaUOjiqLyyc85kI18zN6iURRfD+H59C5kFRFYy+VugiZIy wKqoaHfhv6yFP7pdTV/iHvtSj667YwgXsWLdSc02pcjMeZYbT2PPO4Q3B o=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: s3r3AwYv7BNW+/pKFXq+BOCtnbd6PKANZsXUK5dPkX8xmjxtenSXTI35xJZCcqbf7EqcXV8ZWZ 9g9HavGyPoDR63MGbYVyRL3thOgEwb7b84HROojXDu5qm2AxbiM5zonU5XIUZosN87RzdgMujW 5Sd59Mf+pgl0ro6T5UflPGTaVLu12SyLvdPx6tdxUJ7socQ5eSDRyOq+u+QrPjlJS4DVyAk8sx 0Q6o/lPEJ8lsdreneCPh9hvlJFufEQP1vIYb2HeyLxcopB2BVkQIX3YbLYZTm7E+zKZGto59sk NvM= X-SBRS: 5.2 X-MesageID: 38873525 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,227,1610427600"; d="scan'208";a="38873525" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BSEZzr1RFzvj4WuFNh9gn3uqcDklN4dAT51LF7iEJjXT41+vJtLtbXPBoW32DmKNsANhVQ8bt2ubmStx5P4kHKetDfPeBJrNAwgF10Q2o+JcSCGzd1f9dBz+OzC9trjJoj+IYbfxMTSjY9F90dspW/ByoleVHzsLbdilNjTp9HYcBptJBV38HQbFotUtgnffWiv5NafzT3NvyYUOjX+a2nhq6M8AYPrYttO212IONACHWJZjFF8M/KddB0Q8TaOQZWpBS02UnDkU1/zFKLEnjS9pHrN7zFC5ayXH5V81SWk0HQYKX8LU1w1WDDP8Xz3dRXDXQLaTWETRR/0T0DDHkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RAbokgouAJiZok99t77IvB48sf4WX3fJDAvRp5ALggo=; b=Bc0QlrNZ4tL98YjWmpi+PpuQZstOaaquwWjfgCSaL0ha/y4tl8DClN0xCF6XzI76LREuyJByeif0KThHpIHBx/XQBp3uDb6bvO3QHZfQ0jtzViSUClMdOIJ/nXwQ27LZfai54Dz/eZLw8KFZZJywqg/iHt9Nx8dKynTnFqoSotuAr7EjMO0CApzi7D188oqJxi6bE8G6uruJ3x0gKSZvTBqdbyaE1/29N4ERI+/JsJe47uhpKS2iWAdzLZYvi29ati2D7sAlNBiuIi+U5Ij/uL6yHlIGzziWTIENWFIfXkYLlx6AUKx3kkk9trKw3NMhU0nCwJUSIyGIAIUvyqStfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RAbokgouAJiZok99t77IvB48sf4WX3fJDAvRp5ALggo=; b=nSilKT1uR0b0c3N58F4q+5RtM2q6e/Z7FUuGKyrYjHn5ylEFNJxtl2673QKIf5WFPiA04iyNxKVrs81P4u9NRlVaqzlKRFJgRDgDVGfXc6n9P7uL5cusiJfwRITxO4GM5NfYMCdxAEu/KLtiOoG2fNfKnIVdDEXYb528xK8C3Is= Date: Sat, 6 Mar 2021 10:22:59 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Stefano Stabellini CC: Jan Beulich , , Doug Goldstein , Ian Jackson , Andrew Cooper Subject: Re: [PATCH for-4.15] automation/alpine: add g++ to the list of build depends Message-ID: References: <20210301095806.68518-1-roger.pau@citrix.com> <27ec9db0-69bc-df9a-8511-109f57972046@citrix.com> <77e7004f-8a73-e868-1ccd-318de5886f4a@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0308.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::32) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8910a1bb-fd1f-47aa-ae6b-08d8e0817259 X-MS-TrafficTypeDiagnostic: DM4PR03MB6047: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N7Dgn/BSCMq7SZP9Q357L+e2oJpfCTfNqXxaBgdOJnqSBp2UCLq8JDQkuMZWd1LdOlKMqVEECcpITqDHBaobRn2JUmPhetWLuwfLFpwFbum3aI+gOovviqmig3QlQCrmjfBzEImFcrI6cHLsH1Ff0qrTUmQ5Fj/7nuWeRZDmZsV5gXmBtIbQ+RVKWgO6QbpxTfaHY+q2T6xrkxXUfwJm5Inm+5uxsJo/qatcVm47yQXzIZ5ULJztP2qXwxy6Qoq3v/kyEQGXfuUgVATQFCxllTDvHPB4DIRtG4Kw738AY9pGdjyQfAXeCJnUamTzAVVVSQcjkevn77eHb/MTz3cNe/7DeIrNgtXadMmz04K7lDlIx1dOLiMNvNDGoIrNKmnkV1njKTQ0dbTCzsE/A1BmyaC8KsD940l65K/RtNYc9325PXjQ2XWdqlmWg2P+i/unc7jrfQnPVNer9UJDcS8C2SeKUhsi2tcSrTjAgwil4aHI404jgh4AUmERHP8I3mVofQDBdXQtoyiyXb4mdhuFHEZ54W2xd+87uNZ85qMZyiRmxs7jhMFwcZleU0d6VkdCQeLg02QKczGjllYvGaigjUDUJnprkoaPaAfx63Z8HIWdKqGJ77NL1r1MBxBwk/0y8pp59Mdahtv+dB3r+lt1kQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(39860400002)(396003)(136003)(346002)(366004)(376002)(966005)(33716001)(107886003)(5660300002)(66476007)(66556008)(186003)(956004)(66946007)(8936002)(26005)(53546011)(2906002)(16526019)(8676002)(86362001)(316002)(6666004)(54906003)(9686003)(478600001)(6496006)(85182001)(6486002)(6916009)(4326008)(83380400001)(6606295002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eXVCeHlQYTF5K3pLNVVVeFNsME5SaTlKb2RDVE0vSlpjOFlqNmdxUkxzeU14?= =?utf-8?B?dnA1WTNiOUtXMjJOTUFKeUhCcVkzcXVOOXl1azhlK3VDSWtWRSszUkZHS2hR?= =?utf-8?B?d3FOVmdJTzluSHhWRHVubXpLbXNGRGwzZWVXY2lZNGtybXFKQVRRWGtpdDhC?= =?utf-8?B?MHFlVys4K0JDOHVBSzh3TExFRDVhNVZYVXFVMUtvQWRPZEJWQUxYa3BLc2Jr?= =?utf-8?B?YkNLNktNUFQva25BL3NsZytyR1A2dnRGUXdVUWR4N080ekZnTTVSTVR0S1Zu?= =?utf-8?B?SklPQ3pIc2JYYkJUMkE3NXAya2RJRkVHQVNxbkxEZVY1dTRrc21TaTZZSkZl?= =?utf-8?B?b05CK0x6V1pCNmxXb2txZG1lOVh1QkxjRHZjM2dDdm44bkxrdEF1bmVLdzZV?= =?utf-8?B?SFB2b2tVNWhER3F6WHFYMG8wczYxcFREOUpxUVFkNTNKVU84VXRmNUx5OTE1?= =?utf-8?B?TGdyY0RGTlBVeHdNbmM5aDdvYWFVLzdGZ2pidUFVWkRvTEdJV1h4KzA5TFA3?= =?utf-8?B?VE9SSkFoTGtSbFFQMGJuL1RFTEFjTG4wYWo1ZmZualN1MVRqUmszSnZjSkta?= =?utf-8?B?aDJkOFVvdVBrNTltaE1KU2xKNjdBSVdFUURLekZsOWZrUmpLM243Z1l2eHpK?= =?utf-8?B?NFhsWUlDbHowSkFpakw4blZ3VDBWblpnbXdYRkNxR2wzaWpDbi9LSkhzOWtS?= =?utf-8?B?NHlWQzJjU2lKanVyTk00RlpOcndRMmVqKzIrTXRnay93aERRSGs2MkttSUJR?= =?utf-8?B?VWJOSXphWGFWemZucmdEYkQwTUxaQ3ZsSUxzVnNBOUJNWFF5cU5KY3Z5cHF2?= =?utf-8?B?SEZPQXVpR2kwNTR0clJKUnprTG82Y1RvNGRIY05WZ21hUGdqbEJQcWlHdUpt?= =?utf-8?B?R1RSSy9PNExhemJ1anExaEhaeWk0ZjZkWllSaG5iT3BJYUNiS3dxZEVwQzYz?= =?utf-8?B?ZWhuaUxPQ1MyVWNnS2UrQTI2dUxYYnh6SEdpK2RWV2t1WVUxQ3VMRkYrUDBl?= =?utf-8?B?N01UN3ZiVVFKd2VWdXdkamhubmFsazh4RkFvbzU0WWhIVEtkSGF6VjY1REla?= =?utf-8?B?ZVpwUzdYRVE0aURnTUIzMThMYlRpcktSK2xRUnFvcTUxN1dyUGJwUi9pS08z?= =?utf-8?B?SkZaWUpIRUtQQjRKaTlpeWl5TmEvYURPRTFXOCtuWUp2bjhiR1FEam4vY2JF?= =?utf-8?B?blZnVFNVcUxvYUFuamh1d3REQnNpWi9zYnVYeS9zZ1B5T1lVWWJzODJkSG10?= =?utf-8?B?REVZY2lJd1puNFFyN1ZmMGVLTGVsSExRZHZFNmFtb3E4YXJFYklROW9xYm82?= =?utf-8?B?TGUxVE5OUFNvNzZFclp5ejhIanBaWnlrbkdrYWpDUlRYb3hiTXNUOWtUTkgy?= =?utf-8?B?anpzRDFWcTUydFgwQkkwTTZ5WG4vZmtPNDlaQW9UZFlLSXlycGRKZFFwYUJt?= =?utf-8?B?REpuMHFrQnJmR3VNQjRuY2d3Y1hxd0FydmYzMVhjRmIrdS9WZ1ZKYjBkZlN5?= =?utf-8?B?dzR0YXFRbkszTVV3THZWTzQyTTNZNHFHTEgrQU9Ibi96OUloeFYrcy9jR3cw?= =?utf-8?B?eVBIajBvT2k3RFhXc2pMZExsWUczNDNSRmIrSUlObmdWMVFvN1FDWTZpUnVV?= =?utf-8?B?TGhwUEVVSUFMZEswcjJSSnlEa1ZwUU54dERQVFZTNWhyQlEwa3oyV1BWZWVm?= =?utf-8?B?UWFJcFdvT1lpcXU0amtwZk1Lb0NHdnh1bHBsb3pkQVArd05PWG5qbUN1Tkhu?= =?utf-8?Q?76kON72lutbvKCW8DVfAB7Amv490cA/eLYcs/8q?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8910a1bb-fd1f-47aa-ae6b-08d8e0817259 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2021 09:23:04.8401 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LeNfpSxiumu2FOu7Zx0oH/rfDSblWXkcNApq0uzOPb7yQCt9B0FNk4V9kbxw5WHoQEQZR3ELFx0chwmxt6JWCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6047 X-OriginatorOrg: citrix.com On Fri, Mar 05, 2021 at 05:40:51PM -0800, Stefano Stabellini wrote: > On Tue, 2 Mar 2021, Stefano Stabellini wrote: > > On Tue, 2 Mar 2021, Jan Beulich wrote: > > > On 02.03.2021 10:36, Roger Pau Monné wrote: > > > > On Tue, Mar 02, 2021 at 09:53:41AM +0100, Jan Beulich wrote: > > > >> On 02.03.2021 09:14, Roger Pau Monné wrote: > > > >>> On Mon, Mar 01, 2021 at 06:01:36PM +0000, Andrew Cooper wrote: > > > >>>> On 01/03/2021 17:59, Andrew Cooper wrote: > > > >>>>> On 01/03/2021 09:58, Roger Pau Monne wrote: > > > >>>>>> clang++ relies on the C++ headers installed by g++, or else a clang > > > >>>>>> build will hit the following error: > > > >>>>>> > > > >>>>>> :3:10: fatal error: 'cstring' file not found > > > >>>>>> #include "cstring" > > > >>>>>> ^~~~~~~~~ > > > >>>>>> 1 error generated. > > > >>>>>> make[10]: *** [Makefile:120: headers++.chk] Error 1 > > > >>>>>> > > > >>>>>> Reported-by: Stefano Stabellini > > > >>>>>> Signed-off-by: Roger Pau Monné > > > >>>>>> --- > > > >>>>>> Cc: Ian Jackson > > > >>>>>> No real risk here from a release PoV, it's just pulling a package > > > >>>>>> required for the Alpine clang build. Worse that cold happen is that > > > >>>>>> the Alpine clang build broke, but it's already broken. > > > >>>>> Shouldn't this be fixed upstream in Alpine?  Its clearly a packaging bug. > > > >>>> > > > >>>> Or (thinking about it), we've got a build system bug using g++ when it > > > >>>> should be using clang++. > > > >>> > > > >>> No, the check is using clang++, the issue is that clang++ doesn't > > > >>> install the standard c++ headers, and thus trying to use them (cstring > > > >>> in this case) fails. Installing the g++ package solves the issue > > > >>> because it installs the headers. > > > >> > > > >> I have to admit that I consider this odd. The g++ package should > > > >> neither provide nor depend on the headers. It may recommend their > > > >> installation. On my distro (SLES) the headers come from the > > > >> libstdc++-devel package, as I would have expected. There > > > >> additionally is a dependency of libclang5 (no -devel suffix!) on > > > >> libstdc++-devel (I suppose this is an indication that things > > > >> aren't quite right here either; I haven't checked an up-to-date > > > >> version of the distro yet, though). > > > > > > > > Yes, that was indeed my first attempt as I've tried to install > > > > libstdc++, but there's no -devel counterpart for the package, and it > > > > only installs the libraries but not the headers. > > > > > > > > Then if I list the contents of the g++ package, I do see: > > > > > > > > ... > > > > usr/include/c++/10.2.1/cstring > > > > ... > > > > > > > > And clang++'s include path is: > > > > > > > > #include <...> search starts here: > > > > /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1 > > > > /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1/x86_64-alpine-linux-musl > > > > /usr/bin/../lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../include/c++/10.2.1/backward > > > > /usr/include > > > > /usr/lib/clang/10.0.1/include > > > > > > > > So it does seem clang depends on the gcc c++ headers, I assume this is > > > > done in order to avoid having a duplicate set of c++ headers for clang > > > > and gcc? I really have no idea, but I do think clang package should > > > > depend on g++. > > > > > > As long as the g++ package is what provides the headers (i.e. if that's > > > their concept), I agree. > > > > That makes sense to me too. > > > > Acked-by: Stefano Stabellini > > If nobody speaks up, I'll commit this patch and this patch: > > https://marc.info/?l=xen-devel&m=161433737432684 > > (both of them already acked by Ian and only affecting automation/) > within the next day or two. I've reported the missing c++ headers with clang++ upstream, would you mind adding this link: https://gitlab.alpinelinux.org/alpine/aports/-/issues/12492 To the commit message here? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Sat Mar 06 09:25:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 09:25:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94198.177693 (Exim 4.92) (envelope-from ) id 1lITBP-0005CG-OH; Sat, 06 Mar 2021 09:25:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94198.177693; Sat, 06 Mar 2021 09:25:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lITBP-0005C9-Kl; Sat, 06 Mar 2021 09:25:11 +0000 Received: by outflank-mailman (input) for mailman id 94198; Sat, 06 Mar 2021 09:25:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lITBO-0005C4-D6 for xen-devel@lists.xenproject.org; Sat, 06 Mar 2021 09:25:10 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b9e5029a-7617-45f8-8ae1-84811b23834d; Sat, 06 Mar 2021 09:25:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9e5029a-7617-45f8-8ae1-84811b23834d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615022709; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=8Unpw/YcfVZpRM2zp4qu9cutioGPCHmpH63sKv7fI5U=; b=cXcbuVzR/U0SaTn1FvOWzFIX1cn3ajKDLSrUdOX/7I/HX3Rg+ZTryuoP /WNXwFlY0pYiWNKkpU1P0cDvxpdVxs11oEff0tb9s8u7jzYW6WuwxO56L m+xrpg7c7yw6bDC1effulr0kdv+o563M7t1sJ9xOvyNMsS9Jvi7MN57HY 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: s4q4wmAUkryzz6IvL5ao19LMxCo0q6imb2tSHlp9203EhEdv5+s5GOWSrD4hhiVFCclqI51hlW SkEDIhhJiNZyQisizD0/lvRtmSfNColN3L43vU+0dwGGazGHLLDWVJuoc2ny/aK2Tjy8xmDWO5 o9QLFQUGeOP+Tus9AGwaZUm7cfKhf64MYpB568OidkS8A2FQnuAwvTMFGaH3nR0cmwIHBjLObg lQSJt7N2I8E374GVJ1d8VDt6/KyFOVHwSdxO73mmNycpyWhXfybxg5jw2f4z2kuOi3x6FdpRzz j7c= X-SBRS: 5.2 X-MesageID: 38704442 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,227,1610427600"; d="scan'208";a="38704442" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OGr/8tKDE49qWeKQJoaG/Pehr/CjQ2bf67wsjGR/s+RSrL3mtzylSv1BhAT8kc0qxxS0ARnUqFhX+0/IM2ehVAgpDz/9SWz+4v8VyywSB0Dy8Vfm7q72It6vTU/ngaMGV0zpK1CKrcIHM+qOap6grgkI4u7RS1ZaYkUbOKqc7PTYcRwTTvsDq7JAfUeHY5cwKfQOQ48CJ8jwokDdCMDkVSSEN3GltO5uhydP1bsmQVd9RhnrpOC0M5e3SOlTd1annwFmU5GDN3aKubtosZTMpOaDOmaZm9/GltHE5X1HZFo2/jI2x5uM1SCOumNsBJL7YQRQH0c8Wd9NpHtn6HE48Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IOtbAJrnahx6I+kOFRApaW5B36Z+rn4YKWhh/raHCZE=; b=IVfUjIGXdiUzxl894NISzZ2JLK2KmpU0hQbxaBPLvDGQQI6EXlVaNwvCgJWq5PC5FF0IGICbAzFchOJQlvhVQrlVy43xvz4dtc0dKY6svx4/xZtEimSAK9+rtD8MWQPRkH+SaW0SVzjmO/8ZOGK4PtrwCuv25X4+5veOTPV+dorjPQ2J1ZlQAkgvNQMNGXEHq/shr21mbBoxg5EACUvjnoNAd7LzNtPPetp+FKCab3iqKT58Gq0ZyUMdwjhd233graiq8cb3nnEhmyfN39wD7/7FDqa5aYnKdFLgwWKSZCSSE4ByyCxnBtn1nlyp5gDH+EJvH+AmHbHj56VSVdSh4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IOtbAJrnahx6I+kOFRApaW5B36Z+rn4YKWhh/raHCZE=; b=C79t+cvA285kyJ3HsKoIFDBE6mSKPV5dJDNfI/ag2r7bkCD3fPFYWPT3DEDg05VcWWgr4XZlYR02+OeMltd/CfUshYQ2uGe7kFH1+uuJJyofACuYWe1JCFvGwtZpk3IdqwGjS+qLzrdt/SDuLrqe/lCl7eDEnDvwm2/Q12IPLcc= Date: Sat, 6 Mar 2021 10:24:19 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Xen-devel , Doug Goldstein , Ian Jackson , Stefano Stabellini Subject: Re: [PATCH for-4.15] automation: Fix the Alpine clang builds to use clang Message-ID: References: <20210226110233.27991-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210226110233.27991-1-andrew.cooper3@citrix.com> X-ClientProxiedBy: AS8PR04CA0225.eurprd04.prod.outlook.com (2603:10a6:20b:2f2::20) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 26c43a8c-c56d-4f9b-3e23-08d8e081a227 X-MS-TrafficTypeDiagnostic: DM6PR03MB3738: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:234; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +IgeYkCBOzAMOL7F04jbKghd1ekHbuqK18aCh/UatUV0HcnTZnQzLyN+cw8k0jKQm3ygPZufex4y241MbG75IaEVcB4/TAiUlzNc/nmfq0vhUDDAlLQ2HLfQ3SptmXHedT8m3N1euKFFe4tqRJ25nzUDmX1gYDM39sD2IUCnCwye1SAKB2FlNB605WBCvnSYJ/HfL4qfFFqMc16t/3m3p+Cghx3yrgsQ9IpueMoP3B8bAFjjN+turUJvdUz7NgXDyhWQjoOnF9z3QYRXBYRMhHpIjQqU/YlXLlsix9C8p0JpvA3JusnpOVkzQ1zi4MvGCAWArJxlr0TuH4E0GeeeVW39CfHUBS3sQMuJPggZZA7vdZX4m2bfk1vrlOATmtI28WjzAcFg6h2W/NYMs17759zjhByfkgwV/d7GmSF4xA8lPPih1RlZ1HQjsPbIvRRJn/2MB3R/kUM/MI+BAySuaEFWpoF2SVMRZD2NhBf0z6SRovEeY7WxwyAUwIzziK7tj/lVHEf7HTU3Swsn7OhBvw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(396003)(39860400002)(136003)(376002)(346002)(366004)(33716001)(186003)(2906002)(26005)(9686003)(8676002)(316002)(54906003)(558084003)(16526019)(5660300002)(956004)(66556008)(86362001)(6862004)(66476007)(6636002)(66946007)(6486002)(6666004)(4326008)(85182001)(6496006)(8936002)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dy9xcmgyQ294QVZmWWFQekIvUDFWZ25sSng5V3QyZTFSUjlGVTF1clRuZFZY?= =?utf-8?B?dkoyYkdzaDBaRGNCTldyU1JTK3dybFdVWTA4cFJhcXJxQ0FlUnZHS2h0STlq?= =?utf-8?B?aGR3cFoybHB4KzJWNEFtVE4rWkxWZXRHejJaTC9ua2VzN0haMFZUbzl1S1Rk?= =?utf-8?B?RExHQ2M0bC9PbXlJWU1oMzNsdFlWc1NKUlNGa0YrNEthVGowOWZQNS9DMFAy?= =?utf-8?B?Q2lxMmxvUFU3ZFdLMlN0QkN2NXBPUDIyY2FXV2xCK3ZsNFlaTlRVZlRQQUZp?= =?utf-8?B?cFdqOUZVa0RpZWcyWCs1TEtVWmVxdjU0OTVLVXcvQUUzbHk2L0dmUU1zekVP?= =?utf-8?B?VjBubWFXQ3Z2b3RqQjBDM3R0T0o1d2JJci9LR3BQZmM4dmVtOHM0Sm5jeDVC?= =?utf-8?B?bFkxWm1Na1VHaCttRm5xUFBXZ29DZ2IyZ0tySWNSZmdiYU5UL0loalF5bWhx?= =?utf-8?B?V2xid3ZVUHpua0lIR2lIMjE4Um02VFlZcFFsRkdTMUh3WHNqOW5qZ3EvY3ow?= =?utf-8?B?SGxrSGZkVzNtL2RBQ05GMVhjTjhRcko2R0Jxb1crNGlibzJTMWxOL3VVNmFW?= =?utf-8?B?RlFBbzZzUDV4YUw4U0loNk5aT0RvMjZnYjJ6ZmlmT2trWTJTbUd1SGhwQUtx?= =?utf-8?B?VDVrYjY1eERCRkZKUlh2TmJwSzlIOXF6T0c5TDVXQUIvTlZvZGx5d1BZTlRR?= =?utf-8?B?Mmd1S0ZWNllpalpkc1JlbmVuQUtlLzZuaUpYWWh6NFBoQ3BvWkdTSFBMOVpn?= =?utf-8?B?UTBiWmFhb1BUdG1YYXZ4R3h5akdNRU9TU1JhWDh3dlp4WDZCTHN6TjNVVmZF?= =?utf-8?B?UkJER3JYeDRJUnNVM2ovdy9EMitvK0JaUWcybk10TVRkZnNrUHR2eWh3cEdj?= =?utf-8?B?YnlyRk82YXNCS0FPSERUSndRckFNNkNpQzUvZERhb0FUMy94UVRHTHZSUzl3?= =?utf-8?B?R0dKZzJvS2hlODYvUTJJSzJXMWFLL2UwVlFFUGx1UE1HbGIzQVpzT1pnWlh4?= =?utf-8?B?MTBrMzU4cUpDb243a0pYNW14OXIwbWg4V21kR2dQVGd1T3pKdEltbnRrOUcz?= =?utf-8?B?Wm9mSzlmWTZlSjh1NG5QZTFDa1pjNDRGS0VmVnJJS1ZJYldTaFljQ2FwaTdr?= =?utf-8?B?T3NwUkFFSmpjcXNDcjNMd1JkM1NMbEJybXhhSjhWdmxCSGEzUGhpWU9rWmxm?= =?utf-8?B?SEZ3MDNzUUJEUG1Td0ZMdi9LT0xvQXFuU0J4NlhyOUF5RmJZa1V6L0dodlVJ?= =?utf-8?B?MFJsU0J5Zit1TTZEMWFSQVZOeG1aeGNTOEpPZENBRmxGeVJPc3RuYlYrZ08r?= =?utf-8?B?K1ZiUjU0eG5rOWFtMTRKOERoMVE3dWEwZ2xlWklVRnBCSFZTMXFkWUFNVlZQ?= =?utf-8?B?bHdJUVRRb20wMlgrd3JFdGZNRldWaWRDOGdVcWEydnErcUR6YnBSSVpaSFpj?= =?utf-8?B?cTBCMlNVVVRtRGpQNElsN3hBdUJwc3BmN3ZweEFLekM0SlZCU2lRUDh2emtO?= =?utf-8?B?SDRwRXh2dk8vR1d3OFhqZUpNNmNRaVBnTzJZZzVYdGZUdjE4Vmh1K1FlbThO?= =?utf-8?B?UWVJMDJhdnExbk05aFl6aWJzeGZYd201WWRvaEVjTWRHVk56VWx5UnNMYVBX?= =?utf-8?B?VVNDNHpOOG9lMU9Bbm9OU1ZSbmkxa0RqOXEvWWR6TEFodnJjaFU4WVlvTTVp?= =?utf-8?B?emNzaFRha1pVT2IxRHprdWFETVFBc3Izc3h4THFYM2FMekd4VFlZaXliYVoz?= =?utf-8?Q?VNFO3ZJBnm4VCxTQZvp7mh5kgLgVzjUvYEhTxod?= X-MS-Exchange-CrossTenant-Network-Message-Id: 26c43a8c-c56d-4f9b-3e23-08d8e081a227 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2021 09:24:25.0392 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tI4SFPeStks8l0FKdUSIBLormo83yk/ZvvHqjgGXO/wikc/kd59L0/Jm3mL77tSC7ACVfsE6ZXTOVwwYKaaqKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3738 X-OriginatorOrg: citrix.com On Fri, Feb 26, 2021 at 11:02:33AM +0000, Andrew Cooper wrote: > Looks like a copy&paste error. > > Fixes: f6e1d8515d7 ("automation: add alpine linux x86 build jobs") > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Sat Mar 06 10:31:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 10:31:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94220.177705 (Exim 4.92) (envelope-from ) id 1lIUCe-0003VP-Qz; Sat, 06 Mar 2021 10:30:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94220.177705; Sat, 06 Mar 2021 10:30:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIUCe-0003VI-Np; Sat, 06 Mar 2021 10:30:32 +0000 Received: by outflank-mailman (input) for mailman id 94220; Sat, 06 Mar 2021 10:30:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIUCc-0003VA-PF; Sat, 06 Mar 2021 10:30:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIUCc-0006aK-IZ; Sat, 06 Mar 2021 10:30:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIUCc-0002Un-6q; Sat, 06 Mar 2021 10:30:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIUCc-0001hg-66; Sat, 06 Mar 2021 10:30:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=K+uS5+ud8n/ynfwcLCN51VLfw5Ib1n7Ttf4J0rgoMdc=; b=ceUfBaNNUZnlwoopW1E7xIHbPB uE6fruaolGJ/ENSV2vQOfkYNaHeN01jdMAR3uhHLmWetUHhiDulCszliLOk24J1xIt5H/dsFI2EZB fcToVusUOsW+Sc6vJE27v3TPvJC5F7fN1BGMAGsDVP5DCM5qoFooEIY2cnUvGX7odMgU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.13-testing test] 159839: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.13-testing:test-amd64-amd64-i386-pvgrub:guest-saverestore.2:fail:heisenbug xen-4.13-testing:test-amd64-i386-qemuu-rhel6hvm-amd:redhat-install:fail:heisenbug xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=24b181e4e4c6c6fe28217c845d6d753da1606aeb X-Osstest-Versions-That: xen=d7a1e06efd3ae2b16d5bb335932376b7d7eaf633 From: osstest service owner Date: Sat, 06 Mar 2021 10:30:30 +0000 flight 159839 xen-4.13-testing real [real] flight 159846 xen-4.13-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159839/ http://logs.test-lab.xenproject.org/osstest/logs/159846/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-i386-pvgrub 18 guest-saverestore.2 fail pass in 159846-retest test-amd64-i386-qemuu-rhel6hvm-amd 12 redhat-install fail pass in 159846-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159448 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159448 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159448 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159448 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159448 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159448 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159448 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159448 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159448 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159448 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159448 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 24b181e4e4c6c6fe28217c845d6d753da1606aeb baseline version: xen d7a1e06efd3ae2b16d5bb335932376b7d7eaf633 Last test of basis 159448 2021-02-17 18:03:21 Z 16 days Testing same since 159839 2021-03-05 15:07:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Dario Faggioli Jan Beulich Jason Andryuk Juergen Gross Julien Grall Roger Pau Monné Stefano Stabellini Tamas K Lengyel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git d7a1e06efd..24b181e4e4 24b181e4e4c6c6fe28217c845d6d753da1606aeb -> stable-4.13 From xen-devel-bounces@lists.xenproject.org Sat Mar 06 15:39:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 15:39:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94300.177788 (Exim 4.92) (envelope-from ) id 1lIZ1J-0006Ij-Tz; Sat, 06 Mar 2021 15:39:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94300.177788; Sat, 06 Mar 2021 15:39:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIZ1J-0006Ic-Pf; Sat, 06 Mar 2021 15:39:09 +0000 Received: by outflank-mailman (input) for mailman id 94300; Sat, 06 Mar 2021 15:39:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIZ1I-0006IU-DT; Sat, 06 Mar 2021 15:39:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIZ1I-0003JN-3Q; Sat, 06 Mar 2021 15:39:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIZ1H-0008Fe-Qy; Sat, 06 Mar 2021 15:39:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIZ1H-0007K9-QS; Sat, 06 Mar 2021 15:39:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JHeFbG94hkmly3UZBiHB5xM3cTMocy5EGbvn0R9oYHY=; b=cnsz/kp/7ncJnK9bUaZgy2/7p+ DgzU+2VxpgzhrdN9ccXyVz8nZjOSrx9NFhsOfaXz2OwiYe2kRz/7Ycxyd+VyyhdRPeN9/oq7YPpzX 2V2MemTMmznwAAmIBVZENVfErBnAvtxSEtcMnlf1Dx8W74Dl6SEH2azPtr13cx+W4aAk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159842: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-credit1:guest-start.2:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=9a7beaad3dbba982f7a461d676b55a5c3851d312 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sat, 06 Mar 2021 15:39:07 +0000 flight 159842 qemu-mainline real [real] flight 159847 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159842/ http://logs.test-lab.xenproject.org/osstest/logs/159847/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 8 xen-boot fail pass in 159847-retest test-amd64-amd64-xl-credit1 23 guest-start.2 fail pass in 159847-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 159847 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 159847 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 9a7beaad3dbba982f7a461d676b55a5c3851d312 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 198 days Failing since 152659 2020-08-21 14:07:39 Z 197 days 379 attempts Testing same since 159842 2021-03-05 17:39:35 Z 0 days 1 attempts ------------------------------------------------------------ 435 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 119419 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 06 16:18:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 16:18:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94311.177803 (Exim 4.92) (envelope-from ) id 1lIZdN-00028H-Uv; Sat, 06 Mar 2021 16:18:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94311.177803; Sat, 06 Mar 2021 16:18:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIZdN-00028A-RK; Sat, 06 Mar 2021 16:18:29 +0000 Received: by outflank-mailman (input) for mailman id 94311; Sat, 06 Mar 2021 16:18:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIZdM-000285-6e for xen-devel@lists.xenproject.org; Sat, 06 Mar 2021 16:18:28 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 43495617-6245-49a2-9c48-a163c2a7a1b3; Sat, 06 Mar 2021 16:18:26 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0F0B2ACBF; Sat, 6 Mar 2021 16:18:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43495617-6245-49a2-9c48-a163c2a7a1b3 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615047506; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nukSOwxYWB0nbFvij2/Dm4omz/vg/Y2S787KBEpkjPQ=; b=ikq+lyIUCyWydGZBrbc/5vetOXvA7c9Q6hQJW0KBEmRC9tFWwX0wFFanEWxAZbeoDsxu74 J7hdq2bBlhniAgRF14O9XCLXvRIk9ujSdaYEc1+JSKoGpc1pQ4YIfgug7gB2edU3FkEwzy nsuGkx/XECs/lscQfYjAWefZvBz6Qe0= Subject: Re: [PATCH v3 2/8] xen/events: don't unmask an event channel when an eoi is pending To: Ross Lagerwall , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Boris Ostrovsky , Stefano Stabellini , stable@vger.kernel.org, Julien Grall References: <20210219154030.10892-1-jgross@suse.com> <20210219154030.10892-3-jgross@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <134540c1-40ac-3607-6ca0-3dcd5f83a013@suse.com> Date: Sat, 6 Mar 2021 17:18:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kTuR8myBCAf9zSbzIMWx6GIuaVMSZMcto" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kTuR8myBCAf9zSbzIMWx6GIuaVMSZMcto Content-Type: multipart/mixed; boundary="tI9qAvQfSWeoIIbUUygUcu92S5FGuW44I"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Ross Lagerwall , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Boris Ostrovsky , Stefano Stabellini , stable@vger.kernel.org, Julien Grall Message-ID: <134540c1-40ac-3607-6ca0-3dcd5f83a013@suse.com> Subject: Re: [PATCH v3 2/8] xen/events: don't unmask an event channel when an eoi is pending References: <20210219154030.10892-1-jgross@suse.com> <20210219154030.10892-3-jgross@suse.com> In-Reply-To: --tI9qAvQfSWeoIIbUUygUcu92S5FGuW44I Content-Type: multipart/mixed; boundary="------------93BA1965D22E272FDC5B4750" Content-Language: en-US This is a multi-part message in MIME format. --------------93BA1965D22E272FDC5B4750 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 23.02.21 10:26, Ross Lagerwall wrote: > On 2021-02-19 15:40, Juergen Gross wrote: >> An event channel should be kept masked when an eoi is pending for it. >> When being migrated to another cpu it might be unmasked, though. >> >> In order to avoid this keep three different flags for each event chann= el >> to be able to distinguish "normal" masking/unmasking from eoi related >> masking/unmasking and temporary masking. The event channel should only= >> be able to generate an interrupt if all flags are cleared. >> >> Cc: stable@vger.kernel.org >> Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn fra= mework") >> Reported-by: Julien Grall >> Signed-off-by: Juergen Gross >=20 > I tested this patch series backported to a 4.19 kernel and found that > when doing a reboot loop of Windows with PV drivers, occasionally it wi= ll > end up in a state with some event channels pending and masked in dom0 > which breaks networking in the guest. >=20 > The issue seems to have been introduced with this patch, though at firs= t > glance it appears correct. I haven't yet looked into why it is happenin= g. > Have you seen anything like this with this patch? I have found the issue. lateeoi_mask_ack_dynirq() must not set the "eoi" mask reason flag, as this callback will be called when the handler will not be called later, so there will never be a call of xen_irq_lateeoi() to unmask the event channel again. Juergen --------------93BA1965D22E272FDC5B4750 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------93BA1965D22E272FDC5B4750-- --tI9qAvQfSWeoIIbUUygUcu92S5FGuW44I-- --kTuR8myBCAf9zSbzIMWx6GIuaVMSZMcto Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBDq1EFAwAAAAAACgkQsN6d1ii/Ey8J 7Qf+NHVK97kON4roGF5RJItEisdxbr0ccBbz9u1cZr1HZERP3O8P79ah2OdFk0Xw2sgEp3Hgfvce /rmWAZIt0bfRZua04Z4q2jzoahX1bROTAqZ68/m9Dj3esK/st6gp+SKt7SwWlCDvv3JT7Zm8UR9U FGGf+ar0Sr6E01dC+KaOf7pUuZiGCbor60s4Ko9hZDvW3cGp2ofwaKX4IfVTCUmnHRX5ZGGSr6R7 ZoCa1Mo1kS78RhVQ5zlGrS3HVR2p1+9xZwCcXdpO5py9iFI/5pwkBdZty7hFEolV5vnPyF8kLt8Q RbU2euBuFCYwCyQgv6zKRBtzoqZYZiCMcVcJH1a4cA== =2K6b -----END PGP SIGNATURE----- --kTuR8myBCAf9zSbzIMWx6GIuaVMSZMcto-- From xen-devel-bounces@lists.xenproject.org Sat Mar 06 16:18:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 16:18:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94312.177815 (Exim 4.92) (envelope-from ) id 1lIZdW-0002AU-6Q; Sat, 06 Mar 2021 16:18:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94312.177815; Sat, 06 Mar 2021 16:18:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIZdW-0002AM-3T; Sat, 06 Mar 2021 16:18:38 +0000 Received: by outflank-mailman (input) for mailman id 94312; Sat, 06 Mar 2021 16:18:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIZdV-0002A8-4Z for xen-devel@lists.xenproject.org; Sat, 06 Mar 2021 16:18:37 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 502256a5-b19b-421c-9ea6-c2ff01401d2c; Sat, 06 Mar 2021 16:18:36 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 894A6ACBF; Sat, 6 Mar 2021 16:18:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 502256a5-b19b-421c-9ea6-c2ff01401d2c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615047515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8J1qAdHunz+tmbQ9/r5zGTbgmDsvG9L+i6KEmaXahyU=; b=GbHI37Qp2DIWCj2DDCYa8vhoXGGZy59OCOoz24/s+MnE62esSHkcr80s9p6Cyt1yw6+uWJ Hy7jV1MpQww0MrpBWSNmxhvJ84UTYK9D2cdLc9uP1Z2hnokvYBtB72NGy0ZOglaGl47lHi vO4oNHGV2YZsIAPwuQnpBTR9ldXAJWc= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , stable@vger.kernel.org Subject: [PATCH v4 0/3] xen/events: bug fixes and some diagnostic aids Date: Sat, 6 Mar 2021 17:18:30 +0100 Message-Id: <20210306161833.4552-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Those are fixes for XSA-332. The rest of the V3 patches have been applied already. There is one additional fix in patch 2 which addresses network outages when a guest is doing reboot loops. Juergen Gross (3): xen/events: reset affinity of 2-level event when tearing it down xen/events: don't unmask an event channel when an eoi is pending xen/events: avoid handling the same event on two cpus at the same time drivers/xen/events/events_2l.c | 22 +++-- drivers/xen/events/events_base.c | 130 ++++++++++++++++++++------- drivers/xen/events/events_fifo.c | 7 -- drivers/xen/events/events_internal.h | 14 +-- 4 files changed, 123 insertions(+), 50 deletions(-) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Sat Mar 06 16:18:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 16:18:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94313.177827 (Exim 4.92) (envelope-from ) id 1lIZdX-0002CW-JY; Sat, 06 Mar 2021 16:18:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94313.177827; Sat, 06 Mar 2021 16:18:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIZdX-0002CP-Fv; Sat, 06 Mar 2021 16:18:39 +0000 Received: by outflank-mailman (input) for mailman id 94313; Sat, 06 Mar 2021 16:18:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIZdW-0002AY-8W for xen-devel@lists.xenproject.org; Sat, 06 Mar 2021 16:18:38 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bbb3be79-3cfa-4512-9c61-43b89fee4dcd; Sat, 06 Mar 2021 16:18:36 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 145CAAD21; Sat, 6 Mar 2021 16:18:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbb3be79-3cfa-4512-9c61-43b89fee4dcd X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615047516; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ItonbQ6nCPS7Ck5aiQWROygJkg9zRoVzDQtkeXBTtM=; b=JhoxF/rLRC/zhQd/M2ReBsjMPiviL+iHuN29hmSxhE0B1CUwZAKjKJkmDUPqKujfXLAe7N d2cUZ2P3gSf3h6YpLMaCnlwxPBZmnNlHQbTQiOmE+vG2picUlslwGjePGYejzswWnohDS3 xhPiD2RK+Hc6oMqbvpjG0IngwUoJVrk= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , stable@vger.kernel.org, Julien Grall , Julien Grall Subject: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending Date: Sat, 6 Mar 2021 17:18:32 +0100 Message-Id: <20210306161833.4552-3-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210306161833.4552-1-jgross@suse.com> References: <20210306161833.4552-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit An event channel should be kept masked when an eoi is pending for it. When being migrated to another cpu it might be unmasked, though. In order to avoid this keep three different flags for each event channel to be able to distinguish "normal" masking/unmasking from eoi related masking/unmasking and temporary masking. The event channel should only be able to generate an interrupt if all flags are cleared. Cc: stable@vger.kernel.org Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn framework") Reported-by: Julien Grall Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- V2: - introduce a lock around masking/unmasking - merge patch 3 into this one (Jan Beulich) V4: - don't set eoi masking flag in lateeoi_mask_ack_dynirq() --- drivers/xen/events/events_2l.c | 7 -- drivers/xen/events/events_base.c | 101 +++++++++++++++++++++------ drivers/xen/events/events_fifo.c | 7 -- drivers/xen/events/events_internal.h | 6 -- 4 files changed, 80 insertions(+), 41 deletions(-) diff --git a/drivers/xen/events/events_2l.c b/drivers/xen/events/events_2l.c index a7f413c5c190..b8f2f971c2f0 100644 --- a/drivers/xen/events/events_2l.c +++ b/drivers/xen/events/events_2l.c @@ -77,12 +77,6 @@ static bool evtchn_2l_is_pending(evtchn_port_t port) return sync_test_bit(port, BM(&s->evtchn_pending[0])); } -static bool evtchn_2l_test_and_set_mask(evtchn_port_t port) -{ - struct shared_info *s = HYPERVISOR_shared_info; - return sync_test_and_set_bit(port, BM(&s->evtchn_mask[0])); -} - static void evtchn_2l_mask(evtchn_port_t port) { struct shared_info *s = HYPERVISOR_shared_info; @@ -376,7 +370,6 @@ static const struct evtchn_ops evtchn_ops_2l = { .clear_pending = evtchn_2l_clear_pending, .set_pending = evtchn_2l_set_pending, .is_pending = evtchn_2l_is_pending, - .test_and_set_mask = evtchn_2l_test_and_set_mask, .mask = evtchn_2l_mask, .unmask = evtchn_2l_unmask, .handle_events = evtchn_2l_handle_events, diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index 7e23808892a7..b27c012c86b5 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -98,13 +98,18 @@ struct irq_info { short refcnt; u8 spurious_cnt; u8 is_accounted; - enum xen_irq_type type; /* type */ + short type; /* type: IRQT_* */ + u8 mask_reason; /* Why is event channel masked */ +#define EVT_MASK_REASON_EXPLICIT 0x01 +#define EVT_MASK_REASON_TEMPORARY 0x02 +#define EVT_MASK_REASON_EOI_PENDING 0x04 unsigned irq; evtchn_port_t evtchn; /* event channel */ unsigned short cpu; /* cpu bound */ unsigned short eoi_cpu; /* EOI must happen on this cpu-1 */ unsigned int irq_epoch; /* If eoi_cpu valid: irq_epoch of event */ u64 eoi_time; /* Time in jiffies when to EOI. */ + spinlock_t lock; union { unsigned short virq; @@ -154,6 +159,7 @@ static DEFINE_RWLOCK(evtchn_rwlock); * evtchn_rwlock * IRQ-desc lock * percpu eoi_list_lock + * irq_info->lock */ static LIST_HEAD(xen_irq_list_head); @@ -304,6 +310,8 @@ static int xen_irq_info_common_setup(struct irq_info *info, info->irq = irq; info->evtchn = evtchn; info->cpu = cpu; + info->mask_reason = EVT_MASK_REASON_EXPLICIT; + spin_lock_init(&info->lock); ret = set_evtchn_to_irq(evtchn, irq); if (ret < 0) @@ -459,6 +467,34 @@ unsigned int cpu_from_evtchn(evtchn_port_t evtchn) return ret; } +static void do_mask(struct irq_info *info, u8 reason) +{ + unsigned long flags; + + spin_lock_irqsave(&info->lock, flags); + + if (!info->mask_reason) + mask_evtchn(info->evtchn); + + info->mask_reason |= reason; + + spin_unlock_irqrestore(&info->lock, flags); +} + +static void do_unmask(struct irq_info *info, u8 reason) +{ + unsigned long flags; + + spin_lock_irqsave(&info->lock, flags); + + info->mask_reason &= ~reason; + + if (!info->mask_reason) + unmask_evtchn(info->evtchn); + + spin_unlock_irqrestore(&info->lock, flags); +} + #ifdef CONFIG_X86 static bool pirq_check_eoi_map(unsigned irq) { @@ -605,7 +641,7 @@ static void xen_irq_lateeoi_locked(struct irq_info *info, bool spurious) } info->eoi_time = 0; - unmask_evtchn(evtchn); + do_unmask(info, EVT_MASK_REASON_EOI_PENDING); } static void xen_irq_lateeoi_worker(struct work_struct *work) @@ -850,7 +886,8 @@ static unsigned int __startup_pirq(unsigned int irq) goto err; out: - unmask_evtchn(evtchn); + do_unmask(info, EVT_MASK_REASON_EXPLICIT); + eoi_pirq(irq_get_irq_data(irq)); return 0; @@ -877,7 +914,7 @@ static void shutdown_pirq(struct irq_data *data) if (!VALID_EVTCHN(evtchn)) return; - mask_evtchn(evtchn); + do_mask(info, EVT_MASK_REASON_EXPLICIT); xen_evtchn_close(evtchn); xen_irq_info_cleanup(info); } @@ -1721,10 +1758,10 @@ void rebind_evtchn_irq(evtchn_port_t evtchn, int irq) } /* Rebind an evtchn so that it gets delivered to a specific cpu */ -static int xen_rebind_evtchn_to_cpu(evtchn_port_t evtchn, unsigned int tcpu) +static int xen_rebind_evtchn_to_cpu(struct irq_info *info, unsigned int tcpu) { struct evtchn_bind_vcpu bind_vcpu; - int masked; + evtchn_port_t evtchn = info ? info->evtchn : 0; if (!VALID_EVTCHN(evtchn)) return -1; @@ -1740,7 +1777,7 @@ static int xen_rebind_evtchn_to_cpu(evtchn_port_t evtchn, unsigned int tcpu) * Mask the event while changing the VCPU binding to prevent * it being delivered on an unexpected VCPU. */ - masked = test_and_set_mask(evtchn); + do_mask(info, EVT_MASK_REASON_TEMPORARY); /* * If this fails, it usually just indicates that we're dealing with a @@ -1750,8 +1787,7 @@ static int xen_rebind_evtchn_to_cpu(evtchn_port_t evtchn, unsigned int tcpu) if (HYPERVISOR_event_channel_op(EVTCHNOP_bind_vcpu, &bind_vcpu) >= 0) bind_evtchn_to_cpu(evtchn, tcpu, false); - if (!masked) - unmask_evtchn(evtchn); + do_unmask(info, EVT_MASK_REASON_TEMPORARY); return 0; } @@ -1790,7 +1826,7 @@ static int set_affinity_irq(struct irq_data *data, const struct cpumask *dest, unsigned int tcpu = select_target_cpu(dest); int ret; - ret = xen_rebind_evtchn_to_cpu(evtchn_from_irq(data->irq), tcpu); + ret = xen_rebind_evtchn_to_cpu(info_for_irq(data->irq), tcpu); if (!ret) irq_data_update_effective_affinity(data, cpumask_of(tcpu)); @@ -1799,18 +1835,20 @@ static int set_affinity_irq(struct irq_data *data, const struct cpumask *dest, static void enable_dynirq(struct irq_data *data) { - evtchn_port_t evtchn = evtchn_from_irq(data->irq); + struct irq_info *info = info_for_irq(data->irq); + evtchn_port_t evtchn = info ? info->evtchn : 0; if (VALID_EVTCHN(evtchn)) - unmask_evtchn(evtchn); + do_unmask(info, EVT_MASK_REASON_EXPLICIT); } static void disable_dynirq(struct irq_data *data) { - evtchn_port_t evtchn = evtchn_from_irq(data->irq); + struct irq_info *info = info_for_irq(data->irq); + evtchn_port_t evtchn = info ? info->evtchn : 0; if (VALID_EVTCHN(evtchn)) - mask_evtchn(evtchn); + do_mask(info, EVT_MASK_REASON_EXPLICIT); } static void ack_dynirq(struct irq_data *data) @@ -1829,18 +1867,39 @@ static void mask_ack_dynirq(struct irq_data *data) ack_dynirq(data); } +static void lateeoi_ack_dynirq(struct irq_data *data) +{ + struct irq_info *info = info_for_irq(data->irq); + evtchn_port_t evtchn = info ? info->evtchn : 0; + + if (VALID_EVTCHN(evtchn)) { + do_mask(info, EVT_MASK_REASON_EOI_PENDING); + clear_evtchn(evtchn); + } +} + +static void lateeoi_mask_ack_dynirq(struct irq_data *data) +{ + struct irq_info *info = info_for_irq(data->irq); + evtchn_port_t evtchn = info ? info->evtchn : 0; + + if (VALID_EVTCHN(evtchn)) { + do_mask(info, EVT_MASK_REASON_EXPLICIT); + clear_evtchn(evtchn); + } +} + static int retrigger_dynirq(struct irq_data *data) { - evtchn_port_t evtchn = evtchn_from_irq(data->irq); - int masked; + struct irq_info *info = info_for_irq(data->irq); + evtchn_port_t evtchn = info ? info->evtchn : 0; if (!VALID_EVTCHN(evtchn)) return 0; - masked = test_and_set_mask(evtchn); + do_mask(info, EVT_MASK_REASON_TEMPORARY); set_evtchn(evtchn); - if (!masked) - unmask_evtchn(evtchn); + do_unmask(info, EVT_MASK_REASON_TEMPORARY); return 1; } @@ -2054,8 +2113,8 @@ static struct irq_chip xen_lateeoi_chip __read_mostly = { .irq_mask = disable_dynirq, .irq_unmask = enable_dynirq, - .irq_ack = mask_ack_dynirq, - .irq_mask_ack = mask_ack_dynirq, + .irq_ack = lateeoi_ack_dynirq, + .irq_mask_ack = lateeoi_mask_ack_dynirq, .irq_set_affinity = set_affinity_irq, .irq_retrigger = retrigger_dynirq, diff --git a/drivers/xen/events/events_fifo.c b/drivers/xen/events/events_fifo.c index b234f1766810..ad9fe51d3fb3 100644 --- a/drivers/xen/events/events_fifo.c +++ b/drivers/xen/events/events_fifo.c @@ -209,12 +209,6 @@ static bool evtchn_fifo_is_pending(evtchn_port_t port) return sync_test_bit(EVTCHN_FIFO_BIT(PENDING, word), BM(word)); } -static bool evtchn_fifo_test_and_set_mask(evtchn_port_t port) -{ - event_word_t *word = event_word_from_port(port); - return sync_test_and_set_bit(EVTCHN_FIFO_BIT(MASKED, word), BM(word)); -} - static void evtchn_fifo_mask(evtchn_port_t port) { event_word_t *word = event_word_from_port(port); @@ -423,7 +417,6 @@ static const struct evtchn_ops evtchn_ops_fifo = { .clear_pending = evtchn_fifo_clear_pending, .set_pending = evtchn_fifo_set_pending, .is_pending = evtchn_fifo_is_pending, - .test_and_set_mask = evtchn_fifo_test_and_set_mask, .mask = evtchn_fifo_mask, .unmask = evtchn_fifo_unmask, .handle_events = evtchn_fifo_handle_events, diff --git a/drivers/xen/events/events_internal.h b/drivers/xen/events/events_internal.h index 18a4090d0709..4d3398eff9cd 100644 --- a/drivers/xen/events/events_internal.h +++ b/drivers/xen/events/events_internal.h @@ -21,7 +21,6 @@ struct evtchn_ops { void (*clear_pending)(evtchn_port_t port); void (*set_pending)(evtchn_port_t port); bool (*is_pending)(evtchn_port_t port); - bool (*test_and_set_mask)(evtchn_port_t port); void (*mask)(evtchn_port_t port); void (*unmask)(evtchn_port_t port); @@ -84,11 +83,6 @@ static inline bool test_evtchn(evtchn_port_t port) return evtchn_ops->is_pending(port); } -static inline bool test_and_set_mask(evtchn_port_t port) -{ - return evtchn_ops->test_and_set_mask(port); -} - static inline void mask_evtchn(evtchn_port_t port) { return evtchn_ops->mask(port); -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Sat Mar 06 16:18:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 16:18:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94314.177831 (Exim 4.92) (envelope-from ) id 1lIZdY-0002DQ-0u; Sat, 06 Mar 2021 16:18:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94314.177831; Sat, 06 Mar 2021 16:18:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIZdX-0002DD-RP; Sat, 06 Mar 2021 16:18:39 +0000 Received: by outflank-mailman (input) for mailman id 94314; Sat, 06 Mar 2021 16:18:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIZdW-0002AY-In for xen-devel@lists.xenproject.org; Sat, 06 Mar 2021 16:18:38 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9708d123-c9e6-4ce1-9229-fd83698f65c4; Sat, 06 Mar 2021 16:18:37 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 52614AE42; Sat, 6 Mar 2021 16:18:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9708d123-c9e6-4ce1-9229-fd83698f65c4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615047516; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J1kkgZZ52SPUCRXNyaZp2NxzcRXpEMVhj1MhJQhXSVY=; b=eUJK6LvAllQib5KkEmsQJMqpnbV00DWaGbWm4CS75zGLQXL86fhU6QvTpJoDchHwyluuC9 OYGfkOUxSQjjrAg3v08NMYLziJqNf+pbfQE3GPjFmY6CndKsmXb0GTTD86C9HyY1HW05f/ WjFvxiJwdk4H5lzw/uyuH3SRaM61ewQ= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , stable@vger.kernel.org, Julien Grall , Julien Grall Subject: [PATCH v4 3/3] xen/events: avoid handling the same event on two cpus at the same time Date: Sat, 6 Mar 2021 17:18:33 +0100 Message-Id: <20210306161833.4552-4-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210306161833.4552-1-jgross@suse.com> References: <20210306161833.4552-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When changing the cpu affinity of an event it can happen today that (with some unlucky timing) the same event will be handled on the old and the new cpu at the same time. Avoid that by adding an "event active" flag to the per-event data and call the handler only if this flag isn't set. Cc: stable@vger.kernel.org Reported-by: Julien Grall Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- V2: - new patch V3: - use common helper for end of handler action (Julien Grall) - move setting is_active to 0 for lateeoi (Boris Ostrovsky) --- drivers/xen/events/events_base.c | 32 +++++++++++++++++++++----------- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index b27c012c86b5..8236e2364eeb 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -103,6 +103,7 @@ struct irq_info { #define EVT_MASK_REASON_EXPLICIT 0x01 #define EVT_MASK_REASON_TEMPORARY 0x02 #define EVT_MASK_REASON_EOI_PENDING 0x04 + u8 is_active; /* Is event just being handled? */ unsigned irq; evtchn_port_t evtchn; /* event channel */ unsigned short cpu; /* cpu bound */ @@ -810,6 +811,12 @@ static void xen_evtchn_close(evtchn_port_t port) BUG(); } +static void event_handler_exit(struct irq_info *info) +{ + smp_store_release(&info->is_active, 0); + clear_evtchn(info->evtchn); +} + static void pirq_query_unmask(int irq) { struct physdev_irq_status_query irq_status; @@ -828,14 +835,15 @@ static void pirq_query_unmask(int irq) static void eoi_pirq(struct irq_data *data) { - evtchn_port_t evtchn = evtchn_from_irq(data->irq); + struct irq_info *info = info_for_irq(data->irq); + evtchn_port_t evtchn = info ? info->evtchn : 0; struct physdev_eoi eoi = { .irq = pirq_from_irq(data->irq) }; int rc = 0; if (!VALID_EVTCHN(evtchn)) return; - clear_evtchn(evtchn); + event_handler_exit(info); if (pirq_needs_eoi(data->irq)) { rc = HYPERVISOR_physdev_op(PHYSDEVOP_eoi, &eoi); @@ -1666,6 +1674,8 @@ void handle_irq_for_port(evtchn_port_t port, struct evtchn_loop_ctrl *ctrl) } info = info_for_irq(irq); + if (xchg_acquire(&info->is_active, 1)) + return; dev = (info->type == IRQT_EVTCHN) ? info->u.interdomain : NULL; if (dev) @@ -1853,12 +1863,11 @@ static void disable_dynirq(struct irq_data *data) static void ack_dynirq(struct irq_data *data) { - evtchn_port_t evtchn = evtchn_from_irq(data->irq); - - if (!VALID_EVTCHN(evtchn)) - return; + struct irq_info *info = info_for_irq(data->irq); + evtchn_port_t evtchn = info ? info->evtchn : 0; - clear_evtchn(evtchn); + if (VALID_EVTCHN(evtchn)) + event_handler_exit(info); } static void mask_ack_dynirq(struct irq_data *data) @@ -1874,7 +1883,7 @@ static void lateeoi_ack_dynirq(struct irq_data *data) if (VALID_EVTCHN(evtchn)) { do_mask(info, EVT_MASK_REASON_EOI_PENDING); - clear_evtchn(evtchn); + event_handler_exit(info); } } @@ -1885,7 +1894,7 @@ static void lateeoi_mask_ack_dynirq(struct irq_data *data) if (VALID_EVTCHN(evtchn)) { do_mask(info, EVT_MASK_REASON_EXPLICIT); - clear_evtchn(evtchn); + event_handler_exit(info); } } @@ -1998,10 +2007,11 @@ static void restore_cpu_ipis(unsigned int cpu) /* Clear an irq's pending state, in preparation for polling on it */ void xen_clear_irq_pending(int irq) { - evtchn_port_t evtchn = evtchn_from_irq(irq); + struct irq_info *info = info_for_irq(irq); + evtchn_port_t evtchn = info ? info->evtchn : 0; if (VALID_EVTCHN(evtchn)) - clear_evtchn(evtchn); + event_handler_exit(info); } EXPORT_SYMBOL(xen_clear_irq_pending); void xen_set_irq_pending(int irq) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Sat Mar 06 16:18:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 16:18:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94315.177851 (Exim 4.92) (envelope-from ) id 1lIZdb-0002I7-Bv; Sat, 06 Mar 2021 16:18:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94315.177851; Sat, 06 Mar 2021 16:18:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIZdb-0002Hv-7c; Sat, 06 Mar 2021 16:18:43 +0000 Received: by outflank-mailman (input) for mailman id 94315; Sat, 06 Mar 2021 16:18:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIZdZ-0002A8-WB for xen-devel@lists.xenproject.org; Sat, 06 Mar 2021 16:18:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id faed39b0-5a59-463d-8294-1d3cdb4e1e46; Sat, 06 Mar 2021 16:18:36 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CAE97ACC6; Sat, 6 Mar 2021 16:18:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: faed39b0-5a59-463d-8294-1d3cdb4e1e46 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615047515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CzB0BFIPrmEbErFdpKHp0c0umgSWDwXyfGSsUiACoW8=; b=pQY1xvSueF7SP3KX315+Ya0QAfly5J0uzzdgoWRUwbzjbIcBCbV7niSNt1s0Jpdyv7cFkg /PulzPGmhZIvN6TVySTSn7gNN0AcTk+qGjmfq7gJ+wlMBaWlO5FJXEwNo8zwh6SUAl36fx o6XNnr4ZvY1lELnXlSVtcbKAZBa03jM= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , stable@vger.kernel.org, Julien Grall , Julien Grall Subject: [PATCH v4 1/3] xen/events: reset affinity of 2-level event when tearing it down Date: Sat, 6 Mar 2021 17:18:31 +0100 Message-Id: <20210306161833.4552-2-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210306161833.4552-1-jgross@suse.com> References: <20210306161833.4552-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When creating a new event channel with 2-level events the affinity needs to be reset initially in order to avoid using an old affinity from earlier usage of the event channel port. So when tearing an event channel down reset all affinity bits. The same applies to the affinity when onlining a vcpu: all old affinity settings for this vcpu must be reset. As percpu events get initialized before the percpu event channel hook is called, resetting of the affinities happens after offlining a vcpu (this is working, as initial percpu memory is zeroed out). Cc: stable@vger.kernel.org Reported-by: Julien Grall Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- V2: - reset affinity when tearing down the event (Julien Grall) --- drivers/xen/events/events_2l.c | 15 +++++++++++++++ drivers/xen/events/events_base.c | 1 + drivers/xen/events/events_internal.h | 8 ++++++++ 3 files changed, 24 insertions(+) diff --git a/drivers/xen/events/events_2l.c b/drivers/xen/events/events_2l.c index da87f3a1e351..a7f413c5c190 100644 --- a/drivers/xen/events/events_2l.c +++ b/drivers/xen/events/events_2l.c @@ -47,6 +47,11 @@ static unsigned evtchn_2l_max_channels(void) return EVTCHN_2L_NR_CHANNELS; } +static void evtchn_2l_remove(evtchn_port_t evtchn, unsigned int cpu) +{ + clear_bit(evtchn, BM(per_cpu(cpu_evtchn_mask, cpu))); +} + static void evtchn_2l_bind_to_cpu(evtchn_port_t evtchn, unsigned int cpu, unsigned int old_cpu) { @@ -355,9 +360,18 @@ static void evtchn_2l_resume(void) EVTCHN_2L_NR_CHANNELS/BITS_PER_EVTCHN_WORD); } +static int evtchn_2l_percpu_deinit(unsigned int cpu) +{ + memset(per_cpu(cpu_evtchn_mask, cpu), 0, sizeof(xen_ulong_t) * + EVTCHN_2L_NR_CHANNELS/BITS_PER_EVTCHN_WORD); + + return 0; +} + static const struct evtchn_ops evtchn_ops_2l = { .max_channels = evtchn_2l_max_channels, .nr_channels = evtchn_2l_max_channels, + .remove = evtchn_2l_remove, .bind_to_cpu = evtchn_2l_bind_to_cpu, .clear_pending = evtchn_2l_clear_pending, .set_pending = evtchn_2l_set_pending, @@ -367,6 +381,7 @@ static const struct evtchn_ops evtchn_ops_2l = { .unmask = evtchn_2l_unmask, .handle_events = evtchn_2l_handle_events, .resume = evtchn_2l_resume, + .percpu_deinit = evtchn_2l_percpu_deinit, }; void __init xen_evtchn_2l_init(void) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index adb7260e94b2..7e23808892a7 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -377,6 +377,7 @@ static int xen_irq_info_pirq_setup(unsigned irq, static void xen_irq_info_cleanup(struct irq_info *info) { set_evtchn_to_irq(info->evtchn, -1); + xen_evtchn_port_remove(info->evtchn, info->cpu); info->evtchn = 0; channels_on_cpu_dec(info); } diff --git a/drivers/xen/events/events_internal.h b/drivers/xen/events/events_internal.h index 0a97c0549db7..18a4090d0709 100644 --- a/drivers/xen/events/events_internal.h +++ b/drivers/xen/events/events_internal.h @@ -14,6 +14,7 @@ struct evtchn_ops { unsigned (*nr_channels)(void); int (*setup)(evtchn_port_t port); + void (*remove)(evtchn_port_t port, unsigned int cpu); void (*bind_to_cpu)(evtchn_port_t evtchn, unsigned int cpu, unsigned int old_cpu); @@ -54,6 +55,13 @@ static inline int xen_evtchn_port_setup(evtchn_port_t evtchn) return 0; } +static inline void xen_evtchn_port_remove(evtchn_port_t evtchn, + unsigned int cpu) +{ + if (evtchn_ops->remove) + evtchn_ops->remove(evtchn, cpu); +} + static inline void xen_evtchn_port_bind_to_cpu(evtchn_port_t evtchn, unsigned int cpu, unsigned int old_cpu) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Sat Mar 06 18:09:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 18:09:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94333.177862 (Exim 4.92) (envelope-from ) id 1lIbM6-0004CL-Gd; Sat, 06 Mar 2021 18:08:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94333.177862; Sat, 06 Mar 2021 18:08:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIbM6-0004CE-DX; Sat, 06 Mar 2021 18:08:46 +0000 Received: by outflank-mailman (input) for mailman id 94333; Sat, 06 Mar 2021 18:08:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIbM4-0004C6-Lx; Sat, 06 Mar 2021 18:08:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIbM4-0006Ip-Fe; Sat, 06 Mar 2021 18:08:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIbM4-0000lz-40; Sat, 06 Mar 2021 18:08:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIbM4-00018h-3W; Sat, 06 Mar 2021 18:08:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6UX3h10meAsFah3DfzZz3xxzbdAfGRWdg1kFdlNTBM0=; b=LENj3bU926hRwf8F5sH6D+CvQI BaVguIM4mQRv3a4HTF5F5tVmHO/UAXe1qfzGf6cEST+F5uWH8WuNZMyNPkQxp7bu32KCoGTBOd37/ taFce4d9x8ba8mq28RiotVi5ld+0FAyvsMgjL4Tqs0WhSyl09FXkXrXzRfAGwmYvJTGY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 159845: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=d5b2644815f12c3ef2dc0d31d32a0c30092a8853 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 06 Mar 2021 18:08:44 +0000 flight 159845 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/159845/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt d5b2644815f12c3ef2dc0d31d32a0c30092a8853 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 239 days Failing since 151818 2020-07-11 04:18:52 Z 238 days 231 attempts Testing same since 159845 2021-03-06 04:20:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 46031 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 06 18:11:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 18:11:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94355.177878 (Exim 4.92) (envelope-from ) id 1lIbP1-0005Aa-2q; Sat, 06 Mar 2021 18:11:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94355.177878; Sat, 06 Mar 2021 18:11:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIbP0-0005AT-W2; Sat, 06 Mar 2021 18:11:46 +0000 Received: by outflank-mailman (input) for mailman id 94355; Sat, 06 Mar 2021 18:11:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIbOz-0005AL-F2; Sat, 06 Mar 2021 18:11:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIbOz-0006LF-Bi; Sat, 06 Mar 2021 18:11:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIbOz-00010N-0m; Sat, 06 Mar 2021 18:11:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIbOz-0004ee-0F; Sat, 06 Mar 2021 18:11:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rRESyCK8mp/sx/FAp04ZhhNsPrAzrZ6sj2ydUQPtcog=; b=IlvEW1IR+4nljcencNuxxf/3No yJPvzG3545+wC6H+5HGn22YWRsSuNUK8znZtHh3S9Z3ahxGUWL1cFdfMAi5JyOMKshXhNj2P6+z/w YKGa/KNcqE8d5y9DGZdABmPr6SynuEn0GGcImrEuHv0YWAkhTa/sYEq3uasILGCdrrQg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159843: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=280d542f6ffac0e6d65dc267f92191d509b13b64 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sat, 06 Mar 2021 18:11:45 +0000 flight 159843 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159843/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux 280d542f6ffac0e6d65dc267f92191d509b13b64 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 217 days Failing since 152366 2020-08-01 20:49:34 Z 216 days 375 attempts Testing same since 159835 2021-03-05 09:06:41 Z 1 days 2 attempts ------------------------------------------------------------ 5144 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1273214 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 06 19:38:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 19:38:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94364.177893 (Exim 4.92) (envelope-from ) id 1lIckJ-000468-7F; Sat, 06 Mar 2021 19:37:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94364.177893; Sat, 06 Mar 2021 19:37:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIckJ-000461-49; Sat, 06 Mar 2021 19:37:51 +0000 Received: by outflank-mailman (input) for mailman id 94364; Sat, 06 Mar 2021 19:37:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIckH-00045t-Dw for xen-devel@lists.xenproject.org; Sat, 06 Mar 2021 19:37:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIckF-0007iD-Vr; Sat, 06 Mar 2021 19:37:47 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lIckF-0006Dg-MF; Sat, 06 Mar 2021 19:37:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=94O42RF8ZcOdd/rNkYU0e81C4ESfkvMGzVmyp8tD9Pg=; b=bzkVvrmr3Kr09oJ68vE6QlMDvX zX6BdGzFXhi7KuOEmPIG9ILucAOuoqHHMLM+xD2i82bkFCrl5kOwcWBF4PCQ+hrwRockBzKn3BeTd 8Fj+EHZiStNzwy3lpLnn4s33HmpxADpKawFz0D8lKgvJb4dLJtqp2ocSpsuR62iQwvXc=; Subject: Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() To: Ian Jackson Cc: Jan Beulich , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , raphning@amazon.co.uk, Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-3-julien@xen.org> <0994b7a0-c537-b312-b134-caf54c79c87f@suse.com> <74568cd7-143b-48ad-b9be-bf4229655376@suse.com> <7eb12174-3268-ccdb-df9c-c4fe23d3a332@xen.org> <24642.14600.124181.19574@mariner.uk.xensource.com> From: Julien Grall Message-ID: <0249af89-ced0-0f7f-d370-9ffade6b1678@xen.org> Date: Sat, 6 Mar 2021 19:37:45 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24642.14600.124181.19574@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Ian, On 05/03/2021 13:58, Ian Jackson wrote: > Julien Grall writes ("Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}()"): >> Urgh, you are right. Actually, the extern was added recently by Anthony: >> >> dacdbf7088d6a3705a9831e73991c2b14c519a65 ("tools/xenstore: mark variable >> in header as extern") >> >> I completely forgot it despite I needed to backport the patch to our >> downstream Xen. > > How horrible. > > Maybe we could add a comment to the code, next to the declaration, > about this crazy situation. Would the following comment work for you? /* Function pointer as xprintf() can be configured at runtime. */ I can fold it in my patch while committing. Cheers, > > Ian. > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Mar 06 19:39:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 19:39:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94368.177905 (Exim 4.92) (envelope-from ) id 1lIcmD-0004IE-KL; Sat, 06 Mar 2021 19:39:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94368.177905; Sat, 06 Mar 2021 19:39:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIcmD-0004I7-Gn; Sat, 06 Mar 2021 19:39:49 +0000 Received: by outflank-mailman (input) for mailman id 94368; Sat, 06 Mar 2021 19:39:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIcmC-0004I1-IP for xen-devel@lists.xenproject.org; Sat, 06 Mar 2021 19:39:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIcmA-0007jm-Gp; Sat, 06 Mar 2021 19:39:46 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lIcmA-0006Jz-BN; Sat, 06 Mar 2021 19:39:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=T+9QkXahvt+dwgRHDqLExvoouQ4Qh58rNwQps892uOE=; b=olu0NiEW0gOmM+hdcTeqJTigAI Pd30u/hZfQ1+vqMLUqWV81x2PvVaEuoluh+ELHYdrwfn0AUe9EbiY5F7JDzj1CY3zFrm+bcMW6zca kcHSkWUVl3QxPZufuEt9TkJ/p/jRNLSAX19yM2YAEVuyOhDKCkw23bfLx+jxJGXpxsFk=; Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters To: Ian Jackson Cc: xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall , Juergen Gross References: <20210305121029.7047-1-julien@xen.org> <24642.12417.651929.972294@mariner.uk.xensource.com> From: Julien Grall Message-ID: <2e55f754-7d42-34d2-fc4a-f8415436149e@xen.org> Date: Sat, 6 Mar 2021 19:39:44 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24642.12417.651929.972294@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Ian, On 05/03/2021 13:22, Ian Jackson wrote: > Release-Acked-by: Ian Jackson I have committed the patch. Thanks! Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Mar 06 19:52:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 19:52:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94374.177921 (Exim 4.92) (envelope-from ) id 1lIcyE-00063O-Oo; Sat, 06 Mar 2021 19:52:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94374.177921; Sat, 06 Mar 2021 19:52:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIcyE-00063H-Lk; Sat, 06 Mar 2021 19:52:14 +0000 Received: by outflank-mailman (input) for mailman id 94374; Sat, 06 Mar 2021 19:52:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIcyD-00063C-72 for xen-devel@lists.xenproject.org; Sat, 06 Mar 2021 19:52:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIcyA-0007wv-IY; Sat, 06 Mar 2021 19:52:10 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lIcyA-00073S-7Q; Sat, 06 Mar 2021 19:52:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=ek6GxqEhnufZUAI0eViLtNegYXP4e2JeQmjzhDOrxVI=; b=dX3X+qI7Y9aE6Zuu6SdMelb7mu OUiAcAYuI28ASWPc3iG0FTHVvWzTSO3pCVif5bqdX/doLsb0jpf2W24HAViyA0MnrDQqVPEX4Zdqp JSiekSr2F99IjNIgN17BSmOWxlGLCCEFVtyeWnEcxCHMd1d1tVA13/VB5sjsXfQ/P7Dc=; Subject: Re: [PATCH V4 24/24] [RFC] libxl: Add support for virtio-disk configuration To: Oleksandr Cc: xen-devel@lists.xenproject.org, Oleksandr Tyshchenko , Ian Jackson , Wei Liu , Anthony PERARD , Stefano Stabellini References: <1610488352-18494-1-git-send-email-olekstysh@gmail.com> <1610488352-18494-25-git-send-email-olekstysh@gmail.com> <87f92e40-6462-21ba-0c56-b77c6518fef8@gmail.com> <57272148-ff37-1e5e-1b83-b56304431bc9@gmail.com> From: Julien Grall Message-ID: <86564c3a-2320-138a-574d-067e9b6ab417@xen.org> Date: Sat, 6 Mar 2021 19:52:08 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <57272148-ff37-1e5e-1b83-b56304431bc9@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Oleksandr, On 10/02/2021 09:02, Oleksandr wrote: > > On 20.01.21 19:05, Julien Grall wrote: > Thinking a bit more what approach to choose... > I would tend to automatically allocate the virtio IRQ (4th option) > rather than use static approach with reserved IRQs > in order to eliminate the chance of a clash with a physical IRQs > completely from the very beginning. From other side > we can indeed use static approach (as simpler one) for now and then > refine it when we have more understanding about the virtio usage. > What do you think? The static approach should be fine for now. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Mar 06 20:04:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 20:04:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94379.177933 (Exim 4.92) (envelope-from ) id 1lId9Z-00079t-Ui; Sat, 06 Mar 2021 20:03:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94379.177933; Sat, 06 Mar 2021 20:03:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lId9Z-00079m-Rg; Sat, 06 Mar 2021 20:03:57 +0000 Received: by outflank-mailman (input) for mailman id 94379; Sat, 06 Mar 2021 20:03:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lId9Y-00079h-1U for xen-devel@lists.xenproject.org; Sat, 06 Mar 2021 20:03:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lId9X-0008Eq-2d; Sat, 06 Mar 2021 20:03:55 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lId9W-0007sB-NU; Sat, 06 Mar 2021 20:03:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Syn83vuW1WGUDekL3bFYX9LzT5XraSaDjKXparENo7Y=; b=WWj1SPxgDf24mYrpa0BlnDjfjZ jZ3VJlZPcTRVe4e890GSrirPZlLlgPkfsg/I16VXp0tPDmmjkljJx/8aGbzsD1PBc6Wru9CrjapyM eYQisHFptwcqhPeOqOKKHI8wZD9HwKWSmBxJ21ycccQIA51SQSe5heae2uz/xdCD8PgA=; Subject: Re: [PATCH DO NOT APPLY] docs: Document allocator properties and the rubric for using them To: George Dunlap Cc: "open list:X86" , Andrew Cooper , Jan Beulich , Roger Pau Monne , Stefano Stabellini References: <20210216102839.1801667-1-george.dunlap@citrix.com> From: Julien Grall Message-ID: <9d63df30-6de7-4ea8-1e38-d70318b4b7bb@xen.org> Date: Sat, 6 Mar 2021 20:03:53 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi George, On 16/02/2021 11:17, George Dunlap wrote: > > >> On Feb 16, 2021, at 11:16 AM, George Dunlap wrote: >> >> >> >>> On Feb 16, 2021, at 10:55 AM, Julien Grall wrote: >>> >>> Hi George, >>> >>> On 16/02/2021 10:28, George Dunlap wrote: >>>> Document the properties of the various allocators and lay out a clear >>>> rubric for when to use each. >>>> Signed-off-by: George Dunlap >>>> --- >>>> This doc is my understanding of the properties of the current >>>> allocators (alloc_xenheap_pages, xmalloc, and vmalloc), and of Jan's >>>> proposed new wrapper, xvmalloc. >>>> xmalloc, vmalloc, and xvmalloc were designed more or less to mirror >>>> similar functions in Linux (kmalloc, vmalloc, and kvmalloc >>>> respectively). >>>> CC: Andrew Cooper >>>> CC: Jan Beulich >>>> CC: Roger Pau Monne >>>> CC: Stefano Stabellini >>>> CC: Julien Grall >>>> --- >>>> .../memory-allocation-functions.rst | 118 ++++++++++++++++++ >>>> 1 file changed, 118 insertions(+) >>>> create mode 100644 docs/hypervisor-guide/memory-allocation-functions.rst >>>> diff --git a/docs/hypervisor-guide/memory-allocation-functions.rst b/docs/hypervisor-guide/memory-allocation-functions.rst >>>> new file mode 100644 >>>> index 0000000000..15aa2a1a65 >>>> --- /dev/null >>>> +++ b/docs/hypervisor-guide/memory-allocation-functions.rst >>>> @@ -0,0 +1,118 @@ >>>> +.. SPDX-License-Identifier: CC-BY-4.0 >>>> + >>>> +Xenheap memory allocation functions >>>> +=================================== >>>> + >>>> +In general Xen contains two pools (or "heaps") of memory: the *xen >>>> +heap* and the *dom heap*. Please see the comment at the top of >>>> +``xen/common/page_alloc.c`` for the canonical explanation. >>>> + >>>> +This document describes the various functions available to allocate >>>> +memory from the xen heap: their properties and rules for when they should be >>>> +used. >>>> + >>>> + >>>> +TLDR guidelines >>>> +--------------- >>>> + >>>> +* By default, ``xvmalloc`` (or its helper cognates) should be used >>>> + unless you know you have specific properties that need to be met. >>>> + >>>> +* If you need memory which needs to be physically contiguous, and may >>>> + be larger than ``PAGE_SIZE``... >>>> + >>>> + - ...and is order 2, use ``alloc_xenheap_pages``. >>>> + >>>> + - ...and is not order 2, use ``xmalloc`` (or its helper cognates).. >>>> + >>>> +* If you don't need memory to be physically contiguous, and know the >>>> + allocation will always be larger than ``PAGE_SIZE``, you may use >>>> + ``vmalloc`` (or one of its helper cognates). >>>> + >>>> +* If you know that allocation will always be less than ``PAGE_SIZE``, >>>> + you may use ``xmalloc``. >>> >>> AFAICT, the determining factor is PAGE_SIZE. This is a single is a single value on x86 (e.g. 4KB) but on other architecture this may be multiple values. >>> >>> For instance, on Arm, this could be 4KB, 16KB, 64KB (note that only the former is so far supported on Xen). >>> >>> For Arm and common code, it feels to me we can't make a clear decision based on PAGE_SIZE. Instead, I continue to think that the decision should only be based on physical vs virtually contiguous. >>> >>> We can then add further rules for x86 specific code if the maintainers want. >> >> Sorry my second mail was somewhat delayed — my intent was: 1) post the document I’d agreed to write, 2) say why I think the proposal is a bad idea. :-) No worry, I jumped too quickly in the discussion :). >> >> Re page size — the vast majority of time we’re talking “knowing” that the size is less than 4k. If we’re confident that no architecture will ever have a page size less than 4k, then we know that all allocations less than 4k will always be less than PAGE_SIZE. Obviously larger page sizes then becomes an issue. >> >> But in any case — unless we have BUG_ON(size > PAGE_SIZE), we’re going to have to have a fallback, which is going to cost one precious conditional, making the whole exercise pointless. > > Er, just in case it wasn’t clear — I agree with this: > >>> I continue to think that the decision should only be based on physical vs virtually contiguous. We have two opposite proposal with no clear way to reconciliate them. Should we request a vote on the two proposals? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Mar 06 21:42:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 21:42:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94384.177945 (Exim 4.92) (envelope-from ) id 1lIegW-0007n5-Co; Sat, 06 Mar 2021 21:42:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94384.177945; Sat, 06 Mar 2021 21:42:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIegW-0007my-8j; Sat, 06 Mar 2021 21:42:04 +0000 Received: by outflank-mailman (input) for mailman id 94384; Sat, 06 Mar 2021 21:42:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIegV-0007mt-0y for xen-devel@lists.xenproject.org; Sat, 06 Mar 2021 21:42:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIegT-0001PC-Hl; Sat, 06 Mar 2021 21:42:01 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIegT-00066t-11; Sat, 06 Mar 2021 21:42:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=VU75K8jemcqWW+CW4IZ/uc+bhcZ1ef0hQsKo4FgR/38=; b=HyLA+aZFi+QgIcIUfhDI7p1/M1 01Qpw5jwR3QF7RNAZCLjtOL/M5z/cSq/d31TBtIRKW+fSeN4PYBLfb8b0qnkM16nKuu4TU178BMWr 0Dlc9vBfsNDPwWoSnVA1Qj8q0zH0NGqM7TnLtCc05FyigOY1jACxb3wRRCgtkJG6+mCk=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Subject: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) Date: Sat, 6 Mar 2021 21:41:48 +0000 Message-Id: <20210306214148.27021-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall Compilers older than 4.8 have known codegen issues which can lead to silent miscompilation: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 Furthermore, pre-4.9 GCC have known bugs (including things like internal compiler errors on Arm) which would require workaround (I haven't checked if we have any in Xen). The minimum version of GCC to build the hypervisor is now raised to 4.9. In addition to that, on arm64, GCC version >= 4.9 and < 5.1 have been shown to emit memory references beyond the stack pointer, resulting in memory corruption if an interrupt is taken after the stack pointer has been adjusted but before the reference has been executed. Therefore, the minimum for arm64 is raised to 5.1. Signed-off-by: Julien Grall --- I don't have a strong opinion on the minimum version for GCC on x86. So this is following Andrew's suggestion and the minimum from Linux. This patch is candidate to 4.15 and backport. This is only a build change and will be low-risk for anyone using newer compiler (5.1+ for arm64 and 4.9 for everyone else). Xen will stop building for anyone using older compiler. But it is better than fighting with codegen issues. --- README | 9 ++++++--- xen/include/xen/compiler.h | 13 +++++++++++++ 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/README b/README index 8c99c30986c1..5c32c03f2ea1 100644 --- a/README +++ b/README @@ -38,12 +38,15 @@ provided by your OS distributor: * GNU Make v3.80 or later * C compiler and linker: - For x86: - - GCC 4.1.2_20070115 or later + - GCC 4.9 or later - GNU Binutils 2.16.91.0.5 or later or - Clang/LLVM 3.5 or later - - For ARM: - - GCC 4.8 or later + - For ARM 32-bit: + - GCC 4.9 or later + - GNU Binutils 2.24 or later + - For ARM 64-bit: + - GCC 5.1 or later - GNU Binutils 2.24 or later * Development install of zlib (e.g., zlib-dev) * Development install of Python 2.6 or later (e.g., python-dev) diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h index 0ec0b4698ea7..46779660cc8f 100644 --- a/xen/include/xen/compiler.h +++ b/xen/include/xen/compiler.h @@ -5,6 +5,19 @@ #error Sorry, your compiler is too old/not recognized. #endif +#if CONFIG_CC_IS_GCC +# if CONFIG_GCC_VERSION < 40900 +/* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ +# error Sorry, your version of GCC is too old - please use 4.9 or newer. +# elif defined(CONFIG_ARM_64) && CONFIG_GCC_VERSION < 50100 +/* + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk + */ +# error Sorry, your version of GCC is too old - please use 5.1 or newer. +# endif +#endif + #define barrier() __asm__ __volatile__("": : :"memory") #define likely(x) __builtin_expect(!!(x),1) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Mar 06 22:30:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 22:30:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94387.177957 (Exim 4.92) (envelope-from ) id 1lIfRN-0003vO-6F; Sat, 06 Mar 2021 22:30:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94387.177957; Sat, 06 Mar 2021 22:30:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIfRN-0003vH-1J; Sat, 06 Mar 2021 22:30:29 +0000 Received: by outflank-mailman (input) for mailman id 94387; Sat, 06 Mar 2021 22:30:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIfRM-0003v9-Dw; Sat, 06 Mar 2021 22:30:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIfRM-0002AK-4s; Sat, 06 Mar 2021 22:30:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIfRL-00050a-Nn; Sat, 06 Mar 2021 22:30:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIfRL-0003KB-NJ; Sat, 06 Mar 2021 22:30:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YGCtJ1ra0WyiCOWjAi7L/lhd+fUKcSq6qYVdI60A4EI=; b=vVhLp90PiP0vcl89wa7KzxGceI tDu0HSRQ8vBgV2GCxkj3g33oRZkCd1GtbG4EvL7ZOkOwrt5c6a/OF0ewhBHcBUSJwSlejLJeFuoqp XaagOeNgDPM2dyAkH1QJeO37z0/+5o4HgG6RdE/ptF7UJJ+yVOX3/QGdDK8nzDmxVbfY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159850: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=51972482f77b68ef494c8b9591b125460e7984b9 X-Osstest-Versions-That: xen=9318fdf757ec234f0ee6c5cd381326b2f581d065 From: osstest service owner Date: Sat, 06 Mar 2021 22:30:27 +0000 flight 159850 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159850/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 51972482f77b68ef494c8b9591b125460e7984b9 baseline version: xen 9318fdf757ec234f0ee6c5cd381326b2f581d065 Last test of basis 159837 2021-03-05 13:01:32 Z 1 days Testing same since 159850 2021-03-06 20:01:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9318fdf757..51972482f7 51972482f77b68ef494c8b9591b125460e7984b9 -> smoke From xen-devel-bounces@lists.xenproject.org Sat Mar 06 23:31:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 06 Mar 2021 23:31:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94393.177972 (Exim 4.92) (envelope-from ) id 1lIgOX-00012u-FH; Sat, 06 Mar 2021 23:31:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94393.177972; Sat, 06 Mar 2021 23:31:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIgOX-00012n-BV; Sat, 06 Mar 2021 23:31:37 +0000 Received: by outflank-mailman (input) for mailman id 94393; Sat, 06 Mar 2021 23:31:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIgOW-00012f-1W; Sat, 06 Mar 2021 23:31:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIgOV-00037d-Nt; Sat, 06 Mar 2021 23:31:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIgOV-0007cK-Bb; Sat, 06 Mar 2021 23:31:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIgOV-0006m2-BA; Sat, 06 Mar 2021 23:31:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UR9CI7W0tZp9VF1XMxFd//RO0M9lvirCmwL/+z/iL9I=; b=m8IbeUcv7ZRn4KDVsE0WA/hbR4 brpWN7oRI1yE1dqOtRS2DCvQ2OLbqEIvgo+WvNAtLt4RgGDjkczf0+CcdsGSpFUKADFE1TBx7SBor ySUyXMYst7iwVaa0xGNz5ZCYN15/+b6yhdMYFY0XsJ8lfSEre4I2GAcpQraxNeoF0n2I=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159844: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9318fdf757ec234f0ee6c5cd381326b2f581d065 X-Osstest-Versions-That: xen=f40e1c52e4e0a3e084b025ed6b68f1e6ebaea027 From: osstest service owner Date: Sat, 06 Mar 2021 23:31:35 +0000 flight 159844 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/159844/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159838 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159838 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159838 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159838 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159838 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159838 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159838 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159838 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159838 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159838 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159838 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 9318fdf757ec234f0ee6c5cd381326b2f581d065 baseline version: xen f40e1c52e4e0a3e084b025ed6b68f1e6ebaea027 Last test of basis 159838 2021-03-05 14:04:34 Z 1 days Testing same since 159844 2021-03-06 01:08:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Tim Deegan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f40e1c52e4..9318fdf757 9318fdf757ec234f0ee6c5cd381326b2f581d065 -> master From xen-devel-bounces@lists.xenproject.org Sun Mar 07 04:01:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 Mar 2021 04:01:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94422.177991 (Exim 4.92) (envelope-from ) id 1lIkb5-000339-OW; Sun, 07 Mar 2021 04:00:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94422.177991; Sun, 07 Mar 2021 04:00:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIkb5-000330-GM; Sun, 07 Mar 2021 04:00:51 +0000 Received: by outflank-mailman (input) for mailman id 94422; Sun, 07 Mar 2021 04:00:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIkb4-00032s-Kn; Sun, 07 Mar 2021 04:00:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIkb4-0001ey-Cn; Sun, 07 Mar 2021 04:00:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIkb3-00031R-Sx; Sun, 07 Mar 2021 04:00:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIkb3-0002Hf-PQ; Sun, 07 Mar 2021 04:00:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=j+WaeF77DN2vFAUwAldleym83Y59jaxbwHU/UFOmT+U=; b=KNz7zLVcwpXXk0/OTyLP2dKDlC S53Y0KvF0eJebW0IYAm6RaCSkQQzLpOu3YylIkIRcUAPWvpU6t4UJ340zqAM7ZfIKOpHLZIrVcFVM LEvMylohYQUx6yBg2xSEHcIT4Vs/QgzCLVwYxGky3kmJUDMUX+gdyovyKc03xwiPtxOg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159848: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=91e92cad67caca3bc4b8e920ddb5c8ca64aac9e1 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sun, 07 Mar 2021 04:00:49 +0000 flight 159848 qemu-mainline real [real] flight 159852 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159848/ http://logs.test-lab.xenproject.org/osstest/logs/159852/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 91e92cad67caca3bc4b8e920ddb5c8ca64aac9e1 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 198 days Failing since 152659 2020-08-21 14:07:39 Z 197 days 380 attempts Testing same since 159848 2021-03-06 15:41:19 Z 0 days 1 attempts ------------------------------------------------------------ 435 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 119704 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 07 05:40:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 Mar 2021 05:40:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94428.178005 (Exim 4.92) (envelope-from ) id 1lIm9T-0004Ni-PP; Sun, 07 Mar 2021 05:40:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94428.178005; Sun, 07 Mar 2021 05:40:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIm9T-0004Nb-MK; Sun, 07 Mar 2021 05:40:27 +0000 Received: by outflank-mailman (input) for mailman id 94428; Sun, 07 Mar 2021 05:40:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIm9S-0004NT-Ap; Sun, 07 Mar 2021 05:40:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIm9S-0003qM-2H; Sun, 07 Mar 2021 05:40:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIm9R-0007ay-Hp; Sun, 07 Mar 2021 05:40:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIm9R-0007hQ-GT; Sun, 07 Mar 2021 05:40:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pRnBfLllWTEcPTy4vmB9KtV8Yl2vU0OmcTnjVSeaJJs=; b=MH6lSccoAynXwayXopQrpa3QX+ X5CUZLwDTTGOYkYgAuRuqZK82scl/WhL7Z7YgRQkqbtdsRAwVnHFwHn8RM2Urt1WK6/RyubOK78RL zmsbVEAt9lEiNEAEEVJcg9xK+pgChpbeGW7wPM4XZgH9aa4J3lIG7v8SBmaOxrz1Yptk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159849: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-localmigrate/x10:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a38fd8748464831584a19438cbb3082b5a2dab15 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sun, 07 Mar 2021 05:40:25 +0000 flight 159849 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159849/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 19 guest-localmigrate/x10 fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux a38fd8748464831584a19438cbb3082b5a2dab15 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 218 days Failing since 152366 2020-08-01 20:49:34 Z 217 days 376 attempts Testing same since 159849 2021-03-06 18:14:24 Z 0 days 1 attempts ------------------------------------------------------------ 5153 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1275824 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 07 08:46:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 Mar 2021 08:46:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94450.178021 (Exim 4.92) (envelope-from ) id 1lIp35-0004Ms-DQ; Sun, 07 Mar 2021 08:46:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94450.178021; Sun, 07 Mar 2021 08:46:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIp35-0004Ml-8T; Sun, 07 Mar 2021 08:46:03 +0000 Received: by outflank-mailman (input) for mailman id 94450; Sun, 07 Mar 2021 08:46:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIp34-0004Md-A6; Sun, 07 Mar 2021 08:46:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIp34-0007PU-3i; Sun, 07 Mar 2021 08:46:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIp33-0008Gp-Sv; Sun, 07 Mar 2021 08:46:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIp33-0000Dy-Rg; Sun, 07 Mar 2021 08:46:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gGjPsfOe942F5hWBZp2hzj0QSEyXA6g+4cDwlMqcm6U=; b=FGR1cjfPEYkQ1Q6nf7IUe972GH ssVyazg3Rk66VWOUSPtW/d8wvbopCbz5K0CJOXuRlQlcSh/xW3KekTmH8I2IgnUrL4SEoP+FI1JxU DUvP2vmOxz8jb9T5Fa/68Z7MFXpwsm93wC/EoT9pMno8gPtenTXWtObk0bGVTis/r1xo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 159854: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=d5b2644815f12c3ef2dc0d31d32a0c30092a8853 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 07 Mar 2021 08:46:01 +0000 flight 159854 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/159854/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt d5b2644815f12c3ef2dc0d31d32a0c30092a8853 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 240 days Failing since 151818 2020-07-11 04:18:52 Z 239 days 232 attempts Testing same since 159845 2021-03-06 04:20:01 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 46031 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 07 09:50:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 Mar 2021 09:50:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94468.178035 (Exim 4.92) (envelope-from ) id 1lIq37-0002CS-7f; Sun, 07 Mar 2021 09:50:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94468.178035; Sun, 07 Mar 2021 09:50:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIq37-0002CL-4X; Sun, 07 Mar 2021 09:50:09 +0000 Received: by outflank-mailman (input) for mailman id 94468; Sun, 07 Mar 2021 09:50:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIq36-0002CD-5d; Sun, 07 Mar 2021 09:50:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIq35-0008Qn-Pm; Sun, 07 Mar 2021 09:50:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIq35-0003X4-Dh; Sun, 07 Mar 2021 09:50:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIq35-0000t7-DJ; Sun, 07 Mar 2021 09:50:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eWhuO3zrpuY57a1eoiQyuU/UY6/vbm0pcZ7CgATdiuM=; b=ogfLYrKwVhMA2ut+Ue698q6I5l XzHXVV81J+P758NQp/LlOb0xMv2UxMEqAYrfKpecfQjN7zoOksYJ1zl33ATRMyxS3XSx2KKHmGL2W LEOc+6tj+NS0naMNcQMxACUzamIJJwwy104EQeCphviuzPdggxhN64yPmrL+2zNAYfso=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 159856: all pass - PUSHED X-Osstest-Versions-This: xen=51972482f77b68ef494c8b9591b125460e7984b9 X-Osstest-Versions-That: xen=4834936549f788378918da8e9bc97df7dd3ee16d From: osstest service owner Date: Sun, 07 Mar 2021 09:50:07 +0000 flight 159856 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/159856/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 51972482f77b68ef494c8b9591b125460e7984b9 baseline version: xen 4834936549f788378918da8e9bc97df7dd3ee16d Last test of basis 159815 2021-03-03 09:19:32 Z 4 days Testing same since 159856 2021-03-07 09:20:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Michael Kurth Norbert Manthey Roger Pau Monné Tim Deegan jobs: coverity-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4834936549..51972482f7 51972482f77b68ef494c8b9591b125460e7984b9 -> coverity-tested/smoke From xen-devel-bounces@lists.xenproject.org Sun Mar 07 10:58:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 Mar 2021 10:58:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94487.178051 (Exim 4.92) (envelope-from ) id 1lIr6j-0007nM-6l; Sun, 07 Mar 2021 10:57:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94487.178051; Sun, 07 Mar 2021 10:57:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIr6j-0007nF-3h; Sun, 07 Mar 2021 10:57:57 +0000 Received: by outflank-mailman (input) for mailman id 94487; Sun, 07 Mar 2021 10:57:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIr6h-0007nA-Lf for xen-devel@lists.xenproject.org; Sun, 07 Mar 2021 10:57:55 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id df73b351-dbc4-4d50-bb36-31f08d3aedd1; Sun, 07 Mar 2021 10:57:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df73b351-dbc4-4d50-bb36-31f08d3aedd1 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615114674; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=2q6pRxdIZ78xQ6v4Nih3FvoWX7GJOxta40npktxnXUw=; b=hKvbGvjjfWJKqxKQ6QEAomyCFDpdtY7vpDciaB+HrhAtnvl2CSvcTPJf c6179Qj4T/Bc3n1Lwajm2rb9VGOqNhZpuKvdYVkqPMW8iy+jKB1U+x4l8 f4LY4P3QYDVXFG2N3j40mw8qKz/XIfaMJ+rLTV3AWhM+Ek6b1bBx6iX1v 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: dKDLkF2Mzv5teOYrtc3oFCYIpYxSH89BvwqjOIfH371FWqD6S2zUDAYoOMfzpvCN4XO6ndeIWh mQymJSYDJ48iXZB2A0UvNMzOy6mQ23hmRgxx/I2gfcQWAdWNiVp5EVyQ06ITlQTKBDQHV51EqE TBISRJOpCw/xljy5Gu4xkQBkB9Gri/MM3C32eu+MDlXcUeK9fAY5MYyyh+DkglQP4NLZY4uNZF qOMHAhfidpnDT7Uk6o0UW5puDoA0D66WdPzmyAis0Bfiatr3CKbNbveb6u1cdpTJ9b4Otm/MmD hck= X-SBRS: 5.2 X-MesageID: 39083910 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,230,1610427600"; d="scan'208";a="39083910" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMrwM5Er08/sAsGJNCMvCji8rQ7tOyT8NYyxNZ1sQhB7PxO+XtO1ld5JvwZxhvTgw/TpRUAUa9YKPi76tAkY1TMcxQs0IzzNm8dvtfKAAocf2JOUzDtRC1oGia8CmNR6X06d4kIObsWJM/XokKsfULKnAvw6WnLuzxUpdbze7lELJ26LgHQ+6R5t1ht5XDtdz4GgUnrfqWoECKWyGE/1+suSxXO/2k+7mb5AaJmxXreXDbC6JMM/vK5f12jvd3UWXeNqQ8RdlddJZmgAobh0XVQNcx0OmcInZzAk09ZOV9awGJwUE5mJDYpxGKg5RtM2rc2i5lTzvBux4IIKAgg/eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M/kcEvGz1tQFHCcP3t01GSZz7P2SJD1K3ySFGeFsoys=; b=MR27zqym5gN3mtm9PvbUhKloBtuNPXvwFlbWRgJUf4Q9PoYchUzeVjMc30nZGjpdlZIpjcW05U38CtcfavgjJgIPaBOzzuF/V9W0RSkupOtVDSrrFAayw4+13JQjXa3qLxmskboq9kZ5wnj0+xuwSV/yee06hs02sWgdyO7Sl57KCkiu8U7eAHaYmGY+WZSSPFhYWq8QTly/m825xSDrNSIF78TaNr92cQjo/WP3gk/C5zHi8AKZujLbxz63FY8Lb6nJp/75VBLApD8eTmFjfC0r9NCJWeDpGHzBc550c0G/lM3CZxZRvD+9ysB2m6GNTrQWalkGOD5LgNRip67sGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M/kcEvGz1tQFHCcP3t01GSZz7P2SJD1K3ySFGeFsoys=; b=kT8p2AkCJYAsLrGvmXOGjgtbt+MUTpfuP4aGbKyKOVfn3LGmB513pvmarjseKcGpapSfr6DPDSDMAqJxXHlqu3JG6Prujz7GeobXOGiXH1LnWF/b8jIks2Ud1say3nelGYVpRPoXkcl1fq5B8c+O82Sb8PU/XgQrJiAu2q+jM0k= Date: Sun, 7 Mar 2021 11:57:40 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Julien Grall CC: , Julien Grall , "Andrew Cooper" , George Dunlap , Ian Jackson , Jan Beulich , "Stefano Stabellini" , Wei Liu Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) Message-ID: References: <20210306214148.27021-1-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210306214148.27021-1-julien@xen.org> X-ClientProxiedBy: AS8PR04CA0011.eurprd04.prod.outlook.com (2603:10a6:20b:310::16) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d5cbe62e-1454-4d85-95c0-08d8e157d7af X-MS-TrafficTypeDiagnostic: DS7PR03MB5606: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ARkgZczLAZqWBquOaWHytLeu1WSXcP16SZvRptyLfrI8mzKVgZGg+1/bzFZxk+UR+PmMvat0Apa4f02M4plG3Yzy+Sqxu+i8ZSXVL2OX4rTCYVQ1k3XQocGbv86p0BW/HSg5TM+wpAlgtgUCMpygW+qBdaDKdjoUxoaMngyH04A4LUvANKe6FFHJp73eo+t9rN30ZgwnyxzTjbZz+QWn5NtFCPU531pVrFx6NfG0RKVYQFryDYMfUxz126NhInfwTzRlcqCBZVCgT3O1ctQMjqLVETOMmNp9XlWgC5HT3/xpYPaGQ3GdG49FeEyurWwviHKjMSqdXhFsKuDx/tKvDVrV4rP3zTgCbU1LPD13fpZlF8MyuQqZnsxFQ5hV1cU5wTrjUbvjd1ow1Y1ps1PM+TvuYBWgut7d51qft/CJKwmfJuJKKtAWopqaJC5K2tAli9RBfFVwajX6THR+Ct/6MRpLumqzp/7Jg0IG/JM1Rw1fIPkrh1Dz67PLHT2wBehoZxig6fNRcXkGwnmfFXfDcHlq2VuOjLN0JFJZs3GPGIwtJdOr0uECwh/KNpu+nCdGpcDXiBlVeXu31mojghoYqrHztYIGImiJMWfUfrQaOX1G+s8RLNn4xMtSWrnabc9mEVRwyzMi8zsFXVL8YFktOQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(39850400004)(346002)(376002)(396003)(366004)(136003)(6486002)(26005)(66476007)(186003)(66946007)(66556008)(16526019)(9686003)(8676002)(85182001)(966005)(6496006)(6666004)(8936002)(86362001)(956004)(4744005)(316002)(33716001)(4326008)(2906002)(54906003)(478600001)(5660300002)(6916009)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MXFrS3lVUU9qRGFoWmhsM2lXWnliSjhwb1hNcW8wdFFQTGxtL3JPd3p0TlNr?= =?utf-8?B?b0hON3F1Z1gxNWpDZEcxY0pKRmtDM1AwSjhRakp5eFVVSWV6V3hac3I4ZnNq?= =?utf-8?B?MGV3cXBrTlF5cEF5eFBkVkRjdnU3Ky9UMWZoRXhYN2ZtT1BKU3ZZcnQvVlFU?= =?utf-8?B?VUVSZXJBckIwUnJWb2RLWHc3S3Jjb1g1a3oyNkhXdFNxNytpY0NCelVIaTlL?= =?utf-8?B?ZFlwemJ5TUtYKzFCaGhoM2p2WFd6aDVoM2pWeHhURXVmaHY4RXM0QXBnV3RE?= =?utf-8?B?OEl0QTEyNG5tZWVCTHpPNmhQRVVLTFB2dWZWSG9YcCtMZXFjRHZGd005MUdM?= =?utf-8?B?MzlsK0tzQm01ZENCM1oyMWdITlhURTJlRTNkN0EyZmNyWVI2L09VM3gwN1h5?= =?utf-8?B?NE9GeXVVTStmVGNjMERkVGlveGhiTHNQS2oyNnQvYXBVZzlMSTFFbHphb0VR?= =?utf-8?B?M21NNjJxeUE2UWZSc1IrOHhxRFFvVWN0VVZoOWJvcllXcm83T1N5NHZCTm9E?= =?utf-8?B?UTdvanlyTkZFRkRaazV1TTRYaWpsWUU1eVR6b3BsVGtkMEVab1F4ZXlxZlg1?= =?utf-8?B?ZlUxUW9WUEQ2RVlmWWVmb3l4eDFFK1oxVzRuVFRkT3dsdnNSaDNhVnBSNXhZ?= =?utf-8?B?WVlhVGc4R0dWSkFxbUFRTWhKYVpxeitmMm1lVElVdFI2QUtieks4cjVvbU5F?= =?utf-8?B?eUlWdHFVakZySTNTbFNUNXRLV1JCUDFtak5BRjJPeTlmZ1pjZC9MWmJudTVD?= =?utf-8?B?Q3o4dk9BVk9ITTRpVGY5bHlRL08yc1V6NWtjWXQxaEkvRnkvM2xXTGd3bE9X?= =?utf-8?B?ZHd1akJCTzhYL2g3eTJ5aEZCMUlpYkRsMUZqSHlwdG1PNmxmSitKS3lJVEZ6?= =?utf-8?B?VFJjNzJVSW9mbUNNUmw3cXZUcVlLRm1QRnFwSVA0MUhmNUMvS1hFS0p5Yi9l?= =?utf-8?B?Mlp1bSs2cDdmaGtKM0s5NnM2TWlTbFJEMHNoL1plSEdpd1JvblFNcUVlMTcx?= =?utf-8?B?ekJyais4ekxqUHIwczRSOWhlOGRsTEo0cTRpa242UmlXcHoyUFhpOHlqeWRZ?= =?utf-8?B?NmpwRCtBYmtOS2hVS0FKby9yYXpzMjJFS0VLeWxweVNhb2dBVjJnamRKVnlR?= =?utf-8?B?aHFYMzJMbG1ueXJmM0dObzRFSXNPUU5zeXM5VFJDNHVHNGFqNDY3enViSlJr?= =?utf-8?B?RC9vU0p6R01WdW93cENjeTNYZHpMQkQva21XUENRbU5JOWFkOVN2UUdReVpN?= =?utf-8?B?NmpmYXZ2ZWRVQ2RJRVRxQWlJeVIvMzVFdytmdS9EQjJkRnlFdkNoM29neEZR?= =?utf-8?B?RkVyMk1JNFpnUVZPcXgzKzllazRhRjdaaG0rVzJxZ3UyKzkvMlpEeWdIem1j?= =?utf-8?B?V1dIMlQ3bG0wcjFNWE51aklJQktpM3pkV0hIMzhSemhJK0NNTXAxWGN4ZHJY?= =?utf-8?B?RkhsL2x0SzVWekJSTGtZdGFMRkxNYjN2NmFldnM1ZTZWckRvQmIxZ3B5Nmdv?= =?utf-8?B?aHhkN00ySCtUQkpkTHc5ckd0QWsyWkt1RzNDOUVsR1JsS3Vqa1BHTVBuaDAx?= =?utf-8?B?NE8xUVNHWC9mMHR5bnpZK3EwdHM3b3ppMVNaMTFtNUV3ekdJeGd2bm5GTDFV?= =?utf-8?B?cUw2VGhKWkkzUFh6UUlYT3FWS2pKU05wMGduSGtxUWQ2Mm1zTDMwQ1QxS3Vt?= =?utf-8?B?ZG11bUZnL25ZdEgyQ2xnc0c0NVZ2NDBaT3RpVlptVnBRUHgzUWM5TkZFVmVr?= =?utf-8?Q?whT/GUNeuuZOJnjegb9ZN/U78vfVNIJLvLV2YKJ?= X-MS-Exchange-CrossTenant-Network-Message-Id: d5cbe62e-1454-4d85-95c0-08d8e157d7af X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2021 10:57:47.1172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k9/rd12eueuO2qL504q95aSkVEqD63O4hKLlqdOuaHRDO2hYN3LMNe2oqjqdIzQpBFInfBmdWWoBqLduF7d59Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5606 X-OriginatorOrg: citrix.com On Sat, Mar 06, 2021 at 09:41:48PM +0000, Julien Grall wrote: > From: Julien Grall > > Compilers older than 4.8 have known codegen issues which can lead to > silent miscompilation: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 > > Furthermore, pre-4.9 GCC have known bugs (including things like > internal compiler errors on Arm) which would require workaround (I > haven't checked if we have any in Xen). > > The minimum version of GCC to build the hypervisor is now raised to 4.9. The README entry doesn't differentiate between tools and hypervisor GCC version, can the bug above also manifest in toolstack code? I don't think it makes much sense to have diverging requirements for tools vs hypervisor builds, but if the bug(s) can also manifest in toolstack code we might want to add a GCC version check to tools/configure.ac. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Sun Mar 07 11:15:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 Mar 2021 11:15:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94490.178063 (Exim 4.92) (envelope-from ) id 1lIrN9-0001D8-MZ; Sun, 07 Mar 2021 11:14:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94490.178063; Sun, 07 Mar 2021 11:14:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIrN9-0001D1-Il; Sun, 07 Mar 2021 11:14:55 +0000 Received: by outflank-mailman (input) for mailman id 94490; Sun, 07 Mar 2021 11:14:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIrN8-0001Ct-2K; Sun, 07 Mar 2021 11:14:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIrN7-0001QM-OX; Sun, 07 Mar 2021 11:14:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIrN7-0008Qb-DR; Sun, 07 Mar 2021 11:14:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIrN7-0000Ej-Cy; Sun, 07 Mar 2021 11:14:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=e9PuhDpJKoWkXSJ+cxcPBhfGJLJijmS/2I6NGYohD1I=; b=pXDFN1WB2YHQRuTka8ziXPgVAy SyzyqGOj/TO/cYdgNCvjvS+DOWFnHijYXh2Veva9nwZ5/HVdRpjiLd5tVF0PGb8HoGv2tMeLAFzrz Y/cDqdE/1hnY0sISA2SZymtDTXENbxseMF7xnoDFvZizwJA8Jv1QznfGYoPyOW3TYV3g=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159851: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-arm64-arm64-xl-credit2:xen-boot:fail:heisenbug xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=51972482f77b68ef494c8b9591b125460e7984b9 X-Osstest-Versions-That: xen=9318fdf757ec234f0ee6c5cd381326b2f581d065 From: osstest service owner Date: Sun, 07 Mar 2021 11:14:53 +0000 flight 159851 xen-unstable real [real] flight 159857 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159851/ http://logs.test-lab.xenproject.org/osstest/logs/159857/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-credit2 8 xen-boot fail pass in 159857-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 159857 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 159857 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159844 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159844 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159844 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159844 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159844 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159844 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159844 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159844 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159844 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159844 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159844 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 51972482f77b68ef494c8b9591b125460e7984b9 baseline version: xen 9318fdf757ec234f0ee6c5cd381326b2f581d065 Last test of basis 159844 2021-03-06 01:08:47 Z 1 days Testing same since 159851 2021-03-06 23:33:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9318fdf757..51972482f7 51972482f77b68ef494c8b9591b125460e7984b9 -> master From xen-devel-bounces@lists.xenproject.org Sun Mar 07 12:37:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 Mar 2021 12:37:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94506.178082 (Exim 4.92) (envelope-from ) id 1lIsf2-0008TL-96; Sun, 07 Mar 2021 12:37:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94506.178082; Sun, 07 Mar 2021 12:37:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIsf2-0008TE-5J; Sun, 07 Mar 2021 12:37:28 +0000 Received: by outflank-mailman (input) for mailman id 94506; Sun, 07 Mar 2021 12:37:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIsf1-0008T9-1T for xen-devel@lists.xenproject.org; Sun, 07 Mar 2021 12:37:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIsex-0002jp-V4; Sun, 07 Mar 2021 12:37:23 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lIsex-0003sS-Jj; Sun, 07 Mar 2021 12:37:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=AMIkYuHXp74v7qOiZccjjE6wmpie7IJ3DHDShXxqeTc=; b=hV+Q3xhlfjLM0K6LbqIxjSKWtK tMebSMjz+WwIK7viiuz3qTzQ95jBSV9vKNuPU+Xz2f9wFTwgLsG8uUILwo31z3MHNRzHEMNuhNjfb oICMj0BLNtr9VmBTYj3QWek33ZbY8uFComFJHOz4ao2j3HFdHaz9N7YV9FhspNrBENgA=; Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu References: <20210306214148.27021-1-julien@xen.org> From: Julien Grall Message-ID: <6d312453-a949-143b-f4a6-e7fac7ef6486@xen.org> Date: Sun, 7 Mar 2021 12:37:21 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Roger, On 07/03/2021 10:57, Roger Pau Monné wrote: > On Sat, Mar 06, 2021 at 09:41:48PM +0000, Julien Grall wrote: >> From: Julien Grall >> >> Compilers older than 4.8 have known codegen issues which can lead to >> silent miscompilation: >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 >> >> Furthermore, pre-4.9 GCC have known bugs (including things like >> internal compiler errors on Arm) which would require workaround (I >> haven't checked if we have any in Xen). >> >> The minimum version of GCC to build the hypervisor is now raised to 4.9. > > The README entry doesn't differentiate between tools and hypervisor > GCC version, can the bug above also manifest in toolstack code? I guess it can manifest in the firmware (e.g. hvmloader, rombios). It looks rather unlikely in the userspace tools as we seem to barely use volatile. For the Arm64 bug [1], I think it can also show up when receiving a signal. > > I don't think it makes much sense to have diverging requirements for > tools vs hypervisor builds, but if the bug(s) can also manifest in > toolstack code we might want to add a GCC version check to > tools/configure.ac. Agree. I can add check in ./configure for the toolstack. Cheers, [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Mar 07 13:00:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 Mar 2021 13:00:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94509.178094 (Exim 4.92) (envelope-from ) id 1lIt1J-0002hr-5R; Sun, 07 Mar 2021 13:00:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94509.178094; Sun, 07 Mar 2021 13:00:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIt1J-0002hk-2O; Sun, 07 Mar 2021 13:00:29 +0000 Received: by outflank-mailman (input) for mailman id 94509; Sun, 07 Mar 2021 13:00:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIt1I-0002hf-4o for xen-devel@lists.xenproject.org; Sun, 07 Mar 2021 13:00:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIt1D-00037L-UG; Sun, 07 Mar 2021 13:00:23 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lIt1D-0005U2-Ku; Sun, 07 Mar 2021 13:00:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=urjHlxySHDzp7Wmm/LEClvYh+cIsf2+1hiRjHBN50ME=; b=OjJDnrf0NfvZB0UyD/FlI+WYx8 x0K8sPLvcIv0zKAz3IqohzxEXNym3jJXJ8/mEh1PA7OSiyHhgaAFchLSUZ9dvmiMrNDcMZHY3ofqc VrrDKllGgi2oEMEzJgRsO9BQeJDW88CGhVo/zaYBzNtAvJttpylcLcPbV7KPoe8W7wyw=; Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) To: xen-devel@lists.xenproject.org, famzheng@amazon.com Cc: sstabellini@kernel.org, cardoe@cardoe.com, wl@xen.org, Bertrand.Marquis@arm.com, andrew.cooper3@citrix.com References: <161507188317.11025.6744028462008264481@c667a6b167f6> From: Julien Grall Message-ID: Date: Sun, 7 Mar 2021 13:00:21 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <161507188317.11025.6744028462008264481@c667a6b167f6> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi, On 06/03/2021 23:04, no-reply@patchew.org wrote: > Hi, > > Patchew automatically ran gitlab-ci pipeline with this patch (series) applied, but the job failed. Maybe there's a bug in the patches? > > You can find the link to the pipeline near the end of the report below: > > Type: series > Message-id: 20210306214148.27021-1-julien@xen.org > Subject: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) > > === TEST SCRIPT BEGIN === > #!/bin/bash > sleep 10 > patchew gitlab-pipeline-check -p xen-project/patchew/xen > === TEST SCRIPT END === > > warning: redirecting to https://gitlab.com/xen-project/patchew/xen.git/ > warning: redirecting to https://gitlab.com/xen-project/patchew/xen.git/ > From https://gitlab.com/xen-project/patchew/xen > * [new tag] patchew/20210306214148.27021-1-julien@xen.org -> patchew/20210306214148.27021-1-julien@xen.org > Switched to a new branch 'test' > f332859b88 xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) > > === OUTPUT BEGIN === > [2021-03-06 21:45:17] Looking up pipeline... > [2021-03-06 21:45:18] Found pipeline 266507477: > > https://gitlab.com/xen-project/patchew/xen/-/pipelines/266507477 > > [2021-03-06 21:45:18] Waiting for pipeline to finish... > [2021-03-06 22:00:21] Still waiting... > [2021-03-06 22:15:26] Still waiting... > [2021-03-06 22:30:31] Still waiting... > [2021-03-06 22:45:35] Still waiting... > [2021-03-06 23:00:41] Still waiting... > [2021-03-06 23:04:42] Pipeline failed > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-clang-pvh' in stage 'test' is skipped > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-gcc-pvh' in stage 'test' is skipped > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-clang' in stage 'test' is skipped > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-gcc' in stage 'test' is skipped > [2021-03-06 23:04:42] Job 'qemu-smoke-arm64-gcc' in stage 'test' is skipped > [2021-03-06 23:04:42] Job 'qemu-alpine-arm64-gcc' in stage 'test' is skipped > [2021-03-06 23:04:42] Job 'build-each-commit-gcc' in stage 'test' is skipped > [2021-03-06 23:04:42] Job 'alpine-3.12-clang' in stage 'build' is failed The following jobs are failing: alpine-3.12-clang [1] debian-unstable-32-gcc-debug debian-unstable-clang debian-unstable-gcc-randconfig ubuntu-bionic-clang Cloning into 'qemu-xen-dir-remote.tmp'... error: inflate: data stream error (incorrect data check) fatal: serious inflate inconsistency fatal: index-pack failed This looks unrelated to my patch. Possibly a network error? ========= centos-7-2-gcc [2] centos-7-2-gcc-debug centos-7-gcc centos-7-gcc-debug Centos 7 is using GCC 4.8.5. This patch is bumping the minimum version to 4.9. So the failure is expected. We may have to disable the jobs if my patch goes ahead. May I ask why we chose to build on Centos 7? ========== ubuntu-trusty-gcc [3] ubuntu-trusty-gcc-debug Ubuntu trusty is using GCC 4.8.4. This patch is bumping the minimum version to 4.9. So the failure is expected. We may have to disable the jobs if my patch goes ahead. May I ask why we chose to build on Ubuntu trusty? Cheers, [1] https://gitlab.com/xen-project/patchew/xen/-/jobs/1078273595 [2] https://gitlab.com/xen-project/patchew/xen/-/jobs/1078273539 [3] https://gitlab.com/xen-project/patchew/xen/-/jobs/1078273575 > === OUTPUT END === > > Test command exited with code: 1 > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Mar 07 14:06:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 Mar 2021 14:06:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94516.178105 (Exim 4.92) (envelope-from ) id 1lIu38-0008DT-5Q; Sun, 07 Mar 2021 14:06:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94516.178105; Sun, 07 Mar 2021 14:06:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIu38-0008DM-2V; Sun, 07 Mar 2021 14:06:26 +0000 Received: by outflank-mailman (input) for mailman id 94516; Sun, 07 Mar 2021 14:06:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIu37-0008DE-5C; Sun, 07 Mar 2021 14:06:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIu36-0004F7-T4; Sun, 07 Mar 2021 14:06:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIu36-0006nw-J9; Sun, 07 Mar 2021 14:06:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIu36-0000zn-Hb; Sun, 07 Mar 2021 14:06:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UvHetOyOxHQh7nj61VRJWIJntR5t/6PSA3Zgx7FymZQ=; b=jUkNHHxNoAuL1ZWwOM7FXronbt aBmDpLKtTCPwzJ7xq4rxt85iXS0E6PXAOaIGkyVf5YnQsb2/gACS7dZgqPyhkF8ASCvdHhM2kVLb6 bIqyZE154MSHFjY2RWZWBkA4DXvD69eP15MsSALIvlztTBYGrEAtK/cCIy9qbTenKVeM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159853: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-migrate/dst_host/src_host/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=91e92cad67caca3bc4b8e920ddb5c8ca64aac9e1 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sun, 07 Mar 2021 14:06:24 +0000 flight 159853 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/159853/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 28 guest-migrate/dst_host/src_host/debian.repeat fail pass in 159848 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 91e92cad67caca3bc4b8e920ddb5c8ca64aac9e1 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 199 days Failing since 152659 2020-08-21 14:07:39 Z 197 days 381 attempts Testing same since 159848 2021-03-06 15:41:19 Z 0 days 2 attempts ------------------------------------------------------------ 435 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 119704 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 07 16:43:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 Mar 2021 16:43:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94552.178121 (Exim 4.92) (envelope-from ) id 1lIwV6-0006Bq-9H; Sun, 07 Mar 2021 16:43:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94552.178121; Sun, 07 Mar 2021 16:43:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIwV6-0006Bj-5k; Sun, 07 Mar 2021 16:43:28 +0000 Received: by outflank-mailman (input) for mailman id 94552; Sun, 07 Mar 2021 16:43:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIwV4-0006Bb-Jw; Sun, 07 Mar 2021 16:43:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIwV4-0007F1-BR; Sun, 07 Mar 2021 16:43:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIwV4-0007JO-1z; Sun, 07 Mar 2021 16:43:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lIwV4-0007DZ-1V; Sun, 07 Mar 2021 16:43:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Gq+LvqFS+i/jOhxvgVDAR1QbRvwyalz0sChD3iZUs8w=; b=u67Wi2bQhDSGjje0UjJ40ONxSf b0Vicq/arIfHnzP31fhotEzeoTSFJxwU6Ttn5Xu6oMZpavplERp4Ab+FkNTXI1Yjg2Xc7EZMi3dl6 Jhl2FGQzjWAlqX176S9hh9+p1DDxXoq/OhAz/EycKor8u/hy5krH/gr2yYIbKwkuhB3g=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159855: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a38fd8748464831584a19438cbb3082b5a2dab15 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sun, 07 Mar 2021 16:43:26 +0000 flight 159855 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159855/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux a38fd8748464831584a19438cbb3082b5a2dab15 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 218 days Failing since 152366 2020-08-01 20:49:34 Z 217 days 377 attempts Testing same since 159849 2021-03-06 18:14:24 Z 0 days 2 attempts ------------------------------------------------------------ 5153 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1275824 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 07 20:31:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 07 Mar 2021 20:31:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94606.178136 (Exim 4.92) (envelope-from ) id 1lJ03Z-0001AQ-DG; Sun, 07 Mar 2021 20:31:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94606.178136; Sun, 07 Mar 2021 20:31:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ03Z-0001AJ-9v; Sun, 07 Mar 2021 20:31:17 +0000 Received: by outflank-mailman (input) for mailman id 94606; Sun, 07 Mar 2021 20:31:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ03Y-0001AB-8F; Sun, 07 Mar 2021 20:31:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ03X-0002rQ-Ud; Sun, 07 Mar 2021 20:31:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ03X-0002dR-IV; Sun, 07 Mar 2021 20:31:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJ03X-0002WA-Hy; Sun, 07 Mar 2021 20:31:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tApXfuezxSvoMXOT5zaiw8UrBIgOud076NkR9IYAwcs=; b=37PnB1tXPafiicT4ScK/rrPnB1 gVxk8VQ71FFpY62lbdIf1DV+cym67/cq5aqnqaLJ2eHsbb3O7rLheHICNcriouMWOLPfg0zDOggv0 pBNo9UbCj3LFeUmu66C7F+0ipIzmE8jIBX6ITtua0yPZB0OqGq87YL7CZnbUNnSR46B0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159858: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=51972482f77b68ef494c8b9591b125460e7984b9 X-Osstest-Versions-That: xen=51972482f77b68ef494c8b9591b125460e7984b9 From: osstest service owner Date: Sun, 07 Mar 2021 20:31:15 +0000 flight 159858 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/159858/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159851 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159851 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159851 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159851 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159851 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159851 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159851 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159851 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159851 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159851 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159851 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 51972482f77b68ef494c8b9591b125460e7984b9 baseline version: xen 51972482f77b68ef494c8b9591b125460e7984b9 Last test of basis 159858 2021-03-07 11:17:58 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 02:13:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 02:13:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94616.178151 (Exim 4.92) (envelope-from ) id 1lJ5OL-00089j-MT; Mon, 08 Mar 2021 02:13:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94616.178151; Mon, 08 Mar 2021 02:13:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ5OL-00089c-I9; Mon, 08 Mar 2021 02:13:05 +0000 Received: by outflank-mailman (input) for mailman id 94616; Mon, 08 Mar 2021 02:13:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ5OL-00089U-7X; Mon, 08 Mar 2021 02:13:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ5OK-0002Wq-SP; Mon, 08 Mar 2021 02:13:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ5OK-0001Wf-ES; Mon, 08 Mar 2021 02:13:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJ5OK-0003SI-Cp; Mon, 08 Mar 2021 02:13:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QJsJVzGldOrP9K5q4GtK5a7zsgn/Cr8noHEPcNbEd6U=; b=3k79M6ab3RhhJ/8iEz5tOvthJc iopKuozjg9NlT8IjTW8DxemPt+BEjmQ0WELXc7Ds81TCnk5QjSGVzavhyhyQ6tq8J7c6VkzD8ODbj yYjhV0EHvD6iziLhBcTmM+Sr4IAXjKMMRU5h68LBbjS9pkxhEa7TeVhJnLd5dCzC36iw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 159859: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c4ca4659678e07f0a14b3b143f6fb746efe11f88 X-Osstest-Versions-That: linux=7f324ea75baa059ea126cddd4141198895880a69 From: osstest service owner Date: Mon, 08 Mar 2021 02:13:04 +0000 flight 159859 linux-5.4 real [real] flight 159862 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159859/ http://logs.test-lab.xenproject.org/osstest/logs/159862/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail pass in 159862-retest test-amd64-amd64-examine 4 memdisk-try-append fail pass in 159862-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 159826 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail in 159862 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159826 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159826 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159826 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159826 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159826 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159826 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159826 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159826 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159826 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159826 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159826 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass version targeted for testing: linux c4ca4659678e07f0a14b3b143f6fb746efe11f88 baseline version: linux 7f324ea75baa059ea126cddd4141198895880a69 Last test of basis 159826 2021-03-04 09:40:07 Z 3 days Testing same since 159859 2021-03-07 11:40:35 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Alexander Egorenkov Anders Roxell Andrew Morton Anson Jacob Ard Biesheuvel Arnd Bergmann Bjorn Helgaas Bjørn Mork Borislav Petkov Casey Schaufler Chao Leng Chao Yu Chris Leech Christian Gromm Christian König Christoph Hellwig Claire Chang Cong Wang Daniel Bristot de Oliveira Daniel Vetter Daniel Wheeler Darrick J. Wong Dave Kleikamp David S. Miller David Sterba Defang Bo DENG Qingfang Di Zhu Dinghao Liu Dmitry Torokhov Doug Horn Eckhart Mohr Eric Dumazet Fangrui Song Florian Fainelli Florian Westphal Gao Xiang Geert Uytterhoeven Gerd Hoffmann Gopal Tiwari Greg Kroah-Hartman Hans de Goede Hans Verkuil Heiner Kallweit Helge Deller Herbert Xu Hulk Robot Ingo Molnar Jaegeuk Kim Jakub Kicinski Jan Beulich Jason Self Jens Axboe Jim Mattson Jingle Wu jingle.wu Jiri Slaby Joe Perches John David Anglin Jon Hunter Josef Bacik Juerg Haefliger Juerg Haefliger Juergen Gross Julian Wiedmann Juri Lelli Kalle Valo Laurent Pinchart Lech Perczak Lee Duncan Li Xinhai Linus Torvalds Linux Kernel Functional Testing Luis Claudio R. Goncalves Marc Orr Marcel Holtmann Marco Elver Marek Vasut Mark Brown Martin K. Petersen Martin Kepplinger Mauro Carvalho Chehab Miaoqing Pan Nathan Chancellor Nathan Chancellor Nicholas Kazlauskas Nick Desaulniers Nikolay Aleksandrov Nirmoy Das Paul Burton Peter Zijlstra (Intel) Pierre-Louis Bossart Rajat Jain Randy Dunlap Ricardo Ribalda Rob Herring Rokudo Yan Russell King Sabyrzhan Tasbolatov Sakari Ailus Sasha Levin Sean Young Sedat Dilek Sergey Senozhatsky Shaoying Xu Takashi Iwai Thomas Bogendoerfer Thomas Zimmermann Tian Tao Tony Lindgren Vladimir Oltean Werner Sembach Will Deacon Willem de Bruijn Yumei Huang Zqiang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 7f324ea75baa..c4ca4659678e c4ca4659678e07f0a14b3b143f6fb746efe11f88 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 06:00:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 06:00:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94625.178166 (Exim 4.92) (envelope-from ) id 1lJ8wR-0003t4-5a; Mon, 08 Mar 2021 06:00:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94625.178166; Mon, 08 Mar 2021 06:00:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ8wR-0003sx-2Y; Mon, 08 Mar 2021 06:00:31 +0000 Received: by outflank-mailman (input) for mailman id 94625; Mon, 08 Mar 2021 06:00:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ8wQ-0003sp-49; Mon, 08 Mar 2021 06:00:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ8wP-0007FL-T8; Mon, 08 Mar 2021 06:00:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ8wP-0004qM-Dn; Mon, 08 Mar 2021 06:00:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJ8wP-0000G9-Ar; Mon, 08 Mar 2021 06:00:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tDrgcQh8Dr9Tt+sMWEPs1Jz674xvW/Rhkavc43ulsdI=; b=20lTsX5LuIi0L5H5Q+Oeqgu0N4 6fqaLTJeXDebju7Cb8GhKrDtsfmtA6BjR3b1PcLOjWKN04rgohsPF27ccCzkb4Fm2kjLnbExWYr92 Fu2aj8kFqi/IIENks3XpYWkufgXKJ0dJoSVHuubbsRs10JUaH9/kBVzmLRmlAsuBG93o=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 159863: all pass - PUSHED X-Osstest-Versions-This: ovmf=b8a92fa2fea548dccacc2f228b607b7febdf81c0 X-Osstest-Versions-That: ovmf=59a3ccb09e7a246913d88fbac31412f20f717a3c From: osstest service owner Date: Mon, 08 Mar 2021 06:00:29 +0000 flight 159863 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/159863/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b8a92fa2fea548dccacc2f228b607b7febdf81c0 baseline version: ovmf 59a3ccb09e7a246913d88fbac31412f20f717a3c Last test of basis 159841 2021-03-05 16:11:00 Z 2 days Testing same since 159863 2021-03-08 01:39:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bret Barkelew Bret Barkelew jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 59a3ccb09e..b8a92fa2fe b8a92fa2fea548dccacc2f228b607b7febdf81c0 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Mar 08 06:05:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 06:05:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94630.178181 (Exim 4.92) (envelope-from ) id 1lJ91G-00043f-R4; Mon, 08 Mar 2021 06:05:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94630.178181; Mon, 08 Mar 2021 06:05:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ91G-00043Y-NP; Mon, 08 Mar 2021 06:05:30 +0000 Received: by outflank-mailman (input) for mailman id 94630; Mon, 08 Mar 2021 06:05:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ91F-00043P-R7; Mon, 08 Mar 2021 06:05:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ91F-0007KG-Hn; Mon, 08 Mar 2021 06:05:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ91F-00057K-7B; Mon, 08 Mar 2021 06:05:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJ91F-00040d-6e; Mon, 08 Mar 2021 06:05:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kMmsJYPFLeA2ENKGTjJTWruh33aSy0xTuLmC9pKHjBI=; b=aA0Zhz4liHvI6MZ0MT9iTugrxi X/igJI3DQumGmMxboae+tH352tlmwfnghMUJQiAEaGAXNuHl2uUnEqn8nKnhbJtf0/nB+3hHmP2yr OLPAh55ZvG3VJQVOmMHjK293bTVxvJvUIfPCfr6AHFLAWkAU6m03fDO8CuaW6TiFIrXY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 159865: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=d5b2644815f12c3ef2dc0d31d32a0c30092a8853 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 08 Mar 2021 06:05:29 +0000 flight 159865 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/159865/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt d5b2644815f12c3ef2dc0d31d32a0c30092a8853 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 241 days Failing since 151818 2020-07-11 04:18:52 Z 240 days 233 attempts Testing same since 159845 2021-03-06 04:20:01 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 46031 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 08 07:05:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 07:05:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94637.178196 (Exim 4.92) (envelope-from ) id 1lJ9xJ-0000vs-Ug; Mon, 08 Mar 2021 07:05:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94637.178196; Mon, 08 Mar 2021 07:05:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ9xJ-0000vl-Rc; Mon, 08 Mar 2021 07:05:29 +0000 Received: by outflank-mailman (input) for mailman id 94637; Mon, 08 Mar 2021 07:05:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJ9xI-0000vg-M5 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 07:05:28 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ad90e749-9b80-4c9a-b699-713a93406fc2; Mon, 08 Mar 2021 07:05:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad90e749-9b80-4c9a-b699-713a93406fc2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615187126; h=from:to:cc:subject:date:message-id:mime-version; bh=x4vRChd+dxV6ytQmVNimD9wMQF8A2O4nUmILpIFlhaE=; b=Bp4SeloDpmcJqqyW5k+6Mmp+wYI8ePCS9VmLEGq+Bw1zvFkmrCj0eqB9 uVhFpamRWNa01EFuF4pDmJLfbzXYaqL1FJBVGK7H6dOSG0mKPVtxEdcd8 xWJzFe+jyrJiSpORYjWuACj28pcAUzTl2yD5ViPzM8V3DeR/sujZQQxhq c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: S0Auq6O8JXRFCVSQ8TIEKK7/1NXC+JYJu+7GeHjeY6QV500IefDMxiIlySK/pfC9ACCXiBi9TG YN9ePABBALOUcGESIVSCyQ2JVua0ycqumDkNYkWTnyrOW98w4NMleE1HxgLjxH76rhhWBJAmgH 2x1wHejtWDfrM0Q/xOkPaOoVMdpL6imLdxgFurpzMq2DUuylu4aA3TGluVjAd50U8nJIVBlbKA SrYqjIFFerwwxj90I4E18H4Z0MHeAgXXjlwF719oy3oFtNrW2T3zwvIIZplfXSkFEYpc0RjmcA Iuo= X-SBRS: 4.0 X-MesageID: 38926688 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,231,1610427600"; d="scan'208";a="38926688" From: Igor Druzhinin To: CC: , , , , , Igor Druzhinin Subject: [PATCH for-4.15] vtd: make sure QI/IR are disabled before initialisation Date: Mon, 8 Mar 2021 07:00:02 +0000 Message-ID: <1615186802-5908-1-git-send-email-igor.druzhinin@citrix.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain BIOS might pass control to Xen leaving QI and/or IR in enabled and/or partially configured state. In case of x2APIC code path where EIM is enabled early in boot - those are correctly disabled by Xen before any attempt to configure. But for xAPIC that step is missing which was proven to cause QI initialization failures on some ICX based platforms where QI is left pre-enabled and partially configured by BIOS. Unify the behaviour between x2APIC and xAPIC code paths keeping that in line with what Linux does. Signed-off-by: Igor Druzhinin --- xen/arch/x86/apic.c | 2 +- xen/drivers/passthrough/vtd/iommu.c | 12 +++++++++++- xen/include/asm-x86/apic.h | 1 + 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c index 7497ddb..8ab8214 100644 --- a/xen/arch/x86/apic.c +++ b/xen/arch/x86/apic.c @@ -47,7 +47,7 @@ static bool __read_mostly tdt_enabled; static bool __initdata tdt_enable = true; boolean_param("tdt", tdt_enable); -static bool __read_mostly iommu_x2apic_enabled; +bool __read_mostly iommu_x2apic_enabled; static struct { int active; diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index d136fe3..4aa7a31 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -2080,7 +2080,7 @@ static int __must_check init_vtd_hw(void) u32 sts; /* - * Basic VT-d HW init: set VT-d interrupt, clear VT-d faults. + * Basic VT-d HW init: set VT-d interrupt, clear VT-d faults, etc. */ for_each_drhd_unit ( drhd ) { @@ -2090,6 +2090,16 @@ static int __must_check init_vtd_hw(void) clear_fault_bits(iommu); + /* + * Disable interrupt remapping and queued invalidation if + * already enabled by BIOS in case we've not initialized it yet. + */ + if ( !iommu_x2apic_enabled ) + { + disable_intremap(iommu); + disable_qinval(iommu); + } + spin_lock_irqsave(&iommu->register_lock, flags); sts = dmar_readl(iommu->reg, DMAR_FECTL_REG); sts &= ~DMA_FECTL_IM; diff --git a/xen/include/asm-x86/apic.h b/xen/include/asm-x86/apic.h index 8ddb896..2fe54bb 100644 --- a/xen/include/asm-x86/apic.h +++ b/xen/include/asm-x86/apic.h @@ -24,6 +24,7 @@ enum apic_mode { APIC_MODE_X2APIC /* x2APIC mode - common for large MP machines */ }; +extern bool iommu_x2apic_enabled; extern u8 apic_verbosity; extern bool directed_eoi_enabled; -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 08:10:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 08:10:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94646.178208 (Exim 4.92) (envelope-from ) id 1lJAxJ-0006p7-WD; Mon, 08 Mar 2021 08:09:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94646.178208; Mon, 08 Mar 2021 08:09:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJAxJ-0006p0-St; Mon, 08 Mar 2021 08:09:33 +0000 Received: by outflank-mailman (input) for mailman id 94646; Mon, 08 Mar 2021 08:09:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJAxI-0006ov-G9 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 08:09:32 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c3e9b325-d55d-4fc5-9d57-35da3c824e77; Mon, 08 Mar 2021 08:09:31 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7AFB0AC54; Mon, 8 Mar 2021 08:09:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3e9b325-d55d-4fc5-9d57-35da3c824e77 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615190970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gyJPKbNrcaZkdN4OW2dJ9yfQSuqjDU+os+UZA9bWbok=; b=fyubqMpNStl60hoa6qgUebi/2Vn2xBCZmDpLeHlxmy98q/dA9QMRE+tp0wfuGnXfDsi8vS ZUrcPmot7kni+5R3WhGIFcFp9/BF12sEOzrM4QQx+nbZwqNsIsgrVmVcTWh4lVv4JDb9wC udUz+oqCIzUGFE5CC4s266e5w0YjK4I= Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) To: Julien Grall Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210306214148.27021-1-julien@xen.org> From: Jan Beulich Message-ID: <1897022d-7591-3450-4e57-884a2860b13d@suse.com> Date: Mon, 8 Mar 2021 09:09:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210306214148.27021-1-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06.03.2021 22:41, Julien Grall wrote: > From: Julien Grall > > Compilers older than 4.8 have known codegen issues which can lead to > silent miscompilation: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 > > Furthermore, pre-4.9 GCC have known bugs (including things like > internal compiler errors on Arm) which would require workaround (I > haven't checked if we have any in Xen). > > The minimum version of GCC to build the hypervisor is now raised to 4.9. > > In addition to that, on arm64, GCC version >= 4.9 and < 5.1 have been > shown to emit memory references beyond the stack pointer, resulting in > memory corruption if an interrupt is taken after the stack pointer has > been adjusted but before the reference has been executed. > > Therefore, the minimum for arm64 is raised to 5.1. I'm sure newer compiler versions also have bugs. Therefore I'm not convinced using this as the primary reason for a bump is enough. Plus what if critical to us bugs get found in, say, 5.x? Are we going to bump to 6.x then (and so on, until we allow only the most recent major version to be used)? Additionally - partly related to your own reply regarding the CI failures - imo there needs to be an analysis of what older distros will no longer build (at all or by default). We've been discussing to bump minimum tool chain versions for a long time. At least as far as I'm concerned, I didn't take on this job precisely because the code changes needed are relatively simple, but justification can (and apparently will) be rather complicated. Fundamentally, whatever kind of criteria we use to justify the bump now ought to be usable down the road by people justifying further bumps. Also - what about clang? Linux requires 10.0.1 as a minimum. > --- > > I don't have a strong opinion on the minimum version for GCC on x86. > So this is following Andrew's suggestion and the minimum from Linux. > > This patch is candidate to 4.15 and backport. I think such a change needs to be proposed much earlier in a release cycle. > --- a/README > +++ b/README > @@ -38,12 +38,15 @@ provided by your OS distributor: > * GNU Make v3.80 or later > * C compiler and linker: > - For x86: > - - GCC 4.1.2_20070115 or later > + - GCC 4.9 or later > - GNU Binutils 2.16.91.0.5 or later I don't think it makes much sense to keep the binutils version this low, the more that I don't think we can really build (correctly) with this old a version anymore. Whatever the gcc version chosen, I think we want to pick a binutils version from about the same time frame. > --- a/xen/include/xen/compiler.h > +++ b/xen/include/xen/compiler.h > @@ -5,6 +5,19 @@ > #error Sorry, your compiler is too old/not recognized. > #endif > > +#if CONFIG_CC_IS_GCC > +# if CONFIG_GCC_VERSION < 40900 > +/* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ As per the bug report, the issue was determined to not be present in e.g. 4.3. Hence while such a bug may influence our choice of minimum version, I don't think it can reasonably be named here as the apparent only reason for the choice. Personally I don't think any justification should be put here. > +# error Sorry, your version of GCC is too old - please use 4.9 or newer. > +# elif defined(CONFIG_ARM_64) && CONFIG_GCC_VERSION < 50100 > +/* > + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 > + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk > + */ > +# error Sorry, your version of GCC is too old - please use 5.1 or newer. >From the bug entry the fix looks to have been backported to 4.9, or at least some (important?) branches thereof. > +# endif > +#endif Instead of a completely new conditional, I think this wants to be combined with the existing one (the tail of which is visible in context above). Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 08:18:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 08:18:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94649.178219 (Exim 4.92) (envelope-from ) id 1lJB5x-0007jL-Sc; Mon, 08 Mar 2021 08:18:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94649.178219; Mon, 08 Mar 2021 08:18:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJB5x-0007jE-Pk; Mon, 08 Mar 2021 08:18:29 +0000 Received: by outflank-mailman (input) for mailman id 94649; Mon, 08 Mar 2021 08:18:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJB5w-0007j9-FI for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 08:18:28 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 14f24af3-004e-4ef3-b62a-c152e611ace5; Mon, 08 Mar 2021 08:18:27 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9AA15AC54; Mon, 8 Mar 2021 08:18:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14f24af3-004e-4ef3-b62a-c152e611ace5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615191506; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gbkc2atApil3/y+HiZQ+nWotmtLzxJs7v18JRMoBOAk=; b=KlCbWNhvwegnbNeL156FZeM8et5bmxKLJEZeWMgU6g+ZTunnQVcTX/cgho5I0513FdDoab Duax6DtGcdQDbRtWqo7qz25uob4wgCUpycLqm7MEw7ktyMCzQa8f2mVpF7ikbDNYqU2tN/ hRlvHmRySNh5wpT2TD/F3Z1OtA3/t4k= Subject: Re: [PATCH for-4.15] vtd: make sure QI/IR are disabled before initialisation To: Igor Druzhinin Cc: andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, kevin.tian@intel.com, xen-devel@lists.xenproject.org, Ian Jackson References: <1615186802-5908-1-git-send-email-igor.druzhinin@citrix.com> From: Jan Beulich Message-ID: Date: Mon, 8 Mar 2021 09:18:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1615186802-5908-1-git-send-email-igor.druzhinin@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 08:00, Igor Druzhinin wrote: > BIOS might pass control to Xen leaving QI and/or IR in enabled and/or > partially configured state. In case of x2APIC code path where EIM is > enabled early in boot - those are correctly disabled by Xen before any > attempt to configure. But for xAPIC that step is missing which was > proven to cause QI initialization failures on some ICX based platforms > where QI is left pre-enabled and partially configured by BIOS. And those systems then tell us to avoid use of x2APIC? I would have expected that on modern systems we wouldn't see such quirky firmware behavior anymore. Anyway, half a sentence to this effect might help here, as without such firmware behavior the only way to run into this ought to be use of "no-x2apic" on the command line. Which in turn might require justification (and potentially a fix elsewhere in the code to make use of that option unnecessary). > Unify the behaviour between x2APIC and xAPIC code paths keeping that in > line with what Linux does. > > Signed-off-by: Igor Druzhinin Reviewed-by: Jan Beulich with some editing of the description. If no other need for a v2 arises, I suppose whatever you come up with could be folded in while committing. Also Cc-ing Ian for a release ack. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 08:23:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 08:23:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94654.178231 (Exim 4.92) (envelope-from ) id 1lJBAs-0000DD-JQ; Mon, 08 Mar 2021 08:23:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94654.178231; Mon, 08 Mar 2021 08:23:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJBAs-0000D6-GR; Mon, 08 Mar 2021 08:23:34 +0000 Received: by outflank-mailman (input) for mailman id 94654; Mon, 08 Mar 2021 08:23:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJBAq-0000Cy-UC; Mon, 08 Mar 2021 08:23:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJBAq-0001hH-Ks; Mon, 08 Mar 2021 08:23:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJBAq-0002cV-6F; Mon, 08 Mar 2021 08:23:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJBAq-0001G4-5j; Mon, 08 Mar 2021 08:23:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=G7UVAMBzU/Ot9zw+sey0W+jWdGFjNFpJwlJj4qfeuA4=; b=FeSz/ne7XNeusu16+3O++nbf8S KVgn1MpxjVpUkIRSK2S8zPT1jRkM3Chjjdl9/hiKNDrH+lLYXzQ1xeQ/KfnohHxepV8evyLbI0fHE ipLZ2B9pgZokHmubhhxCeSV5JjlhXcvv09EqtD5k1lp1ZJ18AHxkvzrVqqJka7En+790=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159860: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=91e92cad67caca3bc4b8e920ddb5c8ca64aac9e1 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Mon, 08 Mar 2021 08:23:32 +0000 flight 159860 qemu-mainline real [real] flight 159867 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159860/ http://logs.test-lab.xenproject.org/osstest/logs/159867/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 91e92cad67caca3bc4b8e920ddb5c8ca64aac9e1 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 199 days Failing since 152659 2020-08-21 14:07:39 Z 198 days 382 attempts Testing same since 159848 2021-03-06 15:41:19 Z 1 days 3 attempts ------------------------------------------------------------ 435 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 119704 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 08 08:57:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 08:57:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94664.178250 (Exim 4.92) (envelope-from ) id 1lJBhI-0002yH-Dq; Mon, 08 Mar 2021 08:57:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94664.178250; Mon, 08 Mar 2021 08:57:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJBhI-0002yA-Ap; Mon, 08 Mar 2021 08:57:04 +0000 Received: by outflank-mailman (input) for mailman id 94664; Mon, 08 Mar 2021 08:57:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJBhH-0002y5-BK for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 08:57:03 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id beff79bc-8b27-44b0-82e2-95560a93ea8d; Mon, 08 Mar 2021 08:57:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: beff79bc-8b27-44b0-82e2-95560a93ea8d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615193821; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=IdQ7wrAR/zUetv/KedEfMfuT3gqU/dQTEm/uBj5pvnE=; b=TvqRM3McaJ5hj4+V7ZWgXALLwbTXCBS1m7U0OrZZrZppDJh7XbPHX2zR d38KBDVciDE6GCwq7ZDKGXEXMIfJ+FANC9RtUK4g5OW2Wjg9suVv7oG/m 1KsA4wSKCXMphbUBMkTs0251G7qHHORD0peNDFsi7HvVWZ+buxXrkW31P Q=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: eU7p9Krc6qFS5UKyFQwMy56T2slhwMHzr2smBbJkqcwu5jFx7c0yovBo/7uQyY4NvcfpWD1xm7 H/gXv9Q3FBL0V0fyEePm6v/a24pZkzw1SojXWcfoQsZW5qLPY39f+VEz6tCD0LZBwKyDmLN2ES OFNFL4GZzo5HAt4UuCoa2QQjNIgE5YJSA3h14ssdFTXc/UD/flQ8GklL8NtvY1fqO4FzR26vWO ZWV/aHuw7LpkHrdOr6ZL27sGqc9EJpL2kJxbtcAgaLwqQ74V1gL5+6fhpdf+pF9ldUUyPmJa8b ZZA= X-SBRS: 5.2 X-MesageID: 40159140 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,232,1610427600"; d="scan'208";a="40159140" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XPIsrOcXwOsqqXnVHY0o6kqQo8UPQzqx/5OYDXo/7ODXJtif2d9W14SGVaOyggJkc5W/S85kUQ6fIZIWBwj75l1nuEfTCaseNjdsdNk9waBcmbWEVbuG9GeyiQ/vAgJv18girlHNrtTVCCVP1TmIYrkxxZrfnKutb9O3K6qAGpfZ4YfrocpjQoEaDZwU1BlCoZvryhHLzmegh787qbQ4/EtUCEEPO5OX8WJLLcLYSSGRXa4zvu9nJzl2xLV6C1HPuXhWE0/D6jt9n/OHdwpGwzx9CF7u3Asf/Bh88wuJGOAPJSN/R2e1FDR7FsW+xuLdNd77Rq7UB1XAaq/qhiKnAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XmoMTmHAaEu7wpfC+D9vdqtW0NCM9/czu/DoPKCaoNY=; b=ZxGCLBTbA85i6l2SKTmj/jxQe2CdUwgIxzTCbhbxsF2MeeGeaGRd3asaJ5okeEnoR60IPsk9xmpBRWlUA/OaAiHZDM+DQ6aLIkVQgZUAvXifWtOhVOUv4md3jcM3by3qJa5H2YJxzUIO8l15J2EWEBij1meT0oUW35Z9bnFGC4oM5cidvYeeggdncRc+JfcaK+4xJ4JxrH+RqcDkgKzx5OrAk+8F2zaKha3420vh0BVgM1As6cg3D+dHgazcdkLD3+tEpBVTw9xS/lBaEdbjQlawZcNXz7Xh05kPwb/U7SiXX1XTWYCKtonUWBDSwkoTnR01sLASB0HyXzOFf24fGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XmoMTmHAaEu7wpfC+D9vdqtW0NCM9/czu/DoPKCaoNY=; b=gKzWZJxjJfwk1hJZJme9BFnkhX7mXn3wOQFkTSURmfTD5vmQOtQkau1K7xIhHdx6/RIrsNyg86GIoYm65sfX4lbGbnd4AhIixMdOEEm5ZJ1xtfaU8rXUMvQx5aFdtvqzLCGaqFzYdqChcgt9hMqBtQz33doiX8HDyYD7QXVbteE= Date: Mon, 8 Mar 2021 09:56:30 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson Subject: Re: [PATCH v2 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: PR0P264CA0134.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1a::26) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e094c041-5f40-446e-3e59-08d8e21014f1 X-MS-TrafficTypeDiagnostic: DM6PR03MB3740: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EtdNyX8LUJ+0S9naDQ+bprnMoUxvWRdItYzJG6TeP+nGJzPtP9fRbZtd+8QoIgxzqX6c8koL5w7isfb/AVhDQUilhWjE2KphefwlhIdAkALlGk6hR3tJB9Kcv+4f5bq1xM/hD7MqZ7tLk0hWF52Uxy3vg4cIHN8ExWzgzKwldjIjpcwpjp2iM5wf7MKVrkEDix+Eoxke8cOAmfp+mCGPzkkEiM0G8IfML8cstTQf7oKQkbn3wQbRNNMPsiZhfEjp3gH91qiwr+Kz5F3XeUz5RzjJ91x7/p38gjBuLhvi+7I+3ouj33x1De9qLfNdXZP0BUYble9ESJZSBlr+pAx0RkyYYUuzqxp0CzXQDKUAdNOhPnH2Kdj9LHxowMRXArJhraoN1ICD0jQBftY7vIgfyl1LyC9ptlOISBtftHAJjjucVMPQwFkdZ/hqENguJjS2UdSQTLNeaMVwYjAnGKZxROff6x/7i2kc0BLgAv6NijvK+vbsOm0kw4t/RJqrHle/RZFIfoYp/cdt+xE9RJ84tw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(346002)(366004)(376002)(396003)(39850400004)(136003)(478600001)(8936002)(316002)(8676002)(2906002)(9686003)(85182001)(6666004)(956004)(83380400001)(66556008)(66476007)(66946007)(4326008)(6916009)(86362001)(16526019)(186003)(33716001)(54906003)(5660300002)(26005)(6496006)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?cEIySy92UDV3K3U4Ym1mSFloMDMrQXVWRkowSnNFS3NCdytWZE1yNDJ2TmQ5?= =?utf-8?B?UjNtZlNNdDlvMVZCWFMxMFFlMVFLTE5NRm4xZDhPc2xwb3crdHNoTjllNkFO?= =?utf-8?B?V0xaYUI4MnpZNzRURlI4TFVwVitHb09SRE0xU1g3VWpLTW8xZnlHT2FmbE50?= =?utf-8?B?UlRvTS9EazdQUzF4ajJaRXUyd25BQU11cEtaUFhiOTNSK2psSjJhNENQdjI0?= =?utf-8?B?Q2ViOHllazdlcXFNbXVQamFOREZrNkF1bUkxbGxCTzFFWXYrOTF6bDFHYVFs?= =?utf-8?B?aXR0NC8wczNod282TFhIZU0waTBqOWtRWG9MT0V4c1VQTzlvZDllcEpPaGIv?= =?utf-8?B?RnJXYWoxSE5WK2R4VHFwaUZtSkpHZWp3dVNFSW5DMmM5Nk9sRTdqWjZoeEhx?= =?utf-8?B?bkJQSlJZOUNXelNDRkozRjdaRk1kNEtiYTBkQncxVjJBSUFIK0E3RHhKeWJD?= =?utf-8?B?MjRQcjhJQ1FuZEM0RkZBTDhWL2pDVlVONWhGYkJ2R0pTeVlQaHBLb2c0eStB?= =?utf-8?B?UnlpSExKeStwK2NVUHhvZHRWQktuSVZWUUpreE9yTDhoZ2dPOHBTMUh0bG05?= =?utf-8?B?Vk5QdW5kTVNnNlBlMHJuc0JsVDA5eUpQZS93RFdxY0hjMFJmMHcrTDYyR3pT?= =?utf-8?B?bkVJdFJKSFkzSmhVWDE2QXNzT3ZnRmZHYVc0YnJZRzBQaVhhTkduQ2k1V01G?= =?utf-8?B?VFdjWlhXUXZMNk5sTEZZcnFPM2VSZFJVWUZvVFp5b2JnRnFna1hCeUlzbGk0?= =?utf-8?B?bnhZM3BtY2tMZjgxQm1DdzdvaFRMSzJwQktzWDZrZXFRaUIzZjRSVXcrS2tn?= =?utf-8?B?UUNtVG1Ocy9mQklBMWswdHNzbkRzWEhwNEorOWVpRlUrK09JSkVRSHJ5UmRo?= =?utf-8?B?SmtPWk5hck5VZ0dIOUFTNDlvMFZEbEk4NTE1bG9MTWM0RjVyN3UvdUVKWWY3?= =?utf-8?B?bXlQT3ppZ1V6TzhuMUVYMkIvK2Vod212UEoxT3BVa3h1SG1rVHBKbmV3N3ZN?= =?utf-8?B?S1BjNTEzcngxMWRYU3hsbk5hN3lpdklTYXdqbE9odEMzNXNId3lBcHVwOGRt?= =?utf-8?B?SkNKTndjMGJtc1MrSGsvM1VSVXM3Wjg0b3piSzlXWW5Belo3ZVpvYVpsTVNy?= =?utf-8?B?alRsRFlOMVhEczlKVGI5aGdoUEtRaXlFUWhJNzFmRFNsa1BhdzB0T0VLdlNI?= =?utf-8?B?Wll5N1FaVjJ1VC9HbC9vM2FGekpjV0dQdzYwSG1qZWZFRmswckdwTStidEhX?= =?utf-8?B?d1FCSlRjK2psOGpzM3JVR2ltY29lSWFUM21Xb0QvWHhqcE5MNkViSkF4T2Fv?= =?utf-8?B?UnNxQzJkZ01KVVdvNUVFVmFQV2hHMFlIK0VMNFdhaWl0R25jZUtrTUFOUm5q?= =?utf-8?B?RnVnZnpNYnFvWWlVRFZ4RXNQNHkrcHk4UkpFUjd0bVlUT2dXUHlVVk56VUla?= =?utf-8?B?VnVGWlhUblVKdXlkdjFJaGRwaWpRb0J3UGNrWTV6MFF1cUdGQXVPeW0yS3Uv?= =?utf-8?B?NUF2eE5mdnI1NW1mbHRGTzd6dTVtZFZxMEVERzhZdTFHRTFPcHo3YWN2dUtU?= =?utf-8?B?ZFFXYitrK1RVOUpDR2t6U0tabGYzWE13eTdybmYvNFhMQnNHdHJpbmtlaG5z?= =?utf-8?B?bDVwOXE0ZzBzVmR5b0ZFL2NGR2pkNXUrY2dvYStXNTVZaXpCYlBxak5pemFa?= =?utf-8?B?b3k1U1Mzd00zSGVkOG91eWhxSFVsdnpJMHVvdDFLQk9NRXhoZ2lVdTN1ejJk?= =?utf-8?Q?ryNCZuBdID0d/D1LrJPDC71avr6TV+MHdB5IsOy?= X-MS-Exchange-CrossTenant-Network-Message-Id: e094c041-5f40-446e-3e59-08d8e21014f1 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 08:56:37.3047 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cqjExO6eszyLJZ5QjM7cuXjrj1C3K9g7WGi+6GUfxboEnQ0V43DszhyuF2f+WfOrYYI/faW+nptNj2s/oTiNJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3740 X-OriginatorOrg: citrix.com On Fri, Mar 05, 2021 at 10:50:34AM +0100, Jan Beulich wrote: > Prior to 4.15 Linux, when running in PV mode, did not install a #GP > handler early enough to cover for example the rdmsrl_safe() of > MSR_K8_TSEG_ADDR in bsp_init_amd() (not to speak of the unguarded read > of MSR_K7_HWCR later in the same function). The respective change > (42b3a4cb5609 "x86/xen: Support early interrupts in xen pv guests") was > backported to 4.14, but no further - presumably since it wasn't really > easy because of other dependencies. > > Therefore, to prevent our change in the handling of guest MSR accesses > to render PV Linux 4.13 and older unusable on at least AMD systems, make > the raising of #GP on this paths conditional upon the guest having > installed a handler, provided of course the MSR can be read in the first > place (we would have raised #GP in that case even before). Producing > zero for reads isn't necessarily correct and may trip code trying to > detect presence of MSRs early, but since such detection logic won't work > without a #GP handler anyway, this ought to be a fair workaround. > > Signed-off-by: Jan Beulich > --- > v2: Probe MSR read. Exclude hypervisor range. Avoid issuing two log > messages (in debug builds). Don't alter WRMSR behavior. > --- > I'm not convinced we can get away without also making the WRMSR path > somewhat more permissive again, e.g. tolerating attempts to set bits > which are already set. But of course this would require keeping in sync > for which MSRs we "fake" reads, as then a kernel attempt to set a bit > may also appear as an attempt to clear others (because of the zero value > that we gave it for the read). The above approach seems dangerous, as it could allow a guest to figure out the value of the underlying MSR by probing whether values trigger a #GP? I think we want to do something similar to what we do on HVM in 4.14 and previous versions: ignore writes as long as the rdmsr to the target MSR succeeds, regardless of the value. > > --- a/xen/arch/x86/pv/emul-priv-op.c > +++ b/xen/arch/x86/pv/emul-priv-op.c > @@ -874,7 +874,7 @@ static int read_msr(unsigned int reg, ui > struct vcpu *curr = current; > const struct domain *currd = curr->domain; > const struct cpuid_policy *cp = currd->arch.cpuid; > - bool vpmu_msr = false; > + bool vpmu_msr = false, warn = false; > int ret; > > if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) > @@ -882,7 +882,7 @@ static int read_msr(unsigned int reg, ui > if ( ret == X86EMUL_EXCEPTION ) > x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); > > - return ret; > + goto done; > } > > switch ( reg ) > @@ -986,7 +986,7 @@ static int read_msr(unsigned int reg, ui > } > /* fall through */ > default: > - gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); > + warn = true; > break; > > normal: > @@ -995,7 +995,19 @@ static int read_msr(unsigned int reg, ui > return X86EMUL_OKAY; > } > > - return X86EMUL_UNHANDLEABLE; > + done: Won't this handling be better placed in the 'default' switch case above? > + if ( ret != X86EMUL_OKAY && !curr->arch.pv.trap_ctxt[X86_EXC_GP].address && > + (reg >> 16) != 0x4000 && !rdmsr_safe(reg, *val) ) We didn't used to care about explicitly blocking the reserved MSR range, do we really wan to do it now? I'm not sure I see an issue with that, but given that we are trying to bring back something similar to the previous behavior, I would avoid adding new conditions. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 09:21:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 09:21:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94712.178262 (Exim 4.92) (envelope-from ) id 1lJC4M-0001vi-Lr; Mon, 08 Mar 2021 09:20:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94712.178262; Mon, 08 Mar 2021 09:20:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJC4M-0001vZ-EL; Mon, 08 Mar 2021 09:20:54 +0000 Received: by outflank-mailman (input) for mailman id 94712; Mon, 08 Mar 2021 09:20:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJC4K-0001vU-7z for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:20:52 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6b627013-9c27-483c-99fc-8c32e21ba96e; Mon, 08 Mar 2021 09:20:50 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F2755ACBF; Mon, 8 Mar 2021 09:20:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b627013-9c27-483c-99fc-8c32e21ba96e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615195250; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LIwEkBsM2st3pyBXXt8Lpc7E0hAhJaLbFVIrJwEUDe0=; b=YIw4NROJd93ktcDabx5+H6YN87+U+t5w/LUmymJSffDa6Vv+n41qrYEIIFoVd06sdhXW4a QgtN2rzGwy03zlL1p09bJCRg0Uldtx77sDGzrtz5GVwUXuI6SSUS6XZCScDMBVCO1Yr+PK 3cmqbraGbmduxsbB/cUuzWsg4jx8d5g= To: "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH 0/2] tools/x86: adjust populating of tools/include/xen/ Message-ID: Date: Mon, 8 Mar 2021 10:20:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit While the first change is a possible 4.15 candidate, the second is pure cleanup (but could, should patch 1 end up being controversial, also be re-based ahead). 1: don't rebuild cpuid-autogen.h every time 2: move arch-specific include/xen/ population into arch-specific rule Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 09:22:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 09:22:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94715.178274 (Exim 4.92) (envelope-from ) id 1lJC5d-00021M-T1; Mon, 08 Mar 2021 09:22:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94715.178274; Mon, 08 Mar 2021 09:22:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJC5d-00021E-PC; Mon, 08 Mar 2021 09:22:13 +0000 Received: by outflank-mailman (input) for mailman id 94715; Mon, 08 Mar 2021 09:22:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJC5d-000218-0A for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:22:13 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 314afd13-a55b-4dde-a39c-d5bbfb0002bc; Mon, 08 Mar 2021 09:22:11 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D3419AC54; Mon, 8 Mar 2021 09:22:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 314afd13-a55b-4dde-a39c-d5bbfb0002bc X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615195330; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MBPEIIF1GkKi/wEzrj3sY/FjwcZUTOVXQqJe8a6sZ7I=; b=POzOGYtBSbb+2Htpn0nR23n/YVEHsg76seL8gd2jcK2CDFy2ieAwfizkEYh7PZaRj7IX+m MVcq46rNI4vIUR80Y8B8OvcUYFaXEDyuW7IjuAT9k/pA3M5uxElm6hk9a4ZGOFkC+/Pf45 oAttEarzg+ed7MgmqXIWwrbNs2A5Iuc= Subject: [PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <336aaf51-f163-8ee7-d8ee-297f6f3052fd@suse.com> Date: Mon, 8 Mar 2021 10:22:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit The first thing the "xen-dir" rule does is delete the entire xen/ subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a result there's no original version for $(move-if-changed ...) to compare against, and hence the file and all its consumers would get rebuilt every time. Introduce a "prep-y" rule to move xen/lib/x86/ on the side, to then recover any *autogen.h from there prior to invoking the respective recursive $(MAKE) invocation. Fixes: eddf9559c977 ("libx86: generate cpuid-autogen.h in the libx86 include dir") Signed-off-by: Jan Beulich --- a/.gitignore +++ b/.gitignore @@ -234,6 +234,7 @@ tools/hotplug/NetBSD/rc.d/xendriverdomain tools/include/acpi tools/include/_libxl*.h +tools/include/.xen*/* tools/include/_xentoolcore_list.h tools/include/xen/* tools/include/xen-xsm/* --- a/tools/include/Makefile +++ b/tools/include/Makefile @@ -10,15 +10,15 @@ include $(XEN_ROOT)/tools/Rules.mk # Relative to $(XEN_ROOT)/xen/xsm/flask FLASK_H_DEPEND := policy/initial_sids -.PHONY: all all-y build xen-dir +.PHONY: all all-y build prep-y xen-dir all build: all-y xen-foreign xen-dir xen-xsm/.dir -all-y: +all-y prep-y: .PHONY: xen-foreign xen-foreign: $(MAKE) -C xen-foreign -xen-dir: +xen-dir: prep-y @rm -rf xen acpi mkdir -p xen/libelf acpi ln -s $(XEN_ROOT)/xen/include/public/COPYING xen/ @@ -36,7 +36,15 @@ ifeq ($(CONFIG_X86),y) ln -s $(XEN_ROOT)/xen/include/xen/lib/x86/Makefile xen/lib/x86/ endif +# Arrange for preserving of auto-generated headers (to avoid them getting +# rebuilt every time): Move the entire xen/lib/x86/ to a temporary place. +prep-$(CONFIG_X86): + rm -rf .xen-lib-x86 + test ! -d xen/lib/x86 || mv xen/lib/x86 .xen-lib-x86 + all-$(CONFIG_X86): xen-dir + $(if $(wildcard .xen-lib-x86/*autogen.h),mv .xen-lib-x86/*autogen.h xen/lib/x86/) + rm -rf .xen-lib-x86 $(MAKE) -C xen/lib/x86 all XEN_ROOT=$(XEN_ROOT) PYTHON=$(PYTHON) # Not xen/xsm as that clashes with link to @@ -78,7 +86,7 @@ uninstall: .PHONY: clean clean: - rm -rf xen xen-xsm acpi + rm -rf xen xen-xsm .xen* acpi $(MAKE) -C xen-foreign clean .PHONY: dist From xen-devel-bounces@lists.xenproject.org Mon Mar 08 09:22:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 09:22:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94717.178286 (Exim 4.92) (envelope-from ) id 1lJC64-000272-6A; Mon, 08 Mar 2021 09:22:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94717.178286; Mon, 08 Mar 2021 09:22:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJC64-00026v-23; Mon, 08 Mar 2021 09:22:40 +0000 Received: by outflank-mailman (input) for mailman id 94717; Mon, 08 Mar 2021 09:22:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJC63-00026T-59 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:22:39 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e2c4c53a-2167-4c79-9e0d-fecd377e3814; Mon, 08 Mar 2021 09:22:36 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AA7FFAC54; Mon, 8 Mar 2021 09:22:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2c4c53a-2167-4c79-9e0d-fecd377e3814 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615195355; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HM/JPFP9UxjelZCsGhQtKcxAk3Q+KDuvq+vWM6E/EQ0=; b=CC3I7zk/NMIE9et4xYaXnvRld+4D6MZJO+gcBp2/V7NgC7R4AD95+Bz5rWgPD0jbArUNWJ /aJmT2EHcGA/56qdo4JtJrU2BVDnetl0T58WsT9kZnrH6cnhJKrEpt8YHSKPJVVP9fGUtf YRv2mAHb8nfptZp65rfsd8v1R4vPR6g= Subject: [PATCH 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <0702c375-4769-7246-ba47-613ed69330e1@suse.com> Date: Mon, 8 Mar 2021 10:22:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit There's no need for the common "xen-dir" rule to have an arch-specific part when there already is a arch-specific rule where this can be taken care of. Signed-off-by: Jan Beulich --- I was tempted to also uniformly change the pattern from *autogen.h to *-autogen.h right here - thoughts? I was also tempted to move the "xen-dir" dependency from all-$(CONFIG_X86) to the general all-y, but perhaps that's less related and hence should really be a separate change (and there may also be arguments against that). --- a/tools/include/Makefile +++ b/tools/include/Makefile @@ -29,12 +29,6 @@ xen-dir: prep-y ln -s ../xen-foreign xen/foreign ln -s $(XEN_ROOT)/xen/include/acpi/platform acpi/ ln -s $(XEN_ROOT)/xen/include/acpi/ac*.h acpi/ -ifeq ($(CONFIG_X86),y) - ln -s $(XEN_ROOT)/xen/include/asm-x86 xen/asm - mkdir -p xen/lib/x86 - ln -s $(filter-out %autogen.h,$(wildcard $(XEN_ROOT)/xen/include/xen/lib/x86/*.h)) xen/lib/x86/ - ln -s $(XEN_ROOT)/xen/include/xen/lib/x86/Makefile xen/lib/x86/ -endif # Arrange for preserving of auto-generated headers (to avoid them getting # rebuilt every time): Move the entire xen/lib/x86/ to a temporary place. @@ -43,6 +37,10 @@ prep-$(CONFIG_X86): test ! -d xen/lib/x86 || mv xen/lib/x86 .xen-lib-x86 all-$(CONFIG_X86): xen-dir + ln -s $(XEN_ROOT)/xen/include/asm-x86 xen/asm + mkdir -p xen/lib/x86 + ln -s $(filter-out %autogen.h,$(wildcard $(XEN_ROOT)/xen/include/xen/lib/x86/*.h)) xen/lib/x86/ + ln -s $(XEN_ROOT)/xen/include/xen/lib/x86/Makefile xen/lib/x86/ $(if $(wildcard .xen-lib-x86/*autogen.h),mv .xen-lib-x86/*autogen.h xen/lib/x86/) rm -rf .xen-lib-x86 $(MAKE) -C xen/lib/x86 all XEN_ROOT=$(XEN_ROOT) PYTHON=$(PYTHON) From xen-devel-bounces@lists.xenproject.org Mon Mar 08 09:25:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 09:25:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94721.178298 (Exim 4.92) (envelope-from ) id 1lJC9F-0002Jg-Kc; Mon, 08 Mar 2021 09:25:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94721.178298; Mon, 08 Mar 2021 09:25:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJC9F-0002JZ-HU; Mon, 08 Mar 2021 09:25:57 +0000 Received: by outflank-mailman (input) for mailman id 94721; Mon, 08 Mar 2021 09:25:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJC9D-0002JU-V3 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:25:55 +0000 Received: from deinos.phlegethon.org (unknown [2001:41d0:8:b1d7::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 983a0b0b-2798-44a9-8445-efd91bb7f0ef; Mon, 08 Mar 2021 09:25:55 +0000 (UTC) Received: from tjd by deinos.phlegethon.org with local (Exim 4.92.3 (FreeBSD)) (envelope-from ) id 1lJC98-000DWw-Kb; Mon, 08 Mar 2021 09:25:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 983a0b0b-2798-44a9-8445-efd91bb7f0ef Date: Mon, 8 Mar 2021 09:25:50 +0000 From: Tim Deegan To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , George Dunlap , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Ian Jackson Subject: Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized Message-ID: References: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> X-SA-Known-Good: Yes X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tim@xen.org X-SA-Exim-Scanned: No (on deinos.phlegethon.org); SAEximRunCond expanded to false At 16:37 +0100 on 05 Mar (1614962224), Jan Beulich wrote: > We can't make correctness of our own behavior dependent upon a > hypervisor underneath us correctly telling us the true physical address > with hardware uses. Without knowing this, we can't be certain reserved > bit faults can actually be observed. Therefore, besides evaluating the > number of address bits when deciding whether to use the optimization, > also check whether we're running virtualized ourselves. > > Requested-by: Andrew Cooper > Signed-off-by: Jan Beulich Acked-by: Tim Deegan I would consider this to be a bug in the underlying hypervisor, but I agree than in practice it won't be safe to rely on it being correct. These checks are getting fiddly now. I think that if we end up adding any more to them it might be good to set a read-mostly variable at boot time rather than do them on every MMIO/NP fault. Cheers, Tim. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 09:33:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 09:33:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94724.178309 (Exim 4.92) (envelope-from ) id 1lJCGK-0003EP-Cb; Mon, 08 Mar 2021 09:33:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94724.178309; Mon, 08 Mar 2021 09:33:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCGK-0003EI-9p; Mon, 08 Mar 2021 09:33:16 +0000 Received: by outflank-mailman (input) for mailman id 94724; Mon, 08 Mar 2021 09:33:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCGI-0003ED-Ar for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:33:14 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ab5f8d97-6d98-48e9-a152-3508eec7d4b2; Mon, 08 Mar 2021 09:33:13 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AB0FCAC54; Mon, 8 Mar 2021 09:33:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab5f8d97-6d98-48e9-a152-3508eec7d4b2 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615195992; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oXB4itmC2qnNbufxt2cZxq8FU89mYhIiwkRvTXpCZn8=; b=sMlodLLa5OmRXlrkb5VIvnvXVmG3fYt5SfQ3XTKd3gt19b1GmPiELyLum5sgJY1LswthzL Qt4BbyxGdEGs686k0IG9usf+bH4apT/kFFm+Fq8ys8vED2ZwppikMRFO834cbdNLGwZzqn rTlZC+z84hYkTcCgzUbV8zhIEs64644= Subject: Re: [PATCH v2 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson References: From: Jan Beulich Message-ID: <1f19ced7-183b-8f08-3a90-c06039e053a6@suse.com> Date: Mon, 8 Mar 2021 10:33:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 08.03.2021 09:56, Roger Pau Monné wrote: > On Fri, Mar 05, 2021 at 10:50:34AM +0100, Jan Beulich wrote: >> Prior to 4.15 Linux, when running in PV mode, did not install a #GP >> handler early enough to cover for example the rdmsrl_safe() of >> MSR_K8_TSEG_ADDR in bsp_init_amd() (not to speak of the unguarded read >> of MSR_K7_HWCR later in the same function). The respective change >> (42b3a4cb5609 "x86/xen: Support early interrupts in xen pv guests") was >> backported to 4.14, but no further - presumably since it wasn't really >> easy because of other dependencies. >> >> Therefore, to prevent our change in the handling of guest MSR accesses >> to render PV Linux 4.13 and older unusable on at least AMD systems, make >> the raising of #GP on this paths conditional upon the guest having >> installed a handler, provided of course the MSR can be read in the first >> place (we would have raised #GP in that case even before). Producing >> zero for reads isn't necessarily correct and may trip code trying to >> detect presence of MSRs early, but since such detection logic won't work >> without a #GP handler anyway, this ought to be a fair workaround. >> >> Signed-off-by: Jan Beulich >> --- >> v2: Probe MSR read. Exclude hypervisor range. Avoid issuing two log >> messages (in debug builds). Don't alter WRMSR behavior. >> --- >> I'm not convinced we can get away without also making the WRMSR path >> somewhat more permissive again, e.g. tolerating attempts to set bits >> which are already set. But of course this would require keeping in sync >> for which MSRs we "fake" reads, as then a kernel attempt to set a bit >> may also appear as an attempt to clear others (because of the zero value >> that we gave it for the read). > > The above approach seems dangerous, as it could allow a guest to > figure out the value of the underlying MSR by probing whether values > trigger a #GP? Perhaps, yes. But what do you do? There's potentially a huge value range to probe ... > I think we want to do something similar to what we do on HVM in 4.14 > and previous versions: ignore writes as long as the rdmsr to the > target MSR succeeds, regardless of the value. Which, as said elsewhere, has its own downsides - writable MSRs don't need to also be readable. See e.g. AMD's proposed PARTIAL_{FS,GS}_LOAD MSRs. >> --- a/xen/arch/x86/pv/emul-priv-op.c >> +++ b/xen/arch/x86/pv/emul-priv-op.c >> @@ -874,7 +874,7 @@ static int read_msr(unsigned int reg, ui >> struct vcpu *curr = current; >> const struct domain *currd = curr->domain; >> const struct cpuid_policy *cp = currd->arch.cpuid; >> - bool vpmu_msr = false; >> + bool vpmu_msr = false, warn = false; >> int ret; >> >> if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) >> @@ -882,7 +882,7 @@ static int read_msr(unsigned int reg, ui >> if ( ret == X86EMUL_EXCEPTION ) >> x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); >> >> - return ret; >> + goto done; >> } >> >> switch ( reg ) >> @@ -986,7 +986,7 @@ static int read_msr(unsigned int reg, ui >> } >> /* fall through */ >> default: >> - gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); >> + warn = true; >> break; >> >> normal: >> @@ -995,7 +995,19 @@ static int read_msr(unsigned int reg, ui >> return X86EMUL_OKAY; >> } >> >> - return X86EMUL_UNHANDLEABLE; >> + done: > > Won't this handling be better placed in the 'default' switch case > above? No - see the "goto done" added near the top of the function. >> + if ( ret != X86EMUL_OKAY && !curr->arch.pv.trap_ctxt[X86_EXC_GP].address && >> + (reg >> 16) != 0x4000 && !rdmsr_safe(reg, *val) ) > > We didn't used to care about explicitly blocking the reserved MSR > range, do we really wan to do it now? > > I'm not sure I see an issue with that, but given that we are trying to > bring back something similar to the previous behavior, I would avoid > adding new conditions. What I'm particularly trying to avoid here is to allow information from an underlying hypervisor to "shine through", even if it's only information as to whether a certain MSR is readable. It should be solely our own selection which MSRs in this range a guest is able to (appear to) read. Plus of course by avoiding the rdmsr_safe() in this case we also avoid the unnecessary (debug only) log message associated with such attempted reads. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 09:40:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 09:40:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94727.178322 (Exim 4.92) (envelope-from ) id 1lJCMs-0003am-5M; Mon, 08 Mar 2021 09:40:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94727.178322; Mon, 08 Mar 2021 09:40:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCMs-0003a4-1W; Mon, 08 Mar 2021 09:40:02 +0000 Received: by outflank-mailman (input) for mailman id 94727; Mon, 08 Mar 2021 09:40:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCMr-0003VM-MT for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:40:01 +0000 Received: from deinos.phlegethon.org (unknown [2001:41d0:8:b1d7::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3b4785d2-222d-411b-8042-6d1140108d36; Mon, 08 Mar 2021 09:40:00 +0000 (UTC) Received: from tjd by deinos.phlegethon.org with local (Exim 4.92.3 (FreeBSD)) (envelope-from ) id 1lJCMo-000Dbx-LI; Mon, 08 Mar 2021 09:39:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b4785d2-222d-411b-8042-6d1140108d36 Date: Mon, 8 Mar 2021 09:39:58 +0000 From: Tim Deegan To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , George Dunlap , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Ian Jackson Subject: Re: [PATCH 2/2][4.15?] x86/shadow: encode full GFN in magic MMIO entries Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: X-SA-Known-Good: Yes X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tim@xen.org X-SA-Exim-Scanned: No (on deinos.phlegethon.org); SAEximRunCond expanded to false At 16:37 +0100 on 05 Mar (1614962265), Jan Beulich wrote: > Since we don't need to encode all of the PTE flags, we have enough bits > in the shadow entry to store the full GFN. Don't use literal numbers - > instead derive the involved values. Or, where derivation would become > too ugly, sanity-check the result (invoking #error to identify failure). > > This then allows dropping from sh_l1e_mmio() again the guarding against > too large GFNs. > > Signed-off-by: Jan Beulich Acked-by: Tim Deegan > I wonder if the respective check in sh_audit_l1_table() is actually > useful to retain with these changes. Yes, I think so. We care about these PTEs being bogus for any reason, not just the ones that this could address. > -#define SH_L1E_MAGIC 0xffffffff00000001ULL > +#define SH_L1E_MAGIC_NR_META_BITS 4 > +#define SH_L1E_MAGIC_MASK ((~0ULL << (PADDR_BITS - PAGE_SHIFT + \ > + SH_L1E_MAGIC_NR_META_BITS)) | \ > + _PAGE_PRESENT) I don't think this makes the code any more readable, TBH, but if you prefer it that's OK. I'd be happier with it if you added a BUILD_BUG_ON that checks that 1ULL << (PADDR_BITS - 1) is set in the mask, since that's the main thing we care about. > -#define SH_L1E_MMIO_MAGIC 0xffffffff00000001ULL > -#define SH_L1E_MMIO_MAGIC_MASK 0xffffffff00000009ULL > -#define SH_L1E_MMIO_GFN_MASK 0x00000000fffffff0ULL > +#define SH_L1E_MMIO_MAGIC SH_L1E_MAGIC_MASK > +#define SH_L1E_MMIO_MAGIC_BIT ((_PAGE_PRESENT | _PAGE_RW | _PAGE_USER) + 1) IMO this would be more readable as a straight 0x8 (or even _PAGE_PWT). The ack stands either way. Cheers, Tim. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 09:40:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 09:40:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94729.178334 (Exim 4.92) (envelope-from ) id 1lJCNE-0004G7-EM; Mon, 08 Mar 2021 09:40:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94729.178334; Mon, 08 Mar 2021 09:40:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCNE-0004G0-Ai; Mon, 08 Mar 2021 09:40:24 +0000 Received: by outflank-mailman (input) for mailman id 94729; Mon, 08 Mar 2021 09:40:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCND-0004Fo-K2 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:40:23 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f9434ce2-3aee-4e5c-89cd-e0f6fdc0375c; Mon, 08 Mar 2021 09:40:22 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F3298AC0C; Mon, 8 Mar 2021 09:40:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9434ce2-3aee-4e5c-89cd-e0f6fdc0375c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615196422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nbd8nnky1ZIeC2D3DGjHdwn8gQd4sUOAGX5EdLGcDOU=; b=Rk9d9zQ2/0YbjkerQgin9cwIGg7Glw9tk5U85qt2ZeFx7gs1VWI0doBY7XCgE1CPEbkAvr lnXvBqgvrnVSpy7Bp19CGknrpbXka+y/2JjIkLDjMDjxqXQ5cqYr5TC2Bs90ngBFr24JqK K5ghdJw2+0p02px5Y43B0OTKnoYd2nE= Subject: Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized To: Tim Deegan Cc: "xen-devel@lists.xenproject.org" , George Dunlap , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> From: Jan Beulich Message-ID: <1cfddc2f-4d89-0eea-0ce1-68978914c821@suse.com> Date: Mon, 8 Mar 2021 10:40:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 10:25, Tim Deegan wrote: > At 16:37 +0100 on 05 Mar (1614962224), Jan Beulich wrote: >> We can't make correctness of our own behavior dependent upon a >> hypervisor underneath us correctly telling us the true physical address >> with hardware uses. Without knowing this, we can't be certain reserved >> bit faults can actually be observed. Therefore, besides evaluating the >> number of address bits when deciding whether to use the optimization, >> also check whether we're running virtualized ourselves. >> >> Requested-by: Andrew Cooper >> Signed-off-by: Jan Beulich > > Acked-by: Tim Deegan Thanks. > I would consider this to be a bug in the underlying hypervisor, but I > agree than in practice it won't be safe to rely on it being correct. Suffice it to say that I don't think we present a correct value to our guests. Plus, as said elsewhere, what would you suggest to hand to the guest in case it may need migrating (to a host with a different number of PA bits)? > These checks are getting fiddly now. I think that if we end up adding > any more to them it might be good to set a read-mostly variable at boot > time rather than do them on every MMIO/NP fault. Maybe, but I'd like to point out that the fault path uses only the sh_l1e_is_*() functions (plus sh_l1e_mmio_get_gfn()), and hence isn't affected by the added fiddly-ness. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 09:44:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 09:44:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94736.178349 (Exim 4.92) (envelope-from ) id 1lJCRa-0004VH-5s; Mon, 08 Mar 2021 09:44:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94736.178349; Mon, 08 Mar 2021 09:44:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCRa-0004VA-2s; Mon, 08 Mar 2021 09:44:54 +0000 Received: by outflank-mailman (input) for mailman id 94736; Mon, 08 Mar 2021 09:44:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCRZ-0004V5-3h for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:44:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCRZ-0000w7-2v for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:44:53 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJCRZ-0002JG-21 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:44:53 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lJCRO-0007yq-5O; Mon, 08 Mar 2021 09:44:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=Aj0EJl06pIis/syNLPV8aPivy3Qr3YYxG+jlAI5iJvs=; b=TrdmLuzBNgDJk2s7ZmGpmZX8eU 2OTmewJOTbItl1xWklCtRvnx7n6oDR+cbu4vGglpwzxsSrgPYJObSyF76jqjoUJgxBbRG7g8EVxZ+ X4WtFA0VUu2YlNcuyvFQSAEnCqeGbPotJu4TO03UtzaIMYvaT2QbdpALsXtJ5IDqw9RY=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24645.61961.964574.269753@mariner.uk.xensource.com> Date: Mon, 8 Mar 2021 09:44:41 +0000 To: Julien Grall Cc: Jan Beulich , =?iso-8859-1?Q?J=FCrgen_Gro=DF?= , raphning@amazon.co.uk, Julien Grall , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() In-Reply-To: <0249af89-ced0-0f7f-d370-9ffade6b1678@xen.org> References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-3-julien@xen.org> <0994b7a0-c537-b312-b134-caf54c79c87f@suse.com> <74568cd7-143b-48ad-b9be-bf4229655376@suse.com> <7eb12174-3268-ccdb-df9c-c4fe23d3a332@xen.org> <24642.14600.124181.19574@mariner.uk.xensource.com> <0249af89-ced0-0f7f-d370-9ffade6b1678@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}()"): > Would the following comment work for you? > > /* Function pointer as xprintf() can be configured at runtime. */ > > I can fold it in my patch while committing. Sure, thanks. FTAOD Reviewed-by: Ian Jackson Release-Acked-by: Ian Jackson to that comment addition. Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 09:49:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 09:49:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94740.178362 (Exim 4.92) (envelope-from ) id 1lJCW4-0004hI-PJ; Mon, 08 Mar 2021 09:49:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94740.178362; Mon, 08 Mar 2021 09:49:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCW4-0004hB-Lp; Mon, 08 Mar 2021 09:49:32 +0000 Received: by outflank-mailman (input) for mailman id 94740; Mon, 08 Mar 2021 09:49:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCW3-0004h3-Dq; Mon, 08 Mar 2021 09:49:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCW3-00010s-5h; Mon, 08 Mar 2021 09:49:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCW2-0006Y6-OI; Mon, 08 Mar 2021 09:49:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJCW2-0007DB-Na; Mon, 08 Mar 2021 09:49:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cyvOiyqOgeqC5F1NVPL1ECLlq8vWZbRDNAIkvtN14rQ=; b=K9+0+mXymIdw/vVTSidqjzac0N ayJXqFwg+fIj9HUJdUvlxVGwyEwz4T6kjWJQ+2Wz3FkgbyZGj0udhI1wUJLnbikzGKwTGqwLR6DfV HjbFhT9/g2ieYqknHmFVhDq3yS1L0TuRc619+BKJqncq+omu2dQAz0rbJLHwwV808YRo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159861: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a38fd8748464831584a19438cbb3082b5a2dab15 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 08 Mar 2021 09:49:30 +0000 flight 159861 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159861/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-examine 4 memdisk-try-append fail pass in 159855 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux a38fd8748464831584a19438cbb3082b5a2dab15 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 219 days Failing since 152366 2020-08-01 20:49:34 Z 218 days 378 attempts Testing same since 159849 2021-03-06 18:14:24 Z 1 days 3 attempts ------------------------------------------------------------ 5153 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1275824 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 08 09:49:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 09:49:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94742.178377 (Exim 4.92) (envelope-from ) id 1lJCWC-0004mG-25; Mon, 08 Mar 2021 09:49:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94742.178377; Mon, 08 Mar 2021 09:49:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCWB-0004m8-Uj; Mon, 08 Mar 2021 09:49:39 +0000 Received: by outflank-mailman (input) for mailman id 94742; Mon, 08 Mar 2021 09:49:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCWB-0004lr-8c for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:49:39 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b73bc831-c621-4ecc-aa00-8229458990d7; Mon, 08 Mar 2021 09:49:38 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A4954AD21; Mon, 8 Mar 2021 09:49:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b73bc831-c621-4ecc-aa00-8229458990d7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615196977; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ASjIB1WECxkvx4naN608qGCch8AhKNLNoM+9i6cEs7c=; b=OBtOPGJnfGc+bFZWqsmbYj7G0IO0h+rUhKtA5xuOxTWff9Kd6S7jDEGomRtupVGkW4nbzE ZiSrBY+kLMZjjRtfYEKS5tlUpT0cG54EAZ6VicGsD0BFptZ9/0h/ZhcuSAGIoxYVs2yzRc aCyUh5Zl3UiJavhlr0gio40DP/20+xg= From: Jan Beulich Subject: preparations for 4.13.3 To: "xen-devel@lists.xenproject.org" Cc: George Dunlap , Stefano Stabellini , Ian Jackson , Wei Liu , Anthony Perard , Julien Grall Message-ID: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> Date: Mon, 8 Mar 2021 10:49:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit All, the release is overdue (my apologies). Please point out backports you find missing from the respective staging branches, but which you consider relevant. Ones that I have queued already, but which hadn't passed the push gate to master yet when doing a swipe late last week, are c6ad5a701b9a crypto: adjust rijndaelEncrypt() prototype for gcc11 9318fdf757ec x86/shadow: suppress "fast fault path" optimization without reserved bits 60c0444fae21 x86/shadow: suppress "fast fault path" optimization when running virtualized Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 09:49:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 09:49:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94743.178389 (Exim 4.92) (envelope-from ) id 1lJCWM-0004rO-A9; Mon, 08 Mar 2021 09:49:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94743.178389; Mon, 08 Mar 2021 09:49:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCWM-0004rF-6t; Mon, 08 Mar 2021 09:49:50 +0000 Received: by outflank-mailman (input) for mailman id 94743; Mon, 08 Mar 2021 09:49:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCWL-0004qv-Ar for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:49:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCWL-00011S-80 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:49:49 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJCWL-0002aO-6z for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:49:49 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lJCWH-000802-VS; Mon, 08 Mar 2021 09:49:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=PIRSPx7YkhOyrvCXOyzWue5jBQjQwXNmphb8ajewQmE=; b=xA59tDrgRND25cAbQ5yUHBckMW +RafSso2dNKA1xfFxLGI2FstQpS0fKPIOvie4B0qMsGEQlnLouwedFCDfS21TGkBxbzAL+5X6VsOk eMuQLc22HUrJwIOdYBvocLP9Cl4TGCEH2ibMiAHTqyuYm/7PjJkWbU1ygmvU1o4Wu8es=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24645.62265.765339.521102@mariner.uk.xensource.com> Date: Mon, 8 Mar 2021 09:49:45 +0000 To: Julien Grall Cc: xen-devel@lists.xenproject.org, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) In-Reply-To: <20210306214148.27021-1-julien@xen.org> References: <20210306214148.27021-1-julien@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("[PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64)"): > From: Julien Grall > > Compilers older than 4.8 have known codegen issues which can lead to > silent miscompilation: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 > > Furthermore, pre-4.9 GCC have known bugs (including things like > internal compiler errors on Arm) which would require workaround (I > haven't checked if we have any in Xen). > > The minimum version of GCC to build the hypervisor is now raised to 4.9. > > In addition to that, on arm64, GCC version >= 4.9 and < 5.1 have been > shown to emit memory references beyond the stack pointer, resulting in > memory corruption if an interrupt is taken after the stack pointer has > been adjusted but before the reference has been executed. > > Therefore, the minimum for arm64 is raised to 5.1. How sad. Release-Acked-by: Ian Jackson I don't currently have an opinion about the merits of this change. I'm hoping that the disagreement can be resolved without me having to have one :-). Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 09:52:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 09:52:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94754.178401 (Exim 4.92) (envelope-from ) id 1lJCZE-0005mR-Sf; Mon, 08 Mar 2021 09:52:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94754.178401; Mon, 08 Mar 2021 09:52:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCZE-0005mK-Ol; Mon, 08 Mar 2021 09:52:48 +0000 Received: by outflank-mailman (input) for mailman id 94754; Mon, 08 Mar 2021 09:52:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCZD-0005mF-Lu for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:52:47 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id d4367ea2-e658-49a7-9027-44d7a24a04d6; Mon, 08 Mar 2021 09:52:45 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 50F7D31B; Mon, 8 Mar 2021 01:52:45 -0800 (PST) Received: from e123311-lin.arm.com (unknown [10.57.16.174]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4E98D3F73C; Mon, 8 Mar 2021 01:52:43 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4367ea2-e658-49a7-9027-44d7a24a04d6 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com, wei.chen@arm.com Subject: [PATCH] arm: Add Kconfig entry to select CONFIG_DTB_FILE Date: Mon, 8 Mar 2021 10:52:33 +0100 Message-Id: <20210308095233.13329-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently in order to link existing DTB into Xen image we need to either specify option CONFIG_DTB_FILE on the command line or manually add it into .config. Add Kconfig entries: CONFIG_LINK_DTB and CONFIG_DTB_FILE to be able to select this option and provide the path to DTB we want to embed into Xen image. Signed-off-by: Michal Orzel --- xen/arch/arm/Makefile | 2 -- xen/common/Kconfig | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 16e6523e2c..104422960a 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -137,8 +137,6 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c xen.lds: xen.lds.S $(CPP) -P $(a_flags) -MQ $@ -o $@ $< -dtb.o: $(CONFIG_DTB_FILE) - .PHONY: clean clean:: rm -f asm-offsets.s xen.lds diff --git a/xen/common/Kconfig b/xen/common/Kconfig index eb953d171e..c032079c7e 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -400,6 +400,20 @@ config DOM0_MEM Leave empty if you are not sure what to specify. +config LINK_DTB + bool "Link DTB into Xen image" + depends on ARM + default n + +config DTB_FILE + string "Absolute path to device tree blob" + default "" + depends on LINK_DTB + ---help--- + When using a bootloader that has no device tree support or when there + is no bootloader at all, use this option to specify the absolute path + to a device tree that will be linked directly inside Xen binary. + config TRACEBUFFER bool "Enable tracing infrastructure" if EXPERT default y -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 09:59:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 09:59:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94758.178412 (Exim 4.92) (envelope-from ) id 1lJCfV-00062L-Ih; Mon, 08 Mar 2021 09:59:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94758.178412; Mon, 08 Mar 2021 09:59:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCfV-00062E-Fl; Mon, 08 Mar 2021 09:59:17 +0000 Received: by outflank-mailman (input) for mailman id 94758; Mon, 08 Mar 2021 09:59:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCfU-000626-9a for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:59:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCfU-0001CA-6c for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:59:16 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJCfU-0003Jy-5X for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 09:59:16 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lJCfQ-000840-Vp; Mon, 08 Mar 2021 09:59:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=hS7WocNRtbY6n5glaLixGXL1k1ubYQpB+jjlIlTtTXo=; b=GAw63nMZxezOPnNe6WOMGkLdXV kgw8/sKSC8WukTftUxMzfAGBJ8BtLG0YC2U2qWIVYoird37TveWkQ46IR8Niw0nxZZPWli0eHLmVN QMHe7aM+N60ItFesyrYAIC30Z/OoYfoSQlGrFhtkWd9mA7JGXc8bTDAaY+YViAD1Lo34=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24645.62832.737310.550811@mariner.uk.xensource.com> Date: Mon, 8 Mar 2021 09:59:12 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time In-Reply-To: <336aaf51-f163-8ee7-d8ee-297f6f3052fd@suse.com> References: <336aaf51-f163-8ee7-d8ee-297f6f3052fd@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time"): > The first thing the "xen-dir" rule does is delete the entire xen/ > subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a > result there's no original version for $(move-if-changed ...) to compare > against, and hence the file and all its consumers would get rebuilt > every time. Introduce a "prep-y" rule to move xen/lib/x86/ on the side, > to then recover any *autogen.h from there prior to invoking the > respective recursive $(MAKE) invocation. Urgh. Thanks for working on this swamp. However, > +# Arrange for preserving of auto-generated headers (to avoid them getting > +# rebuilt every time): Move the entire xen/lib/x86/ to a temporary place. > +prep-$(CONFIG_X86): > + rm -rf .xen-lib-x86 > + test ! -d xen/lib/x86 || mv xen/lib/x86 .xen-lib-x86 > + > all-$(CONFIG_X86): xen-dir > + $(if $(wildcard .xen-lib-x86/*autogen.h),mv .xen-lib-x86/*autogen.h xen/lib/x86/) > + rm -rf .xen-lib-x86 > $(MAKE) -C xen/lib/x86 all XEN_ROOT=$(XEN_ROOT) PYTHON=$(PYTHON) Isn't there some better way of doing this ? I am very wary of adding additional on-disk Makefile-managed state to a Makefile which is already going wrong. I haven't thought about this in enough detail to identify a specific bug but I think convincing myself that it is definitely correct is nontrivial. Perhaps we could do the removal with a find rune instead, so we can just skip the files we wanted to keep ? Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 10:00:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 10:00:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94761.178425 (Exim 4.92) (envelope-from ) id 1lJCh4-0006ur-UD; Mon, 08 Mar 2021 10:00:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94761.178425; Mon, 08 Mar 2021 10:00:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCh4-0006uj-Qj; Mon, 08 Mar 2021 10:00:54 +0000 Received: by outflank-mailman (input) for mailman id 94761; Mon, 08 Mar 2021 10:00:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCh4-0006ud-Cf for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 10:00:54 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ae46403a-4bbe-49f8-b85e-df41e2c4765d; Mon, 08 Mar 2021 10:00:53 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8C379ACBF; Mon, 8 Mar 2021 10:00:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae46403a-4bbe-49f8-b85e-df41e2c4765d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615197652; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q2SIrA5XRpg/FSGgWjrQL2AxlwffylmbxFH/5gTIJiw=; b=ZkcK1RoQsaA7SGrxo9qYdY+HsX+6fa5Ndi+pa711L6G17rfyHZep/xQG503W8HXOUX5yVa muWVBQMUt5Yd2AkkDsbeL7oDVDFIpgcuGrpXL56/u8oZceyQ1XEHzfTKx8zUuqn8OqyomH Qkea6Gg/zB3ekwmSohapUM8LjWEDJ+o= Subject: Re: [PATCH] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, wei.chen@arm.com, xen-devel@lists.xenproject.org References: <20210308095233.13329-1-michal.orzel@arm.com> From: Jan Beulich Message-ID: <3709714b-6627-3c66-b8ca-4cb9c59df83b@suse.com> Date: Mon, 8 Mar 2021 11:00:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210308095233.13329-1-michal.orzel@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 10:52, Michal Orzel wrote: > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -400,6 +400,20 @@ config DOM0_MEM > > Leave empty if you are not sure what to specify. > > +config LINK_DTB > + bool "Link DTB into Xen image" > + depends on ARM > + default n I don't think this last line is needed. > +config DTB_FILE > + string "Absolute path to device tree blob" > + default "" > + depends on LINK_DTB > + ---help--- > + When using a bootloader that has no device tree support or when there > + is no bootloader at all, use this option to specify the absolute path > + to a device tree that will be linked directly inside Xen binary. How is selecting LINK_DTB but leaving DTB_FILE at an empty string different from not having a LINK_DTB setting at all? Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 10:01:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 10:01:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94762.178437 (Exim 4.92) (envelope-from ) id 1lJChB-0006xo-5I; Mon, 08 Mar 2021 10:01:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94762.178437; Mon, 08 Mar 2021 10:01:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJChB-0006xg-20; Mon, 08 Mar 2021 10:01:01 +0000 Received: by outflank-mailman (input) for mailman id 94762; Mon, 08 Mar 2021 10:01:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJChA-0006xL-4M for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 10:01:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJChA-0001Jh-2Z for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 10:01:00 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJChA-0003aI-1c for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 10:01:00 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lJCh6-00084b-Rn; Mon, 08 Mar 2021 10:00:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=shga8WJTVY4hizujX61kvSw0TK7deinpbnpxBhVRXEY=; b=FQy+1eiHOjuW8OmQpyo4idXuqL dHiPwmc98DQXfGRXxPSohQyMDFPT7sGRssqSLb5d/TXyog8V229BI0Id1XwAXX8qVSFY5HMNVCAvu zznUWKHEsG77lKXEbZyWL8NIz3mdSyy+eps1aSHY/XmhvIuX6+CGVFr/4s2fL/KCblkM=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24645.62936.623189.553418@mariner.uk.xensource.com> Date: Mon, 8 Mar 2021 10:00:56 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule In-Reply-To: <0702c375-4769-7246-ba47-613ed69330e1@suse.com> References: <0702c375-4769-7246-ba47-613ed69330e1@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule"): > There's no need for the common "xen-dir" rule to have an arch-specific > part when there already is a arch-specific rule where this can be taken > care of. I think the symlinks being made in this arch-specific code are more logically part of the xen-dir target than part of the all target. > I was tempted to also uniformly change the pattern from *autogen.h to > *-autogen.h right here - thoughts? I haven't read this in enough detail to know whether that's right, but if it is right it is IMO preferable. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 10:08:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 10:08:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94767.178448 (Exim 4.92) (envelope-from ) id 1lJCoI-0007H6-Tf; Mon, 08 Mar 2021 10:08:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94767.178448; Mon, 08 Mar 2021 10:08:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCoI-0007Gz-QG; Mon, 08 Mar 2021 10:08:22 +0000 Received: by outflank-mailman (input) for mailman id 94767; Mon, 08 Mar 2021 10:08:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCoH-0007Go-W9 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 10:08:22 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bdfe8175-2bef-40ab-a75e-2465cf0d18ec; Mon, 08 Mar 2021 10:08:21 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 516C2AD21; Mon, 8 Mar 2021 10:08:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bdfe8175-2bef-40ab-a75e-2465cf0d18ec X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615198100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8igKPNfpqU7zE7zUDr+iOm2x4LW/QFrThygf8LahdfI=; b=ddociSuUtZky4Mz7K6RTWL4yGeYkGnK2Oiul2eDhMnPkv1T1Vl4CKZqfgwSzoR2Q+J14b8 cQ8fiZ+U8hvzE8JrXAodW6RXO4KIAUqaeF4qdZSOqRG10RpY9mwO8cHi0BK4UoHsUPgU8f YQbaOdKKGF/TcKsDbgk6odNrPTaKlaQ= Subject: Re: [PATCH 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule To: Ian Jackson Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <0702c375-4769-7246-ba47-613ed69330e1@suse.com> <24645.62936.623189.553418@mariner.uk.xensource.com> From: Jan Beulich Message-ID: Date: Mon, 8 Mar 2021 11:08:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24645.62936.623189.553418@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 11:00, Ian Jackson wrote: > Jan Beulich writes ("[PATCH 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule"): >> There's no need for the common "xen-dir" rule to have an arch-specific >> part when there already is a arch-specific rule where this can be taken >> care of. > > I think the symlinks being made in this arch-specific code are more > logically part of the xen-dir target than part of the all target. But that's true of what has been in all-$(CONFIG_X86) as well, isn't it? It's all about populating xen/. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 10:11:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 10:11:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94770.178461 (Exim 4.92) (envelope-from ) id 1lJCrg-00087U-EY; Mon, 08 Mar 2021 10:11:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94770.178461; Mon, 08 Mar 2021 10:11:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCrg-00087N-9V; Mon, 08 Mar 2021 10:11:52 +0000 Received: by outflank-mailman (input) for mailman id 94770; Mon, 08 Mar 2021 10:11:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJCre-00087I-UX for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 10:11:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 88c33625-aa54-43b9-bb97-0d3e7c6a059c; Mon, 08 Mar 2021 10:11:50 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9D0DCAD2B; Mon, 8 Mar 2021 10:11:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88c33625-aa54-43b9-bb97-0d3e7c6a059c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615198309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5OzLj4QXNSpZrTHaRZIstJsSe0VXvno7tdOhinkMqzc=; b=VMSGTbwE7tTvyMf/HzMXqpRBdZPXnjF6nn8SI58V4a3v9m+4uA+ObYEym3dkbVkO1ikD16 XUUKyOjLchsYcL+yANns4OYHpZPMuSkYwxJbNfMsZXMlmuqJkyFRuqByFU4QijEuv7IAIn v9iXtVzeP4b6Ml14udrY58efxHsYaSo= Subject: Re: [PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time To: Ian Jackson Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <336aaf51-f163-8ee7-d8ee-297f6f3052fd@suse.com> <24645.62832.737310.550811@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <2857440d-058f-5c85-32d3-87e2fe65bb9a@suse.com> Date: Mon, 8 Mar 2021 11:11:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24645.62832.737310.550811@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 10:59, Ian Jackson wrote: > Jan Beulich writes ("[PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time"): >> The first thing the "xen-dir" rule does is delete the entire xen/ >> subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a >> result there's no original version for $(move-if-changed ...) to compare >> against, and hence the file and all its consumers would get rebuilt >> every time. Introduce a "prep-y" rule to move xen/lib/x86/ on the side, >> to then recover any *autogen.h from there prior to invoking the >> respective recursive $(MAKE) invocation. > > Urgh. Thanks for working on this swamp. > > However, > >> +# Arrange for preserving of auto-generated headers (to avoid them getting >> +# rebuilt every time): Move the entire xen/lib/x86/ to a temporary place. >> +prep-$(CONFIG_X86): >> + rm -rf .xen-lib-x86 >> + test ! -d xen/lib/x86 || mv xen/lib/x86 .xen-lib-x86 >> + >> all-$(CONFIG_X86): xen-dir >> + $(if $(wildcard .xen-lib-x86/*autogen.h),mv .xen-lib-x86/*autogen.h xen/lib/x86/) >> + rm -rf .xen-lib-x86 >> $(MAKE) -C xen/lib/x86 all XEN_ROOT=$(XEN_ROOT) PYTHON=$(PYTHON) > > Isn't there some better way of doing this ? I am very wary of adding > additional on-disk Makefile-managed state to a Makefile which is > already going wrong. I haven't thought about this in enough detail to > identify a specific bug but I think convincing myself that it is > definitely correct is nontrivial. > > Perhaps we could do the removal with a find rune instead, so we can > just skip the files we wanted to keep ? Maybe, and I did consider the option, but it would have felt more fragile to me than this dedicated keep-just-the-few-files approach. The problems we've had with this symlinking don't make me confident in leaving around parts of this subtree; populating from scratch seems like the most robust model (short of the suggested but never carried out removal of the symlinking) to me. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 10:51:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 10:51:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94777.178473 (Exim 4.92) (envelope-from ) id 1lJDUD-0003F1-9u; Mon, 08 Mar 2021 10:51:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94777.178473; Mon, 08 Mar 2021 10:51:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJDUD-0003Eu-4u; Mon, 08 Mar 2021 10:51:41 +0000 Received: by outflank-mailman (input) for mailman id 94777; Mon, 08 Mar 2021 10:51:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJDUB-0003Ep-Cw for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 10:51:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJDUA-00029c-2E; Mon, 08 Mar 2021 10:51:38 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJDU9-0007Au-Mf; Mon, 08 Mar 2021 10:51:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=qZeSIqQlVyEh+3fMUUbvh/i1O0jC0h6wAh0YIwvYO5I=; b=PLIsqYR3aonaeoQtu9SMj9t0fw IeRUOFjKNFFCBTTBgvCEWX6C1AXYaS+DBlrVe9MA6RSlcvFg4VJPk8R56iJUNWE+ra+FoKGPJ4/yF xZCwenDQVEyy9JUFVmsTO7NzA9zoWmO5zbBeHYhMCL+LC7E/V7eUAAZIKocRS8JjwxHk=; Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) To: Jan Beulich Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210306214148.27021-1-julien@xen.org> <1897022d-7591-3450-4e57-884a2860b13d@suse.com> From: Julien Grall Message-ID: <7fd07dc9-9c03-bb13-3907-c3c268a4e970@xen.org> Date: Mon, 8 Mar 2021 10:51:34 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <1897022d-7591-3450-4e57-884a2860b13d@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 08/03/2021 08:09, Jan Beulich wrote: > On 06.03.2021 22:41, Julien Grall wrote: >> From: Julien Grall >> >> Compilers older than 4.8 have known codegen issues which can lead to >> silent miscompilation: >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 >> >> Furthermore, pre-4.9 GCC have known bugs (including things like >> internal compiler errors on Arm) which would require workaround (I >> haven't checked if we have any in Xen). >> >> The minimum version of GCC to build the hypervisor is now raised to 4.9. >> >> In addition to that, on arm64, GCC version >= 4.9 and < 5.1 have been >> shown to emit memory references beyond the stack pointer, resulting in >> memory corruption if an interrupt is taken after the stack pointer has >> been adjusted but before the reference has been executed. >> >> Therefore, the minimum for arm64 is raised to 5.1. > > I'm sure newer compiler versions also have bugs. I don't doubt that... > Therefore I'm not > convinced using this as the primary reason for a bump is enough. You also have to take into account the severity of the bug and possible workaround. The bug in 5.1 is severe *and* has no easy (to avoid saying possible) workaround. > Plus what if critical to us bugs get found in, say, 5.x? Are we > going to bump to 6.x then (and so on, until we allow only the most > recent major version to be used)? In the current situation we are claiming that all GCC versions from ~2014 are supported. However, in reality, there are an high number of chance that some of the version will not build Xen or worse miscompile it. The former kind of bug is not a big deal because the user will notice it directly. However, the latter is highly critical because 1) They may only happen sporadically 2) compiler related bug is difficult to root cause. So I think a smaller set of version is going to be better for the users and for us long term. > > Additionally - partly related to your own reply regarding the CI > failures - imo there needs to be an analysis of what older distros > will no longer build (at all or by default). Per the CI, this would be Ubuntu Trusty (and older), Centos 7 (and older) Do you have any other in mind? > We've been discussing > to bump minimum tool chain versions for a long time. At least as > far as I'm concerned, I didn't take on this job precisely because > the code changes needed are relatively simple, but justification > can (and apparently will) be rather complicated. > > Fundamentally, whatever kind of criteria we use to justify the > bump now ought to be usable down the road by people justifying > further bumps. I see you mentioned about distros. Can you outline other criteria you have in mind? > > Also - what about clang? Linux requires 10.0.1 as a minimum. I don't know and I would rather focus on GCC first so we figure out a set of criterias... > >> --- >> >> I don't have a strong opinion on the minimum version for GCC on x86. >> So this is following Andrew's suggestion and the minimum from Linux. >> >> This patch is candidate to 4.15 and backport. > > I think such a change needs to be proposed much earlier in a release > cycle. Possibly... At the same time, we don't want to release 4.15 and continue to say Xen on Arm64 can build fine with 4.9 and 5.0. > >> --- a/README >> +++ b/README >> @@ -38,12 +38,15 @@ provided by your OS distributor: >> * GNU Make v3.80 or later >> * C compiler and linker: >> - For x86: >> - - GCC 4.1.2_20070115 or later >> + - GCC 4.9 or later >> - GNU Binutils 2.16.91.0.5 or later > > I don't think it makes much sense to keep the binutils version this > low, the more that I don't think we can really build (correctly) > with this old a version anymore. Whatever the gcc version chosen, I > think we want to pick a binutils version from about the same time > frame. Ok. Let's first agree on a GCC version and then we can decide on a binutils version. > >> --- a/xen/include/xen/compiler.h >> +++ b/xen/include/xen/compiler.h >> @@ -5,6 +5,19 @@ >> #error Sorry, your compiler is too old/not recognized. >> #endif >> >> +#if CONFIG_CC_IS_GCC >> +# if CONFIG_GCC_VERSION < 40900 >> +/* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ > > As per the bug report, the issue was determined to not be present > in e.g. 4.3. Hence while such a bug may influence our choice of > minimum version, I don't think it can reasonably be named here as > the apparent only reason for the choice. Personally I don't think > any justification should be put here. Ok. > >> +# error Sorry, your version of GCC is too old - please use 4.9 or newer. >> +# elif defined(CONFIG_ARM_64) && CONFIG_GCC_VERSION < 50100 >> +/* >> + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 >> + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk >> + */ >> +# error Sorry, your version of GCC is too old - please use 5.1 or newer. > > From the bug entry the fix looks to have been backported to 4.9, > or at least some (important?) branches thereof. It is not clear what's you are trying to point out. Mind clarifying? > >> +# endif >> +#endif > > Instead of a completely new conditional, I think this wants to be > combined with the existing one (the tail of which is visible in > context above). OK. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Mar 08 11:02:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 11:02:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94784.178485 (Exim 4.92) (envelope-from ) id 1lJDeb-0004HE-E3; Mon, 08 Mar 2021 11:02:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94784.178485; Mon, 08 Mar 2021 11:02:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJDeb-0004H7-9s; Mon, 08 Mar 2021 11:02:25 +0000 Received: by outflank-mailman (input) for mailman id 94784; Mon, 08 Mar 2021 11:02:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJDeZ-0004H1-7S for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 11:02:23 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 35058a59-1e8c-4be3-989d-2ad9de6f85bc; Mon, 08 Mar 2021 11:02:22 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C985AD6E; Mon, 8 Mar 2021 03:02:21 -0800 (PST) Received: from [10.57.16.174] (unknown [10.57.16.174]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E8B293F73C; Mon, 8 Mar 2021 03:02:19 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35058a59-1e8c-4be3-989d-2ad9de6f85bc Subject: Re: [PATCH] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, wei.chen@arm.com, xen-devel@lists.xenproject.org References: <20210308095233.13329-1-michal.orzel@arm.com> <3709714b-6627-3c66-b8ca-4cb9c59df83b@suse.com> From: Michal Orzel Message-ID: Date: Mon, 8 Mar 2021 12:02:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <3709714b-6627-3c66-b8ca-4cb9c59df83b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Jan, On 08.03.2021 11:00, Jan Beulich wrote: > On 08.03.2021 10:52, Michal Orzel wrote: >> --- a/xen/common/Kconfig >> +++ b/xen/common/Kconfig >> @@ -400,6 +400,20 @@ config DOM0_MEM >> >> Leave empty if you are not sure what to specify. >> >> +config LINK_DTB >> + bool "Link DTB into Xen image" >> + depends on ARM >> + default n > > I don't think this last line is needed. > I agree. I can fix it. >> +config DTB_FILE >> + string "Absolute path to device tree blob" >> + default "" >> + depends on LINK_DTB >> + ---help--- >> + When using a bootloader that has no device tree support or when there >> + is no bootloader at all, use this option to specify the absolute path >> + to a device tree that will be linked directly inside Xen binary. > > How is selecting LINK_DTB but leaving DTB_FILE at an empty string > different from not having a LINK_DTB setting at all? > LINK_DTB acts as a switch to allow setting the dtb path. Not having LINK_DTB option will result in a build failure each time the user does not want to embed dtb into Xen(DTB_FILE is empty). I do not see why someone would want to select LINK_DTB leaving DTB_FILE as an empty string. > Jan > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Mon Mar 08 11:08:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 11:08:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94791.178497 (Exim 4.92) (envelope-from ) id 1lJDkZ-0004Vp-45; Mon, 08 Mar 2021 11:08:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94791.178497; Mon, 08 Mar 2021 11:08:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJDkZ-0004Vi-0d; Mon, 08 Mar 2021 11:08:35 +0000 Received: by outflank-mailman (input) for mailman id 94791; Mon, 08 Mar 2021 11:08:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJDkX-0004VN-LB for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 11:08:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJDkX-0002U9-Hc for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 11:08:33 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJDkX-0008Oc-Fi for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 11:08:33 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lJDkU-0008GO-9e; Mon, 08 Mar 2021 11:08:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=G0jnC+juXaoCrcEzUFwQ0Gp3JTZ8lEpZKSNrQBbkRjI=; b=C4bNndOE3Vw+5RPdNgapnl/12K wrS0HncVmg31YddOi+NTJBRRM8eBvm4Gy8G3WkkMj7BvASasYaMg0b1+UoL4v3tar03SHnHQzHKp/ IWEj+yjz3S+gFwQGeMmmbUzd4ECnSQEUVqm52JqLRPHvAJONw4MXrZTZfzeVYzj0nEes=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24646.1454.55437.250075@mariner.uk.xensource.com> Date: Mon, 8 Mar 2021 11:08:30 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time In-Reply-To: <2857440d-058f-5c85-32d3-87e2fe65bb9a@suse.com> References: <336aaf51-f163-8ee7-d8ee-297f6f3052fd@suse.com> <24645.62832.737310.550811@mariner.uk.xensource.com> <2857440d-058f-5c85-32d3-87e2fe65bb9a@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time"): > On 08.03.2021 10:59, Ian Jackson wrote: > > Jan Beulich writes ("[PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time"): > >> +# Arrange for preserving of auto-generated headers (to avoid them getting > >> +# rebuilt every time): Move the entire xen/lib/x86/ to a temporary place. > >> +prep-$(CONFIG_X86): > >> + rm -rf .xen-lib-x86 > >> + test ! -d xen/lib/x86 || mv xen/lib/x86 .xen-lib-x86 > >> + > >> all-$(CONFIG_X86): xen-dir > >> + $(if $(wildcard .xen-lib-x86/*autogen.h),mv .xen-lib-x86/*autogen.h xen/lib/x86/) > >> + rm -rf .xen-lib-x86 > >> $(MAKE) -C xen/lib/x86 all XEN_ROOT=$(XEN_ROOT) PYTHON=$(PYTHON) > > > > Isn't there some better way of doing this ? I am very wary of adding > > additional on-disk Makefile-managed state to a Makefile which is > > already going wrong. I haven't thought about this in enough detail to > > identify a specific bug but I think convincing myself that it is > > definitely correct is nontrivial. > > > > Perhaps we could do the removal with a find rune instead, so we can > > just skip the files we wanted to keep ? > > Maybe, and I did consider the option, but it would have felt more > fragile to me than this dedicated keep-just-the-few-files approach. > The problems we've had with this symlinking don't make me confident > in leaving around parts of this subtree; populating from scratch > seems like the most robust model (short of the suggested but never > carried out removal of the symlinking) to me. I'm confused by your reply. You aren't confident "leaving around parts of this subtree" but you are happy to move it aside and put it back, which seems equivalent. I don't understand why you think the latter would be more reliable. It seems to me that a find rune which deletes individual files can be at least as specific as your current wildcard and mv approach. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 11:20:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 11:20:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94794.178508 (Exim 4.92) (envelope-from ) id 1lJDvk-0006AE-3r; Mon, 08 Mar 2021 11:20:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94794.178508; Mon, 08 Mar 2021 11:20:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJDvk-0006A7-0d; Mon, 08 Mar 2021 11:20:08 +0000 Received: by outflank-mailman (input) for mailman id 94794; Mon, 08 Mar 2021 11:20:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJDvi-0006A2-Qa for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 11:20:06 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 21a64be6-7ee9-48aa-a480-f6700f8b75c8; Mon, 08 Mar 2021 11:20:05 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BE882AC54; Mon, 8 Mar 2021 11:20:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21a64be6-7ee9-48aa-a480-f6700f8b75c8 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615202404; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F0CbNfN949etSGrFP7I23PA2Zv6dalfgrEIR5gnIG6w=; b=C+6laaMQ30EO5Ncrh3FaPxndK2BISHGd2sZmdlTAlgmyGksf4QMOUHE8NF3t9W8cD1lt0O qxLtKeRnTTB3/RvDJxUA4Gj/LgiqS0rAYn6eVtqhVSI6fUiO/cEQjNVxqNWH4zGuPgYIBe DaGgPvB+fVsLqNQ43ZuZOXquP1y5bUU= Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) To: Julien Grall Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210306214148.27021-1-julien@xen.org> <1897022d-7591-3450-4e57-884a2860b13d@suse.com> <7fd07dc9-9c03-bb13-3907-c3c268a4e970@xen.org> From: Jan Beulich Message-ID: <2de5160f-8636-5cdf-a20c-acaa2640c893@suse.com> Date: Mon, 8 Mar 2021 12:20:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <7fd07dc9-9c03-bb13-3907-c3c268a4e970@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 11:51, Julien Grall wrote: > On 08/03/2021 08:09, Jan Beulich wrote: >> On 06.03.2021 22:41, Julien Grall wrote: >>> From: Julien Grall >>> >>> Compilers older than 4.8 have known codegen issues which can lead to >>> silent miscompilation: >>> >>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 >>> >>> Furthermore, pre-4.9 GCC have known bugs (including things like >>> internal compiler errors on Arm) which would require workaround (I >>> haven't checked if we have any in Xen). >>> >>> The minimum version of GCC to build the hypervisor is now raised to 4.9. >>> >>> In addition to that, on arm64, GCC version >= 4.9 and < 5.1 have been >>> shown to emit memory references beyond the stack pointer, resulting in >>> memory corruption if an interrupt is taken after the stack pointer has >>> been adjusted but before the reference has been executed. >>> >>> Therefore, the minimum for arm64 is raised to 5.1. >> >> I'm sure newer compiler versions also have bugs. > > I don't doubt that... > >> Therefore I'm not >> convinced using this as the primary reason for a bump is enough. > You also have to take into account the severity of the bug and possible > workaround. The bug in 5.1 is severe *and* has no easy (to avoid saying > possible) workaround. > >> Plus what if critical to us bugs get found in, say, 5.x? Are we >> going to bump to 6.x then (and so on, until we allow only the most >> recent major version to be used)? > > In the current situation we are claiming that all GCC versions from > ~2014 are supported. > > However, in reality, there are an high number of chance that some of the > version will not build Xen or worse miscompile it. > > The former kind of bug is not a big deal because the user will notice it > directly. However, the latter is highly critical because 1) They may > only happen sporadically 2) compiler related bug is difficult to root cause. Since I realize it may not have been clear from my initial reply: What you want to do for Arm64 is largely up to you. I agree that the bug in question is really bad. I understand it was Andrew who asked you to cover x86 at the same time, so perhaps it should be more him than you to justify the choice. Yet you've submitted the patch, so (I'm sorry) there you go ... >> Additionally - partly related to your own reply regarding the CI >> failures - imo there needs to be an analysis of what older distros >> will no longer build (at all or by default). > > Per the CI, this would be Ubuntu Trusty (and older), Centos 7 (and older) > > Do you have any other in mind? Our SLE12 (latest service pack is SP5 and still has a while to go to at least reach LTSS state) comes with gcc 4.8 as the default compiler. >>> --- >>> >>> I don't have a strong opinion on the minimum version for GCC on x86. >>> So this is following Andrew's suggestion and the minimum from Linux. >>> >>> This patch is candidate to 4.15 and backport. >> >> I think such a change needs to be proposed much earlier in a release >> cycle. > > Possibly... At the same time, we don't want to release 4.15 and continue > to say Xen on Arm64 can build fine with 4.9 and 5.0. 4.9 could be excluded if need be. 4.8 is fine? Also I don't think there's much point thinking about 5.0 - that's where their version numbering scheme changed and the first released version is 5.1. >>> --- a/xen/include/xen/compiler.h >>> +++ b/xen/include/xen/compiler.h >>> @@ -5,6 +5,19 @@ >>> #error Sorry, your compiler is too old/not recognized. >>> #endif >>> >>> +#if CONFIG_CC_IS_GCC >>> +# if CONFIG_GCC_VERSION < 40900 >>> +/* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ >> >> As per the bug report, the issue was determined to not be present >> in e.g. 4.3. Hence while such a bug may influence our choice of >> minimum version, I don't think it can reasonably be named here as >> the apparent only reason for the choice. Personally I don't think >> any justification should be put here. > > Ok. > >> >>> +# error Sorry, your version of GCC is too old - please use 4.9 or newer. >>> +# elif defined(CONFIG_ARM_64) && CONFIG_GCC_VERSION < 50100 >>> +/* >>> + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 >>> + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk >>> + */ >>> +# error Sorry, your version of GCC is too old - please use 5.1 or newer. >> >> From the bug entry the fix looks to have been backported to 4.9, >> or at least some (important?) branches thereof. > > It is not clear what's you are trying to point out. Mind clarifying? Some 4.9 compilers (perhaps widely used ones) may not have the bad issue, which puts under question their ruling out when the main reason for doing so is that bug. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 11:28:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 11:28:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94799.178521 (Exim 4.92) (envelope-from ) id 1lJE47-0006Qp-Tm; Mon, 08 Mar 2021 11:28:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94799.178521; Mon, 08 Mar 2021 11:28:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJE47-0006Qi-Qq; Mon, 08 Mar 2021 11:28:47 +0000 Received: by outflank-mailman (input) for mailman id 94799; Mon, 08 Mar 2021 11:28:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJE46-0006Qd-Aa for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 11:28:46 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a043af92-f18b-4561-aad8-7a63befbd7a1; Mon, 08 Mar 2021 11:28:45 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 943C3AC0C; Mon, 8 Mar 2021 11:28:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a043af92-f18b-4561-aad8-7a63befbd7a1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615202924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ouI8LPsBHyY+4ZE+IepA+KITvpShdC3ToQh5zmV3/Co=; b=gfdd0bqkg8mBe7hO2c7oOY4vtRe7VcBXBImDoRtva/OAkgrMzmmpnawUdgg10jc8E1Crls BCnnmoJyL1m3ocKi6Pctrt5nvn4Po3XmdE3FuLaWwJqEp82RFmq0ID8x1iMW3/4IuRo1F+ g3MnZV6XsIyRP56K/yHDr/eSz4US9/s= Subject: Re: [PATCH] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, wei.chen@arm.com, xen-devel@lists.xenproject.org References: <20210308095233.13329-1-michal.orzel@arm.com> <3709714b-6627-3c66-b8ca-4cb9c59df83b@suse.com> From: Jan Beulich Message-ID: Date: Mon, 8 Mar 2021 12:28:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 12:02, Michal Orzel wrote: > On 08.03.2021 11:00, Jan Beulich wrote: >> On 08.03.2021 10:52, Michal Orzel wrote: >>> +config DTB_FILE >>> + string "Absolute path to device tree blob" >>> + default "" >>> + depends on LINK_DTB >>> + ---help--- >>> + When using a bootloader that has no device tree support or when there >>> + is no bootloader at all, use this option to specify the absolute path >>> + to a device tree that will be linked directly inside Xen binary. >> >> How is selecting LINK_DTB but leaving DTB_FILE at an empty string >> different from not having a LINK_DTB setting at all? >> > LINK_DTB acts as a switch to allow setting the dtb path. Not having LINK_DTB option will result in > a build failure each time the user does not want to embed dtb into Xen(DTB_FILE is empty). Which isn't any different from having LINK_DTB and leaving the string empty, is it? I.e. imo no improved user experience. > I do not see why someone would want to select LINK_DTB leaving DTB_FILE as an empty string. People may not "want" to, but simply think accepting the default is fine, considering they've already said to link in some DTB. It may be obvious to you that there's no good default here, but it may not be to the person configuring their Xen. I'm guessing here, but did you try leaving out the default line? Would this make kconfig insist on the person to type in something? (Likely an empty string would still be accepted. As would be a relative path, despite what the help text says; I guess some forms of relative paths may even work.) Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 11:34:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 11:34:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94802.178532 (Exim 4.92) (envelope-from ) id 1lJE9r-0007KN-Jv; Mon, 08 Mar 2021 11:34:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94802.178532; Mon, 08 Mar 2021 11:34:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJE9r-0007KG-GL; Mon, 08 Mar 2021 11:34:43 +0000 Received: by outflank-mailman (input) for mailman id 94802; Mon, 08 Mar 2021 11:34:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJE9q-0007KB-1Z for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 11:34:42 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 365863d7-ab50-425d-8b42-fb39928ff4ea; Mon, 08 Mar 2021 11:34:40 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7F0D7D6E; Mon, 8 Mar 2021 03:34:40 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.197.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ADC073F73C; Mon, 8 Mar 2021 03:34:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 365863d7-ab50-425d-8b42-fb39928ff4ea From: Luca Fancellu To: luca.fancellu@arm.com, xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less Date: Mon, 8 Mar 2021 11:34:25 +0000 Message-Id: <20210308113425.22540-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 This patch prevents the dom0 to be loaded skipping its building and going forward to build domUs when the dom0 kernel is not found and at least one domU is present. Signed-off-by: Luca Fancellu Change-Id: Ieb9630b80cc7be7688d7d5fff3f839958f142ac0 --- xen/arch/arm/setup.c | 83 +++++++++++++++++++++++++++++++------------- 1 file changed, 59 insertions(+), 24 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 2532ec9739..6d169ff6ce 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -794,6 +794,35 @@ static void __init setup_mm(void) } #endif +static bool __init is_dom0less_mode(void) +{ + struct bootmodules *mods = &bootinfo.modules; + struct bootmodule *mod; + unsigned int i; + bool dom0found = false; + bool domUfound = false; + + /* Look into the bootmodules */ + for ( i = 0 ; i < mods->nr_mods ; i++ ) + { + mod = &mods->module[i]; + /* Find if dom0 and domU kernels are present */ + if ( mod->kind == BOOTMOD_KERNEL ) + { + if ( mod->domU == false ) + dom0found = true; + else + domUfound = true; + } + } + + /* + * If there is no dom0 kernel but at least one domU, then we are in + * dom0less mode + */ + return ( !dom0found && domUfound ); +} + size_t __read_mostly dcache_line_bytes; /* C entry point for boot CPU */ @@ -804,7 +833,7 @@ void __init start_xen(unsigned long boot_phys_offset, int cpus, i; const char *cmdline; struct bootmodule *xen_bootmodule; - struct domain *dom0; + struct domain *dom0 = NULL; struct xen_domctl_createdomain dom0_cfg = { .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, .max_evtchn_port = -1, @@ -964,28 +993,33 @@ void __init start_xen(unsigned long boot_phys_offset, apply_alternatives_all(); enable_errata_workarounds(); - /* Create initial domain 0. */ - /* The vGIC for DOM0 is exactly emulating the hardware GIC */ - dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; - /* - * Xen vGIC supports a maximum of 992 interrupt lines. - * 32 are substracted to cover local IRQs. - */ - dom0_cfg.arch.nr_spis = min(gic_number_lines(), (unsigned int) 992) - 32; - if ( gic_number_lines() > 992 ) - printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); - dom0_cfg.arch.tee_type = tee_get_type(); - dom0_cfg.max_vcpus = dom0_max_vcpus(); - - if ( iommu_enabled ) - dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; - - dom0 = domain_create(0, &dom0_cfg, true); - if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) - panic("Error creating domain 0\n"); - - if ( construct_dom0(dom0) != 0) - panic("Could not set up DOM0 guest OS\n"); + if ( !is_dom0less_mode() ) + { + /* Create initial domain 0. */ + /* The vGIC for DOM0 is exactly emulating the hardware GIC */ + dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; + /* + * Xen vGIC supports a maximum of 992 interrupt lines. + * 32 are substracted to cover local IRQs. + */ + dom0_cfg.arch.nr_spis = min(gic_number_lines(), (unsigned int) 992) - 32; + if ( gic_number_lines() > 992 ) + printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); + dom0_cfg.arch.tee_type = tee_get_type(); + dom0_cfg.max_vcpus = dom0_max_vcpus(); + + if ( iommu_enabled ) + dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; + + dom0 = domain_create(0, &dom0_cfg, true); + if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) + panic("Error creating domain 0\n"); + + if ( construct_dom0(dom0) != 0) + panic("Could not set up DOM0 guest OS\n"); + } + else + printk(XENLOG_INFO "Xen dom0less mode detected\n"); heap_init_late(); @@ -1003,7 +1037,8 @@ void __init start_xen(unsigned long boot_phys_offset, if ( acpi_disabled ) create_domUs(); - domain_unpause_by_systemcontroller(dom0); + if ( dom0 ) + domain_unpause_by_systemcontroller(dom0); /* Switch on to the dynamically allocated stack for the idle vcpu * since the static one we're running on is about to be freed. */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 11:36:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 11:36:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94805.178545 (Exim 4.92) (envelope-from ) id 1lJEBW-0007Rq-0s; Mon, 08 Mar 2021 11:36:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94805.178545; Mon, 08 Mar 2021 11:36:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEBV-0007Rj-U7; Mon, 08 Mar 2021 11:36:25 +0000 Received: by outflank-mailman (input) for mailman id 94805; Mon, 08 Mar 2021 11:36:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEBV-0007Rb-AZ for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 11:36:25 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 43f93126-dfc4-4871-ac97-580dbff9d0bb; Mon, 08 Mar 2021 11:36:23 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 71A6ED6E; Mon, 8 Mar 2021 03:36:23 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.197.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7AE0D3F73C; Mon, 8 Mar 2021 03:36:22 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43f93126-dfc4-4871-ac97-580dbff9d0bb From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less Date: Mon, 8 Mar 2021 11:36:04 +0000 Message-Id: <20210308113604.12961-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 This patch prevents the dom0 to be loaded skipping its building and going forward to build domUs when the dom0 kernel is not found and at least one domU is present. Signed-off-by: Luca Fancellu Change-Id: Ieb9630b80cc7be7688d7d5fff3f839958f142ac0 --- xen/arch/arm/setup.c | 83 +++++++++++++++++++++++++++++++------------- 1 file changed, 59 insertions(+), 24 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 2532ec9739..6d169ff6ce 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -794,6 +794,35 @@ static void __init setup_mm(void) } #endif +static bool __init is_dom0less_mode(void) +{ + struct bootmodules *mods = &bootinfo.modules; + struct bootmodule *mod; + unsigned int i; + bool dom0found = false; + bool domUfound = false; + + /* Look into the bootmodules */ + for ( i = 0 ; i < mods->nr_mods ; i++ ) + { + mod = &mods->module[i]; + /* Find if dom0 and domU kernels are present */ + if ( mod->kind == BOOTMOD_KERNEL ) + { + if ( mod->domU == false ) + dom0found = true; + else + domUfound = true; + } + } + + /* + * If there is no dom0 kernel but at least one domU, then we are in + * dom0less mode + */ + return ( !dom0found && domUfound ); +} + size_t __read_mostly dcache_line_bytes; /* C entry point for boot CPU */ @@ -804,7 +833,7 @@ void __init start_xen(unsigned long boot_phys_offset, int cpus, i; const char *cmdline; struct bootmodule *xen_bootmodule; - struct domain *dom0; + struct domain *dom0 = NULL; struct xen_domctl_createdomain dom0_cfg = { .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, .max_evtchn_port = -1, @@ -964,28 +993,33 @@ void __init start_xen(unsigned long boot_phys_offset, apply_alternatives_all(); enable_errata_workarounds(); - /* Create initial domain 0. */ - /* The vGIC for DOM0 is exactly emulating the hardware GIC */ - dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; - /* - * Xen vGIC supports a maximum of 992 interrupt lines. - * 32 are substracted to cover local IRQs. - */ - dom0_cfg.arch.nr_spis = min(gic_number_lines(), (unsigned int) 992) - 32; - if ( gic_number_lines() > 992 ) - printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); - dom0_cfg.arch.tee_type = tee_get_type(); - dom0_cfg.max_vcpus = dom0_max_vcpus(); - - if ( iommu_enabled ) - dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; - - dom0 = domain_create(0, &dom0_cfg, true); - if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) - panic("Error creating domain 0\n"); - - if ( construct_dom0(dom0) != 0) - panic("Could not set up DOM0 guest OS\n"); + if ( !is_dom0less_mode() ) + { + /* Create initial domain 0. */ + /* The vGIC for DOM0 is exactly emulating the hardware GIC */ + dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; + /* + * Xen vGIC supports a maximum of 992 interrupt lines. + * 32 are substracted to cover local IRQs. + */ + dom0_cfg.arch.nr_spis = min(gic_number_lines(), (unsigned int) 992) - 32; + if ( gic_number_lines() > 992 ) + printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); + dom0_cfg.arch.tee_type = tee_get_type(); + dom0_cfg.max_vcpus = dom0_max_vcpus(); + + if ( iommu_enabled ) + dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; + + dom0 = domain_create(0, &dom0_cfg, true); + if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) + panic("Error creating domain 0\n"); + + if ( construct_dom0(dom0) != 0) + panic("Could not set up DOM0 guest OS\n"); + } + else + printk(XENLOG_INFO "Xen dom0less mode detected\n"); heap_init_late(); @@ -1003,7 +1037,8 @@ void __init start_xen(unsigned long boot_phys_offset, if ( acpi_disabled ) create_domUs(); - domain_unpause_by_systemcontroller(dom0); + if ( dom0 ) + domain_unpause_by_systemcontroller(dom0); /* Switch on to the dynamically allocated stack for the idle vcpu * since the static one we're running on is about to be freed. */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 11:36:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 11:36:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94806.178557 (Exim 4.92) (envelope-from ) id 1lJEBb-0007Uh-DW; Mon, 08 Mar 2021 11:36:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94806.178557; Mon, 08 Mar 2021 11:36:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEBb-0007Ua-A4; Mon, 08 Mar 2021 11:36:31 +0000 Received: by outflank-mailman (input) for mailman id 94806; Mon, 08 Mar 2021 11:36:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEBZ-0007U8-V3 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 11:36:29 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1906e4df-09cb-4c78-b0d6-4f841126a62a; Mon, 08 Mar 2021 11:36:28 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7DDB5AC0C; Mon, 8 Mar 2021 11:36:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1906e4df-09cb-4c78-b0d6-4f841126a62a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615203387; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZX6tELjE20g1Auzb2U0kK+WMVKYf8ewXtKniGC4sZK8=; b=Sdr5S5+418NTHS/xdbONOLyci8ALNnoTIxQGiIHYPhU43rr6rx+ZQvGpxAxqGQH/zbCgeV egjDwsJewDRo6YV65DsNZhg0ksIGsS1GRJXy3hmU2aW0nt9mVhv2QJHhh2YYpmSD2Q5rD5 l510QSKAv2HEfePa0dLdJWrHxD+8tBM= Subject: Re: [PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time To: Ian Jackson Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <336aaf51-f163-8ee7-d8ee-297f6f3052fd@suse.com> <24645.62832.737310.550811@mariner.uk.xensource.com> <2857440d-058f-5c85-32d3-87e2fe65bb9a@suse.com> <24646.1454.55437.250075@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <78259adb-89b1-06a6-c1f4-c0659134e309@suse.com> Date: Mon, 8 Mar 2021 12:36:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <24646.1454.55437.250075@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 12:08, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time"): >> On 08.03.2021 10:59, Ian Jackson wrote: >>> Jan Beulich writes ("[PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time"): >>>> +# Arrange for preserving of auto-generated headers (to avoid them getting >>>> +# rebuilt every time): Move the entire xen/lib/x86/ to a temporary place. >>>> +prep-$(CONFIG_X86): >>>> + rm -rf .xen-lib-x86 >>>> + test ! -d xen/lib/x86 || mv xen/lib/x86 .xen-lib-x86 >>>> + >>>> all-$(CONFIG_X86): xen-dir >>>> + $(if $(wildcard .xen-lib-x86/*autogen.h),mv .xen-lib-x86/*autogen.h xen/lib/x86/) >>>> + rm -rf .xen-lib-x86 >>>> $(MAKE) -C xen/lib/x86 all XEN_ROOT=$(XEN_ROOT) PYTHON=$(PYTHON) >>> >>> Isn't there some better way of doing this ? I am very wary of adding >>> additional on-disk Makefile-managed state to a Makefile which is >>> already going wrong. I haven't thought about this in enough detail to >>> identify a specific bug but I think convincing myself that it is >>> definitely correct is nontrivial. >>> >>> Perhaps we could do the removal with a find rune instead, so we can >>> just skip the files we wanted to keep ? >> >> Maybe, and I did consider the option, but it would have felt more >> fragile to me than this dedicated keep-just-the-few-files approach. >> The problems we've had with this symlinking don't make me confident >> in leaving around parts of this subtree; populating from scratch >> seems like the most robust model (short of the suggested but never >> carried out removal of the symlinking) to me. > > I'm confused by your reply. > > You aren't confident "leaving around parts of this subtree" but you > are happy to move it aside and put it back, which seems equivalent. I > don't understand why you think the latter would be more reliable. I move a subdir aside and then move certain files out of it back. This doesn't leave much uncertainty as to whether other (symlinked) files / dirs may mistakenly also left around. > It seems to me that a find rune which deletes individual files can be > at least as specific as your current wildcard and mv approach. Possibly, but it may end up being more complex: We want to only retain files of specific names from a single dir. I don't think this is as straightforward to express in a find rune. Of course I'll be fine whichever way the bug gets fixed, but I'm afraid I don't feel convinced I want to put time into trying the alternative you suggest. If otoh you wanted to try out yours and it turned out equivalent or better, I wouldn't mind at all. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 11:38:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 11:38:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94814.178569 (Exim 4.92) (envelope-from ) id 1lJEDA-0007mQ-Qc; Mon, 08 Mar 2021 11:38:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94814.178569; Mon, 08 Mar 2021 11:38:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEDA-0007mJ-Mu; Mon, 08 Mar 2021 11:38:08 +0000 Received: by outflank-mailman (input) for mailman id 94814; Mon, 08 Mar 2021 11:38:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJED8-0007m9-Ij for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 11:38:06 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e7250106-8053-4e9d-a408-cf166b7d2a68; Mon, 08 Mar 2021 11:38:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7250106-8053-4e9d-a408-cf166b7d2a68 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615203484; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=UiDoH4ubFhxvZZE1S32tNzBJmS7SiN93C0HiGa9EdBA=; b=g2k721o/TsAod2FkYPEVNRXrT4cNWptf1on7eO3vI/9aUiGR2BFoSHpK j1D5RDDbA1QMARm10dmDLZRZXa50XC6Fg2NkQKE61BtZxYyeeCkAudSto PPJaZVStl3DGLWBuhAN/Ex16aHvmMHGISh1bXwhOzPTcPfQ9m1YPv/Re2 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ZawCvNDIHC6aUOfblvYyke+0VyMEb1leck/Oq3FZlNLSvXUoKTg4HtKxwkIQ2KPQeRkUmesemC SACSud5uGau3DgxAiOsZJVCBuHD/ErIgZiAZNwlxbKsdbA46N8uvrPKrYwkzXu2p+xolOwZiW5 hxUqjrZwsW8WvIPF0xUvaEwznWK9+R5CPvRIG32RAkDxCWpPawIG6VUjQLBxv9mcjf1FnExfkF wNpPzOZmygRRCSQucSmNd5vYljEmd6ZTdNXHPrxTpl0+X2aFTdTlqlVDyAaxzhXAMk5g0Nco2F OAE= X-SBRS: 5.2 X-MesageID: 40169225 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,232,1610427600"; d="scan'208";a="40169225" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iNUtPuc4HUMihEjGW1/wAz/TjeVbNmIG7/ebQoytcjxKSypPWGdzmduby2CUON5llxcsHKjD8pLYcFWfxejlTPIKOMFb5n0XWYS4yNfZxQ7hPQUUJi4c1kXT0+6Z8NkM2K9veJfi9r7ws8pTTsYeT4nXtgLEib1G/jcBFuk6gkfW3ksP2EmcbgjHRYaiNE8W2jTaSP25VYsV4JmFvrjM6gdsYp2GU0I5TXkZeAjR1MZhSiH1C1QZKEZ4mk6JMI0zQS2qLeUqXdsOr0Dnc/pnVXIH2TYW3qB2RNj6esItsvWQeVXL2Jiohx71qsZYh4FOG5uKp1Swhv6GU3AyKFyBcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vqRbU6BlIqaSzOEclvGQ11l9rYi7gl+ROTirI7UOxfI=; b=OBy33utGN/6Z9u+Nu5kcpJfaJpc0kUGjVYkSJmN/ghuG5QqK+oSQQ1N+Z6rA/BFFSu+B/8bBJ7fQn7rXJd+Ui/9oFIxMA+3VvO3EenTvvlkupFWqFPpEO05/tRAH9v8PgzUXPcS8tHg1N//xKKTaAVDJKxHwgO8wCI2HuJ6UDkRHEBU9a/WCDSdvUq2hWxaF9I9pa1P9vL6izD3nh/qLI1jy+/TT0qKStxW0U+zvTWEZkYcRcIa0aMV+vPRc2eG5N9OOqcYupjDccuzkTss/h/tcfvEEsVRnBcSvdVH7AedmOfh5p81HK91JBPdFUUgCMsGTPyRjwdBxQbbIhecWQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vqRbU6BlIqaSzOEclvGQ11l9rYi7gl+ROTirI7UOxfI=; b=gH8LluUC97BaOpRSHzTDPa19trznwOElESy0Zp79JILz03ukYqAbGKy3MFz90NWuhhyoWZgLZcyXJIFiTnwQhHlOVvQ/LV89OVwzj2kaAmJB7vJwcm7GB1DGt/8TuKE9ePPMg3cpXpLiYhiufRXTQ/w2Ekrmz7rnfac78Sy++CU= Date: Mon, 8 Mar 2021 12:37:37 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , Wei Liu , Ian Jackson Subject: Re: [PATCH v2 2/2][4.15] x86/AMD: expose HWCR.TscFreqSel to guests Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AM7PR04CA0022.eurprd04.prod.outlook.com (2603:10a6:20b:110::32) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fa2ac501-32d7-4885-b55d-08d8e2269619 X-MS-TrafficTypeDiagnostic: DM5PR03MB2634: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gq0eejBZntaQX6lCpTOeFicNdbJydB4SsS860C6GjkEi1zlq4w2c/EPvNjpW84cUqQJK17PK5sPRUdu1zthfP7zz6UIoV5O8knRt/wRWi1aiyj07IOShTyITww+6i+3eOrmNdfDY13Rv79D6Qn7RwqB5xNtymT8l6IJTrgv2xT6/ZLKqNcS6pkQqsklHQtv/SfJzeKnqllT2hRL2sA1VJJNfHhGKVNy/6D9DpnOmpUQPf7H11+CRcitAZdvmuDgLlyODcO9pyCR9JcVlrGri7bUm4x24l1qlYS+aZRkSsGRT4B90xPX2WD4bGBAKTzflg4ujZMDfid73cobxaEFvdRP9zn/2HnNjE0Htfr0ZW+zzDYWmATWbJPU3O9sxcbPUr8eW921faFmbdl/kINZsikWnkydYREScGRCOSWUU/5EI9xL3Yhqlk6/vGbMAc+oONC4DteOtKwrF+VnRoKF96QtMGiTi4hwVazCYiNadoH4GSxz3E+f2GSEdJXlJamZP+3swqH+WRCGXcclE52ChcQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(39860400002)(136003)(376002)(346002)(366004)(396003)(6496006)(54906003)(85182001)(26005)(83380400001)(66476007)(33716001)(9686003)(5660300002)(66946007)(4326008)(6916009)(86362001)(8936002)(316002)(956004)(16526019)(6486002)(186003)(478600001)(2906002)(6666004)(66556008)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eDFBdGN6L3VOTFcwRTh2R3RPVGdiYXBwTlJ2Qmh2S29MNFFlOER1NWxFODBM?= =?utf-8?B?WVMyRUZEd2pGQmxsUG9pYi9Cb0Y2L0h3R3gwVmRRa0wrS056anUyVi9ubXRD?= =?utf-8?B?b0h4aDVxV3hjRk5pT2UyY1UySnp2KzhuYk9WZ1J0TTlVTFd5cSs1LzFTNXBZ?= =?utf-8?B?TVpzbE1SLzl6UlFsMytIT3Z6S3VhR2lUL2FvbUlnaTVlYmgzNlpVU2F4Wm53?= =?utf-8?B?VmdkdStLU3RPTDZjOFNjNWlzSnNoTFNmWWEzcGJvaVc5TS9Ecm5rOUVSNTcw?= =?utf-8?B?VzF5V0d2UnNZVmRnNkdLYzhBdVRuS2ltM2dGb2Y5QjlhWmx5bnJ0cGVCTVFw?= =?utf-8?B?OHpBOUJLQjQ5U2ZDNzZhU2NGbmg4bGRKV2I0TnVGUGJJaHp6RlN2SVptWXhI?= =?utf-8?B?eTBzNmlSamRrenZoeGU5S3BLQWg0YVQ1Y0trcDZqVnZDaHViMHNSWks3b1k0?= =?utf-8?B?WUJ1TGFPdlBKYnUrWnpUYjJOcXF6OExvMExiZC9LWUMycVNTZ2dXdnJ5RURy?= =?utf-8?B?T3hST3gzMFdBVkE5dmc4bVFZdzIzTE8xMXhhWldtN2dGVFIrME1aYlU0YS9s?= =?utf-8?B?Y2pJcDh1WDRqQWZNQm1xUk5mMDh4aGg0bVhlRWFSMU55WDhTcnlVT1BKYWp5?= =?utf-8?B?TTQ2QlJxT1BQaDNUREJzZWdmWXdacElHaTRsWWZsM2lkL1A1NjdtOG01RUdv?= =?utf-8?B?WWpiT2l3Y0hCZGlLSmtIekVLYTZZejl3NXoyOEY1QnJPeHFlRHNpQVVWNnR4?= =?utf-8?B?MG1pOXNWcDlxOENPa09YU25ncktuZlJkVzlFVjNlRjl0OC9abzhNQ2dUcjI0?= =?utf-8?B?dFEwSXBrbm0xdDhsa09tQXhhb00veFNkejdzcStFYmxvWWl3ZTRMNFNLaVZm?= =?utf-8?B?YmpnUEdib0I2S2xwODhrejFkd015OWdNSE03SEN4cXJzWHAveW4zc2ZEYVdl?= =?utf-8?B?UFFidE9IQ2lhUXFoN3piMDQ3VHV0Y09YTXJyYmhpVW1sc2d0UGZrTzJMNXBR?= =?utf-8?B?ZE1aQStzV0VGU2p2QTlKMU9jcDR0SlFMNnJJa1BPY1BhU0tINzJSaEtERlJN?= =?utf-8?B?SFlRaUlLU2ZFem5kbUFWU3dLbm1yZ3loK1NhbUVoajVwYVowaVY4QUJOdHZP?= =?utf-8?B?RXpXMS9CaDZRdldMRGdQMXptZmg3WjJDa3piT1l2WU5GWk9uWGdXOTdzMFF2?= =?utf-8?B?dTF3dDlSSmpLVDZSNi9IOEFRbGhIdUU2N1RjK1ZYZVpUVkV0VE1XMldndFha?= =?utf-8?B?RDZyZW1MOUFxdUJLUXZPYWw1YUZLOUtCQ0sxaHVqbUl1czQ2UTJ6S0tUVHZv?= =?utf-8?B?N1BqbHlaV3drOENSZExpaEZOOVI1ODFWNStTYVFyc0ZEdUNDcDBad2U5U0U1?= =?utf-8?B?ZnZ3Y2JabDhNNTBQQUhjZHZveFhiYktUN3lBM1dQUGMyM3RZT2ROaFcxVmxJ?= =?utf-8?B?NGRTT05tN2ZBRFQvbDY1Y3hhcWVLVlJIY3pab2xOOC93bFdkMmtrYjhVUjZQ?= =?utf-8?B?dlEwYXhRMHI1bEdQbTA5cG56NlZmMVlFYllCMUJYemdZaUxPL2JEZ0JMOGpS?= =?utf-8?B?a21iV2E0MUFWc3FiZkR1M0NsVnZ1dGJFNXRmbWtSYWZ5K2ZocjRna1NTWFJX?= =?utf-8?B?ZEhqcGR1d2FwY0hJTlY1OEFYTm5sSXY2a213eHhMMklvaFRXNFg1S21VaE9W?= =?utf-8?B?SUFlbktFSEJCaXJRQ3BKeWtBK252TzZaZU1RRGwyRnUwYjZ1WHMyT0JFQVZK?= =?utf-8?Q?h16fL/oont2Xj1UqlG5XHAAAGftw5kDJ1m15D+w?= X-MS-Exchange-CrossTenant-Network-Message-Id: fa2ac501-32d7-4885-b55d-08d8e2269619 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 11:37:43.0116 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CK8gGA3Vj3evMoqo6PeNd02fSiHDPmFypT87IqzmeuchN62WjnqYi2s/hS0tUlm3x+hHyM8qbpCzV4XnQ3bR8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2634 X-OriginatorOrg: citrix.com On Fri, Mar 05, 2021 at 10:50:54AM +0100, Jan Beulich wrote: > Linux has been warning ("firmware bug") about this bit being clear for a > long time. While writable in older hardware it has been readonly on more > than just most recent hardware. For simplicitly report it always set (if > anything we may want to log the issue ourselves if it turns out to be > clear on older hardware). > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné One question below. > --- > v2: New. > --- > There are likely more bits worthwhile to expose, but for about every one > of them there would be the risk of a lengthy discussion, as there are > clear downsides to exposing such information, the more that it would be > tbd whether the hardware values should be surfaced, and if so what > should happen when the guest gets migrated. > > The main risk with making the read not fault here is that guests might > imply they can also write this MSR then. > > --- a/xen/arch/x86/msr.c > +++ b/xen/arch/x86/msr.c > @@ -315,6 +315,12 @@ int guest_rdmsr(struct vcpu *v, uint32_t > *val = msrs->tsc_aux; > break; > > + case MSR_K8_HWCR: > + if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) > + goto gp_fault; > + *val = K8_HWCR_TSC_FREQ_SEL; I've been only able to find information about this MSR up to family 10h, but I think in theory Xen might also run on family 0Fh, do you know if the MSR is present there, and the bit has the same meaning? > + break; > + > case MSR_AMD64_DE_CFG: > if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) > goto gp_fault; > --- a/xen/include/asm-x86/msr-index.h > +++ b/xen/include/asm-x86/msr-index.h > @@ -287,6 +287,8 @@ > > #define MSR_K7_HWCR 0xc0010015 We could likely drop the K7 define here, as Xen won't be able to run on K7 hardware anymore AFAICT. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 11:47:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 11:47:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94818.178580 (Exim 4.92) (envelope-from ) id 1lJEMW-0000PH-NC; Mon, 08 Mar 2021 11:47:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94818.178580; Mon, 08 Mar 2021 11:47:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEMW-0000PA-Jt; Mon, 08 Mar 2021 11:47:48 +0000 Received: by outflank-mailman (input) for mailman id 94818; Mon, 08 Mar 2021 11:47:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEMU-0000P5-QP for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 11:47:46 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fd665ff1-a22b-4b07-b109-a86b0179145a; Mon, 08 Mar 2021 11:47:45 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 06B7FACBF; Mon, 8 Mar 2021 11:47:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd665ff1-a22b-4b07-b109-a86b0179145a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615204065; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SBOuMZ34kV89EhI/qtaTSYIJIcHsQ0+B54P/z8QrV6w=; b=UyzL5+zvEk5rfRzA4wzhLO+XDsBg6rMXhAfAkiaSbtBhWd0g8OHNPNa0NQrFl7cbD0snRg hvcRPxGje+jCJV+Ow1u+3y6nHJKSE8BciyMzcgsLnZuldlruPn8acmrVwjI4CVU99QpdhL cmK7gkOYogWt0z7HmY8BTiIFWSYAlsM= Subject: Re: [PATCH v2 2/2][4.15] x86/AMD: expose HWCR.TscFreqSel to guests To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson References: From: Jan Beulich Message-ID: Date: Mon, 8 Mar 2021 12:47:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 08.03.2021 12:37, Roger Pau Monné wrote: > On Fri, Mar 05, 2021 at 10:50:54AM +0100, Jan Beulich wrote: >> Linux has been warning ("firmware bug") about this bit being clear for a >> long time. While writable in older hardware it has been readonly on more >> than just most recent hardware. For simplicitly report it always set (if >> anything we may want to log the issue ourselves if it turns out to be >> clear on older hardware). >> >> Signed-off-by: Jan Beulich > > Reviewed-by: Roger Pau Monné Thanks. > One question below. > >> --- >> v2: New. >> --- >> There are likely more bits worthwhile to expose, but for about every one >> of them there would be the risk of a lengthy discussion, as there are >> clear downsides to exposing such information, the more that it would be >> tbd whether the hardware values should be surfaced, and if so what >> should happen when the guest gets migrated. >> >> The main risk with making the read not fault here is that guests might >> imply they can also write this MSR then. >> >> --- a/xen/arch/x86/msr.c >> +++ b/xen/arch/x86/msr.c >> @@ -315,6 +315,12 @@ int guest_rdmsr(struct vcpu *v, uint32_t >> *val = msrs->tsc_aux; >> break; >> >> + case MSR_K8_HWCR: >> + if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) >> + goto gp_fault; >> + *val = K8_HWCR_TSC_FREQ_SEL; > > I've been only able to find information about this MSR up to family > 10h, but I think in theory Xen might also run on family 0Fh, do you > know if the MSR is present there, and the bit has the same meaning? >From its name (and its K7 alternative name) it's clear the register had been there at that point. And indeed the bit has a different meaning there (its the bottom bit of a 6-bit START_FID field if the BKDG I'm looking at can be trusted. Since I don't think it matters much whether we expose a value of 0x00 or a value of 0x01 there, and since we likely don't want to make #GP raising dependent upon family when we don't _really_ need to, I would want to propose that the value used is good enough uniformly. >> --- a/xen/include/asm-x86/msr-index.h >> +++ b/xen/include/asm-x86/msr-index.h >> @@ -287,6 +287,8 @@ >> >> #define MSR_K7_HWCR 0xc0010015 > > We could likely drop the K7 define here, as Xen won't be able to run > on K7 hardware anymore AFAICT. Indeed, but not at this point in time. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 11:56:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 11:56:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94821.178593 (Exim 4.92) (envelope-from ) id 1lJEUs-0001JF-Gy; Mon, 08 Mar 2021 11:56:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94821.178593; Mon, 08 Mar 2021 11:56:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEUs-0001J8-Dj; Mon, 08 Mar 2021 11:56:26 +0000 Received: by outflank-mailman (input) for mailman id 94821; Mon, 08 Mar 2021 11:56:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEUq-0001J0-TN for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 11:56:24 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id c190f1cc-a0fc-4ffa-840a-d0ed69e5c277; Mon, 08 Mar 2021 11:56:23 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B3A5BD6E; Mon, 8 Mar 2021 03:56:22 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.197.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E57553F70D; Mon, 8 Mar 2021 03:56:21 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c190f1cc-a0fc-4ffa-840a-d0ed69e5c277 From: Luca Fancellu To: luca.fancellu@arm.com, xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less Date: Mon, 8 Mar 2021 11:56:10 +0000 Message-Id: <20210308115610.48203-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 This patch prevents the dom0 to be loaded skipping its building and going forward to build domUs when the dom0 kernel is not found and at least one domU is present. Signed-off-by: Luca Fancellu --- xen/arch/arm/setup.c | 83 +++++++++++++++++++++++++++++++------------- 1 file changed, 59 insertions(+), 24 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 2532ec9739..6d169ff6ce 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -794,6 +794,35 @@ static void __init setup_mm(void) } #endif +static bool __init is_dom0less_mode(void) +{ + struct bootmodules *mods = &bootinfo.modules; + struct bootmodule *mod; + unsigned int i; + bool dom0found = false; + bool domUfound = false; + + /* Look into the bootmodules */ + for ( i = 0 ; i < mods->nr_mods ; i++ ) + { + mod = &mods->module[i]; + /* Find if dom0 and domU kernels are present */ + if ( mod->kind == BOOTMOD_KERNEL ) + { + if ( mod->domU == false ) + dom0found = true; + else + domUfound = true; + } + } + + /* + * If there is no dom0 kernel but at least one domU, then we are in + * dom0less mode + */ + return ( !dom0found && domUfound ); +} + size_t __read_mostly dcache_line_bytes; /* C entry point for boot CPU */ @@ -804,7 +833,7 @@ void __init start_xen(unsigned long boot_phys_offset, int cpus, i; const char *cmdline; struct bootmodule *xen_bootmodule; - struct domain *dom0; + struct domain *dom0 = NULL; struct xen_domctl_createdomain dom0_cfg = { .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, .max_evtchn_port = -1, @@ -964,28 +993,33 @@ void __init start_xen(unsigned long boot_phys_offset, apply_alternatives_all(); enable_errata_workarounds(); - /* Create initial domain 0. */ - /* The vGIC for DOM0 is exactly emulating the hardware GIC */ - dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; - /* - * Xen vGIC supports a maximum of 992 interrupt lines. - * 32 are substracted to cover local IRQs. - */ - dom0_cfg.arch.nr_spis = min(gic_number_lines(), (unsigned int) 992) - 32; - if ( gic_number_lines() > 992 ) - printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); - dom0_cfg.arch.tee_type = tee_get_type(); - dom0_cfg.max_vcpus = dom0_max_vcpus(); - - if ( iommu_enabled ) - dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; - - dom0 = domain_create(0, &dom0_cfg, true); - if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) - panic("Error creating domain 0\n"); - - if ( construct_dom0(dom0) != 0) - panic("Could not set up DOM0 guest OS\n"); + if ( !is_dom0less_mode() ) + { + /* Create initial domain 0. */ + /* The vGIC for DOM0 is exactly emulating the hardware GIC */ + dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; + /* + * Xen vGIC supports a maximum of 992 interrupt lines. + * 32 are substracted to cover local IRQs. + */ + dom0_cfg.arch.nr_spis = min(gic_number_lines(), (unsigned int) 992) - 32; + if ( gic_number_lines() > 992 ) + printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); + dom0_cfg.arch.tee_type = tee_get_type(); + dom0_cfg.max_vcpus = dom0_max_vcpus(); + + if ( iommu_enabled ) + dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; + + dom0 = domain_create(0, &dom0_cfg, true); + if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) + panic("Error creating domain 0\n"); + + if ( construct_dom0(dom0) != 0) + panic("Could not set up DOM0 guest OS\n"); + } + else + printk(XENLOG_INFO "Xen dom0less mode detected\n"); heap_init_late(); @@ -1003,7 +1037,8 @@ void __init start_xen(unsigned long boot_phys_offset, if ( acpi_disabled ) create_domUs(); - domain_unpause_by_systemcontroller(dom0); + if ( dom0 ) + domain_unpause_by_systemcontroller(dom0); /* Switch on to the dynamically allocated stack for the idle vcpu * since the static one we're running on is about to be freed. */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 11:59:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 11:59:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94824.178605 (Exim 4.92) (envelope-from ) id 1lJEXg-0001Va-Vc; Mon, 08 Mar 2021 11:59:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94824.178605; Mon, 08 Mar 2021 11:59:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEXg-0001VT-Sc; Mon, 08 Mar 2021 11:59:20 +0000 Received: by outflank-mailman (input) for mailman id 94824; Mon, 08 Mar 2021 11:59:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEXf-0001VO-PY for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 11:59:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEXe-0003Kr-M2; Mon, 08 Mar 2021 11:59:18 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJEXe-0003Ht-EU; Mon, 08 Mar 2021 11:59:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=hqf3/yskXTCieLGbncjOKuMJyp2OzDxOvIKVA6wL09k=; b=DPL8mjgAqNLgn08PKEPNcyr7Xp r81M86c31Yx8ibiKOzH+zReCiewoiS2A38Tegx//RhP8Mc7H54MOM6YuBNsXuPJhor5yK2yGSdoiS pJsL+u3BBzTsN28Pj3rZMq8E+Qp05IZ7wqplWwlbg7NvzYrsVSwMuUq3FGOS5MqKNr/Y=; Subject: Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk References: <20210308115610.48203-1-luca.fancellu@arm.com> From: Julien Grall Message-ID: Date: Mon, 8 Mar 2021 11:59:16 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210308115610.48203-1-luca.fancellu@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Luca, On 08/03/2021 11:56, Luca Fancellu wrote: > This patch prevents the dom0 to be loaded skipping its > building and going forward to build domUs when the dom0 > kernel is not found and at least one domU is present. > > Signed-off-by: Luca Fancellu I have received 3 versions of this patch, can you clarify I should review? If the modification is just the CC list, then we usually add RESEND in the subject. For all the other modifications, we bump the version (vX in suject) and provide a changelog. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:03:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:03:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94829.178617 (Exim 4.92) (envelope-from ) id 1lJEbJ-0002PP-LT; Mon, 08 Mar 2021 12:03:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94829.178617; Mon, 08 Mar 2021 12:03:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEbJ-0002PI-Hh; Mon, 08 Mar 2021 12:03:05 +0000 Received: by outflank-mailman (input) for mailman id 94829; Mon, 08 Mar 2021 12:03:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEbI-0002PA-GG; Mon, 08 Mar 2021 12:03:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEbI-0003RS-Bi; Mon, 08 Mar 2021 12:03:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEbI-0005ga-42; Mon, 08 Mar 2021 12:03:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJEbI-00080l-3Z; Mon, 08 Mar 2021 12:03:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Z5VAKWET8/EmTZ8dyS/a7pYmDsuuS7fSm4UYrPTHbJE=; b=fRTgnEQ/olAqvjODdk26UpQNqW j3ELdVHezjawy91Jcz+zFrkoNEXRFxRLOIaXoflA5KzSIs8dk2lnRY6vQkcNMOeUvp8ts/pbPuJQS sxC6Bd2vYBwtdQzZJ9NqQKtERPt83w87OCRHirTNKs1i3iN/wmnR0nsM2d39ORfNiWlw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159871: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=60c0444fae2148452f9ed0b7c49af1fa41f8f522 X-Osstest-Versions-That: xen=51972482f77b68ef494c8b9591b125460e7984b9 From: osstest service owner Date: Mon, 08 Mar 2021 12:03:04 +0000 flight 159871 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159871/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 60c0444fae2148452f9ed0b7c49af1fa41f8f522 baseline version: xen 51972482f77b68ef494c8b9591b125460e7984b9 Last test of basis 159850 2021-03-06 20:01:30 Z 1 days Testing same since 159871 2021-03-08 10:00:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Tim Deegan jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 51972482f7..60c0444fae 60c0444fae2148452f9ed0b7c49af1fa41f8f522 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:05:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:05:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94834.178631 (Exim 4.92) (envelope-from ) id 1lJEde-0002XL-2s; Mon, 08 Mar 2021 12:05:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94834.178631; Mon, 08 Mar 2021 12:05:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEdd-0002XE-W2; Mon, 08 Mar 2021 12:05:29 +0000 Received: by outflank-mailman (input) for mailman id 94834; Mon, 08 Mar 2021 12:05:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEdc-0002X7-EG for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:05:28 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b5c93f49-c2ec-4ac6-8de6-dcf4a2b4991b; Mon, 08 Mar 2021 12:05:27 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8664AAC0C; Mon, 8 Mar 2021 12:05:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5c93f49-c2ec-4ac6-8de6-dcf4a2b4991b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615205126; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vRa9di/p1QmpzTcsrcH2OuL4P81hepuxWftRo4iB2kk=; b=BpJBQpr//bqYZVu+zqA3mbbsaz7QinqjpcKwszwuEzOg9cF4+0JHaA89IBzIVQYUUO/SIt tbWeYWRgvnOdHaTroFH5YkSPNWg6jZn/eDZ8iEv2eM4+e/OOpvNHU+HjOW6m5KbBl7Kn6b aDrW/J1yCwhW//BeSVyNtrVkJ2J97NE= Subject: Re: [PATCH 2/2][4.15?] x86/shadow: encode full GFN in magic MMIO entries To: Tim Deegan Cc: "xen-devel@lists.xenproject.org" , George Dunlap , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: From: Jan Beulich Message-ID: Date: Mon, 8 Mar 2021 13:05:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 10:39, Tim Deegan wrote: > At 16:37 +0100 on 05 Mar (1614962265), Jan Beulich wrote: >> Since we don't need to encode all of the PTE flags, we have enough bits >> in the shadow entry to store the full GFN. Don't use literal numbers - >> instead derive the involved values. Or, where derivation would become >> too ugly, sanity-check the result (invoking #error to identify failure). >> >> This then allows dropping from sh_l1e_mmio() again the guarding against >> too large GFNs. >> >> Signed-off-by: Jan Beulich > > Acked-by: Tim Deegan Thanks. >> I wonder if the respective check in sh_audit_l1_table() is actually >> useful to retain with these changes. > > Yes, I think so. We care about these PTEs being bogus for any reason, > not just the ones that this could address. > >> -#define SH_L1E_MAGIC 0xffffffff00000001ULL >> +#define SH_L1E_MAGIC_NR_META_BITS 4 >> +#define SH_L1E_MAGIC_MASK ((~0ULL << (PADDR_BITS - PAGE_SHIFT + \ >> + SH_L1E_MAGIC_NR_META_BITS)) | \ >> + _PAGE_PRESENT) > > I don't think this makes the code any more readable, TBH, but if you > prefer it that's OK. I'd be happier with it if you added a > BUILD_BUG_ON that checks that 1ULL << (PADDR_BITS - 1) is set in the > mask, since that's the main thing we care about. > >> -#define SH_L1E_MMIO_MAGIC 0xffffffff00000001ULL >> -#define SH_L1E_MMIO_MAGIC_MASK 0xffffffff00000009ULL >> -#define SH_L1E_MMIO_GFN_MASK 0x00000000fffffff0ULL >> +#define SH_L1E_MMIO_MAGIC SH_L1E_MAGIC_MASK >> +#define SH_L1E_MMIO_MAGIC_BIT ((_PAGE_PRESENT | _PAGE_RW | _PAGE_USER) + 1) > > IMO this would be more readable as a straight 0x8 (or even _PAGE_PWT). > The ack stands either way. For both of your remarks, I agree that readability suffers by doing it this way, so I'll undo some of it since you'd prefer it to be more readable. My goal wasn't so much readability though but ease of changes down the road (no need to change multiple related definitions) and documentation of why these values actually are the way they are. But let's first see anyway what further changes are needed in response to Andrew's remarks. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:12:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:12:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94838.178644 (Exim 4.92) (envelope-from ) id 1lJEk9-0003U2-Ql; Mon, 08 Mar 2021 12:12:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94838.178644; Mon, 08 Mar 2021 12:12:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEk9-0003Tv-Nd; Mon, 08 Mar 2021 12:12:13 +0000 Received: by outflank-mailman (input) for mailman id 94838; Mon, 08 Mar 2021 12:12:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEk8-0003Tp-Ie for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:12:12 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 25250e7b-3514-4cb6-8619-a87456815ccb; Mon, 08 Mar 2021 12:12:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25250e7b-3514-4cb6-8619-a87456815ccb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615205530; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=1+r3NmFRnUOvPx32orQN6Tr7MX0SJLnUpeTJ2bXhDyU=; b=bH68tlOlmkHWZWWtfs4GlQeYXgV5koQFTJY3Fm0vzVbHP1DhiqeC1uVO tijiTpE0KF/1c5hU9rzostd32vMBdF4nnJT6NAi242xEA81lq9y6wLpsc 9j0yw7RH52dhcOm2e8oCas8GJxdhJmuJqkJ4L6JN00Yd001LgG2wLRG/6 U=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: YGsrTk6/ewiDiJ9DFKPlh3Sg1xST+M/ZGGXi8yu5SUTBaRGvHZk4yA/vxWifWN7t49IitxP42n mt5+JcXyCiOxTKu1lChIlx+pG/UBKtyXQaJH/RPnVvqR8o8qilCVTCAO9hsg5QPgceX1Jpz9ob KqcORo0dWngMUmi4RJRkUC7VnHul/y67ozpRgK5nvGefO7XUKXs51bY5xhCPDhmBADgPy/OO6K RcqwBDnN5IPUp8l3ZVs+cyKSaaSkNLg/YNNuTyY/d8P4RpeIbmRJemY/xr8pwkhpNJ5tHMooAi XeY= X-SBRS: 5.2 X-MesageID: 38943348 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,232,1610427600"; d="scan'208";a="38943348" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lK5ZANy62KuvDIHOVQ8azEL051IBIekthbu4pmuGSmYe1x/Rn6nm5ckxpkLz+Bt8gKp5lV73Y1WBi9t+A7/nHDL5inXUzzjUAYDWOe7oYr8mPmgGjSOEY+KDnwbxinM5/wM5sKjBNzvmNZOvt8AXctOzNr8HLYq2atERjaSN7fenOITT34Z18kf0uM3PXyNZ8XfCZNPZg13BIyw02aym4ZJwMumlILm2HX8JVYRXt/m9sRPBFux+U2TIeER51hiuSfRu7Itp225/Lqrm/3s8Otl56SvmjlarkZw+DWKke77gjd8urRson+/kdh9N2/nB0R+925BkFY6AidGujXOnCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ez0HUnktigCDQNibsVl6hn7fBtBNUbK8UenV0QrkbLU=; b=Bh6b3U7AtAjWCoRyNcxpUcopYSnGFdDE0hW10eqLrBh8Yg7HtRBJAyBESk80D8EO95bbqwONQv8gJ+5cwB9RVc5k8X2c3KJDs//V8iw67JnDsiq37aYw9BliJu5q1TmhN6aPD4669cmc9P84zaCs2/DvYAdu5pjhWSN2Woo3jnWMkpk3MfJVtX95fJNyeGXh4VT5GyRbgRrPSXT+NIBzE/eyRwUBozUyrc3l16NDYj2P3OY/O0fwoGMTS/6GyYNYzJwT1S/7kZWAe+XezPISEaojxwqdSiKfXEoW/4JKlDdCSH+cZLF+dzZmX3E2aYVeajcD7dR9mAUk7WkflAwWRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ez0HUnktigCDQNibsVl6hn7fBtBNUbK8UenV0QrkbLU=; b=cJgsxNxq9przXYA29yF77s333r/y7TMWxe5mg8X8cg3uSkHnESa10xbf/IjKI7bV+hj1GKkXeS5Ro2vOEDJdxgqgJl1sIDb46s6yoQ1w4Yn9aTsVMzVoinX22YcbL9ILdCj1J31QkGrdYz8oWMKCOjZADVdkF+78JVcApgsrK/k= Date: Mon, 8 Mar 2021 13:11:24 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , Wei Liu , Ian Jackson Subject: Re: [PATCH v2 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads Message-ID: References: <1f19ced7-183b-8f08-3a90-c06039e053a6@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1f19ced7-183b-8f08-3a90-c06039e053a6@suse.com> X-ClientProxiedBy: LO2P265CA0175.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::19) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fdf81596-a278-47b6-75dc-08d8e22b4ed3 X-MS-TrafficTypeDiagnostic: DM6PR03MB5178: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WQn0Eor/e/SMiPlMJFZyAwmoyMWMpCOpAvFuX3wsLmrOoNZyyH+pztbIgGLqskXp5ItO7Aw9ty3lBv5hpdtoFjxBHJTURVR8qF8FyL+wIA/XtCcR9P42txPMY82sHjm0B19noBRLl0yXMiMa5jhWW7rC0X3PtMFasdIKi22IFywN4PhzDqabEXoxEvp6iEuj/RwfKAFlQ+G1BeHPuPc/U+LtGvLOcTaTK62N/qNV9GNfH/b/mqK/OoE9bbpp3YTY7I0+UrxSr2SI2PMfLnRhr2s5CUlQV6BtG18Jf68/BBvdOIkmH4hB9Lg/A2gHp0AQFHDaLEc4n7sQ6pJWcEe07fR1ncP1BPTDuNrOL24Cca2cFsgJfWrCC3YsHYi/ZphiG6m9G8CsV/ZOIVK9DsCB6MaXNbzAoJyQgw4w/Ru4RxU2daz+Dy+HXW09mD+fo4r2S6NqHxAG7NmI2XPOz6qROHLtrUkqa5fEBTzcjEAWa/MNKyilfjTCv0Yvzs++LReQb+qB/uscLr7Vxu13kUdJFg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(39860400002)(396003)(136003)(366004)(346002)(376002)(6916009)(6496006)(4326008)(8936002)(8676002)(53546011)(66946007)(478600001)(66556008)(33716001)(83380400001)(9686003)(186003)(16526019)(85182001)(956004)(6666004)(86362001)(26005)(2906002)(316002)(54906003)(5660300002)(6486002)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YkxIM3paNU5JVHlBU1BrTXExZklUMk4wUGswbWFUazMxNEZXcXRkWFNrNVNF?= =?utf-8?B?Mm04dWplckU3OFpURldHbEk0czFCcm5rWGc4bUp5TFY2bXQ5MkRJTEdVM004?= =?utf-8?B?SUZqU1VMR0UyK0xESlg5dUpMWS9LcW5tZE56VEtvU01HUHZmS2tkVlZrWCtW?= =?utf-8?B?bGR2VU1pT2tpOHZZMTR1UzgvU0paaW9jd0srOEh6R2I5ZTVaZHVvUnNwanJp?= =?utf-8?B?b3hqUXlhU3RwcXZhTEhVc05YVFBZc1BXZHFOeXlzYlcxb2RKOGF6V05tcEpa?= =?utf-8?B?REJFOXczcXgyc0ZjZER6R1JHbEVONDlFS2d1TWNWSkVTNk9FeTVVNi95RThy?= =?utf-8?B?ZHJxSTNVd3FsRFVkZmVhQ3lJOTkvL0F2VDBIck1zUEZ4aUlMa29zQUxqOVBu?= =?utf-8?B?OVZVSGRKanM2OUFzR1FKREZsSjREekNadzUrcVoyTjkxR3NWZmtRNXdEdDZp?= =?utf-8?B?dG10L1pkNHl0dzRzQ3NEeGxnOGVpNDc4TEdJdCsyUmQyWWVtalAvb0ppdWgw?= =?utf-8?B?dHRGL1M5ZTZXRERZREs1dWJVMzY3eWhBN1JJM2JMaFJVVnBZUFgydHArSU1v?= =?utf-8?B?NTk0SWsreGhUNFh0UWlNZ3JsWkFHUC9NNlJFckdnOE1SUzFaczk0d0hkZlpB?= =?utf-8?B?QmZWWnNDV2RwOGQydndJQVBsSGFURlVqUytidkRlOWtGTjRzd3gwVkhrOFQz?= =?utf-8?B?QTlvQXNUNHphMFJDR0J2Y0ZXSHovcHJTb0s3WDJudkNzZW9MUkNvMnZpaTRy?= =?utf-8?B?QzRCWW1YNFdKMXNIQWljQ3dBMG0rbXJiemdhR3pHY05DU1c0Mno4OEVpZWts?= =?utf-8?B?L0E0aTgwYjZ3S3lheGFRdnc0ZGVRdi9IZ0txNFZVMitmSkxuTjBMYnkxTG5Y?= =?utf-8?B?aFpvY0tKb0lDRVRpVzZFcm9BZURZeDdWVjJZcDlHOTBkRUNoVS83aUxMcHpL?= =?utf-8?B?SjhDcWI4TlAzZnVZekxKV1cybHlSQkhGeGg2OHFGL01kVTljeXZOUEdQVVlt?= =?utf-8?B?aWlEYmJ5Tzhwbll2a1J3YUJGc3IzV2JhckNmM1FURGUrWWZzSUIvSlBaTlYw?= =?utf-8?B?TVltRTRaalYxenp0MURLVnp0QzlMK2Rzc2pna3ZibUs5WGZtRXFOTmtDL1Nx?= =?utf-8?B?STZJaFNacUxoZ3l1dVpaRmtKMHphdWc1VjBzYkhNM09sWlZrdUg0YUZZN3hK?= =?utf-8?B?dzJBT1hlTE1OVDh0LzJNY0UxY1Fhcy9jc2Y5eEI4YmU5YjNkYkRiNldhd2pj?= =?utf-8?B?L1FkMDlLTGlNUDhwZzA5NVZZeUs3YmhtSU0xY3BDR09vZlh0R2dpUDNiS1BJ?= =?utf-8?B?RjliT29nYVhsczFpMFFFR1gvM0Q5N0JRc3YvTUk3aEJCMWM4K0h1Sm5CakNW?= =?utf-8?B?TFMrM1Y2a3hPRFlwZ3JtSkcra1NtTEtmeDB6VVM1aGFzVmF1cnRQOHIzUlA5?= =?utf-8?B?ZzhNOEc4SVluNHpOd0M5TGxla0Zrc2JiaDk5VVNlaThEaXU3ejJaQzZUQzdG?= =?utf-8?B?MFYxOFdrUnlaejlmbDhqTFQ4UEF3Y29TYXpOSXlLY1p0TGFPOFhKLzhGWG8v?= =?utf-8?B?QmhVekpSWER2WUFLTHlva1ZYL2JnMXZ0VzFyYUh5SlpDanhGS2xoSWMwN2RH?= =?utf-8?B?ZUZtRW5zRlFFWk10OFVKSUZjYmZ6K3RTbXZYZ1g3WEJtay9zWWtPN0ZES2hw?= =?utf-8?B?Y0FDU3RTNENaVmdIWUJORjVlRHhVeFJrUWZPcS9YQjFCVWlPSFpJRlFUYzFp?= =?utf-8?Q?bJnFA4Fu7NfWs6q/uMIU9l31pxqtsHvdnFQeLIU?= X-MS-Exchange-CrossTenant-Network-Message-Id: fdf81596-a278-47b6-75dc-08d8e22b4ed3 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 12:11:30.8340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B/KwNKHdQde/0iXNTjFeOBSFAxtFqyM3achorTmSq+B3wHHuRO7tick95SS91XItDLlCR0n1Oxs6dwa+ynzzIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5178 X-OriginatorOrg: citrix.com On Mon, Mar 08, 2021 at 10:33:12AM +0100, Jan Beulich wrote: > On 08.03.2021 09:56, Roger Pau Monné wrote: > > On Fri, Mar 05, 2021 at 10:50:34AM +0100, Jan Beulich wrote: > >> Prior to 4.15 Linux, when running in PV mode, did not install a #GP > >> handler early enough to cover for example the rdmsrl_safe() of > >> MSR_K8_TSEG_ADDR in bsp_init_amd() (not to speak of the unguarded read > >> of MSR_K7_HWCR later in the same function). The respective change > >> (42b3a4cb5609 "x86/xen: Support early interrupts in xen pv guests") was > >> backported to 4.14, but no further - presumably since it wasn't really > >> easy because of other dependencies. > >> > >> Therefore, to prevent our change in the handling of guest MSR accesses > >> to render PV Linux 4.13 and older unusable on at least AMD systems, make > >> the raising of #GP on this paths conditional upon the guest having > >> installed a handler, provided of course the MSR can be read in the first > >> place (we would have raised #GP in that case even before). Producing > >> zero for reads isn't necessarily correct and may trip code trying to > >> detect presence of MSRs early, but since such detection logic won't work > >> without a #GP handler anyway, this ought to be a fair workaround. > >> > >> Signed-off-by: Jan Beulich > >> --- > >> v2: Probe MSR read. Exclude hypervisor range. Avoid issuing two log > >> messages (in debug builds). Don't alter WRMSR behavior. > >> --- > >> I'm not convinced we can get away without also making the WRMSR path > >> somewhat more permissive again, e.g. tolerating attempts to set bits > >> which are already set. But of course this would require keeping in sync > >> for which MSRs we "fake" reads, as then a kernel attempt to set a bit > >> may also appear as an attempt to clear others (because of the zero value > >> that we gave it for the read). > > > > The above approach seems dangerous, as it could allow a guest to > > figure out the value of the underlying MSR by probing whether values > > trigger a #GP? > > Perhaps, yes. But what do you do? There's potentially a huge value > range to probe ... > > > I think we want to do something similar to what we do on HVM in 4.14 > > and previous versions: ignore writes as long as the rdmsr to the > > target MSR succeeds, regardless of the value. > > Which, as said elsewhere, has its own downsides - writable MSRs don't > need to also be readable. See e.g. AMD's proposed PARTIAL_{FS,GS}_LOAD > MSRs. Yes, but it's IMO the lesser of two evils, I think we should avoid any kind of behavior that depends on the underlying MSR value, just to be on the safe side. > >> --- a/xen/arch/x86/pv/emul-priv-op.c > >> +++ b/xen/arch/x86/pv/emul-priv-op.c > >> @@ -874,7 +874,7 @@ static int read_msr(unsigned int reg, ui > >> struct vcpu *curr = current; > >> const struct domain *currd = curr->domain; > >> const struct cpuid_policy *cp = currd->arch.cpuid; > >> - bool vpmu_msr = false; > >> + bool vpmu_msr = false, warn = false; > >> int ret; > >> > >> if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) > >> @@ -882,7 +882,7 @@ static int read_msr(unsigned int reg, ui > >> if ( ret == X86EMUL_EXCEPTION ) > >> x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); > >> > >> - return ret; > >> + goto done; > >> } > >> > >> switch ( reg ) > >> @@ -986,7 +986,7 @@ static int read_msr(unsigned int reg, ui > >> } > >> /* fall through */ > >> default: > >> - gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); > >> + warn = true; > >> break; > >> > >> normal: > >> @@ -995,7 +995,19 @@ static int read_msr(unsigned int reg, ui > >> return X86EMUL_OKAY; > >> } > >> > >> - return X86EMUL_UNHANDLEABLE; > >> + done: > > > > Won't this handling be better placed in the 'default' switch case > > above? > > No - see the "goto done" added near the top of the function. Yes, I'm not sure of that. If guest_rdmsr returns anything different than X86EMUL_UNHANDLEABLE it means it has handled the MSR in some way, and hence we shouldn't check whether the #GP handler is set or not. This is not the behavior of older Xen versions, so I'm unsure whether we should introduce a policy that's even less strict than the previous one in regard to whether a #GP is injected or not. I know injecting a #GP when the handler is not set is not helpful for the guest, but we should limit the workaround to kind of restoring the previous behavior for making buggy guests happy, not expanding it anymore. > >> + if ( ret != X86EMUL_OKAY && !curr->arch.pv.trap_ctxt[X86_EXC_GP].address && > >> + (reg >> 16) != 0x4000 && !rdmsr_safe(reg, *val) ) > > > > We didn't used to care about explicitly blocking the reserved MSR > > range, do we really wan to do it now? > > > > I'm not sure I see an issue with that, but given that we are trying to > > bring back something similar to the previous behavior, I would avoid > > adding new conditions. > > What I'm particularly trying to avoid here is to allow > information from an underlying hypervisor to "shine through", > even if it's only information as to whether a certain MSR is > readable. It should be solely our own selection which MSRs in > this range a guest is able to (appear to) read. > > Plus of course by avoiding the rdmsr_safe() in this case we > also avoid the unnecessary (debug only) log message associated > with such attempted reads. OK, I think that's fine. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:12:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:12:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94839.178656 (Exim 4.92) (envelope-from ) id 1lJEkS-0003Y3-35; Mon, 08 Mar 2021 12:12:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94839.178656; Mon, 08 Mar 2021 12:12:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEkR-0003Xw-W7; Mon, 08 Mar 2021 12:12:31 +0000 Received: by outflank-mailman (input) for mailman id 94839; Mon, 08 Mar 2021 12:12:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEkQ-0003Xk-T8 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:12:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEkQ-0003bZ-Qc for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:12:30 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJEkQ-0004cI-NG for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:12:30 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lJEkN-0008Q2-DB; Mon, 08 Mar 2021 12:12:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=8wCi3Dftd3FaukUhiK2OHo7Bw4PW8XiwJNUVoRyTk9A=; b=u4EueEr4WOPItrj1PTx24dKNuP WG2MENYxkW5n81YTBbPZfjtVuzAfJz9hFNlYdQmhitYL87xQPYm06H4cn6A7kiqifL6ZXInNjnScT U9wc6sEOd1jHIvR5b9bC/YSnlm1n/jbMd7khRCQsUUpmd9BIcon+GEVWckEsLtJ1Gr8g=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24646.5291.124853.270432@mariner.uk.xensource.com> Date: Mon, 8 Mar 2021 12:12:27 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time In-Reply-To: <78259adb-89b1-06a6-c1f4-c0659134e309@suse.com> References: <336aaf51-f163-8ee7-d8ee-297f6f3052fd@suse.com> <24645.62832.737310.550811@mariner.uk.xensource.com> <2857440d-058f-5c85-32d3-87e2fe65bb9a@suse.com> <24646.1454.55437.250075@mariner.uk.xensource.com> <78259adb-89b1-06a6-c1f4-c0659134e309@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time"): > Possibly, but it may end up being more complex: We want to only > retain files of specific names from a single dir. I don't think > this is as straightforward to express in a find rune. Of course > I'll be fine whichever way the bug gets fixed, but I'm afraid I > don't feel convinced I want to put time into trying the alternative > you suggest. If otoh you wanted to try out yours and it turned out > equivalent or better, I wouldn't mind at all. Untested, but I think something like this should DTRT find xen ! -type d ! -path 'xen/lib/x86/*-autogen.h' -print0 | xargs -0r rm -- Since my background is GNU utilities, I checked the FreeBSD manpages for find, xargs and rm. They support these options. This will leave the entire directory structure but I think that is fine. The xen-dir target uses mkdir -p and should there be any stale directories (eg due to switching branches or whatever) they wouldn't be a problem. Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:14:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:14:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94844.178668 (Exim 4.92) (envelope-from ) id 1lJEmR-0003iI-Fs; Mon, 08 Mar 2021 12:14:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94844.178668; Mon, 08 Mar 2021 12:14:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEmR-0003iB-Ce; Mon, 08 Mar 2021 12:14:35 +0000 Received: by outflank-mailman (input) for mailman id 94844; Mon, 08 Mar 2021 12:14:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJEmP-0003hq-Oy for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:14:33 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown [40.107.22.79]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ee6bbee4-1afb-4eb3-80af-1196df8acf8f; Mon, 08 Mar 2021 12:14:32 +0000 (UTC) Received: from AM6PR04CA0057.eurprd04.prod.outlook.com (2603:10a6:20b:f0::34) by DB7PR08MB3481.eurprd08.prod.outlook.com (2603:10a6:10:4b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.28; Mon, 8 Mar 2021 12:14:29 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:f0:cafe::25) by AM6PR04CA0057.outlook.office365.com (2603:10a6:20b:f0::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Mon, 8 Mar 2021 12:14:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Mon, 8 Mar 2021 12:14:29 +0000 Received: ("Tessian outbound 155e15b2e217:v71"); Mon, 08 Mar 2021 12:14:29 +0000 Received: from 540b01177768.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 36B2840F-6785-452A-9EC4-9C57E8E45795.1; Mon, 08 Mar 2021 12:14:23 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 540b01177768.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 08 Mar 2021 12:14:23 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) by VE1PR08MB5775.eurprd08.prod.outlook.com (2603:10a6:800:1a0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Mon, 8 Mar 2021 12:14:18 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642]) by VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642%4]) with mapi id 15.20.3890.037; Mon, 8 Mar 2021 12:14:17 +0000 Received: from a75445.arm.com (82.8.129.65) by LO4P123CA0057.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.26 via Frontend Transport; Mon, 8 Mar 2021 12:14:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee6bbee4-1afb-4eb3-80af-1196df8acf8f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0S+hWfonz9GGee1X4K5rfXGzo+F3fnGRj2XlxlRy8rw=; b=Z7wfsYnG4MK9yVm8jIdjbsHtto44KRfAmz4cJMZIqk+TcuozDTmyeHJfZPFGZCXjUP6GVFPkv7qk+35u9H3moThP5cmuLOjIOfHccLeG7jaCwR6vMROmrY6IHOfKBAOYBiRYlbxTC9pKsK7NXG5WrgZf0XL+1YP9KIZkh747Zok= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: e10be941d084ab53 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GoeI1r+g7wrICtH9OjVXhahkk+KKjVK/AQzmTBdnTMh6od9jC1ogIh+bSHRgizF4do6WUEVcjxtAsOEOZa5VoO3QYIPJ6sFdNUFioA6m3NWCQxNdZekgXye1chkSIeKaFIs6ZUAaIbPGwH92qGRzIKrKrdhZ0pswutGMeuPa7g+U2pHJMYfa5eJi3YZ4OD49ExlXrfS48k2WFaO8A46wm1YUlFnLN2VOIvcap4+PQyFdLTJBLZOleo5bOR9wudYrwCD74m9ErHJKq8yRR/eD7LfF+QOA53JlSTve0wXj3cIxhBBZGdN/91VnrZtbj4bZwzduOXLkBUaw/tD5LDIRXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0S+hWfonz9GGee1X4K5rfXGzo+F3fnGRj2XlxlRy8rw=; b=l+qonOSs3X6G5sEhkgtBhldEWFCBj4onYQUoXPP+mJhcGmLasy2pLzaYgc+0RypZ2/m+K3EJOdhyUKttA1ZkVfX4LN2F8fkTjHkOkXP3V+5zwbHO0umHeuqZLL0ZYZkCQmTzzFuJhGNgSGNosBP8bmb03XQtLum25oB8LODsKZz4zeYavyUgXk8HZR9IdUjD+/WhrAsAUQ9ZMy479O3qITdIkgoJTwOm6iJzC7vWU38xes5IglmwuxA6FIJHObPZK1NYLtjg8rihS6m0nuwMh5ftiEOSOYyJIRssXxGoVHsE//gwErzztEPi9PIvVIV7yWVTWC22YDgpUsivAKuwBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0S+hWfonz9GGee1X4K5rfXGzo+F3fnGRj2XlxlRy8rw=; b=Z7wfsYnG4MK9yVm8jIdjbsHtto44KRfAmz4cJMZIqk+TcuozDTmyeHJfZPFGZCXjUP6GVFPkv7qk+35u9H3moThP5cmuLOjIOfHccLeG7jaCwR6vMROmrY6IHOfKBAOYBiRYlbxTC9pKsK7NXG5WrgZf0XL+1YP9KIZkh747Zok= Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less From: Luca Fancellu In-Reply-To: Date: Mon, 8 Mar 2021 12:14:09 +0000 Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , wei.chen@arm.com Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210308115610.48203-1-luca.fancellu@arm.com> To: Julien Grall X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO4P123CA0057.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::8) To VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 5f64dab4-347d-434a-04ee-08d8e22bb977 X-MS-TrafficTypeDiagnostic: VE1PR08MB5775:|DB7PR08MB3481: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: x5NoGOX+m8JYbh3Jr1i1Qd0yn3Yztawp9ExyG5Z/aAwgO39QnaXPOkDIrEGiUzNI0C8m+59GOx9zRCPUyUE0lf1Vq9OZkAVLH4Ercz7M+8EhskOl5SfMT+D2wmiPFF3UMupggtm/rHIKRHf6Dd5X00vTD4BDsOx63Gek0zwSS4ssdkl38zsgMyGTEa4sUG4JbMiac+ShE4Me0sXxg7zIm3pfuUZ+0mwUB9rL1Mk9RHxQk19fzLmJR5DENJkNRM+2vqVbpcx9lspuCLBaAcwgIjNFS+0tc59Ca1Os8keq4xuEU59ASggMR16SvzP6a+9eJVC1E/vDB4X0zo8p3//cmzUqGwv4cw5Rqv5ZkxoqIwd778vmkTR3TvqJX4EkCTTnfhqUjJ7kn+Cbf1ZkXt32m2OyvSWcq7N94iO+e2wMEebFdwFonPpN1/clo0qqaz0c/2tKlqk5ltu1STnS/g4RRznQE44cy5WNoQh8ydiKj7AlRWVbRn+ycu1M3kvhxq7hmrMbMat9nJi2kxj8wF+8XgdDSk9RmnDhRgVPXUnme+lp7PGhr1FWZo+324JadDkoq+7qCDrTPdvAVVdIiU9eZEo6Lu1NqrSNgiqWDuGFR54= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3629.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(39860400002)(366004)(376002)(136003)(6486002)(16526019)(2906002)(44832011)(5660300002)(186003)(26005)(6666004)(33656002)(4744005)(86362001)(66556008)(66946007)(53546011)(66476007)(54906003)(52116002)(6916009)(7696005)(316002)(8936002)(956004)(2616005)(4326008)(36756003)(8676002)(478600001)(32563001)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NTFUSHlkSitrSXZDZU1rbTFJMWFUOEJidGNwd3pJR2g4V3Ezcy9IRnpDRjY0?= =?utf-8?B?KythdmcyMS9hTzZlNGpkSjkzRmdMWUd3VS9DaFF5bDQ3cUQ5cUZEMGUrNFhs?= =?utf-8?B?bEtLV1M5QlZ0NGlyTnpYOVE5UXRWN25pUDRTQW5MWXd4N1BkV2hQeExXcmQv?= =?utf-8?B?a1hlcFAxUm9iaWVrMmlRVWNHRm9WYmNEWmorUVBFNXY5VDFuWWdnRUN3R05i?= =?utf-8?B?Q0kyRWx3S2t0M3M2U2R3RTg5TGkxZWwvL251MDk3MkxKeE90Wm51MlNKYVlm?= =?utf-8?B?Mi82NEx0S1crdlpWVDlhYXZ2akpCcnFqdEh5Sk5mTjZhYWNuc1ZEUFE0N2NY?= =?utf-8?B?cVFyWWdkYXFPc0FPdVlrbC9xbkRVTTE2WXZ3Rm1tV3ZsdytDeFpUUStGdkVW?= =?utf-8?B?elNhYldYN2J4OTY5T2dud0VST0dnR2dIaGxWRWh0MlplcGZqZ2tNRldtT3Vt?= =?utf-8?B?anJvOEhwWjNSN1hqSmN3aytpZC9LbnVQYjlTR05kVGVXdWQxaE9kR2hpNm4v?= =?utf-8?B?YjUreWJaTzRkd0dkQXJBTzBRN005dDN2aDVwUUFFbUF4N2tHdlVZOUh6REVT?= =?utf-8?B?NFRibVkrM3c3ajlISCs5STQ0VGVIdWlPRlh6Y3pZeENzbzdjTFpuQmswd2wz?= =?utf-8?B?a2ttdGhZbXhVZXhDcmc1a3Q1MnZjcmRodVh6UC93VU5MaXdxV1hrb2R1ZE1v?= =?utf-8?B?UkZETUJzb3JCaWkzVkJWdlhIVTNNaitjLzI3Wk0xUjF5STlIdUtNNFNGMG1B?= =?utf-8?B?bVMvRURHZHZ2bzNPaFVOUEtlMml4aXdUc3hwK05wNkZCdGJMNjg1SllheDBP?= =?utf-8?B?OWJpSGR2Rk1PZE5td0J6aUp4R0N2c0dwdDlDaUxYbU14dzlZaWV4SmR1Tng2?= =?utf-8?B?YU1rcGx3Q0dtdmt3TDVXcDBwcWc2S1ZoeCtWNWJiOUQwOS9OMTlwY0szd3px?= =?utf-8?B?ck5BZisrVG1EREJoN2xFYzFkR1gzWlpnajdwNkRhT2F5bERnaVBYQVhCR0FJ?= =?utf-8?B?RDUzUUtUaEFMVzAvVW0vbE9wNW53TXJKSkZ1SkdrMHBlVFp3WlAzYXNuUVNz?= =?utf-8?B?T0EyWXNEWjFJWWZ6blY5d3dlNUJwbTFCMEVSTWZnZlEwMlZ1RTRFU3JLbjBy?= =?utf-8?B?VmludHhCdDh5Q0l4N3NaR2JNek5EajBUdTV4Z0NqQWp6amwyd3VvRUxwVWp6?= =?utf-8?B?Znh6cHB1S1N0N3JaejdXTnlVSlZCNjlOR28vVitPdmZqRXhBRWVCS3FvOXlm?= =?utf-8?B?cVZTamc3a1dGdEFzK2NiQ2U2bmZWUmxqa2ppRzRoZXRsYnh0NkNnelMrMGty?= =?utf-8?B?VGNwYW5uMjZBekhaQjdRYThJdzJpYVB0ZHBoTThJSnpwaDJ4elRIVGRTTk92?= =?utf-8?B?Z3A4YU95OHI4eDFWNlNWSVF6TDRLVDRwS2cwS2U3T3A0ay84akJVSmhXMlg5?= =?utf-8?B?UTVxR00zRU5FalRFZWZraStieHRWQnRCcGpjWUJ3bHQ3c01vUWo0UlhDc3p3?= =?utf-8?B?THlZM2l2T05LQ2hLSEJsaXg3cUtUWXlTZmE1dFVDY3Z3VmV2L3VFRkR0Mk80?= =?utf-8?B?WXZ6eXJrT2pmMXBaY3lGZFZUY3pPOUlHd3hBY3ZZQ0ppeXYvODFKSitPQzVN?= =?utf-8?B?MU5PTmJvV0REbWppUmRhaXZwdUt2RUhxRGN5YnlENnU4R0Z5eXR0a2thMWlI?= =?utf-8?B?RWxkdlFMenluZG1lU0xIdmdIL3loNmVBWFVDcFlabmo3dFNkbW1sdHBpRjBm?= =?utf-8?Q?VCkJLr0VEu5En6OcBaL8cBsIqXMDCUVOFL+6403?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5775 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 2c88a0f3-f06a-4eca-3132-08d8e22bb1fb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lng9GNk9zm6yo/pPvvUcdiWn8hqVC72QR7RC7N6TdoOEJfc1clBYXRPAk4hcsXnZrZ6IY2F1nNdtyVUpU0HlIkAjEJiuUeEGc9VeA3AYDzckuTaixOHFIRKHRXYtXJns8xQC6ET2eZmxp79X7/IabOyb83Er2smdWO4AMfAPm5XwqrDHYdmT1gRKeWjtORU2HLpObHaSLe0xzHjmNqEV+eL61RPz4TYAfrihzwMh3TtluN4ejOE0NpyPzekI7D+de6mK5PghsLSIAJ/1VwMpfWNP4FNq80UcaUvBIGJwJuGAeWZRHCL7dt4oXesMaikfy+vuh5oPlgGcwMdyhACZjECJtT14CDEUB+OfJ0DCPiOz3UMjImB9z1kzb6jOAPSBkQSPBFWIqovLqqfHwrXkNrSshXvXxF2DSCcBjmAe049e2su0n4YIg/ty0ld82d8kDlzhBoQhV93Epb3wmniG984ynOlmhtp47mwa14Cf/XWk+CD7fDuXcLw8yIW60VSAI2ML5O3uNMRK7iWT+1stj9hcy602kNHC9LB5ffaVNm948h0VtEsNpHsxXEOYuazIe1RLAldaVXJNd4UUI8auFHUMWgRtOSW56rMmF7kbtGeSPr225SS71zOZtXdrbjB5zQk2cbQIlFOh3wTbN7nzU86/Hr9wbrpRIgvNqnA9HlKveIKzZby6R2hf5qJSf6OX X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(376002)(39860400002)(346002)(136003)(36840700001)(46966006)(36860700001)(2616005)(356005)(70206006)(16526019)(956004)(6486002)(70586007)(86362001)(316002)(26005)(4744005)(53546011)(336012)(7696005)(8936002)(54906003)(5660300002)(44832011)(82740400003)(186003)(82310400003)(8676002)(33656002)(6666004)(2906002)(4326008)(81166007)(6862004)(478600001)(47076005)(36756003)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 12:14:29.4671 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f64dab4-347d-434a-04ee-08d8e22bb977 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3481 > On 8 Mar 2021, at 11:59, Julien Grall wrote: >=20 > Hi Luca, >=20 > On 08/03/2021 11:56, Luca Fancellu wrote: >> This patch prevents the dom0 to be loaded skipping its >> building and going forward to build domUs when the dom0 >> kernel is not found and at least one domU is present. >> Signed-off-by: Luca Fancellu > I have received 3 versions of this patch, can you clarify I should review= ? Hi Julien, I=E2=80=99m really sorry for the noise, because of a problem in my configur= ation I sent twice the same patch and it comes with a Change-Id: , this is = the correct one without the Change-Id. >=20 > If the modification is just the CC list, then we usually add RESEND in th= e subject. For all the other modifications, we bump the version (vX in suje= ct) and provide a changelog. Sure, next time I will add something to the changelog. >=20 > Cheers, >=20 > --=20 > Julien Grall >=20 Cheers, Luca= From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:28:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:28:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94850.178680 (Exim 4.92) (envelope-from ) id 1lJF0G-0004ni-Km; Mon, 08 Mar 2021 12:28:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94850.178680; Mon, 08 Mar 2021 12:28:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0G-0004nb-HW; Mon, 08 Mar 2021 12:28:52 +0000 Received: by outflank-mailman (input) for mailman id 94850; Mon, 08 Mar 2021 12:28:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0F-0004nW-GS for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:28:51 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0e7878a4-9810-4479-a6a5-d109f8b3cb83; Mon, 08 Mar 2021 12:28:50 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 74BD8AC54; Mon, 8 Mar 2021 12:28:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e7878a4-9810-4479-a6a5-d109f8b3cb83 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615206529; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lwxA20SDAEyST3opQlZ9hzTp/g3xcLqoUnJ7P0MzmB8=; b=kmRTs4o4dKYOCNahWofrTsHkMs5Gn8Terd0KSrZvSTOOBy7owvGGeZY807SznPlwAkR3a/ a71lIVLaLdAEzRCGid6ouhfLLyJn/Vne51eTP0zd71MmLqVDYi/Dn4w8UzfXNSxpJ4DKBJ m7bLZGEGLx01xgYEampZFgNDLEk/k+c= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Peter Zijlstra , Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel Subject: [PATCH v5 01/12] staticcall: move struct static_call_key definition to static_call_types.h Date: Mon, 8 Mar 2021 13:28:33 +0100 Message-Id: <20210308122844.30488-2-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210308122844.30488-1-jgross@suse.com> References: <20210308122844.30488-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Having the definition of static_call() in static_call_types.h makes no sense as long struct static_call_key isn't defined there, as the generic implementation of static_call() is referencing this structure. So move the definition of struct static_call_key to static_call_types.h. Signed-off-by: Juergen Gross --- V5: - new patch --- include/linux/static_call.h | 18 ------------------ include/linux/static_call_types.h | 18 ++++++++++++++++++ tools/include/linux/static_call_types.h | 18 ++++++++++++++++++ 3 files changed, 36 insertions(+), 18 deletions(-) diff --git a/include/linux/static_call.h b/include/linux/static_call.h index 85ecc789f4ff..76b881259144 100644 --- a/include/linux/static_call.h +++ b/include/linux/static_call.h @@ -128,16 +128,6 @@ struct static_call_mod { struct static_call_site *sites; }; -struct static_call_key { - void *func; - union { - /* bit 0: 0 = mods, 1 = sites */ - unsigned long type; - struct static_call_mod *mods; - struct static_call_site *sites; - }; -}; - /* For finding the key associated with a trampoline */ struct static_call_tramp_key { s32 tramp; @@ -187,10 +177,6 @@ extern long __static_call_return0(void); static inline int static_call_init(void) { return 0; } -struct static_call_key { - void *func; -}; - #define __DEFINE_STATIC_CALL(name, _func, _func_init) \ DECLARE_STATIC_CALL(name, _func); \ struct static_call_key STATIC_CALL_KEY(name) = { \ @@ -243,10 +229,6 @@ static inline long __static_call_return0(void) static inline int static_call_init(void) { return 0; } -struct static_call_key { - void *func; -}; - static inline long __static_call_return0(void) { return 0; diff --git a/include/linux/static_call_types.h b/include/linux/static_call_types.h index ae5662d368b9..5a00b8b2cf9f 100644 --- a/include/linux/static_call_types.h +++ b/include/linux/static_call_types.h @@ -58,11 +58,25 @@ struct static_call_site { __raw_static_call(name); \ }) +struct static_call_key { + void *func; + union { + /* bit 0: 0 = mods, 1 = sites */ + unsigned long type; + struct static_call_mod *mods; + struct static_call_site *sites; + }; +}; + #else /* !CONFIG_HAVE_STATIC_CALL_INLINE */ #define __STATIC_CALL_ADDRESSABLE(name) #define __static_call(name) __raw_static_call(name) +struct static_call_key { + void *func; +}; + #endif /* CONFIG_HAVE_STATIC_CALL_INLINE */ #ifdef MODULE @@ -77,6 +91,10 @@ struct static_call_site { #else +struct static_call_key { + void *func; +}; + #define static_call(name) \ ((typeof(STATIC_CALL_TRAMP(name))*)(STATIC_CALL_KEY(name).func)) diff --git a/tools/include/linux/static_call_types.h b/tools/include/linux/static_call_types.h index ae5662d368b9..5a00b8b2cf9f 100644 --- a/tools/include/linux/static_call_types.h +++ b/tools/include/linux/static_call_types.h @@ -58,11 +58,25 @@ struct static_call_site { __raw_static_call(name); \ }) +struct static_call_key { + void *func; + union { + /* bit 0: 0 = mods, 1 = sites */ + unsigned long type; + struct static_call_mod *mods; + struct static_call_site *sites; + }; +}; + #else /* !CONFIG_HAVE_STATIC_CALL_INLINE */ #define __STATIC_CALL_ADDRESSABLE(name) #define __static_call(name) __raw_static_call(name) +struct static_call_key { + void *func; +}; + #endif /* CONFIG_HAVE_STATIC_CALL_INLINE */ #ifdef MODULE @@ -77,6 +91,10 @@ struct static_call_site { #else +struct static_call_key { + void *func; +}; + #define static_call(name) \ ((typeof(STATIC_CALL_TRAMP(name))*)(STATIC_CALL_KEY(name).func)) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:28:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:28:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94851.178692 (Exim 4.92) (envelope-from ) id 1lJF0I-0004oo-Sf; Mon, 08 Mar 2021 12:28:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94851.178692; Mon, 08 Mar 2021 12:28:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0I-0004oh-PZ; Mon, 08 Mar 2021 12:28:54 +0000 Received: by outflank-mailman (input) for mailman id 94851; Mon, 08 Mar 2021 12:28:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0H-0004oO-6w for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:28:53 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b196f617-02a3-4284-99b5-d6ceabb29440; Mon, 08 Mar 2021 12:28:51 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C40CCAD87; Mon, 8 Mar 2021 12:28:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b196f617-02a3-4284-99b5-d6ceabb29440 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615206530; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AmZ4aGz4K80se4EUVR17Db7xntpSeR5C5fS3BvWpgIw=; b=CH99PWZ6ZOyR+G56mFI3ckGT68QOmth2XBLqlfe/znAM4Wb0+aLF09fpeVepRlHbQarYYZ o4yVIMUg2zb+04V9sgrVLq25zJCu4+3PefC+WqkAi4Rlb5tOlCcpKYje4T7Xs74C7OwHcG WujYX2oZUDeIqS8/KmYx5I76ekDmLWE= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: [PATCH v5 05/12] x86/alternative: support ALTERNATIVE_TERNARY Date: Mon, 8 Mar 2021 13:28:37 +0100 Message-Id: <20210308122844.30488-6-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210308122844.30488-1-jgross@suse.com> References: <20210308122844.30488-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add ALTERNATIVE_TERNARY support for replacing an initial instruction with either of two instructions depending on a feature: ALTERNATIVE_TERNARY "default_instr", FEATURE_NR, "feature_on_instr", "feature_off_instr" which will start with "default_instr" and at patch time will, depending on FEATURE_NR being set or not, patch that with either "feature_on_instr" or "feature_off_instr". Signed-off-by: Juergen Gross --- V3: - new patch V4: - use X86_FEATURE_ALWAYS instead of negated feature (Boris Petkov) - unfortunately this isn't enough to get rid of the "not feature" support, as this is needed in the patch "x86/paravirt: switch functions with custom code to ALTERNATIVE", too V5: - carve out the "not feature" part --- arch/x86/include/asm/alternative-asm.h | 4 ++++ arch/x86/include/asm/alternative.h | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/arch/x86/include/asm/alternative-asm.h b/arch/x86/include/asm/alternative-asm.h index 9a1763550217..ba0aad81d3bb 100644 --- a/arch/x86/include/asm/alternative-asm.h +++ b/arch/x86/include/asm/alternative-asm.h @@ -115,6 +115,10 @@ .popsection .endm +#define ALTERNATIVE_TERNARY(oldinstr, feature, newinstr1, newinstr2) \ + ALTERNATIVE_2 oldinstr, newinstr2, X86_FEATURE_ALWAYS, \ + newinstr1, feature + #endif /* __ASSEMBLY__ */ #endif /* _ASM_X86_ALTERNATIVE_ASM_H */ diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h index b9749cf21ada..693991f8fe89 100644 --- a/arch/x86/include/asm/alternative.h +++ b/arch/x86/include/asm/alternative.h @@ -183,6 +183,9 @@ static inline int alternatives_text_reserved(void *start, void *end) ALTINSTR_REPLACEMENT(newinstr2, 2) \ ".popsection\n" +#define ALTERNATIVE_TERNARY(oldinstr, feature, newinstr1, newinstr2) \ + ALTERNATIVE_2(oldinstr, newinstr2, X86_FEATURE_ALWAYS, newinstr1, feature) + #define ALTERNATIVE_3(oldinsn, newinsn1, feat1, newinsn2, feat2, newinsn3, feat3) \ OLDINSTR_3(oldinsn, 1, 2, 3) \ ".pushsection .altinstructions,\"a\"\n" \ @@ -214,6 +217,9 @@ static inline int alternatives_text_reserved(void *start, void *end) #define alternative_2(oldinstr, newinstr1, feature1, newinstr2, feature2) \ asm_inline volatile(ALTERNATIVE_2(oldinstr, newinstr1, feature1, newinstr2, feature2) ::: "memory") +#define alternative_ternary(oldinstr, feature, newinstr1, newinstr2) \ + asm_inline volatile(ALTERNATIVE_TERNARY(oldinstr, feature, newinstr1, newinstr2) ::: "memory") + /* * Alternative inline assembly with input. * -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:28:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:28:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94852.178704 (Exim 4.92) (envelope-from ) id 1lJF0L-0004qr-5T; Mon, 08 Mar 2021 12:28:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94852.178704; Mon, 08 Mar 2021 12:28:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0L-0004qi-2K; Mon, 08 Mar 2021 12:28:57 +0000 Received: by outflank-mailman (input) for mailman id 94852; Mon, 08 Mar 2021 12:28:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0K-0004nW-A3 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:28:56 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3be574c1-2982-48d4-b9d0-3531386570ff; Mon, 08 Mar 2021 12:28:51 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4C7CCAD57; Mon, 8 Mar 2021 12:28:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3be574c1-2982-48d4-b9d0-3531386570ff X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615206530; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kuZklKgnYa6USpuMOuRhMmMWaIjF31okmqD4U9eV8KM=; b=W1rg7I4mSnI7bxqhI9Vz7U6qCMv1HNnLgVfzWQwSnkCWkj5KpdmCPBZPnCOiGrIFi2I7Xl w/M0vn+sH6R9Mu5mGQmuNqvC/B/dSPaOeHHDN/27UtBhAzfVTGjUA2/q0bVe8fDx5OHa3p uieCC9CvFKcOShPtLPvHPGBNhy+llaE= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: [PATCH v5 03/12] x86/alternative: drop feature parameter from ALTINSTR_REPLACEMENT() Date: Mon, 8 Mar 2021 13:28:35 +0100 Message-Id: <20210308122844.30488-4-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210308122844.30488-1-jgross@suse.com> References: <20210308122844.30488-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The macro ALTINSTR_REPLACEMENT() doesn't make use of the feature parameter, so drop it. Signed-off-by: Juergen Gross --- V5: - new patch --- arch/x86/include/asm/alternative.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h index 13adca37c99a..5753fb2ac489 100644 --- a/arch/x86/include/asm/alternative.h +++ b/arch/x86/include/asm/alternative.h @@ -150,7 +150,7 @@ static inline int alternatives_text_reserved(void *start, void *end) " .byte " alt_rlen(num) "\n" /* replacement len */ \ " .byte " alt_pad_len "\n" /* pad len */ -#define ALTINSTR_REPLACEMENT(newinstr, feature, num) /* replacement */ \ +#define ALTINSTR_REPLACEMENT(newinstr, num) /* replacement */ \ "# ALT: replacement " #num "\n" \ b_replacement(num)":\n\t" newinstr "\n" e_replacement(num) ":\n" @@ -161,7 +161,7 @@ static inline int alternatives_text_reserved(void *start, void *end) ALTINSTR_ENTRY(feature, 1) \ ".popsection\n" \ ".pushsection .altinstr_replacement, \"ax\"\n" \ - ALTINSTR_REPLACEMENT(newinstr, feature, 1) \ + ALTINSTR_REPLACEMENT(newinstr, 1) \ ".popsection\n" #define ALTERNATIVE_2(oldinstr, newinstr1, feature1, newinstr2, feature2)\ @@ -171,8 +171,8 @@ static inline int alternatives_text_reserved(void *start, void *end) ALTINSTR_ENTRY(feature2, 2) \ ".popsection\n" \ ".pushsection .altinstr_replacement, \"ax\"\n" \ - ALTINSTR_REPLACEMENT(newinstr1, feature1, 1) \ - ALTINSTR_REPLACEMENT(newinstr2, feature2, 2) \ + ALTINSTR_REPLACEMENT(newinstr1, 1) \ + ALTINSTR_REPLACEMENT(newinstr2, 2) \ ".popsection\n" #define ALTERNATIVE_3(oldinsn, newinsn1, feat1, newinsn2, feat2, newinsn3, feat3) \ @@ -183,9 +183,9 @@ static inline int alternatives_text_reserved(void *start, void *end) ALTINSTR_ENTRY(feat3, 3) \ ".popsection\n" \ ".pushsection .altinstr_replacement, \"ax\"\n" \ - ALTINSTR_REPLACEMENT(newinsn1, feat1, 1) \ - ALTINSTR_REPLACEMENT(newinsn2, feat2, 2) \ - ALTINSTR_REPLACEMENT(newinsn3, feat3, 3) \ + ALTINSTR_REPLACEMENT(newinsn1, 1) \ + ALTINSTR_REPLACEMENT(newinsn2, 2) \ + ALTINSTR_REPLACEMENT(newinsn3, 3) \ ".popsection\n" /* -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:28:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:28:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94853.178716 (Exim 4.92) (envelope-from ) id 1lJF0N-0004u1-G9; Mon, 08 Mar 2021 12:28:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94853.178716; Mon, 08 Mar 2021 12:28:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0N-0004tn-Ce; Mon, 08 Mar 2021 12:28:59 +0000 Received: by outflank-mailman (input) for mailman id 94853; Mon, 08 Mar 2021 12:28:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0M-0004oO-2G for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:28:58 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3a96e198-05fa-493c-ab09-e283bd111ef3; Mon, 08 Mar 2021 12:28:51 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9F935AD74; Mon, 8 Mar 2021 12:28:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a96e198-05fa-493c-ab09-e283bd111ef3 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615206530; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J66CWuwKwfzFPvCq/m8D63U++K/o7dDSv22aN/eKP7M=; b=cIXiUqxf03980MHxBeIJz7vODEC6tQtd6/lUgwJufF8vAwaGi1A80YufivneEt5GZP/2E8 v70lIPnIEGXuQi2CqELG40DuUwx+olazP2WTKu8piVPTmYHrvFbzH5GBP7rz87skFklWM4 RZyo17tov8ZR5dCZ9W3sgwYURK9c2HU= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini Subject: [PATCH v5 02/12] x86/paravirt: switch time pvops functions to use static_call() Date: Mon, 8 Mar 2021 13:28:34 +0100 Message-Id: <20210308122844.30488-3-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210308122844.30488-1-jgross@suse.com> References: <20210308122844.30488-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The time pvops functions are the only ones left which might be used in 32-bit mode and which return a 64-bit value. Switch them to use the static_call() mechanism instead of pvops, as this allows quite some simplification of the pvops implementation. Signed-off-by: Juergen Gross --- V4: - drop paravirt_time.h again - don't move Hyper-V code (Michael Kelley) V5: - drop no longer needed Hyper-V modification (Michael Kelley) - switch Arm and Arm64 to static_call(), too (kernel test robot) --- arch/arm/include/asm/paravirt.h | 14 +++++--------- arch/arm/kernel/paravirt.c | 9 +++++++-- arch/arm64/include/asm/paravirt.h | 14 +++++--------- arch/arm64/kernel/paravirt.c | 13 +++++++++---- arch/x86/Kconfig | 1 + arch/x86/include/asm/mshyperv.h | 2 +- arch/x86/include/asm/paravirt.h | 17 ++++++++++++++--- arch/x86/include/asm/paravirt_types.h | 6 ------ arch/x86/kernel/cpu/vmware.c | 5 +++-- arch/x86/kernel/kvm.c | 2 +- arch/x86/kernel/kvmclock.c | 2 +- arch/x86/kernel/paravirt.c | 16 ++++++++++++---- arch/x86/kernel/tsc.c | 2 +- arch/x86/xen/time.c | 11 ++++------- drivers/xen/time.c | 3 ++- 15 files changed, 66 insertions(+), 51 deletions(-) diff --git a/arch/arm/include/asm/paravirt.h b/arch/arm/include/asm/paravirt.h index cdbf02d9c1d4..95d5b0d625cd 100644 --- a/arch/arm/include/asm/paravirt.h +++ b/arch/arm/include/asm/paravirt.h @@ -3,23 +3,19 @@ #define _ASM_ARM_PARAVIRT_H #ifdef CONFIG_PARAVIRT +#include + struct static_key; extern struct static_key paravirt_steal_enabled; extern struct static_key paravirt_steal_rq_enabled; -struct pv_time_ops { - unsigned long long (*steal_clock)(int cpu); -}; - -struct paravirt_patch_template { - struct pv_time_ops time; -}; +u64 dummy_steal_clock(int cpu); -extern struct paravirt_patch_template pv_ops; +DECLARE_STATIC_CALL(pv_steal_clock, dummy_steal_clock); static inline u64 paravirt_steal_clock(int cpu) { - return pv_ops.time.steal_clock(cpu); + return static_call(pv_steal_clock)(cpu); } #endif diff --git a/arch/arm/kernel/paravirt.c b/arch/arm/kernel/paravirt.c index 4cfed91fe256..7dd9806369fb 100644 --- a/arch/arm/kernel/paravirt.c +++ b/arch/arm/kernel/paravirt.c @@ -9,10 +9,15 @@ #include #include #include +#include #include struct static_key paravirt_steal_enabled; struct static_key paravirt_steal_rq_enabled; -struct paravirt_patch_template pv_ops; -EXPORT_SYMBOL_GPL(pv_ops); +static u64 native_steal_clock(int cpu) +{ + return 0; +} + +DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock); diff --git a/arch/arm64/include/asm/paravirt.h b/arch/arm64/include/asm/paravirt.h index cf3a0fd7c1a7..9aa193e0e8f2 100644 --- a/arch/arm64/include/asm/paravirt.h +++ b/arch/arm64/include/asm/paravirt.h @@ -3,23 +3,19 @@ #define _ASM_ARM64_PARAVIRT_H #ifdef CONFIG_PARAVIRT +#include + struct static_key; extern struct static_key paravirt_steal_enabled; extern struct static_key paravirt_steal_rq_enabled; -struct pv_time_ops { - unsigned long long (*steal_clock)(int cpu); -}; - -struct paravirt_patch_template { - struct pv_time_ops time; -}; +u64 dummy_steal_clock(int cpu); -extern struct paravirt_patch_template pv_ops; +DECLARE_STATIC_CALL(pv_steal_clock, dummy_steal_clock); static inline u64 paravirt_steal_clock(int cpu) { - return pv_ops.time.steal_clock(cpu); + return static_call(pv_steal_clock)(cpu); } int __init pv_time_init(void); diff --git a/arch/arm64/kernel/paravirt.c b/arch/arm64/kernel/paravirt.c index c07d7a034941..75fed4460407 100644 --- a/arch/arm64/kernel/paravirt.c +++ b/arch/arm64/kernel/paravirt.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include @@ -26,8 +27,12 @@ struct static_key paravirt_steal_enabled; struct static_key paravirt_steal_rq_enabled; -struct paravirt_patch_template pv_ops; -EXPORT_SYMBOL_GPL(pv_ops); +static u64 native_steal_clock(int cpu) +{ + return 0; +} + +DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock); struct pv_time_stolen_time_region { struct pvclock_vcpu_stolen_time *kaddr; @@ -45,7 +50,7 @@ static int __init parse_no_stealacc(char *arg) early_param("no-steal-acc", parse_no_stealacc); /* return stolen time in ns by asking the hypervisor */ -static u64 pv_steal_clock(int cpu) +static u64 para_steal_clock(int cpu) { struct pv_time_stolen_time_region *reg; @@ -150,7 +155,7 @@ int __init pv_time_init(void) if (ret) return ret; - pv_ops.time.steal_clock = pv_steal_clock; + static_call_update(pv_steal_clock, para_steal_clock); static_key_slow_inc(¶virt_steal_enabled); if (steal_acc) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 2792879d398e..107acc403b3b 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -777,6 +777,7 @@ if HYPERVISOR_GUEST config PARAVIRT bool "Enable paravirtualization code" + depends on HAVE_STATIC_CALL help This changes the kernel so it can modify itself when it is run under a hypervisor, potentially improving performance significantly diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h index ccf60a809a17..e7be720062a8 100644 --- a/arch/x86/include/asm/mshyperv.h +++ b/arch/x86/include/asm/mshyperv.h @@ -63,7 +63,7 @@ typedef int (*hyperv_fill_flush_list_func)( static __always_inline void hv_setup_sched_clock(void *sched_clock) { #ifdef CONFIG_PARAVIRT - pv_ops.time.sched_clock = sched_clock; + paravirt_set_sched_clock(sched_clock); #endif } diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 4abf110e2243..1e45b46fae84 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -15,11 +15,22 @@ #include #include #include +#include #include -static inline unsigned long long paravirt_sched_clock(void) +u64 dummy_steal_clock(int cpu); +u64 dummy_sched_clock(void); + +DECLARE_STATIC_CALL(pv_steal_clock, dummy_steal_clock); +DECLARE_STATIC_CALL(pv_sched_clock, dummy_sched_clock); + +extern bool paravirt_using_native_sched_clock; + +void paravirt_set_sched_clock(u64 (*func)(void)); + +static inline u64 paravirt_sched_clock(void) { - return PVOP_CALL0(unsigned long long, time.sched_clock); + return static_call(pv_sched_clock)(); } struct static_key; @@ -33,7 +44,7 @@ bool pv_is_native_vcpu_is_preempted(void); static inline u64 paravirt_steal_clock(int cpu) { - return PVOP_CALL1(u64, time.steal_clock, cpu); + return static_call(pv_steal_clock)(cpu); } /* The paravirtualized I/O functions */ diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index de87087d3bde..1fff349e4792 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -95,11 +95,6 @@ struct pv_lazy_ops { } __no_randomize_layout; #endif -struct pv_time_ops { - unsigned long long (*sched_clock)(void); - unsigned long long (*steal_clock)(int cpu); -} __no_randomize_layout; - struct pv_cpu_ops { /* hooks for various privileged instructions */ void (*io_delay)(void); @@ -291,7 +286,6 @@ struct pv_lock_ops { * what to patch. */ struct paravirt_patch_template { struct pv_init_ops init; - struct pv_time_ops time; struct pv_cpu_ops cpu; struct pv_irq_ops irq; struct pv_mmu_ops mmu; diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index c6ede3b3d302..84fb8e3f3d1b 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #include #include @@ -336,11 +337,11 @@ static void __init vmware_paravirt_ops_setup(void) vmware_cyc2ns_setup(); if (vmw_sched_clock) - pv_ops.time.sched_clock = vmware_sched_clock; + paravirt_set_sched_clock(vmware_sched_clock); if (vmware_is_stealclock_available()) { has_steal_clock = true; - pv_ops.time.steal_clock = vmware_steal_clock; + static_call_update(pv_steal_clock, vmware_steal_clock); /* We use reboot notifier only to disable steal clock */ register_reboot_notifier(&vmware_pv_reboot_nb); diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 5e78e01ca3b4..351ba99f6009 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -650,7 +650,7 @@ static void __init kvm_guest_init(void) if (kvm_para_has_feature(KVM_FEATURE_STEAL_TIME)) { has_steal_clock = 1; - pv_ops.time.steal_clock = kvm_steal_clock; + static_call_update(pv_steal_clock, kvm_steal_clock); } if (pv_tlb_flush_supported()) { diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index aa593743acf6..01e7c1839ace 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -106,7 +106,7 @@ static inline void kvm_sched_clock_init(bool stable) if (!stable) clear_sched_clock_stable(); kvm_sched_clock_offset = kvm_clock_read(); - pv_ops.time.sched_clock = kvm_sched_clock_read; + paravirt_set_sched_clock(kvm_sched_clock_read); pr_info("kvm-clock: using sched offset of %llu cycles", kvm_sched_clock_offset); diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index c60222ab8ab9..44e5b0fe28cb 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include @@ -167,6 +168,17 @@ static u64 native_steal_clock(int cpu) return 0; } +DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock); +DEFINE_STATIC_CALL(pv_sched_clock, native_sched_clock); + +bool paravirt_using_native_sched_clock = true; + +void paravirt_set_sched_clock(u64 (*func)(void)) +{ + static_call_update(pv_sched_clock, func); + paravirt_using_native_sched_clock = (func == native_sched_clock); +} + /* These are in entry.S */ extern void native_iret(void); @@ -272,10 +284,6 @@ struct paravirt_patch_template pv_ops = { /* Init ops. */ .init.patch = native_patch, - /* Time ops. */ - .time.sched_clock = native_sched_clock, - .time.steal_clock = native_steal_clock, - /* Cpu ops. */ .cpu.io_delay = native_io_delay, diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index f70dffc2771f..b6f7853d8077 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -254,7 +254,7 @@ unsigned long long sched_clock(void) bool using_native_sched_clock(void) { - return pv_ops.time.sched_clock == native_sched_clock; + return paravirt_using_native_sched_clock; } #else unsigned long long diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 91f5b330dcc6..01930e182e99 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -379,11 +379,6 @@ void xen_timer_resume(void) } } -static const struct pv_time_ops xen_time_ops __initconst = { - .sched_clock = xen_sched_clock, - .steal_clock = xen_steal_clock, -}; - static struct pvclock_vsyscall_time_info *xen_clock __read_mostly; static u64 xen_clock_value_saved; @@ -528,7 +523,8 @@ static void __init xen_time_init(void) void __init xen_init_time_ops(void) { xen_sched_clock_offset = xen_clocksource_read(); - pv_ops.time = xen_time_ops; + static_call_update(pv_steal_clock, xen_steal_clock); + paravirt_set_sched_clock(xen_sched_clock); x86_init.timers.timer_init = xen_time_init; x86_init.timers.setup_percpu_clockev = x86_init_noop; @@ -570,7 +566,8 @@ void __init xen_hvm_init_time_ops(void) } xen_sched_clock_offset = xen_clocksource_read(); - pv_ops.time = xen_time_ops; + static_call_update(pv_steal_clock, xen_steal_clock); + paravirt_set_sched_clock(xen_sched_clock); x86_init.timers.setup_percpu_clockev = xen_time_init; x86_cpuinit.setup_percpu_clockev = xen_hvm_setup_cpu_clockevents; diff --git a/drivers/xen/time.c b/drivers/xen/time.c index 108edbcbc040..152dd33bb223 100644 --- a/drivers/xen/time.c +++ b/drivers/xen/time.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include @@ -175,7 +176,7 @@ void __init xen_time_setup_guest(void) xen_runstate_remote = !HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_runstate_update_flag); - pv_ops.time.steal_clock = xen_steal_clock; + static_call_update(pv_steal_clock, xen_steal_clock); static_key_slow_inc(¶virt_steal_enabled); if (xen_runstate_remote) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:29:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:29:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94854.178728 (Exim 4.92) (envelope-from ) id 1lJF0Q-0004yG-Us; Mon, 08 Mar 2021 12:29:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94854.178728; Mon, 08 Mar 2021 12:29:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0Q-0004y9-Qz; Mon, 08 Mar 2021 12:29:02 +0000 Received: by outflank-mailman (input) for mailman id 94854; Mon, 08 Mar 2021 12:29:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0P-0004nW-AA for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:29:01 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 65108507-ec09-4e9a-b903-90b38b0bb3b9; Mon, 08 Mar 2021 12:28:51 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8A636AD73; Mon, 8 Mar 2021 12:28:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65108507-ec09-4e9a-b903-90b38b0bb3b9 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615206530; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=256H1k7Fa3HpWRn/najlrX8F12wVH//y72/kSGmicik=; b=kIBCYqb5tkrSpCJXtvHEorRcAyKDGDZaB27lX6JiUAOPpHakZWRFRvonM0e4PMNt4G44vO dfR8a2VElVq4arTI9m2rHkQ9dbNnqpAHSybQ58sX5ryEoDSA8FXmjo5dyX1EqjtbupnKcA bRXYdPfhmTmZbiCkN9Pg8AULDdXLaqw= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Josh Poimboeuf , Peter Zijlstra Subject: [PATCH v5 04/12] x86/alternative: support not-feature Date: Mon, 8 Mar 2021 13:28:36 +0100 Message-Id: <20210308122844.30488-5-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210308122844.30488-1-jgross@suse.com> References: <20210308122844.30488-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for alternative patching for the case a feature is not present on the current cpu. For this purpose add a flag byte to struct alt_instr adding the information that the inverted feature should be used. For users of ALTERNATIVE() and friends an inverted feature is specified by negating it, e.g.: ALTERNATIVE(old, new, ~feature) This requires adapting the objtool information for struct alt_instr. Signed-off-by: Juergen Gross --- V5: - split off from next patch - reworked to use flag byte (Boris Petkov) --- arch/x86/include/asm/alternative-asm.h | 6 ++++++ arch/x86/include/asm/alternative.h | 8 ++++++++ arch/x86/include/asm/cpufeature.h | 2 ++ arch/x86/kernel/alternative.c | 5 +++-- tools/objtool/arch/x86/include/arch/special.h | 6 +++--- 5 files changed, 22 insertions(+), 5 deletions(-) diff --git a/arch/x86/include/asm/alternative-asm.h b/arch/x86/include/asm/alternative-asm.h index 464034db299f..9a1763550217 100644 --- a/arch/x86/include/asm/alternative-asm.h +++ b/arch/x86/include/asm/alternative-asm.h @@ -39,7 +39,13 @@ .macro altinstruction_entry orig alt feature orig_len alt_len pad_len .long \orig - . .long \alt - . + .iflt \feature + .word ~(\feature) + .byte 1 + .else .word \feature + .byte 0 + .endif .byte \orig_len .byte \alt_len .byte \pad_len diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h index 5753fb2ac489..b9749cf21ada 100644 --- a/arch/x86/include/asm/alternative.h +++ b/arch/x86/include/asm/alternative.h @@ -59,6 +59,8 @@ struct alt_instr { s32 instr_offset; /* original instruction */ s32 repl_offset; /* offset to replacement instruction */ u16 cpuid; /* cpuid bit set for replacement */ + u8 flag; /* flag byte */ +#define ALTINSTR_FLAG_INV 0x01 u8 instrlen; /* length of original instruction */ u8 replacementlen; /* length of new instruction */ u8 padlen; /* length of build-time padding */ @@ -145,7 +147,13 @@ static inline int alternatives_text_reserved(void *start, void *end) #define ALTINSTR_ENTRY(feature, num) \ " .long 661b - .\n" /* label */ \ " .long " b_replacement(num)"f - .\n" /* new instruction */ \ + " .iflt " __stringify(feature) "\n" /* inverted? */ \ + " .word ~(" __stringify(feature) ")\n" /* feature bit */ \ + " .byte " __stringify(ALTINSTR_FLAG_INV) "\n" /* flag byte */ \ + " .else\n" \ " .word " __stringify(feature) "\n" /* feature bit */ \ + " .byte 0\n" /* flag byte */ \ + " .endif\n" \ " .byte " alt_total_slen "\n" /* source len */ \ " .byte " alt_rlen(num) "\n" /* replacement len */ \ " .byte " alt_pad_len "\n" /* pad len */ diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h index 1728d4ce5730..f060d3186ee4 100644 --- a/arch/x86/include/asm/cpufeature.h +++ b/arch/x86/include/asm/cpufeature.h @@ -184,6 +184,7 @@ static __always_inline bool _static_cpu_has(u16 bit) " .long 1b - .\n" /* src offset */ " .long 4f - .\n" /* repl offset */ " .word %P[always]\n" /* always replace */ + " .byte 0\n" /* flag byte */ " .byte 3b - 1b\n" /* src len */ " .byte 5f - 4f\n" /* repl len */ " .byte 3b - 2b\n" /* pad len */ @@ -196,6 +197,7 @@ static __always_inline bool _static_cpu_has(u16 bit) " .long 1b - .\n" /* src offset */ " .long 0\n" /* no replacement */ " .word %P[feature]\n" /* feature bit */ + " .byte 0\n" /* flag byte */ " .byte 3b - 1b\n" /* src len */ " .byte 0\n" /* repl len */ " .byte 0\n" /* pad len */ diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index 8d778e46725d..1296a90aa5b8 100644 --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -393,14 +393,15 @@ void __init_or_module noinline apply_alternatives(struct alt_instr *start, replacement = (u8 *)&a->repl_offset + a->repl_offset; BUG_ON(a->instrlen > sizeof(insn_buff)); BUG_ON(a->cpuid >= (NCAPINTS + NBUGINTS) * 32); - if (!boot_cpu_has(a->cpuid)) { + if (!boot_cpu_has(a->cpuid) == !(a->flag & ALTINSTR_FLAG_INV)) { if (a->padlen > 1) optimize_nops(a, instr); continue; } - DPRINTK("feat: %d*32+%d, old: (%pS (%px) len: %d), repl: (%px, len: %d), pad: %d", + DPRINTK("feat: %s%d*32+%d, old: (%pS (%px) len: %d), repl: (%px, len: %d), pad: %d", + (a->flag & ALTINSTR_FLAG_INV) ? "~" : "", a->cpuid >> 5, a->cpuid & 0x1f, instr, instr, a->instrlen, diff --git a/tools/objtool/arch/x86/include/arch/special.h b/tools/objtool/arch/x86/include/arch/special.h index d818b2bffa02..afde39063963 100644 --- a/tools/objtool/arch/x86/include/arch/special.h +++ b/tools/objtool/arch/x86/include/arch/special.h @@ -10,11 +10,11 @@ #define JUMP_ORIG_OFFSET 0 #define JUMP_NEW_OFFSET 4 -#define ALT_ENTRY_SIZE 13 +#define ALT_ENTRY_SIZE 14 #define ALT_ORIG_OFFSET 0 #define ALT_NEW_OFFSET 4 #define ALT_FEATURE_OFFSET 8 -#define ALT_ORIG_LEN_OFFSET 10 -#define ALT_NEW_LEN_OFFSET 11 +#define ALT_ORIG_LEN_OFFSET 11 +#define ALT_NEW_LEN_OFFSET 12 #endif /* _X86_ARCH_SPECIAL_H */ -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:29:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:29:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94855.178739 (Exim 4.92) (envelope-from ) id 1lJF0S-00050e-BY; Mon, 08 Mar 2021 12:29:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94855.178739; Mon, 08 Mar 2021 12:29:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0S-00050U-7K; Mon, 08 Mar 2021 12:29:04 +0000 Received: by outflank-mailman (input) for mailman id 94855; Mon, 08 Mar 2021 12:29:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0R-0004oO-2d for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:29:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9751bea7-d149-4868-944a-b0cebfa6788f; Mon, 08 Mar 2021 12:28:51 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 18F67ADDB; Mon, 8 Mar 2021 12:28:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9751bea7-d149-4868-944a-b0cebfa6788f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615206531; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vgl/JWA4fVb0I9JhPSVrr1rdgr2fz1+oJzHmt6wTrys=; b=IWQn5cuqU2UPwrvfspsUqOhx29PSjVJw4RuGFmrLMSTlFouMQ4xwDjTaMmeAD142p7nT0v WJpVNKOvvPuwCR8xEMmTgvOVqAeIrFfE5wrCBCr+RJ5bClt+DSDGM5LYtOKOtB3x3g1+ls +Rjb2ccVbkKmq78oF1XMjKG+Dz5eRMY= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Deep Shah , "VMware, Inc." Subject: [PATCH v5 06/12] x86: add new features for paravirt patching Date: Mon, 8 Mar 2021 13:28:38 +0100 Message-Id: <20210308122844.30488-7-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210308122844.30488-1-jgross@suse.com> References: <20210308122844.30488-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit For being able to switch paravirt patching from special cased custom code sequences to ALTERNATIVE handling some X86_FEATURE_* are needed as new features. This enables to have the standard indirect pv call as the default code and to patch that with the non-Xen custom code sequence via ALTERNATIVE patching later. Make sure paravirt patching is performed before alternative patching. Signed-off-by: Juergen Gross --- V3: - add comment (Boris Petkov) - no negative features (Boris Petkov) V4: - move paravirt_set_cap() to paravirt-spinlocks.c --- arch/x86/include/asm/cpufeatures.h | 2 ++ arch/x86/include/asm/paravirt.h | 10 ++++++++++ arch/x86/kernel/alternative.c | 30 ++++++++++++++++++++++++++-- arch/x86/kernel/paravirt-spinlocks.c | 9 +++++++++ 4 files changed, 49 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h index cc96e26d69f7..b440c950246d 100644 --- a/arch/x86/include/asm/cpufeatures.h +++ b/arch/x86/include/asm/cpufeatures.h @@ -236,6 +236,8 @@ #define X86_FEATURE_EPT_AD ( 8*32+17) /* Intel Extended Page Table access-dirty bit */ #define X86_FEATURE_VMCALL ( 8*32+18) /* "" Hypervisor supports the VMCALL instruction */ #define X86_FEATURE_VMW_VMMCALL ( 8*32+19) /* "" VMware prefers VMMCALL hypercall instruction */ +#define X86_FEATURE_PVUNLOCK ( 8*32+20) /* "" PV unlock function */ +#define X86_FEATURE_VCPUPREEMPT ( 8*32+21) /* "" PV vcpu_is_preempted function */ /* Intel-defined CPU features, CPUID level 0x00000007:0 (EBX), word 9 */ #define X86_FEATURE_FSGSBASE ( 9*32+ 0) /* RDFSBASE, WRFSBASE, RDGSBASE, WRGSBASE instructions*/ diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 1e45b46fae84..8c354099d9c3 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -47,6 +47,10 @@ static inline u64 paravirt_steal_clock(int cpu) return static_call(pv_steal_clock)(cpu); } +#ifdef CONFIG_PARAVIRT_SPINLOCKS +void __init paravirt_set_cap(void); +#endif + /* The paravirtualized I/O functions */ static inline void slow_down_io(void) { @@ -811,5 +815,11 @@ static inline void paravirt_arch_exit_mmap(struct mm_struct *mm) { } #endif + +#ifndef CONFIG_PARAVIRT_SPINLOCKS +static inline void paravirt_set_cap(void) +{ +} +#endif #endif /* __ASSEMBLY__ */ #endif /* _ASM_X86_PARAVIRT_H */ diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index 1296a90aa5b8..ab9ad729fc5a 100644 --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -28,6 +28,7 @@ #include #include #include +#include int __read_mostly alternatives_patched; @@ -724,6 +725,33 @@ void __init alternative_instructions(void) * patching. */ + /* + * Paravirt patching and alternative patching can be combined to + * replace a function call with a short direct code sequence (e.g. + * by setting a constant return value instead of doing that in an + * external function). + * In order to make this work the following sequence is required: + * 1. set (artificial) features depending on used paravirt + * functions which can later influence alternative patching + * 2. apply paravirt patching (generally replacing an indirect + * function call with a direct one) + * 3. apply alternative patching (e.g. replacing a direct function + * call with a custom code sequence) + * Doing paravirt patching after alternative patching would clobber + * the optimization of the custom code with a function call again. + */ + paravirt_set_cap(); + + /* + * First patch paravirt functions, such that we overwrite the indirect + * call with the direct call. + */ + apply_paravirt(__parainstructions, __parainstructions_end); + + /* + * Then patch alternatives, such that those paravirt calls that are in + * alternatives can be overwritten by their immediate fragments. + */ apply_alternatives(__alt_instructions, __alt_instructions_end); #ifdef CONFIG_SMP @@ -742,8 +770,6 @@ void __init alternative_instructions(void) } #endif - apply_paravirt(__parainstructions, __parainstructions_end); - restart_nmi(); alternatives_patched = 1; } diff --git a/arch/x86/kernel/paravirt-spinlocks.c b/arch/x86/kernel/paravirt-spinlocks.c index 4f75d0cf6305..9e1ea99ad9df 100644 --- a/arch/x86/kernel/paravirt-spinlocks.c +++ b/arch/x86/kernel/paravirt-spinlocks.c @@ -32,3 +32,12 @@ bool pv_is_native_vcpu_is_preempted(void) return pv_ops.lock.vcpu_is_preempted.func == __raw_callee_save___native_vcpu_is_preempted; } + +void __init paravirt_set_cap(void) +{ + if (!pv_is_native_spin_unlock()) + setup_force_cpu_cap(X86_FEATURE_PVUNLOCK); + + if (!pv_is_native_vcpu_is_preempted()) + setup_force_cpu_cap(X86_FEATURE_VCPUPREEMPT); +} -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:29:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:29:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94856.178752 (Exim 4.92) (envelope-from ) id 1lJF0V-00056P-Nc; Mon, 08 Mar 2021 12:29:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94856.178752; Mon, 08 Mar 2021 12:29:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0V-00056A-JF; Mon, 08 Mar 2021 12:29:07 +0000 Received: by outflank-mailman (input) for mailman id 94856; Mon, 08 Mar 2021 12:29:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0U-0004nW-AG for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:29:06 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 26545cf8-4a4f-41b9-bb9f-1b7c120a9b36; Mon, 08 Mar 2021 12:28:52 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EE520ADCD; Mon, 8 Mar 2021 12:28:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26545cf8-4a4f-41b9-bb9f-1b7c120a9b36 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615206531; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Pj0+lsoXMYSDviFMNu3CfGDulAqhBZd0duxurV0jt/k=; b=ullbjypHk4a2OSdXRZBXV7LzXx1wRPq0P3DUkuf3g00TxnX2Kvmikn2mvZgT5yu1bK+GT9 Pb18L02feaPu+UmwjPoQNvBkbpJDORl8H6ArZ/XWAobYvxZmsd1kHtOeWcA3mN+bVvHI/I evXt2ltyGZ054ZgETkOoGM4IjjxGEog= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, clang-built-linux@googlegroups.com Cc: Juergen Gross , Peter Zijlstra , Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel , Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini , Andy Lutomirski , Nathan Chancellor , Nick Desaulniers Subject: [PATCH v5 00/12] x86: major paravirt cleanup Date: Mon, 8 Mar 2021 13:28:32 +0100 Message-Id: <20210308122844.30488-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is a major cleanup of the paravirt infrastructure aiming at eliminating all custom code patching via paravirt patching. This is achieved by using ALTERNATIVE instead, leading to the ability to give objtool access to the patched in instructions. In order to remove most of the 32-bit special handling from pvops the time related operations are switched to use static_call() instead. At the end of this series all paravirt patching has to do is to replace indirect calls with direct ones. In a further step this could be switched to static_call(), too. Changes in V5: - patches 1-5 of V4 dropped, as already applied - new patches 1+3 - fixed patch 2 - split V4 patch 8 into patches 4+5 - use flag byte instead of negative feature bit for "not feature" Changes in V4: - fixed several build failures - removed objtool patch, as objtool patches are in tip now - added patch 1 for making usage of static_call easier - even more cleanup Changes in V3: - added patches 7 and 12 - addressed all comments Changes in V2: - added patches 5-12 Juergen Gross (12): staticcall: move struct static_call_key definition to static_call_types.h x86/paravirt: switch time pvops functions to use static_call() x86/alternative: drop feature parameter from ALTINSTR_REPLACEMENT() x86/alternative: support not-feature x86/alternative: support ALTERNATIVE_TERNARY x86: add new features for paravirt patching x86/paravirt: remove no longer needed 32-bit pvops cruft x86/paravirt: simplify paravirt macros x86/paravirt: switch iret pvops to ALTERNATIVE x86/paravirt: add new macros PVOP_ALT* supporting pvops in ALTERNATIVEs x86/paravirt: switch functions with custom code to ALTERNATIVE x86/paravirt: have only one paravirt patch function arch/arm/include/asm/paravirt.h | 14 +- arch/arm/kernel/paravirt.c | 9 +- arch/arm64/include/asm/paravirt.h | 14 +- arch/arm64/kernel/paravirt.c | 13 +- arch/x86/Kconfig | 1 + arch/x86/entry/entry_32.S | 4 +- arch/x86/entry/entry_64.S | 2 +- arch/x86/include/asm/alternative-asm.h | 10 + arch/x86/include/asm/alternative.h | 28 ++- arch/x86/include/asm/cpufeature.h | 2 + arch/x86/include/asm/cpufeatures.h | 2 + arch/x86/include/asm/irqflags.h | 7 +- arch/x86/include/asm/mshyperv.h | 2 +- arch/x86/include/asm/paravirt.h | 167 +++++++------- arch/x86/include/asm/paravirt_types.h | 210 +++++++----------- arch/x86/kernel/Makefile | 3 +- arch/x86/kernel/alternative.c | 37 ++- arch/x86/kernel/asm-offsets.c | 7 - arch/x86/kernel/cpu/vmware.c | 5 +- arch/x86/kernel/kvm.c | 2 +- arch/x86/kernel/kvmclock.c | 2 +- arch/x86/kernel/paravirt-spinlocks.c | 9 + arch/x86/kernel/paravirt.c | 78 ++----- arch/x86/kernel/paravirt_patch.c | 99 --------- arch/x86/kernel/tsc.c | 2 +- arch/x86/xen/enlighten_pv.c | 4 +- arch/x86/xen/time.c | 11 +- drivers/xen/time.c | 3 +- include/linux/static_call.h | 18 -- include/linux/static_call_types.h | 18 ++ tools/include/linux/static_call_types.h | 18 ++ tools/objtool/arch/x86/include/arch/special.h | 6 +- 32 files changed, 339 insertions(+), 468 deletions(-) delete mode 100644 arch/x86/kernel/paravirt_patch.c -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:29:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:29:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94857.178764 (Exim 4.92) (envelope-from ) id 1lJF0Y-0005BA-55; Mon, 08 Mar 2021 12:29:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94857.178764; Mon, 08 Mar 2021 12:29:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0Y-0005Ay-0F; Mon, 08 Mar 2021 12:29:10 +0000 Received: by outflank-mailman (input) for mailman id 94857; Mon, 08 Mar 2021 12:29:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0W-0004oO-2a for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:29:08 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 121c0b45-ffb4-48f8-abdc-32a137b0aa7f; Mon, 08 Mar 2021 12:28:52 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C3CDDADE3; Mon, 8 Mar 2021 12:28:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 121c0b45-ffb4-48f8-abdc-32a137b0aa7f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615206531; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u3YnMSkFlUp/21QNZ1kMggcxHe1yXHAkDy5ICMJL1QU=; b=YNXv3uCm5+P4OF8r75Pj3qvw5a/bZfGdICaugMYT2001NNP0vgy+3Yvt/g6oITt+sQcCfJ bRWOBUQq9sw0blJ3Qd7GZKfWo8CXn9ZBVyCjfOf1W58pXx3+q/llcvf1E3Q81iLbwVmnW4 5yJkt0s0avbsqJu9zRlFR0ThlVQ9xoo= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Nathan Chancellor , Nick Desaulniers Subject: [PATCH v5 08/12] x86/paravirt: simplify paravirt macros Date: Mon, 8 Mar 2021 13:28:40 +0100 Message-Id: <20210308122844.30488-9-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210308122844.30488-1-jgross@suse.com> References: <20210308122844.30488-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The central pvops call macros ____PVOP_CALL() and ____PVOP_VCALL() are looking very similar now. The main differences are using PVOP_VCALL_ARGS or PVOP_CALL_ARGS, which are identical, and the return value handling. So drop PVOP_VCALL_ARGS and instead of ____PVOP_VCALL() just use (void)____PVOP_CALL(long, ...). Note that it isn't easily possible to just redefine ____PVOP_VCALL() to use ____PVOP_CALL() instead, as this would require further hiding of commas in macro parameters. Signed-off-by: Juergen Gross --- V3: - new patch V4: - fix build warnings with clang (kernel test robot) --- arch/x86/include/asm/paravirt_types.h | 41 ++++++++------------------- 1 file changed, 12 insertions(+), 29 deletions(-) diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 42f9eef84131..45bd21647dd8 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -408,11 +408,9 @@ int paravirt_disable_iospace(void); * makes sure the incoming and outgoing types are always correct. */ #ifdef CONFIG_X86_32 -#define PVOP_VCALL_ARGS \ +#define PVOP_CALL_ARGS \ unsigned long __eax = __eax, __edx = __edx, __ecx = __ecx; -#define PVOP_CALL_ARGS PVOP_VCALL_ARGS - #define PVOP_CALL_ARG1(x) "a" ((unsigned long)(x)) #define PVOP_CALL_ARG2(x) "d" ((unsigned long)(x)) #define PVOP_CALL_ARG3(x) "c" ((unsigned long)(x)) @@ -428,12 +426,10 @@ int paravirt_disable_iospace(void); #define VEXTRA_CLOBBERS #else /* CONFIG_X86_64 */ /* [re]ax isn't an arg, but the return val */ -#define PVOP_VCALL_ARGS \ +#define PVOP_CALL_ARGS \ unsigned long __edi = __edi, __esi = __esi, \ __edx = __edx, __ecx = __ecx, __eax = __eax; -#define PVOP_CALL_ARGS PVOP_VCALL_ARGS - #define PVOP_CALL_ARG1(x) "D" ((unsigned long)(x)) #define PVOP_CALL_ARG2(x) "S" ((unsigned long)(x)) #define PVOP_CALL_ARG3(x) "d" ((unsigned long)(x)) @@ -458,59 +454,46 @@ int paravirt_disable_iospace(void); #define PVOP_TEST_NULL(op) ((void)pv_ops.op) #endif -#define PVOP_RETMASK(rettype) \ +#define PVOP_RETVAL(rettype) \ ({ unsigned long __mask = ~0UL; \ + BUILD_BUG_ON(sizeof(rettype) > sizeof(unsigned long)); \ switch (sizeof(rettype)) { \ case 1: __mask = 0xffUL; break; \ case 2: __mask = 0xffffUL; break; \ case 4: __mask = 0xffffffffUL; break; \ default: break; \ } \ - __mask; \ + __mask & __eax; \ }) -#define ____PVOP_CALL(rettype, op, clbr, call_clbr, extra_clbr, ...) \ +#define ____PVOP_CALL(ret, op, clbr, call_clbr, extra_clbr, ...) \ ({ \ PVOP_CALL_ARGS; \ PVOP_TEST_NULL(op); \ - BUILD_BUG_ON(sizeof(rettype) > sizeof(unsigned long)); \ asm volatile(paravirt_alt(PARAVIRT_CALL) \ : call_clbr, ASM_CALL_CONSTRAINT \ : paravirt_type(op), \ paravirt_clobber(clbr), \ ##__VA_ARGS__ \ : "memory", "cc" extra_clbr); \ - (rettype)(__eax & PVOP_RETMASK(rettype)); \ + ret; \ }) #define __PVOP_CALL(rettype, op, ...) \ - ____PVOP_CALL(rettype, op, CLBR_ANY, PVOP_CALL_CLOBBERS, \ - EXTRA_CLOBBERS, ##__VA_ARGS__) + ____PVOP_CALL(PVOP_RETVAL(rettype), op, CLBR_ANY, \ + PVOP_CALL_CLOBBERS, EXTRA_CLOBBERS, ##__VA_ARGS__) #define __PVOP_CALLEESAVE(rettype, op, ...) \ - ____PVOP_CALL(rettype, op.func, CLBR_RET_REG, \ + ____PVOP_CALL(PVOP_RETVAL(rettype), op.func, CLBR_RET_REG, \ PVOP_CALLEE_CLOBBERS, , ##__VA_ARGS__) - -#define ____PVOP_VCALL(op, clbr, call_clbr, extra_clbr, ...) \ - ({ \ - PVOP_VCALL_ARGS; \ - PVOP_TEST_NULL(op); \ - asm volatile(paravirt_alt(PARAVIRT_CALL) \ - : call_clbr, ASM_CALL_CONSTRAINT \ - : paravirt_type(op), \ - paravirt_clobber(clbr), \ - ##__VA_ARGS__ \ - : "memory", "cc" extra_clbr); \ - }) - #define __PVOP_VCALL(op, ...) \ - ____PVOP_VCALL(op, CLBR_ANY, PVOP_VCALL_CLOBBERS, \ + (void)____PVOP_CALL(, op, CLBR_ANY, PVOP_VCALL_CLOBBERS, \ VEXTRA_CLOBBERS, ##__VA_ARGS__) #define __PVOP_VCALLEESAVE(op, ...) \ - ____PVOP_VCALL(op.func, CLBR_RET_REG, \ + (void)____PVOP_CALL(, op.func, CLBR_RET_REG, \ PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:29:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:29:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94858.178776 (Exim 4.92) (envelope-from ) id 1lJF0a-0005GI-Ky; Mon, 08 Mar 2021 12:29:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94858.178776; Mon, 08 Mar 2021 12:29:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0a-0005G1-FL; Mon, 08 Mar 2021 12:29:12 +0000 Received: by outflank-mailman (input) for mailman id 94858; Mon, 08 Mar 2021 12:29:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0Z-0004nW-AX for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:29:11 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b66ff6c6-292f-4029-98d1-509a663850fa; Mon, 08 Mar 2021 12:28:52 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6C44DADDC; Mon, 8 Mar 2021 12:28:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b66ff6c6-292f-4029-98d1-509a663850fa X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615206531; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ktl3ztu2thxHAuF/klqwDB7xLTh9wUBHXllg+XfrPc4=; b=cO3amrKU/glVXRL6XZoGl0pisq7oknKSG5sTLLgBsv3iOpltUcGNS605X8KXvnFqbpVizw 89mrrhw0SBYTUi1eplUr+D/7TmezRi1NV5B/365IO6hRmCHlMflcAM9vVaVfzKiUZpWEF2 HiORH/a5LHrFZ9QtN543On4xHFzavHc= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Juergen Gross , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Deep Shah , "VMware, Inc." Subject: [PATCH v5 07/12] x86/paravirt: remove no longer needed 32-bit pvops cruft Date: Mon, 8 Mar 2021 13:28:39 +0100 Message-Id: <20210308122844.30488-8-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210308122844.30488-1-jgross@suse.com> References: <20210308122844.30488-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PVOP_VCALL4() is only used for Xen PV, while PVOP_CALL4() isn't used at all. Keep PVOP_CALL4() for 64 bits due to symmetry reasons. This allows to remove the 32-bit definitions of those macros leading to a substantial simplification of the paravirt macros, as those were the only ones needing non-empty "pre" and "post" parameters. PVOP_CALLEE2() and PVOP_VCALLEE2() are used nowhere, so remove them. Another no longer needed case is special handling of return types larger than unsigned long. Replace that with a BUILD_BUG_ON(). DISABLE_INTERRUPTS() is used in 32-bit code only, so it can just be replaced by cli. INTERRUPT_RETURN in 32-bit code can be replaced by iret. ENABLE_INTERRUPTS is used nowhere, so it can be removed. Signed-off-by: Juergen Gross --- arch/x86/entry/entry_32.S | 4 +- arch/x86/include/asm/irqflags.h | 5 -- arch/x86/include/asm/paravirt.h | 35 +------- arch/x86/include/asm/paravirt_types.h | 112 ++++++++------------------ arch/x86/kernel/asm-offsets.c | 2 - 5 files changed, 35 insertions(+), 123 deletions(-) diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S index df8c017e6161..765487e57d6e 100644 --- a/arch/x86/entry/entry_32.S +++ b/arch/x86/entry/entry_32.S @@ -430,7 +430,7 @@ * will soon execute iret and the tracer was already set to * the irqstate after the IRET: */ - DISABLE_INTERRUPTS(CLBR_ANY) + cli lss (%esp), %esp /* switch to espfix segment */ .Lend_\@: #endif /* CONFIG_X86_ESPFIX32 */ @@ -1077,7 +1077,7 @@ restore_all_switch_stack: * when returning from IPI handler and when returning from * scheduler to user-space. */ - INTERRUPT_RETURN + iret .section .fixup, "ax" SYM_CODE_START(asm_iret_error) diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h index 144d70ea4393..a0efbcd24b86 100644 --- a/arch/x86/include/asm/irqflags.h +++ b/arch/x86/include/asm/irqflags.h @@ -109,9 +109,6 @@ static __always_inline unsigned long arch_local_irq_save(void) } #else -#define ENABLE_INTERRUPTS(x) sti -#define DISABLE_INTERRUPTS(x) cli - #ifdef CONFIG_X86_64 #ifdef CONFIG_DEBUG_ENTRY #define SAVE_FLAGS(x) pushfq; popq %rax @@ -119,8 +116,6 @@ static __always_inline unsigned long arch_local_irq_save(void) #define INTERRUPT_RETURN jmp native_iret -#else -#define INTERRUPT_RETURN iret #endif #endif /* __ASSEMBLY__ */ diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 8c354099d9c3..c6496a82fad1 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -721,6 +721,7 @@ extern void default_banner(void); .if ((~(set)) & mask); pop %reg; .endif #ifdef CONFIG_X86_64 +#ifdef CONFIG_PARAVIRT_XXL #define PV_SAVE_REGS(set) \ COND_PUSH(set, CLBR_RAX, rax); \ @@ -746,46 +747,12 @@ extern void default_banner(void); #define PARA_PATCH(off) ((off) / 8) #define PARA_SITE(ptype, ops) _PVSITE(ptype, ops, .quad, 8) #define PARA_INDIRECT(addr) *addr(%rip) -#else -#define PV_SAVE_REGS(set) \ - COND_PUSH(set, CLBR_EAX, eax); \ - COND_PUSH(set, CLBR_EDI, edi); \ - COND_PUSH(set, CLBR_ECX, ecx); \ - COND_PUSH(set, CLBR_EDX, edx) -#define PV_RESTORE_REGS(set) \ - COND_POP(set, CLBR_EDX, edx); \ - COND_POP(set, CLBR_ECX, ecx); \ - COND_POP(set, CLBR_EDI, edi); \ - COND_POP(set, CLBR_EAX, eax) - -#define PARA_PATCH(off) ((off) / 4) -#define PARA_SITE(ptype, ops) _PVSITE(ptype, ops, .long, 4) -#define PARA_INDIRECT(addr) *%cs:addr -#endif -#ifdef CONFIG_PARAVIRT_XXL #define INTERRUPT_RETURN \ PARA_SITE(PARA_PATCH(PV_CPU_iret), \ ANNOTATE_RETPOLINE_SAFE; \ jmp PARA_INDIRECT(pv_ops+PV_CPU_iret);) -#define DISABLE_INTERRUPTS(clobbers) \ - PARA_SITE(PARA_PATCH(PV_IRQ_irq_disable), \ - PV_SAVE_REGS(clobbers | CLBR_CALLEE_SAVE); \ - ANNOTATE_RETPOLINE_SAFE; \ - call PARA_INDIRECT(pv_ops+PV_IRQ_irq_disable); \ - PV_RESTORE_REGS(clobbers | CLBR_CALLEE_SAVE);) - -#define ENABLE_INTERRUPTS(clobbers) \ - PARA_SITE(PARA_PATCH(PV_IRQ_irq_enable), \ - PV_SAVE_REGS(clobbers | CLBR_CALLEE_SAVE); \ - ANNOTATE_RETPOLINE_SAFE; \ - call PARA_INDIRECT(pv_ops+PV_IRQ_irq_enable); \ - PV_RESTORE_REGS(clobbers | CLBR_CALLEE_SAVE);) -#endif - -#ifdef CONFIG_X86_64 -#ifdef CONFIG_PARAVIRT_XXL #ifdef CONFIG_DEBUG_ENTRY #define SAVE_FLAGS(clobbers) \ PARA_SITE(PARA_PATCH(PV_IRQ_save_fl), \ diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 1fff349e4792..42f9eef84131 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -470,55 +470,34 @@ int paravirt_disable_iospace(void); }) -#define ____PVOP_CALL(rettype, op, clbr, call_clbr, extra_clbr, \ - pre, post, ...) \ +#define ____PVOP_CALL(rettype, op, clbr, call_clbr, extra_clbr, ...) \ ({ \ - rettype __ret; \ PVOP_CALL_ARGS; \ PVOP_TEST_NULL(op); \ - /* This is 32-bit specific, but is okay in 64-bit */ \ - /* since this condition will never hold */ \ - if (sizeof(rettype) > sizeof(unsigned long)) { \ - asm volatile(pre \ - paravirt_alt(PARAVIRT_CALL) \ - post \ - : call_clbr, ASM_CALL_CONSTRAINT \ - : paravirt_type(op), \ - paravirt_clobber(clbr), \ - ##__VA_ARGS__ \ - : "memory", "cc" extra_clbr); \ - __ret = (rettype)((((u64)__edx) << 32) | __eax); \ - } else { \ - asm volatile(pre \ - paravirt_alt(PARAVIRT_CALL) \ - post \ - : call_clbr, ASM_CALL_CONSTRAINT \ - : paravirt_type(op), \ - paravirt_clobber(clbr), \ - ##__VA_ARGS__ \ - : "memory", "cc" extra_clbr); \ - __ret = (rettype)(__eax & PVOP_RETMASK(rettype)); \ - } \ - __ret; \ + BUILD_BUG_ON(sizeof(rettype) > sizeof(unsigned long)); \ + asm volatile(paravirt_alt(PARAVIRT_CALL) \ + : call_clbr, ASM_CALL_CONSTRAINT \ + : paravirt_type(op), \ + paravirt_clobber(clbr), \ + ##__VA_ARGS__ \ + : "memory", "cc" extra_clbr); \ + (rettype)(__eax & PVOP_RETMASK(rettype)); \ }) -#define __PVOP_CALL(rettype, op, pre, post, ...) \ +#define __PVOP_CALL(rettype, op, ...) \ ____PVOP_CALL(rettype, op, CLBR_ANY, PVOP_CALL_CLOBBERS, \ - EXTRA_CLOBBERS, pre, post, ##__VA_ARGS__) + EXTRA_CLOBBERS, ##__VA_ARGS__) -#define __PVOP_CALLEESAVE(rettype, op, pre, post, ...) \ +#define __PVOP_CALLEESAVE(rettype, op, ...) \ ____PVOP_CALL(rettype, op.func, CLBR_RET_REG, \ - PVOP_CALLEE_CLOBBERS, , \ - pre, post, ##__VA_ARGS__) + PVOP_CALLEE_CLOBBERS, , ##__VA_ARGS__) -#define ____PVOP_VCALL(op, clbr, call_clbr, extra_clbr, pre, post, ...) \ +#define ____PVOP_VCALL(op, clbr, call_clbr, extra_clbr, ...) \ ({ \ PVOP_VCALL_ARGS; \ PVOP_TEST_NULL(op); \ - asm volatile(pre \ - paravirt_alt(PARAVIRT_CALL) \ - post \ + asm volatile(paravirt_alt(PARAVIRT_CALL) \ : call_clbr, ASM_CALL_CONSTRAINT \ : paravirt_type(op), \ paravirt_clobber(clbr), \ @@ -526,84 +505,57 @@ int paravirt_disable_iospace(void); : "memory", "cc" extra_clbr); \ }) -#define __PVOP_VCALL(op, pre, post, ...) \ +#define __PVOP_VCALL(op, ...) \ ____PVOP_VCALL(op, CLBR_ANY, PVOP_VCALL_CLOBBERS, \ - VEXTRA_CLOBBERS, \ - pre, post, ##__VA_ARGS__) + VEXTRA_CLOBBERS, ##__VA_ARGS__) -#define __PVOP_VCALLEESAVE(op, pre, post, ...) \ +#define __PVOP_VCALLEESAVE(op, ...) \ ____PVOP_VCALL(op.func, CLBR_RET_REG, \ - PVOP_VCALLEE_CLOBBERS, , \ - pre, post, ##__VA_ARGS__) + PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) #define PVOP_CALL0(rettype, op) \ - __PVOP_CALL(rettype, op, "", "") + __PVOP_CALL(rettype, op) #define PVOP_VCALL0(op) \ - __PVOP_VCALL(op, "", "") + __PVOP_VCALL(op) #define PVOP_CALLEE0(rettype, op) \ - __PVOP_CALLEESAVE(rettype, op, "", "") + __PVOP_CALLEESAVE(rettype, op) #define PVOP_VCALLEE0(op) \ - __PVOP_VCALLEESAVE(op, "", "") + __PVOP_VCALLEESAVE(op) #define PVOP_CALL1(rettype, op, arg1) \ - __PVOP_CALL(rettype, op, "", "", PVOP_CALL_ARG1(arg1)) + __PVOP_CALL(rettype, op, PVOP_CALL_ARG1(arg1)) #define PVOP_VCALL1(op, arg1) \ - __PVOP_VCALL(op, "", "", PVOP_CALL_ARG1(arg1)) + __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1)) #define PVOP_CALLEE1(rettype, op, arg1) \ - __PVOP_CALLEESAVE(rettype, op, "", "", PVOP_CALL_ARG1(arg1)) + __PVOP_CALLEESAVE(rettype, op, PVOP_CALL_ARG1(arg1)) #define PVOP_VCALLEE1(op, arg1) \ - __PVOP_VCALLEESAVE(op, "", "", PVOP_CALL_ARG1(arg1)) + __PVOP_VCALLEESAVE(op, PVOP_CALL_ARG1(arg1)) #define PVOP_CALL2(rettype, op, arg1, arg2) \ - __PVOP_CALL(rettype, op, "", "", PVOP_CALL_ARG1(arg1), \ - PVOP_CALL_ARG2(arg2)) + __PVOP_CALL(rettype, op, PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2)) #define PVOP_VCALL2(op, arg1, arg2) \ - __PVOP_VCALL(op, "", "", PVOP_CALL_ARG1(arg1), \ - PVOP_CALL_ARG2(arg2)) - -#define PVOP_CALLEE2(rettype, op, arg1, arg2) \ - __PVOP_CALLEESAVE(rettype, op, "", "", PVOP_CALL_ARG1(arg1), \ - PVOP_CALL_ARG2(arg2)) -#define PVOP_VCALLEE2(op, arg1, arg2) \ - __PVOP_VCALLEESAVE(op, "", "", PVOP_CALL_ARG1(arg1), \ - PVOP_CALL_ARG2(arg2)) - + __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2)) #define PVOP_CALL3(rettype, op, arg1, arg2, arg3) \ - __PVOP_CALL(rettype, op, "", "", PVOP_CALL_ARG1(arg1), \ + __PVOP_CALL(rettype, op, PVOP_CALL_ARG1(arg1), \ PVOP_CALL_ARG2(arg2), PVOP_CALL_ARG3(arg3)) #define PVOP_VCALL3(op, arg1, arg2, arg3) \ - __PVOP_VCALL(op, "", "", PVOP_CALL_ARG1(arg1), \ + __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1), \ PVOP_CALL_ARG2(arg2), PVOP_CALL_ARG3(arg3)) -/* This is the only difference in x86_64. We can make it much simpler */ -#ifdef CONFIG_X86_32 #define PVOP_CALL4(rettype, op, arg1, arg2, arg3, arg4) \ __PVOP_CALL(rettype, op, \ - "push %[_arg4];", "lea 4(%%esp),%%esp;", \ - PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2), \ - PVOP_CALL_ARG3(arg3), [_arg4] "mr" ((u32)(arg4))) -#define PVOP_VCALL4(op, arg1, arg2, arg3, arg4) \ - __PVOP_VCALL(op, \ - "push %[_arg4];", "lea 4(%%esp),%%esp;", \ - "0" ((u32)(arg1)), "1" ((u32)(arg2)), \ - "2" ((u32)(arg3)), [_arg4] "mr" ((u32)(arg4))) -#else -#define PVOP_CALL4(rettype, op, arg1, arg2, arg3, arg4) \ - __PVOP_CALL(rettype, op, "", "", \ PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2), \ PVOP_CALL_ARG3(arg3), PVOP_CALL_ARG4(arg4)) #define PVOP_VCALL4(op, arg1, arg2, arg3, arg4) \ - __PVOP_VCALL(op, "", "", \ - PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2), \ + __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2), \ PVOP_CALL_ARG3(arg3), PVOP_CALL_ARG4(arg4)) -#endif /* Lazy mode for batching updates / context switch */ enum paravirt_lazy_mode { diff --git a/arch/x86/kernel/asm-offsets.c b/arch/x86/kernel/asm-offsets.c index 60b9f42ce3c1..736508004b30 100644 --- a/arch/x86/kernel/asm-offsets.c +++ b/arch/x86/kernel/asm-offsets.c @@ -63,8 +63,6 @@ static void __used common(void) #ifdef CONFIG_PARAVIRT_XXL BLANK(); - OFFSET(PV_IRQ_irq_disable, paravirt_patch_template, irq.irq_disable); - OFFSET(PV_IRQ_irq_enable, paravirt_patch_template, irq.irq_enable); OFFSET(PV_CPU_iret, paravirt_patch_template, cpu.iret); #endif -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:29:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:29:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94859.178788 (Exim 4.92) (envelope-from ) id 1lJF0d-0005Lw-73; Mon, 08 Mar 2021 12:29:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94859.178788; Mon, 08 Mar 2021 12:29:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0d-0005Lh-1t; Mon, 08 Mar 2021 12:29:15 +0000 Received: by outflank-mailman (input) for mailman id 94859; Mon, 08 Mar 2021 12:29:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0b-0004oO-2j for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:29:13 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4eef2ae1-e9f7-4fb4-bdc7-7e8fe52f6720; Mon, 08 Mar 2021 12:28:53 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 64ED5AE05; Mon, 8 Mar 2021 12:28:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4eef2ae1-e9f7-4fb4-bdc7-7e8fe52f6720 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615206532; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rhjW9OQAos6g6yY96+Pq7xS90d5LZCpWCahF7JpKjGY=; b=BC+Dp++K0MR2LZHsFV2XEZVu2+fvWSz4dff/Jp0UFlIHP2JfaJEuJkByKIhMaG4slvVCON f7AlpVvuq5i4J7Zr9354F5ixzJwPZDMZO9Hvm83g9LgbuG2+9m3AvXqd91EVysKyBVC73Y bR5p0ujMSNfODh/QIJx6J4kV8h1/DS0= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: [PATCH v5 10/12] x86/paravirt: add new macros PVOP_ALT* supporting pvops in ALTERNATIVEs Date: Mon, 8 Mar 2021 13:28:42 +0100 Message-Id: <20210308122844.30488-11-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210308122844.30488-1-jgross@suse.com> References: <20210308122844.30488-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using paravirt patching for custom code sequences add support for using ALTERNATIVE handling combined with paravirt call patching. Signed-off-by: Juergen Gross --- V3: - drop ____PVOP_ALT_VCALL() macro --- arch/x86/include/asm/paravirt_types.h | 49 ++++++++++++++++++++++++++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 0afdac83f926..0ed976286d49 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -477,44 +477,91 @@ int paravirt_disable_iospace(void); ret; \ }) +#define ____PVOP_ALT_CALL(ret, op, alt, cond, clbr, call_clbr, \ + extra_clbr, ...) \ + ({ \ + PVOP_CALL_ARGS; \ + PVOP_TEST_NULL(op); \ + asm volatile(ALTERNATIVE(paravirt_alt(PARAVIRT_CALL), \ + alt, cond) \ + : call_clbr, ASM_CALL_CONSTRAINT \ + : paravirt_type(op), \ + paravirt_clobber(clbr), \ + ##__VA_ARGS__ \ + : "memory", "cc" extra_clbr); \ + ret; \ + }) + #define __PVOP_CALL(rettype, op, ...) \ ____PVOP_CALL(PVOP_RETVAL(rettype), op, CLBR_ANY, \ PVOP_CALL_CLOBBERS, EXTRA_CLOBBERS, ##__VA_ARGS__) +#define __PVOP_ALT_CALL(rettype, op, alt, cond, ...) \ + ____PVOP_ALT_CALL(PVOP_RETVAL(rettype), op, alt, cond, CLBR_ANY,\ + PVOP_CALL_CLOBBERS, EXTRA_CLOBBERS, \ + ##__VA_ARGS__) + #define __PVOP_CALLEESAVE(rettype, op, ...) \ ____PVOP_CALL(PVOP_RETVAL(rettype), op.func, CLBR_RET_REG, \ PVOP_CALLEE_CLOBBERS, , ##__VA_ARGS__) +#define __PVOP_ALT_CALLEESAVE(rettype, op, alt, cond, ...) \ + ____PVOP_ALT_CALL(PVOP_RETVAL(rettype), op.func, alt, cond, \ + CLBR_RET_REG, PVOP_CALLEE_CLOBBERS, , ##__VA_ARGS__) + + #define __PVOP_VCALL(op, ...) \ (void)____PVOP_CALL(, op, CLBR_ANY, PVOP_VCALL_CLOBBERS, \ VEXTRA_CLOBBERS, ##__VA_ARGS__) +#define __PVOP_ALT_VCALL(op, alt, cond, ...) \ + (void)____PVOP_ALT_CALL(, op, alt, cond, CLBR_ANY, \ + PVOP_VCALL_CLOBBERS, VEXTRA_CLOBBERS, \ + ##__VA_ARGS__) + #define __PVOP_VCALLEESAVE(op, ...) \ (void)____PVOP_CALL(, op.func, CLBR_RET_REG, \ - PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) + PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) +#define __PVOP_ALT_VCALLEESAVE(op, alt, cond, ...) \ + (void)____PVOP_ALT_CALL(, op.func, alt, cond, CLBR_RET_REG, \ + PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) #define PVOP_CALL0(rettype, op) \ __PVOP_CALL(rettype, op) #define PVOP_VCALL0(op) \ __PVOP_VCALL(op) +#define PVOP_ALT_CALL0(rettype, op, alt, cond) \ + __PVOP_ALT_CALL(rettype, op, alt, cond) +#define PVOP_ALT_VCALL0(op, alt, cond) \ + __PVOP_ALT_VCALL(op, alt, cond) #define PVOP_CALLEE0(rettype, op) \ __PVOP_CALLEESAVE(rettype, op) #define PVOP_VCALLEE0(op) \ __PVOP_VCALLEESAVE(op) +#define PVOP_ALT_CALLEE0(rettype, op, alt, cond) \ + __PVOP_ALT_CALLEESAVE(rettype, op, alt, cond) +#define PVOP_ALT_VCALLEE0(op, alt, cond) \ + __PVOP_ALT_VCALLEESAVE(op, alt, cond) #define PVOP_CALL1(rettype, op, arg1) \ __PVOP_CALL(rettype, op, PVOP_CALL_ARG1(arg1)) #define PVOP_VCALL1(op, arg1) \ __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1)) +#define PVOP_ALT_VCALL1(op, arg1, alt, cond) \ + __PVOP_ALT_VCALL(op, alt, cond, PVOP_CALL_ARG1(arg1)) #define PVOP_CALLEE1(rettype, op, arg1) \ __PVOP_CALLEESAVE(rettype, op, PVOP_CALL_ARG1(arg1)) #define PVOP_VCALLEE1(op, arg1) \ __PVOP_VCALLEESAVE(op, PVOP_CALL_ARG1(arg1)) +#define PVOP_ALT_CALLEE1(rettype, op, arg1, alt, cond) \ + __PVOP_ALT_CALLEESAVE(rettype, op, alt, cond, PVOP_CALL_ARG1(arg1)) +#define PVOP_ALT_VCALLEE1(op, arg1, alt, cond) \ + __PVOP_ALT_VCALLEESAVE(op, alt, cond, PVOP_CALL_ARG1(arg1)) #define PVOP_CALL2(rettype, op, arg1, arg2) \ -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:29:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:29:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94860.178800 (Exim 4.92) (envelope-from ) id 1lJF0f-0005Qm-OY; Mon, 08 Mar 2021 12:29:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94860.178800; Mon, 08 Mar 2021 12:29:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0f-0005Qd-JB; Mon, 08 Mar 2021 12:29:17 +0000 Received: by outflank-mailman (input) for mailman id 94860; Mon, 08 Mar 2021 12:29:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0e-0004nW-Ai for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:29:16 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5c25e52e-338b-417a-b3ea-d018c07cadb6; Mon, 08 Mar 2021 12:28:53 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 204E3AE14; Mon, 8 Mar 2021 12:28:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c25e52e-338b-417a-b3ea-d018c07cadb6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615206532; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uXXZ1ufUdHsiCaRhqGkXYxwcASdPvSuoy69T9MBtYmw=; b=kRKxv1RsAGDcADbrHWu73FD9kTW+jCAcP05Sf8PVHWCkbW+gVkwK1TMNhrEvZMiX/CMoHp swJdh1rWHYlKq/mJOqfJGVsUOzOT8Cnfi2CpWzWKac4cIAw/yFaBbjYntnw5ObNUSVvj3Y Lvgm+VsNKi8ZC0hIa2JSBRNA+uizGp0= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Boris Ostrovsky , Stefano Stabellini Subject: [PATCH v5 09/12] x86/paravirt: switch iret pvops to ALTERNATIVE Date: Mon, 8 Mar 2021 13:28:41 +0100 Message-Id: <20210308122844.30488-10-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210308122844.30488-1-jgross@suse.com> References: <20210308122844.30488-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The iret paravirt op is rather special as it is using a jmp instead of a call instruction. Switch it to ALTERNATIVE. Signed-off-by: Juergen Gross --- V3: - use ALTERNATIVE_TERNARY --- arch/x86/include/asm/paravirt.h | 6 +++--- arch/x86/include/asm/paravirt_types.h | 5 +---- arch/x86/kernel/asm-offsets.c | 5 ----- arch/x86/kernel/paravirt.c | 26 ++------------------------ arch/x86/xen/enlighten_pv.c | 3 +-- 5 files changed, 7 insertions(+), 38 deletions(-) diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index c6496a82fad1..36cd71fa097f 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -749,9 +749,9 @@ extern void default_banner(void); #define PARA_INDIRECT(addr) *addr(%rip) #define INTERRUPT_RETURN \ - PARA_SITE(PARA_PATCH(PV_CPU_iret), \ - ANNOTATE_RETPOLINE_SAFE; \ - jmp PARA_INDIRECT(pv_ops+PV_CPU_iret);) + ANNOTATE_RETPOLINE_SAFE; \ + ALTERNATIVE_TERNARY("jmp *paravirt_iret(%rip);", \ + X86_FEATURE_XENPV, "jmp xen_iret;", "jmp native_iret;") #ifdef CONFIG_DEBUG_ENTRY #define SAVE_FLAGS(clobbers) \ diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 45bd21647dd8..0afdac83f926 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -151,10 +151,6 @@ struct pv_cpu_ops { u64 (*read_pmc)(int counter); - /* Normal iret. Jump to this with the standard iret stack - frame set up. */ - void (*iret)(void); - void (*start_context_switch)(struct task_struct *prev); void (*end_context_switch)(struct task_struct *next); #endif @@ -294,6 +290,7 @@ struct paravirt_patch_template { extern struct pv_info pv_info; extern struct paravirt_patch_template pv_ops; +extern void (*paravirt_iret)(void); #define PARAVIRT_PATCH(x) \ (offsetof(struct paravirt_patch_template, x) / sizeof(void *)) diff --git a/arch/x86/kernel/asm-offsets.c b/arch/x86/kernel/asm-offsets.c index 736508004b30..ecd3fd6993d1 100644 --- a/arch/x86/kernel/asm-offsets.c +++ b/arch/x86/kernel/asm-offsets.c @@ -61,11 +61,6 @@ static void __used common(void) OFFSET(IA32_RT_SIGFRAME_sigcontext, rt_sigframe_ia32, uc.uc_mcontext); #endif -#ifdef CONFIG_PARAVIRT_XXL - BLANK(); - OFFSET(PV_CPU_iret, paravirt_patch_template, cpu.iret); -#endif - #ifdef CONFIG_XEN BLANK(); OFFSET(XEN_vcpu_info_mask, vcpu_info, evtchn_upcall_mask); diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 44e5b0fe28cb..0553a339d850 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -86,25 +86,6 @@ u64 notrace _paravirt_ident_64(u64 x) { return x; } - -static unsigned paravirt_patch_jmp(void *insn_buff, const void *target, - unsigned long addr, unsigned len) -{ - struct branch *b = insn_buff; - unsigned long delta = (unsigned long)target - (addr+5); - - if (len < 5) { -#ifdef CONFIG_RETPOLINE - WARN_ONCE(1, "Failing to patch indirect JMP in %ps\n", (void *)addr); -#endif - return len; /* call too long for patch site */ - } - - b->opcode = 0xe9; /* jmp */ - b->delta = delta; - - return 5; -} #endif DEFINE_STATIC_KEY_TRUE(virt_spin_lock_key); @@ -136,9 +117,6 @@ unsigned paravirt_patch_default(u8 type, void *insn_buff, else if (opfunc == _paravirt_ident_64) ret = paravirt_patch_ident_64(insn_buff, len); - else if (type == PARAVIRT_PATCH(cpu.iret)) - /* If operation requires a jmp, then jmp */ - ret = paravirt_patch_jmp(insn_buff, opfunc, addr, len); #endif else /* Otherwise call the function. */ @@ -316,8 +294,6 @@ struct paravirt_patch_template pv_ops = { .cpu.load_sp0 = native_load_sp0, - .cpu.iret = native_iret, - #ifdef CONFIG_X86_IOPL_IOPERM .cpu.invalidate_io_bitmap = native_tss_invalidate_io_bitmap, .cpu.update_io_bitmap = native_tss_update_io_bitmap, @@ -422,6 +398,8 @@ struct paravirt_patch_template pv_ops = { NOKPROBE_SYMBOL(native_get_debugreg); NOKPROBE_SYMBOL(native_set_debugreg); NOKPROBE_SYMBOL(native_load_idt); + +void (*paravirt_iret)(void) = native_iret; #endif EXPORT_SYMBOL(pv_ops); diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index dc0a337f985b..08dca7bebb30 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -1070,8 +1070,6 @@ static const struct pv_cpu_ops xen_cpu_ops __initconst = { .read_pmc = xen_read_pmc, - .iret = xen_iret, - .load_tr_desc = paravirt_nop, .set_ldt = xen_set_ldt, .load_gdt = xen_load_gdt, @@ -1235,6 +1233,7 @@ asmlinkage __visible void __init xen_start_kernel(void) pv_info = xen_info; pv_ops.init.patch = paravirt_patch_default; pv_ops.cpu = xen_cpu_ops; + paravirt_iret = xen_iret; xen_init_irq_ops(); /* -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:29:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:29:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94862.178812 (Exim 4.92) (envelope-from ) id 1lJF0l-0005ZV-4E; Mon, 08 Mar 2021 12:29:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94862.178812; Mon, 08 Mar 2021 12:29:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0k-0005ZF-W1; Mon, 08 Mar 2021 12:29:22 +0000 Received: by outflank-mailman (input) for mailman id 94862; Mon, 08 Mar 2021 12:29:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0j-0004nW-Am for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:29:21 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6f2e29f1-379a-4b1f-a293-d456c934705d; Mon, 08 Mar 2021 12:28:53 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 115ECAE15; Mon, 8 Mar 2021 12:28:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f2e29f1-379a-4b1f-a293-d456c934705d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615206533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5YR3hNX0yBdFcgPcF7U4KlwSnmq7ehGDCeVDaDqUAAs=; b=nsIlf7yThLUOKt6MsOK0KR2favQqI5cdQ+rYrIVBkUKTIUhEwr8HWQZfRZIaQd6qtspr2d ZnujTb8510z4sdpXntyiZuYhGe/LpTkqELsPTKyJ4SXe+Ko71LmtNoTLGbPZRTjCDYbGuP sXEIHiYWdGVtBb+geIHRSKRIv9TQvgI= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Boris Ostrovsky , Stefano Stabellini Subject: [PATCH v5 12/12] x86/paravirt: have only one paravirt patch function Date: Mon, 8 Mar 2021 13:28:44 +0100 Message-Id: <20210308122844.30488-13-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210308122844.30488-1-jgross@suse.com> References: <20210308122844.30488-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There is no need any longer to have different paravirt patch functions for native and Xen. Eliminate native_patch() and rename paravirt_patch_default() to paravirt_patch(). Signed-off-by: Juergen Gross --- V3: - remove paravirt_patch_insns() (kernel test robot) --- arch/x86/include/asm/paravirt_types.h | 19 +------------------ arch/x86/kernel/Makefile | 3 +-- arch/x86/kernel/alternative.c | 2 +- arch/x86/kernel/paravirt.c | 20 ++------------------ arch/x86/kernel/paravirt_patch.c | 11 ----------- arch/x86/xen/enlighten_pv.c | 1 - 6 files changed, 5 insertions(+), 51 deletions(-) delete mode 100644 arch/x86/kernel/paravirt_patch.c diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 588ff14ce969..62efbf8bd8f0 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -68,19 +68,6 @@ struct pv_info { const char *name; }; -struct pv_init_ops { - /* - * Patch may replace one of the defined code sequences with - * arbitrary code, subject to the same register constraints. - * This generally means the code is not free to clobber any - * registers other than EAX. The patch function should return - * the number of bytes of code generated, as we nop pad the - * rest in generic code. - */ - unsigned (*patch)(u8 type, void *insn_buff, - unsigned long addr, unsigned len); -} __no_randomize_layout; - #ifdef CONFIG_PARAVIRT_XXL struct pv_lazy_ops { /* Set deferred update mode, used for batching operations. */ @@ -276,7 +263,6 @@ struct pv_lock_ops { * number for each function using the offset which we use to indicate * what to patch. */ struct paravirt_patch_template { - struct pv_init_ops init; struct pv_cpu_ops cpu; struct pv_irq_ops irq; struct pv_mmu_ops mmu; @@ -317,10 +303,7 @@ extern void (*paravirt_iret)(void); /* Simple instruction patching code. */ #define NATIVE_LABEL(a,x,b) "\n\t.globl " a #x "_" #b "\n" a #x "_" #b ":\n\t" -unsigned paravirt_patch_default(u8 type, void *insn_buff, unsigned long addr, unsigned len); -unsigned paravirt_patch_insns(void *insn_buff, unsigned len, const char *start, const char *end); - -unsigned native_patch(u8 type, void *insn_buff, unsigned long addr, unsigned len); +unsigned int paravirt_patch(u8 type, void *insn_buff, unsigned long addr, unsigned int len); int paravirt_disable_iospace(void); diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile index 2ddf08351f0b..0704c2a94272 100644 --- a/arch/x86/kernel/Makefile +++ b/arch/x86/kernel/Makefile @@ -35,7 +35,6 @@ KASAN_SANITIZE_sev-es.o := n KCSAN_SANITIZE := n OBJECT_FILES_NON_STANDARD_test_nx.o := y -OBJECT_FILES_NON_STANDARD_paravirt_patch.o := y ifdef CONFIG_FRAME_POINTER OBJECT_FILES_NON_STANDARD_ftrace_$(BITS).o := y @@ -121,7 +120,7 @@ obj-$(CONFIG_AMD_NB) += amd_nb.o obj-$(CONFIG_DEBUG_NMI_SELFTEST) += nmi_selftest.o obj-$(CONFIG_KVM_GUEST) += kvm.o kvmclock.o -obj-$(CONFIG_PARAVIRT) += paravirt.o paravirt_patch.o +obj-$(CONFIG_PARAVIRT) += paravirt.o obj-$(CONFIG_PARAVIRT_SPINLOCKS)+= paravirt-spinlocks.o obj-$(CONFIG_PARAVIRT_CLOCK) += pvclock.o obj-$(CONFIG_X86_PMEM_LEGACY_DEVICE) += pmem.o diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index ab9ad729fc5a..8f922b65c3c5 100644 --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -607,7 +607,7 @@ void __init_or_module apply_paravirt(struct paravirt_patch_site *start, BUG_ON(p->len > MAX_PATCH_LEN); /* prep the buffer with the original instructions */ memcpy(insn_buff, p->instr, p->len); - used = pv_ops.init.patch(p->type, insn_buff, (unsigned long)p->instr, p->len); + used = paravirt_patch(p->type, insn_buff, (unsigned long)p->instr, p->len); BUG_ON(used > p->len); diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 082954930809..3d7b989ed6be 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -99,8 +99,8 @@ void __init native_pv_lock_init(void) static_branch_disable(&virt_spin_lock_key); } -unsigned paravirt_patch_default(u8 type, void *insn_buff, - unsigned long addr, unsigned len) +unsigned int paravirt_patch(u8 type, void *insn_buff, unsigned long addr, + unsigned int len) { /* * Neat trick to map patch type back to the call within the @@ -121,19 +121,6 @@ unsigned paravirt_patch_default(u8 type, void *insn_buff, return ret; } -unsigned paravirt_patch_insns(void *insn_buff, unsigned len, - const char *start, const char *end) -{ - unsigned insn_len = end - start; - - /* Alternative instruction is too large for the patch site and we cannot continue: */ - BUG_ON(insn_len > len || start == NULL); - - memcpy(insn_buff, start, insn_len); - - return insn_len; -} - struct static_key paravirt_steal_enabled; struct static_key paravirt_steal_rq_enabled; @@ -255,9 +242,6 @@ struct pv_info pv_info = { #define PTE_IDENT __PV_IS_CALLEE_SAVE(_paravirt_ident_64) struct paravirt_patch_template pv_ops = { - /* Init ops. */ - .init.patch = native_patch, - /* Cpu ops. */ .cpu.io_delay = native_io_delay, diff --git a/arch/x86/kernel/paravirt_patch.c b/arch/x86/kernel/paravirt_patch.c deleted file mode 100644 index 10543dcc8211..000000000000 --- a/arch/x86/kernel/paravirt_patch.c +++ /dev/null @@ -1,11 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -#include - -#include -#include - -unsigned int native_patch(u8 type, void *insn_buff, unsigned long addr, - unsigned int len) -{ - return paravirt_patch_default(type, insn_buff, addr, len); -} diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 08dca7bebb30..4f18cd9eacd8 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -1231,7 +1231,6 @@ asmlinkage __visible void __init xen_start_kernel(void) /* Install Xen paravirt ops */ pv_info = xen_info; - pv_ops.init.patch = paravirt_patch_default; pv_ops.cpu = xen_cpu_ops; paravirt_iret = xen_iret; xen_init_irq_ops(); -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:29:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:29:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94864.178824 (Exim 4.92) (envelope-from ) id 1lJF0q-0005hB-Fi; Mon, 08 Mar 2021 12:29:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94864.178824; Mon, 08 Mar 2021 12:29:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0q-0005h1-BS; Mon, 08 Mar 2021 12:29:28 +0000 Received: by outflank-mailman (input) for mailman id 94864; Mon, 08 Mar 2021 12:29:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF0o-0004nW-B2 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:29:26 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9eb464af-f222-4ef0-9fcd-f7b7cfe6fab1; Mon, 08 Mar 2021 12:28:53 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B408DAE1F; Mon, 8 Mar 2021 12:28:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9eb464af-f222-4ef0-9fcd-f7b7cfe6fab1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615206532; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ujj2q0CmaDEoJEwmJJSZa/GkKTyukOclyKab3L4s/uE=; b=ZvF05EtGvfNNHmVFqo1VqEqxiBLGbcxdc38UO60Tv6z5MpHFcgwh4VQPkrak2VOlblx8uk hqFJ766xvTaot2iNr25Ou6Sy9Fn+8OqSpD45nBzghjGWmCAtxLzW9cL0yaH5LOdxcMhjb/ Rih1dF3PVr/gjELOjrEWw2v5i+VtEsY= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Juergen Gross , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Deep Shah , "VMware, Inc." Subject: [PATCH v5 11/12] x86/paravirt: switch functions with custom code to ALTERNATIVE Date: Mon, 8 Mar 2021 13:28:43 +0100 Message-Id: <20210308122844.30488-12-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210308122844.30488-1-jgross@suse.com> References: <20210308122844.30488-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using paravirt patching for custom code sequences use ALTERNATIVE for the functions with custom code replacements. Instead of patching an ud2 instruction for unpopulated vector entries into the caller site, use a simple function just calling BUG() as a replacement. Simplify the register defines for assembler paravirt calling, as there isn't much usage left. Signed-off-by: Juergen Gross --- V4: - fixed SAVE_FLAGS() (kernel test robot) - added assembler paravirt cleanup --- arch/x86/entry/entry_64.S | 2 +- arch/x86/include/asm/irqflags.h | 2 +- arch/x86/include/asm/paravirt.h | 99 +++++++++++++-------------- arch/x86/include/asm/paravirt_types.h | 6 -- arch/x86/kernel/paravirt.c | 16 ++--- arch/x86/kernel/paravirt_patch.c | 88 ------------------------ 6 files changed, 56 insertions(+), 157 deletions(-) diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index 400908dff42e..12e2e3cd58be 100644 --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -305,7 +305,7 @@ SYM_CODE_END(ret_from_fork) .macro DEBUG_ENTRY_ASSERT_IRQS_OFF #ifdef CONFIG_DEBUG_ENTRY pushq %rax - SAVE_FLAGS(CLBR_RAX) + SAVE_FLAGS testl $X86_EFLAGS_IF, %eax jz .Lokay_\@ ud2 diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h index a0efbcd24b86..c5ce9845c999 100644 --- a/arch/x86/include/asm/irqflags.h +++ b/arch/x86/include/asm/irqflags.h @@ -111,7 +111,7 @@ static __always_inline unsigned long arch_local_irq_save(void) #ifdef CONFIG_X86_64 #ifdef CONFIG_DEBUG_ENTRY -#define SAVE_FLAGS(x) pushfq; popq %rax +#define SAVE_FLAGS pushfq; popq %rax #endif #define INTERRUPT_RETURN jmp native_iret diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 36cd71fa097f..04b3067f31b5 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -137,7 +137,8 @@ static inline void write_cr0(unsigned long x) static inline unsigned long read_cr2(void) { - return PVOP_CALLEE0(unsigned long, mmu.read_cr2); + return PVOP_ALT_CALLEE0(unsigned long, mmu.read_cr2, + "mov %%cr2, %%rax;", ~X86_FEATURE_XENPV); } static inline void write_cr2(unsigned long x) @@ -147,12 +148,14 @@ static inline void write_cr2(unsigned long x) static inline unsigned long __read_cr3(void) { - return PVOP_CALL0(unsigned long, mmu.read_cr3); + return PVOP_ALT_CALL0(unsigned long, mmu.read_cr3, + "mov %%cr3, %%rax;", ~X86_FEATURE_XENPV); } static inline void write_cr3(unsigned long x) { - PVOP_VCALL1(mmu.write_cr3, x); + PVOP_ALT_VCALL1(mmu.write_cr3, x, + "mov %%rdi, %%cr3", ~X86_FEATURE_XENPV); } static inline void __write_cr4(unsigned long x) @@ -172,7 +175,7 @@ static inline void halt(void) static inline void wbinvd(void) { - PVOP_VCALL0(cpu.wbinvd); + PVOP_ALT_VCALL0(cpu.wbinvd, "wbinvd", ~X86_FEATURE_XENPV); } static inline u64 paravirt_read_msr(unsigned msr) @@ -386,22 +389,28 @@ static inline void paravirt_release_p4d(unsigned long pfn) static inline pte_t __pte(pteval_t val) { - return (pte_t) { PVOP_CALLEE1(pteval_t, mmu.make_pte, val) }; + return (pte_t) { PVOP_ALT_CALLEE1(pteval_t, mmu.make_pte, val, + "mov %%rdi, %%rax", + ~X86_FEATURE_XENPV) }; } static inline pteval_t pte_val(pte_t pte) { - return PVOP_CALLEE1(pteval_t, mmu.pte_val, pte.pte); + return PVOP_ALT_CALLEE1(pteval_t, mmu.pte_val, pte.pte, + "mov %%rdi, %%rax", ~X86_FEATURE_XENPV); } static inline pgd_t __pgd(pgdval_t val) { - return (pgd_t) { PVOP_CALLEE1(pgdval_t, mmu.make_pgd, val) }; + return (pgd_t) { PVOP_ALT_CALLEE1(pgdval_t, mmu.make_pgd, val, + "mov %%rdi, %%rax", + ~X86_FEATURE_XENPV) }; } static inline pgdval_t pgd_val(pgd_t pgd) { - return PVOP_CALLEE1(pgdval_t, mmu.pgd_val, pgd.pgd); + return PVOP_ALT_CALLEE1(pgdval_t, mmu.pgd_val, pgd.pgd, + "mov %%rdi, %%rax", ~X86_FEATURE_XENPV); } #define __HAVE_ARCH_PTEP_MODIFY_PROT_TRANSACTION @@ -434,12 +443,15 @@ static inline void set_pmd(pmd_t *pmdp, pmd_t pmd) static inline pmd_t __pmd(pmdval_t val) { - return (pmd_t) { PVOP_CALLEE1(pmdval_t, mmu.make_pmd, val) }; + return (pmd_t) { PVOP_ALT_CALLEE1(pmdval_t, mmu.make_pmd, val, + "mov %%rdi, %%rax", + ~X86_FEATURE_XENPV) }; } static inline pmdval_t pmd_val(pmd_t pmd) { - return PVOP_CALLEE1(pmdval_t, mmu.pmd_val, pmd.pmd); + return PVOP_ALT_CALLEE1(pmdval_t, mmu.pmd_val, pmd.pmd, + "mov %%rdi, %%rax", ~X86_FEATURE_XENPV); } static inline void set_pud(pud_t *pudp, pud_t pud) @@ -451,14 +463,16 @@ static inline pud_t __pud(pudval_t val) { pudval_t ret; - ret = PVOP_CALLEE1(pudval_t, mmu.make_pud, val); + ret = PVOP_ALT_CALLEE1(pudval_t, mmu.make_pud, val, + "mov %%rdi, %%rax", ~X86_FEATURE_XENPV); return (pud_t) { ret }; } static inline pudval_t pud_val(pud_t pud) { - return PVOP_CALLEE1(pudval_t, mmu.pud_val, pud.pud); + return PVOP_ALT_CALLEE1(pudval_t, mmu.pud_val, pud.pud, + "mov %%rdi, %%rax", ~X86_FEATURE_XENPV); } static inline void pud_clear(pud_t *pudp) @@ -477,14 +491,16 @@ static inline void set_p4d(p4d_t *p4dp, p4d_t p4d) static inline p4d_t __p4d(p4dval_t val) { - p4dval_t ret = PVOP_CALLEE1(p4dval_t, mmu.make_p4d, val); + p4dval_t ret = PVOP_ALT_CALLEE1(p4dval_t, mmu.make_p4d, val, + "mov %%rdi, %%rax", ~X86_FEATURE_XENPV); return (p4d_t) { ret }; } static inline p4dval_t p4d_val(p4d_t p4d) { - return PVOP_CALLEE1(p4dval_t, mmu.p4d_val, p4d.p4d); + return PVOP_ALT_CALLEE1(p4dval_t, mmu.p4d_val, p4d.p4d, + "mov %%rdi, %%rax", ~X86_FEATURE_XENPV); } static inline void __set_pgd(pgd_t *pgdp, pgd_t pgd) @@ -571,7 +587,9 @@ static __always_inline void pv_queued_spin_lock_slowpath(struct qspinlock *lock, static __always_inline void pv_queued_spin_unlock(struct qspinlock *lock) { - PVOP_VCALLEE1(lock.queued_spin_unlock, lock); + PVOP_ALT_VCALLEE1(lock.queued_spin_unlock, lock, + "movb $0, (%%" _ASM_ARG1 ");", + ~X86_FEATURE_PVUNLOCK); } static __always_inline void pv_wait(u8 *ptr, u8 val) @@ -586,7 +604,9 @@ static __always_inline void pv_kick(int cpu) static __always_inline bool pv_vcpu_is_preempted(long cpu) { - return PVOP_CALLEE1(bool, lock.vcpu_is_preempted, cpu); + return PVOP_ALT_CALLEE1(bool, lock.vcpu_is_preempted, cpu, + "xor %%" _ASM_AX ", %%" _ASM_AX ";", + ~X86_FEATURE_VCPUPREEMPT); } void __raw_callee_save___native_queued_spin_unlock(struct qspinlock *lock); @@ -660,17 +680,18 @@ bool __raw_callee_save___native_vcpu_is_preempted(long cpu); #ifdef CONFIG_PARAVIRT_XXL static inline notrace unsigned long arch_local_save_flags(void) { - return PVOP_CALLEE0(unsigned long, irq.save_fl); + return PVOP_ALT_CALLEE0(unsigned long, irq.save_fl, + "pushf; pop %%rax;", ~X86_FEATURE_XENPV); } static inline notrace void arch_local_irq_disable(void) { - PVOP_VCALLEE0(irq.irq_disable); + PVOP_ALT_VCALLEE0(irq.irq_disable, "cli;", ~X86_FEATURE_XENPV); } static inline notrace void arch_local_irq_enable(void) { - PVOP_VCALLEE0(irq.irq_enable); + PVOP_ALT_VCALLEE0(irq.irq_enable, "sti;", ~X86_FEATURE_XENPV); } static inline notrace unsigned long arch_local_irq_save(void) @@ -715,35 +736,9 @@ extern void default_banner(void); .popsection -#define COND_PUSH(set, mask, reg) \ - .if ((~(set)) & mask); push %reg; .endif -#define COND_POP(set, mask, reg) \ - .if ((~(set)) & mask); pop %reg; .endif - #ifdef CONFIG_X86_64 #ifdef CONFIG_PARAVIRT_XXL -#define PV_SAVE_REGS(set) \ - COND_PUSH(set, CLBR_RAX, rax); \ - COND_PUSH(set, CLBR_RCX, rcx); \ - COND_PUSH(set, CLBR_RDX, rdx); \ - COND_PUSH(set, CLBR_RSI, rsi); \ - COND_PUSH(set, CLBR_RDI, rdi); \ - COND_PUSH(set, CLBR_R8, r8); \ - COND_PUSH(set, CLBR_R9, r9); \ - COND_PUSH(set, CLBR_R10, r10); \ - COND_PUSH(set, CLBR_R11, r11) -#define PV_RESTORE_REGS(set) \ - COND_POP(set, CLBR_R11, r11); \ - COND_POP(set, CLBR_R10, r10); \ - COND_POP(set, CLBR_R9, r9); \ - COND_POP(set, CLBR_R8, r8); \ - COND_POP(set, CLBR_RDI, rdi); \ - COND_POP(set, CLBR_RSI, rsi); \ - COND_POP(set, CLBR_RDX, rdx); \ - COND_POP(set, CLBR_RCX, rcx); \ - COND_POP(set, CLBR_RAX, rax) - #define PARA_PATCH(off) ((off) / 8) #define PARA_SITE(ptype, ops) _PVSITE(ptype, ops, .quad, 8) #define PARA_INDIRECT(addr) *addr(%rip) @@ -754,12 +749,14 @@ extern void default_banner(void); X86_FEATURE_XENPV, "jmp xen_iret;", "jmp native_iret;") #ifdef CONFIG_DEBUG_ENTRY -#define SAVE_FLAGS(clobbers) \ - PARA_SITE(PARA_PATCH(PV_IRQ_save_fl), \ - PV_SAVE_REGS(clobbers | CLBR_CALLEE_SAVE); \ - ANNOTATE_RETPOLINE_SAFE; \ - call PARA_INDIRECT(pv_ops+PV_IRQ_save_fl); \ - PV_RESTORE_REGS(clobbers | CLBR_CALLEE_SAVE);) +.macro PARA_IRQ_save_fl + PARA_SITE(PARA_PATCH(PV_IRQ_save_fl), + ANNOTATE_RETPOLINE_SAFE; + call PARA_INDIRECT(pv_ops+PV_IRQ_save_fl);) +.endm + +#define SAVE_FLAGS ALTERNATIVE "PARA_IRQ_save_fl;", "pushf; pop %rax;", \ + ~X86_FEATURE_XENPV #endif #endif /* CONFIG_PARAVIRT_XXL */ #endif /* CONFIG_X86_64 */ diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 0ed976286d49..588ff14ce969 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -3,7 +3,6 @@ #define _ASM_X86_PARAVIRT_TYPES_H /* Bitmask of what can be clobbered: usually at least eax. */ -#define CLBR_NONE 0 #define CLBR_EAX (1 << 0) #define CLBR_ECX (1 << 1) #define CLBR_EDX (1 << 2) @@ -15,7 +14,6 @@ #define CLBR_ARG_REGS (CLBR_EAX | CLBR_EDX | CLBR_ECX) #define CLBR_RET_REG (CLBR_EAX | CLBR_EDX) -#define CLBR_SCRATCH (0) #else #define CLBR_RAX CLBR_EAX #define CLBR_RCX CLBR_ECX @@ -32,12 +30,9 @@ #define CLBR_ARG_REGS (CLBR_RDI | CLBR_RSI | CLBR_RDX | \ CLBR_RCX | CLBR_R8 | CLBR_R9) #define CLBR_RET_REG (CLBR_RAX) -#define CLBR_SCRATCH (CLBR_R10 | CLBR_R11) #endif /* X86_64 */ -#define CLBR_CALLEE_SAVE ((CLBR_ARG_REGS | CLBR_SCRATCH) & ~CLBR_RET_REG) - #ifndef __ASSEMBLY__ #include @@ -322,7 +317,6 @@ extern void (*paravirt_iret)(void); /* Simple instruction patching code. */ #define NATIVE_LABEL(a,x,b) "\n\t.globl " a #x "_" #b "\n" a #x "_" #b ":\n\t" -unsigned paravirt_patch_ident_64(void *insn_buff, unsigned len); unsigned paravirt_patch_default(u8 type, void *insn_buff, unsigned long addr, unsigned len); unsigned paravirt_patch_insns(void *insn_buff, unsigned len, const char *start, const char *end); diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 0553a339d850..082954930809 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -53,7 +53,10 @@ void __init default_banner(void) } /* Undefined instruction for dealing with missing ops pointers. */ -static const unsigned char ud2a[] = { 0x0f, 0x0b }; +static void paravirt_BUG(void) +{ + BUG(); +} struct branch { unsigned char opcode; @@ -107,17 +110,10 @@ unsigned paravirt_patch_default(u8 type, void *insn_buff, unsigned ret; if (opfunc == NULL) - /* If there's no function, patch it with a ud2a (BUG) */ - ret = paravirt_patch_insns(insn_buff, len, ud2a, ud2a+sizeof(ud2a)); + /* If there's no function, patch it with paravirt_BUG() */ + ret = paravirt_patch_call(insn_buff, paravirt_BUG, addr, len); else if (opfunc == _paravirt_nop) ret = 0; - -#ifdef CONFIG_PARAVIRT_XXL - /* identity functions just return their single argument */ - else if (opfunc == _paravirt_ident_64) - ret = paravirt_patch_ident_64(insn_buff, len); - -#endif else /* Otherwise call the function. */ ret = paravirt_patch_call(insn_buff, opfunc, addr, len); diff --git a/arch/x86/kernel/paravirt_patch.c b/arch/x86/kernel/paravirt_patch.c index abd27ec67397..10543dcc8211 100644 --- a/arch/x86/kernel/paravirt_patch.c +++ b/arch/x86/kernel/paravirt_patch.c @@ -4,96 +4,8 @@ #include #include -#define PSTART(d, m) \ - patch_data_##d.m - -#define PEND(d, m) \ - (PSTART(d, m) + sizeof(patch_data_##d.m)) - -#define PATCH(d, m, insn_buff, len) \ - paravirt_patch_insns(insn_buff, len, PSTART(d, m), PEND(d, m)) - -#define PATCH_CASE(ops, m, data, insn_buff, len) \ - case PARAVIRT_PATCH(ops.m): \ - return PATCH(data, ops##_##m, insn_buff, len) - -#ifdef CONFIG_PARAVIRT_XXL -struct patch_xxl { - const unsigned char irq_irq_disable[1]; - const unsigned char irq_irq_enable[1]; - const unsigned char irq_save_fl[2]; - const unsigned char mmu_read_cr2[3]; - const unsigned char mmu_read_cr3[3]; - const unsigned char mmu_write_cr3[3]; - const unsigned char cpu_wbinvd[2]; - const unsigned char mov64[3]; -}; - -static const struct patch_xxl patch_data_xxl = { - .irq_irq_disable = { 0xfa }, // cli - .irq_irq_enable = { 0xfb }, // sti - .irq_save_fl = { 0x9c, 0x58 }, // pushf; pop %[re]ax - .mmu_read_cr2 = { 0x0f, 0x20, 0xd0 }, // mov %cr2, %[re]ax - .mmu_read_cr3 = { 0x0f, 0x20, 0xd8 }, // mov %cr3, %[re]ax - .mmu_write_cr3 = { 0x0f, 0x22, 0xdf }, // mov %rdi, %cr3 - .cpu_wbinvd = { 0x0f, 0x09 }, // wbinvd - .mov64 = { 0x48, 0x89, 0xf8 }, // mov %rdi, %rax -}; - -unsigned int paravirt_patch_ident_64(void *insn_buff, unsigned int len) -{ - return PATCH(xxl, mov64, insn_buff, len); -} -# endif /* CONFIG_PARAVIRT_XXL */ - -#ifdef CONFIG_PARAVIRT_SPINLOCKS -struct patch_lock { - unsigned char queued_spin_unlock[3]; - unsigned char vcpu_is_preempted[2]; -}; - -static const struct patch_lock patch_data_lock = { - .vcpu_is_preempted = { 0x31, 0xc0 }, // xor %eax, %eax - -# ifdef CONFIG_X86_64 - .queued_spin_unlock = { 0xc6, 0x07, 0x00 }, // movb $0, (%rdi) -# else - .queued_spin_unlock = { 0xc6, 0x00, 0x00 }, // movb $0, (%eax) -# endif -}; -#endif /* CONFIG_PARAVIRT_SPINLOCKS */ - unsigned int native_patch(u8 type, void *insn_buff, unsigned long addr, unsigned int len) { - switch (type) { - -#ifdef CONFIG_PARAVIRT_XXL - PATCH_CASE(irq, save_fl, xxl, insn_buff, len); - PATCH_CASE(irq, irq_enable, xxl, insn_buff, len); - PATCH_CASE(irq, irq_disable, xxl, insn_buff, len); - - PATCH_CASE(mmu, read_cr2, xxl, insn_buff, len); - PATCH_CASE(mmu, read_cr3, xxl, insn_buff, len); - PATCH_CASE(mmu, write_cr3, xxl, insn_buff, len); - - PATCH_CASE(cpu, wbinvd, xxl, insn_buff, len); -#endif - -#ifdef CONFIG_PARAVIRT_SPINLOCKS - case PARAVIRT_PATCH(lock.queued_spin_unlock): - if (pv_is_native_spin_unlock()) - return PATCH(lock, queued_spin_unlock, insn_buff, len); - break; - - case PARAVIRT_PATCH(lock.vcpu_is_preempted): - if (pv_is_native_vcpu_is_preempted()) - return PATCH(lock, vcpu_is_preempted, insn_buff, len); - break; -#endif - default: - break; - } - return paravirt_patch_default(type, insn_buff, addr, len); } -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:38:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:38:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94885.178836 (Exim 4.92) (envelope-from ) id 1lJF9D-00074m-JA; Mon, 08 Mar 2021 12:38:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94885.178836; Mon, 08 Mar 2021 12:38:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF9D-00074f-FS; Mon, 08 Mar 2021 12:38:07 +0000 Received: by outflank-mailman (input) for mailman id 94885; Mon, 08 Mar 2021 12:38:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJF21-0004nW-DP for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:30:41 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dac5c8bf-ec30-4ec5-bf3b-85d414fba7d8; Mon, 08 Mar 2021 12:30:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dac5c8bf-ec30-4ec5-bf3b-85d414fba7d8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615206620; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=TayP8bEaFukGDPPCgGjSihYBohwJDVKOk1AGxYWOmrs=; b=YsBQumrwPwjgRsqYR4WnlFM3gq/GsUoqExQVNi8a1Ga2D8/MZoBCcEzB fOn7/eXxOMuFEK0/YuiK3JJFa3uEFIUDgwILUlp4hS6yihmykkKqj0WLJ d1D8YAMRiMl/H0vv959Tdi3okDacYNTrnv5+xmhw5Ptp1/8E7gJtR+iIY c=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ZF5Iyk1oXfvIbR+7liz3AQ6EtMgyTZmbc596MBcD9lEXwIHvc6AL6VluB3GrdxnN1KfdvLuNgR c5+Hd/9dPzsPMIp/bEk1J/At4Bnmxapp/E5R/GTg02lxq4roYjhPZWc1nxjSN1VX33mcAxdilO sQkZ3d8qlyEjJFr3FGrXqZqqGWKXIDZBOy/hcMdLIZXiz8/HWpOAm4CKGYplePlEZLwEZL8MrC +ho7MkXSulkJyfpLvIa8ocZOwo2XI0624kTRGb+QkrT40lJ57RnHcbaGJJWoneUm5FPOivEG+F rZM= X-SBRS: 5.2 X-MesageID: 40172049 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,232,1610427600"; d="scan'208";a="40172049" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EN1zMsWWMZSGGILUzpjJwpOcI4TeyHbxYdt9zSE+tf5lyXQrw1lBxIbYtlsOrW1Tk4zqPkLGenqca3J3PwiM4AR+6nnL2i19UyOQVVcrZqsSPJK1oZr1MJrYA+KL4ki16VexX1wqSXhc9CP1eU8Sr86iORupHUNsNh7rM6wuIIytW33UKHzAx2S85jXcK7k6ufQiryS3TIMtWbdAwrWTE9NC8D9qsjB6AWsTpxOGlD1YHnRn88KdLzNv/gdtH6A4o/F2ua21NIuaQ3eRP4qMx662cTepLswJwmXhSz2IU3aG6DEoYkRj3Qg2NE7aDXiGfOkjWxG25eHoH3al+VFPLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J16x54dZKc6ZSeGa4nuayG8cy78C5+Z71zHErQSR22M=; b=NFMQsMOx8PSXFUDifjupED6t98aZb2O+YiqtFZnkigaCHjPhW4Gpk2hhH7Qy3GQKnvpjjfHNXlcwuiGhjXmDsZAFuTUOfirWekZGpLv3NgNd9AkbtExxzL9vuj7o6ldToM7mypmqtolJAzkX5IMmsVEVAojo9qmH+rS3WrbRwk1DZCZ+7XuKUEgw8jc5f2fSr5f04q7095PyoUmMuxusjqqdQrkrJ1Y7sMZZKbyGc5i04J+uKFvzpAaOEhUpNYHit3D4wPgAez8tTs5pPW0noH/snJ81qVXyfr7EHAC5s5nQXO4N6xjijijn5Vq7sjUNAz3zbW5Mr17uzf9jVmfaIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J16x54dZKc6ZSeGa4nuayG8cy78C5+Z71zHErQSR22M=; b=B/fg4oB+ZpLRkoo7XSwLvdaf7JMZMrF2kIckT3athu+ajPwetCbuypoCLKxhbFNmpIc+fwhz0kAv10wK3vRCJbFLd1HD+ZE5zLIDX9Z1OcNakJE5Y0q4kjrEZi/YCyTyfu4KNwK9oWEMt5ZwiXgrKOb+FMQECEm/2N9U7vBdo9s= Date: Mon, 8 Mar 2021 13:29:47 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson Subject: Re: [PATCH v2 2/2][4.15] x86/AMD: expose HWCR.TscFreqSel to guests Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AM5PR0701CA0017.eurprd07.prod.outlook.com (2603:10a6:203:51::27) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 743f8c3d-d546-4a85-e40b-08d8e22ddfe8 X-MS-TrafficTypeDiagnostic: DM6PR03MB3673: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TBW+rUsowXjNyw8Ig4M71LCP6x0j4LYF0GTu26h1RrK9nV82kUrrEHilbPpTinIm2pkf3PfK+Yl1NpM70XrZdQVP7V+Rui5A9OhcqYIV/cSRjgPjj+dfP6jUKqHC8QKlnl4hj1+2aOcujrKealIKQdYgOWwCuc4G+eTdBJvSBSkczUHT4X9rp9h8QWYOPRu5cRuSI3B/oi5phs/8hIadA6+9V6uSS7DpMKNw+HMM6UWAr2gFyT7AQISB2ZkWsy2leguMd818B7GSmtakcnxCkyQ8UpsTApDklqIOOyhZu3rN8f+LBpKttrw/LQE3ZA8Z9yZ1oD87Z3MWllB+xLn7LjplT2oMZ/itD1aPVfoH7m/wwYvDReASO/okq1wFpjD2T4W9wpJaPDJwIIbryzN5FapDwFrooaxQwcuJTIy4RtgKAt6HfW4C9b6JJvDUvPLRjAkV1gdbslF1qZAx30CD8ZxtQmRKV6NJC9YxtCQZm5VawcqyQRUE2Cq0qw8CWdH2sbos1DqNXSsuQ6rTMqat/aadWxNqRRLH1wmCwIvvkR6l8eYJFO0JbijZi/FBywN8Rl56AWsScJpypqk2MaqTEVO8thF5mLCxqOu2Wmj0zFBUD7KD8y28X6fFvIhMP2gmNAxXfpG3OPJ5mWXCfuficQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(6496006)(2906002)(83380400001)(8936002)(66476007)(66946007)(66556008)(53546011)(8676002)(5660300002)(4326008)(6916009)(478600001)(956004)(26005)(16526019)(85182001)(186003)(966005)(54906003)(316002)(86362001)(33716001)(9686003)(6486002)(6666004)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Yk54RTVvSitlODJDREZUTnNRb2JMWDg5dFVoQmJXTUZXK1MxSHkzMWJycThP?= =?utf-8?B?UDBGVnkvRDhkWStMNlNlUjZSTitpM05nTG5KaXQ0S0IwZ1R2TjcxbGtYSGFm?= =?utf-8?B?bUxiSXBpVHZUejMrdUc0WEUzMk54NDZCbzV3YVllREZQUEp2L1dPNXZ0ZCtD?= =?utf-8?B?aDlTTW5qcSs1SFNnNk9mOURKRzVPZkJ6M3gzUGxkTkpqUVJmS2FWRnJXTitR?= =?utf-8?B?WS9IcHc5MCsvc2NBdWdqbC9pQ3d2QUQ3OEdHWXdpczNpNlVscjNIVUx3bDNW?= =?utf-8?B?cFJ5Q1I3QUxLZmpzV3JhZXI3WXR4N3RQQTJ4VDg4VUlVZE8yQ20zRk9DVjFI?= =?utf-8?B?SkczVXIwNThzSHFuVitlMng4ZlF2WnppNXQ5NDJNU1Z4NW51eU80MlNKejZw?= =?utf-8?B?RlNxTkFkKzI5ODI1dk5JTGVIOEFLYlZKSEJua1Z0Y2VGbEdZdzhGRnBISFRG?= =?utf-8?B?T0w4cEJKbWJXaVJRQzZZWTZxbGgxK0Z0WXpxMnNOMmNTeUZINDM3K09kc1dX?= =?utf-8?B?UnZXZWdGbVNmaysvK0VXUDlyOHhYU1dodU9pWkJKRWxsekEvTkZqNTJEN3hQ?= =?utf-8?B?ZnJsNzRhclFtRk1QdzRTbmkyYllrL3ljeVF3T1JpRFNydkVXNFpIZVVFWFNx?= =?utf-8?B?clJ6Z2xmdUZxNEpYTjZ4T29WaDVRb0tCSG04clh1TFVac1prWmlCbGtOWTZG?= =?utf-8?B?dndaNmhzeHRuKzVpdmt4WmVnZExKMUNZN1ZXUEtZaFp4ZHNQOXlDOGpKWUNr?= =?utf-8?B?elJuck9tdktsT2JaWktUeVpTaVBqdmt2eGpYWEd4QVU2NHNJazFNeERHQkkv?= =?utf-8?B?bkdRR1RKak5aZFJYWXVBZDBOemdTcnAyZEQrMTdLTlEraCtEYzFmQ2FXV2FU?= =?utf-8?B?OU9hMldSWERkNDNGTWg5czlLZG9XSjBPR3RiM2FWT3RLUU5yUENnMjVpaXR0?= =?utf-8?B?SSt4YUpMMGhycWFRQUNLWSthVFhObjYyQWN4VitQOWFzZ05KTk1HNjlxRlFC?= =?utf-8?B?UWJ5NytOZ1dHdmRpaW41Vko1MHhXczBJbThNTXpzRDE1NG9VL3BOQWV1K3hL?= =?utf-8?B?bzBqbWpvSit5T2h3SjBKN1NSaTlZTkVNR1BFOCtpWHgzcGxJNFFCUHVFQ1lh?= =?utf-8?B?RHEzMi91UU9RM1hiVGFGZzI5cUtSQ3luTzlMekxGVTNFTkVFUjNTcm5WR0dY?= =?utf-8?B?Q0NqRTYvYW01QlUza0FSN0FNSjIxMHkzOVJFeFZ0RWd5aGNmL2xlcTN3dWlD?= =?utf-8?B?OGRTcllhc05WdnpkOWYyOFBlcU8vL2M2R2Y2cUpHVzRoZlFlRlBnM29zcEpJ?= =?utf-8?B?UjE2bVNtM1V2cUVxVzR4RTU3Q3VEc2lIN1pubXVqbGFDdWwwVVFiS09LY3ZB?= =?utf-8?B?bS9INTEyM3AxaENiNnFQNm9rNmZLRUREY0d2a1VIWW9pcnREOXJBamRoc21j?= =?utf-8?B?RWF1cjRBdzlMTXV0MGREbmlHb3hFTHdOcDh0S2pIbXBwLzcrT09OaDRjTk9K?= =?utf-8?B?dElnZWpXSW1kQVlqRkFHbmdRSzcvTTh5c05WOHc0U1VmeWlFa0d3SmZYakoz?= =?utf-8?B?UE5Ja280emxLV3dhZ1FxbklBanhSbTdjMDZoU0czUzZFdy9VMmhBOFdEVVhI?= =?utf-8?B?MWpXc25XZ2xnWk9GYVM0eWJRYUxhSnA4Q0EvaldNYVZjclRxbWRJRHVuNWVD?= =?utf-8?B?am1UQUtadGJxOXg3cTdFZW9FdlNCN3FXQ2lacnNsZXIxV0pLKy95THh1Y1Nx?= =?utf-8?Q?preCFCU3zJ34NqLVlSsYy/cqCMbOemgHg7N0Xbj?= X-MS-Exchange-CrossTenant-Network-Message-Id: 743f8c3d-d546-4a85-e40b-08d8e22ddfe8 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 12:29:53.2824 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XcHTaJ2T00KyaMFwERWFNs5ePFJM1NpIFXbPXfCBxEBT1LprBz/EzY4CiL4H9ArYHF3Ls1vewWxJnb5qXdhWWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3673 X-OriginatorOrg: citrix.com On Mon, Mar 08, 2021 at 12:47:44PM +0100, Jan Beulich wrote: > On 08.03.2021 12:37, Roger Pau Monné wrote: > > On Fri, Mar 05, 2021 at 10:50:54AM +0100, Jan Beulich wrote: > >> Linux has been warning ("firmware bug") about this bit being clear for a > >> long time. While writable in older hardware it has been readonly on more > >> than just most recent hardware. For simplicitly report it always set (if > >> anything we may want to log the issue ourselves if it turns out to be > >> clear on older hardware). > >> > >> Signed-off-by: Jan Beulich > > > > Reviewed-by: Roger Pau Monné > > Thanks. > > > One question below. > > > >> --- > >> v2: New. > >> --- > >> There are likely more bits worthwhile to expose, but for about every one > >> of them there would be the risk of a lengthy discussion, as there are > >> clear downsides to exposing such information, the more that it would be > >> tbd whether the hardware values should be surfaced, and if so what > >> should happen when the guest gets migrated. > >> > >> The main risk with making the read not fault here is that guests might > >> imply they can also write this MSR then. > >> > >> --- a/xen/arch/x86/msr.c > >> +++ b/xen/arch/x86/msr.c > >> @@ -315,6 +315,12 @@ int guest_rdmsr(struct vcpu *v, uint32_t > >> *val = msrs->tsc_aux; > >> break; > >> > >> + case MSR_K8_HWCR: > >> + if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) > >> + goto gp_fault; > >> + *val = K8_HWCR_TSC_FREQ_SEL; > > > > I've been only able to find information about this MSR up to family > > 10h, but I think in theory Xen might also run on family 0Fh, do you > > know if the MSR is present there, and the bit has the same meaning? > > From its name (and its K7 alternative name) it's clear the register > had been there at that point. And indeed the bit has a different > meaning there (its the bottom bit of a 6-bit START_FID field if the > BKDG I'm looking at can be trusted. OK, I cannot seem to find the BKDG for family 0Fh. The oldest BKDG I can find is for Family 10h [0]. > Since I don't think it matters > much whether we expose a value of 0x00 or a value of 0x01 there, > and since we likely don't want to make #GP raising dependent upon > family when we don't _really_ need to, I would want to propose that > the value used is good enough uniformly. I would be fine with setting it to 0 if Fam < 10h if you think that's acceptable. I think the chances of someone running Xen >= 4.15 on such old hardware are quite dim. Thanks, Roger. [0] https://developer.amd.com/resources/developer-guides-manuals/ From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:42:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:42:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94897.178848 (Exim 4.92) (envelope-from ) id 1lJFD4-0007yI-4n; Mon, 08 Mar 2021 12:42:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94897.178848; Mon, 08 Mar 2021 12:42:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFD4-0007yB-15; Mon, 08 Mar 2021 12:42:06 +0000 Received: by outflank-mailman (input) for mailman id 94897; Mon, 08 Mar 2021 12:42:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFD2-0007y6-CR for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:42:04 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 43e0bea2-2d3c-4f1c-989b-9ed54fbde9bc; Mon, 08 Mar 2021 12:42:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43e0bea2-2d3c-4f1c-989b-9ed54fbde9bc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615207323; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=lwxeJff5SaXjLDtgN2ejyA9c7MROSOwFhLK7111f6Fc=; b=GWNz3ydirj2apjMDHiJCFPAbUWJf2YbE/y0G/C0edt4F1aPI9yUHGU6W Y/5C7w6/tb1OBXyIMnwJ8zAMVyNQQHidC4hw+ovjRIalJCByF40r/THus NkjIKRhijVGYMCbaKCRwlRXeIpklbCEnmvTFVmMIVu2aKKJZgW7yiS7d4 A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: kvrbRWJx3leiZ33IvBAeNus7VdebHLLuE6WsAgcjoK4OkTy8pP7OJJHzYWC8l2uouyTui70n73 sF9gAD56ER+czKAbbUKwWJfQLbeyQhaBmZyml0rzl48m8JmvGKNjWtVfg+fWIAsfGljjoFMzUD +jAOzYSXN8NLfVyn54SCTgIOqUy6cnmUy9e2GaUvf5seYEZesXT9RjU4Y/t4nLbmmz+F0e3b6J 6ygDRi+rjlYJG+EmwtZUXx7aZzaNwe1jSLbifLhqdZD6Le6Mkbkxa6ka+/VimacM45i/BnDxpV WkE= X-SBRS: 5.2 X-MesageID: 38944955 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,232,1610427600"; d="scan'208";a="38944955" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a0aY7Zp7SO2HV0oat3IjFA6eKsTD25uAJDwVud71I6zv/owij27yULov3UN0ypd64wPjEpLUbG2LUpsIAh3VKOkiKjmOBCt9ETDVZL2BG6kPO8r+aIGNLOcg88unl9VKALK8bziNmBi9vpEsv8EEivGlRPuLXeS+Xnift7TwuwNsvLxDYPpltS6zYafhvWW8XtvfnbPdcn3IrEJf+3H7ozNI6G5iaG/a3nKVrB69Qr9p3LWY01GDN/gBf7CWN3qI9gwi4ndYVx2CRUJEdEWr3LJRtBQbL5VxD3giRCRw7Nld2gkS27bjpk3xOIwfwo0YbourQNAitVNUVddNsOtdyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lwxeJff5SaXjLDtgN2ejyA9c7MROSOwFhLK7111f6Fc=; b=VFSf6GVwoIw0nTUeBGQFM2A9WCQ1S1UapFrCTBLCNailZLmyRkFiKsNiJi1CTOka0McbpX9aT3nk7wN8DD8Vsw7mcyClvVBdEhgFdxtLChtKPpqKUGjgy+arEH96lkaBDavGkWkzsnGYE+WZHPNltm9jzyrsbEuXiyCaG1EsbA+b/pBudATVl1d+uiVs1mlfcN4GCSix0k6r3gZxCmbmxnJZddAotm+mmJCtaVG6TszHc7hr9tQ/twIP3y8xFTUzSC3AEnVisELPChoizePP7pT1y9VdlTTVYKqGvbl4Za8tro8trgrQTVjsMww4+reKAwsoCxBGRPHG6f4qfCaNEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lwxeJff5SaXjLDtgN2ejyA9c7MROSOwFhLK7111f6Fc=; b=S+XmUD3cUFgWa0bIun7QvPMyLczSJ1Z9gL4r0MvgwJZR89iyGous4kNlZTOhOksuk2+Em/Pl/BR+GYHlfFzNm07z3S/ASKzdOowa0wIRtv+3aUpoSAYTr+t7mJbghV5xB3uxE9PhqIesB3/2QA2R4MdLkBwzSWqup3t1uilBHnM= To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: From: Andrew Cooper Subject: Re: [PATCH v2 2/2][4.15] x86/AMD: expose HWCR.TscFreqSel to guests Message-ID: Date: Mon, 8 Mar 2021 12:41:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0472.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::28) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dd4744e6-60c3-4bad-f6ca-08d8e22f8092 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5727: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eOYeKGftNBjRvKN8s/z+MpJk1n4Hx8C5MJZGBYfVk4c5WtFnQlmITo/RHSn1MPc+tTLYFoY6+PMXasQuVsk9cSVJ1PK9RDevc5q7Tvxgj41ipKYSDwE/BnZyKOsYN0a3M2qq1F3Do88cONrAwFjbnTWpO1U8g0XliYfbE5KJhhtJmr+CTHpDhWnCrjDu3+ykKWUd7EZqJlFkdn5a08krqFOpx94LpYtzM72f2tTah9wmRFqp7h2vItCS8aVIFs+p4Frm+9+vJqcQYI2qGnRJK6g0NfKkQN3EWx8JYlqSJLI9d33MyP/EELPA/SsraA6OxUCLgcAuIHgqUaJQra51TWPgu7pljANUh4XM6+0rIXRIwkR6vKUnoWV8QI4xdboXFVjaDWlnCWJ+w/9rqeYl0cnFyjGcaYdSHbyX07X98gbDOTBrpV80wL9tutj8Guw49MtHFJRTRmIcrvvf1IRDn/IoWuAb3HF84/JdGsNdSqQgBY57wGzurJCBUiEG+ORS5qgZ26vrq6Qk0eOvL79krJoM1FTEI2s8mfNvx6EOOl+3pvo0HvK10qRtZk9Tpx6fXHi4EEG81mqGp41ArxTli8KOmcBL9B1Kj2KRkgjg7xQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(4326008)(8676002)(316002)(53546011)(186003)(54906003)(2616005)(36756003)(86362001)(8936002)(66556008)(6486002)(16576012)(478600001)(83380400001)(110136005)(956004)(5660300002)(31696002)(6666004)(66946007)(2906002)(4744005)(31686004)(26005)(16526019)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ckdtNVVPVmRJUlhNQ0QwUDBLeDRlT0hmMXlSVHdPbW02bHJhSnVoSDIwcDJx?= =?utf-8?B?QjZGR0RHdzNIQjZKcHZJMXgxV3N1STY2dnFKWXpRY1hnS29ldmxXZjNNcmpI?= =?utf-8?B?am1yUWF3RnRVUVlmOVc5NFRvR0k2VVZTckZFVU5DL0I4R3d4QnlrMXdSWWF2?= =?utf-8?B?Z0tRQndqWFpOa2pMQVRTcElXN0pzdjRTME5EZWJWL3RlTTc4RnBqbStKSDRu?= =?utf-8?B?VWhQRE9HSEVZZVR1a0k1ckV0b0xINW91c2phcDBLSCtBcjJvSzVvaUFWNERI?= =?utf-8?B?S3FpcXRMdzlsQnA1dEs1c3pZUzQyV09uMlgzZ0xvZC8vNXNmVnB5YjBzTVZ3?= =?utf-8?B?K1RXSWZ6WGs1SHhXbmlsTzBSOXdNU2JvYTZpMThPc0EzOXZFakRjVmIzQXpS?= =?utf-8?B?a2hDdi9PVldIYTMxbm15SkEvZUZvSmFROUlEd2c4S2tHZUdHZGNoY29kcDVV?= =?utf-8?B?bGZtR21ubG0yV0lNN1NUczE3SGpIdUk5K2VKSnY1SWQzNjAxVzFGS005UWhQ?= =?utf-8?B?NDd3SVI3RmVROVVVM292ZVJGdHNLakJUb0RWOE5nVFVXNURXMzl6elp4S2FE?= =?utf-8?B?dXhWMXYzTmVoWjVnNGxVZ1Q0eVVRYm8wVWhjREoyS3lOdHVnVlhOVGZpNXV4?= =?utf-8?B?RzVxMWFyTUZ6enhvNlhpTERmbUNsWFFwMGVZbXVmSHJyU21MT2JpMEVndnhw?= =?utf-8?B?aVR1MlFRelI0U1NsUUpYcXhKa1hHa1QzcG5QbTNXdUZwbTV4U3o5VlJKdFRU?= =?utf-8?B?anVtYkY3V2ZQRUswT1ZQSVFVNGhzNjVWQ09uci9jM3VoZGV0V2pUUFdUMDg4?= =?utf-8?B?NkRIK29iTU9YUjZIK3Jsc3EwRmREdlhFdC9zY2dQWVJqZWV0T2FLYmYxemZR?= =?utf-8?B?YkdldFBLQTJ2TUplbXBXWVR5alkxZi9LOWRLbHJzanduUG5IYklpaU5DclJq?= =?utf-8?B?Ulc0VkJwaGY4aEdNMXk3cUIwR3FuNk40U2JrL3Vwd1k4R0g1MEdLYU1WL2xN?= =?utf-8?B?S3lxKzM2K3NPdjdOc0Z6SnFnbU1jb2NtVTA5eFA3VGdyMDBTTDNJcmFlUWh6?= =?utf-8?B?TEl0NU5nYnhpS3g4RHJwOUJUR3I3SkJqMzlYRVExNUl2NGpXbEoxd1haZEsz?= =?utf-8?B?TGZJQ2F0Z1dkSCtTb3JwdytoTG56Q0hVNzdVNmQ0cWtLSzRaMlNodE1ITElr?= =?utf-8?B?NGQ1OVJra3FYeXJuaVJTdjRaQm5WM3RJV3JPUzB5dWhLN0xWRndQM21KWmNL?= =?utf-8?B?c21IMXM3SCtuSUFDSStIa0F4anRhZXljL3pidUM2T3J2WGx2QWpCblptWXB0?= =?utf-8?B?K2ZsdGh2NlNKalJwN0xseldOTHlqWUJra1BjUy9sL2hRNkpnUWxuMnNLb2tC?= =?utf-8?B?eG5JOHBYOUZsSUorRWFoeVdWekdxQVVac3A0K0Zja2h5SXNMc3laMjRSUkJZ?= =?utf-8?B?SnZyY2F4Z0pJdHpqTytyQlFWdDJBcnlKcGV3UWt4UkszUUFvTmNzMVFXQTNh?= =?utf-8?B?SG1kUUE3clhSc2tuVGo5YSsxYUMzZy9BdkFHS0dyNllYWWg3TFpST0EydnNs?= =?utf-8?B?WWR4S3VWQ2xBS1NHb21YUUQ4RnBHdC9heHFTUEtSbEtHWDh2OFRGMnNDS1E1?= =?utf-8?B?Nmc3ZE9YUjhQRTVoUlBiaTVpZlZ6dk9IS1RtdXZRWkxWN3NnMmNROURVQU1F?= =?utf-8?B?QkhseExSczJEZ3VVcmlaUEthNmthUzVTb0ZxTk5IUVJ3cEhhRmRCSDBpVTlJ?= =?utf-8?Q?dEGHrScCEDvCNJ58+NsDOOcbDtwryuoh6FRr8qg?= X-MS-Exchange-CrossTenant-Network-Message-Id: dd4744e6-60c3-4bad-f6ca-08d8e22f8092 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 12:41:32.2719 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QJYOHkkgW+mBk/XYGOPyJ+671rdcziJa7b7+4mmz+ZGsNaBQg/fKen+ImG67gOttO25x1xnd7HZ+ucT8STVYZco41eJTA1UFufz+PU1P1rE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5727 X-OriginatorOrg: citrix.com On 05/03/2021 09:50, Jan Beulich wrote: > Linux has been warning ("firmware bug") about this bit being clear for a > long time. While writable in older hardware it has been readonly on more > than just most recent hardware. For simplicitly report it always set (if > anything we may want to log the issue ourselves if it turns out to be > clear on older hardware). > > Signed-off-by: Jan Beulich I realise Linux is complaining, but simply setting the bit isn't a fix. This needs corresponding updates in the ACPI tables, as well as Pstate MSRs, or Linux will derive a false relationship between the TSC rate and wallclock. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:42:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:42:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94899.178860 (Exim 4.92) (envelope-from ) id 1lJFDb-00083o-EG; Mon, 08 Mar 2021 12:42:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94899.178860; Mon, 08 Mar 2021 12:42:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFDb-00083h-AJ; Mon, 08 Mar 2021 12:42:39 +0000 Received: by outflank-mailman (input) for mailman id 94899; Mon, 08 Mar 2021 12:42:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFDa-00083b-6m for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 12:42:38 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3fcb9fae-39c6-4720-aec6-95ddc6e25150; Mon, 08 Mar 2021 12:42:37 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3E946AC0C; Mon, 8 Mar 2021 12:42:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3fcb9fae-39c6-4720-aec6-95ddc6e25150 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615207356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Chd/tr2rM8xqMAcHymy5HOuxuEtziYDAycbzmfjYL4=; b=HiYzDCVIt3dOGfuYckS5KEujZ2tCb0H8XQfSwVREPUZvaA3vMgpgmvs/wLHTvyEYPYKEqG oC0lRkml2WJ6V0tfk81hOxgroKZGLd/eOhcFkQSH9ZpiFZH5SQVS1PKG9oDl76O7AZ77a5 Fyp+OBgPugEFNU6znsjvvS/iKoPy17w= Subject: Re: [PATCH 2/2][4.15?] x86/shadow: encode full GFN in magic MMIO entries To: Andrew Cooper Cc: Tim Deegan , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson , "xen-devel@lists.xenproject.org" References: <041aed42-929d-287d-f9e4-c12e5a71ab38@citrix.com> From: Jan Beulich Message-ID: <0c8ff279-fc87-640a-7a39-81451166b6b1@suse.com> Date: Mon, 8 Mar 2021 13:42:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <041aed42-929d-287d-f9e4-c12e5a71ab38@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 05.03.2021 17:32, Andrew Cooper wrote: > On 05/03/2021 15:37, Jan Beulich wrote: >> Since we don't need to encode all of the PTE flags, we have enough bits >> in the shadow entry to store the full GFN. Don't use literal numbers - >> instead derive the involved values. Or, where derivation would become >> too ugly, sanity-check the result (invoking #error to identify failure). >> >> This then allows dropping from sh_l1e_mmio() again the guarding against >> too large GFNs. >> >> Signed-off-by: Jan Beulich >> --- >> I wonder if the respective check in sh_audit_l1_table() is actually >> useful to retain with these changes. >> >> --- a/xen/arch/x86/mm/shadow/types.h >> +++ b/xen/arch/x86/mm/shadow/types.h >> @@ -283,9 +283,17 @@ shadow_put_page_from_l1e(shadow_l1e_t sl >> * This is only feasible for PAE and 64bit Xen: 32-bit non-PAE PTEs don't >> * have reserved bits that we can use for this. And even there it can only >> * be used if we can be certain the processor doesn't use all 52 address bits. >> + * >> + * For the MMIO encoding (see below) we need the bottom 4 bits for >> + * identifying the kind of entry and a full GFN's worth of bits to encode >> + * the originating frame number. Set all remaining bits to trigger >> + * reserved bit faults, if (see above) the hardware permits triggering such. >> */ >> >> -#define SH_L1E_MAGIC 0xffffffff00000001ULL >> +#define SH_L1E_MAGIC_NR_META_BITS 4 >> +#define SH_L1E_MAGIC_MASK ((~0ULL << (PADDR_BITS - PAGE_SHIFT + \ >> + SH_L1E_MAGIC_NR_META_BITS)) | \ >> + _PAGE_PRESENT) >> >> static inline bool sh_have_pte_rsvd_bits(void) >> { >> @@ -294,7 +302,8 @@ static inline bool sh_have_pte_rsvd_bits >> >> static inline bool sh_l1e_is_magic(shadow_l1e_t sl1e) >> { >> - return (sl1e.l1 & SH_L1E_MAGIC) == SH_L1E_MAGIC; >> + BUILD_BUG_ON(!(PADDR_MASK & SH_L1E_MAGIC_MASK)); >> + return (sl1e.l1 & SH_L1E_MAGIC_MASK) == SH_L1E_MAGIC_MASK; >> } >> >> /* Guest not present: a single magic value */ >> @@ -320,20 +329,26 @@ static inline bool sh_l1e_is_gnp(shadow_ >> >> /* >> * MMIO: an invalid PTE that contains the GFN of the equivalent guest l1e. >> - * We store 28 bits of GFN in bits 4:32 of the entry. >> + * We store the GFN in bits 4:43 of the entry. >> * The present bit is set, and the U/S and R/W bits are taken from the guest. >> * Bit 3 is always 0, to differentiate from gnp above. >> */ >> -#define SH_L1E_MMIO_MAGIC 0xffffffff00000001ULL >> -#define SH_L1E_MMIO_MAGIC_MASK 0xffffffff00000009ULL >> -#define SH_L1E_MMIO_GFN_MASK 0x00000000fffffff0ULL >> +#define SH_L1E_MMIO_MAGIC SH_L1E_MAGIC_MASK >> +#define SH_L1E_MMIO_MAGIC_BIT ((_PAGE_PRESENT | _PAGE_RW | _PAGE_USER) + 1) >> +#if SH_L1E_MMIO_MAGIC_BIT & (SH_L1E_MMIO_MAGIC_BIT - 1) >> +# error SH_L1E_MMIO_MAGIC_BIT needs to be a power of 2 >> +#endif >> +#if SH_L1E_MMIO_MAGIC_BIT >> SH_L1E_MAGIC_NR_META_BITS >> +# error SH_L1E_MMIO_MAGIC_BIT and SH_L1E_MAGIC_NR_META_BITS are out of sync >> +#endif >> +#define SH_L1E_MMIO_MAGIC_MASK (SH_L1E_MAGIC_MASK | SH_L1E_MMIO_MAGIC_BIT) >> +#define SH_L1E_MMIO_GFN_MASK ~(SH_L1E_MMIO_MAGIC_MASK | _PAGE_RW | _PAGE_USER) > > In practice, it is 4:36, because we have to limit shadow guests to 32 > bits of gfn for XSA-173 (width of the superpage backpointer IIRC). When !BIGMEM - yes. > Also, this property is important for L1TF.  The more guest-controllable > bits we permit in here, the greater the chance of being vulnerable to > L1TF on massive machines. > > (I'm a little concerned that I can't spot an L1TF comment which has been > made stale by these changes...  Probably the fault of whichever numpty > prepared the L1TF patches, because I'm certain we discussed this at the > time) > > Going from 32 to 36 bits moves the upper safety barrier from TOP-4G to > TOP-64G but I recall us agreed that that was ok, especially as the main > safety guestimate is "no RAM in the top quarter of the address space". > > However, I don't think we want to accidentally creep beyond bit 36, so > I'd suggest that the easy fix here is just adjusting a nibble in the > MMIO masks. With BIGMEM I'm not sure we want to be this strict. Nor do we need to as long as we only need 4 bits at the bottom - we only go up to bit 43 with what we allow guests control over. IOW we will need to be careful on old hardware when l1d_maxphysaddr == 44, but on anything newer we're still far enough away I would think. So I guess instead of outright dropping the GFN check from sh_l1e_mmio() I want to replace it by use of is_l1tf_safe_maddr() (on the produced shadow_l1e_t). Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 12:47:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 12:47:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94906.178871 (Exim 4.92) (envelope-from ) id 1lJFIf-0008Jc-0s; Mon, 08 Mar 2021 12:47:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94906.178871; Mon, 08 Mar 2021 12:47:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFIe-0008JV-UH; Mon, 08 Mar 2021 12:47:52 +0000 Received: by outflank-mailman (input) for mailman id 94906; Mon, 08 Mar 2021 12:47:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFId-0008JM-RM; Mon, 08 Mar 2021 12:47:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFId-0004EZ-It; Mon, 08 Mar 2021 12:47:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFId-00086I-Aj; Mon, 08 Mar 2021 12:47:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJFId-0003im-AF; Mon, 08 Mar 2021 12:47:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KPUEZjMcnNo5l+Fk9BFSuvlimfrHIGe/POBODk84hHQ=; b=N7I4ixeUAc5v/iTn4Lj7RVI2CT HqeUJBZAtClgN5UYgkVW7MEpeJnvRBawIAu4A3ODiHZP5ipBhWvsPifKzM2JFi3s0KuggEHBeu/hK Qw5BdJsxmteYj8Bl3P8wOXJasYIDNV67R4Unci0K9OtG7P8sxCS1Q28+cd55iqBhUe9M=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 159866: all pass - PUSHED X-Osstest-Versions-This: ovmf=d28a68153492ce3e64fb0535674e11e7f46a88a8 X-Osstest-Versions-That: ovmf=b8a92fa2fea548dccacc2f228b607b7febdf81c0 From: osstest service owner Date: Mon, 08 Mar 2021 12:47:51 +0000 flight 159866 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/159866/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d28a68153492ce3e64fb0535674e11e7f46a88a8 baseline version: ovmf b8a92fa2fea548dccacc2f228b607b7febdf81c0 Last test of basis 159863 2021-03-08 01:39:46 Z 0 days Testing same since 159866 2021-03-08 06:03:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chen, Christine Laszlo Ersek Ray Ni Yuwei Chen jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b8a92fa2fe..d28a681534 d28a68153492ce3e64fb0535674e11e7f46a88a8 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Mar 08 13:11:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 13:11:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94920.178886 (Exim 4.92) (envelope-from ) id 1lJFej-0002V9-0t; Mon, 08 Mar 2021 13:10:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94920.178886; Mon, 08 Mar 2021 13:10:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFei-0002V2-U9; Mon, 08 Mar 2021 13:10:40 +0000 Received: by outflank-mailman (input) for mailman id 94920; Mon, 08 Mar 2021 13:10:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFeh-0002Ux-QO for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 13:10:39 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 832f2f00-2fbc-46ee-845e-705b938986ad; Mon, 08 Mar 2021 13:10:38 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id ABC5EAC0C; Mon, 8 Mar 2021 13:10:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 832f2f00-2fbc-46ee-845e-705b938986ad X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615209037; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ikaHvOZsjSFcGHp0AkpHCM+bRv7UlS2puP/A0AQjKV4=; b=QezPYhdcVlp9hURmJwSkcDHhykjy2hmQ43JCcowlZh+paN9j0OtPP/PgH0nSh/P46/kufO w+W6gfykckCYXnn7HErep17JIj7iAJcsBVX+K91DQ/j9g5/VBLgOmFL63fFlAA+p4K9fSI 4D1cLQhhLW5uchORYxsDmLiLUBZy7b4= Subject: Re: [PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time To: Ian Jackson Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <336aaf51-f163-8ee7-d8ee-297f6f3052fd@suse.com> <24645.62832.737310.550811@mariner.uk.xensource.com> <2857440d-058f-5c85-32d3-87e2fe65bb9a@suse.com> <24646.1454.55437.250075@mariner.uk.xensource.com> <78259adb-89b1-06a6-c1f4-c0659134e309@suse.com> <24646.5291.124853.270432@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <5be57f5c-e055-8d92-832e-f1a17352452d@suse.com> Date: Mon, 8 Mar 2021 14:10:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24646.5291.124853.270432@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 13:12, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time"): >> Possibly, but it may end up being more complex: We want to only >> retain files of specific names from a single dir. I don't think >> this is as straightforward to express in a find rune. Of course >> I'll be fine whichever way the bug gets fixed, but I'm afraid I >> don't feel convinced I want to put time into trying the alternative >> you suggest. If otoh you wanted to try out yours and it turned out >> equivalent or better, I wouldn't mind at all. > > Untested, but I think something like this should DTRT > > find xen ! -type d ! -path 'xen/lib/x86/*-autogen.h' -print0 | xargs -0r rm -- > > Since my background is GNU utilities, I checked the FreeBSD manpages > for find, xargs and rm. They support these options. > > This will leave the entire directory structure but I think that is > fine. The xen-dir target uses mkdir -p and should there be any stale > directories (eg due to switching branches or whatever) they wouldn't > be a problem. Right. Thinking of it though - all we do is setting up symlinks plus produce this generated header. Couldn't we therefore have find simply arrange for all symlinks to be found and deleted? Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 13:11:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 13:11:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94923.178898 (Exim 4.92) (envelope-from ) id 1lJFfK-0002a2-9z; Mon, 08 Mar 2021 13:11:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94923.178898; Mon, 08 Mar 2021 13:11:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFfK-0002Zv-78; Mon, 08 Mar 2021 13:11:18 +0000 Received: by outflank-mailman (input) for mailman id 94923; Mon, 08 Mar 2021 13:11:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFfI-0002Zo-F3 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 13:11:16 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 05d225c1-ea94-497c-b48b-994e1d4f1100; Mon, 08 Mar 2021 13:11:14 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB38E31B; Mon, 8 Mar 2021 05:11:13 -0800 (PST) Received: from [10.57.16.174] (unknown [10.57.16.174]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 085FD3F71B; Mon, 8 Mar 2021 05:11:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05d225c1-ea94-497c-b48b-994e1d4f1100 Subject: Re: [PATCH] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, wei.chen@arm.com, xen-devel@lists.xenproject.org References: <20210308095233.13329-1-michal.orzel@arm.com> <3709714b-6627-3c66-b8ca-4cb9c59df83b@suse.com> From: Michal Orzel Message-ID: <15564cc3-db36-e7c3-df8d-64f6f54b4f3d@arm.com> Date: Mon, 8 Mar 2021 14:11:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 12:28, Jan Beulich wrote: > On 08.03.2021 12:02, Michal Orzel wrote: >> On 08.03.2021 11:00, Jan Beulich wrote: >>> On 08.03.2021 10:52, Michal Orzel wrote: >>>> +config DTB_FILE >>>> + string "Absolute path to device tree blob" >>>> + default "" >>>> + depends on LINK_DTB >>>> + ---help--- >>>> + When using a bootloader that has no device tree support or when there >>>> + is no bootloader at all, use this option to specify the absolute path >>>> + to a device tree that will be linked directly inside Xen binary. >>> >>> How is selecting LINK_DTB but leaving DTB_FILE at an empty string >>> different from not having a LINK_DTB setting at all? >>> >> LINK_DTB acts as a switch to allow setting the dtb path. Not having LINK_DTB option will result in >> a build failure each time the user does not want to embed dtb into Xen(DTB_FILE is empty). > > Which isn't any different from having LINK_DTB and leaving the > string empty, is it? I.e. imo no improved user experience. > >> I do not see why someone would want to select LINK_DTB leaving DTB_FILE as an empty string. > > People may not "want" to, but simply think accepting the default > is fine, considering they've already said to link in some DTB. > It may be obvious to you that there's no good default here, but > it may not be to the person configuring their Xen. I'm guessing > here, but did you try leaving out the default line? Would this > make kconfig insist on the person to type in something? (Likely > an empty string would still be accepted. As would be a relative > path, despite what the help text says; I guess some forms of > relative paths may even work.) > There is no option here to make kconfig insist on person to type something. There is one solution. If I change in here: https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/Makefile;h=16e6523e2cc6072b7d4cbcdeaf4726b7a9b1d381;hb=HEAD#l71 from: ifdef CONFIG_DTB_FILE to: ifneq ($(CONFIG_DTB_FILE),"") then if user selects LINK_DTB but does not provide dtb path, the dtb will not be embedded into Xen. > Jan > Michal From xen-devel-bounces@lists.xenproject.org Mon Mar 08 13:13:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 13:13:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94926.178910 (Exim 4.92) (envelope-from ) id 1lJFh3-0002kK-Lx; Mon, 08 Mar 2021 13:13:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94926.178910; Mon, 08 Mar 2021 13:13:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFh3-0002kD-Iu; Mon, 08 Mar 2021 13:13:05 +0000 Received: by outflank-mailman (input) for mailman id 94926; Mon, 08 Mar 2021 13:13:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFh1-0002k5-VK for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 13:13:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fc7db176-3687-4bdc-820f-efb9ff95eb47; Mon, 08 Mar 2021 13:13:03 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 43F38ADCD; Mon, 8 Mar 2021 13:13:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc7db176-3687-4bdc-820f-efb9ff95eb47 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615209182; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UYnkqgYLXmPJ86v4XS0/mBkR7UMEYP7Bn/4/YNwkid4=; b=AG/BBZb9MshXDet/BC5trZzlsme4VF8NRTFZdjavBYuNxLXJjzqmqw9jbWnBa1fEWb/Rdw y+gCMrH1QwHJNe2MFkvm0o2f43m6ira0QK98b5Jva6xiN99h9qGYgAjL6U01NJXM3PpClZ 2TwEy4KfXb0FBE4c3HYJtUhlcaIQv2o= Subject: Re: [PATCH] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, wei.chen@arm.com, xen-devel@lists.xenproject.org References: <20210308095233.13329-1-michal.orzel@arm.com> <3709714b-6627-3c66-b8ca-4cb9c59df83b@suse.com> <15564cc3-db36-e7c3-df8d-64f6f54b4f3d@arm.com> From: Jan Beulich Message-ID: Date: Mon, 8 Mar 2021 14:13:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <15564cc3-db36-e7c3-df8d-64f6f54b4f3d@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 14:11, Michal Orzel wrote: > > > On 08.03.2021 12:28, Jan Beulich wrote: >> On 08.03.2021 12:02, Michal Orzel wrote: >>> On 08.03.2021 11:00, Jan Beulich wrote: >>>> On 08.03.2021 10:52, Michal Orzel wrote: >>>>> +config DTB_FILE >>>>> + string "Absolute path to device tree blob" >>>>> + default "" >>>>> + depends on LINK_DTB >>>>> + ---help--- >>>>> + When using a bootloader that has no device tree support or when there >>>>> + is no bootloader at all, use this option to specify the absolute path >>>>> + to a device tree that will be linked directly inside Xen binary. >>>> >>>> How is selecting LINK_DTB but leaving DTB_FILE at an empty string >>>> different from not having a LINK_DTB setting at all? >>>> >>> LINK_DTB acts as a switch to allow setting the dtb path. Not having LINK_DTB option will result in >>> a build failure each time the user does not want to embed dtb into Xen(DTB_FILE is empty). >> >> Which isn't any different from having LINK_DTB and leaving the >> string empty, is it? I.e. imo no improved user experience. >> >>> I do not see why someone would want to select LINK_DTB leaving DTB_FILE as an empty string. >> >> People may not "want" to, but simply think accepting the default >> is fine, considering they've already said to link in some DTB. >> It may be obvious to you that there's no good default here, but >> it may not be to the person configuring their Xen. I'm guessing >> here, but did you try leaving out the default line? Would this >> make kconfig insist on the person to type in something? (Likely >> an empty string would still be accepted. As would be a relative >> path, despite what the help text says; I guess some forms of >> relative paths may even work.) >> > There is no option here to make kconfig insist on person to type something. > There is one solution. If I change in here: > https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/Makefile;h=16e6523e2cc6072b7d4cbcdeaf4726b7a9b1d381;hb=HEAD#l71 > from: > ifdef CONFIG_DTB_FILE > to: > ifneq ($(CONFIG_DTB_FILE),"") > then if user selects LINK_DTB but does not provide dtb path, the dtb will not be embedded into Xen. I think this would be preferable plus eliminate the need for the separate LINK_DTB option. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 13:24:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 13:24:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94929.178923 (Exim 4.92) (envelope-from ) id 1lJFrf-0003k7-Li; Mon, 08 Mar 2021 13:24:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94929.178923; Mon, 08 Mar 2021 13:24:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFrf-0003k0-Ii; Mon, 08 Mar 2021 13:24:03 +0000 Received: by outflank-mailman (input) for mailman id 94929; Mon, 08 Mar 2021 13:24:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFre-0003jv-Ju for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 13:24:02 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 126a8a3a-8337-4d12-843b-61420450df22; Mon, 08 Mar 2021 13:24:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 126a8a3a-8337-4d12-843b-61420450df22 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615209841; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=dvnutj5LhdEbnqawxG8imUUOTyeJZ+QPZ7sJp9w/BPk=; b=VOOiJu8Hdb6jkgV+wKQf9XBpc22hmbqpq99CzcI3FVGEajzAboAvegBo RVhI3cub3D8k7g79O/qQ3nsarsJF9K0xP3mVfi87EgGjD74dS7pcb1UT+ Cng9QXOBVt+iEQlXaDH7rCHJW1weUiexvZ1n5h6HO3QgG295MDymM9C5O A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: xwSVB7zjdkutq2fZNKgNP0aTB5o9b8mNabj8iB2p8nmcMtJFWr6AMlqYXeRNdCU0YbycmvehpP fNGExeAh/4pZhw4vUzFXW9QMYGkAWqEgHGxI/kXNVij853OHYgGagv5C0HbitOPBRzXhSCpCQz J9LUyGGFard/l0sUccZUFaHzv0hMO0dHE5qEQi+gfFNJVW2i8RDx3x6B98Q/9E6SoSpLFu+aX9 r3cI1zC64HuwLrMzm1RJcRW6QbhY2Be3LtE4p/qKxViUPtVqURValOPhphIlX43KNlt0QQoWtG TeE= X-SBRS: 5.2 X-MesageID: 38679564 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,232,1610427600"; d="scan'208";a="38679564" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A5pQ02Vt6N37awqUQYotm6TGTdid6/Q6Xkq+Da4Bb/rW4+c1NHE+hWrGnAT5Mteb7mH3U0cDDy8kn8q96ZZovp8Bfepjkh/4X1lMzEKgeXVLQUu68kfw6xvfdyVy9egtzdoOPbdyVsxTaRNtSNRxOeLmXd0GOUYO30G71yo/fcKmlpiy+gpKhIJofcXI7OG+Y4lakJiCwSIiSHtSsXZaC++3SzCvOreBdUpbnyVWGdyCWl4nDCnyouFod8M+RbEkKcpL8b6WtPGXSxUJTkoNo2b9HGhLoTCNtiVfrf5Nui2mIUidsmI6JCcyaQgU/PdQxBM5bhOgCcP0MfUQVcgTpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=il//Mm0vq5qV1tMQrzMYc2d+Zzd83nBje/+yds0tuJ8=; b=NYn5rwea0tlm9YI6vzB35/gVtAomNnULqwepPP6jNeKWLdlEbKzdctBwEdPn5VkdYKsKVUIG90FHqtEaJIxkNCqEdwm84PMXfOWkAWm1tfzr115zwgzBsnwwzC+/1J0KmfhtNWKkmIXgbd+NfIRHsDuJsI9o9z0jV05wxd9Y6tTPAaMFSgln4tuu4haWpVwFA9iU19I9JmTdoE2JRwkE4Z5WIGFzX2PjjOmsweyWsorTVSdAGmoD/sNHB0EbCj2Gh5btAC39yBmFEFPZAP2AxF9vPOH9YpoW1WxKsyHOuMZizNVRdkoezS53V1LVn+GxBtPxk8O6SkjwwVBObjNoDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=il//Mm0vq5qV1tMQrzMYc2d+Zzd83nBje/+yds0tuJ8=; b=hJrvWvc1I6Gb70KoIP2PRKw7RucM0eh3KCbG8WfhAvz/bUwy6saZbJP0Pz0ON0/5QHlsDGh6421szZnhrx39qOMfhAADUb++h1Q2Tf4gidO4pGSBtqscbjV00TA1NLY15fA6JJQtWFrR1D03kr4HQu6pUyoyPOc5SlyKExA4A38= Date: Mon, 8 Mar 2021 14:23:25 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Jan Beulich , "xen-devel@lists.xenproject.org" , Wei Liu , Ian Jackson Subject: Re: [PATCH v2 2/2][4.15] x86/AMD: expose HWCR.TscFreqSel to guests Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: PR0P264CA0054.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1d::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5b64e94b-2993-4fbf-0a5b-08d8e2355df5 X-MS-TrafficTypeDiagnostic: DM5PR03MB2971: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GjgaCYsTvg6lld/pvkWDotssrkkRjmKepCNGXzFcRm5xrEaP2HohoGqi5eFmbSJiBmwZi+mF4dt2+PAT9FHLJB66mmc3PixGYPMrIyo6lNuDPuGYHNCu5NMyqvKrgqNB2yFHsuNTLfA7XinTwYXmWz9+5OJ10XUqaOLAR6ML/bRkCr+WZ9lyMRK2XxtLez8LWtKL87Ggr7RyoTORfO30CF45KjnMb/vDC13mO6aYxPXM0RHL2xfWqtZrI4R4qdv0jnCQ9SfT0ychwPH302kXZ0K5xh2X0GzsbGUKhtyLMuSAAS6/9nDiEJvoid6jdLgmDTmyCCEWzAB55hxqTBsomhNcnKXKBv7BV/Lx7+QFtb+ugzPzcyHAPNjPJI6OWUmvJEYmtYqHl1vsnovaHRo/kxLQuhyA0VsztcDqSb0k9jY8Dlmj9abNO84Zq8SSNWNBVD/w7VZ/5N4gDR99CrVP3PpMX3RDYgn0C5aj4NDYlZKuSP5Wd/le5spUXxw/HIUcHh7CqkXbUMLNyPx+14vn6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(346002)(366004)(396003)(39860400002)(136003)(376002)(5660300002)(66476007)(66556008)(2906002)(4744005)(26005)(8676002)(6496006)(6862004)(8936002)(53546011)(478600001)(956004)(6486002)(86362001)(4326008)(66946007)(16526019)(6666004)(186003)(316002)(33716001)(85182001)(83380400001)(6636002)(9686003)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dkl3LzJBcXpaa1N5Q3BVUU5mUEw1WWFreE9tQWpGdzVmT2IvVXlMYWtNN0tW?= =?utf-8?B?M0JvY0oxbk55MEZwNDF3WEpUbE1vUEk5SFVhUGE2emRCcUE4Y1QxM29VWEFr?= =?utf-8?B?Y25uUG9XOHhZcmpKNVQwV2gyRk53V1E0eUNtQitpL2NYcUVPaERvWjRuS1Ru?= =?utf-8?B?bUNndXEydDhXek9EQU95TVN1Y2NQMGRPbnpwRjJ5dTZzNlVSTHh6SXFsSEdI?= =?utf-8?B?WHJpVDZOYmtlZ3JPa2g3VnBBckJITGVzcm1vZFNvQVlZc0FrV2JBQzlGN1lT?= =?utf-8?B?c015andCbkR1cGtmTGlTU0U0RWlTV0lkYWRvSnF4ZTRoVnlRUytnTSswVHNk?= =?utf-8?B?R3BzMC9MWjM5TXZrMlpZU295YS9hVmVEY1VhdUhtZXFJVnVkRUpWNjdST1kx?= =?utf-8?B?V3ZjeXVJcGN3WTM4QzlZQjZEV1F3ODA1bDBiOGpSeFZEUmhZa0VmL3pqUWFD?= =?utf-8?B?cFo4V2p1QWFwSnV4MVluVERhMExnekM3NUJOZUN1aHhDcnVhdHcwSkR0QkJO?= =?utf-8?B?SmZQZjFpZldSSTFITDJPbE91ZW9wd0lpRGhSQm5SWiszdmo0b05xVDNVSENO?= =?utf-8?B?Y2lJSjh5TW0wN29BTEI0NVNEM3pwb25kaG54QnNwY25JWE5VaUE3T09Zdjk5?= =?utf-8?B?OFl6NGl5dG1lL1hhRzQ5dnVCZGNKbEhqRlVZdU02aGEzUGZRdTJkVEFGS1BV?= =?utf-8?B?enYrZzFMbTYxVkJFZ2IyZE1uUG1VbWhDZ2FmN3MxaHJkSkZPRlV4T21Hc1kv?= =?utf-8?B?Ylllek9VdnNmSDE4RHlDQm5pbnRhOXFsTURERzZYaUw2bWUrZ3VZbFBkNlQy?= =?utf-8?B?L2xOS1R6QzNyOUNkTmJlRnU1WmgvOVVGZEtYTmc4em11eU1iV2o0eENKcFA1?= =?utf-8?B?ODJvSVZBa3R0OVJhTlFYTkRDYVplcVJmZmR5SEZJUUNST25IYWpkVEJCRjNu?= =?utf-8?B?cURxdW5XNms1NHNrMXY0U1hqOG00NGpoSEhEb3JTdTV1M1dhd3U4blNpTGdm?= =?utf-8?B?VVJ1ZWtPaTN3c2xrdzR5aU1POUdLT294UzNGNjhtTWVJNmZpQks3cVZtNjE0?= =?utf-8?B?cmpCVGxrbHNFa2Q2bzlzV3RuSmVTYzNnV0VFbjBNUU9XTEJhb2M3Q2szeUdu?= =?utf-8?B?YXhpRjZWcGZhRTVpY054VkRsaWJxY250eVZNeU1SU2U1LytlQ2xMTkEzdzBy?= =?utf-8?B?bzd2V0hhdGZkQjNJa2lsRHIwUnJBNldWdGVtZWkxcUp2Wm5CYVpTVmFncFlN?= =?utf-8?B?b1Z5S0kzRmtnQ00zQzRsWkJGdDlQcHA1bStyNlA3NklDTGFRQm1MdHdNT2U1?= =?utf-8?B?OUNLWFVmZi9tOGVQSHArc1FTcnFjL1dSRjRSWDhlR1Y4TS9TcGQyQVZFWXov?= =?utf-8?B?VnB6Nk1LSnJqK0IvR0REWmdlZjJBRFVhd2NSd2NKMzBna3hUbVNYN1ZweFdO?= =?utf-8?B?R0RrbVJhdFhqNk1iOTl0bXdJMW5ZMlY4MkVucHJKYjFRM1BISnNBRC96bVRR?= =?utf-8?B?eER6UlJ3SmZqQnhnZlpzU3JLelRnY0pSUS8zeE1NbXo2VVVjOGFTRzMxL294?= =?utf-8?B?b283SHgwNkFxaTl5cVk1M0t5Y3ZTQUI5aUViT1ZzMGdYcGlMRjlLY0w3VHh1?= =?utf-8?B?VDhtSXQ5MUtZVzU2M2l0OUlCZXFuVEhVK0NLc1ZmVVVuNTdCM0M0bVExOW5Z?= =?utf-8?B?QU9abXhKRUQ0akNPTCtUMmlOV0trTHhRUjB1QnhEYTNRVStWMkNxZWtyYXJB?= =?utf-8?Q?fk3sHAIeiJQ1/y45XStG3dPhY3Kk/XfKW5bFIVd?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5b64e94b-2993-4fbf-0a5b-08d8e2355df5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 13:23:31.1564 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B/nuhCr8cLOl98DW5+/ZgDFypAM3E0pgL4SHyZ9gWay7fV9CLEqK50CWkJbK9+baKAay2+EEHqq5BRedv1URzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2971 X-OriginatorOrg: citrix.com On Mon, Mar 08, 2021 at 12:41:26PM +0000, Andrew Cooper wrote: > On 05/03/2021 09:50, Jan Beulich wrote: > > Linux has been warning ("firmware bug") about this bit being clear for a > > long time. While writable in older hardware it has been readonly on more > > than just most recent hardware. For simplicitly report it always set (if > > anything we may want to log the issue ourselves if it turns out to be > > clear on older hardware). > > > > Signed-off-by: Jan Beulich > > I realise Linux is complaining, but simply setting the bit isn't a fix. > > This needs corresponding updates in the ACPI tables, as well as Pstate > MSRs, or Linux will derive a false relationship between the TSC rate and > wallclock. Is there any description of those relations? I don't seem to find any other MSR referencing the TscFreqSel bit in HWCR on the AMD Open-Source Register Reference, but I might be looking at the wrong place. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 13:24:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 13:24:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94932.178935 (Exim 4.92) (envelope-from ) id 1lJFsR-0003ps-1L; Mon, 08 Mar 2021 13:24:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94932.178935; Mon, 08 Mar 2021 13:24:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFsQ-0003pl-Sa; Mon, 08 Mar 2021 13:24:50 +0000 Received: by outflank-mailman (input) for mailman id 94932; Mon, 08 Mar 2021 13:24:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJFsQ-0003pg-Ba for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 13:24:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8b4efad2-a0e9-48d9-998f-7444ebc1648b; Mon, 08 Mar 2021 13:24:49 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 957A1AD73; Mon, 8 Mar 2021 13:24:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b4efad2-a0e9-48d9-998f-7444ebc1648b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615209888; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9p5xIm5R9zqwqOHfpVsXywQIbZY9ZXyY+OGp2hOFeXI=; b=C+HTwTIGr9rBR8jAFSHZlA1acpcdxJ679Ko+jJgYbWmtw3c/RpSpDZyD5DAGaYcr8c87EK cS4rMn/0/dAQ/4yPwXrhPBGj40wKU17YKi5ohALiGqaNIdeVHiwngerwCUIdhMOkqyroic cRxrHl5cNAtsIDsxLgP4eEJGKXT4gfQ= Subject: Re: [PATCH v2 2/2][4.15] x86/AMD: expose HWCR.TscFreqSel to guests To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson , "xen-devel@lists.xenproject.org" References: From: Jan Beulich Message-ID: Date: Mon, 8 Mar 2021 14:24:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 13:41, Andrew Cooper wrote: > On 05/03/2021 09:50, Jan Beulich wrote: >> Linux has been warning ("firmware bug") about this bit being clear for a >> long time. While writable in older hardware it has been readonly on more >> than just most recent hardware. For simplicitly report it always set (if >> anything we may want to log the issue ourselves if it turns out to be >> clear on older hardware). >> >> Signed-off-by: Jan Beulich > > I realise Linux is complaining, but simply setting the bit isn't a fix. > > This needs corresponding updates in the ACPI tables, as well as Pstate > MSRs, or Linux will derive a false relationship between the TSC rate and > wallclock. I guess I don't follow: AMD's doc is very clear: BIOSes ought to set the bit. It not being set is more likely a mistake than an indication of other pieces (MSRs, ACPI tables) reflecting this unintended state. Plus isn't what you say true also if Linux sees the bit wrongly clear (which would be the case prior to this patch)? Are you suggesting we should revert behavior here all the way to letting the hardware bit shine through again (for Dom0; for DomU neither other MSRs nor ACPI tables are possibly aware of this bit's state)? Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 13:42:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 13:42:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94935.178947 (Exim 4.92) (envelope-from ) id 1lJG9D-0005mX-DK; Mon, 08 Mar 2021 13:42:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94935.178947; Mon, 08 Mar 2021 13:42:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJG9D-0005mQ-AC; Mon, 08 Mar 2021 13:42:11 +0000 Received: by outflank-mailman (input) for mailman id 94935; Mon, 08 Mar 2021 13:42:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJG9B-0005mL-Ka for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 13:42:09 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 667e26b1-43c4-4106-b3fd-11232c297cfc; Mon, 08 Mar 2021 13:42:08 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B7CF3AC54; Mon, 8 Mar 2021 13:42:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 667e26b1-43c4-4106-b3fd-11232c297cfc X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615210927; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eZ+3Up9dP59m+YGq0dxEE1fIDfgvYYRyhCRZ/TjJyYU=; b=kmV7bTHr/0Qw4gbYzaUCDdPYSUWHml5tNGwvPxps2bHa4V99la8TRZJiiCitXqNkG2vWfi okjhfbDgOARilZw5JSMRmndBKK791xyP3Jy/6I4xpV0wsE5h5xH0P/yVY32k04dInrE+YK Q+aOcPDUkmsHoEmDe7WG0m4x7myQRZ0= Subject: Re: [PATCH v2 2/2][4.15] x86/AMD: expose HWCR.TscFreqSel to guests To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson References: From: Jan Beulich Message-ID: <2cabeb6b-bbec-4cca-d872-66c2d8ae6c3a@suse.com> Date: Mon, 8 Mar 2021 14:42:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 08.03.2021 13:29, Roger Pau Monné wrote: > On Mon, Mar 08, 2021 at 12:47:44PM +0100, Jan Beulich wrote: >> On 08.03.2021 12:37, Roger Pau Monné wrote: >>> On Fri, Mar 05, 2021 at 10:50:54AM +0100, Jan Beulich wrote: >>>> --- a/xen/arch/x86/msr.c >>>> +++ b/xen/arch/x86/msr.c >>>> @@ -315,6 +315,12 @@ int guest_rdmsr(struct vcpu *v, uint32_t >>>> *val = msrs->tsc_aux; >>>> break; >>>> >>>> + case MSR_K8_HWCR: >>>> + if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) >>>> + goto gp_fault; >>>> + *val = K8_HWCR_TSC_FREQ_SEL; >>> >>> I've been only able to find information about this MSR up to family >>> 10h, but I think in theory Xen might also run on family 0Fh, do you >>> know if the MSR is present there, and the bit has the same meaning? >> >> From its name (and its K7 alternative name) it's clear the register >> had been there at that point. And indeed the bit has a different >> meaning there (its the bottom bit of a 6-bit START_FID field if the >> BKDG I'm looking at can be trusted. > > OK, I cannot seem to find the BKDG for family 0Fh. The oldest BKDG I > can find is for Family 10h [0]. > >> Since I don't think it matters >> much whether we expose a value of 0x00 or a value of 0x01 there, >> and since we likely don't want to make #GP raising dependent upon >> family when we don't _really_ need to, I would want to propose that >> the value used is good enough uniformly. > > I would be fine with setting it to 0 if Fam < 10h if you think that's > acceptable. I think the chances of someone running Xen >= 4.15 on such > old hardware are quite dim. Would you mind explaining how returning 0 in this case would be better? No hard-coded value will ever be guaranteed to reflect the truth. See my reply to Andrew - if anything we'd need to let the hardware field shine through, and in _that_ case I of course I agree that we then should treat Fam0F specially. I will admit though that as per the BKDG I'm looking at only even values are defined for the field. Reporting 1 here therefore may do good (keep OSes from trying to use any of this P-state stuff) or bad (confuse OSes). Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 13:45:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 13:45:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94940.178958 (Exim 4.92) (envelope-from ) id 1lJGC1-0005v9-Vz; Mon, 08 Mar 2021 13:45:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94940.178958; Mon, 08 Mar 2021 13:45:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGC1-0005v2-T4; Mon, 08 Mar 2021 13:45:05 +0000 Received: by outflank-mailman (input) for mailman id 94940; Mon, 08 Mar 2021 13:45:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGC0-0005ux-Pd for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 13:45:04 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id c634aa56-bfa3-41d3-89d9-45eb129a220e; Mon, 08 Mar 2021 13:45:03 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D0A4E31B; Mon, 8 Mar 2021 05:45:02 -0800 (PST) Received: from [10.57.16.174] (unknown [10.57.16.174]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E401B3F71B; Mon, 8 Mar 2021 05:45:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c634aa56-bfa3-41d3-89d9-45eb129a220e Subject: Re: [PATCH] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, wei.chen@arm.com, xen-devel@lists.xenproject.org References: <20210308095233.13329-1-michal.orzel@arm.com> <3709714b-6627-3c66-b8ca-4cb9c59df83b@suse.com> <15564cc3-db36-e7c3-df8d-64f6f54b4f3d@arm.com> From: Michal Orzel Message-ID: <5d304c0a-56bf-1c7d-065f-12473a36ae4b@arm.com> Date: Mon, 8 Mar 2021 14:44:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 14:13, Jan Beulich wrote: > On 08.03.2021 14:11, Michal Orzel wrote: >> >> >> On 08.03.2021 12:28, Jan Beulich wrote: >>> On 08.03.2021 12:02, Michal Orzel wrote: >>>> On 08.03.2021 11:00, Jan Beulich wrote: >>>>> On 08.03.2021 10:52, Michal Orzel wrote: >>>>>> +config DTB_FILE >>>>>> + string "Absolute path to device tree blob" >>>>>> + default "" >>>>>> + depends on LINK_DTB >>>>>> + ---help--- >>>>>> + When using a bootloader that has no device tree support or when there >>>>>> + is no bootloader at all, use this option to specify the absolute path >>>>>> + to a device tree that will be linked directly inside Xen binary. >>>>> >>>>> How is selecting LINK_DTB but leaving DTB_FILE at an empty string >>>>> different from not having a LINK_DTB setting at all? >>>>> >>>> LINK_DTB acts as a switch to allow setting the dtb path. Not having LINK_DTB option will result in >>>> a build failure each time the user does not want to embed dtb into Xen(DTB_FILE is empty). >>> >>> Which isn't any different from having LINK_DTB and leaving the >>> string empty, is it? I.e. imo no improved user experience. >>> >>>> I do not see why someone would want to select LINK_DTB leaving DTB_FILE as an empty string. >>> >>> People may not "want" to, but simply think accepting the default >>> is fine, considering they've already said to link in some DTB. >>> It may be obvious to you that there's no good default here, but >>> it may not be to the person configuring their Xen. I'm guessing >>> here, but did you try leaving out the default line? Would this >>> make kconfig insist on the person to type in something? (Likely >>> an empty string would still be accepted. As would be a relative >>> path, despite what the help text says; I guess some forms of >>> relative paths may even work.) >>> >> There is no option here to make kconfig insist on person to type something. >> There is one solution. If I change in here: >> https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/Makefile;h=16e6523e2cc6072b7d4cbcdeaf4726b7a9b1d381;hb=HEAD#l71 >> from: >> ifdef CONFIG_DTB_FILE >> to: >> ifneq ($(CONFIG_DTB_FILE),"") >> then if user selects LINK_DTB but does not provide dtb path, the dtb will not be embedded into Xen. > > I think this would be preferable plus eliminate the need for the > separate LINK_DTB option. > Will do this and send as v2 > Jan > Michal From xen-devel-bounces@lists.xenproject.org Mon Mar 08 13:48:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 13:48:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94944.178971 (Exim 4.92) (envelope-from ) id 1lJGFS-00068m-GL; Mon, 08 Mar 2021 13:48:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94944.178971; Mon, 08 Mar 2021 13:48:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGFS-00068f-Cr; Mon, 08 Mar 2021 13:48:38 +0000 Received: by outflank-mailman (input) for mailman id 94944; Mon, 08 Mar 2021 13:48:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGFQ-00068a-9g for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 13:48:36 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7a90b8f6-cda9-4974-bbf6-1edc811a79f0; Mon, 08 Mar 2021 13:48:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a90b8f6-cda9-4974-bbf6-1edc811a79f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615211315; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=zTS8y9jsijYxARDDmBbM4t3EhgQDoxzfdy1ac/DDICY=; b=I/nbwj6DaK1wd7h/0PHd6leib3qxVoG5vK5kvh15biR5NsEU+FDu5pHI HDNb+l2jJJBqqUWzw37WLrc/N1VzZo5iunSKld/ll+0Ug2C3VVE244KUX 1fXH34q6gt1aQ1ku8f6x7FYR2lLu96pkzG4XvEGsVlUKgwsJBzhNFulpq k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: TCmCvPwbJWwufcMFe2Ew7H7HIa8SoYEWV1r3S2v/Et3OdRbtTXqJfS8a4X2N0WYVBnCkXXr0Yl NP/8Pq5vbUwCU1iSd5oKSa2WGcuNd3251aSvddxkiFO6CSh74pXBq8ve/EH468LHN7JIZFHuwk KHiyEwWExVYrkLIGzkTYPvrsvsNV9awCNxc/pVS9/Wuvn7uMWzv3ADXUJ7BXzXLH+E7A0HZyoO EwO11eW4XTzB8oiFL/warfp2MF3LMwS5Br73slmm4Q4LD4g6k0URqGCTE6b3ZJ1hABZDIQBue7 7Og= X-SBRS: 5.2 X-MesageID: 38783487 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,232,1610427600"; d="scan'208";a="38783487" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H+aUe0IZ3fnp7BhRy2u5mqUVynnrwHW5M3NIDqJq229GIuK6qXo4AQ2EJYn+aawRZgZWngMtubFqWY2S5WPjWSqAju4SI+oXE20yeSk7BHWwZqBSIVJAOezm+nRvrUB552fjqWLYhox2Tw0MFd1/nHASMOLbCpYUDAwNYrrRu2xYwoMiaDSwklH5cHalX7oLZua+QJh6pFBHqGSV43lPWefwEDcUm54tn6XByYXi2PtCtQeTI6anlD8+XPg0tETaTWZNF7VwkOAurRSyGj4y4JFfgkv6E1qzHhx9h+qHtJHHwxQ0Gf3BmhxGNzgYnsbGtU4WbCgevuoCUxManFRBhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zTS8y9jsijYxARDDmBbM4t3EhgQDoxzfdy1ac/DDICY=; b=QYwgetabPnEXDB1lUkvSgdJQQPEmsa34hLuhu7tfY3dgxH5mSdBBqmymwH36KgVZzExtODFIrbdtoSiJbdb1qsdADMTw6eMtgPjFy6haDdlgaFGOiZmgrX+BUTZkfUt11P9RAjTaHnn2pQ0BVbrr2+ehyEldDo+zrnx9SJ92MR68aN4pXawWjWFVIFq2OXEc1xb+kUIamWkViMXKbGaAcmmXYkHhDqDIO+z1rh+NZUl5fe+X9hFSkuosKPMMbS3+3ZIe6pXrsAuhEe58BQA5s/1fsv7lkFODWIJxgDsBp7PZhCyMM8IJ9DgAVbcJUyzDP7MOjE+F7jDUqNB37VTT2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zTS8y9jsijYxARDDmBbM4t3EhgQDoxzfdy1ac/DDICY=; b=V9AE8dCBd88BGQo1ay+xOqZdmVsTKj1meXU9NJyArKsgjwPFFmQ+vZmA8HpEQgxgKgSKDLUv5cv+8qmsSRWstOAzQVsofLCEs0XFL8jCEZ+wo3KXN5LjyODrPlE+ybB/MRszRvID0hRKmxgSgyKpa+4+tkhPL8W8FpUj+c2oygQ= To: Tim Deegan , Jan Beulich CC: "xen-devel@lists.xenproject.org" , "George Dunlap" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> From: Andrew Cooper Subject: Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized Message-ID: <96c83adb-9e81-8398-c905-f4f0730ba240@citrix.com> Date: Mon, 8 Mar 2021 13:47:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0145.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 394c6b28-eb15-4437-3833-08d8e238c4e5 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5773: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZlPEA0zeEu538e/bk3X1O7ziyhAYeeJRJYXI7aEEGDZMvukODJOX95wnSJa3McFqtkW7gAwb3cXYFpeYecPWn9TDFTiN2FLCqU6x6sU9axK84Q6zQNwfqPLjgfCix75l3BfYg6QiEEClW4F9LDXs2GCcSKPsnYyZEIGjyyBOYRTOlTQbyq3y/Flxyt///Nv4/15ZoNhs5YwwPi5EBakWlVjW1XONj7g6Rf1kyuEU9bhiulXuvCfpqQ3YqYkIugcjkEivhUxb0M/0171ZxwxQYcSEtMDflbtgvtIi2ku+bvm00xGwINw0KxIYp4Zu6XwhJr4AWlgh2oeIZnJnyt9XRwb3SmInx/4wrIgKnS5HvXE1G9lZxksIU6WzpQKG3MKA8ATJOEZkppMkh1XjtWX9iaqrvSO9jTJZeL8bGtQt8OHmiJ1GrCTNwjsZaP03wfk/xiTNGSX07fpGOHsEMQH08Jneo3sX5bgAoQJm20HEfK6VzUFfrKdymXNoQ32xp6rTE6gRxi/YubfZK3iKyNY/O2NWjvp9avuhB7q6QT6BawK2ODZwCXkRrl1uQLzV4+YOXJCAQIZGRj3v+uEvueMxwqrLFItBTb2ikZpXeUeA2pA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(39860400002)(376002)(396003)(366004)(53546011)(2906002)(4326008)(16576012)(6486002)(956004)(83380400001)(6666004)(2616005)(86362001)(66556008)(8676002)(31696002)(66946007)(66476007)(186003)(26005)(16526019)(31686004)(36756003)(5660300002)(8936002)(54906003)(110136005)(478600001)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YXBpOFc1c0lQc29Id0JXWXoyZVdLTEh3NzRVekdZcjk1aXVzUXlvWWVKdnNC?= =?utf-8?B?MWMrVzcyR1VORzcybXVZWCtsTTBza3R0SVdEVzZ6aVlCdmx1U1pXVHhzazUv?= =?utf-8?B?MmhCeUNabTdtV0poY01EdVBtYkw4bktBSFVjOC9BWENVZURIYVlsVEJPK3hZ?= =?utf-8?B?RGlLZUdPL3FFYTUxRzZOd3dmTm9EU2dldUllTlFhMXpmYldHYktZWGdSZ0Q5?= =?utf-8?B?OFUySGRjaittVWJLUFo2TFZ2UkRYZkpERitnbXBSMTBPeDkxb2JlMkE1amVY?= =?utf-8?B?QmphN2lxN1FtUzRyN2Q0NHkvbVZmb1pXR012ckQ4QXozWFFIQ0QyZDVpU2p6?= =?utf-8?B?QlJxMXlSbCt1ZEhvLzhwMnFlRVh1WXlqdnJaalo5d0I3SUo5Zm1sR2kwRlRn?= =?utf-8?B?bkN6dzZaRjA1Ui9NNE9GNFdkbkRxSnNTOWZuamVoeE9hL0dCcm9VaWlUVFh0?= =?utf-8?B?RTlNcG1pNzd0NTJYY2hlcjB0TEZoZkUwZmRBeURSZFVxQ25xODJkNkY3WUtZ?= =?utf-8?B?amJBSnFnQ00vUHZjWFRzSFJwYkttSVlkSXlBWnJXUXJjQkJScUR5S2tmMFlI?= =?utf-8?B?VjZqa3ZxajYwWGl6YzhEaGdXTzFoSytZT0d4VUNidkhNM1dYUFZGRGJmZWhp?= =?utf-8?B?U04wcVlHZDVVTXI5N2M2U0dnSWJkOXlzWW5zdVAxNUNPUkV6bXVFaDUxanA5?= =?utf-8?B?dzM5MWhmR3duQTlVU0VtUHZqYXZENVE5N3FTNTVJd085c2pFa05zbGxGTnp2?= =?utf-8?B?anBFbFFmbFkyenR2NWpLcXArdHF3TGtHbFMzV1BFYnc4QTluM1kzRnVTOFlE?= =?utf-8?B?V1B3T1hzamtxYVJhbU9mMWtyUnlYbWtKdGpEREpMSWZ3OXQ1amVMK2ZCamJY?= =?utf-8?B?NVcyQlNZVkc2dE9FcytsVW5qMlgwaUtSWllLdTBLRERUQWVESlNQQUJjWUc5?= =?utf-8?B?eGxsVFVBcU1QSEQ4NloyNFM0TzNPRWlGS2ZMZUI5RUhUK1Y1Nk1DUlk1SExN?= =?utf-8?B?OUpWSG5vQzJBUFpUNDRMem9xSzdOcGNwWUQ2NFpTejNGVlNnM0dzbFhOMDB0?= =?utf-8?B?MGMvV0JNYitzM05ZZlFib1RhQ2JSUnVycU54dWQ2TVZmbXpEblFnTjVpMDd1?= =?utf-8?B?Mk55TmtYTTJyNWhDR3I5L29TN3k2ZXN1UHJQNHJ6QTVYamIvN25oRFhHT296?= =?utf-8?B?ZkZ6OGc1dGdVTGNmQ3dMVTh6TDllR0xGQ2dYU2pVV1dBelZrVHpaZTB4aEJS?= =?utf-8?B?aDk2TDhzTGdQelVWY2hMdG0xWnFySEZ5THpmUnpuMU9WYmpTdEx3dC85NjZJ?= =?utf-8?B?NmY5Y1lEZ3c5dkpObElXdThYcnd4aEdzR2dVLzVNVkNDUU1CU3BvV1FnRU82?= =?utf-8?B?WVZHNU02V21UN3NlWjlsT1dUbWdiMnVVcHkvUXgwVEk5dDJnMUVqUldsL2ZJ?= =?utf-8?B?aHoyYWkzV3hnUnVuZjdXY08zVnBFelU5Z3EvaWVJREhUdVRtMWNaNWpVbFVj?= =?utf-8?B?ZEsyTHJzcU9PckFRdHNEeStRWEpJV29ZaEwxTE4zVndYVTZUUk1MN2UxWDhM?= =?utf-8?B?dW1XanI2ckNRYnEwRjlFWkNnUFBlbXgyNDk2Z1d1U1RxV3pnN2tIYXNhdGdm?= =?utf-8?B?OUVGTUJ5ejZ0bXoycXRDUlFveTEvdmtxY0ROcEQ4amErU2QrdnJNVkwrT0tt?= =?utf-8?B?SFFybUd3ckZjL0twWmNuTGI2d0VLOTArSVA1aEMrRWNKSmVpTVdycERLSEw2?= =?utf-8?Q?c7D/zGehySLsAVcJLx7aSs/NtCIY26bPkBFl0MY?= X-MS-Exchange-CrossTenant-Network-Message-Id: 394c6b28-eb15-4437-3833-08d8e238c4e5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 13:47:52.5645 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KfGK3/KLY8ZmaYg9cBIhlCyVZjqCoH7l1U9kaUwDHalBv9NEYQpCLnFLyFf6y0WLo6VVdH5LaXmzaXzfYuccMAZd8IDMek7APs3ySPJiGCg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5773 X-OriginatorOrg: citrix.com On 08/03/2021 09:25, Tim Deegan wrote: > At 16:37 +0100 on 05 Mar (1614962224), Jan Beulich wrote: >> We can't make correctness of our own behavior dependent upon a >> hypervisor underneath us correctly telling us the true physical address >> with hardware uses. Without knowing this, we can't be certain reserved >> bit faults can actually be observed. Therefore, besides evaluating the >> number of address bits when deciding whether to use the optimization, >> also check whether we're running virtualized ourselves. >> >> Requested-by: Andrew Cooper >> Signed-off-by: Jan Beulich > Acked-by: Tim Deegan > > I would consider this to be a bug in the underlying hypervisor, but I > agree than in practice it won't be safe to rely on it being correct. I'd argue against this being a hypervisor bug.=C2=A0 If anything, it is a weakness in how x86 virtualisation works. For booting on a single host, then yes - vMAXPHYSADDR really ought to be the same as MAXPHYSADDR, and is what happens in the common case. For booting in a heterogeneous pool, the only safe value is the min of MAXPHYSADDR across the resource pool.=C2=A0 Anything higher, and the VM wil= l malfunction (get #PF[rsvd] for apparently-legal PTEs) on the smallest pool member(s). Address widths vary greatly between generations and SKUs, so blocking migrate on a MAXPHYSADDR mismatch isn't a viable option.=C2=A0 VM migration works in practice because native kernels don't tend to use reserved bit optimisations in the first place. The fault lies with Xen.=C2=A0 We're using a property of reserved bit behaviour which was always going to change eventually, and can't be levelled in common heterogeneous scenarios. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 08 13:49:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 13:49:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94946.178983 (Exim 4.92) (envelope-from ) id 1lJGGB-0006EA-QB; Mon, 08 Mar 2021 13:49:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94946.178983; Mon, 08 Mar 2021 13:49:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGGB-0006E3-N3; Mon, 08 Mar 2021 13:49:23 +0000 Received: by outflank-mailman (input) for mailman id 94946; Mon, 08 Mar 2021 13:49:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGGA-0006Dw-7v for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 13:49:22 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 11f9e7aa-71cf-4652-accf-9105bc361f9f; Mon, 08 Mar 2021 13:49:21 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 723DDAD74; Mon, 8 Mar 2021 13:49:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11f9e7aa-71cf-4652-accf-9105bc361f9f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615211360; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HihofuaBJs3E19YQarO5yvxqeJKKBAq0er0iW7zmYGY=; b=qEG/yICHwoH3h3IgrhvKeYiq+oTz0cCkKd81U3wfofEh2R7gklSZsmbGJaJsCNH5BnLVPm D95deB9SEba7BhdlwyVwGX0d9H+oxot6P5DsUyr+8sIKh19uiaTHw6XOBN0MLDf46CMOZ6 I/mY0oanMBl+UWHuoR091xk411sEFuc= Subject: Re: [PATCH v2 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson References: <1f19ced7-183b-8f08-3a90-c06039e053a6@suse.com> From: Jan Beulich Message-ID: Date: Mon, 8 Mar 2021 14:49:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 08.03.2021 13:11, Roger Pau Monné wrote: > On Mon, Mar 08, 2021 at 10:33:12AM +0100, Jan Beulich wrote: >> On 08.03.2021 09:56, Roger Pau Monné wrote: >>> On Fri, Mar 05, 2021 at 10:50:34AM +0100, Jan Beulich wrote: >>>> --- a/xen/arch/x86/pv/emul-priv-op.c >>>> +++ b/xen/arch/x86/pv/emul-priv-op.c >>>> @@ -874,7 +874,7 @@ static int read_msr(unsigned int reg, ui >>>> struct vcpu *curr = current; >>>> const struct domain *currd = curr->domain; >>>> const struct cpuid_policy *cp = currd->arch.cpuid; >>>> - bool vpmu_msr = false; >>>> + bool vpmu_msr = false, warn = false; >>>> int ret; >>>> >>>> if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) >>>> @@ -882,7 +882,7 @@ static int read_msr(unsigned int reg, ui >>>> if ( ret == X86EMUL_EXCEPTION ) >>>> x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); >>>> >>>> - return ret; >>>> + goto done; >>>> } >>>> >>>> switch ( reg ) >>>> @@ -986,7 +986,7 @@ static int read_msr(unsigned int reg, ui >>>> } >>>> /* fall through */ >>>> default: >>>> - gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); >>>> + warn = true; >>>> break; >>>> >>>> normal: >>>> @@ -995,7 +995,19 @@ static int read_msr(unsigned int reg, ui >>>> return X86EMUL_OKAY; >>>> } >>>> >>>> - return X86EMUL_UNHANDLEABLE; >>>> + done: >>> >>> Won't this handling be better placed in the 'default' switch case >>> above? >> >> No - see the "goto done" added near the top of the function. > > Yes, I'm not sure of that. If guest_rdmsr returns anything different > than X86EMUL_UNHANDLEABLE it means it has handled the MSR in some way, > and hence we shouldn't check whether the #GP handler is set or not. > > This is not the behavior of older Xen versions, so I'm unsure whether > we should introduce a policy that's even less strict than the previous > one in regard to whether a #GP is injected or not. > > I know injecting a #GP when the handler is not set is not helpful for > the guest, but we should limit the workaround to kind of restoring the > previous behavior for making buggy guests happy, not expanding it > anymore. Yet then we risk breaking guests with any subsequent addition to guest_rdmsr() which, under whatever extra conditions, wants to raise #GP. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 13:51:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 13:51:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94950.178994 (Exim 4.92) (envelope-from ) id 1lJGIP-00075Q-5q; Mon, 08 Mar 2021 13:51:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94950.178994; Mon, 08 Mar 2021 13:51:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGIP-00075J-30; Mon, 08 Mar 2021 13:51:41 +0000 Received: by outflank-mailman (input) for mailman id 94950; Mon, 08 Mar 2021 13:51:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGIO-00075D-Aw for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 13:51:40 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b8224911-50a4-406e-a660-17f4107c9482; Mon, 08 Mar 2021 13:51:39 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 41991AD3B; Mon, 8 Mar 2021 13:51:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8224911-50a4-406e-a660-17f4107c9482 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615211498; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l5ozFChNT594+olRPzXUE+TKs/4K7Uq1KwTrdShzVdU=; b=mvQHhMjY5cak8g9RaDJ8bAFZ/ponrsu/xAZVfUdwmFGkp1IKg/9md8a156EukqMdasjbsK ai5l/BbXigJeiDt4tu4OjAyS5ZoRySKocqJYqlWfZ0LgJobKFx33wQctsWK3hU8MaoRk/i 8HftLFmvPitn69XbebHbr6zsnnYqQW8= Subject: Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized To: Andrew Cooper , Tim Deegan Cc: "xen-devel@lists.xenproject.org" , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> <96c83adb-9e81-8398-c905-f4f0730ba240@citrix.com> From: Jan Beulich Message-ID: Date: Mon, 8 Mar 2021 14:51:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <96c83adb-9e81-8398-c905-f4f0730ba240@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 08.03.2021 14:47, Andrew Cooper wrote: > On 08/03/2021 09:25, Tim Deegan wrote: >> At 16:37 +0100 on 05 Mar (1614962224), Jan Beulich wrote: >>> We can't make correctness of our own behavior dependent upon a >>> hypervisor underneath us correctly telling us the true physical address >>> with hardware uses. Without knowing this, we can't be certain reserved >>> bit faults can actually be observed. Therefore, besides evaluating the >>> number of address bits when deciding whether to use the optimization, >>> also check whether we're running virtualized ourselves. >>> >>> Requested-by: Andrew Cooper >>> Signed-off-by: Jan Beulich >> Acked-by: Tim Deegan >> >> I would consider this to be a bug in the underlying hypervisor, but I >> agree than in practice it won't be safe to rely on it being correct. > > I'd argue against this being a hypervisor bug.  If anything, it is a > weakness in how x86 virtualisation works. > > For booting on a single host, then yes - vMAXPHYSADDR really ought to be > the same as MAXPHYSADDR, and is what happens in the common case. > > For booting in a heterogeneous pool, the only safe value is the min of > MAXPHYSADDR across the resource pool.  Anything higher, and the VM will > malfunction (get #PF[rsvd] for apparently-legal PTEs) on the smallest > pool member(s). Except that min isn't safe either - the guest may then expect reserved bit faults where none surface. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 13:59:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 13:59:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94956.179012 (Exim 4.92) (envelope-from ) id 1lJGQL-0007Lw-3Y; Mon, 08 Mar 2021 13:59:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94956.179012; Mon, 08 Mar 2021 13:59:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGQL-0007Lp-0n; Mon, 08 Mar 2021 13:59:53 +0000 Received: by outflank-mailman (input) for mailman id 94956; Mon, 08 Mar 2021 13:59:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGQJ-0007Lk-FW for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 13:59:51 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 020ac16d-6d52-4705-8f07-7b6e38ae5686; Mon, 08 Mar 2021 13:59:50 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F40F231B; Mon, 8 Mar 2021 05:59:49 -0800 (PST) Received: from e123311-lin.arm.com (unknown [10.57.16.174]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4D2563F73C; Mon, 8 Mar 2021 05:59:47 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 020ac16d-6d52-4705-8f07-7b6e38ae5686 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com Subject: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE Date: Mon, 8 Mar 2021 14:59:37 +0100 Message-Id: <20210308135937.1692-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently in order to link existing DTB into Xen image we need to either specify option CONFIG_DTB_FILE on the command line or manually add it into .config. Add Kconfig entry: CONFIG_DTB_FILE to be able to provide the path to DTB we want to embed into Xen image. If no path provided - the dtb will not be embedded. Signed-off-by: Michal Orzel --- xen/arch/arm/Makefile | 4 +--- xen/common/Kconfig | 8 ++++++++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 16e6523e2c..0f3e99d075 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o #obj-bin-y += ....o -ifdef CONFIG_DTB_FILE +ifneq ($(CONFIG_DTB_FILE),"") obj-y += dtb.o AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" endif @@ -137,8 +137,6 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c xen.lds: xen.lds.S $(CPP) -P $(a_flags) -MQ $@ -o $@ $< -dtb.o: $(CONFIG_DTB_FILE) - .PHONY: clean clean:: rm -f asm-offsets.s xen.lds diff --git a/xen/common/Kconfig b/xen/common/Kconfig index eb953d171e..a4c8d09edf 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -400,6 +400,14 @@ config DOM0_MEM Leave empty if you are not sure what to specify. +config DTB_FILE + string "Absolute path to device tree blob" + depends on ARM + ---help--- + When using a bootloader that has no device tree support or when there + is no bootloader at all, use this option to specify the absolute path + to a device tree that will be linked directly inside Xen binary. + config TRACEBUFFER bool "Enable tracing infrastructure" if EXPERT default y -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 14:00:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 14:00:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94957.179025 (Exim 4.92) (envelope-from ) id 1lJGQe-0008BX-CD; Mon, 08 Mar 2021 14:00:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94957.179025; Mon, 08 Mar 2021 14:00:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGQe-0008BQ-9A; Mon, 08 Mar 2021 14:00:12 +0000 Received: by outflank-mailman (input) for mailman id 94957; Mon, 08 Mar 2021 14:00:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGQc-0008B5-IV for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 14:00:10 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id be1b9675-9e37-4f55-8139-3c109f35872b; Mon, 08 Mar 2021 14:00:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be1b9675-9e37-4f55-8139-3c109f35872b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615212009; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=2QFGUf0NpAEB3q315oWeky3tTb0uY9yxwUgU4ec7utY=; b=cXqPwpGC9Zg6GqiuT7MQdV7Axn5jiK81d4mmHju9acYSYpeAyBH0ZZSD CZqDhkSdVV/letJv7xoFfahZNDra72yE8uyQ7qFr0NyhNqSoHVeEM6/tA fYtyns6Pz+IEo2wcY1qZJ5GfLKqfut3syh0H0s2Mhkuy4K8p4VzpbzQci Y=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: v1rgk1PRTuGbetZpADjWPOsR3NiEVkDPUiMbeLw9jOEY/oNCtQ57jV/iJzUvOGHjt5Vn9bBT/F CDpHZCTaAytcki2wdNY1DOuxqJg39F4GhsY0l5cYz6I9OMtW7vHB8/pMcxKFNnicwfexHwMluN GGHRV680Dubto8WrvvTiOn3P4FS37UrIA8Z55pI83J82axNFawDcpOOYKQDIx18JSI6Cb90aQ7 HPgCigU7FXffgF2zx78901XWHERwXnywrH+U47EBL8In2J16YNsZ+R+TVjHHC9lr0F2lrNZc9a 44s= X-SBRS: 5.2 X-MesageID: 38682582 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,232,1610427600"; d="scan'208";a="38682582" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dDKxjfpjwMoKs29JOOatnt9Kvzgb5NX4tyT0kaOzhOrpoIwWOHXMb91aNjPGgjvLkuXwnFxNNnh5/rcWTDVhWvjMk7votHyGre6O2dwIO02nXdbe42K40Vu79/3acrhGW+aO7YD6tBA5mzknGCpU7JCwtyVxBWdZL0TBmCbcjkz7qId4nogLK51mjydhPRg4p+Dfa4l0IzxcWjQWtxeNncYkvmdEsD2lxeL2YJ3F9MOTyiIb47WhWihX9LGNz65lnTxsxrAA6L0mx/FuFbnnyhLdDRsvfkoTrKN17FWRMtyGJZAOJnwKCfKw5g7cY+wi2zUMkQlBtoAyv8I7SO3Nvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2QFGUf0NpAEB3q315oWeky3tTb0uY9yxwUgU4ec7utY=; b=KGuyGsQICWM7NoTf5T7RIrGbG685IphSwc2VxEQfml/HY73brTEuhuxN7tXZcGU+LtDGCZnkRXZL8hpzFK2/CmMAVrVkEod9a//nU9haSFW9JwyvjHYYCKo6DPEQZ9JPYzMBcIxSLxDbG2ilP2cQEwTYFXPZgOvqVUWDphFuHaN+mMTWoRGBrKgKJouIO3w307HdXtN+ner0WOPUY8ax8tLN8utNddbFRiWlQal7QTQle5DdnE0MPipoJ+uO4ejsYJgXC8MttkfWJAMtKuRcGAX6IWlKMZ86TsSHVVNfyk4NQKWtiAVKvnESGgSG+0SFiv4Rvepk1EiQx5DPoubeOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2QFGUf0NpAEB3q315oWeky3tTb0uY9yxwUgU4ec7utY=; b=NIRFm4DVbZT2PnGAp0Yk1/BL7/2O2oVn2KVO2hgbInlO0rK2uzxwPt8apmBMvpVB+HuU6auAxdyziKjQQEsuZrma/pyBQm68u0EoFMMLWhT0Mb9ALvXUlSsFF1YghS4T8uid4+5LFzp3w6FRuL4qA5UBmenIDwKreCNxPvp1dPg= To: Jan Beulich , Tim Deegan CC: "xen-devel@lists.xenproject.org" , "George Dunlap" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> <96c83adb-9e81-8398-c905-f4f0730ba240@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized Message-ID: <8fd91411-ecb7-c0ec-000a-b1937c98f57e@citrix.com> Date: Mon, 8 Mar 2021 13:59:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0474.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b74d4776-7338-4e3a-f5e0-08d8e23a7532 X-MS-TrafficTypeDiagnostic: BY5PR03MB5079: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vxiSfHAZBCOvyjnSa22NkXwoK0CI9VDlvxhwsl52PQe+IoxuslE9RIKvv5czSA1Y7oNy++Ap0PTIeorcwVgitJlnuoUxI00lXjIwPq7hAF002CbEeFlYM5xYmQP8Vz2wWe5bcot05h+OczitEYEXGDi9u1G7PB89NvLmwE2sLh+pqxHPbP/tpKg+nswnGm1tmSHZrcvWnwSsnl2Xbge4yYdzSyamIerv0EqWX9fuBb/Ke7HO458Mc1gV0QDs7TKKEmj1R96oC/HVc6e/dpQeDQSpV48rHbVkueJxWpA1LzS4fIJgpYchQzXxgA3I8jLZELM1oYwcMLZ+KBYN7tLuVylJ8916RtFDhmTV6DnGGDU8GSmT2LmQ2ht6l+Uk7HXqntCq9oYVynckCJ+HrWO2h9/FCqq4l9y+WkmtkavhH2af+RvqbDmLNSQ/UMP50PmYwhPBoK/IA1drdfZnZkCQrb+lLk5w7xKbOp7WIgzuK+iUq5hGrq93SOoBn+OEOWCer/tt8fi3b0ZXFZbVvBOg0dHDaQvUZEZBcR4inNkTKr6DPD/uz4KP/jFeJRBtC0/vnIom41wNgvT/VLBJ/Jyjub5DgdSY3H1UYYLbYpsXrAY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(366004)(136003)(39860400002)(376002)(2616005)(16576012)(54906003)(110136005)(66946007)(83380400001)(86362001)(66556008)(6666004)(8676002)(31696002)(36756003)(6486002)(66476007)(26005)(31686004)(8936002)(4326008)(316002)(53546011)(478600001)(956004)(186003)(16526019)(2906002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?V3A2cDJjS2poL3NTVzFpcnp1Z0trUldaeUtTa3pkSTFlSmdkanN2WG9lRDEv?= =?utf-8?B?bUJ3UFhGZVd2K0RITU95R0ZsS2kxVkR5VjIrcmhndDkzdXdGcG12S0daNjJk?= =?utf-8?B?WUNIQ0ZDNXIyb09RN3kwdjlWbjlFa1hERkVSYjVaNFFEQjJKUHBtNzFZcnVD?= =?utf-8?B?cmM0M2tnSjBTb0VoVnZCU0lXYVBkb2pHRVRRRUhDR2J1bWhmK05LVTVPUDhm?= =?utf-8?B?d28xNkRWWUpLNnQ0OUQ0bkVDTUt2RUZXbUYzb1l0bys4OHdNNEd4aWk1d3RT?= =?utf-8?B?R3V1dnlJWXhlNnFUR054ODBBYlV5R2xVZ05EaU1RTlBEblY5VEQ4MHoyYldi?= =?utf-8?B?MTdZV3lkeWxMOStic3dNbjkvay9aWGhvdEJiQTVIdjRmaXIzZDJQOEhmT0tQ?= =?utf-8?B?N2VCVXNteVBZeWEvbnlMS1RvUmdHc3dJRUxiWnVNdnNiRjlwQ3NtZS8xTUUx?= =?utf-8?B?VVFneGVDTzdqVHNqVGVkSXFHWU9lVGd2SXR1cjBoZ3BjVUExcE9yQ3phZ1ZL?= =?utf-8?B?YnJicFNJR2hBWENnTzJoM0pLYVU4OVlyeGc4eGdJcnRUZXIxdGZ1dWY2K294?= =?utf-8?B?dnorN1dLME1VckdXWmJTdjBydlNSSmoxdWM3cnBXRG5xMzZUTlllRmYwck1J?= =?utf-8?B?MFI2TGc3WXBJNXVrQVJxMVBWM29Uem5lMjI1eGs0YzJJRWNOR0VrWm52aEt3?= =?utf-8?B?dlVBc21lUVVxempaRzZoaVJSZ00vd2prVGZ4RXBQTG0ya2psV2k2bm1nbE9M?= =?utf-8?B?SnhDTzFLdjAxVUIvWHd4VVZuSkREVW5vR29maVlDYkhqb3d3Nk5RcjIwaUtj?= =?utf-8?B?RTR6M3FUZzBzK1Jvd085NEs4cE4rRzVqKzh5bE5tTVVxRXVuMEg2ZUZyZmlI?= =?utf-8?B?MFpwaGN3ZmNPbmNkR21RYUVreWk5Mzk0U1Z5UTVRNHZ4V1gwQVE5LzFnMThI?= =?utf-8?B?R1Z2Qk5UQlYybHY2b1FYbDVFZ05md0owcjRDbkVsVzkrM0F3VUVOMDN6eE1T?= =?utf-8?B?dGZDdGpXc2YvSUthRzFJamVQS2JjbE9YQWg4alRCZmZhUUc4Ry9qNG1GTksr?= =?utf-8?B?T0lVcWcwSDNNNlhyRzVGWE50MzdvVmZ6RC9IVkxzOXlTRXdkQ1hCQkExWEdH?= =?utf-8?B?c0NmcU1yQkZXUUlxT0NoaTZLbnNlbHNLWk4rMFF0YmdBbDFsVlo2Wk5MZjFY?= =?utf-8?B?QUdLdjBrY1FVdUlNZm1ybytpbzNXQmV2L2hpeDkyRDI3MTJOb1BodzVOTGJS?= =?utf-8?B?T0lNb2lGWWVJRjZEZzJOT3lkYXhsaUJ3OFhvRVBqS0E4RCtDL2lzUGppY29h?= =?utf-8?B?Zld5YzBxZ25ZZ1NKY3pTa253aEtjYnBLN1dOeG51bExZOXlJRkJtampJVjI5?= =?utf-8?B?ZXNYTDRLZW5vQTl6dVpycm9nTU1YNW0zZVE4WDlYUnFMK09qS1V3VGYzdUs0?= =?utf-8?B?bFlhOU4xUTRmM3lPRzJVZzIrT3M3bCt5VmM5cC9JMUc3czN5K0o5VnllYi9K?= =?utf-8?B?SXRPZnh6SWFicTUrT1FnQTJtM240UzlBbm0veWdQcFNRdUl4am0rbzZIUmJN?= =?utf-8?B?Y3FtZVBFZjJ0b1RCeXBEWTBGRkdHVkFRQWd2TDRab2RwRkFHQyt0WStWd1J4?= =?utf-8?B?Nm5mNWZCOWJ3VlFnK3JwaDNKSlY3UHU2cThoT21yNCt0b3Exekpza2hXLzBy?= =?utf-8?B?TEFnYUdKR0JreGRlU0xXcmlBWW5Nc2hOTnJVbUY5T2ZISmNKdERVd2lxTWdT?= =?utf-8?Q?TwKmcQi4tQGHwLrD3kNRdJLvYKf6ch3rtLh1LcZ?= X-MS-Exchange-CrossTenant-Network-Message-Id: b74d4776-7338-4e3a-f5e0-08d8e23a7532 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 13:59:57.6498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hbfg+0+olqUMaTeV4xW/TZtuw7jQxF9RVB/IY/cUMvikY9aqfIwuLvouEOMAShxG5J6kYltTR4PMdqGs0V95EXqGhQxSMrDFdoHaU3J7ajA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5079 X-OriginatorOrg: citrix.com On 08/03/2021 13:51, Jan Beulich wrote: > On 08.03.2021 14:47, Andrew Cooper wrote: >> On 08/03/2021 09:25, Tim Deegan wrote: >>> At 16:37 +0100 on 05 Mar (1614962224), Jan Beulich wrote: >>>> We can't make correctness of our own behavior dependent upon a >>>> hypervisor underneath us correctly telling us the true physical addres= s >>>> with hardware uses. Without knowing this, we can't be certain reserved >>>> bit faults can actually be observed. Therefore, besides evaluating the >>>> number of address bits when deciding whether to use the optimization, >>>> also check whether we're running virtualized ourselves. >>>> >>>> Requested-by: Andrew Cooper >>>> Signed-off-by: Jan Beulich >>> Acked-by: Tim Deegan >>> >>> I would consider this to be a bug in the underlying hypervisor, but I >>> agree than in practice it won't be safe to rely on it being correct. >> I'd argue against this being a hypervisor bug.=C2=A0 If anything, it is = a >> weakness in how x86 virtualisation works. >> >> For booting on a single host, then yes - vMAXPHYSADDR really ought to be >> the same as MAXPHYSADDR, and is what happens in the common case. >> >> For booting in a heterogeneous pool, the only safe value is the min of >> MAXPHYSADDR across the resource pool.=C2=A0 Anything higher, and the VM = will >> malfunction (get #PF[rsvd] for apparently-legal PTEs) on the smallest >> pool member(s). > Except that min isn't safe either - the guest may then expect reserved > bit faults where none surface. Such a guest is buggy, and in clear violation of the rules set out in the architecture.=C2=A0 All reserved behaviour is subject to change in the future. Any software (Xen included) deliberately choosing to depend on the specifics of reserved behaviour, get to keep all resulting pieces. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 08 14:12:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 14:12:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94964.179036 (Exim 4.92) (envelope-from ) id 1lJGcj-0000qc-Lk; Mon, 08 Mar 2021 14:12:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94964.179036; Mon, 08 Mar 2021 14:12:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGcj-0000qV-Io; Mon, 08 Mar 2021 14:12:41 +0000 Received: by outflank-mailman (input) for mailman id 94964; Mon, 08 Mar 2021 14:12:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGci-0000qQ-Rz for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 14:12:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGch-0005kP-P0; Mon, 08 Mar 2021 14:12:39 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJGch-0005tD-CW; Mon, 08 Mar 2021 14:12:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Vx1g6QNUtDJ9YsyQJ1DdnYdb/4TlAu9VHbLiBVF/bzk=; b=nIavXu/ynJduC1vwfhCHrHNqbS 8sbuQ8RtItHRYFn8ua+MCkmSpO/6sl75oQ69ctVt5C7zNBCTXw7wWkR8RRtQwPz0S5zPoDgypAt0z hCI6EhCBdlhOUmMvjO5/zRUzNO9Lk+wNLyk8ut3ZiA4HcL5vrbSCt6z2hdTrQ07uiv9Q=; Subject: Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk References: <20210308115610.48203-1-luca.fancellu@arm.com> From: Julien Grall Message-ID: <1921ff88-7637-6454-74a7-1cbab8dafc61@xen.org> Date: Mon, 8 Mar 2021 14:12:37 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210308115610.48203-1-luca.fancellu@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Luca, On 08/03/2021 11:56, Luca Fancellu wrote: > This patch prevents the dom0 to be loaded skipping its > building and going forward to build domUs when the dom0 > kernel is not found and at least one domU is present. As you are skipping dom0, the domid 0 will not be usable for another domain. I can see a few issues: 1) The first domU created will now be considered as the hardware domain (see domain_create()). 2) There are still a few hardcoded use of d->domain_id == 0 in the codebase (I could spot at least on in the RTDS code). 3) Not all the code seems to be able to cope with hardware_domain is NULL (although most of it looks to be only reachable by x86)? 4) is_hardware_domain() will return true when passing NULL. It is not clear whether one may pass NULL here. For 2), ideally this needs to be fixed. But we may also want to reserve domid 0 just for sanity. For 3) and 4), you will need to go through the code and check the usage. > > Signed-off-by: Luca Fancellu > --- > xen/arch/arm/setup.c | 83 +++++++++++++++++++++++++++++++------------- > 1 file changed, 59 insertions(+), 24 deletions(-) > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 2532ec9739..6d169ff6ce 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -794,6 +794,35 @@ static void __init setup_mm(void) > } > #endif > > +static bool __init is_dom0less_mode(void) > +{ > + struct bootmodules *mods = &bootinfo.modules; > + struct bootmodule *mod; > + unsigned int i; > + bool dom0found = false; > + bool domUfound = false; > + > + /* Look into the bootmodules */ > + for ( i = 0 ; i < mods->nr_mods ; i++ ) > + { > + mod = &mods->module[i]; > + /* Find if dom0 and domU kernels are present */ > + if ( mod->kind == BOOTMOD_KERNEL ) > + { > + if ( mod->domU == false ) > + dom0found = true; > + else > + domUfound = true; > + } > + } > + > + /* > + * If there is no dom0 kernel but at least one domU, then we are in > + * dom0less mode > + */ > + return ( !dom0found && domUfound ); > +} Should the documentation be updated to reflect this change? > + > size_t __read_mostly dcache_line_bytes; > > /* C entry point for boot CPU */ > @@ -804,7 +833,7 @@ void __init start_xen(unsigned long boot_phys_offset, > int cpus, i; > const char *cmdline; > struct bootmodule *xen_bootmodule; > - struct domain *dom0; > + struct domain *dom0 = NULL; > struct xen_domctl_createdomain dom0_cfg = { > .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, > .max_evtchn_port = -1, > @@ -964,28 +993,33 @@ void __init start_xen(unsigned long boot_phys_offset, > apply_alternatives_all(); > enable_errata_workarounds(); > > - /* Create initial domain 0. */ > - /* The vGIC for DOM0 is exactly emulating the hardware GIC */ > - dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; > - /* > - * Xen vGIC supports a maximum of 992 interrupt lines. > - * 32 are substracted to cover local IRQs. > - */ > - dom0_cfg.arch.nr_spis = min(gic_number_lines(), (unsigned int) 992) - 32; > - if ( gic_number_lines() > 992 ) > - printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); > - dom0_cfg.arch.tee_type = tee_get_type(); > - dom0_cfg.max_vcpus = dom0_max_vcpus(); > - > - if ( iommu_enabled ) > - dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; > - > - dom0 = domain_create(0, &dom0_cfg, true); > - if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) > - panic("Error creating domain 0\n"); > - > - if ( construct_dom0(dom0) != 0) > - panic("Could not set up DOM0 guest OS\n"); > + if ( !is_dom0less_mode() ) > + { > + /* Create initial domain 0. */ > + /* The vGIC for DOM0 is exactly emulating the hardware GIC */ > + dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; > + /* > + * Xen vGIC supports a maximum of 992 interrupt lines. > + * 32 are substracted to cover local IRQs. > + */ > + dom0_cfg.arch.nr_spis = min(gic_number_lines(), (unsigned int) 992) - 32; > + if ( gic_number_lines() > 992 ) > + printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); > + dom0_cfg.arch.tee_type = tee_get_type(); > + dom0_cfg.max_vcpus = dom0_max_vcpus(); > + > + if ( iommu_enabled ) > + dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; > + > + dom0 = domain_create(0, &dom0_cfg, true); > + if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) > + panic("Error creating domain 0\n"); > + > + if ( construct_dom0(dom0) != 0) > + panic("Could not set up DOM0 guest OS\n"); > + } It always felt a bit strange the dom0 creation is partly happening in setup.c when for domU everythink will happen in domain_build.c. Woule you be able to create a patch that will first move the code in a new function (maybe create_dom0())? The function would return NULL in case of an error or the domain. > + else > + printk(XENLOG_INFO "Xen dom0less mode detected\n"); > > heap_init_late(); > > @@ -1003,7 +1037,8 @@ void __init start_xen(unsigned long boot_phys_offset, > if ( acpi_disabled ) > create_domUs(); > > - domain_unpause_by_systemcontroller(dom0); > + if ( dom0 ) > + domain_unpause_by_systemcontroller(dom0); > > /* Switch on to the dynamically allocated stack for the idle vcpu > * since the static one we're running on is about to be freed. */ > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Mar 08 14:22:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 14:22:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94969.179048 (Exim 4.92) (envelope-from ) id 1lJGlo-0001ob-JJ; Mon, 08 Mar 2021 14:22:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94969.179048; Mon, 08 Mar 2021 14:22:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGlo-0001oU-GM; Mon, 08 Mar 2021 14:22:04 +0000 Received: by outflank-mailman (input) for mailman id 94969; Mon, 08 Mar 2021 14:22:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGln-0001oP-AJ for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 14:22:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 07b4cd94-bb51-4470-9f14-a230342546be; Mon, 08 Mar 2021 14:22:02 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 64557AD3B; Mon, 8 Mar 2021 14:22:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07b4cd94-bb51-4470-9f14-a230342546be X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615213321; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zuVhzmHD/GwJ/BD/Uua8G2r0aRGsxm60T75ZELmL844=; b=MfrzZ18omo+HO8HaAVlWOrF1RBhmea1E6XupkOnJh0eoGbn+B82qMLSmPldiPSLCvh+rMe +6vbGhSpU9v3NHndW3TwHH8f1AcDxYZifJDtP9D1FtAXcBD+F/MuobUEmreEOGWnwN32nt JxrqNZrvcxpqWhfgImxtez2kd2P+D1E= Subject: Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less To: Julien Grall , Luca Fancellu Cc: Stefano Stabellini , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20210308115610.48203-1-luca.fancellu@arm.com> <1921ff88-7637-6454-74a7-1cbab8dafc61@xen.org> From: Jan Beulich Message-ID: <24f4462d-cf3e-73a1-0515-de94d7576f34@suse.com> Date: Mon, 8 Mar 2021 15:22:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <1921ff88-7637-6454-74a7-1cbab8dafc61@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 15:12, Julien Grall wrote: > On 08/03/2021 11:56, Luca Fancellu wrote: >> This patch prevents the dom0 to be loaded skipping its >> building and going forward to build domUs when the dom0 >> kernel is not found and at least one domU is present. > > As you are skipping dom0, the domid 0 will not be usable for another > domain. I can see a few issues: > 1) The first domU created will now be considered as the hardware > domain (see domain_create()). > 2) There are still a few hardcoded use of d->domain_id == 0 in the > codebase (I could spot at least on in the RTDS code). > 3) Not all the code seems to be able to cope with hardware_domain is > NULL (although most of it looks to be only reachable by x86)? > 4) is_hardware_domain() will return true when passing NULL. It is > not clear whether one may pass NULL here. > > For 2), ideally this needs to be fixed. But we may also want to reserve > domid 0 just for sanity. +1 to reserving ID zero in such a case. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 14:26:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 14:26:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94972.179061 (Exim 4.92) (envelope-from ) id 1lJGpz-0001xH-4d; Mon, 08 Mar 2021 14:26:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94972.179061; Mon, 08 Mar 2021 14:26:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGpz-0001xA-1Z; Mon, 08 Mar 2021 14:26:23 +0000 Received: by outflank-mailman (input) for mailman id 94972; Mon, 08 Mar 2021 14:26:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGpx-0001x5-Dj for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 14:26:21 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b69f9f88-5989-471e-b07c-1007a37a5e77; Mon, 08 Mar 2021 14:26:20 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B191FAD3B; Mon, 8 Mar 2021 14:26:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b69f9f88-5989-471e-b07c-1007a37a5e77 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615213579; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ANzg/AOpEcwTRQCqKAO57x29eRpCDqdl3nWx+lS4Xx0=; b=JyanQ6IvlriUZVo7eAvdaSHwK/i8y4FE7gQJpLgeqKn6aI4J3iby19n0/X/nT1+tSey1PX rNGBBeACoZM4mdBf8wJ+3KSlaffeMmGNZ3vX7L4pXWf0fDnlCmFQsBtnAjhm3x3y5FQ6Jn mY3i7NekKSmtBOtOyvsVdcGzrBoPQ9M= Subject: Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210308135937.1692-1-michal.orzel@arm.com> From: Jan Beulich Message-ID: <37ea3c87-c960-4c92-af5f-71f2db774a75@suse.com> Date: Mon, 8 Mar 2021 15:26:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210308135937.1692-1-michal.orzel@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 14:59, Michal Orzel wrote: > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o > > #obj-bin-y += ....o > > -ifdef CONFIG_DTB_FILE > +ifneq ($(CONFIG_DTB_FILE),"") > obj-y += dtb.o > AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" > endif Right now what I have for my Arm test builds is an unquoted string in ./.config, e.g.: CONFIG_DTB_FILE:=/usr/local/arm-linux-gnueabi/vexpress-v2p-aem-v7a.dtb While I suppose you've tested that the resulting quoting is still okay, to reduce confusion perhaps the AFLAGS-y line would better be changed to AFLAGS-y += '-DCONFIG_DTB_FILE=$(CONFIG_DTB_FILE)' at the same time? Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 14:29:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 14:29:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94976.179072 (Exim 4.92) (envelope-from ) id 1lJGtB-0002Ax-JM; Mon, 08 Mar 2021 14:29:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94976.179072; Mon, 08 Mar 2021 14:29:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGtB-0002Aq-GM; Mon, 08 Mar 2021 14:29:41 +0000 Received: by outflank-mailman (input) for mailman id 94976; Mon, 08 Mar 2021 14:29:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGtA-0002Ak-0v for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 14:29:40 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 01c4ee59-27b3-4b8e-9fd5-9a9abc1ec002; Mon, 08 Mar 2021 14:29:39 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0EBF3ADDC; Mon, 8 Mar 2021 14:29:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01c4ee59-27b3-4b8e-9fd5-9a9abc1ec002 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615213778; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y2/quS/EQNL8fzKIskYqpe24qvs94twjamab7DxxO1c=; b=Tv50PsFvTzAAOb8fHVLO1sTPeK/Qk0wKmF+X75PGaB/8+uyunA/0TNV9qEkh1FpGLeQe3z tKkI9/X8MthWuEV6HHj0IHNI9C8iV/nDQF2NO2FFe67Pr7DfrYOurg3wJpXS+W2b5Ye5Sv uAQDfM/xSF41Yf68acOFF0jYC3VyfVs= Subject: Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson , Tim Deegan References: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> <96c83adb-9e81-8398-c905-f4f0730ba240@citrix.com> <8fd91411-ecb7-c0ec-000a-b1937c98f57e@citrix.com> From: Jan Beulich Message-ID: <55964b2d-a826-710b-1814-c68eeebcc891@suse.com> Date: Mon, 8 Mar 2021 15:29:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <8fd91411-ecb7-c0ec-000a-b1937c98f57e@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 08.03.2021 14:59, Andrew Cooper wrote: > On 08/03/2021 13:51, Jan Beulich wrote: >> On 08.03.2021 14:47, Andrew Cooper wrote: >>> On 08/03/2021 09:25, Tim Deegan wrote: >>>> At 16:37 +0100 on 05 Mar (1614962224), Jan Beulich wrote: >>>>> We can't make correctness of our own behavior dependent upon a >>>>> hypervisor underneath us correctly telling us the true physical address >>>>> with hardware uses. Without knowing this, we can't be certain reserved >>>>> bit faults can actually be observed. Therefore, besides evaluating the >>>>> number of address bits when deciding whether to use the optimization, >>>>> also check whether we're running virtualized ourselves. >>>>> >>>>> Requested-by: Andrew Cooper >>>>> Signed-off-by: Jan Beulich >>>> Acked-by: Tim Deegan >>>> >>>> I would consider this to be a bug in the underlying hypervisor, but I >>>> agree than in practice it won't be safe to rely on it being correct. >>> I'd argue against this being a hypervisor bug.  If anything, it is a >>> weakness in how x86 virtualisation works. >>> >>> For booting on a single host, then yes - vMAXPHYSADDR really ought to be >>> the same as MAXPHYSADDR, and is what happens in the common case. >>> >>> For booting in a heterogeneous pool, the only safe value is the min of >>> MAXPHYSADDR across the resource pool.  Anything higher, and the VM will >>> malfunction (get #PF[rsvd] for apparently-legal PTEs) on the smallest >>> pool member(s). >> Except that min isn't safe either - the guest may then expect reserved >> bit faults where none surface. > > Such a guest is buggy, and in clear violation of the rules set out in > the architecture.  All reserved behaviour is subject to change in the > future. > > Any software (Xen included) deliberately choosing to depend on the > specifics of reserved behaviour, get to keep all resulting pieces. While I could understand what you're saying when considering our prior unconditional relying on getting reserved bit faults, are you suggesting the recently adjusted behavior is still "in clear violation of the rules set out in the architecture"? And hence are you suggesting we should have outright dropped that optimization? Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 14:31:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 14:31:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94978.179085 (Exim 4.92) (envelope-from ) id 1lJGuv-0002yE-08; Mon, 08 Mar 2021 14:31:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94978.179085; Mon, 08 Mar 2021 14:31:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGuu-0002y7-Sl; Mon, 08 Mar 2021 14:31:28 +0000 Received: by outflank-mailman (input) for mailman id 94978; Mon, 08 Mar 2021 14:31:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGut-0002y1-Ol for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 14:31:27 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cc59eb84-4328-41ed-ba10-5786d5b1c7ae; Mon, 08 Mar 2021 14:31:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc59eb84-4328-41ed-ba10-5786d5b1c7ae DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615213886; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=mWN3spQ59wAH3sbB2qM3oeD6NUs3Q3h3kF0fyOdYMZU=; b=JqCzgfJQoh+gdNT/O0gq71pC1c0eoTs7S0rOOx81uXi67zOUBnmlWhDX IvQmq80lMDxFXo7Y6ZBTOaSxa9f1mBvesm/82BlVCo9ba8U2eGNY6NuTK y0lDqiEO0+WTg42irD0HxwPpjL+TdD4q1yY1eFr41UKQxTUt/6Lmhzmfp Q=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: PzLq33xz9an6GQUv3BMNSxCw9kcT0W7yXnY/FBvuSKYNdyBiMlguqJqFZnfMuOuSbwNB37tMHf PmIrSGcot4F5imP7TWQ5YmSkWN4INbXYlCipOi9zZO+wkkcwlW4vvxaTYEYhs4Qpy961r9Qa/W 5eM06Mr8aaPd+16YCsWy84LUTG7G2DQSf3a8u02L/S/eS6uA9eu3scaStrlunc3gOuYy+CcNcm owU/g7cYg33aF1FRnEsql/pnGeHepXntEfHvID7Rtu5uEgaz0n1XrDCDX9SUXy4GMeE6FFd8sV Ivc= X-SBRS: 5.2 X-MesageID: 40183706 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,232,1610427600"; d="scan'208";a="40183706" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CSYHXPI8ZReX43OqOZJFlSxOUjUg78O9spm9dZId90cv5+M6f63nRDruIrhUVtNwVyVYzWubLEcsGDL/mS+PAKa56vQP6lDXRlHpu8xJu28bWUrf+PBTVZbAD12RXPIkf/I/6t1ng1PIHDxxGz15DxF1+ZlME9hLXx8JUVZkEhGXpAJ+4h9/2PAO54eUFTVpq2zx1Ev9ZU04vkfU9w71IL0/kbAjx0ZRv64YdRzoGsu7ixevZxpbm9cT8BJQSSC452ojOpC0q7lXiJNttyNLxbKbL96utKI2KZkbEH7ZUJHvBQmM+utPq+L56W/CZsJ4OS1ZyShineFzpyxlj+9bSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4d3Dy42PE2eMQRfsKn+OZa7KCKiS9akaynW4wHVieqg=; b=ikY4LwpgbclGAMC1qTfKwYZeYIez4mIqYf/I8hvHTZy8qZNn/pQVdvGE8ZnpEUOg1FNCSIE6KjwNUVOj/IGCFVF/wU305mN8mwerPq8UcFO5xolr2buJR5cwnRR+4qXPEF0AuXDknMzR1TVI+50Y3K/BlL69G85a+Xw07GTQKblbkFoy/J8Zu50jKkUp3MWDkH7W4NXEu5r3O08Ukt4kEjrKO2ozdQoOj0yM6nMObEFFBg83wcNeBnjDwjZ3FmkcsB/xoZ2jYX2Bi3iLSyu+aHCwvIhbQi16KBDpBYw9FxUPnXeffxuMsKGpEHsF+HXBNKQZK5PxqHe3akk5Jgkm6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4d3Dy42PE2eMQRfsKn+OZa7KCKiS9akaynW4wHVieqg=; b=XcASOlhHq3XfeZgZr+pCeAFO6HpaXyAqUhg0lxhuUbVrg2fZEfJPwjoQBNlm0ycN+X9FycUkD1ajFRsNS8O3XIe1whjtcyKT6Ahyh9vVxDkryeDJeMwx3ff2BnypfRR3PHPbrQ+8TC7AAz+qoOT3BNFFn6RVC+rv0ePWa0SKPLk= Date: Mon, 8 Mar 2021 15:30:58 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Ian Jackson , Wei Liu , Anthony PERARD , Andrew Cooper , Jun Nakajima , Kevin Tian , Boris Ostrovsky , Subject: Re: [PATCH v2 for-4.15] x86/msr: introduce an option for HVM relaxed rdmsr behavior Message-ID: References: <20210304144755.35891-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: AM6PR10CA0104.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::45) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 39bce5de-24dd-4abe-c57a-08d8e23ecdff X-MS-TrafficTypeDiagnostic: DS7PR03MB5608: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:316; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QybXIf5Sj4/u2pfrB9YzViQq8a3R0ctP2XamxhyGp7sFS2ym2v2yBY00WYRBfQA7GLjiTKjld+onmq4hgmTMlGDCOXocHqYgopwPwZMzk7kSCnHparR3D3+sUJsYg3JyrKi70Jz4jzoJH+9i5iq97lsK7kC6TNultccIMDod8cSGjkqQC0YjIxWaiIi+MRrDsanJU9rWIhsAej+eCOCVZEtB7mH3oiSgT/2DzD3MI/6RIFoOw+0/Pq9KZvqUCgFXRFzr7AxJelzm8s71wTQDvRLpkcRab4ge/wb1Ey6R16vllw+fPs8XAi6NoxE4Pb4QddExthWgisS8f+nSOsC3O9i/lw7oKULzO7fItcVmuolgI/P9Aw3Inpa2L127XTx3tPSIv4VnD0+ie2bbLSBfPgk3gABhTUIdkjRHT2jX8UAmNXie4KTwo2uqZgU/Gw9Bmq72M9fgackTVTQLT8vgeeyCyMMEh5LKKfCR8sLk50lglT11dP5cBRfgfQtNr/4o4aNDS2s2/g+AHVYvEExh7A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(39860400002)(366004)(396003)(346002)(136003)(376002)(6916009)(478600001)(6666004)(5660300002)(6486002)(4326008)(33716001)(85182001)(66946007)(9686003)(186003)(956004)(66476007)(53546011)(66556008)(16526019)(8676002)(8936002)(86362001)(26005)(54906003)(6496006)(316002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?N2V5eHpjSXNBQkpqcGJqTEh4K284WUptSm5MQVpHdzh5N1l1UnNaanRqeWEz?= =?utf-8?B?bk9OY1FzRmYvbkhORjhKcHNwVy9EVnMwSkMrRkR6M2RZejZjNU15cnQ3S0lx?= =?utf-8?B?TDRVM1JmUkYrNE05Ynl6dG1wbGpRSGUraUd0OEJCcFUrbGtCTFlBODJhVjBJ?= =?utf-8?B?Q0NvQ1hQRzg3NWN4VDhYWUlVdCtXMkxqMm1pT09sbnRBbHJFWjVpcmNiK3l1?= =?utf-8?B?MU9icnJ2WmlRVzVvSUN6Sk9PanFVOXI0RjV6YnIzMmZJUW5lRE9uazJtWms0?= =?utf-8?B?TU0rVzhvY1pjTXJiYTg1SzQ4SHFPNHRzT253cWt6cEdvd0lncVhkNDZWVXJ4?= =?utf-8?B?bDR2MVpkSWpZVm51VWJaUENXSDZ6Q0t4djZVV2xiVUgwWkhkblMzUXllMXBv?= =?utf-8?B?aFlMUHl6djNaOHFoZnZkcHU4N3RKVXdGK29xazlhYTdEdWtzSEFqZ0F2MGtR?= =?utf-8?B?K3JKVktZRDE2amJFNWpCYURhc1N0cERxeEdDcUR6VWtuU0ZEQ0xEMFRHR0Q3?= =?utf-8?B?VW5rN3ppMTVGaitpSWgwS0gxL3E2dTRaMnZ2WWYzZ0RQMThKR0x2Z2tYZENO?= =?utf-8?B?SEhWZkxzOXJnUWxzT0NhMS9FOC9UTmIyVXlQaStCSDliZk1McFJIZlJzVHpH?= =?utf-8?B?ajl4eFRDdXlqOFhMRUJZaERqeW1UMjl4NTBURHlFOTQ1cVF1NzZmMEZDRjVq?= =?utf-8?B?cVNlRUFYcFVsb2VGb1I1R3Zhcy9KOG5tKzVDUzYxTGw3NGV6WnFQZ1JPWFl2?= =?utf-8?B?aTVYUGkvVXlhWlBGUEY2RGxUR2c0ZGd1V0hKMzFoZzBzRDlxWEVEK0RweENS?= =?utf-8?B?clNxR010UUE0Y29vQnRLNXdaaXFZQ2xNWmJyWlRZR01mNjFORStWMzcwdlN4?= =?utf-8?B?RHBIcWRLTGt2N1BnNHRQVlNGMXlmNmxwQ0RHZ3hBRUROVGtpeW1xckxkNW52?= =?utf-8?B?cmlncFQ3MGVjbklJSnFVYzhRTWIydlZRUCtsWThpdVpoZTU3YWQ5TTdmZkdt?= =?utf-8?B?QVNYOHZjUG1YLzZMbXR5TEQ2OEIwczFVclllVjB6eW1yalFLUGg3a0svZG95?= =?utf-8?B?Q29OTWlCb0c1YWxuNWpDWUFhdTE0M0dGbUtzaGFEM2pmRWpDWnhyMHE0YmVn?= =?utf-8?B?RjVxc2ZBQkVMQjJoVXdzK0pTVGlmeGJIM0RGSjZsQ2VkNUtGTU9hdkxLanEr?= =?utf-8?B?TmVUUUI1SVRrTUQ3S2hZdnpTQVJTUnJCWGlseEo3QkNYZEhVSlNNWFdrZ3lr?= =?utf-8?B?WVV5OFdCRlgzNUNQV2xQWG5wNE1PbWZrUFRPSWQvTmlqM0haZGI2eWNCNTJH?= =?utf-8?B?ZndDRTZRNFFuc040ZVBHZWtkWFRYMWRaR0ZZK1IvQ2lWb0FCcnE2dzcvME5i?= =?utf-8?B?aGFPTjJqbHYxbC9EWmtjZHpLNytZb3F4ck9ENnFvQ3ZoUmZSK1llWXlUclVl?= =?utf-8?B?djlpeTJSSFVBeU94SzdWMWMwL25qQUxwRDg4SjFOL3NUMTViVDRreTFmSDFH?= =?utf-8?B?NklKWjZUZGp0Z3Ezbk83T3liaEZKMFBzdFpoZzRTYXV1R0thbzRzRmFEdU1E?= =?utf-8?B?M3NEZXcxQWp3aS9YdGlOanN5bTdiSitVOTAxRjJiVUZiL3VKSG5uRDVLNi9O?= =?utf-8?B?V3Rmdis1dkJIdy80MGROSisrSWhQbXBJWHM4ZG5hY1oxZEE4V252bnNGSko1?= =?utf-8?B?UEVnVjhVOHpZZEpCaDI3ZDg3dS8zcVJFZVFNZEZSSnZzc3p0SWZmWWF4eCtz?= =?utf-8?Q?kOlOhLNgSBf4V5/kD53tmjZElw2W6/So45ERXQ9?= X-MS-Exchange-CrossTenant-Network-Message-Id: 39bce5de-24dd-4abe-c57a-08d8e23ecdff X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 14:31:04.7016 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g5Bz8JEUX5p3jp7P8XEQoMg7N+JCz86Sr2u8Vn7QV4B+89YMk34xgREFLH1IVi/gr5e5cdbChzanW2ym3LiW2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5608 X-OriginatorOrg: citrix.com On Fri, Mar 05, 2021 at 11:56:33AM +0100, Jan Beulich wrote: > On 04.03.2021 15:47, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/svm/svm.c > > +++ b/xen/arch/x86/hvm/svm/svm.c > > @@ -1795,6 +1795,7 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) > > const struct domain *d = v->domain; > > struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; > > const struct nestedsvm *nsvm = &vcpu_nestedsvm(v); > > + uint64_t tmp; > > > > switch ( msr ) > > { > > @@ -1965,6 +1966,11 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) > > break; > > > > default: > > + if ( d->arch.hvm.rdmsr_relaxed && !rdmsr_safe(msr, tmp) ) > > + { > > + *msr_content = 0; > > + break; > > + } > > You don't really need "tmp" here, do you? You could as well read > into *msr_content, as you're zapping the value afterwards anyway. I also thought about doing this, but felt unease. I fear the code might be changed in the future and maybe msr_content is not zapped anymore, thus leaking the content. I feel it's safer to use a temporary variable that will never be returned to the guest. Maybe I'm just too paranoid. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 14:31:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 14:31:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94980.179097 (Exim 4.92) (envelope-from ) id 1lJGvI-00035z-CU; Mon, 08 Mar 2021 14:31:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94980.179097; Mon, 08 Mar 2021 14:31:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGvI-00035s-9C; Mon, 08 Mar 2021 14:31:52 +0000 Received: by outflank-mailman (input) for mailman id 94980; Mon, 08 Mar 2021 14:31:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGvG-00035a-Lx for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 14:31:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGvD-00064a-0Q; Mon, 08 Mar 2021 14:31:47 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJGvC-0006ze-NY; Mon, 08 Mar 2021 14:31:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=wUADUy5CRV7i2GKakvMeVwR7brx30CZn1gWbHASJIq8=; b=ARbae4knno9KiZHfEJpFe4Bkjl 687OdCbjXz2jDFr2z4yV8XtMbIvaaRRQWEavIsBT5u61jvAhawmTLcVW3ZxacO+qgR2FHDOZaqQKq nfVLeM4FGJ/GG4mjV/dq+ase4mHCXXlOS9YJya1Ri22ll7mr08+IFCn1fA4qqt1ToS1U=; Subject: Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com References: <20210308135937.1692-1-michal.orzel@arm.com> From: Julien Grall Message-ID: <745c5049-fb09-5605-8bc1-838a4def45d6@xen.org> Date: Mon, 8 Mar 2021 14:31:43 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210308135937.1692-1-michal.orzel@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi, On 08/03/2021 13:59, Michal Orzel wrote: > Currently in order to link existing DTB into Xen image > we need to either specify option CONFIG_DTB_FILE on the > command line or manually add it into .config. > Add Kconfig entry: CONFIG_DTB_FILE to be able to > provide the path to DTB we want to embed into Xen image. > If no path provided - the dtb will not be embedded. > > Signed-off-by: Michal Orzel > --- > xen/arch/arm/Makefile | 4 +--- > xen/common/Kconfig | 8 ++++++++ > 2 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index 16e6523e2c..0f3e99d075 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o > > #obj-bin-y += ....o > > -ifdef CONFIG_DTB_FILE > +ifneq ($(CONFIG_DTB_FILE),"") > obj-y += dtb.o > AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" > endif > @@ -137,8 +137,6 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c > xen.lds: xen.lds.S > $(CPP) -P $(a_flags) -MQ $@ -o $@ $< > > -dtb.o: $(CONFIG_DTB_FILE) > - Why is this dropped? > .PHONY: clean > clean:: > rm -f asm-offsets.s xen.lds > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index eb953d171e..a4c8d09edf 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -400,6 +400,14 @@ config DOM0_MEM > > Leave empty if you are not sure what to specify. > > +config DTB_FILE May I ask why is this add in common/Kconfig rather than arm/Kconfig? > + string "Absolute path to device tree blob" > + depends on ARM If this stay in common Kconfig, shouldn't this be gated with HAS_DEVICE_TREE? > + ---help--- > + When using a bootloader that has no device tree support or when there > + is no bootloader at all, use this option to specify the absolute path > + to a device tree that will be linked directly inside Xen binary. > + > config TRACEBUFFER > bool "Enable tracing infrastructure" if EXPERT > default y > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Mar 08 14:33:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 14:33:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94986.179108 (Exim 4.92) (envelope-from ) id 1lJGwP-0003E7-Nx; Mon, 08 Mar 2021 14:33:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94986.179108; Mon, 08 Mar 2021 14:33:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGwP-0003E0-Ke; Mon, 08 Mar 2021 14:33:01 +0000 Received: by outflank-mailman (input) for mailman id 94986; Mon, 08 Mar 2021 14:32:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJGwN-0003Du-Pf for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 14:32:59 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 34e8f0b7-2b49-45dd-bda8-ba886754379e; Mon, 08 Mar 2021 14:32:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34e8f0b7-2b49-45dd-bda8-ba886754379e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615213978; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Q1bwcy8zs0Y3OOtedWN1SdTn52JflrxXUJhjBz32qYs=; b=c6dhUoD8LHLcZjnC2FpYoDKjm7QPsgf6T2TX5lssFSpTpF8l2udw0wsl 9Fs9trijOp2S0WhRszNcu+A0ABkBJo5o0zg/+yTpG5U6qcAsMYkapmgcl fJFYtR0dK9ceH1caFqz97wzSK7i+QIT0VHwdbBNaVI0YsVPLc7TJAoN59 A=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: Cyr/TUjEwVfGjW7hRbaKiJa1Ckr9xfodS8EQgLVEM1gUMrkAfx9be9upn8cgb8gLbQX8urcaVU rebXD0ABAkaDYMK3UoXdTT8u0RnZ2ljfVX5/Fi+OFVGGlt4/DSrgq1BwpAg19mrJWZvjNQzTgD AMIPyx12eIEUeEPmGHSYIbsgiKI28Ss6cq4O5iDxKR6A5KGLnu+Fli/dnwx9RjlyRfjNDascwa xjHeFBARuwB8x1Oqu8ZWasTkn0lfa5Y6F8wLK/3jxBXuf6769k5uTPxD+ht0YQg0xPWGKh5Mdr +gE= X-SBRS: 4.0 X-MesageID: 38766920 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,232,1610427600"; d="scan'208";a="38766920" From: Anthony PERARD To: CC: Paolo Bonzini , Stefan Hajnoczi , Maxim Levitsky , Anthony PERARD , Stefano Stabellini , Paul Durrant , Kevin Wolf , Max Reitz , , Subject: [PATCH] xen-block: Fix removal of backend instance via xenstore Date: Mon, 8 Mar 2021 14:32:32 +0000 Message-ID: <20210308143232.83388-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain From: Anthony PERARD Whenever a Xen block device is detach via xenstore, the image associated with it remained open by the backend QEMU and an error is logged: qemu-system-i386: failed to destroy drive: Node xvdz-qcow2 is in use This happened since object_unparent() doesn't immediately frees the object and thus keep a reference to the node we are trying to free. The reference is hold by the "drive" property and the call xen_block_drive_destroy() fails. In order to fix that, we call drain_call_rcu() to run the callback setup by bus_remove_child() via object_unparent(). Fixes: 2d24a6466154 ("device-core: use RCU for list of children of a bus") Signed-off-by: Anthony PERARD --- CCing people whom introduced/reviewed the change to use RCU to give them a chance to say if the change is fine. --- hw/block/xen-block.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index a3b69e27096f..fe5f828e2d25 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -972,6 +972,15 @@ static void xen_block_device_destroy(XenBackendInstance *backend, object_unparent(OBJECT(xendev)); + /* + * Drall all pending RCU callbacks as object_unparent() frees `xendev' + * in a RCU callback. + * And due to the property "drive" still existing in `xendev', we + * cann't destroy the XenBlockDrive associated with `xendev' with + * xen_block_drive_destroy() below. + */ + drain_call_rcu(); + if (iothread) { xen_block_iothread_destroy(iothread, errp); if (*errp) { -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Mar 08 14:39:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 14:39:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94991.179120 (Exim 4.92) (envelope-from ) id 1lJH2A-0003UB-Cp; Mon, 08 Mar 2021 14:38:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94991.179120; Mon, 08 Mar 2021 14:38:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJH2A-0003U4-A5; Mon, 08 Mar 2021 14:38:58 +0000 Received: by outflank-mailman (input) for mailman id 94991; Mon, 08 Mar 2021 14:38:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJH28-0003Tz-NC for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 14:38:56 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id ab57b22d-2b0c-4f72-a3a5-64c2fcd9bdc9; Mon, 08 Mar 2021 14:38:54 +0000 (UTC) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-253-J8rO8reKNguY5nF04Rh5Dw-1; Mon, 08 Mar 2021 09:38:52 -0500 Received: by mail-ej1-f72.google.com with SMTP id fy8so4143520ejb.19 for ; Mon, 08 Mar 2021 06:38:52 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id c20sm6718960eja.22.2021.03.08.06.38.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Mar 2021 06:38:50 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab57b22d-2b0c-4f72-a3a5-64c2fcd9bdc9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615214334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=59gGKL4Yyd65EMEKMhGO6s3r2bHBERkQMxkdw9kaBI4=; b=g2pLCzVjUhO9P7Sg2UcdaOyPoqPBm1lpVctvdIEzbUOED14sePum89sVBvt6mecPrMLQPt fljbfKMklUB+VOU5dYYqGARPagkcFYLGJP3/oB6PeETxyK9naWV9as9Q1KuGxsscy1xTXm j2AB5PJAWvm/4bPHwakWWMI48ZAEdKE= X-MC-Unique: J8rO8reKNguY5nF04Rh5Dw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=59gGKL4Yyd65EMEKMhGO6s3r2bHBERkQMxkdw9kaBI4=; b=tJ9toFgG+1SKt+z5JVpNaeCflDPaTZ6xsF2uVyuyu7Ujbe67XKbosbroknaOkGyG89 hhggXYfl9schB1csTSYuA209nIgSZxjTcJKwSfpZMXFTDuUiLbEv8N6+u9SpXNfv1GBQ 3jW+fK6cOkpDz1g5eYKz6bbf/BZ55HTuY50E2L6tivGrmOAdVYXIzFiDQKeV3F9YfzJw x50vlEF3bhPB2VlmmEsB+YvDr5lF//9PmnV63U3SJt1pRpHDjnGbG5z42y6dfJ2zL1IX We1oO6FngznegVX2kxlIsfKf0+83Ic2ShnMwWxVO4+sicrh6zc1Ig01gUbBzw4PAyDW3 Jojg== X-Gm-Message-State: AOAM530qCs1GIwLRAov8V2RhxC5zl2Tdfp7iWJ8I8jAZHtmr0W4Wq2cG 9C/ugQmXRywQDJGkHKkkaH6hASJWbGbkkesLgHPOmEuMKSpsecr5zMAH7ksuMsXZNZjsdwCBQCs 0slHvLE+pov/PV+tj1ZFIGCJh/0Q= X-Received: by 2002:a17:906:f88a:: with SMTP id lg10mr15549887ejb.39.1615214331591; Mon, 08 Mar 2021 06:38:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJw5EuiPpvju0xe6Z4a96WhY/O8sCqQp56NmC+fXqnSgrjpddxZVtGzgCVdSw/Cz84fx8yJhYQ== X-Received: by 2002:a17:906:f88a:: with SMTP id lg10mr15549872ejb.39.1615214331436; Mon, 08 Mar 2021 06:38:51 -0800 (PST) Subject: Re: [PATCH] xen-block: Fix removal of backend instance via xenstore To: Anthony PERARD , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Maxim Levitsky , Stefano Stabellini , Paul Durrant , Kevin Wolf , Max Reitz , xen-devel@lists.xenproject.org, qemu-block@nongnu.org References: <20210308143232.83388-1-anthony.perard@citrix.com> From: Paolo Bonzini Message-ID: Date: Mon, 8 Mar 2021 15:38:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210308143232.83388-1-anthony.perard@citrix.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/03/21 15:32, Anthony PERARD wrote: > From: Anthony PERARD > > Whenever a Xen block device is detach via xenstore, the image > associated with it remained open by the backend QEMU and an error is > logged: > qemu-system-i386: failed to destroy drive: Node xvdz-qcow2 is in use > > This happened since object_unparent() doesn't immediately frees the > object and thus keep a reference to the node we are trying to free. > The reference is hold by the "drive" property and the call > xen_block_drive_destroy() fails. > > In order to fix that, we call drain_call_rcu() to run the callback > setup by bus_remove_child() via object_unparent(). > > Fixes: 2d24a6466154 ("device-core: use RCU for list of children of a bus") > > Signed-off-by: Anthony PERARD > --- > CCing people whom introduced/reviewed the change to use RCU to give > them a chance to say if the change is fine. If nothing else works then I guess it's okay, but why can't you do the xen_block_drive_destroy from e.g. an unrealize callback? Paolo > --- > hw/block/xen-block.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c > index a3b69e27096f..fe5f828e2d25 100644 > --- a/hw/block/xen-block.c > +++ b/hw/block/xen-block.c > @@ -972,6 +972,15 @@ static void xen_block_device_destroy(XenBackendInstance *backend, > > object_unparent(OBJECT(xendev)); > > + /* > + * Drall all pending RCU callbacks as object_unparent() frees `xendev' > + * in a RCU callback. > + * And due to the property "drive" still existing in `xendev', we > + * cann't destroy the XenBlockDrive associated with `xendev' with > + * xen_block_drive_destroy() below. > + */ > + drain_call_rcu(); > + > if (iothread) { > xen_block_iothread_destroy(iothread, errp); > if (*errp) { > From xen-devel-bounces@lists.xenproject.org Mon Mar 08 14:40:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 14:40:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94993.179133 (Exim 4.92) (envelope-from ) id 1lJH3a-0004HC-Ox; Mon, 08 Mar 2021 14:40:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94993.179133; Mon, 08 Mar 2021 14:40:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJH3a-0004H5-Lq; Mon, 08 Mar 2021 14:40:26 +0000 Received: by outflank-mailman (input) for mailman id 94993; Mon, 08 Mar 2021 14:40:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJH3Z-0004Gz-Qh for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 14:40:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJH3Z-0006FH-LH for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 14:40:25 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJH3Z-0007gT-IK for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 14:40:25 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lJH3W-0000HD-E1; Mon, 08 Mar 2021 14:40:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=fIENQNCGeXSq/VxQN5AmG80eYZ59T40ORO8VcImmoxA=; b=RIv1l4RcRQshtDrj+a5d+3jkoy MIKodwM8RH5x2YXWxMjr2IpTSudqeXQcMFQJf6o/PwsnLy3SLIUDWVzkO2l6uQ6VkljsUM55BXnZy vckoTJnWjnpV4FOY2zH0HNnUH5Z+ukzZJTgPE0r7HYFavo7Boq3sxJ1dPaC+34eVV0/k=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24646.14166.213674.7213@mariner.uk.xensource.com> Date: Mon, 8 Mar 2021 14:40:22 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time In-Reply-To: <5be57f5c-e055-8d92-832e-f1a17352452d@suse.com> References: <336aaf51-f163-8ee7-d8ee-297f6f3052fd@suse.com> <24645.62832.737310.550811@mariner.uk.xensource.com> <2857440d-058f-5c85-32d3-87e2fe65bb9a@suse.com> <24646.1454.55437.250075@mariner.uk.xensource.com> <78259adb-89b1-06a6-c1f4-c0659134e309@suse.com> <24646.5291.124853.270432@mariner.uk.xensource.com> <5be57f5c-e055-8d92-832e-f1a17352452d@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time"): > On 08.03.2021 13:12, Ian Jackson wrote: > > This will leave the entire directory structure but I think that is > > fine. The xen-dir target uses mkdir -p and should there be any stale > > directories (eg due to switching branches or whatever) they wouldn't > > be a problem. > > Right. Thinking of it though - all we do is setting up symlinks > plus produce this generated header. Couldn't we therefore have > find simply arrange for all symlinks to be found and deleted? I think that would be another alternative, if there is nothing else in there but symlinks. Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 14:47:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 14:47:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.94995.179144 (Exim 4.92) (envelope-from ) id 1lJHAP-0004Uc-D3; Mon, 08 Mar 2021 14:47:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 94995.179144; Mon, 08 Mar 2021 14:47:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJHAP-0004UV-A0; Mon, 08 Mar 2021 14:47:29 +0000 Received: by outflank-mailman (input) for mailman id 94995; Mon, 08 Mar 2021 14:47:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJHAN-0004UP-U8 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 14:47:27 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dc80b3ba-005e-4879-a1b6-48ff5cedcf6a; Mon, 08 Mar 2021 14:47:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc80b3ba-005e-4879-a1b6-48ff5cedcf6a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615214846; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=e4GaBLhRKn0ImMER2Gu5f4y+Opc7r9KicYRYk/z1cfk=; b=KtqmuzwVjiE1qObhEtMiByBvq5W7RoAJlPtAHbeTTTKlQIqHLo2IX3uY KXdpXF+ICCjDD6B0V/YGwnLW/VTtSL4QoYPLJd8sXMtOjoQJqaQyguDfH /YhVnJz8+T5jjbFPFTJAFl3nrBBBhcecvI/2+EGwFjerY+lwpZOgtGxUG 0=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: EXBsyg/ePDMnJH5t3evzpqmz54fMtiTQpAj+ifj2RBJ0KjkOGqK2CYpK1he6KnQtEan+TGE9QF vO1PAybi6pvD5xgnV5XQL49AudPuSx80gWRkX9ESK+6XFScPaYjpfa3icoki1teHPPuW74COps T7guhze9ZhVZEwnuVPBr3j37VZFwE4HSAS5DeeXpDYxH5RBXboklnCsQdHSpABi97vjnOALL0u G3+9HzIsGQIe1uT0PFtfLnRFobXNYuhSGoXj9a4AQ7T9FUQqzfue9V1lKRTxurGIaQVCeHOY54 YLo= X-SBRS: 5.2 X-MesageID: 39142679 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,232,1610427600"; d="scan'208";a="39142679" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T3LTbmjZL2gpK5K6NmRPLsp+nCez1K94tLIp6a1686hPonmsnr9zLf+Ela04kdfaHf3vRm4kF6a3QKEOba5j+iYU8dR48q0k/S+o0jxw0/ShQR3qbCGUNL6LTEWGoKd6JtHTQQVwrt+IrCWPaBfce+J9p0z26Wj8tN33aEQZOgg/qNGaB7Z4TvYQm61fV08iL2YglfxAlQRw52ShpOQZw+7jPMPqJ+JDDsI6jM0G9Hx4e49BliGEbS/5iS8dww6ZW2ClH76gVHa8yPvRfNHE5G6v3s8t3TEgCIH7CEqzshhKsXJLgCWVW2MyBchUuzMsY3XKxvbpJ+tWiZse1tO8Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e4GaBLhRKn0ImMER2Gu5f4y+Opc7r9KicYRYk/z1cfk=; b=hXaxvWMqoNGwG17XCFlgcwSffHhE8A/xz5JfgFKq70STtYnLjpre/ZvIdVbjgsVXNEZtU3bJVF23WJjJxbNaunH2rSFjnBejXkdIM59LcWH8ZpR/jy/wNINbgMXneDVuD/hyjdyunZhe8J+BLzEm8CczH7hqeoJnblDdU+3MwFMG/4971UwiFvp8wBAx5c7iVv0Khq5MmSA8mrpQSBKqUD/fCs5UR0up/v0WFKTrPgNBwf2LSfvrR+V33UWhO4e4qU0Fkh0yBVLa5w01YWxkhpVD0Qv0MINZTGAugqCE7VKC04CB66ktRFMxZvTcsWfyWUOGu79jJs+xihz2X+PFiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e4GaBLhRKn0ImMER2Gu5f4y+Opc7r9KicYRYk/z1cfk=; b=DktSnJQleUlAYVloihOczzgkz1j7lqkZIOsDuFQuZY1SRRQ7YogTd2h5jeWNtQjjPu4+5Vf1x98P8S6WafdU5f5JSkgwLOykIgwbe+1OEMF4tHSAbnekLhv2tTP1WqRMd99G88Y5RLZ+/5DBuQRnhdygP3VJeszTiZAyRvKQ8Gk= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson , Tim Deegan References: <3bb90ab6-22c9-31d4-88a2-39bd3d81c2d7@suse.com> <96c83adb-9e81-8398-c905-f4f0730ba240@citrix.com> <8fd91411-ecb7-c0ec-000a-b1937c98f57e@citrix.com> <55964b2d-a826-710b-1814-c68eeebcc891@suse.com> From: Andrew Cooper Subject: Re: [PATCH 1/2][4.15?] x86/shadow: suppress "fast fault path" optimization when running virtualized Message-ID: <439bb00e-b279-d5db-87e7-72ec6ac9a316@citrix.com> Date: Mon, 8 Mar 2021 14:47:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <55964b2d-a826-710b-1814-c68eeebcc891@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0434.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::7) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e5728e5-74bd-4b4a-fb9a-08d8e2410da1 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5597: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E5CQG5raJzhT1j+imng7RpjQgXP7IEgBfylYb/9qGtwt6ognouhK2ZDRQvwzO7dRkrWpQtT9xEYO25HixbW/O8zK3pj3IVAlXzOGuXwpbdcHQobz4RM9Hk4arxvoFblLwQ8jfYdJTxK/OF9bdXt4fZF+Pb02LkK4q/LLS5OzJiekgyA6Yk+iwG6rMSjU3HCNtvqdTJxBHIZ/30di+toY8Sd9dRXaHlE8GBKC6IRdX9saXwF/RSp/+sL0E4Dx9imQ84Wamk1cZMwxHoOCHSP1faBzD9onplVd6UuCFENyJivCTRJXbmBt9VZvUl8pytUy8fMqnwyBO4yBiNXZgOdEqCM3m5xe3bSv0bTM2bGGp0aFBeMN4yYba+bWcQ+ItmuRtIxS8QbBC1VH8TuoxiwA7NRxNyMSPeNrWFGsKZmfHu2K1mbPXf+7amYzau0aTECbdQeFdo8vkaLE7ccYpbZndLBV2LPN3KnkBTvh22TUuS5r2Bmr5tGFWYHyUJpYoDZeRHxw1otFy8l7kzjhEcILFtLNcQ10Hu/YS1BpOyVrPR3Elog/8T+yoVdnmLcZuEui9jNo2ZTq+Yc19MY55C+FbHG7UhEJ0JhPuM9dNaxDQ8o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(396003)(39860400002)(136003)(376002)(36756003)(54906003)(83380400001)(66946007)(2906002)(5660300002)(6666004)(478600001)(26005)(8936002)(8676002)(53546011)(2616005)(4326008)(86362001)(16526019)(31686004)(186003)(6486002)(6916009)(956004)(316002)(66476007)(31696002)(16576012)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?S2lJcWdPSDB2Z1ZkSk02dThjaEMrZ1E4Q1VYN2NCSFZJNUJITzRSdmpLa29K?= =?utf-8?B?bjZ4M0hnRGE1bEVLLzA2OHpIUlc3QWxpUkd2VkxhRUU0eDk3Rng0VUk5d2Fz?= =?utf-8?B?QURERGl1Kzh5SzEvc1lKeWo0UGlGRVVsQ3pxZ2R0Z0xtRVg3S2g1S1g0K2Nr?= =?utf-8?B?QkFOK09KMnptWHp4TUo5NmlEUE9OUHJETmpzTWJUclNXV1FHN3BYR3poZ3BY?= =?utf-8?B?MnFYNE1xTFpEaVY3dURDOThEOXZEcTVXNFhSalRXYnNlOHhtczZHb1BlOFM0?= =?utf-8?B?Z0NOVnZSMVcveXVRS0xGQVp5U3VNN0MvRnAveHdLSlgrZTYrWDd2Y0NBcG9Z?= =?utf-8?B?Mi94bi9MUGtIVGQrM2lHdjFhamhoOXFSNkN0bUQvSm9NU09BNVpkdHRWaElq?= =?utf-8?B?alhacjJJYy9henJXUFJaRzNHWmIxS1U2QTdpSlFlbjhtWlR3K2JmZExQRGl4?= =?utf-8?B?MUlNRFk3dXdKNkNtV05Gd1lSbTBocGxUTGhBeW0zdkNTbkkzWWJ2OTZNMVpm?= =?utf-8?B?cWhPenlZOXlwZFF5dnFpY2h2VEZ6Y3FGTjBlS2wwSjNTZktocGZtUXVFRFox?= =?utf-8?B?UkVaalJzNitLN0xXS2tlZWpLM3NKUVNkSG5lbVhjOTJwb1cwZDJKTEp4ZTY3?= =?utf-8?B?MGlnaGJZQU5ZcGc3TDZqWEhkUUxMMjNTbjFZTTJINGV0TFJ1R2JLanYzYmRM?= =?utf-8?B?Q2ZXZ1JPTWR1T0lMZjA1eG1iNFZMR29PbXIycjRQa0ZJQ2drWVN4Ni9WdEF1?= =?utf-8?B?ejRTdTVFYTZXNTFqU3F3QWFDRlJCN0dnakdTYzZvUnQ4SnY4bmwwaFJiVEY1?= =?utf-8?B?ZU91RlAyNG1kSWNxNjlyMWV5ZEwzZWU2cmNHOCtUTkcwbDlxWlN3OFZvVXVO?= =?utf-8?B?SElvdElKMkE2QmZDWkQ3Sk5VaXhybDhEWFRBek9jTmtuZXh0TDUyMnFRMUI4?= =?utf-8?B?VW5qTzErY3puaWFrN2docno0QjVyQkhLSEVocGV2b3IzWGo1LzVOaXFzK2o0?= =?utf-8?B?RXFBVmZweXVjUkd4Rnp5SFBkMUhlMStpTHk3bndpTWQwT1VPT2ptZC8wVGR2?= =?utf-8?B?WUhHNzhUTG4wRlZsenBNcDdDazg1Y21OMzd2N0Ewd1hoZ3FOVzNVd1lYbGFK?= =?utf-8?B?TnpMdTJWQUlnTlhLR1l0SzBzQ293ellVQjNRT05Xc0dGd2pzMVZFZHVaWFVu?= =?utf-8?B?V213ckh6c2JiWjhkZ3dQZ1NmQ2JxdjhqSFpkTEZ3aVEwSWNQOG16TXhBbXd3?= =?utf-8?B?YnFzdWVXeWswRGFPeld4R21COC9teUxNNUZIS3VOU252dEtmMlVFUXpqeVFB?= =?utf-8?B?NXN3dWVkTTQ2dTB3SnlEK0NSMm9WeDhYa013cnNHL1lOTFYrTmM5YWtjd2JD?= =?utf-8?B?VWlQQVE0V0pnUlE0dTF4Q0hDK2xLZnN0WE43eU96cHNWWlNmRTR4RkdhcHZB?= =?utf-8?B?dS9rWWxYRjJkYnk0RDgxTlpaWWtRWjNzREdJcHFsQnQ0QjFWRVFIdEZmK2ZJ?= =?utf-8?B?WXBnQXVzSE1pS2djeXB1NzU4d1o5aVB5NEVybWFhekR2NlR4WFd4QTN6K1ZV?= =?utf-8?B?TmlXN2ZBblAzSVR1Z05ialg1eE54dWUzZEoyTkNzTWlaVzJjSmhhOGxEei9Q?= =?utf-8?B?dzg1MW5QakhteEh0UERic0xyeXhOSXNma0M3T2c3ek9HYVJkSXMxQWh4Z20w?= =?utf-8?B?cE9hWkNWK3pBMmhzT3hPRSsySVRkR09Jb3QybWd0WVhJckFRWjhUazNFeG13?= =?utf-8?Q?fihUMs4b15AbRaTUQuKN/u4OGmavwVCuD1mvJKb?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7e5728e5-74bd-4b4a-fb9a-08d8e2410da1 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 14:47:10.4175 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gAtM57ye3bZGtibcaYTe/jqagb9C0O0gqJH5pEtsp6hJPmQNgGLBt7mFDWCZxwL0agDRwUB+omCZAAchy6TvRleZRwjaaGbkL3P0n03/ems= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5597 X-OriginatorOrg: citrix.com On 08/03/2021 14:29, Jan Beulich wrote: > On 08.03.2021 14:59, Andrew Cooper wrote: >> On 08/03/2021 13:51, Jan Beulich wrote: >>> On 08.03.2021 14:47, Andrew Cooper wrote: >>>> On 08/03/2021 09:25, Tim Deegan wrote: >>>>> At 16:37 +0100 on 05 Mar (1614962224), Jan Beulich wrote: >>>>>> We can't make correctness of our own behavior dependent upon a >>>>>> hypervisor underneath us correctly telling us the true physical addr= ess >>>>>> with hardware uses. Without knowing this, we can't be certain reserv= ed >>>>>> bit faults can actually be observed. Therefore, besides evaluating t= he >>>>>> number of address bits when deciding whether to use the optimization= , >>>>>> also check whether we're running virtualized ourselves. >>>>>> >>>>>> Requested-by: Andrew Cooper >>>>>> Signed-off-by: Jan Beulich >>>>> Acked-by: Tim Deegan >>>>> >>>>> I would consider this to be a bug in the underlying hypervisor, but I >>>>> agree than in practice it won't be safe to rely on it being correct. >>>> I'd argue against this being a hypervisor bug.=C2=A0 If anything, it i= s a >>>> weakness in how x86 virtualisation works. >>>> >>>> For booting on a single host, then yes - vMAXPHYSADDR really ought to = be >>>> the same as MAXPHYSADDR, and is what happens in the common case. >>>> >>>> For booting in a heterogeneous pool, the only safe value is the min of >>>> MAXPHYSADDR across the resource pool.=C2=A0 Anything higher, and the V= M will >>>> malfunction (get #PF[rsvd] for apparently-legal PTEs) on the smallest >>>> pool member(s). >>> Except that min isn't safe either - the guest may then expect reserved >>> bit faults where none surface. >> Such a guest is buggy, and in clear violation of the rules set out in >> the architecture.=C2=A0 All reserved behaviour is subject to change in t= he >> future. >> >> Any software (Xen included) deliberately choosing to depend on the >> specifics of reserved behaviour, get to keep all resulting pieces. > While I could understand what you're saying when considering our > prior unconditional relying on getting reserved bit faults, are you > suggesting the recently adjusted behavior is still "in clear > violation of the rules set out in the architecture"? And hence are > you suggesting we should have outright dropped that optimization? Strictly speaking, we shouldn't use reserved bits at all.=C2=A0 That is the most compatible option available. Given that we have chosen to use reserved bits, it is our responsibility for ensuring that they are safe to use.=C2=A0 That is why we elect not to u= se them when virtualised (for this bug), or on native when we think they won't work (the previous change for IceLake). >From that point of view, I think we're fine.=C2=A0 We're (knowingly) operating outside of the rules, and now taking appropriate precautions to cover the corner cases we are aware of. The behaviour of already-shipped CPUs, while not architecturally guarenteed, is known and can reasonably be depended upon. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 08 14:52:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 14:52:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95002.179170 (Exim 4.92) (envelope-from ) id 1lJHFD-0005RJ-Lt; Mon, 08 Mar 2021 14:52:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95002.179170; Mon, 08 Mar 2021 14:52:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJHFD-0005Qx-BF; Mon, 08 Mar 2021 14:52:27 +0000 Received: by outflank-mailman (input) for mailman id 95002; Mon, 08 Mar 2021 14:52:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJHFB-0005QH-Tk for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 14:52:25 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 898f1e11-6962-457e-ae67-7cf5648fbd22; Mon, 08 Mar 2021 14:52:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 898f1e11-6962-457e-ae67-7cf5648fbd22 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615215145; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=XQkacuw92YZ6s7P1uWP7jgpIFq+z/6x0But1e7Mt5q4=; b=N74eB0jPPR4l7lHRWx+z37Rbseo4j0u7TI7ll7mJwmu4e5jS45Mj8yr4 FZyCREXQ4LMALatlfmBZv2n47Ck18eYUKrX5XCLP8BuJiild61HEXtCWs N2sZoAjQTLvCw9TMAYa3cE2pPizGNGtVoDVdXCIdLnNtOUa1QvXknEVTk A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: jRy1UYqBSfW2yl9OZHRJd41YtrqxamoXGfBvcIC8zZyj/eXMKgZVnxkaE89Y8aiHCK5VsGf3ib YTSKMxSAA0PmqhBspGhMbcOI8HvOmBPEXmhzxwpTdipw6XhLJDBG4cEbyNyWUelZbdsgztmzZD SRXxRdHFIt5/TsCpNwJP8e9RjyRLUzK5jppGEJZOA9YO8xHhSOW58JEvRHu7SjtkIgzbRTiHV9 qqnzxs0sV4yobwj29RdIwtUvwRRAPq485gN+Sq6lZ9I7zeYZWHeXlVRrh5WgU5J/OsumEm95wy ufo= X-SBRS: 4.0 X-MesageID: 38957321 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,232,1610427600"; d="scan'208";a="38957321" Subject: Re: [PATCH for-4.15] vtd: make sure QI/IR are disabled before initialisation To: Jan Beulich CC: , , , , , Ian Jackson References: <1615186802-5908-1-git-send-email-igor.druzhinin@citrix.com> From: Igor Druzhinin Message-ID: Date: Mon, 8 Mar 2021 14:52:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 08/03/2021 08:18, Jan Beulich wrote: > On 08.03.2021 08:00, Igor Druzhinin wrote: >> BIOS might pass control to Xen leaving QI and/or IR in enabled and/or >> partially configured state. In case of x2APIC code path where EIM is >> enabled early in boot - those are correctly disabled by Xen before any >> attempt to configure. But for xAPIC that step is missing which was >> proven to cause QI initialization failures on some ICX based platforms >> where QI is left pre-enabled and partially configured by BIOS. > > And those systems then tell us to avoid use of x2APIC? I would have > expected that on modern systems we wouldn't see such quirky firmware > behavior anymore. Anyway, half a sentence to this effect might help > here, as without such firmware behavior the only way to run into > this ought to be use of "no-x2apic" on the command line. Which in > turn might require justification (and potentially a fix elsewhere in > the code to make use of that option unnecessary). > >> Unify the behaviour between x2APIC and xAPIC code paths keeping that in >> line with what Linux does. >> >> Signed-off-by: Igor Druzhinin > > Reviewed-by: Jan Beulich > with some editing of the description. If no other need for a v2 > arises, I suppose whatever you come up with could be folded in > while committing. How about: "... But for xAPIC that step is missing which was proven to cause QI initialization failures on some ICX based platforms where QI is left pre-enabled and partially configured by BIOS. That problem becomes hard to avoid since those platforms are shipped with x2APIC opt out being advertised by default at the same time by firmware. ..." Igor From xen-devel-bounces@lists.xenproject.org Mon Mar 08 14:52:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 14:52:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95000.179156 (Exim 4.92) (envelope-from ) id 1lJHFD-0005QT-4n; Mon, 08 Mar 2021 14:52:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95000.179156; Mon, 08 Mar 2021 14:52:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJHFD-0005QM-1r; Mon, 08 Mar 2021 14:52:27 +0000 Received: by outflank-mailman (input) for mailman id 95000; Mon, 08 Mar 2021 14:52:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJHFB-0005Q9-Ef; Mon, 08 Mar 2021 14:52:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJHFB-0006RM-4F; Mon, 08 Mar 2021 14:52:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJHFA-0005hz-PG; Mon, 08 Mar 2021 14:52:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJHFA-00089d-Ol; Mon, 08 Mar 2021 14:52:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zKeyvomTnbAoKWKue4nMKrzQUqFJnCTjiVU9QHEbKi8=; b=r241HIybZdEEGl26Vipx03D044 kVc8vEA1RGLNKmb2uFldTXBrL3xQl9oJXOXa9As3AB/ZMhMz7tKDnBjM2gp8qXFJZORDvBlIpLKsH LS0+FzHZESrZZm+SpOsh2My6DXmGt20NjpPQ7DpBP1xAOPUhpoLMwSTu+EcO4ZfRNPXE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159864: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=51972482f77b68ef494c8b9591b125460e7984b9 X-Osstest-Versions-That: xen=51972482f77b68ef494c8b9591b125460e7984b9 From: osstest service owner Date: Mon, 08 Mar 2021 14:52:24 +0000 flight 159864 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/159864/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159858 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159858 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159858 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159858 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159858 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159858 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159858 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159858 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159858 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159858 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159858 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 51972482f77b68ef494c8b9591b125460e7984b9 baseline version: xen 51972482f77b68ef494c8b9591b125460e7984b9 Last test of basis 159864 2021-03-08 01:51:25 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 15:15:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 15:15:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95014.179183 (Exim 4.92) (envelope-from ) id 1lJHbE-0007RH-CZ; Mon, 08 Mar 2021 15:15:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95014.179183; Mon, 08 Mar 2021 15:15:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJHbE-0007RA-9c; Mon, 08 Mar 2021 15:15:12 +0000 Received: by outflank-mailman (input) for mailman id 95014; Mon, 08 Mar 2021 15:15:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJHbD-0007R5-KT for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 15:15:11 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bbfa2ff5-d30e-432b-974a-e1e7d8d87101; Mon, 08 Mar 2021 15:15:10 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 898ACAE15; Mon, 8 Mar 2021 15:15:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbfa2ff5-d30e-432b-974a-e1e7d8d87101 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615216509; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NY9P1lEQ4kCt/hDvkCiZv1Pj4mvjOxZ1tK9OA1fVxHo=; b=Vo9nwKuWJKmgY257dOoFBjkgyqeLPmIM4RayT8Vi87vWxTBMYg6pnx3dZevbADQ08JfuiB oT8sV/gkJwBLjHvWncM0xSEWNQzTMTujo7hCkW9Fc7TE3rc14Wvt6lRCuDTaww+jzPtKxx llnp2t7LNOrtlJsblrR8BZk+8/4HIqc= Subject: Re: [PATCH for-4.15] vtd: make sure QI/IR are disabled before initialisation To: Igor Druzhinin Cc: andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, kevin.tian@intel.com, xen-devel@lists.xenproject.org, Ian Jackson References: <1615186802-5908-1-git-send-email-igor.druzhinin@citrix.com> From: Jan Beulich Message-ID: <6cd440c3-414b-dc66-0212-1e727fc7655d@suse.com> Date: Mon, 8 Mar 2021 16:15:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 15:52, Igor Druzhinin wrote: > On 08/03/2021 08:18, Jan Beulich wrote: >> On 08.03.2021 08:00, Igor Druzhinin wrote: >>> BIOS might pass control to Xen leaving QI and/or IR in enabled and/or >>> partially configured state. In case of x2APIC code path where EIM is >>> enabled early in boot - those are correctly disabled by Xen before any >>> attempt to configure. But for xAPIC that step is missing which was >>> proven to cause QI initialization failures on some ICX based platforms >>> where QI is left pre-enabled and partially configured by BIOS. >> >> And those systems then tell us to avoid use of x2APIC? I would have >> expected that on modern systems we wouldn't see such quirky firmware >> behavior anymore. Anyway, half a sentence to this effect might help >> here, as without such firmware behavior the only way to run into >> this ought to be use of "no-x2apic" on the command line. Which in >> turn might require justification (and potentially a fix elsewhere in >> the code to make use of that option unnecessary). >> >>> Unify the behaviour between x2APIC and xAPIC code paths keeping that in >>> line with what Linux does. >>> >>> Signed-off-by: Igor Druzhinin >> >> Reviewed-by: Jan Beulich >> with some editing of the description. If no other need for a v2 >> arises, I suppose whatever you come up with could be folded in >> while committing. > > How about: > > "... But for xAPIC that step is missing which was proven to cause QI > initialization failures on some ICX based platforms where QI is left > pre-enabled and partially configured by BIOS. That problem becomes hard > to avoid since those platforms are shipped with x2APIC opt out being > advertised by default at the same time by firmware. > ..." SGTM. Thanks, Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 08 16:28:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 16:28:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95020.179196 (Exim 4.92) (envelope-from ) id 1lJIjQ-0005mV-Ik; Mon, 08 Mar 2021 16:27:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95020.179196; Mon, 08 Mar 2021 16:27:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJIjQ-0005mO-Ef; Mon, 08 Mar 2021 16:27:44 +0000 Received: by outflank-mailman (input) for mailman id 95020; Mon, 08 Mar 2021 16:27:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJIjM-0005mJ-Tr for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 16:27:43 +0000 Received: from desiato.infradead.org (unknown [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f9a78ac1-8076-4c5b-bcd8-0332c0badef2; Mon, 08 Mar 2021 16:27:34 +0000 (UTC) Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lJIj9-0010v4-3I; Mon, 08 Mar 2021 16:27:27 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id D9C88300238; Mon, 8 Mar 2021 17:27:25 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id AD72623662BE0; Mon, 8 Mar 2021 17:27:25 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9a78ac1-8076-4c5b-bcd8-0332c0badef2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VZ1ywut6hjotzCNJblmbhmr/ur93FTUuoN2sXgKzb0A=; b=f3apT4ncojFpFX4giPDwk/8u6j X/AOL90fouIeILOR/6POsveFPJ5niQtwspFjYFur87BAFnBTQT3m03vwoJ6R1fMibe6p7M43yIV5P xaBnhjZsII2w1XzP3CVmK82D+xsrU3RVDU3HQJSoBzeHLTUDE4NzfgJ5aWAuzLbA5aAwpZt7E0lbC DoFVg6zcPFd0YQYUk31AoI1nZ6fvXLBZiDdcr04hhmSynYz6rAzdnuWCNJDBr2KNc89Eh1jqa8bzm Zm2jfjJ8UOWDMl9S7+TcSU5Qo+o1KjKmjAeFiKZckIv9sa9HOuoT6VPwQOZ5F5WEKu5y3iy50fEEF SLMASU5w==; Date: Mon, 8 Mar 2021 17:27:25 +0100 From: Peter Zijlstra To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel Subject: Re: [PATCH v5 01/12] staticcall: move struct static_call_key definition to static_call_types.h Message-ID: References: <20210308122844.30488-1-jgross@suse.com> <20210308122844.30488-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210308122844.30488-2-jgross@suse.com> On Mon, Mar 08, 2021 at 01:28:33PM +0100, Juergen Gross wrote: > Having the definition of static_call() in static_call_types.h makes > no sense as long struct static_call_key isn't defined there, as the > generic implementation of static_call() is referencing this structure. > > So move the definition of struct static_call_key to static_call_types.h. > > Signed-off-by: Juergen Gross s/staticcall/static_call/ on $Subject From xen-devel-bounces@lists.xenproject.org Mon Mar 08 16:32:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 16:32:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95025.179208 (Exim 4.92) (envelope-from ) id 1lJIo5-0006eE-9q; Mon, 08 Mar 2021 16:32:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95025.179208; Mon, 08 Mar 2021 16:32:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJIo5-0006e7-5x; Mon, 08 Mar 2021 16:32:33 +0000 Received: by outflank-mailman (input) for mailman id 95025; Mon, 08 Mar 2021 16:32:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJIo3-0006e2-Ev for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 16:32:32 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f9e0e3f5-f6b1-4907-b936-b0de7befaa3e; Mon, 08 Mar 2021 16:32:22 +0000 (UTC) Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lJImq-00FhSp-Nd; Mon, 08 Mar 2021 16:31:18 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id E6098301A32; Mon, 8 Mar 2021 17:31:14 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id AED8F23662BE6; Mon, 8 Mar 2021 17:31:14 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9e0e3f5-f6b1-4907-b936-b0de7befaa3e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ctgZEZ6SYMXYKEHtwrX/ccObphSH4Tanp4Hu/eZWjco=; b=O6GPVLkfkFCoPo4u770nad6OVA ehvFbr/4Mm4vWAjFwqwO5SUsDEau/mYHQZ2gkZ8bdv6assDl5XHprfvP70WyYSlLZqB6F19bheizF nWPQ2Fl72q4it0NkKb6zdcBFPwO70OKu3vEzT2CGrnUjfYkNffqBcBu5G1k4oM0zmDsfKpRv9mKKH whBUzj7rXE+Y3QCrs42HCNj7eF65Dc+sIk2yQUI7l5GArDZPP9GU2hC1IbAcptmuQ8kurX/Qn02eX G65NDEmgPjiiWczczc82QFlc/DRBUkXZOonwrC3aGjytll0ncMWktJG6plrfBKKjODkeclkevvDPx zKEDNnOw==; Date: Mon, 8 Mar 2021 17:31:14 +0100 From: Peter Zijlstra To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, clang-built-linux@googlegroups.com, Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel , Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini , Andy Lutomirski , Nathan Chancellor , Nick Desaulniers Subject: Re: [PATCH v5 00/12] x86: major paravirt cleanup Message-ID: References: <20210308122844.30488-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210308122844.30488-1-jgross@suse.com> On Mon, Mar 08, 2021 at 01:28:32PM +0100, Juergen Gross wrote: > This is a major cleanup of the paravirt infrastructure aiming at > eliminating all custom code patching via paravirt patching. > > This is achieved by using ALTERNATIVE instead, leading to the ability > to give objtool access to the patched in instructions. > > In order to remove most of the 32-bit special handling from pvops the > time related operations are switched to use static_call() instead. > > At the end of this series all paravirt patching has to do is to > replace indirect calls with direct ones. In a further step this could > be switched to static_call(), too. Acked-by: Peter Zijlstra (Intel) I've rebased my objtool/retpoline branch on top of this, will post if/when this hits tip. Negative alternative works like a charm. From xen-devel-bounces@lists.xenproject.org Mon Mar 08 17:01:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 17:01:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95031.179219 (Exim 4.92) (envelope-from ) id 1lJJG7-0000vb-DH; Mon, 08 Mar 2021 17:01:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95031.179219; Mon, 08 Mar 2021 17:01:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJJG7-0000vU-AN; Mon, 08 Mar 2021 17:01:31 +0000 Received: by outflank-mailman (input) for mailman id 95031; Mon, 08 Mar 2021 17:01:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJJG5-0000vP-Sr for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 17:01:30 +0000 Received: from aserp2130.oracle.com (unknown [141.146.126.79]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 455198c9-936b-42f0-a339-6da0a3d83298; Mon, 08 Mar 2021 17:01:29 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 128GxNRl057490; Mon, 8 Mar 2021 17:00:36 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 373y8bmeav-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Mar 2021 17:00:36 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 128GfNEk100728; Mon, 8 Mar 2021 17:00:36 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by aserp3030.oracle.com with ESMTP id 374kamfwjf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Mar 2021 17:00:35 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BYAPR10MB3623.namprd10.prod.outlook.com (2603:10b6:a03:11b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Mon, 8 Mar 2021 17:00:32 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3912.027; Mon, 8 Mar 2021 17:00:32 +0000 Received: from [10.74.106.64] (138.3.200.0) by CY4PR13CA0001.namprd13.prod.outlook.com (2603:10b6:903:32::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.13 via Frontend Transport; Mon, 8 Mar 2021 17:00:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 455198c9-936b-42f0-a339-6da0a3d83298 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=daP0eS7DKjw/+pNTAUvjnxRcOnE0s9+Kg1bQ2QfZFvQ=; b=Tf72KW67Hruyro+3yrwVR7JGVVfILROicbkT09l1ue79/MkfaVU23Px9s4ZCMxdcXBKU z/u78PHcNVmTmXEv2hbu8YWlzB8Pkndg6uZ9VS/7Yr07RCkxQ/cOjvytKv0zKTLrWtbY 3gd3rGM7Ktx+Y/WegHX9CDCZRso00fqDHUz+zrkpyLFCoLUu3zs0JjoOpgrPC/EOTAh2 nKD0QvIrgyTJCUdS5WeKwX2RWht5EBqHMu0i30HuuIQf3wCGrTlkeVZSSTHf1rV150sI 6ZYtma0YhnX4SLYJyu1baCnrAAJsASpi0tBmHeYeWNIY691I+C46rFj70jInHmujGV+3 cA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KGbEHjBQcyzj4p+XG5VXrDnnfUFQX7Pp3MW0HZeE+el3k7Km8MhD9iHPXEpUh0uNM+pITh+c1nb//W3gioi6f841eRzqXykBlgmlrvkCoWifwwSmgoQvNGujVOODFfRujxsMnl6i3Nrfk1ioGlddgURHxsCM/nWrLVL2K7bVwll+6Evf7QsKAkjgqdoHwhev/+T6T9HAMand+4Wk5oPUIE2kKYYyjyahM+O9tC05Lg8Pln7ERt/+RKbCzues8WHA22Mqm7EN3bqmq721lUdEzBaSs9Rm2MEazs59Nyj102pZdLCT2MHDRo36gaH9QYy8iZasQI1DT//DAKjywpRQ6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=daP0eS7DKjw/+pNTAUvjnxRcOnE0s9+Kg1bQ2QfZFvQ=; b=m1P2AaIvtGUwgLt6GQ86H86jFrM2VZEZvUuRK17LMZj9Hm8Ez2yW0HB8BDZbdCTp+HJsNgZ7W63xHlEq/DsVpDltQXmkkV9PSnh1Td9jV4btMK08B5dMcX1JRbBTKeR3J64dpLnh6XNO4NrSguUBWkNxE4b+FcGhpYwVXEr4Qf9JZy+UZG1uZbKxCJ//yY5n/AILKAvoVARv8WEPaLFNsV8sq4qsT7KoBjmkMP/qJjfAbp2kxKG2RnIFitaE+cONBpgFrzG7I97U4ec8SvbuJriTtdCE3kqD/EokLc2cR7A6Bjjc4RXDuKq6E6qFsRFhD/kyxJaFW4jOd4AD8AuHyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=daP0eS7DKjw/+pNTAUvjnxRcOnE0s9+Kg1bQ2QfZFvQ=; b=htozUCEAjFfE0/gb/XutOnzachwvCOX5xpgDfMHJi5T3iEtporhvPp/bDnLnfIlzFDSp9VisGEKr0y9fQgp5t9Ak/x6T04voJHKElgxIOsoDAS4VgQSL+toG6ZasNFYfBeu19HLwPaftbt8HQE6ghj+bcOy+SWus7+rppvKrsaQ= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH v5 02/12] x86/paravirt: switch time pvops functions to use static_call() To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org Cc: Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini References: <20210308122844.30488-1-jgross@suse.com> <20210308122844.30488-3-jgross@suse.com> From: Boris Ostrovsky Message-ID: <1346dbb1-c43e-9ac2-10e4-3c10cb2ead78@oracle.com> Date: Mon, 8 Mar 2021 12:00:23 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <20210308122844.30488-3-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [138.3.200.0] X-ClientProxiedBy: CY4PR13CA0001.namprd13.prod.outlook.com (2603:10b6:903:32::11) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b5981fe8-a9cd-4ab8-e923-08d8e253af24 X-MS-TrafficTypeDiagnostic: BYAPR10MB3623: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:421; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cS3pYGo0LzcDgP8l9RlxY7mtDqW/DVw9sllgD/KZalTVFgFUzYEVrVfqZzUMxzzqGv/xpTMhAi06k2QYibB8vngdmqP1u2gcK9rK2JfuzmlpEYdPyoAKBnFzB8X3RRvhKen+cRwD8KetmemkNb5cx90VdoyiCz1jbkMmrgC3Ig85lIu65vYoaRE51V5zI/8gTxhVZjKhmu5v8RBAuxh2dyWQPtW7i2aKxPGlXYTkYY1Hye1WkUbEPfHVZpc1VWJ6yHGs1Pueht4nyXXkGjeyrdTjd2Ot5hRQHUVR50tAQoO2nVABFFmTVVcIBSlNG7siTplTfOzi0s+QUCKcED1D3fv99C2eCD9SlWn4j/qEJandVW6pzpbsthsHKw5JTlYWxw78M4No2qkQ46SQ2pC+5d8y3nYIh1ef6uxgeJ6JKy01b3tsTR7p7wKEKwZMoGX9yZibqPwrruB5hdnIdp0RGGmop3XJmHHgnZdNuU8uXW1sAQywHWfoK1+TA6CKepoKj9EitxhgLchBKKALJl/2R5MHEEme5lUZ3ISoOJXaiKVOb8Zf2ODPfaR9H0C0ltKf8/hGunAgsT64tde9HlXMWjmBxC8Lk6amSybzxR48lnc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(366004)(39860400002)(396003)(136003)(346002)(36756003)(83380400001)(2906002)(956004)(86362001)(2616005)(53546011)(6486002)(4326008)(316002)(16576012)(7416002)(31696002)(44832011)(66476007)(8936002)(8676002)(66946007)(478600001)(54906003)(6666004)(5660300002)(31686004)(186003)(26005)(16526019)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UWZpUE44TVZCUEp0Vng5TFdnRUtwbTZxVUN4VzdKK3oreUpXS053RmN5Y3F6?= =?utf-8?B?NSt4VTF1SUxlS2NBYlJYaVU4eVIwZFBCWEU4aGlyaWVoZG1VNWRIUXNuSjR5?= =?utf-8?B?aE9CdW5zVE5kU0ZRVW1rTFVWQWhtL1ZQVzUrMHhkaTc5ZlNJUndUT0t5VDhG?= =?utf-8?B?ZWNrYVJnM3dPdVV6SEs2NmszQkZXYU0vc1RPdWU1aytBL0pBYk1VZWVwdmNP?= =?utf-8?B?aCtNck5ubFljRjJPa1hXWTFBaGIwamlDdmxUaVpJdnZwWUMrQ1B3dDJVTFFy?= =?utf-8?B?NlpnRUxWdkdvcEJ2UTVxMnd5QUppVm9IQ1YxQVVTZUhaMFY1QkhNUFlWYmFx?= =?utf-8?B?eXlmUDcvQTMzUXFpZVZVaGVXN1VXTFMyWG80M3puSno0aUF2dFo3ekJhOXJM?= =?utf-8?B?bHU3QStIVnM0RGU2V2k5Y2NDem4zNlk0UWJEeEVUUkZhTVFKZnEzUmRPNG9r?= =?utf-8?B?amRab2xkS1hFeTdnRVVqd1BsclE2cEZXQnlHY2xHMi93ZU1XQTBkczYzMGhP?= =?utf-8?B?eUdBOEl0akJJbEJBQXhIRnN1WVZBQTMzbW9LV2FOM3ZTTGF4L1lqS2dScUN0?= =?utf-8?B?TE5pRFRXcUJ5TzJteWpMZnBheEhuWkJ1RmN3SnBzYzJGeGIybm5TWUVtSkFv?= =?utf-8?B?bDdwSzVSYkhzd04vR1JJaXU2YUtqOUFQZk5QUVVqNFluellJN2xOYjZIdVZo?= =?utf-8?B?dzdXaDJZNzBINDNQZll1MElHU0xzZmgzaXc2NlBiR3hPOWdOcVE4YW9zYy9P?= =?utf-8?B?Vk1GenRvNUd4aGl3VmdiRHMvMEVKRnp1N2g5Sk1RUU81Vi90Qk15QUhZeTlE?= =?utf-8?B?STh3Y0o4b3FoZGJzUG5XNTVDVkFXaG16ZjZKL3Vjbno5ZFloajNyVWVDVFhN?= =?utf-8?B?aTRSbHJzM3hYbnBZYWpFU00wcTVxYmpoSEVmcFczUkdFSXhyejI5MkhmdWtD?= =?utf-8?B?alBwRWRiK05JbWJQWU9wRFVvRWMxSnRPdm80MzgxVzlRQlRWSG9vc3FtbTM3?= =?utf-8?B?K3cwV3ZESUdYNUQxQ0VVWStqYUJRMlE4U3NiQXNINFh4WXppcjA2RDRSbi90?= =?utf-8?B?Yno2b3NPd1VXUmpiYmRyZTVXaWN5V2JDOXdGT3NhQUFMMjVCRGVSdXNsU0tw?= =?utf-8?B?UFExUVhENGlISHlJaklVZ0lFMm1Wdkt0SUIveEhOdTgreFV4c2RtVHdmNW04?= =?utf-8?B?TUs1cWlFNkVEalNud3dLTXRGVHgzMHYrT0htUTNTN09zOGRwdFVwUTNJbUtP?= =?utf-8?B?eGx3dkJoVFFaV0QycDBwZWJNTExBU256dlh1RlFkWlhaSzZUWUZrMnFUcERj?= =?utf-8?B?eVplVmhGVW51STlWb0ZsZkRmblRIczRSbi9HWmIzYXh4UVp2dkFHcks0WThQ?= =?utf-8?B?ZXNXUk04ZzMyWUxISjVpV2k0Qy8yZTJLVzhJSDNDSENkMGRka1hUc3BjRmt4?= =?utf-8?B?N3BHNTVCQ2tZWE14YlZiMkEyZml1dW5YYTcvcHA5QThWb3dKd0U5ZWFjN2J5?= =?utf-8?B?SXRERnBoVGNiQ2dYMllzakdCditTTFNnTjVxMXdCRVgyWlVCWUtIelBtcWt3?= =?utf-8?B?MCtWZE5tSGN2Q3RBZlhFemNZL1dSM3VuVzR0SUdacFpFZlhCYnlxTnp5OGNn?= =?utf-8?B?U3lFaW5PeFErbnRXK3crV1ZwdFZhN3NpM2pFL0hIQkhsN3ZTRE1WNjFKdHk4?= =?utf-8?B?ZSt0U3g0YzJVc1RYZzhBc0c4RG9pTlI0dFlNYkxidUNxcE04TC9yNjBTTVpT?= =?utf-8?Q?LxKckNeFRJLZ38qfQawI37569PSfnti8G2l/l9R?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5981fe8-a9cd-4ab8-e923-08d8e253af24 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 17:00:32.4478 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HqPVK0PEqOWnpekBDlvbA8ahaoYNkpUO2xCgO4pw+xKii5mgPptubRFRvsamml33WsHg1hmVk60FiPEiR/ydG+6SElOaVmgmUOk3ok949y8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3623 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9917 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103080090 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9917 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1011 mlxscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 adultscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103080091 On 3/8/21 7:28 AM, Juergen Gross wrote: > --- a/arch/x86/xen/time.c > +++ b/arch/x86/xen/time.c > @@ -379,11 +379,6 @@ void xen_timer_resume(void) > } > } > > -static const struct pv_time_ops xen_time_ops __initconst = { > - .sched_clock = xen_sched_clock, > - .steal_clock = xen_steal_clock, > -}; > - > static struct pvclock_vsyscall_time_info *xen_clock __read_mostly; > static u64 xen_clock_value_saved; > > @@ -528,7 +523,8 @@ static void __init xen_time_init(void) > void __init xen_init_time_ops(void) > { > xen_sched_clock_offset = xen_clocksource_read(); > - pv_ops.time = xen_time_ops; > + static_call_update(pv_steal_clock, xen_steal_clock); > + paravirt_set_sched_clock(xen_sched_clock); > > x86_init.timers.timer_init = xen_time_init; > x86_init.timers.setup_percpu_clockev = x86_init_noop; > @@ -570,7 +566,8 @@ void __init xen_hvm_init_time_ops(void) > } > > xen_sched_clock_offset = xen_clocksource_read(); > - pv_ops.time = xen_time_ops; > + static_call_update(pv_steal_clock, xen_steal_clock); > + paravirt_set_sched_clock(xen_sched_clock); > x86_init.timers.setup_percpu_clockev = xen_time_init; > x86_cpuinit.setup_percpu_clockev = xen_hvm_setup_cpu_clockevents; There is a bunch of stuff that's common between the two cases so it can be factored out. > > diff --git a/drivers/xen/time.c b/drivers/xen/time.c > index 108edbcbc040..152dd33bb223 100644 > --- a/drivers/xen/time.c > +++ b/drivers/xen/time.c > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -175,7 +176,7 @@ void __init xen_time_setup_guest(void) > xen_runstate_remote = !HYPERVISOR_vm_assist(VMASST_CMD_enable, > VMASST_TYPE_runstate_update_flag); > > - pv_ops.time.steal_clock = xen_steal_clock; > + static_call_update(pv_steal_clock, xen_steal_clock); > Do we actually need this? We've already set this up in xen_init_time_ops(). (But maybe for ARM). -boris > static_key_slow_inc(¶virt_steal_enabled); > if (xen_runstate_remote) From xen-devel-bounces@lists.xenproject.org Mon Mar 08 17:18:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 17:18:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95035.179232 (Exim 4.92) (envelope-from ) id 1lJJWj-00023t-Tg; Mon, 08 Mar 2021 17:18:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95035.179232; Mon, 08 Mar 2021 17:18:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJJWj-00023m-Qh; Mon, 08 Mar 2021 17:18:41 +0000 Received: by outflank-mailman (input) for mailman id 95035; Mon, 08 Mar 2021 17:18:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJJWh-00023h-T5 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 17:18:39 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 90b721a6-bf77-4706-a9d2-c7fd849cce55; Mon, 08 Mar 2021 17:18:39 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF1ADD6E; Mon, 8 Mar 2021 09:18:38 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 091833F71B; Mon, 8 Mar 2021 09:18:37 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90b721a6-bf77-4706-a9d2-c7fd849cce55 From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH] xen/arm: Use register_t type in cpuinfo entries Date: Mon, 8 Mar 2021 17:18:19 +0000 Message-Id: X-Mailer: git-send-email 2.17.1 All cpu identification registers that we store in the cpuinfo structure are 64bit on arm64 and 32bit on arm32 so storing the values in 32bit on arm64 is removing the higher bits which might contain information in the future. This patch is changing the types in cpuinfo to register_t (which is 32bit on arm32 and 64bit on arm64) and adding the necessary paddings inside the unions. It is also fixing all prints using directly the bits values from cpuinfo to use PRIregister and adapt the printed value to print all bits available on the architecture. Signed-off-by: Bertrand Marquis --- xen/arch/arm/setup.c | 17 ++++++++-------- xen/arch/arm/smpboot.c | 3 ++- xen/include/asm-arm/cpufeature.h | 34 +++++++++++++++++++++----------- 3 files changed, 34 insertions(+), 20 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 2532ec9739..9ba2f267f6 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -116,8 +116,8 @@ static void __init processor_id(void) printk("Huh, cpu architecture %x, expected 0xf (defined by cpuid)\n", c->midr.architecture); - printk("Processor: %08"PRIx32": \"%s\", variant: 0x%x, part 0x%03x, rev 0x%x\n", - c->midr.bits, implementer, + printk("Processor: %"PRIregister": \"%s\", variant: 0x%x, part 0x%03x," + "rev 0x%x\n", c->midr.bits, implementer, c->midr.variant, c->midr.part_number, c->midr.revision); #if defined(CONFIG_ARM_64) @@ -163,7 +163,7 @@ static void __init processor_id(void) if ( cpu_has_aarch32 ) { printk("32-bit Execution:\n"); - printk(" Processor Features: %08"PRIx32":%08"PRIx32"\n", + printk(" Processor Features: %"PRIregister":%"PRIregister"\n", boot_cpu_data.pfr32.bits[0], boot_cpu_data.pfr32.bits[1]); printk(" Instruction Sets:%s%s%s%s%s%s\n", cpu_has_aarch32 ? " AArch32" : "", @@ -176,15 +176,16 @@ static void __init processor_id(void) cpu_has_gentimer ? " GenericTimer" : "", cpu_has_security ? " Security" : ""); - printk(" Debug Features: %08"PRIx32"\n", + printk(" Debug Features: %"PRIregister"\n", boot_cpu_data.dbg32.bits[0]); - printk(" Auxiliary Features: %08"PRIx32"\n", + printk(" Auxiliary Features: %"PRIregister"\n", boot_cpu_data.aux32.bits[0]); - printk(" Memory Model Features: " - "%08"PRIx32" %08"PRIx32" %08"PRIx32" %08"PRIx32"\n", + printk(" Memory Model Features: %"PRIregister" %"PRIregister"\n" + " %"PRIregister" %"PRIregister"\n", boot_cpu_data.mm32.bits[0], boot_cpu_data.mm32.bits[1], boot_cpu_data.mm32.bits[2], boot_cpu_data.mm32.bits[3]); - printk(" ISA Features: %08x %08x %08x %08x %08x %08x\n", + printk(" ISA Features: %"PRIregister" %"PRIregister" %"PRIregister"\n" + " %"PRIregister" %"PRIregister" %"PRIregister"\n", boot_cpu_data.isa32.bits[0], boot_cpu_data.isa32.bits[1], boot_cpu_data.isa32.bits[2], boot_cpu_data.isa32.bits[3], boot_cpu_data.isa32.bits[4], boot_cpu_data.isa32.bits[5]); diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index cae2179126..ea0dd3451e 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -321,7 +321,8 @@ void start_secondary(void) if ( !opt_hmp_unsafe && current_cpu_data.midr.bits != boot_cpu_data.midr.bits ) { - printk(XENLOG_ERR "CPU%u MIDR (0x%x) does not match boot CPU MIDR (0x%x),\n" + printk(XENLOG_ERR "CPU%u MIDR (0x%"PRIregister") does not match boot " + "CPU MIDR (0x%"PRIregister"),\n" "disable cpu (see big.LITTLE.txt under docs/).\n", smp_processor_id(), current_cpu_data.midr.bits, boot_cpu_data.midr.bits); diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h index 9ea3970c70..ba48db3eac 100644 --- a/xen/include/asm-arm/cpufeature.h +++ b/xen/include/asm-arm/cpufeature.h @@ -118,13 +118,16 @@ int enable_nonboot_cpu_caps(const struct arm_cpu_capabilities *caps); */ struct cpuinfo_arm { union { - uint32_t bits; + register_t bits; struct { unsigned long revision:4; unsigned long part_number:12; unsigned long architecture:4; unsigned long variant:4; unsigned long implementer:8; +#ifdef CONFIG_ARM_64 + unsigned long _res0:32; +#endif }; } midr; union { @@ -148,7 +151,7 @@ struct cpuinfo_arm { #ifdef CONFIG_ARM_64 /* 64-bit CPUID registers. */ union { - uint64_t bits[2]; + register_t bits[2]; struct { /* PFR0 */ unsigned long el0:4; @@ -179,15 +182,15 @@ struct cpuinfo_arm { } pfr64; struct { - uint64_t bits[2]; + register_t bits[2]; } dbg64; struct { - uint64_t bits[2]; + register_t bits[2]; } aux64; union { - uint64_t bits[3]; + register_t bits[3]; struct { unsigned long pa_range:4; unsigned long asid_bits:4; @@ -213,7 +216,7 @@ struct cpuinfo_arm { } mm64; union { - uint64_t bits[2]; + register_t bits[2]; struct { /* ISAR0 */ unsigned long __res0:4; @@ -263,7 +266,7 @@ struct cpuinfo_arm { * when running in 32-bit mode. */ union { - uint32_t bits[3]; + register_t bits[3]; struct { /* PFR0 */ unsigned long arm:4; @@ -274,6 +277,9 @@ struct cpuinfo_arm { unsigned long amu:4; unsigned long dit:4; unsigned long ras:4; +#ifdef CONFIG_ARM_64 + unsigned long __res0:32; +#endif /* PFR1 */ unsigned long progmodel:4; @@ -284,29 +290,35 @@ struct cpuinfo_arm { unsigned long sec_frac:4; unsigned long virt_frac:4; unsigned long gic:4; +#ifdef CONFIG_ARM_64 + unsigned long __res1:32; +#endif /* PFR2 */ unsigned long csv3:4; unsigned long ssbs:4; unsigned long ras_frac:4; unsigned long __res2:20; +#ifdef CONFIG_ARM_64 + unsigned long __res3:32; +#endif }; } pfr32; struct { - uint32_t bits[2]; + register_t bits[2]; } dbg32; struct { - uint32_t bits[1]; + register_t bits[1]; } aux32; struct { - uint32_t bits[6]; + register_t bits[6]; } mm32; struct { - uint32_t bits[7]; + register_t bits[7]; } isa32; struct { -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 17:30:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 17:30:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95039.179250 (Exim 4.92) (envelope-from ) id 1lJJhX-000349-3u; Mon, 08 Mar 2021 17:29:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95039.179250; Mon, 08 Mar 2021 17:29:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJJhX-000342-0N; Mon, 08 Mar 2021 17:29:51 +0000 Received: by outflank-mailman (input) for mailman id 95039; Mon, 08 Mar 2021 17:29:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJJhW-00033w-8x for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 17:29:50 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 63bd0c7d-db59-4ed4-885b-2095bf1a5a0b; Mon, 08 Mar 2021 17:29:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63bd0c7d-db59-4ed4-885b-2095bf1a5a0b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615224588; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Qx692fbHiRL4L6T+MZfu9C8g3d1iJXU8ETMMmyC4JAk=; b=Y9h7/qd+AvVqFdw0VoO9yzYdgz88qVe7wICX8Z1nPNFv86/OItWH8td3 tBWdTqUxxEk1k9thX1TP0XtVUGxyoixv+ZvR4MUK/3374+q3QfImfUPNd cs/1xRkiVWyHyQaHAtjOtm3G1sw9Zzg9HROPEI2SqUNzyEc4ndJgdVFBx 4=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: j20KibSo3L8aG0dbglfkza8MpIL91Sk0L4AOpy/JSV8rb0P6eO/qFqdpeft2WyX7Gm8rqtfH0w +E16GcrD3X9FLrloQJJvApoXQXmmSvVZvW6uHtVTHlYFX0SiICk/06GkLDyR1hJQRRUYppN+zw WE3dm19Wv6Q4dOtqQ/gIdOp/rhZbPb49nJNTtKKeKSBkf/ur68+YrBTDr+T2eY4f3OcXKBAlbN XUjo5LlEcTmDelLt1tIYGcyxGSt7m4CyWjcnINYLXBlAkcXVGPD+o0zFYesd3WFAsSu3Z9U3jA 5Uo= X-SBRS: 4.0 X-MesageID: 38785020 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,232,1610427600"; d="scan'208";a="38785020" Date: Mon, 8 Mar 2021 17:29:40 +0000 From: Anthony PERARD To: Paolo Bonzini CC: , Stefan Hajnoczi , Maxim Levitsky , Stefano Stabellini , Paul Durrant , Kevin Wolf , Max Reitz , , Subject: Re: [PATCH] xen-block: Fix removal of backend instance via xenstore Message-ID: References: <20210308143232.83388-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Mon, Mar 08, 2021 at 03:38:49PM +0100, Paolo Bonzini wrote: > On 08/03/21 15:32, Anthony PERARD wrote: > > From: Anthony PERARD > > > > Whenever a Xen block device is detach via xenstore, the image > > associated with it remained open by the backend QEMU and an error is > > logged: > > qemu-system-i386: failed to destroy drive: Node xvdz-qcow2 is in use > > > > This happened since object_unparent() doesn't immediately frees the > > object and thus keep a reference to the node we are trying to free. > > The reference is hold by the "drive" property and the call > > xen_block_drive_destroy() fails. > > > > In order to fix that, we call drain_call_rcu() to run the callback > > setup by bus_remove_child() via object_unparent(). > > > > Fixes: 2d24a6466154 ("device-core: use RCU for list of children of a bus") > > > > Signed-off-by: Anthony PERARD > > --- > > CCing people whom introduced/reviewed the change to use RCU to give > > them a chance to say if the change is fine. > > If nothing else works then I guess it's okay, but why can't you do the > xen_block_drive_destroy from e.g. an unrealize callback? I'm not sure if that's possible. xen_block_device_create/xen_block_device_destroy() is supposed to be equivalent to do those qmp commands: blockdev-add node-name=xvdz-qcow2 driver=qcow2 file={"driver":"file","filename":"disk.qcow2","locking":"off"} device_add id=xvdz driver=xen-disk vdev=xvdz drive=xvdz-qcow2 But I tried to add a call xen_block_drive_destroy from xen_block_unrealize, but that still is called too early, it's called before object_property_del_all() which would delete "drive" and call release_drive() which would free the node. So, no, I don't think we can use an unrealized callback. I though of trying to delete the "drive" property ahead of calling object_unparent() but I didn't figure out how to do so and it's maybe not possible. So either drain_call_rcu or adding call_rcu(xen_block_drive_destroy) seems to be the way, but since xen_block_drive_destroy uses qmp_blockdev_del, it seems better to drain_call_rcu. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Mar 08 17:37:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 17:37:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95044.179262 (Exim 4.92) (envelope-from ) id 1lJJpD-00043C-0y; Mon, 08 Mar 2021 17:37:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95044.179262; Mon, 08 Mar 2021 17:37:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJJpC-000435-U8; Mon, 08 Mar 2021 17:37:46 +0000 Received: by outflank-mailman (input) for mailman id 95044; Mon, 08 Mar 2021 17:37:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJJpB-000430-CV for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 17:37:45 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [63.128.21.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 50749cd7-21c1-4a59-9839-659a1d228950; Mon, 08 Mar 2021 17:37:43 +0000 (UTC) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-532-9U2BNParM3Wj-_MSG6iQUw-1; Mon, 08 Mar 2021 12:37:41 -0500 Received: by mail-wr1-f69.google.com with SMTP id m9so5137951wrx.6 for ; Mon, 08 Mar 2021 09:37:41 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id x11sm48333wmi.3.2021.03.08.09.37.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Mar 2021 09:37:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50749cd7-21c1-4a59-9839-659a1d228950 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615225063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p41WGjEacJEZdK8ZYq3XjUoXvCwhJJPKYlyQ0ak6UEc=; b=KYOFLG4Oyhxt5dXBslaNpPfqfEpNSYWHNcR07HE4ktorXNzCJ8Bc4qr5aPeQrVAv5PKxZq PYuPScG4zj6tCKfx6BJhci40H6FvwiRfcE2fShxz/tIsHu49kZYeuYFWKH1K+MAP8EIU/t XY62obogsq4qkFUm4A5yAhkoF7wV0q4= X-MC-Unique: 9U2BNParM3Wj-_MSG6iQUw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=p41WGjEacJEZdK8ZYq3XjUoXvCwhJJPKYlyQ0ak6UEc=; b=iNeqLjN1SJvuQRmU6yqGhieaTpsJYjC78B/hrsVFQujbfvWkOiDoq5AqEfeRwJJx0M QPwxx4uX4wD2byh/f4PNrN9vn8kvV1BCYKeoGQDflip8fMslGc9dt0hKMnT3NetGCza+ eU2c7zRqiUn4f5SKtaSCBz4WiygmBJyXsYQl5JnTKIx8gs40LSOVEuUxoJgY/Lv6ll40 T3h6Ck+bKkR0z9CBmfKyCr5qR1jJYK/lSTxO7sCPpdFpU6ENBJOylPIWBblpYZULQqhZ DMBItqudqpoqQQe7PsQ343f8q6WyrFIUle80CxprrDO2mRwUShHSo+qVdH1claqvcYPx bWbg== X-Gm-Message-State: AOAM531hwinooBet/8zPFWSDO0tiK3VpiaM6sNAXmjjHnqTCzJLmlT7P 9W+7Zf12Z/Nw7jJkah8+5P3PIYMB0fXB6fzhthfewKQUtSdpeCSqh4Wdyza9jaXctOoGDrYhMho adNdTdy1s0FSsXyPePTAZHulub4Y= X-Received: by 2002:a1c:7ed4:: with SMTP id z203mr22293797wmc.89.1615225060145; Mon, 08 Mar 2021 09:37:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwSmeB2dN1zdzZxpYGd58BfcLPchN7Pxl2J6J/U+2DLSVH+Yxp2L3UWoLJmud3lu/op6qFQJQ== X-Received: by 2002:a1c:7ed4:: with SMTP id z203mr22293783wmc.89.1615225059934; Mon, 08 Mar 2021 09:37:39 -0800 (PST) Subject: Re: [PATCH] xen-block: Fix removal of backend instance via xenstore To: Anthony PERARD Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Maxim Levitsky , Stefano Stabellini , Paul Durrant , Kevin Wolf , Max Reitz , xen-devel@lists.xenproject.org, qemu-block@nongnu.org References: <20210308143232.83388-1-anthony.perard@citrix.com> From: Paolo Bonzini Message-ID: Date: Mon, 8 Mar 2021 18:37:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/03/21 18:29, Anthony PERARD wrote: >> If nothing else works then I guess it's okay, but why can't you do the >> xen_block_drive_destroy from e.g. an unrealize callback? > > I'm not sure if that's possible. > > xen_block_device_create/xen_block_device_destroy() is supposed to be > equivalent to do those qmp commands: > blockdev-add node-name=xvdz-qcow2 driver=qcow2 file={"driver":"file","filename":"disk.qcow2","locking":"off"} > device_add id=xvdz driver=xen-disk vdev=xvdz drive=xvdz-qcow2 > > But I tried to add a call xen_block_drive_destroy from > xen_block_unrealize, but that still is called too early, it's called > before object_property_del_all() which would delete "drive" and call > release_drive() which would free the node. Can you use blockdev_mark_auto_del? Then you don't have to call xen_block_drive_destroy at all. Paolo > So, no, I don't think we can use an unrealized callback. > > I though of trying to delete the "drive" property ahead of calling > object_unparent() but I didn't figure out how to do so and it's maybe > not possible. > > So either drain_call_rcu or adding call_rcu(xen_block_drive_destroy) > seems to be the way, but since xen_block_drive_destroy uses > qmp_blockdev_del, it seems better to drain_call_rcu. > > Cheers, > From xen-devel-bounces@lists.xenproject.org Mon Mar 08 18:15:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 18:15:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95048.179274 (Exim 4.92) (envelope-from ) id 1lJKPI-0007Zj-Vj; Mon, 08 Mar 2021 18:15:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95048.179274; Mon, 08 Mar 2021 18:15:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJKPI-0007Zc-SZ; Mon, 08 Mar 2021 18:15:04 +0000 Received: by outflank-mailman (input) for mailman id 95048; Mon, 08 Mar 2021 18:15:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJKPG-0007ZX-OD for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 18:15:02 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3a354599-bddc-427c-915e-ff19db3feb0b; Mon, 08 Mar 2021 18:15:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a354599-bddc-427c-915e-ff19db3feb0b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615227301; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rZ4SkJ8X/hZwpDyh0viVcvZuGzds7uuy62Q7Mz9ot+U=; b=IaP4SEihgbztyUnj1BnTELaIhDMemtx9NnksisVmA2UtX8zxm+oUDMgA d1sEyoQnmkfOEhZ85A9Khl6tfQ+jFcqBiE2kHLnPoaFxPm63qUQ59pNQp cgfOVaNRjdPy2nfSKpphQn1txNmrf20U+LDW9KOwMmrTzJwjA/y95KgWP 0=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 0Lwi/BiZvEKSYUpO4VUtOzP8Xl9lnKx28tjjXCjF5Mijex70y0RpnhpPGpQ+jJbw1UBVxbqUL/ XTUO1MnMS5llggK97NFZoFvhT14AdgR5KQJfgW3sADiRXBzolZoJK8SSIrtGx/xnUwBIY+YVLn 4JOQyle+GUEQi99v/XqgGV203q88/oUrwDz0s4LKmbT6vAKQiTTPFDgfKImR/Bn5x87yNnGlPB OBil9M77fkt/slfs6gCzYRFrYjgICVc9/32WlgNQsr4S49V3poUN9OBa5fD47yEndne28W+NKR DpI= X-SBRS: 4.0 X-MesageID: 38789155 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,232,1610427600"; d="scan'208";a="38789155" Date: Mon, 8 Mar 2021 18:14:56 +0000 From: Anthony PERARD To: Paolo Bonzini CC: , Stefan Hajnoczi , "Maxim Levitsky" , Stefano Stabellini , Paul Durrant , Kevin Wolf , Max Reitz , , Subject: Re: [PATCH] xen-block: Fix removal of backend instance via xenstore Message-ID: References: <20210308143232.83388-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Mon, Mar 08, 2021 at 06:37:38PM +0100, Paolo Bonzini wrote: > On 08/03/21 18:29, Anthony PERARD wrote: > > > If nothing else works then I guess it's okay, but why can't you do the > > > xen_block_drive_destroy from e.g. an unrealize callback? > > > > I'm not sure if that's possible. > > > > xen_block_device_create/xen_block_device_destroy() is supposed to be > > equivalent to do those qmp commands: > > blockdev-add node-name=xvdz-qcow2 driver=qcow2 file={"driver":"file","filename":"disk.qcow2","locking":"off"} > > device_add id=xvdz driver=xen-disk vdev=xvdz drive=xvdz-qcow2 > > > > But I tried to add a call xen_block_drive_destroy from > > xen_block_unrealize, but that still is called too early, it's called > > before object_property_del_all() which would delete "drive" and call > > release_drive() which would free the node. > > Can you use blockdev_mark_auto_del? Then you don't have to call > xen_block_drive_destroy at all. There is no legacy_dinfo, so blockdev_mark_auto_del doesn't work. -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Mar 08 18:23:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 18:23:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95052.179286 (Exim 4.92) (envelope-from ) id 1lJKXW-00005c-R6; Mon, 08 Mar 2021 18:23:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95052.179286; Mon, 08 Mar 2021 18:23:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJKXW-00005U-O2; Mon, 08 Mar 2021 18:23:34 +0000 Received: by outflank-mailman (input) for mailman id 95052; Mon, 08 Mar 2021 18:23:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJKXV-00005P-To for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 18:23:33 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [170.10.133.124]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id d2521df5-4b15-4a73-b80d-b0efceb8fa6a; Mon, 08 Mar 2021 18:23:33 +0000 (UTC) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-10-gJGXOK8xP6m9VaDO33iy0g-1; Mon, 08 Mar 2021 13:23:31 -0500 Received: by mail-ej1-f70.google.com with SMTP id en21so4467961ejc.2 for ; Mon, 08 Mar 2021 10:23:30 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id g20sm3594900edb.7.2021.03.08.10.23.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Mar 2021 10:23:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2521df5-4b15-4a73-b80d-b0efceb8fa6a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615227812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+beV17USAk5/5BAoxZtz1DOIIiUvcI4Oae8+UMea5+Y=; b=SXfVnyXNQurjdL9o8vrkWOh1IFZikqhyvIIjQDTbUNCPO+gB+dG0XiLDeWe+IXjuw7YU76 08jlsb6UXJHuU+MRZW603z+CzIzMyxPzBW75a/Oyv6CCPOLbxt+gOP7ijS1mLvKg2GdrBm Hm5MIwDd7JZS8RFTTvSbQTbi29j238E= X-MC-Unique: gJGXOK8xP6m9VaDO33iy0g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+beV17USAk5/5BAoxZtz1DOIIiUvcI4Oae8+UMea5+Y=; b=nFGXaGFBXJm/VxxLHgmEnI6xA7Z1hij015Osnidqmyb0y2Rj4ert7i4qnkBFr81HUb +O4I6yscZ+1X9Xmx12YQ7esbtRCk8Q+sxHJVWqZPiTw/rr6MLI0tjw6cdOdsevwCKWgW ikBtiBCOAS5L8E0g55+ykWBy6Q5zRoIHWV6PgIOt/nPq6FLrO5H/1eHKIGuU6sQmpW7M W7+WxOaTLgDig/3W7bMuCmQbHHdkv6gv47enSRiWnDu/VZ9ShDwNjPFGfYrsADN6O7ub KdkYIYcMrvJgXvjFBJELA8mC8l8fr1JeWAt9uc4gdriLKSGigEo37MxXGUZ2Q472Vp6I 3Z5g== X-Gm-Message-State: AOAM5306F9H+jxBlN4Me6JRosT+DGvNg+0Oih9XGn/IClUcxwmbsPj4V TgIPqo0UKcOaxVglJK07Tf9IS30gd5XdPk73cpLIHFxc4jN362fcmBHzzIXZEKkR8JVinomDaHb mtrLN2tepONBwxGj6acTNzaXktpA= X-Received: by 2002:a17:906:3496:: with SMTP id g22mr16772444ejb.143.1615227809929; Mon, 08 Mar 2021 10:23:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJzAKId/zSgJcT+DGItbtsG8E/vnOhHJ2ijozl9R/7jYQhXBSZmhKlFsHCkaz/FvrTyU93dWVA== X-Received: by 2002:a17:906:3496:: with SMTP id g22mr16772416ejb.143.1615227809730; Mon, 08 Mar 2021 10:23:29 -0800 (PST) Subject: Re: [PATCH] xen-block: Fix removal of backend instance via xenstore To: Anthony PERARD Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Maxim Levitsky , Stefano Stabellini , Paul Durrant , Kevin Wolf , Max Reitz , xen-devel@lists.xenproject.org, qemu-block@nongnu.org References: <20210308143232.83388-1-anthony.perard@citrix.com> From: Paolo Bonzini Message-ID: <59c6ca73-2f26-e0fa-8b17-a319b2cae8f9@redhat.com> Date: Mon, 8 Mar 2021 19:23:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/03/21 19:14, Anthony PERARD wrote: > On Mon, Mar 08, 2021 at 06:37:38PM +0100, Paolo Bonzini wrote: >> On 08/03/21 18:29, Anthony PERARD wrote: >>>> If nothing else works then I guess it's okay, but why can't you do the >>>> xen_block_drive_destroy from e.g. an unrealize callback? >>> >>> I'm not sure if that's possible. >>> >>> xen_block_device_create/xen_block_device_destroy() is supposed to be >>> equivalent to do those qmp commands: >>> blockdev-add node-name=xvdz-qcow2 driver=qcow2 file={"driver":"file","filename":"disk.qcow2","locking":"off"} >>> device_add id=xvdz driver=xen-disk vdev=xvdz drive=xvdz-qcow2 >>> >>> But I tried to add a call xen_block_drive_destroy from >>> xen_block_unrealize, but that still is called too early, it's called >>> before object_property_del_all() which would delete "drive" and call >>> release_drive() which would free the node. >> >> Can you use blockdev_mark_auto_del? Then you don't have to call >> xen_block_drive_destroy at all. > > There is no legacy_dinfo, so blockdev_mark_auto_del doesn't work. Then I guess it's okay. Perhaps you can rename the function to xen_block_blockdev_destroy so that it's clear it's a blockdev and no drive. Thanks, Paolo From xen-devel-bounces@lists.xenproject.org Mon Mar 08 18:31:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 18:31:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95057.179298 (Exim 4.92) (envelope-from ) id 1lJKeq-00013B-LQ; Mon, 08 Mar 2021 18:31:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95057.179298; Mon, 08 Mar 2021 18:31:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJKeq-000134-IA; Mon, 08 Mar 2021 18:31:08 +0000 Received: by outflank-mailman (input) for mailman id 95057; Mon, 08 Mar 2021 18:31:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJKeo-00012x-V2 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 18:31:07 +0000 Received: from mail.skyhub.de (unknown [5.9.137.197]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c8612da2-3f72-4ee1-9b6e-e980253f41a5; Mon, 08 Mar 2021 18:31:05 +0000 (UTC) Received: from zn.tnic (p200300ec2f05ab0000cbc018bb7305ab.dip0.t-ipconnect.de [IPv6:2003:ec:2f05:ab00:cb:c018:bb73:5ab]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 402F51EC0473; Mon, 8 Mar 2021 19:31:04 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8612da2-3f72-4ee1-9b6e-e980253f41a5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1615228264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=R6Ru9203fpURvzmZRq8yn1riFpTQt60U5lcjEmeWKn0=; b=qIptAghnedJcDlkx/F8uwNChFfQEKy4KKBB+5XrfeEuhThKI8g22F1BamxZ83fyPHVx7BX oJvtgVXiR88qxGa+hs5ED0PQMY20AkAWQFP4qF9KJN9vVmYqQYRxNHt7L4UqA57BK0gDxx 1JhtQ+BoV1uLOBTASs1EwTFbeIdf+KM= Date: Mon, 8 Mar 2021 19:30:58 +0100 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Deep Shah , "VMware, Inc." Subject: Re: [PATCH v5 11/12] x86/paravirt: switch functions with custom code to ALTERNATIVE Message-ID: <20210308183058.GC12548@zn.tnic> References: <20210308122844.30488-1-jgross@suse.com> <20210308122844.30488-12-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210308122844.30488-12-jgross@suse.com> On Mon, Mar 08, 2021 at 01:28:43PM +0100, Juergen Gross wrote: > diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h > index 36cd71fa097f..04b3067f31b5 100644 > --- a/arch/x86/include/asm/paravirt.h > +++ b/arch/x86/include/asm/paravirt.h > @@ -137,7 +137,8 @@ static inline void write_cr0(unsigned long x) > > static inline unsigned long read_cr2(void) > { > - return PVOP_CALLEE0(unsigned long, mmu.read_cr2); > + return PVOP_ALT_CALLEE0(unsigned long, mmu.read_cr2, > + "mov %%cr2, %%rax;", ~X86_FEATURE_XENPV); Just some cursory poking first - indepth review later. Do I see this correctly that the negated feature can be expressed with, to use this example here: ALTERNATIVE_TERNARY(mmu.read_cr2, X86_FEATURE_XENPV, "", "mov %%cr2, %%rax;"); ? And then you don't need to touch the patching code for ~feature handling and the flags byte. If you want it syntactically sugared, you can define a separate ALTERNATIVE_NOT macro using ALTERNATIVE_TERNARY... Hmmm. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Mon Mar 08 19:48:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 19:48:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95062.179310 (Exim 4.92) (envelope-from ) id 1lJLrg-0007WW-9v; Mon, 08 Mar 2021 19:48:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95062.179310; Mon, 08 Mar 2021 19:48:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJLrg-0007WP-6i; Mon, 08 Mar 2021 19:48:28 +0000 Received: by outflank-mailman (input) for mailman id 95062; Mon, 08 Mar 2021 19:48:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJLre-0007WJ-Hj for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 19:48:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJLrd-0003cl-5f; Mon, 08 Mar 2021 19:48:25 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJLrc-0006aE-T0; Mon, 08 Mar 2021 19:48:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=SWAW896krNQ7uBnY5aTRSBeZLWYPuMmU5UC6Lez3ZMY=; b=VZVmPdPWlyIBPPWgUMOHTg9RAL DGSDxKqiF5HhfvWK94Jx+OculxGk5Xrh2XE12nr5Iw+a5GUhcqXS3ubm/+sSUE33iQVUrwU2AoVyP qoxtLUOHGRcyuMQKSiOtpfeueza3ztUBnQv+6qCWeMCGqMjZ9Y7nk/Mt8m4zAwsGndvg=; Subject: Re: [PATCH] xen/arm: Use register_t type in cpuinfo entries To: Bertrand Marquis , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk References: From: Julien Grall Message-ID: <712d7c6a-3ace-a6b7-a188-faeb4f1258d3@xen.org> Date: Mon, 8 Mar 2021 19:48:23 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Bertrand, On 08/03/2021 17:18, Bertrand Marquis wrote: > All cpu identification registers that we store in the cpuinfo structure > are 64bit on arm64 and 32bit on arm32 so storing the values in 32bit on > arm64 is removing the higher bits which might contain information in the > future. > > This patch is changing the types in cpuinfo to register_t (which is > 32bit on arm32 and 64bit on arm64) and adding the necessary paddings > inside the unions. I read this as we would replace uint32_t with register_t. However, there are a few instances where you, validly, replace uint64_t with register_t. I would suggest to clarify it in the commit message. > diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c > index cae2179126..ea0dd3451e 100644 > --- a/xen/arch/arm/smpboot.c > +++ b/xen/arch/arm/smpboot.c > @@ -321,7 +321,8 @@ void start_secondary(void) > if ( !opt_hmp_unsafe && > current_cpu_data.midr.bits != boot_cpu_data.midr.bits ) > { > - printk(XENLOG_ERR "CPU%u MIDR (0x%x) does not match boot CPU MIDR (0x%x),\n" > + printk(XENLOG_ERR "CPU%u MIDR (0x%"PRIregister") does not match boot " > + "CPU MIDR (0x%"PRIregister"),\n" For printk messages, we don't tend to split it like that (even for more than 80 characters one). Instead, the preferred approach is: printk(XENLOG_ERR "line 1\n" "line 2\n") The rest of the code looks good to me: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Mar 08 20:22:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 20:22:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95067.179324 (Exim 4.92) (envelope-from ) id 1lJMOk-0002fZ-3m; Mon, 08 Mar 2021 20:22:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95067.179324; Mon, 08 Mar 2021 20:22:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJMOk-0002fS-0i; Mon, 08 Mar 2021 20:22:38 +0000 Received: by outflank-mailman (input) for mailman id 95067; Mon, 08 Mar 2021 20:22:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJMOi-0002fN-SF for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 20:22:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJMOh-0004Fh-Iy; Mon, 08 Mar 2021 20:22:35 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJMOh-0000Ip-7X; Mon, 08 Mar 2021 20:22:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=AfOwlOM+T3YGOLL/G4RnZLxwiAk3QHE9t1SipSE308M=; b=1UJQFRXkZzHoHFZmVvSqHM+K3M u4uutLLl8Z0EzivWyargeeCYHsNK14oSI8ui1wMzYw96HFLJ4xY/+1+47LBiFTqreqSA5tdTbMJ/o xBZj+L0lROdCpeQ9t1HfAKvm3kY2bCyH6YAqzx24l9t1gfjKvU9S2Wo8jUo0kDK3Q57E=; Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) To: Jan Beulich Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210306214148.27021-1-julien@xen.org> <1897022d-7591-3450-4e57-884a2860b13d@suse.com> <7fd07dc9-9c03-bb13-3907-c3c268a4e970@xen.org> <2de5160f-8636-5cdf-a20c-acaa2640c893@suse.com> From: Julien Grall Message-ID: Date: Mon, 8 Mar 2021 20:22:33 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <2de5160f-8636-5cdf-a20c-acaa2640c893@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 08/03/2021 11:20, Jan Beulich wrote: > On 08.03.2021 11:51, Julien Grall wrote: >> On 08/03/2021 08:09, Jan Beulich wrote: >>> On 06.03.2021 22:41, Julien Grall wrote: >>>> From: Julien Grall >>>> >>>> Compilers older than 4.8 have known codegen issues which can lead to >>>> silent miscompilation: >>>> >>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 >>>> >>>> Furthermore, pre-4.9 GCC have known bugs (including things like >>>> internal compiler errors on Arm) which would require workaround (I >>>> haven't checked if we have any in Xen). >>>> >>>> The minimum version of GCC to build the hypervisor is now raised to 4.9. >>>> >>>> In addition to that, on arm64, GCC version >= 4.9 and < 5.1 have been >>>> shown to emit memory references beyond the stack pointer, resulting in >>>> memory corruption if an interrupt is taken after the stack pointer has >>>> been adjusted but before the reference has been executed. >>>> >>>> Therefore, the minimum for arm64 is raised to 5.1. >>> >>> I'm sure newer compiler versions also have bugs. >> >> I don't doubt that... >> >>> Therefore I'm not >>> convinced using this as the primary reason for a bump is enough. >> You also have to take into account the severity of the bug and possible >> workaround. The bug in 5.1 is severe *and* has no easy (to avoid saying >> possible) workaround. >> >>> Plus what if critical to us bugs get found in, say, 5.x? Are we >>> going to bump to 6.x then (and so on, until we allow only the most >>> recent major version to be used)? >> >> In the current situation we are claiming that all GCC versions from >> ~2014 are supported. >> >> However, in reality, there are an high number of chance that some of the >> version will not build Xen or worse miscompile it. >> >> The former kind of bug is not a big deal because the user will notice it >> directly. However, the latter is highly critical because 1) They may >> only happen sporadically 2) compiler related bug is difficult to root cause. > > Since I realize it may not have been clear from my initial reply: > What you want to do for Arm64 is largely up to you. I agree that > the bug in question is really bad. Ah, thanks for the clarification. > I understand it was Andrew who asked you to cover x86 at the same > time, so perhaps it should be more him than you to justify the > choice. Yet you've submitted the patch, so (I'm sorry) there you > go ... As I initially wrote, I don't particularly mind the version for x86. I can split the patch in two to avoid mixing the discussions. > >>> Additionally - partly related to your own reply regarding the CI >>> failures - imo there needs to be an analysis of what older distros >>> will no longer build (at all or by default). >> >> Per the CI, this would be Ubuntu Trusty (and older), Centos 7 (and older) >> >> Do you have any other in mind? > > Our SLE12 (latest service pack is SP5 and still has a while to go > to at least reach LTSS state) comes with gcc 4.8 as the default > compiler. Thanks! That's good to know. Is it the old GCC Suse supports? > >>>> --- >>>> >>>> I don't have a strong opinion on the minimum version for GCC on x86. >>>> So this is following Andrew's suggestion and the minimum from Linux. >>>> >>>> This patch is candidate to 4.15 and backport. >>> >>> I think such a change needs to be proposed much earlier in a release >>> cycle. >> >> Possibly... At the same time, we don't want to release 4.15 and continue >> to say Xen on Arm64 can build fine with 4.9 and 5.0. > > 4.9 could be excluded if need be. 4.8 is fine? I am not entirely sure. The bug I pointed out in the commit message ([1]) seems to affect any GCC version until 4.8. > Also I don't think > there's much point thinking about 5.0 - that's where their version > numbering scheme changed and the first released version is 5.1. Good point. I didn't released that 5.0 never existed. >>>> --- a/xen/include/xen/compiler.h >>>> +++ b/xen/include/xen/compiler.h >>>> @@ -5,6 +5,19 @@ >>>> #error Sorry, your compiler is too old/not recognized. >>>> #endif >>>> >>>> +#if CONFIG_CC_IS_GCC >>>> +# if CONFIG_GCC_VERSION < 40900 >>>> +/* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ >>> >>> As per the bug report, the issue was determined to not be present >>> in e.g. 4.3. Hence while such a bug may influence our choice of >>> minimum version, I don't think it can reasonably be named here as >>> the apparent only reason for the choice. Personally I don't think >>> any justification should be put here. >> >> Ok. >> >>> >>>> +# error Sorry, your version of GCC is too old - please use 4.9 or newer. >>>> +# elif defined(CONFIG_ARM_64) && CONFIG_GCC_VERSION < 50100 >>>> +/* >>>> + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 >>>> + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk >>>> + */ >>>> +# error Sorry, your version of GCC is too old - please use 5.1 or newer. >>> >>> From the bug entry the fix looks to have been backported to 4.9, >>> or at least some (important?) branches thereof. >> >> It is not clear what's you are trying to point out. Mind clarifying? > > Some 4.9 compilers (perhaps widely used ones) may not have the bad > issue, which puts under question their ruling out when the main > reason for doing so is that bug. Well... We could surely try to hunt which GCC 4.9 has been fixed. But I am not convinced this is useful, we would need to have an allowlist of GCC compiler. From my experience, the best way to know if someone care about a specific version is to bump it and see who shout. If no one shout, then you know that it wasn't important. If someone shout, then we can decide how to re-enable support for GCC X.Y. The fact Linux bumped to 5.1 on Arm64 give me some confidence that the move is not risky. I know you may not be happy with my problem, so one possible mitigation is to allow a developer to override the check using Kconfig (maybe gated with UNSUPPORTED/EXPERT). [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Mar 08 20:33:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 20:33:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95077.179340 (Exim 4.92) (envelope-from ) id 1lJMZZ-0003gN-Bd; Mon, 08 Mar 2021 20:33:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95077.179340; Mon, 08 Mar 2021 20:33:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJMZZ-0003gG-8b; Mon, 08 Mar 2021 20:33:49 +0000 Received: by outflank-mailman (input) for mailman id 95077; Mon, 08 Mar 2021 20:33:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJMZX-0003gB-Q0 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 20:33:47 +0000 Received: from userp2120.oracle.com (unknown [156.151.31.85]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c939548a-3423-4033-b9a0-8a1e0a528203; Mon, 08 Mar 2021 20:33:46 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 128KTV7p153061; Mon, 8 Mar 2021 20:33:41 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 3742cn50n6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Mar 2021 20:33:41 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 128KVPfQ103050; Mon, 8 Mar 2021 20:33:41 GMT Received: from nam04-sn1-obe.outbound.protection.outlook.com (mail-sn1nam04lp2054.outbound.protection.outlook.com [104.47.44.54]) by aserp3020.oracle.com with ESMTP id 374kmxfu46-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Mar 2021 20:33:40 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BYAPR10MB2728.namprd10.prod.outlook.com (2603:10b6:a02:b9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Mon, 8 Mar 2021 20:33:39 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3912.027; Mon, 8 Mar 2021 20:33:39 +0000 Received: from [10.74.106.64] (138.3.200.0) by SA0PR13CA0025.namprd13.prod.outlook.com (2603:10b6:806:130::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.22 via Frontend Transport; Mon, 8 Mar 2021 20:33:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c939548a-3423-4033-b9a0-8a1e0a528203 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=sfh4bTAv0pzzVgRm13LxdL0UG9lCgW8MA+UnVFVa5II=; b=D53UHi50/fVZS/Jcz/5qwp7YCiv29LOXYW4LKbKKRn7RVN49aC2zUQ+4LbpGUX6tn2QQ WLFhoaTMNkrcfWiXdh/0EU4ZvZVUcQR5u60QJ/DRILGb797/TrVe5yEjbeZY0sADs49f borj2KQJqxTt9xkah8v3pJP1ZMnMBvWK6HNa2/bOce62QHutc7L+YwsIifY4/79+UsSb hPj8rd5hQ1d6hTMEkg4n+FQJxHgjSudFU9Ynb2J2EKZtn9Ycm5Cwtmek22dzaTZ/eyYN uxpAYVcZtrkG3TKh9N9uqsUdAtUdKF0hl9U2NX1VrrHhui1r00gP/h42xMAQGpwcbB4A Vg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g+0BiV0H2HQJOgOK8QmRlz5ud817vLtBPhMN4Jszh1nBDmj9kPW3eA3EzVcOIGuGdlAaFgsZ1tHPIPY4dKioX+2LEveDwHb9C42YfnAvSYZcZH9YKW7B6oT1juRkuYucrGDr+DM3jtTzt6y3t9c0z/kabHCVzJPkZF1/kRWm+aJz2rqNzPnXJMPML89aVhF6qBi/Ozy6eHWrdqXhzIOGiGN0947Qk31PSWJzkx2vysnTo8RR8XCP7q9sdptqZMEWLHSIZrRf0vMZWNgxy77rBNf6RK0Vjg0R4Q9XlnSeMn4Z2ExE9BUT+8lMwnplM0n3PCZW0jNQDCmW8rFJmYztXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sfh4bTAv0pzzVgRm13LxdL0UG9lCgW8MA+UnVFVa5II=; b=cCb9APGjKrVkBvJzhoTJeUQX5X9iqJ1voTS1NBsmzl4hA5zFShgEyCuCMHlEEw3k3XE3UnWyn3dRQEjX6mGpP5NxefEYEYjs7KNylVDRuWIH1YCjEz3ECdCJylze95kwTo5X33bckaW4qht2I9yrbhqMqUYjMQ87ojQvC8dLfxfR118uGO1ZV1SYHoYnoMOiqG3T84U3Qeue5ylNxCIFW8B6J+NK7b0VGuaXprD/4+lyBBd0UZiNVKyJsHYVdUG/7b7TzpyPrW4ZedInHoN2gE+yr1Q5PbH6yMzsVnPfF7ZVnTNIbhnwD9OS8M5KcDNvbOTtm9OWWDp37VSPmMyhWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sfh4bTAv0pzzVgRm13LxdL0UG9lCgW8MA+UnVFVa5II=; b=wRRhexa8eTzrzBqBSTqLvC9DcJnMI2KnaZA/FNE+QOYcjQKsGMREXs/q8rD+qs+Os465dS25nga10bYZraSz8+At62Kd5kudUrp9RUKepLq+wiy2m1Z5mxhpGze72DBYzKxr1unO7sjqohFewbYD4zJklls6EuxJDM+Bla0F2FI= Authentication-Results: amazon.com; dkim=none (message not signed) header.d=none;amazon.com; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending To: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, ross.lagerwall@citrix.com Cc: Stefano Stabellini , stable@vger.kernel.org, Julien Grall , Julien Grall References: <20210306161833.4552-1-jgross@suse.com> <20210306161833.4552-3-jgross@suse.com> From: Boris Ostrovsky Message-ID: Date: Mon, 8 Mar 2021 15:33:33 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <20210306161833.4552-3-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [138.3.200.0] X-ClientProxiedBy: SA0PR13CA0025.namprd13.prod.outlook.com (2603:10b6:806:130::30) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0c6b90f5-001c-434f-67aa-08d8e27174a1 X-MS-TrafficTypeDiagnostic: BYAPR10MB2728: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2150; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MqrKX6HA9vF+ia18hPRRU99v9ZQz4XXiO3Ih2VhHEn/k2LeFJ9TYGtrXEGUq0P8ocVsEFirUM94WwoMYKuRP8euiXlYo08OP7anRMJo/oUsuSM/fpmX7Jx/YBpVVjgLib0/JOLDE9r8yOeu2+NhGAyZNGlWrLvrdg9fXJaGHkKBm9i20742LSNxy7D1SnCEzNoJZg3a49YyB3Z+jxvhyrfql4rkycGcm8WaPh6ehKyng4A3QPT7D+ei8rauhWYOlu4nBvlJJ6sBOSsgKnEM+mey+p2wmQoZGGSclFhOz8JRG7YD9EJf4ioGt/u7uKUulJYWbyEL0ueEJt0QsbJwNYEBWIOTBnjXJMfHGqms4PE4geUr5TGzMO+AHdw3WBwO1GwMXTaY/urTsJ5oOLAcyfcrf//Q19OxPNSNDZKiaqkj8rb/IWJmjq85n559T6A6aObuO/6kXA4eMC2n3TmC+tvpprNI7tb2SAXW/5+WG8Ck5NZ6xOOvVsUr3KVEZjQF4z6UkdPh5Rxn/J7l4T+6axIM+Zxvsmbq9X/ym88R7entTe5iNp6brwdocRvl9cciGDlfwo5opIvKKokmAroJjoP3fZP19VkbfwzjSzWmb88o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(396003)(376002)(346002)(366004)(39860400002)(956004)(186003)(31696002)(2616005)(478600001)(83380400001)(316002)(66946007)(4326008)(66476007)(66556008)(8936002)(26005)(6666004)(16576012)(16526019)(8676002)(36756003)(54906003)(53546011)(5660300002)(2906002)(31686004)(4744005)(6486002)(86362001)(44832011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?S0hFQ21HUFhZQXp0OE83dnRNdmpuNEV3V0lmYWx1TE5jTUxUTVlPT3BYb1Zn?= =?utf-8?B?SzZ4eWVFSWQxQ0dqajZxWHFHMGJBa1QyREsvcWo1Y2xkM09lZTdyUDhjdFps?= =?utf-8?B?dk9BZHNJNmhmSi9BazBBTXQzK2tPdnlqK2U3djB6M3pPNmM5WmtYaW92TWUv?= =?utf-8?B?VGExR21HWXJEZlFBN2VoeFJKdXMwSlRWZDcrRFRNeWU2M3JSUi9rNGphQ2lm?= =?utf-8?B?bVQ5ZzhWQTRsZVhCSEpPVFo0MXRxNmFFRDFsYmZmM2JMeG92M3B0QllBWW84?= =?utf-8?B?QjV6SHdIb0w2YkFxdkRIQlB2dFphOTRDYkthT0lXdlB2cVBkckxWdVhBOERs?= =?utf-8?B?NFBTQkdmSUFONTFmdnRLQktMMkdsS2I2WmNqcTJwRzdGdmx2cU1mbFVoWFFG?= =?utf-8?B?bFNPY0xSUjFEUEI4NE04UElwMzkxaUM5cUlnOUNBelZuVWR2UmRYN3VJVmN2?= =?utf-8?B?cmFxZ3NuV0UvR1dLb2xXTnF5TWs0UVg3UGgzWUcrdGttZ016QXBHc1VTSWU1?= =?utf-8?B?WXhVZFZTdmpoZnJSenV2R3ZXeVVwUC8rMlR3NlJPWi9UNjVVbk5QbTBLQUgv?= =?utf-8?B?eE9waGVuUHBpbHF1djdQcXU5MVR4UmpGeVR3eHdmZ2ZMdEVTUFkyNmpMb1lN?= =?utf-8?B?T2N4emlZTThSTkE0d0gySXoyMnpteHVRNkJUa0tCbWsvVHl3L0JpQjFYM2FE?= =?utf-8?B?TUY2dTVDZnlVTERLZEt5enduYVhLVlRFMGYveDFaMDU5UUxOdUlNVkhrcDlT?= =?utf-8?B?eFV6QW91L1JoNlptVmZMUHQ3RyszOWx2MHk1dXYwcVI5RHBmYWRGUzVZN1c1?= =?utf-8?B?QmY4TzdFamlWMnVPRlRpRFZ2eHkrdG9YUFY0Q3kvR1FrdzZYRHFUMUJPZkx6?= =?utf-8?B?L0ljZktPTGlUSEpRd2xFaHZjblVIQUpMRGl3UVFPY0JPcmp6TkNJMXZUcU42?= =?utf-8?B?VzZ5cHRMYmhGSis2cUFUR3NjamQvdXR3b0tpV0RPaW9DL2tURVNGZHBmL2FJ?= =?utf-8?B?eVJRT1F0UFRCd1U3K2VCTTVBSzBLaEpaKzl6cmMyWEdMT0ZMQmRPWXJDbkwz?= =?utf-8?B?Zi90eExVWWNUenZOU0FlZlJEQno3bHJxdDB3b0FhdndEZE9XU1JjaDhHbGZB?= =?utf-8?B?cjlqQUtZNm5QcE0wZ2Zvak01WlI5SlgwQy9xWHBmVi84TWhBMkNpdFF3OG9K?= =?utf-8?B?bGVaeDVXRkFxWHREeWtELzJObFI3ZUxGVGNOaFhUMnBrREhKR294NUVwVmdF?= =?utf-8?B?YnBKaDY1ZjlRZ0V2NnNuMXJnUElEUzJQcmdxcTZvODN3UFdHYjI4OW0vZ05t?= =?utf-8?B?UHJIS1FsV3BZSEw1TUlZYkNzTUo1S3BYc2RVUkdOcHVFeER0U09uMG5vcU96?= =?utf-8?B?ZzROazI3SklickhyenZaVnR5cW1YNkt5WStxYmgyZWZOWVMxeFRZd3JTQSt1?= =?utf-8?B?RVlXak1McXdidWY1dURKOHRHcy9nczRVUWlEOVN1Nng2Z2l0MmZZbHNMejVr?= =?utf-8?B?MVBTZ3lidDI0M0hkQzFqTU1RNXhvKzFyNlZXTlNrVGR6a0FCU2ZKM0JqMGtP?= =?utf-8?B?K2N2SzRvTFNQL2dIYlZZOFVGc3VkY2Y3U2VDeUwyeUFnL21OU2ljVXpPeFhO?= =?utf-8?B?M2FFTldaL3ZaOW5FcUV1cGxhVmxCRFN2Z2RiTDdsdnZVTFZWUVdPSURHMmJ0?= =?utf-8?B?R01ibnJmbUdTV3BQUStFUTdaQXBPOElkUzZCVzBVQTlnQjZveENwTjV0T2hZ?= =?utf-8?Q?AH1vbiBJb8S0q7b09AlgLrRjGu8lylV1S/jlSgG?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c6b90f5-001c-434f-67aa-08d8e27174a1 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 20:33:39.2519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pl7VJxOi1ZWKq7QP/LBfqnR9ISM4Z4q8NhIP6UMNroaXOGvg4QVUx3NSFDEq3b08h+zkRwJ643twzkWeO/fV67ZTX6OAYCcIQRhEcoA+IHM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2728 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9917 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 phishscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103080107 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9917 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 clxscore=1011 phishscore=0 adultscore=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 bulkscore=0 mlxscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103080107 On 3/6/21 11:18 AM, Juergen Gross wrote: > An event channel should be kept masked when an eoi is pending for it. > When being migrated to another cpu it might be unmasked, though. > > In order to avoid this keep three different flags for each event channel > to be able to distinguish "normal" masking/unmasking from eoi related > masking/unmasking and temporary masking. The event channel should only > be able to generate an interrupt if all flags are cleared. > > Cc: stable@vger.kernel.org > Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn framework") > Reported-by: Julien Grall > Signed-off-by: Juergen Gross > Reviewed-by: Julien Grall > --- > V2: > - introduce a lock around masking/unmasking > - merge patch 3 into this one (Jan Beulich) > V4: > - don't set eoi masking flag in lateeoi_mask_ack_dynirq() Reviewed-by: Boris Ostrovsky Ross, are you planning to test this? -boris From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:02:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:02:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95082.179375 (Exim 4.92) (envelope-from ) id 1lJN1O-0006Td-AL; Mon, 08 Mar 2021 21:02:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95082.179375; Mon, 08 Mar 2021 21:02:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1O-0006TU-6J; Mon, 08 Mar 2021 21:02:34 +0000 Received: by outflank-mailman (input) for mailman id 95082; Mon, 08 Mar 2021 21:02:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1M-0006P0-IW for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 21:02:32 +0000 Received: from mail-qv1-xf30.google.com (unknown [2607:f8b0:4864:20::f30]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3317de23-9f88-48da-a58a-9c85b5f562b1; Mon, 08 Mar 2021 21:02:27 +0000 (UTC) Received: by mail-qv1-xf30.google.com with SMTP id 15so5316748qvp.13 for ; Mon, 08 Mar 2021 13:02:27 -0800 (PST) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:a33e:daa7:46a1:a7eb]) by smtp.gmail.com with ESMTPSA id r2sm8514070qti.4.2021.03.08.13.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 13:02:26 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3317de23-9f88-48da-a58a-9c85b5f562b1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=znGoCssIhhTkDoewrJpPluTmjs7zy8iVwjnUtkhYRns=; b=VTOGUgDcVBADbGGoC2x8aqI1+ZjoRam9mlpwc+lZv0DsI8vWG2GfhbyGSGGiKsawAQ glSnnJ6zgV9VKQqZnlMfkYl+JfnNw5HuyqiYsNhQuBtAHbxAR2qpOaJ2itLzjL5ygyw9 4yFABH+KHt81zKuH6EyJPKU8Bul+1PmD1+kvXmstiSHSDMwRG9OBpLfdyRCSRlP1mVcT V7OFsTE/8s3TxUZo+q7Otzdxjs3SWrJUzLw9c22ixdVTtWvdIfGQfr8v0iIdCC12/VKf u7uoRsCGS+uWNVKxOGj1fhNpQR92UTD8P4irTiifsHFsZAlDX9iHzqXadSKaJDJUEGGR QRAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=znGoCssIhhTkDoewrJpPluTmjs7zy8iVwjnUtkhYRns=; b=leMsvTdfksEpPHvH64Fo4l4TJ8xHDlaoLOdbP0RLiDk8eMf6k5pv9UYuljQrSYKNoj pozcSWn1aAS04FRvZYk29+063LjN4pg0YmkGnWkCf1Ha92XkBbMpenWDBxLqIjHNG3EL DOhKq7SdwcqqoB4Gs3WEm/u+paQwvjyOJ8UL7ReO7Vw/h6ncV+ygll35QtudC7AYEVXD 80KuwWkHifLjBH2xvUzQrkhSBcVzSjWvvlZbFnJhFIYa8bDDud12kmUNuGoE2FEtrFuj YauMAbQyFdHupZWvUpYJWng0VMGU/tnaBFp9/PK4fLlvs40oAoZ10JkGlzWKxn//wix8 vWJg== X-Gm-Message-State: AOAM532MCXJWG6jXJlJOeTxER6F53L6fDIlcyZ6UsoraSHTUQV3jQa2C F75PPwJl18CG/Sed0fYvE4QhIkExiuo= X-Google-Smtp-Source: ABdhPJzKIodUHBfVbf6ctvzIC+8gLg2g3Rmlasu1nuYaIbyh31yXV4Y9g6NRds9nDCx21/VDPIkNWw== X-Received: by 2002:a0c:aece:: with SMTP id n14mr22796843qvd.52.1615237346639; Mon, 08 Mar 2021 13:02:26 -0800 (PST) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: pawel@invisiblethingslab.com, marmarek@invisiblethingslab.com, Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [RFC 02/12] cpufreq: Add perf_freq to cpuinfo Date: Mon, 8 Mar 2021 16:02:00 -0500 Message-Id: <20210308210210.116278-3-jandryuk@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210308210210.116278-1-jandryuk@gmail.com> References: <20210308210210.116278-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit acpi-cpufreq scales the aperf/mperf measurements by max_freq, but HWP needs to scale by base frequency. Settings max_freq to base_freq "works" but the code is not obvious, and returning values to userspace is tricky. Add an additonal perf_freq member which is used for scaling aperf/mperf measurements. Signed-off-by: Jason Andryuk --- I don't like this, but it seems the best way to re-use the common aperf/mperf code. The other option would be to add wrappers that then do the acpi vs. hwp scaling. --- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/drivers/cpufreq/utility.c | 1 + xen/include/acpi/cpufreq/cpufreq.h | 3 +++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index f1f3c6923f..5eac2f7321 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -317,7 +317,7 @@ unsigned int get_measured_perf(unsigned int cpu, unsigned int flag) else perf_percent = 0; - return policy->cpuinfo.max_freq * perf_percent / 100; + return policy->cpuinfo.perf_freq * perf_percent / 100; } static unsigned int get_cur_freq_on_cpu(unsigned int cpu) diff --git a/xen/drivers/cpufreq/utility.c b/xen/drivers/cpufreq/utility.c index b93895d4dd..788929e079 100644 --- a/xen/drivers/cpufreq/utility.c +++ b/xen/drivers/cpufreq/utility.c @@ -236,6 +236,7 @@ int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy, policy->min = policy->cpuinfo.min_freq = min_freq; policy->max = policy->cpuinfo.max_freq = max_freq; + policy->cpuinfo.perf_freq = max_freq; policy->cpuinfo.second_max_freq = second_max_freq; if (policy->min == ~0) diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 56df5eebed..b91859ce5d 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -37,6 +37,9 @@ extern struct acpi_cpufreq_data *cpufreq_drv_data[NR_CPUS]; struct cpufreq_cpuinfo { unsigned int max_freq; unsigned int second_max_freq; /* P1 if Turbo Mode is on */ + unsigned int perf_freq; /* Scaling freq for aperf/mpref. + acpi-cpufreq uses max_freq, but HWP uses + base_freq.*/ unsigned int min_freq; unsigned int transition_latency; /* in 10^(-9) s = nanoseconds */ }; -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:02:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:02:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95081.179364 (Exim 4.92) (envelope-from ) id 1lJN1J-0006Qc-0A; Mon, 08 Mar 2021 21:02:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95081.179364; Mon, 08 Mar 2021 21:02:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1I-0006QU-Sv; Mon, 08 Mar 2021 21:02:28 +0000 Received: by outflank-mailman (input) for mailman id 95081; Mon, 08 Mar 2021 21:02:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1H-0006P0-Hx for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 21:02:27 +0000 Received: from mail-qv1-xf2f.google.com (unknown [2607:f8b0:4864:20::f2f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 43aa06a6-76b4-4036-837e-7fcc27eb821d; Mon, 08 Mar 2021 21:02:24 +0000 (UTC) Received: by mail-qv1-xf2f.google.com with SMTP id s17so5311941qvr.12 for ; Mon, 08 Mar 2021 13:02:24 -0800 (PST) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:a33e:daa7:46a1:a7eb]) by smtp.gmail.com with ESMTPSA id r2sm8514070qti.4.2021.03.08.13.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 13:02:23 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43aa06a6-76b4-4036-837e-7fcc27eb821d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AfcM/s05qxzInnDElTdSa2MUdrnaUTl8MKM2+TfWCVg=; b=tbMhZo+C/23Qk6OTDzVt4ntvhwQITnUTwcsWvir9zh+CBlzBSXCq/rINAAzPFz88s6 sm65Or2at2PZwM9OyXMQBkwvz8WVbxSIi8kfNdy5sj5TjdAj724obPfg1aOCylj0FKMV 7HU1HUA1MV4DZdfHrDqsj2lX4xt+26nJvNA6K8iAXoZ/yAwryvCAwZXlZ/TY+eHBkMym cADG9C92CEKCTjfN9HXLOPb2B4rgMDImokSiU72PRhEZbKf76RHdH2Bxrsos8D84pzuG oDY4mZQNUJe3nzYoEJkCSQJbl/urs94V8KGdP05uslJ+02VO5KJ2kIFOrMW+NRGYzNTT AwRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AfcM/s05qxzInnDElTdSa2MUdrnaUTl8MKM2+TfWCVg=; b=AF8PJwYNOfQysq/gVqLA2/myFhaxfGnCxo9hld4+TM3NnPh4sMiQ+juhUGBD/i9uaO ecGMt13qk2anGvMu0mQO2XhwuHfIbjc8WFeLtgB7j1MwdZi4Hr5lIHnCSI4/T+JKQjTe VogGNe0s6tOaq8AS/6FM61kNWxo5aynHaL1ebtS07czHWOzDS9v8vEtzGdMvk8kttr2V +DZgioOlhBc2ra7qhU7EJH0cExudecf4v7HgLxfLNUVxd5O0hAWEPoB4L9pjfLPTnP3m iAtsb12HUNfbs8UoKCGJevust8pgoR5Ta5EUfP9MxGgGU+h0I0EvcarsUyIbn4nbAHrf BDxw== X-Gm-Message-State: AOAM5330DHGv78YR4Gqktex82hS0RjLYKh+Slj7yP8kIFaYJSMByfsk/ Eu4wB/r3t5NdaFRd11RR31oIKGFzvA4= X-Google-Smtp-Source: ABdhPJyHuwzAX6BTlMOiuZNdGKVNT28aymiqM3iA/I5EocSfeuPmVcrmGeqzJ7pR7YdpkQMQVDFKsg== X-Received: by 2002:ad4:4c0b:: with SMTP id bz11mr1818565qvb.4.1615237344305; Mon, 08 Mar 2021 13:02:24 -0800 (PST) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: pawel@invisiblethingslab.com, marmarek@invisiblethingslab.com, Jason Andryuk , Jan Beulich Subject: [RFC 01/12] cpufreq: Allow restricting to internal governors only Date: Mon, 8 Mar 2021 16:01:59 -0500 Message-Id: <20210308210210.116278-2-jandryuk@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210308210210.116278-1-jandryuk@gmail.com> References: <20210308210210.116278-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit For hwp, the standard governors are not usable, and only the internal one is applicable. Add the cpufreq_governor_internal boolean to indicate when an internal governor, like hwp-internal, will be used. This is set during presmp_initcall, so that it can suppress governor registration during initcall. Only a governor with a name containing "internal" will be allowed in that case. This way, the unuseable governors are not registered, so they internal one is the only one returned to userspace. This means incompatible governors won't be advertised to userspace. Signed-off-by: Jason Andryuk --- xen/drivers/cpufreq/cpufreq.c | 4 ++++ xen/include/acpi/cpufreq/cpufreq.h | 1 + 2 files changed, 5 insertions(+) diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index e630a47419..b1f668b715 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -57,6 +57,7 @@ struct cpufreq_dom { }; static LIST_HEAD_READ_MOSTLY(cpufreq_dom_list_head); +bool __read_mostly cpufreq_governor_internal; struct cpufreq_governor *__read_mostly cpufreq_opt_governor; LIST_HEAD_READ_MOSTLY(cpufreq_governor_list); @@ -122,6 +123,9 @@ int __init cpufreq_register_governor(struct cpufreq_governor *governor) if (!governor) return -EINVAL; + if (cpufreq_governor_internal && strstr(governor->name, "internal") == NULL) + return -EINVAL; + if (__find_governor(governor->name) != NULL) return -EEXIST; diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index e88b20bfed..56df5eebed 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -115,6 +115,7 @@ extern struct cpufreq_governor cpufreq_gov_dbs; extern struct cpufreq_governor cpufreq_gov_userspace; extern struct cpufreq_governor cpufreq_gov_performance; extern struct cpufreq_governor cpufreq_gov_powersave; +extern bool cpufreq_governor_internal; extern struct list_head cpufreq_governor_list; -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:02:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:02:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95080.179352 (Exim 4.92) (envelope-from ) id 1lJN1D-0006PF-Mu; Mon, 08 Mar 2021 21:02:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95080.179352; Mon, 08 Mar 2021 21:02:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1D-0006P8-Jg; Mon, 08 Mar 2021 21:02:23 +0000 Received: by outflank-mailman (input) for mailman id 95080; Mon, 08 Mar 2021 21:02:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1C-0006P0-Ny for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 21:02:22 +0000 Received: from mail-qk1-x72c.google.com (unknown [2607:f8b0:4864:20::72c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d53b4a58-ed75-4043-8493-911df4ec5784; Mon, 08 Mar 2021 21:02:21 +0000 (UTC) Received: by mail-qk1-x72c.google.com with SMTP id l4so10890240qkl.0 for ; Mon, 08 Mar 2021 13:02:21 -0800 (PST) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:a33e:daa7:46a1:a7eb]) by smtp.gmail.com with ESMTPSA id r2sm8514070qti.4.2021.03.08.13.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 13:02:20 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d53b4a58-ed75-4043-8493-911df4ec5784 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=znTAiOKI7hH9toOOOb0ZhwcwnjUZNrFUq91UZZdA8eI=; b=GouNeEM9WadDINh0HMdquJEmpriO+7ccetKXcKXHWbHwqR/UrEFTIAwOTxzHyfD7oQ pPUD9CXy44uAUpBYgnYIzHMlw1ZYnw+bm9SBUVUlgak6S9D8zmyLIRyBrpcB935tgHj/ O/gymI+4v5qalQ9pPqcIrhtjG2sPZfVTeTO55TmeF7xyN+69IPqKQ5QvNKMOMdy26H+w CqYM849ZWdaS2p14EcKq6VFayvow6Oz7uIuO1i4IZpYkQCqgqM3ZNuy1BTZURUxDFDJq XiAOjbKy8jSK16ajuU6Xh8qWgunX2bgbdZbLp6jvINiCz63oS4FED2jrADWK+JOab7DO nm8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=znTAiOKI7hH9toOOOb0ZhwcwnjUZNrFUq91UZZdA8eI=; b=PM6vbo1vke8/4o0m2isOZDvPB1I8gFPZ3bJdasnBH6JXvWnCAkvh0sbYboxo56cnlp C6h+571F0PWwVfsmbx40a2wXSB7gmvUKDB15nJp9RWpXevl0xcn31jxtcuDf1YAxz79y 2YlBWACStuGj5XjU5BIqDv4JRlv015DixZuLIPfXow4CB+/p07iA0/a1j/B8bKRp5sXn Ol+hppi/Trt+FLQvOp307KR1/Hj6iWaeRBuMaq0lPssTez3bwkhN4lZEHwNQpTt1wT+L /P7+jflWbtoWHvQ5pruLYd8uFZKjdWuYMxwQFWssZmJskXR/py5+jSaC3eeLjo4TUQrx CfeQ== X-Gm-Message-State: AOAM531ge49cpccZGN+Yu1rY9wUGz7YouAHUuhhdSIBIRMgVRRYhobnQ 1c5WPKUVtEm+bUQrq8GitbU1KfhyrTQ= X-Google-Smtp-Source: ABdhPJzIjtNE5yvXLkm2nX+CexccDl4+5PBaUEXp1IS5ch+yS9bIntQMXoTKOF/RfxBGXjdfs99Q/Q== X-Received: by 2002:a37:ef18:: with SMTP id j24mr23155160qkk.96.1615237341018; Mon, 08 Mar 2021 13:02:21 -0800 (PST) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: pawel@invisiblethingslab.com, marmarek@invisiblethingslab.com, Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini Subject: [RFC 00/12] Intel Hardware P-States (HWP) support Date: Mon, 8 Mar 2021 16:01:58 -0500 Message-Id: <20210308210210.116278-1-jandryuk@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, This patch series adds Hardware-Controlled Performance States (HWP) for Intel processors to Xen. With HWP, the processor makes its own determinations for frequency selection depending, though users can set some parameters and preferences. There is also Turbo Boost which pushes the max frequency if possible. The existing governors don't work with HWP since they select frequencies and HWP doesn't expose those. Therefore a dummy hwp-interal governor is used that doesn't do anything. xenpm get-cpufreq-para is extended to show HWP parameters, and set-cpufreq-hwp is added to set them. A lightly loaded OpenXT laptop showed ~1W power savings according to powertop. A mostly idle Fedora system (dom0 only) showed a more modest power savings. This fir for a 10th gen 6-core 1600 MHz base 4900 MHZ max cpu. In the default balance mode, Turbo Boost doesn't exceed 4GHz. Tweaking the energy_perf preference with `xenpm set-cpufreq-hwp balance ene:64`, I've seen the CPU hit 4.7GHz before throttling down and bouncing around between 4.3 and 4.5 GHz. Curiously the other cores read ~4GHz when turbo boost takes affect. This was done after pinning all dom0 cores, and using taskset to pin to vCPU/pCPU 11 and running a bash tightloop. RFC since there are a few open questions: hwp defaults to enabled and running in balanced mode. Maybe this wants changing? This series unilaterally enables Hardware Duty Cycling (HDC) which is another feature to autonomously powerdown things. That is enabled if HWP is enabled. Maybe that want to be configurable? I've only tested on an 8th gen and a 10th gen systems. The don't have fast MSR support, and they do have activity window and energy_perf support. So the respective other modes are untested. This changes the systcl_pm_op hypercall, so that wants review. I wanted to get this out since I know Qubes is also interested. Regards, Jason Jason Andryuk (12): cpufreq: Allow restricting to internal governors only cpufreq: Add perf_freq to cpuinfo cpufreq: Export intel_feature_detect cpufreq: Add Hardware P-State (HWP) driver xenpm: Change get-cpufreq-para output for internal cpufreq: Export HWP parameters to userspace libxc: Include hwp_para in definitions xenpm: Print HWP parameters xenpm: Factor out a non-fatal cpuid_parse variant xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op libxc: Add xc_set_cpufreq_hwp xenpm: Add set-cpufreq-hwp subcommand docs/misc/xen-command-line.pandoc | 9 + tools/include/xenctrl.h | 6 + tools/libs/ctrl/xc_pm.c | 18 + tools/misc/xenpm.c | 375 +++++++++++- xen/arch/x86/acpi/cpufreq/Makefile | 1 + xen/arch/x86/acpi/cpufreq/cpufreq.c | 15 +- xen/arch/x86/acpi/cpufreq/hwp.c | 671 ++++++++++++++++++++++ xen/drivers/acpi/pmstat.c | 30 + xen/drivers/cpufreq/cpufreq.c | 4 + xen/drivers/cpufreq/utility.c | 1 + xen/include/acpi/cpufreq/cpufreq.h | 9 + xen/include/acpi/cpufreq/processor_perf.h | 5 + xen/include/asm-x86/cpufeature.h | 11 +- xen/include/asm-x86/msr-index.h | 21 + xen/include/public/sysctl.h | 52 +- 15 files changed, 1199 insertions(+), 29 deletions(-) create mode 100644 xen/arch/x86/acpi/cpufreq/hwp.c -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:02:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:02:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95083.179388 (Exim 4.92) (envelope-from ) id 1lJN1S-0006Xb-Nt; Mon, 08 Mar 2021 21:02:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95083.179388; Mon, 08 Mar 2021 21:02:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1S-0006XQ-Jc; Mon, 08 Mar 2021 21:02:38 +0000 Received: by outflank-mailman (input) for mailman id 95083; Mon, 08 Mar 2021 21:02:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1R-0006P0-IZ for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 21:02:37 +0000 Received: from mail-qt1-x82c.google.com (unknown [2607:f8b0:4864:20::82c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ba2d4011-d9e8-42b6-befe-ff8a00d9df07; Mon, 08 Mar 2021 21:02:29 +0000 (UTC) Received: by mail-qt1-x82c.google.com with SMTP id r24so8632480qtt.8 for ; Mon, 08 Mar 2021 13:02:29 -0800 (PST) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:a33e:daa7:46a1:a7eb]) by smtp.gmail.com with ESMTPSA id r2sm8514070qti.4.2021.03.08.13.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 13:02:28 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba2d4011-d9e8-42b6-befe-ff8a00d9df07 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/v3gx4Dpg1dN3dSgA3Eor7lGHSmiomkDY5L/9HqLLB8=; b=ccptF4NoVHXSWqJNceo7Twvm2jsdZVS02K7G5ejVkRhfqJyTwyy3QgbkYvCYWy2Ma+ FSyoCOWDLdO5Ama9hIe2ZbbiA2m7Pe8hg9PrZoTu0ffmOSDFhc3oL8GGvVsq7+6yxbFd VQ+/LoyPWBvyFQCDp0XhyKJiRac1b9Mhh9EvLQsERVAqt5t7+4Wn8WwWQSHEgDtz6Yt4 AaeUHDG5FVdncGRec+rK/EHVJpCq2wz+ET4r446T76XLafR4AgXwYQSaLwQIR48iWzwN P1x6xby0t5TzqiWu0owCUYJaq+VUitEr1ZNklw61GZCkvp/4B1Y4KCz4Q9/xQYs2RZaK Tbtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/v3gx4Dpg1dN3dSgA3Eor7lGHSmiomkDY5L/9HqLLB8=; b=CwgkjeeM2Gvy0yfiiYMscCeHU4E790tl2VBFjvbae5NtEBXG7TIMQa+nkbfHv5kXTD RsFcgBsWIxiZndB4v58C1z8EmAyOxdropcdygVg7e7HJBI49+Yj+55N1OhU8Edt3ow+l 8HkIGae4ihhreQShpetm3pIW9jrWOjgzJ4VJGk8cQF3qQp3GZF7rRxzAC0fChVp+J177 NZeXdlqiSd8sy9K5OxzYSnRDPIgZLPZQB85Ry6jbvL1ippM6d5FpGA9a6VZ4vM/kJeVJ qIOwc2Quq9cPyl2liU1g/fp0n+cMgZdyUQdaBS0dBvxzQsNY+2BKwj3OdUDelkSqRRqq 6v9w== X-Gm-Message-State: AOAM5325rX+rT2AeY3/OXRI3vopjDF7pPl1Emp7mWDBcI+dMUdyK2jG1 /3dTgYaPwWB1IFhMUoAB9r5pJEh9deI= X-Google-Smtp-Source: ABdhPJzoDDpMqHHj2eLX8KAJiB9w5fKTdAodr8dsjoDTUw4POva1F7vKcpHCILY2iy2CBc2Q59O3CA== X-Received: by 2002:ac8:47c2:: with SMTP id d2mr22977294qtr.348.1615237348549; Mon, 08 Mar 2021 13:02:28 -0800 (PST) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: pawel@invisiblethingslab.com, marmarek@invisiblethingslab.com, Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [RFC 03/12] cpufreq: Export intel_feature_detect Date: Mon, 8 Mar 2021 16:02:01 -0500 Message-Id: <20210308210210.116278-4-jandryuk@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210308210210.116278-1-jandryuk@gmail.com> References: <20210308210210.116278-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Export feature_detect as intel_feature_detect so it can be re-used by HWP. Signed-off-by: Jason Andryuk --- xen/arch/x86/acpi/cpufreq/cpufreq.c | 4 ++-- xen/include/acpi/cpufreq/processor_perf.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index 5eac2f7321..8aae9b534d 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -340,7 +340,7 @@ static unsigned int get_cur_freq_on_cpu(unsigned int cpu) return extract_freq(get_cur_val(cpumask_of(cpu)), data); } -static void feature_detect(void *info) +void intel_feature_detect(void *info) { struct cpufreq_policy *policy = info; unsigned int eax; @@ -596,7 +596,7 @@ acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) /* Check for APERF/MPERF support in hardware * also check for boost support */ if (c->x86_vendor == X86_VENDOR_INTEL && c->cpuid_level >= 6) - on_selected_cpus(cpumask_of(cpu), feature_detect, policy, 1); + on_selected_cpus(cpumask_of(cpu), intel_feature_detect, policy, 1); /* * the first call to ->target() should result in us actually diff --git a/xen/include/acpi/cpufreq/processor_perf.h b/xen/include/acpi/cpufreq/processor_perf.h index d8a1ba68a6..e2c08f0e6d 100644 --- a/xen/include/acpi/cpufreq/processor_perf.h +++ b/xen/include/acpi/cpufreq/processor_perf.h @@ -7,6 +7,8 @@ #define XEN_PX_INIT 0x80000000 +void intel_feature_detect(void *info); + int powernow_cpufreq_init(void); unsigned int powernow_register_driver(void); unsigned int get_measured_perf(unsigned int cpu, unsigned int flag); -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:02:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:02:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95085.179400 (Exim 4.92) (envelope-from ) id 1lJN1Y-0006cS-3Q; Mon, 08 Mar 2021 21:02:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95085.179400; Mon, 08 Mar 2021 21:02:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1X-0006cI-VL; Mon, 08 Mar 2021 21:02:43 +0000 Received: by outflank-mailman (input) for mailman id 95085; Mon, 08 Mar 2021 21:02:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1W-0006P0-Id for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 21:02:42 +0000 Received: from mail-qt1-x835.google.com (unknown [2607:f8b0:4864:20::835]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b82b9a90-1da7-425f-8d11-867da036625d; Mon, 08 Mar 2021 21:02:32 +0000 (UTC) Received: by mail-qt1-x835.google.com with SMTP id l14so5876405qtr.10 for ; Mon, 08 Mar 2021 13:02:32 -0800 (PST) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:a33e:daa7:46a1:a7eb]) by smtp.gmail.com with ESMTPSA id r2sm8514070qti.4.2021.03.08.13.02.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 13:02:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b82b9a90-1da7-425f-8d11-867da036625d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BjEhlVDqlccH5BFquh074KTWWcfbnvlNbbrUkEKCX2E=; b=C9zpkcGIjkKcQkJuirZxV8lknSTdXb9TB48gTR1ZFUf2zqkcrudQs1nWFO6zc8qtaJ AT+QHtMTcdxvYz8jvDSK7U274632PbP0nJdl8NApeStie5mL99Pw3A2V34GQ6ykhwqzP urlja47wAkAQHooJF4f31Wpg9nQm0wyQFwU+WB2TBLa9HTE5xS0OxHWiP4Jnsboc00bY zYbKAiEP+iwHa2ZGEE5D1gEc8QpqAGt7oqJ3pVZQ3Zl2fpk1fOP2qSt3nbVadtTMPCpL VXgGIuhQFKZvo40lUELmtD8krrrb4C86ceJsPLpIVQSs7pP80B76rRGbzt1q980gBsnD HiYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BjEhlVDqlccH5BFquh074KTWWcfbnvlNbbrUkEKCX2E=; b=aKItCwWGxfJcUaGbNYrs3sgBEmTbl2ZMIBP7lJvspGacp1qMlBWiHEp8jts/Zw7GnR vapt7MelYXmVHxZ3GJWnjnZlKJWlQm64ublOn6XO3irrQQ5EZdTf1iOWpkVNsa7FHNXn Re9PyK11sLK68ukvOPEaw9IhIC368tkHsNt2yLo2ocovFGMSx1QPvMEF0CBaqSlXB9/h MJ48mCyfPN7CEqOobG5RGeQGJobsdFzYhiOZjHyNBQbOn6wbwSAdNgX97pOrSZZH6b2a 2VJkMBizogOg9ub2bCuobo73PgZajlqPxGmGHpn3r+/tvwnu2rfjRmZ7AcQCFvRRj1Zv JiQQ== X-Gm-Message-State: AOAM532f55AeQ2NHrvGDUSwCK8Wxo2tK5vbFgpMQq6xgNyo8/ummZuk0 KV0r6/S02mRAjrftvQJE3pBSLZOnfPo= X-Google-Smtp-Source: ABdhPJyeTwlanill4YhFzg/NcX9IGS/uaY7Er9nhFijWUKY+H7YHyhE+Pq4TNVu/YBEjonbsvqx64w== X-Received: by 2002:a05:622a:4d3:: with SMTP id q19mr22286878qtx.316.1615237350881; Mon, 08 Mar 2021 13:02:30 -0800 (PST) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: pawel@invisiblethingslab.com, marmarek@invisiblethingslab.com, Jason Andryuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [RFC 04/12] cpufreq: Add Hardware P-State (HWP) driver Date: Mon, 8 Mar 2021 16:02:02 -0500 Message-Id: <20210308210210.116278-5-jandryuk@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210308210210.116278-1-jandryuk@gmail.com> References: <20210308210210.116278-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit >From the Intel SDM: "Hardware-Controlled Performance States (HWP), which autonomously selects performance states while utilizing OS supplied performance guidance hints." Enable HWP to run in autonomous mode by poking the correct MSRs. There is no interface to configure - it hardcodes the default 0x80 (out of 0x0-0xff) energy/performance preference. xen_sysctl_pm_op/xenpm will be to be extended to configure in subsequent patches. Unscientific powertop measurement of an mostly idle, customized OpenXT install: A 10th gen 6-core laptop showed battery discharge drop from ~9.x to ~7.x watts. A 8th gen 4-core laptop dropped from ~10 to ~9 Power usage depends on many factors, especially display brightness, but this does show an power saving in balanced mode when CPU utilization is low. HWP isn't compatible with an external governor - it doesn't take explicit frequency requests. Therefore a minimal internal governor, hwp-internal, is also added as a placeholder. Signed-off-by: Jason Andryuk --- We disable on cpuid_level < 0x16. cpuid(0x16) is used to get the cpu frequencies for calculating the APERF/MPERF. Without it, things would still work, but the averge cpufrequency output would be wrong. If HWP Energy_Performance_Preference isn't supported, the code falls back to IA32_ENERGY_PERF_BIAS. Right now, we don't check CPUID.06H:ECX.SETBH[bit 3] before using that MSR. The SDM reads like it'll be available, and I assume it was available by the time Skylake introduced HWP. My 8th & 10th gen test systems both report: (XEN) HWP: 1 notify: 1 act_window: 1 energy_perf: 1 pkg_level: 0 peci: 0 (XEN) HWP: FAST_IA32_HWP_REQUEST not supported (XEN) HWP: Hardware Duty Cycling (HDC) supported (XEN) HWP: HW_FEEDBACK not supported So FAST_IA32_HWP_REQUEST and IA32_ENERGY_PERF_BIAS have not been tested. --- docs/misc/xen-command-line.pandoc | 9 + xen/arch/x86/acpi/cpufreq/Makefile | 1 + xen/arch/x86/acpi/cpufreq/cpufreq.c | 9 +- xen/arch/x86/acpi/cpufreq/hwp.c | 533 ++++++++++++++++++++++ xen/include/acpi/cpufreq/processor_perf.h | 3 + xen/include/asm-x86/cpufeature.h | 11 +- xen/include/asm-x86/msr-index.h | 21 + 7 files changed, 583 insertions(+), 4 deletions(-) create mode 100644 xen/arch/x86/acpi/cpufreq/hwp.c diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 4737c92bfe..799391a5ab 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1310,6 +1310,15 @@ Specify whether guests are to be given access to physical port 80 (often used for debugging purposes), to override the DMI based detection of systems known to misbehave upon accesses to that port. +### hwp (x86) +> `= ` + +> Default: `false` + +Specifies whether Xen uses Hardware-Controlled Performance States (HWP) +on supported Intel hardware. HWP is a Skylake+ feature which provides +better CPU power management. + ### idle_latency_factor (x86) > `= ` diff --git a/xen/arch/x86/acpi/cpufreq/Makefile b/xen/arch/x86/acpi/cpufreq/Makefile index f75da9b9ca..db83aa6b14 100644 --- a/xen/arch/x86/acpi/cpufreq/Makefile +++ b/xen/arch/x86/acpi/cpufreq/Makefile @@ -1,2 +1,3 @@ obj-y += cpufreq.o +obj-y += hwp.o obj-y += powernow.o diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index 8aae9b534d..966490bda1 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -641,9 +641,12 @@ static int __init cpufreq_driver_init(void) int ret = 0; if ((cpufreq_controller == FREQCTL_xen) && - (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)) - ret = cpufreq_register_driver(&acpi_cpufreq_driver); - else if ((cpufreq_controller == FREQCTL_xen) && + (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)) { + if (hwp_available()) + ret = hwp_register_driver(); + else + ret = cpufreq_register_driver(&acpi_cpufreq_driver); + } else if ((cpufreq_controller == FREQCTL_xen) && (boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON))) ret = powernow_register_driver(); diff --git a/xen/arch/x86/acpi/cpufreq/hwp.c b/xen/arch/x86/acpi/cpufreq/hwp.c new file mode 100644 index 0000000000..f8e6fdbd41 --- /dev/null +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -0,0 +1,533 @@ +/* + * hwp.c cpufreq driver to run Intel Hardware P-States (HWP) + * + * Copyright (C) 2021 Jason Andryuk + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or (at + * your option) any later version. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; If not, see . + */ + +#include +#include +#include +#include +#include +#include +#include + +static bool feature_hwp; +static bool feature_hwp_notification; +static bool feature_hwp_activity_window; +static bool feature_hwp_energy_perf; +static bool feature_hwp_pkg_level_ctl; +static bool feature_hwp_peci; + +static bool feature_hdc; +static bool feature_fast_msr; + +bool opt_hwp = true; +boolean_param("hwp", opt_hwp); + +union hwp_request +{ + struct + { + uint64_t min_perf:8; + uint64_t max_perf:8; + uint64_t desired:8; + uint64_t energy_perf:8; + uint64_t activity_window:10; + uint64_t package_control:1; + uint64_t reserved:16; + uint64_t activity_window_valid:1; + uint64_t energy_perf_valid:1; + uint64_t desired_valid:1; + uint64_t max_perf_valid:1; + uint64_t min_perf_valid:1; + }; + uint64_t raw; +}; + +struct hwp_drv_data +{ + union + { + uint64_t hwp_caps; + struct + { + uint64_t hw_highest:8; + uint64_t hw_guaranteed:8; + uint64_t hw_most_efficient:8; + uint64_t hw_lowest:8; + uint64_t hw_reserved:32; + }; + }; + union hwp_request curr_req; + uint16_t activity_window; + uint8_t minimum; + uint8_t maximum; + uint8_t desired; + uint8_t energy_perf; +}; +struct hwp_drv_data *hwp_drv_data[NR_CPUS]; + +#define hwp_err(...) printk(XENLOG_ERR __VA_ARGS__) +#define hwp_info(...) printk(XENLOG_INFO __VA_ARGS__) +#define hwp_verbose(...) \ +({ \ + if ( cpufreq_verbose ) \ + { \ + printk(XENLOG_DEBUG __VA_ARGS__); \ + } \ +}) +#define hwp_verbose_cont(...) \ +({ \ + if ( cpufreq_verbose ) \ + { \ + printk( __VA_ARGS__); \ + } \ +}) + +static int hwp_governor(struct cpufreq_policy *policy, + unsigned int event) +{ + int ret; + + if ( policy == NULL ) + return -EINVAL; + + switch (event) + { + case CPUFREQ_GOV_START: + ret = 0; + break; + case CPUFREQ_GOV_STOP: + ret = -EINVAL; + break; + case CPUFREQ_GOV_LIMITS: + ret = 0; + break; + default: + ret = -EINVAL; + } + + return ret; +} + +static struct cpufreq_governor hwp_cpufreq_governor = +{ + .name = "hwp-internal", + .governor = hwp_governor, +}; + +static int __init cpufreq_gov_hwp_init(void) +{ + return cpufreq_register_governor(&hwp_cpufreq_governor); +} +__initcall(cpufreq_gov_hwp_init); + +bool hwp_available(void) +{ + uint32_t eax; + uint64_t val; + bool use_hwp; + + if ( boot_cpu_data.cpuid_level < CPUID_PM_LEAF ) + { + hwp_verbose("cpuid_level (%u) lacks HWP support\n", boot_cpu_data.cpuid_level); + + return false; + } + + eax = cpuid_eax(CPUID_PM_LEAF); + feature_hwp = !!(eax & CPUID6_EAX_HWP); + feature_hwp_notification = !!(eax & CPUID6_EAX_HWP_Notification); + feature_hwp_activity_window = !!(eax & CPUID6_EAX_HWP_Activity_Window); + feature_hwp_energy_perf = + !!(eax & CPUID6_EAX_HWP_Energy_Performance_Preference); + feature_hwp_pkg_level_ctl = + !!(eax & CPUID6_EAX_HWP_Package_Level_Request); + feature_hwp_peci = !!(eax & CPUID6_EAX_HWP_PECI); + + hwp_verbose("HWP: %d notify: %d act_window: %d energy_perf: %d pkg_level: %d peci: %d\n", + feature_hwp, feature_hwp_notification, + feature_hwp_activity_window, feature_hwp_energy_perf, + feature_hwp_pkg_level_ctl, feature_hwp_peci); + + if ( !feature_hwp ) + { + hwp_verbose("Hardware does not support HWP\n"); + + return false; + } + + if ( boot_cpu_data.cpuid_level < 0x16 ) + { + hwp_info("HWP disabled: cpuid_level %x < 0x16 lacks CPU freq info\n", + boot_cpu_data.cpuid_level); + + return false; + } + + hwp_verbose("HWP: FAST_IA32_HWP_REQUEST %ssupported\n", + eax & CPUID6_EAX_FAST_HWP_MSR ? "" : "not "); + if ( eax & CPUID6_EAX_FAST_HWP_MSR ) + { + if ( rdmsr_safe(MSR_FAST_UNCORE_MSRS_CAPABILITY, val) ) + hwp_err("error rdmsr_safe(MSR_FAST_UNCORE_MSRS_CAPABILITY)\n"); + + hwp_verbose("HWP: MSR_FAST_UNCORE_MSRS_CAPABILITY: %016lx\n", val); + if (val & FAST_IA32_HWP_REQUEST ) + { + hwp_verbose("HWP: FAST_IA32_HWP_REQUEST MSR available\n"); + feature_fast_msr = true; + } + } + + feature_hdc = !!(eax & CPUID6_EAX_HDC); + + hwp_verbose("HWP: Hardware Duty Cycling (HDC) %ssupported\n", + feature_hdc ? "" : "not "); + + hwp_verbose("HWP: HW_FEEDBACK %ssupported\n", + (eax & CPUID6_EAX_HW_FEEDBACK) ? "" : "not "); + + use_hwp = feature_hwp && opt_hwp; + cpufreq_governor_internal = use_hwp; + + if ( use_hwp ) + hwp_info("Using HWP for cpufreq\n"); + + return use_hwp; +} + +static void hdc_set_pkg_hdc_ctl(bool val) +{ + uint64_t msr; + + if ( rdmsr_safe(MSR_IA32_PKG_HDC_CTL, msr) ) + { + hwp_err("error rdmsr_safe(MSR_IA32_PKG_HDC_CTL)\n"); + + return; + } + + msr = val ? IA32_PKG_HDC_CTL_HDC_PKG_Enable : 0; + + if ( wrmsr_safe(MSR_IA32_PKG_HDC_CTL, msr) ) + hwp_err("error wrmsr_safe(MSR_IA32_PKG_HDC_CTL): %016lx\n", msr); +} + +static void hdc_set_pm_ctl1(bool val) +{ + uint64_t msr; + + if ( rdmsr_safe(MSR_IA32_PM_CTL1, msr) ) + { + hwp_err("error rdmsr_safe(MSR_IA32_PM_CTL1)\n"); + + return; + } + + msr = val ? IA32_PM_CTL1_HDC_Allow_Block : 0; + + if ( wrmsr_safe(MSR_IA32_PM_CTL1, msr) ) + hwp_err("error wrmsr_safe(MSR_IA32_PM_CTL1): %016lx\n", msr); +} + +static void hwp_fast_uncore_msrs_ctl(bool val) +{ + uint64_t msr; + + if ( rdmsr_safe(MSR_FAST_UNCORE_MSRS_CTL, msr) ) + hwp_err("error rdmsr_safe(MSR_FAST_UNCORE_MSRS_CTL)\n"); + + msr = val; + + if ( wrmsr_safe(MSR_FAST_UNCORE_MSRS_CTL, msr) ) + hwp_err("error wrmsr_safe(MSR_FAST_UNCORE_MSRS_CTL): %016lx\n", msr); +} + +static void hwp_get_cpu_speeds(struct cpufreq_policy *policy) +{ + uint32_t base_khz, max_khz, bus_khz, edx; + + cpuid(0x16, &base_khz, &max_khz, &bus_khz, &edx); + + /* aperf/mperf scales base. */ + policy->cpuinfo.perf_freq = base_khz * 1000; + policy->cpuinfo.min_freq = base_khz * 1000; + policy->cpuinfo.max_freq = max_khz * 1000; + policy->min = base_khz * 1000; + policy->max = max_khz * 1000; + policy->cur = 0; +} + +static void hwp_read_capabilities(void *info) +{ + struct cpufreq_policy *policy = info; + struct hwp_drv_data *data = hwp_drv_data[policy->cpu]; + + if ( rdmsr_safe(MSR_IA32_HWP_CAPABILITIES, data->hwp_caps) ) + { + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_HWP_CAPABILITIES)\n", + policy->cpu); + + return; + } + + if ( rdmsr_safe(MSR_IA32_HWP_REQUEST, data->curr_req.raw) ) + { + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_HWP_REQUEST)\n", policy->cpu); + + return; + } +} + +static void hwp_init_msrs(void *info) +{ + struct cpufreq_policy *policy = info; + uint64_t val; + + /* Package level MSR, but we don't have a good idea of packages here, so + * just do it everytime. */ + if ( rdmsr_safe(MSR_IA32_PM_ENABLE, val) ) + { + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_PM_ENABLE)\n", policy->cpu); + + return; + } + + hwp_verbose("CPU%u: MSR_IA32_PM_ENABLE: %016lx\n", policy->cpu, val); + if ( val != IA32_PM_ENABLE_HWP_ENABLE ) + { + val = IA32_PM_ENABLE_HWP_ENABLE; + if ( wrmsr_safe(MSR_IA32_PM_ENABLE, val) ) + hwp_err("CPU%u: error wrmsr_safe(MSR_IA32_PM_ENABLE, %lx)\n", + policy->cpu, val); + } + + hwp_read_capabilities(info); + + /* Check for APERF/MPERF support in hardware + * also check for boost/turbo support */ + intel_feature_detect(policy); + + if ( feature_hdc ) + { + hdc_set_pkg_hdc_ctl(true); + hdc_set_pm_ctl1(true); + } + + if ( feature_fast_msr ) + hwp_fast_uncore_msrs_ctl(true); + + hwp_get_cpu_speeds(policy); +} + +static int hwp_cpufreq_verify(struct cpufreq_policy *policy) +{ + unsigned int cpu = policy->cpu; + struct hwp_drv_data *data = hwp_drv_data[cpu]; + + if ( !feature_hwp_energy_perf && data->energy_perf ) + { + if ( data->energy_perf > 15 ) + { + hwp_err("energy_perf %d exceeds IA32_ENERGY_PERF_BIAS range 0-15\n", + data->energy_perf); + + return -EINVAL; + } + } + + if ( !feature_hwp_activity_window && data->activity_window ) + { + hwp_err("HWP activity window not supported.\n"); + + return -EINVAL; + } + + return 0; +} + +/* val 0 - highest performance, 15 - maximum energy savings */ +static void hwp_energy_perf_bias(void *info) +{ + uint64_t msr; + struct hwp_drv_data *data = info; + uint8_t val = data->energy_perf; + + ASSERT(val <= 15); + + if ( rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, msr) ) + { + hwp_err("error rdmsr_safe(MSR_IA32_ENERGY_PERF_BIAS)\n"); + + return; + } + + msr &= ~(0xf); + msr |= val; + + if ( wrmsr_safe(MSR_IA32_ENERGY_PERF_BIAS, msr) ) + hwp_err("error wrmsr_safe(MSR_IA32_ENERGY_PERF_BIAS): %016lx\n", msr); +} + +static void hwp_write_request(void *info) +{ + struct cpufreq_policy *policy = info; + struct hwp_drv_data *data = hwp_drv_data[policy->cpu]; + union hwp_request hwp_req = data->curr_req; + + BUILD_BUG_ON(sizeof(union hwp_request) != sizeof(uint64_t)); + if ( wrmsr_safe(MSR_IA32_HWP_REQUEST, hwp_req.raw) ) + { + hwp_err("CPU%u: error wrmsr_safe(MSR_IA32_HWP_REQUEST, %lx)\n", + policy->cpu, hwp_req.raw); + rdmsr_safe(MSR_IA32_HWP_REQUEST, data->curr_req.raw); + } +} + +static int hwp_cpufreq_target(struct cpufreq_policy *policy, + unsigned int target_freq, unsigned int relation) +{ + unsigned int cpu = policy->cpu; + struct hwp_drv_data *data = hwp_drv_data[cpu]; + union hwp_request hwp_req; + + /* Zero everything to ensure reserved bits are zero... */ + hwp_req.raw = 0; + /* .. and update from there */ + hwp_req.min_perf = data->minimum; + hwp_req.max_perf = data->maximum; + hwp_req.desired = data->desired; + if ( feature_hwp_energy_perf ) + hwp_req.energy_perf = data->energy_perf; + if ( feature_hwp_activity_window ) + hwp_req.activity_window = data->activity_window; + + if ( hwp_req.raw == data->curr_req.raw ) + return 0; + + data->curr_req.raw = hwp_req.raw; + + hwp_verbose("CPU%u: wrmsr HWP_REQUEST %016lx\n", cpu, hwp_req.raw); + on_selected_cpus(cpumask_of(cpu), hwp_write_request, policy, 1); + + if ( !feature_hwp_energy_perf && data->energy_perf ) + { + on_selected_cpus(cpumask_of(cpu), hwp_energy_perf_bias, + data, 1); + } + + return 0; +} + +static int hwp_cpufreq_cpu_init(struct cpufreq_policy *policy) +{ + unsigned int cpu = policy->cpu; + struct hwp_drv_data *data; + + if ( cpufreq_opt_governor ) + { + printk(XENLOG_WARNING + "HWP: governor \"%s\" is incompatible with hwp. Using default \"%s\"\n", + cpufreq_opt_governor->name, hwp_cpufreq_governor.name); + } + policy->governor = &hwp_cpufreq_governor; + + data = xzalloc(typeof(*data)); + if ( !data ) + return -ENOMEM; + + hwp_drv_data[cpu] = data; + + on_selected_cpus(cpumask_of(cpu), hwp_init_msrs, policy, 1); + + data->minimum = data->hw_lowest; + data->maximum = data->hw_highest; + data->desired = 0; /* default to HW autonomous */ + if ( feature_hwp_energy_perf ) + data->energy_perf = 0x80; + else + data->energy_perf = 7; + + hwp_verbose("CPU%u: IA32_HWP_CAPABILITIES: %016lx\n", cpu, data->hwp_caps); + + hwp_verbose("CPU%u: rdmsr HWP_REQUEST %016lx\n", cpu, data->curr_req.raw); + + return 0; +} + +static int hwp_cpufreq_cpu_exit(struct cpufreq_policy *policy) +{ + unsigned int cpu = policy->cpu; + + xfree(hwp_drv_data[cpu]); + hwp_drv_data[cpu] = NULL; + + return 0; +} + +/* The SDM reads like turbo should be disabled with MSR_IA32_PERF_CTL and + * PERF_CTL_TURBO_DISENGAGE, but that does not seem to actually work, at least + * with my HWP testing. MSR_IA32_MISC_ENABLE and MISC_ENABLE_TURBO_DISENGAGE + * is what Linux uses and seems to work. */ +static void hwp_set_misc_turbo(void *info) +{ + struct cpufreq_policy *policy = info; + uint64_t msr; + + if ( rdmsr_safe(MSR_IA32_MISC_ENABLE, msr) ) + { + hwp_err("CPU%u: error rdmsr_safe(MSR_IA32_MISC_ENABLE)\n", policy->cpu); + + return; + } + + if ( policy->turbo == CPUFREQ_TURBO_ENABLED ) + msr &= ~MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE; + else + msr |= MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE; + + if ( wrmsr_safe(MSR_IA32_MISC_ENABLE, msr) ) + hwp_err("CPU%u: error wrmsr_safe(MSR_IA32_MISC_ENABLE): %016lx\n", + policy->cpu, msr); +} + +static int hwp_cpufreq_update(int cpuid, struct cpufreq_policy *policy) +{ + on_selected_cpus(cpumask_of(cpuid), hwp_set_misc_turbo, policy, 1); + + return 0; +} + +static const struct cpufreq_driver __initconstrel hwp_cpufreq_driver = +{ + .name = "hwp-cpufreq", + .verify = hwp_cpufreq_verify, + .target = hwp_cpufreq_target, + .init = hwp_cpufreq_cpu_init, + .exit = hwp_cpufreq_cpu_exit, + .update = hwp_cpufreq_update, +}; + +int hwp_register_driver(void) +{ + int ret; + + ret = cpufreq_register_driver(&hwp_cpufreq_driver); + + return ret; +} diff --git a/xen/include/acpi/cpufreq/processor_perf.h b/xen/include/acpi/cpufreq/processor_perf.h index e2c08f0e6d..2e67e667e0 100644 --- a/xen/include/acpi/cpufreq/processor_perf.h +++ b/xen/include/acpi/cpufreq/processor_perf.h @@ -9,6 +9,9 @@ void intel_feature_detect(void *info); +bool hwp_available(void); +int hwp_register_driver(void); + int powernow_cpufreq_init(void); unsigned int powernow_register_driver(void); unsigned int get_measured_perf(unsigned int cpu, unsigned int flag); diff --git a/xen/include/asm-x86/cpufeature.h b/xen/include/asm-x86/cpufeature.h index 33b2257888..1900c90f90 100644 --- a/xen/include/asm-x86/cpufeature.h +++ b/xen/include/asm-x86/cpufeature.h @@ -26,7 +26,16 @@ #define CPUID5_ECX_EXTENSIONS_SUPPORTED 0x1 #define CPUID5_ECX_INTERRUPT_BREAK 0x2 -#define CPUID_PM_LEAF 6 +#define CPUID_PM_LEAF 6 +#define CPUID6_EAX_HWP (_AC(1, U) << 7) +#define CPUID6_EAX_HWP_Notification (_AC(1, U) << 8) +#define CPUID6_EAX_HWP_Activity_Window (_AC(1, U) << 9) +#define CPUID6_EAX_HWP_Energy_Performance_Preference (_AC(1, U) << 10) +#define CPUID6_EAX_HWP_Package_Level_Request (_AC(1, U) << 11) +#define CPUID6_EAX_HDC (_AC(1, U) << 13) +#define CPUID6_EAX_HWP_PECI (_AC(1, U) << 16) +#define CPUID6_EAX_FAST_HWP_MSR (_AC(1, U) << 18) +#define CPUID6_EAX_HW_FEEDBACK (_AC(1, U) << 19) #define CPUID6_ECX_APERFMPERF_CAPABILITY 0x1 /* CPUID level 0x00000001.edx */ diff --git a/xen/include/asm-x86/msr-index.h b/xen/include/asm-x86/msr-index.h index 1f5a5d0e38..6f1f62c0a1 100644 --- a/xen/include/asm-x86/msr-index.h +++ b/xen/include/asm-x86/msr-index.h @@ -101,6 +101,12 @@ #define MSR_RTIT_ADDR_A(n) (0x00000580 + (n) * 2) #define MSR_RTIT_ADDR_B(n) (0x00000581 + (n) * 2) +#define MSR_FAST_UNCORE_MSRS_CTL 0x00000657 +#define FAST_IA32_HWP_REQUEST_MSR_ENABLE (_AC(1, ULL) << 0) + +#define MSR_FAST_UNCORE_MSRS_CAPABILITY 0x0000065f +#define FAST_IA32_HWP_REQUEST (_AC(1, ULL) << 0) + #define MSR_U_CET 0x000006a0 #define MSR_S_CET 0x000006a2 #define CET_SHSTK_EN (_AC(1, ULL) << 0) @@ -112,10 +118,24 @@ #define MSR_PL3_SSP 0x000006a7 #define MSR_INTERRUPT_SSP_TABLE 0x000006a8 +#define MSR_IA32_PM_ENABLE 0x00000770 +#define IA32_PM_ENABLE_HWP_ENABLE (_AC(1, ULL) << 0) +#define MSR_IA32_HWP_CAPABILITIES 0x00000771 +#define MSR_IA32_HWP_REQUEST_PKG 0x00000772 +#define MSR_IA32_HWP_INTERRUPT 0x00000773 +#define MSR_IA32_HWP_REQUEST 0x00000774 +#define MSR_IA32_HWP_PECI_REQUEST_INFO 0x00000775 +#define MSR_IA32_HWP_STATUS 0x00000777 + #define MSR_PASID 0x00000d93 #define PASID_PASID_MASK 0x000fffff #define PASID_VALID (_AC(1, ULL) << 31) +#define MSR_IA32_PKG_HDC_CTL 0x00000db0 +#define IA32_PKG_HDC_CTL_HDC_PKG_Enable (_AC(1, ULL) << 0) +#define MSR_IA32_PM_CTL1 0x00000db1 +#define IA32_PM_CTL1_HDC_Allow_Block (_AC(1, ULL) << 0) + #define MSR_K8_VM_CR 0xc0010114 #define VM_CR_INIT_REDIRECTION (_AC(1, ULL) << 1) #define VM_CR_SVM_DISABLE (_AC(1, ULL) << 4) @@ -458,6 +478,7 @@ #define MSR_IA32_MISC_ENABLE_LIMIT_CPUID (1<<22) #define MSR_IA32_MISC_ENABLE_XTPR_DISABLE (1<<23) #define MSR_IA32_MISC_ENABLE_XD_DISABLE (1ULL << 34) +#define MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE (1ULL << 38) #define MSR_IA32_TSC_DEADLINE 0x000006E0 #define MSR_IA32_ENERGY_PERF_BIAS 0x000001b0 -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:02:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:02:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95087.179413 (Exim 4.92) (envelope-from ) id 1lJN1c-0006hT-LX; Mon, 08 Mar 2021 21:02:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95087.179413; Mon, 08 Mar 2021 21:02:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1c-0006hF-FA; Mon, 08 Mar 2021 21:02:48 +0000 Received: by outflank-mailman (input) for mailman id 95087; Mon, 08 Mar 2021 21:02:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1b-0006P0-Ik for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 21:02:47 +0000 Received: from mail-qv1-xf2a.google.com (unknown [2607:f8b0:4864:20::f2a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2f6b2bc0-98ad-43b3-96a3-15221fda3c2c; Mon, 08 Mar 2021 21:02:33 +0000 (UTC) Received: by mail-qv1-xf2a.google.com with SMTP id bh3so5340421qvb.5 for ; Mon, 08 Mar 2021 13:02:33 -0800 (PST) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:a33e:daa7:46a1:a7eb]) by smtp.gmail.com with ESMTPSA id r2sm8514070qti.4.2021.03.08.13.02.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 13:02:32 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f6b2bc0-98ad-43b3-96a3-15221fda3c2c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6huQgq+uDBy8RsFCTHtfKVZpPnrSucaiZ54dJm9nYeI=; b=Wer6nEDWVkndnvRNgmg4aC8u7FVAcjtZrQLpcbsl3hJ35DWgsPWJKkpRtbyqW2AI71 n3LIDHqn5I6EFGOnAUKMYmr+rsIt08MZ+YcwWvfgRK/Z3UemUKq6S2gHGJWKcYiN+CsF +DjBDXyrr4CVPBKMAoUW5BIMbsrdakM0JhNGiSvIrztIfR89SjEBCHC8Flvofy3Sen2j EqQqIcYFLcmsfUVz6R3kJ6uP081YIti9XfTdTnnKuArSJk82tK21zlJ9tr1/Yn6xbLP2 bWm6qkA5ig+AcpzdnRCC7BJxFL5jV6cgInMLTZ+UNCAydqlI7zdzHCgw7ZHshwAGFcnx 55bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6huQgq+uDBy8RsFCTHtfKVZpPnrSucaiZ54dJm9nYeI=; b=iYr+t2pLqBz4+E4kRJp2k2KiW/0V9WldR1lBtYQCNJ1d+zbrgv8LpglQ2OTGWG/jsn Gq8nNE9KhN0TyzfEGchJQ+X6NrZ/lJ5Z5uoBXy6oArEHrv9Htc0UnBiECxrwAJO73ZtY Kk+ldsnTnZlOPbRPchp3AZHHSquwsmZ/PE81ZaH0ISjicbA/92q9Hl7YgTbdC4eVGKyD +8RGId8q2WWn1UrKCgsvLKvt2EsXEek1MIE3W8UMV/ygMTWpM58buytRL/ve+lrirSwZ VdpTXgLkGCRZLYzG7iLsCZtPUUEVP96hqvaR2Ng8H9HhfQQTByJUW8uP0jPxOtd4lhbY AhbQ== X-Gm-Message-State: AOAM530NHUmdZqkkRrvrysxmOwmpVkjr0Sh/GuoN3raH3eLXactGitSO Bf7Q8GDS3Ygo2t4HSAYzUTo13jtMwr4= X-Google-Smtp-Source: ABdhPJymVRcoQcyP0VqxqnyZsYHb3fWy4qxlrGF/d0o2piukAVzC1HJEvx3QPp+D8QBGx6qRVmTDqA== X-Received: by 2002:a0c:f702:: with SMTP id w2mr776977qvn.0.1615237352617; Mon, 08 Mar 2021 13:02:32 -0800 (PST) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: pawel@invisiblethingslab.com, marmarek@invisiblethingslab.com, Jason Andryuk , Ian Jackson , Wei Liu Subject: [RFC 05/12] xenpm: Change get-cpufreq-para output for internal Date: Mon, 8 Mar 2021 16:02:03 -0500 Message-Id: <20210308210210.116278-6-jandryuk@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210308210210.116278-1-jandryuk@gmail.com> References: <20210308210210.116278-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When using HWP, some of the returned data is not applicable. In that case, we should just omit it to avoid confusing the user. So switch to printing the base and turbo frequencies since those are relevant to HWP. Similarly, stop printing the CPU frequencies since those do not apply. Signed-off-by: Jason Andryuk --- tools/misc/xenpm.c | 45 +++++++++++++++++++++++++++++---------------- 1 file changed, 29 insertions(+), 16 deletions(-) diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index d0191d4984..35223b98df 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -711,6 +711,7 @@ void start_gather_func(int argc, char *argv[]) /* print out parameters about cpu frequency */ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) { + bool internal = strstr(p_cpufreq->scaling_governor, "internal"); int i; printf("cpu id : %d\n", cpuid); @@ -720,10 +721,19 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) printf(" %d", p_cpufreq->affected_cpus[i]); printf("\n"); - printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n", - p_cpufreq->cpuinfo_max_freq, - p_cpufreq->cpuinfo_min_freq, - p_cpufreq->cpuinfo_cur_freq); + if (internal) + { + printf("cpuinfo frequency : base [%u] turbo [%u]\n", + p_cpufreq->cpuinfo_min_freq, + p_cpufreq->cpuinfo_max_freq); + } + else + { + printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n", + p_cpufreq->cpuinfo_max_freq, + p_cpufreq->cpuinfo_min_freq, + p_cpufreq->cpuinfo_cur_freq); + } printf("scaling_driver : %s\n", p_cpufreq->scaling_driver); @@ -750,19 +760,22 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) p_cpufreq->u.ondemand.up_threshold); } - printf("scaling_avail_freq :"); - for ( i = 0; i < p_cpufreq->freq_num; i++ ) - if ( p_cpufreq->scaling_available_frequencies[i] == - p_cpufreq->scaling_cur_freq ) - printf(" *%d", p_cpufreq->scaling_available_frequencies[i]); - else - printf(" %d", p_cpufreq->scaling_available_frequencies[i]); - printf("\n"); + if (!internal) + { + printf("scaling_avail_freq :"); + for ( i = 0; i < p_cpufreq->freq_num; i++ ) + if ( p_cpufreq->scaling_available_frequencies[i] == + p_cpufreq->scaling_cur_freq ) + printf(" *%d", p_cpufreq->scaling_available_frequencies[i]); + else + printf(" %d", p_cpufreq->scaling_available_frequencies[i]); + printf("\n"); - printf("scaling frequency : max [%u] min [%u] cur [%u]\n", - p_cpufreq->scaling_max_freq, - p_cpufreq->scaling_min_freq, - p_cpufreq->scaling_cur_freq); + printf("scaling frequency : max [%u] min [%u] cur [%u]\n", + p_cpufreq->scaling_max_freq, + p_cpufreq->scaling_min_freq, + p_cpufreq->scaling_cur_freq); + } printf("turbo mode : %s\n", p_cpufreq->turbo_enabled ? "enabled" : "disabled or n/a"); -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:03:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:03:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95089.179424 (Exim 4.92) (envelope-from ) id 1lJN1h-0006mc-UT; Mon, 08 Mar 2021 21:02:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95089.179424; Mon, 08 Mar 2021 21:02:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1h-0006mV-Qi; Mon, 08 Mar 2021 21:02:53 +0000 Received: by outflank-mailman (input) for mailman id 95089; Mon, 08 Mar 2021 21:02:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1g-0006P0-J2 for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 21:02:52 +0000 Received: from mail-qk1-x731.google.com (unknown [2607:f8b0:4864:20::731]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 16c4f119-6cfd-4363-b387-aa9243d33cb4; Mon, 08 Mar 2021 21:02:35 +0000 (UTC) Received: by mail-qk1-x731.google.com with SMTP id l4so10891012qkl.0 for ; Mon, 08 Mar 2021 13:02:35 -0800 (PST) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:a33e:daa7:46a1:a7eb]) by smtp.gmail.com with ESMTPSA id r2sm8514070qti.4.2021.03.08.13.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 13:02:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16c4f119-6cfd-4363-b387-aa9243d33cb4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=URsm1yOuvp1SQ/7X/KtWhiPzCJKRQEYt//4KlQf0Bnc=; b=eDfuLm1Hvfmvh4pBO+nYR/75TocdTJ81qDRPc7rGYnK8fud2auS2N7XRHOPTk5bg91 6lHO9sYXeVZHQVs/D8e9FWR8IXB3hnUGOsAbNWBZkAJGHRpR2mEilLasmdpjLHQ6F35S gVpqLT0oCysUoOtLQi4OY2LCdE8moGlCKa2vhm4osNA/kpRyHvfqCSoB6v5DVoZDIB7x vEowajRT3a7ztF7YGdFvX+FM9LOB3ARPEapGC5tvTjnEtdA/l2xSX4cxT1+d/aouXE0v WRTo+ZfgTev9qwuY9ZEP5fQMZuUT//H367YyICw9Ue0yEqfFuHmbzNZfn3bHgOWKcalg /hMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=URsm1yOuvp1SQ/7X/KtWhiPzCJKRQEYt//4KlQf0Bnc=; b=pdgkwC2z5g9Xynns4qxum7US5xrYhOMfmw6jrWn5z72jDPziPMX1EaAhBtDfI2NHCx 6vLo59chi6V/VzBj/Y+CmP3ltIjoJ2CPDFw9mh0SkdsAlYy3GWmASl9Pl/XkQMHqcJsh LS7hlvqvBnWH77hRuNLLfPY3Dj74q6vrqPJQPazQMdUzDbzNnez0DK4IBAmoPLJDpQx8 47P1WcQiiOlxuScSvwNsXHdPkt441cGQzIdLwbek4G8q/m3Zc80jgtaiirPov4uXKVZc XRenVxsesJIf8zid5hv7moWzF85nVRcOHd6ZQM565mJQegBryFBSohGr7tJCPs4uRKz0 gb8A== X-Gm-Message-State: AOAM531TcIggsYNrz7aFQP+6W49/su/u6Vm/aOwt08NzXT9Txq3dLjTl A0AVeAB1yJlaEfeLditG0kk9TkHg0UQ= X-Google-Smtp-Source: ABdhPJy5hyPJly4pN5b+0G4ry9ay0NRrqf8uwMD/OcP5ZVaVBeGf/cvkzt//bzPRlZYop2dmt/enOg== X-Received: by 2002:a37:8506:: with SMTP id h6mr22178160qkd.134.1615237354971; Mon, 08 Mar 2021 13:02:34 -0800 (PST) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: pawel@invisiblethingslab.com, marmarek@invisiblethingslab.com, Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini Subject: [RFC 06/12] cpufreq: Export HWP parameters to userspace Date: Mon, 8 Mar 2021 16:02:04 -0500 Message-Id: <20210308210210.116278-7-jandryuk@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210308210210.116278-1-jandryuk@gmail.com> References: <20210308210210.116278-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Extend xen_get_cpufreq_para to return hwp parameters. These match the hardware rather closely. We need the hw_features bitmask to indicated fields supported by the actual hardware. The use of uint8_t parameters matches the hardware size. uint32_t entries grows the sysctl_t past the build assertion in setup.c. The uint8_t ranges are supported across multiple generations, so hopefully they won't change. Increment XEN_SYSCTL_INTERFACE_VERSION for the new fields. Signed-off-by: Jason Andryuk --- xen/arch/x86/acpi/cpufreq/hwp.c | 24 ++++++++++++++++++++++++ xen/drivers/acpi/pmstat.c | 6 ++++++ xen/include/acpi/cpufreq/cpufreq.h | 3 +++ xen/include/public/sysctl.h | 20 +++++++++++++++++++- 4 files changed, 52 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/acpi/cpufreq/hwp.c b/xen/arch/x86/acpi/cpufreq/hwp.c index f8e6fdbd41..92222d6d85 100644 --- a/xen/arch/x86/acpi/cpufreq/hwp.c +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -523,6 +523,30 @@ static const struct cpufreq_driver __initconstrel hwp_cpufreq_driver = .update = hwp_cpufreq_update, }; +int get_hwp_para(struct cpufreq_policy *policy, struct xen_hwp_para *hwp_para) +{ + unsigned int cpu = policy->cpu; + struct hwp_drv_data *data = hwp_drv_data[cpu]; + + if ( data == NULL ) + return -EINVAL; + + hwp_para->hw_feature = + feature_hwp_activity_window ? XEN_SYSCTL_HWP_FEAT_ACT_WINDOW : 0 | + feature_hwp_energy_perf ? XEN_SYSCTL_HWP_FEAT_ENERGY_PERF : 0; + hwp_para->hw_lowest = data->hw_lowest; + hwp_para->hw_most_efficient = data->hw_most_efficient; + hwp_para->hw_guaranteed = data->hw_guaranteed; + hwp_para->hw_highest = data->hw_highest; + hwp_para->minimum = data->minimum; + hwp_para->maximum = data->maximum; + hwp_para->energy_perf = data->energy_perf; + hwp_para->activity_window = data->activity_window; + hwp_para->desired = data->desired; + + return 0; +} + int hwp_register_driver(void) { int ret; diff --git a/xen/drivers/acpi/pmstat.c b/xen/drivers/acpi/pmstat.c index 2f528f9ca3..4c6ae5d768 100644 --- a/xen/drivers/acpi/pmstat.c +++ b/xen/drivers/acpi/pmstat.c @@ -290,6 +290,12 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op) &op->u.get_para.u.ondemand.sampling_rate, &op->u.get_para.u.ondemand.up_threshold); } + + if ( !strnicmp(op->u.get_para.scaling_governor, + "hwp-internal", CPUFREQ_NAME_LEN) ) + { + ret = get_hwp_para(policy, &op->u.get_para.u.hwp_para); + } op->u.get_para.turbo_enabled = cpufreq_get_turbo_status(op->cpuid); return ret; diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index b91859ce5d..42146ca2cf 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -246,4 +246,7 @@ int write_userspace_scaling_setspeed(unsigned int cpu, unsigned int freq); void cpufreq_dbs_timer_suspend(void); void cpufreq_dbs_timer_resume(void); +/********************** hwp hypercall helper *************************/ +int get_hwp_para(struct cpufreq_policy *policy, struct xen_hwp_para *hwp_para); + #endif /* __XEN_CPUFREQ_PM_H__ */ diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 039ccf885c..1a6c6397ea 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -35,7 +35,7 @@ #include "domctl.h" #include "physdev.h" -#define XEN_SYSCTL_INTERFACE_VERSION 0x00000013 +#define XEN_SYSCTL_INTERFACE_VERSION 0x00000014 /* * Read console content from Xen buffer ring. @@ -301,6 +301,23 @@ struct xen_ondemand { uint32_t up_threshold; }; +struct xen_hwp_para { + uint16_t activity_window; /* 7bit mantissa and 3bit exponent */ +#define XEN_SYSCTL_HWP_FEAT_ENERGY_PERF (1 << 0) /* energy_perf range 0-255 if + 1. Otherwise 0-15 */ +#define XEN_SYSCTL_HWP_FEAT_ACT_WINDOW (1 << 1) /* activity_window supported + if 1 */ + uint8_t hw_feature; /* bit flags for features */ + uint8_t hw_lowest; + uint8_t hw_most_efficient; + uint8_t hw_guaranteed; + uint8_t hw_highest; + uint8_t minimum; + uint8_t maximum; + uint8_t desired; + uint8_t energy_perf; +}; + /* * cpufreq para name of this structure named * same as sysfs file name of native linux @@ -332,6 +349,7 @@ struct xen_get_cpufreq_para { union { struct xen_userspace userspace; struct xen_ondemand ondemand; + struct xen_hwp_para hwp_para; } u; int32_t turbo_enabled; -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:03:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:03:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95091.179436 (Exim 4.92) (envelope-from ) id 1lJN1n-0006si-91; Mon, 08 Mar 2021 21:02:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95091.179436; Mon, 08 Mar 2021 21:02:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1n-0006sZ-4k; Mon, 08 Mar 2021 21:02:59 +0000 Received: by outflank-mailman (input) for mailman id 95091; Mon, 08 Mar 2021 21:02:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1l-0006P0-JQ for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 21:02:57 +0000 Received: from mail-qk1-x72d.google.com (unknown [2607:f8b0:4864:20::72d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 929150ee-f530-4c37-ad0d-a0a8ea0316b0; Mon, 08 Mar 2021 21:02:37 +0000 (UTC) Received: by mail-qk1-x72d.google.com with SMTP id 130so10828068qkh.11 for ; Mon, 08 Mar 2021 13:02:37 -0800 (PST) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:a33e:daa7:46a1:a7eb]) by smtp.gmail.com with ESMTPSA id r2sm8514070qti.4.2021.03.08.13.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 13:02:36 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 929150ee-f530-4c37-ad0d-a0a8ea0316b0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m/HjIThexqCtGTUE+J7vbjJvC1aFn2t5c5WE3e2oBTE=; b=RCFeNNKi1ZTNaOrIH4J6hj0WjaDml4hOia1YsYTeDXpZWZgN3fsTxvQw3oqU/Uvrxz qpUwpr7j/lnAx4i4nyocPCEU8L3y4WEv9yNS3377HUzVyEGz74+iRb4bMcMcEtFxApQo T14Jd0et8eK22NKvxjPr3FleW6fSp0afabP/vqn+OdJNQDqlyQXqOIE+otd36j6aArpo nrNAr7GU7pGXQ43Hf7anyVoFCzPJUO8aRsOScTPDYxBCpF3go9lth0s7A2P7AlLsjlNi l58BHWsF+FAwUpUOmLaNlQ4lVApDr543D+N65LmsEX/Esl3f+gfKRN6OUBeeLjBxApXk p/0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m/HjIThexqCtGTUE+J7vbjJvC1aFn2t5c5WE3e2oBTE=; b=NlYocIUWStr7R/iGzPJYMlIX3acpRmZmBK8904rVA3t4IgDEgwIgkvbSg/qC3KK6uw n2b08Gh5rM+hZYyr451HRLokcOgCOAuaerQaHFgxy8jkNQTJr8b0qqocbW19YLsJycuF L6WNSPLSml05onl3V3pBSG96dzBQWf4YD4P70fdcHnvaZ0I7unMqerLXk045kiF9G1AX ZWs+sgmGFYXWkShrwmW5QlLux7QSb2s22SAMEyGc6jLh+LWth3JW02IItRbruaYIqHoJ 9G50VA+3zW0pYEZKD1PM67+ZtpQ9vTcQ8mb9VAlM5w7Dzo4codHODkC7+v+DS9rWI6cu wiBA== X-Gm-Message-State: AOAM530NVqYJqSh/GkKUSgZqDk10L1inW/DoOaYqjW0UFRE+RymEM+Qz CDIZvY1sogZrxrIk2J0ulPtUgSkyQe0= X-Google-Smtp-Source: ABdhPJxrrXBf/RUi4dQsnOrnyYQBD4xXTzxBGfDL8KwuxbIZxjqMfhGYeXkknf0j6C+U4kUtqIJGmA== X-Received: by 2002:a37:86c5:: with SMTP id i188mr23385057qkd.325.1615237357093; Mon, 08 Mar 2021 13:02:37 -0800 (PST) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: pawel@invisiblethingslab.com, marmarek@invisiblethingslab.com, Jason Andryuk , Ian Jackson , Wei Liu Subject: [RFC 07/12] libxc: Include hwp_para in definitions Date: Mon, 8 Mar 2021 16:02:05 -0500 Message-Id: <20210308210210.116278-8-jandryuk@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210308210210.116278-1-jandryuk@gmail.com> References: <20210308210210.116278-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Expose the hwp_para fields through libxc. Signed-off-by: Jason Andryuk --- tools/include/xenctrl.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 318920166c..3b0ca62fc7 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1960,6 +1960,7 @@ int xc_smt_disable(xc_interface *xch); */ typedef struct xen_userspace xc_userspace_t; typedef struct xen_ondemand xc_ondemand_t; +typedef struct xen_hwp_para xc_hwp_para_t; struct xc_get_cpufreq_para { /* IN/OUT variable */ @@ -1987,6 +1988,7 @@ struct xc_get_cpufreq_para { union { xc_userspace_t userspace; xc_ondemand_t ondemand; + xc_hwp_para_t hwp_para; } u; int32_t turbo_enabled; -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:03:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:03:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95093.179448 (Exim 4.92) (envelope-from ) id 1lJN1s-0006yX-OD; Mon, 08 Mar 2021 21:03:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95093.179448; Mon, 08 Mar 2021 21:03:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1s-0006yB-Ho; Mon, 08 Mar 2021 21:03:04 +0000 Received: by outflank-mailman (input) for mailman id 95093; Mon, 08 Mar 2021 21:03:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1q-0006P0-JW for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 21:03:02 +0000 Received: from mail-qt1-x829.google.com (unknown [2607:f8b0:4864:20::829]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id af455b62-6776-4542-b122-5dd34a88e29a; Mon, 08 Mar 2021 21:02:39 +0000 (UTC) Received: by mail-qt1-x829.google.com with SMTP id d11so8625308qtx.9 for ; Mon, 08 Mar 2021 13:02:39 -0800 (PST) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:a33e:daa7:46a1:a7eb]) by smtp.gmail.com with ESMTPSA id r2sm8514070qti.4.2021.03.08.13.02.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 13:02:38 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af455b62-6776-4542-b122-5dd34a88e29a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N7yhEOqzJ0+x+JlQs3Sjsvl85JThC2zfENNxFodtLhk=; b=XwM+qLg2re6gp7d448+Z4XdF/EiedVpR0jSynMw3g0qTHhS+Schv8AjGvL+oKpNBcs aEEDdUOtQqtTmnZou2IGTaWScV60rmV3M77Qi4OzeRe5pbz4+3r14j2xh4/ZD9A8M/if pYeBWXijdo3EIVNXKgw1UhHD3YYZJ4iRqcLCl/kKogzReEEQDFU2MfLzprkBCslk1Hwh u7XytJhJSDyx36+Wq6c2Da+mdBXEh+CMID5qDo9/aqpzGx2p5pkUsAvZqHgYGNJvWcxn 3Rrv1pT6jaSyFusmAzGA8N5fuw93FhJBQcvztMZeP5ZS2Cp71fkluy6xbYy4jeYrpiWn IwKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N7yhEOqzJ0+x+JlQs3Sjsvl85JThC2zfENNxFodtLhk=; b=RiHfa1JTGh2w71SVvqDmoYYSL8GrhtlOwV4ZKUZQKs3VHpiBx+QtJPGKNwsNDD/4Ye HbB7Vqn3A8685P5OE3vsn5769Rp6ETIBFNsMNJWhuTN76HDsztu6znLtKTTRXHOg3kEa cS9d0GWmP5vXebkW8hIxzRNDdwys9AzH3oSINR3hQOA5ohW9UwQoZANy6quleycc0/y0 /AyGZs7EvMYVLBwP9pZAW++TnrNmPYST7NeOtZzAEFHtD0AZJOGsM3PrAjWu0TDfF9GU iuJHrgueeXrzeAwg3qPw2maKdX+xPRZjUuzEMlAwpijdx407LJHaDo+YbpTceW+uBq/D bA3Q== X-Gm-Message-State: AOAM532J+447TjJFohYC2dUPkZMr0eHFgRj9SBfr5R5rZZWlu7Ofn2s2 /sdscRf3ByU3mj1Wj0A68MnN1z1kJrM= X-Google-Smtp-Source: ABdhPJwf/dEzlun0+1V5RJMcQcxl6otvf+cIsUSOblP40ak/2X+oSRlaOUr+jhESxrlKhl+kVu61eg== X-Received: by 2002:ac8:6988:: with SMTP id o8mr22523226qtq.24.1615237358791; Mon, 08 Mar 2021 13:02:38 -0800 (PST) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: pawel@invisiblethingslab.com, marmarek@invisiblethingslab.com, Jason Andryuk , Ian Jackson , Wei Liu Subject: [RFC 08/12] xenpm: Print HWP parameters Date: Mon, 8 Mar 2021 16:02:06 -0500 Message-Id: <20210308210210.116278-9-jandryuk@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210308210210.116278-1-jandryuk@gmail.com> References: <20210308210210.116278-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Print HWP-specific parameters. Some are always present, but others depend on hardware support. Signed-off-by: Jason Andryuk --- tools/misc/xenpm.c | 75 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 73 insertions(+), 2 deletions(-) diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index 35223b98df..9588dac991 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -708,6 +708,43 @@ void start_gather_func(int argc, char *argv[]) pause(); } +static void calculate_hwp_activity_window(const xc_hwp_para_t *hwp, + unsigned int *activity_window, + const char **units) +{ + unsigned int mantissa = hwp->activity_window & 0x7f; + unsigned int exponent = ( hwp->activity_window >> 7 ) & 0x7; + unsigned int multiplier = 1; + + if ( hwp->activity_window == 0 ) + { + *units = "hardware selected"; + *activity_window = 0; + + return; + } + + if ( exponent >= 6 ) + { + *units = "s"; + exponent -= 6; + } + else if ( exponent >= 3 ) + { + *units = "ms"; + exponent -= 3; + } + else + { + *units = "us"; + } + + for ( unsigned int i = 0; i < exponent; i++ ) + multiplier *= 10; + + *activity_window = mantissa * multiplier; +} + /* print out parameters about cpu frequency */ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) { @@ -721,7 +758,7 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) printf(" %d", p_cpufreq->affected_cpus[i]); printf("\n"); - if (internal) + if ( internal ) { printf("cpuinfo frequency : base [%u] turbo [%u]\n", p_cpufreq->cpuinfo_min_freq, @@ -760,7 +797,7 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) p_cpufreq->u.ondemand.up_threshold); } - if (!internal) + if ( !internal ) { printf("scaling_avail_freq :"); for ( i = 0; i < p_cpufreq->freq_num; i++ ) @@ -777,6 +814,40 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) p_cpufreq->scaling_cur_freq); } + if ( strcmp(p_cpufreq->scaling_governor, "hwp-internal") == 0 ) + { + const xc_hwp_para_t *hwp = &p_cpufreq->u.hwp_para; + + printf("hwp variables :\n"); + printf(" hardware limits : lowest [%u] most_efficient [%u]\n", + hwp->hw_lowest, hwp->hw_most_efficient); + printf(" hardware limits : guaranteed [%u] highest [%u]\n", + hwp->hw_guaranteed, hwp->hw_highest); + printf(" configured limits : min [%u] max [%u] energy_perf [%u]\n", + hwp->minimum, hwp->maximum, hwp->energy_perf); + + if ( hwp->hw_feature & XEN_SYSCTL_HWP_FEAT_ENERGY_PERF ) + { + printf(" configured limits : energy_perf [%u%s]\n", + hwp->energy_perf, + hwp->energy_perf ? "" : " hw autonomous"); + } + + if ( hwp->hw_feature & XEN_SYSCTL_HWP_FEAT_ACT_WINDOW ) + { + unsigned int activity_window; + const char *units; + + calculate_hwp_activity_window(hwp, &activity_window, &units); + printf(" configured limits : activity_window [%u %s]\n", + activity_window, units); + } + + printf(" configured limits : desired [%u%s]\n", + hwp->desired, + hwp->desired ? "" : " hw autonomous"); + } + printf("turbo mode : %s\n", p_cpufreq->turbo_enabled ? "enabled" : "disabled or n/a"); printf("\n"); -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:03:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:03:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95095.179460 (Exim 4.92) (envelope-from ) id 1lJN1x-00073i-1k; Mon, 08 Mar 2021 21:03:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95095.179460; Mon, 08 Mar 2021 21:03:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1w-00073W-Tq; Mon, 08 Mar 2021 21:03:08 +0000 Received: by outflank-mailman (input) for mailman id 95095; Mon, 08 Mar 2021 21:03:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN1v-0006P0-Ja for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 21:03:07 +0000 Received: from mail-qk1-x734.google.com (unknown [2607:f8b0:4864:20::734]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 29c4ded8-0d52-4eb0-bfdd-c476ea12c676; Mon, 08 Mar 2021 21:02:41 +0000 (UTC) Received: by mail-qk1-x734.google.com with SMTP id n79so10866761qke.3 for ; Mon, 08 Mar 2021 13:02:41 -0800 (PST) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:a33e:daa7:46a1:a7eb]) by smtp.gmail.com with ESMTPSA id r2sm8514070qti.4.2021.03.08.13.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 13:02:40 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29c4ded8-0d52-4eb0-bfdd-c476ea12c676 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oqpttayW0aZRbW0lV0dPSojE1v4QDHZLq85y9vWsmqg=; b=UGXM5D94i40l2yF+567mUWT4APPSKuPbrSXJMkZg5BuwjlTOivLZV1fz9bTrNSSvgG Y8V2o1+yEKAer5QYuFyKFlNTGr6vF0XNtjWCpUvFED2sKYG8aeGFnd3sM7HVzlsHeLFe oJ8ianhNT27nrsSspcoW72aLFh8qeMG9LRK0szHmMUFoX3+Lq/GmY2yXQabpXvitgLzd LE0qBvkIcivh+TrHpbIXFCkNYViEraua5Z8FFMUBuBkC/CT08KmY3rq9AQwBHsCfSoAv 23IoIAimOcZBvsS7CGM86b6Y1A3tJmcQwA44/b9KkQLXSBYonkp3glBlzJx0V+ni6TZw Q5rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oqpttayW0aZRbW0lV0dPSojE1v4QDHZLq85y9vWsmqg=; b=EmDn2PmUx9+2q0ssbdSrpQb5SxkaEdnZriJWF97yXKz6Gi1biHXdMmZJYzLTjdafgz V0csgLAeQ5+eVOHzN4zTz4P3GErMkmC4kvXIrIdUHYC0WBsMJ8R1wCrThipEXD4dF1zt IzjNiNt102/NOh2AL/fqeU9Gc6GMHXgpi3JAOCLRls6fZxY7qowblMRretyEQmqL0atF wMpp3Qi5wtQo5XfxLyUMgVHavpt71vupuGIDriMcK+gWQSbAcLjFMQxlLXCz/xrxmeJ6 /7fXRB3s34apV//ZX/WIMEJBMs1cFmF9XUdJHamzvfElTTxnM3MlC6wCFXheE5vgdk6u ELPQ== X-Gm-Message-State: AOAM530SL2IdIjD4x/h/z+26AhcEwTt7g0/hw1Left7cn3DFRohrBInt yPNdn6t83HA8QKjpHhPew11iT2hFDhE= X-Google-Smtp-Source: ABdhPJyqwDLmfPxTONGiGVA9Gikx8JwFOaXo2DpQOeXb59DhjVX/AiDXt98uOkdo6jfnCJ6vkD0SzA== X-Received: by 2002:a37:a8cd:: with SMTP id r196mr21870295qke.451.1615237361005; Mon, 08 Mar 2021 13:02:41 -0800 (PST) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: pawel@invisiblethingslab.com, marmarek@invisiblethingslab.com, Jason Andryuk , Ian Jackson , Wei Liu Subject: [RFC 09/12] xenpm: Factor out a non-fatal cpuid_parse variant Date: Mon, 8 Mar 2021 16:02:07 -0500 Message-Id: <20210308210210.116278-10-jandryuk@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210308210210.116278-1-jandryuk@gmail.com> References: <20210308210210.116278-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Allow cpuid_prase to be re-used without terminating xenpm. HWP will re-use it to optionally parse a cpuid. Signed-off-by: Jason Andryuk --- tools/misc/xenpm.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index 9588dac991..a686f8f46e 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -79,17 +79,26 @@ void help_func(int argc, char *argv[]) show_help(); } -static void parse_cpuid(const char *arg, int *cpuid) +static int parse_cpuid_non_fatal(const char *arg, int *cpuid) { if ( sscanf(arg, "%d", cpuid) != 1 || *cpuid < 0 ) { if ( strcasecmp(arg, "all") ) - { - fprintf(stderr, "Invalid CPU identifier: '%s'\n", arg); - exit(EINVAL); - } + return -1; + *cpuid = -1; } + + return 0; +} + +static void parse_cpuid(const char *arg, int *cpuid) +{ + if ( parse_cpuid_non_fatal(arg, cpuid) ) + { + fprintf(stderr, "Invalid CPU identifier: '%s'\n", arg); + exit(EINVAL); + } } static void parse_cpuid_and_int(int argc, char *argv[], -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:07:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:07:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95113.179490 (Exim 4.92) (envelope-from ) id 1lJN6W-0007eB-Kf; Mon, 08 Mar 2021 21:07:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95113.179490; Mon, 08 Mar 2021 21:07:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN6W-0007dw-DW; Mon, 08 Mar 2021 21:07:52 +0000 Received: by outflank-mailman (input) for mailman id 95113; Mon, 08 Mar 2021 21:07:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN20-0006P0-Ji for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 21:03:12 +0000 Received: from mail-qk1-x736.google.com (unknown [2607:f8b0:4864:20::736]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9253dcf0-30d1-406f-9ad7-c76617ddff7d; Mon, 08 Mar 2021 21:02:43 +0000 (UTC) Received: by mail-qk1-x736.google.com with SMTP id x10so10850799qkm.8 for ; Mon, 08 Mar 2021 13:02:43 -0800 (PST) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:a33e:daa7:46a1:a7eb]) by smtp.gmail.com with ESMTPSA id r2sm8514070qti.4.2021.03.08.13.02.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 13:02:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9253dcf0-30d1-406f-9ad7-c76617ddff7d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DENgrNRtv6VqhXdN7bwMgqWd+ZEOEb0cKD59zRjtD8M=; b=UczG4KIoK8rcZkEfAoJEDFB67oT1oBpn6mPTCGAyPZXQMNzbEb16A1xG0qFl81ZfIz dMJKQYrPmnzILSVKr+TQyog/AY1R45POo24dsDz6giY7R/V/q02y35+5bQIGtnFX9/WD 83f8GtB71PPeqwHV7+Q3ReC33EEbgpmgyLN+KrajYRqorIlpOok8CMOpvFnJb/Cdk/i/ DyqAI98bZg/gqWEkjQpyyxf7wckb2UAEKFDGJHYqhacm3KvL5wnE8APYkX9ZaEX5h9uv kNp4Lz+DqmS449E5VXiNl0XOghIlhZoREn5hLwPKKYd5VTpwIWb9V72F20o6+dEKZZJE Hq9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DENgrNRtv6VqhXdN7bwMgqWd+ZEOEb0cKD59zRjtD8M=; b=cwurFsj3NJi0cCkqebxuwZfu4SbUk+4ccxFiV3CoKYIA1toy6iw1yp1NBT8E7dusFU 5AZsb++X6dl7iLOtfuKtwYkLBylqF4ol5wP72TmtwWiGWx3V5dsZZ0D1JTUSTo3k+22W I8oV/nbjfJ+8aanQN0EXGRzkXfH7P7lFuWB5MtIdSJBpe5HfoSA6flJKcrpYb8wLehu4 /4Ms4EOD/nTvWnpr+/ZxUXNv3ZvUyOmnfq1PfIzhc7BnEeTJNlFn0P0k1KhVDfcbXJu8 xyARW2/iBmYnaAoqBzzjJ+tsUTXQjSUBv8rpVAfw3ZpAlUT+t2gOgJxC9WoWgu3B0A+b dJsg== X-Gm-Message-State: AOAM533mEBVq298cwqVr93BE11z4/2jPYFDByr5WLSa7wmUTciXR333S gbx2xrP98dsPt274yFVRk6SbX3nbds4= X-Google-Smtp-Source: ABdhPJx3VChIdkS3wbpj2fKyih2E+kGuiwMbtNbLUgGeP4mAR/bBwF0IIsD8dvTOIbaN9Aj+Hn22jg== X-Received: by 2002:a05:620a:41:: with SMTP id t1mr22741875qkt.322.1615237362911; Mon, 08 Mar 2021 13:02:42 -0800 (PST) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: pawel@invisiblethingslab.com, marmarek@invisiblethingslab.com, Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini Subject: [RFC 10/12] xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op Date: Mon, 8 Mar 2021 16:02:08 -0500 Message-Id: <20210308210210.116278-11-jandryuk@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210308210210.116278-1-jandryuk@gmail.com> References: <20210308210210.116278-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add SET_CPUFREQ_HWP xen_sysctl_pm_op to set HWP parameters. The sysctl supports setting multiple values simultaneously as indicated by the set_params bits. This allows atomically applying new HWP configuration via a single wrmsr. XEN_SYSCTL_HWP_SET_PRESET_BALANCE/PERFORMANCE/POWERSAVE provide three common presets. Setting them depends on hardware limits which the hypervisor is already caching. So using them allows skipping a hypercall to query the limits (hw_lowest/highest) to then set those same values. The code is organized to allow a preset to be refined with additional stuff if desired. "most_efficient" and "guaranteed" could be additional presets in the future, but the are not added now. Those levels can change at runtime, but we don't have code in place to monitor and update for those events. Signed-off-by: Jason Andryuk --- xen/arch/x86/acpi/cpufreq/hwp.c | 113 +++++++++++++++++++++++++++++ xen/drivers/acpi/pmstat.c | 24 ++++++ xen/include/acpi/cpufreq/cpufreq.h | 2 + xen/include/public/sysctl.h | 32 ++++++++ 4 files changed, 171 insertions(+) diff --git a/xen/arch/x86/acpi/cpufreq/hwp.c b/xen/arch/x86/acpi/cpufreq/hwp.c index 92222d6d85..8f4b18d246 100644 --- a/xen/arch/x86/acpi/cpufreq/hwp.c +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -547,6 +547,119 @@ int get_hwp_para(struct cpufreq_policy *policy, struct xen_hwp_para *hwp_para) return 0; } +int set_hwp_para(struct cpufreq_policy *policy, + struct xen_set_hwp_para *set_hwp) +{ + unsigned int cpu = policy->cpu; + struct hwp_drv_data *data = hwp_drv_data[cpu]; + + if ( data == NULL ) + return -EINVAL; + + /* Validate all parameters first */ + if ( set_hwp->set_params & ~XEN_SYSCTL_HWP_SET_PARAM_MASK ) + { + hwp_err("Invalid bits in hwp set_params %u\n", + set_hwp->set_params); + + return -EINVAL; + } + + if ( set_hwp->activity_window & ~XEN_SYSCTL_HWP_ACT_WINDOW_MASK ) + { + hwp_err("Invalid bits in activity window %u\n", + set_hwp->activity_window); + + return -EINVAL; + } + + if ( !feature_hwp_energy_perf && + set_hwp->set_params & XEN_SYSCTL_HWP_SET_ENERGY_PERF && + set_hwp->energy_perf > 0xf ) + { + hwp_err("energy_perf %u out of range for IA32_ENERGY_PERF_BIAS\n", + set_hwp->energy_perf); + + return -EINVAL; + } + + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_DESIRED && + ( set_hwp->desired < data->hw_lowest || + set_hwp->desired > data->hw_highest ) ) + { + hwp_err("hwp desired %u is out of range (%u ... %u)\n", + set_hwp->desired, data->hw_lowest, data->hw_highest); + + return -EINVAL; + } + + /* + * minimum & maximum are not validated as hardware doesn't seem to care + * and the SDM says CPUs will clip internally. + */ + + /* Apply presets */ + switch ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_PRESET_MASK ) + { + case XEN_SYSCTL_HWP_SET_PRESET_POWERSAVE: + data->minimum = data->hw_lowest; + data->maximum = data->hw_lowest; + data->activity_window = 0; + if ( feature_hwp_energy_perf ) + data->energy_perf = 0xff; + else + data->energy_perf = 0xf; + data->desired = 0; + break; + case XEN_SYSCTL_HWP_SET_PRESET_PERFORMANCE: + data->minimum = data->hw_highest; + data->maximum = data->hw_highest; + data->activity_window = 0; + data->energy_perf = 0; + data->desired = 0; + break; + case XEN_SYSCTL_HWP_SET_PRESET_BALANCE: + data->minimum = data->hw_lowest; + data->maximum = data->hw_highest; + data->activity_window = 0; + data->energy_perf = 0x80; + if ( feature_hwp_energy_perf ) + data->energy_perf = 0x80; + else + data->energy_perf = 0x7; + data->desired = 0; + break; + case XEN_SYSCTL_HWP_SET_PRESET_NONE: + break; + default: + printk("HWP: Invalid preset value: %u\n", + set_hwp->set_params & XEN_SYSCTL_HWP_SET_PRESET_MASK); + + return -EINVAL; + } + + /* Further customize presets if needed */ + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_MINIMUM ) + data->minimum = set_hwp->minimum; + + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_MAXIMUM ) + data->maximum = set_hwp->maximum; + + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_ENERGY_PERF ) + data->energy_perf = set_hwp->energy_perf; + + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_DESIRED ) + data->desired = set_hwp->desired; + + if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_ACT_WINDOW ) + data->activity_window = set_hwp->activity_window & + XEN_SYSCTL_HWP_ACT_WINDOW_MASK; + + hwp_cpufreq_target(policy, 0, 0); + + return 0; +} + int hwp_register_driver(void) { int ret; diff --git a/xen/drivers/acpi/pmstat.c b/xen/drivers/acpi/pmstat.c index 4c6ae5d768..860bf4db61 100644 --- a/xen/drivers/acpi/pmstat.c +++ b/xen/drivers/acpi/pmstat.c @@ -318,6 +318,24 @@ static int set_cpufreq_gov(struct xen_sysctl_pm_op *op) return __cpufreq_set_policy(old_policy, &new_policy); } +static int set_cpufreq_hwp(struct xen_sysctl_pm_op *op) +{ + struct cpufreq_policy *policy; + + if ( !cpufreq_governor_internal ) + return -EINVAL; + + policy = per_cpu(cpufreq_cpu_policy, op->cpuid); + + if ( !policy || !policy->governor ) + return -EINVAL; + + if ( strnicmp(policy->governor->name, "hwp-internal", CPUFREQ_NAME_LEN) ) + return -EINVAL; + + return set_hwp_para(policy, &op->u.set_hwp); +} + static int set_cpufreq_para(struct xen_sysctl_pm_op *op) { int ret = 0; @@ -465,6 +483,12 @@ int do_pm_op(struct xen_sysctl_pm_op *op) break; } + case SET_CPUFREQ_HWP: + { + ret = set_cpufreq_hwp(op); + break; + } + case SET_CPUFREQ_PARA: { ret = set_cpufreq_para(op); diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 42146ca2cf..7ff7d0d4bb 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -248,5 +248,7 @@ void cpufreq_dbs_timer_resume(void); /********************** hwp hypercall helper *************************/ int get_hwp_para(struct cpufreq_policy *policy, struct xen_hwp_para *hwp_para); +int set_hwp_para(struct cpufreq_policy *policy, + struct xen_set_hwp_para *set_hwp); #endif /* __XEN_CPUFREQ_PM_H__ */ diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 1a6c6397ea..3f18a3d522 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -318,6 +318,36 @@ struct xen_hwp_para { uint8_t energy_perf; }; +/* set multiple values simultaneously when set_args bit is set */ +struct xen_set_hwp_para { + uint16_t set_params; /* bitflags for valid values */ +#define XEN_SYSCTL_HWP_SET_DESIRED (1U << 0) +#define XEN_SYSCTL_HWP_SET_ENERGY_PERF (1U << 1) +#define XEN_SYSCTL_HWP_SET_ACT_WINDOW (1U << 2) +#define XEN_SYSCTL_HWP_SET_MINIMUM (1U << 3) +#define XEN_SYSCTL_HWP_SET_MAXIMUM (1U << 4) +#define XEN_SYSCTL_HWP_SET_PRESET_MASK (0xf000) +#define XEN_SYSCTL_HWP_SET_PRESET_NONE (0x0000) +#define XEN_SYSCTL_HWP_SET_PRESET_BALANCE (0x1000) +#define XEN_SYSCTL_HWP_SET_PRESET_POWERSAVE (0x2000) +#define XEN_SYSCTL_HWP_SET_PRESET_PERFORMANCE (0x3000) +#define XEN_SYSCTL_HWP_SET_PARAM_MASK ((uint16_t)( \ + XEN_SYSCTL_HWP_SET_PRESET_MASK | \ + XEN_SYSCTL_HWP_SET_DESIRED | \ + XEN_SYSCTL_HWP_SET_ENERGY_PERF | \ + XEN_SYSCTL_HWP_SET_ACT_WINDOW | \ + XEN_SYSCTL_HWP_SET_MINIMUM | \ + XEN_SYSCTL_HWP_SET_MAXIMUM )) + + uint16_t activity_window; /* 7bit mantissa and 3bit exponent */ +#define XEN_SYSCTL_HWP_ACT_WINDOW_MASK (0x03ff) + uint8_t minimum; + uint8_t maximum; + uint8_t desired; + uint8_t energy_perf; /* 0-255 or 0-15 depending on HW support */ +}; + + /* * cpufreq para name of this structure named * same as sysfs file name of native linux @@ -379,6 +409,7 @@ struct xen_sysctl_pm_op { #define SET_CPUFREQ_GOV (CPUFREQ_PARA | 0x02) #define SET_CPUFREQ_PARA (CPUFREQ_PARA | 0x03) #define GET_CPUFREQ_AVGFREQ (CPUFREQ_PARA | 0x04) + #define SET_CPUFREQ_HWP (CPUFREQ_PARA | 0x05) /* set/reset scheduler power saving option */ #define XEN_SYSCTL_pm_op_set_sched_opt_smt 0x21 @@ -405,6 +436,7 @@ struct xen_sysctl_pm_op { struct xen_get_cpufreq_para get_para; struct xen_set_cpufreq_gov set_gov; struct xen_set_cpufreq_para set_para; + struct xen_set_hwp_para set_hwp; uint64_aligned_t get_avgfreq; uint32_t set_sched_opt_smt; #define XEN_SYSCTL_CX_UNLIMITED 0xffffffff -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:07:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:07:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95111.179481 (Exim 4.92) (envelope-from ) id 1lJN6W-0007dG-99; Mon, 08 Mar 2021 21:07:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95111.179481; Mon, 08 Mar 2021 21:07:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN6W-0007d7-1Z; Mon, 08 Mar 2021 21:07:52 +0000 Received: by outflank-mailman (input) for mailman id 95111; Mon, 08 Mar 2021 21:07:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN25-0006P0-Jk for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 21:03:17 +0000 Received: from mail-qt1-x82d.google.com (unknown [2607:f8b0:4864:20::82d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1a6da784-fe9b-49da-bd27-6060c32b14c3; Mon, 08 Mar 2021 21:02:45 +0000 (UTC) Received: by mail-qt1-x82d.google.com with SMTP id w6so8655624qti.6 for ; Mon, 08 Mar 2021 13:02:45 -0800 (PST) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:a33e:daa7:46a1:a7eb]) by smtp.gmail.com with ESMTPSA id r2sm8514070qti.4.2021.03.08.13.02.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 13:02:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a6da784-fe9b-49da-bd27-6060c32b14c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rVtlX4LAnp5jRUKVkmkEc1GA5I4vbGffEAZm21QjQrM=; b=eH2n4iUAB2+95HjUtKYHsMFrWKuAIs+a2kPamNBPo+kMHSFIyvtZE79ZYIdgEfeK6l y0ni+1qQDOUE+zmAIHmGQEIaYSBkZOWu6HiDcuNY/siQpIsanZpz9t23Bnokwmxxu9DZ K9EMpdGG5FDFfSGtVFLS0tigh4zB9JPK3aQ4kFoHhgXwHoWby7eVhrhawY6kwmHzBoU4 Y6KsI9N80zxxGO723ZShW22iXhz10LlakmRgIFCaU4uEPKjpO9vSc2FA/95V6can/+TL 36y+e3nQ9/Wfk2ngdzo1xuuGnGxRyf9Oocg+v2gaAUvliRQFdoRGNfvwVTGmnJb7KoJW smqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rVtlX4LAnp5jRUKVkmkEc1GA5I4vbGffEAZm21QjQrM=; b=TO4onI8nKQetLFDRtntm7Vp5tMMH56ZY4aItRNOHKnaml4mGpKXjNz9FQRWzOhSa/n CkN83G2P3GUkK+039NOmYqndWdHdIa5EjC1geLY6eFFlBNrxf7/hbFteo9RwEUCJVRF3 eC8cb0hJpwdtY0jvySZeshJmznVzqQYeRx4yQjqT6RjxB0KvZ8buW6gi9+4bnDidBvXN 8fDINwwjBolKnu7F5U82SzVEieBZ8mTr3lj2mJig/pFxV7qvNyrJmwly9EWddQppalqD FQfOZRJcLO8cxHEx763rsW1YfNhzfPmLz9dTFKBs4Zqph790NrQ8M7Tj8LkL92VkRZ23 csTg== X-Gm-Message-State: AOAM5313cVkbMw5doQUjmTL6yndtydkQvd3nX+Dp5GNRgb7PwxbGG6d2 41YKQCIIiw5NuYBT0nI8NirxvL7p8N4= X-Google-Smtp-Source: ABdhPJz7FWHDpj+qhIKakYWL0X3cPsCoqUlVm65leH4sWpU/7lxdScTpjRTxPbVQyd01jeNXSNDKvw== X-Received: by 2002:ac8:4f52:: with SMTP id i18mr22418241qtw.82.1615237364551; Mon, 08 Mar 2021 13:02:44 -0800 (PST) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: pawel@invisiblethingslab.com, marmarek@invisiblethingslab.com, Jason Andryuk , Ian Jackson , Wei Liu Subject: [RFC 11/12] libxc: Add xc_set_cpufreq_hwp Date: Mon, 8 Mar 2021 16:02:09 -0500 Message-Id: <20210308210210.116278-12-jandryuk@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210308210210.116278-1-jandryuk@gmail.com> References: <20210308210210.116278-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add xc_set_cpufreq_hwp to allow calling xen_systctl_pm_op SET_CPUFREQ_HWP. Signed-off-by: Jason Andryuk --- Am I allowed to do set_hwp = *set_hwp struct assignment? --- tools/include/xenctrl.h | 4 ++++ tools/libs/ctrl/xc_pm.c | 18 ++++++++++++++++++ 2 files changed, 22 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 3b0ca62fc7..dc8e1bb23a 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1994,11 +1994,15 @@ struct xc_get_cpufreq_para { int32_t turbo_enabled; }; +typedef struct xen_set_hwp_para xc_set_hwp_para_t; + int xc_get_cpufreq_para(xc_interface *xch, int cpuid, struct xc_get_cpufreq_para *user_para); int xc_set_cpufreq_gov(xc_interface *xch, int cpuid, char *govname); int xc_set_cpufreq_para(xc_interface *xch, int cpuid, int ctrl_type, int ctrl_value); +int xc_set_cpufreq_hwp(xc_interface *xch, int cpuid, + xc_set_hwp_para_t *set_hwp); int xc_get_cpufreq_avgfreq(xc_interface *xch, int cpuid, int *avg_freq); int xc_set_sched_opt_smt(xc_interface *xch, uint32_t value); diff --git a/tools/libs/ctrl/xc_pm.c b/tools/libs/ctrl/xc_pm.c index 76d7eb7f26..407a24d2aa 100644 --- a/tools/libs/ctrl/xc_pm.c +++ b/tools/libs/ctrl/xc_pm.c @@ -330,6 +330,24 @@ int xc_set_cpufreq_para(xc_interface *xch, int cpuid, return xc_sysctl(xch, &sysctl); } +int xc_set_cpufreq_hwp(xc_interface *xch, int cpuid, + xc_set_hwp_para_t *set_hwp) +{ + DECLARE_SYSCTL; + + if ( !xch ) + { + errno = EINVAL; + return -1; + } + sysctl.cmd = XEN_SYSCTL_pm_op; + sysctl.u.pm_op.cmd = SET_CPUFREQ_HWP; + sysctl.u.pm_op.cpuid = cpuid; + sysctl.u.pm_op.u.set_hwp = *set_hwp; + + return xc_sysctl(xch, &sysctl); +} + int xc_get_cpufreq_avgfreq(xc_interface *xch, int cpuid, int *avg_freq) { int ret = 0; -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:07:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:07:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95110.179472 (Exim 4.92) (envelope-from ) id 1lJN6V-0007cp-Sy; Mon, 08 Mar 2021 21:07:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95110.179472; Mon, 08 Mar 2021 21:07:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN6V-0007ci-Pi; Mon, 08 Mar 2021 21:07:51 +0000 Received: by outflank-mailman (input) for mailman id 95110; Mon, 08 Mar 2021 21:07:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJN2A-0006P0-Jq for xen-devel@lists.xenproject.org; Mon, 08 Mar 2021 21:03:22 +0000 Received: from mail-qk1-x733.google.com (unknown [2607:f8b0:4864:20::733]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b51513b8-6bfb-48fc-bc0d-6441286aa7d3; Mon, 08 Mar 2021 21:02:47 +0000 (UTC) Received: by mail-qk1-x733.google.com with SMTP id b130so10829284qkc.10 for ; Mon, 08 Mar 2021 13:02:47 -0800 (PST) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:a33e:daa7:46a1:a7eb]) by smtp.gmail.com with ESMTPSA id r2sm8514070qti.4.2021.03.08.13.02.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 13:02:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b51513b8-6bfb-48fc-bc0d-6441286aa7d3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PKJr8nrwfa99gzKdxy4i3QfsaQ+/kCEtBoAhhMKOwBc=; b=AGJqFitOs3SR/s3GKDOeCYaFSW2EOleleZyJ/l4r6z+1kV6iswUlvVlUw6jKFMrglP y7wfdqEI0ut4+sU2XdXaOGkaX6RYbehVdbBioKIX2lhOg5TMaQVXWXu1bkiHymevfWIp yqiw6SPbITy5LqVtlOZPNEHn66LgrB08HbB3OgHUKnX5kpatchhOc9aB4WkgI0JhOzxu BF02madFzY0pxaq3sUSmLDYIFNBjB6dLURnd8AJqxwGuOShxklWr3+LIYPyRstVB7LBm bq3c12d7MD5MEsq5G2neE1ai0E1zHYrwzwcAY103D9uIoeQnFz2uvS7qzz492tXf37Fd 3C9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PKJr8nrwfa99gzKdxy4i3QfsaQ+/kCEtBoAhhMKOwBc=; b=Fi4vYFSRSMUleKvffC1xxVcKDl0VSKi5xXuyuoeX8cyMV3qvqhwRskJ+mg9t131wRs kSTndLTbyMUarDGxy7vb3WcgIQKU015PDFkunNXkaude//ldLREccZJY90pbjFc7SK6M 63t0QikTiJz+YAWzpCVwF7O21oVd/QKaM5nO0SNL6YSXtYfr1vRGY4ZXjjq/HQD1/0vU g5CTQ5sKhEyfBSLvTlOFmBqwYLzo728gNmnCU3TOAVULKu8u8l4FD1D2xPQJxQ7V6TES sqKklU2GFWqt3r3VNnjs11k0u2pp7H2/ay3KmM/vLwBTrUtOwkE3g+hyAGuintF2frz1 W+rw== X-Gm-Message-State: AOAM532D2t/PqwO4YhMkcX6PKD4GuJvmS59QIVRztu8vOXosjt6UoEVs 2Ff6kqwWbjS6le8BI3GNMSgH9kV0E0o= X-Google-Smtp-Source: ABdhPJykpZdiAikj/fSZyShWHGRzVySaMqLE1EYhJjnKIDorwAsEFzY0mTfkgnKVTsqakCSIMg/7Tw== X-Received: by 2002:a37:9ed0:: with SMTP id h199mr22916899qke.8.1615237366768; Mon, 08 Mar 2021 13:02:46 -0800 (PST) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: pawel@invisiblethingslab.com, marmarek@invisiblethingslab.com, Jason Andryuk , Ian Jackson , Wei Liu , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [RFC 12/12] xenpm: Add set-cpufreq-hwp subcommand Date: Mon, 8 Mar 2021 16:02:10 -0500 Message-Id: <20210308210210.116278-13-jandryuk@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210308210210.116278-1-jandryuk@gmail.com> References: <20210308210210.116278-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit set-cpufreq-hwp allows setting the Hardware P-State (HWP) parameters. It can be run on all or just a snigle cpu. There are preset of balance, powersave & performance. Those can be further tweaked by param:val arguments as explained in the usage description. parameter names are just checked to the first 3 characters to shorten typing. Some options are hardware dependent, and ranges can be found in get-cpufreq-para. Signed-off-by: Jason Andryuk --- tools/misc/xenpm.c | 240 ++++++++++++++++++++++++++++++++ xen/arch/x86/acpi/cpufreq/hwp.c | 1 + 2 files changed, 241 insertions(+) diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index a686f8f46e..d3bcaf3b58 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -67,6 +67,25 @@ void show_help(void) " set-max-cstate |'unlimited' [|'unlimited']\n" " set the C-State limitation ( >= 0) and\n" " optionally the C-sub-state limitation ( >= 0)\n" + " set-cpufreq-hwp [cpuid] [balance|performance|powersave] *\n" + " set Hardware P-State (HWP) parameters\n" + " optionally a preset of one of\n" + " balance|performance|powersave\n" + " an optional list of param:val arguments\n" + " minimum:N hw_lowest ... hw_highest\n" + " maximum:N hw_lowest ... hw_highest\n" + " desired:N hw_lowest ... hw_highest\n" + " Set explicit performance target.\n" + " non-zero disables auto-HWP mode.\n" + " energy_perf:0-255 (or 0-15)\n" + " energy/performance hint\n" + " lower favor performance\n" + " higher favor powersave\n" + " 127 (or 7) balance\n" + " act_window:N{,m,u}s range 0us-1270s\n" + " window for internal calculations.\n" + " 0 lets the hardware decide.\n" + " get-cpufreq-para returns hw_lowest/highest.\n" " start [seconds] start collect Cx/Px statistics,\n" " output after CTRL-C or SIGINT or several seconds.\n" " enable-turbo-mode [cpuid] enable Turbo Mode for processors that support it.\n" @@ -1309,6 +1328,226 @@ void disable_turbo_mode(int argc, char *argv[]) errno, strerror(errno)); } +/* + * Parse activity_window:NNN{us,ms,s} and validate range. + * + * Activity window is a 7bit mantissa (0-127) with a 3bit exponent (0-7) base + * 10 in microseconds. So the range is 1 microsecond to 1270 seconds. A value + * of 0 lets the hardware autonomously select the window. + * + * Return 0 on success + * -1 on error + * 1 Not activity_window. i.e. try parsing as another argument + */ +static int parse_activity_window(xc_set_hwp_para_t *set_hwp, char *p) +{ + char *param = NULL, *val = NULL, *suffix = NULL; + unsigned int u; + unsigned int exponent = 0; + unsigned int multiplier = 1; + int ret; + + ret = sscanf(p, "%m[a-z_A-Z]:%ms", ¶m, &val); + if ( ret != 2 ) + { + return -1; + } + + if ( strncasecmp(param, "act", 3) != 0 ) + { + ret = 1; + + goto out; + } + + free(param); + param = NULL; + + ret = sscanf(val, "%u%ms", &u, &suffix); + if ( ret != 1 && ret != 2 ) + { + fprintf(stderr, "invalid activity window: %s\n", val); + + ret = -1; + + goto out; + } + + if ( ret == 2 && suffix ) + { + if ( strcasecmp(suffix, "s") == 0 ) + { + multiplier = 1000 * 1000; + exponent = 6; + } + else if ( strcasecmp(suffix, "ms") == 0 ) + { + multiplier = 1000; + exponent = 3; + } + else if ( strcasecmp(suffix, "us") == 0 ) + { + multiplier = 1; + exponent = 0; + } + else + { + fprintf(stderr, "invalid activity window units: %s\n", suffix); + + ret = -1; + goto out; + } + } + + if ( u > 1270 * 1000 * 1000 / multiplier ) + { + fprintf(stderr, "activity window %s too large\n", val); + + ret = -1; + goto out; + } + + /* looking for 7 bits of mantissa and 3 bits of exponent */ + while ( u > 127 ) + { + u /= 10; + exponent += 1; + } + + set_hwp->activity_window = ( exponent & 0x7 ) << 7 | ( u & 0x7f ); + set_hwp->set_params |= XEN_SYSCTL_HWP_SET_ACT_WINDOW; + + ret = 0; + + out: + free(suffix); + free(param); + free(val); + + return ret; +} + +static int parse_hwp_opts(xc_set_hwp_para_t *set_hwp, int *cpuid, + int argc, char *argv[]) +{ + int i = 0; + + if ( argc < 1 ) + return -1; + + if ( parse_cpuid_non_fatal(argv[i], cpuid) == 0 ) + { + i++; + } + + if ( i == argc ) + return -1; + + if ( strcasecmp(argv[i], "powersave") == 0 ) + { + set_hwp->set_params = XEN_SYSCTL_HWP_SET_PRESET_POWERSAVE; + i++; + } + else if ( strcasecmp(argv[i], "performance") == 0 ) + { + set_hwp->set_params = XEN_SYSCTL_HWP_SET_PRESET_PERFORMANCE; + i++; + } + else if ( strcasecmp(argv[i], "balance") == 0 ) + { + set_hwp->set_params = XEN_SYSCTL_HWP_SET_PRESET_BALANCE; + i++; + } + + for ( ; i < argc; i++) + { + unsigned int val; + char *param; + int ret; + + ret = parse_activity_window(set_hwp, argv[i]); + switch ( ret ) + { + case -1: + return -1; + case 0: + continue; + break; + case 1: + /* try other parsing */ + break; + } + + /* sscanf can't handle split on ':' for "%ms:%u' */ + ret = sscanf(argv[i], "%m[a-zA-Z_]:%u", ¶m, &val); + if ( ret != 2 ) + { + fprintf(stderr, "%s is an invalid hwp parameter.\n", argv[i]); + return -1; + } + + if ( val > 255 ) + { + fprintf(stderr, "%s value %u is out of range.\n", param, val); + return -1; + } + + if ( strncasecmp(param, "min", 3) == 0 ) + { + set_hwp->minimum = val; + set_hwp->set_params |= XEN_SYSCTL_HWP_SET_MINIMUM; + } + else if ( strncasecmp(param, "max", 3) == 0 ) + { + set_hwp->maximum = val; + set_hwp->set_params |= XEN_SYSCTL_HWP_SET_MAXIMUM; + } + else if ( strncasecmp(param, "des", 3) == 0 ) + { + set_hwp->desired = val; + set_hwp->set_params |= XEN_SYSCTL_HWP_SET_DESIRED; + } + else if ( strncasecmp(param, "ene", 3) == 0 ) + { + set_hwp->energy_perf = val; + set_hwp->set_params |= XEN_SYSCTL_HWP_SET_ENERGY_PERF; + } + else + { + fprintf(stderr, "%s is an invalid parameter\n.", param); + return -1; + } + + free(param); + } + + return 0; +} + +static void hwp_set_func(int argc, char *argv[]) +{ + xc_set_hwp_para_t set_hwp = {}; + int cpuid = -1; + int i = 0; + + if ( parse_hwp_opts(&set_hwp, &cpuid, argc, argv) ) + { + fprintf(stderr, "Missing, excess, or invalid argument(s)\n"); + exit(EINVAL); + } + + if ( cpuid != -1 ) + { + i = cpuid; + max_cpu_nr = i + 1; + } + + for ( ; i < max_cpu_nr; i++ ) + if ( xc_set_cpufreq_hwp(xc_handle, i, &set_hwp) ) + fprintf(stderr, "[CPU%d] failed to set hwp params (%d - %s)\n", + i, errno, strerror(errno)); +} + struct { const char *name; void (*function)(int argc, char *argv[]); @@ -1319,6 +1558,7 @@ struct { { "get-cpufreq-average", cpufreq_func }, { "start", start_gather_func }, { "get-cpufreq-para", cpufreq_para_func }, + { "set-cpufreq-hwp", hwp_set_func }, { "set-scaling-maxfreq", scaling_max_freq_func }, { "set-scaling-minfreq", scaling_min_freq_func }, { "set-scaling-governor", scaling_governor_func }, diff --git a/xen/arch/x86/acpi/cpufreq/hwp.c b/xen/arch/x86/acpi/cpufreq/hwp.c index 8f4b18d246..0fd70d76a8 100644 --- a/xen/arch/x86/acpi/cpufreq/hwp.c +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -584,6 +584,7 @@ int set_hwp_para(struct cpufreq_policy *policy, } if ( set_hwp->set_params & XEN_SYSCTL_HWP_SET_DESIRED && + set_hwp->desired != 0 && ( set_hwp->desired < data->hw_lowest || set_hwp->desired > data->hw_highest ) ) { -- 2.29.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:18:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:18:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95129.179508 (Exim 4.92) (envelope-from ) id 1lJNGH-0000TE-PD; Mon, 08 Mar 2021 21:17:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95129.179508; Mon, 08 Mar 2021 21:17:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJNGH-0000T7-LY; Mon, 08 Mar 2021 21:17:57 +0000 Received: by outflank-mailman (input) for mailman id 95129; Mon, 08 Mar 2021 21:17:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJNGH-0000Sz-2w; Mon, 08 Mar 2021 21:17:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJNGG-0005Dx-T2; Mon, 08 Mar 2021 21:17:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJNGG-0005t6-Jp; Mon, 08 Mar 2021 21:17:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJNGG-0007Be-JJ; Mon, 08 Mar 2021 21:17:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fmS0EZxKX3KLl2Dnwo4r6oSgmx5GTn88SJ/IMypGMBs=; b=lR5aLFAHQ866lVIpl/6wG3UNG9 KuVPl1HbSpMKLIYLn9ieIxBka/WgH7Jfm+/xjZ89UZFY61HcC0Azp9z1zN95IjLcik3/tjIoV7OKT GFKgpS1Zb5TZAzndr+9q1OcojVA2lRY4T1UXv+IV4Y9EYL1PFoVeumzJ0PBMTD642MsY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159869: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=91e92cad67caca3bc4b8e920ddb5c8ca64aac9e1 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Mon, 08 Mar 2021 21:17:56 +0000 flight 159869 qemu-mainline real [real] flight 159876 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159869/ http://logs.test-lab.xenproject.org/osstest/logs/159876/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 91e92cad67caca3bc4b8e920ddb5c8ca64aac9e1 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 200 days Failing since 152659 2020-08-21 14:07:39 Z 199 days 383 attempts Testing same since 159848 2021-03-06 15:41:19 Z 2 days 4 attempts ------------------------------------------------------------ 435 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 119704 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 08 21:37:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 21:37:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95136.179523 (Exim 4.92) (envelope-from ) id 1lJNZN-0002KT-BF; Mon, 08 Mar 2021 21:37:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95136.179523; Mon, 08 Mar 2021 21:37:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJNZN-0002KM-8A; Mon, 08 Mar 2021 21:37:41 +0000 Received: by outflank-mailman (input) for mailman id 95136; Mon, 08 Mar 2021 21:37:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJNZM-0002Jv-Fa; Mon, 08 Mar 2021 21:37:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJNZM-0005XA-9M; Mon, 08 Mar 2021 21:37:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJNZL-0006SA-PT; Mon, 08 Mar 2021 21:37:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJNZL-00029e-Ox; Mon, 08 Mar 2021 21:37:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mpVinR/g6zpu4u7sPjtzVFzLtslWRE/fWg2UkNcasME=; b=ymEoCnV3Kx2gnX+hDv416dYnoo Su29Gme8uamAeJahecoTwovcyzWvzVHnBvwjZ9dU1ckYr5ymf1d79OppzIvt5GW7Lt/Mq7g57ejev VH4bK5s8zUSMsQk9DgBoG/Q6t3FudCsROfp8W3ac53NLi7tikx4uJjWiklv9M4NYVc4c=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 159872: all pass - PUSHED X-Osstest-Versions-This: ovmf=94fa95c8746c553324e8b69ea4a74af670075324 X-Osstest-Versions-That: ovmf=d28a68153492ce3e64fb0535674e11e7f46a88a8 From: osstest service owner Date: Mon, 08 Mar 2021 21:37:39 +0000 flight 159872 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/159872/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 94fa95c8746c553324e8b69ea4a74af670075324 baseline version: ovmf d28a68153492ce3e64fb0535674e11e7f46a88a8 Last test of basis 159866 2021-03-08 06:03:25 Z 0 days Testing same since 159872 2021-03-08 13:11:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git d28a681534..94fa95c874 94fa95c8746c553324e8b69ea4a74af670075324 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Mar 08 23:05:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 08 Mar 2021 23:05:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95152.179544 (Exim 4.92) (envelope-from ) id 1lJOvd-0001nv-50; Mon, 08 Mar 2021 23:04:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95152.179544; Mon, 08 Mar 2021 23:04:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJOvd-0001no-1V; Mon, 08 Mar 2021 23:04:45 +0000 Received: by outflank-mailman (input) for mailman id 95152; Mon, 08 Mar 2021 23:04:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJOvb-0001ng-SR; Mon, 08 Mar 2021 23:04:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJOvb-0006xZ-GI; Mon, 08 Mar 2021 23:04:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJOvb-0002mO-3w; Mon, 08 Mar 2021 23:04:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJOvb-0007hw-3N; Mon, 08 Mar 2021 23:04:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Q1Z9DyJHJqF8Zg4dM2yG2c6Rw2mrCJIu8TfDfnwRhX0=; b=AqZoUCvrrtp16cioAm5T41QkHw uwyAUH2sIQMjaGCs7f7ckOaqIpQ7Kru+cyhUw1cwoGJkfbTkyMzZuKgEbSvTTbHUR/d1asYdcOFmK CjEThGNzauZ1aGw/Q6n+/vwuK2C4mscDyujbZdh6tm39bwDSHMu68Sfj3kiaUvnmQp3U=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159870: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=144c79ef33536b4ecb4951e07dbc1f2b7fa99d32 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 08 Mar 2021 23:04:43 +0000 flight 159870 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159870/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux 144c79ef33536b4ecb4951e07dbc1f2b7fa99d32 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 220 days Failing since 152366 2020-08-01 20:49:34 Z 219 days 379 attempts Testing same since 159870 2021-03-08 09:51:12 Z 0 days 1 attempts ------------------------------------------------------------ 5158 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1278139 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 09 00:59:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 00:59:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95166.179559 (Exim 4.92) (envelope-from ) id 1lJQia-0003mU-9w; Tue, 09 Mar 2021 00:59:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95166.179559; Tue, 09 Mar 2021 00:59:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJQia-0003mN-6Y; Tue, 09 Mar 2021 00:59:24 +0000 Received: by outflank-mailman (input) for mailman id 95166; Tue, 09 Mar 2021 00:59:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJQiY-0003mI-6p for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 00:59:22 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e17971c6-bdda-4ff8-9961-4067cc8121c7; Tue, 09 Mar 2021 00:59:21 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 358F86514D; Tue, 9 Mar 2021 00:59:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e17971c6-bdda-4ff8-9961-4067cc8121c7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615251560; bh=WREUcIWLYSGaofIfbvyGvcvkIqLBJGwNTp9dVTZ1dUk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=kEDvxtot74SK5FUdiFo5xh/9hv0B3uu6ap+EVYJAzaf1L7AAAcHQxFRwBmm7wzAWp QPhPHTqXdtMUj+ExB7n4o8FbAwE/5cIMnGOdt94Yb4EDitIbSJogYNIPAKHbB+OM6S oF6NKzaP3xvx4HTCFY5QrOMmLJq6Zz03Xr2DkHPVqqNHMlfK7aeEIlS8L5MHIHwwqj CZwTz1J9M1LnZCx6wb6jwWtdQs2Vo4QEKUQYzVon+z84bTvH4yDcUw5L1bzoDyI7Dq vgiw4CxzmV/uD0Ot1Glt4FVC4J0acDfGlZyfF1baJ7exsOHcC9+Xq8NKaHb+kLDnj0 6tpUv30ZoSi5A== Date: Mon, 8 Mar 2021 16:59:19 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall cc: xen-devel@lists.xenproject.org, famzheng@amazon.com, sstabellini@kernel.org, cardoe@cardoe.com, wl@xen.org, Bertrand.Marquis@arm.com, andrew.cooper3@citrix.com Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) In-Reply-To: Message-ID: References: <161507188317.11025.6744028462008264481@c667a6b167f6> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sun, 7 Mar 2021, Julien Grall wrote: > On 06/03/2021 23:04, no-reply@patchew.org wrote: > > Hi, > > > > Patchew automatically ran gitlab-ci pipeline with this patch (series) > > applied, but the job failed. Maybe there's a bug in the patches? > > > > You can find the link to the pipeline near the end of the report below: > > > > Type: series > > Message-id: 20210306214148.27021-1-julien@xen.org > > Subject: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to > > 4.9 (5.1 on arm64) > > > > === TEST SCRIPT BEGIN === > > #!/bin/bash > > sleep 10 > > patchew gitlab-pipeline-check -p xen-project/patchew/xen > > === TEST SCRIPT END === > > > > warning: redirecting to https://gitlab.com/xen-project/patchew/xen.git/ > > warning: redirecting to https://gitlab.com/xen-project/patchew/xen.git/ > > From https://gitlab.com/xen-project/patchew/xen > > * [new tag] patchew/20210306214148.27021-1-julien@xen.org -> > > patchew/20210306214148.27021-1-julien@xen.org > > Switched to a new branch 'test' > > f332859b88 xen: Bump the minimum version of GCC supported to 4.9 (5.1 on > > arm64) > > > > === OUTPUT BEGIN === > > [2021-03-06 21:45:17] Looking up pipeline... > > [2021-03-06 21:45:18] Found pipeline 266507477: > > > > https://gitlab.com/xen-project/patchew/xen/-/pipelines/266507477 > > > > [2021-03-06 21:45:18] Waiting for pipeline to finish... > > [2021-03-06 22:00:21] Still waiting... > > [2021-03-06 22:15:26] Still waiting... > > [2021-03-06 22:30:31] Still waiting... > > [2021-03-06 22:45:35] Still waiting... > > [2021-03-06 23:00:41] Still waiting... > > [2021-03-06 23:04:42] Pipeline failed > > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-clang-pvh' in stage 'test' is > > skipped > > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-gcc-pvh' in stage 'test' is > > skipped > > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-clang' in stage 'test' is > > skipped > > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-gcc' in stage 'test' is skipped > > [2021-03-06 23:04:42] Job 'qemu-smoke-arm64-gcc' in stage 'test' is skipped > > [2021-03-06 23:04:42] Job 'qemu-alpine-arm64-gcc' in stage 'test' is skipped > > [2021-03-06 23:04:42] Job 'build-each-commit-gcc' in stage 'test' is skipped > > [2021-03-06 23:04:42] Job 'alpine-3.12-clang' in stage 'build' is failed > > The following jobs are failing: > > alpine-3.12-clang [1] > debian-unstable-32-gcc-debug > debian-unstable-clang > debian-unstable-gcc-randconfig > ubuntu-bionic-clang > > Cloning into 'qemu-xen-dir-remote.tmp'... > error: inflate: data stream error (incorrect data check) > fatal: serious inflate inconsistency > fatal: index-pack failed > > This looks unrelated to my patch. Possibly a network error? Yeah. > ========= > > centos-7-2-gcc [2] > centos-7-2-gcc-debug > centos-7-gcc > centos-7-gcc-debug > > Centos 7 is using GCC 4.8.5. This patch is bumping the minimum version to 4.9. > So the failure is expected. > > We may have to disable the jobs if my patch goes ahead. May I ask why we chose > to build on Centos 7? CentOS 7 is still the latest and it is maintained until 2024: https://wiki.centos.org/About/Product I don't have a lot of direct experience with x86 users any longer, but this seems to be problematic? > ========== > > ubuntu-trusty-gcc [3] > ubuntu-trusty-gcc-debug > > Ubuntu trusty is using GCC 4.8.4. This patch is bumping the minimum version to > 4.9. So the failure is expected. We may have to disable the jobs if my patch > goes ahead. May I ask why we chose to build on Ubuntu trusty? Ubuntu Trusty is in "Extended Security Maintenance", so technically still supported also: https://ubuntu.com/about/release-cycle > Cheers, > > [1] https://gitlab.com/xen-project/patchew/xen/-/jobs/1078273595 > [2] https://gitlab.com/xen-project/patchew/xen/-/jobs/1078273539 > [3] https://gitlab.com/xen-project/patchew/xen/-/jobs/1078273575 > > > > === OUTPUT END === > > > > Test command exited with code: 1 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 01:17:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 01:17:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95181.179570 (Exim 4.92) (envelope-from ) id 1lJQzi-0007Xa-Ol; Tue, 09 Mar 2021 01:17:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95181.179570; Tue, 09 Mar 2021 01:17:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJQzi-0007XT-Lj; Tue, 09 Mar 2021 01:17:06 +0000 Received: by outflank-mailman (input) for mailman id 95181; Tue, 09 Mar 2021 01:17:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJQzh-0007XO-C3 for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 01:17:05 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7bb105dc-6752-4625-8336-2ce7fd1cb130; Tue, 09 Mar 2021 01:17:04 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DD0906527E; Tue, 9 Mar 2021 01:17:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7bb105dc-6752-4625-8336-2ce7fd1cb130 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615252624; bh=VOWuOz+niWM+avW6mk/WnMfZ1yU1jZ60SouMAt9TLg0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Lf3elhTmzedELxGEeRNx7Ty16Tk9Z0i1Ymw4Ya5DjL1eCPMtahoj+GJ8aaHZD6dI+ FmuC/UHhOavSFXIjpU02Gv9DgsA0dJdPbaadh0xKLWMVX8sHg74jj7dDr/YrvfnhK4 MdP/f+QKSwHYlt4TneimalYyBBtk81m3X9meimj9Q856Np8/40j4sjwNKtJc5biAIj eUJ5NRKf8DWqMpm7+/nqbM19OSW4WU+XiTQ0kJoVE4X7MwuY9zUENpSI9cG+KmL1Bz rEamJz4euuNCy7TWWfDokZKMSOyOJfHCU4UQkoCGFzmessuTYZZ1TH47cDOlI1Lt3m d4aPLaSyWilgQ== Date: Mon, 8 Mar 2021 17:17:03 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall cc: Bertrand Marquis , xen-devel@lists.xenproject.org, Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: Use register_t type in cpuinfo entries In-Reply-To: <712d7c6a-3ace-a6b7-a188-faeb4f1258d3@xen.org> Message-ID: References: <712d7c6a-3ace-a6b7-a188-faeb4f1258d3@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 8 Mar 2021, Julien Grall wrote: > Hi Bertrand, > > On 08/03/2021 17:18, Bertrand Marquis wrote: > > All cpu identification registers that we store in the cpuinfo structure > > are 64bit on arm64 and 32bit on arm32 so storing the values in 32bit on > > arm64 is removing the higher bits which might contain information in the > > future. > > > > This patch is changing the types in cpuinfo to register_t (which is > > 32bit on arm32 and 64bit on arm64) and adding the necessary paddings > > inside the unions. > > I read this as we would replace uint32_t with register_t. However, there are a > few instances where you, validly, replace uint64_t with register_t. I would > suggest to clarify it in the commit message. > > > diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c > > index cae2179126..ea0dd3451e 100644 > > --- a/xen/arch/arm/smpboot.c > > +++ b/xen/arch/arm/smpboot.c > > @@ -321,7 +321,8 @@ void start_secondary(void) > > if ( !opt_hmp_unsafe && > > current_cpu_data.midr.bits != boot_cpu_data.midr.bits ) > > { > > - printk(XENLOG_ERR "CPU%u MIDR (0x%x) does not match boot CPU MIDR > > (0x%x),\n" > > + printk(XENLOG_ERR "CPU%u MIDR (0x%"PRIregister") does not match > > boot " > > + "CPU MIDR (0x%"PRIregister"),\n" > > For printk messages, we don't tend to split it like that (even for more than > 80 characters one). Instead, the preferred approach is: > > printk(XENLOG_ERR > "line 1\n" > "line 2\n") > > > The rest of the code looks good to me: > > Acked-by: Julien Grall Aside from these minor issues: Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Tue Mar 09 01:21:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 01:21:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95185.179582 (Exim 4.92) (envelope-from ) id 1lJR3h-0008QN-8F; Tue, 09 Mar 2021 01:21:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95185.179582; Tue, 09 Mar 2021 01:21:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJR3h-0008QG-5N; Tue, 09 Mar 2021 01:21:13 +0000 Received: by outflank-mailman (input) for mailman id 95185; Tue, 09 Mar 2021 01:21:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJR3g-0008QB-1Q for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 01:21:12 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f114150b-0914-47e0-9837-aed15c5b879c; Tue, 09 Mar 2021 01:21:11 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id AFA5965092; Tue, 9 Mar 2021 01:21:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f114150b-0914-47e0-9837-aed15c5b879c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615252870; bh=2uGdIw6ct73aEUsMcahqyCLcwXR5i5yNTFjVicjOwwg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=hgY2YtNZ6q7kN5VjIXX+2rQlMroj0lhNZRcHG3lRN4hPsWu0Wk2b8vcSkorhU54RN 6IcYecI42FQgVVFcX8GGRdkCiEQUpJMdawvu4koCWrJvk0aSjVIAkmraMJVE1Tes8m 7bo2PklGafHD/YIZE51Qv0Ar/AcMBwPIR4xVHgCp+fI7ZOyr+H8DEOoIxHv5QtE1pk asP5qSQ+Vp575uviAS3E9n7rjhYyj3M0/0xKMALC7896i8nLAl83s9goPRK8HqYJBq Q2ITmJZEcZnUbIo2zF7uv1owSnlUSpfyVzxAaCbn0pSzEYueoO/NDTq3JKdX4ZJVcP rzPpUCFOgcDjg== Date: Mon, 8 Mar 2021 17:21:10 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich cc: Julien Grall , Luca Fancellu , Stefano Stabellini , Volodymyr Babchuk , xen-devel@lists.xenproject.org Subject: Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less In-Reply-To: <24f4462d-cf3e-73a1-0515-de94d7576f34@suse.com> Message-ID: References: <20210308115610.48203-1-luca.fancellu@arm.com> <1921ff88-7637-6454-74a7-1cbab8dafc61@xen.org> <24f4462d-cf3e-73a1-0515-de94d7576f34@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 8 Mar 2021, Jan Beulich wrote: > On 08.03.2021 15:12, Julien Grall wrote: > > On 08/03/2021 11:56, Luca Fancellu wrote: > >> This patch prevents the dom0 to be loaded skipping its > >> building and going forward to build domUs when the dom0 > >> kernel is not found and at least one domU is present. > > > > As you are skipping dom0, the domid 0 will not be usable for another > > domain. I can see a few issues: > > 1) The first domU created will now be considered as the hardware > > domain (see domain_create()). > > 2) There are still a few hardcoded use of d->domain_id == 0 in the > > codebase (I could spot at least on in the RTDS code). > > 3) Not all the code seems to be able to cope with hardware_domain is > > NULL (although most of it looks to be only reachable by x86)? > > 4) is_hardware_domain() will return true when passing NULL. It is > > not clear whether one may pass NULL here. > > > > For 2), ideally this needs to be fixed. But we may also want to reserve > > domid 0 just for sanity. > > +1 to reserving ID zero in such a case. I agree too From xen-devel-bounces@lists.xenproject.org Tue Mar 09 01:33:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 01:33:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95188.179595 (Exim 4.92) (envelope-from ) id 1lJRFo-000111-CD; Tue, 09 Mar 2021 01:33:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95188.179595; Tue, 09 Mar 2021 01:33:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJRFo-00010u-8T; Tue, 09 Mar 2021 01:33:44 +0000 Received: by outflank-mailman (input) for mailman id 95188; Tue, 09 Mar 2021 01:33:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJRFn-00010W-3o for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 01:33:43 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3e858ef6-6f9c-4a10-9b58-1b16c6faf887; Tue, 09 Mar 2021 01:33:41 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 8CD8464E02; Tue, 9 Mar 2021 01:33:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e858ef6-6f9c-4a10-9b58-1b16c6faf887 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615253620; bh=rTPfbtvDKBr1Vhc99NQjoiWbIVIJQa4a18/RwbbvcMk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=i00KA4EiptaiXoR0Zap6t31rmO2SA669bj8iKT/BhNe/Qd2Dyxc6CsGYRnJH64KuU airOkHncFwxndxgx/xnB/IFI9hNKMlJAbn0Tv/QiyHSmLDb5F6R0VZ4NUUlas8CzcU fdAbcqueqcWBAvX28CcZbaPBgoJYYywNU3eZXdos+UafSg25zyu9J57JmmqpxaJJkn X+fO9Dr+RsV0iM84hQAfQgjVN8lKH4Liyt1BgAWHhJikSI83dG8WHPY/uHalJnDe5j CjY6oRTgTlqNiaTVsc/1XEXd7g6XNgy2VZSwYaMe62yE/36st2ibkEZHVcad3V5tqS dC/FyMJTyxrjA== Date: Mon, 8 Mar 2021 17:33:39 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Luca Fancellu cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less In-Reply-To: <20210308115610.48203-1-luca.fancellu@arm.com> Message-ID: References: <20210308115610.48203-1-luca.fancellu@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 8 Mar 2021, Luca Fancellu wrote: > This patch prevents the dom0 to be loaded skipping its > building and going forward to build domUs when the dom0 > kernel is not found and at least one domU is present. > > Signed-off-by: Luca Fancellu > --- > xen/arch/arm/setup.c | 83 +++++++++++++++++++++++++++++++------------- > 1 file changed, 59 insertions(+), 24 deletions(-) > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 2532ec9739..6d169ff6ce 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -794,6 +794,35 @@ static void __init setup_mm(void) > } > #endif > > +static bool __init is_dom0less_mode(void) > +{ > + struct bootmodules *mods = &bootinfo.modules; > + struct bootmodule *mod; > + unsigned int i; > + bool dom0found = false; > + bool domUfound = false; > + > + /* Look into the bootmodules */ > + for ( i = 0 ; i < mods->nr_mods ; i++ ) > + { > + mod = &mods->module[i]; > + /* Find if dom0 and domU kernels are present */ > + if ( mod->kind == BOOTMOD_KERNEL ) > + { > + if ( mod->domU == false ) > + dom0found = true; > + else > + domUfound = true; > + } > + } > + > + /* > + * If there is no dom0 kernel but at least one domU, then we are in > + * dom0less mode > + */ > + return ( !dom0found && domUfound ); > +} This code looks correct to me. Julien's suggestion of updating the docs and moving dom0 creation to domain_build.c are good ones. And also I think reserving domain_id 0 is really important to avoid errors and should be done as part of this patch too. > size_t __read_mostly dcache_line_bytes; > > /* C entry point for boot CPU */ > @@ -804,7 +833,7 @@ void __init start_xen(unsigned long boot_phys_offset, > int cpus, i; > const char *cmdline; > struct bootmodule *xen_bootmodule; > - struct domain *dom0; > + struct domain *dom0 = NULL; > struct xen_domctl_createdomain dom0_cfg = { > .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, > .max_evtchn_port = -1, > @@ -964,28 +993,33 @@ void __init start_xen(unsigned long boot_phys_offset, > apply_alternatives_all(); > enable_errata_workarounds(); > > - /* Create initial domain 0. */ > - /* The vGIC for DOM0 is exactly emulating the hardware GIC */ > - dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; > - /* > - * Xen vGIC supports a maximum of 992 interrupt lines. > - * 32 are substracted to cover local IRQs. > - */ > - dom0_cfg.arch.nr_spis = min(gic_number_lines(), (unsigned int) 992) - 32; > - if ( gic_number_lines() > 992 ) > - printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); > - dom0_cfg.arch.tee_type = tee_get_type(); > - dom0_cfg.max_vcpus = dom0_max_vcpus(); > - > - if ( iommu_enabled ) > - dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; > - > - dom0 = domain_create(0, &dom0_cfg, true); > - if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) > - panic("Error creating domain 0\n"); > - > - if ( construct_dom0(dom0) != 0) > - panic("Could not set up DOM0 guest OS\n"); > + if ( !is_dom0less_mode() ) > + { > + /* Create initial domain 0. */ > + /* The vGIC for DOM0 is exactly emulating the hardware GIC */ > + dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; > + /* > + * Xen vGIC supports a maximum of 992 interrupt lines. > + * 32 are substracted to cover local IRQs. > + */ > + dom0_cfg.arch.nr_spis = min(gic_number_lines(), (unsigned int) 992) - 32; > + if ( gic_number_lines() > 992 ) > + printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); > + dom0_cfg.arch.tee_type = tee_get_type(); > + dom0_cfg.max_vcpus = dom0_max_vcpus(); > + > + if ( iommu_enabled ) > + dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; > + > + dom0 = domain_create(0, &dom0_cfg, true); > + if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) > + panic("Error creating domain 0\n"); > + > + if ( construct_dom0(dom0) != 0) > + panic("Could not set up DOM0 guest OS\n"); > + } > + else > + printk(XENLOG_INFO "Xen dom0less mode detected\n"); > > heap_init_late(); > > @@ -1003,7 +1037,8 @@ void __init start_xen(unsigned long boot_phys_offset, > if ( acpi_disabled ) > create_domUs(); > > - domain_unpause_by_systemcontroller(dom0); > + if ( dom0 ) > + domain_unpause_by_systemcontroller(dom0); > > /* Switch on to the dynamically allocated stack for the idle vcpu > * since the static one we're running on is about to be freed. */ > -- > 2.17.1 > From xen-devel-bounces@lists.xenproject.org Tue Mar 09 01:56:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 01:56:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95193.179611 (Exim 4.92) (envelope-from ) id 1lJRc3-0002ue-6e; Tue, 09 Mar 2021 01:56:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95193.179611; Tue, 09 Mar 2021 01:56:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJRc3-0002uX-2w; Tue, 09 Mar 2021 01:56:43 +0000 Received: by outflank-mailman (input) for mailman id 95193; Tue, 09 Mar 2021 01:56:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJRc1-0002uP-BJ; Tue, 09 Mar 2021 01:56:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJRc1-0003Oo-2u; Tue, 09 Mar 2021 01:56:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJRbz-0003B8-Ew; Tue, 09 Mar 2021 01:56:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJRbz-0002jx-Bc; Tue, 09 Mar 2021 01:56:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=p29SBYEChn4EbWEJKWD90GbPlA2WQtucPHggzWNbcqw=; b=KnVQxSTM4ahPd2yWFsAvmdmTj7 oQy54RFmZK8P/iSUc8IqqUiNiKML0LdIgW5+EN9aYTwBMwQOXHJFAoUUnUoh/n732gBBdvesRYibc LTkcOpdO9sKCFsmu3We06EEl1xeg/yR8qnmY3CVjwmhkgdqwqZlc0o6vHrHwH5vKLpv8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159874: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=60c0444fae2148452f9ed0b7c49af1fa41f8f522 X-Osstest-Versions-That: xen=51972482f77b68ef494c8b9591b125460e7984b9 From: osstest service owner Date: Tue, 09 Mar 2021 01:56:39 +0000 flight 159874 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/159874/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159864 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159864 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159864 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159864 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159864 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159864 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159864 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159864 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159864 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159864 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159864 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 60c0444fae2148452f9ed0b7c49af1fa41f8f522 baseline version: xen 51972482f77b68ef494c8b9591b125460e7984b9 Last test of basis 159864 2021-03-08 01:51:25 Z 1 days Testing same since 159874 2021-03-08 15:07:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Tim Deegan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 51972482f7..60c0444fae 60c0444fae2148452f9ed0b7c49af1fa41f8f522 -> master From xen-devel-bounces@lists.xenproject.org Tue Mar 09 04:50:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 04:50:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95207.179643 (Exim 4.92) (envelope-from ) id 1lJUJb-0001rx-6B; Tue, 09 Mar 2021 04:49:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95207.179643; Tue, 09 Mar 2021 04:49:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJUJb-0001rq-2p; Tue, 09 Mar 2021 04:49:51 +0000 Received: by outflank-mailman (input) for mailman id 95207; Tue, 09 Mar 2021 04:49:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJUJZ-0001ri-9N; Tue, 09 Mar 2021 04:49:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJUJZ-0006ne-0L; Tue, 09 Mar 2021 04:49:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJUJY-0002mu-Nr; Tue, 09 Mar 2021 04:49:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJUJY-0006M7-NP; Tue, 09 Mar 2021 04:49:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZcW1HInNMndwefGu4RANP5TI2NSsshUmB2KvPjwLeMc=; b=Hb4lWnOksgsZDzfXoQMBG9ZwGt 3kFACgOM00T331XX9SF+Vqw1rDWmZX3zVddFNYO/fQ+OiKFokpAxX5MF4yQidySg5on3fApmF2cFA 52KW9poieqGI9OYgFUgEZG3xXqsEoTl25jRVMcR0dJ87NDcQIJBBidqvEkTT5H5QvoAg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 159879: all pass - PUSHED X-Osstest-Versions-This: ovmf=edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507 X-Osstest-Versions-That: ovmf=94fa95c8746c553324e8b69ea4a74af670075324 From: osstest service owner Date: Tue, 09 Mar 2021 04:49:48 +0000 flight 159879 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/159879/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507 baseline version: ovmf 94fa95c8746c553324e8b69ea4a74af670075324 Last test of basis 159872 2021-03-08 13:11:56 Z 0 days Testing same since 159879 2021-03-08 21:40:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 94fa95c874..edd46cd407 edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Mar 09 05:14:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 05:14:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95214.179657 (Exim 4.92) (envelope-from ) id 1lJUhH-0004vm-65; Tue, 09 Mar 2021 05:14:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95214.179657; Tue, 09 Mar 2021 05:14:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJUhH-0004vf-37; Tue, 09 Mar 2021 05:14:19 +0000 Received: by outflank-mailman (input) for mailman id 95214; Tue, 09 Mar 2021 05:14:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJUhF-0004va-Sa for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 05:14:17 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 327bb3e7-7ed1-4b81-b1ef-3b997b111b59; Tue, 09 Mar 2021 05:14:16 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D2610AB8C; Tue, 9 Mar 2021 05:14:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 327bb3e7-7ed1-4b81-b1ef-3b997b111b59 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615266856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BwvCGl4RerrOMc9D3VhJpaldx+CpAEoVSAb7RV+Msz0=; b=PsjkzlUmjyNWLXREWyB7xNn47Lt1T1qcBVj929+SN9We23f06yjU0Cdu7T57DwVa+Y/JXI 00xxr6+6cdKI9bHU8uj/gH2FdCy7mfpjJLrhgFlpHw9pHjHi80qZlMWH3ngOq+8pI2FxM+ jY5DMrrzbd8QAXRkVn4CzPpCUJ5qojc= Subject: Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending To: Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, ross.lagerwall@citrix.com Cc: Stefano Stabellini , stable@vger.kernel.org, Julien Grall , Julien Grall References: <20210306161833.4552-1-jgross@suse.com> <20210306161833.4552-3-jgross@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Tue, 9 Mar 2021 06:14:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="q01kZynA2QJbHdjvIabMM3OzYodc49c7C" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --q01kZynA2QJbHdjvIabMM3OzYodc49c7C Content-Type: multipart/mixed; boundary="tNpc0ydQx80iYjL3FMABQniegUgVN9sys"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, ross.lagerwall@citrix.com Cc: Stefano Stabellini , stable@vger.kernel.org, Julien Grall , Julien Grall Message-ID: Subject: Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending References: <20210306161833.4552-1-jgross@suse.com> <20210306161833.4552-3-jgross@suse.com> In-Reply-To: --tNpc0ydQx80iYjL3FMABQniegUgVN9sys Content-Type: multipart/mixed; boundary="------------BE5ED103C411FDF22705A2DF" Content-Language: en-US This is a multi-part message in MIME format. --------------BE5ED103C411FDF22705A2DF Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 08.03.21 21:33, Boris Ostrovsky wrote: >=20 > On 3/6/21 11:18 AM, Juergen Gross wrote: >> An event channel should be kept masked when an eoi is pending for it. >> When being migrated to another cpu it might be unmasked, though. >> >> In order to avoid this keep three different flags for each event chann= el >> to be able to distinguish "normal" masking/unmasking from eoi related >> masking/unmasking and temporary masking. The event channel should only= >> be able to generate an interrupt if all flags are cleared. >> >> Cc: stable@vger.kernel.org >> Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn fra= mework") >> Reported-by: Julien Grall >> Signed-off-by: Juergen Gross >> Reviewed-by: Julien Grall >> --- >> V2: >> - introduce a lock around masking/unmasking >> - merge patch 3 into this one (Jan Beulich) >> V4: >> - don't set eoi masking flag in lateeoi_mask_ack_dynirq() >=20 >=20 > Reviewed-by: Boris Ostrovsky >=20 >=20 > Ross, are you planning to test this? Just as another data point: With the previous version of the patches a reboot loop of a guest needed max 33 reboots to loose network in my tests (those were IIRC 6 test runs). With this patch version I stopped the test after about 1300 reboots without having seen any problems. Juergen --------------BE5ED103C411FDF22705A2DF Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------BE5ED103C411FDF22705A2DF-- --tNpc0ydQx80iYjL3FMABQniegUgVN9sys-- --q01kZynA2QJbHdjvIabMM3OzYodc49c7C Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBHBCYFAwAAAAAACgkQsN6d1ii/Ey/A eQf/QH0znaB3+GMsnTj6zXH3Lw1t8QxjO7acZvpKciqqjxU6LRgnSY7h37Zu/SWPvf8tjantQM0z aSbxaifZ8dmJOAICQ/djKo4WL/Ib26xkPool0Y56dqm/MdUrLBRz7Mr83SGajlO+hIsgs0Jfk9R8 whnC7ogsGZ1iFjGWVHhsEQyXdVTVgplWjf4NDFptDpRTYPT+5QOu4AL++SG0auWnFCNcN7LXv7g3 aKMxs4iyA1jtN16kXvqLI7EHFHDKp/ETHvKBLpLq4ZfsNt23VVPxE95PK7HrDNTq4NhDsxntOF6T n3U0HgH407F+rwqhpuF5a+HAD9Z2Qb+jR8OwuNQxww== =9CG/ -----END PGP SIGNATURE----- --q01kZynA2QJbHdjvIabMM3OzYodc49c7C-- From xen-devel-bounces@lists.xenproject.org Tue Mar 09 06:15:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 06:15:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95221.179670 (Exim 4.92) (envelope-from ) id 1lJVdm-0001tz-HY; Tue, 09 Mar 2021 06:14:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95221.179670; Tue, 09 Mar 2021 06:14:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJVdm-0001ts-EH; Tue, 09 Mar 2021 06:14:46 +0000 Received: by outflank-mailman (input) for mailman id 95221; Tue, 09 Mar 2021 06:14:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJVdl-0001tn-IY for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 06:14:45 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 734e8d1e-feda-424d-9ffe-e44c927884ee; Tue, 09 Mar 2021 06:14:40 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 378E8AC24; Tue, 9 Mar 2021 06:14:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 734e8d1e-feda-424d-9ffe-e44c927884ee X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615270479; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Szn8CoKcdFhLmILaUcNU5Mw5xCclHsTUFexJC8stRy4=; b=jPjIK0O/HZtDDoN9i5q9qE9tCBF+qqDn/LLQf1IVkph/JDoObaw8ldwo6HNokrvlhNodgL Vs85iV11L2fM3q2k47ZOpXDOg6M687QX/KgVkfAXyk4PzKrZF8y74kYMkCJgwRL2t8uQV6 Lgy5TUIAMbtKoMqVu92zSt/DdCmoRak= Subject: Re: [PATCH v5 02/12] x86/paravirt: switch time pvops functions to use static_call() To: Boris Ostrovsky , xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org Cc: Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini References: <20210308122844.30488-1-jgross@suse.com> <20210308122844.30488-3-jgross@suse.com> <1346dbb1-c43e-9ac2-10e4-3c10cb2ead78@oracle.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <5cea7551-ce84-c084-ddaf-e84075823bd8@suse.com> Date: Tue, 9 Mar 2021 07:14:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1346dbb1-c43e-9ac2-10e4-3c10cb2ead78@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="71uw2iHz3Ya5XGSDna2ezasDmqthVMGA6" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --71uw2iHz3Ya5XGSDna2ezasDmqthVMGA6 Content-Type: multipart/mixed; boundary="WlyrUNrhACnKGE7g1Gx1k7ZM6h5PqkFRP"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Boris Ostrovsky , xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org Cc: Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini Message-ID: <5cea7551-ce84-c084-ddaf-e84075823bd8@suse.com> Subject: Re: [PATCH v5 02/12] x86/paravirt: switch time pvops functions to use static_call() References: <20210308122844.30488-1-jgross@suse.com> <20210308122844.30488-3-jgross@suse.com> <1346dbb1-c43e-9ac2-10e4-3c10cb2ead78@oracle.com> In-Reply-To: <1346dbb1-c43e-9ac2-10e4-3c10cb2ead78@oracle.com> --WlyrUNrhACnKGE7g1Gx1k7ZM6h5PqkFRP Content-Type: multipart/mixed; boundary="------------F998C827E1466225E03A1952" Content-Language: en-US This is a multi-part message in MIME format. --------------F998C827E1466225E03A1952 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 08.03.21 18:00, Boris Ostrovsky wrote: >=20 > On 3/8/21 7:28 AM, Juergen Gross wrote: >> --- a/arch/x86/xen/time.c >> +++ b/arch/x86/xen/time.c >> @@ -379,11 +379,6 @@ void xen_timer_resume(void) >> } >> } >> =20 >> -static const struct pv_time_ops xen_time_ops __initconst =3D { >> - .sched_clock =3D xen_sched_clock, >> - .steal_clock =3D xen_steal_clock, >> -}; >> - >> static struct pvclock_vsyscall_time_info *xen_clock __read_mostly; >> static u64 xen_clock_value_saved; >> =20 >> @@ -528,7 +523,8 @@ static void __init xen_time_init(void) >> void __init xen_init_time_ops(void) >> { >> xen_sched_clock_offset =3D xen_clocksource_read(); >> - pv_ops.time =3D xen_time_ops; >> + static_call_update(pv_steal_clock, xen_steal_clock); >> + paravirt_set_sched_clock(xen_sched_clock); >> =20 >> x86_init.timers.timer_init =3D xen_time_init; >> x86_init.timers.setup_percpu_clockev =3D x86_init_noop; >> @@ -570,7 +566,8 @@ void __init xen_hvm_init_time_ops(void) >> } >> =20 >> xen_sched_clock_offset =3D xen_clocksource_read(); >> - pv_ops.time =3D xen_time_ops; >> + static_call_update(pv_steal_clock, xen_steal_clock); >> + paravirt_set_sched_clock(xen_sched_clock); >> x86_init.timers.setup_percpu_clockev =3D xen_time_init; >> x86_cpuinit.setup_percpu_clockev =3D xen_hvm_setup_cpu_clockevents;= >=20 >=20 > There is a bunch of stuff that's common between the two cases so it can= be factored out. Yes. >=20 >=20 >> =20 >> diff --git a/drivers/xen/time.c b/drivers/xen/time.c >> index 108edbcbc040..152dd33bb223 100644 >> --- a/drivers/xen/time.c >> +++ b/drivers/xen/time.c >> @@ -7,6 +7,7 @@ >> #include >> #include >> #include >> +#include >> =20 >> #include >> #include >> @@ -175,7 +176,7 @@ void __init xen_time_setup_guest(void) >> xen_runstate_remote =3D !HYPERVISOR_vm_assist(VMASST_CMD_enable, >> VMASST_TYPE_runstate_update_flag); >> =20 >> - pv_ops.time.steal_clock =3D xen_steal_clock; >> + static_call_update(pv_steal_clock, xen_steal_clock); >> =20 >=20 >=20 > Do we actually need this? We've already set this up in xen_init_time_op= s(). (But maybe for ARM). Correct. Arm needs this. Juergen --------------F998C827E1466225E03A1952 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------F998C827E1466225E03A1952-- --WlyrUNrhACnKGE7g1Gx1k7ZM6h5PqkFRP-- --71uw2iHz3Ya5XGSDna2ezasDmqthVMGA6 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBHEk0FAwAAAAAACgkQsN6d1ii/Ey8E swf+OyODJL+GMlmaqXVphW8kb4oF9BSQVqkcEtzcS+L7SRmJ9ZuimdIeCk6WrrqzUiDE1aeFsNeK hVT12DE64j551Af0uJdt3Q/PBEDiSsvW7V87fiAg8DL8I0XqJj29wP8vBjfJPVFgDVJHIsNK2Tnm K4O/6BbctZcBqC6WwuSpss7JXmRAS0ApTaaAypMTffbSKAwJ9whX+tlcFKpqvBqKVjV2x65b7Cj2 hE/CQ/MjxQhK9Qjz7y4M62kBOGiWt3PhJInwZSpRmbf1j0Qieht6KAbJhWvwm0WGTeoOI/JCLQWd I8/SFQj2W6p8N5ijnvLD5KskevErq8ti98OafCVDpA== =2Vak -----END PGP SIGNATURE----- --71uw2iHz3Ya5XGSDna2ezasDmqthVMGA6-- From xen-devel-bounces@lists.xenproject.org Tue Mar 09 06:16:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 06:16:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95224.179682 (Exim 4.92) (envelope-from ) id 1lJVfb-00022E-TL; Tue, 09 Mar 2021 06:16:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95224.179682; Tue, 09 Mar 2021 06:16:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJVfb-000227-QJ; Tue, 09 Mar 2021 06:16:39 +0000 Received: by outflank-mailman (input) for mailman id 95224; Tue, 09 Mar 2021 06:16:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJVfa-00021y-SQ; Tue, 09 Mar 2021 06:16:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJVfa-00008D-Fb; Tue, 09 Mar 2021 06:16:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJVfa-0007XY-4h; Tue, 09 Mar 2021 06:16:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJVfa-00032t-4C; Tue, 09 Mar 2021 06:16:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ffYQffpnuKVv+BR3+Tk8acmyaTCbXi4iAMNOk4T7Tfo=; b=Cu1Plw5ijYLi17N54Rhpr8t5fU /iKMh7FhH6lOsKEqZbZz6RIjBVzx8O9pvlZ7RIF6qDTdqzeoOKhqXooS3HQ6hF3pVAAOMNOgQ29Ea VeyyIo/FjhfkDGZ6ZbQTMm2jNLOJ7DaV3KcNnTxsdECvfc80ird5DxhyJveWAccb4K7k=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159884: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=682edc95da4f0ffe8149b4651e5808c76d3a8987 X-Osstest-Versions-That: xen=60c0444fae2148452f9ed0b7c49af1fa41f8f522 From: osstest service owner Date: Tue, 09 Mar 2021 06:16:38 +0000 flight 159884 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159884/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 682edc95da4f0ffe8149b4651e5808c76d3a8987 baseline version: xen 60c0444fae2148452f9ed0b7c49af1fa41f8f522 Last test of basis 159871 2021-03-08 10:00:32 Z 0 days Testing same since 159884 2021-03-09 03:00:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Roger Pau Monne Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 60c0444fae..682edc95da 682edc95da4f0ffe8149b4651e5808c76d3a8987 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Mar 09 06:21:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 06:21:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95231.179697 (Exim 4.92) (envelope-from ) id 1lJVkR-0002zM-Ku; Tue, 09 Mar 2021 06:21:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95231.179697; Tue, 09 Mar 2021 06:21:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJVkR-0002zF-Ho; Tue, 09 Mar 2021 06:21:39 +0000 Received: by outflank-mailman (input) for mailman id 95231; Tue, 09 Mar 2021 06:21:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJVkP-0002zA-RC for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 06:21:37 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ab51c8f8-39c3-46c9-83f3-3e36d523d880; Tue, 09 Mar 2021 06:21:37 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 02BCDAB8C; Tue, 9 Mar 2021 06:21:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab51c8f8-39c3-46c9-83f3-3e36d523d880 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615270896; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=auED0x3wS8Wn3FtixUxpL260TFwTyGn7ZjAoR0lab8s=; b=sugliOqHN66fLztniMNHrM6t8IfqY+DtVomXxMlmWAFgzISRB/qAPt21bICd6LaM+SYDMC uBJe4j/rZFNmVWAVk7rUJatk9Q2WH4/0xcdziKE/DPYEFx7uK1b7qiM+BnQ6Sa/iGhifNp pRhpwN8G26dmaykK/TcT+1FJ6NW+vBk= To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Deep Shah , "VMware, Inc." References: <20210308122844.30488-1-jgross@suse.com> <20210308122844.30488-12-jgross@suse.com> <20210308183058.GC12548@zn.tnic> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: [PATCH v5 11/12] x86/paravirt: switch functions with custom code to ALTERNATIVE Message-ID: <09410a65-a5dc-db76-d867-f6b0b968323f@suse.com> Date: Tue, 9 Mar 2021 07:21:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210308183058.GC12548@zn.tnic> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qEpMh3Ecfq1JyILFFGFyPlagg1mFokzxT" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qEpMh3Ecfq1JyILFFGFyPlagg1mFokzxT Content-Type: multipart/mixed; boundary="4WZ1ErrJpnSn17WaCS7ULv4vKLVypghm7"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Deep Shah , "VMware, Inc." Message-ID: <09410a65-a5dc-db76-d867-f6b0b968323f@suse.com> Subject: Re: [PATCH v5 11/12] x86/paravirt: switch functions with custom code to ALTERNATIVE References: <20210308122844.30488-1-jgross@suse.com> <20210308122844.30488-12-jgross@suse.com> <20210308183058.GC12548@zn.tnic> In-Reply-To: <20210308183058.GC12548@zn.tnic> --4WZ1ErrJpnSn17WaCS7ULv4vKLVypghm7 Content-Type: multipart/mixed; boundary="------------518D9DF2B6D10E464777E18C" Content-Language: en-US This is a multi-part message in MIME format. --------------518D9DF2B6D10E464777E18C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 08.03.21 19:30, Borislav Petkov wrote: > On Mon, Mar 08, 2021 at 01:28:43PM +0100, Juergen Gross wrote: >> diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/pa= ravirt.h >> index 36cd71fa097f..04b3067f31b5 100644 >> --- a/arch/x86/include/asm/paravirt.h >> +++ b/arch/x86/include/asm/paravirt.h >> @@ -137,7 +137,8 @@ static inline void write_cr0(unsigned long x) >> =20 >> static inline unsigned long read_cr2(void) >> { >> - return PVOP_CALLEE0(unsigned long, mmu.read_cr2); >> + return PVOP_ALT_CALLEE0(unsigned long, mmu.read_cr2, >> + "mov %%cr2, %%rax;", ~X86_FEATURE_XENPV); >=20 > Just some cursory poking first - indepth review later. >=20 > Do I see this correctly that the negated feature can be expressed with,= to use > this example here: >=20 > ALTERNATIVE_TERNARY(mmu.read_cr2, X86_FEATURE_XENPV, "", "mov %%cr2, %= %rax;"); >=20 > ? No. This would leave the Xen-pv case with a nop, while we need it to call mmu.read_cr2(). In the Xen-pv case there must be _no_ alternative patching in order to have the paravirt patching do its patching (indirect->direct call). This is exactly the reason why I need to "not feature". The only other solution I can think of would be a "split static_call" handling using ALTERNATIVE_TERNARY(): ALTERNATIVE_TERNARY(initial_static_call(mmu.read_cr2), X86_FEATURE_XENPV, final_static_call(mmu.read_cr2), "mov %%cr2, %%rax;"); with initial_static_call() doing an indirect call, while final_static_call() would do a direct call. Not sure we really want that. Juergen --------------518D9DF2B6D10E464777E18C Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------518D9DF2B6D10E464777E18C-- --4WZ1ErrJpnSn17WaCS7ULv4vKLVypghm7-- --qEpMh3Ecfq1JyILFFGFyPlagg1mFokzxT Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBHE+8FAwAAAAAACgkQsN6d1ii/Ey/i owf+NuM+ZrdiHB4RC1K2m8LT7LKECO0k44bwvIFALNAieBdxJhsPJ4oUIVwCp5FNj9dY8H8tk5GG 3CXFwQV8iLiKeIQduvcf29ZXOJeD0xx29A/9DIHY2MSTdSWTDvIDN4+WtQmOvkSClYirkMZV4A5i oWppxkVOC+B8ylDaqlXw8tOyAcWoNnPfDJLaEuF9ZqPm4j9EgNkJjnQ7FsBMAu60CynYtrVNGszk aSpvbPgjLXQse38X+UvDI5oqUnsAWfrYQITmtW2RHM+v4CPGJZcRM/+xvH2/NXvHvbDOMVBF675H T8YelM8a0PPKgS08dEKpDRXDqkXTIgDRCsraPlQTgQ== =klAc -----END PGP SIGNATURE----- --qEpMh3Ecfq1JyILFFGFyPlagg1mFokzxT-- From xen-devel-bounces@lists.xenproject.org Tue Mar 09 07:28:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 07:28:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95239.179715 (Exim 4.92) (envelope-from ) id 1lJWnH-0000Go-KP; Tue, 09 Mar 2021 07:28:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95239.179715; Tue, 09 Mar 2021 07:28:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJWnH-0000Gh-HE; Tue, 09 Mar 2021 07:28:39 +0000 Received: by outflank-mailman (input) for mailman id 95239; Tue, 09 Mar 2021 07:28:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJWnG-0000Gc-Bp for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 07:28:38 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id cc6fcd8b-35c9-482a-92c2-8f635aa48fb4; Tue, 09 Mar 2021 07:28:37 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 90485D6E; Mon, 8 Mar 2021 23:28:36 -0800 (PST) Received: from [10.57.15.131] (unknown [10.57.15.131]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DE5053F70D; Mon, 8 Mar 2021 23:28:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc6fcd8b-35c9-482a-92c2-8f635aa48fb4 Subject: Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210308135937.1692-1-michal.orzel@arm.com> <37ea3c87-c960-4c92-af5f-71f2db774a75@suse.com> From: Michal Orzel Message-ID: Date: Tue, 9 Mar 2021 08:28:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <37ea3c87-c960-4c92-af5f-71f2db774a75@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 15:26, Jan Beulich wrote: > On 08.03.2021 14:59, Michal Orzel wrote: >> --- a/xen/arch/arm/Makefile >> +++ b/xen/arch/arm/Makefile >> @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o >> >> #obj-bin-y += ....o >> >> -ifdef CONFIG_DTB_FILE >> +ifneq ($(CONFIG_DTB_FILE),"") >> obj-y += dtb.o >> AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >> endif > > Right now what I have for my Arm test builds is an unquoted > string in ./.config, e.g.: > > CONFIG_DTB_FILE:=/usr/local/arm-linux-gnueabi/vexpress-v2p-aem-v7a.dtb > > While I suppose you've tested that the resulting quoting is still > okay, to reduce confusion perhaps the AFLAGS-y line would better > be changed to > > AFLAGS-y += '-DCONFIG_DTB_FILE=$(CONFIG_DTB_FILE)' It is tested. I can change it to: AFLAGS-y += -DCONFIG_DTB_FILE='$(CONFIG_DTB_FILE)' as the -DCONFIG_DTB_FILE= does not need to be within quotes > > at the same time? > > Jan > Michal From xen-devel-bounces@lists.xenproject.org Tue Mar 09 07:34:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 07:34:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95241.179727 (Exim 4.92) (envelope-from ) id 1lJWt0-0001B0-9i; Tue, 09 Mar 2021 07:34:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95241.179727; Tue, 09 Mar 2021 07:34:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJWt0-0001At-6N; Tue, 09 Mar 2021 07:34:34 +0000 Received: by outflank-mailman (input) for mailman id 95241; Tue, 09 Mar 2021 07:34:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJWsz-0001Am-0F for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 07:34:33 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id c0a6dabd-1374-4de3-b90a-54ec20d09738; Tue, 09 Mar 2021 07:34:31 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 69AABD6E; Mon, 8 Mar 2021 23:34:31 -0800 (PST) Received: from [10.57.15.131] (unknown [10.57.15.131]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB35E3F70D; Mon, 8 Mar 2021 23:34:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0a6dabd-1374-4de3-b90a-54ec20d09738 Subject: Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com References: <20210308135937.1692-1-michal.orzel@arm.com> <745c5049-fb09-5605-8bc1-838a4def45d6@xen.org> From: Michal Orzel Message-ID: <3353ecf1-3a76-70ee-0475-b7eed90c783c@arm.com> Date: Tue, 9 Mar 2021 08:34:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <745c5049-fb09-5605-8bc1-838a4def45d6@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Julien, On 08.03.2021 15:31, Julien Grall wrote: > Hi, > > On 08/03/2021 13:59, Michal Orzel wrote: >> Currently in order to link existing DTB into Xen image >> we need to either specify option CONFIG_DTB_FILE on the >> command line or manually add it into .config. >> Add Kconfig entry: CONFIG_DTB_FILE to be able to >> provide the path to DTB we want to embed into Xen image. >> If no path provided - the dtb will not be embedded. >> >> Signed-off-by: Michal Orzel >> --- >>   xen/arch/arm/Makefile | 4 +--- >>   xen/common/Kconfig    | 8 ++++++++ >>   2 files changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile >> index 16e6523e2c..0f3e99d075 100644 >> --- a/xen/arch/arm/Makefile >> +++ b/xen/arch/arm/Makefile >> @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o >>     #obj-bin-y += ....o >>   -ifdef CONFIG_DTB_FILE >> +ifneq ($(CONFIG_DTB_FILE),"") >>   obj-y += dtb.o >>   AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>   endif >> @@ -137,8 +137,6 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >>   xen.lds: xen.lds.S >>       $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >>   -dtb.o: $(CONFIG_DTB_FILE) >> - > > Why is this dropped? 1)This line is not needed as it has no impact on creating dtb.o 2)It causes the build failure once CONFIG_DTB_FILE option is in the Kconfig as string within quotes. > >>   .PHONY: clean >>   clean:: >>       rm -f asm-offsets.s xen.lds >> diff --git a/xen/common/Kconfig b/xen/common/Kconfig >> index eb953d171e..a4c8d09edf 100644 >> --- a/xen/common/Kconfig >> +++ b/xen/common/Kconfig >> @@ -400,6 +400,14 @@ config DOM0_MEM >>           Leave empty if you are not sure what to specify. >>   +config DTB_FILE > > May I ask why is this add in common/Kconfig rather than arm/Kconfig? > I wanted to have it in common features rather than architecture features. Maybe it could be later on used by other architectures. >> +    string "Absolute path to device tree blob" >> +    depends on ARM > > If this stay in common Kconfig, shouldn't this be gated with HAS_DEVICE_TREE? No it shouldn't as CONFIG_DTB_FILE depends on CONFIG_ARM which selects CONFIG_HAS_DEVICE_TREE > >> +    ---help--- >> +      When using a bootloader that has no device tree support or when there >> +      is no bootloader at all, use this option to specify the absolute path >> +      to a device tree that will be linked directly inside Xen binary. >> + >>   config TRACEBUFFER >>       bool "Enable tracing infrastructure" if EXPERT >>       default y >> > > Cheers, > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Tue Mar 09 07:48:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 07:48:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95245.179739 (Exim 4.92) (envelope-from ) id 1lJX6V-0002Gk-JM; Tue, 09 Mar 2021 07:48:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95245.179739; Tue, 09 Mar 2021 07:48:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJX6V-0002Gd-FW; Tue, 09 Mar 2021 07:48:31 +0000 Received: by outflank-mailman (input) for mailman id 95245; Tue, 09 Mar 2021 07:48:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJX6T-0002GY-VD for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 07:48:29 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 32a65161-c4de-4a41-8a30-501dedcb3108; Tue, 09 Mar 2021 07:48:29 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5BE26AC1F; Tue, 9 Mar 2021 07:48:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32a65161-c4de-4a41-8a30-501dedcb3108 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615276108; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o7n054MX+Dq/BvPhJ4RPtTh/X29Mm2l8invMO0pHy/U=; b=mLoLocmp/3c5K9QpvNgZC26JnZ1e5U0l3GiWGfFKqw5ezwwlYrer8RjeS5G5cw8+8b58aN Wp/1WIkKHXFyYY6ROysrdMRwKhSXl4HQDec4XOPeT08gL99O4DvzvnZ+fBnwyQe2LHGRw3 iRrn4F9XIkqYjSyZto0T03lcyGd7avU= Subject: Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210308135937.1692-1-michal.orzel@arm.com> <37ea3c87-c960-4c92-af5f-71f2db774a75@suse.com> From: Jan Beulich Message-ID: Date: Tue, 9 Mar 2021 08:48:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09.03.2021 08:28, Michal Orzel wrote: > > > On 08.03.2021 15:26, Jan Beulich wrote: >> On 08.03.2021 14:59, Michal Orzel wrote: >>> --- a/xen/arch/arm/Makefile >>> +++ b/xen/arch/arm/Makefile >>> @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o >>> >>> #obj-bin-y += ....o >>> >>> -ifdef CONFIG_DTB_FILE >>> +ifneq ($(CONFIG_DTB_FILE),"") >>> obj-y += dtb.o >>> AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>> endif >> >> Right now what I have for my Arm test builds is an unquoted >> string in ./.config, e.g.: >> >> CONFIG_DTB_FILE:=/usr/local/arm-linux-gnueabi/vexpress-v2p-aem-v7a.dtb >> >> While I suppose you've tested that the resulting quoting is still >> okay, to reduce confusion perhaps the AFLAGS-y line would better >> be changed to >> >> AFLAGS-y += '-DCONFIG_DTB_FILE=$(CONFIG_DTB_FILE)' > > It is tested. I can change it to: > AFLAGS-y += -DCONFIG_DTB_FILE='$(CONFIG_DTB_FILE)' > as the -DCONFIG_DTB_FILE= does not need to be within quotes Either way would seem better to me than the current use of escaped double quotes. (Personally I prefer to quote entire arguments, but that's clearly a taste aspect.) Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 09 08:13:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 08:13:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95253.179750 (Exim 4.92) (envelope-from ) id 1lJXUQ-0005Ov-Rw; Tue, 09 Mar 2021 08:13:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95253.179750; Tue, 09 Mar 2021 08:13:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJXUQ-0005Oo-Ob; Tue, 09 Mar 2021 08:13:14 +0000 Received: by outflank-mailman (input) for mailman id 95253; Tue, 09 Mar 2021 08:13:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJXUP-0005Og-Ru; Tue, 09 Mar 2021 08:13:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJXUP-0002bv-LB; Tue, 09 Mar 2021 08:13:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJXUP-00043h-Am; Tue, 09 Mar 2021 08:13:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJXUP-00070n-AG; Tue, 09 Mar 2021 08:13:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=W15i0GkmBnibDZeND3VIODU4A+LIJJOSDzvDk0mUpxA=; b=UiARibB84EOjkY0cEDJnfz6Xd2 6sal5etxVZxBcWY31YUtESm3h9dBZlgxZL+TC9R0kDVnJvXHu/v7hmFBVe3NdJgBX5oi2KEQ/qSEk kO/VntpvjSs0cW0l2YdcrbcnYHyIhql5K8xUllEeiRGkS9zkLyLjeD45oIZ3p/i9WuSM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159878: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=229a834518b950d56fd1bc94923276504d0ee9d4 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Tue, 09 Mar 2021 08:13:13 +0000 flight 159878 qemu-mainline real [real] flight 159886 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159878/ http://logs.test-lab.xenproject.org/osstest/logs/159886/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 229a834518b950d56fd1bc94923276504d0ee9d4 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 200 days Failing since 152659 2020-08-21 14:07:39 Z 199 days 384 attempts Testing same since 159878 2021-03-08 21:39:59 Z 0 days 1 attempts ------------------------------------------------------------ 439 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 121438 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 09 08:58:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 08:58:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95263.179766 (Exim 4.92) (envelope-from ) id 1lJYBs-0000ik-D6; Tue, 09 Mar 2021 08:58:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95263.179766; Tue, 09 Mar 2021 08:58:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJYBs-0000id-A5; Tue, 09 Mar 2021 08:58:08 +0000 Received: by outflank-mailman (input) for mailman id 95263; Tue, 09 Mar 2021 08:58:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJYBr-0000iY-5E for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 08:58:07 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8357a63c-dfda-463b-aa67-1c46e22341b8; Tue, 09 Mar 2021 08:58:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8357a63c-dfda-463b-aa67-1c46e22341b8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615280286; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=ucEyClNY7Tik8Yk7WI9RZer5oJR2JMMqQHVmFQC9FDE=; b=X15DapsJP8tQjm69+OumI2H0mxmoSMMlW1JRPE1zU2KhkjNJQ06qdFd7 46HilvL9dVxvIpC41RFUN+xVqBg6yF1Gc0UT8oWWnTDJHIjyCtcXh0rL/ +XFF0Xlyr7d2hoUP/UjzoFJYA0h+3Nuus75IIywZ2PEBIgzjtb3wngDs/ U=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: ifhYFTrHtVgd68c/XUGtBuHNjVRWo6LfOxF3XIc6nQNmeHSBls/AkrbJ89p6twz1cYS0qfTMYE 8tm4S8oS6YFEHMWGJKuMwDAScH2anoCglpbi60qWwpVBQcBGKwPYm/A0aEeGbZ0OfFdfGCxVHB vTkzH4T5pVvmrmdoHlz1NFEYy/WZD59qZSW6ilFF8vw6GqX2T6sJmQVlPCrcKpYXvQI3Netdin SS2On1Z3Azsqs9QyW25t8LjPLwIcVK1udb23wbHb6LXikGmvqMqYehSQ5PxdYJL3zywqd/12FN xtU= X-SBRS: 4.0 X-MesageID: 38751923 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,234,1610427600"; d="scan'208";a="38751923" Subject: Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Boris Ostrovsky , , CC: Stefano Stabellini , , Julien Grall , Julien Grall References: <20210306161833.4552-1-jgross@suse.com> <20210306161833.4552-3-jgross@suse.com> From: Ross Lagerwall Message-ID: Date: Tue, 9 Mar 2021 08:57:23 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit On 2021-03-09 05:14, Jürgen Groß wrote: > On 08.03.21 21:33, Boris Ostrovsky wrote: >> >> On 3/6/21 11:18 AM, Juergen Gross wrote: >>> An event channel should be kept masked when an eoi is pending for it. >>> When being migrated to another cpu it might be unmasked, though. >>> >>> In order to avoid this keep three different flags for each event channel >>> to be able to distinguish "normal" masking/unmasking from eoi related >>> masking/unmasking and temporary masking. The event channel should only >>> be able to generate an interrupt if all flags are cleared. >>> >>> Cc: stable@vger.kernel.org >>> Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn framework") >>> Reported-by: Julien Grall >>> Signed-off-by: Juergen Gross >>> Reviewed-by: Julien Grall >>> --- >>> V2: >>> - introduce a lock around masking/unmasking >>> - merge patch 3 into this one (Jan Beulich) >>> V4: >>> - don't set eoi masking flag in lateeoi_mask_ack_dynirq() >> >> >> Reviewed-by: Boris Ostrovsky >> >> >> Ross, are you planning to test this? > > Just as another data point: With the previous version of the patches > a reboot loop of a guest needed max 33 reboots to loose network in > my tests (those were IIRC 6 test runs). With this patch version I > stopped the test after about 1300 reboots without having seen any > problems. > Thanks, I'll test it today and get back to you. Ross From xen-devel-bounces@lists.xenproject.org Tue Mar 09 09:29:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 09:29:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95274.179783 (Exim 4.92) (envelope-from ) id 1lJYg9-0003VW-3a; Tue, 09 Mar 2021 09:29:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95274.179783; Tue, 09 Mar 2021 09:29:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJYg9-0003VP-0c; Tue, 09 Mar 2021 09:29:25 +0000 Received: by outflank-mailman (input) for mailman id 95274; Tue, 09 Mar 2021 09:29:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJYg8-0003VH-Ii; Tue, 09 Mar 2021 09:29:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJYg8-0003qF-Au; Tue, 09 Mar 2021 09:29:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJYg8-0007LF-3r; Tue, 09 Mar 2021 09:29:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJYg8-0007yu-3O; Tue, 09 Mar 2021 09:29:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=N8H016EgoiRp8UkCj3n4dyPqmJsKoYWEn7zV+nDl8pg=; b=jIFEeZ7k7kLiyC+S5Eo+AQ5kLw 01REzs9oSSi+YEIOCl5DyR+5JcwiSVkRRfHQSMJEjhQipFmX6tZ6Eozq2/8k3uMnivnR1jO59D+ba qt1RVBI9cyKeHaEnZ5cCagbfjC+Mpb9UZLXekbHgQpM0NAquIOTeNbUaNzWfRRJI2V3I=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 159885: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=6564cb01e10094914aca6ea0c562e3769e76e4b8 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 09 Mar 2021 09:29:24 +0000 flight 159885 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/159885/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 6564cb01e10094914aca6ea0c562e3769e76e4b8 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 242 days Failing since 151818 2020-07-11 04:18:52 Z 241 days 234 attempts Testing same since 159885 2021-03-09 04:18:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 46300 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 09 09:31:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 09:31:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95278.179799 (Exim 4.92) (envelope-from ) id 1lJYhl-0004Ik-HN; Tue, 09 Mar 2021 09:31:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95278.179799; Tue, 09 Mar 2021 09:31:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJYhl-0004Id-D3; Tue, 09 Mar 2021 09:31:05 +0000 Received: by outflank-mailman (input) for mailman id 95278; Tue, 09 Mar 2021 09:31:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJYhk-0004IW-40 for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 09:31:04 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown [40.107.8.55]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d1b16599-24d5-4f79-bbab-808a529c4fef; Tue, 09 Mar 2021 09:31:03 +0000 (UTC) Received: from AM6PR05CA0016.eurprd05.prod.outlook.com (2603:10a6:20b:2e::29) by DBBPR08MB6187.eurprd08.prod.outlook.com (2603:10a6:10:209::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.19; Tue, 9 Mar 2021 09:31:01 +0000 Received: from AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2e:cafe::75) by AM6PR05CA0016.outlook.office365.com (2603:10a6:20b:2e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Tue, 9 Mar 2021 09:31:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT013.mail.protection.outlook.com (10.152.16.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Tue, 9 Mar 2021 09:31:00 +0000 Received: ("Tessian outbound ef5d1dda26b7:v71"); Tue, 09 Mar 2021 09:31:00 +0000 Received: from 3597a2845fc9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 687FCC7A-046E-48F1-909C-DF892C5B649E.1; Tue, 09 Mar 2021 09:30:54 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3597a2845fc9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 09 Mar 2021 09:30:54 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VI1PR08MB3309.eurprd08.prod.outlook.com (2603:10a6:803:41::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.28; Tue, 9 Mar 2021 09:30:52 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3912.027; Tue, 9 Mar 2021 09:30:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1b16599-24d5-4f79-bbab-808a529c4fef DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f0fRbCNFTtVArDKOiyLJMs/Wyh2MBw5YmDDsro7bUTQ=; b=aH8r8Hifuzk+buCvqmx52u7+JPQOhJBy4oq/Iq/CMFPsMBMjWC37ivo4F39TI4XgPSIoBAY6VXY32Ifby5LF4+oDS+bPhdMe3ZvcLgEUe838MkM6CgIgQYpmN6IhFCwBeK+I0k33aWyjL+fZReE/o78azUN14FBYpQyLVDFZhts= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 0cefcb835c940aa6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SRWLKVFSmxIxH4xwSmpNu6NRSQHYliG3CWRswP2Ca2rkx1avRvnvxQsN+wLCbPx2kETPyriB3dpRA8ex72A1dYLkodaXUi5Pc1jvR2dNl/zHLp7sXnLqqzNMc9pHBi+pasZEQrOm0t1OzWznrqMcBaCNZU99xzLctTBG7aSJ35DGEBf3HY/qliqvpOOGlHy3WZ+HkwgL+4qVqWJN72CYdtrVLbRWUeDPBQeG53kkZEu0hBClmySjER+r2F8DV1w0v/32yzF4NdU6x6Ni6CsrrDAB3weV24EdxnZT5lEoqwUD1ze6Ba3buAr6dY4cHxwijF/vHyjJEhAK+BrVaiqL9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f0fRbCNFTtVArDKOiyLJMs/Wyh2MBw5YmDDsro7bUTQ=; b=Do5UGpGmPAA3G4z7eahlc4YI1Ru3oKwTeBUp7ZcFFx5HdOaLUYua5BGCQ31tdOoE3bx5/NzuCjt8yElKU3z/idxtLYDDU85oDmCpgG2ca1iAzSbB6/e1kAGjvxLi+ZilWpsMyjzWna3ReksASykQdg00FwkEkLRhWOlm6+SD+VQ+eCvR85S7C4dkQuXm/guDLnBmzZyz9cAOz8xCWaxOPvxLd0oNb3cxN1uzU1eXBzAIo3aiwnXp22NQTh6iC4OIlmluNGjZEpBGBcikhcRkK0lqv4XTUPHWET/k464bOAq6TzrOlK4mWXJOwkmeys6pMYiPUh8LTyneo8Ocez7gBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f0fRbCNFTtVArDKOiyLJMs/Wyh2MBw5YmDDsro7bUTQ=; b=aH8r8Hifuzk+buCvqmx52u7+JPQOhJBy4oq/Iq/CMFPsMBMjWC37ivo4F39TI4XgPSIoBAY6VXY32Ifby5LF4+oDS+bPhdMe3ZvcLgEUe838MkM6CgIgQYpmN6IhFCwBeK+I0k33aWyjL+fZReE/o78azUN14FBYpQyLVDFZhts= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: Use register_t type in cpuinfo entries Thread-Topic: [PATCH] xen/arm: Use register_t type in cpuinfo entries Thread-Index: AQHXFFQNaLCX4oSw+0OC1jGtjtl2z6p7ZSKA Date: Tue, 9 Mar 2021 09:30:51 +0000 Message-ID: <62BD194F-C673-42CD-AEA0-BE4AFA21849E@arm.com> References: <712d7c6a-3ace-a6b7-a188-faeb4f1258d3@xen.org> In-Reply-To: <712d7c6a-3ace-a6b7-a188-faeb4f1258d3@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [2a01:cb10:335:200:3195:51a5:b958:cac1] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ecca6e50-48ee-4dd1-687c-08d8e2de0d45 x-ms-traffictypediagnostic: VI1PR08MB3309:|DBBPR08MB6187: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GNoBPgk3GKBWD4fk5YPla4yCUhDHsG9BsczkYCQUQi1nqhIaWWwXjV4T0oMO58f3F2sFd/ozFd8KCJBE/0+LkHgYBmhmXdV+7unzRu9/DfcsC+MvRtPuP1/22yS97QEPjSr47HDzci4JM7GeLPJsxILnDpCLekk5j0/E8qr/oWnuOV5aiTuxsh2bygCFc5ZxmM7PZa22B88uUNoOck5eX2kgWX41Ej/2Ijc6Sb3H2LFOqkSA5pSyKgkDfvSa6SL+2ArsUA52WkV+Z1NHi8HpJcEiqCWu4QJj6c6V0gM6pYnjnoj+LCM8IYX5wUZ0QIXcqYbx9aOuM/CZJ7wja95K1JBnH0TkwvEUGPtiqEzsaZxaK7FmFvbD5e19kv5TExeKfcof3JhKVTnK97FoXvAt8WhFCev1N3hjl1i3w66nCPzvF7sb12sVHiJ2hPJO9O3RAS0rkAcl9/r9hV6VOSn5uwx3xuqStNHzd+IceAmixjtgT/z0eSmHFNNIsphQUBZzAP8nRRXZgv2MEN+v0+gfPGIM3maoL8vHWdey5JcbHoSAR7k6aChiV02Ln3M2s6sKEaweEB5Qs8U4usCNUEXVHg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(136003)(39860400002)(366004)(346002)(2616005)(6916009)(8936002)(66556008)(66446008)(64756008)(6506007)(6512007)(2906002)(5660300002)(91956017)(478600001)(8676002)(53546011)(4326008)(71200400001)(86362001)(66946007)(54906003)(76116006)(83380400001)(33656002)(316002)(6486002)(66476007)(36756003)(186003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?OWhodXZpM0NhYm5RYjRWeTNKUnJTUUJCZkxZeWNHZ1V6QlhvazJrL2g3cXBl?= =?utf-8?B?TFJHSStNRzVGaHdqT2xRVVNJUks1VzZQMys4ZUQvUnZmdmZOYkhCTnZJYVNI?= =?utf-8?B?VXBGL2xlRWtQWjJsZUdZVThrK0RkR0J6UVNBUFR0TDl2N09ZOHlxYUROYTZh?= =?utf-8?B?MWNjbUZ1M0J3WkZZTFhjb3I3dHJRMHhoaW5rTE1YU2cxc2NjOVlaNTlkRWZs?= =?utf-8?B?MkNtYVpsc3lIV3VjM29nSWYvTXFjUmhOaWdjSGZ5T21UT1VKZ3NmcUhBYzBz?= =?utf-8?B?Y0dNVlorcWxWQVA1SVpjSTR1REF3RGlrc2ZIbjd1RXlZVWFPUUxDMW5HVU5t?= =?utf-8?B?RFFiOEJ0Y3lXbVlPMSsxVVZBbnNhQWFGdWs3SERDb2ZlaEpCZTMvTFRzR0kz?= =?utf-8?B?SytURVhONGlrUGhEeG1YNVhBbXdPZ0wwU2lCVjRLUWVITkhXekI5cDRHM1ly?= =?utf-8?B?RFVBUFdYOXZVZzUyOUZNYnR5RnZPTVN2NjVxYUpuZCtZUGZWYUJtZmMzQTNZ?= =?utf-8?B?ZVY1SjN1WFhWcks1NnRpUjZseDZSY2JYWDNxNCtTNzM3SFZ4U28vTnRNbGRB?= =?utf-8?B?UUpMQit6SURpMFpOS085SUlLdG5YcmZRTFdDTHYxVEFBS0p3eVNYRHYyNmg1?= =?utf-8?B?WWhDaWRFaWQ1Yk5DY0t2VWtRbW5nbjlUNndaQmpXYjZ4K0VtVExGNjdjOE5k?= =?utf-8?B?RDRjamlwMzRXRk5mZ3hvRUE2dmRVWjRoMEJ5ZkE1dmVyLzhieW1kdEdqTmNH?= =?utf-8?B?aG1oOURKd1N6ZGRlUGxGSlVUS1VzVjNUeVdlM3VFYkNGRDhrbXVyMWtCYXFo?= =?utf-8?B?SkFnS0FqZ2I3M1V1Z0hnOU9vNExHRERFeUF5U2x0L2tqenhWRU1RT28reWkz?= =?utf-8?B?VUJYRHVraUh4NVRDZmRVbnhiT3cvVG8wa1BQbTJaeEF2R0xpdDREbXd5Q09R?= =?utf-8?B?QlZTTW1wVXhjdHdqOExtc0Uzd3A0SHAvQUJ5ZVorWWl2eGd3UnNFd0pWeUVN?= =?utf-8?B?YmhBZU5ZaW56YlhKNDBlK2hPcy90U3RselA1SnU5ZXl2Z29aNU9YaGJTejF2?= =?utf-8?B?RlovYUNnR3FpZFQxRll2NStaQVFoajNUdXBSUjFnWlovUUJiQUlZcnpzWlRm?= =?utf-8?B?U1U1QU5lbS8veVIydExlRHE4MVl2S2hFMHQ3TXJHOEhoS2x2VEJmRTBxcEZD?= =?utf-8?B?YXN6Q3B3UzA0Sy84WDBuWUNCNzQ2RUtQQjhzVmNWTDNoUTlWd1BEU0hQTGV1?= =?utf-8?B?VExvZmh1UVJXL3FRbnJOZU5nK2VYTHlkMVJuK0R6TTNmeU92VUYvaE9iUk4w?= =?utf-8?B?MDlQZzE1WFFPTUdMUUF5Tk9xMm83RjBObU5BYTZrTU04V09vK1BrdmtNQkZI?= =?utf-8?B?RzlJOWI5YllPTnpCTFIvN09OUUIwSDdVaXZ5SWQ5VXd4YURCK0hKeHY0T2FJ?= =?utf-8?B?cEtJTWtZRE9rWjZCZjdlUEFvUVZNYlZwc0YrSjI3NThJMHgzWVlTYjVaZW4y?= =?utf-8?B?a3ROSG5Ham5DWVZJTUVtd3lndGNWRDRReUc0QzBQSDllU25aS3VQNUNlVE82?= =?utf-8?B?Tjk4SmhHWXFBVGRhZTBpclBoVEJ1dUJVNVJrWktmWFVPL3RpMnR1M3ZUcDlr?= =?utf-8?B?bk1MaFN3Z1FpaEtKU002MGhSREZWaVVheExXcDB0bVp4OUJyY2lodjY0OENk?= =?utf-8?B?QWIzRnhsb2I5T3pxTWtzT3V1emZyRnR5c1RJN2p4ZVRvVVJ4elptak4xZTJT?= =?utf-8?B?dkF5Vnl6eWVFN1o5ckliczlDOGdQNkJuMDRvLytwaE4rRlBnVVZ3MHhIdWVt?= =?utf-8?B?WVZTMDdSNUQrQ2kyUXFKb09sbmZoQzhUQWM0aldSdHhxRnlZRmNwT0pWSHRM?= =?utf-8?Q?p0R3fljn9JRRN?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <0C6DB9E8D4BB1D49821A8C72A9B6E1AA@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3309 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 48d8898a-cf87-4475-15a5-08d8e2de081f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HfvsTx7FzBTseAlZsBkyaCwOapGgZjxLOJNV69PUiqr4UaSrWv/kOQMqFi4JT+/ngoctJnp/dGtOa+4wWNoU3zTDqzQrH69CvKjKUemN7M1w9ut1M5ro3l4aJkrMDgi4tdSpnTm1PEXLe5k3vxoqlxLC/q+YFxL0yTPNlXTgEHLMjUR8EIPE9574YPij6dN1Qs5jFpqArZJIUsHpjDZB720IZ5kz1FdXk5IolLPjcqI31oGoacO5MBPAghaBj6VD2tKvhSIrOtZ8o9U1VqYzbnoINF3wG8tC4KjlgXPmf8H5LDqNTTmpndv4K9zv207D22rzXy6WKU58/3eSSkRPsOFiAKCuT8G+QHl6RPiPcjIrO2zigM+QKFUFQKmtYphKSWSA9w/xKsB/siV/ulvAZCfZjbZJc93LhYy22XWGe337jkqd9m7TM6JssbZF/8NEmDX+8lOTj8f6X/1/thkO6dkyBAw+7FSOVji7LTvWN4X5SIbUK5mePpOdrkgJWdtmuu5wPLO8+kEGnC6MFQdVaeGP2mlx4QPEsbVDG7Ztd+ZkE27G03rlF6jy6OnFAcIEAHrRx8l3LeWBYmBKDeqIe2U7kMWCeEgdXuwTKCOzRJIvXooODtWXx69DeIYI5gjIhpO+G11sz2b/CiGwD3zOC/d3vOQ29d6I7gNCUD+BHcU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(39860400002)(376002)(346002)(396003)(46966006)(36840700001)(5660300002)(356005)(83380400001)(70586007)(8936002)(336012)(6506007)(82740400003)(82310400003)(4326008)(53546011)(6862004)(70206006)(36756003)(26005)(54906003)(6486002)(2906002)(6512007)(316002)(8676002)(36860700001)(47076005)(81166007)(33656002)(186003)(107886003)(86362001)(478600001)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 09:31:00.5585 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ecca6e50-48ee-4dd1-687c-08d8e2de0d45 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6187 SGkgSnVsaWVuLA0KDQo+IE9uIDggTWFyIDIwMjEsIGF0IDIwOjQ4LCBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEhpIEJlcnRyYW5kLA0KPiANCj4gT24gMDgvMDMv MjAyMSAxNzoxOCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+IEFsbCBjcHUgaWRlbnRpZmlj YXRpb24gcmVnaXN0ZXJzIHRoYXQgd2Ugc3RvcmUgaW4gdGhlIGNwdWluZm8gc3RydWN0dXJlDQo+ PiBhcmUgNjRiaXQgb24gYXJtNjQgYW5kIDMyYml0IG9uIGFybTMyIHNvIHN0b3JpbmcgdGhlIHZh bHVlcyBpbiAzMmJpdCBvbg0KPj4gYXJtNjQgaXMgcmVtb3ZpbmcgdGhlIGhpZ2hlciBiaXRzIHdo aWNoIG1pZ2h0IGNvbnRhaW4gaW5mb3JtYXRpb24gaW4gdGhlDQo+PiBmdXR1cmUuDQo+PiBUaGlz IHBhdGNoIGlzIGNoYW5naW5nIHRoZSB0eXBlcyBpbiBjcHVpbmZvIHRvIHJlZ2lzdGVyX3QgKHdo aWNoIGlzDQo+PiAzMmJpdCBvbiBhcm0zMiBhbmQgNjRiaXQgb24gYXJtNjQpIGFuZCBhZGRpbmcg dGhlIG5lY2Vzc2FyeSBwYWRkaW5ncw0KPj4gaW5zaWRlIHRoZSB1bmlvbnMuDQo+IA0KPiBJIHJl YWQgdGhpcyBhcyB3ZSB3b3VsZCByZXBsYWNlIHVpbnQzMl90IHdpdGggcmVnaXN0ZXJfdC4gSG93 ZXZlciwgdGhlcmUgYXJlIGEgZmV3IGluc3RhbmNlcyB3aGVyZSB5b3UsIHZhbGlkbHksIHJlcGxh Y2UgdWludDY0X3Qgd2l0aCByZWdpc3Rlcl90LiBJIHdvdWxkIHN1Z2dlc3QgdG8gY2xhcmlmeSBp dCBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuDQoNCkhvdyBhYm91dCBhZGRpbmcgdGhlIGZvbGxvd2lu ZyBzZW50ZW5jZTog4oCcRm9yIGNvaGVyZW5jeSB1aW50NjRfdCBlbnRyaWVzIGFyZSBhbHNvIGNo YW5nZWQgdG8gcmVnaXN0ZXJfdCBvbiA2NGJpdCBzeXN0ZW1zLiINCg0KPiANCj4+IGRpZmYgLS1n aXQgYS94ZW4vYXJjaC9hcm0vc21wYm9vdC5jIGIveGVuL2FyY2gvYXJtL3NtcGJvb3QuYw0KPj4g aW5kZXggY2FlMjE3OTEyNi4uZWEwZGQzNDUxZSAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2Fy bS9zbXBib290LmMNCj4+ICsrKyBiL3hlbi9hcmNoL2FybS9zbXBib290LmMNCj4+IEBAIC0zMjEs NyArMzIxLDggQEAgdm9pZCBzdGFydF9zZWNvbmRhcnkodm9pZCkNCj4+ICAgICAgaWYgKCAhb3B0 X2htcF91bnNhZmUgJiYNCj4+ICAgICAgICAgICBjdXJyZW50X2NwdV9kYXRhLm1pZHIuYml0cyAh PSBib290X2NwdV9kYXRhLm1pZHIuYml0cyApDQo+PiAgICAgIHsNCj4+IC0gICAgICAgIHByaW50 ayhYRU5MT0dfRVJSICJDUFUldSBNSURSICgweCV4KSBkb2VzIG5vdCBtYXRjaCBib290IENQVSBN SURSICgweCV4KSxcbiINCj4+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJDUFUldSBNSURS ICgweCUiUFJJcmVnaXN0ZXIiKSBkb2VzIG5vdCBtYXRjaCBib290ICINCj4+ICsgICAgICAgICAg ICAgICAiQ1BVIE1JRFIgKDB4JSJQUklyZWdpc3RlciIpLFxuIg0KPiANCj4gRm9yIHByaW50ayBt ZXNzYWdlcywgd2UgZG9uJ3QgdGVuZCB0byBzcGxpdCBpdCBsaWtlIHRoYXQgKGV2ZW4gZm9yIG1v cmUgdGhhbiA4MCBjaGFyYWN0ZXJzIG9uZSkuIEluc3RlYWQsIHRoZSBwcmVmZXJyZWQgYXBwcm9h Y2ggaXM6DQo+IA0KPiBwcmludGsoWEVOTE9HX0VSUg0KPiAgICAgICAibGluZSAxXG4iDQo+ICAg ICAgICJsaW5lIDJcbiIpDQoNCk9rLg0KDQpEbyB5b3Ugd2FudCBtZSB0byBzZW5kIGEgdjIgb3Ig Y2FuIHlvdSBmaXggdGhpcyBkdXJpbmcgdGhlIGNvbW1pdCA/DQoNCj4gDQo+IA0KPiBUaGUgcmVz dCBvZiB0aGUgY29kZSBsb29rcyBnb29kIHRvIG1lOg0KPiANCj4gQWNrZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQoNClRoYW5rcyA6LSkNCg0KQ2hlZXJzDQpCZXJ0cmFu ZA0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Tue Mar 09 10:05:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 10:05:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95290.179811 (Exim 4.92) (envelope-from ) id 1lJZF0-0007C2-Ec; Tue, 09 Mar 2021 10:05:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95290.179811; Tue, 09 Mar 2021 10:05:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZF0-0007Bv-As; Tue, 09 Mar 2021 10:05:26 +0000 Received: by outflank-mailman (input) for mailman id 95290; Tue, 09 Mar 2021 10:05:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZEy-0007Bq-H7 for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 10:05:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZEv-0004WG-0j; Tue, 09 Mar 2021 10:05:21 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJZEu-0007DG-HT; Tue, 09 Mar 2021 10:05:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Ydd65JX7traKb0hGUfqh3WQxjaeJ9AE7hlTdwXR+3jY=; b=P3Ni8lt34Fv3Ms+AHOJIzgIPQD dEY+V96J0fXpV3jdfQZBmX/QDCZ0PM3i22Y0mUzHOz+1QYKUvQL5M0IW/7+4fsPmW+viiTest5ypE 4mJ8cpHNIWYMUdhUANIIkkCWBLt3C/QgxfiKIO6ZxZT3wlOW2hiQTu0UGX8H8me1pCGc=; Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, famzheng@amazon.com, cardoe@cardoe.com, wl@xen.org, Bertrand.Marquis@arm.com, andrew.cooper3@citrix.com References: <161507188317.11025.6744028462008264481@c667a6b167f6> From: Julien Grall Message-ID: <10b8048a-e8fe-1fcd-7291-7f1b16da2f4c@xen.org> Date: Tue, 9 Mar 2021 10:05:18 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Stefano, On 09/03/2021 00:59, Stefano Stabellini wrote: > On Sun, 7 Mar 2021, Julien Grall wrote: >> On 06/03/2021 23:04, no-reply@patchew.org wrote: >>> Hi, >>> >>> Patchew automatically ran gitlab-ci pipeline with this patch (series) >>> applied, but the job failed. Maybe there's a bug in the patches? >>> >>> You can find the link to the pipeline near the end of the report below: >>> >>> Type: series >>> Message-id: 20210306214148.27021-1-julien@xen.org >>> Subject: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to >>> 4.9 (5.1 on arm64) >>> >>> === TEST SCRIPT BEGIN === >>> #!/bin/bash >>> sleep 10 >>> patchew gitlab-pipeline-check -p xen-project/patchew/xen >>> === TEST SCRIPT END === >>> >>> warning: redirecting to https://gitlab.com/xen-project/patchew/xen.git/ >>> warning: redirecting to https://gitlab.com/xen-project/patchew/xen.git/ >>> From https://gitlab.com/xen-project/patchew/xen >>> * [new tag] patchew/20210306214148.27021-1-julien@xen.org -> >>> patchew/20210306214148.27021-1-julien@xen.org >>> Switched to a new branch 'test' >>> f332859b88 xen: Bump the minimum version of GCC supported to 4.9 (5.1 on >>> arm64) >>> >>> === OUTPUT BEGIN === >>> [2021-03-06 21:45:17] Looking up pipeline... >>> [2021-03-06 21:45:18] Found pipeline 266507477: >>> >>> https://gitlab.com/xen-project/patchew/xen/-/pipelines/266507477 >>> >>> [2021-03-06 21:45:18] Waiting for pipeline to finish... >>> [2021-03-06 22:00:21] Still waiting... >>> [2021-03-06 22:15:26] Still waiting... >>> [2021-03-06 22:30:31] Still waiting... >>> [2021-03-06 22:45:35] Still waiting... >>> [2021-03-06 23:00:41] Still waiting... >>> [2021-03-06 23:04:42] Pipeline failed >>> [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-clang-pvh' in stage 'test' is >>> skipped >>> [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-gcc-pvh' in stage 'test' is >>> skipped >>> [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-clang' in stage 'test' is >>> skipped >>> [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-gcc' in stage 'test' is skipped >>> [2021-03-06 23:04:42] Job 'qemu-smoke-arm64-gcc' in stage 'test' is skipped >>> [2021-03-06 23:04:42] Job 'qemu-alpine-arm64-gcc' in stage 'test' is skipped >>> [2021-03-06 23:04:42] Job 'build-each-commit-gcc' in stage 'test' is skipped >>> [2021-03-06 23:04:42] Job 'alpine-3.12-clang' in stage 'build' is failed >> >> The following jobs are failing: >> >> alpine-3.12-clang [1] >> debian-unstable-32-gcc-debug >> debian-unstable-clang >> debian-unstable-gcc-randconfig >> ubuntu-bionic-clang >> >> Cloning into 'qemu-xen-dir-remote.tmp'... >> error: inflate: data stream error (incorrect data check) >> fatal: serious inflate inconsistency >> fatal: index-pack failed >> >> This looks unrelated to my patch. Possibly a network error? > > Yeah. > > >> ========= >> >> centos-7-2-gcc [2] >> centos-7-2-gcc-debug >> centos-7-gcc >> centos-7-gcc-debug >> >> Centos 7 is using GCC 4.8.5. This patch is bumping the minimum version to 4.9. >> So the failure is expected. >> >> We may have to disable the jobs if my patch goes ahead. May I ask why we chose >> to build on Centos 7? > > CentOS 7 is still the latest and it is maintained until 2024: > > https://wiki.centos.org/About/Product > > I don't have a lot of direct experience with x86 users any longer, but > this seems to be problematic? The last full updates was on the Q3 2020, so it looks unlikely that Centos 7 will upgrade to a new Xen. So this is only going to be a problem for anyone that decides to build there own Xen. I can't tell whether someone may want to build upstream Xen on Centos 7. What I can say is the Arm64 bug in GCC 4.9 will lead to corruption, the bug in GCC < 4.8 looks somewhat less problematic. So, I am sure any user would appreciate if we tell (e.g. throw an error) them when there is a risk that GCC X.Y may miscompile Xen. In the ideal world (e.g if we had unlimited time), we should workaround it in Xen. But this doesn't look easy/possible here. Therefore, for now, I think dropping support for GCC < 4.9 (< 5.1 for Arm) is the best approach. The support can be revived when someone is willing to spend time on it. > > >> ========== >> >> ubuntu-trusty-gcc [3] >> ubuntu-trusty-gcc-debug >> >> Ubuntu trusty is using GCC 4.8.4. This patch is bumping the minimum version to >> 4.9. So the failure is expected. We may have to disable the jobs if my patch >> goes ahead. May I ask why we chose to build on Ubuntu trusty? > > Ubuntu Trusty is in "Extended Security Maintenance", so technically > still supported also: > > https://ubuntu.com/about/release-cycle See above. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 09 10:07:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 10:07:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95293.179823 (Exim 4.92) (envelope-from ) id 1lJZHQ-0007Oy-S3; Tue, 09 Mar 2021 10:07:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95293.179823; Tue, 09 Mar 2021 10:07:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZHQ-0007Or-OM; Tue, 09 Mar 2021 10:07:56 +0000 Received: by outflank-mailman (input) for mailman id 95293; Tue, 09 Mar 2021 10:07:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZHP-0007Om-RP for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 10:07:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZHO-0004Xp-TQ; Tue, 09 Mar 2021 10:07:54 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJZHO-0007O2-N8; Tue, 09 Mar 2021 10:07:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=HxwwefvHBT4hnuYPFrWIFg0Iu9+1e660KWLIRwS9goQ=; b=yUZ2Cgcxu7Yx/tl1hDP2unShJe xOZ26YGQxo37g5xDTM8b6eEPL2bW3/oVK5sTIjW4exg82zrT/scg3r25h+1xzaQfXHawk0ASvK+5W KNSlMbnnDCK4W0KsVx+pMqKd0u1+rfw4Xr53pE8q8lX/2temphWA2oDnYctc/i/3w5+4=; Subject: Re: [PATCH] xen/arm: Use register_t type in cpuinfo entries To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <712d7c6a-3ace-a6b7-a188-faeb4f1258d3@xen.org> <62BD194F-C673-42CD-AEA0-BE4AFA21849E@arm.com> From: Julien Grall Message-ID: <33a75f39-7626-97a9-a90b-3fe8f1fa856f@xen.org> Date: Tue, 9 Mar 2021 10:07:53 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <62BD194F-C673-42CD-AEA0-BE4AFA21849E@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 09/03/2021 09:30, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, > >> On 8 Mar 2021, at 20:48, Julien Grall wrote: >> >> Hi Bertrand, >> >> On 08/03/2021 17:18, Bertrand Marquis wrote: >>> All cpu identification registers that we store in the cpuinfo structure >>> are 64bit on arm64 and 32bit on arm32 so storing the values in 32bit on >>> arm64 is removing the higher bits which might contain information in the >>> future. >>> This patch is changing the types in cpuinfo to register_t (which is >>> 32bit on arm32 and 64bit on arm64) and adding the necessary paddings >>> inside the unions. >> >> I read this as we would replace uint32_t with register_t. However, there are a few instances where you, validly, replace uint64_t with register_t. I would suggest to clarify it in the commit message. > > How about adding the following sentence: “For coherency uint64_t entries are also changed to register_t on 64bit systems." I think you mean consistency rather than coherency. > >> >>> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c >>> index cae2179126..ea0dd3451e 100644 >>> --- a/xen/arch/arm/smpboot.c >>> +++ b/xen/arch/arm/smpboot.c >>> @@ -321,7 +321,8 @@ void start_secondary(void) >>> if ( !opt_hmp_unsafe && >>> current_cpu_data.midr.bits != boot_cpu_data.midr.bits ) >>> { >>> - printk(XENLOG_ERR "CPU%u MIDR (0x%x) does not match boot CPU MIDR (0x%x),\n" >>> + printk(XENLOG_ERR "CPU%u MIDR (0x%"PRIregister") does not match boot " >>> + "CPU MIDR (0x%"PRIregister"),\n" >> >> For printk messages, we don't tend to split it like that (even for more than 80 characters one). Instead, the preferred approach is: >> >> printk(XENLOG_ERR >> "line 1\n" >> "line 2\n") > > Ok. > > Do you want me to send a v2 or can you fix this during the commit ? Both can be fixed on commit. I will queue it to my next branch soon. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 09 10:12:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 10:12:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95296.179835 (Exim 4.92) (envelope-from ) id 1lJZLv-0008G7-F9; Tue, 09 Mar 2021 10:12:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95296.179835; Tue, 09 Mar 2021 10:12:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZLv-0008G0-B4; Tue, 09 Mar 2021 10:12:35 +0000 Received: by outflank-mailman (input) for mailman id 95296; Tue, 09 Mar 2021 10:12:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZLt-0008Fv-T1 for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 10:12:33 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (unknown [40.107.3.77]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b9eeaf6e-0d60-4248-a2a5-bc9744d91b59; Tue, 09 Mar 2021 10:12:32 +0000 (UTC) Received: from AM5PR0701CA0070.eurprd07.prod.outlook.com (2603:10a6:203:2::32) by VI1PR08MB3135.eurprd08.prod.outlook.com (2603:10a6:803:47::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Tue, 9 Mar 2021 10:12:30 +0000 Received: from AM5EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::bd) by AM5PR0701CA0070.outlook.office365.com (2603:10a6:203:2::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.16 via Frontend Transport; Tue, 9 Mar 2021 10:12:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT022.mail.protection.outlook.com (10.152.16.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Tue, 9 Mar 2021 10:12:30 +0000 Received: ("Tessian outbound 67e186bef91c:v71"); Tue, 09 Mar 2021 10:12:29 +0000 Received: from d25c2badf898.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5A43D31E-DC29-451E-BA1D-59AA4EB0625F.1; Tue, 09 Mar 2021 10:12:24 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d25c2badf898.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 09 Mar 2021 10:12:24 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VI1PR08MB3470.eurprd08.prod.outlook.com (2603:10a6:803:7c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Tue, 9 Mar 2021 10:12:21 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3912.027; Tue, 9 Mar 2021 10:12:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9eeaf6e-0d60-4248-a2a5-bc9744d91b59 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OTWFWyQTcXwBDwZZFlryr9XncfO3tk1HEVK3ASeze6o=; b=SXvVT8oYAgUlG7gNGXwZddiWL2qA0lT5Y89+H6ORAo9a27DxWHSIzR0OAC9joSwRbqBuhuee/tHgOzg6QtW80SNMM/oEc7nqa79Hx6WGHQYLyHIXu2JSqnn/MzwDQ66klEdrcnzATuDrHWYJv+zvXoB+VjkmDCsy0lLuW1ohXdI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: e9b249356915e48e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oORUcIq3h4428R+aefre8XPWit0s0bB9ZusdUcoAfgaKbvx6UlTjP312kfUT24a2WpG1rhNHZMhNF2WVyE4K0GYpfKZPXLCQ/T+3bJTTB50V9MR2vXTi9OYacG5jh/bSUn7s2uP8B39DboG0QVwMmSyIxLdyAJ3ZSRKmhkX0Qr0XzNBT036ziqPWn6ewkC7Vq+RaF3OcKaHMaFNOikucmC9QUdiX/3vHpT+tDOfoDJMwMeKNp4xq/rtQfvq/ujLyCFHcjvOkzwJiZtkDXsks2qYup7WsjTqe4D57AAbMO+4ntEA+d9j2sY5oBjnP2XJD9dEcZcYIfne18Zvhy1f8eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OTWFWyQTcXwBDwZZFlryr9XncfO3tk1HEVK3ASeze6o=; b=TevBPbuQPsCbs49JsZXbbRCmwjCWveX7chNdlZufk8OH5s9YkPL8t1QwK+NZg16Jx5xwqK1TJqJUc7hZSTrNilQZEvaQPzMls848blwYrY58VluckAXBVwwyvxeUja8+tgoXsK7iTt3Rw/v11wvbkNfswruYKWSvIWcbI8k/p1honfkM/Lq28JXafitkRgGbshhcXt31a2NUMPs2JCVxg23QQmxtPRB1yLCb93JgvCkdrJ1vkmGQ5UMimIGm+0jzpvWVTLJR5K5AefFSkWOIIuQ0XIeXRB2G/uXroEfmq1LB0OqAus6GWGnnOJqOb7cOrrzKnN1XuwKpgSp105MrSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OTWFWyQTcXwBDwZZFlryr9XncfO3tk1HEVK3ASeze6o=; b=SXvVT8oYAgUlG7gNGXwZddiWL2qA0lT5Y89+H6ORAo9a27DxWHSIzR0OAC9joSwRbqBuhuee/tHgOzg6QtW80SNMM/oEc7nqa79Hx6WGHQYLyHIXu2JSqnn/MzwDQ66klEdrcnzATuDrHWYJv+zvXoB+VjkmDCsy0lLuW1ohXdI= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: Use register_t type in cpuinfo entries Thread-Topic: [PATCH] xen/arm: Use register_t type in cpuinfo entries Thread-Index: AQHXFFQNaLCX4oSw+0OC1jGtjtl2z6p7ZSKAgAAKWICAAAE/AA== Date: Tue, 9 Mar 2021 10:12:20 +0000 Message-ID: References: <712d7c6a-3ace-a6b7-a188-faeb4f1258d3@xen.org> <62BD194F-C673-42CD-AEA0-BE4AFA21849E@arm.com> <33a75f39-7626-97a9-a90b-3fe8f1fa856f@xen.org> In-Reply-To: <33a75f39-7626-97a9-a90b-3fe8f1fa856f@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.243.24.187] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: c851c4b0-db74-4934-5442-08d8e2e3d94c x-ms-traffictypediagnostic: VI1PR08MB3470:|VI1PR08MB3135: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: A6AEkDBGlxCriTmCkDbTDEUYIWd91RQGyAzuaVMvqhldiRDnJCd95X1EBAKicElk0vstHsXHm2bJnkHoQ9lOnBQtKQR3MgpUkoi1fx/BCvFkm3x7b+d2SL7v2e/SU+lmP4I9RlKkidWskY2j7fB5aeKhenXXCs+2NLH/n7k/zWchiLaDWnZWw+88nYsWThI+Ed6fykrmphQubAM4RwTWMjRjuJvzYKURJ+FT9KJiEDPlGInRLf0nI6YPQwYBnKbPrniXB9pge5tEq0lTy7VDRU/W8yeKKb7Shl8ndmW1W+TpXgGHqnA/MEDGbA7BCc2XBlY+BdSA1//u0TeCTPT6SN/pAwv6CwFoyPL1qxHrU947CPG7xYO1RVXKbQFDYMPoT7CPme6ux5WZe99NeA8lVIjEl2hq7G8wHLz2/KRN6J7BYdG22L/pYfFjUR6o5wq/FjK4y0qmR17WWUHADFgCZ6JbAU6sxTvMqqEyqmmfeatVLJO9jHLfq8LKLYVYcsOYJjHh9laLfrKByL+rMXSLICSdpnYQbp1krQ9v+WgS8rzftOYNpLW20O6vqbvY+twHR7UjQYdj/lJvYnpZJZhcXQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6506007)(6486002)(53546011)(8936002)(86362001)(8676002)(36756003)(71200400001)(2616005)(83380400001)(66476007)(186003)(76116006)(91956017)(26005)(66946007)(66446008)(64756008)(66556008)(4326008)(6512007)(5660300002)(54906003)(2906002)(33656002)(6916009)(498600001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?akhHWFF3MlZaMExnSTJCWFRBOWxYbkErV01wWVdhSWNxYWlHSGxsL2pBaEIx?= =?utf-8?B?aWJvTDBld01DWkxqSnpzNUlIVGxGUmJKUDB6RXpSb2cxYWJFdXRyU3oydGls?= =?utf-8?B?emtCd2FwN1lpdEZNU3F4bDVVd0pQeUdrc1FudTNINDFQd2xoUXhwVkR2S0I0?= =?utf-8?B?bVdWUjJWUmlvVEJHakNJdldSNkZmUzlyTnc5QSs1aXllQVkreVA4WndWSnoy?= =?utf-8?B?RnZxN0hpSkNVa2hLcldWSnVZRGVSY2lXT1ZFaWp4RDVXTGdHQXl5VmJQUUpE?= =?utf-8?B?Q2N6RHh6a3YrTzRReXNUQ2I5RklrbTlPYnMramcxRkVDczIvM3NzNTViczl0?= =?utf-8?B?SkYyazJIbHVNUjZXemdWNWZjNXdLN1oyRHVoVU9uNGVLcW1EcE5ZV2s0VHRI?= =?utf-8?B?YlY4dEVzYjZucDRjczFaRmZId3RPM3hkRVNpVkpPc1JPdkhlL004TzNPYVFi?= =?utf-8?B?Q2daRldaNDl5THkxRHV4UjlYRFN1aFk3MEpmd2JvK0psdE81bFk2UVV4bzM5?= =?utf-8?B?dGRGbjdEQmVqdDkrNHhNQzRydHd5MUxENHl3Qm5vZ1IwWHE0ZldPd0lLZkFF?= =?utf-8?B?WjhVR2NGVDdXcFhRYTJMN2YyZUVIbVprekJqWEwwcGM4QnFPcjl5THVXUHV2?= =?utf-8?B?YkZqMTRuZnhQZUo2THppdnBhWlFoZWQwSTZLRTIxSUhzTEhYRFZ1dEdPbm9E?= =?utf-8?B?bXJtZlpOVklLdE5PTFFYZHVyM0hiQmJFckVKWjhwc0ovMmpyMjJoSU42ZzdR?= =?utf-8?B?SlJZblhMbFBHSzJUMm1kaW94aXlNaUdFRFBWSTVhZVJJelNoQ2UzSzErK0gr?= =?utf-8?B?c1ZzM1oxQ3gxTjJ3bzlEZmtxMkNDMitJMDc3d01JWGpPL0MyNHgrRWlkWkJr?= =?utf-8?B?RWJKSEw4YkI5YXlPV0ZpeXE1YWZ6SmtBenUwL0E5cHJ4SzNXNk9zeW5WbnF3?= =?utf-8?B?c2g5cDVBcTlKMmdrSExqbDRwR2M1VTQrTXN2UEljZER3NC9IcCtCbWcyZjdh?= =?utf-8?B?OGJCOHFRTFQ5a1FvMHl2OU1uU3hvZDFxcnhFcldHdktZay9RYW5HVVdaZ1or?= =?utf-8?B?V01lMnk1SENsQUg1cW90anhRM0xJaVU2YkJGMkp2OU1kOHZ1M3A1TkFZVmI0?= =?utf-8?B?TkdwRHk0WER5eExaeXlGLzBCT2tkQnl1Nk4xTkxZS3cwbXYrUFlIYmFFOUNo?= =?utf-8?B?OVRCQVZ2QTRYdkJaVW1LNnVpUmIyc05UaUpzb3pCUHFzNENoWU5VaHBuRmto?= =?utf-8?B?QWFvYnRDSXdPMnZLVVI3VGxCRUlVSVc3a1dzZGV2bWV0YlZYR2lvMDY2eGdU?= =?utf-8?B?dXlEaHArKzdvcmJLdTdCSDVweFZXSzNiM2J5SzJsNWJFbjhZK0hNOCtiTUUr?= =?utf-8?B?V0tUMUxxa0xrbXkxNHgxNHRvaVpSOHhXaExBZDBVNDk0QVh0MVZXRWZhQTIy?= =?utf-8?B?S29uT1J1MXk5VlVxYXZleFkvL2hzUFRlaGs1UktHU094aktNYm1PZHhDQVBv?= =?utf-8?B?MnRsTkwyczZLRWlBeGhIU2EzOG5kOHNrQ3hzM3RVMXF2alJVbnlpY0RocUxP?= =?utf-8?B?NTg0MTBWcHlXYjI2WTNxRVp3S09uelYyRWo0dit6TzRPTk1tTFQ3V1c5NVl2?= =?utf-8?B?ck1sanJyNWxrY0FoYWZvMTZKMSsrOXJoa0JDd254eUd1RlpJOHZDVGVzSUJ4?= =?utf-8?B?ckZ4UjF0ZGIwbDZ3YTF6Yk5ETXE4K0JiZCtTK25GNVpITnR4aXRrOVd6OGxO?= =?utf-8?B?S0VnZDBaN0RNd1grOXJ5b1dYSHp6OG5tYUk5NUNHWEllTkhlaGxyV0VXTkFU?= =?utf-8?B?QkxISFJ0Ky9idmQrTkliQT09?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <3733DD9E4C9CF04EAD974A2B4EA6AF2E@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3470 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 340942bd-7c19-44d5-f8fb-08d8e2e3d394 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wvy9TOJj56lLdj5hfSurvgTzZN10MGysd+JltXYKzpDI2hCx9ZPBaUNtzC3WQ4PnTXalnEfNEEIQ+30a3gqMou/jZGuXz0KSNdRr4MiV9KW9FiFTmOR7BXiVPJUk0FYrLF0N1I3UlwpjONvILCNAnc1rekY329Ps/S9AgE8bltx3YVTSCQ5uCNSkbqR1OSABvDGnFeah6Iy0MuFkzLU33BgWE1a9He/lr+NZ/sIbmKv4MDfmVkqdbZjI/311sHhssT2DYpa8DlqvnK32B6h6BPch75N9a7PnT1dasjWMfm/dXx1st6UvjkLBe62RSwUMWvOHlHrMMXT9aXfy+Mmh+J6P7ghsIsLuj0wKHwNiENAxdjnUorPhFmKzPXfF9zvECxEi0wNrQYy+8xBv5/QnIE0yVS8LpOyi8vvU1ESMlqvq1HpjmDep3aR4AbUF5QCgCmRk80bpDFvX7hBqrJqUa+ENGEAHHNOTISouxoDeqw9svqsNO5hh8Lyl/+9fpnlmKmwTvovmYfNV2PHUT/BNJK3s92Y3RmEW4kT3vMBTnvy4azWEV7Onil5W+FrppdLaBpUM5pxjYTDRMNf0UDStpk+yJfr0iAOQQL7ylNjvsg8pTRbjzEDhc6c1bVWJ5UA7o6mWn8AhTsfoXvep7ny5tHeUWT0+EegBmVjtAzgoZ90= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(47076005)(33656002)(36756003)(498600001)(54906003)(82310400003)(356005)(4326008)(5660300002)(107886003)(36860700001)(53546011)(8676002)(6486002)(6506007)(2906002)(81166007)(83380400001)(6512007)(86362001)(8936002)(186003)(70206006)(26005)(70586007)(336012)(2616005)(6862004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 10:12:30.3487 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c851c4b0-db74-4934-5442-08d8e2e3d94c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3135 SGkgSnVsaWVuLA0KDQo+IE9uIDkgTWFyIDIwMjEsIGF0IDExOjA3LCBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IA0KPiANCj4gT24gMDkvMDMvMjAyMSAwOTozMCwg QmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+IEhpIEp1bGllbiwNCj4gDQo+IEhpIEJlcnRyYW5k LA0KPiANCj4+PiBPbiA4IE1hciAyMDIxLCBhdCAyMDo0OCwgSnVsaWVuIEdyYWxsIDxqdWxpZW5A eGVuLm9yZz4gd3JvdGU6DQo+Pj4gDQo+Pj4gSGkgQmVydHJhbmQsDQo+Pj4gDQo+Pj4gT24gMDgv MDMvMjAyMSAxNzoxOCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4gQWxsIGNwdSBpZGVu dGlmaWNhdGlvbiByZWdpc3RlcnMgdGhhdCB3ZSBzdG9yZSBpbiB0aGUgY3B1aW5mbyBzdHJ1Y3R1 cmUNCj4+Pj4gYXJlIDY0Yml0IG9uIGFybTY0IGFuZCAzMmJpdCBvbiBhcm0zMiBzbyBzdG9yaW5n IHRoZSB2YWx1ZXMgaW4gMzJiaXQgb24NCj4+Pj4gYXJtNjQgaXMgcmVtb3ZpbmcgdGhlIGhpZ2hl ciBiaXRzIHdoaWNoIG1pZ2h0IGNvbnRhaW4gaW5mb3JtYXRpb24gaW4gdGhlDQo+Pj4+IGZ1dHVy ZS4NCj4+Pj4gVGhpcyBwYXRjaCBpcyBjaGFuZ2luZyB0aGUgdHlwZXMgaW4gY3B1aW5mbyB0byBy ZWdpc3Rlcl90ICh3aGljaCBpcw0KPj4+PiAzMmJpdCBvbiBhcm0zMiBhbmQgNjRiaXQgb24gYXJt NjQpIGFuZCBhZGRpbmcgdGhlIG5lY2Vzc2FyeSBwYWRkaW5ncw0KPj4+PiBpbnNpZGUgdGhlIHVu aW9ucy4NCj4+PiANCj4+PiBJIHJlYWQgdGhpcyBhcyB3ZSB3b3VsZCByZXBsYWNlIHVpbnQzMl90 IHdpdGggcmVnaXN0ZXJfdC4gSG93ZXZlciwgdGhlcmUgYXJlIGEgZmV3IGluc3RhbmNlcyB3aGVy ZSB5b3UsIHZhbGlkbHksIHJlcGxhY2UgdWludDY0X3Qgd2l0aCByZWdpc3Rlcl90LiBJIHdvdWxk IHN1Z2dlc3QgdG8gY2xhcmlmeSBpdCBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuDQo+PiBIb3cgYWJv dXQgYWRkaW5nIHRoZSBmb2xsb3dpbmcgc2VudGVuY2U6IOKAnEZvciBjb2hlcmVuY3kgdWludDY0 X3QgZW50cmllcyBhcmUgYWxzbyBjaGFuZ2VkIHRvIHJlZ2lzdGVyX3Qgb24gNjRiaXQgc3lzdGVt cy4iDQo+IA0KPiBJIHRoaW5rIHlvdSBtZWFuIGNvbnNpc3RlbmN5IHJhdGhlciB0aGFuIGNvaGVy ZW5jeS4NCg0KWWVzIHJpZ2h0IDotKQ0KDQo+IA0KPj4+IA0KPj4+PiBkaWZmIC0tZ2l0IGEveGVu L2FyY2gvYXJtL3NtcGJvb3QuYyBiL3hlbi9hcmNoL2FybS9zbXBib290LmMNCj4+Pj4gaW5kZXgg Y2FlMjE3OTEyNi4uZWEwZGQzNDUxZSAxMDA2NDQNCj4+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL3Nt cGJvb3QuYw0KPj4+PiArKysgYi94ZW4vYXJjaC9hcm0vc21wYm9vdC5jDQo+Pj4+IEBAIC0zMjEs NyArMzIxLDggQEAgdm9pZCBzdGFydF9zZWNvbmRhcnkodm9pZCkNCj4+Pj4gICAgICBpZiAoICFv cHRfaG1wX3Vuc2FmZSAmJg0KPj4+PiAgICAgICAgICAgY3VycmVudF9jcHVfZGF0YS5taWRyLmJp dHMgIT0gYm9vdF9jcHVfZGF0YS5taWRyLmJpdHMgKQ0KPj4+PiAgICAgIHsNCj4+Pj4gLSAgICAg ICAgcHJpbnRrKFhFTkxPR19FUlIgIkNQVSV1IE1JRFIgKDB4JXgpIGRvZXMgbm90IG1hdGNoIGJv b3QgQ1BVIE1JRFIgKDB4JXgpLFxuIg0KPj4+PiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAi Q1BVJXUgTUlEUiAoMHglIlBSSXJlZ2lzdGVyIikgZG9lcyBub3QgbWF0Y2ggYm9vdCAiDQo+Pj4+ ICsgICAgICAgICAgICAgICAiQ1BVIE1JRFIgKDB4JSJQUklyZWdpc3RlciIpLFxuIg0KPj4+IA0K Pj4+IEZvciBwcmludGsgbWVzc2FnZXMsIHdlIGRvbid0IHRlbmQgdG8gc3BsaXQgaXQgbGlrZSB0 aGF0IChldmVuIGZvciBtb3JlIHRoYW4gODAgY2hhcmFjdGVycyBvbmUpLiBJbnN0ZWFkLCB0aGUg cHJlZmVycmVkIGFwcHJvYWNoIGlzOg0KPj4+IA0KPj4+IHByaW50ayhYRU5MT0dfRVJSDQo+Pj4g ICAgICAgImxpbmUgMVxuIg0KPj4+ICAgICAgICJsaW5lIDJcbiIpDQo+PiBPay4NCj4+IERvIHlv dSB3YW50IG1lIHRvIHNlbmQgYSB2MiBvciBjYW4geW91IGZpeCB0aGlzIGR1cmluZyB0aGUgY29t bWl0ID8NCj4gDQo+IEJvdGggY2FuIGJlIGZpeGVkIG9uIGNvbW1pdC4gSSB3aWxsIHF1ZXVlIGl0 IHRvIG15IG5leHQgYnJhbmNoIHNvb24uDQoNClBlcmZlY3QsIHRoYW5rcy4NCg0KQ2hlZXJzDQpC ZXJ0cmFuZA0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Tue Mar 09 10:18:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 10:18:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95299.179847 (Exim 4.92) (envelope-from ) id 1lJZRN-0008Ud-31; Tue, 09 Mar 2021 10:18:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95299.179847; Tue, 09 Mar 2021 10:18:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZRM-0008UW-Vy; Tue, 09 Mar 2021 10:18:12 +0000 Received: by outflank-mailman (input) for mailman id 95299; Tue, 09 Mar 2021 10:18:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZRL-0008UR-8f for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 10:18:11 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dad942d1-01af-4a81-8329-eea4e3ff7314; Tue, 09 Mar 2021 10:18:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dad942d1-01af-4a81-8329-eea4e3ff7314 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615285089; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=2SmMOMh5PE6zfrq1kMmA8Ir2i0/rJaSlomgGCaZOBXk=; b=Jj9bizXvJ+Lqn9Or1gQQLJ1rO68E4UoCx0kS8bpsr6otyUCNkwBnY1hB VqvaeumgPc3YzvHIY95bvJfqv5bjZbYtlaVNIEMfOlr24NkCQ3Sbbakbz TVxjurh9Xqw/bAi101BNOQBVT42Ydu9LKQt96j+z3RC/OoexteQmUo3NH g=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: LlU6w+mFcUlqOArpTWbH+wwiBhr0UBqk+EIpJxvn7HoSOb+NJQisxKei1wspMsy2BIC6p9k5uU bLFIZXPgGdJ3rMFLdibUs3iIeZQ8Vdh06qfOPQ4AUs3gU2SBg5nlrPH7/BV6arckcLNV3sO1Ew AirtPfebFTgv1kxPcfmoKUDkEAV7uGMDm6ZwlwvT6iUN9/X4GM22w/9kjZgEK3f+bC3+0Ec9Kx nFeP4o0LSePkntgQE9XOoxLJSRZvRO5v/Gmi6HqpCiwte8gEA5L3KMmiBqfhJNGkr6i4hHF6yV tPc= X-SBRS: 5.2 X-MesageID: 38860305 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,234,1610427600"; d="scan'208";a="38860305" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kq5mwoTcKbyz4AGnYFJCoj28HUeksPtPHkpWUnoHTvSEDcPZwwbnuAqb3dv9U4N5o8DUw+F0/QIFN5TAOXnbsZOgLLpc+1RI+t4R/+MroTuM4w/dygPYKHJ3TRt3SXdQYIYJPvfos0kcMDDfVm/xEVuS+nUu1rR4BDiLn7hwtQ21OltYgqenl0E5al5EjJ+ITNW1puvgjZM/W5JC697REBkiP1iFyOEHivH3Oua4cOAekcft4sKeyBK22ydk8DHhb74AJsTcoQbVBWd5eKZ+EtmbrFdcWgaN5k4zHF+FXHk6Avab8Nldbq5CTvPStsUeaH4em5HHLb8dYLZHlEMbfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ysQDz0JtYjuWpyf2eObItyAVOvfmBWKEK5gpJuJOCkc=; b=Sk0+xOFPvlWkw+O1rGMk1lUwkhhVAm0u6jXH4ifUuVM1owcgK2ri9MEJvpQ75eY3CllOkOPAFWXCECgRlJKbf9/fl/MIvl/GCd/y3ZhS1a73M5q/PQm6HRysOYEane/k9eM2JJWYNN6p2F5LtWc7yM87zXuJbaowWV/cRH6heMS9VODTORcj7mUD1NMcTQqwMQ9SvIPU5lo3l6Q+24Rzhb3QBUJwOrrMREGUeh+fm0bA6YkeQbPTRjDeY0b1+t4+oHRFLRmfBkGakd9Ro7nJPTxSgLURMbm4YGL51oXyuIHT2IZKEvSPbKiPtCBSeHtIF3kBvopO81lE6uo3KsFpSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ysQDz0JtYjuWpyf2eObItyAVOvfmBWKEK5gpJuJOCkc=; b=mYun50+0Bwvxbf4xPrH2hBau1O2X3hhc1Ziy2zoUEEFP6vEodCHMLKqHWyxEcQnA/sYph24KyibIIfwdg7DhORTUVJxNN2aDmEYALWk5HDotb++GnRne1702+rAtYHXCQn8vViaZLY6Bi+dsXThLK6+lg7rwxBZun3+W7CU40Rw= Date: Tue, 9 Mar 2021 11:17:31 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson Subject: Re: [PATCH v2 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads Message-ID: References: <1f19ced7-183b-8f08-3a90-c06039e053a6@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: PR3P192CA0021.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::26) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c21a998d-2d45-421e-0b46-08d8e2e490ed X-MS-TrafficTypeDiagnostic: DM6PR03MB4970: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9df1swE02EmKjWSRmEma6VTCBWJJ/1T4rfzSWxJvUX2JWkTH682vpmKW30bdnV4wCpbL4o8uSnUtZl9eOE1nOAcOAZt8DWcopX54zAXJoB+Iu2e4TxllCvT+7PweIrvu1LzrypjOoZB0Vb8JvWQyNYu94SVmBQ4/bO9CVjpwqyZ4XTwALCqXa7HRTxDahtGo5rRZDK3d2pUYwoWklb64LuIpQGBaib8e4yqOflWxgKlEPJNBMC1+82k+hnl14yXddDzo4nFjB1boNy2djgyNJnKFglRdT281Ikuvtn7u7qEtjsYmJeBHjjNzM6Kz2FRzg+5UXtF1+GXGmBg0DOZ5EYH1VpprCi8Pijy/yz4F+6WUaAi4DBTFxple4QJx/9GlO8ZXkgMjUj72q4tbJ1PZtRiFb9c/c2DpmTwPcLikaLkgYBaBbvqf9cN0afdEa8BpUbUO3gJGkHmQg30eYLhLyPQCaqAhax32zuhXdx8Kys1pg0VvAZZe0D565V8RShMcd85JivHrxBgc3pskFekwBQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(346002)(136003)(39860400002)(366004)(396003)(376002)(86362001)(6666004)(6496006)(66476007)(6486002)(54906003)(4326008)(83380400001)(66946007)(8936002)(478600001)(316002)(5660300002)(33716001)(66556008)(186003)(26005)(8676002)(6916009)(53546011)(2906002)(9686003)(85182001)(16526019)(956004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Kzk4WjZSTmpZNHF2dWRYWDJxaXdvcEc2RGxXUlZCbFJnL3VhUEhDUEFOMWpU?= =?utf-8?B?Tm5DcnFXK3gvQVk1enY5V2lsc3RyYjNOSVMrV0dMSm1ZRTh1anJpWUZuOUU0?= =?utf-8?B?M3RqdWlLWU52N05mdDBGb0hNTDQ0T2xyaDRxUWQxUGRlZXVNTkp2eWlZa3pC?= =?utf-8?B?ZE5pbnVadEw4aEU2SFZ2b2VoRVA1RnlMS0gyc3JoQlVHa2IxWDdZc3I3eUJ5?= =?utf-8?B?MVBmTk1YSUUvK0RINzlpVVYyYnFQQXJLZEpxNTFRQ1kvS2xGVU12ZUhoTkV2?= =?utf-8?B?UXQ2TEhrRTJpQ2I2NTdKUU1QU24yTFRCZTZ1NDJmNzFqVGlsN2c5NDR4WU5v?= =?utf-8?B?YUV2c1ZiUU9vbUxRTkJtTHdXeTVGYVV0VU1YM3h1V1BLbWNPWmFTNURqMng2?= =?utf-8?B?K21iWHBYMXYrUVJzTXhPdUlrN3V4RXU3WXgwNWZLYVNZVUdvR2c2WUsyYUFM?= =?utf-8?B?ZVlxWnhBWnBCSjBWZnFOWUlTRStBS2I1aWlWUlNjZFViclAxYjhQMnZlS2Za?= =?utf-8?B?c0xSbXlobitYamlDd2d5ZXBWbEZhZXVYVityaCtmM3dWQUwvNVFvWVIwTlli?= =?utf-8?B?aVY3UkJ0bzRGWlAwNytUWWNsNUVYbGxWOThNMUQzS09WRzFkd3Z3MkJhUlla?= =?utf-8?B?d1dUODFOWFNqaXZZTHFyL0FpcWFtM0dmendsOWJVUThOdTNNYXRKNDhKVjRt?= =?utf-8?B?eks2VS9TN2E0cmMyN2kzSXU4ZzBBT2pUSlkxdURIdDNDd3Z6S015WTN1eDdu?= =?utf-8?B?NnkrU2VsbVl0ZzQ3RjB5OG13VVZZOGgwTWNUclVrMXR1c09JTVdhbU5TOGh3?= =?utf-8?B?Tk1oWG5XTVNQb0treTErS3pvMEQ0V2dUWENhcE5ZTVl3Tlk3eFFYQTVwTUZm?= =?utf-8?B?MXpCMlRjL0RUTzhLWUgxaHk4OFNsOTBlcENTdW9OcTdTcjFHaGErcEt1MG5C?= =?utf-8?B?T3YvN1o0T3gvU1htNGhVZkpwZElXUVBwdG01WHh0STBYQ3pWUldyeis4Y0ww?= =?utf-8?B?S05rQzFscm9yQzc4Umk3ZlJhNVpOTFlWSlorU3N2Z1p5YlUzSkJ6R1ZYcS9Q?= =?utf-8?B?YjREalZ0bTRlRzZnclhmdmszSldxMlZQeUxaQUJTN0FIaGorNkNTellXYWZJ?= =?utf-8?B?Rll2WVV5SGlQd3ZIREgvVmFid1BNRzYxYmR5MnhrSWRMRmZyRWx1bDNtdTdj?= =?utf-8?B?Q0ZKdXQ0eEVnUUt6RkV0VG4rYlJqVm9STWRIWlpnQjBNWEx3VTUrUG5TMEQ4?= =?utf-8?B?YWRrQXBJMmZDczFkU05qbmtDak9XZTRPN0trR28xTlRnWWgxaEhuTzRjOUR3?= =?utf-8?B?dnFzZXl5YzU3RVBwZ0pGZXFVb0JpTzY2eGFkcDRXTWRKREp1Rm4vQmNJZ09y?= =?utf-8?B?YTluNDBReUhvMDU3NTlLVkFDWERLK0xOOWdvN3U3RHdMQ2RFcWZlWmFlV3l5?= =?utf-8?B?S1YrTVlQRmZHVEM2U0ZZYWg1T3dueTQyd2FJT2VlQmZEQXBpcm1PTmxXSWRL?= =?utf-8?B?U1JZZWRITXhOM0MybDZsNU81VjR2azhFaXFlZENiSjRIZVJ1azdzelZ1aGc4?= =?utf-8?B?dEJoWm16K21DQWRSWVQvRVVvbjhRZGlER0oxY3FlVm83cGM0STc1bFRFQjlt?= =?utf-8?B?RndEUW95RG05ZjJuSldvUVN4eEhrbTdWandmbEV1T2N0K1RaRHVBT01ScmQv?= =?utf-8?B?emR3N2thSGZTcGNqaHhieXdGYUtKUGhpTXBRRVd0U0VQZ2J6TmdWZFR6MW5E?= =?utf-8?B?OThLOG44VXZSQ0NkZUZ2U0tITC95b1ZoeitWR21pSDZIY052NndZV3ZsTldm?= =?utf-8?B?SmJTaWJYTVczMGVIc3Mwdz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: c21a998d-2d45-421e-0b46-08d8e2e490ed X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 10:17:38.7637 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p1Ooi17JwW3FWT/quopJzFLBFQz5zxrPueafHCb3JTx7UIlb2Q7IiQgJMkvWH+LR/nhzkehEeCKODaVFGmP2zg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4970 X-OriginatorOrg: citrix.com On Mon, Mar 08, 2021 at 02:49:19PM +0100, Jan Beulich wrote: > On 08.03.2021 13:11, Roger Pau Monné wrote: > > On Mon, Mar 08, 2021 at 10:33:12AM +0100, Jan Beulich wrote: > >> On 08.03.2021 09:56, Roger Pau Monné wrote: > >>> On Fri, Mar 05, 2021 at 10:50:34AM +0100, Jan Beulich wrote: > >>>> --- a/xen/arch/x86/pv/emul-priv-op.c > >>>> +++ b/xen/arch/x86/pv/emul-priv-op.c > >>>> @@ -874,7 +874,7 @@ static int read_msr(unsigned int reg, ui > >>>> struct vcpu *curr = current; > >>>> const struct domain *currd = curr->domain; > >>>> const struct cpuid_policy *cp = currd->arch.cpuid; > >>>> - bool vpmu_msr = false; > >>>> + bool vpmu_msr = false, warn = false; > >>>> int ret; > >>>> > >>>> if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) > >>>> @@ -882,7 +882,7 @@ static int read_msr(unsigned int reg, ui > >>>> if ( ret == X86EMUL_EXCEPTION ) > >>>> x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); > >>>> > >>>> - return ret; > >>>> + goto done; > >>>> } > >>>> > >>>> switch ( reg ) > >>>> @@ -986,7 +986,7 @@ static int read_msr(unsigned int reg, ui > >>>> } > >>>> /* fall through */ > >>>> default: > >>>> - gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); > >>>> + warn = true; > >>>> break; > >>>> > >>>> normal: > >>>> @@ -995,7 +995,19 @@ static int read_msr(unsigned int reg, ui > >>>> return X86EMUL_OKAY; > >>>> } > >>>> > >>>> - return X86EMUL_UNHANDLEABLE; > >>>> + done: > >>> > >>> Won't this handling be better placed in the 'default' switch case > >>> above? > >> > >> No - see the "goto done" added near the top of the function. > > > > Yes, I'm not sure of that. If guest_rdmsr returns anything different > > than X86EMUL_UNHANDLEABLE it means it has handled the MSR in some way, > > and hence we shouldn't check whether the #GP handler is set or not. > > > > This is not the behavior of older Xen versions, so I'm unsure whether > > we should introduce a policy that's even less strict than the previous > > one in regard to whether a #GP is injected or not. > > > > I know injecting a #GP when the handler is not set is not helpful for > > the guest, but we should limit the workaround to kind of restoring the > > previous behavior for making buggy guests happy, not expanding it > > anymore. > > Yet then we risk breaking guests with any subsequent addition to > guest_rdmsr() which, under whatever extra conditions, wants to > raise #GP. But it's always been like that AFAICT? Additions to guest_{rd/wr}msr preventing taking the default path in the {read/write}_msr PV handlers. If #GP signaled by guest_{rd/wr}msr are no longer injected when the guest #GP handler is not set we might as well drop the rdmsr_safe check and just don't try to inject any #GP at all from MSR accesses unless the handler is setup? I feel this is likely going too far. I agree we should attempt to restore something compatible with the previous behavior for unhandled MSRs, but also not injecting the #GPs signaled by guest_{rd/wr}msr seems to go beyond that. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 09 10:20:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 10:20:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95304.179859 (Exim 4.92) (envelope-from ) id 1lJZTI-0000t6-JS; Tue, 09 Mar 2021 10:20:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95304.179859; Tue, 09 Mar 2021 10:20:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZTI-0000sz-GF; Tue, 09 Mar 2021 10:20:12 +0000 Received: by outflank-mailman (input) for mailman id 95304; Tue, 09 Mar 2021 10:20:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZTG-0000ss-I8 for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 10:20:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZTC-0004mc-VA; Tue, 09 Mar 2021 10:20:06 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJZTC-00083R-Mr; Tue, 09 Mar 2021 10:20:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=8bCymydj2Zxf+dsOZKb5owZGY8CvDvTF4aQ8xq/5zK8=; b=Tyo7fSkJPcqvhlV307n0zx98qW n4z91y//L6Rj25RbBNSidFeUdcByrMiulITr8dZEceDEZ29Cga10UnoTvm0z8kthPPBHrvpuW6mYa 4dKKCslIsnpSbdO/nTqcf9CXNNzRKbaYwATOJP9aMmmYCEL90gt67ALt/XgOqTDfy85M=; Subject: Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com References: <20210308135937.1692-1-michal.orzel@arm.com> <745c5049-fb09-5605-8bc1-838a4def45d6@xen.org> <3353ecf1-3a76-70ee-0475-b7eed90c783c@arm.com> From: Julien Grall Message-ID: Date: Tue, 9 Mar 2021 10:20:04 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <3353ecf1-3a76-70ee-0475-b7eed90c783c@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 09/03/2021 07:34, Michal Orzel wrote: > Hi Julien, Hi, > On 08.03.2021 15:31, Julien Grall wrote: >> Hi, >> >> On 08/03/2021 13:59, Michal Orzel wrote: >>> Currently in order to link existing DTB into Xen image >>> we need to either specify option CONFIG_DTB_FILE on the >>> command line or manually add it into .config. >>> Add Kconfig entry: CONFIG_DTB_FILE to be able to >>> provide the path to DTB we want to embed into Xen image. >>> If no path provided - the dtb will not be embedded. >>> >>> Signed-off-by: Michal Orzel >>> --- >>>   xen/arch/arm/Makefile | 4 +--- >>>   xen/common/Kconfig    | 8 ++++++++ >>>   2 files changed, 9 insertions(+), 3 deletions(-) >>> >>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile >>> index 16e6523e2c..0f3e99d075 100644 >>> --- a/xen/arch/arm/Makefile >>> +++ b/xen/arch/arm/Makefile >>> @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o >>>     #obj-bin-y += ....o >>>   -ifdef CONFIG_DTB_FILE >>> +ifneq ($(CONFIG_DTB_FILE),"") >>>   obj-y += dtb.o >>>   AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>   endif >>> @@ -137,8 +137,6 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >>>   xen.lds: xen.lds.S >>>       $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >>>   -dtb.o: $(CONFIG_DTB_FILE) >>> - >> >> Why is this dropped? > 1)This line is not needed as it has no impact on creating dtb.o > 2)It causes the build failure once CONFIG_DTB_FILE option is in the Kconfig as string within quotes. Because of 1), this should have ideally be part of a separate patch. But I am OK to keep it in this patch so long it is explained in the commit message. >> >>>   .PHONY: clean >>>   clean:: >>>       rm -f asm-offsets.s xen.lds >>> diff --git a/xen/common/Kconfig b/xen/common/Kconfig >>> index eb953d171e..a4c8d09edf 100644 >>> --- a/xen/common/Kconfig >>> +++ b/xen/common/Kconfig >>> @@ -400,6 +400,14 @@ config DOM0_MEM >>>           Leave empty if you are not sure what to specify. >>>   +config DTB_FILE >> >> May I ask why is this add in common/Kconfig rather than arm/Kconfig? >> > I wanted to have it in common features rather than architecture features. > Maybe it could be later on used by other architectures. The same can be argued for a few CONFIG in arch/.../Kconfig. What I want to avoid is spreading depends on in the common/Kconfig. >>> +    string "Absolute path to device tree blob" >>> +    depends on ARM >> >> If this stay in common Kconfig, shouldn't this be gated with HAS_DEVICE_TREE? > No it shouldn't as CONFIG_DTB_FILE depends on CONFIG_ARM which selects CONFIG_HAS_DEVICE_TREE I think you misunderstood my point, what I suggested is replacing "depends on Arm" by "depends on HAS_DEVICE_TREE". This is for two reasons: 1) This avoids spreading depend on in common/kconfig 2) This avoids the assumption that Arm is always using DT If you would rather not use "depends on HAS_DEVICE_TREE", then I think this config should go in arch/arm/Kconfig until we see another users. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 09 10:23:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 10:23:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95307.179870 (Exim 4.92) (envelope-from ) id 1lJZW3-00012i-1q; Tue, 09 Mar 2021 10:23:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95307.179870; Tue, 09 Mar 2021 10:23:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZW2-00012b-V6; Tue, 09 Mar 2021 10:23:02 +0000 Received: by outflank-mailman (input) for mailman id 95307; Tue, 09 Mar 2021 10:23:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZW2-00012V-EC for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 10:23:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZW1-0004oa-Bk; Tue, 09 Mar 2021 10:23:01 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJZW1-0008Pt-4Z; Tue, 09 Mar 2021 10:23:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=covjL8NQ3zDQR3nURxdMLVk/O2gDpVVUe5ScekM1mSo=; b=Vst794sYhOmkXiBZEQQq6ilvWB 0uSnqSwH2XfHuiqdm6PfI+S1a+Qfhp4l6UKsc+Hj6CAVOs5XSmuHHqIdqAYkMGUO/J86FE7SymR8Z NErXGu7aLGb8UZQxVx3O6ItLaWiAOVUf/+r9xLzrTd7zqLtTH6R+UbjGXEBTHWVnW0Vk=; Subject: Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel , Jan Beulich Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210308135937.1692-1-michal.orzel@arm.com> <37ea3c87-c960-4c92-af5f-71f2db774a75@suse.com> From: Julien Grall Message-ID: Date: Tue, 9 Mar 2021 10:22:59 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 09/03/2021 07:28, Michal Orzel wrote: > > > On 08.03.2021 15:26, Jan Beulich wrote: >> On 08.03.2021 14:59, Michal Orzel wrote: >>> --- a/xen/arch/arm/Makefile >>> +++ b/xen/arch/arm/Makefile >>> @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o >>> >>> #obj-bin-y += ....o >>> >>> -ifdef CONFIG_DTB_FILE >>> +ifneq ($(CONFIG_DTB_FILE),"") >>> obj-y += dtb.o >>> AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>> endif >> >> Right now what I have for my Arm test builds is an unquoted >> string in ./.config, e.g.: >> >> CONFIG_DTB_FILE:=/usr/local/arm-linux-gnueabi/vexpress-v2p-aem-v7a.dtb >> >> While I suppose you've tested that the resulting quoting is still >> okay, to reduce confusion perhaps the AFLAGS-y line would better >> be changed to >> >> AFLAGS-y += '-DCONFIG_DTB_FILE=$(CONFIG_DTB_FILE)' > > It is tested. I can change it to: > AFLAGS-y += -DCONFIG_DTB_FILE='$(CONFIG_DTB_FILE)' > as the -DCONFIG_DTB_FILE= does not need to be within quotes May I ask why do we need to keep the AFLAGS-y? Wouldn't Kconfig define it in an header with all the other config option? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 09 10:33:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 10:33:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95311.179882 (Exim 4.92) (envelope-from ) id 1lJZfk-00021W-Ud; Tue, 09 Mar 2021 10:33:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95311.179882; Tue, 09 Mar 2021 10:33:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZfk-00021P-Rh; Tue, 09 Mar 2021 10:33:04 +0000 Received: by outflank-mailman (input) for mailman id 95311; Tue, 09 Mar 2021 10:33:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZfk-00021J-49 for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 10:33:04 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a0c1e427-6464-450e-b8bf-ca6af61566da; Tue, 09 Mar 2021 10:33:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0c1e427-6464-450e-b8bf-ca6af61566da DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615285982; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=3ZqSyUh2mO57bo7ulExPFKnz487wyKo/M9T7fWWtUvA=; b=HCFHyQp8ZQG/JPX4VQDjiWuErMOyikxeI+qy1g+RuXh6cBu1d320RwS5 6+C4ccuomrnvf0Z1B4+dG2AgnZFPaD+/ahS7Qwj5DkW/d1BQ8ryuTOmJS 87OPDou/yb72zFakesMhVigt53HkFR193vYknbjW4r8kY98U4oaQyHfLe g=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: LRagkpW4dziRmi7pp+0YoEGYbkda+LOmMv8k+O8lmOf86KQss5NdARY4dusaN2HEz/wNi2fT/I Eexg1WvcoaQqJwWloZEIqrbKqVYC8Ar3xHWadE48OOAZ1PxjIU7sMek2z+KN1MMB3hl7vjTfgu C+rpESfhnAuwTjuJnZjdnA1OATJjWGnuQpje5e0O9mljlL8W8FTD2i4eGdhneMCu9P2WEPIwG/ 0wvKsPr60P1ZgeM4kGVKKQcfvAG3nFsmUmx+ScA3leojFzEmWn4JFUcVCtB9aNAndFHxgMKRta I3I= X-SBRS: 5.2 X-MesageID: 38838476 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,234,1610427600"; d="scan'208";a="38838476" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QkyEOfLOPJlDVHpxVi43qK1AxaVb4rn9FGmiAbHpp35bllblUvkkvJrwv/8toZhnK1ttmnZxvbpCEkLcJvLCzD1xHpSWWfQzS8/XqWu+tZ4+3j4rVEfoLn5JNc8XqA6jDbsrC3zkwyDbA33ASsyh9OV+ZRtMWmjfEVl+yp6lGymjrNbNWyhB14Coaqlk12F+CRzYInQK4xowDKq+q+0eqmugM7PAIWPHSCJ5dB+oYBulGf6hVo8JtIj0JHxzPGp5uiWEvG8a7pmSiW0IwrEXpArnVbn4RrJT5eDvZwx4WB1/SAQAm+aAUEc4n2tJMb6Iwz3mvVTUh6BidBv7T4mxqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BPNW8Ne7ZAqm2RuRdr8HcWsoLQpHtARH16WwuuXyI+E=; b=XTl1NTOntew9TmeqgY7l6Bj8Xp5XmA+29oxM91Hav9zFQxU/JLTukY7AnHUcJGJ1k+Q+wCCZc8Uz75IGmbG0r5eYAi/D69+dSr3IIJjZYFaCJ7QlaOrSAxJFngy+2LxBQg8sluF2sVlgX20xzpTa3vmShdoLI+ClSi7gyxVPIsDRG0bqV/5TIcoddqZD3amp6R5niIPs41DDDHkpCbvYe5DNlUCXQvZlw0b0pKo1rF6C5SwpBv1GiFkEPVKQQXSLpl5GK1ygwMWa8UCnnjVwysxP5ZIZ5YXmlxawhARfyLpj7QWlChVqK7iCBXCSYaLwzgTWJxO3gdb/Nt5vEKjnzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BPNW8Ne7ZAqm2RuRdr8HcWsoLQpHtARH16WwuuXyI+E=; b=pKrP+nG5K9qoJEaDVQrZBx/54sndHmJkXsn1b9YONIBfe8HN8fcS8bYXthhyXLfgwAHljQGCwP8wmI4Fef61frjRfBf+RuEbot0yG3ZLaAg5GLv25tRQzNFDRzV8Ev4KYqSgvYTMm2850wI6iAIZIOzbg7ePWrbfEKw6CUu319I= Date: Tue, 9 Mar 2021 11:32:47 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Julien Grall CC: Stefano Stabellini , , , , , , , George Dunlap , Anthony PERARD Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) Message-ID: References: <161507188317.11025.6744028462008264481@c667a6b167f6> <10b8048a-e8fe-1fcd-7291-7f1b16da2f4c@xen.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <10b8048a-e8fe-1fcd-7291-7f1b16da2f4c@xen.org> X-ClientProxiedBy: LO4P123CA0053.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 04927fa9-d124-46b4-e025-08d8e2e6b195 X-MS-TrafficTypeDiagnostic: DM5PR03MB2777: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9vz12Aoz5JT8OdI5WTOrZ/DQvJ/HWsIImKDUltMW0o6GamOaYq6hdn8gjET+UvfF5JpyxaiOauCZWXFzlTDasYRK46SOExsIpfxe9jFZMvPaSeG25Hl5xSlwTP1bV2oRYdk8qfG1TlrR7M+sSQRmgxAIPHNbtwWwKjLUMiDEe+Obg3kaecYwpV2Un59Bvxf5FVgw2rbpTpMSXyAZWTjhOD4vFhSTixL/dQprONkVlNJtnP31umS8EgN6jqRvJ9zVAO5UGNYj4Op9r1qrBK/tGpYnV5FBZdR10wqA7dbTuJuQHtusEfqN1tPGbzhTAS0oGBc3YnCE/Vzd5AVB0JhFK5b2pzOBRew0YzBs2hu0owplhOJ4W+mhPG/jQrQVcyvtMjGFf9BYcqFCeaVX0zeO5lt7r9z7U5G9521A7cnnOyH/G3tPlpxITKUoyhfXoz7V/3yByGq91Jhg1KwkgO8lXTqjW0/QdD6skbUfloQzdL3AIBPmq4p/ATvSg/zF4K7oooeiL95K4F4eH2s3l2KXITQv+OrIRRveGgrRZ/ZwfDhPtAyXsaPwJd5QGgjpN8tX29e10E3JNokYSpARvQuVjsWE2C1SXOW8q5jookATxkc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(346002)(376002)(396003)(136003)(39860400002)(366004)(107886003)(316002)(966005)(4326008)(6486002)(956004)(83380400001)(54906003)(5660300002)(86362001)(186003)(16526019)(6496006)(6666004)(478600001)(66556008)(66476007)(53546011)(66946007)(33716001)(2906002)(85182001)(8936002)(26005)(6916009)(9686003)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZGx4d3RBMm5VM1krUXg3MVREWnlDWDJqRThNVmpqNTYwQTJkWWVBWjZxazNu?= =?utf-8?B?SWpQeTJzWGpRV3hIcy9naWtudU41RS9TdDFqaW9ULzFpT24xNzhyVytKWUFi?= =?utf-8?B?eUJnbHV4WE5Jb2xWWDFueDN2cVptOEt4ZzlsVm9hQi9VKzNFTlpXMGQxSVkx?= =?utf-8?B?cmFxbFJmR1ZGSUJhTTRZMWJlbFljQlFCVmxXVEpjUkk5eUl5TUhOQnlKd0k2?= =?utf-8?B?ZExjdGVYZC83bUpUVloyWERHd2UyRGlERi8xSWxXZkRKUEhEVzNrZ00xejA5?= =?utf-8?B?bHNmZUczeWY3QitIV21tcXoxSXBtYjZIYkRNblRvM3N1V2wwRXEyMHprazFT?= =?utf-8?B?c042My83YzBGdDJ4c3VJWUFuZWxzOUk0cTRsR2ZZMkVGblh5cStFN1pmQXdR?= =?utf-8?B?UFJKemgrMWp0SUkrMWNLQlpNTlRiKzFzbUZRNk1xdEd0emxvV1NNaUNiam1E?= =?utf-8?B?cngwdXVJZkdHMTU4M1dFbXhQcHlpb1ZGeUFtVDYrK0pUczgxazFkVzV2eFo3?= =?utf-8?B?YXBaQlEvLzVZdUc3WWxqeXhGK0Y3YlNRM2x2SlRMZ2ltUG9KSTFwUndGamFF?= =?utf-8?B?alY3QmpVS1htTG5LTzBsakJyR1IwUzBTd3lOc3dhUE80KzFlWFNMRXBOeW41?= =?utf-8?B?QkZjRHFGbXdrTjAzNG1wUVREV3pGZmVYeHorTGdvSWdIa0plSjBTblV1aEtG?= =?utf-8?B?cFRUUGQ4ZHJFMUE4VTlZUmRsSm53U2VDN0JVU01MRXZPcWM4UDMrQWFJQ092?= =?utf-8?B?UVUxYVhZWHVnaE96WEJzMm5zY1ZzdlFrbDVHVkxYcWdaZi9nRlUyQm1aLytj?= =?utf-8?B?ZzNSeTkxckxrNnlQRmluRGlzUUJKQUpMS2RhMk0zT1h4VzhlMTM1SXl6NzRY?= =?utf-8?B?Z2h1RklGRkNxMURNc01GcGhQa1lMak1QRHlLZHNFTUxNTjhSMS9GYlZrSUht?= =?utf-8?B?bCt4RG1sRzZSM3hNb0JGcktDbTI4aXpHSjNmN1dDWm1yMFNmeEFVQ2RUcWZw?= =?utf-8?B?WWhqSVc4WVA4enQ1WnFnSHlhZ2hnMFQ5OEJkS3k3ZVlyekM4Qkx6NHIyM3ZX?= =?utf-8?B?WUErMzBBU1VCc0NpVDc3MEd4RG1BRXJlb1daRWxKVzRFYXlSTml1clN4czZU?= =?utf-8?B?WTdYaFNyS2JRU282TWJLTEM4UWtpbjdEM3BMQ2pFemplRFlBbHVqMUUwUTBP?= =?utf-8?B?R1RPbkk0cERHT0w3M2tvc3VsTHdjVkNVWkoxRDV3U1hrdnN3RW9PdzR2cjRL?= =?utf-8?B?ZkdndG9Vd201QTBmcDhiL1BYcHFZRWlja2xKKzh2UkJFOHpHc0IzalRaL0Q5?= =?utf-8?B?OU5nUnY1T05uL00yOWVmWnZVZXhiQ2QvWjVoUDdyUHVjM1VGcEFlOEoxbzRL?= =?utf-8?B?NHJkZ2dPMm5RY0hDOWExM2dhVW5oZFpxRG5lUFg2UmJKRWVWdnJnZGxnc1ll?= =?utf-8?B?TmV2RldKYnp0MTlGcnRvcm5QV2w5bDhUS3hma1g1UGtQZnhzYVVnWS95NXhX?= =?utf-8?B?NHc5aE1QYmk2WHkxSnVJcDdDMGRpQ0ZMbXRXRHpISzBPWXJOZVlDNmwyVE04?= =?utf-8?B?VWF2TDN2eTlrRjc2eU5tRU4xcm82M0dIUWNlcW55UG9ncmlwd2tjcVlqK2VM?= =?utf-8?B?ZnRsN1FRakd5blpSVTJYU0UxNmFlMitHTEJEdjdsS0NXVFNaeVd2UmlBdUI2?= =?utf-8?B?TzRyMlF1UklCc0tsaG83TTZLY1hxdDNoNFlNMXpsWExqYllEZjRFNTB6Qk9P?= =?utf-8?B?ZHhxbjdqS1F3MjFPUTZ5RjJjSHJkcXlhWStrdzl6aTdQLzBIYktqaDljem0r?= =?utf-8?B?dGZiVXVwRDJnRWhCU3RXZz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 04927fa9-d124-46b4-e025-08d8e2e6b195 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 10:32:52.4960 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uLNUPZRy7HLA4r0v6UdxgkaYkfbx7SYfX5nw6X9+PLm+/D028vBKYUt68SSC4gmmDg5fmsOnXlHQdTizMjfloQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2777 X-OriginatorOrg: citrix.com On Tue, Mar 09, 2021 at 10:05:18AM +0000, Julien Grall wrote: > Hi Stefano, > > On 09/03/2021 00:59, Stefano Stabellini wrote: > > On Sun, 7 Mar 2021, Julien Grall wrote: > > > On 06/03/2021 23:04, no-reply@patchew.org wrote: Where does one has to register to get the patchew build failures? > > > > Hi, > > > > > > > > Patchew automatically ran gitlab-ci pipeline with this patch (series) > > > > applied, but the job failed. Maybe there's a bug in the patches? > > > > > > > > You can find the link to the pipeline near the end of the report below: > > > > > > > > Type: series > > > > Message-id: 20210306214148.27021-1-julien@xen.org > > > > Subject: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to > > > > 4.9 (5.1 on arm64) > > > > > > > > === TEST SCRIPT BEGIN === > > > > #!/bin/bash > > > > sleep 10 > > > > patchew gitlab-pipeline-check -p xen-project/patchew/xen > > > > === TEST SCRIPT END === > > > > > > > > warning: redirecting to https://gitlab.com/xen-project/patchew/xen.git/ > > > > warning: redirecting to https://gitlab.com/xen-project/patchew/xen.git/ > > > > From https://gitlab.com/xen-project/patchew/xen > > > > * [new tag] patchew/20210306214148.27021-1-julien@xen.org -> > > > > patchew/20210306214148.27021-1-julien@xen.org > > > > Switched to a new branch 'test' > > > > f332859b88 xen: Bump the minimum version of GCC supported to 4.9 (5.1 on > > > > arm64) > > > > > > > > === OUTPUT BEGIN === > > > > [2021-03-06 21:45:17] Looking up pipeline... > > > > [2021-03-06 21:45:18] Found pipeline 266507477: > > > > > > > > https://gitlab.com/xen-project/patchew/xen/-/pipelines/266507477 > > > > > > > > [2021-03-06 21:45:18] Waiting for pipeline to finish... > > > > [2021-03-06 22:00:21] Still waiting... > > > > [2021-03-06 22:15:26] Still waiting... > > > > [2021-03-06 22:30:31] Still waiting... > > > > [2021-03-06 22:45:35] Still waiting... > > > > [2021-03-06 23:00:41] Still waiting... > > > > [2021-03-06 23:04:42] Pipeline failed > > > > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-clang-pvh' in stage 'test' is > > > > skipped > > > > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-gcc-pvh' in stage 'test' is > > > > skipped > > > > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-clang' in stage 'test' is > > > > skipped > > > > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-gcc' in stage 'test' is skipped > > > > [2021-03-06 23:04:42] Job 'qemu-smoke-arm64-gcc' in stage 'test' is skipped > > > > [2021-03-06 23:04:42] Job 'qemu-alpine-arm64-gcc' in stage 'test' is skipped > > > > [2021-03-06 23:04:42] Job 'build-each-commit-gcc' in stage 'test' is skipped > > > > [2021-03-06 23:04:42] Job 'alpine-3.12-clang' in stage 'build' is failed > > > > > > The following jobs are failing: > > > > > > alpine-3.12-clang [1] > > > debian-unstable-32-gcc-debug > > > debian-unstable-clang > > > debian-unstable-gcc-randconfig > > > ubuntu-bionic-clang > > > > > > Cloning into 'qemu-xen-dir-remote.tmp'... > > > error: inflate: data stream error (incorrect data check) > > > fatal: serious inflate inconsistency > > > fatal: index-pack failed > > > > > > This looks unrelated to my patch. Possibly a network error? > > > > Yeah. > > > > > > > ========= > > > > > > centos-7-2-gcc [2] > > > centos-7-2-gcc-debug > > > centos-7-gcc > > > centos-7-gcc-debug > > > > > > Centos 7 is using GCC 4.8.5. This patch is bumping the minimum version to 4.9. > > > So the failure is expected. > > > > > > We may have to disable the jobs if my patch goes ahead. May I ask why we chose > > > to build on Centos 7? > > > > CentOS 7 is still the latest and it is maintained until 2024: > > > > https://wiki.centos.org/About/Product > > > > I don't have a lot of direct experience with x86 users any longer, but > > this seems to be problematic? > > The last full updates was on the Q3 2020, so it looks unlikely that Centos 7 > will upgrade to a new Xen. > > So this is only going to be a problem for anyone that decides to build there > own Xen. > > I can't tell whether someone may want to build upstream Xen on Centos 7. > What I can say is the Arm64 bug in GCC 4.9 will lead to corruption, the bug > in GCC < 4.8 looks somewhat less problematic. > > So, I am sure any user would appreciate if we tell (e.g. throw an error) > them when there is a risk that GCC X.Y may miscompile Xen. > > In the ideal world (e.g if we had unlimited time), we should workaround it > in Xen. But this doesn't look easy/possible here. > > Therefore, for now, I think dropping support for GCC < 4.9 (< 5.1 for Arm) > is the best approach. The support can be revived when someone is willing to > spend time on it. Does CentOS has something like Debian backports to get updated major versions of packages? Also, I think we do maintain Xen on CentOS using a separate repository, so newer versions of Xen will be added to CentOS. Adding George and Anthony since they know about that. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 09 10:36:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 10:36:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95314.179894 (Exim 4.92) (envelope-from ) id 1lJZiv-00029U-EK; Tue, 09 Mar 2021 10:36:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95314.179894; Tue, 09 Mar 2021 10:36:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZiv-00029N-BE; Tue, 09 Mar 2021 10:36:21 +0000 Received: by outflank-mailman (input) for mailman id 95314; Tue, 09 Mar 2021 10:36:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZiu-00029I-4V for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 10:36:20 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 1ac6d099-7f0d-4c35-bca8-2730628681f6; Tue, 09 Mar 2021 10:36:18 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2A36A31B; Tue, 9 Mar 2021 02:36:18 -0800 (PST) Received: from [10.57.15.131] (unknown [10.57.15.131]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E100B3F71B; Tue, 9 Mar 2021 02:36:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ac6d099-7f0d-4c35-bca8-2730628681f6 Subject: Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com References: <20210308135937.1692-1-michal.orzel@arm.com> <745c5049-fb09-5605-8bc1-838a4def45d6@xen.org> <3353ecf1-3a76-70ee-0475-b7eed90c783c@arm.com> From: Michal Orzel Message-ID: Date: Tue, 9 Mar 2021 11:36:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi, On 09.03.2021 11:20, Julien Grall wrote: > > > On 09/03/2021 07:34, Michal Orzel wrote: >> Hi Julien, > > Hi, > >> On 08.03.2021 15:31, Julien Grall wrote: >>> Hi, >>> >>> On 08/03/2021 13:59, Michal Orzel wrote: >>>> Currently in order to link existing DTB into Xen image >>>> we need to either specify option CONFIG_DTB_FILE on the >>>> command line or manually add it into .config. >>>> Add Kconfig entry: CONFIG_DTB_FILE to be able to >>>> provide the path to DTB we want to embed into Xen image. >>>> If no path provided - the dtb will not be embedded. >>>> >>>> Signed-off-by: Michal Orzel >>>> --- >>>>    xen/arch/arm/Makefile | 4 +--- >>>>    xen/common/Kconfig    | 8 ++++++++ >>>>    2 files changed, 9 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile >>>> index 16e6523e2c..0f3e99d075 100644 >>>> --- a/xen/arch/arm/Makefile >>>> +++ b/xen/arch/arm/Makefile >>>> @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o >>>>      #obj-bin-y += ....o >>>>    -ifdef CONFIG_DTB_FILE >>>> +ifneq ($(CONFIG_DTB_FILE),"") >>>>    obj-y += dtb.o >>>>    AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>>    endif >>>> @@ -137,8 +137,6 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >>>>    xen.lds: xen.lds.S >>>>        $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >>>>    -dtb.o: $(CONFIG_DTB_FILE) >>>> - >>> >>> Why is this dropped? >> 1)This line is not needed as it has no impact on creating dtb.o >> 2)It causes the build failure once CONFIG_DTB_FILE option is in the Kconfig as string within quotes. > > Because of 1), this should have ideally be part of a separate patch. But I am OK to keep it in this patch so long it is explained in the commit message. Ok I will explain it in the commit msg in v3 > >>> >>>>    .PHONY: clean >>>>    clean:: >>>>        rm -f asm-offsets.s xen.lds >>>> diff --git a/xen/common/Kconfig b/xen/common/Kconfig >>>> index eb953d171e..a4c8d09edf 100644 >>>> --- a/xen/common/Kconfig >>>> +++ b/xen/common/Kconfig >>>> @@ -400,6 +400,14 @@ config DOM0_MEM >>>>            Leave empty if you are not sure what to specify. >>>>    +config DTB_FILE >>> >>> May I ask why is this add in common/Kconfig rather than arm/Kconfig? >>> >> I wanted to have it in common features rather than architecture features. >> Maybe it could be later on used by other architectures. > > The same can be argued for a few CONFIG in arch/.../Kconfig. What I want to avoid is spreading depends on in the common/Kconfig. > >>>> +    string "Absolute path to device tree blob" >>>> +    depends on ARM >>> >>> If this stay in common Kconfig, shouldn't this be gated with HAS_DEVICE_TREE? >> No it shouldn't as  CONFIG_DTB_FILE depends on CONFIG_ARM which selects CONFIG_HAS_DEVICE_TREE > I think you misunderstood my point, what I suggested is replacing "depends on Arm" by "depends on HAS_DEVICE_TREE". > > This is for two reasons: >   1) This avoids spreading depend on in common/kconfig >   2) This avoids the assumption that Arm is always using DT > > If you would rather not use "depends on HAS_DEVICE_TREE", then I think this config should go in arch/arm/Kconfig until we see another users. > Ok I will keep it in common/Kconfig but switch to depends on HAS_DEVICE_TREE > Cheers, > Cheers From xen-devel-bounces@lists.xenproject.org Tue Mar 09 10:37:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 10:37:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95317.179907 (Exim 4.92) (envelope-from ) id 1lJZjf-0002H3-Np; Tue, 09 Mar 2021 10:37:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95317.179907; Tue, 09 Mar 2021 10:37:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZjf-0002Gw-Ki; Tue, 09 Mar 2021 10:37:07 +0000 Received: by outflank-mailman (input) for mailman id 95317; Tue, 09 Mar 2021 10:37:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZje-0002Gn-3i for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 10:37:06 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 82ac0d2a-4bd5-4127-b049-a7995d75f876; Tue, 09 Mar 2021 10:37:05 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DEE651063; Tue, 9 Mar 2021 02:37:04 -0800 (PST) Received: from [10.57.15.131] (unknown [10.57.15.131]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A6CD33F71B; Tue, 9 Mar 2021 02:37:02 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82ac0d2a-4bd5-4127-b049-a7995d75f876 Subject: Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Julien Grall , Jan Beulich Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210308135937.1692-1-michal.orzel@arm.com> <37ea3c87-c960-4c92-af5f-71f2db774a75@suse.com> From: Michal Orzel Message-ID: <6ce4c4c6-91a4-5c88-abe1-ac1eec52c663@arm.com> Date: Tue, 9 Mar 2021 11:37:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09.03.2021 11:22, Julien Grall wrote: > > > On 09/03/2021 07:28, Michal Orzel wrote: >> >> >> On 08.03.2021 15:26, Jan Beulich wrote: >>> On 08.03.2021 14:59, Michal Orzel wrote: >>>> --- a/xen/arch/arm/Makefile >>>> +++ b/xen/arch/arm/Makefile >>>> @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o >>>>     #obj-bin-y += ....o >>>>   -ifdef CONFIG_DTB_FILE >>>> +ifneq ($(CONFIG_DTB_FILE),"") >>>>   obj-y += dtb.o >>>>   AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>>   endif >>> >>> Right now what I have for my Arm test builds is an unquoted >>> string in ./.config, e.g.: >>> >>> CONFIG_DTB_FILE:=/usr/local/arm-linux-gnueabi/vexpress-v2p-aem-v7a.dtb >>> >>> While I suppose you've tested that the resulting quoting is still >>> okay, to reduce confusion perhaps the AFLAGS-y line would better >>> be changed to >>> >>> AFLAGS-y += '-DCONFIG_DTB_FILE=$(CONFIG_DTB_FILE)' >> >> It is tested. I can change it to: >> AFLAGS-y += -DCONFIG_DTB_FILE='$(CONFIG_DTB_FILE)' >> as the -DCONFIG_DTB_FILE= does not need to be within quotes > > May I ask why do we need to keep the AFLAGS-y? Wouldn't Kconfig define it in an header with all the other config option? > It is interesting. I did not investigate it when creating a patch. I just tested and indeed we can get rid of AFLAGS-y line. Will do in v3 > Cheers, > Cheers From xen-devel-bounces@lists.xenproject.org Tue Mar 09 10:49:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 10:49:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95323.179918 (Exim 4.92) (envelope-from ) id 1lJZvW-0003NH-09; Tue, 09 Mar 2021 10:49:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95323.179918; Tue, 09 Mar 2021 10:49:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZvV-0003NA-TV; Tue, 09 Mar 2021 10:49:21 +0000 Received: by outflank-mailman (input) for mailman id 95323; Tue, 09 Mar 2021 10:49:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJZvV-0003N5-6Y for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 10:49:21 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 0bcd7d5d-1a21-4f01-b65b-5a52b4c264ba; Tue, 09 Mar 2021 10:49:20 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4585931B; Tue, 9 Mar 2021 02:49:20 -0800 (PST) Received: from e123311-lin.arm.com (unknown [10.57.15.131]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 693413F70D; Tue, 9 Mar 2021 02:49:18 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bcd7d5d-1a21-4f01-b65b-5a52b4c264ba From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com Subject: [PATCH v3] arm: Add Kconfig entry to select CONFIG_DTB_FILE Date: Tue, 9 Mar 2021 11:49:13 +0100 Message-Id: <20210309104913.2776-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently in order to link existing DTB into Xen image we need to either specify option CONFIG_DTB_FILE on the command line or manually add it into .config. Add Kconfig entry: CONFIG_DTB_FILE to be able to provide the path to DTB we want to embed into Xen image. If no path provided - the dtb will not be embedded. Remove the line: dtb.o: $(CONFIG_DTB_FILE) as it has no impact on creating dtb.o and causes the build failure as the dtb path is now within quotes. Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" as it is not needed since Kconfig will define it in a header with all the other config options. Signed-off-by: Michal Orzel --- xen/arch/arm/Makefile | 5 +---- xen/common/Kconfig | 8 ++++++++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 16e6523e2c..d7702258f5 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -68,9 +68,8 @@ extra-y += $(TARGET_SUBARCH)/head.o #obj-bin-y += ....o -ifdef CONFIG_DTB_FILE +ifneq ($(CONFIG_DTB_FILE),"") obj-y += dtb.o -AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" endif ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) @@ -137,8 +136,6 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c xen.lds: xen.lds.S $(CPP) -P $(a_flags) -MQ $@ -o $@ $< -dtb.o: $(CONFIG_DTB_FILE) - .PHONY: clean clean:: rm -f asm-offsets.s xen.lds diff --git a/xen/common/Kconfig b/xen/common/Kconfig index eb953d171e..a27836bf47 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -400,6 +400,14 @@ config DOM0_MEM Leave empty if you are not sure what to specify. +config DTB_FILE + string "Absolute path to device tree blob" + depends on HAS_DEVICE_TREE + ---help--- + When using a bootloader that has no device tree support or when there + is no bootloader at all, use this option to specify the absolute path + to a device tree that will be linked directly inside Xen binary. + config TRACEBUFFER bool "Enable tracing infrastructure" if EXPERT default y -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 10:57:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 10:57:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95326.179931 (Exim 4.92) (envelope-from ) id 1lJa3T-0004Gn-RO; Tue, 09 Mar 2021 10:57:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95326.179931; Tue, 09 Mar 2021 10:57:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJa3T-0004Gg-Nz; Tue, 09 Mar 2021 10:57:35 +0000 Received: by outflank-mailman (input) for mailman id 95326; Tue, 09 Mar 2021 10:57:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJa3S-0004Gb-DK for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 10:57:34 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 97ef1804-c7ee-45f7-8908-73b2de59e1df; Tue, 09 Mar 2021 10:57:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97ef1804-c7ee-45f7-8908-73b2de59e1df DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615287447; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=0wIkc+GpCCB80ud8uU0TvIrXl/rwMlgfoeQP0uwLugc=; b=htAeueqcN2wo+lKqCd9opg82BGzqft7xQWDOqheqaL+ZzB45DYfRKYED mqDIjbV2crLTttohVlABjxvqDeTuB9B/dyoYc18mvEYjw8iJOwblp7Sco Pe1YpRpHLulwz3eb2P26D/S5cjURT6nnxd0dsSW77nw8HFtj5RtubOmpv I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: CPCq6Nyzrsa2KXb/D78yQk7+aPyRpj0OjMwHjZA4FUVi3kpSKIfD4MLNSeUCkqusFqnguXmY95 4D+rjCaJW2AdchVn9AbQ+W8+c8sMxmzSqaqdUdWoCrbADFt0eQj/vGLmOyZo+f1NhbnbxfR7e1 vlKf6CSoyo3S4IlDSm5B71I/b7HhiFWFqqxERgA+7ElzxoVpXddKEwKmyxL5DAtQeCzpTBuUoq 9uy0ZwnPdA4b4KwSl3IngitmtqV4SAPqgCSRZ7kUzAYD37iVxLWU1spW/faEFCL3HOpH5hXBr9 8xA= X-SBRS: 5.2 X-MesageID: 38758766 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,234,1610427600"; d="scan'208";a="38758766" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y7jBZmSfj1lqdD7Z6CFcZao7LmUm4tkSYtd/rtwb4F/3c+vQHXtnsZf0KLV4UwioHRW0wMShL5yv5W1K4Rnswa17KSBzTnpdhbkY7YhcYVnr7BlcIZjLW8rpm5FNycOaUPJo10YhhA5H0L2Lq5+8zFUX28xgXAr9Axr9kNw+yB9BEWPMYV59l5nsoHuuHUeDQUfyidFE13vsicyvK/FqD7yo2Oj+HLhlYOz2gPViIMHnNdDp+5fPE/2GiC5xrvsf+1Ajt0/9z92EjKnOLGGCesmu/ZRBupTBld8q8G7fBBlAClvyZ2dbPQSe4nR9ndqZI9tMihajFFTQ25ktf92hhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UqAp3HV28uCxTYHCtex8ff3bCSR1XtAN4nU6VEb7wkM=; b=K3zWG2W82URziBMbuh0Yh+oj92AkPkDoJAsyHwPzvmh/6KVPxjDpqQDHF5IWWIbEhTVKS75OhyKo23dN9OLW5gQA9IyQ4PvZUD7k5W82RonMtton6Um+yqRNgHVDzwAvSIsiWsBbfZT2HsMHNiIU2oathMy85/OJU8p7dmJW551NmWU8LZ3U+vn5SFyqIZ0HvqhYWsaZXlVj+9HXSdtbMhpoGhpfRxQGNUwt0X/MmalY/KBplxc9LgCVENafHfUSpGeA8qm+gTgg+LgLepqDxw4PPrgAd/ilIluShSLxyjHGbEinWqvcYaPCmwUwq8eAI6MN7fKJ5RreM5tQhlXIxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UqAp3HV28uCxTYHCtex8ff3bCSR1XtAN4nU6VEb7wkM=; b=veSwSFav0fOMBwMaMOb0hVvkKeO6CbFwJg9BQQLiC8CDqI/jeeZwWek1OU32L/VYgiCpkIcTeZyqqFhJexsgJXBWnM6+7uI9kBKD1ukNeTl5FcmuhQMy5QkAkncbgQNFmSyp4CdMyZP6kOATtvz1eoPAMTJ9yILjnrz4Avlba2A= From: Roger Pau Monne To: CC: Roger Pau Monne , Ian Jackson , Wei Liu , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection Date: Tue, 9 Mar 2021 11:56:34 +0100 Message-ID: <20210309105634.7200-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0496.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf6ad9f1-c697-449e-cee7-08d8e2ea05c0 X-MS-TrafficTypeDiagnostic: DM5PR03MB2841: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HUWg2fQOZGGem1QUz7pcCRS9wrEHufDDsEmgAttbL8i4OxcKoRJuGqJRJc/8dlicxDpjGIjXWUGw+SAXJYtRgTdUy9SmRPZODKpF4C5E3z4X2NMoOB1ctqkWLRvfSepPlfvuZC3aKMGuAwKtU+NMeqFGnl1t3p6WVjBwIO/8KNc4UXL3RdbzupJIqfCkLcX7PnwIsFrrNc/VZsHNeyuuFimhi7yLs+A/RK5Q8f8wxqlONaRfPBWW/gmMpDjyoUIBaQv1Q8PEQsLp391bI+Qp1BkCWjYq9JykKvxwyFIUJuC6okWWpD+sEBfYcAiL2Uq4aYAtV/2irniZudtxNJ7WdsG4TRCz0D3TpoPqIl/WalKa0qDMA1UNVJq7tE0G+Pwbrocsuu8Lp99//3Nq92U7zJvuAEkL9++SGO+289TcCIGlvnfc0M6kc1gLHeVOLW9puuAHYfqQtbVYMRx9ZU4BsXjU9tC04Bz9Ny6YjpsTVcTjtS7Je3EN6QqKXDPa/xazsKqPZqR8sFrFAQ4+oT+bZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(396003)(136003)(346002)(376002)(478600001)(83380400001)(26005)(6916009)(186003)(16526019)(6666004)(1076003)(30864003)(2616005)(2906002)(956004)(6496006)(5660300002)(8676002)(54906003)(86362001)(316002)(6486002)(4326008)(7416002)(8936002)(36756003)(66946007)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NUNXVmNSWnV6NGFwby9rNFEvOHJhREJaUGFxdjNaQURqQ01zcjh6NVpEOGMw?= =?utf-8?B?NnVOZzNyRm5yODlKemdma3ZrQy9aTEtBK3hYTHQ0ZUl4VlJWemNNZ1d4b1dE?= =?utf-8?B?MEVFZGdEUkpvaVgxSU5EYVZZYVR1MGM2U1lpVnBmNVU5OGQ5Qm9BVUtIenc1?= =?utf-8?B?QUhoNGd5WEg1clN6cWlBODEyZ0p6MVkzb0IyZGs4c09HMlQyREZZdVFiMit3?= =?utf-8?B?dnBsaVRhZTVKbU5Ta2RoT1pYUXZuTHI2NmRqOXZ3S0xjeVdCMkJ5NzdkcjBL?= =?utf-8?B?VVR3WUFMUmg2VVZmcTBjSDlMV2RZZ2VISFhzOEJTVmVEem9VR2pGRThvSUor?= =?utf-8?B?aXpRWWVqUWw2K3dmQnd6WDlzNUVrUnlZQ0V2dWRLMnV4TmhRdGZSYU9KUTNZ?= =?utf-8?B?ZGhBYzdwc25WYitYTG13T3lrTG5zelJkeTM2Lzk3REUxczRGU255akRJZm42?= =?utf-8?B?TVM4QnR6K1o3c3Aybk0vT0FQT3RBZWM2R25Nb2ZjTGJ1M0RDb2JIVncvQTJM?= =?utf-8?B?Z1dDZmg4aFBQN2FnZjNHNlU1OGdCUHUwa2JVcjkxWEw0KzlnREFYOU1JdlhG?= =?utf-8?B?S0NoeTRwSjM0WFRaZzhhWDFWcU1hVjJMMFRxWW11bG0wYlQwQ3ZweVYzNTFP?= =?utf-8?B?bnJMcFlHM1h3bjNsTXNrN3BSQkNkNk05emZPcm9YZFVqcjV0K0M0WHZiWWIz?= =?utf-8?B?Y1h2dzFMME9OakZxNldRNVVjdTVyOVRwWGRwTkVaUnIvaWppZHQ0ekhMRXlH?= =?utf-8?B?ZWZuRzFLcjF1WUFmUzZDYm40TGZXY3d0ZG44Y0FwZ1NWOXJmUkxuT1h0SnZj?= =?utf-8?B?VnNkQW84b0FGcUVyQjZhcGlHbDF1d1F5KytqSWl3b0YyWWtacTNpbU84VFR4?= =?utf-8?B?ZDF3UU0xTTc5U0NzVHRkL2pxbHVOZGw0aHpvc0pxUzJVVldCV2xPVW5Yc0lG?= =?utf-8?B?Y2doK0hoTjlZa2xLd29kU3JialRZZm5kZWpkaGpqRG1UU2pZU0JyZ2dpWVli?= =?utf-8?B?NC9heFdYdUVQbDhkbkkzQ2pQMlR4eWc1WXJLOU5UZlVrMW1vQkF2MlZtd2xl?= =?utf-8?B?NGZOWUF5amdCVXRtS0JBSE1GZDgyRDJlbzEyL3JoMU1WUllVOG5VaUZwUlR6?= =?utf-8?B?cTRRKzRyY2NNek82M0N4MWsybkpxMmQrVUZnam83MkVjTVVvWFExbWJCSHMx?= =?utf-8?B?c2FjWTBPMW1peEFFLzlHNzBnam4rb2lpWTBUT01OWTFiMElQRG5odTVYaWVl?= =?utf-8?B?RjdZb0ZNY2s0RGpxNnlKUlcrUzd4RW1nSXdJb0l6SkhabHBPTkFmWllMSXA0?= =?utf-8?B?bTNXL1dpdHpaOG9ReEc2M3A0REZDSWxzdkJ4SUNUN2VpYyt3SDBNcEl3N1M1?= =?utf-8?B?SVh0MG9jdzhQUVVFaHFzekNUVExMRnBYM3NudWQ3SmwvWXBRK092anoyTWhs?= =?utf-8?B?UVhQMHkrR2pBQ2JQNUIzMFlVRWpFZnNSOTR4TmpMQ3BrcXhmOVA2K1ZWWDls?= =?utf-8?B?U3c3OHZxT0k5dWI3RlUwVE9ZMUp3RUQrS2l3UHdxL0NrTGJaR016b0dsWFF1?= =?utf-8?B?c20xSjlYTXBUSXhobnZYQWxXd1FSdktIWWVuTmZUT2YydHpTVHN6UnhwU3RM?= =?utf-8?B?aXUxamVReC9zWnJ1ZWxTbU8yUTRNVmR5K2FIN1ZuTWVjVkJKWUFpalJZYlpI?= =?utf-8?B?dFFnME5TeTZhQzBMdjRiMFgzbmZrZzFFR1hVZVRKaHhaT3FZYll1Z0NHRVJm?= =?utf-8?B?ZUFIQ2pvWGUzR20rcHBnVU5QZ21aaGE3eXBqRmx1cm5JWVZjRWRiMWtvczdR?= =?utf-8?B?QTNUT1NydXh1TExKTTNLQT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: bf6ad9f1-c697-449e-cee7-08d8e2ea05c0 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 10:56:42.2698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X9wanGOjm2bRpfzms3kbaAn9KM3l3C3qbg9Nhr99am0qdUPUrukHpXPtTDPESCdkL5YpqqON+fiO2W7dCv9Bxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2841 X-OriginatorOrg: citrix.com Introduce an option to allow selecting a behavior similar to the pre Xen 4.15 one for accesses to MSRs not explicitly handled. Since commit 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly handled by Xen result in the injection of a #GP to the guest. This is a behavior change since previously a #GP was only injected if accessing the MSR on the real hardware would also trigger a #GP, or if the attempted to be set bits wouldn't match the hardware values (for PV). This seems to be problematic for some guests, so introduce an option to fallback to this kind of legacy behavior without leaking the underlying MSR values to the guest. When the option is set, for both PV and HVM don't inject a #GP to the guest on MSR read if reading the underlying MSR doesn't result in a #GP, do the same for writes and simply discard the value to be written on that case. Note that for guests restored or migrated from previous Xen versions the option is enabled by default, in order to keep a compatible MSR behavior. Such compatibility is done at the libxl layer, to avoid higher-level toolstacks from having to know the details about this flag. Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky --- Boris, could you please test with Solaris to see if this fixes the issue? --- Changes since v2: - Apply the option to both HVM and PV guest. - Handle both reads and writes. - Rename to msr_relaxed. - Introduce a Xen commnad line option to set it for dom0. - Set it unconditionally for guests being restored or migrated from previous Xen versions. - Provide the option to dom0. - Attempt at adding the ocaml helpers (build tested only). Changes since v1: - Only apply the option to HVM guests. - Only apply the special handling to MSR reads. - Sanitize the newly introduced flags field. - Print a warning message when the option is used. --- docs/man/xl.cfg.5.pod.in | 19 +++++++++++++++++++ docs/misc/xen-command-line.pandoc | 17 ++++++++++++++++- tools/include/libxl.h | 7 +++++++ tools/libs/light/libxl_arch.h | 5 +++++ tools/libs/light/libxl_arm.c | 6 ++++++ tools/libs/light/libxl_create.c | 7 +++++++ tools/libs/light/libxl_internal.c | 3 +++ tools/libs/light/libxl_types.idl | 2 ++ tools/libs/light/libxl_x86.c | 20 ++++++++++++++++++++ tools/ocaml/libs/xc/xenctrl.ml | 4 ++++ tools/ocaml/libs/xc/xenctrl.mli | 4 ++++ tools/ocaml/libs/xc/xenctrl_stubs.c | 10 ++++++++++ tools/xl/xl_parse.c | 7 +++++++ xen/arch/x86/dom0_build.c | 3 +++ xen/arch/x86/domain.c | 9 +++++++++ xen/arch/x86/hvm/svm/svm.c | 10 ++++++++++ xen/arch/x86/hvm/vmx/vmx.c | 10 ++++++++++ xen/arch/x86/pv/emul-priv-op.c | 10 ++++++++++ xen/arch/x86/setup.c | 1 + xen/include/asm-x86/domain.h | 3 +++ xen/include/asm-x86/setup.h | 1 + xen/include/public/arch-x86/xen.h | 8 ++++++++ 22 files changed, 165 insertions(+), 1 deletion(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 040374dcd6..72b7927483 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -2861,6 +2861,25 @@ No MCA capabilities in above list are enabled. =back +=item B + +Select whether to use a relaxed behavior for accesses to MSRs not explicitly +handled by Xen instead of injecting a #GP to the guest. Such access mode will +force Xen to replicate the behavior from the hardware it's currently running +on in order to decide whether a #GP is injected to the guest for MSR reads. +Note that the guest is never allowed to read the value of unhandled MSRs, this +option only changes whether a #GP might be injected or not. For writes a #GP +won't be injected as long as reading the underlying MSR doesn't result in a +#GP. + +This option will be removed in future releases once we are certain the default +MSR access policy has been properly tested by a wide variety of guests. If you +need to use this option please send a bug report to +xen-devel@lists.xenproject.org with the details of the guests you are running +that require it. + +=back + =back =head1 SEE ALSO diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 4737c92bfe..6cf61a5c57 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -740,7 +740,7 @@ Specify the bit width of the DMA heap. ### dom0 = List of [ pv | pvh, shadow=, verbose=, - cpuid-faulting= ] + cpuid-faulting=, msr-relaxed= ] Applicability: x86 @@ -789,6 +789,21 @@ Controls for how dom0 is constructed on x86 systems. restore the pre-4.13 behaviour. If specifying `no-cpuid-faulting` fixes an issue in dom0, please report a bug. +* msr-relaxed: Select whether to use a relaxed behavior for accesses to MSRs + not explicitly handled by Xen instead of injecting a #GP to dom0. + Such access mode will force Xen to replicate the behavior from the hardware + it's currently running on in order to decide whether a #GP is injected to + dom0 for MSR reads. Note that dom0 is never allowed to read the value of + unhandled MSRs, this option only changes whether a #GP might be injected + or not. For writes a #GP won't be injected as long as reading the + underlying MSR doesn't result in a #GP. + + This option will be removed in future releases once we are certain the + default MSR access policy has been properly tested by a wide variety of + guests. If you need to use this option please send a bug report to + xen-devel@lists.xenproject.org with the details of the guests you are + running that require it. + ### dom0-iommu = List of [ passthrough=, strict=, map-inclusive=, map-reserved=, none ] diff --git a/tools/include/libxl.h b/tools/include/libxl.h index a7b673e89d..ae7fe27c1f 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -495,6 +495,13 @@ */ #define LIBXL_HAVE_VMTRACE_BUF_KB 1 +/* + * LIBXL_HAVE_X86_MSR_RELAXED indicates the toolstack has support for switching + * the MSR access handling in the hypervisor to relaxed mode. This is done by + * setting the libxl_domain_build_info arch_x86.msr_relaxed field. + */ +#define LIBXL_HAVE_X86_MSR_RELAXED 1 + /* * libxl ABI compatibility * diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h index c305d704b1..8527fc5c6c 100644 --- a/tools/libs/light/libxl_arch.h +++ b/tools/libs/light/libxl_arch.h @@ -85,6 +85,11 @@ int libxl__arch_extra_memory(libxl__gc *gc, const libxl_domain_build_info *info, uint64_t *out); +_hidden +void libxl__arch_update_domain_config(libxl__gc *gc, + libxl_domain_config *dst, + const libxl_domain_config *src); + #if defined(__i386__) || defined(__x86_64__) #define LAPIC_BASE_ADDRESS 0xfee00000 diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 5e2a209a8b..e2901f13b7 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -1222,6 +1222,12 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, return rc; } +void libxl__arch_update_domain_config(libxl__gc *gc, + libxl_domain_config *dst, + const libxl_domain_config *src) +{ +} + /* * Local variables: * mode: C diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index 46f68da697..1131b2a733 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -2287,6 +2287,13 @@ int libxl_domain_create_restore(libxl_ctx *ctx, libxl_domain_config *d_config, unset_disk_colo_restore(d_config); } + /* + * When restoring (either from a save file or for a migration domain) set + * the MSR relaxed mode for compatibility with older Xen versions if the + * option is not set as part of the original configuration. + */ + libxl_defbool_setdefault(&d_config->b_info.arch_x86.msr_relaxed, true); + return do_domain_create(ctx, d_config, domid, restore_fd, send_back_fd, params, ao_how, aop_console_how); } diff --git a/tools/libs/light/libxl_internal.c b/tools/libs/light/libxl_internal.c index d93a75533f..86556b6113 100644 --- a/tools/libs/light/libxl_internal.c +++ b/tools/libs/light/libxl_internal.c @@ -16,6 +16,7 @@ #include "libxl_osdeps.h" /* must come before any other headers */ #include "libxl_internal.h" +#include "libxl_arch.h" void libxl__alloc_failed(libxl_ctx *ctx, const char *func, size_t nmemb, size_t size) { @@ -594,6 +595,8 @@ void libxl__update_domain_configuration(libxl__gc *gc, /* video ram */ dst->b_info.video_memkb = src->b_info.video_memkb; + + libxl__arch_update_domain_config(gc, dst, src); } static void ev_slowlock_init_internal(libxl__ev_slowlock *lock, diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 5b85a7419f..f45adddab0 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -644,6 +644,8 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), ("vuart", libxl_vuart_type), ])), + ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), + ])), # Alternate p2m is not bound to any architecture or guest type, as it is # supported by x86 HVM and ARM support is planned. ("altp2m", libxl_altp2m_mode), diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c index 58187ed760..1656f2c730 100644 --- a/tools/libs/light/libxl_x86.c +++ b/tools/libs/light/libxl_x86.c @@ -19,6 +19,10 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, abort(); } + config->arch.domain_flags = 0; + if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed)) + config->arch.domain_flags |= XEN_X86_MSR_RELAXED; + return 0; } @@ -809,6 +813,7 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc, libxl_domain_build_info *b_info) { libxl_defbool_setdefault(&b_info->acpi, true); + libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false); } int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, @@ -851,6 +856,21 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, return rc; } +void libxl__arch_update_domain_config(libxl__gc *gc, + libxl_domain_config *dst, + const libxl_domain_config *src) +{ + /* + * Force MSR relaxed to be set (either to true or false) so it's part of + * the domain configuration when saving or performing a live-migration. + * + * Doing so allows the recovery side to figure out whether the flag should + * be set to true in order to keep backwards compatibility with already + * started domains. + */ + libxl_defbool_setdefault(&dst->b_info.arch_x86.msr_relaxed, + libxl_defbool_val(src->b_info.arch_x86.msr_relaxed)); +} /* * Local variables: diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index a02e26b27f..4789e42e91 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -48,9 +48,13 @@ type x86_arch_emulation_flags = | X86_EMU_USE_PIRQ | X86_EMU_VPCI +type x86_arch_domain_flags = + | X86_MSR_RELAXED + type xen_x86_arch_domainconfig = { emulation_flags: x86_arch_emulation_flags list; + domain_flags: x86_arch_domain_flags list; } type arch_domainconfig = diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index d2a312e273..566c12cb26 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -42,8 +42,12 @@ type x86_arch_emulation_flags = | X86_EMU_USE_PIRQ | X86_EMU_VPCI +type x86_arch_domain_flags = + | X86_MSR_RELAXED + type xen_x86_arch_domainconfig = { emulation_flags: x86_arch_emulation_flags list; + domain_flags: x86_arch_domain_flags list; } type arch_domainconfig = diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index 9a8dbe5579..2f658a6418 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -233,6 +233,16 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config #undef VAL_EMUL_FLAGS +#define VAL_DOMAIN_FLAGS Field(arch_domconfig, 1) + + cfg.arch.domain_flags = ocaml_list_to_c_bitmap + /* ! x86_arch_domain_flags X86_ none */ + /* ! XEN_X86_ XEN_X86_MSR_RELAXED all */ + + (VAL_DOMAIN_FLAGS); + +#undef VAL_DOMAIN_FLAGS + #else caml_failwith("Unhandled: x86"); #endif diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 1893cfc086..9fb0791429 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2741,6 +2741,13 @@ skip_usbdev: xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat", &c_info->xend_suspend_evtchn_compat, 0); + if (!xlu_cfg_get_defbool(config, "msr_relaxed", + &b_info->arch_x86.msr_relaxed, 0)) + fprintf(stderr, + "WARNING: msr_relaxed will be removed in future versions.\n" + "If it fixes an issue you are having please report to " + "xen-devel@lists.xenproject.org.\n"); + xlu_cfg_destroy(config); } diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 0ce29e91a3..74b443e509 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -256,6 +256,7 @@ bool __initdata opt_dom0_shadow; #endif bool __initdata opt_dom0_pvh = !IS_ENABLED(CONFIG_PV); bool __initdata opt_dom0_verbose = IS_ENABLED(CONFIG_VERBOSE_DEBUG); +bool __initdata opt_dom0_msr_relaxed; static int __init parse_dom0_param(const char *s) { @@ -282,6 +283,8 @@ static int __init parse_dom0_param(const char *s) else if ( IS_ENABLED(CONFIG_PV) && (val = parse_boolean("cpuid-faulting", s, ss)) >= 0 ) opt_dom0_cpuid_faulting = val; + else if ( (val = parse_boolean("msr-relaxed", s, ss)) >= 0 ) + opt_dom0_msr_relaxed = val; else rc = -EINVAL; diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 5e3c94d3fa..86e5b506ce 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -683,6 +683,13 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) } } + if ( config->arch.domain_flags & ~XEN_X86_MSR_RELAXED ) + { + dprintk(XENLOG_INFO, "Invalid arch domain flags %#x\n", + config->arch.domain_flags); + return -EINVAL; + } + return 0; } @@ -852,6 +859,8 @@ int arch_domain_create(struct domain *d, domain_cpu_policy_changed(d); + d->arch.msr_relaxed = config->arch.domain_flags & XEN_X86_MSR_RELAXED; + return 0; fail: diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index b819897a4a..4585efe1f8 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -1795,6 +1795,7 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) const struct domain *d = v->domain; struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; const struct nestedsvm *nsvm = &vcpu_nestedsvm(v); + uint64_t tmp; switch ( msr ) { @@ -1965,6 +1966,12 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) break; default: + if ( d->arch.msr_relaxed && !rdmsr_safe(msr, tmp) ) + { + *msr_content = 0; + break; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", msr); goto gpf; } @@ -2151,6 +2158,9 @@ static int svm_msr_write_intercept(unsigned int msr, uint64_t msr_content) break; default: + if ( d->arch.msr_relaxed && !rdmsr_safe(msr, msr_content) ) + break; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", msr, msr_content); diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index bfea1b0f8a..b52824677e 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3123,6 +3123,7 @@ static int is_last_branch_msr(u32 ecx) static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content) { struct vcpu *curr = current; + uint64_t tmp; HVM_DBG_LOG(DBG_LEVEL_MSR, "ecx=%#x", msr); @@ -3204,6 +3205,12 @@ static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content) break; } + if ( curr->domain->arch.msr_relaxed && !rdmsr_safe(msr, tmp) ) + { + *msr_content = 0; + break; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", msr); goto gp_fault; } @@ -3505,6 +3512,9 @@ static int vmx_msr_write_intercept(unsigned int msr, uint64_t msr_content) is_last_branch_msr(msr) ) break; + if ( v->domain->arch.msr_relaxed && !rdmsr_safe(msr, msr_content) ) + break; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", msr, msr_content); diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c index e5a22b9347..74e71403ff 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -875,6 +875,7 @@ static int read_msr(unsigned int reg, uint64_t *val, const struct domain *currd = curr->domain; const struct cpuid_policy *cp = currd->arch.cpuid; bool vpmu_msr = false; + uint64_t tmp; int ret; if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) @@ -986,6 +987,12 @@ static int read_msr(unsigned int reg, uint64_t *val, } /* fall through */ default: + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, tmp) ) + { + *val = 0; + return X86EMUL_OKAY; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); break; @@ -1148,6 +1155,9 @@ static int write_msr(unsigned int reg, uint64_t val, } /* fall through */ default: + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, val) ) + return X86EMUL_OKAY; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", reg, val); diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 23bbb6e8c1..d217c223b0 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -749,6 +749,7 @@ static struct domain *__init create_dom0(const module_t *image, .max_grant_frames = -1, .max_maptrack_frames = -1, .max_vcpus = dom0_max_vcpus(), + .arch.domain_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, }; struct domain *d; char *cmdline; diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h index 3900d7b48b..7213d184b0 100644 --- a/xen/include/asm-x86/domain.h +++ b/xen/include/asm-x86/domain.h @@ -437,6 +437,9 @@ struct arch_domain /* Mem_access emulation control */ bool_t mem_access_emulate_each_rep; + /* Don't unconditionally inject #GP for unhandled MSRs. */ + bool msr_relaxed; + /* Emulated devices enabled bitmap. */ uint32_t emulation_flags; } __cacheline_aligned; diff --git a/xen/include/asm-x86/setup.h b/xen/include/asm-x86/setup.h index 642a5e8460..24be46115d 100644 --- a/xen/include/asm-x86/setup.h +++ b/xen/include/asm-x86/setup.h @@ -65,6 +65,7 @@ extern bool opt_dom0_shadow; extern bool opt_dom0_pvh; extern bool opt_dom0_verbose; extern bool opt_dom0_cpuid_faulting; +extern bool opt_dom0_msr_relaxed; #define max_init_domid (0) diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h index 629cb2ba40..f9d0e33b94 100644 --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -304,6 +304,14 @@ struct xen_arch_domainconfig { XEN_X86_EMU_PIT | XEN_X86_EMU_USE_PIRQ |\ XEN_X86_EMU_VPCI) uint32_t emulation_flags; + +/* + * Select whether to use a relaxed behavior for accesses to MSRs not explicitly + * handled by Xen instead of injecting a #GP to the guest. Note this option + * doesn't allow the guest to read or write to the underlying MSR. + */ +#define XEN_X86_MSR_RELAXED (1u << 0) + uint32_t domain_flags; }; /* Location of online VCPU bitmap. */ -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 10:58:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 10:58:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95330.179942 (Exim 4.92) (envelope-from ) id 1lJa3y-0004OO-9X; Tue, 09 Mar 2021 10:58:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95330.179942; Tue, 09 Mar 2021 10:58:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJa3y-0004OG-6G; Tue, 09 Mar 2021 10:58:06 +0000 Received: by outflank-mailman (input) for mailman id 95330; Tue, 09 Mar 2021 10:58:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJa3w-0004O6-LQ; Tue, 09 Mar 2021 10:58:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJa3w-0005Nj-DP; Tue, 09 Mar 2021 10:58:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJa3w-0003hu-39; Tue, 09 Mar 2021 10:58:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJa3w-0000nW-2b; Tue, 09 Mar 2021 10:58:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=D/BwXxV6u/RjtSw4GFGhHO215DNTk5OyN3puV6ELHR4=; b=NAue5nXeXRpgLICsp1pZobjjVC TX3ZYDg8ZS1lPZuhMpRQv/2NTdhmjr9QhRXWcthU6xfyyjPwAvL7g1DELDXF92qdtT+nH/fQLedwK DMfZtBVa9a8Vg5lGOb4b/A+5620Uf8jk68IWCohJ4dZT5r6FdXJ/sd0p29HxhVFG/LDw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159881: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=144c79ef33536b4ecb4951e07dbc1f2b7fa99d32 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Tue, 09 Mar 2021 10:58:04 +0000 flight 159881 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159881/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: linux 144c79ef33536b4ecb4951e07dbc1f2b7fa99d32 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 220 days Failing since 152366 2020-08-01 20:49:34 Z 219 days 380 attempts Testing same since 159870 2021-03-08 09:51:12 Z 1 days 2 attempts ------------------------------------------------------------ 5158 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1278139 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 09 11:04:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 11:04:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95339.179958 (Exim 4.92) (envelope-from ) id 1lJaAE-0005N4-3V; Tue, 09 Mar 2021 11:04:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95339.179958; Tue, 09 Mar 2021 11:04:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJaAD-0005Mx-W4; Tue, 09 Mar 2021 11:04:33 +0000 Received: by outflank-mailman (input) for mailman id 95339; Tue, 09 Mar 2021 11:04:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJaAB-0005Mn-QB for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 11:04:31 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 28e0eb0f-9480-4ced-815b-cb0b29b975ae; Tue, 09 Mar 2021 11:04:30 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 66B8BAB8C; Tue, 9 Mar 2021 11:04:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28e0eb0f-9480-4ced-815b-cb0b29b975ae X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615287869; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bWIGzd4e8jN/Sk9xCn2VfslJvP8ZvleK4Z70J4q4SGM=; b=AjqsHZRJW9dYQMq3E+P6+n81jNhXH06Hz5Ux7fwDw85BPm2vZeFowbyEKbZX460y1XCYhO qFQnOIdaFHs2BXjReQsxEeo9BvFKDGDIzpnmf4UvqvlKNg87NZIYxEUH6S+MLvc2A4KhA8 0BeEbHytBYFcN4fO1z2VpMzxPf+F8rg= Subject: Re: [PATCH] xen/arm: Use register_t type in cpuinfo entries To: Julien Grall , Bertrand Marquis Cc: Stefano Stabellini , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <712d7c6a-3ace-a6b7-a188-faeb4f1258d3@xen.org> From: Jan Beulich Message-ID: <5bb482ff-a689-67e3-1bc7-30b9bf24034e@suse.com> Date: Tue, 9 Mar 2021 12:04:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <712d7c6a-3ace-a6b7-a188-faeb4f1258d3@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 20:48, Julien Grall wrote: > On 08/03/2021 17:18, Bertrand Marquis wrote: >> --- a/xen/arch/arm/smpboot.c >> +++ b/xen/arch/arm/smpboot.c >> @@ -321,7 +321,8 @@ void start_secondary(void) >> if ( !opt_hmp_unsafe && >> current_cpu_data.midr.bits != boot_cpu_data.midr.bits ) >> { >> - printk(XENLOG_ERR "CPU%u MIDR (0x%x) does not match boot CPU MIDR (0x%x),\n" >> + printk(XENLOG_ERR "CPU%u MIDR (0x%"PRIregister") does not match boot " >> + "CPU MIDR (0x%"PRIregister"),\n" > > For printk messages, we don't tend to split it like that (even for more > than 80 characters one). Instead, the preferred approach is: > > printk(XENLOG_ERR > "line 1\n" > "line 2\n") Except of course you want to repeat XENLOG_ERR for the 2nd line. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 09 11:07:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 11:07:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95342.179970 (Exim 4.92) (envelope-from ) id 1lJaCl-0005W8-Ih; Tue, 09 Mar 2021 11:07:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95342.179970; Tue, 09 Mar 2021 11:07:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJaCl-0005W1-FT; Tue, 09 Mar 2021 11:07:11 +0000 Received: by outflank-mailman (input) for mailman id 95342; Tue, 09 Mar 2021 11:07:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJaCk-0005Vw-Uk for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 11:07:11 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f85e8eb6-f745-4797-b504-afb4fc1419cb; Tue, 09 Mar 2021 11:07:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f85e8eb6-f745-4797-b504-afb4fc1419cb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615288029; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=z9DS7br3KZq6yoL91idIK7t+6tIwKEkXKQMms9ptZ80=; b=dmbJ3zNB55T3y0QI9ssjrpJ4UmLKBNETgbciLO5uphNFykbBo9RXiWgq B40Q1YtxkvqJ/KOZzbTeqmOROhazKatM2O3hLo4hz8zcelyia9C/7utML Ym9xCMJVaYARjPzIn+O2GIxYkKMsBAxfuwKXZsGIWGhz7szLZ5hBrFyYy Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: U5cAvLhxQ5FO6uggSTdwWhc7gTiWdmNAvhXl6nrD547VN84oe5r+H6wjnSB17wWbKf5raBqY3Z vzCYNiWyuFVJVucydt2cqkr5bNjAo4ecM9YyNaF6s0/wVVDmAuiUCUhFs+iz+4/DPQK7Fk1669 hsRUM+buPYQ4RT6uPppG2UAph5Um8BDTxPlngI1eqgIlI1tyyChIGLOOSs28q4tXnoneK7GQIJ rVp1SAkrxEgnYigvbZ0bHT3Kw+IVFlrHDcn1prpiqWXa7aL1zgMiIboQ6x1ei8VJYNL+GzucSu yNo= X-SBRS: 5.2 X-MesageID: 39215643 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,234,1610427600"; d="scan'208";a="39215643" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Px8otZoAGE92qPllBQYOM946/pan7bXs7sMQj3jXOn+ltJp4IZeYog6l1zgHR9wD88/5x52hFERtBoeBTYFou/gLhC1fJzMv2yfD1gFzLAABhBYc4k0QMXDf6xud6VjVl+d+cc1Cs3Lcne24dJBWKO+c7ruRb6x8C/PtyLoVbuBQQsM5ZJvXwE8ZFIsHtfXC2OZh7iAdIboCgRWbjVfttFgJ+nnf1UyRTF77Sgk9hlq59jlyXeOCcnHzaM/p6Z4Ed06QGOq1vBaKzNyvnSbZhR5isVm7P0lrvz+P9MnXoj2XrL6JLzcmxrsBUpqw8zaedzQdC9ibgmy3HObEAHB9XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=931RgjNXrlMZ53cEU4zSTn+6C3H8Es50mRbHwSZQCSg=; b=DsJx/z3mVJvlaM+0bKLQO2hOI32w3gBAIyBc2GWbQhYepxE+bSdMRpT4XvTaxpY1hUKuTmDj21hOxuPEoFm4PrV35tJDfgAEHdPHnQhYp4/5L3msXFT+hkkPCPx30HjL9zTavTUuH1VPziFITGt+cwrJIv6JXLmVMlMkkHXX4fJdQvuk7ExMWDVOFRz6vFmUxKxWX7Kjkemnse3trvPlf+35ml6WTjs8fUdOXEi7QNglLJYM3NAYYs+xWdR/nw0NBVRZPazK/LqjFILChZstQnpZt8dfzR4Z3ARwNqLw6K6j+EtNU81ODUwoOAiXJtWVcshQzCzrWECSP8eMJsRpTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=931RgjNXrlMZ53cEU4zSTn+6C3H8Es50mRbHwSZQCSg=; b=Nk4HeO7xmBYfcV7gRczmJp6VmcMFlB8bnkF/14ppITaQHAwCRQNVmDGsAfqzdvYLdGBN38eCR0DaK/o7bIWWuodX5eCHAwAtqD8KAW+RQKlMB/J2wCK28YPrmzc1tMY8n6SN2JLvmAfoyQY125WgUSpNrb2tormzkt8iB4lUZtg= From: Christian Lindig To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Ian Jackson , Wei Liu , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Anthony Perard , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection Thread-Topic: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection Thread-Index: AQHXFNLk9g6CO5afwkSJp733cbqj36p7fplf Date: Tue, 9 Mar 2021 11:06:52 +0000 Message-ID: References: <20210309105634.7200-1-roger.pau@citrix.com> In-Reply-To: <20210309105634.7200-1-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1f8238a-117f-4e69-538d-08d8e2eb71fc x-ms-traffictypediagnostic: MWHPR03MB2896: x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4h4lpWA2BTIHsg66Z/xQHeThVh1Pxjw4rJ3DWDDFK2zHOdWdK3H899kIbEjrJZXtTRQMOBoRgRBPGwAYvuWHKDpTfJUhk7lZwkIgVQMzh0EBWly20pr1XG3pYjN/p4O50M8e7IkKDze6hAY3WKZo2/YpdePlRDo/cLMqFZPkr5Fm+xvTC1O1Wz8DMCsgYCMdCMItWEj8JWSizoS7m3MUvzZKtBaxAeaS8UtVsMdELlDb+I1Bc0aZY9+PHoXb+M5gH0YjzeHRB5X+5MsFhyCFeXvgAeYXQU+tVkE7/46ZFdU58BFpJDFgVfqpisR36OrPfXce/tZKZ5kFZFZjcIfRtBrKxyBtrjM3azxLA5GfgX4wEuojTn9QWQAJhsVAAIwETfrTVJVEQGK/OCFipOUjcB06WbCNP/fux/qc2kfhCYsGObS8tsSLDkPpCVrOHWYOWJHYJv4y86wsaimCSa7KEwMnsNjo9rZuD8jjD0xeywckV0XqDG7sJKpCKrVWEA9/I9Rwe1xJB8sFJnV5WFO+qw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR03MB2445.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(136003)(39860400002)(396003)(346002)(55016002)(71200400001)(478600001)(33656002)(26005)(8936002)(83380400001)(8676002)(186003)(4326008)(52536014)(9686003)(7696005)(7416002)(5660300002)(44832011)(66446008)(66556008)(54906003)(2906002)(76116006)(91956017)(64756008)(66946007)(110136005)(66476007)(53546011)(316002)(6506007)(86362001)(30864003)(579004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?yYMESr9V8shyoWZBdzWx3Yn2qkMGT7FonQXDvFkw5CV3Lw7ZNaf5H6oa5E?= =?iso-8859-1?Q?BkzpBJWcqnFHikKkig5+pYTtnLnqfX3T2HDMU3L/1jz/yTzmUuBUIQAF7O?= =?iso-8859-1?Q?uARvsrR3bdc3Q9EbgJHzetilU9EaJTmWXP+5P2y7tyHVHcNIThGl7weJ+3?= =?iso-8859-1?Q?KYfPlCeokhuB5o6jZ14r+ha1FM0xypIFFbBt2ttzC2GZlu5kP+esvDwBT+?= =?iso-8859-1?Q?iPboQKzQaQQcjpm3snwBRou0uaRsaMTHuqONCGJkUHxPC/pIxP3k0C32AQ?= =?iso-8859-1?Q?6mL2aAf6IuXZi3bs0ufOZs2j9gPwSOgzEmMW3Bh+ABWIt1mNYeApEem3/J?= =?iso-8859-1?Q?QDGYh08Ws/PknkJ9UsdwS1ojex2Sm3N2dnRBxwPvbal9wUlLcdtJB1AVk7?= =?iso-8859-1?Q?tmSpTiPvZYSu7u4agiPH0NW51ps1PZ8yDfOI67xtaGM1NPgW161cn/JJU6?= =?iso-8859-1?Q?YqhbrM2LgjS7wO0PFoCO5wXr2AUv2WLqB1YdbrDpUZ2kIbokxufaC/GcEE?= =?iso-8859-1?Q?ImpqRnrhbfU4A/RA8V+p0sPN+LpdZET6Almb3JA8WEwO30R0xMK+/itVUm?= =?iso-8859-1?Q?vQv6Atbu4cEaeUlU156FJyEAohXsro1kIUw3OUnkIiqQHwyo+kYTzrvmS2?= =?iso-8859-1?Q?SNiGkbxGQy3p9k6uH1m5iJdag4Hu2cPz3q1c+dxXhio9SE2dDYML04iGu1?= =?iso-8859-1?Q?PGR84QcA/VGz6LT6g+NE9qxtn68CSYDJLGkJHmY//ScLTdE1ghZfAdrgqe?= =?iso-8859-1?Q?s1o9RjIHVVXaC3r+miZf9O8LgFtblWAoAyZkPxJxtYAkhxRzF3Y9RLgVod?= =?iso-8859-1?Q?JrGMHE7lAYxSMIncsgQDUtD30ctAkeWs0YQ0DDaIugySibpzG0zybHokP3?= =?iso-8859-1?Q?FbOjX0cAZ8w8R8AE8RYwtM+JuOpSMrSQROo+uzgVqiFy1h6j6O0P27A++W?= =?iso-8859-1?Q?oODjdpTP6Ush728GWKI9e0P0fOyFjWgzh/KCnSDVVDQPAHch+tXmy8bFDy?= =?iso-8859-1?Q?UjeHAODt+IctS6MGB/S/SSeWYYFi6DZAIyotOVzGLzXXZJr6tcLvRgyuw2?= =?iso-8859-1?Q?nHIZzfJlYMXAzARTK3uKG07dHFkvBss0bpwfni+ivVM4geXAfujkkFgUu7?= =?iso-8859-1?Q?2gKtuk1+hG68CE2/5kR8jaDE2BkZD++foe9hcoar4VXgiIWznzE0tk2Rtw?= =?iso-8859-1?Q?fi51TK5x+KxjAw/rxtHy66A+DFRN2smvh3ck1/qwKR7HGQCdqfhNzc9IaH?= =?iso-8859-1?Q?Mzma6YVGKaRCRxCQ78yLZYLj8AJ9Vc7hdli80Q7sqq1nx9QsnO5xarLRag?= =?iso-8859-1?Q?ExDD/4jBVF8Vz8mX/E/jgIkkopOowRQgILi5MpD6gqygV8E=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR03MB2445.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1f8238a-117f-4e69-538d-08d8e2eb71fc X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2021 11:06:52.8759 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7QTkug2uZx2yP1AYEMMJQzZho3nC6ttPnGFKaRuOZ9x+pFAfaN4bLexEAUV+JZgnvlk+Sp28o0XmZCj13wMuO9dN9JZkBtktUvz0k8kykTI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2896 X-OriginatorOrg: citrix.com The impact on the OCaml side is minimal and looks good to me. Acked-by: Christian Lindig ________________________________________ From: Roger Pau Monne Sent: 09 March 2021 10:56 To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne; Ian Jackson; Wei Liu; Andrew Cooper; George Dunlap; Ja= n Beulich; Julien Grall; Stefano Stabellini; Anthony Perard; Christian Lind= ig; David Scott; Jun Nakajima; Kevin Tian; Boris Ostrovsky Subject: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MS= R behavior selection Introduce an option to allow selecting a behavior similar to the pre Xen 4.15 one for accesses to MSRs not explicitly handled. Since commit 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly handled by Xen result in the injection of a #GP to the guest. This is a behavior change since previously a #GP was only injected if accessing the MSR on the real hardware would also trigger a #GP, or if the attempted to be set bits wouldn't match the hardware values (for PV). This seems to be problematic for some guests, so introduce an option to fallback to this kind of legacy behavior without leaking the underlying MSR values to the guest. When the option is set, for both PV and HVM don't inject a #GP to the guest on MSR read if reading the underlying MSR doesn't result in a #GP, do the same for writes and simply discard the value to be written on that case. Note that for guests restored or migrated from previous Xen versions the option is enabled by default, in order to keep a compatible MSR behavior. Such compatibility is done at the libxl layer, to avoid higher-level toolstacks from having to know the details about this flag. Signed-off-by: Roger Pau Monn=E9 --- Cc: Boris Ostrovsky --- Boris, could you please test with Solaris to see if this fixes the issue? --- Changes since v2: - Apply the option to both HVM and PV guest. - Handle both reads and writes. - Rename to msr_relaxed. - Introduce a Xen commnad line option to set it for dom0. - Set it unconditionally for guests being restored or migrated from previous Xen versions. - Provide the option to dom0. - Attempt at adding the ocaml helpers (build tested only). Changes since v1: - Only apply the option to HVM guests. - Only apply the special handling to MSR reads. - Sanitize the newly introduced flags field. - Print a warning message when the option is used. --- docs/man/xl.cfg.5.pod.in | 19 +++++++++++++++++++ docs/misc/xen-command-line.pandoc | 17 ++++++++++++++++- tools/include/libxl.h | 7 +++++++ tools/libs/light/libxl_arch.h | 5 +++++ tools/libs/light/libxl_arm.c | 6 ++++++ tools/libs/light/libxl_create.c | 7 +++++++ tools/libs/light/libxl_internal.c | 3 +++ tools/libs/light/libxl_types.idl | 2 ++ tools/libs/light/libxl_x86.c | 20 ++++++++++++++++++++ tools/ocaml/libs/xc/xenctrl.ml | 4 ++++ tools/ocaml/libs/xc/xenctrl.mli | 4 ++++ tools/ocaml/libs/xc/xenctrl_stubs.c | 10 ++++++++++ tools/xl/xl_parse.c | 7 +++++++ xen/arch/x86/dom0_build.c | 3 +++ xen/arch/x86/domain.c | 9 +++++++++ xen/arch/x86/hvm/svm/svm.c | 10 ++++++++++ xen/arch/x86/hvm/vmx/vmx.c | 10 ++++++++++ xen/arch/x86/pv/emul-priv-op.c | 10 ++++++++++ xen/arch/x86/setup.c | 1 + xen/include/asm-x86/domain.h | 3 +++ xen/include/asm-x86/setup.h | 1 + xen/include/public/arch-x86/xen.h | 8 ++++++++ 22 files changed, 165 insertions(+), 1 deletion(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 040374dcd6..72b7927483 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -2861,6 +2861,25 @@ No MCA capabilities in above list are enabled. =3Dback +=3Ditem B + +Select whether to use a relaxed behavior for accesses to MSRs not explicit= ly +handled by Xen instead of injecting a #GP to the guest. Such access mode = will +force Xen to replicate the behavior from the hardware it's currently runni= ng +on in order to decide whether a #GP is injected to the guest for MSR reads= . +Note that the guest is never allowed to read the value of unhandled MSRs, = this +option only changes whether a #GP might be injected or not. For writes a = #GP +won't be injected as long as reading the underlying MSR doesn't result in = a +#GP. + +This option will be removed in future releases once we are certain the def= ault +MSR access policy has been properly tested by a wide variety of guests. I= f you +need to use this option please send a bug report to +xen-devel@lists.xenproject.org with the details of the guests you are runn= ing +that require it. + +=3Dback + =3Dback =3Dhead1 SEE ALSO diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line= .pandoc index 4737c92bfe..6cf61a5c57 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -740,7 +740,7 @@ Specify the bit width of the DMA heap. ### dom0 =3D List of [ pv | pvh, shadow=3D, verbose=3D, - cpuid-faulting=3D ] + cpuid-faulting=3D, msr-relaxed=3D ] Applicability: x86 @@ -789,6 +789,21 @@ Controls for how dom0 is constructed on x86 systems. restore the pre-4.13 behaviour. If specifying `no-cpuid-faulting` fix= es an issue in dom0, please report a bug. +* msr-relaxed: Select whether to use a relaxed behavior for accesses to = MSRs + not explicitly handled by Xen instead of injecting a #GP to dom0. + Such access mode will force Xen to replicate the behavior from the har= dware + it's currently running on in order to decide whether a #GP is injected= to + dom0 for MSR reads. Note that dom0 is never allowed to read the value= of + unhandled MSRs, this option only changes whether a #GP might be inject= ed + or not. For writes a #GP won't be injected as long as reading the + underlying MSR doesn't result in a #GP. + + This option will be removed in future releases once we are certain the + default MSR access policy has been properly tested by a wide variety o= f + guests. If you need to use this option please send a bug report to + xen-devel@lists.xenproject.org with the details of the guests you are + running that require it. + ### dom0-iommu =3D List of [ passthrough=3D, strict=3D, map-inclusive=3D<= bool>, map-reserved=3D, none ] diff --git a/tools/include/libxl.h b/tools/include/libxl.h index a7b673e89d..ae7fe27c1f 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -495,6 +495,13 @@ */ #define LIBXL_HAVE_VMTRACE_BUF_KB 1 +/* + * LIBXL_HAVE_X86_MSR_RELAXED indicates the toolstack has support for swit= ching + * the MSR access handling in the hypervisor to relaxed mode. This is done= by + * setting the libxl_domain_build_info arch_x86.msr_relaxed field. + */ +#define LIBXL_HAVE_X86_MSR_RELAXED 1 + /* * libxl ABI compatibility * diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h index c305d704b1..8527fc5c6c 100644 --- a/tools/libs/light/libxl_arch.h +++ b/tools/libs/light/libxl_arch.h @@ -85,6 +85,11 @@ int libxl__arch_extra_memory(libxl__gc *gc, const libxl_domain_build_info *info, uint64_t *out); +_hidden +void libxl__arch_update_domain_config(libxl__gc *gc, + libxl_domain_config *dst, + const libxl_domain_config *src); + #if defined(__i386__) || defined(__x86_64__) #define LAPIC_BASE_ADDRESS 0xfee00000 diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 5e2a209a8b..e2901f13b7 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -1222,6 +1222,12 @@ int libxl__arch_passthrough_mode_setdefault(libxl__g= c *gc, return rc; } +void libxl__arch_update_domain_config(libxl__gc *gc, + libxl_domain_config *dst, + const libxl_domain_config *src) +{ +} + /* * Local variables: * mode: C diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_creat= e.c index 46f68da697..1131b2a733 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -2287,6 +2287,13 @@ int libxl_domain_create_restore(libxl_ctx *ctx, libx= l_domain_config *d_config, unset_disk_colo_restore(d_config); } + /* + * When restoring (either from a save file or for a migration domain) = set + * the MSR relaxed mode for compatibility with older Xen versions if t= he + * option is not set as part of the original configuration. + */ + libxl_defbool_setdefault(&d_config->b_info.arch_x86.msr_relaxed, true)= ; + return do_domain_create(ctx, d_config, domid, restore_fd, send_back_fd= , params, ao_how, aop_console_how); } diff --git a/tools/libs/light/libxl_internal.c b/tools/libs/light/libxl_int= ernal.c index d93a75533f..86556b6113 100644 --- a/tools/libs/light/libxl_internal.c +++ b/tools/libs/light/libxl_internal.c @@ -16,6 +16,7 @@ #include "libxl_osdeps.h" /* must come before any other headers */ #include "libxl_internal.h" +#include "libxl_arch.h" void libxl__alloc_failed(libxl_ctx *ctx, const char *func, size_t nmemb, size_t size) { @@ -594,6 +595,8 @@ void libxl__update_domain_configuration(libxl__gc *gc, /* video ram */ dst->b_info.video_memkb =3D src->b_info.video_memkb; + + libxl__arch_update_domain_config(gc, dst, src); } static void ev_slowlock_init_internal(libxl__ev_slowlock *lock, diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_type= s.idl index 5b85a7419f..f45adddab0 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -644,6 +644,8 @@ libxl_domain_build_info =3D Struct("domain_build_info",= [ ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), ("vuart", libxl_vuart_type), ])), + ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), + ])), # Alternate p2m is not bound to any architecture or guest type, as it = is # supported by x86 HVM and ARM support is planned. ("altp2m", libxl_altp2m_mode), diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c index 58187ed760..1656f2c730 100644 --- a/tools/libs/light/libxl_x86.c +++ b/tools/libs/light/libxl_x86.c @@ -19,6 +19,10 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, abort(); } + config->arch.domain_flags =3D 0; + if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed)) + config->arch.domain_flags |=3D XEN_X86_MSR_RELAXED; + return 0; } @@ -809,6 +813,7 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc= *gc, libxl_domain_build_info *b_i= nfo) { libxl_defbool_setdefault(&b_info->acpi, true); + libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false); } int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, @@ -851,6 +856,21 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc = *gc, return rc; } +void libxl__arch_update_domain_config(libxl__gc *gc, + libxl_domain_config *dst, + const libxl_domain_config *src) +{ + /* + * Force MSR relaxed to be set (either to true or false) so it's part = of + * the domain configuration when saving or performing a live-migration= . + * + * Doing so allows the recovery side to figure out whether the flag sh= ould + * be set to true in order to keep backwards compatibility with alread= y + * started domains. + */ + libxl_defbool_setdefault(&dst->b_info.arch_x86.msr_relaxed, + libxl_defbool_val(src->b_info.arch_x86.msr_relaxed)); +} /* * Local variables: diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.m= l index a02e26b27f..4789e42e91 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -48,9 +48,13 @@ type x86_arch_emulation_flags =3D | X86_EMU_USE_PIRQ | X86_EMU_VPCI +type x86_arch_domain_flags =3D + | X86_MSR_RELAXED + type xen_x86_arch_domainconfig =3D { emulation_flags: x86_arch_emulation_flags list; + domain_flags: x86_arch_domain_flags list; } type arch_domainconfig =3D diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.= mli index d2a312e273..566c12cb26 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -42,8 +42,12 @@ type x86_arch_emulation_flags =3D | X86_EMU_USE_PIRQ | X86_EMU_VPCI +type x86_arch_domain_flags =3D + | X86_MSR_RELAXED + type xen_x86_arch_domainconfig =3D { emulation_flags: x86_arch_emulation_flags list; + domain_flags: x86_arch_domain_flags list; } type arch_domainconfig =3D diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenc= trl_stubs.c index 9a8dbe5579..2f658a6418 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -233,6 +233,16 @@ CAMLprim value stub_xc_domain_create(value xch, value = wanted_domid, value config #undef VAL_EMUL_FLAGS +#define VAL_DOMAIN_FLAGS Field(arch_domconfig, 1) + + cfg.arch.domain_flags =3D ocaml_list_to_c_bitmap + /* ! x86_arch_domain_flags X86_ none */ + /* ! XEN_X86_ XEN_X86_MSR_RELAXED all */ + + (VAL_DOMAIN_FLAGS); + +#undef VAL_DOMAIN_FLAGS + #else caml_failwith("Unhandled: x86"); #endif diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 1893cfc086..9fb0791429 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2741,6 +2741,13 @@ skip_usbdev: xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat", &c_info->xend_suspend_evtchn_compat, 0); + if (!xlu_cfg_get_defbool(config, "msr_relaxed", + &b_info->arch_x86.msr_relaxed, 0)) + fprintf(stderr, + "WARNING: msr_relaxed will be removed in future versio= ns.\n" + "If it fixes an issue you are having please report to = " + "xen-devel@lists.xenproject.org.\n"); + xlu_cfg_destroy(config); } diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 0ce29e91a3..74b443e509 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -256,6 +256,7 @@ bool __initdata opt_dom0_shadow; #endif bool __initdata opt_dom0_pvh =3D !IS_ENABLED(CONFIG_PV); bool __initdata opt_dom0_verbose =3D IS_ENABLED(CONFIG_VERBOSE_DEBUG); +bool __initdata opt_dom0_msr_relaxed; static int __init parse_dom0_param(const char *s) { @@ -282,6 +283,8 @@ static int __init parse_dom0_param(const char *s) else if ( IS_ENABLED(CONFIG_PV) && (val =3D parse_boolean("cpuid-faulting", s, ss)) >=3D 0 = ) opt_dom0_cpuid_faulting =3D val; + else if ( (val =3D parse_boolean("msr-relaxed", s, ss)) >=3D 0 ) + opt_dom0_msr_relaxed =3D val; else rc =3D -EINVAL; diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 5e3c94d3fa..86e5b506ce 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -683,6 +683,13 @@ int arch_sanitise_domain_config(struct xen_domctl_crea= tedomain *config) } } + if ( config->arch.domain_flags & ~XEN_X86_MSR_RELAXED ) + { + dprintk(XENLOG_INFO, "Invalid arch domain flags %#x\n", + config->arch.domain_flags); + return -EINVAL; + } + return 0; } @@ -852,6 +859,8 @@ int arch_domain_create(struct domain *d, domain_cpu_policy_changed(d); + d->arch.msr_relaxed =3D config->arch.domain_flags & XEN_X86_MSR_RELAXE= D; + return 0; fail: diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index b819897a4a..4585efe1f8 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -1795,6 +1795,7 @@ static int svm_msr_read_intercept(unsigned int msr, u= int64_t *msr_content) const struct domain *d =3D v->domain; struct vmcb_struct *vmcb =3D v->arch.hvm.svm.vmcb; const struct nestedsvm *nsvm =3D &vcpu_nestedsvm(v); + uint64_t tmp; switch ( msr ) { @@ -1965,6 +1966,12 @@ static int svm_msr_read_intercept(unsigned int msr, = uint64_t *msr_content) break; default: + if ( d->arch.msr_relaxed && !rdmsr_safe(msr, tmp) ) + { + *msr_content =3D 0; + break; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", msr); goto gpf; } @@ -2151,6 +2158,9 @@ static int svm_msr_write_intercept(unsigned int msr, = uint64_t msr_content) break; default: + if ( d->arch.msr_relaxed && !rdmsr_safe(msr, msr_content) ) + break; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", msr, msr_content); diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index bfea1b0f8a..b52824677e 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3123,6 +3123,7 @@ static int is_last_branch_msr(u32 ecx) static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content) { struct vcpu *curr =3D current; + uint64_t tmp; HVM_DBG_LOG(DBG_LEVEL_MSR, "ecx=3D%#x", msr); @@ -3204,6 +3205,12 @@ static int vmx_msr_read_intercept(unsigned int msr, = uint64_t *msr_content) break; } + if ( curr->domain->arch.msr_relaxed && !rdmsr_safe(msr, tmp) ) + { + *msr_content =3D 0; + break; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", msr); goto gp_fault; } @@ -3505,6 +3512,9 @@ static int vmx_msr_write_intercept(unsigned int msr, = uint64_t msr_content) is_last_branch_msr(msr) ) break; + if ( v->domain->arch.msr_relaxed && !rdmsr_safe(msr, msr_content) = ) + break; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", msr, msr_content); diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.= c index e5a22b9347..74e71403ff 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -875,6 +875,7 @@ static int read_msr(unsigned int reg, uint64_t *val, const struct domain *currd =3D curr->domain; const struct cpuid_policy *cp =3D currd->arch.cpuid; bool vpmu_msr =3D false; + uint64_t tmp; int ret; if ( (ret =3D guest_rdmsr(curr, reg, val)) !=3D X86EMUL_UNHANDLEABLE ) @@ -986,6 +987,12 @@ static int read_msr(unsigned int reg, uint64_t *val, } /* fall through */ default: + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, tmp) ) + { + *val =3D 0; + return X86EMUL_OKAY; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); break; @@ -1148,6 +1155,9 @@ static int write_msr(unsigned int reg, uint64_t val, } /* fall through */ default: + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, val) ) + return X86EMUL_OKAY; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", reg, val); diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 23bbb6e8c1..d217c223b0 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -749,6 +749,7 @@ static struct domain *__init create_dom0(const module_t= *image, .max_grant_frames =3D -1, .max_maptrack_frames =3D -1, .max_vcpus =3D dom0_max_vcpus(), + .arch.domain_flags =3D opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED = : 0, }; struct domain *d; char *cmdline; diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h index 3900d7b48b..7213d184b0 100644 --- a/xen/include/asm-x86/domain.h +++ b/xen/include/asm-x86/domain.h @@ -437,6 +437,9 @@ struct arch_domain /* Mem_access emulation control */ bool_t mem_access_emulate_each_rep; + /* Don't unconditionally inject #GP for unhandled MSRs. */ + bool msr_relaxed; + /* Emulated devices enabled bitmap. */ uint32_t emulation_flags; } __cacheline_aligned; diff --git a/xen/include/asm-x86/setup.h b/xen/include/asm-x86/setup.h index 642a5e8460..24be46115d 100644 --- a/xen/include/asm-x86/setup.h +++ b/xen/include/asm-x86/setup.h @@ -65,6 +65,7 @@ extern bool opt_dom0_shadow; extern bool opt_dom0_pvh; extern bool opt_dom0_verbose; extern bool opt_dom0_cpuid_faulting; +extern bool opt_dom0_msr_relaxed; #define max_init_domid (0) diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x8= 6/xen.h index 629cb2ba40..f9d0e33b94 100644 --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -304,6 +304,14 @@ struct xen_arch_domainconfig { XEN_X86_EMU_PIT | XEN_X86_EMU_USE_PIR= Q |\ XEN_X86_EMU_VPCI) uint32_t emulation_flags; + +/* + * Select whether to use a relaxed behavior for accesses to MSRs not expli= citly + * handled by Xen instead of injecting a #GP to the guest. Note this optio= n + * doesn't allow the guest to read or write to the underlying MSR. + */ +#define XEN_X86_MSR_RELAXED (1u << 0) + uint32_t domain_flags; }; /* Location of online VCPU bitmap. */ -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 11:07:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 11:07:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95345.179982 (Exim 4.92) (envelope-from ) id 1lJaDA-0005bd-0V; Tue, 09 Mar 2021 11:07:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95345.179982; Tue, 09 Mar 2021 11:07:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJaD9-0005bW-TQ; Tue, 09 Mar 2021 11:07:35 +0000 Received: by outflank-mailman (input) for mailman id 95345; Tue, 09 Mar 2021 11:07:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJaD8-0005aZ-7i for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 11:07:34 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a6614b13-f21b-4756-9cd5-4bf27bc3e5d3; Tue, 09 Mar 2021 11:07:31 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 15933ACBF; Tue, 9 Mar 2021 11:07:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6614b13-f21b-4756-9cd5-4bf27bc3e5d3 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615288051; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SkpZLNJ6BK3FS/9pUrH3kgGmZ/Y8KOHjyuf0n4HzqeQ=; b=CcJ8j7RAEyD47HcARK3/ez/qcd+lhMKqSxrgtjWUFM2jRhl7go3yO4h5nhsh3WrcM91fOZ ZjXydCrqWaY8OrjdD1kz07iX2ynH+wTLPPpoz3rkNlDCOdq+EkRSX6PGW66OFvXEcCbyXa 6lwcBjXJReX8lfIAqHhW7nfZxniCYNU= Subject: Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Julien Grall , Michal Orzel Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210308135937.1692-1-michal.orzel@arm.com> <745c5049-fb09-5605-8bc1-838a4def45d6@xen.org> <3353ecf1-3a76-70ee-0475-b7eed90c783c@arm.com> From: Jan Beulich Message-ID: <1a1c8cf1-4c41-7fe2-ef4c-4f92d5b956c8@suse.com> Date: Tue, 9 Mar 2021 12:07:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09.03.2021 11:20, Julien Grall wrote: > On 09/03/2021 07:34, Michal Orzel wrote: >> On 08.03.2021 15:31, Julien Grall wrote: >>> On 08/03/2021 13:59, Michal Orzel wrote: >>>> --- a/xen/arch/arm/Makefile >>>> +++ b/xen/arch/arm/Makefile >>>> @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o >>>>     #obj-bin-y += ....o >>>>   -ifdef CONFIG_DTB_FILE >>>> +ifneq ($(CONFIG_DTB_FILE),"") >>>>   obj-y += dtb.o >>>>   AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>>   endif >>>> @@ -137,8 +137,6 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >>>>   xen.lds: xen.lds.S >>>>       $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >>>>   -dtb.o: $(CONFIG_DTB_FILE) >>>> - >>> >>> Why is this dropped? >> 1)This line is not needed as it has no impact on creating dtb.o >> 2)It causes the build failure once CONFIG_DTB_FILE option is in the Kconfig as string within quotes. > > Because of 1), this should have ideally be part of a separate patch. But > I am OK to keep it in this patch so long it is explained in the commit > message. Wasn't the intention to have dtb.o re-compiled when the blob has changed? This would be lost with the removal of this line. The quotes would need stripping now, of course. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 09 11:11:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 11:11:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95351.179993 (Exim 4.92) (envelope-from ) id 1lJaGi-0006XM-GO; Tue, 09 Mar 2021 11:11:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95351.179993; Tue, 09 Mar 2021 11:11:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJaGi-0006XF-Cz; Tue, 09 Mar 2021 11:11:16 +0000 Received: by outflank-mailman (input) for mailman id 95351; Tue, 09 Mar 2021 11:11:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJaGg-0006XA-Fe for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 11:11:14 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 03ccdb0f-88ae-4940-b7aa-b15d09ca0022; Tue, 09 Mar 2021 11:11:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03ccdb0f-88ae-4940-b7aa-b15d09ca0022 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615288273; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=nuLgex0bJypwLNAxe/D3orQ34UA6EXiqXrSwoWSjkug=; b=cGSX+6kCqGtXlp3Eh71pCofAknSHG98I8+4iDCiGiu3JFzM0O5Y2z7ym bIJcAjLGfNFgFJIvIYXRVZncki+u0u16mP5986FNP/xdYd1COylHDS75m GC0uvQ1dUGwL6CDE2abg7zj4/inA5x4lP5GZmvIseCf9Gpu7qqjEPjIZS Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: w8D7hOM+UpfoH4b+bPIL6/4y5zvGJ5UKx7IZ1KQcXfvliApeTmSBm/o3Dd8ENhprPY3CH+k2T1 78v8sXnBg8DScDR4aplnT/NaBmqYoPxmWqwsRRktzLxsjX2MADM/XErDjJZujCQndej0noxD7a E5e5QW8BpPzEdIg3HLS554FFH0+bqP6M3t8EseNQ5yXfkzmrq0CIqXdKVfIiUj+2SfKJFKMAw6 vCFxtY85UhQ2BhQMRwIxvmu8vYexCePi+NwEUoN5d/FXuzVvF9W7F1wH6yPccYZBLegzDX6lbo 6i0= X-SBRS: 4.0 X-MesageID: 38840490 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,234,1610427600"; d="scan'208";a="38840490" Date: Tue, 9 Mar 2021 11:11:08 +0000 From: Anthony PERARD To: Roger Pau =?iso-8859-1?Q?Monn=E9?= CC: Julien Grall , Stefano Stabellini , , , , , , , George Dunlap Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) Message-ID: References: <161507188317.11025.6744028462008264481@c667a6b167f6> <10b8048a-e8fe-1fcd-7291-7f1b16da2f4c@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Mar 09, 2021 at 11:32:47AM +0100, Roger Pau Monn wrote: > Does CentOS has something like Debian backports to get updated major > versions of packages? Something similar, it's done via SIG. We have SIG virt in which we build Xen packages among others. And there's a SIG which building newer version of GCC, we already use it to build the Linux kernel with a newer version of GCC. So we should be able to setup the Xen packages to build with a newer version of GCC, at least in CentOS 7. (I still have to look again at CentOS 8 or Stream.) > Also, I think we do maintain Xen on CentOS using a separate > repository, so newer versions of Xen will be added to CentOS. Adding > George and Anthony since they know about that. > > Thanks, Roger. -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Mar 09 11:16:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 11:16:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95354.180005 (Exim 4.92) (envelope-from ) id 1lJaM9-0006jd-68; Tue, 09 Mar 2021 11:16:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95354.180005; Tue, 09 Mar 2021 11:16:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJaM9-0006jW-3B; Tue, 09 Mar 2021 11:16:53 +0000 Received: by outflank-mailman (input) for mailman id 95354; Tue, 09 Mar 2021 11:16:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJaM7-0006jR-VO for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 11:16:51 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e75645b8-27a7-4c70-9dda-f789fa64cbe2; Tue, 09 Mar 2021 11:16:51 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 53AF5ACBF; Tue, 9 Mar 2021 11:16:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e75645b8-27a7-4c70-9dda-f789fa64cbe2 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615288610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ixrVyfBFxD/sZvbtkKtAgnz4ZJX48y+YRTOMqeZciwM=; b=f4aMYUs5l7SyuCeO3PZdKEFoxllHx5K3uCzcNxuwV2BXsjUlJbERU+LrjJQoWwHPAQsTEN c0JA07HsqHM3P6pFKaQxhhdD4H7vgjt98iWg6gadujFY7lsNbpEqkg2EXOWtO9tV50FUU/ sKEf/6BVaN60omn5XXFYwSKJLcYgFmY= Subject: Re: [PATCH v2 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson References: <1f19ced7-183b-8f08-3a90-c06039e053a6@suse.com> From: Jan Beulich Message-ID: <204d73ec-a46a-6cef-9bc4-4219a7d00350@suse.com> Date: Tue, 9 Mar 2021 12:16:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09.03.2021 11:17, Roger Pau Monné wrote: > On Mon, Mar 08, 2021 at 02:49:19PM +0100, Jan Beulich wrote: >> On 08.03.2021 13:11, Roger Pau Monné wrote: >>> On Mon, Mar 08, 2021 at 10:33:12AM +0100, Jan Beulich wrote: >>>> On 08.03.2021 09:56, Roger Pau Monné wrote: >>>>> On Fri, Mar 05, 2021 at 10:50:34AM +0100, Jan Beulich wrote: >>>>>> --- a/xen/arch/x86/pv/emul-priv-op.c >>>>>> +++ b/xen/arch/x86/pv/emul-priv-op.c >>>>>> @@ -874,7 +874,7 @@ static int read_msr(unsigned int reg, ui >>>>>> struct vcpu *curr = current; >>>>>> const struct domain *currd = curr->domain; >>>>>> const struct cpuid_policy *cp = currd->arch.cpuid; >>>>>> - bool vpmu_msr = false; >>>>>> + bool vpmu_msr = false, warn = false; >>>>>> int ret; >>>>>> >>>>>> if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) >>>>>> @@ -882,7 +882,7 @@ static int read_msr(unsigned int reg, ui >>>>>> if ( ret == X86EMUL_EXCEPTION ) >>>>>> x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); >>>>>> >>>>>> - return ret; >>>>>> + goto done; >>>>>> } >>>>>> >>>>>> switch ( reg ) >>>>>> @@ -986,7 +986,7 @@ static int read_msr(unsigned int reg, ui >>>>>> } >>>>>> /* fall through */ >>>>>> default: >>>>>> - gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); >>>>>> + warn = true; >>>>>> break; >>>>>> >>>>>> normal: >>>>>> @@ -995,7 +995,19 @@ static int read_msr(unsigned int reg, ui >>>>>> return X86EMUL_OKAY; >>>>>> } >>>>>> >>>>>> - return X86EMUL_UNHANDLEABLE; >>>>>> + done: >>>>> >>>>> Won't this handling be better placed in the 'default' switch case >>>>> above? >>>> >>>> No - see the "goto done" added near the top of the function. >>> >>> Yes, I'm not sure of that. If guest_rdmsr returns anything different >>> than X86EMUL_UNHANDLEABLE it means it has handled the MSR in some way, >>> and hence we shouldn't check whether the #GP handler is set or not. >>> >>> This is not the behavior of older Xen versions, so I'm unsure whether >>> we should introduce a policy that's even less strict than the previous >>> one in regard to whether a #GP is injected or not. >>> >>> I know injecting a #GP when the handler is not set is not helpful for >>> the guest, but we should limit the workaround to kind of restoring the >>> previous behavior for making buggy guests happy, not expanding it >>> anymore. >> >> Yet then we risk breaking guests with any subsequent addition to >> guest_rdmsr() which, under whatever extra conditions, wants to >> raise #GP. > > But it's always been like that AFAICT? Additions to guest_{rd/wr}msr > preventing taking the default path in the {read/write}_msr PV > handlers. Yes, but the impact so far and the impact going forward are different. > If #GP signaled by guest_{rd/wr}msr are no longer injected when the guest > #GP handler is not set we might as well drop the rdmsr_safe check and > just don't try to inject any #GP at all from MSR accesses unless the > handler is setup? Well, that's what I had initially. You asked me to change to what I have now. > I feel this is likely going too far. I agree we should attempt to > restore something compatible with the previous behavior for unhandled > MSRs, but also not injecting the #GPs signaled by guest_{rd/wr}msr > seems to go beyond that. I understand this is a downside. Yet as said - the downside of _not_ doing so is that every further raising of #GP will risk breaking a random guest kernel variant. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 09 11:21:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 11:21:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95360.180018 (Exim 4.92) (envelope-from ) id 1lJaQ9-0007di-O0; Tue, 09 Mar 2021 11:21:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95360.180018; Tue, 09 Mar 2021 11:21:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJaQ9-0007db-JV; Tue, 09 Mar 2021 11:21:01 +0000 Received: by outflank-mailman (input) for mailman id 95360; Tue, 09 Mar 2021 11:21:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJaQ8-0007dW-T4 for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 11:21:00 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2ab3b32d-04d1-47e6-a010-22ad3c2fed05; Tue, 09 Mar 2021 11:21:00 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 633B7AB8C; Tue, 9 Mar 2021 11:20:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ab3b32d-04d1-47e6-a010-22ad3c2fed05 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615288859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J3u/aOz1TPlsD64Ph0ZqwRZWEf0MoIW76MeK41o1c2c=; b=aE2LzoBsQAlYeXlxa3BNT0koaENq+5DErU+D1DDBuQGdaIBp2Q5Go4kAqxG1BYglt7SP3Z QBskbM1k5mW5K7kpRxuIMVF+MW7Rzyy85WqnT2uHvz2mGB4hVxGC7pbxc+eQf+gc8y7stn 1kB+yRT/y5oiiqiTnchHjXz0vZ3jt+s= Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) To: Julien Grall Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210306214148.27021-1-julien@xen.org> <1897022d-7591-3450-4e57-884a2860b13d@suse.com> <7fd07dc9-9c03-bb13-3907-c3c268a4e970@xen.org> <2de5160f-8636-5cdf-a20c-acaa2640c893@suse.com> From: Jan Beulich Message-ID: Date: Tue, 9 Mar 2021 12:20:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.03.2021 21:22, Julien Grall wrote: > On 08/03/2021 11:20, Jan Beulich wrote: >> On 08.03.2021 11:51, Julien Grall wrote: >>> On 08/03/2021 08:09, Jan Beulich wrote: >>>> Additionally - partly related to your own reply regarding the CI >>>> failures - imo there needs to be an analysis of what older distros >>>> will no longer build (at all or by default). >>> >>> Per the CI, this would be Ubuntu Trusty (and older), Centos 7 (and older) >>> >>> Do you have any other in mind? >> >> Our SLE12 (latest service pack is SP5 and still has a while to go >> to at least reach LTSS state) comes with gcc 4.8 as the default >> compiler. > > Thanks! That's good to know. Is it the old GCC Suse supports? Not sure I understand the question: The default compiler of this or any distro is of course (expected to be) supported by the vendor for the lifetime of the OS. >>>>> --- a/xen/include/xen/compiler.h >>>>> +++ b/xen/include/xen/compiler.h >>>>> @@ -5,6 +5,19 @@ >>>>> #error Sorry, your compiler is too old/not recognized. >>>>> #endif >>>>> >>>>> +#if CONFIG_CC_IS_GCC >>>>> +# if CONFIG_GCC_VERSION < 40900 >>>>> +/* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ >>>> >>>> As per the bug report, the issue was determined to not be present >>>> in e.g. 4.3. Hence while such a bug may influence our choice of >>>> minimum version, I don't think it can reasonably be named here as >>>> the apparent only reason for the choice. Personally I don't think >>>> any justification should be put here. >>> >>> Ok. >>> >>>> >>>>> +# error Sorry, your version of GCC is too old - please use 4.9 or newer. >>>>> +# elif defined(CONFIG_ARM_64) && CONFIG_GCC_VERSION < 50100 >>>>> +/* >>>>> + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 >>>>> + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk >>>>> + */ >>>>> +# error Sorry, your version of GCC is too old - please use 5.1 or newer. >>>> >>>> From the bug entry the fix looks to have been backported to 4.9, >>>> or at least some (important?) branches thereof. >>> >>> It is not clear what's you are trying to point out. Mind clarifying? >> >> Some 4.9 compilers (perhaps widely used ones) may not have the bad >> issue, which puts under question their ruling out when the main >> reason for doing so is that bug. > > Well... We could surely try to hunt which GCC 4.9 has been fixed. But I > am not convinced this is useful, we would need to have an allowlist of > GCC compiler. Or probe the compiler for the bug in question. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 09 11:36:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 11:36:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95365.180030 (Exim 4.92) (envelope-from ) id 1lJaes-0000Ep-0Q; Tue, 09 Mar 2021 11:36:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95365.180030; Tue, 09 Mar 2021 11:36:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJaer-0000Ei-SJ; Tue, 09 Mar 2021 11:36:13 +0000 Received: by outflank-mailman (input) for mailman id 95365; Tue, 09 Mar 2021 11:36:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJaeq-0000Ed-NP for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 11:36:12 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1bde09a5-40c4-4fad-a06d-f77291498dd8; Tue, 09 Mar 2021 11:36:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1bde09a5-40c4-4fad-a06d-f77291498dd8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615289771; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=BQa+/sW453AuTNDdYzeUGNI9zmj6jgy0kc3xvrcAsVQ=; b=Bu0rOVlTpq+JifIm/IG52cIDWkrNWFnfAytiMVifFaNoHk4sreP0sS+x QxF+HPEQTUlW3dIjKkBDK4eyclr0HYo2PSlZps1S6Y+IfmHLHjO1MUo9/ spA5QoCtTiep5TZ0HhG769oIfTpiZo5W+MC9FxJ/VUE8pH1BgOnhfZwFi s=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 3eOlW1m6YgdrVKaAgstg6OCLcxsMEgqJCl3yYAGu48Uzr3L7MtjhpjrIAjJwZg2EqawUlhvuKA Uha4XgSFa7Lzqa6BJxmaVg2Dqg3JuIh+Vwjg02wanys7ul3cXMu5RhiXflQo3DzRy+Ej9flh0J 0ibCyLeD57jw9l2Rr9AH1zr4uX7TL9HCg5q6PbAWjXNNAdI6kyDLwwzpQEN/G8QQwAjSr8eWVo IUGhmFwvgsQ4awzm71uszcmMB821FaP/eZLIcJ4YMWIUgiDdC9uuI9iRnZbltXo56WsU34SjeZ vLo= X-SBRS: 5.2 X-MesageID: 38841902 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,234,1610427600"; d="scan'208";a="38841902" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AyjllgFCWcwrNjNfX8DBtj5k4bQZIW07vGMv34gZzXc2AF7PAB5KOKOufSysMUg/9KgzGTWaJ4Q8K/LOh54qu5IPbYRhKHFW44eg+Dkb+C4A9Uro0X4kCfEB8XZpWOfx6TobdY2vnS0pdnlvdA8D74MhkdS4WUSt9Q4I8zp/YZ7PsGPpcILh6b6v3u4OjI+QTILwRKJBUo1jl2iaHgT14gTImgMDTDx/57K0xjCuHpZphxeKGwU08Zz0Kgh8a3h1DMAsew7oUQ5npwweHrG4DNOlsWeXQPW085VPEB1TI8qBSF452FWPrvq6sU84NctVfSxeogRYEMUy7AYjIPQMFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BQa+/sW453AuTNDdYzeUGNI9zmj6jgy0kc3xvrcAsVQ=; b=C91PDQk2K3QRK/QCCL++K/3tX3Fv0uuYXIIjiTqZtnP2/z9XgrDn+YIunm62IVkORREMMi4MljWBJQxe+UW3S/HK6/PbJ2jnXeKZWCse8vKzZJPWgPMCJasjOxklBe+2m0oFLUAyE5Z01IjWiK5xVMQ5vwFRI4Hzhc0W6Um6aJfM5V0BUoAMBzpCZI+b53/gBvTiQ/75tzy+NRIzQyjzjTS+bWjTlucVeHx4b7tkDxidjb4Fu9eRXyyGGXe1p+UCK+iwJrFv1t8Dsz2cJkzO4393/XI2mbYZUuewQW07itkiYlKIWBvcdfGIyYgJMElBgDKFV6lyQsUZvbC/ReVcPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BQa+/sW453AuTNDdYzeUGNI9zmj6jgy0kc3xvrcAsVQ=; b=xkWnKJyJGVN9oQA4bwIagEzKZNeR2soCdaNZZ3L7/Pxr4ZvcgMw6BGr13ij9WEapkO0++rlauzPcPgUQKZAh8LxunjVAXQBlrjrHjfYpM943g6FU78bEQj38z+u3Lt+vL/tvY+9x1hLILe9+2TzOwYBe1jBuLRHJncw8VhfMDEQ= From: George Dunlap To: Julien Grall CC: "open list:X86" , Andrew Cooper , Jan Beulich , Roger Pau Monne , Stefano Stabellini Subject: Re: [PATCH DO NOT APPLY] docs: Document allocator properties and the rubric for using them Thread-Topic: [PATCH DO NOT APPLY] docs: Document allocator properties and the rubric for using them Thread-Index: AQHXBE6IzoDpW0Psi0SLnVWLvJvx9Kpam+MAgAAFtoCAAAB2AIAc3P2AgAQpHIA= Date: Tue, 9 Mar 2021 11:36:04 +0000 Message-ID: References: <20210216102839.1801667-1-george.dunlap@citrix.com> <9d63df30-6de7-4ea8-1e38-d70318b4b7bb@xen.org> In-Reply-To: <9d63df30-6de7-4ea8-1e38-d70318b4b7bb@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f4fc6019-4bbe-4fe8-58bf-08d8e2ef861a x-ms-traffictypediagnostic: PH0PR03MB5894: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Z8BzmIXeKNQhk9jc4CYCUlYOXyNPkYK7FeJDPT8IX0U1c1gcxPi7lf6MoyRL9GRbJjC0ICG2c6WCq9dPvXJrfni+i3KriGHLt+05RhfYCHh5JhYl0l+8wnJA9N/Y+caK7hoyNcOGNGhPcAZDB/lZ2liZ3lj5LAnaiSFcBOl2LLzPEdCG88nmmDRn8fjF40t1fRb9oxcPZs8QKp0NLlrFFiBMiAgzQ3Yjo0sMxXo4TcbEI9I0B0K0jdsKtmndOl1OkqLJIn1pyLEK44Z3L27jYtviKqtJwrxyRziDL4Fsxn7JTQN1fVmtjV0xp87j+E24BMagqXYUXpSMTSZFtQmcfY8Eyt/XHKB0uG4XD1TVBa33a7wTJ43fz2Czl/Wkim/Uwxtjcn8dEs2sXwXElcsgT0KOy3Cuze+8WiYqzR2lnXEu5tu7ZLNRX86UoGdiN4/c8N9yPfaCuZhOQbeteBLxVwvIRIXuW1013rTDSuso/HEmItXBtD4prk5w2VcpCytyFTD/nUuqo65UiGT/br9f0v1UzZVJyZ0tX59i5d7dMYvr3UlZaumOq7FJmi9w8zZBf4YMVo2+Pp66n8q17s1OXg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(136003)(376002)(346002)(366004)(2906002)(66476007)(66556008)(66446008)(6512007)(64756008)(6486002)(6916009)(8936002)(5660300002)(6506007)(83380400001)(8676002)(86362001)(36756003)(186003)(91956017)(26005)(71200400001)(66946007)(478600001)(2616005)(76116006)(4326008)(54906003)(33656002)(316002)(53546011)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?Sy90bC94alFRaVYvQy9DaGhqUnYyYnlJMVJQc2lwTDcxcE5RNFVRVi9LVlYw?= =?utf-8?B?NnhDV3VtTnFlM3B1QXpEc2wvSGtDNmVYT2RuaGpJR3ZaOVUzLzVQQThDaEtH?= =?utf-8?B?Qk5tQW9KM29VN3ZrVkd4M3UySzh3WlM1WXhTRlh0QzJoMENKTmJIZ1FUd1Mv?= =?utf-8?B?UEgwNEN1NjRjQTJ3VXhQSWFQSEtGQlM3MzRyUlYxdDJ5WFgzSmdnQnE2ZHV1?= =?utf-8?B?YTZMZGlPTGJrT1UrTWgxV0hFK25WUzd3N2w5WlBMV0FXalZkaTdwNGY2TnFP?= =?utf-8?B?Wm42NjRvZTR1Q3NWSEVYTXhDSjhSWURTL1FickUydGZEa1F5dHc4ZnhTek90?= =?utf-8?B?VDlXR09GNXFWSG53YjRESHJQOVd0TFdSdHp1KzF4enNjUHEwdzlBcTA0QmZN?= =?utf-8?B?Ym5UY2kvRThOMG9KVm85Q1lrd3ZVUlpVV1l2R0UxVGlvQXc2Y3BWS2luYUlH?= =?utf-8?B?cmJiOEM4djhFc09sSUxUOUYyTU5KWGpYeVRvc2pyNW9TMFJXQ29WbkRncFVC?= =?utf-8?B?eTh3SGlNUm5ETERUQU5ZdzB3ajlEUmFESjdwYTdDWDc3TTNBRUZUSTc1VFRO?= =?utf-8?B?Y2VlWWtEdFgwWXJlUFV2OTVHUnA1SlZQelhsOVpxTklhUzBrZEJxRjVWR2U1?= =?utf-8?B?eFhOU2VjeG4wOTVBbFVtcVZWUk55cTZhWmg2TEhHTStZWnhHbExNU2x2NmYw?= =?utf-8?B?TlY1bDg5SkVvYXNvMHBZa0Z6V0M4MXFWVHJTK0RmWEZxdytwcjA2ZjAyY3Rp?= =?utf-8?B?TVU4aEhqa0NWdUF3cHFKUFRweW5kRTMrRVpaWFFVVU9ubUFSelBGNThOTWFi?= =?utf-8?B?aWNGbC9EOE1qRk5TeHFTaDBnQ3JRcytnN2U1RDZwYW16M3UrTWZvTmgxbW8r?= =?utf-8?B?R29qMTVla1gwamEveFlsNnpSUGlEUjRlWUNTdFNCZDVtTVJLQjl2TFloM2t6?= =?utf-8?B?ME9lcmkzb29jWXpIZXp3aSt5K0E0Y3hBMUFzaEdQRVdlTWN0SERDdHdnUVV2?= =?utf-8?B?RUZDTjZiWU1KZjlRR1dxS1QwREhVSmpCRUM4bFFmb2U3Wm44OWpCR0E4SVpo?= =?utf-8?B?b0FmT3U4K0plUkhvMHI4MDRzYk03aWhsUTl2M042cWt6SytYWkU3VW1jTzU0?= =?utf-8?B?enBSeWVtcStwUldSQU9reldPalRRUnpOQ3BrUldkb2ZTSjdOU2cxd1V2Q1Rl?= =?utf-8?B?TXJGRjFZODN5QVBSaERBSllFVXBvL3NHbWV6MmNSQjcyYis4Z0VGUmljSERG?= =?utf-8?B?MllOQTZhanRkVkVuMlRjMWt3bTF2dEVPSHdmSGRCMGJxRS9FZHBKV0NrNDVJ?= =?utf-8?B?akhyTERtRTRsVkRieGJqT1VuWFpMVHplamJXS2FWSkdFTmV6WlNsK0hTUkpP?= =?utf-8?B?OXNKWkFPSEIwZDFFTkx1RlcrMmlTd0lHbDd0eVdJMU56QmszVENTTVpJWXhU?= =?utf-8?B?d3B3dW90SXBZVFR3OGFUZlpYQUZrRHZvQ1ZZbnFYQVB4LzlMUmhGQ0xkOE94?= =?utf-8?B?NjNvUlk2NzdNdXNYbUw2KzAvRU0xZ0hqMU5sdUxoVXJoV01FTUtQVVdkN2h2?= =?utf-8?B?OE9MUHp6RU9tWThQWldORnl2U2h5WUZRL2JsNEJjaGhORnltMGwxVVhKM0NJ?= =?utf-8?B?MTFvNHk5UmtaRjByTTgxU0VDNS92cncveEZZUmJzbUNSTER3VFFhVzQ5bXhT?= =?utf-8?B?bHp5L05iRU5mdXU5bnF3UjEvek9MOWRqeHIwL0xhY3VQRmdHcjEzd1BnRzE4?= =?utf-8?B?bkcyYnhITTBPMmwvaW1kVHVsWC9IbzJaSFZSOFFQcVFlWHUxcGNMZW0wOGFK?= =?utf-8?B?cUtsQktySWJzNmNTdFZ5Zz09?= Content-Type: text/plain; charset="utf-8" Content-ID: <3EB3D734AC7DD74E9CB9CC76969E5076@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4fc6019-4bbe-4fe8-58bf-08d8e2ef861a X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2021 11:36:04.6346 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r6GyCSMe0ngOzKFfsSt/5AadSkBD+ZAkNlkz/VubTb3pBDOGCM1VKQ6XXtSicjJFRqqMeei9HArUd934+mnkjSoGv9aJr/TEPgIISA15KdM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5894 X-OriginatorOrg: citrix.com DQoNCj4gT24gTWFyIDYsIDIwMjEsIGF0IDg6MDMgUE0sIEp1bGllbiBHcmFsbCA8anVsaWVuQHhl bi5vcmc+IHdyb3RlOg0KPiANCj4gSGkgR2VvcmdlLA0KPiANCj4gT24gMTYvMDIvMjAyMSAxMTox NywgR2VvcmdlIER1bmxhcCB3cm90ZToNCj4+PiBPbiBGZWIgMTYsIDIwMjEsIGF0IDExOjE2IEFN LCBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+IHdyb3RlOg0KPj4+IA0K Pj4+IA0KPj4+IA0KPj4+PiBPbiBGZWIgMTYsIDIwMjEsIGF0IDEwOjU1IEFNLCBKdWxpZW4gR3Jh bGwgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+Pj4gDQo+Pj4+IEhpIEdlb3JnZSwNCj4+Pj4g DQo+Pj4+IE9uIDE2LzAyLzIwMjEgMTA6MjgsIEdlb3JnZSBEdW5sYXAgd3JvdGU6DQo+Pj4+PiBE b2N1bWVudCB0aGUgcHJvcGVydGllcyBvZiB0aGUgdmFyaW91cyBhbGxvY2F0b3JzIGFuZCBsYXkg b3V0IGEgY2xlYXINCj4+Pj4+IHJ1YnJpYyBmb3Igd2hlbiB0byB1c2UgZWFjaC4NCj4+Pj4+IFNp Z25lZC1vZmYtYnk6IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT4NCj4+ Pj4+IC0tLQ0KPj4+Pj4gVGhpcyBkb2MgaXMgbXkgdW5kZXJzdGFuZGluZyBvZiB0aGUgcHJvcGVy dGllcyBvZiB0aGUgY3VycmVudA0KPj4+Pj4gYWxsb2NhdG9ycyAoYWxsb2NfeGVuaGVhcF9wYWdl cywgeG1hbGxvYywgYW5kIHZtYWxsb2MpLCBhbmQgb2YgSmFuJ3MNCj4+Pj4+IHByb3Bvc2VkIG5l dyB3cmFwcGVyLCB4dm1hbGxvYy4NCj4+Pj4+IHhtYWxsb2MsIHZtYWxsb2MsIGFuZCB4dm1hbGxv YyB3ZXJlIGRlc2lnbmVkIG1vcmUgb3IgbGVzcyB0byBtaXJyb3INCj4+Pj4+IHNpbWlsYXIgZnVu Y3Rpb25zIGluIExpbnV4IChrbWFsbG9jLCB2bWFsbG9jLCBhbmQga3ZtYWxsb2MNCj4+Pj4+IHJl c3BlY3RpdmVseSkuDQo+Pj4+PiBDQzogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0 cml4LmNvbT4NCj4+Pj4+IENDOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+Pj4+ PiBDQzogUm9nZXIgUGF1IE1vbm5lIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4+Pj4+IENDOiBT dGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+Pj4+PiBDQzogSnVs aWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4+Pj4+IC0tLQ0KPj4+Pj4gLi4uL21lbW9yeS1h bGxvY2F0aW9uLWZ1bmN0aW9ucy5yc3QgICAgICAgICAgIHwgMTE4ICsrKysrKysrKysrKysrKysr Kw0KPj4+Pj4gMSBmaWxlIGNoYW5nZWQsIDExOCBpbnNlcnRpb25zKCspDQo+Pj4+PiBjcmVhdGUg bW9kZSAxMDA2NDQgZG9jcy9oeXBlcnZpc29yLWd1aWRlL21lbW9yeS1hbGxvY2F0aW9uLWZ1bmN0 aW9ucy5yc3QNCj4+Pj4+IGRpZmYgLS1naXQgYS9kb2NzL2h5cGVydmlzb3ItZ3VpZGUvbWVtb3J5 LWFsbG9jYXRpb24tZnVuY3Rpb25zLnJzdCBiL2RvY3MvaHlwZXJ2aXNvci1ndWlkZS9tZW1vcnkt YWxsb2NhdGlvbi1mdW5jdGlvbnMucnN0DQo+Pj4+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPj4+ Pj4gaW5kZXggMDAwMDAwMDAwMC4uMTVhYTJhMWE2NQ0KPj4+Pj4gLS0tIC9kZXYvbnVsbA0KPj4+ Pj4gKysrIGIvZG9jcy9oeXBlcnZpc29yLWd1aWRlL21lbW9yeS1hbGxvY2F0aW9uLWZ1bmN0aW9u cy5yc3QNCj4+Pj4+IEBAIC0wLDAgKzEsMTE4IEBADQo+Pj4+PiArLi4gU1BEWC1MaWNlbnNlLUlk ZW50aWZpZXI6IENDLUJZLTQuMA0KPj4+Pj4gKw0KPj4+Pj4gK1hlbmhlYXAgbWVtb3J5IGFsbG9j YXRpb24gZnVuY3Rpb25zDQo+Pj4+PiArPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0NCj4+Pj4+ICsNCj4+Pj4+ICtJbiBnZW5lcmFsIFhlbiBjb250YWlucyB0d28gcG9vbHMgKG9y ICJoZWFwcyIpIG9mIG1lbW9yeTogdGhlICp4ZW4NCj4+Pj4+ICtoZWFwKiBhbmQgdGhlICpkb20g aGVhcCouICBQbGVhc2Ugc2VlIHRoZSBjb21tZW50IGF0IHRoZSB0b3Agb2YNCj4+Pj4+ICtgYHhl bi9jb21tb24vcGFnZV9hbGxvYy5jYGAgZm9yIHRoZSBjYW5vbmljYWwgZXhwbGFuYXRpb24uDQo+ Pj4+PiArDQo+Pj4+PiArVGhpcyBkb2N1bWVudCBkZXNjcmliZXMgdGhlIHZhcmlvdXMgZnVuY3Rp b25zIGF2YWlsYWJsZSB0byBhbGxvY2F0ZQ0KPj4+Pj4gK21lbW9yeSBmcm9tIHRoZSB4ZW4gaGVh cDogdGhlaXIgcHJvcGVydGllcyBhbmQgcnVsZXMgZm9yIHdoZW4gdGhleSBzaG91bGQgYmUNCj4+ Pj4+ICt1c2VkLg0KPj4+Pj4gKw0KPj4+Pj4gKw0KPj4+Pj4gK1RMRFIgZ3VpZGVsaW5lcw0KPj4+ Pj4gKy0tLS0tLS0tLS0tLS0tLQ0KPj4+Pj4gKw0KPj4+Pj4gKyogQnkgZGVmYXVsdCwgYGB4dm1h bGxvY2BgIChvciBpdHMgaGVscGVyIGNvZ25hdGVzKSBzaG91bGQgYmUgdXNlZA0KPj4+Pj4gKyAg dW5sZXNzIHlvdSBrbm93IHlvdSBoYXZlIHNwZWNpZmljIHByb3BlcnRpZXMgdGhhdCBuZWVkIHRv IGJlIG1ldC4NCj4+Pj4+ICsNCj4+Pj4+ICsqIElmIHlvdSBuZWVkIG1lbW9yeSB3aGljaCBuZWVk cyB0byBiZSBwaHlzaWNhbGx5IGNvbnRpZ3VvdXMsIGFuZCBtYXkNCj4+Pj4+ICsgIGJlIGxhcmdl ciB0aGFuIGBgUEFHRV9TSVpFYGAuLi4NCj4+Pj4+ICsNCj4+Pj4+ICsgIC0gLi4uYW5kIGlzIG9y ZGVyIDIsIHVzZSBgYGFsbG9jX3hlbmhlYXBfcGFnZXNgYC4NCj4+Pj4+ICsNCj4+Pj4+ICsgIC0g Li4uYW5kIGlzIG5vdCBvcmRlciAyLCB1c2UgYGB4bWFsbG9jYGAgKG9yIGl0cyBoZWxwZXIgY29n bmF0ZXMpLi4NCj4+Pj4+ICsNCj4+Pj4+ICsqIElmIHlvdSBkb24ndCBuZWVkIG1lbW9yeSB0byBi ZSBwaHlzaWNhbGx5IGNvbnRpZ3VvdXMsIGFuZCBrbm93IHRoZQ0KPj4+Pj4gKyAgYWxsb2NhdGlv biB3aWxsIGFsd2F5cyBiZSBsYXJnZXIgdGhhbiBgYFBBR0VfU0laRWBgLCB5b3UgbWF5IHVzZQ0K Pj4+Pj4gKyAgYGB2bWFsbG9jYGAgKG9yIG9uZSBvZiBpdHMgaGVscGVyIGNvZ25hdGVzKS4NCj4+ Pj4+ICsNCj4+Pj4+ICsqIElmIHlvdSBrbm93IHRoYXQgYWxsb2NhdGlvbiB3aWxsIGFsd2F5cyBi ZSBsZXNzIHRoYW4gYGBQQUdFX1NJWkVgYCwNCj4+Pj4+ICsgIHlvdSBtYXkgdXNlIGBgeG1hbGxv Y2BgLg0KPj4+PiANCj4+Pj4gQUZBSUNULCB0aGUgZGV0ZXJtaW5pbmcgZmFjdG9yIGlzIFBBR0Vf U0laRS4gVGhpcyBpcyBhIHNpbmdsZSBpcyBhIHNpbmdsZSB2YWx1ZSBvbiB4ODYgKGUuZy4gNEtC KSBidXQgb24gb3RoZXIgYXJjaGl0ZWN0dXJlIHRoaXMgbWF5IGJlIG11bHRpcGxlIHZhbHVlcy4N Cj4+Pj4gDQo+Pj4+IEZvciBpbnN0YW5jZSwgb24gQXJtLCB0aGlzIGNvdWxkIGJlIDRLQiwgMTZL QiwgNjRLQiAobm90ZSB0aGF0IG9ubHkgdGhlIGZvcm1lciBpcyBzbyBmYXIgc3VwcG9ydGVkIG9u IFhlbikuDQo+Pj4+IA0KPj4+PiBGb3IgQXJtIGFuZCBjb21tb24gY29kZSwgaXQgZmVlbHMgdG8g bWUgd2UgY2FuJ3QgbWFrZSBhIGNsZWFyIGRlY2lzaW9uIGJhc2VkIG9uIFBBR0VfU0laRS4gSW5z dGVhZCwgSSBjb250aW51ZSB0byB0aGluayB0aGF0IHRoZSBkZWNpc2lvbiBzaG91bGQgb25seSBi ZSBiYXNlZCBvbiBwaHlzaWNhbCB2cyB2aXJ0dWFsbHkgY29udGlndW91cy4NCj4+Pj4gDQo+Pj4+ IFdlIGNhbiB0aGVuIGFkZCBmdXJ0aGVyIHJ1bGVzIGZvciB4ODYgc3BlY2lmaWMgY29kZSBpZiB0 aGUgbWFpbnRhaW5lcnMgd2FudC4NCj4+PiANCj4+PiBTb3JyeSBteSBzZWNvbmQgbWFpbCB3YXMg c29tZXdoYXQgZGVsYXllZCDigJQgbXkgaW50ZW50IHdhczogMSkgcG9zdCB0aGUgZG9jdW1lbnQg SeKAmWQgYWdyZWVkIHRvIHdyaXRlLCAyKSBzYXkgd2h5IEkgdGhpbmsgdGhlIHByb3Bvc2FsIGlz IGEgYmFkIGlkZWEuIDotKQ0KPiANCj4gTm8gd29ycnksIEkganVtcGVkIHRvbyBxdWlja2x5IGlu IHRoZSBkaXNjdXNzaW9uIDopLg0KPiANCj4+PiANCj4+PiBSZSBwYWdlIHNpemUg4oCUIHRoZSB2 YXN0IG1ham9yaXR5IG9mIHRpbWUgd2XigJlyZSB0YWxraW5nIOKAnGtub3dpbmfigJ0gdGhhdCB0 aGUgc2l6ZSBpcyBsZXNzIHRoYW4gNGsuICBJZiB3ZeKAmXJlIGNvbmZpZGVudCB0aGF0IG5vIGFy Y2hpdGVjdHVyZSB3aWxsIGV2ZXIgaGF2ZSBhIHBhZ2Ugc2l6ZSBsZXNzIHRoYW4gNGssIHRoZW4g d2Uga25vdyB0aGF0IGFsbCBhbGxvY2F0aW9ucyBsZXNzIHRoYW4gNGsgd2lsbCBhbHdheXMgYmUg bGVzcyB0aGFuIFBBR0VfU0laRS4gIE9idmlvdXNseSBsYXJnZXIgcGFnZSBzaXplcyB0aGVuIGJl Y29tZXMgYW4gaXNzdWUuDQo+Pj4gDQo+Pj4gQnV0IGluIGFueSBjYXNlIOKAlCB1bmxlc3Mgd2Ug aGF2ZSBCVUdfT04oc2l6ZSA+IFBBR0VfU0laRSksIHdl4oCZcmUgZ29pbmcgdG8gaGF2ZSB0byBo YXZlIGEgZmFsbGJhY2ssIHdoaWNoIGlzIGdvaW5nIHRvIGNvc3Qgb25lIHByZWNpb3VzIGNvbmRp dGlvbmFsLCBtYWtpbmcgdGhlIHdob2xlIGV4ZXJjaXNlIHBvaW50bGVzcy4NCj4+IEVyLCBqdXN0 IGluIGNhc2UgaXQgd2FzbuKAmXQgY2xlYXIg4oCUIEkgYWdyZWUgd2l0aCB0aGlzOg0KPj4+PiBJ IGNvbnRpbnVlIHRvIHRoaW5rIHRoYXQgdGhlIGRlY2lzaW9uIHNob3VsZCBvbmx5IGJlIGJhc2Vk IG9uIHBoeXNpY2FsIHZzIHZpcnR1YWxseSBjb250aWd1b3VzLg0KPiANCj4gV2UgaGF2ZSB0d28g b3Bwb3NpdGUgcHJvcG9zYWwgd2l0aCBubyBjbGVhciB3YXkgdG8gcmVjb25jaWxpYXRlIHRoZW0u IFNob3VsZCB3ZSByZXF1ZXN0IGEgdm90ZSBvbiB0aGUgdHdvIHByb3Bvc2Fscz8NCg0KTGV0IG1l IHdyaXRlIHVwIGFuIGFsdGVybmF0ZSBwcm9wb3NhbCB3aXRoIEphbuKAmXMgZmVlZGJhY2s7IHRo ZW4gaWYgaGUgc3RpbGwgdGhpbmtzIGhpcyB3YXkgaXMgYmV0dGVyIHdlIGNhbiB2b3RlLg0KDQog LUdlb3JnZQ== From xen-devel-bounces@lists.xenproject.org Tue Mar 09 11:36:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 11:36:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95368.180042 (Exim 4.92) (envelope-from ) id 1lJafM-0000Mi-El; Tue, 09 Mar 2021 11:36:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95368.180042; Tue, 09 Mar 2021 11:36:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJafM-0000Mb-Bb; Tue, 09 Mar 2021 11:36:44 +0000 Received: by outflank-mailman (input) for mailman id 95368; Tue, 09 Mar 2021 11:36:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJafK-0000MM-NT for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 11:36:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 899e468c-dfb4-421e-9ceb-1ab0cee4fc57; Tue, 09 Mar 2021 11:36:41 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C580DACBF; Tue, 9 Mar 2021 11:36:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 899e468c-dfb4-421e-9ceb-1ab0cee4fc57 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615289801; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZXEzlaOlJLycLmInSeoM0EvI4anAtdTKFIbfgVgmMUo=; b=aL+cGoN25Kl0mkXsI5tAJ37hriZAmVSh52E6naCPnm2HcuTYR7Q0PrxQDKvO98vmPEALEN 9Ky+dfsg31n1i13q4SOckULrIkgtTJyMa4iPAl/pSgQIZikVg1Wws+anK89KJhSOJ75GZ9 UGKaZstTpMQa/R6s3GyAXZhqsewCMm4= Subject: Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection To: Roger Pau Monne Cc: Ian Jackson , Wei Liu , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky , xen-devel@lists.xenproject.org References: <20210309105634.7200-1-roger.pau@citrix.com> From: Jan Beulich Message-ID: <37e82170-8097-1eda-95d9-23d235075a67@suse.com> Date: Tue, 9 Mar 2021 12:36:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210309105634.7200-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09.03.2021 11:56, Roger Pau Monne wrote: > Introduce an option to allow selecting a behavior similar to the pre > Xen 4.15 one for accesses to MSRs not explicitly handled. Since commit > 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly > handled by Xen result in the injection of a #GP to the guest. This > is a behavior change since previously a #GP was only injected if > accessing the MSR on the real hardware would also trigger a #GP, or if > the attempted to be set bits wouldn't match the hardware values (for > PV). > > This seems to be problematic for some guests, so introduce an option > to fallback to this kind of legacy behavior without leaking the > underlying MSR values to the guest. > > When the option is set, for both PV and HVM don't inject a #GP to the > guest on MSR read if reading the underlying MSR doesn't result in a > #GP, do the same for writes and simply discard the value to be written > on that case. > > Note that for guests restored or migrated from previous Xen versions > the option is enabled by default, in order to keep a compatible > MSR behavior. Such compatibility is done at the libxl layer, to avoid > higher-level toolstacks from having to know the details about this flag. > > Signed-off-by: Roger Pau Monné I'm generally okay with this approach, but wouldn't want to give it my R-b until it's at least clear it's not entirely unacceptable to anyone else (Andrew in particular). Couple of remarks: > Changes since v2: > - Apply the option to both HVM and PV guest. > - Handle both reads and writes. I take it that it's intentional that you didn't allow separate read and write control? > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -1795,6 +1795,7 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) > const struct domain *d = v->domain; > struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; > const struct nestedsvm *nsvm = &vcpu_nestedsvm(v); > + uint64_t tmp; > > switch ( msr ) > { While to some degree a matter of taste, I think such variables needed only inside a switch() and not needing an initializer would better live in the respective switch()'s scope. > --- a/xen/arch/x86/pv/emul-priv-op.c > +++ b/xen/arch/x86/pv/emul-priv-op.c > @@ -875,6 +875,7 @@ static int read_msr(unsigned int reg, uint64_t *val, > const struct domain *currd = curr->domain; > const struct cpuid_policy *cp = currd->arch.cpuid; > bool vpmu_msr = false; > + uint64_t tmp; > int ret; > > if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) > @@ -986,6 +987,12 @@ static int read_msr(unsigned int reg, uint64_t *val, > } > /* fall through */ > default: > + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, tmp) ) > + { > + *val = 0; > + return X86EMUL_OKAY; > + } > + > gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); > break; > > @@ -1148,6 +1155,9 @@ static int write_msr(unsigned int reg, uint64_t val, > } > /* fall through */ > default: > + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, val) ) > + return X86EMUL_OKAY; > + > gdprintk(XENLOG_WARNING, > "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", > reg, val); So what are your thoughts wrt my change to this file? Drop it altogether and require people to use this new option? Or do you see both coexist? In the latter case, since you had suggested that I drop the write side of my change - does your changing of the write path indicate you've changed your mind? Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:32:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:32:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95399.180060 (Exim 4.92) (envelope-from ) id 1lJcSz-0002l3-7m; Tue, 09 Mar 2021 13:32:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95399.180060; Tue, 09 Mar 2021 13:32:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcSz-0002kw-4h; Tue, 09 Mar 2021 13:32:05 +0000 Received: by outflank-mailman (input) for mailman id 95399; Tue, 09 Mar 2021 13:32:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcSx-0002kr-ON for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:32:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcSw-0007v8-M1; Tue, 09 Mar 2021 13:32:02 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJcSw-0006Fs-Cu; Tue, 09 Mar 2021 13:32:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=G+pNBv5b49zvjFE59ZRNWS8odJFJxII7Ni4XB4PzReY=; b=VK9a72zbNd6KO4jV0f+m4tTV8H hP4WZsNUqo87ZwTZdxI3iE3prPrGaNbvH58BWnfHUDdUOZAHqStr933b6t1Ihy8C6ONveli+gIYN5 duu6tB9IVZLlGrcuogHmvLcVgLOJxSu27EjdOqHcdGnWGzSd1LwcukmFw9pmcukP7u6U=; Subject: Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Jan Beulich , Michal Orzel Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210308135937.1692-1-michal.orzel@arm.com> <745c5049-fb09-5605-8bc1-838a4def45d6@xen.org> <3353ecf1-3a76-70ee-0475-b7eed90c783c@arm.com> <1a1c8cf1-4c41-7fe2-ef4c-4f92d5b956c8@suse.com> From: Julien Grall Message-ID: Date: Tue, 9 Mar 2021 13:32:00 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <1a1c8cf1-4c41-7fe2-ef4c-4f92d5b956c8@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 09/03/2021 11:07, Jan Beulich wrote: > On 09.03.2021 11:20, Julien Grall wrote: >> On 09/03/2021 07:34, Michal Orzel wrote: >>> On 08.03.2021 15:31, Julien Grall wrote: >>>> On 08/03/2021 13:59, Michal Orzel wrote: >>>>> --- a/xen/arch/arm/Makefile >>>>> +++ b/xen/arch/arm/Makefile >>>>> @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o >>>>>     #obj-bin-y += ....o >>>>>   -ifdef CONFIG_DTB_FILE >>>>> +ifneq ($(CONFIG_DTB_FILE),"") >>>>>   obj-y += dtb.o >>>>>   AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>>>   endif >>>>> @@ -137,8 +137,6 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >>>>>   xen.lds: xen.lds.S >>>>>       $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >>>>>   -dtb.o: $(CONFIG_DTB_FILE) >>>>> - >>>> >>>> Why is this dropped? >>> 1)This line is not needed as it has no impact on creating dtb.o >>> 2)It causes the build failure once CONFIG_DTB_FILE option is in the Kconfig as string within quotes. >> >> Because of 1), this should have ideally be part of a separate patch. But >> I am OK to keep it in this patch so long it is explained in the commit >> message. > > Wasn't the intention to have dtb.o re-compiled when the blob > has changed? This would be lost with the removal of this line. Ah yes. I was only thinking about a name change (this would be caught via the update of the config header) and not a file update. -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:38:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:38:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95407.180072 (Exim 4.92) (envelope-from ) id 1lJcYn-00030G-0w; Tue, 09 Mar 2021 13:38:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95407.180072; Tue, 09 Mar 2021 13:38:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcYm-000309-Sl; Tue, 09 Mar 2021 13:38:04 +0000 Received: by outflank-mailman (input) for mailman id 95407; Tue, 09 Mar 2021 13:38:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcYl-000303-1v for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:38:03 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6f49d382-7adb-4f8a-b1c9-e472c7737615; Tue, 09 Mar 2021 13:38:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f49d382-7adb-4f8a-b1c9-e472c7737615 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615297081; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=3bEL2A+MLwTW/Y798A+cGhhf/Al0mXULZFYe4skDu4I=; b=CYGYiwZxGpXJY5SfxMYOhTSuDNOQ2h+ZpmDrjbpg/K4QIiWSORFojBj2 uawZIRfalLYs9hMNbgXVdViVG7T4IJX3fI+pt4F3pczbys75agVxbeC+j 76t6yDChoXoQViAataVUxXhR+DBV+RlU1/nNcoQmtFDbsRhtjTGxiwTOx A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: BwlrfIMfHzlx/G5kgxfLelN8RvCLGyOU3tf3z3K+kHyJUl9fz6fTuQ/w8tDILtKXZoFoR2p/Za lpm6Sc5bex84shIsQcpX5bwuITUzZGzVtBPQEQNTTTi28x77d2PdzlXI8KN3YQ2GCSXXri5VkN 9n/8nQqJOk44ljfgdl74+LokvBtHSwRv8snP/4YJEINykDChv+TqftBotIJY1ZeeobxQIeJSfx YFTgFkohX5PFBoLyimMj/K5QIFboiuVXejt5+s1cTvp8lE6imJ90wIys8/IhHgwQ1WSaiZ+cmb r+Y= X-SBRS: 5.2 X-MesageID: 39225112 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,234,1610427600"; d="scan'208";a="39225112" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7PevGmM8R7+5UPLV3+278jdZmUCAgOWeV9c/jgpe5lbV2wjLQOS9yjVoI6HaeKkTK2QhfOkiXdlqBlReEkWOi+E3FkwPOOj6Okz8JJ/d9JpjPnwdbVzEb2ervVDfM17CD9mck975TfsGkUAD3o9z/9vv3rcJ2vfih39N+HNWVQDKNIREqD8IqTPGRycadGRCxwfwlHSGIKBmJUAgacYUt8Hs25ai4dTqYuaD6MpxEIrkiM2nyNJ/2sQf4Jhf4JYoIu0D7Kl3SqOQiHWGmlHvluQPOkEOE/WbDMhvG++ojtJrxqhCx+QD43BdzrMxdMoVcnjGQOvsSEEXkOqbAlBwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=alF45HQ5axwzrc6bUdHsxP5DQ6FffPvfjqmYhZ4KiCM=; b=g9Om+sgdmZVEcoy/vUVlnXbmFhdyOVqprxKjEAKtKgFXppRdkkJ+1ctsn/tw4vjbkO8k9EcY3GWUoSpW9kuEf64Z3FqOoPNQ9TKo8oMdUe4buQt/sOxRRLy7OrQzLY1gszlWRhqpBHaB43og83TiwYjDQSfXwRf58VPc7fUCSGlzHCe67qGMjYzBQDvCuTF9lhftG3aD7GNHHpXqfgy/Pl58XS4+m+7MokzEwbNhVnPj2oSalFtek9H83viIK9ukKxZO7YzVO2YgacecRimHbkiKGxNKn7kms6AepKddKD3tMg5i/ermZfEy65Y8TBT395KxD78fJp1Is5scznSY2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=alF45HQ5axwzrc6bUdHsxP5DQ6FffPvfjqmYhZ4KiCM=; b=GaMVL5rFwUsXi5fNMIJaSN0SZNqDXLXnzqA//8xMl810XdpQYROSujvwZcekz91yLkHAFj2zeGDzG+2r6NX2pUkGZMZAPyEpU8Lyucd8SuzjG3MogatuEXakPhRPulOnhK+nTKzaZD2qGC8JL1q3R9/bqDLtl2icAwP73wwBjdY= Date: Tue, 9 Mar 2021 14:37:29 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , Wei Liu , Ian Jackson Subject: Re: [PATCH v2 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads Message-ID: References: <1f19ced7-183b-8f08-3a90-c06039e053a6@suse.com> <204d73ec-a46a-6cef-9bc4-4219a7d00350@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <204d73ec-a46a-6cef-9bc4-4219a7d00350@suse.com> X-ClientProxiedBy: LO4P123CA0013.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3a61d2e5-25e5-4221-000f-08d8e3007f02 X-MS-TrafficTypeDiagnostic: DM6PR03MB5084: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oQB58O7KZOJJPA3GMmcJ3ejghv5hAr815+AEt7eZyo+R4wK07KhjeZkJpl7i/4FQO62QXB/9CKK4HKdO6Dcu5CFbs9DkAzeuLYtsb7PfnZH565K5B2mv8rTy/3ji39cmy1P8ot4jg9c/fed1moDmc+8kSZoxSzAI+bujyi2VL6G9pj5BqP7yZFvnkvXplHGwfONzeFjGLJT/Jkx3nR0AJgrTE6ptvT/8eUdczWWbx//zJ1pYZMkj72NAXy4wavzhKUMY8u+m6+2P2WsPxRRtfx1UgVmFao96bX9mRgcn/AVCkG+7K1kk0VfRsfmaMD2V5r2ECopBUdKGJKrhH/bLPCu5612+GLKW+N1rjxu5GKvZZhYI5GBcH2WnyKvfcIaGZ/uDhAJcjFLkpYuCxjknIh8hey3U2cUcWp9een6FIS7vO1G9AdclKluy7jwG6ynh2UsUIcx7CaK4gUG6wj0Ur6O5YwX6HN0kmi1IdOe7GXTT6Wni1SlZP9LwaQvWsRAkmakHTL+efFtqaHbekWzhyg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(346002)(39860400002)(376002)(396003)(136003)(366004)(85182001)(5660300002)(6496006)(6666004)(66946007)(66476007)(478600001)(66556008)(86362001)(53546011)(54906003)(8676002)(8936002)(6486002)(4326008)(9686003)(16526019)(186003)(2906002)(6916009)(33716001)(26005)(956004)(83380400001)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZGNmb2xSdk03SmoxVmdzRnA4bHZBcGlramFUY2VKRDRxTUd5TVc1cGVINDlO?= =?utf-8?B?TVhYS3luclVKVVZKL2tKOXN1WVV1blA0YUhQb054TlJmYmdST1FBU0pRcFZw?= =?utf-8?B?d3NFclJxQU1lamJxVzVveVg1bFBEOUFWcFM2MWtvZlRENUg1a2RuOXZyY1Mz?= =?utf-8?B?WHQ4dkNycTA2ZWpLY05TNUxEaFgwYVBVelBYbVVNWlM1N1J2Z1dUWUt5S3Rr?= =?utf-8?B?UlFZRUNPd0ViNXZkd3VRQU1sMlgvY1loRzE1UzFTa2RWNEtqMjFJYXNISkdh?= =?utf-8?B?MnMrR0tNY0IzRlU5U0lsdG9TT2FXaEMxRlBKVk5OamZJVTdJSlYxenM1Szh1?= =?utf-8?B?UW1FQU5abGF5Y3AvNnAyOVdFTFV6blRLQ085N2hKNjBFZENHYjA5My9EZTdw?= =?utf-8?B?TEFRRFovMCtCSVJyQmVpVHV5Ym05OHdRanpLaU5GQ0ZOeWNLY2gyRGwvZ1pF?= =?utf-8?B?bmdNY293aHZHK1M0TzNzM2lXT05iVkxYUlpTSVVXM3pmVWFIOGI1NUZIaUp1?= =?utf-8?B?QSt1M0FXamh5MGVTYjIxTHJPb2htVUljYUZudDBnc2t6dDRYOUxtN21tN3JC?= =?utf-8?B?cDcvQlJGVWVyTXZZL0pOWGxoalk0cE8zWmxRTWpLMmpOZTJRV0tMVVlkK0JJ?= =?utf-8?B?dkN4RGhObWI2Q2YvbkM0SUtMUG9tMTlxR0ZVREUxcFhmQUo2RjdQM1lVY0tN?= =?utf-8?B?cWpuUW9NZ0NLQm56ZUw1bUhFTWtkREhaRSszaGNqWkFhcEgwaTJKVWZLT251?= =?utf-8?B?Nm94a1ovVVU4RmdNMnR6anV0a1AxZm9UZUQ2dFFqSmFRWDRFM29pSWh1Zkdy?= =?utf-8?B?ZlZiVXlDdmJwb2lxQlNzZWlKUEtsUWFtY1NBYXVQQ2FhUERscDdVWGU4RmFp?= =?utf-8?B?YUcrN0FLTUl2ZDZMNTFxZU9qYnJZek1GWmhWZXVGbkdKTEtYdUxOZnFIQ2Qz?= =?utf-8?B?ZlYvdnVpZWpMM29OVVo1TDJKSnlwakhtL2xLc2xFcEVlMmFTVVZha01kSTQw?= =?utf-8?B?NDU1dEtSR01qNDVhYVhRcysxVW1JWnFxUXJXSERDeUlHOTh4OGxBQzhpaDBs?= =?utf-8?B?eUtMdkpNa1c0NnhlNzI5NllwdHhBb1FKQVN0RnBrUzU3S1BrSUoxbGs1bDNU?= =?utf-8?B?cEp6Vzk4S2pPUjBYcUp1UFBFWnhXRDdoYnI4eUlWSmNkaWtWdFVETWRuVWV3?= =?utf-8?B?TFRxbWJldm9PYWkrbU1IL3RuOEJiTGRrWGszeWRXcGxhMWZsa2M1M3BITWFD?= =?utf-8?B?Vm5yNnNlajhWV3M4eDlmRE1Ec3BlUkxIa3hyT1hsaEFxSTZGa2ZKMnlVaXIz?= =?utf-8?B?b21hYjhFUCtRVWVaczNnWDYzRUJHLzVROU9nSjVYQlFKaTBKekhjWmRsOWo3?= =?utf-8?B?M0tCSk51WHlLQkZ4MFY0TjlIMUVnd2ZEWWNWOVRKZENJME0zMEh3YWN4ZTc0?= =?utf-8?B?Y3U5M1lNaTJYVk9YSGZSUzVhQmZlcE5JcFZWM1liYUEzR2x5bk5LdzFPY3J6?= =?utf-8?B?Nlc0N0J4ZXlyTUttYjN0WmhObFM0blpPNmI2RDFYRmsxRHhZaUlFL1dwVnVo?= =?utf-8?B?bkc5NkVlUzYrTThpUFpzMzl0dU01UTNPb0wwQkZ5Wm5HQWdMczNsYlBWK0Fp?= =?utf-8?B?d21sSWZ6UDNlRHZpVnpYWlU1SlAwK2U4NkRNMncwZndhMHF0WmhTR1Nua3Ny?= =?utf-8?B?d0hnVkhkMlVqa3dnUUIxTE1QRkttK1RDell1OWt6eXdHM2N5eXFQWXVwOHlu?= =?utf-8?Q?EutVJyGEQK5vSNzIdTCtBS2giPQTAa86Cc2dOWZ?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3a61d2e5-25e5-4221-000f-08d8e3007f02 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 13:37:34.4771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PoTn/fflc2rFrYqZA2riOCQmFS9RJ0gj6BF/Rh2zYzwe/maXZsSMBin00ttR4br29kNEcA8jkif0Gq5/SXf4Tw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5084 X-OriginatorOrg: citrix.com On Tue, Mar 09, 2021 at 12:16:49PM +0100, Jan Beulich wrote: > On 09.03.2021 11:17, Roger Pau Monné wrote: > > On Mon, Mar 08, 2021 at 02:49:19PM +0100, Jan Beulich wrote: > >> On 08.03.2021 13:11, Roger Pau Monné wrote: > >>> On Mon, Mar 08, 2021 at 10:33:12AM +0100, Jan Beulich wrote: > >>>> On 08.03.2021 09:56, Roger Pau Monné wrote: > >>>>> On Fri, Mar 05, 2021 at 10:50:34AM +0100, Jan Beulich wrote: > >>>>>> --- a/xen/arch/x86/pv/emul-priv-op.c > >>>>>> +++ b/xen/arch/x86/pv/emul-priv-op.c > >>>>>> @@ -874,7 +874,7 @@ static int read_msr(unsigned int reg, ui > >>>>>> struct vcpu *curr = current; > >>>>>> const struct domain *currd = curr->domain; > >>>>>> const struct cpuid_policy *cp = currd->arch.cpuid; > >>>>>> - bool vpmu_msr = false; > >>>>>> + bool vpmu_msr = false, warn = false; > >>>>>> int ret; > >>>>>> > >>>>>> if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) > >>>>>> @@ -882,7 +882,7 @@ static int read_msr(unsigned int reg, ui > >>>>>> if ( ret == X86EMUL_EXCEPTION ) > >>>>>> x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); > >>>>>> > >>>>>> - return ret; > >>>>>> + goto done; > >>>>>> } > >>>>>> > >>>>>> switch ( reg ) > >>>>>> @@ -986,7 +986,7 @@ static int read_msr(unsigned int reg, ui > >>>>>> } > >>>>>> /* fall through */ > >>>>>> default: > >>>>>> - gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); > >>>>>> + warn = true; > >>>>>> break; > >>>>>> > >>>>>> normal: > >>>>>> @@ -995,7 +995,19 @@ static int read_msr(unsigned int reg, ui > >>>>>> return X86EMUL_OKAY; > >>>>>> } > >>>>>> > >>>>>> - return X86EMUL_UNHANDLEABLE; > >>>>>> + done: > >>>>> > >>>>> Won't this handling be better placed in the 'default' switch case > >>>>> above? > >>>> > >>>> No - see the "goto done" added near the top of the function. > >>> > >>> Yes, I'm not sure of that. If guest_rdmsr returns anything different > >>> than X86EMUL_UNHANDLEABLE it means it has handled the MSR in some way, > >>> and hence we shouldn't check whether the #GP handler is set or not. > >>> > >>> This is not the behavior of older Xen versions, so I'm unsure whether > >>> we should introduce a policy that's even less strict than the previous > >>> one in regard to whether a #GP is injected or not. > >>> > >>> I know injecting a #GP when the handler is not set is not helpful for > >>> the guest, but we should limit the workaround to kind of restoring the > >>> previous behavior for making buggy guests happy, not expanding it > >>> anymore. > >> > >> Yet then we risk breaking guests with any subsequent addition to > >> guest_rdmsr() which, under whatever extra conditions, wants to > >> raise #GP. > > > > But it's always been like that AFAICT? Additions to guest_{rd/wr}msr > > preventing taking the default path in the {read/write}_msr PV > > handlers. > > Yes, but the impact so far and the impact going forward are different. OK, I assume this is because we plan to handle more MSRs in guest_{rd/wr}msr? In which case those newly added handlers are not likely to inject a #GP? > > If #GP signaled by guest_{rd/wr}msr are no longer injected when the guest > > #GP handler is not set we might as well drop the rdmsr_safe check and > > just don't try to inject any #GP at all from MSR accesses unless the > > handler is setup? > > Well, that's what I had initially. You asked me to change to what I > have now. > > > I feel this is likely going too far. I agree we should attempt to > > restore something compatible with the previous behavior for unhandled > > MSRs, but also not injecting the #GPs signaled by guest_{rd/wr}msr > > seems to go beyond that. > > I understand this is a downside. Yet as said - the downside of _not_ > doing so is that every further raising of #GP will risk breaking a > random guest kernel variant. Right. So given this awkward position Xen is in, we should maybe make the lack of #GP injection as a result of an MSR access when no handler is set formally part of the ABI and written down somewhere? It's not ideal, but at the end of day PV is 'our' own architecture, and given that this workaround will be enabled by default, and that we won't be able to turn it off we should have it written down as part of the ABI. If you agree with this I'm fine with not injecting a #GP at all unless the handler is set for PV, like you proposed in your first patch. IMO it's not ideal, but it's better if it's a consistent behavior and clearly written down in the public headers (likely next to the hypercall used to setup the #GP handler). I know this can be seen as broken behavior from an x86 perspective, but again PV is already different from x86. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:48:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:48:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95415.180108 (Exim 4.92) (envelope-from ) id 1lJcio-00042p-I9; Tue, 09 Mar 2021 13:48:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95415.180108; Tue, 09 Mar 2021 13:48:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcio-00042g-E4; Tue, 09 Mar 2021 13:48:26 +0000 Received: by outflank-mailman (input) for mailman id 95415; Tue, 09 Mar 2021 13:48:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcin-0003yx-NP for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:48:25 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c72d0996-a3c9-4062-bbb5-7476d48317fb; Tue, 09 Mar 2021 13:48:21 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C3B9FAC54; Tue, 9 Mar 2021 13:48:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c72d0996-a3c9-4062-bbb5-7476d48317fb X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615297700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=95nQytiynjE+lgsCD540YiASmJmBTjnBSf2S8IR/Qxo=; b=eTOxo46U1RhOYqXDG/YlpXeiG3mLS1gXZT03GDvmXHlWw2A41vtoW6U87OFUK88uBhj8jV RYsSVHbP+7xSab4R9Ef5+rs9BdphzAAW2san7SPMMtY4hgtNyB/CkvRKIfSDf7TEgMCLzP /udQQc2plcCPrIq/so8hMX3DhKnWiBM= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, clang-built-linux@googlegroups.com Cc: Juergen Gross , Peter Zijlstra , Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel , Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini , Andy Lutomirski , Nathan Chancellor , Nick Desaulniers Subject: [PATCH v6 00/12] x86: major paravirt cleanup Date: Tue, 9 Mar 2021 14:48:01 +0100 Message-Id: <20210309134813.23912-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is a major cleanup of the paravirt infrastructure aiming at eliminating all custom code patching via paravirt patching. This is achieved by using ALTERNATIVE instead, leading to the ability to give objtool access to the patched in instructions. In order to remove most of the 32-bit special handling from pvops the time related operations are switched to use static_call() instead. At the end of this series all paravirt patching has to do is to replace indirect calls with direct ones. In a further step this could be switched to static_call(), too. Changes in V6: - switched back to "not" bit in feature value for "not feature" - other minor comments addressed Changes in V5: - patches 1-5 of V4 dropped, as already applied - new patches 1+3 - fixed patch 2 - split V4 patch 8 into patches 4+5 - use flag byte instead of negative feature bit for "not feature" Changes in V4: - fixed several build failures - removed objtool patch, as objtool patches are in tip now - added patch 1 for making usage of static_call easier - even more cleanup Changes in V3: - added patches 7 and 12 - addressed all comments Changes in V2: - added patches 5-12 Juergen Gross (12): static_call: move struct static_call_key definition to static_call_types.h x86/paravirt: switch time pvops functions to use static_call() x86/alternative: drop feature parameter from ALTINSTR_REPLACEMENT() x86/alternative: support not-feature x86/alternative: support ALTERNATIVE_TERNARY x86: add new features for paravirt patching x86/paravirt: remove no longer needed 32-bit pvops cruft x86/paravirt: simplify paravirt macros x86/paravirt: switch iret pvops to ALTERNATIVE x86/paravirt: add new macros PVOP_ALT* supporting pvops in ALTERNATIVEs x86/paravirt: switch functions with custom code to ALTERNATIVE x86/paravirt: have only one paravirt patch function arch/arm/include/asm/paravirt.h | 14 +- arch/arm/kernel/paravirt.c | 9 +- arch/arm64/include/asm/paravirt.h | 14 +- arch/arm64/kernel/paravirt.c | 13 +- arch/x86/Kconfig | 1 + arch/x86/entry/entry_32.S | 4 +- arch/x86/entry/entry_64.S | 2 +- arch/x86/include/asm/alternative-asm.h | 7 + arch/x86/include/asm/alternative.h | 23 ++- arch/x86/include/asm/cpufeatures.h | 2 + arch/x86/include/asm/irqflags.h | 7 +- arch/x86/include/asm/mshyperv.h | 2 +- arch/x86/include/asm/paravirt.h | 169 +++++++++---------- arch/x86/include/asm/paravirt_types.h | 210 +++++++++--------------- arch/x86/kernel/Makefile | 3 +- arch/x86/kernel/alternative.c | 51 +++++- arch/x86/kernel/asm-offsets.c | 7 - arch/x86/kernel/cpu/vmware.c | 5 +- arch/x86/kernel/kvm.c | 2 +- arch/x86/kernel/kvmclock.c | 2 +- arch/x86/kernel/paravirt-spinlocks.c | 9 + arch/x86/kernel/paravirt.c | 78 +++------ arch/x86/kernel/paravirt_patch.c | 99 ----------- arch/x86/kernel/tsc.c | 2 +- arch/x86/xen/enlighten_pv.c | 4 +- arch/x86/xen/time.c | 26 +-- drivers/xen/time.c | 3 +- include/linux/static_call.h | 18 -- include/linux/static_call_types.h | 18 ++ tools/include/linux/static_call_types.h | 18 ++ 30 files changed, 348 insertions(+), 474 deletions(-) delete mode 100644 arch/x86/kernel/paravirt_patch.c -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:48:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:48:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95414.180096 (Exim 4.92) (envelope-from ) id 1lJcim-00040L-4I; Tue, 09 Mar 2021 13:48:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95414.180096; Tue, 09 Mar 2021 13:48:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcim-00040B-0z; Tue, 09 Mar 2021 13:48:24 +0000 Received: by outflank-mailman (input) for mailman id 95414; Tue, 09 Mar 2021 13:48:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcik-0003zp-Fn for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:48:22 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2a1860f4-6cbd-4df3-b717-955e83e439e5; Tue, 09 Mar 2021 13:48:21 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 403ECAD72; Tue, 9 Mar 2021 13:48:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a1860f4-6cbd-4df3-b717-955e83e439e5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615297700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ahQRIjhdqXiMH7Gh0LbxfuU+coM2Xg7I375ydZ/1bFA=; b=GBMKwRz6DKjYuW/RxjuLrnbjyTUV/PQ2WKh98Pjh9rrIrjyiW1pF+Wgagq+0nKWLV7SuO6 lu9xKibwmx5qj6ngBrEliMhnJA8Q2guu+e90vxKo523+I6F7J1s6WfUfLOPpxT4DdXK3BG OWEdwNxuKk3uNRro96+ZuX/fqMPmKzM= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: [PATCH v6 04/12] x86/alternative: support not-feature Date: Tue, 9 Mar 2021 14:48:05 +0100 Message-Id: <20210309134813.23912-5-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309134813.23912-1-jgross@suse.com> References: <20210309134813.23912-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for alternative patching for the case a feature is not present on the current cpu. For users of ALTERNATIVE() and friends an inverted feature is specified by applying the ALT_NOT() macro to it, e.g.: ALTERNATIVE(old, new, ALT_NOT(feature)) Signed-off-by: Juergen Gross --- V5: - split off from next patch - reworked to use flag byte (Boris Petkov) V6: - rework again to not use flag byte (Boris Petkov) --- arch/x86/include/asm/alternative-asm.h | 3 +++ arch/x86/include/asm/alternative.h | 3 +++ arch/x86/kernel/alternative.c | 19 ++++++++++++++----- 3 files changed, 20 insertions(+), 5 deletions(-) diff --git a/arch/x86/include/asm/alternative-asm.h b/arch/x86/include/asm/alternative-asm.h index 464034db299f..3965daf0460e 100644 --- a/arch/x86/include/asm/alternative-asm.h +++ b/arch/x86/include/asm/alternative-asm.h @@ -6,6 +6,9 @@ #include +#define ALTINSTR_FLAG_INV (1 << 15) +#define ALT_NOT(feat) ((feat) | ALTINSTR_FLAG_INV) + #ifdef CONFIG_SMP .macro LOCK_PREFIX 672: lock diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h index 5753fb2ac489..89889618ae01 100644 --- a/arch/x86/include/asm/alternative.h +++ b/arch/x86/include/asm/alternative.h @@ -59,11 +59,14 @@ struct alt_instr { s32 instr_offset; /* original instruction */ s32 repl_offset; /* offset to replacement instruction */ u16 cpuid; /* cpuid bit set for replacement */ +#define ALTINSTR_FLAG_INV (1 << 15) u8 instrlen; /* length of original instruction */ u8 replacementlen; /* length of new instruction */ u8 padlen; /* length of build-time padding */ } __packed; +#define ALT_NOT(feat) ((feat) | ALTINSTR_FLAG_INV) + /* * Debug flag that can be tested to see whether alternative * instructions were patched in already: diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index 8d778e46725d..d8e669a1546f 100644 --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -388,21 +388,30 @@ void __init_or_module noinline apply_alternatives(struct alt_instr *start, */ for (a = start; a < end; a++) { int insn_buff_sz = 0; + /* Mask away "NOT" flag bit for feature to test. */ + u16 feature = a->cpuid & ~ALTINSTR_FLAG_INV; instr = (u8 *)&a->instr_offset + a->instr_offset; replacement = (u8 *)&a->repl_offset + a->repl_offset; BUG_ON(a->instrlen > sizeof(insn_buff)); - BUG_ON(a->cpuid >= (NCAPINTS + NBUGINTS) * 32); - if (!boot_cpu_has(a->cpuid)) { + BUG_ON(feature >= (NCAPINTS + NBUGINTS) * 32); + + /* + * Drop out if either: + * - feature not available, but required, or + * - feature available, but NOT required + */ + if (!boot_cpu_has(feature) == !(a->cpuid & ALTINSTR_FLAG_INV)) { if (a->padlen > 1) optimize_nops(a, instr); continue; } - DPRINTK("feat: %d*32+%d, old: (%pS (%px) len: %d), repl: (%px, len: %d), pad: %d", - a->cpuid >> 5, - a->cpuid & 0x1f, + DPRINTK("feat: %s%d*32+%d, old: (%pS (%px) len: %d), repl: (%px, len: %d), pad: %d", + (a->cpuid & ALTINSTR_FLAG_INV) ? "!" : "", + feature >> 5, + feature & 0x1f, instr, instr, a->instrlen, replacement, a->replacementlen, a->padlen); -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:48:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:48:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95413.180084 (Exim 4.92) (envelope-from ) id 1lJcij-0003z9-S9; Tue, 09 Mar 2021 13:48:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95413.180084; Tue, 09 Mar 2021 13:48:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcij-0003z2-P7; Tue, 09 Mar 2021 13:48:21 +0000 Received: by outflank-mailman (input) for mailman id 95413; Tue, 09 Mar 2021 13:48:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcii-0003yx-Qy for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:48:20 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7619889b-bbcf-4c07-b37e-6cac559b238f; Tue, 09 Mar 2021 13:48:20 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 329F5AC17; Tue, 9 Mar 2021 13:48:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7619889b-bbcf-4c07-b37e-6cac559b238f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615297699; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lLz8EEkgsQbQc5zK5shQUpeWBQPCbxXPv1CJD4/GY5s=; b=V9rLewRZsFpBl1/XMebrWwmjaGkfsV2llhnmLZXMNrI974R7XYC90NkWaxfzuPQahHLRV7 QYcLm6Y0TKWTsGJlbD4nAR0d1uWxj00iAlUqO1DXdmT043Yz6a/Kj/cH22/KXJwces9Oac 2m1T/gsMz7tida4po0YgsnFuzklP0Qk= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Peter Zijlstra , Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel Subject: [PATCH v6 01/12] static_call: move struct static_call_key definition to static_call_types.h Date: Tue, 9 Mar 2021 14:48:02 +0100 Message-Id: <20210309134813.23912-2-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309134813.23912-1-jgross@suse.com> References: <20210309134813.23912-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Having the definition of static_call() in static_call_types.h makes no sense as long struct static_call_key isn't defined there, as the generic implementation of static_call() is referencing this structure. So move the definition of struct static_call_key to static_call_types.h. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V5: - new patch --- include/linux/static_call.h | 18 ------------------ include/linux/static_call_types.h | 18 ++++++++++++++++++ tools/include/linux/static_call_types.h | 18 ++++++++++++++++++ 3 files changed, 36 insertions(+), 18 deletions(-) diff --git a/include/linux/static_call.h b/include/linux/static_call.h index 85ecc789f4ff..76b881259144 100644 --- a/include/linux/static_call.h +++ b/include/linux/static_call.h @@ -128,16 +128,6 @@ struct static_call_mod { struct static_call_site *sites; }; -struct static_call_key { - void *func; - union { - /* bit 0: 0 = mods, 1 = sites */ - unsigned long type; - struct static_call_mod *mods; - struct static_call_site *sites; - }; -}; - /* For finding the key associated with a trampoline */ struct static_call_tramp_key { s32 tramp; @@ -187,10 +177,6 @@ extern long __static_call_return0(void); static inline int static_call_init(void) { return 0; } -struct static_call_key { - void *func; -}; - #define __DEFINE_STATIC_CALL(name, _func, _func_init) \ DECLARE_STATIC_CALL(name, _func); \ struct static_call_key STATIC_CALL_KEY(name) = { \ @@ -243,10 +229,6 @@ static inline long __static_call_return0(void) static inline int static_call_init(void) { return 0; } -struct static_call_key { - void *func; -}; - static inline long __static_call_return0(void) { return 0; diff --git a/include/linux/static_call_types.h b/include/linux/static_call_types.h index ae5662d368b9..5a00b8b2cf9f 100644 --- a/include/linux/static_call_types.h +++ b/include/linux/static_call_types.h @@ -58,11 +58,25 @@ struct static_call_site { __raw_static_call(name); \ }) +struct static_call_key { + void *func; + union { + /* bit 0: 0 = mods, 1 = sites */ + unsigned long type; + struct static_call_mod *mods; + struct static_call_site *sites; + }; +}; + #else /* !CONFIG_HAVE_STATIC_CALL_INLINE */ #define __STATIC_CALL_ADDRESSABLE(name) #define __static_call(name) __raw_static_call(name) +struct static_call_key { + void *func; +}; + #endif /* CONFIG_HAVE_STATIC_CALL_INLINE */ #ifdef MODULE @@ -77,6 +91,10 @@ struct static_call_site { #else +struct static_call_key { + void *func; +}; + #define static_call(name) \ ((typeof(STATIC_CALL_TRAMP(name))*)(STATIC_CALL_KEY(name).func)) diff --git a/tools/include/linux/static_call_types.h b/tools/include/linux/static_call_types.h index ae5662d368b9..5a00b8b2cf9f 100644 --- a/tools/include/linux/static_call_types.h +++ b/tools/include/linux/static_call_types.h @@ -58,11 +58,25 @@ struct static_call_site { __raw_static_call(name); \ }) +struct static_call_key { + void *func; + union { + /* bit 0: 0 = mods, 1 = sites */ + unsigned long type; + struct static_call_mod *mods; + struct static_call_site *sites; + }; +}; + #else /* !CONFIG_HAVE_STATIC_CALL_INLINE */ #define __STATIC_CALL_ADDRESSABLE(name) #define __static_call(name) __raw_static_call(name) +struct static_call_key { + void *func; +}; + #endif /* CONFIG_HAVE_STATIC_CALL_INLINE */ #ifdef MODULE @@ -77,6 +91,10 @@ struct static_call_site { #else +struct static_call_key { + void *func; +}; + #define static_call(name) \ ((typeof(STATIC_CALL_TRAMP(name))*)(STATIC_CALL_KEY(name).func)) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:48:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:48:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95416.180120 (Exim 4.92) (envelope-from ) id 1lJciq-00045s-ST; Tue, 09 Mar 2021 13:48:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95416.180120; Tue, 09 Mar 2021 13:48:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJciq-00045f-Ot; Tue, 09 Mar 2021 13:48:28 +0000 Received: by outflank-mailman (input) for mailman id 95416; Tue, 09 Mar 2021 13:48:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcip-0003zp-CG for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:48:27 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4fc160d5-76f5-4553-a04c-39cb7941f2e4; Tue, 09 Mar 2021 13:48:20 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CC7ADAC8C; Tue, 9 Mar 2021 13:48:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4fc160d5-76f5-4553-a04c-39cb7941f2e4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615297700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Xwm5mh2li/8IRrBrCYwfe2NBOuXxsvyUigtTvOh1lo=; b=t4cPsAYbcckAYG/qiEk71LYZZ8Z3aeLZ1K8c2a6Ypz+5ltsQALBFHjrtDmGkDMRxE+fnob xAUKcKfDsCQuOARcLh5vW9lYi1hCT4dD1/wK09AMrCsaOH3QVFXgF70djb8lWp4k7kSoJZ uG+aNmsB1Al+tic7UL1KXzx5itZCuzY= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini , Peter Zijlstra Subject: [PATCH v6 02/12] x86/paravirt: switch time pvops functions to use static_call() Date: Tue, 9 Mar 2021 14:48:03 +0100 Message-Id: <20210309134813.23912-3-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309134813.23912-1-jgross@suse.com> References: <20210309134813.23912-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The time pvops functions are the only ones left which might be used in 32-bit mode and which return a 64-bit value. Switch them to use the static_call() mechanism instead of pvops, as this allows quite some simplification of the pvops implementation. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V4: - drop paravirt_time.h again - don't move Hyper-V code (Michael Kelley) V5: - drop no longer needed Hyper-V modification (Michael Kelley) - switch Arm and Arm64 to static_call(), too (kernel test robot) V6: - factor out common parts in Xen pv/pvh initialization (Boris Petkov) --- arch/arm/include/asm/paravirt.h | 14 +++++--------- arch/arm/kernel/paravirt.c | 9 +++++++-- arch/arm64/include/asm/paravirt.h | 14 +++++--------- arch/arm64/kernel/paravirt.c | 13 +++++++++---- arch/x86/Kconfig | 1 + arch/x86/include/asm/mshyperv.h | 2 +- arch/x86/include/asm/paravirt.h | 17 ++++++++++++++--- arch/x86/include/asm/paravirt_types.h | 6 ------ arch/x86/kernel/cpu/vmware.c | 5 +++-- arch/x86/kernel/kvm.c | 2 +- arch/x86/kernel/kvmclock.c | 2 +- arch/x86/kernel/paravirt.c | 16 ++++++++++++---- arch/x86/kernel/tsc.c | 2 +- arch/x86/xen/time.c | 26 +++++++++++++------------- drivers/xen/time.c | 3 ++- 15 files changed, 75 insertions(+), 57 deletions(-) diff --git a/arch/arm/include/asm/paravirt.h b/arch/arm/include/asm/paravirt.h index cdbf02d9c1d4..95d5b0d625cd 100644 --- a/arch/arm/include/asm/paravirt.h +++ b/arch/arm/include/asm/paravirt.h @@ -3,23 +3,19 @@ #define _ASM_ARM_PARAVIRT_H #ifdef CONFIG_PARAVIRT +#include + struct static_key; extern struct static_key paravirt_steal_enabled; extern struct static_key paravirt_steal_rq_enabled; -struct pv_time_ops { - unsigned long long (*steal_clock)(int cpu); -}; - -struct paravirt_patch_template { - struct pv_time_ops time; -}; +u64 dummy_steal_clock(int cpu); -extern struct paravirt_patch_template pv_ops; +DECLARE_STATIC_CALL(pv_steal_clock, dummy_steal_clock); static inline u64 paravirt_steal_clock(int cpu) { - return pv_ops.time.steal_clock(cpu); + return static_call(pv_steal_clock)(cpu); } #endif diff --git a/arch/arm/kernel/paravirt.c b/arch/arm/kernel/paravirt.c index 4cfed91fe256..7dd9806369fb 100644 --- a/arch/arm/kernel/paravirt.c +++ b/arch/arm/kernel/paravirt.c @@ -9,10 +9,15 @@ #include #include #include +#include #include struct static_key paravirt_steal_enabled; struct static_key paravirt_steal_rq_enabled; -struct paravirt_patch_template pv_ops; -EXPORT_SYMBOL_GPL(pv_ops); +static u64 native_steal_clock(int cpu) +{ + return 0; +} + +DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock); diff --git a/arch/arm64/include/asm/paravirt.h b/arch/arm64/include/asm/paravirt.h index cf3a0fd7c1a7..9aa193e0e8f2 100644 --- a/arch/arm64/include/asm/paravirt.h +++ b/arch/arm64/include/asm/paravirt.h @@ -3,23 +3,19 @@ #define _ASM_ARM64_PARAVIRT_H #ifdef CONFIG_PARAVIRT +#include + struct static_key; extern struct static_key paravirt_steal_enabled; extern struct static_key paravirt_steal_rq_enabled; -struct pv_time_ops { - unsigned long long (*steal_clock)(int cpu); -}; - -struct paravirt_patch_template { - struct pv_time_ops time; -}; +u64 dummy_steal_clock(int cpu); -extern struct paravirt_patch_template pv_ops; +DECLARE_STATIC_CALL(pv_steal_clock, dummy_steal_clock); static inline u64 paravirt_steal_clock(int cpu) { - return pv_ops.time.steal_clock(cpu); + return static_call(pv_steal_clock)(cpu); } int __init pv_time_init(void); diff --git a/arch/arm64/kernel/paravirt.c b/arch/arm64/kernel/paravirt.c index c07d7a034941..75fed4460407 100644 --- a/arch/arm64/kernel/paravirt.c +++ b/arch/arm64/kernel/paravirt.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include @@ -26,8 +27,12 @@ struct static_key paravirt_steal_enabled; struct static_key paravirt_steal_rq_enabled; -struct paravirt_patch_template pv_ops; -EXPORT_SYMBOL_GPL(pv_ops); +static u64 native_steal_clock(int cpu) +{ + return 0; +} + +DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock); struct pv_time_stolen_time_region { struct pvclock_vcpu_stolen_time *kaddr; @@ -45,7 +50,7 @@ static int __init parse_no_stealacc(char *arg) early_param("no-steal-acc", parse_no_stealacc); /* return stolen time in ns by asking the hypervisor */ -static u64 pv_steal_clock(int cpu) +static u64 para_steal_clock(int cpu) { struct pv_time_stolen_time_region *reg; @@ -150,7 +155,7 @@ int __init pv_time_init(void) if (ret) return ret; - pv_ops.time.steal_clock = pv_steal_clock; + static_call_update(pv_steal_clock, para_steal_clock); static_key_slow_inc(¶virt_steal_enabled); if (steal_acc) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 2792879d398e..107acc403b3b 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -777,6 +777,7 @@ if HYPERVISOR_GUEST config PARAVIRT bool "Enable paravirtualization code" + depends on HAVE_STATIC_CALL help This changes the kernel so it can modify itself when it is run under a hypervisor, potentially improving performance significantly diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h index ccf60a809a17..e7be720062a8 100644 --- a/arch/x86/include/asm/mshyperv.h +++ b/arch/x86/include/asm/mshyperv.h @@ -63,7 +63,7 @@ typedef int (*hyperv_fill_flush_list_func)( static __always_inline void hv_setup_sched_clock(void *sched_clock) { #ifdef CONFIG_PARAVIRT - pv_ops.time.sched_clock = sched_clock; + paravirt_set_sched_clock(sched_clock); #endif } diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 4abf110e2243..1e45b46fae84 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -15,11 +15,22 @@ #include #include #include +#include #include -static inline unsigned long long paravirt_sched_clock(void) +u64 dummy_steal_clock(int cpu); +u64 dummy_sched_clock(void); + +DECLARE_STATIC_CALL(pv_steal_clock, dummy_steal_clock); +DECLARE_STATIC_CALL(pv_sched_clock, dummy_sched_clock); + +extern bool paravirt_using_native_sched_clock; + +void paravirt_set_sched_clock(u64 (*func)(void)); + +static inline u64 paravirt_sched_clock(void) { - return PVOP_CALL0(unsigned long long, time.sched_clock); + return static_call(pv_sched_clock)(); } struct static_key; @@ -33,7 +44,7 @@ bool pv_is_native_vcpu_is_preempted(void); static inline u64 paravirt_steal_clock(int cpu) { - return PVOP_CALL1(u64, time.steal_clock, cpu); + return static_call(pv_steal_clock)(cpu); } /* The paravirtualized I/O functions */ diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index de87087d3bde..1fff349e4792 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -95,11 +95,6 @@ struct pv_lazy_ops { } __no_randomize_layout; #endif -struct pv_time_ops { - unsigned long long (*sched_clock)(void); - unsigned long long (*steal_clock)(int cpu); -} __no_randomize_layout; - struct pv_cpu_ops { /* hooks for various privileged instructions */ void (*io_delay)(void); @@ -291,7 +286,6 @@ struct pv_lock_ops { * what to patch. */ struct paravirt_patch_template { struct pv_init_ops init; - struct pv_time_ops time; struct pv_cpu_ops cpu; struct pv_irq_ops irq; struct pv_mmu_ops mmu; diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index c6ede3b3d302..84fb8e3f3d1b 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #include #include @@ -336,11 +337,11 @@ static void __init vmware_paravirt_ops_setup(void) vmware_cyc2ns_setup(); if (vmw_sched_clock) - pv_ops.time.sched_clock = vmware_sched_clock; + paravirt_set_sched_clock(vmware_sched_clock); if (vmware_is_stealclock_available()) { has_steal_clock = true; - pv_ops.time.steal_clock = vmware_steal_clock; + static_call_update(pv_steal_clock, vmware_steal_clock); /* We use reboot notifier only to disable steal clock */ register_reboot_notifier(&vmware_pv_reboot_nb); diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 5e78e01ca3b4..351ba99f6009 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -650,7 +650,7 @@ static void __init kvm_guest_init(void) if (kvm_para_has_feature(KVM_FEATURE_STEAL_TIME)) { has_steal_clock = 1; - pv_ops.time.steal_clock = kvm_steal_clock; + static_call_update(pv_steal_clock, kvm_steal_clock); } if (pv_tlb_flush_supported()) { diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index aa593743acf6..01e7c1839ace 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -106,7 +106,7 @@ static inline void kvm_sched_clock_init(bool stable) if (!stable) clear_sched_clock_stable(); kvm_sched_clock_offset = kvm_clock_read(); - pv_ops.time.sched_clock = kvm_sched_clock_read; + paravirt_set_sched_clock(kvm_sched_clock_read); pr_info("kvm-clock: using sched offset of %llu cycles", kvm_sched_clock_offset); diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index c60222ab8ab9..44e5b0fe28cb 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include @@ -167,6 +168,17 @@ static u64 native_steal_clock(int cpu) return 0; } +DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock); +DEFINE_STATIC_CALL(pv_sched_clock, native_sched_clock); + +bool paravirt_using_native_sched_clock = true; + +void paravirt_set_sched_clock(u64 (*func)(void)) +{ + static_call_update(pv_sched_clock, func); + paravirt_using_native_sched_clock = (func == native_sched_clock); +} + /* These are in entry.S */ extern void native_iret(void); @@ -272,10 +284,6 @@ struct paravirt_patch_template pv_ops = { /* Init ops. */ .init.patch = native_patch, - /* Time ops. */ - .time.sched_clock = native_sched_clock, - .time.steal_clock = native_steal_clock, - /* Cpu ops. */ .cpu.io_delay = native_io_delay, diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index f70dffc2771f..b6f7853d8077 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -254,7 +254,7 @@ unsigned long long sched_clock(void) bool using_native_sched_clock(void) { - return pv_ops.time.sched_clock == native_sched_clock; + return paravirt_using_native_sched_clock; } #else unsigned long long diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 91f5b330dcc6..d9c945ee1100 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -379,11 +379,6 @@ void xen_timer_resume(void) } } -static const struct pv_time_ops xen_time_ops __initconst = { - .sched_clock = xen_sched_clock, - .steal_clock = xen_steal_clock, -}; - static struct pvclock_vsyscall_time_info *xen_clock __read_mostly; static u64 xen_clock_value_saved; @@ -525,17 +520,24 @@ static void __init xen_time_init(void) pvclock_gtod_register_notifier(&xen_pvclock_gtod_notifier); } -void __init xen_init_time_ops(void) +static void __init xen_init_time_common(void) { xen_sched_clock_offset = xen_clocksource_read(); - pv_ops.time = xen_time_ops; + static_call_update(pv_steal_clock, xen_steal_clock); + paravirt_set_sched_clock(xen_sched_clock); + + x86_platform.calibrate_tsc = xen_tsc_khz; + x86_platform.get_wallclock = xen_get_wallclock; +} + +void __init xen_init_time_ops(void) +{ + xen_init_time_common(); x86_init.timers.timer_init = xen_time_init; x86_init.timers.setup_percpu_clockev = x86_init_noop; x86_cpuinit.setup_percpu_clockev = x86_init_noop; - x86_platform.calibrate_tsc = xen_tsc_khz; - x86_platform.get_wallclock = xen_get_wallclock; /* Dom0 uses the native method to set the hardware RTC. */ if (!xen_initial_domain()) x86_platform.set_wallclock = xen_set_wallclock; @@ -569,13 +571,11 @@ void __init xen_hvm_init_time_ops(void) return; } - xen_sched_clock_offset = xen_clocksource_read(); - pv_ops.time = xen_time_ops; + xen_init_time_common(); + x86_init.timers.setup_percpu_clockev = xen_time_init; x86_cpuinit.setup_percpu_clockev = xen_hvm_setup_cpu_clockevents; - x86_platform.calibrate_tsc = xen_tsc_khz; - x86_platform.get_wallclock = xen_get_wallclock; x86_platform.set_wallclock = xen_set_wallclock; } #endif diff --git a/drivers/xen/time.c b/drivers/xen/time.c index 108edbcbc040..152dd33bb223 100644 --- a/drivers/xen/time.c +++ b/drivers/xen/time.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include @@ -175,7 +176,7 @@ void __init xen_time_setup_guest(void) xen_runstate_remote = !HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_runstate_update_flag); - pv_ops.time.steal_clock = xen_steal_clock; + static_call_update(pv_steal_clock, xen_steal_clock); static_key_slow_inc(¶virt_steal_enabled); if (xen_runstate_remote) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:48:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:48:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95417.180132 (Exim 4.92) (envelope-from ) id 1lJciu-00049p-5b; Tue, 09 Mar 2021 13:48:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95417.180132; Tue, 09 Mar 2021 13:48:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJciu-00049h-27; Tue, 09 Mar 2021 13:48:32 +0000 Received: by outflank-mailman (input) for mailman id 95417; Tue, 09 Mar 2021 13:48:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcis-0003yx-NH for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:48:30 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ec89891a-0a5e-4e15-99c8-ae0ab6b17ee0; Tue, 09 Mar 2021 13:48:21 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0AF6AAD21; Tue, 9 Mar 2021 13:48:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec89891a-0a5e-4e15-99c8-ae0ab6b17ee0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615297700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0e7+n4ARWdqAf9kOF5ZbkKtS2O6P/zi/dz62g/QYJCc=; b=V3TyEnEU5ipGNiTSmDgJ2rmIt6HRyJOTGDNIO5tZNNe7U09YbRbKoYZoHTEKiCVG6wcHj8 henyZIRI98T0ylNBLVdW7651+EpwPKYUAile39ispgMx+AzU2cTWcMBlJYMKibDAkWvarA IgoKvO9csltNFGy3SNFQ/FVCNGIb2Ys= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Peter Zijlstra Subject: [PATCH v6 03/12] x86/alternative: drop feature parameter from ALTINSTR_REPLACEMENT() Date: Tue, 9 Mar 2021 14:48:04 +0100 Message-Id: <20210309134813.23912-4-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309134813.23912-1-jgross@suse.com> References: <20210309134813.23912-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The macro ALTINSTR_REPLACEMENT() doesn't make use of the feature parameter, so drop it. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V5: - new patch --- arch/x86/include/asm/alternative.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h index 13adca37c99a..5753fb2ac489 100644 --- a/arch/x86/include/asm/alternative.h +++ b/arch/x86/include/asm/alternative.h @@ -150,7 +150,7 @@ static inline int alternatives_text_reserved(void *start, void *end) " .byte " alt_rlen(num) "\n" /* replacement len */ \ " .byte " alt_pad_len "\n" /* pad len */ -#define ALTINSTR_REPLACEMENT(newinstr, feature, num) /* replacement */ \ +#define ALTINSTR_REPLACEMENT(newinstr, num) /* replacement */ \ "# ALT: replacement " #num "\n" \ b_replacement(num)":\n\t" newinstr "\n" e_replacement(num) ":\n" @@ -161,7 +161,7 @@ static inline int alternatives_text_reserved(void *start, void *end) ALTINSTR_ENTRY(feature, 1) \ ".popsection\n" \ ".pushsection .altinstr_replacement, \"ax\"\n" \ - ALTINSTR_REPLACEMENT(newinstr, feature, 1) \ + ALTINSTR_REPLACEMENT(newinstr, 1) \ ".popsection\n" #define ALTERNATIVE_2(oldinstr, newinstr1, feature1, newinstr2, feature2)\ @@ -171,8 +171,8 @@ static inline int alternatives_text_reserved(void *start, void *end) ALTINSTR_ENTRY(feature2, 2) \ ".popsection\n" \ ".pushsection .altinstr_replacement, \"ax\"\n" \ - ALTINSTR_REPLACEMENT(newinstr1, feature1, 1) \ - ALTINSTR_REPLACEMENT(newinstr2, feature2, 2) \ + ALTINSTR_REPLACEMENT(newinstr1, 1) \ + ALTINSTR_REPLACEMENT(newinstr2, 2) \ ".popsection\n" #define ALTERNATIVE_3(oldinsn, newinsn1, feat1, newinsn2, feat2, newinsn3, feat3) \ @@ -183,9 +183,9 @@ static inline int alternatives_text_reserved(void *start, void *end) ALTINSTR_ENTRY(feat3, 3) \ ".popsection\n" \ ".pushsection .altinstr_replacement, \"ax\"\n" \ - ALTINSTR_REPLACEMENT(newinsn1, feat1, 1) \ - ALTINSTR_REPLACEMENT(newinsn2, feat2, 2) \ - ALTINSTR_REPLACEMENT(newinsn3, feat3, 3) \ + ALTINSTR_REPLACEMENT(newinsn1, 1) \ + ALTINSTR_REPLACEMENT(newinsn2, 2) \ + ALTINSTR_REPLACEMENT(newinsn3, 3) \ ".popsection\n" /* -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:48:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:48:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95418.180144 (Exim 4.92) (envelope-from ) id 1lJciv-0004CV-HY; Tue, 09 Mar 2021 13:48:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95418.180144; Tue, 09 Mar 2021 13:48:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJciv-0004CK-DC; Tue, 09 Mar 2021 13:48:33 +0000 Received: by outflank-mailman (input) for mailman id 95418; Tue, 09 Mar 2021 13:48:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJciu-0003zp-CN for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:48:32 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6611fa41-fc76-4c14-9eac-f61277ac5f51; Tue, 09 Mar 2021 13:48:21 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D4740AD74; Tue, 9 Mar 2021 13:48:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6611fa41-fc76-4c14-9eac-f61277ac5f51 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615297701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aUHzGwqz0II+9OmUPwKiXvy4xFpuO+aWkbUyFgMhpn4=; b=Kvnh9ke6uXQ6WUSVvBkHDko+S9V0vfOLvEEH3PcquoQVgwZSlML511UhxOiEmDYe3Ejvka aza3jr55fT9zDC4FNvGaUAIOTdS/byeEzVc74enPxssM7otKd2X3j9vj7OIB647EdjPOT5 Qiguuse/txToiZBaQGrwFbE0VhDf/xg= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Deep Shah , "VMware, Inc." , Peter Zijlstra Subject: [PATCH v6 06/12] x86: add new features for paravirt patching Date: Tue, 9 Mar 2021 14:48:07 +0100 Message-Id: <20210309134813.23912-7-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309134813.23912-1-jgross@suse.com> References: <20210309134813.23912-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit For being able to switch paravirt patching from special cased custom code sequences to ALTERNATIVE handling some X86_FEATURE_* are needed as new features. This enables to have the standard indirect pv call as the default code and to patch that with the non-Xen custom code sequence via ALTERNATIVE patching later. Make sure paravirt patching is performed before alternative patching. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V3: - add comment (Boris Petkov) - no negative features (Boris Petkov) V4: - move paravirt_set_cap() to paravirt-spinlocks.c --- arch/x86/include/asm/cpufeatures.h | 2 ++ arch/x86/include/asm/paravirt.h | 10 ++++++++++ arch/x86/kernel/alternative.c | 30 ++++++++++++++++++++++++++-- arch/x86/kernel/paravirt-spinlocks.c | 9 +++++++++ 4 files changed, 49 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h index cc96e26d69f7..b440c950246d 100644 --- a/arch/x86/include/asm/cpufeatures.h +++ b/arch/x86/include/asm/cpufeatures.h @@ -236,6 +236,8 @@ #define X86_FEATURE_EPT_AD ( 8*32+17) /* Intel Extended Page Table access-dirty bit */ #define X86_FEATURE_VMCALL ( 8*32+18) /* "" Hypervisor supports the VMCALL instruction */ #define X86_FEATURE_VMW_VMMCALL ( 8*32+19) /* "" VMware prefers VMMCALL hypercall instruction */ +#define X86_FEATURE_PVUNLOCK ( 8*32+20) /* "" PV unlock function */ +#define X86_FEATURE_VCPUPREEMPT ( 8*32+21) /* "" PV vcpu_is_preempted function */ /* Intel-defined CPU features, CPUID level 0x00000007:0 (EBX), word 9 */ #define X86_FEATURE_FSGSBASE ( 9*32+ 0) /* RDFSBASE, WRFSBASE, RDGSBASE, WRGSBASE instructions*/ diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 1e45b46fae84..8c354099d9c3 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -47,6 +47,10 @@ static inline u64 paravirt_steal_clock(int cpu) return static_call(pv_steal_clock)(cpu); } +#ifdef CONFIG_PARAVIRT_SPINLOCKS +void __init paravirt_set_cap(void); +#endif + /* The paravirtualized I/O functions */ static inline void slow_down_io(void) { @@ -811,5 +815,11 @@ static inline void paravirt_arch_exit_mmap(struct mm_struct *mm) { } #endif + +#ifndef CONFIG_PARAVIRT_SPINLOCKS +static inline void paravirt_set_cap(void) +{ +} +#endif #endif /* __ASSEMBLY__ */ #endif /* _ASM_X86_PARAVIRT_H */ diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index d8e669a1546f..1f12901e75f2 100644 --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -28,6 +28,7 @@ #include #include #include +#include int __read_mostly alternatives_patched; @@ -732,6 +733,33 @@ void __init alternative_instructions(void) * patching. */ + /* + * Paravirt patching and alternative patching can be combined to + * replace a function call with a short direct code sequence (e.g. + * by setting a constant return value instead of doing that in an + * external function). + * In order to make this work the following sequence is required: + * 1. set (artificial) features depending on used paravirt + * functions which can later influence alternative patching + * 2. apply paravirt patching (generally replacing an indirect + * function call with a direct one) + * 3. apply alternative patching (e.g. replacing a direct function + * call with a custom code sequence) + * Doing paravirt patching after alternative patching would clobber + * the optimization of the custom code with a function call again. + */ + paravirt_set_cap(); + + /* + * First patch paravirt functions, such that we overwrite the indirect + * call with the direct call. + */ + apply_paravirt(__parainstructions, __parainstructions_end); + + /* + * Then patch alternatives, such that those paravirt calls that are in + * alternatives can be overwritten by their immediate fragments. + */ apply_alternatives(__alt_instructions, __alt_instructions_end); #ifdef CONFIG_SMP @@ -750,8 +778,6 @@ void __init alternative_instructions(void) } #endif - apply_paravirt(__parainstructions, __parainstructions_end); - restart_nmi(); alternatives_patched = 1; } diff --git a/arch/x86/kernel/paravirt-spinlocks.c b/arch/x86/kernel/paravirt-spinlocks.c index 4f75d0cf6305..9e1ea99ad9df 100644 --- a/arch/x86/kernel/paravirt-spinlocks.c +++ b/arch/x86/kernel/paravirt-spinlocks.c @@ -32,3 +32,12 @@ bool pv_is_native_vcpu_is_preempted(void) return pv_ops.lock.vcpu_is_preempted.func == __raw_callee_save___native_vcpu_is_preempted; } + +void __init paravirt_set_cap(void) +{ + if (!pv_is_native_spin_unlock()) + setup_force_cpu_cap(X86_FEATURE_PVUNLOCK); + + if (!pv_is_native_vcpu_is_preempted()) + setup_force_cpu_cap(X86_FEATURE_VCPUPREEMPT); +} -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:48:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:48:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95419.180155 (Exim 4.92) (envelope-from ) id 1lJciz-0004In-4c; Tue, 09 Mar 2021 13:48:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95419.180155; Tue, 09 Mar 2021 13:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJciz-0004Ic-0g; Tue, 09 Mar 2021 13:48:37 +0000 Received: by outflank-mailman (input) for mailman id 95419; Tue, 09 Mar 2021 13:48:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcix-0003yx-NJ for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:48:35 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ec7aebdb-f7ef-4251-b419-f37fecb6d632; Tue, 09 Mar 2021 13:48:21 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7D9E4AD73; Tue, 9 Mar 2021 13:48:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec7aebdb-f7ef-4251-b419-f37fecb6d632 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615297700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gRGAbVR+8Mnnt7NDHm7B8xvG2OtdGz+E1qKK/7NsSt0=; b=MRIb7zVmGu6NutqWwIyJg9GRHrMVUFvhJWF/PIfZSZoV3ucw7PhypfxfxYwb3FsfCbbjlh HgMdGby6x+WbX0JzblobosedkjGcdBkP9mZGrLv8ryZg6K7aS+5YfbkCKSTkNuYM4bcQwN wIP3sXBnw1bM2AVQ6rdSpJy7iH4M4iw= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Peter Zijlstra Subject: [PATCH v6 05/12] x86/alternative: support ALTERNATIVE_TERNARY Date: Tue, 9 Mar 2021 14:48:06 +0100 Message-Id: <20210309134813.23912-6-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309134813.23912-1-jgross@suse.com> References: <20210309134813.23912-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add ALTERNATIVE_TERNARY support for replacing an initial instruction with either of two instructions depending on a feature: ALTERNATIVE_TERNARY "default_instr", FEATURE_NR, "feature_on_instr", "feature_off_instr" which will start with "default_instr" and at patch time will, depending on FEATURE_NR being set or not, patch that with either "feature_on_instr" or "feature_off_instr". Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V3: - new patch V4: - use X86_FEATURE_ALWAYS instead of negated feature (Boris Petkov) - unfortunately this isn't enough to get rid of the "not feature" support, as this is needed in the patch "x86/paravirt: switch functions with custom code to ALTERNATIVE", too V5: - carve out the "not feature" part --- arch/x86/include/asm/alternative-asm.h | 4 ++++ arch/x86/include/asm/alternative.h | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/arch/x86/include/asm/alternative-asm.h b/arch/x86/include/asm/alternative-asm.h index 3965daf0460e..80bc6b533358 100644 --- a/arch/x86/include/asm/alternative-asm.h +++ b/arch/x86/include/asm/alternative-asm.h @@ -112,6 +112,10 @@ .popsection .endm +#define ALTERNATIVE_TERNARY(oldinstr, feature, newinstr1, newinstr2) \ + ALTERNATIVE_2 oldinstr, newinstr2, X86_FEATURE_ALWAYS, \ + newinstr1, feature + #endif /* __ASSEMBLY__ */ #endif /* _ASM_X86_ALTERNATIVE_ASM_H */ diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h index 89889618ae01..4fb844e29d26 100644 --- a/arch/x86/include/asm/alternative.h +++ b/arch/x86/include/asm/alternative.h @@ -178,6 +178,9 @@ static inline int alternatives_text_reserved(void *start, void *end) ALTINSTR_REPLACEMENT(newinstr2, 2) \ ".popsection\n" +#define ALTERNATIVE_TERNARY(oldinstr, feature, newinstr1, newinstr2) \ + ALTERNATIVE_2(oldinstr, newinstr2, X86_FEATURE_ALWAYS, newinstr1, feature) + #define ALTERNATIVE_3(oldinsn, newinsn1, feat1, newinsn2, feat2, newinsn3, feat3) \ OLDINSTR_3(oldinsn, 1, 2, 3) \ ".pushsection .altinstructions,\"a\"\n" \ @@ -209,6 +212,9 @@ static inline int alternatives_text_reserved(void *start, void *end) #define alternative_2(oldinstr, newinstr1, feature1, newinstr2, feature2) \ asm_inline volatile(ALTERNATIVE_2(oldinstr, newinstr1, feature1, newinstr2, feature2) ::: "memory") +#define alternative_ternary(oldinstr, feature, newinstr1, newinstr2) \ + asm_inline volatile(ALTERNATIVE_TERNARY(oldinstr, feature, newinstr1, newinstr2) ::: "memory") + /* * Alternative inline assembly with input. * -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:48:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:48:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95420.180168 (Exim 4.92) (envelope-from ) id 1lJcj1-0004NY-JX; Tue, 09 Mar 2021 13:48:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95420.180168; Tue, 09 Mar 2021 13:48:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcj1-0004NN-Di; Tue, 09 Mar 2021 13:48:39 +0000 Received: by outflank-mailman (input) for mailman id 95420; Tue, 09 Mar 2021 13:48:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJciz-0003zp-Cg for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:48:37 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c3c81466-3430-43fb-876d-bd29f7294168; Tue, 09 Mar 2021 13:48:22 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8F94AADCD; Tue, 9 Mar 2021 13:48:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3c81466-3430-43fb-876d-bd29f7294168 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615297701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Oc97+qf4A0YSsFztEucEY2JDBPPlEsNort962uFLwIM=; b=ry6NxALgwZrH3BecWTO0caGbUYi2TBb/FihR4AfMIel2IJT6oxtWixE8hZqPh2gtWWg+iY nqVl433XXa7PQbBwjB4P6Sao/7nGhbuuOAz8SuLwBHZOgIeUP16yYZDGvOGIwGCx3YfteO DaLZZ42vtb+7pP2dvzqkDlL36c2vzbQ= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Nathan Chancellor , Nick Desaulniers , Peter Zijlstra Subject: [PATCH v6 08/12] x86/paravirt: simplify paravirt macros Date: Tue, 9 Mar 2021 14:48:09 +0100 Message-Id: <20210309134813.23912-9-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309134813.23912-1-jgross@suse.com> References: <20210309134813.23912-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The central pvops call macros ____PVOP_CALL() and ____PVOP_VCALL() are looking very similar now. The main differences are using PVOP_VCALL_ARGS or PVOP_CALL_ARGS, which are identical, and the return value handling. So drop PVOP_VCALL_ARGS and instead of ____PVOP_VCALL() just use (void)____PVOP_CALL(long, ...). Note that it isn't easily possible to just redefine ____PVOP_VCALL() to use ____PVOP_CALL() instead, as this would require further hiding of commas in macro parameters. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V3: - new patch V4: - fix build warnings with clang (kernel test robot) --- arch/x86/include/asm/paravirt_types.h | 41 ++++++++------------------- 1 file changed, 12 insertions(+), 29 deletions(-) diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 42f9eef84131..45bd21647dd8 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -408,11 +408,9 @@ int paravirt_disable_iospace(void); * makes sure the incoming and outgoing types are always correct. */ #ifdef CONFIG_X86_32 -#define PVOP_VCALL_ARGS \ +#define PVOP_CALL_ARGS \ unsigned long __eax = __eax, __edx = __edx, __ecx = __ecx; -#define PVOP_CALL_ARGS PVOP_VCALL_ARGS - #define PVOP_CALL_ARG1(x) "a" ((unsigned long)(x)) #define PVOP_CALL_ARG2(x) "d" ((unsigned long)(x)) #define PVOP_CALL_ARG3(x) "c" ((unsigned long)(x)) @@ -428,12 +426,10 @@ int paravirt_disable_iospace(void); #define VEXTRA_CLOBBERS #else /* CONFIG_X86_64 */ /* [re]ax isn't an arg, but the return val */ -#define PVOP_VCALL_ARGS \ +#define PVOP_CALL_ARGS \ unsigned long __edi = __edi, __esi = __esi, \ __edx = __edx, __ecx = __ecx, __eax = __eax; -#define PVOP_CALL_ARGS PVOP_VCALL_ARGS - #define PVOP_CALL_ARG1(x) "D" ((unsigned long)(x)) #define PVOP_CALL_ARG2(x) "S" ((unsigned long)(x)) #define PVOP_CALL_ARG3(x) "d" ((unsigned long)(x)) @@ -458,59 +454,46 @@ int paravirt_disable_iospace(void); #define PVOP_TEST_NULL(op) ((void)pv_ops.op) #endif -#define PVOP_RETMASK(rettype) \ +#define PVOP_RETVAL(rettype) \ ({ unsigned long __mask = ~0UL; \ + BUILD_BUG_ON(sizeof(rettype) > sizeof(unsigned long)); \ switch (sizeof(rettype)) { \ case 1: __mask = 0xffUL; break; \ case 2: __mask = 0xffffUL; break; \ case 4: __mask = 0xffffffffUL; break; \ default: break; \ } \ - __mask; \ + __mask & __eax; \ }) -#define ____PVOP_CALL(rettype, op, clbr, call_clbr, extra_clbr, ...) \ +#define ____PVOP_CALL(ret, op, clbr, call_clbr, extra_clbr, ...) \ ({ \ PVOP_CALL_ARGS; \ PVOP_TEST_NULL(op); \ - BUILD_BUG_ON(sizeof(rettype) > sizeof(unsigned long)); \ asm volatile(paravirt_alt(PARAVIRT_CALL) \ : call_clbr, ASM_CALL_CONSTRAINT \ : paravirt_type(op), \ paravirt_clobber(clbr), \ ##__VA_ARGS__ \ : "memory", "cc" extra_clbr); \ - (rettype)(__eax & PVOP_RETMASK(rettype)); \ + ret; \ }) #define __PVOP_CALL(rettype, op, ...) \ - ____PVOP_CALL(rettype, op, CLBR_ANY, PVOP_CALL_CLOBBERS, \ - EXTRA_CLOBBERS, ##__VA_ARGS__) + ____PVOP_CALL(PVOP_RETVAL(rettype), op, CLBR_ANY, \ + PVOP_CALL_CLOBBERS, EXTRA_CLOBBERS, ##__VA_ARGS__) #define __PVOP_CALLEESAVE(rettype, op, ...) \ - ____PVOP_CALL(rettype, op.func, CLBR_RET_REG, \ + ____PVOP_CALL(PVOP_RETVAL(rettype), op.func, CLBR_RET_REG, \ PVOP_CALLEE_CLOBBERS, , ##__VA_ARGS__) - -#define ____PVOP_VCALL(op, clbr, call_clbr, extra_clbr, ...) \ - ({ \ - PVOP_VCALL_ARGS; \ - PVOP_TEST_NULL(op); \ - asm volatile(paravirt_alt(PARAVIRT_CALL) \ - : call_clbr, ASM_CALL_CONSTRAINT \ - : paravirt_type(op), \ - paravirt_clobber(clbr), \ - ##__VA_ARGS__ \ - : "memory", "cc" extra_clbr); \ - }) - #define __PVOP_VCALL(op, ...) \ - ____PVOP_VCALL(op, CLBR_ANY, PVOP_VCALL_CLOBBERS, \ + (void)____PVOP_CALL(, op, CLBR_ANY, PVOP_VCALL_CLOBBERS, \ VEXTRA_CLOBBERS, ##__VA_ARGS__) #define __PVOP_VCALLEESAVE(op, ...) \ - ____PVOP_VCALL(op.func, CLBR_RET_REG, \ + (void)____PVOP_CALL(, op.func, CLBR_RET_REG, \ PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:48:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:48:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95421.180180 (Exim 4.92) (envelope-from ) id 1lJcj4-0004SE-0T; Tue, 09 Mar 2021 13:48:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95421.180180; Tue, 09 Mar 2021 13:48:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcj3-0004Ry-Rk; Tue, 09 Mar 2021 13:48:41 +0000 Received: by outflank-mailman (input) for mailman id 95421; Tue, 09 Mar 2021 13:48:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcj2-0003yx-NL for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:48:40 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b149e1b3-92d1-4f31-a23a-5eda6da563b0; Tue, 09 Mar 2021 13:48:22 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2EAD9AD87; Tue, 9 Mar 2021 13:48:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b149e1b3-92d1-4f31-a23a-5eda6da563b0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615297701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5dCx1fNhYw/V2GNDtlKOZ+uXJwV9FmyavLSGcVpyYJ4=; b=jgUb85x64FRRB4cDriZUvNgADkzS4yVinwKcurAHPtS4uV1oxlvY4yG8qeOY48Yhv7sD3e hEIzqzop6CcSZ8Kk9a3EWplU9JTedG+IInK+Q/f6ozSCAGnR7Y1EOUBDJH6+zFMBcL06+8 esrjsuH5Wgxt97nENB+wdDKdiJg/+Ns= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Juergen Gross , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Deep Shah , "VMware, Inc." , Peter Zijlstra Subject: [PATCH v6 07/12] x86/paravirt: remove no longer needed 32-bit pvops cruft Date: Tue, 9 Mar 2021 14:48:08 +0100 Message-Id: <20210309134813.23912-8-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309134813.23912-1-jgross@suse.com> References: <20210309134813.23912-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PVOP_VCALL4() is only used for Xen PV, while PVOP_CALL4() isn't used at all. Keep PVOP_CALL4() for 64 bits due to symmetry reasons. This allows to remove the 32-bit definitions of those macros leading to a substantial simplification of the paravirt macros, as those were the only ones needing non-empty "pre" and "post" parameters. PVOP_CALLEE2() and PVOP_VCALLEE2() are used nowhere, so remove them. Another no longer needed case is special handling of return types larger than unsigned long. Replace that with a BUILD_BUG_ON(). DISABLE_INTERRUPTS() is used in 32-bit code only, so it can just be replaced by cli. INTERRUPT_RETURN in 32-bit code can be replaced by iret. ENABLE_INTERRUPTS is used nowhere, so it can be removed. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- arch/x86/entry/entry_32.S | 4 +- arch/x86/include/asm/irqflags.h | 5 -- arch/x86/include/asm/paravirt.h | 35 +------- arch/x86/include/asm/paravirt_types.h | 112 ++++++++------------------ arch/x86/kernel/asm-offsets.c | 2 - 5 files changed, 35 insertions(+), 123 deletions(-) diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S index df8c017e6161..765487e57d6e 100644 --- a/arch/x86/entry/entry_32.S +++ b/arch/x86/entry/entry_32.S @@ -430,7 +430,7 @@ * will soon execute iret and the tracer was already set to * the irqstate after the IRET: */ - DISABLE_INTERRUPTS(CLBR_ANY) + cli lss (%esp), %esp /* switch to espfix segment */ .Lend_\@: #endif /* CONFIG_X86_ESPFIX32 */ @@ -1077,7 +1077,7 @@ restore_all_switch_stack: * when returning from IPI handler and when returning from * scheduler to user-space. */ - INTERRUPT_RETURN + iret .section .fixup, "ax" SYM_CODE_START(asm_iret_error) diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h index 144d70ea4393..a0efbcd24b86 100644 --- a/arch/x86/include/asm/irqflags.h +++ b/arch/x86/include/asm/irqflags.h @@ -109,9 +109,6 @@ static __always_inline unsigned long arch_local_irq_save(void) } #else -#define ENABLE_INTERRUPTS(x) sti -#define DISABLE_INTERRUPTS(x) cli - #ifdef CONFIG_X86_64 #ifdef CONFIG_DEBUG_ENTRY #define SAVE_FLAGS(x) pushfq; popq %rax @@ -119,8 +116,6 @@ static __always_inline unsigned long arch_local_irq_save(void) #define INTERRUPT_RETURN jmp native_iret -#else -#define INTERRUPT_RETURN iret #endif #endif /* __ASSEMBLY__ */ diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 8c354099d9c3..c6496a82fad1 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -721,6 +721,7 @@ extern void default_banner(void); .if ((~(set)) & mask); pop %reg; .endif #ifdef CONFIG_X86_64 +#ifdef CONFIG_PARAVIRT_XXL #define PV_SAVE_REGS(set) \ COND_PUSH(set, CLBR_RAX, rax); \ @@ -746,46 +747,12 @@ extern void default_banner(void); #define PARA_PATCH(off) ((off) / 8) #define PARA_SITE(ptype, ops) _PVSITE(ptype, ops, .quad, 8) #define PARA_INDIRECT(addr) *addr(%rip) -#else -#define PV_SAVE_REGS(set) \ - COND_PUSH(set, CLBR_EAX, eax); \ - COND_PUSH(set, CLBR_EDI, edi); \ - COND_PUSH(set, CLBR_ECX, ecx); \ - COND_PUSH(set, CLBR_EDX, edx) -#define PV_RESTORE_REGS(set) \ - COND_POP(set, CLBR_EDX, edx); \ - COND_POP(set, CLBR_ECX, ecx); \ - COND_POP(set, CLBR_EDI, edi); \ - COND_POP(set, CLBR_EAX, eax) - -#define PARA_PATCH(off) ((off) / 4) -#define PARA_SITE(ptype, ops) _PVSITE(ptype, ops, .long, 4) -#define PARA_INDIRECT(addr) *%cs:addr -#endif -#ifdef CONFIG_PARAVIRT_XXL #define INTERRUPT_RETURN \ PARA_SITE(PARA_PATCH(PV_CPU_iret), \ ANNOTATE_RETPOLINE_SAFE; \ jmp PARA_INDIRECT(pv_ops+PV_CPU_iret);) -#define DISABLE_INTERRUPTS(clobbers) \ - PARA_SITE(PARA_PATCH(PV_IRQ_irq_disable), \ - PV_SAVE_REGS(clobbers | CLBR_CALLEE_SAVE); \ - ANNOTATE_RETPOLINE_SAFE; \ - call PARA_INDIRECT(pv_ops+PV_IRQ_irq_disable); \ - PV_RESTORE_REGS(clobbers | CLBR_CALLEE_SAVE);) - -#define ENABLE_INTERRUPTS(clobbers) \ - PARA_SITE(PARA_PATCH(PV_IRQ_irq_enable), \ - PV_SAVE_REGS(clobbers | CLBR_CALLEE_SAVE); \ - ANNOTATE_RETPOLINE_SAFE; \ - call PARA_INDIRECT(pv_ops+PV_IRQ_irq_enable); \ - PV_RESTORE_REGS(clobbers | CLBR_CALLEE_SAVE);) -#endif - -#ifdef CONFIG_X86_64 -#ifdef CONFIG_PARAVIRT_XXL #ifdef CONFIG_DEBUG_ENTRY #define SAVE_FLAGS(clobbers) \ PARA_SITE(PARA_PATCH(PV_IRQ_save_fl), \ diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 1fff349e4792..42f9eef84131 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -470,55 +470,34 @@ int paravirt_disable_iospace(void); }) -#define ____PVOP_CALL(rettype, op, clbr, call_clbr, extra_clbr, \ - pre, post, ...) \ +#define ____PVOP_CALL(rettype, op, clbr, call_clbr, extra_clbr, ...) \ ({ \ - rettype __ret; \ PVOP_CALL_ARGS; \ PVOP_TEST_NULL(op); \ - /* This is 32-bit specific, but is okay in 64-bit */ \ - /* since this condition will never hold */ \ - if (sizeof(rettype) > sizeof(unsigned long)) { \ - asm volatile(pre \ - paravirt_alt(PARAVIRT_CALL) \ - post \ - : call_clbr, ASM_CALL_CONSTRAINT \ - : paravirt_type(op), \ - paravirt_clobber(clbr), \ - ##__VA_ARGS__ \ - : "memory", "cc" extra_clbr); \ - __ret = (rettype)((((u64)__edx) << 32) | __eax); \ - } else { \ - asm volatile(pre \ - paravirt_alt(PARAVIRT_CALL) \ - post \ - : call_clbr, ASM_CALL_CONSTRAINT \ - : paravirt_type(op), \ - paravirt_clobber(clbr), \ - ##__VA_ARGS__ \ - : "memory", "cc" extra_clbr); \ - __ret = (rettype)(__eax & PVOP_RETMASK(rettype)); \ - } \ - __ret; \ + BUILD_BUG_ON(sizeof(rettype) > sizeof(unsigned long)); \ + asm volatile(paravirt_alt(PARAVIRT_CALL) \ + : call_clbr, ASM_CALL_CONSTRAINT \ + : paravirt_type(op), \ + paravirt_clobber(clbr), \ + ##__VA_ARGS__ \ + : "memory", "cc" extra_clbr); \ + (rettype)(__eax & PVOP_RETMASK(rettype)); \ }) -#define __PVOP_CALL(rettype, op, pre, post, ...) \ +#define __PVOP_CALL(rettype, op, ...) \ ____PVOP_CALL(rettype, op, CLBR_ANY, PVOP_CALL_CLOBBERS, \ - EXTRA_CLOBBERS, pre, post, ##__VA_ARGS__) + EXTRA_CLOBBERS, ##__VA_ARGS__) -#define __PVOP_CALLEESAVE(rettype, op, pre, post, ...) \ +#define __PVOP_CALLEESAVE(rettype, op, ...) \ ____PVOP_CALL(rettype, op.func, CLBR_RET_REG, \ - PVOP_CALLEE_CLOBBERS, , \ - pre, post, ##__VA_ARGS__) + PVOP_CALLEE_CLOBBERS, , ##__VA_ARGS__) -#define ____PVOP_VCALL(op, clbr, call_clbr, extra_clbr, pre, post, ...) \ +#define ____PVOP_VCALL(op, clbr, call_clbr, extra_clbr, ...) \ ({ \ PVOP_VCALL_ARGS; \ PVOP_TEST_NULL(op); \ - asm volatile(pre \ - paravirt_alt(PARAVIRT_CALL) \ - post \ + asm volatile(paravirt_alt(PARAVIRT_CALL) \ : call_clbr, ASM_CALL_CONSTRAINT \ : paravirt_type(op), \ paravirt_clobber(clbr), \ @@ -526,84 +505,57 @@ int paravirt_disable_iospace(void); : "memory", "cc" extra_clbr); \ }) -#define __PVOP_VCALL(op, pre, post, ...) \ +#define __PVOP_VCALL(op, ...) \ ____PVOP_VCALL(op, CLBR_ANY, PVOP_VCALL_CLOBBERS, \ - VEXTRA_CLOBBERS, \ - pre, post, ##__VA_ARGS__) + VEXTRA_CLOBBERS, ##__VA_ARGS__) -#define __PVOP_VCALLEESAVE(op, pre, post, ...) \ +#define __PVOP_VCALLEESAVE(op, ...) \ ____PVOP_VCALL(op.func, CLBR_RET_REG, \ - PVOP_VCALLEE_CLOBBERS, , \ - pre, post, ##__VA_ARGS__) + PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) #define PVOP_CALL0(rettype, op) \ - __PVOP_CALL(rettype, op, "", "") + __PVOP_CALL(rettype, op) #define PVOP_VCALL0(op) \ - __PVOP_VCALL(op, "", "") + __PVOP_VCALL(op) #define PVOP_CALLEE0(rettype, op) \ - __PVOP_CALLEESAVE(rettype, op, "", "") + __PVOP_CALLEESAVE(rettype, op) #define PVOP_VCALLEE0(op) \ - __PVOP_VCALLEESAVE(op, "", "") + __PVOP_VCALLEESAVE(op) #define PVOP_CALL1(rettype, op, arg1) \ - __PVOP_CALL(rettype, op, "", "", PVOP_CALL_ARG1(arg1)) + __PVOP_CALL(rettype, op, PVOP_CALL_ARG1(arg1)) #define PVOP_VCALL1(op, arg1) \ - __PVOP_VCALL(op, "", "", PVOP_CALL_ARG1(arg1)) + __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1)) #define PVOP_CALLEE1(rettype, op, arg1) \ - __PVOP_CALLEESAVE(rettype, op, "", "", PVOP_CALL_ARG1(arg1)) + __PVOP_CALLEESAVE(rettype, op, PVOP_CALL_ARG1(arg1)) #define PVOP_VCALLEE1(op, arg1) \ - __PVOP_VCALLEESAVE(op, "", "", PVOP_CALL_ARG1(arg1)) + __PVOP_VCALLEESAVE(op, PVOP_CALL_ARG1(arg1)) #define PVOP_CALL2(rettype, op, arg1, arg2) \ - __PVOP_CALL(rettype, op, "", "", PVOP_CALL_ARG1(arg1), \ - PVOP_CALL_ARG2(arg2)) + __PVOP_CALL(rettype, op, PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2)) #define PVOP_VCALL2(op, arg1, arg2) \ - __PVOP_VCALL(op, "", "", PVOP_CALL_ARG1(arg1), \ - PVOP_CALL_ARG2(arg2)) - -#define PVOP_CALLEE2(rettype, op, arg1, arg2) \ - __PVOP_CALLEESAVE(rettype, op, "", "", PVOP_CALL_ARG1(arg1), \ - PVOP_CALL_ARG2(arg2)) -#define PVOP_VCALLEE2(op, arg1, arg2) \ - __PVOP_VCALLEESAVE(op, "", "", PVOP_CALL_ARG1(arg1), \ - PVOP_CALL_ARG2(arg2)) - + __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2)) #define PVOP_CALL3(rettype, op, arg1, arg2, arg3) \ - __PVOP_CALL(rettype, op, "", "", PVOP_CALL_ARG1(arg1), \ + __PVOP_CALL(rettype, op, PVOP_CALL_ARG1(arg1), \ PVOP_CALL_ARG2(arg2), PVOP_CALL_ARG3(arg3)) #define PVOP_VCALL3(op, arg1, arg2, arg3) \ - __PVOP_VCALL(op, "", "", PVOP_CALL_ARG1(arg1), \ + __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1), \ PVOP_CALL_ARG2(arg2), PVOP_CALL_ARG3(arg3)) -/* This is the only difference in x86_64. We can make it much simpler */ -#ifdef CONFIG_X86_32 #define PVOP_CALL4(rettype, op, arg1, arg2, arg3, arg4) \ __PVOP_CALL(rettype, op, \ - "push %[_arg4];", "lea 4(%%esp),%%esp;", \ - PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2), \ - PVOP_CALL_ARG3(arg3), [_arg4] "mr" ((u32)(arg4))) -#define PVOP_VCALL4(op, arg1, arg2, arg3, arg4) \ - __PVOP_VCALL(op, \ - "push %[_arg4];", "lea 4(%%esp),%%esp;", \ - "0" ((u32)(arg1)), "1" ((u32)(arg2)), \ - "2" ((u32)(arg3)), [_arg4] "mr" ((u32)(arg4))) -#else -#define PVOP_CALL4(rettype, op, arg1, arg2, arg3, arg4) \ - __PVOP_CALL(rettype, op, "", "", \ PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2), \ PVOP_CALL_ARG3(arg3), PVOP_CALL_ARG4(arg4)) #define PVOP_VCALL4(op, arg1, arg2, arg3, arg4) \ - __PVOP_VCALL(op, "", "", \ - PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2), \ + __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2), \ PVOP_CALL_ARG3(arg3), PVOP_CALL_ARG4(arg4)) -#endif /* Lazy mode for batching updates / context switch */ enum paravirt_lazy_mode { diff --git a/arch/x86/kernel/asm-offsets.c b/arch/x86/kernel/asm-offsets.c index 60b9f42ce3c1..736508004b30 100644 --- a/arch/x86/kernel/asm-offsets.c +++ b/arch/x86/kernel/asm-offsets.c @@ -63,8 +63,6 @@ static void __used common(void) #ifdef CONFIG_PARAVIRT_XXL BLANK(); - OFFSET(PV_IRQ_irq_disable, paravirt_patch_template, irq.irq_disable); - OFFSET(PV_IRQ_irq_enable, paravirt_patch_template, irq.irq_enable); OFFSET(PV_CPU_iret, paravirt_patch_template, cpu.iret); #endif -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:48:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:48:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95422.180191 (Exim 4.92) (envelope-from ) id 1lJcj6-0004XE-G4; Tue, 09 Mar 2021 13:48:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95422.180191; Tue, 09 Mar 2021 13:48:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcj6-0004Wz-Az; Tue, 09 Mar 2021 13:48:44 +0000 Received: by outflank-mailman (input) for mailman id 95422; Tue, 09 Mar 2021 13:48:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcj4-0003zp-Cs for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:48:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ea4c4cbd-4ec7-4f5a-ae3f-0f7fadc15231; Tue, 09 Mar 2021 13:48:23 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E24FEAE3C; Tue, 9 Mar 2021 13:48:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea4c4cbd-4ec7-4f5a-ae3f-0f7fadc15231 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615297703; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zkq+Pzy70GsvGEvfqITxmF3937xAvmVyi93tqlDCI2s=; b=klCZ34OIrpkLRyBfqKCyaxvmYIAuGlGLLQk0LkKLnyShJmGBJ2cKZQRw7+mJQNPTZk72bH wUqvnlMNOBSfftv2TVeDamgtNbzmObjOR5Wn3MjRpP7F2xoPVJKWtdPJigtnrsTbxyD6cV 0BEej9Te5igIDCViLp4WmVhGybpFcpY= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Boris Ostrovsky , Stefano Stabellini , Peter Zijlstra Subject: [PATCH v6 12/12] x86/paravirt: have only one paravirt patch function Date: Tue, 9 Mar 2021 14:48:13 +0100 Message-Id: <20210309134813.23912-13-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309134813.23912-1-jgross@suse.com> References: <20210309134813.23912-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There is no need any longer to have different paravirt patch functions for native and Xen. Eliminate native_patch() and rename paravirt_patch_default() to paravirt_patch(). Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V3: - remove paravirt_patch_insns() (kernel test robot) --- arch/x86/include/asm/paravirt_types.h | 19 +------------------ arch/x86/kernel/Makefile | 3 +-- arch/x86/kernel/alternative.c | 2 +- arch/x86/kernel/paravirt.c | 20 ++------------------ arch/x86/kernel/paravirt_patch.c | 11 ----------- arch/x86/xen/enlighten_pv.c | 1 - 6 files changed, 5 insertions(+), 51 deletions(-) delete mode 100644 arch/x86/kernel/paravirt_patch.c diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 588ff14ce969..9d1ddb7b4350 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -68,19 +68,6 @@ struct pv_info { const char *name; }; -struct pv_init_ops { - /* - * Patch may replace one of the defined code sequences with - * arbitrary code, subject to the same register constraints. - * This generally means the code is not free to clobber any - * registers other than EAX. The patch function should return - * the number of bytes of code generated, as we nop pad the - * rest in generic code. - */ - unsigned (*patch)(u8 type, void *insn_buff, - unsigned long addr, unsigned len); -} __no_randomize_layout; - #ifdef CONFIG_PARAVIRT_XXL struct pv_lazy_ops { /* Set deferred update mode, used for batching operations. */ @@ -276,7 +263,6 @@ struct pv_lock_ops { * number for each function using the offset which we use to indicate * what to patch. */ struct paravirt_patch_template { - struct pv_init_ops init; struct pv_cpu_ops cpu; struct pv_irq_ops irq; struct pv_mmu_ops mmu; @@ -317,10 +303,7 @@ extern void (*paravirt_iret)(void); /* Simple instruction patching code. */ #define NATIVE_LABEL(a,x,b) "\n\t.globl " a #x "_" #b "\n" a #x "_" #b ":\n\t" -unsigned paravirt_patch_default(u8 type, void *insn_buff, unsigned long addr, unsigned len); -unsigned paravirt_patch_insns(void *insn_buff, unsigned len, const char *start, const char *end); - -unsigned native_patch(u8 type, void *insn_buff, unsigned long addr, unsigned len); +unsigned int paravirt_patch(u8 type, void *insn_buff, unsigned long addr, unsigned int len); int paravirt_disable_iospace(void); diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile index 2ddf08351f0b..0704c2a94272 100644 --- a/arch/x86/kernel/Makefile +++ b/arch/x86/kernel/Makefile @@ -35,7 +35,6 @@ KASAN_SANITIZE_sev-es.o := n KCSAN_SANITIZE := n OBJECT_FILES_NON_STANDARD_test_nx.o := y -OBJECT_FILES_NON_STANDARD_paravirt_patch.o := y ifdef CONFIG_FRAME_POINTER OBJECT_FILES_NON_STANDARD_ftrace_$(BITS).o := y @@ -121,7 +120,7 @@ obj-$(CONFIG_AMD_NB) += amd_nb.o obj-$(CONFIG_DEBUG_NMI_SELFTEST) += nmi_selftest.o obj-$(CONFIG_KVM_GUEST) += kvm.o kvmclock.o -obj-$(CONFIG_PARAVIRT) += paravirt.o paravirt_patch.o +obj-$(CONFIG_PARAVIRT) += paravirt.o obj-$(CONFIG_PARAVIRT_SPINLOCKS)+= paravirt-spinlocks.o obj-$(CONFIG_PARAVIRT_CLOCK) += pvclock.o obj-$(CONFIG_X86_PMEM_LEGACY_DEVICE) += pmem.o diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index 1f12901e75f2..cb3eb8c2f50d 100644 --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -615,7 +615,7 @@ void __init_or_module apply_paravirt(struct paravirt_patch_site *start, BUG_ON(p->len > MAX_PATCH_LEN); /* prep the buffer with the original instructions */ memcpy(insn_buff, p->instr, p->len); - used = pv_ops.init.patch(p->type, insn_buff, (unsigned long)p->instr, p->len); + used = paravirt_patch(p->type, insn_buff, (unsigned long)p->instr, p->len); BUG_ON(used > p->len); diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 082954930809..3d7b989ed6be 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -99,8 +99,8 @@ void __init native_pv_lock_init(void) static_branch_disable(&virt_spin_lock_key); } -unsigned paravirt_patch_default(u8 type, void *insn_buff, - unsigned long addr, unsigned len) +unsigned int paravirt_patch(u8 type, void *insn_buff, unsigned long addr, + unsigned int len) { /* * Neat trick to map patch type back to the call within the @@ -121,19 +121,6 @@ unsigned paravirt_patch_default(u8 type, void *insn_buff, return ret; } -unsigned paravirt_patch_insns(void *insn_buff, unsigned len, - const char *start, const char *end) -{ - unsigned insn_len = end - start; - - /* Alternative instruction is too large for the patch site and we cannot continue: */ - BUG_ON(insn_len > len || start == NULL); - - memcpy(insn_buff, start, insn_len); - - return insn_len; -} - struct static_key paravirt_steal_enabled; struct static_key paravirt_steal_rq_enabled; @@ -255,9 +242,6 @@ struct pv_info pv_info = { #define PTE_IDENT __PV_IS_CALLEE_SAVE(_paravirt_ident_64) struct paravirt_patch_template pv_ops = { - /* Init ops. */ - .init.patch = native_patch, - /* Cpu ops. */ .cpu.io_delay = native_io_delay, diff --git a/arch/x86/kernel/paravirt_patch.c b/arch/x86/kernel/paravirt_patch.c deleted file mode 100644 index 10543dcc8211..000000000000 --- a/arch/x86/kernel/paravirt_patch.c +++ /dev/null @@ -1,11 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -#include - -#include -#include - -unsigned int native_patch(u8 type, void *insn_buff, unsigned long addr, - unsigned int len) -{ - return paravirt_patch_default(type, insn_buff, addr, len); -} diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 08dca7bebb30..4f18cd9eacd8 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -1231,7 +1231,6 @@ asmlinkage __visible void __init xen_start_kernel(void) /* Install Xen paravirt ops */ pv_info = xen_info; - pv_ops.init.patch = paravirt_patch_default; pv_ops.cpu = xen_cpu_ops; paravirt_iret = xen_iret; xen_init_irq_ops(); -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:48:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:48:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95423.180203 (Exim 4.92) (envelope-from ) id 1lJcj9-0004d2-7S; Tue, 09 Mar 2021 13:48:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95423.180203; Tue, 09 Mar 2021 13:48:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcj9-0004co-2G; Tue, 09 Mar 2021 13:48:47 +0000 Received: by outflank-mailman (input) for mailman id 95423; Tue, 09 Mar 2021 13:48:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcj7-0003yx-NS for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:48:45 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2db0731f-4296-4b86-a25b-e0a4cd46dc34; Tue, 09 Mar 2021 13:48:22 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E3B23ADE3; Tue, 9 Mar 2021 13:48:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2db0731f-4296-4b86-a25b-e0a4cd46dc34 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615297702; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dBMxkHZRKnqu5bpydqyKw7Gq6TegdcdkrUPgCcZVPrk=; b=lFrrgPDdUQxhI3L1q2BmyIa+SOFdXgbqADTbGMuyipWS0A2bvVX0DjBW0al+EY21nHxjj0 00/mj2AL1y3BHdmaOMPK+HKRYHTzudYbM4czQY+Fyd7i8qdni8CXY/WbahKPX05rbaQMDr 4tdSP1lkxHYwXmbrTDvRxdCf1FDs2z0= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Boris Ostrovsky , Stefano Stabellini , Peter Zijlstra Subject: [PATCH v6 09/12] x86/paravirt: switch iret pvops to ALTERNATIVE Date: Tue, 9 Mar 2021 14:48:10 +0100 Message-Id: <20210309134813.23912-10-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309134813.23912-1-jgross@suse.com> References: <20210309134813.23912-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The iret paravirt op is rather special as it is using a jmp instead of a call instruction. Switch it to ALTERNATIVE. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V3: - use ALTERNATIVE_TERNARY --- arch/x86/include/asm/paravirt.h | 6 +++--- arch/x86/include/asm/paravirt_types.h | 5 +---- arch/x86/kernel/asm-offsets.c | 5 ----- arch/x86/kernel/paravirt.c | 26 ++------------------------ arch/x86/xen/enlighten_pv.c | 3 +-- 5 files changed, 7 insertions(+), 38 deletions(-) diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index c6496a82fad1..36cd71fa097f 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -749,9 +749,9 @@ extern void default_banner(void); #define PARA_INDIRECT(addr) *addr(%rip) #define INTERRUPT_RETURN \ - PARA_SITE(PARA_PATCH(PV_CPU_iret), \ - ANNOTATE_RETPOLINE_SAFE; \ - jmp PARA_INDIRECT(pv_ops+PV_CPU_iret);) + ANNOTATE_RETPOLINE_SAFE; \ + ALTERNATIVE_TERNARY("jmp *paravirt_iret(%rip);", \ + X86_FEATURE_XENPV, "jmp xen_iret;", "jmp native_iret;") #ifdef CONFIG_DEBUG_ENTRY #define SAVE_FLAGS(clobbers) \ diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 45bd21647dd8..0afdac83f926 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -151,10 +151,6 @@ struct pv_cpu_ops { u64 (*read_pmc)(int counter); - /* Normal iret. Jump to this with the standard iret stack - frame set up. */ - void (*iret)(void); - void (*start_context_switch)(struct task_struct *prev); void (*end_context_switch)(struct task_struct *next); #endif @@ -294,6 +290,7 @@ struct paravirt_patch_template { extern struct pv_info pv_info; extern struct paravirt_patch_template pv_ops; +extern void (*paravirt_iret)(void); #define PARAVIRT_PATCH(x) \ (offsetof(struct paravirt_patch_template, x) / sizeof(void *)) diff --git a/arch/x86/kernel/asm-offsets.c b/arch/x86/kernel/asm-offsets.c index 736508004b30..ecd3fd6993d1 100644 --- a/arch/x86/kernel/asm-offsets.c +++ b/arch/x86/kernel/asm-offsets.c @@ -61,11 +61,6 @@ static void __used common(void) OFFSET(IA32_RT_SIGFRAME_sigcontext, rt_sigframe_ia32, uc.uc_mcontext); #endif -#ifdef CONFIG_PARAVIRT_XXL - BLANK(); - OFFSET(PV_CPU_iret, paravirt_patch_template, cpu.iret); -#endif - #ifdef CONFIG_XEN BLANK(); OFFSET(XEN_vcpu_info_mask, vcpu_info, evtchn_upcall_mask); diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 44e5b0fe28cb..0553a339d850 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -86,25 +86,6 @@ u64 notrace _paravirt_ident_64(u64 x) { return x; } - -static unsigned paravirt_patch_jmp(void *insn_buff, const void *target, - unsigned long addr, unsigned len) -{ - struct branch *b = insn_buff; - unsigned long delta = (unsigned long)target - (addr+5); - - if (len < 5) { -#ifdef CONFIG_RETPOLINE - WARN_ONCE(1, "Failing to patch indirect JMP in %ps\n", (void *)addr); -#endif - return len; /* call too long for patch site */ - } - - b->opcode = 0xe9; /* jmp */ - b->delta = delta; - - return 5; -} #endif DEFINE_STATIC_KEY_TRUE(virt_spin_lock_key); @@ -136,9 +117,6 @@ unsigned paravirt_patch_default(u8 type, void *insn_buff, else if (opfunc == _paravirt_ident_64) ret = paravirt_patch_ident_64(insn_buff, len); - else if (type == PARAVIRT_PATCH(cpu.iret)) - /* If operation requires a jmp, then jmp */ - ret = paravirt_patch_jmp(insn_buff, opfunc, addr, len); #endif else /* Otherwise call the function. */ @@ -316,8 +294,6 @@ struct paravirt_patch_template pv_ops = { .cpu.load_sp0 = native_load_sp0, - .cpu.iret = native_iret, - #ifdef CONFIG_X86_IOPL_IOPERM .cpu.invalidate_io_bitmap = native_tss_invalidate_io_bitmap, .cpu.update_io_bitmap = native_tss_update_io_bitmap, @@ -422,6 +398,8 @@ struct paravirt_patch_template pv_ops = { NOKPROBE_SYMBOL(native_get_debugreg); NOKPROBE_SYMBOL(native_set_debugreg); NOKPROBE_SYMBOL(native_load_idt); + +void (*paravirt_iret)(void) = native_iret; #endif EXPORT_SYMBOL(pv_ops); diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index dc0a337f985b..08dca7bebb30 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -1070,8 +1070,6 @@ static const struct pv_cpu_ops xen_cpu_ops __initconst = { .read_pmc = xen_read_pmc, - .iret = xen_iret, - .load_tr_desc = paravirt_nop, .set_ldt = xen_set_ldt, .load_gdt = xen_load_gdt, @@ -1235,6 +1233,7 @@ asmlinkage __visible void __init xen_start_kernel(void) pv_info = xen_info; pv_ops.init.patch = paravirt_patch_default; pv_ops.cpu = xen_cpu_ops; + paravirt_iret = xen_iret; xen_init_irq_ops(); /* -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:48:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:48:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95425.180216 (Exim 4.92) (envelope-from ) id 1lJcjE-0004mD-JB; Tue, 09 Mar 2021 13:48:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95425.180216; Tue, 09 Mar 2021 13:48:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcjE-0004m3-E3; Tue, 09 Mar 2021 13:48:52 +0000 Received: by outflank-mailman (input) for mailman id 95425; Tue, 09 Mar 2021 13:48:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcjC-0003yx-Nf for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:48:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e6cd8ccd-65ea-473e-99ba-c91f7bec589d; Tue, 09 Mar 2021 13:48:23 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 37C70AE05; Tue, 9 Mar 2021 13:48:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6cd8ccd-65ea-473e-99ba-c91f7bec589d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615297702; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/BOg9FE2LyOwuFPT7IjJCD7FUb4zh5arPwZL+WX0RDM=; b=DgZDG9VK9kEtbnFsL+0MlvgBVh/YTZAbnRszQcmtHnMCtruOBJlBjymMKlVN606b5rSO39 uCJt7qZo+cjwbkhJNH97LUL97z/1a3fs64ST2YHRrCx7dUmGM5iYqmZNWbds/x1zeoTdus cuwtC1r0sjYiHEgANL0KhhtB9jYk/Yg= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Peter Zijlstra Subject: [PATCH v6 10/12] x86/paravirt: add new macros PVOP_ALT* supporting pvops in ALTERNATIVEs Date: Tue, 9 Mar 2021 14:48:11 +0100 Message-Id: <20210309134813.23912-11-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309134813.23912-1-jgross@suse.com> References: <20210309134813.23912-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using paravirt patching for custom code sequences add support for using ALTERNATIVE handling combined with paravirt call patching. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V3: - drop ____PVOP_ALT_VCALL() macro --- arch/x86/include/asm/paravirt_types.h | 49 ++++++++++++++++++++++++++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 0afdac83f926..0ed976286d49 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -477,44 +477,91 @@ int paravirt_disable_iospace(void); ret; \ }) +#define ____PVOP_ALT_CALL(ret, op, alt, cond, clbr, call_clbr, \ + extra_clbr, ...) \ + ({ \ + PVOP_CALL_ARGS; \ + PVOP_TEST_NULL(op); \ + asm volatile(ALTERNATIVE(paravirt_alt(PARAVIRT_CALL), \ + alt, cond) \ + : call_clbr, ASM_CALL_CONSTRAINT \ + : paravirt_type(op), \ + paravirt_clobber(clbr), \ + ##__VA_ARGS__ \ + : "memory", "cc" extra_clbr); \ + ret; \ + }) + #define __PVOP_CALL(rettype, op, ...) \ ____PVOP_CALL(PVOP_RETVAL(rettype), op, CLBR_ANY, \ PVOP_CALL_CLOBBERS, EXTRA_CLOBBERS, ##__VA_ARGS__) +#define __PVOP_ALT_CALL(rettype, op, alt, cond, ...) \ + ____PVOP_ALT_CALL(PVOP_RETVAL(rettype), op, alt, cond, CLBR_ANY,\ + PVOP_CALL_CLOBBERS, EXTRA_CLOBBERS, \ + ##__VA_ARGS__) + #define __PVOP_CALLEESAVE(rettype, op, ...) \ ____PVOP_CALL(PVOP_RETVAL(rettype), op.func, CLBR_RET_REG, \ PVOP_CALLEE_CLOBBERS, , ##__VA_ARGS__) +#define __PVOP_ALT_CALLEESAVE(rettype, op, alt, cond, ...) \ + ____PVOP_ALT_CALL(PVOP_RETVAL(rettype), op.func, alt, cond, \ + CLBR_RET_REG, PVOP_CALLEE_CLOBBERS, , ##__VA_ARGS__) + + #define __PVOP_VCALL(op, ...) \ (void)____PVOP_CALL(, op, CLBR_ANY, PVOP_VCALL_CLOBBERS, \ VEXTRA_CLOBBERS, ##__VA_ARGS__) +#define __PVOP_ALT_VCALL(op, alt, cond, ...) \ + (void)____PVOP_ALT_CALL(, op, alt, cond, CLBR_ANY, \ + PVOP_VCALL_CLOBBERS, VEXTRA_CLOBBERS, \ + ##__VA_ARGS__) + #define __PVOP_VCALLEESAVE(op, ...) \ (void)____PVOP_CALL(, op.func, CLBR_RET_REG, \ - PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) + PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) +#define __PVOP_ALT_VCALLEESAVE(op, alt, cond, ...) \ + (void)____PVOP_ALT_CALL(, op.func, alt, cond, CLBR_RET_REG, \ + PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) #define PVOP_CALL0(rettype, op) \ __PVOP_CALL(rettype, op) #define PVOP_VCALL0(op) \ __PVOP_VCALL(op) +#define PVOP_ALT_CALL0(rettype, op, alt, cond) \ + __PVOP_ALT_CALL(rettype, op, alt, cond) +#define PVOP_ALT_VCALL0(op, alt, cond) \ + __PVOP_ALT_VCALL(op, alt, cond) #define PVOP_CALLEE0(rettype, op) \ __PVOP_CALLEESAVE(rettype, op) #define PVOP_VCALLEE0(op) \ __PVOP_VCALLEESAVE(op) +#define PVOP_ALT_CALLEE0(rettype, op, alt, cond) \ + __PVOP_ALT_CALLEESAVE(rettype, op, alt, cond) +#define PVOP_ALT_VCALLEE0(op, alt, cond) \ + __PVOP_ALT_VCALLEESAVE(op, alt, cond) #define PVOP_CALL1(rettype, op, arg1) \ __PVOP_CALL(rettype, op, PVOP_CALL_ARG1(arg1)) #define PVOP_VCALL1(op, arg1) \ __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1)) +#define PVOP_ALT_VCALL1(op, arg1, alt, cond) \ + __PVOP_ALT_VCALL(op, alt, cond, PVOP_CALL_ARG1(arg1)) #define PVOP_CALLEE1(rettype, op, arg1) \ __PVOP_CALLEESAVE(rettype, op, PVOP_CALL_ARG1(arg1)) #define PVOP_VCALLEE1(op, arg1) \ __PVOP_VCALLEESAVE(op, PVOP_CALL_ARG1(arg1)) +#define PVOP_ALT_CALLEE1(rettype, op, arg1, alt, cond) \ + __PVOP_ALT_CALLEESAVE(rettype, op, alt, cond, PVOP_CALL_ARG1(arg1)) +#define PVOP_ALT_VCALLEE1(op, arg1, alt, cond) \ + __PVOP_ALT_VCALLEESAVE(op, alt, cond, PVOP_CALL_ARG1(arg1)) #define PVOP_CALL2(rettype, op, arg1, arg2) \ -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:48:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:48:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95427.180228 (Exim 4.92) (envelope-from ) id 1lJcjJ-0004tL-2M; Tue, 09 Mar 2021 13:48:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95427.180228; Tue, 09 Mar 2021 13:48:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcjI-0004t9-T7; Tue, 09 Mar 2021 13:48:56 +0000 Received: by outflank-mailman (input) for mailman id 95427; Tue, 09 Mar 2021 13:48:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcjH-0003yx-Nx for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:48:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8b730f95-bd8a-4a68-9970-cc52293042a1; Tue, 09 Mar 2021 13:48:23 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8F848AE15; Tue, 9 Mar 2021 13:48:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b730f95-bd8a-4a68-9970-cc52293042a1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615297702; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d4ExMZPJQhPpnv6x0LBUpMruJTxKVMDPDTTcOV0zzwM=; b=ijkz3iPh8dCqibcoZxTCFz3vwKvA0Yfny/egFKgPDoyJ0llIhby8i3vydZcsIK2asD+CdX aFgh87ABYNgE34nI2wUnypL2xCdjovhQkwXSYqdXL3v8BPyN6273kD5z+HYmP+AyWillpx lum4r6AOmEQZ8hTSxXbcqyFgRJ1cokM= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Juergen Gross , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Deep Shah , "VMware, Inc." , Peter Zijlstra Subject: [PATCH v6 11/12] x86/paravirt: switch functions with custom code to ALTERNATIVE Date: Tue, 9 Mar 2021 14:48:12 +0100 Message-Id: <20210309134813.23912-12-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309134813.23912-1-jgross@suse.com> References: <20210309134813.23912-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using paravirt patching for custom code sequences use ALTERNATIVE for the functions with custom code replacements. Instead of patching an ud2 instruction for unpopulated vector entries into the caller site, use a simple function just calling BUG() as a replacement. Simplify the register defines for assembler paravirt calling, as there isn't much usage left. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V4: - fixed SAVE_FLAGS() (kernel test robot) - added assembler paravirt cleanup --- arch/x86/entry/entry_64.S | 2 +- arch/x86/include/asm/irqflags.h | 2 +- arch/x86/include/asm/paravirt.h | 101 +++++++++++++------------- arch/x86/include/asm/paravirt_types.h | 6 -- arch/x86/kernel/paravirt.c | 16 ++-- arch/x86/kernel/paravirt_patch.c | 88 ---------------------- 6 files changed, 58 insertions(+), 157 deletions(-) diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index 400908dff42e..12e2e3cd58be 100644 --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -305,7 +305,7 @@ SYM_CODE_END(ret_from_fork) .macro DEBUG_ENTRY_ASSERT_IRQS_OFF #ifdef CONFIG_DEBUG_ENTRY pushq %rax - SAVE_FLAGS(CLBR_RAX) + SAVE_FLAGS testl $X86_EFLAGS_IF, %eax jz .Lokay_\@ ud2 diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h index a0efbcd24b86..c5ce9845c999 100644 --- a/arch/x86/include/asm/irqflags.h +++ b/arch/x86/include/asm/irqflags.h @@ -111,7 +111,7 @@ static __always_inline unsigned long arch_local_irq_save(void) #ifdef CONFIG_X86_64 #ifdef CONFIG_DEBUG_ENTRY -#define SAVE_FLAGS(x) pushfq; popq %rax +#define SAVE_FLAGS pushfq; popq %rax #endif #define INTERRUPT_RETURN jmp native_iret diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 36cd71fa097f..b32b408958e8 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -137,7 +137,9 @@ static inline void write_cr0(unsigned long x) static inline unsigned long read_cr2(void) { - return PVOP_CALLEE0(unsigned long, mmu.read_cr2); + return PVOP_ALT_CALLEE0(unsigned long, mmu.read_cr2, + "mov %%cr2, %%rax;", + ALT_NOT(X86_FEATURE_XENPV)); } static inline void write_cr2(unsigned long x) @@ -147,12 +149,14 @@ static inline void write_cr2(unsigned long x) static inline unsigned long __read_cr3(void) { - return PVOP_CALL0(unsigned long, mmu.read_cr3); + return PVOP_ALT_CALL0(unsigned long, mmu.read_cr3, + "mov %%cr3, %%rax;", ALT_NOT(X86_FEATURE_XENPV)); } static inline void write_cr3(unsigned long x) { - PVOP_VCALL1(mmu.write_cr3, x); + PVOP_ALT_VCALL1(mmu.write_cr3, x, + "mov %%rdi, %%cr3", ALT_NOT(X86_FEATURE_XENPV)); } static inline void __write_cr4(unsigned long x) @@ -172,7 +176,7 @@ static inline void halt(void) static inline void wbinvd(void) { - PVOP_VCALL0(cpu.wbinvd); + PVOP_ALT_VCALL0(cpu.wbinvd, "wbinvd", ALT_NOT(X86_FEATURE_XENPV)); } static inline u64 paravirt_read_msr(unsigned msr) @@ -386,22 +390,28 @@ static inline void paravirt_release_p4d(unsigned long pfn) static inline pte_t __pte(pteval_t val) { - return (pte_t) { PVOP_CALLEE1(pteval_t, mmu.make_pte, val) }; + return (pte_t) { PVOP_ALT_CALLEE1(pteval_t, mmu.make_pte, val, + "mov %%rdi, %%rax", + ALT_NOT(X86_FEATURE_XENPV)) }; } static inline pteval_t pte_val(pte_t pte) { - return PVOP_CALLEE1(pteval_t, mmu.pte_val, pte.pte); + return PVOP_ALT_CALLEE1(pteval_t, mmu.pte_val, pte.pte, + "mov %%rdi, %%rax", ALT_NOT(X86_FEATURE_XENPV)); } static inline pgd_t __pgd(pgdval_t val) { - return (pgd_t) { PVOP_CALLEE1(pgdval_t, mmu.make_pgd, val) }; + return (pgd_t) { PVOP_ALT_CALLEE1(pgdval_t, mmu.make_pgd, val, + "mov %%rdi, %%rax", + ALT_NOT(X86_FEATURE_XENPV)) }; } static inline pgdval_t pgd_val(pgd_t pgd) { - return PVOP_CALLEE1(pgdval_t, mmu.pgd_val, pgd.pgd); + return PVOP_ALT_CALLEE1(pgdval_t, mmu.pgd_val, pgd.pgd, + "mov %%rdi, %%rax", ALT_NOT(X86_FEATURE_XENPV)); } #define __HAVE_ARCH_PTEP_MODIFY_PROT_TRANSACTION @@ -434,12 +444,15 @@ static inline void set_pmd(pmd_t *pmdp, pmd_t pmd) static inline pmd_t __pmd(pmdval_t val) { - return (pmd_t) { PVOP_CALLEE1(pmdval_t, mmu.make_pmd, val) }; + return (pmd_t) { PVOP_ALT_CALLEE1(pmdval_t, mmu.make_pmd, val, + "mov %%rdi, %%rax", + ALT_NOT(X86_FEATURE_XENPV)) }; } static inline pmdval_t pmd_val(pmd_t pmd) { - return PVOP_CALLEE1(pmdval_t, mmu.pmd_val, pmd.pmd); + return PVOP_ALT_CALLEE1(pmdval_t, mmu.pmd_val, pmd.pmd, + "mov %%rdi, %%rax", ALT_NOT(X86_FEATURE_XENPV)); } static inline void set_pud(pud_t *pudp, pud_t pud) @@ -451,14 +464,16 @@ static inline pud_t __pud(pudval_t val) { pudval_t ret; - ret = PVOP_CALLEE1(pudval_t, mmu.make_pud, val); + ret = PVOP_ALT_CALLEE1(pudval_t, mmu.make_pud, val, + "mov %%rdi, %%rax", ALT_NOT(X86_FEATURE_XENPV)); return (pud_t) { ret }; } static inline pudval_t pud_val(pud_t pud) { - return PVOP_CALLEE1(pudval_t, mmu.pud_val, pud.pud); + return PVOP_ALT_CALLEE1(pudval_t, mmu.pud_val, pud.pud, + "mov %%rdi, %%rax", ALT_NOT(X86_FEATURE_XENPV)); } static inline void pud_clear(pud_t *pudp) @@ -477,14 +492,17 @@ static inline void set_p4d(p4d_t *p4dp, p4d_t p4d) static inline p4d_t __p4d(p4dval_t val) { - p4dval_t ret = PVOP_CALLEE1(p4dval_t, mmu.make_p4d, val); + p4dval_t ret = PVOP_ALT_CALLEE1(p4dval_t, mmu.make_p4d, val, + "mov %%rdi, %%rax", + ALT_NOT(X86_FEATURE_XENPV)); return (p4d_t) { ret }; } static inline p4dval_t p4d_val(p4d_t p4d) { - return PVOP_CALLEE1(p4dval_t, mmu.p4d_val, p4d.p4d); + return PVOP_ALT_CALLEE1(p4dval_t, mmu.p4d_val, p4d.p4d, + "mov %%rdi, %%rax", ALT_NOT(X86_FEATURE_XENPV)); } static inline void __set_pgd(pgd_t *pgdp, pgd_t pgd) @@ -571,7 +589,9 @@ static __always_inline void pv_queued_spin_lock_slowpath(struct qspinlock *lock, static __always_inline void pv_queued_spin_unlock(struct qspinlock *lock) { - PVOP_VCALLEE1(lock.queued_spin_unlock, lock); + PVOP_ALT_VCALLEE1(lock.queued_spin_unlock, lock, + "movb $0, (%%" _ASM_ARG1 ");", + ALT_NOT(X86_FEATURE_PVUNLOCK)); } static __always_inline void pv_wait(u8 *ptr, u8 val) @@ -586,7 +606,9 @@ static __always_inline void pv_kick(int cpu) static __always_inline bool pv_vcpu_is_preempted(long cpu) { - return PVOP_CALLEE1(bool, lock.vcpu_is_preempted, cpu); + return PVOP_ALT_CALLEE1(bool, lock.vcpu_is_preempted, cpu, + "xor %%" _ASM_AX ", %%" _ASM_AX ";", + ALT_NOT(X86_FEATURE_VCPUPREEMPT)); } void __raw_callee_save___native_queued_spin_unlock(struct qspinlock *lock); @@ -660,17 +682,18 @@ bool __raw_callee_save___native_vcpu_is_preempted(long cpu); #ifdef CONFIG_PARAVIRT_XXL static inline notrace unsigned long arch_local_save_flags(void) { - return PVOP_CALLEE0(unsigned long, irq.save_fl); + return PVOP_ALT_CALLEE0(unsigned long, irq.save_fl, "pushf; pop %%rax;", + ALT_NOT(X86_FEATURE_XENPV)); } static inline notrace void arch_local_irq_disable(void) { - PVOP_VCALLEE0(irq.irq_disable); + PVOP_ALT_VCALLEE0(irq.irq_disable, "cli;", ALT_NOT(X86_FEATURE_XENPV)); } static inline notrace void arch_local_irq_enable(void) { - PVOP_VCALLEE0(irq.irq_enable); + PVOP_ALT_VCALLEE0(irq.irq_enable, "sti;", ALT_NOT(X86_FEATURE_XENPV)); } static inline notrace unsigned long arch_local_irq_save(void) @@ -715,35 +738,9 @@ extern void default_banner(void); .popsection -#define COND_PUSH(set, mask, reg) \ - .if ((~(set)) & mask); push %reg; .endif -#define COND_POP(set, mask, reg) \ - .if ((~(set)) & mask); pop %reg; .endif - #ifdef CONFIG_X86_64 #ifdef CONFIG_PARAVIRT_XXL -#define PV_SAVE_REGS(set) \ - COND_PUSH(set, CLBR_RAX, rax); \ - COND_PUSH(set, CLBR_RCX, rcx); \ - COND_PUSH(set, CLBR_RDX, rdx); \ - COND_PUSH(set, CLBR_RSI, rsi); \ - COND_PUSH(set, CLBR_RDI, rdi); \ - COND_PUSH(set, CLBR_R8, r8); \ - COND_PUSH(set, CLBR_R9, r9); \ - COND_PUSH(set, CLBR_R10, r10); \ - COND_PUSH(set, CLBR_R11, r11) -#define PV_RESTORE_REGS(set) \ - COND_POP(set, CLBR_R11, r11); \ - COND_POP(set, CLBR_R10, r10); \ - COND_POP(set, CLBR_R9, r9); \ - COND_POP(set, CLBR_R8, r8); \ - COND_POP(set, CLBR_RDI, rdi); \ - COND_POP(set, CLBR_RSI, rsi); \ - COND_POP(set, CLBR_RDX, rdx); \ - COND_POP(set, CLBR_RCX, rcx); \ - COND_POP(set, CLBR_RAX, rax) - #define PARA_PATCH(off) ((off) / 8) #define PARA_SITE(ptype, ops) _PVSITE(ptype, ops, .quad, 8) #define PARA_INDIRECT(addr) *addr(%rip) @@ -754,12 +751,14 @@ extern void default_banner(void); X86_FEATURE_XENPV, "jmp xen_iret;", "jmp native_iret;") #ifdef CONFIG_DEBUG_ENTRY -#define SAVE_FLAGS(clobbers) \ - PARA_SITE(PARA_PATCH(PV_IRQ_save_fl), \ - PV_SAVE_REGS(clobbers | CLBR_CALLEE_SAVE); \ - ANNOTATE_RETPOLINE_SAFE; \ - call PARA_INDIRECT(pv_ops+PV_IRQ_save_fl); \ - PV_RESTORE_REGS(clobbers | CLBR_CALLEE_SAVE);) +.macro PARA_IRQ_save_fl + PARA_SITE(PARA_PATCH(PV_IRQ_save_fl), + ANNOTATE_RETPOLINE_SAFE; + call PARA_INDIRECT(pv_ops+PV_IRQ_save_fl);) +.endm + +#define SAVE_FLAGS ALTERNATIVE "PARA_IRQ_save_fl;", "pushf; pop %rax;", \ + ALT_NOT(X86_FEATURE_XENPV) #endif #endif /* CONFIG_PARAVIRT_XXL */ #endif /* CONFIG_X86_64 */ diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 0ed976286d49..588ff14ce969 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -3,7 +3,6 @@ #define _ASM_X86_PARAVIRT_TYPES_H /* Bitmask of what can be clobbered: usually at least eax. */ -#define CLBR_NONE 0 #define CLBR_EAX (1 << 0) #define CLBR_ECX (1 << 1) #define CLBR_EDX (1 << 2) @@ -15,7 +14,6 @@ #define CLBR_ARG_REGS (CLBR_EAX | CLBR_EDX | CLBR_ECX) #define CLBR_RET_REG (CLBR_EAX | CLBR_EDX) -#define CLBR_SCRATCH (0) #else #define CLBR_RAX CLBR_EAX #define CLBR_RCX CLBR_ECX @@ -32,12 +30,9 @@ #define CLBR_ARG_REGS (CLBR_RDI | CLBR_RSI | CLBR_RDX | \ CLBR_RCX | CLBR_R8 | CLBR_R9) #define CLBR_RET_REG (CLBR_RAX) -#define CLBR_SCRATCH (CLBR_R10 | CLBR_R11) #endif /* X86_64 */ -#define CLBR_CALLEE_SAVE ((CLBR_ARG_REGS | CLBR_SCRATCH) & ~CLBR_RET_REG) - #ifndef __ASSEMBLY__ #include @@ -322,7 +317,6 @@ extern void (*paravirt_iret)(void); /* Simple instruction patching code. */ #define NATIVE_LABEL(a,x,b) "\n\t.globl " a #x "_" #b "\n" a #x "_" #b ":\n\t" -unsigned paravirt_patch_ident_64(void *insn_buff, unsigned len); unsigned paravirt_patch_default(u8 type, void *insn_buff, unsigned long addr, unsigned len); unsigned paravirt_patch_insns(void *insn_buff, unsigned len, const char *start, const char *end); diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 0553a339d850..082954930809 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -53,7 +53,10 @@ void __init default_banner(void) } /* Undefined instruction for dealing with missing ops pointers. */ -static const unsigned char ud2a[] = { 0x0f, 0x0b }; +static void paravirt_BUG(void) +{ + BUG(); +} struct branch { unsigned char opcode; @@ -107,17 +110,10 @@ unsigned paravirt_patch_default(u8 type, void *insn_buff, unsigned ret; if (opfunc == NULL) - /* If there's no function, patch it with a ud2a (BUG) */ - ret = paravirt_patch_insns(insn_buff, len, ud2a, ud2a+sizeof(ud2a)); + /* If there's no function, patch it with paravirt_BUG() */ + ret = paravirt_patch_call(insn_buff, paravirt_BUG, addr, len); else if (opfunc == _paravirt_nop) ret = 0; - -#ifdef CONFIG_PARAVIRT_XXL - /* identity functions just return their single argument */ - else if (opfunc == _paravirt_ident_64) - ret = paravirt_patch_ident_64(insn_buff, len); - -#endif else /* Otherwise call the function. */ ret = paravirt_patch_call(insn_buff, opfunc, addr, len); diff --git a/arch/x86/kernel/paravirt_patch.c b/arch/x86/kernel/paravirt_patch.c index abd27ec67397..10543dcc8211 100644 --- a/arch/x86/kernel/paravirt_patch.c +++ b/arch/x86/kernel/paravirt_patch.c @@ -4,96 +4,8 @@ #include #include -#define PSTART(d, m) \ - patch_data_##d.m - -#define PEND(d, m) \ - (PSTART(d, m) + sizeof(patch_data_##d.m)) - -#define PATCH(d, m, insn_buff, len) \ - paravirt_patch_insns(insn_buff, len, PSTART(d, m), PEND(d, m)) - -#define PATCH_CASE(ops, m, data, insn_buff, len) \ - case PARAVIRT_PATCH(ops.m): \ - return PATCH(data, ops##_##m, insn_buff, len) - -#ifdef CONFIG_PARAVIRT_XXL -struct patch_xxl { - const unsigned char irq_irq_disable[1]; - const unsigned char irq_irq_enable[1]; - const unsigned char irq_save_fl[2]; - const unsigned char mmu_read_cr2[3]; - const unsigned char mmu_read_cr3[3]; - const unsigned char mmu_write_cr3[3]; - const unsigned char cpu_wbinvd[2]; - const unsigned char mov64[3]; -}; - -static const struct patch_xxl patch_data_xxl = { - .irq_irq_disable = { 0xfa }, // cli - .irq_irq_enable = { 0xfb }, // sti - .irq_save_fl = { 0x9c, 0x58 }, // pushf; pop %[re]ax - .mmu_read_cr2 = { 0x0f, 0x20, 0xd0 }, // mov %cr2, %[re]ax - .mmu_read_cr3 = { 0x0f, 0x20, 0xd8 }, // mov %cr3, %[re]ax - .mmu_write_cr3 = { 0x0f, 0x22, 0xdf }, // mov %rdi, %cr3 - .cpu_wbinvd = { 0x0f, 0x09 }, // wbinvd - .mov64 = { 0x48, 0x89, 0xf8 }, // mov %rdi, %rax -}; - -unsigned int paravirt_patch_ident_64(void *insn_buff, unsigned int len) -{ - return PATCH(xxl, mov64, insn_buff, len); -} -# endif /* CONFIG_PARAVIRT_XXL */ - -#ifdef CONFIG_PARAVIRT_SPINLOCKS -struct patch_lock { - unsigned char queued_spin_unlock[3]; - unsigned char vcpu_is_preempted[2]; -}; - -static const struct patch_lock patch_data_lock = { - .vcpu_is_preempted = { 0x31, 0xc0 }, // xor %eax, %eax - -# ifdef CONFIG_X86_64 - .queued_spin_unlock = { 0xc6, 0x07, 0x00 }, // movb $0, (%rdi) -# else - .queued_spin_unlock = { 0xc6, 0x00, 0x00 }, // movb $0, (%eax) -# endif -}; -#endif /* CONFIG_PARAVIRT_SPINLOCKS */ - unsigned int native_patch(u8 type, void *insn_buff, unsigned long addr, unsigned int len) { - switch (type) { - -#ifdef CONFIG_PARAVIRT_XXL - PATCH_CASE(irq, save_fl, xxl, insn_buff, len); - PATCH_CASE(irq, irq_enable, xxl, insn_buff, len); - PATCH_CASE(irq, irq_disable, xxl, insn_buff, len); - - PATCH_CASE(mmu, read_cr2, xxl, insn_buff, len); - PATCH_CASE(mmu, read_cr3, xxl, insn_buff, len); - PATCH_CASE(mmu, write_cr3, xxl, insn_buff, len); - - PATCH_CASE(cpu, wbinvd, xxl, insn_buff, len); -#endif - -#ifdef CONFIG_PARAVIRT_SPINLOCKS - case PARAVIRT_PATCH(lock.queued_spin_unlock): - if (pv_is_native_spin_unlock()) - return PATCH(lock, queued_spin_unlock, insn_buff, len); - break; - - case PARAVIRT_PATCH(lock.vcpu_is_preempted): - if (pv_is_native_vcpu_is_preempted()) - return PATCH(lock, vcpu_is_preempted, insn_buff, len); - break; -#endif - default: - break; - } - return paravirt_patch_default(type, insn_buff, addr, len); } -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:54:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:54:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95438.180244 (Exim 4.92) (envelope-from ) id 1lJcot-0006CW-1Q; Tue, 09 Mar 2021 13:54:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95438.180244; Tue, 09 Mar 2021 13:54:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcos-0006CP-T6; Tue, 09 Mar 2021 13:54:42 +0000 Received: by outflank-mailman (input) for mailman id 95438; Tue, 09 Mar 2021 13:54:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcor-0006CK-N4 for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:54:41 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d76b7dbf-fe7f-42e0-99c8-ffa6888d6a86; Tue, 09 Mar 2021 13:54:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d76b7dbf-fe7f-42e0-99c8-ffa6888d6a86 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615298080; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=1+KscXvyCCD81TD7F9sW2175DPD5UtaWe9uwNTX/4lE=; b=XA9blZjoX/zNTUASH/WEB4DWDYsCIzHEv/Y9j+RGT1i4sLbVz7bGOldC LDb+HUONpVdiGakFqzXmEJkyxQ6/bEba98MavOuSspFonquMRKwNE8nH0 hw1uxJIshBKsvJ30DX+XzpW2j09yy7c5L5A+oan2PJ6++1Mf51sUYin3Y 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 7BTF9tYZq/oJHFo9+fB43BybqSCa9BsLB22fhRHUsO1xn3B+XgZX8oM7LUXUutUZF7hSqOhM1r zL9RBZYKTxypwoqA00q4+f+e+MV+gJSSARO1m3aESkMN0cTnu4ALTSWqHwAJcclD5VGrBUEnzv BQdSHq0zBJhMKW3OV6bIKo15SgJnFiR0PJLat3mjQhU2YDnM/o5WiR6N674ZRMJjripUwZnZeI zaL3Et02Q/52oXh/xVv/EpVQcZGnMo/p0VR/8tmsvge2+1w2hS73ZGmSJ0Z/weKHMPMPcgmwBL nfM= X-SBRS: 5.2 X-MesageID: 39226148 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,234,1610427600"; d="scan'208";a="39226148" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G4vfSxcrU6nhlKKD/fnPp8zC1LgVd8MfrL8OzdPH5oychq9IQsLc5bJ4LvQXEWjpZZyuULFKTPmMO95HxOG+QBqxKtPOsDmIxFHIrM5zy9sYg3nEUF8AHIzD9zdafpSwCoArPzAM8KmmQPMG8rYmeVuWIX2+n0zrPZP/t+UUH6os65bONYyh8hRltFhONuMy4bp63baBO+9Vpt/oazOh27KGLji9XXRDGAVOAGVguUNgrBlTkk2PMBApx6/+fWVqD+U5YptEgvX8IkIJnPwUJsRrPgMV+bY3oe9EJRqE+My7kvzVFuJt8V34ZXTeBkoO6MV0+4ihLwPlIv4QDBsusA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D6nC5FmpFN+MJz4419r0TamyGM7/BsI6Yi5wphL6dqY=; b=CUm0co0sPuQebDdkvbmL3hQsspdvMuFTVOt30ZyzGO/N596CJhRrabA69GDWmzlAKfHey1ot++7zTC+/6NNQOc8+MO57UQMde/givqRMaXbHHRaTv8xoH5DiwOTPqTUNcThiUJpKO5g0YTxZi8AhoshfhPIrLCloQtcaYFlrlZPGFQViY8Jn0MNEPZpR1QhYth0T3iW+1IeoTFnAIA9CIDYUMvt1+rPvy47WRzGlQrJc+CqMIbahA6thP1mR3XwMw64PjEmEfTd+0/AenpER4wd7dgM/IyKFIHR5YeLytO7rmQxEOMBdGTnaNSmdWyxH7KsKm0ipYxfArECaiF/YzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D6nC5FmpFN+MJz4419r0TamyGM7/BsI6Yi5wphL6dqY=; b=aQ69vAHn5hnq7+iBA/APE0S6Kzj20TKtatHkLzoVLGa8CK/P1O6JidI7o7C9SJis6cy35PPQ/S1wbO0lsR2LChWvoLARq0vhLm0VEFSYnEQe15ClbJRL+02FMcY1Gw8SfZXQZhwzhHwmRKeO0/1MS9+d2SoDoMvU7+F6Enyr9hc= Date: Tue, 9 Mar 2021 14:53:53 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Ian Jackson , Wei Liu , Andrew Cooper , George Dunlap , "Julien Grall" , Stefano Stabellini , "Anthony PERARD" , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky , Subject: Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection Message-ID: References: <20210309105634.7200-1-roger.pau@citrix.com> <37e82170-8097-1eda-95d9-23d235075a67@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <37e82170-8097-1eda-95d9-23d235075a67@suse.com> X-ClientProxiedBy: LO2P265CA0135.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::27) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 16945f3a-b25b-4693-1b87-08d8e302c9ed X-MS-TrafficTypeDiagnostic: DM6PR03MB4057: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J8LBlOlpSMXp3gJB61iJ0TG7djpAGegB7/YWMwyb69+COPGiVxNERcUV7UMx/shwtyVqMztNQUO6ueCyNAPi+wZnKz/R8dEFWxKZoVzFzglWIHDvFGK3Ceft7AtTNZCHgPmc3jGd9/A97qHiCOcngpH/SWp+/JR8gSlJwAA26tLUN8UQhJZAu78QNpIA4atuFWFYhQyk9akHqe5lT4bfHVUQ5crwXPGxSPDLdJgFoOVnH1+xa1CMNl9smo3jz5HagigxLWfI0f8jyHlT7dxrH25wUSn+DPmrmbH5Qm8nogm1FJinVwK695bWNMqZu+gy40GD/dq450pYx9UZlX9SnZd+DGhFa4g8rjwYDTBDme6jLR26UgMkCh0tlEfwCk5TG54Xpp3er+hj4bzotgxbrMMPcF2v0UmOUULKO214aiL9xcPaURiwdXBNeU6539SRRpKQnywXfPApgP2zWmfp1v6VGydugJaZBgafESnsg5m0ipshJAVg1svx1EF3veh/1prS53DPcgg8ZUZymblCGA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(396003)(366004)(376002)(136003)(346002)(39860400002)(6496006)(6666004)(53546011)(8676002)(7416002)(33716001)(6486002)(9686003)(85182001)(5660300002)(86362001)(186003)(66946007)(66556008)(16526019)(478600001)(4326008)(26005)(54906003)(956004)(8936002)(6916009)(83380400001)(316002)(2906002)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aEt2WUo4YW1SeUlRN1Y2d293WHBNYVhrZk1aUWVaSzhTaXVoOU9aaGNpSnpr?= =?utf-8?B?WnF6SnkwaVV1ZXY2ZVltVDF1S29JcjI3VEpTNzNZOTVuaUVBZmxmVUw5eVRt?= =?utf-8?B?WFgzMVNnQ0Y3QXk1eDNoK1lQamdVNTBjbnRGTU5sSXk4UGtGTVVQMEF2aDF4?= =?utf-8?B?TmtWM2RRT3FOcG1SNFExdWd3dzNiRStsQjlwQUtHR2JrQ1VyRWx0WlVhWlVT?= =?utf-8?B?TFRjQTZlRDBoeGtaWEU2M292Sjd1R0hVbHF1bjBCK3dLcDZkeml0KytrbE9E?= =?utf-8?B?NW1yem1ldVh2WXlUK09jNmMrazJETVVWVnYrbjJYQ1VZZzVEc0RySUYvNWVs?= =?utf-8?B?MVpZaWNIOVFkeDVLR1JJbzQ3R1h6R0pFVHRyYW9wYXNVaFl6a29FTEhZNmxV?= =?utf-8?B?M1g2QnZhQkhpV3doWkY4NE1tKzczeXUySngvZU9BWWRzWGdaUGFoM3Y0eFNB?= =?utf-8?B?UnpjK1Q2Z21QZTZZVXJuTEUyNkJEWnY4ZzAvamFjN1Y3SmNBSCtlSHFZUFJW?= =?utf-8?B?Z0RlMWxJVXZWdEYzbGZKNXpad1lCb3VLNURFRHBVRk5qellTYTB3YVdwQ0Vl?= =?utf-8?B?OFRYS3hOMCtGZ2ZxNDY1OTRSS0gvd2JWdnRuMG5TZXRIVmt3VVN4UjNOSFo4?= =?utf-8?B?QjN6Q2I2eFlJZWplZG9kY1hqaDZrMzdvbGErZG1SZHF6RkxObDZVbFB0aHdP?= =?utf-8?B?Q1QwR3YyNlF4Qk5VdHd5ZksxVDFPeDVIT3Bob04wMzkyN2ZCSWZ2SVFlNHFv?= =?utf-8?B?U2ZZZis0Vlh6a3gwelJONmlQbWQ1aUVvL1h1ai9vMThrQkJXOGxRS1VBOVl2?= =?utf-8?B?TkpmQWtvMTcvY0R1MTYxVytSRVJXZ0JGZVVnc3pld0RLVnRjK0orZlhQcG5s?= =?utf-8?B?UndwS0ZvY3pPWnY1b0ZXWkNRMlVVaTV4U2FjbWpaV3NpT1QvL2NlZlZoV2Jn?= =?utf-8?B?WmZpSXlmNDZDQnpPU1ppNUtuc1JpeE9ob0drcDZaTWdnQ0ZHZHFOOHNFVFlo?= =?utf-8?B?SDdpakg1cWtnckhyaTZZVVIwVzBFZHV5cUJZZGxoREtwWkQ4WkJpOTFSc1dp?= =?utf-8?B?dWVYczlzWDIxSmNHRDV1V2pVV2hiUkdCMUw0WXhvTktQVHh5cHY1eXlPbURp?= =?utf-8?B?Yi9UYkl0SndhYlBmZnh2ZjkrK2FRY1ovdks0WWJaWXpNdWs1aWR6bS9NMC9F?= =?utf-8?B?YU9VM1JwRm01R0NUN1Z1eE4vS1dGbGwxcy94NWdLOEErbldtVW9icVUrb0tW?= =?utf-8?B?OXhCQ2VsRzNxRmdMTUlVZE5xV0M1b3Z6bEIrRUdCeU94S1A2SVhIWFUzZlpO?= =?utf-8?B?VmxCRzBzSlNoSENublJPVFFoaTZFMm84WlV5NGlNdXpHTW1Bdy8xOFBqUFZQ?= =?utf-8?B?TTNueGNsZzUzZjQ2NzlrWGYyMytHSERPa1lJM2Q5UkpMQTVaRVpnZWZxSnJk?= =?utf-8?B?Z0JUNnhjMEJzT1pJL0svUVFIRGlPNWE4K1NmYndsYXhXT294WjB4SHRUdlZZ?= =?utf-8?B?d2pQNkl1M1NGelVJWEJGTjRjMm1rUW81UzN3WTFtN1loY09BQ3BEMVZmWmFl?= =?utf-8?B?eTFkS3lDSkx6WWtxS0ZoUDFnLzZ6Z005UHpPRFNzZFY5M3RWMVk1SEpRbGcr?= =?utf-8?B?SkE5bHcrR3BQSU1UOTd2c3ZHRVBBUFV3RVVBL0t0VXJvOW5yQnNkWG1qbm9r?= =?utf-8?B?RXdWQXU2WXo3cDNaTVdTK085K3kyaC9yMFhLWkxIWXpBenhEQTRqTzJQNTJw?= =?utf-8?B?RlYxaWpLbWlvMXU0MVhUQnNMN2N1SjI3MFQveDNGQmJaT2hRNG1iVTduS2lk?= =?utf-8?B?YmxiQkVPL2lPMGI5RnVhZz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 16945f3a-b25b-4693-1b87-08d8e302c9ed X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 13:53:59.1757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nBO6exsclYOaEm5txLnqoXvHxs2jnKYjBqrivIgK0ohh7GL1M3wOi9hLVLkJ2Y3cA9MZBOzn7Ns4FYbqK96u/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4057 X-OriginatorOrg: citrix.com On Tue, Mar 09, 2021 at 12:36:39PM +0100, Jan Beulich wrote: > On 09.03.2021 11:56, Roger Pau Monne wrote: > > Introduce an option to allow selecting a behavior similar to the pre > > Xen 4.15 one for accesses to MSRs not explicitly handled. Since commit > > 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly > > handled by Xen result in the injection of a #GP to the guest. This > > is a behavior change since previously a #GP was only injected if > > accessing the MSR on the real hardware would also trigger a #GP, or if > > the attempted to be set bits wouldn't match the hardware values (for > > PV). > > > > This seems to be problematic for some guests, so introduce an option > > to fallback to this kind of legacy behavior without leaking the > > underlying MSR values to the guest. > > > > When the option is set, for both PV and HVM don't inject a #GP to the > > guest on MSR read if reading the underlying MSR doesn't result in a > > #GP, do the same for writes and simply discard the value to be written > > on that case. > > > > Note that for guests restored or migrated from previous Xen versions > > the option is enabled by default, in order to keep a compatible > > MSR behavior. Such compatibility is done at the libxl layer, to avoid > > higher-level toolstacks from having to know the details about this flag. > > > > Signed-off-by: Roger Pau Monné > > I'm generally okay with this approach, but wouldn't want to give it > my R-b until it's at least clear it's not entirely unacceptable to > anyone else (Andrew in particular). Couple of remarks: Thanks. > > Changes since v2: > > - Apply the option to both HVM and PV guest. > > - Handle both reads and writes. > > I take it that it's intentional that you didn't allow separate read > and write control? Yes, I don't have a strong opinion, but I think just having a single option is better: guests requiring the read side bodge are also likely to require the same adjustment on the write side. It's also better from a user perspective, as it's likely people would enable them in tandem anyway. > > > --- a/xen/arch/x86/hvm/svm/svm.c > > +++ b/xen/arch/x86/hvm/svm/svm.c > > @@ -1795,6 +1795,7 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) > > const struct domain *d = v->domain; > > struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; > > const struct nestedsvm *nsvm = &vcpu_nestedsvm(v); > > + uint64_t tmp; > > > > switch ( msr ) > > { > > While to some degree a matter of taste, I think such variables needed > only inside a switch() and not needing an initializer would better > live in the respective switch()'s scope. I can indeed define them inside the switch statement. > > --- a/xen/arch/x86/pv/emul-priv-op.c > > +++ b/xen/arch/x86/pv/emul-priv-op.c > > @@ -875,6 +875,7 @@ static int read_msr(unsigned int reg, uint64_t *val, > > const struct domain *currd = curr->domain; > > const struct cpuid_policy *cp = currd->arch.cpuid; > > bool vpmu_msr = false; > > + uint64_t tmp; > > int ret; > > > > if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) > > @@ -986,6 +987,12 @@ static int read_msr(unsigned int reg, uint64_t *val, > > } > > /* fall through */ > > default: > > + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, tmp) ) > > + { > > + *val = 0; > > + return X86EMUL_OKAY; > > + } > > + > > gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); > > break; > > > > @@ -1148,6 +1155,9 @@ static int write_msr(unsigned int reg, uint64_t val, > > } > > /* fall through */ > > default: > > + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, val) ) > > + return X86EMUL_OKAY; > > + > > gdprintk(XENLOG_WARNING, > > "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", > > reg, val); > > So what are your thoughts wrt my change to this file? Drop it > altogether and require people to use this new option? Or do you > see both coexist? I wouldn't be opposed to have both changes co-exist, as long as the PV one is made part of the PV ABI, that is have it properly described in the public headers as part of the PV behavior. I've replied with some details along those lines in your patch. > In the latter case, since you had suggested > that I drop the write side of my change - does your changing of > the write path indicate you've changed your mind? Yes, I think we need to provide an option to allow users to revert back to an MSR behavior as close as possible to the previous one for compatibility reasons, and that should include the write side even if we don't know any users requiring it right now. We would be in a bad position if that use-case gets discovered after the release, so it's IMO best to provide an option that covers both read and write side straight away. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 09 13:55:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 13:55:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95441.180255 (Exim 4.92) (envelope-from ) id 1lJcpS-0006I0-98; Tue, 09 Mar 2021 13:55:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95441.180255; Tue, 09 Mar 2021 13:55:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcpS-0006Ht-6D; Tue, 09 Mar 2021 13:55:18 +0000 Received: by outflank-mailman (input) for mailman id 95441; Tue, 09 Mar 2021 13:55:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJcpQ-0006Hl-2P for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 13:55:16 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 6ab6ce86-6b27-4ca5-a82f-8fd2d5728429; Tue, 09 Mar 2021 13:55:13 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7E52131B; Tue, 9 Mar 2021 05:55:13 -0800 (PST) Received: from [10.57.15.131] (unknown [10.57.15.131]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2C18C3F71B; Tue, 9 Mar 2021 05:55:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ab6ce86-6b27-4ca5-a82f-8fd2d5728429 Subject: Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Julien Grall , Jan Beulich Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210308135937.1692-1-michal.orzel@arm.com> <745c5049-fb09-5605-8bc1-838a4def45d6@xen.org> <3353ecf1-3a76-70ee-0475-b7eed90c783c@arm.com> <1a1c8cf1-4c41-7fe2-ef4c-4f92d5b956c8@suse.com> From: Michal Orzel Message-ID: <4a2a8caa-fc13-e18d-6c60-02f3597dc9f9@arm.com> Date: Tue, 9 Mar 2021 14:55:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09.03.2021 14:32, Julien Grall wrote: > > > On 09/03/2021 11:07, Jan Beulich wrote: >> On 09.03.2021 11:20, Julien Grall wrote: >>> On 09/03/2021 07:34, Michal Orzel wrote: >>>> On 08.03.2021 15:31, Julien Grall wrote: >>>>> On 08/03/2021 13:59, Michal Orzel wrote: >>>>>> --- a/xen/arch/arm/Makefile >>>>>> +++ b/xen/arch/arm/Makefile >>>>>> @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o >>>>>>       #obj-bin-y += ....o >>>>>>     -ifdef CONFIG_DTB_FILE >>>>>> +ifneq ($(CONFIG_DTB_FILE),"") >>>>>>     obj-y += dtb.o >>>>>>     AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>>>>     endif >>>>>> @@ -137,8 +137,6 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >>>>>>     xen.lds: xen.lds.S >>>>>>         $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >>>>>>     -dtb.o: $(CONFIG_DTB_FILE) >>>>>> - >>>>> >>>>> Why is this dropped? >>>> 1)This line is not needed as it has no impact on creating dtb.o >>>> 2)It causes the build failure once CONFIG_DTB_FILE option is in the Kconfig as string within quotes. >>> >>> Because of 1), this should have ideally be part of a separate patch. But >>> I am OK to keep it in this patch so long it is explained in the commit >>> message. >> >> Wasn't the intention to have dtb.o re-compiled when the blob >> has changed? This would be lost with the removal of this line. > > Ah yes. I was only thinking about a name change (this would be caught via the update of the config header) and not a file update. > I already pushed v3 but I agree. Something like this would do the job: dtb.o: $(subst $\",,$(CONFIG_DTB_FILE)) to remove quotes From xen-devel-bounces@lists.xenproject.org Tue Mar 09 14:10:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 14:10:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95476.180268 (Exim 4.92) (envelope-from ) id 1lJd42-0008GX-K2; Tue, 09 Mar 2021 14:10:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95476.180268; Tue, 09 Mar 2021 14:10:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJd42-0008GQ-Gy; Tue, 09 Mar 2021 14:10:22 +0000 Received: by outflank-mailman (input) for mailman id 95476; Tue, 09 Mar 2021 14:10:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJd41-0008GL-Ug for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:10:21 +0000 Received: from smtp-fw-6002.amazon.com (unknown [52.95.49.90]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d6795f7e-60c9-4c60-a1db-2d8f861f6134; Tue, 09 Mar 2021 14:10:21 +0000 (UTC) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-1d-e69428c4.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-6002.iad6.amazon.com with ESMTP; 09 Mar 2021 14:10:15 +0000 Received: from EX13D12EUA001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-1d-e69428c4.us-east-1.amazon.com (Postfix) with ESMTPS id D86F9C081F for ; Tue, 9 Mar 2021 14:10:13 +0000 (UTC) Received: from EX13D12EUA002.ant.amazon.com (10.43.165.103) by EX13D12EUA001.ant.amazon.com (10.43.165.48) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 9 Mar 2021 14:10:12 +0000 Received: from EX13D12EUA002.ant.amazon.com ([10.43.165.103]) by EX13D12EUA002.ant.amazon.com ([10.43.165.103]) with mapi id 15.00.1497.012; Tue, 9 Mar 2021 14:10:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: d6795f7e-60c9-4c60-a1db-2d8f861f6134 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1615299022; x=1646835022; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=n3fVoOlqvOn69GDOJ2orF6qiOsuOKIaHcOrcPH2dSJg=; b=MZ6jMSJPiGgDuGvS4r2Cr2TwDLTizznuiBHT42F5SoJ6pANCmGwKhPgB JZpByg1lh0Nnd+Nhkl8f7/2RqdycB2XhKSS8HdtX4Sr3UYnQe8RHy8FbV UEwJoeIrffsTDOhUk6QcDUz7xIJhSiqTidnGjIVInewQ5iX81x/MQU2A9 0=; X-IronPort-AV: E=Sophos;i="5.81,234,1610409600"; d="scan'208";a="95673226" From: "Hsu, Chiahao" To: "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 1/2] xen-netback: add module parameter to disable ctrl-ring Thread-Topic: [PATCH 1/2] xen-netback: add module parameter to disable ctrl-ring Thread-Index: AQHXC3Ho66sjBAH4ck+AJsybt15sHap71bYA Date: Tue, 9 Mar 2021 14:10:12 +0000 Message-ID: References: <20210225122940.9310-1-andyhsu@amazon.com> In-Reply-To: <20210225122940.9310-1-andyhsu@amazon.com> Accept-Language: en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.165.171] Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: Bulk DQoNCu+7v09uIDI1LjAyLjIxLCAxMzoyOSwgIkhzdSwgQ2hpYWhhbyIgPGFuZHloc3VAYW1hem9u LmNvbT4gd3JvdGU6DQoNCiAgICBJbiBvcmRlciB0byBzdXBwb3J0IGxpdmUgbWlncmF0aW9uIG9m IGd1ZXN0cyBiZXR3ZWVuIGtlcm5lbHMNCiAgICB0aGF0IGRvIGFuZCBkbyBub3Qgc3VwcG9ydCAn ZmVhdHVyZS1jdHJsLXJpbmcnLCB3ZSBhZGQgYQ0KICAgIG1vZHVsZSBwYXJhbWV0ZXIgdGhhdCBh bGxvd3MgdGhlIGZlYXR1cmUgdG8gYmUgZGlzYWJsZWQNCiAgICBhdCBydW4gdGltZSwgaW5zdGVh ZCBvZiB1c2luZyBoYXJkY29kZSB2YWx1ZS4NCiAgICBUaGUgZGVmYXVsdCB2YWx1ZSBpcyBlbmFi bGUuDQoNCiAgICBTaWduZWQtb2ZmLWJ5OiBDaGlhSGFvIEhzdSA8YW5keWhzdUBhbWF6b24uY29t Pg0KICAgIC0tLQ0KICAgICBkcml2ZXJzL25ldC94ZW4tbmV0YmFjay9jb21tb24uaCAgfCAgMiAr Kw0KICAgICBkcml2ZXJzL25ldC94ZW4tbmV0YmFjay9uZXRiYWNrLmMgfCAgNiArKysrKysNCiAg ICAgZHJpdmVycy9uZXQveGVuLW5ldGJhY2sveGVuYnVzLmMgIHwgMTMgKysrKysrKystLS0tLQ0K ICAgICAzIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pDQoN CiAgICBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svY29tbW9uLmggYi9kcml2 ZXJzL25ldC94ZW4tbmV0YmFjay9jb21tb24uaA0KICAgIGluZGV4IDRhMTZkNmUzM2MwOS4uYmZi N2EzMDU0OTE3IDEwMDY0NA0KICAgIC0tLSBhL2RyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL2NvbW1v bi5oDQogICAgKysrIGIvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svY29tbW9uLmgNCiAgICBAQCAt Mjc2LDYgKzI3Niw3IEBAIHN0cnVjdCBiYWNrZW5kX2luZm8gew0KICAgICAJdTggaGF2ZV9ob3Rw bHVnX3N0YXR1c193YXRjaDoxOw0KDQogICAgIAljb25zdCBjaGFyICpob3RwbHVnX3NjcmlwdDsN CiAgICArCWJvb2wgY3RybF9yaW5nX2VuYWJsZWQ7DQogICAgIH07DQoNCiAgICAgc3RydWN0IHhl bnZpZiB7DQogICAgQEAgLTQxMyw2ICs0MTQsNyBAQCBzdGF0aWMgaW5saW5lIHBlbmRpbmdfcmlu Z19pZHhfdCBucl9wZW5kaW5nX3JlcXMoc3RydWN0IHhlbnZpZl9xdWV1ZSAqcXVldWUpDQoNCiAg ICAgaXJxcmV0dXJuX3QgeGVudmlmX2ludGVycnVwdChpbnQgaXJxLCB2b2lkICpkZXZfaWQpOw0K DQogICAgK2V4dGVybiBib29sIGNvbnRyb2xfcmluZzsNCiAgICAgZXh0ZXJuIGJvb2wgc2VwYXJh dGVfdHhfcnhfaXJxOw0KICAgICBleHRlcm4gYm9vbCBwcm92aWRlc194ZHBfaGVhZHJvb207DQoN CiAgICBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svbmV0YmFjay5jIGIvZHJp dmVycy9uZXQveGVuLW5ldGJhY2svbmV0YmFjay5jDQogICAgaW5kZXggZTVjNzNmODE5NjYyLi4y MGQ4NThmMDQ1NmEgMTAwNjQ0DQogICAgLS0tIGEvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svbmV0 YmFjay5jDQogICAgKysrIGIvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svbmV0YmFjay5jDQogICAg QEAgLTQ4LDYgKzQ4LDEyIEBADQoNCiAgICAgI2luY2x1ZGUgPGFzbS94ZW4vaHlwZXJjYWxsLmg+ DQoNCiAgICArLyogUHJvdmlkZSBhbiBvcHRpb24gdG8gZGlzYWJsZSBjb250cm9sIHJpbmcgd2hp Y2ggaXMgdXNlZCB0byBwYXNzDQogICAgKyAqIGxhcmdlIHF1YW50aXRpZXMgb2YgZGF0YSBmcm9t IGZyb250ZW5kIHRvIGJhY2tlbmQuDQogICAgKyAqLw0KICAgICtib29sIGNvbnRyb2xfcmluZyA9 IHRydWU7DQogICAgK21vZHVsZV9wYXJhbShjb250cm9sX3JpbmcsIGJvb2wsIDA2NDQpOw0KICAg ICsNCiAgICAgLyogUHJvdmlkZSBhbiBvcHRpb24gdG8gZGlzYWJsZSBzcGxpdCBldmVudCBjaGFu bmVscyBhdCBsb2FkIHRpbWUgYXMNCiAgICAgICogZXZlbnQgY2hhbm5lbHMgYXJlIGxpbWl0ZWQg cmVzb3VyY2UuIFNwbGl0IGV2ZW50IGNoYW5uZWxzIGFyZQ0KICAgICAgKiBlbmFibGVkIGJ5IGRl ZmF1bHQuDQogICAgZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL3hlbmJ1cy5j IGIvZHJpdmVycy9uZXQveGVuLW5ldGJhY2sveGVuYnVzLmMNCiAgICBpbmRleCBhNTQzOWMxMzAx MzAuLjhhOTE2OWNmZjljNSAxMDA2NDQNCiAgICAtLS0gYS9kcml2ZXJzL25ldC94ZW4tbmV0YmFj ay94ZW5idXMuYw0KICAgICsrKyBiL2RyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL3hlbmJ1cy5jDQog ICAgQEAgLTExMjMsMTEgKzExMjMsMTQgQEAgc3RhdGljIGludCBuZXRiYWNrX3Byb2JlKHN0cnVj dCB4ZW5idXNfZGV2aWNlICpkZXYsDQogICAgIAlpZiAoZXJyKQ0KICAgICAJCXByX2RlYnVnKCJF cnJvciB3cml0aW5nIG11bHRpLXF1ZXVlLW1heC1xdWV1ZXNcbiIpOw0KDQogICAgLQllcnIgPSB4 ZW5idXNfcHJpbnRmKFhCVF9OSUwsIGRldi0+bm9kZW5hbWUsDQogICAgLQkJCSAgICAiZmVhdHVy ZS1jdHJsLXJpbmciLA0KICAgIC0JCQkgICAgIiV1IiwgdHJ1ZSk7DQogICAgLQlpZiAoZXJyKQ0K ICAgIC0JCXByX2RlYnVnKCJFcnJvciB3cml0aW5nIGZlYXR1cmUtY3RybC1yaW5nXG4iKTsNCiAg ICArCWJlLT5jdHJsX3JpbmdfZW5hYmxlZCA9IFJFQURfT05DRShjb250cm9sX3JpbmcpOw0KICAg ICsJaWYgKGJlLT5jdHJsX3JpbmdfZW5hYmxlZCkgew0KICAgICsJCWVyciA9IHhlbmJ1c19wcmlu dGYoWEJUX05JTCwgZGV2LT5ub2RlbmFtZSwNCiAgICArCQkJCSAgICAiZmVhdHVyZS1jdHJsLXJp bmciLA0KICAgICsJCQkJICAgICIldSIsIHRydWUpOw0KICAgICsJCWlmIChlcnIpDQogICAgKwkJ CXByX2RlYnVnKCJFcnJvciB3cml0aW5nIGZlYXR1cmUtY3RybC1yaW5nXG4iKTsNCiAgICArCX0N Cg0KICAgICAJYmFja2VuZF9zd2l0Y2hfc3RhdGUoYmUsIFhlbmJ1c1N0YXRlSW5pdFdhaXQpOw0K DQogICAgLS0gDQogICAgMi4yMy4zDQoNCkdlbnRsZSBwaW5nLg0KDQo= From xen-devel-bounces@lists.xenproject.org Tue Mar 09 14:18:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 14:18:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95481.180280 (Exim 4.92) (envelope-from ) id 1lJdBs-00006Q-Et; Tue, 09 Mar 2021 14:18:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95481.180280; Tue, 09 Mar 2021 14:18:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdBs-00006J-Bn; Tue, 09 Mar 2021 14:18:28 +0000 Received: by outflank-mailman (input) for mailman id 95481; Tue, 09 Mar 2021 14:18:27 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdBr-00006E-KF for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:18:27 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ca759845-8655-405a-95ee-0941319d7786; Tue, 09 Mar 2021 14:18:26 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 19635AD73; Tue, 9 Mar 2021 14:18:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca759845-8655-405a-95ee-0941319d7786 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615299506; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CHh8+kJ84TZtcBZshuUDucjJA4FWbaKgQHy8XtOErIQ=; b=C1eW7VdPW+Uis2KKBKSeYxkt2J6/IadkWOfQ6dlaAMnskoCScj+hAWKwjgRUwDW2dURnB1 nijHjG6muiAjZJBF4nyXMCS2q6+VfCzwp6er5yMUFNBpHwIrA++SCBHvldYzHtc6VBCJLs ZFxTu8z7vllrlVL3sZ4cgfbzG9cVTDQ= Subject: Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org, Julien Grall References: <20210308135937.1692-1-michal.orzel@arm.com> <745c5049-fb09-5605-8bc1-838a4def45d6@xen.org> <3353ecf1-3a76-70ee-0475-b7eed90c783c@arm.com> <1a1c8cf1-4c41-7fe2-ef4c-4f92d5b956c8@suse.com> <4a2a8caa-fc13-e18d-6c60-02f3597dc9f9@arm.com> From: Jan Beulich Message-ID: Date: Tue, 9 Mar 2021 15:18:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <4a2a8caa-fc13-e18d-6c60-02f3597dc9f9@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09.03.2021 14:55, Michal Orzel wrote: > > > On 09.03.2021 14:32, Julien Grall wrote: >> >> >> On 09/03/2021 11:07, Jan Beulich wrote: >>> On 09.03.2021 11:20, Julien Grall wrote: >>>> On 09/03/2021 07:34, Michal Orzel wrote: >>>>> On 08.03.2021 15:31, Julien Grall wrote: >>>>>> On 08/03/2021 13:59, Michal Orzel wrote: >>>>>>> --- a/xen/arch/arm/Makefile >>>>>>> +++ b/xen/arch/arm/Makefile >>>>>>> @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o >>>>>>>       #obj-bin-y += ....o >>>>>>>     -ifdef CONFIG_DTB_FILE >>>>>>> +ifneq ($(CONFIG_DTB_FILE),"") >>>>>>>     obj-y += dtb.o >>>>>>>     AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>>>>>     endif >>>>>>> @@ -137,8 +137,6 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >>>>>>>     xen.lds: xen.lds.S >>>>>>>         $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >>>>>>>     -dtb.o: $(CONFIG_DTB_FILE) >>>>>>> - >>>>>> >>>>>> Why is this dropped? >>>>> 1)This line is not needed as it has no impact on creating dtb.o >>>>> 2)It causes the build failure once CONFIG_DTB_FILE option is in the Kconfig as string within quotes. >>>> >>>> Because of 1), this should have ideally be part of a separate patch. But >>>> I am OK to keep it in this patch so long it is explained in the commit >>>> message. >>> >>> Wasn't the intention to have dtb.o re-compiled when the blob >>> has changed? This would be lost with the removal of this line. >> >> Ah yes. I was only thinking about a name change (this would be caught via the update of the config header) and not a file update. >> > I already pushed v3 but I agree. Something like this would do the job: > dtb.o: $(subst $\",,$(CONFIG_DTB_FILE)) > to remove quotes Besides struggling with the $\", may I suggest $(patsubst "%",%,$(CONFIG_DTB_FILE))? If the double quote needs special treatment, I think it wants to be done via an abstraction similar to squote (near the top of ./Config.mk). Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 09 14:26:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 14:26:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95489.180292 (Exim 4.92) (envelope-from ) id 1lJdJM-00010a-At; Tue, 09 Mar 2021 14:26:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95489.180292; Tue, 09 Mar 2021 14:26:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdJM-00010T-7r; Tue, 09 Mar 2021 14:26:12 +0000 Received: by outflank-mailman (input) for mailman id 95489; Tue, 09 Mar 2021 14:26:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdJK-00010O-HB for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:26:10 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 23d1705d-e7f6-443c-99dd-88014623a5bd; Tue, 09 Mar 2021 14:26:09 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id ABD65AC17; Tue, 9 Mar 2021 14:26:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23d1705d-e7f6-443c-99dd-88014623a5bd X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615299968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=56p7MiJSbaJf5fIy8fOA/tm5Y3KDcQA+btAd5tWgcMc=; b=obpEupJ3M2EAeCS6ZjOfKJy3BNwgsdbONJe48QZKzdeabIpTa1klPsDVa6oGU6JOWUvaMZ xHbZMDToMt0Gz7B3+cN1KNAxqQJVQhEUnZk+U/+5MRwvOKPM/Z4TTu2gdzPkUl3IYUn0zI XYCDI2t8n9uWlcfg1z+Mnh2IT01Iako= Subject: Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Ian Jackson , Wei Liu , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky , xen-devel@lists.xenproject.org References: <20210309105634.7200-1-roger.pau@citrix.com> <37e82170-8097-1eda-95d9-23d235075a67@suse.com> From: Jan Beulich Message-ID: Date: Tue, 9 Mar 2021 15:26:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09.03.2021 14:53, Roger Pau Monné wrote: > On Tue, Mar 09, 2021 at 12:36:39PM +0100, Jan Beulich wrote: >> On 09.03.2021 11:56, Roger Pau Monne wrote: >>> Changes since v2: >>> - Apply the option to both HVM and PV guest. >>> - Handle both reads and writes. >> >> I take it that it's intentional that you didn't allow separate read >> and write control? > > Yes, I don't have a strong opinion, but I think just having a single > option is better: guests requiring the read side bodge are also likely > to require the same adjustment on the write side. I'm not convinced of this - there are many MSRs which merely need reading to discover a certain piece of (configuration) information. Note in e.g. how the problem I did run into was affecting RDMSR only. > It's also better > from a user perspective, as it's likely people would enable them in > tandem anyway. This part I agree with; in fact I did mention this earlier on. >>> --- a/xen/arch/x86/pv/emul-priv-op.c >>> +++ b/xen/arch/x86/pv/emul-priv-op.c >>> @@ -875,6 +875,7 @@ static int read_msr(unsigned int reg, uint64_t *val, >>> const struct domain *currd = curr->domain; >>> const struct cpuid_policy *cp = currd->arch.cpuid; >>> bool vpmu_msr = false; >>> + uint64_t tmp; >>> int ret; >>> >>> if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) >>> @@ -986,6 +987,12 @@ static int read_msr(unsigned int reg, uint64_t *val, >>> } >>> /* fall through */ >>> default: >>> + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, tmp) ) >>> + { >>> + *val = 0; >>> + return X86EMUL_OKAY; >>> + } >>> + >>> gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); >>> break; >>> >>> @@ -1148,6 +1155,9 @@ static int write_msr(unsigned int reg, uint64_t val, >>> } >>> /* fall through */ >>> default: >>> + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, val) ) >>> + return X86EMUL_OKAY; >>> + >>> gdprintk(XENLOG_WARNING, >>> "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", >>> reg, val); >> >> So what are your thoughts wrt my change to this file? Drop it >> altogether and require people to use this new option? Or do you >> see both coexist? > > I wouldn't be opposed to have both changes co-exist, as long as the PV > one is made part of the PV ABI, that is have it properly described in > the public headers as part of the PV behavior. I've replied with some > details along those lines in your patch. > >> In the latter case, since you had suggested >> that I drop the write side of my change - does your changing of >> the write path indicate you've changed your mind? > > Yes, I think we need to provide an option to allow users to revert > back to an MSR behavior as close as possible to the previous one for > compatibility reasons, and that should include the write side even if > we don't know any users requiring it right now. > > We would be in a bad position if that use-case gets discovered after > the release, so it's IMO best to provide an option that covers both > read and write side straight away. Well, for your change it's indeed "an option". For my change it's not optional behavior (and we also don't mean it to be). Hence I'm not sure what I should read out of your reply. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 09 14:35:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 14:35:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95500.180307 (Exim 4.92) (envelope-from ) id 1lJdRu-00020d-7l; Tue, 09 Mar 2021 14:35:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95500.180307; Tue, 09 Mar 2021 14:35:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdRu-00020W-4i; Tue, 09 Mar 2021 14:35:02 +0000 Received: by outflank-mailman (input) for mailman id 95500; Tue, 09 Mar 2021 14:35:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdRr-00020R-VM for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:35:00 +0000 Received: from mail-wr1-x42f.google.com (unknown [2a00:1450:4864:20::42f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f5c7b684-ed63-4554-a21f-ad3539ce4052; Tue, 09 Mar 2021 14:34:58 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id b18so16031215wrn.6 for ; Tue, 09 Mar 2021 06:34:58 -0800 (PST) Received: from [192.168.1.186] (host86-180-176-157.range86-180.btcentralplus.com. [86.180.176.157]) by smtp.gmail.com with ESMTPSA id b65sm4443957wmh.4.2021.03.09.06.34.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 06:34:57 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f5c7b684-ed63-4554-a21f-ad3539ce4052 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ykdKcwetsEeU37FFz/tVTnKAN0xhUHR88t1wWfcQWyU=; b=mhgUeHZuoQuRH8kFo5oGPpyk5NTo4PqmwKq3jW3b2ZTTVkQcx0C7PUpn+V5CQi0H/F XxlmjjRnGbJxhxY+hI+wTF/+JWZFQpzWyDtR7FRgo3OCQSCIIZN9NMZuf66XViD/O9KX 3wdDPnFmxvyNioIe5lVcPUN3uOCuz5SDJOv+bYlbtTPtdNQ9BqK0RdrsJI6it+8IWIkB tnVRPeTgACeHigwfszCsOLIiSYi8SpL9MlcUNmdKpKJ/IBgQjy9Ol+7A/klT9SKc7kXv R5GDeBo1sXiRbrHrnMGsZu5ORUQZDywh/4Epvx84U1Hos0up5C0KyY7Z7bLPlyGgKHHf gJDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:cc :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ykdKcwetsEeU37FFz/tVTnKAN0xhUHR88t1wWfcQWyU=; b=Dk+6nPIPJqbGYo8WcS/N+TeCqfbrpHuObER6tKhoXvF7Pox7sLWWR+ZTWjq1hSXCSn 0AITeRBnqmnMz2+3OTFadvwvcEW5Ppu9WTU/n3tgMFgrncUmyqSfXhH4Hk8+T4VYQhVP E3y9UI7SqbgI+8xCMCC8Z+1fQYC8jd48AjnfGaZQhXQJyu26fI+b85aUjB1Us/2A/1tQ NfOtJ22MZ+RG2haQwNpnOxApWrh6aB62/kvGDm2SwfWWxXSxZ7SLkvD/hM+8Y7TDFpzU fshGT8BKZH2gUYOGxIaQrVRt3mhVcDzP/Y/M1TkvgyzKD/pGQoz2iX1ucd7cxlepXKGv bwqg== X-Gm-Message-State: AOAM532FZfC8kpujfPX/BxtuQjzSn/emHRpxdKW6U91pNChbbk93R4eE NeTJeNbL5fCe0a6HwP1kB20wPZXOf0Q= X-Google-Smtp-Source: ABdhPJygGFiNAPDkqYITUI9lc89Hyawt0GdntnVpjXdEtssej2edZEfAualjoS6vj7H3Iiy8F1XerQ== X-Received: by 2002:adf:cf11:: with SMTP id o17mr19849085wrj.391.1615300497786; Tue, 09 Mar 2021 06:34:57 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 1/2] xen-netback: add module parameter to disable ctrl-ring To: xen-devel@lists.xenproject.org References: <20210225122940.9310-1-andyhsu@amazon.com> Cc: wl@xen.org Message-ID: <33c5f0f0-0e6e-a42c-46a5-405000715c1c@xen.org> Date: Tue, 9 Mar 2021 14:34:56 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 09/03/2021 14:10, Hsu, Chiahao wrote: > On 25.02.21, 13:29, "Hsu, Chiahao" wrote: > > In order to support live migration of guests between kernels > that do and do not support 'feature-ctrl-ring', we add a > module parameter that allows the feature to be disabled > at run time, instead of using hardcode value. > The default value is enable. > > Signed-off-by: ChiaHao Hsu You should directly CC maintainers, and also I don't see netdev in the To list... Did you send it there? I suspect not, since I don't see 'net-next' in the prefix. Paul > --- > drivers/net/xen-netback/common.h | 2 ++ > drivers/net/xen-netback/netback.c | 6 ++++++ > drivers/net/xen-netback/xenbus.c | 13 ++++++++----- > 3 files changed, 16 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h > index 4a16d6e33c09..bfb7a3054917 100644 > --- a/drivers/net/xen-netback/common.h > +++ b/drivers/net/xen-netback/common.h > @@ -276,6 +276,7 @@ struct backend_info { > u8 have_hotplug_status_watch:1; > > const char *hotplug_script; > + bool ctrl_ring_enabled; > }; > > struct xenvif { > @@ -413,6 +414,7 @@ static inline pending_ring_idx_t nr_pending_reqs(struct xenvif_queue *queue) > > irqreturn_t xenvif_interrupt(int irq, void *dev_id); > > +extern bool control_ring; > extern bool separate_tx_rx_irq; > extern bool provides_xdp_headroom; > > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c > index e5c73f819662..20d858f0456a 100644 > --- a/drivers/net/xen-netback/netback.c > +++ b/drivers/net/xen-netback/netback.c > @@ -48,6 +48,12 @@ > > #include > > +/* Provide an option to disable control ring which is used to pass > + * large quantities of data from frontend to backend. > + */ > +bool control_ring = true; > +module_param(control_ring, bool, 0644); > + > /* Provide an option to disable split event channels at load time as > * event channels are limited resource. Split event channels are > * enabled by default. > diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c > index a5439c130130..8a9169cff9c5 100644 > --- a/drivers/net/xen-netback/xenbus.c > +++ b/drivers/net/xen-netback/xenbus.c > @@ -1123,11 +1123,14 @@ static int netback_probe(struct xenbus_device *dev, > if (err) > pr_debug("Error writing multi-queue-max-queues\n"); > > - err = xenbus_printf(XBT_NIL, dev->nodename, > - "feature-ctrl-ring", > - "%u", true); > - if (err) > - pr_debug("Error writing feature-ctrl-ring\n"); > + be->ctrl_ring_enabled = READ_ONCE(control_ring); > + if (be->ctrl_ring_enabled) { > + err = xenbus_printf(XBT_NIL, dev->nodename, > + "feature-ctrl-ring", > + "%u", true); > + if (err) > + pr_debug("Error writing feature-ctrl-ring\n"); > + } > > backend_switch_state(be, XenbusStateInitWait); > > -- > 2.23.3 > > Gentle ping. > From xen-devel-bounces@lists.xenproject.org Tue Mar 09 14:41:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 14:41:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95508.180320 (Exim 4.92) (envelope-from ) id 1lJdYP-0002zR-0z; Tue, 09 Mar 2021 14:41:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95508.180320; Tue, 09 Mar 2021 14:41:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdYO-0002zK-SQ; Tue, 09 Mar 2021 14:41:44 +0000 Received: by outflank-mailman (input) for mailman id 95508; Tue, 09 Mar 2021 14:41:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdYO-0002zF-8r for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:41:44 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (unknown [40.107.14.79]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fc5e98c0-ac9f-4d60-baa9-d1707628b7e7; Tue, 09 Mar 2021 14:41:43 +0000 (UTC) Received: from AM5PR0301CA0027.eurprd03.prod.outlook.com (2603:10a6:206:14::40) by DB7PR08MB3916.eurprd08.prod.outlook.com (2603:10a6:10:7e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.27; Tue, 9 Mar 2021 14:41:41 +0000 Received: from VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:14:cafe::eb) by AM5PR0301CA0027.outlook.office365.com (2603:10a6:206:14::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Tue, 9 Mar 2021 14:41:40 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT061.mail.protection.outlook.com (10.152.19.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Tue, 9 Mar 2021 14:41:40 +0000 Received: ("Tessian outbound ef5d1dda26b7:v71"); Tue, 09 Mar 2021 14:41:39 +0000 Received: from e1ec0586851f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AC4D401C-BE3D-45A5-B62D-84680C31C20D.1; Tue, 09 Mar 2021 14:41:34 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e1ec0586851f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 09 Mar 2021 14:41:34 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VE1PR08MB5710.eurprd08.prod.outlook.com (2603:10a6:800:1b0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Tue, 9 Mar 2021 14:41:33 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3912.027; Tue, 9 Mar 2021 14:41:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc5e98c0-ac9f-4d60-baa9-d1707628b7e7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nmkRntvzIqeSF3EPYhFBuFd2sali9PIaLs65OqlA918=; b=iYNNTiaNPlz2xVdHQDi1n3rng/EUy8N+OYv/W4a9pikzRbgKsl2peOzo/2kibDmCCFUSOQF85PMBYKNNCTadI2F2KUtinPtj/fWgW0JvnsJSDHAfpOX4OtnW4mAuA0y0Bj/lMnKSxDm1q5Qbi8SeARj0CvMFbVCIN9LpXquPlTU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 89878107be7c7124 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V/beOX0p95uKDQn189uq4ZYSns1HkkJr8kwxcFxx8aumlPMvvLOZgAIZ6sugnUzCCL+W92N/ZtklcygwHd9AcBZ8VlmkE6IDyONtb9i473YIZa7yaLdpwspJ2heiHLTAO4vhQcFVH06Wh9I1gFop4lZvoTBuvpioPAajda9SijMzrsouZcIqJQixIfx6HjsW0tSo103tYCapt8oewaclebSurci4eS+368NJ3+ZMjBOFAOVwqZDK8dbPqNTh+KbZXgvtTCijkUakORxjADh/YGsj41ZCrADjR7LmTzVytL1tK4Wa/n+FDsxJaAVWcAEfOBGm7UWl2bQFt5tsJpEtgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nmkRntvzIqeSF3EPYhFBuFd2sali9PIaLs65OqlA918=; b=j3aEk5EE/casAyIWJuNljN13MnSKY2HNJ8tFnPAkbQALt7eIbQ/xa96gwalK/EF88O9AkNXNW7zMpXfnN5o0j/ph5kMEDJvTzsrfMvKPxEsIZXFuqdFK6Pj11HGsJSySBqp4nhAxpiwk0o2a2TKPc5chKx9ubZ1I7QzIyl7q+2PQjiXcPwbfq7+XvTvJvtGt47LsFrp/mX+AB2ll75GUSjDHKWbU6dpK6rw2dhPh5JyNmbzxWsL/yYeDvnoEsKo08MCtDO7Zl0B80NVr8N7byCN/S4dElEeFT4GpQrRGyAR3Xpe/3V0l9othHyEOadcRcc48ce2pi76fU/Y4F9lBgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nmkRntvzIqeSF3EPYhFBuFd2sali9PIaLs65OqlA918=; b=iYNNTiaNPlz2xVdHQDi1n3rng/EUy8N+OYv/W4a9pikzRbgKsl2peOzo/2kibDmCCFUSOQF85PMBYKNNCTadI2F2KUtinPtj/fWgW0JvnsJSDHAfpOX4OtnW4mAuA0y0Bj/lMnKSxDm1q5Qbi8SeARj0CvMFbVCIN9LpXquPlTU= From: Bertrand Marquis To: Jan Beulich CC: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen/arm: Use register_t type in cpuinfo entries Thread-Topic: [PATCH] xen/arm: Use register_t type in cpuinfo entries Thread-Index: AQHXFFQNaLCX4oSw+0OC1jGtjtl2z6p7f0oAgAA8pIA= Date: Tue, 9 Mar 2021 14:41:33 +0000 Message-ID: <70193A3D-F169-41C3-96AF-D2C35ADAF1C9@arm.com> References: <712d7c6a-3ace-a6b7-a188-faeb4f1258d3@xen.org> <5bb482ff-a689-67e3-1bc7-30b9bf24034e@suse.com> In-Reply-To: <5bb482ff-a689-67e3-1bc7-30b9bf24034e@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.243.24.187] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6ae04af1-140e-404d-5501-08d8e3097380 x-ms-traffictypediagnostic: VE1PR08MB5710:|DB7PR08MB3916: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:5236;OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +RB2rCN0pXafFw3Y2Cnm4rumO7Jvw6Hir1RRQtrxWskWL1GHpZ9zq3+4gvIdqVPDqJBarIKCMVWHSgrmlwXsS8vrlFRzVPdPxhKjHnKmbB1oi1eHMdAcpvd0EvaMTZdkM4RJ4O84undeP3b5pm3ye+wDU7ckdLtI5oyma+xWlZnr3dChcVQZHWTGR5V2mo/kn6qpWY69QQNdIwutMoc0Xg2nRbCijHRMa4yaRZL5hLSIwlk8w83vXrv7gK4kQ257y150wKjnpA7RI6ANDor2r46uV1t9RNBC1oCMDPsd2z4vB3p3GyC93UZHyQ49foVJS/f930bjCoHu6dkg7rn/rTnIGptnYtFlmBawM1fXtR5uLFVc4YqXyLWnRYLxHYAiYLJRVyAvXQsgJS+LcuyEuMP4D+mmNupYqiNT6M4tl/KhpY/a5e87AMupo2F0+3muT80gHxaKgOSdfskXQswR5Qr+0Tng1yBZj3jPJ8Xrvx6VdfxMJ8L7UbyjRSaOnVf+gM3WyQ7kAuZcjQMegeJs5WZtfzVnIBRFbhAS+310boM8HfF1KCSs7MdzN3j47bDraA7EA8PjGogkcwON+WY1Qg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(136003)(376002)(346002)(366004)(54906003)(6512007)(83380400001)(316002)(2906002)(71200400001)(33656002)(8676002)(8936002)(66946007)(76116006)(66476007)(2616005)(91956017)(66556008)(6486002)(64756008)(186003)(478600001)(4326008)(53546011)(4744005)(6506007)(6916009)(5660300002)(26005)(36756003)(66446008)(86362001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Xwt0OMrDVCbxS6HOwLEZqrHr65zh8hd6aSsZCUYIfc4Q4UKKXGwn2Rmt6y9x?= =?us-ascii?Q?CfZEKIhcsCgKx/05FcPcC+f4QBUiebmIzKsjLt+dCviMA1w8znPl2GAsirvn?= =?us-ascii?Q?guE0tcK7C1z15lAH+8tGUcH1ss+xCF5ZjBgobFGNMVyiNfl0K7BXSAlx4RM/?= =?us-ascii?Q?0BkXcewsuULb+yGv0UhuGFzyGzVLmwjHlsXVoQGQ9LMPatpKPaOy0oylLR83?= =?us-ascii?Q?CcGn/2IqkzbuiDfgGTTdUd7yIgSq7aiFOG4P9y0fMkMwNLaHLoS/832opTAo?= =?us-ascii?Q?iKADseGcK14Y/9Hc91vtIAJ3hNP1teTl1R5Xu0qF9YF5/F3pbUpaji5GdqSh?= =?us-ascii?Q?JDqFJF0dGfaWwDCnfl2EAxZiyABgHvevpC/90E7Lte/EwQzGXAd+PwWPC6om?= =?us-ascii?Q?dHARNbwTk/GYKplu3btdIzbuapPvjzNveTVv421Dg7kdjmQ6Gc2/m45YGUzY?= =?us-ascii?Q?RJyKgqF3aOlk6uTyXTticlxLe+SIVjkyZBjgO7MHF9iRUpAA6Pu7S0Z221P7?= =?us-ascii?Q?N10HOYhNJFcIVrTCIVXf5ygHidDonnwGglyHjxN5FXSz/BXF8C67g2eQ6TO8?= =?us-ascii?Q?Wjy+8vIoeaDYNW9ftPxh818HPaq2zdwA10B5F+JeOrlEZH3L0uM0sz8ls8Kq?= =?us-ascii?Q?E5Ry0AtQQtnXuf87TtQFqSbXY5F6PYlm2VZea4Aa6XoBNbBghjvOgIvm60Vd?= =?us-ascii?Q?e7NJ0ftM3poQ8vw/u5IoAtOcnpoqGVsRhD3kOCBoNsTw/8wKZMd666Qjdv78?= =?us-ascii?Q?tiGlKqDpDqHICJ2P6c3LWKnaMNfSiSL6QGRiYHhtX8bYr6UYMpEC57Cp2rEY?= =?us-ascii?Q?XMgIZ1BvsHohyym/M/ih3o6ld0BmM63vdrFvmRRqVzrd8Yup2+jyZZ/KnwQ/?= =?us-ascii?Q?rkxFPdXU1Th+9vbblUvFbSxIuOpDQXM83s/nVmWXIpnAysfDVHv3uoi+zalc?= =?us-ascii?Q?Ap/QrLNJKQGZnCiRS0bX4TnxEiebaYDwuh3wdCBp9Gm7/OcuQrcOB7NGEAVl?= =?us-ascii?Q?innz/nmBV6DUcxpWHT53jVjIWvvhM6OH6PduP7vy4mZtRk0Nbgv9qmCUFw5e?= =?us-ascii?Q?7Y3GklawQf5R549tV5kIIzmYy4BecHK4PWZHZ90W9l6yudsYRzcuhezNgOhh?= =?us-ascii?Q?+Vf3yczjFyTarLAbCJDh4nZOP/g+ziexS3r38nOxG9yO0Si9Pb5BWTiQyAWz?= =?us-ascii?Q?YFRUvOgeU/HOWSw5/R8iqfO3e8bl5j54nJE6NuBTtp1iOBr0oGPpfA7Wu8SO?= =?us-ascii?Q?w8vMVBMGNO/zXrkhN20AiBQs4K8SMNIboHvcYzNc/GCvKg3TVmPozcIfO/Py?= =?us-ascii?Q?e4pjibaILJRX+2AwVzUuXWLu?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5710 Original-Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: adcb4ab1-036b-477b-1eed-08d8e3096f1c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 42HOctwvTn2bN4NrOarJBY4bowT1Lzxpf+9aNX8IS2rPdeDeLk0TwpSlLSg5MJWoicoRd6qfy4/6T3EZ+jVzopYTzT+bRw5lldmRsNTxvtE8RTYjSlCt10VvJQtSQs9q2si5a9DJlhfGG0HNe+1fBPSixLBWSleWLH/wfSKzKdGFz2mGQ20emz4Z1dG9TgKxvVedQC5w+YvQa+wSkfKYD5owjGBVNUTjTkhiojslRNAd4JE05BGMXsaK1JyDqI3rFR7YmtsFrqIFusRjUeCksh8XwvCcBoHONicnnr2eYE/YW+wQ2ktJ7JreWSWSKOHpG+E6WFx9UKbiHwMyr8E9NrnGvWUmCLrspCEnkHUY5LxCNJkRgnqk3W5p8j3tDEZdntwOD5vsfnt1p0yGeTQsGM65MKeUGLVMZcTbgroEo38Q5bjBqh+efLv8Y09s1MuEpYyH9R4y6gJB9tGqKu6Loqc6M9aoQtrChLy2lcDWom+Jdl9KyVNGQ9yX2B9+z1Xq94oB2WJV8gRFmzX10pKVkU+Jw/JhdCAavWCTmoezaI+SARyqDq9j/u0yQEzsJVjIwRlN14LQNw9IuEx7V06nFwb2wuPT4L3lFVTtXUFgUdELgCHUpNy3Z7+6omL8HfROrCFkw474ZSVoiG3SeUM2vUzsdhx5zNjPWMrpPgWYnUQ= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(396003)(346002)(136003)(376002)(46966006)(36840700001)(8676002)(36756003)(82310400003)(4744005)(53546011)(6486002)(86362001)(478600001)(36860700001)(6512007)(8936002)(70206006)(6506007)(70586007)(5660300002)(54906003)(316002)(83380400001)(336012)(47076005)(26005)(186003)(4326008)(81166007)(33656002)(82740400003)(6862004)(2906002)(356005)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 14:41:40.3516 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6ae04af1-140e-404d-5501-08d8e3097380 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3916 Hi, > On 9 Mar 2021, at 12:04, Jan Beulich wrote: >=20 > On 08.03.2021 20:48, Julien Grall wrote: >> On 08/03/2021 17:18, Bertrand Marquis wrote: >>> --- a/xen/arch/arm/smpboot.c >>> +++ b/xen/arch/arm/smpboot.c >>> @@ -321,7 +321,8 @@ void start_secondary(void) >>> if ( !opt_hmp_unsafe && >>> current_cpu_data.midr.bits !=3D boot_cpu_data.midr.bits ) >>> { >>> - printk(XENLOG_ERR "CPU%u MIDR (0x%x) does not match boot CPU M= IDR (0x%x),\n" >>> + printk(XENLOG_ERR "CPU%u MIDR (0x%"PRIregister") does not matc= h boot " >>> + "CPU MIDR (0x%"PRIregister"),\n" >>=20 >> For printk messages, we don't tend to split it like that (even for more= =20 >> than 80 characters one). Instead, the preferred approach is: >>=20 >> printk(XENLOG_ERR >> "line 1\n" >> "line 2\n") >=20 > Except of course you want to repeat XENLOG_ERR for the 2nd line. Very right. @Julien: feel free to tell me if you want a v2. Cheers Bertrand >=20 > Jan >=20 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 14:50:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 14:50:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95515.180337 (Exim 4.92) (envelope-from ) id 1lJdge-00040A-8X; Tue, 09 Mar 2021 14:50:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95515.180337; Tue, 09 Mar 2021 14:50:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdge-0003zt-2l; Tue, 09 Mar 2021 14:50:16 +0000 Received: by outflank-mailman (input) for mailman id 95515; Tue, 09 Mar 2021 14:50:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdgc-0003zG-O8 for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:50:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdgc-0000wF-NI for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:50:14 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJdgc-00052f-Lh for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:50:14 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1lJdga-0003Go-PW; Tue, 09 Mar 2021 14:50:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=9urRyAwbdbWhet5GvH1eHc+/+QWf8khOs5ffLcTY6lE=; b=lU43AgN/1k6/Om7AycIyU2l1DZ B6tTYTX2/mVatfWBrZFYKJmRgqblYlXMK8DE65VI9ElOwZ4/Ioi/5ziPAN/CmevlXE/596PzLyAP4 UT7T447J+dryitIIZ2jvThOHVp7ALpNqeQRh3uGYLqAc9+T0iAbnLvUaJiEwNBEJNBHA=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: iwj@xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 4.15 1/3] MAINTAINERS: Make myself the owner of the changelog Date: Tue, 9 Mar 2021 14:50:00 +0000 Message-Id: <20210309145002.30359-2-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210309145002.30359-1-iwj@xenproject.org> References: <20210309145002.30359-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Ian Jackson --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3a5c481543..6a7fa8717e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -256,7 +256,7 @@ S: Supported F: xen/drivers/passthrough/arm/smmu-v3.c Change Log -M: Paul Durrant +M: Ian Jackson R: Community Manager S: Maintained F: CHANGELOG.md -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 14:50:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 14:50:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95514.180332 (Exim 4.92) (envelope-from ) id 1lJdgd-0003zY-WD; Tue, 09 Mar 2021 14:50:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95514.180332; Tue, 09 Mar 2021 14:50:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdgd-0003zO-PD; Tue, 09 Mar 2021 14:50:15 +0000 Received: by outflank-mailman (input) for mailman id 95514; Tue, 09 Mar 2021 14:50:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdgc-0003zB-DE for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:50:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdgc-0000wC-7a for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:50:14 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJdgc-00052P-6M for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:50:14 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1lJdga-0003Go-8I; Tue, 09 Mar 2021 14:50:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From; bh=RzxvfHJokDsv+18cnaKl++7V5AArLUMaNSi6hR4ytuw=; b=g6LSOEc/Z5tPoiX+/tylwLidtK zQfcY6z+LKe02rqMg/HqOXw6j9rYh7DEJpUEzIYVBIxn7lBzZjYC8HAiJk1/5X+DGtyAE3l/zTONG +EjGK1dx8VP6ijobYCyYY/4G+y4O5kHcwhVWiUBBeqF8FOXhRM8mR9n0sgsk0SCoqWbc=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: iwj@xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Community Manager Subject: [PATCH 4.15 0/2] Start 4.15 changelog Date: Tue, 9 Mar 2021 14:49:59 +0000 Message-Id: <20210309145002.30359-1-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The administriva parts of this (1/, 2/) is a little belated. For for the substance 3/ I have information from SUPPORT.md. There is much other information to put here but right now there are several blockers in tree and I don't want to distract from fixing them. I had a look through the git logs but it's really hard to see the wood for the trees. I will go and diff some docs. If anyone feels like sending me updates for CHANGELOG.md that would be welcome, but I will send out a further call for contributions later. Ian Jackson (3): MAINTAINERS: Make myself the owner of the changelog CHANGELOG.md: Clear out 4.14 stuff and start 4.15 info CHANGELOG.md: Glean some information from SUPPORT.md CHANGELOG.md | 33 +++++++++------------------------ MAINTAINERS | 2 +- 2 files changed, 10 insertions(+), 25 deletions(-) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 14:50:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 14:50:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95517.180358 (Exim 4.92) (envelope-from ) id 1lJdgf-00042H-73; Tue, 09 Mar 2021 14:50:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95517.180358; Tue, 09 Mar 2021 14:50:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdgf-00041l-1I; Tue, 09 Mar 2021 14:50:17 +0000 Received: by outflank-mailman (input) for mailman id 95517; Tue, 09 Mar 2021 14:50:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdgd-0003zW-Pp for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:50:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdgd-0000wK-P1 for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:50:15 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJdgd-000532-Lx for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:50:15 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1lJdgb-0003Go-JU; Tue, 09 Mar 2021 14:50:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=dzWTxE/NG2cYQ074W8QypBGs/GUCUMAZViXNVcxZvSU=; b=Mv+f3tkW83zs0cYtmjvvcGtW1u lXukKaQ29ZKCLI/Pcv1t84qMMUQ3kdbw2f/oy0ZEnDB/eKnZr73SzGxWR4UfRvkJriLRQ2rHfF940 8qr5RQk13A+sYKs5lKEuThDvtCe2ZceXOdzV1RIxrR1yWCoKcJ5coCIfMaocNMZnmWfc=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: iwj@xenproject.org, Community Manager Subject: [PATCH 4.15 3/3] CHANGELOG.md: Glean some information from SUPPORT.md Date: Tue, 9 Mar 2021 14:50:02 +0000 Message-Id: <20210309145002.30359-4-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210309145002.30359-1-iwj@xenproject.org> References: <20210309145002.30359-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Ian Jackson --- CHANGELOG.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4ecd157a35..ccdbb82c2e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,16 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ## [Unreleased](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog) +## Added / support upgraded + - Linux device model stubdomains (Tech Preview) + - Xen PV display protocol "backend allocation" mode (Experimental) + - ARM IOREQ servers (device emulation etc.) (Tech Preview) + - Renesas IPMMU-VMSA (Supported, not security supported; was Tech Preview) + - ARM SMMUv3 (Tech Preview) + +## Removed / support downgraded + - qemu-xen-traditional as host process device model, now "No security support, not recommended". (Use as stub domain device model is still supported - see SUPPORT.md.) + ## [4.14.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.14.0) - 2020-07-23 > Pointer to release from which CHANGELOG tracking starts -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 14:50:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 14:50:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95516.180352 (Exim 4.92) (envelope-from ) id 1lJdge-00041J-UQ; Tue, 09 Mar 2021 14:50:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95516.180352; Tue, 09 Mar 2021 14:50:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdge-000414-KH; Tue, 09 Mar 2021 14:50:16 +0000 Received: by outflank-mailman (input) for mailman id 95516; Tue, 09 Mar 2021 14:50:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdgd-0003zT-PH for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:50:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdgd-0000wI-OS for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:50:15 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJdgd-000531-Lo for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:50:15 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1lJdgb-0003Go-75; Tue, 09 Mar 2021 14:50:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=f2SvDOkgoMwyvufUctoo6PscqekyzDTdMKmHYXgLkeU=; b=jOJDqHNANVQB9Qta0Avb+WmCFO RNk1YlgyWpoJorJjiL3QezzmY598ikJK7JNM8SIKe2LpIlWisimcSIA3MLYaT1vrz2OUE+d96oSEm iUf/JloWrmaVyOV9h9CJEUB+2CySt3hsLeeqNxhYF2i/k3QcfFhK4HRfhU2uApejLKv0=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: iwj@xenproject.org, Community Manager Subject: [PATCH 4.15 2/3] CHANGELOG.md: Clear out 4.14 stuff and start 4.15 info Date: Tue, 9 Mar 2021 14:50:01 +0000 Message-Id: <20210309145002.30359-3-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210309145002.30359-1-iwj@xenproject.org> References: <20210309145002.30359-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Ian Jackson --- CHANGELOG.md | 27 +-------------------------- 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5c3d3c791d..4ecd157a35 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,31 +6,6 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ## [Unreleased](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog) -### Added - - This file and MAINTAINERS entry. - - Use x2APIC mode whenever available, regardless of interrupt remapping - support. - - Performance improvements to guest assisted TLB flushes, either when using - the Xen hypercall interface or the viridian one. - - Assorted pvshim performance and scalability improvements plus some bug - fixes. - - Hypervisor framework to ease porting Xen to run on hypervisors. - - Initial support to run on Hyper-V. - - Initial hypervisor file system (hypfs) support. - - libxl support for running qemu-xen device model in a linux stubdomain. - - New 'domid_policy', allowing domain-ids to be randomly chosen. - - Option to preserve domain-id across migrate or save+restore. - - Support in kdd for initial KD protocol handshake for Win 7, 8 and 10 (64 bit). - - Tech preview support for Control-flow Execution Technology, with Xen using - Supervisor Shadow Stacks for its own protection. - -### Changed - - The CPUID data seen by a guest on boot is now moved in the migration - stream. A guest migrating between non-identical hardware will now no - longer observe details such as Family/Model/Stepping, Cache, etc changing. - An administrator still needs to take care to ensure the features visible to - the guest at boot are compatible with anywhere it might migrate. - -## [4.13.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.13.0) - 2019-12-17 +## [4.14.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.14.0) - 2020-07-23 > Pointer to release from which CHANGELOG tracking starts -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 14:51:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 14:51:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95528.180380 (Exim 4.92) (envelope-from ) id 1lJdhQ-0004NQ-Ku; Tue, 09 Mar 2021 14:51:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95528.180380; Tue, 09 Mar 2021 14:51:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdhQ-0004NJ-GR; Tue, 09 Mar 2021 14:51:04 +0000 Received: by outflank-mailman (input) for mailman id 95528; Tue, 09 Mar 2021 14:51:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdhO-0004N1-LS for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:51:02 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 56b08059-258d-4c55-b35c-320591a42418; Tue, 09 Mar 2021 14:51:01 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4CCD6AE15; Tue, 9 Mar 2021 14:51:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56b08059-258d-4c55-b35c-320591a42418 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615301460; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b7rs5hfiApm/mJkK935Bglhgf5+CumLEim2hP+wR7r4=; b=HbXPXip4nFH3c/ZlZCwA7C+HmS8bo+vhvSFmNZRGm0uubGx+D/bbq/7P9hQOCS6gKgZk2Y 5iOwOuvY459vBkqWUTF6oGTR8S2f779AbqSeSAuWLXMJ/NA0B9acYrfHzMRpLa0YFX2649 STtPoi6WGgEtEOyIHnKfB5nV/5NjWWE= Subject: Re: [PATCH v2 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson References: <1f19ced7-183b-8f08-3a90-c06039e053a6@suse.com> <204d73ec-a46a-6cef-9bc4-4219a7d00350@suse.com> From: Jan Beulich Message-ID: <6dd26887-4246-8c5d-bf94-de03657230c1@suse.com> Date: Tue, 9 Mar 2021 15:50:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09.03.2021 14:37, Roger Pau Monné wrote: > On Tue, Mar 09, 2021 at 12:16:49PM +0100, Jan Beulich wrote: >> On 09.03.2021 11:17, Roger Pau Monné wrote: >>> On Mon, Mar 08, 2021 at 02:49:19PM +0100, Jan Beulich wrote: >>>> On 08.03.2021 13:11, Roger Pau Monné wrote: >>>>> On Mon, Mar 08, 2021 at 10:33:12AM +0100, Jan Beulich wrote: >>>>>> On 08.03.2021 09:56, Roger Pau Monné wrote: >>>>>>> On Fri, Mar 05, 2021 at 10:50:34AM +0100, Jan Beulich wrote: >>>>>>>> --- a/xen/arch/x86/pv/emul-priv-op.c >>>>>>>> +++ b/xen/arch/x86/pv/emul-priv-op.c >>>>>>>> @@ -874,7 +874,7 @@ static int read_msr(unsigned int reg, ui >>>>>>>> struct vcpu *curr = current; >>>>>>>> const struct domain *currd = curr->domain; >>>>>>>> const struct cpuid_policy *cp = currd->arch.cpuid; >>>>>>>> - bool vpmu_msr = false; >>>>>>>> + bool vpmu_msr = false, warn = false; >>>>>>>> int ret; >>>>>>>> >>>>>>>> if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) >>>>>>>> @@ -882,7 +882,7 @@ static int read_msr(unsigned int reg, ui >>>>>>>> if ( ret == X86EMUL_EXCEPTION ) >>>>>>>> x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); >>>>>>>> >>>>>>>> - return ret; >>>>>>>> + goto done; >>>>>>>> } >>>>>>>> >>>>>>>> switch ( reg ) >>>>>>>> @@ -986,7 +986,7 @@ static int read_msr(unsigned int reg, ui >>>>>>>> } >>>>>>>> /* fall through */ >>>>>>>> default: >>>>>>>> - gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); >>>>>>>> + warn = true; >>>>>>>> break; >>>>>>>> >>>>>>>> normal: >>>>>>>> @@ -995,7 +995,19 @@ static int read_msr(unsigned int reg, ui >>>>>>>> return X86EMUL_OKAY; >>>>>>>> } >>>>>>>> >>>>>>>> - return X86EMUL_UNHANDLEABLE; >>>>>>>> + done: >>>>>>> >>>>>>> Won't this handling be better placed in the 'default' switch case >>>>>>> above? >>>>>> >>>>>> No - see the "goto done" added near the top of the function. >>>>> >>>>> Yes, I'm not sure of that. If guest_rdmsr returns anything different >>>>> than X86EMUL_UNHANDLEABLE it means it has handled the MSR in some way, >>>>> and hence we shouldn't check whether the #GP handler is set or not. >>>>> >>>>> This is not the behavior of older Xen versions, so I'm unsure whether >>>>> we should introduce a policy that's even less strict than the previous >>>>> one in regard to whether a #GP is injected or not. >>>>> >>>>> I know injecting a #GP when the handler is not set is not helpful for >>>>> the guest, but we should limit the workaround to kind of restoring the >>>>> previous behavior for making buggy guests happy, not expanding it >>>>> anymore. >>>> >>>> Yet then we risk breaking guests with any subsequent addition to >>>> guest_rdmsr() which, under whatever extra conditions, wants to >>>> raise #GP. >>> >>> But it's always been like that AFAICT? Additions to guest_{rd/wr}msr >>> preventing taking the default path in the {read/write}_msr PV >>> handlers. >> >> Yes, but the impact so far and the impact going forward are different. > > OK, I assume this is because we plan to handle more MSRs in > guest_{rd/wr}msr? Yes. > In which case those newly added handlers are not likely to inject a > #GP? Kind of the opposite - because it's not impossible that some addition there may want to raise #GP. >>> If #GP signaled by guest_{rd/wr}msr are no longer injected when the guest >>> #GP handler is not set we might as well drop the rdmsr_safe check and >>> just don't try to inject any #GP at all from MSR accesses unless the >>> handler is setup? >> >> Well, that's what I had initially. You asked me to change to what I >> have now. >> >>> I feel this is likely going too far. I agree we should attempt to >>> restore something compatible with the previous behavior for unhandled >>> MSRs, but also not injecting the #GPs signaled by guest_{rd/wr}msr >>> seems to go beyond that. >> >> I understand this is a downside. Yet as said - the downside of _not_ >> doing so is that every further raising of #GP will risk breaking a >> random guest kernel variant. > > Right. So given this awkward position Xen is in, we should maybe make > the lack of #GP injection as a result of an MSR access when no handler > is set formally part of the ABI and written down somewhere? > > It's not ideal, but at the end of day PV is 'our' own architecture, > and given that this workaround will be enabled by default, and that we > won't be able to turn it off we should have it written down as part of > the ABI. > > If you agree with this I'm fine with not injecting a #GP at all unless > the handler is set for PV, like you proposed in your first patch. IMO > it's not ideal, but it's better if it's a consistent behavior and > clearly written down in the public headers (likely next to the > hypercall used to setup the #GP handler). > > I know this can be seen as broken behavior from an x86 perspective, > but again PV is already different from x86. I'm certainly not opposed to spelling this out somewhere; iirc you said the other day that you couldn't spot a good place. I can't think of a good place either. Furthermore before we spell out anything we (which specifically includes Andrew) need to settle on the precise behavior we want. I did suggest earlier that I could see us tighten the condition, and there are many possible variations. For example we could record whether a #GP handler was ever installed, so we wouldn't return back to the relaxed behavior in case a guest zapped its handler again. But for behavior like this the immediate question is going to be what effect migration (or saving/restoring) of the guest ought to have. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 09 14:53:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 14:53:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95531.180392 (Exim 4.92) (envelope-from ) id 1lJdjq-0004bn-1a; Tue, 09 Mar 2021 14:53:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95531.180392; Tue, 09 Mar 2021 14:53:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdjp-0004bg-US; Tue, 09 Mar 2021 14:53:33 +0000 Received: by outflank-mailman (input) for mailman id 95531; Tue, 09 Mar 2021 14:53:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdjn-0004bZ-Lg for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:53:31 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0c82bad2-469c-4b62-9ab8-02426a77ecff; Tue, 09 Mar 2021 14:53:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c82bad2-469c-4b62-9ab8-02426a77ecff DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615301610; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=z+wHajFxEbzNL6KY64KVfQnml1PEuPm9/pQSxQTesX0=; b=WL63TGdxWIJZL9WrFJyPwjdqyVD/7AZStlaZHHv1y/qIqA+NG160Yx+S UJCIEvRZsiuIn3UE6xWb7fUDMfDLZr7Bp8LOnDtDNCUsiIvjTmw6uEobx hvPk9DAoNWD+sbwL70UWee1/RS0VLFTkgTJkq/ZguKFM6yDWMHMa+s+/w I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 4bTQ8/tKCJ6oiOCLUsM/9OX94C9uASXCc2d7/Ff2Mtbz4AsSIqUi9E9GrXAWV5jCSmoQHPrhFM Q/lHOx8cCU5Cy5snWQgDQ/y1UDjOAOHSMm+pK9+8hjZUKoWkswaOgQEn0LEtildFvbYXkoMq+M G1IkHXp6WCBZmyynquu6elA/Tb0KQxEin9lF95QNy8nzzKy+c9Ths+oS950MeCroa7nRhsA5Bu HXG2dj/sO8b0ClyLo00l5OxocduLjJHchsHoklN7sDPrUTXvghwGL63Jem8uGKZulQUrQkd1ho NJw= X-SBRS: 5.2 X-MesageID: 39232482 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,234,1610427600"; d="scan'208";a="39232482" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AUVS2eKQo1Q9Nu13F00pVw7lhKmK3rgvYv8z6gQPVeLpNzxVmWCHT3gBXIsGs3baI1+wBPhik01Fwi7D4BRPcWAuXs5zpmWjx1L0xuKqcuZNvc1eMd9rwjaNCNTDWQ3lRjHAyRrjXie2jdcGQIn0vQuoHe+oPMyWB/xobKJklxqA57KS27S0JlhKn0+hmvbRCAxfYMmaYycXtrx0zmi1NgEsGYyvikgK7gnm/FCzaYh+KsOGAnyYv9gXxw0MNuyXe0wEuNlS7beJy5L60Y36qNWVziqNGQqhWZV5Gijf9aTmrWa0VJHZ9o+kwMiJtbzBXKhA1vU+AUVrr3QI7/abrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kAYkZH5Yy+54Ir70154BT3X2UpaA1j72GzEGOdVw/5Y=; b=k7LtgMzt76ijCMQMGyF8m3h3EKbaUlrzrTxsjCdym2idxaiiRGmnNC3YcSMeGvcvDCH4Mjcmm4smjvY8VuQ7mwYmL8ahm/8cgmouHuWh7kSdWf9jIsRnUBwEzU0sGiesIO4YZKwA8XmfNetTbGUrlXpIOzAfB/c5FQtFpxe3K24SS4gv9MEsuFV/X7bcKGavjgoFcVCd27/eH8BNJNvSuR6L+vKbr+2mskG0N4w60+/408iFcEa1HNMfHaWnVf9P8pb2p7hRZOyhLP9zcvII/EVMiGICc1oev9SgxeCaRWbv2Q9o8FPYyzwDINgsRroDrLxW/T2ckkSMXeja3CuPOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kAYkZH5Yy+54Ir70154BT3X2UpaA1j72GzEGOdVw/5Y=; b=PLIbHccYTPF/ICzJ953Fo8qVQvnit0mhDJyrNgE3V5+BFq4WNACbMZ19ZKCsqUrMvf35kPHxIXvyWibal/47mNgKjNFkJ3GYAdjsS7V5hRhiaRrepXissxfRNf2IZpx0fy2pf9zgwo1/7kqdiltrnzDi8PHhVEJCswVb3J8RQCs= Date: Tue, 9 Mar 2021 15:53:03 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Ian Jackson , Wei Liu , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky , Subject: Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection Message-ID: References: <20210309105634.7200-1-roger.pau@citrix.com> <37e82170-8097-1eda-95d9-23d235075a67@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AM5PR04CA0023.eurprd04.prod.outlook.com (2603:10a6:206:1::36) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a70fd69d-53c9-45dc-712c-08d8e30b0e1a X-MS-TrafficTypeDiagnostic: DM6PR03MB3673: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R/RnrBWJUrUtE4WRIOTRsiHxdE8ZKLWCiXK8FneGm0WUH+cLFEu769vqPTb6bFEHMDF2UWPFT2szAYv5Z69xhm+Zqji4M/n9sY3JgEjgJEskhfnxTO9WSRWAgY34BTZk+hVojOEFZdywbYQ2u5IGlaFq5Hsw1hB2sVZOyUojO3CjZCqdUHfK2fQ6rnNOA7HSdrFSvFNwz/qIcvFrJ2+DaAwvbp2yX0eXIuINgJ0heih4LRhCyvp80PP+EKJ5U34FMJw+fN8PBtma683LO28mFtL/zRmDNiRcS3lvxsC1z2s3RUudTRfiRLijHH1lnU4aSzfCPr3iQvrqgjPNrQ8XWT47zBB1fBykwtlA87oG2lC8spT3LPU+tc5GglBeA1vc19UIrT7udHoDAWQl4vD+LpaTCi3BA2aIhQBIWUJm42N6JMStw5XUWTohy/SKheYJTdJ65HMxCeLwkM3cDOCNB70su5BhjBaPfSuL1v4/RDO9r1vomMrvFafH0TZVxdR16D3fI4HzxSqNsxCoEWlA0Vf755bJGZnBm3LQNjZwIXEZMg5XqZ/R+YaLc10GvzegZV1Bwx60QVHrFrQOwgE1VNfdgwOk34ulDLRGKxrCb3SuuPugbwGgtgbX1zXqCwvYNySpLUSrIVE4HZmGln6Nhw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(376002)(346002)(136003)(39860400002)(396003)(86362001)(8936002)(478600001)(6666004)(956004)(33716001)(6486002)(9686003)(66556008)(66476007)(7416002)(54906003)(53546011)(8676002)(2906002)(83380400001)(186003)(16526019)(316002)(966005)(85182001)(5660300002)(6916009)(4326008)(26005)(66946007)(6496006)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?SldPL25BS2MwNlJQRzJqT1MvcjhLSlgzczh6NWZpS1hFWkVLbm13Q0tCZzEx?= =?utf-8?B?QlVTdDl5Z2JPYzd0cnY5OUMyWTdkeStOckdpTFBuc0JmMTNuY3dkQ043ZElx?= =?utf-8?B?dFEvQml4dldxQ1ZyOGVTQ0VaKzExbW1hOHBldjZLanlTMlZNa1RSQ1Y3Rm9t?= =?utf-8?B?bVlVbXdpWnlnbkh2QzRxWlpScUMwbHBxZmtqQkVzbE9WZ2xwcXRMSnJwK2lY?= =?utf-8?B?NnhqMi9RUlY1TktHU1prN05nbEJiSmU5ZmNNY2QzdzNxYldBVnJURlcrc1R1?= =?utf-8?B?SEc2dURQRGV4N0k1T3ZBVCt5RXNpSTNCNGU0OEhKQnFtclhmTHlFb1VQdEZn?= =?utf-8?B?bW14RG5OOW1qWE5WaFpxWDJRaUR5MENkcTJRUndIbHV3RzM1OVBtd3lJQWI1?= =?utf-8?B?cHlTcThSUURUWDlDZS9CcW5MbnZPcWF3VnVQbFJIMWRzMlpXTy8yZkhLQXVK?= =?utf-8?B?OWVjUWxMMEwxOGxrOExXUFFuNTNMUjllMHUreGRqYnBlRFVwVUpub01Oa3cv?= =?utf-8?B?dmNSZmlwRFYxZmhpOWt2VCtqSHBjbDJTWmtkc3grVTB4a25PSmNYT3JrelA4?= =?utf-8?B?eXIzR1NTT2MrQUYydHV1bWFiS1N5V3A3eFFXZnlqSGh6R2x5clRxdzVKUmNZ?= =?utf-8?B?M1JxZnRDZDUvdjZQbG1iN1NZS294bGNKRXBDaXkxeTZZVXRiaDI1U04xclZU?= =?utf-8?B?bzhhK0k1b1FIQUs1TTcyZTVFR3I5TlRCd2xQbkxNNS9iUS81c2JMV1RUdG44?= =?utf-8?B?eVJFZ2l5SElWWmpuMTdPVXlmZkdUM2xodFlQT1doT3FUcGxlbTZ5TlIrR1I0?= =?utf-8?B?MktzSkxOdGcveUl5UC96WGxrWWRQaHhPQlArbkhheXZhS3NJcU91MEFXc05D?= =?utf-8?B?VC9nSXYyb2VzcGZxZzNqd09CekQyYVVVL1VRK0xyTUlYWDh0V3hOV3FCRjdC?= =?utf-8?B?NVhHY3ZDbkU3TVNrYksrTmFaMHR3bUJvS1FmNHhicVBBTVdZQ29UakZJQ0FP?= =?utf-8?B?K1Z3b2RoRFA5NFFTVUVRYmUyNGNQdVlaRFN2ZzJ0TUtkMnBma0ZMSWZKWG9O?= =?utf-8?B?dnhhMms3TTFMN3NXZmZkK2V1NzdxMVBhTE81Y2JYazlYdkNjSUc2K2ttMXlu?= =?utf-8?B?bFF1bUlOZmpBZW5POWFpSTNVVXFSZkMwMnZ0dXBhSUlhdFE0RmErRUlYdmFm?= =?utf-8?B?Qlk3VU51TEJBa2xEUTJoNTJmY1dLVjB5R2JLQ2F4bWQxRnhIeWRXY2hzazlm?= =?utf-8?B?dnJUb1NYWXdMNnFEZDlHVUF6cnZtQUVuR20xYnVTY1ZYUEltVFZLb2UrZVFl?= =?utf-8?B?NGY3TTh5WHppUFU3TzNZUjduWkZIRFVqcENncWsxVzZsNlVTRVRPUzl6NWZh?= =?utf-8?B?d3NhRzZCamNCcmFEUHBBMUtCNVMwdlhtckF0c2NGQlNNWE4vZHh4MDdtdmhU?= =?utf-8?B?V3poMndudWovcEwzTkZwY3g5NlpZY3lsczIvL285NnRLeExoaGIxYWpSWis3?= =?utf-8?B?c3psbWNPSkZ5WHpySG5wNE93TTBUVzdUb25aenpiR0daWlJ0TnZ3Ujg4QUY2?= =?utf-8?B?b2JHempUUHg5L1FFNWlKZzRoRGZhSGJJdEdyQ3JmSDhuUmFHT3o5dk9RbDQ2?= =?utf-8?B?T2c3TkZSTExvUEdzUm1ld0IvSUFreHhxc1lWOU5lRVBkOTg1SVlObVNmd2cy?= =?utf-8?B?Smt4WUU3eEd4cDZBOWJaMm90MzZyUUFpb1cxYzk0c3huMDRndENUUXBMczhS?= =?utf-8?B?eFJqckRMa0JTS25GNnJ6VjNRK0xJejVEQmNqcWVUOUdBWUlvRXVWdjRzUjgv?= =?utf-8?B?dXFueXgyZ0lHL0MvNlBJQT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: a70fd69d-53c9-45dc-712c-08d8e30b0e1a X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 14:53:09.4919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mxNk1MV9ElZsSitO0ER65rAHXmtgaM1Qpv4YSKe7UbHEKkip1w5dxGf5fZCZ+udOJcGDPoccPrgM5SiNQOHzVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3673 X-OriginatorOrg: citrix.com On Tue, Mar 09, 2021 at 03:26:07PM +0100, Jan Beulich wrote: > On 09.03.2021 14:53, Roger Pau Monné wrote: > > On Tue, Mar 09, 2021 at 12:36:39PM +0100, Jan Beulich wrote: > >> On 09.03.2021 11:56, Roger Pau Monne wrote: > >>> @@ -1148,6 +1155,9 @@ static int write_msr(unsigned int reg, uint64_t val, > >>> } > >>> /* fall through */ > >>> default: > >>> + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, val) ) > >>> + return X86EMUL_OKAY; > >>> + > >>> gdprintk(XENLOG_WARNING, > >>> "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", > >>> reg, val); > >> > >> So what are your thoughts wrt my change to this file? Drop it > >> altogether and require people to use this new option? Or do you > >> see both coexist? > > > > I wouldn't be opposed to have both changes co-exist, as long as the PV > > one is made part of the PV ABI, that is have it properly described in > > the public headers as part of the PV behavior. I've replied with some > > details along those lines in your patch. > > > >> In the latter case, since you had suggested > >> that I drop the write side of my change - does your changing of > >> the write path indicate you've changed your mind? > > > > Yes, I think we need to provide an option to allow users to revert > > back to an MSR behavior as close as possible to the previous one for > > compatibility reasons, and that should include the write side even if > > we don't know any users requiring it right now. > > > > We would be in a bad position if that use-case gets discovered after > > the release, so it's IMO best to provide an option that covers both > > read and write side straight away. > > Well, for your change it's indeed "an option". For my change it's > not optional behavior (and we also don't mean it to be). Hence I'm > not sure what I should read out of your reply. Sorry, maybe my reply wasn't clear. The part of the quote above was my reply to me re-adding the write side of the change. The reply to whether I think your PV change is required was in the chunk above. To clarify: - I do think we need the write side of this change, just for the sake of providing a behavior as close as possible to the previous release. - I don't have a strong opinion whether we need two options ({rd,wr}msr:relaxed) or just a single one (msr_relaxed). I favor a single one because it's likely users will enable both in tandem anyway (like you mentioned). - I'm fine with your change to PV as long as it's documented in the public headers as part of the PV ABI, since it will be enabled unconditionally (more about that in a reply [0] to your patch). - I think your change to PV should cover the write side also. Hope that's less confusing. Thanks, Roger. [0] https://lore.kernel.org/xen-devel/YEd6GTXJqRIjijl6@Air-de-Roger/ From xen-devel-bounces@lists.xenproject.org Tue Mar 09 14:54:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 14:54:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95536.180403 (Exim 4.92) (envelope-from ) id 1lJdkw-0004jj-GJ; Tue, 09 Mar 2021 14:54:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95536.180403; Tue, 09 Mar 2021 14:54:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdkw-0004jc-DQ; Tue, 09 Mar 2021 14:54:42 +0000 Received: by outflank-mailman (input) for mailman id 95536; Tue, 09 Mar 2021 14:54:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdkv-0004jX-OO for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:54:41 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a61d2a39-0e73-41c8-b80d-bd2fd8d6ec98; Tue, 09 Mar 2021 14:54:41 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3A81FAC8C; Tue, 9 Mar 2021 14:54:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a61d2a39-0e73-41c8-b80d-bd2fd8d6ec98 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615301680; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ETTUihX3iW7pnaaMUGCw+M/HQk6c3CfgbtPXSoBXFyQ=; b=VRTZUsWNfBiUF41sXeHfnmmn31wWpizh3TcZFkka/YUn8JPDoAktp9fMDz8+Zi8UwWgXZT Ls/vCkNkn1oRL1Uqr4E+pIMBCKu+SsU0DNHzuXc1z6CqUFje3600qjwQ++L1Pkp7QW0Pr3 d8nwI+a3Ec6raUg1uDDK8KT2265UGds= Subject: Re: [PATCH 4.15 2/3] CHANGELOG.md: Clear out 4.14 stuff and start 4.15 info To: Ian Jackson Cc: Community Manager , xen-devel@lists.xenproject.org References: <20210309145002.30359-1-iwj@xenproject.org> <20210309145002.30359-3-iwj@xenproject.org> From: Jan Beulich Message-ID: <8d5c56af-e7dd-1861-0246-b3c1760cb8e9@suse.com> Date: Tue, 9 Mar 2021 15:54:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210309145002.30359-3-iwj@xenproject.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09.03.2021 15:50, Ian Jackson wrote: > Signed-off-by: Ian Jackson > --- > CHANGELOG.md | 27 +-------------------------- > 1 file changed, 1 insertion(+), 26 deletions(-) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 5c3d3c791d..4ecd157a35 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -6,31 +6,6 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > > ## [Unreleased](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog) > > -### Added > - - This file and MAINTAINERS entry. > - - Use x2APIC mode whenever available, regardless of interrupt remapping > - support. > - - Performance improvements to guest assisted TLB flushes, either when using > - the Xen hypercall interface or the viridian one. > - - Assorted pvshim performance and scalability improvements plus some bug > - fixes. > - - Hypervisor framework to ease porting Xen to run on hypervisors. > - - Initial support to run on Hyper-V. > - - Initial hypervisor file system (hypfs) support. > - - libxl support for running qemu-xen device model in a linux stubdomain. > - - New 'domid_policy', allowing domain-ids to be randomly chosen. > - - Option to preserve domain-id across migrate or save+restore. > - - Support in kdd for initial KD protocol handshake for Win 7, 8 and 10 (64 bit). > - - Tech preview support for Control-flow Execution Technology, with Xen using > - Supervisor Shadow Stacks for its own protection. > - > -### Changed > - - The CPUID data seen by a guest on boot is now moved in the migration > - stream. A guest migrating between non-identical hardware will now no > - longer observe details such as Family/Model/Stepping, Cache, etc changing. > - An administrator still needs to take care to ensure the features visible to > - the guest at boot are compatible with anywhere it might migrate. > - > -## [4.13.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.13.0) - 2019-12-17 > +## [4.14.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.14.0) - 2020-07-23 Was the plan here really to remove old information? I'd have expected you to add the one line you do add (perhaps together with empty "### Added" and "### Changed" sections) between [Unreleased] and the section you remove. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 09 14:55:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 14:55:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95538.180416 (Exim 4.92) (envelope-from ) id 1lJdlv-0004qr-S1; Tue, 09 Mar 2021 14:55:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95538.180416; Tue, 09 Mar 2021 14:55:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdlv-0004qk-OB; Tue, 09 Mar 2021 14:55:43 +0000 Received: by outflank-mailman (input) for mailman id 95538; Tue, 09 Mar 2021 14:55:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdlu-0004qd-Bt for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:55:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3a3a3497-dc6f-41b7-aa92-e46182e5ba5a; Tue, 09 Mar 2021 14:55:41 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A5296AEBE; Tue, 9 Mar 2021 14:55:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a3a3497-dc6f-41b7-aa92-e46182e5ba5a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615301740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JLHb+YAcHTY1pyFDQG5H8fcOhtAOu3Rg7vCcXWyNTQg=; b=kXM534RWQnV7lDsg/BqCtdx4BoXj9Mk7bmnfCWk5Lqr8HQospz+COqV4sfhXo3xcHaqWq1 IGWqGe1iSvGhulrGA79OI8JXgUoluYUZghRlG+p+SL1XM8KVlu55INvuK85M+bbWZh7JYZ BLT1V45NuM6Rtz2G421QdidMrmYX/+w= Subject: Re: [PATCH 4.15 1/3] MAINTAINERS: Make myself the owner of the changelog To: Ian Jackson Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210309145002.30359-1-iwj@xenproject.org> <20210309145002.30359-2-iwj@xenproject.org> From: Jan Beulich Message-ID: <208181b5-d2e7-15c8-df86-00dea6e3040d@suse.com> Date: Tue, 9 Mar 2021 15:55:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210309145002.30359-2-iwj@xenproject.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09.03.2021 15:50, Ian Jackson wrote: > Signed-off-by: Ian Jackson I don't suppose this kind of a change needs it, but just in case: Acked-by: Jan Beulich Jan > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -256,7 +256,7 @@ S: Supported > F: xen/drivers/passthrough/arm/smmu-v3.c > > Change Log > -M: Paul Durrant > +M: Ian Jackson > R: Community Manager > S: Maintained > F: CHANGELOG.md > From xen-devel-bounces@lists.xenproject.org Tue Mar 09 14:58:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 14:58:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95545.180428 (Exim 4.92) (envelope-from ) id 1lJdp2-00057T-AJ; Tue, 09 Mar 2021 14:58:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95545.180428; Tue, 09 Mar 2021 14:58:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdp2-00057M-79; Tue, 09 Mar 2021 14:58:56 +0000 Received: by outflank-mailman (input) for mailman id 95545; Tue, 09 Mar 2021 14:58:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdp0-00057G-JJ for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 14:58:54 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5356a53c-62c6-4357-bb0b-35fc53956033; Tue, 09 Mar 2021 14:58:53 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F3FAFAE15; Tue, 9 Mar 2021 14:58:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5356a53c-62c6-4357-bb0b-35fc53956033 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615301933; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lfhhIzImDqYA/7WwpMPxJdDHEF0E/U9J6dZH7AhaUkU=; b=nemnOyPK/lZ3IEnSLUP0QlH9W+9fzz8urXWdBPjbobxyPguBWBreRUNleD/GPv1kZev95y GXtt3G5/o7IYI5K5skvMmxgujTx9BFo8o2kmyBwVsiZoaBpQmIHr3znD6415Ni/Wm3JLyf WGiBdbtCLINcPz1yB8BZmmzsRBTAbno= Subject: Re: [PATCH 4.15 3/3] CHANGELOG.md: Glean some information from SUPPORT.md To: Ian Jackson Cc: Community Manager , xen-devel@lists.xenproject.org References: <20210309145002.30359-1-iwj@xenproject.org> <20210309145002.30359-4-iwj@xenproject.org> From: Jan Beulich Message-ID: Date: Tue, 9 Mar 2021 15:58:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210309145002.30359-4-iwj@xenproject.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09.03.2021 15:50, Ian Jackson wrote: > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -6,6 +6,16 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > > ## [Unreleased](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog) > > +## Added / support upgraded > + - Linux device model stubdomains (Tech Preview) > + - Xen PV display protocol "backend allocation" mode (Experimental) This was a downgrade iirc (by XSA-363). > + - ARM IOREQ servers (device emulation etc.) (Tech Preview) > + - Renesas IPMMU-VMSA (Supported, not security supported; was Tech Preview) > + - ARM SMMUv3 (Tech Preview) > + > +## Removed / support downgraded > + - qemu-xen-traditional as host process device model, now "No security support, not recommended". (Use as stub domain device model is still supported - see SUPPORT.md.) Nit: This line looks overly long. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 09 15:02:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 15:02:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95550.180439 (Exim 4.92) (envelope-from ) id 1lJds0-00060j-Pp; Tue, 09 Mar 2021 15:02:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95550.180439; Tue, 09 Mar 2021 15:02:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJds0-00060c-Mm; Tue, 09 Mar 2021 15:02:00 +0000 Received: by outflank-mailman (input) for mailman id 95550; Tue, 09 Mar 2021 15:01:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdrz-00060U-IK; Tue, 09 Mar 2021 15:01:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdrz-0001Bb-CT; Tue, 09 Mar 2021 15:01:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdrz-0007BY-3R; Tue, 09 Mar 2021 15:01:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJdrz-0006B9-2y; Tue, 09 Mar 2021 15:01:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=evluW/0dytqt/gWaeQjXtI5Eo2djUP81+liiej9MdVY=; b=K+rvv87aJzFFbGK62Og1XQCWlc ZulDqVH1P5bWn9JUJL0HUAakMt2QFD9sYrbY5r6FtCeGlEb1x+h1DvseVPQ7clzlpNk34YXkN7fMk ucXZHpWQIX7NNJPPMO44aAT58ACR0KjNl9Eq13hL5tKykAveEURDxGPQccFHLmTeizA0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159882: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-armhf-armhf-xl-vhd:leak-check/check:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=60c0444fae2148452f9ed0b7c49af1fa41f8f522 X-Osstest-Versions-That: xen=60c0444fae2148452f9ed0b7c49af1fa41f8f522 From: osstest service owner Date: Tue, 09 Mar 2021 15:01:59 +0000 flight 159882 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/159882/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 159874 test-amd64-amd64-examine 4 memdisk-try-append fail pass in 159874 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 18 guest-localmigrate/x10 fail pass in 159874 test-armhf-armhf-xl-vhd 20 leak-check/check fail pass in 159874 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159874 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159874 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159874 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159874 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159874 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159874 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159874 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159874 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159874 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159874 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159874 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 60c0444fae2148452f9ed0b7c49af1fa41f8f522 baseline version: xen 60c0444fae2148452f9ed0b7c49af1fa41f8f522 Last test of basis 159882 2021-03-09 01:59:48 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Mar 09 15:04:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 15:04:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95557.180455 (Exim 4.92) (envelope-from ) id 1lJdua-0006AZ-Ea; Tue, 09 Mar 2021 15:04:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95557.180455; Tue, 09 Mar 2021 15:04:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJdua-0006AS-BQ; Tue, 09 Mar 2021 15:04:40 +0000 Received: by outflank-mailman (input) for mailman id 95557; Tue, 09 Mar 2021 15:04:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJduY-0006AN-QX for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 15:04:38 +0000 Received: from mail-wr1-x432.google.com (unknown [2a00:1450:4864:20::432]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 411cac64-0c33-459f-b4ec-60eb1975abd1; Tue, 09 Mar 2021 15:04:38 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id j2so16247056wrx.9 for ; Tue, 09 Mar 2021 07:04:38 -0800 (PST) Received: from [192.168.1.186] (host86-180-176-157.range86-180.btcentralplus.com. [86.180.176.157]) by smtp.gmail.com with ESMTPSA id c131sm1809037wma.37.2021.03.09.07.04.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 07:04:37 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 411cac64-0c33-459f-b4ec-60eb1975abd1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yPCeCmLY5uTHUZgK/4sVQkhvTaWHvCR2Gtxf5gLPmpQ=; b=Fii5q1M/CcaaPkS6vDU8fE6lKJeBapHuMznV0Zp/QeZ48XD7mhbTPx2D0d1klLAq9f QTj4mTLzuL5gjePHUv4T2KXRnTuXVG0EGcQEouwcFhnJQXJRESzOXGeEXb+7rsv6scOZ lMryl/N4UZyIMe5iAgy0PmIDG9273D6uE0q1H0NNFxyvAUPe+nMOdGJ2sGOTBlNhUDtm 7qJulTzb/IXryYc75UUPYKiVH8w56DjeA0Y0GCyCeqSgDW5UPcDu/JvwLYNlsXiV7VU8 WvZlNBFOGpkQb+oLHk6JcLTEVO4MSxByvqfeHXv4MjW++1BUGIcrBn8FbJxY2uu6loks 2Bfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yPCeCmLY5uTHUZgK/4sVQkhvTaWHvCR2Gtxf5gLPmpQ=; b=dIWXe8lShY45xw7pvCMY82tWqKuZvxDCnDlk4osmY4jhd4fDlLxs+JTXLeSWBCBpaR yVhrS4WZvDNYULHXKNOWMeXYCie99RF9JAU+Zs0QDs7Jkgj450A1YeIhVNRdqKJvS8kj Muvt9OrxdlOe78aPJ0hWk8qawGPs+RVmTpEQIQ30FEBK0FZMBbgaYtzua+UbxxzONp2X Ha35V4qMWn4cSqgg9/1/eIqW9UDfSxYc7+cpJtcV8pl9o4gzWsEnP1WA09ariXIwXU5r a1rxSgFgRIWSUcmQk2d9VPl3q8ai18UgZWczF62WnI39Ib5KBtRXSWDdqZ+k/kxaW/0G Xv2Q== X-Gm-Message-State: AOAM530q1jWXUwXsVjgUeKZ/2BvXsXeWRmzq18spWwajreJ6I838C4My Hu8y+s/BoCoFD3sWkthqXeiDxc6Ddx4= X-Google-Smtp-Source: ABdhPJygZf0ltgIOrudQNt17FBIOHCbToM2JAayRR+d59rfljSi4bQHdN//seu6P1huApZfMliE1Sg== X-Received: by 2002:adf:ec83:: with SMTP id z3mr28377761wrn.59.1615302277315; Tue, 09 Mar 2021 07:04:37 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 4.15 1/3] MAINTAINERS: Make myself the owner of the changelog To: xen-devel@lists.xenproject.org References: <20210309145002.30359-1-iwj@xenproject.org> <20210309145002.30359-2-iwj@xenproject.org> Message-ID: <8a8c5d10-8a44-bb03-4611-d404ee19c1d3@xen.org> Date: Tue, 9 Mar 2021 15:04:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210309145002.30359-2-iwj@xenproject.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/03/2021 14:50, Ian Jackson wrote: > Signed-off-by: Ian Jackson Perhaps we need a release.manager@xenproject.org alias that can be passed along. Anyway... Acked-by: Paul Durrant > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 3a5c481543..6a7fa8717e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -256,7 +256,7 @@ S: Supported > F: xen/drivers/passthrough/arm/smmu-v3.c > > Change Log > -M: Paul Durrant > +M: Ian Jackson > R: Community Manager > S: Maintained > F: CHANGELOG.md > From xen-devel-bounces@lists.xenproject.org Tue Mar 09 15:18:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 15:18:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95568.180466 (Exim 4.92) (envelope-from ) id 1lJe7a-0007IG-LF; Tue, 09 Mar 2021 15:18:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95568.180466; Tue, 09 Mar 2021 15:18:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJe7a-0007I9-IA; Tue, 09 Mar 2021 15:18:06 +0000 Received: by outflank-mailman (input) for mailman id 95568; Tue, 09 Mar 2021 15:18:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJe7Z-0007I4-J6 for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 15:18:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJe7Z-0001SS-FB for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 15:18:05 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJe7Z-0007iq-Dn for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 15:18:05 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lJe7U-0003Qg-NE; Tue, 09 Mar 2021 15:18:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=+4GtcbBOeoJoVGQYoX+cT9Tf8RiJQ7NZQQc84ExBDaY=; b=HoFFLfLnLzo3a+nguFxlrxUyAQ pCrb/36IFV7dNi+62qyfw7f8QSIgaXmznnUA3iVeHHoP51l+pw4WcwzBRhie4eo4pN41MeC0/fFYi IOiH/mauM0y8VvxDl/ESJK9CK0WdS0aTn0OrUlG24G+V7TdkDbV6LqRbSIk4UUBgDJ6g=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24647.37288.466106.769855@mariner.uk.xensource.com> Date: Tue, 9 Mar 2021 15:18:00 +0000 To: Jan Beulich Cc: Community Manager , xen-devel@lists.xenproject.org Subject: Re: [PATCH 4.15 2/3] CHANGELOG.md: Clear out 4.14 stuff and start 4.15 info In-Reply-To: <8d5c56af-e7dd-1861-0246-b3c1760cb8e9@suse.com> References: <20210309145002.30359-1-iwj@xenproject.org> <20210309145002.30359-3-iwj@xenproject.org> <8d5c56af-e7dd-1861-0246-b3c1760cb8e9@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH 4.15 2/3] CHANGELOG.md: Clear out 4.14 stuff and start 4.15 info"): ... > Was the plan here really to remove old information? I'd have expected > you to add the one line you do add (perhaps together with empty > "### Added" and "### Changed" sections) between [Unreleased] and the > section you remove. Hrm. Interesting. Maybe you are right. I'm new at this :-). Ian. From xen-devel-bounces@lists.xenproject.org Tue Mar 09 15:20:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 15:20:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95571.180478 (Exim 4.92) (envelope-from ) id 1lJe9y-000864-1y; Tue, 09 Mar 2021 15:20:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95571.180478; Tue, 09 Mar 2021 15:20:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJe9x-00085x-V3; Tue, 09 Mar 2021 15:20:33 +0000 Received: by outflank-mailman (input) for mailman id 95571; Tue, 09 Mar 2021 15:20:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJe9w-00085s-Ez for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 15:20:32 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2aeffe8a-e08a-48de-b98b-60365ea7eee0; Tue, 09 Mar 2021 15:20:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2aeffe8a-e08a-48de-b98b-60365ea7eee0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615303231; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=5eqYwwTw8+8cXgkxk+1LpRmI5JBbxRCPC/sHmN34/MM=; b=JcPAT6pZCm+oww55l3V5iovehhzVDpV3RngiyfynoLsvEJXqOfPrbisN 3HaWchBAR70Jayvos4JSKyOWembga1jkkrIBHo4UZgKinjjJREasLqAAo xjKMhR457xS8WPFipBSmHdkpB7ncmCZoAQfsKLJn63OmwNxYxCGlSQfLm o=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: VEh+9U0UR5jGyEmPWgm3Iui7EzmcZyYEaV59nL2sQFxd3qGPzEaXjUeOStJVfoAatz+WLJqqvK geTi+uVlxbUFbjOouMSS4yf6ENSq1XQROqnfN9zyZoJ9VAPXD6sqzUpC541B67JHg60aoUveKE xnjNDcH+e+RG8OpIL/OoCTEBInIcH46xZszfhcFXN4V6dKJqnksBhRqaWMq2jgjEed2LBpj3Ba lCCvmrvqaIobSGfLGqylEH7gTYqVm+k+o21d5pWm0IPCzz4s3Ot8Gw0riNhAzo5sQpuVodcI+z jtU= X-SBRS: 5.2 X-MesageID: 39048698 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,234,1610427600"; d="scan'208";a="39048698" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bQYg72yswjZ6tzcCWpIgVB3MqgYTmfsh/FqqZbg2zGcXb1L7l10fVXeSpWiRtTz1OPttQVeAwK9juqjC4TstIY6n59wLrDV/GMI0lM7YZghQYqEvxuDkghqNCwF2aKA5LEEzTCNK7lIPuE1SJn1vzbFLJxFj+yBxH/f0XcreqGLt5xusT7MfXLWLEUCv7W2jRWBpbHqkK25FpkOzR/qMhqGXXA6Q3/iYcaqC4LNpRvX9a533Q5YfQU8tRvIKPnKoZkFQ6Pm6U4sD0TJgQazhBG4SaZnNqBxTg6oPkWzf4nc1DOzKhxD5uIvxemUNMcFlGVMwGe8iplcmPdjN1TxoNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=npees4kHXq3PWMRyCwKaEoO1j0QyshxvMpdEqL2Aa2g=; b=nNwAeqKgkhP+il5wJGNOMIm1tuxjKbDjzAzs2Qn+DR11WKaRdW5GeoGUOLGCpPoxpBYujKkfjTnDGZRZ1n9X6hPFOfmA3/vmq+VTnVoxhEq//x2MDMjh0yo9qeaPd3Vj89OU+nBdJafsUx9u5A0qEm9o/WjjFS442nJi9GrhQAvjA9aiqJ8APeK+R8X+8W8iLkgTXRMhUx+90EpPf7/WOUmGr5u0Ut1khY+jZJb1mWwysFcM0PS1SiGlTOwWN15sLTZGEg+Ntq6jWeZjGqS4QjB7VCpgZHgkK589QfksguOKhRqojzhjHoN0GGFzIiUSg7JSftj9Fnll+6EOBexyqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=npees4kHXq3PWMRyCwKaEoO1j0QyshxvMpdEqL2Aa2g=; b=SsFB4t+i+NJOmVuLutrZJRG318gJ/tr4DbsyhJWySgIkGa4pMfk3IngSdKgwbv9OYSagW/hVyvMd/sDShu+z/gaCSDAXtu3gPqBAS5Qt78YuANWU6SxPH8O/W+iIw3K/ufHf2+KGDpv2RNlyJ1BWTMxThMbzoSOl0qIKa8YbVrE= Date: Tue, 9 Mar 2021 16:19:47 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson Subject: Re: [PATCH v2 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads Message-ID: References: <1f19ced7-183b-8f08-3a90-c06039e053a6@suse.com> <204d73ec-a46a-6cef-9bc4-4219a7d00350@suse.com> <6dd26887-4246-8c5d-bf94-de03657230c1@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6dd26887-4246-8c5d-bf94-de03657230c1@suse.com> X-ClientProxiedBy: LO2P265CA0266.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 37e6a16a-da19-4ac5-486e-08d8e30ec90b X-MS-TrafficTypeDiagnostic: DM5PR03MB2636: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1bc88QO49bflcuw1RSN4VJG8WtfzmUkHcVvR4aPMn2eTi/2CXVgyiCDdZunpLqNDZVWYA7UGbNb+0gsEQ1KAv+Sj0tQQ5QBBLqHA/6/Nx8+PBlm+Qirq/zWNWTLSugrRZVHuTWKlLJUYcfWcNFGenWMmni0MbM/9VkRB1Y28aK9kgb+BjCz1OSlYL//sk7pR5Sck3O6B0LNwD4SwdR5UsZNux6o/rD06qZj1CJyoT6nA31NUmqgp5mR5yR61USMa5DUKntJl5xjuPpSWEsf3MtsLxUo7dv9uxrGGld0qurkJ4YS6rW9Rl0dg/hSfpo6F+IuUAOEIXhernpLzr9AtDfmPVhS7gvOPnc9yL1OxXlqQNcW8AHDPdo3IjnAjB4FS/7PoxP5qpo3iIz4IHw+GLiEzyILLhfyNkhrjU3hlhecnzWp2uX37HfFuVIv7OnsJXVUF7P8knQEBGnCm/PKMAI0uV5iwzGmW9+H7RqhnBvBD/io6gtKE3tjJ7WoIumvurf37qG/GqKLMr/AkVxBClQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(376002)(39860400002)(366004)(136003)(396003)(346002)(6496006)(66476007)(316002)(8936002)(86362001)(186003)(16526019)(6486002)(54906003)(6666004)(956004)(2906002)(53546011)(85182001)(5660300002)(26005)(4326008)(33716001)(66946007)(8676002)(478600001)(9686003)(83380400001)(6916009)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UWQycytvak9iSXhPcFoySjRLN2JqSnlNa0sveHpFWnRJOXpHVG1uNk1yTmRt?= =?utf-8?B?Zm1tMjBYRTlxamlhWTduZlp1S09xNVN2K0c2NUp4dWpWZkJRYWNiVmhHUjR0?= =?utf-8?B?K0gxcmZTU2s1Si9MMzI3b05HaWgyOUlGYmUxSFZHWm91S2tXZW5hdDBGZy94?= =?utf-8?B?VWR1ekdEZGJ5STNHd0FTYStwYWJoSGdxZU13YTUzaFMyc2N3S1hXZG9ZYW0z?= =?utf-8?B?R0NoTmd2bGwxNU9MV3I0TG5Vc0FsV29zeSt5ZTNreWFmZ3lGZzZUSTRhSlFr?= =?utf-8?B?bUVtSVFHZEF6ZkdZZHZjZEx6SjB6M0NGVVZSNU1kSzI1YXVHaWFZUXhiSHZV?= =?utf-8?B?U0lFOTA4eUFCVDRKaE8vbG1JL1ZkQXBtMGo3bS9tUXd3SW9lTGc2QkhIL0sz?= =?utf-8?B?TXNZUDJrSzRSWUx1U3lvZHgwRHpOL28rbzFkc1ZCbU9qMnZQaWMza1h4cFJr?= =?utf-8?B?aFJiZzZYY2c3VVJDMndqTDFBdkZVajNiTm55VnFQMnRUUHJqWERBelQyZG9q?= =?utf-8?B?UFhhbzgxVWlQaE10Z01mTUoyUGVVRUs2RkhtZ3JXMnVZY3Z2dkliRHhRbUhY?= =?utf-8?B?cDJGL3hQUmVHNE5mSHE0cmxaOFpTQjBuRjRoanlvenBicTBUaU15SEFwTkx4?= =?utf-8?B?NEtJRDMxZ21BNnFzQ1lxd3k0ZWVJZFpPeUdiWU15dmJTY0RpU3hzWnV6MXFs?= =?utf-8?B?Rlhvc1NBdlZGYnl5NnpBbEdwb0R1YWlzWFB0Y0JvQ1ZKUzhteDdVNXdoUk9W?= =?utf-8?B?K01nK2Q2R2p2VndRTmhyRVNTMDZPMlIySDJrcVpMQkF3N3hQczlCQnZ4V0gv?= =?utf-8?B?aGdTdGdRaDJheS9CeUZPdjNGeWw2eXRxb1I4UXZoeVFyM2VsZGZadGorbVFo?= =?utf-8?B?VTNrbktrV3VLaW5YTG9FMWpSRkJzK05VZ2dXaTlMUVYzaHpQazNSbUZORlpn?= =?utf-8?B?VG1LekJGQk04OXJ4ZTZNZDgzdXJSQTdLMmUxWjNtVUFWZmJYampXeHVIR3Ew?= =?utf-8?B?QWo1RTNiUXZ1bEkvei8vM29nN21VNUtNdm5SRS8vRmE0ZzNKSTlVdVk3TzBw?= =?utf-8?B?c2FMK1BqZFhTMFV2a00zUWYxNGs4UHFDazZ2RXRtWk9RK1dIMXFEYjU5Qmdh?= =?utf-8?B?aWNCakNkMXo2WnVvNzFVTG1aNDlWWnFwZEU3ZFlTQ3ljTmxJRjhXTkM4TXNh?= =?utf-8?B?Z2VLcSsvYnJORXd3Tk1FeTBFem1pcnJjemE3akhhb3JQN01qSFlSV1IzMXRH?= =?utf-8?B?Qzlxc3Q5d3NnelZrWlpreEdXSHAxalJ0b05iVmRnN05JQ1lrRUVIZEZYclky?= =?utf-8?B?enR4S3hhb2ZURm9sNytzMVBnZnNHR2FpZkF5TUN4TUQ3MEd4UWg0bnpOZXJU?= =?utf-8?B?ckx3a002WUlvdFQveXlhM0xEUnJLZUNUOGlrWDh2UVQ4c1R1M1RFYlZzODlH?= =?utf-8?B?NzZ6UFRqRUF0K1FPQWdyekp2dW56NEVQWWxvOGUwL0w2dDNJUmdYbWVYdk1n?= =?utf-8?B?SGFXcGxTNHdBYUJwMm5OODJPSXQ4SjV0QVJ2bEJlNy8weE9uamVFSmE3cVo4?= =?utf-8?B?UEo4dy9qSEJQb3pyK0tWNCtQQTRibjhlWWNYdkFURW1CSUtRcldBb05lbGZB?= =?utf-8?B?MnkvRlgrdVZPSjh4bGxLSHhlOHJOeXU4bDBVMVQvNGxvN2ZyWEswQmVOYXVv?= =?utf-8?B?N251ZUhRNUxQcVhRZDgyN3NFa2t0ME1mWXo1QVFGZm9KOW5sR2xWdFl3bGdo?= =?utf-8?B?Rk1VTFBMQS9wTTZ0VUc5TjFSUmpQNzFwSk5zWE9pTG5HblY4VnY3MWhxUC9F?= =?utf-8?B?ZVo4VmJtUXpCTHVKQUFOUT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 37e6a16a-da19-4ac5-486e-08d8e30ec90b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 15:19:51.6485 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PBL4UhTeAXASJC4RFkMCtwZxtCb2X8NpjpKpxGIGbfO3lInvkisvC16gNvFi96pPBT+bb7NxAnF02HgHCJnBAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2636 X-OriginatorOrg: citrix.com On Tue, Mar 09, 2021 at 03:50:59PM +0100, Jan Beulich wrote: > On 09.03.2021 14:37, Roger Pau Monné wrote: > > On Tue, Mar 09, 2021 at 12:16:49PM +0100, Jan Beulich wrote: > >> On 09.03.2021 11:17, Roger Pau Monné wrote: > >>> On Mon, Mar 08, 2021 at 02:49:19PM +0100, Jan Beulich wrote: > >>>> On 08.03.2021 13:11, Roger Pau Monné wrote: > >>>>> On Mon, Mar 08, 2021 at 10:33:12AM +0100, Jan Beulich wrote: > >>>>>> On 08.03.2021 09:56, Roger Pau Monné wrote: > >>>>>>> On Fri, Mar 05, 2021 at 10:50:34AM +0100, Jan Beulich wrote: > >>>>>>>> --- a/xen/arch/x86/pv/emul-priv-op.c > >>>>>>>> +++ b/xen/arch/x86/pv/emul-priv-op.c > >>>>>>>> @@ -874,7 +874,7 @@ static int read_msr(unsigned int reg, ui > >>>>>>>> struct vcpu *curr = current; > >>>>>>>> const struct domain *currd = curr->domain; > >>>>>>>> const struct cpuid_policy *cp = currd->arch.cpuid; > >>>>>>>> - bool vpmu_msr = false; > >>>>>>>> + bool vpmu_msr = false, warn = false; > >>>>>>>> int ret; > >>>>>>>> > >>>>>>>> if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) > >>>>>>>> @@ -882,7 +882,7 @@ static int read_msr(unsigned int reg, ui > >>>>>>>> if ( ret == X86EMUL_EXCEPTION ) > >>>>>>>> x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); > >>>>>>>> > >>>>>>>> - return ret; > >>>>>>>> + goto done; > >>>>>>>> } > >>>>>>>> > >>>>>>>> switch ( reg ) > >>>>>>>> @@ -986,7 +986,7 @@ static int read_msr(unsigned int reg, ui > >>>>>>>> } > >>>>>>>> /* fall through */ > >>>>>>>> default: > >>>>>>>> - gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); > >>>>>>>> + warn = true; > >>>>>>>> break; > >>>>>>>> > >>>>>>>> normal: > >>>>>>>> @@ -995,7 +995,19 @@ static int read_msr(unsigned int reg, ui > >>>>>>>> return X86EMUL_OKAY; > >>>>>>>> } > >>>>>>>> > >>>>>>>> - return X86EMUL_UNHANDLEABLE; > >>>>>>>> + done: > >>>>>>> > >>>>>>> Won't this handling be better placed in the 'default' switch case > >>>>>>> above? > >>>>>> > >>>>>> No - see the "goto done" added near the top of the function. > >>>>> > >>>>> Yes, I'm not sure of that. If guest_rdmsr returns anything different > >>>>> than X86EMUL_UNHANDLEABLE it means it has handled the MSR in some way, > >>>>> and hence we shouldn't check whether the #GP handler is set or not. > >>>>> > >>>>> This is not the behavior of older Xen versions, so I'm unsure whether > >>>>> we should introduce a policy that's even less strict than the previous > >>>>> one in regard to whether a #GP is injected or not. > >>>>> > >>>>> I know injecting a #GP when the handler is not set is not helpful for > >>>>> the guest, but we should limit the workaround to kind of restoring the > >>>>> previous behavior for making buggy guests happy, not expanding it > >>>>> anymore. > >>>> > >>>> Yet then we risk breaking guests with any subsequent addition to > >>>> guest_rdmsr() which, under whatever extra conditions, wants to > >>>> raise #GP. > >>> > >>> But it's always been like that AFAICT? Additions to guest_{rd/wr}msr > >>> preventing taking the default path in the {read/write}_msr PV > >>> handlers. > >> > >> Yes, but the impact so far and the impact going forward are different. > > > > OK, I assume this is because we plan to handle more MSRs in > > guest_{rd/wr}msr? > > Yes. > > > In which case those newly added handlers are not likely to inject a > > #GP? > > Kind of the opposite - because it's not impossible that some > addition there may want to raise #GP. > > >>> If #GP signaled by guest_{rd/wr}msr are no longer injected when the guest > >>> #GP handler is not set we might as well drop the rdmsr_safe check and > >>> just don't try to inject any #GP at all from MSR accesses unless the > >>> handler is setup? > >> > >> Well, that's what I had initially. You asked me to change to what I > >> have now. > >> > >>> I feel this is likely going too far. I agree we should attempt to > >>> restore something compatible with the previous behavior for unhandled > >>> MSRs, but also not injecting the #GPs signaled by guest_{rd/wr}msr > >>> seems to go beyond that. > >> > >> I understand this is a downside. Yet as said - the downside of _not_ > >> doing so is that every further raising of #GP will risk breaking a > >> random guest kernel variant. > > > > Right. So given this awkward position Xen is in, we should maybe make > > the lack of #GP injection as a result of an MSR access when no handler > > is set formally part of the ABI and written down somewhere? > > > > It's not ideal, but at the end of day PV is 'our' own architecture, > > and given that this workaround will be enabled by default, and that we > > won't be able to turn it off we should have it written down as part of > > the ABI. > > > > If you agree with this I'm fine with not injecting a #GP at all unless > > the handler is set for PV, like you proposed in your first patch. IMO > > it's not ideal, but it's better if it's a consistent behavior and > > clearly written down in the public headers (likely next to the > > hypercall used to setup the #GP handler). > > > > I know this can be seen as broken behavior from an x86 perspective, > > but again PV is already different from x86. > > I'm certainly not opposed to spelling this out somewhere; iirc you > said the other day that you couldn't spot a good place. I can't think > of a good place either. After looking some more, I think placing such comment next to HYPERVISOR_set_trap_table (in arch-x86/xen.h) would be fine. > Furthermore before we spell out anything we > (which specifically includes Andrew) need to settle on the precise > behavior we want. I did suggest earlier that I could see us tighten > the condition, and there are many possible variations. For example we > could record whether a #GP handler was ever installed, so we wouldn't > return back to the relaxed behavior in case a guest zapped its handler > again. But for behavior like this the immediate question is going to > be what effect migration (or saving/restoring) of the guest ought to > have. Replying to the save/restore part: this is covered by my patch. Any restore (or incoming live migration) from a source that doesn't have msr_relaxed support will get that option enabled by default, so that guests migrated from previous Xen versions don't see a change in MSR access behavior. That applies to both PV and HVM guests (unless I have messed things up in my patch). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 09 15:39:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 15:39:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95590.180502 (Exim 4.92) (envelope-from ) id 1lJeSG-0000tl-Ot; Tue, 09 Mar 2021 15:39:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95590.180502; Tue, 09 Mar 2021 15:39:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJeSG-0000te-Lg; Tue, 09 Mar 2021 15:39:28 +0000 Received: by outflank-mailman (input) for mailman id 95590; Tue, 09 Mar 2021 15:39:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJeSF-0000tZ-KR for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 15:39:27 +0000 Received: from mail-lf1-x12d.google.com (unknown [2a00:1450:4864:20::12d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3b0e38db-5cdf-48f5-aa3d-bcd6901f06ef; Tue, 09 Mar 2021 15:39:26 +0000 (UTC) Received: by mail-lf1-x12d.google.com with SMTP id v2so14758355lft.9 for ; Tue, 09 Mar 2021 07:39:26 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b0e38db-5cdf-48f5-aa3d-bcd6901f06ef DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l58xmmVOujUcw8TlSSVOH7vDnqxBI6hJIhiBvOHQ3Tk=; b=bsisIYh6Qra+bnUKUlVJ4KB22EmyrjLM/7CDHGuRv9o5pLPVwxFuV/L9d9A/Jeq/9x DgXYw24CdpC3yvyPVQPJbhQZgY5IW9dt1L6zK0OqDxVDv7YDk9gqmVD4wXdGIYUZ+Wjc aR8Th8BOQDWO4LYndjH1KxglUD2zTuMEohfnmAYFftqvLvUghjpoiLBBWu4n5batpZLF Hh+BHCUV4r2cRI03aIqsaAD3/NEq4hMnCLYIVTL59ibXM2c4egQ0ODmsif2bRAWthLx+ jo/BhSEngrFhOU/NkAYCFyka/5olyJQYRRQfTVgXEtfkSV0z/AdXiCivGkfubQ/fRGmI cxeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l58xmmVOujUcw8TlSSVOH7vDnqxBI6hJIhiBvOHQ3Tk=; b=HYlemSoutksq+Nxlx7h1MY1nNLEkmF4faGYYcvW3vEyQ9CLIBtxlvLKEsMmooZHMfh BEujDMp/X+5keuhHr3Q0bSq6HdKXWdPaevPsGUiGNpnlfdI6IamD1a23bM2WgCkMv+Wv iTUu0PLTDy6/uGA+zAMyUvjdhe1y1NiWoC6qwmxhqkJwKlId54qo/XYRE1B7tizKILVP 9oZ2XZb5on4vATEiiu9jVYKcQeLqRR1iXXt5VRLOB//Y3hELUBlhIN0yCR/rfueDld17 k6Q/TXskI6bvjKl7bq0RRxxL8pcNWFzOWd7SBg8Q7T0Tuj2DhY9CWFqyZpBdNn9R0FCt dd/Q== X-Gm-Message-State: AOAM533h1P0WC17C2QSaZgZd4ZZfZz+HX2g1MJ20YOBeCZJvVOTKcAyr EwJkNXK+UFunv7AVUNl1KpB+ZK35+72LrnObzYE= X-Google-Smtp-Source: ABdhPJwujjv8+xAbRl5wwIBuE0bkomGV2eFE7SvJB7axQ5lqRnUS3QH9t4Z4GESiRYiYe3Z5fEnD7CjwaCC1/oqQ5n8= X-Received: by 2002:a05:6512:370f:: with SMTP id z15mr6872274lfr.562.1615304365529; Tue, 09 Mar 2021 07:39:25 -0800 (PST) MIME-Version: 1.0 References: <20210309145002.30359-1-iwj@xenproject.org> <20210309145002.30359-4-iwj@xenproject.org> In-Reply-To: <20210309145002.30359-4-iwj@xenproject.org> From: Jason Andryuk Date: Tue, 9 Mar 2021 10:39:14 -0500 Message-ID: Subject: Re: [PATCH 4.15 3/3] CHANGELOG.md: Glean some information from SUPPORT.md To: Ian Jackson Cc: xen-devel , Community Manager Content-Type: text/plain; charset="UTF-8" On Tue, Mar 9, 2021 at 9:50 AM Ian Jackson wrote: > > Signed-off-by: Ian Jackson > --- > CHANGELOG.md | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 4ecd157a35..ccdbb82c2e 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -6,6 +6,16 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > > ## [Unreleased](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog) > > +## Added / support upgraded > + - Linux device model stubdomains (Tech Preview) This is inaccurate. Linux device model stubdomains went into 4.14, but SUPPORT.md was only updated in 4.15. Patch 2/3 removed "libxl support for running qemu-xen device model in a linux stubdomain." Regards, Jason From xen-devel-bounces@lists.xenproject.org Tue Mar 09 16:06:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 16:06:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95598.180517 (Exim 4.92) (envelope-from ) id 1lJesV-00044x-1h; Tue, 09 Mar 2021 16:06:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95598.180517; Tue, 09 Mar 2021 16:06:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJesU-00044q-US; Tue, 09 Mar 2021 16:06:34 +0000 Received: by outflank-mailman (input) for mailman id 95598; Tue, 09 Mar 2021 16:06:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJesT-00044h-Ph for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 16:06:33 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 71f5cab4-acc3-49d2-9ec5-97cb181ff656; Tue, 09 Mar 2021 16:06:32 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3EF51AEC4; Tue, 9 Mar 2021 16:06:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71f5cab4-acc3-49d2-9ec5-97cb181ff656 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615305991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bItPstEQLhxvk+MVBlxjVI1YB2J02jgbKDGYfqttiBY=; b=o92FAkPYMlFd1PqVN9IkglmvGsLiQg8uSNViGVfUx5cTwU8MnwSeYp76NkuU8WdN1I2plM 3NCidYVI/mSz+xR9sqNUEjPesqeKk3Gjnj++OwaxRCDOuDa8zUJrI+44SmL7sq92nUq+CX Tz+CNcFSfn+I+9u/a9AWX0rh2GcrxIk= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: [PATCH v6 13/12] x86/alternative: merge include files Date: Tue, 9 Mar 2021 17:06:20 +0100 Message-Id: <20210309160621.29290-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309134813.23912-1-jgross@suse.com> References: <20210309134813.23912-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Merge arch/x86/include/asm/alternative-asm.h into arch/x86/include/asm/alternative.h in order to make it easier to use common definitions later. Signed-off-by: Juergen Gross --- arch/x86/entry/entry_32.S | 2 +- arch/x86/entry/vdso/vdso32/system_call.S | 2 +- arch/x86/include/asm/alternative-asm.h | 121 ----------------------- arch/x86/include/asm/alternative.h | 121 +++++++++++++++++++++-- arch/x86/include/asm/nospec-branch.h | 1 - arch/x86/include/asm/smap.h | 5 +- arch/x86/lib/atomic64_386_32.S | 2 +- arch/x86/lib/atomic64_cx8_32.S | 2 +- arch/x86/lib/copy_page_64.S | 2 +- arch/x86/lib/copy_user_64.S | 2 +- arch/x86/lib/memcpy_64.S | 2 +- arch/x86/lib/memmove_64.S | 2 +- arch/x86/lib/memset_64.S | 2 +- arch/x86/lib/retpoline.S | 2 +- 14 files changed, 126 insertions(+), 142 deletions(-) delete mode 100644 arch/x86/include/asm/alternative-asm.h diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S index 765487e57d6e..96f084868ec7 100644 --- a/arch/x86/entry/entry_32.S +++ b/arch/x86/entry/entry_32.S @@ -40,7 +40,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/arch/x86/entry/vdso/vdso32/system_call.S b/arch/x86/entry/vdso/vdso32/system_call.S index de1fff7188aa..d6a6080bade0 100644 --- a/arch/x86/entry/vdso/vdso32/system_call.S +++ b/arch/x86/entry/vdso/vdso32/system_call.S @@ -6,7 +6,7 @@ #include #include #include -#include +#include .text .globl __kernel_vsyscall diff --git a/arch/x86/include/asm/alternative-asm.h b/arch/x86/include/asm/alternative-asm.h deleted file mode 100644 index 80bc6b533358..000000000000 --- a/arch/x86/include/asm/alternative-asm.h +++ /dev/null @@ -1,121 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#ifndef _ASM_X86_ALTERNATIVE_ASM_H -#define _ASM_X86_ALTERNATIVE_ASM_H - -#ifdef __ASSEMBLY__ - -#include - -#define ALTINSTR_FLAG_INV (1 << 15) -#define ALT_NOT(feat) ((feat) | ALTINSTR_FLAG_INV) - -#ifdef CONFIG_SMP - .macro LOCK_PREFIX -672: lock - .pushsection .smp_locks,"a" - .balign 4 - .long 672b - . - .popsection - .endm -#else - .macro LOCK_PREFIX - .endm -#endif - -/* - * objtool annotation to ignore the alternatives and only consider the original - * instruction(s). - */ -.macro ANNOTATE_IGNORE_ALTERNATIVE - .Lannotate_\@: - .pushsection .discard.ignore_alts - .long .Lannotate_\@ - . - .popsection -.endm - -/* - * Issue one struct alt_instr descriptor entry (need to put it into - * the section .altinstructions, see below). This entry contains - * enough information for the alternatives patching code to patch an - * instruction. See apply_alternatives(). - */ -.macro altinstruction_entry orig alt feature orig_len alt_len pad_len - .long \orig - . - .long \alt - . - .word \feature - .byte \orig_len - .byte \alt_len - .byte \pad_len -.endm - -/* - * Define an alternative between two instructions. If @feature is - * present, early code in apply_alternatives() replaces @oldinstr with - * @newinstr. ".skip" directive takes care of proper instruction padding - * in case @newinstr is longer than @oldinstr. - */ -.macro ALTERNATIVE oldinstr, newinstr, feature -140: - \oldinstr -141: - .skip -(((144f-143f)-(141b-140b)) > 0) * ((144f-143f)-(141b-140b)),0x90 -142: - - .pushsection .altinstructions,"a" - altinstruction_entry 140b,143f,\feature,142b-140b,144f-143f,142b-141b - .popsection - - .pushsection .altinstr_replacement,"ax" -143: - \newinstr -144: - .popsection -.endm - -#define old_len 141b-140b -#define new_len1 144f-143f -#define new_len2 145f-144f - -/* - * gas compatible max based on the idea from: - * http://graphics.stanford.edu/~seander/bithacks.html#IntegerMinOrMax - * - * The additional "-" is needed because gas uses a "true" value of -1. - */ -#define alt_max_short(a, b) ((a) ^ (((a) ^ (b)) & -(-((a) < (b))))) - - -/* - * Same as ALTERNATIVE macro above but for two alternatives. If CPU - * has @feature1, it replaces @oldinstr with @newinstr1. If CPU has - * @feature2, it replaces @oldinstr with @feature2. - */ -.macro ALTERNATIVE_2 oldinstr, newinstr1, feature1, newinstr2, feature2 -140: - \oldinstr -141: - .skip -((alt_max_short(new_len1, new_len2) - (old_len)) > 0) * \ - (alt_max_short(new_len1, new_len2) - (old_len)),0x90 -142: - - .pushsection .altinstructions,"a" - altinstruction_entry 140b,143f,\feature1,142b-140b,144f-143f,142b-141b - altinstruction_entry 140b,144f,\feature2,142b-140b,145f-144f,142b-141b - .popsection - - .pushsection .altinstr_replacement,"ax" -143: - \newinstr1 -144: - \newinstr2 -145: - .popsection -.endm - -#define ALTERNATIVE_TERNARY(oldinstr, feature, newinstr1, newinstr2) \ - ALTERNATIVE_2 oldinstr, newinstr2, X86_FEATURE_ALWAYS, \ - newinstr1, feature - -#endif /* __ASSEMBLY__ */ - -#endif /* _ASM_X86_ALTERNATIVE_ASM_H */ diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h index 4fb844e29d26..03f428e6b897 100644 --- a/arch/x86/include/asm/alternative.h +++ b/arch/x86/include/asm/alternative.h @@ -2,13 +2,17 @@ #ifndef _ASM_X86_ALTERNATIVE_H #define _ASM_X86_ALTERNATIVE_H -#ifndef __ASSEMBLY__ - #include -#include #include #include +#define ALTINSTR_FLAG_INV (1 << 15) +#define ALT_NOT(feat) ((feat) | ALTINSTR_FLAG_INV) + +#ifndef __ASSEMBLY__ + +#include + /* * Alternative inline assembly for SMP. * @@ -59,14 +63,11 @@ struct alt_instr { s32 instr_offset; /* original instruction */ s32 repl_offset; /* offset to replacement instruction */ u16 cpuid; /* cpuid bit set for replacement */ -#define ALTINSTR_FLAG_INV (1 << 15) u8 instrlen; /* length of original instruction */ u8 replacementlen; /* length of new instruction */ u8 padlen; /* length of build-time padding */ } __packed; -#define ALT_NOT(feat) ((feat) | ALTINSTR_FLAG_INV) - /* * Debug flag that can be tested to see whether alternative * instructions were patched in already: @@ -280,6 +281,114 @@ static inline int alternatives_text_reserved(void *start, void *end) */ #define ASM_NO_INPUT_CLOBBER(clbr...) "i" (0) : clbr +#else /* __ASSEMBLY__ */ + +#ifdef CONFIG_SMP + .macro LOCK_PREFIX +672: lock + .pushsection .smp_locks,"a" + .balign 4 + .long 672b - . + .popsection + .endm +#else + .macro LOCK_PREFIX + .endm +#endif + +/* + * objtool annotation to ignore the alternatives and only consider the original + * instruction(s). + */ +.macro ANNOTATE_IGNORE_ALTERNATIVE + .Lannotate_\@: + .pushsection .discard.ignore_alts + .long .Lannotate_\@ - . + .popsection +.endm + +/* + * Issue one struct alt_instr descriptor entry (need to put it into + * the section .altinstructions, see below). This entry contains + * enough information for the alternatives patching code to patch an + * instruction. See apply_alternatives(). + */ +.macro altinstruction_entry orig alt feature orig_len alt_len pad_len + .long \orig - . + .long \alt - . + .word \feature + .byte \orig_len + .byte \alt_len + .byte \pad_len +.endm + +/* + * Define an alternative between two instructions. If @feature is + * present, early code in apply_alternatives() replaces @oldinstr with + * @newinstr. ".skip" directive takes care of proper instruction padding + * in case @newinstr is longer than @oldinstr. + */ +.macro ALTERNATIVE oldinstr, newinstr, feature +140: + \oldinstr +141: + .skip -(((144f-143f)-(141b-140b)) > 0) * ((144f-143f)-(141b-140b)),0x90 +142: + + .pushsection .altinstructions,"a" + altinstruction_entry 140b,143f,\feature,142b-140b,144f-143f,142b-141b + .popsection + + .pushsection .altinstr_replacement,"ax" +143: + \newinstr +144: + .popsection +.endm + +#define old_len 141b-140b +#define new_len1 144f-143f +#define new_len2 145f-144f + +/* + * gas compatible max based on the idea from: + * http://graphics.stanford.edu/~seander/bithacks.html#IntegerMinOrMax + * + * The additional "-" is needed because gas uses a "true" value of -1. + */ +#define alt_max_short(a, b) ((a) ^ (((a) ^ (b)) & -(-((a) < (b))))) + +/* + * Same as ALTERNATIVE macro above but for two alternatives. If CPU + * has @feature1, it replaces @oldinstr with @newinstr1. If CPU has + * @feature2, it replaces @oldinstr with @feature2. + */ +.macro ALTERNATIVE_2 oldinstr, newinstr1, feature1, newinstr2, feature2 +140: + \oldinstr +141: + .skip -((alt_max_short(new_len1, new_len2) - (old_len)) > 0) * \ + (alt_max_short(new_len1, new_len2) - (old_len)),0x90 +142: + + .pushsection .altinstructions,"a" + altinstruction_entry 140b,143f,\feature1,142b-140b,144f-143f,142b-141b + altinstruction_entry 140b,144f,\feature2,142b-140b,145f-144f,142b-141b + .popsection + + .pushsection .altinstr_replacement,"ax" +143: + \newinstr1 +144: + \newinstr2 +145: + .popsection +.endm + +#define ALTERNATIVE_TERNARY(oldinstr, feature, newinstr1, newinstr2) \ + ALTERNATIVE_2 oldinstr, newinstr2, X86_FEATURE_ALWAYS, \ + newinstr1, feature + #endif /* __ASSEMBLY__ */ #endif /* _ASM_X86_ALTERNATIVE_H */ diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h index cb9ad6b73973..529f8e9380d8 100644 --- a/arch/x86/include/asm/nospec-branch.h +++ b/arch/x86/include/asm/nospec-branch.h @@ -7,7 +7,6 @@ #include #include -#include #include #include #include diff --git a/arch/x86/include/asm/smap.h b/arch/x86/include/asm/smap.h index 8b58d6975d5d..ea1d8eb644cb 100644 --- a/arch/x86/include/asm/smap.h +++ b/arch/x86/include/asm/smap.h @@ -11,6 +11,7 @@ #include #include +#include /* "Raw" instruction opcodes */ #define __ASM_CLAC ".byte 0x0f,0x01,0xca" @@ -18,8 +19,6 @@ #ifdef __ASSEMBLY__ -#include - #ifdef CONFIG_X86_SMAP #define ASM_CLAC \ @@ -37,8 +36,6 @@ #else /* __ASSEMBLY__ */ -#include - #ifdef CONFIG_X86_SMAP static __always_inline void clac(void) diff --git a/arch/x86/lib/atomic64_386_32.S b/arch/x86/lib/atomic64_386_32.S index 3b6544111ac9..16bc9130e7a5 100644 --- a/arch/x86/lib/atomic64_386_32.S +++ b/arch/x86/lib/atomic64_386_32.S @@ -6,7 +6,7 @@ */ #include -#include +#include /* if you want SMP support, implement these with real spinlocks */ .macro LOCK reg diff --git a/arch/x86/lib/atomic64_cx8_32.S b/arch/x86/lib/atomic64_cx8_32.S index 1c5c81c16b06..ce6935690766 100644 --- a/arch/x86/lib/atomic64_cx8_32.S +++ b/arch/x86/lib/atomic64_cx8_32.S @@ -6,7 +6,7 @@ */ #include -#include +#include .macro read64 reg movl %ebx, %eax diff --git a/arch/x86/lib/copy_page_64.S b/arch/x86/lib/copy_page_64.S index 2402d4c489d2..db4b4f9197c7 100644 --- a/arch/x86/lib/copy_page_64.S +++ b/arch/x86/lib/copy_page_64.S @@ -3,7 +3,7 @@ #include #include -#include +#include #include /* diff --git a/arch/x86/lib/copy_user_64.S b/arch/x86/lib/copy_user_64.S index 77b9b2a3b5c8..57b79c577496 100644 --- a/arch/x86/lib/copy_user_64.S +++ b/arch/x86/lib/copy_user_64.S @@ -11,7 +11,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/arch/x86/lib/memcpy_64.S b/arch/x86/lib/memcpy_64.S index 1e299ac73c86..1cc9da6e29c7 100644 --- a/arch/x86/lib/memcpy_64.S +++ b/arch/x86/lib/memcpy_64.S @@ -4,7 +4,7 @@ #include #include #include -#include +#include #include .pushsection .noinstr.text, "ax" diff --git a/arch/x86/lib/memmove_64.S b/arch/x86/lib/memmove_64.S index 41902fe8b859..64801010d312 100644 --- a/arch/x86/lib/memmove_64.S +++ b/arch/x86/lib/memmove_64.S @@ -8,7 +8,7 @@ */ #include #include -#include +#include #include #undef memmove diff --git a/arch/x86/lib/memset_64.S b/arch/x86/lib/memset_64.S index 0bfd26e4ca9e..9827ae267f96 100644 --- a/arch/x86/lib/memset_64.S +++ b/arch/x86/lib/memset_64.S @@ -3,7 +3,7 @@ #include #include -#include +#include #include /* diff --git a/arch/x86/lib/retpoline.S b/arch/x86/lib/retpoline.S index f6fb1d218dcc..6bb74b5c238c 100644 --- a/arch/x86/lib/retpoline.S +++ b/arch/x86/lib/retpoline.S @@ -4,7 +4,7 @@ #include #include #include -#include +#include #include #include #include -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 16:06:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 16:06:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95599.180528 (Exim 4.92) (envelope-from ) id 1lJesa-00046s-D7; Tue, 09 Mar 2021 16:06:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95599.180528; Tue, 09 Mar 2021 16:06:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJesa-00046l-A0; Tue, 09 Mar 2021 16:06:40 +0000 Received: by outflank-mailman (input) for mailman id 95599; Tue, 09 Mar 2021 16:06:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJesY-00044h-Lw for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 16:06:38 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 71bdde6a-93c6-453c-bf2f-54ea5420be8e; Tue, 09 Mar 2021 16:06:32 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 21C7AAF0C; Tue, 9 Mar 2021 16:06:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71bdde6a-93c6-453c-bf2f-54ea5420be8e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615305992; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yE5Leq5IeRX/BGMbx+e0U1ktiHL+YFJD+F5kGmaHXd0=; b=EwCIEbawx8JZXbWyvRDdft0L71brX1Fx+d/eZYuwgZItIq6G5aTUcSr2UVJrwlCkGFKXrm pYZ0uFkIF6aGMVsjGli9Q1bZ51U3C5zgCu/XaNKv4ki1lj4IDx6a5FOxErE/kI43Yk5vp9 k+ZEUtvPFtuaXGTylCOasP4UGg38aPA= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: [PATCH v6 14/12] x86/alternative: don't open code ALTERNATIVE_TERNARY() in _static_cpu_has() Date: Tue, 9 Mar 2021 17:06:21 +0100 Message-Id: <20210309160621.29290-2-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309160621.29290-1-jgross@suse.com> References: <20210309134813.23912-1-jgross@suse.com> <20210309160621.29290-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit _static_cpu_has() contains a completely open coded version of ALTERNATIVE_TERNARY(). Replace that with the macro instead. Signed-off-by: Juergen Gross --- arch/x86/include/asm/cpufeature.h | 41 +++++++------------------------ 1 file changed, 9 insertions(+), 32 deletions(-) diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h index 1728d4ce5730..16a51e7288d5 100644 --- a/arch/x86/include/asm/cpufeature.h +++ b/arch/x86/include/asm/cpufeature.h @@ -8,6 +8,7 @@ #include #include +#include enum cpuid_leafs { @@ -175,39 +176,15 @@ extern void clear_cpu_cap(struct cpuinfo_x86 *c, unsigned int bit); */ static __always_inline bool _static_cpu_has(u16 bit) { - asm_volatile_goto("1: jmp 6f\n" - "2:\n" - ".skip -(((5f-4f) - (2b-1b)) > 0) * " - "((5f-4f) - (2b-1b)),0x90\n" - "3:\n" - ".section .altinstructions,\"a\"\n" - " .long 1b - .\n" /* src offset */ - " .long 4f - .\n" /* repl offset */ - " .word %P[always]\n" /* always replace */ - " .byte 3b - 1b\n" /* src len */ - " .byte 5f - 4f\n" /* repl len */ - " .byte 3b - 2b\n" /* pad len */ - ".previous\n" - ".section .altinstr_replacement,\"ax\"\n" - "4: jmp %l[t_no]\n" - "5:\n" - ".previous\n" - ".section .altinstructions,\"a\"\n" - " .long 1b - .\n" /* src offset */ - " .long 0\n" /* no replacement */ - " .word %P[feature]\n" /* feature bit */ - " .byte 3b - 1b\n" /* src len */ - " .byte 0\n" /* repl len */ - " .byte 0\n" /* pad len */ - ".previous\n" - ".section .altinstr_aux,\"ax\"\n" - "6:\n" - " testb %[bitnum],%[cap_byte]\n" - " jnz %l[t_yes]\n" - " jmp %l[t_no]\n" - ".previous\n" + asm_volatile_goto( + ALTERNATIVE_TERNARY("jmp 6f", %P[feature], "", "jmp %l[t_no]") + ".section .altinstr_aux,\"ax\"\n" + "6:\n" + " testb %[bitnum],%[cap_byte]\n" + " jnz %l[t_yes]\n" + " jmp %l[t_no]\n" + ".previous\n" : : [feature] "i" (bit), - [always] "i" (X86_FEATURE_ALWAYS), [bitnum] "i" (1 << (bit & 7)), [cap_byte] "m" (((const char *)boot_cpu_data.x86_capability)[bit >> 3]) : : t_yes, t_no); -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 16:07:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 16:07:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95606.180541 (Exim 4.92) (envelope-from ) id 1lJetk-0004JK-OG; Tue, 09 Mar 2021 16:07:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95606.180541; Tue, 09 Mar 2021 16:07:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJetk-0004JD-KP; Tue, 09 Mar 2021 16:07:52 +0000 Received: by outflank-mailman (input) for mailman id 95606; Tue, 09 Mar 2021 16:07:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJetj-0004J6-5H for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 16:07:51 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a2900864-d6fe-44a5-8d7b-393045be25e5; Tue, 09 Mar 2021 16:07:49 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 14678AF0C; Tue, 9 Mar 2021 16:07:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2900864-d6fe-44a5-8d7b-393045be25e5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615306069; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zuzxC2VAAcoZxRiP1UTz555AsK1O/NCW3/YWheLLu1k=; b=AYzLSd21doUDbJ4gcjLWqWTzSlj62q5xMcC2/8nLMcHSwuMgQSR6VEijPJblXPMAOufBvT +ATvXh6wRHJFzxwiHdqC8zGyQpiM4HISQgMHnkEFQtVOSaqNfVrz7BJFAmELIYOqAOQ1C9 PgJm7FtQhlHQD+RbyLmdskk5n10FxrQ= Subject: Re: [PATCH v2 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson References: <1f19ced7-183b-8f08-3a90-c06039e053a6@suse.com> <204d73ec-a46a-6cef-9bc4-4219a7d00350@suse.com> <6dd26887-4246-8c5d-bf94-de03657230c1@suse.com> From: Jan Beulich Message-ID: Date: Tue, 9 Mar 2021 17:07:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09.03.2021 16:19, Roger Pau Monné wrote: > On Tue, Mar 09, 2021 at 03:50:59PM +0100, Jan Beulich wrote: >> On 09.03.2021 14:37, Roger Pau Monné wrote: >>> Right. So given this awkward position Xen is in, we should maybe make >>> the lack of #GP injection as a result of an MSR access when no handler >>> is set formally part of the ABI and written down somewhere? >>> >>> It's not ideal, but at the end of day PV is 'our' own architecture, >>> and given that this workaround will be enabled by default, and that we >>> won't be able to turn it off we should have it written down as part of >>> the ABI. >>> >>> If you agree with this I'm fine with not injecting a #GP at all unless >>> the handler is set for PV, like you proposed in your first patch. IMO >>> it's not ideal, but it's better if it's a consistent behavior and >>> clearly written down in the public headers (likely next to the >>> hypercall used to setup the #GP handler). >>> >>> I know this can be seen as broken behavior from an x86 perspective, >>> but again PV is already different from x86. >> >> I'm certainly not opposed to spelling this out somewhere; iirc you >> said the other day that you couldn't spot a good place. I can't think >> of a good place either. > > After looking some more, I think placing such comment next to > HYPERVISOR_set_trap_table (in arch-x86/xen.h) would be fine. > >> Furthermore before we spell out anything we >> (which specifically includes Andrew) need to settle on the precise >> behavior we want. I did suggest earlier that I could see us tighten >> the condition, and there are many possible variations. For example we >> could record whether a #GP handler was ever installed, so we wouldn't >> return back to the relaxed behavior in case a guest zapped its handler >> again. But for behavior like this the immediate question is going to >> be what effect migration (or saving/restoring) of the guest ought to >> have. > > Replying to the save/restore part: this is covered by my patch. Any > restore (or incoming live migration) from a source that doesn't have > msr_relaxed support will get that option enabled by default, so that > guests migrated from previous Xen versions don't see a change in MSR > access behavior. That applies to both PV and HVM guests (unless I have > messed things up in my patch). Well, yes, that's for your changes. But here the question is about mine (and remember we didn't settle on the precise condition(s) yet, so the migration aspect may not be relevant in the end). Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 09 16:25:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 16:25:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95610.180553 (Exim 4.92) (envelope-from ) id 1lJfAO-00068a-7r; Tue, 09 Mar 2021 16:25:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95610.180553; Tue, 09 Mar 2021 16:25:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJfAO-00068T-4C; Tue, 09 Mar 2021 16:25:04 +0000 Received: by outflank-mailman (input) for mailman id 95610; Tue, 09 Mar 2021 16:25:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJfAN-00068N-Bz for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 16:25:03 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1238924a-880d-4357-a73e-7f672dc246dd; Tue, 09 Mar 2021 16:25:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1238924a-880d-4357-a73e-7f672dc246dd DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615307101; h=date:from:to:cc:subject:message-id:mime-version; bh=fp/YStO+ktkcgHk+Zc8qi9P4yFhmoexXHn06iO9Y60g=; b=Z4r4neW+joiAQsA+l75yFdrtfmbnEdFO2aFUxLLnGaNUvtVEZc2h26ZI RcKmVq1ir/a/hGMu5QVPqXryHwEAya0/vC6OJJAmlzA0HvXUnW2F/XMZi N3/MPx82AbtY84cLwY7sD6eSxHAb8zSzUftgOInExg478tPpPRH7ObhQn w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Fb3Olky8jubWGzKWhGDYEsB56sHo4DoXNvrb5mJKHNBjCOTyXK3cHrUE6jLm2O9ycrVTewRM/Y ioPdjAHT4fv7HbFvfeLkdHgKtaWWGzwb+3GY9Sh/ZS8PgxkBkIkmyPtICK/GYfrEauxGgMmCcX tH7mTJC/l5AeHQkGL2cdUbPneNXjHT916Sz3fMH2qrCaRo7K5dN8RPoRmGrgkxeE82uqAQKnfq nQUbwJJ+jpbwlk1Qt+5NSRGFLMB/G9CJDJqdYrIJfjpBzv1QU9GoKZBDai2pm8oKecCPMqRoSg +/o= X-SBRS: 5.2 X-MesageID: 38870622 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,234,1610427600"; d="scan'208";a="38870622" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jmv6bUbERCx9Z88EoLwQQnVv/zjfPry1oiRqCACktGmLVmjiCxiCZsG48pApjwMkQX3kVWVh2HKMf0Hg0fyYelagS5QkUJsTX5kN6q8KpqGCdn/TsAYwjBscVrckgR1zveQ+Wkk2PY9K05XSKtstjZyK91mkkXfVdL90AacQGIV8eEPBCLJa/awXwTE9ro2rU5p3sYGKY0Ws49kMvvoi1z7i7CUb2hIaKysKG685V6TIdlpsBFbAtg7bdmy7f2D7OQhWj5FsZPS/n0DmWJD4vxKvUNGoVsPOlI0/HITHWG+x3dmOghOt78lydkfebTZj0ODBZfWP67MLEMdwiRJytg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fO1ef3mSDffnRRp2Ck8LauB0yKia47IRx9JQnaqgBnw=; b=kgo/f3y1gKspVaXOiDExArBJnsOblBXwueZfC9mTbPA0mx9mxJ1UG9Nvo9xcpkdg31Ly+34mmQbhwQaGYxdHGjl+ZXHAo3mx/I4e31VmhfeG/ERt4eOnnyhqcfgE/D7sh5ppDHS2u9QG2M1DZRUuq+WQoLk1uDT0eikOa+fhgGSrNXP1IHSyueJmncpSVai6BBJ6Ah9NyaMsS8mIcf/OZwjyfsRwfvvpQ31mwDZ588xUS1+BvJsWaTf1KIDreIOdgcrlkAkpoEmOHGnk/1lqhePM5zhsMYJ7wQyWfShWtsGMpA2LOu/wh6vDphadMcfQN/BH1ORY5rScIqh60cav9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fO1ef3mSDffnRRp2Ck8LauB0yKia47IRx9JQnaqgBnw=; b=uajTr+DGzoOYHi8ECiIpeUB3qQDkPNzwvYy1Qz9UCvrSrpfJ0Hol9FqGQKI/A6YxD7jE5gS4MQquAZE6xwqehqxGlxiQU+2Ag7Uo0jpagQ4VawXXc939kx6lKnkLtaeSWjLriHY3coYE216pTmYLBmCZFJHnHgzdW9ZDfsYzpGs= Date: Tue, 9 Mar 2021 17:24:45 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Dario Faggioli , George Dunlap CC: Subject: Hit ASSERT in credit2 code with NR_CPUS=1 build Message-ID: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-ClientProxiedBy: LO4P123CA0141.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::20) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c30ed278-f2cf-4c4c-674f-08d8e317dd6f X-MS-TrafficTypeDiagnostic: DM6PR03MB4538: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ORkJS5A0EUFx1zMSP5H9XA0YJP8+d6xNVqP0N+ONKtOMDB65FVl7ifUcjRj0SxLQMfdX5LsGOx3V1BGayEBf14kHPGjbgpjmEcwKj/++jkaUXAc1iTU04YoKIrqvbMFuzQTygtsONS4+YapGrL5wXTJkl8USP8ovSAzu//o+1s71Stvezkjy24Ur1mF8te/Z6znfoVXHejqfWaFekCKJBVm9YE4JsMjY5oc8OOc9gXFoame3di4AV5XRnCKGGo42OSHYHvZ6hhu2ngnpsVa8N/ImT58/oL5UwQtV67eW/Ofs4GcDPf/gzAuFj0oeIdQBlMYmUQ1Ig1Bni/SZlIIuuNeSGxVzl/Z7yyH4uz2fQCpLCmK9lKwNGhoGuNFEIlji/dwAOKqc01Qvts+6QNwudDz1c2pYXoWAOGg2aLGmVrdQeXI9cyfFq9S5FysoYv34OYrq1bMpv5Lsn/CfWk5X9ZJU4NXr8Ghb8jfhkap7qggG2IFnmIo6But2eFJeX/Z0JhC0A0pa+fqF4PQTf4qC4Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(376002)(39860400002)(396003)(136003)(346002)(366004)(66556008)(66476007)(4326008)(5660300002)(478600001)(86362001)(316002)(956004)(33716001)(8676002)(26005)(66946007)(110136005)(186003)(6496006)(2906002)(16526019)(8936002)(6636002)(85182001)(6666004)(6486002)(9686003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dEgvS1RPNEprZ2EvZy9QTWNGOTVkRU9sczRmV1hRY1oxMUl5K3V4ZDF4bEVT?= =?utf-8?B?Z0lmSExxNkVhVVJ4THhacURIWTQwdjNyVmpCKy8xV3RZMUc0ckdDOVlwNjNk?= =?utf-8?B?QmVPQXp3R0IzR3RpTFFQRmJXRmtiZ0ltS2k0aVBIeXA4Z2NSN2htck9yNnc3?= =?utf-8?B?WEpJejBQTVMzdTRjb3JXdzRkSGdzU1VVWFBDbW5vQU5JN0tSZW5ITUNEZzVQ?= =?utf-8?B?OXcwbUVTdGp0cWUxa2hRZENYSm91QnBGMlpmWERxdVpaTEhIaENjUWY4Y1ZP?= =?utf-8?B?KzVEcXUwbCsyR1RHcGRvUzBIUWs4V3pyZWg0enNiRTgvcnpxNm1hOFNFVFlC?= =?utf-8?B?cWpPUTJuWWtDby90bXF3NzQvYlQwOEZINGF5UDh3MDhTaUNKektya3dDV3dG?= =?utf-8?B?N25QM3FnUUl3aXZEODdjMDNOUFV2WE4xQmFPcHNQSWUraXdwUjN6bkVkNzJi?= =?utf-8?B?UjVTOUhhVUZjcTAzOGhPUDEwdVhjQTNGbUYrME1qNkdJY3FsL1FvWXN5OUI3?= =?utf-8?B?SnJJS252dGlRUlBOK0p5Y2xaYytyUUwyMVhDNytMZXo4V0FGQng5YUV3L09O?= =?utf-8?B?VlJuTUdzVS8zZDNhalRiTFM5NFFiUW1Fa2YzaFVjcjk3Z0tWOEsxaGY0WFl2?= =?utf-8?B?MmVyVkxEUExLM0drQjNCLzNGemZkcGltVnVXcktYQUxYUEt2bnFIZURSYjYv?= =?utf-8?B?eTVIQm45SjdKYW5XR1BPbElKRGZOWkJlQVMzQWE0VGR6YU84a2hnV0tLSW5r?= =?utf-8?B?SGJwWmtJNk1LR0hqZU5Tci9rMXlZb1lvMmZSQ3oxKzlrVFhOQTJkUmdPenZ2?= =?utf-8?B?VUZlOXMxNUV4QzNPd1kzVmtTYVZEMHVYVzlVS2VzVjV5MnVoUjRuSGhKbHdZ?= =?utf-8?B?T0RqamF3RFE1Vnd6dmttZW5aUGdPSzZZRE9TQm50YlZMekx3bVZiQWljVWVk?= =?utf-8?B?TllVM2o4WkJSNHFYYWU2SW1zemE1N3BSTXpBNzl4WXpOOVJoYlE2VGYzSU5L?= =?utf-8?B?TVlWbmpEY0kyNHhsNFQ2TW5yRFpIalVTeG5hZk8rUkdXV2Z2QXlWTndDMUhZ?= =?utf-8?B?eGVjbHVtL3N2RUFnUVZWRGkzWG5vT01yUDd5Q3MxTG9Ga054MjZReGtoem81?= =?utf-8?B?eFlkMU9ybmJOMHdTSW9DUllxVHNUUlFJV081bWVyWGJRdHdnUUUxYWhPOFFQ?= =?utf-8?B?ZDVyWHFLNmVOaEgzV0VabG01Z0cxaHgrZlBDUFhBWkRkTlVMa1BMaUtubGxU?= =?utf-8?B?TmVVODZaYmxYSTIzVFA3MXNrK2FkNUFEaHNEV2tjcDA1VjVLaVdiRFZTY2ZT?= =?utf-8?B?UEdEOWttUEl2ZzJVZ3FqbGN2VEVMV2Jnd3hjSE1oQS9kK0NPL1pIWmtOcWJZ?= =?utf-8?B?ZkVEcmJaYWNjWFRyRWFEMU9mTjU4ZnFjK25OL01rZEVhTzlSRnROTTB0NWJ6?= =?utf-8?B?OGFIM0lscjJkT1hGbkEvbVV3T0hnSlN5bUp3NVJqR0w4bCthaklGWHpjMDdq?= =?utf-8?B?ZFFHcytVNGZJVU5veGpsUHZjbndRckIzcFRWYzBFNDdFamxHTlVib0h2RUJY?= =?utf-8?B?UXdhUk9Qc2UwUHRoNnh2QmVVV25SM0ZSTUUvc3BiWEVML1RXcTlOZFFzeWY1?= =?utf-8?B?RWxCZ1craVJ5NURJUENDN2s4UjFaR3dvcEJGRFFXNE1CYnV0YzMzSzdYNVM0?= =?utf-8?B?MzZlb3RvODBjc3EyMVJRUlVZMTlsdWxVa0tNRWY0THlwZWN5Q0VqQVlTcGJ5?= =?utf-8?B?am5jR05jaWh3MWVROGpXVGlWWWFZT0ZEaE1JTjZ6K3NsUTBSakhCSVRhZ29t?= =?utf-8?B?TG9GOWlTUlo2dmZIby9MQT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: c30ed278-f2cf-4c4c-674f-08d8e317dd6f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 16:24:51.3018 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZWdyiRwB/ib1qycQL3XD3ThRbMihBnVOloBifzl+Buf1MY1bwTdsU3cgveh6gTBoq4UcsYvCH6yd+pIxVxQT3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4538 X-OriginatorOrg: citrix.com Hello, While looking at the NR_CPUS == 1 build I realized I could reliable trigger the following ASSERT by creating a guest (note that dom0 seems to be fine): (XEN) Assertion 'i != cpu' failed at credit2.c:1725 (XEN) ----[ Xen-4.15.0-rc x86_64 debug=y Tainted: C ]---- (XEN) CPU: 0 (XEN) RIP: e008:[] common/sched/credit2.c#runq_tickle+0x469/0x571 (XEN) RFLAGS: 0000000000010046 CONTEXT: hypervisor (d4v0) (XEN) rax: ffffffffffffffff rbx: 0000000000000000 rcx: 0000000000000000 (XEN) rdx: ffff83086c62feb0 rsi: 0000012774fba66c rdi: ffff8307e11d5d40 (XEN) rbp: ffff83008c8c7cf8 rsp: ffff83008c8c7c68 r8: ffff83086c66d6c0 (XEN) r9: ffff82d0405d1218 r10: 0000000000000000 r11: ffff83086c631000 (XEN) r12: ffff83086c6437c0 r13: 0000000000000000 r14: ffff83086c62fe20 (XEN) r15: ffff82d0405d0320 cr0: 0000000080050033 cr4: 00000000003526e0 (XEN) cr3: 00000007e130d000 cr2: ffff88826910cb38 (XEN) fsb: 00007efee038b780 gsb: ffff888273400000 gss: 0000000000000000 (XEN) ds: 0000 es: 0000 fs: 0000 gs: 0000 ss: e010 cs: e008 (XEN) Xen code around (common/sched/credit2.c#runq_tickle+0x469/0x571): (XEN) ac ff 75 3d 0f 0b 0f 0b <0f> 0b c7 45 ac 00 00 00 00 48 8d 05 6f 7e 38 00 (XEN) Xen stack trace from rsp=ffff83008c8c7c68: (XEN) ffff83008c8c7c88 0000012774fba66c ffff82d0404ab4e0 ffff82d0405d0320 (XEN) ffff82d0405d0320 ffff83086c62feb0 ffff83086c643760 ffffffff00000002 (XEN) ffff83008c8c7cd8 ffff82d0402f9234 ffff8307e131e000 0000000000000000 (XEN) ffff83008c8c7ce8 ffff83086c62feb0 ffff83086c62fe20 ffff83086c6437c0 (XEN) 0000012774fba66c ffff82d0405e64a0 ffff83008c8c7d58 ffff82d040249eb6 (XEN) ffff83008c8c7fff ffff82d0404ab4e0 ffff83008c8c7d18 ffff83008c8c7d18 (XEN) ffff83008c8c7d48 ffff83086c62fe20 ffff83086c66d620 ffff8307e11d5d40 (XEN) ffff83086c66d620 0000000000000000 ffff83008c8c7d78 ffff82d040253752 (XEN) ffff83086c61a000 ffff8307e11ca000 ffff83008c8c7da8 ffff82d040255d8b (XEN) ffff8307e11ca000 ffff83086c61a000 ffff8307e131e000 ffff83086c631000 (XEN) ffff83008c8c7df8 ffff82d04031edd6 ffff83086c61a060 0000000000000296 (XEN) 0000012774fb8f84 ffff8307e11ca000 ffff83086c61a000 0000000000000001 (XEN) 0000012774fb8f84 0000000000000000 ffff83008c8c7e38 ffff82d040255e37 (XEN) ffff83008c8c7e28 ffff83086c66d620 0000000000000000 ffff8307e11d5d40 (XEN) 0000000000000000 0000000000000001 ffff83008c8c7e98 ffff82d040256844 (XEN) ffff83086c61a000 ffff83086c62fe20 ffff82d0403953d4 ffff83086c6437c0 (XEN) deadbeefdeadf00d ffff82d0405d6e80 ffff82d0405d6e80 ffffffffffffffff (XEN) ffff83008c8c7fff 0000000000000000 ffff83008c8c7ed8 ffff82d04022dc68 (XEN) ffff82d0403953d4 ffff83086c61a000 0000000000000000 0000000000000000 (XEN) 0000000000000000 0000000000000000 ffff83008c8c7ee8 ffff82d04022dcfd (XEN) Xen call trace: (XEN) [] R common/sched/credit2.c#runq_tickle+0x469/0x571 (XEN) [] F common/sched/credit2.c#csched2_context_saved+0x27f/0x284 (XEN) [] F common/sched/core.c#unit_context_saved+0x56/0x84 (XEN) [] F sched_context_switched+0x14d/0x161 (XEN) [] F context_switch+0x15b/0x11dd (XEN) [] F common/sched/core.c#sched_context_switch+0x98/0x1e0 (XEN) [] F common/sched/core.c#schedule+0x216/0x2e5 (XEN) [] F common/softirq.c#__do_softirq+0x8a/0xb6 (XEN) [] F do_softirq+0x13/0x15 (XEN) [] F x86_64/entry.S#process_softirqs+0x6/0x20 (XEN) (XEN) (XEN) **************************************** (XEN) Panic on CPU 0: (XEN) Assertion 'i != cpu' failed at credit2.c:1725 (XEN) **************************************** This corresponds to the following chunk of code: for_each_cpu(i, &mask) { s_time_t score; /* Already looked at this one above */ ASSERT(i != cpu); <==== score = tickle_score(ops, now, new, i); if ( score > max ) { max = score; ipid = i; } } In runq_tickle. I'm afraid I have no clue of what's going on. FTR using a non-debug build with NR_CPUS == 1 does seem to work fine and I don't see any ill effects. Obviously the ASSERT is no longer there. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 09 17:01:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 17:01:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95623.180564 (Exim 4.92) (envelope-from ) id 1lJfiz-0001II-1w; Tue, 09 Mar 2021 17:00:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95623.180564; Tue, 09 Mar 2021 17:00:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJfiy-0001IB-V7; Tue, 09 Mar 2021 17:00:48 +0000 Received: by outflank-mailman (input) for mailman id 95623; Tue, 09 Mar 2021 17:00:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJfix-0001I6-FO for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 17:00:47 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8d535eb3-32fe-49f4-a0dd-89e450590a87; Tue, 09 Mar 2021 17:00:46 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8959FAEBD; Tue, 9 Mar 2021 17:00:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d535eb3-32fe-49f4-a0dd-89e450590a87 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615309245; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dU5QsM3WvQuC5eyrehfrQFR2D70sAZqFXdDdpQ0tB6A=; b=Rnu8+dcJ4g3u2jbhRDQ4GCyFt8Y4eKvyoPpKV74hafTyZU8ts01FDHsj/hRn6hBfHE1jLx XWU19QmrvbqPmQmhvsUfPUgQOkQ42PMg2xbQd3dBDdzLl+SzN44DKNNACLeA+7UXOOOio4 hfQ5qkiWHki/iKFknu68k/SenO9ii4g= To: Juergen Gross , Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH] Xen: drop exports of {set,clear}_foreign_p2m_mapping() Message-ID: <746a5cd6-1446-eda4-8b23-03c1cac30b8d@suse.com> Date: Tue, 9 Mar 2021 18:00:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit They're only used internally, and the layering violation they contain (x86) or imply (Arm) of calling HYPERVISOR_grant_table_op() strongly advise against any (uncontrolled) use from a module. The functions also never had users except the ones from drivers/xen/grant-table.c forever since their introduction in 3.15. Signed-off-by: Jan Beulich --- It's not clear to me why Arm doesn't have merely stubs just like x86 has when PV support is disabled. --- a/arch/arm/xen/p2m.c +++ b/arch/arm/xen/p2m.c @@ -130,7 +130,6 @@ int set_foreign_p2m_mapping(struct gntta return 0; } -EXPORT_SYMBOL_GPL(set_foreign_p2m_mapping); int clear_foreign_p2m_mapping(struct gnttab_unmap_grant_ref *unmap_ops, struct gnttab_unmap_grant_ref *kunmap_ops, @@ -145,7 +144,6 @@ int clear_foreign_p2m_mapping(struct gnt return 0; } -EXPORT_SYMBOL_GPL(clear_foreign_p2m_mapping); bool __set_phys_to_machine_multi(unsigned long pfn, unsigned long mfn, unsigned long nr_pages) --- a/arch/x86/xen/p2m.c +++ b/arch/x86/xen/p2m.c @@ -776,7 +776,6 @@ int set_foreign_p2m_mapping(struct gntta out: return ret; } -EXPORT_SYMBOL_GPL(set_foreign_p2m_mapping); int clear_foreign_p2m_mapping(struct gnttab_unmap_grant_ref *unmap_ops, struct gnttab_unmap_grant_ref *kunmap_ops, @@ -802,7 +801,6 @@ int clear_foreign_p2m_mapping(struct gnt return ret; } -EXPORT_SYMBOL_GPL(clear_foreign_p2m_mapping); #ifdef CONFIG_XEN_DEBUG_FS #include From xen-devel-bounces@lists.xenproject.org Tue Mar 09 17:01:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 17:01:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95624.180577 (Exim 4.92) (envelope-from ) id 1lJfjH-0001Lv-Am; Tue, 09 Mar 2021 17:01:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95624.180577; Tue, 09 Mar 2021 17:01:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJfjH-0001Ln-72; Tue, 09 Mar 2021 17:01:07 +0000 Received: by outflank-mailman (input) for mailman id 95624; Tue, 09 Mar 2021 17:01:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJfjF-0001LW-QV for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 17:01:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJfjF-0003f3-PW for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 17:01:05 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJfjF-0002SI-OA for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 17:01:05 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lJfjC-0003e8-Hp; Tue, 09 Mar 2021 17:01:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=MNKwVwPN8p6hE269VIEiLGJGddafQK0WnQi8TE5tXt0=; b=4GK/jWm9Nl/XhZOazsJ94OA8Dl PWn9rw22o4HhGexUYJFAyIuR236yQThXsYNSE/UvFU3l5RcVKLNF6z+CNCTq8MUOVG5cRRmYrX+mG uKStHYOcj6+MA01hsoafi8sM8ZVCL2XRwenlR2HeF7Mmj5GzHMgplUQSdsKdLz/Y+LR0=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24647.43470.308620.506630@mariner.uk.xensource.com> Date: Tue, 9 Mar 2021 17:01:02 +0000 To: Roger Pau Monne Cc: , Wei Liu , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection In-Reply-To: <20210309105634.7200-1-roger.pau@citrix.com> References: <20210309105634.7200-1-roger.pau@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monne writes ("[PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection"): > Introduce an option to allow selecting a behavior similar to the pre > Xen 4.15 one for accesses to MSRs not explicitly handled. Since commit > 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly > handled by Xen result in the injection of a #GP to the guest. This > is a behavior change since previously a #GP was only injected if > accessing the MSR on the real hardware would also trigger a #GP, or if > the attempted to be set bits wouldn't match the hardware values (for > PV). > > This seems to be problematic for some guests, so introduce an option > to fallback to this kind of legacy behavior without leaking the > underlying MSR values to the guest. > > When the option is set, for both PV and HVM don't inject a #GP to the > guest on MSR read if reading the underlying MSR doesn't result in a > #GP, do the same for writes and simply discard the value to be written > on that case. > > Note that for guests restored or migrated from previous Xen versions > the option is enabled by default, in order to keep a compatible > MSR behavior. Such compatibility is done at the libxl layer, to avoid > higher-level toolstacks from having to know the details about this flag. For the tools parts Reviewed-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Tue Mar 09 18:20:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 18:20:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95658.180593 (Exim 4.92) (envelope-from ) id 1lJgxw-00009b-73; Tue, 09 Mar 2021 18:20:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95658.180593; Tue, 09 Mar 2021 18:20:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJgxw-00009U-3t; Tue, 09 Mar 2021 18:20:20 +0000 Received: by outflank-mailman (input) for mailman id 95658; Tue, 09 Mar 2021 18:20:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJgxu-00009P-Jj for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 18:20:18 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 91cb705f-1054-43c4-a5e1-7594f8d59ff1; Tue, 09 Mar 2021 18:20:16 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5436031B; Tue, 9 Mar 2021 10:20:16 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6A48F3F73C; Tue, 9 Mar 2021 10:20:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91cb705f-1054-43c4-a5e1-7594f8d59ff1 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 0/5] xen/arm: smmuv1: Fix stream match conflict issue Date: Tue, 9 Mar 2021 18:19:24 +0000 Message-Id: X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch is the work to fix the stream match conflict issue when two devices have the same stream-id. Approach taken is to merge the below commit from Linux driver to fix the issue. 1. "iommu/arm-smmu: Handle stream IDs more dynamically" commit 21174240e4f4439bb8ed6c116cdbdc03eba2126e 2. "iommu/arm-smmu: Consolidate stream map entry state" commit 1f3d5ca43019bff1105838712d55be087d93c0da 3. "iommu/arm-smmu: Keep track of S2CR state" commit 8e8b203eabd8b9e96d02d6339e4abce3e5a7ea4b 4. "iommu/arm-smmu: Add a stream map entry iterator" commit d3097e39302083d58922a3d1032d7d59a63d263d 5. "iommu/arm-smmu: Intelligent SMR allocation" commit 588888a7399db352d2b1a41c9d5b3bf0fd482390 Rahul Singh (5): xen/arm: smmuv1: Handle stream IDs more dynamically xen/arm: smmuv1: Consolidate stream map entry state xen/arm: smmuv1: Keep track of S2CR state xen/arm: smmuv1: Add a stream map entry iterator xen/arm: smmuv1: Intelligent SMR allocation xen/drivers/passthrough/arm/smmu.c | 423 ++++++++++++++++++----------- 1 file changed, 262 insertions(+), 161 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 18:20:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 18:20:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95659.180605 (Exim 4.92) (envelope-from ) id 1lJgyE-0000Dc-FD; Tue, 09 Mar 2021 18:20:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95659.180605; Tue, 09 Mar 2021 18:20:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJgyE-0000DV-Bv; Tue, 09 Mar 2021 18:20:38 +0000 Received: by outflank-mailman (input) for mailman id 95659; Tue, 09 Mar 2021 18:20:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJgyC-0000DD-VR for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 18:20:37 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id f7a98a9c-1524-4241-979b-9c94f2b600cd; Tue, 09 Mar 2021 18:20:36 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1369931B; Tue, 9 Mar 2021 10:20:36 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 297B23F73C; Tue, 9 Mar 2021 10:20:35 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7a98a9c-1524-4241-979b-9c94f2b600cd From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 1/5] xen/arm: smmuv1: Handle stream IDs more dynamically Date: Tue, 9 Mar 2021 18:19:25 +0000 Message-Id: <7775719c50c56b801e69d952e4ce255b8da1481c.1615312254.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Backport commit 21174240e4f4439bb8ed6c116cdbdc03eba2126e "iommu/arm-smmu: Handle stream IDs more dynamically" from the Linux ernel. This patch is the preparatory work to fix the stream match conflict when two devices have the same stream-id. Original commit message: Rather than assuming fixed worst-case values for stream IDs and SMR masks, keep track of whatever implemented bits the hardware actually reports. This also obviates the slightly questionable validation of SMR fields in isolation - rather than aborting the whole SMMU probe for a hardware configuration which is still architecturally valid, we can simply refuse masters later if they try to claim an unrepresentable ID or mask (which almost certainly implies a DT error anyway). Signed-off-by: Rahul Singh --- xen/drivers/passthrough/arm/smmu.c | 43 +++++++++++++++--------------- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 3e8aa37866..adfab8ee84 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -440,9 +440,7 @@ static struct iommu_group *iommu_group_get(struct device *dev) #define ARM_SMMU_GR0_SMR(n) (0x800 + ((n) << 2)) #define SMR_VALID (1U << 31) #define SMR_MASK_SHIFT 16 -#define SMR_MASK_MASK 0x7fff #define SMR_ID_SHIFT 0 -#define SMR_ID_MASK 0x7fff #define ARM_SMMU_GR0_S2CR(n) (0xc00 + ((n) << 2)) #define S2CR_CBNDX_SHIFT 0 @@ -632,6 +630,8 @@ struct arm_smmu_device { atomic_t irptndx; u32 num_mapping_groups; + u16 streamid_mask; + u16 smr_mask_mask; DECLARE_BITMAP(smr_map, ARM_SMMU_MAX_SMRS); unsigned long s1_input_size; @@ -2140,39 +2140,40 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu) dev_notice(smmu->dev, "\tcoherent table walk\n"); } + /* Max. number of entries we have for stream matching/indexing */ + size = 1 << ((id >> ID0_NUMSIDB_SHIFT) & ID0_NUMSIDB_MASK); + smmu->streamid_mask = size - 1; if (id & ID0_SMS) { - u32 smr, sid, mask; + u32 smr; smmu->features |= ARM_SMMU_FEAT_STREAM_MATCH; - smmu->num_mapping_groups = (id >> ID0_NUMSMRG_SHIFT) & - ID0_NUMSMRG_MASK; - if (smmu->num_mapping_groups == 0) { + size = (id >> ID0_NUMSMRG_SHIFT) & ID0_NUMSMRG_MASK; + if (size == 0) { dev_err(smmu->dev, "stream-matching supported, but no SMRs present!\n"); return -ENODEV; } - smr = SMR_MASK_MASK << SMR_MASK_SHIFT; - smr |= (SMR_ID_MASK << SMR_ID_SHIFT); + /* + * SMR.ID bits may not be preserved if the corresponding MASK + * bits are set, so check each one separately. We can reject + * masters later if they try to claim IDs outside these masks. + */ + smr = smmu->streamid_mask << SMR_ID_SHIFT; writel_relaxed(smr, gr0_base + ARM_SMMU_GR0_SMR(0)); smr = readl_relaxed(gr0_base + ARM_SMMU_GR0_SMR(0)); + smmu->streamid_mask = smr >> SMR_ID_SHIFT; - mask = (smr >> SMR_MASK_SHIFT) & SMR_MASK_MASK; - sid = (smr >> SMR_ID_SHIFT) & SMR_ID_MASK; - if ((mask & sid) != sid) { - dev_err(smmu->dev, - "SMR mask bits (0x%x) insufficient for ID field (0x%x)\n", - mask, sid); - return -ENODEV; - } + smr = smmu->streamid_mask << SMR_MASK_SHIFT; + writel_relaxed(smr, gr0_base + ARM_SMMU_GR0_SMR(0)); + smr = readl_relaxed(gr0_base + ARM_SMMU_GR0_SMR(0)); + smmu->smr_mask_mask = smr >> SMR_MASK_SHIFT; dev_notice(smmu->dev, - "\tstream matching with %u register groups, mask 0x%x\n", - smmu->num_mapping_groups, mask); - } else { - smmu->num_mapping_groups = (id >> ID0_NUMSIDB_SHIFT) & - ID0_NUMSIDB_MASK; + "\tstream matching with %lu register groups, mask 0x%x", + size, smmu->smr_mask_mask); } + smmu->num_mapping_groups = size; /* ID1 */ id = readl_relaxed(gr0_base + ARM_SMMU_GR0_ID1); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 18:21:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 18:21:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95664.180617 (Exim 4.92) (envelope-from ) id 1lJgyq-0000Kp-Pg; Tue, 09 Mar 2021 18:21:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95664.180617; Tue, 09 Mar 2021 18:21:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJgyq-0000Ki-MC; Tue, 09 Mar 2021 18:21:16 +0000 Received: by outflank-mailman (input) for mailman id 95664; Tue, 09 Mar 2021 18:21:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJgyo-0000Kb-OU for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 18:21:14 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 35db3013-48de-43b5-bb78-1dcfefbaff42; Tue, 09 Mar 2021 18:21:14 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DACA331B; Tue, 9 Mar 2021 10:21:13 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D84C03F73C; Tue, 9 Mar 2021 10:21:12 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35db3013-48de-43b5-bb78-1dcfefbaff42 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 2/5] xen/arm: smmuv1: Consolidate stream map entry state Date: Tue, 9 Mar 2021 18:19:26 +0000 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Backport commit 1f3d5ca43019bff1105838712d55be087d93c0da "iommu/arm-smmu: Consolidate stream map entry state" from the Linux kernel. This patch is the preparatory work to fix the stream match conflict when two devices have the same stream-id. Original commit message: In order to consider SMR masking, we really want to be able to validate ID/mask pairs against existing SMR contents to prevent stream match conflicts, which at best would cause transactions to fault unexpectedly, and at worst lead to silent unpredictable behaviour. With our SMMU instance data holding only an allocator bitmap, and the SMR values themselves scattered across master configs hanging off devices which we may have no way of finding, there's essentially no way short of digging everything back out of the hardware. Similarly, the thought of power management ops to support suspend/resume faces the exact same problem. By massaging the software state into a closer shape to the underlying hardware, everything comes together quite nicely; the allocator and the high-level view of the data become a single centralised state which we can easily keep track of, and to which any updates can be validated in full before being synchronised to the hardware itself. Signed-off-by: Rahul Singh --- xen/drivers/passthrough/arm/smmu.c | 138 +++++++++++++++++------------ 1 file changed, 79 insertions(+), 59 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index adfab8ee84..c41e94f836 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -308,9 +308,6 @@ static struct iommu_group *iommu_group_get(struct device *dev) /* Maximum number of context banks per SMMU */ #define ARM_SMMU_MAX_CBS 128 -/* Maximum number of mapping groups per SMMU */ -#define ARM_SMMU_MAX_SMRS 128 - /* SMMU global address space */ #define ARM_SMMU_GR0(smmu) ((smmu)->base) #define ARM_SMMU_GR1(smmu) ((smmu)->base + (1 << (smmu)->pgshift)) @@ -589,16 +586,17 @@ enum arm_smmu_arch_version { }; struct arm_smmu_smr { - u8 idx; u16 mask; u16 id; + bool valid; }; struct arm_smmu_master_cfg { int num_streamids; u16 streamids[MAX_MASTER_STREAMIDS]; - struct arm_smmu_smr *smrs; + s16 smendx[MAX_MASTER_STREAMIDS]; }; +#define INVALID_SMENDX -1 struct arm_smmu_master { struct device_node *of_node; @@ -632,7 +630,7 @@ struct arm_smmu_device { u32 num_mapping_groups; u16 streamid_mask; u16 smr_mask_mask; - DECLARE_BITMAP(smr_map, ARM_SMMU_MAX_SMRS); + struct arm_smmu_smr *smrs; unsigned long s1_input_size; unsigned long s1_output_size; @@ -818,6 +816,7 @@ static int register_smmu_master(struct arm_smmu_device *smmu, return -ERANGE; } master->cfg.streamids[i] = streamid; + master->cfg.smendx[i] = INVALID_SMENDX; } return insert_smmu_master(smmu, master); } @@ -1384,79 +1383,91 @@ static void arm_smmu_domain_destroy(struct iommu_domain *domain) kfree(smmu_domain); } -static int arm_smmu_master_configure_smrs(struct arm_smmu_device *smmu, - struct arm_smmu_master_cfg *cfg) +static int arm_smmu_alloc_smr(struct arm_smmu_device *smmu) { int i; - struct arm_smmu_smr *smrs; - void __iomem *gr0_base = ARM_SMMU_GR0(smmu); - if (!(smmu->features & ARM_SMMU_FEAT_STREAM_MATCH)) - return 0; + for (i = 0; i < smmu->num_mapping_groups; i++) + if (!cmpxchg(&smmu->smrs[i].valid, false, true)) + return i; - if (cfg->smrs) - return -EEXIST; + return INVALID_SMENDX; +} - smrs = kmalloc_array(cfg->num_streamids, sizeof(*smrs), GFP_KERNEL); - if (!smrs) { - dev_err(smmu->dev, "failed to allocate %d SMRs\n", - cfg->num_streamids); - return -ENOMEM; - } +static void arm_smmu_free_smr(struct arm_smmu_device *smmu, int idx) +{ + writel_relaxed(~SMR_VALID, ARM_SMMU_GR0(smmu) + ARM_SMMU_GR0_SMR(idx)); + write_atomic(&smmu->smrs[idx].valid, false); +} + +static void arm_smmu_write_smr(struct arm_smmu_device *smmu, int idx) +{ + struct arm_smmu_smr *smr = smmu->smrs + idx; + u32 reg = (smr->id & smmu->streamid_mask) << SMR_ID_SHIFT | + (smr->mask & smmu->smr_mask_mask) << SMR_MASK_SHIFT; + + if (smr->valid) + reg |= SMR_VALID; + writel_relaxed(reg, ARM_SMMU_GR0(smmu) + ARM_SMMU_GR0_SMR(idx)); +} + +static int arm_smmu_master_alloc_smes(struct arm_smmu_device *smmu, + struct arm_smmu_master_cfg *cfg) +{ + struct arm_smmu_smr *smrs = smmu->smrs; + int i, idx; /* Allocate the SMRs on the SMMU */ for (i = 0; i < cfg->num_streamids; ++i) { - int idx = __arm_smmu_alloc_bitmap(smmu->smr_map, 0, - smmu->num_mapping_groups); + if (cfg->smendx[i] != INVALID_SMENDX) + return -EEXIST; + + /* ...except on stream indexing hardware, of course */ + if (!smrs) { + cfg->smendx[i] = cfg->streamids[i]; + continue; + } + + idx = arm_smmu_alloc_smr(smmu); if (IS_ERR_VALUE(idx)) { dev_err(smmu->dev, "failed to allocate free SMR\n"); goto err_free_smrs; } + cfg->smendx[i] = idx; - smrs[i] = (struct arm_smmu_smr) { - .idx = idx, - .mask = 0, /* We don't currently share SMRs */ - .id = cfg->streamids[i], - }; + smrs[idx].id = cfg->streamids[i]; + smrs[idx].mask = 0; /* We don't currently share SMRs */ } + if (!smrs) + return 0; + /* It worked! Now, poke the actual hardware */ - for (i = 0; i < cfg->num_streamids; ++i) { - u32 reg = SMR_VALID | smrs[i].id << SMR_ID_SHIFT | - smrs[i].mask << SMR_MASK_SHIFT; - writel_relaxed(reg, gr0_base + ARM_SMMU_GR0_SMR(smrs[i].idx)); - } + for (i = 0; i < cfg->num_streamids; ++i) + arm_smmu_write_smr(smmu, cfg->smendx[i]); - cfg->smrs = smrs; return 0; err_free_smrs: - while (--i >= 0) - __arm_smmu_free_bitmap(smmu->smr_map, smrs[i].idx); - kfree(smrs); + while (i--) { + arm_smmu_free_smr(smmu, cfg->smendx[i]); + cfg->smendx[i] = INVALID_SMENDX; + } return -ENOSPC; } -static void arm_smmu_master_free_smrs(struct arm_smmu_device *smmu, +static void arm_smmu_master_free_smes(struct arm_smmu_device *smmu, struct arm_smmu_master_cfg *cfg) { int i; - void __iomem *gr0_base = ARM_SMMU_GR0(smmu); - struct arm_smmu_smr *smrs = cfg->smrs; - - if (!smrs) - return; /* Invalidate the SMRs before freeing back to the allocator */ for (i = 0; i < cfg->num_streamids; ++i) { - u8 idx = smrs[i].idx; + if (smmu->smrs) + arm_smmu_free_smr(smmu, cfg->smendx[i]); - writel_relaxed(~SMR_VALID, gr0_base + ARM_SMMU_GR0_SMR(idx)); - __arm_smmu_free_bitmap(smmu->smr_map, idx); + cfg->smendx[i] = INVALID_SMENDX; } - - cfg->smrs = NULL; - kfree(smrs); } static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain, @@ -1467,14 +1478,14 @@ static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain, void __iomem *gr0_base = ARM_SMMU_GR0(smmu); /* Devices in an IOMMU group may already be configured */ - ret = arm_smmu_master_configure_smrs(smmu, cfg); + ret = arm_smmu_master_alloc_smes(smmu, cfg); if (ret) return ret == -EEXIST ? 0 : ret; for (i = 0; i < cfg->num_streamids; ++i) { u32 idx, s2cr; - idx = cfg->smrs ? cfg->smrs[i].idx : cfg->streamids[i]; + idx = cfg->smendx[i]; s2cr = S2CR_TYPE_TRANS | (smmu_domain->cfg.cbndx << S2CR_CBNDX_SHIFT); writel_relaxed(s2cr, gr0_base + ARM_SMMU_GR0_S2CR(idx)); @@ -1490,23 +1501,23 @@ static void arm_smmu_domain_remove_master(struct arm_smmu_domain *smmu_domain, struct arm_smmu_device *smmu = smmu_domain->smmu; void __iomem *gr0_base = ARM_SMMU_GR0(smmu); - /* An IOMMU group is torn down by the first device to be removed */ - if ((smmu->features & ARM_SMMU_FEAT_STREAM_MATCH) && !cfg->smrs) - return; - /* * We *must* clear the S2CR first, because freeing the SMR means * that it can be re-allocated immediately. * Xen: Unlike Linux, any access to non-configured stream will fault. */ for (i = 0; i < cfg->num_streamids; ++i) { - u32 idx = cfg->smrs ? cfg->smrs[i].idx : cfg->streamids[i]; + int idx = cfg->smendx[i]; + + /* An IOMMU group is torn down by the first device to be removed */ + if (idx == INVALID_SMENDX) + return; writel_relaxed(S2CR_TYPE_FAULT, gr0_base + ARM_SMMU_GR0_S2CR(idx)); } - arm_smmu_master_free_smrs(smmu, cfg); + arm_smmu_master_free_smes(smmu, cfg); } static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) @@ -2017,16 +2028,20 @@ static void arm_smmu_device_reset(struct arm_smmu_device *smmu) { void __iomem *gr0_base = ARM_SMMU_GR0(smmu); void __iomem *cb_base; - int i = 0; + int i; u32 reg; /* clear global FSR */ reg = readl_relaxed(ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sGFSR); writel(reg, ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sGFSR); - /* Mark all SMRn as invalid and all S2CRn as bypass */ + /* + * Reset stream mapping groups: Initial values mark all SMRn as + * invalid and all S2CRn as bypass unless overridden. + */ for (i = 0; i < smmu->num_mapping_groups; ++i) { - writel_relaxed(0, gr0_base + ARM_SMMU_GR0_SMR(i)); + if (smmu->smrs) + arm_smmu_write_smr(smmu, i); /* * Xen: Unlike Linux, any access to a non-configure stream * will fault by default. @@ -2169,6 +2184,11 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu) smr = readl_relaxed(gr0_base + ARM_SMMU_GR0_SMR(0)); smmu->smr_mask_mask = smr >> SMR_MASK_SHIFT; + /* Zero-initialised to mark as invalid */ + smmu->smrs = devm_kzalloc(smmu->dev, sizeof(*smmu->smrs), GFP_KERNEL); + if (!smmu->smrs) + return -ENOMEM; + dev_notice(smmu->dev, "\tstream matching with %lu register groups, mask 0x%x", size, smmu->smr_mask_mask); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 18:22:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 18:22:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95669.180629 (Exim 4.92) (envelope-from ) id 1lJgzb-0000Ud-3X; Tue, 09 Mar 2021 18:22:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95669.180629; Tue, 09 Mar 2021 18:22:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJgza-0000UW-WE; Tue, 09 Mar 2021 18:22:03 +0000 Received: by outflank-mailman (input) for mailman id 95669; Tue, 09 Mar 2021 18:22:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJgzZ-0000UK-65 for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 18:22:01 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id cc954cf3-1bab-4721-a5c4-6f51a19f6ae5; Tue, 09 Mar 2021 18:21:59 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1CAD531B; Tue, 9 Mar 2021 10:21:59 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 334BC3F73C; Tue, 9 Mar 2021 10:21:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc954cf3-1bab-4721-a5c4-6f51a19f6ae5 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 3/5] xen/arm: smmuv1: Keep track of S2CR state Date: Tue, 9 Mar 2021 18:19:27 +0000 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Backport commit 8e8b203eabd8b9e96d02d6339e4abce3e5a7ea4b "iommu/arm-smmu: Keep track of S2CR state" from the Linux kernel. This patch is the preparatory work to fix the stream match conflict when two devices have the same stream-id. Original commit message: Making S2CRs first-class citizens within the driver with a high-level representation of their state offers a neat solution to a few problems: Firstly, the information about which context a device's stream IDs are associated with is already present by necessity in the S2CR. With that state easily accessible we can refer directly to it and obviate the need to track an IOMMU domain in each device's archdata (its earlier purpose of enforcing correct attachment of multi-device groups now being handled by the IOMMU core itself). Secondly, the core API now deprecates explicit domain detach and expects domain attach to move devices smoothly from one domain to another; for SMMUv2, this notion maps directly to simply rewriting the S2CRs assigned to the device. By giving the driver a suitable abstraction of those S2CRs to work with, we can massively reduce the overhead of the current heavy-handed "detach, free resources, reallocate resources, attach" approach. Thirdly, making the software state hardware-shaped and attached to the SMMU instance once again makes suspend/resume of this register group that much simpler to implement in future. Signed-off-by: Rahul Singh --- xen/drivers/passthrough/arm/smmu.c | 150 +++++++++++++++++------------ 1 file changed, 89 insertions(+), 61 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index c41e94f836..e1b937bd4b 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -444,9 +444,20 @@ static struct iommu_group *iommu_group_get(struct device *dev) #define S2CR_CBNDX_MASK 0xff #define S2CR_TYPE_SHIFT 16 #define S2CR_TYPE_MASK 0x3 -#define S2CR_TYPE_TRANS (0 << S2CR_TYPE_SHIFT) -#define S2CR_TYPE_BYPASS (1 << S2CR_TYPE_SHIFT) -#define S2CR_TYPE_FAULT (2 << S2CR_TYPE_SHIFT) +enum arm_smmu_s2cr_type { + S2CR_TYPE_TRANS, + S2CR_TYPE_BYPASS, + S2CR_TYPE_FAULT, +}; + +#define S2CR_PRIVCFG_SHIFT 24 +#define S2CR_PRIVCFG_MASK 0x3 +enum arm_smmu_s2cr_privcfg { + S2CR_PRIVCFG_DEFAULT, + S2CR_PRIVCFG_DIPAN, + S2CR_PRIVCFG_UNPRIV, + S2CR_PRIVCFG_PRIV, +}; /* Context bank attribute registers */ #define ARM_SMMU_GR1_CBAR(n) (0x0 + ((n) << 2)) @@ -585,6 +596,16 @@ enum arm_smmu_arch_version { ARM_SMMU_V2, }; +struct arm_smmu_s2cr { + enum arm_smmu_s2cr_type type; + enum arm_smmu_s2cr_privcfg privcfg; + u8 cbndx; +}; + +#define s2cr_init_val (struct arm_smmu_s2cr){ \ + .type = S2CR_TYPE_FAULT \ +} + struct arm_smmu_smr { u16 mask; u16 id; @@ -631,6 +652,7 @@ struct arm_smmu_device { u16 streamid_mask; u16 smr_mask_mask; struct arm_smmu_smr *smrs; + struct arm_smmu_s2cr *s2crs; unsigned long s1_input_size; unsigned long s1_output_size; @@ -1411,6 +1433,23 @@ static void arm_smmu_write_smr(struct arm_smmu_device *smmu, int idx) writel_relaxed(reg, ARM_SMMU_GR0(smmu) + ARM_SMMU_GR0_SMR(idx)); } +static void arm_smmu_write_s2cr(struct arm_smmu_device *smmu, int idx) +{ + struct arm_smmu_s2cr *s2cr = smmu->s2crs + idx; + u32 reg = (s2cr->type & S2CR_TYPE_MASK) << S2CR_TYPE_SHIFT | + (s2cr->cbndx & S2CR_CBNDX_MASK) << S2CR_CBNDX_SHIFT | + (s2cr->privcfg & S2CR_PRIVCFG_MASK) << S2CR_PRIVCFG_SHIFT; + + writel_relaxed(reg, ARM_SMMU_GR0(smmu) + ARM_SMMU_GR0_S2CR(idx)); +} + +static void arm_smmu_write_sme(struct arm_smmu_device *smmu, int idx) +{ + arm_smmu_write_s2cr(smmu, idx); + if (smmu->smrs) + arm_smmu_write_smr(smmu, idx); +} + static int arm_smmu_master_alloc_smes(struct arm_smmu_device *smmu, struct arm_smmu_master_cfg *cfg) { @@ -1461,6 +1500,23 @@ static void arm_smmu_master_free_smes(struct arm_smmu_device *smmu, { int i; + /* + * We *must* clear the S2CR first, because freeing the SMR means + * that it can be re-allocated immediately. + */ + for (i = 0; i < cfg->num_streamids; ++i) { + int idx = cfg->smendx[i]; + + /* An IOMMU group is torn down by the first device to be removed */ + if (idx == INVALID_SMENDX) + return; + + smmu->s2crs[idx] = s2cr_init_val; + arm_smmu_write_s2cr(smmu, idx); + } + /* Sync S2CR updates before touching anything else */ + __iowmb(); + /* Invalidate the SMRs before freeing back to the allocator */ for (i = 0; i < cfg->num_streamids; ++i) { if (smmu->smrs) @@ -1473,51 +1529,30 @@ static void arm_smmu_master_free_smes(struct arm_smmu_device *smmu, static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain, struct arm_smmu_master_cfg *cfg) { - int i, ret; + int i, ret = 0; struct arm_smmu_device *smmu = smmu_domain->smmu; - void __iomem *gr0_base = ARM_SMMU_GR0(smmu); + struct arm_smmu_s2cr *s2cr = smmu->s2crs; + enum arm_smmu_s2cr_type type = S2CR_TYPE_TRANS; + u8 cbndx = smmu_domain->cfg.cbndx; - /* Devices in an IOMMU group may already be configured */ - ret = arm_smmu_master_alloc_smes(smmu, cfg); + if (cfg->smendx[0] == INVALID_SMENDX) + ret = arm_smmu_master_alloc_smes(smmu, cfg); if (ret) - return ret == -EEXIST ? 0 : ret; - - for (i = 0; i < cfg->num_streamids; ++i) { - u32 idx, s2cr; - - idx = cfg->smendx[i]; - s2cr = S2CR_TYPE_TRANS | - (smmu_domain->cfg.cbndx << S2CR_CBNDX_SHIFT); - writel_relaxed(s2cr, gr0_base + ARM_SMMU_GR0_S2CR(idx)); - } - - return 0; -} - -static void arm_smmu_domain_remove_master(struct arm_smmu_domain *smmu_domain, - struct arm_smmu_master_cfg *cfg) -{ - int i; - struct arm_smmu_device *smmu = smmu_domain->smmu; - void __iomem *gr0_base = ARM_SMMU_GR0(smmu); + return ret; - /* - * We *must* clear the S2CR first, because freeing the SMR means - * that it can be re-allocated immediately. - * Xen: Unlike Linux, any access to non-configured stream will fault. - */ for (i = 0; i < cfg->num_streamids; ++i) { int idx = cfg->smendx[i]; - /* An IOMMU group is torn down by the first device to be removed */ - if (idx == INVALID_SMENDX) - return; + /* Devices in an IOMMU group may already be configured */ + if (type == s2cr[idx].type && cbndx == s2cr[idx].cbndx) + break; - writel_relaxed(S2CR_TYPE_FAULT, - gr0_base + ARM_SMMU_GR0_S2CR(idx)); + s2cr[idx].type = type ; + s2cr[idx].privcfg = S2CR_PRIVCFG_UNPRIV; + s2cr[idx].cbndx = cbndx; + arm_smmu_write_s2cr(smmu, idx); } - - arm_smmu_master_free_smes(smmu, cfg); + return 0; } static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) @@ -1564,24 +1599,17 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) if (!cfg) return -ENODEV; - ret = arm_smmu_domain_add_master(smmu_domain, cfg); - - if (!ret) - dev_iommu_domain(dev) = domain; - return ret; + return arm_smmu_domain_add_master(smmu_domain, cfg); } static void arm_smmu_detach_dev(struct iommu_domain *domain, struct device *dev) { - struct arm_smmu_domain *smmu_domain = domain->priv; - struct arm_smmu_master_cfg *cfg; + struct arm_smmu_device *smmu = find_smmu_for_device(dev); + struct arm_smmu_master_cfg *cfg = find_smmu_master_cfg(dev); - cfg = find_smmu_master_cfg(dev); - if (!cfg) - return; + if (smmu && cfg) + arm_smmu_master_free_smes(smmu, cfg); - dev_iommu_domain(dev) = NULL; - arm_smmu_domain_remove_master(smmu_domain, cfg); } #if 0 /* @@ -2039,16 +2067,8 @@ static void arm_smmu_device_reset(struct arm_smmu_device *smmu) * Reset stream mapping groups: Initial values mark all SMRn as * invalid and all S2CRn as bypass unless overridden. */ - for (i = 0; i < smmu->num_mapping_groups; ++i) { - if (smmu->smrs) - arm_smmu_write_smr(smmu, i); - /* - * Xen: Unlike Linux, any access to a non-configure stream - * will fault by default. - */ - writel_relaxed(S2CR_TYPE_FAULT, - gr0_base + ARM_SMMU_GR0_S2CR(i)); - } + for (i = 0; i < smmu->num_mapping_groups; ++i) + arm_smmu_write_sme(smmu, i); /* Make sure all context banks are disabled and clear CB_FSR */ for (i = 0; i < smmu->num_context_banks; ++i) { @@ -2110,6 +2130,7 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu) unsigned long size; void __iomem *gr0_base = ARM_SMMU_GR0(smmu); u32 id; + int i; dev_notice(smmu->dev, "probing hardware configuration...\n"); dev_notice(smmu->dev, "SMMUv%d with:\n", smmu->version); @@ -2193,6 +2214,13 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu) "\tstream matching with %lu register groups, mask 0x%x", size, smmu->smr_mask_mask); } + /* s2cr->type == 0 means translation, so initialise explicitly */ + smmu->s2crs = kmalloc_array(size, sizeof(*smmu->s2crs), GFP_KERNEL); + if (!smmu->s2crs) + return -ENOMEM; + for (i = 0; i < size; i++) + smmu->s2crs[i] = s2cr_init_val; + smmu->num_mapping_groups = size; /* ID1 */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 18:22:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 18:22:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95671.180641 (Exim 4.92) (envelope-from ) id 1lJgzv-0000bA-GW; Tue, 09 Mar 2021 18:22:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95671.180641; Tue, 09 Mar 2021 18:22:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJgzv-0000b3-Cj; Tue, 09 Mar 2021 18:22:23 +0000 Received: by outflank-mailman (input) for mailman id 95671; Tue, 09 Mar 2021 18:22:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJgzt-0000af-Sv for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 18:22:21 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 2623d154-ee50-4e79-a823-a4d8eb42ce1c; Tue, 09 Mar 2021 18:22:20 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6030031B; Tue, 9 Mar 2021 10:22:20 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 251ED3F73C; Tue, 9 Mar 2021 10:22:19 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2623d154-ee50-4e79-a823-a4d8eb42ce1c From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 4/5] xen/arm: smmuv1: Add a stream map entry iterator Date: Tue, 9 Mar 2021 18:19:28 +0000 Message-Id: <51cb16f9bc937b647e73189dc16e94a6e71b679c.1615312254.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Backport commit d3097e39302083d58922a3d1032d7d59a63d263d "iommu/arm-smmu: Add a stream map entry iterator" from the Linux kernel. This patch is the preparatory work to fix the stream match conflict when two devices have the same stream-id. Original commit message: We iterate over the SMEs associated with a master config quite a lot in various places, and are about to do so even more. Let's wrap the idiom in a handy iterator macro before the repetition gets out of hand. Signed-off-by: Rahul Singh --- xen/drivers/passthrough/arm/smmu.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index e1b937bd4b..2c1ea8e6ff 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -618,6 +618,8 @@ struct arm_smmu_master_cfg { s16 smendx[MAX_MASTER_STREAMIDS]; }; #define INVALID_SMENDX -1 +#define for_each_cfg_sme(cfg, i, idx) \ + for (i = 0; idx = cfg->smendx[i], i < cfg->num_streamids; ++i) struct arm_smmu_master { struct device_node *of_node; @@ -1457,8 +1459,8 @@ static int arm_smmu_master_alloc_smes(struct arm_smmu_device *smmu, int i, idx; /* Allocate the SMRs on the SMMU */ - for (i = 0; i < cfg->num_streamids; ++i) { - if (cfg->smendx[i] != INVALID_SMENDX) + for_each_cfg_sme(cfg, i, idx) { + if (idx != INVALID_SMENDX) return -EEXIST; /* ...except on stream indexing hardware, of course */ @@ -1482,8 +1484,8 @@ static int arm_smmu_master_alloc_smes(struct arm_smmu_device *smmu, return 0; /* It worked! Now, poke the actual hardware */ - for (i = 0; i < cfg->num_streamids; ++i) - arm_smmu_write_smr(smmu, cfg->smendx[i]); + for_each_cfg_sme(cfg, i, idx) + arm_smmu_write_smr(smmu, idx); return 0; @@ -1498,15 +1500,13 @@ err_free_smrs: static void arm_smmu_master_free_smes(struct arm_smmu_device *smmu, struct arm_smmu_master_cfg *cfg) { - int i; + int i, idx; /* * We *must* clear the S2CR first, because freeing the SMR means * that it can be re-allocated immediately. */ - for (i = 0; i < cfg->num_streamids; ++i) { - int idx = cfg->smendx[i]; - + for_each_cfg_sme(cfg, i, idx) { /* An IOMMU group is torn down by the first device to be removed */ if (idx == INVALID_SMENDX) return; @@ -1518,9 +1518,9 @@ static void arm_smmu_master_free_smes(struct arm_smmu_device *smmu, __iowmb(); /* Invalidate the SMRs before freeing back to the allocator */ - for (i = 0; i < cfg->num_streamids; ++i) { + for_each_cfg_sme(cfg, i, idx) { if (smmu->smrs) - arm_smmu_free_smr(smmu, cfg->smendx[i]); + arm_smmu_free_smr(smmu, idx); cfg->smendx[i] = INVALID_SMENDX; } @@ -1529,7 +1529,7 @@ static void arm_smmu_master_free_smes(struct arm_smmu_device *smmu, static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain, struct arm_smmu_master_cfg *cfg) { - int i, ret = 0; + int i, idx, ret = 0; struct arm_smmu_device *smmu = smmu_domain->smmu; struct arm_smmu_s2cr *s2cr = smmu->s2crs; enum arm_smmu_s2cr_type type = S2CR_TYPE_TRANS; @@ -1540,9 +1540,7 @@ static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain, if (ret) return ret; - for (i = 0; i < cfg->num_streamids; ++i) { - int idx = cfg->smendx[i]; - + for_each_cfg_sme(cfg, i, idx) { /* Devices in an IOMMU group may already be configured */ if (type == s2cr[idx].type && cbndx == s2cr[idx].cbndx) break; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 18:22:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 18:22:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95678.180652 (Exim 4.92) (envelope-from ) id 1lJh0I-0000hk-PL; Tue, 09 Mar 2021 18:22:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95678.180652; Tue, 09 Mar 2021 18:22:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJh0I-0000hd-M7; Tue, 09 Mar 2021 18:22:46 +0000 Received: by outflank-mailman (input) for mailman id 95678; Tue, 09 Mar 2021 18:22:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJh0H-0000d8-NR for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 18:22:45 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 8fe18c09-db14-4369-aa41-3dd54941ea8e; Tue, 09 Mar 2021 18:22:42 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DD40F31B; Tue, 9 Mar 2021 10:22:41 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 008173F73C; Tue, 9 Mar 2021 10:22:40 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8fe18c09-db14-4369-aa41-3dd54941ea8e From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 5/5] xen/arm: smmuv1: Intelligent SMR allocation Date: Tue, 9 Mar 2021 18:19:29 +0000 Message-Id: <789abfb57568dcbaba122ea9b68c627e6c9707c4.1615312254.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Backport 588888a7399db352d2b1a41c9d5b3bf0fd482390 "iommu/arm-smmu: Intelligent SMR allocation" from the Linux kernel This patch fix the stream match conflict issue when two devices have the same stream-id. Only difference while applying this patch is to use spinlock in place of mutex and move iommu_group_alloc(..) function call in arm_smmu_add_device(..) function from the start of the function to the end. Original commit message: Stream Match Registers are one of the more awkward parts of the SMMUv2 architecture; there are typically never enough to assign one to each stream ID in the system, and configuring them such that a single ID matches multiple entries is catastrophically bad - at best, every transaction raises a global fault; at worst, they go *somewhere*. To address the former issue, we can mask ID bits such that a single register may be used to match multiple IDs belonging to the same device or group, but doing so also heightens the risk of the latter problem (which can be nasty to debug). Tackle both problems at once by replacing the simple bitmap allocator with something much cleverer. Now that we have convenient in-memory representations of the stream mapping table, it becomes straightforward to properly validate new SMR entries against the current state, opening the door to arbitrary masking and SMR sharing. Another feature which falls out of this is that with IDs shared by separate devices being automatically accounted for, simply associating a group pointer with the S2CR offers appropriate group allocation almost for free, so hook that up in the process. Signed-off-by: Rahul Singh --- xen/drivers/passthrough/arm/smmu.c | 230 ++++++++++++++++++----------- 1 file changed, 142 insertions(+), 88 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 2c1ea8e6ff..20ac672e91 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -597,6 +597,8 @@ enum arm_smmu_arch_version { }; struct arm_smmu_s2cr { + struct iommu_group *group; + int count; enum arm_smmu_s2cr_type type; enum arm_smmu_s2cr_privcfg privcfg; u8 cbndx; @@ -613,6 +615,7 @@ struct arm_smmu_smr { }; struct arm_smmu_master_cfg { + struct arm_smmu_device *smmu; int num_streamids; u16 streamids[MAX_MASTER_STREAMIDS]; s16 smendx[MAX_MASTER_STREAMIDS]; @@ -655,6 +658,7 @@ struct arm_smmu_device { u16 smr_mask_mask; struct arm_smmu_smr *smrs; struct arm_smmu_s2cr *s2crs; + spinlock_t stream_map_lock; unsigned long s1_input_size; unsigned long s1_output_size; @@ -1407,23 +1411,6 @@ static void arm_smmu_domain_destroy(struct iommu_domain *domain) kfree(smmu_domain); } -static int arm_smmu_alloc_smr(struct arm_smmu_device *smmu) -{ - int i; - - for (i = 0; i < smmu->num_mapping_groups; i++) - if (!cmpxchg(&smmu->smrs[i].valid, false, true)) - return i; - - return INVALID_SMENDX; -} - -static void arm_smmu_free_smr(struct arm_smmu_device *smmu, int idx) -{ - writel_relaxed(~SMR_VALID, ARM_SMMU_GR0(smmu) + ARM_SMMU_GR0_SMR(idx)); - write_atomic(&smmu->smrs[idx].valid, false); -} - static void arm_smmu_write_smr(struct arm_smmu_device *smmu, int idx) { struct arm_smmu_smr *smr = smmu->smrs + idx; @@ -1452,98 +1439,143 @@ static void arm_smmu_write_sme(struct arm_smmu_device *smmu, int idx) arm_smmu_write_smr(smmu, idx); } -static int arm_smmu_master_alloc_smes(struct arm_smmu_device *smmu, - struct arm_smmu_master_cfg *cfg) +static int arm_smmu_find_sme(struct arm_smmu_device *smmu, u16 id, u16 mask) { struct arm_smmu_smr *smrs = smmu->smrs; - int i, idx; + int i, free_idx = -ENOSPC; - /* Allocate the SMRs on the SMMU */ - for_each_cfg_sme(cfg, i, idx) { - if (idx != INVALID_SMENDX) - return -EEXIST; + /* Stream indexing is blissfully easy */ + if (!smrs) + return id; - /* ...except on stream indexing hardware, of course */ - if (!smrs) { - cfg->smendx[i] = cfg->streamids[i]; + /* Validating SMRs is... less so */ + for (i = 0; i < smmu->num_mapping_groups; ++i) { + if (!smrs[i].valid) { + /* + * Note the first free entry we come across, which + * we'll claim in the end if nothing else matches. + */ + if (free_idx < 0) + free_idx = i; continue; } + /* + * If the new entry is _entirely_ matched by an existing entry, + * then reuse that, with the guarantee that there also cannot + * be any subsequent conflicting entries. In normal use we'd + * expect simply identical entries for this case, but there's + * no harm in accommodating the generalisation. + */ + if ((mask & smrs[i].mask) == mask && + !((id ^ smrs[i].id) & ~smrs[i].mask)) + return i; + /* + * If the new entry has any other overlap with an existing one, + * though, then there always exists at least one stream ID + * which would cause a conflict, and we can't allow that risk. + */ + if (!((id ^ smrs[i].id) & ~(smrs[i].mask | mask))) + return -EINVAL; + } - idx = arm_smmu_alloc_smr(smmu); - if (IS_ERR_VALUE(idx)) { - dev_err(smmu->dev, "failed to allocate free SMR\n"); - goto err_free_smrs; + return free_idx; +} + +static bool arm_smmu_free_sme(struct arm_smmu_device *smmu, int idx) +{ + if (--smmu->s2crs[idx].count) + return false; + + smmu->s2crs[idx] = s2cr_init_val; + if (smmu->smrs) + smmu->smrs[idx].valid = false; + + return true; +} + +static int arm_smmu_master_alloc_smes(struct device *dev) +{ + struct arm_smmu_master_cfg *cfg = find_smmu_master_cfg(dev); + struct arm_smmu_device *smmu = cfg->smmu; + struct arm_smmu_smr *smrs = smmu->smrs; + struct iommu_group *group; + int i, idx, ret; + + spin_lock(&smmu->stream_map_lock); + /* Figure out a viable stream map entry allocation */ + for_each_cfg_sme(cfg, i, idx) { + if (idx != INVALID_SMENDX) { + ret = -EEXIST; + goto out_err; } - cfg->smendx[i] = idx; - smrs[idx].id = cfg->streamids[i]; - smrs[idx].mask = 0; /* We don't currently share SMRs */ + ret = arm_smmu_find_sme(smmu, cfg->streamids[i], 0); + if (ret < 0) + goto out_err; + + idx = ret; + if (smrs && smmu->s2crs[idx].count == 0) { + smrs[idx].id = cfg->streamids[i]; + smrs[idx].mask = 0; /* We don't currently share SMRs */ + smrs[idx].valid = true; + } + smmu->s2crs[idx].count++; + cfg->smendx[i] = (s16)idx; } - if (!smrs) - return 0; + group = iommu_group_get(dev); + if (!group) + group = ERR_PTR(-ENOMEM); + if (IS_ERR(group)) { + ret = PTR_ERR(group); + goto out_err; + } + iommu_group_put(group); /* It worked! Now, poke the actual hardware */ - for_each_cfg_sme(cfg, i, idx) - arm_smmu_write_smr(smmu, idx); + for_each_cfg_sme(cfg, i, idx) { + arm_smmu_write_sme(smmu, idx); + smmu->s2crs[idx].group = group; + } + spin_unlock(&smmu->stream_map_lock); return 0; -err_free_smrs: +out_err: while (i--) { - arm_smmu_free_smr(smmu, cfg->smendx[i]); + arm_smmu_free_sme(smmu, cfg->smendx[i]); cfg->smendx[i] = INVALID_SMENDX; } - return -ENOSPC; + spin_unlock(&smmu->stream_map_lock); + return ret; } -static void arm_smmu_master_free_smes(struct arm_smmu_device *smmu, - struct arm_smmu_master_cfg *cfg) +static void arm_smmu_master_free_smes(struct arm_smmu_master_cfg *cfg) { + struct arm_smmu_device *smmu = cfg->smmu; int i, idx; - /* - * We *must* clear the S2CR first, because freeing the SMR means - * that it can be re-allocated immediately. - */ + spin_lock(&smmu->stream_map_lock); for_each_cfg_sme(cfg, i, idx) { - /* An IOMMU group is torn down by the first device to be removed */ - if (idx == INVALID_SMENDX) - return; - - smmu->s2crs[idx] = s2cr_init_val; - arm_smmu_write_s2cr(smmu, idx); - } - /* Sync S2CR updates before touching anything else */ - __iowmb(); - - /* Invalidate the SMRs before freeing back to the allocator */ - for_each_cfg_sme(cfg, i, idx) { - if (smmu->smrs) - arm_smmu_free_smr(smmu, idx); - + if (arm_smmu_free_sme(smmu, idx)) + arm_smmu_write_sme(smmu, idx); cfg->smendx[i] = INVALID_SMENDX; } + spin_unlock(&smmu->stream_map_lock); } static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain, struct arm_smmu_master_cfg *cfg) { - int i, idx, ret = 0; struct arm_smmu_device *smmu = smmu_domain->smmu; struct arm_smmu_s2cr *s2cr = smmu->s2crs; enum arm_smmu_s2cr_type type = S2CR_TYPE_TRANS; u8 cbndx = smmu_domain->cfg.cbndx; - - if (cfg->smendx[0] == INVALID_SMENDX) - ret = arm_smmu_master_alloc_smes(smmu, cfg); - if (ret) - return ret; + int i, idx; for_each_cfg_sme(cfg, i, idx) { - /* Devices in an IOMMU group may already be configured */ if (type == s2cr[idx].type && cbndx == s2cr[idx].cbndx) - break; + continue; s2cr[idx].type = type ; s2cr[idx].privcfg = S2CR_PRIVCFG_UNPRIV; @@ -1602,11 +1634,10 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) static void arm_smmu_detach_dev(struct iommu_domain *domain, struct device *dev) { - struct arm_smmu_device *smmu = find_smmu_for_device(dev); struct arm_smmu_master_cfg *cfg = find_smmu_master_cfg(dev); - if (smmu && cfg) - arm_smmu_master_free_smes(smmu, cfg); + if (cfg) + arm_smmu_master_free_smes(cfg); } @@ -1935,31 +1966,44 @@ static void __arm_smmu_release_pci_iommudata(void *data) kfree(data); } +static struct iommu_group *arm_smmu_device_group(struct + arm_smmu_master_cfg *cfg) +{ + struct arm_smmu_device *smmu = cfg->smmu; + struct iommu_group *group = NULL; + int i, idx; + + for_each_cfg_sme(cfg, i, idx) { + if (group && smmu->s2crs[idx].group && + group != smmu->s2crs[idx].group) + return ERR_PTR(-EINVAL); + + group = smmu->s2crs[idx].group; + } + + if (group) + return group; + + return NULL; +} + static int arm_smmu_add_device(struct device *dev) { struct arm_smmu_device *smmu; struct arm_smmu_master_cfg *cfg; struct iommu_group *group; void (*releasefn)(void *) = NULL; - int ret; smmu = find_smmu_for_device(dev); if (!smmu) return -ENODEV; - group = iommu_group_alloc(); - if (IS_ERR(group)) { - dev_err(dev, "Failed to allocate IOMMU group\n"); - return PTR_ERR(group); - } - if (dev_is_pci(dev)) { struct pci_dev *pdev = to_pci_dev(dev); cfg = kzalloc(sizeof(*cfg), GFP_KERNEL); if (!cfg) { - ret = -ENOMEM; - goto out_put_group; + return -ENOMEM; } cfg->num_streamids = 1; @@ -1970,24 +2014,33 @@ static int arm_smmu_add_device(struct device *dev) pci_for_each_dma_alias(pdev, __arm_smmu_get_pci_sid, &cfg->streamids[0]); releasefn = __arm_smmu_release_pci_iommudata; + cfg->smmu = smmu; } else { struct arm_smmu_master *master; master = find_smmu_master(smmu, dev->of_node); if (!master) { - ret = -ENODEV; - goto out_put_group; + return -ENODEV; } cfg = &master->cfg; + cfg->smmu = smmu; } - iommu_group_set_iommudata(group, cfg, releasefn); - ret = iommu_group_add_device(group, dev); + group = arm_smmu_device_group(cfg); + if (!group) { + group = iommu_group_alloc(); + if (IS_ERR(group)) { + dev_err(dev, "Failed to allocate IOMMU group\n"); + return PTR_ERR(group); + } + } -out_put_group: + iommu_group_set_iommudata(group, cfg, releasefn); + iommu_group_add_device(group, dev); iommu_group_put(group); - return ret; + + return arm_smmu_master_alloc_smes(dev); } #if 0 /* Xen: We don't support remove device for now. Will be useful for PCI */ @@ -2220,6 +2273,7 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu) smmu->s2crs[i] = s2cr_init_val; smmu->num_mapping_groups = size; + spin_lock_init(&smmu->stream_map_lock); /* ID1 */ id = readl_relaxed(gr0_base + ARM_SMMU_GR0_ID1); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 18:57:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 18:57:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95711.180679 (Exim 4.92) (envelope-from ) id 1lJhYA-0003ih-OS; Tue, 09 Mar 2021 18:57:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95711.180679; Tue, 09 Mar 2021 18:57:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJhYA-0003ia-L9; Tue, 09 Mar 2021 18:57:46 +0000 Received: by outflank-mailman (input) for mailman id 95711; Tue, 09 Mar 2021 18:57:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJhY8-0003iV-Tq for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 18:57:45 +0000 Received: from mail.skyhub.de (unknown [5.9.137.197]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a8f55fc5-b966-4410-a76c-56c958184c1d; Tue, 09 Mar 2021 18:57:42 +0000 (UTC) Received: from zn.tnic (p200300ec2f0d1e00d0c5a693a55ce411.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:1e00:d0c5:a693:a55c:e411]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 69B591EC0472; Tue, 9 Mar 2021 19:57:41 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8f55fc5-b966-4410-a76c-56c958184c1d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1615316261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=XORSsete5wDAuj0qz8rNhfE7ztUreCnJFjyEgtuEEKM=; b=azPU0PhRnMmVMUehnvtIjy9yn/D1YnQz5gJG/iSyo655LhqKHIlSxCuwCq1j715vh3uovh NFWAIPqleg2xfS2vuxq5ytUA3EO2hDYspG0gNDGondbClyxv39iE018r97NVYuPLrjYwrs 2iCwWZ5mRvfKVA+fNRbyRBboOODaGyY= Date: Tue, 9 Mar 2021 19:57:37 +0100 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini , Peter Zijlstra Subject: Re: [PATCH v6 02/12] x86/paravirt: switch time pvops functions to use static_call() Message-ID: <20210309185737.GE699@zn.tnic> References: <20210309134813.23912-1-jgross@suse.com> <20210309134813.23912-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210309134813.23912-3-jgross@suse.com> On Tue, Mar 09, 2021 at 02:48:03PM +0100, Juergen Gross wrote: > @@ -167,6 +168,17 @@ static u64 native_steal_clock(int cpu) > return 0; > } > > +DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock); > +DEFINE_STATIC_CALL(pv_sched_clock, native_sched_clock); > + > +bool paravirt_using_native_sched_clock = true; > + > +void paravirt_set_sched_clock(u64 (*func)(void)) > +{ > + static_call_update(pv_sched_clock, func); > + paravirt_using_native_sched_clock = (func == native_sched_clock); > +} What's the point of this function if there's a global paravirt_using_native_sched_clock variable now? Looking how the bit of information whether native_sched_clock is used, is needed in tsc.c, it probably would be cleaner if you add a set_sched_clock_native(void); or so, to tsc.c instead and call that here and make that long var name a a shorter and static one in tsc.c instead. Hmm? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Tue Mar 09 19:14:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 19:14:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95720.180691 (Exim 4.92) (envelope-from ) id 1lJhnx-0005Uq-48; Tue, 09 Mar 2021 19:14:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95720.180691; Tue, 09 Mar 2021 19:14:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJhnw-0005Uj-V1; Tue, 09 Mar 2021 19:14:04 +0000 Received: by outflank-mailman (input) for mailman id 95720; Tue, 09 Mar 2021 19:14:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJhnv-0005Ue-J1 for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 19:14:03 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6768ce61-3420-43f4-9c77-f92a8408f2bb; Tue, 09 Mar 2021 19:14:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6768ce61-3420-43f4-9c77-f92a8408f2bb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615317241; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=fBgNYMacj11GtJoYCFbzdu86nNPk6f6rNknw1z05nUw=; b=NwJC/VTFTJiKCyw+33QZVx3/c9Ze0D1COybAX72duVfzsog8XhoaeZJU llNGctISRn5P3mZSydejyig38+VIlFvB4IUFhp9A9UQIUtCt8FjIQ+X9s RVxwGyOi7haiBz7nj/VrD1aEbG6jmXch6f0OYjDzEROh5BrImwnc7rZUX 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: bjq88UMO4fEqz0qyNMaqW6uBk0fQUEXWI/QedXLDZAMuaC3N4O3XII36aoYpD26RqczYEF/GLl dSt9Hi6W+a/PeyIzmv01anGTmC8PGPMBF2+rDdqQcK/mBRzR1xCBDeUq4/uFzZNQacuGd08MKQ XXAaBXPACbWVGf+IDYdIrnugCMKF+dNkhKsgSjL3fNLx5jTkBD51brhLgOKgHSHhlgYzvH7sme htGe5mIh1ArhVaD5OGPuI9Xxc1cbEJ9/EWRUvetfge9He4foRKNU38TP/fE+1hT4n2FlMsJOBc n/4= X-SBRS: 5.2 X-MesageID: 38888634 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,236,1610427600"; d="scan'208";a="38888634" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jPbjplJdwLL8w4B8uJRzEMlWKtmBstzrE98T4fj1l4iZvJh8MJLnB5WParKZpoNBVaVSyQF3cvSocb9yHEXP69KcoVKCTuCHERX1b3pViPg0WpWIgDjJKjk8qqm1Fbt8UWy80aoGuAf1XuxLDyOLsE8V86a5zRaBpacM223wydBK942pXlmbNSx+RFJZhkyPTbumOK0zoBdeIfRCPQtrfsqwlwVe0cPC+C9CGOUM2gags86quq7XZbhghGTNQX1KhL55kFVlEXJpyROjmVPD83rBeBAySlH3KyADE+K011n0OfMOn1vCxQPT3/XmJ6ugTGLqMIVsdDbmvxBW2VizRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JfO6ef3wgV/TbuhMnJL6aV6osA8DxyC8z9uW1C6WK+Y=; b=Hk9J7KovVzqdiGKPl0FSP9vKVw5jmHVm+sXbFi+QXkHz7uZlLEeM2CCPFuW47qLO2B+zwbMUs7bygc5UK4/G8OkewIlqGVtPH0Tz8PQV9VWvm4Cd/hP0+3UDN4QyTFlGjZLp3hy2ReTD+wKW8fDItYhmLPIXuUl72bPy8HuxxQlea1lXHldJRM9tr/WTT7KycJo0xruSeIRWtWut/dYSFvKyr8QXIvYGS3EiMxYuAYWA5dkdA2ICGcUbyivioXC2f0soGLr4H5JCWEGTq3nGBWES1BHdaYeGJPQs0D8U62reKM/M2cZqhawp/w/xIwZQzBcpxeh0TmfuNBKM3/NdDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JfO6ef3wgV/TbuhMnJL6aV6osA8DxyC8z9uW1C6WK+Y=; b=YDmM83v5bzNWrb2gHW2v5Fbv+Zvxpi2d9hU5DgHckwEZyvsx4LJu8OxEAXt/oXxeaBWhLQDVVq5JihtH+Khh4Ud09haZ1g+e8SjE9IfsEshzgUcGNk8gq8xJFxVSDCwEKsrD6uq4Oxlg5oJVJOqJ1JLjDLtU8X6oaGIBCTLHMmE= To: Roger Pau Monne , CC: Ian Jackson , Wei Liu , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky References: <20210309105634.7200-1-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection Message-ID: Date: Tue, 9 Mar 2021 19:13:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210309105634.7200-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0106.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6caac718-e51f-49f2-ec2d-08d8e32f702d X-MS-TrafficTypeDiagnostic: BY5PR03MB5348: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ltjcgwnTRsi3XDjYmK6HE4F/jQiRuce9OefKaXwQm50OHd6znfXmtvDFOgQAMweeGRP6vD1LgqZrdIK3p+fKAImA5bjOXOfuEah6dybkweoFSptqmhzkTiC1pI7kon464/2uyAn2vpxBLufNrUx78gzViJWaIeezOg2O1d8aJoQ6Sp/jLw2Tq75sX39GF81l4TYg0LVAR1XirHVg1QR34f3MN/Nmf+1iFypvaoHIFz7qh8XCqCIYV2Cx/hOTVUOQhp5NJUGsUcaekpSNyScpNAhdN2eokEmOJSUOufjUthmC9ZcaiA7A5O7PqvOr6VyRTU9/ytsThxOpdtvT02o0VLk5FAKAJ/SxG9U17ZmkG2UVkV14O/TAgDcS/309ULqrFwih1uqWxI+tKr4mBsIwZkg36+gHrhrXEZYvsTyM27YFPMX9/aGZ9jxRlbCIfzmKIvHFy+iMfacAyfNXx1ZeA8FaDMQtsoFzQkRJolM4QbWz+RsLehxiNyEwZaBoLIfhhXyqZHi8m5gUnkvIwxYxfImVRNuCk4Myb6RQ/x/FxpNw9IDwm1jknK2hsgpQm2pbWUVKbq+Fwdlmpv/44vmgi79OV16V/T9DFH+lHe/5tYY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(478600001)(53546011)(6666004)(16526019)(26005)(83380400001)(186003)(66476007)(31686004)(2906002)(956004)(2616005)(5660300002)(8676002)(54906003)(36756003)(6486002)(316002)(4326008)(16576012)(7416002)(8936002)(31696002)(66946007)(66556008)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YWNFSlpUYzc2a1JPV1VMRlZNYzVBN3FaQnVrclpJbkZKSzU4bTdTb0UxaWU0?= =?utf-8?B?NVlsVE5Da29oYlpuWTdmUlBwUzRMTll3RTB5Z3FvOTVtaVNQSG84N3FQNEdG?= =?utf-8?B?dzlZb2cwTWlPeDFoUWNrNkJEV2hLY0U5dDF3VTYvL1lFTEp0TEhlbE1DQWdX?= =?utf-8?B?VFdZMFdCcU95S0ltM2l6YkdwSlVmd2N4SjJwYm1IMmUzU216azFqclJWTzR3?= =?utf-8?B?anRTR05pZ3V0SHpNMXYzNURZUHRxZWN2MWw3WmJWWU5Uc0RLaFBGSXVNN3VD?= =?utf-8?B?eitsU1lmV1p1K1JHdTU2SGtYS0Z2T1BDWFlkVmRKRjZ5aWVlV0RpL3pyRk5s?= =?utf-8?B?T3BCMzZOTUltMFV3K05BdVFNbDROUll0ZDJOZFBNekNqTmxSOGFrRXJWc1FR?= =?utf-8?B?VktyTlFRMEU0OURSV1MwQi9ucTE3VXNsWWplY1l6ampuQ3Rwbm1rbDhhSURJ?= =?utf-8?B?QmtMMkU3dWhPVERvYVFiQWhMREZZRUFwQ24zajYzZU5rTkJjWEJ0amRkS2po?= =?utf-8?B?Qy9CZnYyWE16OU8rNDdCRGl4b1VjMnF2TERXUUZsTjVsVkRsNzJ1Q1VPMEVU?= =?utf-8?B?WlltZituSUdqREFxN0pVdlhESmRvbjRnTWFYV2RGUjRVL3BkWldDdGlGK1Np?= =?utf-8?B?VnoyT2NGY0czNmxjYXpoYlc2cWtWZkQ1UlVPU2trd0F1TjlyTTJPT2pmT29z?= =?utf-8?B?czFyS0I1WGJibjk0eUlwUHdmUm9YV0x1TjZnTTB2cmZKN3pLUFQ5ajhTUWJo?= =?utf-8?B?aGhSSWp0cUZwT0grdFc0cWxISWtsWjFpLyt4N2d4WjA4bFErY29HZk5HZC8w?= =?utf-8?B?NGp4bG8zbWcxek52L09MT0VFeGRmV2RWcU00L2JLV1lKQjY3eXNYbnptdlgr?= =?utf-8?B?bThXbE9zZC9lRGMwWm9QMFJ3MTZ0MTVKelBlNmRlNytNZTRsM0U4VFVReXBZ?= =?utf-8?B?OUpobTNGVGZPNGIwaW44eWpDNkd6OU5CWXJ5RU4rOVhSTjZnUndSd1V0WGNF?= =?utf-8?B?d1hkTFZkNmFaVVBEMU5TVjVNRmYwZDRCaWsrd0JqM3pyNGI1SG9aUVB4OXE0?= =?utf-8?B?Z1I4YTh1Ym4zT2h5QVlJSXJYVGdRSWpLbDQ4TnlwYUJkdmNYc0I3MUtCVHc2?= =?utf-8?B?NWVRQkplZGFYK3Jvblk2RU4yc2dQa2hjY2pGTC9Cb21WTTNGc3BoRDVqQk52?= =?utf-8?B?UWEyNnlJTWZUMzVWR2l4eXZtWTA5QWpUREdOckdTelpVQTJsaFBzUE1ZZWJV?= =?utf-8?B?OFR1OVVHM0pVU0JHNkQ1Q2RSUlNBSm5CaTZqMGVkb0VCYzZoUXE0Vk5ZSGxE?= =?utf-8?B?Z0ZZaXdYeWwxTGZobkxrQ0FUcGRTTnRLMTFBeDhrbDYxWVhiRHpxYkFFaEor?= =?utf-8?B?R3hyUjFZTENrNDVBSkpkc3d6UDVST1ZyUThGRVZNMnplLy9uOG8zL1BYRERk?= =?utf-8?B?Z1NyMFRCSTlhWDQxcDZNYjV2dXU0OS92U0V6UXVKT01ZZmdWL0V3YWx3U1lK?= =?utf-8?B?ck0vemJSL0NpdFMycEhRQ1gyaktudU8xSVJMYThhRThvL1VtVnFpdVNBalp6?= =?utf-8?B?Y2lKMVVRajBwYWFVd1BqQXNaNWZaTkxkWGZhSmYxUjV4eS83aFcxZ1IzbDJh?= =?utf-8?B?TDdIUGJ1S3o2WnlKTFR1ZWwyV3l5NU9kdDN1UTVDdkZqTmI4QTZKN0FXbkxx?= =?utf-8?B?NzM1bVNzckRNOUppTVQ3WDV4dzV6QmFyZHVWWmw4QUlsejJtWTU0Vmt2anZ5?= =?utf-8?Q?g9TPuxWUPDX9XbcyNfvUUZHWh9bugBG+EextWAI?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6caac718-e51f-49f2-ec2d-08d8e32f702d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 19:13:36.5906 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E+2ucrpi80eRTqNXSqTVNxWsTaI3EFhElO4C5HnADTMGpuMOZgSjkOMARxAvUnESLQfvcut0oJb3oCdhisZnvpdOzTkOFFAKgcsLVxUDuPo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5348 X-OriginatorOrg: citrix.com On 09/03/2021 10:56, Roger Pau Monne wrote: > Introduce an option to allow selecting a behavior similar to the pre > Xen 4.15 one for accesses to MSRs not explicitly handled. Since commit > 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly > handled by Xen result in the injection of a #GP to the guest. This > is a behavior change since previously a #GP was only injected if > accessing the MSR on the real hardware would also trigger a #GP, or if > the attempted to be set bits wouldn't match the hardware values (for > PV). > > This seems to be problematic for some guests, so introduce an option > to fallback to this kind of legacy behavior without leaking the > underlying MSR values to the guest. > > When the option is set, for both PV and HVM don't inject a #GP to the > guest on MSR read if reading the underlying MSR doesn't result in a > #GP, do the same for writes and simply discard the value to be written > on that case. > > Note that for guests restored or migrated from previous Xen versions > the option is enabled by default, in order to keep a compatible > MSR behavior. Such compatibility is done at the libxl layer, to avoid > higher-level toolstacks from having to know the details about this flag. > > Signed-off-by: Roger Pau Monn=C3=A9 Thankyou for doing this.=C2=A0 By and large, Reviewed-by: Andrew Cooper , subject to some pandoc syntax fixes below. However, I think it is worth saying explicitly that the reasons behind the changes in 84e848fd7a162f669 and 322ec7c89f6640e (not leaking hardware MSRs, and not breaking #GP-probing) are still legitimate, and this influences the change in behaviour between msr_relaxed and 4.14 (i.e. read-as-zero rather than leaking). > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-li= ne.pandoc > index 4737c92bfe..6cf61a5c57 100644 > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -740,7 +740,7 @@ Specify the bit width of the DMA heap. > =20 > ### dom0 > =3D List of [ pv | pvh, shadow=3D, verbose=3D, > - cpuid-faulting=3D ] > + cpuid-faulting=3D, msr-relaxed=3D ] > =20 > Applicability: x86 > =20 > @@ -789,6 +789,21 @@ Controls for how dom0 is constructed on x86 systems. > restore the pre-4.13 behaviour. If specifying `no-cpuid-faulting` f= ixes > an issue in dom0, please report a bug. > =20 > +* msr-relaxed: Select whether to use a relaxed behavior for accesses t= o MSRs > + not explicitly handled by Xen instead of injecting a #GP to dom0. > + Such access mode will force Xen to replicate the behavior from the h= ardware > + it's currently running on in order to decide whether a #GP is inject= ed to > + dom0 for MSR reads. Note that dom0 is never allowed to read the val= ue of > + unhandled MSRs, this option only changes whether a #GP might be inje= cted > + or not. For writes a #GP won't be injected as long as reading the > + underlying MSR doesn't result in a #GP. I don't find this overly clear to follow, and it also misses stating the default explicitly.=C2=A0 How about: ---8<--- The `msr-relaxed` boolean is an interim option, and defaults to false. In Xen 4.15, the default behaviour for unhandled MSRs has been changed, to avoid leaking host data into guests, and to avoid breaking guest logic which uses \#GP probing to identify the availability of MSRs. However, this new stricter behaviour has the possibility to break guests, and a more 4.14-like behaviour can be selected by specifying `dom0=3Dmsr-relaxed`. If using this option is necessary to fix an issue, please report a bug. ---8<--- Other pending Sphinx work is drawing together the "how to contact us" information, so the various "please report a bug"s through this document will turn into links. > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index 23bbb6e8c1..d217c223b0 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -749,6 +749,7 @@ static struct domain *__init create_dom0(const module= _t *image, > .max_grant_frames =3D -1, > .max_maptrack_frames =3D -1, > .max_vcpus =3D dom0_max_vcpus(), > + .arch.domain_flags =3D opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXE= D : 0, Can I request .arch =3D { =C2=A0=C2=A0=C2=A0 .domain_flags =3D opt_dom0_msr_relaxed ? XEN_X86_MSR_REL= AXED : 0, }, please, to reduce the patch complexity of further additions inside .arch. > diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-= x86/xen.h > index 629cb2ba40..f9d0e33b94 100644 > --- a/xen/include/public/arch-x86/xen.h > +++ b/xen/include/public/arch-x86/xen.h > @@ -304,6 +304,14 @@ struct xen_arch_domainconfig { > XEN_X86_EMU_PIT | XEN_X86_EMU_USE_P= IRQ |\ > XEN_X86_EMU_VPCI) > uint32_t emulation_flags; > + > +/* > + * Select whether to use a relaxed behavior for accesses to MSRs not exp= licitly > + * handled by Xen instead of injecting a #GP to the guest. Note this opt= ion > + * doesn't allow the guest to read or write to the underlying MSR. > + */ > +#define XEN_X86_MSR_RELAXED (1u << 0) > + uint32_t domain_flags; The domain prefix is somewhat redundant, given the name of the structure or the hypercall it is used for.=C2=A0 OTOH, 'flags' on its own probably isn't ok.=C2=A0 Thoughts on misc_flags? ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Mar 09 19:21:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 19:21:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95725.180702 (Exim 4.92) (envelope-from ) id 1lJhv6-0006RW-09; Tue, 09 Mar 2021 19:21:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95725.180702; Tue, 09 Mar 2021 19:21:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJhv5-0006RP-TT; Tue, 09 Mar 2021 19:21:27 +0000 Received: by outflank-mailman (input) for mailman id 95725; Tue, 09 Mar 2021 19:21:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJhv4-0006RK-7U for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 19:21:26 +0000 Received: from mail-wm1-f49.google.com (unknown [209.85.128.49]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 95461b36-423c-4b1c-895f-93714183a77a; Tue, 09 Mar 2021 19:21:25 +0000 (UTC) Received: by mail-wm1-f49.google.com with SMTP id w7so3366944wmb.5 for ; Tue, 09 Mar 2021 11:21:25 -0800 (PST) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id g16sm26083731wrs.76.2021.03.09.11.21.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 11:21:23 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95461b36-423c-4b1c-895f-93714183a77a X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=XaUbM1s2vULgWR55ZOqlUQD6eY53ou7f9+9PCI2clD0=; b=ZHIIVrUQf2bDXpWpCAevymRkHkukVyHQQqkhkKjhy3fBtVSXsNxnvsDmngxd3F5lOO d9b4OHSbLS9uuF6HsmYLCSJ6m6a5MKKqgo3h6OiXsOYhU6lfQ1QEJSWGQEv7ZzPe6oca 89ADJcm6EMy+qoHS7YoAsfR/gK/OO9EBs1AW/d9pWr17L17CY2gt6byOooGo0VDqEWfd ys+lM9CSuJuvumOH/+GTkV6Ne+2TkS2Ua1tvWolwmujBrHIM8L7a+nfg1zpYC6D7fVbH URijszW118kr8hBFPDdUJnSa3Z9Qds/yzNfYK2R668X1r1F+tmbgGLIP3S82gmihTz1H i2Vg== X-Gm-Message-State: AOAM530pFuQLXgP6/r+586o2bQs5IxGbV4SOnihEo6mJcvmg+lRDZGRu p2ONkPqZ93p+ye1XZ1ot/6qMqD6GMX8= X-Google-Smtp-Source: ABdhPJybj8KVxHc9eoBHXJBS0OedLKzYeOSpv/dZeMyzxEWyGSuCpemgUjxj7vfSrjCeOmGypsIZmQ== X-Received: by 2002:a05:600c:4f55:: with SMTP id m21mr5688867wmq.11.1615317684275; Tue, 09 Mar 2021 11:21:24 -0800 (PST) Date: Tue, 9 Mar 2021 19:21:22 +0000 From: Wei Liu To: paul@xen.org Cc: xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 1/2] xen-netback: add module parameter to disable ctrl-ring Message-ID: <20210309192122.ym7xwduz4ddauks5@liuwe-devbox-debian-v2> References: <20210225122940.9310-1-andyhsu@amazon.com> <33c5f0f0-0e6e-a42c-46a5-405000715c1c@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <33c5f0f0-0e6e-a42c-46a5-405000715c1c@xen.org> On Tue, Mar 09, 2021 at 02:34:56PM +0000, Paul Durrant wrote: > On 09/03/2021 14:10, Hsu, Chiahao wrote: > > On 25.02.21, 13:29, "Hsu, Chiahao" wrote: > > > > In order to support live migration of guests between kernels > > that do and do not support 'feature-ctrl-ring', we add a > > module parameter that allows the feature to be disabled > > at run time, instead of using hardcode value. > > The default value is enable. > > > > Signed-off-by: ChiaHao Hsu > > You should directly CC maintainers, and also I don't see netdev in the To > list... Did you send it there? I suspect not, since I don't see 'net-next' > in the prefix. I think it would be better to resend this series. See Documentation/networking/netdev-FAQ.rst. Wei. > > Paul From xen-devel-bounces@lists.xenproject.org Tue Mar 09 19:23:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 19:23:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95728.180714 (Exim 4.92) (envelope-from ) id 1lJhwf-0006Zs-Bd; Tue, 09 Mar 2021 19:23:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95728.180714; Tue, 09 Mar 2021 19:23:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJhwf-0006Zl-8D; Tue, 09 Mar 2021 19:23:05 +0000 Received: by outflank-mailman (input) for mailman id 95728; Tue, 09 Mar 2021 19:23:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJhwd-0006Zf-MN for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 19:23:03 +0000 Received: from mail-wm1-f47.google.com (unknown [209.85.128.47]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4990a103-e548-464b-9d69-b2e458d5445b; Tue, 09 Mar 2021 19:23:03 +0000 (UTC) Received: by mail-wm1-f47.google.com with SMTP id l22so3388792wme.1 for ; Tue, 09 Mar 2021 11:23:03 -0800 (PST) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id z21sm5431943wma.29.2021.03.09.11.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 11:23:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4990a103-e548-464b-9d69-b2e458d5445b X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=K0gLmVpC43ZgYdn9L7XeTYAkhhThRp0c7BhDPkH0sAQ=; b=ep709YUq9Zex++Ospm1QK4lfOB9lL0mTiizDddhMUzYB1295341AKc5YRL4NyJ1LAO dZIAw9wFlkWDmf7U+WSgJf4SMW1JPvewKMa6b8k7Ll8jcWZ+a/3ePSCCrI5rrIhd8YeV VVjuHo8YNPq9sDXlBtbt/SNhCUAbH/tI/m5o3TZnwriKcUTGD046UfxKvclz+o0WR0AY UiYXDRAfQ8WXCLzjG+vmlSjcWWrNJNiGBULiSHGfSPVG/wruv/yCEjCENqC8p0BIzuow SXzcO6o3Azx+0XJV+E9++9mVhBNyrnYT9WIFrpkZnxWIqnQn81DhNqgbLgkh2x2ovr5a QUhw== X-Gm-Message-State: AOAM533I+EUpX/1jckD4gOJ0aCX9JcHIhDgMfl35r08y/WfallRJSLFs EooQZrwV63uGcNEaN/4o0gpl8Vhj0eM= X-Google-Smtp-Source: ABdhPJxzgds6ljacsnE1/lwqq0403TEAi5krK6On3Pj7epUq3CW9aB9xEKtv/XEiSRlKt6eSt+QG4A== X-Received: by 2002:a7b:ca50:: with SMTP id m16mr5608602wml.113.1615317782256; Tue, 09 Mar 2021 11:23:02 -0800 (PST) Date: Tue, 9 Mar 2021 19:23:00 +0000 From: Wei Liu To: paul@xen.org, andyhsu@amazon.com Cc: xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 1/2] xen-netback: add module parameter to disable ctrl-ring Message-ID: <20210309192300.drd4ktvbeaeauvja@liuwe-devbox-debian-v2> References: <20210225122940.9310-1-andyhsu@amazon.com> <33c5f0f0-0e6e-a42c-46a5-405000715c1c@xen.org> <20210309192122.ym7xwduz4ddauks5@liuwe-devbox-debian-v2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210309192122.ym7xwduz4ddauks5@liuwe-devbox-debian-v2> + the author On Tue, Mar 09, 2021 at 07:21:22PM +0000, Wei Liu wrote: > On Tue, Mar 09, 2021 at 02:34:56PM +0000, Paul Durrant wrote: > > On 09/03/2021 14:10, Hsu, Chiahao wrote: > > > On 25.02.21, 13:29, "Hsu, Chiahao" wrote: > > > > > > In order to support live migration of guests between kernels > > > that do and do not support 'feature-ctrl-ring', we add a > > > module parameter that allows the feature to be disabled > > > at run time, instead of using hardcode value. > > > The default value is enable. > > > > > > Signed-off-by: ChiaHao Hsu > > > > You should directly CC maintainers, and also I don't see netdev in the To > > list... Did you send it there? I suspect not, since I don't see 'net-next' > > in the prefix. > > I think it would be better to resend this series. > > See Documentation/networking/netdev-FAQ.rst. > > Wei. > > > > > Paul From xen-devel-bounces@lists.xenproject.org Tue Mar 09 19:58:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 19:58:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95735.180731 (Exim 4.92) (envelope-from ) id 1lJiUa-000116-60; Tue, 09 Mar 2021 19:58:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95735.180731; Tue, 09 Mar 2021 19:58:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJiUa-00010z-2f; Tue, 09 Mar 2021 19:58:08 +0000 Received: by outflank-mailman (input) for mailman id 95735; Tue, 09 Mar 2021 19:58:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJiUZ-00010t-AM for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 19:58:07 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e5298766-ffaf-4d25-a25e-bead9c8d8734; Tue, 09 Mar 2021 19:58:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5298766-ffaf-4d25-a25e-bead9c8d8734 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615319885; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=ph6+vjGNebz+xJRp/BtoeAWuoF4vhl56XYXMIntmvVg=; b=WERVoIbE80fnWCVTc+4jlAPcLsagvEBAOTF803QBbKia4Hpcim+oGXBv HIMX5/Z5Dafb7ZyWzwSfJ2B+fSmQWl1XdA0PP0+d8SZD757a5OFcHV76b yjmE7UV0LbSEj9uV4NEME3kkH7GfXT83GQ09wqaij+fQjkREYv6Xm3dhi 4=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Oz2MRHUGCKPRx62BpRwaKit0MPbMbrhCdqtR9oWlfaGACbELzMbKb6a4amctUv+kPdsN1xI/HJ wf4QaEDv025tlUgc+yRrylIMcBHY0yTGp1UP0UI6va71AubZixi7ZJ+Msy+ZVE8anVficjpBn1 0YzP2xTS2icgnaAEcsyULjzkFG41W/RIVCwlYi4PJWnGIl2yLh6m77qa+8Rq7buwKIvjO4BB2O 0XfALhMtNuHeN/7hbUgfKF9IM0HM1V/yMjji/q+kn+3X+fHcNE/Aq2H3A0aeTsnL9fIH7ZcL9o SRs= X-SBRS: 5.2 X-MesageID: 38892319 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,236,1610427600"; d="scan'208";a="38892319" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PTvAz2W8PrXZ1dfNX7Tiby1pZIQGZA9/WU4qezrys4ZFgLLN5c9+ellW8sYkUBIRo40CMoC38L54OLubz7MXrj+SO/wG3lrgpv+PmLeZadzm7qfLFSdAu636vK4JO+YmocZb2rdVNGAfpRJiCB93xTPFzOOgSYyyMt4r8q9TPhllw47idm8+AmZxeJACFzqZEebtEUVdxTcPI+NXFbpbaMEsxihLfbkQA505e4xoT/o6CElOngVWieHMiCNXAQLFdYC+7U37iToecBfeggFxNA+QzqlbX9Q/+SHZy2n+NaG3fbTXHkA+EnycMXAeJeZRO7GPO+ANCZw2lz2aYl4FFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uvsyn4BQtuOsH1ezzYT6qfWEubjzVqiQLFtMWsBe5Gg=; b=ekmyCFYNxVbOpIoVpWWsemGJUe0yTtsn0MST6FWkhkPWvk7Y0EOLa1ZtlxmeNdNElBuyqc3Q8v8y7C/KKq20OWDLdTMyi3r+Qg7FAaYDSUGKhE1kQN3FYdjG6GQm/8dxsw6cT8kz1e/0mWZiSM4MGioBBvHBrxVCZJC+aogRhrpwrtEgLUw2GDC3YgzzXgFvB0WklbwUqSdwrAZGYRilZI33aI2gLZc6xTmyAyIavACFWGwa1LoNuFlqqmGzQuFeFFppoH/Z3VxY5TNQ7bAKOJIMwPG46yj2wXkUU1I7LvwJWRrCiQ3sTbhQXJfYU9kFHP8BTkA/O2gMeOo/TbwVMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uvsyn4BQtuOsH1ezzYT6qfWEubjzVqiQLFtMWsBe5Gg=; b=ih28x9AlhCjxOztbDazjxcQ0KoV0qNbmbhxT9Ej/jA02IWk3Ms7PWdwjwdql70ndMWBNzBtJJyMenZSc4yXwooB3KBbfmkCXbdvSeavBd066xkyYko67FQFmC/jozghXuLx2KJ9GFWStIGXFje64z9LEl+SuWDYxFX+3P2B8WVA= To: Jan Beulich , Roger Pau Monne CC: Ian Jackson , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky , References: <20210309105634.7200-1-roger.pau@citrix.com> <37e82170-8097-1eda-95d9-23d235075a67@suse.com> From: Andrew Cooper Subject: Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection Message-ID: <4da62f0b-8a08-dd84-2040-fd55d74fd85a@citrix.com> Date: Tue, 9 Mar 2021 19:57:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <37e82170-8097-1eda-95d9-23d235075a67@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0472.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::9) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f1025599-0fa1-4ccd-3c1c-08d8e3359ea2 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5454: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cOV3GjUvGmMqSKOmIpRghAlQW7IxtqtMngGZ+Q6HzWRhfgUd+p2vQdVbxn+LQdus58fYfKZB8u2bWdnOoP4gACrcAbYctqFlMdV7P/hVVOnkvadW0iuppkx1fCKGOUf9cuOZp4R/hYlK7retusYuaLUjZ0i/+6vNNTqa2ItTjvZKaru53REWfJg70pHcV/YHnX+5+H7kvqhH192hVbbwqycYz7JSvDrnbfJPCnr7bDVC5mCm+IH+X/dAVhPSx3/ZZzSifhNRWpjnt4IhehifXU58k+Xu1yGaye2EfiJe1f2OLnuZBO4WOrXFyZp3oiWVZVqp+K4EUH5dM4GOYgnt8ra77f320NOX14pRf9KBPMRuZmk6Mo/HjoiZFsNcqA8LoJtjumFl+q3Ku/4pB9KaDjjTYV4QlCSxNGAje3ZrDpIkTwJjB+n8ZPL79OhpG5YvWvqJLp4FmqOW1t6Zd3zLH44PjKxepvcBCvTKmkInyIZZKFlSt9+jASV5LYtMW+CJiWDjGb1MpLmOii9K9wZQKsEifBuIdaAFplJd5p1AqlR/h7AjfZfvOQldFfX2yIC4QbUKwdRLFsElto/T4pTSZLl8Of35Bjz6V3BvUIH/K+A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(86362001)(31686004)(31696002)(316002)(16576012)(110136005)(4326008)(54906003)(2906002)(5660300002)(2616005)(956004)(36756003)(478600001)(7416002)(6666004)(26005)(6486002)(53546011)(83380400001)(6636002)(8936002)(66476007)(66556008)(66946007)(8676002)(16526019)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?L0FOY0FzR25BT0hyeGRSUFpWa1YzYnpEL3NOcGtxbDN1L3N3T0tvbmRiNUR2?= =?utf-8?B?K0ZFRUZLNXVKT3J0UjBpUWs4azdtYUJsZVdQRVNWZWJac0lYUkpqN1Q2V1dC?= =?utf-8?B?dGYzSlR2SkJrdHRCTmU5ZDRsV0VQS0JSREM2UHplS0V2U0w1QUN2S0ptcklz?= =?utf-8?B?V1ltUDJRcDYxY0xNcVhpQXYvcGpTMkx2d0NDOG11Q0Q0ZUo3c2N3ZEVxTlN6?= =?utf-8?B?ZFo0YlUxc3JLdHVVL2d5dk1ibHFmbFBmN1d0ZkxTM3lIQzJmcm9oRWZHMURa?= =?utf-8?B?dTlpQmQ5Nyt6aERBTGJGMCtjeUpmbkcyY3huaFkycHU5UDJReVEyMnR4bHlU?= =?utf-8?B?RisxN3pGRS9yMVF3aXJjLzN1OVdIYXFlQW9tbFJFYlU5alJMbmlrMjVsSmFw?= =?utf-8?B?Y3JPTnJJQ2FpZklLWVpnYzU3QWphM25UbkZ1R3cydFJxN05BWVJLTWdwUmVJ?= =?utf-8?B?dkw4L2FMY25ZUlhraXZVTSt5dEc2VXUxdFhSQUdudnFhaDlsVFVqYU5QQ0Vt?= =?utf-8?B?NGV4NFVrK3RlYmxVanlldVZZWmg5NitjV2lmSm03ckdCWFJpMDJDb1VxaEVI?= =?utf-8?B?S1JXUXgrQzd2WDJIdHV2endrWUxjbGZZeVF4YTVwRHdCVVQ1ejI5NzY3RnNK?= =?utf-8?B?MFNBd0ZhZjQxNHJpendJVHZDZnplWld6R2l1U2ZheGhWWGtKRUFIbklyb3M3?= =?utf-8?B?WU9qek1DclROc3M3cEVYMHFId0lkak1XYUVlUlNxVU54NEFObjdqRVVLcmR3?= =?utf-8?B?bjEvT3BiUCtTa2RQUmxtYTlFTXA5cTk0aWlsWm91SmNOKzRLcFFlZmcxYnk0?= =?utf-8?B?S29oUjVFdWk3cUQyV0JtTm5TazZJL2FOMnZjOHF6OWJ0Z2kxY1I3Tk5DTTVG?= =?utf-8?B?Ty9QMVZSWUZibE5XTDFFSEZNOFVoVlIwUm9GdUtIS3ZJS3R3SDk2bnBTeXBP?= =?utf-8?B?L3VDcVh3Mmw5Vjg0ZEV2ZUpoTVp4bHhzcmNpMDlvUG9uclpjMndnVGpzYUxq?= =?utf-8?B?T1gyK3g4bWMrWGJ3SzJPR1c3SksrOU1hZ3NjTHBaYVJRUyttNE1qSm5HQzY3?= =?utf-8?B?SVNEZTJkRGYvM3BZM0RNd09TZjhBME1IZ1JsdFIwVGtmRTVycjV1K0tIMWFW?= =?utf-8?B?WkZzM1djTDhrcUpTSjVraVhqSFMyb3dPM2xzNlg1a0pscHFuQWdwMEg0aXNS?= =?utf-8?B?VzgwRGtXRkF0MS9JckZPblE5dEtzM1pQcy9nUm9wazJjRzVqN2lCam92RDlh?= =?utf-8?B?eWJhRFRyQU9TZ0xFUXRpNWVlTEtpY1R4N0lFUWR6Uzk0cWNkZ1NRUUg5RzlH?= =?utf-8?B?bUFvd1ZKQXdoWE1RTUsrTFFaYTJTeHNnRHVXWllDWmtzcTZRa1h4Ymd6WmFT?= =?utf-8?B?SVl0YTdELzlhQ1pvdHZxOVpJeEllUFNodDBlMDZuMmo5Nks2TU9oTURBUkN2?= =?utf-8?B?SjBhbU5QcklId2RIRkpvSFNNUkNjdmlFZzJhaE1KZXdVTEtjTmRxZXRhMDU4?= =?utf-8?B?MEdYQkVmakxtTGVEWndHSDBKRzdEV3NyOVFTTG0waGhta01PU3djWXNEYXh3?= =?utf-8?B?T2UyWisvVWs4Ym5CSUQrVUlINXZSQTZGSHU3bDRiUnZrbXFnTi94NThCWFl3?= =?utf-8?B?dzZGOG1YcXh5SmVwNTREY0Z4Sm4rbEhMSHkvMUpvQnRqRzhDTVFBNlZQSmpF?= =?utf-8?B?UmFYUVJUOE10L215UTF4ZmlmL2FKQWdneWhZTDRuRkdydTcyM1FPTUV6N2NK?= =?utf-8?Q?b1LsuwVExhPveZ9cB76kXI353ldHqfX/mEr7GDi?= X-MS-Exchange-CrossTenant-Network-Message-Id: f1025599-0fa1-4ccd-3c1c-08d8e3359ea2 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 19:57:50.8808 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vx4ljMiiYvCCPAHMKsrkcFe3FFane8jjSyk6UR/Me0I3zgZ5BIoWc0HSk2QLNNKE3YpGnEudAolmqYgCKPeNB31p7TeHiKxc7QD1CYugwiY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5454 X-OriginatorOrg: citrix.com On 09/03/2021 11:36, Jan Beulich wrote: > On 09.03.2021 11:56, Roger Pau Monne wrote: >> Introduce an option to allow selecting a behavior similar to the pre >> Xen 4.15 one for accesses to MSRs not explicitly handled. Since commit >> 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly >> handled by Xen result in the injection of a #GP to the guest. This >> is a behavior change since previously a #GP was only injected if >> accessing the MSR on the real hardware would also trigger a #GP, or if >> the attempted to be set bits wouldn't match the hardware values (for >> PV). >> >> This seems to be problematic for some guests, so introduce an option >> to fallback to this kind of legacy behavior without leaking the >> underlying MSR values to the guest. >> >> When the option is set, for both PV and HVM don't inject a #GP to the >> guest on MSR read if reading the underlying MSR doesn't result in a >> #GP, do the same for writes and simply discard the value to be written >> on that case. >> >> Note that for guests restored or migrated from previous Xen versions >> the option is enabled by default, in order to keep a compatible >> MSR behavior. Such compatibility is done at the libxl layer, to avoid >> higher-level toolstacks from having to know the details about this flag. >> >> Signed-off-by: Roger Pau Monn=C3=A9 > I'm generally okay with this approach, but wouldn't want to give it > my R-b until it's at least clear it's not entirely unacceptable to > anyone else (Andrew in particular). I'm broadly happy with this approach.=C2=A0 Some feedback just sent. > Couple of remarks: > >> Changes since v2: >> - Apply the option to both HVM and PV guest. >> - Handle both reads and writes. > I take it that it's intentional that you didn't allow separate read > and write control? I think v3 is the correct approach. This is strictly a backwards compatibility option.=C2=A0 Splitting read and write just doubles the complexity the admin has wrestle with to recover a legacy guest. As we explicitly intend to retire the option in due course, this is very much a "make my guest work until my upstream (either Xen or kernel) can fix the bug". > >> --- a/xen/arch/x86/hvm/svm/svm.c >> +++ b/xen/arch/x86/hvm/svm/svm.c >> @@ -1795,6 +1795,7 @@ static int svm_msr_read_intercept(unsigned int msr= , uint64_t *msr_content) >> const struct domain *d =3D v->domain; >> struct vmcb_struct *vmcb =3D v->arch.hvm.svm.vmcb; >> const struct nestedsvm *nsvm =3D &vcpu_nestedsvm(v); >> + uint64_t tmp; >> =20 >> switch ( msr ) >> { > While to some degree a matter of taste, I think such variables needed > only inside a switch() and not needing an initializer would better > live in the respective switch()'s scope. Actually, I was hoping to make a CODING_SYTLE change removing this as a permitted construct. Recent compilers have hardening features to automatically initialise all stack variables, because even if your code isn't architecturally buggy, an attacker can launch speculative attacks the stack rubble. However, because of the way the compiler transform works, it cannot tolerate this specific construct in a switch statement, as there is no available execution to cope with the implicit "=3D0" or "=3DPOISON". Even within Xen, we don't have many examples of this construct AFAICT, and there is a concrete security advantage to being able to support the compiler hardening. >> --- a/xen/arch/x86/pv/emul-priv-op.c >> +++ b/xen/arch/x86/pv/emul-priv-op.c >> @@ -875,6 +875,7 @@ static int read_msr(unsigned int reg, uint64_t *val, >> const struct domain *currd =3D curr->domain; >> const struct cpuid_policy *cp =3D currd->arch.cpuid; >> bool vpmu_msr =3D false; >> + uint64_t tmp; >> int ret; >> =20 >> if ( (ret =3D guest_rdmsr(curr, reg, val)) !=3D X86EMUL_UNHANDLEABL= E ) >> @@ -986,6 +987,12 @@ static int read_msr(unsigned int reg, uint64_t *val= , >> } >> /* fall through */ >> default: >> + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, tmp) ) >> + { >> + *val =3D 0; >> + return X86EMUL_OKAY; >> + } >> + >> gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); >> break; >> =20 >> @@ -1148,6 +1155,9 @@ static int write_msr(unsigned int reg, uint64_t va= l, >> } >> /* fall through */ >> default: >> + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, val) ) >> + return X86EMUL_OKAY; >> + >> gdprintk(XENLOG_WARNING, >> "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", >> reg, val); > So what are your thoughts wrt my change to this file? Drop it > altogether and require people to use this new option? Or do you > see both coexist? In the latter case, since you had suggested > that I drop the write side of my change - does your changing of > the write path indicate you've changed your mind? I don't think we should legitimise buggy PV behaviour, either by codifying in the ABI, or providing a knob beyond this one. A guest blindly stumbling forward with a missed #GP could very well worse than crashing hard. Case in point - the 4.15 behaviour spotted a very serious bug in NetBSD where it tried writing MSR_PAT with its own choice (which wasn't the same as Xen's choice).=C2=A0 The consequence of this bug is getting cache attributes in pagetables wrong. It is unfortunate that multiple bugs have combined to make this mess, but every instance needs investigating and fixing.=C2=A0 Continuing to pape= r over the hole doesn't help anyone in the long run. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Mar 09 20:00:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 20:00:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95743.180743 (Exim 4.92) (envelope-from ) id 1lJiWa-0001vS-IB; Tue, 09 Mar 2021 20:00:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95743.180743; Tue, 09 Mar 2021 20:00:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJiWa-0001vL-F8; Tue, 09 Mar 2021 20:00:12 +0000 Received: by outflank-mailman (input) for mailman id 95743; Tue, 09 Mar 2021 20:00:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJiWZ-0001vC-Fb; Tue, 09 Mar 2021 20:00:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJiWZ-0006ie-BE; Tue, 09 Mar 2021 20:00:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJiWZ-0005jV-13; Tue, 09 Mar 2021 20:00:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJiWZ-0000CM-0Z; Tue, 09 Mar 2021 20:00:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=anfcn0MPYAM4SZ/amY0cVFE/hkAmUVmrl6vG12ADGWs=; b=PpJs/kD7xO8m0j1CnbJxb0DPN3 g8/ohYf8Jf62nIMShwzm6JHM8obKoit7YQ7fFBNyqQgf5QBcl36AAA0IoC762yVZpEZ2cn12D6EUq CLVLgSZ/CA07zRpwYz242oA5CU9I87jRF5uHpghSmTNthohEBV65/J27qgN081fcCR6I=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159888: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=229a834518b950d56fd1bc94923276504d0ee9d4 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Tue, 09 Mar 2021 20:00:11 +0000 flight 159888 qemu-mainline real [real] flight 159896 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159888/ http://logs.test-lab.xenproject.org/osstest/logs/159896/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 229a834518b950d56fd1bc94923276504d0ee9d4 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 201 days Failing since 152659 2020-08-21 14:07:39 Z 200 days 385 attempts Testing same since 159878 2021-03-08 21:39:59 Z 0 days 2 attempts ------------------------------------------------------------ 439 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 121438 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 09 20:39:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 20:39:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95763.180762 (Exim 4.92) (envelope-from ) id 1lJj8M-0004t1-Kh; Tue, 09 Mar 2021 20:39:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95763.180762; Tue, 09 Mar 2021 20:39:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJj8M-0004su-Gs; Tue, 09 Mar 2021 20:39:14 +0000 Received: by outflank-mailman (input) for mailman id 95763; Tue, 09 Mar 2021 20:39:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJj8L-0004sm-Di; Tue, 09 Mar 2021 20:39:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJj8L-0007KN-7g; Tue, 09 Mar 2021 20:39:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJj8L-0007h6-0r; Tue, 09 Mar 2021 20:39:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJj8K-00005M-UW; Tue, 09 Mar 2021 20:39:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6LjxOpufVgJgLOWsSlE2E917ba3KX2zUFTxvhYCMnBM=; b=QRzcCwDDTur+/XvG9RvYcB+GVm PNOi2xobo5cTKc5MaPNneZdIWaiPAzGY7ivZqJILwrK2/11FrCRTjNcI0TKnSV4EtYgkPbL3LsDGJ 4UgSWXjTwrJiifsuEu7oLRslp4Yk8FqOUbnwYeYF355RSJw2Wv7kvHz9M1hv2/HFHiB4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159895: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=1b47cc852fd130ed9ce274a0f1600a4a62949a2c X-Osstest-Versions-That: xen=682edc95da4f0ffe8149b4651e5808c76d3a8987 From: osstest service owner Date: Tue, 09 Mar 2021 20:39:12 +0000 flight 159895 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159895/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 1b47cc852fd130ed9ce274a0f1600a4a62949a2c baseline version: xen 682edc95da4f0ffe8149b4651e5808c76d3a8987 Last test of basis 159884 2021-03-09 03:00:27 Z 0 days Testing same since 159895 2021-03-09 18:00:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 682edc95da..1b47cc852f 1b47cc852fd130ed9ce274a0f1600a4a62949a2c -> smoke From xen-devel-bounces@lists.xenproject.org Tue Mar 09 21:15:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 21:15:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95781.180787 (Exim 4.92) (envelope-from ) id 1lJjh0-0008Sa-Ko; Tue, 09 Mar 2021 21:15:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95781.180787; Tue, 09 Mar 2021 21:15:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJjh0-0008ST-Hl; Tue, 09 Mar 2021 21:15:02 +0000 Received: by outflank-mailman (input) for mailman id 95781; Tue, 09 Mar 2021 21:15:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJjgz-0008SO-9v for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 21:15:01 +0000 Received: from mailhost.m5p.com (unknown [74.104.188.4]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c25db99f-4637-43e6-a37a-2987387ed734; Tue, 09 Mar 2021 21:15:00 +0000 (UTC) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 129LEhSM059926 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 9 Mar 2021 16:14:48 -0500 (EST) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 129LEgZp059925; Tue, 9 Mar 2021 13:14:42 -0800 (PST) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c25db99f-4637-43e6-a37a-2987387ed734 Message-Id: <202103092114.129LEgZp059925@m5p.com> From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini Cc: Julien Grall Cc: Volodymyr Babchuk Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Wei Liu Cc: Juergen Gross Date: Mon, 8 Mar 2021 05:36:18 -0800 Subject: [PATCH] arm: replace typeof() with __typeof__() X-Spam-Status: No, score=0.9 required=10.0 tests=DATE_IN_PAST_24_48, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mattapan.m5p.com typeof() is available in Xen's build environment, which uses Xen's compiler. As these headers are public, they need strict standards conformance. Only __typeof__() is officially standardized. A compiler in standards conformance mode should report: warning: implicit declaration of function 'typeof' is invalid in C99 [-Wimplicit-function-declaration] (this has been observed with FreeBSD's kernel build environment) Based-on-patch-by: Julien Grall , Sun Oct 4 20:33:04 2015 +0100 Signed-off-by: Elliott Mitchell --- xen/include/public/arch-arm.h | 2 +- xen/include/public/hvm/save.h | 4 ++-- xen/include/public/io/ring.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index c365b1b39e..713fd65317 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -191,7 +191,7 @@ #define XEN_GUEST_HANDLE_PARAM(name) __guest_handle_ ## name #define set_xen_guest_handle_raw(hnd, val) \ do { \ - typeof(&(hnd)) _sxghr_tmp = &(hnd); \ + __typeof__(&(hnd)) _sxghr_tmp = &(hnd); \ _sxghr_tmp->q = 0; \ _sxghr_tmp->p = val; \ } while ( 0 ) diff --git a/xen/include/public/hvm/save.h b/xen/include/public/hvm/save.h index f72e3a9bc4..bea5e9f50f 100644 --- a/xen/include/public/hvm/save.h +++ b/xen/include/public/hvm/save.h @@ -82,12 +82,12 @@ struct hvm_save_descriptor { struct __HVM_SAVE_TYPE_##_x { _type t; char c[_code]; char cpt[1];} #endif -#define HVM_SAVE_TYPE(_x) typeof (((struct __HVM_SAVE_TYPE_##_x *)(0))->t) +#define HVM_SAVE_TYPE(_x) __typeof__ (((struct __HVM_SAVE_TYPE_##_x *)(0))->t) #define HVM_SAVE_LENGTH(_x) (sizeof (HVM_SAVE_TYPE(_x))) #define HVM_SAVE_CODE(_x) (sizeof (((struct __HVM_SAVE_TYPE_##_x *)(0))->c)) #ifdef __XEN__ -# define HVM_SAVE_TYPE_COMPAT(_x) typeof (((struct __HVM_SAVE_TYPE_COMPAT_##_x *)(0))->t) +# define HVM_SAVE_TYPE_COMPAT(_x) __typeof__ (((struct __HVM_SAVE_TYPE_COMPAT_##_x *)(0))->t) # define HVM_SAVE_LENGTH_COMPAT(_x) (sizeof (HVM_SAVE_TYPE_COMPAT(_x))) # define HVM_SAVE_HAS_COMPAT(_x) (sizeof (((struct __HVM_SAVE_TYPE_##_x *)(0))->cpt)-1) diff --git a/xen/include/public/io/ring.h b/xen/include/public/io/ring.h index d68615ae2f..6a94a9fe4b 100644 --- a/xen/include/public/io/ring.h +++ b/xen/include/public/io/ring.h @@ -242,7 +242,7 @@ typedef struct __name##_back_ring __name##_back_ring_t */ #define RING_COPY_REQUEST(_r, _idx, _req) do { \ /* Use volatile to force the copy into _req. */ \ - *(_req) = *(volatile typeof(_req))RING_GET_REQUEST(_r, _idx); \ + *(_req) = *(volatile __typeof__(_req))RING_GET_REQUEST(_r, _idx); \ } while (0) #define RING_GET_RESPONSE(_r, _idx) \ -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 21:28:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 21:28:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95789.180799 (Exim 4.92) (envelope-from ) id 1lJjts-00017z-RT; Tue, 09 Mar 2021 21:28:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95789.180799; Tue, 09 Mar 2021 21:28:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJjts-00017s-Nw; Tue, 09 Mar 2021 21:28:20 +0000 Received: by outflank-mailman (input) for mailman id 95789; Tue, 09 Mar 2021 21:28:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJjtr-00017n-G8 for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 21:28:19 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 891c1b58-7219-4156-b7cf-5f50b8510870; Tue, 09 Mar 2021 21:28:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 891c1b58-7219-4156-b7cf-5f50b8510870 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615325298; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=MUEbdImqHtSsNbjyATBdV0L+7oRR93ty0OFvf8xU3SU=; b=Jxo/ZXaYMo+3LftIqp2X3nYK6uiEbR/RQWlRwv4Cnr7Bd3J8hSzuU3pz Ra2ffmsOZgToFZrfuIEtX1xRCa3pML/v3Pg0E9+8mH8xGeHDYV1Mya8xk IfWLeJRcNCMm13whgQcTaj0VW3/5eHxSS3MHyY7UvDOHij9I0M65eqvnr w=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: OzOu2NJ0T+GUbtZW4pNe+3ItqPiRQV8pwhTM+xe+FognLQZ3m9ApM/TutgouqFP50let+z0j2c JopbjPc0ihqZHSL8gDUG3drir4kzoyXznJK1xjb3L3ssYgY4jTXqbHWeaSjOQMzom6Bb7zS/Bs X8obeBVYsES6Bnl3B4rcOeHZggsQ1lC4jb91NyBHzE0aTBXsX6u28CBBq/s/rEGQSOFyPO7dMu mBqAzzTqAsXEok+sE0O1uJvCIlcbsZycV363HlRRFno+nbEm2nd/yQJda/KCgCF6lvpx8ygM4F gMM= X-SBRS: 5.2 X-MesageID: 39271719 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,236,1610427600"; d="scan'208";a="39271719" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c7f1fAvR13JwzgkE1fLDKkFOzLW4Lhy5MC5cGyCeYSDxXtJDMyDE6tmoEa4lLF4aiqyaWD5PBQk5CZ5MU3yWcQHjFh6dO5l9DCmWtfDKm8jqDQUmgLUL3v6/+W+AoptLrU31e0cub3cNdY5IRSFfVTrk2olISANsGDPzB8P6t4zP5jxftradSfCEKTJdClTJ+dJXAADDfjaMrEqfd0tEX8LcfSzyIhz9gZudq12HT/JaLvHFsiYlL3wejv2287fJTfz+/mMWPwBI6HH2i/9hsNHfOkyfXM39ahIJqez8GzMkEweeVJA+RtOb/DsMm8XHkBSzVvuSdt+rt6zVidQgqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EHAWXWQeFMG1dZV+TkKBpIvZ2X4MziZTej5Jb9/tD8s=; b=UfhxqAeYVilgQXb5JMTDAyiTOczlVbQHiG+37nSR/OUZCvKFQhJYbn0IhyAR7XGFZL1lEdZEKe5A7xR0LoDyLR7f00gqkilw+Pk7Q06pQXDUhUbAoA8LwCX77Rfk3GKc56phzROox/TEJ+gY5tJuh5yP/SjolhiN7jwCKoEdbuQSCguDV9kW2hENkMxUVJctlszvWUu49+Qie0lhS5VcRhA/TUJo+ClBK5+xIIbYY7zi1n0j1gvrS5uCuNlDQbRpHkIEdVApiysKSJl1fLWdrUx9ZOSqcoMgHHlCZP5qA2Pq4Z4iRdeT4Mwg8w/aCHI1TSh30vao+ODgfk1phP3QiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EHAWXWQeFMG1dZV+TkKBpIvZ2X4MziZTej5Jb9/tD8s=; b=JouFyZmGP0cvsoyTTCznByOoVm0TJAHgcDfj55wflCJZLFS9LOlTS8e7JJxjL14yKH4bdsOgUDRO7i5eJaeAU0YxAQ7SPrx8mQJOp43LJsIgMEwqdOiezx0l6UUXUNqY55zrlcJTQj3I1aZUdlDYJC2DVnkFgJVC1fOZeSpIwWs= To: Elliott Mitchell , CC: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Juergen Gross References: <202103092114.129LEgZp059925@m5p.com> From: Andrew Cooper Subject: Re: [PATCH for-4.15] arm: replace typeof() with __typeof__() Message-ID: Date: Tue, 9 Mar 2021 21:27:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <202103092114.129LEgZp059925@m5p.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0099.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bafee5e6-29ab-4f85-46c7-08d8e3422bd8 X-MS-TrafficTypeDiagnostic: BYAPR03MB4165: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Iv52jJYqp4pMT1UlYdQ4FXc1BRuHDImey6yUpeCM7Qa6fAcOGLqTUUI2/k3JuFnZfD7BAjVwbV/ir+mgRdJXQNDObH7SoA7Gyrhw++8MQ5Pzl/wEc2qkLCiepdSrpOa2qguQrFb9qpPDI2109Kc1t1Q78tyo9aPzQ292SwE8bGsUXBtdFDdBw+R0isD6JX+brSYBEzK902/IXqs2zbliToXJ91luMN050By6heaQkVB/f4AyWuATyUzpBZZz3B4RuhokDNV0LcBmysQl4yNL08sb8PwzFO5+2SGmoYo2+xdLDLzr/lEsU/y0K7AIFl185FAApI8QqquPyzN8wK3ecX9t1uG62vwXWzsK7o63Rwacj00N5Af9/iiQdNEtt4PFnALXJ4Fe0tnz2fqETHNOP7NIKnVU+msR7AqppngFpnyysEhi36+t1Z9yu/G/ZoGctF036uebBPrBlh7BcCVwCzMrkJAJn0Sev2L875c5kysS/+SaQCDyJp5xiKoA4F5pqlY/WaRA043KVTEQ5LnJ6Z7I6twpDzdwrEGTks7hzagcS4hsILz71mO6+S+F3pxQnblZ1FxXfHW2rM6vEPxfJf/bb0k41aCExsqWRxTLhSM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(136003)(366004)(39860400002)(346002)(16526019)(8936002)(4326008)(4744005)(31686004)(83380400001)(6666004)(5660300002)(53546011)(478600001)(8676002)(956004)(2616005)(26005)(36756003)(86362001)(54906003)(316002)(186003)(66556008)(66476007)(66946007)(6486002)(2906002)(16576012)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bHBCZHJTRXduenpjRmhzR2pnOHErRVFTU1hlaVNzRHg3ZWZyNG9HK3V2WkRk?= =?utf-8?B?M3NWWDQyQ3daQ3dWMDk2SlNScmRZYmR4RzBpTExQVzEvWm5PZUtvY29SMnZJ?= =?utf-8?B?eVhXMHJ5NGJ1VUpoZnFaK09HQm9wRmlGckVnZDZRMFBvbzc4Z0o3UTVTKzA2?= =?utf-8?B?N1BuU2hEL3BXSDZXeWZwZDFDaFh4SFlMcG1lZ0R3NHBiaEc1dXFvbGk5TXYv?= =?utf-8?B?Z01IcWtWUDZHWTZGOFdwUkhrR3ZFdHZKbExOdW1CM0Jja01YUGN2c1hDQjBs?= =?utf-8?B?N2JWYUplV1hNLzIrSFFXWXJPeGFQWVJxdmZCdWRrSnkxaGZScjBKVnRCY293?= =?utf-8?B?VEl6SHJwNFZSWXJpTGF6dE5CUzdBSWxQZTJvbTJJV2txd1AwNEtUR204eHRj?= =?utf-8?B?dHkvbzNXRFkxdmtIa3libXZjeFFZNGp5OHcxaXZHaDNOUXI4NWtuOGVVL3ln?= =?utf-8?B?NXZKeHU0aHpoUGsvK0N2MS93bjZkalpJY1pPZS9ZZkZVYXA5SStWZjRoeHlq?= =?utf-8?B?aXFqS3ZlZlU4OHAzcjYzZFFSeVdiTnZ5N0t5MHpVZEI1ODJTTHM3dW5jMTdF?= =?utf-8?B?RktvSW9QYmRFQ2RIOWl5bno3OFhMMXZIdXZleUwxNE9FOEEwNVdoVzFaS0Mx?= =?utf-8?B?cERUWjVXOU16djU3cXozL2thREdjQjh5MmU2WUs3RlFJdzBXVFdmWlljejFS?= =?utf-8?B?UC9Dc3JpdmZ3YzF1L1hEN2tGQTBhUlFDVXNBK0dnR2dBeEhnT2tXK0pQSFFZ?= =?utf-8?B?V0lFSmxobGhsVTd3QmU0bCtqenB3Z1NFa0lOMnhjcm9CVDdKdC9aV0Mwb0Nu?= =?utf-8?B?eXhmQm9SUXM1aWw4dklFYzF4OEVmVjlSWm1PMlFEbnVxZ2VYTTZwaVVzYXlx?= =?utf-8?B?cVVwb1ZjSm1CckpuWW9PTGgybndNSllUc1NPRElsV0hsNTV4dm9HQ1c5TUk2?= =?utf-8?B?Vk52dE5CNmd4Q0UwVldBa0loS2dIK3dRU3dya09pSzdocjc2SU1YeS9ldFlw?= =?utf-8?B?V0g1L2p0TURYWGRqM0w2RlB2aEJLcVNmZGFMeXJncnI5UjE3bi8vcnhabHJo?= =?utf-8?B?amZlUW1wNW5SWERqbFhYWSs0dVpoU2pWU1FlMzhNVUt0K0JpSzIrNjlneWla?= =?utf-8?B?NjRGY1paZWlpYzN1QXhMVS9JSGtCK1JONmIxQk5veHUycUhQZ2VjSzNySndH?= =?utf-8?B?VWY5QnZxQ1lQbldLdjZpZSt1ZWsrL25Ld0NYY2lIVG5PWkhhUk1MaWF2RFE3?= =?utf-8?B?OExOSnFmSDZPQndBMGxSQllLaHkyYTVwTmFJVThZSERubFphTWQ1Y2tTcjdm?= =?utf-8?B?OWVBZHZOV1VKRFV0VWdobVA2eE95T3M3QzczY0VpaC9TeWgvU1NEYmdhZkRu?= =?utf-8?B?V0YwSVVkaThBalI5VVh1ZjhEdnZ0UU5NUFlzR3lsUnRtTWdsQ2hhM1JBT3NX?= =?utf-8?B?SFhQT21lbWNnWVh1ZndxWkRaaEJDTzdKcEp5b0QzWkY5UjNCMHI5SGM3NTZa?= =?utf-8?B?ME1tQ3ZiblRTVFBscEFEb201ZUNCMlJMRjk2Y3FteU1wVHR3OVFiOVBHZnlC?= =?utf-8?B?dFg1MythZ3VPTU1FQjg1YUdZblhHSW1XYXpobXExK2lCSzJwK3lOcXkrMitj?= =?utf-8?B?YTU1aEJTVXhJeFh2WU9MNkUyUVViMWhJL3ROeWxLYm96YjhiWWtlQnpiMHJQ?= =?utf-8?B?dkN0d040L0xRTCs0bWU3dzN1UlpkNFBFTm5pZVpUTFVaZVhHTnBXcXhOTFlC?= =?utf-8?Q?qQ+MfbUFXfjFdMwzajiXCgoAYNIyqMmOce3rVRu?= X-MS-Exchange-CrossTenant-Network-Message-Id: bafee5e6-29ab-4f85-46c7-08d8e3422bd8 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 21:27:41.9394 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vDdb1Sbpyrp8IJS1D9LjPaAM7f1uYHVgDV5/HZ16VnEKyTDOQHVjoHxf+FR3mARvzhDc95JLI5D86CxiVSPUC1FfOIuW6bn36SiBxsXzM68= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4165 X-OriginatorOrg: citrix.com On 08/03/2021 13:36, Elliott Mitchell wrote: > typeof() is available in Xen's build environment, which uses Xen's > compiler. As these headers are public, they need strict standards > conformance. Only __typeof__() is officially standardized. > > A compiler in standards conformance mode should report: > > warning: implicit declaration of function 'typeof' is invalid in C99 > [-Wimplicit-function-declaration] > > (this has been observed with FreeBSD's kernel build environment) > > Based-on-patch-by: Julien Grall , Sun Oct 4 20:33:04 2015= +0100 > Signed-off-by: Elliott Mitchell s!arm!xen/public! in the subject seeing as two thirds of the modifications are in non-ARM headers. Acked-by: Andrew Cooper This wants backporting as a build fix, so should be considered for 4.15 at this point. I wonder why our header checks don't pick this up.=C2=A0 Do we need to thro= w a -pedantic around? From xen-devel-bounces@lists.xenproject.org Tue Mar 09 22:08:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 22:08:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95798.180815 (Exim 4.92) (envelope-from ) id 1lJkWi-0004lx-1v; Tue, 09 Mar 2021 22:08:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95798.180815; Tue, 09 Mar 2021 22:08:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJkWh-0004lq-VB; Tue, 09 Mar 2021 22:08:27 +0000 Received: by outflank-mailman (input) for mailman id 95798; Tue, 09 Mar 2021 22:08:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJkWg-0004ll-7J for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 22:08:26 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [170.10.133.124]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 9d83a547-fa69-4fe1-af66-7d431d274933; Tue, 09 Mar 2021 22:08:24 +0000 (UTC) Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-166-Budw5cMqPBCvu3CF6jYNBA-1; Tue, 09 Mar 2021 17:08:22 -0500 Received: by mail-ej1-f69.google.com with SMTP id e13so6275943ejd.21 for ; Tue, 09 Mar 2021 14:08:21 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id u15sm10107092eds.6.2021.03.09.14.08.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 14:08:20 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d83a547-fa69-4fe1-af66-7d431d274933 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615327704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TrRfkpaCyAif10vY2NLzElT8H9hcz96S44UT+WnEyM0=; b=AX4JN3KlRzvVZY7kUOGstjmHLo/65B3SiilWnDoIa1wLK+17QVEMVMMhS0y2ynLTy02cAM Gni/Cb4TnscuEMebIrep8ArMUjbdUrZZ/fu4qNUQ1bu7xeLoRap1bIvgFEXgFJGtE53D5E hjGcIse+0L9LEEBshtDdmGUHDQ47llI= X-MC-Unique: Budw5cMqPBCvu3CF6jYNBA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TrRfkpaCyAif10vY2NLzElT8H9hcz96S44UT+WnEyM0=; b=gP9WtBxfAGsFBBhl+4soqaZy0y11XUHFEoPQwq7iaadsNKe78PEWRp6IUjVbqI5sJs kQvAXkhwmmAoDbX77TgtjLGgXOmRltUpj1ZMcCzYhMdEzLkS9k99yh+OLOCkpHdBdNcf dpG9aGMT2int8e/fml7k7CZLUGtFm41BEz0rRJVo+ZNCdY9yAKtQOdGPVFjIY2p3rbZo SvTBzMRBnkyCs6G92vvZ61Ih6Y8cVK/PhQ3q0Eq7k65KKXtqVsvds7mdJ7Ll5CDCLb2K JlyOVw/IYGNGU/wsvjyN3bvO272ydsEzahvBox9KTDEtCMtiZz8ViH7HuBYVzmBQQkQN 43FA== X-Gm-Message-State: AOAM5336oWaL0JztgJk9O9H0/wSUVXzmB3mWZH2dsR8BhK+YObhKzaCZ WF41JlNDEZpBqCgLLANVAfLM5TNEHya+zwgM5QKCop8eszmHjL+p343Kt+6XSDitDhJpBjKmTGk NmhkIzLRKQaAzM6bZ5W7IchHOWxA= X-Received: by 2002:a17:907:d15:: with SMTP id gn21mr180972ejc.337.1615327700938; Tue, 09 Mar 2021 14:08:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyoPZbz8BsbfZxNq4crDSMnBl/+S3hyEa4IsAMqqCextuO59Wc8A5fWQ9LtkxA8SuHE3e3dRQ== X-Received: by 2002:a17:907:d15:: with SMTP id gn21mr180947ejc.337.1615327700754; Tue, 09 Mar 2021 14:08:20 -0800 (PST) Subject: Re: [PATCH 0/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: qemu-devel@nongnu.org, Paolo Bonzini , QEMU Trivial Cc: Huacai Chen , Greg Kurz , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, Amit Shah , Dmitry Fleytman , qemu-arm@nongnu.org, John Snow , qemu-s390x@nongnu.org, Paul Durrant , Anthony Perard , Eduardo Habkost , Gerd Hoffmann , Kevin Wolf , Marcelo Tosatti , Max Reitz , Alex Williamson , Aurelien Jarno , Aleksandar Rikalo , Marcel Apfelbaum , Jason Wang , Peter Maydell , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Halil Pasic , Fam Zheng , qemu-ppc@nongnu.org, kvm@vger.kernel.org, Stefano Stabellini , xen-devel@lists.xenproject.org, Cornelia Huck , David Hildenbrand , qemu-block@nongnu.org, Christian Borntraeger , Sunil Muthuswamy , David Gibson , Richard Henderson , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Laurent Vivier , Thomas Huth , Stefan Hajnoczi , Jiaxun Yang References: <20210111152020.1422021-1-philmd@redhat.com> <84048681-32d3-7217-e94c-461501cf550b@redhat.com> Message-ID: <3112233d-e227-b0c5-4a97-3ad0127a4d12@redhat.com> Date: Tue, 9 Mar 2021 23:08:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <84048681-32d3-7217-e94c-461501cf550b@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit ping, qemu-trivial maybe? On 2/22/21 3:34 PM, Philippe Mathieu-Daudé wrote: > Paolo, this series is fully reviewed, can it go via your > misc tree? > > On 1/11/21 4:20 PM, Philippe Mathieu-Daudé wrote: >> Trivial prototype change to clarify the use of the 'running' >> argument of VMChangeStateHandler. >> >> Green CI: >> https://gitlab.com/philmd/qemu/-/pipelines/239497352 >> >> Philippe Mathieu-Daudé (2): >> sysemu/runstate: Let runstate_is_running() return bool >> sysemu: Let VMChangeStateHandler take boolean 'running' argument >> >> include/sysemu/runstate.h | 12 +++++++++--- >> target/arm/kvm_arm.h | 2 +- >> target/ppc/cpu-qom.h | 2 +- >> accel/xen/xen-all.c | 2 +- >> audio/audio.c | 2 +- >> block/block-backend.c | 2 +- >> gdbstub.c | 2 +- >> hw/block/pflash_cfi01.c | 2 +- >> hw/block/virtio-blk.c | 2 +- >> hw/display/qxl.c | 2 +- >> hw/i386/kvm/clock.c | 2 +- >> hw/i386/kvm/i8254.c | 2 +- >> hw/i386/kvmvapic.c | 2 +- >> hw/i386/xen/xen-hvm.c | 2 +- >> hw/ide/core.c | 2 +- >> hw/intc/arm_gicv3_its_kvm.c | 2 +- >> hw/intc/arm_gicv3_kvm.c | 2 +- >> hw/intc/spapr_xive_kvm.c | 2 +- >> hw/misc/mac_via.c | 2 +- >> hw/net/e1000e_core.c | 2 +- >> hw/nvram/spapr_nvram.c | 2 +- >> hw/ppc/ppc.c | 2 +- >> hw/ppc/ppc_booke.c | 2 +- >> hw/s390x/tod-kvm.c | 2 +- >> hw/scsi/scsi-bus.c | 2 +- >> hw/usb/hcd-ehci.c | 2 +- >> hw/usb/host-libusb.c | 2 +- >> hw/usb/redirect.c | 2 +- >> hw/vfio/migration.c | 2 +- >> hw/virtio/virtio-rng.c | 2 +- >> hw/virtio/virtio.c | 2 +- >> net/net.c | 2 +- >> softmmu/memory.c | 2 +- >> softmmu/runstate.c | 4 ++-- >> target/arm/kvm.c | 2 +- >> target/i386/kvm/kvm.c | 2 +- >> target/i386/sev.c | 2 +- >> target/i386/whpx/whpx-all.c | 2 +- >> target/mips/kvm.c | 4 ++-- >> ui/gtk.c | 2 +- >> ui/spice-core.c | 2 +- >> 41 files changed, 51 insertions(+), 45 deletions(-) >> > From xen-devel-bounces@lists.xenproject.org Tue Mar 09 22:13:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 22:13:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95801.180827 (Exim 4.92) (envelope-from ) id 1lJkbn-0005cf-Lm; Tue, 09 Mar 2021 22:13:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95801.180827; Tue, 09 Mar 2021 22:13:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJkbn-0005cY-Hz; Tue, 09 Mar 2021 22:13:43 +0000 Received: by outflank-mailman (input) for mailman id 95801; Tue, 09 Mar 2021 22:13:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJkbm-0005cT-6N for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 22:13:42 +0000 Received: from mout.kundenserver.de (unknown [212.227.17.10]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8b9d4691-b3f3-43f7-8a02-2d64de81927d; Tue, 09 Mar 2021 22:13:40 +0000 (UTC) Received: from [192.168.100.1] ([82.142.6.26]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MaIvT-1lDrLg2j3N-00WEYS; Tue, 09 Mar 2021 23:13:29 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b9d4691-b3f3-43f7-8a02-2d64de81927d Subject: Re: [PATCH 1/2] sysemu/runstate: Let runstate_is_running() return bool To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Fam Zheng , Peter Maydell , Dmitry Fleytman , kvm@vger.kernel.org, Paul Durrant , Jason Wang , David Hildenbrand , Thomas Huth , Jiaxun Yang , Gerd Hoffmann , Stefano Stabellini , qemu-block@nongnu.org, qemu-trivial@nongnu.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Huacai Chen , Halil Pasic , Christian Borntraeger , Marcel Apfelbaum , Anthony Perard , qemu-ppc@nongnu.org, Aleksandar Rikalo , Eduardo Habkost , Amit Shah , Richard Henderson , Greg Kurz , Alex Williamson , qemu-arm@nongnu.org, =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , xen-devel@lists.xenproject.org, Sunil Muthuswamy , John Snow , David Gibson , Kevin Wolf , Marcelo Tosatti , qemu-s390x@nongnu.org, Max Reitz , "Michael S. Tsirkin" , Cornelia Huck , Paolo Bonzini , Aurelien Jarno References: <20210111152020.1422021-1-philmd@redhat.com> <20210111152020.1422021-2-philmd@redhat.com> From: Laurent Vivier Message-ID: <07895651-8d3f-5029-f53d-c85046a4d671@vivier.eu> Date: Tue, 9 Mar 2021 23:13:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210111152020.1422021-2-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:12XOd/fQZjSctmbivNeZ1JZuQewWmbkfNL57bgUQXmbdKx9dqLq HByZ1sycMG2xd1f+Y6yoJ/TNHv1q6ARh/FZPZEs0rYlTXo9PPylXUW3db8Eoe56W/2ymSKS /crueO/Fx3A1swwtZA4GcywniuEYh2T+g3qQCTjORZGEdqbUjOU+rQWriBAh+Sl4PrvEl7W vTfr73lCewZh9adojPJ2A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:0bXVhwhndoo=:bFHdv36pWdMKsFzU/9x10J fmKQKyh8l7iyerCElMGY2yYMA3QZwQ6jbBMMIVsI6KEc+S2AIhKNe7HuCowVP5x4JzeuftrFe e1+4vqqbDGJ3WGNzmpMYAhJ0Njbl6/EAgMbtJQKAqVaryqK3xVT9dpbAwX3JzDGJqUfhAXoyN JdHgfLNttj3xq5oyOsgInECsqt4mS31a+Lqlsy422v8f/DZtEkiOmSHFr077kI8kzB2J7k7HL Pq97nLqxOVL/HO97G3GmXoeFA/rtuZlezrPfR0HVlsWTR+XvzwO9rqlp5Web+tuIavvic7Vu+ m8uJOnVXHSJSFQaDy0PAXdj4FDanqvaZ9O1bOj3zb6DcA1MOhXI+XZ/DB4Tt3isCVhPMAk1oI uru20n4qviPJbzX7PPt7Bo/L3VJeJyDIUhcqJHkgj+lgqfnL42QDBDbdSpSHhQ3q3VgvXUM2Y KfFETldzFg== Le 11/01/2021 à 16:20, Philippe Mathieu-Daudé a écrit : > runstate_check() returns a boolean. runstate_is_running() > returns what runstate_check() returns, also a boolean. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/runstate.h | 2 +- > softmmu/runstate.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/sysemu/runstate.h b/include/sysemu/runstate.h > index e557f470d42..3ab35a039a0 100644 > --- a/include/sysemu/runstate.h > +++ b/include/sysemu/runstate.h > @@ -6,7 +6,7 @@ > > bool runstate_check(RunState state); > void runstate_set(RunState new_state); > -int runstate_is_running(void); > +bool runstate_is_running(void); > bool runstate_needs_reset(void); > bool runstate_store(char *str, size_t size); > > diff --git a/softmmu/runstate.c b/softmmu/runstate.c > index 636aab0addb..c7a67147d17 100644 > --- a/softmmu/runstate.c > +++ b/softmmu/runstate.c > @@ -217,7 +217,7 @@ void runstate_set(RunState new_state) > current_run_state = new_state; > } > > -int runstate_is_running(void) > +bool runstate_is_running(void) > { > return runstate_check(RUN_STATE_RUNNING); > } > Applied to my trivial-patches branch. Thanks, Laurent From xen-devel-bounces@lists.xenproject.org Tue Mar 09 22:14:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 22:14:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95804.180839 (Exim 4.92) (envelope-from ) id 1lJkcO-0005iy-33; Tue, 09 Mar 2021 22:14:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95804.180839; Tue, 09 Mar 2021 22:14:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJkcN-0005ir-Vh; Tue, 09 Mar 2021 22:14:19 +0000 Received: by outflank-mailman (input) for mailman id 95804; Tue, 09 Mar 2021 22:14:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJkcN-0005ij-5r for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 22:14:19 +0000 Received: from mout.kundenserver.de (unknown [217.72.192.73]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a3e08f2a-5f5e-4550-a77f-31c478aa2527; Tue, 09 Mar 2021 22:14:16 +0000 (UTC) Received: from [192.168.100.1] ([82.142.6.26]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MgNlB-1lxTkX0HHz-00hwus; Tue, 09 Mar 2021 23:14:06 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3e08f2a-5f5e-4550-a77f-31c478aa2527 Subject: Re: [PATCH 2/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Fam Zheng , Peter Maydell , Dmitry Fleytman , kvm@vger.kernel.org, Paul Durrant , Jason Wang , David Hildenbrand , Thomas Huth , Jiaxun Yang , Gerd Hoffmann , Stefano Stabellini , qemu-block@nongnu.org, qemu-trivial@nongnu.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Huacai Chen , Halil Pasic , Christian Borntraeger , Marcel Apfelbaum , Anthony Perard , qemu-ppc@nongnu.org, Aleksandar Rikalo , Eduardo Habkost , Amit Shah , Richard Henderson , Greg Kurz , Alex Williamson , qemu-arm@nongnu.org, =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , xen-devel@lists.xenproject.org, Sunil Muthuswamy , John Snow , David Gibson , Kevin Wolf , Marcelo Tosatti , qemu-s390x@nongnu.org, Max Reitz , "Michael S. Tsirkin" , Cornelia Huck , Paolo Bonzini , Aurelien Jarno References: <20210111152020.1422021-1-philmd@redhat.com> <20210111152020.1422021-3-philmd@redhat.com> From: Laurent Vivier Message-ID: Date: Tue, 9 Mar 2021 23:14:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210111152020.1422021-3-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:Wz1kCOiI5qvsEjaBV7eL7C/P3yRzShfp72une3BLfv9vcOxuqB8 Yc/zyj4gn7LDz5LJeKuPrs/v/R9kxmV7JZwhrnY2BtbKmrL3n+OofhrOc69U1Ko+s9oK09t MyTM2CTl1v1VLjgDMzOKCTxlQtmvrKok0q39cHHxtoyB2zvz1TuNnegsQfktIB4wTUYbxYU FEuZfHtqVJ5K3/bbmCj3A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:qj5mfo9/4+s=:cFr614z98+EEppj5K1O5bB 7GiNXb+l9NFon8gCbvJm63lMGQXPwilfWyhLUbzY7/81oY2nWlX6GmAAOx6lq3kguLbe8LzJL gJuL1M8RbCuqGxgO4brtUScGAxVM0JkPNSoq6JltaZVWXVywEVdaNQ/hoGYWlSuHKfTkWYcIV v8X7lvHxAfzlgxb9C9jaT1bM+8wivsvvVDaYHrMFlsOIcC+YjnrPihssR4kxe1ZQu6Q4NIvRG SIM2d7E/HiSkfQWAFCtEEMuA9fOXbVYLMTcHtUTNqBqOS2o652AcDnY3bo+znE3uz/99MzQpM hIpiWdpVTJyVjlkcEKrX2o5obgqVKhvjlZlDMXXOQEpdsvTAtWR8A93wuc8fe+GokcdWy0EdE py2dO1FPAfsQxHnCx6tHxFHReX+bRTokrQgyDVFUZtBXfR/BlYShlERlhZLo9vsnebIjtW7/g OQYMDI61hw== Le 11/01/2021 à 16:20, Philippe Mathieu-Daudé a écrit : > The 'running' argument from VMChangeStateHandler does not require > other value than 0 / 1. Make it a plain boolean. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/runstate.h | 10 ++++++++-- > target/arm/kvm_arm.h | 2 +- > target/ppc/cpu-qom.h | 2 +- > accel/xen/xen-all.c | 2 +- > audio/audio.c | 2 +- > block/block-backend.c | 2 +- > gdbstub.c | 2 +- > hw/block/pflash_cfi01.c | 2 +- > hw/block/virtio-blk.c | 2 +- > hw/display/qxl.c | 2 +- > hw/i386/kvm/clock.c | 2 +- > hw/i386/kvm/i8254.c | 2 +- > hw/i386/kvmvapic.c | 2 +- > hw/i386/xen/xen-hvm.c | 2 +- > hw/ide/core.c | 2 +- > hw/intc/arm_gicv3_its_kvm.c | 2 +- > hw/intc/arm_gicv3_kvm.c | 2 +- > hw/intc/spapr_xive_kvm.c | 2 +- > hw/misc/mac_via.c | 2 +- > hw/net/e1000e_core.c | 2 +- > hw/nvram/spapr_nvram.c | 2 +- > hw/ppc/ppc.c | 2 +- > hw/ppc/ppc_booke.c | 2 +- > hw/s390x/tod-kvm.c | 2 +- > hw/scsi/scsi-bus.c | 2 +- > hw/usb/hcd-ehci.c | 2 +- > hw/usb/host-libusb.c | 2 +- > hw/usb/redirect.c | 2 +- > hw/vfio/migration.c | 2 +- > hw/virtio/virtio-rng.c | 2 +- > hw/virtio/virtio.c | 2 +- > net/net.c | 2 +- > softmmu/memory.c | 2 +- > softmmu/runstate.c | 2 +- > target/arm/kvm.c | 2 +- > target/i386/kvm/kvm.c | 2 +- > target/i386/sev.c | 2 +- > target/i386/whpx/whpx-all.c | 2 +- > target/mips/kvm.c | 4 ++-- > ui/gtk.c | 2 +- > ui/spice-core.c | 2 +- > 41 files changed, 49 insertions(+), 43 deletions(-) > > diff --git a/include/sysemu/runstate.h b/include/sysemu/runstate.h > index 3ab35a039a0..a5356915734 100644 > --- a/include/sysemu/runstate.h > +++ b/include/sysemu/runstate.h > @@ -10,7 +10,7 @@ bool runstate_is_running(void); > bool runstate_needs_reset(void); > bool runstate_store(char *str, size_t size); > > -typedef void VMChangeStateHandler(void *opaque, int running, RunState state); > +typedef void VMChangeStateHandler(void *opaque, bool running, RunState state); > > VMChangeStateEntry *qemu_add_vm_change_state_handler(VMChangeStateHandler *cb, > void *opaque); > @@ -20,7 +20,13 @@ VMChangeStateEntry *qdev_add_vm_change_state_handler(DeviceState *dev, > VMChangeStateHandler *cb, > void *opaque); > void qemu_del_vm_change_state_handler(VMChangeStateEntry *e); > -void vm_state_notify(int running, RunState state); > +/** > + * vm_state_notify: Notify the state of the VM > + * > + * @running: whether the VM is running or not. > + * @state: the #RunState of the VM. > + */ > +void vm_state_notify(bool running, RunState state); > > static inline bool shutdown_caused_by_guest(ShutdownCause cause) > { > diff --git a/target/arm/kvm_arm.h b/target/arm/kvm_arm.h > index eb81b7059eb..68ec970c4f4 100644 > --- a/target/arm/kvm_arm.h > +++ b/target/arm/kvm_arm.h > @@ -352,7 +352,7 @@ void kvm_arm_get_virtual_time(CPUState *cs); > */ > void kvm_arm_put_virtual_time(CPUState *cs); > > -void kvm_arm_vm_state_change(void *opaque, int running, RunState state); > +void kvm_arm_vm_state_change(void *opaque, bool running, RunState state); > > int kvm_arm_vgic_probe(void); > > diff --git a/target/ppc/cpu-qom.h b/target/ppc/cpu-qom.h > index 63b9e8632ca..118baf8d41f 100644 > --- a/target/ppc/cpu-qom.h > +++ b/target/ppc/cpu-qom.h > @@ -218,7 +218,7 @@ extern const VMStateDescription vmstate_ppc_timebase; > .offset = vmstate_offset_value(_state, _field, PPCTimebase), \ > } > > -void cpu_ppc_clock_vm_state_change(void *opaque, int running, > +void cpu_ppc_clock_vm_state_change(void *opaque, bool running, > RunState state); > #endif > > diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c > index 878a4089d97..3756aca27be 100644 > --- a/accel/xen/xen-all.c > +++ b/accel/xen/xen-all.c > @@ -122,7 +122,7 @@ static void xenstore_record_dm_state(struct xs_handle *xs, const char *state) > } > > > -static void xen_change_state_handler(void *opaque, int running, > +static void xen_change_state_handler(void *opaque, bool running, > RunState state) > { > if (running) { > diff --git a/audio/audio.c b/audio/audio.c > index b48471bb3f6..f2d56e7e57d 100644 > --- a/audio/audio.c > +++ b/audio/audio.c > @@ -1549,7 +1549,7 @@ static int audio_driver_init(AudioState *s, struct audio_driver *drv, > } > } > > -static void audio_vm_change_state_handler (void *opaque, int running, > +static void audio_vm_change_state_handler (void *opaque, bool running, > RunState state) > { > AudioState *s = opaque; > diff --git a/block/block-backend.c b/block/block-backend.c > index ce78d30794a..9175eb237a2 100644 > --- a/block/block-backend.c > +++ b/block/block-backend.c > @@ -163,7 +163,7 @@ static const char *blk_root_get_name(BdrvChild *child) > return blk_name(child->opaque); > } > > -static void blk_vm_state_changed(void *opaque, int running, RunState state) > +static void blk_vm_state_changed(void *opaque, bool running, RunState state) > { > Error *local_err = NULL; > BlockBackend *blk = opaque; > diff --git a/gdbstub.c b/gdbstub.c > index d99bc0bf2ea..9f2998f8d03 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -2691,7 +2691,7 @@ void gdb_set_stop_cpu(CPUState *cpu) > } > > #ifndef CONFIG_USER_ONLY > -static void gdb_vm_state_change(void *opaque, int running, RunState state) > +static void gdb_vm_state_change(void *opaque, bool running, RunState state) > { > CPUState *cpu = gdbserver_state.c_cpu; > g_autoptr(GString) buf = g_string_new(NULL); > diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c > index ccf326793db..badcbccf012 100644 > --- a/hw/block/pflash_cfi01.c > +++ b/hw/block/pflash_cfi01.c > @@ -1014,7 +1014,7 @@ void pflash_cfi01_legacy_drive(PFlashCFI01 *fl, DriveInfo *dinfo) > loc_pop(&loc); > } > > -static void postload_update_cb(void *opaque, int running, RunState state) > +static void postload_update_cb(void *opaque, bool running, RunState state) > { > PFlashCFI01 *pfl = opaque; > > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > index bac2d6fa2b2..5207ef617f0 100644 > --- a/hw/block/virtio-blk.c > +++ b/hw/block/virtio-blk.c > @@ -870,7 +870,7 @@ static void virtio_blk_dma_restart_bh(void *opaque) > virtio_blk_process_queued_requests(s, true); > } > > -static void virtio_blk_dma_restart_cb(void *opaque, int running, > +static void virtio_blk_dma_restart_cb(void *opaque, bool running, > RunState state) > { > VirtIOBlock *s = opaque; > diff --git a/hw/display/qxl.c b/hw/display/qxl.c > index 431c1070967..d22e84ba13e 100644 > --- a/hw/display/qxl.c > +++ b/hw/display/qxl.c > @@ -1992,7 +1992,7 @@ static void qxl_dirty_surfaces(PCIQXLDevice *qxl) > } > } > > -static void qxl_vm_change_state_handler(void *opaque, int running, > +static void qxl_vm_change_state_handler(void *opaque, bool running, > RunState state) > { > PCIQXLDevice *qxl = opaque; > diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c > index 2d8a3663693..51872dd84c0 100644 > --- a/hw/i386/kvm/clock.c > +++ b/hw/i386/kvm/clock.c > @@ -162,7 +162,7 @@ static void do_kvmclock_ctrl(CPUState *cpu, run_on_cpu_data data) > } > } > > -static void kvmclock_vm_state_change(void *opaque, int running, > +static void kvmclock_vm_state_change(void *opaque, bool running, > RunState state) > { > KVMClockState *s = opaque; > diff --git a/hw/i386/kvm/i8254.c b/hw/i386/kvm/i8254.c > index c73254e8866..c558893961b 100644 > --- a/hw/i386/kvm/i8254.c > +++ b/hw/i386/kvm/i8254.c > @@ -239,7 +239,7 @@ static void kvm_pit_irq_control(void *opaque, int n, int enable) > kvm_pit_put(pit); > } > > -static void kvm_pit_vm_state_change(void *opaque, int running, > +static void kvm_pit_vm_state_change(void *opaque, bool running, > RunState state) > { > KVMPITState *s = opaque; > diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c > index 2c1898032e4..46315445d22 100644 > --- a/hw/i386/kvmvapic.c > +++ b/hw/i386/kvmvapic.c > @@ -748,7 +748,7 @@ static void do_vapic_enable(CPUState *cs, run_on_cpu_data data) > s->state = VAPIC_ACTIVE; > } > > -static void kvmvapic_vm_state_change(void *opaque, int running, > +static void kvmvapic_vm_state_change(void *opaque, bool running, > RunState state) > { > MachineState *ms = MACHINE(qdev_get_machine()); > diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c > index 68821d90f52..7ce672e5a5c 100644 > --- a/hw/i386/xen/xen-hvm.c > +++ b/hw/i386/xen/xen-hvm.c > @@ -1235,7 +1235,7 @@ static void xen_main_loop_prepare(XenIOState *state) > } > > > -static void xen_hvm_change_state_handler(void *opaque, int running, > +static void xen_hvm_change_state_handler(void *opaque, bool running, > RunState rstate) > { > XenIOState *state = opaque; > diff --git a/hw/ide/core.c b/hw/ide/core.c > index b49e4cfbc6c..b5c6e967b2e 100644 > --- a/hw/ide/core.c > +++ b/hw/ide/core.c > @@ -2677,7 +2677,7 @@ static void ide_restart_bh(void *opaque) > } > } > > -static void ide_restart_cb(void *opaque, int running, RunState state) > +static void ide_restart_cb(void *opaque, bool running, RunState state) > { > IDEBus *bus = opaque; > > diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c > index 057cb53f13c..b554d2ede0a 100644 > --- a/hw/intc/arm_gicv3_its_kvm.c > +++ b/hw/intc/arm_gicv3_its_kvm.c > @@ -71,7 +71,7 @@ static int kvm_its_send_msi(GICv3ITSState *s, uint32_t value, uint16_t devid) > * > * The tables get flushed to guest RAM whenever the VM gets stopped. > */ > -static void vm_change_state_handler(void *opaque, int running, > +static void vm_change_state_handler(void *opaque, bool running, > RunState state) > { > GICv3ITSState *s = (GICv3ITSState *)opaque; > diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c > index d040a5d1e99..65a4c880a35 100644 > --- a/hw/intc/arm_gicv3_kvm.c > +++ b/hw/intc/arm_gicv3_kvm.c > @@ -743,7 +743,7 @@ static const ARMCPRegInfo gicv3_cpuif_reginfo[] = { > * > * The tables get flushed to guest RAM whenever the VM gets stopped. > */ > -static void vm_change_state_handler(void *opaque, int running, > +static void vm_change_state_handler(void *opaque, bool running, > RunState state) > { > GICv3State *s = (GICv3State *)opaque; > diff --git a/hw/intc/spapr_xive_kvm.c b/hw/intc/spapr_xive_kvm.c > index acc8c3650c4..c0083311607 100644 > --- a/hw/intc/spapr_xive_kvm.c > +++ b/hw/intc/spapr_xive_kvm.c > @@ -504,7 +504,7 @@ static int kvmppc_xive_get_queues(SpaprXive *xive, Error **errp) > * runs again. If an interrupt was queued while the VM was stopped, > * simply generate a trigger. > */ > -static void kvmppc_xive_change_state_handler(void *opaque, int running, > +static void kvmppc_xive_change_state_handler(void *opaque, bool running, > RunState state) > { > SpaprXive *xive = opaque; > diff --git a/hw/misc/mac_via.c b/hw/misc/mac_via.c > index 488d086a17c..ca2f939dd58 100644 > --- a/hw/misc/mac_via.c > +++ b/hw/misc/mac_via.c > @@ -1098,7 +1098,7 @@ static void mac_via_init(Object *obj) > TYPE_ADB_BUS, DEVICE(obj), "adb.0"); > } > > -static void postload_update_cb(void *opaque, int running, RunState state) > +static void postload_update_cb(void *opaque, bool running, RunState state) > { > MacVIAState *m = MAC_VIA(opaque); > > diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c > index 4dcb92d966b..b75f2ab8fc1 100644 > --- a/hw/net/e1000e_core.c > +++ b/hw/net/e1000e_core.c > @@ -3298,7 +3298,7 @@ e1000e_autoneg_resume(E1000ECore *core) > } > > static void > -e1000e_vm_state_change(void *opaque, int running, RunState state) > +e1000e_vm_state_change(void *opaque, bool running, RunState state) > { > E1000ECore *core = opaque; > > diff --git a/hw/nvram/spapr_nvram.c b/hw/nvram/spapr_nvram.c > index 9e51bc82ae4..01f77520146 100644 > --- a/hw/nvram/spapr_nvram.c > +++ b/hw/nvram/spapr_nvram.c > @@ -217,7 +217,7 @@ static int spapr_nvram_pre_load(void *opaque) > return 0; > } > > -static void postload_update_cb(void *opaque, int running, RunState state) > +static void postload_update_cb(void *opaque, bool running, RunState state) > { > SpaprNvram *nvram = opaque; > > diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c > index 5cbbff1f8d0..bf28d6bfc8d 100644 > --- a/hw/ppc/ppc.c > +++ b/hw/ppc/ppc.c > @@ -1059,7 +1059,7 @@ static void timebase_load(PPCTimebase *tb) > } > } > > -void cpu_ppc_clock_vm_state_change(void *opaque, int running, > +void cpu_ppc_clock_vm_state_change(void *opaque, bool running, > RunState state) > { > PPCTimebase *tb = opaque; > diff --git a/hw/ppc/ppc_booke.c b/hw/ppc/ppc_booke.c > index 652a21b8064..974c0c8a752 100644 > --- a/hw/ppc/ppc_booke.c > +++ b/hw/ppc/ppc_booke.c > @@ -317,7 +317,7 @@ static void ppc_booke_timer_reset_handle(void *opaque) > * action will be taken. To avoid this we always clear the watchdog state when > * state changes to running. > */ > -static void cpu_state_change_handler(void *opaque, int running, RunState state) > +static void cpu_state_change_handler(void *opaque, bool running, RunState state) > { > PowerPCCPU *cpu = opaque; > CPUPPCState *env = &cpu->env; > diff --git a/hw/s390x/tod-kvm.c b/hw/s390x/tod-kvm.c > index 6e21d83181d..0b944774861 100644 > --- a/hw/s390x/tod-kvm.c > +++ b/hw/s390x/tod-kvm.c > @@ -78,7 +78,7 @@ static void kvm_s390_tod_set(S390TODState *td, const S390TOD *tod, Error **errp) > } > } > > -static void kvm_s390_tod_vm_state_change(void *opaque, int running, > +static void kvm_s390_tod_vm_state_change(void *opaque, bool running, > RunState state) > { > S390TODState *td = opaque; > diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c > index c349fb7f2d1..f990d5b3b03 100644 > --- a/hw/scsi/scsi-bus.c > +++ b/hw/scsi/scsi-bus.c > @@ -181,7 +181,7 @@ void scsi_req_retry(SCSIRequest *req) > req->retry = true; > } > > -static void scsi_dma_restart_cb(void *opaque, int running, RunState state) > +static void scsi_dma_restart_cb(void *opaque, bool running, RunState state) > { > SCSIDevice *s = opaque; > > diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c > index aca018d8b5f..98d08c325ea 100644 > --- a/hw/usb/hcd-ehci.c > +++ b/hw/usb/hcd-ehci.c > @@ -2436,7 +2436,7 @@ static int usb_ehci_post_load(void *opaque, int version_id) > return 0; > } > > -static void usb_ehci_vm_state_change(void *opaque, int running, RunState state) > +static void usb_ehci_vm_state_change(void *opaque, bool running, RunState state) > { > EHCIState *ehci = opaque; > > diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c > index b950501d100..ecbf3f66f42 100644 > --- a/hw/usb/host-libusb.c > +++ b/hw/usb/host-libusb.c > @@ -1755,7 +1755,7 @@ type_init(usb_host_register_types) > static QEMUTimer *usb_auto_timer; > static VMChangeStateEntry *usb_vmstate; > > -static void usb_host_vm_state(void *unused, int running, RunState state) > +static void usb_host_vm_state(void *unused, bool running, RunState state) > { > if (running) { > usb_host_auto_check(unused); > diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c > index 7e9e3fecbfe..17f06f34179 100644 > --- a/hw/usb/redirect.c > +++ b/hw/usb/redirect.c > @@ -1395,7 +1395,7 @@ static void usbredir_chardev_event(void *opaque, QEMUChrEvent event) > * init + destroy > */ > > -static void usbredir_vm_state_change(void *priv, int running, RunState state) > +static void usbredir_vm_state_change(void *priv, bool running, RunState state) > { > USBRedirDevice *dev = priv; > > diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c > index 00daa50ed81..134bdccc4f8 100644 > --- a/hw/vfio/migration.c > +++ b/hw/vfio/migration.c > @@ -727,7 +727,7 @@ static SaveVMHandlers savevm_vfio_handlers = { > > /* ---------------------------------------------------------------------- */ > > -static void vfio_vmstate_change(void *opaque, int running, RunState state) > +static void vfio_vmstate_change(void *opaque, bool running, RunState state) > { > VFIODevice *vbasedev = opaque; > VFIOMigration *migration = vbasedev->migration; > diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c > index 76ce9376931..cc8e9f775d8 100644 > --- a/hw/virtio/virtio-rng.c > +++ b/hw/virtio/virtio-rng.c > @@ -133,7 +133,7 @@ static uint64_t get_features(VirtIODevice *vdev, uint64_t f, Error **errp) > return f; > } > > -static void virtio_rng_vm_state_change(void *opaque, int running, > +static void virtio_rng_vm_state_change(void *opaque, bool running, > RunState state) > { > VirtIORNG *vrng = opaque; > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index b308026596f..38dc623c89e 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -3208,7 +3208,7 @@ void virtio_cleanup(VirtIODevice *vdev) > qemu_del_vm_change_state_handler(vdev->vmstate); > } > > -static void virtio_vmstate_change(void *opaque, int running, RunState state) > +static void virtio_vmstate_change(void *opaque, bool running, RunState state) > { > VirtIODevice *vdev = opaque; > BusState *qbus = qdev_get_parent_bus(DEVICE(vdev)); > diff --git a/net/net.c b/net/net.c > index e1035f21d18..8a85d1e3f7b 100644 > --- a/net/net.c > +++ b/net/net.c > @@ -1341,7 +1341,7 @@ void qmp_set_link(const char *name, bool up, Error **errp) > } > } > > -static void net_vm_change_state_handler(void *opaque, int running, > +static void net_vm_change_state_handler(void *opaque, bool running, > RunState state) > { > NetClientState *nc; > diff --git a/softmmu/memory.c b/softmmu/memory.c > index 333e1ed7b05..ab7f2e5aa07 100644 > --- a/softmmu/memory.c > +++ b/softmmu/memory.c > @@ -2675,7 +2675,7 @@ static void memory_global_dirty_log_do_stop(void) > MEMORY_LISTENER_CALL_GLOBAL(log_global_stop, Reverse); > } > > -static void memory_vm_change_state_handler(void *opaque, int running, > +static void memory_vm_change_state_handler(void *opaque, bool running, > RunState state) > { > if (running) { > diff --git a/softmmu/runstate.c b/softmmu/runstate.c > index c7a67147d17..cb07a65925c 100644 > --- a/softmmu/runstate.c > +++ b/softmmu/runstate.c > @@ -316,7 +316,7 @@ void qemu_del_vm_change_state_handler(VMChangeStateEntry *e) > g_free(e); > } > > -void vm_state_notify(int running, RunState state) > +void vm_state_notify(bool running, RunState state) > { > VMChangeStateEntry *e, *next; > > diff --git a/target/arm/kvm.c b/target/arm/kvm.c > index ffe186de8d1..53d6c4a17eb 100644 > --- a/target/arm/kvm.c > +++ b/target/arm/kvm.c > @@ -844,7 +844,7 @@ MemTxAttrs kvm_arch_post_run(CPUState *cs, struct kvm_run *run) > return MEMTXATTRS_UNSPECIFIED; > } > > -void kvm_arm_vm_state_change(void *opaque, int running, RunState state) > +void kvm_arm_vm_state_change(void *opaque, bool running, RunState state) > { > CPUState *cs = opaque; > ARMCPU *cpu = ARM_CPU(cs); > diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c > index 6dc1ee052d5..170ad55c09c 100644 > --- a/target/i386/kvm/kvm.c > +++ b/target/i386/kvm/kvm.c > @@ -690,7 +690,7 @@ static int kvm_inject_mce_oldstyle(X86CPU *cpu) > return 0; > } > > -static void cpu_update_state(void *opaque, int running, RunState state) > +static void cpu_update_state(void *opaque, bool running, RunState state) > { > CPUX86State *env = opaque; > > diff --git a/target/i386/sev.c b/target/i386/sev.c > index 15466068118..e7890f61906 100644 > --- a/target/i386/sev.c > +++ b/target/i386/sev.c > @@ -670,7 +670,7 @@ sev_launch_finish(SevGuestState *sev) > } > > static void > -sev_vm_state_change(void *opaque, int running, RunState state) > +sev_vm_state_change(void *opaque, bool running, RunState state) > { > SevGuestState *sev = opaque; > > diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c > index 3b824fc9d7c..850dfe72e75 100644 > --- a/target/i386/whpx/whpx-all.c > +++ b/target/i386/whpx/whpx-all.c > @@ -1318,7 +1318,7 @@ void whpx_cpu_synchronize_pre_loadvm(CPUState *cpu) > > static Error *whpx_migration_blocker; > > -static void whpx_cpu_update_state(void *opaque, int running, RunState state) > +static void whpx_cpu_update_state(void *opaque, bool running, RunState state) > { > CPUX86State *env = opaque; > > diff --git a/target/mips/kvm.c b/target/mips/kvm.c > index 477692566a4..09945ad2455 100644 > --- a/target/mips/kvm.c > +++ b/target/mips/kvm.c > @@ -37,7 +37,7 @@ const KVMCapabilityInfo kvm_arch_required_capabilities[] = { > KVM_CAP_LAST_INFO > }; > > -static void kvm_mips_update_state(void *opaque, int running, RunState state); > +static void kvm_mips_update_state(void *opaque, bool running, RunState state); > > unsigned long kvm_arch_vcpu_id(CPUState *cs) > { > @@ -552,7 +552,7 @@ static int kvm_mips_restore_count(CPUState *cs) > /* > * Handle the VM clock being started or stopped > */ > -static void kvm_mips_update_state(void *opaque, int running, RunState state) > +static void kvm_mips_update_state(void *opaque, bool running, RunState state) > { > CPUState *cs = opaque; > int ret; > diff --git a/ui/gtk.c b/ui/gtk.c > index a752aa22be0..a5bf8ed8429 100644 > --- a/ui/gtk.c > +++ b/ui/gtk.c > @@ -672,7 +672,7 @@ static const DisplayChangeListenerOps dcl_egl_ops = { > > /** QEMU Events **/ > > -static void gd_change_runstate(void *opaque, int running, RunState state) > +static void gd_change_runstate(void *opaque, bool running, RunState state) > { > GtkDisplayState *s = opaque; > > diff --git a/ui/spice-core.c b/ui/spice-core.c > index 5746d0aae7c..22c77c04151 100644 > --- a/ui/spice-core.c > +++ b/ui/spice-core.c > @@ -622,7 +622,7 @@ static int add_channel(void *opaque, const char *name, const char *value, > return 0; > } > > -static void vm_change_state_handler(void *opaque, int running, > +static void vm_change_state_handler(void *opaque, bool running, > RunState state) > { > if (running) { > Applied to my trivial-patches branch. Thanks, Laurent From xen-devel-bounces@lists.xenproject.org Tue Mar 09 22:24:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 22:24:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95812.180851 (Exim 4.92) (envelope-from ) id 1lJklt-0006jW-2K; Tue, 09 Mar 2021 22:24:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95812.180851; Tue, 09 Mar 2021 22:24:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJkls-0006jP-VV; Tue, 09 Mar 2021 22:24:08 +0000 Received: by outflank-mailman (input) for mailman id 95812; Tue, 09 Mar 2021 22:24:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJklr-0006jK-QC for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 22:24:07 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fbf24275-6c78-45f2-9396-20a248d749b7; Tue, 09 Mar 2021 22:24:06 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A0116650BA; Tue, 9 Mar 2021 22:24:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fbf24275-6c78-45f2-9396-20a248d749b7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615328646; bh=m/vW3pChpzsOuDCWjRf8ntpoE1BgCPYKFDJvxyYH01A=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=CCtypWjn389pz8LlmIIbt096V38n3neeXPkg6NZHcRMexskURrWdAJt+Ng8XiuUE9 biZv2Rxrg7xfILtxBwoWJA9SWnfu4gZsdNC1dSBlpFxyAlKn7FAM20jvkUb+ursoLQ VY+q/MlI3x1uR4B7E9i6fvka7TE+S+BkIxJ+5PYqmKsbz1FyN65baVXoRsKkBKmNbS STBa/M1RWdJHVfk1BcDeKLKMu0jW8CCWWc803n5/j0Y3dVt9w1oy9ZOza2jxRE28/K gF2T73ApJVJHZd9G66cPIhzyAd5NnaeMme+glEjrekt24WFDkdnjN3QuC6YfFwnpqU o7urXzrQ4qw8g== Date: Tue, 9 Mar 2021 14:24:05 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= cc: Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, famzheng@amazon.com, cardoe@cardoe.com, wl@xen.org, Bertrand.Marquis@arm.com, andrew.cooper3@citrix.com, George Dunlap , Anthony PERARD Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) In-Reply-To: Message-ID: References: <161507188317.11025.6744028462008264481@c667a6b167f6> <10b8048a-e8fe-1fcd-7291-7f1b16da2f4c@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1936489669-1615328646=:16374" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1936489669-1615328646=:16374 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 9 Mar 2021, Roger Pau Monné wrote: > On Tue, Mar 09, 2021 at 10:05:18AM +0000, Julien Grall wrote: > > Hi Stefano, > > > > On 09/03/2021 00:59, Stefano Stabellini wrote: > > > On Sun, 7 Mar 2021, Julien Grall wrote: > > > > On 06/03/2021 23:04, no-reply@patchew.org wrote: > > Where does one has to register to get the patchew build failures? By asking Fam (CC'ed) very nicely :-) --8323329-1936489669-1615328646=:16374-- From xen-devel-bounces@lists.xenproject.org Tue Mar 09 22:25:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 22:25:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95817.180863 (Exim 4.92) (envelope-from ) id 1lJkne-0006rb-IE; Tue, 09 Mar 2021 22:25:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95817.180863; Tue, 09 Mar 2021 22:25:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJkne-0006rU-Ex; Tue, 09 Mar 2021 22:25:58 +0000 Received: by outflank-mailman (input) for mailman id 95817; Tue, 09 Mar 2021 22:25:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJknd-0006r2-3S; Tue, 09 Mar 2021 22:25:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJknc-0000ea-Rw; Tue, 09 Mar 2021 22:25:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJknc-0004I0-Im; Tue, 09 Mar 2021 22:25:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJknc-00022O-IC; Tue, 09 Mar 2021 22:25:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XFLC/gQ2zgm9ov6gAfoVzZHtkAHqi17bWTwboHa9dow=; b=Cfsk51zZDDalgD15UwXb2Ze8V6 aqFLwlurB5MVQ6IVJFyjCdkhPZQEdkaXekrf9RRNorl5qQ/Oidgtw100MpU6llZAwfIlCoJ3AHzs1 vgPxtm6zTC46HXPnTz1Ypm/ND0h+IyTWRz4Zl2x+0KvKEsjvD/OO3XHizFBQQWdMp/TE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 159890: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=84d5d3c9d3fbcee10bc16d3a3316af9a924c91c6 X-Osstest-Versions-That: linux=c4ca4659678e07f0a14b3b143f6fb746efe11f88 From: osstest service owner Date: Tue, 09 Mar 2021 22:25:56 +0000 flight 159890 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/159890/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159859 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159859 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159859 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159859 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159859 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159859 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159859 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159859 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 159859 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159859 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159859 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159859 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: linux 84d5d3c9d3fbcee10bc16d3a3316af9a924c91c6 baseline version: linux c4ca4659678e07f0a14b3b143f6fb746efe11f88 Last test of basis 159859 2021-03-07 11:40:35 Z 2 days Testing same since 159890 2021-03-09 10:39:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Antonio Borneo Ard Biesheuvel Armin Wolf Casey Schaufler Chen Jun Colin Ian King Dan Carpenter Dan Carpenter David S. Miller David Sterba Elaine Zhang Filipe Manana Florian Fainelli Greg Kroah-Hartman Guenter Roeck Heiner Kallweit Herbert Xu Hulk Robot Ira Weiny Jarkko Sakkinen Jason Gunthorpe Jason Self Jens Axboe Jon Hunter Julian Braha Jérôme Carretero Kevin Wang Leon Romanovsky Linux Kernel Functional Testing Lukasz Majczak Mike Snitzer Mikulas Patocka Milan Broz Nikolay Borisov Pierre-Louis Bossart Rafael J. Wysocki Sasha Levin Shuah Khan Steven Rostedt (VMware) Sudeep Holla Takashi Iwai Timothy E Baldwin Will Deacon YueHaibing jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git c4ca4659678e..84d5d3c9d3fb 84d5d3c9d3fbcee10bc16d3a3316af9a924c91c6 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Tue Mar 09 22:35:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 22:35:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95823.180877 (Exim 4.92) (envelope-from ) id 1lJkww-0007rt-G6; Tue, 09 Mar 2021 22:35:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95823.180877; Tue, 09 Mar 2021 22:35:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJkww-0007rm-DD; Tue, 09 Mar 2021 22:35:34 +0000 Received: by outflank-mailman (input) for mailman id 95823; Tue, 09 Mar 2021 22:35:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJkwv-0007rh-Cb for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 22:35:33 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f6239356-4ecd-4403-88e2-8d5e3072ec97; Tue, 09 Mar 2021 22:35:32 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id CDEA165100; Tue, 9 Mar 2021 22:35:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6239356-4ecd-4403-88e2-8d5e3072ec97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615329332; bh=VN9rZoWbHkLdYDlNXm4OHg/xd2sYDympEa+yPJV165I=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=HDx/84d5HDbiTMts7VoaS1jCvn0FyZxx4ySh5tNmm/I1noPq4EzFiQtWdfV19OHoD I91RShh4lXyBgYuH7hVuPB+HmRtgKLWhhzeOqTanMxLiOSDBgxRKy1PxNlt/KBnKNy yMtId5xQBQR43YRqUei6XopmhB8n6DU6Orcwn/ePEsA8JMHeKW0NB5XpCf7BUnXVVa wEOxeZ/1a2sUyFqyzw1IamrPJHy61AokA1+YzPHnoTCKWCotuFcShxDzkdqKWIgh7b TFR2DJ4rVBXh6VG/MWeQqsT8ekTfvUSoeyG7yXK+NELnMXQpj2t5ePm+RLs+9dV8iJ EyVErxeGk9t6Q== Date: Tue, 9 Mar 2021 14:35:31 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] Xen: drop exports of {set,clear}_foreign_p2m_mapping() In-Reply-To: <746a5cd6-1446-eda4-8b23-03c1cac30b8d@suse.com> Message-ID: References: <746a5cd6-1446-eda4-8b23-03c1cac30b8d@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 9 Mar 2021, Jan Beulich wrote: > They're only used internally, and the layering violation they contain > (x86) or imply (Arm) of calling HYPERVISOR_grant_table_op() strongly > advise against any (uncontrolled) use from a module. The functions also > never had users except the ones from drivers/xen/grant-table.c forever > since their introduction in 3.15. > > Signed-off-by: Jan Beulich Reviewed-by: Stefano Stabellini > --- > It's not clear to me why Arm doesn't have merely stubs just like x86 has > when PV support is disabled. ARM implements the two functions to keep track of foreign pages mapped into the system. It uses swiotlb-xen to translate gfn to mfn for foreign pages. Local pages are 1:1. This way, an IOMMU is not required. > --- a/arch/arm/xen/p2m.c > +++ b/arch/arm/xen/p2m.c > @@ -130,7 +130,6 @@ int set_foreign_p2m_mapping(struct gntta > > return 0; > } > -EXPORT_SYMBOL_GPL(set_foreign_p2m_mapping); > > int clear_foreign_p2m_mapping(struct gnttab_unmap_grant_ref *unmap_ops, > struct gnttab_unmap_grant_ref *kunmap_ops, > @@ -145,7 +144,6 @@ int clear_foreign_p2m_mapping(struct gnt > > return 0; > } > -EXPORT_SYMBOL_GPL(clear_foreign_p2m_mapping); > > bool __set_phys_to_machine_multi(unsigned long pfn, > unsigned long mfn, unsigned long nr_pages) > --- a/arch/x86/xen/p2m.c > +++ b/arch/x86/xen/p2m.c > @@ -776,7 +776,6 @@ int set_foreign_p2m_mapping(struct gntta > out: > return ret; > } > -EXPORT_SYMBOL_GPL(set_foreign_p2m_mapping); > > int clear_foreign_p2m_mapping(struct gnttab_unmap_grant_ref *unmap_ops, > struct gnttab_unmap_grant_ref *kunmap_ops, > @@ -802,7 +801,6 @@ int clear_foreign_p2m_mapping(struct gnt > > return ret; > } > -EXPORT_SYMBOL_GPL(clear_foreign_p2m_mapping); > > #ifdef CONFIG_XEN_DEBUG_FS > #include > From xen-devel-bounces@lists.xenproject.org Tue Mar 09 22:44:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 09 Mar 2021 22:44:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95826.180889 (Exim 4.92) (envelope-from ) id 1lJl5H-0000Pn-Av; Tue, 09 Mar 2021 22:44:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95826.180889; Tue, 09 Mar 2021 22:44:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJl5H-0000Pg-82; Tue, 09 Mar 2021 22:44:11 +0000 Received: by outflank-mailman (input) for mailman id 95826; Tue, 09 Mar 2021 22:44:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJl5G-0000Pb-Kv for xen-devel@lists.xenproject.org; Tue, 09 Mar 2021 22:44:10 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f1739289-9f18-4739-8eed-45cf74165beb; Tue, 09 Mar 2021 22:44:09 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id AF9F5650FD; Tue, 9 Mar 2021 22:44:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1739289-9f18-4739-8eed-45cf74165beb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615329849; bh=d8xIRX0RtCjsSAfrzN3mwsU8YemgIC4uP3zO6GCviMw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=nnT+x7HVDzEFqQS3Io8TUhH9vpJSIn/8YlliOCLGN5/8+CMcjfY35AZ3cIqmJYdYN oKdV68FcbkL2FgoIrR6Qe2rcyNe3SpJyRuokget2gFB2gqpiHIWxDTUaIOWTYJGH/T WDmgFWNpkkLgu4/hm4D/JxPN0YllmUt8VVNan2aBMHzWeYtweTyzS3y4HNlROtL4Uz sbkBj4pIdPlg8Mk68cL1gv/Lk3MMLQekSAyIHdqyo8InvNCNgtfXZx/64Cc4dhcFFx zaFUFkbJKnLuP9rKDwEsMYhDW9odo/9inM8tqzkkzgFDizXUjWyaj50rklVUAWEK7u dfjD3JGLZK+Hg== Date: Tue, 9 Mar 2021 14:44:08 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Andrew Cooper cc: Elliott Mitchell , xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Juergen Gross Subject: Re: [PATCH for-4.15] arm: replace typeof() with __typeof__() In-Reply-To: Message-ID: References: <202103092114.129LEgZp059925@m5p.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 9 Mar 2021, Andrew Cooper wrote: > On 08/03/2021 13:36, Elliott Mitchell wrote: > > typeof() is available in Xen's build environment, which uses Xen's > > compiler. As these headers are public, they need strict standards > > conformance. Only __typeof__() is officially standardized. > > > > A compiler in standards conformance mode should report: > > > > warning: implicit declaration of function 'typeof' is invalid in C99 > > [-Wimplicit-function-declaration] > > > > (this has been observed with FreeBSD's kernel build environment) > > > > Based-on-patch-by: Julien Grall , Sun Oct 4 20:33:04 2015 +0100 > > Signed-off-by: Elliott Mitchell > > s!arm!xen/public! in the subject seeing as two thirds of the > modifications are in non-ARM headers. > > Acked-by: Andrew Cooper Reviewed-by: Stefano Stabellini > This wants backporting as a build fix, so should be considered for 4.15 > at this point. +1 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 02:54:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 02:54:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95844.180914 (Exim 4.92) (envelope-from ) id 1lJozJ-00008p-GQ; Wed, 10 Mar 2021 02:54:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95844.180914; Wed, 10 Mar 2021 02:54:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJozJ-00008g-8V; Wed, 10 Mar 2021 02:54:17 +0000 Received: by outflank-mailman (input) for mailman id 95844; Wed, 10 Mar 2021 02:54:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJozI-00008V-0K; Wed, 10 Mar 2021 02:54:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJozH-0007SY-Q4; Wed, 10 Mar 2021 02:54:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJozH-0000Lv-Fp; Wed, 10 Mar 2021 02:54:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJozH-0007OB-FG; Wed, 10 Mar 2021 02:54:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ilbz0Z0PMd76XhwwuXML2dKheVRnh2po1yyHnr2+Qfk=; b=eMm1C+4zDmekNvzQ7QBxSS9mTA U1DILk4HCM5xgEGaBEigNhBTJterAVCJVVqauV2CTkqymLoNVYcmznOWhGFdERyD0C8+8Txm3UVaY YlP3SAgFL9f5S+JYga/GgnY2ItTHrN0EwE7wtK3Hqo7AcffTx5y+NfJ69YpYDPw62dec=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159891: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=144c79ef33536b4ecb4951e07dbc1f2b7fa99d32 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Wed, 10 Mar 2021 02:54:15 +0000 flight 159891 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159891/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux 144c79ef33536b4ecb4951e07dbc1f2b7fa99d32 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 221 days Failing since 152366 2020-08-01 20:49:34 Z 220 days 381 attempts Testing same since 159870 2021-03-08 09:51:12 Z 1 days 3 attempts ------------------------------------------------------------ 5158 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1278139 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 10 03:25:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 03:25:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95852.180929 (Exim 4.92) (envelope-from ) id 1lJpSu-0002vQ-QG; Wed, 10 Mar 2021 03:24:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95852.180929; Wed, 10 Mar 2021 03:24:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJpSu-0002vJ-MI; Wed, 10 Mar 2021 03:24:52 +0000 Received: by outflank-mailman (input) for mailman id 95852; Wed, 10 Mar 2021 03:24:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJpSt-0002vE-J7 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 03:24:51 +0000 Received: from mailhost.m5p.com (unknown [74.104.188.4]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 140ff447-608e-416e-9243-966fd0755461; Wed, 10 Mar 2021 03:24:50 +0000 (UTC) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 12A3OXFc061128 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 9 Mar 2021 22:24:39 -0500 (EST) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 12A3OWB0061127; Tue, 9 Mar 2021 19:24:32 -0800 (PST) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 140ff447-608e-416e-9243-966fd0755461 Date: Tue, 9 Mar 2021 19:24:32 -0800 From: Elliott Mitchell To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Juergen Gross Subject: Re: [PATCH for-4.15] arm: replace typeof() with __typeof__() Message-ID: References: <202103092114.129LEgZp059925@m5p.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mattapan.m5p.com On Tue, Mar 09, 2021 at 09:27:34PM +0000, Andrew Cooper wrote: > On 08/03/2021 13:36, Elliott Mitchell wrote: > > typeof() is available in Xen's build environment, which uses Xen's > > compiler. As these headers are public, they need strict standards > > conformance. Only __typeof__() is officially standardized. > > > > A compiler in standards conformance mode should report: > > > > warning: implicit declaration of function 'typeof' is invalid in C99 > > [-Wimplicit-function-declaration] > > > > (this has been observed with FreeBSD's kernel build environment) > > > > Based-on-patch-by: Julien Grall , Sun Oct 4 20:33:04 2015 +0100 > > Signed-off-by: Elliott Mitchell > > s!arm!xen/public! in the subject seeing as two thirds of the > modifications are in non-ARM headers. Gah! Crucial little detail missing when rewriting the subject line. Julien Grall's original patch/commit only did ARM, but when I checked I found the other two and I did them too. > Acked-by: Andrew Cooper > > This wants backporting as a build fix, so should be considered for 4.15 > at this point. > > I wonder why our header checks don't pick this up.?? Do we need to throw > a -pedantic around? This came up since FreeBSD's kernel build uses Clang with -std=iso9899:1999. When I found FreeBSD was simply copying Xen's headers it was clear this needed to be *here*. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 06:07:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 06:07:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95856.180941 (Exim 4.92) (envelope-from ) id 1lJs02-0000kH-55; Wed, 10 Mar 2021 06:07:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95856.180941; Wed, 10 Mar 2021 06:07:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJs02-0000kA-1a; Wed, 10 Mar 2021 06:07:14 +0000 Received: by outflank-mailman (input) for mailman id 95856; Wed, 10 Mar 2021 06:07:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJs00-0000k5-Pf for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 06:07:12 +0000 Received: from mail.skyhub.de (unknown [5.9.137.197]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ad481ac3-204b-4ed9-97c0-e238f8d67c5a; Wed, 10 Mar 2021 06:07:11 +0000 (UTC) Received: from zn.tnic (p200300ec2f0a99002de44af59edd037d.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:9900:2de4:4af5:9edd:37d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E62DF1EC0473; Wed, 10 Mar 2021 07:07:09 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad481ac3-204b-4ed9-97c0-e238f8d67c5a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1615356430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=BzBbQnXUuiDK+nmPzIwIGL4n/Loc18opf7QU0fcWCJI=; b=EFBzBnX3lsz0uqv3rvfnAcgyzAPvVERZQvmn6qwVVk3XZ7ShVAeGR0lCSjJr6bRb2Z6d5m loNpBlkOf+e6lbtfnVNg9sMVA12nr5iwtTNQ4pYnEi+mB9nQxRqVvotZuQGZvt5WwBhuqD 676DJkplf/Co08k5EvawCocwKqd5DV0= Date: Wed, 10 Mar 2021 07:07:05 +0100 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Subject: Re: [PATCH v6 04/12] x86/alternative: support not-feature Message-ID: <20210310060705.GB23521@zn.tnic> References: <20210309134813.23912-1-jgross@suse.com> <20210309134813.23912-5-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210309134813.23912-5-jgross@suse.com> On Tue, Mar 09, 2021 at 02:48:05PM +0100, Juergen Gross wrote: > Add support for alternative patching for the case a feature is not > present on the current cpu. > > For users of ALTERNATIVE() and friends an inverted feature is specified > by applying the ALT_NOT() macro to it, e.g.: > > ALTERNATIVE(old, new, ALT_NOT(feature)) > > Signed-off-by: Juergen Gross > --- > V5: > - split off from next patch > - reworked to use flag byte (Boris Petkov) > V6: > - rework again to not use flag byte (Boris Petkov) > --- > arch/x86/include/asm/alternative-asm.h | 3 +++ > arch/x86/include/asm/alternative.h | 3 +++ > arch/x86/kernel/alternative.c | 19 ++++++++++++++----- > 3 files changed, 20 insertions(+), 5 deletions(-) LGTM, minor touchups I'd do ontop: --- diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h index 89889618ae01..fd205cdcfbad 100644 --- a/arch/x86/include/asm/alternative.h +++ b/arch/x86/include/asm/alternative.h @@ -55,18 +55,18 @@ ".long 999b - .\n\t" \ ".popsection\n\t" +#define ALTINSTR_FLAG_INV (1 << 15) +#define ALT_NOT(feat) ((feat) | ALTINSTR_FLAG_INV) + struct alt_instr { s32 instr_offset; /* original instruction */ s32 repl_offset; /* offset to replacement instruction */ u16 cpuid; /* cpuid bit set for replacement */ -#define ALTINSTR_FLAG_INV (1 << 15) u8 instrlen; /* length of original instruction */ u8 replacementlen; /* length of new instruction */ u8 padlen; /* length of build-time padding */ } __packed; -#define ALT_NOT(feat) ((feat) | ALTINSTR_FLAG_INV) - /* * Debug flag that can be tested to see whether alternative * instructions were patched in already: diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index d8e669a1546f..133b549dc091 100644 --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -397,9 +397,10 @@ void __init_or_module noinline apply_alternatives(struct alt_instr *start, BUG_ON(feature >= (NCAPINTS + NBUGINTS) * 32); /* - * Drop out if either: - * - feature not available, but required, or - * - feature available, but NOT required + * Patch if either: + * - feature is present + * - feature not present but ALTINSTR_FLAG_INV is set to mean, + * patch if feature is *NOT* present. */ if (!boot_cpu_has(feature) == !(a->cpuid & ALTINSTR_FLAG_INV)) { if (a->padlen > 1) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Wed Mar 10 06:51:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 06:51:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95863.180968 (Exim 4.92) (envelope-from ) id 1lJsgS-0005CQ-OW; Wed, 10 Mar 2021 06:51:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95863.180968; Wed, 10 Mar 2021 06:51:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJsgS-0005CJ-LQ; Wed, 10 Mar 2021 06:51:04 +0000 Received: by outflank-mailman (input) for mailman id 95863; Wed, 10 Mar 2021 06:51:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJsgQ-0005By-Kl for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 06:51:02 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id d49f1c06-0e90-4f1b-afdd-b5a4e7b0965c; Wed, 10 Mar 2021 06:51:00 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E96061FB; Tue, 9 Mar 2021 22:50:59 -0800 (PST) Received: from [10.57.15.227] (unknown [10.57.15.227]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 424493F70D; Tue, 9 Mar 2021 22:50:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d49f1c06-0e90-4f1b-afdd-b5a4e7b0965c Subject: Re: [PATCH v2] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Jan Beulich Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org, Julien Grall References: <20210308135937.1692-1-michal.orzel@arm.com> <745c5049-fb09-5605-8bc1-838a4def45d6@xen.org> <3353ecf1-3a76-70ee-0475-b7eed90c783c@arm.com> <1a1c8cf1-4c41-7fe2-ef4c-4f92d5b956c8@suse.com> <4a2a8caa-fc13-e18d-6c60-02f3597dc9f9@arm.com> From: Michal Orzel Message-ID: Date: Wed, 10 Mar 2021 07:50:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09.03.2021 15:18, Jan Beulich wrote: > On 09.03.2021 14:55, Michal Orzel wrote: >> >> >> On 09.03.2021 14:32, Julien Grall wrote: >>> >>> >>> On 09/03/2021 11:07, Jan Beulich wrote: >>>> On 09.03.2021 11:20, Julien Grall wrote: >>>>> On 09/03/2021 07:34, Michal Orzel wrote: >>>>>> On 08.03.2021 15:31, Julien Grall wrote: >>>>>>> On 08/03/2021 13:59, Michal Orzel wrote: >>>>>>>> --- a/xen/arch/arm/Makefile >>>>>>>> +++ b/xen/arch/arm/Makefile >>>>>>>> @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o >>>>>>>>       #obj-bin-y += ....o >>>>>>>>     -ifdef CONFIG_DTB_FILE >>>>>>>> +ifneq ($(CONFIG_DTB_FILE),"") >>>>>>>>     obj-y += dtb.o >>>>>>>>     AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>>>>>>     endif >>>>>>>> @@ -137,8 +137,6 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >>>>>>>>     xen.lds: xen.lds.S >>>>>>>>         $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >>>>>>>>     -dtb.o: $(CONFIG_DTB_FILE) >>>>>>>> - >>>>>>> >>>>>>> Why is this dropped? >>>>>> 1)This line is not needed as it has no impact on creating dtb.o >>>>>> 2)It causes the build failure once CONFIG_DTB_FILE option is in the Kconfig as string within quotes. >>>>> >>>>> Because of 1), this should have ideally be part of a separate patch. But >>>>> I am OK to keep it in this patch so long it is explained in the commit >>>>> message. >>>> >>>> Wasn't the intention to have dtb.o re-compiled when the blob >>>> has changed? This would be lost with the removal of this line. >>> >>> Ah yes. I was only thinking about a name change (this would be caught via the update of the config header) and not a file update. >>> >> I already pushed v3 but I agree. Something like this would do the job: >> dtb.o: $(subst $\",,$(CONFIG_DTB_FILE)) >> to remove quotes > > Besides struggling with the $\", may I suggest > $(patsubst "%",%,$(CONFIG_DTB_FILE))? If the double quote needs > special treatment, I think it wants to be done via an abstraction > similar to squote (near the top of ./Config.mk). > The line $(patsubst "%",%,$(CONFIG_DTB_FILE)) is sufficient. I checked and dtb.o is recompiled when the blob is changed. I will fix it in v4 > Jan > Michal From xen-devel-bounces@lists.xenproject.org Wed Mar 10 06:58:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 06:58:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95866.180981 (Exim 4.92) (envelope-from ) id 1lJsng-0005TO-I4; Wed, 10 Mar 2021 06:58:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95866.180981; Wed, 10 Mar 2021 06:58:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJsng-0005TH-Eb; Wed, 10 Mar 2021 06:58:32 +0000 Received: by outflank-mailman (input) for mailman id 95866; Wed, 10 Mar 2021 06:58:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJsnf-0005TC-JS for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 06:58:31 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id c791f107-32bc-41e3-8be2-94aaaaebfb2e; Wed, 10 Mar 2021 06:58:30 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D07111FB; Tue, 9 Mar 2021 22:58:29 -0800 (PST) Received: from e123311-lin.arm.com (unknown [10.57.15.227]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F14873F70D; Tue, 9 Mar 2021 22:58:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c791f107-32bc-41e3-8be2-94aaaaebfb2e From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com Subject: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE Date: Wed, 10 Mar 2021 07:58:03 +0100 Message-Id: <20210310065803.348-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently in order to link existing DTB into Xen image we need to either specify option CONFIG_DTB_FILE on the command line or manually add it into .config. Add Kconfig entry: CONFIG_DTB_FILE to be able to provide the path to DTB we want to embed into Xen image. If no path provided - the dtb will not be embedded. Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" as it is not needed since Kconfig will define it in a header with all the other config options. Signed-off-by: Michal Orzel --- xen/arch/arm/Makefile | 5 ++--- xen/common/Kconfig | 8 ++++++++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 16e6523e2c..46e6a95fec 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -68,9 +68,8 @@ extra-y += $(TARGET_SUBARCH)/head.o #obj-bin-y += ....o -ifdef CONFIG_DTB_FILE +ifneq ($(CONFIG_DTB_FILE),"") obj-y += dtb.o -AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" endif ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c xen.lds: xen.lds.S $(CPP) -P $(a_flags) -MQ $@ -o $@ $< -dtb.o: $(CONFIG_DTB_FILE) +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) .PHONY: clean clean:: diff --git a/xen/common/Kconfig b/xen/common/Kconfig index eb953d171e..a27836bf47 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -400,6 +400,14 @@ config DOM0_MEM Leave empty if you are not sure what to specify. +config DTB_FILE + string "Absolute path to device tree blob" + depends on HAS_DEVICE_TREE + ---help--- + When using a bootloader that has no device tree support or when there + is no bootloader at all, use this option to specify the absolute path + to a device tree that will be linked directly inside Xen binary. + config TRACEBUFFER bool "Enable tracing infrastructure" if EXPERT default y -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 07:49:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 07:49:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95878.181002 (Exim 4.92) (envelope-from ) id 1lJtb3-0001cz-L7; Wed, 10 Mar 2021 07:49:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95878.181002; Wed, 10 Mar 2021 07:49:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJtb3-0001cs-I1; Wed, 10 Mar 2021 07:49:33 +0000 Received: by outflank-mailman (input) for mailman id 95878; Wed, 10 Mar 2021 07:49:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJtb1-0001ci-TJ for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 07:49:32 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9514d391-d566-4922-b2d9-8afcde969665; Wed, 10 Mar 2021 07:49:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9514d391-d566-4922-b2d9-8afcde969665 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615362570; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=ERaUF3hE5TkWVE0K1zQogibFQ0R3myO9yEuuhccJP/g=; b=aJx1orDo/C0wg3Tqw814GoPjXmMcB/yAbzJsg01ys3tbtr14z7KTYbTF +rxCUl4cr/4BINOt9xFqm1msuhvIBEtAuhNVNuTyNg+l+ova57z5hchiu NQ3j5wBxPzIUkTUP8s8DzPwGGlSI/6CAw7t21PYaXymnKRdU/LkzT3DEQ I=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: diq+iEhyD8zUhnkJhgA8xdr37BCoGItms7uLOMYaku9XkEvkx7/9uNmepFYrV5lkOGFeX2RV7e QCpg3M/sRQa3JGiEysyHF0aIGtKHqa2K6rUinytAmZ5Yr4dT3A+rg8FlFxAvuRhKIbL1ymWwO2 oX+5J/GsTntvqPE4RZoq87NFyoZXNWKuVa2On4PlwQVLvqtFIRcZVex8+QmOKEHtkNq7aLXksC xRPFreTB2nKeOMWfcIK8GMO64nvRVOTrsNs4I7ylOiXiYBvKIkD1vC1QeLBiImqEjYuXcpjJn1 2CA= X-SBRS: 5.2 X-MesageID: 38947527 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,237,1610427600"; d="scan'208";a="38947527" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N7btv2Qd42rbZliF43n4ZYUHkQZL5Sg4LAII7vayZpHkt0eCX6zUl6gM1yxVX7yHLRgtvDp9zh8xv+DSi5JmQKC5g/3Sq9GlGQENiKb0Y1KvWlcrWmr3h7ZJoYO78fXlA4BsOvJXX1OIaiA72NnY29Ta2/bMhFqBhk1FTOB69HJiLDbpHcT1/CbQJN4FZHjemPT47YwkVT0dxC+o2hpwDgJtdF5B8eeQddmC9MyNCbcbQ2yKc36eGOKKx8/EjV/Z7LElGkrhFG7908aSxfTCO1Yy9Zr/VCV+Q1sgONgdqh9HigRSPz38ID/nvfHkFyOHZCTpGzALmYeVApZ5hjD+zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CpZtEeIqrPtN0Q79N5PPXnH4BaXxQ3jqSvohJqdn32s=; b=TE6M05wB/WQSLGOBA5dKoOILJPy79tBO3tgRg7I63p+lOcBzPN4qK5aZ3QGZ0FPQ98UG2ltLJ0ZZ3vsutw4sgcIAqjl+d4gBUZDKDvm2Y5BUHNvr0sqQc8El4PSlgPtaF+npSU79XM5sVbP7TPM+jqq5KAT/21HhbWspa/a6d/fFAm5Nn8GOu3EqNaDmW30FudmpX6AI68rSdDuVpL0XAprYtTLmibJeXqtpebiN2bhy04s7+uR8/VZXSHPDLYWbzvrgpRfjPhpdEu7EX+Lfp3LynMIuP5g562k7FryO/sPMHG9JFpDsR0yqDlom1lZbyGonSOLbQW/Nq25ei2ULuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CpZtEeIqrPtN0Q79N5PPXnH4BaXxQ3jqSvohJqdn32s=; b=I+fCLATSVgeh5CXjUNHZ+q0BwUEfy8BpkR5x4q8lYbQ//ayGT/W5qtHCyw5y/x4XaAOQDFlOW9UZGbZSAKxsNnTZD6azFik4t7Z+9snRdZEUAS7hVfAqfDGNENlOm58ASmYL8L36egw3ocnOgODFXzOuM6lt7ZrFhVN7xfQDfz8= Date: Wed, 10 Mar 2021 08:49:07 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Elliott Mitchell CC: Andrew Cooper , , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Juergen Gross Subject: Re: [PATCH for-4.15] arm: replace typeof() with __typeof__() Message-ID: References: <202103092114.129LEgZp059925@m5p.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: AM6P195CA0002.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::15) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb77dd1f-49c7-495e-39bb-08d8e398ffe2 X-MS-TrafficTypeDiagnostic: DM5PR03MB2633: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pcq+NfcnY9ga3+2PuNOs1rwCF8SWINm5bKT8S+vpjZIWdcWyvVcpB3Ofld2NFH7OI6RHE1mwlfkiSQBOeER4H/a3L95TCLy/VWbFt1FdQWSP1OssUeCAEaC1imS8LpITwQ8SDcr71FiuR0ssOcSNUTJsxOJ2NOBIaF+1uGrJJmyvWLAjPjMoIN8tAtrSkcdNiddcy4ouJ+cDmyZ6zbBEtaP9DbYQYKtJ/lLBtrOKO29sGXqA/TEmIuyx9kW1QTPsKzVJWqvJvlUCIh3+berNOfb7Dn53Xay6YiPzFgMS2+di6/4sNwDxbfjT52axK9Thara/81ZegaAAExsgrSiJY/t4tOoyjG44JX/CEeU7nvQhQyx4h69JvaDt9xRx9JmuB24hE1a+fm6IZwYXrYOWLnDcbhiUTWRevhvYmnyFbmov7mXymDzUIG+W6jlMJ8Qkp8GQgHau0L3z02Q/VOarIFVGEkBJghhYcmI+EipOuLBBFRK3Zf7G/YEyGoKB09ueiIh8dxssKwN22yaQw30+fw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(376002)(39850400004)(136003)(346002)(366004)(396003)(5660300002)(8676002)(316002)(53546011)(86362001)(33716001)(8936002)(54906003)(66476007)(6496006)(66556008)(85182001)(16526019)(26005)(186003)(956004)(2906002)(6486002)(9686003)(66946007)(6666004)(478600001)(4326008)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?N2hDNzNGdmNJcmN2aTh5dlhZc3VoZ2tpMmZOaGVqcVdweWRpaXVra0owMmlK?= =?utf-8?B?V0t2R0c2c1ovN0dLamZWdmU1alJkc1JRM3hDSDVtZmlvVzQ2UXNrWHVBNXQ0?= =?utf-8?B?SERDdGpIMFJkeVk3QzAvN1hhcVVTRWwrSEhlRE9VaFdMQkJUUUNYM1N6SVZC?= =?utf-8?B?NW5lbEMwN0NPZmd4NHpwR0FYVWM4QndtTFJkbzNYMFpCYzBSbk1ZVERmc3Az?= =?utf-8?B?cFdXaGRIbWFScjM5djFXQWJrWVlnSGpNTUxPSkxrSGEzSkxLUUNHTjR1akFC?= =?utf-8?B?OVMwY09rYngwejl3RlNiYWNsRjlYZVBrWTUvRktodVNPS0MzWC81VCtxK29X?= =?utf-8?B?NFNOaWd6UFBPNlhoRHRvMk1NUnJlcjNYZTFjTG5sSUkvbUlSVkFvZ3NNbEZV?= =?utf-8?B?dGkwWUhJQVJGZnNSMGZ0SGhXMXZtV0VzcDRCUGZDVlIrN3JQM3ZDT1NVV2ll?= =?utf-8?B?eDNSRWxlWkprelBiUmlCbWtZcEwwT1U5WE1JcTArNlFLQ1dKbVV2LzdSd0sr?= =?utf-8?B?VTQ1NW1hbFBkV3BocmNFK1BXV3d5NFhQRG85eWJBR1U4TDNjTHgrRUZWb29y?= =?utf-8?B?RGVJd3JXd3hHRk5aNXpHTmRXSVg5aFNzUnVoRjR6TVRJeS9ZZHFBQnAvRlEz?= =?utf-8?B?VVRZL1VBYnRlWWlSWjlFTDRHR2gyOEVlZ2NOUncyMktnNitqQVA1alo2Y0Fi?= =?utf-8?B?TnR1RGtPcnhyOWZwSDcxR2UrdHFnby9MaEhGaHhLa2Y2cEtjWHNzSm1VUWJB?= =?utf-8?B?cjd3c3V3Z2V6L3J4enBRZ0pSVVYzQVUrM2VaTzlKQjFGMWpwT1J0Z0F4VE9p?= =?utf-8?B?N0RuVDU0djNyV3kzeC9UQnU4dEV3eE8vVVN3eGRTQlVTR0kxWWJxd0ZWOU83?= =?utf-8?B?VktFeUk4T3NJRVY3MTF0UXBpbGcrRFQvNW9HL21rMWZ1QVNLNExPTnkzUk00?= =?utf-8?B?NEVhbzFUUGZKYnFKTS9EMThmV0FRdDR5ajBvOE96ZnpLNXpLUk80R0s4c0Vq?= =?utf-8?B?dEg2UDdMREFqaXlmeGlLRmxPbkJsWGxTVk9OOUJ3SUoxUXJ3S2V1dmdvWXlF?= =?utf-8?B?VHhuQmhEYzBIOFlmUDEzRGZBcUVSRC9BdXB2R2JIeUhnUGdiSURZdm13WmFY?= =?utf-8?B?aTF6VWhPbjhuZUdsZXcyeGF3a0dOeGM4VVlyeHU4b0hTbit6Q0ZLaHVxTGZ3?= =?utf-8?B?UldwcGZQYUk4b1AySEN1aGZkRDlyY3JHTkFDZXcya0ZKNjBDd0pWV0pkQk5t?= =?utf-8?B?QUZxbU5wTExqZ3JNR3doTmw1UVZNSFJQa3FrcXVlcFBxNGkzdnlYZWtQTEdV?= =?utf-8?B?Zk1wRmNYa3VaQWF1Y0NCSnFHL3RUT0ZsSzdrYThSTEQ3L1NoMGZZZ25lOHlL?= =?utf-8?B?R2NyTG03ci9ZOEk2dm5pZm1DcVVuSVl6ZFlkbWVSWHcvMVBKbnJ2ODBwMFdh?= =?utf-8?B?RzBvL0F4MDdJUWdUc016bjl6aVY2TlkzcW1wTGJSZFpWTzUwZUNkNVRYNlAx?= =?utf-8?B?Y0RmbWx0MlZJNUFqYndlZWpDOEZKbnF0ajljNzd5ZnZ1dnZ3VHpJQVNDQ2ow?= =?utf-8?B?WVVVVVJSUGorQlExTFRlc0FZWDQ3TTVCYStZVHpiZlBoZWdKbWE1a1NRMXY1?= =?utf-8?B?L1BPT1ZYd2JnNjdhbDFCejZRbkV1QkFEbkNPanZFQ051UjBia09tbzVkSEh6?= =?utf-8?B?K1pUWi9OSFdPaitlVGV5Z0VYVmFxSXVPTHRsQVBUOGJ6SmZkOG5tNDhPWlFi?= =?utf-8?Q?lksK2g03u5Y3v+qQIsCKtgfDr3RVmIEzMobMWvd?= X-MS-Exchange-CrossTenant-Network-Message-Id: bb77dd1f-49c7-495e-39bb-08d8e398ffe2 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 07:49:14.2566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hVW6LRiEHDOYW/WYmyLPF4ntkgOQnDMuTLF4jyUjE8fhoZ74R3/ojoFtsBymVyJuGEEn0dwIGXS3rx33Rm4cMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2633 X-OriginatorOrg: citrix.com On Tue, Mar 09, 2021 at 07:24:32PM -0800, Elliott Mitchell wrote: > On Tue, Mar 09, 2021 at 09:27:34PM +0000, Andrew Cooper wrote: > > On 08/03/2021 13:36, Elliott Mitchell wrote: > > > typeof() is available in Xen's build environment, which uses Xen's > > > compiler. As these headers are public, they need strict standards > > > conformance. Only __typeof__() is officially standardized. > > > > > > A compiler in standards conformance mode should report: > > > > > > warning: implicit declaration of function 'typeof' is invalid in C99 > > > [-Wimplicit-function-declaration] > > > > > > (this has been observed with FreeBSD's kernel build environment) > > > > > > Based-on-patch-by: Julien Grall , Sun Oct 4 20:33:04 2015 +0100 > > > Signed-off-by: Elliott Mitchell > > > > s!arm!xen/public! in the subject seeing as two thirds of the > > modifications are in non-ARM headers. > > Gah! Crucial little detail missing when rewriting the subject line. > Julien Grall's original patch/commit only did ARM, but when I checked I > found the other two and I did them too. > > > > Acked-by: Andrew Cooper > > > > This wants backporting as a build fix, so should be considered for 4.15 > > at this point. > > > > I wonder why our header checks don't pick this up.?? Do we need to throw > > a -pedantic around? > > This came up since FreeBSD's kernel build uses Clang with > -std=iso9899:1999. When I found FreeBSD was simply copying Xen's headers > it was clear this needed to be *here*. FTR this was never spotted on x86 because we don't make use of any of the macros that use typeof in the kernel. Arm OTOH has a typeof in set_xen_guest_handle_raw which is used by kernel code. Thanks for fixing those. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 10 07:51:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 07:51:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95881.181014 (Exim 4.92) (envelope-from ) id 1lJtcu-0002Q6-20; Wed, 10 Mar 2021 07:51:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95881.181014; Wed, 10 Mar 2021 07:51:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJtct-0002Pz-Uz; Wed, 10 Mar 2021 07:51:27 +0000 Received: by outflank-mailman (input) for mailman id 95881; Wed, 10 Mar 2021 07:51:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJtcs-0002Ps-AQ for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 07:51:26 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 501b0ad5-d2ae-4a28-9543-767120d0df42; Wed, 10 Mar 2021 07:51:25 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 79E63AC1F; Wed, 10 Mar 2021 07:51:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 501b0ad5-d2ae-4a28-9543-767120d0df42 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615362684; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OdJhwschBXvB5hNHxMQE7ci5qnJUnPFBXFeYxWWs7LU=; b=MIhzv4U/6I9MUcLzMLr7qFZ5XDlYOMx+4qXKrm3bpB5MI6rXn4/VWVUmQNesLyQK4JWPsZ NyTSsAP5d6dlFcaGiMseRqojsKxIlKlVF2qv7qQl7w/FdImJGPHAb7HgqO6EnT98wcyJpB SPmxzqannDTIg0oRcNf4OS81xpo3XRQ= To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini , Peter Zijlstra References: <20210309134813.23912-1-jgross@suse.com> <20210309134813.23912-3-jgross@suse.com> <20210309185737.GE699@zn.tnic> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: [PATCH v6 02/12] x86/paravirt: switch time pvops functions to use static_call() Message-ID: Date: Wed, 10 Mar 2021 08:51:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210309185737.GE699@zn.tnic> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nna0TkS6ABUg1IonAzP3y7arxA0rrchGS" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nna0TkS6ABUg1IonAzP3y7arxA0rrchGS Content-Type: multipart/mixed; boundary="q9XNVycbGdPhE1GVCGpTpAYFf6uHIwdvx"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini , Peter Zijlstra Message-ID: Subject: Re: [PATCH v6 02/12] x86/paravirt: switch time pvops functions to use static_call() References: <20210309134813.23912-1-jgross@suse.com> <20210309134813.23912-3-jgross@suse.com> <20210309185737.GE699@zn.tnic> In-Reply-To: <20210309185737.GE699@zn.tnic> --q9XNVycbGdPhE1GVCGpTpAYFf6uHIwdvx Content-Type: multipart/mixed; boundary="------------B707D43FD7210F09477B06A5" Content-Language: en-US This is a multi-part message in MIME format. --------------B707D43FD7210F09477B06A5 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 09.03.21 19:57, Borislav Petkov wrote: > On Tue, Mar 09, 2021 at 02:48:03PM +0100, Juergen Gross wrote: >> @@ -167,6 +168,17 @@ static u64 native_steal_clock(int cpu) >> return 0; >> } >> =20 >> +DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock); >> +DEFINE_STATIC_CALL(pv_sched_clock, native_sched_clock); >> + >> +bool paravirt_using_native_sched_clock =3D true; >> + >> +void paravirt_set_sched_clock(u64 (*func)(void)) >> +{ >> + static_call_update(pv_sched_clock, func); >> + paravirt_using_native_sched_clock =3D (func =3D=3D native_sched_cloc= k); >> +} >=20 > What's the point of this function if there's a global > paravirt_using_native_sched_clock variable now? It is combining the two needed actions: update the static call and set the paravirt_using_native_sched_clock boolean. > Looking how the bit of information whether native_sched_clock is used, > is needed in tsc.c, it probably would be cleaner if you add a >=20 > set_sched_clock_native(void); >=20 > or so, to tsc.c instead and call that here and make that long var name = a > a shorter and static one in tsc.c instead. I need to transfer a boolean value, so it would need to be set_sched_clock_native(bool state); In the end the difference is only marginal IMO. Just had another idea: I could add a function to static_call.h for querying the current function. This would avoid the double book keeping and could probably be used later when switching other pv_ops calls to static_call, too (e.g. pv_is_native_spin_unlock()). What do you think? Juergen --------------B707D43FD7210F09477B06A5 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------B707D43FD7210F09477B06A5-- --q9XNVycbGdPhE1GVCGpTpAYFf6uHIwdvx-- --nna0TkS6ABUg1IonAzP3y7arxA0rrchGS Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBIenoFAwAAAAAACgkQsN6d1ii/Ey+d LQf+PRoeCHcywaE7JFLyJUUT15sNvX3awHBwiEsVK1SYO1xfHKSHZY8/xQGVeeRS/+MUAoXzkcBy 8j0SEjUX6gtprkhE1CYcwf21hlc7v1nA9u2wPwys5VFLGJfKPEv0TBPX1/jm5QQdFpb6+ttqPQb/ l3bNN4scvGkK/tV+D8L6FW+9a/SaHjXmNeLDe43rz10jNHFhkPAdOnRlHzH9DVSdFZFxKcORKgSO xp1FQRbKEv5252ZN+v1bESbjN1N/J/6e4dDRAzj7oUDuexczA2Qq7mRrd31J2eh0+QW/EQQ3gqQF QAmw28hYrqmgzmcWhfmLRzQVGuzx5NnueG8taAtUBA== =4mcV -----END PGP SIGNATURE----- --nna0TkS6ABUg1IonAzP3y7arxA0rrchGS-- From xen-devel-bounces@lists.xenproject.org Wed Mar 10 07:52:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 07:52:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95885.181026 (Exim 4.92) (envelope-from ) id 1lJte7-0002Zk-G7; Wed, 10 Mar 2021 07:52:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95885.181026; Wed, 10 Mar 2021 07:52:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJte7-0002Zd-D4; Wed, 10 Mar 2021 07:52:43 +0000 Received: by outflank-mailman (input) for mailman id 95885; Wed, 10 Mar 2021 07:52:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJte6-0002ZY-Bg for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 07:52:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d94ed53f-f894-4c97-aa0b-37368bcb87d7; Wed, 10 Mar 2021 07:52:41 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E5E6DAE44; Wed, 10 Mar 2021 07:52:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d94ed53f-f894-4c97-aa0b-37368bcb87d7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615362761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fmagm0g6SG9wOn5qY9NDsKJhRGoqp/JA1hP32sWV3T4=; b=VyZrbZQKMeSMXCTWCSyz0CqR7B2gWSK3gyj6vBitCnWoQi7styoaQILCubHOquaJugUypv ovDZFEds58x63Nt44akxgZiZ4BSosHqqH92NNeihDJ/FNj5MIk3ysmnm9p42v5UM3/fAEh IKGW1y8bpuZ2EbURSOq7bZEdO9hkQPE= Subject: Re: [PATCH v6 04/12] x86/alternative: support not-feature To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" References: <20210309134813.23912-1-jgross@suse.com> <20210309134813.23912-5-jgross@suse.com> <20210310060705.GB23521@zn.tnic> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <1b95376a-56e1-ab3e-aa85-73a9d38aaaf7@suse.com> Date: Wed, 10 Mar 2021 08:52:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210310060705.GB23521@zn.tnic> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dTWXoiEr2CUu22HQ0ZizVBKitnbXxMRRZ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dTWXoiEr2CUu22HQ0ZizVBKitnbXxMRRZ Content-Type: multipart/mixed; boundary="p5M5sLIHJQkn6BTbMQSaAVowf7JqkAJIS"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Message-ID: <1b95376a-56e1-ab3e-aa85-73a9d38aaaf7@suse.com> Subject: Re: [PATCH v6 04/12] x86/alternative: support not-feature References: <20210309134813.23912-1-jgross@suse.com> <20210309134813.23912-5-jgross@suse.com> <20210310060705.GB23521@zn.tnic> In-Reply-To: <20210310060705.GB23521@zn.tnic> --p5M5sLIHJQkn6BTbMQSaAVowf7JqkAJIS Content-Type: multipart/mixed; boundary="------------67B61F63DAEE5E8820EB9FAE" Content-Language: en-US This is a multi-part message in MIME format. --------------67B61F63DAEE5E8820EB9FAE Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 10.03.21 07:07, Borislav Petkov wrote: > On Tue, Mar 09, 2021 at 02:48:05PM +0100, Juergen Gross wrote: >> Add support for alternative patching for the case a feature is not >> present on the current cpu. >> >> For users of ALTERNATIVE() and friends an inverted feature is specifie= d >> by applying the ALT_NOT() macro to it, e.g.: >> >> ALTERNATIVE(old, new, ALT_NOT(feature)) >> >> Signed-off-by: Juergen Gross >> --- >> V5: >> - split off from next patch >> - reworked to use flag byte (Boris Petkov) >> V6: >> - rework again to not use flag byte (Boris Petkov) >> --- >> arch/x86/include/asm/alternative-asm.h | 3 +++ >> arch/x86/include/asm/alternative.h | 3 +++ >> arch/x86/kernel/alternative.c | 19 ++++++++++++++----- >> 3 files changed, 20 insertions(+), 5 deletions(-) >=20 > LGTM, minor touchups I'd do ontop: >=20 > --- >=20 > diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/= alternative.h > index 89889618ae01..fd205cdcfbad 100644 > --- a/arch/x86/include/asm/alternative.h > +++ b/arch/x86/include/asm/alternative.h > @@ -55,18 +55,18 @@ > ".long 999b - .\n\t" \ > ".popsection\n\t" > =20 > +#define ALTINSTR_FLAG_INV (1 << 15) > +#define ALT_NOT(feat) ((feat) | ALTINSTR_FLAG_INV) > + > struct alt_instr { > s32 instr_offset; /* original instruction */ > s32 repl_offset; /* offset to replacement instruction */ > u16 cpuid; /* cpuid bit set for replacement */ > -#define ALTINSTR_FLAG_INV (1 << 15) > u8 instrlen; /* length of original instruction */ > u8 replacementlen; /* length of new instruction */ > u8 padlen; /* length of build-time padding */ > } __packed; > =20 > -#define ALT_NOT(feat) ((feat) | ALTINSTR_FLAG_INV) > - Did you look at patch 13? :-) > /* > * Debug flag that can be tested to see whether alternative > * instructions were patched in already: > diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternativ= e.c > index d8e669a1546f..133b549dc091 100644 > --- a/arch/x86/kernel/alternative.c > +++ b/arch/x86/kernel/alternative.c > @@ -397,9 +397,10 @@ void __init_or_module noinline apply_alternatives(= struct alt_instr *start, > BUG_ON(feature >=3D (NCAPINTS + NBUGINTS) * 32); > =20 > /* > - * Drop out if either: > - * - feature not available, but required, or > - * - feature available, but NOT required > + * Patch if either: > + * - feature is present > + * - feature not present but ALTINSTR_FLAG_INV is set to mean, > + * patch if feature is *NOT* present. Okay. Juergen --------------67B61F63DAEE5E8820EB9FAE Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------67B61F63DAEE5E8820EB9FAE-- --p5M5sLIHJQkn6BTbMQSaAVowf7JqkAJIS-- --dTWXoiEr2CUu22HQ0ZizVBKitnbXxMRRZ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBIesgFAwAAAAAACgkQsN6d1ii/Ey8v Qwf+PVmZMZVTwfKPrQb5E1WzsyCFL0Gr06M/AR0VARJ5+OhMaH1oGGeSsE8Td0O7+R6P3m6+c4j2 4vxCddjvA/a7Z5CBWOs70yOGK282YHUdSanfGGbWD0EE89h8IvxqIvpKIvedJZeaykynOFl2u3gp F7QUw8FzZMfuMeFMHTiOxrv0kJ797jvbzLjhZRIOxaStCMj2FAwqpSHfWANXwJ39POD3kO3n/dBc E2BCQSmYxijJUHHrUTcYk5bgVwbtVX1H7t47zru6RLWbjJkeYXENYYaXZjBQHh8dJTPFPJqWhbH7 qNC1tndU9dCCQQvfB2c5MsMw9K8kcDvN600vlT5Npg== =bcO9 -----END PGP SIGNATURE----- --dTWXoiEr2CUu22HQ0ZizVBKitnbXxMRRZ-- From xen-devel-bounces@lists.xenproject.org Wed Mar 10 07:53:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 07:53:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95886.181039 (Exim 4.92) (envelope-from ) id 1lJteQ-0002eW-QM; Wed, 10 Mar 2021 07:53:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95886.181039; Wed, 10 Mar 2021 07:53:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJteQ-0002eO-Mt; Wed, 10 Mar 2021 07:53:02 +0000 Received: by outflank-mailman (input) for mailman id 95886; Wed, 10 Mar 2021 07:53:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJteP-0002e9-Hz for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 07:53:01 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6e81d9a6-8e8f-4f50-84da-1a1271f57290; Wed, 10 Mar 2021 07:53:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e81d9a6-8e8f-4f50-84da-1a1271f57290 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615362780; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=1Kssqz+WLgBNHpkenZMOvaFKLGJcIvM6rkrhayhxPuU=; b=brRSQ/aoDeLmefkibxkH3ddZKjjPRDGVzX88qz9oEY9qfyr8dNiyJrVE tauK+cGbe/PMeywTwE8GT7PAyII3E+ByNGg4nmAoolisy2ASwFcgcsfVo BdIzZPjn48iyXVqwWkxAZfZ4OqsAWEzoZOITQA2abssCvsMRBcWudyPnj A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: LSXf9i3fphaDoZwHBHzJTzH2FPXXuXd5vZQXFh7U3p7UCGilgQcug0yJoO36ZMItL8usd3vAGJ kMQ0ZX7ZbR4OgAsUVEKTJF4/PMitGB0hWUl/AGf1/l4sJKtw9l/H0VozxJLIEmdjqM13Zjo1wd OOMfY2yktMECmKHM1u4grwKiupfSbS6mT5HNi57/JJoE32u4Xby59R+kARzGcIg4I31YQfkiyx YmpXZOOfT6X7GXH+arpZ+M/mO2ZXmPlPqu+5gXh26WsnhaqsqD14tFLmugHGD5YNtT/hkPTXYY ipU= X-SBRS: 5.2 X-MesageID: 39111763 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,237,1610427600"; d="scan'208";a="39111763" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JQg3UFdoJ2BI+nS9Tj0587DnLOOElvgKgX4TAhyRgmfwxB5aiYlocXTP83yJgcVJQDAKEX2G3J/k9fgGKgBisnaEnLqm/VXBFuc9KKx449kTyIB6/PHeh9s/bYDMfoRyxXETYO59mZ1aEEff4Y3P//lSHLp6WSL30pn5qvuU2Xyb/gQhtuutaz+YJbRIa1U4nSE6bodhSRNQL/1+mrkNx7inZTIFQI1i3wD65Hw6xcw0rWKhDafSeIWGmnNTf1e2+DBnVaugaomi/tAMJsDPzEjHrCMWaWzwMJ9N9X21IRVnb++T+guYREyVhXosw9Ex/buxz3eLVz6dpLq2JdsW6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eqzUufE9H0R8/djEDbSikgHNrNawG3lACGzcc953Nqs=; b=GnCvv/cMb4v/OcT9xVstDxvbwrb0WVC+RaA56ta+aX2Pwc5DaVRa/eq1oOK7Rmaa4FppFgiXJ3mYL2pqPk5bMUU8GObUeFsTj/r+0e6HJ7In4J3t1bpmTVm1f2hF5jgWl+kpoGBzklK6E+nV1WQtaWzBCUcMz2r+UgGJgCFUAP8zGtq3Ivbqw68ZkgxQng41f+TN5k+huyArliPw6ekAReaGxYGhooPwVu5Idl5IGWSeFrJkHhCan7SX9tjLRovv5zcW/BsfGX0NTR718Lg6QGtuN3303giiIG+WklD0xeTgs3gWL90/jXI++sKDbtmoamuMe5G1SaJ/F5OzGPjX+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eqzUufE9H0R8/djEDbSikgHNrNawG3lACGzcc953Nqs=; b=DbTuyzpR+/Pe1Hnj/F6NbX8xNUCcXWA4+XOT7IOpk9eWMTiBxFFIwWXd6zYyR2HX8NySQ71ugrURYk2bf969NbYPnSwK3mFIa354Kceft4QGR7F9iwS66S6ieadqVpshRCNQtK6JXy2knapHoeIxyyAvow8E3ytqLnNpgzMdquI= Date: Wed, 10 Mar 2021 08:52:30 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Stefano Stabellini CC: Julien Grall , , , , , , , George Dunlap , Anthony PERARD Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) Message-ID: References: <161507188317.11025.6744028462008264481@c667a6b167f6> <10b8048a-e8fe-1fcd-7291-7f1b16da2f4c@xen.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P123CA0099.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 18855762-13d1-4eca-a8c4-08d8e39977f9 X-MS-TrafficTypeDiagnostic: DM4PR03MB5998: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XD81ZkJb1jqGeHC4W6svWA9bZqbYKl2FmVgGaZp0+zIH5pO2uG176am/Wx1rJNyUXIUqS/yd8UqsbMnzZ2FWf5XsGy2RswEoI5TQZlapADZCyyDUfZQTgfdvOZ5EnQACPj1KBtDb85oYd8xUkOSTq+S+D1fiEcfWcuTN1+Yp+nwta0i5WPYFubcElaNKdcFprjzIy4SH6vH0Fg/3gSbd+cte8dFqi8YBci5nEn6wz9VD/JHxFLY9mUj8kqfWeylgKPQe+9wpaC1aUTg6VDjekxVE0j5bMA86qNYXpMbpL8zC6i0OWau/BU9Bz/xoB9qMQemOpBXI5b0W+th5o3DFh9TJQeQ1o1II88tV+WeEoDK1iZRBkgj4M5YDVGcTepa+9p7EBVtQnD4zKWozvbe0zRr7KtL5Ph5zmDj9KH48AAbc9Bo4avZuFKEY8hriiH1EbAFEi6q0z5exdsIfAO2HSKIE6sVoXU96N7+PV+uYV6w0i3nTsYJKue/xis88b/1EUpAW1XDa16N5UnhhRsZFIQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(396003)(39850400004)(366004)(136003)(376002)(346002)(66556008)(316002)(6916009)(86362001)(83380400001)(6496006)(54906003)(9686003)(478600001)(6666004)(956004)(66946007)(66476007)(6486002)(8936002)(2906002)(186003)(26005)(5660300002)(33716001)(4326008)(16526019)(107886003)(4744005)(53546011)(8676002)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MHRFVVUwQW5iWmNRSVBXNVAxSFlsdWl2QmhnbEl0dG1iMkNNeTM3aEVVT25a?= =?utf-8?B?b2x3V0lDdndJMUxzbXNQdm9MbWZxam1CSmFUM3FWeSt1b3VUUi9TR3ZXbHFS?= =?utf-8?B?TCt3eHlnb0dremEyUHFmV2hKTDdFZktnM05nQ3o5L2x6TG5wNWxBeWk0Y1ZL?= =?utf-8?B?L3B2bURrSXN5UWdTUVZlMG1CbmhUTkhxOUZIK3JxQ3RBdTAwNTEwKzEyRE1k?= =?utf-8?B?Q21ybFdJL0hQVVQ0b1U3ejhLMkFnY1pSRzQweVAyMmhXYXVreHhCZVhXejc4?= =?utf-8?B?MkE4TTFXS2JYeDhNYzRDQ05zQ2gzZG5YZmxLVEFDbHF1bXg3clFMaHZiRVFh?= =?utf-8?B?ZytwTWVKa2pEUGpNdVpjbkh4ZnlOMXpVUk14K3RVaEdrV2hKZmtjdVFmaEF2?= =?utf-8?B?TXJhTTd2VHhGNmx6RWwxNlBCUERtZ1d2NGVGOHdXOUZWeXNIaCtud1RadFlk?= =?utf-8?B?aHJlUUMvSkdyNGE1em1YeXNqdnVYYjhVdGZNU0tqL29FeGI5QkNacHBSRUxF?= =?utf-8?B?alRyMk1LaDltVm5qZzk0VWJWWkE0WDY4WmZyUGdFUU51Z2FtQ3Fudy92R24x?= =?utf-8?B?aUJ5R1ZMOWRFQ3RWVVA2SWRQK2NvNTlza0JhbDFVNml6Qld5aEFRMTZzM0du?= =?utf-8?B?dDBUaktkMzJKSzhabjhCUG85S09IVWZWWEY1OXZzV2RLakIzVmljb21nbWpW?= =?utf-8?B?MXVRVjg5ZnJMbEZBa3Q3emhKbXgzSzlDdGlYYWxDSDNCSExCMENRaVlzbWpn?= =?utf-8?B?bWVHTWU1WGgwNElhZU5PbGtLMTk4RXZMN2RjK08zNktDK0lsdHd4SUNyazMv?= =?utf-8?B?NlgwRk9Lb1E0d1lvcWJaQTF4eDVWTk5iS2M3U1o2dmpQK2xQeXUvNWFidlAv?= =?utf-8?B?TnU5Vy9ycGl3VTQyVUcvOXhWVDlTR1I5eHNNbTBSenF2cmpxRXRtZUQ2bWxO?= =?utf-8?B?S0VsVlZ3eFA4K0lQU1M1TnNxT2ZJbTdJeFkxRkhNTlpyOHpCbldTd2o0R0FU?= =?utf-8?B?d1ZJTmcvVWpJQUd3RlhNVjdudzdOZlAzdmJhdSs2SDJxaEJCSTQvVmJkbGtt?= =?utf-8?B?K1RwQndtQ2hRcVVOekhGa1o4NWx1ekxwWUZvSFMzK3g5eVg5Zk9XYkFEcVFU?= =?utf-8?B?K1BjSzJmUnEreTIxdVZXcVpsdkFkZHJ4UEltVjBjSXZVOExlYlo1Rk5wWUVR?= =?utf-8?B?Q1hMR2VicEFibWdIb3VuTGRaaXgybmtNMVFUZ1laZ2F6WjU3c2IwWERnQndP?= =?utf-8?B?OGhMYWZPQWdRcWxhQUNSWDRqQWYyYnJHalprcXJWSk1udW81R0hFeDlrbEFs?= =?utf-8?B?QTJzRW12aXlQME9JVThkaEhidXcxblpSRlVKajFPT0R4OGkxVHNCMnp0VlZ1?= =?utf-8?B?T3lDdGRDZ1JaVDlQNi9RcXpLbkN3TUdSTUl4N1ZxSlkxQkQyMDFnOUdqRTYy?= =?utf-8?B?UFpDaWZpMVIxeG5zYS9xcitPaDR2TlIvY3o3ck5yMEJVaXVoQ2RkYjFQdW9l?= =?utf-8?B?TXZycElpN1ZqSjJ0SWNMUlZTSmhaTE16emQrWlhCaVFOcVQzaWVsY0pMLzBp?= =?utf-8?B?YlhucDlFanAzcW1JM1JtN3prc1FpSXNCc1dTRUs4WkloQ2NGNEFrYnhVVHd2?= =?utf-8?B?VUZnQVMzMlNRUENYM2FsNTB2bmp5Wko4VlprQ1Z0RmpDc292dzl4WXJzVGdk?= =?utf-8?B?bnhoSFpiSXFCUjc0VVpZRjZaRHF3aXgybVV1eEtHdDZCVGVJcVRKUnd5Uk9U?= =?utf-8?B?VlF3aWdtRHI2eVRNY3d4WW9INW9pRi9tNkJlVElDUm9oMUMwWURWdkNQd1RR?= =?utf-8?B?azF3SEpKNFpnSC9ocDk2Zz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 18855762-13d1-4eca-a8c4-08d8e39977f9 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 07:52:35.6402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D5WGhbquQFwWOFyuYjkCLeBT4oA57dTmtaZn0ypJi28txYZpOiJeGgpvGIea8Ynmnt7/NIAnbdWPPiro7Ywv7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5998 X-OriginatorOrg: citrix.com On Tue, Mar 09, 2021 at 02:24:05PM -0800, Stefano Stabellini wrote: > On Tue, 9 Mar 2021, Roger Pau Monné wrote: > > On Tue, Mar 09, 2021 at 10:05:18AM +0000, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 09/03/2021 00:59, Stefano Stabellini wrote: > > > > On Sun, 7 Mar 2021, Julien Grall wrote: > > > > > On 06/03/2021 23:04, no-reply@patchew.org wrote: > > > > Where does one has to register to get the patchew build failures? > > By asking Fam (CC'ed) very nicely :-) Thanks! Could we maybe setup a mailing list for those emails? ie: patchew-tests@... or some such, so that we don't have to go adding people manually? Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 10 07:59:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 07:59:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95891.181050 (Exim 4.92) (envelope-from ) id 1lJtkV-0002wh-GK; Wed, 10 Mar 2021 07:59:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95891.181050; Wed, 10 Mar 2021 07:59:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJtkV-0002wa-D4; Wed, 10 Mar 2021 07:59:19 +0000 Received: by outflank-mailman (input) for mailman id 95891; Wed, 10 Mar 2021 07:59:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJtkT-0002wV-T5 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 07:59:17 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 36f5c8db-ad70-4bcd-a149-5630803a2bcb; Wed, 10 Mar 2021 07:59:16 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EEB74AC1F; Wed, 10 Mar 2021 07:59:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36f5c8db-ad70-4bcd-a149-5630803a2bcb X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615363156; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bS2K/jVrybfRNQIhP9EwsP9/KS2Gkb2dfPR0vg+ZwOM=; b=PMsgwoG4ty5KrDwrsG/9aiwWxK6Bv9nYeZvIizdcJqxOR6GmMwqwdEn12sLlwT/M8CcpJ7 mSeKSZhr6/QsRyCY4Ro/k7fZ2Dpbl/CWY1bWSaawGPUAyv0+GOhEWbjtS7M8eC7YEocMrJ bE53DE31epetqXzr22riECI8bKPGbcg= Subject: Re: [PATCH] arm: replace typeof() with __typeof__() To: Elliott Mitchell , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu References: <202103092114.129LEgZp059925@m5p.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Wed, 10 Mar 2021 08:59:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <202103092114.129LEgZp059925@m5p.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="01dVxhajaTytwgGxlqX2QTfuzdHHI7jZ0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --01dVxhajaTytwgGxlqX2QTfuzdHHI7jZ0 Content-Type: multipart/mixed; boundary="Jl1KDn918pIqMaKsQIc9aKcNQ0J9wKUIM"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Elliott Mitchell , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu Message-ID: Subject: Re: [PATCH] arm: replace typeof() with __typeof__() References: <202103092114.129LEgZp059925@m5p.com> In-Reply-To: <202103092114.129LEgZp059925@m5p.com> --Jl1KDn918pIqMaKsQIc9aKcNQ0J9wKUIM Content-Type: multipart/mixed; boundary="------------F18E2BDB436E224F6FF157CB" Content-Language: en-US This is a multi-part message in MIME format. --------------F18E2BDB436E224F6FF157CB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 08.03.21 14:36, Elliott Mitchell wrote: > typeof() is available in Xen's build environment, which uses Xen's > compiler. As these headers are public, they need strict standards > conformance. Only __typeof__() is officially standardized. >=20 > A compiler in standards conformance mode should report: >=20 > warning: implicit declaration of function 'typeof' is invalid in C99 > [-Wimplicit-function-declaration] >=20 > (this has been observed with FreeBSD's kernel build environment) >=20 > Based-on-patch-by: Julien Grall , Sun Oct 4 20:33:04 20= 15 +0100 > Signed-off-by: Elliott Mitchell Reviewed-by: Juergen Gross Juergen --------------F18E2BDB436E224F6FF157CB Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------F18E2BDB436E224F6FF157CB-- --Jl1KDn918pIqMaKsQIc9aKcNQ0J9wKUIM-- --01dVxhajaTytwgGxlqX2QTfuzdHHI7jZ0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBIfFMFAwAAAAAACgkQsN6d1ii/Ey9F 8wf/R273QDIiEWInY5h1QnUYpJX2vIH0u9H0FPeTMDA6NUR+M9lQKvgxfS+J+rXG20rtlTOvOUrh 0MIpLE57u07k05N+H9yTnIcsqLBXuplnUBRIr3vBaCy0llvVqaqwFzSEJD0nRZ+tIgDf2NN5eOgs w5dX58sVFBz4pVGS6u/moZR5Nh1sSYB25mIfb53/gvczUuhhgYF6N5uLN5bGHwCFyluMQlvg4sOm D7iXuIvhQuoc5e78Zy2m9t2guavp51VXV3uoqiU2FcTDVJCvzJMISbB7I5aEQl12BvAm6JvtSXua XMmYg2zZYsayARIz766eWWXimJCUpPo3GsWF/zJoCA== =DOOi -----END PGP SIGNATURE----- --01dVxhajaTytwgGxlqX2QTfuzdHHI7jZ0-- From xen-devel-bounces@lists.xenproject.org Wed Mar 10 08:06:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 08:06:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95897.181063 (Exim 4.92) (envelope-from ) id 1lJtr5-0004M0-DK; Wed, 10 Mar 2021 08:06:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95897.181063; Wed, 10 Mar 2021 08:06:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJtr5-0004Lt-9v; Wed, 10 Mar 2021 08:06:07 +0000 Received: by outflank-mailman (input) for mailman id 95897; Wed, 10 Mar 2021 08:06:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJtr3-0004Lo-7l for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 08:06:05 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [40.107.20.53]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 47732e80-9148-48c0-8f40-51c8fe23a730; Wed, 10 Mar 2021 08:06:02 +0000 (UTC) Received: from DU2PR04CA0173.eurprd04.prod.outlook.com (2603:10a6:10:2b0::28) by AM0PR08MB4467.eurprd08.prod.outlook.com (2603:10a6:208:138::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 10 Mar 2021 08:05:59 +0000 Received: from DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b0:cafe::b2) by DU2PR04CA0173.outlook.office365.com (2603:10a6:10:2b0::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 10 Mar 2021 08:05:59 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT006.mail.protection.outlook.com (10.152.20.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Wed, 10 Mar 2021 08:05:59 +0000 Received: ("Tessian outbound 24a7072fdae6:v71"); Wed, 10 Mar 2021 08:05:59 +0000 Received: from 037fb7699184.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D15C0DC0-DAA7-4338-9AC4-039CB81D22F4.1; Wed, 10 Mar 2021 08:05:53 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 037fb7699184.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 10 Mar 2021 08:05:53 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VI1PR08MB3791.eurprd08.prod.outlook.com (2603:10a6:803:c0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.30; Wed, 10 Mar 2021 08:05:46 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3912.030; Wed, 10 Mar 2021 08:05:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47732e80-9148-48c0-8f40-51c8fe23a730 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aJRcvDglW3nsBhwz9XMyxQjlKduvqxHw916myrBus/4=; b=6ZjrZskFSEU7CB+VwTZEdy4zg33+tpBt8LVAiqkabVPetQdkeSxqpoqoL62dP+hSlTE+zCAXRNTVu8FS6TX4gGHD5hTBm/Tk8f80tAzGCSLvfVZR53rSzbi/m2e5oCq6bAeAwXMRtJv+jb9fIuALCnLmJk5MUhn7iG08S3+NFqA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 602cba9698c3d51f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hay59Qmu4Qr7Zw3wh9anufjKcdFtNYnXKRgiRcgYzek21brXMuxq0jLmAaW/P2E36r4YwPaKVukSJEh4VpPSIcXu8OPI5L7YJALvnryAog6AC6mNLKNXPtvNNAqCvP4+NPEe8TO/othh4Nz3HSo/ov3kxROyCulL7R4b/+n8lZEdKanR31oNIxmvYYbteIUWC5RtMggWx7ABL4C6wNKJdhs91oLEwac98qgO49RdUV4vNmZ0kgMA707vNUlmTLe4iZ0F6kXt+MYO+YTAv3BM7IIhusimCbWy8vXJOfPpIauKaOqfN6Dem1ozcDghLxYzAtcia8HpF3Fy+o+CEyYrtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aJRcvDglW3nsBhwz9XMyxQjlKduvqxHw916myrBus/4=; b=D2nGvgrOTWAsfQfaYKEuFVTS/uE5qHRw8iaTJpUvu0wPGZJrmysldnHnAUfm3ai5UUmhezTGg610lUFQJz9U/2vzFIthW3iJqcVFXiflNVImux9qbBUAHkbUXDn3Bq0KsqxyGmbI7ut3sMwXp+X2HKjk5ARVGmRqt3A2v6uGF0zYVG2GuEwpAkwaU+07KJ1TpiFuaa4B4YH/lTACP/o404pvyXJ1vEhCPbHbQo+HSeRAX1nMgHeQlh/T9ae+EWC3apwT8fO7mqpurYd/ZDdJG8JSeJkaUCLyWcGIdrY4UIcB9IxaAwjYfFKNlDIL4TGfx1RMW0aLienvtRfwBEZgog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aJRcvDglW3nsBhwz9XMyxQjlKduvqxHw916myrBus/4=; b=6ZjrZskFSEU7CB+VwTZEdy4zg33+tpBt8LVAiqkabVPetQdkeSxqpoqoL62dP+hSlTE+zCAXRNTVu8FS6TX4gGHD5hTBm/Tk8f80tAzGCSLvfVZR53rSzbi/m2e5oCq6bAeAwXMRtJv+jb9fIuALCnLmJk5MUhn7iG08S3+NFqA= From: Bertrand Marquis To: Michal Orzel CC: Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu Subject: Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE Thread-Topic: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE Thread-Index: AQHXFXrOKr1ioWnJ5USYV383dKI5L6p83WMA Date: Wed, 10 Mar 2021 08:05:46 +0000 Message-ID: <8AAFFE95-AA19-4616-8100-D031FB5731BD@arm.com> References: <20210310065803.348-1-michal.orzel@arm.com> In-Reply-To: <20210310065803.348-1-michal.orzel@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.243.24.187] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 740c8d4f-79e8-47c6-ee2a-08d8e39b56f9 x-ms-traffictypediagnostic: VI1PR08MB3791:|AM0PR08MB4467: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cweQ3YS0tDA6dbYEYHlPCZNJBdcLptXI+XhGDWw9PmYWGmCHEjmSkQIsrffN1+13iOrpx5JRwBybZma7LhBxw9uR3dEYh9Jws/5xzZsYLqbQa3CPYM5eL35vklPR8+CTJ5yKnadSFrXVslCgeQMJvSsrEg6nzZbEAz4vMvBQj52GU8Rhm92ERKLEdtbizGyNdU0NjhpiIcouY/ohlu2XRXuGMuMmaqsAFTXIDl2K5ymva2PyVelkH8ZDd3sazwZDQlAPD8aF45F9x9bH5bYGTIpZJW9SEESy+cDOoL6UxKQFZcqL9LxinYGJl//fgkcXzVI01XfmxUAODfPUdz6atFfL3vJlVJpo3YuzDPlMPrHyf1JkNEhVDvxO+fmgxTQVY0gmn3Ah5d6TZgCZW9DyrYInZgLGyltIubapiAloIkX5JP5i2MK1EqZUWHTNjDtu8vPo/PRzzdCcIi+ZSliWyEbeU+D++crIXnPbMNmTkHJzR42pBufIgpfzfE/V9T5FFZKle3tKfwHoAZ9UTMTM4znXP3ZanBeXiU4Wo6mcatoiGdgiqN+uwCxcOksDfN4vfwT7fqfuEM3ts5Sjq+H/XA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(346002)(39860400002)(136003)(396003)(4326008)(6506007)(53546011)(5660300002)(316002)(54906003)(64756008)(66446008)(2616005)(66946007)(66556008)(66476007)(76116006)(37006003)(6636002)(91956017)(6512007)(83380400001)(36756003)(6486002)(8936002)(33656002)(2906002)(6862004)(26005)(71200400001)(478600001)(186003)(8676002)(86362001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?c2Ms4gQFUoE62IoRZ0o3fpwDepbb/P3Xkxq08UmsOMubzMtXUZWavbklGWBd?= =?us-ascii?Q?bYzsoAluMAEhdBYUPwTp+0IGziGi4EVtb9fT2bH4yoGN1QbOg66VxmihFhG/?= =?us-ascii?Q?qVu47pLv+hPVDuVxeDvCqsNgD9jhHHoObTG5iKoswXj2FHEK5UiE92KYuS15?= =?us-ascii?Q?9L6NgqZ5whs15MwiFl/UXcWkPkV7+8Y7UWclgGgJWyG+/0BFQBNNzTN7XL8l?= =?us-ascii?Q?F05Fi+GaBdJeLIXVMd9k4xLPPsBLSM7djBNStSM8NjkUx/jawDLojHfHlqdk?= =?us-ascii?Q?O1wV9HAnKXZmQ7f8g7FB8cP7p9ii60Mm53m4Ct2MInW9W3yGDkQUF41ygfcS?= =?us-ascii?Q?MDdPC66uJDRhrYsHydaRDMQrnLRXvFY8rpgCIwMwP8jBM24DJazvBMnfruiz?= =?us-ascii?Q?QdRewkg/sNvbUbFZWlgiEJrXd01B7EtL123Fxd7TQhvn47r+Woq+6bb9M4go?= =?us-ascii?Q?J7gyYmyRaXiaHb297K0ju9VbvQOOGKCFUPlR1a07+t+i+bWyBNTD9C82FldP?= =?us-ascii?Q?2Y0uUKtp4A3cNJROcYIvzOsnIr3GepIFKyjYCMI6FWGxROdTzOhcttDE58yp?= =?us-ascii?Q?7702lzmio19x9FI8AHY3Bxhqnfr6PiDash0AAnX/hrQreGLkxEhBiMN377vM?= =?us-ascii?Q?jqV2GC2hGjk0Nk3hrmMEWaYhXRQjHqXy5GSx3aokyaA9TlNDxVLrABRJYtrw?= =?us-ascii?Q?UN8WtMlj8/yY+Fsv2dUhWKTEFEIldIa3xnl7ZrBzQWF67qEph1P+Xsr0b+6H?= =?us-ascii?Q?6FdsXzAMNiti6oa1ez2fw+0RbNB+CmhjYOcOA/6e7dcF497XrX85d8B0MbNV?= =?us-ascii?Q?Buczv8GbXMakJk73BYa+v2BmeFcX0OzE7FIwibvTOgGhHFne3h5JXzObjs8m?= =?us-ascii?Q?LsscQ/Iu4jfr6wI1h/sHabtlQBA4YKtzkN68kKBOES2PBQKr9/bAsHvI777j?= =?us-ascii?Q?tK+B77dp5c5DTSOQ2rX8+7jNCiSRKvndYmpVjfdJo0bpZcA8LMHm5AGi0OLP?= =?us-ascii?Q?I8X/ir6EFhnXdJHXFfhWYpq0CbPmJMWvCSl+Tw48hMFIf49o3djNLyy0yfdy?= =?us-ascii?Q?TJR22s5o+OryE0aIG21OQdtVaKABxwmpX7Za/Rf+8nOiOlCYV80v0Pr/KKcX?= =?us-ascii?Q?VQC7T0xoqP94gAqFAIHzmZNPWvSPu3OyAL64V6CkfKxSqlLHkTFUSF6q9dj5?= =?us-ascii?Q?VLeN/G69gLUhrj+DHvb0uFOkyUn83ftUrrpuwc9Fx+5jGD+WakgRwmKMe7qK?= =?us-ascii?Q?lpWQGq7QB3El5o9ikpS+ZyvXWN//I15Of63rgbTzh1g8ghQ9OShJ/6Yajvqg?= =?us-ascii?Q?dKDjN33i7YT5mE8nOiDjJElQZRaSrfVWkaUVxo4qBuUDQw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <4B9CD19A494B3E438EA085D92F90D261@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3791 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 2f51fb04-4725-4f90-e121-08d8e39b4f70 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G7dtrkOMRsiLI4MdZIPflvQmAsSbAjV3MNmkdgf/VNCT8TUSdXn+L+LAhfQnyb4UsJea5N2eUb2eoc/DVbVeT2K7V3p75gYlvyPe7Q3Hjks0iFuFQlsDDnR7l0ELEgQ21iqstJeBv8/R8AjJngJxwJ8aeh9J0tRA2czfmv50UmC28P0DPfNvddwG1WCkgErIgZZ6PeavqN3+dnNF+IhhSgHz0B589vtupsilyKMMUsYO08kihVSwfcz6wQXJvuejmXwi7R6fuyjwIaFiXFeZhGos+DDczvxVPb2cSis36fb5cCGesjAddTUPVIUBNm85PxOYCzuN9zwQmLcOSQGCz2cZbv4tHy6RTEzXRBpWnCv2CWI9MJX3vMKzKwHJ1zwuwXD1c0FWg17uH53kH+N02Dadw1yODaKKA3sNBA+ZpGCCPUQHsIzFKWm2PuB201tVlSQ/jGu25Q9NQ77rXV2WyYwail3WQYq0kLGh1VsxXS0V+uzIBJgr6MzHxuxCWdJ0eT69JiURQn3T3eX2zWmKE6SDOJDz1Flhlw9umQWxsACoCeBgcAVByeuQgpAPA9KjI6NruOkbXaroz+lf4KXiC46i+46arhO/3jvYeyR7o8ebvKhVWAhKMGpI6at+hWe6E0lUvb6VVcWn7G955XK50HHQGt0qZEiTDHyNFEPMrvo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(39860400002)(136003)(396003)(376002)(46966006)(36840700001)(53546011)(5660300002)(6506007)(82310400003)(37006003)(36756003)(36860700001)(2616005)(81166007)(70206006)(6636002)(70586007)(8676002)(26005)(4326008)(82740400003)(54906003)(316002)(33656002)(478600001)(6862004)(6486002)(6512007)(47076005)(336012)(356005)(8936002)(186003)(2906002)(83380400001)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 08:05:59.1511 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 740c8d4f-79e8-47c6-ee2a-08d8e39b56f9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4467 Hi, > On 10 Mar 2021, at 07:58, Michal Orzel wrote: >=20 > Currently in order to link existing DTB into Xen image > we need to either specify option CONFIG_DTB_FILE on the > command line or manually add it into .config. > Add Kconfig entry: CONFIG_DTB_FILE to be able to > provide the path to DTB we want to embed into Xen image. > If no path provided - the dtb will not be embedded. >=20 > Remove the line: AFLAGS-y +=3D -DCONFIG_DTB_FILE=3D\"$(CONFIG_DTB_FILE)\" > as it is not needed since Kconfig will define it in a header > with all the other config options. >=20 > Signed-off-by: Michal Orzel Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/Makefile | 5 ++--- > xen/common/Kconfig | 8 ++++++++ > 2 files changed, 10 insertions(+), 3 deletions(-) >=20 > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index 16e6523e2c..46e6a95fec 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -68,9 +68,8 @@ extra-y +=3D $(TARGET_SUBARCH)/head.o >=20 > #obj-bin-y +=3D ....o >=20 > -ifdef CONFIG_DTB_FILE > +ifneq ($(CONFIG_DTB_FILE),"") > obj-y +=3D dtb.o > -AFLAGS-y +=3D -DCONFIG_DTB_FILE=3D\"$(CONFIG_DTB_FILE)\" > endif >=20 > ALL_OBJS :=3D $(TARGET_SUBARCH)/head.o $(ALL_OBJS) > @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c > xen.lds: xen.lds.S > $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >=20 > -dtb.o: $(CONFIG_DTB_FILE) > +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) >=20 > .PHONY: clean > clean:: > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index eb953d171e..a27836bf47 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -400,6 +400,14 @@ config DOM0_MEM >=20 > Leave empty if you are not sure what to specify. >=20 > +config DTB_FILE > + string "Absolute path to device tree blob" > + depends on HAS_DEVICE_TREE > + ---help--- > + When using a bootloader that has no device tree support or when there > + is no bootloader at all, use this option to specify the absolute path > + to a device tree that will be linked directly inside Xen binary. > + > config TRACEBUFFER > bool "Enable tracing infrastructure" if EXPERT > default y > --=20 > 2.29.0 >=20 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 08:17:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 08:17:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95902.181075 (Exim 4.92) (envelope-from ) id 1lJu1v-0005Nk-J4; Wed, 10 Mar 2021 08:17:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95902.181075; Wed, 10 Mar 2021 08:17:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJu1v-0005Nd-Fm; Wed, 10 Mar 2021 08:17:19 +0000 Received: by outflank-mailman (input) for mailman id 95902; Wed, 10 Mar 2021 08:17:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJu1u-0005NV-Qw; Wed, 10 Mar 2021 08:17:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJu1u-0005Nd-KC; Wed, 10 Mar 2021 08:17:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJu1u-0008N8-Cb; Wed, 10 Mar 2021 08:17:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJu1u-0008Pi-C7; Wed, 10 Mar 2021 08:17:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XXdFibj4VnuM0lNjDCBK+Vtflh/fvDLIpl9MP9maHDg=; b=cJ30MXCvgQ8wv5Ev2KGd68mgGj jp4U80L0+Y9kXjApw4Wq5yIbX3UxKNUzwt+eA6zBQE6HpAbtizhhkbrs67QWvEt+ybdwY0eFIBHYJ MVNRHaGXFx0rtZe9BP5trElbQBGnTAs3r8OUOJI2a1LYsWXr6Kcs35AWJc4jMA4JrJQU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159893: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=682edc95da4f0ffe8149b4651e5808c76d3a8987 X-Osstest-Versions-That: xen=60c0444fae2148452f9ed0b7c49af1fa41f8f522 From: osstest service owner Date: Wed, 10 Mar 2021 08:17:18 +0000 flight 159893 xen-unstable real [real] flight 159904 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159893/ http://logs.test-lab.xenproject.org/osstest/logs/159904/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 159904-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail like 159882 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159882 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159882 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159882 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159882 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159882 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159882 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159882 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159882 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159882 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159882 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159882 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 682edc95da4f0ffe8149b4651e5808c76d3a8987 baseline version: xen 60c0444fae2148452f9ed0b7c49af1fa41f8f522 Last test of basis 159882 2021-03-09 01:59:48 Z 1 days Testing same since 159893 2021-03-09 15:07:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Roger Pau Monne Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 60c0444fae..682edc95da 682edc95da4f0ffe8149b4651e5808c76d3a8987 -> master From xen-devel-bounces@lists.xenproject.org Wed Mar 10 08:55:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 08:55:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95910.181098 (Exim 4.92) (envelope-from ) id 1lJucO-0000Zw-Ju; Wed, 10 Mar 2021 08:55:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95910.181098; Wed, 10 Mar 2021 08:55:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJucO-0000Zp-Fd; Wed, 10 Mar 2021 08:55:00 +0000 Received: by outflank-mailman (input) for mailman id 95910; Wed, 10 Mar 2021 08:54:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJucN-0000Zk-N7 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 08:54:59 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 05d5a3d3-fe23-40cf-993b-8a7b725c8e73; Wed, 10 Mar 2021 08:54:58 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F1160AD74; Wed, 10 Mar 2021 08:54:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05d5a3d3-fe23-40cf-993b-8a7b725c8e73 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615366498; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m0LTtDPgjAu1AKLTSf2rfs4Wlipb/s589qLDfrqxtEA=; b=ZdbGwPNeXOhQzuDyCEwvAqIUAfVrmxlTcC4OaVRBrPfXP2DAljHTkdROjaUqRxK1HxFaUr NvHin0MKnKtZbZ2zve5mHHXiB3G3xaWN/BVDGPznHnxL+70Yy9Ua3cZsxUMHKs5ctPP+Ph 36sO3LSTJ4wlC/j9EE4jtmkp59obH9Y= Subject: Re: [PATCH for-4.15] arm: replace typeof() with __typeof__() To: Andrew Cooper Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , George Dunlap , Ian Jackson , Wei Liu , Juergen Gross , xen-devel@lists.xenproject.org, Elliott Mitchell References: <202103092114.129LEgZp059925@m5p.com> From: Jan Beulich Message-ID: Date: Wed, 10 Mar 2021 09:54:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09.03.2021 22:27, Andrew Cooper wrote: > On 08/03/2021 13:36, Elliott Mitchell wrote: >> typeof() is available in Xen's build environment, which uses Xen's >> compiler. As these headers are public, they need strict standards >> conformance. Only __typeof__() is officially standardized. >> >> A compiler in standards conformance mode should report: >> >> warning: implicit declaration of function 'typeof' is invalid in C99 >> [-Wimplicit-function-declaration] >> >> (this has been observed with FreeBSD's kernel build environment) >> >> Based-on-patch-by: Julien Grall , Sun Oct 4 20:33:04 2015 +0100 >> Signed-off-by: Elliott Mitchell > > s!arm!xen/public! in the subject seeing as two thirds of the > modifications are in non-ARM headers. > > Acked-by: Andrew Cooper > > This wants backporting as a build fix, so should be considered for 4.15 > at this point. > > I wonder why our header checks don't pick this up.  Do we need to throw > a -pedantic around? That's a long-standing issue with the checking: For issues to be found in macros, the macros would actually need to be used. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 10 09:00:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 09:00:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95917.181110 (Exim 4.92) (envelope-from ) id 1lJuho-0001Xp-A9; Wed, 10 Mar 2021 09:00:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95917.181110; Wed, 10 Mar 2021 09:00:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJuho-0001Xi-6N; Wed, 10 Mar 2021 09:00:36 +0000 Received: by outflank-mailman (input) for mailman id 95917; Wed, 10 Mar 2021 09:00:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJuhm-0001Xd-HU for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 09:00:34 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4dbb345b-2d2f-4102-be7e-1182ff352c7e; Wed, 10 Mar 2021 09:00:33 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 71417AD74; Wed, 10 Mar 2021 09:00:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4dbb345b-2d2f-4102-be7e-1182ff352c7e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615366832; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OTr2wJ5XeMutAszimHjmu47PkcDW5hHRBQjZt8mVSBE=; b=jnyNuuc9Hr1M7Nwv8X/M/5ZoKNtyV+V81d3dMNVVBDpt/zVuppKbkUUTu2x3bhBKLzbPh8 ceE5OyMpAKa2vycxcxdGJVEEFU9F+HhgpSC/IzPWOkfurnInEPRC60Wc/n/0yx/fGBUqtn 1jYaClbOK2ZwseedzUuBUcDY/xJaLOg= Subject: Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210310065803.348-1-michal.orzel@arm.com> From: Jan Beulich Message-ID: <3247ee1d-f843-7c74-20a4-315716a91097@suse.com> Date: Wed, 10 Mar 2021 10:00:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210310065803.348-1-michal.orzel@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10.03.2021 07:58, Michal Orzel wrote: > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -400,6 +400,14 @@ config DOM0_MEM > > Leave empty if you are not sure what to specify. > > +config DTB_FILE > + string "Absolute path to device tree blob" > + depends on HAS_DEVICE_TREE > + ---help--- > + When using a bootloader that has no device tree support or when there > + is no bootloader at all, use this option to specify the absolute path > + to a device tree that will be linked directly inside Xen binary. Nit: Linux, iirc, has dropped support for ---help--- (allowing only help now). To limit churn whenever we're going to re-sync our kconfig again, I'd like to avoid introduction of new uses of the old form. I'm sure this could be taken care of while committing. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 10 09:09:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 09:09:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95921.181122 (Exim 4.92) (envelope-from ) id 1lJuq7-0001pg-44; Wed, 10 Mar 2021 09:09:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95921.181122; Wed, 10 Mar 2021 09:09:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJuq7-0001pZ-0q; Wed, 10 Mar 2021 09:09:11 +0000 Received: by outflank-mailman (input) for mailman id 95921; Wed, 10 Mar 2021 09:09:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJuq4-0001pU-RV for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 09:09:08 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5a4fab66-27ae-4504-9f4f-fb36d0266568; Wed, 10 Mar 2021 09:09:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a4fab66-27ae-4504-9f4f-fb36d0266568 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615367347; h=subject:from:to:cc:references:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=4VmRMA+z46nfmAF79aPtxD7G3DEltQtHlbCtG5CBYG4=; b=DSNSKvuHi4szfT/QUYdsiFs1Nsx6SBK2uN4tmgDCRiYNb4oIl3FH+JCE 4WdwxUsthHP4JuKnp9CZXu3+xmkcb0ZxowUPWT3eBOc6O/myBl6B4myBb d8whet+j3qX4o+D7dkktlmmUasyZZI3lY0xl9jDQgBnXX4dWTiFSdaoxD 0=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: +BTeAh8Uamfyx7JXECtHe4MHBr+LasAM5IXnbCFVbC7EHr7AXjhpZ2DwltkQWS/F20JUriuzsK yA5Ums4mSHCc8c4kJo1ffSBruToMR/0xTG6++UDBIcucvS/OvayHRSpbeMhDloJihYTntaNyfa jqEn4uvZWBAZ+riECrRqYQ3GbIVyT8sXD7xh9a04GX7/ut8T9qZklS1VhoeCKg5MZXjDg8V1Yx 2w+5DjAbQJ9y7wGBDeYwVdahccCzVTRTFQyNi3lPb7BZqcVSOErEkrrdzjhPrJtpRcNvfkEfvQ zxE= X-SBRS: 4.0 X-MesageID: 38931597 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,237,1610427600"; d="scan'208";a="38931597" Subject: Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending From: Ross Lagerwall To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Boris Ostrovsky , , CC: Stefano Stabellini , , Julien Grall , Julien Grall References: <20210306161833.4552-1-jgross@suse.com> <20210306161833.4552-3-jgross@suse.com> Message-ID: <3880be9d-1176-8beb-b192-20078cd39038@citrix.com> Date: Wed, 10 Mar 2021 09:08:34 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit On 2021-03-09 08:57, Ross Lagerwall wrote: > On 2021-03-09 05:14, Jürgen Groß wrote: >> On 08.03.21 21:33, Boris Ostrovsky wrote: >>> >>> On 3/6/21 11:18 AM, Juergen Gross wrote: >>>> An event channel should be kept masked when an eoi is pending for it. >>>> When being migrated to another cpu it might be unmasked, though. >>>> >>>> In order to avoid this keep three different flags for each event channel >>>> to be able to distinguish "normal" masking/unmasking from eoi related >>>> masking/unmasking and temporary masking. The event channel should only >>>> be able to generate an interrupt if all flags are cleared. >>>> >>>> Cc: stable@vger.kernel.org >>>> Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn framework") >>>> Reported-by: Julien Grall >>>> Signed-off-by: Juergen Gross >>>> Reviewed-by: Julien Grall >>>> --- >>>> V2: >>>> - introduce a lock around masking/unmasking >>>> - merge patch 3 into this one (Jan Beulich) >>>> V4: >>>> - don't set eoi masking flag in lateeoi_mask_ack_dynirq() >>> >>> >>> Reviewed-by: Boris Ostrovsky >>> >>> >>> Ross, are you planning to test this? >> >> Just as another data point: With the previous version of the patches >> a reboot loop of a guest needed max 33 reboots to loose network in >> my tests (those were IIRC 6 test runs). With this patch version I >> stopped the test after about 1300 reboots without having seen any >> problems. >> > > Thanks, I'll test it today and get back to you. > Tested-by: Ross Lagerwall The updated patch seems fine in testing. Thanks Ross From xen-devel-bounces@lists.xenproject.org Wed Mar 10 09:33:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 09:33:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95928.181134 (Exim 4.92) (envelope-from ) id 1lJvDU-0004TP-5r; Wed, 10 Mar 2021 09:33:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95928.181134; Wed, 10 Mar 2021 09:33:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvDU-0004TI-1N; Wed, 10 Mar 2021 09:33:20 +0000 Received: by outflank-mailman (input) for mailman id 95928; Wed, 10 Mar 2021 09:29:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJv9l-0003j9-Df for xen-devel@lists.xen.org; Wed, 10 Mar 2021 09:29:29 +0000 Received: from smsin.roj.com (unknown [89.96.160.179]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 12689618-ef9b-462f-9d68-6c73f72775de; Wed, 10 Mar 2021 09:29:27 +0000 (UTC) Received: from mail.roj.com ( [192.168.254.110]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by smsin.roj.com (Symantec Mail Security) with SMTP id B0.7A.21443.67198406; Wed, 10 Mar 2021 10:29:26 +0100 (CET) Received: from ROJMAIL2016.ROJ.corp (10.139.1.110) by ROJMAIL2016.roj.corp (10.139.1.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 10 Mar 2021 10:29:25 +0100 Received: from ROJMAIL2016.ROJ.corp ([fe80::ac45:1b07:6a6f:c237]) by ROJMAIL2016.roj.corp ([fe80::ac45:1b07:6a6f:c237%4]) with mapi id 15.01.1713.009; Wed, 10 Mar 2021 10:29:25 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12689618-ef9b-462f-9d68-6c73f72775de X-AuditID: c0a80408-6231f700000053c3-bc-604891769b60 From: Gurrieri Stefano To: "xen-devel@lists.xen.org" Subject: HOWTO enable Xen on my board based on STM32MP1 Thread-Topic: HOWTO enable Xen on my board based on STM32MP1 Thread-Index: AdcVj1dWrgn5iepWTpm9UYvkY91w1w== Date: Wed, 10 Mar 2021 09:29:25 +0000 Message-ID: <1449aa784e6243ee9a8e33642dcb7693@roj.com> Accept-Language: it-IT, en-US Content-Language: it-IT X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.139.100.56] Content-Type: multipart/alternative; boundary="_000_1449aa784e6243ee9a8e33642dcb7693rojcom_" MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAIsWRmVeSWpSXmKPExsVyYMW/PN2yiR4JBu9aOCyWfFzM4sDocXT3 b6YAxqgGRpvEvLz8ksSSVIWU1OJkWyWXzOLknMTM3NQiJYXMFFslIyWFgpzE5NTc1LwSW6XE goLUvBQlOy4FDGADVJaZp5Cal5yfkpmXbqvkGeyva2FhaqlrqGTnlp+Tk1+uUFqskJ+nEJlf GlKalGqlkFFSUpDwRSSjfz1PwWGJivvfl7I0MB4S7WLk5JAQMJG4uGwBaxcjF4eQwGQmiUP7 frGDJIQEXjJKnPvGDZHYxSix/cE1xi5GDg42AUOJ/ed4QWpEBMwlti7ZwghiCwPZm85A9IoI 2Eh82vWEFaRcREBPYv7tUpAwi4CqxJuJl5hBbF4BM4mfq/tZQWxGAVmJCbsXgY1hFhCXeDH9 BDvEbQISS/acZ4awRSVePv7HCmErSnTe7WSCqI+TWLpmFQvETEGJkzOfsExgFJqFZNQsJGWz kJRBxHUkFuz+xAZha0ssW/iaGcY+c+AxE7L4Akb2VYy8xbnFmXl6RflZesn5uZsYwfHOwrGD cfPkr3qHGJk4GA8xSnAwK4nw+h13SxDiTUmsrEotyo8vKs1JLT7EaAEMhInMUtzJ+cCEk1cS b2xggMJREucNM4uNExJIB6aU7NTUgtQimFYmDk6pBiaOKVbnN6Wn6ZpJzNh+Rrb8gfQylpzK MN/GM5wpu3vmHm1oC4470CfCsEegedOLGUz7SnI91H0nzZX5Ns9vevwltaovRzp/Pfwf3J9c /fN3S/ZCGZ05+acdYif8uDGPz8rP4Vzol88NBU0embK+i5t4N847xX33irfRg5tMvNzL/Cx3 2E6932H952Hvklvt7dJKN+yZ+HgOVUbt3VzvpHX24rcp39wk12dcZ9WeuOLzmsU6Js3fdcLO r+p/1N66Te312+3zKmVMuQ56Chxd9rnzXaoJ24VzGWdWX1yy+/2lsFMs0lu2/ingOJjQ4b74 4dTo5adbUw/G/OqJ8gxn0zL4Mj1aL8k/cMaEmxlbgqqUWIozEg21mIuKEwEgrWLQgwMAAA== --_000_1449aa784e6243ee9a8e33642dcb7693rojcom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello, I'm working on the platform STM32MP1 based on cortex-A7 dual core. This is a= n armv7-A that has the "Hardware virtualization support". My current Linux BSP is built using Yocto Project... but now, I'm asking how= to enable XEN on my platform? Is there a procedure to follow to try to expe= riment? Thanks a lot! Greetings, Stefano Follow us on YouTube: https://www.youtube.com/channel/UC9nTKjeq8UdxExKnCNXDP= mA Prima di stampare, pensa all'ambiente ** Think about the environment before= printing ROJ S.r.l. - Biella - Italy (www.roj.com) Tel: +39.015.8480111 Fax: +39.015.405815/8480209 This e-mail and any files transmitted with it is confidential and intended o= nly for the stated addressee(s). Any unauthorised disclosure, use or dissemi= nation, either whole or partial, by person or entities other than the addres= see(s) is prohibited. Please notify the sender immediately by e-mail if you= have received this e-mail by mistake and delete this e-mail from your syste= m. Please note that any views or opinions presented in this e-mail are solely t= hose of the author and are not necessarily endorsed by the company. Although= the company has taken reasonable precautions to ensure no viruses are prese= nt in this e-mail, the company cannot accept responsibility for any loss or= damage arising from the use of this e-mail or attachments. --_000_1449aa784e6243ee9a8e33642dcb7693rojcom_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hello,

 

I’m working on the platform STM32MP1 based on c= ortex-A7 dual core. This is an armv7-A that has the “Hardware virtuali= zation support”.

My current Linux BSP is built using Yocto ProjectR= 30; but now, I’m asking how to enable XEN on my platform? Is there a p= rocedure to follow to try to experiment?

 

Thanks a lot!

Greetings,

Stefano


Follow us on YouTube

Prima di stampare, pensa all'ambiente ** Think about the environment before= printing
ROJ S.r.l. - Biella - Italy (www.roj.com)
Tel: +39.015.8480111 Fax: +39.015.405815/8480209

This e-mail and any files transmitted with it is confidential and intended o= nly for the stated addressee(s). Any unauthorised disclosure, use or dissemi= nation, either whole or partial, by person or entities other than the addressee(s) is prohibited. Please noti= fy the sender immediately by e-mail if you have received this e-mail by mist= ake and delete this e-mail from your system. Please note that any views or opinions presented in this e-mail are solely t= hose of the author and are not necessarily endorsed by the company. Although= the company has taken reasonable precautions to ensure no viruses are present in this e-mail, the company can= not accept responsibility for any loss or damage arising from the use of thi= s e-mail or attachments.
--_000_1449aa784e6243ee9a8e33642dcb7693rojcom_-- From xen-devel-bounces@lists.xenproject.org Wed Mar 10 09:33:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 09:33:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95931.181146 (Exim 4.92) (envelope-from ) id 1lJvE1-0004Y1-EZ; Wed, 10 Mar 2021 09:33:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95931.181146; Wed, 10 Mar 2021 09:33:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvE1-0004Xu-BA; Wed, 10 Mar 2021 09:33:53 +0000 Received: by outflank-mailman (input) for mailman id 95931; Wed, 10 Mar 2021 09:33:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvDz-0004Xn-FR for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 09:33:51 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d9b2f481-325c-4347-b85b-6796d5aa0264; Wed, 10 Mar 2021 09:33:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9b2f481-325c-4347-b85b-6796d5aa0264 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615368830; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=vUE9Zwwbm825ZnVQZ/NF2c62gs4Cjq8UGLO+t/md7EA=; b=T/jXuDLdOOAFEUt81uDpIQf1wIVObDzrLrno4ox2E7GzZyy5gByTe7Nu xDiO0CzpWTn2sviAty7mUKK2/6iDdxtGji6+Ib+MZ1Nm8Xgbr+/5a0bw3 e7PUcsGTcLPseMSsgnLAiHl3Bz5zmgBFKzO/7+K+AI9x2eQgyITKyTcJS 4=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 1R+wBfQouc/GyzeMVpI50Rd7lJ/u1+pEVibCeJoVQoFE8CCP5Xt4s7/9GUVFIXcvtNy9UKeYwa rwuVROwQ/Fk4hLVzM36yotT9FVKzdD8z9KEtF51nYNEo5VI1gj1DvMD23cPEEVt0oG5jbiEZ8W m71jxb4FIyqUM5sCEWjfZQNRlUHOK3jhRwvtgDo9V/H6+6aga3TWc6HFv3RpLCJwup6O3woB5G uNreCh+38ErlOP5uPTp/Ii4J0mP8Wh8NS9jL9zUGfVpiJ/JgrLkIngIkthy73MfWWEgdl84nEa 7gk= X-SBRS: 5.2 X-MesageID: 38933019 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,237,1610427600"; d="scan'208";a="38933019" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cWS6NvuUmh/LZVubQs7IAWi5jlvol/+g7ICPn9V2uHQVIPwQ0+WULdVeg1delJXbDNx/3UR98lSN60vWs5kHxwrOWix3O2TE8JuGg4Sk7IfepSglrZ37LhuS3twXBUDJoA8q2cHno6+bQ7rgTJZGvzJGInYbc+tKDNGnJ33k87XkkF2o/oiuOj++PTnGA8XEzBmcRHrmmGtbEkAjZdEgB6eUKmjKYj0gvIT1WUeTdzyUxu8mfUz5hgaNZwzURdLzMzYlXW30mqvx4iZRXmn6W2ffsD/zFqg7GlfYdh4E1zeUuthUdiR3iFWudFpmIHcyXk6d22zefuGKC8Yy8t+C0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mkYzQmaI74fUYW98c90Ctctx2PFPCJPbIhEfdEsz2ig=; b=eZKnp8ss3zSZU6q2s5VngqcRNjk5TTyG47dTNZ4VIWjnnwXcbjqCdtEvdIe2+8xLLPvC2E5c54C5EWe5zH5QlcPz8W/oCqAB4/2e8EINHTOgC91dy/TB1sSpy4NtXgvMS9N9bQYxQXdOE1BzN6uyoU7Ilew2RGuDJIcHTd1+NgiWm4rs+18JiZlKxiIHFL9/r6NJD0BPDT45PcpOTnbLohXLaietGZeru27TG0laWwRgZjaGn8PoQ6LII+ztR/Qg0XVmCjYh2wkEsUtYdjgs1cmHjNfaxU4uNQfZtmr9n4LsoDS8SNtPDNzKcM46OnnKRvXqLetdpayYbr3nnyDlBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mkYzQmaI74fUYW98c90Ctctx2PFPCJPbIhEfdEsz2ig=; b=G0pHbQaA9PDpyTPf4XSNZ62B7ZwRhPzV4pD8ASW/bKOMLYDuvYL522BtQW98F+za6Yot/4sJakbPveXOLmUkrNWgz1nzESZc6QLJB9iNxHQPhnO5jHaMXp/ojWfmifs/DhcEY7Dhmm+Av8c716yAWz0axvmdAFa9NSi+qUwd4/w= Date: Wed, 10 Mar 2021 10:33:17 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: , Ian Jackson , "Wei Liu" , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection Message-ID: References: <20210309105634.7200-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0329.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::10) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aa3d6e46-b1ed-476a-5adb-08d8e3a78d0b X-MS-TrafficTypeDiagnostic: DM6PR03MB4683: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eG90uArd5XY4rNTE7ZAMh8N1PLYYuLnb8WR0cgO1IiLkVk4roTqtwoGRT13Wj82XgJPVJNmdIlAqJpg5kX4c88hUaTYlRvXcTg2enxQr8fCYnvh46A005wp1E+I4egK3VH06H8zbqIRfmJ5qi0CQQi216t7l7tqTabO1EsTHUzvzWYxOX/8Y4WEQcwVL6okHKJIIUKfeSB9sWJ9CF0NMzxlppBD1+PYTlC4lZwRDNf/Y1EikbsAmv0cYeAOLBQ6efhbo1HfOQn7iUcwVBY7J5lruG1OjNmaTSP+sQNvqqIgmBKNbCPFLHwCpJrYsmIfj0nFZcUhQMbNaF8QskDQC1ERk9lParpbaJs1h1fQvwVcmn8ETgGtiqes5NqgECSst8nxiZdCAz2/SSHkZsn1+ZLtidGOBLca8XmVZuJ5vtfQY7E7BAzaVMY/SjhunHhEeNZrEJse35mITxMeWJTUMWt7G4gcvqaVl+njMibz7YU4++UlLrAAV9cJWwQZ3GV7QOGOMX79fnSBNDnqwkCTE0A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(136003)(39850400004)(396003)(346002)(376002)(16526019)(186003)(6496006)(7416002)(6636002)(2906002)(66946007)(83380400001)(33716001)(5660300002)(9686003)(53546011)(66556008)(26005)(66476007)(478600001)(4326008)(8676002)(316002)(6666004)(85182001)(54906003)(6486002)(86362001)(956004)(8936002)(6862004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZXZZcVkwUlVNekJxMnY5bjJWdWhEREVUUnI5SUo4alZFeXUyNVFDTmFsWUgz?= =?utf-8?B?ZjUxMCtXb0hYcC9yS2FzS29aRTArQXRxMzdWLzBIUlN1V2hWdUNET2U1aHU3?= =?utf-8?B?dDlwZzVhSjZocTBqbFV1R2tia3BZQ0psNTlYUm5qZCtqNkV3Mk8xaWpJTytC?= =?utf-8?B?ejJiNGtRK1QvK2U3a29qbUNMR0cvaFUxbzNLS2txWnlOeGc2WDVNNUl2Zjcy?= =?utf-8?B?ZE1mZWN5ZE92c0s3QkhiVWNJdEQ0S2I4ckJDTlczNEpQdzN2R2pIU1BPUmZm?= =?utf-8?B?K0EzdzFJNUdWSW9FNm83dlYwNmhNMHh3OUZ3Mkdlc0IzYzVZVU52ZThxZkNP?= =?utf-8?B?REgyK2JrSjIzQ2pCaTkzRXUvUS9FamZsZTU1LytmQmdpZ1RSNTdxRm16Z2R1?= =?utf-8?B?ZEliL2IvdzlIV3lCUGpZK0ZjcE5kSzNYWGRKbkNUVHBEYVpXUFRHZ2ZxRG1G?= =?utf-8?B?SHYvWkZqVURvWEV2d3J5bDZNS3hSa1poWEkrN3Jkbjh6TEw2V2dNcXk0aGhu?= =?utf-8?B?dVNFTExUR002b1UzR0NjU2JXejluZTdLbzZvQnA1QXVTNUVIakNjZ1NPU1RC?= =?utf-8?B?ZmdlYjRIWWZBamYwTUlsWDNYYm9UUTJXN3FHbGhpTnd4cWY4UHVFWnQyU2E3?= =?utf-8?B?djliMjVnQU5nbUZITjN6VlBKSkQyaDVpR2ZqQkxHTVRES29iOC9ocklqcjlN?= =?utf-8?B?WC9vdDN3dUpwRlFTMU1wZ0F6NnpBU2owQWFCV0hTZTgrRjJVNkRSb2I5OTdQ?= =?utf-8?B?N29RbDMwWHJnTGl0MTkrTng2RnFUTlJoSXNpeUJHa09Kb29kanJoS2RnY24x?= =?utf-8?B?bEg3aHBVdTBydXAwZHFmSVdld05WeVNPcmhGU3ROck1xOVFDdWtpc1l3eU1Y?= =?utf-8?B?UTdHdlNSaXNldFpoQTNLTlBiYUc4UnM1eWNNRXVEK3IyM0dtTVYrcGQyQjFD?= =?utf-8?B?T1M1SjNZRktROE91VjlFLzNGNnR2MFFGWW15dGx2KzR5WEVxK01yeVpSTklq?= =?utf-8?B?RGY1RFRDdldTZlZrVHpSdS9IdWU3SjRIQVkrYTRNRG5pYW5XZjBtMXhXVDFG?= =?utf-8?B?UURmL1RPdURxeENCRHZoNGZ3K1VvWVZsaXRvb0VscXZCL0FsL0dTYXE2ZWFE?= =?utf-8?B?VG1jRys4NEdxUG9XZUJuOTRQTFcyNGJ6Y2RzMDMwc3VxTmJMU0l4cnpNMitZ?= =?utf-8?B?c212SHFTdzdZbEpWSnd5b2VBblp4a3huTTFLVnFtcUliQUhEMjUwU2F4Z1Vo?= =?utf-8?B?bENJZlhUQjY1YmFOQ05yNkRqOUZwdnRadjkybDExNTJ5RTBVR3VpbDh1MUVi?= =?utf-8?B?YWhFbnpIRjNCbjhjYTZrbHZrZ1dCZ01FNDRZbVpxWmZXVC9LUXJKZDRwTHFG?= =?utf-8?B?MU9kZWxBTjZGU29ObkxmNng5Y1lmT1FxSENZRHoxUmtKQTFLT2NxSmxuOWN1?= =?utf-8?B?RmFoY0phWnlBMFZ1eXloYkZBNWFLaGNZRGZKbHhHWjJnV0kyYktuTXJoVDRR?= =?utf-8?B?VW9vUk15dFBNazMrYjBNb3dZZFBjY3NmYzBEckZrQUJZU2ppcjk0dm5PT0hr?= =?utf-8?B?Q0NvbUJ4MVZobk13dmVEUEU2RW1EcktsUTVvTWRRY3U1VllvYUxhOVBmUVdZ?= =?utf-8?B?NEYwWDR0MWI0SmdzOHd5V0U2V1FZc2wrdmpCTUh3QWM3VXFnTzBWaHA1MnJk?= =?utf-8?B?cEFiVUt2UmRRbVB4cXRIQ2VvNE00NEhQMGY2OTduSzlIbCtLRnpJZHM1UTZy?= =?utf-8?B?QkR6bG9qNTdxVVBUa3JuRmIrS05GbTB0SGJQTU9sZ2RubjJaUW9EQ3AvUVNE?= =?utf-8?B?SmtKb1BYakFJdnFNUERPUT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: aa3d6e46-b1ed-476a-5adb-08d8e3a78d0b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 09:33:24.0550 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 10A6TqebKqXD85pF1i3qA+HAEZ48YPYofTk+tNPjpqVQSI3aNvQjWf+QBdcvsz+Wc1KXuuGT+1dOCB1g7QlOUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4683 X-OriginatorOrg: citrix.com On Tue, Mar 09, 2021 at 07:13:26PM +0000, Andrew Cooper wrote: > On 09/03/2021 10:56, Roger Pau Monne wrote: > > Introduce an option to allow selecting a behavior similar to the pre > > Xen 4.15 one for accesses to MSRs not explicitly handled. Since commit > > 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly > > handled by Xen result in the injection of a #GP to the guest. This > > is a behavior change since previously a #GP was only injected if > > accessing the MSR on the real hardware would also trigger a #GP, or if > > the attempted to be set bits wouldn't match the hardware values (for > > PV). > > > > This seems to be problematic for some guests, so introduce an option > > to fallback to this kind of legacy behavior without leaking the > > underlying MSR values to the guest. > > > > When the option is set, for both PV and HVM don't inject a #GP to the > > guest on MSR read if reading the underlying MSR doesn't result in a > > #GP, do the same for writes and simply discard the value to be written > > on that case. > > > > Note that for guests restored or migrated from previous Xen versions > > the option is enabled by default, in order to keep a compatible > > MSR behavior. Such compatibility is done at the libxl layer, to avoid > > higher-level toolstacks from having to know the details about this flag. > > > > Signed-off-by: Roger Pau Monné > > Thankyou for doing this.  By and large, Reviewed-by: Andrew Cooper > , subject to some pandoc syntax fixes below. Thanks. > However, I think it is worth saying explicitly that the reasons behind > the changes in 84e848fd7a162f669 and 322ec7c89f6640e (not leaking > hardware MSRs, and not breaking #GP-probing) are still legitimate, and > this influences the change in behaviour between msr_relaxed and 4.14 > (i.e. read-as-zero rather than leaking). Right, I tried to convey this fact by using "compatible" behavior instead of "legacy" one, as the behavior provided by msr_relaxed is not exactly the same as what you would get on 4.14. I've added the following at the end of the first paragraph: "The reasons for not leaking hardware MSR values and injecting a #GP are fully valid, so the solution proposed here should be considered a temporary workaround until all the required MSRs are properly handled." > > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc > > index 4737c92bfe..6cf61a5c57 100644 > > --- a/docs/misc/xen-command-line.pandoc > > +++ b/docs/misc/xen-command-line.pandoc > > @@ -740,7 +740,7 @@ Specify the bit width of the DMA heap. > > > > ### dom0 > > = List of [ pv | pvh, shadow=, verbose=, > > - cpuid-faulting= ] > > + cpuid-faulting=, msr-relaxed= ] > > > > Applicability: x86 > > > > @@ -789,6 +789,21 @@ Controls for how dom0 is constructed on x86 systems. > > restore the pre-4.13 behaviour. If specifying `no-cpuid-faulting` fixes > > an issue in dom0, please report a bug. > > > > +* msr-relaxed: Select whether to use a relaxed behavior for accesses to MSRs > > + not explicitly handled by Xen instead of injecting a #GP to dom0. > > + Such access mode will force Xen to replicate the behavior from the hardware > > + it's currently running on in order to decide whether a #GP is injected to > > + dom0 for MSR reads. Note that dom0 is never allowed to read the value of > > + unhandled MSRs, this option only changes whether a #GP might be injected > > + or not. For writes a #GP won't be injected as long as reading the > > + underlying MSR doesn't result in a #GP. > > I don't find this overly clear to follow, and it also misses stating the > default explicitly.  How about: > > ---8<--- > The `msr-relaxed` boolean is an interim option, and defaults to false. > > In Xen 4.15, the default behaviour for unhandled MSRs has been changed, > to avoid leaking host data into guests, and to avoid breaking guest > logic which uses \#GP probing to identify the availability of MSRs. > > However, this new stricter behaviour has the possibility to break > guests, and a more 4.14-like behaviour can be selected by specifying > `dom0=msr-relaxed`. > > If using this option is necessary to fix an issue, please report a bug. > ---8<--- OK, this seems to be less verbose that what I previously had, but I'm fine with it. I assume this should also be changed in xl.cfg then? > Other pending Sphinx work is drawing together the "how to contact us" > information, so the various "please report a bug"s through this document > will turn into links. > > > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > > index 23bbb6e8c1..d217c223b0 100644 > > --- a/xen/arch/x86/setup.c > > +++ b/xen/arch/x86/setup.c > > @@ -749,6 +749,7 @@ static struct domain *__init create_dom0(const module_t *image, > > .max_grant_frames = -1, > > .max_maptrack_frames = -1, > > .max_vcpus = dom0_max_vcpus(), > > + .arch.domain_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, > > Can I request > > .arch = { >     .domain_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, > }, > > please, to reduce the patch complexity of further additions inside .arch. Sure. > > diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h > > index 629cb2ba40..f9d0e33b94 100644 > > --- a/xen/include/public/arch-x86/xen.h > > +++ b/xen/include/public/arch-x86/xen.h > > @@ -304,6 +304,14 @@ struct xen_arch_domainconfig { > > XEN_X86_EMU_PIT | XEN_X86_EMU_USE_PIRQ |\ > > XEN_X86_EMU_VPCI) > > uint32_t emulation_flags; > > + > > +/* > > + * Select whether to use a relaxed behavior for accesses to MSRs not explicitly > > + * handled by Xen instead of injecting a #GP to the guest. Note this option > > + * doesn't allow the guest to read or write to the underlying MSR. > > + */ > > +#define XEN_X86_MSR_RELAXED (1u << 0) > > + uint32_t domain_flags; > > The domain prefix is somewhat redundant, given the name of the structure > or the hypercall it is used for.  OTOH, 'flags' on its own probably > isn't ok.  Thoughts on misc_flags? I'm fine with it, will change unless Jan objects to the name. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 10 09:47:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 09:47:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95935.181157 (Exim 4.92) (envelope-from ) id 1lJvRL-0005gh-Lu; Wed, 10 Mar 2021 09:47:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95935.181157; Wed, 10 Mar 2021 09:47:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvRL-0005ga-Is; Wed, 10 Mar 2021 09:47:39 +0000 Received: by outflank-mailman (input) for mailman id 95935; Wed, 10 Mar 2021 09:47:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvRK-0005gS-Ie; Wed, 10 Mar 2021 09:47:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvRK-0006rV-7F; Wed, 10 Mar 2021 09:47:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvRJ-00048a-Up; Wed, 10 Mar 2021 09:47:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJvRJ-0003Sg-UL; Wed, 10 Mar 2021 09:47:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GgzjpSP1mypY/7EbqFfdrtLGMIlDegbRw/8njuHetGo=; b=bqi5tQXrF9Osd9zfwwuKLpxtNY Lx1DC+SxYXWOnHkq5vWPYrrHx8A07A3bkDSgaLFSX6657UelDNI79B9cdZ/FJziweBSmVm3dRscsx 3BsjwE+yYzdzw7b7Qf91xAexjeT44UtjPXG58jMPmAXInx9lhdzlCY9URFkUAOgFc3fo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 159907: all pass - PUSHED X-Osstest-Versions-This: xen=1b47cc852fd130ed9ce274a0f1600a4a62949a2c X-Osstest-Versions-That: xen=51972482f77b68ef494c8b9591b125460e7984b9 From: osstest service owner Date: Wed, 10 Mar 2021 09:47:37 +0000 flight 159907 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/159907/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 1b47cc852fd130ed9ce274a0f1600a4a62949a2c baseline version: xen 51972482f77b68ef494c8b9591b125460e7984b9 Last test of basis 159856 2021-03-07 09:20:39 Z 3 days Testing same since 159907 2021-03-10 09:18:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Roger Pau Monne Roger Pau Monné Tim Deegan jobs: coverity-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 51972482f7..1b47cc852f 1b47cc852fd130ed9ce274a0f1600a4a62949a2c -> coverity-tested/smoke From xen-devel-bounces@lists.xenproject.org Wed Mar 10 09:50:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 09:50:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95939.181173 (Exim 4.92) (envelope-from ) id 1lJvU8-0006VS-4t; Wed, 10 Mar 2021 09:50:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95939.181173; Wed, 10 Mar 2021 09:50:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvU8-0006VJ-1Y; Wed, 10 Mar 2021 09:50:32 +0000 Received: by outflank-mailman (input) for mailman id 95939; Wed, 10 Mar 2021 09:50:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvU6-0006VA-88; Wed, 10 Mar 2021 09:50:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvU6-0006vF-2I; Wed, 10 Mar 2021 09:50:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvU5-0004Kx-PW; Wed, 10 Mar 2021 09:50:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJvU5-0004QA-P4; Wed, 10 Mar 2021 09:50:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NTID5m1yIkhKfk2ARW9jDoAyWTDtN+jgH+pRKx7Ub+4=; b=y7nIYIM0r/a8hwyvnCyvTaICqe A1MsU3vvPCLrSQQYHXMGaCCf7BI3+cvsxVprVbGSHER+xYF1872V2Mx+KUpk8bRkLosowXz+pjDE0 ZVkDeJM/wZL9EvC4r/MWc5VgJgn+c3+nNGALgwxDBHsQ2eAa/YPc+MMt5YvAfZKRMa9A=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 159903: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=16634feb1d4b53053557af55c1d6eedb887fbc7c X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 10 Mar 2021 09:50:29 +0000 flight 159903 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/159903/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 16634feb1d4b53053557af55c1d6eedb887fbc7c baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 243 days Failing since 151818 2020-07-11 04:18:52 Z 242 days 235 attempts Testing same since 159903 2021-03-10 04:22:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 46697 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 10 10:13:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 10:13:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95948.181188 (Exim 4.92) (envelope-from ) id 1lJvpy-00005J-A3; Wed, 10 Mar 2021 10:13:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95948.181188; Wed, 10 Mar 2021 10:13:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvpy-00005B-6F; Wed, 10 Mar 2021 10:13:06 +0000 Received: by outflank-mailman (input) for mailman id 95948; Wed, 10 Mar 2021 10:13:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvpw-0008WR-Ie for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 10:13:04 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e0cec7fd-a36d-44d1-a694-87b6a78d97f2; Wed, 10 Mar 2021 10:13:03 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E4930AE55; Wed, 10 Mar 2021 10:13:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0cec7fd-a36d-44d1-a694-87b6a78d97f2 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615371183; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xSz8z++nz7zo0taD7a44rCc2zm2DDN7sLhZYwx3QeEc=; b=HYcMtDq7ts2An7e3foPmAye24NID+F3VGATq4wkH+wpHBQqE0oyEmQI/Vn76SrD41sl34N 2ejFbJUJI2PNHtui4pz3zZtiiNzHyhRSQE4ePqcmv6vV8EPOQ1ddR4mtaq+7q9pTJsI48n JKAnU55YXkgHemMN67HJsXXUj0t72TI= To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu From: Jan Beulich Subject: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning Message-ID: Date: Wed, 10 Mar 2021 11:13:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sadly I was wrong to suggest dropping vaddrs' initializer during review of v2 of the patch introducing this code. gcc 4.3 can't cope. Fixes: 52531c734ea1 ("xen/gnttab: Rework resource acquisition") Signed-off-by: Jan Beulich --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -4026,7 +4026,7 @@ int gnttab_acquire_resource( struct grant_table *gt = d->grant_table; unsigned int i, final_frame; mfn_t tmp; - void **vaddrs; + void **vaddrs = NULL; int rc = -EINVAL; if ( !nr_frames ) From xen-devel-bounces@lists.xenproject.org Wed Mar 10 10:20:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 10:20:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95951.181200 (Exim 4.92) (envelope-from ) id 1lJvwz-00012P-3B; Wed, 10 Mar 2021 10:20:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95951.181200; Wed, 10 Mar 2021 10:20:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvwy-00012I-Vu; Wed, 10 Mar 2021 10:20:20 +0000 Received: by outflank-mailman (input) for mailman id 95951; Wed, 10 Mar 2021 10:20:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJvwx-00012D-UX for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 10:20:19 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d56b667a-1de8-4d05-8854-626f3910cfe3; Wed, 10 Mar 2021 10:20:18 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 48FCFAC24; Wed, 10 Mar 2021 10:20:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d56b667a-1de8-4d05-8854-626f3910cfe3 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615371617; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W+LCkCzG3w3GXCtXrY1m7wP3TiuaQHK4fpn65yDyRWw=; b=C5mDVrvjISQFRPrX08rPJm3NOJUIdY0VafVFVhvTlwZ1vJOFsJi5qfAMrSctH7QLNnMGkt gIscOjxijQHUNgBHHZJVVzB7YJUELRgVWYtDJPX/wER9iKzBo/mIfqy8I/c5uQ7XdVN0n4 kL5TYFRllaIDYMsGkzWH9pAwFnvDtDQ= Subject: Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky , Andrew Cooper References: <20210309105634.7200-1-roger.pau@citrix.com> From: Jan Beulich Message-ID: <0371bfa5-7dd5-9ce2-ca1d-20e7f850938d@suse.com> Date: Wed, 10 Mar 2021 11:20:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 10.03.2021 10:33, Roger Pau Monné wrote: > On Tue, Mar 09, 2021 at 07:13:26PM +0000, Andrew Cooper wrote: >> On 09/03/2021 10:56, Roger Pau Monne wrote: >>> --- a/xen/include/public/arch-x86/xen.h >>> +++ b/xen/include/public/arch-x86/xen.h >>> @@ -304,6 +304,14 @@ struct xen_arch_domainconfig { >>> XEN_X86_EMU_PIT | XEN_X86_EMU_USE_PIRQ |\ >>> XEN_X86_EMU_VPCI) >>> uint32_t emulation_flags; >>> + >>> +/* >>> + * Select whether to use a relaxed behavior for accesses to MSRs not explicitly >>> + * handled by Xen instead of injecting a #GP to the guest. Note this option >>> + * doesn't allow the guest to read or write to the underlying MSR. >>> + */ >>> +#define XEN_X86_MSR_RELAXED (1u << 0) >>> + uint32_t domain_flags; >> >> The domain prefix is somewhat redundant, given the name of the structure >> or the hypercall it is used for.  OTOH, 'flags' on its own probably >> isn't ok.  Thoughts on misc_flags? > > I'm fine with it, will change unless Jan objects to the name. I'm fine with the suggestion. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 10 10:24:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 10:24:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95954.181211 (Exim 4.92) (envelope-from ) id 1lJw15-0001CR-KI; Wed, 10 Mar 2021 10:24:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95954.181211; Wed, 10 Mar 2021 10:24:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJw15-0001CK-HP; Wed, 10 Mar 2021 10:24:35 +0000 Received: by outflank-mailman (input) for mailman id 95954; Wed, 10 Mar 2021 10:24:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJw14-0001CF-7k for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 10:24:34 +0000 Received: from smtp-fw-4101.amazon.com (unknown [72.21.198.25]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6e72d90d-d512-4648-8c16-c0064fc13ff5; Wed, 10 Mar 2021 10:24:32 +0000 (UTC) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2c-c6afef2e.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP; 10 Mar 2021 10:24:25 +0000 Received: from EX13D38EUB001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2c-c6afef2e.us-west-2.amazon.com (Postfix) with ESMTPS id BB253A2840; Wed, 10 Mar 2021 10:24:23 +0000 (UTC) Received: from EX13D38EUB001.ant.amazon.com (10.43.166.110) by EX13D38EUB001.ant.amazon.com (10.43.166.110) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Mar 2021 10:24:22 +0000 Received: from EX13D38EUB001.ant.amazon.com ([10.43.166.110]) by EX13D38EUB001.ant.amazon.com ([10.43.166.110]) with mapi id 15.00.1497.012; Wed, 10 Mar 2021 10:24:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 6e72d90d-d512-4648-8c16-c0064fc13ff5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1615371874; x=1646907874; h=from:to:cc:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version:subject; bh=FvSvjguTLFZ1hhfb8GXwvVIqK8Ngn1VmFVpzPrk+vtc=; b=K4ExUeoDZtZss8ExAfsspXeKWi45YoAWrZQZElNQ0pRvE+g4ywE2618N Eaj/6W/sGjcOPwgPykB9D8H5KHQJADMQqPYtBu2ZS4BFpAA4kx+dzv1Ya FB8ztVOFLW4tJDDfNZrArJYHrU4Ac0ONZtOvBidjgfhaWo24lQcySC6db Q=; X-IronPort-AV: E=Sophos;i="5.81,237,1610409600"; d="scan'208";a="91705831" Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) Thread-Topic: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) From: "Zheng, Fam" To: "roger.pau@citrix.com" , "sstabellini@kernel.org" CC: "george.dunlap@eu.citrix.com" , "anthony.perard@citrix.com" , "andrew.cooper3@citrix.com" , "cardoe@cardoe.com" , "Bertrand.Marquis@arm.com" , "julien@xen.org" , "wl@xen.org" , "xen-devel@lists.xenproject.org" Thread-Index: AQHXEt09VDRvSzcs2kGB8AY7OydLi6p4fe6AgAJbNYCAAJiMAIAAB66AgADGvICAAJ7QAIAAKm8A Date: Wed, 10 Mar 2021 10:24:22 +0000 Message-ID: <985f49e153789ff2428a7b3f47a0b2557bf23c97.camel@amazon.com> References: <161507188317.11025.6744028462008264481@c667a6b167f6> <10b8048a-e8fe-1fcd-7291-7f1b16da2f4c@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.166.52] Content-Type: text/plain; charset="utf-8" Content-ID: <8D6519B30EEBE64592AE9E0AC0D73F42@amazon.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: Bulk T24gV2VkLCAyMDIxLTAzLTEwIGF0IDA4OjUyICswMTAwLCBSb2dlciBQYXUgTW9ubsOpIHdyb3Rl Og0KPiBDQVVUSU9OOiBUaGlzIGVtYWlsIG9yaWdpbmF0ZWQgZnJvbSBvdXRzaWRlIG9mIHRoZSBv cmdhbml6YXRpb24uIERvDQo+IG5vdCBjbGljayBsaW5rcyBvciBvcGVuIGF0dGFjaG1lbnRzIHVu bGVzcyB5b3UgY2FuIGNvbmZpcm0gdGhlIHNlbmRlcg0KPiBhbmQga25vdyB0aGUgY29udGVudCBp cyBzYWZlLg0KPiANCj4gDQo+IA0KPiBPbiBUdWUsIE1hciAwOSwgMjAyMSBhdCAwMjoyNDowNVBN IC0wODAwLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+ID4gT24gVHVlLCA5IE1hciAyMDIx LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiA+ID4gT24gVHVlLCBNYXIgMDksIDIwMjEgYXQg MTA6MDU6MThBTSArMDAwMCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiA+ID4gPiBIaSBTdGVmYW5v LA0KPiA+ID4gPiANCj4gPiA+ID4gT24gMDkvMDMvMjAyMSAwMDo1OSwgU3RlZmFubyBTdGFiZWxs aW5pIHdyb3RlOg0KPiA+ID4gPiA+IE9uIFN1biwgNyBNYXIgMjAyMSwgSnVsaWVuIEdyYWxsIHdy b3RlOg0KPiA+ID4gPiA+ID4gT24gMDYvMDMvMjAyMSAyMzowNCwgbm8tcmVwbHlAcGF0Y2hldy5v cmcgd3JvdGU6DQo+ID4gPiANCj4gPiA+IFdoZXJlIGRvZXMgb25lIGhhcyB0byByZWdpc3RlciB0 byBnZXQgdGhlIHBhdGNoZXcgYnVpbGQgZmFpbHVyZXM/DQo+ID4gDQo+ID4gQnkgYXNraW5nIEZh bSAoQ0MnZWQpIHZlcnkgbmljZWx5IDotKQ0KPiANCj4gVGhhbmtzISBDb3VsZCB3ZSBtYXliZSBz ZXR1cCBhIG1haWxpbmcgbGlzdCBmb3IgdGhvc2UgZW1haWxzPyBpZToNCj4gcGF0Y2hldy10ZXN0 c0AuLi4gb3Igc29tZSBzdWNoLCBzbyB0aGF0IHdlIGRvbid0IGhhdmUgdG8gZ28gYWRkaW5nDQo+ IHBlb3BsZSBtYW51YWxseT8NCj4gDQo+IFJvZ2VyLg0KDQpUaGUgaWRlYSAoSSB0aGluaykgaXMg dG8gZ3JvdXAgcmVwbHkgYWxsIG9uY2Ugd2UgZmVlbCBjb21mb3J0YWJsZSB3aXRoDQp0aGUgZmFs c2UgcG9zaXRpdmUgcmF0ZS4gQnV0IGEgc2VwYXJhdGUgbWFpbGluZyBsaXN0IGlzIGFsc28gYSBn b29kDQphcHByb2FjaC4NCg0KSSdsbCBhZGQgeW91IGJ5IGhhbmQgZm9yIG5vdywgUm9nZXIuDQoN CkZhbQ0K From xen-devel-bounces@lists.xenproject.org Wed Mar 10 10:43:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 10:43:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95960.181240 (Exim 4.92) (envelope-from ) id 1lJwJj-00035t-K9; Wed, 10 Mar 2021 10:43:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95960.181240; Wed, 10 Mar 2021 10:43:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwJj-00035l-Fh; Wed, 10 Mar 2021 10:43:51 +0000 Received: by outflank-mailman (input) for mailman id 95960; Wed, 10 Mar 2021 10:43:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwJi-00035F-32 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 10:43:50 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id e60485af-fc58-43fc-8838-e3df52d142c5; Wed, 10 Mar 2021 10:43:47 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA04A1FB; Wed, 10 Mar 2021 02:43:46 -0800 (PST) Received: from e123311-lin.arm.com (unknown [10.57.15.227]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A30473F85F; Wed, 10 Mar 2021 02:43:45 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e60485af-fc58-43fc-8838-e3df52d142c5 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: julien@xen.org, andrew.cooper3@citrix.com, amc96@cam.ac.uk Subject: [XTF 3/4] arm: Add initial architecture code for arm64 and arm32 Date: Wed, 10 Mar 2021 11:43:34 +0100 Message-Id: <20210310104335.14855-4-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 In-Reply-To: <20210310104335.14855-1-michal.orzel@arm.com> References: <20210310104335.14855-1-michal.orzel@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add initial support to XTF for arm64/arm32 without modifying existing XTF architecture. Most of the files are just dummy files waiting to be properly implemented step by step later on. The purpose of this change is to add the initial code and minimal set of files to support arm64 without modifying the existing XTF design. This creates a base for further implementation. Signed-off-by: Michal Orzel Based-on-the-work-from: Julien Grall --- arch/arm/arm32/head.S | 0 arch/arm/arm64/cache.S | 23 +++++++ arch/arm/arm64/head.S | 90 ++++++++++++++++++++++++++ arch/arm/decode.c | 25 ++++++++ arch/arm/include/arch/arm32/regs.h | 73 +++++++++++++++++++++ arch/arm/include/arch/arm64/regs.h | 100 +++++++++++++++++++++++++++++ arch/arm/include/arch/asm_macros.h | 21 ++++++ arch/arm/include/arch/barrier.h | 41 ++++++++++++ arch/arm/include/arch/bitops.h | 45 +++++++++++++ arch/arm/include/arch/config.h | 37 +++++++++++ arch/arm/include/arch/desc.h | 16 +++++ arch/arm/include/arch/div.h | 35 ++++++++++ arch/arm/include/arch/extable.h | 19 ++++++ arch/arm/include/arch/hypercall.h | 39 +++++++++++ arch/arm/include/arch/page.h | 23 +++++++ arch/arm/include/arch/regs.h | 25 ++++++++ arch/arm/include/arch/traps.h | 22 +++++++ arch/arm/include/arch/xtf.h | 17 +++++ arch/arm/link.lds.S | 58 +++++++++++++++++ arch/arm/setup.c | 28 ++++++++ arch/arm/traps.c | 22 +++++++ 21 files changed, 759 insertions(+) create mode 100644 arch/arm/arm32/head.S create mode 100644 arch/arm/arm64/cache.S create mode 100644 arch/arm/arm64/head.S create mode 100644 arch/arm/decode.c create mode 100644 arch/arm/include/arch/arm32/regs.h create mode 100644 arch/arm/include/arch/arm64/regs.h create mode 100644 arch/arm/include/arch/asm_macros.h create mode 100644 arch/arm/include/arch/barrier.h create mode 100644 arch/arm/include/arch/bitops.h create mode 100644 arch/arm/include/arch/config.h create mode 100644 arch/arm/include/arch/desc.h create mode 100644 arch/arm/include/arch/div.h create mode 100644 arch/arm/include/arch/extable.h create mode 100644 arch/arm/include/arch/hypercall.h create mode 100644 arch/arm/include/arch/page.h create mode 100644 arch/arm/include/arch/regs.h create mode 100644 arch/arm/include/arch/traps.h create mode 100644 arch/arm/include/arch/xtf.h create mode 100644 arch/arm/link.lds.S create mode 100644 arch/arm/setup.c create mode 100644 arch/arm/traps.c diff --git a/arch/arm/arm32/head.S b/arch/arm/arm32/head.S new file mode 100644 index 0000000..e69de29 diff --git a/arch/arm/arm64/cache.S b/arch/arm/arm64/cache.S new file mode 100644 index 0000000..31b70ae --- /dev/null +++ b/arch/arm/arm64/cache.S @@ -0,0 +1,23 @@ +#include + +/* + * flush_dcache_range(start, end) + * - start - start address of a region + * - end - end address of a region + */ +ENTRY(flush_dcache_range) + /* Get the minimum D-cache line size */ + mrs x3, ctr_el0 + ubfm x3, x3, #16, #19 + mov x2, #4 + lsl x2, x2, x3 + sub x3, x2, #1 + bic x0, x0, x3 + /* Clean and invalidate D-cache line */ +1: dc civac, x0 + add x0, x0, x2 + cmp x0, x1 + b.lo 1b + dsb sy + ret +ENDFUNC(flush_dcache_range) diff --git a/arch/arm/arm64/head.S b/arch/arm/arm64/head.S new file mode 100644 index 0000000..bce0968 --- /dev/null +++ b/arch/arm/arm64/head.S @@ -0,0 +1,90 @@ +#include +#include +#include + +/* 1 if BE, 0 if LE */ +#define HEAD_FLAG_ENDIANNESS 0 +#define HEAD_FLAG_PAGE_SIZE ((PAGE_SHIFT - 10) / 2) +#define HEAD_FLAG_PHYS_BASE 1 +#define HEAD_FLAGS ((HEAD_FLAG_ENDIANNESS << 0) | \ + (HEAD_FLAG_PAGE_SIZE << 1) | \ + (HEAD_FLAG_PHYS_BASE << 3)) + +/* + * Print a string on the debug console + * + * Clobbers: x0, x1, x2, x16 + * + * /!\ When MMU is off, this can only be used with embed string in the + * kernel. + */ +#define PRINT(s) \ + adr x2, 97f; \ + adr x1, 98f; \ + sub x1, x1, x2; \ + mov x0, #CONSOLEIO_write; \ + mov x16, #__HYPERVISOR_console_io; \ + hvc #XEN_HYPERCALL_TAG; \ + b 99f; \ +97: .asciz s; \ +98:; \ + .align 2; \ +99: + +.section ".bss.page_aligned" +.p2align PAGE_SHIFT + +.text + b _start /* branch to kernel start, magic */ + .long 0 /* Executable code */ + .quad 0x0 /* Image load offset from start of RAM */ + .quad _end - _start /* Effective Image size */ + .quad HEAD_FLAGS /* Informative flags, little-endian */ + .quad 0 /* reserved */ + .quad 0 /* reserved */ + .quad 0 /* reserved */ + .byte 0x41 /* Magic number, "ARM\x64" */ + .byte 0x52 + .byte 0x4d + .byte 0x64 + .long 0 /* reserved */ + + +/* Load a physical address of \sym to \xb */ +.macro load_paddr xb, sym + ldr \xb, =\sym + add \xb, \xb, x21 +.endm + +/* + * Common register usage for assembly boot code + * + * x20 - DTB physical address (boot CPU only) + * x21 - Offset between PA and VA ( PA - VA) + * x30 - lr + */ +ENTRY(_start) + /* Save DTB pointer */ + mov x20, x0 + + /* Calculate where we are */ + ldr x22, =_start /* x22 := vaddr(_start) */ + adr x21, _start /* x21 := paddr(_start) */ + sub x21, x21, x22 /* x21 := phys-offset */ + + PRINT("- XTF booting -\n") + + PRINT("- Zero BSS -\n") + + load_paddr x0, __start_bss + load_paddr x1, __end_bss + + bl flush_dcache_range +1: str xzr, [x0], #8 + cmp x0, x1 + b.lo 1b + bl flush_dcache_range + + /* Start an infinite loop */ + PRINT("- Infinite loop -\n") +1: b 1b diff --git a/arch/arm/decode.c b/arch/arm/decode.c new file mode 100644 index 0000000..97aa576 --- /dev/null +++ b/arch/arm/decode.c @@ -0,0 +1,25 @@ +/** + * @file arch/arm/decode.c + * + * Helper routines for decoding arm architectural state. + */ +#include +#include + +bool arch_fmt_pointer( + char **str_ptr, char *end, const char **fmt_ptr, const void *arg, + int width, int precision, unsigned int flags) +{ + UNIMPLEMENTED(); + return false; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/include/arch/arm32/regs.h b/arch/arm/include/arch/arm32/regs.h new file mode 100644 index 0000000..fe137c4 --- /dev/null +++ b/arch/arm/include/arch/arm32/regs.h @@ -0,0 +1,73 @@ +/** + * @file arch/arm/include/arch/arm32/regs.h + * + * arm32 CPU user registers. + */ +#ifndef XTF_ARM32_REGS_H +#define XTF_ARM32_REGS_H + +#include + +/* On stack VCPU state */ +struct cpu_regs +{ + uint32_t r0; + uint32_t r1; + uint32_t r2; + uint32_t r3; + uint32_t r4; + uint32_t r5; + uint32_t r6; + uint32_t r7; + uint32_t r8; + uint32_t r9; + uint32_t r10; + union { + uint32_t r11; + uint32_t fp; + }; + uint32_t r12; + + uint32_t sp; /* r13 - SP: Valid for Hyp. frames only, o/w banked (see below) */ + + /* r14 - LR: is the same physical register as LR_usr */ + union { + uint32_t lr; /* r14 - LR: Valid for Hyp. Same physical register as lr_usr. */ + + uint32_t lr_usr; + }; + + union { /* Return IP, pc32 is used to allow code to be common with 64-bit */ + uint32_t pc, pc32; + }; + uint32_t cpsr; /* Return mode */ + uint32_t hsr; /* Exception Syndrome */ + + /* Outer guest frame only from here on... */ + + uint32_t sp_usr; /* LR_usr is the same register as LR, see above */ + + uint32_t sp_irq, lr_irq; + uint32_t sp_svc, lr_svc; + uint32_t sp_abt, lr_abt; + uint32_t sp_und, lr_und; + + uint32_t r8_fiq, r9_fiq, r10_fiq, r11_fiq, r12_fiq; + uint32_t sp_fiq, lr_fiq; + + uint32_t spsr_svc, spsr_abt, spsr_und, spsr_irq, spsr_fiq; + + uint32_t pad1; /* Doubleword-align the user half of the frame */ +}; + +#endif /* XTF_ARM32_REGS_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/include/arch/arm64/regs.h b/arch/arm/include/arch/arm64/regs.h new file mode 100644 index 0000000..8e18ae0 --- /dev/null +++ b/arch/arm/include/arch/arm64/regs.h @@ -0,0 +1,100 @@ +/** + * @file arch/arm/include/arch/arm64/regs.h + * + * arm64 CPU user registers. + */ +#ifndef XTF_ARM64_REGS_H +#define XTF_ARM64_REGS_H + +#include + +/* Anonymous union includes both 32- and 64-bit names (e.g., r0/x0). */ +#define __DECL_REG(n64, n32) union { \ + uint64_t n64; \ + uint32_t n32; \ +} + +/* On stack VCPU state */ +struct cpu_regs +{ + /* + * The mapping AArch64 <-> AArch32 is based on D1.20.1 in ARM DDI + * 0487A.d. + * + * AArch64 AArch32 + */ + __DECL_REG(x0, r0/*_usr*/); + __DECL_REG(x1, r1/*_usr*/); + __DECL_REG(x2, r2/*_usr*/); + __DECL_REG(x3, r3/*_usr*/); + __DECL_REG(x4, r4/*_usr*/); + __DECL_REG(x5, r5/*_usr*/); + __DECL_REG(x6, r6/*_usr*/); + __DECL_REG(x7, r7/*_usr*/); + __DECL_REG(x8, r8/*_usr*/); + __DECL_REG(x9, r9/*_usr*/); + __DECL_REG(x10, r10/*_usr*/); + __DECL_REG(x11 , r11/*_usr*/); + __DECL_REG(x12, r12/*_usr*/); + + __DECL_REG(x13, /* r13_usr */ sp_usr); + __DECL_REG(x14, /* r14_usr */ lr_usr); + + __DECL_REG(x15, /* r13_hyp */ __unused_sp_hyp); + + __DECL_REG(x16, /* r14_irq */ lr_irq); + __DECL_REG(x17, /* r13_irq */ sp_irq); + + __DECL_REG(x18, /* r14_svc */ lr_svc); + __DECL_REG(x19, /* r13_svc */ sp_svc); + + __DECL_REG(x20, /* r14_abt */ lr_abt); + __DECL_REG(x21, /* r13_abt */ sp_abt); + + __DECL_REG(x22, /* r14_und */ lr_und); + __DECL_REG(x23, /* r13_und */ sp_und); + + __DECL_REG(x24, r8_fiq); + __DECL_REG(x25, r9_fiq); + __DECL_REG(x26, r10_fiq); + __DECL_REG(x27, r11_fiq); + __DECL_REG(x28, r12_fiq); + __DECL_REG(/* x29 */ fp, /* r13_fiq */ sp_fiq); + + __DECL_REG(/* x30 */ lr, /* r14_fiq */ lr_fiq); + + uint64_t sp; /* Valid for hypervisor frames */ + + /* Return address and mode */ + __DECL_REG(pc, pc32); /* ELR_EL2 */ + uint32_t cpsr; /* SPSR_EL2 */ + uint32_t hsr; /* ESR_EL2 */ + + /* Outer guest frame only from here on... */ + + union { + uint32_t spsr_el1; /* AArch64 */ + uint32_t spsr_svc; /* AArch32 */ + }; + + uint32_t pad1; /* Doubleword-align the user half of the frame */ + + /* AArch32 guests only */ + uint32_t spsr_fiq, spsr_irq, spsr_und, spsr_abt; + + /* AArch64 guests only */ + uint64_t sp_el0; + uint64_t sp_el1, elr_el1; +}; + +#endif /* XTF_ARM64_REGS_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/include/arch/asm_macros.h b/arch/arm/include/arch/asm_macros.h new file mode 100644 index 0000000..39e1d16 --- /dev/null +++ b/arch/arm/include/arch/asm_macros.h @@ -0,0 +1,21 @@ +/** + * @file arch/arm/include/arch/asm_macros.h + * + * Macros for use in arm assembly files. + */ +#ifndef XTF_ARM_ASM_MACROS_H +#define XTF_ARM_ASM_MACROS_H + +#define ALIGN .align 2 + +#endif /* XTF_ARM_ASM_MACROS_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/include/arch/barrier.h b/arch/arm/include/arch/barrier.h new file mode 100644 index 0000000..b84c922 --- /dev/null +++ b/arch/arm/include/arch/barrier.h @@ -0,0 +1,41 @@ +/** + * @file arch/arm/include/arch/barrier.h + * + * arm memory barriers. + */ +#ifndef XTF_ARM_BARRIER_H +#define XTF_ARM_BARRIER_H + +#include + +#define isb() __asm__ __volatile__ ("isb" : : : "memory") +#define dsb(scope) __asm__ __volatile__ ("dsb " #scope : : : "memory") +#define dmb(scope) __asm__ __volatile__ ("dmb " #scope : : : "memory") + +#define mb() dsb(sy) +#ifdef CONFIG_ARM_64 +#define rmb() dsb(ld) +#else +#define rmb() dsb(sy) +#endif +#define wmb() dsb(st) + +#define smp_mb() dmb(ish) +#ifdef CONFIG_ARM_64 +#define smp_rmb() dmb(ishld) +#else +#define smp_rmb() dmb(ish) +#endif +#define smp_wmb() dmb(ishst) + +#endif /* XTF_ARM_BARRIER_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/include/arch/bitops.h b/arch/arm/include/arch/bitops.h new file mode 100644 index 0000000..524b9f7 --- /dev/null +++ b/arch/arm/include/arch/bitops.h @@ -0,0 +1,45 @@ +/** + * @file arch/arm/include/arch/bitops.h + * + * Low level bit operations. + */ +#ifndef XTF_ARM_BITOPS_H +#define XTF_ARM_BITOPS_H + +#include + +static inline bool test_bit(unsigned int bit, const void *addr) +{ + UNIMPLEMENTED(); + return false; +} + +static inline bool test_and_set_bit(unsigned int bit, volatile void *addr) +{ + UNIMPLEMENTED(); + return false; +} + +static inline bool test_and_change_bit(unsigned int bit, volatile void *addr) +{ + UNIMPLEMENTED(); + return false; +} + +static inline bool test_and_clear_bit(unsigned int bit, volatile void *addr) +{ + UNIMPLEMENTED(); + return false; +} + +#endif /* XTF_ARM_BITOPS_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/include/arch/config.h b/arch/arm/include/arch/config.h new file mode 100644 index 0000000..2ccc71e --- /dev/null +++ b/arch/arm/include/arch/config.h @@ -0,0 +1,37 @@ +/** + * @file arch/arm/include/arch/config.h + * + * A Linux-style configuration list. + */ +#ifndef XTF_ARM_CONFIG_H +#define XTF_ARM_CONFIG_H + +#define XTF_VIRT_START 0x40000000 + +#if defined(CONFIG_ENV_arm64) +#define CONFIG_ARM 1 +#define CONFIG_ARM_64 1 +#define CONFIG_64BIT 1 +#define ENVIRONMENT_DESCRIPTION "ARM64" +#undef CONFIG_ENV_arm64 +#elif defined(CONFIG_ENV_arm32) +#define CONFIG_ARM 1 +#define CONFIG_ARM_32 1 +#define CONFIG_32BIT 1 +#define ENVIRONMENT_DESCRIPTION "ARM32" +#undef CONFIG_ENV_arm32 +#else +#error "Bad environment" +#endif + +#endif /* XTF_ARM_CONFIG_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/include/arch/desc.h b/arch/arm/include/arch/desc.h new file mode 100644 index 0000000..f4ea8b3 --- /dev/null +++ b/arch/arm/include/arch/desc.h @@ -0,0 +1,16 @@ +/** + * @file arch/arm/include/arch/desc.h + */ +#ifndef XTF_ARM_DESC_H +#define XTF_ARM_DESC_H + +#endif /* XTF_ARM_DESC_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/include/arch/div.h b/arch/arm/include/arch/div.h new file mode 100644 index 0000000..3038430 --- /dev/null +++ b/arch/arm/include/arch/div.h @@ -0,0 +1,35 @@ +/** + * @file arch/arm/include/arch/div.h + */ +#ifndef XTF_ARM_DIV_H +#define XTF_ARM_DIV_H + +#include + +/* + * Divide a 64bit number by 32bit divisor without software support. + * + * The dividend is modified in place, and the modulus is returned. + */ +static inline uint32_t divmod64(uint64_t *dividend, uint32_t divisor) +{ +#if defined(CONFIG_ARM_64) + uint32_t remainder = *dividend % divisor; + *dividend = *dividend / divisor; + return remainder; +#else + UNIMPLEMENTED(); +#endif +} + +#endif /* XTF_ARM_DIV_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/include/arch/extable.h b/arch/arm/include/arch/extable.h new file mode 100644 index 0000000..9560b96 --- /dev/null +++ b/arch/arm/include/arch/extable.h @@ -0,0 +1,19 @@ +/** + * @file arch/arm/include/arch/extable.h + * + * Common arm exception table helper functions. + */ +#ifndef XTF_ARM64_EXTABLE_H +#define XTF_ARM64_EXTABLE_H + +#endif /* XTF_ARM_EXTABLE_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/include/arch/hypercall.h b/arch/arm/include/arch/hypercall.h new file mode 100644 index 0000000..660b2d6 --- /dev/null +++ b/arch/arm/include/arch/hypercall.h @@ -0,0 +1,39 @@ +/** + * @file arch/arm/include/arch/hypercall.h + * + * Hypercall primitives for arm. + */ +#ifndef XTF_ARM_HYPERCALL_H +#define XTF_ARM_HYPERCALL_H + +#include + +#define _hypercall_1(type, hcall, a1) \ + ({ \ + UNIMPLEMENTED(); \ + (type)0; \ + }) + +#define _hypercall_2(type, hcall, a1, a2) \ + ({ \ + UNIMPLEMENTED(); \ + (type)0; \ + }) + +#define _hypercall_3(type, hcall, a1, a2, a3) \ + ({ \ + UNIMPLEMENTED(); \ + (type)0; \ + }) + +#endif /* XTF_ARM_HYPERCALL_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/include/arch/page.h b/arch/arm/include/arch/page.h new file mode 100644 index 0000000..508b3ef --- /dev/null +++ b/arch/arm/include/arch/page.h @@ -0,0 +1,23 @@ +/** + * @file arch/arm/include/arch/page.h + */ +#ifndef XTF_ARM_PAGE_H +#define XTF_ARM_PAGE_H + +#include + +#define PAGE_SHIFT 12 +#define PAGE_SIZE (_AC(1, L) << PAGE_SHIFT) +#define PAGE_MASK (~(PAGE_SIZE - 1)) + +#endif /* XTF_ARM_PAGE_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/include/arch/regs.h b/arch/arm/include/arch/regs.h new file mode 100644 index 0000000..704e8e6 --- /dev/null +++ b/arch/arm/include/arch/regs.h @@ -0,0 +1,25 @@ +/** + * @file arch/arm/include/arch/regs.h + * + * arm CPU user registers. + */ +#ifndef XTF_ARM_REGS_H +#define XTF_ARM_REGS_H + +#if defined(CONFIG_ARM_64) +#include +#else +#include +#endif + +#endif /* XTF_ARM_REGS_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/include/arch/traps.h b/arch/arm/include/arch/traps.h new file mode 100644 index 0000000..8c42064 --- /dev/null +++ b/arch/arm/include/arch/traps.h @@ -0,0 +1,22 @@ +/** + * @file arch/arm/include/arch/traps.h + */ +#ifndef XTF_ARM_TRAPS_H +#define XTF_ARM_TRAPS_H + +#include +#include + +void __noreturn arch_crash_hard(void); + +#endif /* XTF_ARM_TRAPS_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/include/arch/xtf.h b/arch/arm/include/arch/xtf.h new file mode 100644 index 0000000..7b25617 --- /dev/null +++ b/arch/arm/include/arch/xtf.h @@ -0,0 +1,17 @@ +/** + * @file arch/arm/include/arch/xtf.h + */ +#ifndef XTF_ARM_XTF_H +#define XTF_ARM_XTF_H + +#endif /* XTF_ARM_XTF_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/link.lds.S b/arch/arm/link.lds.S new file mode 100644 index 0000000..3160cf1 --- /dev/null +++ b/arch/arm/link.lds.S @@ -0,0 +1,58 @@ +#include + +#if defined(__arm__) +OUTPUT_ARCH(arm) +OUTPUT_FORMAT("elf32-littlearm") +#elif defined(__aarch64__) +OUTPUT_ARCH(aarch64) +OUTPUT_FORMAT("elf64-littleaarch64") +#endif + +ENTRY(_start) + +SECTIONS +{ + . = XTF_VIRT_START; + _text = .; + + .text : { + *(.text) + } + + . = ALIGN(PAGE_SIZE); + + .data : { + *(.data) + + . = ALIGN(PAGE_SIZE); + *(.data.page_aligned) + } + + . = ALIGN(PAGE_SIZE); + + .rodata : { + *(.rodata) + *(.rodata.*) + } + + . = ALIGN(PAGE_SIZE); + + .bss : { + __start_bss = .; + *(.bss) + + . = ALIGN(PAGE_SIZE); + *(.bss.page_aligned) + + __end_bss = .; + } + + _end = .; + + /* + * It is possible for a GNU linker to add a .note.gnu.build-id section + * before .text which causes zimage header to be shifted resulting in + * a bad magic. Discard this section to prevent errors. + */ + /DISCARD/ : { *(.note.gnu.build-id) } +} diff --git a/arch/arm/setup.c b/arch/arm/setup.c new file mode 100644 index 0000000..bc5669d --- /dev/null +++ b/arch/arm/setup.c @@ -0,0 +1,28 @@ +/** + * @file arch/arm/setup.c + * + * Early bringup code for arm. + */ +#include + +const char environment_description[] = ENVIRONMENT_DESCRIPTION; + +void arch_setup(void) +{ + UNIMPLEMENTED(); +} + +void test_setup(void) +{ + UNIMPLEMENTED(); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/arch/arm/traps.c b/arch/arm/traps.c new file mode 100644 index 0000000..f4ad807 --- /dev/null +++ b/arch/arm/traps.c @@ -0,0 +1,22 @@ +/** + * @file arch/arm/traps.c + * + * arm trap handlers. + */ +#include +#include + +void __noreturn arch_crash_hard(void) +{ + UNIMPLEMENTED(); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 10:43:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 10:43:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95959.181228 (Exim 4.92) (envelope-from ) id 1lJwJf-00034K-Ae; Wed, 10 Mar 2021 10:43:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95959.181228; Wed, 10 Mar 2021 10:43:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwJf-00034D-7g; Wed, 10 Mar 2021 10:43:47 +0000 Received: by outflank-mailman (input) for mailman id 95959; Wed, 10 Mar 2021 10:43:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwJe-000348-0R for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 10:43:46 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id cd3f677c-babd-48ef-b53d-6dc2017b9d0b; Wed, 10 Mar 2021 10:43:44 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EE6171FB; Wed, 10 Mar 2021 02:43:43 -0800 (PST) Received: from e123311-lin.arm.com (unknown [10.57.15.227]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0907B3F85F; Wed, 10 Mar 2021 02:43:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd3f677c-babd-48ef-b53d-6dc2017b9d0b From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: julien@xen.org, andrew.cooper3@citrix.com, amc96@cam.ac.uk Subject: [XTF 1/4] xtf: Perform misc code cleanup Date: Wed, 10 Mar 2021 11:43:32 +0100 Message-Id: <20210310104335.14855-2-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 In-Reply-To: <20210310104335.14855-1-michal.orzel@arm.com> References: <20210310104335.14855-1-michal.orzel@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit -define macro ALIGN to set alignment: Header file asm_macros.h should not contain architecture specific code. Replace hardcoded alignment value with a call to macro ALIGN. -move declaration of shared_info into xtf/traps.h: Declaration of shared_info structure should be placed in xtf/traps.h as it is a common declaration for all the possible architectures. -do not protect including We should always include and rely on the compiler to throw an error. This would avoid increasing #if protection each time we would add a new architecture. Signed-off-by: Michal Orzel --- arch/x86/include/arch/asm_macros.h | 2 ++ arch/x86/include/arch/traps.h | 1 - include/xtf/asm_macros.h | 2 +- include/xtf/barrier.h | 4 ---- include/xtf/traps.h | 2 ++ 5 files changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/x86/include/arch/asm_macros.h b/arch/x86/include/arch/asm_macros.h index e12e1ba..1aabed5 100644 --- a/arch/x86/include/arch/asm_macros.h +++ b/arch/x86/include/arch/asm_macros.h @@ -15,6 +15,8 @@ # define __ASM_CODE_RAW(x) #x #endif +#define ALIGN .align 16 + /* Select between two variations based on compat or long mode. */ #ifdef __i386__ # define __ASM_SEL(c, l) __ASM_CODE(c) diff --git a/arch/x86/include/arch/traps.h b/arch/x86/include/arch/traps.h index 0c6888b..60fc3a4 100644 --- a/arch/x86/include/arch/traps.h +++ b/arch/x86/include/arch/traps.h @@ -57,7 +57,6 @@ extern uint8_t user_stack[PAGE_SIZE]; extern xen_pv_start_info_t *pv_start_info; extern xen_pvh_start_info_t *pvh_start_info; -extern shared_info_t shared_info; /* * Parameters for fine tuning the exec_user_*() behaviour. diff --git a/include/xtf/asm_macros.h b/include/xtf/asm_macros.h index 5484f7c..c531355 100644 --- a/include/xtf/asm_macros.h +++ b/include/xtf/asm_macros.h @@ -25,7 +25,7 @@ * @param name Function name. */ #define ENTRY(name) \ - .align 16; \ + ALIGN; \ GLOBAL(name) /** diff --git a/include/xtf/barrier.h b/include/xtf/barrier.h index b526fe1..3b02d49 100644 --- a/include/xtf/barrier.h +++ b/include/xtf/barrier.h @@ -1,11 +1,7 @@ #ifndef XTF_BARRIER_H #define XTF_BARRIER_H -#if defined(__x86_64__) || defined (__i386__) # include -#else -# error Bad architecture -#endif #endif /* XTF_BARRIER_H */ diff --git a/include/xtf/traps.h b/include/xtf/traps.h index 8fc66af..4081db6 100644 --- a/include/xtf/traps.h +++ b/include/xtf/traps.h @@ -6,6 +6,8 @@ #include +extern shared_info_t shared_info; + /** * May be implemented by a guest to provide custom exception handling. */ -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 10:43:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 10:43:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95961.181246 (Exim 4.92) (envelope-from ) id 1lJwJj-00036R-VW; Wed, 10 Mar 2021 10:43:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95961.181246; Wed, 10 Mar 2021 10:43:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwJj-00036G-P7; Wed, 10 Mar 2021 10:43:51 +0000 Received: by outflank-mailman (input) for mailman id 95961; Wed, 10 Mar 2021 10:43:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwJi-000348-Rg for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 10:43:50 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 2db8e24c-9196-4e4e-9cc0-77a7fde17faf; Wed, 10 Mar 2021 10:43:43 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B51C01063; Wed, 10 Mar 2021 02:43:42 -0800 (PST) Received: from e123311-lin.arm.com (unknown [10.57.15.227]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C1DD73F85F; Wed, 10 Mar 2021 02:43:41 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2db8e24c-9196-4e4e-9cc0-77a7fde17faf From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: julien@xen.org, andrew.cooper3@citrix.com, amc96@cam.ac.uk Subject: [XTF 0/4] Port XTF to arm64 and arm32 Date: Wed, 10 Mar 2021 11:43:31 +0100 Message-Id: <20210310104335.14855-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The goal of this patch series is to make the first step in porting XTF to arm64 and arm32, whereby the emphasis is on arm64. The attempt to port XTF to arm64 was originally started by Julien Grall. The series contains: Patch 1 performs miscellaneous code cleanup related to headers that should be architecture independent. Patch 2 modifies the XTF build system to be able to support multiple architectures as the current build system is strictly made up for x86. This is done by generalizing the common makefiles to be architecture independent and creating architecture specific makefiles. Patch 3 adds the initial support for arm64/arm32 by providing minimal set of architecture specific files. Some of them are just dummy files waiting to be properly implemented later on. This creates a base for further implementation. Patch 4 adds the build system support for arm64/arm32 and updates the documentation. On arm64 one test is supported tests/example allowing the startup code to be executed. On arm32 currently no test is supported. Michal Orzel (4): xtf: Perform misc code cleanup build: Modify build system to support multiple architectures arm: Add initial architecture code for arm64 and arm32 arm: Add build support for arm64/arm32 .gitignore | 2 +- INSTALL | 18 + Makefile | 23 +- README | 7 + arch/arm/arm32/head.S | 0 arch/arm/arm64/cache.S | 23 ++ arch/arm/arm64/head.S | 90 +++++ arch/arm/decode.c | 25 ++ arch/arm/include/arch/arm32/regs.h | 73 +++++ arch/arm/include/arch/arm64/regs.h | 100 ++++++ arch/arm/include/arch/asm_macros.h | 21 ++ arch/arm/include/arch/barrier.h | 41 +++ arch/arm/include/arch/bitops.h | 45 +++ arch/arm/include/arch/config.h | 37 +++ arch/arm/include/arch/desc.h | 16 + arch/arm/include/arch/div.h | 35 ++ arch/arm/include/arch/extable.h | 19 ++ arch/arm/include/arch/hypercall.h | 39 +++ arch/arm/include/arch/page.h | 23 ++ arch/arm/include/arch/regs.h | 25 ++ arch/arm/include/arch/traps.h | 22 ++ arch/arm/include/arch/xtf.h | 17 + arch/arm/link.lds.S | 58 ++++ arch/arm/setup.c | 28 ++ arch/arm/traps.c | 22 ++ arch/x86/include/arch/asm_macros.h | 2 + arch/x86/include/arch/traps.h | 1 - build/arm-common-files.mk | 14 + build/arm32/arch-common.mk | 8 + build/arm32/arch-files.mk | 7 + build/arm32/arch-tests.mk | 4 + build/arm64/arch-common.mk | 15 + build/arm64/arch-files.mk | 7 + build/arm64/arch-tests.mk | 4 + build/common.mk | 49 ++- build/gen.mk | 22 +- build/x86/arch-common.mk | 34 ++ build/{files.mk => x86/arch-files.mk} | 12 +- config/default-arm.cfg.in | 6 + docs/introduction.dox | 16 +- docs/mainpage.dox | 34 +- include/xen/arch-arm.h | 452 ++++++++++++++++++++++++++ include/xen/xen.h | 2 + include/xtf/asm_macros.h | 2 +- include/xtf/barrier.h | 4 - include/xtf/hypercall.h | 81 +++-- include/xtf/lib.h | 9 +- include/xtf/traps.h | 2 + 48 files changed, 1502 insertions(+), 94 deletions(-) create mode 100644 arch/arm/arm32/head.S create mode 100644 arch/arm/arm64/cache.S create mode 100644 arch/arm/arm64/head.S create mode 100644 arch/arm/decode.c create mode 100644 arch/arm/include/arch/arm32/regs.h create mode 100644 arch/arm/include/arch/arm64/regs.h create mode 100644 arch/arm/include/arch/asm_macros.h create mode 100644 arch/arm/include/arch/barrier.h create mode 100644 arch/arm/include/arch/bitops.h create mode 100644 arch/arm/include/arch/config.h create mode 100644 arch/arm/include/arch/desc.h create mode 100644 arch/arm/include/arch/div.h create mode 100644 arch/arm/include/arch/extable.h create mode 100644 arch/arm/include/arch/hypercall.h create mode 100644 arch/arm/include/arch/page.h create mode 100644 arch/arm/include/arch/regs.h create mode 100644 arch/arm/include/arch/traps.h create mode 100644 arch/arm/include/arch/xtf.h create mode 100644 arch/arm/link.lds.S create mode 100644 arch/arm/setup.c create mode 100644 arch/arm/traps.c create mode 100644 build/arm-common-files.mk create mode 100644 build/arm32/arch-common.mk create mode 100644 build/arm32/arch-files.mk create mode 100644 build/arm32/arch-tests.mk create mode 100644 build/arm64/arch-common.mk create mode 100644 build/arm64/arch-files.mk create mode 100644 build/arm64/arch-tests.mk create mode 100644 build/x86/arch-common.mk rename build/{files.mk => x86/arch-files.mk} (86%) create mode 100644 config/default-arm.cfg.in create mode 100644 include/xen/arch-arm.h -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 10:43:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 10:43:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95962.181264 (Exim 4.92) (envelope-from ) id 1lJwJp-0003Bu-AQ; Wed, 10 Mar 2021 10:43:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95962.181264; Wed, 10 Mar 2021 10:43:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwJp-0003Bn-6k; Wed, 10 Mar 2021 10:43:57 +0000 Received: by outflank-mailman (input) for mailman id 95962; Wed, 10 Mar 2021 10:43:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwJm-00035F-Vp for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 10:43:55 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 5f512f45-65b9-414c-a28e-504c0cbaa8ee; Wed, 10 Mar 2021 10:43:48 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2C27211B3; Wed, 10 Mar 2021 02:43:48 -0800 (PST) Received: from e123311-lin.arm.com (unknown [10.57.15.227]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 11B573F85F; Wed, 10 Mar 2021 02:43:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f512f45-65b9-414c-a28e-504c0cbaa8ee From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: julien@xen.org, andrew.cooper3@citrix.com, amc96@cam.ac.uk Subject: [XTF 4/4] arm: Add build support for arm64/arm32 Date: Wed, 10 Mar 2021 11:43:35 +0100 Message-Id: <20210310104335.14855-5-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 In-Reply-To: <20210310104335.14855-1-michal.orzel@arm.com> References: <20210310104335.14855-1-michal.orzel@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for arm64/arm32 in the build system, modify the common headers to be aware of the new architectures and update the documentation. Architecture can be set using ARCH=arm64 or ARCH=arm32. arm64: Currently only one test: tests/example is supported allowing the startup code head.S to be executed. arm32: No tests supported. Only compile time support. Signed-off-by: Michal Orzel --- INSTALL | 18 ++ Makefile | 6 +- README | 7 + build/arm-common-files.mk | 14 ++ build/arm32/arch-common.mk | 8 + build/arm32/arch-files.mk | 7 + build/arm32/arch-tests.mk | 4 + build/arm64/arch-common.mk | 15 ++ build/arm64/arch-files.mk | 7 + build/arm64/arch-tests.mk | 4 + config/default-arm.cfg.in | 6 + docs/introduction.dox | 16 +- docs/mainpage.dox | 34 ++- include/xen/arch-arm.h | 452 +++++++++++++++++++++++++++++++++++++ include/xen/xen.h | 2 + include/xtf/hypercall.h | 81 ++++--- include/xtf/lib.h | 9 +- 17 files changed, 654 insertions(+), 36 deletions(-) create mode 100644 build/arm-common-files.mk create mode 100644 build/arm32/arch-common.mk create mode 100644 build/arm32/arch-files.mk create mode 100644 build/arm32/arch-tests.mk create mode 100644 build/arm64/arch-common.mk create mode 100644 build/arm64/arch-files.mk create mode 100644 build/arm64/arch-tests.mk create mode 100644 config/default-arm.cfg.in create mode 100644 include/xen/arch-arm.h diff --git a/INSTALL b/INSTALL index ed19623..296a0f0 100644 --- a/INSTALL +++ b/INSTALL @@ -2,6 +2,24 @@ Xen Test Framework Build requirements: - GNU Make >= 3.81 +For x86: - GNU compatible compiler, capable of: -std=gnu99 -m64 and -m32 +For arm64/arm32: +-when cross-compiling: + - GNU compatible cross-compiler toolchain for Aarch64/Aarch32 +-when building natively: + - GNU compatible toolchain for Aarch64/Aarch32 + +To build XTF: +-for x86: + $ make +-for arm64 natively: + $ make ARCH=arm64 +-for arm64 when cross compiling: + $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- +-for arm32 natively: + $ make ARCH=arm32 +-for arm32 when cross compiling: + $ make ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabi- diff --git a/Makefile b/Makefile index 7c25b0d..2cb6abc 100644 --- a/Makefile +++ b/Makefile @@ -19,7 +19,7 @@ endif xtftestdir := $(xtfdir)/tests # Supported architectures -SUPPORTED_ARCH := x86 +SUPPORTED_ARCH := x86 arm64 arm32 # Default architecture ARCH ?= x86 # Check if specified architecture is supported @@ -42,6 +42,10 @@ PYTHON := python export CC CPP INSTALL INSTALL_DATA INSTALL_DIR INSTALL_PROGRAM OBJCOPY PYTHON +# Some tests are architecture specific. In this case we can have a list of tests +# supported by a given architecture in $(ROOT)/build/$(ARCH)/arch-tests.mk +-include $(ROOT)/build/$(ARCH)/arch-tests.mk + # By default enable all the tests TESTS ?= $(wildcard tests/*) diff --git a/README b/README index 20d9127..c595a5b 100644 --- a/README +++ b/README @@ -9,12 +9,19 @@ Tests for more generic areas are build multiple times into different microkernels, to test the same functionality from different types of virtual machine. +Currently there are 3 architectures available: x86, arm64 and arm32 although +only x86 is truly supported. Initial support for arm64 is added allowing to run +a startup code based on the test: tests/example. For arm32 only compile time +support is added. This creates a base for future implementation. + ## The framework consists of: * PV and HVM, 32 and 64 bit entry points * Hypercall interface * PV console driver (output) * Common reporting framework +* Initial support for arm64 (startup code running) +* Initial support for arm32 (currently no tests supported) ## TODO List: diff --git a/build/arm-common-files.mk b/build/arm-common-files.mk new file mode 100644 index 0000000..01e9d8d --- /dev/null +++ b/build/arm-common-files.mk @@ -0,0 +1,14 @@ +# Common files compiled and linked for arm + +obj-perenv += $(ROOT)/common/console.o +obj-perenv += $(ROOT)/common/lib.o +obj-perenv += $(ROOT)/common/libc/stdio.o +obj-perenv += $(ROOT)/common/libc/string.o +obj-perenv += $(ROOT)/common/libc/vsnprintf.o +obj-perenv += $(ROOT)/common/report.o +obj-perenv += $(ROOT)/common/setup.o +obj-perenv += $(ROOT)/common/xenbus.o + +obj-perenv += $(ROOT)/arch/arm/decode.o +obj-perenv += $(ROOT)/arch/arm/setup.o +obj-perenv += $(ROOT)/arch/arm/traps.o diff --git a/build/arm32/arch-common.mk b/build/arm32/arch-common.mk new file mode 100644 index 0000000..ef65b7f --- /dev/null +++ b/build/arm32/arch-common.mk @@ -0,0 +1,8 @@ +# Architecture specific configuration for arm32 + +ARCH_PATH := $(ROOT)/arch/arm +ALL_ENVIRONMENTS := arm32 + +arm32_arch := arm32 +arm32_guest := arm32 +defcfg-arm32 := $(ROOT)/config/default-arm.cfg.in diff --git a/build/arm32/arch-files.mk b/build/arm32/arch-files.mk new file mode 100644 index 0000000..8186d70 --- /dev/null +++ b/build/arm32/arch-files.mk @@ -0,0 +1,7 @@ +# Architecture specific files compiled and linked for arm32 + +# Include arm common files +include $(ROOT)/build/arm-common-files.mk + +# Specific files for arm32 +obj-perenv += diff --git a/build/arm32/arch-tests.mk b/build/arm32/arch-tests.mk new file mode 100644 index 0000000..3736042 --- /dev/null +++ b/build/arm32/arch-tests.mk @@ -0,0 +1,4 @@ +# Supported tests by arm32 + +# Currently no tests are supported for arm32 +TESTS := diff --git a/build/arm64/arch-common.mk b/build/arm64/arch-common.mk new file mode 100644 index 0000000..85060c5 --- /dev/null +++ b/build/arm64/arch-common.mk @@ -0,0 +1,15 @@ +# Architecture specific configuration for arm64 + +ARCH_PATH := $(ROOT)/arch/arm +ALL_ENVIRONMENTS := arm64 + +arm64_arch := arm64 +arm64_guest := arm64 +defcfg-arm64 := $(ROOT)/config/default-arm.cfg.in + +# Compilation recipe for arm64 +# arm64 needs linking normally, then converting to a binary format +define build-arm64 + $(CC) $$(LDFLAGS_arm64) $$(DEPS-arm64) -o $$@-syms + $(OBJCOPY) $$@-syms -O binary $$@ +endef diff --git a/build/arm64/arch-files.mk b/build/arm64/arch-files.mk new file mode 100644 index 0000000..f7a4007 --- /dev/null +++ b/build/arm64/arch-files.mk @@ -0,0 +1,7 @@ +# Architecture specific files compiled and linked for arm64 + +# Include arm common files +include $(ROOT)/build/arm-common-files.mk + +# Specific files for arm64 +obj-perenv += $(ROOT)/arch/arm/arm64/cache.o diff --git a/build/arm64/arch-tests.mk b/build/arm64/arch-tests.mk new file mode 100644 index 0000000..1a13ba9 --- /dev/null +++ b/build/arm64/arch-tests.mk @@ -0,0 +1,4 @@ +# Supported tests by arm64 + +# Currently only example test is supported +TESTS := $(ROOT)/tests/example diff --git a/config/default-arm.cfg.in b/config/default-arm.cfg.in new file mode 100644 index 0000000..26c0c50 --- /dev/null +++ b/config/default-arm.cfg.in @@ -0,0 +1,6 @@ +name="test-@@ENV@@-@@NAME@@@@VARIATION@@" + +vcpus=@@VCPUS@@ + +memory=128 +kernel="@@XTFDIR@@/tests/@@NAME@@/test-@@ENV@@-@@NAME@@" diff --git a/docs/introduction.dox b/docs/introduction.dox index 9207941..ff5ceae 100644 --- a/docs/introduction.dox +++ b/docs/introduction.dox @@ -38,17 +38,29 @@ categories are: A test is built for one or more environments. The environment encodes: +For x86 architecture: - The Xen VM ABI in use (PV or HVM). - The compilation width (32bit or 64bit). - The primary paging mode (none, PSE, PAE). -All available environments are: +For arm64/arm32 there is currently a single environment called arm64/arm32. + +All available environments for x86 are: +@dontinclude build/x86/arch-common.mk @skipline ALL_ENVIRONMENTS -Some more specific collections for environments are also available: +Some more specific collections for x86 environments are also available: @skipline PV_ENVIRONMENTS @until 64BIT_ENVIRONMENTS +All available environments for arm64 are: +@dontinclude build/arm64/arch-common.mk +@skipline ALL_ENVIRONMENTS + +All available environments for arm32 are: +@dontinclude build/arm32/arch-common.mk +@skipline ALL_ENVIRONMENTS + An individual test, compiled for more than one environment, will end up with a individual microkernel binary for each specified environment. diff --git a/docs/mainpage.dox b/docs/mainpage.dox index 4b09ce1..572c552 100644 --- a/docs/mainpage.dox +++ b/docs/mainpage.dox @@ -18,8 +18,14 @@ The build system and library abstractions are specifically designed to make it easy to write code once and compile it for multiple different environments (virtual machines). +Currently there are 3 architectures available: x86, arm64 and arm32 although +only x86 is truly supported. Initial support for arm64 is added allowing to run +a startup code based on the test: tests/example. For arm32 only compile time +support is added. This creates a base for future implementation. + The current environments supported are: +x86: Environment | Guest | Width | Paging :-----------|:------|:------|:--------- `pv32pae` | PV | 32bit | PAE @@ -29,18 +35,29 @@ Environment | Guest | Width | Paging `hvm32pae` | HVM | 32bit | PAE `hvm64` | HVM | 64bit | Long mode +arm64: +Environment | Guest | Width | Paging +:-----------|:------|:------|:---------------- +`arm64` | arm64 | 64bit | Currently no MMU + +arm32: +Environment | Guest | Width | Paging +:-----------|:------|:------|:---------------- +`arm32` | arm32 | 32bit | Currently no MMU @section getting-started Getting Started Requirements: - GNU Make >= 3.81 +- Python 2.6 or later + +For x86: - GNU compatible 32 and 64-bit toolchain, capable of `-std=gnu99`, `-m64`, and `-m32` - For Debian-based systems, the `build-essential` package is sufficient. For RHEL-based systems, the `glibc-devel.i686` package is generally needed beyond the default toolchain packages. - Clang may be used, via `CC="clang"` -- Python 2.6 or later Optionally: - A toolchain with x32 support. @@ -49,11 +66,26 @@ Optionally: `elf32-i386` will be used which will load correctly, but disassemble incorrectly. +For arm64/arm32: +-when cross-compiling: + - GNU compatible cross-compiler toolchain for Aarch64/Aarch32 +-when building natively: + - GNU compatible toolchain for Aarch64/Aarch32 + To obtain and build: $ git clone git://xenbits.xen.org/xtf.git $ cd xtf + # To build for x86: $ make -j4 + # To build for arm64 natively: + $ make ARCH=arm64 + # To build for arm32 natively: + $ make ARCH=arm32 + # To build for arm64 when cross compiling: + $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- + # To build for arm32 when cross compiling: + $ make ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabi- To run tests on a Xen host: (see @ref errata first) diff --git a/include/xen/arch-arm.h b/include/xen/arch-arm.h new file mode 100644 index 0000000..c77ee48 --- /dev/null +++ b/include/xen/arch-arm.h @@ -0,0 +1,452 @@ +#ifndef XEN_PUBLIC_ARCH_ARM_H +#define XEN_PUBLIC_ARCH_ARM_H + +/* + * `incontents 50 arm_abi Hypercall Calling Convention + * + * A hypercall is issued using the ARM HVC instruction. + * + * A hypercall can take up to 5 arguments. These are passed in + * registers, the first argument in x0/r0 (for arm64/arm32 guests + * respectively irrespective of whether the underlying hypervisor is + * 32- or 64-bit), the second argument in x1/r1, the third in x2/r2, + * the forth in x3/r3 and the fifth in x4/r4. + * + * The hypercall number is passed in r12 (arm) or x16 (arm64). In both + * cases the relevant ARM procedure calling convention specifies this + * is an inter-procedure-call scratch register (e.g. for use in linker + * stubs). This use does not conflict with use during a hypercall. + * + * The HVC ISS must contain a Xen specific TAG: XEN_HYPERCALL_TAG. + * + * The return value is in x0/r0. + * + * The hypercall will clobber x16/r12 and the argument registers used + * by that hypercall (except r0 which is the return value) i.e. in + * addition to x16/r12 a 2 argument hypercall will clobber x1/r1 and a + * 4 argument hypercall will clobber x1/r1, x2/r2 and x3/r3. + * + * Parameter structs passed to hypercalls are laid out according to + * the Procedure Call Standard for the ARM Architecture (AAPCS, AKA + * EABI) and Procedure Call Standard for the ARM 64-bit Architecture + * (AAPCS64). Where there is a conflict the 64-bit standard should be + * used regardless of guest type. Structures which are passed as + * hypercall arguments are always little endian. + * + * All memory which is shared with other entities in the system + * (including the hypervisor and other guests) must reside in memory + * which is mapped as Normal Inner Write-Back Outer Write-Back Inner-Shareable. + * This applies to: + * - hypercall arguments passed via a pointer to guest memory. + * - memory shared via the grant table mechanism (including PV I/O + * rings etc). + * - memory shared with the hypervisor (struct shared_info, struct + * vcpu_info, the grant table, etc). + * + * Any cache allocation hints are acceptable. + */ + +/* + * `incontents 55 arm_hcall Supported Hypercalls + * + * Xen on ARM makes extensive use of hardware facilities and therefore + * only a subset of the potential hypercalls are required. + * + * Since ARM uses second stage paging any machine/physical addresses + * passed to hypercalls are Guest Physical Addresses (Intermediate + * Physical Addresses) unless otherwise noted. + * + * The following hypercalls (and sub operations) are supported on the + * ARM platform. Other hypercalls should be considered + * unavailable/unsupported. + * + * HYPERVISOR_memory_op + * All generic sub-operations + * + * HYPERVISOR_domctl + * All generic sub-operations, with the exception of: + * * XEN_DOMCTL_irq_permission (not yet implemented) + * + * HYPERVISOR_sched_op + * All generic sub-operations, with the exception of: + * * SCHEDOP_block -- prefer wfi hardware instruction + * + * HYPERVISOR_console_io + * All generic sub-operations + * + * HYPERVISOR_xen_version + * All generic sub-operations + * + * HYPERVISOR_event_channel_op + * All generic sub-operations + * + * HYPERVISOR_physdev_op + * No sub-operations are currenty supported + * + * HYPERVISOR_sysctl + * All generic sub-operations, with the exception of: + * * XEN_SYSCTL_page_offline_op + * * XEN_SYSCTL_get_pmstat + * * XEN_SYSCTL_pm_op + * + * HYPERVISOR_hvm_op + * Exactly these sub-operations are supported: + * * HVMOP_set_param + * * HVMOP_get_param + * + * HYPERVISOR_grant_table_op + * All generic sub-operations + * + * HYPERVISOR_vcpu_op + * Exactly these sub-operations are supported: + * * VCPUOP_register_vcpu_info + * * VCPUOP_register_runstate_memory_area + * + * + * Other notes on the ARM ABI: + * + * - struct start_info is not exported to ARM guests. + * + * - struct shared_info is mapped by ARM guests using the + * HYPERVISOR_memory_op sub-op XENMEM_add_to_physmap, passing + * XENMAPSPACE_shared_info as space parameter. + * + * - All the per-cpu struct vcpu_info are mapped by ARM guests using the + * HYPERVISOR_vcpu_op sub-op VCPUOP_register_vcpu_info, including cpu0 + * struct vcpu_info. + * + * - The grant table is mapped using the HYPERVISOR_memory_op sub-op + * XENMEM_add_to_physmap, passing XENMAPSPACE_grant_table as space + * parameter. The memory range specified under the Xen compatible + * hypervisor node on device tree can be used as target gpfn for the + * mapping. + * + * - Xenstore is initialized by using the two hvm_params + * HVM_PARAM_STORE_PFN and HVM_PARAM_STORE_EVTCHN. They can be read + * with the HYPERVISOR_hvm_op sub-op HVMOP_get_param. + * + * - The paravirtualized console is initialized by using the two + * hvm_params HVM_PARAM_CONSOLE_PFN and HVM_PARAM_CONSOLE_EVTCHN. They + * can be read with the HYPERVISOR_hvm_op sub-op HVMOP_get_param. + * + * - Event channel notifications are delivered using the percpu GIC + * interrupt specified under the Xen compatible hypervisor node on + * device tree. + * + * - The device tree Xen compatible node is fully described under Linux + * at Documentation/devicetree/bindings/arm/xen.txt. + */ + +#define XEN_HYPERCALL_TAG 0XEA1 + +#define int64_aligned_t int64_t __attribute__((aligned(8))) +#define uint64_aligned_t uint64_t __attribute__((aligned(8))) + +#ifndef __ASSEMBLY__ +#define ___DEFINE_XEN_GUEST_HANDLE(name, type) \ + typedef union { type *p; unsigned long q; } \ + __guest_handle_ ## name; \ + typedef union { type *p; uint64_aligned_t q; } \ + __guest_handle_64_ ## name + +/* + * XEN_GUEST_HANDLE represents a guest pointer, when passed as a field + * in a struct in memory. On ARM is always 8 bytes sizes and 8 bytes + * aligned. + * XEN_GUEST_HANDLE_PARAM represents a guest pointer, when passed as an + * hypercall argument. It is 4 bytes on aarch32 and 8 bytes on aarch64. + */ +#define __DEFINE_XEN_GUEST_HANDLE(name, type) \ + ___DEFINE_XEN_GUEST_HANDLE(name, type); \ + ___DEFINE_XEN_GUEST_HANDLE(const_##name, const type) +#define DEFINE_XEN_GUEST_HANDLE(name) __DEFINE_XEN_GUEST_HANDLE(name, name) +#define __XEN_GUEST_HANDLE(name) __guest_handle_64_ ## name +#define XEN_GUEST_HANDLE(name) __XEN_GUEST_HANDLE(name) +#define XEN_GUEST_HANDLE_PARAM(name) __guest_handle_ ## name +#define set_xen_guest_handle_raw(hnd, val) \ + do { \ + typeof(&(hnd)) _sxghr_tmp = &(hnd); \ + _sxghr_tmp->q = 0; \ + _sxghr_tmp->p = val; \ + } while ( 0 ) +#define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val) + +typedef uint64_t xen_pfn_t; +#define PRI_xen_pfn PRIx64 +#define PRIu_xen_pfn PRIu64 + +/* + * Maximum number of virtual CPUs in legacy multi-processor guests. + * Only one. All other VCPUS must use VCPUOP_register_vcpu_info. + */ +#define XEN_LEGACY_MAX_VCPUS 1 + +typedef uint64_t xen_ulong_t; +#define PRI_xen_ulong PRIx64 + +#if defined(__GNUC__) && !defined(__STRICT_ANSI__) +/* Anonymous union includes both 32- and 64-bit names (e.g., r0/x0). */ +# define __DECL_REG(n64, n32) union { \ + uint64_t n64; \ + uint32_t n32; \ + } +#else +/* Non-gcc sources must always use the proper 64-bit name (e.g., x0). */ +#define __DECL_REG(n64, n32) uint64_t n64 +#endif + +struct vcpu_guest_core_regs +{ + /* Aarch64 Aarch32 */ + __DECL_REG(x0, r0_usr); + __DECL_REG(x1, r1_usr); + __DECL_REG(x2, r2_usr); + __DECL_REG(x3, r3_usr); + __DECL_REG(x4, r4_usr); + __DECL_REG(x5, r5_usr); + __DECL_REG(x6, r6_usr); + __DECL_REG(x7, r7_usr); + __DECL_REG(x8, r8_usr); + __DECL_REG(x9, r9_usr); + __DECL_REG(x10, r10_usr); + __DECL_REG(x11, r11_usr); + __DECL_REG(x12, r12_usr); + + __DECL_REG(x13, sp_usr); + __DECL_REG(x14, lr_usr); + + __DECL_REG(x15, __unused_sp_hyp); + + __DECL_REG(x16, lr_irq); + __DECL_REG(x17, sp_irq); + + __DECL_REG(x18, lr_svc); + __DECL_REG(x19, sp_svc); + + __DECL_REG(x20, lr_abt); + __DECL_REG(x21, sp_abt); + + __DECL_REG(x22, lr_und); + __DECL_REG(x23, sp_und); + + __DECL_REG(x24, r8_fiq); + __DECL_REG(x25, r9_fiq); + __DECL_REG(x26, r10_fiq); + __DECL_REG(x27, r11_fiq); + __DECL_REG(x28, r12_fiq); + + __DECL_REG(x29, sp_fiq); + __DECL_REG(x30, lr_fiq); + + /* Return address and mode */ + __DECL_REG(pc64, pc32); /* ELR_EL2 */ + uint32_t cpsr; /* SPSR_EL2 */ + + union { + uint32_t spsr_el1; /* AArch64 */ + uint32_t spsr_svc; /* AArch32 */ + }; + + /* AArch32 guests only */ + uint32_t spsr_fiq, spsr_irq, spsr_und, spsr_abt; + + /* AArch64 guests only */ + uint64_t sp_el0; + uint64_t sp_el1, elr_el1; +}; +typedef struct vcpu_guest_core_regs vcpu_guest_core_regs_t; +DEFINE_XEN_GUEST_HANDLE(vcpu_guest_core_regs_t); + +#undef __DECL_REG + +struct vcpu_guest_context { +#define _VGCF_online 0 +#define VGCF_online (1<<_VGCF_online) + uint32_t flags; /* VGCF_* */ + + struct vcpu_guest_core_regs user_regs; /* Core CPU registers */ + + uint64_t sctlr; + uint64_t ttbcr, ttbr0, ttbr1; +}; +typedef struct vcpu_guest_context vcpu_guest_context_t; +DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); + +/* + * struct xen_arch_domainconfig's ABI is covered by + * XEN_DOMCTL_INTERFACE_VERSION. + */ +#define XEN_DOMCTL_CONFIG_GIC_NATIVE 0 +#define XEN_DOMCTL_CONFIG_GIC_V2 1 +#define XEN_DOMCTL_CONFIG_GIC_V3 2 + +#define XEN_DOMCTL_CONFIG_TEE_NONE 0 +#define XEN_DOMCTL_CONFIG_TEE_OPTEE 1 + +struct xen_arch_domainconfig { + /* IN/OUT */ + uint8_t gic_version; + /* IN */ + uint16_t tee_type; + /* IN */ + uint32_t nr_spis; + /* + * OUT + * Based on the property clock-frequency in the DT timer node. + * The property may be present when the bootloader/firmware doesn't + * set correctly CNTFRQ which hold the timer frequency. + * + * As it's not possible to trap this register, we have to replicate + * the value in the guest DT. + * + * = 0 => property not present + * > 0 => Value of the property + * + */ + uint32_t clock_frequency; +}; + +struct arch_vcpu_info { +}; +typedef struct arch_vcpu_info arch_vcpu_info_t; + +struct arch_shared_info { +}; +typedef struct arch_shared_info arch_shared_info_t; +typedef uint64_t xen_callback_t; + +#endif + +/* PSR bits (CPSR, SPSR) */ + +#define PSR_THUMB (1<<5) /* Thumb Mode enable */ +#define PSR_FIQ_MASK (1<<6) /* Fast Interrupt mask */ +#define PSR_IRQ_MASK (1<<7) /* Interrupt mask */ +#define PSR_ABT_MASK (1<<8) /* Asynchronous Abort mask */ +#define PSR_BIG_ENDIAN (1<<9) /* arm32: Big Endian Mode */ +#define PSR_DBG_MASK (1<<9) /* arm64: Debug Exception mask */ +#define PSR_IT_MASK (0x0600fc00) /* Thumb If-Then Mask */ +#define PSR_JAZELLE (1<<24) /* Jazelle Mode */ + +/* 32 bit modes */ +#define PSR_MODE_USR 0x10 +#define PSR_MODE_FIQ 0x11 +#define PSR_MODE_IRQ 0x12 +#define PSR_MODE_SVC 0x13 +#define PSR_MODE_MON 0x16 +#define PSR_MODE_ABT 0x17 +#define PSR_MODE_HYP 0x1a +#define PSR_MODE_UND 0x1b +#define PSR_MODE_SYS 0x1f + +/* 64 bit modes */ +#define PSR_MODE_BIT 0x10 /* Set iff AArch32 */ +#define PSR_MODE_EL3h 0x0d +#define PSR_MODE_EL3t 0x0c +#define PSR_MODE_EL2h 0x09 +#define PSR_MODE_EL2t 0x08 +#define PSR_MODE_EL1h 0x05 +#define PSR_MODE_EL1t 0x04 +#define PSR_MODE_EL0t 0x00 + +#define PSR_GUEST32_INIT (PSR_ABT_MASK|PSR_FIQ_MASK|PSR_IRQ_MASK|PSR_MODE_SVC) +#define PSR_GUEST64_INIT (PSR_ABT_MASK|PSR_FIQ_MASK|PSR_IRQ_MASK|PSR_MODE_EL1h) + +#define SCTLR_GUEST_INIT xen_mk_ullong(0x00c50078) + +/* + * Virtual machine platform (memory layout, interrupts) + * + * These are defined for consistency between the tools and the + * hypervisor. Guests must not rely on these hardcoded values but + * should instead use the FDT. + */ + +/* Physical Address Space */ + +/* + * vGIC mappings: Only one set of mapping is used by the guest. + * Therefore they can overlap. + */ + +/* vGIC v2 mappings */ +#define GUEST_GICD_BASE xen_mk_ullong(0x03001000) +#define GUEST_GICD_SIZE xen_mk_ullong(0x00001000) +#define GUEST_GICC_BASE xen_mk_ullong(0x03002000) +#define GUEST_GICC_SIZE xen_mk_ullong(0x00002000) + +/* vGIC v3 mappings */ +#define GUEST_GICV3_GICD_BASE xen_mk_ullong(0x03001000) +#define GUEST_GICV3_GICD_SIZE xen_mk_ullong(0x00010000) + +#define GUEST_GICV3_RDIST_REGIONS 1 + +#define GUEST_GICV3_GICR0_BASE xen_mk_ullong(0x03020000) /* vCPU0..127 */ +#define GUEST_GICV3_GICR0_SIZE xen_mk_ullong(0x01000000) + +/* ACPI tables physical address */ +#define GUEST_ACPI_BASE xen_mk_ullong(0x20000000) +#define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000) + +/* PL011 mappings */ +#define GUEST_PL011_BASE xen_mk_ullong(0x22000000) +#define GUEST_PL011_SIZE xen_mk_ullong(0x00001000) + +/* + * 16MB == 4096 pages reserved for guest to use as a region to map its + * grant table in. + */ +#define GUEST_GNTTAB_BASE xen_mk_ullong(0x38000000) +#define GUEST_GNTTAB_SIZE xen_mk_ullong(0x01000000) + +#define GUEST_MAGIC_BASE xen_mk_ullong(0x39000000) +#define GUEST_MAGIC_SIZE xen_mk_ullong(0x01000000) + +#define GUEST_RAM_BANKS 2 + +#define GUEST_RAM0_BASE xen_mk_ullong(0x40000000) /* 3GB of low RAM @ 1GB */ +#define GUEST_RAM0_SIZE xen_mk_ullong(0xc0000000) + +#define GUEST_RAM1_BASE xen_mk_ullong(0x0200000000) /* 1016GB of RAM @ 8GB */ +#define GUEST_RAM1_SIZE xen_mk_ullong(0xfe00000000) + +#define GUEST_RAM_BASE GUEST_RAM0_BASE /* Lowest RAM address */ +/* Largest amount of actual RAM, not including holes */ +#define GUEST_RAM_MAX (GUEST_RAM0_SIZE + GUEST_RAM1_SIZE) +/* Suitable for e.g. const uint64_t ramfoo[] = GUEST_RAM_BANK_FOOS; */ +#define GUEST_RAM_BANK_BASES { GUEST_RAM0_BASE, GUEST_RAM1_BASE } +#define GUEST_RAM_BANK_SIZES { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE } + +/* Current supported guest VCPUs */ +#define GUEST_MAX_VCPUS 128 + +/* Interrupts */ +#define GUEST_TIMER_VIRT_PPI 27 +#define GUEST_TIMER_PHYS_S_PPI 29 +#define GUEST_TIMER_PHYS_NS_PPI 30 +#define GUEST_EVTCHN_PPI 31 + +#define GUEST_VPL011_SPI 32 + +/* PSCI functions */ +#define PSCI_cpu_suspend 0 +#define PSCI_cpu_off 1 +#define PSCI_cpu_on 2 +#define PSCI_migrate 3 + +#ifndef __ASSEMBLY__ +/* Stub definition of PMU structure */ +typedef struct xen_pmu_arch { uint8_t dummy; } xen_pmu_arch_t; +#endif + +#endif /* XEN_PUBLIC_ARCH_ARM_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/include/xen/xen.h b/include/xen/xen.h index 877f2f0..60af17c 100644 --- a/include/xen/xen.h +++ b/include/xen/xen.h @@ -7,6 +7,8 @@ #if defined(__i386__) || defined(__x86_64__) #include "arch-x86/xen.h" +#elif defined(__arm__) || defined (__aarch64__) +#include "arch-arm.h" #else #error Bad architecture #endif diff --git a/include/xtf/hypercall.h b/include/xtf/hypercall.h index acda592..7cf8a9d 100644 --- a/include/xtf/hypercall.h +++ b/include/xtf/hypercall.h @@ -22,6 +22,13 @@ # define HYPERCALL3 _hypercall32_3 # define HYPERCALL4 _hypercall32_4 +#elif defined(__aarch64__) || defined(__arm__) + +#include +# define HYPERCALL1 _hypercall_1 +# define HYPERCALL2 _hypercall_2 +# define HYPERCALL3 _hypercall_3 + #else # error Bad architecture for hypercalls #endif @@ -48,6 +55,10 @@ extern uint8_t hypercall_page[PAGE_SIZE]; /* * Hypercall primatives, compiled for the correct bitness */ + +/* x86 specific hypercalls */ +#if defined(__x86_64__) || defined(__i386__) + static inline long hypercall_set_trap_table(const struct xen_trap_info *ti) { return HYPERCALL1(long, __HYPERVISOR_set_trap_table, ti); @@ -83,17 +94,6 @@ static inline long hypercall_update_descriptor(uint64_t maddr, user_desc desc) #endif } -static inline long hypercall_memory_op(unsigned int cmd, void *arg) -{ - return HYPERCALL2(long, __HYPERVISOR_memory_op, cmd, arg); -} - -static inline long hypercall_multicall(struct multicall_entry *list, - unsigned int nr) -{ - return HYPERCALL2(long, __HYPERVISOR_multicall, list, nr); -} - /* * This hypercall is misnamed in the Xen ABI, and actually operates on a * linear address, not a virtual address. @@ -109,6 +109,34 @@ static inline long hypercall_update_va_mapping( #endif } +static inline long hypercall_mmuext_op(const mmuext_op_t ops[], + unsigned int count, + unsigned int *done, + unsigned int foreigndom) +{ + return HYPERCALL4(long, __HYPERVISOR_mmuext_op, + ops, count, done, foreigndom); +} + +static inline long hypercall_callback_op(unsigned int cmd, const void *arg) +{ + return HYPERCALL2(long, __HYPERVISOR_callback_op, cmd, arg); +} + +#endif /* defined(__x86_64__) || defined(__i386__) */ + +/* Common hypercalls */ +static inline long hypercall_memory_op(unsigned int cmd, void *arg) +{ + return HYPERCALL2(long, __HYPERVISOR_memory_op, cmd, arg); +} + +static inline long hypercall_multicall(struct multicall_entry *list, + unsigned int nr) +{ + return HYPERCALL2(long, __HYPERVISOR_multicall, list, nr); +} + static inline long hypercall_xen_version(unsigned int cmd, void *arg) { return HYPERCALL2(long, __HYPERVISOR_xen_version, cmd, arg); @@ -131,25 +159,11 @@ static inline long hypercall_vcpu_op(unsigned int cmd, unsigned int vcpu, return HYPERCALL3(long, __HYPERVISOR_vcpu_op, cmd, vcpu, extra); } -static inline long hypercall_mmuext_op(const mmuext_op_t ops[], - unsigned int count, - unsigned int *done, - unsigned int foreigndom) -{ - return HYPERCALL4(long, __HYPERVISOR_mmuext_op, - ops, count, done, foreigndom); -} - static inline long hypercall_sched_op(unsigned int cmd, void *arg) { return HYPERCALL2(long, __HYPERVISOR_sched_op, cmd, arg); } -static inline long hypercall_callback_op(unsigned int cmd, const void *arg) -{ - return HYPERCALL2(long, __HYPERVISOR_callback_op, cmd, arg); -} - static inline long hypercall_event_channel_op(unsigned int cmd, void *arg) { return HYPERCALL2(long, __HYPERVISOR_event_channel_op, cmd, arg); @@ -173,6 +187,18 @@ static inline long hypercall_sysctl(xen_sysctl_t *arg) /* * Higher level hypercall helpers */ + +/* x86 specific hypercall helpers */ +#if defined(__x86_64__) || defined(__i386__) + +static inline int hypercall_register_callback(const xen_callback_register_t *arg) +{ + return hypercall_callback_op(CALLBACKOP_register, arg); +} + +#endif /* defined(__x86_64__) || defined(__i386__) */ + +/* Common hypercall helpers */ static inline void hypercall_console_write(const char *buf, unsigned long count) { (void)HYPERCALL3(long, __HYPERVISOR_console_io, CONSOLEIO_write, count, buf); @@ -195,11 +221,6 @@ static inline long hypercall_poll(evtchn_port_t port) return hypercall_sched_op(SCHEDOP_poll, &poll); } -static inline int hypercall_register_callback(const xen_callback_register_t *arg) -{ - return hypercall_callback_op(CALLBACKOP_register, arg); -} - static inline int hypercall_evtchn_send(evtchn_port_t port) { return hypercall_event_channel_op(EVTCHNOP_send, &port); diff --git a/include/xtf/lib.h b/include/xtf/lib.h index 3348464..8afdcf2 100644 --- a/include/xtf/lib.h +++ b/include/xtf/lib.h @@ -5,9 +5,9 @@ #include #include -#if defined(__i386__) +#if defined(__i386__) || defined(__arm__) # define BYTES_PER_LONG 4 -#elif defined(__x86_64__) +#elif defined(__x86_64__) || defined(__aarch64__) # define BYTES_PER_LONG 8 #else # errror Bad width @@ -36,6 +36,11 @@ void __noreturn panic(const char *fmt, ...) __printf(1, 2); ((void)sizeof(struct { char: -!!(cond); })) #endif +#define UNIMPLEMENTED() do { \ + panic("Unimplemented function -> %s:%u\n", \ + __FILE__, __LINE__); \ +} while(0) + #define min(a, b) \ ({ \ const typeof(a) _a = (a); \ -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 10:43:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 10:43:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95963.181270 (Exim 4.92) (envelope-from ) id 1lJwJp-0003Cg-No; Wed, 10 Mar 2021 10:43:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95963.181270; Wed, 10 Mar 2021 10:43:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwJp-0003CP-HL; Wed, 10 Mar 2021 10:43:57 +0000 Received: by outflank-mailman (input) for mailman id 95963; Wed, 10 Mar 2021 10:43:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwJn-000348-Rw for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 10:43:55 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 4471baa2-310a-447f-ab21-e7e20a1a43d8; Wed, 10 Mar 2021 10:43:45 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 582B511B3; Wed, 10 Mar 2021 02:43:45 -0800 (PST) Received: from e123311-lin.arm.com (unknown [10.57.15.227]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 420E33F85F; Wed, 10 Mar 2021 02:43:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4471baa2-310a-447f-ab21-e7e20a1a43d8 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: julien@xen.org, andrew.cooper3@citrix.com, amc96@cam.ac.uk Subject: [XTF 2/4] build: Modify build system to support multiple architectures Date: Wed, 10 Mar 2021 11:43:33 +0100 Message-Id: <20210310104335.14855-3-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 In-Reply-To: <20210310104335.14855-1-michal.orzel@arm.com> References: <20210310104335.14855-1-michal.orzel@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently XTF build system is strictly made up for x86. Modify the build system so that it will be easier to add other platforms to XTF in the future. This is done by generalizing the common makefiles to be architecture independent and creating architecture specific makefiles. Signed-off-by: Michal Orzel --- .gitignore | 2 +- Makefile | 19 ++++++++--- build/common.mk | 49 +++++++++++---------------- build/gen.mk | 22 ++++++------ build/x86/arch-common.mk | 34 +++++++++++++++++++ build/{files.mk => x86/arch-files.mk} | 12 ++----- 6 files changed, 85 insertions(+), 53 deletions(-) create mode 100644 build/x86/arch-common.mk rename build/{files.mk => x86/arch-files.mk} (86%) diff --git a/.gitignore b/.gitignore index 5e458a3..dcacdf3 100644 --- a/.gitignore +++ b/.gitignore @@ -4,7 +4,7 @@ *.pyc *.pyo *.swp -/arch/x86/*.lds +/arch/*/*.lds /cscope.* /dist/ /docs/autogenerated/ diff --git a/Makefile b/Makefile index 15a865f..7c25b0d 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,5 @@ MAKEFLAGS += -rR ROOT := $(abspath $(CURDIR)) -export ROOT # $(xtfdir) defaults to $(ROOT) so development and testing can be done # straight out of the working tree. @@ -19,7 +18,16 @@ endif xtftestdir := $(xtfdir)/tests -export DESTDIR xtfdir xtftestdir +# Supported architectures +SUPPORTED_ARCH := x86 +# Default architecture +ARCH ?= x86 +# Check if specified architecture is supported +ifeq ($(filter $(ARCH),$(SUPPORTED_ARCH)),) +$(error Architecture '$(ARCH)' not supported) +endif + +export ROOT DESTDIR ARCH xtfdir xtftestdir # Programs used CC := $(CROSS_COMPILE)gcc @@ -34,9 +42,12 @@ PYTHON := python export CC CPP INSTALL INSTALL_DATA INSTALL_DIR INSTALL_PROGRAM OBJCOPY PYTHON +# By default enable all the tests +TESTS ?= $(wildcard tests/*) + .PHONY: all all: - @set -e; for D in $(wildcard tests/*); do \ + @set -e; for D in $(TESTS); do \ [ ! -e $$D/Makefile ] && continue; \ $(MAKE) -C $$D build; \ done @@ -45,7 +56,7 @@ all: install: @$(INSTALL_DIR) $(DESTDIR)$(xtfdir) $(INSTALL_PROGRAM) xtf-runner $(DESTDIR)$(xtfdir) - @set -e; for D in $(wildcard tests/*); do \ + @set -e; for D in $(TESTS); do \ [ ! -e $$D/Makefile ] && continue; \ $(MAKE) -C $$D install; \ done diff --git a/build/common.mk b/build/common.mk index 6480a54..71fce5c 100644 --- a/build/common.mk +++ b/build/common.mk @@ -1,21 +1,7 @@ -ALL_CATEGORIES := special functional xsa utility in-development +# Architecture independent/common configuration -ALL_ENVIRONMENTS := pv64 pv32pae hvm64 hvm32pae hvm32pse hvm32 - -PV_ENVIRONMENTS := $(filter pv%,$(ALL_ENVIRONMENTS)) -HVM_ENVIRONMENTS := $(filter hvm%,$(ALL_ENVIRONMENTS)) -32BIT_ENVIRONMENTS := $(filter pv32% hvm32%,$(ALL_ENVIRONMENTS)) -64BIT_ENVIRONMENTS := $(filter pv64% hvm64%,$(ALL_ENVIRONMENTS)) - -# $(env)_guest => pv or hvm mapping -$(foreach env,$(PV_ENVIRONMENTS),$(eval $(env)_guest := pv)) -$(foreach env,$(HVM_ENVIRONMENTS),$(eval $(env)_guest := hvm)) - -# $(env)_arch => x86_32/64 mapping -$(foreach env,$(32BIT_ENVIRONMENTS),$(eval $(env)_arch := x86_32)) -$(foreach env,$(64BIT_ENVIRONMENTS),$(eval $(env)_arch := x86_64)) - -COMMON_FLAGS := -pipe -I$(ROOT)/include -I$(ROOT)/arch/x86/include -MMD -MP +ALL_CATEGORIES := special functional xsa utility in-development +COMMON_FLAGS := -pipe -I$(ROOT)/include -I$(ROOT)/arch/$(ARCH)/include -MMD -MP # Experimental LTO support. `make ... lto=y` COMMON_CFLAGS-$(lto) := -flto @@ -23,25 +9,29 @@ LDFLAGS-$(lto) := -flto -fuse-ld=gold COMMON_AFLAGS := $(COMMON_FLAGS) -D__ASSEMBLY__ COMMON_CFLAGS := $(COMMON_FLAGS) $(COMMON_CFLAGS-y) + +# Include architecture specific configuration +include $(ROOT)/build/$(ARCH)/arch-common.mk + +COMMON_CFLAGS += -I$(ARCH_PATH)/include +COMMON_AFLAGS += -I$(ARCH_PATH)/include COMMON_CFLAGS += -Wall -Wextra -Werror -std=gnu99 -Wstrict-prototypes -O3 -g COMMON_CFLAGS += -fno-common -fno-asynchronous-unwind-tables -fno-strict-aliasing COMMON_CFLAGS += -fno-stack-protector -fno-pic -ffreestanding -COMMON_CFLAGS += -mno-red-zone -mno-sse COMMON_CFLAGS += -Wno-unused-parameter -Winline -COMMON_AFLAGS-x86_32 := -m32 -COMMON_AFLAGS-x86_64 := -m64 - -COMMON_CFLAGS-x86_32 := -m32 -COMMON_CFLAGS-x86_64 := -m64 - +# Default guest configfiles defcfg-pv := $(ROOT)/config/default-pv.cfg.in defcfg-hvm := $(ROOT)/config/default-hvm.cfg.in +# Following variables needs to be set up in $(ROOT)/build/$(ARCH)/arch-files.mk +# obj-perarch get compiled once per architecture +# obj-perenv get compiled once for each environment +# obj-$(env) are objects unique to a specific environment obj-perarch := obj-perenv := -include $(ROOT)/build/files.mk +include $(ROOT)/build/$(ARCH)/arch-files.mk cc-option = $(shell if [ -z "`echo 'int p=1;' | $(CC) $(1) -S -o /dev/null -x c - 2>&1`" ]; \ then echo y; else echo n; fi) @@ -49,7 +39,7 @@ cc-option = $(shell if [ -z "`echo 'int p=1;' | $(CC) $(1) -S -o /dev/null -x c # Disable PIE, but need to check if compiler supports it LDFLAGS-$(call cc-option,-no-pie) += -no-pie -# Run once per environment to set up some common bits & pieces +# Set up some common bits and pieces for specified environment define PERENV_setup AFLAGS_$($(1)_arch) := $$(COMMON_AFLAGS) $$(COMMON_AFLAGS-$($(1)_arch)) @@ -58,8 +48,8 @@ CFLAGS_$($(1)_arch) := $$(COMMON_CFLAGS) $$(COMMON_CFLAGS-$($(1)_arch)) AFLAGS_$(1) := $$(AFLAGS_$($(1)_arch)) $$(COMMON_AFLAGS-$(1)) -DCONFIG_ENV_$(1) -include arch/config.h CFLAGS_$(1) := $$(CFLAGS_$($(1)_arch)) $$(COMMON_CFLAGS-$(1)) -DCONFIG_ENV_$(1) -include arch/config.h -head-$(1) := $(ROOT)/arch/x86/$($(1)_guest)/head-$(1).o -link-$(1) := $(ROOT)/arch/x86/link-$(1).lds +link-$(1) := $(ARCH_PATH)/link-$(1).lds +head-$(1) := $(ARCH_PATH)/$($(1)_guest)/head-$(1).o LDFLAGS_$(1) := -Wl,-T,$$(link-$(1)) -nostdlib $(LDFLAGS-y) @@ -68,7 +58,7 @@ DEPS-$(1) = $$(head-$(1)) \ $$(obj-perarch:%.o=%-$($(1)_arch).o) \ $$(obj-$(1):%.o=%-$(1).o) $$(obj-perenv:%.o=%-$(1).o) -# Generate .lds with approprate flags +# Generate .lds with appropriate flags %/link-$(1).lds: %/link.lds.S $$(CPP) $$(AFLAGS_$(1)) -P -C $$< -o $$@ @@ -90,6 +80,7 @@ DEPS-$(1) = $$(head-$(1)) \ endef +# Make a call to a function PERENV_setup once per each environment $(foreach env,$(ALL_ENVIRONMENTS),$(eval $(call PERENV_setup,$(env)))) define move-if-changed diff --git a/build/gen.mk b/build/gen.mk index f657d87..87eb74e 100644 --- a/build/gen.mk +++ b/build/gen.mk @@ -1,6 +1,6 @@ +# Architecture independent makefile for compiling tests # Sanity checking of expected parameters - ifeq ($(NAME),) $(error NAME should be specified) endif @@ -44,20 +44,20 @@ install: install-each-env info.json @$(INSTALL_DIR) $(DESTDIR)$(xtftestdir)/$(NAME) $(INSTALL_DATA) info.json $(DESTDIR)$(xtftestdir)/$(NAME) -hvm64-format := $(firstword $(filter elf32-x86-64,$(shell $(OBJCOPY) --help)) elf32-i386) - +# Build a test for specified environment define PERENV_build -ifneq ($(1),hvm64) -# Generic link line for most environments +# If any environment needs a special compilation/linking recipe instead of +# the default one, a custom recipe called build-$(env) e.g. build-hvm64 +# should be created in $(ROOT)/build/$(ARCH)/arch-common.mk + test-$(1)-$(NAME): $$(DEPS-$(1)) $$(link-$(1)) +ifndef build-$(1) + @# Generic link line for most environments $(CC) $$(LDFLAGS_$(1)) $$(DEPS-$(1)) -o $$@ else -# hvm64 needs linking normally, then converting to elf32-x86-64 or elf32-i386 -test-$(1)-$(NAME): $$(DEPS-$(1)) $$(link-$(1)) - $(CC) $$(LDFLAGS_$(1)) $$(DEPS-$(1)) -o $$@.tmp - $(OBJCOPY) $$@.tmp -O $(hvm64-format) $$@ - rm -f $$@.tmp + @# Environment specific compilation recipe + $(call build-$(1)) endif cfg-$(1) ?= $(defcfg-$($(1)_guest)) @@ -91,6 +91,8 @@ install-$(1).cfg: $(filter test-$(1)-%,$(TEST-CFGS)) install-each-env: install-$(1) install-$(1).cfg endef + +# Make a call to a function PERENV_build once per each test's environment $(foreach env,$(TEST-ENVS),$(eval $(call PERENV_build,$(env)))) .PHONY: clean diff --git a/build/x86/arch-common.mk b/build/x86/arch-common.mk new file mode 100644 index 0000000..72448db --- /dev/null +++ b/build/x86/arch-common.mk @@ -0,0 +1,34 @@ +# Architecture specific configuration for x86 + +ARCH_PATH := $(ROOT)/arch/x86 +ALL_ENVIRONMENTS := pv64 pv32pae hvm64 hvm32pae hvm32pse hvm32 + +PV_ENVIRONMENTS := $(filter pv%,$(ALL_ENVIRONMENTS)) +HVM_ENVIRONMENTS := $(filter hvm%,$(ALL_ENVIRONMENTS)) +32BIT_ENVIRONMENTS := $(filter pv32% hvm32%,$(ALL_ENVIRONMENTS)) +64BIT_ENVIRONMENTS := $(filter pv64% hvm64%,$(ALL_ENVIRONMENTS)) + +# $(env)_guest => pv or hvm mapping +$(foreach env,$(PV_ENVIRONMENTS),$(eval $(env)_guest := pv)) +$(foreach env,$(HVM_ENVIRONMENTS),$(eval $(env)_guest := hvm)) + +# $(env)_arch => x86_32/64 mapping +$(foreach env,$(32BIT_ENVIRONMENTS),$(eval $(env)_arch := x86_32)) +$(foreach env,$(64BIT_ENVIRONMENTS),$(eval $(env)_arch := x86_64)) + +COMMON_CFLAGS += -mno-red-zone -mno-sse + +COMMON_AFLAGS-x86_32 := -m32 +COMMON_AFLAGS-x86_64 := -m64 +COMMON_CFLAGS-x86_32 := -m32 +COMMON_CFLAGS-x86_64 := -m64 + +hvm64-format := $(firstword $(filter elf32-x86-64,$(shell $(OBJCOPY) --help)) elf32-i386) + +# Compilation recipe for hvm64 +# hvm64 needs linking normally, then converting to elf32-x86-64 or elf32-i386 +define build-hvm64 + $(CC) $$(LDFLAGS_hvm64) $$(DEPS-hvm64) -o $$@.tmp + $(OBJCOPY) $$@.tmp -O $(hvm64-format) $$@ + rm -f $$@.tmp +endef diff --git a/build/files.mk b/build/x86/arch-files.mk similarity index 86% rename from build/files.mk rename to build/x86/arch-files.mk index dfa27e4..b02c849 100644 --- a/build/files.mk +++ b/build/x86/arch-files.mk @@ -1,9 +1,6 @@ -# Files compiled and linked for different architectures and environments -# -# obj-perarch get compiled once per architecture -# obj-perenv get get compiled once for each environment -# obj-$(env) are objects unique to a specific environment +# Architecture specific files compiled and linked for x86 +# Per architecture obj-perarch += $(ROOT)/common/console.o obj-perarch += $(ROOT)/common/exlog.o obj-perarch += $(ROOT)/common/extable.o @@ -17,6 +14,7 @@ obj-perarch += $(ROOT)/common/report.o obj-perarch += $(ROOT)/common/setup.o obj-perarch += $(ROOT)/common/xenbus.o +# Per environment obj-perenv += $(ROOT)/arch/x86/decode.o obj-perenv += $(ROOT)/arch/x86/desc.o obj-perenv += $(ROOT)/arch/x86/extable.o @@ -26,7 +24,6 @@ obj-perenv += $(ROOT)/arch/x86/msr.o obj-perenv += $(ROOT)/arch/x86/setup.o obj-perenv += $(ROOT)/arch/x86/traps.o - # HVM specific objects obj-hvm += $(ROOT)/arch/x86/apic.o obj-hvm += $(ROOT)/arch/x86/hpet.o @@ -40,17 +37,14 @@ obj-hvm += $(ROOT)/arch/x86/x86-tss.o $(foreach env,$(HVM_ENVIRONMENTS),$(eval obj-$(env) += $(obj-hvm))) - # PV specific objects obj-pv += $(ROOT)/arch/x86/pv/traps.o $(foreach env,$(PV_ENVIRONMENTS),$(eval obj-$(env) += $(obj-pv))) - # 32bit specific objects obj-32 += $(ROOT)/arch/x86/entry_32.o $(foreach env,$(32BIT_ENVIRONMENTS),$(eval obj-$(env) += $(obj-32))) - # 64bit specific objects obj-64 += $(ROOT)/arch/x86/entry_64.o $(foreach env,$(64BIT_ENVIRONMENTS),$(eval obj-$(env) += $(obj-64))) -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 10:44:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 10:44:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95966.181288 (Exim 4.92) (envelope-from ) id 1lJwK6-0003SU-8s; Wed, 10 Mar 2021 10:44:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95966.181288; Wed, 10 Mar 2021 10:44:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwK6-0003SK-4I; Wed, 10 Mar 2021 10:44:14 +0000 Received: by outflank-mailman (input) for mailman id 95966; Wed, 10 Mar 2021 10:44:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwK5-0003RY-1p for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 10:44:13 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 93b01f98-da1d-451a-93ce-e0d8e3e4f515; Wed, 10 Mar 2021 10:44:11 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7FD74AC24; Wed, 10 Mar 2021 10:44:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93b01f98-da1d-451a-93ce-e0d8e3e4f515 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615373050; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=X3I7a1Jog+rvSfEanA/u+E2mxc+RtRHVujTNsBgcfZg=; b=hJSuf3eMlCC3/Fr6rHTVlPyUgb55lfAQEwjDDAJnM+VNyaS6haV65zDdZ2tb/OGNlOCw8P ChwbqMUZwBSOFULHIVe9PvU4sSbjinzgvKSCRoao+EJTWdC8D3lx6ISJ4xZxZesjpRqoeW oF77v4z6ZffBm3R4LbxlARH9Abz/jok= To: Juergen Gross , Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH 0/3] Xen: grant table related adjustments following recent XSAs Message-ID: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> Date: Wed, 10 Mar 2021 11:44:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit While addressing the XSAs a number of further oddities were noticed. Try to take care of them. 1: gntdev: don't needlessly allocate k{,un}map_ops[] 2: gnttab: introduce common INVALID_GRANT_{HANDLE,REF} 3: gntdev: don't needlessly use kvcalloc() Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 10 10:45:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 10:45:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95982.181303 (Exim 4.92) (envelope-from ) id 1lJwKt-0003gG-Kx; Wed, 10 Mar 2021 10:45:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95982.181303; Wed, 10 Mar 2021 10:45:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwKt-0003g9-Ht; Wed, 10 Mar 2021 10:45:03 +0000 Received: by outflank-mailman (input) for mailman id 95982; Wed, 10 Mar 2021 10:45:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwKs-0003g1-Qu for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 10:45:02 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 07f34e48-b43f-4b95-9233-6c324fcba987; Wed, 10 Mar 2021 10:45:01 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BEE2DAC24; Wed, 10 Mar 2021 10:45:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07f34e48-b43f-4b95-9233-6c324fcba987 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615373100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=auDrX8MZ83gAoUw+7BpRkycrdv7LFLuKqOyiZSwy028=; b=U6KSOMYSnqdrAhjabRmOrA8sANDOgTUDp0Tcij6mADEbEb8k2sN2Xes4fS4yeXaQhPMTX1 48jmJGbBAuGb/qRlX86u20JXvII8RsZQlZMKCNChd0N6rZp2J4LPc8yG/QuzLFLt2WFgLM zq9/iT1sue4pokc+jwjl+LbrAMwyICE= Subject: [PATCH 1/3] Xen/gntdev: don't needlessly allocate k{,un}map_ops[] From: Jan Beulich To: Juergen Gross , Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" References: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> Message-ID: <180d50cb-5531-8952-4bf0-d65c554638ed@suse.com> Date: Wed, 10 Mar 2021 11:45:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit They're needed only in the not-auto-translate (i.e. PV) case; there's no point in allocating memory that's never going to get accessed. Signed-off-by: Jan Beulich --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -136,17 +136,20 @@ struct gntdev_grant_map *gntdev_alloc_ma add->grants = kvcalloc(count, sizeof(add->grants[0]), GFP_KERNEL); add->map_ops = kvcalloc(count, sizeof(add->map_ops[0]), GFP_KERNEL); add->unmap_ops = kvcalloc(count, sizeof(add->unmap_ops[0]), GFP_KERNEL); - add->kmap_ops = kvcalloc(count, sizeof(add->kmap_ops[0]), GFP_KERNEL); - add->kunmap_ops = kvcalloc(count, - sizeof(add->kunmap_ops[0]), GFP_KERNEL); add->pages = kvcalloc(count, sizeof(add->pages[0]), GFP_KERNEL); if (NULL == add->grants || NULL == add->map_ops || NULL == add->unmap_ops || - NULL == add->kmap_ops || - NULL == add->kunmap_ops || NULL == add->pages) goto err; + if (use_ptemod) { + add->kmap_ops = kvcalloc(count, sizeof(add->kmap_ops[0]), + GFP_KERNEL); + add->kunmap_ops = kvcalloc(count, sizeof(add->kunmap_ops[0]), + GFP_KERNEL); + if (NULL == add->kmap_ops || NULL == add->kunmap_ops) + goto err; + } #ifdef CONFIG_XEN_GRANT_DMA_ALLOC add->dma_flags = dma_flags; @@ -185,8 +188,10 @@ struct gntdev_grant_map *gntdev_alloc_ma for (i = 0; i < count; i++) { add->map_ops[i].handle = -1; add->unmap_ops[i].handle = -1; - add->kmap_ops[i].handle = -1; - add->kunmap_ops[i].handle = -1; + if (use_ptemod) { + add->kmap_ops[i].handle = -1; + add->kunmap_ops[i].handle = -1; + } } add->index = 0; @@ -332,8 +337,8 @@ int gntdev_map_grant_pages(struct gntdev } pr_debug("map %d+%d\n", map->index, map->count); - err = gnttab_map_refs(map->map_ops, use_ptemod ? map->kmap_ops : NULL, - map->pages, map->count); + err = gnttab_map_refs(map->map_ops, map->kmap_ops, map->pages, + map->count); for (i = 0; i < map->count; i++) { if (map->map_ops[i].status == GNTST_okay) From xen-devel-bounces@lists.xenproject.org Wed Mar 10 10:45:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 10:45:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95984.181315 (Exim 4.92) (envelope-from ) id 1lJwLJ-0003nn-Vd; Wed, 10 Mar 2021 10:45:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95984.181315; Wed, 10 Mar 2021 10:45:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwLJ-0003ng-R4; Wed, 10 Mar 2021 10:45:29 +0000 Received: by outflank-mailman (input) for mailman id 95984; Wed, 10 Mar 2021 10:45:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwLI-0003nO-A8 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 10:45:28 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f13af8c0-4ab6-4ec7-b818-c98ca372a428; Wed, 10 Mar 2021 10:45:27 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 775B5AE7B; Wed, 10 Mar 2021 10:45:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f13af8c0-4ab6-4ec7-b818-c98ca372a428 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615373126; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ril/4RPeyhImho9ia6AHwhyvGLcmYtjyWfmoZsXmzHI=; b=kCtLZPpVoqLhEwxjvs2rkNk3Vi8Dcw8h4kl3Q53Zz/olDnQvXyadOtBa1UcYJ+UR2wRg6s MDfx2tUyyPFIH4tDYXbp21bAlkf997nM7CnnudqZJOODWgbBWFJ3HmVv/puxnAokAC2hu0 CDBjJ/doFJMCpVAi8LCiIUODcl8FYsY= Subject: [PATCH 2/3] Xen/gnttab: introduce common INVALID_GRANT_{HANDLE,REF} From: Jan Beulich To: Juergen Gross , Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" References: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> Message-ID: Date: Wed, 10 Mar 2021 11:45:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit It's not helpful if every driver has to cook its own. Generalize xenbus'es INVALID_GRANT_HANDLE and pcifront's INVALID_GRANT_REF (which shouldn't have expanded to zero to begin with). Use the constants in p2m.c and gntdev.c right away, and update field types where necessary so they would match with the constants' types (albeit without touching struct ioctl_gntdev_grant_ref's ref field, as that's part of the public interface of the kernel and would require introducing a dependency on Xen's grant_table.h public header). Signed-off-by: Jan Beulich --- a/arch/arm/xen/p2m.c +++ b/arch/arm/xen/p2m.c @@ -11,6 +11,7 @@ #include #include +#include #include #include @@ -109,7 +110,7 @@ int set_foreign_p2m_mapping(struct gntta map_ops[i].status = GNTST_general_error; unmap.host_addr = map_ops[i].host_addr, unmap.handle = map_ops[i].handle; - map_ops[i].handle = ~0; + map_ops[i].handle = INVALID_GRANT_HANDLE; if (map_ops[i].flags & GNTMAP_device_map) unmap.dev_bus_addr = map_ops[i].dev_bus_addr; else --- a/arch/x86/xen/p2m.c +++ b/arch/x86/xen/p2m.c @@ -741,7 +741,7 @@ int set_foreign_p2m_mapping(struct gntta map_ops[i].status = GNTST_general_error; unmap[0].host_addr = map_ops[i].host_addr, unmap[0].handle = map_ops[i].handle; - map_ops[i].handle = ~0; + map_ops[i].handle = INVALID_GRANT_HANDLE; if (map_ops[i].flags & GNTMAP_device_map) unmap[0].dev_bus_addr = map_ops[i].dev_bus_addr; else @@ -751,7 +751,7 @@ int set_foreign_p2m_mapping(struct gntta kmap_ops[i].status = GNTST_general_error; unmap[1].host_addr = kmap_ops[i].host_addr, unmap[1].handle = kmap_ops[i].handle; - kmap_ops[i].handle = ~0; + kmap_ops[i].handle = INVALID_GRANT_HANDLE; if (kmap_ops[i].flags & GNTMAP_device_map) unmap[1].dev_bus_addr = kmap_ops[i].dev_bus_addr; else --- a/drivers/pci/xen-pcifront.c +++ b/drivers/pci/xen-pcifront.c @@ -26,7 +26,7 @@ #include #include -#define INVALID_GRANT_REF (0) + #define INVALID_EVTCHN (-1) struct pci_bus_entry { @@ -42,7 +42,7 @@ struct pcifront_device { struct list_head root_buses; int evtchn; - int gnt_ref; + grant_ref_t gnt_ref; int irq; --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -186,11 +186,11 @@ struct gntdev_grant_map *gntdev_alloc_ma goto err; for (i = 0; i < count; i++) { - add->map_ops[i].handle = -1; - add->unmap_ops[i].handle = -1; + add->map_ops[i].handle = INVALID_GRANT_HANDLE; + add->unmap_ops[i].handle = INVALID_GRANT_HANDLE; if (use_ptemod) { - add->kmap_ops[i].handle = -1; - add->kunmap_ops[i].handle = -1; + add->kmap_ops[i].handle = INVALID_GRANT_HANDLE; + add->kunmap_ops[i].handle = INVALID_GRANT_HANDLE; } } @@ -279,7 +279,7 @@ static int find_grant_ptes(pte_t *pte, u map->grants[pgnr].ref, map->grants[pgnr].domid); gnttab_set_unmap_op(&map->unmap_ops[pgnr], pte_maddr, flags, - -1 /* handle */); + INVALID_GRANT_HANDLE); return 0; } @@ -297,7 +297,7 @@ int gntdev_map_grant_pages(struct gntdev if (!use_ptemod) { /* Note: it could already be mapped */ - if (map->map_ops[0].handle != -1) + if (map->map_ops[0].handle != INVALID_GRANT_HANDLE) return 0; for (i = 0; i < map->count; i++) { unsigned long addr = (unsigned long) @@ -306,7 +306,7 @@ int gntdev_map_grant_pages(struct gntdev map->grants[i].ref, map->grants[i].domid); gnttab_set_unmap_op(&map->unmap_ops[i], addr, - map->flags, -1 /* handle */); + map->flags, INVALID_GRANT_HANDLE); } } else { /* @@ -332,7 +332,7 @@ int gntdev_map_grant_pages(struct gntdev map->grants[i].ref, map->grants[i].domid); gnttab_set_unmap_op(&map->kunmap_ops[i], address, - flags, -1); + flags, INVALID_GRANT_HANDLE); } } @@ -390,7 +390,7 @@ static int __unmap_grant_pages(struct gn pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); - map->unmap_ops[offset+i].handle = -1; + map->unmap_ops[offset+i].handle = INVALID_GRANT_HANDLE; } return err; } @@ -406,13 +406,15 @@ static int unmap_grant_pages(struct gntd * already unmapped some of the grants. Only unmap valid ranges. */ while (pages && !err) { - while (pages && map->unmap_ops[offset].handle == -1) { + while (pages && + map->unmap_ops[offset].handle == INVALID_GRANT_HANDLE) { offset++; pages--; } range = 0; while (range < pages) { - if (map->unmap_ops[offset+range].handle == -1) + if (map->unmap_ops[offset + range].handle == + INVALID_GRANT_HANDLE) break; range++; } --- a/include/xen/grant_table.h +++ b/include/xen/grant_table.h @@ -50,6 +50,13 @@ #include #include +/* + * Technically there's no reliably invalid grant reference or grant handle, + * so pick the value that is the most unlikely one to be observed valid. + */ +#define INVALID_GRANT_REF ((grant_ref_t)-1) +#define INVALID_GRANT_HANDLE ((grant_handle_t)-1) + #define GNTTAB_RESERVED_XENSTORE 1 /* NR_GRANT_FRAMES must be less than or equal to that configured in Xen */ --- a/include/xen/xenbus.h +++ b/include/xen/xenbus.h @@ -51,7 +51,6 @@ #define XENBUS_MAX_RING_GRANT_ORDER 4 #define XENBUS_MAX_RING_GRANTS (1U << XENBUS_MAX_RING_GRANT_ORDER) -#define INVALID_GRANT_HANDLE (~0U) /* Register callback to watch this node. */ struct xenbus_watch From xen-devel-bounces@lists.xenproject.org Wed Mar 10 10:46:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 10:46:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95989.181329 (Exim 4.92) (envelope-from ) id 1lJwM4-0003ws-A3; Wed, 10 Mar 2021 10:46:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95989.181329; Wed, 10 Mar 2021 10:46:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwM4-0003wl-7A; Wed, 10 Mar 2021 10:46:16 +0000 Received: by outflank-mailman (input) for mailman id 95989; Wed, 10 Mar 2021 10:46:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwM2-0003wc-Dt for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 10:46:14 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 74e6b74e-0ced-4df2-982c-200d980c9508; Wed, 10 Mar 2021 10:46:13 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 017F9AC24; Wed, 10 Mar 2021 10:46:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74e6b74e-0ced-4df2-982c-200d980c9508 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615373173; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yvUHprKx53TaVD+UfRnNYW7HFBxwI5hyLFfjImK+NmI=; b=a08Avz/NSZFWEZLSEKggtjR0QaOpO0YEpvzKqyclVcRIFKKhJbYKiTYvp9GBR9sKc42uD9 7kH517gdlU6BcVbC0XhfYHMVO3pKWDGRVamM3iP6bt4YNG+m07xcUlKLf9x8yUJ5ytwsNC 29dfs0qEwcXQfvpA3NXgXe5G6i84mDU= Subject: [PATCH 3/3] Xen/gntdev: don't needlessly use kvcalloc() From: Jan Beulich To: Juergen Gross , Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" References: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> Message-ID: <9a726be2-4893-8ffe-0ef1-b70dd1c229b1@suse.com> Date: Wed, 10 Mar 2021 11:46:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Requesting zeroed memory when all of it will be overwritten subsequently by all ones is a waste of processing bandwidth. In fact, rather than recording zeroed ->grants[], fill that array too with more appropriate "invalid" indicators. Signed-off-by: Jan Beulich --- v2: Use (now generalized) INVALID_GRANT_REF. --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -133,9 +133,12 @@ struct gntdev_grant_map *gntdev_alloc_ma if (NULL == add) return NULL; - add->grants = kvcalloc(count, sizeof(add->grants[0]), GFP_KERNEL); - add->map_ops = kvcalloc(count, sizeof(add->map_ops[0]), GFP_KERNEL); - add->unmap_ops = kvcalloc(count, sizeof(add->unmap_ops[0]), GFP_KERNEL); + add->grants = kvmalloc_array(count, sizeof(add->grants[0]), + GFP_KERNEL); + add->map_ops = kvmalloc_array(count, sizeof(add->map_ops[0]), + GFP_KERNEL); + add->unmap_ops = kvmalloc_array(count, sizeof(add->unmap_ops[0]), + GFP_KERNEL); add->pages = kvcalloc(count, sizeof(add->pages[0]), GFP_KERNEL); if (NULL == add->grants || NULL == add->map_ops || @@ -143,10 +146,10 @@ struct gntdev_grant_map *gntdev_alloc_ma NULL == add->pages) goto err; if (use_ptemod) { - add->kmap_ops = kvcalloc(count, sizeof(add->kmap_ops[0]), - GFP_KERNEL); - add->kunmap_ops = kvcalloc(count, sizeof(add->kunmap_ops[0]), - GFP_KERNEL); + add->kmap_ops = kvmalloc_array(count, sizeof(add->kmap_ops[0]), + GFP_KERNEL); + add->kunmap_ops = kvmalloc_array(count, sizeof(add->kunmap_ops[0]), + GFP_KERNEL); if (NULL == add->kmap_ops || NULL == add->kunmap_ops) goto err; } @@ -186,6 +189,8 @@ struct gntdev_grant_map *gntdev_alloc_ma goto err; for (i = 0; i < count; i++) { + add->grants[i].domid = DOMID_INVALID; + add->grants[i].ref = INVALID_GRANT_REF; add->map_ops[i].handle = INVALID_GRANT_HANDLE; add->unmap_ops[i].handle = INVALID_GRANT_HANDLE; if (use_ptemod) { From xen-devel-bounces@lists.xenproject.org Wed Mar 10 11:05:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 11:05:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95995.181345 (Exim 4.92) (envelope-from ) id 1lJweQ-0005uD-1z; Wed, 10 Mar 2021 11:05:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95995.181345; Wed, 10 Mar 2021 11:05:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJweP-0005u6-UF; Wed, 10 Mar 2021 11:05:13 +0000 Received: by outflank-mailman (input) for mailman id 95995; Wed, 10 Mar 2021 11:05:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJweO-0005u1-7r for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:05:12 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id de170534-89aa-4d29-913f-6543ee25c00f; Wed, 10 Mar 2021 11:05:11 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 74BE6AEB9; Wed, 10 Mar 2021 11:05:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de170534-89aa-4d29-913f-6543ee25c00f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615374310; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mje8dSbMN9B4ZklugH+HD7/0BcurT3Hoj4/83XEnpRo=; b=idqGOq8m/psAB3x/OxlulWrA2jsg3/j0nZiD0dA686AwiDdiW1aOfuB/T0qsCPyIOR29R+ 1Vbcxycoi6dUDzHlTMEYZVr5GPmh+30SWynAPm+u39svttH4s0mpIL8D9OFURlmoXWoDHU 9aQPN+4SA0dE/ARugvRZ9Sg75EyIPVA= Subject: Re: [PATCH 1/3] Xen/gntdev: don't needlessly allocate k{,un}map_ops[] To: Jan Beulich , Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" References: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> <180d50cb-5531-8952-4bf0-d65c554638ed@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <4dc7d8a8-0789-eab1-396a-26e39158a880@suse.com> Date: Wed, 10 Mar 2021 12:05:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <180d50cb-5531-8952-4bf0-d65c554638ed@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ar0Uu9Th6KiwmGLcvAGt5kQMnwAPkUAlJ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ar0Uu9Th6KiwmGLcvAGt5kQMnwAPkUAlJ Content-Type: multipart/mixed; boundary="2NuDGhbl1SoYZ1koXSoS7FbQtlOdJaqM4"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich , Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" Message-ID: <4dc7d8a8-0789-eab1-396a-26e39158a880@suse.com> Subject: Re: [PATCH 1/3] Xen/gntdev: don't needlessly allocate k{,un}map_ops[] References: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> <180d50cb-5531-8952-4bf0-d65c554638ed@suse.com> In-Reply-To: <180d50cb-5531-8952-4bf0-d65c554638ed@suse.com> --2NuDGhbl1SoYZ1koXSoS7FbQtlOdJaqM4 Content-Type: multipart/mixed; boundary="------------FD4011DA029B80497D26CC62" Content-Language: en-US This is a multi-part message in MIME format. --------------FD4011DA029B80497D26CC62 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 10.03.21 11:45, Jan Beulich wrote: > They're needed only in the not-auto-translate (i.e. PV) case; there's n= o > point in allocating memory that's never going to get accessed. >=20 > Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Juergen --------------FD4011DA029B80497D26CC62 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------FD4011DA029B80497D26CC62-- --2NuDGhbl1SoYZ1koXSoS7FbQtlOdJaqM4-- --ar0Uu9Th6KiwmGLcvAGt5kQMnwAPkUAlJ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBIp+UFAwAAAAAACgkQsN6d1ii/Ey8T 5wf9GuLo/CNZeYql8EwEuhfYaULIbaULwbPuZdK/Dm1OUvXmNcz2lo97FQojrjl6ga/PN23bfY4H tXXbMiQkNc6J3ZwxnWuEqKcHayiWza+eKxZN1WuBx9HVgMOo0puX6X5Lo7PEhDkFcfsgLKk3ovSM 5wUCzhmMskJGgh/zRkFoNo2mK35xQ2SYCaEgzeLa37ASHRGtC5P+xbAD2i1jc99iBA9AbthfoOOG o1zAZUJvg5VNDhZstLoFd46y08T2sfzgZnMyAfIEV/wBjNY5Kb045qnWpYrblsK3oIPeZd3DZgnw MehsigkaYcDNbcM4njhSiuxqVVTZmu4QXjZb9sYmAg== =aCw8 -----END PGP SIGNATURE----- --ar0Uu9Th6KiwmGLcvAGt5kQMnwAPkUAlJ-- From xen-devel-bounces@lists.xenproject.org Wed Mar 10 11:09:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 11:09:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.95998.181357 (Exim 4.92) (envelope-from ) id 1lJwiH-00068j-MC; Wed, 10 Mar 2021 11:09:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 95998.181357; Wed, 10 Mar 2021 11:09:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwiH-00068c-I0; Wed, 10 Mar 2021 11:09:13 +0000 Received: by outflank-mailman (input) for mailman id 95998; Wed, 10 Mar 2021 11:09:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwiG-00068X-P3 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:09:12 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 925b8ad5-01bf-4018-8605-d0c6213edca5; Wed, 10 Mar 2021 11:09:11 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6DDE3AEA3; Wed, 10 Mar 2021 11:09:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 925b8ad5-01bf-4018-8605-d0c6213edca5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615374550; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XTvwSBQxkIcQAZQ5fIwQe5f9+TB3r5qx3c7WDIYqchM=; b=NYZRZanboRvFjRmh8rI78n+E1Htgthqzy10Ow0tGLTmOYsqg1qfQZaxx5evVwuq5TD60E3 x5BxfVC8/Rpxb1UujpfwLGdfjrjJ8oU9uJA7brx/M7uxJQShQqr84Q+YmFSKOF926WXy69 Sw64wbFi9x7dayWqVzVYp/xkpJyfCq4= Subject: Re: [PATCH 2/3] Xen/gnttab: introduce common INVALID_GRANT_{HANDLE,REF} To: Jan Beulich , Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" References: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <0aa08508-4447-ac56-e410-59b040aa9860@suse.com> Date: Wed, 10 Mar 2021 12:09:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="l3WDXn4I4ALMqHcpxICmFyQEkNwKtif5U" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --l3WDXn4I4ALMqHcpxICmFyQEkNwKtif5U Content-Type: multipart/mixed; boundary="98Izm4lq36JkKqngUHxvqYQHF8RaC4Z5u"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich , Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" Message-ID: <0aa08508-4447-ac56-e410-59b040aa9860@suse.com> Subject: Re: [PATCH 2/3] Xen/gnttab: introduce common INVALID_GRANT_{HANDLE,REF} References: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> In-Reply-To: --98Izm4lq36JkKqngUHxvqYQHF8RaC4Z5u Content-Type: multipart/mixed; boundary="------------C23E357AC205CA6840FE97CD" Content-Language: en-US This is a multi-part message in MIME format. --------------C23E357AC205CA6840FE97CD Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 10.03.21 11:45, Jan Beulich wrote: > It's not helpful if every driver has to cook its own. Generalize > xenbus'es INVALID_GRANT_HANDLE and pcifront's INVALID_GRANT_REF (which > shouldn't have expanded to zero to begin with). Use the constants in > p2m.c and gntdev.c right away, and update field types where necessary s= o > they would match with the constants' types (albeit without touching > struct ioctl_gntdev_grant_ref's ref field, as that's part of the public= > interface of the kernel and would require introducing a dependency on > Xen's grant_table.h public header). >=20 > Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Juergen --------------C23E357AC205CA6840FE97CD Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------C23E357AC205CA6840FE97CD-- --98Izm4lq36JkKqngUHxvqYQHF8RaC4Z5u-- --l3WDXn4I4ALMqHcpxICmFyQEkNwKtif5U Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBIqNUFAwAAAAAACgkQsN6d1ii/Ey8S XQf+Lx90+icTncdjcwftBLRUn4MFJaehnANT2fx6VFbowZCF4iWGhE4Yrvw3uH48LH1UmfuBCmN4 25y44IsDIUgvuv6mtma/YNuiqJo2UCVARhU70CUOObodMiCp+km8P5MaMp2Hfb8Ouq69RtcEBLjw QXl0wgY98GqrWEDa23r0pZ28Tg0E0kPjCeYJFkOKJG7nsL5ks8UdOE2nggkcHOsA9MTeiAsiJ5/R OPfx9CaCYrWJ4EIlb7npty3eobzOBu1bZZlxJt0ttKpeZtpPlajX3xBu3whO0xn9+VZsvXUjYSwZ B+kzBQWYg/bfBqPTB10dcCoF7pBudsLlwbCcLJ1zQA== =ddGu -----END PGP SIGNATURE----- --l3WDXn4I4ALMqHcpxICmFyQEkNwKtif5U-- From xen-devel-bounces@lists.xenproject.org Wed Mar 10 11:11:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 11:11:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96000.181368 (Exim 4.92) (envelope-from ) id 1lJwk5-0006wD-2f; Wed, 10 Mar 2021 11:11:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96000.181368; Wed, 10 Mar 2021 11:11:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwk4-0006w6-Va; Wed, 10 Mar 2021 11:11:04 +0000 Received: by outflank-mailman (input) for mailman id 96000; Wed, 10 Mar 2021 11:11:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwk3-0006w1-Gv for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:11:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8307adcc-3d58-48d2-8c0e-070cd31d3e07; Wed, 10 Mar 2021 11:11:02 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 507BEAE78; Wed, 10 Mar 2021 11:11:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8307adcc-3d58-48d2-8c0e-070cd31d3e07 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615374661; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dJSutNaW/cwjs/cHggIP6DvCAcr8Qy+4AdRoE2QlOrk=; b=G/0iNBx4682EoS/5pk2IMHyllJnGpPHZa0LLO8Y0sTpqtCoGv7akzihWwMge0DxwzYg8n6 8KWaBQpLgWLm9p77adGNLjwcxzcYGvvPnFx8zcX1w5MbSDE3eUzj8akI8ZtA74+esb1mrc S6x+Q6KidqM6dlFpdtBLQHu5nMw42F4= Subject: Re: [PATCH 3/3] Xen/gntdev: don't needlessly use kvcalloc() To: Jan Beulich , Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" References: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> <9a726be2-4893-8ffe-0ef1-b70dd1c229b1@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <4500abaf-141d-1f6a-3e41-03cad6e069cc@suse.com> Date: Wed, 10 Mar 2021 12:11:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <9a726be2-4893-8ffe-0ef1-b70dd1c229b1@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D9DJqsBWfcWCBPPcN1yPmzbSeEvvzcS4u" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --D9DJqsBWfcWCBPPcN1yPmzbSeEvvzcS4u Content-Type: multipart/mixed; boundary="GtvEpyySpC4NpKRLLeRTHbMLGV6oor8a5"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich , Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" Message-ID: <4500abaf-141d-1f6a-3e41-03cad6e069cc@suse.com> Subject: Re: [PATCH 3/3] Xen/gntdev: don't needlessly use kvcalloc() References: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> <9a726be2-4893-8ffe-0ef1-b70dd1c229b1@suse.com> In-Reply-To: <9a726be2-4893-8ffe-0ef1-b70dd1c229b1@suse.com> --GtvEpyySpC4NpKRLLeRTHbMLGV6oor8a5 Content-Type: multipart/mixed; boundary="------------172976DE781032C94C2FF162" Content-Language: en-US This is a multi-part message in MIME format. --------------172976DE781032C94C2FF162 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 10.03.21 11:46, Jan Beulich wrote: > Requesting zeroed memory when all of it will be overwritten subsequentl= y > by all ones is a waste of processing bandwidth. In fact, rather than > recording zeroed ->grants[], fill that array too with more appropriate > "invalid" indicators. >=20 > Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Juergen --------------172976DE781032C94C2FF162 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------172976DE781032C94C2FF162-- --GtvEpyySpC4NpKRLLeRTHbMLGV6oor8a5-- --D9DJqsBWfcWCBPPcN1yPmzbSeEvvzcS4u Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBIqUQFAwAAAAAACgkQsN6d1ii/Ey9a YAf/V8rhZy2EShnG33Hs9BcA1XjT+W7NExLnVPnePdxWNONADGJfvwQX/+pwmTcTsRRtEEg13hl9 W96UVCHRkaE63iIs0tcIx8D1xH3ld19B+5F3er3axiH8O7r7U5I0DhHI3ZNTMlsPp6fhJJnfGFyV /gWwzlBdn9WHwRtXABqCXM5GbygBYnD+ZFxOunRQFQSytA+io7A15v1w+Ja2SVW+gH1bkoHGpE9w EuKCld9CMDi3/DyfaAhX27UcO1IvA78bKTQZsPlh1S7xmjuEM+ayEgd9U9cB1iDmzuuxeyCcJY4J //PI2cW6ITbBbdQr6RTY4dvchlIHd8QDxT3lv0WTDQ== =Z9sm -----END PGP SIGNATURE----- --D9DJqsBWfcWCBPPcN1yPmzbSeEvvzcS4u-- From xen-devel-bounces@lists.xenproject.org Wed Mar 10 11:13:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 11:13:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96003.181381 (Exim 4.92) (envelope-from ) id 1lJwmP-00075f-Fi; Wed, 10 Mar 2021 11:13:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96003.181381; Wed, 10 Mar 2021 11:13:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwmP-00075Y-Cd; Wed, 10 Mar 2021 11:13:29 +0000 Received: by outflank-mailman (input) for mailman id 96003; Wed, 10 Mar 2021 11:13:27 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwmN-00075T-OS for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:13:27 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 936b7aa9-22ae-403d-8b83-ff1fc396af22; Wed, 10 Mar 2021 11:13:26 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 91C93AE78; Wed, 10 Mar 2021 11:13:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 936b7aa9-22ae-403d-8b83-ff1fc396af22 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615374805; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eCNKUjyMIm7der6JEf6tGGnpH4ONaht08vLFM0IG6f0=; b=MfO2QB9o7gaGI3YFP8cc+zxO95cRLFfL2H0ZDpnFjULQEKnXaXLTqyqCdAKNwkv1uagPv0 W2jWxo/wcXFtW1SV7TS650kwAFoFEi7cVLBBGSxdPC9SkBVGY/OpuMgHRcHTKhRbHi4890 7DUy5OefO4IoKWA9FrbBXvjZU4A6l+I= Message-ID: <5ac80ae8be856e49fd83245eee4baae986beafa9.camel@suse.com> Subject: Re: Hit ASSERT in credit2 code with NR_CPUS=1 build From: Dario Faggioli To: Roger Pau =?ISO-8859-1?Q?Monn=E9?= , George Dunlap Cc: xen-devel@lists.xenproject.org Date: Wed, 10 Mar 2021 12:13:24 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-4+52hzy5PpD5au/BQ86Z" User-Agent: Evolution 3.38.4 (by Flathub.org) MIME-Version: 1.0 --=-4+52hzy5PpD5au/BQ86Z Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2021-03-09 at 17:24 +0100, Roger Pau Monn=C3=A9 wrote: > Hello, >=20 Hey, > While looking at the NR_CPUS =3D=3D 1 build I realized I could reliable > trigger the following ASSERT by creating a guest (note that dom0 > seems > to be fine): >=20 Yes, I'm (somewhat, not sure if exactly though) able to reproduce. > (XEN) Assertion 'i !=3D cpu' failed at credit2.c:1725 > (XEN) ----[ Xen-4.15.0-rc=C2=A0 x86_64=C2=A0 debug=3Dy=C2=A0 Tainted:=C2= =A0=C2=A0 C=C2=A0=C2=A0 ]---- > (XEN) CPU:=C2=A0=C2=A0=C2=A0 0 > (XEN) RIP:=C2=A0=C2=A0=C2=A0 e008:[] > common/sched/credit2.c#runq_tickle+0x469/0x571 > (XEN) RFLAGS: 0000000000010046=C2=A0=C2=A0 CONTEXT: hypervisor (d4v0) > (XEN) rax: ffffffffffffffff=C2=A0=C2=A0 rbx: 0000000000000000=C2=A0=C2=A0= rcx: > 0000000000000000 > (XEN) rdx: ffff83086c62feb0=C2=A0=C2=A0 rsi: 0000012774fba66c=C2=A0=C2=A0= rdi: > ffff8307e11d5d40 > (XEN) rbp: ffff83008c8c7cf8=C2=A0=C2=A0 rsp: ffff83008c8c7c68=C2=A0=C2=A0= r8:=C2=A0 > ffff83086c66d6c0 > (XEN) r9:=C2=A0 ffff82d0405d1218=C2=A0=C2=A0 r10: 0000000000000000=C2=A0= =C2=A0 r11: > ffff83086c631000 > (XEN) r12: ffff83086c6437c0=C2=A0=C2=A0 r13: 0000000000000000=C2=A0=C2=A0= r14: > ffff83086c62fe20 > (XEN) r15: ffff82d0405d0320=C2=A0=C2=A0 cr0: 0000000080050033=C2=A0=C2=A0= cr4: > 00000000003526e0 > (XEN) cr3: 00000007e130d000=C2=A0=C2=A0 cr2: ffff88826910cb38 > (XEN) fsb: 00007efee038b780=C2=A0=C2=A0 gsb: ffff888273400000=C2=A0=C2=A0= gss: > 0000000000000000 > (XEN) ds: 0000=C2=A0=C2=A0 es: 0000=C2=A0=C2=A0 fs: 0000=C2=A0=C2=A0 gs: = 0000=C2=A0=C2=A0 ss: e010=C2=A0=C2=A0 cs: e008 > (XEN) Xen code around > (common/sched/credit2.c#runq_tickle+0x469/0x571): > (XEN)=C2=A0 ac ff 75 3d 0f 0b 0f 0b <0f> 0b c7 45 ac 00 00 00 00 48 8d 05 > 6f 7e 38 00 > (XEN) Xen stack trace from rsp=3Dffff83008c8c7c68: > [...] > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 0: > (XEN) Assertion 'i !=3D cpu' failed at credit2.c:1725 > (XEN) **************************************** >=20 Interesting... So, how do cpumasks look like/work, with NR_CPUS=3D1 (sorry, I couldn't follow all the aspects of it too closely) ? I'm asking because, what we're doing here is the following. First of all we put together a cpumask (in `mask`) out of the intersection of the CPUs that are in the vcpu's hard/soft affinity, are part of this runqueue, are idle and have not been tickled (where tickled =3D=3D they've been poked and will go through schedule() soon): cpumask_andnot(&mask, &rqd->active, &rqd->idle); cpumask_andnot(&mask, &mask, &rqd->tickled); cpumask_and(&mask, &mask, cpumask_scratch_cpu(cpu)); Now, I would very much expect for `mask` to have at most one bit set (i.e., the one of our only CPU). Actually, considering how unlikely it would be that our only CPU is both idle and not-tickled, I expect mask to be empty most of the times. Anyway, let's say the cpumask has 1 bit set (in which case, it must be the one associated to CPU 0, I presume?). What we do now is this: if ( __cpumask_test_and_clear_cpu(cpu, &mask) ) { ... } Which I think means that, no matter whether or not we enter the loop, we clear the bit. Of course, which bit depends on the value of `cpu`... But with NR_CPUS=3D1, I don't see how `cpu` can have a value different than the ID of the one and only CPU we have. So, in my mind, now `mask` is empty. Therefore, I'm currently clueless about why we enter this loop... > =C2=A0=C2=A0=C2=A0 for_each_cpu(i, &mask) > =C2=A0=C2=A0=C2=A0 { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 s_time_t score; >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Already looked at this one = above */ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ASSERT(i !=3D cpu); <=3D=3D=3D= =3D >=20 ... and we reach this point. I tried to build staging here (with NR_CPUS=3D1), and I think the code for this ASSERT(), for me, is: test %ebx,%ebx je ffff82d040245ac5 (and ffff82d040245ac5 is of course ud2.) Snf this kind of makes sense. Or, at least, I'm not surprised that, if we are inside this loop, `i` is actually equal to `cpu`. What I'm surprised about is that we are inside the loop in the first place... I guess I need to think more about it. Any bright ideas that explain what is going on would be more than appreciated. > In runq_tickle. I'm afraid I have no clue of what's going on. FTR > using a non-debug build with NR_CPUS =3D=3D 1 does seem to work fine and > I > don't see any ill effects. > Well, yes, special casing `cpu` and dealing with it outside of the loop is just an optimization, for when soft-affinity is defined for the vcpu. So it makes sense that things work without the ASSERT(). However, the ASSERT() was there as a consistency check, and it looks to me to be a valid one, even with NR_CPUS=3D1, so I really don't know why it triggers... Thanks and Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-4+52hzy5PpD5au/BQ86Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmBIqdQACgkQFkJ4iaW4 c+5H0w//cpZRV4Y4UVJy8BnnKvENKPx+xx+CnBp8P+kqMKDryv3kzS8zU/Dfs1d9 6TSSJBYpPjeaXnp88GuI3g1NzZYHfyAQBKuSRy6DhXed/aCI2DXB+ub930zzmwXt 3ypV1lUChPpj1SbnYRuYV450Vz1BOosYD0svdVOSnvzKH14VE/c+m0X65mm+IUKy jBrAMxegvDAC8RysIVoFHVIw2ExLyzI/PFZZkO03EE8H1FswAiX23t4YX4gw/5y3 S+kA8dBkaFpWPbGcOxytcwB87vrAsqIFIIffUQQBKnJHZLL7gExGQQfWLUb6Z/ee NLWHc36SokVobbOsGmXFn5CBABPqJsyBc+yDlQU0+8U+dCtit2XKkWysBYH90BeW OmPdDJe0uiKMki7K2DBku4dkBc4XQ8h+Wh8gDw9JMmnlE4mNo1E9vAKfuEhf3c3X a4zrXnLefckw2JJtGCANJ2yxdRfFN0hVpiaRWRLXu7A4lk6mqv+iBgGHXDXkGtZk FXhWZ0uqpeKQJyM85ONTihk1JBgEMvyJM0MO6YLgx12gXWwDIqgyz31vW+ZC33kA CxxLTbPrb0LxHK8C4iLIcHDJ8f2Z1oRZp1QIOAvMhcljA+jkkBmj8or7o0F9yKQd 3wxrLF7344kWhYE7miKQJ4LHIkbbBV22GJNXiTSkRqhSuUGLuP8= =2IDc -----END PGP SIGNATURE----- --=-4+52hzy5PpD5au/BQ86Z-- From xen-devel-bounces@lists.xenproject.org Wed Mar 10 11:14:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 11:14:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96008.181393 (Exim 4.92) (envelope-from ) id 1lJwnL-0007Cw-Ub; Wed, 10 Mar 2021 11:14:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96008.181393; Wed, 10 Mar 2021 11:14:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwnL-0007Co-RH; Wed, 10 Mar 2021 11:14:27 +0000 Received: by outflank-mailman (input) for mailman id 96008; Wed, 10 Mar 2021 11:14:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwnK-0007Ch-ND for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:14:26 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c26db8b5-8465-4d6a-b5f8-943c313c07fb; Wed, 10 Mar 2021 11:14:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c26db8b5-8465-4d6a-b5f8-943c313c07fb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615374866; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=gAL1CWpQh5Vfovsqlcxf55EjjbG441S2ljRcu6DkEbE=; b=LoWiqnA4ObrebIABPFqSosl+x1a3fb3iQIR75ZDvjNZHZwRrMe+njgZi UzBjXnXO1yT4mar5BlppWXj2JHNJ0HCMrWFm4irBoeK+TN0H1mTcxTyEh r8RqxvAw92njvLSByCEiXvCMl23UlGc1EJAw5UCC0pfOYtLFfkBmTmiE/ A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 4Se8efW+pUmNnD3Hz3E0SEdTjoZ5ZSDwSogEMbjeSSEcgNQBRmNW+X+r7i4R10ibDc2+BXIphZ bWKHWK9flUMi+3ZmY36o1rou15N7OQe7SmH0wKegcgtAF/hIoVIfgLK5g3Gf1Q5oou0kEDMHcV o1vJT5AbqQJfPWXgEb990a0kPtsz311LHXGC75Jxc3MeONEpc/eTMCbIHEycl8P0xizfjskYNM Wa0uTd/RQaLFmoxu+RGDqKiHFQWp4DD4aABSJMTR5U6SD3Fe03CMNfxRiPwTXqbrcxEKNfi9qP js4= X-SBRS: 5.2 X-MesageID: 38855821 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,237,1610427600"; d="scan'208";a="38855821" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=crVL2ycZ/RlDFEqK/AFLrcGd36QF7QL3/5dkhzo/zluug191xXrrJBRQKOoZqRDUOQPAz+UUdH+lzeJPWhfAC1Ebb0XeivX4XFBnJbXu5/X1wi2Ja45jTwkJTVr0c9jhXhGOHWss5/ueaSNCMb1usnCqr8y6gYtxqB0dL+Vff8pkP2QF5xtVWARsFzsCl9f8k2v1MnfUq1peNQGeIg3cDCWthfbJO7X/EEI5m02MMr0NcNfQbDK7zuIPxewbx6LGT06i9W1aAqpo9ta8LmZNBrbm0iT1pVIxPTkkKoX9DONe39RTMf5c4fut8Iop92SKl8devjQqBOnPORDE7iwb+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MSlPR975+YkePtkUfBjhUF8gMxXvL5hxSJ1uqufy44A=; b=iwv2swueLLrvwo1fd5tPhKllhFvERUjZprbGOMicXrlLUuUmoP3RQQpB4aokE6zs7npujYODCs9M4yuEd+wRsKIF2XShuNbBor8OXJxZ+2uJYd5nB2hKOSeE/XHbkeR4TrJ7PxxNSLaaFCURC0G0mEs9Sy+fGd26vsVBR9JrFQJPFnGabeUZgsTs2LlWmh9Pjs6bSd5hMXy4sfOUk8Rw6fL0KEC5984dFzkbw/Ri6IiBqDcPGl8PZmCbkS5avvCjQCndSTkDipBv4uGMMaqvnAsRn9/VBF0d8WsWugW4ykD+PjwzoZZ4A47GFThvDokzFZHzXG8l5WHkXv+mzLKQ0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MSlPR975+YkePtkUfBjhUF8gMxXvL5hxSJ1uqufy44A=; b=taTkNixGZNA0jRbCF/7OJw0R/3MXse6z3Mqb+xLNZk8TNYNm3nM9EE6KpCIUvuOnxYaPImh69Xf9T384vaY7GQjnrE0lyFhvByvr1PhAc5bnQCYSI+5VUT49e0rtpj5s7eRGOrx60RiNEtg3SGO6DGfiH6ZFb7fqw4Uu9/leD9U= Date: Wed, 10 Mar 2021 12:13:50 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper , Jan Beulich CC: Ian Jackson , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky , Subject: Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection Message-ID: References: <20210309105634.7200-1-roger.pau@citrix.com> <37e82170-8097-1eda-95d9-23d235075a67@suse.com> <4da62f0b-8a08-dd84-2040-fd55d74fd85a@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4da62f0b-8a08-dd84-2040-fd55d74fd85a@citrix.com> X-ClientProxiedBy: AM6PR0202CA0061.eurprd02.prod.outlook.com (2603:10a6:20b:3a::38) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4481136b-2b24-4de2-03f1-08d8e3b5990b X-MS-TrafficTypeDiagnostic: DM6PR03MB3945: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yV5D7P+pGxQ0cTKn5FhHUmAnhKYq28uWu2Au3Z0fNAhZK/q1oPwSAigciLbmBXCV/9IHbe/9gGsc/aDUdrQ0PgY9iLiEcVcXMM9ffCFTDEcmoJ0LaQNIRUOHb3jgF092B31Zv8/nKqJ+vqNFXTPWtv6J0Z6HdMHSm3NhgcAuMc/QVsRQLlM5No9clf8oRecEngWbpzQXCigTmGjMrRHYFLZjuLZm2K4RQCb3IuSEkkOOZOR5BHwzFLUn8J9GjxBcl05S357/Sq/CpWCKNYlhk9FeoAT+5dhcBDWdNCvq8iNAko23nfdwA9YwGLqtf88TD2V0UHidT+vjFIuTWyEBO2+Q3xbhUYSMospvFaM4iB+XDXClLteyiMANmntGPwbsSETdQr1cWani20nhf4ph4hDUkVWG5A4da18IENfv+jGllS3+E+93giYfmKotFOzsHrruCxA+nVvQVCfp3uEXNFkVqNF7vobQRit4GTuBrDag9eiou3PrX8ApHI7qcAhz6aiGSCp5GetBdSRG5SP6wLGFf52WlQS0BnF5CgZqrEOARwMrdAuojizp9h1/jCtY X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(376002)(396003)(136003)(366004)(39850400004)(346002)(956004)(66556008)(4326008)(316002)(66946007)(186003)(26005)(8936002)(6496006)(66476007)(83380400001)(110136005)(8676002)(16526019)(54906003)(53546011)(33716001)(478600001)(9686003)(6666004)(2906002)(85182001)(5660300002)(7416002)(6486002)(86362001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WnE0R2gwVnJVZGRBemdaMWgwSmw0bjVxQituNkgzNVFxZ2VOcXQyOHBCRVgv?= =?utf-8?B?b1lDSkJIUzZzTjdNeVpWazBoaHQrZlE1Y2x0NTJxTk5ERDBlRFhqZEc1ZDZY?= =?utf-8?B?bGc4Rm1aenA4cVpObUpuSEcrN0RTdlVOZXErQTczT1hkRnlhN284L010MXEv?= =?utf-8?B?NGNUcDBKK3owblAwN3pEcWkzQlREemxtUWk1TTdrN3FhQmJBSG5XVUJRVjNG?= =?utf-8?B?WThmQ3ErQjdLT0p4QzN3L2J6a1huVm9WbzdaTWVQUDZVd3FIMzJ2ZnNhcXdG?= =?utf-8?B?MkRtUzFoUjdHTXlNWVVsN2ZRcVlNbjB1aXlHbjNkV0dzMUlxSnVUM3grM2VI?= =?utf-8?B?SHNlTmo3UmlTSm15dmlwTk1PTGFXNkp5YjBDaDF6Uk9lbGN2N2xWNUw2LzBq?= =?utf-8?B?c3pPN29RWkMwa0tVUlBadFlhV0RHT05aemszSjBDWk5FbFFEcENjU1BwdTBT?= =?utf-8?B?MWxCbTVPRUxGMkZ6TDhkbUlNVWlxM0d6T3YzVzFmdkNkeUI0LzhZcjlrRTRQ?= =?utf-8?B?UStDZXpkc3pNMXhhbzFmeHBidGg4V2pPOFUzSEF2WEVVY01WT1RJSjBLQnZ2?= =?utf-8?B?ZzhSZFloRXpJVXh5UThkeno3RkFqZ2hGYUlUZzZ3b0hJelBTbUVQNHhDc3VT?= =?utf-8?B?TkNnWHdqRWNmeERoaWFjMEFDNEYvdmJSTmRKVWhqWktqekh4RVVEeG9IRGU0?= =?utf-8?B?ZDJMUUo0ZGY2ODZXWW5lUGNsRFdZWURWNHZndThlRWlwcU1RVkdXOXR0dHF6?= =?utf-8?B?SnV5a3YweVFYQkxkbnhld0JoakI3OWdURlJVeGc1MXdyK01GVlZXaHg3NERH?= =?utf-8?B?S0E1a2NNd2lkUHM2TVh0N0pOWFlYZjNpVERiVjZNUnkzbFY3a3NIUU1rVndr?= =?utf-8?B?aTd3Rjk5MFpEaXFWSmJ6L0lXU3ZLRzNCdjlvWENsMlZUOW4yeEFHOW5ROGxG?= =?utf-8?B?MjA0a21xWXUyT2kvWmVmdnhXdUt5aFFHcjJ5aEswc1h4WkwyVWsxQ0M5TXdU?= =?utf-8?B?SHZpd25lS0p0Ymp0OHRMWVk0andaT1hWbWJteC80eHg4SFh2dXdJMGlGTTh6?= =?utf-8?B?K1JLWFQvaWlrdVJEUnNIcXZLb2NaQjFUcVVKU0lHM0Yybk81aDBXbWFCcTJJ?= =?utf-8?B?Q1daZ1k4djdBRVFuTCs5M1kwazk4VHNZT1pneTR4NGZmM2s3YnYvTjJQcTdP?= =?utf-8?B?R1d2cWpyajJzWUFkYjFId0lFQnFaZnVvRXZYZ3NmbWo1ZVEyZmZ1RkJVaVds?= =?utf-8?B?ZW5JcHU5ZXRHd2toMHg0Sm9DU1pHajM1QS9oQ2FZSWZoei8xWEZ3ZEE5bWJX?= =?utf-8?B?eTQrUWxaRGZLTitsR2toaWRTMHlIZ1BzeHE2ZHA3SGdLN0pNZTNEdHREVFRx?= =?utf-8?B?d2s0UllRRXVoU2Y4anRFcHZWR093UWNrd1lKUS85UFh2R0J5d0hRdEdSRldp?= =?utf-8?B?YzFVbjhHOU1oZ3M2cHFwWUxPdkhPdGtDaVJ5OFRNd1JPUU1QeDNWYjc0Tmls?= =?utf-8?B?Nk4vSE82bGhSMHRxSE9BTDNkOEttQkFSbmhOVjN5cU4rdlVTeEJLb054cHFB?= =?utf-8?B?b09XRVBjTmNpY0pIcTArUzZCckRYWTYrYzVxZkVBN3dCSFNsOGcrenIvVjds?= =?utf-8?B?V2JqMzVtTzRYOFZVUHVxV0pnQnpSQ2NKSTZTdGgxYk90RDl0QmYrZGtidDNq?= =?utf-8?B?bWIxTzZoTUpnNWZ3RDBWUXArYTdJWHVSMHNkclpNcUVxQkdDMXFVeHR4TElq?= =?utf-8?Q?9GHq9woQeJePzJnt+vVX+ieEMFBZiLPGjwi2nNm?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4481136b-2b24-4de2-03f1-08d8e3b5990b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 11:13:57.0849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zJCWd/Gjnk+m0rIsXAmoTcqhk96SOzbsEXZiXh7qX2ucSjxj3DY9J+i3BEXeDWwx4JaFUW9cF3a1ZSKoCi/I/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3945 X-OriginatorOrg: citrix.com On Tue, Mar 09, 2021 at 07:57:42PM +0000, Andrew Cooper wrote: > On 09/03/2021 11:36, Jan Beulich wrote: > > On 09.03.2021 11:56, Roger Pau Monne wrote: > >> --- a/xen/arch/x86/pv/emul-priv-op.c > >> +++ b/xen/arch/x86/pv/emul-priv-op.c > >> @@ -875,6 +875,7 @@ static int read_msr(unsigned int reg, uint64_t *val, > >> const struct domain *currd = curr->domain; > >> const struct cpuid_policy *cp = currd->arch.cpuid; > >> bool vpmu_msr = false; > >> + uint64_t tmp; > >> int ret; > >> > >> if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) > >> @@ -986,6 +987,12 @@ static int read_msr(unsigned int reg, uint64_t *val, > >> } > >> /* fall through */ > >> default: > >> + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, tmp) ) > >> + { > >> + *val = 0; > >> + return X86EMUL_OKAY; > >> + } > >> + > >> gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); > >> break; > >> > >> @@ -1148,6 +1155,9 @@ static int write_msr(unsigned int reg, uint64_t val, > >> } > >> /* fall through */ > >> default: > >> + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, val) ) > >> + return X86EMUL_OKAY; > >> + > >> gdprintk(XENLOG_WARNING, > >> "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", > >> reg, val); > > So what are your thoughts wrt my change to this file? Drop it > > altogether and require people to use this new option? Or do you > > see both coexist? In the latter case, since you had suggested > > that I drop the write side of my change - does your changing of > > the write path indicate you've changed your mind? > > I don't think we should legitimise buggy PV behaviour, either by > codifying in the ABI, or providing a knob beyond this one. In that case - can we try to figure out which MSRs is PV Linux trying to access without having the #GP handler setup? Maybe we can try to handle the ones we know the buggy Linux versions will try to access without having #GP setup? I know it's not possible to test all possible Linux versions, but we could at least try to get the ones we know about fixed. Is the only offending one we know about MSR_K8_HWCR? > A guest blindly stumbling forward with a missed #GP could very well > worse than crashing hard. > > Case in point - the 4.15 behaviour spotted a very serious bug in NetBSD > where it tried writing MSR_PAT with its own choice (which wasn't the > same as Xen's choice).  The consequence of this bug is getting cache > attributes in pagetables wrong. Was that write by NetBSD done without the #GP handler setup? Because the patch by Jan affects only that specific scenario. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 10 11:24:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 11:24:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96011.181405 (Exim 4.92) (envelope-from ) id 1lJwxJ-0008E8-Uo; Wed, 10 Mar 2021 11:24:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96011.181405; Wed, 10 Mar 2021 11:24:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwxJ-0008E1-Ri; Wed, 10 Mar 2021 11:24:45 +0000 Received: by outflank-mailman (input) for mailman id 96011; Wed, 10 Mar 2021 11:24:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJwxI-0008Dw-AY for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:24:44 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ac18573e-4364-42a0-8835-e54714e63de5; Wed, 10 Mar 2021 11:24:43 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4F2EFAE78; Wed, 10 Mar 2021 11:24:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac18573e-4364-42a0-8835-e54714e63de5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615375482; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=85m8fftSYrclN47stYnbq7WvpYpQUDAkyCj2JKHHa58=; b=SYAQ7z0QQEjFkQtkoddQOu+y8BxnAlyofd2Q8Yb4xjIz7k92twwEZObUDFnXBm/HHJnPf6 YozAsAjqHeaNGp4QswwcnaQWjpOjNM7r1O9Zw9kMYSnQewM9FlFyG/rIRBhJdDFisfLE8N Q/b9Aa2u28g7RF/sjivU/0JfbUrwS04= Subject: Re: Hit ASSERT in credit2 code with NR_CPUS=1 build To: Dario Faggioli Cc: xen-devel@lists.xenproject.org, George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <5ac80ae8be856e49fd83245eee4baae986beafa9.camel@suse.com> From: Jan Beulich Message-ID: Date: Wed, 10 Mar 2021 12:24:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <5ac80ae8be856e49fd83245eee4baae986beafa9.camel@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 10.03.2021 12:13, Dario Faggioli wrote: > On Tue, 2021-03-09 at 17:24 +0100, Roger Pau Monné wrote: >> Hello, >> > Hey, > >> While looking at the NR_CPUS == 1 build I realized I could reliable >> trigger the following ASSERT by creating a guest (note that dom0 >> seems >> to be fine): >> > Yes, I'm (somewhat, not sure if exactly though) able to reproduce. > >> (XEN) Assertion 'i != cpu' failed at credit2.c:1725 >> (XEN) ----[ Xen-4.15.0-rc  x86_64  debug=y  Tainted:   C   ]---- >> (XEN) CPU:    0 >> (XEN) RIP:    e008:[] >> common/sched/credit2.c#runq_tickle+0x469/0x571 >> (XEN) RFLAGS: 0000000000010046   CONTEXT: hypervisor (d4v0) >> (XEN) rax: ffffffffffffffff   rbx: 0000000000000000   rcx: >> 0000000000000000 >> (XEN) rdx: ffff83086c62feb0   rsi: 0000012774fba66c   rdi: >> ffff8307e11d5d40 >> (XEN) rbp: ffff83008c8c7cf8   rsp: ffff83008c8c7c68   r8:  >> ffff83086c66d6c0 >> (XEN) r9:  ffff82d0405d1218   r10: 0000000000000000   r11: >> ffff83086c631000 >> (XEN) r12: ffff83086c6437c0   r13: 0000000000000000   r14: >> ffff83086c62fe20 >> (XEN) r15: ffff82d0405d0320   cr0: 0000000080050033   cr4: >> 00000000003526e0 >> (XEN) cr3: 00000007e130d000   cr2: ffff88826910cb38 >> (XEN) fsb: 00007efee038b780   gsb: ffff888273400000   gss: >> 0000000000000000 >> (XEN) ds: 0000   es: 0000   fs: 0000   gs: 0000   ss: e010   cs: e008 >> (XEN) Xen code around >> (common/sched/credit2.c#runq_tickle+0x469/0x571): >> (XEN)  ac ff 75 3d 0f 0b 0f 0b <0f> 0b c7 45 ac 00 00 00 00 48 8d 05 >> 6f 7e 38 00 >> (XEN) Xen stack trace from rsp=ffff83008c8c7c68: >> [...] >> (XEN) >> (XEN) **************************************** >> (XEN) Panic on CPU 0: >> (XEN) Assertion 'i != cpu' failed at credit2.c:1725 >> (XEN) **************************************** >> > Interesting... So, how do cpumasks look like/work, with NR_CPUS=1 > (sorry, I couldn't follow all the aspects of it too closely) ? > > I'm asking because, what we're doing here is the following. First of > all we put together a cpumask (in `mask`) out of the intersection of > the CPUs that are in the vcpu's hard/soft affinity, are part of this > runqueue, are idle and have not been tickled (where tickled == they've > been poked and will go through schedule() soon): > > cpumask_andnot(&mask, &rqd->active, &rqd->idle); > cpumask_andnot(&mask, &mask, &rqd->tickled); > cpumask_and(&mask, &mask, cpumask_scratch_cpu(cpu)); > > Now, I would very much expect for `mask` to have at most one bit set > (i.e., the one of our only CPU). Actually, considering how unlikely it > would be that our only CPU is both idle and not-tickled, I expect mask > to be empty most of the times. > > Anyway, let's say the cpumask has 1 bit set (in which case, it must be > the one associated to CPU 0, I presume?). What we do now is this: > > if ( __cpumask_test_and_clear_cpu(cpu, &mask) ) > { > ... > } > > Which I think means that, no matter whether or not we enter the loop, > we clear the bit. Of course, which bit depends on the value of `cpu`... > But with NR_CPUS=1, I don't see how `cpu` can have a value different > than the ID of the one and only CPU we have. > > So, in my mind, now `mask` is empty. Therefore, I'm currently clueless > about why we enter this loop... > >>     for_each_cpu(i, &mask) >>     { >>         s_time_t score; >> >>         /* Already looked at this one above */ >>         ASSERT(i != cpu); <==== >> > ... and we reach this point. from xen/cpumask.h: #define for_each_cpu(cpu, mask) \ for ((cpu) = 0; (cpu) < 1; (cpu)++, (void)(mask)) I'm struggling though why this is this way. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 10 11:32:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 11:32:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96014.181416 (Exim 4.92) (envelope-from ) id 1lJx4S-0000lg-Ov; Wed, 10 Mar 2021 11:32:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96014.181416; Wed, 10 Mar 2021 11:32:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJx4S-0000lZ-Ls; Wed, 10 Mar 2021 11:32:08 +0000 Received: by outflank-mailman (input) for mailman id 96014; Wed, 10 Mar 2021 11:32:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJx4R-0000lU-27 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:32:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJx4R-0000Fx-0O for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:32:07 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJx4Q-0003Zp-Vo for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:32:06 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lJx4C-0005tS-N5; Wed, 10 Mar 2021 11:31:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=3Un91V9mT+3jhV0L99sF4vWuC7pYDdUNg+YmlbA4p/s=; b=fONOfWeWRHyS+O2XSmMFIl/9So G6CGcnh4tuEGsDIZy8/f3lwJ517DftDnrqpqvepdH3LTLtrU56YRob9SABo7I9Qoja8hoGrjAi8J2 NoJyxWiC+2wrCsIlAJNa3dfVuuSp0nKGrzc7NrhtB2+l7e30CCqLBcMtBw4n2/H59tZQ=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24648.44584.312512.639736@mariner.uk.xensource.com> Date: Wed, 10 Mar 2021 11:31:52 +0000 To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , George Dunlap , Wei Liu , Juergen Gross , xen-devel@lists.xenproject.org, Elliott Mitchell Subject: Re: [PATCH for-4.15] arm: replace typeof() with __typeof__() In-Reply-To: References: <202103092114.129LEgZp059925@m5p.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH for-4.15] arm: replace typeof() with __typeof__()"): > On 09.03.2021 22:27, Andrew Cooper wrote: > > This wants backporting as a build fix, so should be considered for 4.15 > > at this point. Release-Acked-by: Ian Jackson Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 10 11:33:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 11:33:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96017.181429 (Exim 4.92) (envelope-from ) id 1lJx5R-0000rs-2w; Wed, 10 Mar 2021 11:33:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96017.181429; Wed, 10 Mar 2021 11:33:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJx5Q-0000rl-W5; Wed, 10 Mar 2021 11:33:08 +0000 Received: by outflank-mailman (input) for mailman id 96017; Wed, 10 Mar 2021 11:33:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJx5P-0000rb-CR for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:33:07 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6a7013db-5aa1-42ba-9e2a-9b10b5ea8a1f; Wed, 10 Mar 2021 11:33:04 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 34B2DAE55; Wed, 10 Mar 2021 11:33:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a7013db-5aa1-42ba-9e2a-9b10b5ea8a1f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615375983; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kKgNATYR2ADz53k1z4+P+EuL9I6B5cwi3wfN0okSA7M=; b=gMKWYUio844M0Bu+0bh8BSadA21sJ9tmw1KEjJRoVFeGaWyzKlzfnLS5XGzPnUthUKiHdo hqvqU5QI5QbBPQnCj60CGBih3sLuQN/1zZlTwIi1UVG8ueCFXaeCcDl5cdnMx9Twi+nD5l DZy6/IR4dVO5/Nx7X9f/Bz4GFdtICPg= Subject: Re: Hit ASSERT in credit2 code with NR_CPUS=1 build From: Jan Beulich To: Dario Faggioli Cc: xen-devel@lists.xenproject.org, George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <5ac80ae8be856e49fd83245eee4baae986beafa9.camel@suse.com> Message-ID: Date: Wed, 10 Mar 2021 12:33:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 10.03.2021 12:24, Jan Beulich wrote: > On 10.03.2021 12:13, Dario Faggioli wrote: >> So, in my mind, now `mask` is empty. Therefore, I'm currently clueless >> about why we enter this loop... >> >>>     for_each_cpu(i, &mask) >>>     { >>>         s_time_t score; >>> >>>         /* Already looked at this one above */ >>>         ASSERT(i != cpu); <==== >>> >> ... and we reach this point. > > from xen/cpumask.h: > > #define for_each_cpu(cpu, mask) \ > for ((cpu) = 0; (cpu) < 1; (cpu)++, (void)(mask)) > > I'm struggling though why this is this way. Quoting Linux 5.11 (where, long ago, our code came from): #define for_each_cpu(cpu, mask) \ for ((cpu) = 0; (cpu) < 1; (cpu)++, (void)mask) #define for_each_cpu_not(cpu, mask) \ for ((cpu) = 0; (cpu) < 1; (cpu)++, (void)mask) #define for_each_cpu_wrap(cpu, mask, start) \ for ((cpu) = 0; (cpu) < 1; (cpu)++, (void)mask, (void)(start)) #define for_each_cpu_and(cpu, mask1, mask2) \ for ((cpu) = 0; (cpu) < 1; (cpu)++, (void)mask1, (void)mask2) where I find particularly odd that for_each_cpu() and for_each_cpu_not() have the same effect when really they should act on disjoint sets of CPUs. I can't find anything under Documentation/ there, so my best guess is that this is either a bug we share, or there was some historical reason for the behavior which wasn't written down anywhere. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 10 11:33:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 11:33:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96020.181441 (Exim 4.92) (envelope-from ) id 1lJx68-0000yG-Bz; Wed, 10 Mar 2021 11:33:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96020.181441; Wed, 10 Mar 2021 11:33:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJx68-0000y9-8p; Wed, 10 Mar 2021 11:33:52 +0000 Received: by outflank-mailman (input) for mailman id 96020; Wed, 10 Mar 2021 11:33:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJx66-0000xy-Nf for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:33:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJx66-0000IC-Mq for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:33:50 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJx66-0003rV-M7 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:33:50 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lJx5q-0005uA-HG; Wed, 10 Mar 2021 11:33:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=9WAQxYiJ3+8ZC3U2C8pjaWlX1R549vui2Sv0g+sv0hs=; b=7LJUGbLBdqXR8dXFPhv4zntrvq WqJe4CNSqdcRlcBwEspNDLcp9VnE+j70d6fopUDUNckmcf+DsBz18koED8k/SsPEJJ/tc6oTvETMk wtttPSfZWAYoyZKdF6YVHw9ztyejNIIbz/VCRg86JVn3V32GykCbK7arvqRhrpCFlMJA=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24648.44686.272676.156900@mariner.uk.xensource.com> Date: Wed, 10 Mar 2021 11:33:34 +0000 To: Jan Beulich Cc: Michal Orzel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org Subject: Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE In-Reply-To: <3247ee1d-f843-7c74-20a4-315716a91097@suse.com> References: <20210310065803.348-1-michal.orzel@arm.com> <3247ee1d-f843-7c74-20a4-315716a91097@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE"): > Nit: Linux, iirc, has dropped support for ---help--- (allowing > only help now). To limit churn whenever we're going to re-sync > our kconfig again, I'd like to avoid introduction of new uses > of the old form. I'm sure this could be taken care of while > committing. At this stage of the release I would prefer to avoid updates made by the committer when committing. Ie the thing that is committed should have been previously posted and had at least some minimal time to spot howlers. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 10 11:40:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 11:40:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96023.181453 (Exim 4.92) (envelope-from ) id 1lJxCE-0001vt-2E; Wed, 10 Mar 2021 11:40:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96023.181453; Wed, 10 Mar 2021 11:40:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJxCD-0001vm-VL; Wed, 10 Mar 2021 11:40:09 +0000 Received: by outflank-mailman (input) for mailman id 96023; Wed, 10 Mar 2021 11:40:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJxCD-0001vh-5q for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:40:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJxCC-0000QF-6I; Wed, 10 Mar 2021 11:40:08 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJxCB-0004Fc-MQ; Wed, 10 Mar 2021 11:40:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=4gwFw7bDZ4IVq9c0TeW+bp5lxQ6YAX7wVVnripp8gKg=; b=MC1NE7j+w5ZjNOxzCcjbPRBcsA PwYoIs00P0sXR2uiUmbm/rZ9N0UGwGcpUYo2Nmzt4bDR4GjfAG3LLbX46IZ5XoRdjqav/pSrzi8ri vC4pJ+ljUz9KzxcNUwDHsbjPAOyoNlAAwwRTmtSw2K4OppHffyLzz91xBQjYDVLUu7Ow=; Subject: Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Ian Jackson , Jan Beulich Cc: Michal Orzel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210310065803.348-1-michal.orzel@arm.com> <3247ee1d-f843-7c74-20a4-315716a91097@suse.com> <24648.44686.272676.156900@mariner.uk.xensource.com> From: Julien Grall Message-ID: Date: Wed, 10 Mar 2021 11:40:05 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24648.44686.272676.156900@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Ian, On 10/03/2021 11:33, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE"): >> Nit: Linux, iirc, has dropped support for ---help--- (allowing >> only help now). To limit churn whenever we're going to re-sync >> our kconfig again, I'd like to avoid introduction of new uses >> of the old form. I'm sure this could be taken care of while >> committing. > > At this stage of the release I would prefer to avoid updates made by > the committer when committing. Ie the thing that is committed should > have been previously posted and had at least some minimal time to spot > howlers. I was under the impression that this patch would not target 4.15. At least I didn't see any request for it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 10 11:44:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 11:44:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96028.181465 (Exim 4.92) (envelope-from ) id 1lJxGp-00026r-QZ; Wed, 10 Mar 2021 11:44:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96028.181465; Wed, 10 Mar 2021 11:44:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJxGp-00026k-Mk; Wed, 10 Mar 2021 11:44:55 +0000 Received: by outflank-mailman (input) for mailman id 96028; Wed, 10 Mar 2021 11:44:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJxGn-00026c-Vq for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 11:44:54 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fee16196-7ccc-43c5-923e-22017c082c88; Wed, 10 Mar 2021 11:44:52 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EAE3BAE84; Wed, 10 Mar 2021 11:44:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fee16196-7ccc-43c5-923e-22017c082c88 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615376692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2hOEQCkeJ/+/P2yPKGORkXNcw/ht/1JPJikJ4OWj8K4=; b=vFyLWrzKR0sbJOr2/Hi9nfFjOY1mB0bsRQtCb6EsYiVsry3wdzkyckAylIa/zP48/h5slX f3dmNOpCdPWzTsQS14oTvZFUkAVDFLpMQ/YxBPoWzADY6WC5qHfEhNbzAeNZjHGoU7MRi3 LPvfDMfubCAD6heKzSYdT5g+A8lEx8Q= Subject: Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Ian Jackson , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky , xen-devel@lists.xenproject.org, Andrew Cooper References: <20210309105634.7200-1-roger.pau@citrix.com> <37e82170-8097-1eda-95d9-23d235075a67@suse.com> <4da62f0b-8a08-dd84-2040-fd55d74fd85a@citrix.com> From: Jan Beulich Message-ID: <184dbf6f-ddc7-b4aa-eee0-de35197283ef@suse.com> Date: Wed, 10 Mar 2021 12:44:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 10.03.2021 12:13, Roger Pau Monné wrote: > On Tue, Mar 09, 2021 at 07:57:42PM +0000, Andrew Cooper wrote: >> On 09/03/2021 11:36, Jan Beulich wrote: >>> So what are your thoughts wrt my change to this file? Drop it >>> altogether and require people to use this new option? Or do you >>> see both coexist? In the latter case, since you had suggested >>> that I drop the write side of my change - does your changing of >>> the write path indicate you've changed your mind? >> >> I don't think we should legitimise buggy PV behaviour, either by >> codifying in the ABI, or providing a knob beyond this one. > > In that case - can we try to figure out which MSRs is PV Linux trying > to access without having the #GP handler setup? > > Maybe we can try to handle the ones we know the buggy Linux versions > will try to access without having #GP setup? > > I know it's not possible to test all possible Linux versions, but we > could at least try to get the ones we know about fixed. Is the only > offending one we know about MSR_K8_HWCR? No, that was the secondary observation. The crash was when reading MSR_K8_TSEG_ADDR. See my patch'es description. Handling this on an MSR-by-MSR basis is what Andrew suggested when I first posted that patch. I continue to not agree, because even if we limited our auditing to just a single Linux version, how could we be sure to catch all cases (including rarely taken paths)? IOW I think auditing isn't a workable approach, and waiting for bug reports isn't one either. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 10 11:45:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 11:45:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96031.181476 (Exim 4.92) (envelope-from ) id 1lJxHN-0002CR-2Q; Wed, 10 Mar 2021 11:45:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96031.181476; Wed, 10 Mar 2021 11:45:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJxHM-0002CK-Ve; Wed, 10 Mar 2021 11:45:28 +0000 Received: by outflank-mailman (input) for mailman id 96031; Wed, 10 Mar 2021 11:45:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJxHL-0002CB-8Q; Wed, 10 Mar 2021 11:45:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJxHL-0000W2-2E; Wed, 10 Mar 2021 11:45:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJxHK-0001KG-PX; Wed, 10 Mar 2021 11:45:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lJxHK-0002YX-P3; Wed, 10 Mar 2021 11:45:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=91O0hz/JbvX449X4STP48kFwqHHU6tFoH9eP+4ErN5s=; b=6FWiHXL0Fqmbd0u870y4PPTkrj 3+AZAUhhgNF8TW6tHNsVp9CSHPiMoJ5Gm5pfPLISofBe3qZPbiXhqxYBJm+5XpJO6LMrNvjeIhgK9 FuLj97ywqE2SK/d9Q1amksBnBheX4OjKqm/ajq7pt2u5HqTSaPbchfauno8Zwf2QjT4Y=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159898: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=b2ae1009d7cca2701e17eae55ae2d44fd22c942a X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Wed, 10 Mar 2021 11:45:26 +0000 flight 159898 qemu-mainline real [real] flight 159908 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159898/ http://logs.test-lab.xenproject.org/osstest/logs/159908/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu b2ae1009d7cca2701e17eae55ae2d44fd22c942a baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 202 days Failing since 152659 2020-08-21 14:07:39 Z 200 days 386 attempts Testing same since 159898 2021-03-09 20:06:58 Z 0 days 1 attempts ------------------------------------------------------------ 439 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 122621 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 10 13:29:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 13:29:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96060.181524 (Exim 4.92) (envelope-from ) id 1lJyu5-0003Ht-ID; Wed, 10 Mar 2021 13:29:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96060.181524; Wed, 10 Mar 2021 13:29:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJyu5-0003Hm-Es; Wed, 10 Mar 2021 13:29:33 +0000 Received: by outflank-mailman (input) for mailman id 96060; Wed, 10 Mar 2021 13:29:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJyu3-0003HV-Nb for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 13:29:31 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [63.128.21.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 4b0afa24-8af7-415b-ab02-b21d7528ff3a; Wed, 10 Mar 2021 13:29:31 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-380-Dot55fPuPren7dHkeTzhxQ-1; Wed, 10 Mar 2021 08:29:27 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA0FB57; Wed, 10 Mar 2021 13:29:25 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-141.ams2.redhat.com [10.36.112.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FE565C648; Wed, 10 Mar 2021 13:29:22 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 8741F18000AC; Wed, 10 Mar 2021 14:29:20 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b0afa24-8af7-415b-ab02-b21d7528ff3a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615382971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8ScCgNxIqd6sDHI2X3m9zVzuFaT/EbwN3SJtZcuNZOs=; b=NglhDWUSJrq9TsrtcgHY7P6+KI+gjn10vZK4KsLHq/XHbBpScJ/jwybjhFclXOZBnkSRdF 6a/MvPjOOKwLDe41XeGcqjZYMLymQ9AmbFVvIsbEeHwJqTBXX3S3sqiJ88/nF3HU0MI47R 0zzK8+RN0tJRtnw9IKrNTXu8aIk9T5A= X-MC-Unique: Dot55fPuPren7dHkeTzhxQ-1 Date: Wed, 10 Mar 2021 14:29:20 +0100 From: Gerd Hoffmann To: Akihiko Odaki Cc: qemu Developers , xen-devel@lists.xenproject.org, "Michael S . Tsirkin" , Stefano Stabellini , Anthony Perard , Paul Durrant Subject: Re: [PATCH v2 2/2] virtio-gpu: Respect UI refresh rate for EDID Message-ID: <20210310132920.6rv5f62ineowzscq@sirius.home.kraxel.org> References: <20210303152948.59943-1-akihiko.odaki@gmail.com> <20210303152948.59943-2-akihiko.odaki@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210303152948.59943-2-akihiko.odaki@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > -static void xenfb_update_interval(void *opaque, uint64_t interval) > +static void xenfb_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info) > - .update_interval = xenfb_update_interval, > + .ui_info = xenfb_ui_info, Hmm, I suspect xenfb really wants the actual refresh rate, even in case vnc/sdl change it dynamically. Anthony? Stefano? I guess we should just leave the update_interval callback as-is, for those who want know, and use ui_info->refresh_rate for the virtual edid refresh rate (which may not match the actual update interval in case of dynamic changes). Adding a comment explaining the difference to console.h is a good idea too. Otherwise looks good to me overall. Splitting the ui/gtk update to a separate patch is probably a good idea. take care, Gerd From xen-devel-bounces@lists.xenproject.org Wed Mar 10 13:36:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 13:36:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96073.181536 (Exim 4.92) (envelope-from ) id 1lJz0p-0004GN-9z; Wed, 10 Mar 2021 13:36:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96073.181536; Wed, 10 Mar 2021 13:36:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJz0p-0004GG-6d; Wed, 10 Mar 2021 13:36:31 +0000 Received: by outflank-mailman (input) for mailman id 96073; Wed, 10 Mar 2021 13:36:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJz0n-0004GB-BY for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 13:36:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJz0n-0002f4-9w for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 13:36:29 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJz0n-0004hp-95 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 13:36:29 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lJz0Y-00069h-12; Wed, 10 Mar 2021 13:36:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=8ms5qV+gEfYguU4vkBpxWrkWXvk58ThvNl32YBhoIys=; b=RB4Pbl7y1jdNHa1mPbEs6t8K4H 4iObhrQs9CievR0CPM0UjdMrvDXTMNl6h0vuLo3JhrjxaKsa15K6M9C7zSI1JUzhCefUPevO4j7Th 3D++C7kZ03yI9O20Srn9UiDI/2Tp6GvUi22gpeSDfBY+Ov5hrD7Ia+5UmTBSDrTZDhrI=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24648.52045.413392.930954@mariner.uk.xensource.com> Date: Wed, 10 Mar 2021 13:36:13 +0000 To: Julien Grall Cc: Jan Beulich , Michal Orzel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org Subject: Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE In-Reply-To: References: <20210310065803.348-1-michal.orzel@arm.com> <3247ee1d-f843-7c74-20a4-315716a91097@suse.com> <24648.44686.272676.156900@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE"): > I was under the impression that this patch would not target 4.15. At > least I didn't see any request for it. OK, good :-). Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 10 13:42:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 13:42:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96076.181547 (Exim 4.92) (envelope-from ) id 1lJz6J-0005EA-UQ; Wed, 10 Mar 2021 13:42:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96076.181547; Wed, 10 Mar 2021 13:42:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJz6J-0005E3-RJ; Wed, 10 Mar 2021 13:42:11 +0000 Received: by outflank-mailman (input) for mailman id 96076; Wed, 10 Mar 2021 13:42:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJz6J-0005Dy-02 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 13:42:11 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7fd63768-11b3-436f-9a39-d5bc95c731e5; Wed, 10 Mar 2021 13:42:08 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id ACEE4AE84; Wed, 10 Mar 2021 13:42:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fd63768-11b3-436f-9a39-d5bc95c731e5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615383727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RbhOMnJC00CNpFucJ2JfplBWXP/4qYu6TB/QlW+p6UM=; b=N+pT7dXGeGUUe9/SQ8qKhXYNeBTuNNZ2FUieCZdEgDPi2qaxfJk75eteWSoSR6buaZicsb CKVbPBbQ0nu9IEMzFa8CUo1jdVcYRhLS9fQUkbhunsxo0BKcMZvywpz51XmhWE/K8nK7Id gAAVo1mGlqyy2seAUmlxJeOxeMd7hA0= Subject: Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection To: Andrew Cooper Cc: Ian Jackson , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky , xen-devel@lists.xenproject.org, Roger Pau Monne References: <20210309105634.7200-1-roger.pau@citrix.com> <37e82170-8097-1eda-95d9-23d235075a67@suse.com> <4da62f0b-8a08-dd84-2040-fd55d74fd85a@citrix.com> From: Jan Beulich Message-ID: <50685b4a-7f29-8b52-aaa6-f3aeceb66beb@suse.com> Date: Wed, 10 Mar 2021 14:42:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <4da62f0b-8a08-dd84-2040-fd55d74fd85a@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09.03.2021 20:57, Andrew Cooper wrote: > On 09/03/2021 11:36, Jan Beulich wrote: >> On 09.03.2021 11:56, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/hvm/svm/svm.c >>> +++ b/xen/arch/x86/hvm/svm/svm.c >>> @@ -1795,6 +1795,7 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) >>> const struct domain *d = v->domain; >>> struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; >>> const struct nestedsvm *nsvm = &vcpu_nestedsvm(v); >>> + uint64_t tmp; >>> >>> switch ( msr ) >>> { >> While to some degree a matter of taste, I think such variables needed >> only inside a switch() and not needing an initializer would better >> live in the respective switch()'s scope. > > Actually, I was hoping to make a CODING_SYTLE change removing this as a > permitted construct. > > Recent compilers have hardening features to automatically initialise all > stack variables, because even if your code isn't architecturally buggy, > an attacker can launch speculative attacks the stack rubble. > > However, because of the way the compiler transform works, it cannot > tolerate this specific construct in a switch statement, as there is no > available execution to cope with the implicit "=0" or "=POISON". While an entirely orthogonal issue, since you bring this up here I'd like to point out that this then is a compiler implementation issue, not something one ought to change source code for. The compiler can very well put its initialization at a suitable place, which - for internal handling purposes - could go as far as introducing and artificial block and hence making code structure as if it was { int tmp; switch ( ... ) { case ...: ... } } Trying to limit variable scope as much as possible shouldn't be crippled by incompletely thought through new hardening options. >>> --- a/xen/arch/x86/pv/emul-priv-op.c >>> +++ b/xen/arch/x86/pv/emul-priv-op.c >>> @@ -875,6 +875,7 @@ static int read_msr(unsigned int reg, uint64_t *val, >>> const struct domain *currd = curr->domain; >>> const struct cpuid_policy *cp = currd->arch.cpuid; >>> bool vpmu_msr = false; >>> + uint64_t tmp; >>> int ret; >>> >>> if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) >>> @@ -986,6 +987,12 @@ static int read_msr(unsigned int reg, uint64_t *val, >>> } >>> /* fall through */ >>> default: >>> + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, tmp) ) >>> + { >>> + *val = 0; >>> + return X86EMUL_OKAY; >>> + } >>> + >>> gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); >>> break; >>> >>> @@ -1148,6 +1155,9 @@ static int write_msr(unsigned int reg, uint64_t val, >>> } >>> /* fall through */ >>> default: >>> + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, val) ) >>> + return X86EMUL_OKAY; >>> + >>> gdprintk(XENLOG_WARNING, >>> "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", >>> reg, val); >> So what are your thoughts wrt my change to this file? Drop it >> altogether and require people to use this new option? Or do you >> see both coexist? In the latter case, since you had suggested >> that I drop the write side of my change - does your changing of >> the write path indicate you've changed your mind? > > I don't think we should legitimise buggy PV behaviour, either by > codifying in the ABI, or providing a knob beyond this one. > > A guest blindly stumbling forward with a missed #GP could very well > worse than crashing hard. There's a fundamental missing piece in your reply here: Do you mean this just as an argument against extending my change to the write side, or as one against my change as a whole? In the latter case, if instead one had to use Roger's new option, the same missing #GP would cause the same possible problems, plus - once the guest has installed a handler - further #GP-s may end up getting suppressed. Jan > Case in point - the 4.15 behaviour spotted a very serious bug in NetBSD > where it tried writing MSR_PAT with its own choice (which wasn't the > same as Xen's choice).  The consequence of this bug is getting cache > attributes in pagetables wrong. > > It is unfortunate that multiple bugs have combined to make this mess, > but every instance needs investigating and fixing.  Continuing to paper > over the hole doesn't help anyone in the long run. > > ~Andrew > From xen-devel-bounces@lists.xenproject.org Wed Mar 10 13:59:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 13:59:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96080.181560 (Exim 4.92) (envelope-from ) id 1lJzNN-0006NG-Fq; Wed, 10 Mar 2021 13:59:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96080.181560; Wed, 10 Mar 2021 13:59:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJzNN-0006N9-Ca; Wed, 10 Mar 2021 13:59:49 +0000 Received: by outflank-mailman (input) for mailman id 96080; Wed, 10 Mar 2021 13:59:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJzNM-0006Mx-9H for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 13:59:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJzNM-00033P-8V for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 13:59:48 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lJzNM-0006OS-7G for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 13:59:48 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lJzNJ-0006Ma-2W; Wed, 10 Mar 2021 13:59:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID: Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=q8OwsW3WlNB1U1E47WtbBFhdXqcGgmgEv3iFeYC72U4=; b=IjC1H7RbJRt3cKLcgywKOVV4d4 MF7NzgThabkzAsdJS6oHG1a4VYh8DJCIOsUuupVYS08glWpiP/O3tk4Yl8NQY05I3XVojJvQbFASB UQJt0R9/V7/rzB8bJVj5wGO+HB1VcPHIHR2Thd1aAbCLbw7OxdrCxhCj1IknansukNS0=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24648.53456.877705.383162@mariner.uk.xensource.com> Date: Wed, 10 Mar 2021 13:59:44 +0000 To: xen-announce@lists.xenproject.org CC: xen-devel@lists.xenproject.org, xen-users@lists.xenproject.org Subject: Xen 4.15 RC2 Xen 4.15 RC2 is now available. It is available from git: git clone https://xenbits.xenproject.org/git-http/xen.git -b 4.15.0-rc2 For your convenience a tarball is available: https://downloads.xenproject.org/release/xen/4.15.0-rc2/xen-4.15.0-rc2.tar.gz https://downloads.xenproject.org/release/xen/4.15.0-rc2/xen-4.15.0-rc2.tar.gz.sig Please send bug reports and test reports to xen-devel@lists.xenproject.org. When sending bug reports, please CC relevant maintainers and me (iwj@xenproject.org). Sorry for the lateness of this RC, which I originally intended to be available this last Monday. I hope to resume the schedule with RC3 this coming Monday. There are still some important fixes and docs changes outstanding. Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 10 14:14:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 14:14:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96123.181609 (Exim 4.92) (envelope-from ) id 1lJzbC-0000GF-Ib; Wed, 10 Mar 2021 14:14:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96123.181609; Wed, 10 Mar 2021 14:14:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJzbC-0000G8-Fj; Wed, 10 Mar 2021 14:14:06 +0000 Received: by outflank-mailman (input) for mailman id 96123; Wed, 10 Mar 2021 14:14:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJzbA-0000G3-W0 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 14:14:05 +0000 Received: from mail.skyhub.de (unknown [5.9.137.197]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9cf3f06a-15c8-4644-9fc1-8431138fa1f5; Wed, 10 Mar 2021 14:14:02 +0000 (UTC) Received: from zn.tnic (p200300ec2f0a9900452923910729ca7d.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:9900:4529:2391:729:ca7d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AE4BD1EC026F; Wed, 10 Mar 2021 15:14:01 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cf3f06a-15c8-4644-9fc1-8431138fa1f5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1615385641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TkMrmSK/gpY6OtMDP3bCzeW/KsANAPjk+GubcA0SiVk=; b=E5tIxCfbxV1QtJ7+kVylOOkptdMD5POD0M28l1YoZoIW5BjvRtSO1DgTJyfsd3pCigHb73 FLUR0E5MOJBdgkckOwBZ5WRAvXqEU6lsD2TQRaNJRsdp9MwWTl+mpMOE9fP7avOddwZqi+ MMqMSC4Aom3dQrDOqhVRCmy5BqdUCF4= Date: Wed, 10 Mar 2021 15:13:47 +0100 From: Borislav Petkov To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini , Peter Zijlstra Subject: Re: [PATCH v6 02/12] x86/paravirt: switch time pvops functions to use static_call() Message-ID: <20210310141347.GF23521@zn.tnic> References: <20210309134813.23912-1-jgross@suse.com> <20210309134813.23912-3-jgross@suse.com> <20210309185737.GE699@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Mar 10, 2021 at 08:51:22AM +0100, Jürgen Groß wrote: > It is combining the two needed actions: update the static call and > set the paravirt_using_native_sched_clock boolean. I actually meant what the point of using_native_sched_clock() is but put this comment at the wrong place, sorry. > Just had another idea: I could add a function to static_call.h for > querying the current function. This would avoid the double book keeping > and could probably be used later when switching other pv_ops calls to > static_call, too (e.g. pv_is_native_spin_unlock()). > > What do you think? Yap, that makes sense. Alternatively, you could even add a bitfield to pv_ops which carries that info and since pv_ops is global... But yeah, the less bookkeeping the better. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Wed Mar 10 14:15:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 14:15:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96126.181621 (Exim 4.92) (envelope-from ) id 1lJzcF-0000N4-So; Wed, 10 Mar 2021 14:15:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96126.181621; Wed, 10 Mar 2021 14:15:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJzcF-0000Mx-Pq; Wed, 10 Mar 2021 14:15:11 +0000 Received: by outflank-mailman (input) for mailman id 96126; Wed, 10 Mar 2021 14:15:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJzcF-0000Mr-2Q for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 14:15:11 +0000 Received: from mail.skyhub.de (unknown [2a01:4f8:190:11c2::b:1457]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2e439a53-8e6e-41b2-94b1-c37858b2e74b; Wed, 10 Mar 2021 14:15:08 +0000 (UTC) Received: from zn.tnic (p200300ec2f0a9900452923910729ca7d.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:9900:4529:2391:729:ca7d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 0D6E01EC026F; Wed, 10 Mar 2021 15:15:08 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e439a53-8e6e-41b2-94b1-c37858b2e74b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1615385708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xInftdEM72Yr3cDyfCScGyACeH4pMYE+757zoD3NCTM=; b=Ypf/zLPu/DN+SzbMFOoHUaGduzDPcW4G6qiHGNzRZljOMuLTfcQsSq9WJmae4/MHG38EQR R3FTVdXqG5bR/i75nBy7m9HXmVtedaR6EZ36Wdkp35HgcYrQG2Hz+QCG2kFottyNxE5TMc QjAl70dhe8qXdLHzBPjBD28Brsyvu1g= Date: Wed, 10 Mar 2021 15:15:10 +0100 From: Borislav Petkov To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Subject: Re: [PATCH v6 04/12] x86/alternative: support not-feature Message-ID: <20210310141510.GG23521@zn.tnic> References: <20210309134813.23912-1-jgross@suse.com> <20210309134813.23912-5-jgross@suse.com> <20210310060705.GB23521@zn.tnic> <1b95376a-56e1-ab3e-aa85-73a9d38aaaf7@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1b95376a-56e1-ab3e-aa85-73a9d38aaaf7@suse.com> On Wed, Mar 10, 2021 at 08:52:40AM +0100, Jürgen Groß wrote: > Did you look at patch 13? :-) Well, I usually review in increasing patch order. :-P But make that change here pls because otherwise unnecessary churn. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Wed Mar 10 14:28:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 14:28:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96129.181634 (Exim 4.92) (envelope-from ) id 1lJzof-0001Tu-2J; Wed, 10 Mar 2021 14:28:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96129.181634; Wed, 10 Mar 2021 14:28:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJzoe-0001Tn-VK; Wed, 10 Mar 2021 14:28:00 +0000 Received: by outflank-mailman (input) for mailman id 96129; Wed, 10 Mar 2021 14:27:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJzod-0001Ti-4L for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 14:27:59 +0000 Received: from mail.skyhub.de (unknown [5.9.137.197]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 60208fd7-687f-4a73-bbdd-2632f1a9bfe6; Wed, 10 Mar 2021 14:27:58 +0000 (UTC) Received: from zn.tnic (p200300ec2f0a9900452923910729ca7d.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:9900:4529:2391:729:ca7d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 325911EC026F; Wed, 10 Mar 2021 15:27:57 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60208fd7-687f-4a73-bbdd-2632f1a9bfe6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1615386477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=ttfTjP2mc2NJJolPrw5G/H4gc7B5Dvgh5Pc2Z3g4DpA=; b=G784EB3nGQcdzbE411YJBthr26JHN+gLIXa9Mev0eBrSU7eI4sjreG0NMvN+zNNB54YtHy i0jxQFrSMbo47kN4XHS8n7NOZcgZya/AeZtPKe2DkA78ZC7wsMhTyfqjR8mbzAWexYvenm xLXKKRRIdxC2CTowlvkgT/jaa0sGEaU= Date: Wed, 10 Mar 2021 15:27:54 +0100 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra Subject: Re: [PATCH v6 05/12] x86/alternative: support ALTERNATIVE_TERNARY Message-ID: <20210310142754.GH23521@zn.tnic> References: <20210309134813.23912-1-jgross@suse.com> <20210309134813.23912-6-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210309134813.23912-6-jgross@suse.com> On Tue, Mar 09, 2021 at 02:48:06PM +0100, Juergen Gross wrote: > diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h > index 89889618ae01..4fb844e29d26 100644 > --- a/arch/x86/include/asm/alternative.h > +++ b/arch/x86/include/asm/alternative.h > @@ -178,6 +178,9 @@ static inline int alternatives_text_reserved(void *start, void *end) > ALTINSTR_REPLACEMENT(newinstr2, 2) \ > ".popsection\n" > > +#define ALTERNATIVE_TERNARY(oldinstr, feature, newinstr1, newinstr2) \ > + ALTERNATIVE_2(oldinstr, newinstr2, X86_FEATURE_ALWAYS, newinstr1, feature) Make that: /* * If @feature is set, patch @newinstr_yes, else @newinstr_no */ #define ALTERNATIVE_TERNARY(oldinstr, feature, newinstr_yes, newinstr_no) \ ALTERNATIVE_2(oldinstr, newinstr_no, X86_FEATURE_ALWAYS, newinstr_yes, feature) and in alternative-asm.h too pls. Regardless, this looks nice! :) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Wed Mar 10 14:41:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 14:41:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96153.181664 (Exim 4.92) (envelope-from ) id 1lK01n-0003TS-ME; Wed, 10 Mar 2021 14:41:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96153.181664; Wed, 10 Mar 2021 14:41:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK01n-0003TL-IF; Wed, 10 Mar 2021 14:41:35 +0000 Received: by outflank-mailman (input) for mailman id 96153; Wed, 10 Mar 2021 14:41:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK01m-0003TC-HY for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 14:41:34 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5b015006-c2a5-4dda-8156-9798c4f2fe07; Wed, 10 Mar 2021 14:41:33 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 639C9AE78; Wed, 10 Mar 2021 14:41:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b015006-c2a5-4dda-8156-9798c4f2fe07 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615387292; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PxSzjwfPtvxXb2e4g0NgV1xOXyHoFy/VgBr2tQy2sJ8=; b=uMrDDZBOhcqgN2YYKOWhP0FNQL25jnl9AcXB6h4jLHnLqUYIuZvshNqiKWh3WHLP8r3+Uz qfztL8wtXVrWatxonKGtCvKwocRUx2WUqt5wPlxZ5whM9qb5LrrOaeVPcpUOFu+KJFRepi AMBSQsU4Gb45X4zJBibKpsWI/05ovpA= Subject: Re: [PATCH v6 04/12] x86/alternative: support not-feature To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" References: <20210309134813.23912-1-jgross@suse.com> <20210309134813.23912-5-jgross@suse.com> <20210310060705.GB23521@zn.tnic> <1b95376a-56e1-ab3e-aa85-73a9d38aaaf7@suse.com> <20210310141510.GG23521@zn.tnic> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <4b7ba26f-af23-7208-db29-4bda7be79cc6@suse.com> Date: Wed, 10 Mar 2021 15:41:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210310141510.GG23521@zn.tnic> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WYWrC1aRj0Zkmr1uiOKvfduKDw2zXLA5r" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WYWrC1aRj0Zkmr1uiOKvfduKDw2zXLA5r Content-Type: multipart/mixed; boundary="ByzS5gGquCchlGt9EfY4LEzkHqKv4UB7r"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Message-ID: <4b7ba26f-af23-7208-db29-4bda7be79cc6@suse.com> Subject: Re: [PATCH v6 04/12] x86/alternative: support not-feature References: <20210309134813.23912-1-jgross@suse.com> <20210309134813.23912-5-jgross@suse.com> <20210310060705.GB23521@zn.tnic> <1b95376a-56e1-ab3e-aa85-73a9d38aaaf7@suse.com> <20210310141510.GG23521@zn.tnic> In-Reply-To: <20210310141510.GG23521@zn.tnic> --ByzS5gGquCchlGt9EfY4LEzkHqKv4UB7r Content-Type: multipart/mixed; boundary="------------04BCC31FF0EE4F36BAA41F64" Content-Language: en-US This is a multi-part message in MIME format. --------------04BCC31FF0EE4F36BAA41F64 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 10.03.21 15:15, Borislav Petkov wrote: > On Wed, Mar 10, 2021 at 08:52:40AM +0100, J=C3=BCrgen Gro=C3=9F wrote: >> Did you look at patch 13? :-) >=20 > Well, I usually review in increasing patch order. :-P >=20 > But make that change here pls because otherwise unnecessary churn. Okay. Juergen --------------04BCC31FF0EE4F36BAA41F64 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------04BCC31FF0EE4F36BAA41F64-- --ByzS5gGquCchlGt9EfY4LEzkHqKv4UB7r-- --WYWrC1aRj0Zkmr1uiOKvfduKDw2zXLA5r Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBI2psFAwAAAAAACgkQsN6d1ii/Ey9i Pwf/a29ypr3sr3STd919ouf1cx7Zi/mYSiScQ3qCIB3O+OWmwxCLmBqMAyQHjK6ssyMt3VQuG8KL iL/s/T0iv8KYFrRTFcKUvLkDRjVBjAEweCJn9famgSJ/kwEaEoJOzl36DHoYMjHs4Ks+QRTZp4U9 X1WaMjFWYSbPN8ZeAxCWnm2BIed4khopHCk7PZxQXihZX/pwJ+Z8zGiBKyLjTwhvNrwXiAxug8Rb Ae6PXn+ZeHuP2MHSIMlOuVeM5xfh1vTrtqFXMT5OrKgDpYBaV9/4IzG9+iz/7JPR8h9B2B/6ejN+ IZTJIfjT5fTQiI7mWU0wIwmpSUBq0JRVvq1+9aZaUg== =LjTz -----END PGP SIGNATURE----- --WYWrC1aRj0Zkmr1uiOKvfduKDw2zXLA5r-- From xen-devel-bounces@lists.xenproject.org Wed Mar 10 14:42:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 14:42:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96156.181675 (Exim 4.92) (envelope-from ) id 1lK02K-0003ZE-3y; Wed, 10 Mar 2021 14:42:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96156.181675; Wed, 10 Mar 2021 14:42:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK02K-0003Z7-0w; Wed, 10 Mar 2021 14:42:08 +0000 Received: by outflank-mailman (input) for mailman id 96156; Wed, 10 Mar 2021 14:42:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK02I-0003Yz-BA for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 14:42:06 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8f9eb122-2aa9-4f04-b1f7-49811c1d7b4a; Wed, 10 Mar 2021 14:42:05 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 83989AE78; Wed, 10 Mar 2021 14:42:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f9eb122-2aa9-4f04-b1f7-49811c1d7b4a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615387324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+/0syBVLNk8kdInbBQltckRnqMuyIZPKIEM/Rs/ny3Y=; b=l9N0AUkqrrHFm/Jp2ESxBj2Y1aKWtXMc+9gTZ8Y4eObL6pCL0JhzS9VWNqD5KgmRemvX/L sqR8uK+2F+v/8JJjxjkKkU+S3cvFrCF7gkk3NJYvw+gN2T7sWttXdXdp2XyjiZB1/bxxg3 7hYEgI7txiHx6Rs0W07H21ysOoHiev0= Subject: Re: [PATCH v6 05/12] x86/alternative: support ALTERNATIVE_TERNARY To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra References: <20210309134813.23912-1-jgross@suse.com> <20210309134813.23912-6-jgross@suse.com> <20210310142754.GH23521@zn.tnic> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <544d2242-9a1d-b7cb-dd8f-e40c9277a3de@suse.com> Date: Wed, 10 Mar 2021 15:42:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210310142754.GH23521@zn.tnic> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yUa0AJIhNLS0Uyf0hnyo1orD0saQSud6E" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --yUa0AJIhNLS0Uyf0hnyo1orD0saQSud6E Content-Type: multipart/mixed; boundary="kJ8l9mKS7p0DVZOe2szQ2JoMiNQgWluHZ"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra Message-ID: <544d2242-9a1d-b7cb-dd8f-e40c9277a3de@suse.com> Subject: Re: [PATCH v6 05/12] x86/alternative: support ALTERNATIVE_TERNARY References: <20210309134813.23912-1-jgross@suse.com> <20210309134813.23912-6-jgross@suse.com> <20210310142754.GH23521@zn.tnic> In-Reply-To: <20210310142754.GH23521@zn.tnic> --kJ8l9mKS7p0DVZOe2szQ2JoMiNQgWluHZ Content-Type: multipart/mixed; boundary="------------B77F5407A0AB926917EEBC34" Content-Language: en-US This is a multi-part message in MIME format. --------------B77F5407A0AB926917EEBC34 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 10.03.21 15:27, Borislav Petkov wrote: > On Tue, Mar 09, 2021 at 02:48:06PM +0100, Juergen Gross wrote: >> diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm= /alternative.h >> index 89889618ae01..4fb844e29d26 100644 >> --- a/arch/x86/include/asm/alternative.h >> +++ b/arch/x86/include/asm/alternative.h >> @@ -178,6 +178,9 @@ static inline int alternatives_text_reserved(void = *start, void *end) >> ALTINSTR_REPLACEMENT(newinstr2, 2) \ >> ".popsection\n" >> =20 >> +#define ALTERNATIVE_TERNARY(oldinstr, feature, newinstr1, newinstr2) = \ >> + ALTERNATIVE_2(oldinstr, newinstr2, X86_FEATURE_ALWAYS, newinstr1, fe= ature) >=20 > Make that: >=20 > /* > * If @feature is set, patch @newinstr_yes, else @newinstr_no > */ > #define ALTERNATIVE_TERNARY(oldinstr, feature, newinstr_yes, newinstr_n= o) \ > ALTERNATIVE_2(oldinstr, newinstr_no, X86_FEATURE_ALWAYS, newin= str_yes, feature) >=20 > and in alternative-asm.h too pls. Okay. >=20 > Regardless, this looks nice! :) Thanks, Juergen --------------B77F5407A0AB926917EEBC34 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------B77F5407A0AB926917EEBC34-- --kJ8l9mKS7p0DVZOe2szQ2JoMiNQgWluHZ-- --yUa0AJIhNLS0Uyf0hnyo1orD0saQSud6E Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBI2rsFAwAAAAAACgkQsN6d1ii/Ey/H 8Af+Mp6GwCI/zjkP3UBP3qphr21aQq25jWKZb9guCkcsrn2XmX5MCZQw9K1ZCMohoLa5VVbDuNA+ 6DoaPJOl5RIAewSCKcNIseCY8+ulrddEsk8oJs9WfMQfPSHWQOs7F5MvyFVz9YAhTGOIMZVYfPj5 Vw4eNcyeZZ/SlUPcsUQ4wIfoSh4s8H3Nhi5NHdri/vs3MEOtxwCgGXRYgG1VTRQRfHIk3k/DcOBc e0AzBBzMPSyFQh36RIse5cc0cuFT/0tVQ5nvIBbr89YO259csXG7Bx+S8e7KUYL9F3DbFbVPbKRs 4o2+vNL1+u5BVlR+jcDygOpspt2ataDtxVIurSiFWQ== =+cHb -----END PGP SIGNATURE----- --yUa0AJIhNLS0Uyf0hnyo1orD0saQSud6E-- From xen-devel-bounces@lists.xenproject.org Wed Mar 10 14:58:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 14:58:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96162.181688 (Exim 4.92) (envelope-from ) id 1lK0Hi-0004f6-HJ; Wed, 10 Mar 2021 14:58:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96162.181688; Wed, 10 Mar 2021 14:58:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0Hi-0004ez-E6; Wed, 10 Mar 2021 14:58:02 +0000 Received: by outflank-mailman (input) for mailman id 96162; Wed, 10 Mar 2021 14:58:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0Hg-0004eu-AW for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 14:58:00 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5d0a4aba-b078-4f67-8c49-6751fc07056d; Wed, 10 Mar 2021 14:57:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d0a4aba-b078-4f67-8c49-6751fc07056d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615388277; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=4nMsvboqKdWWSmRA52cQ6+vWf67vuT3NwByJv3JcYk0=; b=dad1Y6rAKgHWY4uvse+kmhlqwNx412Z1PzOHq6tr+LHEU62F2YfqYNxU NEGnqFaxA4/TbtoLmOnfh1M3FRkwJ6M5GKrQOGuTCeCKOG+B8uGhXD27D Qk06PLutenmIM7maksYmErksUbYzMDfuOTtVurP5Rnuw1Iy0MRRKAvD9M 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: fs6RWvyVOEZKbBuJiKmDd6WMfPz/I2ZqNmy50M0RuCOY3bKk+RnlATWInZk7qhKI+8XI56FICq c0Ic56oFl9IWaw/15GHIXS3yfgSdHy93lc7e23IssnXTgMzR4p1Q1lZTTegtHXgr5+XhwLZEtQ 4GYT/ppTYrT3CK/tpTYFtFPyPRCUUX3g9u3/XZgeYQGJu27j2/9GC+D5C3b7fzxcJ+PtiTqZ78 MfZzzCkIkaROsdmmJKCBr6uGtn8V7mBMEIbLYr+2TYF6HTMOUzhm5WfB+KyXCKaXNYCWUggjOp rPk= X-SBRS: 5.2 X-MesageID: 38872585 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:zqy7e6rZx/X1nsjhtPEC+E8aV5v5L9V00zAX/kB9WHVpW+SFis Gjm+ka3xfoiDAXHEotg8yEJbPoex7h3LR+iLNwAZ6JWg76tGy0aLxz9IeK+UyFJwTS1M54kZ 1hfa93FcHqATFB5/rSzQGkH78br+Wv37uvgY7loUtFaSFPR+Ve4xxiCgCde3cGITVuIZYiDp KT6o5milObCBcqR/+2DHUEQOTPzuej/P7bSCULGgI97022hS6ogYSQLzGjwhwcXzlTqI1Sk1 TtrgqR3MSemsD+8DDw/Sv575NamNzuo+EzefCku4wuBRjHziqtbIRlcbWesD4yu/HH0idXrP D85y0OEu42x3TNfnykgRaF4Xie7B8er0XM5HXdoXz/rdf3TDg3YvAx+75xQ1/ixGcL+PRfuZ g7uF6xht5sIj7r2BnZ3ZzuUSpnk0KlyEBS6tI7vjhkfqY1LINKoZd3xjIyLL4wWBjUxaoAC+ dUAMTV9J9tACmnRkGchGVpzdC2N05DZyuucwwHssyR5TBcgGp0+Use3NAehXcN7vsGOuF529 g= X-IronPort-AV: E=Sophos;i="5.81,237,1610427600"; d="scan'208,223";a="38872585" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O06zGy5SgFnCJgLjOOgSnim+yNykOoDrMWVQkmSsGcS+fP02FnXJ3IN8W7RdsQsAUA4wPi2Lb5mgIrI7dCbte1FnSAC/6IQ4Dkbc5YmyHzQR0MAyIeBLpwjJ3CzHz8NvuSw8ZFheT71jvFH/ghJ/AVwcmSPPo/buDkEcAtO+UVoV1KIeTOP1eSJpegXCI/zfR1Bo03955T/2oYNb+g/G4W96IWKRfvkucCi+jFeugn1M493KsUoY1HE8QGMnN/uGni0C88etr9S8AeA00RAJVs2SnQpWLyMYNbcFlgg+hkCuvfTmyTiPch/QCsAZeM8AkQYYnCez1wsBGUX/XAqh7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PwShmI2TmKE7lBcmbu0IcWjuophqoO1gHU2oUZDU7Z8=; b=YE53sUfXvTeCpEB6DgpuRB8e5uaNafJ3B+bjrme94FDriIX3d6yPa9FVPmYFSWiooMGtAMJYbOydx+DTpkdh6CLOW5hf8NNSGCks+dfMEZdFyfJl85VThtaQCuly+Emwj3azf9/48QYO/rll7HKkPPQpcL+Nlv70mPd/SHrZ1of9UhjFhxA+rVFeYAygQ+7HiRokfiW6dFSJ+UKCE0IojGRK4Kv5o2ryCyZWuuLu9hOb166m0J2SwU8wZkjExmGkkCll4NUUXk4o0W8A6ynlniAExH4vF2EXQOVuKLjU/o+rNEjjraDr0VVxigbBO4sh6YiUAKAGSPFmNKdfYil9jQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PwShmI2TmKE7lBcmbu0IcWjuophqoO1gHU2oUZDU7Z8=; b=qgM1vYixnkhqwcGMsT0UHpDv+fvXlmV9dayzycj3thxT7zVChNwlmVde2I1DzGq2uofcMQx3xbNpRbtZBFGNm5d5m/j/NwvnLDzrEbd3mhaPXQKatYwc3fIpb7bEc7rzsRmiXi8YS8smLR6O1B4M2MMuCt0/yS6MhDRWKCCq7DE= From: Roger Pau Monne To: CC: Roger Pau Monne , Ian Jackson , Wei Liu , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection Date: Wed, 10 Mar 2021 15:57:30 +0100 Message-ID: <20210310145730.27951-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0444.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::24) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 55ba6e0d-329c-406c-9b14-08d8e3d4dd2b X-MS-TrafficTypeDiagnostic: DM5PR03MB2777: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YPjI3dL7q49/oxcZ4GsOGTKi49ZpcvSm4vC0lim5CrVJshPSL7X/zTex7FDP6H4F1h2pEbLJpv+DlVgrYSXUO3FoQQNIcGuLVLUGMNUGnKDaUUg8vobac/i5hW650lZjKMvIUHITsWBspWH3QnsDsCUOKuyF6bQrqy8IQHtFy5Vm18IHFJYu3qxWoUPE8NJVRtAwCX7gIMykNIP+SDab1yuo/QYT2G4qYQPNU/IUY9ICXT2fl5IjmAGCuuly/vc2df4wcEHxmMr5xr0PyUXNUjFw4XBzJVSc+yGRAcaAEs8/z184by5vutl6zCkdWki07r0pYotdApPaY83er2sviFvkOBW4RrEBbfVt5xyxx340l78afUAYtaA3U4m81XnEZ0XJKr3d4voGnefX3oUgbqzwTouV2H78gwID6+Hh8HXwshmLlKsRCxX3ZkeC611bF2XqNK+j3AsbfP3BHacL3p4Oysn30H9EnCjCmBQmEaFrX+oLF0+7A4I1ZGiHUBNezGyD0dzimDRkV8Yfks/KRA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(346002)(366004)(136003)(396003)(316002)(478600001)(54906003)(6666004)(2616005)(6496006)(7416002)(956004)(6916009)(26005)(36756003)(86362001)(83380400001)(186003)(16526019)(6486002)(1076003)(30864003)(66476007)(66946007)(8936002)(4326008)(2906002)(8676002)(66556008)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UnA0c0FMZDZHbm41MWYvZVExblNid3FsQmtmWkpMb2Jsc1hjdy9lQ2FacURy?= =?utf-8?B?OVE0TEZxbWZZdFczOUxvVzVuNW1uRC9OMGNlU2xhb0dkbE53Z3FUY2Z0a1Fq?= =?utf-8?B?Zjl5OG9MMXY2VHprRTZDajhXenVjYVlkK25tY2Yzb3ZSWnJ0dXFsajVsSHNy?= =?utf-8?B?R3loZE9pVXM3QXR5RTNoaUpXb3QrbUpCdkI2Ykc3U1YvNFFRSU41NjZsRVBP?= =?utf-8?B?dGRaYTVKZWd5SFRjalF5dUgwYWVOVnRZTmt6WnhCK2VSdi9PcmhpRGRyVDc3?= =?utf-8?B?bFp1UmlFcFV6Y2NtcWcybUlXNklmem9Ba3NscnY2MlN6K3NkeW5YS2w3TUZQ?= =?utf-8?B?OExUTEQ5SE81a3ZrSUFpQXJNaDJ6LytiNU5mRG85Ulh5OTEwczVTa1l2VEU1?= =?utf-8?B?UnlPbGNRQUNzVUE1elBidFlSQ3dFQ2RlZWt1c3NlcER6UklXZ085ZUxGWURB?= =?utf-8?B?NWxkemRSVjY3MkVjODNHSmQ3UEl6dHRBMWYrNDJVcTY2cExZa1h6TG1Icm9j?= =?utf-8?B?OTlHTlpiWTc5RXZxRllRVk45UVY1UlFLdHN0am5wT05ua0ZSR2krNU56eE12?= =?utf-8?B?OHpnQ1ljMjM3MGFvZ3NhS1U4N1VYdUpDUEl6SWwvUCtIc1J4c2p5MzFkdmFG?= =?utf-8?B?amR4WnhCMmdTclJJSGJRQzY2ajI3SWRPQmc2N25qb1FDQ3dnNk96NGd6dzEv?= =?utf-8?B?WjNYV1dad2xCa3c3dmpKWC80czBTWmNNckFIRkFDV3NuS2hsYTZmQ0o0blVj?= =?utf-8?B?WGpudWgySjBpQmJkMDNrSFpIYU5USDR2ZFlwQVhxUmdQWWwyTE1JeU1SR0g0?= =?utf-8?B?Uk9QblJlSnM0RmZ3WFMvMkVsK0ZsaTJTMjluQkh1REJFUzVDcnZaaTdwc0tz?= =?utf-8?B?UVZibUMwdEhTSWJBc0JKaHQyL0xsNGNCUFRiSnB1M1o3Sk5OWDJrVlFPZUVT?= =?utf-8?B?NWk5amZSbHoyNFQ2UWhUT2NNK2lNcFpuUDIyL2JzZDBjbEovbXdzazlTTjNm?= =?utf-8?B?TEZmYUxhbEJMWXBML0xFOGRkNFBSbmJLZ2RoODM1UXNqcVcrLy9wa2doQWJz?= =?utf-8?B?WW1GZjd0a3VaZU10eUIzTDRYVFVDUjZIWjZIWmFTL3BZY0o5NWhyMk5yb21U?= =?utf-8?B?cFZ2ZVQ1U0ZVbVYyK3ZhZVJuZTR5cXBhMTV2L2pZTjNMcDFtZURadG1TcHVU?= =?utf-8?B?NDlaY3AxVWNYNDRLdzhTeVZJOUJ3dnJvaU15RGhRT1RBNzdXbGRIM1FxY2p4?= =?utf-8?B?UTdUL05XZm8rS0VHV0k1b1kwY2c0NzJ3WEhNYlNSL05XUnFXdDU5YnhnRDVJ?= =?utf-8?B?TGxjd0FabVFLUHhrSVRJZVZVM2kvM2VBTk1QR2hxSEIraXJBMnBvcXJ0bWEy?= =?utf-8?B?dnVuUmJRMjBYSVlnd2l2b3hSdHdqVmt2d093TEJkbzlUdm5JWmJkSnRvYis2?= =?utf-8?B?dWVKalZxZ29seWgydFlvYlpnaktlYUduWWgvUHVJWlNSM2xURlFVaDh0M3Bt?= =?utf-8?B?RnJrTjcwSVRwb2RacmJ4bHRXRTE1UlArYitsMjMwYzlMdE82N3l2S21WK0Zv?= =?utf-8?B?WW1DL2NyUmV2TW50VHNycEVVa0s4VlRycjk3aDllYy9qS2hiU2F1YzhMaXVa?= =?utf-8?B?Zi93Z2RnNlBDNEJvTEppY2tVTTdreUtzcjdtVEhBajFuMHZnYndtQVMzdEl0?= =?utf-8?B?UXpzam50VHNlOWFXaXFNMTM3QjN2QytYQWFYbHlBeFoyUmdQUVM3OEhTUDNz?= =?utf-8?Q?fHaBLH2/Jcefr/hIcFpnmEQ3LEXGwM/D2QrEDBe?= X-MS-Exchange-CrossTenant-Network-Message-Id: 55ba6e0d-329c-406c-9b14-08d8e3d4dd2b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 14:57:45.8299 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E1pn6HOCB1907cdgozPmy/Tzc68yk2LOdoH9MTV+SzpulwRa5M3gSEC7qR7644ea6oPXMdPeBxBnJ4ophCiW2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2777 X-OriginatorOrg: citrix.com Introduce an option to allow selecting a behavior similar to the pre Xen 4.15 one for accesses to MSRs not explicitly handled. Since commit 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly handled by Xen result in the injection of a #GP to the guest. This is a behavior change since previously a #GP was only injected if accessing the MSR on the real hardware would also trigger a #GP, or if the attempted to be set bits wouldn't match the hardware values (for PV). The reasons for not leaking hardware MSR values and injecting a #GP are fully valid, so the solution proposed here should be considered a temporary workaround until all the required MSRs are properly handled. This seems to be problematic for some guests, so introduce an option to fallback to this kind of legacy behavior without leaking the underlying MSR values to the guest. When the option is set, for both PV and HVM don't inject a #GP to the guest on MSR read if reading the underlying MSR doesn't result in a #GP, do the same for writes and simply discard the value to be written on that case. Note that for guests restored or migrated from previous Xen versions the option is enabled by default, in order to keep a compatible MSR behavior. Such compatibility is done at the libxl layer, to avoid higher-level toolstacks from having to know the details about this flag. Signed-off-by: Roger Pau Monné Acked-by: Christian Lindig Reviewed-by: Ian Jackson Reviewed-by: Andrew Cooper --- Cc: Boris Ostrovsky --- Boris, could you please test with Solaris to see if this fixes the issue? >From a release PoV there are risks of taking this patch, as it touches several different areas. So it could break MSR handling or domain creation. I think however we would be able to spot such breakages in osstest. Not taking the patch would put us in an awkward position if people migrating from < 4.15 find their guests no longer boot (or crash on migration) on newer Xen versions, hence I think we need to accept the risk. --- Changes since v3: - Slightly adjust commit message. - Change the description of the option. - s/domain_flags/misc_flags/. - Adjust setting of misc_flags in create_dom0. Changes since v2: - Apply the option to both HVM and PV guest. - Handle both reads and writes. - Rename to msr_relaxed. - Introduce a Xen commnad line option to set it for dom0. - Set it unconditionally for guests being restored or migrated from previous Xen versions. - Provide the option to dom0. - Attempt at adding the ocaml helpers (build tested only). Changes since v1: - Only apply the option to HVM guests. - Only apply the special handling to MSR reads. - Sanitize the newly introduced flags field. - Print a warning message when the option is used. --- docs/man/xl.cfg.5.pod.in | 16 ++++++++++++++++ docs/misc/xen-command-line.pandoc | 14 +++++++++++++- tools/include/libxl.h | 7 +++++++ tools/libs/light/libxl_arch.h | 5 +++++ tools/libs/light/libxl_arm.c | 6 ++++++ tools/libs/light/libxl_create.c | 7 +++++++ tools/libs/light/libxl_internal.c | 3 +++ tools/libs/light/libxl_types.idl | 2 ++ tools/libs/light/libxl_x86.c | 20 ++++++++++++++++++++ tools/ocaml/libs/xc/xenctrl.ml | 4 ++++ tools/ocaml/libs/xc/xenctrl.mli | 4 ++++ tools/ocaml/libs/xc/xenctrl_stubs.c | 9 +++++++++ tools/xl/xl_parse.c | 7 +++++++ xen/arch/x86/dom0_build.c | 3 +++ xen/arch/x86/domain.c | 9 +++++++++ xen/arch/x86/hvm/svm/svm.c | 10 ++++++++++ xen/arch/x86/hvm/vmx/vmx.c | 10 ++++++++++ xen/arch/x86/pv/emul-priv-op.c | 10 ++++++++++ xen/arch/x86/setup.c | 3 +++ xen/include/asm-x86/domain.h | 3 +++ xen/include/asm-x86/setup.h | 1 + xen/include/public/arch-x86/xen.h | 8 ++++++++ 22 files changed, 160 insertions(+), 1 deletion(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 040374dcd6..ae084252e0 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -2861,6 +2861,22 @@ No MCA capabilities in above list are enabled. =back +=item B + +The "msr_relaxed" boolean is an interim option, and defaults to false. + +In Xen 4.15, the default behaviour for unhandled MSRs has been changed, +to avoid leaking host data into guests, and to avoid breaking guest +logic which uses #GP probing to identify the availability of MSRs. + +However, this new stricter behaviour has the possibility to break +guests, and a more 4.14-like behaviour can be selected by setting this +option. + +If using this option is necessary to fix an issue, please report a bug. + +=back + =back =head1 SEE ALSO diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 4737c92bfe..a0601ff838 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -740,7 +740,7 @@ Specify the bit width of the DMA heap. ### dom0 = List of [ pv | pvh, shadow=, verbose=, - cpuid-faulting= ] + cpuid-faulting=, msr-relaxed= ] Applicability: x86 @@ -789,6 +789,18 @@ Controls for how dom0 is constructed on x86 systems. restore the pre-4.13 behaviour. If specifying `no-cpuid-faulting` fixes an issue in dom0, please report a bug. +* The `msr-relaxed` boolean is an interim option, and defaults to false. + + In Xen 4.15, the default behaviour for unhandled MSRs has been changed, + to avoid leaking host data into guests, and to avoid breaking guest + logic which uses \#GP probing to identify the availability of MSRs. + + However, this new stricter behaviour has the possibility to break + guests, and a more 4.14-like behaviour can be selected by specifying + `dom0=msr-relaxed`. + + If using this option is necessary to fix an issue, please report a bug. + ### dom0-iommu = List of [ passthrough=, strict=, map-inclusive=, map-reserved=, none ] diff --git a/tools/include/libxl.h b/tools/include/libxl.h index a7b673e89d..ae7fe27c1f 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -495,6 +495,13 @@ */ #define LIBXL_HAVE_VMTRACE_BUF_KB 1 +/* + * LIBXL_HAVE_X86_MSR_RELAXED indicates the toolstack has support for switching + * the MSR access handling in the hypervisor to relaxed mode. This is done by + * setting the libxl_domain_build_info arch_x86.msr_relaxed field. + */ +#define LIBXL_HAVE_X86_MSR_RELAXED 1 + /* * libxl ABI compatibility * diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h index c305d704b1..8527fc5c6c 100644 --- a/tools/libs/light/libxl_arch.h +++ b/tools/libs/light/libxl_arch.h @@ -85,6 +85,11 @@ int libxl__arch_extra_memory(libxl__gc *gc, const libxl_domain_build_info *info, uint64_t *out); +_hidden +void libxl__arch_update_domain_config(libxl__gc *gc, + libxl_domain_config *dst, + const libxl_domain_config *src); + #if defined(__i386__) || defined(__x86_64__) #define LAPIC_BASE_ADDRESS 0xfee00000 diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 5e2a209a8b..e2901f13b7 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -1222,6 +1222,12 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, return rc; } +void libxl__arch_update_domain_config(libxl__gc *gc, + libxl_domain_config *dst, + const libxl_domain_config *src) +{ +} + /* * Local variables: * mode: C diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index 46f68da697..1131b2a733 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -2287,6 +2287,13 @@ int libxl_domain_create_restore(libxl_ctx *ctx, libxl_domain_config *d_config, unset_disk_colo_restore(d_config); } + /* + * When restoring (either from a save file or for a migration domain) set + * the MSR relaxed mode for compatibility with older Xen versions if the + * option is not set as part of the original configuration. + */ + libxl_defbool_setdefault(&d_config->b_info.arch_x86.msr_relaxed, true); + return do_domain_create(ctx, d_config, domid, restore_fd, send_back_fd, params, ao_how, aop_console_how); } diff --git a/tools/libs/light/libxl_internal.c b/tools/libs/light/libxl_internal.c index d93a75533f..86556b6113 100644 --- a/tools/libs/light/libxl_internal.c +++ b/tools/libs/light/libxl_internal.c @@ -16,6 +16,7 @@ #include "libxl_osdeps.h" /* must come before any other headers */ #include "libxl_internal.h" +#include "libxl_arch.h" void libxl__alloc_failed(libxl_ctx *ctx, const char *func, size_t nmemb, size_t size) { @@ -594,6 +595,8 @@ void libxl__update_domain_configuration(libxl__gc *gc, /* video ram */ dst->b_info.video_memkb = src->b_info.video_memkb; + + libxl__arch_update_domain_config(gc, dst, src); } static void ev_slowlock_init_internal(libxl__ev_slowlock *lock, diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 5b85a7419f..f45adddab0 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -644,6 +644,8 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), ("vuart", libxl_vuart_type), ])), + ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), + ])), # Alternate p2m is not bound to any architecture or guest type, as it is # supported by x86 HVM and ARM support is planned. ("altp2m", libxl_altp2m_mode), diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c index 58187ed760..ac09897a63 100644 --- a/tools/libs/light/libxl_x86.c +++ b/tools/libs/light/libxl_x86.c @@ -19,6 +19,10 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, abort(); } + config->arch.misc_flags = 0; + if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed)) + config->arch.misc_flags |= XEN_X86_MSR_RELAXED; + return 0; } @@ -809,6 +813,7 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc, libxl_domain_build_info *b_info) { libxl_defbool_setdefault(&b_info->acpi, true); + libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false); } int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, @@ -851,6 +856,21 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, return rc; } +void libxl__arch_update_domain_config(libxl__gc *gc, + libxl_domain_config *dst, + const libxl_domain_config *src) +{ + /* + * Force MSR relaxed to be set (either to true or false) so it's part of + * the domain configuration when saving or performing a live-migration. + * + * Doing so allows the recovery side to figure out whether the flag should + * be set to true in order to keep backwards compatibility with already + * started domains. + */ + libxl_defbool_setdefault(&dst->b_info.arch_x86.msr_relaxed, + libxl_defbool_val(src->b_info.arch_x86.msr_relaxed)); +} /* * Local variables: diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index a02e26b27f..a5588c643f 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -48,9 +48,13 @@ type x86_arch_emulation_flags = | X86_EMU_USE_PIRQ | X86_EMU_VPCI +type x86_arch_misc_flags = + | X86_MSR_RELAXED + type xen_x86_arch_domainconfig = { emulation_flags: x86_arch_emulation_flags list; + misc_flags: x86_arch_misc_flags list; } type arch_domainconfig = diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index d2a312e273..6e94940a8a 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -42,8 +42,12 @@ type x86_arch_emulation_flags = | X86_EMU_USE_PIRQ | X86_EMU_VPCI +type x86_arch_misc_flags = + | X86_MSR_RELAXED + type xen_x86_arch_domainconfig = { emulation_flags: x86_arch_emulation_flags list; + misc_flags: x86_arch_misc_flags list; } type arch_domainconfig = diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index 9a8dbe5579..6d0d7dfd5e 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -233,6 +233,15 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config #undef VAL_EMUL_FLAGS +#define VAL_MISC_FLAGS Field(arch_domconfig, 1) + + cfg.arch.misc_flags = ocaml_list_to_c_bitmap + /* ! x86_arch_misc_flags X86_ none */ + /* ! XEN_X86_ XEN_X86_MSR_RELAXED all */ + (VAL_MISC_FLAGS); + +#undef VAL_MISC_FLAGS + #else caml_failwith("Unhandled: x86"); #endif diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 1893cfc086..9fb0791429 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2741,6 +2741,13 @@ skip_usbdev: xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat", &c_info->xend_suspend_evtchn_compat, 0); + if (!xlu_cfg_get_defbool(config, "msr_relaxed", + &b_info->arch_x86.msr_relaxed, 0)) + fprintf(stderr, + "WARNING: msr_relaxed will be removed in future versions.\n" + "If it fixes an issue you are having please report to " + "xen-devel@lists.xenproject.org.\n"); + xlu_cfg_destroy(config); } diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 0ce29e91a3..74b443e509 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -256,6 +256,7 @@ bool __initdata opt_dom0_shadow; #endif bool __initdata opt_dom0_pvh = !IS_ENABLED(CONFIG_PV); bool __initdata opt_dom0_verbose = IS_ENABLED(CONFIG_VERBOSE_DEBUG); +bool __initdata opt_dom0_msr_relaxed; static int __init parse_dom0_param(const char *s) { @@ -282,6 +283,8 @@ static int __init parse_dom0_param(const char *s) else if ( IS_ENABLED(CONFIG_PV) && (val = parse_boolean("cpuid-faulting", s, ss)) >= 0 ) opt_dom0_cpuid_faulting = val; + else if ( (val = parse_boolean("msr-relaxed", s, ss)) >= 0 ) + opt_dom0_msr_relaxed = val; else rc = -EINVAL; diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 5e3c94d3fa..b212729880 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -683,6 +683,13 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) } } + if ( config->arch.misc_flags & ~XEN_X86_MSR_RELAXED ) + { + dprintk(XENLOG_INFO, "Invalid arch misc flags %#x\n", + config->arch.misc_flags); + return -EINVAL; + } + return 0; } @@ -852,6 +859,8 @@ int arch_domain_create(struct domain *d, domain_cpu_policy_changed(d); + d->arch.msr_relaxed = config->arch.misc_flags & XEN_X86_MSR_RELAXED; + return 0; fail: diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index b819897a4a..4585efe1f8 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -1795,6 +1795,7 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) const struct domain *d = v->domain; struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; const struct nestedsvm *nsvm = &vcpu_nestedsvm(v); + uint64_t tmp; switch ( msr ) { @@ -1965,6 +1966,12 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) break; default: + if ( d->arch.msr_relaxed && !rdmsr_safe(msr, tmp) ) + { + *msr_content = 0; + break; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", msr); goto gpf; } @@ -2151,6 +2158,9 @@ static int svm_msr_write_intercept(unsigned int msr, uint64_t msr_content) break; default: + if ( d->arch.msr_relaxed && !rdmsr_safe(msr, msr_content) ) + break; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", msr, msr_content); diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index bfea1b0f8a..b52824677e 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3123,6 +3123,7 @@ static int is_last_branch_msr(u32 ecx) static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content) { struct vcpu *curr = current; + uint64_t tmp; HVM_DBG_LOG(DBG_LEVEL_MSR, "ecx=%#x", msr); @@ -3204,6 +3205,12 @@ static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content) break; } + if ( curr->domain->arch.msr_relaxed && !rdmsr_safe(msr, tmp) ) + { + *msr_content = 0; + break; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", msr); goto gp_fault; } @@ -3505,6 +3512,9 @@ static int vmx_msr_write_intercept(unsigned int msr, uint64_t msr_content) is_last_branch_msr(msr) ) break; + if ( v->domain->arch.msr_relaxed && !rdmsr_safe(msr, msr_content) ) + break; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", msr, msr_content); diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c index e5a22b9347..74e71403ff 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -875,6 +875,7 @@ static int read_msr(unsigned int reg, uint64_t *val, const struct domain *currd = curr->domain; const struct cpuid_policy *cp = currd->arch.cpuid; bool vpmu_msr = false; + uint64_t tmp; int ret; if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) @@ -986,6 +987,12 @@ static int read_msr(unsigned int reg, uint64_t *val, } /* fall through */ default: + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, tmp) ) + { + *val = 0; + return X86EMUL_OKAY; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); break; @@ -1148,6 +1155,9 @@ static int write_msr(unsigned int reg, uint64_t val, } /* fall through */ default: + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, val) ) + return X86EMUL_OKAY; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", reg, val); diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 23bbb6e8c1..68454df8ed 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -749,6 +749,9 @@ static struct domain *__init create_dom0(const module_t *image, .max_grant_frames = -1, .max_maptrack_frames = -1, .max_vcpus = dom0_max_vcpus(), + .arch = { + .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, + }, }; struct domain *d; char *cmdline; diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h index 3900d7b48b..7213d184b0 100644 --- a/xen/include/asm-x86/domain.h +++ b/xen/include/asm-x86/domain.h @@ -437,6 +437,9 @@ struct arch_domain /* Mem_access emulation control */ bool_t mem_access_emulate_each_rep; + /* Don't unconditionally inject #GP for unhandled MSRs. */ + bool msr_relaxed; + /* Emulated devices enabled bitmap. */ uint32_t emulation_flags; } __cacheline_aligned; diff --git a/xen/include/asm-x86/setup.h b/xen/include/asm-x86/setup.h index 642a5e8460..24be46115d 100644 --- a/xen/include/asm-x86/setup.h +++ b/xen/include/asm-x86/setup.h @@ -65,6 +65,7 @@ extern bool opt_dom0_shadow; extern bool opt_dom0_pvh; extern bool opt_dom0_verbose; extern bool opt_dom0_cpuid_faulting; +extern bool opt_dom0_msr_relaxed; #define max_init_domid (0) diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h index 629cb2ba40..6bf1e8cccb 100644 --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -304,6 +304,14 @@ struct xen_arch_domainconfig { XEN_X86_EMU_PIT | XEN_X86_EMU_USE_PIRQ |\ XEN_X86_EMU_VPCI) uint32_t emulation_flags; + +/* + * Select whether to use a relaxed behavior for accesses to MSRs not explicitly + * handled by Xen instead of injecting a #GP to the guest. Note this option + * doesn't allow the guest to read or write to the underlying MSR. + */ +#define XEN_X86_MSR_RELAXED (1u << 0) + uint32_t misc_flags; }; /* Location of online VCPU bitmap. */ -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 14:58:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 14:58:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96165.181700 (Exim 4.92) (envelope-from ) id 1lK0IG-0004qH-0G; Wed, 10 Mar 2021 14:58:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96165.181700; Wed, 10 Mar 2021 14:58:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0IF-0004qA-S9; Wed, 10 Mar 2021 14:58:35 +0000 Received: by outflank-mailman (input) for mailman id 96165; Wed, 10 Mar 2021 14:58:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0IE-0004q2-Fy for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 14:58:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0IC-00044f-Qy; Wed, 10 Mar 2021 14:58:32 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lK0IC-0002OO-Fo; Wed, 10 Mar 2021 14:58:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=lodQ7FG7ZXZ4/aX0c5msg2K6xV7OPC6YGi3udVI9Da8=; b=M6RZIVEsNY+4LeQi8nqbm0qlrh 45ZOro3r2r+Kc7zWzDCLXK2F1rpCd47uv+aaa6DswVFAni9+BoPeATPx7ZicMKYYQiglYFBccEJkO 4jH6K9hzDa1N097t34RLWlcvlvgephc5Tij8q7npla1caIiZt8dFGPoEZL0qUhm0wGJc=; Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu References: From: Julien Grall Message-ID: Date: Wed, 10 Mar 2021 14:58:30 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 10/03/2021 10:13, Jan Beulich wrote: > Sadly I was wrong to suggest dropping vaddrs' initializer during review > of v2 of the patch introducing this code. gcc 4.3 can't cope. What's the error? Are you sure this is not going to hiding a potential miscompilation of the function? > > Fixes: 52531c734ea1 ("xen/gnttab: Rework resource acquisition") > Signed-off-by: Jan Beulich > > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -4026,7 +4026,7 @@ int gnttab_acquire_resource( > struct grant_table *gt = d->grant_table; > unsigned int i, final_frame; > mfn_t tmp; > - void **vaddrs; > + void **vaddrs = NULL; I am a bit nervous to inialize vaddrs to NULL for a few reasons: 1) It is not 100% obvious (e.g. it takes more than a second) that vaddrs will always be initialized. 2) A compiler will not be able to help us if we are adding code without initialized vaddrs. It also feels wrong to me to try to write Xen in a way that will make a 10 years compiler happy... If we still want to support them, then maybe a better approach would be to turn off to turn off -Werror for some version of GCC. So we can continue to benefit from the newer compiler diagnostics. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 10 14:59:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 14:59:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96170.181712 (Exim 4.92) (envelope-from ) id 1lK0Iq-0004wl-AS; Wed, 10 Mar 2021 14:59:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96170.181712; Wed, 10 Mar 2021 14:59:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0Iq-0004we-7C; Wed, 10 Mar 2021 14:59:12 +0000 Received: by outflank-mailman (input) for mailman id 96170; Wed, 10 Mar 2021 14:59:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0Ip-0004wW-0I for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 14:59:11 +0000 Received: from mail-lf1-x132.google.com (unknown [2a00:1450:4864:20::132]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4d44feae-4425-4ac7-8a0f-5f1d1e5e46c2; Wed, 10 Mar 2021 14:59:09 +0000 (UTC) Received: by mail-lf1-x132.google.com with SMTP id f1so33980197lfu.3 for ; Wed, 10 Mar 2021 06:59:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d44feae-4425-4ac7-8a0f-5f1d1e5e46c2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=RnHPXeFsKxvCgCwN35Ors6JMOl6XKivOa99Ezbis3UQ=; b=Lanvzd53mKPQOpMls6hiKau62JIcL4QklOs3J15pe+scVD4BOvE0R6Z+zyJFglIOVf w1criP0LyAgEA1eOC2/8rYKgrduDfkdA76Ur95r49YZksOKvjKQGFMLa06O1iMjblN2R xr1eECGm4VbIOwZoxxH+pd87qXZGp7piV+KjD+9quxM2xVTb4WD8ZvYJBWbZ0beAKMR9 z27E+1z92gLLZh5V1oB6ULYV8TsT6rJXVQBtjRlxNM/Nt6dwQW46tMZludCS8SXkg1vl EdMykJvXWveIuUpuBHU7RS0wPisEEl38H+x3KtTmeW9Tt7Pjz4PLgz/WhfE7wkgLWZf6 dl1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=RnHPXeFsKxvCgCwN35Ors6JMOl6XKivOa99Ezbis3UQ=; b=KxxGxfmOx8hh2cix+AcJr+mp1SdW5BnWHkOeYCmd4Sl1EUo6Uon+G/+mVVoYMRQ/EU 3zzz0vFbla4XJrp9xMLpvvyn9gXPOoiLcj3IEDvG1iGW3CS97f6GCwh9BMJKvgznEmY4 OahQ/WQ9HvCDXrckPS9V4AIIpEj8oQXm91+UYjMRPSmgydm7HmjoLdCgRU6n0K297i8m MDeNQOGqF7t+EXZfNmvOja0HDXKnJ5769WjFSzfX5R3JJN1L5CHqySScByjErY/I+E9z e0CwWUn/eR+112zN/nwpIcu26d2TcjuMghuwG0xbjm3NFGP8UqE4mWghXVkhKsRxphsJ xuTQ== X-Gm-Message-State: AOAM5338K4YIBrKV4PoQ5ruPsZfBl0oWxSdOGGalnrcslc+SM7xMAGJf ID9M0q3CS/282VDgWILzSer+IBy9c26z18zEmd/MAiGs X-Google-Smtp-Source: ABdhPJzvTEGG7622oj3n4sNtIlg0+PL0BPWy2Td3hpAgEnheh/2wDSnYFmt67qGxqE+v40DWluBK3lcVltb4qaUV+Fg= X-Received: by 2002:a05:6512:3290:: with SMTP id p16mr2282139lfe.150.1615388348210; Wed, 10 Mar 2021 06:59:08 -0800 (PST) MIME-Version: 1.0 From: Jason Andryuk Date: Wed, 10 Mar 2021 09:58:57 -0500 Message-ID: Subject: xen-blkfront: BUG_ON(info->nr_rings) To: xen-devel Content-Type: text/plain; charset="UTF-8" Hi, I was running a loop of `xl block-attach ; xl block-detach` and I triggered a BUG in xen-blkfront, drivers/block/xen-blkfront.c:1917 This is BUG_ON(info->nr_rings) in negotiate_mq called by blkback_changed. I'm using Linux 5.4.103 and blktap3 on Xen 4.12 (OpenXT), though I don't think that matters. The backtrace and some preceding logs (from the reproducer) are below. I just repro-ed with this: path= xenstore-write $path 5 ; xenstore-write $path 4 info->nr_rings is still set because of the unexpected transition XenbusStateClosing -> XenbusStateConnected: dom7: [ 2866.574853] vbd vbd-51728: blkfront:blkback_changed to state 5. dom7: [ 2866.578385] vbd vbd-51728: blkfront:blkback_changed to state 4. I'm not totally sure how to handle this. The XenbusStateConnected event should be creating a new blkfront device, but instead it's seen by the old one which hasn't been cleaned up yet. After this BUG, the xenwatch thread is gone. The VM is still running, but watches aren't triggering anymore. Regards, Jason dom7: [ 2866.494691] vbd vbd-51728: blkfront:blkback_changed to state 1. tapback[27208]: backend.c:276 51728 physical_device_changed tapback[27208]: backend.c:362 51728 found tapdisk[17223], for 254:9 tapdisk[17223]: VBD 9 got disk info: sectors=147456 sector size=512, info=0 xl: [18012] libxl_disk.c:303:device_disk_add:Domain 7:device already exists in xenstore xl: [18012] libxl_device.c:1468:device_addrm_aocomplete:unable to add device dom7: [ 2866.507702] vbd vbd-51728: blkfront:blkback_changed to state 2. xl: [18022] libxl_disk.c:303:device_disk_add:Domain 7:device already exists in xenstore xl: [18026] libxl_disk.c:303:device_disk_add:Domain 7:device already exists in xenstore xl: [18024] libxl_disk.c:303:device_disk_add:Domain 7:device already exists in xenstore xl: [18022] libxl_device.c:1468:device_addrm_aocomplete:unable to add device xl: [18018] libxl_disk.c:303:device_disk_add:Domain 7:device already exists in xenstore xl: [18026] libxl_device.c:1468:device_addrm_aocomplete:unable to add device xl: [18024] libxl_device.c:1468:device_addrm_aocomplete:unable to add device xl: [18018] libxl_device.c:1468:device_addrm_aocomplete:unable to add device xl: [18038] libxl_disk.c:303:device_disk_add:Domain 7:device already exists in xenstore xl: [18034] libxl_disk.c:303:device_disk_add:Domain 7:device already exists in xenstore xl: [18038] libxl_device.c:1468:device_addrm_aocomplete:unable to add device xl: [18034] libxl_device.c:1468:device_addrm_aocomplete:unable to add device xl: [18030] libxl_disk.c:303:device_disk_add:Domain 7:device already exists in xenstore xl: [18030] libxl_device.c:1468:device_addrm_aocomplete:unable to add device tapback[27208]: frontend.c:216 51728 front-end supports persistent grants but we don't tapdisk[17223]: connecting VBD 9 domid=7, devid=51728, pool (null), evt 12, poll duration 0, poll idle threshold 0 tapdisk[17223]: ring 0x74ce10 connected dom7: [ 2866.536144] vbd vbd-51728: blkfront:blkback_changed to state 5. xl: [18020] libxl_disk.c:303:device_disk_add:Domain 7:device already exists in xenstore xl: [18016] libxl_disk.c:303:device_disk_add:Domain 7:device already exists in xenstore xl: [18020] libxl_device.c:1468:device_addrm_aocomplete:unable to add device xl: [18016] libxl_device.c:1468:device_addrm_aocomplete:unable to add device xl: [18036] libxl_disk.c:303:device_disk_add:Domain 7:device already exists in xenstore dom7: [ 2866.544439] vbd vbd-51728: blkfront:blkback_changed to state 5. xl: [18036] libxl_device.c:1468:device_addrm_aocomplete:unable to add device dom7: [ 2866.555778] vbd vbd-51728: blkfront:blkback_changed to state 5. dom7: [ 2866.565810] vbd vbd-51728: blkfront:blkback_changed to state 5. dom7: [ 2866.574853] vbd vbd-51728: blkfront:blkback_changed to state 5. dom7: [ 2866.578385] vbd vbd-51728: blkfront:blkback_changed to state 4. dom7: [ 2866.578655] ------------[ cut here ]------------ dom7: [ 2866.578662] kernel BUG at .../drivers/block/xen-blkfront.c:1917! dom7: [ 2866.578681] invalid opcode: 0000 [#1] SMP PTI dom7: [ 2866.578688] CPU: 0 PID: 76 Comm: xenwatch Tainted: G O 5.4.103 #1 dom7: [ 2866.578699] RIP: 0010:talk_to_blkback+0x7b7/0xdb0 dom7: [ 2866.578706] Code: ff ff fa ff e9 5d fb ff ff 49 8b 56 08 48 8b b3 08 01 00 00 8b 7c 24 1c e8 96 bb ff ff 85 c0 0f 84 60 ff ff ff e9 4b ff ff ff <0f> 0b 48 c7 c2 0c e7 c0 81 be f4 ff ff ff 4c 89 f7 e8 c3 ff fa ff dom7: [ 2866.578727] RSP: 0018:ffffc900004e3d80 EFLAGS: 00010202 dom7: [ 2866.578734] RAX: 0000000000000001 RBX: ffff88801df68200 RCX: 0000000000000000 dom7: [ 2866.578743] RDX: 000000000000004a RSI: ffff88801d20ab80 RDI: 0000000000000000 dom7: [ 2866.578752] RBP: ffff88801e31a800 R08: 00000000000003c6 R09: 0000000000000800 dom7: [ 2866.578761] R10: ffffc900004d3db0 R11: 00000000000002da R12: ffffffff81ea4410 dom7: [ 2866.578770] R13: dead000000000122 R14: ffff88801e31a800 R15: ffff88801df68200 dom7: [ 2866.578779] FS: 0000000000000000(0000) GS:ffff88801f200000(0000) knlGS:0000000000000000 dom7: [ 2866.578789] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 dom7: [ 2866.578797] CR2: 00007f34ade5a0d4 CR3: 000000001d0bc003 CR4: 00000000003606b0 dom7: [ 2866.578807] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 dom7: [ 2866.578815] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 dom7: [ 2866.578825] Call Trace: dom7: [ 2866.578830] blkback_changed+0x14a/0xc50 dom7: [ 2866.578836] ? find_watch+0x40/0x40 dom7: [ 2866.578841] ? xenbus_read_driver_state+0x34/0x60 dom7: [ 2866.578848] ? find_watch+0x40/0x40 dom7: [ 2866.578853] xenwatch_thread+0x97/0x160 dom7: [ 2866.578859] ? wait_woken+0x80/0x80 dom7: [ 2866.578866] kthread+0xf3/0x130 dom7: [ 2866.578871] ? kthread_create_worker_on_cpu+0x70/0x70 dom7: [ 2866.578879] ret_from_fork+0x35/0x40 dom7: [ 2866.578884] Modules linked in: xen_argo(O) dom7: [ 2866.578890] ---[ end trace 06163b0483faf9c0 ]--- dom7: [ 2866.578898] RIP: 0010:talk_to_blkback+0x7b7/0xdb0 dom7: [ 2866.586251] Code: ff ff fa ff e9 5d fb ff ff 49 8b 56 08 48 8b b3 08 01 00 00 8b 7c 24 1c e8 96 bb ff ff 85 c0 0f 84 60 ff ff ff e9 4b ff ff ff <0f> 0b 48 c7 c2 0c e7 c0 81 be f4 ff ff ff 4c 89 f7 e8 c3 ff fa ff dom7: [ 2866.586276] RSP: 0018:ffffc900004e3d80 EFLAGS: 00010202 dom7: [ 2866.586288] RAX: 0000000000000001 RBX: ffff88801df68200 RCX: 0000000000000000 dom7: [ 2866.586301] RDX: 000000000000004a RSI: ffff88801d20ab80 RDI: 0000000000000000 dom7: [ 2866.586315] RBP: ffff88801e31a800 R08: 00000000000003c6 R09: 0000000000000800 dom7: [ 2866.586325] R10: ffffc900004d3db0 R11: 00000000000002da R12: ffffffff81ea4410 dom7: [ 2866.586339] R13: dead000000000122 R14: ffff88801e31a800 R15: ffff88801df68200 dom7: [ 2866.586354] FS: 0000000000000000(0000) GS:ffff88801f200000(0000) knlGS:0000000000000000 dom7: [ 2866.586368] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 dom7: [ 2866.586376] CR2: 00007f34ade5a0d4 CR3: 000000001d0bc003 CR4: 00000000003606b0 dom7: [ 2866.586390] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 dom7: [ 2866.586404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 tapdisk[17223]: disconnecting domid=7, devid=51728 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 15:01:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 15:01:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96174.181724 (Exim 4.92) (envelope-from ) id 1lK0L5-0005oy-NU; Wed, 10 Mar 2021 15:01:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96174.181724; Wed, 10 Mar 2021 15:01:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0L5-0005or-KG; Wed, 10 Mar 2021 15:01:31 +0000 Received: by outflank-mailman (input) for mailman id 96174; Wed, 10 Mar 2021 15:01:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0L3-0005oj-Pw for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 15:01:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0L3-0004AW-OB for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 15:01:29 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lK0L3-0002ho-N5 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 15:01:29 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lK0L0-0006Un-FX; Wed, 10 Mar 2021 15:01:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=9WbyLBxF8E/8hwOBC8GujDPyHGDlHGEiaRD1z6hj8Ks=; b=mUO86Tc5nQUZwpDsGrsqGrVYHB rEUlz9wlidDQifrbRfFutMzIxTQcLIhGMg8XbEwq1Nr1m4mmR2hml5X7T24cWkhcf5hi5w+/hQ6P9 Yk9JK2/ZE1loCVsX0kYWsmkdtH8E1kGqUMqdg3jj9mmLlENS9R2XDyw9vFzckXT86eUM=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24648.57158.252811.988624@mariner.uk.xensource.com> Date: Wed, 10 Mar 2021 15:01:26 +0000 To: Roger Pau Monne Cc: , Wei Liu , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection In-Reply-To: <20210310145730.27951-1-roger.pau@citrix.com> References: <20210310145730.27951-1-roger.pau@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monne writes ("[PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection"): > Introduce an option to allow selecting a behavior similar to the pre > Xen 4.15 one for accesses to MSRs not explicitly handled. Since commit > 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly > handled by Xen result in the injection of a #GP to the guest. This > is a behavior change since previously a #GP was only injected if > accessing the MSR on the real hardware would also trigger a #GP, or if > the attempted to be set bits wouldn't match the hardware values (for > PV). The reasons for not leaking hardware MSR values and injecting a > #GP are fully valid, so the solution proposed here should be > considered a temporary workaround until all the required MSRs are > properly handled. > > This seems to be problematic for some guests, so introduce an option > to fallback to this kind of legacy behavior without leaking the > underlying MSR values to the guest. > > When the option is set, for both PV and HVM don't inject a #GP to the > guest on MSR read if reading the underlying MSR doesn't result in a > #GP, do the same for writes and simply discard the value to be written > on that case. > > Note that for guests restored or migrated from previous Xen versions > the option is enabled by default, in order to keep a compatible > MSR behavior. Such compatibility is done at the libxl layer, to avoid > higher-level toolstacks from having to know the details about this flag. > > Signed-off-by: Roger Pau Monn > Acked-by: Christian Lindig > Reviewed-by: Ian Jackson > Reviewed-by: Andrew Cooper ... > >From a release PoV there are risks of taking this patch, as it touches > several different areas. So it could break MSR handling or domain > creation. I think however we would be able to spot such breakages in > osstest. > > Not taking the patch would put us in an awkward position if people > migrating from < 4.15 find their guests no longer boot (or crash on > migration) on newer Xen versions, hence I think we need to accept the > risk. Thanks. Yes. I agree. Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Wed Mar 10 15:08:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 15:08:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96178.181736 (Exim 4.92) (envelope-from ) id 1lK0RJ-00067L-Ec; Wed, 10 Mar 2021 15:07:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96178.181736; Wed, 10 Mar 2021 15:07:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0RJ-00067E-BB; Wed, 10 Mar 2021 15:07:57 +0000 Received: by outflank-mailman (input) for mailman id 96178; Wed, 10 Mar 2021 15:07:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0RH-000679-Fy for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 15:07:55 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 86c03f93-bcd8-41c6-aa9d-e0b069cb2548; Wed, 10 Mar 2021 15:07:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86c03f93-bcd8-41c6-aa9d-e0b069cb2548 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615388874; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=H8CeaVXjAnDjHLQdGAJ2W0DeuqpxBVGQQCRcjxJ7XTI=; b=fb/Xm2JGKpTF1g0nEkqhvZ9Ca/OeSs/LAYiYTCXsX8rK7CULpBc3R8U1 Ub9S7QHFawNJ7wk8fRSoj5y0U6POOduc9ttDtf2DHyh8eVcp3qqb7/7zJ hJWof1qvN46R0DKkglwZ5oyTe4YgWcGBHXpY+qwLSVHrdpFcuuFa4opKe A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: AkBwGd5Ey2RN+frF5Iv39Nmoqw0SAZemf2wQN7ng9D2kDgNykfGlSuHHiQELjWVR6YdWX8u9UC 1mV+YXVRepoza3fpurI+augkOFMahAAmOKYps8iSa4us5G57bl8cv2MeZABTEHXDKyBVVN7KVY 5USMM9GP9KxkE+LG+QXVI94bhr78U2Hp3FyepfEO81/r8aEDT9aLsOdEDOa/HbItiic6DrDfZX DShJ0umqcPqA2TaYlB6lE3tcx+lIncH69QeQpfjQpjarDsU8YVzvkxLIN0pwFUTC1GP1GhWvrp ud0= X-SBRS: 4.0 X-MesageID: 39328629 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:/ZREaamuNTdVcEQ4QEk+Mr6Hd+fpDfPFiWdD5ilNYBxZY6Wkvu izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/4FgrU5F7GkQQXgpS+UPJhvhLGStQHINg/f0qpm1a lme7VjE9GYNykZse/W6BS1euxM/PCp66at7N2z815IbSVHL55t9B14DAHzKCxLbS1LH4AwGp bZxucvnUvWRV0tYs62BmYIUoH4zrWh/q7OWwIMBBIs9WC14w+A1biSKXel9yZbeRZ/hYwv63 HClBb0j5/Tzc2T+1v38l6W1ZVfldf6o+Eze/Cku4w0ARGpojntSahdd5e+nBYTydvfomoCoZ 3tiDNlF/s21F/rREGShnLWqkTd+Qdry1THjWWAiX/Gp8HkQT4hT/BKg5lUaHLimgIdleA58I lum1iBv55yCx7dmSjmo+fFTAtrkE2vyEBS2tI7vjhnSo0ZZ6ZWrYsDuGhcF5ANB2bG84AoHu V0Zfuslcp+QBeidHbesXBowNuwGk4rFhPDb0QessyRyVFt7QNE5npd/dcYmHgY8pI7Vt165/ /ZKOBWmKpVTskQBJgNdNspcI+MJUHmBTnNN2+TJlqPLtB9B1v976TZzZ9wyOWjeJkjxIY/lp LbQDpjxBQPUnOrM+Ki9tlm9Q3MXXWcUF3Wu7xjzqk8gJLQbv7KNjCOU18nmcfImYRiPuTrH8 ydFbgTJt2LFxqKJa95mzfQdrMXFFwlFOoSgdo/U0LmmLOzFqTa8tb1XdyWGKDgCl8fKwfCK0 pGZhffDuNa4HumX3fp6SKhI0/FSwjE8ZV8HLOyxZl19KE9crBp9iAuzXqSwOalQAcywJAeTQ 9CB5/JvryyoHW/4GrEhl8ZTiZ1PwJl6LvtVG4PiwcWP139Yd84yqCiUFEX2HOGIyl2RN/NHD heoExq+bm2I4b4/1FFN/u3dmiQj3Z7ngPCc6sh X-IronPort-AV: E=Sophos;i="5.81,237,1610427600"; d="scan'208";a="39328629" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant , Ian Jackson Subject: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API Date: Wed, 10 Mar 2021 15:07:22 +0000 Message-ID: <20210310150722.27194-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Exactly as with c/s f40e1c52e4, this is inappropriate for a stable library. That change actually broke the build with: include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t' ioservid_t *id); ^ as libxendevicemodel.h now uses a type it can't see a typedef for. However, nothing noticed because the header.chk logic is also broken (fixed subsequently). Strip the guard from the public header, and remove compensation from devicemodel's private.h. Fix the dmop design doc to discuss both reasons behind the the ABI design. Signed-off-by: Andrew Cooper Release-Acked-by: Ian Jackson --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Paul Durrant CC: Ian Jackson v2: * Patch dmop.pandoc as well. For 4.15. This is a build fix, even if current staging can't spot the breakage. These two issues highlight that libxendevcemodel.h has never been checked since its introduction, because the checking logic only saw an empty file. --- docs/designs/dmop.pandoc | 10 +++++++--- tools/libs/devicemodel/private.h | 2 -- xen/include/public/hvm/dm_op.h | 5 ----- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/docs/designs/dmop.pandoc b/docs/designs/dmop.pandoc index 8e9f95af47..336be64397 100644 --- a/docs/designs/dmop.pandoc +++ b/docs/designs/dmop.pandoc @@ -4,9 +4,13 @@ DMOP Introduction ------------ -The aim of DMOP is to prevent a compromised device model from compromising -domains other than the one it is providing emulation for (which is therefore -likely already compromised). +The DMOP hypercall has a new ABI design to solve problems in the Xen +ecosystem. First, the ABI is fully stable, to reduce the coupling between +device models and the version of Xen. + +Secondly, for device models in userspace, the ABI is designed specifically to +allow a kernel to audit the memory ranges used, without having to know the +internal structure of sub-ops. The problem occurs when you a device model issues an hypercall that includes references to user memory other than the operation structure diff --git a/tools/libs/devicemodel/private.h b/tools/libs/devicemodel/private.h index c4a225f8af..c24f3396bb 100644 --- a/tools/libs/devicemodel/private.h +++ b/tools/libs/devicemodel/private.h @@ -1,8 +1,6 @@ #ifndef XENDEVICEMODEL_PRIVATE_H #define XENDEVICEMODEL_PRIVATE_H -#define __XEN_TOOLS__ 1 - #include #include #include diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h index ef7fbc0d3d..fa3f083fed 100644 --- a/xen/include/public/hvm/dm_op.h +++ b/xen/include/public/hvm/dm_op.h @@ -25,9 +25,6 @@ #define __XEN_PUBLIC_HVM_DM_OP_H__ #include "../xen.h" - -#if defined(__XEN__) || defined(__XEN_TOOLS__) - #include "../event_channel.h" #ifndef uint64_aligned_t @@ -491,8 +488,6 @@ struct xen_dm_op { } u; }; -#endif /* __XEN__ || __XEN_TOOLS__ */ - struct xen_dm_op_buf { XEN_GUEST_HANDLE(void) h; xen_ulong_t size; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 15:15:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 15:15:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96181.181748 (Exim 4.92) (envelope-from ) id 1lK0YC-0006zH-7W; Wed, 10 Mar 2021 15:15:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96181.181748; Wed, 10 Mar 2021 15:15:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0YC-0006zA-33; Wed, 10 Mar 2021 15:15:04 +0000 Received: by outflank-mailman (input) for mailman id 96181; Wed, 10 Mar 2021 15:15:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0YB-0006z5-6k for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 15:15:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0YB-0004PV-1n for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 15:15:03 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lK0YB-0003hi-0h for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 15:15:03 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lK0Y7-0006XG-OH; Wed, 10 Mar 2021 15:14:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=udJnr+Ah07Tgqjp3r46mOigwVDrWqWV0YEwaKv/gyLk=; b=q/H1eOOqZKwMuUjCYBEdAFRcX6 LOpDA1GxKg0VoR6wxnTcPntjuR5Zuz38mmE8ZZIwRd1oIwGkXgdyIaeEBsVvYR2aJINfqQVxtdPD6 FdYh3jp5Rimat9l5cVf/HDs6K3xPT1/He/jkZw1YIEGvZDV4IujBlGvse6e2AJLZIwwY=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24648.57971.488443.593050@mariner.uk.xensource.com> Date: Wed, 10 Mar 2021 15:14:59 +0000 To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Paul Durrant Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API In-Reply-To: <20210310150722.27194-1-andrew.cooper3@citrix.com> References: <20210310150722.27194-1-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API"): > Exactly as with c/s f40e1c52e4, this is inappropriate for a stable library. > > That change actually broke the build with: > > include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t' > ioservid_t *id); > ^ > > as libxendevicemodel.h now uses a type it can't see a typedef for. However, > nothing noticed because the header.chk logic is also broken (fixed > subsequently). > > Strip the guard from the public header, and remove compensation from > devicemodel's private.h. Fix the dmop design doc to discuss both reasons > behind the the ABI design. > > Signed-off-by: Andrew Cooper > Release-Acked-by: Ian Jackson > --- > CC: Jan Beulich > CC: Roger Pau Monn > CC: Wei Liu > CC: Paul Durrant > CC: Ian Jackson > > v2: > * Patch dmop.pandoc as well. > > For 4.15. This is a build fix, even if current staging can't spot the > breakage. Release-Acked-by: Ian Jackson I am going to stop giving acks for this kind of thing fairly shorty. Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 10 15:21:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 15:21:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96186.181760 (Exim 4.92) (envelope-from ) id 1lK0eV-0007zd-18; Wed, 10 Mar 2021 15:21:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96186.181760; Wed, 10 Mar 2021 15:21:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0eU-0007zW-UQ; Wed, 10 Mar 2021 15:21:34 +0000 Received: by outflank-mailman (input) for mailman id 96186; Wed, 10 Mar 2021 15:21:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK0eT-0007yq-6T for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 15:21:33 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6d761b26-ad07-42c9-993e-186b275fdd33; Wed, 10 Mar 2021 15:21:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d761b26-ad07-42c9-993e-186b275fdd33 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615389692; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=0lw+XttI/U+q/0C1takvXkcHR/ueXJ4eOCiTQ/mA3ZM=; b=d+iAoh451IdUuw03F7MgRAO1Zr5v0mg/GyToZYo9i+ujJbtU9IfL/LTi 26zYvXuMcWylloM227gyG0cLZeeJG84vrNpxPv/Gsj8crdztKfZcoPB+N r6h2D3dsVOKRuJqNek13oa1zpGzvvuH3WkciB3tlFr7UXYGSAkyGfIGJd c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: jfqrJkF57zbpyDiou5eauw2q4i4uhyPjNG6iCKLatSD1+jkbfNCWiHrTThud5QwsNSnmPdbpKS AYnSl9xgFQYZd0maVox1zg10QgYRacV/HAod+yqjX4pMQJxzp4xCmAGMHIDvjw4Zg3DlUjqian aC/ShkaTgUqBjlw28jW4LcfE3/4ggnUT8iMwb+LqTvXz1c/XqGrLmkgf0Tksg6jhEefWoi+fsM +cF35hflepRUHIAaMiyzAPEpZjOCmFktZBze54iJBiofg7kNdh51glRxFVf7R1pncY2yE65b7e wPM= X-SBRS: 5.2 X-MesageID: 38959254 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:VKG+la1TRzd/UsZAiIG/IwqjBR13eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/BIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFmdJ1/Z xLN5JzANiYNzRHpO7n/Qi1FMshytGb8KauwdzT1WtpUBsCUcFdxi1SYzzrdXFebg9AGJY/Cd 647s1IuzKvdR0sH7qGL1MCWPXOoMCOqYnvZgQICwVixA6Fiz6p77CSKWnm4j41VTRTzbA+tV XUigCR3NTej9iX6D/5k1XS4ZNfhcf7xrJ4ZfCkp8AJJlzX+32VTat7XbnqhkFNnMiO7xIQnM DIs1McOa1Img7sV0WUhTeo5AX6yjYp7BbZuC2lqF/uu9bwSj5/K+cpv/MgTjLj50AtvM5x3c twtgrz3fcnbmKj7VDAzuPFWB1wmk2/rWBKq590s1VlXZYDc7gUlIQD/SpuYeQ9NRjn44MqGv QGNrC42N9qdzqhHhTkl1V0zMfpdno+GQrueDl5huWllxJSnHx/0nICwt0eknoq5PsGOul5zt WBHaJymL5USMgKKYp7GecaWMOyTlfAWBTWLQupUBraPZBCH0iIh4/84b0z6u3vUJsUzKEqkJ CEdF9Dr2Y9d2/nFMXm5uwLzjn9BEGGGRj9wMBX4JZ0/pfmQqDwDCGFQFcy1+O9vvQ2GKTgKr SOEaMTJ8WmAXrlGI5P0QG7cYJVM2MiXMocvct+c06So/jMNpbhuoXgAbXuDYuoNQxhdnL0A3 MFUjS2Dt5H9FqXVnjxhwWUdGjqfmD54JJsAInX9+Ue0+E2R8lxmzlQrW78ytCAKDVEvKBzVl B5OqnbnqSyonTz3Wug1RQvBjNtSmJupJnwWXJDogEHd2nud6wYhtmZcWdOmF+OJhp1SdLqAB dSzm4Hv56fHti1/2QPGtinOmWVgz84v3SRVaoRnaWF+IPDdo4nCI0lHIh8Dx/CGRAwuQsCkh YCVCY0AmvkUh/+g6Ssi5IZQMvFccNnvQutKclI7VTFtUudoskrbmABXyGnVPOWhQpGfUsQun RBt4skxJaQkzemLmUyxM4iNkdXVWiRCLVaSDieaJ5sgbDtcgFoRWKsjTiX4itDI1bCxgE3vC jMPCeUcfbEDh54tmpD2qjnyl9ya16QZll9cHx8rI17G1nXo3ob657/WoODl0+qLncSyOAUNz /IJQEfJQ5j3Pib/h+YkjTqLwRq+rweesjmSJgzebDa3X2gbLCSnaYdBvlO4dJOL9b1qNIGVu qZZi6YJD71EPkSxgSQv3opURME8EUMoLfN4lnI/WK41HkwDb7uO1xgXagcOMzZwG7+RfqEua 8Jxe4djK+VCCHWZdGHw62MMGIGBRPXvGKsT+Yn7bpTprk/sbNvH5/dFRvEvUs3qikWHYPRrg c5Rq8+3ZXqfqlIVOYWczhC/lUomM+URXFb+DDeM6sbRxUVk3TfP9m1+LLGprokP12ZqGLLSC 6i2hwY282AYjCK2rEbAZ8hOGh6aEAz73J54eOJHregQTmCRqVm/FCgNGW6f6IYYK+ZGa8Iph IS2aDFo8anMw750hvXpz11P+Zn9HumW9q7BEapFfRT+9K3fXSKja3C2r/9sB7HDR+6YV8fn4 tLaAg5adlCkCAriMkP6ReJI5aH6X4Noh95+jFollnkx4ig7iP6JCh9QHzkq6QTeyJSPHiOhd nC6s6C2h3GkWN45aU= X-IronPort-AV: E=Sophos;i="5.81,237,1610427600"; d="scan'208";a="38959254" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hhgYR3tqGq/bXzstD6SNwkGODcJNqt59pcL7uY3/QgRXu8puI8ITRtUrVHxuxfyv80GKHLmvmiM+8/sxAEmno/HWCS1NqdG7UzAi/m85lh1UyqJU5dtZr44hhVRayLy5Q064jdH0RScQDaDw4LIgSiEf7ocVJpJiaqf6oqfANSdskJDpw+og1ht6Cg4D7OXfWwo69ruD4iu6WYB+vmPFPgDj5qsOLQbglx15AWIJ2rPvJVYZ4qr/xAA224mYJKrc4C8t2eYQxRQe6VIr5bZDzy4/V7q2bSrGynXq8bTaRhpjWSrI5smd0FyHmBhu2A4qwXkRA1s5aqDUkdsEqasskQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6+eE1L6ahTfk9aniyrLBSNW88CqnafowSvsmYjkTNE=; b=oBM18A4Hn7zZtNFi5UkQdWuOSZECEkHzQxCnZkYUPEpUY4jE+a5FZe++RwKEuuMOS7MRglhrTzL/TBII5AADp/8ZEAoS+7XC/7TG0/DvP8AkexOJLkxYf+VnzTDCvuahIpturzRbP9GO/Kc9LWtHvuBxbvy3x1okPsSmBBwrVywpbJn5ARtWa7xpEgveUPLM4ZtCIF2kuFmcg4cgxOrduIJEFoGqk1v/SSoFweWsNnijyEpoIjqllYCa+gcnhmxybGE94GVCvJ4Q+ccHy6mFzdisAaCNeN70xDzeqN43LskgED63VOWF9m/7QgibuWykV4aRIQTHKUxn0gD50VPm2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6+eE1L6ahTfk9aniyrLBSNW88CqnafowSvsmYjkTNE=; b=qOsre+o0H1yV3xfVEzxmBfa1xaoAQEubnXH0aWca5oYiEwDFrY2ZjVi7EMUCwimNneo39O36awB2AqPQ0w5l33v2fFeom8NAarbPOjISy5A7tKnn3GWNWT5HjxHy6fxQqvXjQfua9mIKh6x2TNtA9GCMwEYMjFV6sUCGDBZC+10= Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API To: Ian Jackson CC: Xen-devel , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <24648.57971.488443.593050@mariner.uk.xensource.com> From: Andrew Cooper Message-ID: <04a54768-e1ae-4fc4-caf4-50327920a4e7@citrix.com> Date: Wed, 10 Mar 2021 15:20:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <24648.57971.488443.593050@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0482.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::7) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4090e78e-2ab7-417c-09f1-08d8e3d81d9f X-MS-TrafficTypeDiagnostic: BYAPR03MB3989: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5j84QCZ4VA+0iP0TLzei/W2gXdSomSemMFUvrxJJGhox4V2obO7WHKtaBFe5XePyHcE4J4xQaL1L5U7UG8SXPqJNzCh7mRbDrb6FjtJh/rQDpPXPLC7FTvFz3vOCRW+SHcwpom9h86+ScNXpK3ZPf2c2qhXsEM/dkqEip+6Zic6KpwTZqOj3rvAjf1b96WV0onQwGiyoGqLDN2mi7JUdEIuvzxhri0WFFDtdpAzFrG3b0SYCoQlvfdSxWIarz4DnWaX6vK3UNRvvYPhbc+dkXB3W4p+SdOukZ4LyWK7A4Vwfo2KzJoiM0g7C7KsAnsXEfbrfFkkmaJEOlU+EhIAxdx1jO2r6+5E4eSF0F3GSphpm9Y1oGvarqcAh0DPwFWI2zpBQM8gbtouIZPOJq1Nuhdh1avdYPMQcriDOl47tjpWerNy3DMe2aQToeokr+DnHQFN/ZZXFcXBVgWcV4Z6ttsSx0sPzweu5FesRiVsiVhWeavZLSJqr+eRCWsnv/wFZXvHtDpy/uwxKUPFeCGHoJphPJTi40DwT/zx1k3kO5ykRI3mYAnH/efoArF5UIJlTeopdQyOsx6iczZkqR66i1VvOwaP/JDC4wmBEHygYAzw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(376002)(346002)(366004)(39860400002)(6666004)(26005)(6916009)(83380400001)(31686004)(86362001)(16526019)(36756003)(478600001)(53546011)(66556008)(186003)(2906002)(956004)(66476007)(5660300002)(8676002)(2616005)(6486002)(16576012)(316002)(4326008)(66946007)(31696002)(54906003)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Wit5SlIyc1NDRE56SDhWWDZ0byt4Yitja1RONVlSTEl4MVYrYU1sYjNVSmRl?= =?utf-8?B?RjNydndNSlh5ZStRRzl3N1lEby9UVzAwa09GWUY4cTk1djRaRDJCQUc2REZs?= =?utf-8?B?YkVpYXpETU1sTERHa29tbW1UTWRCMHpRTUluN042bk9OUHcvQW5xY0lrbG8y?= =?utf-8?B?K1RORktla0d6UlYxUmVRaDVQVGc2cExkSWdNWDJvK25IeElnRkNuVUNqUWpl?= =?utf-8?B?UitHbTZKYVhFWEM2U0RaMkJSUWsvZlhXS2lXTm5VV2JDWUZMaTBkWnBhOWJE?= =?utf-8?B?eGtmTk92K3ptRzdDNmZjU2FaM24xYWp4QUJEZ0JQRy8rbGtDSDdrTEY4Uk1s?= =?utf-8?B?WXhvanBMd0R4VXd3TDdGS0I5a1JFanNFRXNwL0ZpT1lDTXNLU1RlWE91dm5M?= =?utf-8?B?YzlqTG1IVW12empwdWQyTUEzKzNjTXlPTVZaeXI2U3hRVC9oakFZekJoWDhF?= =?utf-8?B?aHN6VE05Z2VtVXlndDBYUHAvYWRrbWxnaVpESHNSSWVGRE9vWWExeWQwUTln?= =?utf-8?B?RGx4SmJWY0ZlTnhiSWE4VFM4NmE4MHlrTkV4ZldzclNXNWErZ1NLOS9mdXhz?= =?utf-8?B?SkNvbURMOHZrTnQ5Yk0zSEp0MHcrc0lMTVFmUGxuTWZXNG5pYlN1Z2dDNDZ0?= =?utf-8?B?R0E0M0dDZHFSTTBnN0FnNmNyK2FCNU9ndkl5WVRCbjI4ZE5TaXFUZXNzU3BD?= =?utf-8?B?NU1SVU5mejRhemR2aUZYY2xibXoydllha2RmYTdObDc4OHRQQWhYTnpxY1FC?= =?utf-8?B?dnFLMWxnRWw0R29tK1Qxa1V2YzZITThyMWVobk50ZUJtL2ZXSjMzeFZNTkN2?= =?utf-8?B?YUxZWFZIa0JQVGNKdFh0ak5vSFdpZ3hwK042ZHhNRENMaHQ1Y2ljNGVYSy91?= =?utf-8?B?aVFycktTb01GemQ2dE84Qmw2anN4ODlnNllXVGdmWFdPelBrUW4yaTBaY0Qw?= =?utf-8?B?UTJ1cm9YNHpRd1dZTnF6NDlPRHR4TEhjcWxzOEg3NnhUTjEzNjFLVStlS1ll?= =?utf-8?B?SllCMWFCZXl4Yk5idUtaN3NpSDZwTW01eFVBN084VzlDM2lpa3QxM3JNT2RY?= =?utf-8?B?amlLRDZRN3dGZ2NvYWE2TnFaT0pOQ2MzdUg5Mm1ScWN6eW1JcHRzNGVtT0xG?= =?utf-8?B?ajFiWmxRdHlMbDBHbUlyV0NaOEIva21oTTM1V3drTDlRTjJqTGIxMkxFd2tj?= =?utf-8?B?eUhic2M4NzlxLzZ1eGRvVTBPQ3hhKzhQeW8xN2lZazc5VG5ldE5PMjlLc1pI?= =?utf-8?B?N2ZxOTl2bnkzdTl1UjU2RXl6N3duOWlwQ242RExtdjhUanV2TnZXdi9jZE9T?= =?utf-8?B?WWlTNUtEa3RuL292S1NrVktZbEZld1FoZHJLWHBlUElEVDlVUHBVZlU0U0c4?= =?utf-8?B?UHI3dmhEbTlkVDdjc3VGcE1RSmQxL3pwdUY2R0Vwdnlpb0c4bTlyOG9ycXpr?= =?utf-8?B?Zm5RSDV6ZTRuaDY1NFFzUFMxL3dOKzFpSHUwSUlLeUhzZ0grek1sb3F2UWtI?= =?utf-8?B?YyswU2V2cy9pNklCZHRVUld5eWZ5OFhubGluZWZzYjdTVEpZb3M2VFRDVDQ2?= =?utf-8?B?UjBBS3RldXlkUDByaGd0STFoa0ZMNEMyUUpzdFVzTXZoY2xzUHdyRjlzVmNi?= =?utf-8?B?Tkh6dlh3TEpBeGtvWGdPTVNjbEVwckFZUFVWSjVyY2Q1WXJGRXRMNmk0OThm?= =?utf-8?B?VG1jeWJCdjE2Q2lmTWxPSG5jZmgyZmtsampaY2hqekxYdGZTa0RoZTBHRkVX?= =?utf-8?Q?8qMjZEr7DB868ifoGZ7O3imGOsyd1pkYDCQrbzO?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4090e78e-2ab7-417c-09f1-08d8e3d81d9f X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 15:21:02.3737 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5p86vNtVzAiuoBgS9W53RHMDtjRNR+nTrXqV9wmmlXcb31GgNb9IDT8CveCGvO30VABrJRWFFY7nYGc+bFakkJXl57fYKpoz5Z9YXoixztw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3989 X-OriginatorOrg: citrix.com On 10/03/2021 15:14, Ian Jackson wrote: > Andrew Cooper writes ("[PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API"): >> Exactly as with c/s f40e1c52e4, this is inappropriate for a stable library. >> >> That change actually broke the build with: >> >> include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t' >> ioservid_t *id); >> ^ >> >> as libxendevicemodel.h now uses a type it can't see a typedef for. However, >> nothing noticed because the header.chk logic is also broken (fixed >> subsequently). >> >> Strip the guard from the public header, and remove compensation from >> devicemodel's private.h. Fix the dmop design doc to discuss both reasons >> behind the the ABI design. >> >> Signed-off-by: Andrew Cooper >> Release-Acked-by: Ian Jackson >> --- >> CC: Jan Beulich >> CC: Roger Pau Monné >> CC: Wei Liu >> CC: Paul Durrant >> CC: Ian Jackson >> >> v2: >> * Patch dmop.pandoc as well. >> >> For 4.15. This is a build fix, even if current staging can't spot the >> breakage. > Release-Acked-by: Ian Jackson > > I am going to stop giving acks for this kind of thing fairly shorty. Thanks, but you already release acked it.  This is the requested update including the documentation change. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Mar 10 15:44:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 15:44:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96191.181778 (Exim 4.92) (envelope-from ) id 1lK10a-0001Ua-2c; Wed, 10 Mar 2021 15:44:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96191.181778; Wed, 10 Mar 2021 15:44:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK10Z-0001UT-Uv; Wed, 10 Mar 2021 15:44:23 +0000 Received: by outflank-mailman (input) for mailman id 96191; Wed, 10 Mar 2021 15:44:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK10Y-0001UO-Dn for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 15:44:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK10Y-0004rz-9q for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 15:44:22 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lK10Y-00062q-8H for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 15:44:22 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lK10U-0006bB-WE; Wed, 10 Mar 2021 15:44:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=AVawnhUgiSgn4PUQFg8OlfOcIbePn+icAYr2WAmLf4Y=; b=y46zuqSydbXM4McI9gUJ/Yj+VL GfQZkX7RqLaBExa2ukk5UI88ehsQ2degD4T10M+8XEskh6Rw5hCra11dd/qZEe5pbKh/3PoNMdDs5 nR/5ly7Zdc71wXPTgrfRBQZby96CWHYAo+7bXsC20B7Ix/ZtwX2aGjW3DW3VmFMChU5c=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24648.59730.735948.801324@mariner.uk.xensource.com> Date: Wed, 10 Mar 2021 15:44:18 +0000 To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Paul Durrant Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API In-Reply-To: <04a54768-e1ae-4fc4-caf4-50327920a4e7@citrix.com> References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <24648.57971.488443.593050@mariner.uk.xensource.com> <04a54768-e1ae-4fc4-caf4-50327920a4e7@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API"): > Thanks, but you already release acked it. This is the requested update > including the documentation change. Oh yes so I did. Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 10 16:08:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 16:08:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96195.181790 (Exim 4.92) (envelope-from ) id 1lK1NR-00042i-2o; Wed, 10 Mar 2021 16:08:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96195.181790; Wed, 10 Mar 2021 16:08:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1NQ-00042b-Un; Wed, 10 Mar 2021 16:08:00 +0000 Received: by outflank-mailman (input) for mailman id 96195; Wed, 10 Mar 2021 16:08:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1NQ-00042W-06 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:08:00 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id be99378c-3f9b-499a-8f3c-b6d5043b2106; Wed, 10 Mar 2021 16:07:59 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id E45D564F4C; Wed, 10 Mar 2021 16:07:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be99378c-3f9b-499a-8f3c-b6d5043b2106 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615392478; bh=7sTMvplzl4qRhmylBff3JMaWNZ6VDs7GHryb8IWMb8E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PIIVIbrunaUx2mEUOz6ZJxHRH1se7E+5o1HDWFnKHf8eRzIiylHjOZmg5NZShqUGW hjBa9elVXNdk4eDdsGhTeXYuzv3/BXbX9p/KFb7ybT6VG90bTEx1lnCRZOw2RFaiFz xUEZGv0mJM9hDLsvPxYJiJZDiqjW49MgbOGmc1zY8E3cbyvNj4DU6HwresgdU5wkaD /6Nzn59UjeidTCW1K7nx7/asBj1lP/sYdEKM7aFPidqM8CVyvFTnzvC3yn1XacZioJ H8pxELt905xod7Mk5tdYLPuc5q0SIB1frKl7tHHxsimgV+p7eYBm76eNyVHMHiOgX+ s9X5laJqNqC3Q== Date: Wed, 10 Mar 2021 16:07:48 +0000 From: Will Deacon To: Claire Chang Cc: Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , sstabellini@kernel.org, Robin Murphy , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan Subject: Re: [PATCH v4 13/14] dt-bindings: of: Add restricted DMA pool Message-ID: <20210310160747.GA29834@willie-the-truck> References: <20210209062131.2300005-1-tientzu@chromium.org> <20210209062131.2300005-14-tientzu@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210209062131.2300005-14-tientzu@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Hi Claire, On Tue, Feb 09, 2021 at 02:21:30PM +0800, Claire Chang wrote: > Introduce the new compatible string, restricted-dma-pool, for restricted > DMA. One can specify the address and length of the restricted DMA memory > region by restricted-dma-pool in the reserved-memory node. > > Signed-off-by: Claire Chang > --- > .../reserved-memory/reserved-memory.txt | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt > index e8d3096d922c..fc9a12c2f679 100644 > --- a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt > +++ b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt > @@ -51,6 +51,20 @@ compatible (optional) - standard definition > used as a shared pool of DMA buffers for a set of devices. It can > be used by an operating system to instantiate the necessary pool > management subsystem if necessary. > + - restricted-dma-pool: This indicates a region of memory meant to be > + used as a pool of restricted DMA buffers for a set of devices. The > + memory region would be the only region accessible to those devices. > + When using this, the no-map and reusable properties must not be set, > + so the operating system can create a virtual mapping that will be used > + for synchronization. The main purpose for restricted DMA is to > + mitigate the lack of DMA access control on systems without an IOMMU, > + which could result in the DMA accessing the system memory at > + unexpected times and/or unexpected addresses, possibly leading to data > + leakage or corruption. The feature on its own provides a basic level > + of protection against the DMA overwriting buffer contents at > + unexpected times. However, to protect against general data leakage and > + system memory corruption, the system needs to provide way to lock down > + the memory access, e.g., MPU. As far as I can tell, these pools work with both static allocations (which seem to match your use-case where firmware has preconfigured the DMA ranges) but also with dynamic allocations where a 'size' property is present instead of the 'reg' property and the kernel is responsible for allocating the reservation during boot. Am I right and, if so, is that deliberate? I ask because I think that would potentially be useful to us for the Protected KVM work, where we need to bounce virtio memory accesses via guest-determined windows because the guest memory is generally inaccessible to the host. We've been hacking this using a combination of "swiotlb=force" and set_memory_{decrypted,encrypted}() but it would be much better to leverage the stuff you have here. Also: > + > + restricted_dma_mem_reserved: restricted_dma_mem_reserved { > + compatible = "restricted-dma-pool"; > + reg = <0x50000000 0x400000>; > + }; > }; > > /* ... */ > @@ -138,4 +157,9 @@ one for multimedia processing (named multimedia-memory@77000000, 64MiB). > memory-region = <&multimedia_reserved>; > /* ... */ > }; > + > + pcie_device: pcie_device@0,0 { > + memory-region = <&restricted_dma_mem_reserved>; > + /* ... */ > + }; I find this example a bit weird, as I didn't think we usually had DT nodes for PCI devices; rather they are discovered as a result of probing config space. Is the idea that you have one reserved memory region attached to the RC and all the PCI devices below that share the region, or is there a need for a mapping mechanism? Will From xen-devel-bounces@lists.xenproject.org Wed Mar 10 16:08:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 16:08:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96197.181802 (Exim 4.92) (envelope-from ) id 1lK1Ny-00047y-Aa; Wed, 10 Mar 2021 16:08:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96197.181802; Wed, 10 Mar 2021 16:08:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1Ny-00047r-7N; Wed, 10 Mar 2021 16:08:34 +0000 Received: by outflank-mailman (input) for mailman id 96197; Wed, 10 Mar 2021 16:08:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1Nx-00047k-6y for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:08:33 +0000 Received: from mail-ed1-x534.google.com (unknown [2a00:1450:4864:20::534]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9c662e29-b27d-474e-95f8-2f16dc4e3697; Wed, 10 Mar 2021 16:08:32 +0000 (UTC) Received: by mail-ed1-x534.google.com with SMTP id h10so28880345edl.6 for ; Wed, 10 Mar 2021 08:08:32 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c662e29-b27d-474e-95f8-2f16dc4e3697 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=tQKjpBbeAGvVs6+wLD13+b80I0XRG1ErL3vCY11jAQ8=; b=fdE5vTpiprs9YgRwlunxA9uEI9O0zmGuFBxCn/Y9h/HRt6y0fhl74xYB2ZmtpNEHNT VxAsHzhVii1AMqO8frlqoZbLGCcaipV4uY9aEp7JqIlq26FHy3mUq4JH/gvGBd3q4Yr0 +WTS9QP00tSkjkXPQcvXXC1gp712WR93L2inQ9WO4BguThQpbse6wjrzs8dZxEwYOmsE NOxUaufrJdib3LkMMUAbBIdDrw7FYZ32PakrNuuXa/e0k+zvpCQvxDX26kEkt5t9J+AT LwJ+lRYYx2V1UCGdP2umMrH3g8NbqHwO1EFKxcKTHjvdK+ai5oWKbi+A/e3/bGrd9drX Hiqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tQKjpBbeAGvVs6+wLD13+b80I0XRG1ErL3vCY11jAQ8=; b=MrMRQf+SaMiSV6wm+naxrDJqgX/UGs4jpdLH5KGOxDUvkI3a+mbo4yDQCHLpONhBaY yRQj3ODqK3vDcrKCjbmlLAo6BIpIku86fErE66FUIJTc4gB46sEyPU/4shTfMUR3rI38 KvnflPObhzk5kxFZsEk9/rh/Z/bUfBh5R5gifu31UmHZp2BtaMFNMeWT9sF8YK8aSNvp VuSyaWHgSKt6pFdRw8m7vNCJaE8rJ5d4niaREt7c6QsybQAmDMPjy5p4+2jsr/OdyRu8 kzLgc+iGMk5DKe5dFFkD2pejG/cnV/asj+IsSvAB3gq+8ANCMonX+jB8yBtHzZu0evuB Zfqw== X-Gm-Message-State: AOAM532o0r8VpYGBiIcA+37Q23qX4cSbgOf5nijy+/HjvPYCXPyslPT5 eHIA1pn8bOtGhfhZop/9eH3QTywNVGOa3v1caac= X-Google-Smtp-Source: ABdhPJymb2jto6uErJnYtWurPU9cGbyu9Ua1yZmFZ3/d2gFzamREE3Ee/fVojMDSuRSGbqjKgURDFzCJyhkmYPEsreU= X-Received: by 2002:a50:fa42:: with SMTP id c2mr4195637edq.159.1615392511620; Wed, 10 Mar 2021 08:08:31 -0800 (PST) MIME-Version: 1.0 References: <20210303152948.59943-1-akihiko.odaki@gmail.com> <20210303152948.59943-2-akihiko.odaki@gmail.com> <20210310132920.6rv5f62ineowzscq@sirius.home.kraxel.org> In-Reply-To: <20210310132920.6rv5f62ineowzscq@sirius.home.kraxel.org> From: Akihiko Odaki Date: Thu, 11 Mar 2021 01:08:20 +0900 Message-ID: Subject: Re: [PATCH v2 2/2] virtio-gpu: Respect UI refresh rate for EDID To: Gerd Hoffmann Cc: qemu Developers , xen-devel@lists.xenproject.org, "Michael S . Tsirkin" , Stefano Stabellini , Anthony Perard , Paul Durrant Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2021=E5=B9=B43=E6=9C=8810=E6=97=A5(=E6=B0=B4) 22:29 Gerd Hoffmann : > > Hi, > > > -static void xenfb_update_interval(void *opaque, uint64_t interval) > > +static void xenfb_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info= ) > > > - .update_interval =3D xenfb_update_interval, > > + .ui_info =3D xenfb_ui_info, > > Hmm, I suspect xenfb really wants the actual refresh rate, even in case > vnc/sdl change it dynamically. Anthony? Stefano? > > I guess we should just leave the update_interval callback as-is, for > those who want know, and use ui_info->refresh_rate for the virtual edid > refresh rate (which may not match the actual update interval in case of > dynamic changes). Adding a comment explaining the difference to > console.h is a good idea too. sdl shortens update_interval to respond to user inputs, but it has nothing to do with frame buffer. Using ui_info->refresh_rate will eliminate worthless frame updates even for xenfb in such cases. xenfb has a behavior similar to virtio-gpu. Instead of generating interrupts, they just tell the refresh rate to the guest and expect the guest to provide a frame buffer by itself. I think the dynamic display mode change is also problematic for xenfb if the guest driver uses the information (although the Linux driver does not use it at least.) It is possible to have both of the refresh rate member in QemuUIInfo and update_interval, but I don't see a difference justifying that. Anyway, I'd also like to hear opinions from Xen developers. > > Otherwise looks good to me overall. Splitting the ui/gtk update to a > separate patch is probably a good idea. > I'll do so when submitting the next version. Regards, Akihiko Odaki From xen-devel-bounces@lists.xenproject.org Wed Mar 10 16:13:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 16:13:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96200.181814 (Exim 4.92) (envelope-from ) id 1lK1SK-00050M-UI; Wed, 10 Mar 2021 16:13:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96200.181814; Wed, 10 Mar 2021 16:13:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1SK-00050F-Pf; Wed, 10 Mar 2021 16:13:04 +0000 Received: by outflank-mailman (input) for mailman id 96200; Wed, 10 Mar 2021 16:13:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1SJ-000506-NR; Wed, 10 Mar 2021 16:13:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1SJ-0005sl-EJ; Wed, 10 Mar 2021 16:13:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1SJ-0006jQ-5M; Wed, 10 Mar 2021 16:13:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lK1SJ-0006sE-4v; Wed, 10 Mar 2021 16:13:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NPrHMb4rrflpG0S5GvyRmoqKqCxqlenW/HG8tPg0lgQ=; b=Xvj9qZ05beZFFpbQvPp6jp+2hk DL1Hk2hcF2rqPDWaQSYRAl5HdxR8JBFB28e4NZF3ELY8G05GkASqbAVB9b9AoEvod095pIGXt84PQ xUTURxm9jihW/3YJ3C3Yd2oMQatA+4F3bpdEtCN7ptF8iRFHO6iUViFoC/opICNIUcYo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159902: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=05a59d79793d482f628a31753c671f2e92178a21 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Wed, 10 Mar 2021 16:13:03 +0000 flight 159902 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159902/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux 05a59d79793d482f628a31753c671f2e92178a21 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 221 days Failing since 152366 2020-08-01 20:49:34 Z 220 days 382 attempts Testing same since 159902 2021-03-10 02:57:19 Z 0 days 1 attempts ------------------------------------------------------------ 5182 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1283745 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 10 16:15:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 16:15:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96209.181844 (Exim 4.92) (envelope-from ) id 1lK1US-0005B1-49; Wed, 10 Mar 2021 16:15:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96209.181844; Wed, 10 Mar 2021 16:15:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1UR-0005Ak-Sw; Wed, 10 Mar 2021 16:15:15 +0000 Received: by outflank-mailman (input) for mailman id 96209; Wed, 10 Mar 2021 16:15:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1UQ-00059X-Hf for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:15:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1UQ-0005wG-FN for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:15:14 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lK1UQ-0008JI-EI for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:15:14 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1lK1UO-0006gF-Od; Wed, 10 Mar 2021 16:15:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=vhXuS3XbXLBnWlFAX24yLmDEtAJAC8XTjgPOj84rBTM=; b=679iH7cwKo7MHsNGhraNhof2sr K3kEFYmTj+vOSUqvURfToErLxbiVcivDTSNps1qegmtqxz9O6M79x3OjkmjX2FSCsoFSe4neaohsl gQWvZPHCFCixu+GnqFtRneUbsVl4CSdqtLrTqgaW+LAFGXhfrqpFadYGpGZ5FLY4I4NE=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: iwj@xenproject.org Subject: [PATCH 4.15 v2 2/3] CHANGELOG.md: Add sections for 4.14 (belated) and 4.15 (prospective) Date: Wed, 10 Mar 2021 16:15:00 +0000 Message-Id: <20210310161501.13680-3-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210310161501.13680-1-iwj@xenproject.org> References: <20210310161501.13680-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit And update the release technician checklist to mention to edit it. Signed-off-by: Ian Jackson Release-Acked-by: Ian Jackson --- CHANGELOG.md | 4 +++- docs/process/release-technician-checklist.txt | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5c3d3c791d..6805f9b7d4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,9 @@ Notable changes to Xen will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) -## [Unreleased](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog) +## [4.15.0 UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.15.0) - TBD + +## [4.14.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.14.0) - 2020-07-23 ### Added - This file and MAINTAINERS entry. diff --git a/docs/process/release-technician-checklist.txt b/docs/process/release-technician-checklist.txt index 7ed2636a12..880630c1ed 100644 --- a/docs/process/release-technician-checklist.txt +++ b/docs/process/release-technician-checklist.txt @@ -56,6 +56,8 @@ t=RELEASE-$r * change SUPPORT.md heading version number; -unstable or -rc tag * (empty in stable branches after .0 release). * SUPPORT.md: insert correct version number in release-notes link +* CHANGELOG.md: set section heading to delete UNRELEASED and add date; +# in unstable branches set to X.Y.0 and RELEASE-X.YY.0 * change xen-unstable xen/Makefile XEN_EXTRAVERSION # if main version number has changed (eg 4.7 -> 4.8) rerun ./autogen.sh * rerun ./autogen.sh to update version number in configure -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 16:15:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 16:15:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96208.181834 (Exim 4.92) (envelope-from ) id 1lK1UR-0005AK-Nq; Wed, 10 Mar 2021 16:15:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96208.181834; Wed, 10 Mar 2021 16:15:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1UR-0005A8-J3; Wed, 10 Mar 2021 16:15:15 +0000 Received: by outflank-mailman (input) for mailman id 96208; Wed, 10 Mar 2021 16:15:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1UQ-00059S-9I for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:15:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1UQ-0005wD-8d for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:15:14 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lK1UQ-0008JB-7Z for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:15:14 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1lK1UO-0006gF-Fg; Wed, 10 Mar 2021 16:15:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=Xz3cxnkF07Qng2n8VUDnLR8Ky1qeiWhKzCYO1xe9ic8=; b=4w0jrIfM8g3I3iFCyocUwQq30B nGcApzBNDWd9czF4TILDfXq7ITc5rfZQ+r9efASGJCIKLSQVaiUhvnooWWEMR6SezfT1rHGlLYFm0 foygdPYX9YSGyDlT9gBM9nB8qRHtt4YBx5Oqz27oJsrQIuyDf8cEMMtP58+vRJoHqy6k=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: iwj@xenproject.org, Jan Beulich Subject: [PATCH 4.15 v2 1/3] MAINTAINERS: Make myself the owner of the changelog Date: Wed, 10 Mar 2021 16:14:59 +0000 Message-Id: <20210310161501.13680-2-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210310161501.13680-1-iwj@xenproject.org> References: <20210310161501.13680-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Ian Jackson Acked-by: Jan Beulich Release-Acked-by: Ian Jackson --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3a5c481543..6a7fa8717e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -256,7 +256,7 @@ S: Supported F: xen/drivers/passthrough/arm/smmu-v3.c Change Log -M: Paul Durrant +M: Ian Jackson R: Community Manager S: Maintained F: CHANGELOG.md -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 16:15:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 16:15:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96207.181829 (Exim 4.92) (envelope-from ) id 1lK1UR-00059o-DL; Wed, 10 Mar 2021 16:15:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96207.181829; Wed, 10 Mar 2021 16:15:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1UR-00059h-AP; Wed, 10 Mar 2021 16:15:15 +0000 Received: by outflank-mailman (input) for mailman id 96207; Wed, 10 Mar 2021 16:15:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1UQ-00059N-1d for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:15:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1UQ-0005wA-0f for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:15:14 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lK1UP-0008J1-VZ for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:15:13 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1lK1UO-0006gF-6o; Wed, 10 Mar 2021 16:15:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From; bh=nKJhwlsQyr5FIFxPgIYngPFt2WkRaA5VnrAWq3JncXQ=; b=Aku1C5M3p8wQiwt0tZEA0ssNSL g9eOIHpnacpab6zTMG8mGyxghw3Nv1oEGOsOrVcYfGqUx9PF0DvDPbCWEGxEWSUg/nL65QiqMvPnu 32r6C0Dhnc4VG8rm2a6XA20LytgNhUdXVTjSt5yJWP55oztBpIh6ieJKLYTH5llqU56I=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: iwj@xenproject.org Subject: [PATCH 4.15 v2 0/3] Start 4.15 changelog Date: Wed, 10 Mar 2021 16:14:58 +0000 Message-Id: <20210310161501.13680-1-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The administriva parts of this (1/, 2/) are a little belated. For for the substance 3/ I have information from SUPPORT.md. There is much other information to put here but right now there are several blockers in tree and I don't want to distract from fixing them. I had a look through the git logs but it's really hard to see the wood for the trees. I still intend to go and diff some docs. If anyone feels like sending me updates for CHANGELOG.md that would be welcome, but I will send out a further call for contributions later. Thanks to the reviewers of v1; I have taken those comments on board. If there are no prompt objections I will commit this shortly. Ian Jackson (3): MAINTAINERS: Make myself the owner of the changelog CHANGELOG.md: Add sections for 4.14 (belated) and 4.15 (prospective) CHANGELOG.md: Glean some information from SUPPORT.md CHANGELOG.md | 15 ++++++++++++++- MAINTAINERS | 2 +- docs/process/release-technician-checklist.txt | 2 ++ 3 files changed, 17 insertions(+), 2 deletions(-) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 16:15:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 16:15:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96210.181851 (Exim 4.92) (envelope-from ) id 1lK1US-0005Bf-DC; Wed, 10 Mar 2021 16:15:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96210.181851; Wed, 10 Mar 2021 16:15:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1US-0005BO-6g; Wed, 10 Mar 2021 16:15:16 +0000 Received: by outflank-mailman (input) for mailman id 96210; Wed, 10 Mar 2021 16:15:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1UR-00059c-0m for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:15:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1UR-0005wJ-02 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:15:15 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lK1UQ-0008JW-Tn for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:15:14 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1lK1UO-0006gF-WD; Wed, 10 Mar 2021 16:15:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=NIQS8n+dtoRd9CTPhezV8eAtZRwcQ0FPCXvOOG2r64Q=; b=haXvJxUnqJvxbiHSQ5uWSphx6p I6jFlr9/pcObEIs5X69qtuVC1drA1x6cZLMvTrnCvi376vEQTMbaNesk+1rOhSDjs5WamZkDjSwtG LqpPMWc0Nqsu0aHC2QcbWq7Xpbb3mN14udoobitu0ABNtG1ta6nk2xKmioBmmXQVugh0=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: iwj@xenproject.org Subject: [PATCH 4.15 v2 3/3] CHANGELOG.md: Glean some information from SUPPORT.md Date: Wed, 10 Mar 2021 16:15:01 +0000 Message-Id: <20210310161501.13680-4-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210310161501.13680-1-iwj@xenproject.org> References: <20210310161501.13680-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Ian Jackson Release-Acked-by: Ian Jackson --- CHANGELOG.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6805f9b7d4..c407f6bb2f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,17 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ## [4.15.0 UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.15.0) - TBD +## Added / support upgraded + - ARM IOREQ servers (device emulation etc.) (Tech Preview) + - Renesas IPMMU-VMSA (Supported, not security supported; was Tech Preview) + - ARM SMMUv3 (Tech Preview) + +## Removed / support downgraded + + - qemu-xen-traditional as host process device model, now "No security + support, not recommended". (Use as stub domain device model is still + supported - see SUPPORT.md.) + ## [4.14.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.14.0) - 2020-07-23 ### Added -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 10 16:21:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 16:21:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96221.181877 (Exim 4.92) (envelope-from ) id 1lK1aU-0006Qv-5C; Wed, 10 Mar 2021 16:21:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96221.181877; Wed, 10 Mar 2021 16:21:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1aU-0006Qo-2B; Wed, 10 Mar 2021 16:21:30 +0000 Received: by outflank-mailman (input) for mailman id 96221; Wed, 10 Mar 2021 16:21:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK1aT-0006Qj-Eo for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 16:21:29 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e4ea6028-5db0-48ac-b5aa-a7d3abd94f40; Wed, 10 Mar 2021 16:21:28 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AC800ABD7; Wed, 10 Mar 2021 16:21:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4ea6028-5db0-48ac-b5aa-a7d3abd94f40 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615393287; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0rDd9NjiUrVYIj06ZFqWVOsDKfRqoZUFPT0/awPKexs=; b=jCikWkjOwTHZQsHh0IgxMry+2R2u0Kqu7GqfUzQ9lRREukxSd2XrvIJXBCr3NhtaKJ4mbg Eb9OEYsAJU5OiJLe4QlKVH/M9/m3TNO7OLT0JDyuADvYr9acLB9wf8P6c8CluniKF+vNdR ieTDwOw8HwWW9Ky/yKKtbYDRyoh+1UA= Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning To: Julien Grall Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: From: Jan Beulich Message-ID: <6bd14438-7dec-2176-eab5-5898f190c4d8@suse.com> Date: Wed, 10 Mar 2021 17:21:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10.03.2021 15:58, Julien Grall wrote: > On 10/03/2021 10:13, Jan Beulich wrote: >> Sadly I was wrong to suggest dropping vaddrs' initializer during review >> of v2 of the patch introducing this code. gcc 4.3 can't cope. > > What's the error? The one quoted in the title. > Are you sure this is not going to hiding a potential > miscompilation of the function? Miscompilation? It may hide us screwing up, but addressing such a compiler warning by adding an initializer has been quite common in the past. >> --- a/xen/common/grant_table.c >> +++ b/xen/common/grant_table.c >> @@ -4026,7 +4026,7 @@ int gnttab_acquire_resource( >> struct grant_table *gt = d->grant_table; >> unsigned int i, final_frame; >> mfn_t tmp; >> - void **vaddrs; >> + void **vaddrs = NULL; > I am a bit nervous to inialize vaddrs to NULL for a few reasons: > 1) It is not 100% obvious (e.g. it takes more than a second) that > vaddrs will always be initialized. But convincing ourselves was necessary even more so prior to this change. We must not ever rely on the compiler to tell us about issues in our code. We can only leverage that in some cases it does. From this it (I think obviously) follows that without the initializer we're at bigger risk than with it. > 2) A compiler will not be able to help us if we are adding code > without initialized vaddrs. > > It also feels wrong to me to try to write Xen in a way that will make a > 10 years compiler happy... As said above - we've worked around limitations quite a few times in the past. This is just one more instance. > If we still want to support them, then maybe a better approach would be > to turn off to turn off -Werror for some version of GCC. So we can > continue to benefit from the newer compiler diagnostics. Avoiding use of -Werror is not an option imo: Once you start seeing warnings, you have only two options imo: Either one decides to ignore them all (and then one will also ignore new ones introduce by changes yet to be submitted), or one would have to memorize, for every build one does, which warnings one ought to ignore. The latter doesn't scale, while the former is a code quality problem. Suppressing a particular class of warning might be an option, but again risks somebody submitting code which elsewhere would trigger warnings. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 10 16:59:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 16:59:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96239.181905 (Exim 4.92) (envelope-from ) id 1lK2B5-00015R-Am; Wed, 10 Mar 2021 16:59:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96239.181905; Wed, 10 Mar 2021 16:59:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK2B5-00015K-7r; Wed, 10 Mar 2021 16:59:19 +0000 Received: by outflank-mailman (input) for mailman id 96239; Wed, 10 Mar 2021 16:59:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK2B3-00015C-JV; Wed, 10 Mar 2021 16:59:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK2B3-0006cd-DK; Wed, 10 Mar 2021 16:59:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK2B3-0000aR-6E; Wed, 10 Mar 2021 16:59:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lK2B3-0001pP-5l; Wed, 10 Mar 2021 16:59:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ao3ZJaglRCGZs6V6iNClTLctgG+lJ56dEEs2QmJmjC4=; b=pd3weM54diQeuHIPcZ5E4thcr5 J5YKr96WbSZTwPus1F3cFETtIOfF8cUA8UOmgQhiWV6RtAUsL6PQ9Df8eTOCAZs6503FRDmYeNhW6 ThqFoTAiYNT5rGaUpahvKM99yjB/Ghu4C8oYgdSTf1IzlhfniqWsNcvB1DPNEhHlwaCw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159913: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4e01c48886d9fbfee3bf7e481c4529a176331c78 X-Osstest-Versions-That: xen=1b47cc852fd130ed9ce274a0f1600a4a62949a2c From: osstest service owner Date: Wed, 10 Mar 2021 16:59:17 +0000 flight 159913 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159913/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 4e01c48886d9fbfee3bf7e481c4529a176331c78 baseline version: xen 1b47cc852fd130ed9ce274a0f1600a4a62949a2c Last test of basis 159895 2021-03-09 18:00:28 Z 0 days Testing same since 159913 2021-03-10 14:01:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Roger Pau Monne Roger Pau Monné Wei Liu jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 1b47cc852f..4e01c48886 4e01c48886d9fbfee3bf7e481c4529a176331c78 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Mar 10 17:12:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 17:12:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96245.181920 (Exim 4.92) (envelope-from ) id 1lK2Nz-0002qe-GF; Wed, 10 Mar 2021 17:12:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96245.181920; Wed, 10 Mar 2021 17:12:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK2Nz-0002qX-DP; Wed, 10 Mar 2021 17:12:39 +0000 Received: by outflank-mailman (input) for mailman id 96245; Wed, 10 Mar 2021 17:12:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK2Ny-0002qS-8X for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 17:12:38 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b8e76a40-81e8-48b6-9d93-cef0884f7937; Wed, 10 Mar 2021 17:12:36 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 20B58AC54; Wed, 10 Mar 2021 17:12:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8e76a40-81e8-48b6-9d93-cef0884f7937 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615396356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LJ10Uz/5yn3L9VteC18A49vsRnOB2Ev+jQnifQHtANw=; b=D/K91msTtePq9f8rqsiwlrcxcK0KfuG4nf2tLiZpYlulZazpJCgHRx7T3jFMBAtvejBTnG ESme52DJvWCaT9MHFmIqCsdxquM7Bwkk6QwWg1HlXTXPBATHUSZChTkzrEDrTj/rSjFpMc GlmTwR2TAvkNRMe4iokr97As0Efp8uw= Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API To: Andrew Cooper , Paul Durrant Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , Xen-devel References: <20210310150722.27194-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 10 Mar 2021 18:12:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210310150722.27194-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10.03.2021 16:07, Andrew Cooper wrote: > --- a/docs/designs/dmop.pandoc > +++ b/docs/designs/dmop.pandoc > @@ -4,9 +4,13 @@ DMOP > Introduction > ------------ > > -The aim of DMOP is to prevent a compromised device model from compromising > -domains other than the one it is providing emulation for (which is therefore > -likely already compromised). > +The DMOP hypercall has a new ABI design to solve problems in the Xen > +ecosystem. First, the ABI is fully stable, to reduce the coupling between > +device models and the version of Xen. > + > +Secondly, for device models in userspace, the ABI is designed specifically to > +allow a kernel to audit the memory ranges used, without having to know the > +internal structure of sub-ops. I appreciate the editing, but the cited points still don't justify ... > --- a/xen/include/public/hvm/dm_op.h > +++ b/xen/include/public/hvm/dm_op.h > @@ -25,9 +25,6 @@ > #define __XEN_PUBLIC_HVM_DM_OP_H__ > > #include "../xen.h" > - > -#if defined(__XEN__) || defined(__XEN_TOOLS__) > - > #include "../event_channel.h" > > #ifndef uint64_aligned_t > @@ -491,8 +488,6 @@ struct xen_dm_op { > } u; > }; > > -#endif /* __XEN__ || __XEN_TOOLS__ */ > - > struct xen_dm_op_buf { > XEN_GUEST_HANDLE(void) h; > xen_ulong_t size; ... this removal: What the kernel needs for its auditing (your 2nd point) is already outside of this guarded region, as you can see from the context above. You said there was a design goal of allowing use of this interface by (and not only through) the kernel, e.g. by a kernel module (which I don't think you mean to be covered by "device models"). If that was indeed a goal (Paul - can you confirm this?), this would now want listing as a 3rd item. Without such a statement I'd call it a bug to not have the guards there, and hence might either feel tempted myself to add them back at some point, or would ack a patch doing so. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 10 17:23:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 17:23:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96248.181932 (Exim 4.92) (envelope-from ) id 1lK2Xz-0003qF-Fu; Wed, 10 Mar 2021 17:22:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96248.181932; Wed, 10 Mar 2021 17:22:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK2Xz-0003q8-CQ; Wed, 10 Mar 2021 17:22:59 +0000 Received: by outflank-mailman (input) for mailman id 96248; Wed, 10 Mar 2021 17:22:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK2Xx-0003q3-MJ for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 17:22:58 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e06170f8-9259-465f-8aec-b8e177fd0506; Wed, 10 Mar 2021 17:22:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e06170f8-9259-465f-8aec-b8e177fd0506 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615396975; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=nmT3VUh7L4Teyfr7uPRZ6ajvRBFgRjJ4Sy+i+B2Tc+M=; b=HOpM9fPoP+hdblb3adlaJiU0T8BofuCHFOZJfkJlSm1gKIk8+mGVWGi2 HPG+nA6b0UNx8xE21W+xzDh9M0slj9BypquU13JkRY8RLM9e74rdk0iLu tAfWfRFHpeCsWOlbmJMFlQwkD0ku4DYh4XawcB6O5An29q7FOkynQnD4i 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: /mNcPxlxtqBGbbq4mEkC1hXStTRa5vploDomN314OkC5ssLJmdkV9I18TY13BXMzr0tJdZxG1E bwV1Y3ImbBIOP9AZkCFSp1F4S39ks0bLD0jsYeR0DnhDrnCi2Y0C+DXk1O94w8tuRPSkDn73+/ uIT3u4a2Njlql89vQ0g8gVY3U3Yib6waSjhdqLWIirgIjtAbCqTbqg092/kKPhZ3rmY3MjL/HV XAuqka13+IekiWj76hST92V7WjUDG/L8E2WGCN5KK98KImj/OpLWEtRHHii6znT+afNI4Px2uL 21w= X-SBRS: 5.2 X-MesageID: 38973377 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:ZwijdKjIa7GqMkM/c1cRYIkaknBQXwB13DAbvn1ZSRFFG/Gwv9 yynfgdyB//gCsQXnZlotybJKycWxrnmKJdy48XILukQU3aqHKlRbsSiLfK7h/BP2nF9uBb3b p9aKQWMrfNJHVzkMqS2maFOvk6xt3vys6VrMP/61socg1wcaFn6G5Ce2SmO2l7XhNPC5Z8NL f03Kp6jgGtc3gWcci3b0NtN4T+jubGiY78Zlo+DwMngTPksRqT9LX4HxKEty1uMA9n/LFKyw n4uj283IqPmbWRyhjQ12jchq4m4ufJ+594K+GnzuQQIjXooA60aIpmQK3qhkFJnMifrGwEvf OJjxA8P9liy365RBDInTLdnzPO/Rxry3j+xUSWiXHuyPaJOw4SOo56qq9yNj76gnBQ2O1U4e Zw8E+y86dzN1fmmh/w4tDZPisa7nackD4ZvsM4y0BEXZB2Us43kaUvuHl7Pb0nByzA5IUuAI BVfbrhzccTS1+cYnzD11MfpuCEbzA2FheCdEAIptaY5ThQhGx41EsV3qUk7w49yK4= X-IronPort-AV: E=Sophos;i="5.81,237,1610427600"; d="scan'208";a="38973377" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fO5rKa0x1EfYYttfR/akf7wHqFFx8KjLaUP0FtpFmBpvUywGyFXoAlMTs2xGNcsd+WtyscHt2OgVqF4IkSXS6B2zMUI9G5p8zANGNhjdUO/OregpM7Z7/ja9DvEHy2CyHqytWEyJ/OOEj/5dqb/yn9mSHIyULbGpI6ulRTcb377Ycjkcmt8AFcEY60nbUQbbuowsHPGn7Dhz9UuwOTS+ko2X1dJZ1xnraMolKtsTqF/JPB6uHzDLaUCasSuFojKogva+1NpGDCosPO//vlzYZsS72cry1JmoPTQMBKNNwAeEC/cfZkVzvslIh8MIombbFaVvW/27lIyjXh/rq9GIww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l/GN8YxH78Q+enrgfjv7pEctB1xoozBobcdx1vlh3ek=; b=NivRnMVQN9qfn8SjAw32HT1vwAtZ62zbl3qbvARtKr6NAcY5wQ6+MKJOjF8hGAxNOptLvdnU8HAPxtEAKdTnyuo2YQGMDjYjiUZNnoYJWIEGKvThB3HvpWw1UB9iHz2hwUgQwkqsZm2r+NK+EPSWTPq2BJJge8frPla9vtdpHXuzDcO50Gta1Kjy/xQgJ4PDcDnw7oclNx7u/UK5YVRCleKWyIG5tO0dopVzIrqhItI0LE0y6+E2EG5lJke/mbcLIWDlznj6QH8HXo8pjx13HGn4Cj9Evghgb/fmTtNKkE9PNtOaxQBhOcFc69aBbH5nw9odJZpN7KoNPcI3rlOM8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l/GN8YxH78Q+enrgfjv7pEctB1xoozBobcdx1vlh3ek=; b=QhqMQSJVsQEzRKIgM/QWLgdT2VV7JAi3jysp7Aj8lUWrIijAQwPBXwtCslYlnkGjdMoMFXq4/4DEaRu3OOpC2a01gwTh3fJsNq0xHI1R6W4Kg/woCTl0OMno4vqJ5FfxChlFpHlLCWrf3JYD8tyyKN+cNVBjTsoo5wRj2tFYpvs= To: Jan Beulich , Paul Durrant CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , Xen-devel References: <20210310150722.27194-1-andrew.cooper3@citrix.com> From: Andrew Cooper Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API Message-ID: <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> Date: Wed, 10 Mar 2021 17:22:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0322.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 204347ee-6aee-4e35-e791-08d8e3e91fc4 X-MS-TrafficTypeDiagnostic: BYAPR03MB3797: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KsIMEIexpmZBhSkdXBdFSa0OjpfcZWcirfW6teuHrMz1Zg6bpv3ZQN7GQhTMyMmYB+p3Cb6PCSa0kOguVHvbg0qgQ2K4RdtpbjMfh0l9vj2NsxilM5zpGzD53rrpfi9rbExQzSWLENXH13C80do3HMn64N/uvONh6Jlb5fotWh9zjXuh5tJAmwB8sPm4XZDxfeqHurmGp+dbiLl6INMtaJVvDEy9AnUPUYQhUNZH7+o/QpEIxCOSZ7BtWcWKRhaNsTjKooLt3l6GfqRnt4XmNL1aF6gJu+by9fITpXhCdi9TxW/zbJn3S0dtiQT/c0S4lyABbHx310LAACsbyw6x73nWsza58ZKqTHaMgTcgn634v4cp+1aiwtCHDIrFIPOV9Dfn5/V4YPTSwZzo476p5C34xQLHPLU5UCjvR/2gXfQHK6JwpMmVtbYoyKN/x6FR/6FSY6QC/9Dqo/6MycmPNhnBileh1PKbmDWhE5WTaRZsuEt86ae9fqvRzk1fvVZdopYzgHessDtMQfZZg07m/uNXI1YnK1bJL5C7g1W2JULUl4kksHs7txPErn4ioW8XD+aVN3EYA66LZuYYJMs93ocF5Jp1Cz0hwH0GQ1uIRIQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39860400002)(396003)(366004)(136003)(376002)(53546011)(110136005)(26005)(2616005)(66946007)(66476007)(956004)(2906002)(16526019)(6666004)(186003)(5660300002)(478600001)(54906003)(16576012)(83380400001)(31696002)(86362001)(316002)(31686004)(8936002)(8676002)(4326008)(36756003)(6486002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?V1pEVVhCdkwza0pHaFVqV0VxbVkzRUI0dysxSVkvcE12YVZtSmQ4ZytyODdo?= =?utf-8?B?YlpPMWFMcmxjd0JKNnhlMmN1enZMUElqUldMN0tFY3lRS1NXN2tCaVArU3Jh?= =?utf-8?B?b2lqVDlnYkNFOUl6dlYybFhla3loSHZlM0hTbW5WYnl4NnZrYU1wZDVSUVhT?= =?utf-8?B?VWtXTzVMTzRIZUZLZzM1dWRjMDArZVVIdnNkdE43eW92Z3pndHc0RlIxQkkz?= =?utf-8?B?OEV2WFdXRkplZHo4RGN2dkVwbEd6azBQWWNndVdHaUpCMFVHSzJIM0FQNmlX?= =?utf-8?B?Skk2SE83Z05xSjlkeWIxSnowY0YyUVorS2tYbThJc1BZMmZZZjJidmxGWTh0?= =?utf-8?B?V0U4alZQQzZZRWxFTW1aaGdDTERpd0dOQ1RoWGF6bkQ3S2FrcFRpRG5udDRo?= =?utf-8?B?V2ZLdURTYWxWTlNBU3IxT3d5M1ZjZTR3TTZrc3dmTnVrU01ZZFRrcE1tb0Iw?= =?utf-8?B?d3dsbmVSZzNscU9IN25lbHplTDFVdkRXQkU2cE51Znl5bVNiOXdtYS9OVlNH?= =?utf-8?B?UjdBRndnZ0k5aTZwT2cvVUgwa0p3Ym5mUW01WjNldGRpc0lBbExmYVphNkJy?= =?utf-8?B?VHZDSFZzdmdPOXc2M3V3WlIrQ1JJOS81dVRrQkxsRVlJNVF6TGh1ZVpHWmNQ?= =?utf-8?B?TGh4bmgrcWRybFBkN3RYV244VnV1K3dGYzE0VG5YRUVGa3JNRFlZZlFGaXQx?= =?utf-8?B?WUY4M1o0ejBua0RqenVVTjZVRVJWZ3NHWDNzbFg1SUZySlI5cnZ0a3JSRWtW?= =?utf-8?B?cVJid2RQN2hLK0pFRGhCQk1XMnBIanExSDY0a1NFNmpTZFJ1Qm93ZTRKdEov?= =?utf-8?B?V0ZlcVNJT1g4dXFYakpDUXhWM3hrdDFmMnJhNkNFZFdZcjNkRWd1RXNpQXQx?= =?utf-8?B?MWE1OFExR2psdDJ6bFY0SklLQ1dHQkR1YWRmUXJ2Y2NLVlFKdWgrYk10bWhU?= =?utf-8?B?d1pEZ0ZlN1JVQ1VITlh4N0RMQytLbDFoOUpON2ZmQ0dmc09IL1M1bkNwaXJL?= =?utf-8?B?c2ZzYi8zRVN6WmpISkJ4ems2SlJycGpDTmE3S0Y2dVBoQU0yOUZlVk9TdmZG?= =?utf-8?B?bEVBRmZkYUxuSkI5WFRtN1BQQWQyQzJNM1NKRkgwa3B5N0pRaHlPcGIzREJ6?= =?utf-8?B?c203Ym9XQWRJbDc2NTlEODNwSVNYK0xSeFB2cHk4ME1zVW1Zd0J0NTBVUVNF?= =?utf-8?B?cnRQQ1dndExGaGM1aURVUGZEbFpyeDJWR09jT05tWVU5eG9zaDJVZkduMGVp?= =?utf-8?B?NmViNXlEd2VweHI0WU1GMWlTSkxYRURERFFINGVPZDcyZjJtY3p5ckRYL3VG?= =?utf-8?B?aEp5dTZFQ3RBdTRIeXIrMi9YVFVuMU1Za1I5RGlhS3JjK0xCSmF6TUF1RmIz?= =?utf-8?B?Tmo2UkV4QTBjczRXQTloRGRSd21mRHhwUmlNVVRJWTd3WXJQc3lWdXJxVWpX?= =?utf-8?B?SFFTYzcrUllNR05tT0pGdW4yanhGc3BMWDMzNzZtMVMyaksvVlVEVlJlNWp1?= =?utf-8?B?M09ETEU2SExBRVdPait1dFNSVGxqVDVaaU5hVUd1TXVMVlJ1Nzhmc080Tisz?= =?utf-8?B?SzYrMmhMMURTZ2FLZEUycXB5ZFZiTU8wYjJ3aWg1eXNjZHZXVGs0QXJEcm1s?= =?utf-8?B?WkZnaDRIYXRlOVNVdHp1MUhpT0NnZXJ5ZVBjaVJxNWtVSWJia08rL0FOYU5a?= =?utf-8?B?V3g4bjNlU0RQcmxCejJabnBaQXl2T0ZLMmtKOG4vVjczeUNUV2M1TWJ6TERS?= =?utf-8?Q?cfqDooJK4YWqmGBrVMHqcNHN2PGMDXKMKsjnxew?= X-MS-Exchange-CrossTenant-Network-Message-Id: 204347ee-6aee-4e35-e791-08d8e3e91fc4 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 17:22:47.6995 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QsTBeRonP7LjqxjhKtimxfDBnKjdnCRkaOmXy1kQcYD+/5+o89+WGOeJbbi/c1MX6TK4gJi8Cx5G8B3jSInVPmYcu3akjVI06VqnCVltUbw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3797 X-OriginatorOrg: citrix.com On 10/03/2021 17:12, Jan Beulich wrote: > On 10.03.2021 16:07, Andrew Cooper wrote: >> --- a/docs/designs/dmop.pandoc >> +++ b/docs/designs/dmop.pandoc >> @@ -4,9 +4,13 @@ DMOP >> Introduction >> ------------ >> =20 >> -The aim of DMOP is to prevent a compromised device model from compromis= ing >> -domains other than the one it is providing emulation for (which is ther= efore >> -likely already compromised). >> +The DMOP hypercall has a new ABI design to solve problems in the Xen >> +ecosystem. First, the ABI is fully stable, to reduce the coupling betw= een >> +device models and the version of Xen. >> + >> +Secondly, for device models in userspace, the ABI is designed specifica= lly to >> +allow a kernel to audit the memory ranges used, without having to know = the >> +internal structure of sub-ops. > I appreciate the editing, but the cited points still don't justify ... > >> --- a/xen/include/public/hvm/dm_op.h >> +++ b/xen/include/public/hvm/dm_op.h >> @@ -25,9 +25,6 @@ >> #define __XEN_PUBLIC_HVM_DM_OP_H__ >> =20 >> #include "../xen.h" >> - >> -#if defined(__XEN__) || defined(__XEN_TOOLS__) >> - >> #include "../event_channel.h" >> =20 >> #ifndef uint64_aligned_t >> @@ -491,8 +488,6 @@ struct xen_dm_op { >> } u; >> }; >> =20 >> -#endif /* __XEN__ || __XEN_TOOLS__ */ >> - >> struct xen_dm_op_buf { >> XEN_GUEST_HANDLE(void) h; >> xen_ulong_t size; > ... this removal: What the kernel needs for its auditing (your 2nd > point) is already outside of this guarded region, as you can see > from the context above. You said there was a design goal of allowing > use of this interface by (and not only through) the kernel, e.g. by > a kernel module (which I don't think you mean to be covered by > "device models"). If that was indeed a goal (Paul - can you confirm > this?), this would now want listing as a 3rd item. Without such a > statement I'd call it a bug to not have the guards there, and hence > might either feel tempted myself to add them back at some point, or > would ack a patch doing so. Xen has absolutely no business dictating stuff like this.=C2=A0 It is an internal and opaque property of the domain if the hypercalls happen to originate from logic in user mode or kernel mode.=C2=A0 Stubdomains would fall into the same "kernel" category as xengt in the dom0 i915 driver. However, the actual bug I'm trying to fix with this is the need for userspace, which doesn't link against libxc, to do #define __XEN_TOOLS__ #include to be able to use the libxendevicemodel stable library. The __XEN_TOOLS__ guard is buggy even ignoring the kernel device model aspect. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Mar 10 17:52:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 17:52:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96253.181944 (Exim 4.92) (envelope-from ) id 1lK30o-0006cZ-3d; Wed, 10 Mar 2021 17:52:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96253.181944; Wed, 10 Mar 2021 17:52:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK30o-0006cS-0C; Wed, 10 Mar 2021 17:52:46 +0000 Received: by outflank-mailman (input) for mailman id 96253; Wed, 10 Mar 2021 17:52:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK30m-0006cN-QW for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 17:52:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK30l-0007V9-Ln; Wed, 10 Mar 2021 17:52:43 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lK30l-0002Ey-CY; Wed, 10 Mar 2021 17:52:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Y+Jnnzkn2oABqEgNjtJPldwx3KVGV20n3G6bUgGAgJg=; b=pEloDGqOpsKLUeysr04r4Z0L1u 88eDOgabPg7LxJuwaVwKtiIlU+R7bmd0vXL/2lrKlyWc9cjUcycexjEsInYfLhuFZEbVS5ovguQRV 6Bt+uXSvJk9M1OOhSkN4tXTNfx23EMyVmM2Nj3hxCCbVYtneBcenBOA4EjKLnzKuAhds=; Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <6bd14438-7dec-2176-eab5-5898f190c4d8@suse.com> From: Julien Grall Message-ID: Date: Wed, 10 Mar 2021 17:52:41 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <6bd14438-7dec-2176-eab5-5898f190c4d8@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 10/03/2021 16:21, Jan Beulich wrote: > On 10.03.2021 15:58, Julien Grall wrote: >> On 10/03/2021 10:13, Jan Beulich wrote: >>> Sadly I was wrong to suggest dropping vaddrs' initializer during review >>> of v2 of the patch introducing this code. gcc 4.3 can't cope. >> >> What's the error? > > The one quoted in the title. > >> Are you sure this is not going to hiding a potential >> miscompilation of the function? > > Miscompilation? It may hide us screwing up, but addressing such a > compiler warning by adding an initializer has been quite common > in the past. Well... When a compiler tells me a value may be unitialized, I read it as some optimization may decide to use the variable in a way I wasn't expected. >>> --- a/xen/common/grant_table.c >>> +++ b/xen/common/grant_table.c >>> @@ -4026,7 +4026,7 @@ int gnttab_acquire_resource( >>> struct grant_table *gt = d->grant_table; >>> unsigned int i, final_frame; >>> mfn_t tmp; >>> - void **vaddrs; >>> + void **vaddrs = NULL; >> I am a bit nervous to inialize vaddrs to NULL for a few reasons: >> 1) It is not 100% obvious (e.g. it takes more than a second) that >> vaddrs will always be initialized. > > But convincing ourselves was necessary even more so prior to this > change. We must not ever rely on the compiler to tell us about > issues in our code. We can only leverage that in some cases it > does. I didn't suggest that we should only rely on the compiler. I pointed out that we are telling the compiler to not worry. This may hide a valid concern from the compiler. > From this it (I think obviously) follows that without the > initializer we're at bigger risk than with it. I thought deferencing a NULL pointer was still a concern for PV? For the other setup, I agree that it would only lead to a crash rather than dereferencing anything. Yet I am not convinced this is that much better... >> 2) A compiler will not be able to help us if we are adding code >> without initialized vaddrs. >> >> It also feels wrong to me to try to write Xen in a way that will make a >> 10 years compiler happy... > > As said above - we've worked around limitations quite a few times > in the past. This is just one more instance. I find amusing you wrote that when you complained multiple time when someone was re-using existing bad pattern. :) > >> If we still want to support them, then maybe a better approach would be >> to turn off to turn off -Werror for some version of GCC. So we can >> continue to benefit from the newer compiler diagnostics. > > Avoiding use of -Werror is not an option imo: Once you start seeing > warnings, you have only two options imo: Either one decides to ignore > them all (and then one will also ignore new ones introduce by changes > yet to be submitted), or one would have to memorize, for every build > one does, which warnings one ought to ignore. The latter doesn't > scale, while the former is a code quality problem. > > Suppressing a particular class of warning might be an option, but > again risks somebody submitting code which elsewhere would trigger > warnings. This is pretty much what we are already doing slowly by initializing values to shut up older compilers. I agree this is more limited, but we also waive off diagnostics from every single compiler in that code rather than just one version. Hence why I suggested dropping -Werror for older compiler. This is not ideal but it would give us the ability to keep support for dinausor compiler and not hamper our ability to take advantage of newer compiler diagnostics. The ideal solution is to drop support for older compiler (see my other thread). But this sounds like a daunting task so far on x86... Anyway, I will not Nack the patch but will also not Ack it. I will let another maintainer ack this patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 10 18:05:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 18:05:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96257.181962 (Exim 4.92) (envelope-from ) id 1lK3DG-0007kL-C9; Wed, 10 Mar 2021 18:05:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96257.181962; Wed, 10 Mar 2021 18:05:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK3DG-0007kE-8n; Wed, 10 Mar 2021 18:05:38 +0000 Received: by outflank-mailman (input) for mailman id 96257; Wed, 10 Mar 2021 18:05:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK3DF-0007k9-E5 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 18:05:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK3DE-0007on-5q; Wed, 10 Mar 2021 18:05:36 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lK3DD-00038u-SF; Wed, 10 Mar 2021 18:05:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=rVBK4deqEcBvSLxBe5QpT9AXxRZruW155bQgWbiYJdc=; b=OFFWacnzMFi1Wx1arQHOfS5HXh egpK2GP75hpIBC8nyMgNbrK/4IpUQHkUJ3o88oiyTzzALu+y5omocn9jPQeqUjCkAfPnSKhvH/m9x 7s3YCpaf6uqg7a/TVqA6Gywppl5RecNtWMxA7wtnTv2bScLZsXwiaAXZbHFGwfHmjJr0=; Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) To: Jan Beulich Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210306214148.27021-1-julien@xen.org> <1897022d-7591-3450-4e57-884a2860b13d@suse.com> <7fd07dc9-9c03-bb13-3907-c3c268a4e970@xen.org> <2de5160f-8636-5cdf-a20c-acaa2640c893@suse.com> From: Julien Grall Message-ID: <7ab87cab-8836-e8a0-993e-0cdeca3c45e3@xen.org> Date: Wed, 10 Mar 2021 18:05:34 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 09/03/2021 11:20, Jan Beulich wrote: > On 08.03.2021 21:22, Julien Grall wrote: >> On 08/03/2021 11:20, Jan Beulich wrote: >>> On 08.03.2021 11:51, Julien Grall wrote: >>>> On 08/03/2021 08:09, Jan Beulich wrote: >>>>> Additionally - partly related to your own reply regarding the CI >>>>> failures - imo there needs to be an analysis of what older distros >>>>> will no longer build (at all or by default). >>>> >>>> Per the CI, this would be Ubuntu Trusty (and older), Centos 7 (and older) >>>> >>>> Do you have any other in mind? >>> >>> Our SLE12 (latest service pack is SP5 and still has a while to go >>> to at least reach LTSS state) comes with gcc 4.8 as the default >>> compiler. >> >> Thanks! That's good to know. Is it the old GCC Suse supports? > > Not sure I understand the question: The default compiler of this or > any distro is of course (expected to be) supported by the vendor > for the lifetime of the OS. Sorry for the wording. I was asking whether Suse also supports compiler older than GCC 4.8. > >>>>>> --- a/xen/include/xen/compiler.h >>>>>> +++ b/xen/include/xen/compiler.h >>>>>> @@ -5,6 +5,19 @@ >>>>>> #error Sorry, your compiler is too old/not recognized. >>>>>> #endif >>>>>> >>>>>> +#if CONFIG_CC_IS_GCC >>>>>> +# if CONFIG_GCC_VERSION < 40900 >>>>>> +/* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ >>>>> >>>>> As per the bug report, the issue was determined to not be present >>>>> in e.g. 4.3. Hence while such a bug may influence our choice of >>>>> minimum version, I don't think it can reasonably be named here as >>>>> the apparent only reason for the choice. Personally I don't think >>>>> any justification should be put here. >>>> >>>> Ok. >>>> >>>>> >>>>>> +# error Sorry, your version of GCC is too old - please use 4.9 or newer. >>>>>> +# elif defined(CONFIG_ARM_64) && CONFIG_GCC_VERSION < 50100 >>>>>> +/* >>>>>> + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 >>>>>> + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk >>>>>> + */ >>>>>> +# error Sorry, your version of GCC is too old - please use 5.1 or newer. >>>>> >>>>> From the bug entry the fix looks to have been backported to 4.9, >>>>> or at least some (important?) branches thereof. >>>> >>>> It is not clear what's you are trying to point out. Mind clarifying? >>> >>> Some 4.9 compilers (perhaps widely used ones) may not have the bad >>> issue, which puts under question their ruling out when the main >>> reason for doing so is that bug. >> >> Well... We could surely try to hunt which GCC 4.9 has been fixed. But I >> am not convinced this is useful, we would need to have an allowlist of >> GCC compiler. > > Or probe the compiler for the bug in question. I thought about it but it is not clear to me whether the reproducer would work on every GCC version and how to detect that this was miscompiled. Do you have any suggestion? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 10 18:45:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 18:45:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96263.181973 (Exim 4.92) (envelope-from ) id 1lK3pz-0002z5-ES; Wed, 10 Mar 2021 18:45:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96263.181973; Wed, 10 Mar 2021 18:45:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK3pz-0002yy-BX; Wed, 10 Mar 2021 18:45:39 +0000 Received: by outflank-mailman (input) for mailman id 96263; Wed, 10 Mar 2021 18:45:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK3px-0002yt-Af for xen-devel@lists.xen.org; Wed, 10 Mar 2021 18:45:37 +0000 Received: from mail-pj1-x102e.google.com (unknown [2607:f8b0:4864:20::102e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6c1e285b-409e-4051-9a5a-9c4fe7d51359; Wed, 10 Mar 2021 18:45:36 +0000 (UTC) Received: by mail-pj1-x102e.google.com with SMTP id q2-20020a17090a2e02b02900bee668844dso7727834pjd.3 for ; Wed, 10 Mar 2021 10:45:36 -0800 (PST) Received: from ?IPv6:2601:1c2:4f80:d230::5? ([2601:1c2:4f80:d230::5]) by smtp.gmail.com with ESMTPSA id 186sm225160pfb.143.2021.03.10.10.45.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Mar 2021 10:45:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c1e285b-409e-4051-9a5a-9c4fe7d51359 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:organization:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1QlGp94Z6xqtgpaSqZ1T43NlR4hswlJTog0zzkF2qmM=; b=Z8G3eanK+NquRUUrfVN1rerBR1po6SvilaSG7q+2J2jWiWQN/GLNYbg9EDmDgdTb5p Da6355xfUB3+pxhP91OyBOinqzEWbF8s5+fLCASbMgin3QJwRQ9OS7kuC7s7dr1umca6 h5JI9rQZyNZ/CYTKyo4q3aXCkO6/NsCzVBY3G0pXHgB8JQTCFmUUmDToeNOI9VtpvJBu nM/BcpwaJs6nFFZZl+N/Dl+sjpKYKukZ7DNDMjpCDAranBG6awNstQbdagvO1HRX9Nw1 XefE2Jwm9FZAqiNjnewxXy6i7SqnJqcFrNIpFOTCtrlao20ZgoLMZjHCt1eRxoa6sIkR jdew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=1QlGp94Z6xqtgpaSqZ1T43NlR4hswlJTog0zzkF2qmM=; b=Sgo0DQeRwE38/iWJONo86dqAQwSLXcoXou0Ex9o3rVf8yrkB543e7r0Ct3+JKEOKC7 ukEOpNF9jgrRWzGt2dQZZ1DMR78nYlbeTUi6h+++/JvEEu7fA4IhrEaGeqZ+aXYckFoL wJvCy7uFr3yBJSV13DlNwW5576n5EgrVphtk3PoQqvkfVdp9lIztbsAKg/zXmmG4Hlvn RMx7FhiYjeKM0PhQ+ZwmXBGOSi6vrURDontaKJpI1cmJVbqo+d2m8C3IHUJUPrwyk/dy sOJpeOuNK4U1/OizMp8tqWFIrB+A8PoH5G/at39lNNg+1e7RKuuxMQJ9Xt0CoCSQYBvk zcIA== X-Gm-Message-State: AOAM532kRc99IanNJim+MOzw3HmzVIng4frRoQZl8626I3wOWo8Rawvb 9jTnhTD8TAxmkxIaK3A4QLmSAZZJeQTV/A== X-Google-Smtp-Source: ABdhPJz0R00O/A+HzBt1HftSK5Att9b/98uBAyEZ/WCHHAL6jR8Xr3RzoxvMudzDn+HK4Z0U1b4+jg== X-Received: by 2002:a17:90a:20c:: with SMTP id c12mr4883417pjc.224.1615401935106; Wed, 10 Mar 2021 10:45:35 -0800 (PST) Subject: Re: HOWTO enable Xen on my board based on STM32MP1 To: Gurrieri Stefano , "xen-devel@lists.xen.org" References: <1449aa784e6243ee9a8e33642dcb7693@roj.com> From: Bob Eshleman Organization: Vates SAS Message-ID: Date: Wed, 10 Mar 2021 10:45:33 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <1449aa784e6243ee9a8e33642dcb7693@roj.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/10/21 1:29 AM, Gurrieri Stefano wrote: > Hello, > > I'm working on the platform STM32MP1 based on cortex-A7 dual core. This is an armv7-A that has the "Hardware virtualization support". > My current Linux BSP is built using Yocto Project... but now, I'm asking how to enable XEN on my platform? Is there a procedure to follow to try to experiment? > > Thanks a lot! > Greetings, > Stefano Hey Stefano, I'd start with https://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions and telling U-Boot to modify the fdt as described in the link. That should give you a good idea how to get UART from Xen and how to tell it about where your dom0 kernel/initrd are located. Best, Bobby From xen-devel-bounces@lists.xenproject.org Wed Mar 10 19:02:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 19:02:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96266.181986 (Exim 4.92) (envelope-from ) id 1lK465-0004wN-TG; Wed, 10 Mar 2021 19:02:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96266.181986; Wed, 10 Mar 2021 19:02:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK465-0004wG-P6; Wed, 10 Mar 2021 19:02:17 +0000 Received: by outflank-mailman (input) for mailman id 96266; Wed, 10 Mar 2021 19:02:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK464-0004wB-Qx for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 19:02:17 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8a0f7698-1014-4959-bd1a-5b8f3ad4bc32; Wed, 10 Mar 2021 19:02:15 +0000 (UTC) Resent-Message-ID: <24649.6066.185913.382873@mariner.uk.xensource.com> Resent-Date: Wed, 10 Mar 2021 19:02:10 +0000 Resent-To: Resent-From: Ian Jackson X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a0f7698-1014-4959-bd1a-5b8f3ad4bc32 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615402935; h=resent-message-id:resent-date:resent-to:message-id: mime-version:from:to:cc:subject:date:resent-from; bh=FFlPtTR2s1Hm7sP6trZ7Nj/AqG4KREClitErAm06bz0=; b=J3nd5a1PPeWS/pDQTLDQnk2vP+TAfQdP7E6dje+KZJA5iTCT5HkSuIU/ b49ZpbsQF9nsmQIpEUSX5m4pOJRlqHNCrl48ozjyKKpRQB/TwFo5yGd56 9GDSoigkVwvVbAqQye2CDYfG5xS80T0oEojPvL796VYSrBiPqZ/ff6apU o=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: CXeZT67ID9kz2v5+QvQdgV5d3MF/K+smadsnJnjN5DetGOZNgS7+bS404s8rxiQdYUwhnb7Vrl 1hEmdCoiSzAd00pXtjHgotPNWz8wT5O/2otlWsIBHJcfMWVKurgtK5md7zeObMWiqW/8FrLuUY vQi8x8ikRV/Nc1Qf3IuoL7tYr+49zT4mzkhgsfZYFKiFGKNAr4QDfQzSC+m9/IHQcDX6kZaQlL PPO1LJPuuoHe6wUKj4XSl842QROXBbCQ+xtPntgmj27BEUOghPgT3KYaas0GhYtx/3gheoi8I7 mME= X-SBRS: 4.0 X-MesageID: 40403192 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,238,1610427600"; d="scan'208";a="40403192" X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 X-Inumbo-ID: 318846c8-c861-43d1-ac69-d135625588d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615394846; h=date:from:to:cc:subject:message-id:mime-version; bh=FFlPtTR2s1Hm7sP6trZ7Nj/AqG4KREClitErAm06bz0=; b=a4H7pv7Tt31EwqpNoLhnoaNg5MvXZdTdVelQa+SLbFDYoXXEzLzWKMkZ feoBSfSpvfZnbXSFOSL+nYZGj49RaHSmHm7jLPYWC4gl4MmLbMkuwmCJj WF/5yWAUTOHt4SVCHL1RZPKiwLPJFuMm6ZvW84JHW6i5FHhWE+MJ13o6F A=; IronPort-SDR: eq+k6QL/pN5/H6Qtg8hcNXGSxza6pH21qQBzNwYmfe9CT5QOweDHhPWH46BNM1sY9vVzb7LU+1 rdY4suQG0AVw++AxdrBSv6b1mrmahAdOYhvFPVoxGraT3sgCxeTaFVyuoPslREgpYs/DCvaLT4 5gqa/fI6j+K0TtQNxP1OLY2KQcQruEg3eoaxADdU4665ghR1CvnIysLz/VtuINU1KWeqGUvsRX Ada7sk6vRG/2zsFbxZtO2IqKSfd36FsCqiA6GhTRFwOq6Ub+r8eZEUuWnx459MHH9KLSh6LQmT S6g= X-SBRS: 5.2 X-MesageID: 40390135 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:fS6H7a949CvUsfT34W9uk+EocL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmyybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIUHD38Zn/+ Nbf6B6YeecMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsKV4hLxW5Ce2GmO2dxQxRLAod8OZ qH/8xcpyehf3N/VLXBOlAuWe/fq9rX0K/3eBJuPW9e1CCirxONrIT7HR+RwwsEX1p0r4sK3G DZn2XCl8eemt6hzBu07R63071zuP/MjuROH9aNjM99EESSti+NaJ56U7OP+BAZydvfkWoCq9 XHrxc+M8kb0Rq4FQvU0HidqjXI6zoy92TkjWaRnHqLm72EeBsBF8FDiYhFGyGpjXYIgdcU6t Mu40up87BTDR/GgR3n4cnJWxxAhiOP0AcfuN9WoHpFXYQEbrhN6aQZ4UNOCZ8FWBn38YY9DY BVfYrhzccTVWnfQ2HSv2FpztDpdnMvHi2eSkxHnsCOyTBZkF1w0kNw/r1Uol4wsLYGD7VU7e XNNapl0JtUSNUNUK57DOAdBeOqF23kW3v3QS2vCGWiMJtCF2PGqpbx7rlwzvqtYoY0wJw7n4 mEeE9EtFQ1Z1nlBaS1rdF22yGIZF/4cSXmy8lY6ZQ8kKb7XqDXPSqKT01rvNCnp9kZH83HS9 e+MJ9bGJbYXCrTMLcM+ze7d4hZKHEYXsFQkM08QUiyrsXCLZCvluGzSoeSGJPdVRIfHk/vCH oKWzb+YO9a6FqwZ3P+iB/NH1fkekn1+4NMALHXltJji7QlB8lpiEw4mF657saEJXlpqaotZn ZzJ7vhj+edqXSp+33Lq0FkIABUAEoQwLiIaQIGmSY6d2fPNZoTsdSWfm5fmFGdIAVkcs/QGA lD43Jt+ay2KJSU7Ts4C82uN1+bi3d7ngPFc74s3om4oev1cJIxCZgrHIZrEx/QKhBzkQF27F tYZBQ8XU/ZHDP2gaCDhJgZbduvNeVUsUOOG4p5uHjfvUKTqYUKSmEAVzCja8KRnD0jXiFZnF F37q8ZjoeRgDrHExpAvM0IdHl3LEiHCrNPCwqIIL9Znb3mYylcZ2aHjz7ysWBERkPas2Epwk DxJyydfv/GRmdHsndDy6Dw7RdfbWOGZX99bXh8rKxwHWnLoWxIzOeOf6a/ulHhL2cq86U4Cn XocDESKgRhy5SLzxaTgi+FDmhj6ZM0PODRZY5TBo376zeIEsmvmq4HFfMPo8ogG9Dqr+MRUe WQPyWSNyj1Dus12wqT4lYpURME20UMoLfN4lnC6mP94VsURdz1C35iT6sAI96d43P/Lsz4p6 lRvJYQh6+ILm71atS60qnZYD5IFwPLrQeNPpEVgKERmZh3iaB6EJbaWwbZzX1r3B0xK8HviU MVKZ4LkozpC8tKf8YIfThe8UdsvNOTLFEzugieOJ52QXgdy1vaNciO+bzGtP4GBVCAvhL5PR 26/zdG9/nIGwuF2rhyMdN5HU1mLGw94m9l5uWMasn5DxirbfhK+B6CCUCGGYUtPJStKPE3tR Z149aBgu+ReW7Z4WnrzEFGC5ML1X2mT8O0CB+LAshS/bWBSBCxvpc= X-IronPort-AV: E=Sophos;i="5.81,237,1610427600"; d="scan'208";a="40390135" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RqaZc2eWDMIJc5pvts9t0QJ6eoHU8dYK5Qdo25jVxfvtCsO3ozUVuyBdnnS2Keo1jyCLDFqs0OltaX2IINrPdWljGax5UXMRgEgQJPGkC0z3rGkyijyEbe5dJarN8/YcXeePvp+D7tDTE3VhsLImPT3QvJGzdG7QouILJrdU0KrNZo00Ktl9xPMBYcuvOGUt80M1qeK1JT5WN/1fCEGMk/Pu6fXqQ4Ovot6wso8zYsX4DXOYPA8ZWgL+f6E2ePpHOJYzil54H5sKLWKuQXlqwCh0+RQo3veUoX9CMmabqW+W16XLSMvN2uZwzbu9BYioWW3L96lR2Gk6/t1M9P12xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gmGLIOoT+DiOsrVphlt5lw1sE8UbvBvcFWORl/tmDbE=; b=E6v98V1lQbpVTZDqTVkCgaDWkCZOrKRmQTQ/aQ8ydE3ELKfnT2Hf0a+ZQ5TWyOeVSonSJeEDf4lEVdbg3HyZinC1XWG8dCcLbd9gFwVQ1ydp0ZcEyzxQdJ0THjL3vOclBVWWzPoPldSdUOYPULcDJB3nucMJIS7opcmLNJxF6p2ZU49a7NOTRfAWXnKqHqk/ZVPQjYBffYOf8QD00vdf3eXcjPBHj6Rlp8X39PkRFnGRc+sR56WRGxL15z7v5tSkxmvQNuy0p7oo/QwIw6QJH+4ATDFgjegUB6H0kdKaToW4yLSJEfyIXC4XIA40IkU8Sw2mk7T01bGi0d1IdRflmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gmGLIOoT+DiOsrVphlt5lw1sE8UbvBvcFWORl/tmDbE=; b=hfGrlJQhqqRTag3CdWs+XHdijxVxEFHDpplbdBXJPxFd+afQkZM7zWRN9Dj8i3w50vv8tiXERLk4bKYLXGtjeeLJ8c3TMMvHb+XSLckcrjx0lqIFw4fqAUo9FHGC9erIAC9yZNz11cWukV6GMwDDGoMV6sUmvCWBNSCS52+nRKY= Message-ID: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-ClientProxiedBy: LO2P123CA0011.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::23) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 80195b4e-25f4-42df-5f43-08d8e3e41b36 X-MS-TrafficTypeDiagnostic: DM5PR03MB3147: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P0y3beLBjYAf7e7ecpJKrQjf4WjOJ4SPok3vUdpbWinuSdk+ydcuTTSIaDrWtrf8MacJYnh/jXMLZb4vX4+PVztxJR1iqHFUT7aNMce9Puw+XsoPFPwx5A36zr57XBjKy8/EBGucxz2NRyAt9P9SHfz2E5ZtEa4O3Zo1oeD7nvK6fM7W4+gKZww6tb/NwNQMjZP81idG/eojh9MUebcISY7IxXoF1vkfVG5yFIGvw83CAB6I2DscHCnZJseAYgFURs0rTBkextezqT4Zs+XIYwGJeBHrGL/Kuw3AYxc/iXnTW73yn1STLHODfModt0uC6olrVYRZLdhL4/VoiZJaSvwUqeXCRPxi3DRBiXBF4ClOxPxfH6yCe+2X12TGvJOlG6aSyWjhEIY6ywonoq+GSp/e8PmsNLyW9l1+a4L2O9XWIsXhJCxGec1LqagNKyfi7imtyxdRL0ZPCiVQl6dOp9LUDsGcFRbCG99EU01JMRQagyJD55Ft8MaIl0q/AgIi077Xh3zqbVLmUl59joaMsRMIuK1HqSstfhIN7jBwJH68DpxQMmYPA1pCwno1yAoIvuDFxx1Fj4T/pheZO0ndxDcMB5calv9GU1lRazF2WzY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(39860400002)(136003)(346002)(376002)(396003)(366004)(2906002)(316002)(33716001)(4326008)(86362001)(478600001)(8936002)(186003)(956004)(9686003)(54906003)(5660300002)(3480700007)(966005)(6486002)(6666004)(7116003)(26005)(6496006)(6916009)(66556008)(83380400001)(66476007)(85182001)(16526019)(8676002)(66946007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?RDgxbXlEYVhjUFQwUzZoTVZQc1V2cFBWTmc2cExmeVZrTVYxdTNwYUZNclQy?= =?utf-8?B?Z1lSVDVXTUNBdy9SOXNtMGNHQmNZamdsUG9BeG1MWTBUcHFJVkFNN1Z5am5y?= =?utf-8?B?Mk8xV2FWWTMzZXhDbVhYcGFvYWgybDJEdndxR0hjaU51ODdYRUdaZmNPU3lW?= =?utf-8?B?M2NrQjlHN096UGhnWjVEdkNZc0xzR0M0K0xEL1RSNDJqbHhCT2U1akRaTDh1?= =?utf-8?B?SStwS3lCSGlUdzV6QnczSkh2UHlWZUpDZ1ZORlJNMU03ZkhURFNzR3pqZjhC?= =?utf-8?B?UVRXYkRVTjBmQWpPKzNCYlBvdDF0ZDBnUks2UTV1NFptcmlSRzBSdDMxZkYx?= =?utf-8?B?bko3bTZmcnVIWllzMFpoUUgxOUpjQzgrWkVtTUgvK0NldjJZY1lkS3BIK0h4?= =?utf-8?B?bFhzMjV3RE95dHphT1IwVGIwL0pHRU51Mms4SElxejQ1aS9oVHc1dHpnSGJx?= =?utf-8?B?UmVaZVN6RElVWTdveXZTVjhxSGRXa2hxUGJwMWlGMEUrRjg2eGxkS2FCb2lj?= =?utf-8?B?cXdPVkVzTXlUazZLcmd4Yk1EZFoyL05wWDJxSUpZdVpJNjRlenZpMTY4NlJx?= =?utf-8?B?UEtjL0xNa25RcnduK1Azd05GSENieTZwNHRmSDNuUVlYSE5hZFJZQlB6ZXdS?= =?utf-8?B?NlNtd3gwbjZzVmVPWm1JMlNXMmI5Y3JsWWlNdlNvU3IxNHBCcTEwTGdCZ09U?= =?utf-8?B?VFgwK04rM0EyQzJWUG92aDRrWXpzMmMyR3Rjd0praTZZZDNMb3JJd2w3T1ZQ?= =?utf-8?B?QnV3R0NpVVJWWTU1WFczeW5rMlZNTTRPWFdvOEFtMUxKRG1IZFp4RExwTVk0?= =?utf-8?B?Yy83dEtvN21zWG9QeCtRM0NiQTBzRDBnME9NQUVKQ3RDR21uNmdEVmdOeWNr?= =?utf-8?B?VHFwY1c2TlMyNkdpVXp4Tkx6WmsvSkt5UXRkWVpLbzlwblBjcGluS3BXTnFt?= =?utf-8?B?NjN1aFd2V2VJc0NNN1RDL1lVYlpHemFnNHRHVDlVMWx2RWRGdTREZWpkMldz?= =?utf-8?B?ODhiU3EycHBLM2RnbkZ1VHRWRFArc01OMi9hR2xuWjN6NTdkV3MyKzU2ZEw1?= =?utf-8?B?YVZiVmZoWGJLckN3TlRYZVJDQWhBNktZY05pdDVZVkFYS2o3L2tKZzlpNDFR?= =?utf-8?B?WlRaSFpUbEpEZ1B1dU9lSGl1dnN5ZUg2cGp4bERLclBmdmNCYmN5NW9SRy84?= =?utf-8?B?Q0pscUZyNUFVMmtuOFY3a3M3dWJSU0NRUWtrK2lYbHV6WlFVWXFGTEoxaVph?= =?utf-8?B?V3dEclpPUVlMb0VaMFNQRGRScy9OaG81dmU5OHhiZGxOUUdwR1NmZDBLZUNR?= =?utf-8?B?cFFOOWxGOWFMa3FzYmo3QzZtOUltK25CTXlnSERvSHZoZUxodklJYTRaOW1h?= =?utf-8?B?T1ZLYU1wYWlnMnRyZmNHVFQxczlDeGdWL2FraG5MVm5RVVk0Q25aV040UDla?= =?utf-8?B?cnJXMjhQTmYvSHFNeXpMWWpXejBidGs1akIxYm9NV2VsL2hodXpHSXl5d0Vn?= =?utf-8?B?Z1FyUzBickRUSEs0ZmxUVG9PUXBoWUlmNjVzV293cHFZdVhxWDdDK2tSSTF2?= =?utf-8?B?NE11M2I1WEtjaVFzQWgvbmIzZC9lQUJUVkdCVHljbDd5U1czS0ZtUXlxNVMy?= =?utf-8?B?UTlLeXFqVkgrL2U5SUlKUFoyVHJPUzhxcW1XbEkzRDg0enZvOFd1eVhVUStT?= =?utf-8?B?Zk1DcjFzQmFqU0ExbVE3dGwzTGJRUmxsWXRON3dDS2FmcVFCTkJYZFRPakl3?= =?utf-8?Q?UQMI9B8AkqnI4+rd1Jy8KQWiyK3LfsPwr4Zt2kl?= X-MS-Exchange-CrossTenant-Network-Message-Id: 80195b4e-25f4-42df-5f43-08d8e3e41b36 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 16:46:52.2637 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cxjwRfOxh0mAqCYhMVKD7+1+7+NaKenr2I6mtXs6bMOD1uDumVrGX1FSWxiroM+1prJ0Xt5uVr2HYA/EmGiHmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3147 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: CC: Jan Beulich , Andrew Cooper , Ian Jackson Subject: Remaining MSR wrinkles Date: Wed, 10 Mar 2021 17:46:46 +0100 Hello, There are a couple of remaining wrinkles related to MSR that I think we need to solve before the release, or agree that it's fine to leave them as-is and document in the release notes. I've tried to summarize the different views below, sorry if I haven't done this properly or missed some arguments. I'm sending to committers to see if we can find consensus on the path going forward, or else to trigger a voting on the possible solutions, because discussion on xen-devel seems to get stuck. 1. MSR behavior for PV guests without a #GP handler set: PV Linux versions < 4.14 will use rdmsr_safe (and likely wrmsr_safe?) without having a #GP handler setup, which results in a crash. This bug was hidden in previous Xen releases by allowing unlimited read access to the MSR space. Jan has posted several proposals to address this: https://lore.kernel.org/xen-devel/7e69db81-cee7-3c7b-be64-4f5ff50fbe9c@suse.com/ https://lore.kernel.org/xen-devel/d794bbee-a5e5-6632-3d1f-acd8164b7171@suse.com/ Which all rely on the fact that for PV guests Xen knows whether there's a #GP handler setup and can hence prevent injection of a #GP fault if no handler is present. Andrew opinion is that we should instead try to figure out which MSRs the buggy Linux versions try to access and special case them. Andrew also raised the point that continue running with a 'fake' (ie: 0) MSR value might be worse than crashing. Part of the discussion has also happened here: https://lore.kernel.org/xen-devel/4da62f0b-8a08-dd84-2040-fd55d74fd85a@citrix.com/ Look for the last quote. Another option is to document that PV Linux < 4.14 will require msr_relaxed=1 in order to run. That as Jan pointed out will also imply PV Linux to run with a faked (0) MSR value instead of crashing. 2. RAPL_POWER_LIMIT: handle the MSR explicitly to make Solaris happy. Alternatively we can list in the release notes that Solaris guests require msr_relaxed=1. Andrew is working on a patch for this. 3. MSR_K8_HWCR: Linux will complain about a missing bit (TscFreqSel). Jan posted a patch to handle the MSR and unconditionally set the bit: https://lore.kernel.org/xen-devel/c91b190a-aaa1-d3b8-10eb-d8da7ad1f834@suse.com/ There are concerns from Andrew about missing bits in ACPI tables and Pstate MSRs if this bit is reported as set. For 1. I do agree with Jan than this workaround is likely the best option we have, sort of resorting to request enabling msr_relaxed for all Linux PV guests < 4.14. Whether we want to limit this workaround to the read side only I'm not fully convinced. There's something nice about having symmetry in the read and write paths, but if all the calls we have identified are rdmsr only I prefer to leave the write path unaltered and request users to use msr_relaxed if write issues are found later. For 3. I think I at least need more details about the relation with TscFreqSel and ACPI or other MSRs, and I haven't been able to find it on the PPRs I looked. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 10 19:16:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 19:16:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96280.181997 (Exim 4.92) (envelope-from ) id 1lK4JW-000672-60; Wed, 10 Mar 2021 19:16:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96280.181997; Wed, 10 Mar 2021 19:16:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK4JW-00066v-2u; Wed, 10 Mar 2021 19:16:10 +0000 Received: by outflank-mailman (input) for mailman id 96280; Wed, 10 Mar 2021 19:16:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK4JU-00066j-8q; Wed, 10 Mar 2021 19:16:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK4JU-0000WL-14; Wed, 10 Mar 2021 19:16:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK4JT-0005Lz-PM; Wed, 10 Mar 2021 19:16:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lK4JT-0004dL-Ot; Wed, 10 Mar 2021 19:16:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yEwqhhoyI8qcVonVjF5VrzaRi9Z0OLa9JRcJelrytSA=; b=1QipjYUALeLadLDau0lcxmUQJA mxAjvdodRsbFCTyN5wxl10+1vIcLpGK7j0GAw6LOg+kv3mP7jXT88Q3JrSYxMIgjI8llRubzdfDM6 h1UUjaYd5cPDJfPugy0dLNTs7loxwKlCIBzKjl35lAV8YKJrPE3BwR0T3ojCiyKNBUiw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159917: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e4bdcc8aef6707027168ea29caed844a7da67b4d X-Osstest-Versions-That: xen=4e01c48886d9fbfee3bf7e481c4529a176331c78 From: osstest service owner Date: Wed, 10 Mar 2021 19:16:07 +0000 flight 159917 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159917/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e4bdcc8aef6707027168ea29caed844a7da67b4d baseline version: xen 4e01c48886d9fbfee3bf7e481c4529a176331c78 Last test of basis 159913 2021-03-10 14:01:33 Z 0 days Testing same since 159917 2021-03-10 17:01:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ian Jackson Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4e01c48886..e4bdcc8aef e4bdcc8aef6707027168ea29caed844a7da67b4d -> smoke From xen-devel-bounces@lists.xenproject.org Wed Mar 10 19:38:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 19:38:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96286.182013 (Exim 4.92) (envelope-from ) id 1lK4eY-00089Q-TU; Wed, 10 Mar 2021 19:37:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96286.182013; Wed, 10 Mar 2021 19:37:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK4eY-00089J-Os; Wed, 10 Mar 2021 19:37:54 +0000 Received: by outflank-mailman (input) for mailman id 96286; Wed, 10 Mar 2021 19:37:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK4eX-00089E-R6 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 19:37:53 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 528de74e-9808-483e-8f82-34790a2a9603; Wed, 10 Mar 2021 19:37:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 528de74e-9808-483e-8f82-34790a2a9603 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615405072; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ID4rXGKPixiIuekEIXdMa5whMyRfr4VjHmPEXuxM1vU=; b=T6V12kghnrsngdqIhanG5ymffyMV4rxD/fdJxdXhNU1nogzvYzN8ZnYs FznXb3ZnWA4BX6wbtaZQyvTcOZmvbe1X3Q1O2BxuBB2iMtIQSl9kx9/SZ nV4nSftMnths1zWwxDRpngQAMvQiQvN2WSh20Bpg2fVQuf4JEPkXO/0yh s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 9pReDtA9FFn03gxuG6f2MJs7UXOax9hpzzp8BvgSU/Js36UIJGg8zxERTt6Ftaa+VflxpoeEuo qwC4DRvdm6NPUgSN9SO98T8yUZV/lEZAJYRNAarGc8fT5bdDy09to5UYH2yeXbZZuufF1CfaWM cn28f7rk1K4mQZMs3lDgyGeamC3UPTmjiludRpHCRyu+/SntSFs80CTXdJgSTVOZjZRyhGP4hn EsRtxKS8+vwdqKgGdTAajEv8xmJqz6ps3iuJpD7ULpf28p+AUlXynhn4+mYhKIkhLZvgtvHRGT hrM= X-SBRS: 4.0 X-MesageID: 39005932 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:DHovQaioBBa3/sdFih4pxHTnj3BQXiUji2hD6mlwRA09T+Wzkc eykPMHkTr9jzgMUH8t8OrvBICrR3TA+ZlppbQAJLvKZmbbkUahMY0K1+ff6hL6HSmWzIRg/I dmN5NzEdjhSWV95Pyb3CCdM/INhOaK67qpg+C29RxQZCVncbtp4Qs8KivzKCxLbTJLD5Y4C5 aQj/AvzwaIQngZYt+2AXMIRYH41r72vaj7ah0LDQNP0njtsRqU7tfBfiSl4g== X-IronPort-AV: E=Sophos;i="5.81,238,1610427600"; d="scan'208";a="39005932" From: Igor Druzhinin To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= , Roman Shaposhnik CC: Xen-devel Subject: RE: Troubles analyzing crash dumps from xl dump-core Thread-Topic: Troubles analyzing crash dumps from xl dump-core Thread-Index: AQHW9nsP4F6kEkHrzUmrgvtWz2V0Z6pAGduAgAC/cYCAAMlrgIA8OGKg Date: Wed, 10 Mar 2021 19:37:48 +0000 Message-ID: <6466c5e156bf4afbb9fbbd44d7ff20b8@FTLPEX02CL02.citrite.net> References: <91837fa8-1d57-8b37-bf66-9e021855348d@suse.com> <2bbb347c-bc5b-63f7-3e94-b90145ff5166@suse.com> In-Reply-To: <2bbb347c-bc5b-63f7-3e94-b90145ff5166@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 PiBPbiAzMC4wMS4yMSAxOTo1MywgUm9tYW4gU2hhcG9zaG5payB3cm90ZToNCj4gPiBPbiBGcmks IEphbiAyOSwgMjAyMSBhdCAxMToyOCBQTSBKw7xyZ2VuIEdyb8OfIDxqZ3Jvc3NAc3VzZS5jb20+ IHdyb3RlOg0KPiA+Pg0KPiA+PiBPbiAyOS4wMS4yMSAyMToxMiwgUm9tYW4gU2hhcG9zaG5payB3 cm90ZToNCj4gPj4+IEhpIQ0KPiA+Pj4NCj4gPj4+IEknbSB0cnlpbmcgdG8gc2VlIGhvdyBtdWNo IG1pbGVhZ2UgSSBjYW4gZ2V0IG91dCBvZg0KPiA+Pj4gY3Jhc2goMSkgNy4yLjggKGJhc2VkIG9u IGdkYiA3LjYpIHdoZW4gaXQgY29tZXMgdG8gYW5hbHl6aW5nIGNyYXNoDQo+ID4+PiBkdW1wcyB0 YWtlbiB2aWEgeGwgZHVtcC1jb3JlICh0aGlzIGlzIGFsbCBvbiB4ODZfNjQgd2l0aCBzdG9jayBY ZW4NCj4gPj4+IHYuIDQuMTQpLg0KPiA+Pj4NCj4gPj4+IFRoZSBnb29kIG5ld3MgaXMgdGhhdCB0 aGUgaW1hZ2UgYWN0dWFsbHkgZG9lcyBsb2FkIHVwIGJ1dCBpdCB0aHJvd3MNCj4gPj4+IHRoZSBm b2xsb3dpbmcgV0FSTklOR3MgaW4gdGhlIHByb2Nlc3M6DQo+ID4+Pg0KPiA+Pj4gV0FSTklORzog Y2Fubm90IGFjY2VzcyB2bWFsbG9jJ2QgbW9kdWxlIG1lbW9yeQ0KPiA+Pj4gY3Jhc2g6IHJlYWQg ZXJyb3I6IGtlcm5lbCB2aXJ0dWFsIGFkZHJlc3M6IGZmZmZmZmZmOTM2MTM0ODAgIHR5cGU6DQo+ ID4+PiAiZmlsbF90YXNrX3N0cnVjdCINCj4gPj4+IFdBUk5JTkc6IGFjdGl2ZSB0YXNrIGZmZmZm ZmZmOTM2MTM0ODAgb24gY3B1IDAgbm90IGZvdW5kIGluIFBJRCBoYXNoDQo+ID4+PiBjcmFzaDog cmVhZCBlcnJvcjoga2VybmVsIHZpcnR1YWwgYWRkcmVzczogZmZmZmZmZmY5MzYxMzQ4MCAgdHlw ZToNCj4gPj4+ICJmaWxsX3Rhc2tfc3RydWN0Ig0KPiA+Pj4gV0FSTklORzogY2Fubm90IHJlYWQg bG9nX2J1ZiBjb250ZW50cw0KPiA+Pj4NCj4gPj4+IEFuZCB0aGVuIHRoZSBpbmZvIHRoYXQgaXQg Z2l2ZXMgbWUgYXJvdW5kIGJhc2ljIHRoaW5ncyBsaWtlIHBzLCBtb2QsDQo+ID4+PiBsb2csIGV0 Yy4gaXMgcmVhbGx5IHN1cGVyIGxpbWl0ZWQgKGFuZCBJIGFtIG5vdyBzdXNwZWN0aW5nIG1heSBl dmVuDQo+ID4+PiBiZSB3cm9uZykuDQo+ID4+Pg0KPiA+Pj4gU2luY2UgSSB3YXMgcHJpbWFyaWx5 IGFmdGVyIGRtZXNnL2xvZyBpbml0aWFsbHksIEkgdHJpZWQ6DQo+ID4+PiBjcmFzaD4gbG9nDQo+ ID4+PiBsb2c6IFdBUk5JTkc6IGNhbm5vdCByZWFkIGxvZ19idWYgY29udGVudHMNCj4gPj4+DQo+ ID4+PiBUaGVuIEkgdHJpZWQgdGFraW5nIGFuIHhsIGR1bXAtY29yZSBmcm9tIHRoZSBkb21VIHRo YXQgd2FzIHN0aWxsDQo+ID4+PiB2ZXJ5IG11Y2ggYWxpdmUgYW5kIGhhcHB5IGFuZCBnb3Qgc2lt aWxhciByZXN1bHRzIC0tIHNvIGl0IGNsZWFybHkNCj4gPj4+IGRvZXNuJ3Qgc2VlbSB0byBiZSBy ZWxhdGVkIHRvIHRoZSBzdGF0ZSBkb21VIGlzIGluLg0KPiA+Pj4NCj4gPj4+IEFzIG1hdHRlciBv ZiBmYWN0LCBJIGFjdHVhbGx5IGdvdCB0byB0aGUgZGVzaXJlZCBkbWVzZyBvdXRwdXQgYnkNCj4g Pj4+IHNpbXBseSBydW5uaW5nIHN0cmluZ3MoMSkgb24gdGhlIGNvcmUgZmlsZSAtLSBzbyB0aGUg aW5mbyBpcw0KPiA+Pj4gZGVmaW5pdGVseSB0aGVyZSAtLSBidXQgSSBndWVzcyBzb21lIGtpbmQg b2YgaW5kZXgvcmVmZXJlbmNlIG1heWJlDQo+ID4+PiBicm9rZW4uDQo+ID4+Pg0KPiA+Pj4gV2l0 aCBhbGwgdGhhdCBpbiBtaW5kLCBpZiB0aGVyZSdzIGFueW9uZSBvbiB0aGlzIE1MIHdobyBoYXMg cmVjZW50bHkNCj4gPj4+IGRvbmUgWGVuIERvbVUgY3Jhc2ggZHVtcCBhbmFseXNpcyAtLSBJIHdv dWxkIGRlZmluaXRlbHkgYXBwcmVjaWF0ZQ0KPiA+Pj4gdGhlIHBvaW50ZXJzIQ0KPiA+Pg0KPiA+ PiBGb3IgbWUgaXQganVzdCB3b3JrcyAob3BlblNVU0UpLg0KPiA+DQo+ID4gQ2FuIHlvdSBwbGVh c2UgcnVuOg0KPiA+DQo+ID4gY3Jhc2ggLS12ZXJzaW9uIGFuZCByZWFkZWxmIC1hIFhYWFggKG9u IHRoZSB4bCBkdW1wLWNvcmUgb3V0cHV0KSBhbmQNCj4gPiBwb3N0IHRoZSByZXN1bHRzPw0KPiAN Cj4gIyBjcmFzaCAtLXZlcnNpb24NCj4gDQo+IGNyYXNoIDcuMi4xDQoNCkkgdHJpZWQgdG8gYnVp bGQgdGhpcyB2ZXJzaW9uIGJ1dCBJIHN0aWxsIGdldCB0aGUgZm9sbG93aW5nIHdoaWxlIHRyeWlu ZyB0byBvcGVuIGEgZHVtcCBmaWxlDQpwcm9kdWNlZCBieSAieGwgZHVtcC1jb3JlIjoNCg0KW3Jv b3RAbGN5Mi1kdDkyIGNyYXNoXSMgLi9jcmFzaCAuLi92bWxpbnV4LTUuOC4wLTQ0LWdlbmVyaWMg Li4veHh4LmRtcA0KDQpjcmFzaCA3LjIuMQ0KQ29weXJpZ2h0IChDKSAyMDAyLTIwMTcgIFJlZCBI YXQsIEluYy4NCkNvcHlyaWdodCAoQykgMjAwNCwgMjAwNSwgMjAwNiwgMjAxMCAgSUJNIENvcnBv cmF0aW9uDQpDb3B5cmlnaHQgKEMpIDE5OTktMjAwNiAgSGV3bGV0dC1QYWNrYXJkIENvDQpDb3B5 cmlnaHQgKEMpIDIwMDUsIDIwMDYsIDIwMTEsIDIwMTIgIEZ1aml0c3UgTGltaXRlZA0KQ29weXJp Z2h0IChDKSAyMDA2LCAyMDA3ICBWQSBMaW51eCBTeXN0ZW1zIEphcGFuIEsuSy4NCkNvcHlyaWdo dCAoQykgMjAwNSwgMjAxMSAgTkVDIENvcnBvcmF0aW9uDQpDb3B5cmlnaHQgKEMpIDE5OTksIDIw MDIsIDIwMDcgIFNpbGljb24gR3JhcGhpY3MsIEluYy4NCkNvcHlyaWdodCAoQykgMTk5OSwgMjAw MCwgMjAwMSwgMjAwMiAgTWlzc2lvbiBDcml0aWNhbCBMaW51eCwgSW5jLg0KVGhpcyBwcm9ncmFt IGlzIGZyZWUgc29mdHdhcmUsIGNvdmVyZWQgYnkgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNl bnNlLA0KYW5kIHlvdSBhcmUgd2VsY29tZSB0byBjaGFuZ2UgaXQgYW5kL29yIGRpc3RyaWJ1dGUg Y29waWVzIG9mIGl0IHVuZGVyDQpjZXJ0YWluIGNvbmRpdGlvbnMuICBFbnRlciAiaGVscCBjb3B5 aW5nIiB0byBzZWUgdGhlIGNvbmRpdGlvbnMuDQpUaGlzIHByb2dyYW0gaGFzIGFic29sdXRlbHkg bm8gd2FycmFudHkuICBFbnRlciAiaGVscCB3YXJyYW50eSIgZm9yIGRldGFpbHMuDQoNCkdOVSBn ZGIgKEdEQikgNy42DQpDb3B5cmlnaHQgKEMpIDIwMTMgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9u LCBJbmMuDQpMaWNlbnNlIEdQTHYzKzogR05VIEdQTCB2ZXJzaW9uIDMgb3IgbGF0ZXIgPGh0dHA6 Ly9nbnUub3JnL2xpY2Vuc2VzL2dwbC5odG1sPg0KVGhpcyBpcyBmcmVlIHNvZnR3YXJlOiB5b3Ug YXJlIGZyZWUgdG8gY2hhbmdlIGFuZCByZWRpc3RyaWJ1dGUgaXQuDQpUaGVyZSBpcyBOTyBXQVJS QU5UWSwgdG8gdGhlIGV4dGVudCBwZXJtaXR0ZWQgYnkgbGF3LiAgVHlwZSAic2hvdyBjb3B5aW5n Ig0KYW5kICJzaG93IHdhcnJhbnR5IiBmb3IgZGV0YWlscy4NClRoaXMgR0RCIHdhcyBjb25maWd1 cmVkIGFzICJ4ODZfNjQtdW5rbm93bi1saW51eC1nbnUiLi4uDQoNCmNyYXNoOiBjYW5ub3QgZGV0 ZXJtaW5lIGJhc2Uga2VybmVsIHZlcnNpb24NCmNyYXNoOiAuLi92bWxpbnV4LTUuOC4wLTQ0LWdl bmVyaWMgYW5kIC4uL3h4eC5kbXAgZG8gbm90IG1hdGNoIQ0KDQoNCkFtIEkgZG9pbmcgc29tZXRo aW5nIHdyb25nPyBIb3cgZG8gSSBuZWVkIHRvIHVzZSBjcmFzaCBmb3IgaXQgdG8gd29yaz8NCg0K SWdvcg0K From xen-devel-bounces@lists.xenproject.org Wed Mar 10 20:32:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 20:32:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96296.182035 (Exim 4.92) (envelope-from ) id 1lK5Uh-0005Cv-3l; Wed, 10 Mar 2021 20:31:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96296.182035; Wed, 10 Mar 2021 20:31:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK5Uh-0005Co-0O; Wed, 10 Mar 2021 20:31:47 +0000 Received: by outflank-mailman (input) for mailman id 96296; Wed, 10 Mar 2021 20:31:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK5Uf-0005Cf-Gv; Wed, 10 Mar 2021 20:31:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK5Uf-0001nx-8g; Wed, 10 Mar 2021 20:31:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK5Ue-0001YI-V0; Wed, 10 Mar 2021 20:31:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lK5Ue-0003fx-UW; Wed, 10 Mar 2021 20:31:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QKKw8scvIfq7aJa12vccSGkKtSGCvEzT8KfKXVGQoDM=; b=AtU5TM06q8p7BreP1znv2eTksw l2ImyIsM95gyd0BySxOvBhFPLT62V5LqPxZKvd1G/UAjL4IeeuYMS2CGii2+hInfBI/eeeO4RI6e6 lXUMfRmndVcItMbS3ZAuWvJ/cKmlUSAmM/PaLZ5izg3LbTbsUdrNP35h6GArh9MCK2U8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159906: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=1b47cc852fd130ed9ce274a0f1600a4a62949a2c X-Osstest-Versions-That: xen=682edc95da4f0ffe8149b4651e5808c76d3a8987 From: osstest service owner Date: Wed, 10 Mar 2021 20:31:44 +0000 flight 159906 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/159906/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 159893 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail like 159893 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159893 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159893 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159893 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159893 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159893 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159893 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159893 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159893 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159893 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159893 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159893 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 1b47cc852fd130ed9ce274a0f1600a4a62949a2c baseline version: xen 682edc95da4f0ffe8149b4651e5808c76d3a8987 Last test of basis 159893 2021-03-09 15:07:43 Z 1 days Testing same since 159906 2021-03-10 08:20:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 682edc95da..1b47cc852f 1b47cc852fd130ed9ce274a0f1600a4a62949a2c -> master From xen-devel-bounces@lists.xenproject.org Wed Mar 10 20:48:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 20:48:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96305.182053 (Exim 4.92) (envelope-from ) id 1lK5kU-0006WN-N0; Wed, 10 Mar 2021 20:48:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96305.182053; Wed, 10 Mar 2021 20:48:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK5kU-0006WG-K6; Wed, 10 Mar 2021 20:48:06 +0000 Received: by outflank-mailman (input) for mailman id 96305; Wed, 10 Mar 2021 20:48:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK5kT-0006WB-IP for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 20:48:05 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a0e6379d-9352-4d1a-8335-43d6536368b4; Wed, 10 Mar 2021 20:48:04 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 5D27364FAF; Wed, 10 Mar 2021 20:48:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0e6379d-9352-4d1a-8335-43d6536368b4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615409283; bh=ojGzT8l9D92MEjIk+0sXh0dVACwtYQPkIDsUydDMuJ8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=j4kzH9EFYMNm8r4Hj5m+vrwNjH04rTJ89OxpeHXLuWHoNepUduGgWEky4O6jAKiCA WshFa7ZUSh7xRKKsxaTLa5hkVPgd+fF7089u/ILf6Vk/6QEmycrV8ix+fDQKN5+fgN ktmt7tCgw6FYlhDTn4Dffj3zJ4VU0nJv0M3n5UikGWX9Je+v0uWRU7XJev1vPbrIbs s4vstm0jwjxkPRQrpZgQquc/R3SzWCzN89odlTtXspCy7GFUJOyq671Wt2GjBcw9oF sFKP4Dwm3MHgzTXyZ0IbStEIl4eKlfQri9Ja0uFATtrtVxH4ShlmSyfJhTCjd0Gxvm 2LWdybwfWyoog== Date: Wed, 10 Mar 2021 12:48:02 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall cc: xen-devel@lists.xenproject.org, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) In-Reply-To: <20210306214148.27021-1-julien@xen.org> Message-ID: References: <20210306214148.27021-1-julien@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sat, 6 Mar 2021, Julien Grall wrote: > From: Julien Grall > > Compilers older than 4.8 have known codegen issues which can lead to > silent miscompilation: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 > > Furthermore, pre-4.9 GCC have known bugs (including things like > internal compiler errors on Arm) which would require workaround (I > haven't checked if we have any in Xen). > > The minimum version of GCC to build the hypervisor is now raised to 4.9. > > In addition to that, on arm64, GCC version >= 4.9 and < 5.1 have been > shown to emit memory references beyond the stack pointer, resulting in > memory corruption if an interrupt is taken after the stack pointer has > been adjusted but before the reference has been executed. > > Therefore, the minimum for arm64 is raised to 5.1. > > Signed-off-by: Julien Grall For the ARM part: Acked-by: Stefano Stabellini > --- > > I don't have a strong opinion on the minimum version for GCC on x86. > So this is following Andrew's suggestion and the minimum from Linux. > > This patch is candidate to 4.15 and backport. > > This is only a build change and will be low-risk for anyone using newer > compiler (5.1+ for arm64 and 4.9 for everyone else). Xen will stop > building for anyone using older compiler. But it is better than fighting > with codegen issues. > --- > README | 9 ++++++--- > xen/include/xen/compiler.h | 13 +++++++++++++ > 2 files changed, 19 insertions(+), 3 deletions(-) > > diff --git a/README b/README > index 8c99c30986c1..5c32c03f2ea1 100644 > --- a/README > +++ b/README > @@ -38,12 +38,15 @@ provided by your OS distributor: > * GNU Make v3.80 or later > * C compiler and linker: > - For x86: > - - GCC 4.1.2_20070115 or later > + - GCC 4.9 or later > - GNU Binutils 2.16.91.0.5 or later > or > - Clang/LLVM 3.5 or later > - - For ARM: > - - GCC 4.8 or later > + - For ARM 32-bit: > + - GCC 4.9 or later > + - GNU Binutils 2.24 or later > + - For ARM 64-bit: > + - GCC 5.1 or later > - GNU Binutils 2.24 or later > * Development install of zlib (e.g., zlib-dev) > * Development install of Python 2.6 or later (e.g., python-dev) > diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h > index 0ec0b4698ea7..46779660cc8f 100644 > --- a/xen/include/xen/compiler.h > +++ b/xen/include/xen/compiler.h > @@ -5,6 +5,19 @@ > #error Sorry, your compiler is too old/not recognized. > #endif > > +#if CONFIG_CC_IS_GCC > +# if CONFIG_GCC_VERSION < 40900 > +/* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ > +# error Sorry, your version of GCC is too old - please use 4.9 or newer. > +# elif defined(CONFIG_ARM_64) && CONFIG_GCC_VERSION < 50100 > +/* > + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 > + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk > + */ > +# error Sorry, your version of GCC is too old - please use 5.1 or newer. > +# endif > +#endif > + > #define barrier() __asm__ __volatile__("": : :"memory") > > #define likely(x) __builtin_expect(!!(x),1) From xen-devel-bounces@lists.xenproject.org Wed Mar 10 21:16:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 21:16:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96308.182066 (Exim 4.92) (envelope-from ) id 1lK6BU-0000pc-Kv; Wed, 10 Mar 2021 21:16:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96308.182066; Wed, 10 Mar 2021 21:16:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK6BU-0000pV-Ha; Wed, 10 Mar 2021 21:16:00 +0000 Received: by outflank-mailman (input) for mailman id 96308; Wed, 10 Mar 2021 21:15:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK6BT-0000pQ-50 for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 21:15:59 +0000 Received: from mail-qt1-x833.google.com (unknown [2607:f8b0:4864:20::833]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e60e7937-3016-49df-bc37-8dee613b6781; Wed, 10 Mar 2021 21:15:58 +0000 (UTC) Received: by mail-qt1-x833.google.com with SMTP id n26so5024073qtv.8 for ; Wed, 10 Mar 2021 13:15:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e60e7937-3016-49df-bc37-8dee613b6781 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zededa.com; s=google; h=mime-version:from:date:message-id:subject:to:cc; bh=9+waY9//i7aB7OCxxc58Mb5VgSwZAqQcRVQSVN1WFl0=; b=ch/ieljRNbjVMXTf65xR/pUCJAxjgWagarsfT5k4yq79eacuhr3d0Bfb9Tg6KxnuPJ hN1kClvaaku9tH1Mj09evdcxERTBiRVYiN7Jg2WFO0o9ajmor6keAxPHFrL6WcoGy1ye CIizxB3EBi1tDEbjLVg+2fdsGjEMI4Rcko7gSpxZffigl8KUXrYYdXCI3zXmdk+NmRFz ++MArghp3vnRXGrukcvGLYs7sRaZAJdEUIiQpHnP8DjMdOYIEx3ukwVfZkVWrP0UWeyu SQAbzzjWZ+2w6FTtIbmUkyBCpBydK9TauoGXJNrITwrNRVa53HlV8Cu1/3t2lrUBJS0B Jtiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=9+waY9//i7aB7OCxxc58Mb5VgSwZAqQcRVQSVN1WFl0=; b=qq8/tWqVb66mirN3FXCHn4gxt9SwBDyULrHuSVNz5PLnGn0L3dF2YaUZQ47mPHVPYZ OfruVi3NaBtExj5ftvgZLRk5YF/oLNeyKBG2OxV6KGs35S+zTJtpd9/JKHV3+/elaBOg 0Pc2bIMEi8PJBK1kgSQjJa4KUMwanH252YprabamQOUF3+WqXVUozprwZAR33OH/OJGD iOVUbW7UfnXzLejkLfC6yUprWaMH9tj/Lebku1kyA/248OWBj5bnPk7lGOM44IuLoShE /CmY7bTzKWELGjfPqzIIpWb5PAAHbWonSIGt4zCqK79ckuYvKPiyK2bVXWOaoRtMsrnv KBnw== X-Gm-Message-State: AOAM532tqh8c7CADmauDwqnGkKWm0FfNBsxcHfpwEFYB/gpRfjTMEVYR RybI8VU+PR5Yo1Q1X2p++pJ76TRHKCDNR9tkbrBGeL5fMW32zZqJ X-Google-Smtp-Source: ABdhPJwOzVz2Pty8qCzHwZ12CczBmmV6KORnOyD+JqoyKjFOMGJ11P2wY2S3v9XQYk72vo1gKVS6kTI6PpmG2yYIGg0= X-Received: by 2002:ac8:1403:: with SMTP id k3mr4703702qtj.266.1615410957845; Wed, 10 Mar 2021 13:15:57 -0800 (PST) MIME-Version: 1.0 From: Roman Shaposhnik Date: Wed, 10 Mar 2021 13:15:46 -0800 Message-ID: Subject: Xen 4.14 build failing on aarch64 with GCC 10.2.1 To: Xen-devel Cc: Julien Grall , Stefano Stabellini , Stefano Stabellini Content-Type: text/plain; charset="UTF-8" Hi! just came across this failure on aarch64: ld: prelink.o: in function `_spin_lock_cb': 19187(.text+0x1f26c): undefined reference to `__aarch64_ldadd4_acq_rel' 19188ld: prelink.o: in function `_spin_lock': 19189(.text+0x1f2ec): undefined reference to `__aarch64_ldadd4_acq_rel' 19190ld: prelink.o: in function `_spin_lock_irq': 19191(.text+0x1f35c): undefined reference to `__aarch64_ldadd4_acq_rel' 19192ld: prelink.o: in function `_spin_lock_irqsave': 19193(.text+0x1f3d4): undefined reference to `__aarch64_ldadd4_acq_rel' 19194ld: prelink.o: in function `_spin_lock_recursive': 19195(.text+0x1f6b0): undefined reference to `__aarch64_ldadd4_acq_rel' This, of course, goes away if I build Xen with: CFLAGS=-mno-outline-atomics However, at this point I'm curious if this is going to get addressed in Xen proper or not. Thanks, Roman. From xen-devel-bounces@lists.xenproject.org Wed Mar 10 21:41:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 21:41:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96311.182078 (Exim 4.92) (envelope-from ) id 1lK6Ze-0003Y8-N7; Wed, 10 Mar 2021 21:40:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96311.182078; Wed, 10 Mar 2021 21:40:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK6Ze-0003Y1-Jd; Wed, 10 Mar 2021 21:40:58 +0000 Received: by outflank-mailman (input) for mailman id 96311; Wed, 10 Mar 2021 21:40:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK6Zd-0003Xw-Ga for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 21:40:57 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4a31c3e4-121d-4c83-8697-8ca6b797bd45; Wed, 10 Mar 2021 21:40:55 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id B7BBC64FD6 for ; Wed, 10 Mar 2021 21:40:54 +0000 (UTC) Received: by mail-qt1-f177.google.com with SMTP id d11so14252870qtx.9 for ; Wed, 10 Mar 2021 13:40:54 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a31c3e4-121d-4c83-8697-8ca6b797bd45 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615412454; bh=lljbEm8y6jNcxvIMoB+J261BTyFdid0U0j/1mSpgrns=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=eDXX9I0rBca4D2age7wm+DtVv6geacxhoDXnt5SysKVhym9aYBoOULiDV+ts4rOLP jxqSr5B0vX0/o/NShM/j+kwlnb4hGRATSr0mEhy2fTgb4b/f9TFkN0sucrguP/wUnN VpsdkpA2+bkS7oY10zU2zq+j59iH8lNhIYLI61shYJGWLghrHuyig30tcjLo3fTgbB 3DEVFLncbcg+C2B9HtVOo3SUvsmkNa+xgZXWZi3ZI5a2G3Gno+oUiLdB0wFYwj7D9V li5Sma9VH3O9evfauK7N3UwWSXURG5BK+1LBH0BYK5Vbx589vAqinspwZjQAwTmkXH mjJKT2LCYnF3Q== X-Gm-Message-State: AOAM533xQqmKjpjvGpHhhd4e9D9o1KGB5HEXeqnGFrRi34C+R0+N7WdE YWH61Jp5K4jBvqAjUW9+WVufP/96wr8URiXcjA== X-Google-Smtp-Source: ABdhPJwvOHv4sjXRoS+j4qWhL9MVaGJgYMXKyxBDilpUrwUXgxjhTnULwJ7kIho0KdWOn0m+qzW6exxxNwLS3x7GxZU= X-Received: by 2002:a05:620a:1001:: with SMTP id z1mr4659415qkj.364.1615412453005; Wed, 10 Mar 2021 13:40:53 -0800 (PST) MIME-Version: 1.0 References: <20210209062131.2300005-1-tientzu@chromium.org> <20210209062131.2300005-14-tientzu@chromium.org> <20210310160747.GA29834@willie-the-truck> In-Reply-To: <20210310160747.GA29834@willie-the-truck> From: Rob Herring Date: Wed, 10 Mar 2021 14:40:41 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 13/14] dt-bindings: of: Add restricted DMA pool To: Will Deacon Cc: Claire Chang , Michael Ellerman , Joerg Roedel , Frank Rowand , Konrad Rzeszutek Wilk , Boris Ostrovsky , Juergen Gross , Christoph Hellwig , Marek Szyprowski , Benjamin Herrenschmidt , Paul Mackerras , "list@263.net:IOMMU DRIVERS" , Stefano Stabellini , Robin Murphy , Grant Likely , Heinrich Schuchardt , Thierry Reding , Ingo Molnar , Thiago Jung Bauermann , Peter Zijlstra , Greg KH , Saravana Kannan , "Rafael J . Wysocki" , Heikki Krogerus , Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev , xen-devel , Nicolas Boichat , Jim Quinlan Content-Type: text/plain; charset="UTF-8" On Wed, Mar 10, 2021 at 9:08 AM Will Deacon wrote: > > Hi Claire, > > On Tue, Feb 09, 2021 at 02:21:30PM +0800, Claire Chang wrote: > > Introduce the new compatible string, restricted-dma-pool, for restricted > > DMA. One can specify the address and length of the restricted DMA memory > > region by restricted-dma-pool in the reserved-memory node. > > > > Signed-off-by: Claire Chang > > --- > > .../reserved-memory/reserved-memory.txt | 24 +++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt > > index e8d3096d922c..fc9a12c2f679 100644 > > --- a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt > > +++ b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt > > @@ -51,6 +51,20 @@ compatible (optional) - standard definition > > used as a shared pool of DMA buffers for a set of devices. It can > > be used by an operating system to instantiate the necessary pool > > management subsystem if necessary. > > + - restricted-dma-pool: This indicates a region of memory meant to be > > + used as a pool of restricted DMA buffers for a set of devices. The > > + memory region would be the only region accessible to those devices. > > + When using this, the no-map and reusable properties must not be set, > > + so the operating system can create a virtual mapping that will be used > > + for synchronization. The main purpose for restricted DMA is to > > + mitigate the lack of DMA access control on systems without an IOMMU, > > + which could result in the DMA accessing the system memory at > > + unexpected times and/or unexpected addresses, possibly leading to data > > + leakage or corruption. The feature on its own provides a basic level > > + of protection against the DMA overwriting buffer contents at > > + unexpected times. However, to protect against general data leakage and > > + system memory corruption, the system needs to provide way to lock down > > + the memory access, e.g., MPU. > > As far as I can tell, these pools work with both static allocations (which > seem to match your use-case where firmware has preconfigured the DMA ranges) > but also with dynamic allocations where a 'size' property is present instead > of the 'reg' property and the kernel is responsible for allocating the > reservation during boot. Am I right and, if so, is that deliberate? I believe so. I'm not keen on having size only reservations in DT. Yes, we allowed that already, but that's back from the days of needing large CMA carveouts to be reserved early in boot. I've read that the kernel is much better now at contiguous allocations, so do we really need this in DT anymore? > I ask because I think that would potentially be useful to us for the > Protected KVM work, where we need to bounce virtio memory accesses via > guest-determined windows because the guest memory is generally inaccessible > to the host. We've been hacking this using a combination of "swiotlb=force" > and set_memory_{decrypted,encrypted}() but it would be much better to > leverage the stuff you have here. > > Also: > > > + > > + restricted_dma_mem_reserved: restricted_dma_mem_reserved { > > + compatible = "restricted-dma-pool"; > > + reg = <0x50000000 0x400000>; > > + }; > > }; > > > > /* ... */ > > @@ -138,4 +157,9 @@ one for multimedia processing (named multimedia-memory@77000000, 64MiB). > > memory-region = <&multimedia_reserved>; > > /* ... */ > > }; > > + > > + pcie_device: pcie_device@0,0 { > > + memory-region = <&restricted_dma_mem_reserved>; > > + /* ... */ > > + }; > > I find this example a bit weird, as I didn't think we usually had DT nodes > for PCI devices; rather they are discovered as a result of probing config > space. Is the idea that you have one reserved memory region attached to the > RC and all the PCI devices below that share the region, or is there a need > for a mapping mechanism? We can have DT nodes for PCI. AIUI, IBM power systems always do. For FDT, it's only if there are extra non-discoverable resources. It's particularly fun when it's resources which need to be enabled for the PCI device to be discovered. That seems to be a growing problem as PCI becomes more common on embedded systems. Rob From xen-devel-bounces@lists.xenproject.org Wed Mar 10 23:15:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 10 Mar 2021 23:15:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96318.182096 (Exim 4.92) (envelope-from ) id 1lK82r-0003M4-JW; Wed, 10 Mar 2021 23:15:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96318.182096; Wed, 10 Mar 2021 23:15:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK82r-0003Lx-GQ; Wed, 10 Mar 2021 23:15:13 +0000 Received: by outflank-mailman (input) for mailman id 96318; Wed, 10 Mar 2021 23:15:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lK82q-0003Ls-Ew for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 23:15:12 +0000 Received: from mail-ed1-x52f.google.com (unknown [2a00:1450:4864:20::52f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id de0214ea-2e33-4f2f-a347-2035e4f2f7d5; Wed, 10 Mar 2021 23:15:11 +0000 (UTC) Received: by mail-ed1-x52f.google.com with SMTP id y6so8150eds.1 for ; Wed, 10 Mar 2021 15:15:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de0214ea-2e33-4f2f-a347-2035e4f2f7d5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i/gGoI82isxh2Pj6ZZVCBtGI/GKRIG+++nG/qLnmSrk=; b=PnNQIXzMLgGrbA9lu6mrkyF5/SGpO4vzuXaVVwc1OjWQJ7vHnHs6acdWXT3HaZy6Yq bTQfbJpKHt4W+AiauhewpFQIkVMcWgN26+5SAm1c7v0vF5nGwg3UvkXjaXyN+UN6ZZkZ MuQ+LFnaXp3is0FopRjvZ1pb1VUxy+qtjwD3VGJdMfYjSDvyQbZwiZDDMokbNgf0Bi1S IgMKOyNMUoU4VIHKabubcmh+wmm/HcoFgZdrmX5dxI5RmazQW+J7mcoe+0nqEWZ1EeJ1 RtRjY7mgFVmMYHlMLmTzcYkzmhh0V77YITJd38l1Lw1CC5fvm5e9VjQaU3TwXqaGc9Ar EXMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i/gGoI82isxh2Pj6ZZVCBtGI/GKRIG+++nG/qLnmSrk=; b=Vf3vIqWzfUJaTYmGgiWzpKeu2/urgCtVIrFHdHs6MXxqpLek1RgwpFwYYUJCgwQaDs TltaGn4PuJ/OPUCQqX5NIrwSRszZ4me3QOvYVEstwqohM2Mi9Fv3mR2crY0cE8LoD5jJ QVsg1PdCG46vkfQfsO9yXEw0YKyA1PgQFnZbBO4t7OR7A6+bpLHLka68FWZlp/XfaacP r84jbO5MRRwfLoxjx8Woi1A+1sYbIaGZRm9rVwDhCmcOydjT5iwaBDulm2Wr9MG/ljga dir7Pa4vR9DaUb+hzaheXg7sYihnrxsEIkyqdkm8a8+opfjoAI2d3wl461wUArcG2OFf 8v7w== X-Gm-Message-State: AOAM530EmOSzHrMeE35r/YcxwqjX++7QO7D7q0I/dgCwOam439S7ZGeK Nndt1adhKJify65VxOmHYnwgyU0gZYaac9SMuX4= X-Google-Smtp-Source: ABdhPJxxOj+2niVJ5YgsAIpGwnV14zXuvbZWmJZ6uNRvwZMXuzyZCS0vxkG8BlEcTbc9auRbvWOwse+wnHoMhhcIcxc= X-Received: by 2002:a50:ec0e:: with SMTP id g14mr5841285edr.264.1615418110693; Wed, 10 Mar 2021 15:15:10 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Julien Grall Date: Wed, 10 Mar 2021 23:14:59 +0000 Message-ID: Subject: Re: Xen 4.14 build failing on aarch64 with GCC 10.2.1 To: Roman Shaposhnik Cc: Xen-devel , Stefano Stabellini , Stefano Stabellini Content-Type: text/plain; charset="UTF-8" On Wed, 10 Mar 2021 at 21:15, Roman Shaposhnik wrote: > > Hi! Hi, > > just came across this failure on aarch64: > > ld: prelink.o: in function `_spin_lock_cb': > 19187(.text+0x1f26c): undefined reference to `__aarch64_ldadd4_acq_rel' > 19188ld: prelink.o: in function `_spin_lock': > 19189(.text+0x1f2ec): undefined reference to `__aarch64_ldadd4_acq_rel' > 19190ld: prelink.o: in function `_spin_lock_irq': > 19191(.text+0x1f35c): undefined reference to `__aarch64_ldadd4_acq_rel' > 19192ld: prelink.o: in function `_spin_lock_irqsave': > 19193(.text+0x1f3d4): undefined reference to `__aarch64_ldadd4_acq_rel' > 19194ld: prelink.o: in function `_spin_lock_recursive': > 19195(.text+0x1f6b0): undefined reference to `__aarch64_ldadd4_acq_rel' > > This, of course, goes away if I build Xen with: > CFLAGS=-mno-outline-atomics > > However, at this point I'm curious if this is going to get addressed in Xen > proper or not. This has already been fixed and backported to Xen 4.14 (included in 4.14.1). Are you using the latest 4.14 branch? Cheers, From xen-devel-bounces@lists.xenproject.org Thu Mar 11 02:41:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 02:41:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96326.182120 (Exim 4.92) (envelope-from ) id 1lKBFz-0008DF-M7; Thu, 11 Mar 2021 02:40:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96326.182120; Thu, 11 Mar 2021 02:40:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKBFz-0008D8-ID; Thu, 11 Mar 2021 02:40:59 +0000 Received: by outflank-mailman (input) for mailman id 96326; Thu, 11 Mar 2021 02:40:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKBFy-0008D3-Ta for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 02:40:59 +0000 Received: from mga02.intel.com (unknown [134.134.136.20]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1192f5cd-4e1e-4515-8508-e3e606c46966; Thu, 11 Mar 2021 02:40:56 +0000 (UTC) Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 18:40:54 -0800 Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 10 Mar 2021 18:40:54 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 10 Mar 2021 18:40:54 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 10 Mar 2021 18:40:54 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 10 Mar 2021 18:40:54 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 10 Mar 2021 18:40:53 -0800 Received: from BN6PR11MB1875.namprd11.prod.outlook.com (2603:10b6:404:104::11) by BN6PR11MB1876.namprd11.prod.outlook.com (2603:10b6:404:ff::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Thu, 11 Mar 2021 02:40:52 +0000 Received: from BN6PR11MB1875.namprd11.prod.outlook.com ([fe80::90ec:1b70:5912:9849]) by BN6PR11MB1875.namprd11.prod.outlook.com ([fe80::90ec:1b70:5912:9849%4]) with mapi id 15.20.3912.030; Thu, 11 Mar 2021 02:40:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1192f5cd-4e1e-4515-8508-e3e606c46966 IronPort-SDR: vw1POjGvmW8LpC93zxO67us6CGhtSdnfoSgyTDj6TjBS089gEDTCNhYv8yN9Hos0DE4fmJ1I87 92QWkQaLG4/g== X-IronPort-AV: E=McAfee;i="6000,8403,9919"; a="175708783" X-IronPort-AV: E=Sophos;i="5.81,238,1610438400"; d="scan'208";a="175708783" IronPort-SDR: ylBhABGwZSI6FBfpgwEN5zrGchEdqpV07EAR+ZZqTA2w//ojiQq5l0pM2pI2pKIh6LU4NQ/vXJ +RJRyViz1sWQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,238,1610438400"; d="scan'208";a="372179054" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K5+QAv48N3ynlHXLoSuVrWcm+lAQYkk/ASHoLWmL/nusAyVgiZdmKrFyI2nNhtq7ZTDM6IGfAu++xaIyMYPDj2wInomxVaIzoYirLfRAn7SBbpU/F8cgPbuiHcUA/nFhCAfC+70bxiLXYS+L5O8e6sHmSRQFLOKyPtsNMR2mZb1xGHLV1PW/1xeWPnl9lfN/diW8men/2Rom5Ris6N6nqxU5lW2X0C1UJ4aYLJYkyA7EdVx+PG+CwQzYL6dE59PaArGztcoJFPnW9OWULyjQnftro2chyBf8/nrqW/BitIMudZkSa+ZyTrgpkeDzMyWDpp3Y8KChkKywuLUmEgKlrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J4iXIGfX03N97NoGYLbSJLmjOCG1peSV2LSXtX6XFfw=; b=fU8YW6eSzFjjAILJLWDgBQHy2uNYNZ/GQZmVf+XJAUlehmgLG+9yIFFsMJ8qwLlZRQ+Eu4MnCGUi5BoRDC5WxOwgkw+148RI1/qbtLk2jZBR7W1w1Wv3yPgION5UG2FwNn541vWdAsGQED8lgQ6iOL4SpykPKLWRlDJ9bExgfL8gPNdskEnIjHr0m6tOCX3/7PxE5pnF+DRv6wNLwC4zVZWlDlq4UPh9a6nIAWbTw5OYCDKbqAjswqt8b7A4n1a73PptCCKtCgPQqAVWdxS48cUCqbYfyMrZsV1R5w0BJXxkIAuEui6iKLnP2I0LOCqM4sSsz3R7M60blzMiVtzsUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J4iXIGfX03N97NoGYLbSJLmjOCG1peSV2LSXtX6XFfw=; b=MWNf0fOhurrtDKiVEbE2XHkL/B8eTnD7LKsFnXxg50pyV+awxLQa28mULX1RZ/guAXH0erN7j2rW7tNWRJ3wXeT0XPa5GqsHPSrAr86SSPbuqnH0sfSVVSen8fTFGX6AacvnQRpULWFsxdQQLN2VyaiOrvV/9QmSd3SxqUGbSXA= From: "Tian, Kevin" To: Igor Druzhinin , "xen-devel@lists.xenproject.org" CC: "jbeulich@suse.com" , "Cooper, Andrew" , "roger.pau@citrix.com" , "wl@xen.org" Subject: RE: [PATCH for-4.15] vtd: make sure QI/IR are disabled before initialisation Thread-Topic: [PATCH for-4.15] vtd: make sure QI/IR are disabled before initialisation Thread-Index: AQHXE+l+DcjZa4vV7kWyWy/YUMLF56p+F/Gw Date: Thu, 11 Mar 2021 02:40:52 +0000 Message-ID: References: <1615186802-5908-1-git-send-email-igor.druzhinin@citrix.com> In-Reply-To: <1615186802-5908-1-git-send-email-igor.druzhinin@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.213] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3100a907-5479-497e-9077-08d8e4371657 x-ms-traffictypediagnostic: BN6PR11MB1876: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: S9R6DeMGLAvwn1zlAyE83F9c+GrYSMhJ8gGn/spuw0gHZTTJFz3KrdymQgJ4Ne4GPaaPLu7uvosUo8Z6u8OYH2F7h7jrPqlcL8pDrwbRru9r0krF5N3hJY3cQJVw+o4MPfBkTGO6HHpXMXYT6A8tCEeMoh6mUz4U+bIkpIIVMvOplgpa1sPsP5LgAx4U6z3CTL4b//MNVM9Po4cslagcfrYzKSkpYu+VqPMAUpSVP/aztNE61IlXmm+Xo7Myr/JFVXf+aLOoVu4/R2v3Vz/tPno1JkfkV1kfgNpxJGvZlvXJNP3KmwTtPl4WxZvr0+jyk0bp5AoJrBnNTs7fPKxfCMyprNDxfG4oM/DADQerFYJnVUQSJEiOGj57bW9juiGHj5DLSnXUgHr2Jw6n94Bp8APbRb+9XcKiGpyuVOdC38qIDW7yci0jRQiiaIIjky06LVBMgtbbcnCR3Spn3GVSgY8n1WmTMJIAB9QK6MKhH850jOs/K7SZzYaDhgcj3lpPQFWGYtyNAlCgFuOzaUO9Iw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1875.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(366004)(396003)(346002)(39860400002)(376002)(54906003)(33656002)(9686003)(8676002)(4326008)(2906002)(86362001)(26005)(83380400001)(5660300002)(55016002)(316002)(66446008)(66946007)(8936002)(64756008)(66556008)(76116006)(186003)(66476007)(6506007)(52536014)(110136005)(7696005)(478600001)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ONmk5lNZ+uo7qA2znfqxP/9GmhVcUK1IHpdFt1Tm1JPyFXSx5zIDUqqyAXn+?= =?us-ascii?Q?qAqrVxTCE5uJhIyKUjXmIONwzp/ZE4b0V9oOcWrgFBwSPcvBjTFUBcLKIG/x?= =?us-ascii?Q?bkveG/6WsFLRA2rffmm4wwWyoB17hdLxBEn+szShXSIbwRdLd8m235RM69Qm?= =?us-ascii?Q?kSAafkdhSu+4fqGk1selpjcHKTg59T93uFOPdHbn2U7HB/n92up+rfik9tbW?= =?us-ascii?Q?bbi8s9H40TQ12wZGdSU5CWi09RkL0VX/TtZTHNAZPOeAxaPTzddm7KyIgnH8?= =?us-ascii?Q?Gl/HH2zhgP80Ko3XQQDVW5kumCJwk0JXkVBGORkxNIH75KO6ovR/zwYcPKEC?= =?us-ascii?Q?NzF2aJYjBLfV618zcLmD5/9aCV7CZHwDu8PZ9atKpPALzsqOVBjlRc2a+7Pj?= =?us-ascii?Q?CPU0AjbtCpZnMrmqhkMSg6LdWIjgGDsyGLqLeFG3Td0W46YbiPp+vYfmU0hD?= =?us-ascii?Q?ozAgtVa4wUO6P2jCv7BmyhT/uoKsFtyF77ILlt6m2pAQy8Wwsz5MNixo/bhb?= =?us-ascii?Q?QbynVVHb7Yx3iYxg1L32jKqf7lMFrGs+x2Arwe2r8nYrRVN4rpZokymWg/jr?= =?us-ascii?Q?MaCbDj4wOTj/Hq8MiONQxkan9QgBPBXw5h9RqkSB2akTfzFJTnUgKTT0f167?= =?us-ascii?Q?f4du6j+Zjel3adp7j511lFd8+kL4FFEO2eWZVrykVqHWX2hZXvc3/dD7kxPX?= =?us-ascii?Q?v2+PdomeGD8DFnzCT08Re/UQC58MyarH4pLH/OzdnUynfXZi3Q6GDjI8OJYJ?= =?us-ascii?Q?6yDLruuMOlsr7zJDzvGGHXegQ0gWh5rc2/URV6Fr9rFPjHW5vX1atD4wbLmX?= =?us-ascii?Q?scEaYFAx3u0Rs4bQ7+5XAzp11DXwL8I7PBW1eNk+sZM1MYWjFNx6ZfMyrONL?= =?us-ascii?Q?/wRgbw8GCFVprGJxeX7JT/nbStD9n2XDiRl44kFiwupNuLwOxzqCB70/kfMB?= =?us-ascii?Q?yi0Ofwn1d2xaRzpUJ2VUKyj40xFIcxbjNrSyRIkBYQUqSiMqJanuPktbIann?= =?us-ascii?Q?corouGVUSG4dWp8JQqGwYbSXxto5CssH/ZnFPqh5SrgT0Z+v3mtdOLDuFCnO?= =?us-ascii?Q?oBwFG4Eqh4GLAk57Hm00gclDptAoCbz+4KBeVwG5yjID4Y9ReEdpiAAS69cD?= =?us-ascii?Q?zMjfcG8JmxW54mDaOjdm7dttjtOFZ+5sTrlDdV+AEbL5OcGnqLmjMj2oFFJz?= =?us-ascii?Q?DxXoYBg9mT2RsTCo+bA2fEFfnHfyKPuQVxP+s0rEQPYazJlNn695dH8l040L?= =?us-ascii?Q?yM85VFCa2FKM4yREgzt4UiObKZlssuRXd5bzYKZ5V5A8qxjD8ZUwqMahb8R/?= =?us-ascii?Q?UDBEW3gG1KAS2mWjHCxCadIY?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1875.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3100a907-5479-497e-9077-08d8e4371657 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2021 02:40:52.1127 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: icJxJaWwkgAaYlXUicVQ7DEICrnL8gnMTgpNs9124N4vamgmXF8NKg7YyIMaGmELAEMd+pj9ZOOVe8krhlFtTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1876 X-OriginatorOrg: intel.com > From: Igor Druzhinin > Sent: Monday, March 8, 2021 3:00 PM >=20 > BIOS might pass control to Xen leaving QI and/or IR in enabled and/or > partially configured state. In case of x2APIC code path where EIM is > enabled early in boot - those are correctly disabled by Xen before any > attempt to configure. But for xAPIC that step is missing which was > proven to cause QI initialization failures on some ICX based platforms > where QI is left pre-enabled and partially configured by BIOS. >=20 > Unify the behaviour between x2APIC and xAPIC code paths keeping that in > line with what Linux does. >=20 > Signed-off-by: Igor Druzhinin Reviewed-by: Kevin Tian > --- > xen/arch/x86/apic.c | 2 +- > xen/drivers/passthrough/vtd/iommu.c | 12 +++++++++++- > xen/include/asm-x86/apic.h | 1 + > 3 files changed, 13 insertions(+), 2 deletions(-) >=20 > diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c > index 7497ddb..8ab8214 100644 > --- a/xen/arch/x86/apic.c > +++ b/xen/arch/x86/apic.c > @@ -47,7 +47,7 @@ static bool __read_mostly tdt_enabled; > static bool __initdata tdt_enable =3D true; > boolean_param("tdt", tdt_enable); >=20 > -static bool __read_mostly iommu_x2apic_enabled; > +bool __read_mostly iommu_x2apic_enabled; >=20 > static struct { > int active; > diff --git a/xen/drivers/passthrough/vtd/iommu.c > b/xen/drivers/passthrough/vtd/iommu.c > index d136fe3..4aa7a31 100644 > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -2080,7 +2080,7 @@ static int __must_check init_vtd_hw(void) > u32 sts; >=20 > /* > - * Basic VT-d HW init: set VT-d interrupt, clear VT-d faults. > + * Basic VT-d HW init: set VT-d interrupt, clear VT-d faults, etc. > */ > for_each_drhd_unit ( drhd ) > { > @@ -2090,6 +2090,16 @@ static int __must_check init_vtd_hw(void) >=20 > clear_fault_bits(iommu); >=20 > + /* > + * Disable interrupt remapping and queued invalidation if > + * already enabled by BIOS in case we've not initialized it yet. > + */ > + if ( !iommu_x2apic_enabled ) > + { > + disable_intremap(iommu); > + disable_qinval(iommu); > + } > + > spin_lock_irqsave(&iommu->register_lock, flags); > sts =3D dmar_readl(iommu->reg, DMAR_FECTL_REG); > sts &=3D ~DMA_FECTL_IM; > diff --git a/xen/include/asm-x86/apic.h b/xen/include/asm-x86/apic.h > index 8ddb896..2fe54bb 100644 > --- a/xen/include/asm-x86/apic.h > +++ b/xen/include/asm-x86/apic.h > @@ -24,6 +24,7 @@ enum apic_mode { > APIC_MODE_X2APIC /* x2APIC mode - common for large MP machines > */ > }; >=20 > +extern bool iommu_x2apic_enabled; > extern u8 apic_verbosity; > extern bool directed_eoi_enabled; >=20 > -- > 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 03:10:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 03:10:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96331.182131 (Exim 4.92) (envelope-from ) id 1lKBih-0002bS-6b; Thu, 11 Mar 2021 03:10:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96331.182131; Thu, 11 Mar 2021 03:10:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKBih-0002bL-3c; Thu, 11 Mar 2021 03:10:39 +0000 Received: by outflank-mailman (input) for mailman id 96331; Thu, 11 Mar 2021 03:10:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKBif-0002bD-GE; Thu, 11 Mar 2021 03:10:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKBif-0002ag-7k; Thu, 11 Mar 2021 03:10:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKBie-00035s-UR; Thu, 11 Mar 2021 03:10:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKBie-0006CV-Tx; Thu, 11 Mar 2021 03:10:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4iovz48nN9Vu8KhBAldfyopB8WWAKtt4/BCHg4tsKXw=; b=LgkvuxYz/kEBIuIriPHVkFCj6z rJEwX171Zs3myCLyc+FDl4RnBzZgx21/0uCfIZZ8x+esseCqIKMHayxtFohaF5ZewccFQdI/YmAzb ymyfXMxJOnXYh/ScN7FieMWuF9fiPKx2g5vytJ9mOAvgHl+HRFd5UGZjNWh1hApVEe1c=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159911: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=a557b00469bca61a058fc1db4855503cac1c3219 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Thu, 11 Mar 2021 03:10:36 +0000 flight 159911 qemu-mainline real [real] flight 159923 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159911/ http://logs.test-lab.xenproject.org/osstest/logs/159923/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail pass in 159923-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu a557b00469bca61a058fc1db4855503cac1c3219 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 202 days Failing since 152659 2020-08-21 14:07:39 Z 201 days 387 attempts Testing same since 159911 2021-03-10 11:47:28 Z 0 days 1 attempts ------------------------------------------------------------ 439 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 123237 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 11 05:05:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 05:05:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96340.182152 (Exim 4.92) (envelope-from ) id 1lKDVD-0004l2-Mz; Thu, 11 Mar 2021 05:04:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96340.182152; Thu, 11 Mar 2021 05:04:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKDVD-0004kv-K0; Thu, 11 Mar 2021 05:04:51 +0000 Received: by outflank-mailman (input) for mailman id 96340; Thu, 11 Mar 2021 05:04:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKDVB-0004kq-LE for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 05:04:49 +0000 Received: from mail-pj1-x102f.google.com (unknown [2607:f8b0:4864:20::102f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ac8a017a-c856-4598-b349-fcfbcd7c63a3; Thu, 11 Mar 2021 05:04:48 +0000 (UTC) Received: by mail-pj1-x102f.google.com with SMTP id bt4so2861173pjb.5 for ; Wed, 10 Mar 2021 21:04:48 -0800 (PST) Received: from [10.230.29.30] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y2sm979638pgf.7.2021.03.10.21.04.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Mar 2021 21:04:47 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac8a017a-c856-4598-b349-fcfbcd7c63a3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eayOjb0KZ31qj1N8PdToC+xRVUBfCHUPI3Znks8WR0k=; b=IL1N7vM7p9PzFcfpvhgRRMuOzhmjBlfibWkIcOQbYlGbPOJMnLhIzjCy8LxBaJ8EGU KJjjEgkbLtjbaD4sqhZ1ochG6cVFghEOlubEd7dsbfPijX8lC9eVqiLaeiTO3VXqhE5j YprOjLc8isTrNz1yxLNXa7sz1Bhn0z1t0w+HJ0pPJUXLLao5DKoPWk0aWURYin4FB6OE oTFCyRJLtkVFf3JLLGhSJTXk7wLVT433snzVLTFp5sM2sqXb87myqAsWS9pqaTfVDExL f+ojkMFllNvYboAo4xsrXYacF/clYDZcJc779Ph0MFvl0b3brsNawqyYAhHoxSZKsU/v mTBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eayOjb0KZ31qj1N8PdToC+xRVUBfCHUPI3Znks8WR0k=; b=HoxkdiJH2vwc59gmSIJlkgCxjN0jVPXcKAbmJyCR/AAh1mFSURLy5PReFpAl+hBxSa JkIRlTp/DPpAK5+ygjP6iFtfklxIAZ3uRUEt/0nfC7vTzBSNbYP5ntf4eZa+816x/rE2 9Cz5oDNsFtPNUeiwfEoXmJ1kpGY/I6b9wtbi4MOjSTa5E8gETLn/6F5HLOn9GsP++n27 5RwDm6mjiJ3UDaEjW1D2CShGgpDKzZljsuDDj1japIRRxjUky99skLDu2yvig0APHNOC qKxePRgL5isv6f1hM3dvrs4Q+HS23WkrubnAkZN3YlWfgp0+6+bBmorKxRnYFL+FSK9E OAYQ== X-Gm-Message-State: AOAM531AzCDY7uNObxNalECda//3HpOr2x+zdqOYD49f/JToEw67HOt7 Hocr0ZQpZVrZ7Syv52NBwpQ= X-Google-Smtp-Source: ABdhPJzomvd6XDgwv/fL+vlX+FLEQgGyCWkzPbL90UL/BQndPGhzKH0Q4L/hjqK/fMjpcf3zxKU3vg== X-Received: by 2002:a17:90a:a403:: with SMTP id y3mr7078020pjp.227.1615439087609; Wed, 10 Mar 2021 21:04:47 -0800 (PST) Subject: Re: [PATCH v4 13/14] dt-bindings: of: Add restricted DMA pool To: Rob Herring , Will Deacon Cc: Claire Chang , Michael Ellerman , Joerg Roedel , Frank Rowand , Konrad Rzeszutek Wilk , Boris Ostrovsky , Juergen Gross , Christoph Hellwig , Marek Szyprowski , Benjamin Herrenschmidt , Paul Mackerras , "list@263.net:IOMMU DRIVERS" , Stefano Stabellini , Robin Murphy , Grant Likely , Heinrich Schuchardt , Thierry Reding , Ingo Molnar , Thiago Jung Bauermann , Peter Zijlstra , Greg KH , Saravana Kannan , "Rafael J . Wysocki" , Heikki Krogerus , Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev , xen-devel , Nicolas Boichat , Jim Quinlan References: <20210209062131.2300005-1-tientzu@chromium.org> <20210209062131.2300005-14-tientzu@chromium.org> <20210310160747.GA29834@willie-the-truck> From: Florian Fainelli Message-ID: Date: Wed, 10 Mar 2021 21:04:42 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/10/2021 1:40 PM, Rob Herring wrote: > On Wed, Mar 10, 2021 at 9:08 AM Will Deacon wrote: >> >> Hi Claire, >> >> On Tue, Feb 09, 2021 at 02:21:30PM +0800, Claire Chang wrote: >>> Introduce the new compatible string, restricted-dma-pool, for restricted >>> DMA. One can specify the address and length of the restricted DMA memory >>> region by restricted-dma-pool in the reserved-memory node. >>> >>> Signed-off-by: Claire Chang >>> --- >>> .../reserved-memory/reserved-memory.txt | 24 +++++++++++++++++++ >>> 1 file changed, 24 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt >>> index e8d3096d922c..fc9a12c2f679 100644 >>> --- a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt >>> +++ b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt >>> @@ -51,6 +51,20 @@ compatible (optional) - standard definition >>> used as a shared pool of DMA buffers for a set of devices. It can >>> be used by an operating system to instantiate the necessary pool >>> management subsystem if necessary. >>> + - restricted-dma-pool: This indicates a region of memory meant to be >>> + used as a pool of restricted DMA buffers for a set of devices. The >>> + memory region would be the only region accessible to those devices. >>> + When using this, the no-map and reusable properties must not be set, >>> + so the operating system can create a virtual mapping that will be used >>> + for synchronization. The main purpose for restricted DMA is to >>> + mitigate the lack of DMA access control on systems without an IOMMU, >>> + which could result in the DMA accessing the system memory at >>> + unexpected times and/or unexpected addresses, possibly leading to data >>> + leakage or corruption. The feature on its own provides a basic level >>> + of protection against the DMA overwriting buffer contents at >>> + unexpected times. However, to protect against general data leakage and >>> + system memory corruption, the system needs to provide way to lock down >>> + the memory access, e.g., MPU. >> >> As far as I can tell, these pools work with both static allocations (which >> seem to match your use-case where firmware has preconfigured the DMA ranges) >> but also with dynamic allocations where a 'size' property is present instead >> of the 'reg' property and the kernel is responsible for allocating the >> reservation during boot. Am I right and, if so, is that deliberate? > > I believe so. I'm not keen on having size only reservations in DT. > Yes, we allowed that already, but that's back from the days of needing > large CMA carveouts to be reserved early in boot. I've read that the > kernel is much better now at contiguous allocations, so do we really > need this in DT anymore? I would say yes, there can be a number of times where you want to semi statically partition your physical memory and their reserved regions. Be it to pack everything together under the same protection rules or because you need to allocate memory from a particular address range in say a non-uniform memory controller architecture where address windows have different scheduling algorithms. -- Florian From xen-devel-bounces@lists.xenproject.org Thu Mar 11 07:49:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 07:49:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96349.182176 (Exim 4.92) (envelope-from ) id 1lKG3r-0002dC-5Q; Thu, 11 Mar 2021 07:48:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96349.182176; Thu, 11 Mar 2021 07:48:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKG3r-0002d5-2M; Thu, 11 Mar 2021 07:48:47 +0000 Received: by outflank-mailman (input) for mailman id 96349; Thu, 11 Mar 2021 07:48:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKG3p-0002cx-Ep; Thu, 11 Mar 2021 07:48:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKG3p-0007xy-7Y; Thu, 11 Mar 2021 07:48:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKG3p-0006pq-0a; Thu, 11 Mar 2021 07:48:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKG3p-000605-02; Thu, 11 Mar 2021 07:48:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TzWXd3lx1L6+0HFKN3Wqx3ZS8y6MxggsgKuHTM05h+c=; b=CZHWa+O0oG29AJQYFBVbX2sAiU 0k7yWGhUQSYqv8DYV52fxG0tmyEt9soRmNQ5ZLDAf1LOg7QnjjDT6rDyzICHvvQcPUEZPv+BoARpv hv6nboYcE/3WopCMT2T0Bf0kLz7QgTYjBpeZ1iywkOx4XXL/SH1ilYWmVhYmWGgkPzMY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 159928: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=f11f32326f163dda28143e9495d9bbc5d4869f6d X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 11 Mar 2021 07:48:45 +0000 flight 159928 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/159928/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt f11f32326f163dda28143e9495d9bbc5d4869f6d baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 244 days Failing since 151818 2020-07-11 04:18:52 Z 243 days 236 attempts Testing same since 159928 2021-03-11 04:18:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 46724 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 11 07:55:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 07:55:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96356.182192 (Exim 4.92) (envelope-from ) id 1lKGAP-0003Wd-6l; Thu, 11 Mar 2021 07:55:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96356.182192; Thu, 11 Mar 2021 07:55:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGAP-0003WW-3A; Thu, 11 Mar 2021 07:55:33 +0000 Received: by outflank-mailman (input) for mailman id 96356; Thu, 11 Mar 2021 07:55:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGAN-0003WR-Fh for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 07:55:31 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 38352f9d-8836-4719-80b8-78725b7ae549; Thu, 11 Mar 2021 07:55:30 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A2CC2AB8C; Thu, 11 Mar 2021 07:55:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38352f9d-8836-4719-80b8-78725b7ae549 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615449329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=et4tmaBnTTfQBUxIE4EefbfiOHM9veA97Ae8dFGNtNA=; b=m8PNqj0UVQ2iXQ+CyXWzHCG+P6xraFy31NROKCaIGnrqUjsk++kJ8B7Y8+FBeHhbntnhLu MbIWkzEl16f30B1R7p1Ezc39JgrYzqQrIJ6kiSBfCLu6hr+VLe5nCrYfog0IzxeiJAsSeX AyNIdnQRFHOzPfRtYVitIUjeWK/1ibg= Subject: Re: Remaining MSR wrinkles To: Ian Jackson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Boris Ostrovsky Cc: committers@xenproject.org, Andrew Cooper , "xen-devel@lists.xenproject.org" References: <24649.6523.991714.489131@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <78536b74-2e6e-02ae-6655-d14fd97b3d37@suse.com> Date: Thu, 11 Mar 2021 08:55:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24649.6523.991714.489131@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 10.03.2021 20:09, Ian Jackson wrote: > (I bounced Roger's original mail to xen-devel. I hope it made it...) > > Roger Pau Monné writes ("Remaining MSR wrinkles"): >> 1. MSR behavior for PV guests without a #GP handler set: PV Linux versions < >> 4.14 will use rdmsr_safe (and likely wrmsr_safe?) without having a #GP >> handler setup, which results in a crash. This bug was hidden in previous >> Xen releases by allowing unlimited read access to the MSR space. I've not observed problematic wrmsr_safe() so far. >> Jan has posted several proposals to address this: >> >> https://lore.kernel.org/xen-devel/7e69db81-cee7-3c7b-be64-4f5ff50fbe9c@suse.com/ >> https://lore.kernel.org/xen-devel/d794bbee-a5e5-6632-3d1f-acd8164b7171@suse.com/ >> >> Which all rely on the fact that for PV guests Xen knows whether there's a >> #GP handler setup and can hence prevent injection of a #GP fault if no >> handler is present. >> >> Andrew opinion is that we should instead try to figure out which MSRs the >> buggy Linux versions try to access and special case them. Andrew also raised >> the point that continue running with a 'fake' (ie: 0) MSR value might be >> worse than crashing. >> >> Part of the discussion has also happened here: >> >> https://lore.kernel.org/xen-devel/4da62f0b-8a08-dd84-2040-fd55d74fd85a@citrix.com/ >> >> Look for the last quote. >> >> Another option is to document that PV Linux < 4.14 will require msr_relaxed=1 >> in order to run. That as Jan pointed out will also imply PV Linux to run with >> a faked (0) MSR value instead of crashing. > >> For 1. I do agree with Jan than this workaround is likely the best option we >> have, sort of resorting to request enabling msr_relaxed for all Linux PV guests >> < 4.14. Whether we want to limit this workaround to the read side only I'm not >> fully convinced. There's something nice about having symmetry in the read and >> write paths, but if all the calls we have identified are rdmsr only I prefer to >> leave the write path unaltered and request users to use msr_relaxed if write >> issues are found later. Especially if Andrew's ambiguous objection was against the write side only, I think I'd prefer to go with this latter variant. Considering that dealing with the read side alone is sufficient to address the observed issue, I'm even inclined to prefer this irrespective of that constraint. > Thanks. I find your explanation and arguments convincing. I have > read what Andy says in that link and I find that less convincing. In > particular "I don't think we should legitimise buggy PV behaviour" is > not entirely consistent with our previous approach to > bug-compatibility and support for old guests. > > Accordingly, (with committer tie-breaker hat on) I would prefer to > apply the patches from Jan. I don't have an opinion about the read vs > write question, and will probably be happy with whatever you and Jan > can agree on. > > I don't think I Release-Acked those patches yet so, for those two, > > Release-Acked-by: Ian Jackson You didn't, indeed, but "those two" is slightly confusing, the two links Roger did provide are just different versions of the same patch. Hence I'd like to double check that it is exactly this one patch of mine (of which I need to send another version, at least to include Roger's requested documentation of the behavior, and possibly also the write side equivalent - still waiting for Andrew to come back and clarify the scope of his objection). >> 2. RAPL_POWER_LIMIT: handle the MSR explicitly to make Solaris happy. >> Alternatively we can list in the release notes that Solaris guests require >> msr_relaxed=1. Andrew is working on a patch for this. > > I would prefer to handle the MSR explicitly, for the same > compatibility reason as above. The question is here - we aren't sure yet that this is the only one, are we? Andrew suspects if this one MSR gets accessed this way, then likely others will be, too. Boris, can you tell for sure either way? Also, Boris - any chance you could give your Tested-by for Roger's patch? It's otherwise ready to go in, but I'd prefer to commit it knowing that you've tested this hopefully final version. I'm sorry for the recurring requests to test this workaround. >> 3. MSR_K8_HWCR: Linux will complain about a missing bit (TscFreqSel). Jan >> posted a patch to handle the MSR and unconditionally set the bit: >> >> https://lore.kernel.org/xen-devel/c91b190a-aaa1-d3b8-10eb-d8da7ad1f834@suse.com/ >> >> There are concerns from Andrew about missing bits in ACPI tables and Pstate >> MSRs if this bit is reported as set. > >> For 3. I think I at least need more details about the relation with TscFreqSel >> and ACPI or other MSRs, and I haven't been able to find it on the PPRs I >> looked. > > I don't understsnd the implications here. Jan says that Linux has > been warning about this, but is that the only symptom of the current > state of affairs ? Yes. It claiming a firmware bug when running under Xen, but not when running natively is likely to cause support calls. > Jan writes > > The main risk with making the read not fault here is that guests > might imply [sic, "infer" intended] they can also write this MSR then. > > How would that matter, in practice ? The guest would try to write > the KSR and then ... ? ... would crash. I should say though that with increasing awareness of potentially running virtualized, kernels have become more careful in this regard. (I was about to say "with implications like this one, but since you say "imply" was wrong, "implications" would likely be as well. What would the correct noun here be then? My dictionary has "inference", but this feels a little odd, too much like misspelled "interference".) Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 07:58:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 07:58:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96359.182203 (Exim 4.92) (envelope-from ) id 1lKGDV-0003lp-LL; Thu, 11 Mar 2021 07:58:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96359.182203; Thu, 11 Mar 2021 07:58:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGDV-0003li-IV; Thu, 11 Mar 2021 07:58:45 +0000 Received: by outflank-mailman (input) for mailman id 96359; Thu, 11 Mar 2021 07:58:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGDU-0003lc-6G for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 07:58:44 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7a6d6b2a-e0c6-45b0-a5bc-588d99917373; Thu, 11 Mar 2021 07:58:43 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C39A2AB8C; Thu, 11 Mar 2021 07:58:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a6d6b2a-e0c6-45b0-a5bc-588d99917373 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615449522; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sM1SZv8SLDv9D8MHB1KS7Qpx2wQarvOqqTsIfJ4GZ80=; b=Pv1wMDwSOdbWiM0SKlB4lrvwhAVzlNsqHledva6ndISE+9/FDuJ4dGIwNOd6/3pHA60bb6 f/10sbfCx7Jf+ULgwC0jx706I5jRGVZDvTnPhCBxZdtImjXBJ/dRTCXSEXMa62GK8rwenW Vp+dajAndPpY0kyTEE5Qt4KsGlwbTcI= Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , Xen-devel , Paul Durrant References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> From: Jan Beulich Message-ID: Date: Thu, 11 Mar 2021 08:58:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 10.03.2021 18:22, Andrew Cooper wrote: > On 10/03/2021 17:12, Jan Beulich wrote: >> On 10.03.2021 16:07, Andrew Cooper wrote: >>> --- a/docs/designs/dmop.pandoc >>> +++ b/docs/designs/dmop.pandoc >>> @@ -4,9 +4,13 @@ DMOP >>> Introduction >>> ------------ >>> >>> -The aim of DMOP is to prevent a compromised device model from compromising >>> -domains other than the one it is providing emulation for (which is therefore >>> -likely already compromised). >>> +The DMOP hypercall has a new ABI design to solve problems in the Xen >>> +ecosystem. First, the ABI is fully stable, to reduce the coupling between >>> +device models and the version of Xen. >>> + >>> +Secondly, for device models in userspace, the ABI is designed specifically to >>> +allow a kernel to audit the memory ranges used, without having to know the >>> +internal structure of sub-ops. >> I appreciate the editing, but the cited points still don't justify ... >> >>> --- a/xen/include/public/hvm/dm_op.h >>> +++ b/xen/include/public/hvm/dm_op.h >>> @@ -25,9 +25,6 @@ >>> #define __XEN_PUBLIC_HVM_DM_OP_H__ >>> >>> #include "../xen.h" >>> - >>> -#if defined(__XEN__) || defined(__XEN_TOOLS__) >>> - >>> #include "../event_channel.h" >>> >>> #ifndef uint64_aligned_t >>> @@ -491,8 +488,6 @@ struct xen_dm_op { >>> } u; >>> }; >>> >>> -#endif /* __XEN__ || __XEN_TOOLS__ */ >>> - >>> struct xen_dm_op_buf { >>> XEN_GUEST_HANDLE(void) h; >>> xen_ulong_t size; >> ... this removal: What the kernel needs for its auditing (your 2nd >> point) is already outside of this guarded region, as you can see >> from the context above. You said there was a design goal of allowing >> use of this interface by (and not only through) the kernel, e.g. by >> a kernel module (which I don't think you mean to be covered by >> "device models"). If that was indeed a goal (Paul - can you confirm >> this?), this would now want listing as a 3rd item. Without such a >> statement I'd call it a bug to not have the guards there, and hence >> might either feel tempted myself to add them back at some point, or >> would ack a patch doing so. > > Xen has absolutely no business dictating stuff like this.  It is an > internal and opaque property of the domain if the hypercalls happen to > originate from logic in user mode or kernel mode.  Stubdomains would > fall into the same "kernel" category as xengt in the dom0 i915 driver. There's imo a good reason to prevent kernel to use e.g. sysctl and domctl. Those are unstable interfaces, yes, but still. > However, the actual bug I'm trying to fix with this is the need for > userspace, which doesn't link against libxc, to do > > #define __XEN_TOOLS__ > #include > > to be able to use the libxendevicemodel stable library. > > The __XEN_TOOLS__ guard is buggy even ignoring the kernel device model > aspect. Aiui to address this all that would be needed would be to move the one typedef out of the guarded region. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 08:00:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 08:00:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96366.182216 (Exim 4.92) (envelope-from ) id 1lKGFA-00057e-7o; Thu, 11 Mar 2021 08:00:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96366.182216; Thu, 11 Mar 2021 08:00:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGFA-00057X-4k; Thu, 11 Mar 2021 08:00:28 +0000 Received: by outflank-mailman (input) for mailman id 96366; Thu, 11 Mar 2021 08:00:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGF8-00057P-9e; Thu, 11 Mar 2021 08:00:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGF8-0000IP-3t; Thu, 11 Mar 2021 08:00:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGF7-0007Ks-TD; Thu, 11 Mar 2021 08:00:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKGF7-0003RK-Sj; Thu, 11 Mar 2021 08:00:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ptamYoN36WDogt13Vw8+TT4enfrbI6Ly/TaQzwhAJZw=; b=fm4DMqJtsLlMKmk0w/BrCqrmIE X98zPSULl9gKUhIrA8xII2UJHpshtUHHi1awFTu1Kt0mqIH2IWeUEcKsL/fxGIVvOyQENM9SD9HnN eObr0h6acl00oKafWB/esp1ELPvNBELkax5601i6PkqF9i7NmBEq4fjf0V5YzUndIlwo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159916: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=05a59d79793d482f628a31753c671f2e92178a21 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Thu, 11 Mar 2021 08:00:25 +0000 flight 159916 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159916/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux 05a59d79793d482f628a31753c671f2e92178a21 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 222 days Failing since 152366 2020-08-01 20:49:34 Z 221 days 383 attempts Testing same since 159902 2021-03-10 02:57:19 Z 1 days 2 attempts ------------------------------------------------------------ 5182 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1283745 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 11 08:09:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 08:09:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96373.182231 (Exim 4.92) (envelope-from ) id 1lKGNq-0005Sh-8S; Thu, 11 Mar 2021 08:09:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96373.182231; Thu, 11 Mar 2021 08:09:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGNq-0005Sa-5T; Thu, 11 Mar 2021 08:09:26 +0000 Received: by outflank-mailman (input) for mailman id 96373; Thu, 11 Mar 2021 08:09:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGNo-0005SV-Ul for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 08:09:24 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3008c709-832f-419a-bd57-421c529335e0; Thu, 11 Mar 2021 08:09:24 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1A3B6AD72; Thu, 11 Mar 2021 08:09:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3008c709-832f-419a-bd57-421c529335e0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615450163; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dJLMv/hsgUsGfwAxp18RwimpubSUpytd1cJU34yAdks=; b=AMIrmjh35d74JtP+zbLfGX4mPGiF3INgr+tUiSXzQUC9SJIGlcH8wu08MewbI/bBwr8Sv0 pK6Ci6UFCKeXC4u79tJuI4dEL5OAuIypiJaXw0kAbaWBDjqn1DpCaKiYGsuyOT/U6tTnrz 0R1OHVQyrOjdv0UL2tAyk1pAcpN4Ttk= Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning To: Julien Grall Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <6bd14438-7dec-2176-eab5-5898f190c4d8@suse.com> From: Jan Beulich Message-ID: <952ca444-2091-b7f1-3559-c728a63af37f@suse.com> Date: Thu, 11 Mar 2021 09:09:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10.03.2021 18:52, Julien Grall wrote: > On 10/03/2021 16:21, Jan Beulich wrote: >> On 10.03.2021 15:58, Julien Grall wrote: >>> On 10/03/2021 10:13, Jan Beulich wrote: >>>> Sadly I was wrong to suggest dropping vaddrs' initializer during review >>>> of v2 of the patch introducing this code. gcc 4.3 can't cope. >>> >>> What's the error? >> >> The one quoted in the title. >> >>> Are you sure this is not going to hiding a potential >>> miscompilation of the function? >> >> Miscompilation? It may hide us screwing up, but addressing such a >> compiler warning by adding an initializer has been quite common >> in the past. > > Well... When a compiler tells me a value may be unitialized, I read it > as some optimization may decide to use the variable in a way I wasn't > expected. I don't think that's how warnings like this work in general. Optimization may help spot a case where an uninitialized variable gets used (because optimization may result in sufficient simplification of the internal representation of the original source), and variable lifetime analysis may also be a prereq to optimization, but in general I'd recommend viewing the two as independent aspects. >>>> --- a/xen/common/grant_table.c >>>> +++ b/xen/common/grant_table.c >>>> @@ -4026,7 +4026,7 @@ int gnttab_acquire_resource( >>>> struct grant_table *gt = d->grant_table; >>>> unsigned int i, final_frame; >>>> mfn_t tmp; >>>> - void **vaddrs; >>>> + void **vaddrs = NULL; >>> I am a bit nervous to inialize vaddrs to NULL for a few reasons: >>> 1) It is not 100% obvious (e.g. it takes more than a second) that >>> vaddrs will always be initialized. >> >> But convincing ourselves was necessary even more so prior to this >> change. We must not ever rely on the compiler to tell us about >> issues in our code. We can only leverage that in some cases it >> does. > > I didn't suggest that we should only rely on the compiler. I pointed out > that we are telling the compiler to not worry. This may hide a valid > concern from the compiler. As we (have to) do elsewhere. >> From this it (I think obviously) follows that without the >> initializer we're at bigger risk than with it. > > I thought deferencing a NULL pointer was still a concern for PV? I could use ZERO_BLOCK_PTR or yet something else, if we decided we want to work around this class of issues this way. Elsewhere we're using NULL afaict (but see also below). > For the other setup, I agree that it would only lead to a crash rather > than dereferencing anything. Yet I am not convinced this is that much > better... When using an uninitialized variable, anything can happen. A crash would still be on the better side of things, as a privilege escalation then also is possible. Again - if you're worried about us introducing an actual use of the thus initialized variable, you should be even more worried about using it when it's uninitialized (and the compiler _not_ being able to spot it). >>> 2) A compiler will not be able to help us if we are adding code >>> without initialized vaddrs. >>> >>> It also feels wrong to me to try to write Xen in a way that will make a >>> 10 years compiler happy... >> >> As said above - we've worked around limitations quite a few times >> in the past. This is just one more instance. > > I find amusing you wrote that when you complained multiple time when > someone was re-using existing bad pattern. :) Well, thing is - I don't view this as a bad pattern. The only question really is whether NULL is a good initializer here. As per above a non- canonical pointer may be better, but then we have quite a few places elsewhere to fix. We could also deliberately leave the variable uninitialized, by using past Linux'es uninitialized_var(), but they've dropped that construct for what I think are very good reasons. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 08:09:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 08:09:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96374.182242 (Exim 4.92) (envelope-from ) id 1lKGNz-0005VQ-G0; Thu, 11 Mar 2021 08:09:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96374.182242; Thu, 11 Mar 2021 08:09:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGNz-0005VI-Cw; Thu, 11 Mar 2021 08:09:35 +0000 Received: by outflank-mailman (input) for mailman id 96374; Thu, 11 Mar 2021 08:09:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGNx-0005Uy-SX; Thu, 11 Mar 2021 08:09:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGNx-0000QB-Jc; Thu, 11 Mar 2021 08:09:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGNx-0007uU-88; Thu, 11 Mar 2021 08:09:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKGNx-000520-7f; Thu, 11 Mar 2021 08:09:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=x/9KpcJhv4Fsb/U0Lk7ZX1vQ2iCRaJYxmj7sKF+UO+s=; b=5A1LfipSyvdImBS0wtrIXM+tXL D4UG2eXhixU4cuY6rK+XfxLc0n9cU5L1QS8m4oZNdnKH9zWf/BgbgfApiZrGZ3ybejlyVzXOR9+cW 7e4N8gEUIsxOzpPBl3XXI7pbb+lIt1GD+wtQu0cyISF53qKJPByFWnGwUddBN7yCZ5o4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 159924: all pass - PUSHED X-Osstest-Versions-This: ovmf=54ba08c6b66090bdc03186110149bfe4b0f75208 X-Osstest-Versions-That: ovmf=edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507 From: osstest service owner Date: Thu, 11 Mar 2021 08:09:33 +0000 flight 159924 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/159924/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 54ba08c6b66090bdc03186110149bfe4b0f75208 baseline version: ovmf edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507 Last test of basis 159879 2021-03-08 21:40:45 Z 2 days Testing same since 159924 2021-03-11 01:54:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ray Ni jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git edd46cd407..54ba08c6b6 54ba08c6b66090bdc03186110149bfe4b0f75208 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Mar 11 08:18:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 08:18:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96383.182258 (Exim 4.92) (envelope-from ) id 1lKGWA-0006ak-E8; Thu, 11 Mar 2021 08:18:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96383.182258; Thu, 11 Mar 2021 08:18:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGWA-0006ad-Ax; Thu, 11 Mar 2021 08:18:02 +0000 Received: by outflank-mailman (input) for mailman id 96383; Thu, 11 Mar 2021 08:18:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGW8-0006aW-Hq for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 08:18:00 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5c311390-9ac6-4011-bb0f-bfbed8b020d6; Thu, 11 Mar 2021 08:17:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A435CAC16; Thu, 11 Mar 2021 08:17:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c311390-9ac6-4011-bb0f-bfbed8b020d6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615450678; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bpixSMGVIw+5F7WyNe2N5wSzzZOriV1Vf/ISr/6LqTA=; b=Uh265zkSW0W9nFgml3FrvU8/LzBZSEQzCAwzm8poZs0KrDQyarRjMRdmLdNIpSqV6FDGCr it4YlNL9CV6wx8pSuYrzD/aQxj8cxUW4FmOeOiF/E2y6p9msw9XKQMKTlWVAxCjKBljWSX iaLl+3lQU6vs/IQ0Kz7sTO36QfS5/6E= Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) To: Julien Grall Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210306214148.27021-1-julien@xen.org> <1897022d-7591-3450-4e57-884a2860b13d@suse.com> <7fd07dc9-9c03-bb13-3907-c3c268a4e970@xen.org> <2de5160f-8636-5cdf-a20c-acaa2640c893@suse.com> <7ab87cab-8836-e8a0-993e-0cdeca3c45e3@xen.org> From: Jan Beulich Message-ID: <2bc2ad13-8636-e5d4-3a4a-722c75e3b92a@suse.com> Date: Thu, 11 Mar 2021 09:17:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <7ab87cab-8836-e8a0-993e-0cdeca3c45e3@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10.03.2021 19:05, Julien Grall wrote: > On 09/03/2021 11:20, Jan Beulich wrote: >> On 08.03.2021 21:22, Julien Grall wrote: >>> On 08/03/2021 11:20, Jan Beulich wrote: >>>> On 08.03.2021 11:51, Julien Grall wrote: >>>>> On 08/03/2021 08:09, Jan Beulich wrote: >>>>>> Additionally - partly related to your own reply regarding the CI >>>>>> failures - imo there needs to be an analysis of what older distros >>>>>> will no longer build (at all or by default). >>>>> >>>>> Per the CI, this would be Ubuntu Trusty (and older), Centos 7 (and older) >>>>> >>>>> Do you have any other in mind? >>>> >>>> Our SLE12 (latest service pack is SP5 and still has a while to go >>>> to at least reach LTSS state) comes with gcc 4.8 as the default >>>> compiler. >>> >>> Thanks! That's good to know. Is it the old GCC Suse supports? >> >> Not sure I understand the question: The default compiler of this or >> any distro is of course (expected to be) supported by the vendor >> for the lifetime of the OS. > > Sorry for the wording. I was asking whether Suse also supports compiler > older than GCC 4.8. Oh, I see. SLES11 has another year to go for LTSS to end, and it's 4.3 which is used there. >>>>>>> --- a/xen/include/xen/compiler.h >>>>>>> +++ b/xen/include/xen/compiler.h >>>>>>> @@ -5,6 +5,19 @@ >>>>>>> #error Sorry, your compiler is too old/not recognized. >>>>>>> #endif >>>>>>> >>>>>>> +#if CONFIG_CC_IS_GCC >>>>>>> +# if CONFIG_GCC_VERSION < 40900 >>>>>>> +/* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ >>>>>> >>>>>> As per the bug report, the issue was determined to not be present >>>>>> in e.g. 4.3. Hence while such a bug may influence our choice of >>>>>> minimum version, I don't think it can reasonably be named here as >>>>>> the apparent only reason for the choice. Personally I don't think >>>>>> any justification should be put here. >>>>> >>>>> Ok. >>>>> >>>>>> >>>>>>> +# error Sorry, your version of GCC is too old - please use 4.9 or newer. >>>>>>> +# elif defined(CONFIG_ARM_64) && CONFIG_GCC_VERSION < 50100 >>>>>>> +/* >>>>>>> + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 >>>>>>> + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk >>>>>>> + */ >>>>>>> +# error Sorry, your version of GCC is too old - please use 5.1 or newer. >>>>>> >>>>>> From the bug entry the fix looks to have been backported to 4.9, >>>>>> or at least some (important?) branches thereof. >>>>> >>>>> It is not clear what's you are trying to point out. Mind clarifying? >>>> >>>> Some 4.9 compilers (perhaps widely used ones) may not have the bad >>>> issue, which puts under question their ruling out when the main >>>> reason for doing so is that bug. >>> >>> Well... We could surely try to hunt which GCC 4.9 has been fixed. But I >>> am not convinced this is useful, we would need to have an allowlist of >>> GCC compiler. >> >> Or probe the compiler for the bug in question. > > I thought about it but it is not clear to me whether the reproducer > would work on every GCC version and how to detect that this was miscompiled. > > Do you have any suggestion? To have one I'd have to study the problem in quite a bit more detail. But I did say that what you do for Arm is largely up to you (and Stefano did meanwhile ack the Arm side), so I'm not sure I want to invest the time that would be needed. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 08:26:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 08:26:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96386.182270 (Exim 4.92) (envelope-from ) id 1lKGdo-0007W7-8E; Thu, 11 Mar 2021 08:25:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96386.182270; Thu, 11 Mar 2021 08:25:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGdo-0007W0-2z; Thu, 11 Mar 2021 08:25:56 +0000 Received: by outflank-mailman (input) for mailman id 96386; Thu, 11 Mar 2021 08:25:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGdm-0007Vv-P0 for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 08:25:55 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1fed2bae-3eef-4448-9a34-cb80ee7798e1; Thu, 11 Mar 2021 08:25:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1fed2bae-3eef-4448-9a34-cb80ee7798e1 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615451153; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=oU9S64iZYC/kTQLdbtiTWi/IDh+IwGQmrynRnzWfmYA=; b=ec3UHoXZjUn4JsV4VozmgsbWgOhk+lSB58g36UiZ5BDUY3KVjdXoaPRV 16kBIyIfPFUZWMIM0MZNZTamy8XwEDeScvagXh2YrTbT/F4fQv9+3HpeV IBCYKGw4C1VwbwNxlIzS5IDXB0wT1U2gmAkV8P6m7bNbP3bbQsXDK3PNM E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 2/NQUwVIH08lJam0sPzA2ScEoQ1XPnNic13esNaKOjjehaJVZer4p3IYocuwBT7fePcRTPDotd Q0YY8dvrjwU1HCEbYq8tlsCghNumaWci6BAmq1nL9cXcSlh3Zhyg5BTPRHHIVoc4EhzRxfgQoV 9zYlCCO/5jkE7D/YZ35IksULvKGOMBiyBqKnx4zHp7AAqMy+9xPrhUz8KI3xbwUeWeKrt67WtO txeDYFz2kubTNoBW+NnwFLDB07SJtKvY8szCbdF2AgVTIDye5Av76wjnNEmnrqzo5RnvfBQTPz jNc= X-SBRS: 5.2 X-MesageID: 38942778 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:TG7m2q1cIH20bHnyjkF/cAqjBU51eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z+8S3aA4Bp3neAX9omOnIMVZ7YXkyyD9ACGWzJ876Y 5JSII7MtH5CDFB/KLHySGzGdo43Z2j+Kenme/Rwx5WPHRXQol98gZ0DRuaGEVqRA9AQaE0Do aY+9ACgSGhd3QRZsHTPAhNY8HoodrXmJX6JTsPABA64AeD5AnYnILSOR6ewxsYTndz0a4vmF K11zDRy4eCl7WAyhHa33LO9Jg+orCRs+drKcSQhqEuW0TRoymyYoAJYcz5gBkUp6WV5E8ugJ 3wpX4bTrZOwlfwWk3wnhf3wQnn118Vmjjf4HuVm2Hqr8C8ZB9SMbswuatjfhHU61UtsbhHuc ogsgz5xuIndi/opyj269jWWxwvrHOayEBMrccpg3NSSocYYrNKxLZvj399K5scADn8rLkuDe gGNrCE2N9tbViYY3rF11MfvOCEY3UpEh+KBmgEt8CFugIm4kxR8koCyMQT2koH7ZI2IqM0mN jsD6IArsAycuYmKY5aPc8dXNC2AXDRTR/pPHiJKVrqfZt3Y07lmtra8b8x7OGvdIcoyoEulJ n6UF1evXMvYE71TemDxodC/Bz1W2O2US72xsw23fhEk4y5aKvgNCWCTFw0s8+4uPUZH+XQRv a0P/ttcpreBFqrNZdC2gX/X5VICX0GS80Tp/MyRl6IqNKjEPyJisXrNNrDLr/kETIpQVrlBG oSeTDvKMJL/imQKxzFqSmUdHX3dkPl+5VsVIDc4ugI0YAIcrZBqw4PlD2Cl562AAwHnaoscE RkJrT71ou9uGmt5G7Nq15kIxxHEwJo56j6T2lWqQJiCTK2TZ8z//GkPUxC1nqOIRFyC+vLDQ 9SoEl286qrL5qWgRsvEc6jL3jytRcujUPPa61ZtryI5M/jdJ99JI0hQrZNGQLCEAEwsRp2qU 9YATV0EnP3J3fLs+GInZYUDObQe51XmwGwO/NZrnrZqAG1udwvfH0GRDSjOPTn1DoGdn5xvB lc4qUfiL2PlXKEMm0kmtk1N1VKdSC5G7RDIAOZZJhFu7zidQ1qJF360gCyulUWQC7H5k8Sjm vuIWm/YvfQGGdQvXhez+LL/TpPBzagVnM1Tko/nZx2FGzAtHo2+/SMfLCP32yYbUZH5e0BLj ffY383Lhl1z966kD6Z8QzyRUkO99ELBKjwHb4je7bc1jeGM4uTj5wLGPdS4dJCL9DhsugCVM qFYA+LJDbEC+cksjbl90oNCW1Rkj0JgPno0Brq4CyTx3gkG8ffJ1xgWvU8ONGT72/tQt6UzY 54hs4pseaMPmL4bcOtz6bRYzRfKhTcgXfedZB7lblk+YYJ8JdjFZjSVjXFkEtK2xgzN+/Yvk ITSqYT2sGOBqZfO+gpPw5J9Fsgk9qCaHYxugvtG+kkYBUGlHnAJe6E5LLOtJsiCkCMvxHLJF Ga6iFRls21GVrU6ZcqT4YLZUhGYkk173pvuN6Yf4rLEQOwaqVo51yhKEKwd7dbVYmIEbgdtQ xB/sqJhvaaekPDqVvtlAo+BpgL0m68BeuuHQqHGIdzgquHEGXJppHvxsG9jD36E2TmL2sZgJ BIbkwWYIBojCI4gIg+zyi1TejWryse4hFjyAAismSo/Ieo4G3WRx4bdSLYh4hbRjlVPDyji9 /f/e2RyXT653xk1N37D1hLF+s+QeQ4f8zSFWNSDuQ++JSv5LEihyxfZgxGNR9LtBnNm8dn16 y+wvPcRqnLDmrpI0sI/Vd+d9NJtx1ujWFLaM6l652hJi0RC+4TGvM6oqRbiihgpFS2z1oSaX xWx1AV/7CIClzsJHJnE6fy2aPwnRgDvaCHr3ljvm9ZlF/iqFaSvRzShMa6u309qgTm309agJ TYYDs6myBCsAF7hYRnL3qWSGbpBUq/D2mf9tplBVRVTUQuwf4slhzNMu0ikY2/1XNtqXAGBT Uq36u3Gmu3c0TSKfTAaBawFNq0B9ZuZe12IWRrFQ/pCD3U3pArCh7YctZo0Ruh3n8IGKiVI6 ujJAaQFoME8qAcM7HlKrTux/vmx0xc7TUfvoj7gXuKkLZ29sudPBd7qs94fK5zOAumlR0Il+ e7TEbKJcwQ5iqQsmnqrSJfL9USyx4OwUYbqTwLcRnYSO+bVwVkvnoe15TtRCcE0s6PRtZerH fZrTeayTLrHRHRNFPpRqYE7H0o/hvQWY7Wv1C1fLzqKhBZkcvcXJuRhG79zA/Vp9KIkTnYuF dsyApnNF0I9zs= X-IronPort-AV: E=Sophos;i="5.81,239,1610427600"; d="scan'208";a="38942778" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c7k8TWyYgbPw99vmltu1HCo3SWUoAJUf3ZY1vOrzwjPJKId/z+16DH5cCH6xPcIIQhlAC61glI3+y7XlZofhjRtPKJs5vBxtkN8tzKWxvSnQqv+er81MPJrd0a1Bo8ZpxNZvRsZtBzAYXK4jDoNSnVgZMApFNDxJN2KbMhZtDXL5sLfdpswBdQB6w7feU1P922kqVMnysENemTmtjvSpsJeaHoZJTiUR/IC4nSrggVCbDBBwtXsLYnG/e4cisVqSIG1kMiB3ZIHY4XDoeqvVAR3WHjUqIkl98yg/bt+CnRNJ0xHVhqD8BqPhkszvtRoaVLEeTQOHDb5Sk2gadLSCXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nwQq36Hi81n35Mtk5ZfO1VYif3bs0JJ3T/p+IlBD4Ws=; b=iyOmuOo0usWBTk7JUkURyF5bcxNdZfeoyFxtCKu62LIBvBOzoSGw00GtrG0RGZIzusf3vzO8K0za4AwT09s/RKPzTNblB2f0OxNLLYcejQ/MXMCFPtR2hivM1HxQqVZsPQscLSwkzqcfcTy/akIxGKxJ4TLwnPV/jQbEEY43+mwJe5xnLhXyVbuoL5jJeqyTNveJ8gr0kIyNk87iEabBRjSpQAHKgQ7/ESDsSAwofWTkQoavMUzQRd8l9zCpEcth3nlW3buKg5qmL+AAeGf0hjsd10f8a7NqugyHl7ABR+GG1kPKzzLpDWbftB3cwaln9s0f7IqIDiIgOSz4J89bFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nwQq36Hi81n35Mtk5ZfO1VYif3bs0JJ3T/p+IlBD4Ws=; b=gcdaZ+pWC7La7aJ4WPC9cbi/TuHDX1c5GOz3xINwTtu8/RqMoouQDyAE7n5J4TQ+0Nf5vEfeqJ1JGh8XQex1bRcQDOhT6PPLwfD8QNYGicGyY81poLgGbmcQhRkhne61baE4WhbUgqbDkBdOPWQLfOhJ/hWsoIujHT8t5bS//3k= Date: Thu, 11 Mar 2021 09:25:30 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning Message-ID: References: <6bd14438-7dec-2176-eab5-5898f190c4d8@suse.com> <952ca444-2091-b7f1-3559-c728a63af37f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <952ca444-2091-b7f1-3559-c728a63af37f@suse.com> X-ClientProxiedBy: AM6P195CA0070.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::47) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b3b4927-f426-4873-f5bc-08d8e4673f89 X-MS-TrafficTypeDiagnostic: DM6PR03MB5356: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yMT87jBidMOhHtwiqSJmaV8MJd9Va3xnPhc/LRUtlYeb/msA3PAdD1YKi1TpD6KVpurCQS2IRQOkLX7rnLFcxkX+sotCv9l++q9THsi/m3zMQ22pgU5wIJpV0MecXt9YImg6cUBCf1dSc26tpvj79woR2DMk/Uvr83SgHwhKELJRklYZemz8RC/BH3M15kG2SUfbieAuCtwMBOMDhruivY2DLGg6sI6owDiJ0wsstBPlybJBfHNFcTuh2Bdof2G3R+cp4sqea39AScWpTqLgFjWk8amZgoAvqlL1ZDMOM+LprQEd//XmV9XNvI0n/Ld44J0ku60wW4KOpQQkC/pvKdALtf/WIQUXmARETdtttC3dVHKhXAhD7yb6K1a8nHU6SZnSmCgY9A30lUy67yKh5pJk84tgelYFgpbw2DUuhl/0gtPKN70m7Q0MjtdwqRQpeh53XUR1T8YG+wIqH2WPMP7uf8VVW15jgBarZo+Ag2GY/Upyb1WIs+TksiN2AE1GWaL/7RbhuH0lz0DU4ggUOA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(39860400002)(136003)(346002)(376002)(396003)(366004)(6916009)(9686003)(33716001)(16526019)(66556008)(66476007)(66946007)(83380400001)(6486002)(2906002)(6496006)(85182001)(478600001)(8676002)(8936002)(316002)(956004)(86362001)(54906003)(53546011)(186003)(5660300002)(6666004)(26005)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dVl6cXI3c3A3TlJkM3ZQQ3JSODFCRHU4QjA5NU1GRC9ZczVRcU5QWjZCQUQ1?= =?utf-8?B?VlQ0anNmN29wRmtTUHpFczMxL1d5eE1rL1F4RHo5cndHb0Q3WFJQdDB1VzdU?= =?utf-8?B?dy9mMU0vdnRpR3pwMTZMb2ZMRW51dFJGNlFkMzB5aVRTT01vaFlGa1JPdW5Z?= =?utf-8?B?ZnZ4QmlmUXBqVndOSXF2QlJBL2w2SnNmTkFwdk9SaW56Ymk1M3EwWEFGaWNF?= =?utf-8?B?c0hyaWRGcmtIV1FEaFdWQTFOMWpBNEtrTG1DYTVVaWdMcDlicVVCUjU0V1pU?= =?utf-8?B?ZXdkeXdNekZaQW5oRWNrVDVPMGJMa084ZGEvSHowK2NTcGEwZUhGSG8rWjhE?= =?utf-8?B?akJZSVNYc2wzRC9QWHFSTkQ0L0thbGlXOXE2TDFETU5IektUNURDbWhFdFlZ?= =?utf-8?B?dDR4NFhwSSs0emNEZkRmNnpJRlhyRHVMN1VodmZWSGoydW5ZYmVQdmEyRTlH?= =?utf-8?B?UzNHTkM3ZTNCVEY2MnNWSFNEbGVsTVdMSmYzeU14Tm5RdXhMc3QwcmxjSUJ5?= =?utf-8?B?UkNoQW1VaDJQd1VYbm5MY1ZSeFdTM2xhVWtLTEZGcmtHWWwzMm9xZWNxNC9w?= =?utf-8?B?NVpGYkNlb0Rka0xudTZjMkU4K0c0M09qK0dZNHEzU0RTdFM3TWpRSHZrVjVq?= =?utf-8?B?MER1WVpvSXJSWW0vc2RSWUJxYzJYQWZaZVdwMEhMbDlnYVE2eEZGanh3K1Ny?= =?utf-8?B?WW9VdllBWG00VW0rRHVvblUzWUZleFNCTWhTYVVvbTVQVHVYMEFjaktNd21V?= =?utf-8?B?bGl1a3BlamN2U3lvbHVQSlpDUW0vcHRWbWsrcWk0ZFYyR1ppajFsYitIVElk?= =?utf-8?B?eEYrSm9OdWNWcGRnRlpuK3VVL25tZDJWb0NoNTBNeTc4MStlTUM4TlNBUHZD?= =?utf-8?B?aVE2OG4yZm5pbHpPdHJQMU16czBzSFdVVVR0UFF3YzVPcWVpSCtXOUovVEZ5?= =?utf-8?B?NTVSckhrWjhUQ1c0S0xmRVk4S3RMck5KRHBYU2hkM1NwVFNCV2I3TmtKa0Rx?= =?utf-8?B?bVdiRlE0YWNjNVNTS1A5WjR2dnVXRWJoR283SXdwajc1TFlGWmVHNTdzU3BM?= =?utf-8?B?Z3RKKzNCN3ovcHJsMkNUV3FRZ2hvRDNCbktVK3Q5UTZDMjl6aVorWm1FTzNL?= =?utf-8?B?aU5WRHJyS1FCN1lhbk5pZWlEcy9OSkFUcHg4YlAyQW53ak10WVJEbWgxWkV4?= =?utf-8?B?YnlaeVRNdzdIb2R6NHM4THdJaHU4Q1F5NWE4WUVjb0ZxZzdhN1FSdkRGUElJ?= =?utf-8?B?NTdmNjFaV1JuYlFVZVl2ZllFSXlLQTFReC81ZVVlbjcrN1NXVUtNNmFsUWZn?= =?utf-8?B?bWdXbkIzMmZub3lBckNaQXVuMzRPVUZaSUVxYjNjS29jQjluanB6Q3lkV2dO?= =?utf-8?B?aWVrQm9QN2xDNUhMSW16eEFwTVlINHMvbmp3eFFaTTk4alFRM1dVcXRQZTc2?= =?utf-8?B?Qm1DRis3ZlRQMzhPenF4Q1ZGK2JSMG54L2hzcEViYXVxQ0llNDk0Qk9iay92?= =?utf-8?B?OGNVRkNDMERVTjhJSmtaM2pJQVZWeDVqODlKVmxHVEhteWNWNzI3U25kMWRh?= =?utf-8?B?T1MzS0JLM0NmOGVHRG5oRUd5S3lRSnRTZm1aUlcxSFNFeEFqWTFqWlhnZGJL?= =?utf-8?B?Z0ljUjdVQkl6ZE9mUThUcG9aNjd5aWhZMEZhU2RYUWhBYk93L2dCRW9tR0Vu?= =?utf-8?B?cmV6SWZVT0dyNkwzMHRwdFNianBWMHIveENmR3ovYVY3VDllcnVZR2NuN1Vy?= =?utf-8?Q?gSpPeshSbcA+LMYwT4L4oZIdjmDLzr4q1Gyw+YR?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2b3b4927-f426-4873-f5bc-08d8e4673f89 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 08:25:37.3637 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C7u7jA1/iCG+Vq82GTlSqH07hhzM+3vvBY2VmwlMTa0jegvSbXVIH3m+qli4a+h+3mabH/X/C30kyEAMlAFQOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5356 X-OriginatorOrg: citrix.com On Thu, Mar 11, 2021 at 09:09:22AM +0100, Jan Beulich wrote: > On 10.03.2021 18:52, Julien Grall wrote: > > On 10/03/2021 16:21, Jan Beulich wrote: > >> On 10.03.2021 15:58, Julien Grall wrote: > >>> On 10/03/2021 10:13, Jan Beulich wrote: > >>> 2) A compiler will not be able to help us if we are adding code > >>> without initialized vaddrs. > >>> > >>> It also feels wrong to me to try to write Xen in a way that will make a > >>> 10 years compiler happy... > >> > >> As said above - we've worked around limitations quite a few times > >> in the past. This is just one more instance. > > > > I find amusing you wrote that when you complained multiple time when > > someone was re-using existing bad pattern. :) > > Well, thing is - I don't view this as a bad pattern. The only question > really is whether NULL is a good initializer here. As per above a non- > canonical pointer may be better, but then we have quite a few places > elsewhere to fix. Sorry for jumping in the middle but I think that would be a very dangerous move for Xen to do. We have been using implicit conversions of pointers to booleans all over the place, assuming that NULL == false, hence NULL no longer mapping to false would break a lot of our code. ie: if ( foo ) free(foo); Would no longer work as expected. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 11 08:27:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 08:27:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96390.182282 (Exim 4.92) (envelope-from ) id 1lKGfg-0007md-Mm; Thu, 11 Mar 2021 08:27:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96390.182282; Thu, 11 Mar 2021 08:27:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGfg-0007mV-J4; Thu, 11 Mar 2021 08:27:52 +0000 Received: by outflank-mailman (input) for mailman id 96390; Thu, 11 Mar 2021 08:27:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGff-0007mP-TC for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 08:27:51 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4c56c069-fbc2-4800-9451-755f01c926fd; Thu, 11 Mar 2021 08:27:51 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 286D6AC16; Thu, 11 Mar 2021 08:27:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c56c069-fbc2-4800-9451-755f01c926fd X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615451270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wk3h0kMVXT6hHcD+F31BX7FNMUKF+sIkySGJApugL58=; b=rYpwJNYZJM4WILI0NDHmdy8nXsAW5kJoJTIpWqaNSRcPVRzLKy0MhGpY6zjg7y7yd7HhfW eiHovDLZvDQDBqueSCFYwS5nCBUeXLfuKRsKf/dYVD3Qr1oHNuUWmvJm4xx1iN7y1WZXOp rGBqFWcnkn3FXSnkfVzMqnUeeSLUkUA= Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API To: Andrew Cooper , Paul Durrant Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , Xen-devel References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> From: Jan Beulich Message-ID: <556ce32b-5087-b8b1-432e-643218dd8c6e@suse.com> Date: Thu, 11 Mar 2021 09:27:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 10.03.2021 18:22, Andrew Cooper wrote: > On 10/03/2021 17:12, Jan Beulich wrote: >> On 10.03.2021 16:07, Andrew Cooper wrote: >>> --- a/docs/designs/dmop.pandoc >>> +++ b/docs/designs/dmop.pandoc >>> @@ -4,9 +4,13 @@ DMOP >>> Introduction >>> ------------ >>> >>> -The aim of DMOP is to prevent a compromised device model from compromising >>> -domains other than the one it is providing emulation for (which is therefore >>> -likely already compromised). >>> +The DMOP hypercall has a new ABI design to solve problems in the Xen >>> +ecosystem. First, the ABI is fully stable, to reduce the coupling between >>> +device models and the version of Xen. >>> + >>> +Secondly, for device models in userspace, the ABI is designed specifically to >>> +allow a kernel to audit the memory ranges used, without having to know the >>> +internal structure of sub-ops. >> I appreciate the editing, but the cited points still don't justify ... >> >>> --- a/xen/include/public/hvm/dm_op.h >>> +++ b/xen/include/public/hvm/dm_op.h >>> @@ -25,9 +25,6 @@ >>> #define __XEN_PUBLIC_HVM_DM_OP_H__ >>> >>> #include "../xen.h" >>> - >>> -#if defined(__XEN__) || defined(__XEN_TOOLS__) >>> - >>> #include "../event_channel.h" >>> >>> #ifndef uint64_aligned_t >>> @@ -491,8 +488,6 @@ struct xen_dm_op { >>> } u; >>> }; >>> >>> -#endif /* __XEN__ || __XEN_TOOLS__ */ >>> - >>> struct xen_dm_op_buf { >>> XEN_GUEST_HANDLE(void) h; >>> xen_ulong_t size; >> ... this removal: What the kernel needs for its auditing (your 2nd >> point) is already outside of this guarded region, as you can see >> from the context above. You said there was a design goal of allowing >> use of this interface by (and not only through) the kernel, e.g. by >> a kernel module (which I don't think you mean to be covered by >> "device models"). If that was indeed a goal (Paul - can you confirm >> this?), this would now want listing as a 3rd item. Without such a >> statement I'd call it a bug to not have the guards there, and hence >> might either feel tempted myself to add them back at some point, or >> would ack a patch doing so. > > Xen has absolutely no business dictating stuff like this. Actually there's no "dictating" here anyway: People are free to clone the headers and omit the guards anyway. Outside of our own build system they really mainly serve a documentation purpose. >  It is an > internal and opaque property of the domain if the hypercalls happen to > originate from logic in user mode or kernel mode.  Stubdomains would > fall into the same "kernel" category as xengt in the dom0 i915 driver. > > However, the actual bug I'm trying to fix with this is the need for > userspace, which doesn't link against libxc, to do > > #define __XEN_TOOLS__ > #include > > to be able to use the libxendevicemodel stable library. > > The __XEN_TOOLS__ guard is buggy even ignoring the kernel device model > aspect. Depends on what __XEN_TOOLS__ really means - to guard things accessible to any part of the tool stack, or to guard unstable interfaces only. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 08:33:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 08:33:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96393.182294 (Exim 4.92) (envelope-from ) id 1lKGkt-0000FY-9a; Thu, 11 Mar 2021 08:33:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96393.182294; Thu, 11 Mar 2021 08:33:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGkt-0000FR-6M; Thu, 11 Mar 2021 08:33:15 +0000 Received: by outflank-mailman (input) for mailman id 96393; Thu, 11 Mar 2021 08:33:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKGkr-0000FM-Ir for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 08:33:13 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7dcdca86-8e75-472e-97bd-bf4c487d8215; Thu, 11 Mar 2021 08:33:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0668FAC16; Thu, 11 Mar 2021 08:33:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7dcdca86-8e75-472e-97bd-bf4c487d8215 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615451592; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v3TLjU1ZaXzkM5cq4AeizWMlcoE7mIvra9RmiAnL7qQ=; b=TGcDWXdqEEMN1g9FapfaMiT4WwAYEOYrwhHC8yVu9I3J4aspwYyjPv0VgM8GOMHlxdx+oP afvVdUAHolt2Jf8lZdzH7vlFnKjYujnHUgKc0T+OE+Ba5+I8OLNF52aYvOCUGKrwdMqQRg 5GoH58RJunnVc30HMTRByW12uGIt5Zs= Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <6bd14438-7dec-2176-eab5-5898f190c4d8@suse.com> <952ca444-2091-b7f1-3559-c728a63af37f@suse.com> From: Jan Beulich Message-ID: <957e6cab-657a-c72d-b5c7-f2e84e976a21@suse.com> Date: Thu, 11 Mar 2021 09:33:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11.03.2021 09:25, Roger Pau Monné wrote: > On Thu, Mar 11, 2021 at 09:09:22AM +0100, Jan Beulich wrote: >> On 10.03.2021 18:52, Julien Grall wrote: >>> On 10/03/2021 16:21, Jan Beulich wrote: >>>> On 10.03.2021 15:58, Julien Grall wrote: >>>>> On 10/03/2021 10:13, Jan Beulich wrote: >>>>> 2) A compiler will not be able to help us if we are adding code >>>>> without initialized vaddrs. >>>>> >>>>> It also feels wrong to me to try to write Xen in a way that will make a >>>>> 10 years compiler happy... >>>> >>>> As said above - we've worked around limitations quite a few times >>>> in the past. This is just one more instance. >>> >>> I find amusing you wrote that when you complained multiple time when >>> someone was re-using existing bad pattern. :) >> >> Well, thing is - I don't view this as a bad pattern. The only question >> really is whether NULL is a good initializer here. As per above a non- >> canonical pointer may be better, but then we have quite a few places >> elsewhere to fix. > > Sorry for jumping in the middle but I think that would be a very > dangerous move for Xen to do. We have been using implicit conversions > of pointers to booleans all over the place, assuming that NULL == > false, hence NULL no longer mapping to false would break a lot of our > code. ie: > > if ( foo ) > free(foo); > > Would no longer work as expected. Funny you should give this example: Assuming you mean xfree(), it specifically tolerates both NULL and ZERO_BLOCK_PTR (the latter because xmalloc() may return it, and that's what it was invented for). But yes - other non-NULL checking guards would indeed break. I'm afraid every possible solution here has its downsides, and the suggested change simply follows the pattern we used so far in similar cases - without anyone objecting. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 09:02:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 09:02:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96398.182306 (Exim 4.92) (envelope-from ) id 1lKHCe-00037Z-Km; Thu, 11 Mar 2021 09:01:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96398.182306; Thu, 11 Mar 2021 09:01:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKHCe-00037S-GS; Thu, 11 Mar 2021 09:01:56 +0000 Received: by outflank-mailman (input) for mailman id 96398; Thu, 11 Mar 2021 09:01:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKHCd-00037N-5L for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 09:01:55 +0000 Received: from mail-wr1-x434.google.com (unknown [2a00:1450:4864:20::434]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b11a59e5-cf2f-489a-85d2-4d5b8dc3561c; Thu, 11 Mar 2021 09:01:53 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id y16so933684wrw.3 for ; Thu, 11 Mar 2021 01:01:53 -0800 (PST) Received: from ?IPv6:2a00:23c5:5785:9a01:ad53:27c8:8931:32bf? ([2a00:23c5:5785:9a01:ad53:27c8:8931:32bf]) by smtp.gmail.com with ESMTPSA id 3sm3096719wry.72.2021.03.11.01.01.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Mar 2021 01:01:52 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b11a59e5-cf2f-489a-85d2-4d5b8dc3561c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Orp3Bk0hKm0aeaWNTiYcbHxTKdI6bsXJmidsqgGPQnA=; b=raRGHMmL6dL9HjiNq7tGPH9/33AcwIgRcpDSF3vITUz7CyNkKn+z7bar4MywLXRoDb hYXCN/33PVEg9Cjt7pJrK4WeeOLN+PZeCuokCj0CjSmCmMtdDRWbx5PpRswvHgZghX2d aMyt209Swi/FvNb1ykOAhQMNrc7Ct6eCBzOptFtGcplNtIJ7tiMaef/vmmOU7qBKBoGg H9+v2BfgRxK/pLRzeSCnvPksSHZpUutv6x1LDurS+fujDfIKK33pyzxQmrRczcAuuKSv gSt7Qj85JqsrZYDfS5Xuph4v9ppk882ZZrbaKVvJ4DKaYZO06NMCETsSe+fT31SkRSUE FCfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Orp3Bk0hKm0aeaWNTiYcbHxTKdI6bsXJmidsqgGPQnA=; b=RTxwxFW15JDp/hdENB2hz6WTzeHBlK4drUmaqBlb8Zzrqah7w0okg0zBTMop14dwQ6 +3WNUXHuVu4VbjNRKkkBIlBsWVLVRXHdWv5Sb3uJVOo7+KZrkTLjxC2byou3G38P2ayL fHzDGNlXPYtLcQpVGLiPDKu6gj8XZ/ClzIh8RXImnEl7Gzx5olPTPwrOH0Zp4R/u5jBZ qi1tiHN5F+gedHf/0em6H4KbdQfYX4P5h08j0836QvGIl3ZJ0RKO7yImV30EMyGK+gf6 m5pxtN5ghmLHwthmsGkWTXm+Er120AiGIv3y34lxm/IH49C3v9zlTontqCWLNA9KcSLf echw== X-Gm-Message-State: AOAM531NNqNpRlC0xABCraTelUuDYb2b/udS3pJdSu2B/liPd8Df6BpF pBmcR+hHF48afxfCbBNBUiquE82EcAM= X-Google-Smtp-Source: ABdhPJxLPEWEsOD3Re+nDuE/Wy0VJNVA27JxAAYvZybqzNbq+HzX7eLpwcdRJz+z1OqZkGHK3SFwyw== X-Received: by 2002:a5d:4e83:: with SMTP id e3mr7650591wru.82.1615453312782; Thu, 11 Mar 2021 01:01:52 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: xen-blkfront: BUG_ON(info->nr_rings) To: xen-devel@lists.xenproject.org References: Message-ID: Date: Thu, 11 Mar 2021 09:01:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/03/2021 14:58, Jason Andryuk wrote: > Hi, > > I was running a loop of `xl block-attach ; xl block-detach` and I > triggered a BUG in xen-blkfront, drivers/block/xen-blkfront.c:1917 > This is BUG_ON(info->nr_rings) in negotiate_mq called by blkback_changed. > > I'm using Linux 5.4.103 and blktap3 on Xen 4.12 (OpenXT), though I > don't think that matters. The backtrace and some preceding logs (from > the reproducer) are below. > > I just repro-ed with this: > path= > xenstore-write $path 5 ; xenstore-write $path 4 > > info->nr_rings is still set because of the unexpected transition > XenbusStateClosing -> XenbusStateConnected: > dom7: [ 2866.574853] vbd vbd-51728: blkfront:blkback_changed to state 5. > dom7: [ 2866.578385] vbd vbd-51728: blkfront:blkback_changed to state 4. > > I'm not totally sure how to handle this. The XenbusStateConnected > event should be creating a new blkfront device, but instead it's seen > by the old one which hasn't been cleaned up yet. > Sounds like blkfront needs to be fixed. Once it is in state 5 the only state it should go to should be 6. From there it can cycle back to 4. Paul > After this BUG, the xenwatch thread is gone. The VM is still running, > but watches aren't triggering anymore. > > Regards, > Jason > > dom7: [ 2866.494691] vbd vbd-51728: blkfront:blkback_changed to state 1. > tapback[27208]: backend.c:276 51728 physical_device_changed > tapback[27208]: backend.c:362 51728 found tapdisk[17223], for 254:9 > tapdisk[17223]: VBD 9 got disk info: sectors=147456 sector size=512, info=0 > xl: [18012] libxl_disk.c:303:device_disk_add:Domain 7:device already > exists in xenstore > xl: [18012] libxl_device.c:1468:device_addrm_aocomplete:unable to add device > dom7: [ 2866.507702] vbd vbd-51728: blkfront:blkback_changed to state 2. > xl: [18022] libxl_disk.c:303:device_disk_add:Domain 7:device already > exists in xenstore > xl: [18026] libxl_disk.c:303:device_disk_add:Domain 7:device already > exists in xenstore > xl: [18024] libxl_disk.c:303:device_disk_add:Domain 7:device already > exists in xenstore > xl: [18022] libxl_device.c:1468:device_addrm_aocomplete:unable to add device > xl: [18018] libxl_disk.c:303:device_disk_add:Domain 7:device already > exists in xenstore > xl: [18026] libxl_device.c:1468:device_addrm_aocomplete:unable to add device > xl: [18024] libxl_device.c:1468:device_addrm_aocomplete:unable to add device > xl: [18018] libxl_device.c:1468:device_addrm_aocomplete:unable to add device > xl: [18038] libxl_disk.c:303:device_disk_add:Domain 7:device already > exists in xenstore > xl: [18034] libxl_disk.c:303:device_disk_add:Domain 7:device already > exists in xenstore > xl: [18038] libxl_device.c:1468:device_addrm_aocomplete:unable to add device > xl: [18034] libxl_device.c:1468:device_addrm_aocomplete:unable to add device > xl: [18030] libxl_disk.c:303:device_disk_add:Domain 7:device already > exists in xenstore > xl: [18030] libxl_device.c:1468:device_addrm_aocomplete:unable to add device > tapback[27208]: frontend.c:216 51728 front-end supports persistent > grants but we don't > tapdisk[17223]: connecting VBD 9 domid=7, devid=51728, pool (null), > evt 12, poll duration 0, poll idle threshold 0 > tapdisk[17223]: ring 0x74ce10 connected > dom7: [ 2866.536144] vbd vbd-51728: blkfront:blkback_changed to state 5. > xl: [18020] libxl_disk.c:303:device_disk_add:Domain 7:device already > exists in xenstore > xl: [18016] libxl_disk.c:303:device_disk_add:Domain 7:device already > exists in xenstore > xl: [18020] libxl_device.c:1468:device_addrm_aocomplete:unable to add device > xl: [18016] libxl_device.c:1468:device_addrm_aocomplete:unable to add device > xl: [18036] libxl_disk.c:303:device_disk_add:Domain 7:device already > exists in xenstore > dom7: [ 2866.544439] vbd vbd-51728: blkfront:blkback_changed to state 5. > xl: [18036] libxl_device.c:1468:device_addrm_aocomplete:unable to add device > dom7: [ 2866.555778] vbd vbd-51728: blkfront:blkback_changed to state 5. > dom7: [ 2866.565810] vbd vbd-51728: blkfront:blkback_changed to state 5. > dom7: [ 2866.574853] vbd vbd-51728: blkfront:blkback_changed to state 5. > dom7: [ 2866.578385] vbd vbd-51728: blkfront:blkback_changed to state 4. > dom7: [ 2866.578655] ------------[ cut here ]------------ > dom7: [ 2866.578662] kernel BUG at .../drivers/block/xen-blkfront.c:1917! > dom7: [ 2866.578681] invalid opcode: 0000 [#1] SMP PTI > dom7: [ 2866.578688] CPU: 0 PID: 76 Comm: xenwatch Tainted: G O 5.4.103 #1 > dom7: [ 2866.578699] RIP: 0010:talk_to_blkback+0x7b7/0xdb0 > dom7: [ 2866.578706] Code: ff ff fa ff e9 5d fb ff ff 49 8b 56 08 48 > 8b b3 08 01 00 00 8b 7c 24 1c e8 96 bb ff ff 85 c0 0f 84 60 ff ff ff > e9 4b ff ff ff <0f> 0b 48 c7 c2 0c e7 c0 81 be f4 ff ff ff 4c 89 f7 e8 > c3 ff fa ff > dom7: [ 2866.578727] RSP: 0018:ffffc900004e3d80 EFLAGS: 00010202 > dom7: [ 2866.578734] RAX: 0000000000000001 RBX: ffff88801df68200 RCX: > 0000000000000000 > dom7: [ 2866.578743] RDX: 000000000000004a RSI: ffff88801d20ab80 RDI: > 0000000000000000 > dom7: [ 2866.578752] RBP: ffff88801e31a800 R08: 00000000000003c6 R09: > 0000000000000800 > dom7: [ 2866.578761] R10: ffffc900004d3db0 R11: 00000000000002da R12: > ffffffff81ea4410 > dom7: [ 2866.578770] R13: dead000000000122 R14: ffff88801e31a800 R15: > ffff88801df68200 > dom7: [ 2866.578779] FS: 0000000000000000(0000) > GS:ffff88801f200000(0000) knlGS:0000000000000000 > dom7: [ 2866.578789] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > dom7: [ 2866.578797] CR2: 00007f34ade5a0d4 CR3: 000000001d0bc003 CR4: > 00000000003606b0 > dom7: [ 2866.578807] DR0: 0000000000000000 DR1: 0000000000000000 DR2: > 0000000000000000 > dom7: [ 2866.578815] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: > 0000000000000400 > dom7: [ 2866.578825] Call Trace: > dom7: [ 2866.578830] blkback_changed+0x14a/0xc50 > dom7: [ 2866.578836] ? find_watch+0x40/0x40 > dom7: [ 2866.578841] ? xenbus_read_driver_state+0x34/0x60 > dom7: [ 2866.578848] ? find_watch+0x40/0x40 > dom7: [ 2866.578853] xenwatch_thread+0x97/0x160 > dom7: [ 2866.578859] ? wait_woken+0x80/0x80 > dom7: [ 2866.578866] kthread+0xf3/0x130 > dom7: [ 2866.578871] ? kthread_create_worker_on_cpu+0x70/0x70 > dom7: [ 2866.578879] ret_from_fork+0x35/0x40 > dom7: [ 2866.578884] Modules linked in: xen_argo(O) > dom7: [ 2866.578890] ---[ end trace 06163b0483faf9c0 ]--- > dom7: [ 2866.578898] RIP: 0010:talk_to_blkback+0x7b7/0xdb0 > dom7: [ 2866.586251] Code: ff ff fa ff e9 5d fb ff ff 49 8b 56 08 48 > 8b b3 08 01 00 00 8b 7c 24 1c e8 96 bb ff ff 85 c0 0f 84 60 ff ff ff > e9 4b ff ff ff <0f> 0b 48 c7 c2 0c e7 c0 81 be f4 ff ff ff 4c 89 f7 e8 > c3 ff fa ff > dom7: [ 2866.586276] RSP: 0018:ffffc900004e3d80 EFLAGS: 00010202 > dom7: [ 2866.586288] RAX: 0000000000000001 RBX: ffff88801df68200 RCX: > 0000000000000000 > dom7: [ 2866.586301] RDX: 000000000000004a RSI: ffff88801d20ab80 RDI: > 0000000000000000 > dom7: [ 2866.586315] RBP: ffff88801e31a800 R08: 00000000000003c6 R09: > 0000000000000800 > dom7: [ 2866.586325] R10: ffffc900004d3db0 R11: 00000000000002da R12: > ffffffff81ea4410 > dom7: [ 2866.586339] R13: dead000000000122 R14: ffff88801e31a800 R15: > ffff88801df68200 > dom7: [ 2866.586354] FS: 0000000000000000(0000) > GS:ffff88801f200000(0000) knlGS:0000000000000000 > dom7: [ 2866.586368] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > dom7: [ 2866.586376] CR2: 00007f34ade5a0d4 CR3: 000000001d0bc003 CR4: > 00000000003606b0 > dom7: [ 2866.586390] DR0: 0000000000000000 DR1: 0000000000000000 DR2: > 0000000000000000 > dom7: [ 2866.586404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: > 0000000000000400 > tapdisk[17223]: disconnecting domid=7, devid=51728 > From xen-devel-bounces@lists.xenproject.org Thu Mar 11 09:17:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 09:17:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96401.182318 (Exim 4.92) (envelope-from ) id 1lKHRR-0004CM-W0; Thu, 11 Mar 2021 09:17:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96401.182318; Thu, 11 Mar 2021 09:17:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKHRR-0004CF-SS; Thu, 11 Mar 2021 09:17:13 +0000 Received: by outflank-mailman (input) for mailman id 96401; Thu, 11 Mar 2021 09:17:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKHRQ-0004CA-Ia for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 09:17:12 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 74d10d2a-dbfc-4dc3-bdd2-17aecacd35b4; Thu, 11 Mar 2021 09:17:10 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DAB3A1FB; Thu, 11 Mar 2021 01:17:09 -0800 (PST) Received: from [10.57.15.166] (unknown [10.57.15.166]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 713D63F70D; Thu, 11 Mar 2021 01:17:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74d10d2a-dbfc-4dc3-bdd2-17aecacd35b4 Subject: Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Ian Jackson , Julien Grall Cc: Jan Beulich , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210310065803.348-1-michal.orzel@arm.com> <3247ee1d-f843-7c74-20a4-315716a91097@suse.com> <24648.44686.272676.156900@mariner.uk.xensource.com> <24648.52045.413392.930954@mariner.uk.xensource.com> From: Michal Orzel Message-ID: Date: Thu, 11 Mar 2021 10:17:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <24648.52045.413392.930954@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10.03.2021 14:36, Ian Jackson wrote: > Julien Grall writes ("Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE"): >> I was under the impression that this patch would not target 4.15. At >> least I didn't see any request for it. > > OK, good :-). > > Thanks, > Ian. > So do you guys want me to push v5 now with fix "help" or will the commiter do this? Michal From xen-devel-bounces@lists.xenproject.org Thu Mar 11 09:31:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 09:31:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96404.182330 (Exim 4.92) (envelope-from ) id 1lKHf9-00061S-7E; Thu, 11 Mar 2021 09:31:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96404.182330; Thu, 11 Mar 2021 09:31:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKHf9-00061L-3v; Thu, 11 Mar 2021 09:31:23 +0000 Received: by outflank-mailman (input) for mailman id 96404; Thu, 11 Mar 2021 09:31:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKHf7-00061G-N7 for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 09:31:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKHf6-0001m0-Ee; Thu, 11 Mar 2021 09:31:20 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lKHf6-0006bK-2I; Thu, 11 Mar 2021 09:31:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=xUgZGw0PM4aGrq8PRtjULlOHasMLa7vf5FqAOS9c090=; b=Z1InrgFn0c/VuJkl8vgtgAEp6n fptAdbsD7gr/8IoOABFA/Qi34oMiek0fh5tXb6N20TTUDBudWQF2yzpGw9uGqC5TgxYrdi0rceGxn h9rrV3PK2tKG+knzmAGCC2nZkdaH8yyKzdBUip33PFECfpBEDpoHjGYVgKjc64idrsPY=; Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) To: Jan Beulich Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210306214148.27021-1-julien@xen.org> <1897022d-7591-3450-4e57-884a2860b13d@suse.com> <7fd07dc9-9c03-bb13-3907-c3c268a4e970@xen.org> <2de5160f-8636-5cdf-a20c-acaa2640c893@suse.com> <7ab87cab-8836-e8a0-993e-0cdeca3c45e3@xen.org> <2bc2ad13-8636-e5d4-3a4a-722c75e3b92a@suse.com> From: Julien Grall Message-ID: <6048b3f0-b131-9ced-9521-a935e5b337eb@xen.org> Date: Thu, 11 Mar 2021 09:31:17 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <2bc2ad13-8636-e5d4-3a4a-722c75e3b92a@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 11/03/2021 08:17, Jan Beulich wrote: > On 10.03.2021 19:05, Julien Grall wrote: >> On 09/03/2021 11:20, Jan Beulich wrote: >>> On 08.03.2021 21:22, Julien Grall wrote: >>>> On 08/03/2021 11:20, Jan Beulich wrote: >>>>> On 08.03.2021 11:51, Julien Grall wrote: >>>>>> On 08/03/2021 08:09, Jan Beulich wrote: >>>>>>> Additionally - partly related to your own reply regarding the CI >>>>>>> failures - imo there needs to be an analysis of what older distros >>>>>>> will no longer build (at all or by default). >>>>>> >>>>>> Per the CI, this would be Ubuntu Trusty (and older), Centos 7 (and older) >>>>>> >>>>>> Do you have any other in mind? >>>>> >>>>> Our SLE12 (latest service pack is SP5 and still has a while to go >>>>> to at least reach LTSS state) comes with gcc 4.8 as the default >>>>> compiler. >>>> >>>> Thanks! That's good to know. Is it the old GCC Suse supports? >>> >>> Not sure I understand the question: The default compiler of this or >>> any distro is of course (expected to be) supported by the vendor >>> for the lifetime of the OS. >> >> Sorry for the wording. I was asking whether Suse also supports compiler >> older than GCC 4.8. > > Oh, I see. SLES11 has another year to go for LTSS to end, and it's 4.3 > which is used there. Thanks for the info! Are you planning to build Xen 4.15 there too? > >>>>>>>> --- a/xen/include/xen/compiler.h >>>>>>>> +++ b/xen/include/xen/compiler.h >>>>>>>> @@ -5,6 +5,19 @@ >>>>>>>> #error Sorry, your compiler is too old/not recognized. >>>>>>>> #endif >>>>>>>> >>>>>>>> +#if CONFIG_CC_IS_GCC >>>>>>>> +# if CONFIG_GCC_VERSION < 40900 >>>>>>>> +/* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ >>>>>>> >>>>>>> As per the bug report, the issue was determined to not be present >>>>>>> in e.g. 4.3. Hence while such a bug may influence our choice of >>>>>>> minimum version, I don't think it can reasonably be named here as >>>>>>> the apparent only reason for the choice. Personally I don't think >>>>>>> any justification should be put here. >>>>>> >>>>>> Ok. >>>>>> >>>>>>> >>>>>>>> +# error Sorry, your version of GCC is too old - please use 4.9 or newer. >>>>>>>> +# elif defined(CONFIG_ARM_64) && CONFIG_GCC_VERSION < 50100 >>>>>>>> +/* >>>>>>>> + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 >>>>>>>> + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk >>>>>>>> + */ >>>>>>>> +# error Sorry, your version of GCC is too old - please use 5.1 or newer. >>>>>>> >>>>>>> From the bug entry the fix looks to have been backported to 4.9, >>>>>>> or at least some (important?) branches thereof. >>>>>> >>>>>> It is not clear what's you are trying to point out. Mind clarifying? >>>>> >>>>> Some 4.9 compilers (perhaps widely used ones) may not have the bad >>>>> issue, which puts under question their ruling out when the main >>>>> reason for doing so is that bug. >>>> >>>> Well... We could surely try to hunt which GCC 4.9 has been fixed. But I >>>> am not convinced this is useful, we would need to have an allowlist of >>>> GCC compiler. >>> >>> Or probe the compiler for the bug in question. >> >> I thought about it but it is not clear to me whether the reproducer >> would work on every GCC version and how to detect that this was miscompiled. >> >> Do you have any suggestion? > > To have one I'd have to study the problem in quite a bit more detail. > But I did say that what you do for Arm is largely up to you (and > Stefano did meanwhile ack the Arm side), so I'm not sure I want to > invest the time that would be needed. Well, there are still miscompilation problem on x86... So it would be good to have a way to address it. Anyway, I will split the Arm change in a separate patch so it can go in 4.15. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 11 09:40:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 09:40:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96410.182347 (Exim 4.92) (envelope-from ) id 1lKHoG-00073P-Ao; Thu, 11 Mar 2021 09:40:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96410.182347; Thu, 11 Mar 2021 09:40:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKHoG-00073I-7q; Thu, 11 Mar 2021 09:40:48 +0000 Received: by outflank-mailman (input) for mailman id 96410; Thu, 11 Mar 2021 09:40:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKHoE-00073D-NY for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 09:40:46 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f4168d23-4778-427b-ab71-434787f94cf1; Thu, 11 Mar 2021 09:40:45 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3E146AC16; Thu, 11 Mar 2021 09:40:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4168d23-4778-427b-ab71-434787f94cf1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615455644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1XVkrEfKmBVOU6F+L+VVfC9OHCsEz9IKiz0UT5qoCQE=; b=MZqljq3IQAm31q6uxSEDAaFiKhtAirMgPS3ixjN4ZYyKYth1Q+3U2oqsl5t9tDvtzOUsRv YeDa7TMLqN6ZPUrOSP1foQTd/UL0oUTQ0nZvsc6mlb+tnfhcStOYMyUNa8Png+F3m81zxq itxFjCWpndQy+o41c1uNHzQhu6KPn7s= Subject: [PATCH] xen: fix for_each_cpu when NR_CPUS=1 From: Dario Faggioli To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Date: Thu, 11 Mar 2021 09:40:43 +0000 Message-ID: <161545564302.24868.14477928469038686899.stgit@Wayrath> User-Agent: StGit/0.23 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit When running an hypervisor build with NR_CPUS=1 for_each_cpu does not take into account whether the bit of the CPU is set or not in the provided mask. This means that whatever we have in the bodies of these loops is always done once, even if the mask was empty and it should never be done. This is clearly a bug and was in fact causing an assert to trigger in credit2 code. Removing the special casing of NR_CPUS == 1 makes things work again. Signed-off-by: Dario Faggioli --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu --- I'm not really sure whether this should be 4.15 material. It's definitely a bug, IMO. The risk is also pretty low, considering that no one should really run Xen in this configuration (NR_CPUS=1, I mean). Which is also the reason why it's probably not really important that we fix it at this point of the release cycle. --- xen/include/xen/cpumask.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/xen/include/xen/cpumask.h b/xen/include/xen/cpumask.h index 256b60b106..e69589fc08 100644 --- a/xen/include/xen/cpumask.h +++ b/xen/include/xen/cpumask.h @@ -368,15 +368,10 @@ static inline void free_cpumask_var(cpumask_var_t mask) #define FREE_CPUMASK_VAR(m) free_cpumask_var(m) #endif -#if NR_CPUS > 1 #define for_each_cpu(cpu, mask) \ for ((cpu) = cpumask_first(mask); \ (cpu) < nr_cpu_ids; \ (cpu) = cpumask_next(cpu, mask)) -#else /* NR_CPUS == 1 */ -#define for_each_cpu(cpu, mask) \ - for ((cpu) = 0; (cpu) < 1; (cpu)++, (void)(mask)) -#endif /* NR_CPUS */ /* * The following particular system cpumasks and operations manage From xen-devel-bounces@lists.xenproject.org Thu Mar 11 09:48:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 09:48:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96414.182360 (Exim 4.92) (envelope-from ) id 1lKHvU-0007ME-33; Thu, 11 Mar 2021 09:48:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96414.182360; Thu, 11 Mar 2021 09:48:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKHvU-0007M5-01; Thu, 11 Mar 2021 09:48:16 +0000 Received: by outflank-mailman (input) for mailman id 96414; Thu, 11 Mar 2021 09:48:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKHvS-0007M0-BB for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 09:48:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKHvR-00022O-4N; Thu, 11 Mar 2021 09:48:13 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lKHvQ-0007m4-S4; Thu, 11 Mar 2021 09:48:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=3cqelGmI07pHVY8hVPWi3fhqvD0roAVrxauEZew+z0s=; b=kuZpvvSVok9dY5p69Tz+NME7NV pj/k038DQ7OQsVyHRAvqwkytBiLspyXYZpokt6IbtkSkVv85hQt1dF/On5HCnuCawonOcw7vbziLI YA91gfviZyYcforefAWYyjK0+lrxhJpOnLKoGD9Nnd9x/Q/2aJdoDZJTh5avo5wd5Bxs=; Subject: Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() To: Ian Jackson Cc: Jan Beulich , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , raphning@amazon.co.uk, Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-3-julien@xen.org> <0994b7a0-c537-b312-b134-caf54c79c87f@suse.com> <74568cd7-143b-48ad-b9be-bf4229655376@suse.com> <7eb12174-3268-ccdb-df9c-c4fe23d3a332@xen.org> <24642.14600.124181.19574@mariner.uk.xensource.com> <0249af89-ced0-0f7f-d370-9ffade6b1678@xen.org> <24645.61961.964574.269753@mariner.uk.xensource.com> From: Julien Grall Message-ID: <1ec1c5b8-3802-873c-36a2-ea9637345302@xen.org> Date: Thu, 11 Mar 2021 09:48:11 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24645.61961.964574.269753@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Ian, On 08/03/2021 09:44, Ian Jackson wrote: > Julien Grall writes ("Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}()"): >> Would the following comment work for you? >> >> /* Function pointer as xprintf() can be configured at runtime. */ >> >> I can fold it in my patch while committing. > > Sure, thanks. FTAOD > > Reviewed-by: Ian Jackson > Release-Acked-by: Ian Jackson > > to that comment addition. Thanks! I have committed the two patches. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 11 09:55:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 09:55:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96419.182379 (Exim 4.92) (envelope-from ) id 1lKI2R-0008HJ-Tp; Thu, 11 Mar 2021 09:55:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96419.182379; Thu, 11 Mar 2021 09:55:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKI2R-0008HC-Qt; Thu, 11 Mar 2021 09:55:27 +0000 Received: by outflank-mailman (input) for mailman id 96419; Thu, 11 Mar 2021 09:55:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKI2P-0008Gt-QD for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 09:55:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKI2O-0002Ab-Gx; Thu, 11 Mar 2021 09:55:24 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lKI2O-0008FB-5u; Thu, 11 Mar 2021 09:55:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Wc7PHMegeQlqr3XGkjq6u6HbJjpLeO6qTp+ms/Kl+yg=; b=OT5QDv//1IGW6Go4ZBDqpmtPDS iiHFn7D44+bq74GRvtumGpf8TBrnNyu//f4oBOYuA/k9zA8at1sC7vrNO/EXFC/QYIeRu6tuqmDBi A8BzZkH02FVXht9+s978YuJyyOwu9c/YoOGVd926R+z823nzBq36xtBHx0L08yleVR/4=; Subject: Re: [PATCH for-4.15] arm: replace typeof() with __typeof__() To: Ian Jackson , Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Volodymyr Babchuk , George Dunlap , Wei Liu , Juergen Gross , xen-devel@lists.xenproject.org, Elliott Mitchell References: <202103092114.129LEgZp059925@m5p.com> <24648.44584.312512.639736@mariner.uk.xensource.com> From: Julien Grall Message-ID: <65481c0a-5c1f-5c87-0697-72a04654f90c@xen.org> Date: Thu, 11 Mar 2021 09:55:22 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24648.44584.312512.639736@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi, On 10/03/2021 11:31, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH for-4.15] arm: replace typeof() with __typeof__()"): >> On 09.03.2021 22:27, Andrew Cooper wrote: >>> This wants backporting as a build fix, so should be considered for 4.15 >>> at this point. > > Release-Acked-by: Ian Jackson Thanks! I have committed the patch now. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 11 09:59:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 09:59:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96425.182396 (Exim 4.92) (envelope-from ) id 1lKI6W-00007w-Jd; Thu, 11 Mar 2021 09:59:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96425.182396; Thu, 11 Mar 2021 09:59:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKI6W-00007p-Fy; Thu, 11 Mar 2021 09:59:40 +0000 Received: by outflank-mailman (input) for mailman id 96425; Thu, 11 Mar 2021 09:59:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKI6V-00007k-0L for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 09:59:39 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dada5450-2c69-4a33-ac0e-b618df77eb8c; Thu, 11 Mar 2021 09:59:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dada5450-2c69-4a33-ac0e-b618df77eb8c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615456775; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=wIRbsGN4ZKu1v3I5qQBKYn7QajOrmyqygcYS6gU9eLE=; b=E8OEuSemPEg6WO28Fo6aUNOBR1nkt+J545iFSRIT3GW5hU2bGywydGa0 moT+5knCFXi+oKbTvMITw+zvD4Ehf4O0kdTOmB31wX4+w8ydi76QlL7Rc yAkbJZIMtEUJqCM+BeUzMyRx7ZCRU87i/+11tQzlertIX0fdXmMLfeIex A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: iYhU9LbygTERJV8Lza/Fj30iXuuDA3j+3YKMTZviaC2SgTF5lJR0fkkXaHHVuMRXFow3ovv1Yo jFYXDWFgm5KWv7Q4zRsRi12rDo1IsS8fpF9Rz2gzsI3nY5EIh9M0MgqGAONkH87S3NrPjs3BDV J4spJ9C7qLsEL+b2h5az4eC9CpHYILdes5+JKykR75Ux1YQ4Gf5RB2lL60wPk1P+Ey+/zIMp1/ gK1UaYt4H8o8Kted2ufGe9pH2lLGYboIueezumcTUFlbycfGU7FCQVMlg8FqHktbaImCtXPfAl MPs= X-SBRS: 5.2 X-MesageID: 39402064 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:0GdAOqjikEm8fLH/fefRlmT6h3BQX1Jw3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+YsFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmuZ tIW5NVTOf9BV0St6vHySGlDtctx8SG+qi0heHYi0xgVx1udrsI1WZEIyywe3cGIDVuL5w/CZ aa+457vDKmY3sadYCWAXMCUujFqbTw5ejbSDQBAAMq7xTLsCOw5NfBYmOl9zo9cxcK+7ct9m DZjxf0j5/Mj9iXwgLRvlWjiah+t8DmzrJ4da6xo+w0DhmptQqyfoRmXNS5zU4IicWi8kwjnt WJgzpIBbUL11rrcmu4oQTg1mDbuV5EgR+Sqi7pvVLZrdHkXzV/MsJdhOtiA2TkwnA9t9Jx2r 8j5RP/i7NrC3r77UHAzumNfRRrmk2omGElgO4egldOOLFuFIN5nMgx+lhYH4wHGz+/wIc7EP N2BMWZ3/pOd0iGBkqp81VH8ZiIczALBRGNTlIZtsH96UkjoFlJi28jgOAPlHYJ85wwD7FC+u T/K6xt0JVDVNUfY65RDPoIKPHHRlDlcFbpCia/MF7nHKYINzbmsJjs+og44+msZdgh0IYysI 6paiIYiUcCP2bVTeGe1pxC9R7ABE+nWy72981Y759l/pXhWbvQNzGZQlxGqbrvn9wvRungH9 qjMpNfBPHuaUH0H5xS4gH4U55ObVYEVsk4vcs6RkKursrHJpaCjJ2ZTN/jYJ7WVRo0UGL2BX UOGBLpIt9b00ytUnjkxDjdMkmdOHDXzNZVKuz37uITwI8COslnqQ4Ok2m04cmNNHlnuqwyd0 1uHaP/nsqA1CyL1FeNy18sFgtWD05T7rmleWhNvxU2P0T9dqtGnNmDZ2ZI3j+iKgVkR83bVC 5Tzm4Htp6fHti1/2QPGtinOmWVgz84v3SRVaoRnaWF+IPCYZM3DpEvXYRrDgXVHxlJmQJnwV 0zKDMsdwv6LHfDmK+lhJsbCKX0bN9nmjqmJsZStDbir0mGnNouQXEaRjaqdsaSjW8VNn5pr2 w015VarKuLmD6pJ2d6pOgjKlVDZF6aB698AB2faJ9Zna3qfw9MXX6H7Abq+i0bSy7PzQE/l2 bhJSqbdbXwDl1Rtmtx/4zq/Fl3H1/tN35YWzRfi8lQBG7GsnF83au3faK1yXKWcUZH6PoaKi v5bTwbJR5Oy9i72AWOoiuLEWwry/wVT6vgJYVmV4uW9mKmKYWOm61DIuRd+4x9Msvy9sAMSu CSdmauXUTFItJs/zbQgHkrOCN58iZ51dzp3QDo92i+0joUB+HILFFvWrEcJJW94gHfNoS1+a Q8qehwm+26dljVQJqh74r8ajZYMBPdoWKsVYgT2NlplJN3kIE2JoXRVDvD6WpO0xo/JvrljU 92etUJ3JnxfqtUO/EIcy1X/lAVhM2CAUsivAvxGPI/dzgW/grmFuLMx7LJrLY1a3fx3DfYCB 268ydH+e3CUDbG/bkGC7goKWA+Ujl21F1SuMeDfZbXEgOkaqVq+0e7KGa0dPt4RLKeEbsd6j Z87NfgpZ7cSwPInCTRtyB8OKRA7iKORt6zGhuFHapwyOOBUG789JeC0YqUlzf4STyydkQei8 lkTCUrH7l+owhnqpY23Ci0QrHwuWQ/nTJlkHdaqmI= X-IronPort-AV: E=Sophos;i="5.81,240,1610427600"; d="scan'208,223";a="39402064" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mr9cqDOOXd7HA9suTlSu/RTZtEYf1DnQ6CMGtUjV3pow3J4Hq/mtEnSdPxkWiwDTnLN1wCYh15YhPXn/kHLBMwNz+cQ/nsv5TncEk9/CcLTgZuLfjtRTv9yjMZw3Rq7OWJrbbHWf+FJnVQCFGIPguYVLHmX/PxRkay/Myoa5FdmJTqJ7iK0NsW8PhjMs5R/UqZJdhpwV1MTCtB0PzgyLAo8TdBD9VOa6oyG91sZSSDOYXrFIQiwfTSDhR2XqXiBK6csDqnRxXbYuMF3GAz5rudK4o5WRaAUHw822oSifDoCSHFZwvtk5UHdV27IY09PjOKUPtPo8CJni6ShZcKH2IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HzhLKUTaPXnVkcI98OV/eAAQi3Y9/MTk1MqGWIaaYWk=; b=EBZmWAm9s/dW0nbYrWJAIAlH0fPSGlI6El39/u9m+VB0NvYW5vc+Mf4tXd3fFqS4xZ7FSM/Aa6+I6KpGj/8Ig4Dd70WrPDRSs+oxMifLCJESc2YpKB3Oh8Obg64JqrAOkWn2AJh28OH/s+FEjZqRYjbmovILoZ9v0pYSUQJs/j8p7TxrnDjw0wmy5b8vHpytGQ/90ROiY0L4wv34awxXspysx3UYIJQl5ohMszHT8nyj8xv9KEgXNsfarJaxUcx/nL/3a7nWO2/RHqogrK5bDstX9k6OK7Kgz3WRrA5vwt/1EKaDpAOdrWOOb+DIPafHr+i9MF3mqxnNX30/SnocBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HzhLKUTaPXnVkcI98OV/eAAQi3Y9/MTk1MqGWIaaYWk=; b=Ir8odBgV9U3rbWZSIesfNtQNvZQEMR6wUKG41CC+hz+HrdzUXJW6l8HfKc7Pnqd+SIplq1XBnRJwTu1IDmok6mgWVyJ45Goo1db/GdcezTnrvGCMmpf9wk+ivtu0+/T0bpqqrInPgwUjT7T0d+vPt+whM7y2PkrRFqN65r/7evs= From: Roger Pau Monne To: CC: Roger Pau Monne , Ian Jackson , Wei Liu , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Anthony PERARD , Christian Lindig , David Scott , Jun Nakajima , Kevin Tian , Boris Ostrovsky Subject: [PATCH v5 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection Date: Thu, 11 Mar 2021 10:59:17 +0100 Message-ID: <20210311095918.40490-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0387.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 304408a1-0985-4981-0723-08d8e4745c53 X-MS-TrafficTypeDiagnostic: DM6PR03MB5084: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NvJNDveCko+/AR62ksM54SVxNPnPjwLg1FeSO+kyDpcKL9sTd4CP3M6tdcqH/JORvWrIvo13CQ5KLz6GGLRH1DAo5ViDS9RYinecWxKz4ZiRJx3tFlEowK1GLxHXSVQrwGvwEk9EWKjHHHtUGF8PtRxnbJl9ULRMah3PW0iDh2nArYz8xC3vdd8Rf2P3chjHBzex89IdaDhNDm6uANKDppDjaTmHAO/h2sK/bFO9OcLqyfuQqzKzW84/ZSoG64+POWo9FUnaBSCJLzMU36c8DJPYdSw9eB2gUAZjRI6tCsReI7WVHFvNHBQYIPDPSpTA6Ce3pujc1ixSW5g61EV4n5sx6QZCKWnlXR3M5jOW9MDJD1JREUHaHYyRzwKBiRC0FPV/b3vMtJ+u0qmDKissueAzuRC0Lg0nbR3v4gAvqujw69xPVDJdlibgp9+JZAA2aHQH7fvl1a1EngtKUupaz7ss4gKNrDxyB6xpoeZw7AoeR0FvQJCY55ftAnxla25okAkBdyOsnmNj55vtiqsWjw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(136003)(39860400002)(346002)(366004)(186003)(4326008)(2906002)(16526019)(478600001)(5660300002)(36756003)(7416002)(66946007)(8676002)(83380400001)(2616005)(1076003)(26005)(956004)(6916009)(316002)(6496006)(6666004)(66556008)(66476007)(8936002)(6486002)(86362001)(54906003)(30864003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?R3dCM2ExZDFzSlg2VzNuQ253NGJIVm1TRVdqSmxXc2c5Z3BGbGUwMWx1emVu?= =?utf-8?B?MlIyZUdsTkpzUUxyOVNrWVQ3UFUwOWc2MzhXcnprWWJ2UHJoWkpRWXo2b1dH?= =?utf-8?B?VmVjYVRoMFNvRmNYSktlUWlSMnYwR0srMmo3NGxTUmJ6R1ZPdXE1Mk8xT1pt?= =?utf-8?B?LzVBdjYraEI0U2xwbGJsaHdGRWtwZlRCYURwQlEySGMxVEY4c3NaZ1Frdk90?= =?utf-8?B?NVM3dnNuMjVRMkJBY1pkTGdVblVmK2lRUDBKazZqSmNnMTFPd0ppU0dRKzZZ?= =?utf-8?B?Ynhaa250cElmSFlwWnBRTjlNYmw1SzVsaC9uMjREV3lic3VzbUh0OFJsTFRT?= =?utf-8?B?SlJ3N2p6K0VGWkpzYkwxemNJdERISXFyZWtQd01SU1ozWUdHclhmWjJZajBM?= =?utf-8?B?K0lmYlZaZWUvL2RQWVdmNmNnZk5LVERVQ3FrWmlabDRnN0tUcFc3MzlwWEJj?= =?utf-8?B?ZUhyWWp0MkNnL0JFOEtDNmplM3BlL0VKeUMwUi9yd0dJemU3dHFsdHhDeTFB?= =?utf-8?B?UG13dmsrNjhhVURybWJsdUtjZGxnazcxVit3Q1pxYWlWTTFNaGJaTm4zeUxO?= =?utf-8?B?QXBzQi92YkZIMU9IdFN5MWQ1OStHcWZmVGZaZVVyN2VCN3IwZE9Tblp3NkVG?= =?utf-8?B?dzhQNG5vSWFqOFN0bDlYbEc5ZUZ4SlFnbEwxN2RCYzJObksvcENOQ05YZjgz?= =?utf-8?B?SzUzc25nMW0xS3ZQNGZ3L3VkL1FtVXFJMmRsai9wQmF3aXErSnlmNGRVNlhM?= =?utf-8?B?eXZVTG9RbTlYVTBEV1pLM21oTjNIdVV0M0RiOU5hTGFqc3YzV1JBRHB5dWhF?= =?utf-8?B?QURCblJhMVRTMXJNMkoySWhSMlJpNFBOSHRrR0Exc1YxdGpHczBDS2xTbitR?= =?utf-8?B?OFNCbzF5elFZZ3UwK2dmSlNibnMvRFAxODhuTWZ6dTNQclFnTHlrWXBUUEtS?= =?utf-8?B?aUtWVG4vYXR4RUZsWUVQZjFrQUU0SzIwend3YkpNOGtHZHVLZWMyMHJEN2NK?= =?utf-8?B?MEREUWpzaU5pUW00THlMQXFESy9SeUxVTTRiSEFXUnhaZTh5WkhrQklXb2dS?= =?utf-8?B?RVNUZ3h6THpWMUJuazQ1YWlxKzYzdGczcmtnUklsZnExVGprWCt3dGM3a1dy?= =?utf-8?B?U2JDN0hqemNocUlwb01lZDhBTWxKNEZVdUFteTMxM2J1dzJHL0k0NVpqejRi?= =?utf-8?B?VmNHMERQenlZSW1RV3VSUEY5c0J4cktocTNZbG8wbEhXRzZrWDExQ1FDVWlp?= =?utf-8?B?ZWNrU0hwMlg3KzFNeEpkNFJremVvMmJwKzZ3dk5jYWdWdHVTQXpTb0Uvb3k4?= =?utf-8?B?YXFkMXN6R1liK2kxdXo3YW00K1Zwd1FDeHlPbjRNSWcxK2NnYjZ6NlBsRm1x?= =?utf-8?B?aXJ0NkV0OEQ0Slg3S0RnWTBpNzJDNlR0Rnh3K090aWxObFA3VDJnM0RnZit1?= =?utf-8?B?ZUNCUjJINVRRRGROZk5JZ2hBS21UZFpTTisxL09uSmZMSDFkd0d2TUlNditJ?= =?utf-8?B?bFpCd3Brb2xMcFp1L2ZXSXlQTGplVEVIZmRrSktKK3pNVzJEeVpBaGR4L2xj?= =?utf-8?B?b0k0aGZESm55MVYvaXVQOWNmajFsVXJHR3hCNS9OSzRXL1pnMHYvNWpkOXpC?= =?utf-8?B?TGlzTHFVeDN1Qk9QWmJFZ1YxcFd6T1IxQU85SlRWeWhsdFBEdGNsczZRSENZ?= =?utf-8?B?d0dVUFY0U005WHhKRWxremJOdE5XTHJvdjFCZmVLVHEzalR2Qm0rTWlUeG1P?= =?utf-8?Q?WGc45Z63fVK0woK0TIb3JDjExlrPWUdZEsXttzY?= X-MS-Exchange-CrossTenant-Network-Message-Id: 304408a1-0985-4981-0723-08d8e4745c53 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 09:59:29.1927 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xm0inhNUZ/1OdGX/dGT+15BVUj/ZWoTlaIWQrqI/MPHBfev9uhXDjmhbX43pY0qNvkX+RdtZ4snB9XklMTVy/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5084 X-OriginatorOrg: citrix.com Introduce an option to allow selecting a behavior similar to the pre Xen 4.15 one for accesses to MSRs not explicitly handled. Since commit 84e848fd7a162f669 and 322ec7c89f6640e accesses to MSRs not explicitly handled by Xen result in the injection of a #GP to the guest. This is a behavior change since previously a #GP was only injected if accessing the MSR on the real hardware would also trigger a #GP, or if the attempted to be set bits wouldn't match the hardware values (for PV). The reasons for not leaking hardware MSR values and injecting a #GP are fully valid, so the solution proposed here should be considered a temporary workaround until all the required MSRs are properly handled. This seems to be problematic for some guests, so introduce an option to fallback to this kind of legacy behavior without leaking the underlying MSR values to the guest. When the option is set, for both PV and HVM don't inject a #GP to the guest on MSR read if reading the underlying MSR doesn't result in a #GP, do the same for writes and simply discard the value to be written on that case. Note that for guests restored or migrated from previous Xen versions the option is enabled by default, in order to keep a compatible MSR behavior. Such compatibility is done at the libxl layer, to avoid higher-level toolstacks from having to know the details about this flag. Signed-off-by: Roger Pau Monné Acked-by: Christian Lindig Reviewed-by: Ian Jackson Reviewed-by: Andrew Cooper Release-Acked-by: Ian Jackson --- Cc: Boris Ostrovsky --- Boris, could you please test with Solaris to see if this fixes the issue? >From a release PoV there are risks of taking this patch, as it touches several different areas. So it could break MSR handling or domain creation. I think however we would be able to spot such breakages in osstest. Not taking the patch would put us in an awkward position if people migrating from < 4.15 find their guests no longer boot (or crash on migration) on newer Xen versions, hence I think we need to accept the risk. --- Changes since v4: - Fix xl.cfg man page. Changes since v3: - Slightly adjust commit message. - Change the description of the option. - s/domain_flags/misc_flags/. - Adjust setting of misc_flags in create_dom0. Changes since v2: - Apply the option to both HVM and PV guest. - Handle both reads and writes. - Rename to msr_relaxed. - Introduce a Xen commnad line option to set it for dom0. - Set it unconditionally for guests being restored or migrated from previous Xen versions. - Provide the option to dom0. - Attempt at adding the ocaml helpers (build tested only). Changes since v1: - Only apply the option to HVM guests. - Only apply the special handling to MSR reads. - Sanitize the newly introduced flags field. - Print a warning message when the option is used. --- docs/man/xl.cfg.5.pod.in | 14 ++++++++++++++ docs/misc/xen-command-line.pandoc | 14 +++++++++++++- tools/include/libxl.h | 7 +++++++ tools/libs/light/libxl_arch.h | 5 +++++ tools/libs/light/libxl_arm.c | 6 ++++++ tools/libs/light/libxl_create.c | 7 +++++++ tools/libs/light/libxl_internal.c | 3 +++ tools/libs/light/libxl_types.idl | 2 ++ tools/libs/light/libxl_x86.c | 20 ++++++++++++++++++++ tools/ocaml/libs/xc/xenctrl.ml | 4 ++++ tools/ocaml/libs/xc/xenctrl.mli | 4 ++++ tools/ocaml/libs/xc/xenctrl_stubs.c | 9 +++++++++ tools/xl/xl_parse.c | 7 +++++++ xen/arch/x86/dom0_build.c | 3 +++ xen/arch/x86/domain.c | 9 +++++++++ xen/arch/x86/hvm/svm/svm.c | 10 ++++++++++ xen/arch/x86/hvm/vmx/vmx.c | 10 ++++++++++ xen/arch/x86/pv/emul-priv-op.c | 10 ++++++++++ xen/arch/x86/setup.c | 3 +++ xen/include/asm-x86/domain.h | 3 +++ xen/include/asm-x86/setup.h | 1 + xen/include/public/arch-x86/xen.h | 8 ++++++++ 22 files changed, 158 insertions(+), 1 deletion(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 040374dcd6..56370a37db 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -2861,6 +2861,20 @@ No MCA capabilities in above list are enabled. =back +=item B + +The "msr_relaxed" boolean is an interim option, and defaults to false. + +In Xen 4.15, the default behaviour for unhandled MSRs has been changed, +to avoid leaking host data into guests, and to avoid breaking guest +logic which uses #GP probing to identify the availability of MSRs. + +However, this new stricter behaviour has the possibility to break +guests, and a more 4.14-like behaviour can be selected by setting this +option. + +If using this option is necessary to fix an issue, please report a bug. + =back =head1 SEE ALSO diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 4737c92bfe..a0601ff838 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -740,7 +740,7 @@ Specify the bit width of the DMA heap. ### dom0 = List of [ pv | pvh, shadow=, verbose=, - cpuid-faulting= ] + cpuid-faulting=, msr-relaxed= ] Applicability: x86 @@ -789,6 +789,18 @@ Controls for how dom0 is constructed on x86 systems. restore the pre-4.13 behaviour. If specifying `no-cpuid-faulting` fixes an issue in dom0, please report a bug. +* The `msr-relaxed` boolean is an interim option, and defaults to false. + + In Xen 4.15, the default behaviour for unhandled MSRs has been changed, + to avoid leaking host data into guests, and to avoid breaking guest + logic which uses \#GP probing to identify the availability of MSRs. + + However, this new stricter behaviour has the possibility to break + guests, and a more 4.14-like behaviour can be selected by specifying + `dom0=msr-relaxed`. + + If using this option is necessary to fix an issue, please report a bug. + ### dom0-iommu = List of [ passthrough=, strict=, map-inclusive=, map-reserved=, none ] diff --git a/tools/include/libxl.h b/tools/include/libxl.h index a7b673e89d..ae7fe27c1f 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -495,6 +495,13 @@ */ #define LIBXL_HAVE_VMTRACE_BUF_KB 1 +/* + * LIBXL_HAVE_X86_MSR_RELAXED indicates the toolstack has support for switching + * the MSR access handling in the hypervisor to relaxed mode. This is done by + * setting the libxl_domain_build_info arch_x86.msr_relaxed field. + */ +#define LIBXL_HAVE_X86_MSR_RELAXED 1 + /* * libxl ABI compatibility * diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h index c305d704b1..8527fc5c6c 100644 --- a/tools/libs/light/libxl_arch.h +++ b/tools/libs/light/libxl_arch.h @@ -85,6 +85,11 @@ int libxl__arch_extra_memory(libxl__gc *gc, const libxl_domain_build_info *info, uint64_t *out); +_hidden +void libxl__arch_update_domain_config(libxl__gc *gc, + libxl_domain_config *dst, + const libxl_domain_config *src); + #if defined(__i386__) || defined(__x86_64__) #define LAPIC_BASE_ADDRESS 0xfee00000 diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 5e2a209a8b..e2901f13b7 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -1222,6 +1222,12 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, return rc; } +void libxl__arch_update_domain_config(libxl__gc *gc, + libxl_domain_config *dst, + const libxl_domain_config *src) +{ +} + /* * Local variables: * mode: C diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index 46f68da697..1131b2a733 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -2287,6 +2287,13 @@ int libxl_domain_create_restore(libxl_ctx *ctx, libxl_domain_config *d_config, unset_disk_colo_restore(d_config); } + /* + * When restoring (either from a save file or for a migration domain) set + * the MSR relaxed mode for compatibility with older Xen versions if the + * option is not set as part of the original configuration. + */ + libxl_defbool_setdefault(&d_config->b_info.arch_x86.msr_relaxed, true); + return do_domain_create(ctx, d_config, domid, restore_fd, send_back_fd, params, ao_how, aop_console_how); } diff --git a/tools/libs/light/libxl_internal.c b/tools/libs/light/libxl_internal.c index d93a75533f..86556b6113 100644 --- a/tools/libs/light/libxl_internal.c +++ b/tools/libs/light/libxl_internal.c @@ -16,6 +16,7 @@ #include "libxl_osdeps.h" /* must come before any other headers */ #include "libxl_internal.h" +#include "libxl_arch.h" void libxl__alloc_failed(libxl_ctx *ctx, const char *func, size_t nmemb, size_t size) { @@ -594,6 +595,8 @@ void libxl__update_domain_configuration(libxl__gc *gc, /* video ram */ dst->b_info.video_memkb = src->b_info.video_memkb; + + libxl__arch_update_domain_config(gc, dst, src); } static void ev_slowlock_init_internal(libxl__ev_slowlock *lock, diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 5b85a7419f..f45adddab0 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -644,6 +644,8 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), ("vuart", libxl_vuart_type), ])), + ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), + ])), # Alternate p2m is not bound to any architecture or guest type, as it is # supported by x86 HVM and ARM support is planned. ("altp2m", libxl_altp2m_mode), diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c index 58187ed760..ac09897a63 100644 --- a/tools/libs/light/libxl_x86.c +++ b/tools/libs/light/libxl_x86.c @@ -19,6 +19,10 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, abort(); } + config->arch.misc_flags = 0; + if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed)) + config->arch.misc_flags |= XEN_X86_MSR_RELAXED; + return 0; } @@ -809,6 +813,7 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc, libxl_domain_build_info *b_info) { libxl_defbool_setdefault(&b_info->acpi, true); + libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false); } int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, @@ -851,6 +856,21 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, return rc; } +void libxl__arch_update_domain_config(libxl__gc *gc, + libxl_domain_config *dst, + const libxl_domain_config *src) +{ + /* + * Force MSR relaxed to be set (either to true or false) so it's part of + * the domain configuration when saving or performing a live-migration. + * + * Doing so allows the recovery side to figure out whether the flag should + * be set to true in order to keep backwards compatibility with already + * started domains. + */ + libxl_defbool_setdefault(&dst->b_info.arch_x86.msr_relaxed, + libxl_defbool_val(src->b_info.arch_x86.msr_relaxed)); +} /* * Local variables: diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index a02e26b27f..a5588c643f 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -48,9 +48,13 @@ type x86_arch_emulation_flags = | X86_EMU_USE_PIRQ | X86_EMU_VPCI +type x86_arch_misc_flags = + | X86_MSR_RELAXED + type xen_x86_arch_domainconfig = { emulation_flags: x86_arch_emulation_flags list; + misc_flags: x86_arch_misc_flags list; } type arch_domainconfig = diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index d2a312e273..6e94940a8a 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -42,8 +42,12 @@ type x86_arch_emulation_flags = | X86_EMU_USE_PIRQ | X86_EMU_VPCI +type x86_arch_misc_flags = + | X86_MSR_RELAXED + type xen_x86_arch_domainconfig = { emulation_flags: x86_arch_emulation_flags list; + misc_flags: x86_arch_misc_flags list; } type arch_domainconfig = diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index 9a8dbe5579..d05d7bb30e 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -233,6 +233,15 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config #undef VAL_EMUL_FLAGS +#define VAL_MISC_FLAGS Field(arch_domconfig, 1) + + cfg.arch.misc_flags = ocaml_list_to_c_bitmap + /* ! x86_arch_misc_flags X86_ none */ + /* ! XEN_X86_ XEN_X86_MSR_RELAXED all */ + (VAL_MISC_FLAGS); + +#undef VAL_MISC_FLAGS + #else caml_failwith("Unhandled: x86"); #endif diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 1893cfc086..9fb0791429 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2741,6 +2741,13 @@ skip_usbdev: xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat", &c_info->xend_suspend_evtchn_compat, 0); + if (!xlu_cfg_get_defbool(config, "msr_relaxed", + &b_info->arch_x86.msr_relaxed, 0)) + fprintf(stderr, + "WARNING: msr_relaxed will be removed in future versions.\n" + "If it fixes an issue you are having please report to " + "xen-devel@lists.xenproject.org.\n"); + xlu_cfg_destroy(config); } diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 0ce29e91a3..74b443e509 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -256,6 +256,7 @@ bool __initdata opt_dom0_shadow; #endif bool __initdata opt_dom0_pvh = !IS_ENABLED(CONFIG_PV); bool __initdata opt_dom0_verbose = IS_ENABLED(CONFIG_VERBOSE_DEBUG); +bool __initdata opt_dom0_msr_relaxed; static int __init parse_dom0_param(const char *s) { @@ -282,6 +283,8 @@ static int __init parse_dom0_param(const char *s) else if ( IS_ENABLED(CONFIG_PV) && (val = parse_boolean("cpuid-faulting", s, ss)) >= 0 ) opt_dom0_cpuid_faulting = val; + else if ( (val = parse_boolean("msr-relaxed", s, ss)) >= 0 ) + opt_dom0_msr_relaxed = val; else rc = -EINVAL; diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 5e3c94d3fa..b212729880 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -683,6 +683,13 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) } } + if ( config->arch.misc_flags & ~XEN_X86_MSR_RELAXED ) + { + dprintk(XENLOG_INFO, "Invalid arch misc flags %#x\n", + config->arch.misc_flags); + return -EINVAL; + } + return 0; } @@ -852,6 +859,8 @@ int arch_domain_create(struct domain *d, domain_cpu_policy_changed(d); + d->arch.msr_relaxed = config->arch.misc_flags & XEN_X86_MSR_RELAXED; + return 0; fail: diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index b819897a4a..4585efe1f8 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -1795,6 +1795,7 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) const struct domain *d = v->domain; struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; const struct nestedsvm *nsvm = &vcpu_nestedsvm(v); + uint64_t tmp; switch ( msr ) { @@ -1965,6 +1966,12 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) break; default: + if ( d->arch.msr_relaxed && !rdmsr_safe(msr, tmp) ) + { + *msr_content = 0; + break; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", msr); goto gpf; } @@ -2151,6 +2158,9 @@ static int svm_msr_write_intercept(unsigned int msr, uint64_t msr_content) break; default: + if ( d->arch.msr_relaxed && !rdmsr_safe(msr, msr_content) ) + break; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", msr, msr_content); diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index bfea1b0f8a..b52824677e 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3123,6 +3123,7 @@ static int is_last_branch_msr(u32 ecx) static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content) { struct vcpu *curr = current; + uint64_t tmp; HVM_DBG_LOG(DBG_LEVEL_MSR, "ecx=%#x", msr); @@ -3204,6 +3205,12 @@ static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content) break; } + if ( curr->domain->arch.msr_relaxed && !rdmsr_safe(msr, tmp) ) + { + *msr_content = 0; + break; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", msr); goto gp_fault; } @@ -3505,6 +3512,9 @@ static int vmx_msr_write_intercept(unsigned int msr, uint64_t msr_content) is_last_branch_msr(msr) ) break; + if ( v->domain->arch.msr_relaxed && !rdmsr_safe(msr, msr_content) ) + break; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", msr, msr_content); diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c index e5a22b9347..74e71403ff 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -875,6 +875,7 @@ static int read_msr(unsigned int reg, uint64_t *val, const struct domain *currd = curr->domain; const struct cpuid_policy *cp = currd->arch.cpuid; bool vpmu_msr = false; + uint64_t tmp; int ret; if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) @@ -986,6 +987,12 @@ static int read_msr(unsigned int reg, uint64_t *val, } /* fall through */ default: + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, tmp) ) + { + *val = 0; + return X86EMUL_OKAY; + } + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); break; @@ -1148,6 +1155,9 @@ static int write_msr(unsigned int reg, uint64_t val, } /* fall through */ default: + if ( currd->arch.msr_relaxed && !rdmsr_safe(reg, val) ) + return X86EMUL_OKAY; + gdprintk(XENLOG_WARNING, "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", reg, val); diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 23bbb6e8c1..68454df8ed 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -749,6 +749,9 @@ static struct domain *__init create_dom0(const module_t *image, .max_grant_frames = -1, .max_maptrack_frames = -1, .max_vcpus = dom0_max_vcpus(), + .arch = { + .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, + }, }; struct domain *d; char *cmdline; diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h index 3900d7b48b..7213d184b0 100644 --- a/xen/include/asm-x86/domain.h +++ b/xen/include/asm-x86/domain.h @@ -437,6 +437,9 @@ struct arch_domain /* Mem_access emulation control */ bool_t mem_access_emulate_each_rep; + /* Don't unconditionally inject #GP for unhandled MSRs. */ + bool msr_relaxed; + /* Emulated devices enabled bitmap. */ uint32_t emulation_flags; } __cacheline_aligned; diff --git a/xen/include/asm-x86/setup.h b/xen/include/asm-x86/setup.h index 642a5e8460..24be46115d 100644 --- a/xen/include/asm-x86/setup.h +++ b/xen/include/asm-x86/setup.h @@ -65,6 +65,7 @@ extern bool opt_dom0_shadow; extern bool opt_dom0_pvh; extern bool opt_dom0_verbose; extern bool opt_dom0_cpuid_faulting; +extern bool opt_dom0_msr_relaxed; #define max_init_domid (0) diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h index 629cb2ba40..6bf1e8cccb 100644 --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -304,6 +304,14 @@ struct xen_arch_domainconfig { XEN_X86_EMU_PIT | XEN_X86_EMU_USE_PIRQ |\ XEN_X86_EMU_VPCI) uint32_t emulation_flags; + +/* + * Select whether to use a relaxed behavior for accesses to MSRs not explicitly + * handled by Xen instead of injecting a #GP to the guest. Note this option + * doesn't allow the guest to read or write to the underlying MSR. + */ +#define XEN_X86_MSR_RELAXED (1u << 0) + uint32_t misc_flags; }; /* Location of online VCPU bitmap. */ -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 10:04:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 10:04:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96430.182408 (Exim 4.92) (envelope-from ) id 1lKIAX-00015m-8c; Thu, 11 Mar 2021 10:03:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96430.182408; Thu, 11 Mar 2021 10:03:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKIAX-00015f-5k; Thu, 11 Mar 2021 10:03:49 +0000 Received: by outflank-mailman (input) for mailman id 96430; Thu, 11 Mar 2021 10:03:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKIAV-00015a-KB for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 10:03:47 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7f41bf96-6f13-44d1-8822-397f7f101b01; Thu, 11 Mar 2021 10:03:45 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 14E6AAB8C; Thu, 11 Mar 2021 10:03:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f41bf96-6f13-44d1-8822-397f7f101b01 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615457025; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zrBv3yeNQEi4FTxVugbZXds0AEKq7Mvbc2a2lRJY2NY=; b=s/HnHuR0Vq8+vCNuY4Jcd/4byaFQRwoP58YP+aKAVIYwPRAlBvOrEi8hT2oQSd7hV+QWhd m+ioUCfdRWCmaKgg58i8qPohLMJUN5iXwCZ9WDmTO0O0f771VRVbCXA4DVqaaGKBtNGwIE TYx2r1JBkyZT/gfqk80jydlxtOMpxms= Subject: Re: [PATCH] xen: fix for_each_cpu when NR_CPUS=1 To: Dario Faggioli , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <161545564302.24868.14477928469038686899.stgit@Wayrath> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <56a8d23e-fb81-c1bb-1cb4-f0f74d80fb59@suse.com> Date: Thu, 11 Mar 2021 11:03:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <161545564302.24868.14477928469038686899.stgit@Wayrath> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="w7gTCpuakZWKQJf7O4hYgFKIg1G2PhE8S" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --w7gTCpuakZWKQJf7O4hYgFKIg1G2PhE8S Content-Type: multipart/mixed; boundary="Tibby8DABs1JDji2gMJ56LRe5HWENJR2R"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Dario Faggioli , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Message-ID: <56a8d23e-fb81-c1bb-1cb4-f0f74d80fb59@suse.com> Subject: Re: [PATCH] xen: fix for_each_cpu when NR_CPUS=1 References: <161545564302.24868.14477928469038686899.stgit@Wayrath> In-Reply-To: <161545564302.24868.14477928469038686899.stgit@Wayrath> --Tibby8DABs1JDji2gMJ56LRe5HWENJR2R Content-Type: multipart/mixed; boundary="------------4DF93F1E9B9E1A54608ABA86" Content-Language: en-US This is a multi-part message in MIME format. --------------4DF93F1E9B9E1A54608ABA86 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 11.03.21 10:40, Dario Faggioli wrote: > When running an hypervisor build with NR_CPUS=3D1 for_each_cpu does not= > take into account whether the bit of the CPU is set or not in the > provided mask. >=20 > This means that whatever we have in the bodies of these loops is always= > done once, even if the mask was empty and it should never be done. This= > is clearly a bug and was in fact causing an assert to trigger in credit= 2 > code. >=20 > Removing the special casing of NR_CPUS =3D=3D 1 makes things work again= =2E >=20 > Signed-off-by: Dario Faggioli > --- > Cc: Andrew Cooper > Cc: George Dunlap > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Julien Grall > Cc: Stefano Stabellini > Cc: Wei Liu > --- > I'm not really sure whether this should be 4.15 material. >=20 > It's definitely a bug, IMO. The risk is also pretty low, considering > that no one should really run Xen in this configuration (NR_CPUS=3D1, I= > mean). Which is also the reason why it's probably not really important > that we fix it at this point of the release cycle. > --- > xen/include/xen/cpumask.h | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/xen/include/xen/cpumask.h b/xen/include/xen/cpumask.h > index 256b60b106..e69589fc08 100644 > --- a/xen/include/xen/cpumask.h > +++ b/xen/include/xen/cpumask.h > @@ -368,15 +368,10 @@ static inline void free_cpumask_var(cpumask_var_t= mask) > #define FREE_CPUMASK_VAR(m) free_cpumask_var(m) > #endif > =20 > -#if NR_CPUS > 1 > #define for_each_cpu(cpu, mask) \ > for ((cpu) =3D cpumask_first(mask); \ > (cpu) < nr_cpu_ids; \ > (cpu) =3D cpumask_next(cpu, mask)) > -#else /* NR_CPUS =3D=3D 1 */ > -#define for_each_cpu(cpu, mask) \ > - for ((cpu) =3D 0; (cpu) < 1; (cpu)++, (void)(mask)) > -#endif /* NR_CPUS */ Wouldn't it make sense to drop the other NR_CPUS =3D=3D 1 optimization further down, too? IMO this is adding clutter for no real gain, as NR_CPUS =3D=3D 1 Xen hypervisor builds aiming at high performance are probably not existing anywhere in the universe. Juergen --------------4DF93F1E9B9E1A54608ABA86 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------4DF93F1E9B9E1A54608ABA86-- --Tibby8DABs1JDji2gMJ56LRe5HWENJR2R-- --w7gTCpuakZWKQJf7O4hYgFKIg1G2PhE8S Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBJ6wAFAwAAAAAACgkQsN6d1ii/Ey8U RAf9EZ+AYD7wC7n6JwmhbaotDCQ3ZTkMy3jy06XpcXNKjsXvLZ6Memywm0LTb9tPWsSYN51o2QAB 8z88RhSAKbPPL3rwt+Hb3Q8cqZQWA/BCwHKJunjhFIHMU9TnG/z2cc97wrDYXbC5WGkVDX5egCiV nMzGKdRWY13JtfTAA7U3F/PgilcTRAKAtX1w3mAini5bE0W+hb7Fc63fnsiSxLeXp0KjXwEbp1bb d5Tt3csx7bmCZVoliK7wr7F/F8/UItB5FoVmrumidHUC4pSL2A3rzhMiKKyKsA9DI43DVEAZH8lj BUEzrUSrQxoKQIHZR125bwoXUYxAC31iXlvOuk0SuA== =/i7+ -----END PGP SIGNATURE----- --w7gTCpuakZWKQJf7O4hYgFKIg1G2PhE8S-- From xen-devel-bounces@lists.xenproject.org Thu Mar 11 10:13:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 10:13:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96433.182420 (Exim 4.92) (envelope-from ) id 1lKIJO-00026A-6u; Thu, 11 Mar 2021 10:12:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96433.182420; Thu, 11 Mar 2021 10:12:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKIJO-000263-2k; Thu, 11 Mar 2021 10:12:58 +0000 Received: by outflank-mailman (input) for mailman id 96433; Thu, 11 Mar 2021 10:12:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKIJM-00025y-BL for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 10:12:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKIJL-0002Xd-R3; Thu, 11 Mar 2021 10:12:55 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lKIJL-00018C-Fu; Thu, 11 Mar 2021 10:12:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=eEyMBKpoNP9ql0m/rd4jgmK2wYuRIpoCHFEgsknSATI=; b=Cyz2rTG05EfrR7pY9fG5gqoRCM iFVAFggQOt7No6wJ+quCddloAosPuPbhXvGsAFsqIcCo+RhGNtkiqNnOJxq+avBZzCH3uI6hrtl/9 FK8Kviedzjkjua0wa3YCOMKfMvzSMSRql+LWhL080L9lYqGbiNJGwBqjUVQGV3l3Ttc0=; Subject: Re: [PATCH] xen/arm: Use register_t type in cpuinfo entries To: Bertrand Marquis , Jan Beulich Cc: Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" References: <712d7c6a-3ace-a6b7-a188-faeb4f1258d3@xen.org> <5bb482ff-a689-67e3-1bc7-30b9bf24034e@suse.com> <70193A3D-F169-41C3-96AF-D2C35ADAF1C9@arm.com> From: Julien Grall Message-ID: <6aa28aef-1d0e-393e-a9b8-c6b24cd19eb8@xen.org> Date: Thu, 11 Mar 2021 10:12:53 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <70193A3D-F169-41C3-96AF-D2C35ADAF1C9@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Bertrand, On 09/03/2021 14:41, Bertrand Marquis wrote: >> On 9 Mar 2021, at 12:04, Jan Beulich wrote: >> >> On 08.03.2021 20:48, Julien Grall wrote: >>> On 08/03/2021 17:18, Bertrand Marquis wrote: >>>> --- a/xen/arch/arm/smpboot.c >>>> +++ b/xen/arch/arm/smpboot.c >>>> @@ -321,7 +321,8 @@ void start_secondary(void) >>>> if ( !opt_hmp_unsafe && >>>> current_cpu_data.midr.bits != boot_cpu_data.midr.bits ) >>>> { >>>> - printk(XENLOG_ERR "CPU%u MIDR (0x%x) does not match boot CPU MIDR (0x%x),\n" >>>> + printk(XENLOG_ERR "CPU%u MIDR (0x%"PRIregister") does not match boot " >>>> + "CPU MIDR (0x%"PRIregister"),\n" >>> >>> For printk messages, we don't tend to split it like that (even for more >>> than 80 characters one). Instead, the preferred approach is: >>> >>> printk(XENLOG_ERR >>> "line 1\n" >>> "line 2\n") >> >> Except of course you want to repeat XENLOG_ERR for the 2nd line. Interesting, I always thought a single XENLOG_* was enough for multi-line in the same printk. > > Very right. > > @Julien: feel free to tell me if you want a v2. I would prefer if you resend a v2. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 11 10:27:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 10:27:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96436.182432 (Exim 4.92) (envelope-from ) id 1lKIWq-0003AA-DJ; Thu, 11 Mar 2021 10:26:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96436.182432; Thu, 11 Mar 2021 10:26:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKIWq-0003A3-AA; Thu, 11 Mar 2021 10:26:52 +0000 Received: by outflank-mailman (input) for mailman id 96436; Thu, 11 Mar 2021 10:26:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKIWp-00039y-Os for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 10:26:51 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:7e1a::60e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 55fd182b-1a82-4d64-b580-9ae95ffd812f; Thu, 11 Mar 2021 10:26:49 +0000 (UTC) Received: from MR2P264CA0026.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::14) by PAXPR08MB6511.eurprd08.prod.outlook.com (2603:10a6:102:12d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.19; Thu, 11 Mar 2021 10:26:47 +0000 Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:0:cafe::dc) by MR2P264CA0026.outlook.office365.com (2603:10a6:500::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.26 via Frontend Transport; Thu, 11 Mar 2021 10:26:47 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Thu, 11 Mar 2021 10:26:46 +0000 Received: ("Tessian outbound e7a0046930fb:v71"); Thu, 11 Mar 2021 10:26:46 +0000 Received: from 885227bcc84a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 75B14BD4-2501-46FB-A143-95AE2806733B.1; Thu, 11 Mar 2021 10:26:39 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 885227bcc84a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 11 Mar 2021 10:26:39 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VI1PR08MB3472.eurprd08.prod.outlook.com (2603:10a6:803:80::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Thu, 11 Mar 2021 10:26:36 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3912.030; Thu, 11 Mar 2021 10:26:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55fd182b-1a82-4d64-b580-9ae95ffd812f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fuNJ2+CnWrPxceuoCyo1ZM+5HwsOBWqSU3aTw+TBMDc=; b=qdwgqxT7MDxMAKjxzGV3LkFEvRDP3kwhQokdqK+RmX3T2hA2mWuwIJqlH48SMuGF0Gngo47gaupHo6RrL5bNwQVBqbtEBFeW6I73k2cncNhId6Fsl/kUVNC9we4suCZ3+4DafF+nZqgOsCCFsfm/xTAT1y3/pXkjiO1y1c5BtHI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: e1391520195a69b9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FTndZl3nOnI2e/8MZmVnZzbyNqZq7+XDd0L4se0UB+oPfHP6h8+olXzB8rKfnlwOaQWqPKDs8psMmw55Jo4kkACZceHYOLH6jILOyeuz4ipxsFtK72BTnBz/R0KlYafoG1n7DdaE4b172+tpkUVAvz5f72Iq1b3My0Ll1A3cdkd722lBWBJUVjncvNQRLqke+m/6x0/knJKTouYX7oI5m2FLDHya15asx81rMkhlzfOtxnRtM1RlSZRR06psz/5+jq48QLWOTgvlo+DRbijVa3ib6BKffte1azW8Psd4BnAXpxfVB5xY7TgzQe5ZAzIuh97he/jsUmRxAeP47SuBGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fuNJ2+CnWrPxceuoCyo1ZM+5HwsOBWqSU3aTw+TBMDc=; b=HwPapKJnjRLgxoresQNDIFB2dGXeMFWjU5jzPEZbx8whmx6mWgkUNOr15okljeCflICXi3h6O6VEcoSliOIOm9Amo2KdM4n7EiILdspCG05YjZyFxMM2ngO65W2y1xyYlrrwSArgsH7u4V4YG5xRQMYK+AH55Emp/ZLl/Fz0Utj8T6LzYf+mMAtEvdwHrdBV0fxz4QVbo9rjEy0rzSBavSqnjfLG30dMihHOU90hYZVQqJgIGQURMEhN3DT8BlMvHb+XwdkyVGUU8m6AWnHzNTxUBYWeC0LJeilJPeXbhbchbCMLkte4Q++exqDi7UZePBX5QWyIcySfSQjiJjlyAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fuNJ2+CnWrPxceuoCyo1ZM+5HwsOBWqSU3aTw+TBMDc=; b=qdwgqxT7MDxMAKjxzGV3LkFEvRDP3kwhQokdqK+RmX3T2hA2mWuwIJqlH48SMuGF0Gngo47gaupHo6RrL5bNwQVBqbtEBFeW6I73k2cncNhId6Fsl/kUVNC9we4suCZ3+4DafF+nZqgOsCCFsfm/xTAT1y3/pXkjiO1y1c5BtHI= From: Bertrand Marquis To: Julien Grall CC: Jan Beulich , Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen/arm: Use register_t type in cpuinfo entries Thread-Topic: [PATCH] xen/arm: Use register_t type in cpuinfo entries Thread-Index: AQHXFFQNaLCX4oSw+0OC1jGtjtl2z6p7f0oAgAA8pICAAtmcgIAAA9UA Date: Thu, 11 Mar 2021 10:26:36 +0000 Message-ID: <6CB45CBC-81CF-4855-9B6D-DAA0BC3E4057@arm.com> References: <712d7c6a-3ace-a6b7-a188-faeb4f1258d3@xen.org> <5bb482ff-a689-67e3-1bc7-30b9bf24034e@suse.com> <70193A3D-F169-41C3-96AF-D2C35ADAF1C9@arm.com> <6aa28aef-1d0e-393e-a9b8-c6b24cd19eb8@xen.org> In-Reply-To: <6aa28aef-1d0e-393e-a9b8-c6b24cd19eb8@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.243.24.187] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: db3aea9a-a456-4fc9-825f-08d8e4782c7d x-ms-traffictypediagnostic: VI1PR08MB3472:|PAXPR08MB6511: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:5797;OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6NTiwWNjQCRfkhKCY41/ZvMpKpbhiRYCNy4GKhCu+k5M0ubB/mMTVb+lgaE2REJn8Emc7jrl7nq3mWgAvXIb6SkRDQOfLCDfpi1Xn56ZfMzun4LugDS4qEifs2Fhcq5blwqOmaqUdwrLPWOTYXUBTHSqu0aNW7CIuoY9DHij7wF4GCml9bXyKhvOWtdobaJ1QhbzXrEMKdpZ6fBP994SoaAQVUXC82RY97a7Pi88mvpnOCmJUsc2SYZziKiaOZQYUihBpDpxDnOB7GobDT273fGf/R/0puPE0XaMgz0HDweZr6voWJH/ojvPYMPsfNHIIQxoi+7peDlr5elmZ8pNAxn1a1fOj+VNpijvbR/3lmsFI4QADxeYVdRlUhPP4yodUdbMZ6vAkXTRVotm7M3WGXelMBYk/u96pxY2f/3C/NBzC7p0thClMsru46BaKLnjqF1VRpQBwOGoQxYwuQDEFd06bhvjvX7FZF4rXtugnkBfgjq4hs4nNIAFRYv0XuoA6fPYfpLLCInvfRI2E1+N/szSB5uKF1xV816F/roXbaSPoHtw1/AJ3+I7Kuf1Ug4GijtTKDiVE47bwSEJN5oIOg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(91956017)(4326008)(5660300002)(316002)(6512007)(66556008)(66446008)(36756003)(83380400001)(33656002)(66946007)(186003)(26005)(76116006)(64756008)(86362001)(478600001)(71200400001)(6486002)(53546011)(2616005)(8936002)(54906003)(2906002)(8676002)(6916009)(66476007)(6506007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?QO9+mveASftCvCQSouooqpK491gi2V2E5pauPvOxndrO/TOpavXlcluRMgDv?= =?us-ascii?Q?MvPJVTRQydDNm8tOO1D6l43i/TDIe5jPR/z/uTbsL9qSJrLoKPvuYHSt2U3g?= =?us-ascii?Q?5Y52avEPfSqlEGxxrVGBwApsD7ePRygB7KRr3+X6dZCzSxrM19MQt2Zon1G3?= =?us-ascii?Q?D7+TrLmiP+PVy0zRRdtz3E+7DedOSy7g5Xo43mnsngf6Uf/04z2c/cEATeDE?= =?us-ascii?Q?8vTyd4n6kBIrP8GgR/sSN3D8JdTRg0Is0dZLphP0EVgSIcf73PaRh4sUwDpU?= =?us-ascii?Q?fWmSDoWY5SZFDZulmnYxaqnmgfrQUbtfNiscsYWDeLYG2rM6GTf4SzHssM82?= =?us-ascii?Q?TOF9dcF50W7fjJLpgzYmkJ1YjUFpoqne+Mwg0pgTCU2fMt+re2kUtX8Y10H9?= =?us-ascii?Q?XHb2rp4d+8l4Ql/Q1SwrtZWN8jYjejB7sBdsCdh8E8y1X4CjxTloQf2uMA2y?= =?us-ascii?Q?kudgtQoVa8EBgwO2i/xOxIjk0VQHxZ4xshXFUHQGYjwgSWxB0dv9pH3YK0Lq?= =?us-ascii?Q?mZYmbz5WqIRxm+Z7UbLmHDvRuT8mZPGgVnJy/zpk7K9tLo4Z5d9f2L+i2RrV?= =?us-ascii?Q?ZhgR5vskJLWs0zGD6xviybnLSTQO7sspiSLske2YhcNvbei8j70uR2VfPmFK?= =?us-ascii?Q?F1zZ56EYD6tUl3q9W4CRFrWPP6tWm3NHzQlUdmv7E032Hs3oXb0Dr92ytHc1?= =?us-ascii?Q?k5+FXWkDpMIHcWk1flussSG96bpvfNcO2DqzjbvKYKZQTdIUhbS5k2uo6KoE?= =?us-ascii?Q?SiUtHdrDcBXABsnGi+6X34u14D72plbvwHivUy+CTEkm3pV6B0icjVgWwBCz?= =?us-ascii?Q?70NRroiNpO78IuRgxWUoZI4LgOUQPdRzwVP+6fgRvVxVt9rj48Z5X+dNs0nm?= =?us-ascii?Q?38KaUVqfLshjlhCESS+EFUgdWLWnky9vs3dYHhKh4CWa+VdqutmQvKJiDEzC?= =?us-ascii?Q?g+4LSgbwyt1YexiGuhvaAz42weC1XMTWzxLrszL7dK1WqaTMi9YmD/CImMFY?= =?us-ascii?Q?MqvnPg0s1c8rwFq45ncRSCDKne2mA122rCmDjJWEH4pUREmyQJWCDPOxCxkg?= =?us-ascii?Q?1ox3Bfll3UfVZSb0cuobSIjAE7TdJ4xLTJWBFE/Pjpw27X1sHGxHELe5OdZy?= =?us-ascii?Q?zgeqRxGIIpllIAjJSHzhY+oIHMF8lxVWp4nQoLYhZEw5aFm5XNTYguoEGm26?= =?us-ascii?Q?cckqC2x0T8oKI0cXFL2MTdwdUC3Ay3nK/9p6Scshf5fazVLp1bS3PIahbPPU?= =?us-ascii?Q?zwrMCKmhkhCENY51Bwb7aGGM2wrrxCO+/NCb2RQ+3fnWA39w6FlfLEtA2jX4?= =?us-ascii?Q?Qip6RsrrF3JBZzoUGcUaZ0G9?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3472 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 0fe050d2-cd09-41df-b713-08d8e478267d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QFfJfK+jcY8G9T47W4hsU3G2AknJIkAqUWtE/7YC1CqwDm7ROVhylpY81tDnIP+nW2PW12GFExpc9XUw34snlB8x8dXvK8l9PlU5cQNHZE+vl3PDYlqTexRYHBGeRonkjdirMRxx15pZ4brgI+p6o7aMAvWDjBWZvwd4wfXzvG6ksc4ElbQla417UtRNmdBJcuNqy5DDAkk0Ni18xpkz1SvgYA/Rg8Uwc5JV/JkVfmWP8XEfDXexpnttb9uAyBCXuegN92pPiG7LHimzs0OT3pjBvAVCHXFkr9Qw9b7ubDmeDVvbFC/6OhpLjM2Ecz80dN0SmvE2E6od7Prz/W05ETOg316oZeAZShcBP7Ezhe6S4o81k0RTTgJLkHqiEXtQFzCxYxFqvZJS/wwYfKRBvjutdwpViA5eaiDWQL7lSd5kb5XgL2IfkhAvyVkuFgwoujEWLJvM3mRQrHRx6JAk8cScXDeIrvIsjGDW4jPNGjT6h/L7cI3z9DW9JV2h4U41NbxcTrLbwilerseMk150HWkfZqK3anlisWsQh43MvP6y/UioE4IjCKmj8vfCAKX1DV/YKms5fGQmtmeAazbKFFyJ1vo7SmJdL94KemoVkktmtdNvisyX1YDleW6Ct1H1+021nckgACvn8j1SMHspMvFaNVvD1onAwKjSAMMMGcQ= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(39860400002)(396003)(136003)(346002)(36840700001)(46966006)(8676002)(82740400003)(70206006)(336012)(26005)(8936002)(70586007)(81166007)(6512007)(2616005)(2906002)(6862004)(356005)(186003)(36756003)(6486002)(478600001)(54906003)(47076005)(82310400003)(86362001)(6506007)(53546011)(83380400001)(33656002)(316002)(5660300002)(36860700001)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 10:26:46.5227 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db3aea9a-a456-4fc9-825f-08d8e4782c7d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6511 Hi Julien, > On 11 Mar 2021, at 11:12, Julien Grall wrote: >=20 > Hi Bertrand, >=20 > On 09/03/2021 14:41, Bertrand Marquis wrote: >>> On 9 Mar 2021, at 12:04, Jan Beulich wrote: >>>=20 >>> On 08.03.2021 20:48, Julien Grall wrote: >>>> On 08/03/2021 17:18, Bertrand Marquis wrote: >>>>> --- a/xen/arch/arm/smpboot.c >>>>> +++ b/xen/arch/arm/smpboot.c >>>>> @@ -321,7 +321,8 @@ void start_secondary(void) >>>>> if ( !opt_hmp_unsafe && >>>>> current_cpu_data.midr.bits !=3D boot_cpu_data.midr.bits ) >>>>> { >>>>> - printk(XENLOG_ERR "CPU%u MIDR (0x%x) does not match boot CPU= MIDR (0x%x),\n" >>>>> + printk(XENLOG_ERR "CPU%u MIDR (0x%"PRIregister") does not ma= tch boot " >>>>> + "CPU MIDR (0x%"PRIregister"),\n" >>>>=20 >>>> For printk messages, we don't tend to split it like that (even for mor= e >>>> than 80 characters one). Instead, the preferred approach is: >>>>=20 >>>> printk(XENLOG_ERR >>>> "line 1\n" >>>> "line 2\n") >>>=20 >>> Except of course you want to repeat XENLOG_ERR for the 2nd line. >=20 > Interesting, I always thought a single XENLOG_* was enough for multi-line= in the same printk. >=20 >> Very right. >> @Julien: feel free to tell me if you want a v2. >=20 > I would prefer if you resend a v2. Sure i will do that. Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 11 10:34:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 10:34:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96438.182444 (Exim 4.92) (envelope-from ) id 1lKIeH-00048c-7T; Thu, 11 Mar 2021 10:34:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96438.182444; Thu, 11 Mar 2021 10:34:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKIeH-00048V-41; Thu, 11 Mar 2021 10:34:33 +0000 Received: by outflank-mailman (input) for mailman id 96438; Thu, 11 Mar 2021 10:34:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKIeG-00048Q-Ad for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 10:34:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKIeC-0002sF-Ms; Thu, 11 Mar 2021 10:34:28 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lKIeC-0002Qq-Dr; Thu, 11 Mar 2021 10:34:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=eMBHbKsSIl6Qxu9rRTx9jt5DHya1jvVbeEOmt9KbHyI=; b=YSFcbWENyWm8On0/m44hMw993/ GiylIAGyVQWxWxfKmRDR5xrSRZZCzY9jcs/fmLXMXPj6oXEcJCDdvRc2nbfoGiBUBIzP+Dz6l9V0R eExNwVvQb87AKZhU4geLC+Z2FZFwVrq+Y4uucEh+LlOTdp1EpqTiTSmrJT2sgzCnm/BY=; Subject: Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com References: <20210310065803.348-1-michal.orzel@arm.com> From: Julien Grall Message-ID: <3d3e5573-6d64-98cd-1f6f-897eb860d8ba@xen.org> Date: Thu, 11 Mar 2021 10:34:26 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210310065803.348-1-michal.orzel@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Michal, On 10/03/2021 06:58, Michal Orzel wrote: > Currently in order to link existing DTB into Xen image > we need to either specify option CONFIG_DTB_FILE on the > command line or manually add it into .config. > Add Kconfig entry: CONFIG_DTB_FILE to be able to > provide the path to DTB we want to embed into Xen image. > If no path provided - the dtb will not be embedded. > > Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" > as it is not needed since Kconfig will define it in a header > with all the other config options. > > Signed-off-by: Michal Orzel > --- > xen/arch/arm/Makefile | 5 ++--- > xen/common/Kconfig | 8 ++++++++ > 2 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index 16e6523e2c..46e6a95fec 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -68,9 +68,8 @@ extra-y += $(TARGET_SUBARCH)/head.o > > #obj-bin-y += ....o > > -ifdef CONFIG_DTB_FILE > +ifneq ($(CONFIG_DTB_FILE),"") > obj-y += dtb.o > -AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" > endif > > ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) > @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c > xen.lds: xen.lds.S > $(CPP) -P $(a_flags) -MQ $@ -o $@ $< > > -dtb.o: $(CONFIG_DTB_FILE) > +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) > > .PHONY: clean > clean:: > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index eb953d171e..a27836bf47 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -400,6 +400,14 @@ config DOM0_MEM > > Leave empty if you are not sure what to specify. > > +config DTB_FILE > + string "Absolute path to device tree blob" > + depends on HAS_DEVICE_TREE > + ---help--- > + When using a bootloader that has no device tree support or when there > + is no bootloader at all, use this option to specify the absolute path > + to a device tree that will be linked directly inside Xen binary. With this approach, CONFIG_DTB_FILE will always be defined. This means that Xen will always be compiled to use the "embedded" DTB. When the string is "", it will be garbagge. So I think we need a second config to that indicates whether the string is empty or not. Interestingly, your first version of patch didn't expose the problem because CONFIG_DTB_FILE would not be defined if the CONFIG_LINK_DTB is not selected. Although, it would still happily build if CONFIG_DTB_FILE is "". Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 11 10:37:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 10:37:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96443.182456 (Exim 4.92) (envelope-from ) id 1lKIh4-0004Iq-PA; Thu, 11 Mar 2021 10:37:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96443.182456; Thu, 11 Mar 2021 10:37:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKIh4-0004Ij-Lv; Thu, 11 Mar 2021 10:37:26 +0000 Received: by outflank-mailman (input) for mailman id 96443; Thu, 11 Mar 2021 10:37:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKIh3-0004Id-Fy for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 10:37:25 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 66f198ba-7803-4afb-935f-2684380ca3c7; Thu, 11 Mar 2021 10:37:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66f198ba-7803-4afb-935f-2684380ca3c7 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615459044; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=DsaCN3T5sodwJ/bJ4UDVTBLDfR8xYuJolsmH31scPc8=; b=M/mXJtFsNuzVfQN7QgYmgryCW+SFJzXJ+KimreaUgSfUHLGPgPrgVj9C zCoyu5o8bakEZZboqEPvofEAyIXBMYZoUbzBvbgsQNXgMOLYTomgJnDUn 2sbfaD4y1NzcdxA7g7tGY7cKRdGZFRgBZJn3K0k/9EKrAWG85Y4BfN4nK A=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: FkjFPoBZPYfz1AWYFkd8cRwNrNG3RSP5qXsMC6L0JWfBUDlOM45lU+wii7qo/QGSpXBlwyZhH4 ZCYkNENp4vIsIHG7Vxo7BhT5ed8r8LsjwG4vVHmhCSgNOELX6dkTE2+8UTxsHMLzzyvW2vFAQq DRwrEhfyXRhmiDTSuK6VdBSsYTkIF4oSDkUadePiMl9XqHSRDn0/32XSlzQAVJvWwFZqOjbLMQ aDGe5FdFXnre0ZZEkScEJrVkJzqxDEKGFKbZwlYP3g+/kUIgBafh1VUjfgEmQwXKhxgEQKq+BC r60= X-SBRS: 5.2 X-MesageID: 39053044 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:n4OxQKsbJlwbwP9RCujudQGL7skCiYYji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOj7U5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qz6Y 5JSII7MtH5CDFB4frSyBWkEtom3dmM+L2pg+Cb9Ht2UQR2cchbjztRICzzKDwReCBtA50lGJ 2AoudGvSOnY3QLbsK9b0N1ItTrjdvNiZ7gfFo6FwcqgTP+9w+AxZzbN1yj3hkYWy5S2rtKyw n4uiHw+6nLiYDf9jbyzGnWhq4m/OfJ6twGP8CUj9hQFzOEsHfVWK1Ee5mv+A84u/uu7lFCqq i9nz4FM95o433cOkGZyCGdozXI6zol53/8xVLwuxKKyqaVNVFKabsyuatjfhTU8EYmtt1nuZ g7pF6xjJZLEQjG2B30+tmgbWAaqmOPvXEgneQP5kYvKLc2Vbk5l/15wGplVL0EHC789bk9Fv hvAMz29J9tAC2nRkGckW91zNO2WHMvWj+AX0gZo8SQlwNbhXZj0iIjtYEit0ZF0Kh4Z4hP5u zCPKgtvLZSTvUOZaY4IOsaW8O4BkHEXBqkChPfHX3XUIU8f17doZ/+57s4oMuwfoYT8Zc0kJ PdFHtFqG8bYSvVeIyz9awO1iqIbHS2XDzrxM0bzYN+oKfASL3iNjDGYEwykvGnv+4UDqTgKr iOEaMTJ8WmAXrlGI5P0QG7cYJVM2MiXMocvct+dEmJpu7NN432ps3WePveP9PWYHUZc1K6Jk FGcCn4Jc1G4EzucGT/mgLtV3TkfVG63Z8YKtmZw8EjjKw2cqFcuAkcjlq0ouuRLydZj6AwdE xiZJfukqaxo3iK7X/Fhl8ZfyZ1PwJw2vHNQnlKrQgFPwffarAYoeiSfmhUwT+hKgJgSdjVVC pSvU5+967yD5H4/1FsN/uXdkahy1cDrnODSJkR3oeZ493+R58+BpE6HIprFQvKEBRxsR1wqH hKbTIFQkO3LEKvtYyVyLgvQM3Pfdh1hwmmZeROr2jEiEmarcYzAkcAUyWWSs6RiwY2Tz9yjl l8mpVvxIaoqHKKEy8Ske44OFpDZCCyDKhdBAqIXolSh4vmYRp9V2uMmDychSwiY2aCzTRguk XRaQmvPd3bCFtUvX5Vlpzn9155bU2xVUN9YHISi/w0KU32/lJIlcObbKu61GWcLmYYyuYGKT fffH85OQV13e260xaThRePHXgr3Y8VI+TYFbgvGoujnU+FGcmtr+UhEPBV9po+a4yrne8PTO 6FewiaaBn/EPgk3gSJpnAjfAl4wUNU5c/A6VnA1iyf2nV6PN/5ZHJBbJsfK8uH72flS+2Tua 8JxO4djK+VCCHJdtWCyavrdDZNJRPYnH6uQ4gT2OVplJN3kIE2IoLSXjTJ3kxWxRkSLM/7k0 UFXaRwiYqxTbNHTog3eyhD+EAum8nKBEw3shbuCutWRyBns1bre/eI6aHPs7whHwmooxbxI0 CW92l48+3eVyWOkZ4cBKRYGxUdVGEMrFBj9viFbYveFUGDcPxC5kOzNjuFS4BmIZL1b4k4n1 Jd+NGHn+ieair+1kTxhFJAU91z2lfiZ9izDgKKEfNP6PqgNz238+2X3PI= X-IronPort-AV: E=Sophos;i="5.81,240,1610427600"; d="scan'208";a="39053044" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AnXGHDNjPt6aa3l+NinNv2YV2JxWZult09avUM1xQRWbor/sUqMrgMS9eZBxQLvJnb+fkhF1dAz9XZm5ewOAusdvF1Vxm8rhheJFs8JrVPrsN4WI3pkJ1QYZZiu7W3j/nWaHAitpDcBOB6jsFUl9rBcXFy3HdaQoPvZK5MUFujLe/XwYFmjEmy4qrnSa4U1GF6bqYL8FEZSe8B/EPud75QxFsm5a/pNppT09363uYgFKQvzirVhM1R9QQetsrpzwRMLFYVf6va89pMyfExAjGgOAhAjzaGuSxo0uc9fIl2i+kpLGUn2pnvDJAY3iGnUowZC0jSBmjEkDZHV55N8Ezw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FLOWvj6/I7vNuUP4n4VkxtN6WBjipND4hx9RMT1j7g4=; b=FZItxeFRSWzcVMHov77pmvyEXtbTeBeHLDeXDgzaW6YpAs+u92ep2GMQfSjhJXRMwVUJ1Txe2Zv9lcvs0U/Hf4sH4Z9TZ9E/mKaRNIS+lq+UUouqUXLhtS7HMACz4kK48p0f+5PceOgq5Uu4xp55ZRpGvg4PG0O4nK3jJ7tNjzqDgEErFPAUO6Ed7EBDzaPAW0+7C/SuOgMRUqMPD+JtskiDAZ/aZkNSpVNXEloJODSa6rfTe5EueIZqxh83VficPShtQmHdvX4uyeUFsC22O+JUS8oUxyjE3wS9sE5UnOHhEPon377Dhzxq54jZ6/v2mkWtqb+sbxWGzPwY9hFgsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FLOWvj6/I7vNuUP4n4VkxtN6WBjipND4hx9RMT1j7g4=; b=euDVi7NVvLsq6nk3unPClThs3ofIDLInxobXojeZ707mKmqWwco4SPX6ayeAj6PJqEb17TjyeZD+ONhzCeGrJSHB9rlWDEEWa1aT2S+EkaX3mGeymHyr9rDFiZ/d8YV1z0sR+F5TqhUVdWNXuYFHKrRU2jBWPd/9FUd0vXB7TC0= Date: Thu, 11 Mar 2021 11:37:04 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: CC: Subject: Re: xen-blkfront: BUG_ON(info->nr_rings) Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0111.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::27) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e96b0bda-2cea-4142-334e-08d8e479a13a X-MS-TrafficTypeDiagnostic: DM6PR03MB3946: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mJcglVYt7UCMvKtUU3e25BZq2i5QYv++VghCkkM94wUseQgyQLYqxc7OKzi0w2HmUNJblz+LMMOY7AKDP+woj04VSrq8zNnLmxktDjsVk44L0gAIK/m6xqyi4nxjcu056+K4XlZ3gptzKClmGHxIykLg+r3iugJ+HWKpuA+p0YlbR0T33v8vFolFHzJfYaEA0BRMwSvVKptDyTRTDtIO/SCp/8CpAcI7jQ4KFiBJZ4nuun165o35ZNhN5mIPy1n91m6rdDhC/QOZC2aauRwvIqtjg9whqP+6uR8R+R7qzmB8XfYLZtPWttkpZ4X610CfDdgPAt35MA+PzaWyNA3/Dz7qt8tzoHzXVhwOz7QW2orWC+uI2ptxRbuUC3h3O/6RGpFfDEz35Vr7LTeWnVn58zuTAtCpqPdfChHMxjcgvu1fDSZ045ttxXx01SqSBkivCVZL4Nb2hxr404iznxvaNjes2vGiBbnmX4DdZa1Mw9+LWWV/a/DZlMBgcrfZKlzkxfZexiXRZVNZ1Jr6Dhux6w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(396003)(39860400002)(136003)(376002)(346002)(366004)(6916009)(2906002)(53546011)(83380400001)(4326008)(85182001)(6496006)(86362001)(316002)(5660300002)(478600001)(33716001)(16526019)(186003)(6486002)(956004)(9686003)(8676002)(66946007)(26005)(6666004)(8936002)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VFc1elJiRkwza1JsZk5BNGlxUDhkQW1CRkk1R011eEsxK1M4R21ZYmRPcUNr?= =?utf-8?B?UzJBalpsUWJBOHNna0hLSVhOWEtsUkNqSW50SUFvN0dpV1RoNHFUajB6T1Bm?= =?utf-8?B?RHVpZGdwenkvYWp4cmVKb1Jka3BnOC9xdlJHZ1RWdzh2VVlHdGVaZkV6ZW9a?= =?utf-8?B?OHlhZi9XRnMrREdjQnJoMnZXZnQvR1JPSG5rYng3eDQ3clg0QTBZQjQ5QWZX?= =?utf-8?B?YkM1NXFrQUhjSlIxbEJweUxQRnJ1RFp0UmxORitPa0F0YzErdllWMEttS0k3?= =?utf-8?B?bmRpQXhuL3pUL1FMMTc4K2UrMXhJcjlHbW15cjdLSkltdWpEQkdlUytYdkdJ?= =?utf-8?B?UHBQNytkMXlHazA4WGttSEd4VHZnSitGNXJqRXdtUTkzaVhlaUEvcGZzVjRq?= =?utf-8?B?MGdZT0FOOFI0dW5KUm5oUE9IY0VhbGNjSVBsRU1RSFFuSWRUMGwybzB3VXpE?= =?utf-8?B?UkFid05KY254WTJpOVdvZUUvRUtxRUx5eGdtakhLNEhnWXkzbmtEbmxZM2FO?= =?utf-8?B?eDZoOUh0aWpQWFdqdkp1ZTY1c3k2ai9HNzJkZGZzYmMwaXdYNnFQOU1tdUI1?= =?utf-8?B?amFZUTM3N25mOFBtcEhQWktDYlNxbUxCN2Fuc08xZksrZUhTWFFvajdxVWZy?= =?utf-8?B?SzBXZWtpbXlZMmp5WFNSOEN3QW1JM1JxcFM5ZXZINjc5cnMrVk14UmtjTDYx?= =?utf-8?B?ZmRVK0I5dlk2WWVnQzlkM1NlcDEwWmhwWVJGeHMzMTNhTTg2RFMrSFRSR2JU?= =?utf-8?B?YlBLOGJqQ0htVHY4L2lMTFV0Mi8zQmJ3T2NMT2RYRUgwVVVZWm9TNEVVNXpm?= =?utf-8?B?WE1ZcGR3Tm1HN1RUZGVub2t4NEE4MWlXaXBzR3hkWVU2WTdScUJJUkNtbXZN?= =?utf-8?B?TUJLVHBtTFpmSUd1L1lKY0lNZ2s5czNreEdwemhUREY2cTZndVlIdDZVT3lh?= =?utf-8?B?Sjhua2FjSzNVMlFKZnJaQjZLYkl1ZG1jTUtaRXFZQkFpYVU0ait3cWlIYWI4?= =?utf-8?B?bDdTbnA1M1BJZTl2b1ZoeFJHM2lZSE53NVFxY09veHd2bW9hZGZZTnAxWFFZ?= =?utf-8?B?OEg0VHpLMkxzSWwybTM5RzRLK2o2V016RVJ6eHJlVmljbHdFM1BVYWlnTC9M?= =?utf-8?B?UFJSQSt0NlJzdk1WZWdmQnBTRnQ0Zk5GN1U4ODBaM0FRZDZsZmFLTGxuS2JV?= =?utf-8?B?ZWFyZ3ZDWVlOWXo0ZS9BNUJLTnlEZ0dIanZQUUlPNVJtQy9ub2dZN2NDMjVV?= =?utf-8?B?R1BBZjdUOGNJaXh3c0pZbzNpMEQ2UjNwUGx5T01Nb3NiZWZWeEVxQVloOUZp?= =?utf-8?B?eEVmeUNZZmxhN2d0SGJoUjJtaXlDV2xaL1lEbFN4VlJabmpCRmJIdlhSTG1C?= =?utf-8?B?bUtxdGhLTUZ3aGJ4QWR6ZWdxdnBwUmpWZStkZUc1eGpZQlFrTWlCYzZjOG80?= =?utf-8?B?dFJHSUdCd0NkUkV2anVzOU0yVU9HMkdpMVZiY3czdnd4aERGTTlpa2xZL20x?= =?utf-8?B?S2FTSFh4Y2tlNjg3dG9IT2I1dld0TUlmaytXRlRONlhkV0J4WGhGQklPSERZ?= =?utf-8?B?WGlKUmpNeVR5V0lkSjZVMnk1aGowUW5LK1oxNTAzMkRCNFZkSGVpWUhkTzZM?= =?utf-8?B?MmtzU3h0V2Y1Y25VZUwzQXAvRm10V3MyREVRR0I1VXB2ZEcwSnZqYlFEcUNk?= =?utf-8?B?ajNUdkNUMDYyVVRMQSsxcmMzYUdnWW1lOUZ4emdoUk5UWG5paklPTmdFSi9l?= =?utf-8?Q?6RRqtDN2B5pscQqqsWKdKOSQvueA0x8XhLxc2ta?= X-MS-Exchange-CrossTenant-Network-Message-Id: e96b0bda-2cea-4142-334e-08d8e479a13a X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 10:37:12.2257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LNrSczb/HE+w9W/ZeMvMpUjoRVP5F6cC5Jl6WkQ6kAPkYAaz0UczcSfzB7ARVtvSIgU0VCPuDA+BKDIHtJL1Vw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3946 X-OriginatorOrg: citrix.com On Thu, Mar 11, 2021 at 09:01:51AM +0000, Paul Durrant wrote: > On 10/03/2021 14:58, Jason Andryuk wrote: > > Hi, > > > > I was running a loop of `xl block-attach ; xl block-detach` and I > > triggered a BUG in xen-blkfront, drivers/block/xen-blkfront.c:1917 > > This is BUG_ON(info->nr_rings) in negotiate_mq called by blkback_changed. > > > > I'm using Linux 5.4.103 and blktap3 on Xen 4.12 (OpenXT), though I > > don't think that matters. The backtrace and some preceding logs (from > > the reproducer) are below. > > > > I just repro-ed with this: > > path= > > xenstore-write $path 5 ; xenstore-write $path 4 > > > > info->nr_rings is still set because of the unexpected transition > > XenbusStateClosing -> XenbusStateConnected: > > dom7: [ 2866.574853] vbd vbd-51728: blkfront:blkback_changed to state 5. > > dom7: [ 2866.578385] vbd vbd-51728: blkfront:blkback_changed to state 4. > > > > I'm not totally sure how to handle this. The XenbusStateConnected > > event should be creating a new blkfront device, but instead it's seen > > by the old one which hasn't been cleaned up yet. IIRC xenbus state changes (like you perform above) never trigger the creation or destruction of devices on the bus. See xenbus_otherend_changed. xl block-detach however should indeed remove the device. We should add an option to `xl block-detach -w` to wait for the device to actually be removed before returning (or exit with a timeout). > > > > Sounds like blkfront needs to be fixed. Once it is in state 5 the only state > it should go to should be 6. From there it can cycle back to 4. Indeed, there's likely some logic to be improved in blkfront so it doesn't get messed up so badly on state changes by blkback. I'm happy to review patch for both blkfront and libxl/xl in order to make this better :). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 11 10:41:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 10:41:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96446.182467 (Exim 4.92) (envelope-from ) id 1lKIkj-0005E6-8j; Thu, 11 Mar 2021 10:41:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96446.182467; Thu, 11 Mar 2021 10:41:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKIkj-0005Dz-5p; Thu, 11 Mar 2021 10:41:13 +0000 Received: by outflank-mailman (input) for mailman id 96446; Thu, 11 Mar 2021 10:41:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKIkh-0005Du-NC for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 10:41:11 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id e00ee762-1152-4a4c-977c-b5a273e1dbd5; Thu, 11 Mar 2021 10:41:09 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7C3A11FB; Thu, 11 Mar 2021 02:41:09 -0800 (PST) Received: from [10.57.15.166] (unknown [10.57.15.166]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 33BEE3F70D; Thu, 11 Mar 2021 02:41:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e00ee762-1152-4a4c-977c-b5a273e1dbd5 Subject: Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com References: <20210310065803.348-1-michal.orzel@arm.com> <3d3e5573-6d64-98cd-1f6f-897eb860d8ba@xen.org> From: Michal Orzel Message-ID: <16f39b33-2e26-1a4b-5415-02cd14edaf24@arm.com> Date: Thu, 11 Mar 2021 11:41:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <3d3e5573-6d64-98cd-1f6f-897eb860d8ba@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Julien, On 11.03.2021 11:34, Julien Grall wrote: > Hi Michal, > > On 10/03/2021 06:58, Michal Orzel wrote: >> Currently in order to link existing DTB into Xen image >> we need to either specify option CONFIG_DTB_FILE on the >> command line or manually add it into .config. >> Add Kconfig entry: CONFIG_DTB_FILE to be able to >> provide the path to DTB we want to embed into Xen image. >> If no path provided - the dtb will not be embedded. >> >> Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >> as it is not needed since Kconfig will define it in a header >> with all the other config options. >> >> Signed-off-by: Michal Orzel >> --- >>   xen/arch/arm/Makefile | 5 ++--- >>   xen/common/Kconfig    | 8 ++++++++ >>   2 files changed, 10 insertions(+), 3 deletions(-) >> >> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile >> index 16e6523e2c..46e6a95fec 100644 >> --- a/xen/arch/arm/Makefile >> +++ b/xen/arch/arm/Makefile >> @@ -68,9 +68,8 @@ extra-y += $(TARGET_SUBARCH)/head.o >>     #obj-bin-y += ....o >>   -ifdef CONFIG_DTB_FILE >> +ifneq ($(CONFIG_DTB_FILE),"") >>   obj-y += dtb.o >> -AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>   endif >>     ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) >> @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >>   xen.lds: xen.lds.S >>       $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >>   -dtb.o: $(CONFIG_DTB_FILE) >> +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) >>     .PHONY: clean >>   clean:: >> diff --git a/xen/common/Kconfig b/xen/common/Kconfig >> index eb953d171e..a27836bf47 100644 >> --- a/xen/common/Kconfig >> +++ b/xen/common/Kconfig >> @@ -400,6 +400,14 @@ config DOM0_MEM >>           Leave empty if you are not sure what to specify. >>   +config DTB_FILE >> +    string "Absolute path to device tree blob" >> +    depends on HAS_DEVICE_TREE >> +    ---help--- >> +      When using a bootloader that has no device tree support or when there >> +      is no bootloader at all, use this option to specify the absolute path >> +      to a device tree that will be linked directly inside Xen binary. > > With this approach, CONFIG_DTB_FILE will always be defined. This means that Xen will always be compiled to use the "embedded" DTB. When the string is "", it will be garbagge. > > So I think we need a second config to that indicates whether the string is empty or not. > > Interestingly, your first version of patch didn't expose the problem because CONFIG_DTB_FILE would not be defined if the CONFIG_LINK_DTB is not selected. Although, it would still happily build if CONFIG_DTB_FILE is "". > > Cheers, > I do not agrree. We do not need another config. If string is empty - the dtb.o will not be created and there will be no dtb section in xen binary. The dtb.o will be compiled and embedded into Xen if and only if the path to dtb was given. Cheers, Michal From xen-devel-bounces@lists.xenproject.org Thu Mar 11 11:06:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 11:06:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96450.182480 (Exim 4.92) (envelope-from ) id 1lKJ8c-0007FD-C1; Thu, 11 Mar 2021 11:05:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96450.182480; Thu, 11 Mar 2021 11:05:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJ8c-0007F6-8T; Thu, 11 Mar 2021 11:05:54 +0000 Received: by outflank-mailman (input) for mailman id 96450; Thu, 11 Mar 2021 11:05:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJ8a-0007F1-UF for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 11:05:53 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3cea21c7-0e19-4159-ab28-366a5264e7a9; Thu, 11 Mar 2021 11:05:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3cea21c7-0e19-4159-ab28-366a5264e7a9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615460751; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=/FrW1AtOW2gGgoPqh/1PJBUkMHjK8/jpDqn12hGdSJ8=; b=S/vDQMZqPHldgDl+Em7xkfGU09u99L+RVLuxd14kOhTGQcIWhdu/4cQv wXxqLOF/tl21ydmkUOqtpkDNbsWWEQniTPzEAY4Jc8yGijkMs0Fgq7P7M DvblNLwiFQa92fKq7OqYqNAYs9n1fxl0GbbZnjRTQuDfkl5M17nst1d0z U=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: GWWB3x32zCNhnTXd4RkEao7SWYQsq8hQD/PZRmW6Wh0ULG7y3XfZHscMr1OzsFy0VAUXSIKOXT rr/VS7g26sQ1N6MKf8BvMA8wRhT3oIjGVUSFa8kmvYiXok9DP7WDa8dGVFGqoUqpQJ4sWIv00u cHwwVKmKM5nw8iCwrRglPGomvGps3mLUFCfdsm1jKexVlQUiDtmE79pY243FgTtRsJr+60qC+q qxqe7mH1Jj7IoCG/EBrXvRycam3YQBIIQdjwcwknbow1bLxJtDOz1tIeSucWpNoYX49ehAfx4N 6Nc= X-SBRS: 5.2 X-MesageID: 39405919 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:AeYNYaDwApusQe7lHegltMeALOonbusQ8zAX/mh6QxBNb4i8n8 ehgPwU2XbP+U4scVk9hNGNP7SBS3vA9ZhzpbIcJ6umQROOghrrEKhJx+LZowHIMSv46+JbyO NEe69xFNX/ATFB/IHHySO/FMstx8TCzbCwiY7lvjFQZCxJS4Ul1Qd2DQ6HDlZ7LTMsObMVHI eRj/A3wwaIVm8Qaq2AaEUtf++GnNHTkYKjXBhuPW9f1CCrrReFrIH3CAKZ2BB2aUIH/Z4H/X LemwL0ooWP2svLrSP07GPY45RIlNaJ8LIqbqDituEvJjrhkQquboh6Mofy2gwdmv2l61ohjb D30nQdFvlz8H/YcyWUphbgymDboVMTwkLi0lORjD/fp9X4TlsBeqh8rL9eGyG512MQ+PVXlJ 5N33qEu/NsYC/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEf1Fk9KuZKIAvKrKQcVM V+BsDV4/hbNXmAaWrCg2VpyNuwGlwuAxa9RFQYsMD96UkdoFlJi28jgOAPlHYJ85wwD7Ne4f 7fD6hunLZSCugbcLx6H+VEZcesEGTCTVbtPQupUBnaPZBCH0iIh4/84b0z6u3vUocP1oEOlJ PIV04dunU1f07oFM2SzJxG+h3AWwyGLHvQ4/Abw6I8lqz3RbLtPyHGYkspidGcr/IWBdCeW/ vbAuMZP9bTaU/VXapZ1Qz3XJdfbVMEVtcOh9o9U1WS5sbCKojgsP3HYO/eTYCdUAoMayfaOD 8uTTLzLMJP4gSAQXnjmiXcXHvrZwj45pJ/EK/T+uAJ04gTPohQsgwY4G7Jqv2jGHlniOgbbU F+KLTonueQvm+t51vF6G1vJ15AFEpP+a7hVHlLvAcONEvxfd84ypWiUFEX+EHCCg50TsvQHg Iamk9+/rivKYeMgQo4Dci8D26ch3wPhX6DQpsGgJef7cP9dp5QNOdkZIVBUSHwUz18g0JDtX pKYg5sfD6lKhrezYGeyKEyKM6aXd9mmwuvKdNTshvkxD+hjPBqYnseUzSnS9PSpx0vSTpSjk B26MYk8f69sAfqDWs6jO4xKkAJUn2eBPZ9BgKfaOxv6/XWUTA1a3yLizycgww0YUzw+Swp9y TcBDzRdvfRDlVHvHdElq7s7VNvb22YO1l9c3ZgrORGZBD7k2c21e+Afayo1WSNLlME3+EGKT nACAFiUD9G1pSy1BSPniyFGmhjzpIyPvbFBLBmd73IwHuiJMmJkq4BdsUkiapNJZTrsuURV/ iYdBLQJDTkC/kx0wjQv207IkBP2QgZuOKt3Aeg4Hmz3XY5D/aXKFN6R6sDK9XZ62T/Xf6H3J hwkNpdh5rGDkzhLtqdja3HZT9KLR3e5XS7SOwlsphYt6M/vrkbJeipbRLYkHVcmBkuJsb9k0 0TBLlh6LfaI4l1YogcfTla8ldBrqX4EGI79gjtRukwclEmgyWFY5eH47/UpaEuBUPErg3qIl Wb+zBc+fCAXybr789kN4sgZWBNLE474zB++enHcYvaAgCjbftC81q3KWXVSs4sdIGVXbEL6g 9n6NSJlfKNfyX22ArMrSJ2S5g+j1qPUIe3GkaQAuZG/NyxJESUjqar6MC1ii3rSTHTUTVnua RVMUoKbspCjTE+jIo4liiqI5aH334Yrw== X-IronPort-AV: E=Sophos;i="5.81,240,1610427600"; d="scan'208";a="39405919" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LhlnqbYiUQNTqqdfgOnJ18Jj4d3NOM6WrNWgzZm6L/ZXv3IkLa1U1nPIl4bVfJoy4Gkj6cyAQG3K/ZgwFSBBGOZbHouFI9cv/0d3D5Vn1Ae3E6y5gUPWNArBllLM7kywp9tPg2AzUPqf9uHN9lEbAzjEkiBY6m1wFG8Uji+NMhoAeC+d62qgpyo6tMkwuKsk7mwzZRGIWxlVaHsAeGur9VWYnkl8tQWeA0Morq5hgsBfKv4FPd29J0nCSRgCsQg+kXtkcZd8TWPB6ASlCCwCs97Boouy2vxoAEnytcyR4mTiGFXtyR8A2eBfOq/e1hm5MfZ0H3xkTrAlPK0zsVBN1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+bSva+Px1wrxAkeAMrJWOEKLGLJ4JwsVzHXWwa5o/1c=; b=DsY6LiWoSvySLV23q7SZhc6M3d13qKTGg7uU5PbJYDFGHx/MBbeWyOx9AukHWq+2PFQOUGmOHMEUMNePoKVEmRyD+fzDzE1p3zaTOywYNTcKHI8chd2QYNr6rw8+3uE9P0HzNLUeHQ7jm26hR4E9oWZcolji8Ys/Isw6N6z9fAVir1GHbhEet7i2IUF5ICHMWSY/8YLVX/Yy6r45L7vCHZPB0jTuIxKHCh6KIb4A3EDxK6kyrpEueYS9kPrGs7HpNp9PTORoS8qVsxaymZ1V1ab+v19Akk8WaoOsnquM0dEjRkbvcO52+FpRZ5DHYDbD4VVApY3Xw5fjst3OQDs7lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+bSva+Px1wrxAkeAMrJWOEKLGLJ4JwsVzHXWwa5o/1c=; b=cBAIT8QTeSkseUbZLNNXwRt6UeTlFNC4LRbqfWVL9hALdO4zPM+IxehHiz7ANk7WtV2ewa6yHx4yTNuq61AR7Y3iMZrgOQPv6UxIo/a2yL4Ar70+XqzbVjhXMrxE2j5jEg5a0dkq2+37zC3iUJDAKwx5z75jl9BNUoyU+y78XGk= To: Jan Beulich , Paul Durrant CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , Xen-devel , Juergen Gross References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> <556ce32b-5087-b8b1-432e-643218dd8c6e@suse.com> From: Andrew Cooper Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API Message-ID: <9ca069ab-8b6c-c8f1-d68b-4a9bb0cf5c56@citrix.com> Date: Thu, 11 Mar 2021 11:05:32 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <556ce32b-5087-b8b1-432e-643218dd8c6e@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0055.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::6) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 57d8352a-0a1e-4beb-d836-08d8e47d9af0 X-MS-TrafficTypeDiagnostic: BYAPR03MB4120: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ucLLKpybCJOXIFj/wN9SUNCiwMX+bT8TH7Mih14s9WzMUqyLxVJZFfYTABgGYc2we7f2K1RnFVQO3Ta2QM2MO3aMqwKLr9UaL128tjvDGGF/3sbS7bWgpiHWHzPLVRhzt9xW5E9A74QSESCg+MiulDh1JT0p7y6+lVA3yF6lixAqhO12RORY7/5HvWe7RLDf1jNMRjRBODQWJ1lARPhr8SJmKJK3+Jpf+3VHTE+UceZUB/hLnzfmXBr2xc678XGlhLMabgmzdUJIkOR6JFSb5CPG9ChMhLSjkAg/OZRfZwZA4GdRBDEMPNimgzLtz74Tli0oInv6s5RTpnY/MZGxBGMq9IOJFU3puHKLv1Pl6Vl8b/hxk7G8ziDwAmU+eMNM4hs99dDDR6ul65TKvMfl097sDLNGqJ8P+Xbe4MEnng4GZCSAyFV080ozhGFrwFgNCriGx0K1esjEHJr++s/rjtqcvo6ODijSAFh1vuxYo/T0qIZQHj0PjzNE8Xo9FSggWgcJ0zEOeOWVhDLSHzOh/4BYnwR3y3TA2v2/X9i1csJ/hNRVzct8C999WRgL1gxY2xYsr1od3M9j6lHz/Pg6GYKXpbgkAtAzjzK7CpaeHE3+6nFIyPKD2O8Bg3MCOGS/n9ouzg65l4uehUoPNKCVClIwCilV7viFjcHa165XPYWLoVsQutKfB8Bw7s+/nl9u X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39850400004)(376002)(136003)(396003)(346002)(366004)(2616005)(966005)(2906002)(54906003)(5660300002)(478600001)(36756003)(110136005)(66476007)(316002)(26005)(6666004)(31696002)(16576012)(8936002)(66556008)(956004)(4326008)(66946007)(31686004)(16526019)(8676002)(53546011)(83380400001)(6486002)(186003)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?QzNMSDVBSUozVytxb0xaZWxDTXUxVzExWXQyTTk5MHZFM3lJaGpiOUU2R3ph?= =?utf-8?B?UjFVSmN3N3FZVG9XdVBTa2djNy9KWGtnSFV6WkYxUndCeHhpbzBtZEdDWWFS?= =?utf-8?B?ekYvZDd3dTloYy84ZDh6Q2QrZjl1Sjh5V3VxaENSTEpoMTVqK2hpckFxczBM?= =?utf-8?B?TVR4bU5zbVQyd3hiU3R0TlRrRmhGaXgyei9MWWRSM2VNSmJ3TGltN2Eya2ZV?= =?utf-8?B?R3hWbkw1ODM5UTBhbk00c3k4WnhVQStlQnkvSFdacXhUaHRYdzE5WkFvd2t0?= =?utf-8?B?eW5jN0VLUWhadWE1eC9ESXN1cmh1WGEvOWdTUGhrZnBwcE43bzJuNjJnekNh?= =?utf-8?B?dnk5bG1JZXdaUWl5N2VUSUt2UGdsRjA0MTZHeVU4MUgwQ3RTQ2JpWVg1ZEhT?= =?utf-8?B?MVU2VG5FcjA3TzVoaUlMejBjN3RTbEN3MWxnMGNaQnhuQTlXYXZlMExZa3VR?= =?utf-8?B?UHdWak5EVllFemdIVlhLRFFxSm5PR3RoOU1nVmVCK21MM3R2V3VDWVlkMXM2?= =?utf-8?B?Y29iTjlpVGRsQjNnTkljcjM4SnlxWXZncWxNSm5pYlFFWTA0akFFemk2Sy90?= =?utf-8?B?ckdZMnNEczBvaENBd3ZMRGUvZTlUOG9ZRGpxS0kzR1JFeThHaUJyV1E4SjFx?= =?utf-8?B?WnlZSWtKSEU0OVlUMDAzQnZKOFBhTDJCakpRQTJVanViejYvRFVnMGVlV1dm?= =?utf-8?B?UHZTUnpLZldkYkRoaUhBdG51QzlCQUVrSzN0M1drcklrbXF3WHBuMDltY3cy?= =?utf-8?B?Wjk1MUNUeDdtdjNFMnJFYmkxd3N1dmNFaktrbWU5RGl2R2dFYk1YZFovdGJT?= =?utf-8?B?OTAxdnNpQXRVbEhIRHIyeExWQ1VNSXloT01xUXdmVjZNYzUwSHkzbG0zOHo0?= =?utf-8?B?ZzhmSmNmai9qcldHN2JvSUtySnQxL25ZblZGTXJETytVclh0WlV2azNQbHpz?= =?utf-8?B?ZFlMbWpjRzFZSDExdkk2TXNrRUhzRzlhbkxWbXA0T1ZaQ2VnZ2pFOTh5TU1y?= =?utf-8?B?NTcyWDBKRjN4Rkw0UXZkSUdXVU1PSkx3dHlRTkZma09DeVZVM0ZCOHl0YU1K?= =?utf-8?B?ZW1YbGFKR3ppUTdoK3laeWJET1lWSHBLbEs3QjJ5emRrTzVBeGtmamwyWm5W?= =?utf-8?B?K2o1SEJaMG1LSks1dUFFSllCV205NUx1dEdmWXg2OGQ5elJJaDZTbmZGV1N1?= =?utf-8?B?bjZjWTVsdGVqOVFhdzR2YjZ3RmhTZ3dBbHduaTU3bzlEM291ZHVGQ05mS3Jh?= =?utf-8?B?d05UcUJNYjk3NndQVjdnVjlWWXBxRmRKaklVSHBIWUFDdGJzTVN6MVlIOVZv?= =?utf-8?B?ODM4bzhjMUFxSTJMZzROMk5iU2pIY3BtbDlHaGhTdDI0ZmxROEpUenIwZmRI?= =?utf-8?B?d3NsemxSS3lkYnBSVC8wa28xZ1B5dmppWjZIbFhZSzVXNitXOXh1Q1VKaEV5?= =?utf-8?B?aFFwTW5vUXVZL0d3MW5ML2VoSXRPb243aWhPaG84UGdLbTFGZ1NydjNka1FQ?= =?utf-8?B?Rk1GczVENFdCMkVnKy8xcVVkQnFwZ3ExaksvQnhiQ3VyYzJ3Mm9RSW9oaU9B?= =?utf-8?B?MmFHTDhuTktoRjliTThNeUpRV2VRQyswY25LM3FSckt3RmJmNDBicjhZL1Vq?= =?utf-8?B?TWdnbFlhTTNsdzkrb1hIY01rTUNtTDJsN1EreE5MZ0ZaMlVWUzBEWmt4S0t6?= =?utf-8?B?NDFTWk1QV2RYTmVWQ3A0eDhhWXZDclhzRmo1R1J2NHhCN1NzU1lWMWk2ejdH?= =?utf-8?Q?TVHsKpqWf4j9YzB1MMZjw7ilcUXoRaakaDww4R4?= X-MS-Exchange-CrossTenant-Network-Message-Id: 57d8352a-0a1e-4beb-d836-08d8e47d9af0 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 11:05:40.0371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IfmrioYodgcraMmDgwBic3N2Y40X+MXN3QMVEe7ueOaQaHVnpAgod841llhodljBRdJVvJIkTIC/nl4SCO8YYZlgBujYqhA3FWd61sVdxgw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4120 X-OriginatorOrg: citrix.com On 11/03/2021 08:27, Jan Beulich wrote: > On 10.03.2021 18:22, Andrew Cooper wrote: >> On 10/03/2021 17:12, Jan Beulich wrote: >>> On 10.03.2021 16:07, Andrew Cooper wrote: >>>> --- a/docs/designs/dmop.pandoc >>>> +++ b/docs/designs/dmop.pandoc >>>> @@ -4,9 +4,13 @@ DMOP >>>> Introduction >>>> ------------ >>>> =20 >>>> -The aim of DMOP is to prevent a compromised device model from comprom= ising >>>> -domains other than the one it is providing emulation for (which is th= erefore >>>> -likely already compromised). >>>> +The DMOP hypercall has a new ABI design to solve problems in the Xen >>>> +ecosystem. First, the ABI is fully stable, to reduce the coupling be= tween >>>> +device models and the version of Xen. >>>> + >>>> +Secondly, for device models in userspace, the ABI is designed specifi= cally to >>>> +allow a kernel to audit the memory ranges used, without having to kno= w the >>>> +internal structure of sub-ops. >>> I appreciate the editing, but the cited points still don't justify ... >>> >>>> --- a/xen/include/public/hvm/dm_op.h >>>> +++ b/xen/include/public/hvm/dm_op.h >>>> @@ -25,9 +25,6 @@ >>>> #define __XEN_PUBLIC_HVM_DM_OP_H__ >>>> =20 >>>> #include "../xen.h" >>>> - >>>> -#if defined(__XEN__) || defined(__XEN_TOOLS__) >>>> - >>>> #include "../event_channel.h" >>>> =20 >>>> #ifndef uint64_aligned_t >>>> @@ -491,8 +488,6 @@ struct xen_dm_op { >>>> } u; >>>> }; >>>> =20 >>>> -#endif /* __XEN__ || __XEN_TOOLS__ */ >>>> - >>>> struct xen_dm_op_buf { >>>> XEN_GUEST_HANDLE(void) h; >>>> xen_ulong_t size; >>> ... this removal: What the kernel needs for its auditing (your 2nd >>> point) is already outside of this guarded region, as you can see >>> from the context above. You said there was a design goal of allowing >>> use of this interface by (and not only through) the kernel, e.g. by >>> a kernel module (which I don't think you mean to be covered by >>> "device models"). If that was indeed a goal (Paul - can you confirm >>> this?), this would now want listing as a 3rd item. Without such a >>> statement I'd call it a bug to not have the guards there, and hence >>> might either feel tempted myself to add them back at some point, or >>> would ack a patch doing so. >> Xen has absolutely no business dictating stuff like this. > Actually there's no "dictating" here anyway: People are free to clone > the headers and omit the guards anyway. That is somewhere between busywork and just plain rude to 3rd parties.=C2= =A0 "here are some headers but you need to unbreak them locally before use". > Outside of our own build > system they really mainly serve a documentation purpose. Header guards are not documentation - they are active attempt to segregate hypercalls by "who we think is supposed to use them". MiniOS, which uses this header within our build system, is not a part of the toolstack, and should not need to define __XEN_TOOLS__ to be able to use stable-ABI hypercalls. Equally, the fact that libxendevicemodel's private.h needed to define __XEN_TOOLS__ demonstrates the problem - dm_op.h (the structs and defines - not just the types) are necessary to use the ioctl() on /dev/xen/devicemodel in the first place. >> =C2=A0 It is an >> internal and opaque property of the domain if the hypercalls happen to >> originate from logic in user mode or kernel mode.=C2=A0 Stubdomains woul= d >> fall into the same "kernel" category as xengt in the dom0 i915 driver. >> >> However, the actual bug I'm trying to fix with this is the need for >> userspace, which doesn't link against libxc, to do >> >> #define __XEN_TOOLS__ >> #include >> >> to be able to use the libxendevicemodel stable library. >> >> The __XEN_TOOLS__ guard is buggy even ignoring the kernel device model >> aspect. > Depends on what __XEN_TOOLS__ really means - to guard things accessible > to any part of the tool stack, or to guard unstable interfaces only. As far as I'm concerned, __XEN_TOOLS__ should always have been spelled __XEN_UNSTABLE_ABI__. For better or worse, the fact that we currently do have unstable interfaces, which aren't in an obvious namespace such as xen/public/unstable/, means that there is some value in some form of protection to prevent users from inadvertently using an interface which will explode on them with a mismatched hypervisor. >From numerous complains and problems from donwstreams, we are deliberately taking steps to stabilise the interfaces, specifically to decouple the software in domains from the version of the hypervisor. dmop was the first serious crack at this, and all these patches from me are literally trying to get https://github.com/xapi-project/varstored (which is a trivial IO port device model for UEFI secure variables) onto fully stable hypercalls, so it doesn't need rebuilding simply because Xen changed. Relatedly, xenstored.=C2=A0 At the moment, xenstored (which requires one bi= t of information per domain via its final unstable hypercall) breaks whenever the domctl and sysctl interface versions change, despite the fact that the ABI hasn't actually changed in years and years AFAICT. xenstored is arguably classified as "toolstack", while varstored (or its stubdomain equivalent) is not.=C2=A0 Neither should be forced to jump throu= gh hoops to see stable API/ABIs, even after they've included the appropriate headers. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Mar 11 11:11:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 11:11:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96456.182492 (Exim 4.92) (envelope-from ) id 1lKJDg-0008Ek-4w; Thu, 11 Mar 2021 11:11:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96456.182492; Thu, 11 Mar 2021 11:11:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJDg-0008Ed-1M; Thu, 11 Mar 2021 11:11:08 +0000 Received: by outflank-mailman (input) for mailman id 96456; Thu, 11 Mar 2021 11:11:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJDf-0008EY-6K for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 11:11:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJDb-0003Ve-AQ; Thu, 11 Mar 2021 11:11:03 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lKJDa-0005Ks-U0; Thu, 11 Mar 2021 11:11:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=PDZ2BIw7q+qBLZK1zBozS1BpcLY0D+YLKVjixvzXI8k=; b=z81pII8bkSccsML3U319gD5UBs ak1Wenvc3c7om1APDoqnMb9A450ZiA9HkDXdhkr1ngsEXRqqDOSPXKWUhKZN5IaZxxziDF8N7r+71 i1l8sApXgzahopmfLwhQBQ9VkK0uS1soqsg2xdPWsHRc7zFnGVi1CB3KefFtGz8i7Be4=; Subject: Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com References: <20210310065803.348-1-michal.orzel@arm.com> <3d3e5573-6d64-98cd-1f6f-897eb860d8ba@xen.org> <16f39b33-2e26-1a4b-5415-02cd14edaf24@arm.com> From: Julien Grall Message-ID: Date: Thu, 11 Mar 2021 11:11:00 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <16f39b33-2e26-1a4b-5415-02cd14edaf24@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 11/03/2021 10:41, Michal Orzel wrote: > Hi Julien, Hi, > > On 11.03.2021 11:34, Julien Grall wrote: >> Hi Michal, >> >> On 10/03/2021 06:58, Michal Orzel wrote: >>> Currently in order to link existing DTB into Xen image >>> we need to either specify option CONFIG_DTB_FILE on the >>> command line or manually add it into .config. >>> Add Kconfig entry: CONFIG_DTB_FILE to be able to >>> provide the path to DTB we want to embed into Xen image. >>> If no path provided - the dtb will not be embedded. >>> >>> Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>> as it is not needed since Kconfig will define it in a header >>> with all the other config options. >>> >>> Signed-off-by: Michal Orzel >>> --- >>>   xen/arch/arm/Makefile | 5 ++--- >>>   xen/common/Kconfig    | 8 ++++++++ >>>   2 files changed, 10 insertions(+), 3 deletions(-) >>> >>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile >>> index 16e6523e2c..46e6a95fec 100644 >>> --- a/xen/arch/arm/Makefile >>> +++ b/xen/arch/arm/Makefile >>> @@ -68,9 +68,8 @@ extra-y += $(TARGET_SUBARCH)/head.o >>>     #obj-bin-y += ....o >>>   -ifdef CONFIG_DTB_FILE >>> +ifneq ($(CONFIG_DTB_FILE),"") >>>   obj-y += dtb.o >>> -AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>   endif >>>     ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) >>> @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >>>   xen.lds: xen.lds.S >>>       $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >>>   -dtb.o: $(CONFIG_DTB_FILE) >>> +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) >>>     .PHONY: clean >>>   clean:: >>> diff --git a/xen/common/Kconfig b/xen/common/Kconfig >>> index eb953d171e..a27836bf47 100644 >>> --- a/xen/common/Kconfig >>> +++ b/xen/common/Kconfig >>> @@ -400,6 +400,14 @@ config DOM0_MEM >>>           Leave empty if you are not sure what to specify. >>>   +config DTB_FILE >>> +    string "Absolute path to device tree blob" >>> +    depends on HAS_DEVICE_TREE >>> +    ---help--- >>> +      When using a bootloader that has no device tree support or when there >>> +      is no bootloader at all, use this option to specify the absolute path >>> +      to a device tree that will be linked directly inside Xen binary. >> >> With this approach, CONFIG_DTB_FILE will always be defined. This means that Xen will always be compiled to use the "embedded" DTB. When the string is "", it will be garbagge. >> >> So I think we need a second config to that indicates whether the string is empty or not. >> >> Interestingly, your first version of patch didn't expose the problem because CONFIG_DTB_FILE would not be defined if the CONFIG_LINK_DTB is not selected. Although, it would still happily build if CONFIG_DTB_FILE is "". >> >> Cheers, >> > I do not agrree. We do not need another config. Did you test that Xen will still boot if the string is empty? > If string is empty - the dtb.o will not be created and there will be no dtb section in xen binary. The dtb.o will not be created but the section will because the linker use #ifdef CONFIG_DTB_FILE: 42sh> grep CONFIG_DTB .config CONFIG_DTB_FILE="" 42sh> nm xen-syms | grep _sdtb 00000000003560f8 B _sdtb And to show this is going to be used: 42sh> git diff diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 5d44667bd89d..2b680b8226d2 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -297,6 +297,7 @@ real_start_efi: /* Using the DTB in the .dtb section? */ #ifdef CONFIG_DTB_FILE + e load_paddr x21, _sdtb #endif 42hs> make [...] CC arm64/head.o arm64/head.S: Assembler messages: arm64/head.S:300: Error: unknown mnemonic `e' -- `e' /home/ANT.AMAZON.COM/jgrall/works/oss/xen/xen/Rules.mk:204: recipe for target 'arm64/head.o' failed So _sdtb is going to always be used... Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 11 11:28:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 11:28:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96460.182504 (Exim 4.92) (envelope-from ) id 1lKJUA-00012C-Jd; Thu, 11 Mar 2021 11:28:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96460.182504; Thu, 11 Mar 2021 11:28:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJUA-000125-GW; Thu, 11 Mar 2021 11:28:10 +0000 Received: by outflank-mailman (input) for mailman id 96460; Thu, 11 Mar 2021 11:28:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJU9-000120-1u for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 11:28:09 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 86bbf54e-494f-446a-94aa-e5a1210f8aa0; Thu, 11 Mar 2021 11:28:07 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6D74FAB8C; Thu, 11 Mar 2021 11:28:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86bbf54e-494f-446a-94aa-e5a1210f8aa0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615462086; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M09rmtVJUUKZqaKgvyIxP14gZzQ5LrxUn164x9+lHGQ=; b=DOSbHszFUw8LkLIgdvY0QKKRHzEaJ1OooZxZJvPh3PPdWqyzGBjczz70pdyOcirGjdimFv 45gf0FyRocDa7VjYTQdO8RTFamMplOqnerIMDOENm7U2TCCzjO1N8QGTz/SMNllz6tfiDD 0sWbL9NlLR/5mIuEPY6dbOazi/DfrbE= Subject: Re: [PATCH] xen: fix for_each_cpu when NR_CPUS=1 To: Dario Faggioli Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <161545564302.24868.14477928469038686899.stgit@Wayrath> From: Jan Beulich Message-ID: <9cc6f3ff-f078-1657-7c5a-9f356a857cdb@suse.com> Date: Thu, 11 Mar 2021 12:28:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <161545564302.24868.14477928469038686899.stgit@Wayrath> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11.03.2021 10:40, Dario Faggioli wrote: > When running an hypervisor build with NR_CPUS=1 for_each_cpu does not > take into account whether the bit of the CPU is set or not in the > provided mask. > > This means that whatever we have in the bodies of these loops is always > done once, even if the mask was empty and it should never be done. This > is clearly a bug and was in fact causing an assert to trigger in credit2 > code. > > Removing the special casing of NR_CPUS == 1 makes things work again. > > Signed-off-by: Dario Faggioli Doesn't this want a Reported-by: Roger? Reviewed-by: Jan Beulich And FTR I don't really mind the other NR_CPUS == 1 piece of logic to remain there. > I'm not really sure whether this should be 4.15 material. > > It's definitely a bug, IMO. The risk is also pretty low, considering > that no one should really run Xen in this configuration (NR_CPUS=1, I > mean). Which is also the reason why it's probably not really important > that we fix it at this point of the release cycle. I agree; I'll put it in the 4.16 bucket. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 11:41:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 11:41:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96464.182519 (Exim 4.92) (envelope-from ) id 1lKJgf-0002le-Qw; Thu, 11 Mar 2021 11:41:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96464.182519; Thu, 11 Mar 2021 11:41:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJgf-0002lX-Ns; Thu, 11 Mar 2021 11:41:05 +0000 Received: by outflank-mailman (input) for mailman id 96464; Thu, 11 Mar 2021 11:41:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJgd-0002lR-Ra for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 11:41:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f4fedf5f-4a88-4785-baba-ba6eff214e59; Thu, 11 Mar 2021 11:41:02 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B1EDDAC16; Thu, 11 Mar 2021 11:41:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4fedf5f-4a88-4785-baba-ba6eff214e59 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615462861; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zPjS+8090b9vguY41fZmaGmXKDLlQpLQg8OBbk1MblI=; b=Q3RvNwxo71+zRCZjoN+kdO5Q+Tc0V4IMaTEKpZvtEj8M8doqOf4AwxLWY7bO57nNbXBIf+ hN3m8kTZ2ywsalIqznymrlBqQA6d/ZdkKuSbP5o4MtW1gCDTDpU/1Uh3vo4D6NrWqtuJdG yz7rbO1oMbUps+3rnYympHiNwGVYXf8= Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , Xen-devel , Juergen Gross , Paul Durrant References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> <556ce32b-5087-b8b1-432e-643218dd8c6e@suse.com> <9ca069ab-8b6c-c8f1-d68b-4a9bb0cf5c56@citrix.com> From: Jan Beulich Message-ID: Date: Thu, 11 Mar 2021 12:41:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <9ca069ab-8b6c-c8f1-d68b-4a9bb0cf5c56@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11.03.2021 12:05, Andrew Cooper wrote: > On 11/03/2021 08:27, Jan Beulich wrote: >> On 10.03.2021 18:22, Andrew Cooper wrote: >>> On 10/03/2021 17:12, Jan Beulich wrote: >>>> On 10.03.2021 16:07, Andrew Cooper wrote: >>>>> --- a/docs/designs/dmop.pandoc >>>>> +++ b/docs/designs/dmop.pandoc >>>>> @@ -4,9 +4,13 @@ DMOP >>>>> Introduction >>>>> ------------ >>>>> >>>>> -The aim of DMOP is to prevent a compromised device model from compromising >>>>> -domains other than the one it is providing emulation for (which is therefore >>>>> -likely already compromised). >>>>> +The DMOP hypercall has a new ABI design to solve problems in the Xen >>>>> +ecosystem. First, the ABI is fully stable, to reduce the coupling between >>>>> +device models and the version of Xen. >>>>> + >>>>> +Secondly, for device models in userspace, the ABI is designed specifically to >>>>> +allow a kernel to audit the memory ranges used, without having to know the >>>>> +internal structure of sub-ops. >>>> I appreciate the editing, but the cited points still don't justify ... >>>> >>>>> --- a/xen/include/public/hvm/dm_op.h >>>>> +++ b/xen/include/public/hvm/dm_op.h >>>>> @@ -25,9 +25,6 @@ >>>>> #define __XEN_PUBLIC_HVM_DM_OP_H__ >>>>> >>>>> #include "../xen.h" >>>>> - >>>>> -#if defined(__XEN__) || defined(__XEN_TOOLS__) >>>>> - >>>>> #include "../event_channel.h" >>>>> >>>>> #ifndef uint64_aligned_t >>>>> @@ -491,8 +488,6 @@ struct xen_dm_op { >>>>> } u; >>>>> }; >>>>> >>>>> -#endif /* __XEN__ || __XEN_TOOLS__ */ >>>>> - >>>>> struct xen_dm_op_buf { >>>>> XEN_GUEST_HANDLE(void) h; >>>>> xen_ulong_t size; >>>> ... this removal: What the kernel needs for its auditing (your 2nd >>>> point) is already outside of this guarded region, as you can see >>>> from the context above. You said there was a design goal of allowing >>>> use of this interface by (and not only through) the kernel, e.g. by >>>> a kernel module (which I don't think you mean to be covered by >>>> "device models"). If that was indeed a goal (Paul - can you confirm >>>> this?), this would now want listing as a 3rd item. Without such a >>>> statement I'd call it a bug to not have the guards there, and hence >>>> might either feel tempted myself to add them back at some point, or >>>> would ack a patch doing so. >>> Xen has absolutely no business dictating stuff like this. >> Actually there's no "dictating" here anyway: People are free to clone >> the headers and omit the guards anyway. > > That is somewhere between busywork and just plain rude to 3rd parties.  > "here are some headers but you need to unbreak them locally before use". > >> Outside of our own build >> system they really mainly serve a documentation purpose. > > Header guards are not documentation And I didn't say so - I said they server a documentation purpose. > - they are active attempt to > segregate hypercalls by "who we think is supposed to use them". > > MiniOS, which uses this header within our build system, is not a part of > the toolstack, and should not need to define __XEN_TOOLS__ to be able to > use stable-ABI hypercalls. I've not been able to spot a definition of __XEN_TOOLS__ in the mini-os sources. Are you perhaps referring to tool stack libraries getting built also for it? > Equally, the fact that libxendevicemodel's private.h needed to define > __XEN_TOOLS__ demonstrates the problem - dm_op.h (the structs and > defines - not just the types) are necessary to use the ioctl() on > /dev/xen/devicemodel in the first place. But this library _is_ part of the tool stack. Looks like it really boils down to ... >>>   It is an >>> internal and opaque property of the domain if the hypercalls happen to >>> originate from logic in user mode or kernel mode.  Stubdomains would >>> fall into the same "kernel" category as xengt in the dom0 i915 driver. >>> >>> However, the actual bug I'm trying to fix with this is the need for >>> userspace, which doesn't link against libxc, to do >>> >>> #define __XEN_TOOLS__ >>> #include >>> >>> to be able to use the libxendevicemodel stable library. >>> >>> The __XEN_TOOLS__ guard is buggy even ignoring the kernel device model >>> aspect. >> Depends on what __XEN_TOOLS__ really means - to guard things accessible >> to any part of the tool stack, or to guard unstable interfaces only. > > As far as I'm concerned, __XEN_TOOLS__ should always have been spelled > __XEN_UNSTABLE_ABI__. ... this. If you added half a sentence to this effect to the description, you may feel free to add Acked-by: Jan Beulich I still would appreciate if you also added the kernel (module) aspect to the doc change. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 11:43:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 11:43:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96468.182534 (Exim 4.92) (envelope-from ) id 1lKJjE-0002vK-9j; Thu, 11 Mar 2021 11:43:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96468.182534; Thu, 11 Mar 2021 11:43:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJjE-0002vD-6g; Thu, 11 Mar 2021 11:43:44 +0000 Received: by outflank-mailman (input) for mailman id 96468; Thu, 11 Mar 2021 11:43:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJjC-0002v8-Qe for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 11:43:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 410110a1-e5e2-48cd-be02-e6a3338d58df; Thu, 11 Mar 2021 11:43:42 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3176EAC17; Thu, 11 Mar 2021 11:43:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 410110a1-e5e2-48cd-be02-e6a3338d58df X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615463021; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uiNWiXnPAoe+/jhRiPkWAurq6xpVbqXwniHx4z+FwSc=; b=QmryxUU+HNwebzKmtsT4vhyZZY9Trd647NnGgGzo7kDCjPibvWs2pcnvhdt3jfTOCrDmML QKz6DJW2ytA9Yeov0wnM9V+8CnHmrmclTJZcWaGphzGn3eBymM3AzhR0WQD6OvV+RtAxRr qisrCZoMqGu7FpjWDinRwOJlEl77HJg= Subject: Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64) To: Julien Grall Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210306214148.27021-1-julien@xen.org> <1897022d-7591-3450-4e57-884a2860b13d@suse.com> <7fd07dc9-9c03-bb13-3907-c3c268a4e970@xen.org> <2de5160f-8636-5cdf-a20c-acaa2640c893@suse.com> <7ab87cab-8836-e8a0-993e-0cdeca3c45e3@xen.org> <2bc2ad13-8636-e5d4-3a4a-722c75e3b92a@suse.com> <6048b3f0-b131-9ced-9521-a935e5b337eb@xen.org> From: Jan Beulich Message-ID: <13983f51-f6d9-db70-dbce-51481d4aaa2b@suse.com> Date: Thu, 11 Mar 2021 12:43:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <6048b3f0-b131-9ced-9521-a935e5b337eb@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11.03.2021 10:31, Julien Grall wrote: > On 11/03/2021 08:17, Jan Beulich wrote: >> On 10.03.2021 19:05, Julien Grall wrote: >>> On 09/03/2021 11:20, Jan Beulich wrote: >>>> On 08.03.2021 21:22, Julien Grall wrote: >>>>> On 08/03/2021 11:20, Jan Beulich wrote: >>>>>> On 08.03.2021 11:51, Julien Grall wrote: >>>>>>> On 08/03/2021 08:09, Jan Beulich wrote: >>>>>>>> Additionally - partly related to your own reply regarding the CI >>>>>>>> failures - imo there needs to be an analysis of what older distros >>>>>>>> will no longer build (at all or by default). >>>>>>> >>>>>>> Per the CI, this would be Ubuntu Trusty (and older), Centos 7 (and older) >>>>>>> >>>>>>> Do you have any other in mind? >>>>>> >>>>>> Our SLE12 (latest service pack is SP5 and still has a while to go >>>>>> to at least reach LTSS state) comes with gcc 4.8 as the default >>>>>> compiler. >>>>> >>>>> Thanks! That's good to know. Is it the old GCC Suse supports? >>>> >>>> Not sure I understand the question: The default compiler of this or >>>> any distro is of course (expected to be) supported by the vendor >>>> for the lifetime of the OS. >>> >>> Sorry for the wording. I was asking whether Suse also supports compiler >>> older than GCC 4.8. >> >> Oh, I see. SLES11 has another year to go for LTSS to end, and it's 4.3 >> which is used there. > > Thanks for the info! Are you planning to build Xen 4.15 there too? If "you" is the company - there are no plans to provide 4.15 there. But I do build Xen myself on such systems. That's how I'm noticing compatibility issues like the one in grant table code where you don't like the workaround. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 11:46:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 11:46:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96471.182546 (Exim 4.92) (envelope-from ) id 1lKJlu-00033L-Ou; Thu, 11 Mar 2021 11:46:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96471.182546; Thu, 11 Mar 2021 11:46:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJlu-00033E-L2; Thu, 11 Mar 2021 11:46:30 +0000 Received: by outflank-mailman (input) for mailman id 96471; Thu, 11 Mar 2021 11:46:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJlt-000339-UT for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 11:46:29 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b922d222-255d-4dc6-ab98-d0e67b2b5a08; Thu, 11 Mar 2021 11:46:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b922d222-255d-4dc6-ab98-d0e67b2b5a08 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615463188; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=PjnmfYXXkk7j/iV3a0WKeTe0kC+PpwLGVyV5lc1V/Vc=; b=dFQvJltR3PjJhmjCZhvhtTUeF6YmW6xdmXSlu95oqK5S+WCITtZ/pB0p ummDWb5iTiFQWvVcvB9sksbR803zLtDpS5mPz9lNxhh6B4huqxm3t44Mf +NPbxuyCk0u85mWhRokj9G+p0nlltGAplG+xYQCe0ayDPfqEBYuWagBVK s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: HSlwVoszlM5vTRK/0XZvenREwqiomo/W6gj7Y8e+h2gEuO4F2c7cOwHJ4RAcRGxrnevjrL/oc5 QnsxLgpiCl2P/bPeq68rGGJfV3+4uOraYElwJ5T0Dpg1+wR29ILen2vTmVEUdSCUIfsiwDYqe3 xT+T4z7Waw65wfhPw+e8DXwOa8ReDovRDEc5nCH7e1HuFefOr7qviXHnCxzZqGVty6OUu2/nco UN87hBsEYJRD8a8GzzZ892AvkBLJSdLRYzsu3D5jG2klolJnshkrxMdqQNvAfRTb1R14AtqbPl 0Sg= X-SBRS: 5.2 X-MesageID: 39408703 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:xunhjKvVU2TvG/YVSi6kOvtl7skCpIMji2hD6mlwRA09T+Wxi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmwybde6+AqXYuKdg/gpWeuMcVe/ZLvqgeQfxHW28x88e Nbc6Z4AMDtFlQSt6zHySSxDtpI+ra62Y+yg+O29RlQZCVLT40l0AtjEAacFSRNNWx7LL40Do CV6MYChxfIQwV1Uu2BCnMIX/fOqrTw/fqLXTc8CwM68w7LtDu06dfBeCSw5AsUUD9E3N4ZgA r4ujH+j5/Dj9iLjiXy+kWWxJRQldvnxLJ4dbGxo/lQEBrAoEKFYIxgXpeLoTw6pvq+gWxa7O XkklMbEOlYr1/XY2GpsTvhsjOQrwoG2jvZ5nKzxVvlvMDjSzoxB6N69PxkWyqc0WUMlpVY8s twrgWknqsSNzzstmDBwuKNcBdQmk+9sRMZ4JUupk0aa6QyQvtst4AFlXkldqsoLWbBx60MNv JhN83Y7OY+SyLhU1np+lNix9GhRR0Ib267a3lHvsSU1g5fl2xiw30Zw9QCnmwB+IhVceg929 j5 X-IronPort-AV: E=Sophos;i="5.81,240,1610427600"; d="scan'208";a="39408703" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EPHHxULU200S1HUK0ECV4A7c9NfCOIBLcKH1xRL7FE8i9N2kETWxtNeytylCOn89Odr7peyFybFSBqMXDOOTMKvHnyXy28qfjYLO7DQZ1OF3A4cbzuz1gj59hxXvkIdu/OeuqwNt+mXVSyMDLPhOSWbgYTE6Qfe9fQSAA8g3SRtKzdhgp2Kxa9V6vrVAGqw4aPIrcwxIJQFs4e8ZEGfsUG7jqD5oQVmikwc3SzCAmCT6c5JhIf+Fi2aecerEeM0USqD1e16JWKmxflhQ7N+/cba2oAeaTTzh0jLl26xD6Jclt3/HgcrD7pFCSVsvjmrIFlFEZ6/B3yUa0dJsS47H8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AGWjZ3EVvrR6mDn+7xMbHXeHY+vOZlhj5RzxnRGgHSE=; b=IHmxOVi3ADlRpfYobR1KvzZcM9BuNjkyJs8E65KXJWPgvu63Gpg+KaUQ13FN7lueaE9ixZCmWPUr+rKb02DWCnhaKAe6XkFhel+7ay/SHYsy/eyenxdBHm91K4yoBV/vwfSsuvk2/Cpm39b3nN7kmbla+744UdTRUH6pUzBeulPld7vkgJtO1lGvGobb91A0VNJWnRAByvkSb9x+0PDD5b2NuiLd9lwRPBRASne9DDiTr+j2knOxPM9MYrRX/9QzD+DOqd7OHPleQCqH3FzT+FInkX025mArlj2Fip8SX6QWSLgv+9m2ZrgicEQ279RoWBe5r10fhswLBSDhmnjNSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AGWjZ3EVvrR6mDn+7xMbHXeHY+vOZlhj5RzxnRGgHSE=; b=Zkyk0BUOGbJfDpHL3e4HMblvX84yz5gDKdllTraq5QJD9ZfO6+Yvmi8LJZXaXAGgSx2dPNu3AyCEBaKdaPA9HAV/A4fV40kEeQFsCfoqH6d4WkZf/aOg6BNc+B0VPg9O9FQBwRdhFXV4KiVlqXwcL987KPeNHihkh1a5VTsRNXM= From: Roger Pau Monne To: CC: Roger Pau Monne , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH RFC] build: detect outdated configure outputs Date: Thu, 11 Mar 2021 12:46:01 +0100 Message-ID: <20210311114601.42460-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6PR10CA0069.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::46) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 001013dc-bb3e-4993-2189-08d8e483437b X-MS-TrafficTypeDiagnostic: DM6PR03MB4137: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T6PRsjZI86zarQftPlXEU/XjbXVx/ZebH4QKC6QfxGUVoDd6P8GBOB7nvtcT7UGqk2M5GyO0kd2h0y74Hqx6Q7WdNMoGRfligMCFRZIN1jv1OrtbnHp1F9sP6YYuDjSeHOTxYXfShPsVr3H+C+SfAJeKYiqFpgyydcFfy5qLAE9of59IGXiuRU8pADQJJgAyiFVunSm5bs3F5aGaTb/A4GfX0AEKghNcQqoia2q1SJaUArxJ9aTQCog/FTYJrIhdLUivo+a25/TIPK/aWh9agGhmxfoTWA7EGBWXWnL5BpxJshe8GwxTz9v500pd1LqXmiHUA4aNDe0u32gitzfSeE6U6ID0lMuZHQlfDMmYEFDkmXATI+AYpRFCDPKDInDD4duYHRHx7RogJ2q5rpcTJGF5W0HoXLCdc9heFvBaTgMMA1QCSdQyPrWMP9gBkXgk4pdQaEhjE21b+KOZJa0zRy0bDhjSTkSqXpl/KuncQR5/GOc4v/5XgPKLqze9yi9j3rsdTZBnQHxJUYoWeLcEcg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(39860400002)(376002)(136003)(346002)(6666004)(2616005)(956004)(6486002)(478600001)(8936002)(316002)(16526019)(26005)(1076003)(54906003)(83380400001)(6496006)(36756003)(8676002)(66946007)(6916009)(2906002)(66556008)(4326008)(66476007)(186003)(86362001)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?S25nUFNiay95L2ZjbzlKbytlZnJBK3M3SmNBZVVtZUlwUHVRVkRwbDZ6L0Zm?= =?utf-8?B?N0F0ZlVxYXFLbkd1RHNsTVYyd2ZQWDJRYWtZN2lUVzB4SGl3ekNNdEhjT0Y4?= =?utf-8?B?N0pDbVRNRktlTWV0bHIyMUE5bjZFcTRJckpOcG16RS9FVTVCT0hPN0ZMQVFZ?= =?utf-8?B?NDVWUSt4TU9CM3o1QkJ6RmdCZXkzMldTZmliczM3amE0Vmk5N0RnOUtyVFhI?= =?utf-8?B?V2lYRXpLSDlad3RISy9oMG1ZN3VFRmdrTFdBYUxaMG1qQllndGNsV0d0QTdr?= =?utf-8?B?QVJjT1JVUkMrclk2SzgwNlRZSEg3MEZMb1dlbCtGRFU0V1V6djJES0NGMGw1?= =?utf-8?B?NjlkTS9pbWtyT05keUczTHBuaUp3cW1tWnBlakxEb1kza1dnT2o4c09GVmVU?= =?utf-8?B?a1pJQ3IvaTdJUmEzRFBacTBlTm5sNVk2V1g2T2RqUEtteFplSjB2bEExb3d3?= =?utf-8?B?aUIwSUxGQVV0QlROc1lDdGk5MzByTUg2cVp5VkxYc0c5ZVdieUxmcjVOU3U3?= =?utf-8?B?cjZlV3FEcXRTVmJrejBYcWgwZUM4T3FYUjlMa01lK2dtWG41aTdpM3NLcTc4?= =?utf-8?B?T2phWTZleTNXNGlXL285QzBnT2dYUkJLb2xGeEtjMFNUM09mTDVUTDg0dHhV?= =?utf-8?B?MXQwMGtwdmlSOEZYU29vakhwZ0R0c2xvK3ZpNUpva05BQ1BWa21PeHJuVnZM?= =?utf-8?B?SVVYZ09wcEZNbjdBRHhiYTB0Q2tWREM3aG1lUVBvN1BybndxbWQ3RldqMk1k?= =?utf-8?B?WE94OC9PSGZHdUpyTndjcmcvc2ZhUnlQeXE1MGVMUWFaM0YzTU9QZDNNNU93?= =?utf-8?B?cEc0dnpxc2p0RVBXWm9lZ1Iza3RQMkgrMVgrcS9zN2g3K1F1U0paUDhZekRP?= =?utf-8?B?VmFhSERpSmNGbW81Q2Z4dURVWmsxb2pCT1dYNi9hL0pPUkVDV1Jub0FKa0tG?= =?utf-8?B?Y2F6TzZlTXNtZEZpcGpEMWcvMjRHTmlVYnF3U0p0b1BjSEtvclRSTE5jTkZQ?= =?utf-8?B?NW8rOWZGYTdTUXpkcTZlYloyZkNHWkozOFMycXRjQnhSQUw1cjYvTG9weTNO?= =?utf-8?B?ZEVYOEZudGhmSFhUTmJrYjUzRWxCQWtpRjU2cG41YlcycXg3TmcxNVBUOFpM?= =?utf-8?B?d2VsbXVwSkp1cWdEOGJLQitvVDBVMjY3eEJ0ejFlQlJ0YzVhNjFxNndyUWNs?= =?utf-8?B?b2NRQUN6bDI1dDdzMWNOS2oyL3YyM2V4SzY3Q21WcmNDbVBqWFVRYzExVjEr?= =?utf-8?B?RVJsUHRzOTFvbzRBaDl3VGlkYTVtSEdlRjlSWlhtY2w5cDRCdVhLZzlmZmFH?= =?utf-8?B?RWpiNEhPTjBod21jQ2hkU1BIVXl3cnJpZERnYTI5UFA0R2RmcDdOakljZjBh?= =?utf-8?B?RG5qWXNIUU5GZE03NnZOdmFYdFZLZ1BMb3lIaUtSVXdMc2gzYjgycTZaTHVZ?= =?utf-8?B?RzR6Q254VmVIcjJheWQ4SDJ4eVprc2FabXJ4SU5LbExNYUFWdk9KUUE1eXl0?= =?utf-8?B?U3BWU0FrcmdNQjUxUktIOGpHR3J3bGRWbithNWs3WGFrQjRCZllYbHA4WHFy?= =?utf-8?B?QTA1dEV5U2c0aXByOW9hUzRucHhCRDRiT1pnSWcvaFQ4eGdxSDl5VHl0djh5?= =?utf-8?B?VGZrQWl1Q2RHZ1NsR0FpS3hqQUxENUMvUlQ0SndEK0NxclF4eVRWVzR6bXFZ?= =?utf-8?B?M3psSWM3VTV6UkU4WTlXeVBqL2VTT2VXM3JQRG4vMllHT2NybGtLMWtNWUln?= =?utf-8?Q?SJdac4oPAPqVn3t74lZ4R75Xi7b9d87IHxdfEdd?= X-MS-Exchange-CrossTenant-Network-Message-Id: 001013dc-bb3e-4993-2189-08d8e483437b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 11:46:09.9226 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nRItsg6X6U466plfY8DhcTWKWOxGCp5JSURwZu7pWonGtWLYmFhJpK7h9LT3IAugy/ARYDj4Qd51rUTqOradBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4137 X-OriginatorOrg: citrix.com The Xen build system relies on configure to parse some .in files in order to do substitutions based on the data gathered from configure. The main issue with those substitutions done at the configure level is that make is not able to detect when they go out of date because the .in file has been modified, and hence it's possible to end up in a situation where .in files have been modified but the build is using outdated ones. This is made even worse because the 'clean' targets don't remove the output of the .in parsing, so doing a typical `make clean && make` will still use the old files without complaining. Note that 'clean' not removing the output of the .in transformations is the right behavior, otherwise Xen would require re-executing the configure script after each clean. Attempt to improve the situation by adding a global rule that spot the outdated files as long as they are properly listed as makefile target prerequisites. Ultimately those substitutions should be part of the build phase, not the configure one. Signed-off-by: Roger Pau Monné --- RFC because I'm not sure if there's some better way to handle this. Also I think we would want to make sure all the .in outputs are properly listed as target prerequisites, or else this won't work. Also not sure whether this will break some other usage of .in files I'm not aware. --- Config.mk | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Config.mk b/Config.mk index a56a971028..a81d384899 100644 --- a/Config.mk +++ b/Config.mk @@ -65,6 +65,10 @@ DEPS_RM = $(DEPS) $(DEPS_INCLUDE) %.d2: %.d sed "s!\(^\| \)$$PWD/! !" $^ >$@.tmp && mv -f $@.tmp $@ +# Make sure the configure generated files are up to date +%: %.in + $(error $@ is outdated, please re-run configure) + include $(XEN_ROOT)/config/$(XEN_OS).mk include $(XEN_ROOT)/config/$(XEN_TARGET_ARCH).mk -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 11:55:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 11:55:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96476.182558 (Exim 4.92) (envelope-from ) id 1lKJuU-000457-LB; Thu, 11 Mar 2021 11:55:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96476.182558; Thu, 11 Mar 2021 11:55:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJuU-000450-HB; Thu, 11 Mar 2021 11:55:22 +0000 Received: by outflank-mailman (input) for mailman id 96476; Thu, 11 Mar 2021 11:55:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJuS-00044q-Rd; Thu, 11 Mar 2021 11:55:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJuS-0004Dk-Kg; Thu, 11 Mar 2021 11:55:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKJuS-0002Ms-Bz; Thu, 11 Mar 2021 11:55:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKJuS-0002R0-BW; Thu, 11 Mar 2021 11:55:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zWV2ygFYRv0DJ9x2Lu2HGm94xThPTpa2Azzr0+oIUd8=; b=MKNhpujbZdsPRQxs5D5sXYDYWA d0IZFFOC1yH/DEvJ3lQBeyxB84GxxH6xplM6Rztz7GJx96/ly7FnxsQiPaQ8XVtV2mtHkoO9xzAR8 0/YRoI2DIu/F6K1aZDjvaML0DOat2W7P9bmbcJQkfzzMNX9jz9Pn02s5GG3CmM6SXXfw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159934: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=935e0836710ce8cab584155b2844cea8497a5159 X-Osstest-Versions-That: xen=e4bdcc8aef6707027168ea29caed844a7da67b4d From: osstest service owner Date: Thu, 11 Mar 2021 11:55:20 +0000 flight 159934 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159934/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 935e0836710ce8cab584155b2844cea8497a5159 baseline version: xen e4bdcc8aef6707027168ea29caed844a7da67b4d Last test of basis 159917 2021-03-10 17:01:30 Z 0 days Testing same since 159934 2021-03-11 10:01:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Elliott Mitchell Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e4bdcc8aef..935e083671 935e0836710ce8cab584155b2844cea8497a5159 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Mar 11 12:39:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 12:39:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96499.182573 (Exim 4.92) (envelope-from ) id 1lKKbC-0008By-HA; Thu, 11 Mar 2021 12:39:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96499.182573; Thu, 11 Mar 2021 12:39:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKKbC-0008Br-Dl; Thu, 11 Mar 2021 12:39:30 +0000 Received: by outflank-mailman (input) for mailman id 96499; Thu, 11 Mar 2021 12:39:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKKbB-0008Bm-Oa for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 12:39:29 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 1d28edce-da7c-4b78-8fed-786a32f6eabf; Thu, 11 Mar 2021 12:39:28 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B2FA6ED1; Thu, 11 Mar 2021 04:39:27 -0800 (PST) Received: from [10.57.15.166] (unknown [10.57.15.166]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0FD6E3F793; Thu, 11 Mar 2021 04:39:25 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d28edce-da7c-4b78-8fed-786a32f6eabf Subject: Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com References: <20210310065803.348-1-michal.orzel@arm.com> <3d3e5573-6d64-98cd-1f6f-897eb860d8ba@xen.org> <16f39b33-2e26-1a4b-5415-02cd14edaf24@arm.com> From: Michal Orzel Message-ID: <54c7a952-cc17-8ab5-1aec-d1bd2453d1a1@arm.com> Date: Thu, 11 Mar 2021 13:39:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11.03.2021 12:11, Julien Grall wrote: > > > On 11/03/2021 10:41, Michal Orzel wrote: >> Hi Julien, > > Hi, > >> >> On 11.03.2021 11:34, Julien Grall wrote: >>> Hi Michal, >>> >>> On 10/03/2021 06:58, Michal Orzel wrote: >>>> Currently in order to link existing DTB into Xen image >>>> we need to either specify option CONFIG_DTB_FILE on the >>>> command line or manually add it into .config. >>>> Add Kconfig entry: CONFIG_DTB_FILE to be able to >>>> provide the path to DTB we want to embed into Xen image. >>>> If no path provided - the dtb will not be embedded. >>>> >>>> Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>> as it is not needed since Kconfig will define it in a header >>>> with all the other config options. >>>> >>>> Signed-off-by: Michal Orzel >>>> --- >>>>    xen/arch/arm/Makefile | 5 ++--- >>>>    xen/common/Kconfig    | 8 ++++++++ >>>>    2 files changed, 10 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile >>>> index 16e6523e2c..46e6a95fec 100644 >>>> --- a/xen/arch/arm/Makefile >>>> +++ b/xen/arch/arm/Makefile >>>> @@ -68,9 +68,8 @@ extra-y += $(TARGET_SUBARCH)/head.o >>>>      #obj-bin-y += ....o >>>>    -ifdef CONFIG_DTB_FILE >>>> +ifneq ($(CONFIG_DTB_FILE),"") >>>>    obj-y += dtb.o >>>> -AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>>    endif >>>>      ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) >>>> @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >>>>    xen.lds: xen.lds.S >>>>        $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >>>>    -dtb.o: $(CONFIG_DTB_FILE) >>>> +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) >>>>      .PHONY: clean >>>>    clean:: >>>> diff --git a/xen/common/Kconfig b/xen/common/Kconfig >>>> index eb953d171e..a27836bf47 100644 >>>> --- a/xen/common/Kconfig >>>> +++ b/xen/common/Kconfig >>>> @@ -400,6 +400,14 @@ config DOM0_MEM >>>>            Leave empty if you are not sure what to specify. >>>>    +config DTB_FILE >>>> +    string "Absolute path to device tree blob" >>>> +    depends on HAS_DEVICE_TREE >>>> +    ---help--- >>>> +      When using a bootloader that has no device tree support or when there >>>> +      is no bootloader at all, use this option to specify the absolute path >>>> +      to a device tree that will be linked directly inside Xen binary. >>> >>> With this approach, CONFIG_DTB_FILE will always be defined. This means that Xen will always be compiled to use the "embedded" DTB. When the string is "", it will be garbagge. >>> >>> So I think we need a second config to that indicates whether the string is empty or not. >>> >>> Interestingly, your first version of patch didn't expose the problem because CONFIG_DTB_FILE would not be defined if the CONFIG_LINK_DTB is not selected. Although, it would still happily build if CONFIG_DTB_FILE is "". >>> >>> Cheers, >>> >> I do not agrree. We do not need another config. > > Did you test that Xen will still boot if the string is empty? > >> If string is empty - the dtb.o will not be created and there will be no dtb section in xen binary. > > The dtb.o will not be created but the section will because the linker use #ifdef CONFIG_DTB_FILE: > > 42sh> grep CONFIG_DTB .config > CONFIG_DTB_FILE="" > 42sh> nm xen-syms | grep _sdtb > 00000000003560f8 B _sdtb > > And to show this is going to be used: > > 42sh> git diff > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 5d44667bd89d..2b680b8226d2 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -297,6 +297,7 @@ real_start_efi: > >          /* Using the DTB in the .dtb section? */ >  #ifdef CONFIG_DTB_FILE > +        e >          load_paddr x21, _sdtb >  #endif > > 42hs> make > [...] >   CC      arm64/head.o > arm64/head.S: Assembler messages: > arm64/head.S:300: Error: unknown mnemonic `e' -- `e' > /home/ANT.AMAZON.COM/jgrall/works/oss/xen/xen/Rules.mk:204: recipe for target 'arm64/head.o' failed > > So _sdtb is going to always be used... > > Cheers, > Yes you are right. So I could add another config like: config DTB_VALID def_bool y if DTB_FILE != "" and change all the lines containing: #ifdef CONFIG_DTB_FILE to #ifdef CONFIG_DTB_VALID What do u think? Michal From xen-devel-bounces@lists.xenproject.org Thu Mar 11 12:50:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 12:50:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96502.182585 (Exim 4.92) (envelope-from ) id 1lKKlw-0001UO-K9; Thu, 11 Mar 2021 12:50:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96502.182585; Thu, 11 Mar 2021 12:50:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKKlw-0001UH-FN; Thu, 11 Mar 2021 12:50:36 +0000 Received: by outflank-mailman (input) for mailman id 96502; Thu, 11 Mar 2021 12:50:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKKlu-0001UC-0V for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 12:50:35 +0000 Received: from mail.skyhub.de (unknown [5.9.137.197]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c3c2bec7-f378-4a0e-a51a-db0aa51b48c9; Thu, 11 Mar 2021 12:50:31 +0000 (UTC) Received: from zn.tnic (p200300ec2f0e1f0084acfb80b2ea2480.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:1f00:84ac:fb80:b2ea:2480]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 570341EC04C0; Thu, 11 Mar 2021 13:50:30 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3c2bec7-f378-4a0e-a51a-db0aa51b48c9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1615467030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=YQoMnM+JalduchtvnnRdDi537/sQjYe69dpZBUUIePI=; b=oOGUaSre4XzUs+lxkz7FD2kSZBN8NksBkfckW/+qTHl8JbaxYlJ6NN8Mbc1R2n11m55CFf P73fj+xpCfOCQDtCPXJIYK1D6MwZPiXIwvgaAfFGUGzDJZaZCXkLGAHUC5DtKeJD/Osqtp IAS+CcgMs7OmmLqg6Q3uUtquB4Svgws= Date: Thu, 11 Mar 2021 13:50:26 +0100 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, clang-built-linux@googlegroups.com, Peter Zijlstra , Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel , Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini , Andy Lutomirski , Nathan Chancellor , Nick Desaulniers Subject: Re: [PATCH v6 00/12] x86: major paravirt cleanup Message-ID: <20210311125026.GB5829@zn.tnic> References: <20210309134813.23912-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210309134813.23912-1-jgross@suse.com> On Tue, Mar 09, 2021 at 02:48:01PM +0100, Juergen Gross wrote: > This is a major cleanup of the paravirt infrastructure aiming at > eliminating all custom code patching via paravirt patching. > > This is achieved by using ALTERNATIVE instead, leading to the ability > to give objtool access to the patched in instructions. > > In order to remove most of the 32-bit special handling from pvops the > time related operations are switched to use static_call() instead. > > At the end of this series all paravirt patching has to do is to > replace indirect calls with direct ones. In a further step this could > be switched to static_call(), too. > > Changes in V6: > - switched back to "not" bit in feature value for "not feature" > - other minor comments addressed Ok, looks real good, the simplification is amazing! :) Can you please redo with the minor nits addressed ontop of the tip:x86/alternatives branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/log/?h=x86/alternatives and move the cleanups patches 13 and 14 to the beginning of the set? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Thu Mar 11 12:51:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 12:51:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96505.182597 (Exim 4.92) (envelope-from ) id 1lKKn3-0001br-T7; Thu, 11 Mar 2021 12:51:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96505.182597; Thu, 11 Mar 2021 12:51:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKKn3-0001bk-Q9; Thu, 11 Mar 2021 12:51:45 +0000 Received: by outflank-mailman (input) for mailman id 96505; Thu, 11 Mar 2021 12:51:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKKn2-0001be-N9 for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 12:51:44 +0000 Received: from mail.skyhub.de (unknown [5.9.137.197]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 25202adc-3f65-476c-b913-7477a525a103; Thu, 11 Mar 2021 12:51:42 +0000 (UTC) Received: from zn.tnic (p200300ec2f0e1f0084acfb80b2ea2480.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:1f00:84ac:fb80:b2ea:2480]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id F0EBC1EC04CB; Thu, 11 Mar 2021 13:51:41 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25202adc-3f65-476c-b913-7477a525a103 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1615467102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=04Q81L86Yi8VhtfgMy5DPhkMLlrDvgeVfznIwom2C0o=; b=F7I4zNkFealftdt3MSO2iENkOoJ7233iIBl0MIA2fExAwgTg9QWD88MEO8x3MFz8dHZN3+ qEbWBRHl1mcXsYMgEMA1pRva0r+EgUrrobNzE1xqTPoZc3Vv+WQhSag3viC4Y2uSFgaf4T ID5ejVj1usJOEZ1VFcDtbCWF5MkzXrk= Date: Thu, 11 Mar 2021 13:51:43 +0100 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, clang-built-linux@googlegroups.com, Peter Zijlstra , Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel , Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini , Andy Lutomirski , Nathan Chancellor , Nick Desaulniers Subject: Re: [PATCH v6 00/12] x86: major paravirt cleanup Message-ID: <20210311125143.GC5829@zn.tnic> References: <20210309134813.23912-1-jgross@suse.com> <20210311125026.GB5829@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210311125026.GB5829@zn.tnic> On Thu, Mar 11, 2021 at 01:50:26PM +0100, Borislav Petkov wrote: > and move the cleanups patches 13 and 14 to the beginning of the set? Yeah, 14 needs ALTERNATIVE_TERNARY so I guess after patch 5, that is. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Thu Mar 11 13:01:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 13:01:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96508.182609 (Exim 4.92) (envelope-from ) id 1lKKwH-0002eJ-U5; Thu, 11 Mar 2021 13:01:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96508.182609; Thu, 11 Mar 2021 13:01:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKKwH-0002eC-Op; Thu, 11 Mar 2021 13:01:17 +0000 Received: by outflank-mailman (input) for mailman id 96508; Thu, 11 Mar 2021 13:01:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKKwG-0002e7-Ml for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 13:01:16 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7b663bba-3f60-459a-bf86-514ab6e3a430; Thu, 11 Mar 2021 13:01:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b663bba-3f60-459a-bf86-514ab6e3a430 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615467675; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=eGfdVCJ49I3T2FJxGhf5mXTVeWsNmVm4j6ue50ZEwns=; b=PWC0a5XiZ7YECf0jxzgtNWFzowS5iV/5K8sEkZ/Vw+I70HzMnu05PElV mnxT5CZ4kfjIamdGqkHgfCcR6RhHq6ClP8Tx/kDNbp5b2O3o/dc6YZtAb f2dV5gUAKc2NYpE6CW6kf3mOhFxVD5phl5C18jXv6Y8SwC7UVTzGM7aO2 8=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 7VxGC+ThhMM3fS8KItu/SAvVvTlGG89yZr9RuGu64P0Jr5/RVz8N/gVkc0dthw0OavfDupJjBR UVdaR7MAWz9JEJ3wiJrexpOnLXiK+7mZES47kgdXDDZ/xvhHEripn6PA5dm5ic3mYfOAY0way7 AaJEBPq8M7iXzDtWeP7Ug6E9nPraO+epOGXLc0SbA3p+pzLSroSVkH4Mq8Oi9SVaeEczoEQYZW aaL9o7wPNhCAOzlQDaSys4FFJrI2C/O1Nym597lL7Or7MjDA2cfxSF5YKbE1T4qIROtH8A/VoN ztc= X-SBRS: 5.2 X-MesageID: 40463976 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:vP+viaGuDgp/lOEtpLqFR5TXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7L0/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeOJwTXzcQY76 tpdsFFZOHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLT1CQYsI1XYcNi+wFEpqSA5aQb8wE5 SB7sRKzgDQB0g/RMK9G3UDQqz/vNXNjp3relorABQg5QmIg1qTmcHHOjKf2QoTVC4K/Kc6/Q H+4nDEz4iAk9X+8B/T0GfP849b8eGB9vJvDNGB4/JlUQnEpR2vYO1aKtu/lRAz5Nqi8VM71O TLyi1QQvhbz1P0UiWLrQD22w/muQxemUPK7VODm3PsrYjYaVsBerJ8rLlUeBfY9EYs1esUuM kgshP7xvgneS/opyjz68PFUBtnjCOP0B0fuNUekmBFVs8mYKJRxLZvj399KosKHy7x9ekcYZ BTJfzbjcwmFG+yU2rUpS1GztCqQx0Ib227a3lHkMmU3z9KpWt+3ksVyecO901whK4Vet1q4f /JPb9vk6wLZsgKbbhlDONEesevDHfRKCi8fl66EBDCLuUqKnjNo5n47PEc4/yrQoUByN8XlI 7aWF1VmGYucyvVeIyz9awO1iqIbHS2XDzrxM0bzYN+oKfASL3iNjDGYEwykuO7ys9vQPHzar KWAtZ7EvXjJWzhFcJixAvlQaRfLnEYTYk8pss7YVSTucjGQ7ea9dDzQbL2Hv7AADwkUmTwDj 8oRz7oPvhN6UitRzvWmx7Ud3TxelHu3J55HaTAltJjjLQlB8lpiEw4mF657saEJXlpqaotZn ZzJ7vhj+eaqACNjCH1xlQsHiAYIlde4b3mXX8PjxQNKVnIfbEKvMjaXWhT2XCANyJuVs++Kn 8Ym31HvYaMa7CAzyErDNyqdkiAiWEImX6MR5AA3oqO+NniYZF9Kpo9QqR+GUHqGnVO6EZXgV YGTDVBal7UFzvoh6ngpocTHvvje951hxruB9VVp3LZvUC1vtouWXMfYj6rXaes8EMTbgsRom c0374UgbKGlzrqA3A4mv4EPFpFb3nSPKhLFz2fZIJfmqnifSZ5SWviv03CtzgDPk7Rs2kCjG 3oKiOZPdXGGEBUtHxj3qH2y19sbWmGc0Vsand1jJ1lGQ39ywNO+N7OQpD2/3qaa1MEzO1YCj 3DbDcICi5Fxty81neu6Xu/PERj4q9rEv3WDbwlfb2W52ikL5eQk7oaW9VO+ox+CdzouugXcO 6WdgOPNgnkA+cx1wH9nAd8BABE7F0f1d/40hzs62a1mEMlCf3JOVJ8WvU1Jcqf42WMfYfB7L xJyfYO+c2+PWX6ZoTYleX5bztfJgjSpmDzZecyspxQtb8zsrw2P5Sza0q/6Fh3mDEFaOHznw ciZY4+xpbrEIpmZdYTdCJU5UBBrqXEEGIb9ijNRtYjdlQshULBN9yH47D0uaMia3fx0zfYCB 26yWlh5P/LUCuI6K4CB48xKWpQblIg6H4KxpLKS6TgTCGrffpE5ly0LzuUd6JcUrGMHdwr31 pHyuDNu++cbCzj3g/M+RN9P6JV6m6iBee/GhiFF+IN09u0Pz238+SXyf/2qDf8Uj2gbUsEwa VDaEwLd8xGzgAYs7df6Fn4doXH5mQ/k1Vf5jl7llninqieiV2rbH1uAEn+mZVZXT5aL36Sq9 /KmNLoj0jA3A== X-IronPort-AV: E=Sophos;i="5.81,240,1610427600"; d="scan'208";a="40463976" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gq8E+bYP/w2DRNamVvtzae9hvqnXnc24Kym7qUhEGp6qihvzE1jsbnO7MYhhW1qAK45CdsM95wp+KU3WmpfuUDGWPhuGsyySipGqQhHHnn39EOmJeazvtmzs06o0Nb5zrgc69S8wcYnJkZS+/Ge8atkYli/DbRMBVLIWzMwA/znBV0rSzV1RNgSY5gNkV/89aYippVGwp+oyH9JGlGEKYrlns0EpZujUtZHcA9+KnRyMgi5KUtj9npGlNPsnjJY1cGj0CI/ZjPTXEAv91DviSYLFTt/VIVN8RZYB9cL8YIWN26foD7kQu0woNvttkoTAqguDfOGuX5mrgIJgziqN9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ajpze4cH1ExYhZ/fAlLPgE41D+0bllP+1rV/FTpxLa4=; b=fXoo024suvXf3rRflBYzimLNw03aAp3BWHkorMJsnDq6/Zi/cR2QtAxUoLoyRzkucqThbmQU0kRFSoukV76cBj/OBhyyRjfxz+zKnqlKfSoNAb+JQslHEf2GG1LSDISYlRGqkTyTM+YNf04yYVFLZAXQtK2LK+kbaB4IVgS8LbOeL3Lb0NEJsiG4jEzx6bne9uu1/jpGkqf59v0g4U5HdJft+E0hhpu8Y2Yu0gnbpoUC20XJZXXUYAFYUtOaZfqWTjwVsa8FkQd0eQ9zyGQvZPH1p+ZwPYwORuNJ9Wj8ybBoWTzgOz9DiW23Q24Y7zuabsSr6o4hf+B3mm3M67Uxeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ajpze4cH1ExYhZ/fAlLPgE41D+0bllP+1rV/FTpxLa4=; b=IRXfck3PrpN2gEJDuPgbtCO0s151G9FIxV2PQkMsbGLxtzK3jJBJhW+VDzgy7FTGCnpwISxFZvHrSz3oGBOTQ2G4IqleHk77iRtrP4aYd8Laa7ZPzqpg3VGcb5ULBNMYky4IS0CktbU4nOy0ovwvq63ey6lnrbrmwDNPA4xkdyE= To: Jan Beulich CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , Xen-devel , Juergen Gross , "Paul Durrant" References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> <556ce32b-5087-b8b1-432e-643218dd8c6e@suse.com> <9ca069ab-8b6c-c8f1-d68b-4a9bb0cf5c56@citrix.com> From: Andrew Cooper Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API Message-ID: <62b79d56-2438-23ab-49c0-a8c4b290c4f7@citrix.com> Date: Thu, 11 Mar 2021 13:00:53 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0493.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c58c1d16-c7db-4d23-b05a-08d8e48db847 X-MS-TrafficTypeDiagnostic: BYAPR03MB3864: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aDoQ6mTs9BBtsjjJuWG8Kxs2PPi2v9eKMb/EVB3yOdClO9/kWdknKaKTP+5lsB/msX2Y27/EwjZOx9/LDVd3vOsaXHD/P2eYy0R9g+FgYzXsgFMUVH5pv15+jtL7sEQ2tcTnhb3oQdfH/SvwNZcOUKd4nJYGKz7HDDFZkwCY/EaM9H/s2RGr99K5Ro4c7Om5gHAFHvX4oBZVfS4yFH5ph4KHlt+/OGh/1QJKqLn3VnwpHBtJHViOyXavoaRe19YZprmHDE75yqmQyTgoaP6aqJVVDL5RC84PYyaL4pzH25Ud0W4bDiCqAaEDpii29gnjz0d+kx6IbZOPOQOu5YabpfcUhj2yuFAvX79zmggnaD/ku9+2DP0HNCzJYxWsDlnoaDAn7n8vZSJ2vSlYuvgRVZl8rsxiTByIEnTaSbEtdzZPWeI5ccZNlEM2z9mMC0PC9FAQkhzcrP+oeFgvd0Sz7XHaZR2ZlSQaU/7NZ2S0A0vVSYg5w9aymyrvI6zLmnP9VC1850Trq1JBrLOBxdQSSzF1m8GbTG7UD3KtQZTi2DZPB4/lDf9fjOsHW6aY03zGhNRfc2eNXIyBlotdj8AJWQJOO13UNSzzIzJtbBnGJjY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39850400004)(376002)(396003)(366004)(346002)(136003)(4326008)(16576012)(66556008)(26005)(6916009)(6666004)(31686004)(31696002)(5660300002)(66946007)(16526019)(54906003)(186003)(36756003)(53546011)(956004)(478600001)(83380400001)(2616005)(6486002)(316002)(86362001)(8936002)(2906002)(66476007)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bTZ3MUpDL3NYODZ6VytZZUwrOCtlVTVVcmhURHdaeit1VEc3N2VEd2ZkWDM2?= =?utf-8?B?OE9LVU5PZm9rejZId3VzazREbmVadDhOdzZXRURkTmp3Q2VDNWZackMwZFRl?= =?utf-8?B?MklZNG9DOC94ME5sRUtheFdqTkdBNXc5cVh0M3ZkNm5KMUxqUTlFL0ZESCs3?= =?utf-8?B?dWYrWVF1WHFEN1RXU0l1VlorVXhwNkV3cWxTeWluWGZKWHNNTnRRRDg5RVBz?= =?utf-8?B?b1BTZ2RoempYV2lUcXpxWXJVRWFsMU9VSERCVTIrS1VzeVAvRWFuZzBXcWpM?= =?utf-8?B?M0RRbXE2U0tWbGo5a3lySkl4S1g5T1dkMldsOWVoQ2JnbnpSZ2xLeGtPRHF1?= =?utf-8?B?R2U4VlFRYVlEdkZRdWw0M2FVL0tSbDNCcDdiMUFIc05rWEFYcFhXWDVZcDFh?= =?utf-8?B?K09oQWI4d3NIOFJsMVN6WWhLRzhpWWVTRTQ5a3c1OUE0ZlhxWmhlQ1JWdUg0?= =?utf-8?B?UXZrNzh6N1lVRkp2OFJRVkFZSzJZVkdWUXdkS3d0akp5YWlXcFlhV3BYOTBq?= =?utf-8?B?dmFLVmRxRFQ1ckpKdUJtMTZsR2x5enlOZ2VvMnQ3cDlDdEtXcUo3UzJxajIw?= =?utf-8?B?UVdRbXNSckg4MjAvMDQwSlRvRHl5Y1FGcW9vNHRQRXVXSk5rTVBYZWRaczB4?= =?utf-8?B?ZzZIR1lsU3lpOWF4UldYTVN0OXB0aXB6R3dwM1Y1bUhPc0hEVlMySDUyYXZB?= =?utf-8?B?SURTTVkyTzJ1UldaQlBCb1Nacjl4VXlQVVNtZDdyUm90ZFV5TVh1ay9rUUJ0?= =?utf-8?B?elo2ZW1VcE5mVWE2NnZ2d21qUk5xUEtaSmlBaVlmTXdzeFFYRUxBdTIzRWFZ?= =?utf-8?B?NFJ3VmdQQTIxbGdKOEtNaFR2enhTLytzcm5qZlROdWNjUlV2TEt2a0s0THho?= =?utf-8?B?VFZzRERmV1gxYzdEYlRpM05na2lpWEpIV3h2NTVKTlRKd1doS2U1bGtCeUth?= =?utf-8?B?eTVaV2gvVjlnOHc2dmF1OEJVZEZFMkFZdGloS2dsaVVEV1piVVNNeTBuQzJx?= =?utf-8?B?aFFTTDVVaXAyVnV0WEZVRHhMYThnQjhIeTI0aDZLcVBWN0pSUjcvNm9vZkVs?= =?utf-8?B?Rzl0bjFIK0VxdFVRT2NZYzUrTlQwOEtQb2pjcS9lSVp2eHRWM2l4S1VoQnVk?= =?utf-8?B?a0VBN09yWkQ5UVV2YjRGRDVCZlhzSXhCU3hxbm1YOGNjS1hLTjJDenBKRExw?= =?utf-8?B?VGppR1pCTWlJQXZxV1JDNHB0L2J6bW5TbWlleC9YVDFOMkJEcHNiMkQzbGtx?= =?utf-8?B?bzVIdUY0S3lQY3A3OFA5SW51U3JjKy9GYk5naEFCTFJzQXE2Mm9BeTgxVVhX?= =?utf-8?B?TW1SUHJGdmRieWhnRml3ZjFhRjE2ZzR1aEZMMjhLa2JVMWRLVDhRNVVhVWZZ?= =?utf-8?B?Z3lKWmVKVWkveDFhcGxnWlJMYk4vdktWRXZMeVZkaVFtY2dvazRwdXBIdVg0?= =?utf-8?B?MVJ2elNMWTlTeEpSMERvc1NISzIweTBPVWIvaCtiZ3pMYWxGR05pRWFNU01F?= =?utf-8?B?c0JXRks4eWFLUVlZeHJtR25qTGZWd1JORmdpVEJwRmdKSzRlR2VwUWhyMVF6?= =?utf-8?B?VFp1M1hnc0N3QnJvVUZMbmRUY2V2MkgreGZLZEZzOVM5aEEwQllTMUJEMFo3?= =?utf-8?B?V2swb3NxMkFVeDJPb1FIdHRvZ2YxQnlxREVmUVhsUDNubWhMSGZtWERya1JU?= =?utf-8?B?MkVDQ1JGeFUrdDdzTys1VGIxNjR0K1E0UEoxRDYyV3QxUjdlcUdrWmZvODRR?= =?utf-8?Q?qNuGJKQYKnqPlubB6lnd4SIVUcgUc6ZNiED1FYR?= X-MS-Exchange-CrossTenant-Network-Message-Id: c58c1d16-c7db-4d23-b05a-08d8e48db847 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 13:01:00.8731 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8BUI7EbYB9O0hbyGtX8lJ405SU+R+q7veAkRgGGDEzB0P1Mhz39m/UBXcjtXa60GvPZbrCO3iAHW7uFBs1/FfdvaAgq5USZSi9C3j95l2aY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3864 X-OriginatorOrg: citrix.com On 11/03/2021 11:41, Jan Beulich wrote: > On 11.03.2021 12:05, Andrew Cooper wrote: >> On 11/03/2021 08:27, Jan Beulich wrote: >>> On 10.03.2021 18:22, Andrew Cooper wrote: >>>> On 10/03/2021 17:12, Jan Beulich wrote: >>>>> On 10.03.2021 16:07, Andrew Cooper wrote: >>>>>> --- a/docs/designs/dmop.pandoc >>>>>> +++ b/docs/designs/dmop.pandoc >>>>>> @@ -4,9 +4,13 @@ DMOP >>>>>> Introduction >>>>>> ------------ >>>>>> =20 >>>>>> -The aim of DMOP is to prevent a compromised device model from compr= omising >>>>>> -domains other than the one it is providing emulation for (which is = therefore >>>>>> -likely already compromised). >>>>>> +The DMOP hypercall has a new ABI design to solve problems in the Xe= n >>>>>> +ecosystem. First, the ABI is fully stable, to reduce the coupling = between >>>>>> +device models and the version of Xen. >>>>>> + >>>>>> +Secondly, for device models in userspace, the ABI is designed speci= fically to >>>>>> +allow a kernel to audit the memory ranges used, without having to k= now the >>>>>> +internal structure of sub-ops. >>>>> I appreciate the editing, but the cited points still don't justify ..= . >>>>> >>>>>> --- a/xen/include/public/hvm/dm_op.h >>>>>> +++ b/xen/include/public/hvm/dm_op.h >>>>>> @@ -25,9 +25,6 @@ >>>>>> #define __XEN_PUBLIC_HVM_DM_OP_H__ >>>>>> =20 >>>>>> #include "../xen.h" >>>>>> - >>>>>> -#if defined(__XEN__) || defined(__XEN_TOOLS__) >>>>>> - >>>>>> #include "../event_channel.h" >>>>>> =20 >>>>>> #ifndef uint64_aligned_t >>>>>> @@ -491,8 +488,6 @@ struct xen_dm_op { >>>>>> } u; >>>>>> }; >>>>>> =20 >>>>>> -#endif /* __XEN__ || __XEN_TOOLS__ */ >>>>>> - >>>>>> struct xen_dm_op_buf { >>>>>> XEN_GUEST_HANDLE(void) h; >>>>>> xen_ulong_t size; >>>>> ... this removal: What the kernel needs for its auditing (your 2nd >>>>> point) is already outside of this guarded region, as you can see >>>>> from the context above. You said there was a design goal of allowing >>>>> use of this interface by (and not only through) the kernel, e.g. by >>>>> a kernel module (which I don't think you mean to be covered by >>>>> "device models"). If that was indeed a goal (Paul - can you confirm >>>>> this?), this would now want listing as a 3rd item. Without such a >>>>> statement I'd call it a bug to not have the guards there, and hence >>>>> might either feel tempted myself to add them back at some point, or >>>>> would ack a patch doing so. >>>> Xen has absolutely no business dictating stuff like this. >>> Actually there's no "dictating" here anyway: People are free to clone >>> the headers and omit the guards anyway. >> That is somewhere between busywork and just plain rude to 3rd parties.= =C2=A0 >> "here are some headers but you need to unbreak them locally before use". >> >>> Outside of our own build >>> system they really mainly serve a documentation purpose. >> Header guards are not documentation > And I didn't say so - I said they server a documentation purpose. > >> - they are active attempt to >> segregate hypercalls by "who we think is supposed to use them". >> >> MiniOS, which uses this header within our build system, is not a part of >> the toolstack, and should not need to define __XEN_TOOLS__ to be able to >> use stable-ABI hypercalls. > I've not been able to spot a definition of __XEN_TOOLS__ in the > mini-os sources. Are you perhaps referring to tool stack libraries > getting built also for it? Things in stubdom/ which include xenctrl.h get __XEN_TOOLS__ set behind the scenes, which is the only way that including libxendevicemodel.h worked before last week. > >> Equally, the fact that libxendevicemodel's private.h needed to define >> __XEN_TOOLS__ demonstrates the problem - dm_op.h (the structs and >> defines - not just the types) are necessary to use the ioctl() on >> /dev/xen/devicemodel in the first place. > But this library _is_ part of the tool stack. Looks like it really > boils down to ... > >>>> =C2=A0 It is an >>>> internal and opaque property of the domain if the hypercalls happen to >>>> originate from logic in user mode or kernel mode.=C2=A0 Stubdomains wo= uld >>>> fall into the same "kernel" category as xengt in the dom0 i915 driver. >>>> >>>> However, the actual bug I'm trying to fix with this is the need for >>>> userspace, which doesn't link against libxc, to do >>>> >>>> #define __XEN_TOOLS__ >>>> #include >>>> >>>> to be able to use the libxendevicemodel stable library. >>>> >>>> The __XEN_TOOLS__ guard is buggy even ignoring the kernel device model >>>> aspect. >>> Depends on what __XEN_TOOLS__ really means - to guard things accessible >>> to any part of the tool stack, or to guard unstable interfaces only. >> As far as I'm concerned, __XEN_TOOLS__ should always have been spelled >> __XEN_UNSTABLE_ABI__. > ... this. If you added half a sentence to this effect to the description, > you may feel free to add > Acked-by: Jan Beulich > > I still would appreciate if you also added the kernel (module) aspect to > the doc change. Thanks, will do, and I'll post a v3 just to check that everyone is happy. However, having laid things out in this way today, it occurs to me that we should consider further cleanup as well. I do agree that code wanting to use the libxendevicemodel.h API almost certainly don't want/need the dmop ABI.=C2=A0 (i.e. an individual consumer will want one, or the other, but almost certainly not both together). Should libxendevicemodel.h really be including dm_op.h?=C2=A0 AFAICT, it is only the ioserverid_t typedef which is API shared between the two contexts, and we can trivially typedef that locally. This is something which we should either do now, or not at all. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Mar 11 13:01:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 13:01:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96513.182621 (Exim 4.92) (envelope-from ) id 1lKKwv-0002m7-AR; Thu, 11 Mar 2021 13:01:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96513.182621; Thu, 11 Mar 2021 13:01:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKKwv-0002m0-6T; Thu, 11 Mar 2021 13:01:57 +0000 Received: by outflank-mailman (input) for mailman id 96513; Thu, 11 Mar 2021 13:01:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKKwt-0002lc-Ti for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 13:01:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d4d77ad6-7fa4-4099-9559-6315289181ae; Thu, 11 Mar 2021 13:01:55 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 49C5CAC16; Thu, 11 Mar 2021 13:01:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4d77ad6-7fa4-4099-9559-6315289181ae X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615467714; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LX4kSJDVCVwQMzj45QZ8QAyUyw/ZVjuaoRQUn153FRQ=; b=hFs1/xKfAYxQj4/ok4wrrhekigK1xVHH88/97tpk66GnxDwItLvb8v/m3Bjn94IKOxBRUM gDt1ZKIrLY/rKcIDPtrf1Nz48CcnIfSEt5i8D2xQ/ugM8cNGdEwoqIxM+GzO1dRKJ+lZXv RuY7LaICRYo58mbG3nHaVjh6ffMODJg= Subject: Re: [PATCH RFC] build: detect outdated configure outputs To: Roger Pau Monne Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210311114601.42460-1-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Thu, 11 Mar 2021 14:01:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210311114601.42460-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11.03.2021 12:46, Roger Pau Monne wrote: > The Xen build system relies on configure to parse some .in files in > order to do substitutions based on the data gathered from configure. > > The main issue with those substitutions done at the configure level is > that make is not able to detect when they go out of date because the > .in file has been modified, and hence it's possible to end up in a > situation where .in files have been modified but the build is using > outdated ones. This is made even worse because the 'clean' targets > don't remove the output of the .in parsing, so doing a typical `make > clean && make` will still use the old files without complaining. > Note that 'clean' not removing the output of the .in transformations > is the right behavior, otherwise Xen would require re-executing the > configure script after each clean. > > Attempt to improve the situation by adding a global rule that spot the > outdated files as long as they are properly listed as makefile target > prerequisites. > > Ultimately those substitutions should be part of the build phase, not > the configure one. > > Signed-off-by: Roger Pau Monné > --- > RFC because I'm not sure if there's some better way to handle this. > Also I think we would want to make sure all the .in outputs are > properly listed as target prerequisites, or else this won't work. > > Also not sure whether this will break some other usage of .in files > I'm not aware. There are a number of such files in the tree which aren't used to record configure results. Whether their existence could actually case a problem with this approach I can't tell. Would it be possible to ... > --- a/Config.mk > +++ b/Config.mk > @@ -65,6 +65,10 @@ DEPS_RM = $(DEPS) $(DEPS_INCLUDE) > %.d2: %.d > sed "s!\(^\| \)$$PWD/! !" $^ >$@.tmp && mv -f $@.tmp $@ > > +# Make sure the configure generated files are up to date > +%: %.in > + $(error $@ is outdated, please re-run configure) ... make this a static pattern rule for just the file names that are actually processed / produced by configure? Of course it wouldn't be very nice to have to keep in sync that list and what the various configure.ac scripts list in AC_CONFIG_FILES() et al. But not listing the targets explicitly would always risk the rule to kick in for a file where it's not supposed to apply. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 13:05:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 13:05:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96515.182633 (Exim 4.92) (envelope-from ) id 1lKL0D-0002vp-Q7; Thu, 11 Mar 2021 13:05:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96515.182633; Thu, 11 Mar 2021 13:05:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKL0D-0002vi-Lz; Thu, 11 Mar 2021 13:05:21 +0000 Received: by outflank-mailman (input) for mailman id 96515; Thu, 11 Mar 2021 13:05:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKL0C-0002va-Kn; Thu, 11 Mar 2021 13:05:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKL0C-0005Pa-D4; Thu, 11 Mar 2021 13:05:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKL0C-0004za-5n; Thu, 11 Mar 2021 13:05:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKL0C-00018c-50; Thu, 11 Mar 2021 13:05:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Pj2jmNIQ3m/XFiOg1ssLYVUu9tg1/jamc9EMXspErAM=; b=FbJUU/+xFFP4IqiBTdtKZ6jVYl 0gmjmCIYwbqD/ZGo1JZph++gd0II6MdGodzmCbpZYt4kaJgTaawVSH3VTubiQsQF8CgnsDPA4ofbO 57kVybtu1OekFcTfBq6IZ/id8DwZNZzE9gmq9MvtVsHYxG6MRKCOwDJ4GCdrXfcZtI8M=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159920: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-qemuu-rhel6hvm-intel:guest-start/redhat.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e4bdcc8aef6707027168ea29caed844a7da67b4d X-Osstest-Versions-That: xen=1b47cc852fd130ed9ce274a0f1600a4a62949a2c From: osstest service owner Date: Thu, 11 Mar 2021 13:05:20 +0000 flight 159920 xen-unstable real [real] flight 159936 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159920/ http://logs.test-lab.xenproject.org/osstest/logs/159936/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-intel 14 guest-start/redhat.repeat fail pass in 159936-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail like 159906 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159906 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159906 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159906 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159906 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159906 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159906 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159906 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159906 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159906 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159906 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159906 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen e4bdcc8aef6707027168ea29caed844a7da67b4d baseline version: xen 1b47cc852fd130ed9ce274a0f1600a4a62949a2c Last test of basis 159906 2021-03-10 08:20:16 Z 1 days Testing same since 159920 2021-03-10 20:37:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ian Jackson Jan Beulich Roger Pau Monne Roger Pau Monné Wei Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 1b47cc852f..e4bdcc8aef e4bdcc8aef6707027168ea29caed844a7da67b4d -> master From xen-devel-bounces@lists.xenproject.org Thu Mar 11 13:09:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 13:09:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96522.182648 (Exim 4.92) (envelope-from ) id 1lKL3s-0003DR-E8; Thu, 11 Mar 2021 13:09:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96522.182648; Thu, 11 Mar 2021 13:09:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKL3s-0003DK-7x; Thu, 11 Mar 2021 13:09:08 +0000 Received: by outflank-mailman (input) for mailman id 96522; Thu, 11 Mar 2021 13:09:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKL3q-0003DF-JT for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 13:09:06 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3f162f00-009a-438c-b8ad-5b33ba551e7d; Thu, 11 Mar 2021 13:09:05 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B29A9AC17; Thu, 11 Mar 2021 13:09:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f162f00-009a-438c-b8ad-5b33ba551e7d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615468145; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/cnNGJS92LaF9k2ZTwqu9nk70vjyYRogPXIIe3N+itQ=; b=kSANEUwtRLviDB/KeIGzWdmCHf41qrSF9+Pm1o/8rRyuc8A/u8rrbcbOZP76OHKzT0Ahan o4iw1I/ZCFewIHFheXvfWca3clVhL5wyEWkdV6xa8e1HH+Me6ZBUX+ZSZrsIO76H/stff7 2z+fhGh3Mab5+X9lwPIQQBbdGVYU1Is= Subject: Re: [PATCH v6 00/12] x86: major paravirt cleanup To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, clang-built-linux@googlegroups.com, Peter Zijlstra , Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel , Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini , Andy Lutomirski , Nathan Chancellor , Nick Desaulniers References: <20210309134813.23912-1-jgross@suse.com> <20210311125026.GB5829@zn.tnic> <20210311125143.GC5829@zn.tnic> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <121a494d-b365-eb41-c329-2f0676b72c20@suse.com> Date: Thu, 11 Mar 2021 14:09:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210311125143.GC5829@zn.tnic> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sHGm1foLXOCKkEUnUGNC7UsESSEa9kG2D" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sHGm1foLXOCKkEUnUGNC7UsESSEa9kG2D Content-Type: multipart/mixed; boundary="ncnlhSdjJDB3MyBZ79puGdjOzrKooCvcO"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Borislav Petkov Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, clang-built-linux@googlegroups.com, Peter Zijlstra , Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel , Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini , Andy Lutomirski , Nathan Chancellor , Nick Desaulniers Message-ID: <121a494d-b365-eb41-c329-2f0676b72c20@suse.com> Subject: Re: [PATCH v6 00/12] x86: major paravirt cleanup References: <20210309134813.23912-1-jgross@suse.com> <20210311125026.GB5829@zn.tnic> <20210311125143.GC5829@zn.tnic> In-Reply-To: <20210311125143.GC5829@zn.tnic> --ncnlhSdjJDB3MyBZ79puGdjOzrKooCvcO Content-Type: multipart/mixed; boundary="------------C6C892EEF89D5D4CB4A414F1" Content-Language: en-US This is a multi-part message in MIME format. --------------C6C892EEF89D5D4CB4A414F1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 11.03.21 13:51, Borislav Petkov wrote: > On Thu, Mar 11, 2021 at 01:50:26PM +0100, Borislav Petkov wrote: >> and move the cleanups patches 13 and 14 to the beginning of the set? >=20 > Yeah, 14 needs ALTERNATIVE_TERNARY so I guess after patch 5, that is. I'm putting 13 at the begin of the series and 14 after 5. Juergen --------------C6C892EEF89D5D4CB4A414F1 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------C6C892EEF89D5D4CB4A414F1-- --ncnlhSdjJDB3MyBZ79puGdjOzrKooCvcO-- --sHGm1foLXOCKkEUnUGNC7UsESSEa9kG2D Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBKFm4FAwAAAAAACgkQsN6d1ii/Ey+h KQgAjhK+g8WC8LZv2hOzJE0RlIalM761Yaxv12fceCorl30Mq4b1ZB57xdM97FUQkO6DjnJs7XYg 2c97qfyRRv9pPDd+Su+Fh7p2Uu47BFyHBxT250G0OwoK6/j/FZzu4EPYtliizyz2yMJ8+qtHugU2 8vXAmywUjTjUvKSIfPAOmn5tjViNfhf27RnVZAY/LF8zkg05naANhSW3K2fKfT5se7UBaPxK1f+2 YKKfs031D231+gYklLq9lLoBhfIu6RYF4wiVdcNw7oFNjMv8ggFAUVRDmtTEOa8GkQsqHDpvqdoJ 0i0OjOZrTslf0aJUbx0dLx60C4JKa2cQAkGwGgKU1Q== =koDR -----END PGP SIGNATURE----- --sHGm1foLXOCKkEUnUGNC7UsESSEa9kG2D-- From xen-devel-bounces@lists.xenproject.org Thu Mar 11 13:10:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 13:10:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96529.182663 (Exim 4.92) (envelope-from ) id 1lKL5P-00042k-VV; Thu, 11 Mar 2021 13:10:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96529.182663; Thu, 11 Mar 2021 13:10:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKL5P-00042d-Rd; Thu, 11 Mar 2021 13:10:43 +0000 Received: by outflank-mailman (input) for mailman id 96529; Thu, 11 Mar 2021 13:10:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKL5P-00042Y-2U for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 13:10:43 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 19d7dcb6-c34e-4525-a4d3-4d0a4189c63b; Thu, 11 Mar 2021 13:10:41 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9BDB6AC17; Thu, 11 Mar 2021 13:10:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19d7dcb6-c34e-4525-a4d3-4d0a4189c63b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615468240; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qkCgyc/0YHXHvklSdGu08gAy+D75TOJkvXrE+D8kTMg=; b=lmfQKu6ZkwxdlilZcvIUa89S6tlCUDpLEdzCXaNxN21pTzAjrqybUyydA/LYlquQtFjL0c /PeUYqNic82y3l8dR7wwXu/Gndfy+fJtH3iMXF0klrd3BdzCV54X7vMdIHWp+A0xVgn2qx be8t78td2fvCta5/ZPbSfuEVctETk+w= Subject: Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org, Julien Grall References: <20210310065803.348-1-michal.orzel@arm.com> <3d3e5573-6d64-98cd-1f6f-897eb860d8ba@xen.org> <16f39b33-2e26-1a4b-5415-02cd14edaf24@arm.com> <54c7a952-cc17-8ab5-1aec-d1bd2453d1a1@arm.com> From: Jan Beulich Message-ID: Date: Thu, 11 Mar 2021 14:10:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <54c7a952-cc17-8ab5-1aec-d1bd2453d1a1@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11.03.2021 13:39, Michal Orzel wrote: > On 11.03.2021 12:11, Julien Grall wrote: >> On 11/03/2021 10:41, Michal Orzel wrote: >>> On 11.03.2021 11:34, Julien Grall wrote: >>>> On 10/03/2021 06:58, Michal Orzel wrote: >>>>> Currently in order to link existing DTB into Xen image >>>>> we need to either specify option CONFIG_DTB_FILE on the >>>>> command line or manually add it into .config. >>>>> Add Kconfig entry: CONFIG_DTB_FILE to be able to >>>>> provide the path to DTB we want to embed into Xen image. >>>>> If no path provided - the dtb will not be embedded. >>>>> >>>>> Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>>> as it is not needed since Kconfig will define it in a header >>>>> with all the other config options. >>>>> >>>>> Signed-off-by: Michal Orzel >>>>> --- >>>>>    xen/arch/arm/Makefile | 5 ++--- >>>>>    xen/common/Kconfig    | 8 ++++++++ >>>>>    2 files changed, 10 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile >>>>> index 16e6523e2c..46e6a95fec 100644 >>>>> --- a/xen/arch/arm/Makefile >>>>> +++ b/xen/arch/arm/Makefile >>>>> @@ -68,9 +68,8 @@ extra-y += $(TARGET_SUBARCH)/head.o >>>>>      #obj-bin-y += ....o >>>>>    -ifdef CONFIG_DTB_FILE >>>>> +ifneq ($(CONFIG_DTB_FILE),"") >>>>>    obj-y += dtb.o >>>>> -AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>>>    endif >>>>>      ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) >>>>> @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >>>>>    xen.lds: xen.lds.S >>>>>        $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >>>>>    -dtb.o: $(CONFIG_DTB_FILE) >>>>> +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) >>>>>      .PHONY: clean >>>>>    clean:: >>>>> diff --git a/xen/common/Kconfig b/xen/common/Kconfig >>>>> index eb953d171e..a27836bf47 100644 >>>>> --- a/xen/common/Kconfig >>>>> +++ b/xen/common/Kconfig >>>>> @@ -400,6 +400,14 @@ config DOM0_MEM >>>>>            Leave empty if you are not sure what to specify. >>>>>    +config DTB_FILE >>>>> +    string "Absolute path to device tree blob" >>>>> +    depends on HAS_DEVICE_TREE >>>>> +    ---help--- >>>>> +      When using a bootloader that has no device tree support or when there >>>>> +      is no bootloader at all, use this option to specify the absolute path >>>>> +      to a device tree that will be linked directly inside Xen binary. >>>> >>>> With this approach, CONFIG_DTB_FILE will always be defined. This means that Xen will always be compiled to use the "embedded" DTB. When the string is "", it will be garbagge. >>>> >>>> So I think we need a second config to that indicates whether the string is empty or not. >>>> >>>> Interestingly, your first version of patch didn't expose the problem because CONFIG_DTB_FILE would not be defined if the CONFIG_LINK_DTB is not selected. Although, it would still happily build if CONFIG_DTB_FILE is "". >>>> >>>> Cheers, >>>> >>> I do not agrree. We do not need another config. >> >> Did you test that Xen will still boot if the string is empty? >> >>> If string is empty - the dtb.o will not be created and there will be no dtb section in xen binary. >> >> The dtb.o will not be created but the section will because the linker use #ifdef CONFIG_DTB_FILE: >> >> 42sh> grep CONFIG_DTB .config >> CONFIG_DTB_FILE="" >> 42sh> nm xen-syms | grep _sdtb >> 00000000003560f8 B _sdtb >> >> And to show this is going to be used: >> >> 42sh> git diff >> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S >> index 5d44667bd89d..2b680b8226d2 100644 >> --- a/xen/arch/arm/arm64/head.S >> +++ b/xen/arch/arm/arm64/head.S >> @@ -297,6 +297,7 @@ real_start_efi: >> >>          /* Using the DTB in the .dtb section? */ >>  #ifdef CONFIG_DTB_FILE >> +        e >>          load_paddr x21, _sdtb >>  #endif >> >> 42hs> make >> [...] >>   CC      arm64/head.o >> arm64/head.S: Assembler messages: >> arm64/head.S:300: Error: unknown mnemonic `e' -- `e' >> /home/ANT.AMAZON.COM/jgrall/works/oss/xen/xen/Rules.mk:204: recipe for target 'arm64/head.o' failed >> >> So _sdtb is going to always be used... >> >> Cheers, >> > > Yes you are right. So I could add another config like: > config DTB_VALID > def_bool y if DTB_FILE != "" > and change all the lines containing: > #ifdef CONFIG_DTB_FILE > to > #ifdef CONFIG_DTB_VALID I'm sorry to jump in again, but I still think a 2nd Kconfig setting is not needed. I count three uses of CONFIG_DTB_VALID outside of make files. The ones in .S can be replaced by using assembler directives .ifeqs / .ifneqs. And the one in xen.lds.S looks to be unnecessary altogether: If there's no input .dtb section, the linker wouldn't allocate an output one anyway. And the _sdtb symbol, if you want to avoid its creation when there's no reference, could be wrapped in PROVIDE(). (I also think that symbol should be defined inside the section definition, not ahead of it.) Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 13:24:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 13:24:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96537.182693 (Exim 4.92) (envelope-from ) id 1lKLIc-0005DV-9T; Thu, 11 Mar 2021 13:24:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96537.182693; Thu, 11 Mar 2021 13:24:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLIc-0005DO-6c; Thu, 11 Mar 2021 13:24:22 +0000 Received: by outflank-mailman (input) for mailman id 96537; Thu, 11 Mar 2021 13:24:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLIb-0005DJ-0u for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 13:24:21 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c22d0991-3472-460f-945e-79071deafbc7; Thu, 11 Mar 2021 13:24:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c22d0991-3472-460f-945e-79071deafbc7 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615469060; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=tHuesWFQA7Mchpj7f9p42VhfotJUCO8dFEjaWBOOtbk=; b=JiaM2ZbWnbL4o0Je2XryioliSioJddRy5DwXMYPUd4G531PnUwI5mjvE lKshG0Pn8D3mAN+33H1CXfWAkkaPrXqSQqyR7+awEFubi0okZMwVDfZHZ GUlr/N20xqm9B8o1J73aIazz7FwK4Q51wKJCvX0MyJJnF9OUDS1gNCfpA 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: dUgzisvD0S1vEDYgMEc8CmpC7u30st7aWwqcP/AXZ3LPIdkqYqSYlvxMNKdt8y15OUEfnizyL+ ZZvWQnY5PtLlrptKZjNMYKvOGbPcnMnfgpTiuUKsw+0Ilw3a1RRUg24MA8IEKmge+3yZAHdOLX tdVOHpkHyfVaf057qqJiqaVHusW53Q3n969+YPWNEuCHTnaSZ/SZwJglsJZoEstCEtrZLWyc1v p5cMCfr4EBAxlH3mcGI/qCQMHzL8f2Fql8iE95puSMIS8ULDlggnRXheg8ckubxUr+olRvLpRe VwY= X-SBRS: 4.0 X-MesageID: 39228458 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:TEhs7aNpDdmDn8BcTxP155DYdL4zR+YMi2QD/1xtSBBTb8yTn9 2vmvNe7hPvlDMNQhgb9OyoEqPoexPh3LRy5pQcOqrnYRn+tAKTXeVfxKbB4xmlIS3x8eZByb xtGpIVNPTcBUV35PyU3CCWCNAlqePozImNpcPzi0hgVhtrbaYI1XYdNi++HldtTAdLQboVfa DshfZvnDardXQJYsnTPBBsM9TrnNHXiIngJScPGh9P0mKzpAm14733GQXw5GZ9bxpzx94ZkF TtokjCyYiI99q6zRLd0GG71eUqpPLRjuFtKebJpswcKjDHghulaoJ7S9S5zUwIidDq0nkGup 3hpAohItRS5hrqDx6IiCqo4SbM+nIP7GLv0lCRi3eLm72GeBsKT/BvqKgcVzmx0TtGgPhMlJ hl8kjcir9sSTTHpyj578igbWAQqmOE5UAMvMRWs2ZSSuIlGdlshL1axmx5OrEaEhn37Yg2ed Medv301bJtfVSWY2uxhBgX/PWcGnA6HhKxSkMfoMCi0z9PgHBjz0cDrfZv5ks9yA== X-IronPort-AV: E=Sophos;i="5.81,240,1610427600"; d="scan'208";a="39228458" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant , Ian Jackson Subject: [PATCH for-4.15 v3] xen/dmop: Strip __XEN_TOOLS__ header guard from public ABI Date: Thu, 11 Mar 2021 13:24:00 +0000 Message-ID: <20210311132400.24411-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit __XEN_TOOLS__ is really there to separate the unstable from stable hypercalls. Exactly as with c/s f40e1c52e4, stable interfaces shouldn't contain this guard. That change actually broke the build with: include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t' ioservid_t *id); ^ as libxendevicemodel.h now uses a type it can't see a typedef for. However, nothing noticed because the header.chk logic is also broken (fixed subsequently). Strip the guard from the public header, and remove compensation from devicemodel's private.h. Fix the dmop design doc to discuss both reasons behind the the ABI design. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-Acked-by: Ian Jackson --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Paul Durrant CC: Ian Jackson v3: * Clarifications to the commit message, and dmop.pandoc v2: * Patch dmop.pandoc as well. --- docs/designs/dmop.pandoc | 12 +++++++++--- tools/libs/devicemodel/private.h | 2 -- xen/include/public/hvm/dm_op.h | 5 ----- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/docs/designs/dmop.pandoc b/docs/designs/dmop.pandoc index 8e9f95af47..49e52b1bcc 100644 --- a/docs/designs/dmop.pandoc +++ b/docs/designs/dmop.pandoc @@ -4,9 +4,15 @@ DMOP Introduction ------------ -The aim of DMOP is to prevent a compromised device model from compromising -domains other than the one it is providing emulation for (which is therefore -likely already compromised). +The DMOP hypercall has a new ABI design to solve problems in the Xen +ecosystem. First, the ABI is fully stable, to reduce the coupling between +device models and the version of Xen. Specifically, device model software +using DMOP (be it user, stub domain or kernel software) need not be recompiled +to match the version of the running hypervisor. + +Secondly, for device models in userspace, the ABI is designed specifically to +allow a kernel to audit the memory ranges used, without having to know the +internal structure of sub-ops. The problem occurs when you a device model issues an hypercall that includes references to user memory other than the operation structure diff --git a/tools/libs/devicemodel/private.h b/tools/libs/devicemodel/private.h index c4a225f8af..c24f3396bb 100644 --- a/tools/libs/devicemodel/private.h +++ b/tools/libs/devicemodel/private.h @@ -1,8 +1,6 @@ #ifndef XENDEVICEMODEL_PRIVATE_H #define XENDEVICEMODEL_PRIVATE_H -#define __XEN_TOOLS__ 1 - #include #include #include diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h index ef7fbc0d3d..fa3f083fed 100644 --- a/xen/include/public/hvm/dm_op.h +++ b/xen/include/public/hvm/dm_op.h @@ -25,9 +25,6 @@ #define __XEN_PUBLIC_HVM_DM_OP_H__ #include "../xen.h" - -#if defined(__XEN__) || defined(__XEN_TOOLS__) - #include "../event_channel.h" #ifndef uint64_aligned_t @@ -491,8 +488,6 @@ struct xen_dm_op { } u; }; -#endif /* __XEN__ || __XEN_TOOLS__ */ - struct xen_dm_op_buf { XEN_GUEST_HANDLE(void) h; xen_ulong_t size; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 13:28:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 13:28:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96540.182705 (Exim 4.92) (envelope-from ) id 1lKLMk-0005W4-Sh; Thu, 11 Mar 2021 13:28:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96540.182705; Thu, 11 Mar 2021 13:28:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLMk-0005Vx-Oj; Thu, 11 Mar 2021 13:28:38 +0000 Received: by outflank-mailman (input) for mailman id 96540; Thu, 11 Mar 2021 13:28:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLMi-0005Vs-Oz for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 13:28:36 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 71ec5d34-e96f-4668-ad19-6df3a038931a; Thu, 11 Mar 2021 13:28:36 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4B420AC17; Thu, 11 Mar 2021 13:28:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71ec5d34-e96f-4668-ad19-6df3a038931a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615469315; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=97+7cVHLYJrSNxbgQR4BFmmxVrB8XCPJYoxHCAcPS/Y=; b=gr8+2698g+Lyt+n91dW6Tqih28wTWljeBVhlJF879szU9CFUnBJXgkHf/5yQckT62sswyN 7tz9O2HA0gUI5IRGmlD/hfysmXNKkmopd31rJ2xI1YtdtHSBLjx7DJDvp8ZMbMGHcJ1nTe 3Hys1vvl8Dw1Cu9/fTi6ex6+W6cW8Wo= Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , Xen-devel , Juergen Gross , Paul Durrant References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> <556ce32b-5087-b8b1-432e-643218dd8c6e@suse.com> <9ca069ab-8b6c-c8f1-d68b-4a9bb0cf5c56@citrix.com> <62b79d56-2438-23ab-49c0-a8c4b290c4f7@citrix.com> From: Jan Beulich Message-ID: <9a248354-f68b-8cba-f18c-f4a26473f9bf@suse.com> Date: Thu, 11 Mar 2021 14:28:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <62b79d56-2438-23ab-49c0-a8c4b290c4f7@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11.03.2021 14:00, Andrew Cooper wrote: > However, having laid things out in this way today, it occurs to me that > we should consider further cleanup as well. > > I do agree that code wanting to use the libxendevicemodel.h API almost > certainly don't want/need the dmop ABI.  (i.e. an individual consumer > will want one, or the other, but almost certainly not both together). > > Should libxendevicemodel.h really be including dm_op.h? I was indeed wondering. >  AFAICT, it is > only the ioserverid_t typedef which is API shared between the two > contexts, and we can trivially typedef that locally. Hmm, a local typedef isn't nice - there should be one central point. Granted there's no risk for this to change in anywhere halfway foreseeable future, but still. Also neither C89 nor C99 allow a typedef to be repeated - in those versions we'd then rely on an extension. > This is something which we should either do now, or not at all. Well, yes, would be better. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 13:29:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 13:29:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96541.182718 (Exim 4.92) (envelope-from ) id 1lKLN9-0005ax-53; Thu, 11 Mar 2021 13:29:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96541.182718; Thu, 11 Mar 2021 13:29:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLN9-0005aq-1G; Thu, 11 Mar 2021 13:29:03 +0000 Received: by outflank-mailman (input) for mailman id 96541; Thu, 11 Mar 2021 13:29:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLN8-0005al-Ix for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 13:29:02 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cc83307f-3858-4eb2-8a85-bb8f71cb5891; Thu, 11 Mar 2021 13:29:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc83307f-3858-4eb2-8a85-bb8f71cb5891 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615469341; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=DzlnXfHu3E0CiSDJExmPfxAYPu8qtXUSLlXDgNzQwv0=; b=XEbyJRY8OnarD3cH7/vXF04gPNwmasUUpC3up2uD/zJQKStKbZcyCHzC 6WWMMqvYmn48ryGvXd1VnOOOuQAmbd+//Uqx9ku+j9k65FXt8mMnIroo4 QI+BDxPKd1aEUfcYJYQhLoYfyX77P0Hp8s06pk4WNVvG1m2ttszOdPycG w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: xbh7ZpHljAF8jgsW6FPnkVap5reVh1RnCfA7e5yMik+RYuEvot9Kg9vgEXbGuMIggyIJEoBFxu yDPcPa6HyCwrzrRZ4XHQoznl3EPfYVeUER1pufn6cTFJ/1V4iQIMAswjguTRlkmPtxzUseyjiT Ebg9twZVnJa09zhMZhhKw7s9nTPcEZcmNZD8DDjxCfti7HdtGnwnLQlx9go+7ekHGRAeJMRpT1 M6432RaV8pfQdOlQ4SlU0zkrdFphxSZ5SVK846+j0uEDgdQxwDhW7E0ZNVchu67h42Q3Kk+zLJ pVk= X-SBRS: 5.2 X-MesageID: 39047544 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:QhxTo6EPsE+vWkYtpLqFRZTXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7Lk/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeNJwTXzcQY76 tpdsFFZeHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLD1CQYsI1XYcNi+wFEpqSA5aQb8wE5 SB7sRKzgDQBkg/RMK9G3UDQqz/vNXNjp3relorABQg5QmIg1qTmcLHOjKf2QoTVC4K/Kc6/Q H+4nHEz4iAk9X+8B/T0GfP849b8eGO9vJvDNGB4/JlUgnEpR2vYO1aKtu/lRAz5Nqi8VM71O TLyi1QRfhbz1P0UiWLrQD22w/muQxemEPK7VODm3PsrYjYaVsBerN8rLlUeBfY9EYs1esUuM kgvxP7xu9qJCjNkyjn69/DWwsCrDvSnVMYnfMOlHsaaIMCadZq3Pwi1XlIG5QNFj+S0vFELM BSCqjnlZNrWG+BY2uclmdix8HEZAVJIj62BmIGusCTzgFMmmF4w0Yy1KUk7wY93aN4ZJ9e6+ veNKN00JlIU88NdKp4QNwMWM2tFwX2MF3xGVPXBW6iOLAMOnrLpZKyyLIp5NuycJhN6Jcpgp zOXH5RqGZaQTOhNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dQWeVVEHiaKb0rYiK/yef8 z2FINdAvflI2erM51OxRfCV55bLmRbeNEJu+w8R0mFrqvwW83Xn92eVMyWCKvmED4iVG+6KG AERiLPKMJJ6V3udWT/hDTXRnPxam3y9Z99C8Hhjq0u4blIErcJnhkeiFy/6M3OAyZFqLYKcE x3J66isq7TnxjzwU/4q0FSfjZNBEdc57vtF1lQoxURDk/yebEf//GWeWVY2mq7NgZyJvmmVz J3lhBSw+aaPpaQzSctB5aMKWSBlUYeo3qMUtM6lrCc49zmPrc1FIwvVqA0NQijLW01pS9a7E N4LCMUTE7WET3jzY+/ioYPOe3Zf95gxCGxIcBVrnrbnV6Gpd4mQ0YaWzLGa7/UvS8eAx5vwn Fh+a4Wh7SN3Ry1L3Ekveg+OFpQLFiMDKl+FwSDboVMkrXNcAV9JF36wwCyulUWQC7H5k8Sjm vuIWmxdevQClRQgHxez53n6Uh5bGmbYkJ2ZE1rqIEVLxW1hl9DlcuwIoaj2WqYbVUPhtsQNz zIehM+CAJjzdLf7m/epB+yUVEdgrk+NO3UC7ouN4zJ0nS2MYuSiOUtBPlP5qtoM9jor84GWe +SYBWuMTv9Eu8lsjbl/0oNCW1Rkj0JgPno0Brq4CyEx3Y5G+PVO0kjaLcBId2QhlKUDsqg4d Fct5YSsuSxOGmqNYLD5qHTcjJZKhTc5USxVPolrJhIvaQ08Jt/dqOrJgfg5TVi5lEZKsyxqW Y1BIJcy5rFMpV0f8MTdzlCl2BZ3+inHQ8OiEjOHuQ6fVsRlHfVMNOC3qrQpdMUczm8jTq1HW PazjZU8PjEVRaSzLI2C6o/JmJNdUg3gU4Sit+qRsn1CA+wcftE80f/GnihcKVFQKztI8Rckj 9Kp/WJlfSQbSz2xUT5uiZ6OLtH9yKCTdmpCAyBXc5O/NrSAyXBvoKapOqyhizwUz21dgAxgp BEb1UZaoB7sQYZ5bdHmhSae+jQuUIqk1xX/DFhmBrM4+GdkRnmNHADFxbYjJVQVSRUKV6Sg6 3+gLCl6Eg= X-IronPort-AV: E=Sophos;i="5.81,240,1610427600"; d="scan'208";a="39047544" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q1JDlfKQKB4mlN8KQhgYqyEu1gH95LECbqtUdygJRWaUlQ/TgYVE+RNKp7JidJsD1wnRgjC4DIuzaDiJAwb+eeuK77xeh+0N1jcQnO5UzVVjApMDrQn08cbR5w+Lffk2XDvmOfRT8+TWW1gadW4gjJZX+wD+B02rrMttjnYSnBfjCkGJv0FrygjrPkM2q1byW8SdZ3+jTKrcEKDKA21swX34YD5buuOnrEQ6WFZ4b0cgDZ9keEstORfizsVeUfwBR24a7rsRHe28OPrLNRdQOr4AuSlmqw5RK3u6qiq4zu3dwgcg3p54RCMzeK+Xnogy+gleaNLrYDnNG6DgrmGsxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=px5mo/EHB1WU3sUDzgONHAk9I9kK+yXGOFgRCDuZoSg=; b=LYqkKPcXU03hJF0Dl2yYCmQByrGSJyzgrRjMyklQGA6N8oFst/LND2B76LdFmKKBT5YzfgRScFzFs7GS1OwCIK9pg3NRwolPLhwQ0cgy9XyrDvxYc4y/Aelym11H54dNmIpKUS4V39s5hsZIwyvuckC5Vzn/01vyJajZ/TKIUAnqNbq9TqyOWlE/V4QCt+voxMNI84cRziTtRoBw6aGhDgyU2xpokBDyalwEuTXQjyLPOSoXGCAFreF3m+lQqH3JKn/EkLyiB72+fa51lWV07rmT5A0/lvIn6iKOac3Sf5W3b6oLa1pWxFvfi56cqXIgTWPDtHgMmht4O5mkCvsECA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=px5mo/EHB1WU3sUDzgONHAk9I9kK+yXGOFgRCDuZoSg=; b=RoO5JMsQEBrSOo1s3UTuLnAgHi6wjtUZ+whPmBTbBpepiDqn++y9W+5ZmnNwNCPOlwYPoIdMKCQiSZHHfr6avzeSkFTaLN5dg6wlGOIHtBoSmPfY8YgV+YaTw0DyQ7i+AJIsAJ2OSnxnFkZklhZGHszqTzmtWHxz4vSYWuajQsc= Subject: Re: Ping [PATCH for-4.15 0/3] tools/libs: Multiple fixes to header handling To: Xen-devel CC: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Juergen Gross , Ian Jackson References: <20210305124949.6719-1-andrew.cooper3@citrix.com> From: Andrew Cooper Message-ID: Date: Thu, 11 Mar 2021 13:28:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210305124949.6719-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0083.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::16) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5a79725-7c0f-4165-b38f-08d8e4919511 X-MS-TrafficTypeDiagnostic: BN3PR03MB2275: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:324; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 23cxN0Xq3y9PJgG3flZKjvVOwOkxCPQWrSOgFr9IMxnd9Pt/dic7qQ4X36U78ver3be+2BfgKRCb3jJs5qFPtaUmvHmPHwR0lvNaEselCb5x3OQFJMlUok2Cw2qFa2c58zXIjdT0Y5i8wVeyWLG37NvPqkoqxJ2UB292E/U/2kVsxES3jjIWsxOpYp7KMnvW1CXPMM58rxmZoGPj+3VoU7Ka32VAssN9YxeofkvgPg9CH/HqOfHDM363sYI7rRWaWYhBjl9wJx4GM4Kz8G1Po17KnSlNLOER4VfLUry/V5jYs3kpMVKjcZWQkhM/5h+0PYBJNNukdlhZ4l2mvkEGX8a9v46uKmHgXVCeHiflQ/E3SnpFriDT4Q4O7m6fSDUPop5IvYvWhhu5sZiq73kT+3dCCco7nSzIhvBBUE4eADhz77SfNIPHeB/SqpQ33neDzsa0aqbWOc37mYtfCnTtgiDM7hfDWdep+oveUdIYgoNWB/O5qJ4dWwkYKBo99fiOImMkSkciQ5PT4LSjSeBopihJiLKFCNmllTKQeSmr4h0G2jN5UbJCjeASK58B69EYJDRh4VfQ5vDc/SctAOSdgukcoi/DuOL4v5zLXDZIvGA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(39850400004)(376002)(346002)(396003)(8676002)(316002)(478600001)(16576012)(6666004)(4326008)(66946007)(53546011)(66476007)(2906002)(6486002)(66556008)(6916009)(8936002)(26005)(16526019)(36756003)(5660300002)(2616005)(956004)(186003)(31686004)(31696002)(86362001)(54906003)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MzJsY05IMi9lbUlCSHZrWkhPVzNYbjBXZUF4SHJ1MUwzQVVVN3NLb2hCV2c1?= =?utf-8?B?STJuYzhUZ3RPZUhYU3kzOExvdkhUYTVzemFialY0MU5NSSt5Zzlab1hPWllo?= =?utf-8?B?N0pETkNYMU90d3FGdFBUYVhSREpxYnkxMkN2OEt1c0d4NXZqYldmcEp1RS9P?= =?utf-8?B?RmY0aWRXY0FTVU9tTnczRHVlcVpjczFzZEtQM2RpNGErWTJkZWdsc01VVEtC?= =?utf-8?B?dFZ2T1I5eW1YaDI0aUZwS1E4SzhuZ3lQWGcyUUNweHoxK1F0Zyt3N0NxcU1J?= =?utf-8?B?dUlJcWh2UEJkemc0dmdpZTR4RWkzQkMxLzBLdVo1bzRvK0lib1hydkF4NnAv?= =?utf-8?B?T2xwZjAxMUUzbG9tRFFEYTRiUHg1ZG1VU2RBVkhScTZ3ZkdaV3dsRytQZVBn?= =?utf-8?B?bUdTcFZQWlc2S2dYaUpwMEM5UWQ0QWJaYWJJTHNSSzUxVVBOSWcwejdtNE4z?= =?utf-8?B?elVLN0dCQ3JoL1hzVk5lTTBPWnFaN1p5UXB2azJGZzZsd0pyajdISGtIa3ps?= =?utf-8?B?UnZsTC9nWDNzK2c2SDFFSFJvb3FBbEZWK3ZZamZYOTh2Y2M2UkVvSkZyQmpE?= =?utf-8?B?amFadzJXVVltMVdWZUVMT2hjc2xtMW1VekxXNng1emlNVnI0cG9JM0hOUUVm?= =?utf-8?B?ZEdDd3dBT3pjZFlNMlA3OW1Zd3hmUDB0WldvY0JrYU9LRVowc1pJWVg0VUhH?= =?utf-8?B?WHZCcjBBVlI3MC8wODA4N0k5Z0U1eUVQdFFJbmJhVXRBNW8zeE1ac1F0ZFJw?= =?utf-8?B?UGdmU1daRU43WjBvY1FLUEpkbTZJQXp3SFpJbllXdTlnclgwd2xRbmd6YVVn?= =?utf-8?B?UENNUzFmQk5ITFpOcm5qeTBIQjk4aThPQkU1Qmx1VjRVTVpReDZBVjh6ZHl4?= =?utf-8?B?SzNrMm14cUN2NE5DVEdwUERsMDNtQ0xsMEY4Umk0akpJR1pSS3dxSit1VWFJ?= =?utf-8?B?cXhOa0NLaGtVUlpENWZMb2U3OEVRcmJXK3VFc3RUTURlVkN2a0F3Znd6ZzRi?= =?utf-8?B?WUNpTi8rTnlrMVRPclR0TGxCY1dXaFUwSHcvVWpzNVBLUjdycWlTdTVScGEv?= =?utf-8?B?V3c0ZnRqSlNuQlBMeWRRTVlLMkJGTlQwUUx3QVlrNW1Tb2NVKzZTSHF3OG9z?= =?utf-8?B?ckVEQkRWalNmSlZWelhVK1pleHlTYUhCMTh2b2tzL3k0T3BUTURvZ0VEajRT?= =?utf-8?B?aDRWaXZBNnc5Y3IxK0o3dDRQZjREaHFpQ01Dd2tVYXNNeHJDYTZLTVl3UTBR?= =?utf-8?B?cGhGaDdyTW1aWUtsVkdlVHk2NFVDRHJ5Vkh5Q2dkTjlXNVhneDZKRDBEeW1V?= =?utf-8?B?ZVlKa1JOQXp1NTU2aU5IQTJ0aFJiUm51eU5XUG9YNEh5bFFjYWIwbDRnUmxq?= =?utf-8?B?N1ZwbS9JUE5zOHNrVnVkQTExNnU0ekxnYUFNbmlFMnpBaTArYkViQ2s3TzlI?= =?utf-8?B?cU00OG9PYURUd2pQRWxQUnNIVFQxS25CSDhlaUQrY01Oa2s0NENRTnFiN3pz?= =?utf-8?B?N0tzSzJ6cllIdWxXcWE2QTZ5QklPR0haN291SStGNUZHeFpDWGtiY3dVbkdo?= =?utf-8?B?dWhhS25hZG9sYU14THFLRXdIclVlNFl6dzRWUVdTRFA3SDRxOG45K2VuRXVT?= =?utf-8?B?MC9SYkk4REJDNXk2bzdsczltYkVmdDVUdTg3T0RQcFNxUzBhL0grd3B4RndX?= =?utf-8?B?T05wT1RkRFltMHgvV2NMc3kzditVUzl3WXEzc20zQWtqSzU3MlhiTlBuNm5P?= =?utf-8?Q?5rTj1m/gpGC+8XEHGMHujDF4qagHuID4xDT2het?= X-MS-Exchange-CrossTenant-Network-Message-Id: c5a79725-7c0f-4165-b38f-08d8e4919511 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 13:28:40.4765 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dj8ZFdCKX4lo9qZWe1zJlr8eoM0HD94GUPguq1q2qnTAc3vhtvo8D5+1KuXR6hZrXukBn0k908dsSM1Cng0v1UJGfr8qBPJFBkHNTxri1oU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2275 X-OriginatorOrg: citrix.com On 05/03/2021 12:49, Andrew Cooper wrote: > This can of worms is festering. See patch 1 for yet more issues. > > Andrew Cooper (3): > tools/libxentoolcore: Fill in LIBHEADERS > xen/dmop: Strip __XEN_TOOLS__ header guard from public API > tools/libs: Fix headers.chk logic Ping for acks/otherwise on patches 1 and 3?  (They're already R-A'd) Given their simplicity, as well as being regression fixes for build-time checks, I'll commit them tomorrow unless any objections are raised. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Mar 11 13:32:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 13:32:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96547.182730 (Exim 4.92) (envelope-from ) id 1lKLQH-0006TW-Oy; Thu, 11 Mar 2021 13:32:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96547.182730; Thu, 11 Mar 2021 13:32:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLQH-0006TP-KL; Thu, 11 Mar 2021 13:32:17 +0000 Received: by outflank-mailman (input) for mailman id 96547; Thu, 11 Mar 2021 13:32:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLQG-0006TK-0Z for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 13:32:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLQE-0005rd-RB; Thu, 11 Mar 2021 13:32:14 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lKLQE-0007RJ-DV; Thu, 11 Mar 2021 13:32:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=n/LQpqoy4C4w5B+MWBr5BKaGMB9F5rNVWjpj/3h6e00=; b=C855MiaE1S8aMOJ/qlIcv4CrWc 6zFjdT1S8lWmozjNuV1v18Wv9GNPqHBvWUmTU9vEDGg5wH+dlu/bzC+s9Mo5clO+1wmvwsuwfpynS o4fpQ9qvadMi0dRExTuXq2RztNPwBDNRyYhkZUKR/5MdwkxWBqsYo4OZllYgRLTvq56Y=; Subject: Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Jan Beulich , Michal Orzel Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210310065803.348-1-michal.orzel@arm.com> <3d3e5573-6d64-98cd-1f6f-897eb860d8ba@xen.org> <16f39b33-2e26-1a4b-5415-02cd14edaf24@arm.com> <54c7a952-cc17-8ab5-1aec-d1bd2453d1a1@arm.com> From: Julien Grall Message-ID: <91b18be5-e5f8-9d32-ddf7-ed0c30068e54@xen.org> Date: Thu, 11 Mar 2021 13:32:12 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi, On 11/03/2021 13:10, Jan Beulich wrote: > On 11.03.2021 13:39, Michal Orzel wrote: >> On 11.03.2021 12:11, Julien Grall wrote: >>> On 11/03/2021 10:41, Michal Orzel wrote: >>>> On 11.03.2021 11:34, Julien Grall wrote: >>>>> On 10/03/2021 06:58, Michal Orzel wrote: >>>>>> Currently in order to link existing DTB into Xen image >>>>>> we need to either specify option CONFIG_DTB_FILE on the >>>>>> command line or manually add it into .config. >>>>>> Add Kconfig entry: CONFIG_DTB_FILE to be able to >>>>>> provide the path to DTB we want to embed into Xen image. >>>>>> If no path provided - the dtb will not be embedded. >>>>>> >>>>>> Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>>>> as it is not needed since Kconfig will define it in a header >>>>>> with all the other config options. >>>>>> >>>>>> Signed-off-by: Michal Orzel >>>>>> --- >>>>>>    xen/arch/arm/Makefile | 5 ++--- >>>>>>    xen/common/Kconfig    | 8 ++++++++ >>>>>>    2 files changed, 10 insertions(+), 3 deletions(-) >>>>>> >>>>>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile >>>>>> index 16e6523e2c..46e6a95fec 100644 >>>>>> --- a/xen/arch/arm/Makefile >>>>>> +++ b/xen/arch/arm/Makefile >>>>>> @@ -68,9 +68,8 @@ extra-y += $(TARGET_SUBARCH)/head.o >>>>>>      #obj-bin-y += ....o >>>>>>    -ifdef CONFIG_DTB_FILE >>>>>> +ifneq ($(CONFIG_DTB_FILE),"") >>>>>>    obj-y += dtb.o >>>>>> -AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>>>>    endif >>>>>>      ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) >>>>>> @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >>>>>>    xen.lds: xen.lds.S >>>>>>        $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >>>>>>    -dtb.o: $(CONFIG_DTB_FILE) >>>>>> +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) >>>>>>      .PHONY: clean >>>>>>    clean:: >>>>>> diff --git a/xen/common/Kconfig b/xen/common/Kconfig >>>>>> index eb953d171e..a27836bf47 100644 >>>>>> --- a/xen/common/Kconfig >>>>>> +++ b/xen/common/Kconfig >>>>>> @@ -400,6 +400,14 @@ config DOM0_MEM >>>>>>            Leave empty if you are not sure what to specify. >>>>>>    +config DTB_FILE >>>>>> +    string "Absolute path to device tree blob" >>>>>> +    depends on HAS_DEVICE_TREE >>>>>> +    ---help--- >>>>>> +      When using a bootloader that has no device tree support or when there >>>>>> +      is no bootloader at all, use this option to specify the absolute path >>>>>> +      to a device tree that will be linked directly inside Xen binary. >>>>> >>>>> With this approach, CONFIG_DTB_FILE will always be defined. This means that Xen will always be compiled to use the "embedded" DTB. When the string is "", it will be garbagge. >>>>> >>>>> So I think we need a second config to that indicates whether the string is empty or not. >>>>> >>>>> Interestingly, your first version of patch didn't expose the problem because CONFIG_DTB_FILE would not be defined if the CONFIG_LINK_DTB is not selected. Although, it would still happily build if CONFIG_DTB_FILE is "". >>>>> >>>>> Cheers, >>>>> >>>> I do not agrree. We do not need another config. >>> >>> Did you test that Xen will still boot if the string is empty? >>> >>>> If string is empty - the dtb.o will not be created and there will be no dtb section in xen binary. >>> >>> The dtb.o will not be created but the section will because the linker use #ifdef CONFIG_DTB_FILE: >>> >>> 42sh> grep CONFIG_DTB .config >>> CONFIG_DTB_FILE="" >>> 42sh> nm xen-syms | grep _sdtb >>> 00000000003560f8 B _sdtb >>> >>> And to show this is going to be used: >>> >>> 42sh> git diff >>> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S >>> index 5d44667bd89d..2b680b8226d2 100644 >>> --- a/xen/arch/arm/arm64/head.S >>> +++ b/xen/arch/arm/arm64/head.S >>> @@ -297,6 +297,7 @@ real_start_efi: >>> >>>          /* Using the DTB in the .dtb section? */ >>>  #ifdef CONFIG_DTB_FILE >>> +        e >>>          load_paddr x21, _sdtb >>>  #endif >>> >>> 42hs> make >>> [...] >>>   CC      arm64/head.o >>> arm64/head.S: Assembler messages: >>> arm64/head.S:300: Error: unknown mnemonic `e' -- `e' >>> /home/ANT.AMAZON.COM/jgrall/works/oss/xen/xen/Rules.mk:204: recipe for target 'arm64/head.o' failed >>> >>> So _sdtb is going to always be used... >>> >>> Cheers, >>> >> >> Yes you are right. So I could add another config like: >> config DTB_VALID >> def_bool y if DTB_FILE != "" >> and change all the lines containing: >> #ifdef CONFIG_DTB_FILE >> to >> #ifdef CONFIG_DTB_VALID > > I'm sorry to jump in again, but I still think a 2nd Kconfig setting > is not needed. I count three uses of CONFIG_DTB_VALID outside of > make files. The ones in .S can be replaced by using assembler > directives .ifeqs / .ifneqs. And the one in xen.lds.S looks to be > unnecessary altogether: If there's no input .dtb section, the > linker wouldn't allocate an output one anyway. And the _sdtb symbol, > if you want to avoid its creation when there's no reference, could > be wrapped in PROVIDE(). (I also think that symbol should be > defined inside the section definition, not ahead of it.) I don't particularly care of the approach used so long it doesn't break existing setup and doesn't end up to define _sdtb. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 11 13:37:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 13:37:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96550.182741 (Exim 4.92) (envelope-from ) id 1lKLVQ-0006eC-Ax; Thu, 11 Mar 2021 13:37:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96550.182741; Thu, 11 Mar 2021 13:37:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLVQ-0006e5-7x; Thu, 11 Mar 2021 13:37:36 +0000 Received: by outflank-mailman (input) for mailman id 96550; Thu, 11 Mar 2021 13:37:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLVP-0006e0-46 for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 13:37:35 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a6bf0b1d-1971-471b-806e-685a6e004402; Thu, 11 Mar 2021 13:37:33 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 09359AC17; Thu, 11 Mar 2021 13:37:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6bf0b1d-1971-471b-806e-685a6e004402 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615469853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0KLQXKQqv9Zejt7cx/fNB4ng/9uFC56CYjHfVcdvsQQ=; b=b+0+ymzvpXMs5MJd0jW4r7q2JzmGgai/eqE0wabCMbgUYOTC8Lo3ojcS+q9G+oByT3SXSF 5NqOTHf5wmVNO3rV46OWVEfS+yNyQwfaYmsyh0omwu+Y7Wi4rA+u7azNt41otw/UzrtiOZ UJrAMcsw9T/qRIaFyW6dHieU9GvDv1E= Subject: Re: [PATCH 1/3] tools/libxentoolcore: Fill in LIBHEADERS To: Andrew Cooper , Xen-devel Cc: Ian Jackson , Wei Liu References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-2-andrew.cooper3@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <3bb9510b-ee1a-a32e-d83c-930c43307b66@suse.com> Date: Thu, 11 Mar 2021 14:37:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210305124949.6719-2-andrew.cooper3@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iRFFa6J1gfCWdZ7RqsT1BA3ZpOm0fstMH" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iRFFa6J1gfCWdZ7RqsT1BA3ZpOm0fstMH Content-Type: multipart/mixed; boundary="jn1e4DQ2mP9xB5hK2oRsCWzL5xFqOiDPm"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Andrew Cooper , Xen-devel Cc: Ian Jackson , Wei Liu Message-ID: <3bb9510b-ee1a-a32e-d83c-930c43307b66@suse.com> Subject: Re: [PATCH 1/3] tools/libxentoolcore: Fill in LIBHEADERS References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-2-andrew.cooper3@citrix.com> In-Reply-To: <20210305124949.6719-2-andrew.cooper3@citrix.com> --jn1e4DQ2mP9xB5hK2oRsCWzL5xFqOiDPm Content-Type: multipart/mixed; boundary="------------C1B7C7D690FA6377BCD365F3" Content-Language: en-US This is a multi-part message in MIME format. --------------C1B7C7D690FA6377BCD365F3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 05.03.21 13:49, Andrew Cooper wrote: > c/s 4664034cd replaced a glob over include/*.h with an expectation that= > LIBHEADER was suitably set for libraries which didn't have a single, > consistently named, header file. >=20 > This wasn't true for xentoolcore, which lost xentoolcore_internal.h as = a > consequence, and failed an API/ABI check vs 4.14 >=20 > Fixes: 4664034cd ("tools/libs: move official headers to common director= y") > Signed-off-by: Andrew Cooper Reviewed-by: Juergen Gross Juergen --------------C1B7C7D690FA6377BCD365F3 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------C1B7C7D690FA6377BCD365F3-- --jn1e4DQ2mP9xB5hK2oRsCWzL5xFqOiDPm-- --iRFFa6J1gfCWdZ7RqsT1BA3ZpOm0fstMH Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBKHRwFAwAAAAAACgkQsN6d1ii/Ey9u 3ggAiX+RJcwZMWEsr28ZO3fB+6c42skNTznE7pUvO+GKGshCsbpnT+MLk16yL7Rl6rnRXqI2ZJRD TvrtpymGPyqK93+/YuVUT8syCOlKJzJM8djbKJS/83Ex7qqupdnZpZ0NMd5c0BNzNyJijyx3V0ad wqsK59KAQe+PqJ1ReqSAj3m8h9z7H29z8Sv/U0CCsRZseBv01yA1NZRMbXKIa4EJyUloxyU5tIiA EGOIXdDDZmx0lWLC2oLRS+ie7h0nfP6ZAVjhYNt7qvEpVqmUKn6PFnLSmVwYqxsc4+Lan4fpLFwN +hdc0JMKwLzDm9+4dMBSYAEcnYGK4H7MfgNKJikY7A== =RB09 -----END PGP SIGNATURE----- --iRFFa6J1gfCWdZ7RqsT1BA3ZpOm0fstMH-- From xen-devel-bounces@lists.xenproject.org Thu Mar 11 13:38:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 13:38:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96552.182754 (Exim 4.92) (envelope-from ) id 1lKLW0-0006r1-K2; Thu, 11 Mar 2021 13:38:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96552.182754; Thu, 11 Mar 2021 13:38:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLW0-0006qu-Gn; Thu, 11 Mar 2021 13:38:12 +0000 Received: by outflank-mailman (input) for mailman id 96552; Thu, 11 Mar 2021 13:38:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLVz-0006qn-9z for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 13:38:11 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 338ec76e-08f7-4edf-8917-a61a4152766f; Thu, 11 Mar 2021 13:38:09 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 72DAFAC17; Thu, 11 Mar 2021 13:38:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 338ec76e-08f7-4edf-8917-a61a4152766f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615469888; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zoXWpXvbgsoCZyAf0Pl7hjgIAzIqV8WWo25I27t7L0E=; b=eQpG7QDqZYN4Wrq8qthRQID+tqt4k5KaTQ7rKIyG6kR9dusC61wB9fYQXvmIDNUvbK7aGt xeBWF0JdIY4GqMfah7EK3/EyJZV8XJabP1f9VIzyezjLpDtz/k4vi996pw+8HshziPBZIV 6Ykxa14haa63rC2YwM6He4Bb3lv2mCI= Subject: Re: [PATCH 3/3] tools/libs: Fix headers.chk logic To: Andrew Cooper , Xen-devel Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-4-andrew.cooper3@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <21556d11-03e4-a243-3e48-7592f64fa9c7@suse.com> Date: Thu, 11 Mar 2021 14:38:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210305124949.6719-4-andrew.cooper3@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aImywZeZRWpBC3vgjDRfR4IXizNWJIvYe" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aImywZeZRWpBC3vgjDRfR4IXizNWJIvYe Content-Type: multipart/mixed; boundary="gf52iPVPBQ6RoCZdqmPJJnEVAKmZTiVsY"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Andrew Cooper , Xen-devel Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu Message-ID: <21556d11-03e4-a243-3e48-7592f64fa9c7@suse.com> Subject: Re: [PATCH 3/3] tools/libs: Fix headers.chk logic References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-4-andrew.cooper3@citrix.com> In-Reply-To: <20210305124949.6719-4-andrew.cooper3@citrix.com> --gf52iPVPBQ6RoCZdqmPJJnEVAKmZTiVsY Content-Type: multipart/mixed; boundary="------------3C26315CC66BA85E302105AB" Content-Language: en-US This is a multi-part message in MIME format. --------------3C26315CC66BA85E302105AB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 05.03.21 13:49, Andrew Cooper wrote: > c/s 4664034cd dropped the $(LIBHEADERSGLOB) dependency for the headers.= chk > rule, without replacing it. >=20 > As headers.chk uses $^, a typical build looks like: >=20 > andrewcoop@andrewcoop:/local/xen.git$ make -C tools/libs/devicemodel= / > make: Entering directory '/local/xen.git/tools/libs/devicemodel' > for i in ; do \ > gcc -x c -ansi -Wall -Werror > -I/local/xen.git/tools/libs/devicemodel/../../../tools/include \= > -S -o /dev/null $i || exit 1; \ > echo $i; \ > done >headers.chk.new > mv headers.chk.new headers.chk >=20 > i.e. with an empty for loop, and checking only the $(AUTOINCS). >=20 > Reinsert a $(LIBHEADERS) dependency. >=20 > Fixes: 4664034cd ("tools/libs: move official headers to common director= y") > Signed-off-by: Andrew Cooper Reviewed-by: Juergen Gross Juergen --------------3C26315CC66BA85E302105AB Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------3C26315CC66BA85E302105AB-- --gf52iPVPBQ6RoCZdqmPJJnEVAKmZTiVsY-- --aImywZeZRWpBC3vgjDRfR4IXizNWJIvYe Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBKHT8FAwAAAAAACgkQsN6d1ii/Ey9z Igf8Dbg5TO35s3xDOXtA4w3SwIHiziGVhwurQvfpwJhbXLPfYjl+oDqzpqBhdnZmGIZedncm47g5 yMrKkM0xpcGwMkXe9rsPYtg3zASfFa+0HKV0b6Dd5JHACM443oqY5efBVVKTl2M64Ojjh3D/iUmQ MBYrJzVjQBKHySRdo9NMmXWHwsDtpszTw4NOqUsjhCKT8krrdNf1z+dbMqV+0ljSvEQF5JzOF6+t FJhU64sIsa62IgFcQpQbJ5djW9K1/MjjMRS4Cxea50/AS8FjYoK8NifWwhvSya0Ma8rDEW4e5ZhF nBTD/zLIUeCCGaOsKCQfylYsa/wev5wlaiydmiNMDg== =7bn1 -----END PGP SIGNATURE----- --aImywZeZRWpBC3vgjDRfR4IXizNWJIvYe-- From xen-devel-bounces@lists.xenproject.org Thu Mar 11 13:43:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 13:43:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96556.182765 (Exim 4.92) (envelope-from ) id 1lKLb9-0007kC-7p; Thu, 11 Mar 2021 13:43:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96556.182765; Thu, 11 Mar 2021 13:43:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLb9-0007k5-4r; Thu, 11 Mar 2021 13:43:31 +0000 Received: by outflank-mailman (input) for mailman id 96556; Thu, 11 Mar 2021 13:43:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKLb7-0007k0-Tt for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 13:43:29 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a15c02fc-7f36-41ce-b986-1f680e50260a; Thu, 11 Mar 2021 13:43:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a15c02fc-7f36-41ce-b986-1f680e50260a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615470208; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=CsIkHXPoOGSxp7/5w/kygfKmQ1VAFN1rV9r/PpKO+Ts=; b=UoY5mNjV9zl6lbojqHNY+nPs78yRldcViWgeM57uokviUTafaugN38Ou 2PfntXnqkOXPjW4MXxQR3+58BHKdEyLwlztlJBKWiWZze3J2jjEh00o9E CyhvlLs6cnWJGpIdtpyBVSXOElE2xwRMQ8POrzEVVLVieuqww7gnlG62R 4=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: TNyQV1SFqRtu6AZxxmdfAwKcyaF+OX2pENIvRJwwViuQMIHBSBvLttCdfrF0aFdCxzbkWwa8to E3ksIDMbhayIGCOPcEWb5sjt4Bg2v33vHxl1AlWUW3O6Fprfq68mE9VnZ9hf0zx2Ae1GmgvNRm I6wv5crph4G/xc9i9fLx6wCpFTAY0BXQZd+0lSZedtcyKdqjrPjqq6p0Ae1ut0U43FIMsbsh1d 2kPnyd9ozxeyyaXsG/qm6ePj5TWyA1gHXb/i8j+SVjGFBpNC6kQ/2Nkvx6JIopBv38aCyp6E73 FNk= X-SBRS: 5.2 X-MesageID: 39048749 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:JySPvKF4m8ickNv6pLqEcseALOonbusQ8zAX/mp2TgFYddHdqt unm+4V2QSxpDEaXnwhnt7oAtjjfVr385lp7Y4NeYqzRQWOghrKEKhOz6vHhwfhFSr36/JH2c 5bGJRWJdXsATFB7PrSzxK/F78br+Wv1ICNqaPgw2x2TQdsApsN0y5cBhyAGkN7AClqbKBJca a03cZMqzq+dXl/VK3SbBQ4dtLerN7Gno+OW347LiMggTPhsRqYrJjgExaZ2R8aeyhVwagr9F XElwCR3NTGj82G X-IronPort-AV: E=Sophos;i="5.81,240,1610427600"; d="scan'208";a="39048749" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EiBlT+P2omx2KzxpyHvl2NYDY7MlP+cIXCKvhAK0UxRvEI4KI40B3eJVvAEiV7hou8GL+kGri8Dp2zaUbzSB2lXFjVyh5RgiU6beOYUL90VIbGX7SMuoWqVhdmb9kdMq2d+NGy1cThm5bgVUmIstkDrW78NO6NbyKE8bjXcIZlsQdTo5Ev7fjtg33NdOF89FWREmffhmZeCcQh7p8C6czL7V61KY2SWz8TVQk7dhPH+/ChhUuDPjo8c2TWeB6lCBPJnP3mZrQ28eWYmyQ+kMytbSDv/47Un0OeIIhCs7QAgU0P0lwfua0lEfowUDiKKli0gOSSLc71ihPlpxqE9+HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CsIkHXPoOGSxp7/5w/kygfKmQ1VAFN1rV9r/PpKO+Ts=; b=jO4g79V+qSzZewqodRyFK9YTcMx555AU48O2Y/96T3c5hDFxnXHTJYirYTWUItOc2ga1A9Cd9SwWUfhdwP9/qlE6l44DtKETf7hDAgNGOioCsJP0L8RQGHUTXTHXMPBBv8Jqwrng6ZEMn5ta9WTgrEv3sKC/5E4YJiHtdxC0uLda/1HIiDz4JY1uME+cfW2BD9ieHEh6G1Fb0waqcNO7yQgkRmgDB4WAbZY+Q6W5JYPFfPFmNyxR6/6peZW9QI30DXX/7PWDbTe4LqFjzewZ4Qr+9Mp+pkkKlhY8LUI6MiOyeKph/+3dthcrM+gIUowke1p7HwbYjyoGBJ/S0/9n2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CsIkHXPoOGSxp7/5w/kygfKmQ1VAFN1rV9r/PpKO+Ts=; b=TazFNiCE9oEygGyANtVAU8jq2veuvjSaN5RvqJ0wXL9aCw8X5lbmDBwG2Z5OPcDU6P01z15FbfNHIjPV6VFmm9rjmUh9aSz+sCszA2ILu+W5gxUjjr6SGSiE3Z0QcumYcDwoxnLuZ6KTKIVL/3AQLHUjgKvNFX/5rOmvF1amOmw= To: Jan Beulich CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , Xen-devel , Juergen Gross , Paul Durrant References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> <556ce32b-5087-b8b1-432e-643218dd8c6e@suse.com> <9ca069ab-8b6c-c8f1-d68b-4a9bb0cf5c56@citrix.com> <62b79d56-2438-23ab-49c0-a8c4b290c4f7@citrix.com> <9a248354-f68b-8cba-f18c-f4a26473f9bf@suse.com> From: Andrew Cooper Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API Message-ID: <586f5bcc-9d96-dc37-2aa1-aed0bf11117c@citrix.com> Date: Thu, 11 Mar 2021 13:43:05 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <9a248354-f68b-8cba-f18c-f4a26473f9bf@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0078.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::18) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: da0346a4-cf55-4de9-34ed-08d8e4939e8b X-MS-TrafficTypeDiagnostic: BN7PR03MB4513: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fc8Y7yQmRXAdUe3WrMaLJmlPR0bFk/XEVIUI+evCBntCpeccCisVC0jBlnfFKgOv2K7cuDHn/nNNRJck3l1bMzOPCpPRxADloK2uKnKDOv6kAQglhSIp+IpUTxjP0qMILtKF2kMu1Yq9mMAfu2Aml7dMEX4p6DZjZO3u0QvoNUIgwKvaChnEjZAgpdpVu+eQoCmvHjZARHVX5TF9ILWgAzODdTQQ3WMfkOG6oPg3GZbKLOGtwJW9Z/81P80CxO0tB3w09IuvmNlDEWXJdR7CX+RRRPbvQeGRqsi0WT7VL5XFqzVBN6gbOkZ/kAUHDp0F0PcEfIHWBnwRzdRAqQIC8d+jSgX39yY1necTs0AhhKyja7RuZAe9hOy+LR2mD91GsmczuS15rNlVDTA9Rdbk9fRAFhL/6EJ4Hk1zkAxJ49W5uuLo2BrF+/QTmrROJhRSGoWU+ZnKdk9cA7WMkI+9XRtfguXAZxGkvDmWsF65slB0SVzq9birlInxd0W7nrPaASZqCQGcPEXbuN7fPUaaUpagDXuVbwqcJhA9MuexOvEszTmeL8FNyeSma8zNII4pXStO2Nm6oztzGZGkZwCV5M32plj7mnRPeT/zR+3oX9PdAD/xAooljQDrupeQoqgYCRGiomKHFF11uJjgCUPrzA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(346002)(366004)(39860400002)(136003)(31686004)(2616005)(2906002)(6666004)(186003)(16526019)(26005)(6916009)(16576012)(66556008)(53546011)(54906003)(316002)(478600001)(66476007)(8936002)(956004)(83380400001)(5660300002)(86362001)(31696002)(4326008)(36756003)(8676002)(6486002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZUVSVk1ULzVzYTl5cnJocDRlZXRDTTh5TXo5a3VzbWRFMERZRnhRYURFaEgr?= =?utf-8?B?SkNZRmhEdU9Xb0NRVTZTTWx4S3l0WXlxZFQ3VnZQS3VLQitjYWFLUm1OV3Ax?= =?utf-8?B?ODVkNUhqaHhRV0xINWYydVpSVUtUWjJiQzZIc1FoUTBhbFd1ZUZiRUJ2RlZq?= =?utf-8?B?MzdFQTd5eTRRUklkTlBqK1ZEZjNKa1ZRTGdtdFJBTGFwQ1ZtcUs4NDlHOXJZ?= =?utf-8?B?VmRJbGJmdlJ1NmJPV3hnNXZlRUJTM3QzbnZCUitmM2lWL2F5KzdkTkx3U29o?= =?utf-8?B?YVVidnRyVEpLTmkrUEFIQmlhaTBFRzQ5Ry9VUmsvT0hLUHJYdzZNNGZMRitD?= =?utf-8?B?SjNTbGtURzdMZG5UYmNsUFpZN2pndGxxanR2TG5kalB5Wks3Z3pOZldxYmJt?= =?utf-8?B?NVRuLzkydHpZVjdYUDM3RTBTR3h0TTc5K1dkZ3VXMzEzZW5yNWZNUDF3K3Bt?= =?utf-8?B?WmQxNUFKOW0vRCtiOFhCVWtGWnlWMHVCUnVITUZSOGYxQ2R1YjBNRzB6dGxW?= =?utf-8?B?VEJJWFQyLzZOeVlpLzlMNkxkS3B0OUdCQm5SODBqd0xyZ0FUWUhsbER5bzgv?= =?utf-8?B?cXZCQUY1Y2xpRzlxM05tdkVaR2twTEloRjAwb2U3ckZxeTJNVXVudkVoZXM0?= =?utf-8?B?RUM0UHBpTjU3TnRRS0wxMVZKQk9wN0taTEo3bEZjWTlwUEh4Z0g1OW84MDBF?= =?utf-8?B?MXpxMmlDMUQwQVp3UXZtSmxlRVV6cWRaak9yRUtBNmdHZXg3eUxHUHpQV1B4?= =?utf-8?B?c3pTTU5NN0U2YUF4azJNN0hYa3pYTjNnY0ZPY045YXVIOTJqUFFZclhqRytE?= =?utf-8?B?YVRGekszUTZJbnl6bU5EaExyS1dvZ0puaDZyRDBCaHJDeVc4MmlCYU5obnNq?= =?utf-8?B?RVFYRllYcE1jdzJjT2Rtdk4zVktQY3g2ODJla2UzQzAvT1BWU3czVTJ3aXJr?= =?utf-8?B?amo2aUVkR2VZdEpoT0NzWGZxWkNHQUgxYlJGZHJWR3BOeElveWdsbGhWNEtL?= =?utf-8?B?WlJMRGZtczd3LzFzck9OS3U4RFFaZlZjLzd3V2k3YVFjNUNWNUVWTXpicmVP?= =?utf-8?B?TWgxRG15N2xQQWJyMXBNMlM0Zk9vZTZNZWd4ODQ4MWMrVndFeVlnT3Vad1lV?= =?utf-8?B?R3Q1YUVVaWlsRStUaFhIUXhJQ0o2d29rbjUvTGVoTFBaRGpPZ1BnZzU2aUlO?= =?utf-8?B?bVFZUWhoVHp6T3FGc05qckVJTytPS3pjZGtGM3d1ZEc2ZWw2cllUeUxsdXc2?= =?utf-8?B?bFIrdmdqQkJQT0xoUitEenB4ajhVc1VXKzBuS05DRUxLNHcxUk9VVGFWWnRD?= =?utf-8?B?Q1lEKzJJL3ZBUUI2TVZ1TlR2VVZpek53RWJGbXlGdWF2eU1PdzRNTFJITFdk?= =?utf-8?B?eGFGd2FRMlQ5VU1qQ0dsYnVSVVl6Q3RUSjFSYnBXKzFCMlJwdnlIMjhQRG9E?= =?utf-8?B?M2dwaG80dlVjR0FqeFNmYVFEYW9tYjUrQnVoY0RpUXFPUkxUNzFJMGRJVEMv?= =?utf-8?B?NGloa2cvSjZVZjV6dHV6b05qM25xMnp3SWR1QlVRVVhpSUxQUjJ4UUVXbDdz?= =?utf-8?B?UUNiVzJDcTJmL21rdUdSUmJ4bmRxcXpsZlpWRHBqMHVWR2wyVEU1d0dLRFly?= =?utf-8?B?OVB0Qk83c2RaZ3JkWkRHakJwMlVNbkNpam0yakUwYVZPZVhUTzJpcFNURzVS?= =?utf-8?B?Wm45UTR4S0hJQit3bFNkQzJjWjlzR0h2Z3BKQm9hTEx6YXhjaTNyOGR6ajkx?= =?utf-8?Q?mq9ldInYD2Zy2WsB23VVPoPIjiASWtzBmdZ86WG?= X-MS-Exchange-CrossTenant-Network-Message-Id: da0346a4-cf55-4de9-34ed-08d8e4939e8b X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 13:43:14.6452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tmsa4T8LCqo/3Zz9T+f15OGGBbcSe1tKfRgOg3dpiiSjEt9x886smvqwg1aPFluykz1n6Na6pvqf0PBL00VXnavWqbQ5SQ8DXy8/swCZFFo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4513 X-OriginatorOrg: citrix.com On 11/03/2021 13:28, Jan Beulich wrote: > On 11.03.2021 14:00, Andrew Cooper wrote: >> However, having laid things out in this way today, it occurs to me that >> we should consider further cleanup as well. >> >> I do agree that code wanting to use the libxendevicemodel.h API almost >> certainly don't want/need the dmop ABI.=C2=A0 (i.e. an individual consum= er >> will want one, or the other, but almost certainly not both together). >> >> Should libxendevicemodel.h really be including dm_op.h? > I was indeed wondering. > >> =C2=A0 AFAICT, it is >> only the ioserverid_t typedef which is API shared between the two >> contexts, and we can trivially typedef that locally. > Hmm, a local typedef isn't nice - there should be one central point. > Granted there's no risk for this to change in anywhere halfway > foreseeable future, but still. Also neither C89 nor C99 allow a > typedef to be repeated - in those versions we'd then rely on an > extension. I wonder if we're depending on that extension elsewhere.=C2=A0 As far as th= e stable libraries go, we are dependent on a Linux or BSD environment currently. Alternatively we can drop the typedef and use uint16_t instead without breaking things in practice.=C2=A0 (As long as we make the change in 4.15 a= nd we lose the wiggle room afforded us by the entire interface being behind __XEN_TOOLS__ previously). Thoughts?=C2=A0 I can't think of any ifdefary which would help, and swappin= g to uint16_t would reduce the use of an improperly namespaced identifier. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:17:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:17:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96563.182778 (Exim 4.92) (envelope-from ) id 1lKM7R-0002MS-TF; Thu, 11 Mar 2021 14:16:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96563.182778; Thu, 11 Mar 2021 14:16:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKM7R-0002ML-Q5; Thu, 11 Mar 2021 14:16:53 +0000 Received: by outflank-mailman (input) for mailman id 96563; Thu, 11 Mar 2021 14:16:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKM7Q-0002MG-Qd for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:16:52 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 19d8c1fc-763c-438c-8d8a-c55116621622; Thu, 11 Mar 2021 14:16:49 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 16D421FB; Thu, 11 Mar 2021 06:16:49 -0800 (PST) Received: from [10.57.15.166] (unknown [10.57.15.166]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 56BDB3F793; Thu, 11 Mar 2021 06:16:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19d8c1fc-763c-438c-8d8a-c55116621622 Subject: Re: [PATCH v4] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Julien Grall , Jan Beulich Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210310065803.348-1-michal.orzel@arm.com> <3d3e5573-6d64-98cd-1f6f-897eb860d8ba@xen.org> <16f39b33-2e26-1a4b-5415-02cd14edaf24@arm.com> <54c7a952-cc17-8ab5-1aec-d1bd2453d1a1@arm.com> <91b18be5-e5f8-9d32-ddf7-ed0c30068e54@xen.org> From: Michal Orzel Message-ID: <18abe7f1-39bc-dc8b-fe63-b57b3ecc5663@arm.com> Date: Thu, 11 Mar 2021 15:16:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <91b18be5-e5f8-9d32-ddf7-ed0c30068e54@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11.03.2021 14:32, Julien Grall wrote: > Hi, > > On 11/03/2021 13:10, Jan Beulich wrote: >> On 11.03.2021 13:39, Michal Orzel wrote: >>> On 11.03.2021 12:11, Julien Grall wrote: >>>> On 11/03/2021 10:41, Michal Orzel wrote: >>>>> On 11.03.2021 11:34, Julien Grall wrote: >>>>>> On 10/03/2021 06:58, Michal Orzel wrote: >>>>>>> Currently in order to link existing DTB into Xen image >>>>>>> we need to either specify option CONFIG_DTB_FILE on the >>>>>>> command line or manually add it into .config. >>>>>>> Add Kconfig entry: CONFIG_DTB_FILE to be able to >>>>>>> provide the path to DTB we want to embed into Xen image. >>>>>>> If no path provided - the dtb will not be embedded. >>>>>>> >>>>>>> Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>>>>> as it is not needed since Kconfig will define it in a header >>>>>>> with all the other config options. >>>>>>> >>>>>>> Signed-off-by: Michal Orzel >>>>>>> --- >>>>>>>     xen/arch/arm/Makefile | 5 ++--- >>>>>>>     xen/common/Kconfig    | 8 ++++++++ >>>>>>>     2 files changed, 10 insertions(+), 3 deletions(-) >>>>>>> >>>>>>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile >>>>>>> index 16e6523e2c..46e6a95fec 100644 >>>>>>> --- a/xen/arch/arm/Makefile >>>>>>> +++ b/xen/arch/arm/Makefile >>>>>>> @@ -68,9 +68,8 @@ extra-y += $(TARGET_SUBARCH)/head.o >>>>>>>       #obj-bin-y += ....o >>>>>>>     -ifdef CONFIG_DTB_FILE >>>>>>> +ifneq ($(CONFIG_DTB_FILE),"") >>>>>>>     obj-y += dtb.o >>>>>>> -AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>>>>>     endif >>>>>>>       ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) >>>>>>> @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c >>>>>>>     xen.lds: xen.lds.S >>>>>>>         $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >>>>>>>     -dtb.o: $(CONFIG_DTB_FILE) >>>>>>> +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) >>>>>>>       .PHONY: clean >>>>>>>     clean:: >>>>>>> diff --git a/xen/common/Kconfig b/xen/common/Kconfig >>>>>>> index eb953d171e..a27836bf47 100644 >>>>>>> --- a/xen/common/Kconfig >>>>>>> +++ b/xen/common/Kconfig >>>>>>> @@ -400,6 +400,14 @@ config DOM0_MEM >>>>>>>             Leave empty if you are not sure what to specify. >>>>>>>     +config DTB_FILE >>>>>>> +    string "Absolute path to device tree blob" >>>>>>> +    depends on HAS_DEVICE_TREE >>>>>>> +    ---help--- >>>>>>> +      When using a bootloader that has no device tree support or when there >>>>>>> +      is no bootloader at all, use this option to specify the absolute path >>>>>>> +      to a device tree that will be linked directly inside Xen binary. >>>>>> >>>>>> With this approach, CONFIG_DTB_FILE will always be defined. This means that Xen will always be compiled to use the "embedded" DTB. When the string is "", it will be garbagge. >>>>>> >>>>>> So I think we need a second config to that indicates whether the string is empty or not. >>>>>> >>>>>> Interestingly, your first version of patch didn't expose the problem because CONFIG_DTB_FILE would not be defined if the CONFIG_LINK_DTB is not selected. Although, it would still happily build if CONFIG_DTB_FILE is "". >>>>>> >>>>>> Cheers, >>>>>> >>>>> I do not agrree. We do not need another config. >>>> >>>> Did you test that Xen will still boot if the string is empty? >>>> >>>>> If string is empty - the dtb.o will not be created and there will be no dtb section in xen binary. >>>> >>>> The dtb.o will not be created but the section will because the linker use #ifdef CONFIG_DTB_FILE: >>>> >>>> 42sh> grep CONFIG_DTB .config >>>> CONFIG_DTB_FILE="" >>>> 42sh> nm xen-syms | grep _sdtb >>>> 00000000003560f8 B _sdtb >>>> >>>> And to show this is going to be used: >>>> >>>> 42sh> git diff >>>> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S >>>> index 5d44667bd89d..2b680b8226d2 100644 >>>> --- a/xen/arch/arm/arm64/head.S >>>> +++ b/xen/arch/arm/arm64/head.S >>>> @@ -297,6 +297,7 @@ real_start_efi: >>>> >>>>           /* Using the DTB in the .dtb section? */ >>>>   #ifdef CONFIG_DTB_FILE >>>> +        e >>>>           load_paddr x21, _sdtb >>>>   #endif >>>> >>>> 42hs> make >>>> [...] >>>>    CC      arm64/head.o >>>> arm64/head.S: Assembler messages: >>>> arm64/head.S:300: Error: unknown mnemonic `e' -- `e' >>>> /home/ANT.AMAZON.COM/jgrall/works/oss/xen/xen/Rules.mk:204: recipe for target 'arm64/head.o' failed >>>> >>>> So _sdtb is going to always be used... >>>> >>>> Cheers, >>>> >>> >>> Yes you are right. So I could add another config like: >>> config DTB_VALID >>>     def_bool y if DTB_FILE != "" >>> and change all the lines containing: >>> #ifdef CONFIG_DTB_FILE >>> to >>> #ifdef CONFIG_DTB_VALID >> >> I'm sorry to jump in again, but I still think a 2nd Kconfig setting >> is not needed. I count three uses of CONFIG_DTB_VALID outside of >> make files. The ones in .S can be replaced by using assembler >> directives .ifeqs / .ifneqs. And the one in xen.lds.S looks to be >> unnecessary altogether: If there's no input .dtb section, the >> linker wouldn't allocate an output one anyway. And the _sdtb symbol, >> if you want to avoid its creation when there's no reference, could >> be wrapped in PROVIDE(). (I also think that symbol should be >> defined inside the section definition, not ahead of it.) > > I don't particularly care of the approach used so long it doesn't break existing setup and doesn't end up to define _sdtb. > > Cheers, > I will send v5. From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:19:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:19:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96566.182790 (Exim 4.92) (envelope-from ) id 1lKM9U-0002ae-9w; Thu, 11 Mar 2021 14:19:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96566.182790; Thu, 11 Mar 2021 14:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKM9U-0002aX-6P; Thu, 11 Mar 2021 14:19:00 +0000 Received: by outflank-mailman (input) for mailman id 96566; Thu, 11 Mar 2021 14:18:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKM9S-0002aS-PR for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:18:58 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c944d42f-ea84-4e8b-9b3f-04696b20b32b; Thu, 11 Mar 2021 14:18:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c944d42f-ea84-4e8b-9b3f-04696b20b32b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615472337; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=L+RNroIQDEPik4ZuA/EtQGlCanyHfoXJJw62y+ltc2Q=; b=M6QU5H9RFJT83Inj3Vi0AUij29T1WojLo/gYOSeNDuU1CifCbTYoBR/q IlJrVpM/QSHj3XjdEf4XIZe2o+1/jGxdsjQJlUTmU39a0M0yBzQu6isku j0MngNJXsXfuR8coifp63GgLpCDiYmFCiZ5Epn7jPZINF+PETTPLDAp2c s=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: SnZPWjFIj1W4lQ1z2CmaHN7OtMa9Hf1OBwBwN8Yhj/KpTIgk7ydvzNvL6B5XXtBz21CsmGuTu4 osZKq8onbLctybl/BPYqsOBdbcy4NkIoalgARyZKzQLfnzCgtgDO4bLdttyH937g5+cEtf5peT H5r72KGE5WgtDW+NPt6yQsGYb7aUxSQao3qEFaNfTma1//6L3us5KVqddap0Wzn7zNT5GJluHe vJvsPS0y+zGI8jaWHbIDsccJE8VGYg8+qyc6dtyeoAQxvCR7e8XlxxOpEtIutFN6Tnx2a7p2h6 wnw= X-SBRS: 5.2 X-MesageID: 38968980 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:XREfDaohlEBxgh8KoA4cNGsaV5sOL9V00zAX/kB9WHVpW+STnc y2gbA/3Rj7lD4eVBgb6Km9EYOrKEm8ybde544NMbC+GCzvv2W1JI9vhLGSuwHIMSv46+JbyO NcY7FzYeeAc2RSoM7m7GCDYrMd6fad9qTAv4jj5ldrCTpncqRxqzp+YzzrdHFeYCljKd4HGI GH5sxBzgDQCEg/SsigHHEKU6ziirTw5fbbSCULDRIm9wWC5AnAgNSWfySw5RsQXyhCxr0v6w H+4mvEz5++uPK2wAK07Q/uxqlWg9fox59iA8GBm6EuW1fRozuof4hoVvm+uik0qoiUmTUXue TLyi1PA+1Dr1f9Xkzdm2qc5yDQlBIVr17r0xuxnGbqq82RfkNAN+NxwaZiNib/x2Vlltdmy6 5P13+erPNsfGn9tRW42NjSSwsvrEC9pn0vnIco5EB3QM8TebVVpYwa8FgQFJpFFiT854Aoed Mec/309bJTeVOeY2uxhBgT/PW8GnIpHhmHRUAeusualzhO9UoJs3cl+A== X-IronPort-AV: E=Sophos;i="5.81,240,1610427600"; d="scan'208";a="38968980" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pfyav6V8RenKi/rY0P9dqvFwCXh08PdSALn9Y/PQ7E/v7qcXwOPe+4MD4790aNquWw1tR5ZyOfy3b5VqFCTZ/v5ZLc5M1dZbC40c4+tyuas3p2cQkWMXf8hCzW3k7boUjKdyUKHkGLMTFm4EP3NF7K6fcuiAcLXAhzIymF+fN1np2MBfnutOe9RJD9SeZIBuQeC/G1yQXqyTOuUk5doBYA6bXHEzNUuGGsVA2Cn1drs6Aafh/DLZ2nnEqZzUFJXqQn3aFV31aXzjhcp1uZwQ/0Er2449nTTzzZ+ReSDR3w0tSz+HYIoLR/tzBVIgegc3+M8ld6yqC71Irc6MqSAQAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wZ+hrFI0aAgo8+DuTI/aKLatz8Ixaoah2LZAayXwD9Q=; b=oIFTNstPZEQe94dK+yH+4JziksxXuZHtnzespRyLVoTpgP2qROJOyffHs9OuTgeexlWiFevcjb4rmGG2cImIMesjZQDCP+hG37spe/bWcphFgABUlVbWOjSWiEJBwhukvwVgycgWqtPt/GgTLNl72LcapBeO6JRrUTvHbNUh50cJ/KMR7KecuE/RLtW7Gxbe3Zpm4+vGf2YM8lBYFo5e/sdqLS9RIrxeY1DyRrCMqwJ3zQQCtjWHQy1fOOxe+T21NsCPuUi20c8PLfwArTTzjfCH5nIO7PGHpICjqA5UxM+R1XFvz9AwxbcDK9SekzEXRbcsEjypXwg5Ajn92mf+Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wZ+hrFI0aAgo8+DuTI/aKLatz8Ixaoah2LZAayXwD9Q=; b=n9JNy4EMG7fWI4PIZ4AH4vC/UOaCe/RBkRQxDzhOG24Fs1su4UvVQ+T2xlsCx0j48Z71JeMCkPCp8nD1afgITqVTxy1WfB1UPjAivnRQ3qMQjBr8msFE99GjKJdykcFvVpRzfQjK1ISlnBZVwvm7pNFXJuLi/G8NjGmHoc4X0eg= Date: Thu, 11 Mar 2021 15:18:30 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Jan Beulich , Paul Durrant , Wei Liu , Ian Jackson , Xen-devel , Juergen Gross Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API Message-ID: References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> <556ce32b-5087-b8b1-432e-643218dd8c6e@suse.com> <9ca069ab-8b6c-c8f1-d68b-4a9bb0cf5c56@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9ca069ab-8b6c-c8f1-d68b-4a9bb0cf5c56@citrix.com> X-ClientProxiedBy: PR3P193CA0042.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:51::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fade3d81-3cb6-493d-7fc0-08d8e4988f34 X-MS-TrafficTypeDiagnostic: DM5PR03MB3145: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MvTADjTcmVaK/jXFm81Ex3cThkbLEf1J3wR7Rc8K2q/wR7oEPS5tr083WeEg8n5carR/PI5uPHpd0dQrQQWktKibf5yGUm2ON/Q7pZKppHkVhIs32bxTytwooxa/YKpC+9FT5cNv7MtAkTD1OrQkTHpT5eI9Qho2FYuTLuxJe1/aJ7SvAIRmGM53S8zQ6+RJ83ccLdMIrOH08+R51XeYP93FKDYkHaJebOMB9Bptxzpc9FQgb5mNHrJ9E11Pk3NAFgWfE298vLXOw0nrj3DHPYWxae1eBt+h8jInn4TTAgDBgRwKOxQaYs0PdoaxOhrM5OdgX47V+3BCxA0lqgwtfu1gqrsqN/VBx/IVUVnf6dJ8bfSct5WfAY9wumCe998yIGBp4RNEg1g+AogMYYtPpv8zPCQGJqjW6ZZiyXWREkHPJbStD+Fmz26TXJ54vKgM75fWcL5ra5vndQJyGtjqFqU7ohiho1xY8KkIA10GyLw2I4gPb1ZKOaKLNLGUOjE9YlfsFzoB7Bh4iukMWW0M/A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(346002)(136003)(376002)(39860400002)(396003)(83380400001)(6486002)(6636002)(66476007)(956004)(16526019)(186003)(5660300002)(8936002)(54906003)(66946007)(4744005)(6496006)(316002)(53546011)(478600001)(66556008)(2906002)(26005)(86362001)(85182001)(4326008)(6666004)(6862004)(9686003)(33716001)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MCt2QmQwUjYwLzUxQStXNlZxSXB0YUc1OGVtNWxTUXBaN0FpdGYwZWY3TEEx?= =?utf-8?B?UTZzZy81UE9veHVURkZSQ1FRT042VjZOa3ZKcnlTNTZtMHZtZFJGdHJMMnpR?= =?utf-8?B?YUNIbGdvSE13ZmRXdEFOcTYxWWJ5RWJtZXNRVENHejRNODlwNXpaUjAzeTgv?= =?utf-8?B?WHJ2bzNlL0x4OEVmM0h3aWtzbE5wdEUreFZBb2tGeVFRUHlVSkF3SjJadldi?= =?utf-8?B?VVZnRUdCcUVERkRBSFhFZWc3cXB0MnBERWRTOUx1KzVvZ0FQU0dyWmNHeUhr?= =?utf-8?B?UktweTB2WVc4S0Q5VWNmblNMbGc4VCs0aWFsdU9yOGQ2UDhjRFdab203ZmtV?= =?utf-8?B?U0xLTXN3VS9SQWlTakZiQjlWQWo1ZjI2Wmp5dmpRTFZ3eHErMEkxRUx6QmpD?= =?utf-8?B?OEhLTVFkeWs4WEhrbjZjTjBjcUExWDMzYnNJWDl4MUt4NGZKOFN6bTJUUzBk?= =?utf-8?B?QThwMlQzZm9kaS9QaG9FOGQxcFd2RzA0ZVhsbGxXeVU0S2pVMVZqbEV5L0hQ?= =?utf-8?B?NEdwcDNwUWMrRjFtbWFnWEtKcm9Db0t4VjFBSS9VdHhUWDhDV0s3alZ5Zk53?= =?utf-8?B?NU54d09naktVOXlmNHZaTG84a0tqU2dFaHovTmFOSW1QMmp6ZXJ6eHhQOFo4?= =?utf-8?B?ZG1GQmRicXVqMUZJQ2h4MjhnclIwR3RKZmduUG9NcFNuZnM3ZXZQWjVyeVcv?= =?utf-8?B?SjQ1UDlCWml3RkFZT3VVY240clR0YnNobGhqYk96WHpUd0ZtZXpGWlJUUWhZ?= =?utf-8?B?a2tGTXpJb2pYaUo1MmFnQzZidy96bzdYNnYzN3JtQlU0MDA1UXBkeW1WZUll?= =?utf-8?B?TStaenNFWGdWc1hNN0Z4TUt1ODBNb1dBSEJESjhPZ3k2WWFhUTFhUW5VMzZL?= =?utf-8?B?azhLakZxdG5ENE5vWFd2dWdSNndSWmM2YVp3eURVak16OXRLMzlHaFowbjJl?= =?utf-8?B?QWJvVFllaXd0RnVzaTM5Skdtc3UweWN0SDZzUW9obkQrSnpCMC9Sb2plNDht?= =?utf-8?B?dGdwcWpvb2ZGRFJwb2NwbHRPRTRSS05KdlZYL2xGRzltWjl5VnM3SjR0WHpv?= =?utf-8?B?ZzJkS2l3ZE9HQVdrSVhWc1FMdmxiR0NPdnZOaVRtbFNKWmJ2bHlreXFMbGpG?= =?utf-8?B?MEg1ZVpHcEdFdnU1QTF3cHpxTU1wVWhQdXFJM2swR1JERTBSNjV6ajBGdEpa?= =?utf-8?B?dG9Oa0VXY2dObEFTWTNWbjVRTkRlSnk4Ny9abWxCUkdIK2ZXWC9RNDFBSzZF?= =?utf-8?B?UmtpVkVlRXEvSTZmemxJN2laYzJDcjB1U3I3VVg3Wk92UktpS1FTWUVVNENx?= =?utf-8?B?a2ZJTkRJNFA1VkpMd3JOY2VvQVNMN2JQWGNhTjJSN042N2JUZE9KSTFUSnJY?= =?utf-8?B?cm5ZZTkyUWVSWThVSkhrOWVaK2drNnFLRkJzdFRObnk5ZVBJbytqWStkajNl?= =?utf-8?B?c3YzSkZYUnpyWXlPaVVOMTU4WFVwSmVibEQxWmpKbWtFcnBxRnQ0eXY2Z0pD?= =?utf-8?B?Ump6Y3ZZanVTaTd4VWFPOU8vaElYeHdNT1cyVXMrZWxaVi9lb0ZnVEU2a2kx?= =?utf-8?B?eDlHSEh6MjBGZTFEM3BhTjIxbzVDTC9RRjV6Szd0U2FlK2llTFFsS1d5RGVB?= =?utf-8?B?dytKMmJyQzZpN1BmTmJFVUQ3Y2dodEFQdVNyazRwKytrQWNpU0xPSmZWQXZo?= =?utf-8?B?WkpjS2pVV2RMa0NHZEl0TzJDUnJuaTlTTnM2bVZuQkVKYWgwV3IzRnVJOVZ5?= =?utf-8?Q?vUDRO43hLO11JVUNWpgw7oIQWdVLWXcd6FA1GDa?= X-MS-Exchange-CrossTenant-Network-Message-Id: fade3d81-3cb6-493d-7fc0-08d8e4988f34 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 14:18:36.2943 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P9I4DgSesbtP11t7078rVyQfIT5fGzICwVDNY43fR9nlFwn536FrZ96qRZWHfSQbJDv4dFU8IfSrQHyz56pxMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3145 X-OriginatorOrg: citrix.com On Thu, Mar 11, 2021 at 11:05:32AM +0000, Andrew Cooper wrote: > On 11/03/2021 08:27, Jan Beulich wrote: > > Depends on what __XEN_TOOLS__ really means - to guard things accessible > > to any part of the tool stack, or to guard unstable interfaces only. > > As far as I'm concerned, __XEN_TOOLS__ should always have been spelled > __XEN_UNSTABLE_ABI__. > > For better or worse, the fact that we currently do have unstable > interfaces, which aren't in an obvious namespace such as > xen/public/unstable/, means that there is some value in some form of > protection to prevent users from inadvertently using an interface which > will explode on them with a mismatched hypervisor. I think using __XEN_UNSTABLE_ABI__ would be way clearer than __XEN_TOOLS__, or even placing those in a separate directory as you mention. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:22:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:22:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96569.182802 (Exim 4.92) (envelope-from ) id 1lKMCg-0003Rg-O7; Thu, 11 Mar 2021 14:22:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96569.182802; Thu, 11 Mar 2021 14:22:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMCg-0003RZ-L1; Thu, 11 Mar 2021 14:22:18 +0000 Received: by outflank-mailman (input) for mailman id 96569; Thu, 11 Mar 2021 14:22:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMCf-0003RU-QL for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:22:17 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 7da69c1c-e585-488f-b41e-4a9634814bf5; Thu, 11 Mar 2021 14:22:15 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 823601FB; Thu, 11 Mar 2021 06:22:15 -0800 (PST) Received: from e123311-lin.arm.com (unknown [10.57.15.166]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C979A3F800; Thu, 11 Mar 2021 06:22:12 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7da69c1c-e585-488f-b41e-4a9634814bf5 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com Subject: [PATCH v5] arm: Add Kconfig entry to select CONFIG_DTB_FILE Date: Thu, 11 Mar 2021 15:22:07 +0100 Message-Id: <20210311142207.25556-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently in order to link existing DTB into Xen image we need to either specify option CONFIG_DTB_FILE on the command line or manually add it into .config. Add Kconfig entry: CONFIG_DTB_FILE to be able to provide the path to DTB we want to embed into Xen image. If no path provided - the dtb will not be embedded. Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" as it is not needed since Kconfig will define it in a header with all the other config options. Make a change in the linker script from: _sdtb = .; to: PROVIDE(_sdtb = .); to avoid creation of _sdtb if there is no reference to it. Signed-off-by: Michal Orzel --- xen/arch/arm/Makefile | 5 ++--- xen/arch/arm/arm32/head.S | 4 ++-- xen/arch/arm/arm64/head.S | 4 ++-- xen/arch/arm/xen.lds.S | 2 +- xen/common/Kconfig | 8 ++++++++ 5 files changed, 15 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 16e6523e2c..46e6a95fec 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -68,9 +68,8 @@ extra-y += $(TARGET_SUBARCH)/head.o #obj-bin-y += ....o -ifdef CONFIG_DTB_FILE +ifneq ($(CONFIG_DTB_FILE),"") obj-y += dtb.o -AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" endif ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c xen.lds: xen.lds.S $(CPP) -P $(a_flags) -MQ $@ -o $@ $< -dtb.o: $(CONFIG_DTB_FILE) +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) .PHONY: clean clean:: diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index c404fa973e..50f019ed98 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -156,10 +156,10 @@ past_zImage: sub r10, r9, r0 /* r10 := phys-offset */ /* Using the DTB in the .dtb section? */ -#ifdef CONFIG_DTB_FILE +.ifnes CONFIG_DTB_FILE,"" ldr r8, =_sdtb add r8, r10 /* r8 := paddr(DTB) */ -#endif +.endif /* Initialize the UART if earlyprintk has been enabled. */ #ifdef CONFIG_EARLY_PRINTK diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 5d44667bd8..f38a8dfca7 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -296,9 +296,9 @@ real_start_efi: sub x20, x19, x0 /* x20 := phys-offset */ /* Using the DTB in the .dtb section? */ -#ifdef CONFIG_DTB_FILE +.ifnes CONFIG_DTB_FILE,"" load_paddr x21, _sdtb -#endif +.endif /* Initialize the UART if earlyprintk has been enabled. */ #ifdef CONFIG_EARLY_PRINTK diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index 004b182acb..78af2af504 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -222,7 +222,7 @@ SECTIONS #ifdef CONFIG_DTB_FILE /* Section for the device tree blob (if any). */ - _sdtb = .; + PROVIDE(_sdtb = .); .dtb : { *(.dtb) } :text #endif diff --git a/xen/common/Kconfig b/xen/common/Kconfig index eb953d171e..71fc9e00cb 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -400,6 +400,14 @@ config DOM0_MEM Leave empty if you are not sure what to specify. +config DTB_FILE + string "Absolute path to device tree blob" + depends on HAS_DEVICE_TREE + help + When using a bootloader that has no device tree support or when there + is no bootloader at all, use this option to specify the absolute path + to a device tree that will be linked directly inside Xen binary. + config TRACEBUFFER bool "Enable tracing infrastructure" if EXPERT default y -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96572.182814 (Exim 4.92) (envelope-from ) id 1lKMDm-0003Yf-2F; Thu, 11 Mar 2021 14:23:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96572.182814; Thu, 11 Mar 2021 14:23:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDl-0003YY-VY; Thu, 11 Mar 2021 14:23:25 +0000 Received: by outflank-mailman (input) for mailman id 96572; Thu, 11 Mar 2021 14:23:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDk-0003YK-Pv for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:24 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fc97f6c3-6c4e-477e-9f5d-5db6de1dcff8; Thu, 11 Mar 2021 14:23:23 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DB495AC8C; Thu, 11 Mar 2021 14:23:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc97f6c3-6c4e-477e-9f5d-5db6de1dcff8 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lLz8EEkgsQbQc5zK5shQUpeWBQPCbxXPv1CJD4/GY5s=; b=IQ0vLS/VjrX40HoFEUQlgpmm/G1qlzafLoXcUzAz0m3i8GSx5sFZR9ulwVcPtvbf5MQb0/ RtHqUx7tOZfE8FLDs5KJJOqGu0CefWcG4SDNQ0fqCIw08DhvEYAQF8FuURxONGmk4A7xzP DeEtvr5EqmS7D6CFoATk75XwHSyDFZs= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Peter Zijlstra , Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel Subject: [PATCH v7 02/14] static_call: move struct static_call_key definition to static_call_types.h Date: Thu, 11 Mar 2021 15:23:07 +0100 Message-Id: <20210311142319.4723-3-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311142319.4723-1-jgross@suse.com> References: <20210311142319.4723-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Having the definition of static_call() in static_call_types.h makes no sense as long struct static_call_key isn't defined there, as the generic implementation of static_call() is referencing this structure. So move the definition of struct static_call_key to static_call_types.h. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V5: - new patch --- include/linux/static_call.h | 18 ------------------ include/linux/static_call_types.h | 18 ++++++++++++++++++ tools/include/linux/static_call_types.h | 18 ++++++++++++++++++ 3 files changed, 36 insertions(+), 18 deletions(-) diff --git a/include/linux/static_call.h b/include/linux/static_call.h index 85ecc789f4ff..76b881259144 100644 --- a/include/linux/static_call.h +++ b/include/linux/static_call.h @@ -128,16 +128,6 @@ struct static_call_mod { struct static_call_site *sites; }; -struct static_call_key { - void *func; - union { - /* bit 0: 0 = mods, 1 = sites */ - unsigned long type; - struct static_call_mod *mods; - struct static_call_site *sites; - }; -}; - /* For finding the key associated with a trampoline */ struct static_call_tramp_key { s32 tramp; @@ -187,10 +177,6 @@ extern long __static_call_return0(void); static inline int static_call_init(void) { return 0; } -struct static_call_key { - void *func; -}; - #define __DEFINE_STATIC_CALL(name, _func, _func_init) \ DECLARE_STATIC_CALL(name, _func); \ struct static_call_key STATIC_CALL_KEY(name) = { \ @@ -243,10 +229,6 @@ static inline long __static_call_return0(void) static inline int static_call_init(void) { return 0; } -struct static_call_key { - void *func; -}; - static inline long __static_call_return0(void) { return 0; diff --git a/include/linux/static_call_types.h b/include/linux/static_call_types.h index ae5662d368b9..5a00b8b2cf9f 100644 --- a/include/linux/static_call_types.h +++ b/include/linux/static_call_types.h @@ -58,11 +58,25 @@ struct static_call_site { __raw_static_call(name); \ }) +struct static_call_key { + void *func; + union { + /* bit 0: 0 = mods, 1 = sites */ + unsigned long type; + struct static_call_mod *mods; + struct static_call_site *sites; + }; +}; + #else /* !CONFIG_HAVE_STATIC_CALL_INLINE */ #define __STATIC_CALL_ADDRESSABLE(name) #define __static_call(name) __raw_static_call(name) +struct static_call_key { + void *func; +}; + #endif /* CONFIG_HAVE_STATIC_CALL_INLINE */ #ifdef MODULE @@ -77,6 +91,10 @@ struct static_call_site { #else +struct static_call_key { + void *func; +}; + #define static_call(name) \ ((typeof(STATIC_CALL_TRAMP(name))*)(STATIC_CALL_KEY(name).func)) diff --git a/tools/include/linux/static_call_types.h b/tools/include/linux/static_call_types.h index ae5662d368b9..5a00b8b2cf9f 100644 --- a/tools/include/linux/static_call_types.h +++ b/tools/include/linux/static_call_types.h @@ -58,11 +58,25 @@ struct static_call_site { __raw_static_call(name); \ }) +struct static_call_key { + void *func; + union { + /* bit 0: 0 = mods, 1 = sites */ + unsigned long type; + struct static_call_mod *mods; + struct static_call_site *sites; + }; +}; + #else /* !CONFIG_HAVE_STATIC_CALL_INLINE */ #define __STATIC_CALL_ADDRESSABLE(name) #define __static_call(name) __raw_static_call(name) +struct static_call_key { + void *func; +}; + #endif /* CONFIG_HAVE_STATIC_CALL_INLINE */ #ifdef MODULE @@ -77,6 +91,10 @@ struct static_call_site { #else +struct static_call_key { + void *func; +}; + #define static_call(name) \ ((typeof(STATIC_CALL_TRAMP(name))*)(STATIC_CALL_KEY(name).func)) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96573.182824 (Exim 4.92) (envelope-from ) id 1lKMDm-0003ZY-It; Thu, 11 Mar 2021 14:23:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96573.182824; Thu, 11 Mar 2021 14:23:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDm-0003ZL-Di; Thu, 11 Mar 2021 14:23:26 +0000 Received: by outflank-mailman (input) for mailman id 96573; Thu, 11 Mar 2021 14:23:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDl-0003YP-1n for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:25 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4a193490-165a-4615-bed4-c8fa15d56401; Thu, 11 Mar 2021 14:23:24 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DB47BAC23; Thu, 11 Mar 2021 14:23:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a193490-165a-4615-bed4-c8fa15d56401 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=po4QZsHAN+vzX5uvzJmshXlPCac7n69c5r9Fdn0dvCo=; b=sjqqOUQpbELgunG51bLYnaAneLdLoAHn6rXcSwK/DsFchfLZJWPal7opKb2RUZtxFSKIEo JbtKBiDJ2iWmLlE8dN17PcQJiP6NCqXX2GAZhWcMmbQgbNa+4/4kethaBp09UxMuCAjwFQ d8u620eAOSyPtbAZDTHxKFPkybBM2LQ= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, clang-built-linux@googlegroups.com Cc: Juergen Gross , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Peter Zijlstra , Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel , Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini , Nathan Chancellor , Nick Desaulniers Subject: [PATCH v7 00/14] x86: major paravirt cleanup Date: Thu, 11 Mar 2021 15:23:05 +0100 Message-Id: <20210311142319.4723-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is a major cleanup of the paravirt infrastructure aiming at eliminating all custom code patching via paravirt patching. This is achieved by using ALTERNATIVE instead, leading to the ability to give objtool access to the patched in instructions. In order to remove most of the 32-bit special handling from pvops the time related operations are switched to use static_call() instead. At the end of this series all paravirt patching has to do is to replace indirect calls with direct ones. In a further step this could be switched to static_call(), too. Changes in V7: - dropped patch 3, as already applied on tip tree - new patch 3 (patches 1 and 7 have been added to V6 late) - addressed comments by Boris Changes in V6: - switched back to "not" bit in feature value for "not feature" - other minor comments addressed Changes in V5: - patches 1-5 of V4 dropped, as already applied - new patches 1+3 - fixed patch 2 - split V4 patch 8 into patches 4+5 - use flag byte instead of negative feature bit for "not feature" Changes in V4: - fixed several build failures - removed objtool patch, as objtool patches are in tip now - added patch 1 for making usage of static_call easier - even more cleanup Changes in V3: - added patches 7 and 12 - addressed all comments Changes in V2: - added patches 5-12 Juergen Gross (14): x86/alternative: merge include files static_call: move struct static_call_key definition to static_call_types.h static_call: add function to query current function x86/paravirt: switch time pvops functions to use static_call() x86/alternative: support not-feature x86/alternative: support ALTERNATIVE_TERNARY x86/alternative: don't open code ALTERNATIVE_TERNARY() in _static_cpu_has() x86: add new features for paravirt patching x86/paravirt: remove no longer needed 32-bit pvops cruft x86/paravirt: simplify paravirt macros x86/paravirt: switch iret pvops to ALTERNATIVE x86/paravirt: add new macros PVOP_ALT* supporting pvops in ALTERNATIVEs x86/paravirt: switch functions with custom code to ALTERNATIVE x86/paravirt: have only one paravirt patch function arch/arm/include/asm/paravirt.h | 14 +- arch/arm/kernel/paravirt.c | 9 +- arch/arm64/include/asm/paravirt.h | 14 +- arch/arm64/kernel/paravirt.c | 13 +- arch/x86/Kconfig | 1 + arch/x86/entry/entry_32.S | 6 +- arch/x86/entry/entry_64.S | 2 +- arch/x86/entry/vdso/vdso32/system_call.S | 2 +- arch/x86/include/asm/alternative-asm.h | 114 ------------ arch/x86/include/asm/alternative.h | 126 +++++++++++++- arch/x86/include/asm/cpufeature.h | 41 +---- arch/x86/include/asm/cpufeatures.h | 2 + arch/x86/include/asm/irqflags.h | 7 +- arch/x86/include/asm/mshyperv.h | 2 +- arch/x86/include/asm/nospec-branch.h | 1 - arch/x86/include/asm/paravirt.h | 167 ++++++++---------- arch/x86/include/asm/paravirt_types.h | 210 +++++++++-------------- arch/x86/include/asm/smap.h | 5 +- arch/x86/kernel/Makefile | 3 +- arch/x86/kernel/alternative.c | 52 +++++- arch/x86/kernel/asm-offsets.c | 7 - arch/x86/kernel/cpu/vmware.c | 5 +- arch/x86/kernel/kvm.c | 2 +- arch/x86/kernel/kvmclock.c | 2 +- arch/x86/kernel/paravirt-spinlocks.c | 9 + arch/x86/kernel/paravirt.c | 75 ++------ arch/x86/kernel/paravirt_patch.c | 99 ----------- arch/x86/kernel/tsc.c | 3 +- arch/x86/lib/atomic64_386_32.S | 2 +- arch/x86/lib/atomic64_cx8_32.S | 2 +- arch/x86/lib/copy_page_64.S | 2 +- arch/x86/lib/copy_user_64.S | 2 +- arch/x86/lib/memcpy_64.S | 2 +- arch/x86/lib/memmove_64.S | 2 +- arch/x86/lib/memset_64.S | 2 +- arch/x86/lib/retpoline.S | 2 +- arch/x86/xen/enlighten_pv.c | 4 +- arch/x86/xen/time.c | 26 +-- drivers/xen/time.c | 3 +- include/linux/static_call.h | 26 +-- include/linux/static_call_types.h | 18 ++ tools/include/linux/static_call_types.h | 18 ++ 42 files changed, 473 insertions(+), 631 deletions(-) delete mode 100644 arch/x86/include/asm/alternative-asm.h delete mode 100644 arch/x86/kernel/paravirt_patch.c -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96574.182833 (Exim 4.92) (envelope-from ) id 1lKMDn-0003ai-25; Thu, 11 Mar 2021 14:23:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96574.182833; Thu, 11 Mar 2021 14:23:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDm-0003a2-NG; Thu, 11 Mar 2021 14:23:26 +0000 Received: by outflank-mailman (input) for mailman id 96574; Thu, 11 Mar 2021 14:23:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDl-0003YP-FS for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:25 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a5bc6b17-7e05-4e8c-962b-b42beaf96281; Thu, 11 Mar 2021 14:23:24 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F3D90AD74; Thu, 11 Mar 2021 14:23:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5bc6b17-7e05-4e8c-962b-b42beaf96281 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qh1g08GhFm6ePTkeeFW/Xy4vYX6kKi58igyTMiHJm8U=; b=WfQsdvmtX5iJzk4B1I5YaGG3Gs9euDnfi9U+jiaEOfoTQuIrA29bkaQ58hpLJAtP6YrNJd bvqAftjelQYv2S8BiBeoS4GAB4iWy+Z/dDgftaAibgQsbuhZ1c5Vo69JErGX4e05UqA+bJ e5igTzFMS+NDNRRCpaVu9taTTRtTx28= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: [PATCH v7 05/14] x86/alternative: support not-feature Date: Thu, 11 Mar 2021 15:23:10 +0100 Message-Id: <20210311142319.4723-6-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311142319.4723-1-jgross@suse.com> References: <20210311142319.4723-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for alternative patching for the case a feature is not present on the current cpu. For users of ALTERNATIVE() and friends an inverted feature is specified by applying the ALT_NOT() macro to it, e.g.: ALTERNATIVE(old, new, ALT_NOT(feature)) Signed-off-by: Juergen Gross --- V5: - split off from next patch - reworked to use flag byte (Boris Petkov) V6: - rework again to not use flag byte (Boris Petkov) V7: - minor tweaks: move defines up, comment wording (Boris Petkov) --- arch/x86/include/asm/alternative.h | 3 +++ arch/x86/kernel/alternative.c | 20 +++++++++++++++----- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h index 53f295f41c34..649e56f70889 100644 --- a/arch/x86/include/asm/alternative.h +++ b/arch/x86/include/asm/alternative.h @@ -6,6 +6,9 @@ #include #include +#define ALTINSTR_FLAG_INV (1 << 15) +#define ALT_NOT(feat) ((feat) | ALTINSTR_FLAG_INV) + #ifndef __ASSEMBLY__ #include diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index 8d778e46725d..133b549dc091 100644 --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -388,21 +388,31 @@ void __init_or_module noinline apply_alternatives(struct alt_instr *start, */ for (a = start; a < end; a++) { int insn_buff_sz = 0; + /* Mask away "NOT" flag bit for feature to test. */ + u16 feature = a->cpuid & ~ALTINSTR_FLAG_INV; instr = (u8 *)&a->instr_offset + a->instr_offset; replacement = (u8 *)&a->repl_offset + a->repl_offset; BUG_ON(a->instrlen > sizeof(insn_buff)); - BUG_ON(a->cpuid >= (NCAPINTS + NBUGINTS) * 32); - if (!boot_cpu_has(a->cpuid)) { + BUG_ON(feature >= (NCAPINTS + NBUGINTS) * 32); + + /* + * Patch if either: + * - feature is present + * - feature not present but ALTINSTR_FLAG_INV is set to mean, + * patch if feature is *NOT* present. + */ + if (!boot_cpu_has(feature) == !(a->cpuid & ALTINSTR_FLAG_INV)) { if (a->padlen > 1) optimize_nops(a, instr); continue; } - DPRINTK("feat: %d*32+%d, old: (%pS (%px) len: %d), repl: (%px, len: %d), pad: %d", - a->cpuid >> 5, - a->cpuid & 0x1f, + DPRINTK("feat: %s%d*32+%d, old: (%pS (%px) len: %d), repl: (%px, len: %d), pad: %d", + (a->cpuid & ALTINSTR_FLAG_INV) ? "!" : "", + feature >> 5, + feature & 0x1f, instr, instr, a->instrlen, replacement, a->replacementlen, a->padlen); -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96575.182850 (Exim 4.92) (envelope-from ) id 1lKMDr-0003gI-5J; Thu, 11 Mar 2021 14:23:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96575.182850; Thu, 11 Mar 2021 14:23:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDr-0003g9-0x; Thu, 11 Mar 2021 14:23:31 +0000 Received: by outflank-mailman (input) for mailman id 96575; Thu, 11 Mar 2021 14:23:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDp-0003YK-OQ for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:29 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f9b36932-40de-42df-acc1-6faa5f5b808e; Thu, 11 Mar 2021 14:23:24 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1D408AD72; Thu, 11 Mar 2021 14:23:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9b36932-40de-42df-acc1-6faa5f5b808e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rUUExa3MttAImINlrgzpHFxRG0q5LayeW3GQCnY3KsA=; b=ZAJxz53QZ7oat6o13Y5McdL+0NLo0AOUsKeLSZhrjUJm9UE7qukAPTgq1bHXLBoIrMcD+3 pmO7slOuYsC9MUCYrNLiHLu0R/fXSGRJuTK+bZttZep1uutL90lHPnmqwjUO+iVDqIgcDP Q+cCc9dkb9LQXbNvC9wls1PJDHWBLKM= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Peter Zijlstra , Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel Subject: [PATCH v7 03/14] static_call: add function to query current function Date: Thu, 11 Mar 2021 15:23:08 +0100 Message-Id: <20210311142319.4723-4-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311142319.4723-1-jgross@suse.com> References: <20210311142319.4723-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Some users of paravirtualized functions need to query which function has been specified in a pv_ops vector element. In order to be able to switch such paravirtualized functions to static_calls instead, there needs to be a function to query the function which will be called via static_call(). Signed-off-by: Juergen Gross --- V7: - new patch --- include/linux/static_call.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/include/linux/static_call.h b/include/linux/static_call.h index 76b881259144..e01b61ab86b1 100644 --- a/include/linux/static_call.h +++ b/include/linux/static_call.h @@ -20,6 +20,7 @@ * static_call(name)(args...); * static_call_cond(name)(args...); * static_call_update(name, func); + * static_call_query(name); * * Usage example: * @@ -91,6 +92,10 @@ * * which will include the required value tests to avoid NULL-pointer * dereferences. + * + * To query which function is currently set to be called, use: + * + * func = static_call_query(name); */ #include @@ -118,6 +123,8 @@ extern void arch_static_call_transform(void *site, void *tramp, void *func, bool STATIC_CALL_TRAMP_ADDR(name), func); \ }) +#define static_call_query(name) (READ_ONCE(STATIC_CALL_KEY(name).func)) + #ifdef CONFIG_HAVE_STATIC_CALL_INLINE extern int __init static_call_init(void); @@ -191,6 +198,7 @@ static inline int static_call_init(void) { return 0; } }; \ ARCH_DEFINE_STATIC_CALL_NULL_TRAMP(name) + #define static_call_cond(name) (void)__static_call(name) static inline -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96576.182859 (Exim 4.92) (envelope-from ) id 1lKMDr-0003hQ-Pe; Thu, 11 Mar 2021 14:23:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96576.182859; Thu, 11 Mar 2021 14:23:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDr-0003h4-Es; Thu, 11 Mar 2021 14:23:31 +0000 Received: by outflank-mailman (input) for mailman id 96576; Thu, 11 Mar 2021 14:23:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDq-0003YP-0q for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:30 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9b1e2756-5198-491c-adc8-52829afa8eb9; Thu, 11 Mar 2021 14:23:25 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 77C2FAE15; Thu, 11 Mar 2021 14:23:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b1e2756-5198-491c-adc8-52829afa8eb9 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S/Hw0vtaVCt5Q8AUk38dcwkbjEUX9MJeJ6rLGSeuHTY=; b=AIWlxQodTp3rSWpRjpyD2QKynNPXIqp8KJDeYNu/pIm6h4OSZ0twcrJuDUgD9CjM2FLcQJ U2cTTyE1+iKEcQwXKEoqXbFYTzra498/X7s1CDYkGRVb8Kn4ezHq2XBzYwURb2G7r3sm+S XPZPmF+zEnBBjCaewCm3iO0+UWzWjx0= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: [PATCH v7 07/14] x86/alternative: don't open code ALTERNATIVE_TERNARY() in _static_cpu_has() Date: Thu, 11 Mar 2021 15:23:12 +0100 Message-Id: <20210311142319.4723-8-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311142319.4723-1-jgross@suse.com> References: <20210311142319.4723-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit _static_cpu_has() contains a completely open coded version of ALTERNATIVE_TERNARY(). Replace that with the macro instead. Signed-off-by: Juergen Gross --- V6: - new patch V7: - moved patch earlier in series (Boris Petkov) --- arch/x86/include/asm/cpufeature.h | 41 +++++++------------------------ 1 file changed, 9 insertions(+), 32 deletions(-) diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h index 1728d4ce5730..16a51e7288d5 100644 --- a/arch/x86/include/asm/cpufeature.h +++ b/arch/x86/include/asm/cpufeature.h @@ -8,6 +8,7 @@ #include #include +#include enum cpuid_leafs { @@ -175,39 +176,15 @@ extern void clear_cpu_cap(struct cpuinfo_x86 *c, unsigned int bit); */ static __always_inline bool _static_cpu_has(u16 bit) { - asm_volatile_goto("1: jmp 6f\n" - "2:\n" - ".skip -(((5f-4f) - (2b-1b)) > 0) * " - "((5f-4f) - (2b-1b)),0x90\n" - "3:\n" - ".section .altinstructions,\"a\"\n" - " .long 1b - .\n" /* src offset */ - " .long 4f - .\n" /* repl offset */ - " .word %P[always]\n" /* always replace */ - " .byte 3b - 1b\n" /* src len */ - " .byte 5f - 4f\n" /* repl len */ - " .byte 3b - 2b\n" /* pad len */ - ".previous\n" - ".section .altinstr_replacement,\"ax\"\n" - "4: jmp %l[t_no]\n" - "5:\n" - ".previous\n" - ".section .altinstructions,\"a\"\n" - " .long 1b - .\n" /* src offset */ - " .long 0\n" /* no replacement */ - " .word %P[feature]\n" /* feature bit */ - " .byte 3b - 1b\n" /* src len */ - " .byte 0\n" /* repl len */ - " .byte 0\n" /* pad len */ - ".previous\n" - ".section .altinstr_aux,\"ax\"\n" - "6:\n" - " testb %[bitnum],%[cap_byte]\n" - " jnz %l[t_yes]\n" - " jmp %l[t_no]\n" - ".previous\n" + asm_volatile_goto( + ALTERNATIVE_TERNARY("jmp 6f", %P[feature], "", "jmp %l[t_no]") + ".section .altinstr_aux,\"ax\"\n" + "6:\n" + " testb %[bitnum],%[cap_byte]\n" + " jnz %l[t_yes]\n" + " jmp %l[t_no]\n" + ".previous\n" : : [feature] "i" (bit), - [always] "i" (X86_FEATURE_ALWAYS), [bitnum] "i" (1 << (bit & 7)), [cap_byte] "m" (((const char *)boot_cpu_data.x86_capability)[bit >> 3]) : : t_yes, t_no); -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96577.182874 (Exim 4.92) (envelope-from ) id 1lKMDv-0003nj-Tj; Thu, 11 Mar 2021 14:23:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96577.182874; Thu, 11 Mar 2021 14:23:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDv-0003nZ-PS; Thu, 11 Mar 2021 14:23:35 +0000 Received: by outflank-mailman (input) for mailman id 96577; Thu, 11 Mar 2021 14:23:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDu-0003YK-OY for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:34 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1b07e119-1515-420a-bc0b-cca4adf02d7f; Thu, 11 Mar 2021 14:23:23 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A3D33AC16; Thu, 11 Mar 2021 14:23:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b07e119-1515-420a-bc0b-cca4adf02d7f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472602; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KWeM4wbpx13GD4L4elDBN4aKGS1VmuJ7l8IaSi0wKRM=; b=LD7R9sR2C2we9Da23K+zm8HgDkKwHk9Quss/6ThGQ/pzCj0kFuxVWDUXtPvuUAmry4So57 ZY/dKHqTJgn2yg/E7shTpu3jNXedNzYOx3kUTL+Y5jKnoadBlofGIRkpJfIOkpKyzOksY0 r2bYGN62/9EJUul3dYqCbT3jOKNr+Kw= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: [PATCH v7 01/14] x86/alternative: merge include files Date: Thu, 11 Mar 2021 15:23:06 +0100 Message-Id: <20210311142319.4723-2-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311142319.4723-1-jgross@suse.com> References: <20210311142319.4723-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Merge arch/x86/include/asm/alternative-asm.h into arch/x86/include/asm/alternative.h in order to make it easier to use common definitions later. Signed-off-by: Juergen Gross --- V6: - new patch V7: - moved to begin of series (Boris Petkov) --- arch/x86/entry/entry_32.S | 2 +- arch/x86/entry/vdso/vdso32/system_call.S | 2 +- arch/x86/include/asm/alternative-asm.h | 114 ----------------------- arch/x86/include/asm/alternative.h | 112 +++++++++++++++++++++- arch/x86/include/asm/nospec-branch.h | 1 - arch/x86/include/asm/smap.h | 5 +- arch/x86/lib/atomic64_386_32.S | 2 +- arch/x86/lib/atomic64_cx8_32.S | 2 +- arch/x86/lib/copy_page_64.S | 2 +- arch/x86/lib/copy_user_64.S | 2 +- arch/x86/lib/memcpy_64.S | 2 +- arch/x86/lib/memmove_64.S | 2 +- arch/x86/lib/memset_64.S | 2 +- arch/x86/lib/retpoline.S | 2 +- 14 files changed, 120 insertions(+), 132 deletions(-) delete mode 100644 arch/x86/include/asm/alternative-asm.h diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S index df8c017e6161..4e079f250962 100644 --- a/arch/x86/entry/entry_32.S +++ b/arch/x86/entry/entry_32.S @@ -40,7 +40,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/arch/x86/entry/vdso/vdso32/system_call.S b/arch/x86/entry/vdso/vdso32/system_call.S index de1fff7188aa..d6a6080bade0 100644 --- a/arch/x86/entry/vdso/vdso32/system_call.S +++ b/arch/x86/entry/vdso/vdso32/system_call.S @@ -6,7 +6,7 @@ #include #include #include -#include +#include .text .globl __kernel_vsyscall diff --git a/arch/x86/include/asm/alternative-asm.h b/arch/x86/include/asm/alternative-asm.h deleted file mode 100644 index 464034db299f..000000000000 --- a/arch/x86/include/asm/alternative-asm.h +++ /dev/null @@ -1,114 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#ifndef _ASM_X86_ALTERNATIVE_ASM_H -#define _ASM_X86_ALTERNATIVE_ASM_H - -#ifdef __ASSEMBLY__ - -#include - -#ifdef CONFIG_SMP - .macro LOCK_PREFIX -672: lock - .pushsection .smp_locks,"a" - .balign 4 - .long 672b - . - .popsection - .endm -#else - .macro LOCK_PREFIX - .endm -#endif - -/* - * objtool annotation to ignore the alternatives and only consider the original - * instruction(s). - */ -.macro ANNOTATE_IGNORE_ALTERNATIVE - .Lannotate_\@: - .pushsection .discard.ignore_alts - .long .Lannotate_\@ - . - .popsection -.endm - -/* - * Issue one struct alt_instr descriptor entry (need to put it into - * the section .altinstructions, see below). This entry contains - * enough information for the alternatives patching code to patch an - * instruction. See apply_alternatives(). - */ -.macro altinstruction_entry orig alt feature orig_len alt_len pad_len - .long \orig - . - .long \alt - . - .word \feature - .byte \orig_len - .byte \alt_len - .byte \pad_len -.endm - -/* - * Define an alternative between two instructions. If @feature is - * present, early code in apply_alternatives() replaces @oldinstr with - * @newinstr. ".skip" directive takes care of proper instruction padding - * in case @newinstr is longer than @oldinstr. - */ -.macro ALTERNATIVE oldinstr, newinstr, feature -140: - \oldinstr -141: - .skip -(((144f-143f)-(141b-140b)) > 0) * ((144f-143f)-(141b-140b)),0x90 -142: - - .pushsection .altinstructions,"a" - altinstruction_entry 140b,143f,\feature,142b-140b,144f-143f,142b-141b - .popsection - - .pushsection .altinstr_replacement,"ax" -143: - \newinstr -144: - .popsection -.endm - -#define old_len 141b-140b -#define new_len1 144f-143f -#define new_len2 145f-144f - -/* - * gas compatible max based on the idea from: - * http://graphics.stanford.edu/~seander/bithacks.html#IntegerMinOrMax - * - * The additional "-" is needed because gas uses a "true" value of -1. - */ -#define alt_max_short(a, b) ((a) ^ (((a) ^ (b)) & -(-((a) < (b))))) - - -/* - * Same as ALTERNATIVE macro above but for two alternatives. If CPU - * has @feature1, it replaces @oldinstr with @newinstr1. If CPU has - * @feature2, it replaces @oldinstr with @feature2. - */ -.macro ALTERNATIVE_2 oldinstr, newinstr1, feature1, newinstr2, feature2 -140: - \oldinstr -141: - .skip -((alt_max_short(new_len1, new_len2) - (old_len)) > 0) * \ - (alt_max_short(new_len1, new_len2) - (old_len)),0x90 -142: - - .pushsection .altinstructions,"a" - altinstruction_entry 140b,143f,\feature1,142b-140b,144f-143f,142b-141b - altinstruction_entry 140b,144f,\feature2,142b-140b,145f-144f,142b-141b - .popsection - - .pushsection .altinstr_replacement,"ax" -143: - \newinstr1 -144: - \newinstr2 -145: - .popsection -.endm - -#endif /* __ASSEMBLY__ */ - -#endif /* _ASM_X86_ALTERNATIVE_ASM_H */ diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h index 5753fb2ac489..53f295f41c34 100644 --- a/arch/x86/include/asm/alternative.h +++ b/arch/x86/include/asm/alternative.h @@ -2,13 +2,14 @@ #ifndef _ASM_X86_ALTERNATIVE_H #define _ASM_X86_ALTERNATIVE_H -#ifndef __ASSEMBLY__ - #include -#include #include #include +#ifndef __ASSEMBLY__ + +#include + /* * Alternative inline assembly for SMP. * @@ -271,6 +272,111 @@ static inline int alternatives_text_reserved(void *start, void *end) */ #define ASM_NO_INPUT_CLOBBER(clbr...) "i" (0) : clbr +#else /* __ASSEMBLY__ */ + +#ifdef CONFIG_SMP + .macro LOCK_PREFIX +672: lock + .pushsection .smp_locks,"a" + .balign 4 + .long 672b - . + .popsection + .endm +#else + .macro LOCK_PREFIX + .endm +#endif + +/* + * objtool annotation to ignore the alternatives and only consider the original + * instruction(s). + */ +.macro ANNOTATE_IGNORE_ALTERNATIVE + .Lannotate_\@: + .pushsection .discard.ignore_alts + .long .Lannotate_\@ - . + .popsection +.endm + +/* + * Issue one struct alt_instr descriptor entry (need to put it into + * the section .altinstructions, see below). This entry contains + * enough information for the alternatives patching code to patch an + * instruction. See apply_alternatives(). + */ +.macro altinstruction_entry orig alt feature orig_len alt_len pad_len + .long \orig - . + .long \alt - . + .word \feature + .byte \orig_len + .byte \alt_len + .byte \pad_len +.endm + +/* + * Define an alternative between two instructions. If @feature is + * present, early code in apply_alternatives() replaces @oldinstr with + * @newinstr. ".skip" directive takes care of proper instruction padding + * in case @newinstr is longer than @oldinstr. + */ +.macro ALTERNATIVE oldinstr, newinstr, feature +140: + \oldinstr +141: + .skip -(((144f-143f)-(141b-140b)) > 0) * ((144f-143f)-(141b-140b)),0x90 +142: + + .pushsection .altinstructions,"a" + altinstruction_entry 140b,143f,\feature,142b-140b,144f-143f,142b-141b + .popsection + + .pushsection .altinstr_replacement,"ax" +143: + \newinstr +144: + .popsection +.endm + +#define old_len 141b-140b +#define new_len1 144f-143f +#define new_len2 145f-144f + +/* + * gas compatible max based on the idea from: + * http://graphics.stanford.edu/~seander/bithacks.html#IntegerMinOrMax + * + * The additional "-" is needed because gas uses a "true" value of -1. + */ +#define alt_max_short(a, b) ((a) ^ (((a) ^ (b)) & -(-((a) < (b))))) + + +/* + * Same as ALTERNATIVE macro above but for two alternatives. If CPU + * has @feature1, it replaces @oldinstr with @newinstr1. If CPU has + * @feature2, it replaces @oldinstr with @feature2. + */ +.macro ALTERNATIVE_2 oldinstr, newinstr1, feature1, newinstr2, feature2 +140: + \oldinstr +141: + .skip -((alt_max_short(new_len1, new_len2) - (old_len)) > 0) * \ + (alt_max_short(new_len1, new_len2) - (old_len)),0x90 +142: + + .pushsection .altinstructions,"a" + altinstruction_entry 140b,143f,\feature1,142b-140b,144f-143f,142b-141b + altinstruction_entry 140b,144f,\feature2,142b-140b,145f-144f,142b-141b + .popsection + + .pushsection .altinstr_replacement,"ax" +143: + \newinstr1 +144: + \newinstr2 +145: + .popsection +.endm + #endif /* __ASSEMBLY__ */ #endif /* _ASM_X86_ALTERNATIVE_H */ diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h index cb9ad6b73973..529f8e9380d8 100644 --- a/arch/x86/include/asm/nospec-branch.h +++ b/arch/x86/include/asm/nospec-branch.h @@ -7,7 +7,6 @@ #include #include -#include #include #include #include diff --git a/arch/x86/include/asm/smap.h b/arch/x86/include/asm/smap.h index 8b58d6975d5d..ea1d8eb644cb 100644 --- a/arch/x86/include/asm/smap.h +++ b/arch/x86/include/asm/smap.h @@ -11,6 +11,7 @@ #include #include +#include /* "Raw" instruction opcodes */ #define __ASM_CLAC ".byte 0x0f,0x01,0xca" @@ -18,8 +19,6 @@ #ifdef __ASSEMBLY__ -#include - #ifdef CONFIG_X86_SMAP #define ASM_CLAC \ @@ -37,8 +36,6 @@ #else /* __ASSEMBLY__ */ -#include - #ifdef CONFIG_X86_SMAP static __always_inline void clac(void) diff --git a/arch/x86/lib/atomic64_386_32.S b/arch/x86/lib/atomic64_386_32.S index 3b6544111ac9..16bc9130e7a5 100644 --- a/arch/x86/lib/atomic64_386_32.S +++ b/arch/x86/lib/atomic64_386_32.S @@ -6,7 +6,7 @@ */ #include -#include +#include /* if you want SMP support, implement these with real spinlocks */ .macro LOCK reg diff --git a/arch/x86/lib/atomic64_cx8_32.S b/arch/x86/lib/atomic64_cx8_32.S index 1c5c81c16b06..ce6935690766 100644 --- a/arch/x86/lib/atomic64_cx8_32.S +++ b/arch/x86/lib/atomic64_cx8_32.S @@ -6,7 +6,7 @@ */ #include -#include +#include .macro read64 reg movl %ebx, %eax diff --git a/arch/x86/lib/copy_page_64.S b/arch/x86/lib/copy_page_64.S index 2402d4c489d2..db4b4f9197c7 100644 --- a/arch/x86/lib/copy_page_64.S +++ b/arch/x86/lib/copy_page_64.S @@ -3,7 +3,7 @@ #include #include -#include +#include #include /* diff --git a/arch/x86/lib/copy_user_64.S b/arch/x86/lib/copy_user_64.S index 77b9b2a3b5c8..57b79c577496 100644 --- a/arch/x86/lib/copy_user_64.S +++ b/arch/x86/lib/copy_user_64.S @@ -11,7 +11,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/arch/x86/lib/memcpy_64.S b/arch/x86/lib/memcpy_64.S index 1e299ac73c86..1cc9da6e29c7 100644 --- a/arch/x86/lib/memcpy_64.S +++ b/arch/x86/lib/memcpy_64.S @@ -4,7 +4,7 @@ #include #include #include -#include +#include #include .pushsection .noinstr.text, "ax" diff --git a/arch/x86/lib/memmove_64.S b/arch/x86/lib/memmove_64.S index 41902fe8b859..64801010d312 100644 --- a/arch/x86/lib/memmove_64.S +++ b/arch/x86/lib/memmove_64.S @@ -8,7 +8,7 @@ */ #include #include -#include +#include #include #undef memmove diff --git a/arch/x86/lib/memset_64.S b/arch/x86/lib/memset_64.S index 0bfd26e4ca9e..9827ae267f96 100644 --- a/arch/x86/lib/memset_64.S +++ b/arch/x86/lib/memset_64.S @@ -3,7 +3,7 @@ #include #include -#include +#include #include /* diff --git a/arch/x86/lib/retpoline.S b/arch/x86/lib/retpoline.S index f6fb1d218dcc..6bb74b5c238c 100644 --- a/arch/x86/lib/retpoline.S +++ b/arch/x86/lib/retpoline.S @@ -4,7 +4,7 @@ #include #include #include -#include +#include #include #include #include -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96578.182882 (Exim 4.92) (envelope-from ) id 1lKMDw-0003oq-FH; Thu, 11 Mar 2021 14:23:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96578.182882; Thu, 11 Mar 2021 14:23:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDw-0003oD-4V; Thu, 11 Mar 2021 14:23:36 +0000 Received: by outflank-mailman (input) for mailman id 96578; Thu, 11 Mar 2021 14:23:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDv-0003YP-1Q for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:35 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5e28d839-f072-40c1-9df6-7e9f69375cd0; Thu, 11 Mar 2021 14:23:25 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C9F89AE1F; Thu, 11 Mar 2021 14:23:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e28d839-f072-40c1-9df6-7e9f69375cd0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uibtRW/35W2JKjmvbkGR/+wzT1klkA1B0aS9OimKU6Q=; b=lMSVnAfgxzjLi+BMYZtuAwhDG6Q71JvdDQWw63hmS7pTk9AFHbWgsv5qtM3F59HXVs+fAg J3JrmjY+q97ZM1Y2Y52S4zDbFkvqwDD5lKwB92SWFsg1S5HO+Vo21kykb5btfgEpCberkS UUQClgKySa0o1H5pS5IOw4ve06JQd3E= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Deep Shah , "VMware, Inc." , Peter Zijlstra Subject: [PATCH v7 08/14] x86: add new features for paravirt patching Date: Thu, 11 Mar 2021 15:23:13 +0100 Message-Id: <20210311142319.4723-9-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311142319.4723-1-jgross@suse.com> References: <20210311142319.4723-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit For being able to switch paravirt patching from special cased custom code sequences to ALTERNATIVE handling some X86_FEATURE_* are needed as new features. This enables to have the standard indirect pv call as the default code and to patch that with the non-Xen custom code sequence via ALTERNATIVE patching later. Make sure paravirt patching is performed before alternative patching. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V3: - add comment (Boris Petkov) - no negative features (Boris Petkov) V4: - move paravirt_set_cap() to paravirt-spinlocks.c --- arch/x86/include/asm/cpufeatures.h | 2 ++ arch/x86/include/asm/paravirt.h | 10 ++++++++++ arch/x86/kernel/alternative.c | 30 ++++++++++++++++++++++++++-- arch/x86/kernel/paravirt-spinlocks.c | 9 +++++++++ 4 files changed, 49 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h index cc96e26d69f7..b440c950246d 100644 --- a/arch/x86/include/asm/cpufeatures.h +++ b/arch/x86/include/asm/cpufeatures.h @@ -236,6 +236,8 @@ #define X86_FEATURE_EPT_AD ( 8*32+17) /* Intel Extended Page Table access-dirty bit */ #define X86_FEATURE_VMCALL ( 8*32+18) /* "" Hypervisor supports the VMCALL instruction */ #define X86_FEATURE_VMW_VMMCALL ( 8*32+19) /* "" VMware prefers VMMCALL hypercall instruction */ +#define X86_FEATURE_PVUNLOCK ( 8*32+20) /* "" PV unlock function */ +#define X86_FEATURE_VCPUPREEMPT ( 8*32+21) /* "" PV vcpu_is_preempted function */ /* Intel-defined CPU features, CPUID level 0x00000007:0 (EBX), word 9 */ #define X86_FEATURE_FSGSBASE ( 9*32+ 0) /* RDFSBASE, WRFSBASE, RDGSBASE, WRGSBASE instructions*/ diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 6408fd0f55ab..def450f46097 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -45,6 +45,10 @@ static inline u64 paravirt_steal_clock(int cpu) return static_call(pv_steal_clock)(cpu); } +#ifdef CONFIG_PARAVIRT_SPINLOCKS +void __init paravirt_set_cap(void); +#endif + /* The paravirtualized I/O functions */ static inline void slow_down_io(void) { @@ -809,5 +813,11 @@ static inline void paravirt_arch_exit_mmap(struct mm_struct *mm) { } #endif + +#ifndef CONFIG_PARAVIRT_SPINLOCKS +static inline void paravirt_set_cap(void) +{ +} +#endif #endif /* __ASSEMBLY__ */ #endif /* _ASM_X86_PARAVIRT_H */ diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index 133b549dc091..76ad4ce454c0 100644 --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -28,6 +28,7 @@ #include #include #include +#include int __read_mostly alternatives_patched; @@ -733,6 +734,33 @@ void __init alternative_instructions(void) * patching. */ + /* + * Paravirt patching and alternative patching can be combined to + * replace a function call with a short direct code sequence (e.g. + * by setting a constant return value instead of doing that in an + * external function). + * In order to make this work the following sequence is required: + * 1. set (artificial) features depending on used paravirt + * functions which can later influence alternative patching + * 2. apply paravirt patching (generally replacing an indirect + * function call with a direct one) + * 3. apply alternative patching (e.g. replacing a direct function + * call with a custom code sequence) + * Doing paravirt patching after alternative patching would clobber + * the optimization of the custom code with a function call again. + */ + paravirt_set_cap(); + + /* + * First patch paravirt functions, such that we overwrite the indirect + * call with the direct call. + */ + apply_paravirt(__parainstructions, __parainstructions_end); + + /* + * Then patch alternatives, such that those paravirt calls that are in + * alternatives can be overwritten by their immediate fragments. + */ apply_alternatives(__alt_instructions, __alt_instructions_end); #ifdef CONFIG_SMP @@ -751,8 +779,6 @@ void __init alternative_instructions(void) } #endif - apply_paravirt(__parainstructions, __parainstructions_end); - restart_nmi(); alternatives_patched = 1; } diff --git a/arch/x86/kernel/paravirt-spinlocks.c b/arch/x86/kernel/paravirt-spinlocks.c index 4f75d0cf6305..9e1ea99ad9df 100644 --- a/arch/x86/kernel/paravirt-spinlocks.c +++ b/arch/x86/kernel/paravirt-spinlocks.c @@ -32,3 +32,12 @@ bool pv_is_native_vcpu_is_preempted(void) return pv_ops.lock.vcpu_is_preempted.func == __raw_callee_save___native_vcpu_is_preempted; } + +void __init paravirt_set_cap(void) +{ + if (!pv_is_native_spin_unlock()) + setup_force_cpu_cap(X86_FEATURE_PVUNLOCK); + + if (!pv_is_native_vcpu_is_preempted()) + setup_force_cpu_cap(X86_FEATURE_VCPUPREEMPT); +} -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96579.182898 (Exim 4.92) (envelope-from ) id 1lKME1-0003xs-5B; Thu, 11 Mar 2021 14:23:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96579.182898; Thu, 11 Mar 2021 14:23:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKME1-0003xe-0w; Thu, 11 Mar 2021 14:23:41 +0000 Received: by outflank-mailman (input) for mailman id 96579; Thu, 11 Mar 2021 14:23:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMDz-0003YK-Os for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:39 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0229db14-070f-479e-82e2-4b631778e5ce; Thu, 11 Mar 2021 14:23:25 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3F96CADCD; Thu, 11 Mar 2021 14:23:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0229db14-070f-479e-82e2-4b631778e5ce X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MKy6lSEcqRltqkWApgm84thplgjw9W/kgg8ogVcUb6U=; b=TuSNTb9JzVfcsxkcShX+P8cRCgJOrN0TPKs68MYP2sHfziWBCPDnMFwE0bLHD5bWKeGIzS yedHoyUFxGWACCPLMFzmJ9go04kFSPP48InTpIlMeZzt4UB35ilJbX41UcEmi3OBAvT3Gr PQ1kV+cd1odVp8NCh4WO77Jqolikqg4= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Peter Zijlstra Subject: [PATCH v7 06/14] x86/alternative: support ALTERNATIVE_TERNARY Date: Thu, 11 Mar 2021 15:23:11 +0100 Message-Id: <20210311142319.4723-7-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311142319.4723-1-jgross@suse.com> References: <20210311142319.4723-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add ALTERNATIVE_TERNARY support for replacing an initial instruction with either of two instructions depending on a feature: ALTERNATIVE_TERNARY "default_instr", FEATURE_NR, "feature_on_instr", "feature_off_instr" which will start with "default_instr" and at patch time will, depending on FEATURE_NR being set or not, patch that with either "feature_on_instr" or "feature_off_instr". Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V3: - new patch V4: - use X86_FEATURE_ALWAYS instead of negated feature (Boris Petkov) - unfortunately this isn't enough to get rid of the "not feature" support, as this is needed in the patch "x86/paravirt: switch functions with custom code to ALTERNATIVE", too V5: - carve out the "not feature" part V7: - rename parameter names (Boris Petkov) --- arch/x86/include/asm/alternative.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h index 649e56f70889..a044e59cbdf5 100644 --- a/arch/x86/include/asm/alternative.h +++ b/arch/x86/include/asm/alternative.h @@ -179,6 +179,10 @@ static inline int alternatives_text_reserved(void *start, void *end) ALTINSTR_REPLACEMENT(newinstr2, 2) \ ".popsection\n" +#define ALTERNATIVE_TERNARY(oldinstr, feature, newinstr_yes, newinstr_no) \ + ALTERNATIVE_2(oldinstr, newinstr_no, X86_FEATURE_ALWAYS, \ + newinstr_yes, feature) + #define ALTERNATIVE_3(oldinsn, newinsn1, feat1, newinsn2, feat2, newinsn3, feat3) \ OLDINSTR_3(oldinsn, 1, 2, 3) \ ".pushsection .altinstructions,\"a\"\n" \ @@ -210,6 +214,9 @@ static inline int alternatives_text_reserved(void *start, void *end) #define alternative_2(oldinstr, newinstr1, feature1, newinstr2, feature2) \ asm_inline volatile(ALTERNATIVE_2(oldinstr, newinstr1, feature1, newinstr2, feature2) ::: "memory") +#define alternative_ternary(oldinstr, feature, newinstr_yes, newinstr_no) \ + asm_inline volatile(ALTERNATIVE_TERNARY(oldinstr, feature, newinstr_yes, newinstr_no) ::: "memory") + /* * Alternative inline assembly with input. * @@ -380,6 +387,10 @@ static inline int alternatives_text_reserved(void *start, void *end) .popsection .endm +#define ALTERNATIVE_TERNARY(oldinstr, feature, newinstr_yes, newinstr_no) \ + ALTERNATIVE_2 oldinstr, newinstr_no, X86_FEATURE_ALWAYS, \ + newinstr_yes, feature + #endif /* __ASSEMBLY__ */ #endif /* _ASM_X86_ALTERNATIVE_H */ -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96580.182906 (Exim 4.92) (envelope-from ) id 1lKME1-0003zA-QX; Thu, 11 Mar 2021 14:23:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96580.182906; Thu, 11 Mar 2021 14:23:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKME1-0003yc-CK; Thu, 11 Mar 2021 14:23:41 +0000 Received: by outflank-mailman (input) for mailman id 96580; Thu, 11 Mar 2021 14:23:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKME0-0003YP-1t for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:40 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f309e393-da7d-4147-a924-4c45c52a560d; Thu, 11 Mar 2021 14:23:25 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D7AE7AD73; Thu, 11 Mar 2021 14:23:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f309e393-da7d-4147-a924-4c45c52a560d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=55byjntLWrac+G1/EmyNpbetggnp+E6260ue3t2P3P4=; b=pYx9kXR2pk2ZxyiESzP4xgpDuzzlLheI8he4AgVsdLKuUnT8pC0NrFk+J8dKtLPkpVilEJ sdTX57T1rw0QbslhJPMJOVWRKm6V1fU4gViCLQE6yIslQtR1nUon0DSNeeIJZLvS2l72aZ eIxUlXXU1vXNwzJ0ggSGszKirXHgt6g= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Boris Ostrovsky , Stefano Stabellini , Peter Zijlstra Subject: [PATCH v7 04/14] x86/paravirt: switch time pvops functions to use static_call() Date: Thu, 11 Mar 2021 15:23:09 +0100 Message-Id: <20210311142319.4723-5-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311142319.4723-1-jgross@suse.com> References: <20210311142319.4723-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The time pvops functions are the only ones left which might be used in 32-bit mode and which return a 64-bit value. Switch them to use the static_call() mechanism instead of pvops, as this allows quite some simplification of the pvops implementation. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V4: - drop paravirt_time.h again - don't move Hyper-V code (Michael Kelley) V5: - drop no longer needed Hyper-V modification (Michael Kelley) - switch Arm and Arm64 to static_call(), too (kernel test robot) V6: - factor out common parts in Xen pv/pvh initialization (Boris Petkov) V7: - use new function static_call_query() --- arch/arm/include/asm/paravirt.h | 14 +++++--------- arch/arm/kernel/paravirt.c | 9 +++++++-- arch/arm64/include/asm/paravirt.h | 14 +++++--------- arch/arm64/kernel/paravirt.c | 13 +++++++++---- arch/x86/Kconfig | 1 + arch/x86/include/asm/mshyperv.h | 2 +- arch/x86/include/asm/paravirt.h | 15 ++++++++++++--- arch/x86/include/asm/paravirt_types.h | 6 ------ arch/x86/kernel/cpu/vmware.c | 5 +++-- arch/x86/kernel/kvm.c | 2 +- arch/x86/kernel/kvmclock.c | 2 +- arch/x86/kernel/paravirt.c | 13 +++++++++---- arch/x86/kernel/tsc.c | 3 ++- arch/x86/xen/time.c | 26 +++++++++++++------------- drivers/xen/time.c | 3 ++- 15 files changed, 71 insertions(+), 57 deletions(-) diff --git a/arch/arm/include/asm/paravirt.h b/arch/arm/include/asm/paravirt.h index cdbf02d9c1d4..95d5b0d625cd 100644 --- a/arch/arm/include/asm/paravirt.h +++ b/arch/arm/include/asm/paravirt.h @@ -3,23 +3,19 @@ #define _ASM_ARM_PARAVIRT_H #ifdef CONFIG_PARAVIRT +#include + struct static_key; extern struct static_key paravirt_steal_enabled; extern struct static_key paravirt_steal_rq_enabled; -struct pv_time_ops { - unsigned long long (*steal_clock)(int cpu); -}; - -struct paravirt_patch_template { - struct pv_time_ops time; -}; +u64 dummy_steal_clock(int cpu); -extern struct paravirt_patch_template pv_ops; +DECLARE_STATIC_CALL(pv_steal_clock, dummy_steal_clock); static inline u64 paravirt_steal_clock(int cpu) { - return pv_ops.time.steal_clock(cpu); + return static_call(pv_steal_clock)(cpu); } #endif diff --git a/arch/arm/kernel/paravirt.c b/arch/arm/kernel/paravirt.c index 4cfed91fe256..7dd9806369fb 100644 --- a/arch/arm/kernel/paravirt.c +++ b/arch/arm/kernel/paravirt.c @@ -9,10 +9,15 @@ #include #include #include +#include #include struct static_key paravirt_steal_enabled; struct static_key paravirt_steal_rq_enabled; -struct paravirt_patch_template pv_ops; -EXPORT_SYMBOL_GPL(pv_ops); +static u64 native_steal_clock(int cpu) +{ + return 0; +} + +DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock); diff --git a/arch/arm64/include/asm/paravirt.h b/arch/arm64/include/asm/paravirt.h index cf3a0fd7c1a7..9aa193e0e8f2 100644 --- a/arch/arm64/include/asm/paravirt.h +++ b/arch/arm64/include/asm/paravirt.h @@ -3,23 +3,19 @@ #define _ASM_ARM64_PARAVIRT_H #ifdef CONFIG_PARAVIRT +#include + struct static_key; extern struct static_key paravirt_steal_enabled; extern struct static_key paravirt_steal_rq_enabled; -struct pv_time_ops { - unsigned long long (*steal_clock)(int cpu); -}; - -struct paravirt_patch_template { - struct pv_time_ops time; -}; +u64 dummy_steal_clock(int cpu); -extern struct paravirt_patch_template pv_ops; +DECLARE_STATIC_CALL(pv_steal_clock, dummy_steal_clock); static inline u64 paravirt_steal_clock(int cpu) { - return pv_ops.time.steal_clock(cpu); + return static_call(pv_steal_clock)(cpu); } int __init pv_time_init(void); diff --git a/arch/arm64/kernel/paravirt.c b/arch/arm64/kernel/paravirt.c index c07d7a034941..75fed4460407 100644 --- a/arch/arm64/kernel/paravirt.c +++ b/arch/arm64/kernel/paravirt.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include @@ -26,8 +27,12 @@ struct static_key paravirt_steal_enabled; struct static_key paravirt_steal_rq_enabled; -struct paravirt_patch_template pv_ops; -EXPORT_SYMBOL_GPL(pv_ops); +static u64 native_steal_clock(int cpu) +{ + return 0; +} + +DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock); struct pv_time_stolen_time_region { struct pvclock_vcpu_stolen_time *kaddr; @@ -45,7 +50,7 @@ static int __init parse_no_stealacc(char *arg) early_param("no-steal-acc", parse_no_stealacc); /* return stolen time in ns by asking the hypervisor */ -static u64 pv_steal_clock(int cpu) +static u64 para_steal_clock(int cpu) { struct pv_time_stolen_time_region *reg; @@ -150,7 +155,7 @@ int __init pv_time_init(void) if (ret) return ret; - pv_ops.time.steal_clock = pv_steal_clock; + static_call_update(pv_steal_clock, para_steal_clock); static_key_slow_inc(¶virt_steal_enabled); if (steal_acc) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 2792879d398e..107acc403b3b 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -777,6 +777,7 @@ if HYPERVISOR_GUEST config PARAVIRT bool "Enable paravirtualization code" + depends on HAVE_STATIC_CALL help This changes the kernel so it can modify itself when it is run under a hypervisor, potentially improving performance significantly diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h index ccf60a809a17..e7be720062a8 100644 --- a/arch/x86/include/asm/mshyperv.h +++ b/arch/x86/include/asm/mshyperv.h @@ -63,7 +63,7 @@ typedef int (*hyperv_fill_flush_list_func)( static __always_inline void hv_setup_sched_clock(void *sched_clock) { #ifdef CONFIG_PARAVIRT - pv_ops.time.sched_clock = sched_clock; + paravirt_set_sched_clock(sched_clock); #endif } diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 4abf110e2243..6408fd0f55ab 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -15,11 +15,20 @@ #include #include #include +#include #include -static inline unsigned long long paravirt_sched_clock(void) +u64 dummy_steal_clock(int cpu); +u64 dummy_sched_clock(void); + +DECLARE_STATIC_CALL(pv_steal_clock, dummy_steal_clock); +DECLARE_STATIC_CALL(pv_sched_clock, dummy_sched_clock); + +void paravirt_set_sched_clock(u64 (*func)(void)); + +static inline u64 paravirt_sched_clock(void) { - return PVOP_CALL0(unsigned long long, time.sched_clock); + return static_call(pv_sched_clock)(); } struct static_key; @@ -33,7 +42,7 @@ bool pv_is_native_vcpu_is_preempted(void); static inline u64 paravirt_steal_clock(int cpu) { - return PVOP_CALL1(u64, time.steal_clock, cpu); + return static_call(pv_steal_clock)(cpu); } /* The paravirtualized I/O functions */ diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index de87087d3bde..1fff349e4792 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -95,11 +95,6 @@ struct pv_lazy_ops { } __no_randomize_layout; #endif -struct pv_time_ops { - unsigned long long (*sched_clock)(void); - unsigned long long (*steal_clock)(int cpu); -} __no_randomize_layout; - struct pv_cpu_ops { /* hooks for various privileged instructions */ void (*io_delay)(void); @@ -291,7 +286,6 @@ struct pv_lock_ops { * what to patch. */ struct paravirt_patch_template { struct pv_init_ops init; - struct pv_time_ops time; struct pv_cpu_ops cpu; struct pv_irq_ops irq; struct pv_mmu_ops mmu; diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index c6ede3b3d302..84fb8e3f3d1b 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #include #include @@ -336,11 +337,11 @@ static void __init vmware_paravirt_ops_setup(void) vmware_cyc2ns_setup(); if (vmw_sched_clock) - pv_ops.time.sched_clock = vmware_sched_clock; + paravirt_set_sched_clock(vmware_sched_clock); if (vmware_is_stealclock_available()) { has_steal_clock = true; - pv_ops.time.steal_clock = vmware_steal_clock; + static_call_update(pv_steal_clock, vmware_steal_clock); /* We use reboot notifier only to disable steal clock */ register_reboot_notifier(&vmware_pv_reboot_nb); diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 5e78e01ca3b4..351ba99f6009 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -650,7 +650,7 @@ static void __init kvm_guest_init(void) if (kvm_para_has_feature(KVM_FEATURE_STEAL_TIME)) { has_steal_clock = 1; - pv_ops.time.steal_clock = kvm_steal_clock; + static_call_update(pv_steal_clock, kvm_steal_clock); } if (pv_tlb_flush_supported()) { diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index aa593743acf6..01e7c1839ace 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -106,7 +106,7 @@ static inline void kvm_sched_clock_init(bool stable) if (!stable) clear_sched_clock_stable(); kvm_sched_clock_offset = kvm_clock_read(); - pv_ops.time.sched_clock = kvm_sched_clock_read; + paravirt_set_sched_clock(kvm_sched_clock_read); pr_info("kvm-clock: using sched offset of %llu cycles", kvm_sched_clock_offset); diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index c60222ab8ab9..a688edf35e31 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include @@ -167,6 +168,14 @@ static u64 native_steal_clock(int cpu) return 0; } +DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock); +DEFINE_STATIC_CALL(pv_sched_clock, native_sched_clock); + +void paravirt_set_sched_clock(u64 (*func)(void)) +{ + static_call_update(pv_sched_clock, func); +} + /* These are in entry.S */ extern void native_iret(void); @@ -272,10 +281,6 @@ struct paravirt_patch_template pv_ops = { /* Init ops. */ .init.patch = native_patch, - /* Time ops. */ - .time.sched_clock = native_sched_clock, - .time.steal_clock = native_steal_clock, - /* Cpu ops. */ .cpu.io_delay = native_io_delay, diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index f70dffc2771f..9f592923f956 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include @@ -254,7 +255,7 @@ unsigned long long sched_clock(void) bool using_native_sched_clock(void) { - return pv_ops.time.sched_clock == native_sched_clock; + return static_call_query(pv_sched_clock) == native_sched_clock; } #else unsigned long long diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 91f5b330dcc6..d9c945ee1100 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -379,11 +379,6 @@ void xen_timer_resume(void) } } -static const struct pv_time_ops xen_time_ops __initconst = { - .sched_clock = xen_sched_clock, - .steal_clock = xen_steal_clock, -}; - static struct pvclock_vsyscall_time_info *xen_clock __read_mostly; static u64 xen_clock_value_saved; @@ -525,17 +520,24 @@ static void __init xen_time_init(void) pvclock_gtod_register_notifier(&xen_pvclock_gtod_notifier); } -void __init xen_init_time_ops(void) +static void __init xen_init_time_common(void) { xen_sched_clock_offset = xen_clocksource_read(); - pv_ops.time = xen_time_ops; + static_call_update(pv_steal_clock, xen_steal_clock); + paravirt_set_sched_clock(xen_sched_clock); + + x86_platform.calibrate_tsc = xen_tsc_khz; + x86_platform.get_wallclock = xen_get_wallclock; +} + +void __init xen_init_time_ops(void) +{ + xen_init_time_common(); x86_init.timers.timer_init = xen_time_init; x86_init.timers.setup_percpu_clockev = x86_init_noop; x86_cpuinit.setup_percpu_clockev = x86_init_noop; - x86_platform.calibrate_tsc = xen_tsc_khz; - x86_platform.get_wallclock = xen_get_wallclock; /* Dom0 uses the native method to set the hardware RTC. */ if (!xen_initial_domain()) x86_platform.set_wallclock = xen_set_wallclock; @@ -569,13 +571,11 @@ void __init xen_hvm_init_time_ops(void) return; } - xen_sched_clock_offset = xen_clocksource_read(); - pv_ops.time = xen_time_ops; + xen_init_time_common(); + x86_init.timers.setup_percpu_clockev = xen_time_init; x86_cpuinit.setup_percpu_clockev = xen_hvm_setup_cpu_clockevents; - x86_platform.calibrate_tsc = xen_tsc_khz; - x86_platform.get_wallclock = xen_get_wallclock; x86_platform.set_wallclock = xen_set_wallclock; } #endif diff --git a/drivers/xen/time.c b/drivers/xen/time.c index 108edbcbc040..152dd33bb223 100644 --- a/drivers/xen/time.c +++ b/drivers/xen/time.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include @@ -175,7 +176,7 @@ void __init xen_time_setup_guest(void) xen_runstate_remote = !HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_runstate_update_flag); - pv_ops.time.steal_clock = xen_steal_clock; + static_call_update(pv_steal_clock, xen_steal_clock); static_key_slow_inc(¶virt_steal_enabled); if (xen_runstate_remote) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96581.182922 (Exim 4.92) (envelope-from ) id 1lKME6-00047x-1v; Thu, 11 Mar 2021 14:23:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96581.182922; Thu, 11 Mar 2021 14:23:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKME5-00047n-TY; Thu, 11 Mar 2021 14:23:45 +0000 Received: by outflank-mailman (input) for mailman id 96581; Thu, 11 Mar 2021 14:23:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKME4-0003YK-Oy for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:44 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5a32725c-0fcb-4e40-8d5f-c312b9c9189e; Thu, 11 Mar 2021 14:23:26 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 87391AE49; Thu, 11 Mar 2021 14:23:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a32725c-0fcb-4e40-8d5f-c312b9c9189e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Oc97+qf4A0YSsFztEucEY2JDBPPlEsNort962uFLwIM=; b=CWrLLOWMmSSielRQngX4qLa7ZBBsntgBuTdQE1+Pn24Wd6S14QnfqH0EmAI4/7JRmBrm9z eTj0xyRsxqoGNiJzRECw2S+Jpzo61cctda1DK/N0VOKYURSEvLksmuMpvrXYc0gSrS4KC4 sFCziCdRK4tcRiaHq5Cxs1qPXCx2e4A= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Nathan Chancellor , Nick Desaulniers , Peter Zijlstra Subject: [PATCH v7 10/14] x86/paravirt: simplify paravirt macros Date: Thu, 11 Mar 2021 15:23:15 +0100 Message-Id: <20210311142319.4723-11-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311142319.4723-1-jgross@suse.com> References: <20210311142319.4723-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The central pvops call macros ____PVOP_CALL() and ____PVOP_VCALL() are looking very similar now. The main differences are using PVOP_VCALL_ARGS or PVOP_CALL_ARGS, which are identical, and the return value handling. So drop PVOP_VCALL_ARGS and instead of ____PVOP_VCALL() just use (void)____PVOP_CALL(long, ...). Note that it isn't easily possible to just redefine ____PVOP_VCALL() to use ____PVOP_CALL() instead, as this would require further hiding of commas in macro parameters. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V3: - new patch V4: - fix build warnings with clang (kernel test robot) --- arch/x86/include/asm/paravirt_types.h | 41 ++++++++------------------- 1 file changed, 12 insertions(+), 29 deletions(-) diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 42f9eef84131..45bd21647dd8 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -408,11 +408,9 @@ int paravirt_disable_iospace(void); * makes sure the incoming and outgoing types are always correct. */ #ifdef CONFIG_X86_32 -#define PVOP_VCALL_ARGS \ +#define PVOP_CALL_ARGS \ unsigned long __eax = __eax, __edx = __edx, __ecx = __ecx; -#define PVOP_CALL_ARGS PVOP_VCALL_ARGS - #define PVOP_CALL_ARG1(x) "a" ((unsigned long)(x)) #define PVOP_CALL_ARG2(x) "d" ((unsigned long)(x)) #define PVOP_CALL_ARG3(x) "c" ((unsigned long)(x)) @@ -428,12 +426,10 @@ int paravirt_disable_iospace(void); #define VEXTRA_CLOBBERS #else /* CONFIG_X86_64 */ /* [re]ax isn't an arg, but the return val */ -#define PVOP_VCALL_ARGS \ +#define PVOP_CALL_ARGS \ unsigned long __edi = __edi, __esi = __esi, \ __edx = __edx, __ecx = __ecx, __eax = __eax; -#define PVOP_CALL_ARGS PVOP_VCALL_ARGS - #define PVOP_CALL_ARG1(x) "D" ((unsigned long)(x)) #define PVOP_CALL_ARG2(x) "S" ((unsigned long)(x)) #define PVOP_CALL_ARG3(x) "d" ((unsigned long)(x)) @@ -458,59 +454,46 @@ int paravirt_disable_iospace(void); #define PVOP_TEST_NULL(op) ((void)pv_ops.op) #endif -#define PVOP_RETMASK(rettype) \ +#define PVOP_RETVAL(rettype) \ ({ unsigned long __mask = ~0UL; \ + BUILD_BUG_ON(sizeof(rettype) > sizeof(unsigned long)); \ switch (sizeof(rettype)) { \ case 1: __mask = 0xffUL; break; \ case 2: __mask = 0xffffUL; break; \ case 4: __mask = 0xffffffffUL; break; \ default: break; \ } \ - __mask; \ + __mask & __eax; \ }) -#define ____PVOP_CALL(rettype, op, clbr, call_clbr, extra_clbr, ...) \ +#define ____PVOP_CALL(ret, op, clbr, call_clbr, extra_clbr, ...) \ ({ \ PVOP_CALL_ARGS; \ PVOP_TEST_NULL(op); \ - BUILD_BUG_ON(sizeof(rettype) > sizeof(unsigned long)); \ asm volatile(paravirt_alt(PARAVIRT_CALL) \ : call_clbr, ASM_CALL_CONSTRAINT \ : paravirt_type(op), \ paravirt_clobber(clbr), \ ##__VA_ARGS__ \ : "memory", "cc" extra_clbr); \ - (rettype)(__eax & PVOP_RETMASK(rettype)); \ + ret; \ }) #define __PVOP_CALL(rettype, op, ...) \ - ____PVOP_CALL(rettype, op, CLBR_ANY, PVOP_CALL_CLOBBERS, \ - EXTRA_CLOBBERS, ##__VA_ARGS__) + ____PVOP_CALL(PVOP_RETVAL(rettype), op, CLBR_ANY, \ + PVOP_CALL_CLOBBERS, EXTRA_CLOBBERS, ##__VA_ARGS__) #define __PVOP_CALLEESAVE(rettype, op, ...) \ - ____PVOP_CALL(rettype, op.func, CLBR_RET_REG, \ + ____PVOP_CALL(PVOP_RETVAL(rettype), op.func, CLBR_RET_REG, \ PVOP_CALLEE_CLOBBERS, , ##__VA_ARGS__) - -#define ____PVOP_VCALL(op, clbr, call_clbr, extra_clbr, ...) \ - ({ \ - PVOP_VCALL_ARGS; \ - PVOP_TEST_NULL(op); \ - asm volatile(paravirt_alt(PARAVIRT_CALL) \ - : call_clbr, ASM_CALL_CONSTRAINT \ - : paravirt_type(op), \ - paravirt_clobber(clbr), \ - ##__VA_ARGS__ \ - : "memory", "cc" extra_clbr); \ - }) - #define __PVOP_VCALL(op, ...) \ - ____PVOP_VCALL(op, CLBR_ANY, PVOP_VCALL_CLOBBERS, \ + (void)____PVOP_CALL(, op, CLBR_ANY, PVOP_VCALL_CLOBBERS, \ VEXTRA_CLOBBERS, ##__VA_ARGS__) #define __PVOP_VCALLEESAVE(op, ...) \ - ____PVOP_VCALL(op.func, CLBR_RET_REG, \ + (void)____PVOP_CALL(, op.func, CLBR_RET_REG, \ PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96582.182928 (Exim 4.92) (envelope-from ) id 1lKME6-00049H-PQ; Thu, 11 Mar 2021 14:23:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96582.182928; Thu, 11 Mar 2021 14:23:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKME6-00048m-B5; Thu, 11 Mar 2021 14:23:46 +0000 Received: by outflank-mailman (input) for mailman id 96582; Thu, 11 Mar 2021 14:23:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKME5-0003YP-1I for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:45 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3c25066b-ad2b-48d8-b03d-306208a12fa0; Thu, 11 Mar 2021 14:23:26 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 25ED3AE42; Thu, 11 Mar 2021 14:23:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c25066b-ad2b-48d8-b03d-306208a12fa0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YPgxzWE73/7UNYG43HNrY7aTQtYQuW9YtSaQMteVv6c=; b=MmCvQXIsDAGwYfh92Er1c3z/3PhwxJ7fhx6BN4qfXJVU8eJRzRWUNUU73Df3AVQZGGFwXv c17nK6rCG+yb6e6C1FT9kwFzc/T3RmbrUgd1Fjmeg2F97wdtCDJmXZaA3o8f5FFyoYY7pq E3uy/QdLvEqJdNUkp50pKZXEFXATirU= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Juergen Gross , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Deep Shah , "VMware, Inc." , Peter Zijlstra Subject: [PATCH v7 09/14] x86/paravirt: remove no longer needed 32-bit pvops cruft Date: Thu, 11 Mar 2021 15:23:14 +0100 Message-Id: <20210311142319.4723-10-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311142319.4723-1-jgross@suse.com> References: <20210311142319.4723-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PVOP_VCALL4() is only used for Xen PV, while PVOP_CALL4() isn't used at all. Keep PVOP_CALL4() for 64 bits due to symmetry reasons. This allows to remove the 32-bit definitions of those macros leading to a substantial simplification of the paravirt macros, as those were the only ones needing non-empty "pre" and "post" parameters. PVOP_CALLEE2() and PVOP_VCALLEE2() are used nowhere, so remove them. Another no longer needed case is special handling of return types larger than unsigned long. Replace that with a BUILD_BUG_ON(). DISABLE_INTERRUPTS() is used in 32-bit code only, so it can just be replaced by cli. INTERRUPT_RETURN in 32-bit code can be replaced by iret. ENABLE_INTERRUPTS is used nowhere, so it can be removed. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- arch/x86/entry/entry_32.S | 4 +- arch/x86/include/asm/irqflags.h | 5 -- arch/x86/include/asm/paravirt.h | 35 +------- arch/x86/include/asm/paravirt_types.h | 112 ++++++++------------------ arch/x86/kernel/asm-offsets.c | 2 - 5 files changed, 35 insertions(+), 123 deletions(-) diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S index 4e079f250962..96f084868ec7 100644 --- a/arch/x86/entry/entry_32.S +++ b/arch/x86/entry/entry_32.S @@ -430,7 +430,7 @@ * will soon execute iret and the tracer was already set to * the irqstate after the IRET: */ - DISABLE_INTERRUPTS(CLBR_ANY) + cli lss (%esp), %esp /* switch to espfix segment */ .Lend_\@: #endif /* CONFIG_X86_ESPFIX32 */ @@ -1077,7 +1077,7 @@ restore_all_switch_stack: * when returning from IPI handler and when returning from * scheduler to user-space. */ - INTERRUPT_RETURN + iret .section .fixup, "ax" SYM_CODE_START(asm_iret_error) diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h index 144d70ea4393..a0efbcd24b86 100644 --- a/arch/x86/include/asm/irqflags.h +++ b/arch/x86/include/asm/irqflags.h @@ -109,9 +109,6 @@ static __always_inline unsigned long arch_local_irq_save(void) } #else -#define ENABLE_INTERRUPTS(x) sti -#define DISABLE_INTERRUPTS(x) cli - #ifdef CONFIG_X86_64 #ifdef CONFIG_DEBUG_ENTRY #define SAVE_FLAGS(x) pushfq; popq %rax @@ -119,8 +116,6 @@ static __always_inline unsigned long arch_local_irq_save(void) #define INTERRUPT_RETURN jmp native_iret -#else -#define INTERRUPT_RETURN iret #endif #endif /* __ASSEMBLY__ */ diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index def450f46097..a780509186bd 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -719,6 +719,7 @@ extern void default_banner(void); .if ((~(set)) & mask); pop %reg; .endif #ifdef CONFIG_X86_64 +#ifdef CONFIG_PARAVIRT_XXL #define PV_SAVE_REGS(set) \ COND_PUSH(set, CLBR_RAX, rax); \ @@ -744,46 +745,12 @@ extern void default_banner(void); #define PARA_PATCH(off) ((off) / 8) #define PARA_SITE(ptype, ops) _PVSITE(ptype, ops, .quad, 8) #define PARA_INDIRECT(addr) *addr(%rip) -#else -#define PV_SAVE_REGS(set) \ - COND_PUSH(set, CLBR_EAX, eax); \ - COND_PUSH(set, CLBR_EDI, edi); \ - COND_PUSH(set, CLBR_ECX, ecx); \ - COND_PUSH(set, CLBR_EDX, edx) -#define PV_RESTORE_REGS(set) \ - COND_POP(set, CLBR_EDX, edx); \ - COND_POP(set, CLBR_ECX, ecx); \ - COND_POP(set, CLBR_EDI, edi); \ - COND_POP(set, CLBR_EAX, eax) - -#define PARA_PATCH(off) ((off) / 4) -#define PARA_SITE(ptype, ops) _PVSITE(ptype, ops, .long, 4) -#define PARA_INDIRECT(addr) *%cs:addr -#endif -#ifdef CONFIG_PARAVIRT_XXL #define INTERRUPT_RETURN \ PARA_SITE(PARA_PATCH(PV_CPU_iret), \ ANNOTATE_RETPOLINE_SAFE; \ jmp PARA_INDIRECT(pv_ops+PV_CPU_iret);) -#define DISABLE_INTERRUPTS(clobbers) \ - PARA_SITE(PARA_PATCH(PV_IRQ_irq_disable), \ - PV_SAVE_REGS(clobbers | CLBR_CALLEE_SAVE); \ - ANNOTATE_RETPOLINE_SAFE; \ - call PARA_INDIRECT(pv_ops+PV_IRQ_irq_disable); \ - PV_RESTORE_REGS(clobbers | CLBR_CALLEE_SAVE);) - -#define ENABLE_INTERRUPTS(clobbers) \ - PARA_SITE(PARA_PATCH(PV_IRQ_irq_enable), \ - PV_SAVE_REGS(clobbers | CLBR_CALLEE_SAVE); \ - ANNOTATE_RETPOLINE_SAFE; \ - call PARA_INDIRECT(pv_ops+PV_IRQ_irq_enable); \ - PV_RESTORE_REGS(clobbers | CLBR_CALLEE_SAVE);) -#endif - -#ifdef CONFIG_X86_64 -#ifdef CONFIG_PARAVIRT_XXL #ifdef CONFIG_DEBUG_ENTRY #define SAVE_FLAGS(clobbers) \ PARA_SITE(PARA_PATCH(PV_IRQ_save_fl), \ diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 1fff349e4792..42f9eef84131 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -470,55 +470,34 @@ int paravirt_disable_iospace(void); }) -#define ____PVOP_CALL(rettype, op, clbr, call_clbr, extra_clbr, \ - pre, post, ...) \ +#define ____PVOP_CALL(rettype, op, clbr, call_clbr, extra_clbr, ...) \ ({ \ - rettype __ret; \ PVOP_CALL_ARGS; \ PVOP_TEST_NULL(op); \ - /* This is 32-bit specific, but is okay in 64-bit */ \ - /* since this condition will never hold */ \ - if (sizeof(rettype) > sizeof(unsigned long)) { \ - asm volatile(pre \ - paravirt_alt(PARAVIRT_CALL) \ - post \ - : call_clbr, ASM_CALL_CONSTRAINT \ - : paravirt_type(op), \ - paravirt_clobber(clbr), \ - ##__VA_ARGS__ \ - : "memory", "cc" extra_clbr); \ - __ret = (rettype)((((u64)__edx) << 32) | __eax); \ - } else { \ - asm volatile(pre \ - paravirt_alt(PARAVIRT_CALL) \ - post \ - : call_clbr, ASM_CALL_CONSTRAINT \ - : paravirt_type(op), \ - paravirt_clobber(clbr), \ - ##__VA_ARGS__ \ - : "memory", "cc" extra_clbr); \ - __ret = (rettype)(__eax & PVOP_RETMASK(rettype)); \ - } \ - __ret; \ + BUILD_BUG_ON(sizeof(rettype) > sizeof(unsigned long)); \ + asm volatile(paravirt_alt(PARAVIRT_CALL) \ + : call_clbr, ASM_CALL_CONSTRAINT \ + : paravirt_type(op), \ + paravirt_clobber(clbr), \ + ##__VA_ARGS__ \ + : "memory", "cc" extra_clbr); \ + (rettype)(__eax & PVOP_RETMASK(rettype)); \ }) -#define __PVOP_CALL(rettype, op, pre, post, ...) \ +#define __PVOP_CALL(rettype, op, ...) \ ____PVOP_CALL(rettype, op, CLBR_ANY, PVOP_CALL_CLOBBERS, \ - EXTRA_CLOBBERS, pre, post, ##__VA_ARGS__) + EXTRA_CLOBBERS, ##__VA_ARGS__) -#define __PVOP_CALLEESAVE(rettype, op, pre, post, ...) \ +#define __PVOP_CALLEESAVE(rettype, op, ...) \ ____PVOP_CALL(rettype, op.func, CLBR_RET_REG, \ - PVOP_CALLEE_CLOBBERS, , \ - pre, post, ##__VA_ARGS__) + PVOP_CALLEE_CLOBBERS, , ##__VA_ARGS__) -#define ____PVOP_VCALL(op, clbr, call_clbr, extra_clbr, pre, post, ...) \ +#define ____PVOP_VCALL(op, clbr, call_clbr, extra_clbr, ...) \ ({ \ PVOP_VCALL_ARGS; \ PVOP_TEST_NULL(op); \ - asm volatile(pre \ - paravirt_alt(PARAVIRT_CALL) \ - post \ + asm volatile(paravirt_alt(PARAVIRT_CALL) \ : call_clbr, ASM_CALL_CONSTRAINT \ : paravirt_type(op), \ paravirt_clobber(clbr), \ @@ -526,84 +505,57 @@ int paravirt_disable_iospace(void); : "memory", "cc" extra_clbr); \ }) -#define __PVOP_VCALL(op, pre, post, ...) \ +#define __PVOP_VCALL(op, ...) \ ____PVOP_VCALL(op, CLBR_ANY, PVOP_VCALL_CLOBBERS, \ - VEXTRA_CLOBBERS, \ - pre, post, ##__VA_ARGS__) + VEXTRA_CLOBBERS, ##__VA_ARGS__) -#define __PVOP_VCALLEESAVE(op, pre, post, ...) \ +#define __PVOP_VCALLEESAVE(op, ...) \ ____PVOP_VCALL(op.func, CLBR_RET_REG, \ - PVOP_VCALLEE_CLOBBERS, , \ - pre, post, ##__VA_ARGS__) + PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) #define PVOP_CALL0(rettype, op) \ - __PVOP_CALL(rettype, op, "", "") + __PVOP_CALL(rettype, op) #define PVOP_VCALL0(op) \ - __PVOP_VCALL(op, "", "") + __PVOP_VCALL(op) #define PVOP_CALLEE0(rettype, op) \ - __PVOP_CALLEESAVE(rettype, op, "", "") + __PVOP_CALLEESAVE(rettype, op) #define PVOP_VCALLEE0(op) \ - __PVOP_VCALLEESAVE(op, "", "") + __PVOP_VCALLEESAVE(op) #define PVOP_CALL1(rettype, op, arg1) \ - __PVOP_CALL(rettype, op, "", "", PVOP_CALL_ARG1(arg1)) + __PVOP_CALL(rettype, op, PVOP_CALL_ARG1(arg1)) #define PVOP_VCALL1(op, arg1) \ - __PVOP_VCALL(op, "", "", PVOP_CALL_ARG1(arg1)) + __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1)) #define PVOP_CALLEE1(rettype, op, arg1) \ - __PVOP_CALLEESAVE(rettype, op, "", "", PVOP_CALL_ARG1(arg1)) + __PVOP_CALLEESAVE(rettype, op, PVOP_CALL_ARG1(arg1)) #define PVOP_VCALLEE1(op, arg1) \ - __PVOP_VCALLEESAVE(op, "", "", PVOP_CALL_ARG1(arg1)) + __PVOP_VCALLEESAVE(op, PVOP_CALL_ARG1(arg1)) #define PVOP_CALL2(rettype, op, arg1, arg2) \ - __PVOP_CALL(rettype, op, "", "", PVOP_CALL_ARG1(arg1), \ - PVOP_CALL_ARG2(arg2)) + __PVOP_CALL(rettype, op, PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2)) #define PVOP_VCALL2(op, arg1, arg2) \ - __PVOP_VCALL(op, "", "", PVOP_CALL_ARG1(arg1), \ - PVOP_CALL_ARG2(arg2)) - -#define PVOP_CALLEE2(rettype, op, arg1, arg2) \ - __PVOP_CALLEESAVE(rettype, op, "", "", PVOP_CALL_ARG1(arg1), \ - PVOP_CALL_ARG2(arg2)) -#define PVOP_VCALLEE2(op, arg1, arg2) \ - __PVOP_VCALLEESAVE(op, "", "", PVOP_CALL_ARG1(arg1), \ - PVOP_CALL_ARG2(arg2)) - + __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2)) #define PVOP_CALL3(rettype, op, arg1, arg2, arg3) \ - __PVOP_CALL(rettype, op, "", "", PVOP_CALL_ARG1(arg1), \ + __PVOP_CALL(rettype, op, PVOP_CALL_ARG1(arg1), \ PVOP_CALL_ARG2(arg2), PVOP_CALL_ARG3(arg3)) #define PVOP_VCALL3(op, arg1, arg2, arg3) \ - __PVOP_VCALL(op, "", "", PVOP_CALL_ARG1(arg1), \ + __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1), \ PVOP_CALL_ARG2(arg2), PVOP_CALL_ARG3(arg3)) -/* This is the only difference in x86_64. We can make it much simpler */ -#ifdef CONFIG_X86_32 #define PVOP_CALL4(rettype, op, arg1, arg2, arg3, arg4) \ __PVOP_CALL(rettype, op, \ - "push %[_arg4];", "lea 4(%%esp),%%esp;", \ - PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2), \ - PVOP_CALL_ARG3(arg3), [_arg4] "mr" ((u32)(arg4))) -#define PVOP_VCALL4(op, arg1, arg2, arg3, arg4) \ - __PVOP_VCALL(op, \ - "push %[_arg4];", "lea 4(%%esp),%%esp;", \ - "0" ((u32)(arg1)), "1" ((u32)(arg2)), \ - "2" ((u32)(arg3)), [_arg4] "mr" ((u32)(arg4))) -#else -#define PVOP_CALL4(rettype, op, arg1, arg2, arg3, arg4) \ - __PVOP_CALL(rettype, op, "", "", \ PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2), \ PVOP_CALL_ARG3(arg3), PVOP_CALL_ARG4(arg4)) #define PVOP_VCALL4(op, arg1, arg2, arg3, arg4) \ - __PVOP_VCALL(op, "", "", \ - PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2), \ + __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1), PVOP_CALL_ARG2(arg2), \ PVOP_CALL_ARG3(arg3), PVOP_CALL_ARG4(arg4)) -#endif /* Lazy mode for batching updates / context switch */ enum paravirt_lazy_mode { diff --git a/arch/x86/kernel/asm-offsets.c b/arch/x86/kernel/asm-offsets.c index 60b9f42ce3c1..736508004b30 100644 --- a/arch/x86/kernel/asm-offsets.c +++ b/arch/x86/kernel/asm-offsets.c @@ -63,8 +63,6 @@ static void __used common(void) #ifdef CONFIG_PARAVIRT_XXL BLANK(); - OFFSET(PV_IRQ_irq_disable, paravirt_patch_template, irq.irq_disable); - OFFSET(PV_IRQ_irq_enable, paravirt_patch_template, irq.irq_enable); OFFSET(PV_CPU_iret, paravirt_patch_template, cpu.iret); #endif -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96583.182946 (Exim 4.92) (envelope-from ) id 1lKMEB-0004Iv-Af; Thu, 11 Mar 2021 14:23:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96583.182946; Thu, 11 Mar 2021 14:23:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMEB-0004Ik-5i; Thu, 11 Mar 2021 14:23:51 +0000 Received: by outflank-mailman (input) for mailman id 96583; Thu, 11 Mar 2021 14:23:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKME9-0003YK-P5 for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:49 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 65175bab-8f46-4645-85dc-7cac852dd97e; Thu, 11 Mar 2021 14:23:26 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E305AAE44; Thu, 11 Mar 2021 14:23:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65175bab-8f46-4645-85dc-7cac852dd97e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IoI7oHufeO8pieHlsxYeq8uKmilyQjXsUQUWZlzb7OE=; b=JTodUFeSkwVptUe+WEDIhCYBsfvIKyFCCawDwjkRTsQA5A58As0giziNTz37dloIRJyjYe oCJ/k3Q1vNixFiQa4Pml/1PcmKQf4h36+ffSK+q/GTxDqO8p7BTHv9pSVEIsCsAMB5tyOn yRHGRcb50GXCnHIu0T4CEczhIdGWTD8= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Boris Ostrovsky , Stefano Stabellini , Peter Zijlstra Subject: [PATCH v7 11/14] x86/paravirt: switch iret pvops to ALTERNATIVE Date: Thu, 11 Mar 2021 15:23:16 +0100 Message-Id: <20210311142319.4723-12-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311142319.4723-1-jgross@suse.com> References: <20210311142319.4723-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The iret paravirt op is rather special as it is using a jmp instead of a call instruction. Switch it to ALTERNATIVE. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V3: - use ALTERNATIVE_TERNARY --- arch/x86/include/asm/paravirt.h | 6 +++--- arch/x86/include/asm/paravirt_types.h | 5 +---- arch/x86/kernel/asm-offsets.c | 5 ----- arch/x86/kernel/paravirt.c | 26 ++------------------------ arch/x86/xen/enlighten_pv.c | 3 +-- 5 files changed, 7 insertions(+), 38 deletions(-) diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index a780509186bd..913acf7a0ebf 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -747,9 +747,9 @@ extern void default_banner(void); #define PARA_INDIRECT(addr) *addr(%rip) #define INTERRUPT_RETURN \ - PARA_SITE(PARA_PATCH(PV_CPU_iret), \ - ANNOTATE_RETPOLINE_SAFE; \ - jmp PARA_INDIRECT(pv_ops+PV_CPU_iret);) + ANNOTATE_RETPOLINE_SAFE; \ + ALTERNATIVE_TERNARY("jmp *paravirt_iret(%rip);", \ + X86_FEATURE_XENPV, "jmp xen_iret;", "jmp native_iret;") #ifdef CONFIG_DEBUG_ENTRY #define SAVE_FLAGS(clobbers) \ diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 45bd21647dd8..0afdac83f926 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -151,10 +151,6 @@ struct pv_cpu_ops { u64 (*read_pmc)(int counter); - /* Normal iret. Jump to this with the standard iret stack - frame set up. */ - void (*iret)(void); - void (*start_context_switch)(struct task_struct *prev); void (*end_context_switch)(struct task_struct *next); #endif @@ -294,6 +290,7 @@ struct paravirt_patch_template { extern struct pv_info pv_info; extern struct paravirt_patch_template pv_ops; +extern void (*paravirt_iret)(void); #define PARAVIRT_PATCH(x) \ (offsetof(struct paravirt_patch_template, x) / sizeof(void *)) diff --git a/arch/x86/kernel/asm-offsets.c b/arch/x86/kernel/asm-offsets.c index 736508004b30..ecd3fd6993d1 100644 --- a/arch/x86/kernel/asm-offsets.c +++ b/arch/x86/kernel/asm-offsets.c @@ -61,11 +61,6 @@ static void __used common(void) OFFSET(IA32_RT_SIGFRAME_sigcontext, rt_sigframe_ia32, uc.uc_mcontext); #endif -#ifdef CONFIG_PARAVIRT_XXL - BLANK(); - OFFSET(PV_CPU_iret, paravirt_patch_template, cpu.iret); -#endif - #ifdef CONFIG_XEN BLANK(); OFFSET(XEN_vcpu_info_mask, vcpu_info, evtchn_upcall_mask); diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index a688edf35e31..9b0f568b0200 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -86,25 +86,6 @@ u64 notrace _paravirt_ident_64(u64 x) { return x; } - -static unsigned paravirt_patch_jmp(void *insn_buff, const void *target, - unsigned long addr, unsigned len) -{ - struct branch *b = insn_buff; - unsigned long delta = (unsigned long)target - (addr+5); - - if (len < 5) { -#ifdef CONFIG_RETPOLINE - WARN_ONCE(1, "Failing to patch indirect JMP in %ps\n", (void *)addr); -#endif - return len; /* call too long for patch site */ - } - - b->opcode = 0xe9; /* jmp */ - b->delta = delta; - - return 5; -} #endif DEFINE_STATIC_KEY_TRUE(virt_spin_lock_key); @@ -136,9 +117,6 @@ unsigned paravirt_patch_default(u8 type, void *insn_buff, else if (opfunc == _paravirt_ident_64) ret = paravirt_patch_ident_64(insn_buff, len); - else if (type == PARAVIRT_PATCH(cpu.iret)) - /* If operation requires a jmp, then jmp */ - ret = paravirt_patch_jmp(insn_buff, opfunc, addr, len); #endif else /* Otherwise call the function. */ @@ -313,8 +291,6 @@ struct paravirt_patch_template pv_ops = { .cpu.load_sp0 = native_load_sp0, - .cpu.iret = native_iret, - #ifdef CONFIG_X86_IOPL_IOPERM .cpu.invalidate_io_bitmap = native_tss_invalidate_io_bitmap, .cpu.update_io_bitmap = native_tss_update_io_bitmap, @@ -419,6 +395,8 @@ struct paravirt_patch_template pv_ops = { NOKPROBE_SYMBOL(native_get_debugreg); NOKPROBE_SYMBOL(native_set_debugreg); NOKPROBE_SYMBOL(native_load_idt); + +void (*paravirt_iret)(void) = native_iret; #endif EXPORT_SYMBOL(pv_ops); diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index dc0a337f985b..08dca7bebb30 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -1070,8 +1070,6 @@ static const struct pv_cpu_ops xen_cpu_ops __initconst = { .read_pmc = xen_read_pmc, - .iret = xen_iret, - .load_tr_desc = paravirt_nop, .set_ldt = xen_set_ldt, .load_gdt = xen_load_gdt, @@ -1235,6 +1233,7 @@ asmlinkage __visible void __init xen_start_kernel(void) pv_info = xen_info; pv_ops.init.patch = paravirt_patch_default; pv_ops.cpu = xen_cpu_ops; + paravirt_iret = xen_iret; xen_init_irq_ops(); /* -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96584.182951 (Exim 4.92) (envelope-from ) id 1lKMEB-0004KE-Sf; Thu, 11 Mar 2021 14:23:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96584.182951; Thu, 11 Mar 2021 14:23:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMEB-0004Jg-Id; Thu, 11 Mar 2021 14:23:51 +0000 Received: by outflank-mailman (input) for mailman id 96584; Thu, 11 Mar 2021 14:23:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMEA-0003YP-1j for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ce256495-9935-43e5-8506-187df64efd8f; Thu, 11 Mar 2021 14:23:27 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 35538AEAE; Thu, 11 Mar 2021 14:23:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce256495-9935-43e5-8506-187df64efd8f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/BOg9FE2LyOwuFPT7IjJCD7FUb4zh5arPwZL+WX0RDM=; b=lYC9xkByKo6WT3wmk5wHQUXFXo6jo6LRTu64y60i3Tk1K4r3voASTQzXE6taqM3VTJ2vsb jRo9P30Gfl0aTwseTZX2hzYOPv8w9R5lgnjXkmlTMho//0Nx3fJXWRxV2DGcn9Vdh36nbk +NReG/j0vR1TcwLn7WkHriSIalKbEHE= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Peter Zijlstra Subject: [PATCH v7 12/14] x86/paravirt: add new macros PVOP_ALT* supporting pvops in ALTERNATIVEs Date: Thu, 11 Mar 2021 15:23:17 +0100 Message-Id: <20210311142319.4723-13-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311142319.4723-1-jgross@suse.com> References: <20210311142319.4723-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using paravirt patching for custom code sequences add support for using ALTERNATIVE handling combined with paravirt call patching. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V3: - drop ____PVOP_ALT_VCALL() macro --- arch/x86/include/asm/paravirt_types.h | 49 ++++++++++++++++++++++++++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 0afdac83f926..0ed976286d49 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -477,44 +477,91 @@ int paravirt_disable_iospace(void); ret; \ }) +#define ____PVOP_ALT_CALL(ret, op, alt, cond, clbr, call_clbr, \ + extra_clbr, ...) \ + ({ \ + PVOP_CALL_ARGS; \ + PVOP_TEST_NULL(op); \ + asm volatile(ALTERNATIVE(paravirt_alt(PARAVIRT_CALL), \ + alt, cond) \ + : call_clbr, ASM_CALL_CONSTRAINT \ + : paravirt_type(op), \ + paravirt_clobber(clbr), \ + ##__VA_ARGS__ \ + : "memory", "cc" extra_clbr); \ + ret; \ + }) + #define __PVOP_CALL(rettype, op, ...) \ ____PVOP_CALL(PVOP_RETVAL(rettype), op, CLBR_ANY, \ PVOP_CALL_CLOBBERS, EXTRA_CLOBBERS, ##__VA_ARGS__) +#define __PVOP_ALT_CALL(rettype, op, alt, cond, ...) \ + ____PVOP_ALT_CALL(PVOP_RETVAL(rettype), op, alt, cond, CLBR_ANY,\ + PVOP_CALL_CLOBBERS, EXTRA_CLOBBERS, \ + ##__VA_ARGS__) + #define __PVOP_CALLEESAVE(rettype, op, ...) \ ____PVOP_CALL(PVOP_RETVAL(rettype), op.func, CLBR_RET_REG, \ PVOP_CALLEE_CLOBBERS, , ##__VA_ARGS__) +#define __PVOP_ALT_CALLEESAVE(rettype, op, alt, cond, ...) \ + ____PVOP_ALT_CALL(PVOP_RETVAL(rettype), op.func, alt, cond, \ + CLBR_RET_REG, PVOP_CALLEE_CLOBBERS, , ##__VA_ARGS__) + + #define __PVOP_VCALL(op, ...) \ (void)____PVOP_CALL(, op, CLBR_ANY, PVOP_VCALL_CLOBBERS, \ VEXTRA_CLOBBERS, ##__VA_ARGS__) +#define __PVOP_ALT_VCALL(op, alt, cond, ...) \ + (void)____PVOP_ALT_CALL(, op, alt, cond, CLBR_ANY, \ + PVOP_VCALL_CLOBBERS, VEXTRA_CLOBBERS, \ + ##__VA_ARGS__) + #define __PVOP_VCALLEESAVE(op, ...) \ (void)____PVOP_CALL(, op.func, CLBR_RET_REG, \ - PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) + PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) +#define __PVOP_ALT_VCALLEESAVE(op, alt, cond, ...) \ + (void)____PVOP_ALT_CALL(, op.func, alt, cond, CLBR_RET_REG, \ + PVOP_VCALLEE_CLOBBERS, , ##__VA_ARGS__) #define PVOP_CALL0(rettype, op) \ __PVOP_CALL(rettype, op) #define PVOP_VCALL0(op) \ __PVOP_VCALL(op) +#define PVOP_ALT_CALL0(rettype, op, alt, cond) \ + __PVOP_ALT_CALL(rettype, op, alt, cond) +#define PVOP_ALT_VCALL0(op, alt, cond) \ + __PVOP_ALT_VCALL(op, alt, cond) #define PVOP_CALLEE0(rettype, op) \ __PVOP_CALLEESAVE(rettype, op) #define PVOP_VCALLEE0(op) \ __PVOP_VCALLEESAVE(op) +#define PVOP_ALT_CALLEE0(rettype, op, alt, cond) \ + __PVOP_ALT_CALLEESAVE(rettype, op, alt, cond) +#define PVOP_ALT_VCALLEE0(op, alt, cond) \ + __PVOP_ALT_VCALLEESAVE(op, alt, cond) #define PVOP_CALL1(rettype, op, arg1) \ __PVOP_CALL(rettype, op, PVOP_CALL_ARG1(arg1)) #define PVOP_VCALL1(op, arg1) \ __PVOP_VCALL(op, PVOP_CALL_ARG1(arg1)) +#define PVOP_ALT_VCALL1(op, arg1, alt, cond) \ + __PVOP_ALT_VCALL(op, alt, cond, PVOP_CALL_ARG1(arg1)) #define PVOP_CALLEE1(rettype, op, arg1) \ __PVOP_CALLEESAVE(rettype, op, PVOP_CALL_ARG1(arg1)) #define PVOP_VCALLEE1(op, arg1) \ __PVOP_VCALLEESAVE(op, PVOP_CALL_ARG1(arg1)) +#define PVOP_ALT_CALLEE1(rettype, op, arg1, alt, cond) \ + __PVOP_ALT_CALLEESAVE(rettype, op, alt, cond, PVOP_CALL_ARG1(arg1)) +#define PVOP_ALT_VCALLEE1(op, arg1, alt, cond) \ + __PVOP_ALT_VCALLEESAVE(op, alt, cond, PVOP_CALL_ARG1(arg1)) #define PVOP_CALL2(rettype, op, arg1, arg2) \ -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96585.182969 (Exim 4.92) (envelope-from ) id 1lKMEG-0004TI-2d; Thu, 11 Mar 2021 14:23:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96585.182969; Thu, 11 Mar 2021 14:23:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMEF-0004T1-Tb; Thu, 11 Mar 2021 14:23:55 +0000 Received: by outflank-mailman (input) for mailman id 96585; Thu, 11 Mar 2021 14:23:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMEE-0003YK-PD for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:54 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1be67360-bbd3-4cd7-b0a8-7e7478990f99; Thu, 11 Mar 2021 14:23:27 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 870FEAEB6; Thu, 11 Mar 2021 14:23:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1be67360-bbd3-4cd7-b0a8-7e7478990f99 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RSQibmup3zrnLnd404UEiSfARcbV249ku40GogSWZBk=; b=ORVur7l1ffgQIWa973Dl69EqAE5b0QNyvl5jhvafSNEwledjdIanxS6sX1p7YfPgZa6W/J 2tRoIu3ZwcyvcJfegDN86dKJKUTnm9KNBFQZWMZyvnK4ivhP2KVBZ0OFG5Umy4OPY8t6d9 OhZhmJzJ/9LPCcWqmQPxWJ3ICHetQuc= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Juergen Gross , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Deep Shah , "VMware, Inc." , Peter Zijlstra Subject: [PATCH v7 13/14] x86/paravirt: switch functions with custom code to ALTERNATIVE Date: Thu, 11 Mar 2021 15:23:18 +0100 Message-Id: <20210311142319.4723-14-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311142319.4723-1-jgross@suse.com> References: <20210311142319.4723-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using paravirt patching for custom code sequences use ALTERNATIVE for the functions with custom code replacements. Instead of patching an ud2 instruction for unpopulated vector entries into the caller site, use a simple function just calling BUG() as a replacement. Simplify the register defines for assembler paravirt calling, as there isn't much usage left. Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V4: - fixed SAVE_FLAGS() (kernel test robot) - added assembler paravirt cleanup --- arch/x86/entry/entry_64.S | 2 +- arch/x86/include/asm/irqflags.h | 2 +- arch/x86/include/asm/paravirt.h | 101 +++++++++++++------------- arch/x86/include/asm/paravirt_types.h | 6 -- arch/x86/kernel/paravirt.c | 16 ++-- arch/x86/kernel/paravirt_patch.c | 88 ---------------------- 6 files changed, 58 insertions(+), 157 deletions(-) diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index 400908dff42e..12e2e3cd58be 100644 --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -305,7 +305,7 @@ SYM_CODE_END(ret_from_fork) .macro DEBUG_ENTRY_ASSERT_IRQS_OFF #ifdef CONFIG_DEBUG_ENTRY pushq %rax - SAVE_FLAGS(CLBR_RAX) + SAVE_FLAGS testl $X86_EFLAGS_IF, %eax jz .Lokay_\@ ud2 diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h index a0efbcd24b86..c5ce9845c999 100644 --- a/arch/x86/include/asm/irqflags.h +++ b/arch/x86/include/asm/irqflags.h @@ -111,7 +111,7 @@ static __always_inline unsigned long arch_local_irq_save(void) #ifdef CONFIG_X86_64 #ifdef CONFIG_DEBUG_ENTRY -#define SAVE_FLAGS(x) pushfq; popq %rax +#define SAVE_FLAGS pushfq; popq %rax #endif #define INTERRUPT_RETURN jmp native_iret diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 913acf7a0ebf..43992e5c52c2 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -135,7 +135,9 @@ static inline void write_cr0(unsigned long x) static inline unsigned long read_cr2(void) { - return PVOP_CALLEE0(unsigned long, mmu.read_cr2); + return PVOP_ALT_CALLEE0(unsigned long, mmu.read_cr2, + "mov %%cr2, %%rax;", + ALT_NOT(X86_FEATURE_XENPV)); } static inline void write_cr2(unsigned long x) @@ -145,12 +147,14 @@ static inline void write_cr2(unsigned long x) static inline unsigned long __read_cr3(void) { - return PVOP_CALL0(unsigned long, mmu.read_cr3); + return PVOP_ALT_CALL0(unsigned long, mmu.read_cr3, + "mov %%cr3, %%rax;", ALT_NOT(X86_FEATURE_XENPV)); } static inline void write_cr3(unsigned long x) { - PVOP_VCALL1(mmu.write_cr3, x); + PVOP_ALT_VCALL1(mmu.write_cr3, x, + "mov %%rdi, %%cr3", ALT_NOT(X86_FEATURE_XENPV)); } static inline void __write_cr4(unsigned long x) @@ -170,7 +174,7 @@ static inline void halt(void) static inline void wbinvd(void) { - PVOP_VCALL0(cpu.wbinvd); + PVOP_ALT_VCALL0(cpu.wbinvd, "wbinvd", ALT_NOT(X86_FEATURE_XENPV)); } static inline u64 paravirt_read_msr(unsigned msr) @@ -384,22 +388,28 @@ static inline void paravirt_release_p4d(unsigned long pfn) static inline pte_t __pte(pteval_t val) { - return (pte_t) { PVOP_CALLEE1(pteval_t, mmu.make_pte, val) }; + return (pte_t) { PVOP_ALT_CALLEE1(pteval_t, mmu.make_pte, val, + "mov %%rdi, %%rax", + ALT_NOT(X86_FEATURE_XENPV)) }; } static inline pteval_t pte_val(pte_t pte) { - return PVOP_CALLEE1(pteval_t, mmu.pte_val, pte.pte); + return PVOP_ALT_CALLEE1(pteval_t, mmu.pte_val, pte.pte, + "mov %%rdi, %%rax", ALT_NOT(X86_FEATURE_XENPV)); } static inline pgd_t __pgd(pgdval_t val) { - return (pgd_t) { PVOP_CALLEE1(pgdval_t, mmu.make_pgd, val) }; + return (pgd_t) { PVOP_ALT_CALLEE1(pgdval_t, mmu.make_pgd, val, + "mov %%rdi, %%rax", + ALT_NOT(X86_FEATURE_XENPV)) }; } static inline pgdval_t pgd_val(pgd_t pgd) { - return PVOP_CALLEE1(pgdval_t, mmu.pgd_val, pgd.pgd); + return PVOP_ALT_CALLEE1(pgdval_t, mmu.pgd_val, pgd.pgd, + "mov %%rdi, %%rax", ALT_NOT(X86_FEATURE_XENPV)); } #define __HAVE_ARCH_PTEP_MODIFY_PROT_TRANSACTION @@ -432,12 +442,15 @@ static inline void set_pmd(pmd_t *pmdp, pmd_t pmd) static inline pmd_t __pmd(pmdval_t val) { - return (pmd_t) { PVOP_CALLEE1(pmdval_t, mmu.make_pmd, val) }; + return (pmd_t) { PVOP_ALT_CALLEE1(pmdval_t, mmu.make_pmd, val, + "mov %%rdi, %%rax", + ALT_NOT(X86_FEATURE_XENPV)) }; } static inline pmdval_t pmd_val(pmd_t pmd) { - return PVOP_CALLEE1(pmdval_t, mmu.pmd_val, pmd.pmd); + return PVOP_ALT_CALLEE1(pmdval_t, mmu.pmd_val, pmd.pmd, + "mov %%rdi, %%rax", ALT_NOT(X86_FEATURE_XENPV)); } static inline void set_pud(pud_t *pudp, pud_t pud) @@ -449,14 +462,16 @@ static inline pud_t __pud(pudval_t val) { pudval_t ret; - ret = PVOP_CALLEE1(pudval_t, mmu.make_pud, val); + ret = PVOP_ALT_CALLEE1(pudval_t, mmu.make_pud, val, + "mov %%rdi, %%rax", ALT_NOT(X86_FEATURE_XENPV)); return (pud_t) { ret }; } static inline pudval_t pud_val(pud_t pud) { - return PVOP_CALLEE1(pudval_t, mmu.pud_val, pud.pud); + return PVOP_ALT_CALLEE1(pudval_t, mmu.pud_val, pud.pud, + "mov %%rdi, %%rax", ALT_NOT(X86_FEATURE_XENPV)); } static inline void pud_clear(pud_t *pudp) @@ -475,14 +490,17 @@ static inline void set_p4d(p4d_t *p4dp, p4d_t p4d) static inline p4d_t __p4d(p4dval_t val) { - p4dval_t ret = PVOP_CALLEE1(p4dval_t, mmu.make_p4d, val); + p4dval_t ret = PVOP_ALT_CALLEE1(p4dval_t, mmu.make_p4d, val, + "mov %%rdi, %%rax", + ALT_NOT(X86_FEATURE_XENPV)); return (p4d_t) { ret }; } static inline p4dval_t p4d_val(p4d_t p4d) { - return PVOP_CALLEE1(p4dval_t, mmu.p4d_val, p4d.p4d); + return PVOP_ALT_CALLEE1(p4dval_t, mmu.p4d_val, p4d.p4d, + "mov %%rdi, %%rax", ALT_NOT(X86_FEATURE_XENPV)); } static inline void __set_pgd(pgd_t *pgdp, pgd_t pgd) @@ -569,7 +587,9 @@ static __always_inline void pv_queued_spin_lock_slowpath(struct qspinlock *lock, static __always_inline void pv_queued_spin_unlock(struct qspinlock *lock) { - PVOP_VCALLEE1(lock.queued_spin_unlock, lock); + PVOP_ALT_VCALLEE1(lock.queued_spin_unlock, lock, + "movb $0, (%%" _ASM_ARG1 ");", + ALT_NOT(X86_FEATURE_PVUNLOCK)); } static __always_inline void pv_wait(u8 *ptr, u8 val) @@ -584,7 +604,9 @@ static __always_inline void pv_kick(int cpu) static __always_inline bool pv_vcpu_is_preempted(long cpu) { - return PVOP_CALLEE1(bool, lock.vcpu_is_preempted, cpu); + return PVOP_ALT_CALLEE1(bool, lock.vcpu_is_preempted, cpu, + "xor %%" _ASM_AX ", %%" _ASM_AX ";", + ALT_NOT(X86_FEATURE_VCPUPREEMPT)); } void __raw_callee_save___native_queued_spin_unlock(struct qspinlock *lock); @@ -658,17 +680,18 @@ bool __raw_callee_save___native_vcpu_is_preempted(long cpu); #ifdef CONFIG_PARAVIRT_XXL static inline notrace unsigned long arch_local_save_flags(void) { - return PVOP_CALLEE0(unsigned long, irq.save_fl); + return PVOP_ALT_CALLEE0(unsigned long, irq.save_fl, "pushf; pop %%rax;", + ALT_NOT(X86_FEATURE_XENPV)); } static inline notrace void arch_local_irq_disable(void) { - PVOP_VCALLEE0(irq.irq_disable); + PVOP_ALT_VCALLEE0(irq.irq_disable, "cli;", ALT_NOT(X86_FEATURE_XENPV)); } static inline notrace void arch_local_irq_enable(void) { - PVOP_VCALLEE0(irq.irq_enable); + PVOP_ALT_VCALLEE0(irq.irq_enable, "sti;", ALT_NOT(X86_FEATURE_XENPV)); } static inline notrace unsigned long arch_local_irq_save(void) @@ -713,35 +736,9 @@ extern void default_banner(void); .popsection -#define COND_PUSH(set, mask, reg) \ - .if ((~(set)) & mask); push %reg; .endif -#define COND_POP(set, mask, reg) \ - .if ((~(set)) & mask); pop %reg; .endif - #ifdef CONFIG_X86_64 #ifdef CONFIG_PARAVIRT_XXL -#define PV_SAVE_REGS(set) \ - COND_PUSH(set, CLBR_RAX, rax); \ - COND_PUSH(set, CLBR_RCX, rcx); \ - COND_PUSH(set, CLBR_RDX, rdx); \ - COND_PUSH(set, CLBR_RSI, rsi); \ - COND_PUSH(set, CLBR_RDI, rdi); \ - COND_PUSH(set, CLBR_R8, r8); \ - COND_PUSH(set, CLBR_R9, r9); \ - COND_PUSH(set, CLBR_R10, r10); \ - COND_PUSH(set, CLBR_R11, r11) -#define PV_RESTORE_REGS(set) \ - COND_POP(set, CLBR_R11, r11); \ - COND_POP(set, CLBR_R10, r10); \ - COND_POP(set, CLBR_R9, r9); \ - COND_POP(set, CLBR_R8, r8); \ - COND_POP(set, CLBR_RDI, rdi); \ - COND_POP(set, CLBR_RSI, rsi); \ - COND_POP(set, CLBR_RDX, rdx); \ - COND_POP(set, CLBR_RCX, rcx); \ - COND_POP(set, CLBR_RAX, rax) - #define PARA_PATCH(off) ((off) / 8) #define PARA_SITE(ptype, ops) _PVSITE(ptype, ops, .quad, 8) #define PARA_INDIRECT(addr) *addr(%rip) @@ -752,12 +749,14 @@ extern void default_banner(void); X86_FEATURE_XENPV, "jmp xen_iret;", "jmp native_iret;") #ifdef CONFIG_DEBUG_ENTRY -#define SAVE_FLAGS(clobbers) \ - PARA_SITE(PARA_PATCH(PV_IRQ_save_fl), \ - PV_SAVE_REGS(clobbers | CLBR_CALLEE_SAVE); \ - ANNOTATE_RETPOLINE_SAFE; \ - call PARA_INDIRECT(pv_ops+PV_IRQ_save_fl); \ - PV_RESTORE_REGS(clobbers | CLBR_CALLEE_SAVE);) +.macro PARA_IRQ_save_fl + PARA_SITE(PARA_PATCH(PV_IRQ_save_fl), + ANNOTATE_RETPOLINE_SAFE; + call PARA_INDIRECT(pv_ops+PV_IRQ_save_fl);) +.endm + +#define SAVE_FLAGS ALTERNATIVE "PARA_IRQ_save_fl;", "pushf; pop %rax;", \ + ALT_NOT(X86_FEATURE_XENPV) #endif #endif /* CONFIG_PARAVIRT_XXL */ #endif /* CONFIG_X86_64 */ diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 0ed976286d49..588ff14ce969 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -3,7 +3,6 @@ #define _ASM_X86_PARAVIRT_TYPES_H /* Bitmask of what can be clobbered: usually at least eax. */ -#define CLBR_NONE 0 #define CLBR_EAX (1 << 0) #define CLBR_ECX (1 << 1) #define CLBR_EDX (1 << 2) @@ -15,7 +14,6 @@ #define CLBR_ARG_REGS (CLBR_EAX | CLBR_EDX | CLBR_ECX) #define CLBR_RET_REG (CLBR_EAX | CLBR_EDX) -#define CLBR_SCRATCH (0) #else #define CLBR_RAX CLBR_EAX #define CLBR_RCX CLBR_ECX @@ -32,12 +30,9 @@ #define CLBR_ARG_REGS (CLBR_RDI | CLBR_RSI | CLBR_RDX | \ CLBR_RCX | CLBR_R8 | CLBR_R9) #define CLBR_RET_REG (CLBR_RAX) -#define CLBR_SCRATCH (CLBR_R10 | CLBR_R11) #endif /* X86_64 */ -#define CLBR_CALLEE_SAVE ((CLBR_ARG_REGS | CLBR_SCRATCH) & ~CLBR_RET_REG) - #ifndef __ASSEMBLY__ #include @@ -322,7 +317,6 @@ extern void (*paravirt_iret)(void); /* Simple instruction patching code. */ #define NATIVE_LABEL(a,x,b) "\n\t.globl " a #x "_" #b "\n" a #x "_" #b ":\n\t" -unsigned paravirt_patch_ident_64(void *insn_buff, unsigned len); unsigned paravirt_patch_default(u8 type, void *insn_buff, unsigned long addr, unsigned len); unsigned paravirt_patch_insns(void *insn_buff, unsigned len, const char *start, const char *end); diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 9b0f568b0200..855ae08a05a1 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -53,7 +53,10 @@ void __init default_banner(void) } /* Undefined instruction for dealing with missing ops pointers. */ -static const unsigned char ud2a[] = { 0x0f, 0x0b }; +static void paravirt_BUG(void) +{ + BUG(); +} struct branch { unsigned char opcode; @@ -107,17 +110,10 @@ unsigned paravirt_patch_default(u8 type, void *insn_buff, unsigned ret; if (opfunc == NULL) - /* If there's no function, patch it with a ud2a (BUG) */ - ret = paravirt_patch_insns(insn_buff, len, ud2a, ud2a+sizeof(ud2a)); + /* If there's no function, patch it with paravirt_BUG() */ + ret = paravirt_patch_call(insn_buff, paravirt_BUG, addr, len); else if (opfunc == _paravirt_nop) ret = 0; - -#ifdef CONFIG_PARAVIRT_XXL - /* identity functions just return their single argument */ - else if (opfunc == _paravirt_ident_64) - ret = paravirt_patch_ident_64(insn_buff, len); - -#endif else /* Otherwise call the function. */ ret = paravirt_patch_call(insn_buff, opfunc, addr, len); diff --git a/arch/x86/kernel/paravirt_patch.c b/arch/x86/kernel/paravirt_patch.c index abd27ec67397..10543dcc8211 100644 --- a/arch/x86/kernel/paravirt_patch.c +++ b/arch/x86/kernel/paravirt_patch.c @@ -4,96 +4,8 @@ #include #include -#define PSTART(d, m) \ - patch_data_##d.m - -#define PEND(d, m) \ - (PSTART(d, m) + sizeof(patch_data_##d.m)) - -#define PATCH(d, m, insn_buff, len) \ - paravirt_patch_insns(insn_buff, len, PSTART(d, m), PEND(d, m)) - -#define PATCH_CASE(ops, m, data, insn_buff, len) \ - case PARAVIRT_PATCH(ops.m): \ - return PATCH(data, ops##_##m, insn_buff, len) - -#ifdef CONFIG_PARAVIRT_XXL -struct patch_xxl { - const unsigned char irq_irq_disable[1]; - const unsigned char irq_irq_enable[1]; - const unsigned char irq_save_fl[2]; - const unsigned char mmu_read_cr2[3]; - const unsigned char mmu_read_cr3[3]; - const unsigned char mmu_write_cr3[3]; - const unsigned char cpu_wbinvd[2]; - const unsigned char mov64[3]; -}; - -static const struct patch_xxl patch_data_xxl = { - .irq_irq_disable = { 0xfa }, // cli - .irq_irq_enable = { 0xfb }, // sti - .irq_save_fl = { 0x9c, 0x58 }, // pushf; pop %[re]ax - .mmu_read_cr2 = { 0x0f, 0x20, 0xd0 }, // mov %cr2, %[re]ax - .mmu_read_cr3 = { 0x0f, 0x20, 0xd8 }, // mov %cr3, %[re]ax - .mmu_write_cr3 = { 0x0f, 0x22, 0xdf }, // mov %rdi, %cr3 - .cpu_wbinvd = { 0x0f, 0x09 }, // wbinvd - .mov64 = { 0x48, 0x89, 0xf8 }, // mov %rdi, %rax -}; - -unsigned int paravirt_patch_ident_64(void *insn_buff, unsigned int len) -{ - return PATCH(xxl, mov64, insn_buff, len); -} -# endif /* CONFIG_PARAVIRT_XXL */ - -#ifdef CONFIG_PARAVIRT_SPINLOCKS -struct patch_lock { - unsigned char queued_spin_unlock[3]; - unsigned char vcpu_is_preempted[2]; -}; - -static const struct patch_lock patch_data_lock = { - .vcpu_is_preempted = { 0x31, 0xc0 }, // xor %eax, %eax - -# ifdef CONFIG_X86_64 - .queued_spin_unlock = { 0xc6, 0x07, 0x00 }, // movb $0, (%rdi) -# else - .queued_spin_unlock = { 0xc6, 0x00, 0x00 }, // movb $0, (%eax) -# endif -}; -#endif /* CONFIG_PARAVIRT_SPINLOCKS */ - unsigned int native_patch(u8 type, void *insn_buff, unsigned long addr, unsigned int len) { - switch (type) { - -#ifdef CONFIG_PARAVIRT_XXL - PATCH_CASE(irq, save_fl, xxl, insn_buff, len); - PATCH_CASE(irq, irq_enable, xxl, insn_buff, len); - PATCH_CASE(irq, irq_disable, xxl, insn_buff, len); - - PATCH_CASE(mmu, read_cr2, xxl, insn_buff, len); - PATCH_CASE(mmu, read_cr3, xxl, insn_buff, len); - PATCH_CASE(mmu, write_cr3, xxl, insn_buff, len); - - PATCH_CASE(cpu, wbinvd, xxl, insn_buff, len); -#endif - -#ifdef CONFIG_PARAVIRT_SPINLOCKS - case PARAVIRT_PATCH(lock.queued_spin_unlock): - if (pv_is_native_spin_unlock()) - return PATCH(lock, queued_spin_unlock, insn_buff, len); - break; - - case PARAVIRT_PATCH(lock.vcpu_is_preempted): - if (pv_is_native_vcpu_is_preempted()) - return PATCH(lock, vcpu_is_preempted, insn_buff, len); - break; -#endif - default: - break; - } - return paravirt_patch_default(type, insn_buff, addr, len); } -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:23:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:23:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96586.182976 (Exim 4.92) (envelope-from ) id 1lKMEG-0004UB-Jt; Thu, 11 Mar 2021 14:23:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96586.182976; Thu, 11 Mar 2021 14:23:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMEG-0004Tq-9S; Thu, 11 Mar 2021 14:23:56 +0000 Received: by outflank-mailman (input) for mailman id 96586; Thu, 11 Mar 2021 14:23:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMEF-0003YP-1f for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:23:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1913793a-6d5f-44d8-8116-55c006ffdd1e; Thu, 11 Mar 2021 14:23:27 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DCB1DAEB9; Thu, 11 Mar 2021 14:23:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1913793a-6d5f-44d8-8116-55c006ffdd1e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615472607; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xvXQTESbVUUOQpFJd4LhMV3VKc6mx7G3lPEDouvn7/Q=; b=A2MqvoaMzklSqcNTeBXk2kflS403fWIJC9sIvKki9e7vDRDj/KTOuCpv4Z+584oPSA5ATI 3F++3hvQYEWrizvNx61DF752xGRQ0M17sWCHmk5ZlIfACe2Cywo8BhCPZoSs+kXwGZdmdu e24EKv/4wiw5ZPf9k6THVpERSo1huRs= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Deep Shah , "VMware, Inc." , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Boris Ostrovsky , Stefano Stabellini , Peter Zijlstra Subject: [PATCH v7 14/14] x86/paravirt: have only one paravirt patch function Date: Thu, 11 Mar 2021 15:23:19 +0100 Message-Id: <20210311142319.4723-15-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311142319.4723-1-jgross@suse.com> References: <20210311142319.4723-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There is no need any longer to have different paravirt patch functions for native and Xen. Eliminate native_patch() and rename paravirt_patch_default() to paravirt_patch(). Signed-off-by: Juergen Gross Acked-by: Peter Zijlstra (Intel) --- V3: - remove paravirt_patch_insns() (kernel test robot) --- arch/x86/include/asm/paravirt_types.h | 19 +------------------ arch/x86/kernel/Makefile | 3 +-- arch/x86/kernel/alternative.c | 2 +- arch/x86/kernel/paravirt.c | 20 ++------------------ arch/x86/kernel/paravirt_patch.c | 11 ----------- arch/x86/xen/enlighten_pv.c | 1 - 6 files changed, 5 insertions(+), 51 deletions(-) delete mode 100644 arch/x86/kernel/paravirt_patch.c diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 588ff14ce969..9d1ddb7b4350 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -68,19 +68,6 @@ struct pv_info { const char *name; }; -struct pv_init_ops { - /* - * Patch may replace one of the defined code sequences with - * arbitrary code, subject to the same register constraints. - * This generally means the code is not free to clobber any - * registers other than EAX. The patch function should return - * the number of bytes of code generated, as we nop pad the - * rest in generic code. - */ - unsigned (*patch)(u8 type, void *insn_buff, - unsigned long addr, unsigned len); -} __no_randomize_layout; - #ifdef CONFIG_PARAVIRT_XXL struct pv_lazy_ops { /* Set deferred update mode, used for batching operations. */ @@ -276,7 +263,6 @@ struct pv_lock_ops { * number for each function using the offset which we use to indicate * what to patch. */ struct paravirt_patch_template { - struct pv_init_ops init; struct pv_cpu_ops cpu; struct pv_irq_ops irq; struct pv_mmu_ops mmu; @@ -317,10 +303,7 @@ extern void (*paravirt_iret)(void); /* Simple instruction patching code. */ #define NATIVE_LABEL(a,x,b) "\n\t.globl " a #x "_" #b "\n" a #x "_" #b ":\n\t" -unsigned paravirt_patch_default(u8 type, void *insn_buff, unsigned long addr, unsigned len); -unsigned paravirt_patch_insns(void *insn_buff, unsigned len, const char *start, const char *end); - -unsigned native_patch(u8 type, void *insn_buff, unsigned long addr, unsigned len); +unsigned int paravirt_patch(u8 type, void *insn_buff, unsigned long addr, unsigned int len); int paravirt_disable_iospace(void); diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile index 2ddf08351f0b..0704c2a94272 100644 --- a/arch/x86/kernel/Makefile +++ b/arch/x86/kernel/Makefile @@ -35,7 +35,6 @@ KASAN_SANITIZE_sev-es.o := n KCSAN_SANITIZE := n OBJECT_FILES_NON_STANDARD_test_nx.o := y -OBJECT_FILES_NON_STANDARD_paravirt_patch.o := y ifdef CONFIG_FRAME_POINTER OBJECT_FILES_NON_STANDARD_ftrace_$(BITS).o := y @@ -121,7 +120,7 @@ obj-$(CONFIG_AMD_NB) += amd_nb.o obj-$(CONFIG_DEBUG_NMI_SELFTEST) += nmi_selftest.o obj-$(CONFIG_KVM_GUEST) += kvm.o kvmclock.o -obj-$(CONFIG_PARAVIRT) += paravirt.o paravirt_patch.o +obj-$(CONFIG_PARAVIRT) += paravirt.o obj-$(CONFIG_PARAVIRT_SPINLOCKS)+= paravirt-spinlocks.o obj-$(CONFIG_PARAVIRT_CLOCK) += pvclock.o obj-$(CONFIG_X86_PMEM_LEGACY_DEVICE) += pmem.o diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index 76ad4ce454c0..f810e6fececd 100644 --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -616,7 +616,7 @@ void __init_or_module apply_paravirt(struct paravirt_patch_site *start, BUG_ON(p->len > MAX_PATCH_LEN); /* prep the buffer with the original instructions */ memcpy(insn_buff, p->instr, p->len); - used = pv_ops.init.patch(p->type, insn_buff, (unsigned long)p->instr, p->len); + used = paravirt_patch(p->type, insn_buff, (unsigned long)p->instr, p->len); BUG_ON(used > p->len); diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 855ae08a05a1..d0730264786b 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -99,8 +99,8 @@ void __init native_pv_lock_init(void) static_branch_disable(&virt_spin_lock_key); } -unsigned paravirt_patch_default(u8 type, void *insn_buff, - unsigned long addr, unsigned len) +unsigned int paravirt_patch(u8 type, void *insn_buff, unsigned long addr, + unsigned int len) { /* * Neat trick to map patch type back to the call within the @@ -121,19 +121,6 @@ unsigned paravirt_patch_default(u8 type, void *insn_buff, return ret; } -unsigned paravirt_patch_insns(void *insn_buff, unsigned len, - const char *start, const char *end) -{ - unsigned insn_len = end - start; - - /* Alternative instruction is too large for the patch site and we cannot continue: */ - BUG_ON(insn_len > len || start == NULL); - - memcpy(insn_buff, start, insn_len); - - return insn_len; -} - struct static_key paravirt_steal_enabled; struct static_key paravirt_steal_rq_enabled; @@ -252,9 +239,6 @@ struct pv_info pv_info = { #define PTE_IDENT __PV_IS_CALLEE_SAVE(_paravirt_ident_64) struct paravirt_patch_template pv_ops = { - /* Init ops. */ - .init.patch = native_patch, - /* Cpu ops. */ .cpu.io_delay = native_io_delay, diff --git a/arch/x86/kernel/paravirt_patch.c b/arch/x86/kernel/paravirt_patch.c deleted file mode 100644 index 10543dcc8211..000000000000 --- a/arch/x86/kernel/paravirt_patch.c +++ /dev/null @@ -1,11 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -#include - -#include -#include - -unsigned int native_patch(u8 type, void *insn_buff, unsigned long addr, - unsigned int len) -{ - return paravirt_patch_default(type, insn_buff, addr, len); -} diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 08dca7bebb30..4f18cd9eacd8 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -1231,7 +1231,6 @@ asmlinkage __visible void __init xen_start_kernel(void) /* Install Xen paravirt ops */ pv_info = xen_info; - pv_ops.init.patch = paravirt_patch_default; pv_ops.cpu = xen_cpu_ops; paravirt_iret = xen_iret; xen_init_irq_ops(); -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:36:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:36:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96626.182994 (Exim 4.92) (envelope-from ) id 1lKMQn-0006JA-AH; Thu, 11 Mar 2021 14:36:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96626.182994; Thu, 11 Mar 2021 14:36:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMQn-0006J3-72; Thu, 11 Mar 2021 14:36:53 +0000 Received: by outflank-mailman (input) for mailman id 96626; Thu, 11 Mar 2021 14:36:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMQl-0006Iy-J1 for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:36:51 +0000 Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0a9081c6-ab3b-48ad-a9a4-afd4858f93e5; Thu, 11 Mar 2021 14:36:50 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12BEU8Ri146808; Thu, 11 Mar 2021 14:36:48 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 37415rese8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Mar 2021 14:36:48 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12BETWmh122821; Thu, 11 Mar 2021 14:36:47 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2169.outbound.protection.outlook.com [104.47.59.169]) by userp3030.oracle.com with ESMTP id 374kp11vwr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Mar 2021 14:36:47 +0000 Received: from MN2PR10MB3293.namprd10.prod.outlook.com (2603:10b6:208:12b::24) by MN2PR10MB3422.namprd10.prod.outlook.com (2603:10b6:208:122::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.29; Thu, 11 Mar 2021 14:36:45 +0000 Received: from MN2PR10MB3293.namprd10.prod.outlook.com ([fe80::b87b:5cdc:87f4:c465]) by MN2PR10MB3293.namprd10.prod.outlook.com ([fe80::b87b:5cdc:87f4:c465%6]) with mapi id 15.20.3912.030; Thu, 11 Mar 2021 14:36:45 +0000 Received: from [192.168.1.195] (73.249.50.119) by BL0PR05CA0005.namprd05.prod.outlook.com (2603:10b6:208:91::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.10 via Frontend Transport; Thu, 11 Mar 2021 14:36:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a9081c6-ab3b-48ad-a9a4-afd4858f93e5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=UavA2wqND9y6nzkF8zXRP5+tk1GLuopQ3xvifXYh5/0=; b=L0gkuHf8yV+1yAewy6PULwZlfVqoWz3tGrvwTSKmriHBcFj2XhBGCkTKO1KkCplY4Oi4 mCrHUky9nKvAqHP+a+5InOvWCC/ZZsC5aFwYLHJ1dMvV/ELQmKXLfYs14wTicSXNrFJz ELVqVkPAzzHzY5EvfoORpD/z19hgbDhahQtNoIzOCe6bxb66rs4MOOwFnWyqFZOkKnd0 8U2mslxhdIAYAOW9+jnH0IEpFFWxSwpxNu/V9yKyCnANxlA4hQbOq+E8ng3XCQeMDqfk VXyh1lAFPNaUrJHVHhtHJcg7KLtehH2U2J2ttFZ5WG1OxxsA9a79Q9MyiPec9+9b9P07 ww== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d9sUNBTrWkg5V5hWC3oKNdfRXVm8EemAp9zGAVrcBK2tBnFZRLwN19ZWKqL3+xDsBcByZYPbYf01Sp8sRFj+LXvFlkdO6UagC+zfLAjK/pQurJgy5tcNFPCoTBqY+O96vcF+M7PoD0XCU8zdtJciOc31QgxGdL5lnJEyWeHtFu8veX8PxsR9wJrn5gQmlhZDpQW6OtGqEyTUzA4MwEnczNk2k/yolxib+YKbgGm5bb5FJKcDQkRbG4g/st2lAjKzEdrhpxf2ndHwz11N7e/q5dmG57tgV9utMh7n/YJQ23MO4my4aIzGT/HETzzx5Hojgh47xiqRAfP6CWnfDtfgUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UavA2wqND9y6nzkF8zXRP5+tk1GLuopQ3xvifXYh5/0=; b=CcWyGvesGvB3/T+2ULnrWCq37b+A+IpQ+EOy50o/3PwUMJ/qpvKSU4WipFyvVyi6LSktml5hGgc/FVy2Br7F9gVcaDcY6G7B1S/wYDU8Bvdc3IVDlcdP+6v8MUtEtUOLXruL1u/e7vmOV4k4CRi7IfO5pLACe7ptHCy7HjDsXTGQr1FNeuOeDLL2gzmQ30q+3WMCCVmXb9SSuU2mAhwEJyvaHRK+LtJpCLJRQuQVoopFBWS6280JlJz3KXdh2snrDDLTI6oJRnJ8QG33u/9ifTLo/ezYqnzp4rYohWkaRhEZMmu38MU7V0OmyDbLY3dfUjfTy2ZKOoPkk0KpqNJKsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UavA2wqND9y6nzkF8zXRP5+tk1GLuopQ3xvifXYh5/0=; b=zkKWUu+T1ROPRleyqi642glkitsBl80rCCbj4yKN2DBgz3kRpjQ9/R8kktzDkp/Wmjd1CYxPAkSsEvNiivKABF4+l7ehuWqNzBcwlzFC4QQtRjNFTyes5zvROcZQ9qhCCYvK2r6NvDKXcED0d6uTL8v1ETHRyBIqaW6bgX9RbBo= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH v4 0/3] xen/events: bug fixes and some diagnostic aids To: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Stefano Stabellini , stable@vger.kernel.org References: <20210306161833.4552-1-jgross@suse.com> From: Boris Ostrovsky Message-ID: <5c495bcf-80bc-d512-6ea3-48f3ec75bb35@oracle.com> Date: Thu, 11 Mar 2021 09:36:43 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <20210306161833.4552-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [73.249.50.119] X-ClientProxiedBy: BL0PR05CA0005.namprd05.prod.outlook.com (2603:10b6:208:91::15) To MN2PR10MB3293.namprd10.prod.outlook.com (2603:10b6:208:12b::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f22a9807-d45a-49df-ce4d-08d8e49b1841 X-MS-TrafficTypeDiagnostic: MN2PR10MB3422: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GWqJDO4U29aSyegE8oehYK3lsuemubYN2ABoprZIhbIXoY7GEgX20AXt7vrqQ3Vy3Q95mkMO5D1xJ/5Vb9eeVuFEdyqyrKYus1rbIgEenMNtp3+qg+JOLTEBciFhg1MRUYESjL7C/ZMleKgSR/eFs0XA4VP4rAJhwidgsSpN+vA8zOCgnoDPr8AXsKTtcoTyj3KE67GUOAPxmSfkvjwBVCxuXbd3scTDCLg272w9Fc8e4BrEYSDsKgxmd9pC/JnrWM2iQYuKVqYsDED6Smv5o4yVMPk2oPBQ3TiQ447H7XjPy5MmxcCaz0Omb8LErGVMck4BD8sh99Es2f3YBGDIENMhlaWP/B9cj1gpvn/cQkzIOZodu+kW5YPfbydGgdgv5QFyytbKL/5+QOVL1suYpPxafPBeEw5MsGl1Gm7uIigqg7K2aX+yYTseDHG4E7UP8TgAnEIWJce9lZXku/qwGyhfdnAFgUSWtmX/pKB0jecWDOOA3yDydcA0bAxnVePW3aAolzCJYPCHiTLcH4TK0wI5vNDRWSOHjL6PbjGw9fId3t1h3Lif/SKoZwDCMNjZ3LqWwYJ4uf2DASB579+wqMER89yRxyUKM+InC6XVtg0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3293.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(396003)(136003)(346002)(376002)(5660300002)(8676002)(36756003)(16576012)(8936002)(2616005)(83380400001)(956004)(4326008)(86362001)(478600001)(4744005)(31696002)(6486002)(16526019)(316002)(44832011)(2906002)(186003)(53546011)(66946007)(66476007)(31686004)(66556008)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VHpYOUs4cGhMWDFxRTZDZjZWR1gyTlk5OVd5OGIyQ3VGQWNFTjFpK011Y0Er?= =?utf-8?B?K05oWWFWNnI2azZFZENSMDd5MmcwSjlGZ3Bxd3R6QXlhZzN3TTY4UG9aY20r?= =?utf-8?B?eWRTNE93a2dBMkc3TkY4WUJKRitvM1R5SjFPbTExamxpbzBHZVZTdTlqOE9n?= =?utf-8?B?L29yUFQvT0l4OEwyRUUzNS9RSlZGOEtuTHBjSFIxTXVmS1dkM1ZXc3V1Y3BR?= =?utf-8?B?dlEza25TZWRyZHVKNXNUaUM2TXhBU05xYzAwWEE5S2lFY0xISll2VEhnSkxO?= =?utf-8?B?S0RrYWlKeFNVeUJsbU52VDR2MmhBcUtPMEsxT3RFaTZJWFhFOEh3cXRtUmw1?= =?utf-8?B?Q2JlRjF6b0h0c25Rbk1BcjN0bWQ4U2xKUGh4azNkYzdJcG5HZVM3cUFQbjdx?= =?utf-8?B?UStidDRLNmZkNllqdDBVaEZkWUJITlFOTEpRckVCMXRLakNVWlBBaGdEOFh3?= =?utf-8?B?U25ITUx3RytoQ1lybWpzd1hVTmVQZ1pjWitpa3hVQ0puKy9Pb21tbzN6OGtz?= =?utf-8?B?UWdsTno0V0JCSGQweTRGV2ptZDc1V3JNNzBTWFlDUm10RUNOMk96WHRsUlNr?= =?utf-8?B?OFo4TXh4TjJKTkUvTWdjdnZHQmwzVXM4eHIrdkRyN3RpdE5BTzJsb05Zam5t?= =?utf-8?B?dVpsMmkyMzYvR0YwT2FUZ1hYWjg5Qno1b2pZSmZXamdtQWpOMCtINWgwV21K?= =?utf-8?B?YWx3aHJkOWpnT3dkOUUvM0JMcjEvays0VlRHRlBUZ3NTa2w4Um9hdE1tYlNo?= =?utf-8?B?VUZVQ1lFemFLK2UxTG1ZOEhWTURYbDlPTi9UQ3VHV3RtRmo4V2dDT2RhSFJC?= =?utf-8?B?Y0xZUmk2N0FTMEhKUXJ6UnptVXBJT1BTMk0yOEJpdXlGZnE0d2JpSklMWVZR?= =?utf-8?B?SjVnNTlJK2tGd1I1cWtWbnprdUg4a3ArMVpqRmFmcDRVck9vdHlsZ3pjYk91?= =?utf-8?B?cTdUS0trRzl6d3JRZkNjOTRnUmdLSi9nS0ZiRU9CcVE3WG05Q3Zzekc0WFVl?= =?utf-8?B?eVA0R0ZhMkFBZTFGUWhIWWpyYUVVS1h4eVRKWm9rRngyNTJjdGJrN3pWVTdR?= =?utf-8?B?dFBQUGo0QjYvcCtVcTBiZVAxWkFIS1lFazBMZTdpUXc1UjlSL09sckdUNTFm?= =?utf-8?B?aCs1Q2NZNmZrd2p5NFlUOUwzK3JtUHVFNWdSbEphN3h5QjdJWit2T1dLT0R2?= =?utf-8?B?eldsNUVzZUlTTG9zemFBTkFuRW5xNjVwTk1UMEd3cThEWDB1RFJIeTRnakZu?= =?utf-8?B?UFVIZ2tpdUpuRzhRV2hjMDREUElQdkFQQm4wemRYZW9qSlBObFEydk5hdkhV?= =?utf-8?B?TXN5RVY4cnNUbDNZU24veExYRTFJQ3dZRlhuRzhqRjBpRFZHQ0wrQmhTVWxJ?= =?utf-8?B?eVFXSTZkTW9qd1ZTbkRmM1J5VFNvTkZTdnFNL3c1a3JKeGRFaFB6bkpBTkUw?= =?utf-8?B?V2dsTU1ZYnNLc1QzUVJlbGh0MlY3dlZPSHFMZjJyeXM2NWY4Nm9PVXVJbkxJ?= =?utf-8?B?elVhMElIbXVVUG52UHRDaWJ6SlNUUnpNcFFDaVl1cVI4amRGcWszVnRVSGl2?= =?utf-8?B?dnJlVlUzMXI5QnF2V1U3Snh1NTMybjAvOVNNL0VKbXRmeTZ6UUxOL3Y5TDNS?= =?utf-8?B?Qmc4MVBhbVJla3ZuMWNWU3BMUXFmbitUOUVVVUIyQlpUNlZUTk9za0RjcGhl?= =?utf-8?B?aHFXaWduUHRqZ0NYY3FJUEtHcElTODN1Sng1WkdwaWJBajU2bWRYZnh2cGt2?= =?utf-8?Q?NZLBt+fAHBgzDx3EDmRIsWnuk5BvWc6PB8+MVCa?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f22a9807-d45a-49df-ce4d-08d8e49b1841 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3293.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 14:36:45.3653 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ss1sm+BVvAgqFaIvUmVkJTc9Wn2uSGtvkwk7zWvXSpUjUqfum3rInLGCvsyz33jHDsmZXbPXxCNoAC/eDiqf80cWghI30HAb9UAXuBYMDwY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3422 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9920 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103110079 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9920 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103110079 On 3/6/21 11:18 AM, Juergen Gross wrote: > Those are fixes for XSA-332. > > The rest of the V3 patches have been applied already. There is one > additional fix in patch 2 which addresses network outages when a guest > is doing reboot loops. > > Juergen Gross (3): > xen/events: reset affinity of 2-level event when tearing it down > xen/events: don't unmask an event channel when an eoi is pending > xen/events: avoid handling the same event on two cpus at the same time > > drivers/xen/events/events_2l.c | 22 +++-- > drivers/xen/events/events_base.c | 130 ++++++++++++++++++++------- > drivers/xen/events/events_fifo.c | 7 -- > drivers/xen/events/events_internal.h | 14 +-- > 4 files changed, 123 insertions(+), 50 deletions(-) Applied to for-linus-5.12b From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:37:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:37:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96629.183006 (Exim 4.92) (envelope-from ) id 1lKMRW-0006PT-Kl; Thu, 11 Mar 2021 14:37:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96629.183006; Thu, 11 Mar 2021 14:37:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMRW-0006PM-HL; Thu, 11 Mar 2021 14:37:38 +0000 Received: by outflank-mailman (input) for mailman id 96629; Thu, 11 Mar 2021 14:37:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMRV-0006PH-Lt for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:37:37 +0000 Received: from aserp2120.oracle.com (unknown [141.146.126.78]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 822958ce-4c90-4443-ab8b-5e535ed50479; Thu, 11 Mar 2021 14:37:37 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12BESl2E146795; Thu, 11 Mar 2021 14:37:35 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 3741pmpsh8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Mar 2021 14:37:35 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12BETWHN122781; Thu, 11 Mar 2021 14:37:34 GMT Received: from nam04-sn1-obe.outbound.protection.outlook.com (mail-sn1nam04lp2055.outbound.protection.outlook.com [104.47.44.55]) by userp3030.oracle.com with ESMTP id 374kp11wry-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Mar 2021 14:37:34 +0000 Received: from MN2PR10MB3293.namprd10.prod.outlook.com (2603:10b6:208:12b::24) by BLAPR10MB4945.namprd10.prod.outlook.com (2603:10b6:208:324::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Thu, 11 Mar 2021 14:37:32 +0000 Received: from MN2PR10MB3293.namprd10.prod.outlook.com ([fe80::b87b:5cdc:87f4:c465]) by MN2PR10MB3293.namprd10.prod.outlook.com ([fe80::b87b:5cdc:87f4:c465%6]) with mapi id 15.20.3912.030; Thu, 11 Mar 2021 14:37:32 +0000 Received: from [192.168.1.195] (73.249.50.119) by BL0PR05CA0012.namprd05.prod.outlook.com (2603:10b6:208:91::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.10 via Frontend Transport; Thu, 11 Mar 2021 14:37:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 822958ce-4c90-4443-ab8b-5e535ed50479 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=3NS4yUqw+3HoqkMmybE3gAKIvPDqi+pADhxYp1kKi28=; b=xvD30eAj0p+whvR/ietWMy9guwR5l34Px/fNG2S06aQvWcXxA9w3Cfsoqh0UDCZf6ji4 u3lvHyy1bpb1zFNM1Qp8GNOgV5jnVid9gOKog3ZGIxauyrWCxQO90V0Bn7T/nnE5RM/C Cq/XlMQmheZGrrAcxZ560OMSbpk5UlV5+vZEuWGLyKUkvddpdc8uE+n5zfr2qfEfAjZp LLUrvyCvP+zDgLZVf5rfvJXmkHtEH7v5eou3KNPDxOuVb6FT35/TaoMc8bcEDqhHjOgP DaIzUV6kVET+/S0mL3BEIJNDLQEB2a+CUZP8HHef+y6JHhKPxLlLoSx1lctZ58a72NhE Mg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P96evmk9CE3qXZNNDnnWW/k+U8WHvXCz5ftpqWVY8IV7WcWatx8QntOVSlOr0aG/a9eXYzbQc2F+8VzfCm7ZbkpPce/QHPOediAqSgTjH4wJQkRwj70fAF2a3guWrvu6FT3Ljo2jcdR8zZN8fHSQN0g7He+JSFEBkgEUFn7sAglbBHKGzOfLIwtDyMDhCtMb73n7tBkIsANKIQkx1tvgG9ihUupo9bd0zCXvwV3HQt2MiQ+pCYwIIUhkVUgwUbuv/20uoCqw5kN8SPx74F08SZE7oEcbEtQc4wY+JlBRQ4hXrM+DfUV1uasPPbxPPhZccinJ9+18jjItfwMBgsIG+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3NS4yUqw+3HoqkMmybE3gAKIvPDqi+pADhxYp1kKi28=; b=h/sAsjjF5XU87m9yJPZeksnUoWQ8qlZRjnfTjqemgtMN155Jwt4iTtXEg5FBivPYjeY0tcZhe3WFYxUBIE7I5bj3OcMU0JVtNyNrYWJwwGSrRsmEZMnN5pjZZLONOFahL4a1UtU+EVzQ+nRAIIXpZs7oWVsOAIEHzwegtMm1Kf9mAVh7n+RCMqTsouprW8vubTk2f9gC8ilWDAKDFviYkGAlgk6E/N3kDIEOCw7xX4bKH/t0PH/Sook+Gy0edlXaD8MfXPqd9rGmzd6lPSOLIHSdAqg6Ud7J3m3MAtBduo07+78FlEqsTbk9Py2fGFraKgLMiWVsLGzLnaGKeyipKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3NS4yUqw+3HoqkMmybE3gAKIvPDqi+pADhxYp1kKi28=; b=qnSO2Ls/k+IVld9mD8Bqc/L1zx838CRDHTpvzgRdHnum5ktB5WHlrtn5lsOUdaiIzXmax5awKJSBgSikQjkDNMMZVKy+jGUn6z7jmzbnwN4jVzR1Iv558VH2yPvJb1ydRhNbnHoFrBir1zpy9+Bt/GiyaLAjvsMSxhrH+5wopCU= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH] Xen: drop exports of {set,clear}_foreign_p2m_mapping() To: Jan Beulich , Juergen Gross , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" References: <746a5cd6-1446-eda4-8b23-03c1cac30b8d@suse.com> From: Boris Ostrovsky Message-ID: <063d7e77-c38d-7eb2-c129-ba5a0950c985@oracle.com> Date: Thu, 11 Mar 2021 09:37:31 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <746a5cd6-1446-eda4-8b23-03c1cac30b8d@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [73.249.50.119] X-ClientProxiedBy: BL0PR05CA0012.namprd05.prod.outlook.com (2603:10b6:208:91::22) To MN2PR10MB3293.namprd10.prod.outlook.com (2603:10b6:208:12b::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4c0eeff-19a6-49b9-fae9-08d8e49b345e X-MS-TrafficTypeDiagnostic: BLAPR10MB4945: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tnq+nQFCnk7uh5KUcTpg7hHfTIOJT4dFOu4gZSVzJNQWlIe/wEs8ut+sTn1fCQ4Dzudmdwu+TcNPCUywj3mj4lVyn3sHnkPh6U75BbVqWsZV+Yy+sin4XMFbZbyEYeXvpabi77hU10/0HzhX0wPsAa3NJbkzA6VpDESmriLmEcO/Dd7RYg9ZH3AuEoWdZu+WoNiSE7hg6YdK1fcSwo/4wfqZl3WWmYCO4/jgyGznEjlpcDEU2EGRhPcDsWhrCmoVlcvZaFI9f9CZEcXQsbHe17f7MlQL2P6Bt9DgYHeSPS95zyLUtXyuWOQuD346+V3pnOozbi++z7FdWF1NDSJY2wkkrkZVmJrcoFTOmMCE7zGHET9mvYc5rr7Ovn/dnJFPEAQwyn8r35zGoReJbP72bNw94QF9ygjUnibaNakeDOfE9sQtHqAbRoWTnS1v2wp55Y6eiQjG293r9MPU6+mdikYVgC9TcRFKTCbb+BDRGKQ1GE19jxwiUmhXKJMoFRbOZ87Y9RJFpSz+UHGiGarXBgrYaYW7YEB56OBkW0CLg0PSah6aT7NmL+6PF/30aHurnDsSHyeaS9kq6w4EIKDwf9qmfv89sVl5EcZZlb/Pem8u+9ctc4BNWO2la+QfnDFZoFkn8NWX/ePm5vSoTv1ZiIZpbzAy1/MC9h4SJpkhQbVtgA6Crx3l71/sjf8GyRqd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3293.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(366004)(346002)(136003)(396003)(39860400002)(16576012)(316002)(8936002)(31696002)(36756003)(44832011)(4326008)(4744005)(86362001)(6486002)(31686004)(186003)(5660300002)(478600001)(53546011)(110136005)(66946007)(66556008)(26005)(956004)(2616005)(8676002)(2906002)(66476007)(16526019)(70780200001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YWtWR3hObUNndmdFZnJuZjljOGxGVFJQZkJicld2RjRBMnBCOXdiRnNhamRq?= =?utf-8?B?Mk1sRFZhQXBjeE5YZ0pQaFdJakhBRkhwbmtxaWdEN1lsdzNZNTc0VkFuWG44?= =?utf-8?B?T0psakxSaG1UWGNEdnFLYTA2YmkwOTU5V2dCWWp1TnhyVHBDVm1ldElWNEJX?= =?utf-8?B?WGNUVlExbzUrcE81Uk1rYS9sT2o5Qzc0UkJYQU4vWmg4L1p6RGRSeThQYzBH?= =?utf-8?B?K240blhKRUR1RTN0RzllcEVXMU9EYWR5VUxkQXo0NlNyVWI5UXBuRnltVnZ4?= =?utf-8?B?RE9OM3NrenpiSEJJajQyZmdyRmxTMnZrN1krL0swell4QTB0d2pFdmFhMUVO?= =?utf-8?B?dHVmeVNDTkxMRGNvMmg5cW5ZYnk5TlZCRFZHY240c09NY003MFRjbDdyRlgz?= =?utf-8?B?OU5wS3ZoeElqeVlydVk1bTljQTBWSSsvYlBmZ3FsajNtTHJUOVBmNUREd2o2?= =?utf-8?B?RjhiODA2VXZITTA3ZFRmcktxRmJTNzc1RFFOZkNtbXpZRlpFd1lhakFVWDR4?= =?utf-8?B?TGdFcVNjcXJPQnNBbW44TWFGNG9Jcm1rU1o1aGRqd2cxSG9HR1VKcGN4Y1pB?= =?utf-8?B?alQ0dmZ5T2N5bXErb2lJMCtlMC9rQVdLTzdhZDgwcnQ3R0RiUVJna0Y1ODF0?= =?utf-8?B?NnlZL2wzUXl5QkxGUHk3NmJpckZHbUptVXRCVVZSVlhibVA1S2Y1YTd3cnRL?= =?utf-8?B?K2hTaWFtU0p5cXV4RE9IWjAvNU5MU0pWMG9ZY1F6V3VTOHpxTS8yZUszenlx?= =?utf-8?B?bUpMUnZQM3k1aHpXbzY3TEQyRDA0UHVncW1CYkZkemFrbWk1blVlQXlMbWh0?= =?utf-8?B?Ulg5bFRuV016WU1YRjlTQ3JOTml6Z3d4NG5CRmE5T09Ldk5xNmNRK0xDbWFV?= =?utf-8?B?LzZEQUVHWUlNRVFia1Z6akozN2UvN3E2WFJIK3IvRU9LZ3JBVndkMFUySlRW?= =?utf-8?B?dXU1WTd2aEJUYXovQmwzbFZiNUJKUGQxQ3NPTWx5c1BkWkF0MGsyS2pFb1hv?= =?utf-8?B?UUFUQmNvNHZyQlNtWDF3QktRaWREeVlzWDV3SFRGdXVvR3h3dm9TWmdLaXd1?= =?utf-8?B?QzAzUXZsODk2TGVmSGxlanJYVy9KeGhsbU5aSGdHQVRSdnp1c0RvTXR5SmRM?= =?utf-8?B?YXlYTk55cjZYY0x4QTg3M0VQNUVVMW1UYlNsL0lFWHFDOXZBR1ovelp3NDN5?= =?utf-8?B?OTV2Mk1rY0Z1WUo5NExIQnBuNXl5S1RZVHplVFhRSEszUjF6SDZoemNWMXYw?= =?utf-8?B?SUxiWTVVWHlhSml2SllZSDc4dEpqNy96WmgxSGZvdVFkZXZ1eGxqV2kzZkhk?= =?utf-8?B?MExZdExzQUdXZXQra3hBT2Y4SVI0dnR1YWFEZVBGNFpGT3dDV29nL2hZcFlH?= =?utf-8?B?Vzc1WHF2anpqRktNc2J2ajhaVGt6M09RemVmY1pNdjkrNVBNbzExQWRDQm50?= =?utf-8?B?TXRpaGZ6SzhTeHp1L2c1MmNYU0dPOUZjSUVxaHFVczA2RkxzNVlVbXhkVkJZ?= =?utf-8?B?K2E1NEp3V3Azdk0vZmFuRzVLSEZxSFIxMWl1cU5oMjBQSGVaOEVRekRGT1JC?= =?utf-8?B?dTBoTWc5M1VYSjhSOVlJS0YvL291WVpGZmZVSDBmallaamNtb2VXRUNTYkhu?= =?utf-8?B?b3pPdkpDbXZnK3pTbGppRTM3b1cvTkN6K1FmOEJZMmYvRjl2ZXlGME1ud0NY?= =?utf-8?B?OGRMcjVWZHYrdldBNjdmelI3cWhsbGRWT0dTcnJTWTlCRW40YnEyRlQ3ZUZ3?= =?utf-8?Q?3ys9DzJBDhW49lrVRe14VB5KSTvSTgXJ3/Vm6WR?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4c0eeff-19a6-49b9-fae9-08d8e49b345e X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3293.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 14:37:32.3618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7wwkME50rLcLfEILxkfEZUitNCzO3Zb+HCSJRs4Ed+j4y3a3xmfmChVnRhBCXkqpKxhsIARRn/WjDjnwVGx9G+zSPPyi3kP02DlfFIwHFC0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4945 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9920 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103110079 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9920 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 impostorscore=0 suspectscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 phishscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103110079 On 3/9/21 12:00 PM, Jan Beulich wrote: > They're only used internally, and the layering violation they contain > (x86) or imply (Arm) of calling HYPERVISOR_grant_table_op() strongly > advise against any (uncontrolled) use from a module. The functions also > never had users except the ones from drivers/xen/grant-table.c forever > since their introduction in 3.15. > > Signed-off-by: Jan Beulich Applied to for-linus-5.12b From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:38:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:38:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96634.183017 (Exim 4.92) (envelope-from ) id 1lKMSJ-0006i4-4D; Thu, 11 Mar 2021 14:38:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96634.183017; Thu, 11 Mar 2021 14:38:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMSJ-0006hx-1E; Thu, 11 Mar 2021 14:38:27 +0000 Received: by outflank-mailman (input) for mailman id 96634; Thu, 11 Mar 2021 14:38:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMSH-0006hm-K6 for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:38:25 +0000 Received: from userp2120.oracle.com (unknown [156.151.31.85]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7752ede3-6ade-49b2-8c67-15ace844955f; Thu, 11 Mar 2021 14:38:24 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12BETaGF115251; Thu, 11 Mar 2021 14:38:23 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 3742cnerwx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Mar 2021 14:38:22 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12BETbF3021127; Thu, 11 Mar 2021 14:38:22 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2108.outbound.protection.outlook.com [104.47.70.108]) by aserp3020.oracle.com with ESMTP id 374kn2kqqm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Mar 2021 14:38:21 +0000 Received: from MN2PR10MB3293.namprd10.prod.outlook.com (2603:10b6:208:12b::24) by MN2PR10MB3422.namprd10.prod.outlook.com (2603:10b6:208:122::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.29; Thu, 11 Mar 2021 14:38:20 +0000 Received: from MN2PR10MB3293.namprd10.prod.outlook.com ([fe80::b87b:5cdc:87f4:c465]) by MN2PR10MB3293.namprd10.prod.outlook.com ([fe80::b87b:5cdc:87f4:c465%6]) with mapi id 15.20.3912.030; Thu, 11 Mar 2021 14:38:20 +0000 Received: from [192.168.1.195] (73.249.50.119) by BL0PR05CA0030.namprd05.prod.outlook.com (2603:10b6:208:91::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.10 via Frontend Transport; Thu, 11 Mar 2021 14:38:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7752ede3-6ade-49b2-8c67-15ace844955f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=3zenU6wUI6nu7AkNiLmoOAASqEppMDw7XNV/IEqijYQ=; b=aFghWF8ObiBMO6LZzkvlge5hC7tJ1lKM1ufQT9jZ3SFPavAStT4pEl2Np1cs7KlhsVBd K70wCYtKDfLb+4BGSgAlX2QA+N7N3VtfUnRAQycVfK/jtwXSEVovdjdnSYni/f/kzXjU b68MyuqAzpw9wIvYPTWuFh/75w9bwCRohwbrBccxwhMCEwsUa0bCBHZ6LrGyuvu65F5I EB93QWD1oYXOxCPL8cXV08kANSy+RIATbNl/N10ozJcP+baC8ZHGRtM8coar+5JLkPik IsvlJoityUNfGjukyb/VrbmqjyZaH3A9ugPAFheQmupUytEqax+vsU18akuTkaqsAwgR XQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G5t7QxLLq+qQVC8GwkvE+VpSkazz5BZKfauc0HfX9QAqtn825776qE9hGEG2U/7H3Xe2wB+ae1jv1u5i4GPPcCKbM/wFqY+A2RlaqE1qpD01/z41ikRfoEgkUboEOF3y9aeKSeI6qS2OM+V5nMgwqlSnnN1/IX4tzmyS6A99Vru4k4iyqx7phK77I+9tN7uj0NLosWZ6g/t4QJwMjjaziXweWwC4tSnEhFdDM3iIra+J6PiwzpL/UMPYVSH7KYnrNT8iFGzE4Ein46tc/nUPonF5U2SdfKrpz23jP8UAt79sBNGC7KxJ7c9OYpehgxt4q5wbckRQ7qoIgCcOFrjoJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3zenU6wUI6nu7AkNiLmoOAASqEppMDw7XNV/IEqijYQ=; b=TklB3qDU/3VZpDFgtbh1hZ3cQnyNX73oUyNlmQaVQTG9+bTNVDtmCdpNarRVVO6WRF1J/UcWDTNGp4CtCeidCrS/V8lyjZJDESc9fa5mHAoAdwHyYN4JaRWLNTnWbiQyIf3S6PaLb7u1s+lLMB9/HAol4sFAw+sTA52bL80Of3OfF++b3+Qj7glPGCzJDheSInuQcN6yXAQkCEJN8IO54S27KY6n5uFmSi3ERYXJYZeDWNx7TjZR9JAMa5hSpL+ZYYCfBHnzir9EdSHA2mQ7RGrDyzgPE/y2r/Qy5oJ9EQjqJeTHqTKHq6/048utOSdHpiIN9iKMtS9Lg/Yoz2bcRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3zenU6wUI6nu7AkNiLmoOAASqEppMDw7XNV/IEqijYQ=; b=FQeWyspl22JfanHRUWTizE0lyPLVhI39yWs3yJsv+bT31JC0N1t74p7jJRa89q+SdWl7kp+d2z4BxmO7OhmKXPqEX5F3gjLWlQzhrSL4LeneC5GdJLdDTongMdgv4fj3v/U3HIlagh0zsYNOmdFVJJjhE+daPmOALx8Q4dzi/Xw= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH 0/3] Xen: grant table related adjustments following recent XSAs To: Jan Beulich , Juergen Gross , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" References: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> From: Boris Ostrovsky Message-ID: <9d89a640-3fc2-756a-42f4-873be469f44f@oracle.com> Date: Thu, 11 Mar 2021 09:38:18 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <2b326dc6-c624-c97b-f9c4-4cc68dd013ba@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [73.249.50.119] X-ClientProxiedBy: BL0PR05CA0030.namprd05.prod.outlook.com (2603:10b6:208:91::40) To MN2PR10MB3293.namprd10.prod.outlook.com (2603:10b6:208:12b::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0704257b-090d-42c1-cdba-08d8e49b50d7 X-MS-TrafficTypeDiagnostic: MN2PR10MB3422: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2089; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WUz8x79/Al9rspRK845ZYjxt52CD53p8NOeNXKeEvA2bBXTTcxH6AYgWX2WlLS64Agr7vpx36kne0NePDy+BZb+mFyJ4dYon6SrzOs6vPGZvmF/8JsaMBvcbw+DWrUuKIkg1iX+G9gZkUjD6nRiC0E7jCnL71ubvXjAZ59Zdd9dX+u7Nqu/lnMiMrSicApVay5HgVjxwGfEuS8funUa4EeIgioOvfT5CiuKKtR7mV2rdosnLFccTnebbpXuHgrj3yYyzfHy9TW2/4bfds07cWJqdVneGJYHgXsf2xApxlJIjkQTfPz+B0TQ9ZWAm1NNGHMtYqhd/FD4mKtr90IeTVo7HYgFusg+ryyW65LOi9eQqD2sSwnfCnKNLV5zEMIjEe4+7QPz4JIt+xo1uLc6p4U2VHcUVi3O/6Ek2wII94DtLi8L8Qksm68zktdSMAEgkTfnm8LoF8VMrzZtPpjIODbSiiPcy++03MJ90gLgnoVvizvIz4lihuGoiHuG934IoGrRrDY34CQFoBceHyKxVWqZ325O0obpIakNBIvJFIPomnIvL9viJYW+3ucEmUG1avMVBlQvKIymlNB868kC+1+3UkGoTOsYZjkFr5qpvMzM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3293.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(396003)(136003)(346002)(376002)(5660300002)(8676002)(36756003)(16576012)(8936002)(2616005)(83380400001)(956004)(4326008)(110136005)(86362001)(478600001)(4744005)(31696002)(6486002)(16526019)(316002)(44832011)(2906002)(186003)(53546011)(66946007)(66476007)(31686004)(66556008)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bzdlR3F1aWp2UWprNzVwMGpRTTcvM0IvMVkwYk1TWjNrZzVGbnVKREtJcG5i?= =?utf-8?B?bldiRVZLVHhBSUlEZDRoMmJTUlpSNGs4OWo1MUpZQlhXanh5bVhoMVQxZHhr?= =?utf-8?B?Ni9tRkVKZEEyZWxxZkpMNTFyT0VVazBrM2VBdGpEblZxcWtUZ0xmSGZ0ekhz?= =?utf-8?B?Y2YvNSs4aW4zMmJBbm12MkQ0NXgvT2RqZFlZdFBBcjJIaWxTMzVVTlplMVJC?= =?utf-8?B?VlNsTEVxL3lkS3BHL2h3b1NCWnl0Q1RqNUN5b1RCS1hNNS9NRUxSeEJLMEY0?= =?utf-8?B?L3hIN3JVaGprd2ZKWko1dkhVNGc4RUxQMVlrWDg3THZZZTIyRzZqSlFOQ2Fu?= =?utf-8?B?UWdNV043dm14UjdKNk1OaDhiOGdnai9nTFJRVjMxSmR4eW5BOTBMR1kwaEFh?= =?utf-8?B?a0pmR1NwYU1ySVVOWFFQWGVlNnpEVlFDcUpwS3dUTzZ3aEtPa2Q4MXR1WkIz?= =?utf-8?B?R1JPUHY0ajlmd3U5UTE3Z1JLckFMMEdNRm9ROE93a0Z3WjVpUTloaTJiZWRL?= =?utf-8?B?b3ZZWktvaGdsWWd1T3NndnZ0Q05uN2o3QUFlRzN4Ui90N2JzUEUvU2thOW95?= =?utf-8?B?TEJ2UDhxV280SytiRkxqV2pac3ovWWN5RXowSC85VVFOYjBRS211bDFXVExz?= =?utf-8?B?Z1lGTEFKeGsyd0ZCZHdaQkw2MWpkRzZXKy9pKzlKa3F4QzUweHF6MVdlZjF1?= =?utf-8?B?bkdLcGVOd2o2OFZaUHlQVy9vcGh3dk1OTml4WG81MG9BeTkrOGVTMHgwMm16?= =?utf-8?B?QWYzTGY3MFRtVVpTNDNaaWpMb3JiWWJEMXlyTjNGajZ4UUlzb3A3WEVDZEVF?= =?utf-8?B?RWhUZHVSdTU0RG1CRTREZWUzZ1NkQldBMlhKSmVKblNRQ3pvSmdUTzFOdXdu?= =?utf-8?B?QkNYZzYwQTUveW5XQ2hsNFA3V0NsNGQ1WndyM2VJcXozSlgzbXZ5UHRQd013?= =?utf-8?B?ZG9FSGlLVTFRVG91TzQrYTZQNDdiQ3FVRTAyV2t3L0dLR2hLcGlDNUJRT3Nr?= =?utf-8?B?TmxqT1JjSnRDTWp5K3dSWHhuRkt0K0FWM0dqZUxPRm5WOGt2UUU5b3JoQndR?= =?utf-8?B?TXdPYTUrU290Qm1QbERlQUkzTHdmL3J4V1ByTTVlNUEyRkdheWtpS0RCRGxo?= =?utf-8?B?Tnp2Y3RpaXBTSFBQeVlERGhOdjFETUc5K3VudU8yWjI4VHlWbjFTMDZ4RlNH?= =?utf-8?B?dGppemVTSTF0aGkyWDdSYmhUeE9Yd1g4WW5UM3A5OFdsclo1TGlYS3J6OXVq?= =?utf-8?B?SzYwY3ZYS3ZhYUxmVHgxN3BFcWpYc0taT3k3R3gzTnpYYUZxUis0SUhFQWRB?= =?utf-8?B?bkIzTTZrbkVpYW9DVU92NkhsZ0Zlai9iMGF0ekgzMU4vd3EvUFBRcnpYRTVp?= =?utf-8?B?dWl2T2pzWExKQVNtQ2RCeXF6SG54cHB4MEk1dFBkTUg2TGRocHZNOW9za3NM?= =?utf-8?B?MWJmejlzeHVNZGhMdHg5MUNXWDVmVmxHaDFiTkRPdmoyT3NDZXo2SlVpL0R1?= =?utf-8?B?WllZRlpRS1JVcHhlak1KemRlVlVkcjlrZXFqcXFzOG96MVhVdDIyeXV1ak5u?= =?utf-8?B?RWo2Tk9yWFhhVUNuRFdFN0ZLUEVtY1J0K1BSc1I3ZWtGUElmcEYvclRLSXVT?= =?utf-8?B?T2FBMVlpbEZJZGlmOU40Y2dHM3pSMFVLRUt0MmtvLzgvejBuV0dqcTdVdERF?= =?utf-8?B?SVdGRGdlR1YvR1FlUnZPOHpYODVkcG5namdoeHpmWmVUeGdOYnE3Z3VvRWtu?= =?utf-8?Q?Quv40zk+/eRZEaVxzY6TaCwqUpcrgvuyqewBtcN?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0704257b-090d-42c1-cdba-08d8e49b50d7 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3293.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 14:38:20.1378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8Ir6UwA6d9lWN4EqPPNZ3lHqqtgpUGvtbOf/n00qu+pW53fCKMJP78uhGtVoJ/Nzi8w4EmdjgFod/wkTlBV5KK2AV6eq5j1iYE4pmH+bFIA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3422 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9920 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 phishscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103110079 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9920 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 clxscore=1015 phishscore=0 adultscore=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 bulkscore=0 mlxscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103110079 On 3/10/21 5:44 AM, Jan Beulich wrote: > While addressing the XSAs a number of further oddities were noticed. > Try to take care of them. > > 1: gntdev: don't needlessly allocate k{,un}map_ops[] > 2: gnttab: introduce common INVALID_GRANT_{HANDLE,REF} > 3: gntdev: don't needlessly use kvcalloc() Applied to for-linus-5.12b From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:38:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:38:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96636.183030 (Exim 4.92) (envelope-from ) id 1lKMSm-0006nn-DN; Thu, 11 Mar 2021 14:38:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96636.183030; Thu, 11 Mar 2021 14:38:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMSm-0006ng-AM; Thu, 11 Mar 2021 14:38:56 +0000 Received: by outflank-mailman (input) for mailman id 96636; Thu, 11 Mar 2021 14:38:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMSl-0006nZ-JO for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:38:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0fe43c90-c399-405a-9246-858e7ec2af97; Thu, 11 Mar 2021 14:38:54 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A142BAB8C; Thu, 11 Mar 2021 14:38:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fe43c90-c399-405a-9246-858e7ec2af97 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615473533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+F8YCQYwFfAAno7kXAzb0wMUytT5f6bAGDvirWF6wV4=; b=VerFM3hJ3x49p9SW5dtlrcLMCWx6vjnFF1g/z2HqtP8P9E17mbEgy0XHchH9jSpdW35nNQ JzBwCaFFt1SwUstTK6RXfFxoHcAvT7ZZ72icSIPKfLpRtqXSHWyOpBzo9+rCC1vkeYLjXe ef398TDr5qaQB7BH2h3q6O/b2MU4Epw= From: Jan Beulich Subject: [PATCH v2 0/2] tools/x86: adjust populating of tools/include/xen/ To: "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Message-ID: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> Date: Thu, 11 Mar 2021 15:38:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit While the first change is a possible 4.15 candidate, the second is pure cleanup (but could, should patch 1 end up being controversial, also go in independently). 1: don't rebuild cpuid-autogen.h every time 2: move arch-specific include/xen/ population into arch-specific rule Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:40:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:40:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96640.183042 (Exim 4.92) (envelope-from ) id 1lKMTv-0007cx-OF; Thu, 11 Mar 2021 14:40:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96640.183042; Thu, 11 Mar 2021 14:40:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMTv-0007cq-L5; Thu, 11 Mar 2021 14:40:07 +0000 Received: by outflank-mailman (input) for mailman id 96640; Thu, 11 Mar 2021 14:40:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMTu-0007cj-Q9 for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:40:06 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ac6cdb5c-38a0-4866-bacc-06f2e1926510; Thu, 11 Mar 2021 14:40:06 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3069CAC16; Thu, 11 Mar 2021 14:40:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac6cdb5c-38a0-4866-bacc-06f2e1926510 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615473605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SpCLboR3rdGxQgHP4USmwjA3IAZd5oALlQEmZb2qbDQ=; b=uTjgsNBNMTB05iipx9Ld7t+JrAcOmC12AQYRAKUIjvhmDqNsP6AVmeY/0C/1w0OMtMnFCG l7eVUZBdVeSzGMenZMDNxXVpR7Oiwf9MPapbcWzvzt2CYf/MwUbQs5QMUHcsSWWAA5tUpn s03bkfma65oz9ehZVfSa8UC1d2o1JDI= Subject: [PATCH v2 1/2][4.15] tools/x86: don't rebuild cpuid-autogen.h every time From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> Message-ID: <1b8aee19-9194-153c-8dbb-0aec3412e255@suse.com> Date: Thu, 11 Mar 2021 15:40:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit The first thing the "xen-dir" rule does is delete the entire xen/ subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a result there's no original version for $(move-if-changed ...) to compare against, and hence the file and all its consumers would get rebuilt every time. Instead only find and delete all the symlinks. Fixes: eddf9559c977 ("libx86: generate cpuid-autogen.h in the libx86 include dir") Signed-off-by: Jan Beulich --- v2: Different approach. --- Ian did suggest to pass -0r to xargs (and -print0 to find), but I couldn't convince myself that these are standard compliant options. We don't use any special characters in file names, so -print0 / -0 shouldn't be necessary at all. The stray rm invocation when there is no output from find can be taken care of by passing -f to it. --- a/tools/include/Makefile +++ b/tools/include/Makefile @@ -19,7 +19,7 @@ xen-foreign: $(MAKE) -C xen-foreign xen-dir: - @rm -rf xen acpi + find xen/ acpi/ -type l 2>/dev/null | xargs rm -f -- mkdir -p xen/libelf acpi ln -s $(XEN_ROOT)/xen/include/public/COPYING xen/ ln -s $(XEN_ROOT)/xen/include/public/*.h xen/ From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:40:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:40:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96643.183054 (Exim 4.92) (envelope-from ) id 1lKMUj-0007kE-24; Thu, 11 Mar 2021 14:40:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96643.183054; Thu, 11 Mar 2021 14:40:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMUi-0007k7-Ue; Thu, 11 Mar 2021 14:40:56 +0000 Received: by outflank-mailman (input) for mailman id 96643; Thu, 11 Mar 2021 14:40:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMUh-0007k0-N2 for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:40:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e43e1200-1ea9-4ec1-92f7-5ae55f97bcf4; Thu, 11 Mar 2021 14:40:54 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F3B7CAB8C; Thu, 11 Mar 2021 14:40:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e43e1200-1ea9-4ec1-92f7-5ae55f97bcf4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615473654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+X69GrozWYaghxwvS9MPdag8I8/4ve4VeVt9yKkZhYs=; b=Nz1PRdnUSOdE9jtsJU3xqs4L//HENNUebiCm6H4gdKgedYR6kE3npHieyVCq3gAR7Mu6g4 3GreSc/GDdXn0hvU2XdVee0k2gomGl/chDx3IRgOKPXpdX73Ik6OStBrLIu6s0RNvMZF7K uZvPmEwx/Dkr5Il0PSjbfYpAV8siOCE= Subject: [PATCH v2 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> Message-ID: Date: Thu, 11 Mar 2021 15:40:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit There's no need for the common "xen-dir" rule to have an arch-specific part when there already is a arch-specific rule where this can be taken care of (arguably instead of all-y this might better be xendir-y anyway). Also change the pattern from *autogen.h to *-autogen.h. Signed-off-by: Jan Beulich --- v2: Insert dash in pattern. Re-base over changed earlier patch. --- I was tempted to move the "xen-dir" dependency from all-$(CONFIG_X86) to the general all-y, but perhaps that's less related and hence should really be a separate change (and there may also be arguments against that). --- a/tools/include/Makefile +++ b/tools/include/Makefile @@ -29,14 +29,12 @@ xen-dir: ln -s ../xen-foreign xen/foreign ln -s $(XEN_ROOT)/xen/include/acpi/platform acpi/ ln -s $(XEN_ROOT)/xen/include/acpi/ac*.h acpi/ -ifeq ($(CONFIG_X86),y) + +all-$(CONFIG_X86): xen-dir ln -s $(XEN_ROOT)/xen/include/asm-x86 xen/asm mkdir -p xen/lib/x86 - ln -s $(filter-out %autogen.h,$(wildcard $(XEN_ROOT)/xen/include/xen/lib/x86/*.h)) xen/lib/x86/ + ln -s $(filter-out %-autogen.h,$(wildcard $(XEN_ROOT)/xen/include/xen/lib/x86/*.h)) xen/lib/x86/ ln -s $(XEN_ROOT)/xen/include/xen/lib/x86/Makefile xen/lib/x86/ -endif - -all-$(CONFIG_X86): xen-dir $(MAKE) -C xen/lib/x86 all XEN_ROOT=$(XEN_ROOT) PYTHON=$(PYTHON) # Not xen/xsm as that clashes with link to From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:44:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:44:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96646.183066 (Exim 4.92) (envelope-from ) id 1lKMYC-0007vq-HP; Thu, 11 Mar 2021 14:44:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96646.183066; Thu, 11 Mar 2021 14:44:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMYC-0007vj-EB; Thu, 11 Mar 2021 14:44:32 +0000 Received: by outflank-mailman (input) for mailman id 96646; Thu, 11 Mar 2021 14:44:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMYB-0007vZ-88 for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:44:31 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d39eb568-073b-492f-ba2f-ccd49e4b5ec1; Thu, 11 Mar 2021 14:44:30 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6BFC8AD72; Thu, 11 Mar 2021 14:44:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d39eb568-073b-492f-ba2f-ccd49e4b5ec1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615473869; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IscWbjnVtI7ozSXwYlcHTZll37v+EaVHgEC/72Mdcn8=; b=ewJbRdY7UElPi3Agn5RlwrSxTxxILn7JMCa5pV16l5BZ00/ZKbpCd6VRObGo4IFHKd2E7p rC0AiIUNRw+ydfVdAGsC+W+9I1HqF5K2K25fyHNqV/BmyufMCszu+aDZ/U36eJc0ooFja+ v/DbQWRUyxzMQW451gw4a1T9UcnXF+I= Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , Xen-devel , Juergen Gross , Paul Durrant References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> <556ce32b-5087-b8b1-432e-643218dd8c6e@suse.com> <9ca069ab-8b6c-c8f1-d68b-4a9bb0cf5c56@citrix.com> <62b79d56-2438-23ab-49c0-a8c4b290c4f7@citrix.com> <9a248354-f68b-8cba-f18c-f4a26473f9bf@suse.com> <586f5bcc-9d96-dc37-2aa1-aed0bf11117c@citrix.com> From: Jan Beulich Message-ID: <0779dcee-4aa1-019c-3e6d-5b6330e395ee@suse.com> Date: Thu, 11 Mar 2021 15:44:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <586f5bcc-9d96-dc37-2aa1-aed0bf11117c@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11.03.2021 14:43, Andrew Cooper wrote: > On 11/03/2021 13:28, Jan Beulich wrote: >> On 11.03.2021 14:00, Andrew Cooper wrote: >>> However, having laid things out in this way today, it occurs to me that >>> we should consider further cleanup as well. >>> >>> I do agree that code wanting to use the libxendevicemodel.h API almost >>> certainly don't want/need the dmop ABI.  (i.e. an individual consumer >>> will want one, or the other, but almost certainly not both together). >>> >>> Should libxendevicemodel.h really be including dm_op.h? >> I was indeed wondering. >> >>>   AFAICT, it is >>> only the ioserverid_t typedef which is API shared between the two >>> contexts, and we can trivially typedef that locally. >> Hmm, a local typedef isn't nice - there should be one central point. >> Granted there's no risk for this to change in anywhere halfway >> foreseeable future, but still. Also neither C89 nor C99 allow a >> typedef to be repeated - in those versions we'd then rely on an >> extension. > > I wonder if we're depending on that extension elsewhere.  As far as the > stable libraries go, we are dependent on a Linux or BSD environment > currently. Right, but we'd like the headers to be consumable by any environment. > Alternatively we can drop the typedef and use uint16_t instead without > breaking things in practice.  (As long as we make the change in 4.15 and > we lose the wiggle room afforded us by the entire interface being behind > __XEN_TOOLS__ previously). > > Thoughts?  I can't think of any ifdefary which would help, and swapping > to uint16_t would reduce the use of an improperly namespaced identifier. I'm not outright against, but this might inspire people to use uint16_t elsewhere too, when they should use the typedef. How about a transient #define (suitably commented)? Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 14:50:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 14:50:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96648.183078 (Exim 4.92) (envelope-from ) id 1lKMeD-0000Xj-7z; Thu, 11 Mar 2021 14:50:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96648.183078; Thu, 11 Mar 2021 14:50:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMeD-0000Xc-44; Thu, 11 Mar 2021 14:50:45 +0000 Received: by outflank-mailman (input) for mailman id 96648; Thu, 11 Mar 2021 14:50:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMeC-0000XX-E5 for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 14:50:44 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 20605d5c-4578-4ac0-afd8-8dfccfa951e7; Thu, 11 Mar 2021 14:50:43 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BC4CBAB8C; Thu, 11 Mar 2021 14:50:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20605d5c-4578-4ac0-afd8-8dfccfa951e7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615474242; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rLrD27xHWuUw+M1XCJMKdmfXk4h795TUzEU6Khx5pNY=; b=KrPKXtq5RUp3iGdH37fiq3N6lFR5BYhfcAHPqDphpCvqlwPg/9BEzMr/BC+8awbNXPAFrZ s9603s5qmk3AGTJ0WmYAMTwV3/UmsQob+GRZhdLS6Z+P0eH2V/QEfs5mX+i2FU51mVyN1R vxXa/KBa6oE2YDPN//ajvzxoqJhk/ZM= Subject: Re: [PATCH v5] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210311142207.25556-1-michal.orzel@arm.com> From: Jan Beulich Message-ID: <572b503c-6650-a0a7-74d6-f5f3ba076fea@suse.com> Date: Thu, 11 Mar 2021 15:50:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210311142207.25556-1-michal.orzel@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11.03.2021 15:22, Michal Orzel wrote: > Currently in order to link existing DTB into Xen image > we need to either specify option CONFIG_DTB_FILE on the > command line or manually add it into .config. > Add Kconfig entry: CONFIG_DTB_FILE > to be able to provide the path to DTB we want to embed > into Xen image. If no path provided - the dtb will not > be embedded. > > Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" > as it is not needed since Kconfig will define it in a header > with all the other config options. > > Make a change in the linker script from: > _sdtb = .; > to: > PROVIDE(_sdtb = .); > to avoid creation of _sdtb if there is no reference to it. > > Signed-off-by: Michal Orzel Reviewed-by: Jan Beulich albeit I think that, as suggested, ... > --- a/xen/arch/arm/xen.lds.S > +++ b/xen/arch/arm/xen.lds.S > @@ -222,7 +222,7 @@ SECTIONS > > #ifdef CONFIG_DTB_FILE > /* Section for the device tree blob (if any). */ > - _sdtb = .; > + PROVIDE(_sdtb = .); > .dtb : { *(.dtb) } :text > #endif .. the now pointless (always true) #ifdef here should also go away. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 15:00:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 15:00:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96651.183090 (Exim 4.92) (envelope-from ) id 1lKMnG-0001jn-Ar; Thu, 11 Mar 2021 15:00:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96651.183090; Thu, 11 Mar 2021 15:00:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMnG-0001jg-6m; Thu, 11 Mar 2021 15:00:06 +0000 Received: by outflank-mailman (input) for mailman id 96651; Thu, 11 Mar 2021 15:00:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMnE-0001Ut-TX for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 15:00:04 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ebc9a2e0-e92f-4542-8278-b95502d94cd4; Thu, 11 Mar 2021 15:00:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebc9a2e0-e92f-4542-8278-b95502d94cd4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615474803; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=6vpo9DnhA7VyoWa4VZy2cWEDVSr8WIu6yX+xQUHxhgE=; b=BROq123OM3MCKJ1dXUbXzaTfc1ZuH3s3rIG2NYu3e2vXw6WE44pt3DJH 6F7GQM9SKLct+h2CU4g+Dz/BR1M4RSbMXtm1uywaZAxfdEk6n6W0wAA40 YFgAsxrh6KNNjxux7sOf29hmQMbOzaXyvRNfWVBOeJ36mRlk+9iyR671L E=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: M2STuQlVDud+4ryrtlSg+CF/bo3A9d1DBuyxZlbvbwPEql4xVaAFnzYweifdib9ij1+EwD2bGq PI9FMuKBo2RzXTCadUBkUfQENYLGgGhzsgzYcjn6rl+hv6J0J8kYTQZneISxJCT5kH4fZSKDOE 5e0aU96NE5Ei/qTY8tarL83cM2b/feFFMLMIqIYNRf/sQefMGdjbFxdbK/j4GRSBgkG/u+G2ax R6CJuzuUDwB3Warl2gPetNTm48Kpu0ynK1wr6fW0t8QzMSvP5nY2kcGSANl4Ac5oWhG/sMhPUA REg= X-SBRS: 5.2 X-MesageID: 40479554 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:DbNMI6MQ1+kVP8BcTxv155DYdL4zR+YMi2QD/1xtSBBTb8yTn9 2vmvNe7hPvlDMNQhgb9OyoEq+GXH/a6NpJ8ZAcVI3SOTXOlUmJCMVZ7YXkyyD9ACGWzIRg/I ppbqQWMrLNJHdgi8KS2meFOvIB5PXCz6yyn+fZyB5WPGNXQoVt9R1wBAreMmAefml7LKE0Hp ad+cZLzgDIERgqR/+2G2UfWKz7r8DL/aiMXTc9GxUl5AOS5AnYi4LSLh7w5HYjegIK+5gO2y zvkwv15qKs2svLsCP05ivowLl93PfkwttHLsSQhsYSMSWEsHfUWK1RH4eskRpwjOaz6Es7sN SkmWZdA+1Dr0n/U0vwgRzx1xLu2DwjgkWStmOwsD/YjuHSABcZYvAx4b5xQ1/ixGcL+OxY6u Zt2VmUspJGZCmw5BjV1pzzeDxB0navrWFKq591s1VvFbEwRZV2toIl8EZcAP47bVnHwbFiKu VoAc3GjcwmF2+yXjTctmlr9tSmQm4+KBeAWlQDocyYyVFt7QlE83c= X-IronPort-AV: E=Sophos;i="5.81,240,1610427600"; d="scan'208";a="40479554" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eAtZjd9lFFhTfkcer7mfB1Z9lfQVE+wTiUp17sNhF1a4/3/f6YZabIJNpPDTLHMbktzX7L2JK2XyNeaM4ot6MZVC6/IB6sfJ5cr0RXMJ5C9UvofkVZSAeEeZg+6EjmzdQVYWkeGyjnQQunDkQ+B/sm5Uexa8D4N4G0soOjNKJi83KT/PXmIH040PIoDFJ0MbRZjVaYDenlxxHV8LNNh38Hmxv55sC/GQICXihM9vPMVYExYAsraWCIhd9MSNLJWxzFOta8CD1cnfgCWCje8zJ5FspS0wezbgZyKQA4ykMLt8gMWE7/0pbZFawfwVgKMKkFT7SBZA7da92FPT7k0szw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mUG1TdsHe0NYVPn6jvX3nYhLe9Ns/zMy6s34wcH4tI0=; b=Wlmv9cH3DOe/0xsN0T7iHt6Y8DZOnnfdW0hm587TWSgNXzC7HlqTqQsR4ldvyeT512QgHarJlGQO+bJzWjVoaVHMMu89Ya/rOP7Kc2gtx47JsPx53dhwzyUK9ZsnFnyWcX//gJhQ7XURRZqKTNuw+YrM8YV4mztzxShJgrWm0NUwCIOTiS40QH9PO4nqahBUWBN8S7fYbv8edye4Yf5utxRC1Dj+WcScnKyfBW7M7zCTRUS7cvPK1+uc6HaCCU4LQwI6SqfjC6dX0n8eimYs9hs7Thx9WA9UJ+Qx1EQ+RJDh2TCuEWuBlgtJDpSd+2B1Qacy7vND6d3yhAxR0fjBGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mUG1TdsHe0NYVPn6jvX3nYhLe9Ns/zMy6s34wcH4tI0=; b=UH1VQLnagtSFwEfj3uenAZa7XNdMgL83BtcwP5QZEaVuF+dao2sv6EuszNypi6pXIBkTJ+hBzxMkr2JFRBp/+X2pr379pPY/IwIinkSiZl8kNDZYzERfB+70a0w5CZf8u2rJQB2IPa9BasLbeJQ61qwSNOCsgpSGZRrGaS3wUDU= Date: Thu, 11 Mar 2021 15:59:39 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Jan Beulich , Wei Liu , Ian Jackson , Xen-devel , "Juergen Gross" , Paul Durrant Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API Message-ID: References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> <556ce32b-5087-b8b1-432e-643218dd8c6e@suse.com> <9ca069ab-8b6c-c8f1-d68b-4a9bb0cf5c56@citrix.com> <62b79d56-2438-23ab-49c0-a8c4b290c4f7@citrix.com> <9a248354-f68b-8cba-f18c-f4a26473f9bf@suse.com> <586f5bcc-9d96-dc37-2aa1-aed0bf11117c@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <586f5bcc-9d96-dc37-2aa1-aed0bf11117c@citrix.com> X-ClientProxiedBy: AM6PR02CA0010.eurprd02.prod.outlook.com (2603:10a6:20b:6e::23) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5fbe9428-cfae-4b60-f7a9-08d8e49e4dfb X-MS-TrafficTypeDiagnostic: DM5PR03MB3210: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZuVy9x8Az1V5SmuX0UmzK3nxiuuyYDFHm3hDRGZpGd/GBJwIucnFWQvUpTDBU0d29lz26iI1Rag2SvPPuY9Tz7J7ZPcItsp1UZXeuH+9bzKbLDrV5Wot50BWcqizQK4E876nSUUAtVCn9RB/G3WqOzMDWVZAvsGlhbMicHw7uwT/lIUxiqM+Oh6nAm66T6iAXVDdL6jYFlhsF9wu34kwaRbA1eVdZOgfXle0DDvWI/HkoOBJtEtW6esGJHHtPEiW139fA1B4+eQ0sfkO3eqKUuxnuShXIICptLkYD573s+5KYoLPnwD8Ne2vnSHq1gMlOMjoBnuHzLmggmAtgImrXJOCV/jhkgKXZvxY0k0tlcXqKckvokZiYiPI69w2Ze6bAH3nHEqPGYimK5X8rRqYS9zu+KGrN+rf5ECcAUNLfAVYomT3KB1jDgFqDTNQPRsxctU4ka2jfgG8QzyX7IoSr8EQLiuiHGYqfeI254Xm691lyKiHAvC838ViS1dYY0cBzdif9AJv3JUW2sBnhWi1YA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(136003)(376002)(396003)(366004)(346002)(39860400002)(86362001)(6666004)(6636002)(5660300002)(4326008)(53546011)(2906002)(83380400001)(85182001)(316002)(8676002)(33716001)(54906003)(956004)(6496006)(8936002)(66946007)(66476007)(6486002)(16526019)(26005)(186003)(478600001)(9686003)(6862004)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NytOYTJrVXJNMmVIbmtZVzZNYzZvSTJyWWNUOG9UZTNVVVZnTlhKS1ZPc1k5?= =?utf-8?B?Q3lqYW15VjlCdDhtVUI4dWdUUFRZUkJWNDZidGZTTmVXZjMvNTlYZnhPbldL?= =?utf-8?B?bERXWDk0WnVjWGVnWnNLS3Y2QVg1QVB0ZGVqYzNkeUZ5UG03L1lmVzZLOGdQ?= =?utf-8?B?TGpSdStFSG5iWEhpZlo5cCtBckNqRHFFNUxTVjdqNkpLVURUUVVHN2lIdmw0?= =?utf-8?B?RGIxaHArZDJEVllxMThBN05sK2dieXRQTXF1VFpJTXQzTEYrbVd1VFAvbHJN?= =?utf-8?B?Z0xCNHRDeGVlbmxuOWV0Rm1kS3lQSkJrQ3MyeFY1MzRSdWFucHY4eGVaRSs0?= =?utf-8?B?VDBhZUQ5YUtnWlNTaWVDMEdXZHBFR1RoUnlqRlorVzlEUmpkY0tQalBoSWZI?= =?utf-8?B?VGkzVktWdmxuVVlYZC9XdDJwWGROZzJiOWhNWDdlUG96UVZMSzBWdGhFMWEx?= =?utf-8?B?R2pqNjl1STgzR0ZaZ0hQbUwwdDBIVUJDaFhCemxnVWhWQzVkaEIxcUJrOGJK?= =?utf-8?B?aE1NejlSRmg4cU9DOUQwRmJRVlRQN3lTbk9YdE0vVEFLcTFpcHJFY2tQeTJr?= =?utf-8?B?c0xDQnU3VjNsSUs5d2JWT0paTCtKTVA5ZVA0RTY2SE9laWo2Q2RtOG5HN2dR?= =?utf-8?B?R2JnZjFWU1FqZE54R09qWEFmU0pGS3c1TVpveHlENElmTVpsKzdmSHRzK0xH?= =?utf-8?B?NlBDNWZPOUl6VWdtd0pwZVZNTHZBZXpXY2VDaWdreGdXMUdWSFJOT1pUT1E5?= =?utf-8?B?cGZBK2p0YmdYQjNMK2Z4cTE2TExDbTBqdUQ2UHdBaTBxVEhzOXR0MEpJR3BW?= =?utf-8?B?aERxaXprVUtXSzR0K08zN2cydEs2TWYvQ1NseW9uYzUxaWxWeXJXV2VUbUhp?= =?utf-8?B?aFhQSlpTazU5M2tJTkZIYUFBRlNGcHFUMkxlVFNZdi9rcm5PbnBXdGU3RHhP?= =?utf-8?B?ZEFFb1FkVTBtSlgzOWxkVzJMcy9PRDVVWER6SkdKTE5wS01JQTd1NWRDOUJN?= =?utf-8?B?RTF2TUoyeTc0d1Eyc0F4VzBySGRXdHFsbmFicXVCejFESklRUDdTQi8rOTVG?= =?utf-8?B?Z21ScUx3ME5Ickc3ak0rWXc3eUlWWVFMMFRzZzA3L1VidVJ2MkhoYWhSbHRQ?= =?utf-8?B?S0VmaGFwQkZma3VXQlJ0cjR4NHhsYUdKSmRSNk1UVXRZOElTSDQ2ZkRHcVhR?= =?utf-8?B?SjVqRk9taEtGMDlkRStiUkt5VFFibDJiUVN2L2JtSEpIc1ZyUVgwVXFsMEJ6?= =?utf-8?B?S2U4TUdjUW51dGRpMGNuOWZuaWN6N0h2eFA5QzVUZXJ5V0NYS01QeWRWSC94?= =?utf-8?B?ZFhpSVAyaGdGWmVUSGc4MWR4NzhxVVFVT0ZQbWMzWFlUSVVmdWxiNXQ1bDVu?= =?utf-8?B?R0lmS3k0WkJJNG9JQTZTbENVVzBpaklHeE56VWF4Zm1SVmlHWE9jYVF2RllV?= =?utf-8?B?K0VMUDRDZStlb2dDMHlpOHFwVnQ2ZDVjREplYzVjL1VKYURWc0I4SVhSejNj?= =?utf-8?B?a3BaL2NmeXNDV3dJSXZMR2gybGJlQXVaWmRLUDRHaHEzdHFra2xEK1dsZW5V?= =?utf-8?B?d3RsSCtxQzZaOG1nU0h0bHhSVDF6b2hYVGh2Z1NrNnFqeEc4a1pQUTJjNlU1?= =?utf-8?B?WHZGenk3R09QdWlQNi9vRlNVUUFEUnZaR3B1enhyZ20rVUV5cFFTTUZLaUlj?= =?utf-8?B?K0VSdzEyYzIrNkJEeWZHVUhIWWpDQ1E5QzIvVjJlY1AvaTNWT1plNjEyRS84?= =?utf-8?Q?dof7cC+GmpYSjRlN4aTRj8OUk6B0vB5PfFMOT/q?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5fbe9428-cfae-4b60-f7a9-08d8e49e4dfb X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 14:59:43.9131 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uhrlnpiC/YRAawoT0iQPE4OVKbA9CT1CdBoGwltaPa5l3fpR2RRt36BKGrIM6vQLoWlHrFJsQq08V3G4OTs9yQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3210 X-OriginatorOrg: citrix.com On Thu, Mar 11, 2021 at 01:43:05PM +0000, Andrew Cooper wrote: > On 11/03/2021 13:28, Jan Beulich wrote: > > On 11.03.2021 14:00, Andrew Cooper wrote: > >> However, having laid things out in this way today, it occurs to me that > >> we should consider further cleanup as well. > >> > >> I do agree that code wanting to use the libxendevicemodel.h API almost > >> certainly don't want/need the dmop ABI.  (i.e. an individual consumer > >> will want one, or the other, but almost certainly not both together). > >> > >> Should libxendevicemodel.h really be including dm_op.h? FTR, this is xendevicemodel.h. Just saying because it took me a bit to find the header. I'm dense today. > > I was indeed wondering. > > > >>   AFAICT, it is > >> only the ioserverid_t typedef which is API shared between the two > >> contexts, and we can trivially typedef that locally. > > Hmm, a local typedef isn't nice - there should be one central point. > > Granted there's no risk for this to change in anywhere halfway > > foreseeable future, but still. Also neither C89 nor C99 allow a > > typedef to be repeated - in those versions we'd then rely on an > > extension. > > I wonder if we're depending on that extension elsewhere.  As far as the > stable libraries go, we are dependent on a Linux or BSD environment > currently. > > Alternatively we can drop the typedef and use uint16_t instead without > breaking things in practice.  (As long as we make the change in 4.15 and > we lose the wiggle room afforded us by the entire interface being behind > __XEN_TOOLS__ previously). > > Thoughts?  I can't think of any ifdefary which would help, and swapping > to uint16_t would reduce the use of an improperly namespaced identifier. I don't see much problem in switching to uint16_t, it's likely what should have been used from the start in order to avoid bits of dm_op.h leaking into xendevicemodel.h. Or alternatively a new type that maps to uint16_t if we think that would be more descriptive from a header PoV: server_t or some such. At the end of day it should be an opaque handler from the caller PoV, or is it expected that the ioserverid_t obtained from xendevicemodel will be used as a parameter to other libraries? If you end up changing the type to uint16_t it might help to expand the parameter name to server_id or some such, as an id parameter with type uint16_t is kind of ambiguous. We already have some comment blocks to describe the purpose of the parameters, so I don't think it's a big deal if you also leave then as 'id'. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 11 15:09:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 15:09:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96654.183102 (Exim 4.92) (envelope-from ) id 1lKMvv-0002Bj-4T; Thu, 11 Mar 2021 15:09:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96654.183102; Thu, 11 Mar 2021 15:09:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMvv-0002Bc-1W; Thu, 11 Mar 2021 15:09:03 +0000 Received: by outflank-mailman (input) for mailman id 96654; Thu, 11 Mar 2021 15:09:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMvt-0002BU-Cx; Thu, 11 Mar 2021 15:09:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMvt-0007bz-6V; Thu, 11 Mar 2021 15:09:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKMvs-0000kG-VD; Thu, 11 Mar 2021 15:09:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKMvs-0007L1-US; Thu, 11 Mar 2021 15:09:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KoVPa2J+Q3DvYyzrHFIz8T+edcQUYfm2aNKEA/TBFxE=; b=G5Ke7QTcPa67dQIx9ovfrQTpCo BIfkLZVI2DhpXI1lOepB73LyPSNFvNb3kSuxfRXGJWBFmusJlBA/3v+1SNrlnojt1W3/oL8LK2qgs IjUCMemUTUcJsu53lA3YOlKSwfND+gDBAXLOLvjuEtBZuX5Bk1Pa2xLE9Akpa7liR1a8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 159932: all pass - PUSHED X-Osstest-Versions-This: ovmf=4751a48aeb2ab828b0a5cbdc585fd3642967cda1 X-Osstest-Versions-That: ovmf=54ba08c6b66090bdc03186110149bfe4b0f75208 From: osstest service owner Date: Thu, 11 Mar 2021 15:09:00 +0000 flight 159932 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/159932/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 baseline version: ovmf 54ba08c6b66090bdc03186110149bfe4b0f75208 Last test of basis 159924 2021-03-11 01:54:43 Z 0 days Testing same since 159932 2021-03-11 09:09:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Fan Wang Jiaxin Wu Siyuan Fu Ting Ye jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 54ba08c6b6..4751a48aeb 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Mar 11 15:30:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 15:30:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96662.183120 (Exim 4.92) (envelope-from ) id 1lKNGI-0004xa-SE; Thu, 11 Mar 2021 15:30:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96662.183120; Thu, 11 Mar 2021 15:30:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKNGI-0004xT-Oh; Thu, 11 Mar 2021 15:30:06 +0000 Received: by outflank-mailman (input) for mailman id 96662; Thu, 11 Mar 2021 15:30:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKNGH-0004ma-8H for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 15:30:05 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f9399197-7487-4cbc-b9bb-57ded3b6e8d6; Thu, 11 Mar 2021 15:30:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9399197-7487-4cbc-b9bb-57ded3b6e8d6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615476603; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=qZjfMbRRgHC6Vcbwl/dmWhEZuTHKgPOjyJVHTLOjFiI=; b=iQ0r17zHONtC7Y+iKHLEIO4qEhfdUsbj4NnwXevj5CZIKEi7XN7VHc1a 8Ge3dSBean5nAoo4BNc14JiC7n2m34i6q3R2mB2PqUetGuc1zQ1Vs83sg 9VGvPKf/R86lrYHsA6tV/vBI4gHQdEv4cfInq4CnzXFhjeAgue8bJQV1R E=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Tur9VbaaZls+DPT3gNvOkx1OCxxtH75J4KzifoTCx5iE1r/JEQV7n712KUSCewb6W58yWnpIA2 UnmEAfAJsS01GITnudyHCItCkQ9BLcGTeqKwzMMLfxvuwHXRY/0qgFPLg5hYO4YBr7YX4kYP5O 9o36NA8pGp5lDifFwmJGzDYMsswkE/lrau3wAwbfuJm9p5dux5a1P/XNxKT0mt9kJOquE61qhE 2/0wm0D0LvLLKVk33pBVJvQIr7Gorz5raoDGSYXxInyYIrVWJxDDsqosH2j6hOnuY2yjTkWKJS noM= X-SBRS: 5.2 X-MesageID: 40483467 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:52i+bK9CckXCcT2ZFFhuk+FLcL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmzybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIULD38Zn/+ Nbf6B6YeedMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsLV4hLxW5Ce2CmO2dxQxRLAod8OZ qH/8xcpyehf3N/VLXHOlAuWe/fq9rX0K/3eBJuPW9c1CCirxONrIT7HR+RwwsEX1p0oIsK3G DZn2XCl8Cemt6hzBu07R620713n5/bxsJHFIiwjKEuW0nRoyKJQKgkZLGYpjAyp4iUmSYXuf 3BuQ0pMcg2y165RBDMnTLX1wPt0Ckj5hbZoDfy6xaTwr2aNUAHIvFMio5DfhzS51BIhqAG7I tx03+ErJ0SNBvcnU3Glqn1fit3nUm5q2dKq59rs1VjV+IlGdhshL1a1kZUHJAcJTn9+YAqHc J/Zfusmsp+QBe0aWvUsXJox8HpdnMvHg2eSkxHgcCN1SNK9UoJg3cw9Yg6pDMt5Zg9Q55L66 DtNblprqhHSoszYbhmDOkMbMOrAgX2MF3xGVPXBW6iOLAMOnrLpZKyyq4y/vuWdJsBy4Z3sI jdUXtD3FRCO37GOImr5tlm4xrNSGKyUXDG0cdF/aV0vbX6Wf7CLTCDclYziMGtys9vQ/Hzar KWAtZ7EvXjJWzhFcJixAvlQaRfLnEYTYk7odA+d1WSot/aC4Hju+DBGcyjZobFIHIBYCfSE3 EDVD/8KIFr9UawQEL1hxDXRjfMdyXEjNdNOZmf29JW5JkGN4VKvARQo0++/Nu3JTpLtbFzWE N/Jbjgg56qvGXexxeN00xZfj5mSmpF6rTpVH1H4SUQNVnvTLoFs9KDPUdfwWWAPR06a8/NCg ZQqxBW9MuMXtKt7BFnL+jiHnORjnMVqn7PZYwbgLe/6cDsfY59KI0nVqx3HQDiDAd0hg5ulW dGZGY/NwziPwKrrZ/goI0fBenZedU5qhysO9RopXXWsljZmdsiXUIBXzmlUdeehCEnQzY8vC w3z4YvxJ673Rq/I2o2h+o1dHlBcn6eDr59AAOZX4lMgbzwdAZsTWCFuCyCh3gICxnX3nRXol akATyfePnNDFYYgHxe36rw2H5fd2mWfStLGztHmLw4MV6Dlmd40OeNaKb27nCYbUEaxPoBdB vfZyEJHw9oz9er9RKclTqYD086zpE2MuG1NsVkT5jjnleWbKGYn6APGPFZuKt/PNf1q+kRTK axfRSWID6QMZJe5yWl4lIefA96p3kvnam2hFnL7G2k0GU+BvSXClJ8XL0fK8yd6W+hZ/vg6u QMsfsF+c+LdkP2YZq67IuSSRhpABbau3S3QOElsoo8h9N7iJJDW73gFQLV33RG1igkJMj6lE kiUL12iYqxT7NHTog3QWZl5VInm9SEEVszviH3CuE4e0sxj3WzBaL/35P47Z4uCFaGvg3+JB 229DBc5e7MW0K4pPQnIpN1BWRdc04n7nt+uMuEao3LEQ2vM8VO5kCzPHP4ULhTTsG+aPgthy c/x9GDhOmMcSXknCjWoDtgO6pLt1+dfvnaOnPEJcd4t/qgOVqNhaO24Mm8yBfPIAHLFHgwtM libkwfbsNKlz84qpY4uxLCE5DKng== X-IronPort-AV: E=Sophos;i="5.81,241,1610427600"; d="scan'208";a="40483467" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fe54hH1DCj+HsbhRlIunzSp23ZvVkK2plkPGeAJ9v7rNqvUhiZ+HKBllyrNW06L+aNmpiXCBSF/81sUjnR6KOF2kqlNh8MsgMhMzIcDuKrnHF6Hg8bJRhkKzkaYmvinKZs1y+S4x/2jrhGKWswXCdOLPrOJqRB7dVfrg8O5rIWBPnD98LrP4dDjlZxpj/rpnbj8qlk/oOnRdIuh0DhTPKjJtJWfvp5JYMNrVhwq32CDSX1D3iMimwtkHGzZMnDahvAytLoOKjToD+n/2uqx3R5hSoJP6MZoUthM5i45HKdi0Lyg9K34gPnIin0Di4569PQoJTs6Y8ondk4/bU3WH5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=geDBbU9EjX8Jnex9QKdowsFek8INI4IykGSx1N6fHto=; b=BcjEOH9G6WyGGGs5P8wKvwoUIVWFpUyIdTUvxl8A1ToF+gHyEIJw9/GjVgQhINi2/kEOPgcUTZZ+YQcxHfboi5VvpLvIfWxcDcniWaLVJkQ3rY/0mA5tRN+zgKoHIj9KLrSCOM7eFeeyY5psdfJ8cfpR2Z4KXyZ1xfSg8I91tYl9hU3FJhuiDuhgBDkIz2KDzxKBbKXuSLbAa31sOIs1LLPqWFemxDa8qfYTgqoAWqNT4uEqXTcS56eqzO+AlMRcOHc9bvG5zYTobrOS+22gnqdLXfXeyJ6A0dgrO9NX4o0DAUIb5z/G/cYS3zJiA9V2PuDphafYgfeR/BKIxnsbpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=geDBbU9EjX8Jnex9QKdowsFek8INI4IykGSx1N6fHto=; b=SZKt/kzIk8QunYC/DC9n4CDJ+HgKyUxofYJkTgu7G8iBXU7LygdiyazQZYcwcMiGVCsUZKv57BwQa60s78mHufIYE3PEIahyJiYKEuD3ProzJdvXO6UcgSKkKWGb3AQQIVEKBaCgMgOL4mhumj5xWo6c9MZETs59Y4+Ve5bP3Ak= Date: Thu, 11 Mar 2021 16:29:27 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Ian Jackson" , Andrew Cooper , "Wei Liu" Subject: Re: [PATCH v2 1/2][4.15] tools/x86: don't rebuild cpuid-autogen.h every time Message-ID: References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> <1b8aee19-9194-153c-8dbb-0aec3412e255@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1b8aee19-9194-153c-8dbb-0aec3412e255@suse.com> X-ClientProxiedBy: LO4P123CA0243.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 26eca4f9-1ada-43e5-14b4-08d8e4a27849 X-MS-TrafficTypeDiagnostic: DM6PR03MB4139: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9iX24qdMiEUR1BID4J1d+YbGYBXDUrTyjV+T/zVPenLN/kGJGrRwxSuGuCbVIF35gS6pbe+QyHriRh/0cOvisV4AWiWyA4TtgtJsZ8O3dN56dQfhIs0rETxRW11Ul/xNI5yMP/4VhcO5EwSUOZN+0KCFLNP5waf8l9jGN3c+Oiqo5ef4IEVPwug4Ut0V4GL2mTL4FgzefRQfiemU2x/WA6lJbL+8GEwbGiKEcS+EomIiR+SIMV/wyzWcIxYfTH4wxmCix/t0fEEBzNpw7biRLXHROs/NdnalLseITKxxWNVNui+XaVdOdIubBPWoFYeY69CpcCgntk0ZEHmFWsP+ptELLRFH8+AvnMAQ4kYLElUYK6lX0YI7fIaOAbQvg6tLXdFgYHMv0wu7uw+cdLt+JUUnNf1EJYfdqs959sN4jHlbXuZL2bVi9rkX+uM4L0w11XU7ZeTBjQ/iCiIKPETSQOSbpzOajIAX1qYsTe/1Z8l92FzDPn83IciPO+MR8EO6zMRzNeu6h36ZPbQmqkIlhg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(396003)(136003)(376002)(39860400002)(366004)(346002)(478600001)(33716001)(6486002)(9686003)(186003)(16526019)(26005)(8936002)(2906002)(4326008)(956004)(8676002)(66476007)(66946007)(66556008)(6916009)(83380400001)(6666004)(85182001)(5660300002)(6496006)(54906003)(316002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WTU4OUNiRjFBUDB3cTloNEorYUt3RFVqT1NTNUwvSDNhdStkOUE5M2VXa2JP?= =?utf-8?B?dC9pTzZOajl0NXdwejFrOUtwVnQ4Z2tRMGtuNDFhK3I0cnJzbzZXOWVhbGx3?= =?utf-8?B?UndVemdtR1RDVzR3NS9tNmJlbmI5bzJiNnQ1emQrK2FpbExBS0h2ZG8zajVV?= =?utf-8?B?R0NneGRKUFZFRUlBcWdIVXU1TEU2aGVCN2kvVURhWU13Zzk5Vmh3SVhGSzlQ?= =?utf-8?B?WWtGWG9pRXNJN3J2SlJheWUxcVRvM0k3bzRZVFdUSVI3Q1pPaUVEc3QyeDVl?= =?utf-8?B?WE1yRnp3ZTlwSTkvdS92RXFjWUFOb3E2TGhQRGg2OENaY3hHL09hYWRacDdl?= =?utf-8?B?WVlHbDNlMU11OEt5VDVCaFdDdS9BSncwT3ZXa0M5eXpYU292V01LazJYTEFu?= =?utf-8?B?ZUViRU1Rb2VpdENRekJhTWVNZjNkbWtPK1R6OUw5Qm05RTIxZmQxeXQzb3lU?= =?utf-8?B?cCttN2lzUjc1djhYSVdCbVQrbTQ1Ym9JM3hEZGZ5VjBKZHlzYitTL3o4R2NT?= =?utf-8?B?WGhSeGFDZVI1Wk5hbzhsY3I4WCswYkpPV1E2T3E1UkdsUldqYmJyYWkvRHU3?= =?utf-8?B?L3JvSTA2WnYxaVcyR01VNHhLdlpFSjk2R3pFbXZjVW4xdzRmNWgvdTNSVi9I?= =?utf-8?B?WkhCS0tLVExESW56Z2FLK09QVGxINXEyRGIxTWtpRVZrZGhoZEFKWnhuSGJ3?= =?utf-8?B?aVNMRndJQ2NISSt1MzJxUnRQK3J1Y3dYWXdPQW5sL0JNWjIrMWJXZmlka0lC?= =?utf-8?B?UjVJeXEwWmJEemszSysrOHV4NG94S2lQYyttNEVRM0hXM0Z6R1E2dEV2enlH?= =?utf-8?B?d1hWMzRWSjNza3UzT3piMWUrNGxhWWZycGQ3MXdRMzNzMmZZM1N3NHNxSkp0?= =?utf-8?B?NmYwZ2Q1M2k2YWQ2MStMMHV1clI3MDVYdkh0WXRmZGRsSjV2b0MrcjN6ajd3?= =?utf-8?B?S2QvV2hLcVRYSjUrSWFDdFdyZHh5eHpKMVI5UWNjK0ZIUnhFdlRkdEloM3VO?= =?utf-8?B?enloc1hncnZvMFczclB1TDFLLzU0SGpmeklNREtBY3FlWUhJazE5cm4xQVBq?= =?utf-8?B?UlhranNNOXhqR1ZnM0ZxZnBsU1d3NmRKVnpWU3IvdnlRaHFvS3ErTXFITlZB?= =?utf-8?B?N01EZWFjWGxtd0R5M01JV3BoMENHejRaKy9HelJ1Qks2OThGUWhSWG9MME90?= =?utf-8?B?MUorVGZIbmJua05DNVBmblhWT21kZS8xTHVod1gzZHliWnorR3dtd3YzUkpZ?= =?utf-8?B?dDdzcnpFN3hCaHg4SExsYVlBc0NDbnh1VWRhN0hCT2hjR0RIM3huczRQeWhx?= =?utf-8?B?UmdYbXFQemo5bzNsMU5ObzRiSFlLY0tOSFpSRmJRRDJBbW5qZ3hGQzh6Wkd2?= =?utf-8?B?VmU3ejZNZW04UGRlemtoM1FPelVyc1FmVGlPd3VqcmFkSHp5aWNMQ2laWFJJ?= =?utf-8?B?TU5kYUd4TC8vVTdybk1YcnFhRXEvRWxQSkQwUTJxV0pOcFJZa2tlWXBsakFY?= =?utf-8?B?dDYxaDh3QkpncVp2MmM1UnlmdW0rSnhNZUtRQncrdjBnUUc1dmVaVFpmYlRM?= =?utf-8?B?TERETk1SenY0TWRoWjVKSExZVnIxcXRaTmdoVHRBdkt6WVNyN3V5amVFM1RM?= =?utf-8?B?S2k2SXdjcFhiOElBOGpJNWFMSWRGQ3NaS0dvMUtNYm9WaUc4TEdqMVpOcWVi?= =?utf-8?B?WmR0M1FWWGxkcnRrN0ZRVlZBQXY2akdFTXVXUDN1SUs3MXRVWTNCWGZReE9s?= =?utf-8?Q?5mis98dSvBKlM4tY+RySNj212oWN4CtdwaPdx95?= X-MS-Exchange-CrossTenant-Network-Message-Id: 26eca4f9-1ada-43e5-14b4-08d8e4a27849 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 15:29:32.8657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 01bCuhs//Mlv4yUZmBV9WPL3jt31USEHp7Eu/enSYzeS+3d64JQC2pLdvPnVZkjzteOYlno7dL3crnFf+w1VYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4139 X-OriginatorOrg: citrix.com On Thu, Mar 11, 2021 at 03:40:05PM +0100, Jan Beulich wrote: > The first thing the "xen-dir" rule does is delete the entire xen/ > subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a > result there's no original version for $(move-if-changed ...) to compare > against, and hence the file and all its consumers would get rebuilt > every time. Instead only find and delete all the symlinks. > > Fixes: eddf9559c977 ("libx86: generate cpuid-autogen.h in the libx86 include dir") > Signed-off-by: Jan Beulich > --- > v2: Different approach. > --- > Ian did suggest to pass -0r to xargs (and -print0 to find), but I > couldn't convince myself that these are standard compliant options. We > don't use any special characters in file names, so -print0 / -0 > shouldn't be necessary at all. The stray rm invocation when there is no > output from find can be taken care of by passing -f to it. Why not use `-exec rm -f {} +` instead? That seems to be part of POSIX and is likely nicer than piping to xargs? > > --- a/tools/include/Makefile > +++ b/tools/include/Makefile > @@ -19,7 +19,7 @@ xen-foreign: > $(MAKE) -C xen-foreign > > xen-dir: > - @rm -rf xen acpi > + find xen/ acpi/ -type l 2>/dev/null | xargs rm -f -- Do we care about leaving an empty xen/libelf directory behind? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 11 15:36:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 15:36:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96666.183135 (Exim 4.92) (envelope-from ) id 1lKNMB-00058o-JW; Thu, 11 Mar 2021 15:36:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96666.183135; Thu, 11 Mar 2021 15:36:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKNMB-00058h-GQ; Thu, 11 Mar 2021 15:36:11 +0000 Received: by outflank-mailman (input) for mailman id 96666; Thu, 11 Mar 2021 15:36:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKNMA-00058c-VV for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 15:36:11 +0000 Received: from mail-qk1-x72c.google.com (unknown [2607:f8b0:4864:20::72c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 05769cc7-1b17-4eb8-98df-18100affbcb1; Thu, 11 Mar 2021 15:36:06 +0000 (UTC) Received: by mail-qk1-x72c.google.com with SMTP id l4so21009157qkl.0 for ; Thu, 11 Mar 2021 07:36:06 -0800 (PST) Received: from doug-macbook.localdomain ([2600:1700:7b90:52f8:18d5:dd06:1f1d:2bc3]) by smtp.gmail.com with ESMTPSA id z78sm2236981qka.38.2021.03.11.07.36.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Mar 2021 07:36:05 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05769cc7-1b17-4eb8-98df-18100affbcb1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cardoe.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=w0hczY3LkgJQNxgNZ6U/OWoNmbhV17x3WYdNyRJJhBw=; b=b2GvqvrjleC4xULgYK/PfgYUd+n0n3S79qbY8+Y/xvpqFkYqwMX7EQAtc0CwK7y5So 9rX3bv/mkv2Aldisdsa2ohFn3AoexK3kqsbwK26SRizk407KPSaIMLNorbWXmGsVrPD9 DZ1m2UmNiMOCbKzc68NCKXg9NnprKclm4sGwg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w0hczY3LkgJQNxgNZ6U/OWoNmbhV17x3WYdNyRJJhBw=; b=fPVPKRO6+/HFMXyN3FL//5ZXYbm0WPgwS7TJSRCPOXlWtez4lJopz6xu4TqORJt6y3 yFq9wisnCZtgqhdeA9ZtXmI3b9KbnYDPyVAroP13Jj8q28/6sKqULPcCQI6JLYa8/7Z0 fivuovRr2fDn+8FdIkWAPlit8LOEZe6zGmyleKmk0Rp03jJk0B7yr338mciqY5JOlpqz IOPBcduvCa2OnOnzTZdEfvBWdErH6qDXLNEsYdd7f8ojZof8lZDnpWOsJXHbi0W6FhDb H1Zrt2fji3j3cGxuYaRtJHWOALlCaI6Skm6DBJ7hIXVC9q1QHCXyGcOfxz+chFCizzhr pD/w== X-Gm-Message-State: AOAM531xw2sfteLlbEy/EbHfUzg8i2JKoesE0LaZ75j7p9Ydb9nbLeWN GDp92CtRbIGIPtRI8w5DJ/BiwQ== X-Google-Smtp-Source: ABdhPJwEYJcOfHKszMAtn0IELmw04x/5oGVu6GDCYtE9mZeq/O1QLu4/ZEjfWfAUnmJhmjW1HaCR5Q== X-Received: by 2002:a37:2756:: with SMTP id n83mr8029246qkn.70.1615476966438; Thu, 11 Mar 2021 07:36:06 -0800 (PST) Subject: Re: [PATCH for-4.15] automation: allow doing hypervisor only builds To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Ian Jackson References: <20210303143316.16840-1-roger.pau@citrix.com> From: Doug Goldstein Message-ID: <3652cbaa-a073-feb3-8f2b-94b40e60f098@cardoe.com> Date: Thu, 11 Mar 2021 09:36:05 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210303143316.16840-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 3/3/21 8:33 AM, Roger Pau Monne wrote: > For things like randconfig there's no need to do a full Xen build, a > hypervisor build only will be much faster and will achieve the same > level of testing, as randconfig only changes the hypervisor build > options. > > Signed-off-by: Roger Pau Monné > --- Acked-by: Doug Goldstein From xen-devel-bounces@lists.xenproject.org Thu Mar 11 16:00:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 16:00:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96672.183151 (Exim 4.92) (envelope-from ) id 1lKNjV-0000HV-OR; Thu, 11 Mar 2021 16:00:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96672.183151; Thu, 11 Mar 2021 16:00:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKNjV-0000HO-L3; Thu, 11 Mar 2021 16:00:17 +0000 Received: by outflank-mailman (input) for mailman id 96672; Thu, 11 Mar 2021 16:00:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKNjU-0000HJ-FD for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 16:00:16 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4a87cd76-f322-43a4-95e0-f0284fcf9f04; Thu, 11 Mar 2021 16:00:13 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EF743AE42; Thu, 11 Mar 2021 16:00:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a87cd76-f322-43a4-95e0-f0284fcf9f04 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615478413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2AMgF2g8QQqIRmOc1OaUPevEQnhToTdQO7MfNVOmchE=; b=DK12Gw8wCYpXO3iegHzJ1EquXqu6rMCZZODSfSOBuE+RNo6l0s2Rt/zjNcFoYTQLw/VoiE HOk1IBC5gM215ecrV+NEzN+KKMYQTx2G7PgUc2bQQPlK6b+gMN6+ZKPP8G9K3Vrz4hDnsA 3uHkN4Zn74dO8xKi3QsRefxUyFOoou4= Subject: Re: [PATCH v2 1/2][4.15] tools/x86: don't rebuild cpuid-autogen.h every time To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Ian Jackson , Andrew Cooper , Wei Liu References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> <1b8aee19-9194-153c-8dbb-0aec3412e255@suse.com> From: Jan Beulich Message-ID: Date: Thu, 11 Mar 2021 17:00:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11.03.2021 16:29, Roger Pau Monné wrote: > On Thu, Mar 11, 2021 at 03:40:05PM +0100, Jan Beulich wrote: >> The first thing the "xen-dir" rule does is delete the entire xen/ >> subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a >> result there's no original version for $(move-if-changed ...) to compare >> against, and hence the file and all its consumers would get rebuilt >> every time. Instead only find and delete all the symlinks. >> >> Fixes: eddf9559c977 ("libx86: generate cpuid-autogen.h in the libx86 include dir") >> Signed-off-by: Jan Beulich >> --- >> v2: Different approach. >> --- >> Ian did suggest to pass -0r to xargs (and -print0 to find), but I >> couldn't convince myself that these are standard compliant options. We >> don't use any special characters in file names, so -print0 / -0 >> shouldn't be necessary at all. The stray rm invocation when there is no >> output from find can be taken care of by passing -f to it. > > Why not use `-exec rm -f {} +` instead? That seems to be part of > POSIX and is likely nicer than piping to xargs? Hmm, I avoided it because I was under the impression that there are (compatibility) issues with it, and Ian suggesting xargs seemed to support that. I'd be more than happy to avoid xargs, of which I've never been a friend. >> --- a/tools/include/Makefile >> +++ b/tools/include/Makefile >> @@ -19,7 +19,7 @@ xen-foreign: >> $(MAKE) -C xen-foreign >> >> xen-dir: >> - @rm -rf xen acpi >> + find xen/ acpi/ -type l 2>/dev/null | xargs rm -f -- > > Do we care about leaving an empty xen/libelf directory behind? Why would we? It'll get created immediately afterwards if it's not there, and it'll initially be empty (not for long of course). Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 16:12:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 16:12:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96675.183163 (Exim 4.92) (envelope-from ) id 1lKNve-0001Qp-U6; Thu, 11 Mar 2021 16:12:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96675.183163; Thu, 11 Mar 2021 16:12:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKNve-0001Qi-QW; Thu, 11 Mar 2021 16:12:50 +0000 Received: by outflank-mailman (input) for mailman id 96675; Thu, 11 Mar 2021 16:12:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKNvd-0001Qd-HG for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 16:12:49 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fd6bff08-de3a-433a-8ca7-c3a77577da9a; Thu, 11 Mar 2021 16:12:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd6bff08-de3a-433a-8ca7-c3a77577da9a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615479168; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Ok21gEVIFIZ2JeHd1Iju3z6QwQK/hFfdqgD0dXrL0nA=; b=QFxBymafUB9Wa9lJO3UCCRaP/KhKEt4ET3WaJ+xav0Dg8KiqJYp8ORnh fgdwsCDG7ircWFpDi7FKeE/A63AE4X2HAsu7wqqlujd/V55oiDyUA0cgO H6W84HM+gL8X51bgN5/lm21NUt4x4Oc2TDb4foJKpJXMal+CP0vvzoIhn E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: NidfVW3n1w35/ExbjR6M+l7fN/iqu1JIhr+C1V3PzjqH59UpR3uDLcUxSxtbAr24HvXXSMJD3r rZ+hxnPe/8Bx3Z7n7kvu6Ho15ZlYunnZSjmobld2YpbREIpPSr99GFoD3qzMmK5pQvJWasksq0 PhOu7uoqa8JMH3F948JXiZCDcN6TZQSq/lW7rq+BzN/iXJ/nT2ZJRLY0ay/ZRV3QrLkCTY+Asa hrM5ug1mfGH8O+M0ic9vmxCACXRoIveRQIdbMNqSs6UTAqGXxqF0B9ujOve0IN9Mch0yLEfsse xvM= X-SBRS: 5.2 X-MesageID: 38982238 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:0DGx365/v9XvrgrPAAPXwXqEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoex3h3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdBHW3tV2kZ 1te60WMrHNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2FXQotLhj0JbDqzOEtwWQVAGN4VFI CE4NBGujqnfh0sH7mGL1MCWPXOoMCOqYnvZgQICwVixA6Fiz6p77CSKWnl4j41VTRTzbA+tV XUigCR3NTYj9iX6D/5k1XS4ZNfhcf7xrJ4ZfCkp8AJJlzX+2OVTat7XbnqhkFQnMiO7xIQnM DIs1McOa1ImgzsV0WUhTeo5AX6yjYp7BbZuCylqF/uu9bwSj5/K+cpv/MgTjLj50AtvM5x3c twtgrz3fcnbmKj7VHAzuPFWB1wmk2/rWBKq59ps1VlXZYDc7gUlIQD/SpuYec9NRjn44MqGv QGNrCk2N9qdzqhHhfkl1gq6tmtUnMvJwyBU0gPt+eEugIm7UxR/g82wtcSkWwH8494Y55Y5/ 7cOqAtr71WSNQKBJgNS9spcI+SMCjgUBjMOGWdLRDOE7wGAWvEr9rS7K8u7O+nVZQUxPIJ6d r8eWIdkVR3V1PlCMWI0pEO2AvKWn+BUTPkzdwbz4Rlu5XnLYCbchGreRQLqY+Nsv8fCsrUV7 KYI5RNGcLuKmPoBMJgwxD+YZ9PMnMTOfdl+uoTaharmIbmO4fqvuvUfLL4P7z2CwspXWv5Hz 8tRz72CMJc7l26e3PxjRTLMkmdP3DXzNZVKuz37uITwI8COslnqQ4Ok2m04cmNNHljv8UNDQ 9DCYKitpn+iXi9/G7O4WksEAFaFFxp7LLpVG4PgQcLNkjzYIsSotn3QxEU4FK3YjtEC+/GGg 9WoFp6vYitKYaL+CwkA9W7dkWXkmUUv3DPa5sHgKWM6YPEd/oDf9cbcZ00MT+OOw1+mA5spm sGQhQDXFXjGjTnjrjgqocVCuHZf9xVmxyqPsZQlHLauSyn1IMSb0peewTrfd+cgA4oSTYRrE Z26bUjjL2JnivqFXEym90iMFpHaH2eBZVPCAjtXvQTppnbPCVLCUuajz2TjB8+Pk7n7V8biG DaISqIQv3TGVZGtndE0qHlzUNsegymDjBNQ0E/lbc4OXXNu3513+POXKa13meLQnYpw+0WMl j+EHEvCzIr4+ry+A+emT6EG3lj+44nOfbFCq8/N5vJ3Gm2FYGOnaYaPvNd8Zp/LuryuusTXe /3QX7NEBrIT8cSnyCFrHcsPyd57EQ+mfTzwRv/8SyW2mU8Dfe6GiUue5grZ/Wnq07qSPaD3M 8n0ZYbve6sPn7wbdDD46fNdDJHIg7Sp2nzb+xAk+EigYsC8J9IW7/cWn/08VsC+jMUBsL9jl kfT6R2+6qpAP4lQ+UiPwZiumM0n9GOJnYxugP4AuUCbUgg5kWrS++h0v7tk/4TGUWPqwv7BE mH/wBc9/nDWTGf1bRyMdNHHU1mLGw94m9l5uWMasn5DxirbfhK+DOBQzKAWY4YbKiOArMLqB lmp/mOgu+MbiL9nCTdpyFyLK4L02GpR6qJcU6xMN8N19yxIlKXhKS2pOa1kTfsUDO+L30iur ctTz1ZUu1zzh84jIM21SCuSqv45mId+mEunw1PpxrKwYip4GDSAEdcFxbW668mBQVuDg== X-IronPort-AV: E=Sophos;i="5.81,241,1610427600"; d="scan'208";a="38982238" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n6iZNkkdAPkwZx+EAr22d1YwCSwf3GLhpVBg57rsvJfRzKd3qbT2Vrbv5jT4tkFwti9bGfbogmjp3g/RO+sPScYdKkiBwk5Ov1QjIsF1/5PZsu1qk1s0CIDfMSeJIZ66g2ITww4JWDrSGEsbvYx8cv1OJEq4cVgQxVF99JHFUzqLFCgsnMexHuJzBGomX8wRx5SGJ1nwA6vl7WNAbZ0kBTgS0nZQee5eiBWe02GuCk7NlX9ItQov8adbygjqEw4VcmWTP7Dw6C7ApKINo8QsTZ/R2ezGQTZItETPvFc4oYN74G4tsgZ+BHlO34D5pOfvzrG5scoZeANG8G0o4hydxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l1h4eBNBRVg/D53iyzM+NT306xc9zw0gYmxHjMYp8rA=; b=kTtvyj+QZAz7z4RSe6kKTVztXwmVsDq+9zsig/NLAW5GubEZtp0YaXMSiODdfrYC4yv/TM+kDiWS2Y7g57CwGuua6PMkS3cKaMz1hHNakZWqpBBA5SLRESBwIQmRsV2T6BNXz0YTLWg4P4yi1WDv8VHIMSe40uxMlCPWDpoR66N/oYYwAKifT6Iqh4gOQ5//hKr6ahKZAvFFPRy1vDQDVOF+ZJc1a8NfzMK8hvFtaMhj7zAOa8t79sltU7DKe64jBy3pOCpVLqjhtQt8yt3qcpfeO/4CNkkq8HOJSb0C91QtK1KiDOGi0f03UoLOLgSb/q+vqzoPMo2L8OjTA9ZHmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l1h4eBNBRVg/D53iyzM+NT306xc9zw0gYmxHjMYp8rA=; b=JOySVwwtfT2/KsnxNa8CfqtEKcK+PE5/Sq2EqUbi+T+SDFX4oQB7JaKyhANigVo3DIk4b1IbQenk40rCUUvM11LawtM+NFEeLDfgFl74HLJy7mCy5ah8kOBIvzerOAOQ7xREzeNcA96es4IXfUelDwI/FZxE+9cIHO764xdRd78= Date: Thu, 11 Mar 2021 17:12:22 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Subject: Re: [PATCH RFC] build: detect outdated configure outputs Message-ID: References: <20210311114601.42460-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LNXP265CA0037.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::25) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d038034e-b140-4c1a-7b3c-08d8e4a876a9 X-MS-TrafficTypeDiagnostic: DS7PR03MB5463: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aQk6U3fNQvtwWPbhhibWkZhGsuKefR8b0y1zcLBhIg3Ta0iO5PB8qdxBbqmG656DJL9SY7OJeIk1s8yuBphlcp94eYPRAfrpcyQsc/DEKaZYQmORLQrOtC7dQD/Q6xgrt48vfQvtQnGXBVLhsKeajxwZGRb1aJIeNjD/nsrnVyhoQNnnCSo61SVG+Yjw0c+oFk1Xfd+cYEP2lUzAz6gnTjSzhQAA6HZd7zjFh/c0NIzwhq1fPdw2QMwuJ4DXX47BG4kFXiYzAvZgFl93T74tTr62zxGhtf56MKS5KC4/nba0Bl2m8BLewrR3/gVoNYcGQOje1grCI0VXA6hqk8/zyMgJMMxziFVkYhWqX7hVMdXc1ytmfKJ3Qh6p6uICoIWneCtmCTZ5ZMe+bFkElaAyvrY1n7WDtHcsfCv1ycFFh7O/Ft1vRDFXvLBkQ0WiKM7oTr53yA/vmVAnkHfGkbSmeU9haKWWJaewP0aVi4AQPvtOqOSa4QuFqHDomWrhfPSTEVXYzmuvgGfkXbSc3yXQqw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(39860400002)(376002)(346002)(136003)(396003)(366004)(316002)(4326008)(53546011)(66476007)(66556008)(8676002)(6916009)(186003)(66946007)(54906003)(16526019)(956004)(83380400001)(8936002)(6486002)(26005)(33716001)(2906002)(478600001)(6496006)(86362001)(9686003)(85182001)(6666004)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MkVTbG1NQS9ncEZ0TUQ0QlBBcEkyZFlzVkZ0S1ZPTjJTc3pZSzlwR2tFQkR2?= =?utf-8?B?WG1palR2WmhuaTJvMmxsZ2RuTDVSVWhsRjZnbStLa0NlRC9RcFdSMHpaN0Yr?= =?utf-8?B?MjJZbzlNWXhxclF5U1Y1K3dCbC96WDBDaFhVdGFFbG5heHJqWXVJSkdFb0Zt?= =?utf-8?B?SFowRVdWczV5UlFYUVhYQTJXYUpDQ2FTSmhXMzJvMTlXem5qTlZSY05OdTdC?= =?utf-8?B?T3RXUmxQalcwMEdKL0JHeDRoREw4MXdST3lrZjhuaTZkbEo0L0ZXUWVPRHpn?= =?utf-8?B?WEY4SU1XcVBTSU9jeHVqUFpZOGVwV2dvS21oeDV3Smw0bE5WR3ZKN3Yrc2c4?= =?utf-8?B?VHFEWG5NWHd0bG9yeDBqYmFZRDhNOG8xbjQvK2M1U29oYSt4elBDTW1vWFpL?= =?utf-8?B?QnkvS0FtQ2VJTDBpb0FZanF3ZTg2OGJLOXdMamZZd2RJczUyVnExcFJJV0l5?= =?utf-8?B?QzF3TUlMbkxIT0l2OGp6ZFRmVnJPTEtNRE9FakFvVGpBb1d3dHUxaEd2YUtG?= =?utf-8?B?QkJJU2d4Z1NIQVVKUWszWXFHSGtCczNvQkYrUXNwaFVhd3kwdHdCN0M4ejUy?= =?utf-8?B?TmpHQ3lBM0w3QmhjY0F2T3NFcXptYUtzbkVZcjBRdUNKMHFKcHkzM2tkMUpx?= =?utf-8?B?dHE2Y2UrYW5aNGI2Ymc2RUVOcFVEeEZCUUV2KzFZcEQ2a2U0ZUczZWdiSDRG?= =?utf-8?B?Rm00djJWUWE2K0xSY1lIajZZcm52eGlwUXBKcE11T1h0eXkvL0FIZTFBTWZ3?= =?utf-8?B?N2pEQ2tvVHlSS2U4Q2Fvb0JKTzExZ1NsV2JiTitYanFqMThLUVoybEtkOE9o?= =?utf-8?B?Y25aUVRhSVE1UVp1WlpiUWpEN3pnR1k2d2Q0KzZMS1ZNOGRUdXNyQ2JFR3da?= =?utf-8?B?VlRaZEk5VTNMcStDcWl1S0pWWXQwcjN6dURUdC8ybjRzMHpydFJSRTYrY2hE?= =?utf-8?B?Smsrb2R1SVhqcnAxVTMzN3dubm5uRnI3dXArdGY5MThVU1d6OW81VmdoTFQ4?= =?utf-8?B?SUFWamhTSHVMRlVqY3BjcERhbEwrcHZzUjJFL1l1ckNKcDhnYVVURVBhS3Fp?= =?utf-8?B?aksyVmI4U2kvNmZSMnZYSiszTVpvMHdSQzdFbEcvQnhwbllPZ25vTFJ2WGd4?= =?utf-8?B?YTJpbklIdFFjTFZWY3lIcVVjZ2UrWjdpcHZOeTl2WFhzUERCSTlzSGc4K0lF?= =?utf-8?B?dlUybGYzODl1ZUE5NncxZzVMUzl1NlVBZnAzd3FRR201UVBQVWM0clVNU1dm?= =?utf-8?B?YW5XSEpiNGZTTHRRZXJvQkJPVFNIdW1CNHdDT1pNTmVmbVJKYkEydTZDTWlT?= =?utf-8?B?NXp5TTNKTE5kOEhKZWlsQk5jenluSHNMRHJhV3NXU3pRdHpuTFpDQWxteExp?= =?utf-8?B?N1VpdktkUHFmbWFjWFpPREFTM2ZWV01yalRmMTJNbjV6dnU3d0k4UXFWRFp6?= =?utf-8?B?UUh2Lys3Y1FJR0F3Q2tTUEQxR2N5dmU1SGR1bGg4U2c0d3JHMFlBejV6c0la?= =?utf-8?B?NFN1S3VFQlFmMEFvYTBjcFAybG9GdUs0T1Nmd1lqdWlab0lXYndQajdnMmwz?= =?utf-8?B?cGkzeGMwMi9rRll2dXN2dlBMaXZIcUdFc09pTDZIQlZTc21oNEdCWHVoRjRz?= =?utf-8?B?dVgzcDhoWUc4bVJ0ZFAxSnFRQ3owSjNEbVpkbXJuWGRvYWtGUWtGMmptNDRP?= =?utf-8?B?WUVZbFBhZTZ0RWZJTkdqdjVWQWNwaVFheTNTRmlmTmpESXJvYXg3QlQ2SitG?= =?utf-8?Q?rrLTyzx7urcPBpSKreDkcSX40jI8kehJMQnjnW4?= X-MS-Exchange-CrossTenant-Network-Message-Id: d038034e-b140-4c1a-7b3c-08d8e4a876a9 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 16:12:27.0965 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O15NA1NiQFgQI50dEWs3SlXoyytkK8+Lu+iNWq6K2nTEiNCT+/NPMdePaW9IXhQNK2Dj15bB48JczTBMyAAEtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5463 X-OriginatorOrg: citrix.com On Thu, Mar 11, 2021 at 02:01:53PM +0100, Jan Beulich wrote: > On 11.03.2021 12:46, Roger Pau Monne wrote: > > The Xen build system relies on configure to parse some .in files in > > order to do substitutions based on the data gathered from configure. > > > > The main issue with those substitutions done at the configure level is > > that make is not able to detect when they go out of date because the > > .in file has been modified, and hence it's possible to end up in a > > situation where .in files have been modified but the build is using > > outdated ones. This is made even worse because the 'clean' targets > > don't remove the output of the .in parsing, so doing a typical `make > > clean && make` will still use the old files without complaining. > > Note that 'clean' not removing the output of the .in transformations > > is the right behavior, otherwise Xen would require re-executing the > > configure script after each clean. > > > > Attempt to improve the situation by adding a global rule that spot the > > outdated files as long as they are properly listed as makefile target > > prerequisites. > > > > Ultimately those substitutions should be part of the build phase, not > > the configure one. > > > > Signed-off-by: Roger Pau Monné > > --- > > RFC because I'm not sure if there's some better way to handle this. > > Also I think we would want to make sure all the .in outputs are > > properly listed as target prerequisites, or else this won't work. > > > > Also not sure whether this will break some other usage of .in files > > I'm not aware. > > There are a number of such files in the tree which aren't used to > record configure results. Whether their existence could actually > case a problem with this approach I can't tell. Would it be > possible to ... I think having other .in files in the tree is not a problem with the target I've added, as it would only apply to files that have an .in pair and are used as prerequisites. > > --- a/Config.mk > > +++ b/Config.mk > > @@ -65,6 +65,10 @@ DEPS_RM = $(DEPS) $(DEPS_INCLUDE) > > %.d2: %.d > > sed "s!\(^\| \)$$PWD/! !" $^ >$@.tmp && mv -f $@.tmp $@ > > > > +# Make sure the configure generated files are up to date > > +%: %.in > > + $(error $@ is outdated, please re-run configure) > > ... make this a static pattern rule for just the file names that > are actually processed / produced by configure? Of course it > wouldn't be very nice to have to keep in sync that list and what > the various configure.ac scripts list in AC_CONFIG_FILES() et al. > But not listing the targets explicitly would always risk the rule > to kick in for a file where it's not supposed to apply. Yes, I think it's going to be a pain to keep the list updated, as it's part of two different configure.ac files. >From a quick look there are other .in files used in a similar way by ocaml, so those targets will override the pattern rule (%: %.in) in some places, for example in tools/ocaml/libs/xl/Makefile. I think this should be fine. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 11 16:18:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 16:18:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96679.183175 (Exim 4.92) (envelope-from ) id 1lKO1W-0001n4-Ja; Thu, 11 Mar 2021 16:18:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96679.183175; Thu, 11 Mar 2021 16:18:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKO1W-0001mx-G1; Thu, 11 Mar 2021 16:18:54 +0000 Received: by outflank-mailman (input) for mailman id 96679; Thu, 11 Mar 2021 16:18:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKO1V-0001ms-Bz for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 16:18:53 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7003e126-7f8e-4cb5-b2a8-de938ca58d3f; Thu, 11 Mar 2021 16:18:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7003e126-7f8e-4cb5-b2a8-de938ca58d3f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615479532; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=x7YUYrmdrRgeguyBY9JGjIqs+8LZL7I2/XLMJjbfXG4=; b=gDigL+DV2exS/1GPYCGUivdacNTYGf7Z8lT8YTYQHf0f9nTslCb676Pn RG4TjTkca97bk8qGCizzwFsY4DCvfaxpy+jqVbm5CMjq2NdiSYmrdzwJX fdVTeJMqZRjPfm6JYiz0eDGlfr9/2Rmypiqqe2EOIdStJUy1kWeSa46tW Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: wa9iYxhT79aHbbOR9AyHkXuZe9lHhjJpFIkNxRI6c0jB3NItdicUYkRYpQktpWiQHOnhRfXbTm qbHQisPb32rivUhS/D/wAAHGOL8FgqDSlk2PjFva5P4m99j8SbSCZQVTak41ghsbZKUUPtmety BIJEvXOLguNlIk628j3x5xQ6MXLh3oPM8NegCqdAgOrBj+xTfLYDEwjyBAZdmTPdhvFBKfFrE/ JzkzjOVeKHJ+8qaAs8Bm58f8AaVvdW8TdXFa0LvOep64tkY2s9N4Lcbr9bHV4E7kOMTLWk7puV kUY= X-SBRS: 5.2 X-MesageID: 39068817 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:mlvOoKCaPoVdmv/lHegDtMeALOonbusQ8zAX/mhLY1h8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPvfVr1zrQwxYUKJ7+tUE3duGWuJJx/9oeK+VLdMgXE3Kpm2a 9kGpITNPTZEUV6gcHm4AOxDtYnx529/Lq1gPrFpk0McShBQchbnmNEIyycFVB7QxQDIJI/Go aV6MYvnUvfRV08aMOnCn4ZG9XZr9rQm578JTIADRgr6A6B5AnYl4LSOR6ewxsYTndz0a4vmF K17zDRy4eCl7WAyhHa33LO9Jg+orrc4/ZKGcDksLlvFhzCkQCtDb4RPYGqnDdwm+237UZvrd +kmWZcA+1Wy1f8Ol64ugHs3Q6I6kdd11bHxUWDiXXu5ezVLQhKc/Zpvo5SfhvH50dIhrgVu8 gnrgHp1esiMTr6kCvw/NTOXR1x/3DExkYKquIPk2dZFbIXdb45l/1twGpuDJwCECjmgbpXad VGMce03ocyTXqndXzD+kFgzNuwN05DZCuucwwpv8yY1CVuh3Zpz0cU79x3pAZxyLsND7ZD/O jKKaJuifVnSdIXd7t0AKM7TdKwEXGle2ODDEuiZXDcUI0XMXPErJD6pJ0z+eGRYZQNiL8/go 7IXl90vXM7EnieSPGm7dluyFTgUW+9VTPixoV1/J5ioIDxQ7LtLGmqVE0uu9HImYRcPuTrH9 KIfL5GCf7qKmXjXaxT2RflZpVUIX4CFOUIp9cAXU6UqM6jEPyoisXrNNLoYJb9GzctXW3yRl EZWiLoGclG5ke3HlDihhz8XG7sZ1zf8Zp8HLOyxZlW9KE9cql39iQFg1Ww4c+GbRdYtLYtQU d4KLT71oO3zFPGulrg3iFMAF5wH0xV6LLvXzdhvgkRKX75dr4FppG6cWBW132XGw9nQ6rtYU hijmUy3ZjyA42bxCgkBd7iGHmdlWEvqHWDSIpZvaGf+8H/eNcdAow9UKJ8USXHfiYF2TpCmS NmUkspV0XfHjThheGOl5oPHtzScNF6nUOMOs5bqXXWsG2GvsExTn4nXzqjOPTnxDoGdn5xvB lc4qUfiL2PlXKEMm0kmtk1N1VKdSCqGr5cNR+EY49Vg7jvXwl1QQ6x9GWnoiB2XlCv21QZh2 TnIyHRXf3QGFJStkpV1bvQ/Epuen+QeF9xbX5GoZRwfF62z0pb4KuuXO6ewmGRYlwNzqUmPD bJbSA7Dyluy9q0vSTl1QqqJDED/NEDL+bdBLMsf/XvwXurMpSPjrxDNeRT5oxZONfntfIrXe qTdxSOFi7xD/ok1mWu1y4YERgxjENhveLj2RXj4mT94WU2BuDKJk96A54cONOR4gHfNr61+a Q8qehwm+S+Mm/8MIHbjY7WaiNOMRPVryqdSfoypZVdoKI1s/9SEvDgIE31/UAC+C97CsH+0H 46auBcxpvqP4d0Zcwcey5D5DMS5Z6yBXpuljazO/M0eFEmsmTSMNyI6YfZsLZHODz3mCLAfX 2ktxBH9/jLXyG/xacXJqI5L2NRclU94h1Zjaq/XryVLAWhbOdY+lWmdle7bb9GUaCAcI9g4i pS0pWtn+WNcTD/1x2VlTxnIrhW+2LiZc+pGgqDFapp9NO9UG78zZeC0YqWjD3tTyG8ZFldrY pZdVYIZsAGswIctuQMo2OPY52yhFkknVtY6SxmkVCo+rHO2harIWh2dSvDgptXWjFPNGOvls qty5nC6EjA X-IronPort-AV: E=Sophos;i="5.81,241,1610427600"; d="scan'208";a="39068817" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QIBAlC5AyDUV/soVo9JZCNMft3oj+hrRUMAeaOM5V6vXGGNc2Zg6aENdmzpUcxrOkaEcD3APpWtr4p/oF9kR41FGcN6lJacZ3Tb0JSMLLYmd1fhk1LQFNCjXMVKmyt8bVZ3GAx1mYPimtodEEQIyQ5zqGipkR8gfPHlaLnNUCeT2DdxJeh3owY0rEc8SOeNjRd+yLTO5ySE5gJyMi6AlQlJ7AU9iJA+xnzFfgN8ar8JE1+G/Ta5KEBOPmQwa7l3Ozan2LbA6I0GLFtPcbCF3Qg+qWUoDx6l7kJLTWpH9to2gJ9+kZ2cM91hGrjKuwMV/ELa9nXecSJhLtsaV131qiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x7YUYrmdrRgeguyBY9JGjIqs+8LZL7I2/XLMJjbfXG4=; b=B6eOk5VCy+gxSviRINAC/bOa7lUAAQz7/lLjXCseCitfCEgLlu38NipMqjcK+NI65XbQa5sUKV3LygoWBm/0S54MCFEdbqBIIuKV9ODYkcQXkHX+7NpVmY982ziI6KnrKYnlFJLh0blqtktvblwz7FnOb32g2d9jF35JzH3q931QzmZbe+dzpZGOQaInOcUPELx2PuK6KXmkixdn1ezzcc1XbNrw1EyFOm+jI++1pQGizHLGXj2DQcEvpP9QOMgQIVXX8LLq4ROjy4FlyiDacEEaqDOL7HWNgsX756zddfHzIIM1KE4sK84TGUkpN8We/BxolPjgWfhU4TEmPQjTHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x7YUYrmdrRgeguyBY9JGjIqs+8LZL7I2/XLMJjbfXG4=; b=CZC9lLaH7W8M/ky3smXVadk7VAhmEK5OSakxaBmI27N3J8IOXVn/Ki3Rvcuzur6oo1a7bMe+iEJcERIzOUnJ5PEqqX+N41wjnrOyM99FVXJUJ9NJWHFXEQG/ljOX3Fqi3VgGtrAkdT2Bof0PFXzrJA4cHNALsnceVNN5S1E0SEw= To: Jan Beulich CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , Xen-devel , Juergen Gross , "Paul Durrant" References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> <556ce32b-5087-b8b1-432e-643218dd8c6e@suse.com> <9ca069ab-8b6c-c8f1-d68b-4a9bb0cf5c56@citrix.com> <62b79d56-2438-23ab-49c0-a8c4b290c4f7@citrix.com> <9a248354-f68b-8cba-f18c-f4a26473f9bf@suse.com> <586f5bcc-9d96-dc37-2aa1-aed0bf11117c@citrix.com> <0779dcee-4aa1-019c-3e6d-5b6330e395ee@suse.com> From: Andrew Cooper Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API Message-ID: Date: Thu, 11 Mar 2021 16:18:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <0779dcee-4aa1-019c-3e6d-5b6330e395ee@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0070.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::21) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4187c471-da05-42fc-f3d4-08d8e4a94ffb X-MS-TrafficTypeDiagnostic: BN7PR03MB3828: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1MVTdaAJLCRR505ReOtWeU8yDdsEDWV3nmUT1A6/dfp9zd+bwJqLqiFDm2Z9BEIg9qKmnqzH8RvGSlVhebQ2Pd3qwPNrRh6VV90LQdyGcMr8D3CTgRXQxbIqROBLkQSKttkK5RXwvRIuPQ0ff7F8LodEakU7Hj46hxsw/9KED9KILEQmxVfoQIh/4kLIv5kqhAUV3FMJeJ5ZiycrIphRc6c9KvR3NgYsS7QNYf20kwO5HG9tgJc8O8gtQI4oWh0CQSXlJ+Xbh9w6JlhAAFpSbb8NgZwl9T0MOYQIlD274Ak3sukQKaa65HsREF7SUDpuHs2LGfZOp9hMVzdrC6bIE/KyzBAFKMd1NI2H6K5NliG9UhPuwVgG40e7aZWkcwiwy1XewnseqLvpHOcj7R0sPt/Zjkw1HPCx67z5qagHOWCqudzYfZkkMbHXR7VCFoJKMmYLkzwOlfe6gi8A6oo0JMVhW+Bzsff53HO0cEsOWXOggOq9pmWPr3wxIXFChXHGHOoSmN7XpWgeoEFPi9HypWo8ekMCwyJIe/VzSuOgUxax7MKxEjWaaULb/4IGWAZlbcwyXLobOcrzu/7p8Ejsap9LCZQwlMzLkk1FFnuKnL4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(346002)(136003)(396003)(366004)(478600001)(66476007)(6666004)(66946007)(66556008)(31686004)(86362001)(316002)(26005)(54906003)(8936002)(53546011)(8676002)(16576012)(4326008)(83380400001)(186003)(2906002)(16526019)(6916009)(31696002)(5660300002)(2616005)(956004)(36756003)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Q3hoV1VCamVmL2Y4cFlKZkYzT0RYTTEvaUNxMWx0YksxWm81bnlaaHZUakVo?= =?utf-8?B?QnhwdTRQbHY3bTA5Z1lwVnNtb0o2d0xxV2lKWTczamZ4NWQ1UXIvSGtGYXU3?= =?utf-8?B?WDNDUmNmYWZEQ3M0bUVoUGNFWUhBcTVVMmNTeXM3RkxRajNtZUxrWFFrMWtK?= =?utf-8?B?VzdjajhSaEk5R2wxSEdrWSt4TCtGZ0FQSVQrMmVXRjBzb0YzMjd0YlIvMUl1?= =?utf-8?B?U1NjRS9XOWZHUnpWZVZKbU1ISWw1cmRFNHZOcW4rQU1NbnExQkpHWUhhTVN1?= =?utf-8?B?NEEzR1NyQzhEV3MrK1JBamVWeG80UHJXRkF4VXN1Z2dVZy9hMlNXMVV1Qm5R?= =?utf-8?B?c2Urb0V6a2xOby9ab2RKRGd3Y0UvTCt3ckthOVBrNEVKWGFzRm9HQmJQaDhp?= =?utf-8?B?VzlUY3FpanRHcWplejJndXRnanBUZEYydlhSZllBTGdBY29MYm5VWFpaRlB4?= =?utf-8?B?VUw1UG9zeGJncFQ5bW5Mb0lwWDM5dzkxd3RyTFN6VmNHL0plU3h6cGI5NlJm?= =?utf-8?B?Y2VjUExzbm5MR0NyOVdRaW1PbUpEbFk5VUZDWk90cHQ2c2IvVm91NGdzdDcr?= =?utf-8?B?WDZWU1RiK2pJcEs5eGdIeVo2ZkZDYmh3Y09HWHBndFNUbGR5eGw3VkVhbXZP?= =?utf-8?B?WVFMbFdrUEY4MkhiWmV3ajBIajd1UnIrWGJwQVlNNWNuQzB1TXRJeTJvdUM4?= =?utf-8?B?MGdOWnVCbGYzTVhwYmkvWWd1ODlkdmVwRDJHUkRwMW9XNXkvcWY4RmoxeWRq?= =?utf-8?B?a3ExeHJGTG1kUzI2eU5KRVFwN1dhc0F4NFh0NVZPWkRISWFkTWRQdTN1Rk5J?= =?utf-8?B?VUtaa2VuTUhUVFM4cnhGcC9xMkU5eERNS2VtalJGRU5mMERyTko3K29zclA0?= =?utf-8?B?eXI5SStMT1E2Z21tTTk5UlpaeGdWaDFYejM0VGNnN2tkVFpRN2NxRDdMZ1R6?= =?utf-8?B?eHVaTW40SWt1and0eUZMYTBLOTVreVhhVTZjL25POGQvanpvOVB0cExiK2RZ?= =?utf-8?B?dEZBemFrUWRXa3FJSlI5dWdrY3lJZGQxWElHQnB2aHFmUUdFcmVhVXNkK25n?= =?utf-8?B?M0ZHSXB6U0cwREZSZitXbEpWQ0U5bGllSDdWZHRvMzBFTENMell0dE45MTdo?= =?utf-8?B?UnRWUURBNExwMDJRZWFGQXBycWxWazB3VWVOQnpVK0FTbXRLNi9UWXA4aDFq?= =?utf-8?B?TXpjY2x6YzNmSTRMMzg1LzlQQ2lzWGZJOTF3QWlDaFY0eCs0M3BQak93dUZQ?= =?utf-8?B?eEQvK2NUdnNFL3NGWUphdkl3RllTa3JlRFpqNkV1dTRoOVdhUmdWMHJ3SWRk?= =?utf-8?B?TjE5TDdDVXVVWGYyellPL3hrMkllWUFmNUVaYzhzOEF3dGRtRmdqN3owbGpy?= =?utf-8?B?QXlYV1AvblpQN29XVS83UWxGbEdPZXpYajdlc2lYM0hFelZ1ZHJPZFFERzcy?= =?utf-8?B?L2kzUUJCN1Y5N2VWOGd4TTgrZWhxZ09WbldsZTJQRmtocDJ6a0NLVjVVcTJr?= =?utf-8?B?SHJad3VnVnZkTDU2aXBOY2VEN2lGT0lSVUZRK0RwYlFvNVhkRHVDbExNQVY1?= =?utf-8?B?T3VrT0dIVjZFTUZTTFQxMklEandGZUROeTh4QnVkdUEyUkNSM2ZRT20yMGx2?= =?utf-8?B?akpRNDg3VkQxQkpQTVRSczBQT2cvT0oyaXpWK0g5aGpCVzdVQk5vMmxyVUVP?= =?utf-8?B?QzkvQ2R3MEhqWko4ZEZSQUtPR2NCTTlRN2RFRVdrOFI2Z2RySG5qYis1Vlhw?= =?utf-8?Q?lVA95WSKFHqEwhsX7e7JgmOQaXnbEY2SLftyYGO?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4187c471-da05-42fc-f3d4-08d8e4a94ffb X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 16:18:31.7392 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: usp43mGeKNEiZk5dvs7EXKHWBw20ELGx6ol4O2AU7il68uVEPx10hDH3oa5Bu4GMTG7S82R4LlSI1ZqpKXH2UCmZcMu6vTf53ALk0Bx94ug= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3828 X-OriginatorOrg: citrix.com On 11/03/2021 14:44, Jan Beulich wrote: > On 11.03.2021 14:43, Andrew Cooper wrote: >> On 11/03/2021 13:28, Jan Beulich wrote: >>> On 11.03.2021 14:00, Andrew Cooper wrote: >>>> However, having laid things out in this way today, it occurs to me tha= t >>>> we should consider further cleanup as well. >>>> >>>> I do agree that code wanting to use the libxendevicemodel.h API almost >>>> certainly don't want/need the dmop ABI.=C2=A0 (i.e. an individual cons= umer >>>> will want one, or the other, but almost certainly not both together). >>>> >>>> Should libxendevicemodel.h really be including dm_op.h? >>> I was indeed wondering. >>> >>>> =C2=A0 AFAICT, it is >>>> only the ioserverid_t typedef which is API shared between the two >>>> contexts, and we can trivially typedef that locally. >>> Hmm, a local typedef isn't nice - there should be one central point. >>> Granted there's no risk for this to change in anywhere halfway >>> foreseeable future, but still. Also neither C89 nor C99 allow a >>> typedef to be repeated - in those versions we'd then rely on an >>> extension. >> I wonder if we're depending on that extension elsewhere.=C2=A0 As far as= the >> stable libraries go, we are dependent on a Linux or BSD environment >> currently. > Right, but we'd like the headers to be consumable by any environment. > >> Alternatively we can drop the typedef and use uint16_t instead without >> breaking things in practice.=C2=A0 (As long as we make the change in 4.1= 5 and >> we lose the wiggle room afforded us by the entire interface being behind >> __XEN_TOOLS__ previously). >> >> Thoughts?=C2=A0 I can't think of any ifdefary which would help, and swap= ping >> to uint16_t would reduce the use of an improperly namespaced identifier. > I'm not outright against, but this might inspire people to use > uint16_t elsewhere too, when they should use the typedef. How > about a transient #define (suitably commented)? Having actually experimented, it is more complicated. /local/xen.git/tools/libs/devicemodel/../../../tools/include/xendevicemodel= .h:283:45: error: array type has incomplete element type =E2=80=98struct xen_dm_op_modified_memory_extent=E2=80=99 =C2=A0=C2=A0=C2=A0=C2=A0 struct xen_dm_op_modified_memory_extent extents[],= uint32_t nr); so the dm_op include is necessary to use the libxendevicemodel API. Also hvmmem_type_t and evtchn_port_t get used. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Mar 11 16:21:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 16:21:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96683.183187 (Exim 4.92) (envelope-from ) id 1lKO3s-0002bg-65; Thu, 11 Mar 2021 16:21:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96683.183187; Thu, 11 Mar 2021 16:21:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKO3s-0002bZ-2c; Thu, 11 Mar 2021 16:21:20 +0000 Received: by outflank-mailman (input) for mailman id 96683; Thu, 11 Mar 2021 16:21:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKO3r-0002bU-5B for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 16:21:19 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 63606b8c-7d9a-4392-b7c3-2af537a9168b; Thu, 11 Mar 2021 16:21:18 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6F944AB8C; Thu, 11 Mar 2021 16:21:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63606b8c-7d9a-4392-b7c3-2af537a9168b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615479677; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iGcM6UsZHx9gD1D04IJo/iPO7ukzmoCGzXge9mo+keg=; b=oraT0/gU9VuyORr1YZGRVZbF6u4TWS7BAErzE4hAf2KRMI3tqmqD8BLBlDfe3tZ0RBkvNc xN7/AtvX5IpsmF64pmPnBV2fR45mthXkSZGPAGHRLUUZ4/usOk61RhHyzO+ARZ/ZEbdhAh MogDm9WBBj4HhnMl4ADU7PCGYTrisC8= Message-ID: Subject: Re: [PATCH] xen: fix for_each_cpu when NR_CPUS=1 From: Dario Faggioli To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Roger Pau Monne Date: Thu, 11 Mar 2021 17:21:16 +0100 In-Reply-To: <9cc6f3ff-f078-1657-7c5a-9f356a857cdb@suse.com> References: <161545564302.24868.14477928469038686899.stgit@Wayrath> <9cc6f3ff-f078-1657-7c5a-9f356a857cdb@suse.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-PoEK/B/t/GaWRBgsbq74" User-Agent: Evolution 3.38.4 (by Flathub.org) MIME-Version: 1.0 --=-PoEK/B/t/GaWRBgsbq74 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2021-03-11 at 12:28 +0100, Jan Beulich wrote: > On 11.03.2021 10:40, Dario Faggioli wrote: > >=20 > > Removing the special casing of NR_CPUS =3D=3D 1 makes things work again= . > >=20 > > Signed-off-by: Dario Faggioli >=20 > Doesn't this want a Reported-by: Roger? >=20 It definitely does! And I even forgot to Cc him... Sorry Roger :-( Will you add it, or do you want me to resubmit with it? > Reviewed-by: Jan Beulich >=20 Thanks > And FTR I don't really mind the other NR_CPUS =3D=3D 1 piece of logic to > remain there. >=20 Ok. I agree with Juergen that they're totally useless, but at least they're not wrong. Oh, BTW, since you mentioned in your other email the fact that this comes from Linux, I've had a look there and there's a comment in their cpumask.h file, under the NR_CPUS=3D=3D1 define, looking like this: /* Uniprocessor. Assume all masks are "1". */ https://elixir.bootlin.com/linux/latest/source/include/linux/cpumask.h#L149 Of course, that does not make the fact that for_each_cpu and for_each_cpu_not are identical less weird, and the whole thing still does not make sense, at least not to me. I'm wondering whether or not it is worth to report this to them too, as I have the impression that they just don't care. Thanks and Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-PoEK/B/t/GaWRBgsbq74 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmBKQ3wACgkQFkJ4iaW4 c+7xAxAA7k5/dm0/2Wg4ERmbZgaItQubvksdh/iOBepDeI5V19KTaba2hsctUCwF sUIu4cMhcvFIRHO+1KNuJMVcDiSMOE6GfTDGUqZOgwiBfbXpx8/csHay1JfLV5C+ qGO4xQMGOhrJ191mVAbwgo/rEnwSU2f0+kuQTo9qDhXxMmSVYcvcsGmbGaROZHK/ bEdgc3ET7sMD4qg2GOY7kUNxoBxzbOr4ExfeDyXf7b/MF1aHaW6khzGtzmNBG85F mw/VfBJ6vPct+/oKo8LFBDnCEIq5D1E5juHwFDcoZqncu4Jt/6r5To24t8qxtPnS JRRBwq4z//uvU/ZuyzG1mE5zUpL776WsevulSL2KpPDGyOT2NC+77nvwN1Pgr5hn VDv2qhlzt62bSMyOLHuAlPW+vubTxzbJoKS8mzTk415aLpQbLqETEwpdSHlIiEn2 h23JkPnDy7O2PFaz/WixKEdF+yDhUksazgmj/EmRSYi432ju0+vREwJ5rjxNtez8 X4IZPPR4jaxDbUtUt8uCoS6xE+fmPg23twBnTt5jYorio55jbsO9x268Fm7wWkY7 ZXcgLfvdqLVaZSAETgEIBGfvvml0ytozkqWInnhtSQQgU1ofYl5s2HZEAT8cGv3Q 552HbuNPjXQZNKj6LdqEqUQNN5iecQ3yWGsUnWvqfwEgi4ITCl8= =x2Lx -----END PGP SIGNATURE----- --=-PoEK/B/t/GaWRBgsbq74-- From xen-devel-bounces@lists.xenproject.org Thu Mar 11 16:22:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 16:22:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96686.183199 (Exim 4.92) (envelope-from ) id 1lKO4W-0002j2-Eq; Thu, 11 Mar 2021 16:22:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96686.183199; Thu, 11 Mar 2021 16:22:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKO4W-0002iv-Bl; Thu, 11 Mar 2021 16:22:00 +0000 Received: by outflank-mailman (input) for mailman id 96686; Thu, 11 Mar 2021 16:21:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKO4V-0002in-Fq for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 16:21:59 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3b116271-6d95-4853-ac47-b09784e448d1; Thu, 11 Mar 2021 16:21:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b116271-6d95-4853-ac47-b09784e448d1 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615479718; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=EV7AjTLC0TFcuDw+q+bKCKhZ4CC8dWU76xVWFd5a6SE=; b=ZxuMJBqPzdD+50dz0UR4X8w1CnRQOuuzxyiVA9gAKX9L/Q1/zFp0Xp/a Vy/wVNeWyMEaU8tgSwnICbdSesD8vA8PuzjItam+BVWkCSMgzStyhhW6y C9pZikDMHChR89CKP+CXY5IyknU7BCq1luMkdxhe2z60W7B7tgL7iiMnV M=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 1bC2Bhdl5EJt07OcrDko0UUv9iRN3v+bE7ZCDa2n2g8QdB81Wj7nP65UMkMN0RpA91f9Oxuoqo G98XOsCyGTSUoLahRAMy03et+rQAcAfP0w76BwwJHOr5pcJ56cgMszPEj6hnx6xYBiU3WcQCTC FhficPxyU/nnv6H80SRs6Iop3Ru7HUkHdI3oMFkcI1Gpqwe3hUmWMcxj69UWG9FzK5zKFPWTU0 YY5yE9ipFpdZv/5L77uqSsRVg15gVO+Xr6+Zt2LqPhgqsgt42LhrlfhLD7cU0YnWUC2Dc/qhyg mkA= X-SBRS: 5.2 X-MesageID: 40490546 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:QmphW6g2VCAp78tispaUPvnYwXBQXwh13DAbvn1ZSRFFG/Gwv9 yynfgdyB//gCsQXnZlotybJKycWxrnmKJdy4N5B9efdSPhv3alK5wn0Jv6z1TbaknD38N+9Y MlSahxD9XsEUN35PyR3CCUG8stqePpzImGnuHbpk0CcShPS4VNqzh0ERyaFEoefngiObMcGI CH7sRK4xqMEE5nDfiTPXUOU+jdq9CjrvuPDSIuPBI79BKIyQqh9b+SKXOl9y0DWDBCy6pKyx mmryXF4MyY0s2T+1vn+EL4q79Xn9bgzdUrPr3wtuElbg/CpyztSIBoW7iptC04rue1+D8R4a XxiiZlBetfwTf8eXy0vAvM1mDboUkTwk6n83C0qz/CptH0Xz0zAcYpv/MmTjLpr3AOkfs59Y Aj5RP/i7NnSSnusQ642v3zEzZtrUawqWpKq59ps1VvFbEwRZUUkZYS5ypuYfE9NRO/0q8LOs 90AvrR4f5HGGnqFUzxjy1UzNugUm9bJGb+fmEy/sic0z1hlHtk1UcvxMsGgnca9J4mIqM0n9 j5Dg== X-IronPort-AV: E=Sophos;i="5.81,241,1610427600"; d="scan'208";a="40490546" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c7lzQv9MNF7O2GOrB5JjMbetIH9Gp/exudPvqUcebn2tBKfaRk4f6jdsr3wprYTs2nlOc4LdH96+Aav71OfeYOtOTT7iCdaBaWfIFwNPbzl2PeJGALCG2alzMWL4zzOC71q8iSZxRdba7QauW4Nub501DjI2uyVEfdHjr8l8cRBMqSzhOrBzj/6cPtUl02zU+nDDSq3oWDTAz5MC93zXFEKNAfqjZIWmbVn2uLWuI31GYCPN1yIwimVTNSAM8bszSQ2A0OzKY8kKZvdLt5833uSSyHFe+iKM3tqjFldXHSh6cdecCT63th1cMUIhQPRAsktpL/T9q6PaGXhrj0dXqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DsbX3b0NSX/ShaOyXjQ6Rh6gdTVgcTVOKz9f1MHxwCo=; b=XUUPcZc6FHYnsQf88OkQRFIFoIE0/0/uex2MG79H+W2UnUeYFBg0C2PTW0RS4EdncThSj0qVHf8VoOrDzBlrN8Pj0VlZid3ed0mWCnlCaQ8FNVa4g0fvUljEUsR11m+G2WNXtuiudEakZfClEmT7S2yfYrgCVMl3kM9w91oELDn+aW+/eGm8daGPfscWN2SJ9oPheJbuIPp8bgLb8BwB72iEZB4Sntq+q6wRPgoHgFFztVmKuf1Ez7GOHFsyhK/CdlEp2zWsIrhgmR+K2WdLrGTwrFfyXN/yxh28UnGxydzypddlQq7E03ByrnrA7Cg9RSJhBalgYw6zRQJDls3wQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DsbX3b0NSX/ShaOyXjQ6Rh6gdTVgcTVOKz9f1MHxwCo=; b=b5zXCbLt5ktOoaK2Vo3DPdrgJt+wfN35zbHJIE5/aXEPmWs5v6keTfYQShZcp/7eQn/4Zgg8IGerFpVCFeMlQzVQMJJKekiV8BnOQIawpIKA6a/J2d4aTNI2fsZKtZsi6BOiIQ++o2oeVU3PXvYa5tXw39avXbLqRh0YpeOauUU= Date: Thu, 11 Mar 2021 17:21:38 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Ian Jackson , Andrew Cooper , Wei Liu Subject: Re: [PATCH v2 1/2][4.15] tools/x86: don't rebuild cpuid-autogen.h every time Message-ID: References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> <1b8aee19-9194-153c-8dbb-0aec3412e255@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: PR2PR09CA0021.eurprd09.prod.outlook.com (2603:10a6:101:16::33) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 12a5f52a-85e8-4a59-295d-08d8e4a9c2fa X-MS-TrafficTypeDiagnostic: DM5PR03MB2969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9r0MmWlFDGmuh3pwD0OxcjvdXy2IUZaRgLpym7fejiOBgFDOtG1FFSFQd0p4f6xrNV0JCcIGZagFPAM3B1C1Dy+mQsz7OVOxSm+qmvKQUI2AeHNOmSuXhiA5uqy5+9IhKSX6pW3g9ukQ5VYc4XLfBygo4LFdUod+r6XN8WI0iP54kDe8GKTntOBdfBPHP62B7QllRJ1X8/odJsaClQkqMDtjSjCr82AP6rnltfdt/EQi3DPDVZ3aaiammmPHhbGyMl6CJJkdBRHsOFYuUJdgELMUAdbwr0TT8ik3OWqXGdAbbWsK+eyX1Z/5apxkgHiPtrpUex7nfsrJs1yo7/AP0fwha9Ff3UoNtV9aBFiDtxc8vXUdkV2vfNigPfPhNVaOaKN4u/l65UYIkTGpJZRz3RVe9VgPXFVIcBDbhFRkQ2Oj1jBOXpTFBK0Grpoq80Am26K0RMj08tz+xA4hRFKntY9XclWYnhkIRpf4byhDHAfdGSDhP6sh3FE6fnkqOpMIec1GxB2g51hu/Hir22NSzRvT0z4V5cjagg5cj0QYS/XcGv1lcEho909MQ+c0We5h4aPxlt5hgPfBtwnnnI4W5SB4Okrurpd3asrhFcy2q+M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(83380400001)(2906002)(85182001)(6916009)(8936002)(8676002)(6486002)(4326008)(6666004)(478600001)(33716001)(5660300002)(966005)(186003)(16526019)(26005)(86362001)(66946007)(956004)(66476007)(66556008)(9686003)(316002)(54906003)(6496006)(53546011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZkZ4UGdoeHRlSGQ5Sk9nNTRJNmUvNTAwVHpjTWdwWElacVZ0NlE4UEhwTGNW?= =?utf-8?B?UzU4VmhaaDlLNDlSZmRpMGwrUzJrRTNMYUwrOVBvYTQ4Wk5rODNBTzQ4M0FS?= =?utf-8?B?RWNVS2NZZHBVYmMvYSsremJmVWpDYzl4OHZOb3F4cTR0OUtpSFNndzljcEZ1?= =?utf-8?B?c08rUWxIZVQwLzE4dUl6RG9Hd2tYaVUzSzRaMWxCam1jZlBXNnJuelFROHJj?= =?utf-8?B?WnBkUXVxd1p5ZWtHYXpMYnhnSThEN1NBMlRTVExSYXVUU3JxMWFRWnBMTEFT?= =?utf-8?B?OUpBUmM2cGYyTWVXd0lCSHJQOThXdXVqOHpjOUJPblp1SktuYTFIRXJVVmFR?= =?utf-8?B?b0JrR1RwZEpFcnhBblNrZlozbkhKeTJpQ0lPYmYzUXV2VVRPdjNxV3QzU0pj?= =?utf-8?B?OEFaZTJQckRaOGRyZStub0plZGNEMDM1RytKZVo4Q3BxL3FzZkMvalczRmFu?= =?utf-8?B?aGRkV0crSnhuWWNVK2RKSEFIOHVkZ0lBU2xNY1pORlFnSVlTbzN3WGpRcmRF?= =?utf-8?B?bXhPOU9IOWM1WVhXRTFDekkxYjk5aTBtZTJPQTE5cUNIT1kvSHQ1S3RGS3J5?= =?utf-8?B?MEQ0SnJaL3p3dFl6NWRWNDNMY2pPWUYvOFYxRlQzOGkydEJVc2tONE56YjVO?= =?utf-8?B?eitSZlArNloya0w0RE9YTEw1YjlaUHJKSXRSbmJ0cmJKVVFWYTk5dzRnTmFF?= =?utf-8?B?UDl0RktiMGpWdnF0NGFrQ1djeXZ2ZHhJTWpjRXFpRG05TVZRNWdVVTRUbmY3?= =?utf-8?B?eUJIdnJFNzlsbTBmSVltNFREczVJbWkwNUpDUUh6eFhqZUx0WWJlaDlMWVFh?= =?utf-8?B?SVpnSStyM3BBSmN4eDQrYWxuMm1WbUE4eFZJRHo3WVdob3FsTlQzcjdUY3JV?= =?utf-8?B?dlV2TUZBSkduKzF5ZFpaMUs5MW9Jb2dXQkVtV3c4UEh2Rk9Oek43QzdWOGND?= =?utf-8?B?YTZ6Vm5WNkxWL1NVRG1WamM2SFFodzFsVi9ZekhUNXIvdTQ1WFlGZFFFcHdu?= =?utf-8?B?T01rSkdWV2tCRWh3N0NpZnBCNnRpckc1c2s3dlBWMEg4VjNXMGdZc3hxOEk0?= =?utf-8?B?bEpZazZ2SkpnR21jMytWeUhHQWZHM1dRK3ozM29aRDFpalcrY3E4alNVZkZN?= =?utf-8?B?LzZ0Wko0amhPeHlTY1A1RGZPYzY2L0tIcThpa3JsU28xYjF1UGxHcUZtSUUw?= =?utf-8?B?WmVLZ0c0RXIrazF6NWtZb0VoVFUzV3BTVkN3aGVpN2g5SDB1VTFaS3R3Sk1X?= =?utf-8?B?RnBWaGVCUnUyRDZUSWU3SlZnVEgzanpUWE1IVlZQVmZuQXhSV2o3WDI4V3ow?= =?utf-8?B?bGRnbFUrMTZxV29vbFF1RUEzVDVVYUdsYnpXUmJZalJkMkYrUjhMYzhHN1dE?= =?utf-8?B?Z1J2U0IwdGtpdUkzNWNaNUkwamdYaE5VS2VuTkpSMHFkNHlobVdtZ2xiT0Jr?= =?utf-8?B?MFk2aVF6VFBCOGZXSDgzSjNwYmF0RnhXRi9Id1QrRSszOUdaWGF6S3BNc0Va?= =?utf-8?B?WXpmNHY1cUlmUjR0T1FDTng0WHhlN3RDMUVpWkorTGVScGJTRVJPd1RWMFJW?= =?utf-8?B?R0ExM3Z3ZytCd1U0TjhkOWZ1VmdxVVcxTmpTcjlleGdMU0VsZTFIR1o2T2RY?= =?utf-8?B?Z3A2MVM4SllBRUFGTjdQUUc2RjlWK1AwNDFGZXp0elFsWEc3dERrem5yV3ZQ?= =?utf-8?B?T1NJa2FlTHdUNU1ZYTJ0c0pwMGFxL0RJSU1KSVpCTVZiODZrVXhJYzViSUNX?= =?utf-8?Q?F/n6r+wQ9BYqzzdw3wzRAae9IhWb0xvm6g5x/n1?= X-MS-Exchange-CrossTenant-Network-Message-Id: 12a5f52a-85e8-4a59-295d-08d8e4a9c2fa X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 16:21:44.6477 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZTmRdF5yke0TwMNFALfh2Ji/MomRuWmJWNKnb9siFwzI3MXp7Sjs/R7tYYLou70fL9MQGn9zgq3So2WoXpPCnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2969 X-OriginatorOrg: citrix.com On Thu, Mar 11, 2021 at 05:00:12PM +0100, Jan Beulich wrote: > On 11.03.2021 16:29, Roger Pau Monné wrote: > > On Thu, Mar 11, 2021 at 03:40:05PM +0100, Jan Beulich wrote: > >> The first thing the "xen-dir" rule does is delete the entire xen/ > >> subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a > >> result there's no original version for $(move-if-changed ...) to compare > >> against, and hence the file and all its consumers would get rebuilt > >> every time. Instead only find and delete all the symlinks. > >> > >> Fixes: eddf9559c977 ("libx86: generate cpuid-autogen.h in the libx86 include dir") > >> Signed-off-by: Jan Beulich > >> --- > >> v2: Different approach. > >> --- > >> Ian did suggest to pass -0r to xargs (and -print0 to find), but I > >> couldn't convince myself that these are standard compliant options. We > >> don't use any special characters in file names, so -print0 / -0 > >> shouldn't be necessary at all. The stray rm invocation when there is no > >> output from find can be taken care of by passing -f to it. > > > > Why not use `-exec rm -f {} +` instead? That seems to be part of > > POSIX and is likely nicer than piping to xargs? > > Hmm, I avoided it because I was under the impression that there > are (compatibility) issues with it, and Ian suggesting xargs > seemed to support that. I'd be more than happy to avoid xargs, > of which I've never been a friend. All I can tell is that '-exec ... {} +' is part of POSIX [0], and I can confirm it works on FreeBSD. I have a slight preference for -exec instead of xargs because I think it's cleaner, but I think your current one is correct, so: Reviewed-by: Roger Pau Monné For either one. > >> --- a/tools/include/Makefile > >> +++ b/tools/include/Makefile > >> @@ -19,7 +19,7 @@ xen-foreign: > >> $(MAKE) -C xen-foreign > >> > >> xen-dir: > >> - @rm -rf xen acpi > >> + find xen/ acpi/ -type l 2>/dev/null | xargs rm -f -- > > > > Do we care about leaving an empty xen/libelf directory behind? > > Why would we? It'll get created immediately afterwards if it's > not there, and it'll initially be empty (not for long of course). Right, also the 'clean' target will still rm the whole directory. Thanks, Roger. [0] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/find.html From xen-devel-bounces@lists.xenproject.org Thu Mar 11 16:24:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 16:24:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96688.183211 (Exim 4.92) (envelope-from ) id 1lKO72-0002sK-TS; Thu, 11 Mar 2021 16:24:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96688.183211; Thu, 11 Mar 2021 16:24:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKO72-0002sD-QI; Thu, 11 Mar 2021 16:24:36 +0000 Received: by outflank-mailman (input) for mailman id 96688; Thu, 11 Mar 2021 16:24:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKO71-0002s8-9p for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 16:24:35 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id def35981-5154-4791-876f-2934a2000b9d; Thu, 11 Mar 2021 16:24:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: def35981-5154-4791-876f-2934a2000b9d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615479874; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=mQ7ev8qs7TpjwyDBLnfCjdfEo3ugAzrS4IdLwHUtvBQ=; b=YweT7+/FEzz7ClpV/9iziZyS/VFHg2zyGtojx/4luez786vDCHGiUknG xfC9K6N0147VNO9Zrxg+YRe7MhOh4mu/SK+Baju5BGBrMkd3fp3Z6btBl gsOktBHEhFudMk0JpJdh2uB55EaY0yIBapd3PeZq4DXEvKXVMmzZ8tYP9 s=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: CA5zbA6Nsun6Gtsv9Z86vUbDihZNYmYcjOgb+WKbgD5kX6lrRnuFuiefBZixULOjy5esjfvlh/ 3JYP3AgP0Pp+mNfFqejM6zH9rwRCCFzDt3uREGtWVIQhu0Bv5+Z8R7XtGJm/XFJT+iKEMowm35 HpYz3djOtekEkUe1jBCzsoMiibTGpOQV7SubRXgEevfJsnx1fEZ8+fwRNeEtxIv8o1wzx5BMd+ ROfmspkl1hJrnX7esNO88DWvzlBN/ON05MLWSQvSXP/izb6yhey03jvd8uQs0YgAZSPidaXi6b m0c= X-SBRS: 5.2 X-MesageID: 38983695 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:vJEpCa7tmP42vEooyQPXwWWEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoexzh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdxHW3tV2kZ 1te60WMrDNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2BXQotLhj0JbjqzOEtwWQVAGN4dHJ 2T+sJIq1ObCAsqR+68AWQIWPWGmsbCk4jobQVDKxks7gSPij3A0s+HLzGz2BACXzRThYoz6G StqX2F2oyPkdGejiXd2Wja8ohMlLLapOdrKcSQhqEuW03RoymyYoAJYczlgBkUp6WV5E8ugJ 3wpX4bTr5OwlfwWk3wnhf3wQnn118Vmgzf4HuVm2Hqr8C8ZB9SMbs5uatjfhHU61UtsbhHuc ohtQLp1OsjMTr6kCvw/NTOXR1x/3DExkYKquIPk2dZFbIXdb45l/1uwGpuDJwCECjmgbpXct VGMce03ocyTXqndXzD+kFgzNuwN05DZSuucwwpv8yY1CVuh3Zpz0cU79x3pAZwyLsND7ZD/O jKKaJuifVnSdIXd7t0AKM7TdKwEXGle2OCDEuiZXDcUI0XMXPErJD6pJ0z+eGRYZQNiL8/go 7IXl90vXM7EnieR/Gm7dluyFTgUW+9VTPixoV1/J5ioIDxQ7LtLGmqVE0uu9HImYRdPuTrH9 KIfL5GCf7qKmXjXaxT2RflZpVUIX4CFOUIp9cAXU6UqM6jEPyrisXrNNLoYJb9GzctXW3yRl EZWiLoGclG5ke3HlDihhz8XG7sZ1zf8Zp8HLOyxZlX9KE9cql39iQFg1Ww4c+GbRdYtLYtQU d4KLT71oO3zFPGuVrg3iFMAF5wH0xV6LLvXzdhvgkRKX75dr4FppG6cWBW132XGw9nQ6rtYU lijmUy3ZjyA42bxCgkBd7iGHmdlWEvqHWDSIpZvaGf+8H/eNcdAow9UKJ8USXHfiYF2DpCmS NmUkspV0XfHjThheGOl5oPHtzScNF6nUOMOs5bqXXWsG2GvsExTn4nXzqjOPTnwzoGdn5xvB lc4qUfiL2PlXKEMm0kmtk1N1VKdSCqGr5cNR+EY49Vg7jvXwl1QQ6x9HqnoiB2XlCv21QZh2 TnIyHRXf3QGFJStkpV1bvQ/Epuen+QeF9xbX5GoZRwfF62yEpb4KuuXO6ewmGRYlwNzqUmPD bJbSA7Dyluy9q0vSTl0gqqJDED/NEDL+bdBLMsf/XvwXurMpSPjrxDNeRT5oxZONfntfIrXe qTdxSOFi7xD/ok1mWu1y8YERgxjENhveLj2RXj4mT94WU2BuDKJk96A54cONOR4gHfNr+1+a Q8qehwm+S+Mm/8MIHbjY7WaiNOMRPVryqdSfoypZVdoKI1s/9SEvDgIEz1/UAC+C97CsH+0H 46auBcxpvqP4d0Zcwcey5D5DMS5Z+yBXpuljazO/M0eFEmsmTSMNyI6YfZsLZHODz0mCLAfX 2ktxBH9/jLXyG/xacXJqI5L2NRclU94h1ZjZW/XryVLAWhbOdY+lWmdle7bb9GUaCAcI9g4y pS0pWtn+WNcTD/1x2VlTxnIrhW+2LiZc+pGgqDFapp9NO9UG78zpeC0YqWjD3tTyG8ZFldrY pZdVYIZsAGswIctuQMo2CPY52yhFkknVtY6SxmkVCo+rHO2hakIWh2dSvDgptXWjFPNGOvls qty5nB6EjA X-IronPort-AV: E=Sophos;i="5.81,241,1610427600"; d="scan'208";a="38983695" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JX6zmyWLZRFYY2Z98NScYCj0+59Q2nKJOmvw3BgBZj5KrareheY9NrfXkhqWg3WppGR1VE5YxYFTPKPphektJFlIh6NhiNzfnzpg9AnlX6OPZM0LHbXvYOl2v+bZnuvm47OkM6KAZmrPs1ctHIx4p+sovgIqdEBhx61uA1ewU/vZW6qkQJlg2uI/m6u4T1E9GFcsjACGwhuuTM/8kSINCdEXzT1HcuPKaFHuknPPSq5EQguPx3Lc0yT8ebf5cILFlUxmu9WJoz8M7/TQ+0jEpxLl9L2Qpg/RhtTt85w2VrsaXx9g/enGLoXFpo3zvyzQasOitWUYCOrIbgOIz0cpAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mQ7ev8qs7TpjwyDBLnfCjdfEo3ugAzrS4IdLwHUtvBQ=; b=Oh4pN0Nke0WlDOE1uwgEx7db7ze+j/LnXxsx0OVnBNYtXHVKUC4N79V8ZPDocfzAVV7o5wpKzd/cdxaGLd++krc42kVjKPzhYQiK5Kx/mdyAOps4oDZWpD1yWmkR3EfAeJmLEvNUXMBErb3mmJK2jWG7AmJ/9CT+EbeqbPQusiOTiupa178kL8lUsKK7KF49VTHRxjuKDyzWLXdI3SZeJxi/QRFQTeHwlRRTbFrXNQtG3Kc8Skk9oz40SqdefJJiizmrK49guVO6BIjm7xOmuje+yuxyB21PTskzyBW9ywNS/PCri4+WTR+EYdsDi9gEkjGuPSwwnh+YEHjjlEPJ9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mQ7ev8qs7TpjwyDBLnfCjdfEo3ugAzrS4IdLwHUtvBQ=; b=miDYx5yaLnLSz/I53uZ3IVp+ETqLhUI1gjz772GXHkggAkL3AQpkJWx5Oxhbd/s9DgS0R7te4K6xpHOyFLdtwpSCWyZgp+8/ryvSi7vzHI9ALazTnpFnPORsfCHgpwOEklple8MI7gKLMBfFwaVcOrRaZ1LD50q2p5gP9TLZRxg= Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Jan Beulich , Paul Durrant , Wei Liu , Ian Jackson , Xen-devel , Juergen Gross References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> <556ce32b-5087-b8b1-432e-643218dd8c6e@suse.com> <9ca069ab-8b6c-c8f1-d68b-4a9bb0cf5c56@citrix.com> From: Andrew Cooper Message-ID: Date: Thu, 11 Mar 2021 16:23:44 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0349.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::12) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4b45f363-e456-4375-cb63-08d8e4aa0d1f X-MS-TrafficTypeDiagnostic: BN3PR03MB2130: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IpenrQWHL7gqiqyyHj4FVIeWYpTOlaBTHOB44sl8i3P34Yp4nM4t0dv5dYBwbOUd550hxhVd/WHo7sicsDkVjsPSj4jjRRgU6DkkRKnvjMizRCAU4wjGg7i04Bvh57ExOgKIuFyc0R62aUYL7nqplKIG0Ti4lxeXgWJjJBAAda/cThXtz5XAMO/Bw5DMHev2XDcTWeh+gOjEEOeTg7WDmP0jLeosP9L/CrrascwiTlbGW7yeWcjkRffK4l67zb6ECo3Un6Ztx33UeCE2y0GMaTPyEcI4PQ+NAtCid3uEqb2mz+lMIf0fIqsivrOzZsUOx3aAHaAcD3YNgeODoq07gN8oBlI3+D29hW7OBhNtk/sNv7KI+FE+NSIkG+avs6Z/Ou4GczUyvHmNfm+ebVO+W03xZa+8cpdyK6vjzm9icJmTVWJo2HZJcl9sJBmDQaZnHRCEprjGHoM3ePIVe9VKlcp2djnD4lCsSP/At7pYncyu3gA7Ns3kuFwv7SlB0LE067DpQ+R5CsU5Qxz+I/Ycw7isRKGnPuAjX8DQc5NvDI/j21KaiLG1hGjddsp9imzLf6gZil8G7Db7d+nYCZhb63eGzoTDuMsmdLPB5ZyokHQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(346002)(396003)(136003)(376002)(16526019)(8936002)(16576012)(6486002)(6862004)(8676002)(31696002)(31686004)(37006003)(6636002)(36756003)(5660300002)(316002)(83380400001)(2906002)(54906003)(66556008)(86362001)(66946007)(26005)(53546011)(478600001)(956004)(4326008)(2616005)(6666004)(186003)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MWtwTzFGTzI3QXdSNlZYMXBScFFaaXR5T1UxZzZkc2ZZWXJiYVBXRE1iRHJj?= =?utf-8?B?L3FIUERobEY5VWlUVlFLa01xOUIyVGJ2Q1I3RVcrczNrZ0dEVWFDRE5oY1lu?= =?utf-8?B?N0VkUHh1MFB6ajcyUHorSG5zMXc2aUFnT1NlOFBzUWNvREk3cTgrWldxMDdZ?= =?utf-8?B?K1RUZm1lZkFXdm9DYm1sVnR0SW4wT0xvNGRSQVNxWWpuakJTbGtXUGpHTUNT?= =?utf-8?B?T1JmK0RSWEp2L0RkTSs1THltVGdLYyszVURleWthOFIwQjdYZStDWWJOY3RF?= =?utf-8?B?dkNsaFIzU1hwcHpFYkt6NkRWK3dMMCt0N1R0ZER5NmhwTFZRMnBSMzRzQ3Rw?= =?utf-8?B?NkFCUDRZa2I5VTBiR3JXY3oyY1NLcHRTMnVWaExWK3FPc2ZLb3FwejlDNFh1?= =?utf-8?B?NU5DLzhoZ3R1TnMzK2FzOVBUajdnUU84QllrK0YrOUFTancrKy85VnVHUkZE?= =?utf-8?B?cUthWHRyY3lWajB2aWRnWW80cVBPS1RZbERRR2lyTlBtc2ZQRnRjenpxU2xj?= =?utf-8?B?Zml4Ky80cHV5dlRyZFRoUWNTR0NGZUd5UGdKcGFvdWRRWTYvLzRLcE44RFVq?= =?utf-8?B?SVg4cnJIckJGU1Z6Yll2SzVRMzNzQ1RQS0hENHZEbzdlK0RhbHRPaGxGMktt?= =?utf-8?B?SE1OcjYxN1RMTCt4dWlDM2c4S0JXTHFkN2dwbk5aYmJmdVRlTm9JakpmZzlt?= =?utf-8?B?ZWxaL3REUHBEVEJ3ajZjbzZRRlQvanZVUno1eC9KMk45TEovRlNZSmVoT1Z1?= =?utf-8?B?VzRxN3F6U0JEU2loSlRJZ0ZxdDluNnNZbWdreWJUblY3M1FweDArRkVqZEM2?= =?utf-8?B?WnNUOE9lQi83RllIVS9oWXZaMlFDaG9wL3VYUytrL0tMN1hlc0lYZU9YcFJR?= =?utf-8?B?dzVLRGltVmMrd1JjekpuMUJPZmpEMXozU2tlL3RkU0NxUGRjQ0ppU0xIYXMy?= =?utf-8?B?NUE4VjJTbVRjVnIxRzRnTkJxZDJ4NmtrT1drYmlGWGJ4K1NyZGNQT0U4d2dx?= =?utf-8?B?TjY4NFBVQStCU3ZxRXFyaW42eFFFdHdMVmFsVUwvZmFtY1pla2I0dU5vQnAw?= =?utf-8?B?a3pYejFBd3k0dFU1eW9LYzIvOHRNck83YlFQT3NSY2hmREtvbVFvS0JmZzRl?= =?utf-8?B?VzAvNkFEb2pudEk2aGdmcDlZd01qZ2pUWFcrYzYwdkJaaUVsQ0xmSjdDckNI?= =?utf-8?B?ZU55WDdTL09GWGFIcTFvRzVVeEthR0IxTHZWT3ozbzlNV0ZWV0NUMk5kN1h6?= =?utf-8?B?d0k0Q3hkSndhcTNzbm5tK0l1RjdpSnBPak5YZDJ6anlWelpnSmR1V1grY2lG?= =?utf-8?B?b29uZ2hZdlZJYzBLMHVjM1R5cW5oZUMxWkY3YWhoUUxhSFF0U2dhcHBJUzB1?= =?utf-8?B?VDZyeElJdFJWd3ZQREhIYXJwQlpBSG5nMzhMeVNyeTRVY25wdHRIUnM0MmdI?= =?utf-8?B?M0ExOEovcjhwWmg1aGRNSVNqUjNNYnlEakxiWW9RNUFCUWJPOEpoRXFlT2E4?= =?utf-8?B?NXpNZlBSU2gzZEtqSkxraGZNbHRXMUlYcTJkdHp6VTJTU0p3L25odFFYcFZt?= =?utf-8?B?cWJ3dHJVK21zSUMvQStsUnZQVXdXWW1qVGtuYStLWExNWS9RTkZUUi9tRy9m?= =?utf-8?B?MDlwenViL1dYb2g0RGNDTC9pTnVCN0FrSjVhdUoyaFBZU21XTkd2Q1k0QTdm?= =?utf-8?B?VGFXNjBwNjZYTHpDaWVmeXpmUTVXSnd5T0hXWTdOQ3B5aVFJS2tjS1VKUjFD?= =?utf-8?Q?WhuWYS3hohWvUPtwGP9mjVnaL2jzyRsVrL7G09M?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4b45f363-e456-4375-cb63-08d8e4aa0d1f X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 16:23:49.0904 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /KLWN5FxdZjGg1BLS13zz25z1XByya5Zzi6ckUWRNhi7sz5qdYvzUb+upPBIUqRjtWYsxEDrqb5DdHD5z8H2tN6sfwpCBwvRzrwW7xfZiOw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2130 X-OriginatorOrg: citrix.com On 11/03/2021 14:18, Roger Pau Monné wrote: > On Thu, Mar 11, 2021 at 11:05:32AM +0000, Andrew Cooper wrote: >> On 11/03/2021 08:27, Jan Beulich wrote: >>> Depends on what __XEN_TOOLS__ really means - to guard things accessible >>> to any part of the tool stack, or to guard unstable interfaces only. >> As far as I'm concerned, __XEN_TOOLS__ should always have been spelled >> __XEN_UNSTABLE_ABI__. >> >> For better or worse, the fact that we currently do have unstable >> interfaces, which aren't in an obvious namespace such as >> xen/public/unstable/, means that there is some value in some form of >> protection to prevent users from inadvertently using an interface which >> will explode on them with a mismatched hypervisor. > I think using __XEN_UNSTABLE_ABI__ would be way clearer than > __XEN_TOOLS__, or even placing those in a separate directory as you > mention. I plan to submit a rename for 4.16. I don't expect I'll have much luck arguing for a release ack at this point, and isn't totally risk-free. Re-laying-out the headers is far more invasive, and was also a trick I was planning to pull when we've got a rough plan for the other ABI improvements agreed. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Mar 11 16:30:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 16:30:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96692.183223 (Exim 4.92) (envelope-from ) id 1lKOCQ-0003vz-Lh; Thu, 11 Mar 2021 16:30:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96692.183223; Thu, 11 Mar 2021 16:30:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKOCQ-0003vs-Ia; Thu, 11 Mar 2021 16:30:10 +0000 Received: by outflank-mailman (input) for mailman id 96692; Thu, 11 Mar 2021 16:30:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKOCO-0003vn-8F for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 16:30:08 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 77b171b3-7793-472f-9fc7-de0bb15978ca; Thu, 11 Mar 2021 16:30:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77b171b3-7793-472f-9fc7-de0bb15978ca DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615480205; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=tBcIU/uUffBCBTbsnTyDv6UE1JAX76nM2wvPks34Y3o=; b=a+hHEJcZUHGYCNz+kAomziEZGn8FpaBQ4LtntWXQur5weG8amlb83oTx tUcd2NR2OZOCW1oQ8/nSFgbBcglJIWAZjSrvuht340HAFhBjT6SZTgUNU 96KomuuVWdYVXhf52kRcFCBhM9zYyj2LR+ORtKCqnBKde1Cjx+i3ue9qH o=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: z+N+NGt3BpVnJFWIh1F0EkkhW4vw3sxGEZmGPtRMZpQk4UmFP/eaHI7y4GJh3A4pEQdrrHmKpa qe8zZxqMFN5501yUHghHouYiK8Y1npBtHRtoVwf61VLOxpxgK3AOxj1ccURQWztBz+5YAfYHXz /OeYa1UpJMRSD8HctUk9upwH3Pjf+eamVwKQwAjNYGERBDVf/vJAnNFM/NzpuuM+kMF/OO9tVn edmeDU2dnZeaLB19Wc6+ZLV0CTaCawAhWSBzRaO4z8kqTvXrow6j3sUQkrIDzkOXlrDeT/qP7P 0gs= X-SBRS: 5.2 X-MesageID: 39436879 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:e/rDgqrOh19NVVg6bWNMOjYaV5v5L9V00zAX/kB9WHVpW+SFis Gjm+ka3xfoiDAXHEotg8yEJbPoex7h3LR+iLNwAZ6JWg76tGy0aLxz9IeK+UyFJwTS1M54kZ 1hfa93FcHqATFB5/rSzQGkH78br+Wv37uvgY7loUtFaSFPR+Ve4xxiCgCde3cGITVuIZYiDp KT6o5milObCBcqR/+2DHUEQOTPzuej/P7bSCULGgI97022hS6ogYSQLzGjwhwcXzlTqI1Sk1 TtrgqR3MSemsD+8DDw/Sv575NamNzuo+EzefCku4wuBRjHziqtbIRlcbWesD4yu/HH0idXrP D85y0OEu42x3TNfnykgRaF4Xie7B8er0XM5HXdoXz/rdf3TDg3YvAx+75xQ1/ixGcL+PRfuZ g7uF6xht5sIj7r2BnZ3ZzuUSpnk0KlyEBS6tI7vjhkfqY1LINKoZd3xjIyLL4wWBjUxaoAC+ dUAMTV9J9tACmnRkGchGVpzdC2N05DZyuucwwHssyR5TBcgGp0+Use3NAehXcN7vsGOuF529 g= X-IronPort-AV: E=Sophos;i="5.81,241,1610427600"; d="scan'208";a="39436879" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C5uRLxMBq/ilq4k/ErNlN9b+HK5cB+kC4WK+S6EhtecBRXnxc2WzF07KORZae4m6jpCT9G4j1J34cFJbzdblmN4ns76xXfSC0zS43Y+JoaRC1OGHKljcf9GAUjn2axkx4JeVqdUfaf1jY/e+y44icZJDYkMts9GeDbnNkSdYefhg4mBMUDYj9fnIprldeDmkB/a5q0EVKHY2PIVax75clYPGUVahOaSmPE9dRsDf0Zmdt5rPwbOQJNxDCoo/pu46kCSCn50sGpuj/XQlI5xQC3BYgir4Lq1xhkzRhZaNmSA810Ero6EF3lftk0ejbMj7E7JB272TUiUa5h2Pz2FJow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ldEafCVFZbmjJ0KDRx6tD8FfKkQZCByBg8+UiYZVbY=; b=MyI/3rxlnhLo0JCnl1wiHHs74a4ZQBXbWUotqNsPX4vW3Ly/kJpgKDgjn01S6N8mPrb8AH0vJBNGnRGAtspX63+3BDPA1CgKVwqJnpOgDExbrpcmpMILCVt6wqxKM/K5ARNiL4Cqis+XQWHXj8VxyVgPmG3929et/b9ilF+JItobbqTQ+FO988XP7MS199gyLjqN6n+Cq1nNCwbl2Tw2QH3iLOfFmek9zIKhR8BPRG1Vo2zje6TUkEngomxrWn5EthubDc653EeUHB2g6D9wti1Q9oTNaQP+RtQ1tCk/JYP/yjlLUf6pLrzCMKK3I/HE7N1q70RpmmBqHQhBJF3/ZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ldEafCVFZbmjJ0KDRx6tD8FfKkQZCByBg8+UiYZVbY=; b=ikKSDlloaxqE0fcweAVQ3G5YsYGEjL6AwitykSGyiZf0F6GZAkurabBmQQnhEnXQT9AcQCIsvpPvksiiAmC7MRu3NsYZh8PbnCsvqvwpyWUPRwXGA/38hzlmbocDfRPyA0U4poNwoPQO+FZ03SazMy+FpI8KuRtOCuqjUcE+40Q= Date: Thu, 11 Mar 2021 17:29:30 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Dario Faggioli CC: Jan Beulich , Andrew Cooper , George Dunlap , "Ian Jackson" , Julien Grall , "Stefano Stabellini" , Wei Liu , Subject: Re: [PATCH] xen: fix for_each_cpu when NR_CPUS=1 Message-ID: References: <161545564302.24868.14477928469038686899.stgit@Wayrath> <9cc6f3ff-f078-1657-7c5a-9f356a857cdb@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0063.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::27) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 031cc694-08c7-461f-2053-08d8e4aadba5 X-MS-TrafficTypeDiagnostic: DM6PR03MB4474: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d9FEVtUYecBBQ7GJXq/1A3BmrrJNcLJ3KRkYmHtX+HKNVFYqVMHAPWamxTOmu25PG5UBlHmbcnj57w4xEAoK8L3qfkuk5/qCZxcDw+M1eYD7j+5f0TKGVTaO/hQERpG1vjuQOh6fuQiB26CEz5HseN7qzOXXKrzJ+tMg07nB+IYDT5iPZjYVD0xt/a90oCFjjjrdgs+/Gt/sFSwvXnGLBD/J1/LWu3PgTqiUBBb/NMZ3tWOVBywTqOmdFZVocNvZRKvbQ5OqtXUyWsdBtFdJ9daCgeDl7ixfRqTwJ2XVlKP9vgpQstsKUSUtPMrmiTw/YnqZN+t4+xv5w75qw4OxV+GYvicvGyMFj//a2a8qjeIISJ8m4mkP/RVNYU0SJXtT/AkNEQYYEXzxnyjgvYFgyQUMmGoPi/kEubEEQzUKqfwcTDuDITAMjhbXkjH+Zds3cLufPwcL9GcF2+ygO7n8hGdHGFZd0U+V2B8cbUovHGHKeTzxY9Bb0f4uQM6qObBsBFHlK5Wf9o4zrJZ6IzsYVOKOptB+Q3WfOTyWPSfHQNWT3xik5ZTu+94NXSmdSOE31JLNSKmqCIw3awm+9gG9Vr03MfwmkXJJooeRz69b6vI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(376002)(396003)(346002)(39860400002)(136003)(366004)(966005)(6486002)(6496006)(8676002)(4326008)(316002)(8936002)(26005)(53546011)(86362001)(54906003)(16526019)(2906002)(186003)(5660300002)(9686003)(956004)(66476007)(6916009)(85182001)(6666004)(478600001)(66946007)(33716001)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MThydktkTHU1SlFzbzhWallxTi9MUUlwMmtMOS84cmxIaW1YTUNsa3k3RS9G?= =?utf-8?B?OERWeFhYK1lORHg2R0FrazJyaWpWOGhCTllTVFh0UkZzZno0dko0N0lZb0JB?= =?utf-8?B?U3pmYzltdEtEZ3VldkpZWjdzdGRjRDUvdmp2LzYyMzgrQmtRRUVTZnY0bzV4?= =?utf-8?B?c2JWVlJwYWJTWk13ZU9kYmZ1T29sRy90em9GMXk0cW9EVVc0dlVRZ2dlWnZp?= =?utf-8?B?cG5UcjFOV1pjMFZta0hYaU1DbDlWelpFaDJQaWQzWkpmazJyeXU3S1pUbnJo?= =?utf-8?B?RVpoQkdnMXNnWS9pcElERFJLWFFuMHE3MTkza1JjQ1loWXozWUJHeWg4OUQr?= =?utf-8?B?cndudkVhSjYwNW02N241TGJBS2lLbzN5MEhBQklwcjgxSTRuVDVmVGRkWERF?= =?utf-8?B?QTNIUEVEVTE3T3BjU3VlYU1VckYrSjJSZ0JjakVock1YanVtWkhoTG55VWpE?= =?utf-8?B?L0VrVjloU1FWZVFHUDhId2hQK1loaTNFRElxUkowZitaaE5DWDFMOGpoRWZt?= =?utf-8?B?R3JHdExEeUVpYzIvR1NOTm90cjA2UXdGclRGM0FYcEFXcFpWcjRXSzVvOWxH?= =?utf-8?B?aGtGMnVSazBUa0pZZENvR2FOT2R5MFZ1N2s5Q2lwVzlickFOcE9MOHFOc0x0?= =?utf-8?B?ZmZGWWlyZTUzUjh6V0dwd0FEalN0NHJPaTNmRjE1V0h2dVVwajZHM1ZWN091?= =?utf-8?B?OVJqWmFLdUpZNjE3WTlEN1RtNU1SYUdwbWJqVjRPRXRwUXBqQVZhWlA3NFlC?= =?utf-8?B?TUkyVHBTT2ZTeERsZ2tyTE9qZzB2UnlUWUg2SmxIaWxWd2FwV2tSNTQ2WDlu?= =?utf-8?B?bTJja3hTNW1SRmhSMG5NcFZUYmJjcmhWdW52dmJWZTVRWXg1a0dEQVJwOERB?= =?utf-8?B?RmYyajU0allOSHNqZ0VPZ1hwUkQ3K2sxbVJjN1ExN2tHbmM2dGpJTkNYd2ZD?= =?utf-8?B?d0E1eVdSai8rR3dUdWdRUWRlOXBnMFhwbkNYcjdZWGxVUzdUZmVudmZZeGc5?= =?utf-8?B?akhzMFJKNzhjci9NZmJsY1c3WWtaMVYvdStZaVRXZEV2SHp4TldHOHhCeVhU?= =?utf-8?B?S0tDZlBab1R4Y3BzdktXT2x4WWIxTkZweDhUSmtpWWdrTEtLeCs5cTZ0dkFr?= =?utf-8?B?MzdneFY0dDZRMC9STjA2UXJrcSs5dEJwYUY0b0thN1FkUEhIRWpueE1HWHZU?= =?utf-8?B?TmdtQXNxR1NpYUJyb3FrL3hWcVhCQjFGMUp3ZTdRNnZCbEw0dlhWTGhNaUVG?= =?utf-8?B?RHg4OVJLckRSYnZoSC9wWWU2UXlHdVRuSStwRXloOXE3YXVHaGZGZU5Ca0Fl?= =?utf-8?B?Y01wVlNNdWxiTUljOFpMNkF0MlJMOWp3bEM1dnMveW5XaVcvT1pLamRGUi8v?= =?utf-8?B?MVlUWEpzMTlCL2FyYSs1QTlTR3NoZWNjaDBqNG5nRzcxM3ZnTEl5bHVsZXEy?= =?utf-8?B?L2VpSlJsTjAwWHkzUk1GT1ZZZVFReGU3YVh5dXA2T21CYkJxcVRBYlJhd3ZZ?= =?utf-8?B?amhTUmIvMm11cDBCNXhmRGVMK3NsUUQzeWRmVFNMK2J6RTU5QlNsN0xUY1hi?= =?utf-8?B?RmhpcitmWWpNVWI4VklVUUxtbWw0QlNiby9HeDBYaXlCVDBvV2FBcEg5S0lu?= =?utf-8?B?SVdFLytvV05qbmdpSVl1cm8ya0ZhbWtudWYxdk9MY2d6cERrV1F6dEQ5YU8v?= =?utf-8?B?UVVnQWt4aEM1cE1YVEN3M3lEcUtSZ1pWSmdHZmNWcU9uOEtZcFhMSm0zZmJB?= =?utf-8?B?R1hKaHN5bm1md0NDc2hFeE0vRitCa1h1eDFqQ0dsYXRvamF2T0M1ZkxFSUVq?= =?utf-8?B?ZjNHaDdiTHYxek0vdlA1QT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 031cc694-08c7-461f-2053-08d8e4aadba5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 16:29:35.5461 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7Zp2wgebnobz/W60+A0C7FZZYSOYhQhV4sKyfBaGLZskMzTfFl9Q2QW6+Fwk98lNcSsUxNnxC/9tVWkqavPcpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4474 X-OriginatorOrg: citrix.com On Thu, Mar 11, 2021 at 05:21:16PM +0100, Dario Faggioli wrote: > On Thu, 2021-03-11 at 12:28 +0100, Jan Beulich wrote: > > On 11.03.2021 10:40, Dario Faggioli wrote: > > > > > > Removing the special casing of NR_CPUS == 1 makes things work again. > > > > > > Signed-off-by: Dario Faggioli > > > > Doesn't this want a Reported-by: Roger? > > > It definitely does! And I even forgot to Cc him... Sorry Roger :-( No problem! Thanks for sending the patch. > Will you add it, or do you want me to resubmit with it? > > > Reviewed-by: Jan Beulich > > > Thanks > > > And FTR I don't really mind the other NR_CPUS == 1 piece of logic to > > remain there. > > > Ok. I agree with Juergen that they're totally useless, but at least > they're not wrong. > > Oh, BTW, since you mentioned in your other email the fact that this > comes from Linux, I've had a look there and there's a comment in their > cpumask.h file, under the NR_CPUS==1 define, looking like this: > > /* Uniprocessor. Assume all masks are "1". */ > > https://elixir.bootlin.com/linux/latest/source/include/linux/cpumask.h#L149 > > Of course, that does not make the fact that for_each_cpu and > for_each_cpu_not are identical less weird, and the whole thing still > does not make sense, at least not to me. > > I'm wondering whether or not it is worth to report this to them too, as > I have the impression that they just don't care. I would report it, worse case they will just ignore, but it would be nice to get it fixed there also, so that someone else doesn't have to discover the same brokenness. Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 11 16:45:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 16:45:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96695.183235 (Exim 4.92) (envelope-from ) id 1lKORN-00056B-25; Thu, 11 Mar 2021 16:45:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96695.183235; Thu, 11 Mar 2021 16:45:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKORM-000564-UZ; Thu, 11 Mar 2021 16:45:36 +0000 Received: by outflank-mailman (input) for mailman id 96695; Thu, 11 Mar 2021 16:45:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKORM-00055z-8q for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 16:45:36 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 05979bf0-1b58-4b9e-a1ac-d651c3d61433; Thu, 11 Mar 2021 16:45:34 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A5428AE89; Thu, 11 Mar 2021 16:45:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05979bf0-1b58-4b9e-a1ac-d651c3d61433 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615481133; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kWOIl8oLuAwGIDrlkjfHBd4+KSVj5o4ziFUBHJIRra0=; b=tuEe3I5juGDXWc1y6p4Faz4WSTuDWzPZBT/fDaoWbzKxvrBtsjL0r9YFqNUGr6QE9iD6uC XjwpYW2PWGNCpnj76JYG8/ffAHlLCGDguLaCAhG3zDpjAk7U+pqToD1ru1+WbxDvI1mjSE 0g2EdriBFV+O4KxhffW79SbQBodNSeU= Subject: Re: [PATCH] xen: fix for_each_cpu when NR_CPUS=1 To: Dario Faggioli Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Roger Pau Monne References: <161545564302.24868.14477928469038686899.stgit@Wayrath> <9cc6f3ff-f078-1657-7c5a-9f356a857cdb@suse.com> From: Jan Beulich Message-ID: <1d4c20c4-39e4-a05f-d4a4-c9a3ad56b64b@suse.com> Date: Thu, 11 Mar 2021 17:45:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11.03.2021 17:21, Dario Faggioli wrote: > On Thu, 2021-03-11 at 12:28 +0100, Jan Beulich wrote: >> On 11.03.2021 10:40, Dario Faggioli wrote: >>> >>> Removing the special casing of NR_CPUS == 1 makes things work again. >>> >>> Signed-off-by: Dario Faggioli >> >> Doesn't this want a Reported-by: Roger? >> > It definitely does! And I even forgot to Cc him... Sorry Roger :-( > > Will you add it, or do you want me to resubmit with it? No need to, I've taken note. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 11 16:52:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 16:52:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96699.183246 (Exim 4.92) (envelope-from ) id 1lKOYA-0006Aj-NT; Thu, 11 Mar 2021 16:52:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96699.183246; Thu, 11 Mar 2021 16:52:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKOYA-0006Ac-KX; Thu, 11 Mar 2021 16:52:38 +0000 Received: by outflank-mailman (input) for mailman id 96699; Thu, 11 Mar 2021 16:52:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKOYA-0006AX-0e for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 16:52:38 +0000 Received: from verein.lst.de (unknown [213.95.11.211]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e89263c1-ddec-42b3-b5ba-90fd0fcd16f0; Thu, 11 Mar 2021 16:52:37 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 8347C68B05; Thu, 11 Mar 2021 17:52:34 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e89263c1-ddec-42b3-b5ba-90fd0fcd16f0 Date: Thu, 11 Mar 2021 17:52:34 +0100 From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Claire Chang , linuxppc-dev@lists.ozlabs.org, Dongli Zhang Subject: Re: swiotlb cleanups v2 Message-ID: <20210311165234.GA25023@lst.de> References: <20210301074436.919889-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210301074436.919889-1-hch@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Any comments? I would be good to make some progress on this series as the base for the various additional pools. On Mon, Mar 01, 2021 at 08:44:22AM +0100, Christoph Hellwig wrote: > Hi Konrad, > > this series contains a bunch of swiotlb cleanups, mostly to reduce the > amount of internals exposed to code outside of swiotlb.c, which should > helper to prepare for supporting multiple different bounce buffer pools. > > Changes since v1: > - rebased to v5.12-rc1 > - a few more cleanups > - merge and forward port the patch from Claire to move all the global > variables into a struct to prepare for multiple instances > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu ---end quoted text--- From xen-devel-bounces@lists.xenproject.org Thu Mar 11 16:55:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 16:55:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96702.183259 (Exim 4.92) (envelope-from ) id 1lKOaX-0006I5-5A; Thu, 11 Mar 2021 16:55:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96702.183259; Thu, 11 Mar 2021 16:55:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKOaX-0006Hy-1g; Thu, 11 Mar 2021 16:55:05 +0000 Received: by outflank-mailman (input) for mailman id 96702; Thu, 11 Mar 2021 16:55:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKOaV-0006Ht-8r for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 16:55:03 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9bcecb91-1268-47f3-950a-9a8b9e056763; Thu, 11 Mar 2021 16:55:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bcecb91-1268-47f3-950a-9a8b9e056763 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615481702; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/gIkKx/bC+gRtnu+EyjWFScdDRrKTbNa60/cIkbI+4E=; b=TjfwTVzvKUvYfNn2sBMj0jAcHj3BQwR6qzj/TLBu7lbYo3vKYakwY93q CvIJyABflo9k1lNfsX3Bo/fwroZPLb52zx+TLM5sRi72Y9/JG0c4f+Ssz lKLHRvY2C1LSL8wVoeuPTY7R5hiQDZyTu9iaTk5+Rhzj5U6Pil8aYFwNF A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: uMmMyZKnjSFEwDHlDdlcoMQyyOuufpKkK9FfHZQ0VTV9gtMSwmbLrIT9Ut6kZ5otgzoJRSmAwF EvTlXYV68QEy6d+aoCbUDJ8gEyjxQTJUyP9n6Dy8e4x2VF4U5orO8uiIfWuQdkVbn30gSbZvvE ivcijMdnDn2w/Wl6aDFjoeV6n+BW0twFza+ETWJZavTrl3Zb0THR7jTbU+eSQXXN0sqaW8JQS/ dow+KC1cLmxBRycVzEn9K5dyv0t2+jUdF25CuFWBRK0aWdSI9Zn6WkKK0+PzOka87oKers1t0s xBQ= X-SBRS: 5.2 X-MesageID: 39254916 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Hn15Ual2+MMFtnOQPLubArK696/pDfNOimdD5ilNYBxZY6Wkvu qpm+kW0gKxtS0YX2sulcvFFK6LR37d8pAd2+ksFJ2lWxTrv3btEZF64eLZsl7dMgD36+I178 hdWodkDtmYNzRHpOLbxCX9LNo62tmA98mT9IPj5lNgVxtjZa0lzyoRMGemO3Z7TgVHGpY1fa D0jaB6jgCtfnkada2Aa0UtYu6rnbP2vaOjSQIKBwMGxWC15Q+A2frQCBiX3wobWzNLhYo4+W LGnxeR3NTYj9iLjjXy12rP448Tvd3m07J4dbexo/lQBzX3gAOhZIBsVtS5zUgIidDqzHYPvO TWqx0jVv4DjU/5TyWQmz/k2wyl6S0v7WTj1E/wuwqHneXJABYzC89MnutiA3zkwntlhcp91r lKwnLxjes0MTrw2Bnby/flSBluikKorXdKq59rs0Bi X-IronPort-AV: E=Sophos;i="5.81,241,1610427600"; d="scan'208";a="39254916" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dhz5sXeCQgbGDYUdwKPCtciMmoy1Fimjc2BFgVM4hwL/+Q99hX3IzyYlNacR7OMZP2i7YsWHCJdeCvFOMws8RIvLaZCXp2CEgU/gw9ZRBR02e9ogXTjCgH4A+E1tuKXmlyiQ4wluSCB2fTVYPR0OVLA2GlFq81g0Xiouwcfo2rMarmFfLJKGvHlCB73cNeImewHjKxFSlb9L5vMO1/gdlrYYnXzm1rYbchSeKOtfRClHjtEJf6I5n12TPWbEARQaPiViB7aSqS9Yug839bdWmozFr7rDoJIDr+p5NfmqHnyt25gTdU0eWJUAqqUDSRjOLo9cqvFCSaFWCIIR7k2yCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AjGpfmg6FSHoZxKGbxFAs+ITC+qglhp0If7gHSlolr0=; b=iBoXDRnhUnBqlYEZHspynKhYphfiKP51dvcMZ0qHz81pI9MrpjXm1Uyf0j3UxppFgHkOlrfhK5oj2muqiJM4AmmWYNK6VlAfI2zJ3N1ePYve2WwLTdnSiHxH3E/evAuRspNYvZ3ZqHMXmxPrd0+GGT50IgWjAheIFIje7YzXN+I/FdysE3cUws6IBshuVpSGvg+miO7RgEssQIySpvJnzlxjfB+/lIR+pVU9YQxnlH6WlhSWmAQARoC2oWxal0Ih632jaOxm/lcFcTg3NbyC4LeH3PkmysJsLgWAaVQdNvZdt/0HOnpVbcfPjhBz31rDCmO899aC6wJh9/7L0G06ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AjGpfmg6FSHoZxKGbxFAs+ITC+qglhp0If7gHSlolr0=; b=QOmw2yA+MWySzGTpCmOki9bMFm09UImegnHiO26ZtPKqVqhkF4wFGjtLIx4TBDepJPphQy2N6j6MdOudCmtltPYwjimaMB+EN4IFyHLXs21M5gJ30s8kNbNdqnvuwCJ11GCDJ75ZGHwbSVfOmsv+6HYTFjJvAyzbu8CB/VbVrAc= Date: Thu, 11 Mar 2021 17:54:13 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Ian Jackson , Boris Ostrovsky , , Andrew Cooper , "xen-devel@lists.xenproject.org" Subject: Re: Remaining MSR wrinkles Message-ID: References: <24649.6523.991714.489131@mariner.uk.xensource.com> <78536b74-2e6e-02ae-6655-d14fd97b3d37@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <78536b74-2e6e-02ae-6655-d14fd97b3d37@suse.com> X-ClientProxiedBy: LNXP265CA0021.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::33) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 46a7c74e-ed25-4586-7755-08d8e4ae4f64 X-MS-TrafficTypeDiagnostic: DM5PR03MB2972: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wsMxjOomwJ0MYK9gN0qXHqO/cObmfKbYeyc6ifi8kQ1UfYXU8zlUBdT9Wt9xmlkTkAexofvWGBvewS88ewYtGL00kTD8ciSFigaYz32ooTIIRDF8hAygcYgMQ3WgcnOtSVXNfC/WMt6mCs2ewGTgSZ6AsnOB090by9+yIaoXZwt0iA/xk3fOw6nNw1oeGsIc4zyCj0Q4QNMleZeBNll1S/C0umCRKxkUrEIWBaCfEePpV1D+KmGHbPUbRs2g21oSFQPlOvZocWhSKBOtjoHj1hGsjxZ7ECrI+z8bt6gJ0W2B33fLt5aBHlKb3PK+NR5Wo/SqmR7HJreu+2GdDYGkFlrkaMkdG7mo3IOvNpC72y6i1Wu0TEsj80EdQhDNDcIYRAOpDrcQ5fw9kgSciEahM+t7qSf18EWY4frz9bMguYRU8ZyuBnXD0+ob30puvln9mgSE9iTr2kvHliIH/KeqmBN/RfDwgdJ1jCwfuwBV31V4p6My4JO3c4SC9LYasoiw6BH+e0N1w6bpnVc7Nx2k/qa/NyaIi/mbmNxKNJa9ADzXuXEbxuRlFe79gWLR/ZNQ6uFPjIcCR12o6RCu7/jZfyBDcvKw7HOLxQOyZ/vunzY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(396003)(136003)(376002)(39860400002)(346002)(86362001)(54906003)(9686003)(7116003)(66946007)(186003)(66556008)(6666004)(316002)(8936002)(6916009)(4326008)(66476007)(2906002)(3480700007)(53546011)(956004)(8676002)(6496006)(6486002)(478600001)(26005)(966005)(5660300002)(33716001)(83380400001)(85182001)(16526019);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eXl0UGk2d2lHcjhQTWU5NzVURnhOSkoyS3ZFc094ZFZJbXQ3dkE1c2syL0xj?= =?utf-8?B?VXM5UVp5Vit3Rlh0ekJwY2JCRmZWVVpVVFdlU2I1YVkyYTE3c3Q0YTVRY0xq?= =?utf-8?B?SFZOZWpUZ29Pc2Q3QVA2WmlhbUhzLzZ0TUpQbkFVcnEzMkhjNGJ0MnR0eGpZ?= =?utf-8?B?VndPbjFxNGs3bkVLSlJaNnNyZVQ5LzBsOEozTHVyN2Q4VEtJY1JYV1NlYTg3?= =?utf-8?B?a0VRek0vY1ZTT3pTR1FpaitRRTZMU2E5NG5MZDNZbzRCQjJ5NkExanE3d0d0?= =?utf-8?B?b29VYm1rTk5vSEg3N3hEVWR0bS9UbW9VTERtRUpCaWRhaEpTNkQxdEJaTXJY?= =?utf-8?B?Y1d6aW9UMWhKZDFVZFFadlN2L09DcjRGbFdrWmdvWWdlV1JUNjZ2aU9YL1VT?= =?utf-8?B?Rm9wTklpb1F4TEhXQk9ac3ZzSmk0RTQ4MktWN0N1M3FCaGs0WWI4SEN2YjFV?= =?utf-8?B?L0FxMW9GVldjekdnN0RhR25MMlFzMms2OEJheENyZVQ5RlZIRlF0UkY3a1Mz?= =?utf-8?B?ZnNoeENFL2dDS2Y2V1JEaWovNDBmVDNtRGo3VHUvZ3NOWUtnVmVpeU83RUVX?= =?utf-8?B?dXZUekZSUE45RGpYS2FyUzRvaGxsNXNwWFEyMzJ4WGhxQVU5b3Q5OHBZVFpK?= =?utf-8?B?Tng2dkcweUVscW1yZ295YVI4VHFZS1Z1Y2JuYWd0S2NkalhvR29CaUJJc0Iv?= =?utf-8?B?NVJwSENMWk1ENll2K2dtbExjcDRMVHR0cDFDRHBKUUZucFpERWlHQzR4cGJE?= =?utf-8?B?cWlabDV3Rm5CSnEyYlpHbm1veGcwa3FnZ09ZWmpOZFJ2RHhiRkw4NmdsRFlJ?= =?utf-8?B?UWxrUlNXamtHaDR0ZEZyMUNnS28zQ1VWV3lkNXYxbm5yVU81cEhXZU91MDJK?= =?utf-8?B?Tmw0VjlZT2VtaG8vVllPd0cveGxMSk5yTVdtY2tWRzk4SEpoMGt4eWNhZmsw?= =?utf-8?B?cGJJSzE2c05hUkROR0JKc1BzTmNLMDFSODMwVkVrUklpZlFVbzF2cGdrUC8r?= =?utf-8?B?djR3Mk02M3g3WG1XdmFhTFFDZ293L0p1U3R6d3phR3Q5QWhLL2szQXRLTS9S?= =?utf-8?B?Tmg0cHhNMVUyR0tSdXZJd0R6K0NDOWw1QnNRZlVhTnM0MXNTWExMcDg2ZmVR?= =?utf-8?B?YmtRM2FkdGlsUWJvc2xteDhuRitGT2dhMlJDZmRLSVhEdmhQNlZnaFI4TkFI?= =?utf-8?B?VUlndjBac0NlOVVrMUoxeElLdEh6TDlpUUtnRGpLOGVIS0w1Qk9RcjBkTlJi?= =?utf-8?B?S1NtMG55QVdKeHZ2eXlmL08wb0J2YUFhYmFUdWFXSGtyZ05RQngyc3N0d0Zl?= =?utf-8?B?QWxMb0hVNjRpSjZSYUtHL29aTjhkazRibWtCV1Bnb28rS0c0SUVYN0pzcDJI?= =?utf-8?B?S3NoKzNCRy9KK0E0VHBVc0RuVElvNTNPNEk2RUVjTS9PQVg1UzVJb01VR2Jt?= =?utf-8?B?ZzkwNDVIU2tkamFSQ09GTXFueGl5eitlaFpoYSt4elR0M3hSNERZc0prNldi?= =?utf-8?B?RDQ1MXRBY0liTmcwUVpjalF5bFBWQUFJeFd4UlRrb2pqVWlVQk5BWkdYL29h?= =?utf-8?B?d2ZNaGlGb0ozN3ZvYkRkZGdlOHJEZHZJc3poZnNFRUIxc21yb3NCMlkxK0or?= =?utf-8?B?RW9CcnFRQ1VEZ2FpUzJFa3Buc1gzbWIxMWdUbHRxeWcwMFhZVkV2RGJEV3BQ?= =?utf-8?B?eXBoZ3p2ZWlEOFNqRnBpQy9LbFp6VlNwNzNQbGIvVGdGaURCZlBkTUFJaGpD?= =?utf-8?B?NnJtdHlRb2FtVXB0emtuSkJsOHc1MWRJbE44V1FDTXF1NHhuMXkrZTQrbzRh?= =?utf-8?B?L3hGOTR1UnRVWThxZ2EyZz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 46a7c74e-ed25-4586-7755-08d8e4ae4f64 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 16:54:18.1287 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eA5QwJV5J5aEr59/T1LRcpKID76JE+X4JJJ3YYrKuEZckQn54nOFqkIZYdXZvt69VJ0EZFLJGlcJO//Yhb/Gbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2972 X-OriginatorOrg: citrix.com On Thu, Mar 11, 2021 at 08:55:29AM +0100, Jan Beulich wrote: > On 10.03.2021 20:09, Ian Jackson wrote: > > (I bounced Roger's original mail to xen-devel. I hope it made it...) > > > > Roger Pau Monné writes ("Remaining MSR wrinkles"): > >> 1. MSR behavior for PV guests without a #GP handler set: PV Linux versions < > >> 4.14 will use rdmsr_safe (and likely wrmsr_safe?) without having a #GP > >> handler setup, which results in a crash. This bug was hidden in previous > >> Xen releases by allowing unlimited read access to the MSR space. > > I've not observed problematic wrmsr_safe() so far. > > >> Jan has posted several proposals to address this: > >> > >> https://lore.kernel.org/xen-devel/7e69db81-cee7-3c7b-be64-4f5ff50fbe9c@suse.com/ > >> https://lore.kernel.org/xen-devel/d794bbee-a5e5-6632-3d1f-acd8164b7171@suse.com/ > >> > >> Which all rely on the fact that for PV guests Xen knows whether there's a > >> #GP handler setup and can hence prevent injection of a #GP fault if no > >> handler is present. > >> > >> Andrew opinion is that we should instead try to figure out which MSRs the > >> buggy Linux versions try to access and special case them. Andrew also raised > >> the point that continue running with a 'fake' (ie: 0) MSR value might be > >> worse than crashing. > >> > >> Part of the discussion has also happened here: > >> > >> https://lore.kernel.org/xen-devel/4da62f0b-8a08-dd84-2040-fd55d74fd85a@citrix.com/ > >> > >> Look for the last quote. > >> > >> Another option is to document that PV Linux < 4.14 will require msr_relaxed=1 > >> in order to run. That as Jan pointed out will also imply PV Linux to run with > >> a faked (0) MSR value instead of crashing. > > > >> For 1. I do agree with Jan than this workaround is likely the best option we > >> have, sort of resorting to request enabling msr_relaxed for all Linux PV guests > >> < 4.14. Whether we want to limit this workaround to the read side only I'm not > >> fully convinced. There's something nice about having symmetry in the read and > >> write paths, but if all the calls we have identified are rdmsr only I prefer to > >> leave the write path unaltered and request users to use msr_relaxed if write > >> issues are found later. > > Especially if Andrew's ambiguous objection was against the write side > only, I think I'd prefer to go with this latter variant. Considering > that dealing with the read side alone is sufficient to address the > observed issue, I'm even inclined to prefer this irrespective of that > constraint. > > > Thanks. I find your explanation and arguments convincing. I have > > read what Andy says in that link and I find that less convincing. In > > particular "I don't think we should legitimise buggy PV behaviour" is > > not entirely consistent with our previous approach to > > bug-compatibility and support for old guests. > > > > Accordingly, (with committer tie-breaker hat on) I would prefer to > > apply the patches from Jan. I don't have an opinion about the read vs > > write question, and will probably be happy with whatever you and Jan > > can agree on. > > > > I don't think I Release-Acked those patches yet so, for those two, > > > > Release-Acked-by: Ian Jackson > > You didn't, indeed, but "those two" is slightly confusing, the two > links Roger did provide are just different versions of the same > patch. Hence I'd like to double check that it is exactly this one > patch of mine (of which I need to send another version, at least > to include Roger's requested documentation of the behavior, and > possibly also the write side equivalent - still waiting for Andrew > to come back and clarify the scope of his objection). I would leave the write side out. Now we have the fallback msr_relaxed option which should be enough to cover for any write side issue that might arise later. Also you have not identified any problematic wrmsr_safe so far. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 11 18:23:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 18:23:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96709.183277 (Exim 4.92) (envelope-from ) id 1lKPxZ-0006pW-R3; Thu, 11 Mar 2021 18:22:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96709.183277; Thu, 11 Mar 2021 18:22:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKPxZ-0006pP-Nj; Thu, 11 Mar 2021 18:22:57 +0000 Received: by outflank-mailman (input) for mailman id 96709; Thu, 11 Mar 2021 18:22:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKPxY-0006pK-JY for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 18:22:56 +0000 Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b75882ae-a83b-49fb-b91b-7531ba52f167; Thu, 11 Mar 2021 18:22:55 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12BIBa0w098091; Thu, 11 Mar 2021 18:22:54 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 37415rfjcy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Mar 2021 18:22:53 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12BI9YlP116935; Thu, 11 Mar 2021 18:22:53 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2103.outbound.protection.outlook.com [104.47.58.103]) by userp3030.oracle.com with ESMTP id 374kp1cfm3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Mar 2021 18:22:53 +0000 Received: from MN2PR10MB3293.namprd10.prod.outlook.com (2603:10b6:208:12b::24) by BLAPR10MB4915.namprd10.prod.outlook.com (2603:10b6:208:330::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Thu, 11 Mar 2021 18:22:51 +0000 Received: from MN2PR10MB3293.namprd10.prod.outlook.com ([fe80::b87b:5cdc:87f4:c465]) by MN2PR10MB3293.namprd10.prod.outlook.com ([fe80::b87b:5cdc:87f4:c465%6]) with mapi id 15.20.3912.030; Thu, 11 Mar 2021 18:22:50 +0000 Received: from [10.74.105.6] (138.3.200.6) by CY4PR15CA0012.namprd15.prod.outlook.com (2603:10b6:910:14::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Thu, 11 Mar 2021 18:22:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b75882ae-a83b-49fb-b91b-7531ba52f167 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=T+KFszDK3IGw1hvZbM6oiEBYTY7rKXeRV+C7FukvB+A=; b=CKzvy8KyZDZALQJbj7UtPssvQo2RwylJ8HOX6lNZHQW1+WpuT07tXNGCWcSUvnt70eCF ODevmqWYVFp2oeDI20EibixIdxeWVm35dPNJA8KS+PW9zJ9dVx8ciJGgLaOe9jvpoZH5 kPzDAf3nOTBe114RzWTkeenZ3Hyirl7YfBCgWTtKotTm6A0aGKPy45H6WMS3BqIL5buk PfT+7OvRrDj/PEZQCGJYAq0pR4lXcyBWFbGWpjYIEdh75s3lb2N1GdLP0x8THB859agd vWkyFvq7B+6caqBu5H+LlbuKHpztRawID91ch8XpX9QoQVE1WHvxtULyUobMrK/wJjnH ow== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mWaFYBRG/0u8xMXr4Fz8jx8BVPM0X68NrgErrycb5cfL/0M6Y5ASAXEoh4166qKMs6xvhS95Ec1EkyddeX3VO1eHqwtdhH2WEZE75UVe/7rWv7spjMgBm69vHfUyIaZBUoOHNfsoBIMWjPgL3Kwkn6c9NcPmcLpTOoYVM8JAKHY/ERR89cOVxsyo8vnUYAc0qi6bK6ygT1NQAR1IreJxh9aYN3VtVPTJt+lx31Ip+3WajyogS/SpU/j2SvAxhJsW+WYtjgJAZmAjDTtveqnsW6S81nf3/KH4dfSMOrUf9CTRtU9zUUyecHIIV68qY5ZBglU/W16k2dnRIsFoZF5ZSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T+KFszDK3IGw1hvZbM6oiEBYTY7rKXeRV+C7FukvB+A=; b=Lxi4U8yyZ0IqcT93PGKcauVuCBeN4Eac7h6ow/GXOMvOMxdtUqqt+9XGQSDGlw7QQNEEbPKUzOCDsPb/MDW51wmbrCnKZ15ckKIWaLzRk876YznStQqi6zwaqI1MMvG3Wq6TlFmxuWQ8N9VviVRi8cnMnMnwLnpM6mMyx5D+vqezSTlJ3lMKgW6kfhDaUMfKeRNm3LpBJJf+VgyDHhJWgWF+j1HQkhGlIUi41j5V1CUKWTMxAdJ94ck4Hl7pxxnNFZTQOsErBHGRTDAKSNG5GP255AfDrU6LmeN0vmK7zTticaGqx951ng/81Gh+I5g0hCPyb8+q7WXWyxz/zQjwEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T+KFszDK3IGw1hvZbM6oiEBYTY7rKXeRV+C7FukvB+A=; b=P2URlzsfJ5zmZiHZ0+y14LWPr+lovDW6Sz7In6N9C20C3dDc+FebZWe49/yp2y14MAk8VysPr3z5oWTTUCsbEjrW0WCxehJBNpoWQwIFNKNd7VJL5jePvinP9xEULo7/AmkkR6b4GrGnCIuLCRYKquabg0iCmivPYksEYj5Yzug= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; Subject: Re: Remaining MSR wrinkles To: Jan Beulich , Ian Jackson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: committers@xenproject.org, Andrew Cooper , "xen-devel@lists.xenproject.org" References: <24649.6523.991714.489131@mariner.uk.xensource.com> <78536b74-2e6e-02ae-6655-d14fd97b3d37@suse.com> From: Boris Ostrovsky Message-ID: <766efe2c-2361-9ddf-2ebc-b8ff808673b4@oracle.com> Date: Thu, 11 Mar 2021 13:22:42 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <78536b74-2e6e-02ae-6655-d14fd97b3d37@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [138.3.200.6] X-ClientProxiedBy: CY4PR15CA0012.namprd15.prod.outlook.com (2603:10b6:910:14::22) To MN2PR10MB3293.namprd10.prod.outlook.com (2603:10b6:208:12b::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 90ccbcf9-e65d-48f2-0668-08d8e4baadac X-MS-TrafficTypeDiagnostic: BLAPR10MB4915: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZM9TWrlrkUmsufHXnTaAh/izzo5msJ0wnCywMPyIbFrsNTyRx0vc+F1eUxKOOJ/M8RAvFM6hypNw7G3/oLcac2dOCiQvEArxrH05fvkCrHRDcNFYkJMCcMIwWwL8FjWpx8YOzWAO0u/gRPWupK1taMP46/TaHXksjJNuIeddRGy29ohvEzuL2Fg92JRgnR2Q5kFkj9xHawpV4nOrnmpaanLUr/DML41tsXkIK1w3wR7nex1kHHZejFt488o8AO3wxBYjaUbRdVP3bDMBPo5gSxOiXfukUItpdzFPP9Wj0ka8Jd/foVDTxvyvUWZSBLz/4yz59HyZgoOoTsWCu/hCcZ3UarGH2ACnxkNEIbX+oajOCkwl7spnxoOo06//SIc5r85GQbQByjx7iWFb0okGiHVN6B39gdCruw/RUgKM2TEZBkLxrWXuStxH8+h4wcR5mBV5mQB+UiR5A5noB5gxMyE9/1ZZJqco5s9UyHAVhlLSvewe3Bo5do3mv3eEEiWFM0kJwe8xwML7LYCMzScK9rwkxkp0uYQ7POpglIGR1pslTyIrzJHLaftcv6DQVbWQK6vKOC9dVGkV/HqqNgq4rAv8LcAIjI6Qa6LrLblnO9ra5VZE1xHInZmTSznH719k68Kmz8NvF1V4/jx5BDEnslh5Ua5yRyx/Db3WTLIP1ZC2tl6gmH79q3NjL400TRTK X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3293.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(346002)(376002)(136003)(366004)(396003)(44832011)(956004)(4326008)(2616005)(66946007)(36756003)(53546011)(2906002)(26005)(8936002)(66556008)(66476007)(966005)(31696002)(8676002)(6486002)(478600001)(6666004)(31686004)(110136005)(5660300002)(3480700007)(16526019)(16576012)(186003)(86362001)(7116003)(316002)(83380400001)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UEJaT2U0SE5TYWdrNE1mUWxJcHZYVDduZEVVME9vbUVXbk5udXBWWGxpTGl0?= =?utf-8?B?cm5BRG1ET1VveExmUDh5dnJvOGtDeDNDOEtnQU5yWW9YcE0vTWdLVmYxTTRJ?= =?utf-8?B?UWs4MXhpU1JRemNlVUlsQ0UyR25zNllrTWx4eGpLTGVsYU1yYzJzT245Vzk1?= =?utf-8?B?bjlhZW1vNzVhL2tnbTlzdFRqZnVlejFjankrUFQ1STBXajFucHAyTEVEdS8v?= =?utf-8?B?T3U5MlhPVERnMGh0djZrdUIzTkdFWjM5Smd4Mmszc1J0aXVpTytOYXR1eHA5?= =?utf-8?B?L1Q0dDBmangrSkFqMTJ5WG8xTWxGMDl2YUJvOW9JZ0YwaDRXSU54TU9Va0JP?= =?utf-8?B?V1ZXL3NXRHA3UU5BdzJqTHBxNys2VmhpSmh0LzZ0VkJHWWVqaGxUVWN3RUoz?= =?utf-8?B?dFlHZG4waklONmZLK3JrSVN1bjd3cHpaQXYrb2Zoa0lCSDRkbWZZNUlreUFC?= =?utf-8?B?UnFKdWptV3MyTmtCOW95T1VyL29GcDNsdFRuY2YzRGZsU3hiRW81Q1czdE40?= =?utf-8?B?NmlwdXNKNnA0K3JuM1BhKzlyanVTblQwTHBrSVBPNGlrNGVaL2JpMWpNaG01?= =?utf-8?B?cjBrOGVnbzlZbHN5OVFHdC9mbXdKdTJ6NlQvckdvcG4xVlBnQ1hvbk52Tkw2?= =?utf-8?B?a041QnUxcHprUGI4T3UyWG5HbUN3NE5vb012VWRFSXhmakNHSFpOcnNvbVlx?= =?utf-8?B?d2kxZEJlWXNnSFZVQU55ZE1KdHFWRTNHc0lMN21ZMTdUcGdHY25KQjQwVGM1?= =?utf-8?B?WUFhL3pxM3ZBOFIyR3k2MENwZHRYa2Z1Um9mSUh5TXpIWjZtakg2bEdhSVRk?= =?utf-8?B?eVZYR0QrRmJNV3JOQjdDNThwc3lIbHMxSTFONzA5TllteUNhazRwS3ViZ3FQ?= =?utf-8?B?N09IRGZvNEhRNkx2MkRyVmI2K3ozMnBIdXJwejFZUDdyOXRwcHRNMlhxTHd1?= =?utf-8?B?NG13M01FSzh0dTVnVXp4NFB6SCswZG9KT2J2dHlSR3JJbXVHMkFTcUNWZ0pl?= =?utf-8?B?TGR6ZitUaXd1WFZoZnJGU0dVMmNpL2FPcDNqVERBdEk2dVgrdXYzUFdaOHo3?= =?utf-8?B?RGdwS0d4WFZTZXhqcUhGbWo3aWVST2tnUnJhODJ5aHFDN3BOY1FSejFmMHN3?= =?utf-8?B?Tmc1QzNEaVdGcGpyQkJCVHExTFFCMERPbXVXQmVHT1RZSDIyRFRKeHpXbWp6?= =?utf-8?B?UDBCSlhHbjdhS21zT1FjQ0dnazNJMXpSTER3ZENJU1BUblIrYTVOUkg3dXR2?= =?utf-8?B?SW5GOUVDUEkxVkF3RjVxbVZkT3RiQ1UvRXBGMEw3OHhDRjRZNFNYaFhQKzdj?= =?utf-8?B?U2dXV3ZKNjFZMUdabE1SRm5DSksxY3N0TjNtZUxjYmsrNEdLT2xlOTcxREcw?= =?utf-8?B?bVNLemlOMjdNVGk5ZjJzcHhSK1Z2U0RPdWI1Q1MxSWVZVGFad09KakhPMGxa?= =?utf-8?B?RVRUay9Ddm41Ynk4SlhKaDZBcVY5dS9jMlluQ1F1VWhDZE5LMTltOTNhbS95?= =?utf-8?B?SGo5bXErd0NJUGN5YVhKa1VvUUdERjlRaTRiN1BHb2RtRUlXSzRJQ2VlMHpI?= =?utf-8?B?SEtXSlJuTHVLeWErN0s1czJpa0FmcmZVYkFiWjJkeFRiQ3NiNnNMakw4KzFL?= =?utf-8?B?MWVhK245L1Z0SmdlSWNhL0F3TEZEV0xFOUhSZ1BEakkwZXdtTTdNSTMyYUZu?= =?utf-8?B?VWM1czFWNktMbkxuMWc1SnhqUXREbEE2cXhoQVZkVkZQVEVSREp5RmdSaERa?= =?utf-8?Q?+OzTf3bh9Spsf6vr8627d95QerT7XdBVkGQG11a?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90ccbcf9-e65d-48f2-0668-08d8e4baadac X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3293.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 18:22:50.2796 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iEz2XcpN6YdEuRWvC7fSg5InwJOfHSDhe4SdzrXf98qQHqAUylIMl/i8CDZD6Q2eDsNe46ht6G7wpgnN/8YqdKmO2DfFL/QRe2Q0gChoRJU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4915 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9920 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103110094 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9920 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103110094 On 3/11/21 2:55 AM, Jan Beulich wrote: > On 10.03.2021 20:09, Ian Jackson wrote: >> (I bounced Roger's original mail to xen-devel. I hope it made it...) >> >> Roger Pau Monné writes ("Remaining MSR wrinkles"): >> >>> 2. RAPL_POWER_LIMIT: handle the MSR explicitly to make Solaris happy. >>> Alternatively we can list in the release notes that Solaris guests require >>> msr_relaxed=1. Andrew is working on a patch for this. MSR_RAPL_POWER_UNIT (in Linux parlance), i.e. 0x606. >> I would prefer to handle the MSR explicitly, for the same >> compatibility reason as above. > The question is here - we aren't sure yet that this is the only > one, are we? Andrew suspects if this one MSR gets accessed this > way, then likely others will be, too. Boris, can you tell for sure > either way? The only one that Solaris reads on boot in 0x606. However, a few more may be accessed unguarded if kstat runs, as I mentioned in https://lore.kernel.org/xen-devel/4fc3532b-f53f-2a15-ce64-f857816b0566@oracle.com/ (I have not been able to empirically verify that) > > Also, Boris - any chance you could give your Tested-by for Roger's > patch? It's otherwise ready to go in, but I'd prefer to commit it > knowing that you've tested this hopefully final version. I'm sorry > for the recurring requests to test this workaround. For v5: Tested-by: Boris Ostrovsky From xen-devel-bounces@lists.xenproject.org Thu Mar 11 18:34:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 18:34:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96712.183288 (Exim 4.92) (envelope-from ) id 1lKQ8M-0007x3-QE; Thu, 11 Mar 2021 18:34:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96712.183288; Thu, 11 Mar 2021 18:34:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKQ8M-0007ww-NI; Thu, 11 Mar 2021 18:34:06 +0000 Received: by outflank-mailman (input) for mailman id 96712; Thu, 11 Mar 2021 18:34:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKQ8L-0007wr-NM for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 18:34:05 +0000 Received: from mail-pf1-x434.google.com (unknown [2607:f8b0:4864:20::434]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0ce06f15-c045-4b52-b1aa-8b89e7816e0d; Thu, 11 Mar 2021 18:34:04 +0000 (UTC) Received: by mail-pf1-x434.google.com with SMTP id a188so135305pfb.4 for ; Thu, 11 Mar 2021 10:34:04 -0800 (PST) Received: from ?IPv6:2601:1c2:4f80:d230::5? ([2601:1c2:4f80:d230::5]) by smtp.gmail.com with ESMTPSA id gz4sm2953252pjb.0.2021.03.11.10.34.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Mar 2021 10:34:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ce06f15-c045-4b52-b1aa-8b89e7816e0d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:organization:to:cc:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=Viw3fs9xSOk3floRadbZbBqxhggHQ/CuFwAqa0RM85w=; b=fX+pCwlxConGkm8T1dEcR4BTjPw+iL33plnI2vs5ccVvy1EmRYcZekNH5UJtHMYIwg n0r/tK4s/oF777QQ5XFj270TAjMSkPJH7YZITI5yOMhdvIRYcpAqlrhk+lZFA6LLfZBL /Lm/gbUBstu++1wqmS+1xYcHJPqE4f20WSM3JKZZYJj3CgBnK9qCxT5d1Ce0treA+Gjk Myxjw8t8OwGQm2R/grwp5MnO6CQoeW/1gUcx/6gMjcCsyqGCk6JuAK0NtHkKTfmzSbxm Qw8qt1k/pftfiY4IUovG5QH5Z/ODWf9dzVjpROmETDtUBeXbau1bJKADr/BqQQeNAkFA 9h6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:organization:to:cc:subject:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=Viw3fs9xSOk3floRadbZbBqxhggHQ/CuFwAqa0RM85w=; b=WbHPK0wDeHZenhPvAwr8kP8f2Nwl/nXgNf3ID8cRyNP3WWdLAlgx3YyGDqCx9QdzBV TeZPJ0t0kHMA7kccbLoWo8Jv9afdetl45SphnOHT73rkU0QrHj1lo+MECTSb+tqHQlSc 7ddN3Me3JeemSephuPqZhja+LEXBdgbX33byRLLqIy7pFhh4NRwd0cQttLJM5VNALksh E7gQoVr5JGNjduigCrgQyj235CY7tMfzSUCrSRLZ0/jBXdYx93FxPdnuptcsrweQX3jX QP4A+Ian9QxvrxInytD3jQKoPWcqrqAm9qCGX0TRHU1RqpoKW+HaJyiWA1MVgRP6rxjk U6fw== X-Gm-Message-State: AOAM530Ma1EKOe93sDfK99UeodFRg35LaTZw6fw5lOm844f0ouath4hD gkX/VpgTeDQu7MI9jWCLlKg= X-Google-Smtp-Source: ABdhPJz+OnX2bGXdnoz61l9f5lQEUzQ/e5w2d6x2Frq/KCIhSVVm2+spVnTQfMFw2XmlYnG71CrblA== X-Received: by 2002:aa7:8a99:0:b029:1a6:c8b8:1414 with SMTP id a25-20020aa78a990000b02901a6c8b81414mr8363944pfc.66.1615487644214; Thu, 11 Mar 2021 10:34:04 -0800 (PST) From: Bob Eshleman Organization: Vates SAS To: Xen-devel Cc: Andrew Cooper , George Dunlap , piotr.krol@3mdeb.com, Olivier Lambert Subject: Working Group for Secure Boot Message-ID: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> Date: Thu, 11 Mar 2021 10:34:02 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hey all, We would like to start a working group for secure boot support in Xen to coordinate the various interested parties and set out a plan for the feature and its implications for the whole Xen system. The end goal is a full implementation that restricts the interfaces dom0 has to affect Xen, akin to Linux's lockdown LSM. This implicates important parts of the ABI (e.g., /dev/xen/privcmd/) and so will require input from the greater community. I'm not familiar with how working groups function in the Xen project, so this email also opens the floor for suggestions as to how this might be managed. We'd love to hear from anyone interested in such a group and how the community as a whole feels about such an effort. Best regards. --- Bobby Eshleman SE at Vates SAS From xen-devel-bounces@lists.xenproject.org Thu Mar 11 19:07:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 19:07:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96717.183307 (Exim 4.92) (envelope-from ) id 1lKQeQ-0002dp-FM; Thu, 11 Mar 2021 19:07:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96717.183307; Thu, 11 Mar 2021 19:07:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKQeQ-0002di-Bw; Thu, 11 Mar 2021 19:07:14 +0000 Received: by outflank-mailman (input) for mailman id 96717; Thu, 11 Mar 2021 19:07:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKQeP-0002da-AQ; Thu, 11 Mar 2021 19:07:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKQeP-0003ds-3G; Thu, 11 Mar 2021 19:07:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKQeO-0005C2-QR; Thu, 11 Mar 2021 19:07:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKQeO-0005LB-LL; Thu, 11 Mar 2021 19:07:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EL+68i7pvineGOwBv07iudP4yc5M0Qy5IXtWMcHSr5A=; b=W3hgLDKP8yTPt5925c3hlg2HIj cQrLH4IGVQziWTIPGc+m0Uuf0fqLfw1DxIX43v4nJrNSOXQDo9ZL3RfYisYMVNcTOLFjiDIL12qK/ 3Q9KDC5g+SSkFF5MzlKoeiAu0hkoSxuv9TaXBqfzQCLHCCJ4VzBcF3hS2KWSOFuj3CeQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159941: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=893103e286ac1c500d2ad113f55c41edb35e047c X-Osstest-Versions-That: xen=935e0836710ce8cab584155b2844cea8497a5159 From: osstest service owner Date: Thu, 11 Mar 2021 19:07:12 +0000 flight 159941 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159941/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 893103e286ac1c500d2ad113f55c41edb35e047c baseline version: xen 935e0836710ce8cab584155b2844cea8497a5159 Last test of basis 159934 2021-03-11 10:01:42 Z 0 days Testing same since 159941 2021-03-11 16:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Doug Goldstein Roger Pau Monne Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 935e083671..893103e286 893103e286ac1c500d2ad113f55c41edb35e047c -> smoke From xen-devel-bounces@lists.xenproject.org Thu Mar 11 19:39:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 19:39:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96726.183334 (Exim 4.92) (envelope-from ) id 1lKR9J-0005kC-79; Thu, 11 Mar 2021 19:39:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96726.183334; Thu, 11 Mar 2021 19:39:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKR9J-0005k5-3u; Thu, 11 Mar 2021 19:39:09 +0000 Received: by outflank-mailman (input) for mailman id 96726; Thu, 11 Mar 2021 19:39:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKR9H-0005jx-3g; Thu, 11 Mar 2021 19:39:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKR9G-00048F-PZ; Thu, 11 Mar 2021 19:39:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKR9G-0007cG-H8; Thu, 11 Mar 2021 19:39:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKR9G-0003n8-Gf; Thu, 11 Mar 2021 19:39:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oroH4fu3XR/CILwlJoelDCbBguR8mNZx0J/B4o+E1nE=; b=2YY5rnT+ok7eK/Wox4ZcldvVh/ prEbgAy22HOZalzzSDDKP+BC0DhLa2qwKYNUpp61sRt+gleQH/6Rr4pBRZkPDlsC/BXAwfiyLxXri cE9HOzZT5sIT+zNhduyJ2kyiwv64tPzx3ebqcSoEME0dOu0XR9U1SbGBayh9k84e3yas=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159926: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=821e7ed167f11f482d2d1a8eaf114a667295a581 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Thu, 11 Mar 2021 19:39:06 +0000 flight 159926 qemu-mainline real [real] flight 159944 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159926/ http://logs.test-lab.xenproject.org/osstest/logs/159944/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 821e7ed167f11f482d2d1a8eaf114a667295a581 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 203 days Failing since 152659 2020-08-21 14:07:39 Z 202 days 388 attempts Testing same since 159926 2021-03-11 03:11:25 Z 0 days 1 attempts ------------------------------------------------------------ 441 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 124570 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 11 22:26:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 22:26:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96742.183355 (Exim 4.92) (envelope-from ) id 1lKTlS-0005UP-3I; Thu, 11 Mar 2021 22:26:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96742.183355; Thu, 11 Mar 2021 22:26:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKTlR-0005UI-VF; Thu, 11 Mar 2021 22:26:41 +0000 Received: by outflank-mailman (input) for mailman id 96742; Thu, 11 Mar 2021 22:26:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKTlQ-0005UA-PM; Thu, 11 Mar 2021 22:26:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKTlQ-0006tl-ER; Thu, 11 Mar 2021 22:26:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKTlQ-0006Ds-32; Thu, 11 Mar 2021 22:26:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKTlQ-0003K0-2W; Thu, 11 Mar 2021 22:26:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=InAnQxtOzhbsDq4FyZUT5yPrJXz2xlq4/dbzPxR69wY=; b=64g5+94b4HcOSNPX/uAlQtqg8A U2qPWhoMyjPiwNs2MA15q2T2Zp/+zQ1n7q3A/spo52CtmACA6Qswx4NOJwnowpCCdGiW6JGWiixK/ ij8hmTLHZ6YcXfDI2ewH8BeRuIOULmEnv1KgCcuiOJATmodqWHoF7xpl0h9D/BCZCEnY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159931: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-localmigrate/x10:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a74e6a014c9d4d4161061f770c9b4f98372ac778 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Thu, 11 Mar 2021 22:26:40 +0000 flight 159931 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159931/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 19 guest-localmigrate/x10 fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux a74e6a014c9d4d4161061f770c9b4f98372ac778 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 223 days Failing since 152366 2020-08-01 20:49:34 Z 222 days 384 attempts Testing same since 159931 2021-03-11 08:03:20 Z 0 days 1 attempts ------------------------------------------------------------ 5182 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1284567 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 11 22:58:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 22:58:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96750.183375 (Exim 4.92) (envelope-from ) id 1lKUG3-0000EU-Gc; Thu, 11 Mar 2021 22:58:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96750.183375; Thu, 11 Mar 2021 22:58:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKUG3-0000EN-Dj; Thu, 11 Mar 2021 22:58:19 +0000 Received: by outflank-mailman (input) for mailman id 96750; Thu, 11 Mar 2021 22:58:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKUG3-0000EF-0X; Thu, 11 Mar 2021 22:58:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKUG2-0007Nk-O6; Thu, 11 Mar 2021 22:58:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKUG2-0007uj-FC; Thu, 11 Mar 2021 22:58:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKUG2-0001BK-Ed; Thu, 11 Mar 2021 22:58:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cUf9ga4724bFeBbFG1SuxAscgAFxYx+7FvjD5YT2ChE=; b=emtC1oOxRWG0FppZD9GviUgjSN Qky+y0xSmv3a8U/PGjf5MTHBUx5zKGr+nPn7Tvvz0hfdjRcNWhZGHYfaaUECZ4qT67VBFzmgwzNtt Bwc/OmGXFTtpzCuKzGjBHsVxyoHQtcAN/KJZMD9vrNPkrQtvNgDVC/jxY8xzGVpzOQpw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159946: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9e23f10eb0db5ffa06f1a43f74fac790992a85c7 X-Osstest-Versions-That: xen=893103e286ac1c500d2ad113f55c41edb35e047c From: osstest service owner Date: Thu, 11 Mar 2021 22:58:18 +0000 flight 159946 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159946/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9e23f10eb0db5ffa06f1a43f74fac790992a85c7 baseline version: xen 893103e286ac1c500d2ad113f55c41edb35e047c Last test of basis 159941 2021-03-11 16:00:26 Z 0 days Testing same since 159946 2021-03-11 20:02:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 893103e286..9e23f10eb0 9e23f10eb0db5ffa06f1a43f74fac790992a85c7 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Mar 11 23:00:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 23:00:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96754.183391 (Exim 4.92) (envelope-from ) id 1lKUHq-000157-TO; Thu, 11 Mar 2021 23:00:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96754.183391; Thu, 11 Mar 2021 23:00:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKUHq-000150-QK; Thu, 11 Mar 2021 23:00:10 +0000 Received: by outflank-mailman (input) for mailman id 96754; Thu, 11 Mar 2021 23:00:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKUHp-00014v-Tb for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 23:00:09 +0000 Received: from smtp-fw-4101.amazon.com (unknown [72.21.198.25]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a79dd51f-88e1-4309-b5ae-93e36f2cb113; Thu, 11 Mar 2021 23:00:09 +0000 (UTC) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2b-c300ac87.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP; 11 Mar 2021 23:00:00 +0000 Received: from EX13D12EUA002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2b-c300ac87.us-west-2.amazon.com (Postfix) with ESMTPS id 1C690A22E0; Thu, 11 Mar 2021 22:59:59 +0000 (UTC) Received: from dev-dsk-andyhsu-1c-d6833dcf.eu-west-1.amazon.com (10.43.160.27) by EX13D12EUA002.ant.amazon.com (10.43.165.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 11 Mar 2021 22:59:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: a79dd51f-88e1-4309-b5ae-93e36f2cb113 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1615503609; x=1647039609; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=f4kw6VKDxqZ6aK5je+CShKYL/i9tWOOhWCfFur47MZU=; b=UGUGIPn3RL2Wn973dCqB/OjjJ4bfP7W5bmGnhUToh/mPXPZsqFGU1baG ISbwkSoVNRVbIguZmtKNU+POg04oHzvFwG4JyTFi4ucA8DozH+JT/z9Dy gMO7yeBowP+S/4yghbpOc52VEcXv9SgLCELVdk6e+tet+L/7U6ZCnQR71 g=; IronPort-HdrOrdr: A9a23:hblugKnnQPn8kG+AHnwCCxgN7sfpDfKS3DAbvn1ZSRFFG/Gwve rGppsm/DXzjyscX2xlpMuJP7OOTWiZ2Zl+54QQOrnKZniChEKDKoZ+4Yz+hwDxAiGWzJ846Y 5Me7VzYeeQMXFUlsD/iTPUL/8F4P2qtJ+lnv3fyXAFd3AJV4hF4x1iAgiWVm1aLTMnObMBD5 aX6sdKoDCtEE5nF/iTPXUOU+jdq9CjrvuPCnQ7LiQ64wqDhy7A0tDHOiWfty1zbxp/hZ0m8W TDjjXj4LSiv/yR2nbnpgnuxqUTvNPgz9dZbfb86fQ9G3HLkQanZINoRr2EsnQUmYiUmTEXrO U= X-IronPort-AV: E=Sophos;i="5.81,241,1610409600"; d="scan'208";a="92295156" From: ChiaHao Hsu To: CC: , , , , , Subject: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring Date: Thu, 11 Mar 2021 22:59:44 +0000 Message-ID: <20210311225944.24198-1-andyhsu@amazon.com> X-Mailer: git-send-email 2.23.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.43.160.27] X-ClientProxiedBy: EX13D42UWB003.ant.amazon.com (10.43.161.45) To EX13D12EUA002.ant.amazon.com (10.43.165.103) Precedence: Bulk In order to support live migration of guests between kernels that do and do not support 'feature-ctrl-ring', we add a module parameter that allows the feature to be disabled at run time, instead of using hardcode value. The default value is enable. Signed-off-by: ChiaHao Hsu --- drivers/net/xen-netback/common.h | 2 ++ drivers/net/xen-netback/netback.c | 6 ++++++ drivers/net/xen-netback/xenbus.c | 23 ++++++++++++++--------- 3 files changed, 22 insertions(+), 9 deletions(-) diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h index 4a16d6e33c09..bfb7a3054917 100644 --- a/drivers/net/xen-netback/common.h +++ b/drivers/net/xen-netback/common.h @@ -276,6 +276,7 @@ struct backend_info { u8 have_hotplug_status_watch:1; const char *hotplug_script; + bool ctrl_ring_enabled; }; struct xenvif { @@ -413,6 +414,7 @@ static inline pending_ring_idx_t nr_pending_reqs(struct xenvif_queue *queue) irqreturn_t xenvif_interrupt(int irq, void *dev_id); +extern bool control_ring; extern bool separate_tx_rx_irq; extern bool provides_xdp_headroom; diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 39a01c2a3058..a119ae673862 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -48,6 +48,12 @@ #include +/* Provide an option to disable control ring which is used to pass + * large quantities of data from frontend to backend. + */ +bool control_ring = true; +module_param(control_ring, bool, 0644); + /* Provide an option to disable split event channels at load time as * event channels are limited resource. Split event channels are * enabled by default. diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index a5439c130130..9801b8d10239 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -755,10 +755,12 @@ static void connect(struct backend_info *be) xen_register_watchers(dev, be->vif); read_xenbus_vif_flags(be); - err = connect_ctrl_ring(be); - if (err) { - xenbus_dev_fatal(dev, err, "connecting control ring"); - return; + if (be->ctrl_ring_enabled) { + err = connect_ctrl_ring(be); + if (err) { + xenbus_dev_fatal(dev, err, "connecting control ring"); + return; + } } /* Use the number of queues requested by the frontend */ @@ -1123,11 +1125,14 @@ static int netback_probe(struct xenbus_device *dev, if (err) pr_debug("Error writing multi-queue-max-queues\n"); - err = xenbus_printf(XBT_NIL, dev->nodename, - "feature-ctrl-ring", - "%u", true); - if (err) - pr_debug("Error writing feature-ctrl-ring\n"); + be->ctrl_ring_enabled = READ_ONCE(control_ring); + if (be->ctrl_ring_enabled) { + err = xenbus_printf(XBT_NIL, dev->nodename, + "feature-ctrl-ring", + "%u", true); + if (err) + pr_debug("Error writing feature-ctrl-ring\n"); + } backend_switch_state(be, XenbusStateInitWait); -- 2.23.3 From xen-devel-bounces@lists.xenproject.org Thu Mar 11 23:00:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 11 Mar 2021 23:00:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96758.183403 (Exim 4.92) (envelope-from ) id 1lKUId-0001CV-Aw; Thu, 11 Mar 2021 23:00:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96758.183403; Thu, 11 Mar 2021 23:00:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKUId-0001CO-6v; Thu, 11 Mar 2021 23:00:59 +0000 Received: by outflank-mailman (input) for mailman id 96758; Thu, 11 Mar 2021 23:00:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKUIc-0001CH-04 for xen-devel@lists.xenproject.org; Thu, 11 Mar 2021 23:00:58 +0000 Received: from smtp-fw-6001.amazon.com (unknown [52.95.48.154]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4cda18ce-dbdd-4ad9-aefb-6434ec5c7403; Thu, 11 Mar 2021 23:00:56 +0000 (UTC) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2b-a7fdc47a.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP; 11 Mar 2021 23:00:50 +0000 Received: from EX13D12EUA002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2b-a7fdc47a.us-west-2.amazon.com (Postfix) with ESMTPS id 9067DC09A4; Thu, 11 Mar 2021 23:00:48 +0000 (UTC) Received: from dev-dsk-andyhsu-1c-d6833dcf.eu-west-1.amazon.com (10.43.161.87) by EX13D12EUA002.ant.amazon.com (10.43.165.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 11 Mar 2021 23:00:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 4cda18ce-dbdd-4ad9-aefb-6434ec5c7403 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1615503657; x=1647039657; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=EelXUHyPTnNZzAoNgrkrCTVUBcXgQAjuKcfSXbijb4s=; b=Vg9ZTU4KiF+zOsfP4FyrInY6PuG5KmLDMKbuBULHYe33poF5y8U74FZi P7gEAEXGePBU8qM1rt172viMi/j+4sPaxam7rlRO7S+B6/RtnykZtxRtV HJV0TthvoxwTFy+7GzZIwMW3ZWHynYJAXGuY3LAZBAC6u8o6tTAhefr61 8=; IronPort-HdrOrdr: A9a23:qg3et6sX97996S7pax9t1/hP7skDyNV00zAX/kB9WHVpW+az/v rAoN0w0xjohDENHEw6kdebN6WaBV/a/5h54Y4eVI3SOTXOkm2uMY1k8M/e0yTtcheOktJ1+K 98f8FFaeHYIkN9ia/BjTWQN/YF7J25/LuzheHYpk0dLz1CT6179Q92BkK6PyRNJDVuPIE0Hp aQ6s1Mq1ObCA0qR/+2DHUEQOTPzuej/PmNXTc9GxUl5AOS5AnH1JfGFXGjsis2YndkxLcv9n X9iArp5qmvmOHT8G6760bjq7BfmN7s0bJ4da+xo/lQDC7thAaubJlgXLPHnAldmpDJ1GoX X-IronPort-AV: E=Sophos;i="5.81,241,1610409600"; d="scan'208";a="98053995" From: ChiaHao Hsu To: CC: , , , , , Subject: [net-next 2/2] xen-netback: add module parameter to disable dynamic multicast control Date: Thu, 11 Mar 2021 23:00:35 +0000 Message-ID: <20210311230035.24450-1-andyhsu@amazon.com> X-Mailer: git-send-email 2.23.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.43.161.87] X-ClientProxiedBy: EX13D05UWC004.ant.amazon.com (10.43.162.223) To EX13D12EUA002.ant.amazon.com (10.43.165.103) Precedence: Bulk In order to support live migration of guests between kernels that do and do not support 'feature-dynamic-multicast-control', we add a module parameter that allows the feature to be disabled at run time, instead of using hardcode value. The default value is enable. Signed-off-by: ChiaHao Hsu --- drivers/net/xen-netback/common.h | 1 + drivers/net/xen-netback/netback.c | 7 +++++++ drivers/net/xen-netback/xenbus.c | 14 ++++++++------ 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h index bfb7a3054917..c166ebb5a81f 100644 --- a/drivers/net/xen-netback/common.h +++ b/drivers/net/xen-netback/common.h @@ -415,6 +415,7 @@ static inline pending_ring_idx_t nr_pending_reqs(struct xenvif_queue *queue) irqreturn_t xenvif_interrupt(int irq, void *dev_id); extern bool control_ring; +extern bool dynamic_multicast_control; extern bool separate_tx_rx_irq; extern bool provides_xdp_headroom; diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index a119ae673862..d369428ea5bb 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -54,6 +54,13 @@ bool control_ring = true; module_param(control_ring, bool, 0644); +/* Provide an option to extend multicast control protocol. This allows + * request-multicast-control to be set by the frontend at any time, + * the backend will watch the value and re-sample on watch events. + */ +bool dynamic_multicast_control = true; +module_param(dynamic_multicast_control, bool, 0644); + /* Provide an option to disable split event channels at load time as * event channels are limited resource. Split event channels are * enabled by default. diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 9801b8d10239..a7f487289bec 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -1094,12 +1094,14 @@ static int netback_probe(struct xenbus_device *dev, goto abort_transaction; } - err = xenbus_printf(xbt, dev->nodename, - "feature-dynamic-multicast-control", - "%d", 1); - if (err) { - message = "writing feature-dynamic-multicast-control"; - goto abort_transaction; + if (dynamic_multicast_control) { + err = xenbus_printf(xbt, dev->nodename, + "feature-dynamic-multicast-control", + "%d", 1); + if (err) { + message = "writing feature-dynamic-multicast-control"; + goto abort_transaction; + } } err = xenbus_transaction_end(xbt, 0); -- 2.23.3 From xen-devel-bounces@lists.xenproject.org Fri Mar 12 00:39:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 00:39:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96766.183421 (Exim 4.92) (envelope-from ) id 1lKVpF-0002X0-0Q; Fri, 12 Mar 2021 00:38:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96766.183421; Fri, 12 Mar 2021 00:38:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKVpE-0002Wt-TY; Fri, 12 Mar 2021 00:38:44 +0000 Received: by outflank-mailman (input) for mailman id 96766; Fri, 12 Mar 2021 00:38:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKVpC-0002Wo-UN for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 00:38:42 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9ee21236-2a60-4521-aa1a-22feede08581; Fri, 12 Mar 2021 00:38:41 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id EEE9E64F8E; Fri, 12 Mar 2021 00:38:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ee21236-2a60-4521-aa1a-22feede08581 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615509521; bh=LxhJQNmeTlbV2mKTliu09mr/7q9XmffjSSgUB5VRJfk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Wto0DKzf3jAwwj8OK7fePvU1NBXf1RyJ2ZP5uSTHIf/ZxNljCWtfP9c8Bs/HcYgKY rm1XeybdlQ50Ip1QLR6m2KKCuFbKH2a/MHmsSy5PK/EbphhcDys1t5YYFj98JhcPOc qd4fNHzWqrvZNkL/90KxkedECuwfuvDZdJhLfcIqKbAkaZaX1pMGE1i0UmO21crlUA 0vDl6yGiTTY+JdzydE/pY9Ev2FGVpzcpAO7M4yk1xd+b51x7diiO5QaUmYWCYjQJdz ozg2vmMSoc1LSU0+9bBclwCa4qpk01GPWh85yDTg3ar7CRnfzJbZK1gJldFXINBSRA tS0JQC0V/kp+w== Date: Thu, 11 Mar 2021 16:38:33 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Rahul Singh cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH 0/5] xen/arm: smmuv1: Fix stream match conflict issue In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1376348301-1615509521=:18926" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1376348301-1615509521=:18926 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 9 Mar 2021, Rahul Singh wrote: > This patch is the work to fix the stream match conflict issue when two devices > have the same stream-id. > > Approach taken is to merge the below commit from Linux driver to fix the > issue. > > 1. "iommu/arm-smmu: Handle stream IDs more dynamically" > commit 21174240e4f4439bb8ed6c116cdbdc03eba2126e > 2. "iommu/arm-smmu: Consolidate stream map entry state" > commit 1f3d5ca43019bff1105838712d55be087d93c0da > 3. "iommu/arm-smmu: Keep track of S2CR state" > commit 8e8b203eabd8b9e96d02d6339e4abce3e5a7ea4b > 4. "iommu/arm-smmu: Add a stream map entry iterator" > commit d3097e39302083d58922a3d1032d7d59a63d263d > 5. "iommu/arm-smmu: Intelligent SMR allocation" > commit 588888a7399db352d2b1a41c9d5b3bf0fd482390 > > Rahul Singh (5): > xen/arm: smmuv1: Handle stream IDs more dynamically > xen/arm: smmuv1: Consolidate stream map entry state > xen/arm: smmuv1: Keep track of S2CR state > xen/arm: smmuv1: Add a stream map entry iterator > xen/arm: smmuv1: Intelligent SMR allocation > > xen/drivers/passthrough/arm/smmu.c | 423 ++++++++++++++++++----------- > 1 file changed, 262 insertions(+), 161 deletions(-) I didn't closely review the changes but I made sure that all patches build and I also compared each patch with the original commit in Linux: all changes correspond correctly. For the whole series: Acked-by: Stefano Stabellini --8323329-1376348301-1615509521=:18926-- From xen-devel-bounces@lists.xenproject.org Fri Mar 12 00:59:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 00:59:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96769.183433 (Exim 4.92) (envelope-from ) id 1lKW9c-0004Zm-PS; Fri, 12 Mar 2021 00:59:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96769.183433; Fri, 12 Mar 2021 00:59:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKW9c-0004Zf-ML; Fri, 12 Mar 2021 00:59:48 +0000 Received: by outflank-mailman (input) for mailman id 96769; Fri, 12 Mar 2021 00:59:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKW9c-0004ZX-0z; Fri, 12 Mar 2021 00:59:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKW9a-0001bq-Pj; Fri, 12 Mar 2021 00:59:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKW9a-00060p-Hb; Fri, 12 Mar 2021 00:59:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKW9a-0000Nc-H5; Fri, 12 Mar 2021 00:59:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TxapSiAXs5fUHAAasv8HKEf+83P3nWurSSllrSoyHRM=; b=DeRe7CRJJQMk3yyRuOQbEMU42H FApXcrKOHEB0pBcYemWh4xILRjJ4JF6+TynSOPnyfe5aHKtJYlofYy+YnXV38LHo5FI8xhPi4iOM3 lsaBF8iCHyr7kW3faAKxWBPzxPtkbb3fB87DDMg4SLRKhDO5f508wNNHpVzd6jN/4aVE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159937: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:regression xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=935e0836710ce8cab584155b2844cea8497a5159 X-Osstest-Versions-That: xen=e4bdcc8aef6707027168ea29caed844a7da67b4d From: osstest service owner Date: Fri, 12 Mar 2021 00:59:46 +0000 flight 159937 xen-unstable real [real] flight 159951 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159937/ http://logs.test-lab.xenproject.org/osstest/logs/159951/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 159920 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 159920 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159920 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159920 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159920 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159920 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159920 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159920 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159920 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159920 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159920 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159920 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159920 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 935e0836710ce8cab584155b2844cea8497a5159 baseline version: xen e4bdcc8aef6707027168ea29caed844a7da67b4d Last test of basis 159920 2021-03-10 20:37:43 Z 1 days Testing same since 159937 2021-03-11 13:07:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Elliott Mitchell Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 935e0836710ce8cab584155b2844cea8497a5159 Author: Elliott Mitchell Date: Mon Mar 8 05:36:18 2021 -0800 xen/public: replace typeof() with __typeof__() typeof() is available in Xen's build environment, which uses Xen's compiler. As these headers are public, they need strict standards conformance. Only __typeof__() is officially standardized. A compiler in standards conformance mode should report: warning: implicit declaration of function 'typeof' is invalid in C99 [-Wimplicit-function-declaration] (this has been observed with FreeBSD's kernel build environment) Based-on-patch-by: Julien Grall , Sun Oct 4 20:33:04 2015 +0100 Signed-off-by: Elliott Mitchell Acked-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Juergen Gross Release-Acked-by: Ian Jackson commit 1fff444679a1ffa67d0bf55744b80555ab58f9f8 Author: Julien Grall Date: Fri Mar 5 12:40:03 2021 +0000 tools/xenstore: Check the format printf for xprintf() and barf{,_perror}() Allow GCC to analyze the format printf for xprintf() and barf{,_perror}(). Take the opportunity to define __noreturn to make the prototype for barf{,_perror})() easier to read. Also document why 'extern' is used for xprintf(). Signed-off-by: Julien Grall Reviewed-by: Juergen Gross Reviewed-by: Ian Jackson Release-Acked-by: Ian Jackson commit 209b309e33ebbf8674a9d84fd73cce7f1e70e7eb Author: Julien Grall Date: Fri Mar 5 12:40:02 2021 +0000 tools/xenstore: Consolidate PRINTF_ATTRIBUTE() in utils.h At the moment PRINTF_ATTRIBUTE() is defined in two places: - tdb.h: Defined as a NOP - talloc.h: Defined as a NOP for GCC older than 3.0 otherwise will add the attribute to check the printf format Xen requires to build with minimum GCC 4.1 and we want to check the printf format for all the printf-like functions. Only implement PRINTF_ATTRIBUTE() once in utils.h and drop the conditional check for GCC < 3.0. Signed-off-by: Julien Grall Reviewed-by: Juergen Gross Release-Acked-by: Ian Jackson (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Mar 12 02:59:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 02:59:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96791.183487 (Exim 4.92) (envelope-from ) id 1lKY13-0001uc-K2; Fri, 12 Mar 2021 02:59:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96791.183487; Fri, 12 Mar 2021 02:59:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKY13-0001uU-Da; Fri, 12 Mar 2021 02:59:05 +0000 Received: by outflank-mailman (input) for mailman id 96791; Fri, 12 Mar 2021 02:59:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKY12-0001uM-TI; Fri, 12 Mar 2021 02:59:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKY12-0005TA-Is; Fri, 12 Mar 2021 02:59:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKY12-0003pH-8u; Fri, 12 Mar 2021 02:59:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKY12-0004Mi-8O; Fri, 12 Mar 2021 02:59:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8rKV6TNPAUwR/gKvgbWUu844YMev25a2d2VQBz+fHek=; b=GjbNvwTXwkkBshxxeQRi6WVe4s yebfVnBEPavu8tI/7G0goWsyV5DhC9mn1QmpDZZlkqc9+L4LgOhsf5825mPDLPoBt5CuplVx4FpYe 9XfYS4jfjEdqZn+K3DD5dmlY/6pftfoI0aKB4YM6+4/s2P01KvCx/gpEeeeqY6uwLyLw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 159939: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=ce615a08404c821bcb3c6f358b8f34307bfe30c9 X-Osstest-Versions-That: linux=84d5d3c9d3fbcee10bc16d3a3316af9a924c91c6 From: osstest service owner Date: Fri, 12 Mar 2021 02:59:04 +0000 flight 159939 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/159939/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159890 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159890 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159890 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159890 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159890 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159890 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159890 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159890 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159890 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159890 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159890 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux ce615a08404c821bcb3c6f358b8f34307bfe30c9 baseline version: linux 84d5d3c9d3fbcee10bc16d3a3316af9a924c91c6 Last test of basis 159890 2021-03-09 10:39:27 Z 2 days Testing same since 159939 2021-03-11 13:40:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexander Lobakin Andrey Ryabinin AngeloGioacchino Del Regno Aswath Govindraju Bjorn Helgaas Bob Moore Chris Chiu Christoph Hellwig Daniel Lee Kruse David S. Miller Erik Kaneda Ethan Warth Greg Kroah-Hartman Guenter Roeck Hans de Goede Hans Verkuil Hulk Robot Jason Self Jasper St. Pierre Jeffle Xu Jiri Kosina Jisheng Zhang Joerg Roedel Jon Hunter Julian Einwag Kalle Valo Linux Kernel Functional Testing Mark Brown Mauro Carvalho Chehab Mike Snitzer Pascal Terjan Pierre-Louis Bossart Rafael J. Wysocki Rob Clark Ross Schmidt Sasha Levin Shuah Khan Tsuchiya Yuto Ulf Hansson Will Deacon Wladimir J. van der Laan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 84d5d3c9d3fb..ce615a08404c ce615a08404c821bcb3c6f358b8f34307bfe30c9 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Fri Mar 12 04:03:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 04:03:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96810.183541 (Exim 4.92) (envelope-from ) id 1lKZ0u-0000Kq-4y; Fri, 12 Mar 2021 04:03:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96810.183541; Fri, 12 Mar 2021 04:03:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKZ0u-0000Kj-1p; Fri, 12 Mar 2021 04:03:00 +0000 Received: by outflank-mailman (input) for mailman id 96810; Fri, 12 Mar 2021 04:02:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKZ0s-0000Kb-UT; Fri, 12 Mar 2021 04:02:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKZ0s-0006b7-Oe; Fri, 12 Mar 2021 04:02:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKZ0s-0006iZ-GE; Fri, 12 Mar 2021 04:02:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKZ0s-0001K4-Fk; Fri, 12 Mar 2021 04:02:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xSvY+ijpGUi2lqCdkbhnqPnqoe3NVkEvAKxH80j0sPI=; b=vauHJ18wydATl9S4qOo52Qqn1G r8dj8D4yF95vtvYHyJ94SjOZMYJ2ivbBrnkhoUbIaKy/kMdkDpmF5azxpmhwHpnN0SNvBuvzvHguE uVIPkJbsaxkpZmYnvDVQRHeKszqIFi1VOf6En+7f+uzr83zePBwxosF4RUOfa87ZJxTA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [seabios test] 159942: tolerable FAIL - PUSHED X-Osstest-Failures: seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: seabios=b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee X-Osstest-Versions-That: seabios=ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e From: osstest service owner Date: Fri, 12 Mar 2021 04:02:58 +0000 flight 159942 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/159942/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 157762 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 157762 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 157762 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 157762 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 157762 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: seabios b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee baseline version: seabios ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e Last test of basis 157762 2020-12-21 16:10:48 Z 80 days Testing same since 159942 2021-03-11 16:39:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Stefan Ott Stefan Ott via SeaBIOS jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/seabios.git ef88eea..b0d61ec b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Mar 12 06:26:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 06:26:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96840.183625 (Exim 4.92) (envelope-from ) id 1lKbF8-0006Et-0w; Fri, 12 Mar 2021 06:25:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96840.183625; Fri, 12 Mar 2021 06:25:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKbF7-0006Em-Tz; Fri, 12 Mar 2021 06:25:49 +0000 Received: by outflank-mailman (input) for mailman id 96840; Fri, 12 Mar 2021 06:25:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKbF6-0006Eh-VD for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 06:25:49 +0000 Received: from mga09.intel.com (unknown [134.134.136.24]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d8967374-424a-45a6-a1ad-f25dc4c53d48; Fri, 12 Mar 2021 06:25:44 +0000 (UTC) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 22:25:42 -0800 Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga001.fm.intel.com with ESMTP; 11 Mar 2021 22:25:41 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 11 Mar 2021 22:25:41 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 11 Mar 2021 22:25:41 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 11 Mar 2021 22:25:40 -0800 Received: from BN6PR11MB1875.namprd11.prod.outlook.com (2603:10b6:404:104::11) by BN6PR11MB1347.namprd11.prod.outlook.com (2603:10b6:404:48::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.30; Fri, 12 Mar 2021 06:25:38 +0000 Received: from BN6PR11MB1875.namprd11.prod.outlook.com ([fe80::90ec:1b70:5912:9849]) by BN6PR11MB1875.namprd11.prod.outlook.com ([fe80::90ec:1b70:5912:9849%4]) with mapi id 15.20.3912.031; Fri, 12 Mar 2021 06:25:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8967374-424a-45a6-a1ad-f25dc4c53d48 IronPort-SDR: di2E1+yC/0DLZUGkezQ0Qano0Ojl4fyVuyElNTuw6JntGfRhJAfOv9fK68CT4REYKzHv/krmyz krY4LvKNkATQ== X-IronPort-AV: E=McAfee;i="6000,8403,9920"; a="188886033" X-IronPort-AV: E=Sophos;i="5.81,242,1610438400"; d="scan'208";a="188886033" IronPort-SDR: Ul9tqMKO6Uh0dXTGItiTkoajSqAUo/k0qgSgKjlbIiL3vctbHH7WHpi9la/BZUGb/DN+ZPb6jo MkbBj7pMyl9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,242,1610438400"; d="scan'208";a="510242323" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TG1CYCsWoqWx4W+5sodH2RZcu5YrBm0FrZX8D/vauewna72GJESAHCXlwAUrulWwPRRwOlK+iRc7wljNq1SPopLP4eTedyrQRS6j2DKnWfLVzElBQis4kL8iMoLsnds4TbangbnfTvwDfJhlt59qMgf3qP/SeN+YcdpzdRqnDKpnfizuRVHW0zsScG641zzIUvb6rmdeDS8PgO7JMKbYuoe2k0yDO01wPmz3q2B52yIeyXnUre+ygNIMnltB02FE/SOM3nuZjxNsxIT1GEiCJpJMFKtUb2a/hX0YR/0L3br4wbuCAR+49oNrU3bGjIM++FlfjyvANoXAoFtkyAWldA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e9HUyGMVAaErYwgk8Eg0wsBBKDa4EvmCSoBMvVMyns0=; b=eSs3N78icMg+XqU0GfC+fFKtc5hdZT7pcKcblSgaLg6m4uJfHFV14zlni86Cqgyfrf78wjoCRyziybSD6vlTKg7OEcxZNUNqkDSCJAxhskZCtpBlee6+Z6mQXL6/VF+Hkg9kX1LDWIt3zvc0RMtuKNAXOevpB7g8C1Ie40rayyXcn0FWXBbUfVBbXvcSt79yNa/Lpjl4ABfX9no+g0ot2Ve6M3YXSFQqbtjEZbV4NQY26/swLb5ZSDMSZyerpIt28cXEN1IWMLVS9EvyYihsxoNoBvvVBk1BlmR36bcfwuBwKJhYGL6ES+lx7eKUtCj9Z0xwaZBWB1X61Zu8RenPTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e9HUyGMVAaErYwgk8Eg0wsBBKDa4EvmCSoBMvVMyns0=; b=wSx48FYqm29igGHaLZ6O37A1caI7cMExPoZjb8X6rlQwfGZDvEPThCQZICnDdVrGRHuklsS9yLaYQAd3hKrOOq5o7602Wv/LEPt7zPMjg3SJmurE9no+rcOFkAYHGGSLbDqf577t+wO4U5Vonlb43pwHBeSxZ9P9nX5jyuH48rQ= From: "Tian, Kevin" To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Ian Jackson , Wei Liu , "Cooper, Andrew" , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Anthony PERARD , Christian Lindig , David Scott , "Nakajima, Jun" , Boris Ostrovsky Subject: RE: [PATCH v5 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection Thread-Topic: [PATCH v5 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection Thread-Index: AQHXFl1E17qE/GwUv0S+Qqy38ZKKgKp/5CwA Date: Fri, 12 Mar 2021 06:25:38 +0000 Message-ID: References: <20210311095918.40490-1-roger.pau@citrix.com> In-Reply-To: <20210311095918.40490-1-roger.pau@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3f4262fd-2636-4ec4-f7c8-08d8e51fa719 x-ms-traffictypediagnostic: BN6PR11MB1347: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SZ+rK6R6YT7dtHHXtMAlfFXXoMzggyHkNMCbaXB4xEVLXuttvdkoo2YyKyDbZ/cAxySyrfsY+HrUi0swB0r+Y/wbrqiNoIisx7CCaHzQYc4a4HMARZEPmfzy5W2sJMZkuPXIoxPvLzc1tWkHXzeWovbEn4l6SQ9m8qhGkyZeVRped6biIGp0RQVXlq8pIryUofjREnJjGBs5ReIz1P+bAekH3gqfJ6BmFUBGhp6p8Ds703uJxwLj3Rsu1wCy5LUnYIA4MhfXPdXWQST+T3FX4YY1LJE9u/huEktMLiyntdfo+w3nv6vQWHjuILDb5zgMVbszctnhqQnYw6GF7SZcKUh9/hF+6SNPOALrYGarTo97Nxoeqr+0bUUPfwveGyzsYfOSJB2pPkfPDuMHGETu9S64id8u0hmEOzY9t/L3evSXlLP8ulVzNx3hjiFFalxHMR9hkddC9wTNfdaQ/ObUaWCjlbeGodo8ruyu3ntpoLq7RT4fq8GNsuIozyr0gb5+zLfmU3sYwqRQCNkZmaRVZA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1875.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(396003)(376002)(39860400002)(346002)(136003)(316002)(4326008)(54906003)(6506007)(7696005)(64756008)(2906002)(83380400001)(30864003)(110136005)(52536014)(76116006)(5660300002)(9686003)(66476007)(55016002)(86362001)(66446008)(8936002)(7416002)(186003)(66946007)(66556008)(8676002)(71200400001)(478600001)(26005)(33656002)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?utf-8?B?NldCd3o5UkpsTG9hVHcyazdKamE3dWZBbVBGWk51UGE5OGVoYkFzRm9JNnFD?= =?utf-8?B?WXRVU0pmZmdwc0VIY0ttOHY3RVRxVWYydmxLNVBTbUgyWGY3eTdkanN4THdH?= =?utf-8?B?aEtVNDJzNHR3NlpMeHMvdXMwQjdYbkpmK3R1UzBXZ3pOZnJYK2lFNTFtMTlN?= =?utf-8?B?RStXYUtLK2hmOWxJMWJqR2l5Q0hYemNOVnZVdTRnT01HRkszV01TOEJ5cGdP?= =?utf-8?B?UnRCYlpFVTltWlFQN0kzZGpCbmZCQjd6TzJqMFFYaTJPalB4Z0NFTkpnc2lr?= =?utf-8?B?bGV1RXcwZTM0amVrTlBRa0ZqcmxoTTcvSGt0SjVmbXRLNmIwQnBZdkhXL1lI?= =?utf-8?B?WGJtS1RwWTd2UGJrQkdMaUd5bDJVL1dGS1NpYTRjcFRVUTdXUVIzWXY1VTB3?= =?utf-8?B?by9UUGtMK1ZyM3V1WDBrRjBPbHR3VjlNdVJIYUhWRFBFUndqc1JMb2Jka3Bx?= =?utf-8?B?WW5LMmU5WTMrdWlNY3d2amhRVjZMcWZOa0xickFOdVVnRk9keXM5Nnd4OEgr?= =?utf-8?B?LyszNHZWODc4ejFRMnhzVjNLYllndUNMMVJtZmZpMEM1cVpaMzF2YWpwS0Rq?= =?utf-8?B?THIzQlgwT0dPMThUS0IvYk1nUTJSbjZuaU0yZHZFc0doNTM1eFErMXZEeis3?= =?utf-8?B?M3FtQTd4Mk5lZXNzbXhhNkVmaVJFNnZkNG55L0l5TmE4MFVMYXNhSFhQd09I?= =?utf-8?B?TDZCWWUvcTk5NnZ4SFA4UFlNRDE3YkpjK1Z4bmw5VUNlK09pUEI0VDZ2WUpm?= =?utf-8?B?MjdUbTltQXEzeVBUc1I3a2FjNXN1ZVA2RXNrc29kYVk2d01xWHViMVBvVnky?= =?utf-8?B?MEtqeFFyRGp2TkZ3SFV5Rml4YmtkYWhIeXZRT0QyL2dqRm5TcU9lVm5heGZ4?= =?utf-8?B?VFNwWTZUSXVZWWd0dUhsYW9xVkMzcnp4OCtkYkJBeXQwVlNucVluTDI2NVpH?= =?utf-8?B?eVhoYUxBMVVQdkdtTSt6S0Z2TDIxbFQwZDgydHJONjRtZklqTFBYY3FLSm8x?= =?utf-8?B?ZXFiQXFoajlOSmJDQ3Y2NmNsck8rT1FvTlU1cXNLVHF5UEpNMCt3SVVPYUta?= =?utf-8?B?OUhBc3JtQkp0a2tFZzNrak1jRy9ScGhNT2ZBVE1QWi8vekFiOU9xSDZZN3Fz?= =?utf-8?B?d3hGT29ac1FsWEQ3MndVcFJ6czJEeXFyOXlhdmtpUExadTdkY0w2SHdMUWdQ?= =?utf-8?B?czN3NXdid0ZZZXF3amRDK1ZPVWp4NVNwTGFFK0dab1d1c20zZUlyZllPQTFn?= =?utf-8?B?Z0EzOElMV29SYWQ4NGZDY05iNUFGcEUveGhJUE92ZFdwQzBvdVUvNnduVmhR?= =?utf-8?B?alN2QWtRMlJqcTdXM1N0bktuUGRRSEpidWlWMzRLWERkeVFza2oxbnFXWCtm?= =?utf-8?B?d1lLTEZFeHN0OFpzaE50cjZHMWNmQjk0RkJ4Rmd1U3MrTFJoSERUZUxQNkhR?= =?utf-8?B?MmErSzBQc0pzditUcGlrYVFOb2hjRmNIY1NmQXpxWklOMjlKL0FRazU1TVhs?= =?utf-8?B?SkZzdXJCeVdRMC9FYnRQMkpRN0czdGhYUU5HZkhsZUtYc1NFRmVQY3dwOG1p?= =?utf-8?B?Y2xnRThCNXozMzhFU042MFVERVRsN05aL1pTcGZMaEN4SkdCOXl0QkZUbjFB?= =?utf-8?B?S0IzZUZQVk5rdlA0YmtJeG9GTmU0eWtTeTdDRy9IS3RQc0FQUGVJb244VlRE?= =?utf-8?B?dnFBd3lVc2ZNUFZLV0VsTkxxV2dQVkR5TG8veTJocE9ITkNCWnpXWWtORnM5?= =?utf-8?Q?LcdgIDhgnOK1LFCCkPSNvcTflOif35DvzWS9Rdr?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1875.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f4262fd-2636-4ec4-f7c8-08d8e51fa719 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2021 06:25:38.1589 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vIkJiP0fs+QRFMigtAH8KosPHTgmk8xdaXksg5Ook/SBS3/CZlUdBz+tkOcrF9siWcYVhrrccxPfLo/6/UlYvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1347 X-OriginatorOrg: intel.com PiBGcm9tOiBSb2dlciBQYXUgTW9ubmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiBTZW50OiBU aHVyc2RheSwgTWFyY2ggMTEsIDIwMjEgNTo1OSBQTQ0KPiANCj4gSW50cm9kdWNlIGFuIG9wdGlv biB0byBhbGxvdyBzZWxlY3RpbmcgYSBiZWhhdmlvciBzaW1pbGFyIHRvIHRoZSBwcmUNCj4gWGVu IDQuMTUgb25lIGZvciBhY2Nlc3NlcyB0byBNU1JzIG5vdCBleHBsaWNpdGx5IGhhbmRsZWQuIFNp bmNlIGNvbW1pdA0KPiA4NGU4NDhmZDdhMTYyZjY2OSBhbmQgMzIyZWM3Yzg5ZjY2NDBlIGFjY2Vz c2VzIHRvIE1TUnMgbm90IGV4cGxpY2l0bHkNCj4gaGFuZGxlZCBieSBYZW4gcmVzdWx0IGluIHRo ZSBpbmplY3Rpb24gb2YgYSAjR1AgdG8gdGhlIGd1ZXN0LiBUaGlzDQo+IGlzIGEgYmVoYXZpb3Ig Y2hhbmdlIHNpbmNlIHByZXZpb3VzbHkgYSAjR1Agd2FzIG9ubHkgaW5qZWN0ZWQgaWYNCj4gYWNj ZXNzaW5nIHRoZSBNU1Igb24gdGhlIHJlYWwgaGFyZHdhcmUgd291bGQgYWxzbyB0cmlnZ2VyIGEg I0dQLCBvciBpZg0KPiB0aGUgYXR0ZW1wdGVkIHRvIGJlIHNldCBiaXRzIHdvdWxkbid0IG1hdGNo IHRoZSBoYXJkd2FyZSB2YWx1ZXMgKGZvcg0KPiBQVikuIFRoZSByZWFzb25zIGZvciBub3QgbGVh a2luZyBoYXJkd2FyZSBNU1IgdmFsdWVzIGFuZCBpbmplY3RpbmcgYQ0KPiAjR1AgYXJlIGZ1bGx5 IHZhbGlkLCBzbyB0aGUgc29sdXRpb24gcHJvcG9zZWQgaGVyZSBzaG91bGQgYmUNCj4gY29uc2lk ZXJlZCBhIHRlbXBvcmFyeSB3b3JrYXJvdW5kIHVudGlsIGFsbCB0aGUgcmVxdWlyZWQgTVNScyBh cmUNCj4gcHJvcGVybHkgaGFuZGxlZC4NCj4gDQo+IFRoaXMgc2VlbXMgdG8gYmUgcHJvYmxlbWF0 aWMgZm9yIHNvbWUgZ3Vlc3RzLCBzbyBpbnRyb2R1Y2UgYW4gb3B0aW9uDQo+IHRvIGZhbGxiYWNr IHRvIHRoaXMga2luZCBvZiBsZWdhY3kgYmVoYXZpb3Igd2l0aG91dCBsZWFraW5nIHRoZQ0KPiB1 bmRlcmx5aW5nIE1TUiB2YWx1ZXMgdG8gdGhlIGd1ZXN0Lg0KPiANCj4gV2hlbiB0aGUgb3B0aW9u IGlzIHNldCwgZm9yIGJvdGggUFYgYW5kIEhWTSBkb24ndCBpbmplY3QgYSAjR1AgdG8gdGhlDQo+ IGd1ZXN0IG9uIE1TUiByZWFkIGlmIHJlYWRpbmcgdGhlIHVuZGVybHlpbmcgTVNSIGRvZXNuJ3Qg cmVzdWx0IGluIGENCj4gI0dQLCBkbyB0aGUgc2FtZSBmb3Igd3JpdGVzIGFuZCBzaW1wbHkgZGlz Y2FyZCB0aGUgdmFsdWUgdG8gYmUgd3JpdHRlbg0KPiBvbiB0aGF0IGNhc2UuDQo+IA0KPiBOb3Rl IHRoYXQgZm9yIGd1ZXN0cyByZXN0b3JlZCBvciBtaWdyYXRlZCBmcm9tIHByZXZpb3VzIFhlbiB2 ZXJzaW9ucw0KPiB0aGUgb3B0aW9uIGlzIGVuYWJsZWQgYnkgZGVmYXVsdCwgaW4gb3JkZXIgdG8g a2VlcCBhIGNvbXBhdGlibGUNCj4gTVNSIGJlaGF2aW9yLiBTdWNoIGNvbXBhdGliaWxpdHkgaXMg ZG9uZSBhdCB0aGUgbGlieGwgbGF5ZXIsIHRvIGF2b2lkDQo+IGhpZ2hlci1sZXZlbCB0b29sc3Rh Y2tzIGZyb20gaGF2aW5nIHRvIGtub3cgdGhlIGRldGFpbHMgYWJvdXQgdGhpcyBmbGFnLg0KPiAN Cj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+ DQo+IEFja2VkLWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5j b20+DQo+IFJldmlld2VkLWJ5OiBJYW4gSmFja3NvbiA8aXdqQHhlbnByb2plY3Qub3JnPg0KPiBS ZXZpZXdlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4g UmVsZWFzZS1BY2tlZC1ieTogSWFuIEphY2tzb24gPGl3akB4ZW5wcm9qZWN0Lm9yZz4NCg0KUmV2 aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPg0KDQo+IC0tLQ0KPiBD YzogQm9yaXMgT3N0cm92c2t5IDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT4NCj4gLS0tDQo+ IEJvcmlzLCBjb3VsZCB5b3UgcGxlYXNlIHRlc3Qgd2l0aCBTb2xhcmlzIHRvIHNlZSBpZiB0aGlz IGZpeGVzIHRoZQ0KPiBpc3N1ZT8NCj4gDQo+IEZyb20gYSByZWxlYXNlIFBvViB0aGVyZSBhcmUg cmlza3Mgb2YgdGFraW5nIHRoaXMgcGF0Y2gsIGFzIGl0IHRvdWNoZXMNCj4gc2V2ZXJhbCBkaWZm ZXJlbnQgYXJlYXMuIFNvIGl0IGNvdWxkIGJyZWFrIE1TUiBoYW5kbGluZyBvciBkb21haW4NCj4g Y3JlYXRpb24uIEkgdGhpbmsgaG93ZXZlciB3ZSB3b3VsZCBiZSBhYmxlIHRvIHNwb3Qgc3VjaCBi cmVha2FnZXMgaW4NCj4gb3NzdGVzdC4NCj4gDQo+IE5vdCB0YWtpbmcgdGhlIHBhdGNoIHdvdWxk IHB1dCB1cyBpbiBhbiBhd2t3YXJkIHBvc2l0aW9uIGlmIHBlb3BsZQ0KPiBtaWdyYXRpbmcgZnJv bSA8IDQuMTUgZmluZCB0aGVpciBndWVzdHMgbm8gbG9uZ2VyIGJvb3QgKG9yIGNyYXNoIG9uDQo+ IG1pZ3JhdGlvbikgb24gbmV3ZXIgWGVuIHZlcnNpb25zLCBoZW5jZSBJIHRoaW5rIHdlIG5lZWQg dG8gYWNjZXB0IHRoZQ0KPiByaXNrLg0KPiAtLS0NCj4gQ2hhbmdlcyBzaW5jZSB2NDoNCj4gIC0g Rml4IHhsLmNmZyBtYW4gcGFnZS4NCj4gDQo+IENoYW5nZXMgc2luY2UgdjM6DQo+ICAtIFNsaWdo dGx5IGFkanVzdCBjb21taXQgbWVzc2FnZS4NCj4gIC0gQ2hhbmdlIHRoZSBkZXNjcmlwdGlvbiBv ZiB0aGUgb3B0aW9uLg0KPiAgLSBzL2RvbWFpbl9mbGFncy9taXNjX2ZsYWdzLy4NCj4gIC0gQWRq dXN0IHNldHRpbmcgb2YgbWlzY19mbGFncyBpbiBjcmVhdGVfZG9tMC4NCj4gDQo+IENoYW5nZXMg c2luY2UgdjI6DQo+ICAtIEFwcGx5IHRoZSBvcHRpb24gdG8gYm90aCBIVk0gYW5kIFBWIGd1ZXN0 Lg0KPiAgLSBIYW5kbGUgYm90aCByZWFkcyBhbmQgd3JpdGVzLg0KPiAgLSBSZW5hbWUgdG8gbXNy X3JlbGF4ZWQuDQo+ICAtIEludHJvZHVjZSBhIFhlbiBjb21tbmFkIGxpbmUgb3B0aW9uIHRvIHNl dCBpdCBmb3IgZG9tMC4NCj4gIC0gU2V0IGl0IHVuY29uZGl0aW9uYWxseSBmb3IgZ3Vlc3RzIGJl aW5nIHJlc3RvcmVkIG9yIG1pZ3JhdGVkIGZyb20NCj4gICAgcHJldmlvdXMgWGVuIHZlcnNpb25z Lg0KPiAgLSBQcm92aWRlIHRoZSBvcHRpb24gdG8gZG9tMC4NCj4gIC0gQXR0ZW1wdCBhdCBhZGRp bmcgdGhlIG9jYW1sIGhlbHBlcnMgKGJ1aWxkIHRlc3RlZCBvbmx5KS4NCj4gDQo+IENoYW5nZXMg c2luY2UgdjE6DQo+ICAtIE9ubHkgYXBwbHkgdGhlIG9wdGlvbiB0byBIVk0gZ3Vlc3RzLg0KPiAg LSBPbmx5IGFwcGx5IHRoZSBzcGVjaWFsIGhhbmRsaW5nIHRvIE1TUiByZWFkcy4NCj4gIC0gU2Fu aXRpemUgdGhlIG5ld2x5IGludHJvZHVjZWQgZmxhZ3MgZmllbGQuDQo+ICAtIFByaW50IGEgd2Fy bmluZyBtZXNzYWdlIHdoZW4gdGhlIG9wdGlvbiBpcyB1c2VkLg0KPiAtLS0NCj4gIGRvY3MvbWFu L3hsLmNmZy41LnBvZC5pbiAgICAgICAgICAgIHwgMTQgKysrKysrKysrKysrKysNCj4gIGRvY3Mv bWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRvYyAgIHwgMTQgKysrKysrKysrKysrKy0NCj4gIHRv b2xzL2luY2x1ZGUvbGlieGwuaCAgICAgICAgICAgICAgIHwgIDcgKysrKysrKw0KPiAgdG9vbHMv bGlicy9saWdodC9saWJ4bF9hcmNoLmggICAgICAgfCAgNSArKysrKw0KPiAgdG9vbHMvbGlicy9s aWdodC9saWJ4bF9hcm0uYyAgICAgICAgfCAgNiArKysrKysNCj4gIHRvb2xzL2xpYnMvbGlnaHQv bGlieGxfY3JlYXRlLmMgICAgIHwgIDcgKysrKysrKw0KPiAgdG9vbHMvbGlicy9saWdodC9saWJ4 bF9pbnRlcm5hbC5jICAgfCAgMyArKysNCj4gIHRvb2xzL2xpYnMvbGlnaHQvbGlieGxfdHlwZXMu aWRsICAgIHwgIDIgKysNCj4gIHRvb2xzL2xpYnMvbGlnaHQvbGlieGxfeDg2LmMgICAgICAgIHwg MjAgKysrKysrKysrKysrKysrKysrKysNCj4gIHRvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5t bCAgICAgIHwgIDQgKysrKw0KPiAgdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1saSAgICAg fCAgNCArKysrDQo+ICB0b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYyB8ICA5ICsr KysrKysrKw0KPiAgdG9vbHMveGwveGxfcGFyc2UuYyAgICAgICAgICAgICAgICAgfCAgNyArKysr KysrDQo+ICB4ZW4vYXJjaC94ODYvZG9tMF9idWlsZC5jICAgICAgICAgICB8ICAzICsrKw0KPiAg eGVuL2FyY2gveDg2L2RvbWFpbi5jICAgICAgICAgICAgICAgfCAgOSArKysrKysrKysNCj4gIHhl bi9hcmNoL3g4Ni9odm0vc3ZtL3N2bS5jICAgICAgICAgIHwgMTAgKysrKysrKysrKw0KPiAgeGVu L2FyY2gveDg2L2h2bS92bXgvdm14LmMgICAgICAgICAgfCAxMCArKysrKysrKysrDQo+ICB4ZW4v YXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmMgICAgICB8IDEwICsrKysrKysrKysNCj4gIHhlbi9h cmNoL3g4Ni9zZXR1cC5jICAgICAgICAgICAgICAgIHwgIDMgKysrDQo+ICB4ZW4vaW5jbHVkZS9h c20teDg2L2RvbWFpbi5oICAgICAgICB8ICAzICsrKw0KPiAgeGVuL2luY2x1ZGUvYXNtLXg4Ni9z ZXR1cC5oICAgICAgICAgfCAgMSArDQo+ICB4ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC14ODYveGVu LmggICB8ICA4ICsrKysrKysrDQo+ICAyMiBmaWxlcyBjaGFuZ2VkLCAxNTggaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RvY3MvbWFuL3hsLmNmZy41LnBv ZC5pbiBiL2RvY3MvbWFuL3hsLmNmZy41LnBvZC5pbg0KPiBpbmRleCAwNDAzNzRkY2Q2Li41NjM3 MGEzN2RiIDEwMDY0NA0KPiAtLS0gYS9kb2NzL21hbi94bC5jZmcuNS5wb2QuaW4NCj4gKysrIGIv ZG9jcy9tYW4veGwuY2ZnLjUucG9kLmluDQo+IEBAIC0yODYxLDYgKzI4NjEsMjAgQEAgTm8gTUNB IGNhcGFiaWxpdGllcyBpbiBhYm92ZSBsaXN0IGFyZSBlbmFibGVkLg0KPiANCj4gID1iYWNrDQo+ IA0KPiArPWl0ZW0gQjxtc3JfcmVsYXhlZD1CT09MRUFOPg0KPiArDQo+ICtUaGUgIm1zcl9yZWxh eGVkIiBib29sZWFuIGlzIGFuIGludGVyaW0gb3B0aW9uLCBhbmQgZGVmYXVsdHMgdG8gZmFsc2Uu DQo+ICsNCj4gK0luIFhlbiA0LjE1LCB0aGUgZGVmYXVsdCBiZWhhdmlvdXIgZm9yIHVuaGFuZGxl ZCBNU1JzIGhhcyBiZWVuIGNoYW5nZWQsDQo+ICt0byBhdm9pZCBsZWFraW5nIGhvc3QgZGF0YSBp bnRvIGd1ZXN0cywgYW5kIHRvIGF2b2lkIGJyZWFraW5nIGd1ZXN0DQo+ICtsb2dpYyB3aGljaCB1 c2VzICNHUCBwcm9iaW5nIHRvIGlkZW50aWZ5IHRoZSBhdmFpbGFiaWxpdHkgb2YgTVNScy4NCj4g Kw0KPiArSG93ZXZlciwgdGhpcyBuZXcgc3RyaWN0ZXIgYmVoYXZpb3VyIGhhcyB0aGUgcG9zc2li aWxpdHkgdG8gYnJlYWsNCj4gK2d1ZXN0cywgYW5kIGEgbW9yZSA0LjE0LWxpa2UgYmVoYXZpb3Vy IGNhbiBiZSBzZWxlY3RlZCBieSBzZXR0aW5nIHRoaXMNCj4gK29wdGlvbi4NCj4gKw0KPiArSWYg dXNpbmcgdGhpcyBvcHRpb24gaXMgbmVjZXNzYXJ5IHRvIGZpeCBhbiBpc3N1ZSwgcGxlYXNlIHJl cG9ydCBhIGJ1Zy4NCj4gKw0KPiAgPWJhY2sNCj4gDQo+ICA9aGVhZDEgU0VFIEFMU08NCj4gZGlm ZiAtLWdpdCBhL2RvY3MvbWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRvYyBiL2RvY3MvbWlzYy94 ZW4tDQo+IGNvbW1hbmQtbGluZS5wYW5kb2MNCj4gaW5kZXggNDczN2M5MmJmZS4uYTA2MDFmZjgz OCAxMDA2NDQNCj4gLS0tIGEvZG9jcy9taXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jDQo+ICsr KyBiL2RvY3MvbWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRvYw0KPiBAQCAtNzQwLDcgKzc0MCw3 IEBAIFNwZWNpZnkgdGhlIGJpdCB3aWR0aCBvZiB0aGUgRE1BIGhlYXAuDQo+IA0KPiAgIyMjIGRv bTANCj4gICAgICA9IExpc3Qgb2YgWyBwdiB8IHB2aCwgc2hhZG93PTxib29sPiwgdmVyYm9zZT08 Ym9vbD4sDQo+IC0gICAgICAgICAgICAgICAgY3B1aWQtZmF1bHRpbmc9PGJvb2w+IF0NCj4gKyAg ICAgICAgICAgICAgICBjcHVpZC1mYXVsdGluZz08Ym9vbD4sIG1zci1yZWxheGVkPTxib29sPiBd DQo+IA0KPiAgICAgIEFwcGxpY2FiaWxpdHk6IHg4Ng0KPiANCj4gQEAgLTc4OSw2ICs3ODksMTgg QEAgQ29udHJvbHMgZm9yIGhvdyBkb20wIGlzIGNvbnN0cnVjdGVkIG9uIHg4Ng0KPiBzeXN0ZW1z Lg0KPiAgICAgIHJlc3RvcmUgdGhlIHByZS00LjEzIGJlaGF2aW91ci4gIElmIHNwZWNpZnlpbmcg YG5vLWNwdWlkLWZhdWx0aW5nYCBmaXhlcw0KPiAgICAgIGFuIGlzc3VlIGluIGRvbTAsIHBsZWFz ZSByZXBvcnQgYSBidWcuDQo+IA0KPiArKiAgIFRoZSBgbXNyLXJlbGF4ZWRgIGJvb2xlYW4gaXMg YW4gaW50ZXJpbSBvcHRpb24sIGFuZCBkZWZhdWx0cyB0byBmYWxzZS4NCj4gKw0KPiArICAgIElu IFhlbiA0LjE1LCB0aGUgZGVmYXVsdCBiZWhhdmlvdXIgZm9yIHVuaGFuZGxlZCBNU1JzIGhhcyBi ZWVuIGNoYW5nZWQsDQo+ICsgICAgdG8gYXZvaWQgbGVha2luZyBob3N0IGRhdGEgaW50byBndWVz dHMsIGFuZCB0byBhdm9pZCBicmVha2luZyBndWVzdA0KPiArICAgIGxvZ2ljIHdoaWNoIHVzZXMg XCNHUCBwcm9iaW5nIHRvIGlkZW50aWZ5IHRoZSBhdmFpbGFiaWxpdHkgb2YgTVNScy4NCj4gKw0K PiArICAgIEhvd2V2ZXIsIHRoaXMgbmV3IHN0cmljdGVyIGJlaGF2aW91ciBoYXMgdGhlIHBvc3Np YmlsaXR5IHRvIGJyZWFrDQo+ICsgICAgZ3Vlc3RzLCBhbmQgYSBtb3JlIDQuMTQtbGlrZSBiZWhh dmlvdXIgY2FuIGJlIHNlbGVjdGVkIGJ5IHNwZWNpZnlpbmcNCj4gKyAgICBgZG9tMD1tc3ItcmVs YXhlZGAuDQo+ICsNCj4gKyAgICBJZiB1c2luZyB0aGlzIG9wdGlvbiBpcyBuZWNlc3NhcnkgdG8g Zml4IGFuIGlzc3VlLCBwbGVhc2UgcmVwb3J0IGEgYnVnLg0KPiArDQo+ICAjIyMgZG9tMC1pb21t dQ0KPiAgICAgID0gTGlzdCBvZiBbIHBhc3N0aHJvdWdoPTxib29sPiwgc3RyaWN0PTxib29sPiwg bWFwLWluY2x1c2l2ZT08Ym9vbD4sDQo+ICAgICAgICAgICAgICAgICAgbWFwLXJlc2VydmVkPTxi b29sPiwgbm9uZSBdDQo+IGRpZmYgLS1naXQgYS90b29scy9pbmNsdWRlL2xpYnhsLmggYi90b29s cy9pbmNsdWRlL2xpYnhsLmgNCj4gaW5kZXggYTdiNjczZTg5ZC4uYWU3ZmUyN2MxZiAxMDA2NDQN Cj4gLS0tIGEvdG9vbHMvaW5jbHVkZS9saWJ4bC5oDQo+ICsrKyBiL3Rvb2xzL2luY2x1ZGUvbGli eGwuaA0KPiBAQCAtNDk1LDYgKzQ5NSwxMyBAQA0KPiAgICovDQo+ICAjZGVmaW5lIExJQlhMX0hB VkVfVk1UUkFDRV9CVUZfS0IgMQ0KPiANCj4gKy8qDQo+ICsgKiBMSUJYTF9IQVZFX1g4Nl9NU1Jf UkVMQVhFRCBpbmRpY2F0ZXMgdGhlIHRvb2xzdGFjayBoYXMgc3VwcG9ydCBmb3INCj4gc3dpdGNo aW5nDQo+ICsgKiB0aGUgTVNSIGFjY2VzcyBoYW5kbGluZyBpbiB0aGUgaHlwZXJ2aXNvciB0byBy ZWxheGVkIG1vZGUuIFRoaXMgaXMgZG9uZQ0KPiBieQ0KPiArICogc2V0dGluZyB0aGUgbGlieGxf ZG9tYWluX2J1aWxkX2luZm8gYXJjaF94ODYubXNyX3JlbGF4ZWQgZmllbGQuDQo+ICsgKi8NCj4g KyNkZWZpbmUgTElCWExfSEFWRV9YODZfTVNSX1JFTEFYRUQgMQ0KPiArDQo+ICAvKg0KPiAgICog bGlieGwgQUJJIGNvbXBhdGliaWxpdHkNCj4gICAqDQo+IGRpZmYgLS1naXQgYS90b29scy9saWJz L2xpZ2h0L2xpYnhsX2FyY2guaCBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJjaC5oDQo+IGlu ZGV4IGMzMDVkNzA0YjEuLjg1MjdmYzVjNmMgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL2xpYnMvbGln aHQvbGlieGxfYXJjaC5oDQo+ICsrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJjaC5oDQo+ IEBAIC04NSw2ICs4NSwxMSBAQCBpbnQgbGlieGxfX2FyY2hfZXh0cmFfbWVtb3J5KGxpYnhsX19n YyAqZ2MsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGxpYnhsX2RvbWFp bl9idWlsZF9pbmZvICppbmZvLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50 NjRfdCAqb3V0KTsNCj4gDQo+ICtfaGlkZGVuDQo+ICt2b2lkIGxpYnhsX19hcmNoX3VwZGF0ZV9k b21haW5fY29uZmlnKGxpYnhsX19nYyAqZ2MsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGxpYnhsX2RvbWFpbl9jb25maWcgKmRzdCwNCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgbGlieGxfZG9tYWluX2NvbmZpZyAqc3JjKTsN Cj4gKw0KPiAgI2lmIGRlZmluZWQoX19pMzg2X18pIHx8IGRlZmluZWQoX194ODZfNjRfXykNCj4g DQo+ICAjZGVmaW5lIExBUElDX0JBU0VfQUREUkVTUyAgMHhmZWUwMDAwMA0KPiBkaWZmIC0tZ2l0 IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcm0uYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxf YXJtLmMNCj4gaW5kZXggNWUyYTIwOWE4Yi4uZTI5MDFmMTNiNyAxMDA2NDQNCj4gLS0tIGEvdG9v bHMvbGlicy9saWdodC9saWJ4bF9hcm0uYw0KPiArKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhs X2FybS5jDQo+IEBAIC0xMjIyLDYgKzEyMjIsMTIgQEAgaW50DQo+IGxpYnhsX19hcmNoX3Bhc3N0 aHJvdWdoX21vZGVfc2V0ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLA0KPiAgICAgIHJldHVybiByYzsN Cj4gIH0NCj4gDQo+ICt2b2lkIGxpYnhsX19hcmNoX3VwZGF0ZV9kb21haW5fY29uZmlnKGxpYnhs X19nYyAqZ2MsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxpYnhs X2RvbWFpbl9jb25maWcgKmRzdCwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgY29uc3QgbGlieGxfZG9tYWluX2NvbmZpZyAqc3JjKQ0KPiArew0KPiArfQ0KPiArDQo+ ICAvKg0KPiAgICogTG9jYWwgdmFyaWFibGVzOg0KPiAgICogbW9kZTogQw0KPiBkaWZmIC0tZ2l0 IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9jcmVhdGUuYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGli eGxfY3JlYXRlLmMNCj4gaW5kZXggNDZmNjhkYTY5Ny4uMTEzMWIyYTczMyAxMDA2NDQNCj4gLS0t IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9jcmVhdGUuYw0KPiArKysgYi90b29scy9saWJzL2xp Z2h0L2xpYnhsX2NyZWF0ZS5jDQo+IEBAIC0yMjg3LDYgKzIyODcsMTMgQEAgaW50IGxpYnhsX2Rv bWFpbl9jcmVhdGVfcmVzdG9yZShsaWJ4bF9jdHggKmN0eCwNCj4gbGlieGxfZG9tYWluX2NvbmZp ZyAqZF9jb25maWcsDQo+ICAgICAgICAgIHVuc2V0X2Rpc2tfY29sb19yZXN0b3JlKGRfY29uZmln KTsNCj4gICAgICB9DQo+IA0KPiArICAgIC8qDQo+ICsgICAgICogV2hlbiByZXN0b3JpbmcgKGVp dGhlciBmcm9tIGEgc2F2ZSBmaWxlIG9yIGZvciBhIG1pZ3JhdGlvbiBkb21haW4pIHNldA0KPiAr ICAgICAqIHRoZSBNU1IgcmVsYXhlZCBtb2RlIGZvciBjb21wYXRpYmlsaXR5IHdpdGggb2xkZXIg WGVuIHZlcnNpb25zIGlmIHRoZQ0KPiArICAgICAqIG9wdGlvbiBpcyBub3Qgc2V0IGFzIHBhcnQg b2YgdGhlIG9yaWdpbmFsIGNvbmZpZ3VyYXRpb24uDQo+ICsgICAgICovDQo+ICsgICAgbGlieGxf ZGVmYm9vbF9zZXRkZWZhdWx0KCZkX2NvbmZpZy0+Yl9pbmZvLmFyY2hfeDg2Lm1zcl9yZWxheGVk LCB0cnVlKTsNCj4gKw0KPiAgICAgIHJldHVybiBkb19kb21haW5fY3JlYXRlKGN0eCwgZF9jb25m aWcsIGRvbWlkLCByZXN0b3JlX2ZkLCBzZW5kX2JhY2tfZmQsDQo+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgcGFyYW1zLCBhb19ob3csIGFvcF9jb25zb2xlX2hvdyk7DQo+ICB9DQo+IGRp ZmYgLS1naXQgYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2ludGVybmFsLmMgYi90b29scy9saWJz L2xpZ2h0L2xpYnhsX2ludGVybmFsLmMNCj4gaW5kZXggZDkzYTc1NTMzZi4uODY1NTZiNjExMyAx MDA2NDQNCj4gLS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9pbnRlcm5hbC5jDQo+ICsrKyBi L3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfaW50ZXJuYWwuYw0KPiBAQCAtMTYsNiArMTYsNyBAQA0K PiAgI2luY2x1ZGUgImxpYnhsX29zZGVwcy5oIiAvKiBtdXN0IGNvbWUgYmVmb3JlIGFueSBvdGhl ciBoZWFkZXJzICovDQo+IA0KPiAgI2luY2x1ZGUgImxpYnhsX2ludGVybmFsLmgiDQo+ICsjaW5j bHVkZSAibGlieGxfYXJjaC5oIg0KPiANCj4gIHZvaWQgbGlieGxfX2FsbG9jX2ZhaWxlZChsaWJ4 bF9jdHggKmN0eCwgY29uc3QgY2hhciAqZnVuYywNCj4gICAgICAgICAgICAgICAgICAgICAgICAg ICBzaXplX3Qgbm1lbWIsIHNpemVfdCBzaXplKSB7DQo+IEBAIC01OTQsNiArNTk1LDggQEAgdm9p ZCBsaWJ4bF9fdXBkYXRlX2RvbWFpbl9jb25maWd1cmF0aW9uKGxpYnhsX19nYw0KPiAqZ2MsDQo+ IA0KPiAgICAgIC8qIHZpZGVvIHJhbSAqLw0KPiAgICAgIGRzdC0+Yl9pbmZvLnZpZGVvX21lbWti ID0gc3JjLT5iX2luZm8udmlkZW9fbWVta2I7DQo+ICsNCj4gKyAgICBsaWJ4bF9fYXJjaF91cGRh dGVfZG9tYWluX2NvbmZpZyhnYywgZHN0LCBzcmMpOw0KPiAgfQ0KPiANCj4gIHN0YXRpYyB2b2lk IGV2X3Nsb3dsb2NrX2luaXRfaW50ZXJuYWwobGlieGxfX2V2X3Nsb3dsb2NrICpsb2NrLA0KPiBk aWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF90eXBlcy5pZGwgYi90b29scy9saWJz L2xpZ2h0L2xpYnhsX3R5cGVzLmlkbA0KPiBpbmRleCA1Yjg1YTc0MTlmLi5mNDVhZGRkYWIwIDEw MDY0NA0KPiAtLS0gYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVzLmlkbA0KPiArKysgYi90 b29scy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVzLmlkbA0KPiBAQCAtNjQ0LDYgKzY0NCw4IEBAIGxp YnhsX2RvbWFpbl9idWlsZF9pbmZvID0NCj4gU3RydWN0KCJkb21haW5fYnVpbGRfaW5mbyIsWw0K PiAgICAgICgiYXJjaF9hcm0iLCBTdHJ1Y3QoTm9uZSwgWygiZ2ljX3ZlcnNpb24iLCBsaWJ4bF9n aWNfdmVyc2lvbiksDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKCJ2dWFydCIs IGxpYnhsX3Z1YXJ0X3R5cGUpLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXSkp LA0KPiArICAgICgiYXJjaF94ODYiLCBTdHJ1Y3QoTm9uZSwgWygibXNyX3JlbGF4ZWQiLCBsaWJ4 bF9kZWZib29sKSwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF0pKSwNCj4gICAg ICAjIEFsdGVybmF0ZSBwMm0gaXMgbm90IGJvdW5kIHRvIGFueSBhcmNoaXRlY3R1cmUgb3IgZ3Vl c3QgdHlwZSwgYXMgaXQgaXMNCj4gICAgICAjIHN1cHBvcnRlZCBieSB4ODYgSFZNIGFuZCBBUk0g c3VwcG9ydCBpcyBwbGFubmVkLg0KPiAgICAgICgiYWx0cDJtIiwgbGlieGxfYWx0cDJtX21vZGUp LA0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF94ODYuYyBiL3Rvb2xzL2xp YnMvbGlnaHQvbGlieGxfeDg2LmMNCj4gaW5kZXggNTgxODdlZDc2MC4uYWMwOTg5N2E2MyAxMDA2 NDQNCj4gLS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF94ODYuYw0KPiArKysgYi90b29scy9s aWJzL2xpZ2h0L2xpYnhsX3g4Ni5jDQo+IEBAIC0xOSw2ICsxOSwxMCBAQCBpbnQgbGlieGxfX2Fy Y2hfZG9tYWluX3ByZXBhcmVfY29uZmlnKGxpYnhsX19nYyAqZ2MsDQo+ICAgICAgICAgIGFib3J0 KCk7DQo+ICAgICAgfQ0KPiANCj4gKyAgICBjb25maWctPmFyY2gubWlzY19mbGFncyA9IDA7DQo+ ICsgICAgaWYgKGxpYnhsX2RlZmJvb2xfdmFsKGRfY29uZmlnLT5iX2luZm8uYXJjaF94ODYubXNy X3JlbGF4ZWQpKQ0KPiArICAgICAgICBjb25maWctPmFyY2gubWlzY19mbGFncyB8PSBYRU5fWDg2 X01TUl9SRUxBWEVEOw0KPiArDQo+ICAgICAgcmV0dXJuIDA7DQo+ICB9DQo+IA0KPiBAQCAtODA5 LDYgKzgxMyw3IEBAIHZvaWQNCj4gbGlieGxfX2FyY2hfZG9tYWluX2J1aWxkX2luZm9fc2V0ZGVm YXVsdChsaWJ4bF9fZ2MgKmdjLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGxpYnhsX2RvbWFpbl9idWlsZF9pbmZvICpiX2luZm8pDQo+ICB7DQo+ICAg ICAgbGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZiX2luZm8tPmFjcGksIHRydWUpOw0KPiArICAg IGxpYnhsX2RlZmJvb2xfc2V0ZGVmYXVsdCgmYl9pbmZvLT5hcmNoX3g4Ni5tc3JfcmVsYXhlZCwg ZmFsc2UpOw0KPiAgfQ0KPiANCj4gIGludCBsaWJ4bF9fYXJjaF9wYXNzdGhyb3VnaF9tb2RlX3Nl dGRlZmF1bHQobGlieGxfX2djICpnYywNCj4gQEAgLTg1MSw2ICs4NTYsMjEgQEAgaW50DQo+IGxp YnhsX19hcmNoX3Bhc3N0aHJvdWdoX21vZGVfc2V0ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLA0KPiAg ICAgIHJldHVybiByYzsNCj4gIH0NCj4gDQo+ICt2b2lkIGxpYnhsX19hcmNoX3VwZGF0ZV9kb21h aW5fY29uZmlnKGxpYnhsX19nYyAqZ2MsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGxpYnhsX2RvbWFpbl9jb25maWcgKmRzdCwNCj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgY29uc3QgbGlieGxfZG9tYWluX2NvbmZpZyAqc3JjKQ0KPiAr ew0KPiArICAgIC8qDQo+ICsgICAgICogRm9yY2UgTVNSIHJlbGF4ZWQgdG8gYmUgc2V0IChlaXRo ZXIgdG8gdHJ1ZSBvciBmYWxzZSkgc28gaXQncyBwYXJ0IG9mDQo+ICsgICAgICogdGhlIGRvbWFp biBjb25maWd1cmF0aW9uIHdoZW4gc2F2aW5nIG9yIHBlcmZvcm1pbmcgYSBsaXZlLW1pZ3JhdGlv bi4NCj4gKyAgICAgKg0KPiArICAgICAqIERvaW5nIHNvIGFsbG93cyB0aGUgcmVjb3Zlcnkgc2lk ZSB0byBmaWd1cmUgb3V0IHdoZXRoZXIgdGhlIGZsYWcgc2hvdWxkDQo+ICsgICAgICogYmUgc2V0 IHRvIHRydWUgaW4gb3JkZXIgdG8ga2VlcCBiYWNrd2FyZHMgY29tcGF0aWJpbGl0eSB3aXRoIGFs cmVhZHkNCj4gKyAgICAgKiBzdGFydGVkIGRvbWFpbnMuDQo+ICsgICAgICovDQo+ICsgICAgbGli eGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZkc3QtPmJfaW5mby5hcmNoX3g4Ni5tc3JfcmVsYXhlZCwN Cj4gKyAgICAgICAgICAgICAgICAgICAgbGlieGxfZGVmYm9vbF92YWwoc3JjLT5iX2luZm8uYXJj aF94ODYubXNyX3JlbGF4ZWQpKTsNCj4gK30NCj4gDQo+ICAvKg0KPiAgICogTG9jYWwgdmFyaWFi bGVzOg0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sIGIvdG9v bHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sDQo+IGluZGV4IGEwMmUyNmIyN2YuLmE1NTg4YzY0 M2YgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbA0KPiArKysg Yi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWwNCj4gQEAgLTQ4LDkgKzQ4LDEzIEBAIHR5 cGUgeDg2X2FyY2hfZW11bGF0aW9uX2ZsYWdzID0NCj4gIAl8IFg4Nl9FTVVfVVNFX1BJUlENCj4g IAl8IFg4Nl9FTVVfVlBDSQ0KPiANCj4gK3R5cGUgeDg2X2FyY2hfbWlzY19mbGFncyA9DQo+ICsJ fCBYODZfTVNSX1JFTEFYRUQNCj4gKw0KPiAgdHlwZSB4ZW5feDg2X2FyY2hfZG9tYWluY29uZmln ID0NCj4gIHsNCj4gIAllbXVsYXRpb25fZmxhZ3M6IHg4Nl9hcmNoX2VtdWxhdGlvbl9mbGFncyBs aXN0Ow0KPiArCW1pc2NfZmxhZ3M6IHg4Nl9hcmNoX21pc2NfZmxhZ3MgbGlzdDsNCj4gIH0NCj4g DQo+ICB0eXBlIGFyY2hfZG9tYWluY29uZmlnID0NCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1s L2xpYnMveGMveGVuY3RybC5tbGkgYi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWxpDQo+ IGluZGV4IGQyYTMxMmUyNzMuLjZlOTQ5NDBhOGEgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL29jYW1s L2xpYnMveGMveGVuY3RybC5tbGkNCj4gKysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJs Lm1saQ0KPiBAQCAtNDIsOCArNDIsMTIgQEAgdHlwZSB4ODZfYXJjaF9lbXVsYXRpb25fZmxhZ3Mg PQ0KPiAgICB8IFg4Nl9FTVVfVVNFX1BJUlENCj4gICAgfCBYODZfRU1VX1ZQQ0kNCj4gDQo+ICt0 eXBlIHg4Nl9hcmNoX21pc2NfZmxhZ3MgPQ0KPiArICB8IFg4Nl9NU1JfUkVMQVhFRA0KPiArDQo+ ICB0eXBlIHhlbl94ODZfYXJjaF9kb21haW5jb25maWcgPSB7DQo+ICAgIGVtdWxhdGlvbl9mbGFn czogeDg2X2FyY2hfZW11bGF0aW9uX2ZsYWdzIGxpc3Q7DQo+ICsgIG1pc2NfZmxhZ3M6IHg4Nl9h cmNoX21pc2NfZmxhZ3MgbGlzdDsNCj4gIH0NCj4gDQo+ICB0eXBlIGFyY2hfZG9tYWluY29uZmln ID0NCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybF9zdHVicy5jDQo+ IGIvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsX3N0dWJzLmMNCj4gaW5kZXggOWE4ZGJlNTU3 OS4uZDA1ZDdiYjMwZSAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJs X3N0dWJzLmMNCj4gKysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsX3N0dWJzLmMNCj4g QEAgLTIzMyw2ICsyMzMsMTUgQEAgQ0FNTHByaW0gdmFsdWUgc3R1Yl94Y19kb21haW5fY3JlYXRl KHZhbHVlIHhjaCwNCj4gdmFsdWUgd2FudGVkX2RvbWlkLCB2YWx1ZSBjb25maWcNCj4gDQo+ICAj dW5kZWYgVkFMX0VNVUxfRkxBR1MNCj4gDQo+ICsjZGVmaW5lIFZBTF9NSVNDX0ZMQUdTICAgICAg ICAgIEZpZWxkKGFyY2hfZG9tY29uZmlnLCAxKQ0KPiArDQo+ICsJCWNmZy5hcmNoLm1pc2NfZmxh Z3MgPSBvY2FtbF9saXN0X3RvX2NfYml0bWFwDQo+ICsJCQkvKiAhIHg4Nl9hcmNoX21pc2NfZmxh Z3MgWDg2XyBub25lICovDQo+ICsJCQkvKiAhIFhFTl9YODZfIFhFTl9YODZfTVNSX1JFTEFYRUQg YWxsICovDQo+ICsJCQkoVkFMX01JU0NfRkxBR1MpOw0KPiArDQo+ICsjdW5kZWYgVkFMX01JU0Nf RkxBR1MNCj4gKw0KPiAgI2Vsc2UNCj4gIAkJY2FtbF9mYWlsd2l0aCgiVW5oYW5kbGVkOiB4ODYi KTsNCj4gICNlbmRpZg0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMveGwveGxfcGFyc2UuYyBiL3Rvb2xz L3hsL3hsX3BhcnNlLmMNCj4gaW5kZXggMTg5M2NmYzA4Ni4uOWZiMDc5MTQyOSAxMDA2NDQNCj4g LS0tIGEvdG9vbHMveGwveGxfcGFyc2UuYw0KPiArKysgYi90b29scy94bC94bF9wYXJzZS5jDQo+ IEBAIC0yNzQxLDYgKzI3NDEsMTMgQEAgc2tpcF91c2JkZXY6DQo+ICAgICAgeGx1X2NmZ19nZXRf ZGVmYm9vbChjb25maWcsICJ4ZW5kX3N1c3BlbmRfZXZ0Y2huX2NvbXBhdCIsDQo+ICAgICAgICAg ICAgICAgICAgICAgICAgICAmY19pbmZvLT54ZW5kX3N1c3BlbmRfZXZ0Y2huX2NvbXBhdCwgMCk7 DQo+IA0KPiArICAgIGlmICgheGx1X2NmZ19nZXRfZGVmYm9vbChjb25maWcsICJtc3JfcmVsYXhl ZCIsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZiX2luZm8tPmFyY2hfeDg2Lm1z cl9yZWxheGVkLCAwKSkNCj4gKyAgICAgICAgICAgIGZwcmludGYoc3RkZXJyLA0KPiArICAgICAg ICAgICAgICAgICAgICAiV0FSTklORzogbXNyX3JlbGF4ZWQgd2lsbCBiZSByZW1vdmVkIGluIGZ1 dHVyZSB2ZXJzaW9ucy5cbiINCj4gKyAgICAgICAgICAgICAgICAgICAgIklmIGl0IGZpeGVzIGFu IGlzc3VlIHlvdSBhcmUgaGF2aW5nIHBsZWFzZSByZXBvcnQgdG8gIg0KPiArICAgICAgICAgICAg ICAgICAgICAieGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnLlxuIik7DQo+ICsNCj4gICAg ICB4bHVfY2ZnX2Rlc3Ryb3koY29uZmlnKTsNCj4gIH0NCj4gDQo+IGRpZmYgLS1naXQgYS94ZW4v YXJjaC94ODYvZG9tMF9idWlsZC5jIGIveGVuL2FyY2gveDg2L2RvbTBfYnVpbGQuYw0KPiBpbmRl eCAwY2UyOWU5MWEzLi43NGI0NDNlNTA5IDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC94ODYvZG9t MF9idWlsZC5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9kb20wX2J1aWxkLmMNCj4gQEAgLTI1Niw2 ICsyNTYsNyBAQCBib29sIF9faW5pdGRhdGEgb3B0X2RvbTBfc2hhZG93Ow0KPiAgI2VuZGlmDQo+ ICBib29sIF9faW5pdGRhdGEgb3B0X2RvbTBfcHZoID0gIUlTX0VOQUJMRUQoQ09ORklHX1BWKTsN Cj4gIGJvb2wgX19pbml0ZGF0YSBvcHRfZG9tMF92ZXJib3NlID0NCj4gSVNfRU5BQkxFRChDT05G SUdfVkVSQk9TRV9ERUJVRyk7DQo+ICtib29sIF9faW5pdGRhdGEgb3B0X2RvbTBfbXNyX3JlbGF4 ZWQ7DQo+IA0KPiAgc3RhdGljIGludCBfX2luaXQgcGFyc2VfZG9tMF9wYXJhbShjb25zdCBjaGFy ICpzKQ0KPiAgew0KPiBAQCAtMjgyLDYgKzI4Myw4IEBAIHN0YXRpYyBpbnQgX19pbml0IHBhcnNl X2RvbTBfcGFyYW0oY29uc3QgY2hhciAqcykNCj4gICAgICAgICAgZWxzZSBpZiAoIElTX0VOQUJM RUQoQ09ORklHX1BWKSAmJg0KPiAgICAgICAgICAgICAgICAgICAgKHZhbCA9IHBhcnNlX2Jvb2xl YW4oImNwdWlkLWZhdWx0aW5nIiwgcywgc3MpKSA+PSAwICkNCj4gICAgICAgICAgICAgIG9wdF9k b20wX2NwdWlkX2ZhdWx0aW5nID0gdmFsOw0KPiArICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBh cnNlX2Jvb2xlYW4oIm1zci1yZWxheGVkIiwgcywgc3MpKSA+PSAwICkNCj4gKyAgICAgICAgICAg IG9wdF9kb20wX21zcl9yZWxheGVkID0gdmFsOw0KPiAgICAgICAgICBlbHNlDQo+ICAgICAgICAg ICAgICByYyA9IC1FSU5WQUw7DQo+IA0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2RvbWFp bi5jIGIveGVuL2FyY2gveDg2L2RvbWFpbi5jDQo+IGluZGV4IDVlM2M5NGQzZmEuLmIyMTI3Mjk4 ODAgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYw0KPiArKysgYi94ZW4vYXJj aC94ODYvZG9tYWluLmMNCj4gQEAgLTY4Myw2ICs2ODMsMTMgQEAgaW50IGFyY2hfc2FuaXRpc2Vf ZG9tYWluX2NvbmZpZyhzdHJ1Y3QNCj4geGVuX2RvbWN0bF9jcmVhdGVkb21haW4gKmNvbmZpZykN Cj4gICAgICAgICAgfQ0KPiAgICAgIH0NCj4gDQo+ICsgICAgaWYgKCBjb25maWctPmFyY2gubWlz Y19mbGFncyAmIH5YRU5fWDg2X01TUl9SRUxBWEVEICkNCj4gKyAgICB7DQo+ICsgICAgICAgIGRw cmludGsoWEVOTE9HX0lORk8sICJJbnZhbGlkIGFyY2ggbWlzYyBmbGFncyAlI3hcbiIsDQo+ICsg ICAgICAgICAgICAgICAgY29uZmlnLT5hcmNoLm1pc2NfZmxhZ3MpOw0KPiArICAgICAgICByZXR1 cm4gLUVJTlZBTDsNCj4gKyAgICB9DQo+ICsNCj4gICAgICByZXR1cm4gMDsNCj4gIH0NCj4gDQo+ IEBAIC04NTIsNiArODU5LDggQEAgaW50IGFyY2hfZG9tYWluX2NyZWF0ZShzdHJ1Y3QgZG9tYWlu ICpkLA0KPiANCj4gICAgICBkb21haW5fY3B1X3BvbGljeV9jaGFuZ2VkKGQpOw0KPiANCj4gKyAg ICBkLT5hcmNoLm1zcl9yZWxheGVkID0gY29uZmlnLT5hcmNoLm1pc2NfZmxhZ3MgJiBYRU5fWDg2 X01TUl9SRUxBWEVEOw0KPiArDQo+ICAgICAgcmV0dXJuIDA7DQo+IA0KPiAgIGZhaWw6DQo+IGRp ZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3N2bS9zdm0uYyBiL3hlbi9hcmNoL3g4Ni9odm0v c3ZtL3N2bS5jDQo+IGluZGV4IGI4MTk4OTdhNGEuLjQ1ODVlZmUxZjggMTAwNjQ0DQo+IC0tLSBh L3hlbi9hcmNoL3g4Ni9odm0vc3ZtL3N2bS5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vc3Zt L3N2bS5jDQo+IEBAIC0xNzk1LDYgKzE3OTUsNyBAQCBzdGF0aWMgaW50IHN2bV9tc3JfcmVhZF9p bnRlcmNlcHQodW5zaWduZWQgaW50DQo+IG1zciwgdWludDY0X3QgKm1zcl9jb250ZW50KQ0KPiAg ICAgIGNvbnN0IHN0cnVjdCBkb21haW4gKmQgPSB2LT5kb21haW47DQo+ICAgICAgc3RydWN0IHZt Y2Jfc3RydWN0ICp2bWNiID0gdi0+YXJjaC5odm0uc3ZtLnZtY2I7DQo+ICAgICAgY29uc3Qgc3Ry dWN0IG5lc3RlZHN2bSAqbnN2bSA9ICZ2Y3B1X25lc3RlZHN2bSh2KTsNCj4gKyAgICB1aW50NjRf dCB0bXA7DQo+IA0KPiAgICAgIHN3aXRjaCAoIG1zciApDQo+ICAgICAgew0KPiBAQCAtMTk2NSw2 ICsxOTY2LDEyIEBAIHN0YXRpYyBpbnQgc3ZtX21zcl9yZWFkX2ludGVyY2VwdCh1bnNpZ25lZCBp bnQNCj4gbXNyLCB1aW50NjRfdCAqbXNyX2NvbnRlbnQpDQo+ICAgICAgICAgIGJyZWFrOw0KPiAN Cj4gICAgICBkZWZhdWx0Og0KPiArICAgICAgICBpZiAoIGQtPmFyY2gubXNyX3JlbGF4ZWQgJiYg IXJkbXNyX3NhZmUobXNyLCB0bXApICkNCj4gKyAgICAgICAgew0KPiArICAgICAgICAgICAgKm1z cl9jb250ZW50ID0gMDsNCj4gKyAgICAgICAgICAgIGJyZWFrOw0KPiArICAgICAgICB9DQo+ICsN Cj4gICAgICAgICAgZ2RwcmludGsoWEVOTE9HX1dBUk5JTkcsICJSRE1TUiAweCUwOHggdW5pbXBs ZW1lbnRlZFxuIiwgbXNyKTsNCj4gICAgICAgICAgZ290byBncGY7DQo+ICAgICAgfQ0KPiBAQCAt MjE1MSw2ICsyMTU4LDkgQEAgc3RhdGljIGludCBzdm1fbXNyX3dyaXRlX2ludGVyY2VwdCh1bnNp Z25lZCBpbnQNCj4gbXNyLCB1aW50NjRfdCBtc3JfY29udGVudCkNCj4gICAgICAgICAgYnJlYWs7 DQo+IA0KPiAgICAgIGRlZmF1bHQ6DQo+ICsgICAgICAgIGlmICggZC0+YXJjaC5tc3JfcmVsYXhl ZCAmJiAhcmRtc3Jfc2FmZShtc3IsIG1zcl9jb250ZW50KSApDQo+ICsgICAgICAgICAgICBicmVh azsNCj4gKw0KPiAgICAgICAgICBnZHByaW50ayhYRU5MT0dfV0FSTklORywNCj4gICAgICAgICAg ICAgICAgICAgIldSTVNSIDB4JTA4eCB2YWwgMHglMDE2IlBSSXg2NCIgdW5pbXBsZW1lbnRlZFxu IiwNCj4gICAgICAgICAgICAgICAgICAgbXNyLCBtc3JfY29udGVudCk7DQo+IGRpZmYgLS1naXQg YS94ZW4vYXJjaC94ODYvaHZtL3ZteC92bXguYyBiL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5j DQo+IGluZGV4IGJmZWExYjBmOGEuLmI1MjgyNDY3N2UgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNo L3g4Ni9odm0vdm14L3ZteC5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jDQo+ IEBAIC0zMTIzLDYgKzMxMjMsNyBAQCBzdGF0aWMgaW50IGlzX2xhc3RfYnJhbmNoX21zcih1MzIg ZWN4KQ0KPiAgc3RhdGljIGludCB2bXhfbXNyX3JlYWRfaW50ZXJjZXB0KHVuc2lnbmVkIGludCBt c3IsIHVpbnQ2NF90ICptc3JfY29udGVudCkNCj4gIHsNCj4gICAgICBzdHJ1Y3QgdmNwdSAqY3Vy ciA9IGN1cnJlbnQ7DQo+ICsgICAgdWludDY0X3QgdG1wOw0KPiANCj4gICAgICBIVk1fREJHX0xP RyhEQkdfTEVWRUxfTVNSLCAiZWN4PSUjeCIsIG1zcik7DQo+IA0KPiBAQCAtMzIwNCw2ICszMjA1 LDEyIEBAIHN0YXRpYyBpbnQgdm14X21zcl9yZWFkX2ludGVyY2VwdCh1bnNpZ25lZCBpbnQNCj4g bXNyLCB1aW50NjRfdCAqbXNyX2NvbnRlbnQpDQo+ICAgICAgICAgICAgICBicmVhazsNCj4gICAg ICAgICAgfQ0KPiANCj4gKyAgICAgICAgaWYgKCBjdXJyLT5kb21haW4tPmFyY2gubXNyX3JlbGF4 ZWQgJiYgIXJkbXNyX3NhZmUobXNyLCB0bXApICkNCj4gKyAgICAgICAgew0KPiArICAgICAgICAg ICAgKm1zcl9jb250ZW50ID0gMDsNCj4gKyAgICAgICAgICAgIGJyZWFrOw0KPiArICAgICAgICB9 DQo+ICsNCj4gICAgICAgICAgZ2RwcmludGsoWEVOTE9HX1dBUk5JTkcsICJSRE1TUiAweCUwOHgg dW5pbXBsZW1lbnRlZFxuIiwgbXNyKTsNCj4gICAgICAgICAgZ290byBncF9mYXVsdDsNCj4gICAg ICB9DQo+IEBAIC0zNTA1LDYgKzM1MTIsOSBAQCBzdGF0aWMgaW50IHZteF9tc3Jfd3JpdGVfaW50 ZXJjZXB0KHVuc2lnbmVkIGludA0KPiBtc3IsIHVpbnQ2NF90IG1zcl9jb250ZW50KQ0KPiAgICAg ICAgICAgICAgIGlzX2xhc3RfYnJhbmNoX21zcihtc3IpICkNCj4gICAgICAgICAgICAgIGJyZWFr Ow0KPiANCj4gKyAgICAgICAgaWYgKCB2LT5kb21haW4tPmFyY2gubXNyX3JlbGF4ZWQgJiYgIXJk bXNyX3NhZmUobXNyLCBtc3JfY29udGVudCkgKQ0KPiArICAgICAgICAgICAgYnJlYWs7DQo+ICsN Cj4gICAgICAgICAgZ2RwcmludGsoWEVOTE9HX1dBUk5JTkcsDQo+ICAgICAgICAgICAgICAgICAg ICJXUk1TUiAweCUwOHggdmFsIDB4JTAxNiJQUkl4NjQiIHVuaW1wbGVtZW50ZWRcbiIsDQo+ICAg ICAgICAgICAgICAgICAgIG1zciwgbXNyX2NvbnRlbnQpOw0KPiBkaWZmIC0tZ2l0IGEveGVuL2Fy Y2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jIGIveGVuL2FyY2gveDg2L3B2L2VtdWwtcHJpdi0NCj4g b3AuYw0KPiBpbmRleCBlNWEyMmI5MzQ3Li43NGU3MTQwM2ZmIDEwMDY0NA0KPiAtLS0gYS94ZW4v YXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmMNCj4gKysrIGIveGVuL2FyY2gveDg2L3B2L2VtdWwt cHJpdi1vcC5jDQo+IEBAIC04NzUsNiArODc1LDcgQEAgc3RhdGljIGludCByZWFkX21zcih1bnNp Z25lZCBpbnQgcmVnLCB1aW50NjRfdCAqdmFsLA0KPiAgICAgIGNvbnN0IHN0cnVjdCBkb21haW4g KmN1cnJkID0gY3Vyci0+ZG9tYWluOw0KPiAgICAgIGNvbnN0IHN0cnVjdCBjcHVpZF9wb2xpY3kg KmNwID0gY3VycmQtPmFyY2guY3B1aWQ7DQo+ICAgICAgYm9vbCB2cG11X21zciA9IGZhbHNlOw0K PiArICAgIHVpbnQ2NF90IHRtcDsNCj4gICAgICBpbnQgcmV0Ow0KPiANCj4gICAgICBpZiAoIChy ZXQgPSBndWVzdF9yZG1zcihjdXJyLCByZWcsIHZhbCkpICE9IFg4NkVNVUxfVU5IQU5ETEVBQkxF ICkNCj4gQEAgLTk4Niw2ICs5ODcsMTIgQEAgc3RhdGljIGludCByZWFkX21zcih1bnNpZ25lZCBp bnQgcmVnLCB1aW50NjRfdCAqdmFsLA0KPiAgICAgICAgICB9DQo+ICAgICAgICAgIC8qIGZhbGwg dGhyb3VnaCAqLw0KPiAgICAgIGRlZmF1bHQ6DQo+ICsgICAgICAgIGlmICggY3VycmQtPmFyY2gu bXNyX3JlbGF4ZWQgJiYgIXJkbXNyX3NhZmUocmVnLCB0bXApICkNCj4gKyAgICAgICAgew0KPiAr ICAgICAgICAgICAgKnZhbCA9IDA7DQo+ICsgICAgICAgICAgICByZXR1cm4gWDg2RU1VTF9PS0FZ Ow0KPiArICAgICAgICB9DQo+ICsNCj4gICAgICAgICAgZ2RwcmludGsoWEVOTE9HX1dBUk5JTkcs ICJSRE1TUiAweCUwOHggdW5pbXBsZW1lbnRlZFxuIiwgcmVnKTsNCj4gICAgICAgICAgYnJlYWs7 DQo+IA0KPiBAQCAtMTE0OCw2ICsxMTU1LDkgQEAgc3RhdGljIGludCB3cml0ZV9tc3IodW5zaWdu ZWQgaW50IHJlZywgdWludDY0X3QgdmFsLA0KPiAgICAgICAgICB9DQo+ICAgICAgICAgIC8qIGZh bGwgdGhyb3VnaCAqLw0KPiAgICAgIGRlZmF1bHQ6DQo+ICsgICAgICAgIGlmICggY3VycmQtPmFy Y2gubXNyX3JlbGF4ZWQgJiYgIXJkbXNyX3NhZmUocmVnLCB2YWwpICkNCj4gKyAgICAgICAgICAg IHJldHVybiBYODZFTVVMX09LQVk7DQo+ICsNCj4gICAgICAgICAgZ2RwcmludGsoWEVOTE9HX1dB Uk5JTkcsDQo+ICAgICAgICAgICAgICAgICAgICJXUk1TUiAweCUwOHggdmFsIDB4JTAxNiJQUkl4 NjQiIHVuaW1wbGVtZW50ZWRcbiIsDQo+ICAgICAgICAgICAgICAgICAgIHJlZywgdmFsKTsNCj4g ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9zZXR1cC5jIGIveGVuL2FyY2gveDg2L3NldHVwLmMN Cj4gaW5kZXggMjNiYmI2ZThjMS4uNjg0NTRkZjhlZCAxMDA2NDQNCj4gLS0tIGEveGVuL2FyY2gv eDg2L3NldHVwLmMNCj4gKysrIGIveGVuL2FyY2gveDg2L3NldHVwLmMNCj4gQEAgLTc0OSw2ICs3 NDksOSBAQCBzdGF0aWMgc3RydWN0IGRvbWFpbiAqX19pbml0IGNyZWF0ZV9kb20wKGNvbnN0DQo+ IG1vZHVsZV90ICppbWFnZSwNCj4gICAgICAgICAgLm1heF9ncmFudF9mcmFtZXMgPSAtMSwNCj4g ICAgICAgICAgLm1heF9tYXB0cmFja19mcmFtZXMgPSAtMSwNCj4gICAgICAgICAgLm1heF92Y3B1 cyA9IGRvbTBfbWF4X3ZjcHVzKCksDQo+ICsgICAgICAgIC5hcmNoID0gew0KPiArICAgICAgICAg ICAgLm1pc2NfZmxhZ3MgPSBvcHRfZG9tMF9tc3JfcmVsYXhlZCA/IFhFTl9YODZfTVNSX1JFTEFY RUQgOiAwLA0KPiArICAgICAgICB9LA0KPiAgICAgIH07DQo+ICAgICAgc3RydWN0IGRvbWFpbiAq ZDsNCj4gICAgICBjaGFyICpjbWRsaW5lOw0KPiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNt LXg4Ni9kb21haW4uaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvZG9tYWluLmgNCj4gaW5kZXggMzkw MGQ3YjQ4Yi4uNzIxM2QxODRiMCAxMDA2NDQNCj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9k b21haW4uaA0KPiArKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L2RvbWFpbi5oDQo+IEBAIC00Mzcs NiArNDM3LDkgQEAgc3RydWN0IGFyY2hfZG9tYWluDQo+ICAgICAgLyogTWVtX2FjY2VzcyBlbXVs YXRpb24gY29udHJvbCAqLw0KPiAgICAgIGJvb2xfdCBtZW1fYWNjZXNzX2VtdWxhdGVfZWFjaF9y ZXA7DQo+IA0KPiArICAgIC8qIERvbid0IHVuY29uZGl0aW9uYWxseSBpbmplY3QgI0dQIGZvciB1 bmhhbmRsZWQgTVNScy4gKi8NCj4gKyAgICBib29sIG1zcl9yZWxheGVkOw0KPiArDQo+ICAgICAg LyogRW11bGF0ZWQgZGV2aWNlcyBlbmFibGVkIGJpdG1hcC4gKi8NCj4gICAgICB1aW50MzJfdCBl bXVsYXRpb25fZmxhZ3M7DQo+ICB9IF9fY2FjaGVsaW5lX2FsaWduZWQ7DQo+IGRpZmYgLS1naXQg YS94ZW4vaW5jbHVkZS9hc20teDg2L3NldHVwLmggYi94ZW4vaW5jbHVkZS9hc20teDg2L3NldHVw LmgNCj4gaW5kZXggNjQyYTVlODQ2MC4uMjRiZTQ2MTE1ZCAxMDA2NDQNCj4gLS0tIGEveGVuL2lu Y2x1ZGUvYXNtLXg4Ni9zZXR1cC5oDQo+ICsrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc2V0dXAu aA0KPiBAQCAtNjUsNiArNjUsNyBAQCBleHRlcm4gYm9vbCBvcHRfZG9tMF9zaGFkb3c7DQo+ICBl eHRlcm4gYm9vbCBvcHRfZG9tMF9wdmg7DQo+ICBleHRlcm4gYm9vbCBvcHRfZG9tMF92ZXJib3Nl Ow0KPiAgZXh0ZXJuIGJvb2wgb3B0X2RvbTBfY3B1aWRfZmF1bHRpbmc7DQo+ICtleHRlcm4gYm9v bCBvcHRfZG9tMF9tc3JfcmVsYXhlZDsNCj4gDQo+ICAjZGVmaW5lIG1heF9pbml0X2RvbWlkICgw KQ0KPiANCj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni94ZW4uaCBi L3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLQ0KPiB4ODYveGVuLmgNCj4gaW5kZXggNjI5Y2IyYmE0 MC4uNmJmMWU4Y2NjYiAxMDA2NDQNCj4gLS0tIGEveGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2 L3hlbi5oDQo+ICsrKyBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni94ZW4uaA0KPiBAQCAt MzA0LDYgKzMwNCwxNCBAQCBzdHJ1Y3QgeGVuX2FyY2hfZG9tYWluY29uZmlnIHsNCj4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBYRU5fWDg2X0VNVV9QSVQgfCBYRU5fWDg2 X0VNVV9VU0VfUElSUSB8XA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IFhFTl9YODZfRU1VX1ZQQ0kpDQo+ICAgICAgdWludDMyX3QgZW11bGF0aW9uX2ZsYWdzOw0KPiAr DQo+ICsvKg0KPiArICogU2VsZWN0IHdoZXRoZXIgdG8gdXNlIGEgcmVsYXhlZCBiZWhhdmlvciBm b3IgYWNjZXNzZXMgdG8gTVNScyBub3QNCj4gZXhwbGljaXRseQ0KPiArICogaGFuZGxlZCBieSBY ZW4gaW5zdGVhZCBvZiBpbmplY3RpbmcgYSAjR1AgdG8gdGhlIGd1ZXN0LiBOb3RlIHRoaXMgb3B0 aW9uDQo+ICsgKiBkb2Vzbid0IGFsbG93IHRoZSBndWVzdCB0byByZWFkIG9yIHdyaXRlIHRvIHRo ZSB1bmRlcmx5aW5nIE1TUi4NCj4gKyAqLw0KPiArI2RlZmluZSBYRU5fWDg2X01TUl9SRUxBWEVE ICgxdSA8PCAwKQ0KPiArICAgIHVpbnQzMl90IG1pc2NfZmxhZ3M7DQo+ICB9Ow0KPiANCj4gIC8q IExvY2F0aW9uIG9mIG9ubGluZSBWQ1BVIGJpdG1hcC4gKi8NCj4gLS0NCj4gMi4zMC4xDQoNCg== From xen-devel-bounces@lists.xenproject.org Fri Mar 12 07:30:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 07:30:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96855.183664 (Exim 4.92) (envelope-from ) id 1lKcFF-00045G-Gp; Fri, 12 Mar 2021 07:30:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96855.183664; Fri, 12 Mar 2021 07:30:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKcFF-000459-Do; Fri, 12 Mar 2021 07:30:01 +0000 Received: by outflank-mailman (input) for mailman id 96855; Fri, 12 Mar 2021 07:30:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKcFE-000454-R3 for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 07:30:00 +0000 Received: from mail-wr1-x430.google.com (unknown [2a00:1450:4864:20::430]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8858bf89-9b2c-49a5-a4cd-24f67bf0b750; Fri, 12 Mar 2021 07:29:59 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id x13so1195135wrs.9 for ; Thu, 11 Mar 2021 23:29:59 -0800 (PST) Received: from ?IPv6:2a00:23c5:5785:9a01:d41c:67e5:a11f:43fe? ([2a00:23c5:5785:9a01:d41c:67e5:a11f:43fe]) by smtp.gmail.com with ESMTPSA id d29sm6653834wra.51.2021.03.11.23.29.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Mar 2021 23:29:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8858bf89-9b2c-49a5-a4cd-24f67bf0b750 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+GbGDDhDe3XYWVX7P5acwBAajtVk5fQepJhLd2YxEHk=; b=Drwwgq5OiF4NLc4d8wFU/96m5OxgffiKXCyf56WXzlz2L92BsD+swwEF2CjN0z7Veu AdoftD17N5kjN03eWtgMLhphjJfTXiwJQLp5bvoNdP+o3EFWNADkZW+o26rfrIoza/pI D0ZSfLVlM5t7FTmYpq4Ewh5NmC5i2QBp9wmSExHIQSiCbjnIYmxZ07dfaa7CNOiNwF+i XvEJuR5H4J1hBrL1PjBt7SjV+LlAalzNweQg0HHyGwl5hUcuXbJDBr8/lnkHnW8GpZXi wm7dFu5ygw8xLX0iQsNxCCOGwRRl4qtP28N3r1lf1nWlzlZS4r/AwuLLUzGheB9NE4JY Sl/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:cc:references :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=+GbGDDhDe3XYWVX7P5acwBAajtVk5fQepJhLd2YxEHk=; b=uB5bNvjVNGPo1CTK7LSc6AkHhNHZAYu8JY3Y23dhJ2EbVItCENn7hfmkzeJ5oFhQ0M pvoCZJxe6/gpgxHKNi0bgyPmJFNMyVN+Od2R8yqME0Ll/R0/MD80godfAc5wH3ex8Kar aMFv+2U2VefycggLe4yWNKt86TVLwRELC2sfib1w3AhsU2Ub7KqWtduwE7JNdv2VdEIJ wFPWupWLsF6xbQtnLStedPdKM6PIidojnVeepiqAgzjbTDWN+Yom0uAwbmz1e9bntG0U pokR//O3ovXi8PXBjQhRMgoWkJ+Cxj7ltgdX1wPdU3IYBYeQScMzd3rquMsbAkTebow7 BnkA== X-Gm-Message-State: AOAM532keL1vMZoWnkjhLPj/yL+nvXLwUjdkovb0e3nZiox7pIlwjqZV jc4GYMBNmqIc1g8TKickaDo= X-Google-Smtp-Source: ABdhPJw4GjSPmM2lvPGLKlFmWuWvnsZazI4EW0hStIInfgc4qmvvxcpPKkJlBYJFD4IdvsVer+hDyg== X-Received: by 2002:a05:6000:114e:: with SMTP id d14mr12519882wrx.236.1615534198629; Thu, 11 Mar 2021 23:29:58 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH for-4.15 v3] xen/dmop: Strip __XEN_TOOLS__ header guard from public ABI To: Andrew Cooper , Xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson References: <20210311132400.24411-1-andrew.cooper3@citrix.com> Message-ID: <50e384fa-5203-3882-4b0d-3f3721468275@xen.org> Date: Fri, 12 Mar 2021 07:29:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210311132400.24411-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 11/03/2021 13:24, Andrew Cooper wrote: > __XEN_TOOLS__ is really there to separate the unstable from stable hypercalls. > Exactly as with c/s f40e1c52e4, stable interfaces shouldn't contain this > guard. > > That change actually broke the build with: > > include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t' > ioservid_t *id); > ^ > > as libxendevicemodel.h now uses a type it can't see a typedef for. However, > nothing noticed because the header.chk logic is also broken (fixed > subsequently). > > Strip the guard from the public header, and remove compensation from > devicemodel's private.h. Fix the dmop design doc to discuss both reasons > behind the the ABI design. > > Signed-off-by: Andrew Cooper > Acked-by: Jan Beulich > Release-Acked-by: Ian Jackson Reviewed-by: Paul Durrant > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > CC: Paul Durrant > CC: Ian Jackson > > v3: > * Clarifications to the commit message, and dmop.pandoc > v2: > * Patch dmop.pandoc as well. > --- > docs/designs/dmop.pandoc | 12 +++++++++--- > tools/libs/devicemodel/private.h | 2 -- > xen/include/public/hvm/dm_op.h | 5 ----- > 3 files changed, 9 insertions(+), 10 deletions(-) > > diff --git a/docs/designs/dmop.pandoc b/docs/designs/dmop.pandoc > index 8e9f95af47..49e52b1bcc 100644 > --- a/docs/designs/dmop.pandoc > +++ b/docs/designs/dmop.pandoc > @@ -4,9 +4,15 @@ DMOP > Introduction > ------------ > > -The aim of DMOP is to prevent a compromised device model from compromising > -domains other than the one it is providing emulation for (which is therefore > -likely already compromised). > +The DMOP hypercall has a new ABI design to solve problems in the Xen > +ecosystem. First, the ABI is fully stable, to reduce the coupling between > +device models and the version of Xen. Specifically, device model software > +using DMOP (be it user, stub domain or kernel software) need not be recompiled > +to match the version of the running hypervisor. > + > +Secondly, for device models in userspace, the ABI is designed specifically to > +allow a kernel to audit the memory ranges used, without having to know the > +internal structure of sub-ops. > > The problem occurs when you a device model issues an hypercall that > includes references to user memory other than the operation structure > diff --git a/tools/libs/devicemodel/private.h b/tools/libs/devicemodel/private.h > index c4a225f8af..c24f3396bb 100644 > --- a/tools/libs/devicemodel/private.h > +++ b/tools/libs/devicemodel/private.h > @@ -1,8 +1,6 @@ > #ifndef XENDEVICEMODEL_PRIVATE_H > #define XENDEVICEMODEL_PRIVATE_H > > -#define __XEN_TOOLS__ 1 > - > #include > #include > #include > diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h > index ef7fbc0d3d..fa3f083fed 100644 > --- a/xen/include/public/hvm/dm_op.h > +++ b/xen/include/public/hvm/dm_op.h > @@ -25,9 +25,6 @@ > #define __XEN_PUBLIC_HVM_DM_OP_H__ > > #include "../xen.h" > - > -#if defined(__XEN__) || defined(__XEN_TOOLS__) > - > #include "../event_channel.h" > > #ifndef uint64_aligned_t > @@ -491,8 +488,6 @@ struct xen_dm_op { > } u; > }; > > -#endif /* __XEN__ || __XEN_TOOLS__ */ > - > struct xen_dm_op_buf { > XEN_GUEST_HANDLE(void) h; > xen_ulong_t size; > From xen-devel-bounces@lists.xenproject.org Fri Mar 12 07:32:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 07:32:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96858.183676 (Exim 4.92) (envelope-from ) id 1lKcHp-0004uj-Uw; Fri, 12 Mar 2021 07:32:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96858.183676; Fri, 12 Mar 2021 07:32:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKcHp-0004uc-Rc; Fri, 12 Mar 2021 07:32:41 +0000 Received: by outflank-mailman (input) for mailman id 96858; Fri, 12 Mar 2021 07:32:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKcHp-0004uW-3i for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 07:32:41 +0000 Received: from mail-wm1-x334.google.com (unknown [2a00:1450:4864:20::334]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a46377ee-2f46-4b33-b10e-6276af17b8ef; Fri, 12 Mar 2021 07:32:40 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id l19so3174561wmh.1 for ; Thu, 11 Mar 2021 23:32:40 -0800 (PST) Received: from ?IPv6:2a00:23c5:5785:9a01:d41c:67e5:a11f:43fe? ([2a00:23c5:5785:9a01:d41c:67e5:a11f:43fe]) by smtp.gmail.com with ESMTPSA id s18sm7584487wrr.27.2021.03.11.23.32.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Mar 2021 23:32:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a46377ee-2f46-4b33-b10e-6276af17b8ef DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2vLlMPsBQyKsFoewMMaHWk8ZTsxgQH5oRVh2R46t72I=; b=eRvxO3OGAh8x8s+TynQ7Qqc3QtYDI2+D5HRMO+W6qXwkTWKvw4ZHRjJq3w3HNt79s3 wK/B+6YiYJCSK/Ymqr49GsKrHXzrZa9HN5cmiaDP0jhbiaL1B4nReFSpiV3xL9qdVDEt +f/Zx0V12aKrSKs50Bxr4PS9za2RyfMnPF521YbpTkB49TKwp+MB5JSZVxkZ6WDslpeC uwCBLjeZDyPyTiObbs6tFqTaJT5iykEOoP/f9cQUKfkCAvV3iw5yMnjGDc+NObpR6Z4S 1BOkc+0kho1n01vhzcoXnJo3DUzf7q+TtDRRduA23Sn8VySUh2nBZw1k/kYW9ddJxaEG j78Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:cc:references :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=2vLlMPsBQyKsFoewMMaHWk8ZTsxgQH5oRVh2R46t72I=; b=bi7EGP4dzX3fdRm78VIHo9Cz134peI1D5Wi/870hDMuljn8UBSeLHxODZs/FF0E7Xl Abjj5O41GC2E+gHC93qBV84pdsyEdWY5VVI9RkNwm3bxPJxgHuHoQAKhie513FqoAuDK vpZ8lImiaO31sOPjJMaMmx805axaDr+hPrn9BE5kUmxfk/z811poyKLEBMzR27PutOM+ +OI+z+2uphzUWljswRTyfokl8JnL33p39W0OosYSpnT9E46VS1416kq5qrh2tJm+UWoc dkQ9iB4yOWn6xgP3WS1Hd957i+s3KgEENT7i7FlkpzbXU3361Om8L4Ynd8WDoXf+X6f8 Xs6Q== X-Gm-Message-State: AOAM532sjqqI7gJbF9SPqEp8zgdkVWZ1hU6EBcYKuS27FajUUVixC27E iCYwew3mMLK9F8OMzGva8rmoJ8HvP4o= X-Google-Smtp-Source: ABdhPJzU96plijb1/pNdMD1WsWX8VrvNK0AR4kCLhxXPrq8Xm20pf8hcvX6ZNj/+TL4Vzt3y7TBaCg== X-Received: by 2002:a1c:3b43:: with SMTP id i64mr11452642wma.43.1615534359651; Thu, 11 Mar 2021 23:32:39 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring To: ChiaHao Hsu , netdev@vger.kernel.org Cc: wei.liu@kernel.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org References: <20210311225944.24198-1-andyhsu@amazon.com> Message-ID: Date: Fri, 12 Mar 2021 07:32:38 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210311225944.24198-1-andyhsu@amazon.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/03/2021 22:59, ChiaHao Hsu wrote: > In order to support live migration of guests between kernels > that do and do not support 'feature-ctrl-ring', we add a > module parameter that allows the feature to be disabled > at run time, instead of using hardcode value. > The default value is enable. > > Signed-off-by: ChiaHao Hsu Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Mar 12 07:35:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 07:35:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96861.183687 (Exim 4.92) (envelope-from ) id 1lKcKQ-00052j-Bx; Fri, 12 Mar 2021 07:35:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96861.183687; Fri, 12 Mar 2021 07:35:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKcKQ-00052c-8w; Fri, 12 Mar 2021 07:35:22 +0000 Received: by outflank-mailman (input) for mailman id 96861; Fri, 12 Mar 2021 07:35:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKcKO-00052X-LD for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 07:35:20 +0000 Received: from mail-wm1-x333.google.com (unknown [2a00:1450:4864:20::333]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8b588686-2994-49da-a642-68750798844e; Fri, 12 Mar 2021 07:35:19 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id o26so3175920wmc.5 for ; Thu, 11 Mar 2021 23:35:19 -0800 (PST) Received: from ?IPv6:2a00:23c5:5785:9a01:d41c:67e5:a11f:43fe? ([2a00:23c5:5785:9a01:d41c:67e5:a11f:43fe]) by smtp.gmail.com with ESMTPSA id g9sm7188316wrp.14.2021.03.11.23.35.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Mar 2021 23:35:18 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b588686-2994-49da-a642-68750798844e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZWI2ifkumsHMtHtO5ppg2HtJpuKFgZtX+BsaiymIvC4=; b=ot/OEcyIZgPCJL/hr4PNayP7cYbzY6ItRaAYvzVLHB5Ye4Sfo+wGUqeikthnvxBawU j1IwRaSCOX1jzjPbo0h1qZMiO8MyRWI2OScN7AO5aGf6BFW8AO+2ZAqyk83JnfxMUXPo n2lxesXOJtCWPpzZbYPGvjmu1LYe+vZwVDwuzpj9EYZyEbE0lq4v0BTzGcAFYWw1tm3S y7+6lPlAY+aqi9ctcUmyvZaJxnCOH5Czk8gMZuVTYZIrjET/kXDxBX0JUk6fVJzeaDrx codZPwBX8nDPr6ZEV8ndaLa8TrWxSFK2UjVeAM741CyUhPBN0AtfypHvA7o4RiNwmdrJ 8fog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:cc:references :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ZWI2ifkumsHMtHtO5ppg2HtJpuKFgZtX+BsaiymIvC4=; b=mzTkDBawuwTNA9pmAxez7K/dI9wjR74TEU2xes2nLa4BMZNhN7UahlV76MWnRqpKm2 5pJ4r4HkByniO3gimIYuA07jjq7Z/IGZoYzLT8jSx8IHHcwJK9mk1RzHoV4O+fFzi8Lh vNP6CBF7cmA2p52c0XWWEf0lsBuWoaqhJ9LImiYfaZIblK/PQQJMWzLv7fVRQT5Y1V7r zZ5aavcpeeKcFil4FDH15SsEoyO2faKFW8uvO2Hzjs3S+rTlZbH4XC2d4UZDDLmjbKlK AAoo5VOy8apWHIn5VVctOo0qIyo0IohvZ1Vj25JdUgJVCkf3qsuE41trVfdhEC/aMybJ G84Q== X-Gm-Message-State: AOAM531GXbiLFzId3b2ozs+/K4yfM5JjoOJ2jxj9ocUFfsSbeQePzEOY p3MB5i3QIoFm4mzfPninTN7oMl53ViM= X-Google-Smtp-Source: ABdhPJxWdgEYz1BrD4aUPyoXz1qQnY243gERkEOoHnEvKzU5Xgr/RRtKiC96eNi7f9qlnHSpuIMY9Q== X-Received: by 2002:a05:600c:3650:: with SMTP id y16mr5771890wmq.182.1615534519041; Thu, 11 Mar 2021 23:35:19 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [net-next 2/2] xen-netback: add module parameter to disable dynamic multicast control To: ChiaHao Hsu , netdev@vger.kernel.org Cc: wei.liu@kernel.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org References: <20210311230035.24450-1-andyhsu@amazon.com> Message-ID: <341df30d-ece4-b01c-79c0-1727493b21b3@xen.org> Date: Fri, 12 Mar 2021 07:35:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210311230035.24450-1-andyhsu@amazon.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/03/2021 23:00, ChiaHao Hsu wrote: > In order to support live migration of guests between kernels > that do and do not support 'feature-dynamic-multicast-control', > we add a module parameter that allows the feature to be disabled > at run time, instead of using hardcode value. > The default value is enable. > > Signed-off-by: ChiaHao Hsu Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Mar 12 07:53:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 07:53:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96867.183705 (Exim 4.92) (envelope-from ) id 1lKccC-00076P-4R; Fri, 12 Mar 2021 07:53:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96867.183705; Fri, 12 Mar 2021 07:53:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKccC-00076I-1J; Fri, 12 Mar 2021 07:53:44 +0000 Received: by outflank-mailman (input) for mailman id 96867; Fri, 12 Mar 2021 07:53:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKcc9-00076B-Uq for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 07:53:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5531c1d5-b7c1-497f-94b5-3f42fe9f39e5; Fri, 12 Mar 2021 07:53:41 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3121CAEAE; Fri, 12 Mar 2021 07:53:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5531c1d5-b7c1-497f-94b5-3f42fe9f39e5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615535620; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RF0NUXMdM1b19HvTDj8cmhyUhkT2qR2UVX4/UdCwo30=; b=Fja+yea6BGMQHghgc9Mi5VglzHCTb8jXVEWd/RH5ghHclSsHKzgJudtI5HFtTehUT57G9s qTV7QrG0BMRXLRh9akuoPhUaWQT7/sudTHinnz1tNaAuka1lfgYzgvbes+NRn9Hu1rGt7W eF/wNQqiMcL8/DY1WG7AY/S3G237I68= From: Jan Beulich Subject: [PATCH v3 0/2][4.15] x86: guest MSR access handling tweaks To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson Message-ID: <7a84bc56-0045-2111-6888-8db830335ad1@suse.com> Date: Fri, 12 Mar 2021 08:53:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Addressing review feedback, albeit some of it still looks to be stalled. But I didn't want to wait longer. 1: PV: conditionally avoid raising #GP for early guest MSR reads 2: AMD: expose HWCR.TscFreqSel to guests Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 07:54:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 07:54:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96870.183717 (Exim 4.92) (envelope-from ) id 1lKcdE-0007D4-EE; Fri, 12 Mar 2021 07:54:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96870.183717; Fri, 12 Mar 2021 07:54:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKcdE-0007Cx-BH; Fri, 12 Mar 2021 07:54:48 +0000 Received: by outflank-mailman (input) for mailman id 96870; Fri, 12 Mar 2021 07:54:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKcdD-0007Cq-3h for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 07:54:47 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 13a0468d-786a-44ed-ac97-7dd026bcde6c; Fri, 12 Mar 2021 07:54:46 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5E509AE5C; Fri, 12 Mar 2021 07:54:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13a0468d-786a-44ed-ac97-7dd026bcde6c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615535685; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZvlKusSXHPm7ZHxV0KpYOFnqvBFQX3cO0pgsQ+grOaw=; b=gJRvwZ9/oXAkoWXNHmCWHY3833IWChRX6+a5cMQGHPYMvv6+SwiXaWYZ0AUi/OsEuRzu+T yVz7NPAzfUcP3YGc3F3wGNvfcGonRYgc0BuaV1+x8Q1NLhFtDmoWbTP54HtGFteaH2t9qp geewSvja4HoYtKJUKsdHs12uHhgDDjI= Subject: [PATCH v3 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: <7a84bc56-0045-2111-6888-8db830335ad1@suse.com> Message-ID: <90f87aa8-09da-1453-bd82-c722465c2881@suse.com> Date: Fri, 12 Mar 2021 08:54:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <7a84bc56-0045-2111-6888-8db830335ad1@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Prior to 4.15 Linux, when running in PV mode, did not install a #GP handler early enough to cover for example the rdmsrl_safe() of MSR_K8_TSEG_ADDR in bsp_init_amd() (not to speak of the unguarded read of MSR_K7_HWCR later in the same function). The respective change (42b3a4cb5609 "x86/xen: Support early interrupts in xen pv guests") was backported to 4.14, but no further - presumably since it wasn't really easy because of other dependencies. Therefore, to prevent our change in the handling of guest MSR accesses to render PV Linux 4.13 and older unusable on at least AMD systems, make the raising of #GP on this paths conditional upon the guest having installed a handler, provided of course the MSR can be read in the first place (we would have raised #GP in that case even before). Producing zero for reads isn't necessarily correct and may trip code trying to detect presence of MSRs early, but since such detection logic won't work without a #GP handler anyway, this ought to be a fair workaround. Signed-off-by: Jan Beulich Release-Acked-by: Ian Jackson --- (projected v4: re-base over Roger's change) v3: Use temporary variable for probing. Document the behavior (in a public header, for the lack of a better place). v2: Probe MSR read. Exclude hypervisor range. Avoid issuing two log messages (in debug builds). Don't alter WRMSR behavior. --- While I didn't myself observe or find similar WRMSR side issues, I'm nevertheless not convinced we can get away without also making the WRMSR path somewhat more permissive again, e.g. tolerating attempts to set bits which are already set. But of course this would require keeping in sync for which MSRs we "fake" reads, as then a kernel attempt to set a bit may also appear as an attempt to clear others (because of the zero value that we gave it for the read). Roger validly points out that making behavior dependent upon MSR values has its own downsides, so simply depending on MSR readability is another option (with, in turn, its own undesirable effects, e.g. for write-only MSRs). --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -874,7 +874,8 @@ static int read_msr(unsigned int reg, ui struct vcpu *curr = current; const struct domain *currd = curr->domain; const struct cpuid_policy *cp = currd->arch.cpuid; - bool vpmu_msr = false; + bool vpmu_msr = false, warn = false; + uint64_t tmp; int ret; if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) @@ -882,7 +883,7 @@ static int read_msr(unsigned int reg, ui if ( ret == X86EMUL_EXCEPTION ) x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); - return ret; + goto done; } switch ( reg ) @@ -986,7 +987,7 @@ static int read_msr(unsigned int reg, ui } /* fall through */ default: - gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); + warn = true; break; normal: @@ -995,7 +996,19 @@ static int read_msr(unsigned int reg, ui return X86EMUL_OKAY; } - return X86EMUL_UNHANDLEABLE; + done: + if ( ret != X86EMUL_OKAY && !curr->arch.pv.trap_ctxt[X86_EXC_GP].address && + (reg >> 16) != 0x4000 && !rdmsr_safe(reg, tmp) ) + { + gprintk(XENLOG_WARNING, "faking RDMSR 0x%08x\n", reg); + *val = 0; + x86_emul_reset_event(ctxt); + ret = X86EMUL_OKAY; + } + else if ( warn ) + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); + + return ret; } static int write_msr(unsigned int reg, uint64_t val, --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -143,6 +143,12 @@ typedef unsigned long xen_ulong_t; * Level == 1: Kernel may enter * Level == 2: Kernel may enter * Level == 3: Everyone may enter + * + * Note: For compatibility with kernels not setting up exception handlers + * early enough, Xen will avoid trying to inject #GP (and hence crash + * the domain) when an RDMSR would require this, but no handler was + * set yet. The precise conditions are implementation specific, and + * new code shouldn't rely on such behavior anyway. */ #define TI_GET_DPL(_ti) ((_ti)->flags & 3) #define TI_GET_IF(_ti) ((_ti)->flags & 4) From xen-devel-bounces@lists.xenproject.org Fri Mar 12 07:55:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 07:55:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96873.183729 (Exim 4.92) (envelope-from ) id 1lKcds-0007JC-OF; Fri, 12 Mar 2021 07:55:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96873.183729; Fri, 12 Mar 2021 07:55:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKcds-0007J5-Ke; Fri, 12 Mar 2021 07:55:28 +0000 Received: by outflank-mailman (input) for mailman id 96873; Fri, 12 Mar 2021 07:55:27 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKcdr-0007Iw-QL for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 07:55:27 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0a0919ba-7553-4536-bdf4-56da87783299; Fri, 12 Mar 2021 07:55:27 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 77D18AEBD; Fri, 12 Mar 2021 07:55:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a0919ba-7553-4536-bdf4-56da87783299 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615535726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QFrMh+sBcKyoQb7P1wDYHd/74ZilGORQiERspE6maW0=; b=KtRStRZOrHCb5Rt5wy5ejseMiiAj5FHplLDzGS073uFJHjNfYG35dR0ItdR1XSDeeAfg4D SrEhhS7/lar4n3MPM+bPdS2SQrYX+WW5atT61RjslCXNi0w5Nn+m24Abvt2sHjocRbEGrP SO14KwmWzHMIRYoo/cNfUl7oGqAUpdU= Subject: [PATCH v3 2/2][4.15] x86/AMD: expose HWCR.TscFreqSel to guests From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: <7a84bc56-0045-2111-6888-8db830335ad1@suse.com> Message-ID: <414cceb7-003b-527d-7472-447be325dc14@suse.com> Date: Fri, 12 Mar 2021 08:55:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <7a84bc56-0045-2111-6888-8db830335ad1@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Linux has been warning ("firmware bug") about this bit being clear for a long time. While writable in older hardware it has been readonly on more than just most recent hardware. For simplicitly report it always set (if anything we may want to log the issue ourselves if it turns out to be clear on older hardware) on CPU families 10h and up (in family 0fh the bit is part of a larger field of different purpose). Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné --- v3: Report 0 for Fam0F. v2: New. --- There are likely more bits worthwhile to expose, but for about every one of them there would be the risk of a lengthy discussion, as there are clear downsides to exposing such information. The more that it would be tbd whether the hardware values should be surfaced, and if so what should happen when the guest gets migrated. The main risk with making the read not fault here is that guests might imply they can also write this MSR then. --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -315,6 +315,13 @@ int guest_rdmsr(struct vcpu *v, uint32_t *val = msrs->tsc_aux; break; + case MSR_K8_HWCR: + if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) + goto gp_fault; + *val = get_cpu_family(cp->basic.raw_fms, NULL, NULL) >= 0x10 + ? K8_HWCR_TSC_FREQ_SEL : 0; + break; + case MSR_AMD64_DE_CFG: if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) goto gp_fault; --- a/xen/include/asm-x86/msr-index.h +++ b/xen/include/asm-x86/msr-index.h @@ -287,6 +287,8 @@ #define MSR_K7_HWCR 0xc0010015 #define MSR_K8_HWCR 0xc0010015 +#define K8_HWCR_TSC_FREQ_SEL (1ULL << 24) + #define MSR_K7_FID_VID_CTL 0xc0010041 #define MSR_K7_FID_VID_STATUS 0xc0010042 #define MSR_K8_PSTATE_LIMIT 0xc0010061 From xen-devel-bounces@lists.xenproject.org Fri Mar 12 07:58:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 07:58:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96878.183745 (Exim 4.92) (envelope-from ) id 1lKcgZ-0007g3-EA; Fri, 12 Mar 2021 07:58:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96878.183745; Fri, 12 Mar 2021 07:58:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKcgZ-0007fw-Az; Fri, 12 Mar 2021 07:58:15 +0000 Received: by outflank-mailman (input) for mailman id 96878; Fri, 12 Mar 2021 07:58:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKcgX-0007fo-EN for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 07:58:13 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:fe05::62a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b7d64351-ef96-4cc5-a8d2-c8cbcfce4a86; Fri, 12 Mar 2021 07:58:11 +0000 (UTC) Received: from AM5PR0202CA0010.eurprd02.prod.outlook.com (2603:10a6:203:69::20) by DB9PR08MB6844.eurprd08.prod.outlook.com (2603:10a6:10:2a6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Fri, 12 Mar 2021 07:58:09 +0000 Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:69:cafe::d9) by AM5PR0202CA0010.outlook.office365.com (2603:10a6:203:69::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Fri, 12 Mar 2021 07:58:09 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Fri, 12 Mar 2021 07:58:09 +0000 Received: ("Tessian outbound e7a0046930fb:v71"); Fri, 12 Mar 2021 07:58:08 +0000 Received: from f2bd0746487e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4E1696EB-1BEC-45C5-8F10-3B514756F1D2.1; Fri, 12 Mar 2021 07:58:03 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f2bd0746487e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 12 Mar 2021 07:58:03 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VI1PR08MB4045.eurprd08.prod.outlook.com (2603:10a6:803:dd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.29; Fri, 12 Mar 2021 07:58:01 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3912.030; Fri, 12 Mar 2021 07:58:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7d64351-ef96-4cc5-a8d2-c8cbcfce4a86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yRHEgE2s3aK/DfilkpZqg2QbZfFmk6MMUG7VO5LcJ+I=; b=4MNHjQZRLgtM0rE/5NnPXYFdOXqBumoHM1QhC3CONxMM4+lV/bej+FiY1FQyUGNwLnPh56KwMAGiP9uMQOGjT9sEp/tuk/mt0Q8khrO0223VZKW858gX3MfQiqtiYTJxnFAs8Wh6KUQL2EfBxIhZSsKa3f21hmv3E0qT6p9SAiI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: ead942b6c3717a04 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iDPltf6DzK79ih4iKbgCxcWv/TiHgZwHq5YRDJcbbl07o8TiHacmsbmcKxRLkQz2iKdFDf+OASXsJ8wEWk834SWEGakAsNZvhNij8NLHPLp30NhgPlDqpD7Sn6EiwAwkGf7o5PdEJLu/68uqUZHJWAqHaduUUIT+v/pp+cp4ZoiJZMdUIW6Q2/TUZaqXKLfnYtjL1wiEiw2+ZgXwPajfdHSZpOkKI+MSnynTtspNCUEO2qw8pPVEQSjEKPBqUleXes6Mej0wL0QEPlofL7vSpR+svNnasGLP5TPbDxzT87MgaTHQPp5fENCgVJMh4RKZwF+sLqlxjBxxq+grqTZsyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yRHEgE2s3aK/DfilkpZqg2QbZfFmk6MMUG7VO5LcJ+I=; b=jPJFx1pGnxGv9ikAlTMj08QBI0/+X7TIJrl/bAMUAS5tsiRQ7F6Bk2pHSylCchgfEgVJqmfZDcjjoJq5bB2NbzL9xpEUKKy/bUnjL15GlDfg97E2sA5/Tn2Y9XKEbikgwc65s3UP+3LXC6hmA4CARGLFHh3CM4hNaAMrFodNZHZVL9U/IuLbBsc3eHM74bkjKtBjefajHK/JkC1b+YoauZL4iyVKvF6ZE7IFYLlMNvVXqJsRwT4+IS08GJqP84s3ygE+jgrVwYrWGwNPZuB+4SXZUQ6AtATUgBYP8Obga2LNJN2iz/NLc4ZHR0wl3nmAtl8LbEJQxHr6VnmPwnEUlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yRHEgE2s3aK/DfilkpZqg2QbZfFmk6MMUG7VO5LcJ+I=; b=4MNHjQZRLgtM0rE/5NnPXYFdOXqBumoHM1QhC3CONxMM4+lV/bej+FiY1FQyUGNwLnPh56KwMAGiP9uMQOGjT9sEp/tuk/mt0Q8khrO0223VZKW858gX3MfQiqtiYTJxnFAs8Wh6KUQL2EfBxIhZSsKa3f21hmv3E0qT6p9SAiI= From: Bertrand Marquis To: Rahul Singh CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH 0/5] xen/arm: smmuv1: Fix stream match conflict issue Thread-Topic: [PATCH 0/5] xen/arm: smmuv1: Fix stream match conflict issue Thread-Index: AQHXFRDsfmQEpjwmUkeZqlC6XkDzOqqAALUA Date: Fri, 12 Mar 2021 07:58:00 +0000 Message-ID: <40B7A7BD-6E2F-4493-A9FC-1BFFCBC237AF@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [2a01:cb10:335:200:4546:4473:bf12:4b83] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1e17348a-2282-40d0-1b00-08d8e52c93a8 x-ms-traffictypediagnostic: VI1PR08MB4045:|DB9PR08MB6844: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:972;OLM:972; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XAuy//kdZrFyX2S7Kv13VGLIEnhQR50TKeTbQA7rcrwO9mChimega4D2F81Ql37RKp5vs2mPIXNs4RZRTdB67kPoKOkBKIKPj5wInn4RatV+L/XixmnKR1OjUrwu03fgtp4Z+on0JzAjU1vlX59oGDuga21rNTdzLHU1KGdud7hA5D0TGyJq5Ga+l/SDFKZE7VHxZi/1fca2txu3x+vwOLfUufODjabLXLD21gsqtnKL5e6rR/UEBB7AQpVcXSn3uHvoyCT6O27HorDopuD56gJ3QTwBDemHdAu8XSh84/Ry5YFN3/VQDqwHeKy4fnIOCZjCEuTGIrdDzxfglT39f+m/bvOMvMENctV5epO1s2XCGn13cAK2ewmXG0qmd227rcg9q4ZL1m+3vP4/TI4SIshtRPdvsm/wkXiwX0TN9wNPobyCqjU/Vr7m6BCQnzRVN4g8Bx5q7PmzYguGRDaxnQGS0kb7Ssmn4ycrbjncZIXGT4cWrbhEPTqjdFoQmWV4qsZ1TXYX5leigj24jIrtPYNEgsFmVzpHG+hKzzFAlawRVoTCumF/+Cxsm1U5wPtTFNr+ADf2NxvcVwCbDbok0w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(39850400004)(376002)(136003)(346002)(6506007)(6512007)(4326008)(36756003)(6636002)(83380400001)(6486002)(66556008)(86362001)(186003)(5660300002)(316002)(33656002)(8936002)(54906003)(71200400001)(2906002)(8676002)(66446008)(6862004)(64756008)(478600001)(2616005)(76116006)(91956017)(66946007)(66476007)(53546011)(37006003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?kKIJykfW8DCgEVGDLBQCCCC13HFPjqaq7e20utybi7EDYz2INEbzJo7ykTpX?= =?us-ascii?Q?TaAlqbgMwfsT1sIatG5GIql+0XItXPzOGqNFjWzkjKsT96akMrP1ToTXGftm?= =?us-ascii?Q?rzgcB5QBoMoAqQSA2qPiJC2NSEX6ZRARmaycMcU265M8xiK6wnXyjW+3Ksqi?= =?us-ascii?Q?RaCLLcGCnCfIpqOCUm7NvyedV53kpmohtd0ZSoTaPpON8maRPv4/M0erIAxq?= =?us-ascii?Q?1ueevv6Qg5iXLGSpNKRcQYI0Px975T0YiQI61AL8WcgiFSwO+k8y9PXLGiBE?= =?us-ascii?Q?/B/R//LfPmUSSMKuV5CTLv2qt6s26rLN02zfT0kFavg2yUIutaK07J0jMPsZ?= =?us-ascii?Q?tfhLj+C99uMFsSP1qeBvddpvUunxHt/tpYOBF6JWOVM84TIa71EOxXpeY2MO?= =?us-ascii?Q?lQeE0qck7eKWw+6CAfNnLHkVY6IEO5aFjyI1UWOP6zTXdquLJrSHWBbmMs5w?= =?us-ascii?Q?C9mOnObxpFViHbuMsBIoP1XXL/WQraGkNgb1W5UJeuol0qvSRNHRQFH86iNJ?= =?us-ascii?Q?CPLQqN411rEJ6KHLULRZYiF94oR9Kc2HGRfVIjg0R6NkKfaayZZBUSL3n+4h?= =?us-ascii?Q?aQNrKA1hKWVFwEAcKB7U7pZLTyt6p3D0n+nr+6TWWA9i8GEjHwVabFN2ufu/?= =?us-ascii?Q?zKWopYa7vDYcfWMP+eGix33KBGASqeEtc5B0M7fhMdKLXx4sjhDGY+th6eXa?= =?us-ascii?Q?l7faudn6DA8b0Uwvy22qSIlNPLS3DcHzW5yeGou5YnfodWUqO07s/006DSn4?= =?us-ascii?Q?8pVaY1WYhAO4lWJSfORpGLSZCxh+wDY05vcs7ZLz9moL2enRsso7S6K5C7B4?= =?us-ascii?Q?w4Ew3neDjiQnp2lzcX2VYwzy1ajk2wnUZFFAQ5dBdian+ePXIBO4VUBWIr7W?= =?us-ascii?Q?bgiPUJeCoAzyou7ynaWiUc2FVhaA2VQ+ydn8tyomskkVafVaOxZLlYYjnMnk?= =?us-ascii?Q?anoZbURCFzaJySPqGYQT55NPEUucT9aV+ppOX9Bzku+n7komBklbM0UKiK4I?= =?us-ascii?Q?VJ9CkbISrMgP2+0lU1pKF82WOluGGG3a3scAy4/RuylVEGMDIpUDzWxhGvta?= =?us-ascii?Q?W0d68BTHNf9xdn8UobgUyFv1qntFQ3W+Y1n6Yfliid7lJS2tOBPNE6Mxs/WT?= =?us-ascii?Q?+Z84PttntkNxuQU+cPzjS23KhYKVmR4CSN99AUaDRAADiB5x3RHgTDRtYZVa?= =?us-ascii?Q?rXkbtrRL0VXwyGs+IFN8PueCYfGhtkuhiC3lKoG/PVJM8LAksYHL9DFlvQB3?= =?us-ascii?Q?VXuamh773+9f/LLExZumlLxMItH1Fwzky9FDO7oJitwpv6KAJQ+VgklecOeG?= =?us-ascii?Q?9g7QrbuQQTooihPkzpAMK5iplTy49YQnuPPWGSVH74EF3ClKN5ap0PGeXaX7?= =?us-ascii?Q?Y9tWrvYSyXVi6EnKhf7Z4aNkmrcx?= Content-Type: text/plain; charset="us-ascii" Content-ID: <84E759FD70BCBA41B0604B4F3CCC3183@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4045 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 6ccc7805-0428-4d98-21b2-08d8e52c8eb4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: La12LJ0N/gNUMRyJ/XDhI7z1kEyFWNzOJQcs8pqmrtD/QRpno5CEFb1DKFD0RqNW93ja5Ybw7sOAC/u/1C6v8ZVzcoy8xDxlyoTf6r/4iNJA97TyL/9V0do3qpH1voajUlM7XrERiucfXbEbdhjEy+fsNyfaf+9atpmVzmh78jFf3MATaL60AAvsxsCnkeUWTF/Ra9o+W+XnBCie/ZyLuwECxYuB4Tx0975KHVj5ksonONB1DphOaydQHy2OCFWl6Aj7Mny7IkGTElg39gGFO1JSR0PzH6WCZ34Q/YmAEHy+02xUD+XBeYVjZmWw5/meZyGzFGV4G/eCa+aVjYoC+JyqFfF8JKHNqVVJEDyfZ+KD/OFfknsmluVWPSfs4pfMQT1rssqrynHVxOKaASjVviZC1e0MDSacrliVOvEHW4KjsykREY7j+zc7ra/lJvRAFG5rONoAJnXoDAwzzgzcJRIIF9J8TAJhMhTMtsH653dBblYq7iEs5jUfFH0C3VDRZyQQFE9b723/qg6XKnSJ7lupKxpdtPfYnISpnor5kFQV9bpmzMc1p8Gn+j7IwRehYzkEc6qUC5zputLl+NdTPnOj4tHTv5TlsRyZUq4GWW9YpB83eGY3DZH2RRm2ORAZ5PforOqOyKL/jMZ5BchxFdNjzi8Y4ejcMGUnukGVoZk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(39850400004)(396003)(376002)(346002)(36840700001)(46966006)(81166007)(6486002)(316002)(47076005)(107886003)(36860700001)(6512007)(54906003)(8676002)(82310400003)(6506007)(86362001)(53546011)(356005)(5660300002)(83380400001)(2616005)(2906002)(8936002)(37006003)(336012)(36756003)(70586007)(4326008)(70206006)(26005)(33656002)(6862004)(6636002)(186003)(478600001)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 07:58:09.0245 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1e17348a-2282-40d0-1b00-08d8e52c93a8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6844 Hi Rahul, > On 9 Mar 2021, at 19:19, Rahul Singh wrote: >=20 > This patch is the work to fix the stream match conflict issue when two de= vices > have the same stream-id. >=20 > Approach taken is to merge the below commit from Linux driver to fix the > issue. >=20 > 1. "iommu/arm-smmu: Handle stream IDs more dynamically" > commit 21174240e4f4439bb8ed6c116cdbdc03eba2126e > 2. "iommu/arm-smmu: Consolidate stream map entry state" > commit 1f3d5ca43019bff1105838712d55be087d93c0da > 3. "iommu/arm-smmu: Keep track of S2CR state" > commit 8e8b203eabd8b9e96d02d6339e4abce3e5a7ea4b > 4. "iommu/arm-smmu: Add a stream map entry iterator" > commit d3097e39302083d58922a3d1032d7d59a63d263d > 5. "iommu/arm-smmu: Intelligent SMR allocation" > commit 588888a7399db352d2b1a41c9d5b3bf0fd482390 >=20 > Rahul Singh (5): > xen/arm: smmuv1: Handle stream IDs more dynamically > xen/arm: smmuv1: Consolidate stream map entry state > xen/arm: smmuv1: Keep track of S2CR state > xen/arm: smmuv1: Add a stream map entry iterator > xen/arm: smmuv1: Intelligent SMR allocation >=20 > xen/drivers/passthrough/arm/smmu.c | 423 ++++++++++++++++++----------- > 1 file changed, 262 insertions(+), 161 deletions(-) For the whole serie: Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 > --=20 > 2.17.1 >=20 From xen-devel-bounces@lists.xenproject.org Fri Mar 12 08:06:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 08:06:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96887.183763 (Exim 4.92) (envelope-from ) id 1lKco4-0000gq-Iw; Fri, 12 Mar 2021 08:06:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96887.183763; Fri, 12 Mar 2021 08:06:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKco4-0000gj-FV; Fri, 12 Mar 2021 08:06:00 +0000 Received: by outflank-mailman (input) for mailman id 96887; Fri, 12 Mar 2021 08:05:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKco3-0000ge-Pw for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 08:05:59 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 545b1657-72a5-4fe9-a7f1-321e1d4a88eb; Fri, 12 Mar 2021 08:05:58 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EA5EFAEE5; Fri, 12 Mar 2021 08:05:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 545b1657-72a5-4fe9-a7f1-321e1d4a88eb X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615536358; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qd94mhiIll1PT567Y9ofX2pAQv+9TAJVnchcqrr4mzw=; b=iQRI3JISfROPypTv2V6bdHSTvxjg3jqePjstUhXgE0rP9tc3sNHtYMpcnm7EoHE2PmlduA 91Vw3qXXO4kywo58bgcJ3oi3/c0q1Rp+npnRmb091xapWm5R7ORbNJ/xU5U/rAK4HvE1H1 zrs+g8uWaDmYy98F755n69gWi9TeV4g= Subject: Re: Working Group for Secure Boot To: Bob Eshleman Cc: Andrew Cooper , George Dunlap , piotr.krol@3mdeb.com, Olivier Lambert , Xen-devel References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> From: Jan Beulich Message-ID: <8cdd96ef-0f54-dea0-5d90-8f1c46be40ff@suse.com> Date: Fri, 12 Mar 2021 09:05:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11.03.2021 19:34, Bob Eshleman wrote: > We would like to start a working group for secure boot support in Xen > to coordinate the various interested parties and set out a plan for > the feature and its implications for the whole Xen system. > > The end goal is a full implementation that restricts the interfaces > dom0 has to affect Xen, akin to Linux's lockdown LSM. This implicates > important parts of the ABI (e.g., /dev/xen/privcmd/) and so will > require input from the greater community. > > I'm not familiar with how working groups function in the Xen project, > so this email also opens the floor for suggestions as to how this might > be managed. > > We'd love to hear from anyone interested in such a group and how the > community as a whole feels about such an effort. I'm definitely interested, but I'm uncertain if a WG is the way to go here. There may be a lot of corners to touch, and hence a lot of people to consult. While it may be possible to have a pretty large WG for this reason, it may well be better to have the discussions on xen-devel right away, and form WGs only when more narrow sub-aspects need sorting out. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 08:34:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 08:34:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96900.183794 (Exim 4.92) (envelope-from ) id 1lKdFE-0003mY-5j; Fri, 12 Mar 2021 08:34:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96900.183794; Fri, 12 Mar 2021 08:34:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKdFE-0003mR-2h; Fri, 12 Mar 2021 08:34:04 +0000 Received: by outflank-mailman (input) for mailman id 96900; Fri, 12 Mar 2021 08:34:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKdFC-0003mM-Tp for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 08:34:02 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dcdb0e91-dfea-4bfb-8628-6d8f90f2c8ef; Fri, 12 Mar 2021 08:34:01 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CDA75AF33; Fri, 12 Mar 2021 08:34:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dcdb0e91-dfea-4bfb-8628-6d8f90f2c8ef X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615538040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kpL+Xtl6biqMgc7I3UVtrZgaY5rgIReHpDQzGV19roM=; b=is0Vpu7wzLDbgPxrjU0azVYRPXXlKjoS7/kJNwO/QJ8BbtsTQmoNfz+jMVrAmxpcuddRUh FTb+YbXHma1xou0jd3NPhxw+J7Xm3fUVhtl2O2mGAbIkrI3IjZ6mopGmImMbOfpZTEb2Mx 7RlvAUBhugZgJm2iUMLtXT1YJ7jZcRs= From: Juergen Gross To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com Subject: [GIT PULL] xen: branch for v5.12-rc3 Date: Fri, 12 Mar 2021 09:34:00 +0100 Message-Id: <20210312083400.2594-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.12b-rc3-tag xen: branch for v5.12-rc3 It contains two patch series and a single patch: - a small cleanup patch to remove unneeded symbol exports - a series to cleanup Xen grant handling (avoiding allocations in some cases, and using common defines for "invalid" values) - a series to address a race issue in Xen event channel handling Thanks. Juergen arch/arm/xen/p2m.c | 5 +- arch/x86/xen/p2m.c | 6 +- drivers/pci/xen-pcifront.c | 4 +- drivers/xen/events/events_2l.c | 22 ++++-- drivers/xen/events/events_base.c | 130 +++++++++++++++++++++++++++-------- drivers/xen/events/events_fifo.c | 7 -- drivers/xen/events/events_internal.h | 14 ++-- drivers/xen/gntdev.c | 54 +++++++++------ include/xen/grant_table.h | 7 ++ include/xen/xenbus.h | 1 - 10 files changed, 169 insertions(+), 81 deletions(-) Jan Beulich (4): Xen: drop exports of {set,clear}_foreign_p2m_mapping() Xen/gntdev: don't needlessly allocate k{,un}map_ops[] Xen/gnttab: introduce common INVALID_GRANT_{HANDLE,REF} Xen/gntdev: don't needlessly use kvcalloc() Juergen Gross (3): xen/events: reset affinity of 2-level event when tearing it down xen/events: don't unmask an event channel when an eoi is pending xen/events: avoid handling the same event on two cpus at the same time From xen-devel-bounces@lists.xenproject.org Fri Mar 12 08:45:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 08:45:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96904.183812 (Exim 4.92) (envelope-from ) id 1lKdQQ-0004tZ-Dd; Fri, 12 Mar 2021 08:45:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96904.183812; Fri, 12 Mar 2021 08:45:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKdQQ-0004tS-9f; Fri, 12 Mar 2021 08:45:38 +0000 Received: by outflank-mailman (input) for mailman id 96904; Fri, 12 Mar 2021 08:45:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKdQP-0004t7-0N for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 08:45:37 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 64586895-11fd-46c6-aee8-15d1d89af5a0; Fri, 12 Mar 2021 08:45:35 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0CE1EAF39; Fri, 12 Mar 2021 08:45:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64586895-11fd-46c6-aee8-15d1d89af5a0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615538735; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/fnIlZATBHUFmI4G1S8Zhc4vjygJLmS5ZGQ/SPaaRsc=; b=oCxLRgcp6kEl4U7811tB5kasuTgWBDUugdQfAA2oYsakNWbORHVeGMUnhI4Lx9Xv4yWT9a le0ZhcRKakEsN1WGibYhY5YOC4Ogr9+RexibIDgWrhX4soCoUxRZCbkuaQiSkU0OWgZ+sW deKVypQcNeS48+BHUx5qNMIC2EbACk4= Subject: Re: [PATCH v2 1/2][4.15] tools/x86: don't rebuild cpuid-autogen.h every time To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Ian Jackson , Andrew Cooper , Wei Liu References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> <1b8aee19-9194-153c-8dbb-0aec3412e255@suse.com> From: Jan Beulich Message-ID: Date: Fri, 12 Mar 2021 09:45:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11.03.2021 16:29, Roger Pau Monné wrote: > On Thu, Mar 11, 2021 at 03:40:05PM +0100, Jan Beulich wrote: >> The first thing the "xen-dir" rule does is delete the entire xen/ >> subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a >> result there's no original version for $(move-if-changed ...) to compare >> against, and hence the file and all its consumers would get rebuilt >> every time. Instead only find and delete all the symlinks. >> >> Fixes: eddf9559c977 ("libx86: generate cpuid-autogen.h in the libx86 include dir") >> Signed-off-by: Jan Beulich >> --- >> v2: Different approach. >> --- >> Ian did suggest to pass -0r to xargs (and -print0 to find), but I >> couldn't convince myself that these are standard compliant options. We >> don't use any special characters in file names, so -print0 / -0 >> shouldn't be necessary at all. The stray rm invocation when there is no >> output from find can be taken care of by passing -f to it. > > Why not use `-exec rm -f {} +` instead? That seems to be part of > POSIX and is likely nicer than piping to xargs? I've looked around some more and also remembered an aspect because of the looking around. 1) xargs has special provisions to not overrun argument space (leaving a gap of 2048 bytes). Nothing like this is said in the spec for find, and in fact I recall having had issues when the accumulated arguments needed splitting. This was on an old distro, but I wanted to mention it. 2) I've found (old) indications that the {} may be troublesome to some distros (Solaris was mentioned) and might need quoting. (This would of course be easy to deal with.) Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 09:09:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 09:09:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96913.183833 (Exim 4.92) (envelope-from ) id 1lKdnA-0007Fb-Is; Fri, 12 Mar 2021 09:09:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96913.183833; Fri, 12 Mar 2021 09:09:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKdnA-0007FU-FR; Fri, 12 Mar 2021 09:09:08 +0000 Received: by outflank-mailman (input) for mailman id 96913; Fri, 12 Mar 2021 09:09:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKdn9-0007FP-13 for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 09:09:07 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 82f122f8-a63a-4a9d-bb7c-ccb06753dac9; Fri, 12 Mar 2021 09:09:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82f122f8-a63a-4a9d-bb7c-ccb06753dac9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615540144; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=378qcNixXSwSV7WZBQWsevkgR8pimNwXN5aigWCHbC8=; b=a96GKs9xp/8AwPskMWyQ0ZAMhqFsX4R2lmh7T9bq3gvHjigRzpjydw2S 3311yZxoGRZSdkFKcbuGuufj6vJmkaJNc35L4PXn24+u3i+GsvF/dRLvc siQ7BMmy5gTLejzu9MxhH9TMLIr9HDC3+CjoLJuHv9W8rym2CihEhmdad 0=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: swwvuahnNB5VfZDgcfvlqvSCCpLJuuNWK+GzZhDBfOmdApXllrMh9wVTZ/CIibnXOsqAqnspP2 1BXRNZA1caGgnRIhrUDO7Z3wC6q+uedpJBY4K/ZPeOm+zTpkT0YaI90WSuQiTbt65uaRQYktPP 4DXbF0PGCcmd5xEeFLc4imlnl6x7OS7rKDLnFdJbQb/LxUiXEEHcBbvRUPhf5QTLtwvLNNgBRV Fn9cHVgvSpodDKSkAaOk5chq1YjWcogrEVOKVvxNuigntePEEaObXdh4aIfRJLXk9t1ugBCikv /SQ= X-SBRS: 5.2 X-MesageID: 39498421 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:c6nJdag2CVO13SlUUTX3BhDZQnBQX3tw3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+csFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmup tIW5NVTOf9BV0St6rHySGzGdo43Z2j+Kenme/Rwx5WPH1XQotLhj0JbjqzOEtwWQVAGN4dHJ 2T+sJIq1ObCAsqR+68AWQIWPWGms3TmPvdEFA7LjMEyC3LtzOn77bmDwOVty1+bxpjyaovmF K16zDRyb6kt5iAu33h/k/Vq69bgd7wjuZEbfb89/Q9DhXJpkKWaJ96W7uE1QpF4d2HzFoxit HDr1MBEq1ImgjsV1q4qxfsxAXsuQxGgxSJpD/o4kfLmsD3SCk3DMBMn+tiA2HkwnEtoc1m1+ Zz13+Z3qAnVi/opjj35NTDSnhR5y2JiEciiuIagjh+VoYTedZq3PUi1X5VC5sJEWbG7pkmGo BVfafhzctRGGnqCkzxjy1K+piBT34zFhCJTgwpocqOyQVbm3h/0g8x2NEftm1ozuN8d7B0o8 D/doh4nrBHScEbKYhnAv0afMexAmvRBTrRLWOpJ0j9Hq1vAQOPl7fHpJEOoM26cp0By5U/3L 7bVklDiGI0c0XyTeqDwYNM6RKIZGmmRzzixoV/6vFCy//BbYuuFRfGZEElksOmrflaKNbcQe yPNJVfBOKmInDpHYpPwg3iS5hfIXQTS6Quy5IGcmPLhviOBpzht+TdfvqWDqHqCywYVmT2BW ZGXDWbHrQG0mmbHlvDxDTBUXLkfULyubhqFrLBwuQVwI8RcolFsg0fj0Wl9tiGQAcy9JAeTQ 9bGvfKg6m7rW658SLj9GNyICdQCU5T/fHnSHNFpQgDNkvuarYds9CDeWRftUH3YyNXfofzKk pytl538aW4I9i73iY5Ee+qNWqckj8Ovn6QVowdnaeC/M/hfZs9Av8dKfVMPDSOMyYwtRdhqW 9FZgNBe1TWESn2j765yLYOAvvEStV6iAC3AMJdpH7Fr3+ArcU3SnZzZU/3beenxSIVAxtdnB lY7rIWirvoo0fQFUIPxMADdGBqREvSKrRcFwiBbJhTgdnQCXBNZFbPoyebhRE1cnft7GMIiA XaXHepUPnWH1tQvW1Z2K728FVyMn6QZV50d2oSi/wPKU3DoHZr5+qCbaa3yQKqGys/6/BYPz ffbTQIJARyg9ixyR6OgT6HUW4r35M0I4XmffgeWqCW3nOmM4uTk64aW/dS4ZZ+Ldjr29V7G9 63akuQLDniDfku1BHQrnE5ODNsoH1hlf/zwhXq4Cy523E4aMCibWhOVvUeI9uG6XLjSOvN2J Jljcgtte/1K37vcLe9uOjqRi8GLgmWrX+9Tukup5wRtaUutKFrF52eVTfTznlI0Bg3Mc+crj JQfI1rpLTafoN/dc0bfCxUukAkk9mCN0MnuA37CO1WRyBns1bLe9eSp7bYo7smBUOM4BbqMV 6E6itH4rPLWTCA2bNyMdNHHU1GLEwnrHJs8+OJe9eOVEGkd+Rf8EG7NXH4erlHU6SBEagRqB E/49zgpZ7iSwPonATL+T18KeZS9mziR8W4CgeFA/RJ/Ny3Ik7kuNrj3OejyDPsDSKmYEEZj5 BffUMebs5fmiAv5bdHpxSaW+jyuAY5iFNQ7jFsi0711oWn6GndG1taMQexuOQgYRBDdn6Sjc rE9uCE1HPypDhdsKOzZnttQg== X-IronPort-AV: E=Sophos;i="5.81,243,1610427600"; d="scan'208";a="39498421" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fFwILX97UcbEOKdBMCdzDBsNl7mMvRtI9vkrv+SCvVp+ml9cfATbcuW/WEGums8gFcLn1RLDm185q5A24x9/YSifWJDa5qd8emuYufwJc/kXviZIVKhnF0xHrsPapspJXlWzWgI2nm67dowHH+Z3BSlILcZgkf8ZKdq5BFpYpOxxb5FZrV5Dls8/o+uzVmZSDBSWLTWT4kSW8XvTpXbq6H0RoJw1UcUJA9dYM+gtUOZHlPL0xhPcVTdVuCHDV8LwP+Nhlf3SL5vfegut2iBZv6SZZ+w7Ayv93VvOpa3dwF66VCtLSbyZrMBQNDv5mlL6tz96Wku6FNnYWYm4mhy5Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QDW0PCDjN+tn7CYPrCPUjvIRmk30V9xvRTya61+pBzM=; b=hXLmCMokRyyaXnWtxsrAEGQSryZ4RaRSVlo91THYrA1f0BRAexSVEMrguVAXEJnOz1Mm11wug7pfyz4TuXSGlVL12mWY2h9ICiG9RC27XZeriXWop/lvl6beEbjTF+CNIVihJnC53+0K5GGX8FVHV3GHB5Pl0CMGH/Y/vEsJ+PLtlnkxpvi2V7UP3O8+HairSAWqfgMlUWhPSj+LE7hwN8GHT37j8d1BNZrGg8QgYgYHnfz4kjTIthRP6pQ4bMHhf/iWu7FCyKDlCjqbpMCbphU3uZNPOgEu+QnUDEWfUdmz6jaV/as1otY5mRxFsyh0SwYaRaU2+bGuBJtP4Ry73w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QDW0PCDjN+tn7CYPrCPUjvIRmk30V9xvRTya61+pBzM=; b=mHcx44E0XDTfqxECOYnqVnM21n/1GfivfCJieuTCEhVzm1uumLJww2/5cavg8JqPKj+zsux6idD32neORGCRD68WZ4NskI9z3vuevJpr7rn6zaTESwRphNXt8d20He6wYTLx9LzA+D1+34vh4YAru44yPl8+DEhYJ7ZaGyxR2i4= Date: Fri, 12 Mar 2021 10:08:52 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson Subject: Re: [PATCH v3 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads Message-ID: References: <7a84bc56-0045-2111-6888-8db830335ad1@suse.com> <90f87aa8-09da-1453-bd82-c722465c2881@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <90f87aa8-09da-1453-bd82-c722465c2881@suse.com> X-ClientProxiedBy: MR2P264CA0140.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::32) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f11af745-c8a6-415b-e399-08d8e53678e5 X-MS-TrafficTypeDiagnostic: DM5PR03MB2635: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EZHpJlNo3yukoQbo39A+lfDEX6zeakh+CNhlarPbraBrHx9E2QdkIxgHHKFXwPwqKiQ7H44JduIgLsyUVMrEkNZEVxw3jtSDh70X8ROlCAG011gSTu9Ia9nMvsbKEMF8bGFbpd7xhrL+zyBaBnA/aazKrgK0efWqDdylhcRGNu3vEl+EjSnDEfL8cOhkBRLAnZ6EvoKAMJEks4KI6I9fupbifeZHIofTOdbT14dNpLqJf+xX7CqKb7KuFH/02UW7/weeIuA9czDEiFUHr4GjbBSIv+yj3AHQtkEXIxs5t6vm2veb8B6/n4UVGf2QnokYBfsqt7mxDEZCbh9xUW0DwBxgl7LB1jLNmTJCcWVwfNKeWOCcKWD3RTpvLz7uhnENpm93CkYBHYmi0maJ2qDFQXnjSSGHy2nFhKcma1ehSVeRdRxMv6GvgaQRn7Zc+csRu/0gv7eTz7S11khv4umJgEO9ybg6v9WWcp8KCzlbv+OnKYQEk60fBgyJgLf5Q3pjyD1a5Hd/DEb7/Pl60vGlCw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(136003)(396003)(366004)(346002)(39860400002)(376002)(4326008)(186003)(2906002)(8936002)(8676002)(85182001)(26005)(5660300002)(956004)(16526019)(83380400001)(86362001)(66556008)(66476007)(66946007)(6666004)(478600001)(6916009)(54906003)(316002)(9686003)(6486002)(33716001)(6496006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dnVHRTE0YVBrQmFUV1NIZzJEazYzbkNHYkVJcWZ3ZXhHWXYwTGhDVEpYU1Zy?= =?utf-8?B?K0Q2SDRYdWhIdmNzMXZxTUErVmsrL29ZUVhuTEdPZXAxdlErdWh3SmJvdXY2?= =?utf-8?B?dE9jckc2Z0FJVjZ5ZlFtWmhkYlVjczNmWTRyd1NZYWRCMkt0Q3QrWjY3MHRt?= =?utf-8?B?d2ZvTFR2cyt2STRDWS9pY3VPdGJ6SUZEZjhDNG5uTmpnL2t4cS9IM3dHek9F?= =?utf-8?B?ekNGVFJTYkpqWXgyVEVXS0FTZTNibUluenRYNnJJMm9VYmovNWJLUzdVU25w?= =?utf-8?B?UmFYWThwTVg5QWNYTUxMcktDa0FBdmswdXZDVmwwSUZ3bHFBaFRLTWV3Ymg1?= =?utf-8?B?d25KMXVEb2oyU0UrRzgyamhFR1lTK0FLYU05WUduV240dUU4Nk1DWWJsMkZ4?= =?utf-8?B?ejFIbDZ4akQwSUtJOWFVb09NZ1RUVm1CeXJoMC9UQ3FPTUlrZE5vU0dYbjE1?= =?utf-8?B?RzF5TFZpMHcwc0hxMXlrcXFCR0cvejdud2FhT1FkN1VQcmRKS2kzM21nNW16?= =?utf-8?B?NjlOZ2RuK3drQVdRRkFHTUZwM01yK0g2bmR1TnVkY09waUM1WDF5M2h5WEhp?= =?utf-8?B?UXdYTUk4Qkx1cG43cmxIQ3I1ZjdENFUzelFEUnVLeVR1NlYyeWc5eGpKOFQ4?= =?utf-8?B?ZjhlSWxvU05wWCtSaHdRbElyNm1UeDRSVDdvc0JHbjRac0FMWXZBYkI3K0gv?= =?utf-8?B?SGhNNXNLNmVmOENqeDVXREFxRHNtWDlkV0FBSmhWYTV5dmlVRlFEMHVlZDJr?= =?utf-8?B?eFFXa2s1cFlKbXA3ell4ODRRdnNjNHhSM0NBd1J1K1hSZm02ajJBNG8rM2JF?= =?utf-8?B?ck85bE1acmdwRXFyTHM4dmRyc0NwRXV1dmg5L3J4VE9UOU0yLzB5ZXJYRlI0?= =?utf-8?B?TU52emVQaFRiNGc2ZEFPUnhSZndTanFwNFdIUThJZUJFS1dtL1JJcE9nNW1r?= =?utf-8?B?U1NhNGhGbnE5TFNjazgzRmIzVEtybm1MYXNUUXg4VWJVbC9BYkpUYWFSdk82?= =?utf-8?B?T1ByT043dmVIalIxRUY2NzB3RkVFR3E5V2tJdStoS0loWmtCM2FMS0dlK0hp?= =?utf-8?B?YnI4dnV6VVNlSmE5eGFYUk1vUzNLeHBBMUUvY1psR3EvL01EWEF6RHIvVElI?= =?utf-8?B?K214WjM1U0hPYU95QmRNQ2YrZkJRcVFvMVVzcDVGaThFVHd1YVltQlFwd2Nz?= =?utf-8?B?TnlzZUQweUZKNHo4NFRxWGYvbG5jQ0FEcXlNQitvOTBlV2RzK0tiQ0VpTDRj?= =?utf-8?B?OEcxZjN1Tko3Q0k0Q0VFaXlHLytRenZKYkFJRnJxZHU3NlZXdVF5aUFDZ2o2?= =?utf-8?B?U0NyS0NEMFZFdTZCdWNFN2haWElSQlprZ3B0bFdwYks0Sk5jdU9vSVltTnNU?= =?utf-8?B?QmtWenk1R0VCRzg0YXVHZHhJQUpBME5ZVGdiNG5pZGlGTXZLaUFJSnN5ZXVO?= =?utf-8?B?bWdBejBRU01jSFF3d1FaODc1TkszbGd3V1dEMS94QURSaUp5YXFxZTJDQVlu?= =?utf-8?B?RFNyRGhNNExYT3VkQjQ2ZVdqUTFjRGFCK2diV25SNDN5YnZEY2g3RStuQlp2?= =?utf-8?B?MkkxY25DWnlKcmV0VW8vUFhaTlhuWVd4Q1g0dWJVeHhaeGl4WmhTdGtZWTV3?= =?utf-8?B?c1NHTUhlTDFFdWt6bVV5OFVnL05jYkxUQkJEVHRhVUJwNmQxSnA1SmtTTVVz?= =?utf-8?B?RFpwOTB3cC84V251QUM4Vkw4ZVlTd1o3NUlMV1VVNFA1alJRWHlqM1dvUDNx?= =?utf-8?Q?d5BNbHNpyVfMGg8qvuOMWhQ+yeOOBVZyxTo5sa3?= X-MS-Exchange-CrossTenant-Network-Message-Id: f11af745-c8a6-415b-e399-08d8e53678e5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 09:08:59.3287 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0PZ0YsaPmOQh+7gBqx3WSdY+CLEaAFx5TBcXjl26cuOVej55gaO/Se1UnJtBN3GxEuAXyWKIlNrPvAvCB5HIWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2635 X-OriginatorOrg: citrix.com On Fri, Mar 12, 2021 at 08:54:46AM +0100, Jan Beulich wrote: > Prior to 4.15 Linux, when running in PV mode, did not install a #GP > handler early enough to cover for example the rdmsrl_safe() of > MSR_K8_TSEG_ADDR in bsp_init_amd() (not to speak of the unguarded read > of MSR_K7_HWCR later in the same function). The respective change > (42b3a4cb5609 "x86/xen: Support early interrupts in xen pv guests") was > backported to 4.14, but no further - presumably since it wasn't really > easy because of other dependencies. > > Therefore, to prevent our change in the handling of guest MSR accesses > to render PV Linux 4.13 and older unusable on at least AMD systems, make > the raising of #GP on this paths conditional upon the guest having > installed a handler, provided of course the MSR can be read in the first > place (we would have raised #GP in that case even before). Producing > zero for reads isn't necessarily correct and may trip code trying to > detect presence of MSRs early, but since such detection logic won't work > without a #GP handler anyway, this ought to be a fair workaround. > > Signed-off-by: Jan Beulich > Release-Acked-by: Ian Jackson I think the approach is fine: Reviewed-by: Roger Pau Monné Some comments below. > --- > (projected v4: re-base over Roger's change) > v3: Use temporary variable for probing. Document the behavior (in a > public header, for the lack of a better place). > v2: Probe MSR read. Exclude hypervisor range. Avoid issuing two log > messages (in debug builds). Don't alter WRMSR behavior. > --- > While I didn't myself observe or find similar WRMSR side issues, I'm > nevertheless not convinced we can get away without also making the WRMSR > path somewhat more permissive again, e.g. tolerating attempts to set > bits which are already set. But of course this would require keeping in > sync for which MSRs we "fake" reads, as then a kernel attempt to set a > bit may also appear as an attempt to clear others (because of the zero > value that we gave it for the read). Roger validly points out that > making behavior dependent upon MSR values has its own downsides, so > simply depending on MSR readability is another option (with, in turn, > its own undesirable effects, e.g. for write-only MSRs). > > --- a/xen/arch/x86/pv/emul-priv-op.c > +++ b/xen/arch/x86/pv/emul-priv-op.c > @@ -874,7 +874,8 @@ static int read_msr(unsigned int reg, ui > struct vcpu *curr = current; > const struct domain *currd = curr->domain; > const struct cpuid_policy *cp = currd->arch.cpuid; > - bool vpmu_msr = false; > + bool vpmu_msr = false, warn = false; > + uint64_t tmp; > int ret; > > if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) > @@ -882,7 +883,7 @@ static int read_msr(unsigned int reg, ui > if ( ret == X86EMUL_EXCEPTION ) > x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); You might want to move the injection of the exception to the done label? So that we can avoid the call to x86_emul_reset_event. > > - return ret; > + goto done; > } > > switch ( reg ) > @@ -986,7 +987,7 @@ static int read_msr(unsigned int reg, ui > } > /* fall through */ > default: > - gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); > + warn = true; > break; > > normal: > @@ -995,7 +996,19 @@ static int read_msr(unsigned int reg, ui > return X86EMUL_OKAY; > } > > - return X86EMUL_UNHANDLEABLE; > + done: > + if ( ret != X86EMUL_OKAY && !curr->arch.pv.trap_ctxt[X86_EXC_GP].address && > + (reg >> 16) != 0x4000 && !rdmsr_safe(reg, tmp) ) > + { > + gprintk(XENLOG_WARNING, "faking RDMSR 0x%08x\n", reg); > + *val = 0; > + x86_emul_reset_event(ctxt); > + ret = X86EMUL_OKAY; > + } > + else if ( warn ) > + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); I think you could add: if ( rc == X86EMUL_EXCEPTION ) x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); > + > + return ret; > } > > static int write_msr(unsigned int reg, uint64_t val, > --- a/xen/include/public/arch-x86/xen.h > +++ b/xen/include/public/arch-x86/xen.h > @@ -143,6 +143,12 @@ typedef unsigned long xen_ulong_t; > * Level == 1: Kernel may enter > * Level == 2: Kernel may enter > * Level == 3: Everyone may enter > + * > + * Note: For compatibility with kernels not setting up exception handlers > + * early enough, Xen will avoid trying to inject #GP (and hence crash > + * the domain) when an RDMSR would require this, but no handler was > + * set yet. The precise conditions are implementation specific, and You can drop the 'yet' here I think? As even if a handler has been set and then removed we would still prevent injecting a #GP AFAICT. Not a native speaker anyway, so I might be wrong on that one. > + * new code shouldn't rely on such behavior anyway. I would use a stronger mustn't here instead of shouldn't. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Mar 12 09:17:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 09:17:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96920.183848 (Exim 4.92) (envelope-from ) id 1lKdvU-0008MP-Nn; Fri, 12 Mar 2021 09:17:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96920.183848; Fri, 12 Mar 2021 09:17:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKdvU-0008MI-Jf; Fri, 12 Mar 2021 09:17:44 +0000 Received: by outflank-mailman (input) for mailman id 96920; Fri, 12 Mar 2021 09:17:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKdvS-0008MD-UZ for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 09:17:42 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bf8f147a-f303-4c1d-a304-04fe09e113ba; Fri, 12 Mar 2021 09:17:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf8f147a-f303-4c1d-a304-04fe09e113ba DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615540660; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=W3px+BUg/rTI+S1HncfRe1xwPoKeUxUtH4x33O16eBM=; b=DpKDCjsOtY0OqGJxL89+D2oO2ExpgpujIfIlOy7dKeuNwaRTjfVqN58g Rb+cIz8a42GYEqVQopdhgOGnp6h7YgSWzgEOZchKSVV/4tDjv8L5YqiQ6 sWT0X+/h3XmSEkfLwk1NzPRjIP8hrCKheHZxhJVgH7jTu3ruzqVzktVyk E=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: zBaAJxJi7sVu5ZNg+6xKSpVMBcDcFXxfABl4ZwDezWOGVJlfluVIAgmkXioDB3aFzOciJaS4+U ke9hggUxurxCRtixRSa5mXgdCGYMQkHIrLZN13ja07GclfExOPzqDqiHQPgPSoldeoe55OEsY5 0fymLuijjiojSmVyXwVc9fMOJhS/zXjKnGp1EK0x4RboyZH50ObPRJRW89g9Rq0/fO/VxY7ZRa fnwVTAmC2c1zVhL5SfAQ3EhEo1h2lwbK2olThU20TeI2uER7zM/0xyh/TIsQJQXnJ2pFus1JZk iHs= X-SBRS: 5.2 X-MesageID: 39498830 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:W+kDaqDM6p12wRXlHeh+sceALOonbusQ8zAX/mhsVB1YddGZnc iynPIdkST5kioVRWtIo729EYOLKEm9ybde544NMbC+GDT3oWfAFvAH0aLO4R3FXxf/+OlUyL t6f8FFYuHYIFBmga/BjzWQPM0nxLC8npyAocf74zNTQRpxa6dmhj0JbzqzNkFtXgFJCd4YOf Onl6l6jgGtc3gWcci3b0NtN4T+jubGiY78Zlo+DwMngTPksRqT9LX4HxKEty1uMQ9n/LFKyw n4uj283IqPmbWRyhjQ12jchq4m5efJ+594K+GnzuQQIjXooA60aIpmQK3qhkFInMifrGwEvf OJjxA8P9liy365RBDLnTLdnzPO/Rxry3j+xUSWiXHuyPaJOg4SOo56qq9yNj76gnBQ2+1U4e Zw8E+y86dzN1fmmh/w4tDZPisa7XackD4ZvsM4y0BEXZB2Us42kaUvuHl7Pb0nByzA5IUuAI BVfbvhzccTS1+cYnzD11MfueCEbzA2FheCdEAIptaY5ThQhGx41EsV3qUk7w89yK4= X-IronPort-AV: E=Sophos;i="5.81,243,1610427600"; d="scan'208";a="39498830" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WQtADgaxehEK7j6KLDLkoGfr7fnuQZspHHGLjqthWGmRcasEy1w+pirEprCHE6mbCTCX12L/iUir7Aj3e/xvhbP2m5Ww3hHj5XRSRmepe46ELuvtC9gIL9rKQl9zrHPi4QwONZhQONiF6JQyKjaPzMcCsa206FNYnsJbfFt7Tm4zSZ50PA/+E+TPPkTivKuc3S4BjjJZlam2UTp642p1RI3BObtNK0rKM34qj09lHv6dGnbTsRX3YiGGI5QKKfT5ndlelUFGi8oMp9g8gueqHMyJKB/hYYqarP0MsK1BhpbwazgUSSBEwjlzhfqVIkI7Q3xuonTIKak3fDCxZ3Km/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WXEesVwcIzvJnI2AeWvQ2pA4aR7oZWJHG/XQjhGHEvU=; b=SB9f7OzjUrmmkEWqfYMNMb67KJWkdf+foFPaJuSwkTU+AQLLh6HHzK6YUwktHvAEF9Opm+o/SED2I/EAj77mPbMZMyK6XW0lckJt8MGuYFHsmwEITSRwDLjO30R9kPjkDSr3fmohI4VG4vHfcypSqEYZ5qA1SIYMIOQ3TUcxj3Ya7LrZ2cwE/i1sy4OR627VZbCRXl+p3T+FrtVzP7Kn8VnE/RN6phZIW5JV1rwy+tgV4r8tkd+UuxzHrGAikcx6CCxIThmMKXNFQob9cp49vlP0RP+DkUKLpJ4oTtCQiF6mmqcv4uQr88mi08f87lQae8pN2wwUSASnqNYI7+8C9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WXEesVwcIzvJnI2AeWvQ2pA4aR7oZWJHG/XQjhGHEvU=; b=XS5lj6CzITCH+8VF87sxww/197JNIB8GXN6tQh9aSsaFUNLAdmTQ9vYMIpCsRH0bEqku2TU7PMdqRDBx5DxYnHA/fDVRw0obK7m1uFYaQ4AGh7T5SuH2YdFPWI/TOwjy0/f7FJK2QGeiqjRBGBW33MBGp0hOqc8WSApqLH9BOX8= Date: Fri, 12 Mar 2021 10:17:31 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Ian Jackson , Andrew Cooper , Wei Liu Subject: Re: [PATCH v2 1/2][4.15] tools/x86: don't rebuild cpuid-autogen.h every time Message-ID: References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> <1b8aee19-9194-153c-8dbb-0aec3412e255@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: PR2P264CA0042.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101:1::30) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84942082-1f29-478a-8e9d-08d8e537ad9d X-MS-TrafficTypeDiagnostic: DM6PR03MB4762: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RHjBLzrmBxQaIkkvJ+R4Q++xzzBgLyvx9tYn4rN99uPbTUNi/2++SXoOjEyLpwVBX5kq8h9KZJFWd4De99P+iu67kgHFbl8QPGoAgQPIU4T8EXY7ZORZ9N0iLROdj3X3ALzvy8oru41U9+DD/OYTNCKFC/KBj+moiXPnklR1tAQeBmZ3feJ6ljCQM3+WWhaXedm9WlWcXtbq7yyVKiZ7K6Kz+yuzIBeZO3L/FIm2koTlxzb5XwJ0aG7k6Xqryj9pbWm51GPrUzRuLVHwuvaJ9EGz+93NVOOF7Xc0Q8GPyUBLP8rjwaY+35Btx2kO3pI347Bi5gBAKVdzY8gW32WcgA89ZFuSJIn05Z6VpXsNO8V2HOyhoRMCODbPb4pCxpbGdRGH61bRN+5ErudcWe7MaottrGSdmiS5o3ajYWTbFekK2prNVSqzDmT3UqxH2B0URRRTuzb+LowMYzO0BngIhSRFb4nSEUWj9uS7t2XaOiPQF1DopSqNDBJfdURn5aJv3+odwRRU9cOpiMzxaWAghA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(376002)(136003)(396003)(366004)(39860400002)(346002)(66946007)(66556008)(66476007)(8676002)(85182001)(956004)(16526019)(186003)(8936002)(478600001)(26005)(4326008)(6666004)(9686003)(6486002)(6916009)(54906003)(53546011)(316002)(2906002)(83380400001)(5660300002)(6496006)(33716001)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bDl5VzNaS01WWWhBZ25KbFJsZ05IZXpOMWpETVlpclJZai9rU2sxaXhjaFpn?= =?utf-8?B?T29IdS94M1doNzY4SC9QL3ZRM2xZakxHZHppSko4M3pZMWJJQk44YVMwajRY?= =?utf-8?B?VkdCMGlGQkFQSDZFSFhhbTdmWmF5UzVXWjFRMjNqZkdWMWpBL1hRRTl4SWYv?= =?utf-8?B?V2FJeVlOQlpDdU9HazAxQzNhWTZ4aGhYVXJybVNzdG53azJOZkFXaFNnU01V?= =?utf-8?B?ZUFPMTBGajdhYWtMWHZ6TGhRZWR0RDk0bHBuWWlxa2IzTFpyUTRKVDRreHdX?= =?utf-8?B?d3NOSjBMb1M4WEVkdlpiMDRRemZFcjlJQmZJYU1NUHdoR1JJRHY2MDJSTm5M?= =?utf-8?B?dlRaNlFsWGx0WVViNWRzSnpiT0dxSzFFSFd5cXFOVUh6WkF0OU9SVUhYVEs2?= =?utf-8?B?RWRPQi9QVTdHdzJxZVpWSW9XN0lVbk1HRWh6ek9rV2RMeUR3R0VmWlQ5RjRa?= =?utf-8?B?cUVJN1dJV0hJb1ZGd0k3QkpYcGo4eWdOYXlEQjc2UU5KWU5NaTIzU1M0M0dY?= =?utf-8?B?N3I2MG9VZGI5YUxpVUh6djNuSHZiaHQvNW1QdjM1MjVJT0drMmM1MW5ZbnZS?= =?utf-8?B?dFdDeWNwU3RFN3AwV2ROZ0RKajlSTW54N2I3UE1UTDI4TjNFOXV4TXBSZ1NO?= =?utf-8?B?RnFrQmJMcThRZUhjY0RtYlFjSitMWUo5dlZPdElLQm1mUUo1a2Jmc2VRcjc1?= =?utf-8?B?REo3RXF5ekhWbW1yZ1YrbDVuYWtoNGFIMyt5Wjg0eHhMSlRSajZndGppYnVq?= =?utf-8?B?RHdwV1BRYW1WWGFVZ0xUWHdyN1BJVkVCNysyZTZkQnd5VjZvQ1VsbmgweDMw?= =?utf-8?B?TTgzdTBMaDlma0pMMkk1eTlVaXRIb2NrcXg1dWZvbXRlOWxPSGxZTnlMWjU5?= =?utf-8?B?MC8rL0JPV2RVTFIwQ1Y5eXZjRnloM3JwRVdvdUgrc1BDQXdnZXZ2eDVySERD?= =?utf-8?B?WGpxdnN0NHNCSkdEWUdIVzhtd01hWFd1SkxWaDBvN2tMb0tGS3BRcWcvYmZM?= =?utf-8?B?cC93V25OdmhyMDh6RnM4b09FU2tsMFpUNTVZMngwTjZIVHM0WnVXaGhZamph?= =?utf-8?B?a2JYditBaHVxYmlOaUNQUEtXaWtrZUUrL3RGOVlFTDRHWnY4KytURldQbnJo?= =?utf-8?B?aFZvclhTZzdMNDkySlNkOXVxRmRWM21zVkpHc2prOHlIYncxTmsydGZoNk9n?= =?utf-8?B?ZW0vV2JwL25PdGwreVdQcURMdEwzWTRYTTV5N1REeEpBSXJNMit3ek5RWmNH?= =?utf-8?B?dTlVT3ZZTTZURTJOSllNN2NCZ05rMS9UTTAvWVBJelVjTE90eDdFMTJSaE84?= =?utf-8?B?TDYrdStGVFVSUVkyQSthTVJCL1VHTWRjZzdWZDhpdEFYL0NGakZZcnF2QWIy?= =?utf-8?B?dVk2N25lLzNCRlNXM1pGd1dSVWYvUVM0RXNvVHVQdGw0RVMvcjBrNEM4azFn?= =?utf-8?B?T3IvZVhuN1RDTWU2ZEhNV0lONUFvQVdtYnlKQjdoMkU5RTdDcXNnZFp3K2VU?= =?utf-8?B?ak5SVWcyNnBmZEFNWlloL2N6WmdXTHcvSjFVY2RZZGNkMUtVVlRON0gzMzFH?= =?utf-8?B?aG5xeDR0ZVNweW9ISnFvZG1oMXZnVFJIanVHbmVuWUdlY3FuYWF5VE1XUTEz?= =?utf-8?B?TE1QTjVlZmZIZVJONzBPZUY0bkxrYmQrdURnQy9hMGhyUENDRzZXalJGOC90?= =?utf-8?B?SmsrOVo4NG5pNGh0ekxGMHJvWUpvM1V5QTBvVXU1eUZLd1JSak5yYVlpUk5l?= =?utf-8?B?U1oxZ05MR1E0b3QyREU1SDNxcmkweEo3QzJuemxWRi9vdmZ0eUNHckR4VDdO?= =?utf-8?B?VlhaV1BQOEFhamh0d1EyUT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 84942082-1f29-478a-8e9d-08d8e537ad9d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 09:17:37.3632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qSXTNYzAcvvEQ5er83lqXCuosc7NMQtLvHwURZfJGMlK5DcfhLJ9VrWIw/BBEML4ceRNsV3E2Ew2co22YTQbnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4762 X-OriginatorOrg: citrix.com On Fri, Mar 12, 2021 at 09:45:35AM +0100, Jan Beulich wrote: > On 11.03.2021 16:29, Roger Pau Monné wrote: > > On Thu, Mar 11, 2021 at 03:40:05PM +0100, Jan Beulich wrote: > >> The first thing the "xen-dir" rule does is delete the entire xen/ > >> subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a > >> result there's no original version for $(move-if-changed ...) to compare > >> against, and hence the file and all its consumers would get rebuilt > >> every time. Instead only find and delete all the symlinks. > >> > >> Fixes: eddf9559c977 ("libx86: generate cpuid-autogen.h in the libx86 include dir") > >> Signed-off-by: Jan Beulich > >> --- > >> v2: Different approach. > >> --- > >> Ian did suggest to pass -0r to xargs (and -print0 to find), but I > >> couldn't convince myself that these are standard compliant options. We > >> don't use any special characters in file names, so -print0 / -0 > >> shouldn't be necessary at all. The stray rm invocation when there is no > >> output from find can be taken care of by passing -f to it. > > > > Why not use `-exec rm -f {} +` instead? That seems to be part of > > POSIX and is likely nicer than piping to xargs? > > I've looked around some more and also remembered an aspect because > of the looking around. > > 1) xargs has special provisions to not overrun argument space (leaving > a gap of 2048 bytes). Nothing like this is said in the spec for find, > and in fact I recall having had issues when the accumulated arguments > needed splitting. This was on an old distro, but I wanted to mention > it. Oh, the POSIX spec does note this: "The size of any set of two or more pathnames shall be limited such that execution of the utility does not cause the system's {ARG_MAX} limit to be exceeded." I would argue that not doing this is a bug. > 2) I've found (old) indications that the {} may be troublesome to > some distros (Solaris was mentioned) and might need quoting. (This > would of course be easy to deal with.) Hm, OK. I won't insist then. I'm not sure we should still consider Solaris as supported anyway. It's likely to explode in a lot of ways when trying to build. Do you really need the stderr redirection to /dev/null of find output when using xargs though? As that will just drop error messages, making failure diagnostic harder. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Mar 12 09:22:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 09:22:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96922.183860 (Exim 4.92) (envelope-from ) id 1lKe0J-0000mt-Br; Fri, 12 Mar 2021 09:22:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96922.183860; Fri, 12 Mar 2021 09:22:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKe0J-0000mm-7K; Fri, 12 Mar 2021 09:22:43 +0000 Received: by outflank-mailman (input) for mailman id 96922; Fri, 12 Mar 2021 09:22:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKe0I-0000mh-0Q for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 09:22:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e7f7924a-8723-45a0-bc89-56daae1c58f9; Fri, 12 Mar 2021 09:22:41 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2D05BAF4D; Fri, 12 Mar 2021 09:22:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7f7924a-8723-45a0-bc89-56daae1c58f9 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615540960; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iQVrKPMc99pqmPwKE5dFU/KjGNwV2O4V/pOsr/IY71U=; b=m9KwW0d087h8iZ4dKXEESQQoSSWuPIhFH3Oh+pqdh4cD3X65RVs5O4sefuJrxCWROnTXzU YvFQd8HZRcIXdFnbjuTa0jflvvc09uRmoO67KPUqn+wmPIdK56bYUl5tY3yW+LbYvdAURG WZ90oJzzXaRLtn4hE3AO1I1PNVNT+cY= Subject: Re: [PATCH v2 1/2][4.15] tools/x86: don't rebuild cpuid-autogen.h every time To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Ian Jackson , Andrew Cooper , Wei Liu References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> <1b8aee19-9194-153c-8dbb-0aec3412e255@suse.com> From: Jan Beulich Message-ID: Date: Fri, 12 Mar 2021 10:22:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 12.03.2021 10:17, Roger Pau Monné wrote: > On Fri, Mar 12, 2021 at 09:45:35AM +0100, Jan Beulich wrote: >> On 11.03.2021 16:29, Roger Pau Monné wrote: >>> On Thu, Mar 11, 2021 at 03:40:05PM +0100, Jan Beulich wrote: >>>> The first thing the "xen-dir" rule does is delete the entire xen/ >>>> subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a >>>> result there's no original version for $(move-if-changed ...) to compare >>>> against, and hence the file and all its consumers would get rebuilt >>>> every time. Instead only find and delete all the symlinks. >>>> >>>> Fixes: eddf9559c977 ("libx86: generate cpuid-autogen.h in the libx86 include dir") >>>> Signed-off-by: Jan Beulich >>>> --- >>>> v2: Different approach. >>>> --- >>>> Ian did suggest to pass -0r to xargs (and -print0 to find), but I >>>> couldn't convince myself that these are standard compliant options. We >>>> don't use any special characters in file names, so -print0 / -0 >>>> shouldn't be necessary at all. The stray rm invocation when there is no >>>> output from find can be taken care of by passing -f to it. >>> >>> Why not use `-exec rm -f {} +` instead? That seems to be part of >>> POSIX and is likely nicer than piping to xargs? >> >> I've looked around some more and also remembered an aspect because >> of the looking around. >> >> 1) xargs has special provisions to not overrun argument space (leaving >> a gap of 2048 bytes). Nothing like this is said in the spec for find, >> and in fact I recall having had issues when the accumulated arguments >> needed splitting. This was on an old distro, but I wanted to mention >> it. > > Oh, the POSIX spec does note this: > > "The size of any set of two or more pathnames shall be limited such > that execution of the utility does not cause the system's {ARG_MAX} > limit to be exceeded." Well, yes. Hence my referral to the extra precautions in xargs: "The xargs utility shall limit the command line length such that when the command line is invoked, the combined argument and environment lists (see the exec family of functions in the System Interfaces volume of IEEE Std 1003.1-2001) shall not exceed {ARG_MAX}-2048 bytes." > I would argue that not doing this is a bug. I agree, of course. >> 2) I've found (old) indications that the {} may be troublesome to >> some distros (Solaris was mentioned) and might need quoting. (This >> would of course be easy to deal with.) > > Hm, OK. I won't insist then. I'm not sure we should still consider > Solaris as supported anyway. It's likely to explode in a lot of ways > when trying to build. Right, I understand Solaris isn't the best example. I'd like to see what Ian says towards either of the options being better than the other. > Do you really need the stderr redirection to /dev/null of find output > when using xargs though? As that will just drop error messages, making > failure diagnostic harder. Well, yes, upon first build there would be error messages otherwise for xen/ and acpi/ not existing (yet). Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 09:32:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 09:32:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96931.183878 (Exim 4.92) (envelope-from ) id 1lKe9r-0001tO-EE; Fri, 12 Mar 2021 09:32:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96931.183878; Fri, 12 Mar 2021 09:32:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKe9r-0001tH-AT; Fri, 12 Mar 2021 09:32:35 +0000 Received: by outflank-mailman (input) for mailman id 96931; Fri, 12 Mar 2021 09:32:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKe9p-0001tC-Uh for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 09:32:33 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0956fa21-c2e0-44f1-b198-9333870e0ef9; Fri, 12 Mar 2021 09:32:32 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D04F6AF4D; Fri, 12 Mar 2021 09:32:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0956fa21-c2e0-44f1-b198-9333870e0ef9 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615541551; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mSzZ2e6C8lTfHbvkZr9jmUnRx9YHtfWraI8yj8ENVWA=; b=XKb7IbfkDY68QDySK6bwfTxgZHVo/se+daM16tQfA9G1iXSqx2lDcuTQEyzhf6cVi4KYs4 7HPRwEBKxBD1b+082zrj7AlA2/q3Rqnez0w9nGabVmqCHinmsddiR13dRJOwp92M4Ut/5i mI1/3o3mqqozDlX4y3FoV+LjFxGSAgs= Subject: Re: [PATCH v3 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson References: <7a84bc56-0045-2111-6888-8db830335ad1@suse.com> <90f87aa8-09da-1453-bd82-c722465c2881@suse.com> From: Jan Beulich Message-ID: <815584e1-2d0f-4119-e27d-cf897d1b8901@suse.com> Date: Fri, 12 Mar 2021 10:32:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 12.03.2021 10:08, Roger Pau Monné wrote: > On Fri, Mar 12, 2021 at 08:54:46AM +0100, Jan Beulich wrote: >> Prior to 4.15 Linux, when running in PV mode, did not install a #GP >> handler early enough to cover for example the rdmsrl_safe() of >> MSR_K8_TSEG_ADDR in bsp_init_amd() (not to speak of the unguarded read >> of MSR_K7_HWCR later in the same function). The respective change >> (42b3a4cb5609 "x86/xen: Support early interrupts in xen pv guests") was >> backported to 4.14, but no further - presumably since it wasn't really >> easy because of other dependencies. >> >> Therefore, to prevent our change in the handling of guest MSR accesses >> to render PV Linux 4.13 and older unusable on at least AMD systems, make >> the raising of #GP on this paths conditional upon the guest having >> installed a handler, provided of course the MSR can be read in the first >> place (we would have raised #GP in that case even before). Producing >> zero for reads isn't necessarily correct and may trip code trying to >> detect presence of MSRs early, but since such detection logic won't work >> without a #GP handler anyway, this ought to be a fair workaround. >> >> Signed-off-by: Jan Beulich >> Release-Acked-by: Ian Jackson > > I think the approach is fine: > > Reviewed-by: Roger Pau Monné Thanks. >> --- a/xen/arch/x86/pv/emul-priv-op.c >> +++ b/xen/arch/x86/pv/emul-priv-op.c >> @@ -874,7 +874,8 @@ static int read_msr(unsigned int reg, ui >> struct vcpu *curr = current; >> const struct domain *currd = curr->domain; >> const struct cpuid_policy *cp = currd->arch.cpuid; >> - bool vpmu_msr = false; >> + bool vpmu_msr = false, warn = false; >> + uint64_t tmp; >> int ret; >> >> if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) >> @@ -882,7 +883,7 @@ static int read_msr(unsigned int reg, ui >> if ( ret == X86EMUL_EXCEPTION ) >> x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); > > You might want to move the injection of the exception to the done > label? > > So that we can avoid the call to x86_emul_reset_event. At the expense of slightly more code churn, yes, perhaps. I have to admit though that it feels less prone to future issues to me to have an unconditional x86_emul_reset_event() on that path. >> --- a/xen/include/public/arch-x86/xen.h >> +++ b/xen/include/public/arch-x86/xen.h >> @@ -143,6 +143,12 @@ typedef unsigned long xen_ulong_t; >> * Level == 1: Kernel may enter >> * Level == 2: Kernel may enter >> * Level == 3: Everyone may enter >> + * >> + * Note: For compatibility with kernels not setting up exception handlers >> + * early enough, Xen will avoid trying to inject #GP (and hence crash >> + * the domain) when an RDMSR would require this, but no handler was >> + * set yet. The precise conditions are implementation specific, and > > You can drop the 'yet' here I think? As even if a handler has been set > and then removed we would still prevent injecting a #GP AFAICT. Not a > native speaker anyway, so I might be wrong on that one. Well, I've put it there intentionally to leave room (effectively trying to further emphasize "implementation specific") for us to indeed only behave this way if no handler was ever set (as opposed to a handler having got set and then zapped again). >> + * new code shouldn't rely on such behavior anyway. > > I would use a stronger mustn't here instead of shouldn't. Fine with me. I've been using "mustn't" in a number of cases in the past and was told I'm using it too often, sounding sort of impolite. I guess I'll switch to "may not", which was suggested to me as the better replacement. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 09:39:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 09:39:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96934.183890 (Exim 4.92) (envelope-from ) id 1lKeFx-0002Dw-4W; Fri, 12 Mar 2021 09:38:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96934.183890; Fri, 12 Mar 2021 09:38:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKeFx-0002Dp-1D; Fri, 12 Mar 2021 09:38:53 +0000 Received: by outflank-mailman (input) for mailman id 96934; Fri, 12 Mar 2021 09:38:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKeFv-0002Dk-Ll for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 09:38:51 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:fe0a::617]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e7ba6f57-67cf-4906-adae-a42aeec6fa1d; Fri, 12 Mar 2021 09:38:48 +0000 (UTC) Received: from AM6P195CA0094.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::35) by DB8PR08MB5500.eurprd08.prod.outlook.com (2603:10a6:10:11e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Fri, 12 Mar 2021 09:38:38 +0000 Received: from VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:86:cafe::ac) by AM6P195CA0094.outlook.office365.com (2603:10a6:209:86::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Fri, 12 Mar 2021 09:38:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT063.mail.protection.outlook.com (10.152.18.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Fri, 12 Mar 2021 09:38:38 +0000 Received: ("Tessian outbound ef5d1dda26b7:v71"); Fri, 12 Mar 2021 09:38:37 +0000 Received: from 856d3af5f2df.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 58E51A02-663D-481C-8E52-B575A4BB0855.1; Fri, 12 Mar 2021 09:38:29 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 856d3af5f2df.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 12 Mar 2021 09:38:29 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) by VE1PR08MB5694.eurprd08.prod.outlook.com (2603:10a6:800:1a3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.19; Fri, 12 Mar 2021 09:38:27 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642]) by VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642%4]) with mapi id 15.20.3912.030; Fri, 12 Mar 2021 09:38:27 +0000 Received: from a75445.arm.com (82.8.129.65) by LO4P123CA0326.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.26 via Frontend Transport; Fri, 12 Mar 2021 09:38:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7ba6f57-67cf-4906-adae-a42aeec6fa1d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ERAv7FfGgYFDZqJlst2ubagHKQTj1FMrXKJHLRQWBiQ=; b=dGVUtu4p2jA46P1/soroao/LswZnTwvmJRDLojLjFQo2kJLYu1A0Ofk+aRKD7dnxKigg05CegEN1pzhi5h9k7NILY/aCw/6vVAyPhzH9CdMzpT9LGUqDcCUJCo3VV2RTuL/PrqiB3N/fPFFn0aU4x0YfDFT1q/0xPnLfIsko6+U= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 8596e0d3ee419419 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HNsZbpGrGdQn9uICCOThiMpr/jMY6ClaODljTHIgtdSeY4xduVrvCT3wrYEkZUU/hv4WyBEgTQSPra0VMaXmq9BAmm4frARavfcGar3ejMDSSlWmwLZdLZCNX5/n/Gdnz0gYLLmhlAAvo8iY33G3CCENqAjtueoI5568JxxsFb5HpPIyFNgfmsRxHC41HTHh3/TpAgYVrOJnisO8SeZ+1nTm+enTtNwOfBZ4smxIILUHw4/4rigGvGJW5J/gw1Uzi5dB+V4/rW+JDOUIW2txcajZj/yLFAWLGGVsV1rY3nCLgpbE64bYNPqecUDz2yV34x+bFVmZbLU9uSAjCirnKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ERAv7FfGgYFDZqJlst2ubagHKQTj1FMrXKJHLRQWBiQ=; b=cQncl3kmRl/VdwatAfY4yXf53DiFwUlLz5fljQFbpqbKcxlg3lCc/gis3EO3F0ffUBP/bYfhCWBk0HUnQ0y4oAydxEiogliRMdYgduCj0MdvpjAD+xNzqGAFtOeb2gEK4VP+cqhMLdpCrPbB4FUjRcEYXiLA7dCEx/1E9WkMIwUkZlJPH4wMn0egBOjrTNSXpRUm8YtOMdNNW5C1cdEUuUj59brr3xPe6Nz4SOJCRa9mCym074vNPvplx1PtIfedHTZtia34OOr4+WWlVqeUcm/r1FkMG1FHor7jQo7Mm7P37oSZL3qCPB7v8eWPt+k/k9YuuKtCzg2goqqWifnrDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ERAv7FfGgYFDZqJlst2ubagHKQTj1FMrXKJHLRQWBiQ=; b=dGVUtu4p2jA46P1/soroao/LswZnTwvmJRDLojLjFQo2kJLYu1A0Ofk+aRKD7dnxKigg05CegEN1pzhi5h9k7NILY/aCw/6vVAyPhzH9CdMzpT9LGUqDcCUJCo3VV2RTuL/PrqiB3N/fPFFn0aU4x0YfDFT1q/0xPnLfIsko6+U= Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less From: Luca Fancellu In-Reply-To: <1921ff88-7637-6454-74a7-1cbab8dafc61@xen.org> Date: Fri, 12 Mar 2021 09:38:19 +0000 Cc: xen-devel@lists.xenproject.org, Volodymyr Babchuk , Bertrand Marquis , wei.chen@arm.com Content-Transfer-Encoding: quoted-printable Message-Id: <72E0C95C-D5E1-471B-9590-F4D42E3E066B@arm.com> References: <20210308115610.48203-1-luca.fancellu@arm.com> <1921ff88-7637-6454-74a7-1cbab8dafc61@xen.org> To: Julien Grall , Stefano Stabellini , Jan Beulich X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO4P123CA0326.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::7) To VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 78739d8e-63d5-46f1-1f87-08d8e53a9d6a X-MS-TrafficTypeDiagnostic: VE1PR08MB5694:|DB8PR08MB5500: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: B1oIFqtyE7rzSbZHpL692Qld1qIXh/rG580q6GS5LPAeSAMhQsRCd6dbFjJz1feeN0e33M7O/Untxyx8VdHZwkNb28ps5fdxq8EZO/buhKnBcOMU6oktahDG9E3UMNVW2+Cqtq1/5xW9OPmNLmu7HDZEGuPNQKq/6nDyIewbXu7o4G0xWQcu/quWci9y/akoEC5LzpgsHIH8uGgvkU6Qmfp+XMMiwKtF6mOH4LHJC4nxCoQ+Qm5hFG/LNljKlfoOWb4XLebV0O0nj0BYoPEBItzjP9jWPjVQEKaY2LEDC6291lPAX32pUGo+6amAudbQpZGgS3HERd+Mn0u92GS+037rVXNQbXXsw6uXfvEiFVWRVJOHA2zZHoZC2BknOYP8qDh9+WY0b0ZGUoXdJPz+A10K/UninK53sFCI5Nlz+yZepp18a9997vh7gzDnhw12jkmjOnDeN3GQGq9OmZCoM/vb+xVl8CLPaJuoQLDdW9NAanM6s7A0mxH4l8LYaFP9NoRqyhSvopkX1GqabNA3URSxlZUlrI9AraB3n2elabIFaoEymqHTYmqa9n4i+9Jp90c6DKhdbM6OvP4R9MAxvBFxdlmCW7Iu7N6W/iTv9wo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3629.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39850400004)(376002)(346002)(366004)(136003)(956004)(16526019)(6666004)(54906003)(53546011)(186003)(2616005)(6486002)(26005)(7696005)(110136005)(316002)(83380400001)(2906002)(52116002)(44832011)(4326008)(8936002)(8676002)(478600001)(66946007)(33656002)(86362001)(66476007)(5660300002)(36756003)(66556008)(32563001)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?RnppZ2lmdGNkQWVmMUU0K3dQWWZnNG9UaEMvWXkzR0RsdmtMcEV1VDE1RWFK?= =?utf-8?B?Y2ZxcXlGRUU3b2o5dW9xMWZvVGxVNWtPSnluZVg3SEJINnBTc1BUcURpT3R6?= =?utf-8?B?Z3dnVENjUjFHY2JBY3ZoK1VrMDBVVlJjdXNSWlRsNVRmd3dMRjhvZENYV2xp?= =?utf-8?B?QTdaZXFsdU5TaFllM0diRGlKV2RUdzV5MkxmWkxYbXNjaEtTTG9nU2JKT0l4?= =?utf-8?B?VUNXTm9udEpVS2hmWHZFWUN0d0F3ak5ka25BTkQ1U0lnc1lrdFk2Z0I1cXdD?= =?utf-8?B?ZVdlNFlyQkRRNU9CNkF4aW9sZHpHNnFseC9uUDk4SXVaOGY2UTVkcWpManZX?= =?utf-8?B?emlEaFRab3d3MDVlNVEvM28wOWMwaytHSTA4N2FXNzkrMm16aFVySTM0N3Nv?= =?utf-8?B?VGtzVHlTdnN2b3hjeE5od29zSHY0NzBoWTdFK2Z0NmNmemtkRUdhcitNN3NV?= =?utf-8?B?OHhyeCtzSW9IRTVZL2lpQWhFemVUaXhkRGNGREVraTlsa0xaMXJzL1owVXMx?= =?utf-8?B?WVRXVTcxbEkzemhMZjFaemt2UzRpZURHSmtkTi9ubVJiY3JqVy90MzlJN3dv?= =?utf-8?B?dFBEQjZHNFZpYlV3UDNIOXhsSUJteUJ1a3JiOU5yZmZuVFh5ZitEampaUW40?= =?utf-8?B?MHpXcS80dTdjbG5OU0tIYmNhdEFvQjhvaFNaTmhJMlVpN3pSQTZTVlJHcElZ?= =?utf-8?B?R0tUWTQ3RitaYTd5NGtXYk1QdW9PWDdKZzZUaW1ISGhCN1RKT0xUVnVoN0NH?= =?utf-8?B?cU9pZE9zWnFBMU90YWNvVU1zRW9OeFRiVUU5bUFqc2tSNHNhOEI2YjZwMnVu?= =?utf-8?B?Rmdnc056VVJMMHBFQWs1d0ZTbVRLK201ZzBvQTRreWhIZnJXY0dvYUVKUVFv?= =?utf-8?B?SXdzdXdqaitvOWJuOFJpWWFKR29PYnFQOEhHWGFndU1TVlM5TkJLV0ZZZm15?= =?utf-8?B?Sml0aktibEduSzlZMzBmQ3BMcEFnUmorTnZNREtLM3Q3bzMyN2xlN2FVanFt?= =?utf-8?B?ejJ3RGVrTUdoR0Fxb1BWNXI3WGZISC8xL2J1TFZaMHdzR2FOZDhVQU1rVEMx?= =?utf-8?B?ZExUZmJWMW1lMzZMckRlb1NSMDQxcjJheTFjc0RKS3ArdjdFZndBZ3NmOXJm?= =?utf-8?B?UVg1ZWd1aklCYjNQSS9JNzhZUFc1N2lXQUlIemY1cTl1amdPcE4zUFZtanVB?= =?utf-8?B?ek5jUTJGZGNxQlJWT1pKSDd6ZTZKMkd3WFVqYm9zbitlTlVBWk9RSVQvY1lr?= =?utf-8?B?bm9LdDdEZnl5dXJ4d29qTHNNWnVIczAxZEZYYWpiUEJqbml6c2t5RC9md1NM?= =?utf-8?B?WnhnVVQ5M01xdFpyQ1Z4NGxNS21SaCtSV3hpeFpJcU94QXhadnNtUTNEL3BY?= =?utf-8?B?eTljYTRWaGhDVWtzSVM0NXRVQ1hHdmlyejV1MlArenZSdHlFZVZxS1Q2L0VI?= =?utf-8?B?eHA3NmVEQnYwbFE5cDlaQSs4WGRhOXFndnhnZXl2M0tnNHo4QXgvWCtPaHlS?= =?utf-8?B?Y3grNDdMc1ZiVlNHSGZTaUhReGE0L1NvM0FyeHZ2aG1VS1RiUnlCaDREOEhN?= =?utf-8?B?QndXREZhbkw0c1MyRjB1eDZzb05ld3NMS2NEcVdRd2NVT2l3U3ppejBuL1Rr?= =?utf-8?B?WGhLTE5CNzN2bEp5VHlNNDhsczRpVVVTUmpic2QvdVNLUm5jRHNXTXMrVm9q?= =?utf-8?B?TDRWQjQ2UXVRVUF2QVE3ZC83MUJ6RnNiMUkvbXAySzlPZ1poeTJzU3lNbUJ4?= =?utf-8?Q?/Bkf5Ye8M0lILx7wvgdMJULooXN1cbZRakvvn3Z?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5694 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a19c8832-51bd-4ced-a2de-08d8e53a969a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: flZmkvaHNjmQJ5PWGBqiqE1JST2J+OeZKgiDHRyanE+xWsZg0g0TGRpsfoyw9WIffobfgPnyVscd+9bcYX+BFj5k1yvrZNlMwrW3P91abw30hbhAE2Z/XG1cF8eCYbWsq6qm63NYj9Y0unj+HEMCdTf3esYAXQOSivOgdAGgHEFlKRrBK4rSEWhuchgmXJBL3pnrLaEXnBLF57hEYc+0VDlADY3WAkXOg1qiO+eQfwUimOF1GKUSKOeW+kDC2M+UcSfpQMF0qU4VJCeRuMEFwhnbdUL5FokuIuwVntabCs3bHyaVpaCvTsOs6sBWkdecBvSaLSrcFTRccmBoh2K2UMujWXRTt6tkby5oT1hKiWsc56xBQKecUGjQr+4M1WQ3wbl/uPqZhXdfE2e3IfgrGeliSJu/+UjVTw3e9QLtsoSxPMQN5HUFaH9Kc+TSJTJb1WGxMNgZDsizJGXI0PjDQbPUEO0P40DxrFfzXysHQy+CGAuCMllJtOZ8+D5lJsu0Y9ARvnO4+fbvu2rjfEPAVVp0L+o3nVbdfxyEl8f7/Jq62qBvzNsd44UYz6YQYg1mgQh/MGASiyjSrk/14AC/RnfwMBeeKxnay/BGG8tjAhfLDMl+rsLz5MeXM9vmLS3XDGfKpwuyngfk8LPA63W4oUf36NZXpr2wUGDIHeuFvfi88gxffxlrNStOGUWoGwFw X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(376002)(346002)(39850400004)(136003)(36840700001)(46966006)(47076005)(2906002)(81166007)(82310400003)(6486002)(2616005)(186003)(36860700001)(356005)(16526019)(82740400003)(6666004)(26005)(956004)(8936002)(4326008)(478600001)(54906003)(316002)(70206006)(336012)(70586007)(110136005)(83380400001)(44832011)(7696005)(5660300002)(86362001)(8676002)(33656002)(36756003)(53546011)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 09:38:38.3077 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 78739d8e-63d5-46f1-1f87-08d8e53a9d6a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5500 Hi all, > On 8 Mar 2021, at 14:12, Julien Grall wrote: >=20 > Hi Luca, >=20 > On 08/03/2021 11:56, Luca Fancellu wrote: >> This patch prevents the dom0 to be loaded skipping its >> building and going forward to build domUs when the dom0 >> kernel is not found and at least one domU is present. >=20 > As you are skipping dom0, the domid 0 will not be usable for another doma= in. I can see a few issues: > 1) The first domU created will now be considered as the hardware domain= (see domain_create()). > 2) There are still a few hardcoded use of d->domain_id =3D=3D 0 in the= codebase (I could spot at least on in the RTDS code). > 3) Not all the code seems to be able to cope with hardware_domain is NU= LL (although most of it looks to be only reachable by x86)? > 4) is_hardware_domain() will return true when passing NULL. It is not c= lear whether one may pass NULL here. >=20 > For 2), ideally this needs to be fixed. But we may also want to reserve d= omid 0 just for sanity. >=20 > For 3) and 4), you will need to go through the code and check the usage. I=E2=80=99m investigating these points, but I agree with you all that domid= 0 should be reserved. >=20 >> Signed-off-by: Luca Fancellu >> --- >> xen/arch/arm/setup.c | 83 +++++++++++++++++++++++++++++++------------- >> 1 file changed, 59 insertions(+), 24 deletions(-) >> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c >> index 2532ec9739..6d169ff6ce 100644 >> --- a/xen/arch/arm/setup.c >> +++ b/xen/arch/arm/setup.c >> @@ -794,6 +794,35 @@ static void __init setup_mm(void) >> } >> #endif >> +static bool __init is_dom0less_mode(void) >> +{ >> + struct bootmodules *mods =3D &bootinfo.modules; >> + struct bootmodule *mod; >> + unsigned int i; >> + bool dom0found =3D false; >> + bool domUfound =3D false; >> + >> + /* Look into the bootmodules */ >> + for ( i =3D 0 ; i < mods->nr_mods ; i++ ) >> + { >> + mod =3D &mods->module[i]; >> + /* Find if dom0 and domU kernels are present */ >> + if ( mod->kind =3D=3D BOOTMOD_KERNEL ) >> + { >> + if ( mod->domU =3D=3D false ) >> + dom0found =3D true; >> + else >> + domUfound =3D true; >> + } >> + } >> + >> + /* >> + * If there is no dom0 kernel but at least one domU, then we are in >> + * dom0less mode >> + */ >> + return ( !dom0found && domUfound ); >> +} > Should the documentation be updated to reflect this change? Sure I will update the documentation in the v2 patch >=20 >> + >> size_t __read_mostly dcache_line_bytes; >> /* C entry point for boot CPU */ >> @@ -804,7 +833,7 @@ void __init start_xen(unsigned long boot_phys_offset= , >> int cpus, i; >> const char *cmdline; >> struct bootmodule *xen_bootmodule; >> - struct domain *dom0; >> + struct domain *dom0 =3D NULL; >> struct xen_domctl_createdomain dom0_cfg =3D { >> .flags =3D XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, >> .max_evtchn_port =3D -1, >> @@ -964,28 +993,33 @@ void __init start_xen(unsigned long boot_phys_offs= et, >> apply_alternatives_all(); >> enable_errata_workarounds(); >> - /* Create initial domain 0. */ >> - /* The vGIC for DOM0 is exactly emulating the hardware GIC */ >> - dom0_cfg.arch.gic_version =3D XEN_DOMCTL_CONFIG_GIC_NATIVE; >> - /* >> - * Xen vGIC supports a maximum of 992 interrupt lines. >> - * 32 are substracted to cover local IRQs. >> - */ >> - dom0_cfg.arch.nr_spis =3D min(gic_number_lines(), (unsigned int) 99= 2) - 32; >> - if ( gic_number_lines() > 992 ) >> - printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"= ); >> - dom0_cfg.arch.tee_type =3D tee_get_type(); >> - dom0_cfg.max_vcpus =3D dom0_max_vcpus(); >> - >> - if ( iommu_enabled ) >> - dom0_cfg.flags |=3D XEN_DOMCTL_CDF_iommu; >> - >> - dom0 =3D domain_create(0, &dom0_cfg, true); >> - if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) =3D=3D NULL) ) >> - panic("Error creating domain 0\n"); >> - >> - if ( construct_dom0(dom0) !=3D 0) >> - panic("Could not set up DOM0 guest OS\n"); >> + if ( !is_dom0less_mode() ) >> + { >> + /* Create initial domain 0. */ >> + /* The vGIC for DOM0 is exactly emulating the hardware GIC */ >> + dom0_cfg.arch.gic_version =3D XEN_DOMCTL_CONFIG_GIC_NATIVE; >> + /* >> + * Xen vGIC supports a maximum of 992 interrupt lines. >> + * 32 are substracted to cover local IRQs. >> + */ >> + dom0_cfg.arch.nr_spis =3D min(gic_number_lines(), (unsigned int= ) 992) - 32; >> + if ( gic_number_lines() > 992 ) >> + printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded= .\n"); >> + dom0_cfg.arch.tee_type =3D tee_get_type(); >> + dom0_cfg.max_vcpus =3D dom0_max_vcpus(); >> + >> + if ( iommu_enabled ) >> + dom0_cfg.flags |=3D XEN_DOMCTL_CDF_iommu; >> + >> + dom0 =3D domain_create(0, &dom0_cfg, true); >> + if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) =3D=3D NULL) ) >> + panic("Error creating domain 0\n"); >> + >> + if ( construct_dom0(dom0) !=3D 0) >> + panic("Could not set up DOM0 guest OS\n"); >> + } >=20 > It always felt a bit strange the dom0 creation is partly happening in set= up.c when for domU everythink will happen in domain_build.c. >=20 > Woule you be able to create a patch that will first move the code in a ne= w function (maybe create_dom0())? The function would return NULL in case of= an error or the domain. Yes I will create a new patch with this change and I will put on top the v2= dom0less patch >=20 >> + else >> + printk(XENLOG_INFO "Xen dom0less mode detected\n"); >> heap_init_late(); >> @@ -1003,7 +1037,8 @@ void __init start_xen(unsigned long boot_phys_off= set, >> if ( acpi_disabled ) >> create_domUs(); >> - domain_unpause_by_systemcontroller(dom0); >> + if ( dom0 ) >> + domain_unpause_by_systemcontroller(dom0); >> /* Switch on to the dynamically allocated stack for the idle vcpu >> * since the static one we're running on is about to be freed. */ >=20 > Cheers, >=20 > --=20 > Julien Grall Thank you for your feedbacks. Cheers, Luca From xen-devel-bounces@lists.xenproject.org Fri Mar 12 10:05:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 10:05:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96952.183919 (Exim 4.92) (envelope-from ) id 1lKef6-00058d-L6; Fri, 12 Mar 2021 10:04:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96952.183919; Fri, 12 Mar 2021 10:04:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKef6-00058W-IK; Fri, 12 Mar 2021 10:04:52 +0000 Received: by outflank-mailman (input) for mailman id 96952; Fri, 12 Mar 2021 10:04:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKef5-00058R-N7 for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:04:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKef5-0005E0-LB for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:04:51 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lKef5-0001SZ-KC for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:04:51 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lKeeu-0003SU-Ee; Fri, 12 Mar 2021 10:04:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=5EFwyi/1U7cGcp4J6tCUQbQYFIWfW9Mdj5LoNQxbRzo=; b=dEbZO8Y87HwwVdIO94zJDgnzao 0MEHA8mXZqzZLr7IZgKwGOf0e/tSttLjUeWiDIOZbsPopsiyhmCNoLv1s3qoE11K8AMVX3sIkqNtg 0gWO4f3qdhGuvi6AHtExCRqSnjoRcwHxx4pc5JFiT6qthyEk56Je4pMIE3pOWcV3IE8k=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24651.15544.142804.468744@mariner.uk.xensource.com> Date: Fri, 12 Mar 2021 10:04:40 +0000 To: Julien Grall Cc: Jan Beulich , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel\@lists.xenproject.org" Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning In-Reply-To: References: <6bd14438-7dec-2176-eab5-5898f190c4d8@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning"): > This is pretty much what we are already doing slowly by initializing > values to shut up older compilers. I agree this is more limited, but we > also waive off diagnostics from every single compiler in that code > rather than just one version. > > Hence why I suggested dropping -Werror for older compiler. This is not > ideal but it would give us the ability to keep support for dinausor > compiler and not hamper our ability to take advantage of newer compiler > diagnostics. I agree with Julien. I think we should avoid adding these redundant initialisers for the reasons he gives. > The ideal solution is to drop support for older compiler (see my other > thread). But this sounds like a daunting task so far on x86... > > Anyway, I will not Nack the patch but will also not Ack it. I will let > another maintainer ack this patch. But this is outside my usual area so I won't nack it either. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 12 10:13:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 10:13:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96960.183938 (Exim 4.92) (envelope-from ) id 1lKenm-0006Dl-NE; Fri, 12 Mar 2021 10:13:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96960.183938; Fri, 12 Mar 2021 10:13:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKenm-0006De-Ja; Fri, 12 Mar 2021 10:13:50 +0000 Received: by outflank-mailman (input) for mailman id 96960; Fri, 12 Mar 2021 10:13:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKenl-0006DZ-Eh for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:13:49 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 752a784f-ee79-409c-ad11-e1af094a0327; Fri, 12 Mar 2021 10:13:48 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BD554AF9F; Fri, 12 Mar 2021 10:13:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 752a784f-ee79-409c-ad11-e1af094a0327 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615544027; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sPiSkafLbbIKwYtj0VbdM45lHctMgoLsYxbNMURtuZ0=; b=cdMhYOuhoZI8dF99cijx1HHaTC5Un5yL+GFOVUAOH/Sg4tsyHAlLoZglxtCxDrnCu7/+W+ +kH2cgMnsv84OJoVx77YpkKRTSsFUgcmoiQvATOf+eRvHJkDWjkE3PyCadHwA0GdwxV4jy XaXYJYKfczVS+GwFG+bqMSoUcXqW6Js= Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning To: Ian Jackson , Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <6bd14438-7dec-2176-eab5-5898f190c4d8@suse.com> <24651.15544.142804.468744@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <7185c052-3e66-6202-f820-76568b2b1228@suse.com> Date: Fri, 12 Mar 2021 11:13:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24651.15544.142804.468744@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12.03.2021 11:04, Ian Jackson wrote: > Julien Grall writes ("Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning"): >> This is pretty much what we are already doing slowly by initializing >> values to shut up older compilers. I agree this is more limited, but we >> also waive off diagnostics from every single compiler in that code >> rather than just one version. >> >> Hence why I suggested dropping -Werror for older compiler. This is not >> ideal but it would give us the ability to keep support for dinausor >> compiler and not hamper our ability to take advantage of newer compiler >> diagnostics. > > I agree with Julien. I think we should avoid adding these redundant > initialisers for the reasons he gives. I find this odd, not only because it is contrary to what we've done so far. What if more modern gcc issues a false-positive warning? If we'd fix it there, where would you suggest to draw the line? Imo our tree should build without issues on all compiler versions which we state we permit to be used. Of course in the case here I could add a "default:" to the switch(), but this would still only work around the compiler issue. Would the two of you consider this any better? Also, Ian - do you have any alternative suggestion towards making the build work again (in the more general case, i.e. irrespective of the alternative suggestion for this specific case just above)? Not using -Werror on old compilers (again - where would we draw the line) was already objected to by me. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 10:22:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 10:22:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96965.183950 (Exim 4.92) (envelope-from ) id 1lKevo-0007HV-HD; Fri, 12 Mar 2021 10:22:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96965.183950; Fri, 12 Mar 2021 10:22:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKevo-0007HO-Di; Fri, 12 Mar 2021 10:22:08 +0000 Received: by outflank-mailman (input) for mailman id 96965; Fri, 12 Mar 2021 10:22:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKevm-0007HJ-Vr for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:22:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKevm-0005Ue-R8 for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:22:06 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lKevm-0002la-Od for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:22:06 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lKevj-0003XR-DG; Fri, 12 Mar 2021 10:22:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=3RFzZyrpYW0tRoni8ArV+qjzb1p3DgMTXwJaXhoiPj0=; b=0ZhLJ+erkclZRzJYKOnIstEkGq 8xHfZU3LTqNVq4fxHzAy9n8HQKdxrs8DsRAUYj0viM94s8T6BplPdFbzrSyb0UXzhbOFzl2LHkFdB SJIRH8COp3nZ9MD+m0j1620njBoXsHKTyDLae+VPwUIR09xvPWG/Qz+E2xyk+xlXzzjg=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24651.16587.79927.894745@mariner.uk.xensource.com> Date: Fri, 12 Mar 2021 10:22:03 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Ian Jackson , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH v2 1/2][4.15] tools/x86: don't rebuild cpuid-autogen.h every time In-Reply-To: <1b8aee19-9194-153c-8dbb-0aec3412e255@suse.com> References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> <1b8aee19-9194-153c-8dbb-0aec3412e255@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH v2 1/2][4.15] tools/x86: don't rebuild cpuid-autogen.h every time"): > Ian did suggest to pass -0r to xargs (and -print0 to find), but I > couldn't convince myself that these are standard compliant options. We > don't use any special characters in file names, so -print0 / -0 > shouldn't be necessary at all. The stray rm invocation when there is no > output from find can be taken care of by passing -f to it. I addressed these portability questions in my original mail. I said that I had checked FreeBSD find and xargs have all these options. I didn't check the other *BSDs but I see no reason to think they would be different. find -print0 and xargs -0 are not in SuS (for bad reasons) but these are obviously necessary (unless one thinks people are supposed to use -exec printf "%s\n" '{}' \; when the output is going to something more complicated an just some command's arguments. IOW we are IMO find to rely on both these options. I would be OK with find -exec + in this case. The {} must be quoted. > --- a/tools/include/Makefile > +++ b/tools/include/Makefile > @@ -19,7 +19,7 @@ xen-foreign: > $(MAKE) -C xen-foreign > > xen-dir: > - @rm -rf xen acpi > + find xen/ acpi/ -type l 2>/dev/null | xargs rm -f -- I disapprove of the 2>/dev/null and the -f because I disapprove of suppressing. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 12 10:25:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 10:25:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96969.183965 (Exim 4.92) (envelope-from ) id 1lKeyb-0007QF-1C; Fri, 12 Mar 2021 10:25:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96969.183965; Fri, 12 Mar 2021 10:25:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKeya-0007Q8-UV; Fri, 12 Mar 2021 10:25:00 +0000 Received: by outflank-mailman (input) for mailman id 96969; Fri, 12 Mar 2021 10:25:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKeya-0007Q3-Is for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:25:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKeya-0005YR-I2 for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:25:00 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lKeya-0002uy-HC for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:25:00 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lKeyX-0003Y2-7E; Fri, 12 Mar 2021 10:24:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=djRI6z83hqBJ/Xzgaks9+EyKWbP13MvTx4JfTcOnNDY=; b=kNVZuCbwiveZMMyVA/PGXTjRR/ dCvBRYQuLi+v5qg5dA3PZ5ck85ftlvn0RHha15yXp9qQXBqc/g0K7StFbXitiD4QHpLmG0Ze0X77+ tnFFX83LYeMtVLo1eHG0sVy2AQ2aK65CjhVFfibJ4kGq8w7bqtwsaN22ynFWgvFoZ4tk=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24651.16760.951727.831368@mariner.uk.xensource.com> Date: Fri, 12 Mar 2021 10:24:56 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH v2 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule In-Reply-To: References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH v2 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule"): > There's no need for the common "xen-dir" rule to have an arch-specific > part when there already is a arch-specific rule where this can be taken > care of (arguably instead of all-y this might better be xendir-y > anyway). Thanks, but I do not like this change. IMO make commands should be primarily organised by their logical function and role in the file. If that means that multiple targets have arch-specific parts, so be it. IMO it is not right to move something from xen-dir to all just to reduce the number of different targets with arch-specific parts. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 12 10:29:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 10:29:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96972.183977 (Exim 4.92) (envelope-from ) id 1lKf2b-0007jZ-JO; Fri, 12 Mar 2021 10:29:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96972.183977; Fri, 12 Mar 2021 10:29:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKf2b-0007jS-Fv; Fri, 12 Mar 2021 10:29:09 +0000 Received: by outflank-mailman (input) for mailman id 96972; Fri, 12 Mar 2021 10:29:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKf2a-0007jN-KL for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:29:08 +0000 Received: from forwardcorp1p.mail.yandex.net (unknown [77.88.29.217]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 807b39b7-7333-4481-a292-33b60467d891; Fri, 12 Mar 2021 10:29:04 +0000 (UTC) Received: from iva8-d077482f1536.qloud-c.yandex.net (iva8-d077482f1536.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:2f26:0:640:d077:482f]) by forwardcorp1p.mail.yandex.net (Yandex) with ESMTP id 83F722E11CD; Fri, 12 Mar 2021 13:29:02 +0300 (MSK) Received: from mail.yandex-team.ru (mail.yandex-team.ru [5.255.223.100]) by iva8-d077482f1536.qloud-c.yandex.net (mxbackcorp/Yandex) with HTTP id eSTCI30xQeA1-T1xOOk00; Fri, 12 Mar 2021 13:29:02 +0300 Received: from vla1-fdfb804fb3f3.qloud-c.yandex.net (vla1-fdfb804fb3f3.qloud-c.yandex.net [2a02:6b8:c0d:3199:0:640:fdfb:804f]) by sas1-c3eab8bf7b15.qloud-c.yandex.net with LMTP id fGbK2v0HT4-SXSKEVvi for ; Fri, 12 Mar 2021 13:28:51 +0300 Received: by vla1-4ea76ba32639.qloud-c.yandex.net with HTTP; Fri, 12 Mar 2021 13:28:50 +0300 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 807b39b7-7333-4481-a292-33b60467d891 Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1615544942; bh=vlZFGZPWD0GFhxyZili3SYVtAffMSqSg9sin0+OeFHY=; h=Cc:Subject:Date:References:To:From:Message-Id; b=NEzkEWLk07ZYEqTlK/ZFrENpIVaE54u1lCSNA3oqBLRPnHdaFb5r/UiN1U0HVH+O2 ZEDEUTeRcSCQMB1uIfc20MKa0rUOXNJg3xldlyOD9uJ0lLJUuccVifqfuL+U1YHfeq l/ms2wKqtbpGdEzrtXxoqh1EhPmZlJAIInLbXrSk= Authentication-Results: iva8-d077482f1536.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru X-Yandex-Sender-Uid: 1120000000161690 X-Yandex-Avir: 1 From: Alexey Kirillov To: Jason Wang , Markus Armbruster , Thomas Huth , Eric Blake Cc: Laurent Vivier , Stefano Stabellini , Stefan Weil , "xen-devel@lists.xenproject.org" , Michael S. Tsirkin , Michael Roth , Paul Durrant , "qemu-devel@nongnu.org" , Vincenzo Maffione , "yc-core@yandex-team.ru" , Paolo Bonzini , Anthony Perard , Samuel Thibault , Giuseppe Lettieri , Luigi Rizzo References: <20210303095910.78277-1-lekiravi@yandex-team.ru> Subject: Re: [PATCH v7 0/5] Introducing QMP query-netdev command MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Fri, 12 Mar 2021 13:29:00 +0300 Message-Id: <32641615544652@mail.yandex-team.ru> Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 ping Patchew page: https://patchew.org/QEMU/20210303095910.78277-1-lekiravi@yandex-team.ru 03.03.2021, 13:01, "Alexey Kirillov" : > This patch series introduces a new QMP command "query-netdev" to get > information about currently attached backend network devices (netdevs). > > Also, since the "info_str" field of "NetClientState" is now deprecated, > we no longer use it for netdevs, only for NIC/hubports. > > The HMP command "info network" now also uses QAPI structure inside. > > Usage example: > > -> { "execute": "query-netdev" } > <- { "return": [ >          { >              "listen": "127.0.0.1:90", >              "type": "socket", >              "peer-id": "hub0port1", >              "id": "__org.qemu.net1" >          }, >          { >              "script": "/etc/qemu-ifup", >              "downscript": "/etc/qemu-ifdown", >              "ifname": "tap0", >              "type": "tap", >              "peer-id": "net5", >              "vnet_hdr": true, >              "id": "tap0" >          }, >          { >              "ipv6": true, >              "ipv4": true, >              "host": "10.0.2.2", >              "ipv6-dns": "fec0::3", >              "ipv6-prefix": "fec0::", >              "net": "10.0.2.0/255.255.255.0", >              "ipv6-host": "fec0::2", >              "type": "user", >              "peer-id": "net0", >              "dns": "10.0.2.3", >              "hostfwd": [ >                  { >                      "str": "tcp::20004-:22" >                  } >              ], >              "ipv6-prefixlen": 64, >              "id": "netdev0", >              "restrict": false >          } >      ] >    } > > v6->v7: > - Use macroses QAPI_LIST_PREPEND and QAPI_LIST_APPEND for lists. > - Reorder NetBackend entries in alphabetical order. > > v5->v6: > - Add QAPI visitor to generate info_str replacement directly from NetdevInfo. > - Make info_str dynamically allocated. > - Make commit messages more meaningful. > > v4->v5: > - Enable qtest of query-netdevs for AVR and RX archs. > - Bump "Since" version in QAPI to 6.0. > > v3->v4: > - Rename "query-netdevs" to "query-netdev". > - Copy netdev drivers to new QAPI enum "NetBackend". > > v2->v3: > - Remove NIC and hubports from query-netdevs. > - Remove several fields from NetdevInfo since they are unnecessary. > - Rename field @peer to @peer-id. > - Add support of vhost-vdpa. > - Keep "info_str" for NIC/hubports, but remove it for netdevs. > > v1->v2: > - Rewrite HMP "info network" to get information from results of QMP command. > - Remove obsolete field "info_str" from "NetClientState". > > Alexey Kirillov (5): >   qapi: net: Add query-netdev command >   tests: Add tests for query-netdev command >   net: Move NetClientState.info_str to dynamic allocations >   hmp: Use QAPI NetdevInfo in hmp_info_network >   net: Do not fill legacy info_str for backends > >  hw/net/xen_nic.c | 5 +- >  include/net/net.h | 5 +- >  include/qapi/hmp-output-visitor.h | 30 +++++ >  net/l2tpv3.c | 8 +- >  net/net.c | 73 +++++++++-- >  net/netmap.c | 7 ++ >  net/slirp.c | 124 ++++++++++++++++++- >  net/socket.c | 92 ++++++++++---- >  net/tap-win32.c | 10 +- >  net/tap.c | 107 +++++++++++++++-- >  net/vde.c | 25 +++- >  net/vhost-user.c | 20 +++- >  net/vhost-vdpa.c | 15 ++- >  qapi/hmp-output-visitor.c | 193 ++++++++++++++++++++++++++++++ >  qapi/meson.build | 1 + >  qapi/net.json | 80 +++++++++++++ >  tests/qtest/meson.build | 3 + >  tests/qtest/test-query-netdev.c | 120 +++++++++++++++++++ >  18 files changed, 856 insertions(+), 62 deletions(-) >  create mode 100644 include/qapi/hmp-output-visitor.h >  create mode 100644 qapi/hmp-output-visitor.c >  create mode 100644 tests/qtest/test-query-netdev.c > > -- > 2.25.1 --  Alexey Kirillov Yandex.Cloud From xen-devel-bounces@lists.xenproject.org Fri Mar 12 10:29:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 10:29:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96975.183990 (Exim 4.92) (envelope-from ) id 1lKf31-0007oL-US; Fri, 12 Mar 2021 10:29:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96975.183990; Fri, 12 Mar 2021 10:29:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKf31-0007oE-P2; Fri, 12 Mar 2021 10:29:35 +0000 Received: by outflank-mailman (input) for mailman id 96975; Fri, 12 Mar 2021 10:29:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKf30-0007o6-Mt for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:29:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKf30-0005bx-Jd for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:29:34 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lKf30-00037i-Ik for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:29:34 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lKf2p-0003Z1-Ah; Fri, 12 Mar 2021 10:29:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=yGdcISLXILgnM+oQAr1inXBMzVkxhIog+rnf0NeWGWo=; b=WV/14NNTfrMAQ34OURccVv3wn5 3ZfBYIIVKplbeUiWOb7XNJzS/Lhn0zrRipl86RmdEE43Ig/9kmX4i0AuarwRWFtCC6qixjW49f7gz GydeVms6IQMHII4BlwcsjdKyqANI87SqC+EmzY5L9EhhArzJTByHwS63rANKIxMcXcq4=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24651.17027.10811.145589@mariner.uk.xensource.com> Date: Fri, 12 Mar 2021 10:29:23 +0000 To: Jan Beulich Cc: Julien Grall , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel\@lists.xenproject.org" Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning In-Reply-To: <7185c052-3e66-6202-f820-76568b2b1228@suse.com> References: <6bd14438-7dec-2176-eab5-5898f190c4d8@suse.com> <24651.15544.142804.468744@mariner.uk.xensource.com> <7185c052-3e66-6202-f820-76568b2b1228@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning"): > On 12.03.2021 11:04, Ian Jackson wrote: > > Julien Grall writes ("Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning"): > >> This is pretty much what we are already doing slowly by initializing > >> values to shut up older compilers. I agree this is more limited, but we > >> also waive off diagnostics from every single compiler in that code > >> rather than just one version. > >> > >> Hence why I suggested dropping -Werror for older compiler. This is not > >> ideal but it would give us the ability to keep support for dinausor > >> compiler and not hamper our ability to take advantage of newer compiler > >> diagnostics. > > > > I agree with Julien. I think we should avoid adding these redundant > > initialisers for the reasons he gives. > > I find this odd, not only because it is contrary to what we've done so > far. What if more modern gcc issues a false-positive warning? If we'd > fix it there, where would you suggest to draw the line? Imo our tree > should build without issues on all compiler versions which we state we > permit to be used. > > Of course in the case here I could add a "default:" to the switch(), > but this would still only work around the compiler issue. Would the > two of you consider this any better? > > Also, Ian - do you have any alternative suggestion towards making the > build work again (in the more general case, i.e. irrespective of the > alternative suggestion for this specific case just above)? Not using > -Werror on old compilers (again - where would we draw the line) was > already objected to by me. I read your objection to not using -Werror for such old compilers but I did not agree with it. I am sympathetic to Julien's desire to try to limit the set of supported compilers. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 12 10:55:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 10:55:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96985.184012 (Exim 4.92) (envelope-from ) id 1lKfSE-0002Ek-69; Fri, 12 Mar 2021 10:55:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96985.184012; Fri, 12 Mar 2021 10:55:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfSE-0002Ed-35; Fri, 12 Mar 2021 10:55:38 +0000 Received: by outflank-mailman (input) for mailman id 96985; Fri, 12 Mar 2021 10:55:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfSC-0002EY-3S for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:55:36 +0000 Received: from mail-wm1-x333.google.com (unknown [2a00:1450:4864:20::333]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 95b65677-ee28-4161-8616-1e16a3e92edf; Fri, 12 Mar 2021 10:55:35 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id c76-20020a1c9a4f0000b029010c94499aedso15521062wme.0 for ; Fri, 12 Mar 2021 02:55:35 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id q15sm7264962wrr.58.2021.03.12.02.55.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 02:55:33 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95b65677-ee28-4161-8616-1e16a3e92edf DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=U8krqYE8Ef8qnGsiAipJzGQpaVm5t8lDtkhTxaSOQf8=; b=yo+0Pv1vGiiRr+BRTMkp3T9EiYl7WyqiXEjQPicDPEauSFiYyR62sktJewMDa8dedY TtEdyo/qjJQ2oVaYRSQ7M53MZM7dmCSqleG5phx9kfrPM/3iQZKaUrptoZGtnKshKPhT k8vBK+orZOsk37DTLhw4a5zMwn0ZRe0W0KpUJE4c2vUJnFGNzRTKNOrfj7BUVsMiySCS KpG8zUZke0l4urksnmr+8FXqKdvK/LQQp9twKzZeG5Anzi66F3YJXeBbnAbLfyEs9Mdm 33HdF8a5+NO+J+PGn7XcVBn02oWNoEAEpdVHkH2yt2jK9lzPK6A0zywtAJ78xDs41uwS Okkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=U8krqYE8Ef8qnGsiAipJzGQpaVm5t8lDtkhTxaSOQf8=; b=FRKQxEfjd3N7meeRxL+j+cYRItB4plqcPiBWx7oAKOqPShhcx/hnkJ0bo29XuvM9o6 RqgidPrasTFSu1MFIozncQN86RNJ+S1WLgDxkm8bgK/N3OfddpvlW7cNOhbldsFtE/wo kMclPVJ5twWCXTsn8crUiMFvBgGAuaCpeY4zRz+Wt1a/5IQrDgkLw+gnsIE2UFd2m3Rv JdLYlUi9Yjc0cWVxk15gp8HV7u72J9HUr5BO4lHLtAZNCADNmrMQW1rwoPzp5Pwn73hJ fkVyLrvZv/yIDHCKgeku5sP4nFMD++K0ia24DSr5BrW9a7ihzKnoe1iWSJLYnk9Q1D3d jx7Q== X-Gm-Message-State: AOAM530xC24Ki4RA4w+M5cCh6atWzRc4duquiybhvygjnXL8ePnB85xJ AWzY7LUPxaKARj0YnHyXXxB0SA== X-Google-Smtp-Source: ABdhPJwGy2yiZng+8p42AiTsODzcXCoCU2A55jsurjv+Rkg7hZ8K/NGYGP3VtK/HkA0LP08aOZ4tBg== X-Received: by 2002:a1c:7e16:: with SMTP id z22mr12397544wmc.74.1615546534304; Fri, 12 Mar 2021 02:55:34 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Boris Ostrovsky , drbd-dev@lists.linbit.com, Jens Axboe , Joshua Morris , Juergen Gross , Konrad Rzeszutek Wilk , Lars Ellenberg , linux-block@vger.kernel.org, Philip Kelleher , Philipp Reisner , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org Subject: [PATCH 00/11] Rid W=1 warnings from Block Date: Fri, 12 Mar 2021 10:55:19 +0000 Message-Id: <20210312105530.2219008-1-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (11): block: rsxx: core: Remove superfluous const qualifier block: drbd: drbd_interval: Demote some kernel-doc abuses and fix another header block: mtip32xx: mtip32xx: Mark debugging variable 'start' as __maybe_unused block: drbd: drbd_state: Fix some function documentation issues block: drbd: drbd_receiver: Demote non-conformant kernel-doc headers block: drbd: drbd_main: Remove duplicate field initialisation block: drbd: drbd_nl: Make conversion to 'enum drbd_ret_code' explicit block: drbd: drbd_main: Fix a bunch of function documentation discrepancies block: drbd: drbd_receiver: Demote less than half complete kernel-doc header block: xen-blkfront: Demote kernel-doc abuses block: drbd: drbd_nl: Demote half-complete kernel-doc headers drivers/block/drbd/drbd_interval.c | 8 +++++--- drivers/block/drbd/drbd_main.c | 30 +++++++++++++++--------------- drivers/block/drbd/drbd_nl.c | 17 ++++++++++------- drivers/block/drbd/drbd_receiver.c | 26 ++++++++++++-------------- drivers/block/drbd/drbd_state.c | 7 ++++--- drivers/block/mtip32xx/mtip32xx.c | 2 +- drivers/block/rsxx/core.c | 2 +- drivers/block/xen-blkfront.c | 6 +++--- 8 files changed, 51 insertions(+), 47 deletions(-) Cc: Boris Ostrovsky Cc: drbd-dev@lists.linbit.com Cc: Jens Axboe Cc: Joshua Morris Cc: Juergen Gross Cc: Konrad Rzeszutek Wilk Cc: Lars Ellenberg Cc: linux-block@vger.kernel.org Cc: Philip Kelleher Cc: Philipp Reisner Cc: "Roger Pau Monné" Cc: Stefano Stabellini Cc: xen-devel@lists.xenproject.org -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Fri Mar 12 10:55:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 10:55:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96986.184025 (Exim 4.92) (envelope-from ) id 1lKfSO-0002Ho-JX; Fri, 12 Mar 2021 10:55:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96986.184025; Fri, 12 Mar 2021 10:55:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfSO-0002Hg-GI; Fri, 12 Mar 2021 10:55:48 +0000 Received: by outflank-mailman (input) for mailman id 96986; Fri, 12 Mar 2021 10:55:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfSN-0002HH-9y for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 10:55:47 +0000 Received: from mail-wm1-x32a.google.com (unknown [2a00:1450:4864:20::32a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e2feb718-2784-4f6b-9116-1a65313704b9; Fri, 12 Mar 2021 10:55:46 +0000 (UTC) Received: by mail-wm1-x32a.google.com with SMTP id y124-20020a1c32820000b029010c93864955so15516163wmy.5 for ; Fri, 12 Mar 2021 02:55:46 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id q15sm7264962wrr.58.2021.03.12.02.55.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 02:55:45 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2feb718-2784-4f6b-9116-1a65313704b9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xA52xjDJnHJLgzflByk0CYC2xv7fgNWSlI8xs2AjI2I=; b=yBhGkoCBvWZlTxApi3aQJCnXm6iZzfXW4lQ1f6lbu63T/UR1hwscaZQgi6mFsVg64a oiA/rWoXUQKQGJ5nth3GW+1+N6Q9vQ+LsOSskFQvM5+FfVpyUsxa1oVrzuO7bgSsVet+ 1LCEz6xdgaUNJ0NNVGWeHhf6ln0L/JSLz2qMsYBqA3fk6Yl2JEUPxgAQyQB+GlNOero6 ZpeDtbIKY2N+DkzL73rgHW+TRdFtjfwk7QEw69eurO+gkMsQEIQpbkTgDWbcfs1q/+t5 Bx5XTPDeM450Q5ULCtVDlRXPeZuf8JJp9FGJSRNnul8wY2tmaHUSIYbYczvw3aGjkxBJ 9yiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xA52xjDJnHJLgzflByk0CYC2xv7fgNWSlI8xs2AjI2I=; b=OrpPU0zF0OA0BC1kA7f9IxAylP5h0EKdN8DbuLnYMDMw9JqKrJDeEwdmNP1U3c2orl 7V4aSF7iL5HKiFcbzXIYGLc8CI/IbOq9HKECu/DM9Ey9m4ljPPfoCRTQ5NCTQDZsQeAr 7PRwSyzIfzccc5Fh69XwDks6NNow0WLFERTnHibNcdTk1JeNBAtsoAjaqqtW+nhCwqic ni0aClv7jTe9VU1Q8GyhmUtQeHqgCf3cCZx0fS96rVf4bMfEdR7iwMVoQsxaf+JnynTI w3N1Ka2OTzAHOmEmuC3pRKUnNgBC5bvmE2ibmTUxW2+54Auq/i0OO4uQhfZ4TVnK+DPo k8rQ== X-Gm-Message-State: AOAM533CMLdCiDDM9SuW3QnfSfa0/HhW4VmWieCUDs2jgZBgvSb90k++ ZTdljtBQnc30tELoaxFiJK6cQg== X-Google-Smtp-Source: ABdhPJyuSwTDyvh7rCaXNW786qrIPBHDymlJenX8Hl8exjSrhayuRqjYskb8CzXmWzlIWfVNFKDDdw== X-Received: by 2002:a1c:9a0e:: with SMTP id c14mr12656107wme.34.1615546545649; Fri, 12 Mar 2021 02:55:45 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Konrad Rzeszutek Wilk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Jens Axboe , xen-devel@lists.xenproject.org, linux-block@vger.kernel.org Subject: [PATCH 10/11] block: xen-blkfront: Demote kernel-doc abuses Date: Fri, 12 Mar 2021 10:55:29 +0000 Message-Id: <20210312105530.2219008-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312105530.2219008-1-lee.jones@linaro.org> References: <20210312105530.2219008-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Fixes the following W=1 kernel build warning(s): drivers/block/xen-blkfront.c:1960: warning: Function parameter or member 'dev' not described in 'blkfront_probe' drivers/block/xen-blkfront.c:1960: warning: Function parameter or member 'id' not described in 'blkfront_probe' drivers/block/xen-blkfront.c:1960: warning: expecting prototype for Allocate the basic(). Prototype was for blkfront_probe() instead drivers/block/xen-blkfront.c:2085: warning: Function parameter or member 'dev' not described in 'blkfront_resume' drivers/block/xen-blkfront.c:2085: warning: expecting prototype for or a backend(). Prototype was for blkfront_resume() instead drivers/block/xen-blkfront.c:2444: warning: wrong kernel-doc identifier on line: Cc: Konrad Rzeszutek Wilk Cc: "Roger Pau Monné" Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Jens Axboe Cc: xen-devel@lists.xenproject.org Cc: linux-block@vger.kernel.org Signed-off-by: Lee Jones --- drivers/block/xen-blkfront.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index e1c6798889f48..e57e3cd354fb8 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1949,7 +1949,7 @@ module_param(feature_persistent, bool, 0644); MODULE_PARM_DESC(feature_persistent, "Enables the persistent grants feature"); -/** +/* * Entry point to this code when a new device is created. Allocate the basic * structures and the ring buffer for communication with the backend, and * inform the backend of the appropriate details for those. Switch to @@ -2075,7 +2075,7 @@ static int blkif_recover(struct blkfront_info *info) return 0; } -/** +/* * We are reconnecting to the backend, due to a suspend/resume, or a backend * driver restart. We tear down our blkif structure and recreate it, but * leave the device-layer structures intact so that this is transparent to the @@ -2440,7 +2440,7 @@ static void blkfront_connect(struct blkfront_info *info) return; } -/** +/* * Callback received when the backend's state changes. */ static void blkback_changed(struct xenbus_device *dev, -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Fri Mar 12 10:58:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 10:58:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96993.184037 (Exim 4.92) (envelope-from ) id 1lKfVT-0002fT-3U; Fri, 12 Mar 2021 10:58:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96993.184037; Fri, 12 Mar 2021 10:58:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfVT-0002fM-0T; Fri, 12 Mar 2021 10:58:59 +0000 Received: by outflank-mailman (input) for mailman id 96993; Fri, 12 Mar 2021 10:58:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfVR-0002fC-Da; Fri, 12 Mar 2021 10:58:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfVR-00067I-6S; Fri, 12 Mar 2021 10:58:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfVQ-0000l8-S9; Fri, 12 Mar 2021 10:58:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKfVQ-0007lg-Rf; Fri, 12 Mar 2021 10:58:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WME2fOHnE7SRN+PFK+85/HixSYyBRuCZiWr7IuX4Atk=; b=tlHs+n2vCF0BQicj+2IagWWyd5 KxiTrKUJTqa8suuDhCJThCgyDPWfegylEbtkNydkYyn8PcX+5kau3lORtoqd7t+gclXL1nZuF6v35 yDOTjRUlIUccWOHFxeOU6AhasET1M4iA4QlQLR00ogS1kRIfFqr/+onO+/aSHBW6COkE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 159947: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=f4abdf32714d1845b7c01ec136dd2b04c2f7db47 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Fri, 12 Mar 2021 10:58:56 +0000 flight 159947 qemu-mainline real [real] flight 159995 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159947/ http://logs.test-lab.xenproject.org/osstest/logs/159995/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu f4abdf32714d1845b7c01ec136dd2b04c2f7db47 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 204 days Failing since 152659 2020-08-21 14:07:39 Z 202 days 389 attempts Testing same since 159947 2021-03-11 20:06:59 Z 0 days 1 attempts ------------------------------------------------------------ 442 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 126210 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Mar 12 11:01:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 11:01:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.96999.184055 (Exim 4.92) (envelope-from ) id 1lKfXz-0003YW-Jf; Fri, 12 Mar 2021 11:01:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96999.184055; Fri, 12 Mar 2021 11:01:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfXz-0003YP-Gj; Fri, 12 Mar 2021 11:01:35 +0000 Received: by outflank-mailman (input) for mailman id 96999; Fri, 12 Mar 2021 11:01:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfXy-0003YF-7W for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 11:01:34 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d4fba7e1-acb5-48dd-9c7d-7bafa3bd2947; Fri, 12 Mar 2021 11:01:33 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 803B1B02F; Fri, 12 Mar 2021 11:01:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4fba7e1-acb5-48dd-9c7d-7bafa3bd2947 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615546892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ODUPWDssY7gs7fhSJKuuSqxZQG4EVlFROeOzHNfA6IQ=; b=hXIXCKZ1q2wMP/M9PQCzflE+Yi8djezQLYsGC/ihq5w4OHGQZdR29A/onb1tX43zoSYcjZ jDTwO4jezD99YOGunulGdUyYz5LL5Bw+MirjyJxsZNyUJXZPbMkwt1NTSZ/wxBPbxGqm+W qj/YzYucBmnFsx6vQR5m2paRhGRCp30= From: Jan Beulich Subject: [PATCH v4 0/2][4.15] x86: guest MSR access handling tweaks To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson Message-ID: <9c2e5e0e-041f-03e3-3c08-7abcc82d63c7@suse.com> Date: Fri, 12 Mar 2021 12:01:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Largely to re-base patch 1. 1: PV: conditionally avoid raising #GP for early guest MSR reads 2: AMD: expose HWCR.TscFreqSel to guests Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 11:02:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 11:02:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97003.184066 (Exim 4.92) (envelope-from ) id 1lKfZ6-0003fT-Um; Fri, 12 Mar 2021 11:02:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97003.184066; Fri, 12 Mar 2021 11:02:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfZ6-0003fM-Ri; Fri, 12 Mar 2021 11:02:44 +0000 Received: by outflank-mailman (input) for mailman id 97003; Fri, 12 Mar 2021 11:02:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfZ4-0003fF-Rc for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 11:02:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fcc57503-d894-46ae-a9dd-660d9eae5c2e; Fri, 12 Mar 2021 11:02:41 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1EB86B02C; Fri, 12 Mar 2021 11:02:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcc57503-d894-46ae-a9dd-660d9eae5c2e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615546961; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6n0jPE7z0vDwFOBZ8/feXejyuYibfU3F2LIii07idAQ=; b=QsCW1BehTW5hw7yB0VO/bDkZf9t3ZWBvWr4Tt+C5CbWzRpyngRMpBZHaI+gZ8aEF6g3M1a OROTkyDIehqtT7A0DdMaHd8XjkQ+8yboc/MjDkLhlKBRhoGx9HVSeFq4aOcHsQqlbHVJPA 03n2fIc3JLmh9fKy5ubZUhIKQ+CTd3A= Subject: [PATCH v4 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: <9c2e5e0e-041f-03e3-3c08-7abcc82d63c7@suse.com> Message-ID: Date: Fri, 12 Mar 2021 12:02:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <9c2e5e0e-041f-03e3-3c08-7abcc82d63c7@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Prior to 4.15 Linux, when running in PV mode, did not install a #GP handler early enough to cover for example the rdmsrl_safe() of MSR_K8_TSEG_ADDR in bsp_init_amd() (not to speak of the unguarded read of MSR_K7_HWCR later in the same function). The respective change (42b3a4cb5609 "x86/xen: Support early interrupts in xen pv guests") was backported to 4.14, but no further - presumably since it wasn't really easy because of other dependencies. Therefore, to prevent our change in the handling of guest MSR accesses to render PV Linux 4.13 and older unusable on at least AMD systems, make the raising of #GP on this paths conditional upon the guest having installed a handler, provided of course the MSR can be read in the first place (we would have raised #GP in that case even before). Producing zero for reads isn't necessarily correct and may trip code trying to detect presence of MSRs early, but since such detection logic won't work without a #GP handler anyway, this ought to be a fair workaround. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Release-Acked-by: Ian Jackson --- v4: Re-base. Slightly adjust comment wording. v3: Use temporary variable for probing. Document the behavior (in a public header, for the lack of a better place). v2: Probe MSR read. Exclude hypervisor range. Avoid issuing two log messages (in debug builds). Don't alter WRMSR behavior. --- While I didn't myself observe or find similar WRMSR side issues, I'm nevertheless not convinced we can get away without also making the WRMSR path somewhat more permissive again, e.g. tolerating attempts to set bits which are already set. But of course this would require keeping in sync for which MSRs we "fake" reads, as then a kernel attempt to set a bit may also appear as an attempt to clear others (because of the zero value that we gave it for the read). Roger validly points out that making behavior dependent upon MSR values has its own downsides, so simply depending on MSR readability is another option (with, in turn, its own undesirable effects, e.g. for write-only MSRs). --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -874,7 +874,7 @@ static int read_msr(unsigned int reg, ui struct vcpu *curr = current; const struct domain *currd = curr->domain; const struct cpuid_policy *cp = currd->arch.cpuid; - bool vpmu_msr = false; + bool vpmu_msr = false, warn = false; uint64_t tmp; int ret; @@ -883,7 +883,7 @@ static int read_msr(unsigned int reg, ui if ( ret == X86EMUL_EXCEPTION ) x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); - return ret; + goto done; } switch ( reg ) @@ -993,7 +993,7 @@ static int read_msr(unsigned int reg, ui return X86EMUL_OKAY; } - gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); + warn = true; break; normal: @@ -1002,7 +1002,19 @@ static int read_msr(unsigned int reg, ui return X86EMUL_OKAY; } - return X86EMUL_UNHANDLEABLE; + done: + if ( ret != X86EMUL_OKAY && !curr->arch.pv.trap_ctxt[X86_EXC_GP].address && + (reg >> 16) != 0x4000 && !rdmsr_safe(reg, tmp) ) + { + gprintk(XENLOG_WARNING, "faking RDMSR 0x%08x\n", reg); + *val = 0; + x86_emul_reset_event(ctxt); + ret = X86EMUL_OKAY; + } + else if ( warn ) + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); + + return ret; } static int write_msr(unsigned int reg, uint64_t val, --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -143,6 +143,12 @@ typedef unsigned long xen_ulong_t; * Level == 1: Kernel may enter * Level == 2: Kernel may enter * Level == 3: Everyone may enter + * + * Note: For compatibility with kernels not setting up exception handlers + * early enough, Xen will avoid trying to inject #GP (and hence crash + * the domain) when an RDMSR would require this, but no handler was + * set yet. The precise conditions are implementation specific, and + * new code may not rely on such behavior anyway. */ #define TI_GET_DPL(_ti) ((_ti)->flags & 3) #define TI_GET_IF(_ti) ((_ti)->flags & 4) From xen-devel-bounces@lists.xenproject.org Fri Mar 12 11:03:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 11:03:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97007.184079 (Exim 4.92) (envelope-from ) id 1lKfZZ-0003lq-Cp; Fri, 12 Mar 2021 11:03:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97007.184079; Fri, 12 Mar 2021 11:03:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfZZ-0003lj-8r; Fri, 12 Mar 2021 11:03:13 +0000 Received: by outflank-mailman (input) for mailman id 97007; Fri, 12 Mar 2021 11:03:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfZX-0003kX-Sd for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 11:03:11 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 74f87939-5567-4ea0-a86a-218298e721bf; Fri, 12 Mar 2021 11:03:06 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7002EB02C; Fri, 12 Mar 2021 11:03:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74f87939-5567-4ea0-a86a-218298e721bf X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615546985; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QFrMh+sBcKyoQb7P1wDYHd/74ZilGORQiERspE6maW0=; b=E7zJOJnPZJDSBqXWO2Xl7S/OH4dNjw/nn5lBDdGm1lfYu9kVqN97TkToCnJ4gdWyMbbTrz Rb76q8VHo4hpc0E4MFGaXjYB/yEejqHqRMLXdpwuvBUu6iu7pzZRFhsrxlh6p7JvDiny4k CX5O5wN8A8C+WAOZZ6wWe4F+Hv8BkoI= Subject: [PATCH v4 2/2][4.15] x86/AMD: expose HWCR.TscFreqSel to guests From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: <9c2e5e0e-041f-03e3-3c08-7abcc82d63c7@suse.com> Message-ID: <0c8043e3-07aa-6242-19bd-07b04f574b87@suse.com> Date: Fri, 12 Mar 2021 12:03:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <9c2e5e0e-041f-03e3-3c08-7abcc82d63c7@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Linux has been warning ("firmware bug") about this bit being clear for a long time. While writable in older hardware it has been readonly on more than just most recent hardware. For simplicitly report it always set (if anything we may want to log the issue ourselves if it turns out to be clear on older hardware) on CPU families 10h and up (in family 0fh the bit is part of a larger field of different purpose). Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné --- v3: Report 0 for Fam0F. v2: New. --- There are likely more bits worthwhile to expose, but for about every one of them there would be the risk of a lengthy discussion, as there are clear downsides to exposing such information. The more that it would be tbd whether the hardware values should be surfaced, and if so what should happen when the guest gets migrated. The main risk with making the read not fault here is that guests might imply they can also write this MSR then. --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -315,6 +315,13 @@ int guest_rdmsr(struct vcpu *v, uint32_t *val = msrs->tsc_aux; break; + case MSR_K8_HWCR: + if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) + goto gp_fault; + *val = get_cpu_family(cp->basic.raw_fms, NULL, NULL) >= 0x10 + ? K8_HWCR_TSC_FREQ_SEL : 0; + break; + case MSR_AMD64_DE_CFG: if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) goto gp_fault; --- a/xen/include/asm-x86/msr-index.h +++ b/xen/include/asm-x86/msr-index.h @@ -287,6 +287,8 @@ #define MSR_K7_HWCR 0xc0010015 #define MSR_K8_HWCR 0xc0010015 +#define K8_HWCR_TSC_FREQ_SEL (1ULL << 24) + #define MSR_K7_FID_VID_CTL 0xc0010041 #define MSR_K7_FID_VID_STATUS 0xc0010042 #define MSR_K8_PSTATE_LIMIT 0xc0010061 From xen-devel-bounces@lists.xenproject.org Fri Mar 12 11:05:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 11:05:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97011.184091 (Exim 4.92) (envelope-from ) id 1lKfbJ-0003v1-OZ; Fri, 12 Mar 2021 11:05:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97011.184091; Fri, 12 Mar 2021 11:05:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfbJ-0003uu-LM; Fri, 12 Mar 2021 11:05:01 +0000 Received: by outflank-mailman (input) for mailman id 97011; Fri, 12 Mar 2021 11:05:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfbI-0003up-TO for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 11:05:00 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5175d7d0-84de-4ead-a8bb-57d6e9e0f2b4; Fri, 12 Mar 2021 11:05:00 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 649ABB02F; Fri, 12 Mar 2021 11:04:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5175d7d0-84de-4ead-a8bb-57d6e9e0f2b4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615547099; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JKglwgQmrxKqE+Kz3RJoIaxWXHhvamIhs7u/l9kSWak=; b=u+Cy2RrTqc+a2Mhv6PAOK/xOIbFgRtcXAmIUUTXcdCzUVmQ4yE1HpeJy0t7WKWrOcH79cZ RBwd081coB4qd+y7Ds5Lif0j24vNpBF40STJyiNNKhphRmLhAva3Vnwqjt/H5gQK+omEKn z8RThY/sNFp6CWkmVTOKlW174Agq324= Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning To: Ian Jackson Cc: Julien Grall , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <6bd14438-7dec-2176-eab5-5898f190c4d8@suse.com> <24651.15544.142804.468744@mariner.uk.xensource.com> <7185c052-3e66-6202-f820-76568b2b1228@suse.com> <24651.17027.10811.145589@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <07d34ad4-65b6-31f5-b4ae-ee4ed18e8baa@suse.com> Date: Fri, 12 Mar 2021 12:05:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24651.17027.10811.145589@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12.03.2021 11:29, Ian Jackson wrote: > I am sympathetic to Julien's desire to try to limit the set of > supported compilers. Yes, and I agree we're long overdue with raising the baseline. It's just that it's not straightforward to establish a good new one. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 11:13:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 11:13:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97015.184103 (Exim 4.92) (envelope-from ) id 1lKfj1-0004zZ-Hq; Fri, 12 Mar 2021 11:12:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97015.184103; Fri, 12 Mar 2021 11:12:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfj1-0004zS-Ev; Fri, 12 Mar 2021 11:12:59 +0000 Received: by outflank-mailman (input) for mailman id 97015; Fri, 12 Mar 2021 11:12:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfj0-0004zK-39; Fri, 12 Mar 2021 11:12:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfiz-0006OP-Th; Fri, 12 Mar 2021 11:12:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfiz-0001bA-LH; Fri, 12 Mar 2021 11:12:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKfiz-0004Uo-Ko; Fri, 12 Mar 2021 11:12:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hxkLAzIQnwob3YihfAYpaF8yEVtGREtTmes27yhWbTk=; b=IeEs9zhrwbwtNdrKNaEFMh8Avk 4Pr2U5ckMiOQop56PSjhg3s1pisJD5Exs4TqebpSWNiBBNmzrAVFNdH/FCUrudHRvJT+Sj9IoqDuJ qe5FGuPMAjkoVZVuNryE+likrE8N+v0hTqOoObMwQ4hbYMO3CmsIoRGJb19nYFQa+vjc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 159991: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0570d7f276dd20a3adee80ca44a5fe7daf7566cd X-Osstest-Versions-That: xen=9e23f10eb0db5ffa06f1a43f74fac790992a85c7 From: osstest service owner Date: Fri, 12 Mar 2021 11:12:57 +0000 flight 159991 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159991/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 0570d7f276dd20a3adee80ca44a5fe7daf7566cd baseline version: xen 9e23f10eb0db5ffa06f1a43f74fac790992a85c7 Last test of basis 159946 2021-03-11 20:02:34 Z 0 days Testing same since 159991 2021-03-12 09:00:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Boris Ostrovsky Christian Lindig Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9e23f10eb0..0570d7f276 0570d7f276dd20a3adee80ca44a5fe7daf7566cd -> smoke From xen-devel-bounces@lists.xenproject.org Fri Mar 12 11:19:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 11:19:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97024.184123 (Exim 4.92) (envelope-from ) id 1lKfpD-0005Mu-E6; Fri, 12 Mar 2021 11:19:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97024.184123; Fri, 12 Mar 2021 11:19:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfpD-0005Mn-B9; Fri, 12 Mar 2021 11:19:23 +0000 Received: by outflank-mailman (input) for mailman id 97024; Fri, 12 Mar 2021 11:19:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfpC-0005Mi-MI for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 11:19:22 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7ec404c7-bc35-4d43-8008-9fca1445dfb8; Fri, 12 Mar 2021 11:19:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ec404c7-bc35-4d43-8008-9fca1445dfb8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615547961; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=dTYqEk3VcqDeq2SWk/2UwSmLiF8lTBLnOqOhkCxoKCk=; b=VMaIQwiPij18eKsAjp7oqpDUfrZ+Y+T74/uJi0Xbf5d06JrL+2DDNvqv EwEUIMWtILmfx9O95Ju8qvBP3riwfOf1LMWfdj/2FxoHOjTosKykZOOeO EfeoqDoi6GaPTbhJyqei1iF156lYb1lmMR9klb3w3hHO31ow7pLfo4aOj o=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 4+NG2FJo25fSEZkfJPvmwi5mBcct4zYoYhUQe3L2f+ZXjVC2b5JIt2AhgEFbFQAN+I6yn3l7UM uBljtcOqYQLUFjHaC1tZ4kP1E8wraQTGcXTDNFP6LsdwVBp3rWl29pWO3G6dFdgxymZfdWRRL0 JvRDv+ldeTHUvFxzDYkkPvqULyWsX3riTSe8or+LLoJVZsLghGFb3WajetrCnE1KZ5DWvcwy+o Ao8rolI6JOGXQC1I9wn+9UpT9waxfl24dv/IqrGo2RXW6++xPOYwiOqEPMWZf8gcREj5jArgHP AoE= X-SBRS: 5.2 X-MesageID: 39049908 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:GdfvGqpZq+gYGF5Uk6jmpzsaV5uEKtV00zAX/kB9WHVpW+SivY SHgOkb2RjoiDwYRXEnnpS6NLOdRG7HnKQa3aA4Bp3neAX9omOnIMVZ7YXkyyD9ACGWzIFg/I 9aWexFBNX0ZGIXse/T/BS4H9E8wNOO7aCvgqPkw21wSBxxApsB0y5SIG+gYylLbSNBAoc0E4 fZw8JBqSapd3h/VLXEOlAuWe/fq9rX0K/8aRkdCBI9rCWIhzWk6Ln1eiLooSs2eTVJ3Lsk7C z5gxX0j5/Tz82T5z398yvo75pQkMb80dcrPq2xo+UcNzmEsHfSWK1PQLuH1QpFxt2HyFFvq9 XUpgdlAsIb0QKtQkiQgT/Anzbtyywv7XiK8y7rvVLGrdbiTDw3T+pt7LgpCifx0EYrsNFi3K 8j5Qvw3PA7fHCw/lWI2/HyWx5njUayq3Y5+NRj6EB3aocCdKRX6bUW4UI9KuZyIAvB9IslHO NyZfusncp+TFXyVQG9gkBS2tC2Glw8EhCaK3JywPC94nx9mXB0yFYg38oPnnsM34JVceg128 30dotvj71AVckQcOZUA/oAW9K+Dij3TQvLK3/6GyWoKIg3f1b277Ln6rQ84++nPLQO0ZsJgZ zEFHdVr3Q7dU7CAdCHtac7syzlcSGYZ3DA28te7592tvnXX7zwKxCOT1gojo+Jv+gfKtezYY fwBLtmR9vYaUf+E4dA2APzH7NIL2MFbcETstEnH3qTv8PwLJHwvOCzSoeRGJPdVRIfHk/vCH oKWzb+YO9a6FqwZ3P+iB/NH1z3fEjS+o9xDbj68+AfxJNlDPwJjiElzXCCou2bIzxLtaI7OG FkJqn8r6+9rW6quUbEhl8ZfSZ1PwJw2vHNQnlKrQgFPwffarAYoeiSfmhUwT+iLh97RMXGLR 5Hqz1MiOSKBq3V4RpnJ8OsM2qcgXdWjmmNVY0glqqK4tqgXZ8kEJA8WuhUGR/QHxJ43SZmwV 0zKDMsdwv6LHfDmK+lhJsbCKX0bN9nmjqmJsZStDb4rkWTpcYmQ1MBRD6wWcurgQIjLgAkw2 FZwus6uv6tiDyvIWwwjKATK1tXclmaB7pAEUC4folOo6vqfwtxVG+OojSfh3gICzPX3nRXol akATyfePnNDFYYnnxDyK7l/Gl5cXinc1tqZmp3tpB8Emr6qm9+uNX7E5ab4i+0UB8v0+sdOD bKbX8pLgRiy8ue+TSVlDyBfE9Wi6kGD6j4NvAOYrvT0nSiJMm0jqkABeZT54sgHsvpqPU3Xe WWfBK1IDv0B/gy4RGcom8oNUBP2SEZuMKt/CegwHmz3XY5D/aXHU9vQKsDJcqAq0fjXPSF3f xC/JoIlNr1Fl+0TNGIyavaNWEebjzSpHO7VOEup9R/u7kouL56ApncVn/p2Rh8rWMDBfaxsH lbZqJxpI3lEMtIWec5fipC5FonlNiVNiIQw0bLK957WWtotmPROtOC3qHBprUuCHCQvQeYAy jpzwRtu9P+GxaZ3bEUC6gMMX1bRUg15nNl5v6DfeTreUyXXtAG2FqxKXmmdrBBDICDBLULtx 5/iuv409O/Rm7d2ArKuyF8Lb8L22G7QdmqCAbJPeJT6dS1NRCthaStifTDwwvfeH+ea04Cg5 dCelFVRsNfiiM6hIly6xOMcMXM0wkYumobxypmmF7r0pWn52mePXguC3ypvrxmGR9JMnaJis zZ9/O/z3qV2kkf5aX+ X-IronPort-AV: E=Sophos;i="5.81,243,1610427600"; d="scan'208";a="39049908" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AFZKjlWB62NLb1MMQ8cuC1M47I9WTgPxkZ9UspxRvFsBsNgAk8ZMF81mZohjBXly16TCfFZFNWNpKWd5RdNUXsLQDbKWzurRhyQn+ChwnQw0EpW5zx6wovDvAUAlB55e6qwsE54/IYtRomR4oA+bvdJ0vrq91uxBaxrQAWz/vU0prSjYSb3pGt8IXS5jHQTHdAgVCqp7Ek0Bl3g1vfy1PR27wYsavMQ/iCIxEydRk13z2o4HdBPia7FrEHgdFPGuwA8zaDSMgrXaFKcybjra5R0IvNUT8qyzlXuGWrzKTHMmEZZ1hP/lTqTaIr+dplb5BTcfEJTV0GJHxUOKbaWB5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dTYqEk3VcqDeq2SWk/2UwSmLiF8lTBLnOqOhkCxoKCk=; b=iaCOx8afvNaJlEBcUo5xXxsWstJyK4rZhyLjDsEdYt0yjX/Q0upSH75cmX5h/ASeYP0mJ4RnLzoyO4eR9dXrAI8d9qM/YnEcEiT0H9yUIyLSMVT4tpgezzajoyK/3gvGoua1262FlZkyh93S40R1q0vSZ33wT4FXNOiQsrcWZfAUzlp2lalS1hw8zwljZbdB6mWqWE5DYb6+IY7DCbzIL7eYnpZ6jMbWA+s8FuuA99NvKPvGPulF1SHTBbeuyX3hpItJVFXwWbyX8QVXWNDObCE7cv/0KqiEEAF0LlKFmhsxZ2vk5eh4pq9BQDHs9X/0ktis8+5hqUpuEKQDb1kP1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dTYqEk3VcqDeq2SWk/2UwSmLiF8lTBLnOqOhkCxoKCk=; b=rSfZZAc6qJytVomFQ2gHGfnydDhp3+jy2TOJ/gGMYWY8NhOCkjd+o/1lR4iHgd2fbDnBjfFzb8OnsMwiP65jsR1kpHUDBskjMfHRB5Hucl3u5wPjTdsIzNEIeY+PHi6EW7wxZknUd+vKm8esGsTA5GuhMfiRzFpFuulDukMSaq8= To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: <7a84bc56-0045-2111-6888-8db830335ad1@suse.com> <90f87aa8-09da-1453-bd82-c722465c2881@suse.com> From: Andrew Cooper Subject: Re: [PATCH v3 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads Message-ID: <7504b027-f106-33e1-214a-eecf8ea5ff5d@citrix.com> Date: Fri, 12 Mar 2021 11:19:12 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <90f87aa8-09da-1453-bd82-c722465c2881@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO3P265CA0012.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::17) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 251b9866-2791-4578-0ae3-08d8e548ad02 X-MS-TrafficTypeDiagnostic: BN7PR03MB4388: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D0pXRgxHWifPI4ETEzK2kyMQA9FAaEQKU/Sts8OHSNCABGTNivvkrxpsHKgIK+B5CIZ5ABfp7D4H8aH1zmanefHwAHAQLkzA+bQAvkx+tTz+c0oc1IbmBkQmcWO1NzqwbrULBFz8qv+kmrCyMVWSWyvk50izDyaaOdOwkBxK2NuJqfTSVNgN4hFRPQ2R9bUwPojNFsaD7zL+gvkaW+kuBneXeSJFlkSCq5OHTLXhxv2BM65mMGdf1Pzz8siNRFeFIXCnwtR6mP7nQ1muL3Xq3Is7/YNBs3cWRs4NFNvCtSHAMsrKIx/Yu3r4g4VUWni2tY3dy5RdOdjpVdRpkbrETMJRdEDWw8JvvbQb/svmbuWfyPeTAvZAETTHyFUmr5GYleC9+GRoi0aImm7ZB+xOVgoHvsMtPVxgAaTv1lQwvA1YovwAoyROPKvRdy+MZEyvCNj7MTNzH9yCNupPxi+7vIeYGT+C76fO/mERhgy2AM4VRY191+beWLA566xabvHxGK1jma9x0kG1sq7TKgfH+U2Ma4r+7UNBditCXSJUhjy4Z2ZjUQcXtij+fSG6LKDKMHwmkCMOZE748/7wfWVFfzwbCrrUare0tkgqmxIDCZM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(136003)(39860400002)(346002)(376002)(16576012)(66946007)(316002)(2616005)(26005)(66556008)(956004)(31686004)(66476007)(8936002)(86362001)(5660300002)(110136005)(8676002)(2906002)(186003)(53546011)(31696002)(6486002)(16526019)(6666004)(4326008)(36756003)(83380400001)(54906003)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZlppMEpaT2Y3OEZram1nbDhmYjJMT0NKTExvOGJLbTdtN2lGM1ZwMDlHSTNm?= =?utf-8?B?b20zdEJMV25nZUtJTHJXYzM4cXU0VzlCU1RJWGZHanhKbys3djhxOVl6cnVF?= =?utf-8?B?dTRSMVFVQVF5MVdvV0FmN1FNR2lVL2JmWkRIMkhTMVQzQ1c4WGRqSktFcGFp?= =?utf-8?B?TlZxUUdnRStSUWkxYTZSS25BcEhRSXRDZExMVlFyQW9Ed0ZISTVLK000Tm9h?= =?utf-8?B?aE1rV1ZBM2RvUGlIR09ka1poV2VUZ1E4NDVJV3hhQjBFdkRLNy80TkQ0LzNw?= =?utf-8?B?bmcrUlNUUS8ranN3c3REbElPd0xsN3poUkJOMW1qMzllK2EzUlFkT2EyL1NV?= =?utf-8?B?Q01VVXQzNEtsWWZNOENpdE5QeHBGYkZSclZsTXFZYjhhUVNnMXlKWFV1SzJq?= =?utf-8?B?WjErUUNaOFg4TnlqYnRKVFFLYU1nbFhFb2dDcmJ4b3FKTGVpdTl0L0hZdHFz?= =?utf-8?B?YkYyK21jUzIzS3V4aThVMk9tOXpaMUU4WitPNmJXazArQk1LbWRqWSt1aEF0?= =?utf-8?B?KytrMWVaL0UvNzFzZFhZb29WYUJrd05tNitxV3JoMnZpSUNVWDdWS1owVWJu?= =?utf-8?B?MDdZTCtnRU1qV1l3Z3NNYXNDckZYZWtwQzBkK2Zkcm5kaHhYQXZIeXdyTE51?= =?utf-8?B?NnZNRVg3a0h4ZldHYlFPUTFtSVdjSlR5Q1VtbnpiVHJnUUd1NG5OU29IK2s1?= =?utf-8?B?QnA2eVZTQmlxTUNNN0hDQjBaSzVVZmtpcDlkbE1sUHBUS1MzeGg1SUhOVDVS?= =?utf-8?B?QjVMcllqVVZCVVNVUzlqZVdRdGM1U3BreE1NajRaQ0tJamp3MUFBTE1JbFR3?= =?utf-8?B?c0xBeDIzYld4V1VIeklXUDRtVFdwNlA5alZtUFkwOUZqSmxxbUVJZjhFbUZS?= =?utf-8?B?eVo2cXJDdWFKSGxJR2pSRWVIek55VUVxZ0pDZ2JjOHd6UDFRQ1NTQlhvZ1hs?= =?utf-8?B?bXYrbWxONkgvRGFON0NlVUk2QndUc1JBNlhpczZIdUJFNW8xdmZIemk1UmZD?= =?utf-8?B?MDZFL2JxbE9KMnQ4ZVllYkxtRWF0T012NEh1RUpzV0dleDBLaHhFZEI3Ri9J?= =?utf-8?B?bkFJbDVIRG10bnhDV0Z6ZElNSmpQQmx1NXhZbThZeUtUeU5TZEFaNXY2S2Ns?= =?utf-8?B?L3B2NU04aEozUUdiTkl5RDR1eWd2ZmpEUml0czE0T3VROFpjTGJaVVdnNzZz?= =?utf-8?B?MnAyZEtyb3hsZ2U0dzI5OFJzdTNGN092cnFBTUJNOEhSN0JoWmcrUWltNitB?= =?utf-8?B?U3V0VExGdFhMVjNLNU5ZSXRFRXhrdjExSkM1OFltZzc5VkV1ZStJSzV5czdN?= =?utf-8?B?N1drejh3SCtIRXBoc1kveTFzWUpDV0VCTnRJTEN3Yjh2NjVmQW9Wbktmb09X?= =?utf-8?B?Wko0a1N0bFdTMzE0UWxmV21neUZpUVArWTRVMk5kd25acnhGL2owNTdqQ0FW?= =?utf-8?B?THBVU2pLVnRZS25pNVgrTGFZV2Y1c3NoS203THdSc1pKb2NIZ0ZCbERJcmJo?= =?utf-8?B?NS9HT0ZxYnNmK1pLZk5MV1VIMG84bXU5eEVuT3JNaVkrcnVoalAzak8yd2Zz?= =?utf-8?B?allqbktuZnNqVzJhRitzbDBrRGE4Qlk1NkNQYXh3bnBVd3c4ODh6THZ2TGk1?= =?utf-8?B?a0lENHBFTFBNcVhCb0NPbTJwRFRJdVlvL045azRFejNyQ09iZnhQQnRXTm5F?= =?utf-8?B?V0ZkTmJaRWQ0NUpQUXY1MGlEakNjSTVheXZML0tVN1NIQTlSZEFuWk1rbFZY?= =?utf-8?Q?Tj6Kd3IXKNsL4vmDzPunRaTQ4J54tScI7CpMX2e?= X-MS-Exchange-CrossTenant-Network-Message-Id: 251b9866-2791-4578-0ae3-08d8e548ad02 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 11:19:17.7992 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I2UKPvgMy+NvhRRiJInE8LjEzqkzYIdfZK7yPW6QHfc5yndHraZhRGkNgyxCyUzgraRFDUvi/PP+vZ7qM0EYRunIJDTZRtUouC20f7B0BQI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4388 X-OriginatorOrg: citrix.com On 12/03/2021 07:54, Jan Beulich wrote: > Prior to 4.15 Linux, when running in PV mode, did not install a #GP > handler early enough to cover for example the rdmsrl_safe() of > MSR_K8_TSEG_ADDR in bsp_init_amd() (not to speak of the unguarded read > of MSR_K7_HWCR later in the same function). The respective change > (42b3a4cb5609 "x86/xen: Support early interrupts in xen pv guests") was > backported to 4.14, but no further - presumably since it wasn't really > easy because of other dependencies. > > Therefore, to prevent our change in the handling of guest MSR accesses > to render PV Linux 4.13 and older unusable on at least AMD systems, make > the raising of #GP on this paths conditional upon the guest having > installed a handler, provided of course the MSR can be read in the first > place (we would have raised #GP in that case even before). Producing > zero for reads isn't necessarily correct and may trip code trying to > detect presence of MSRs early, but since such detection logic won't work > without a #GP handler anyway, this ought to be a fair workaround. > > Signed-off-by: Jan Beulich > Release-Acked-by: Ian Jackson I am still of the firm belief that this is the wrong course of action. It is deliberately papering over error handling bugs which, in the NetBSD case, literally created memory corruption scenarios.=C2=A0 (Yes - th= at was a WRMSR not RDMSR, but the general point still stands, particularly in light of your expectation to do the same to the WRMSR). It is one thing to not realise that we have a trainwreck here.=C2=A0 Its totally another to take wilful action to keep current and all future guests broken in the same way. The *only* case where it is acceptable to skip error handling is if the VM admin has specifically signed their life away to say that they'll accept the, now discovered, potential-memory-corrupion consequences. Rogers patch already does this. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 12 11:24:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 11:24:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97028.184139 (Exim 4.92) (envelope-from ) id 1lKfu1-0006EE-38; Fri, 12 Mar 2021 11:24:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97028.184139; Fri, 12 Mar 2021 11:24:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKfu0-0006E7-W6; Fri, 12 Mar 2021 11:24:20 +0000 Received: by outflank-mailman (input) for mailman id 97028; Fri, 12 Mar 2021 11:24:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKftz-0006E2-RG for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 11:24:19 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1c7fe792-0423-4c33-ad23-a4168172364b; Fri, 12 Mar 2021 11:24:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c7fe792-0423-4c33-ad23-a4168172364b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615548259; h=from:to:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=m9WeZJLH3Jfij/W8i2dxvoR4y00n894swAc1kcs58sU=; b=RicV8jI4c5JblQQbWpniTc+vYz79JtEytlXacoN2sMHNruye72WNdhRK vK81EUYnsjEUc8tv5PJNsJK3NfGfDyOZfcAQdyIpEVQc9v3jkWzX3xZBc v/TTdP4VqOR9agtixbZrQ8FBW9XT+fxmraE0fFJagxXvCYDjPPrnFpMPw s=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 5doDNDZHwCB8R2ldLcSfpcXl18dNYI11nYz0hsfJQt6KGK55nky27z1YRCNSbZVcuL3N1QCvQR 6ZEe1kNgcLyCe6qtTYjAruWtogxFebv/Ijr0TWfg/CVPDnHIl2bUEhYU1kq+jCFIFZxtVDZ9TN XbLE3Wa11nK817xBpQjJ+fWDH6s9njBlKjjIoHnv91N9zEaJSiaI6kketqM8XIQSCPfMAWCuni h87fT4bgPrNRDtacRWBAv9tKm348h52tWYXgOjfdywH1tPdURnY7ymFw/LRDE+PMfdMXfIO5xw Gt4= X-SBRS: 5.2 X-MesageID: 39050134 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:evbN7a2mP0bHd4jTwbYNegqjBRB3eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/FIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFmtJ1/Z xLN5JzANiYNzVHpO7x6gWgDpIEyN6I7KiniY7lvg9QZCttbLxt6Bo8KivzKDw6eCBtA50lGJ 2Aou9OoDS9cXoaB/7LfUUtde7FutHNidbaehYAHREq802jijmv5b78HXGjr1sjehlIxqov9n WArhzh6syYwruG4zL/90uW1ZRZn9P91sBObfbjtuE5Iijh4zzYArhJdKaFuFkO0YKSwXILtP WJnBs6JcR07BrqDy6IiD/gwRPp3jpry1KK8y7gvVLZrcb0RC03BqN67OozGHq412MasMxhy6 UO5mqFtvNsfEr9tR7g7NvFXQwCrDvQnVMekPUeh3EacYwSZK45l/15wGppEYwNFC+/1YY/EO MGNrC52N9qdzqhHhLkl1gq5ObpcmU4Hx+ATERHkNeSySJqkHdwyFZd7NADn18bnahNBaVs1q DhCOBFhbtORsgZYeZWH+EaW/a6DWTLXFblLH+SG1L6D6sKUki96qLf0fEQ3qWHaZYIxJw9lN DqS1VDr1M/fEroFImo0IBU9AvOBEGwRy7kxM0bx5URgMy9eJPbdQm4DHw+mcqppPsSRufBXe yoBZ5QC/j/aWT0H4JE2BD/RolSJXESXNZ9gKd4Z3u+5ubwbqH6vO3Sd/jeYJD3Fyw/Z2/5Cn wfGDj/Tf8wq3yDazvdulz8Snntckvw8dZbC67B5dUez4ALK8lJuggRglKp+9GTJVR5w+gLVX o7BImivrKwpGGw82qNxX5uIABhAkFc56ilVWhLqw8MO0b9aq0CpN2bZGBX0BK8V1xCZvKTND Qai0V8+KqxIZDV7zslEcibPmWTiGZWuGiHVI4GmqqI5d7sf5QxCppOYt03KSz7UzhO3Sp6om ZKbwEJAnLFHjT1kKO/kdg/H+fEbeRxhw+tPO9ZoX/Srl+nuMkqX3cXNgTeF/K/sEILfX50jk c027IDiLCA8AzfU1cXsaAdChlwT0i5RJhBFx+IYY1InKuDQnAMcU66wRqAix8yfWL28V41nW KJF1zNRdjCHkddtndE0qzj7VNzcSGHc1htb21h2LcNaljuqzJ91/SGabG01HbUYlwewvsFOD WAejcKJBhyrurHnSK9iXKHHXUiyo5GBJ2gMJ0zN7XS0GiqMouGiOUPGOJV5o9sMLnVw5g2eP Pafw+eNzXjDew1nwSTu3Y+ISFx7H0pi+nh1hGg7G+22hcEcIzvCUUjQ7EQONeH6Wf4A/6OzZ VilNow+fKqLX+ZUK/19YjHKzpYbh/Dq2+/SO8l7ZhSoKIprbN2W53WSyHB2n1L1Ag3Rf2E3H 82UeB++vTMK4Vvd8sdd2ZC8l0lmM+GIUErvgb1a9VOCW0FnjveJZeE8rDIob0gDgmdvwP2I0 CY6DAY8PHfXSePvIRqQJ4YMCBTcgw753tj9u/ZKNGVBwWuau1Z/F21dnW6a6RQTaCZGbMW6h Z2iuv479O/Zm79wkTXuzA+P6dFt2CgSsm2CBiXGeFJ/8ehUG7895eC8Yq2lnPvVTC/a04Eno VLekwbc9RbhlAZ/fwK+zn3Trayv1ksnFRf6yx2j1Lh2oCp52HAAEFNWDep8al+TH1UKXiHjc PM7Oie2jD8+VF+qOf+KHs= X-IronPort-AV: E=Sophos;i="5.81,243,1610427600"; d="scan'208";a="39050134" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SYZd7GG2i0COZNJp7QndNNSVRjXKqDZRLWT1MExrlHXWYln+LZKqZbeJOeiaxbPFGNh3/V3140gi0TSPl+yW7YTsyc1iWW4auL2fe0NiRX3q9aqUygxfq2AoSySiGFiNUaoqc6DOm5UT5oIBS36P0Fsi4GE0v59kgk5hGM3h3trU6Qo/iQnbWjnih/AkSeZREG4x2i8ZmpJSND1eadLCsfJjuw5Gna8WKMHwhufWosAjEaNH6QWJWVXETs0tVN0Wk9aADpPuo7CZLrBCdrU9PMBtuANWEp5f6jqdhKktH0yfpdsucO+jH+arFeiYFoXEeSZDIMMYE6Tx065BLqPDYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m9WeZJLH3Jfij/W8i2dxvoR4y00n894swAc1kcs58sU=; b=AXbYT19oKxtvp/ff1l05os3ksOf0/6CTYXB7w/wq3KYzdfmZ7bsqO20DGCzuRGGp4KA9AFNf/R+RKwVVtt4hbDyawGGWKM2xvAbBzV3OXr9ziSrx8MEYUPyKEGc5SEI8hIYb3i0BgfeItEH6PAORRf0/iZb1amERXWKX6NQbpiLyec5THqBthDX4NRBTDzjnGoVxIJanhCWe0UUcJoKnpy5w8ninOCtCkkJHdSWsdZDOZWeDj3LiAFsqUgKH02ZtbtVFRCKn6Xltp8TAncE2Fg2gec+rpedUzb67lJ3/WwWvMb8qnRTBjb94m7G1Om9ApaM7EL5AskFCLDN6ITl6Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m9WeZJLH3Jfij/W8i2dxvoR4y00n894swAc1kcs58sU=; b=eoK1TuvsZs/hd+fF2ADLMcR0y7J1AFH/Y5j0kYkVM0mFH+pkGaTN3wh2U1EUgDw3yMZnidG9e2KsaBzFUFO4VFxDNbRm+z7Gop4K/N6OutGSYhqdUnf7kjrhxTW2spgB2JgWsM4N/uq7S7zXJMySxxZgYtOwvGAnZSF9a8lQGds= From: George Dunlap To: "open list:X86" Subject: TLA files for XSA-287 and XSA-299 Thread-Topic: TLA files for XSA-287 and XSA-299 Thread-Index: AQHXFzI5g/uR9VaBnk2lG3H9JEKxLg== Date: Fri, 12 Mar 2021 11:24:10 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c63322d6-b3aa-402c-eb74-08d8e5495bf8 x-ms-traffictypediagnostic: PH0PR03MB5910: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NIErHQOKhZUv12P+ph600CaidZXc1hGvqWtq/8U+J1Kg9BtCb/YTShgMzT8Ux5PyLdEhmXSppkKFsuCmHK7voPupMiubDrskz2RcXUHovZv21FnZmkfSgplhneR+hkPnnYiMwS/9vNpjXggaFnIVEPbJEoHgRlEqRIQ2wPMs7DmA3Z8/lGja8hwkd6X5aI24JBoAeVDCas5l4Yhw939xRkSoA8oWJ9Dl3vP8MIgHmz0hEhZz1rAi60+FjQMonkb+BxX3KQybENumDbCvUz3849tPtIRp8IXzvkFc350IGbL69Eyv8Zdpa1bXbHg0z0RIaZogeQk1y0FdeZo0x1rdamx7Sq3gj80jm+YZ8i0ipLUXdlzf1ee4z1gL85VJQL5kjtL65BAX0i/LZjvCef7quf3lrxUFwoHUEHvGaOOi9xXWr2hqILqTnLzIPSyeyQgNtj0eMRo4vaQJ5MjEzGETGXO7mKyS2cGGoOIB3hGUC7ZN5q2xOe/IKx23R+LU4iUc/vTrWBTpYPACaDAlf9FALA18yE3h2xH41BxMWdbrlDSCaPKwYlXN51v2uRe24MyWIgzRAlYRnYR2Za8Npv+YojocjkuSIohIUSgIXr/fpiHpG+NiB1TAZfVyEyvEm8wV8x77jGme1GO9qkKkqmsEYw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(376002)(136003)(396003)(366004)(4744005)(33656002)(2906002)(5660300002)(66946007)(6512007)(36756003)(66446008)(6916009)(86362001)(71200400001)(8676002)(66556008)(83380400001)(64756008)(6486002)(186003)(66476007)(91956017)(26005)(76116006)(478600001)(966005)(2616005)(8936002)(6506007)(316002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?eDRrVmNQSUZldkhsVlJSYkZvTERRNGs0V3BVakk3eW5LbmZYZnA4L05USkMv?= =?utf-8?B?cUpWZ3NzRXdqMDVYc2JON2hWbG45YiszcmN4WDQreWtlOXI4WWVNWnY1Q3Nl?= =?utf-8?B?SjVJWUEvNFlYZFgvVWVkN1ZKK0prZWc0LzFUeHZ6cUVTb29QUGhBL2JoNUpo?= =?utf-8?B?WmdJSEdUc21rMGpkTUl0bXIrZnN2Sk5aZzd3T0h1bDZVZU1MbmhiVGNsTjNx?= =?utf-8?B?bVNYNkNMTWxoYnRuSHZjb0IyQmdIMkVFaEVROHIwdHk5OEN6akV6a0pLMWRN?= =?utf-8?B?ak95bTdoRE5uMm85NzJCVVRoUjNOQW1iVkQvb3pDdVZtYzgybW5zMWVBaGwz?= =?utf-8?B?emt3QlNSMmFDbUtOMjdWTDg2MGZVcHlPTHRXQlptNlArRThma3N6OHF0SXZr?= =?utf-8?B?VGtNSURGeDZIZDk2VDdsOTRQekRNZWRHVGc2Y1ZoaVlvaWhucTd5ekQyZDl1?= =?utf-8?B?dzY4U3BaTTQ2RWxRbUlXMVBCL3pPcUlLeVFGNUFDYmV4SDBaMERrS3ZoY2Jh?= =?utf-8?B?UncySWV2LzkwdnhTVVV3L3RWNjAzSklWNXM3dG5ncmlDY3MwenVqS0RZeXRi?= =?utf-8?B?bXNWVjVJRTZvWTBsMjJVT0xwcUZTQVljR2k1eEJrd3lsSDNGV0lJam1RVWtu?= =?utf-8?B?a1ZPbmwyMGZ6ZFhTdlh1YlhBQ3d4cnZIN1hTOGZFZlB4NFJxcDMzSmZIaXFS?= =?utf-8?B?QkxsWStNSnBoM3RzWHh5OVJzYUZVd3dQSndadmlPTXdwMEN5VDNRd1lFSzBY?= =?utf-8?B?bzNLSklKb0picUdRMWF6MDNtVGwvYWErS0J4WEE2MGRFcTJEcmkvNitRbyt0?= =?utf-8?B?SlJDdk5mMG9xYkZuUkRIbS94eVFpaVJJNmYrREhVSWZjR0E0Uy9OQnJCN1h1?= =?utf-8?B?dGZTMHpjVXJzZE5JK01kVjdlanRjN0kvbkJkNG1DaEtjUElTeXRIYkNqZVJk?= =?utf-8?B?MXZLejhIRXluOURIQVdBR0JNZE9FTGN2bGRKRDEyZVRnRlpqRjlaNHJXOVRH?= =?utf-8?B?Z2hYUjcwU1A3bkNnYTlOVFhVeTJoM2NLQW5ZVWIranZ5UUVZNzVteERSTFV2?= =?utf-8?B?T3FGamxDWHg3VXExQ2tidW44aFZQdk9PVjZ2UmVuQVNFWjBWemcySjJNOUNS?= =?utf-8?B?dXNQam5TOEwvSmJNdS83VW5UeWtONXZybjZpLzY1RU1ocmE3amhTdlZXakpO?= =?utf-8?B?a0NVUVFOUXMvZ0grMDQzK3hmbk5QNGFqOGRKY2Z6YTRZY09BTWxna2ZyRzhU?= =?utf-8?B?WlVZbU1ZS2grbjMwSW5xT0pTUHV3SmdvS1RPekVSaGtpS1RNcDB1M0R4dmJV?= =?utf-8?B?RXFjQjBiYWVMM0dxNHEyZkRWeDlWcjAwVHloWFdrM1RnTXU2aTU1U3g4Mndk?= =?utf-8?B?RzJvWnpyaysrekY1TURoVy9VUTZ2S0hTdjB1WWxYcWxvaU9td0hQc3FYV2tj?= =?utf-8?B?K3pvU05hT1lJamFIMVdKdktzZS9QL0VPMGhSVGdlQkQxbk9BdVptZm9DVEZE?= =?utf-8?B?Zlg4Z0plQzdXWXFwTVdxWmZuSmVlSlF6T3AzZVZjVkVMM2JSYkNEYUljNWRO?= =?utf-8?B?eHJqK2tVdlRMUGdEczZ1QWExRlg4WGtqbUVZVkJRNHMxWWFnRlcyN0F4d2dj?= =?utf-8?B?cDNIOVRITlZlTzJwL0hiUzEvSVVxd0drTWdKeTY0UmQyMXVPRk9GL1BFQUhx?= =?utf-8?B?a01xMHRqaTN2b2NMMmcxNjhQdU00UDRGMWZtL3c3cWlNeFlQNWJ0VEhOVGMv?= =?utf-8?B?b3hBNU53MFIyakIzVTdjZGs4bkNaUkh3dm5PQk5YcmpmZ0kxT0dtcGwrdTh5?= =?utf-8?B?S05oMDVrSjViK2MrUmlzZz09?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <9DA198A29502DC448141903D2FEBFA57@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c63322d6-b3aa-402c-eb74-08d8e5495bf8 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2021 11:24:11.0004 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lBz778inbGtzNd4UqN2PHcGOgfK3KmhopfnCzXei+r6gYFIlQaIcWENaHsHaOkZQBNqMRWWhA+zW0S6SgpMpJttB1GeViScTY6tfrn1HIUA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5910 X-OriginatorOrg: citrix.com SSBkb27igJl0IHRoaW5rIEkgd3JvdGUgdGhpcyB1cCBhbnl3aGVyZSB5ZXQsIGJ1dCBJIHVzZWQg VExBKyB0byB2ZXJpZnkgdGhlIGZpeGVzIGZvciBYU0EtMjk5IHNldmVyYWwgeWVhcnMgYWdvLiAg SeKAmWQgYWx3YXlzIGludGVuZGVkIHRvIHBvc3QgdGhlbSBvbmNlIHRoZSAgZW1iYXJnbyB3YXMg dXAsIGJ1dCBuZXZlciBnb3QgYXJvdW5kIHRvIGl0LiAgVExBIGNhbWUgdXAgaW4gYW4gb25saW5l IGRpc2N1c3Npb24gYm9hcmQgcmVjZW50bHksIHNvIEkgc3BlbnQgYSBiaXQgb2YgdGltZSB0byBj bGVhbiB0aGluZ3MgdXAgYW5kIGdldCB0aGVtIHBvc3RlZC4gIEhlcmUgdGhleSBhcmUsIGlmIGFu eW9uZeKAmXMgaW50ZXJlc3RlZC4NCg0KaHR0cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L3Bl b3BsZS9nZHVubGFwL3RsYQ0KDQogLUdlb3JnZQ== From xen-devel-bounces@lists.xenproject.org Fri Mar 12 11:31:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 11:31:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97035.184154 (Exim 4.92) (envelope-from ) id 1lKg0h-0007Il-0O; Fri, 12 Mar 2021 11:31:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97035.184154; Fri, 12 Mar 2021 11:31:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKg0g-0007Ie-Sr; Fri, 12 Mar 2021 11:31:14 +0000 Received: by outflank-mailman (input) for mailman id 97035; Fri, 12 Mar 2021 11:31:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKg0f-0007IY-Oz for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 11:31:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKg0f-0006hh-HT; Fri, 12 Mar 2021 11:31:13 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lKg0f-0007Sg-BG; Fri, 12 Mar 2021 11:31:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=IF4NOy+NSVk8fTfzJIy8V92/ROQlDvQmES3zBmoN9dk=; b=p/h/psG41gByennYSJ7rjUE8/c YNAK3crFy/YwUGmQKa+hPGcUHhcbqnH5z+4K+xd9zXOSR+nY7r/glSawyGJuFyzfiBzDeKjs/BOe/ jongY72bCqN2jr1tsjtYOf3eg3njSi5fsPhja6b85MWjN8kRWdcU5Y8Lj5g05wsgjlak=; Subject: Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less To: Luca Fancellu , Stefano Stabellini , Jan Beulich Cc: xen-devel@lists.xenproject.org, Volodymyr Babchuk , Bertrand Marquis , wei.chen@arm.com References: <20210308115610.48203-1-luca.fancellu@arm.com> <1921ff88-7637-6454-74a7-1cbab8dafc61@xen.org> <72E0C95C-D5E1-471B-9590-F4D42E3E066B@arm.com> From: Julien Grall Message-ID: <7ed12d12-6fed-cc3a-4a0b-76ad732d4337@xen.org> Date: Fri, 12 Mar 2021 11:31:11 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <72E0C95C-D5E1-471B-9590-F4D42E3E066B@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Luca, On 12/03/2021 09:38, Luca Fancellu wrote: >>> + >>> size_t __read_mostly dcache_line_bytes; >>> /* C entry point for boot CPU */ >>> @@ -804,7 +833,7 @@ void __init start_xen(unsigned long boot_phys_offset, >>> int cpus, i; >>> const char *cmdline; >>> struct bootmodule *xen_bootmodule; >>> - struct domain *dom0; >>> + struct domain *dom0 = NULL; >>> struct xen_domctl_createdomain dom0_cfg = { >>> .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, >>> .max_evtchn_port = -1, >>> @@ -964,28 +993,33 @@ void __init start_xen(unsigned long boot_phys_offset, >>> apply_alternatives_all(); >>> enable_errata_workarounds(); >>> - /* Create initial domain 0. */ >>> - /* The vGIC for DOM0 is exactly emulating the hardware GIC */ >>> - dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; >>> - /* >>> - * Xen vGIC supports a maximum of 992 interrupt lines. >>> - * 32 are substracted to cover local IRQs. >>> - */ >>> - dom0_cfg.arch.nr_spis = min(gic_number_lines(), (unsigned int) 992) - 32; >>> - if ( gic_number_lines() > 992 ) >>> - printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); >>> - dom0_cfg.arch.tee_type = tee_get_type(); >>> - dom0_cfg.max_vcpus = dom0_max_vcpus(); >>> - >>> - if ( iommu_enabled ) >>> - dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; >>> - >>> - dom0 = domain_create(0, &dom0_cfg, true); >>> - if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) >>> - panic("Error creating domain 0\n"); >>> - >>> - if ( construct_dom0(dom0) != 0) >>> - panic("Could not set up DOM0 guest OS\n"); >>> + if ( !is_dom0less_mode() ) >>> + { >>> + /* Create initial domain 0. */ >>> + /* The vGIC for DOM0 is exactly emulating the hardware GIC */ >>> + dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; >>> + /* >>> + * Xen vGIC supports a maximum of 992 interrupt lines. >>> + * 32 are substracted to cover local IRQs. >>> + */ >>> + dom0_cfg.arch.nr_spis = min(gic_number_lines(), (unsigned int) 992) - 32; >>> + if ( gic_number_lines() > 992 ) >>> + printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); >>> + dom0_cfg.arch.tee_type = tee_get_type(); >>> + dom0_cfg.max_vcpus = dom0_max_vcpus(); >>> + >>> + if ( iommu_enabled ) >>> + dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; >>> + >>> + dom0 = domain_create(0, &dom0_cfg, true); >>> + if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) >>> + panic("Error creating domain 0\n"); >>> + >>> + if ( construct_dom0(dom0) != 0) >>> + panic("Could not set up DOM0 guest OS\n"); >>> + } >> >> It always felt a bit strange the dom0 creation is partly happening in setup.c when for domU everythink will happen in domain_build.c. >> >> Woule you be able to create a patch that will first move the code in a new function (maybe create_dom0())? The function would return NULL in case of an error or the domain. > > Yes I will create a new patch with this change and I will put on top the v2 dom0less patch I think it would be better to put it first. This will avoid some churn if the code movmement comes second (you would first indent and then move the code). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Mar 12 11:32:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 11:32:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97039.184165 (Exim 4.92) (envelope-from ) id 1lKg21-0007RJ-Cd; Fri, 12 Mar 2021 11:32:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97039.184165; Fri, 12 Mar 2021 11:32:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKg21-0007RC-9T; Fri, 12 Mar 2021 11:32:37 +0000 Received: by outflank-mailman (input) for mailman id 97039; Fri, 12 Mar 2021 11:32:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKg1z-0007R5-FB for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 11:32:35 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1a38df6b-7e16-4a65-b8aa-f4703adb67d4; Fri, 12 Mar 2021 11:32:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a38df6b-7e16-4a65-b8aa-f4703adb67d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615548754; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=aBdTnGhhrQSul1RZpz/EXTjpMCcAdamWjoRiBr5W5nQ=; b=fJQ5uhw0T4i2A1QVA6Hjcp67gO1Zud2lgLC3/jvOc7PLpqu4GlxcCIkh zPSlGNdbclY3cb7smu5SOy/GOkgEmeJ6FtJ4fzoJvFco53bUA87iz2sUn 8ivMVjrzybB/jCWk3OK05T4tuca5JXQLMKDJixcMLOEWk8CGqlwc32ByF I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: rzMie2vwlVT0QB8YCQxUjYL5mgG2clzUh59vXM0ty5F1XQwonPLDj1VvQ//udHrmy75FKa3MZ1 vRhmywhAKc5E4XPmqNu/Qew7Z4kQ/QnOGNXxcaT5AsGfJvjS+hU8jvCd3Gsgr9J0SIFy6ciaF2 T7j7zmR4OrJZV44MWl+wD5bDj/imWeaUyWZB+3Ok14j7Ux7FKGYtPFjJY1GkRU427ZuWvYC80F 8svH8ifQPSuhReCnYgy+H94QnoWll26Bkt2PlK9wmyNOK7gZrYDV6lxJU/1EkYdRRLoSqX73Zg e54= X-SBRS: 5.2 X-MesageID: 39050510 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:kwTN3Kqd/kjJKUlPFnZuTgwaV5uGKtV00zAX/kB9WHVpW+SivY SHgOkb2RjoiDwYRXEnnpS6NLOdRG7HnKQb3aA4Bp3neAX9omOnIMVZ7YXkyyD9ACGWzIJg/I 9aWexFBNX0ZGIWse/T/BS4H9E8wNOO7aCvgqPkw21wSBxxApsA0y5SIG+gYyhLbSNBAoc0E4 fZw8JBqSapd3h/VLXFOlAuWe/fq9rX0K/8aRkdCBI9rCWIhzWk6Ln1eiLoois2eTVJ3Lsk7C z5gxX0j5/Tzs2T5z398yvo75pQkMb80dcrPqKxo+UcNzmEsHfRWK1PQLuH1QpFx92HyFFvq9 XUpgdlAsIb0QKqQkiQgT/Anzbtyywv7XiK8y7qvVLGrdbiTDw3T+pt7LgpCyfx0EYrsNFi3K 8j5Qvw3PA2fHCw6RjV3NTGWwpnkUC5uxMZ4IoupkdSTJcEb/tppZEflXklYKsoJj7w64wsDY BVfafhzctRGGnqDUzxgnNi25iFUHg1A369MzM/k/3Q+T1XkHdl9lAf1cwSk1wRnahNOqVs1q DqNL9lm6pJSdJTRaVhBP0ZSc/yMWDVRwnQWVjibmjPJeUiATbgupT36LI66KWDf4EJ9oI7nN DkXElDvWA/VkryAaS1rdN22yGIZF/4cSXmy8lY6ZQ8kKb7XqDXPSqKT01ru9e8ot0Ea/erGM qbCdZzObvOPGHuEYFG00nVQJ9JM0QTV8UTp5ISR0+OmMTWMYfn39arMMr7Ff7IK3IJS2n/Cn wMUHzYP8Nb9H2mXXf+nVz/QHXoVkvj/Y9hMaTT8uQJobJ9c7Fkg0wwsxCU98uLITpNvugdZ0 1lOo7qlau9uC2X8A/zniFUEysYKnwQzKTrUntMqwNPGVjza6w/t9KWfn0X+HOGIxR4Xv7HCQ I3nSUxxYuHa7irgQwyAdOuNWyXy1EJomiRcpsakqqfoeDoZ40/FZRjfKBqDw3EG1hUlG9R2S Z+QT5BYnWaOiLliK2jgpBRLvrYbcNAjACiJtMRj2neu0WarcQGXWAaQDaqbM6SjW8VNnhpr2 w015VarKuLmD6pJ2d6qv8/KkdwZGOeB68DMB6If7xOmrfgeBh5SECDgTDysWB0RkPas2Epwk DxJyydfv/GRn5QoGpR3KrR/FRoTWmFZE5rZndmsYpyKHTeth9IoJ22T5v291HURkoJw+kbPj 2AWzcULw907/2c1RKeml+5ZD8b76RrGtaYIKUocrnV1H/oFZaBkrseGeRIuLx/Msr1j+MNWe WDWgOcIT/iEdk10wiNqntNAlgslFAU1dfTnDH15mmx23AyRcfIKFN9XrcBPpWy6XPnS/vg6u QxsfsF+c+LdkP/Zd6NxfuJM3ptKhbPrXW3SO9tg5ZOpq42vKZyGZ6ecTag7gAx4DwOaOPP0G UZS+BHxZqEHKlFVckbYThY8Vokj87nFjphjiXGRssFOWgwhHraNe6T67XGqbATElSMzTGATW W3wml4xbP5RCON2r4RNrIoLUlXYEY67m5+/OnqTfynNCyaM8VC9kG9KHmzbft0T7WEA6wZqn 9Bkpy1tt7SUyrzwwbLuzRnZopI7ma8WMu3RCaBA/RB/dD/GVOChMKRkYKOpQaybTuwcEIDg4 JZMWQWc8RYkzEnyLQN7RLacN2+nmsV131E4T9mkVbx2o+ppEfjdHs2TzHxs9FxRjlcMn+BkM Lf1/OXvU6NuAR45Q== X-IronPort-AV: E=Sophos;i="5.81,243,1610427600"; d="scan'208";a="39050510" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y6d/wjNPbY8DYbha1d6NEZNnvYc2nsMTR9ed+FO4jZDNlYwFlxsg5NOUXO0E7GK1ShbYYupmHV0ZQPBCYIV5RogcmVMOqr11kDwaDYrT6MV+LyMKBkn+zsT5ZCZ90sIGBlpv7Iz9d3DlUymAgV0UF4vyavsOnGgRozgWunO9EK1XJ0UbR7kx8FpJCHZgUKMM7EhErScD/eDfTfI1LgnmUbpOOmmp11erjO5HSkwK0JatG2ZtBlfxOZnoGHnoMoIsvb4Vr/+g2uvM46PA8N11f4gGJcdtDGcnORaTNXxtpaZwmqRJn8t1flUwchLBbg4LphXxkpy4SMlRvuzXpmnZZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OipArakd9AaJeEKxw3eFbyi0e1wSm70+BLcthU5Ler4=; b=YWABBXS+vFEkeYh6Gd4FzHBsT72cTs77AuW1oJIYDQQEeh7K2PPRwz5hivlTpnYiw0MSZmECd/NyXP9XRGqEZWErvLbUnGtWbnJncag72XqmDG7WQ6wrdvALucUfDSHCQp28VysZkqHWt9ZRVuVrebzXSQk5nefpzpIhpEG8d8aA7AOx/LUVDndAY3gmE4mQgLMg3p8ofbPkKzRhewgChBh+UGcQipWDKSRiStwdiIPexqJkcSEl1qSqEtjmS9+IQv5bUOY1iQrGaNeLrDau7aEFarzVtyZT5OaZiIY+Id88vKOnCtuum/6d+/jM4YxpN/PXJnDKt2zAhwiKFMMLeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OipArakd9AaJeEKxw3eFbyi0e1wSm70+BLcthU5Ler4=; b=h5lsugTX7/IBtEURJTnVJUleQk0QHQEHMNpPCOSfpzgnttTdr1WDkfQFmgaO/D7xcd8VB/FOSMBWRzp1HpiHGwQ5UOx9S+S6MtyB3Fclco1/osv/mV+D+dYlIzwfqdOmpudGEV9TC0uu0JYj67EfR8ENjcggNulRSnI4RlE1qZo= To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: From: Andrew Cooper Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning Message-ID: <1642726c-0134-fb90-164a-e49672f613ff@citrix.com> Date: Fri, 12 Mar 2021 11:32:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LNXP123CA0013.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::25) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c2642243-af7a-415b-cd78-08d8e54a853a X-MS-TrafficTypeDiagnostic: BN7PR03MB3731: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RZULfqUhJmSTwGZrDBlWMaASPoprhswkijl48298jIqMVDfxWw8DOfctsylQx/Hska5WMBesE/anyYTI0Pp3/BfnrcFlITTEqiHL3iAtbPMXdPg58j9tTVrKZNSRf46TPQekCH81rytqB1E+SpI83st2Zg+jHCQOfQFH84YKEqAdKNoYjInpaTP+DhaHqc6FTXI6LCSTuZUijD7qHTYpnXGkiF7FTSmXjS0qdfVRJIXlSR++chTUX0ZYiL+JAiUMOeRWKaJxvKnOOPn2ZHb33BRerFTVQM8NIcwJ9pVprOtSTNxqqrq31Pj03Pgvw8UnWmEu/XDwdPi3PKsFd9gtkJ/tnrLlTfpF55isDKstNa4XY+gLjgoRYh8Aq2TVkQ6+IoATMIq4Bk9CjLe//OAWUWEQPBEPRZY4Y5hbdxmCvuqyYQqnaT3VL5/z2jtrDohykWQquXVujbukJNbHzHTgWXGlnNf6duevw/VfB2kCfeGcGWkk0pbi6607GJipV5wOQOqKNFoZvarocZ3q1aFo09psQVeqlg9zarqLCTiwZB/BPRhWVlIWXq5H/2q4WR2aqXmpRQcPMvyccR77TsysgoDbS+3u8IIUUdBYJhbfmHhWc+LlXti1TECHV6ZyVn8hdRGrWdDYs3S0VLyOyJoBOA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(376002)(136003)(39860400002)(396003)(31686004)(66556008)(66476007)(186003)(26005)(16526019)(66946007)(8676002)(478600001)(2906002)(8936002)(956004)(2616005)(4326008)(86362001)(53546011)(31696002)(36756003)(6486002)(5660300002)(54906003)(316002)(16576012)(6666004)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?QlNZOEhxOUVFbDR4eld5SXR0VFJSdlNwYkFBTDVjS2RHMEZHb2tQRzZjR1dY?= =?utf-8?B?cjhoR2ZJRlpPTTl4cGhYVmlPYUJBb0lLelRkMXk5RDI2U2JxUDZ2cjE4YTQ1?= =?utf-8?B?WlJKTDJzZmxMQ25PTVg1dzRWSUZlOVRkWGkwL2xadi9WaFlDU0NTZjlmNHdi?= =?utf-8?B?WkNBSTdxY0ljeFVGbHAwVGFKaWIvQSt5dnUvRkhaZDRqN2hFV1orcTRFZ08x?= =?utf-8?B?eWFyeTVqemR6aVV6cHdYdXVTZVF4YWhFbVI5TEdOYXdFc0UrWEthNzNrQ1Vi?= =?utf-8?B?aUUzQ0ZTQU9DRERDbEpMZHBzQTlOSWFMb3BXeTVrS2syUmRGZTYxb3d5eEk3?= =?utf-8?B?K3pIU2pkZjdTRVJFSTcrdWdjN2dGNityRHJLWlJoUkU5ajdPVU4yNXpHcndl?= =?utf-8?B?bERtN3BSVHA4Umx6Q2NQSHAzK05jQjdJMXFqaHFqaCtXcVcxeU1MNHhTcWhW?= =?utf-8?B?OEIrM2JvNUVUeUcrUkkzbHNFdzJReTZ4WkU4TksvTGVIckl3TnNtUHBRc3RM?= =?utf-8?B?Y3BuUXNxNHRlWU43eE9PcjNINVZzTEJGbkF5b2I5aWNZUE5vVFFEWVJsWGx4?= =?utf-8?B?aUFDS0hpMDZGRGc4K2dtRmZGbXkvMnFwTTQwSUdDSWR3b3M0TVhhLzZ1QmY3?= =?utf-8?B?RkhCSytMamloSVNScXY5UU1KV1E5a2hWRXM2NzByRlpiaFBXZE1kdjI4RnNW?= =?utf-8?B?bG1qNm0xK0hkY0FhRU5NbU9TMDFETTQ0S2dCWlZ5M2o3YUlidGZvY2ZCSHhP?= =?utf-8?B?QjQ2UEdFTFlDczVBNWdNajlZclZKQVFFU0UzL2lVV3NqaXJ1RWVxdnJLWWYr?= =?utf-8?B?QUJTc0FqNVluT3hhYUVHVzNaZGliM3c1Q1dKREFaSGwzSmlJWVJGN3dJUWhV?= =?utf-8?B?YkhqTFMyOTYrVzAxWlgzd3g1RUxWNnZIZHNYN3dtcXFuUjBVdTVjVmdxRmVI?= =?utf-8?B?Z3MzdU95WDNmMW9xdFNLSkROK05UK2hmK1NqZmtBT1VyVytEVjhLZjhpVDdK?= =?utf-8?B?Q1B1RGQyZmt2MkE0b05uWUJFSjhIOU1ibERxQW01bFY0WGExZ2Nzd0pYSG1j?= =?utf-8?B?RE9TcENFa2VQWU9DN1ltUlpQRlZHZU5sR2x1ZFhib2o3OUlHaG1RMWhML2cr?= =?utf-8?B?NmI1ckVtTTdJaklyM2dtVStsUEprZ3FlWjREdlIxZHphZk1aNlk5ejgzdHRE?= =?utf-8?B?RWFCb0EzNlVKSDQ1NnJsaWNBNmxBdHRzbWtoWjVCNXpDT2VnRG0zOUxpOWM0?= =?utf-8?B?RGdnZmthVmZHT2lJY1JsZzd6a24zclc5NmpzOC9ZWUEvZXRzZUNjczlKcm00?= =?utf-8?B?Ym04NnFDRGdPUmdjSXhuaXBEWCtkc3JLY3VKcDV0WXN4K1dMSFhobWhWT3FG?= =?utf-8?B?cVQ2WnNCMjQ1WERKMVJJdng1YncvNU9MYldsRms5ZWJrWmNwVXpYVXRqcWFY?= =?utf-8?B?THJ1QVlTNEliZ0NZUHdIVVRhV3RMNUdVZ0JuZWtrdXptWHBLbkJ0ODdBL25X?= =?utf-8?B?Vjc4ZktBSE5rMkgreHFEdkwzTGd4ZEpmMFBKNTRVNGNSUXQ4QVE3UUxoVnNa?= =?utf-8?B?d1h4T3dvWUdzaENnbmJ1NHpLOVFnTVc3NDFnRHJoUGxOQ1pkMEYyZlpkbTNY?= =?utf-8?B?Z09HL1hRN24zVlFtVEFDaFJxaWZZTTFDN3gweTh5NUk5YmdVSUtuVUVJWHBU?= =?utf-8?B?cXJ5OEU2a2FUWGFBdWxwbU9vMmxRaDZVb3c2R1pZM2llNTJSVDJiN0hPdE1P?= =?utf-8?Q?6A+JxkXx5eUfD35IgCF3SCYfF9fdUdMPtRSVfPp?= X-MS-Exchange-CrossTenant-Network-Message-Id: c2642243-af7a-415b-cd78-08d8e54a853a X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 11:32:30.0947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mXSl+ISfacABkKgMhwrrDoDADbZXSyIgJoRBdFlAs2C0BDBWxZTUeFkVC8Tv/B3p2WNzyst1OfpOLk8XsoC/n4Hsv7X2pZBaWGmDosCWNiI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3731 X-OriginatorOrg: citrix.com On 10/03/2021 10:13, Jan Beulich wrote: > Sadly I was wrong to suggest dropping vaddrs' initializer during review > of v2 of the patch introducing this code. gcc 4.3 can't cope. > > Fixes: 52531c734ea1 ("xen/gnttab: Rework resource acquisition") > Signed-off-by: Jan Beulich > > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -4026,7 +4026,7 @@ int gnttab_acquire_resource( > struct grant_table *gt =3D d->grant_table; > unsigned int i, final_frame; > mfn_t tmp; > - void **vaddrs; > + void **vaddrs =3D NULL; > int rc =3D -EINVAL; > =20 > if ( !nr_frames ) in v1, there was a companion check. diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index f937c1d350..2bb07f129f 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -4059,6 +4059,16 @@ int gnttab_acquire_resource( =C2=A0=C2=A0=C2=A0=C2=A0 if ( rc ) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto out; =C2=A0 +=C2=A0=C2=A0=C2=A0 /* +=C2=A0=C2=A0=C2=A0=C2=A0 * Some older toolchains can't spot that vaddrs is= non-NULL on non-error +=C2=A0=C2=A0=C2=A0=C2=A0 * paths.=C2=A0 Leave some runtime safety. +=C2=A0=C2=A0=C2=A0=C2=A0 */ +=C2=A0=C2=A0=C2=A0 if ( !vaddrs ) +=C2=A0=C2=A0=C2=A0 { +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ASSERT_UNREACHABLE(); +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto out; +=C2=A0=C2=A0=C2=A0 } + =C2=A0=C2=A0=C2=A0=C2=A0 for ( i =3D 0; i < nr_frames; ++i ) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mfn_list[i] =3D virt_to_mf= n(vaddrs[frame + i]); =C2=A0 With this reinstated, Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Fri Mar 12 12:27:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 12:27:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97066.184205 (Exim 4.92) (envelope-from ) id 1lKgtJ-0004OM-6z; Fri, 12 Mar 2021 12:27:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97066.184205; Fri, 12 Mar 2021 12:27:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKgtJ-0004OF-40; Fri, 12 Mar 2021 12:27:41 +0000 Received: by outflank-mailman (input) for mailman id 97066; Fri, 12 Mar 2021 12:27:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKgtH-0004Nr-FF; Fri, 12 Mar 2021 12:27:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKgtH-0007cD-Ap; Fri, 12 Mar 2021 12:27:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKgtH-0005c1-1n; Fri, 12 Mar 2021 12:27:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKgtH-0007mR-1J; Fri, 12 Mar 2021 12:27:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PXFauPvdF0oerxjbig3j91v2Lu5knsX5jWnHhUbBw+A=; b=o7E+dSlpXY2H/yHByuLhTesw4l RnWfUoSF0XL7ovAdFugJlmZOGQdDS44BUg9AGWhlZ6T3sycEMogVIHB6gB/hehi2JbwuE66v/gJrS mthziRHbeHa4uHSAGhL9UIi4HLOON8SxKpaIorXGcsj58nDKzEdpwRao7cXIug907ut4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 159950: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=28806e4d9b97865b450d72156e9ad229f2067f0b X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Fri, 12 Mar 2021 12:27:39 +0000 flight 159950 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159950/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux 28806e4d9b97865b450d72156e9ad229f2067f0b baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 223 days Failing since 152366 2020-08-01 20:49:34 Z 222 days 385 attempts Testing same since 159950 2021-03-11 22:43:43 Z 0 days 1 attempts ------------------------------------------------------------ 5182 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1284683 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Mar 12 13:08:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 13:08:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97094.184234 (Exim 4.92) (envelope-from ) id 1lKhWy-0008Uw-QM; Fri, 12 Mar 2021 13:08:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97094.184234; Fri, 12 Mar 2021 13:08:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKhWy-0008Up-NT; Fri, 12 Mar 2021 13:08:40 +0000 Received: by outflank-mailman (input) for mailman id 97094; Fri, 12 Mar 2021 13:08:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKhWx-0008UR-MD for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 13:08:39 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 094ff024-4a92-4b7c-a87f-1b7901358e96; Fri, 12 Mar 2021 13:08:38 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 36451B0D2; Fri, 12 Mar 2021 13:08:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 094ff024-4a92-4b7c-a87f-1b7901358e96 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615554517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qNkz0+Qb+1pUFJPyd9GrRxqT8lH+5z8lWkV51uiM+KU=; b=BCR+fGZjcX+Ni9v3mEXm9beOrtnIYyT0zu8B0SQavaJsrcq8LOACG+Otrq76RMf4hwx4gj El81fspNkjkXMh+XTgrZ0sZe8ph7yuU8PBI7VSodibYKIbmxeeRECHMauGaflU87tRr5eP YvsHBsFtc/D27ZYalPbfiR4hUukbkss= Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning To: Andrew Cooper Cc: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <1642726c-0134-fb90-164a-e49672f613ff@citrix.com> From: Jan Beulich Message-ID: <81539e7d-6b3c-8261-6959-67ef1dc136bf@suse.com> Date: Fri, 12 Mar 2021 14:08:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <1642726c-0134-fb90-164a-e49672f613ff@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 12.03.2021 12:32, Andrew Cooper wrote: > On 10/03/2021 10:13, Jan Beulich wrote: >> Sadly I was wrong to suggest dropping vaddrs' initializer during review >> of v2 of the patch introducing this code. gcc 4.3 can't cope. >> >> Fixes: 52531c734ea1 ("xen/gnttab: Rework resource acquisition") >> Signed-off-by: Jan Beulich >> >> --- a/xen/common/grant_table.c >> +++ b/xen/common/grant_table.c >> @@ -4026,7 +4026,7 @@ int gnttab_acquire_resource( >> struct grant_table *gt = d->grant_table; >> unsigned int i, final_frame; >> mfn_t tmp; >> - void **vaddrs; >> + void **vaddrs = NULL; >> int rc = -EINVAL; >> >> if ( !nr_frames ) > > in v1, there was a companion check. > > diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c > index f937c1d350..2bb07f129f 100644 > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -4059,6 +4059,16 @@ int gnttab_acquire_resource( >      if ( rc ) >          goto out; >   > +    /* > +     * Some older toolchains can't spot that vaddrs is non-NULL on > non-error > +     * paths.  Leave some runtime safety. > +     */ > +    if ( !vaddrs ) > +    { > +        ASSERT_UNREACHABLE(); > +        goto out; > +    } > + >      for ( i = 0; i < nr_frames; ++i ) >          mfn_list[i] = virt_to_mfn(vaddrs[frame + i]); Oh, I didn't realize this. Will add, but did you really mean to have the function return success in this case (on a release build)? I'd be inclined to put it ahead of if "if ( rc )" and set rc (to e.g. -ENODATA) in this case. > With this reinstated, Acked-by: Andrew Cooper Thanks. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 13:18:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 13:18:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97101.184250 (Exim 4.92) (envelope-from ) id 1lKhgk-0001A8-Rt; Fri, 12 Mar 2021 13:18:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97101.184250; Fri, 12 Mar 2021 13:18:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKhgk-0001A1-Oh; Fri, 12 Mar 2021 13:18:46 +0000 Received: by outflank-mailman (input) for mailman id 97101; Fri, 12 Mar 2021 13:18:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKhgj-00019w-J7 for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 13:18:45 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e332d14a-f276-4e33-b902-34eabe31da73; Fri, 12 Mar 2021 13:18:44 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9F106AF4D; Fri, 12 Mar 2021 13:18:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e332d14a-f276-4e33-b902-34eabe31da73 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615555123; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oUfjyU7YmCpl1tB6qq8jEeha7KvF4k+/iVu3tJ6jnMU=; b=nLdA8ybP40ksHs76pgaqJ8XixDl9v+FfxEyYVvqf0nqa18exXNOVDc8RMhf9ZA2zf9atDS 5EgX+GjoLhPpOOUB06u2O/bV9fsOX7tHlref5KGPk2niJ7ncGRXcGZ5dzm2J9tgYvzLc4c Mq+aAUjNVSmHm7T/ZOKwyOKcg855B14= Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning From: Jan Beulich To: Andrew Cooper Cc: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <1642726c-0134-fb90-164a-e49672f613ff@citrix.com> <81539e7d-6b3c-8261-6959-67ef1dc136bf@suse.com> Message-ID: <24c07e5f-4ca4-95cd-503d-2dd87579ee5c@suse.com> Date: Fri, 12 Mar 2021 14:18:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <81539e7d-6b3c-8261-6959-67ef1dc136bf@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 12.03.2021 14:08, Jan Beulich wrote: > On 12.03.2021 12:32, Andrew Cooper wrote: >> --- a/xen/common/grant_table.c >> +++ b/xen/common/grant_table.c >> @@ -4059,6 +4059,16 @@ int gnttab_acquire_resource( >>      if ( rc ) >>          goto out; >>   >> +    /* >> +     * Some older toolchains can't spot that vaddrs is non-NULL on >> non-error >> +     * paths.  Leave some runtime safety. >> +     */ >> +    if ( !vaddrs ) >> +    { >> +        ASSERT_UNREACHABLE(); >> +        goto out; >> +    } >> + >>      for ( i = 0; i < nr_frames; ++i ) >>          mfn_list[i] = virt_to_mfn(vaddrs[frame + i]); > > Oh, I didn't realize this. Will add, but did you really mean to > have the function return success in this case (on a release > build)? I'd be inclined to put it ahead of if "if ( rc )" and > set rc (to e.g. -ENODATA) in this case. But I think the comment isn't really correct - the problem isn't NULL or not, but uninitialized without setting it to NULL. How about /* * Some older toolchains can't spot that vaddrs won't remain uninitialized * on non-error paths, and hence it needs setting to NULL at the top of the * function. Leave some runtime safety. */ ? Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 13:21:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 13:21:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97107.184265 (Exim 4.92) (envelope-from ) id 1lKhjA-0001zQ-Gn; Fri, 12 Mar 2021 13:21:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97107.184265; Fri, 12 Mar 2021 13:21:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKhjA-0001zJ-DJ; Fri, 12 Mar 2021 13:21:16 +0000 Received: by outflank-mailman (input) for mailman id 97107; Fri, 12 Mar 2021 13:21:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKhj8-0001zE-B5 for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 13:21:14 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6122797a-ac98-4b88-a168-4377befb6328; Fri, 12 Mar 2021 13:21:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6122797a-ac98-4b88-a168-4377befb6328 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615555273; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=OnlCNOh5rRjeah5vtIARS6VgM4v1vqKyOYJaMmmBVIM=; b=Hmi7kI6qmgyaxp+MM9XKy599jOyLwqRa15V3t16QHu6u/6ULynM4DuWZ LUI8D3gFKXIvC9LL0tJ5DYINWbSyb7pm8LcI2no5KDriJkJkbZRSwxxag IXTs5r1glp47BTdrDl1MHzIbJ4r7GaYOKzQhdRNCrXYssGf/mEvaMOBXj I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 7RMJFpVsHvucT/6Xk4Jj+cdF4vBWx4Br0IQi4XmV5IbgYEiPnlIwkyvz65BQQz1kZAYVUCnlE2 2TZ7BlBt4vXfsweUYe2/GjFkA8zCQqAZMGTlLu600vmxqyweruynrgSHgAu55WGTaiWgSECL6T Bv43Hmu8K+G6fKEJG0ulLOYHWhW72mE7CQkcfLKoX59/lY8GglGX9/W4QYvyIb0wk1gk5yRTxA X/4XSPpixulV/2L8oAIGSmmQ0DkLqxDF+ZmzJRj3uG+XY5a0gA/Z6RJP2M17N8eNh+uI2H2zZH dAw= X-SBRS: 5.2 X-MesageID: 39327003 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:/34Uy6uvbI8rSIm9qG7Ie6il7skC24Yji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOjrU5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qw6Y 5JSII7MtH5CDFB4PrSyBWkEtom3dmM+L2pg+Cb9Ht2UQR2cchbjjtRICzzKDwTeCBtA50lGJ 2Aou9OoDS9cXoaB/7LeUUtde7FutHNidbaehYAHREq802jijmv5b78HXGjr2sjehlIxqov9n WArhzh6syYwoyG4zL/90uW1ZRZn9P91sBObfbjtuE5Iijh4zzYHLhJdKaFuFkO0YeSwXYs1O LBuhIxe/l0gkmhBF2dhTvI903e3C0163nkoGXo8kfLhcDiXjo1B45gqOtiA2LkwnEttt19z6 5Htljx3/E8bWKi7VHAzuPFWB1wmk2/rWBKq591s1VlXZYDc7gUlIQD/SpuYec9NRjn44MqGv QGNrC/2N9qdzqhHhXkl1V0zMfpdno+GQrueDl4huWllxJSnHx/0nICwt0eknoq5PsGOuh5zt WBHaJymL5USMgKKYp7GecaWMOyTlfAWBTWLQupUBvaPZBCH0iIh4/84b0z6u3vUJsUzKEqkJ CEdF9Dr2Y9d2/nFMXm5uwEzjn9BEGGGRj9wMBX4JZ0/pfmQqDwDCGFQFcy1+O9vvQ2GKTgKr WOEaMTJ8WmAXrlGI5P0QG7cYJVM2MiXMocvct+c06So/jMNpbhuoXgAbbuDYuoNQxhdnL0A3 MFUjS2Dt5H9FqXVnjxhwWUdGjqfmD54JJsAInX9+Ue0+E2R8hxmzlQrW78ytCAKDVEvKBzVl B5OqnbnqSyonTz3Wug1RQsBjNtSmJupJnwWXJDogEHd2nud6wYhtmZcWdOmF+OJhp1SdLqAB dSzm4Hvp6fHti1/2QPGtinOmWVgz84v3SRVaoRnaWF+IPDdo4nCI0lHIh8Dx/CGRAwuQsCkh YDVCY0AmvkUh/+g6Ssi5IZQMvFccNnvQutKclI7VTFtUudoskrbmABXyGnVPOWhQpGfUsXun RBt4skxJaQkzemLmUyxM4iNkdXVWiRCLVaSDieaJ5sgbDtcgFoRWKsjTiX4itDPFbCxgE3vC jMPCeUcfbEDh54tmpD2qjnyl9ya16QZll9cHx8rI17G1nXo3ob6574WoODl0+qLncSyOAUNz /IJQEfJQ5j3Pib/h+YkjTqLwRt+rweesjmSJgzebDa3X2gbLCSnaYdBvlO4dJOL9b1qNIGVu qZZi6YJD71EPkSxgSQv3opURME8UUMoLfN4lnI/WK41HkwDb7uO1xgXagcOMzZwG7+RfqEua 8JxO4djK+VCCHWZdGHw62MMGIGBRPXvGKsT+Yn7bpTprk/sbNvH5/dFRvEvUs3qykWHYPRrg c5Rq8+3ZXqfqlIVOYWczhC/lUomM+URXFb+TDeM6sbRxUVk3TfP9m1+LLGprokP12ZqGLLSC 2i2hwY282AYjCK2rEbAZ8hOGh6aEAz73J54eOJHregfjmCRqVm/FCgNGW6f6IYYK+ZGa8Iph IS2aDEo8anMw750hvXpz11P+Zn9HumW9q7BEapFfRT+9K3fXSKja3C2r/+sB7HDR+6YV8fn4 tLaAg5adlCkCAriMkP6ReJI5aH6n4Noh95+jFollnkx4ig7iP6JCh9QHPkq6QTeyJSPHiOhd nC6s6C2h3GkWB45aU= X-IronPort-AV: E=Sophos;i="5.81,243,1610427600"; d="scan'208";a="39327003" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L63/USCGu03GhYYyBmrLiTeyyCi9fhBREVDdSSa91da0V7KK9XTw50UU3cAznR6jV5Gd60KjYbUdNKCGAf7Xng1QTmNAFnwXTqx9aaL+LAhE0VtgXBOe6YRkUrHgUSS4NlpH3BV3d8Rzp7cqAqj5tYSvq38HEuvJJ2fCYbDeUQc+TDj0NVUGdL99eeDqVuvT7NJGIEaloYknYzIwX3LWKML1HeQf52yHruWypNww0Sh3BtRHIwsbgndlQACMwzC/6H64z3m4fNnWdBg3dPgiBIEFD4jxXqXKhjekPONdD2lT7DZikYiFFx3UYPSDFgfx1zk/VmFfoHEmVsmSrvyLNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=id1/jmjuQ3je8H9gAGA8ub9JYFHGZHZSJXpkrhIrzFM=; b=IFrUGshd+OTx9pDptlF0qPtO0XfXuCTKfRytKzGz/urncSQ1cAvUlZXtbtzV6gw80eVGf+QAXV84dk5+doLGhlBm4cAZYK4Mas3lyEVbFZHHDX1GX0Dg21YUju9Rl0GPGj2wBqIIWU3oweewLj9Soau12Tq7pgex4XbQxloLu/u59W6vCa7C5hUudJLKex8iVABSOzIk+41R47XiecEPMGU2g91X/P9j5zx9sR6Zk7H2hqp10ImCS5DcadlqWfnGNRxXUIS7piLYdapkWU6yH3C4zTjIGjQK3eHInze//QlS6XuPRxhzPkFmCevsm02zM7DYvBfkJlWoP1/jXu5O1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=id1/jmjuQ3je8H9gAGA8ub9JYFHGZHZSJXpkrhIrzFM=; b=dQv/qmNBomXSGdUUqMecrbAt4zwAFCxDKGIshijSdyexwvLsxryqEipfN6GmeG4xFzD7Kx/cLLLhxxeANp5onB4ph9GhsVjaohOituA6XgoROTB6C4zD3aF+obw7QxS4b+8XPGJ/eO6K5frP3jE86ML8LCijxd/zJEznRtA1CwE= Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning To: Jan Beulich CC: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <1642726c-0134-fb90-164a-e49672f613ff@citrix.com> <81539e7d-6b3c-8261-6959-67ef1dc136bf@suse.com> <24c07e5f-4ca4-95cd-503d-2dd87579ee5c@suse.com> From: Andrew Cooper Message-ID: Date: Fri, 12 Mar 2021 13:20:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <24c07e5f-4ca4-95cd-503d-2dd87579ee5c@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0015.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::27) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d37b705-f673-4e96-7141-08d8e559ab58 X-MS-TrafficTypeDiagnostic: BN9PR03MB6187: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: owZvFfS+AC+VcLCalj/8Y/87/+9joQP83Bup4djwASX2qAPi/gzvYvlojYQCf41AWLiVinYGy9AjnMob2wl1pa7a7OBNWn6p9BGqHYcmxVPX25QgwHC3OpeESsY9xe6S1scps6HnF4QoxnDjV5yH5ZrfmNGiTJ6yfKEuAczZBnwK7d09MgeoIOvW1y5Z4mNQmUNsmuR54acD+//B3ZLd4FSJi55PLyhUsnz8ovAkZRKC7UWi6NHW0tg2GwhAssAmfM3tMuNS6D1fzWWyZzmpl13B5MPtUhSgQK5dMVXUU9uxXjrEtDBQKcOJC7d7LaP0p5WslR4kenAQ0bo2r/ZfZy8O0wXpxy7+V1uaygT3HxkkpQ2WupqfZiTU+cJ9JVXjWdkri5Y62KKnP/N6spa/Qib2Wu04sSUF5VVYVSkV1kTMH08sd5NMWgYrjMaBycyOE2CS5/d61xJSHSOe/8xxNcVSo1LVUQ5RagWM7JRx7w8rfdbEVesBgo/rshxgJ2r1WvmwakttEwjD1d3038NECcAr4+qMUaViU2sM417OmSU1OfM7ZLf+bN8uKD+U7fPLToPQ2+3u1Y0AQRfdZ0iQd23edY+ewa30xkvwk2CMCY0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(366004)(346002)(136003)(376002)(66476007)(6486002)(26005)(66556008)(66946007)(53546011)(36756003)(86362001)(956004)(16526019)(316002)(31696002)(54906003)(16576012)(5660300002)(4326008)(186003)(6916009)(8936002)(31686004)(2906002)(478600001)(8676002)(2616005)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dlpKMFFkYUVZeGo0ZTdyRmxZZHY0dXFsRzlSQkFxQmlGMm5vQ0lyTFQwMWU1?= =?utf-8?B?b2x3cFVoS3pRa0pqOGx0R1JFQ3RSSW1odXVod1ErVkhLNW8vY0dxeC81VGc4?= =?utf-8?B?QTkzYTlBTWxvbmY5dlNXMGQ0OGlWaUZxK2tnQ3dDY3VaTjVyNmVJK0dXdFVJ?= =?utf-8?B?ZDJ0YkRKRUFkNkxsT1YrWDVDTVowdE5BY1BUVmk2aE9nanZ3OXQ5T2tobW02?= =?utf-8?B?aU0zbjdYbWhTYkpDUXdKM0xvbEVVcmNGOHV2Vkxicm1Xd0QvT1Jvci9GUnRV?= =?utf-8?B?NDRTM0J1K0tTREtHa0xxQWU0TnpXcld4VXd3clpkUXF5MnBlaXMvSVVoUGRN?= =?utf-8?B?N3Rac1ROU1pBMUd1ZmhHakNzVk5va1ozZU5OQWNhVm1sVHpvUmlTa0UrN25R?= =?utf-8?B?WDJJVjRKV29RY1NyMTJEcUdKM0ErbGN5bDBvN2hFOEd5MkVEZEJjZTEyYU5O?= =?utf-8?B?UThzUFZQeHVQZkpXTUNVNkNYL1o0VlNDUDdreEJRTTYyOE4wTFpUQzVNRkda?= =?utf-8?B?WC85eU5YdHFkdm5xWHNJb1F4RW1vbm9ZRU5LazM3WUJZVFJWTHlVb2l0aHgy?= =?utf-8?B?UW5UNWw5STRYVEl6dURCQkZOMUdnbjF2TTNEcXg2czFlVWErSXNrZm1Oa3BO?= =?utf-8?B?Z3FCOEZUdUgwekRiZkllTEM4NGhqK1BON0VoWlhpNGl4M0orK1huMnZqb1Zp?= =?utf-8?B?OGhBWjZVSEx5dWcwWURic25sL0FUZVRIQjg4VUQxc1VyeEIxK2ttNnE3TGE3?= =?utf-8?B?L21KKzltUTdabWhlNzBWRkVraFlUNTQ3bzdnZzF1bWxtdCsxRHJUcGc2Q1J3?= =?utf-8?B?OE1velg3T0RhNnpIeXVqeUhWRVBKUzQ5ZFlFenk3NU5Kd2xWZk5RNG52VVpx?= =?utf-8?B?QjFOWWs1YkhxclkvUDhmZ3hrelovVU9tb0JaaEFyblFjT1hZSTl3bEpvMkEw?= =?utf-8?B?c0NpZVcwdk9kUi9MOUllRjJUZjhWbVJVM1Q2TDhnMnVpaGxpa1pMZForZUNV?= =?utf-8?B?QWdHeGhkdFBSM2hmUGxoendGY0lqcHMwV1BJbXFLZjR1elc3NmJUdVgvWHlq?= =?utf-8?B?UEpzQjhBcHBZdXZQWDlPUzhRN3FTaEhPbmNXN0UxL1IzREJiT2ZPMEtRSkRo?= =?utf-8?B?VHJiWkRORHlER3lzRXI4eUFiTzFmZXpzeFF1Zmh0NWZiQW5lY08yTGYrWHJw?= =?utf-8?B?VFJlUG5ueTVvMjN0R2FiNVBoS1RvRXVOTFN5RlZkS0d4ZjdiYkdET1RXMWJE?= =?utf-8?B?LzBtaTRGc3hTUWFQcjNJZW9BbXNSZXJJMm1DZE5RMEhRcDk1SUYxSlh1OXRp?= =?utf-8?B?Z3JkSG9WWmNtclZDbXE3a25UcWZYdnk3Q2hRSHptRndsTkxRSlM0OXFqdktn?= =?utf-8?B?RllxTVNXblhZUGxMT0NubDFaK21mQ2hDM0U1UHRxRmZhRm9tUm5idXBTTGlN?= =?utf-8?B?SnBrTyt2TnpoZDRuTVB0Ui9SLzFUN2RUUWJtd3U2NVVCZDN2d0ZwbTQwNWJS?= =?utf-8?B?NVVPSXJKQnFjZldZK0pvanFwMm14UGZPMEo0eDUxSG9leUJnaW1aVEFzdkd6?= =?utf-8?B?MFNxTXVNUTBvT1hnaUhqVi8xcCtqWmxST3NGc3N3ZEhoSm5JNGpVQ2NrSWFH?= =?utf-8?B?T3ZxbjVNbDk0bTNCNWwrVWQwZVFJdHI5bEpZT3BOWnJ2WG1nNDVJdHAyM1BD?= =?utf-8?B?TmVWa0ZzdW0wM2dDTzU3VGUyS2NQK3hJWk56UlVsb1pJak5McVhCR2NGZEVZ?= =?utf-8?Q?bh/YzJzAC5BjJvtA5GgXNligoFP2SmPhSiuotPB?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5d37b705-f673-4e96-7141-08d8e559ab58 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 13:20:56.4554 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z92gpcFw5G8Y4IWLOx208KKv75IrwpWreFq9LCIi7oGuVRfb4bSncKhWu5SZBpXMa5xk18kFpzNYbZbGnJfj1EE3kdNNCE9zqkNaWW6GMrM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6187 X-OriginatorOrg: citrix.com On 12/03/2021 13:18, Jan Beulich wrote: > On 12.03.2021 14:08, Jan Beulich wrote: >> On 12.03.2021 12:32, Andrew Cooper wrote: >>> --- a/xen/common/grant_table.c >>> +++ b/xen/common/grant_table.c >>> @@ -4059,6 +4059,16 @@ int gnttab_acquire_resource( >>>      if ( rc ) >>>          goto out; >>>   >>> +    /* >>> +     * Some older toolchains can't spot that vaddrs is non-NULL on >>> non-error >>> +     * paths.  Leave some runtime safety. >>> +     */ >>> +    if ( !vaddrs ) >>> +    { >>> +        ASSERT_UNREACHABLE(); >>> +        goto out; >>> +    } >>> + >>>      for ( i = 0; i < nr_frames; ++i ) >>>          mfn_list[i] = virt_to_mfn(vaddrs[frame + i]); >> Oh, I didn't realize this. Will add, but did you really mean to >> have the function return success in this case (on a release >> build)? I'd be inclined to put it ahead of if "if ( rc )" and >> set rc (to e.g. -ENODATA) in this case. > But I think the comment isn't really correct - the problem isn't > NULL or not, but uninitialized without setting it to NULL. How > about > > /* > * Some older toolchains can't spot that vaddrs won't remain uninitialized > * on non-error paths, and hence it needs setting to NULL at the top of the > * function. Leave some runtime safety. > */ > > ? Yes - that's fine. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 12 13:25:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 13:25:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97110.184280 (Exim 4.92) (envelope-from ) id 1lKhnO-0002A6-4c; Fri, 12 Mar 2021 13:25:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97110.184280; Fri, 12 Mar 2021 13:25:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKhnO-00029z-1M; Fri, 12 Mar 2021 13:25:38 +0000 Received: by outflank-mailman (input) for mailman id 97110; Fri, 12 Mar 2021 13:25:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKhnM-00029u-Nf for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 13:25:36 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d85cf464-ae16-4d58-81e6-465d03456dc0; Fri, 12 Mar 2021 13:25:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d85cf464-ae16-4d58-81e6-465d03456dc0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615555535; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=lydewPfH7Tzl8FhZHSk4hXXumUbUIRPZWmgAHU98C0U=; b=AjZ0fVnYO7O7DDSoPEnEwXPXSUvOApNR2ZdzzvO3SrtZRH9r94Ml9iRp bLIUDTJQ3GdomnJEwQohpO7arGx7IE4nY5PGQQnZjztVX+8RHfqxTMskW pEsZAUDrtN90ij9Ds+VE3Uf/UEORkEEEbTZAIUE33v/sO/K4fwSkTkDwh o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: hcYBs6402z7ru3IdTAu71+W97MMJBDsTliZ0ZRkr11agwfEb3mRhbuQHbxuZ7KgV93P447bcjV Gcr4eyHLKIr8St7krbmaGcgM6TRvwOu7Cx6ZjS29dNQUqPjl9AlGEX2rNSpDi7uVzsiGGEqlON 4RyKP4DP0qia+MqPIIoFzVVAGQcu+vjQ9z5+9le+c6KA5yCtiZbRuUjWrF2tKrdMV0TkGlctC+ iI0aCCD8kbx4tk0H89jYpxHx4VtTHBHzXc2Jkj/R1yH3hcqJpYPsQV7DMaP059hyUZtc5cbZ7J jwU= X-SBRS: 5.2 X-MesageID: 39161645 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:1VX9m6Pohb+tscBcT2zw55DYdL4zR+YMi2QD/3taDTRIb82VkN 2vlvwH1RnyzA0cQm0khMroAsa9aFvm39pQ7ZMKNbmvGDPntmyhMZ144eLZrwHIMxbVstRQ3a IIScVDIfXtEFl3itv76gGkE9AmhOKK6rysmP229RZQZCtBApsQiztRIACdD0FwWU1iDZ02CJ KT6qN81kWdUF4Qadm2AWRAYvPKoMfFmImjTRkNARMm7wfmt0LV1JfRFR+E0hACFw5e2LtKyx m5ryXVxIWG98u6xBjVynPJ4/1t9ufJ59NfCKW3+7AoAxr2jALAXvUGZ5Sju3QPrPir+BIWlr D30m0dFuBSz1+UQW2vuxvq3GDboUUTwlvv00WRj3emgeGRfkNCN+N7iYhUcgTU5iMb1bkWus I7vBPti7NtARzNhyj77dTTPisa8XacmnY+jfUVy0VWTIp2Us4gkaUk4EhXHJ0cdRiKirwPLe 8GNrC42N9ra1+AK1jWsm5zqebcJUgbL1OtR0gPvdGtyD5GnHx15Ftw/r1vol4wsL06UJVK/O LCL+BBk6xPVNYfaeZHCP4GWtbfMB2DfTv8dEapZXj3HqAOPHzA77bx/bUO/emvPLgF1oE7lp jtWE5R3FRCNX7GOImr5tlm4xrNSGKyUXDG0cdF/aV0vbX6Wf7CLTCDYEpGqbrin9wvRungH9 qjMpNfBPHuaUH0H5xS4gH4U55ObVEDTcwuvMohUV7mmLOKFqTa8sjgNNrDLrvkFjgpHknlBG EYYTT1LMJcqm+xXHvVhwXQRmPNdkTz8YkYKtmew8EjjKw2cqFcuAkcjlq0ouuRLydZj6AwdE xiZJPr+5nL4VWezCLt1SFEKxBdBkFa7PHLSHVRvzIHNEvybPIms9WbcmZC4WufKnZEPoTrOT 8ag24y1bO8LpSWyyxnIcmgKHimg3wao2/PaJsAhKuZ54PAdokjBpgrHIx9fD+7ViBdqEJPki NueQUETkjQGnfFkqO+lqEZA+nZap1bmwekIcldrFrFrkWCrcQTRn8WNgTeE/K/sEILfX55l1 dx+6gQjP6rgjC0M1Yyh+w+LRlxcmiNOalHCw6EfY1QvbjudGhLPCG3rA3fryt2Vnvh9k0UiG CkCSGPY/nEDmBQvW1i3r/w/El5cXiceExMeml32LcNZ1juizJW66umd6Cz22yeZh85zuYRPC rsTBESLgltrurHniK9qXKnLzEL158uNuvSAPAfaLnVwGqqM5DNv7oBBeVo8JFsM83OvucHXf mEQRKcKCr1BooSqlWoj0dgHBMxhGgvkPvu1hGg0XOx22QnB+HOZHthXLMWLrinniHZbsfN9K 88q907veG9aDqsLvGHzLzadD5FJFf4p3WsQ+QhtJBTuuYTudJIbu7meAqN8EsC+hM0aPrQvg c5Zo9Q5bjaII9hf8AIYUtijxEUveXKCHFuixD8B+81QEokgHDaNe6Y+ragk8taPmSx4C/LfW SF+yJT//35TzKO+L4TBaU3O3lXYiEHmQJf1dLHU43bEwOxce5fuHK8L3+mabdYIZL1VIk4n1 Jf49uSmfWQeDe98AfMvSFjKqYL12q8W8u9DEatHuFPmubKdWiks++P4MSpii3wRib+Q0MEhZ ddfUhVV/99sFAZ/cUK+xn3bLf2rEIjm0Zf5j8itmeF4PnZ3E7rWWdcMQPYhZ1KWyJ0KXbgt7 WczdSl X-IronPort-AV: E=Sophos;i="5.81,243,1610427600"; d="scan'208";a="39161645" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XVPnCPHSBZxlwk8WToU/xTtEarTKilbmgijvTUisz6l1+/WfwPYRdUaHH9RAuhrYIfg7/6upNzQKwYF3IozGD4g5nyBdeqB2oJCp0I5saNqaISBeEyk8bPLWu6JUM3LM29VCN4g+/9CAhGv6oAFeCAI9xHpCAMhhyIUDj/Sybp1xnpcmY+runSCYz0xkcfFOAvl1gtfQ6wfm02XXitOO6nMpy2mM3pFQXhJFlqzR8EAgoC/NHqFJtTys6sfRCQKoLKscJsBX7CfOLw/0wtRTMm+C1neMw1vw/Wo1lVWtEYZrI6zZIvXRS8XTgQTP7jGsPoOcmoe0oNBw2CyO+mXB7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uwt255OP6dwuelu+TJrjEQQibtbltatYNSr7c26diKE=; b=VlkFShxZBbR4lQ69trMtR8gvadEzY7i17jWuUGxdb1fAVWfVsBMZPL+yDm5IYxuEF+SnaMn1994LK7JVB6o3d2+2lVaRwFlQBgZAbBBTWwLdovju0ItEE55N/esTcGSk1AaSZ5GgTD7LxPizA0+BWtuxUMD3r3zoaWK857Zvagkca4pLZhmvziyORNEzjZaPz2eGyhuVwI1BMyZ4nGxhgeq/RKt6BveM3n04LGuq7jRoIXAUsYBNJ6m2vhDDbpEGYjjR1HX0gc4ThbLM9gYoWvBQZjgH3eyvsjxFAeTlbEJWf0r6mYqNnMuVDBVxYAlFVgCfZlic80cK2Em8k/S9+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uwt255OP6dwuelu+TJrjEQQibtbltatYNSr7c26diKE=; b=Cz607iMRaD0ciHcuNCbXkTKEQSI7gjocDdpUUqwqlKUl8WnjT8wzUXCNekLHJ3dyVswg13EuN/e2usQqdr4AQxIjbC0P9WgpUy+thzL/Z6yZpf7Vx2iwj2CedQzADN5rwsDR1x9gRodatsCT7MGLQFVLFKfcEC2PMItmaFrkW4w= Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning To: Jan Beulich CC: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <1642726c-0134-fb90-164a-e49672f613ff@citrix.com> <81539e7d-6b3c-8261-6959-67ef1dc136bf@suse.com> From: Andrew Cooper Message-ID: <4722bb38-387a-7bd2-12fc-87dcbde48d4f@citrix.com> Date: Fri, 12 Mar 2021 13:25:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <81539e7d-6b3c-8261-6959-67ef1dc136bf@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0445.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::25) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6233838a-c069-406f-78a7-08d8e55a4ae8 X-MS-TrafficTypeDiagnostic: BN8PR03MB5121: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hsg5n7Scfqk0+K/W9QhsBZZKbzN9HinYBB+Mnk9LtBQbiEIf3OHHaCAlJwK1ABv3AEBfnUWP4zZrOxiWejLDrQl0u8W0zDAJlr+ihRVUjipcYOQ82+DDCwgfKUxPrjYYa11Tsn2AtlvGexUedxT6vNXh5Zjaez8ikd/GYpBLexT/BycDKwcrPJ239sUJbuEwsg4J9uipf0Znx4+HO5rCMQ9tWXcIGkhPb040m3/doQT5SOYHP8e4zJib51fTeXiZnHX/3ILrSBaFQbVp6CZCvGqWWMLAHIX2iXVEXoCGMUtrKLMyek5XpOoTSkamgl8P3grtjsCfBP13NXp5yKdgOrcN3mPDzwGaxITnUKg3ivgttP35YbTgOSFlnnlO3F5fxxwKaM+2vTmh5xO/N2rRsQcU/k54sk9tygBX6E27c5ZpZD4A6J7kyANeK6N4c98uZEjWbXs00xGmzBpNab02eZCkeUHZ/Uo2BD6Ii/ep2LVmM7MvR0jgu4OPq88edx8Y+SB6Sz8OGIx3JX0hhZKxzuJYlKr9mIyMvjA4pVJ2xRGKpQjf88cLZKK/1GBNnGBZjGLCAY49YbzCKh1e66WTdnPy0JjFMIXzJfGVnkels58= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(39860400002)(136003)(346002)(396003)(478600001)(5660300002)(16576012)(4326008)(8676002)(86362001)(316002)(31686004)(36756003)(53546011)(54906003)(956004)(2616005)(2906002)(6916009)(31696002)(8936002)(16526019)(186003)(66946007)(26005)(66476007)(6486002)(66556008)(6666004)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?OEEzWmsvYjhyN1lmTGdDQndLUWROTU5maFZwNUtObHQyK2p6ZDVNdjJMVjRj?= =?utf-8?B?Vy9ocEZLODBTejBzam5xQkFXQWxmL2hDWkxlcWNyLzh1V3A3WlJSMTIyQ2tz?= =?utf-8?B?MVZvNkFnT2Y1cDJvMHBQS3F5NVZ1ZjVibmJESG9tKzBkcUNjMC9vTSs3Y1pC?= =?utf-8?B?UVVNRHk4cHJvQUtCU0xNOFBScW5SdHRSbXBqVkxCci9sazJjZmFHSndiano0?= =?utf-8?B?dVQzUWowaFBWbmZhOVppazgvRlcrYW5QbXdCQXY2dFN2cHVRdVFWKzZuWmZt?= =?utf-8?B?djB0aVVXR2lRanB6SFlEdmZOc0w5WmFTQTJ6dTRDK3ovRUhuQkQ3QVA1eUxW?= =?utf-8?B?MWRpWDFSM1BzTU5PakJnZGNiOS9hS0lRR09TQmQxcGZUN3BYbDkvbzFoSTZS?= =?utf-8?B?WUlHQnNkOGQrV3pETUdLaE9oOUpVLzcrNHlBT1Z1cEhiRmN4NUlrSzN6RXBZ?= =?utf-8?B?b1JsVmxxYjI4L1lITW5nVytlclA3YXQxMDYyMExyWTdwdVA5TEhUUFFSZzEx?= =?utf-8?B?ekRPYnkxcUpUQnhqMlMwNWt6dnE4Z2hyMVZPaTRnLzRMV3dQMDdMVlZzMWly?= =?utf-8?B?NnAwbUdhZWkyNW1PdnNCZzRTcnViZm91SFpKb3R1OW45VzRUeVhnc0V3V0xv?= =?utf-8?B?eWlranlBbDhGSmFmc2paY2lYTUVNUmdOZUx5ZUxjeHRlQThuK1E1ZFJ6dWFt?= =?utf-8?B?K1hUbnh0L2Z5czRkMTBsbklKbmJaK21zeDFOQ244WDRsSlRhMXYrS3didzlT?= =?utf-8?B?YnNGZUdwRUkrYnM2ZUs4ZWxEMGRrYi9Cc0w1YzJUUDVBV0RwOS80WXBFODE4?= =?utf-8?B?MEhpZXhGb0d0U1NrUjNKVHYyTlFhWkZlSWRPc2QvQTNlNWNDMkhVWUZMQVlx?= =?utf-8?B?S254VHNuM2VON1VEc0V2TjE4T0FDU0ZCYkVLSDJzcXZVV04xK3JJQW5ZSlBZ?= =?utf-8?B?R2NUekpKNCtKdHhBWFB0MGlGNTA4dzRreG9pbE9kZzhiSm9iRDJ3Q0tvMjZy?= =?utf-8?B?SXB1NGhkTFRBblZnTVVxOW54SmsrMFhiRXFQU3M2UEF6OXh3M2tmNS8rb3Fy?= =?utf-8?B?M3RYME1qWGZGSXRhVGl5VEw1aXlIQTUzRTBtWVgzeDlkMUg0K0tzL1NxK3Rh?= =?utf-8?B?VEMzMUV1TTBpUjdMTmFtRXB2T1RaNnBnZWdDQzlEemFDTmJXK1ZCTWRBVGp2?= =?utf-8?B?NUZMSkpUODU3c25uUGZXR3BWUFZQRjk0dTE1UDBId0RLL2REa2tncnRMR1l4?= =?utf-8?B?NC94OGY5Nno1MVh3ci85Q01HSTUyVHVPTlVjRUJyelZ4WjJyQ3AzdmdnUzMx?= =?utf-8?B?cU42aGZwNGlBZXlDVjhjcGlHak4vRDdldWFSdjI3TjNwdHJDQ0JVTG1IYjVT?= =?utf-8?B?UkNjQ042OGt5Z3ZReEJNNDI1Y01ad045K2p2cmJTKzFEdjlPUnNBOUVtdEpa?= =?utf-8?B?S3Z3WUJNemlKaWdVMjdTS1lNSUtuMDBhL3puTURYeTNqR1FHanBhQ1cyRGo5?= =?utf-8?B?eDltUFh2akpaNExMcUUyaHZaNktoR0RZS0pmYkVGTWxYOXhySEJnNTFZaWdp?= =?utf-8?B?aUdMYjlIb2JLNVJQckVwWWlKWEx1RHhpSnA5cXZKdHJGVG51VEg4dERrQXFF?= =?utf-8?B?ZlJkcjlhaVVFa3R6RjVQVVBub0NlOHB0RTRkRTZDcUQ0bnNuWnBrVzVieU1C?= =?utf-8?B?Rlo0ZzBhbXpNQ2UrbmtzYzVJK3ZvUTVkN2RTM2VqU2VFY28yQzgvdFlOZzRi?= =?utf-8?Q?5VeQioFlMYvj6Sc+a9UPa4RRMeOeA59VJPFnhJB?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6233838a-c069-406f-78a7-08d8e55a4ae8 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 13:25:24.0781 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sM2516WTByocLiq8NCTPf/suNXGxJv8vL7EPayzaIXWZfWGkhec0AaOYDlBKCj81mV7lPZm7xx0WLYV3yaWaNCsNqYEkQ+KV76mimhp5Y0o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5121 X-OriginatorOrg: citrix.com On 12/03/2021 13:08, Jan Beulich wrote: > On 12.03.2021 12:32, Andrew Cooper wrote: >> On 10/03/2021 10:13, Jan Beulich wrote: >>> Sadly I was wrong to suggest dropping vaddrs' initializer during review >>> of v2 of the patch introducing this code. gcc 4.3 can't cope. >>> >>> Fixes: 52531c734ea1 ("xen/gnttab: Rework resource acquisition") >>> Signed-off-by: Jan Beulich >>> >>> --- a/xen/common/grant_table.c >>> +++ b/xen/common/grant_table.c >>> @@ -4026,7 +4026,7 @@ int gnttab_acquire_resource( >>> struct grant_table *gt = d->grant_table; >>> unsigned int i, final_frame; >>> mfn_t tmp; >>> - void **vaddrs; >>> + void **vaddrs = NULL; >>> int rc = -EINVAL; >>> >>> if ( !nr_frames ) >> in v1, there was a companion check. >> >> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c >> index f937c1d350..2bb07f129f 100644 >> --- a/xen/common/grant_table.c >> +++ b/xen/common/grant_table.c >> @@ -4059,6 +4059,16 @@ int gnttab_acquire_resource( >>      if ( rc ) >>          goto out; >>   >> +    /* >> +     * Some older toolchains can't spot that vaddrs is non-NULL on >> non-error >> +     * paths.  Leave some runtime safety. >> +     */ >> +    if ( !vaddrs ) >> +    { >> +        ASSERT_UNREACHABLE(); >> +        goto out; >> +    } >> + >>      for ( i = 0; i < nr_frames; ++i ) >>          mfn_list[i] = virt_to_mfn(vaddrs[frame + i]); > Oh, I didn't realize this. Will add, but did you really mean to > have the function return success in this case (on a release > build)? I'd be inclined to put it ahead of if "if ( rc )" and > set rc (to e.g. -ENODATA) in this case. Oh - quite right.  Returning 0 here will hit the assertion/failsafe protecting against livelock. I'd be tempted to chose -EINVAL because the only plausible way to get here is a bad id, and that path should have errored out earlier. And yeah, with the rc adjustment, fine to reposition. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 12 13:28:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 13:28:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97115.184295 (Exim 4.92) (envelope-from ) id 1lKhpv-0002UR-LG; Fri, 12 Mar 2021 13:28:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97115.184295; Fri, 12 Mar 2021 13:28:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKhpv-0002UK-I9; Fri, 12 Mar 2021 13:28:15 +0000 Received: by outflank-mailman (input) for mailman id 97115; Fri, 12 Mar 2021 13:28:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKhpu-0002UF-Dn for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 13:28:14 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6a1ae1bb-2291-437d-8b45-ec1334cf1d9b; Fri, 12 Mar 2021 13:28:13 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D962AAF4D; Fri, 12 Mar 2021 13:28:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a1ae1bb-2291-437d-8b45-ec1334cf1d9b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615555693; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SB6cjRcfANDSZoA5AjSpD/ZyaGqTkyrX+8xNZEZp/CM=; b=dzGZOfmSWx55h8P8MVGUKvweRhEXiqvHPGlHGKhMJg2894UaU1kESPpsbXSGurTILUJc8K eaFV3xpKnlPZZydrb5jT515fcXyWvyJPwrUWLbn8ohfmu3u7Jxqf4IJsYj6o6jXECO9maH DwGpk0QBKoJI9zaZoAqML4wNMziW/oY= From: Jan Beulich Subject: [PATCH v2][4.15] gnttab: work around "may be used uninitialized" warning To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu Message-ID: <099e79c0-6443-2199-1242-3cfc4d93c367@suse.com> Date: Fri, 12 Mar 2021 14:28:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sadly I was wrong to suggest dropping vaddrs' initializer during review of v2 of the patch introducing this code. gcc 4.3 can't cope. Fixes: 52531c734ea1 ("xen/gnttab: Rework resource acquisition") Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- v2: Re-insert the other half of what Andrew had in his original patch. --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -4026,7 +4026,7 @@ int gnttab_acquire_resource( struct grant_table *gt = d->grant_table; unsigned int i, final_frame; mfn_t tmp; - void **vaddrs; + void **vaddrs = NULL; int rc = -EINVAL; if ( !nr_frames ) @@ -4055,6 +4055,17 @@ int gnttab_acquire_resource( break; } + /* + * Some older toolchains can't spot that vaddrs won't remain uninitialized + * on non-error paths, and hence it needs setting to NULL at the top of the + * function. Leave some runtime safety. + */ + if ( !vaddrs ) + { + ASSERT_UNREACHABLE(); + rc = -ENODATA; + } + /* Any errors? Bad id, or from growing the table? */ if ( rc ) goto out; From xen-devel-bounces@lists.xenproject.org Fri Mar 12 13:29:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 13:29:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97118.184306 (Exim 4.92) (envelope-from ) id 1lKhrC-0002az-08; Fri, 12 Mar 2021 13:29:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97118.184306; Fri, 12 Mar 2021 13:29:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKhrB-0002as-TG; Fri, 12 Mar 2021 13:29:33 +0000 Received: by outflank-mailman (input) for mailman id 97118; Fri, 12 Mar 2021 13:29:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKhrA-0002am-1p for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 13:29:32 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d3a5cac1-cb91-4ea6-8ac6-13c8bdad341a; Fri, 12 Mar 2021 13:29:31 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 85E40B122; Fri, 12 Mar 2021 13:29:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3a5cac1-cb91-4ea6-8ac6-13c8bdad341a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615555770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FhoGIIjSO95RAjgWgleCpOhVsyBc0CR/e2p0QtDKmPA=; b=JPiNq8XW5PVgeKOMVWL5+eYOklBUw9Y2kcgjldC5oNlfrTOTftqEZDk4CZx3z2GkMLGdN4 Ja5r80Mxpx5dROpstGm+VJ8B1TVF7dXh3u6TUQLSdqiDxTcgCB5JJaJ5KrPrhsGu70vJAW 98x8U0/fhjUrquGJud6cEeu5LSWR0qo= Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning To: Andrew Cooper Cc: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <1642726c-0134-fb90-164a-e49672f613ff@citrix.com> <81539e7d-6b3c-8261-6959-67ef1dc136bf@suse.com> <4722bb38-387a-7bd2-12fc-87dcbde48d4f@citrix.com> From: Jan Beulich Message-ID: <1167c6a5-4d76-8803-99a5-33121aa82b3a@suse.com> Date: Fri, 12 Mar 2021 14:29:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <4722bb38-387a-7bd2-12fc-87dcbde48d4f@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 12.03.2021 14:25, Andrew Cooper wrote: > On 12/03/2021 13:08, Jan Beulich wrote: >> On 12.03.2021 12:32, Andrew Cooper wrote: >>> On 10/03/2021 10:13, Jan Beulich wrote: >>>> Sadly I was wrong to suggest dropping vaddrs' initializer during review >>>> of v2 of the patch introducing this code. gcc 4.3 can't cope. >>>> >>>> Fixes: 52531c734ea1 ("xen/gnttab: Rework resource acquisition") >>>> Signed-off-by: Jan Beulich >>>> >>>> --- a/xen/common/grant_table.c >>>> +++ b/xen/common/grant_table.c >>>> @@ -4026,7 +4026,7 @@ int gnttab_acquire_resource( >>>> struct grant_table *gt = d->grant_table; >>>> unsigned int i, final_frame; >>>> mfn_t tmp; >>>> - void **vaddrs; >>>> + void **vaddrs = NULL; >>>> int rc = -EINVAL; >>>> >>>> if ( !nr_frames ) >>> in v1, there was a companion check. >>> >>> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c >>> index f937c1d350..2bb07f129f 100644 >>> --- a/xen/common/grant_table.c >>> +++ b/xen/common/grant_table.c >>> @@ -4059,6 +4059,16 @@ int gnttab_acquire_resource( >>>      if ( rc ) >>>          goto out; >>>   >>> +    /* >>> +     * Some older toolchains can't spot that vaddrs is non-NULL on >>> non-error >>> +     * paths.  Leave some runtime safety. >>> +     */ >>> +    if ( !vaddrs ) >>> +    { >>> +        ASSERT_UNREACHABLE(); >>> +        goto out; >>> +    } >>> + >>>      for ( i = 0; i < nr_frames; ++i ) >>>          mfn_list[i] = virt_to_mfn(vaddrs[frame + i]); >> Oh, I didn't realize this. Will add, but did you really mean to >> have the function return success in this case (on a release >> build)? I'd be inclined to put it ahead of if "if ( rc )" and >> set rc (to e.g. -ENODATA) in this case. > > Oh - quite right.  Returning 0 here will hit the assertion/failsafe > protecting against livelock. > > I'd be tempted to chose -EINVAL because the only plausible way to get > here is a bad id, and that path should have errored out earlier. As you may have seen, I've chosen to stick to ENODATA. This error, should it ever get raised, would better be easily distinguishable from an ordinary -EINVAL. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 13:34:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 13:34:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97125.184325 (Exim 4.92) (envelope-from ) id 1lKhwM-0003V1-Qy; Fri, 12 Mar 2021 13:34:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97125.184325; Fri, 12 Mar 2021 13:34:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKhwM-0003Uu-Ny; Fri, 12 Mar 2021 13:34:54 +0000 Received: by outflank-mailman (input) for mailman id 97125; Fri, 12 Mar 2021 13:34:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKhwM-0003Up-BN for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 13:34:54 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 61a7c494-ef73-4297-9d95-5fadc8e905bb; Fri, 12 Mar 2021 13:34:52 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1DC5EB034; Fri, 12 Mar 2021 13:34:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61a7c494-ef73-4297-9d95-5fadc8e905bb X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615556092; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fsOOmVOBABtxanD9QlgqtucNM8425swHUVRB7f2ll4M=; b=Lw1TyaZNuh3VPuznwgAbCQVpxgnkMfd5H2eKAk4yxQztjLRjdnCEdoTG8lijkSjLQn/VPa K3cNziUl63LTlfNK+CO3Vkc7F/ODV/Xp9veWrEMmcbFjif69wpBNKfGGXIbMBgAAWQfH8E MctENzAm5GGt7cVxK04zrF2U5kg7SFM= Subject: Re: [PATCH v3 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson , "xen-devel@lists.xenproject.org" References: <7a84bc56-0045-2111-6888-8db830335ad1@suse.com> <90f87aa8-09da-1453-bd82-c722465c2881@suse.com> <7504b027-f106-33e1-214a-eecf8ea5ff5d@citrix.com> From: Jan Beulich Message-ID: Date: Fri, 12 Mar 2021 14:34:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <7504b027-f106-33e1-214a-eecf8ea5ff5d@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 12.03.2021 12:19, Andrew Cooper wrote: > On 12/03/2021 07:54, Jan Beulich wrote: >> Prior to 4.15 Linux, when running in PV mode, did not install a #GP >> handler early enough to cover for example the rdmsrl_safe() of >> MSR_K8_TSEG_ADDR in bsp_init_amd() (not to speak of the unguarded read >> of MSR_K7_HWCR later in the same function). The respective change >> (42b3a4cb5609 "x86/xen: Support early interrupts in xen pv guests") was >> backported to 4.14, but no further - presumably since it wasn't really >> easy because of other dependencies. >> >> Therefore, to prevent our change in the handling of guest MSR accesses >> to render PV Linux 4.13 and older unusable on at least AMD systems, make >> the raising of #GP on this paths conditional upon the guest having >> installed a handler, provided of course the MSR can be read in the first >> place (we would have raised #GP in that case even before). Producing >> zero for reads isn't necessarily correct and may trip code trying to >> detect presence of MSRs early, but since such detection logic won't work >> without a #GP handler anyway, this ought to be a fair workaround. >> >> Signed-off-by: Jan Beulich >> Release-Acked-by: Ian Jackson > > I am still of the firm belief that this is the wrong course of action. > > It is deliberately papering over error handling bugs which, in the > NetBSD case, literally created memory corruption scenarios.  (Yes - that > was a WRMSR not RDMSR, but the general point still stands, particularly > in light of your expectation to do the same to the WRMSR). > > It is one thing to not realise that we have a trainwreck here.  Its > totally another to take wilful action to keep current and all future > guests broken in the same way. > > The *only* case where it is acceptable to skip error handling is if the > VM admin has specifically signed their life away to say that they'll > accept the, now discovered, potential-memory-corrupion consequences. > > Rogers patch already does this. With _much_ bigger impact - it requires changing the behavior for the entire lifetime of the domain, rather than just very early boot. And as you may have seen, despite my fear that it may not be enough, Roger and I have agreed to leave the WRMSR path alone. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 13:59:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 13:59:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97137.184349 (Exim 4.92) (envelope-from ) id 1lKiKK-0005qK-3t; Fri, 12 Mar 2021 13:59:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97137.184349; Fri, 12 Mar 2021 13:59:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKiKK-0005qD-0p; Fri, 12 Mar 2021 13:59:40 +0000 Received: by outflank-mailman (input) for mailman id 97137; Fri, 12 Mar 2021 13:59:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKiKI-0005q8-SM for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 13:59:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKiKI-0000jd-Pe for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 13:59:38 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lKiKI-0008Iq-Jt for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 13:59:38 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lKiKD-000424-UA; Fri, 12 Mar 2021 13:59:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=1SgGOQ/W1OX3cIf6c9ejXss53ACGDutvhvid4ZSnvxk=; b=gmUswn/ssK+T9cMUX+87hofX9g miLRdf4SMHUMsUGb05ISwL6BqlEumv/h1qudwGjQMywkCj2BOWJmmKpjXPxKlCmjjt6Vzl7NdJTJJ lElUkEJwCotRBaz1/W5EOELBlT4s4MrXK5/Q1lGpZMhT6X5rdsanh9xntV7vByV3f1HA=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24651.29637.673344.425436@mariner.uk.xensource.com> Date: Fri, 12 Mar 2021 13:59:33 +0000 To: Andrew Cooper , Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , committers@xenproject.org Subject: Re: [PATCH v4 0/2][4.15] x86: guest MSR access handling tweaks [and 1 more messages] In-Reply-To: <9c2e5e0e-041f-03e3-3c08-7abcc82d63c7@suse.com>, <7504b027-f106-33e1-214a-eecf8ea5ff5d@citrix.com> References: <7a84bc56-0045-2111-6888-8db830335ad1@suse.com> <90f87aa8-09da-1453-bd82-c722465c2881@suse.com> <7504b027-f106-33e1-214a-eecf8ea5ff5d@citrix.com> <9c2e5e0e-041f-03e3-3c08-7abcc82d63c7@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH v4 0/2][4.15] x86: guest MSR access handling tweaks"): > Largely to re-base patch 1. > > 1: PV: conditionally avoid raising #GP for early guest MSR reads > 2: AMD: expose HWCR.TscFreqSel to guests Jan, thanks for the v4. Roger, thanks for your reviews and for your mail to committers@ (on Wednesday). Andrew Cooper writes ("Re: [PATCH v3 1/2][4.15] x86/PV: conditionally avoid raising #GP for early guest MSR reads"): > I am still of the firm belief that this is the wrong course of action. Andrew, thanks for your clearly stated opinion. It seems to me that, even having taken Andrew's strong objection into account, Jan and Roger and I all still think this patch is the right thing to do. With my release manager hat on I would prefer not to spend any more time debating this; and, the discussions do not seem to be producing any new information. I spoke to Jan on IRC and he confirmed that these patches are finished on a detailed technical level - that is, there is no reason not to commit these patches, except for the above objection to the whole principle. I therefore intend to commit both these two patches (v4) late this afternoon, say 5pm UK time. If anyone thinks that this would be improper, or has a new reason I shouldn't go ahead, please let me know ASAP. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 12 14:03:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 14:03:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97140.184361 (Exim 4.92) (envelope-from ) id 1lKiNz-0006nI-Kf; Fri, 12 Mar 2021 14:03:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97140.184361; Fri, 12 Mar 2021 14:03:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKiNz-0006nB-Hh; Fri, 12 Mar 2021 14:03:27 +0000 Received: by outflank-mailman (input) for mailman id 97140; Fri, 12 Mar 2021 14:03:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKiNx-0006n6-P4 for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 14:03:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKiNx-0000uT-Nt for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 14:03:25 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lKiNx-0000Dc-N1 for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 14:03:25 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lKiNu-00043K-Fi; Fri, 12 Mar 2021 14:03:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=2zhvpBnhL1HJMl89jtyuK2Jr2cs+XEO0bTq/GRFPND8=; b=d6rwFYWeTX9GAsTSnceLWJ/IYN QVmk7BGoBXyws2VJaklZ0dO4Pi9o6Nv1EBVakqNWxjIbMx6OMSSk2H2zyvtvJsjSsyNbtGtzGlte/ 6s0HtPxnL+7jZX1aRmDSilC+icHMMupjrPPR8vZV4HOmwxgKYoyh29sR/5jIiAXcUn1E=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24651.29866.263648.422601@mariner.uk.xensource.com> Date: Fri, 12 Mar 2021 14:03:22 +0000 To: Dario Faggioli Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH] xen: fix for_each_cpu when NR_CPUS=1 In-Reply-To: <161545564302.24868.14477928469038686899.stgit@Wayrath> References: <161545564302.24868.14477928469038686899.stgit@Wayrath> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Dario Faggioli writes ("[PATCH] xen: fix for_each_cpu when NR_CPUS=1"): > When running an hypervisor build with NR_CPUS=1 for_each_cpu does not > take into account whether the bit of the CPU is set or not in the > provided mask. > > This means that whatever we have in the bodies of these loops is always > done once, even if the mask was empty and it should never be done. This > is clearly a bug and was in fact causing an assert to trigger in credit2 > code. > > Removing the special casing of NR_CPUS == 1 makes things work again. Release-Acked-by: Ian Jackson > I'm not really sure whether this should be 4.15 material. > > It's definitely a bug, IMO. The risk is also pretty low, considering > that no one should really run Xen in this configuration (NR_CPUS=1, I > mean). Which is also the reason why it's probably not really important > that we fix it at this point of the release cycle. Given that it clearly only affects NR_CPUS==1, I think the risk/reward tradeoff is unambiguously positive. > -#if NR_CPUS > 1 > #define for_each_cpu(cpu, mask) \ > for ((cpu) = cpumask_first(mask); \ Just a thought: does cpumask_first work on an empty mask ? Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 12 14:08:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 14:08:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97145.184373 (Exim 4.92) (envelope-from ) id 1lKiTD-0007Br-7O; Fri, 12 Mar 2021 14:08:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97145.184373; Fri, 12 Mar 2021 14:08:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKiTD-0007Bk-4F; Fri, 12 Mar 2021 14:08:51 +0000 Received: by outflank-mailman (input) for mailman id 97145; Fri, 12 Mar 2021 14:08:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKiTB-0007Bd-9G for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 14:08:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKiTB-0000zy-5A for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 14:08:49 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lKiTB-0000bd-3G for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 14:08:49 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lKiT0-00044q-EE; Fri, 12 Mar 2021 14:08:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=m5H7FgXfFnbYQQT7H+HBh4eIcgFfUsHEIhLz/wbXR+w=; b=Avdr/bYw6HrGphUaJ+k1aKB5/9 BgehS6zytBjBNuI7ioep+QBW0fNBkyXi5AdluLb5YlxLkIDyFphPw2Dx/GvPybB2QnQ1qZ6V5CpuO InbBF6P7W2NhpBCj/ydr49nCDDH0gUp7FBwHqoxwdk8lpOj7bNHEETiC55KtCH4iH1wo=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24651.30182.179324.184928@mariner.uk.xensource.com> Date: Fri, 12 Mar 2021 14:08:38 +0000 To: Andrew Cooper Cc: Roger Pau =?iso-8859-1?Q?Monn=E9?= , Jan Beulich , Paul Durrant , Wei Liu , Ian Jackson , Xen-devel , Juergen Gross Subject: Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API In-Reply-To: References: <20210310150722.27194-1-andrew.cooper3@citrix.com> <13f03a67-18c2-e564-a0f6-84eccc7eeb76@citrix.com> <556ce32b-5087-b8b1-432e-643218dd8c6e@suse.com> <9ca069ab-8b6c-c8f1-d68b-4a9bb0cf5c56@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API"): > On 11/03/2021 14:18, Roger Pau Monn wrote: > > I think using __XEN_UNSTABLE_ABI__ would be way clearer than > > __XEN_TOOLS__, or even placing those in a separate directory as you > > mention. +1 > I plan to submit a rename for 4.16. +1 > I don't expect I'll have much luck arguing for a release ack at this > point, and isn't totally risk-free. Indeed, I think the value for 4.15 would be very limited and I wouldn't want the churn. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 12 14:14:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 14:14:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97148.184388 (Exim 4.92) (envelope-from ) id 1lKiYZ-00085f-Tn; Fri, 12 Mar 2021 14:14:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97148.184388; Fri, 12 Mar 2021 14:14:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKiYZ-00085Y-Qg; Fri, 12 Mar 2021 14:14:23 +0000 Received: by outflank-mailman (input) for mailman id 97148; Fri, 12 Mar 2021 14:14:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKiYY-00085T-PE for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 14:14:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKiYY-00015e-KB for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 14:14:22 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lKiYY-00013h-Fb for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 14:14:22 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lKiYV-00046q-8v; Fri, 12 Mar 2021 14:14:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=612xe5D1gQNvP67L9NWPxnl64xExgmv8QNuIAJBrNxA=; b=3hY92iGAcEMH6UYuKhRubJJrHP SE2/38geWjr3GDNp3K9DJt+dqTh/6oCxNO9F6K14Is7mZuqh5fTZdtJZw+IzIArocIrP3KGyYrO4U BU91yGmZ+4IAXxjrykLcwJlA/9MJJ28f65p75iEfTaZqSo7QTTsfKp4QoULIoav3FkG4=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24651.30523.7483.695534@mariner.uk.xensource.com> Date: Fri, 12 Mar 2021 14:14:19 +0000 To: Igor Druzhinin Cc: , , , , , Subject: Re: [PATCH for-4.15] vtd: make sure QI/IR are disabled before initialisation Newsgroups: chiark.mail.xen.devel In-Reply-To: <2937df62c72f48cf81af9e12b33e13c6@FTLPEX02CAS03.citrite.net> References: <2937df62c72f48cf81af9e12b33e13c6@FTLPEX02CAS03.citrite.net> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Igor Druzhinin writes ("[PATCH for-4.15] vtd: make sure QI/IR are disabled before initialisation"): > BIOS might pass control to Xen leaving QI and/or IR in enabled and/or > partially configured state. In case of x2APIC code path where EIM is > enabled early in boot - those are correctly disabled by Xen before any > attempt to configure. But for xAPIC that step is missing which was > proven to cause QI initialization failures on some ICX based platforms > where QI is left pre-enabled and partially configured by BIOS. > > Unify the behaviour between x2APIC and xAPIC code paths keeping that in > line with what Linux does. Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Fri Mar 12 14:32:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 14:32:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97157.184409 (Exim 4.92) (envelope-from ) id 1lKiq2-0001oe-Mw; Fri, 12 Mar 2021 14:32:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97157.184409; Fri, 12 Mar 2021 14:32:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKiq2-0001oX-Jp; Fri, 12 Mar 2021 14:32:26 +0000 Received: by outflank-mailman (input) for mailman id 97157; Fri, 12 Mar 2021 14:32:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKiq0-0001oS-If for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 14:32:24 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d4b95671-79bb-4c92-ab0e-2292266d6767; Fri, 12 Mar 2021 14:32:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4b95671-79bb-4c92-ab0e-2292266d6767 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615559541; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=F9zmieDEj7O7bFb35FrXJgCrlhxvLbHXtkvrl5oXUds=; b=iC6L1hl8y0hQsTbX47mYask4986tGhXq7oYZBMlaU5WfdZoF4v8aWgpX pc/LnbLaLGaA0Z3meSyp5QyNFF9b8r4bKNOOWvpAjbR0YNauHS+aZBMBh OHqMw+NiWI1MpSZiwbq08nFDyei1CZLhRk+xUc/pNkt0eDjeAfcvpQ14W A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ELN8MqbEK2/pEDkBHR5xbscg+hjKyRSicJj7VxwSIV39R/2a4aeA/tyw2aDA8uioljz1Q5A3c4 RFqXMHgo6wizQpsKts4wcr7/6Aa464jRdsn3GjbXWbmLdBUZC4FJoxZeiIw/e9wwbPZ1vg1W4i 0fbksljtl784CinoLVEZ1vzzqn/g7pAHm9JAy3arhDKQ+Dpv3VUVjSv6b2VwdhJpAdBiS0WXEV b40KcIju/dRoHuaGYzopifGMiItCDzyA2nP1xdBiF5Tbjp5GKORTdXw5NVKOYzvBbweqC3CvR/ uew= X-SBRS: 5.2 X-MesageID: 39519006 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:m+L1QaNFEH4UhsBcT7rx55DYdL4zR+YMi2QD/3taDTRIb82VkN 2vlvwH1RnyzA0cQm0khMroAsa9aFvm39pQ7ZMKNbmvGDPntmyhMZ144eLZrwHIMxbVstRQ3a IIScVDIfX7B1RikILe6A63D94vzLC8gd2VrM31pk0dKD1CQadm8gt/F0K6PyRNNUd7LLA+E4 eR4dcCgjKmd2geYMjTPAh4Y8HoodrXmJX6JSMcDxk85wWUyR+u4rj2Ex+Xty1uEg9n67Ek7G TDjkjF9ryu2svLhSP0+k3yy9BtmNXnwsZeH8DksKYoAxjllwrAXvUZZ5SspzYwydvfi2oCsN 6JmBs4OtQ21nW5RBDOnTLI+y3NlAkj8GXjz1jwuwqineXcSCghA8RMwaJ1GyGpk3YIh9133K JV02/xjfM+Znmg/BjV3NTGWwpnkUC5uxMZ4JUupkdSTJcEb/tppZEflXklSqsoJj7w64wsDY BVfaXhzctWal+TYjT4uWRi0bWXLxIONyqGWUQLt4ip1SFXlhlCviwl7fEY901wlq4Vet1h3a DpI65onLZBQos9dqRmHtoMRsOxFyjkXQ/MGHj6GyWlKIg3f1b277Ln6rQ84++nPLYSyoEppZ jHWFRE8UYvZkPVD9GU1pEjyGGOfEyNGRDWju1O7ZlwvbPxAJDxNzeYdVwom8y859ISH9PcQP T2HJ5NGffsIS/PFO9yrkjDcqgXDUNbfNweu949VV7LiNnMMJfWuuvSd+uWK6HqFToiR2PjEn oOVDX+P6x7nweWc069pCKUd2Lme0T58541OrPd5fIvxI8EMZAJsgV9syX+2ui7bRl59oAmdk p3J73q1omho3OtwGrO52J1fh5UDkNf5qT8Q2pHzDV6an/cQPImgZGyaGpS1HyIKltUVMXNCj NSoFxx5OawNJyfxScrDtq9KWKEh34PpHaHJq1s3pGr1IPAQNcVH5wmUKt+GUHgDBpugztnr2 9FdUsZXEPFDyjvjq+klZQQA+nae7BH8V+WCP8RjUiamVSXpMkpSHdeYiWnVtSPhx0yAxBOgE dqzqMZiL2cuDqmJGclmt4kOFlUZGn/OsMcMC21IKFv3pHiYkVZUHqDjz3ysWBNRkPas2Epwl HHAQLRU/fRGVZZsm1fyc/RgS1JX1TYWVlxZHB8uZB6DkLctB9IoLK2T6KuzmqcbUYDyOkBMD fDJSAfOB9q2srf7m/kpB+SUXoh3ZkgJerbEfAqdKzSwGqkLMmSmbgBBOI8xucpCPn+9usCUe eSYGauXULFIvJs3wyevXA+PiZo7HEijPPzwRXghVLIl0IXEL7XIF58QascLMzZ52/4R+yQ2J E8id4up+O/PiHwbdGBoJunJQJrO1fWoWSsSfsvpo0RtaUutKFrF52eSCDWzhh8rWMDBdaxkF lbTLVw4bjHNIMqd8sOezhB9l5skNiUNkMkvgH/H+dWRyBgs1bLe9eSp7bYo7smBUOM4BH9Pl SS6CVR9fbIVSnr789TN4sgZWBNLEQs4nVr++2PM5DKAAKxbudZ4R60NGS+fLI1ctnzJZwA6h Jhp9eGkO+ce3CmhETevT5nLrlP9GjiS8WoGw6IEfNJ9dv/OVnkuNre3OejyDPsDT28YAAEgI cAc0oaZMFKkCMjg406yTLacN2/nms1119FpSh6nVvs0JW86GjVHUtaIRTU668mLwV7IzyNl4 DZ6uCW23T2/Shd1ZTCHElWeMtSG9J4dPmCEw5+bc4KvLCp+KIzgiNMJBc2ZlRM+wzA4w== X-IronPort-AV: E=Sophos;i="5.81,243,1610427600"; d="scan'208";a="39519006" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NjzsFduRYAyifaGHrYi0zfRHN5cZk5NsexePCSHo5egghXt3GjbhJS8j5RjPjjcFdi5n+faX6bsEAdA7/PmsvDtZuXFGwGxZHJ5eDsRtC29wtMqvkYis22niCJhA8od4XgMslUi8dKePQrYpNrwW/ullb4wYyCwJPei+4HwnqFHaHMZVlBdpVlMAcnwLgvWPRDgtE6Jsk7SW65d/xgoaBn85tQ8wjm5LPVAQnKKZDiHauhciiWlyHjhyt7Ha/zQ761Km8Qx3P5T3QxxzrAhFsJ2+W9KL4HXcHeDmBS15Mvnku+jTBUceVJcNPakEceAmcJJL5HOHnorxlEJKW48/lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F9zmieDEj7O7bFb35FrXJgCrlhxvLbHXtkvrl5oXUds=; b=NjGL6gynPXEP+8XQ7YsvimxUvasf3MqcQCtYhmv9VTnvo3lunPk6tPQz/hBELfA+pUnjPbfIimkMtXJg3LCpqXjEdga9XdRFTnbwqoH15Tony1POG30LN1SKo5+1INm33isBN+Juxu4j4/QAuTxcwGZMntVTsOEDO1UIzMOkQHsBEwUYWWzbT8DSCpj1VvakqaSYhoGGbSUR4g20oO+9Qcsyl4uVYSOSzPsRo2lIRLN5JH1rd+6VWd51nsB72rJIVoWSG3lXxdGyVAvhhsvVHPUCGwEDcg8TOdYNH/PKoD6rXVnFi5OtlVpIecYcgY6V0xD6Kff62d0sk6E5CoIbMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F9zmieDEj7O7bFb35FrXJgCrlhxvLbHXtkvrl5oXUds=; b=p3gIEk4TtHSm2/pPLbuTDXJkp0XQ7MdLDYNIpd4QMCTYAqbpQa0hSzX9Mk+my0XiDW7CPplN/I+XIIoAmClMm14nE/w6gbE9YmKAYtYLczbA99ktoi7YVJOy46rYAOjE00ZB5AS6O6sNqg3ZRhRaNx6X5Ylag6y4Gx/YtQI6nk8= From: George Dunlap To: Jan Beulich CC: Andrew Cooper , Roger Pau Monne , Stefano Stabellini , "Julien Grall" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH DO NOT APPLY] docs: Document allocator properties and the rubric for using them Thread-Topic: [PATCH DO NOT APPLY] docs: Document allocator properties and the rubric for using them Thread-Index: AQHXBE6IzoDpW0Psi0SLnVWLvJvx9Kpa6FyAgCWn/QA= Date: Fri, 12 Mar 2021 14:32:09 +0000 Message-ID: <63895FAD-B848-461D-8A31-E6C9973B6726@citrix.com> References: <20210216102839.1801667-1-george.dunlap@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 27fed8c7-d09e-4e28-0d5c-08d8e5639e43 x-ms-traffictypediagnostic: PH0PR03MB5670: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GthCHZ0H7UcQj6N+upovMMYZaEVsSoJsOJgC66IduUpJGT19rz6ZNxEbooXcv71idQG2ZrhW4xFCv9CETahOB4itcF8pmir7vssTlg39R2T4B2kq7cXN4kkbYmbILqOO/Ba5ZVidTp+e+PIR2srADN5RNTCoKW5yPM6WhnjwLEbnRWVUkviWTtSPUjjbPrkL/I9QmOUiLZs7dQYe8v7YcZ4iyLTYg/oy77XrP0qv5ugVK/Tb/fPttw6Ww08CxFzkHuj4T9Af8ziEnB3S+qCdEiGcHt9GnmfEptZjzAFDvy+W1Gyg8SRzbMiPKS1LZw6Vukuj+Idj5Ex/qXUiYTE7hA+ug/EtbaAJN5DytzayMYzKgfQ5UWW+ivA6P14AFgmaKpzi3jPxdcWUCBMJH9OGiG/fF54ai+huRK1k/Crewn+QMhEZNbUkxmZvV848cvkOHOCgMFIYzpNUJfl6FHMVK0UphH1s4DDPQIbK6WLhLR7Qa8KKvp6p4UH5k/pRCkDbQJfWv3L0scjORQt4EudsBt8il7LytBB7WUdHD4HOmBTsgOPi5OhAf1rFkfmyYakqeAGn24ijlKfHVvhF3lKdTvs9Je9UvLJvt6xwvATi2CSBPjD34udUK2GCoJRNSyAd x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39860400002)(346002)(366004)(396003)(376002)(8936002)(26005)(8676002)(316002)(6486002)(71200400001)(2906002)(54906003)(5660300002)(4326008)(91956017)(6512007)(186003)(2616005)(33656002)(66946007)(64756008)(478600001)(76116006)(66556008)(66446008)(66476007)(86362001)(53546011)(83380400001)(6506007)(36756003)(6916009)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?OUdFUUZ4SFFZaSthZVBJbTFiZ1NPVVBDUXZIUEIyU2ZjcW1OUnFSWnFOOWlH?= =?utf-8?B?NGpRWjdtaVNBdGlmMGY5UFZvS1VtSzZKOE1Ld2VMWitMYUIzeGRVc2MzcnB1?= =?utf-8?B?V0xzWEJNbHp4R0RLQXBGSW13cVQrMlVhS056RkdiUE1ZRk1zSXFML1M3WnNw?= =?utf-8?B?dGhiQVpHWDIzUWM4eHdEa1VMYnl3cjZaUnNFVHg2emhxcUQvM01xQ0dYNkZs?= =?utf-8?B?bG43TU8rWlVNS3RTck9NZjhBdzYrOVZFSVh6UGs5Z1JObWZJS3hwVzE3Z2Ns?= =?utf-8?B?ZzNiWTVUdU0zaWMrbkNKblVMdmVGSWpiOXNpbFRyZndJNFlVTGlFNFdqNHND?= =?utf-8?B?YmJlUG42UUtLTTdVaDRVQWM1NWU4QUN4RGJkcGtwSVZnK29OOC9EajYrUktZ?= =?utf-8?B?bmV5Rmg1WmZrUXFTem9GT2g0UnVIcFVyWm1VZXUwSU84M0c4ZUt0MHVyUys0?= =?utf-8?B?SWR3V2RiWnJwbUNtZEhoMTIvZG5HQ2s2MnROUkh6ek1TamZGZFRLZmduTFIz?= =?utf-8?B?VUZURUJTRWtrcjh3WnRHYkxJMzlDdGQrN1pIbDdkNFVHeUNmTjlhWnFhalNL?= =?utf-8?B?V0lIUi9nU1pMQ0RLdmw0bWtmVnNDWnRTaHpsU3UwamhPMWE1VDI5NDhRMDl1?= =?utf-8?B?Y0NyK0hJcDNPamVjYm9JMDZEZktmYVhpUHpzQzMzY3FLV0V5UzhCdlN6eFdi?= =?utf-8?B?NjB4cWxybERxTEhETm96eFpCd3J3cCtjWXZLSmlESEhEZTJvZUcwRXJxNGhp?= =?utf-8?B?bVQ1eXpXcWhwdkw3cVpoUnUzaVVuNUVnUjk3M0VCdnQrN3gvRnlONWkyMmNv?= =?utf-8?B?MnJNa0ZZQ1lFM2lKSnVmNUFmTXFpWjlHdFVqbmtLYlRRM2wzQlZ0d2V0bHds?= =?utf-8?B?TmoyWVJMT3VoNGdrYTM0bzJ3UXRxUkJyRjhDT05ybkVucENFWmNlS2hWZCtq?= =?utf-8?B?TFVGTndlUHRCeTA1V0Z6bGhUVTJiUndrSjdLN3IrRnFCTGpRaVpNSnROSVZK?= =?utf-8?B?YWcrcWlyQWozWUo0THZlWndrejI1dnZBOTRPOVpySnRSbjNJY2VlNWR4M2NO?= =?utf-8?B?Z2xVOW1Ec2xtdHpYNUhPYmRVVFA5VkxRQy9Ja3h3MVFUSXJpLzcwUjlyNXpF?= =?utf-8?B?aXhyZlUwbHJwSzAxYWRXdCtuVis0dldpWW5wOEdudW5uaWZjMmNxU0dkcnBa?= =?utf-8?B?T2w5YmkzYjFNT0hiTWxvRHJXK2orVS9zd05YNXhzSzdMV1c1R0ttbnJqV2hF?= =?utf-8?B?Q3VtQitVOG9CNEVDYjErbkJDdlAySk9mN1pNU2dma05jNENicHA2WmsyWGhM?= =?utf-8?B?L1J2eVVObmJWY2oySm9mMk9DNGRIZ3NkNE5MZnMyTlhBbVVYdUFkR0orM3hC?= =?utf-8?B?R2FRa1hrbFl5ZndOeDJ6ZXRyNmZCWmpDNjlvTFRZUTQ1ZS9Nbkd6Z1E0cmpF?= =?utf-8?B?SktDMUtJbzlrd3J3M3U3U1lSSjl2R25zNkFVRFZEaUpMSjZVSERuMFJRQXI0?= =?utf-8?B?Y1dZTitrSVhlTmF2dk9EdVI4ZkFPOTNncThGbzc2QmV5SDk4SVhHSlpZcXNB?= =?utf-8?B?TnNVeTRvbEVmTm55Zm9CRUZKTUlxVTZzWERhNWtySVVWcjFidGhqQTd0dlA1?= =?utf-8?B?OTZhd05MRjFhTHdqZ3dPcE85aW44U3RpWjY3NnFDa2lBaVRRVnRuS3M4Y2Fu?= =?utf-8?B?TlV3SktnUTFuSFpjaEo0N2FVMjFuSnkrMkhPSk0zbXFjT1VCRUFuNFA3ZDc0?= =?utf-8?B?bWlGWHF0UEpvc3RNU2xvWWNmMDdVUEMyZnJWRVdsa3kvTEJaT0FLV1ZGK0VM?= =?utf-8?B?QjJDU1VqVHc1cS81enlIdz09?= Content-Type: text/plain; charset="utf-8" Content-ID: <2924BA54739ECB418C97F87B461A3E9E@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27fed8c7-d09e-4e28-0d5c-08d8e5639e43 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2021 14:32:09.1776 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vlvNgi/vGdlDR1mnJ/kvCCS25FJl7yInXcCw83zJEl/wXp2E/Q8EDKAWlTvlj3lywUNPMZ0sGxqXeu/MXMTPrmLSnywnwEw+cQ8iqISH3dM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5670 X-OriginatorOrg: citrix.com DQoNCj4gT24gRmViIDE2LCAyMDIxLCBhdCAzOjI5IFBNLCBKYW4gQmV1bGljaCA8SkJldWxpY2hA c3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTYuMDIuMjAyMSAxMToyOCwgR2VvcmdlIER1bmxh cCB3cm90ZToNCj4+IC0tLSAvZGV2L251bGwNCj4+ICsrKyBiL2RvY3MvaHlwZXJ2aXNvci1ndWlk ZS9tZW1vcnktYWxsb2NhdGlvbi1mdW5jdGlvbnMucnN0DQo+PiBAQCAtMCwwICsxLDExOCBAQA0K Pj4gKy4uIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBDQy1CWS00LjANCj4+ICsNCj4+ICtYZW5o ZWFwIG1lbW9yeSBhbGxvY2F0aW9uIGZ1bmN0aW9ucw0KPj4gKz09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09DQo+PiArDQo+PiArSW4gZ2VuZXJhbCBYZW4gY29udGFpbnMgdHdvIHBv b2xzIChvciAiaGVhcHMiKSBvZiBtZW1vcnk6IHRoZSAqeGVuDQo+PiAraGVhcCogYW5kIHRoZSAq ZG9tIGhlYXAqLiAgUGxlYXNlIHNlZSB0aGUgY29tbWVudCBhdCB0aGUgdG9wIG9mDQo+PiArYGB4 ZW4vY29tbW9uL3BhZ2VfYWxsb2MuY2BgIGZvciB0aGUgY2Fub25pY2FsIGV4cGxhbmF0aW9uLg0K Pj4gKw0KPj4gK1RoaXMgZG9jdW1lbnQgZGVzY3JpYmVzIHRoZSB2YXJpb3VzIGZ1bmN0aW9ucyBh dmFpbGFibGUgdG8gYWxsb2NhdGUNCj4+ICttZW1vcnkgZnJvbSB0aGUgeGVuIGhlYXA6IHRoZWly IHByb3BlcnRpZXMgYW5kIHJ1bGVzIGZvciB3aGVuIHRoZXkgc2hvdWxkIGJlDQo+PiArdXNlZC4N Cj4gDQo+IElycmVzcGVjdGl2ZSBvZiB5b3VyIHN1YnNlcXVlbnQgaW5kaWNhdGlvbiBvZiB5b3Ug ZGlzbGlraW5nIHRoZQ0KPiBwcm9wb3NhbCAod2hpY2ggSSB1bmRlcnN0YW5kIG9ubHkgYWZmZWN0 cyB0aGUgZ3VpZGVsaW5lcyBmdXJ0aGVyDQo+IGRvd24gYW55d2F5KSBJJ2QgbGlrZSB0byBwb2lu dCBvdXQgdGhhdCB2bWFsbG9jKCkgZG9lcyBub3QNCj4gYWxsb2NhdGUgZnJvbSB0aGUgWGVuIGhl YXAuIFRoZXJlZm9yZSBhIGJlbmVmaXQgb2YgYWx3YXlzDQo+IHJlY29tbWVuZGluZyB1c2Ugb2Yg eHZtYWxsb2MoKSB3b3VsZCBiZSB0aGF0IHRoZSBmdW5jdGlvbiBjb3VsZA0KPiBmYWxsIGJhY2sg dG8gdm1hbGxvYygpIChhbmQgaGVuY2UgdGhlIGxhcmdlciBkb21haW4gaGVhcCkgd2hlbg0KPiB4 bWFsbG9jKCkgZmFpbGVkLg0KDQpPSywgdGhhdOKAmXMgZ29vZCB0byBrbm93Lg0KDQpTbyBqdXN0 IHRyeWluZyB0byB0aGluayB0aGlzIHRocm91Z2g6IGFkZHJlc3Mgc3BhY2UgaXMgbGltaXRpbmcg ZmFjdG9yIGZvciBob3cgYmlnIHRoZSB4ZW5oZWFwIGNhbiBiZSwgcmlnaHQ/ICBQcmVzdW1hYmx5 IOKAnHZtYXDigJ0gc3BhY2UgaXMgYWxzbyBsaW1pdGVkLCBhbmQgd2lsbCBiZSBtdWNoIHNtYWxs ZXI/ICBTbyBpbiBhIHNlbnNlIHRoZSDigJxmYWxsYmFja+KAnSBpcyBsZXNzIGFib3V0IGdldHRp bmcgbW9yZSBtZW1vcnksIGJ1dCBhYm91dCB1c2luZyB1cCB0aGF0IGV4dHJhIGxpdHRsZSBiaXQg b2YgdmlydHVhbCBhZGRyZXNzIHNwYWNlPw0KDQpBbm90aGVyIHF1ZXN0aW9uIHRoYXQgcmFpc2Vz OiAgQXJlIHRoZXJlIHRpbWVzIHdoZW4gaXTigJlzIGFkdmFudGFnZW91cyB0byBzcGVjaWZ5IHdo aWNoIGhlYXAgdG8gYWxsb2NhdGUgZnJvbT8gIElmIHRoZXJlIGFyZSBnb29kIHJlYXNvbnMgZm9y IGFsbG9jYXRpb25zIHRvIGJlIGluIHRoZSB4ZW5oZWFwIG9yIGluIHRoZSBkb21oZWFwIC8gdm1h cCBhcmVhLCB0aGVuIHRoZSBndWlkZWxpbmVzIHNob3VsZCBwcm9iYWJseSBzYXkgdGhhdCBhcyB3 ZWxsLg0KDQpBbmQsIG9mIGNvdXJzZSwgd2lsbCB0aGUgd2hvbGUgY29uY2VwdCBvZiB0aGUgeGVu aGVhcCAvIGRvbWhlYXAgc3BsaXQgZ28gYXdheSBpZiB3ZSBldmVyIGdldCByaWQgb2YgdGhlIDE6 MSBtYXA/DQoNCj4gDQo+PiArVExEUiBndWlkZWxpbmVzDQo+PiArLS0tLS0tLS0tLS0tLS0tDQo+ PiArDQo+PiArKiBCeSBkZWZhdWx0LCBgYHh2bWFsbG9jYGAgKG9yIGl0cyBoZWxwZXIgY29nbmF0 ZXMpIHNob3VsZCBiZSB1c2VkDQo+PiArICB1bmxlc3MgeW91IGtub3cgeW91IGhhdmUgc3BlY2lm aWMgcHJvcGVydGllcyB0aGF0IG5lZWQgdG8gYmUgbWV0Lg0KPj4gKw0KPj4gKyogSWYgeW91IG5l ZWQgbWVtb3J5IHdoaWNoIG5lZWRzIHRvIGJlIHBoeXNpY2FsbHkgY29udGlndW91cywgYW5kIG1h eQ0KPj4gKyAgYmUgbGFyZ2VyIHRoYW4gYGBQQUdFX1NJWkVgYC4uLg0KPj4gKyAgDQo+PiArICAt IC4uLmFuZCBpcyBvcmRlciAyLCB1c2UgYGBhbGxvY194ZW5oZWFwX3BhZ2VzYGAuDQo+PiArICAg IA0KPj4gKyAgLSAuLi5hbmQgaXMgbm90IG9yZGVyIDIsIHVzZSBgYHhtYWxsb2NgYCAob3IgaXRz IGhlbHBlciBjb2duYXRlcykuLg0KPiANCj4gSVRZTSAiYW4gZXhhY3QgcG93ZXIgb2YgMiBudW1i ZXIgb2YgcGFnZXMiPw0KDQpZZXMsIEnigJlsbCBmaXggdGhhdC4NCg0KPiANCj4+ICsqIElmIHlv dSBkb24ndCBuZWVkIG1lbW9yeSB0byBiZSBwaHlzaWNhbGx5IGNvbnRpZ3VvdXMsIGFuZCBrbm93 IHRoZQ0KPj4gKyAgYWxsb2NhdGlvbiB3aWxsIGFsd2F5cyBiZSBsYXJnZXIgdGhhbiBgYFBBR0Vf U0laRWBgLCB5b3UgbWF5IHVzZQ0KPj4gKyAgYGB2bWFsbG9jYGAgKG9yIG9uZSBvZiBpdHMgaGVs cGVyIGNvZ25hdGVzKS4NCj4+ICsNCj4+ICsqIElmIHlvdSBrbm93IHRoYXQgYWxsb2NhdGlvbiB3 aWxsIGFsd2F5cyBiZSBsZXNzIHRoYW4gYGBQQUdFX1NJWkVgYCwNCj4+ICsgIHlvdSBtYXkgdXNl IGBgeG1hbGxvY2BgLg0KPiANCj4gQXMgcGVyIEp1bGllbidzIGFuZCB5b3VyIG93biByZXBsaWVz LCB0aGlzIHdhbnRzIHRvIGJlICJtaW5pbXVtDQo+IHBvc3NpYmxlIHBhZ2Ugc2l6ZSIsIHdoaWNo IG9mIGNvdXJzZSBkZXBlbmRzIG9uIHdoZXJlIGluIHRoZQ0KPiB0cmVlIHRoZSBwaWVjZSBvZiBj b2RlIGlzIHRvIGxpdmUuIChJdCB3b3VsZCBiZSAibWF4aW11bQ0KPiBwb3NzaWJsZSBwYWdlIHNp emUiIGluIHRoZSBlYXJsaWVyIHBhcmFncmFwaC4pDQoNCknigJlsbCBzZWUgaWYgSSBjYW4gY2xh cmlmeSB0aGlzLg0KDQo+IA0KPj4gK1Byb3BlcnRpZXMgb2YgdmFyaW91cyBhbGxvY2F0aW9uIGZ1 bmN0aW9ucw0KPj4gKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0K Pj4gKw0KPj4gK1VsdGltYXRlbHksIHRoZSB1bmRlcmx5aW5nIGFsbG9jYXRvciBmb3IgYWxsIG9m IHRoZXNlIGZ1bmN0aW9ucyBpcw0KPj4gK2BgYWxsb2NfeGVuaGVhcF9wYWdlc2BgLiAgVGhleSBk aWZmZXIgb24gc2V2ZXJhbCBkaWZmZXJlbnQgcHJvcGVydGllczoNCj4+ICsNCj4+ICsxLiBXaGF0 IHVuZGVybHlpbmcgYWxsb2NhdGlvbiBzaXplcyBhcmUuICBUaGlzIGluIHR1cm4gaGFzIGFuIGVm ZmVjdA0KPj4gKyAgIG9uOg0KPj4gKw0KPj4gKyAgIC0gSG93IG11Y2ggbWVtb3J5IGlzIHdhc3Rl ZCB3aGVuIHJlcXVlc3RlZCBzaXplIGRvZXNuJ3QgbWF0Y2gNCj4+ICsNCj4+ICsgICAtIEhvdyBz dWNoIGFsbG9jYXRpb25zIGFyZSBhZmZlY3RlZCBieSBtZW1vcnkgZnJhZ21lbnRhdGlvbg0KPj4g Kw0KPj4gKyAgIC0gSG93IHN1Y2ggYWxsb2NhdGlvbnMgYWZmZWN0IG1lbW9yeSBmcmFnbWVudGF0 aW9uDQo+PiArDQo+PiArMi4gV2hldGhlciB0aGUgdW5kZXJseWluZyBwYWdlcyBhcmUgcGh5c2lj YWxseSBjb250aWd1b3VzDQo+PiArDQo+PiArMy4gV2hldGhlciBhbGxvY2F0aW9uIGFuZCBkZWFs bG9jYXRpb24gcmVxdWlyZSB0aGUgY29zdCBvZiBtYXBwaW5nIGFuZA0KPj4gKyAgIHVubWFwcGlu Zw0KPj4gKw0KPj4gK2BgYWxsb2NfeGVuaGVhcF9wYWdlc2BgIHdpbGwgYWxsb2NhdGUgYSBwaHlz aWNhbGx5IGNvbnRpZ3VvdXMgc2V0IG9mDQo+PiArcGFnZXMgb24gb3JkZXJzIG9mIDIuICBObyBt YXBwaW5nIG9yIHVubWFwcGluZyBpcyBkb25lLg0KPiANCj4gVGhhdCdzIHRoZSBjYXNlIHRvZGF5 LCBidXQgbWVhbnQgdG8gY2hhbmdlIHJhdGhlciBzb29uZXIgdGhhbiBsYXRlcg0KPiAod2hlbiB0 aGUgMToxIG1hcCBkaXNhcHBlYXJzKS4NCg0KSXMgdGhhdCB0aGUga2luZCBvZiB0aGluZyB3ZSB3 YW50IHRvIGFkZCBpbnRvIHRoaXMgZG9jdW1lbnQ/ICBJIHN1cHBvc2UgaXQgd291bGQgYmUgZ29v ZCB0byBtYWtlIHRoZSBndWlkZWxpbmVzIG5vdyBzdWNoIHRoYXQgdGhleSBwcm9kdWNlIGNvZGUg d2hpY2ggaXMgYXMgZWFzeSBhcyBwb3NzaWJsZSB0byBhZGFwdCB0byB0aGUgbmV3IHdheSBvZiBk b2luZyB0aGluZ3MuDQoNCiAtR2Vvcmdl From xen-devel-bounces@lists.xenproject.org Fri Mar 12 14:52:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 14:52:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97171.184426 (Exim 4.92) (envelope-from ) id 1lKj9Z-0003vi-Mj; Fri, 12 Mar 2021 14:52:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97171.184426; Fri, 12 Mar 2021 14:52:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKj9Z-0003vb-Js; Fri, 12 Mar 2021 14:52:37 +0000 Received: by outflank-mailman (input) for mailman id 97171; Fri, 12 Mar 2021 14:52:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKj9Y-0003vW-SC for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 14:52:36 +0000 Received: from vps0.lunn.ch (unknown [185.16.172.187]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 323cef2e-2768-4c63-bbd8-ccfd19ded29b; Fri, 12 Mar 2021 14:52:34 +0000 (UTC) Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lKj9M-00AXgg-LW; Fri, 12 Mar 2021 15:52:24 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 323cef2e-2768-4c63-bbd8-ccfd19ded29b Date: Fri, 12 Mar 2021 15:52:24 +0100 From: Andrew Lunn To: ChiaHao Hsu Cc: netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring Message-ID: References: <20210311225944.24198-1-andyhsu@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210311225944.24198-1-andyhsu@amazon.com> On Thu, Mar 11, 2021 at 10:59:44PM +0000, ChiaHao Hsu wrote: > In order to support live migration of guests between kernels > that do and do not support 'feature-ctrl-ring', we add a > module parameter that allows the feature to be disabled > at run time, instead of using hardcode value. > The default value is enable. Hi ChiaHao There is a general dislike for module parameters. What other mechanisms have you looked at? Would an ethtool private flag work? Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 12 15:12:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 15:12:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97179.184448 (Exim 4.92) (envelope-from ) id 1lKjSp-00063l-K7; Fri, 12 Mar 2021 15:12:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97179.184448; Fri, 12 Mar 2021 15:12:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKjSp-00063e-Gj; Fri, 12 Mar 2021 15:12:31 +0000 Received: by outflank-mailman (input) for mailman id 97179; Fri, 12 Mar 2021 15:12:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKjSo-00063Z-9S for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 15:12:30 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c91658fe-70f3-424d-b9e7-13fd40dca776; Fri, 12 Mar 2021 15:12:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c91658fe-70f3-424d-b9e7-13fd40dca776 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615561948; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=Szvwm68z069ddCDHJd9X5X0XnfwkZeFepUpGbh/uU2k=; b=YigOqeV8XD8LYQkxxgI9fB326Z7tpVoqYc9iOSFXmSbI7UC8/n+Rma7p 3/mS3Ke7fCOcXzZtMdCJHwYiudMBQ7PQ22t0i2iwwmEyXd38m0NxI0NRe xhvHQ4OYCedPdM1Vdk16XsAxLGmKgbZ+Tk28wakhRMjsCUAIoIrAAwOBb 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: jdBUaSxV4KDSvVN9ShbE4iDlU0z3LyG6iyIS54CGYGyCE0OrLsAhlHMjfEnpT6EelKDFc4NEkb hn6znnPQ0aBlDozTW0QECap3B0p9q/PzlC6seEZQMyn399t3jsNDKf0VpjXovOFMSxZGxKFecg gz+NiriHnCS0DCzLN0hsVX3WI4v/SXTHW8qhDf7cC8/CdCve411bxRlPomjjraVVG4BJXSXq2e alzqSLlENSAeqon+rIT1RhyQjNemEEMIT6SMw6Mf9vFaLl/U5POLmgJCAp00ce7c/t2oRHjzuA sXU= X-SBRS: 5.2 X-MesageID: 39153835 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Pmldb6mTbIqaulcREzO46x9bEObpDfOBj2dD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLN/AZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 tdWoBEIpnLAVB+5PyW3CCRD8sgzN6b8KqhmOfZyDNXQRt3brx7hj0ZNi+wOCRNNW17LLA+E4 eR4dcCgjKmd2geYMjTPAh7Y8HoodrXmJX6JSMcDxk85wWUyR+u4rj2Ex+Xty1uLw9n67Ek7G TDjkjF9ryu2svLtyP0+k3yy9BtmNXnwsZeH8DksKYoAxjllwrAXvUYZ5SspzYwydvfjmoCsN 6JmBs4OtQ21nW5RBDOnTLI+y3NlAkj8GXjz1jwuwqRneXcSCghA8RMwaJ1GyGpknYIh9133K JV02/xjfM+Znmh7UeNkuTgbB1kmlG5pnAvi4co/htieLATdaNLqsgn9F5Vea1wbB7S0pwtE+ VlEajnlZRrWG6dBkqp21VH/MahRTAaEBuAXyE5y7eo+gkTtnV4w0wE/dcYj3cN+bksIqM0lt jsA+BGkqpDQdQRar84LOAdQdGvAmiIeh7UNnmOSG6XW50vCjbokdra8b817OaldNghy4Yzoo 3IVBd9uXQpc0zjJMWS1PRwg17waVT4eQ6o5tBV5pB/tLG5bqHsKze/RFcnlNbli+kDA+XAMs zDe65+MrvGFy/DCIxJ1wrxV915Mn8FSvAYvd49Rhanvt/LEIv3rebWGcyjZIbFIHIBYCfSE3 EDVD/8KIFr9UawQEL1hxDXRjfDYUr60ZVsELXL3uQaxYQXX7c89zQ9uBCc3IWmODdCuqs5cA 9VO7X8iJ62omGw4CLp4gxSS15gJ3cQxI+lf2JBpAcMPU+xW60Eoc+jdWdb22bCAhd+SsjRAT NOvlgfw9PxE7WggQQZT/63OGOTiHUe4FiQSY0Hp6GF7cD5PrQ1E4ghQ640MQnQDRR6lUJLpQ 54GU45b36aMgmrpbSujZQSCu2aXcJ7mh2XLcldrm+ak16dq8EpTn4yRCWvTsaTvAYrS1Nv9x 9M2p5apIDFtSekKGM5juh9GkZLcn6rDLVPCxnAWJ9ZgYnxeAZ7TX6DgBuTjx1bQButy2wiwk jaaQGEc/DCBVRQ/lRVyLzj/l9PemKBRE5ocXxhvYphFWPJh2Zr3YawF9iO+lrUTmFH7vAWMT nDbzdXGA9oytyt/DO+mTqJFxwdt98TF92YKI5mX6DY23urJoHNqLoPGOVM+o15cPr0tPUQbO 6ZcwiJDT/xBu8zwTaJrnI9NCQckgh8rdrYnDneqESo1n82BvTfZGl8T7YAOteG8izKQe2L3J gRt6N9gcKAdkHKLviIxqHcY2Qddlf9oWuqQ/oprp4Rl6Qor7d3F4TaVzyN9Hwv5mRIEO7E0G clBIJ86/T9H6UqWeo4USdQ5EAom9SCN1FDiH28PsYOOXUWy0bGNNaI6YfSobUhAke9tBL9UG PvhxF1zrPgZW+/zrYUBKI7HHROZGU94Hpk+vmed4e4MnTdS8hzuH67OGS6arlTVeysHqgRtA 9z57iz7qKqXhu9/ADbpj1gJK1St06hXMOpGQqJXcpF6cazN1jJoqyk5qeI/XvKYAr+T0QTno tec0MMKuxFlzk5lYUylhGIdZafmDNsr3JupRd9llDs3YC64GDUWWF+WDep/Kl+bH10KXiHjc PM7O6C8m/yiQI1gaX+KA== X-IronPort-AV: E=Sophos;i="5.81,243,1610427600"; d="scan'208";a="39153835" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qq7pQcKKEvuQ5De2TEsW+pKtolnf4IkLDhrdAr1f9rXNbep6AU7kIg181ysLciwBhbYVXY4WsS4FQ5+lL8HNgnZjSR2z0RqyECekGylKiOWixiW80TUuKN/OVXpweRkRniAaA8bLQMwicem6H+Ehpdr9jNBmkzDKxlifJg6t21K/QmmVhLqu4Q1fDF8L0aT50zHqrVjNtqRGHrcGQsP3z67YuXdIMsHxdY5LweuzfUo3WXIFkn1qYTs7vKUJTDpTExeBYPleLdfqnhNBCwnpWCmeC6qgNyYd7H8etvaKJYsm9m7XjSYeU6ejUeiPOdV+gBc9oIM44Q2NO2r1Wp0/gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FnjvWAL84YNJo6CW6NB//XIqNn1d9e6sefYi5QjcG08=; b=NA6Eaa4a2C44WufLjyYF9gsb/unwYf6YHkU7r0R+6YELv9cchqu8FA65YE7JXeS6og/SzcZu8wuSLNVLpUJ+q1g5oVsOC/umnUoIxtzScJh69b6rnEWpGz+OS2wakIb0OlUZcG9LnOsvCPqa4jmaI6nUflBKWwg1y4ELa9kuWvCgLWCG+SBeBjZ/yUPq6SP8+gBa+Mkbcn13Kh760xpiZhZDVmPzsT7a3XoJKGtou56GYz2lGHG6YmLmuyiSz+AyyePhM/MiAguqLdFLAHhJ5FiIM+G2hJXIR4AdB0kTjx76WBiLRasD8muYAqxHku2KAgIiHrqoNUAhv3tb46BZhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FnjvWAL84YNJo6CW6NB//XIqNn1d9e6sefYi5QjcG08=; b=AD6/U2HS9GxNKrF3maDuf9tvlRhu89TKC0hTVoKeCftx1zhbJoOAXKZ6MgRRmw6o0NfF+i9iUjClSMTd9NHmAGVTuWrckqn1CRPquM4SyuZnK/MBVn66cNArf/0epdEL5jCSqb66l2O4oJB8SDoJXAgtChJixuT6fRUGc12p0Wo= Subject: Re: Working Group for Secure Boot To: Bob Eshleman , Xen-devel CC: George Dunlap , , Olivier Lambert References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> From: Andrew Cooper Message-ID: Date: Fri, 12 Mar 2021 15:12:13 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0029.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::17) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ec490510-c5d8-4812-821e-08d8e5693b0e X-MS-TrafficTypeDiagnostic: BN9PR03MB6025: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v3E+TyTVOMutbY80IS2P+OM/lIAJ2rBcmCrvkUeYQgzGbyq1EO4uMtqxC3WiPOLT4GE49496zitXduBhCL0aw0ZyyAzHBP+tfGLigxe/Lo9o6uaH4L3wbArQO+2XqDRdy8hCxPHMvjnSLtJwzclX+w+AijbXa/pVuu1Z8p2UVieWUrleZ4HpB4nrlTqpyzCJx0OK1xw8SlKiTmRtO8i8NF1lHaWbVW79VXym/czmx3qNQP6tPmZfDJpIOIioxQue272Ir8v59HWoWWJW642x0Gl2OFZzArz/Bf4bY/aYOBZDLjUiVsf6l9J1sWXEg2LIHO68IVvnvPOhgfsGLH5nssW0BMwdWZ3tIEf0k28cs7/JywTOQn9TDSXRk+94p6KRLAF8C9I72gPIPT/nJBKDKiXE23hivNdGx26p61PjTrbI5KojiBzX2i/pCr0YuvsUZ4NwkLOjBsjbTrNrt5hVatpc7rCn+3hFUw6vTugnPETBYykh91gRewsQWCZ8QNJavevTIGkPMs/jltyZHavht8W05pQLjhg+oMwANQ2l/R9Sl+wSKOK5ckf3mv0pK4NJPi6FAvG2kLBsgZVCpNpMs+zdPr6FbbcrwIrC7qA7PWo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(136003)(346002)(396003)(366004)(31696002)(83380400001)(186003)(16526019)(36756003)(2616005)(5660300002)(110136005)(4744005)(26005)(6486002)(54906003)(66946007)(956004)(478600001)(66476007)(16576012)(8676002)(8936002)(316002)(31686004)(53546011)(4326008)(66556008)(6666004)(86362001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Rk5kMERiQlJNQS9wVURXTnAxWTM1cXVLMkg1bnY2Rit1VDBQUTNuTjlORFBM?= =?utf-8?B?Y0tlaDF3bmZDOUYvcUErMnVNdnk0VXZuRVllNGZoeDRMNW9sY2dSaGluTFBm?= =?utf-8?B?UHdRdCs3UGtmcUpLVmU2WGs5bWtRbmlhRkdqZjFtRnJaSlJIdXpLVUVwNENo?= =?utf-8?B?YXhxWEpPenpXR2RRQ0tWdHdLNjNtaHV2Ri9HSGFEekhkejhraVFmVERmbGFY?= =?utf-8?B?cmlDMWdIcVc5Qy9aY1lDUUZCbVZRbDNpemErMmRZeitzMlJ4U1BpanVtZDVs?= =?utf-8?B?NFY3Vk82elQrbjBXeDEwZjhWbVFydW1ad2hjZU9QMGdnUEg2YXdHQ2ljZG9I?= =?utf-8?B?ZVZ6UzZYZFVkVHVpS3NzbDYxUlhSV0dUTHYxRnVMNkdFVW1xYjZVMlN3SEo1?= =?utf-8?B?dDBBVGRLbkJ4QXM2dGxFQk9IbVlYT3pQRHRyblRSRVlCUmVJbEZMQmt6bFlT?= =?utf-8?B?Ym1UclovY2YwNVVFWUxYcGJoaWUrZ1BObFo1VjRlMWlhTVl0LzRHNTNQVjZi?= =?utf-8?B?L2hybnRUUXpXdmxFalN2SmF6bU9JYTdGemUxMUJ5bjZaUkswOURvRW9NSlVH?= =?utf-8?B?MFZUZUw3Z0hNUzBSbStQeklMUmtWKzcxVHFIWGpUc2F0ckRJS0M4OXBYTGNR?= =?utf-8?B?bzhOVlBWTDB5T0J0Q0w1aGRweE5GQWZzMkp1NTN5T1hjYkxpeldYRHFDS2JI?= =?utf-8?B?L1hxR2x1MXFIWnJMRmVZc0U0VWRycXpOdGZJbHRwQTRXNm5pMElDVkJuMWZm?= =?utf-8?B?YjdTcUlTY0k1TjNZZlMwdTJWak1iNDhNenh3RjNxTm1mMWpHQS9DemhNT3FT?= =?utf-8?B?OEsvaEtSa09aV3RwYkFhcUxWd0oxQkpQSnpyY2lLZHVydHpzQVVpOHR1SHRG?= =?utf-8?B?ZEU5dXprcTVtNmJTWElpQ3p1QjhkMzVBdCtIUHNsS3pVM3JIU1VmR1NEZlpP?= =?utf-8?B?NFJYZzlEbUUxWmF1MmpBODdLdHVWUzhmRnVvREJnNGNvbTJodFNkL0lEakJa?= =?utf-8?B?T1lHVDhDMVRRRDkvTjRwMDRycDJzc2pubWpBZlMwTHlUWHNiaUdkeVFOL1Zu?= =?utf-8?B?Um1ZTmtLL2RSYkNteGZLUmFRZlhNUU5CaEdNTVhmL3h6Z3pMZFpPNHdWL2dW?= =?utf-8?B?YXBMcEVxZXk2RlAvRS91YTJIOU1CSUZvMkZTUzBGT2ovZVk2czBmQnN0TUJs?= =?utf-8?B?THZsRkZENzQ3NFZCamIwVTlScU5IbVlWNG9VZmdkRjJMZnAyL0ZMUUxDRUZy?= =?utf-8?B?RG0wbzI0dVRJSE5ydGQ1ZmNnSFB6THFGL0F5QmpvdkRBOG1GUG1KUDlaN01w?= =?utf-8?B?dGE2cTNiTDZlVzhXb0dCaVo3UUE5V3dybXNFWWJoM2krZWdBUnhheFA0c3dE?= =?utf-8?B?UlkrcEZFRHM5RExZMGVJQ3VsM1RPNFdtWEdUTDBOcDFNVXRJQ3JaMXdrSGVG?= =?utf-8?B?SURGaXZBM3UvVDdIREYveTJ6RVVDdHlDMmsyMXExOWI0M2grbjZvRjdQZkV2?= =?utf-8?B?ZVVuTXc2SE53UExXcG1odnBlZWRkb0Rtekt6eldGRVZLbUh2SWpldFNDeXJV?= =?utf-8?B?Q1IxbXRuN3E3aGJMUXl3MG9OMWpSN1JVdFJoVUlobmtLUlJ6OG41MXZ4ZjI3?= =?utf-8?B?WE12blNySTlIWUhlYzhRV2FhT0VjeTZEUlJ5RHFoT0R4cEpBcWZxSFZwL0Iv?= =?utf-8?B?UDVma3VKWlBIN1JmY1N5OXNmK0VjeERMbk5DVjMxV2s3c01odXZ2TWhya2ZC?= =?utf-8?Q?Fau+fIWQkjR0dSoz2Tp+LW+TnglL02CjP3G6f65?= X-MS-Exchange-CrossTenant-Network-Message-Id: ec490510-c5d8-4812-821e-08d8e5693b0e X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 15:12:20.0657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S7qX2o/TPExoB/5z9c9lhrWoEv3dtFFQMWCP2oTQ2N3MhLuFLedsRpOOJpZIFiOUVBDnufEOtbOZekk+EZviqokCeVNM0xAWcnCuyNpUhbM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6025 X-OriginatorOrg: citrix.com On 11/03/2021 18:34, Bob Eshleman wrote: > Hey all, > > We would like to start a working group for secure boot support in Xen > to coordinate the various interested parties and set out a plan for > the feature and its implications for the whole Xen system. > > The end goal is a full implementation that restricts the interfaces > dom0 has to affect Xen, akin to Linux's lockdown LSM. This implicates > important parts of the ABI (e.g., /dev/xen/privcmd/) and so will > require input from the greater community. > > I'm not familiar with how working groups function in the Xen project, > so this email also opens the floor for suggestions as to how this might > be managed. > > We'd love to hear from anyone interested in such a group and how the > community as a whole feels about such an effort. Count me in.  This is years and years overdue. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 12 15:18:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 15:18:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97184.184463 (Exim 4.92) (envelope-from ) id 1lKjYS-0006QJ-B1; Fri, 12 Mar 2021 15:18:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97184.184463; Fri, 12 Mar 2021 15:18:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKjYS-0006QC-7z; Fri, 12 Mar 2021 15:18:20 +0000 Received: by outflank-mailman (input) for mailman id 97184; Fri, 12 Mar 2021 15:18:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKjYQ-0006Q7-TM for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 15:18:18 +0000 Received: from smtp-fw-4101.amazon.com (unknown [72.21.198.25]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 51a1c8db-385e-4e34-85ae-1cdc7be4577a; Fri, 12 Mar 2021 15:18:18 +0000 (UTC) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2b-859fe132.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP; 12 Mar 2021 15:18:11 +0000 Received: from EX13D12EUA002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2b-859fe132.us-west-2.amazon.com (Postfix) with ESMTPS id CF1DD220186; Fri, 12 Mar 2021 15:18:09 +0000 (UTC) Received: from 147dda3ee008.ant.amazon.com (10.43.162.213) by EX13D12EUA002.ant.amazon.com (10.43.165.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 12 Mar 2021 15:18:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 51a1c8db-385e-4e34-85ae-1cdc7be4577a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1615562299; x=1647098299; h=to:cc:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding:subject; bh=fXChBcwn3i8+I8FRgnwJ2UacpPT+Q/2Jk1d/TX9xTNU=; b=bZyNTpJOkd/ZxN1TLhFvDaZLq7+fAsfqUcRG+5CshWZUk4bcLmW9O8ML 0uNMAYsNRVV7p0Bhv1fAsUP9sx5DgJ04UE8/zTh9H+Ie3QuuvTjx70rOo wGeMoHtXeDz7HmjoaNzAtsVMCAU3o/Uo72mwkq5GHxHOTSJ6Lh7y17dkk o=; IronPort-HdrOrdr: A9a23:jABeqaDMkSulc2PlHekZ55DYdL4zR+YMi2QD/UoZc20zTuWzkc eykPMHkSLlkTp5YgBHpfmsGomlBUnd+5l8/JULMd6ZNjXOlWO0IOhZnOjf6hL6HSmWzI5g/I NBV4Q7N9HqF1h9iq/BgTWQN9o72tGI/OSJqI7lvhVQZDpnYa1h8At1YzzzeiZLbTNbDpk0Ho f03LsjmxOcfx0sH6CGL0hAceyGg9HQjprpbVo9GhY75GC14Q+A2frVFR6X2xtbfhFu5fMZ8W bDmxHk/anLiZyG4y6Z+WnU4ZFb3OHk18IGPsqRkcIYQw+Cti+YIL9sUbGDozw5ydvA1GoX X-IronPort-AV: E=Sophos;i="5.81,243,1610409600"; d="scan'208";a="92520097" Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring To: Andrew Lunn CC: , , , , , References: <20210311225944.24198-1-andyhsu@amazon.com> From: "Hsu, Chiahao" Message-ID: Date: Fri, 12 Mar 2021 16:18:02 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.43.162.213] X-ClientProxiedBy: EX13D04UWB002.ant.amazon.com (10.43.161.133) To EX13D12EUA002.ant.amazon.com (10.43.165.103) Precedence: Bulk Andrew Lunn 於 2021/3/12 15:52 寫道: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > On Thu, Mar 11, 2021 at 10:59:44PM +0000, ChiaHao Hsu wrote: >> In order to support live migration of guests between kernels >> that do and do not support 'feature-ctrl-ring', we add a >> module parameter that allows the feature to be disabled >> at run time, instead of using hardcode value. >> The default value is enable. > Hi ChiaHao > > There is a general dislike for module parameters. What other mechanisms > have you looked at? Would an ethtool private flag work? > > Andrew Hi Andrew, I can survey other mechanisms, however before I start doing that, could you share more details about what the problem is with using module parameters? thanks. ChiaHao From xen-devel-bounces@lists.xenproject.org Fri Mar 12 15:19:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 15:19:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97187.184475 (Exim 4.92) (envelope-from ) id 1lKjZJ-0006WX-LZ; Fri, 12 Mar 2021 15:19:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97187.184475; Fri, 12 Mar 2021 15:19:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKjZJ-0006WQ-IQ; Fri, 12 Mar 2021 15:19:13 +0000 Received: by outflank-mailman (input) for mailman id 97187; Fri, 12 Mar 2021 15:19:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKjZI-0006WH-Jf for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 15:19:12 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 24b8dbff-6922-4624-ba44-773dc70c82a8; Fri, 12 Mar 2021 15:19:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24b8dbff-6922-4624-ba44-773dc70c82a8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615562350; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=b7HBZQMO8XAMdeHGp9TbhzybQ0kHpW9eiaccNXupzIo=; b=NvSkaDHfuqS7qEUdP1qQJS68a3XMJkYNcU/3WaRCvdwJ+52ISQzJFyuA X2Uj8Vn0IYZ3jMm+TCqn7KIluMy1cdeTysyQbgqnTwWY2L6WjpRc1yu06 dPsAHRz3XOQ5jMTK62n/KOeH52OVfS79OBSxgaeWRCfZUJ9qhwuMILozW A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: qdtduvpfk/WyA1athWJ8e/PAzkQNsm6u3DI3H6EVoBw4gm5v041i7MNOVpSt8ogWETVSlWgUlQ /BQINfHWDhEVQV8X8DfRrQGbkpLXRvQHDMDHhSG1e1KPaGN2IUVpgkwKXyogA6T8KIDRgo8w+t rqO29dkmnfuddO8vfmjrdfl7Cty0ybhdxCyZmSRT++skDO40Z3PRUXyT0xfARQfpnQrOgajBhT IjtUmANLKiio62GhU4jXvX6eFIqAILAH4F2c8FpNlziJAkuUjE75VHD+BQPvV7VfOfJK8BRRwl Zs0= X-SBRS: 5.2 X-MesageID: 39523313 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:aJWVgKATBL8Av0flHejXtceALOonbusQ8zAX/mhLY1h8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPufVr1zrQwxYUKJ7+tUE3duGWuJJx/9oeK+VHdMgXE3Kpm2a 9kGpISNPTZB1J3lNu/xQG+HcopztXvytHUuc715R5WPGRXQotn6Bp0DRveMmAefngJObMSEp 2A6s1b4x+pfnoKZsq2b0N1I9TrjdvNiZ7gfFo6HBYh8gaDlneF77T9Hhie0H4lInJy6J0l9n XIlBG827W7v5iAu1Dh/kLwz7ATotvuzdNfGNeB4/J6FhzAghulDb4RIoGqkysypIiUmTUXuf nK5ywtJsFir07WF1vF2yfF/ynF/HIQ52T5yVme6EGT4fDRYD4hEcJOicZ4X3LimjIdlepx2q 5KwG6V3qA/ZXir/UTAzuPFWB1wmk2/rWBKq59ps1VlXZYDc7gUlIQD/SpuYc09NRjn44MqGv QGNrC52N9qcEiXZ32cnm5jzM3EZAVUIj66Q1MPssHQ7j5OnHoR9Tp++OUjmB47hfAAYqgBw9 6BHrVjlblIQMNTR7l6Hv09Tcy+DXGIaQ7QMUqJSG6XV50vCjbokdra8b817OaldNgj150pgq nMV1teqCobZ1/uM8uTx5dGmyq9AlmVbHDI8IVz9pJ5srrzSP7AKiuYUm0jlMOmvrE5DtDEXe 2wfLZbGeXqI2erOYsh5Xy6Z7BibV0lFOEFsNcyXFyD5ujRLJfxi+DdePHPYLX3FzIpXX7+H2 sDUDD/KN4o1DHtZlbIxDzqH1/9cE32+px9VILA+fII9YQLPopQ9ggZ4G7JoP2jGHlniOgbbU F+KLTonueQvm+t51vF6G1vJ15YBkZR67PwTmNSqWYxQhrJWIdGn+/aVXFZ3XOBKBM6ZdjRCh Rjq1N+/r/yKYeRyyAkA9euKXmbkHMXuXKPQ/4n6+m+zPagXql9IoctWaR3GwmOPQdygxxWpG BKbxJBWlXSDSr0iaKujIUdAebWc9UUunbyHedk7Vbk8WmMr8AmQXUWGwO0WcmMmAA0Wn5/nV tq6ZISh7KGhBeiIWYym/4DLVVJcWibaYg2VzitVcFxoPTLcBs1ZXqWjTaa4itDBVbCxgE3vC jdCgG6PdvMGUFQv3hE1L2CyiILSkytO2Rqan57toVhE3/hoXgb657XWoO6z3aRZlwewusULT HCZn8ILhlzws2svSTl6AqqBDEowI4jMffaC6lme7bP2mm1IInNjq0eGeRIlawVeezGo6sOWe KbdxT9FkKIN8o5nwiUrG0iIi96tT0tlu7pwgTs6AGDrTUCKOuXJFRtXLcAJd6Aq2DiWvaTyZ 18ydY4p/G5PGm0atmIz8jsHnR+AwKWpW69VOczr59I+ao0qbtoBpHeFSLSy2sv5mRJEO7k0E cFBKhr6rHIPYFiO8QUZiJC51Is0NCCNlEivAD6CvI3FGtdw0PzLpeM+f7FuLAvCkqOqE/rNV 6T/zZU8v3FUyGAvIRqQ54YMCBTcgwx+X5i9OSNe8nMEw2sbfhE50f/PXmncrNRIZL1bok4v1 J/+ZWPkOCWfSajh1yVsjt/P65U82GoBcm1GxmBHOZU89q8fVSA65HalfKbnXPyU3+8bU9dmI hOMUoXZc5HgiM5jII23jOpI5aH634Ngh9b+3V/ilXp2oK6+2/VEkFNLB3BjvxtLEtuG2nNid 6A7POR23v86iVUwJXPFE9feddVBtgbJ7KHWxtGOIwXp76n/60mnyRFblMvFgcH+UPA498= X-IronPort-AV: E=Sophos;i="5.81,243,1610427600"; d="scan'208";a="39523313" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eu4X+uSrxBij32YTECcF4rXP8es3nhuF7yJItzn2P01Zw1q2UDmP+s4X0v08SR5NSrOlFkDzxs1WLx7e+2Zj+dcxun+4gRtAwXA7tNWfC0OoN5adHPuLzqTJBFCFERFJzoL5wj5SwPCfrrtHX99cl/A3pGkj3U3HejnWTzKkQK4wrKf3GHi9nEB2DmTSZb7fGkaEPAdUYPNJmjtUT5UiPMBkLBPAvHGEChnq+8KsGV8NEMHrgG2dUeLsLJkVJeAgtBr6xYMPzpr2p0a+FZBv4ouJFgOlT520VZDyImefHJD1FCFK77P6mVeHxcEjVJe0poBTb5OfqP1qd4bKAhZGlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b7HBZQMO8XAMdeHGp9TbhzybQ0kHpW9eiaccNXupzIo=; b=H7fDhLYE2mmdKblzWd5qc73QsRY3pnzFBENpTRSUX7+dPbJV1CratHB8N7XCkuRE0sKp01z/Xq1/Zz+ATuzVpn5gf/3ZZuUE96dwxNvazGznhQXRbiP8oQ7mLDOKVj8trWsktxI/KPcioYuEBdWe3bO/qqAMitdAYW4vcvPoA+wORUzbNC4ard3v4Tfot7rlZztdmt3XYDsb1eoXBrS3fOUgQKsMrJf08kRwZ1WBFv2iSDpN8h0ExX4V2fIJFUjteCoSCbzI7qkSwy96+mUpkPiS1wT2iosqGIA7OvhZBklhPgrvdv8izGPB7c9b9A5rwoyrfWwoeJuNSeoznyjMMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b7HBZQMO8XAMdeHGp9TbhzybQ0kHpW9eiaccNXupzIo=; b=CdZh8fFyZlk5+so9rEbxjXIYH0ptZAozhpavvWm7bpuLWRy7tFrFl9FoNrJgSPeyHiu3PjoQzLUAMnbqcQrORYpVRrxvZjmKPIfIa6mAoc7lZXwJaW3iRfLVtE2ZTJzNOgFeYH8sQB4nSAEIYxVK7Ra+YO0u61vgzo7ZwJdpa1w= From: George Dunlap To: Jan Beulich CC: Andrew Cooper , Roger Pau Monne , Stefano Stabellini , "Julien Grall" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH DO NOT APPLY] docs: Document allocator properties and the rubric for using them Thread-Topic: [PATCH DO NOT APPLY] docs: Document allocator properties and the rubric for using them Thread-Index: AQHXBE6IzoDpW0Psi0SLnVWLvJvx9Kpa6FyAgCWn/QCAAA0bgA== Date: Fri, 12 Mar 2021 15:19:04 +0000 Message-ID: <199F2B82-6172-4DB2-A747-182EC42C6E9C@citrix.com> References: <20210216102839.1801667-1-george.dunlap@citrix.com> <63895FAD-B848-461D-8A31-E6C9973B6726@citrix.com> In-Reply-To: <63895FAD-B848-461D-8A31-E6C9973B6726@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8120a6c7-a4cc-4739-9046-08d8e56a2cad x-ms-traffictypediagnostic: PH0PR03MB5927: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OaFfYCphA1ySX+xxgDTpvrOKDzRyGVf/84TZUG+RIeyei+Dm2DUYvPQrPIHh3XlevdqYVOOXKlns540VAIFwG6PCtWY+aHoVX0CaBUBl/iv8xCcK8IGWrHdX97khyCgCiWWIR2hVP2UOBpzZlAWEabjYMJBRaGxtDq6Ol7EfBfz36vMABZjBVAg5TUeL9lvqEotafKcgD5nIqZj9RAYzwZcLAUcbDvEOdx9ToRkmyxwNPg6fEEPrYgsEKCWgZiwadBFoTLenwpLgh7t2lNUfGteJVxNJNhuUo9oBqddbiFtEzS/t8bbdjYCrM39HGQubCRhhT29IEsv8wWDuDq2O3SMHFwBYb70lwOg+An63hVijDkHPiTHap312bkU4/q4sU0e/vyLZE8wVh1s8CNH+wN41XIftvCdk20uT0sggnOVQXbBqCdTzWxeLK3cEPOxUyoMTe4/9wPXZl9iXAx/LHTJNJu4LQLhhnAmf+K2ULpDax55+4toS3wwtOPTXD2VBbKy2ttA5IRoliH9QY0v7oewaAgt5b16d1gZ5sptCCXCqJgFI3XoBO6fDB7qPZrBS5brX7agLmKHeY2MPO+R8HJXYuDnUBBi4huEFfVO4z7IfGIcIC/bfD0wHbbL2xsZE x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(346002)(136003)(39860400002)(376002)(64756008)(66556008)(66946007)(66476007)(33656002)(91956017)(76116006)(83380400001)(66446008)(6506007)(53546011)(186003)(478600001)(316002)(54906003)(4326008)(8676002)(5660300002)(2616005)(8936002)(71200400001)(26005)(6486002)(6916009)(36756003)(86362001)(2906002)(6512007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?cFF2anZKY2dQcFRXUHpGTS92MXNsaXhWQkQwenhaaDdMczB6aWNwQ0thVWdk?= =?utf-8?B?RUlHejJQVmNTMTVBTWF3c2ljTm5JNTN5c01ITGhhZUhENWUwRENXUzI1ZkVo?= =?utf-8?B?OHgrdnlKY09id0owdUFZalRHQ1hvR3NqUG9ybTB0NXNuSm1od1NHNE1ocWFp?= =?utf-8?B?OGJkS1VjMVBGN2Rhdmx2WlM0aGFKQUEwZUhadnNMamxCekdnV0cvbkNtTVQy?= =?utf-8?B?TkR4VFY2YTI5ODhtTWR6aUZXSzdNajFYZWtNRjdzTVRnTE9xaVhJSDBVK2Jp?= =?utf-8?B?VERYY3pNSW10YkpOOEZib0lIaUNLcU9QbHoxMXRXdjA2R2o3cTJZYnhBR2lY?= =?utf-8?B?aDJLVDlEWFU5aXVvakxKcEI4ZExvM0dHQVB3dml0Nm10SFE0ZENvNGd5TzFp?= =?utf-8?B?eG5aaFVHMVR3dStGamM0SFVDMUk4WERUSTF1bVFodDlLL0NFbmpUamRYdkYw?= =?utf-8?B?K080dGlGWGlvVmUwMGkxVi9jZTVhN3MvM1JlZ2gwZUF5cjB0Q2hGTDdGSEI4?= =?utf-8?B?OGJDbEluODRGNUtWMFZYTFE2bGF2dmh2MU95YTRtN0FDaFI1NGpNSjVUZ0tq?= =?utf-8?B?cG95c285SDRDQTdRcXNjYjE3d2x6WmJXaDBxN202SFhGeDMrUE1HUmpQcjNl?= =?utf-8?B?VFU3Q01FUTMycDlUalgvZ0ZYVlpDNnlsRmhLb3Q0R3hsbWx1c1VRcjRmZzJm?= =?utf-8?B?UWNJVnQ4aDJ3VzAwL3ErU2g5OVFBTUxQWXl5WFAyMzhNRjZMd3NGekdtN25u?= =?utf-8?B?d3RJRUFKT3Vsd1VqRTRpZEF4UzB0djU2RXRNeVpXMWNFRWkwR1p1WWRpN1p2?= =?utf-8?B?NnhIMDYvNnFIZkdMdXlJdnNCcjBkNGF4K1U0ZnQ0dU5BMytIa3ZIeXBhKzFU?= =?utf-8?B?bncrRDk1U2Z1b0xjN3Rkb1NmUG9LNU9UelNaemJ0ajhCSHNTYjJmSkE1V1Fw?= =?utf-8?B?SURNRTNBa05SbTJHUDVkdER5VXgwaFRodlNGbmxLNnlZaklTM092R0NBMTRY?= =?utf-8?B?NmJWbXd2c3ZQbDJDaWdoeXkyaU5BV3VBVEs5WitjeDNLYU9LSHp0YjVLcG14?= =?utf-8?B?TnJzVk9paUQwL3pUM05HOUF2dWNQamR3ang0NkNkVCtpMVJOME1pV2gzWGov?= =?utf-8?B?Rm43NXB4THhvKytRV0F2c1NFcDExYUVXaVZJeStrUTUweWNybUFzK0o4Zlpr?= =?utf-8?B?K3lQS1cwVVVFN0Z5ZDdiMjcwNlVYdmxRdHA2aW9DNTk3Y3ZVSE0vdUl6Y1JM?= =?utf-8?B?Yi96R2RKaEZLeGw0bm5nZWFCM2NoUVhneFMwUXRXSEhNKzljeGFiMHVGbkpM?= =?utf-8?B?ODIzdk1qTVZ6ZnN5U0RmSUVMK3d1dVhUR1M1Z0NMWDNOQWF1a1ZQYzlWWUNY?= =?utf-8?B?d1hjdTczb0dQVU1zMndoeUY5RjJWdUhpdG45TzhTTFJJNUlMcTlDOXIzcUsy?= =?utf-8?B?cFNBcThMdUpIcUw5OFVVMk5QeWhnWlJOdTZUc1pDbG80ckc5Rk5LbzZiSVgv?= =?utf-8?B?NHNDSTlhVGNWSDNBclNNSE45RVc0dmlBRDhpTVJaUEZPY25wdGt2N0tHRGhJ?= =?utf-8?B?YVJ3VFA0SFR2cjVFVVNkNGowTVpkU1hlL2hDYnlsc043RlBWSEtnenVVNWlL?= =?utf-8?B?Y2wzWmo4TG92LzkrOVlrWUFJT2s2TFZxeHJOa0FxcjhiWDd0YWQ0Tkc5SmVx?= =?utf-8?B?UkozWHBxQzJZQnBEN0QyakJ1d1QyRjQrSVkxOFV2QjYxdG11U1NpVFdoT2cx?= =?utf-8?B?M3dqWXJZQXlueit6M09Edmc0bGt6ejJhSm5SKys1WnJwWFcxWjIrOGF1Vm5I?= =?utf-8?B?TXpLajNLOFhGS051c3Rtdz09?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8120a6c7-a4cc-4739-9046-08d8e56a2cad X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2021 15:19:04.7331 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tCG3/Ynd1lO8EGc3IQCe2Y3ejLCyYvs01XjGSowoZxAno0N8EH2Yf9IFhvZLldGv6hshIzRkG7sfryMnnWTzCKnlr2jJa3dwSDjmYWv2cDY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5927 X-OriginatorOrg: citrix.com DQoNCj4gT24gTWFyIDEyLCAyMDIxLCBhdCAyOjMyIFBNLCBHZW9yZ2UgRHVubGFwIDxnZW9yZ2Uu ZHVubGFwQGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gDQo+IA0KPj4gT24gRmViIDE2LCAyMDIx LCBhdCAzOjI5IFBNLCBKYW4gQmV1bGljaCA8SkJldWxpY2hAc3VzZS5jb20+IHdyb3RlOg0KPj4g DQo+PiBPbiAxNi4wMi4yMDIxIDExOjI4LCBHZW9yZ2UgRHVubGFwIHdyb3RlOg0KPj4+IC0tLSAv ZGV2L251bGwNCj4+PiArKysgYi9kb2NzL2h5cGVydmlzb3ItZ3VpZGUvbWVtb3J5LWFsbG9jYXRp b24tZnVuY3Rpb25zLnJzdA0KPj4+IEBAIC0wLDAgKzEsMTE4IEBADQo+Pj4gKy4uIFNQRFgtTGlj ZW5zZS1JZGVudGlmaWVyOiBDQy1CWS00LjANCj4+PiArDQo+Pj4gK1hlbmhlYXAgbWVtb3J5IGFs bG9jYXRpb24gZnVuY3Rpb25zDQo+Pj4gKz09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09DQo+Pj4gKw0KPj4+ICtJbiBnZW5lcmFsIFhlbiBjb250YWlucyB0d28gcG9vbHMgKG9yICJo ZWFwcyIpIG9mIG1lbW9yeTogdGhlICp4ZW4NCj4+PiAraGVhcCogYW5kIHRoZSAqZG9tIGhlYXAq LiAgUGxlYXNlIHNlZSB0aGUgY29tbWVudCBhdCB0aGUgdG9wIG9mDQo+Pj4gK2BgeGVuL2NvbW1v bi9wYWdlX2FsbG9jLmNgYCBmb3IgdGhlIGNhbm9uaWNhbCBleHBsYW5hdGlvbi4NCj4+PiArDQo+ Pj4gK1RoaXMgZG9jdW1lbnQgZGVzY3JpYmVzIHRoZSB2YXJpb3VzIGZ1bmN0aW9ucyBhdmFpbGFi bGUgdG8gYWxsb2NhdGUNCj4+PiArbWVtb3J5IGZyb20gdGhlIHhlbiBoZWFwOiB0aGVpciBwcm9w ZXJ0aWVzIGFuZCBydWxlcyBmb3Igd2hlbiB0aGV5IHNob3VsZCBiZQ0KPj4+ICt1c2VkLg0KPj4g DQo+PiBJcnJlc3BlY3RpdmUgb2YgeW91ciBzdWJzZXF1ZW50IGluZGljYXRpb24gb2YgeW91IGRp c2xpa2luZyB0aGUNCj4+IHByb3Bvc2FsICh3aGljaCBJIHVuZGVyc3RhbmQgb25seSBhZmZlY3Rz IHRoZSBndWlkZWxpbmVzIGZ1cnRoZXINCj4+IGRvd24gYW55d2F5KSBJJ2QgbGlrZSB0byBwb2lu dCBvdXQgdGhhdCB2bWFsbG9jKCkgZG9lcyBub3QNCj4+IGFsbG9jYXRlIGZyb20gdGhlIFhlbiBo ZWFwLiBUaGVyZWZvcmUgYSBiZW5lZml0IG9mIGFsd2F5cw0KPj4gcmVjb21tZW5kaW5nIHVzZSBv ZiB4dm1hbGxvYygpIHdvdWxkIGJlIHRoYXQgdGhlIGZ1bmN0aW9uIGNvdWxkDQo+PiBmYWxsIGJh Y2sgdG8gdm1hbGxvYygpIChhbmQgaGVuY2UgdGhlIGxhcmdlciBkb21haW4gaGVhcCkgd2hlbg0K Pj4geG1hbGxvYygpIGZhaWxlZC4NCj4gDQo+IE9LLCB0aGF04oCZcyBnb29kIHRvIGtub3cuDQo+ IA0KPiBTbyBqdXN0IHRyeWluZyB0byB0aGluayB0aGlzIHRocm91Z2g6IGFkZHJlc3Mgc3BhY2Ug aXMgbGltaXRpbmcgZmFjdG9yIGZvciBob3cgYmlnIHRoZSB4ZW5oZWFwIGNhbiBiZSwgcmlnaHQ/ ICBQcmVzdW1hYmx5IOKAnHZtYXDigJ0gc3BhY2UgaXMgYWxzbyBsaW1pdGVkLCBhbmQgd2lsbCBi ZSBtdWNoIHNtYWxsZXI/ICBTbyBpbiBhIHNlbnNlIHRoZSDigJxmYWxsYmFja+KAnSBpcyBsZXNz IGFib3V0IGdldHRpbmcgbW9yZSBtZW1vcnksIGJ1dCBhYm91dCB1c2luZyB1cCB0aGF0IGV4dHJh IGxpdHRsZSBiaXQgb2YgdmlydHVhbCBhZGRyZXNzIHNwYWNlPw0KPiANCj4gQW5vdGhlciBxdWVz dGlvbiB0aGF0IHJhaXNlczogIEFyZSB0aGVyZSB0aW1lcyB3aGVuIGl04oCZcyBhZHZhbnRhZ2Vv dXMgdG8gc3BlY2lmeSB3aGljaCBoZWFwIHRvIGFsbG9jYXRlIGZyb20/ICBJZiB0aGVyZSBhcmUg Z29vZCByZWFzb25zIGZvciBhbGxvY2F0aW9ucyB0byBiZSBpbiB0aGUgeGVuaGVhcCBvciBpbiB0 aGUgZG9taGVhcCAvIHZtYXAgYXJlYSwgdGhlbiB0aGUgZ3VpZGVsaW5lcyBzaG91bGQgcHJvYmFi bHkgc2F5IHRoYXQgYXMgd2VsbC4NCj4gDQo+IEFuZCwgb2YgY291cnNlLCB3aWxsIHRoZSB3aG9s ZSBjb25jZXB0IG9mIHRoZSB4ZW5oZWFwIC8gZG9taGVhcCBzcGxpdCBnbyBhd2F5IGlmIHdlIGV2 ZXIgZ2V0IHJpZCBvZiB0aGUgMToxIG1hcD8NCj4gDQo+PiANCj4+PiArVExEUiBndWlkZWxpbmVz DQo+Pj4gKy0tLS0tLS0tLS0tLS0tLQ0KPj4+ICsNCj4+PiArKiBCeSBkZWZhdWx0LCBgYHh2bWFs bG9jYGAgKG9yIGl0cyBoZWxwZXIgY29nbmF0ZXMpIHNob3VsZCBiZSB1c2VkDQo+Pj4gKyAgdW5s ZXNzIHlvdSBrbm93IHlvdSBoYXZlIHNwZWNpZmljIHByb3BlcnRpZXMgdGhhdCBuZWVkIHRvIGJl IG1ldC4NCj4+PiArDQo+Pj4gKyogSWYgeW91IG5lZWQgbWVtb3J5IHdoaWNoIG5lZWRzIHRvIGJl IHBoeXNpY2FsbHkgY29udGlndW91cywgYW5kIG1heQ0KPj4+ICsgIGJlIGxhcmdlciB0aGFuIGBg UEFHRV9TSVpFYGAuLi4NCj4+PiArICANCj4+PiArICAtIC4uLmFuZCBpcyBvcmRlciAyLCB1c2Ug YGBhbGxvY194ZW5oZWFwX3BhZ2VzYGAuDQo+Pj4gKyAgICANCj4+PiArICAtIC4uLmFuZCBpcyBu b3Qgb3JkZXIgMiwgdXNlIGBgeG1hbGxvY2BgIChvciBpdHMgaGVscGVyIGNvZ25hdGVzKS4uDQo+ PiANCj4+IElUWU0gImFuIGV4YWN0IHBvd2VyIG9mIDIgbnVtYmVyIG9mIHBhZ2VzIj8NCj4gDQo+ IFllcywgSeKAmWxsIGZpeCB0aGF0Lg0KPiANCj4+IA0KPj4+ICsqIElmIHlvdSBkb24ndCBuZWVk IG1lbW9yeSB0byBiZSBwaHlzaWNhbGx5IGNvbnRpZ3VvdXMsIGFuZCBrbm93IHRoZQ0KPj4+ICsg IGFsbG9jYXRpb24gd2lsbCBhbHdheXMgYmUgbGFyZ2VyIHRoYW4gYGBQQUdFX1NJWkVgYCwgeW91 IG1heSB1c2UNCj4+PiArICBgYHZtYWxsb2NgYCAob3Igb25lIG9mIGl0cyBoZWxwZXIgY29nbmF0 ZXMpLg0KPj4+ICsNCj4+PiArKiBJZiB5b3Uga25vdyB0aGF0IGFsbG9jYXRpb24gd2lsbCBhbHdh eXMgYmUgbGVzcyB0aGFuIGBgUEFHRV9TSVpFYGAsDQo+Pj4gKyAgeW91IG1heSB1c2UgYGB4bWFs bG9jYGAuDQo+PiANCj4+IEFzIHBlciBKdWxpZW4ncyBhbmQgeW91ciBvd24gcmVwbGllcywgdGhp cyB3YW50cyB0byBiZSAibWluaW11bQ0KPj4gcG9zc2libGUgcGFnZSBzaXplIiwgd2hpY2ggb2Yg Y291cnNlIGRlcGVuZHMgb24gd2hlcmUgaW4gdGhlDQo+PiB0cmVlIHRoZSBwaWVjZSBvZiBjb2Rl IGlzIHRvIGxpdmUuIChJdCB3b3VsZCBiZSAibWF4aW11bQ0KPj4gcG9zc2libGUgcGFnZSBzaXpl IiBpbiB0aGUgZWFybGllciBwYXJhZ3JhcGguKQ0KPiANCj4gSeKAmWxsIHNlZSBpZiBJIGNhbiBj bGFyaWZ5IHRoaXMuDQoNCkkgdGhpbmsgdGhlIG9ubHkgd2F5IHRvIGFjdHVhbGx5IG1ha2UgdGhp cyBjbGVhciB3b3VsZCBiZSB0byBzZXQgc3BlY2lmaWMgdmFsdWVzIGZvciDigJxtaW5pbXVtIHBv c3NpYmxlIFBBR0VfU0laReKAnSBhbmQg4oCcbWF4aW11bSBwb3NzaWJsZSBQQUdFX1NJWkXigJ0g 4oCUIHZhbHVlcyBwYXN0IHdoaWNoIHRoZSBtYWludGFpbmVycyBvZiB0aGUgYXJjaGl0ZWN0dXJl IGFyZSBoYXBweSB0byBkbyBzb21lIHNvcnQgb2YgYXVkaXQgaWYgUEFHRV9TSVpFIGV2ZXIgZXhj ZWVkcyB0aGVtLg0KDQogLUdlb3JnZQ0KDQo= From xen-devel-bounces@lists.xenproject.org Fri Mar 12 15:25:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 15:25:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97194.184493 (Exim 4.92) (envelope-from ) id 1lKjew-0007S5-Iz; Fri, 12 Mar 2021 15:25:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97194.184493; Fri, 12 Mar 2021 15:25:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKjew-0007Ry-F1; Fri, 12 Mar 2021 15:25:02 +0000 Received: by outflank-mailman (input) for mailman id 97194; Fri, 12 Mar 2021 15:25:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKjev-0007Rt-94 for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 15:25:01 +0000 Received: from out2-smtp.messagingengine.com (unknown [66.111.4.26]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 787a0a92-413d-47e1-b028-8d1a64ee8e12; Fri, 12 Mar 2021 15:25:00 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 48CEB5C0101; Fri, 12 Mar 2021 10:25:00 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 12 Mar 2021 10:25:00 -0500 Received: from mail-itl (ip5b434f04.dynamic.kabel-deutschland.de [91.67.79.4]) by mail.messagingengine.com (Postfix) with ESMTPA id 12F62108005F; Fri, 12 Mar 2021 10:24:57 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 787a0a92-413d-47e1-b028-8d1a64ee8e12 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=xzg0Ty omI36gh5b53iHyS/0ykRdT0c907OhwYFupXHA=; b=s56Xkd0ejuxPaprQj9//7z GONr5jM9uepxrcz+x3W9YmhxOZzupG+m3g3ZzryaFL+6XXKBqIThlYJPsAzyoHvY KiC+XOVhtzxBiXvOXKBUrlvZMHWGetnZeD5ouUtiLTYvXyck6UEx8hi1HR3G6JGR g3wcETgub75fIdEaVSi8MsjwSs6HcDZZb4UCEZse0prosJ39ggGS9abuvuGyjJXe KX1d/FSHWyRWl0aD+xhwvufjTYybYs8QC56NjF6JYK+Q9hg6JVDv8PjZa+tifzfL sxA+6CTZfjt9ubKJaiwxHbxn1nKf4yP9MKhLJ3TVG2pnyCJ3OoLZqhYV01DKy+xQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddvvddgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucfkpheple durdeijedrjeelrdegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg homh X-ME-Proxy: Date: Fri, 12 Mar 2021 16:24:53 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Bob Eshleman Cc: Xen-devel , Andrew Cooper , George Dunlap , piotr.krol@3mdeb.com, Olivier Lambert , Trammell Hudson Subject: Re: Working Group for Secure Boot Message-ID: References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/yH1B15JiJxZxna/" Content-Disposition: inline In-Reply-To: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> --/yH1B15JiJxZxna/ Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 12 Mar 2021 16:24:53 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Bob Eshleman Cc: Xen-devel , Andrew Cooper , George Dunlap , piotr.krol@3mdeb.com, Olivier Lambert , Trammell Hudson Subject: Re: Working Group for Secure Boot On Thu, Mar 11, 2021 at 10:34:02AM -0800, Bob Eshleman wrote: > Hey all, >=20 > We would like to start a working group for secure boot support in Xen > to coordinate the various interested parties and set out a plan for > the feature and its implications for the whole Xen system. >=20 > The end goal is a full implementation that restricts the interfaces > dom0 has to affect Xen, akin to Linux's lockdown LSM. This implicates > important parts of the ABI (e.g., /dev/xen/privcmd/) and so will > require input from the greater community. >=20 > I'm not familiar with how working groups function in the Xen project, > so this email also opens the floor for suggestions as to how this might > be managed. >=20 > We'd love to hear from anyone interested in such a group and how the > community as a whole feels about such an effort. Count me in too. Also, I'm cc-ing Trammell, who might be interested too. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --/yH1B15JiJxZxna/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmBLh8YACgkQ24/THMrX 1yypnwf/dAFTUF0m98AGgQO9xAbLGmP+Vb7Y32jqQyuQavdV9veAh5h/m2IYoYDp eW8mzVWXaRllyEOaqwpZjf4qhb74m2CUU1BjN446LaAQLfPoW8En8YhT0ZiwGjR3 4OR7ZTZUPY40thzCqpeVdQQCILjcGUf1R6HuPK0qiDuOrh4z4NxTRqgigPBEdYrw U2nGFt9xncr5KqTCHFg8wGTm40Ypb4+8M7p1UWz8o/inlLATraIkk9fiXMEndghH odtLRN1tfo7Rs0eoT7zIe48TJW/B/lo+gVqJ+C2JE2cKjwxdx0GIge4s4GYjwdwh r6yhG+mFpC24ZCHYna87EloSUw+cAQ== =Qepr -----END PGP SIGNATURE----- --/yH1B15JiJxZxna/-- From xen-devel-bounces@lists.xenproject.org Fri Mar 12 15:28:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 15:28:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97199.184508 (Exim 4.92) (envelope-from ) id 1lKjiY-0007nv-5N; Fri, 12 Mar 2021 15:28:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97199.184508; Fri, 12 Mar 2021 15:28:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKjiY-0007no-1T; Fri, 12 Mar 2021 15:28:46 +0000 Received: by outflank-mailman (input) for mailman id 97199; Fri, 12 Mar 2021 15:28:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKjiW-0007ng-OF; Fri, 12 Mar 2021 15:28:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKjiW-0002JY-Fm; Fri, 12 Mar 2021 15:28:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKjiW-0006fM-8G; Fri, 12 Mar 2021 15:28:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKjiW-0004sA-7m; Fri, 12 Mar 2021 15:28:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xkDkqtsmvZzefr9b0YAl3t2sxnLmUxXI3W227BOBjJs=; b=3egXYTC/4th/091vkd+0Orh0ev OdQIoboTL/FqV/VaV/h8akoeVtdbCJryTTvvm8GO9fhHJnXbqvk+BasnNqfrKi6SVaZUxcuxrHQkw FvyR8jHOZZIB/TIXQ1XFHJQl7nwR26Dm8Wfh4RzDe5Ed44e1R8lt3fcP/iwWJmylBGSE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 159969: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=2d91b1405d203d45474f341fb69d47ca35aaea0a X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 12 Mar 2021 15:28:44 +0000 flight 159969 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/159969/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 2d91b1405d203d45474f341fb69d47ca35aaea0a baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 245 days Failing since 151818 2020-07-11 04:18:52 Z 244 days 237 attempts Testing same since 159969 2021-03-12 04:18:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 46817 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Mar 12 15:41:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 15:41:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97207.184529 (Exim 4.92) (envelope-from ) id 1lKjuQ-0001CQ-Eg; Fri, 12 Mar 2021 15:41:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97207.184529; Fri, 12 Mar 2021 15:41:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKjuQ-0001CJ-BW; Fri, 12 Mar 2021 15:41:02 +0000 Received: by outflank-mailman (input) for mailman id 97207; Fri, 12 Mar 2021 15:41:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKjuP-0001CE-St for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 15:41:02 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 51fb6761-7839-4c23-8cda-0a20af345df6; Fri, 12 Mar 2021 15:41:00 +0000 (UTC) Received: from [10.10.1.24] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1615563655040773.0532958690712; Fri, 12 Mar 2021 07:40:55 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51fb6761-7839-4c23-8cda-0a20af345df6 ARC-Seal: i=1; a=rsa-sha256; t=1615563658; cv=none; d=zohomail.com; s=zohoarc; b=daQN2bBCxHYHiko7j9A6jSW+rksJv91VxZ1VZAEyYwMoeWMIi4En+znZ8Gi4YdbnYE4j/PO2PLgOPe1YoGm9zqywnEQrC5UBmlSHiuCAVJfHbgiRdPb5LniMUs0CVybl1GJQ7mzmMmB5Ic1NA/0sNy+w3PJXrG0r/z7waWSbxCw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615563658; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=9sc5kpJKzRcEJczYNIdpfGixV50ZE7JUprDPzxxFia8=; b=Ppl1aBuKtyAUeC4DrMc2Bv/P8I3yGAbWkSYvCCV/FsphFRenGPatU5U4qNN9a7wxCFi0Quxjiusia6YqgjHDX+wqYp20MWRSMv7QMWIpMUsrqwz3/toPpQat+grKwxGwZoaEuiG4GLCv86pnzRIhlXyI3hEIP7hYzW18EN2+ft8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1615563658; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Subject:To:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=9sc5kpJKzRcEJczYNIdpfGixV50ZE7JUprDPzxxFia8=; b=q2is3E3XuWISnpp35eCAmWuXRumHGGhwPNSUieNG08SbHH8ZSLwEAzcWK3rd+U1c dIxd9jgQ0XzJleyr1onyUdUFH7+moW3L+ppNQtFFX7zVNaRN47CImjtIYpVNIoW7vfV fJpiFjRmz1M9dG7QrdJuIi/asL459LnMMN+AbZcc= Subject: Re: Working Group for Secure Boot To: Bob Eshleman , Xen-devel References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> From: "Daniel P. Smith" Message-ID: <23821364-c8a2-2fac-97c7-c4f71c9f6424@apertussolutions.com> Date: Fri, 12 Mar 2021 10:40:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 3/11/21 1:34 PM, Bob Eshleman wrote: > Hey all, > > We would like to start a working group for secure boot support in Xen > to coordinate the various interested parties and set out a plan for > the feature and its implications for the whole Xen system. > > The end goal is a full implementation that restricts the interfaces > dom0 has to affect Xen, akin to Linux's lockdown LSM. This implicates > important parts of the ABI (e.g., /dev/xen/privcmd/) and so will > require input from the greater community. > > I'm not familiar with how working groups function in the Xen project, > so this email also opens the floor for suggestions as to how this might > be managed. > > We'd love to hear from anyone interested in such a group and how the > community as a whole feels about such an effort. > > Best regards. > > --- > > Bobby Eshleman > SE at Vates SAS > Yes, please count me in since it will definitely overlap with the work I am doing under DomB/Hyperlaunch as well as planned work under the TrenchBoot project. V/r, Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Fri Mar 12 15:49:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 15:49:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97210.184541 (Exim 4.92) (envelope-from ) id 1lKk2h-0001b6-AT; Fri, 12 Mar 2021 15:49:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97210.184541; Fri, 12 Mar 2021 15:49:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKk2h-0001az-79; Fri, 12 Mar 2021 15:49:35 +0000 Received: by outflank-mailman (input) for mailman id 97210; Fri, 12 Mar 2021 15:49:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKk2g-0001au-4Q for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 15:49:34 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d94ff4cd-1462-4026-9989-73fc7b2d8104; Fri, 12 Mar 2021 15:49:33 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6A45DB123; Fri, 12 Mar 2021 15:49:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d94ff4cd-1462-4026-9989-73fc7b2d8104 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615564172; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8/XB+mDpG3c4DHIZyhXeJDdEhhLiKHV+nd4VlhMdsPQ=; b=lvCaN30LK5uJ1G+bP4fEb84GR1PaoeLZYKZCIRmQUJhszTadPEsBE5VRHN5fZpBwLT3Gz5 +iDXGfe23dlCIlFsn5yTp0ihlA1SVLF0dJpuK/Fl6Vjch32XMzg9F0IxjxRfwSg6auOyP7 7SFBKu0wMGa3uFq/DDplV93KJQaI6+I= Subject: Re: [PATCH] xen: fix for_each_cpu when NR_CPUS=1 To: Ian Jackson Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Dario Faggioli References: <161545564302.24868.14477928469038686899.stgit@Wayrath> <24651.29866.263648.422601@mariner.uk.xensource.com> From: Jan Beulich Message-ID: Date: Fri, 12 Mar 2021 16:49:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24651.29866.263648.422601@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12.03.2021 15:03, Ian Jackson wrote: > Dario Faggioli writes ("[PATCH] xen: fix for_each_cpu when NR_CPUS=1"): >> -#if NR_CPUS > 1 >> #define for_each_cpu(cpu, mask) \ >> for ((cpu) = cpumask_first(mask); \ > > Just a thought: does cpumask_first work on an empty mask ? I'm sure it does, yes - it'll return a value >= nr_cpu_ids in this case. If it didn't work, NR_CPUS > 1 would also be badly affected. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 15:59:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 15:59:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97215.184559 (Exim 4.92) (envelope-from ) id 1lKkBq-0002iA-Cn; Fri, 12 Mar 2021 15:59:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97215.184559; Fri, 12 Mar 2021 15:59:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkBq-0002i3-9B; Fri, 12 Mar 2021 15:59:02 +0000 Received: by outflank-mailman (input) for mailman id 97215; Fri, 12 Mar 2021 15:59:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkBp-0002hy-5B for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 15:59:01 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c9a85205-d6d9-45fe-8c28-43b7ec5d9819; Fri, 12 Mar 2021 15:59:00 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 77C1BB126; Fri, 12 Mar 2021 15:58:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9a85205-d6d9-45fe-8c28-43b7ec5d9819 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615564739; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g1sysbFB17Or6V00qOcCRJOBVe83PeMncfFsr7otsfY=; b=JclNHvwAoTVVbEJ30F5fNVBzQS8RMxrGTEIiK149snnftKdqghSv1oFOX87IWCFKiwA6eM hLmyiB7rjlDOXKKdQXUwxoTwUaBKiS94O2l2zM/i+l4NMHKy3lTNy6zmzR2kjUMkY+Tr+X HSnYn8ELoNAyvnmmimwKPqK30Let780= Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning To: Ian Jackson Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" , Julien Grall References: <6bd14438-7dec-2176-eab5-5898f190c4d8@suse.com> <24651.15544.142804.468744@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <46176065-8ae3-cb42-f031-aad12512d29e@suse.com> Date: Fri, 12 Mar 2021 16:59:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24651.15544.142804.468744@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12.03.2021 11:04, Ian Jackson wrote: > Julien Grall writes ("Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning"): >> This is pretty much what we are already doing slowly by initializing >> values to shut up older compilers. I agree this is more limited, but we >> also waive off diagnostics from every single compiler in that code >> rather than just one version. >> >> Hence why I suggested dropping -Werror for older compiler. This is not >> ideal but it would give us the ability to keep support for dinausor >> compiler and not hamper our ability to take advantage of newer compiler >> diagnostics. > > I agree with Julien. I think we should avoid adding these redundant > initialisers for the reasons he gives. > >> The ideal solution is to drop support for older compiler (see my other >> thread). But this sounds like a daunting task so far on x86... >> >> Anyway, I will not Nack the patch but will also not Ack it. I will let >> another maintainer ack this patch. > > But this is outside my usual area so I won't nack it either. But would you be willing to release-ack v2? Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 16:07:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 16:07:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97221.184574 (Exim 4.92) (envelope-from ) id 1lKkKQ-0004Cu-Fu; Fri, 12 Mar 2021 16:07:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97221.184574; Fri, 12 Mar 2021 16:07:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkKQ-0004Cn-Bn; Fri, 12 Mar 2021 16:07:54 +0000 Received: by outflank-mailman (input) for mailman id 97221; Fri, 12 Mar 2021 16:07:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkKQ-0004Ci-0w for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 16:07:54 +0000 Received: from mail-wm1-f50.google.com (unknown [209.85.128.50]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ef272010-d3ea-4c63-93bb-2af6429bf253; Fri, 12 Mar 2021 16:07:53 +0000 (UTC) Received: by mail-wm1-f50.google.com with SMTP id f22-20020a7bc8d60000b029010c024a1407so16131708wml.2 for ; Fri, 12 Mar 2021 08:07:52 -0800 (PST) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id p10sm8878572wrw.33.2021.03.12.08.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 08:07:51 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef272010-d3ea-4c63-93bb-2af6429bf253 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MdjxVRrc/l98n2mp6JR4TkBMyjSKA6nlXDWOt3C5Q8s=; b=GOAx4FIWZh22L42dow1qXdNmOtP3j51My+2pjABcwdOhUeYHZ7cGdv8Q5QixPoGunA C/vghQyQL2Qt7ikR41F38z8+EV3Odi62O6k9h0FlQCZqOsmmrZ4OEHQzUMlBZm4VKv9d hKhGDxJ1cyuOUnWaCZGZIwfuUtv+W6SELk4z1L8jIpovp9/1m+n+MfoGFBFIHK98VAtg 7JDngtxGXErrRoQGz2Ru/7RYDOBHVUdpaCVIUi35Yra3SWtMUJT6YfTKh8SnE1Bg8ijI kPaP0yUI5vNnvnuJZUdbM+7mtHY733oL3rmZ4vPHg4AMuwkH+eynOyy2tp7tRB6iWgx5 Uqig== X-Gm-Message-State: AOAM531UHuazRRki0Hrv3CpCuNr7sRhz6HEHGGgu5Jpke+WV3c79o1Fy IGvf/HuWa0csv06kj9xIiY4= X-Google-Smtp-Source: ABdhPJyohJMj1WYxSKUaxIdSpjYuwHBpeu+D8eSB3iDBJnFzzMJKmT0Lzx2BvXnCzCQILIXEmpH1/A== X-Received: by 2002:a1c:dd89:: with SMTP id u131mr13504620wmg.54.1615565272215; Fri, 12 Mar 2021 08:07:52 -0800 (PST) Date: Fri, 12 Mar 2021 16:07:50 +0000 From: Wei Liu To: Stefano Stabellini Cc: cardoe@cardoe.com, andrew.cooper3@citrix.com, wl@xen.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Ian Jackson Subject: Re: [PATCH] automation: add arm32 cross-build tests for Xen Message-ID: <20210312160750.svw4ls76z6yli3yb@liuwe-devbox-debian-v2> References: <20210213013813.30114-1-sstabellini@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210213013813.30114-1-sstabellini@kernel.org> On Fri, Feb 12, 2021 at 05:38:13PM -0800, Stefano Stabellini wrote: > Add a debian build container with cross-gcc for arm32 installed. > Add build jobs to cross-compile Xen-only for arm32. > > Signed-off-by: Stefano Stabellini Acked-by: Wei Liu Cc Ian. The risk is small: Gitlab CI doesn't gate pushes to Xen, but it is rather beneficial to have arm32 builds for Xen. > --- > .../debian/unstable-arm32-gcc.dockerfile | 24 +++++++++ > automation/gitlab-ci/build.yaml | 50 +++++++++++++++++++ > automation/scripts/build | 9 ++++ > 3 files changed, 83 insertions(+) > create mode 100644 automation/build/debian/unstable-arm32-gcc.dockerfile > > diff --git a/automation/build/debian/unstable-arm32-gcc.dockerfile b/automation/build/debian/unstable-arm32-gcc.dockerfile > new file mode 100644 > index 0000000000..b41a57f197 > --- /dev/null > +++ b/automation/build/debian/unstable-arm32-gcc.dockerfile > @@ -0,0 +1,24 @@ > +FROM debian:unstable > +LABEL maintainer.name="The Xen Project" \ > + maintainer.email="xen-devel@lists.xenproject.org" > + > +ENV DEBIAN_FRONTEND=noninteractive > +ENV USER root > +ENV CROSS_COMPILE /usr/bin/arm-linux-gnueabihf- > + > +RUN mkdir /build > +WORKDIR /build > + > +# build depends > +RUN apt-get update && \ > + apt-get --quiet --yes install \ > + build-essential \ > + flex \ > + bison \ > + git \ > + gcc-arm-linux-gnueabihf \ > + && \ > + apt-get autoremove -y && \ > + apt-get clean && \ > + rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* > + > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index d00b8a5123..22114662f2 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -117,6 +117,33 @@ > variables: > <<: *clang > > +.arm32-cross-build-tmpl: > + <<: *build > + variables: > + XEN_TARGET_ARCH: arm32 > + tags: > + - x86_64 > + > +.arm32-cross-build: > + extends: .arm32-cross-build-tmpl > + variables: > + debug: n > + > +.arm32-cross-build-debug: > + extends: .arm32-cross-build-tmpl > + variables: > + debug: y > + > +.gcc-arm32-cross-build: > + extends: .arm32-cross-build > + variables: > + <<: *gcc > + > +.gcc-arm32-cross-build-debug: > + extends: .arm32-cross-build-debug > + variables: > + <<: *gcc > + > .arm64-build-tmpl: > <<: *build > variables: > @@ -454,6 +481,29 @@ alpine-3.12-clang-debug: > CONTAINER: alpine:3.12 > allow_failure: true > > +# Arm32 cross-build > + > +debian-unstable-gcc-arm32: > + extends: .gcc-arm32-cross-build > + variables: > + CONTAINER: debian:unstable-arm32-gcc > + > +debian-unstable-gcc-arm32-debug: > + extends: .gcc-arm32-cross-build-debug > + variables: > + CONTAINER: debian:unstable-arm32-gcc > + > +debian-unstable-gcc-arm32-randconfig: > + extends: .gcc-arm32-cross-build > + variables: > + CONTAINER: debian:unstable-arm32-gcc > + RANDCONFIG: y > + > +debian-unstable-gcc-arm32-debug-randconfig: > + extends: .gcc-arm32-cross-build-debug > + variables: > + CONTAINER: debian:unstable-arm32-gcc > + RANDCONFIG: y > > # Arm builds > > diff --git a/automation/scripts/build b/automation/scripts/build > index d8990c3bf4..e7d68f7a9d 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -15,6 +15,15 @@ else > make -j$(nproc) -C xen defconfig > fi > > +# arm32 only cross-compiles the hypervisor > +if [[ "${XEN_TARGET_ARCH}" = "arm32" ]]; then > + make -j$(nproc) xen > + cp xen/.config xen-config > + mkdir binaries > + cp xen/xen binaries/xen > + exit 0 > +fi > + > # build up our configure options > cfgargs=() > cfgargs+=("--enable-docs") > -- > 2.17.1 > From xen-devel-bounces@lists.xenproject.org Fri Mar 12 16:15:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 16:15:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97228.184600 (Exim 4.92) (envelope-from ) id 1lKkRo-0005Hu-Ep; Fri, 12 Mar 2021 16:15:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97228.184600; Fri, 12 Mar 2021 16:15:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkRo-0005Hn-Bg; Fri, 12 Mar 2021 16:15:32 +0000 Received: by outflank-mailman (input) for mailman id 97228; Fri, 12 Mar 2021 16:15:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkRn-0005Hi-Ji for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 16:15:31 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f9027e64-dd70-40c4-87b5-f82e55ba734e; Fri, 12 Mar 2021 16:15:30 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 91D4DB124; Fri, 12 Mar 2021 16:15:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9027e64-dd70-40c4-87b5-f82e55ba734e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615565729; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ptNN89Tr4Hseul/yPniugb6TyK0HibSDrG8wIPcmymI=; b=Rbav+Ity4tBaDZ3DZ5iCbTMU8c/CfRCNvHvqEQU3b0v4YXwd5q8i6yEfl56Uy/jr9pyi2A W3elV1+h0kA/h3awCO9kLbKS1rwtJLaPPRBs+/CwS9SxuOHDvH2guHwyZe0OGRKHTnphoN f4JEm/e55xBf0IZIeaLK4N1pj9nFbcM= Subject: Re: [PATCH DO NOT APPLY] docs: Document allocator properties and the rubric for using them To: George Dunlap Cc: Andrew Cooper , Roger Pau Monne , Stefano Stabellini , Julien Grall , "xen-devel@lists.xenproject.org" References: <20210216102839.1801667-1-george.dunlap@citrix.com> <63895FAD-B848-461D-8A31-E6C9973B6726@citrix.com> From: Jan Beulich Message-ID: <1391dbd2-2839-67f9-0570-a466cadacc63@suse.com> Date: Fri, 12 Mar 2021 17:15:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <63895FAD-B848-461D-8A31-E6C9973B6726@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 12.03.2021 15:32, George Dunlap wrote: >> On Feb 16, 2021, at 3:29 PM, Jan Beulich wrote: >> On 16.02.2021 11:28, George Dunlap wrote: >>> --- /dev/null >>> +++ b/docs/hypervisor-guide/memory-allocation-functions.rst >>> @@ -0,0 +1,118 @@ >>> +.. SPDX-License-Identifier: CC-BY-4.0 >>> + >>> +Xenheap memory allocation functions >>> +=================================== >>> + >>> +In general Xen contains two pools (or "heaps") of memory: the *xen >>> +heap* and the *dom heap*. Please see the comment at the top of >>> +``xen/common/page_alloc.c`` for the canonical explanation. >>> + >>> +This document describes the various functions available to allocate >>> +memory from the xen heap: their properties and rules for when they should be >>> +used. >> >> Irrespective of your subsequent indication of you disliking the >> proposal (which I understand only affects the guidelines further >> down anyway) I'd like to point out that vmalloc() does not >> allocate from the Xen heap. Therefore a benefit of always >> recommending use of xvmalloc() would be that the function could >> fall back to vmalloc() (and hence the larger domain heap) when >> xmalloc() failed. > > OK, that’s good to know. > > So just trying to think this through: address space is limiting factor for how big the xenheap can be, right? Yes, with the current direct-map model only memory which has a permanent mapping can be "Xen heap". Obviously, for the mapping to be permanent, its VA range needs to be set up front (at build time in reality). FAOD the distinction (at least on x86) matters only on systems with a lot of memory. > Presumably “vmap” space is also limited, and will be much smaller? Yes and yes, albeit for the 2nd one I'd like to add "currently", because once we do away with the direct map, I'd envision to use all the VA space for such on-demand mapping purposes. > So in a sense the “fallback” is less about getting more memory, > but about using up that extra little bit of virtual address space? Not really, no. If no memory is left on the Xen heap, there may still be some left on the domain heap. Falling back could also be the other way around, yes - if we've run out of vmalloc() address space, we may still have a chance find the requested space in the Xen heap. > Another question that raises: Are there times when it’s > advantageous to specify which heap to allocate from? If there > are good reasons for allocations to be in the xenheap or in the > domheap / vmap area, then the guidelines should probably say > that as well. I can't think of such reasons (beyond ones already named, like e.g. wanting to avoid mapping overhead), but I agree that if there are any, mentioning them would be desirable. > And, of course, will the whole concept of the xenheap / domheap > split go away if we ever get rid of the 1:1 map? I expect so, yes. >>> +Properties of various allocation functions >>> +------------------------------------------ >>> + >>> +Ultimately, the underlying allocator for all of these functions is >>> +``alloc_xenheap_pages``. They differ on several different properties: >>> + >>> +1. What underlying allocation sizes are. This in turn has an effect >>> + on: >>> + >>> + - How much memory is wasted when requested size doesn't match >>> + >>> + - How such allocations are affected by memory fragmentation >>> + >>> + - How such allocations affect memory fragmentation >>> + >>> +2. Whether the underlying pages are physically contiguous >>> + >>> +3. Whether allocation and deallocation require the cost of mapping and >>> + unmapping >>> + >>> +``alloc_xenheap_pages`` will allocate a physically contiguous set of >>> +pages on orders of 2. No mapping or unmapping is done. >> >> That's the case today, but meant to change rather sooner than later >> (when the 1:1 map disappears). > > Is that the kind of thing we want to add into this document? Not sure what to answer here - my intention with raising the point was ... > I suppose it would be good to make the guidelines now such > that they produce code which is as easy as possible to adapt > to the new way of doing things. ... precisely this. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 16:25:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 16:25:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97232.184615 (Exim 4.92) (envelope-from ) id 1lKkaz-0006Or-EG; Fri, 12 Mar 2021 16:25:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97232.184615; Fri, 12 Mar 2021 16:25:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkaz-0006Ok-Aw; Fri, 12 Mar 2021 16:25:01 +0000 Received: by outflank-mailman (input) for mailman id 97232; Fri, 12 Mar 2021 16:24:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkax-0006Of-LP for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 16:24:59 +0000 Received: from mail-40134.protonmail.ch (unknown [185.70.40.134]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6ff54ed3-e586-44a1-be7b-be209a467974; Fri, 12 Mar 2021 16:24:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ff54ed3-e586-44a1-be7b-be209a467974 Date: Fri, 12 Mar 2021 16:24:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trmm.net; s=protonmail; t=1615566295; bh=2ACfSekKEsr5YcE6yaI7EpKojSmgULgoHgJcvTn2nn8=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=eEIwNSrAH8GmtmhNXvUNoiQqCV27oeIKODQFsIfftDfeHz31DbRKUbMYiHfpA9n+s 2yInJDjp434cGGvmydRGu7aPXsnPJFFd8fHnQOyEtM32+WqFaV+mm8zI8GYIaejbmC RVDCN4Hbm0JsmH5+WGoN5bXgwfL4oCXdtCa3i5xQ= To: Marek Marczykowski-G??recki From: Trammell Hudson Cc: Bob Eshleman , Xen-devel , Andrew Cooper , George Dunlap , piotr.krol@3mdeb.com, Olivier Lambert Reply-To: Trammell Hudson Subject: Re: Working Group for Secure Boot Message-ID: In-Reply-To: References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch On Fri, Mar 12, 2021 at 04:24:53PM +0100, Marek Marczykowski-G??recki wrote= : > On Thu, Mar 11, 2021 at 10:34:02AM -0800, Bob Eshleman wrote: > > We would like to start a working group for secure boot support in Xen > > to coordinate the various interested parties and set out a plan for > > the feature and its implications for the whole Xen system. > [...] > > We'd love to hear from anyone interested in such a group and how the > > community as a whole feels about such an effort. >=20 > Count me in too. >=20 > Also, I'm cc-ing Trammell, who might be interested too. Thanks for the invite, Marek. I'm also interested in discussing how to lockdown a running Xen system. Now that the unified EFI image patches have been merged, we can boot with a little more integrity and hopefully transfer the chain of trust to a trustworthy system. --=20 Trammell From xen-devel-bounces@lists.xenproject.org Fri Mar 12 16:30:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 16:30:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97237.184630 (Exim 4.92) (envelope-from ) id 1lKkg2-0007Ti-5A; Fri, 12 Mar 2021 16:30:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97237.184630; Fri, 12 Mar 2021 16:30:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkg2-0007Tb-1j; Fri, 12 Mar 2021 16:30:14 +0000 Received: by outflank-mailman (input) for mailman id 97237; Fri, 12 Mar 2021 16:30:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkg0-0007TW-30 for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 16:30:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkfz-0003t3-VU for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 16:30:11 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lKkfz-00017v-QI for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 16:30:11 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lKkfq-0004PV-BQ; Fri, 12 Mar 2021 16:30:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=11VfRNUtWbl28Ty/YLVizfM8Yp/Q6vEhy6Izlmh3BfU=; b=BTp9kcuvztufkfFs3EHs+YMeWE mZmccxoJFZen8yE9DWVHI7uh6zzUrjAE+0nNkeg/xjnLa3xm2B9epyrh/PhJR8Wfhm+XdwYvkWD/6 y9HQdNQVb8O51zcUB8lHOovSzvFCcsiO2lPxoJIUlthF9G5Kqd0bpwsvOeMFFGCk9SGI=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24651.38665.981069.53322@mariner.uk.xensource.com> Date: Fri, 12 Mar 2021 16:30:01 +0000 To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel\@lists.xenproject.org" , Julien Grall Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning In-Reply-To: <46176065-8ae3-cb42-f031-aad12512d29e@suse.com> References: <6bd14438-7dec-2176-eab5-5898f190c4d8@suse.com> <24651.15544.142804.468744@mariner.uk.xensource.com> <46176065-8ae3-cb42-f031-aad12512d29e@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning"): > On 12.03.2021 11:04, Ian Jackson wrote: > > But this is outside my usual area so I won't nack it either. > > But would you be willing to release-ack v2? Good question. I don't think my code quality/style qualms etc. have any bearing on the release question. So, I will do that now: Release-Acked-by: Ian Jackson Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 12 16:50:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 16:50:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97243.184652 (Exim 4.92) (envelope-from ) id 1lKkzL-0001Ai-V0; Fri, 12 Mar 2021 16:50:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97243.184652; Fri, 12 Mar 2021 16:50:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkzL-0001Ab-Rs; Fri, 12 Mar 2021 16:50:11 +0000 Received: by outflank-mailman (input) for mailman id 97243; Fri, 12 Mar 2021 16:50:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkzK-0001AW-Aa for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 16:50:10 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cfdeb2b2-ce53-4633-b7a2-758ae8234b04; Fri, 12 Mar 2021 16:50:09 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5311EAF6C; Fri, 12 Mar 2021 16:50:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfdeb2b2-ce53-4633-b7a2-758ae8234b04 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615567808; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MmGPfV8DwHMB3Z9ZDZqRR5s22asV4IuA5dkHojkwLiI=; b=ssjRyOHivjERsl5WB/JR1yXJAQ7r4nj/wbnRmqAhz4bZ+mgNqLF/oLhDvza9Kx0jLVokhq EFCwujMf6zFyotBXQfwh560Fl9kJQFQCm/mvqNYLiWYTj79WihrsL5GIA5DVjvVoOsbGWt DY83wqVWWOwMkDjBGPvG8V286FZBuCk= From: Jan Beulich Subject: [PATCH v3][4.15] tools/x86: don't rebuild cpuid-autogen.h every time To: "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> Message-ID: <96ad6d6e-84f0-89dd-f7b1-1e1ddc2183fd@suse.com> Date: Fri, 12 Mar 2021 17:50:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit The first thing the "xen-dir" rule does is delete the entire xen/ subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a result there's no original version for $(move-if-changed ...) to compare against, and hence the file and all its consumers would get rebuilt every time. Instead only find and delete all the symlinks. Fixes: eddf9559c977 ("libx86: generate cpuid-autogen.h in the libx86 include dir") Signed-off-by: Jan Beulich --- v3: Don't use xargs. Don't hide errors. v2: Different approach. --- a/tools/include/Makefile +++ b/tools/include/Makefile @@ -19,8 +19,8 @@ xen-foreign: $(MAKE) -C xen-foreign xen-dir: - @rm -rf xen acpi mkdir -p xen/libelf acpi + find xen/ acpi/ -type l -exec rm '{}' + ln -s $(XEN_ROOT)/xen/include/public/COPYING xen/ ln -s $(XEN_ROOT)/xen/include/public/*.h xen/ ln -s $(XEN_ROOT)/xen/include/public/*/ xen/ From xen-devel-bounces@lists.xenproject.org Fri Mar 12 16:59:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 16:59:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97248.184670 (Exim 4.92) (envelope-from ) id 1lKl8D-0001XZ-1I; Fri, 12 Mar 2021 16:59:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97248.184670; Fri, 12 Mar 2021 16:59:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKl8C-0001XS-TU; Fri, 12 Mar 2021 16:59:20 +0000 Received: by outflank-mailman (input) for mailman id 97248; Fri, 12 Mar 2021 16:59:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKl8B-0001XN-QC for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 16:59:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKl8B-0004LM-Hq for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 16:59:19 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lKl8B-0006wU-GG for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 16:59:19 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lKl88-0004Tu-9l; Fri, 12 Mar 2021 16:59:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=zfWf9oJrhq8D+nMBn/uBLGq6NkCmljSjEJDoEmNPBQk=; b=ss5UKMk6i3jqHMwQQEYgcUIhH4 FAO318YZ6SznpCluCfp5XbLhmMI25jTqwRR6jCXF4pfTrHdFmnRTx1JqzqnQCPMZnI2l50WdA4JeE sUldQLn4eWnoCfEXszldQFJIsqP2PySjgUO1D33YpJPgLVaZG7wIu64f/k6Oh3FnIIp4=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24651.40420.34409.269589@mariner.uk.xensource.com> Date: Fri, 12 Mar 2021 16:59:16 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH v3][4.15] tools/x86: don't rebuild cpuid-autogen.h every time In-Reply-To: <96ad6d6e-84f0-89dd-f7b1-1e1ddc2183fd@suse.com> References: <1365013b-1e90-aeb2-3c80-7a5c6284c46a@suse.com> <96ad6d6e-84f0-89dd-f7b1-1e1ddc2183fd@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH v3][4.15] tools/x86: don't rebuild cpuid-autogen.h every time"): > The first thing the "xen-dir" rule does is delete the entire xen/ > subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a > result there's no original version for $(move-if-changed ...) to compare > against, and hence the file and all its consumers would get rebuilt > every time. Instead only find and delete all the symlinks. > > Fixes: eddf9559c977 ("libx86: generate cpuid-autogen.h in the libx86 include dir") > Signed-off-by: Jan Beulich Release-Acked-by: Ian Jackson Reviewed-by: Ian Jackson Thanks! From xen-devel-bounces@lists.xenproject.org Fri Mar 12 17:01:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 17:01:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97251.184682 (Exim 4.92) (envelope-from ) id 1lKlAP-0002Oo-EP; Fri, 12 Mar 2021 17:01:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97251.184682; Fri, 12 Mar 2021 17:01:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKlAP-0002Oh-AX; Fri, 12 Mar 2021 17:01:37 +0000 Received: by outflank-mailman (input) for mailman id 97251; Fri, 12 Mar 2021 17:01:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKlAN-0002Oc-IC for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 17:01:35 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 06094051-43f5-41f4-8075-c535e4242d14; Fri, 12 Mar 2021 17:01:35 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 076E7AF6C; Fri, 12 Mar 2021 17:01:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06094051-43f5-41f4-8075-c535e4242d14 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615568494; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wf69Du+MLgMaQXV+2XCK++U9PYpPw4d/+aVude5uYdM=; b=huou5rQSqy1evNu3jQ4MJllsS6UTjgzrdKb7cae4uj0qXULCeZMrcJ8CrYcYZG4MYGTxiP 8HCyjMLugPmU1uQ0GBmebDrRlUdYxCy9hBqI/9OhpQCCRfQ72Ms+isbWUTrc+HLRqbvjMX Vv8psU267oLe6PGIdEEQnlehyqE847E= Subject: Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build To: Connor Davis Cc: Bobby Eshleman , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , xen-devel@lists.xenproject.org References: <7652ce3486c026a3a9f7d850170ea81ba8a18bdb.1614265718.git.connojdavis@gmail.com> From: Jan Beulich Message-ID: Date: Fri, 12 Mar 2021 18:01:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <7652ce3486c026a3a9f7d850170ea81ba8a18bdb.1614265718.git.connojdavis@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 25.02.2021 16:24, Connor Davis wrote: > --- a/xen/drivers/char/serial.c > +++ b/xen/drivers/char/serial.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include Btw - changes like this one would better be split off, so they would come with a justification / description. A file like this one shouldn't really need to include processor.h, so I'm curious what the requirement is. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 17:06:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 17:06:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97259.184700 (Exim 4.92) (envelope-from ) id 1lKlFF-0002bP-8s; Fri, 12 Mar 2021 17:06:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97259.184700; Fri, 12 Mar 2021 17:06:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKlFF-0002bI-4z; Fri, 12 Mar 2021 17:06:37 +0000 Received: by outflank-mailman (input) for mailman id 97259; Fri, 12 Mar 2021 17:06:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKlFE-0002bD-9k for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 17:06:36 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1a1d3382-75a3-403b-9b29-7982e0b16d79; Fri, 12 Mar 2021 17:06:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a1d3382-75a3-403b-9b29-7982e0b16d79 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615568794; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=RkU5b68NZ01iCsYfUaOdR5r+nzhCfEQQftlPXY4TMg0=; b=bkyS+J7HSe+yk8iOszCnPj8EMTb0dItZT/RrkCycjpnHOPyb6/AnMrBr I29CbQk/vLix3pKcfrgLVnMNky1POTMYKkDA+AwxB8MxOE4jUU6tXXRxU a1FGLvRuzJGVXFsZMF2yUlbu/SpB19ZFXt7VYWIvjGL+5m0yGAtNs/bUX Q=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: gDh6nzH+vkJ0PRgMGkGML0Uae8NB6cr3Vjzv7qUkDZtcdtgZ1K0FO+zoKEi08++lbRuGgGMrOw 9j3TwI7YwLshqvoc3SwpNSVglIotjeZiyGOKSe5X7W5WB/JHRJn+wS4eac7AzyVCJgI8QwLiUN ZVRtD83JWPfnAlsifDA5QhBC9lagwhqEG2VHd7lgBJHrOnlG9fVMwa8fxHd5vt5cUzlW24spHX 4BAP7POYEBu7lIPB2Zfwv10Ozs6Z4bolTSGH5E2defiijz++Jua/4cJLSFDTe6fFLVzrTWyL6K R18= X-SBRS: 5.2 X-MesageID: 39182680 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:WyxUxKuVxTYlttMbp3hIMR8/7skC/YYji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOj7U5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qz6Y 5JSII7MtH5CDFB4frSyBWkEtom3dmM+L2pg+Cb9Ht2UQR2cchbjztRICzzKDwQeCBtA50lGJ 2Aou9OoDS9cXoaB/7LeEUtde7FutHNidbaehYAHREq802jijmv5b78HXGjr2gjehlIxqov9n WArhzh6syYwo2G4zL/90uW1ZRZn9P91sBObfbstuE5Iijh4zzYH7hJdKaFuFkO0ZiSwXYs1O LBuhIxe/l0gkmhA12dhTvI903e3C0163nkoGXo80fLhcDiXjo1B45gqOtiA2PkwnEttt19z6 5Htljx3/E8YGKi7UaNk+TgbB1kmlG5pnAvi4co/hpieLATdaNLqsgn9F5Vea1wbx7S0pwtE+ VlEajnlZNrWG6dBkqp2lVH/MahRTAaEBuAXyE5y7ao+gkTtnV4w0wE/dcYj3cN+bksIqM0l9 jsA+BGkqpDQdQRar84LOAdQdGvAmiIeh7UNnmOSG6XW50vCjbokdra8b817OaldNghy4Yzoo 3IVBd9uXQpc0zjJMWS1PRwg17waVT4eQ6o5tBV5pB/tLG5bqHsKze/RFcnlNbli+kDA+XAMs zDe65+MrvGFy/DCIxJ1wrxV915Mn8FSvAYvd49Rhanvt/LEIv3rebWGcyjZIbFIHIBYCfSE3 EDVD/8KIFr9UawQEL1hxDXRjfDYUr60ZVsELXL3uQaxYQXX7c89zQ9uBCc3IWmODdCuqs5cA 9VO7X8iJ62omGw4CLp4gxSS15gJ3cQxI+lf2JBpAcMPU+xW60Eoc+jdWdb22bCAhd+SsjRAT NOvlgfw9PxE7WggQQZT/63OGOTiHUe4FiQSY0Hp6GF7cD5PrQ1E4ghQ640MQnQDRR6lUJLpQ 54GU45b36aMgmrpbSujZQSCu2aXcJ7mh2XLcldrm+ak16dq8EpTn4yRCWvTsaTvAYrS1Nv9x 9M2p5apIDFtSekKGM5juh9GkZLcn6rDLVPCxnAWJ9ZgYnxeAZ7TX6DgBuTjx1bQButy2wiwk jaaQGEc/DCBVRQ/lRVyLzj/l9PemKBRE5ocXxhvYphFWPJh2Zr3YawF9+O+lrUTmFH7vAWMT nDbzdXGA9oytyt/DO+mTqJFxwdt98TF92YKI5mX6DY23urJoHNqLoPGOVM+o15cPr0tPUQbO 6ZcwiJDT/xBu8zwTaJrnI9NCQckgh8rdrYnDneqE620340DaCMfBBIR7QHL8qd6GahbfCSy5 l9hc80u+z1EmiZUK/x9YjnKxp4bjXUqiqKasttj7Z+l6c7rqFyEJnWSiGg7gAN4DwOaOPP0H oDS6F66o3bMoBhf8YuaztUl2BZ4+inHQ8OiEjKGecwclEmsm/DM/6I67TOr6AzAkfpnnq4BX Cvtwlc9ezCRS2NyPozDL8xO31fbCEHmTlf1dLHU43bEwOxce5fuHK8L3+mabdYDIyIA68ZoB o/w9aGmYasBmbF8TGVmTtwOaRV9Wm7Beu0HQKXAOZNt+WABm7kuNrj3OeDyBHtSTW6bEwEhY pKMWwoB/4z+wUKvckQySi9Sqv+v0Q/tUBRiAsXzmLQ5g== X-IronPort-AV: E=Sophos;i="5.81,244,1610427600"; d="scan'208";a="39182680" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xt3Z2aYzZQNf2zWm1hG/7eBUcRicSGmOICFQn2WA397X91HOYteQVjpyJLNdLpENkDDYUzFZChjrSiXZYca17/4iRn50OhsAJY5i1hLrz3xGmSNQDjWJvUYGlotJvNRi3YmV6G/FdK/uNVd8nJtgvS15g+/2wtPNJphOrTON3z4amVdVoTHPsjf0JEy782AyfbSHUG+74tANnQKdPFd4R01/jNFg3y2CSXWG9yrAbfCLp8ZJYczzMBnhlPP5Wdr4WooGma0KCDphuk1KJvToGRUdIx0q8OGbcq0cewR0TVccWrGPYJCGaDOHfvsmfujf0fvbNxwuh41Au4YahZKWUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FPS0+tf586JHmAWGdHQRB80+GLdISvZU62xO+Jbs9fo=; b=QMO8N/sQhD5WCVOD08TE42zDWk5qjl69PtvHo8uNE/i2xpBeCeaWYJyf1s7gfXZRGq7EFMPQY67oyzIOpUM5wcb7s/sMDLLIC+Ng2dFweTe6YBrwgoz1O2hsu5t6tcgpHeTsCcejb9OAV/PXE7qZTTrbIYXTfeunkor7QS1++lh8aXvaHMCLVQhJUWshyqrmT6ZBCF+mNZoVjgJw4RAafBP+uTZsjqhB/WpSUlrQsTZ2BQTy5HKqX/l+ZbeCu4LVDZ8PYuJtKNrlebbzu+RX1I6hEYfMl740DcjQHTIIE8N3nRoD/ru4WB6bPKctBZxrOnQ+wPpRP7g5wx+Zmb83Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FPS0+tf586JHmAWGdHQRB80+GLdISvZU62xO+Jbs9fo=; b=enHP1NINgR9/nsymcTIJ1MTpaGxSnpHxeAXaE0f2Ud+h9gomecV4mRmyIKRk6S23r+tU1+Eo5xB1hw/vZlETHhAnlVzJHe7Qh1dDKo+GjSffKy3jzYbhqeHbsYIYHu4Wi3Ml+It6CYiUqX6rFou4JbVuJ8bIwB6VsyMca/WX6AA= Subject: Re: Working Group for Secure Boot To: Bob Eshleman , Xen-devel CC: Roman Shaposhnik References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> From: Andrew Cooper Message-ID: <19a3ce18-da72-3fef-fb15-8ca2891ddc8a@citrix.com> Date: Fri, 12 Mar 2021 17:06:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0253.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::6) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aeca19cc-589d-4bfa-58db-08d8e5792dd9 X-MS-TrafficTypeDiagnostic: BN6PR03MB2513: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xu4DvtWoZTMDt4hcNKtqpv4G0zNbgNxjL0cfuS2U0Nhz/45BgKkenU/nnPihBoKzc7YA9hAsZx/zvNjOmhJ9TwOZRTFIWzeMr+5GoSs4xnG0IsY2eu0KgliHKY3ZT08Bk65Fz0WoBMDIkcQo3t5UUgWlTmdbCjap6Lp5f1wSM+5xG7M6Bh/JfE7AiSIUzfcfRnf6itwW1T81s3/lUagE6czji+yuL3Yv3GHUo+V/nu6fkbmd6XHTZQGshXpigoqOl2jDNvq8LD4lY6R2oloE77Pld3wVHXgJIirLzIOY9gvQ+rOKvvsODZAa+qeJK18Qjv3G0tgkLRDWdefD1VBHRt/plLzqoa9BiL/3A49xeu+NqIsrU0PV1bmMvUnC9DldsQw4neHmkHaCFwSBwxG0Ywp9iLMcKrrrTjcXD7aJ5vEzJDWEImrRAt8lQq7+Agw8t3TmVQV7emwSH8I+8Y2wEfWUb7dtyfKE3u6ODPMClH3/ToLvd5RfpdwV579dqQ8Cmr4M6H71KA+BRkYT4f1/I8H/44xwMSpmQ0fhAnohSCIPqg3MlcEwTZvfJRd3LfZPRMXacARt0eBTi7ffyxTCu+Nm0uBcFHN7MyWnIMhxUU4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(376002)(39860400002)(366004)(396003)(66946007)(6486002)(31686004)(956004)(66476007)(2906002)(2616005)(4326008)(66556008)(26005)(53546011)(86362001)(6666004)(83380400001)(31696002)(186003)(16526019)(110136005)(16576012)(8676002)(478600001)(316002)(4744005)(36756003)(5660300002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZGNZNmtBMFFKYlFvRWYrdytXdDVjbGlrQjlPaWw3UStqQ2czZlBXZG5hTDgw?= =?utf-8?B?YWhndit4V3BENTJJY3g5NElMVC9MaS9LcURDTkpWWUNmQW9tUkVsZmlXMENj?= =?utf-8?B?UktaaXdsa2JyVS85KzNjTmx5NnM4Q0hvN0htaVNZUVNhd0dhRDRuTTlzSUNy?= =?utf-8?B?M1M3WFNsK3Rxa2k4bWpiNmhwanN5UTJGdlpkcWYrUm9JYW9DdThwT1BmaW1D?= =?utf-8?B?Z05Nc0RsOXF6QWgvYkZpTXJZeFZvSW80QXFmd1BoNUdZMmhnd0Q0SFVYSHE3?= =?utf-8?B?Z3FwdHZqY2I0ZkRDUmFtajVoYUFiQm5rakVPdytjYURTaFNFUFFMWUVnTmdr?= =?utf-8?B?NjF1eWlpNWVtYXJlSWR5TTU1alhJamZzenhxMnlIeTNTYnIzZjM0VFJURlcy?= =?utf-8?B?YjN1bHN3RzEyV0RmajBpdmpxK3lidEVkVjhYVFZlZDNoTWRvR1NWTmU3d0NJ?= =?utf-8?B?VWtYUStaUm50bGQ5SUNZcCtKcWh4bC8vUitzTVdjQzYvbno4bUhRTnNSN2pF?= =?utf-8?B?NzNycDZ3dWtOWlArdHlvbXFjNkRiSzZVd2FqVUVpQ0FwV0UrM2Z0Mlh4S1dS?= =?utf-8?B?N1R1Qkh4am1BdGdzREJPaWhKeEVtWmtvc1pyRkUwZk0raW83QjROZGQ0U3Bx?= =?utf-8?B?QSs5RExGNXROYjlOamxPWGo5UmU0UUdPRnhaODJLNnRyRTZmc25rMnp6ZHhw?= =?utf-8?B?SStLN1ZveitPT3BvWVIyK1pJczdTd0RxVE1iVHQrK1FnL0o4eHVjSFc4MmR2?= =?utf-8?B?UysrRDJjUDUxeWYrUUFGM2s5RGs5eERIdHFkTGhYbzY3ckZKck41elJTVmE2?= =?utf-8?B?Yk1vVXhDcHd0QmJUcFdmVlNDMWJPbHJEcmxDSnJrL1BIcjhrN2t5cy9ycWRR?= =?utf-8?B?NkxCK0pJUUpRUkNqVkhua29jQURkUWpHM0F4NnhrdlR2YzhYRkFhcVg3azMx?= =?utf-8?B?ejNWRS9teS9wTS9SRkc3anVEQ1BCY2VidW11WkRSMHZmc1hxaGlFMlNjZ0R4?= =?utf-8?B?Nk40Z3NlZEhGVE5CVXNpQ0ZYUitFaDJoc3ZqTjFaTTNXZy9saXpjUWc3Zld2?= =?utf-8?B?d01OelA5WVdKeGdTWWgxTlBUZU9DREN2N1hFV2RhZVFjSEk5SGFFTGpTenRO?= =?utf-8?B?ZTdnaFR3eGtDSUl4L2FSNTFJVUNxZEp4bGZrZml5ZzZGbFFRM0RFY3NTQ3Ry?= =?utf-8?B?bGRoSG16d0FxNlhRL0NodFViQ2h3Wm1rSWtpdWJCaGJwaERhTW5GUG5jUFlO?= =?utf-8?B?ZjJ5U3RwSHBDRjhSSXNqUGcxajVidkxSY2V1amRIdExtaTdRSlN0Wkc3QVRJ?= =?utf-8?B?RUtYUWRUNTlmMlpHdjBuU2FkeFRrN0lYbElvREl2TDNXZm8xNHVMY1NkTHhP?= =?utf-8?B?UWJ0dDhnWXFlVm9EMjRERVBpS3FKS25zb0tPWFpsdWlPaWF5aWg5bUpKQlBS?= =?utf-8?B?TUdzQTVseUcyVVBhZU0rUG95WEduTHFDclNGMFRSN2ZQZmN2UndSUWpPd09N?= =?utf-8?B?ZjVDWUY0U3FBVDBnSE1KS3FkM3pHK1QwTlgzQjY4WkJGMldTMDF4UFdNMmh3?= =?utf-8?B?Y21DS3hRNEhobGhGZFBVT2hWRjFZYjBDYUl1eXE1NGVnRVRJZVJWS1d6STlI?= =?utf-8?B?aWRXV1Z6UG8yMFhDOXZSWEg0aHF6YjVKMEpDK09Ta25Dak0rU1Zac3VxaGJT?= =?utf-8?B?VTZpVXJtdytZaW9TRDNXcXpuMDMrYy9MdmdCM1hpSjhPOThvU0tGTUNFeER0?= =?utf-8?Q?aIuCYV0sznWGHUn+/gph1jxsHC9LSn0AlYWE6JO?= X-MS-Exchange-CrossTenant-Network-Message-Id: aeca19cc-589d-4bfa-58db-08d8e5792dd9 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 17:06:29.7696 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b7Utwl250tt/1vik01TtPQe5c85Y795BLo3mteOBTQ9RE3Rpw4eFmich+ppkmazfFTgFIXx5nUHYGyTUzMpM1n9OvKZnoz3dYZ6wYQtu+fI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2513 X-OriginatorOrg: citrix.com On 11/03/2021 18:34, Bob Eshleman wrote: > Hey all, > > We would like to start a working group for secure boot support in Xen > to coordinate the various interested parties and set out a plan for > the feature and its implications for the whole Xen system. > > The end goal is a full implementation that restricts the interfaces > dom0 has to affect Xen, akin to Linux's lockdown LSM. This implicates > important parts of the ABI (e.g., /dev/xen/privcmd/) and so will > require input from the greater community. > > I'm not familiar with how working groups function in the Xen project, > so this email also opens the floor for suggestions as to how this might > be managed. > > We'd love to hear from anyone interested in such a group and how the > community as a whole feels about such an effort. > > Best regards. CCing Roman as I expect he'll be interested too. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 12 17:09:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 17:09:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97264.184715 (Exim 4.92) (envelope-from ) id 1lKlHn-0002sU-OE; Fri, 12 Mar 2021 17:09:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97264.184715; Fri, 12 Mar 2021 17:09:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKlHn-0002sN-LI; Fri, 12 Mar 2021 17:09:15 +0000 Received: by outflank-mailman (input) for mailman id 97264; Fri, 12 Mar 2021 17:09:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKlHm-0002sI-Mg for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 17:09:14 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 52e8bb95-f68d-47d6-8f96-cf68e8a10ec6; Fri, 12 Mar 2021 17:09:13 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BE87DAF4D; Fri, 12 Mar 2021 17:09:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52e8bb95-f68d-47d6-8f96-cf68e8a10ec6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615568952; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vw9vlbcIxDvZFDSO3qxsyXQsarWP/6D8iLVj5PTnuSc=; b=P9Dv19Ahfoo6UePhZeclE36VMD8hzQawnnZAzNuWJf+cT4cMqFZurIm/tzHl0ccwUwN0v/ 2VuwSvOJM5vHs77bGRxFnjMi0dYrF4R54hjOKgmCNVlD6CLNNNe3YVkfe+inp1XKrcFWZ1 oKdsj8x2g4B2OS1ixC0gv0w/c9DL8uk= Subject: Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build To: Connor Davis Cc: Bobby Eshleman , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , xen-devel@lists.xenproject.org References: <7652ce3486c026a3a9f7d850170ea81ba8a18bdb.1614265718.git.connojdavis@gmail.com> From: Jan Beulich Message-ID: <84f490e8-7035-565d-4b20-6e46ccc800f2@suse.com> Date: Fri, 12 Mar 2021 18:09:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <7652ce3486c026a3a9f7d850170ea81ba8a18bdb.1614265718.git.connojdavis@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 25.02.2021 16:24, Connor Davis wrote: > --- /dev/null > +++ b/xen/include/public/arch-riscv.h > @@ -0,0 +1,183 @@ > +/****************************************************************************** > + * arch-riscv.h > + * > + * Guest OS interface to RISC-V Xen. > + * Initially based on the ARM implementation > + * > + * Permission is hereby granted, free of charge, to any person obtaining a copy > + * of this software and associated documentation files (the "Software"), to > + * deal in the Software without restriction, including without limitation the > + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the Software is > + * furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be included in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > + * DEALINGS IN THE SOFTWARE. > + * > + * Copyright 2019 (C) Alistair Francis > + */ > + > +#ifndef __XEN_PUBLIC_ARCH_RISCV_H__ > +#define __XEN_PUBLIC_ARCH_RISCV_H__ > + > +#include > + > +#define int64_aligned_t int64_t __attribute__((aligned(8))) > +#define uint64_aligned_t uint64_t __attribute__((aligned(8))) > + > +#ifndef __ASSEMBLY__ > +#define ___DEFINE_XEN_GUEST_HANDLE(name, type) \ > + typedef union { type *p; unsigned long q; } \ > + __guest_handle_ ## name; \ > + typedef union { type *p; uint64_aligned_t q; } \ > + __guest_handle_64_ ## name > + > +/* > + * XEN_GUEST_HANDLE represents a guest pointer, when passed as a field > + * in a struct in memory. On rv64 it is 8 bytes long and 8-byte aligned. > + * > + * XEN_GUEST_HANDLE_PARAM represents a guest pointer, when passed as a > + * hypercall argument. It is 4 bytes on rv32 and 8 bytes on rv64. > + */ > +#define __DEFINE_XEN_GUEST_HANDLE(name, type) \ > + ___DEFINE_XEN_GUEST_HANDLE(name, type); \ > + ___DEFINE_XEN_GUEST_HANDLE(const_##name, const type) > +#define DEFINE_XEN_GUEST_HANDLE(name) __DEFINE_XEN_GUEST_HANDLE(name, name) > +#define __XEN_GUEST_HANDLE(name) __guest_handle_64_ ## name > +#define XEN_GUEST_HANDLE(name) __XEN_GUEST_HANDLE(name) > +#define XEN_GUEST_HANDLE_PARAM(name) __guest_handle_ ## name > +#define set_xen_guest_handle_raw(hnd, val) \ > + do { \ > + typeof(&(hnd)) _sxghr_tmp = &(hnd); \ > + _sxghr_tmp->q = 0; \ > + _sxghr_tmp->p = val; \ > + } while ( 0 ) > +#define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val) > + > +#if defined(__GNUC__) && !defined(__STRICT_ANSI__) > +/* Anonymous union includes both 32- and 64-bit names (e.g., r0/x0). */ > +# define __DECL_REG(n64, n32) union { \ > + uint64_t n64; \ > + uint32_t n32; \ > + } > +#else > +/* Non-gcc sources must always use the proper 64-bit name (e.g., x0). */ > +#define __DECL_REG(n64, n32) uint64_t n64 > +#endif > + > +struct vcpu_guest_core_regs > +{ > + unsigned long zero; > + unsigned long ra; > + unsigned long sp; > + unsigned long gp; > + unsigned long tp; > + unsigned long t0; > + unsigned long t1; > + unsigned long t2; > + unsigned long s0; > + unsigned long s1; > + unsigned long a0; > + unsigned long a1; > + unsigned long a2; > + unsigned long a3; > + unsigned long a4; > + unsigned long a5; > + unsigned long a6; > + unsigned long a7; > + unsigned long s2; > + unsigned long s3; > + unsigned long s4; > + unsigned long s5; > + unsigned long s6; > + unsigned long s7; > + unsigned long s8; > + unsigned long s9; > + unsigned long s10; > + unsigned long s11; > + unsigned long t3; > + unsigned long t4; > + unsigned long t5; > + unsigned long t6; Please avoid use of "unsigned long" in the public headers. Consumers, potentially even cross-bitness or cross-arch ones, may have a different view on what unsigned long is. uint_t wants using here, and if you mean to abstract 32-bit and 64-bit right away, then something like a register_t typedef may want introducing. Also iirc all the integer registers can also be referred to as x, in which case it might be nice to allow for both names (in a union). You have a __DECL_REG() further up, but you don't appear to be using it ... > --- a/xen/include/public/hvm/save.h > +++ b/xen/include/public/hvm/save.h > @@ -106,6 +106,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct hvm_save_end); > #include "../arch-x86/hvm/save.h" > #elif defined(__arm__) || defined(__aarch64__) > #include "../arch-arm/hvm/save.h" > +#elif defined(__riscv) > +#include "../arch-riscv/hvm/save.h" Does the compiler not also provide __riscv__? If it does, using it here (and elsewhere) would fit better with the existing logic. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 12 17:39:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 17:39:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97277.184747 (Exim 4.92) (envelope-from ) id 1lKlkZ-0005qi-HV; Fri, 12 Mar 2021 17:38:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97277.184747; Fri, 12 Mar 2021 17:38:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKlkZ-0005qb-EE; Fri, 12 Mar 2021 17:38:59 +0000 Received: by outflank-mailman (input) for mailman id 97277; Fri, 12 Mar 2021 17:38:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKlkY-0005qV-Pr for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 17:38:58 +0000 Received: from mailhost.m5p.com (unknown [74.104.188.4]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 55f4ed62-aea6-42d3-a2bd-5b4f2865e42f; Fri, 12 Mar 2021 17:38:57 +0000 (UTC) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 12CHcaIH077739 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 12 Mar 2021 12:38:42 -0500 (EST) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 12CHcaQA077738; Fri, 12 Mar 2021 09:38:36 -0800 (PST) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55f4ed62-aea6-42d3-a2bd-5b4f2865e42f Date: Fri, 12 Mar 2021 09:38:36 -0800 From: Elliott Mitchell To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , George Dunlap , Ian Jackson , Wei Liu , Juergen Gross , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.15] arm: replace typeof() with __typeof__() Message-ID: References: <202103092114.129LEgZp059925@m5p.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mattapan.m5p.com On Wed, Mar 10, 2021 at 09:54:57AM +0100, Jan Beulich wrote: > On 09.03.2021 22:27, Andrew Cooper wrote: > > > > I wonder why our header checks don't pick this up.?? Do we need to throw > > a -pedantic around? > > That's a long-standing issue with the checking: For issues to be > found in macros, the macros would actually need to be used. This is key since only the hunk for xen/include/public/arch-arm.h was found during a build. The other two hunks were found while preparing to submit this to the Xen Project since I checked for other occurrences of typeof(). Had I not spent the time to look, the other three uses might have generated 2-3 additional patches in the future. Also notable the ARM portion was originally found more than 5 years ago (between 4.2 and 4.6), so this had been lurking for a long time. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Fri Mar 12 19:07:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 19:07:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97297.184798 (Exim 4.92) (envelope-from ) id 1lKn7R-0006CG-Re; Fri, 12 Mar 2021 19:06:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97297.184798; Fri, 12 Mar 2021 19:06:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKn7R-0006C9-Nx; Fri, 12 Mar 2021 19:06:41 +0000 Received: by outflank-mailman (input) for mailman id 97297; Fri, 12 Mar 2021 19:06:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKn7P-0006C4-Jo for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 19:06:39 +0000 Received: from mail-pj1-x102e.google.com (unknown [2607:f8b0:4864:20::102e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2e9c3918-45ee-4b77-8605-bb526c767846; Fri, 12 Mar 2021 19:06:38 +0000 (UTC) Received: by mail-pj1-x102e.google.com with SMTP id kr3-20020a17090b4903b02900c096fc01deso11514748pjb.4 for ; Fri, 12 Mar 2021 11:06:38 -0800 (PST) Received: from ?IPv6:2601:1c2:4f80:d230::5? ([2601:1c2:4f80:d230::5]) by smtp.gmail.com with ESMTPSA id 8sm6397303pfp.171.2021.03.12.11.06.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Mar 2021 11:06:37 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e9c3918-45ee-4b77-8605-bb526c767846 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SZP31BWDO2a2GEspHnC+nw+SlsUo6GIIo5Al+G3ya/E=; b=TDd4L3K62tJKYjK5rQ6ta9doz5QXpYcSXNI/5ZRNJuwzezOFl08AvR4IUXuPHAqxAm qn1F+A+wddpxIoZFLsJcrNDFkG7Isj6lIrF5FKH77ulsQ78qWmsE3Hy+2QwA93J9GmUb ep+nPLbGIShnSF37QBdOhAg/OVAddECZCwOWAWNxJAODvUVfxmr41lZ6D+BsT0yS0iDv 3ug9avDS/PUQU9cGKSZX0L3dzxmnCBsrjg06EkvPalURkspqD8+1vywkwyX4yCLm6s7E T0vJXIOuiq8F0exI5wZEWm7vbui1B6C+VzGkbOTDta1u9gkuRWu5vR7DdbzIOhRczIFa Kz3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=SZP31BWDO2a2GEspHnC+nw+SlsUo6GIIo5Al+G3ya/E=; b=S/XCVwg6LQlbTTSxRZXg9bkHOWb1gxQz1JU5CKHO7gu/Fu9EgAICO/ffVZudOnDWS3 3jk8mguv1i9mLoESI/DncG1kfWatOSHtAdOV/3qMNxT4c774IzvRrtGRUnR9Wwd2sgTh jXYnxAu+gng/8CC4O8IrW5m/sJzSXwJXmTus+gH0EjkZ6oJF2TtCGmKCSGcG5kCsOHGX CLvmMWXiho4jQ68+Wjg946vFunR0KuJD6nLpx8OViUL6HeQucdpi/21f//NjBZpQt6Ar hDpC6XpmQTSwuoUDSMlSIHp5kK6zzB+UFX8U1THJ0SpsnTJCMwLqd9zsCUc2D43CJFVd B5Og== X-Gm-Message-State: AOAM530eCx2b6e/FVd+EOelgC18ShKmNTxhkaRk8tjH9xqKxfmxE6DR/ 92a1UuWNIZDRfcbkWzk5zhQ= X-Google-Smtp-Source: ABdhPJzY1TFKZ8P4Y+acYcIBrj0MeGMjKO26JNJ7qrs2W5M11qHhHguw02d4MGdaNFN5NldvSJy+NA== X-Received: by 2002:a17:90a:ad87:: with SMTP id s7mr16041442pjq.20.1615575997970; Fri, 12 Mar 2021 11:06:37 -0800 (PST) Subject: Re: Working Group for Secure Boot From: Bob Eshleman To: Xen-devel Cc: Andrew Cooper , George Dunlap , piotr.krol@3mdeb.com, Olivier Lambert , Trammell Hudson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , "Daniel P. Smith" , Jan Beulich References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> Organization: Vates SAS Message-ID: <1039be05-cbf2-95aa-5eba-246fb06be8e5@gmail.com> Date: Fri, 12 Mar 2021 11:06:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Awesome, it's great to see this interest. I'll wait until early next week to give more people a chance to pitch in, then start bugging everybody about availability to schedule a meeting. I'll put together a small agenda then to get the ball rolling. Thanks all. From xen-devel-bounces@lists.xenproject.org Fri Mar 12 19:55:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 19:55:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97302.184813 (Exim 4.92) (envelope-from ) id 1lKnsb-0002YZ-MT; Fri, 12 Mar 2021 19:55:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97302.184813; Fri, 12 Mar 2021 19:55:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKnsb-0002YS-I8; Fri, 12 Mar 2021 19:55:25 +0000 Received: by outflank-mailman (input) for mailman id 97302; Fri, 12 Mar 2021 19:55:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKnsa-0002YK-03; Fri, 12 Mar 2021 19:55:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKnsZ-0007Kf-R5; Fri, 12 Mar 2021 19:55:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKnsZ-0002fd-JD; Fri, 12 Mar 2021 19:55:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKnsZ-0004tL-If; Fri, 12 Mar 2021 19:55:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=o1Wzto2x+BiPezMJLoguEAeOLE6J23pjmyuak9XEgDw=; b=wIXf0ogSuHhzgGsJYGWdfJbEWh RKA1QH42DVb+OrjDmxlRVJcZotik/yQRNaWvZDgdyvyU8vOWD9Ydb2j3/ORpKwoWNsezSCN0wCO2B jOiE7vVGAmlo8wqZWNOSiRLhPIcx8mYuLeQtx3ITHamC3B0JoiIrJxWTSyzZul9jXtVo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160031: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc46386d89d83c73c41c2b19be83a73957c4393 X-Osstest-Versions-That: xen=0570d7f276dd20a3adee80ca44a5fe7daf7566cd From: osstest service owner Date: Fri, 12 Mar 2021 19:55:23 +0000 flight 160031 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160031/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9dc46386d89d83c73c41c2b19be83a73957c4393 baseline version: xen 0570d7f276dd20a3adee80ca44a5fe7daf7566cd Last test of basis 159991 2021-03-12 09:00:24 Z 0 days Testing same since 160031 2021-03-12 17:00:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Dario Faggioli Igor Druzhinin Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 0570d7f276..9dc46386d8 9dc46386d89d83c73c41c2b19be83a73957c4393 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Mar 12 20:03:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 20:03:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97310.184828 (Exim 4.92) (envelope-from ) id 1lKo0W-0003gO-NB; Fri, 12 Mar 2021 20:03:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97310.184828; Fri, 12 Mar 2021 20:03:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKo0W-0003gH-K2; Fri, 12 Mar 2021 20:03:36 +0000 Received: by outflank-mailman (input) for mailman id 97310; Fri, 12 Mar 2021 20:03:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKo0U-0003gC-O2 for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 20:03:34 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 553fef3b-7165-4ee9-8390-9ea0f98af803; Fri, 12 Mar 2021 20:03:33 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPS id 1323D64F83; Fri, 12 Mar 2021 20:03:33 +0000 (UTC) Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id 0DD61609E7; Fri, 12 Mar 2021 20:03:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 553fef3b-7165-4ee9-8390-9ea0f98af803 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615579413; bh=2iIUDg5MQhW2lt2WKw0Mjk82CAhvya2PmWSvMJh1obg=; h=Subject:From:In-Reply-To:References:Date:To:Cc:From; b=rXHhU5G7ocbzs5s0OeLFicRsQs4ViIH8N7IMrOfv1HTN+DMqoQK/c/Y4QRxd2RX3k j38D0udm7fracNLiQrpGGm7yGEhFkjckbESEvRSJI/8O2h5IX6sKdVSnNkp9HCICQq JOp2EfkpHcLEvs5bbAj7R5u9zNWFx6T53xZLTuif4KMR0dXrsJMFHzw6lWh7ooh6jg ckPlFKl0sTyRMwAPekhmY3kGcNEob2KEaqVvCFHLuHjlFajTRdP3l1h69rImFWim0W tC5jMAZz/ES+1Vc3PmZzPhA2bWxnbOwR24F4SkxdMZuAPNNRnlN4jLbrdJmj0MzjIo M5ZlZdNOo64Cg== Subject: Re: [GIT PULL] xen: branch for v5.12-rc3 From: pr-tracker-bot@kernel.org In-Reply-To: <20210312083400.2594-1-jgross@suse.com> References: <20210312083400.2594-1-jgross@suse.com> X-PR-Tracked-List-Id: X-PR-Tracked-Message-Id: <20210312083400.2594-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.12b-rc3-tag X-PR-Tracked-Commit-Id: f1d20d8643e54dcde242fd2c8748063ed75702a8 X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: 6bf8819fede1fef9805e1d803261c0d3bb62f239 Message-Id: <161557941305.10515.9029579817339264425.pr-tracker-bot@kernel.org> Date: Fri, 12 Mar 2021 20:03:33 +0000 To: Juergen Gross Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com The pull request you sent on Fri, 12 Mar 2021 09:34:00 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.12b-rc3-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6bf8819fede1fef9805e1d803261c0d3bb62f239 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Fri Mar 12 20:17:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 20:17:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97313.184840 (Exim 4.92) (envelope-from ) id 1lKoDa-0004lj-UO; Fri, 12 Mar 2021 20:17:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97313.184840; Fri, 12 Mar 2021 20:17:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKoDa-0004lc-Qv; Fri, 12 Mar 2021 20:17:06 +0000 Received: by outflank-mailman (input) for mailman id 97313; Fri, 12 Mar 2021 20:17:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKoDZ-0004lU-Is; Fri, 12 Mar 2021 20:17:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKoDZ-0007mD-Az; Fri, 12 Mar 2021 20:17:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKoDY-0003IG-To; Fri, 12 Mar 2021 20:17:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKoDY-0003Yh-TD; Fri, 12 Mar 2021 20:17:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=u7Gqj++E+Z3Ab7Y3vzwbP77pFfS92WEP+Kp9RZ3jm+g=; b=XT7HYB0do+Zlf+QnAwDQpks9Sd F/Fgjbiph8MaZuOK476n8mrJKYef5q32FoG6fRBgJWXhhSzIY/m7qugr2Cg/l6e3u22d5PWd7bIvw fyc7A8ue2XmR+lTC6tKHyts5GyNPbqJeEyAzkcqw0T8a3xnQ1AcSRSTrKJRoxKBDoh50=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 159953: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9e23f10eb0db5ffa06f1a43f74fac790992a85c7 X-Osstest-Versions-That: xen=e4bdcc8aef6707027168ea29caed844a7da67b4d From: osstest service owner Date: Fri, 12 Mar 2021 20:17:04 +0000 flight 159953 xen-unstable real [real] flight 160042 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159953/ http://logs.test-lab.xenproject.org/osstest/logs/160042/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160042-retest test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160042-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159920 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159920 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159920 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159920 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159920 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159920 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159920 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159920 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159920 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159920 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159920 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 9e23f10eb0db5ffa06f1a43f74fac790992a85c7 baseline version: xen e4bdcc8aef6707027168ea29caed844a7da67b4d Last test of basis 159920 2021-03-10 20:37:43 Z 1 days Failing since 159937 2021-03-11 13:07:28 Z 1 days 2 attempts Testing same since 159953 2021-03-12 01:07:35 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Doug Goldstein Elliott Mitchell Jan Beulich Julien Grall Roger Pau Monne Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e4bdcc8aef..9e23f10eb0 9e23f10eb0db5ffa06f1a43f74fac790992a85c7 -> master From xen-devel-bounces@lists.xenproject.org Fri Mar 12 20:37:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 20:37:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97329.184889 (Exim 4.92) (envelope-from ) id 1lKoX2-0006uU-1m; Fri, 12 Mar 2021 20:37:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97329.184889; Fri, 12 Mar 2021 20:37:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKoX1-0006uN-Uc; Fri, 12 Mar 2021 20:37:11 +0000 Received: by outflank-mailman (input) for mailman id 97329; Fri, 12 Mar 2021 20:37:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKoX0-0006uI-9l for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 20:37:10 +0000 Received: from vps0.lunn.ch (unknown [185.16.172.187]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 78857b94-a625-426a-92c8-f35cd35329d5; Fri, 12 Mar 2021 20:37:09 +0000 (UTC) Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lKoWp-00AaIe-Fb; Fri, 12 Mar 2021 21:36:59 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78857b94-a625-426a-92c8-f35cd35329d5 Date: Fri, 12 Mar 2021 21:36:59 +0100 From: Andrew Lunn To: "Hsu, Chiahao" Cc: netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring Message-ID: References: <20210311225944.24198-1-andyhsu@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Mar 12, 2021 at 04:18:02PM +0100, Hsu, Chiahao wrote: > > Andrew Lunn 於 2021/3/12 15:52 寫道: > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > > > > > On Thu, Mar 11, 2021 at 10:59:44PM +0000, ChiaHao Hsu wrote: > > > In order to support live migration of guests between kernels > > > that do and do not support 'feature-ctrl-ring', we add a > > > module parameter that allows the feature to be disabled > > > at run time, instead of using hardcode value. > > > The default value is enable. > > Hi ChiaHao > > > > There is a general dislike for module parameters. What other mechanisms > > have you looked at? Would an ethtool private flag work? > > > > Andrew > > > Hi Andrew, > > I can survey other mechanisms, however before I start doing that, > > could you share more details about what the problem is with using module > parameters? thanks. It is not very user friendly. No two kernel modules use the same module parameters. Often you see the same name, but different meaning. There is poor documentation, you often need to read the kernel sources it figure out what it does, etc. Ideally, you want a mechanism which is shared by multiple drivers and is well documented. Does virtio have the same problems? What about VmWare? HyperV? Could you make a generic solution which works for all these technologies? Is this just a networking problem? Or does disk, graphics etc, need something similar? Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 12 20:47:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 20:47:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97333.184901 (Exim 4.92) (envelope-from ) id 1lKogS-0007xP-WF; Fri, 12 Mar 2021 20:46:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97333.184901; Fri, 12 Mar 2021 20:46:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKogS-0007xI-TL; Fri, 12 Mar 2021 20:46:56 +0000 Received: by outflank-mailman (input) for mailman id 97333; Fri, 12 Mar 2021 20:46:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKogR-0007xD-U8 for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 20:46:56 +0000 Received: from mail-qk1-x729.google.com (unknown [2607:f8b0:4864:20::729]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3a79cbbe-e9eb-48fe-9dff-c7093a2f95ed; Fri, 12 Mar 2021 20:46:55 +0000 (UTC) Received: by mail-qk1-x729.google.com with SMTP id l132so25777032qke.7 for ; Fri, 12 Mar 2021 12:46:55 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a79cbbe-e9eb-48fe-9dff-c7093a2f95ed DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zededa.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l785eZf+wWI4zZpuXE1q31ve0eVDz6sJ28MOYfsk8Zo=; b=dSlrLa8h1Wv5mlxtZXolO4pTOdtxx5zhUoBPYuUSf65mE8syJ25J04qAzumHhtRJDH LInZvfdX4HCpcLfVdsf65rxukGVqJ3V0/lVuN38IIp21DtbFtkNyYm9q/4xwuRnzQs0W C/cnN9WvpliVqUyQ3mnBGL7KLntVLeZiizyemYUriFHi6Tq0rkdhu81SzNfNZlbhBEYb 0E8AF477k64qIcIikDQCAouUgLAQLjdkRrupyUuieU/BxMLrAl3cTsznvJcWTgh3AqIt 6dwoEHWAqxgTsqY50bSnsgpFK076lFufdN/G4sOaJq7tv916OlPYWxVO8hkIkAK6R7b0 03Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l785eZf+wWI4zZpuXE1q31ve0eVDz6sJ28MOYfsk8Zo=; b=kDbHxRDp/6qPF4rk5tlnjY033+THvHjAg+HMBhgt1pdsX0FMpc9HCiTJw+dCmmATUA nhYWEB3nCrGDC3zEtI0VBOtpphxAtAKcsj6rDk0A0ZZc+k8hsjTp5o3Jso+eYN0AK/uY CLKrPH/crtZPQPp3MajGKeGX2aX9TihdifuWwFQSPwH7ZZb0qBSLhFf/aR/n0aMh69T9 MumZp//493kv4Ez/V5uxH9OHw5CqS2GH+jRza3Xye+Uwv3PU78+F+ekibRCP3UaMeHyS tUAHdR8LGaoZEgnDQeK34F9yEIF4PrdhQYmhprpszLtcdQkR4CTyIAA+YXx40u68e1qT gc3A== X-Gm-Message-State: AOAM530p01uU9hcUt1KPTYEVNpLpN5D0pabeWYfb6A1KuXNcl57JAHeH MDW6lOZRHV/VxZUrRcdgNN2WLpmQvmSmJc5VqaknGw== X-Google-Smtp-Source: ABdhPJyXa0WTaSbuMjp5jetFiontlSRHvPO27OK0ugobhptG7YF8Kybfm+Qi9c+bhuz/IP//CnXeCvfL5kqKrBNrxlI= X-Received: by 2002:a37:2cc3:: with SMTP id s186mr8599655qkh.270.1615582014897; Fri, 12 Mar 2021 12:46:54 -0800 (PST) MIME-Version: 1.0 References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> <1039be05-cbf2-95aa-5eba-246fb06be8e5@gmail.com> In-Reply-To: <1039be05-cbf2-95aa-5eba-246fb06be8e5@gmail.com> From: Roman Shaposhnik Date: Fri, 12 Mar 2021 12:46:43 -0800 Message-ID: Subject: Re: Working Group for Secure Boot To: Bob Eshleman Cc: Xen-devel , Andrew Cooper , George Dunlap , =?UTF-8?Q?Piotr_Kr=C3=B3l?= , Olivier Lambert , Trammell Hudson , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= , "Daniel P. Smith" , Jan Beulich Content-Type: text/plain; charset="UTF-8" Would love to participate! What are the next steps? Thanks, Roman. On Fri, Mar 12, 2021 at 11:06 AM Bob Eshleman wrote: > > Awesome, it's great to see this interest. > > I'll wait until early next week to give more > people a chance to pitch in, then start > bugging everybody about availability to > schedule a meeting. I'll put together a > small agenda then to get the ball rolling. > > Thanks all. > From xen-devel-bounces@lists.xenproject.org Fri Mar 12 20:55:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 20:55:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97339.184913 (Exim 4.92) (envelope-from ) id 1lKoow-0000We-0Q; Fri, 12 Mar 2021 20:55:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97339.184913; Fri, 12 Mar 2021 20:55:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKoov-0000WX-Su; Fri, 12 Mar 2021 20:55:41 +0000 Received: by outflank-mailman (input) for mailman id 97339; Fri, 12 Mar 2021 20:55:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKoou-0000WS-BA for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 20:55:40 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d5b9a16d-5bad-4194-9b7d-a8cc456b2747; Fri, 12 Mar 2021 20:55:39 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id BEEDB64F5E; Fri, 12 Mar 2021 20:55:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5b9a16d-5bad-4194-9b7d-a8cc456b2747 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615582539; bh=QENM3z31/tcfs5c9CR67VIbX9OzwRw1bni+hXiHOeOw=; h=Date:From:To:cc:Subject:From; b=FaL7jmMfMYmc861Pqxbxcb5TmXUnGcchdORrRU+kUzI34Sgcunr6eAqOXV3TSqsE8 Noxlr0lb9rvuNGmlcCe5Js1Y7/9DkEYF9N36Rftyj/U/JDaC02pk9b3oUIDlWdyF1C EnpTMObmudqSXloaA/yoyRLBoVPauzjc41zGYOSVl5FkS3wGJx3Yj1WF0HnMa899Qs bpaheSLh2be3kYzmXvpf73t5q+BWemWItbf/K3IQjTmvEOnr9ciFwizQkZ1JZ6hn+I 7FnStJ91ybdPVHJShcsgCH+gzp8PQekg56NhBzcBv6MtnX6BGbiqdaUBsvH+1dbI2u zcQNsw7jbyc+w== Date: Fri, 12 Mar 2021 12:55:38 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: xen-devel@lists.xenproject.org cc: sstabellini@kernel.org, committers@xenproject.org, roger.pau@citrix.com, Bertrand.Marquis@arm.com, cardoe@cardoe.com, fam@euphon.net Subject: patchew - gitlab-ci notifications during the Xen 4.16 cycle Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi all, During the last 6 months we have been working on improving the Xen Project gitlab-ci and patchew infrastructure. You can see the results from gitlab-ci tests on the staging branch here: https://gitlab.com/xen-project/xen/-/pipelines https://gitlab.com/xen-project/xen/-/pipelines/269678673 In addition, and more interestingly, now we have patchew integration. Patchew picks up patch series sent to xen-devel by any contributor and commits them to branches under this repository: https://gitlab.com/xen-project/patchew/xen Then, gitlab-ci tests start automatically. Patchew waits for the results and send a notification email. You can see patchew pipelines here: https://gitlab.com/xen-project/patchew/xen/-/pipelines All this typically happens before patches are even reviewed. Today the patchew notification emails are only sent to us in the Gitlab-CI working group. But the good news is that we think the results got to the point where they are reliable enough that it would be good to share them with the community. We plan to have patchew send email notifications to xen-devel starting from the beginning of the 4.16 development cycle. Stay tuned. Cheers, Stefano From xen-devel-bounces@lists.xenproject.org Fri Mar 12 21:05:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 21:05:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97342.184925 (Exim 4.92) (envelope-from ) id 1lKoyR-0001ZP-Vp; Fri, 12 Mar 2021 21:05:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97342.184925; Fri, 12 Mar 2021 21:05:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKoyR-0001ZI-RM; Fri, 12 Mar 2021 21:05:31 +0000 Received: by outflank-mailman (input) for mailman id 97342; Fri, 12 Mar 2021 21:05:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKoyQ-0001ZD-PZ for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 21:05:30 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9b83948e-7b7d-49d8-9c41-682aa6d7868d; Fri, 12 Mar 2021 21:05:30 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0C45264F2A; Fri, 12 Mar 2021 21:05:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b83948e-7b7d-49d8-9c41-682aa6d7868d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615583129; bh=0QNIPZgMEwF/WodAJ21fXlLPnZdWQNpPxT2BnDMPf0I=; h=From:To:Cc:Subject:Date:From; b=UWCAlPFlDPPZfZj65LbohqwThK7rpds/NUuaf0KN6x6DtYxENo+JU+cjgaOwU5yDo FxsZ/ayHW3lthZQoPWfBYIcDJFPRtur+qTcXf8cm+oDltI+bDuUtVrKTgtk4GR/IXP dalhyXd37qjghB579pON9WlKY3z7GchOGgGEcPEt5igBZ8XILfvIWmnC+Ax9RQiMo6 CgB2QRpZcG3QEajrdVfTGo/JVhwv+5rgaKC3EXP68On4af4xYJsXI8+5h1RlDXSnUg oisEU1SF0ogdQZhE98So1vWMYerc4fpu5niLrbH3GNtBrW/QOncO3hpVeBWgGNS+aY FhQZBlPBtUO5g== From: Stefano Stabellini To: cardoe@cardoe.com Cc: sstabellini@kernel.org, wl@xen.org, andrew.cooper3@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Subject: [PATCH] automation: remove allow_failure from Alpine Linux jobs Date: Fri, 12 Mar 2021 13:05:26 -0800 Message-Id: <20210312210526.14862-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 Now that the Alpine Linux build jobs complete successfully on staging we can remove the "allow_failure: true" tag. Signed-off-by: Stefano Stabellini --- automation/gitlab-ci/build.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 23ab81d892..cca2c310e2 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -434,25 +434,21 @@ alpine-3.12-gcc: extends: .gcc-x86-64-build variables: CONTAINER: alpine:3.12 - allow_failure: true alpine-3.12-gcc-debug: extends: .gcc-x86-64-build-debug variables: CONTAINER: alpine:3.12 - allow_failure: true alpine-3.12-clang: extends: .clang-x86-64-build variables: CONTAINER: alpine:3.12 - allow_failure: true alpine-3.12-clang-debug: extends: .clang-x86-64-build-debug variables: CONTAINER: alpine:3.12 - allow_failure: true # Arm builds -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Mar 12 21:33:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 21:33:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97359.184936 (Exim 4.92) (envelope-from ) id 1lKpPa-0004PW-7i; Fri, 12 Mar 2021 21:33:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97359.184936; Fri, 12 Mar 2021 21:33:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKpPa-0004PP-4V; Fri, 12 Mar 2021 21:33:34 +0000 Received: by outflank-mailman (input) for mailman id 97359; Fri, 12 Mar 2021 21:33:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKpPZ-0004PK-2S for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 21:33:33 +0000 Received: from mail-qt1-x829.google.com (unknown [2607:f8b0:4864:20::829]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b13f16f5-680d-4955-9582-8100ca4f8f57; Fri, 12 Mar 2021 21:33:31 +0000 (UTC) Received: by mail-qt1-x829.google.com with SMTP id s2so4978993qtx.10 for ; Fri, 12 Mar 2021 13:33:31 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b13f16f5-680d-4955-9582-8100ca4f8f57 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zededa.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BM3TgQ5bmQYp6+zaKTHpy/qR/6BDMxW0IXigCdZourc=; b=TbS5J14MfX6lOhRKTRptFj8VbuGZyEyu91j2dfMkbgMPwFYn16Wa4A4LXjg4MC1mXO xTTGqpsGMNJ20aUm23b8bBvd0oYzxDZK0qFPd6N7SYFMC6bLc4ScOD3TuzkkCKal0YT/ q1U1EPb1xBlzQvRLHbyWvgxvFNXZFHYPmOeI7QzB2eUWtTShPZQ1yK08+YEP9wMVOa4V RoAwUtkj3oofs7JpX8lFTyuoscslmjf7GMlAdhzGnggzAvAcAqgMNhG2jG2V+hMpcVc5 4K8C7kE5avWclmrp4i+Nqcghnt6m28Gi3l+wOQrYvPc0Drb4/GjXygA8ahcfAcHMu2nh vLPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BM3TgQ5bmQYp6+zaKTHpy/qR/6BDMxW0IXigCdZourc=; b=IF8gbhafuPYgQAXFOS4FVywyfJXRlqzOwvNsAAKl0nGVzNGQz5XTk9brhzuDYXcw4E GHeOprsULoksjKSRul9ZpdscPhsu2J06gZ+yOs1o3ARzWAWXKerqPy1mg1fOsfxr4xSb +xqs6pnQblI9i8HJKMbcw22nQZUu4i3dL4EVlVJFgh5jQoEzGZHVKawd+YxFnCnC60v/ YsxEzxgwaYEITD/r6oLfqiHsrWryDcfR/r0kYS0cDPsk4oPX8Rs/tO0kpGckG9NK+wII ywr0/kdn4o4L8b6wvq3l8WCLd+WOBGgZfBFMeS6qnv3QiP8vKAKAbWPmEEZ71XbobAut 3ayw== X-Gm-Message-State: AOAM530/LzuaLYJ85QYOTY1zcy8ChML9OBWYM/OwtiL5qL5oyN0RJGAx iHu4e50ARHGiGo8zc2x7+b7zMW1iZ+Wdo8GaoT4B6Q== X-Google-Smtp-Source: ABdhPJwAMciMM96AwaEKkCvGawTDOs/HneURHRPx8MPDNE8HehMQwbwCbeYnYXy2as5mmVirM7vEPXTmZeEX/WdXL30= X-Received: by 2002:ac8:1403:: with SMTP id k3mr13947354qtj.266.1615584811461; Fri, 12 Mar 2021 13:33:31 -0800 (PST) MIME-Version: 1.0 References: <45b8ef4c-6d36-e91b-ca1a-a82eeca5aaf5@suse.com> <49344e8d-5518-68c6-a417-68522a915e72@suse.com> In-Reply-To: From: Roman Shaposhnik Date: Fri, 12 Mar 2021 13:33:20 -0800 Message-ID: Subject: Re: Linux DomU freezes and dies under heavy memory shuffling To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: Stefano Stabellini , Xen-devel , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , George Dunlap Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi J=C3=BCrgen, just wanted to give you (and everyone who may be keeping an eye on this) an update. Somehow, after applying your kernel patch -- the VM is now running 10 days+ without a problem. I'll keep experimenting (A/B-testing style) but at this point I'm actually pretty perplexed as to why this patch would make a difference (since it is basically just for observability). Any thoughts on that? Thanks, Roman. On Wed, Feb 24, 2021 at 7:06 PM Roman Shaposhnik wrote: > > Hi J=C3=BCrgen! > > sorry for the belated reply -- I wanted to externalize the VM before I > do -- but let me at least reply to you: > > On Tue, Feb 23, 2021 at 5:17 AM J=C3=BCrgen Gro=C3=9F w= rote: > > > > On 18.02.21 06:21, Roman Shaposhnik wrote: > > > On Wed, Feb 17, 2021 at 12:29 AM J=C3=BCrgen Gro=C3=9F > > > wrote: > > > > > > On 17.02.21 09:12, Roman Shaposhnik wrote: > > > > Hi J=C3=BCrgen, thanks for taking a look at this. A few commen= ts below: > > > > > > > > On Tue, Feb 16, 2021 at 10:47 PM J=C3=BCrgen Gro=C3=9F > > > wrote: > > > >> > > > >> On 16.02.21 21:34, Stefano Stabellini wrote: > > > >>> + x86 maintainers > > > >>> > > > >>> It looks like the tlbflush is getting stuck? > > > >> > > > >> I have seen this case multiple times on customer systems now,= but > > > >> reproducing it reliably seems to be very hard. > > > > > > > > It is reliably reproducible under my workload but it take a lo= ng time > > > > (~3 days of the workload running in the lab). > > > > > > This is by far the best reproduction rate I have seen up to now. > > > > > > The next best reproducer seems to be a huge installation with sev= eral > > > hundred hosts and thousands of VMs with about 1 crash each week. > > > > > > > > > > >> I suspected fifo events to be blamed, but just yesterday I've= been > > > >> informed of another case with fifo events disabled in the gue= st. > > > >> > > > >> One common pattern seems to be that up to now I have seen thi= s > > > effect > > > >> only on systems with Intel Gold cpus. Can it be confirmed to = be true > > > >> in this case, too? > > > > > > > > I am pretty sure mine isn't -- I can get you full CPU specs if > > > that's useful. > > > > > > Just the output of "grep model /proc/cpuinfo" should be enough. > > > > > > > > > processor: 3 > > > vendor_id: GenuineIntel > > > cpu family: 6 > > > model: 77 > > > model name: Intel(R) Atom(TM) CPU C2550 @ 2.40GHz > > > stepping: 8 > > > microcode: 0x12d > > > cpu MHz: 1200.070 > > > cache size: 1024 KB > > > physical id: 0 > > > siblings: 4 > > > core id: 3 > > > cpu cores: 4 > > > apicid: 6 > > > initial apicid: 6 > > > fpu: yes > > > fpu_exception: yes > > > cpuid level: 11 > > > wp: yes > > > flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov = pat > > > pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx rdts= cp > > > lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology > > > nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx = est > > > tm2 ssse3 cx16 xtpr pdcm sse4_1 sse4_2 movbe popcnt tsc_deadline_time= r > > > aes rdrand lahf_lm 3dnowprefetch cpuid_fault epb pti ibrs ibpb stibp > > > tpr_shadow vnmi flexpriority ept vpid tsc_adjust smep erms dtherm ida > > > arat md_clear > > > vmx flags: vnmi preemption_timer invvpid ept_x_only flexpriority > > > tsc_offset vtpr mtf vapic ept vpid unrestricted_guest > > > bugs: cpu_meltdown spectre_v1 spectre_v2 mds msbds_only > > > bogomips: 4800.19 > > > clflush size: 64 > > > cache_alignment: 64 > > > address sizes: 36 bits physical, 48 bits virtual > > > power management: > > > > > > > > > > >> In case anybody has a reproducer (either in a guest or dom0) = with a > > > >> setup where a diagnostic kernel can be used, I'd be _very_ > > > interested! > > > > > > > > I can easily add things to Dom0 and DomU. Whether that will > > > disrupt the > > > > experiment is, of course, another matter. Still please let me > > > know what > > > > would be helpful to do. > > > > > > Is there a chance to switch to an upstream kernel in the guest? I= 'd like > > > to add some diagnostic code to the kernel and creating the patche= s will > > > be easier this way. > > > > > > > > > That's a bit tough -- the VM is based on stock Ubuntu and if I upgrad= e > > > the kernel I'll have fiddle with a lot things to make workload > > > functional again. > > > > > > However, I can install debug kernel (from Ubuntu, etc. etc.) > > > > > > Of course, if patching the kernel is the only way to make progress -- > > > lets try that -- please let me know. > > > > I have found a nice upstream patch, which - with some modifications - I > > plan to give our customer as a workaround. > > > > The patch is for kernel 4.12, but chances are good it will apply to a > > 4.15 kernel, too. > > I'm slightly confused about this patch -- it seems to me that it needs > to be applied to the guest kernel, correct? > > If that's the case -- the challenge I have is that I need to re-build > the Canonical (Ubuntu) distro kernel with this patch -- this seems > a bit daunting at first (I mean -- I'm pretty good at rebuilding kernels > I just never do it with the vendor ones ;-)). > > So... if there's anyone here who has any suggestions on how to do that > -- I'd appreciate pointers. > > > I have been able to gather some more data. > > > > I have contacted the author of the upstream kernel patch I've been usin= g > > for our customer (and that helped, by the way). > > > > It seems as if the problem is occurring when running as a guest at leas= t > > under Xen, KVM, and VMWare, and there have been reports of bare metal > > cases, too. Hunting this bug is going on for several years now, the > > patch author is at it since 8 months. > > > > So we can rule out a Xen problem. > > > > Finding the root cause is still important, of course, and your setup > > seems to have the best reproduction rate up to now. > > > > So any help would really be appreciated. > > > > Is the VM self contained? Would it be possible to start it e.g. on a > > test system on my side? If yes, would you be allowed to pass it on to > > me? > > I'm working on externalizing the VM in a way that doesn't disclose anythi= ng > about the customer workload. I'm almost there -- sans my question about > the vendor kernel rebuild. I plan to make that VM available this week. > > Goes without saying, but I would really appreciate your help in chasing t= his. > > Thanks, > Roman. From xen-devel-bounces@lists.xenproject.org Fri Mar 12 22:15:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 22:15:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97365.184948 (Exim 4.92) (envelope-from ) id 1lKq4F-0008Em-Et; Fri, 12 Mar 2021 22:15:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97365.184948; Fri, 12 Mar 2021 22:15:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKq4F-0008Ef-Bd; Fri, 12 Mar 2021 22:15:35 +0000 Received: by outflank-mailman (input) for mailman id 97365; Fri, 12 Mar 2021 22:15:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKq4E-0008EX-GJ; Fri, 12 Mar 2021 22:15:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKq4E-0001Q9-A5; Fri, 12 Mar 2021 22:15:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKq4D-0007Nl-Uk; Fri, 12 Mar 2021 22:15:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKq4D-0002jP-UF; Fri, 12 Mar 2021 22:15:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=b8FxGn9YWKJLevON2BQXRncucFr7ttEn10HSh9Cs1ZQ=; b=LwQcvtRGwLYHjw2tp1e2Nv1Fzz SOm8OmxREXs0r4hFr7KUzZYd/B8cT0siGW2O9BY4keRd5tfQi+YpYiTa6w9P4vOPWtGgOTbIXcf05 afk0UbNNgnVBfw1dJhtCXBaAIwBCw0IWW4G1Xjko1c2jP3zQT+V3kwFI5UOV/EOYAJZI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160044: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=14b95b3b8546db201e7efd0636ae0e215fae98f3 X-Osstest-Versions-That: xen=9dc46386d89d83c73c41c2b19be83a73957c4393 From: osstest service owner Date: Fri, 12 Mar 2021 22:15:33 +0000 flight 160044 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160044/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 14b95b3b8546db201e7efd0636ae0e215fae98f3 baseline version: xen 9dc46386d89d83c73c41c2b19be83a73957c4393 Last test of basis 160031 2021-03-12 17:00:24 Z 0 days Testing same since 160044 2021-03-12 20:01:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ian Jackson Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9dc46386d8..14b95b3b85 14b95b3b8546db201e7efd0636ae0e215fae98f3 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Mar 12 23:16:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 12 Mar 2021 23:16:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97373.184966 (Exim 4.92) (envelope-from ) id 1lKr1J-0005Sk-7S; Fri, 12 Mar 2021 23:16:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97373.184966; Fri, 12 Mar 2021 23:16:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKr1J-0005Sd-4X; Fri, 12 Mar 2021 23:16:37 +0000 Received: by outflank-mailman (input) for mailman id 97373; Fri, 12 Mar 2021 23:16:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKr1H-0005SY-J8 for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 23:16:35 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f70687f7-4f32-4561-ae7e-c52a91103163; Fri, 12 Mar 2021 23:16:34 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9901A64F86; Fri, 12 Mar 2021 23:16:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f70687f7-4f32-4561-ae7e-c52a91103163 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615590993; bh=2Ud3Qj5FwQDV8Jl/uhEGUftQWNZdzTuPESSr+hKjGYI=; h=From:To:Cc:Subject:Date:From; b=QwD0MpvCpMLvE+5s33MuW+bGLiuMc0/hr3ZsQn1uqtcjsUQ6oYpdKfWN1qPxCm7bv BuPhXuN3ifD7A95nBw0F4FhePBQk36nD0Ia4Ea5dqfX4nPFtCJoJnxaEErJ06U2+M6 kZzoCfK9Xg2M8Gaz6QBQub+yb6Qs5N7F82KQy8BPmXRbRk3v3ZNxprM1W5/skNRT7p WCIf0axZ4x7GbVYDLTijjvWbhsYgTNhoDZIgwcoTRZ8qQq6ITc/uIDusYyYCK9RELk dIdXqkUncwyE07E8GioAhh+dmion+BXF8u2Fjkaf3m/O+IYMfOsN1z7QKMucGe27ME 03DW5/3TwB0nA== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jbeulich@suse.com, andrew.cooper3@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, Stefano Stabellini Subject: [PATCH v3] xen: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped Date: Fri, 12 Mar 2021 15:16:32 -0800 Message-Id: <20210312231632.5666-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 Introduce two feature flags to tell the domain whether it is direct-mapped or not. It allows the guest kernel to make informed decisions on things such as swiotlb-xen enablement. The introduction of both flags (XENFEAT_direct_mapped and XENFEAT_not_direct_mapped) allows the guest kernel to avoid any guesswork if one of the two is present, or fallback to the current checks if neither of them is present. XENFEAT_direct_mapped is always set for not auto-translated guests. For auto-translated guests, only Dom0 on ARM is direct-mapped. Also, see is_domain_direct_mapped() which refers to auto-translated guests: xen/include/asm-arm/domain.h:is_domain_direct_mapped xen/include/asm-x86/domain.h:is_domain_direct_mapped Signed-off-by: Stefano Stabellini CC: jbeulich@suse.com CC: andrew.cooper3@citrix.com CC: julien@xen.org --- Changes in v3: - swap 2 conditions of || - improve in-code comment to cover existing assumptions Changes in v2: - code style improvements - better comments - better commit message - not auto_translated domains are direct_mapped --- xen/common/kernel.c | 4 ++++ xen/include/public/features.h | 14 ++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/xen/common/kernel.c b/xen/common/kernel.c index 7a345ae45e..d77756a81e 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -560,6 +560,10 @@ DO(xen_version)(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) (1U << XENFEAT_hvm_callback_vector) | (has_pirq(d) ? (1U << XENFEAT_hvm_pirqs) : 0); #endif + if ( !paging_mode_translate(d) || is_domain_direct_mapped(d) ) + fi.submap |= (1U << XENFEAT_direct_mapped); + else + fi.submap |= (1U << XENFEAT_not_direct_mapped); break; default: return -EINVAL; diff --git a/xen/include/public/features.h b/xen/include/public/features.h index 1613b2aab8..9ee2f760ef 100644 --- a/xen/include/public/features.h +++ b/xen/include/public/features.h @@ -114,6 +114,20 @@ */ #define XENFEAT_linux_rsdp_unrestricted 15 +/* + * A direct-mapped (or 1:1 mapped) domain is a domain for which its + * local pages have gfn == mfn. If a domain is direct-mapped, + * XENFEAT_direct_mapped is set; otherwise XENFEAT_not_direct_mapped + * is set. + * + * If neither flag is set (e.g. older Xen releases) the assumptions are: + * - not auto_translated domains (x86 only) are always direct-mapped + * - on x86, auto_translated domains are not direct-mapped + * - on ARM, Dom0 is direct-mapped, DomUs are not + */ +#define XENFEAT_not_direct_mapped 16 +#define XENFEAT_direct_mapped 17 + #define XENFEAT_NR_SUBMAPS 1 #endif /* __XEN_PUBLIC_FEATURES_H__ */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Mar 13 00:00:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 00:00:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97381.184998 (Exim 4.92) (envelope-from ) id 1lKrhz-0002L4-FZ; Sat, 13 Mar 2021 00:00:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97381.184998; Sat, 13 Mar 2021 00:00:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKrhz-0002Kx-CO; Sat, 13 Mar 2021 00:00:43 +0000 Received: by outflank-mailman (input) for mailman id 97381; Sat, 13 Mar 2021 00:00:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKrhx-0002Kp-Ht; Sat, 13 Mar 2021 00:00:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKrhx-0003jm-3f; Sat, 13 Mar 2021 00:00:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKrhw-0004Dj-Na; Sat, 13 Mar 2021 00:00:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKrhw-0005sv-NB; Sat, 13 Mar 2021 00:00:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gDhv/bNVVANtfiydbmSikNqYfcAJqu0s79MuUW3Yho0=; b=mI3Ux/YL8fLjqJcPjQ9BNSbK2B hFoe91iolMEQBj8CgxfQ3G+wS6uFRkyzOMv8gqI22bmY27MexFM3BssPax17h8yt6P2ioBc0Niskx DMeaHCJL5Mu7hjmWUPmS2+gkOtqE+kyA9NoVFwjpU+ERumt6eeQVPwq8ZawnuJRs2d5o=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160002: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=6f34661b6c97a37a5efc27d31c037ddeda4547e2 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sat, 13 Mar 2021 00:00:40 +0000 flight 160002 qemu-mainline real [real] flight 160047 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160002/ http://logs.test-lab.xenproject.org/osstest/logs/160047/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 6f34661b6c97a37a5efc27d31c037ddeda4547e2 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 204 days Failing since 152659 2020-08-21 14:07:39 Z 203 days 390 attempts Testing same since 160002 2021-03-12 11:00:51 Z 0 days 1 attempts ------------------------------------------------------------ 443 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 126627 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 13 01:57:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 01:57:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97393.185013 (Exim 4.92) (envelope-from ) id 1lKtX7-0006Yf-5J; Sat, 13 Mar 2021 01:57:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97393.185013; Sat, 13 Mar 2021 01:57:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKtX7-0006Xt-1f; Sat, 13 Mar 2021 01:57:37 +0000 Received: by outflank-mailman (input) for mailman id 97393; Sat, 13 Mar 2021 01:57:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKtX5-0006UX-QN; Sat, 13 Mar 2021 01:57:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKtX5-00079q-Jt; Sat, 13 Mar 2021 01:57:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKtX5-0000UE-7r; Sat, 13 Mar 2021 01:57:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKtX5-00023D-7M; Sat, 13 Mar 2021 01:57:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HItPh50cFGSQu0IFStnPPiajVzB0ZimfXOiE6mOgcQA=; b=aDSVtmZDzXGojNjyW2AHO4gBUv ot7ZdutQtmPu6kLyAMSERHgib3C89tjXJN5sYD8mdPuBJdMOW4gr/Jjz8TEmP0fiz2qB3WrOrl42S OZHNczcPWVrPV+A/eRLO6te0w7M+NUo7Y/mGmHtnw6PmFNJMlyxrxLq+ifmaeY09t960=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160010: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f78d76e72a4671ea52d12752d92077788b4f5d50 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sat, 13 Mar 2021 01:57:35 +0000 flight 160010 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160010/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux f78d76e72a4671ea52d12752d92077788b4f5d50 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 224 days Failing since 152366 2020-08-01 20:49:34 Z 223 days 386 attempts Testing same since 160010 2021-03-12 12:30:13 Z 0 days 1 attempts ------------------------------------------------------------ 5187 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1285589 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 13 03:29:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 03:29:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97399.185028 (Exim 4.92) (envelope-from ) id 1lKuxn-0006vX-KT; Sat, 13 Mar 2021 03:29:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97399.185028; Sat, 13 Mar 2021 03:29:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKuxn-0006vQ-HM; Sat, 13 Mar 2021 03:29:15 +0000 Received: by outflank-mailman (input) for mailman id 97399; Sat, 13 Mar 2021 03:29:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKuxl-0006vI-LD; Sat, 13 Mar 2021 03:29:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKuxl-0000e7-EF; Sat, 13 Mar 2021 03:29:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKuxl-0005f1-34; Sat, 13 Mar 2021 03:29:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKuxl-0002kk-2Y; Sat, 13 Mar 2021 03:29:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JaEXP93834Oxim7FmMfnUZyhcn2ITMP9B0mEbUi+mHg=; b=XCu2Me9TdrTCJn8LxGcQ72oaAN BUZspKlvrbiWbdNu46unUPZfdd/E5bX7FNrCsA3WXT+OBjoQR8TbsXUeeESLmwn0YURRGlBnUdBlo NFszbyGq33sNBRfIwFY2KwGl8hJ6Gdy4EEHoYlsg16JyK50/UnfyRgj5HqUAyKjw+kn4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160048: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-amd64-pvgrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-i386-pvgrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=3f8d1885e48e4d72eab0688f604de62e0aea7a38 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sat, 13 Mar 2021 03:29:13 +0000 flight 160048 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160048/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 152631 build-amd64-xsm 6 xen-build fail REGR. vs. 152631 build-arm64-xsm 6 xen-build fail REGR. vs. 152631 build-arm64 6 xen-build fail REGR. vs. 152631 build-i386 6 xen-build fail REGR. vs. 152631 build-i386-xsm 6 xen-build fail REGR. vs. 152631 build-armhf 6 xen-build fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-amd64-pvgrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-i386-pvgrub 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-raw 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a version targeted for testing: qemuu 3f8d1885e48e4d72eab0688f604de62e0aea7a38 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 204 days Failing since 152659 2020-08-21 14:07:39 Z 203 days 391 attempts Testing same since 160048 2021-03-13 00:08:05 Z 0 days 1 attempts ------------------------------------------------------------ 444 people touched revisions under test, not listing them all jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-amd64-pvgrub blocked test-amd64-amd64-i386-pvgrub blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-amd64-amd64-xl-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-xl-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 127455 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 13 04:36:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 04:36:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97412.185059 (Exim 4.92) (envelope-from ) id 1lKw0W-0005CY-WE; Sat, 13 Mar 2021 04:36:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97412.185059; Sat, 13 Mar 2021 04:36:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKw0W-0005CR-Sz; Sat, 13 Mar 2021 04:36:08 +0000 Received: by outflank-mailman (input) for mailman id 97412; Sat, 13 Mar 2021 04:36:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKw0W-0005CH-EM; Sat, 13 Mar 2021 04:36:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKw0W-00022Y-7f; Sat, 13 Mar 2021 04:36:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKw0V-0000yX-Up; Sat, 13 Mar 2021 04:36:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKw0V-0007MF-UM; Sat, 13 Mar 2021 04:36:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wimLIoos0eZorshup3Q9RQ1FqaPoYwVVW6hTbTRwqJI=; b=0AQ3pg7CV3P9ZYeaRyWWA8IrYr PuEWa0dTSLdS5fcu6e4t+MMcwS5R5zIZcSKKtVhXyEFoeECjK+vU5Qk4hEbZstUPOUFMqyVAd/C4E gwDKYjSRnbEAoCHa1NdB4tySnZQke926ojXxbMp6C5uXlUDnpsqTlQlBQ9kbH0xWGhhc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160050: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-amd64-pvgrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-i386-pvgrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=3f8d1885e48e4d72eab0688f604de62e0aea7a38 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sat, 13 Mar 2021 04:36:07 +0000 flight 160050 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160050/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 152631 build-amd64-xsm 6 xen-build fail REGR. vs. 152631 build-arm64-xsm 6 xen-build fail REGR. vs. 152631 build-arm64 6 xen-build fail REGR. vs. 152631 build-i386 6 xen-build fail REGR. vs. 152631 build-i386-xsm 6 xen-build fail REGR. vs. 152631 build-armhf 6 xen-build fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-amd64-pvgrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-i386-pvgrub 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-raw 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a version targeted for testing: qemuu 3f8d1885e48e4d72eab0688f604de62e0aea7a38 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 204 days Failing since 152659 2020-08-21 14:07:39 Z 203 days 392 attempts Testing same since 160048 2021-03-13 00:08:05 Z 0 days 2 attempts ------------------------------------------------------------ 444 people touched revisions under test, not listing them all jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-amd64-pvgrub blocked test-amd64-amd64-i386-pvgrub blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-amd64-amd64-xl-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-xl-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 127455 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 13 05:46:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 05:46:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97426.185092 (Exim 4.92) (envelope-from ) id 1lKx6Y-0003nb-Qg; Sat, 13 Mar 2021 05:46:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97426.185092; Sat, 13 Mar 2021 05:46:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKx6Y-0003nU-Nh; Sat, 13 Mar 2021 05:46:26 +0000 Received: by outflank-mailman (input) for mailman id 97426; Sat, 13 Mar 2021 05:46:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKx6W-0003nJ-W0; Sat, 13 Mar 2021 05:46:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKx6W-0003Sq-QX; Sat, 13 Mar 2021 05:46:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKx6W-00046O-JN; Sat, 13 Mar 2021 05:46:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKx6W-0001vd-Is; Sat, 13 Mar 2021 05:46:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=z78YVn5/8rBtMt09Gd0DyvuE1nRhLDSYaN9U42zkwn8=; b=gmxTrUPjsuWufIHLx/KbhT3TDG HYOSOv0SCaqpljtex2LbGtdKTXvfWsd4JhI6/hOn7E/DnkJH31peUvRnSHukIItA76Y2Pk9NisALF pKURbd8/CK+KLsknXVLrsvNmDfdBjDFnSXV1Y2+imKmgJBSf6rv/w7trtGH9acI7BUQo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160053: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=52a937d8a2328c83018f0a69393b2840788c2d25 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 13 Mar 2021 05:46:24 +0000 flight 160053 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160053/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 52a937d8a2328c83018f0a69393b2840788c2d25 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 246 days Failing since 151818 2020-07-11 04:18:52 Z 245 days 238 attempts Testing same since 160053 2021-03-13 04:18:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 47222 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 13 07:16:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 07:16:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97441.185119 (Exim 4.92) (envelope-from ) id 1lKyVK-0003wr-B5; Sat, 13 Mar 2021 07:16:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97441.185119; Sat, 13 Mar 2021 07:16:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKyVK-0003wk-7I; Sat, 13 Mar 2021 07:16:06 +0000 Received: by outflank-mailman (input) for mailman id 97441; Sat, 13 Mar 2021 07:16:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKyVJ-0003wc-MB; Sat, 13 Mar 2021 07:16:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKyVJ-00051D-EZ; Sat, 13 Mar 2021 07:16:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKyVJ-0008HH-2G; Sat, 13 Mar 2021 07:16:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKyVJ-0003He-1o; Sat, 13 Mar 2021 07:16:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kG6CystWC/sXEg7KZeiLsuPGHwYn24n/2ANYARLE8KY=; b=GamPZ0sCi2Qq4XRKPnQuzW50VK T8GWG6d/Iyo2zK3/VLgDVDbNABmfabXyMRXFhr0IRWyBONMeKvy9XBsGzNDIWg6KGrcDy5rdaoiWU Jh+eyFhdWjKa/lk9WpKIs5y8G5cBTHbYz1IOf/wXbH6QmYbpxhapH6uN0OE8Ttl6+FEE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160057: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-amd64-pvgrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-i386-pvgrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=3f8d1885e48e4d72eab0688f604de62e0aea7a38 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sat, 13 Mar 2021 07:16:05 +0000 flight 160057 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160057/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 152631 build-amd64-xsm 6 xen-build fail REGR. vs. 152631 build-arm64-xsm 6 xen-build fail REGR. vs. 152631 build-arm64 6 xen-build fail REGR. vs. 152631 build-i386 6 xen-build fail REGR. vs. 152631 build-i386-xsm 6 xen-build fail REGR. vs. 152631 build-armhf 6 xen-build fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-amd64-pvgrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-i386-pvgrub 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-raw 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a version targeted for testing: qemuu 3f8d1885e48e4d72eab0688f604de62e0aea7a38 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 204 days Failing since 152659 2020-08-21 14:07:39 Z 203 days 393 attempts Testing same since 160048 2021-03-13 00:08:05 Z 0 days 3 attempts ------------------------------------------------------------ 444 people touched revisions under test, not listing them all jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-amd64-pvgrub blocked test-amd64-amd64-i386-pvgrub blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-amd64-amd64-xl-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-xl-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 127455 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 13 07:18:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 07:18:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97445.185133 (Exim 4.92) (envelope-from ) id 1lKyXI-0004CE-Ot; Sat, 13 Mar 2021 07:18:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97445.185133; Sat, 13 Mar 2021 07:18:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKyXI-0004C7-Ln; Sat, 13 Mar 2021 07:18:08 +0000 Received: by outflank-mailman (input) for mailman id 97445; Sat, 13 Mar 2021 07:18:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKyXH-0004C1-Um for xen-devel@lists.xenproject.org; Sat, 13 Mar 2021 07:18:08 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id aa71889a-7bad-411f-90a4-3f2b7533791e; Sat, 13 Mar 2021 07:18:06 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 95276AB8C; Sat, 13 Mar 2021 07:18:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa71889a-7bad-411f-90a4-3f2b7533791e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615619885; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tK+2KPlvdnxoxCN1IqL7t+VhSxDK3e++sQZ+b/LG2AQ=; b=L/i5OCvYOqP5D8uqCdbr4wLifKRpYhSZwRuy9BAND9qHO0TkH2ZyIJ3W7H2SdaezKm3IlS lKv0dr5Tp9lWduplvIMQJTCIkdFwZLDnrmziHuWD/ceJJFJfPMgmiEjupxId3SUTGmI9Ca czHk9+lAdJkv0wWyDSdFx/2XppuEAq8= Subject: Re: Linux DomU freezes and dies under heavy memory shuffling To: Roman Shaposhnik Cc: Stefano Stabellini , Xen-devel , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap References: <45b8ef4c-6d36-e91b-ca1a-a82eeca5aaf5@suse.com> <49344e8d-5518-68c6-a417-68522a915e72@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Sat, 13 Mar 2021 08:18:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yV3e29qlJVkORLytCzreFdCYGTtHvPy3w" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --yV3e29qlJVkORLytCzreFdCYGTtHvPy3w Content-Type: multipart/mixed; boundary="Th5NOkwgHWvSfXtUiZgknvENl1HWsptWi"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Roman Shaposhnik Cc: Stefano Stabellini , Xen-devel , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap Message-ID: Subject: Re: Linux DomU freezes and dies under heavy memory shuffling References: <45b8ef4c-6d36-e91b-ca1a-a82eeca5aaf5@suse.com> <49344e8d-5518-68c6-a417-68522a915e72@suse.com> In-Reply-To: --Th5NOkwgHWvSfXtUiZgknvENl1HWsptWi Content-Type: multipart/mixed; boundary="------------54DB922F4707F86C347D4B5C" Content-Language: en-US This is a multi-part message in MIME format. --------------54DB922F4707F86C347D4B5C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 12.03.21 22:33, Roman Shaposhnik wrote: > Hi J=C3=BCrgen, >=20 > just wanted to give you (and everyone who may be keeping an eye on > this) an update. >=20 > Somehow, after applying your kernel patch -- the VM is now running 10 > days+ without a problem. Can you check the kernel console messages, please? There are messages printed when a potential hang is detected, and the hanging cpu is tried to be woken up via another interrupt again. Look for messages containing "csd", so e.g. do dmesg | grep csd in the VM. Thanks, Juergen >=20 > I'll keep experimenting (A/B-testing style) but at this point I'm > actually pretty perplexed as to why this patch would make a difference > (since it is basically just for observability). Any thoughts on that? >=20 > Thanks, > Roman. >=20 > On Wed, Feb 24, 2021 at 7:06 PM Roman Shaposhnik wro= te: >> >> Hi J=C3=BCrgen! >> >> sorry for the belated reply -- I wanted to externalize the VM before I= >> do -- but let me at least reply to you: >> >> On Tue, Feb 23, 2021 at 5:17 AM J=C3=BCrgen Gro=C3=9F wrote: >>> >>> On 18.02.21 06:21, Roman Shaposhnik wrote: >>>> On Wed, Feb 17, 2021 at 12:29 AM J=C3=BCrgen Gro=C3=9F >>> > wrote: >>>> >>>> On 17.02.21 09:12, Roman Shaposhnik wrote: >>>> > Hi J=C3=BCrgen, thanks for taking a look at this. A few comm= ents below: >>>> > >>>> > On Tue, Feb 16, 2021 at 10:47 PM J=C3=BCrgen Gro=C3=9F >>> > wrote: >>>> >> >>>> >> On 16.02.21 21:34, Stefano Stabellini wrote: >>>> >>> + x86 maintainers >>>> >>> >>>> >>> It looks like the tlbflush is getting stuck? >>>> >> >>>> >> I have seen this case multiple times on customer systems no= w, but >>>> >> reproducing it reliably seems to be very hard. >>>> > >>>> > It is reliably reproducible under my workload but it take a = long time >>>> > (~3 days of the workload running in the lab). >>>> >>>> This is by far the best reproduction rate I have seen up to now= =2E >>>> >>>> The next best reproducer seems to be a huge installation with s= everal >>>> hundred hosts and thousands of VMs with about 1 crash each week= =2E >>>> >>>> > >>>> >> I suspected fifo events to be blamed, but just yesterday I'= ve been >>>> >> informed of another case with fifo events disabled in the g= uest. >>>> >> >>>> >> One common pattern seems to be that up to now I have seen t= his >>>> effect >>>> >> only on systems with Intel Gold cpus. Can it be confirmed t= o be true >>>> >> in this case, too? >>>> > >>>> > I am pretty sure mine isn't -- I can get you full CPU specs = if >>>> that's useful. >>>> >>>> Just the output of "grep model /proc/cpuinfo" should be enough.= >>>> >>>> >>>> processor: 3 >>>> vendor_id: GenuineIntel >>>> cpu family: 6 >>>> model: 77 >>>> model name: Intel(R) Atom(TM) CPU C2550 @ 2.40GHz >>>> stepping: 8 >>>> microcode: 0x12d >>>> cpu MHz: 1200.070 >>>> cache size: 1024 KB >>>> physical id: 0 >>>> siblings: 4 >>>> core id: 3 >>>> cpu cores: 4 >>>> apicid: 6 >>>> initial apicid: 6 >>>> fpu: yes >>>> fpu_exception: yes >>>> cpuid level: 11 >>>> wp: yes >>>> flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov= pat >>>> pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx rdt= scp >>>> lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology >>>> nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx= est >>>> tm2 ssse3 cx16 xtpr pdcm sse4_1 sse4_2 movbe popcnt tsc_deadline_tim= er >>>> aes rdrand lahf_lm 3dnowprefetch cpuid_fault epb pti ibrs ibpb stibp= >>>> tpr_shadow vnmi flexpriority ept vpid tsc_adjust smep erms dtherm id= a >>>> arat md_clear >>>> vmx flags: vnmi preemption_timer invvpid ept_x_only flexpriority >>>> tsc_offset vtpr mtf vapic ept vpid unrestricted_guest >>>> bugs: cpu_meltdown spectre_v1 spectre_v2 mds msbds_only >>>> bogomips: 4800.19 >>>> clflush size: 64 >>>> cache_alignment: 64 >>>> address sizes: 36 bits physical, 48 bits virtual >>>> power management: >>>> >>>> > >>>> >> In case anybody has a reproducer (either in a guest or dom0= ) with a >>>> >> setup where a diagnostic kernel can be used, I'd be _very_ >>>> interested! >>>> > >>>> > I can easily add things to Dom0 and DomU. Whether that will >>>> disrupt the >>>> > experiment is, of course, another matter. Still please let m= e >>>> know what >>>> > would be helpful to do. >>>> >>>> Is there a chance to switch to an upstream kernel in the guest?= I'd like >>>> to add some diagnostic code to the kernel and creating the patc= hes will >>>> be easier this way. >>>> >>>> >>>> That's a bit tough -- the VM is based on stock Ubuntu and if I upgra= de >>>> the kernel I'll have fiddle with a lot things to make workload >>>> functional again. >>>> >>>> However, I can install debug kernel (from Ubuntu, etc. etc.) >>>> >>>> Of course, if patching the kernel is the only way to make progress -= - >>>> lets try that -- please let me know. >>> >>> I have found a nice upstream patch, which - with some modifications -= I >>> plan to give our customer as a workaround. >>> >>> The patch is for kernel 4.12, but chances are good it will apply to a= >>> 4.15 kernel, too. >> >> I'm slightly confused about this patch -- it seems to me that it needs= >> to be applied to the guest kernel, correct? >> >> If that's the case -- the challenge I have is that I need to re-build >> the Canonical (Ubuntu) distro kernel with this patch -- this seems >> a bit daunting at first (I mean -- I'm pretty good at rebuilding kerne= ls >> I just never do it with the vendor ones ;-)). >> >> So... if there's anyone here who has any suggestions on how to do that= >> -- I'd appreciate pointers. >> >>> I have been able to gather some more data. >>> >>> I have contacted the author of the upstream kernel patch I've been us= ing >>> for our customer (and that helped, by the way). >>> >>> It seems as if the problem is occurring when running as a guest at le= ast >>> under Xen, KVM, and VMWare, and there have been reports of bare metal= >>> cases, too. Hunting this bug is going on for several years now, the >>> patch author is at it since 8 months. >>> >>> So we can rule out a Xen problem. >>> >>> Finding the root cause is still important, of course, and your setup >>> seems to have the best reproduction rate up to now. >>> >>> So any help would really be appreciated. >>> >>> Is the VM self contained? Would it be possible to start it e.g. on a >>> test system on my side? If yes, would you be allowed to pass it on to= >>> me? >> >> I'm working on externalizing the VM in a way that doesn't disclose any= thing >> about the customer workload. I'm almost there -- sans my question abou= t >> the vendor kernel rebuild. I plan to make that VM available this week.= >> >> Goes without saying, but I would really appreciate your help in chasin= g this. >> >> Thanks, >> Roman. >=20 --------------54DB922F4707F86C347D4B5C Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------54DB922F4707F86C347D4B5C-- --Th5NOkwgHWvSfXtUiZgknvENl1HWsptWi-- --yV3e29qlJVkORLytCzreFdCYGTtHvPy3w Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBMZywFAwAAAAAACgkQsN6d1ii/Ey8O +gf+Kg0jDRrWXlTiahlvfhgVN5giOaJVp8SR6iDyVBuld+pX5idEebMOjyO9/SiaZyHdaT+MCuZy n5+tajBjebZDgLlBDQEjfvH4pvJMCBiYbr/ckOHN1sAmyUMfF4nn820vhJIRFEAa1vs/IE/qkhhG W+PlvQsBhSROXFsW/ZTx/REhnLKWdmQsZzbtWLeT/EDEHeBiFeIvbW80nyMW8+jBq2NyK2WrsIbd mu3ft2auLlTnIKfpNuTYUaE+87HOQxQ2DBe1oaWbhNrIf/mvDXVWUc9N6Q50hohX2KclnUOnSr22 8+02/FA3ETuoFx/Rxr0IfNNXKF/xOgacrI6l8ut3zg== =rdqw -----END PGP SIGNATURE----- --yV3e29qlJVkORLytCzreFdCYGTtHvPy3w-- From xen-devel-bounces@lists.xenproject.org Sat Mar 13 07:27:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 07:27:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97452.185146 (Exim 4.92) (envelope-from ) id 1lKyg4-00058s-RC; Sat, 13 Mar 2021 07:27:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97452.185146; Sat, 13 Mar 2021 07:27:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKyg4-00058l-OE; Sat, 13 Mar 2021 07:27:12 +0000 Received: by outflank-mailman (input) for mailman id 97452; Sat, 13 Mar 2021 07:27:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKyg3-00058d-EJ; Sat, 13 Mar 2021 07:27:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKyg3-0005Bk-7G; Sat, 13 Mar 2021 07:27:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKyg2-00006v-SJ; Sat, 13 Mar 2021 07:27:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lKyg2-0007aC-Rn; Sat, 13 Mar 2021 07:27:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=u3isNbZ+b/NKXlB3htNWBYRUnzJGcbEeLleioZ2egV0=; b=EAshtlPF+jO9E+YswN7bqrZar4 9tPWVfqsYHUHTJUqddnfNga8pf2lyqWV6mwfm/oip1TGkzRqclRAddt+vjUub8ok/xmM73TgwS+U/ D0xvvw4A7OXifE+rTvyuj+fo3hFRqo3YbHmEuqtlCWkg44uMZY1sBCLiIqRJ4/v5hUJc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160045: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc46386d89d83c73c41c2b19be83a73957c4393 X-Osstest-Versions-That: xen=9e23f10eb0db5ffa06f1a43f74fac790992a85c7 From: osstest service owner Date: Sat, 13 Mar 2021 07:27:10 +0000 flight 160045 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160045/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159953 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159953 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159953 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159953 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159953 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159953 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159953 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159953 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159953 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159953 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159953 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 9dc46386d89d83c73c41c2b19be83a73957c4393 baseline version: xen 9e23f10eb0db5ffa06f1a43f74fac790992a85c7 Last test of basis 159953 2021-03-12 01:07:35 Z 1 days Testing same since 160045 2021-03-12 20:18:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Boris Ostrovsky Christian Lindig Dario Faggioli Igor Druzhinin Jan Beulich Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9e23f10eb0..9dc46386d8 9dc46386d89d83c73c41c2b19be83a73957c4393 -> master From xen-devel-bounces@lists.xenproject.org Sat Mar 13 08:39:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 08:39:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97470.185180 (Exim 4.92) (envelope-from ) id 1lKznM-000406-O6; Sat, 13 Mar 2021 08:38:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97470.185180; Sat, 13 Mar 2021 08:38:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKznM-0003zz-K8; Sat, 13 Mar 2021 08:38:48 +0000 Received: by outflank-mailman (input) for mailman id 97470; Sat, 13 Mar 2021 08:38:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKznK-0003zu-TW for xen-devel@lists.xenproject.org; Sat, 13 Mar 2021 08:38:47 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8af9ec36-a04c-4965-aa4c-41e61a04f093; Sat, 13 Mar 2021 08:38:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8af9ec36-a04c-4965-aa4c-41e61a04f093 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615624724; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=At6zORnsaDZVTnHRQQPeCyeV9TYUP3rdLONoe2WSYVQ=; b=UxpFDhmHEkTQo6qNFW5010GwSVQhOUYtxvsJUQdeCzLRNkv8RNO/8QXp Gn6VbO8tL+XGbvtbKTJ0BPelesBYe5oq7VkRcou5zO3VksU7TlYeXawAr ZXlnR+JTr7tFlHETVKrzIBlhS1PG/5NDtKCfNeWNWRNbVnj9oqCHYs+9b w=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 7L5Qxwlrr1k5vG7vLmNHHQlKz+KMSYJZyEGO1sl/rqyXenr/8w3pgADdmOBlBaYJP1QavJ4xYY g2Wb4/wplJpnh6rJWrJcHr/vfrhJxkTHf9bPgP2XHAmL8dm5AXhA9+cxuAQ91ThaLo8c6KUdMx cMnjpuPeX9efn8sAdGOmlsUD2Ap3JsZPoNwSwPa7f3VB70bhwT+0fHM9Ark7jgLWEBG9S/B1b4 brhi5hT+xqn8B8MJDgdq4JbbC51gwRinSwFfvLdgQm+O8ikwxxsnn5lVRPWst/7WrreUiHfW8v Cws= X-SBRS: 5.2 X-MesageID: 39386728 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:44l+RatsCcAHRj6MrqGXLkq37skDidV00zAX/kB9WHVpW+afkN 2jm+le6A/shF8qNE0ItPKhHO27QX3a/YNo+oV5B9yfdSTvpWfAFu5fxKT4xTmIIUPD38pQz7 1pfaQ7KPCYNykYse/f4A21V+kt28OG9qfAv4bj5kxgRw1rdK1shj0RYmz3LmRNWAJECZAlfa DshPZvmjzIQxQqR/X+Kn4ZX/XS4/3n/aiWBSIuNlocxk2jrR7A0s+eLySl X-IronPort-AV: E=Sophos;i="5.81,245,1610427600"; d="scan'208";a="39386728" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S6XlINfyCLi87pbG2uMtyAL491iZymEHnd3TGp+912k8BeZ3QfK2crYiextgXaaLHjDJS4JfmK0dfUAmlAcTAkuIExhFrhsRyEzWlECcxfknbXaNZanu0LjBn4Rt7aZjTreOgjecN0NARcocgzgZvZErpihCCLM5of+5VA9gC35YZehTA4h9Btu0/NOvwTei2a2IpuVPBeELnyhe3xUoubIVAU/XP3Kij67r09NYujGJ/uG8tIqcRoUm1R7XdaNbVG/zo8+Zjye92ftiUfiABSIjoYJ+Px0zmnfICkO97k7jmePRicF/p8Unp03JqKXk/UkPXqscBz+IVQ9eJgZE2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3dFlE965mmiTezsqVvDlA64nAs1eIQ7UUCYtINJGmHw=; b=ACLCiI20GRcM/oXrHYd+TNHMERBaaMxEOPv9nED513+4k3rOfPWMwDB9IWjOYvGK2yjd//xjgRHABLF4ynFrUfbrzn1S3TREFf7RjJBiM5h3aM+yZxxyjthdVyts3aKzPeSjp/nf9RvEcfNJdIvqYzFLOIYtLVn9hDfjhKdO8b/P1iFlHI3nI12hvHvqmHa8KJMSNdpm/FR+V6WsgOcvyPGlzfLyRb9tszgcaAQC7ULDmKJSmt6tmPwZuLlEJ/IAs51VE87oywtsBUpjWdSMfSdIzjGYpFEZ8ec9HmMhyYElojZOtmkXRRXhehvOT5drCXciGcgPnDPVZ8+yx2jsbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3dFlE965mmiTezsqVvDlA64nAs1eIQ7UUCYtINJGmHw=; b=GHeWJwORFPV19ERlbqpM7Fwpe3Y0QWPJoRuQt+4SlTmR1t6uWGkqsK3X6Ku0UsXqCGc3cPwab9337oerF2K1sgNZYLRvKU8Wo2dJ+j5WjmXQvKWPXwQa0wpzgu+V0hRsYb1jy8GTktVYyZhlp8q/Dq9gsctL8+TTyTuTHr93Z1g= Date: Sat, 13 Mar 2021 09:38:25 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Bob Eshleman CC: Xen-devel , Andrew Cooper , George Dunlap , , Olivier Lambert Subject: Re: Working Group for Secure Boot Message-ID: References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> X-ClientProxiedBy: MR2P264CA0115.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::31) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb35430c-bef6-49e8-e3f6-08d8e5fb62a7 X-MS-TrafficTypeDiagnostic: DM6PR03MB3484: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8GM0159708LEifPP6B9V5I+T1LGXpixGDqYdirPijkPd2aPd2jperE6hqoQOMMH/tAYqnpM96HDZMJS5eghWwEnd/JspDSLORbsZgVRaG7S5yzRV/Y0LHMt9RCaozkplRe5iwpJY69BF2WE0Rsm2emM81cvOqrT3GkKdEl52lk6aSf1yPn4kMSgDwqu1FPdOcNH5dYP9pgDYlxYdnhnXaroFqz67CaaDtHRP0G0PAPGaQt1vjOJB2Jb9jr6Dh4p0XvX5ltTQpnCUiVkXYL1uYy9NPYtbhaLy26jdWVUF5hbBlq9lw1mwRdOWh1FtCe0Omiq+bE/dgxrT0w/6kwPetICIifNoBNtzoG73f02WuR3LrUFlYTZKvYClfPGPxB2RlSuCtsoNGFUrHdNyP5/fvfw1uJb7tErNf8qbTyfJ0SzR4xWCBTqb+x8Oyk2ATTkSBpD4mbv0A4ON77n026WT2x/MvPCqh+iZJ/kiV0ppieKtY+H/p0OZIW9czydmyzFvTCleCfBh/4hjeLPuaQVHPg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(346002)(396003)(376002)(39860400002)(366004)(136003)(6666004)(4326008)(8936002)(4744005)(26005)(478600001)(54906003)(16526019)(8676002)(9686003)(186003)(66946007)(83380400001)(33716001)(2906002)(6496006)(6486002)(66476007)(5660300002)(66556008)(956004)(6916009)(316002)(86362001)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?a3RJaGJmb3NYMzNyNGtPZHBTUHZlTCsvSWthVGYwNnJBUnlUUmZ3MDIxNERT?= =?utf-8?B?VHlabXFsWGJlS054bnJTTWVQd0VUUHlIdmxwWmJKQ1gxL1c5Qkpwd3dyWGhM?= =?utf-8?B?aC9qNGlJMnlqYXlVbndqNUxmOEVDZDFZekxxd3JMUGdrdWFLalZZTXJSQ2xr?= =?utf-8?B?MTN5b1libHBQeFRUdU9xRzdLbG1KNkJwR1VHUmNmUVVUTjhtYU9xNzVpd2Jy?= =?utf-8?B?YmhqMGlrKzZuRW5ScHh3VzA0YXJ4NFBEcGlKL01makdsNkJSUGRiUGsxelZl?= =?utf-8?B?ZTVmdURLcDc4eWhaWFpzeVc0MUxRRWp6eTVEb2krcE1ZZlBlTlNGVnU5TC9D?= =?utf-8?B?QjZvUDVxTHVEcTRsY3pwUnN1NzBrTzQ5dTdLclI5S1BUMU1oRGIwaENSUE9w?= =?utf-8?B?VHlqaHJXLzZuZkpUTzVnY2o3UEJGV3dSNEo4VGZpcXRid2QzS3RYcDdVYlNj?= =?utf-8?B?UWVTYlhXSzlpSk13OXJPaFVJbDZvZVl6UXNOWkltYjJWUlFvcW1QUndHTVg2?= =?utf-8?B?UEFkdnhxL3c1aGwwSEd6TzdoejRMUjZJa1VmV21vUWdHUCtPUWVDSWV4QUhF?= =?utf-8?B?bVNzYnNwN1pVaEVJNkk5TFpibTU1VzlDTkNEK0RITUlJZXRnVmgwK0hJTlJv?= =?utf-8?B?UkJrby90Y0V6NDNkcks3elhIU2tLYWhWeEluZ2t0NERDeWhsdFBGU1QwN0M4?= =?utf-8?B?ekptNk5tNGxqMUFHVVNMNi9FMDFWYllkL2ZSbnZ3NWJYUTd0V3Z0a2dIYjBB?= =?utf-8?B?N05QQjREU3VUNVg0ejkzTE5qREtxK0Erc2R6RWtZZzRsYWxUSG9PWHhMZ1VF?= =?utf-8?B?UCtnT0Z3WitqbTU3d1l6N3A2SkpuOVNpNW9lbitXMGRRWnNLYmQ1Vk4vb3M1?= =?utf-8?B?ZEZJVEI5ME8xbkdkaWdJWlU2SEZKdzJDNjc2VDREaXhEZGtJWERzc2sxajRV?= =?utf-8?B?WWl3Z3pPTWozd2hzalF3SGU3V1FxUXgydlY0S053M0s3dldWWDlQZi94THM3?= =?utf-8?B?SXZDWFIyVjNOT0dPN09nbHh0RWdId1JvczJZQUV3TGMxK3lkb1JRSzlMLzl0?= =?utf-8?B?OGFYYnNXd1hFWHE5SGxMdk1KNitlNGJXenp5UTdXRFRHK1VUVUIrOXRjdC9r?= =?utf-8?B?OWk2NzdmTG4zYkM0bVhMS0w5QTJab3REZTNvdGF3UmVZVlgxaWVXLzlyM3NH?= =?utf-8?B?b0taUmJFT29JYm14YmpMSzg1NTNxTDlyOU1XRWV0K1NQWFRuSGFOSlVBRlR1?= =?utf-8?B?cUwvRWcycmR0R2hIbnUybkZEbFVqRVUzZXdBOUxDc2ZTMEJkNVBmSlF6YWlV?= =?utf-8?B?UU1yeUl2VnRFY3ZkaC9ZUVhibmwrektLY0I3MG1FQ2x0dDVSU0ttUitlczZj?= =?utf-8?B?d1l3VnpOVFV5Qy9tam41aU9SNVNDdTB0a2thajhCeUNkYXphS2tobzllSU5j?= =?utf-8?B?Y2J0ejVRM0JCbEIvMzdqT3RBZ2FscEtCNGNIdndnYTBMTmF3REZoRnk4QzJG?= =?utf-8?B?dDlXM3U1UlJaMlBGR1F6djBaL2hmWmtsYXdpUmxDS3Q1Vkl4U1h4S3FQcXBj?= =?utf-8?B?Ym90eDBwUEFnRUpDblJpK0ZjbnQzUHV6V2ZKZ1k5WitMTDBmZCtOdTFZMzc2?= =?utf-8?B?U1lmd1BJT1ZoQkYvTkx4Si9jeURDRWZ4a3FaZE04SHA4ZENUR0NiVm9lVTN2?= =?utf-8?B?ektPSEF6cVZldmxzR3JOTE12SVR0WUJSMHB0YlhpbzY0QU0veVQyelBTNmJr?= =?utf-8?Q?PnX8wvo8qGEhHxuYl9TnpBhV3ZYIKwbC8jRokpI?= X-MS-Exchange-CrossTenant-Network-Message-Id: cb35430c-bef6-49e8-e3f6-08d8e5fb62a7 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2021 08:38:32.9369 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QNjSqh8/hRdjVBx20DBz2H6KOzdRBH9EBnQ0vIZyIFVQAc92/lKRUCQxmypmEbBSA0b8kWFr/09y2tua19ntug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3484 X-OriginatorOrg: citrix.com On Thu, Mar 11, 2021 at 10:34:02AM -0800, Bob Eshleman wrote: > Hey all, > > We would like to start a working group for secure boot support in Xen > to coordinate the various interested parties and set out a plan for > the feature and its implications for the whole Xen system. > > The end goal is a full implementation that restricts the interfaces > dom0 has to affect Xen, akin to Linux's lockdown LSM. This implicates > important parts of the ABI (e.g., /dev/xen/privcmd/) and so will > require input from the greater community. > > I'm not familiar with how working groups function in the Xen project, > so this email also opens the floor for suggestions as to how this might > be managed. > > We'd love to hear from anyone interested in such a group and how the > community as a whole feels about such an effort. Please add me, if nothing else I need to at least to figure out if this could also be used for secure boot on FreeBSD. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Sat Mar 13 08:44:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 08:44:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97475.185192 (Exim 4.92) (envelope-from ) id 1lKzt3-0004sh-G3; Sat, 13 Mar 2021 08:44:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97475.185192; Sat, 13 Mar 2021 08:44:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKzt3-0004sa-Cy; Sat, 13 Mar 2021 08:44:41 +0000 Received: by outflank-mailman (input) for mailman id 97475; Sat, 13 Mar 2021 08:44:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKzt2-0004sV-8S for xen-devel@lists.xenproject.org; Sat, 13 Mar 2021 08:44:40 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1d2afef5-4a8e-44ea-8290-b61de988a5eb; Sat, 13 Mar 2021 08:44:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d2afef5-4a8e-44ea-8290-b61de988a5eb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615625079; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=QFR2kyZVjCh2iexxa0C1/EGEdKvvkrBkNB7ZjaBZgi0=; b=BMmSicOa1a6aRF84UMRVpFrMw3m4maSCneNC2g/3Uaa0ui1l6qbXKyVQ HagnGnX95ZVIec9WuTC9Yce5rZOL9qSjchuh9v9M39Fv8zUMOR9CAPGHY 8wri4XsLuJvIAHVuq0OwuOHjnTdbpaawXJAuxXVhWaTl0xKZ3jYH9sRAv Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: CLSdWHelAeFByVaj6N03MWwQMSErfydwk1jaNa2kP7BlDcnsUKNMv7hevfeFDB7fmkQ7sGXMjD rmvlGBP1YFusFOXE0AfdtdfxSFXFjjud/x7LEh/LzTxsgmHcxlEpjzaUHY2AHDTe1/h1mGVHCz m3vjLR6LeQKv6ScZKsS7ssX6OdfOaQ9qhS3fFl4+msuJyW7HXDrEu5SMadmB9ORLwAMmLSRGV1 IUA19qOTDwTvr2hhWw4B1bPcA+ELDQj7vzfSfph3g8YEtVpBA4+TySNkClCX3Uf1HTCA6iYk7b 35I= X-SBRS: 5.2 X-MesageID: 39386805 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:cMVGQ6jCbPDzK4agLzQOTWqLrHBQXkAji2hD6mlwRA09T+Wzkc eykPMHkSLugDEKV3063fyGMq+MQXTTnKQFg7U5F7GkQQXgpS+UPJhvhLGSoAHINg/f0qpm1a lme7VjE9GYNzNHpOvz/QXQKbcd6fad9qTAv4jj5lNMaS0vVK169Qd+DW+gfnFeYAVdH5I2GN 69y6N81l+dUE8aZMi6GXUJNtKrz7enqLvdfRUECxQ7gTPvsRqU7tfBfSSw71M5SDNAwbAr9E DfiAzn7qCfs/W2oyWss1Pu0w== X-IronPort-AV: E=Sophos;i="5.81,245,1610427600"; d="scan'208";a="39386805" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XANrLHQzVV3kO+aNy4eOUROWfgq34cPhnAgXYqMLGNXeDVmqa0sBifb8hKx9wO+R+e8wtLfGb9kzZkYXUeyLlb3RcFcz5K0NAC3tN4C5J0Ti/MlCXyJBg+cASOKAy1sR1iWMxg9zVeJuclmYCkqzytDZ+nrlCSvQ5+PdUnKe+aNCmObX5FrDfDoNyTiyBhQa/Gs0NN59wDuUD4o/M9m5nz07rBHvgSaU68e2/fx3rcqirWp8Qz4XSgDmNpvrbRB+LsPjsBafU1sxpeatyKZ8UGiY/Wd67hwzb2e6q+NNWn0ET/4E5fkGk6/rJ2n6hmmNHUf318qNNxZYNGe28E7pRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Dpyw74+07y/GB/ZGjhqnPscJ4yNC8UEefYTbR5KBPQ=; b=AmJ9z8LMZ7O1T64Sn5o7ZZ0wxjKoOo3lOXH/yvc3eQB/f9tUA0NOVkcvTxELyJbZosZStHZjqPXf54mAnzjkDTosyR+iZEQrQnQEvLfzWK+Zk/SMPLe2qnXly+VL4UvN31cwi7o7+yOfutXgP8v/hbmWkfEFu7AcWzf5Wtq5XBUOdA8j9kIcCRU7rmwcg1/R0v3ipk6hqZmZ4txKsAKHvpdwVZ/nFdDoW/rh7KAKIEV6u0kBwjYtbnkn5x12vfseWwobGRcmFIap0fG/7eVGNJRwvg5oFTkF5Kg2uSsz/fmjmG2iVX5fwSlH6WQZvINjATw7ghKw4VrkaCIIM8vUAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Dpyw74+07y/GB/ZGjhqnPscJ4yNC8UEefYTbR5KBPQ=; b=S4gTmSuAY6jjZ9LqEOWv64//KsQdVnjKN29vKdLq7HhT4z+d+rlIyD+a/7/dor6iODx3sXYRvxvBQ218xho1Scw+VQmq2BGcAgI+BgBJg3Qhw86NIo6dvpC4v/01Pmh6o+gLkmxcvO3o0EA4QaA+hKPeHPu5cwnSI0xb3kWHoak= Date: Sat, 13 Mar 2021 09:44:05 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Stefano Stabellini CC: , , , , Stefano Stabellini Subject: Re: [PATCH] automation: add arm32 cross-build tests for Xen Message-ID: References: <20210213013813.30114-1-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210213013813.30114-1-sstabellini@kernel.org> X-ClientProxiedBy: MRXP264CA0018.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:15::30) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1f7bdb4-bb14-4c04-8106-08d8e5fc2be4 X-MS-TrafficTypeDiagnostic: DM5PR03MB2636: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V9BWXrCYuVSURHzJihIfv/YoIx1P+up3l1vl1BE0urLN9RVbreapxvxBnLSfSFrxpicajjnRgFSWgjmhuavkpjvgDfacMdvwIDXYyvpMIWgUhcPKkAYtxe6+PVJkd6BjeMLK0TQsn7wInAcfIoaR/K5za16sytWFDzwbk3Flc88U9bAu/D72YI3LHehcCn11F7xCluVRuumRV1IqMfECOzgF3Ll4RqeGdYndPLbpM96/vDZwVX46xS0RAKz0LkpmMeFIqYh8iY+50OMongQR8tz1G3trgqwBjmPTkPsDISCeoIdULTdlfI28rBwkr9NBQNzSzv5eNpuRgbuuuYaXUEA0fLwENEaDNwhdQMsULjEeDpoMQToyY1is+I6CQb3Qsb7MyjAaOCiqjXFr3dikAXNcPdC6+1cFD1fxnz0y+2+crVkpaFqjlqO6Zq79ul3RYQ1clCd9j75mKmTRInK0UTP6YO1txVHykXgPnRkV20nf5+zDax+MHT3i/SmbdsC8hiF6RkEcWQx9wEN+CMnAEQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(396003)(366004)(346002)(136003)(376002)(39860400002)(6496006)(8676002)(86362001)(5660300002)(16526019)(66556008)(9686003)(66946007)(66476007)(26005)(6666004)(4326008)(2906002)(316002)(85182001)(6916009)(4744005)(6486002)(478600001)(8936002)(186003)(83380400001)(33716001)(956004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?blhjM21uYlNWODJSNTZodU1QZHRLOXhObzRIY2FkNUJKbUJZK09rMDhjcXJz?= =?utf-8?B?M3NTYk5rb2FNZ1ZLdFg4RS9vUC9yZWsvY0JRMzJVUWxCT2RVb2FwbjhSZjlx?= =?utf-8?B?eVQ1THEvZEV6dFVQeHhHN1YzcmVuYWp0Zk5WSTZWRHZNZWtBVWNYbTc0T3l1?= =?utf-8?B?WmNURGpUc09UYnZvK3VYVEFTamY0MFpEK3ZscFIxaWlkS1liSmhYNTYxNUwx?= =?utf-8?B?ZStnc3ZuSjkybjRZZitZc0RJajROVEMrUUJjUGxURWFZRE80dXVrN1cxd01E?= =?utf-8?B?QkF3MjFUdWhqY2Nldno1VEtmWWJaS1V6VkJCZEJRR2pWb05FQWVqZDgzSENx?= =?utf-8?B?V3B4MzR5ZkNyZ045RUN2QVByQ1BmVXgrSStHN2U5bUhoMGx3V2Y0cE12VkJn?= =?utf-8?B?cEFnYkpNNFdDZVhKeTQvcGZPMFdDVmFOZ04rK2VYc3lGMW1iN0s1L2dQVWUy?= =?utf-8?B?amtUVFBKR21zM25ha1N1d2JFVHRYNjdJUlNwMUxlLzFZUnUxdTZYaFowZWdy?= =?utf-8?B?NFJuZFdaQk5EbE1WWmRHeUtLZkZCN3l3ME1tRjlGc3dZMUJyZFRrdmJUTThQ?= =?utf-8?B?SGgvSnR6bWxrbkhRTGJTQWNMN2VkY1ptK2ViMEtQTGRDVXFMMDgzRmRrdm9V?= =?utf-8?B?Z0tTZVAxNG83RzVxb0VsQXJ2ZTRNdjdqdlJacDF5QnlFd2xDaXlIMlNKUEd0?= =?utf-8?B?ZXJuejR0RmN6TEQxNnNwcXpYRWw1OFZlL0NTTnNqTEJjMWhnTVRiVGVEVTBm?= =?utf-8?B?SHlyUEhFRUNpL1lJVkhhNVpXdVFrR3FlLy90R1FTbXFFd0kwUDd1SEJNaGFm?= =?utf-8?B?elRmL081dllhTkJxU3BTQTUzdE1vTEowaXJHVm5TOW0xT1B2d2N3UXV2aEZP?= =?utf-8?B?eGd1d2M3YU1pVWJoc1lKTzA4WUtacFJ5Y3ZLQTlZS1BmVjU1VUc4aGJmT0l0?= =?utf-8?B?VldGdWliaDAvaWpya2UzU0FjOC9pRGY3YzJjdGxiZURDRTkwTHd4UUk1d3Zq?= =?utf-8?B?K0gzb3o4SFBVd1gyZGRpN1FEMFk0K2YzWkMrYXhyV3ZMOEVDTldQRkVGQnVv?= =?utf-8?B?NElrL3lpamIrMnNmQ0RXaFlPSElVQWQ1SXRuczVqUVZFY1JGeTlmZ295Sk1r?= =?utf-8?B?UXN5cnJwOFNqSGxxUG4wV0M2S3RVMHNBekp1Z0szc0dTeWZpUTRuK1N0V0hZ?= =?utf-8?B?YzQvL2F3WG15RTJ3Y0wxSEtaRWFFbHNmTFNzeUw4dG8yV0dVWmpmUW9KZkpq?= =?utf-8?B?Um9zd3ZoRnFaQVErMEZsUkpvaFJsL1NxK2xFK3Z4SU00aTcyMGJSbkJYWlp1?= =?utf-8?B?cnlDelU2Y2dTQTJkdVliZ1hRNjdIanNacWozYTkxR3dRcHlpb1YxME1BK0hY?= =?utf-8?B?ZzRKTHVVUGxVdE9pM1kyVVZsckl0Q29YRTczY2hNT29WZlZwQURjNHVQUlAz?= =?utf-8?B?MXFwdko4ODhBcVMxRkFZK3FscWtEcU9xajZDd2ZzZzluNFcvY3FhQjk2YmFz?= =?utf-8?B?UjgwUWxWNlVkb2tBeGllVkE4ZE1sTDRMMEJEdXY4Z0xIRFpVOFdBTXI4N2lk?= =?utf-8?B?YVVPQ2NQSlpTQmZXRnRDU0tnekR1NzVuWXpCdWtNU2NCbFZENGZCNVpXMkN4?= =?utf-8?B?VW1rRlgwRHAvaG9hUnZNQnVrYVZWSUl4TzB3MkJIeXpCUTUyUkkycUFZYmZq?= =?utf-8?B?TVZtbzRzWDRvemdDOCs5VG0zNDluZlhCaW0rRWhxREx6QnVuSE4xV1Rka0o1?= =?utf-8?Q?y63RBPMlWeWoSyzGByUYWBevJk3ak0sBv25Ey/I?= X-MS-Exchange-CrossTenant-Network-Message-Id: b1f7bdb4-bb14-4c04-8106-08d8e5fc2be4 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2021 08:44:10.5482 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oCYmExOVt3y7MzeUlEH0BofZ5HpnfsDaEXBCSCfJ/5WOUqEETlLr919ZTTBhBlwZDNxc3Ng3kqkjC/R9khIwcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2636 X-OriginatorOrg: citrix.com On Fri, Feb 12, 2021 at 05:38:13PM -0800, Stefano Stabellini wrote: > diff --git a/automation/scripts/build b/automation/scripts/build > index d8990c3bf4..e7d68f7a9d 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -15,6 +15,15 @@ else > make -j$(nproc) -C xen defconfig > fi > > +# arm32 only cross-compiles the hypervisor > +if [[ "${XEN_TARGET_ARCH}" = "arm32" ]]; then > + make -j$(nproc) xen > + cp xen/.config xen-config > + mkdir binaries > + cp xen/xen binaries/xen > + exit 0 > +fi You will have to rebase on top of 893103e286ac1c50 at which point you have an option to do hypervisor only builds already (hypervisor_only). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Sat Mar 13 08:49:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 08:49:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97478.185203 (Exim 4.92) (envelope-from ) id 1lKzxu-00059u-4B; Sat, 13 Mar 2021 08:49:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97478.185203; Sat, 13 Mar 2021 08:49:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKzxu-00059n-18; Sat, 13 Mar 2021 08:49:42 +0000 Received: by outflank-mailman (input) for mailman id 97478; Sat, 13 Mar 2021 08:49:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKzxs-00059i-K4 for xen-devel@lists.xenproject.org; Sat, 13 Mar 2021 08:49:40 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fe5ec202-1663-46b1-9d57-c2159c57a447; Sat, 13 Mar 2021 08:49:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe5ec202-1663-46b1-9d57-c2159c57a447 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615625379; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=GYZw0Inn0A+dAA6N63MYM5HJGsFiUCGFIUFAUotoqr8=; b=aXFIpYnOC4jd5zab/91fz7s7uAb6nBe4ZMWCPZOKVdDw9p6RQQ3fhhLa SQYRpRSnPxKwblEgxspco7eoAobAr6IUO3tjqgvkD4mSHczBEeZUgABJ+ Kx+IksvI+kQEUfs+oBzHQkC4SiPC+sRmShtOyb+K5+QB47yP3fC2qj2fJ U=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: QYQqg+/hXoz8wK5jCl0pKX45/Gif8AAovgR/Xu682LZM/D03w58TiQ3BF29baDvKS3PJzH/+Dr JJ8pQSYn0nsGXxNFFyA3P9Dtss1X1b27+T3Rsxf5diIxUDuRdIljLwxiVUVeoqZ4MvFjsmvyDP NMN/GDP9SayYxvAwT21KiFv7Puwz5Irm2ihazQ4NsaOdF5Z8dYUwiVQvmqi8w89q+CIY+P13aK WP2k0pTz+UBTQmhK+CBskWq4LNNVXbi6SR6xhOsvgOkIKNAHpDMDdeG8KU28peh90wpyEKhsw2 tKQ= X-SBRS: 5.2 X-MesageID: 39386861 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:7XvOdKAovEbheBrlHehRtMeALOonbusQ8zAX/mhLY1h8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPufVr1zrQwxYUKJ7+tUE3duGWuJJx/9oeK+VHdMgXE3Kpm2a 9kGpISNPTZEUV6gcHm4AOxDtYnx529/Lq1gPrFpk0NcShBQchbnmBEIyycFVB7QxQDKJoiDZ yH5tdGoT3IQwVsUu2QAH4ZU+/f4+DajZ6OW298OzcLyimryQmp5rnzDgSC0n4lPQ9n7L8+/Q H+4m7Ez4q5tfXT8G6460by6NBslMLl2p9/AqW3+7UoAxHNrirtW4h7Qb2Fu1kO0ZCSwXInis PFrRtlH+kb0QKpQkiPrRHg2xbt3V8VgheIoz/o4gqRneXDSD03EMZHj45CGyGpk3YIh91gzL lNm1uQqps/N2K/oA3G+9PKWxt2/3DEx0YKrOh7tQ06baIuLJVVrYAZ4XpPFoYBEC/Q+OkcYZ ZTJfCZy/BMfVyAaXfF+kFp3dy3R3w2WiyLW04Yp6WuonJrtUE863Fd6N0Un38G+p54Y55Y59 7cOqAtsL1VVMcZYY90Ge9pe7r7NkX9BTb3dE6CK1XuE68Kf1jXrYTs3bkz7Oa2PLQV0Zobgv 36IR1lnF93X3irJdyF3ZVN/ByIan66Ry7RxsZX4IU8kqHgRYDsLTaIRDkV4oSdisRaJveed+ e4OZpQDfOmB3DpA5x10wr3XIQXBmIZVOETp9YnS3ODqs/GMeTRx6zmWceWAICoPScvW2v5DH dGdiP0Pt984keiXWK9oBW5YQKvRmXPubZLVITK9ekaz4YAcqdWtBIOtFi/7saXbRlLsqk8el pCMKrq+5nL51WezCLt1SFEKxBdBkFa7PHLSHVRvzIHNEvybPIlt8iAf3tRmF+KPAV2Qc+TMA M3nSU6xYuHa7irgQwyAdOuNWyXy1EJomiRcpsakqqfoeH/ep05CZ4icLdrFRrCEiF0nQoCkh YDVCY0AmvkUh/+g6Ssi5IZQMvFccNnvQutKclI7U7EuV6kvsEpTHsDVzuIWcqa6DxeAgZ8tx lUyesykbCAkTGgJS8ajP4jOFNBUmiRHYlLFR+IfolSh7DtdjxhVGviv03rtzgDPk7Rs2kCjG 3oKiOZPcvGBVdQoVh0+Kfn+lEcTBTVQ2tALlRB9aFtH2XPvXh+ldKRbq2oym2Ldx8p2ecGKg zIZjMUPyJjz926zwSuhT6HDHkqr69eetD1PfAGSfX01XysIoHTyv1DMP9Q4Zp/NNfh9sUMSv mSfgeJLDX+T8Mlsjbl00oNCW1Rkj0Dl/it5TjOqE6f91Q7CeDJIFtnS6oASuvsmVTMdrKt6t FBkdkxveGMKW3/Zd6N9LHPY1d4W2HuiF/za9ttlItdsq0zvoZiBpX3UTPH03dcwRU1Rf2E4H 82ceBe4LrbPJVocNFXUyVF/kAxnNDnFjpijiXGRss/d0oqlXnVIpeg5KfJs6MmBgmkqBHrMV eStw1b8PGtZVrJ6ZcqT4YxK39Rck4y9TBL+/6DbZTZDEGSTN54lWDKRUOVQft6U6iKGbIZsx Z87ZWppoasBlbF8TGVmyB6LKJI+3ugWuWoDmu3aKl1z+A= X-IronPort-AV: E=Sophos;i="5.81,245,1610427600"; d="scan'208";a="39386861" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f5wWU5RE2gBBByO8Bq1pN/68VD08qKg9x5t75Knf4T5LVDqD7NZPztfvxLtvtxTl7b+7D9LHbrJEhUvkrE3emn0rOf/uteOf+8XdhaL/ZL5kTzz1Sp15tCXGBpZA0fC4R8/CN7IO9WBFeuWcDI/ct/YlXYyBfJ1rTI+BMsBUtZhbBwHHMspix1mzb9fTr/O1GpCPe2OGY5bLqPSVB6hZozfWV1hOo/BZbZ2lhRVDiztRGMtfzUvxh9KGl63sOsW7SAys0QZa+o63AADfrFPh614TYwc389l2G15G+Cmcqc0Dmcs22RIPwbgzUi/odfJjMIJXoO0JZmPzd7L6GMPVsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xH4fv7MBovRaRkdZkZScVDR+CihwIO0TVP4bEb/CRh4=; b=jw3THWxXLcDUYLPNKIkXw06qX2QfuFOhChTSSaLbslt3+wMj+pKzgbMrGRod8mI7pjsykuGqP8VMH2AwrVcabamLHurgm0V5as0ED7E/GuYM0cS6MP6PeaOscA73RXxlQibHhl8PRuANceb9UUbhxdlLPV1d2+9osFxIQ1ILWMimuvW2TCNUXmfp0YMPy3aF88klUOBf5edI0xzW9qs+uRtHIbN2/Qv8cR6huOKRe3sJP28LYjZ5trjspBqaafuOeAZxq7vAfb8mHix7467of6icjFM4yKBw9N+o/mgkLuE5XYZjjANIArDTH37ERwEzj3Bf5uEFF30mrOPOrzBZ8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xH4fv7MBovRaRkdZkZScVDR+CihwIO0TVP4bEb/CRh4=; b=bpth6f5wQpVc3HyHfI1LBXO4vpcNGSoJqPd/hNaWdXTcUUILwe1BbD9pcEKb+5x0uTl19xgXkO7dvSZaF0C6oxk7VcuNimth0AOGb2Gfw15Y3sor8jpbUBPOLqBh6E7B9TQy17LpLQqKnyjPpRY7hE6vKuPYslSULc02p9eNAfs= Date: Sat, 13 Mar 2021 09:49:09 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Stefano Stabellini CC: , , , , Subject: Re: patchew - gitlab-ci notifications during the Xen 4.16 cycle Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MR2P264CA0050.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:31::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3a3c7e5b-df64-44d9-cc03-08d8e5fce1b5 X-MS-TrafficTypeDiagnostic: DM6PR03MB4971: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IHayFVwvJ9Ch8oNrwxHAY0JEL/26Cqh9OouEFxkvesFu3+l1zYjr498rqwmAazhGQI7GdyB0DXoE5lch8v3F23E/fBhK8K8jNmNAIK2v1VzhP0ZM4Lo6CNlGUrfZJCgd0jnRVDmEetUeqNyw0/40gRv12PpPZMzPewY59Ul2Q00uJS+tcvCZ3imvCAfN+Q+bNcZMV1z/KLztjdJLG8J5xwuBoIvwyJcoE3zRlfNaEF1lvjMEn5uaEub6CwRsvc/mlvHPzRPF64D6O7AzgBSBCV3KrJDvxvLkjyGNE2q2716iNU0W29BMUz54R7MKvhYuxCYD7ep7jnghOX57NZkAlgYoScINrJfHYXtIhLUz29TMnveIob0si/+6o3Kr+dU4PwBO6q0I9AtLSK4b5giLt1+cKJSOSeLaJZTtMMCTME6u8mIPjzEz1u8nUMRaV1YmSMFLGRyCk3mvjH03zJKSnJqUjVk2CF2OV9WGc1o7ql958nTk7emCtOn2HfaxyduCbhbDVsyZbHDVdm7mLtpO9wonBM9W1PjIqUGKRnGM8T65lcUNPbFP4QzCehliOOLGgGQRejKeOr/Mh+CjEklJCC5dgydkKVjxmDJDt4F6PRjiwN5rU3hWgTDButqpH96DQK7rgngNztLhABK2u+RAk+HEIvYFIhCSLB7F0s43kQOzDMzBaj/3qjvluy/Uetgu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(376002)(39860400002)(346002)(366004)(136003)(396003)(66556008)(85182001)(66476007)(66946007)(83380400001)(86362001)(16526019)(8936002)(6486002)(478600001)(8676002)(6916009)(5660300002)(9686003)(33716001)(2906002)(6666004)(6496006)(15650500001)(4326008)(26005)(186003)(316002)(966005)(956004)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?R0psQTFJQW9zL3RxRW5qZUF2TlppbDU2bmhidWhxckMyb1hFQkhVMzRoRC9L?= =?utf-8?B?ajhndXozZHBEWHhUekRjdEdXSlkzdG9UVDZqeHVLU3IxdEJCWEpPdU5QNkNB?= =?utf-8?B?bjZLallhdXgvZEdBd0wxbkx2S1FET2oyMGJUOGdBc1JZOEFVWSs3SFh2eWxj?= =?utf-8?B?M3ZTUEJ1VDAvSFB4N2lIclFueS9Ic3duOFZTQTFDdHl5b2lwWVFraDhydHVk?= =?utf-8?B?NEZ2c21hOTYxNHZvTnJOM1hyQUxwMTRteVZUNmxNNjBQaE9idEcyYTU5bkEz?= =?utf-8?B?RHlEaGpKMlZVaHQxZWY3STcvOUFFWUJTT1ljSFhTNW1JWndjRjZtbWZlYS9N?= =?utf-8?B?NWo3alRCTkZNODBMNzAzaEFYa25zeng3VS92OCtOaGo4LzlxZ0twZm4yR0x5?= =?utf-8?B?VkFYakNQbzhwWXViNk12SG13d1JwOW5Vb2ZBR3NRalkwZ2pGVExVbytFNEFs?= =?utf-8?B?Q25na2RpUG9MVTMrMFBNUlpxc1puMlBjd1ZmVWdRN3pBUnQ4OUxpODZTaDFR?= =?utf-8?B?WVYyKzl1VnhNZlM4RWxRRG9ZbDlLR3RFM3kwZVpRVEIzU2xSWVRIaDlXNGNp?= =?utf-8?B?a0xzb1RDVGFQeFJjdVBVQjV5U3NjZE1FL3pOYlA2akZ3NENHb2JZc2RlbVBI?= =?utf-8?B?aE13K0xFK0REblJuVHh0RWtLQ2UxTE1ObFZvaXVLeVBNVzBKWXZMSnlBU1RI?= =?utf-8?B?Q3JrOXgxeUNkWHZFTFRoY1R2Nm1BR2xxTHJYdFJaQ2pBS1dQRGN5alUydGg3?= =?utf-8?B?MjJ4MDF4dHE3Nmo1a2twL0MxZGYxVUFpOVp4NDZ6MW9XYmkyaHJnR0NjcnRz?= =?utf-8?B?NkJWM1NqVmlCNjdCTDVzTUJHNkxYaHVEdGFiRUdkVkRkZU5sU1FWRVY0aE1J?= =?utf-8?B?enYwMkhnTjRUbnlWOHZtcnBQaDJFOU1DdFI5UkRBT1FMdHM2TzJRQk84ZU1W?= =?utf-8?B?Ni8yclhuM3puamNmT0ZGYzBvR0xPZmxSbFJlTUVHNjI1elpnMGNac3RPMG0v?= =?utf-8?B?Zi9uQitmK0Z6emsvSDVyT2lnc3AxVTNOaG1QOTA5QU1tV001YUtleVNqMGJ3?= =?utf-8?B?UC9IMlNIRkRTYk9IUWh0dWU5bGNoQnY5cDlldGMzZEhZelUySmk1NFdaL1hO?= =?utf-8?B?Zk1wVTR4TEJaNjlaTGdMaUJSUHNpeTRncXcwTWZZNkJyeVhFdHNlODVWZGth?= =?utf-8?B?R2NZNUN6M0ZSTTRhQ3U1Q2N5STNLWlF6VHF3UHg1clBucmlxSWRSdEk4TmpT?= =?utf-8?B?NFRSK3F0Q0MveUFVUjZqbHdGWTFhTVlZQTQ3NllRWlNydmlEMWo3Nmt6N1V5?= =?utf-8?B?SFF6U0pyclJFbWdZeGYvd3hUTk1mOG4raTRWZVVJRnFBR3c3ZU5TbkRhVUVi?= =?utf-8?B?ZUdYSnJsR2RRT0tXOWVoeHdsL21sTHlnNkVUYUtvNzhYckl4VHhHZC9IMDI5?= =?utf-8?B?U1g2YVk2aHNxa0JiNmdHWU1aYXk1K2hhV3d0eVloNnROUlFlV1Q1UFRVMW4r?= =?utf-8?B?bjlzSHBWaFlNanoza2doejBoZENKbEc1SjcwRFhEZlM3Wkk1YWhmUy9RVkF0?= =?utf-8?B?Y3RjdWNRZ2ZrQXJMVmVxcmdvQk9ObmtKYnNuWCt2TURuczNqY2gvVUI4Nm5Y?= =?utf-8?B?d0EyalQwaDJmVElPS2JBZ2syY0ZPYTVRSVNHOUpJOXgwajJYcS9hNGxlUzhC?= =?utf-8?B?aXBjK1FKZnJPR09ROEljNTlQMzRmT29yY1R2aXNEYS9lSEhaZXdkcTZVMXJX?= =?utf-8?Q?JC2FEPaxFjYf4+WySavw7MsF2DXhf0eoDXM5G6Y?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3a3c7e5b-df64-44d9-cc03-08d8e5fce1b5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2021 08:49:15.6721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XmzDocsOvrj4VFcZtXMjEuutcDn9nvvSNOj93s+v3hloqJvP7WcZ4T7rdN/OoGIHjVvLoWfoust5EBWKlEExeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4971 X-OriginatorOrg: citrix.com On Fri, Mar 12, 2021 at 12:55:38PM -0800, Stefano Stabellini wrote: > Hi all, > > During the last 6 months we have been working on improving the Xen > Project gitlab-ci and patchew infrastructure. > > You can see the results from gitlab-ci tests on the staging branch here: > > https://gitlab.com/xen-project/xen/-/pipelines > https://gitlab.com/xen-project/xen/-/pipelines/269678673 > > In addition, and more interestingly, now we have patchew integration. > Patchew picks up patch series sent to xen-devel by any contributor and > commits them to branches under this repository: > > https://gitlab.com/xen-project/patchew/xen > > Then, gitlab-ci tests start automatically. Patchew waits for the results > and send a notification email. You can see patchew pipelines here: > > https://gitlab.com/xen-project/patchew/xen/-/pipelines > > All this typically happens before patches are even reviewed. Today the > patchew notification emails are only sent to us in the Gitlab-CI working > group. But the good news is that we think the results got to the point > where they are reliable enough that it would be good to share them with > the community. I'm not opposed to that, but we seem to have some random git clone failures during builds (at least on the x86 side), that are more frequent that expected. At least recently I had trouble getting a full gitlab CI pipeline run that didn't hit one of those. I will try to figure out what's going on by adding some more debug to git to see if I can get more verbose information from git on exactly what's failing. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Sat Mar 13 09:42:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 09:42:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97485.185216 (Exim 4.92) (envelope-from ) id 1lL0mk-0002Bf-Vf; Sat, 13 Mar 2021 09:42:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97485.185216; Sat, 13 Mar 2021 09:42:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL0mk-0002BY-SN; Sat, 13 Mar 2021 09:42:14 +0000 Received: by outflank-mailman (input) for mailman id 97485; Sat, 13 Mar 2021 09:42:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL0mi-0002BT-SH for xen-devel@lists.xenproject.org; Sat, 13 Mar 2021 09:42:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL0mg-0007tg-6d; Sat, 13 Mar 2021 09:42:10 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lL0mf-00032u-UA; Sat, 13 Mar 2021 09:42:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=EI6jRllVztx1sEsLt3SeOq/NfAZsBEPAvZ/UsXhhhJA=; b=3Wm8GInonj1aUeLP5Pkg9Yt/TU Uq8+blfi6wc2daOTRB9BzBtTrYCcJQqsmMHKd7EzJOR+FR3trkcaJj8gpQKpKbPHd/bd2cYlwFH0x A/7GHs2xX2fky+gDFDXXxTmxZgR20SPffT4SGSbevgH9m0HC93FIKHyz7lGWz8TOKA7Y=; Subject: Re: [PATCH v3] xen: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, Bertrand.Marquis@arm.com, Stefano Stabellini References: <20210312231632.5666-1-sstabellini@kernel.org> From: Julien Grall Message-ID: <57520732-e033-774f-4341-be19a07f5745@xen.org> Date: Sat, 13 Mar 2021 09:42:07 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210312231632.5666-1-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Stefano, On 12/03/2021 23:16, Stefano Stabellini wrote: > Introduce two feature flags to tell the domain whether it is > direct-mapped or not. It allows the guest kernel to make informed > decisions on things such as swiotlb-xen enablement. > > The introduction of both flags (XENFEAT_direct_mapped and > XENFEAT_not_direct_mapped) allows the guest kernel to avoid any > guesswork if one of the two is present, or fallback to the current > checks if neither of them is present. > > XENFEAT_direct_mapped is always set for not auto-translated guests. > > For auto-translated guests, only Dom0 on ARM is direct-mapped. Also, > see is_domain_direct_mapped() which refers to auto-translated guests: > xen/include/asm-arm/domain.h:is_domain_direct_mapped > xen/include/asm-x86/domain.h:is_domain_direct_mapped > > Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Mar 13 10:35:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 10:35:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97496.185235 (Exim 4.92) (envelope-from ) id 1lL1cE-00072G-6b; Sat, 13 Mar 2021 10:35:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97496.185235; Sat, 13 Mar 2021 10:35:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL1cE-000729-3B; Sat, 13 Mar 2021 10:35:26 +0000 Received: by outflank-mailman (input) for mailman id 97496; Sat, 13 Mar 2021 10:35:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL1cC-000721-JZ; Sat, 13 Mar 2021 10:35:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL1cC-0000PP-CI; Sat, 13 Mar 2021 10:35:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL1cC-0006ep-2o; Sat, 13 Mar 2021 10:35:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lL1cC-0002mF-2L; Sat, 13 Mar 2021 10:35:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=10X1rQRVu/DYjB7akVHUakQhBLM1UWed+amr3GUEPhA=; b=3xZK82846dgLpB3EdFDuqVl7JC Z45q1IU+ky9ONPo+MUKCT7sMCpJaUVpmUKrC7PpQHYjVCS8aeJgf1QQcSbzdU4geQEKIPo0V8E00A Vkl8FqIRp24Hi/g/mSrdxnB+D7cXuQVTZuWxTd9cgP9x5gKnHsObl5PowjWey54i9r4M=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160049: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f296bfd5cd04cbb49b8fc9585adc280ab2b58624 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sat, 13 Mar 2021 10:35:24 +0000 flight 160049 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160049/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux f296bfd5cd04cbb49b8fc9585adc280ab2b58624 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 224 days Failing since 152366 2020-08-01 20:49:34 Z 223 days 387 attempts Testing same since 160049 2021-03-13 02:00:29 Z 0 days 1 attempts ------------------------------------------------------------ 5201 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1288789 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 13 10:48:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 10:48:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97511.185267 (Exim 4.92) (envelope-from ) id 1lL1ow-0008L4-R8; Sat, 13 Mar 2021 10:48:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97511.185267; Sat, 13 Mar 2021 10:48:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL1ow-0008Kx-Mc; Sat, 13 Mar 2021 10:48:34 +0000 Received: by outflank-mailman (input) for mailman id 97511; Sat, 13 Mar 2021 10:48:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL1ov-0008Kp-On; Sat, 13 Mar 2021 10:48:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL1ov-0000bh-Gh; Sat, 13 Mar 2021 10:48:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL1ov-0007iF-8d; Sat, 13 Mar 2021 10:48:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lL1ov-0005p9-8B; Sat, 13 Mar 2021 10:48:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sQoBnBJ8Z0yazJ22qDZ8BMLy+cwA/CuVdBs7uaKEfgw=; b=W+yFb2Irknp1cTFOjQmchZtfBY Q+xK1edptczBlMeCPImE0LBBoPLYm+f8PbBwCRJnGX//cd8q8AaPQ8K+gr1sZPNLhIfDb9xMetbJg 1AIV0RQ3J+ZtcDf6PpkigIdpiretNzW4Ub6niI1TeMcmCo842Ym+WkMcnoIAGjTE3AlY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160062: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-amd64-pvgrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-i386-pvgrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=3f8d1885e48e4d72eab0688f604de62e0aea7a38 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sat, 13 Mar 2021 10:48:33 +0000 flight 160062 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160062/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 152631 build-amd64-xsm 6 xen-build fail REGR. vs. 152631 build-arm64-xsm 6 xen-build fail REGR. vs. 152631 build-arm64 6 xen-build fail REGR. vs. 152631 build-i386 6 xen-build fail REGR. vs. 152631 build-i386-xsm 6 xen-build fail REGR. vs. 152631 build-armhf 6 xen-build fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-amd64-pvgrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-i386-pvgrub 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-raw 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a version targeted for testing: qemuu 3f8d1885e48e4d72eab0688f604de62e0aea7a38 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 205 days Failing since 152659 2020-08-21 14:07:39 Z 203 days 394 attempts Testing same since 160048 2021-03-13 00:08:05 Z 0 days 4 attempts ------------------------------------------------------------ 444 people touched revisions under test, not listing them all jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-amd64-pvgrub blocked test-amd64-amd64-i386-pvgrub blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-amd64-amd64-xl-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-xl-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 127455 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 13 13:42:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 13:42:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97531.185282 (Exim 4.92) (envelope-from ) id 1lL4Wr-00080i-ID; Sat, 13 Mar 2021 13:42:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97531.185282; Sat, 13 Mar 2021 13:42:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL4Wr-00080b-F8; Sat, 13 Mar 2021 13:42:05 +0000 Received: by outflank-mailman (input) for mailman id 97531; Sat, 13 Mar 2021 13:42:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL4Wq-00080W-60 for xen-devel@lists.xenproject.org; Sat, 13 Mar 2021 13:42:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL4Wo-0003UQ-H0; Sat, 13 Mar 2021 13:42:02 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lL4Wo-0000Th-6K; Sat, 13 Mar 2021 13:42:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=X5LsG9ymoBz2OvK8Dyuay4FldkMlI9IsWMLmTitdIJY=; b=jUtNE9KtZiZA7NUGjvBYszMo0Q OJFCNEqhXmDZ349IxTaEHEeiC+afC+DQsMinJn33sMEXGQm+mA0MLV2AynJ3z3UMU0c9qIisnAZI+ 3r5Ifs++JnuQWmokETzZsELbhheH51K4GdrUeoPxKL6YE3vHUxeNTveAcAKaOuzXhXFk=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, volodymyr_babchuk@epam.com, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH for-4.15 v2] xen: Bump the minimum version of GCC supported to 4.9 for arm32 and 5.1 on arm64 Date: Sat, 13 Mar 2021 13:41:58 +0000 Message-Id: <20210313134158.24363-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall Compilers older than 4.8 have known codegen issues which can lead to silent miscompilation: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 Furthermore, pre-4.9 GCC have known bugs (including things like internal compiler errors on Arm) which would require workaround (I haven't checked if we have any in Xen). The minimum version of GCC to build the hypervisor on arm is now raised to 4.9. In addition to that, on arm64, GCC version >= 4.9 and < 5.1 have been shown to emit memory references beyond the stack pointer, resulting in memory corruption if an interrupt is taken after the stack pointer has been adjusted but before the reference has been executed. Therefore, the minimum for arm64 is raised to 5.1. Signed-off-by: Julien Grall --- This patch is candidate to 4.15 and backport. This is only a build change and will be low-risk for anyone using newer compiler (5.1+ for arm64 and 4.9+ for arm32). Xen will stop building for anyone using older compiler. But it is better than fighting with codegen issues. Changes in v2: - Only bump the GCC version for Arm. --- README | 7 +++++-- xen/include/xen/compiler.h | 10 ++++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/README b/README index 8c99c30986c1..aa8b4fe126a8 100644 --- a/README +++ b/README @@ -42,8 +42,11 @@ provided by your OS distributor: - GNU Binutils 2.16.91.0.5 or later or - Clang/LLVM 3.5 or later - - For ARM: - - GCC 4.8 or later + - For ARM 32-bit: + - GCC 4.9 or later + - GNU Binutils 2.24 or later + - For ARM 64-bit: + - GCC 5.1 or later - GNU Binutils 2.24 or later * Development install of zlib (e.g., zlib-dev) * Development install of Python 2.6 or later (e.g., python-dev) diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h index 0ec0b4698ea7..17cf00e1ec92 100644 --- a/xen/include/xen/compiler.h +++ b/xen/include/xen/compiler.h @@ -3,6 +3,16 @@ #if !defined(__GNUC__) || (__GNUC__ < 4) #error Sorry, your compiler is too old/not recognized. +#elif CONFIG_CC_IS_GCC +# if defined(CONFIG_ARM_32) && CONFIG_GCC_VERSION < 40900 +# error Sorry, your version of GCC is too old - please use 4.9 or newer. +# elif defined(CONFIG_ARM_64) && CONFIG_GCC_VERSION < 50100 +/* + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk + */ +# error Sorry, your version of GCC is too old - please use 5.1 or newer. +# endif #endif #define barrier() __asm__ __volatile__("": : :"memory") -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Mar 13 13:55:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 13:55:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97535.185294 (Exim 4.92) (envelope-from ) id 1lL4jS-0000cq-OZ; Sat, 13 Mar 2021 13:55:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97535.185294; Sat, 13 Mar 2021 13:55:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL4jS-0000cj-Ld; Sat, 13 Mar 2021 13:55:06 +0000 Received: by outflank-mailman (input) for mailman id 97535; Sat, 13 Mar 2021 13:55:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL4jR-0000ce-36 for xen-devel@lists.xenproject.org; Sat, 13 Mar 2021 13:55:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL4jP-0003iA-VZ; Sat, 13 Mar 2021 13:55:03 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lL4jP-00019l-IB; Sat, 13 Mar 2021 13:55:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=pyaEz+9r3V6Dmziv7KgafVXgAmmD28nJLcQLfSvsft4=; b=hX8WnHCjuNYixNKROPZHFSQZls NM9HuV3fIYZbdOQHT2GbGeRHohCH2pTl4tyh717jcuTrPazGecynVhakSCKJyPXWoC54eMlKvyNLR Bq/PG7TfRLMSlCj3sAcJRfDd6Wmv63P9A7cG2hYKvcvyxMyE8hG0VE9TWRW5Z0vbeEjM=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Juergen Gross Subject: [PATCH for-4.15] SUPPORT.MD: Mark C XenStored LiveUpdate as Tech Preview Date: Sat, 13 Mar 2021 13:55:00 +0000 Message-Id: <20210313135500.27241-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall Support to liveupdate C XenStored was adding during the 4.15 development cycle. Add a section in SUPPORT.MD to explain what is the support state. For now, it is a tech preview. Signed-off-by: Julien Grall --- CC: Juergen Gross It looks like the OCaml side was not merged in 4.15. So I have only described the support state for C XenStored. --- SUPPORT.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index 7db4568f1a0f..39855f2c7b32 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -177,6 +177,10 @@ Support for running qemu-xen device model in a linux stubdomain. Status: Tech Preview +## C XenStored LiveUpdate + + Status: Tech Preview + ## Toolstack/3rd party ### libvirt driver for xl -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Mar 13 15:29:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 15:29:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97571.185305 (Exim 4.92) (envelope-from ) id 1lL6Cg-0000vO-NR; Sat, 13 Mar 2021 15:29:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97571.185305; Sat, 13 Mar 2021 15:29:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL6Cg-0000vH-KB; Sat, 13 Mar 2021 15:29:22 +0000 Received: by outflank-mailman (input) for mailman id 97571; Sat, 13 Mar 2021 15:29:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL6Cf-0000vC-8x for xen-devel@lists.xenproject.org; Sat, 13 Mar 2021 15:29:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL6Cd-0005IA-87; Sat, 13 Mar 2021 15:29:19 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lL6Cd-0007RP-1q; Sat, 13 Mar 2021 15:29:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=6PpD2QtjKJVCKF9Z4MznSD0DNfKnwqhdqX9Vn0Wnkh8=; b=4O5yisHfDbMVGDInDbSDi4/ROi 8SSjVxEE9XArzPCrRNRqbw9d+IA1Xu49O8BBctw9mTuSAkEsWMyhs+TbiFFsM+ROL+7PjfwQiGeBH 6tY+sFyT2h45vK4WU7PNTFctyNg1L4+VayHFLxIpvXJRZZBFKZV1vidiLf/UwGZ5XUAE=; Subject: Re: preparations for 4.13.3 To: Jan Beulich , "xen-devel@lists.xenproject.org" , Stefano Stabellini Cc: George Dunlap , Stefano Stabellini , Ian Jackson , Wei Liu , Anthony Perard References: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> From: Julien Grall Message-ID: Date: Sat, 13 Mar 2021 15:29:16 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan & Stefano, On 08/03/2021 09:49, Jan Beulich wrote: > All, > > the release is overdue (my apologies). Please point out backports > you find missing from the respective staging branches, but which > you consider relevant. > > Ones that I have queued already, but which hadn't passed the push > gate to master yet when doing a swipe late last week, are > > c6ad5a701b9a crypto: adjust rijndaelEncrypt() prototype for gcc11 > 9318fdf757ec x86/shadow: suppress "fast fault path" optimization without reserved bits > 60c0444fae21 x86/shadow: suppress "fast fault path" optimization when running virtualized I would like to also consider the following one: 28804c0ce9fd SUPPORT.MD: Clarify the support state for the Arm SMMUv{1, 2} drivers (4.11+ as updating the security support) 067935804a8e xen/vgic: Implement write to ISPENDR in vGICv{2, 3} (4.13+) To support newer kernel on stable Xen d81133d45d81 xen/arm: Add workaround for Cortex-A53 erratum #843419 (4.13+) fd7479b9aec2 xen/arm: Add workaround for Cortex-A55 erratum #1530923 (4.13+) 5505f5f8e7e8 xen/arm: Add Cortex-A73 erratum 858921 workaround (4.13+) 63b4c9bfb788 xen/arm: mm: Access a PT entry before the table is unmapped (4.13 only) f6790389613c xen/arm: sched: Ensure the vCPU context is seen before vcpu_pause() returns (4.13 only) I have put in parentheses the list of versions targeted. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Mar 13 16:06:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 16:06:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97576.185330 (Exim 4.92) (envelope-from ) id 1lL6mQ-00054P-V9; Sat, 13 Mar 2021 16:06:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97576.185330; Sat, 13 Mar 2021 16:06:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL6mQ-00054I-Ra; Sat, 13 Mar 2021 16:06:18 +0000 Received: by outflank-mailman (input) for mailman id 97576; Sat, 13 Mar 2021 16:06:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL6mO-00053G-QZ for xen-devel@lists.xenproject.org; Sat, 13 Mar 2021 16:06:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL6mO-0006R1-EL; Sat, 13 Mar 2021 16:06:16 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lL6mO-0001Ff-4b; Sat, 13 Mar 2021 16:06:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=5eKYsHX9wrqCSkZwcu/9vG6xXkJ79FPbMIThxl+msro=; b=st4j9HlvdtT5VnQK/lrhM16Eo p+d+sZIXHQ7eilsMOFfj5Gx1B5ezrBR8/EeDq5uIJkon6iIbU+uWT8TTE3GDtaAGpiQfe1olQzPAs JWDPKX6WtlPcbtMmu7yrai6PISY7f5C3QiqLZ92QthO9O3YsbKuP7Fz13LPcBSqs83qwY=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH for-next v2 1/2] xen/arm: Include asm/asm-offsets.h and asm/macros.h on every assembly files Date: Sat, 13 Mar 2021 16:06:10 +0000 Message-Id: <20210313160611.18665-2-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210313160611.18665-1-julien@xen.org> References: <20210313160611.18665-1-julien@xen.org> From: Julien Grall In a follow-up patch we may want to automatically replace some mnemonics (such as ret) with a different sequence. To ensure all the assembly files will include asm/macros.h it is best to automatically include it on single assembly. This can be done via config.h. It was necessary to include a few more headers as dependency: - to define sizeof_* - which is already a latent issue given STACK_ORDER rely on PAGE_SIZE. Unfortunately the build system will use -D__ASSEMBLY__ when generating the linker script. A new option -D__LINKER__ is introduceed and used for the linker script to avoid including headers (such as asm/macros.h) that may not be compatible with the syntax. Lastly, take the opportunity to remove both asm/asm-offsets.h and asm/macros.h from the various assembly files as they are now automagically included. Signed-off-by: Julien Grall --- xen/arch/arm/Makefile | 2 +- xen/arch/arm/arm32/entry.S | 1 - xen/arch/arm/arm32/head.S | 1 - xen/arch/arm/arm32/proc-v7.S | 1 - xen/arch/arm/arm64/debug-cadence.inc | 1 - xen/arch/arm/arm64/debug-pl011.inc | 2 -- xen/arch/arm/arm64/entry.S | 2 -- xen/arch/arm/arm64/head.S | 2 -- xen/arch/arm/arm64/smc.S | 3 --- xen/include/asm-arm/config.h | 6 ++++++ 10 files changed, 7 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 16e6523e2cc6..9ffc3f771c51 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -135,7 +135,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c $(CC) $(filter-out -flto,$(c_flags)) -S -o $@ $< xen.lds: xen.lds.S - $(CPP) -P $(a_flags) -MQ $@ -o $@ $< + $(CPP) -P $(a_flags) -D__LINKER__ -MQ $@ -o $@ $< dtb.o: $(CONFIG_DTB_FILE) diff --git a/xen/arch/arm/arm32/entry.S b/xen/arch/arm/arm32/entry.S index b228d44b190c..f2f1bc7a3158 100644 --- a/xen/arch/arm/arm32/entry.S +++ b/xen/arch/arm/arm32/entry.S @@ -1,4 +1,3 @@ -#include #include #include #include diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index c404fa973e9b..9084023a6ed9 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -18,7 +18,6 @@ */ #include -#include #include #define ZIMAGE_MAGIC_NUMBER 0x016f2818 diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S index 46bfc7a9074c..1efde2d72da0 100644 --- a/xen/arch/arm/arm32/proc-v7.S +++ b/xen/arch/arm/arm32/proc-v7.S @@ -17,7 +17,6 @@ * GNU General Public License for more details. */ -#include #include #include diff --git a/xen/arch/arm/arm64/debug-cadence.inc b/xen/arch/arm/arm64/debug-cadence.inc index 7df0abe4756f..0b6f2e094e18 100644 --- a/xen/arch/arm/arm64/debug-cadence.inc +++ b/xen/arch/arm/arm64/debug-cadence.inc @@ -17,7 +17,6 @@ * GNU General Public License for more details. */ -#include #include /* diff --git a/xen/arch/arm/arm64/debug-pl011.inc b/xen/arch/arm/arm64/debug-pl011.inc index 385deff49b1b..1928a2e3ffbb 100644 --- a/xen/arch/arm/arm64/debug-pl011.inc +++ b/xen/arch/arm/arm64/debug-pl011.inc @@ -16,8 +16,6 @@ * GNU General Public License for more details. */ -#include - /* * PL011 UART initialization * xb: register which containts the UART base address diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S index 175ea2981e72..ab9a65fc1475 100644 --- a/xen/arch/arm/arm64/entry.S +++ b/xen/arch/arm/arm64/entry.S @@ -1,6 +1,4 @@ -#include #include -#include #include #include #include diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 5d44667bd89d..fa7a3ffd2926 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -21,11 +21,9 @@ */ #include -#include #include #include #include -#include #define PT_PT 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ #define PT_MEM 0xf7d /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=0 P=1 */ diff --git a/xen/arch/arm/arm64/smc.S b/xen/arch/arm/arm64/smc.S index b0752be57e8f..91bae62dd4d2 100644 --- a/xen/arch/arm/arm64/smc.S +++ b/xen/arch/arm/arm64/smc.S @@ -13,9 +13,6 @@ * GNU General Public License for more details. */ -#include -#include - /* * void __arm_smccc_1_0_smc(register_t a0, register_t a1, register_t a2, * register_t a3, register_t a4, register_t a5, diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h index 5c10c755db46..51273b9db1fc 100644 --- a/xen/include/asm-arm/config.h +++ b/xen/include/asm-arm/config.h @@ -69,6 +69,7 @@ #endif #include +#include /* * Common ARM32 and ARM64 layout: @@ -190,6 +191,11 @@ extern unsigned long frametable_virt_end; #define watchdog_disable() ((void)0) #define watchdog_enable() ((void)0) +#if defined(__ASSEMBLY__) && !defined(__LINKER__) +#include +#include +#endif + #endif /* __ARM_CONFIG_H__ */ /* * Local variables: -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Mar 13 16:06:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 16:06:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97575.185317 (Exim 4.92) (envelope-from ) id 1lL6mP-00053S-MO; Sat, 13 Mar 2021 16:06:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97575.185317; Sat, 13 Mar 2021 16:06:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL6mP-00053L-J4; Sat, 13 Mar 2021 16:06:17 +0000 Received: by outflank-mailman (input) for mailman id 97575; Sat, 13 Mar 2021 16:06:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL6mN-00053B-SY for xen-devel@lists.xenproject.org; Sat, 13 Mar 2021 16:06:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL6mN-0006Qw-Fg; Sat, 13 Mar 2021 16:06:15 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lL6mN-0001Ff-0z; Sat, 13 Mar 2021 16:06:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=OiaaY8Ipo2EWvkLByzV6dgLZ0290eAYdoAl27NRpKL8=; b=lF2SY2TSQJb6MEEbIWlItDhbB1 yowEdMkWaIAhjEisw2XbRZM0INs4zxDmpOWB3bGGUBBXy2Z7HrOnq9ihysWp4gpMmhJ0UjOXEkPpw x6l00G9swlncLN9lKkkeYnArzDJy9j0Y7v7C9p8XOdN+d16Ed0deP5IOZO+691QND6ow=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH for-next v2 0/2] xen/arm: Mitigate straight-line speculation Date: Sat, 13 Mar 2021 16:06:09 +0000 Message-Id: <20210313160611.18665-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall Hi all, Last year, Arm released a whitepaper about a new category of speculation. (see [1] and [2]). In short, a processor may be able to speculate past some of the unconditional control flow instructions (e.g eret, smc, br). In some of the cases, the registers will contain values controlled by the guest. While there is no known gadget afterwards, we still want to prevent any leakage in the future. The mitigation is planned in two parts: 1) Arm provided patches for both GCC and LLVM to add speculation barrier and remove problematic code sequence. 2) Inspection of assembly code and call to higher level (e.g smc in our case). I still haven't looked at 1) and how to mitigate properly Arm32 (see patch #1) and SMC call. So this issue is not fully addressed. Note that the ERET instruction was already addressed as part of XSA-312. Cheers, [1] https://developer.arm.com/support/arm-security-updates/speculative-processor-vulnerability [2] https://developer.arm.com/support/arm-security-updates/speculative-processor-vulnerability/downloads/straight-line-speculation Julien Grall (2): xen/arm: Include asm/asm-offsets.h and asm/macros.h on every assembly files xen/arm64: Place a speculation barrier following an ret instruction xen/arch/arm/Makefile | 2 +- xen/arch/arm/arm32/entry.S | 2 +- xen/arch/arm/arm32/head.S | 1 - xen/arch/arm/arm32/lib/lib1funcs.S | 1 + xen/arch/arm/arm32/proc-v7.S | 1 - xen/arch/arm/arm64/debug-cadence.inc | 1 - xen/arch/arm/arm64/debug-pl011.inc | 2 -- xen/arch/arm/arm64/entry.S | 2 -- xen/arch/arm/arm64/head.S | 2 -- xen/arch/arm/arm64/smc.S | 3 --- xen/include/asm-arm/arm64/macros.h | 6 ++++++ xen/include/asm-arm/config.h | 6 ++++++ xen/include/asm-arm/macros.h | 18 +++++++++--------- 13 files changed, 24 insertions(+), 23 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Mar 13 16:06:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 16:06:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97577.185338 (Exim 4.92) (envelope-from ) id 1lL6mR-00054u-Cf; Sat, 13 Mar 2021 16:06:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97577.185338; Sat, 13 Mar 2021 16:06:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL6mR-00054g-3u; Sat, 13 Mar 2021 16:06:19 +0000 Received: by outflank-mailman (input) for mailman id 97577; Sat, 13 Mar 2021 16:06:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL6mP-00053m-Rz for xen-devel@lists.xenproject.org; Sat, 13 Mar 2021 16:06:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL6mP-0006R9-HD; Sat, 13 Mar 2021 16:06:17 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lL6mP-0001Ff-8P; Sat, 13 Mar 2021 16:06:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=h/X3I9ZAsFKz04WmHoy0166ylMYdxPeS6uPApGEsbfA=; b=LdQeA51vQbW/wbup+yVmczglR 68QA0nyB5pXJm9ofc72BiTLSI+qWvec/ZbtcCpSTV2te4zv3NtMvFqqm0WMsNQrjK/XhtbfDJBCC5 ZZwjSBQwUb3ZoCt/pe637jCpnZgNdYR/zls7npRhhlAk1+w5qcq9DiNrkic/dirrnHEZI=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH for-next v2 2/2] xen/arm64: Place a speculation barrier following an ret instruction Date: Sat, 13 Mar 2021 16:06:11 +0000 Message-Id: <20210313160611.18665-3-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210313160611.18665-1-julien@xen.org> References: <20210313160611.18665-1-julien@xen.org> From: Julien Grall Some CPUs can speculate past a RET instruction and potentially perform speculative accesses to memory before processing the return. There is no known gadget available after the RET instruction today. However some of the registers (such as in check_pending_guest_serror()) may contain a value provided by the guest. In order to harden the code, it would be better to add a speculation barrier after each RET instruction. The performance impact is meant to be negligeable as the speculation barrier is not meant to be architecturally executed. Rather than manually inserting a speculation barrier, use a macro which overrides the mnemonic RET and replace with RET + SB. We need to use the opcode for RET to prevent any macro recursion. This patch is only covering the assembly code. C code would need to be covered separately using the compiler support. This is part of the work to mitigate straight-line speculation. Signed-off-by: Julien Grall --- It is not clear to me whether Armv7 (we don't officially support 32-bit hypervisor on Armv8) is also affected by straight-line speculation. But the mitigation is a lot messier because opcode can be optionally executed. So this Arm32 is left alone for now. Changes in v2: - Use a macro rather than inserting the speculation barrier manually - Remove mitigation for arm32 --- xen/arch/arm/arm32/entry.S | 1 + xen/arch/arm/arm32/lib/lib1funcs.S | 1 + xen/include/asm-arm/arm64/macros.h | 6 ++++++ xen/include/asm-arm/macros.h | 18 +++++++++--------- 4 files changed, 17 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/arm32/entry.S b/xen/arch/arm/arm32/entry.S index f2f1bc7a3158..d0a066484f13 100644 --- a/xen/arch/arm/arm32/entry.S +++ b/xen/arch/arm/arm32/entry.S @@ -441,6 +441,7 @@ ENTRY(__context_switch) add r4, r1, #VCPU_arch_saved_context ldmia r4, {r4 - sl, fp, sp, pc} /* Load registers and return */ + sb /* * Local variables: diff --git a/xen/arch/arm/arm32/lib/lib1funcs.S b/xen/arch/arm/arm32/lib/lib1funcs.S index f1278bd6c139..8c33ffbbcc4c 100644 --- a/xen/arch/arm/arm32/lib/lib1funcs.S +++ b/xen/arch/arm/arm32/lib/lib1funcs.S @@ -382,5 +382,6 @@ UNWIND(.save {lr}) bl __div0 mov r0, #0 @ About as wrong as it could be. ldr pc, [sp], #8 + sb UNWIND(.fnend) ENDPROC(Ldiv0) diff --git a/xen/include/asm-arm/arm64/macros.h b/xen/include/asm-arm/arm64/macros.h index f981b4f43e84..4614394b3dd5 100644 --- a/xen/include/asm-arm/arm64/macros.h +++ b/xen/include/asm-arm/arm64/macros.h @@ -21,6 +21,12 @@ ldr \dst, [\dst, \tmp] .endm + .macro ret + // ret opcode + .inst 0xd65f03c0 + sb + .endm + /* * Register aliases. */ diff --git a/xen/include/asm-arm/macros.h b/xen/include/asm-arm/macros.h index 4833671f4ced..1aa373760f98 100644 --- a/xen/include/asm-arm/macros.h +++ b/xen/include/asm-arm/macros.h @@ -5,6 +5,15 @@ # error "This file should only be included in assembly file" #endif + /* + * Speculative barrier + * XXX: Add support for the 'sb' instruction + */ + .macro sb + dsb nsh + isb + .endm + #if defined (CONFIG_ARM_32) # include #elif defined(CONFIG_ARM_64) @@ -20,13 +29,4 @@ .endr .endm - /* - * Speculative barrier - * XXX: Add support for the 'sb' instruction - */ - .macro sb - dsb nsh - isb - .endm - #endif /* __ASM_ARM_MACROS_H */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Mar 13 17:12:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 17:12:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97592.185354 (Exim 4.92) (envelope-from ) id 1lL7np-0003M6-9B; Sat, 13 Mar 2021 17:11:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97592.185354; Sat, 13 Mar 2021 17:11:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL7np-0003Lz-65; Sat, 13 Mar 2021 17:11:49 +0000 Received: by outflank-mailman (input) for mailman id 97592; Sat, 13 Mar 2021 17:11:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL7nn-0003Lr-CZ; Sat, 13 Mar 2021 17:11:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL7nn-0007Ug-42; Sat, 13 Mar 2021 17:11:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL7nm-0001CJ-Nh; Sat, 13 Mar 2021 17:11:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lL7nm-0001Kc-Mz; Sat, 13 Mar 2021 17:11:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Xvsw30o4tJqjGyJd1KEKbbQfYum7XmBGZuiuugU7HtQ=; b=iIufBBTwea+uD683BVexAQVfnO Eyujh8bxvGIQr0i1wiqu7GktWnn/Y4HVU0v+TUutMjVaZ8b1hb2wrAFbGobuZWFDTaDDj9XNf5pOQ 2NMl9QZGp0et0ZRhvzgrNBToPSfkmK0r5a6/rWjtRXHUnnkmu8aGj60siLNgJYOEZtLg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160064: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-amd64-pvgrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-i386-pvgrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=3f8d1885e48e4d72eab0688f604de62e0aea7a38 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sat, 13 Mar 2021 17:11:46 +0000 flight 160064 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160064/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 152631 build-amd64-xsm 6 xen-build fail REGR. vs. 152631 build-arm64-xsm 6 xen-build fail REGR. vs. 152631 build-arm64 6 xen-build fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-amd64-pvgrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-i386-pvgrub 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-raw 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 3f8d1885e48e4d72eab0688f604de62e0aea7a38 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 205 days Failing since 152659 2020-08-21 14:07:39 Z 204 days 395 attempts Testing same since 160048 2021-03-13 00:08:05 Z 0 days 5 attempts ------------------------------------------------------------ 444 people touched revisions under test, not listing them all jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm pass build-amd64 fail build-arm64 fail build-armhf pass build-i386 pass build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt pass test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-amd64-pvgrub blocked test-amd64-amd64-i386-pvgrub blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-amd64-amd64-xl-qcow2 blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 127455 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 13 18:40:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 18:40:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97606.185369 (Exim 4.92) (envelope-from ) id 1lL9BI-0003MI-4Z; Sat, 13 Mar 2021 18:40:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97606.185369; Sat, 13 Mar 2021 18:40:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL9BI-0003MB-0o; Sat, 13 Mar 2021 18:40:08 +0000 Received: by outflank-mailman (input) for mailman id 97606; Sat, 13 Mar 2021 18:40:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL9BH-0003M3-3a; Sat, 13 Mar 2021 18:40:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL9BG-0000Zh-QO; Sat, 13 Mar 2021 18:40:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lL9BG-0004Ve-IR; Sat, 13 Mar 2021 18:40:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lL9BG-0000rk-Hw; Sat, 13 Mar 2021 18:40:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=g/dnw4KK5ykQsPCogP3ZbUvogqzb4IhmhEan4f9aWE0=; b=f+f8zMyOG4IAXs4Gxov8jP7uFo b2lv2j9QNHwLz18/4dJqJQ2pSSnzK/jIaejvJfMMbXg2Ak1KZHu2PcijuOL4qk4N95UzMqqbippgp DBmcnsamQCFO3fRjsmJZS5tOldNhtSot8XYas9UW75v24PIhM+iYh/YOZY9mrS8BnsoM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160061: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=14b95b3b8546db201e7efd0636ae0e215fae98f3 X-Osstest-Versions-That: xen=9dc46386d89d83c73c41c2b19be83a73957c4393 From: osstest service owner Date: Sat, 13 Mar 2021 18:40:06 +0000 flight 160061 xen-unstable real [real] flight 160065 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160061/ http://logs.test-lab.xenproject.org/osstest/logs/160065/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160065-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160045 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160045 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160045 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160045 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160045 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160045 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160045 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160045 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160045 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160045 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160045 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 14b95b3b8546db201e7efd0636ae0e215fae98f3 baseline version: xen 9dc46386d89d83c73c41c2b19be83a73957c4393 Last test of basis 160045 2021-03-12 20:18:58 Z 0 days Testing same since 160061 2021-03-13 07:30:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ian Jackson Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9dc46386d8..14b95b3b85 14b95b3b8546db201e7efd0636ae0e215fae98f3 -> master From xen-devel-bounces@lists.xenproject.org Sat Mar 13 20:47:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 13 Mar 2021 20:47:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97620.185392 (Exim 4.92) (envelope-from ) id 1lLBAa-0006Bv-Ek; Sat, 13 Mar 2021 20:47:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97620.185392; Sat, 13 Mar 2021 20:47:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLBAa-0006Bo-9p; Sat, 13 Mar 2021 20:47:32 +0000 Received: by outflank-mailman (input) for mailman id 97620; Sat, 13 Mar 2021 20:47:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLBAY-0006Bg-Iz; Sat, 13 Mar 2021 20:47:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLBAY-0002iw-Ad; Sat, 13 Mar 2021 20:47:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLBAX-0001Bp-W5; Sat, 13 Mar 2021 20:47:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLBAX-0007mE-VZ; Sat, 13 Mar 2021 20:47:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mXGrV4xGc8oWFJXiwnNlkkPpXieZRf5djHWRjrhM+UY=; b=x7jq1hKRogOXEurHHVlDiwoYOf IvINmmv4jkveVuCFRrKa1S+5bYMRh3nTRJGeGszUZu3uEAWihv0IYfKusOBap8XJIBHo2/2dxYjh+ V9WkB4qEM3rMxwgPBKegdZFkflwri3Hk6tzoxLkQSwDhyqUKrz6jV/jYNmj2kcRvJJMo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160063: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:guest-destroy:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f296bfd5cd04cbb49b8fc9585adc280ab2b58624 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sat, 13 Mar 2021 20:47:29 +0000 flight 160063 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160063/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 160049 pass in 160063 test-amd64-amd64-examine 4 memdisk-try-append fail pass in 160049 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 20 guest-destroy fail blocked in 152332 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 160049 like 152332 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux f296bfd5cd04cbb49b8fc9585adc280ab2b58624 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 225 days Failing since 152366 2020-08-01 20:49:34 Z 223 days 388 attempts Testing same since 160049 2021-03-13 02:00:29 Z 0 days 2 attempts ------------------------------------------------------------ 5201 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1288789 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 14 01:57:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 14 Mar 2021 01:57:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97638.185407 (Exim 4.92) (envelope-from ) id 1lLFzg-0003I3-W4; Sun, 14 Mar 2021 01:56:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97638.185407; Sun, 14 Mar 2021 01:56:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLFzg-0003Hu-Oi; Sun, 14 Mar 2021 01:56:36 +0000 Received: by outflank-mailman (input) for mailman id 97638; Sun, 14 Mar 2021 01:56:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLFzf-0003Hm-4c; Sun, 14 Mar 2021 01:56:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLFze-0001RC-VV; Sun, 14 Mar 2021 01:56:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLFze-0006kB-Kx; Sun, 14 Mar 2021 01:56:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLFze-0002oC-JA; Sun, 14 Mar 2021 01:56:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rH7LFmD3UbI7QIU61CG+BmcAxpn34HTDSVjR5bUbXh0=; b=PQBzSiHwtx+t95vd+RyXTRWydT v8rZ8rCgYAwAlAAgaaeCpy76D9P5nrWjlDX9OaMhUw++dVugDoorzYR1ly9/KHpg7WjDby5rB+6bg fW5D7eCzfsOGrQ1mbTPO6hzx6IqjAbgN9wgG3D2lRNlbvocmEvDqyR6sXNOA5m9Y3Chw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160066: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=3f8d1885e48e4d72eab0688f604de62e0aea7a38 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sun, 14 Mar 2021 01:56:34 +0000 flight 160066 qemu-mainline real [real] flight 160068 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160066/ http://logs.test-lab.xenproject.org/osstest/logs/160068/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 3f8d1885e48e4d72eab0688f604de62e0aea7a38 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 205 days Failing since 152659 2020-08-21 14:07:39 Z 204 days 396 attempts Testing same since 160048 2021-03-13 00:08:05 Z 1 days 6 attempts ------------------------------------------------------------ 444 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 127455 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 14 05:44:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 14 Mar 2021 05:44:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97646.185422 (Exim 4.92) (envelope-from ) id 1lLJXv-0008GP-Ug; Sun, 14 Mar 2021 05:44:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97646.185422; Sun, 14 Mar 2021 05:44:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLJXv-0008GI-RM; Sun, 14 Mar 2021 05:44:11 +0000 Received: by outflank-mailman (input) for mailman id 97646; Sun, 14 Mar 2021 05:44:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLJXv-0008G9-99; Sun, 14 Mar 2021 05:44:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLJXv-00063X-0y; Sun, 14 Mar 2021 05:44:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLJXu-0008Bn-Kr; Sun, 14 Mar 2021 05:44:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLJXu-0003MR-Ia; Sun, 14 Mar 2021 05:44:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=w0QuhVKHw5oVqp3Uc4hwEIhfLBL32V0fzeUNWkaMrYY=; b=gpnr+jaXvOGc2NzjgVaMoJMUEM raT80lsIBA1FBzrLgy5LrO4dvKAU30NUT0kSxNc0S3xuE6bSo3mSaaEZtc8XiuAzhtgAn/gdqgikO USRWQSEKHBw9siVGfnWWw+lTI5GIaY4j6/fGOkuD1Q2FPhH2fwIdTKIvJhIkXzEcgH24=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160067: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=88fe49249c99de14e543c632a46248d85411ab9e X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sun, 14 Mar 2021 05:44:10 +0000 flight 160067 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160067/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 152332 test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 152332 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux 88fe49249c99de14e543c632a46248d85411ab9e baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 225 days Failing since 152366 2020-08-01 20:49:34 Z 224 days 389 attempts Testing same since 160067 2021-03-13 21:10:30 Z 0 days 1 attempts ------------------------------------------------------------ 5207 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1290753 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 14 08:29:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 14 Mar 2021 08:29:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97671.185437 (Exim 4.92) (envelope-from ) id 1lLM7G-0006xN-Kb; Sun, 14 Mar 2021 08:28:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97671.185437; Sun, 14 Mar 2021 08:28:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLM7G-0006xG-HS; Sun, 14 Mar 2021 08:28:50 +0000 Received: by outflank-mailman (input) for mailman id 97671; Sun, 14 Mar 2021 08:28:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLM7F-0006x8-Vh; Sun, 14 Mar 2021 08:28:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLM7F-0000uL-Iw; Sun, 14 Mar 2021 08:28:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLM7F-0000P1-9k; Sun, 14 Mar 2021 08:28:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLM7F-00044V-9E; Sun, 14 Mar 2021 08:28:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7R5v1VoGe84FkTXAIiwcUsvgQuRVcd0QKnEDj0fN//c=; b=O2fvIYy2ZPU7ZJ7GIFxHONaB/w 2vfSBufYYptz7MYjYnFXgIY9Me3K8b8dRUIv+XJMoQ6BCwkWv28SCg8dkeiAYrupr/UBQ6NBXimSi 3iA/FI7nyQcdbU3SoMF0wyDbn5w9rVbHVEEIueRATrrfzqlV+vgK7ta2W9KvwNBb3kUU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160071: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=52a937d8a2328c83018f0a69393b2840788c2d25 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 14 Mar 2021 08:28:49 +0000 flight 160071 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160071/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 52a937d8a2328c83018f0a69393b2840788c2d25 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 247 days Failing since 151818 2020-07-11 04:18:52 Z 246 days 239 attempts Testing same since 160053 2021-03-13 04:18:52 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 47222 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 14 10:04:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 14 Mar 2021 10:04:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97688.185461 (Exim 4.92) (envelope-from ) id 1lLNbk-0007fK-QZ; Sun, 14 Mar 2021 10:04:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97688.185461; Sun, 14 Mar 2021 10:04:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLNbk-0007fD-Lz; Sun, 14 Mar 2021 10:04:24 +0000 Received: by outflank-mailman (input) for mailman id 97688; Sun, 14 Mar 2021 10:04:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLNbk-0007f8-11 for xen-devel@lists.xenproject.org; Sun, 14 Mar 2021 10:04:24 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0142cc59-12d2-488e-a6a1-fc18e208b0f4; Sun, 14 Mar 2021 10:04:22 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 72A5B64EC6; Sun, 14 Mar 2021 10:04:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0142cc59-12d2-488e-a6a1-fc18e208b0f4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615716262; bh=YaBvDkHUpVHgz7IeG1nFxa4iaw8l+effxELbw6xjnSE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f9YaaxkaUJC+S1azF/+EVhOe/Lsd3o7jbq4JOjr3/2DQ6MhgN9b59MDqcefZZsdKg 6jP871VcuNH1rT616IsxvMjOXZbZC6tFGVQB7r9KoIyJusI40pMgHxlaHBROWaZkBt cXn7MylmRqRpBsgDR40EfziTbjSNq4a+kNLjoZsEYGUn1KqLLj8YGINoZ6QPQpSng0 xCvyfxE2aTO2draiJuQtp2Qo08K303pVPUmIOsKjqaL953lovzlHLAc+poc6yHQz96 PnQ+52gWBxkJ+p7IoX8p1gGCUelyP2/7a2SsDQFdStJ2v+mIkD0Eip6flduJgjCcRz DY4pge6ieA9cQ== Date: Sun, 14 Mar 2021 12:04:18 +0200 From: Leon Romanovsky To: Andrew Lunn Cc: "Hsu, Chiahao" , netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring Message-ID: References: <20210311225944.24198-1-andyhsu@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Mar 12, 2021 at 09:36:59PM +0100, Andrew Lunn wrote: > On Fri, Mar 12, 2021 at 04:18:02PM +0100, Hsu, Chiahao wrote: > > > > Andrew Lunn 於 2021/3/12 15:52 寫道: > > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > > > > > > > > > On Thu, Mar 11, 2021 at 10:59:44PM +0000, ChiaHao Hsu wrote: > > > > In order to support live migration of guests between kernels > > > > that do and do not support 'feature-ctrl-ring', we add a > > > > module parameter that allows the feature to be disabled > > > > at run time, instead of using hardcode value. > > > > The default value is enable. > > > Hi ChiaHao > > > > > > There is a general dislike for module parameters. What other mechanisms > > > have you looked at? Would an ethtool private flag work? > > > > > > Andrew > > > > > > Hi Andrew, > > > > I can survey other mechanisms, however before I start doing that, > > > > could you share more details about what the problem is with using module > > parameters? thanks. > > It is not very user friendly. No two kernel modules use the same > module parameters. Often you see the same name, but different > meaning. There is poor documentation, you often need to read the > kernel sources it figure out what it does, etc. +1, It is also global parameter to whole system/devices that use this module, which is rarely what users want. Thanks From xen-devel-bounces@lists.xenproject.org Sun Mar 14 10:43:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 14 Mar 2021 10:43:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97696.185476 (Exim 4.92) (envelope-from ) id 1lLODT-0002wn-TT; Sun, 14 Mar 2021 10:43:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97696.185476; Sun, 14 Mar 2021 10:43:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLODT-0002wg-QQ; Sun, 14 Mar 2021 10:43:23 +0000 Received: by outflank-mailman (input) for mailman id 97696; Sun, 14 Mar 2021 10:43:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLODT-0002wY-4H; Sun, 14 Mar 2021 10:43:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLODS-0003Ag-S4; Sun, 14 Mar 2021 10:43:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLODS-0006lj-Gw; Sun, 14 Mar 2021 10:43:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLODS-0000qV-GR; Sun, 14 Mar 2021 10:43:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jDuvQ5R42g1oddRBRIFS4TTmPPf8NYnmOhEtEFnYjN0=; b=Bw9l3x0t3+demtXztNv3tz3V/U dbxi65o0dzxWZZnoTWustCdPjhUZ3c4iO9TFqUN1NVIbc/PItLQ+8dhRdRqpE6g1E5hZBJki3J4qg Blc5ZMTxo9c4A3QPo0dDNlFgz1vqwx3UOYcvFfwBUbTJvmIFTN8BmwDShYtPUXJeXSKY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160069: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=14b95b3b8546db201e7efd0636ae0e215fae98f3 X-Osstest-Versions-That: xen=14b95b3b8546db201e7efd0636ae0e215fae98f3 From: osstest service owner Date: Sun, 14 Mar 2021 10:43:22 +0000 flight 160069 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160069/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160061 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160061 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160061 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160061 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160061 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160061 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160061 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160061 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160061 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160061 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160061 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 14b95b3b8546db201e7efd0636ae0e215fae98f3 baseline version: xen 14b95b3b8546db201e7efd0636ae0e215fae98f3 Last test of basis 160069 2021-03-14 01:51:28 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Mar 14 11:16:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 14 Mar 2021 11:16:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97714.185491 (Exim 4.92) (envelope-from ) id 1lLOis-0005pV-L9; Sun, 14 Mar 2021 11:15:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97714.185491; Sun, 14 Mar 2021 11:15:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLOis-0005pO-He; Sun, 14 Mar 2021 11:15:50 +0000 Received: by outflank-mailman (input) for mailman id 97714; Sun, 14 Mar 2021 11:15:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLOir-0005pG-5K; Sun, 14 Mar 2021 11:15:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLOiq-0003ij-Ps; Sun, 14 Mar 2021 11:15:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLOiq-0000mo-GY; Sun, 14 Mar 2021 11:15:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLOiq-0003Pz-G5; Sun, 14 Mar 2021 11:15:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+p7ogZWXKdcRSz6K1KaSKw6aIz6YZigEI3UHq8u5MI0=; b=Y1gsqFTVpGnCpMwhW1a6JXaLSI EvsU0Sg0CahJcLWM5fQ/38yt/KVOPz5s+xOhgjXcd+wP+13cEkGEzBDbx2Aw3WLUqnvJrBodahPJr h7949GIrTcjKE/5eCZ+OlUUuwBJQQMf+e8BRm5vNQl8o+2udxQOx08gR9O36GVOgtLlk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 160076: regressions - ALL FAIL X-Osstest-Failures: xen-unstable-coverity:coverity-amd64:coverity-upload:fail:regression X-Osstest-Versions-This: xen=14b95b3b8546db201e7efd0636ae0e215fae98f3 X-Osstest-Versions-That: xen=1b47cc852fd130ed9ce274a0f1600a4a62949a2c From: osstest service owner Date: Sun, 14 Mar 2021 11:15:48 +0000 flight 160076 xen-unstable-coverity real [real] flight 160077 xen-unstable-coverity real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160076/ http://logs.test-lab.xenproject.org/osstest/logs/160077/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: coverity-amd64 7 coverity-upload fail REGR. vs. 159907 version targeted for testing: xen 14b95b3b8546db201e7efd0636ae0e215fae98f3 baseline version: xen 1b47cc852fd130ed9ce274a0f1600a4a62949a2c Last test of basis 159907 2021-03-10 09:18:33 Z 4 days Testing same since 160076 2021-03-14 09:18:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Boris Ostrovsky Christian Lindig Dario Faggioli Doug Goldstein Elliott Mitchell Ian Jackson Igor Druzhinin Jan Beulich Julien Grall Roger Pau Monne Roger Pau Monné Wei Liu jobs: coverity-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 342 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 14 16:33:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 14 Mar 2021 16:33:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97784.185524 (Exim 4.92) (envelope-from ) id 1lLTgK-0001s7-50; Sun, 14 Mar 2021 16:33:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97784.185524; Sun, 14 Mar 2021 16:33:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLTgK-0001s0-1g; Sun, 14 Mar 2021 16:33:32 +0000 Received: by outflank-mailman (input) for mailman id 97784; Sun, 14 Mar 2021 16:33:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLTgJ-0001rs-5V; Sun, 14 Mar 2021 16:33:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLTgI-0000xZ-TM; Sun, 14 Mar 2021 16:33:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLTgI-0003aI-JP; Sun, 14 Mar 2021 16:33:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLTgI-0000fN-Ix; Sun, 14 Mar 2021 16:33:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IvMotPsh0QEx7ENKttonfICzzm5QgIibK0ilpYK46uA=; b=FARzBSk0CRJhvK/WYj2635NYJz H9C5l5x3jfbMPNL4HmJflQhN3SVke+7ZK689oNjpc4QzIlawfzL7HrVD2VH58Z6uF8JtgNynC9l88 YGmCSHzS+MlAE8qLt0PpHl2q7PU/7FVn26Kr5j9JEK8hGiXKt5s0oQ6rEdRW0yWfeuX0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160070: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=3f8d1885e48e4d72eab0688f604de62e0aea7a38 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sun, 14 Mar 2021 16:33:30 +0000 flight 160070 qemu-mainline real [real] flight 160078 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160070/ http://logs.test-lab.xenproject.org/osstest/logs/160078/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 3f8d1885e48e4d72eab0688f604de62e0aea7a38 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 206 days Failing since 152659 2020-08-21 14:07:39 Z 205 days 397 attempts Testing same since 160048 2021-03-13 00:08:05 Z 1 days 7 attempts ------------------------------------------------------------ 444 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 127455 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 14 18:19:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 14 Mar 2021 18:19:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97795.185539 (Exim 4.92) (envelope-from ) id 1lLVKR-0002iI-2D; Sun, 14 Mar 2021 18:19:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97795.185539; Sun, 14 Mar 2021 18:19:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLVKQ-0002iB-UU; Sun, 14 Mar 2021 18:19:02 +0000 Received: by outflank-mailman (input) for mailman id 97795; Sun, 14 Mar 2021 18:19:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLVKP-0002i3-17; Sun, 14 Mar 2021 18:19:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLVKO-0002iz-OP; Sun, 14 Mar 2021 18:19:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLVKO-0006UB-7X; Sun, 14 Mar 2021 18:19:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLVKO-0007bG-72; Sun, 14 Mar 2021 18:19:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BC4MJZ+1lIh6+fZzPVbavwmt0+MqOlhgebD/Lp9PjbU=; b=qm3VkMi7hF5sKI4jsRAVm3Z6wa LNJ8T2PcKnyCOmnaN3QIJzH7oQZ61nTNyl9sBYiBFjU24s90gcevjani6JcfuAteKPrhQM/LkWJiy GONPj/HGCrATiIFCoJ7w9mZpziuzwiHCesIT0QWiT5q6+UgKQ0AzQC/hkp0vNZ2b+Tr4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160072: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=88fe49249c99de14e543c632a46248d85411ab9e X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sun, 14 Mar 2021 18:19:00 +0000 flight 160072 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160072/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 160067 pass in 160072 test-armhf-armhf-libvirt-raw 8 xen-boot fail in 160067 pass in 160072 test-amd64-amd64-examine 4 memdisk-try-append fail in 160067 pass in 160072 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160067 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux 88fe49249c99de14e543c632a46248d85411ab9e baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 225 days Failing since 152366 2020-08-01 20:49:34 Z 224 days 390 attempts Testing same since 160067 2021-03-13 21:10:30 Z 0 days 2 attempts ------------------------------------------------------------ 5207 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1290753 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 14 23:29:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 14 Mar 2021 23:29:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97815.185558 (Exim 4.92) (envelope-from ) id 1lLaAt-0005Le-K9; Sun, 14 Mar 2021 23:29:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97815.185558; Sun, 14 Mar 2021 23:29:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLaAt-0005LX-Gn; Sun, 14 Mar 2021 23:29:31 +0000 Received: by outflank-mailman (input) for mailman id 97815; Sun, 14 Mar 2021 23:29:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLaAr-0005LS-Rl for xen-devel@lists.xenproject.org; Sun, 14 Mar 2021 23:29:29 +0000 Received: from mail-wr1-x42a.google.com (unknown [2a00:1450:4864:20::42a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7fd255a2-82f3-47cd-b7e7-1e47b8b0cff3; Sun, 14 Mar 2021 23:29:28 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id u16so7802001wrt.1 for ; Sun, 14 Mar 2021 16:29:27 -0700 (PDT) Received: from localhost.localdomain (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id a8sm10533573wmm.46.2021.03.14.16.29.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Mar 2021 16:29:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 7fd255a2-82f3-47cd-b7e7-1e47b8b0cff3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h5PCnHeuw663l7VaVIolY9Ne6WKSedqc+Qdhk8tXZxI=; b=ar+Fg8rz24oRhbuiwycxqds9OHpHo9VC298sJTVByLXIEO/y3tU2tfJ4WmjMtUal4M ZL+WKKcS3MIUxV4a4/O28CkNDvTihLtaN72s31DBYsOIfhfUXcn7u8fQzdGdwzjgHmY6 eti2xAwInvH4bdixt4DSmT/jJDH2XSy5ZkjBz+Ws1gu5f/0FRfyXh5NrJbquYP/n3AUb XVbgGjLFVnFY2iuY3egv2lPv0dptei+bZIHX3aCmlNm8vhzNieeRxUvlkqeqg/AjuCf4 CVi3J5MsdNZ6aqTQF3NoZZKAi5N2VgSpzmVw51iNI+Hcnyk7k2/9ml69U2I55aQVHiz+ UixQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=h5PCnHeuw663l7VaVIolY9Ne6WKSedqc+Qdhk8tXZxI=; b=oMD1sFz6aWVfvnmh3YtRZg/YfiKw1sM6MLfGysBP7aJwadCEQXKH7k11nr9FlO5sk/ 12kEh/q++kvCpIeMq3gStReTsPXMfXFpqJhtXDMzgaDDXlHFYGsohs4BeUtumzlobfXe Xmkh0dbxplnun/TVMYpFpo3WO2YYuv9m4ZzvXkznBuzqpLKOOeLlWO6e5d10owby3XiP 7AYlUA7hwqKwM3g/wSIe0N92UfiqV5rymlEH4TLN+k0Ofe2PJJEZ9C3MyCgXpZxm8h1Q LKirJFwnQ3PFMgix9pE9S5yH/GXWQMbK5X+UpxugGAVaeT6Ca6DPORnylv8Hx5ZDicOd PZlw== X-Gm-Message-State: AOAM53235w4TlS4/X0ny3u3hc+aNUY4JEW3BnkU2VrPvE3E4Yk4hquUy hQPBwX4Fd14pS0tK5tBPybQ= X-Google-Smtp-Source: ABdhPJzIEwujHVQs/5HxbmUBLWEk5042vfAG0vNbusCoXJvUxDP6j8s8K0Uh5L5pj5Ks/wAVIwiXAQ== X-Received: by 2002:adf:e412:: with SMTP id g18mr25206215wrm.159.1615764567139; Sun, 14 Mar 2021 16:29:27 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Claudio Fontana , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefano Stabellini , Anthony Perard , Paul Durrant , "Michael S. Tsirkin" , Marcel Apfelbaum , Eduardo Habkost , Markus Armbruster , "Dr. David Alan Gilbert" , Thomas Huth , Laurent Vivier , Alexander Bulekov , Bandan Das , Stefan Hajnoczi , xen-devel@lists.xenproject.org (open list:X86 Xen CPUs) Subject: [RFC PATCH 2/8] exec: Extract CPU I/O instructions to "cpu-io.h" Date: Mon, 15 Mar 2021 00:29:07 +0100 Message-Id: <20210314232913.2607360-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210314232913.2607360-1-f4bug@amsat.org> References: <20210314232913.2607360-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Not all architectures use an I/O bus. Extract the CPU I/O instruction helpers into a specific unit named cpu-io.c (and its equivalent "cpu-io.h" header). Signed-off-by: Philippe Mathieu-Daudé --- include/exec/cpu-io.h | 30 +++++++++++ include/exec/ioport.h | 7 --- hw/i386/xen/xen-hvm.c | 1 + monitor/misc.c | 2 +- softmmu/cpu-io.c | 88 +++++++++++++++++++++++++++++++ softmmu/ioport.c | 60 --------------------- softmmu/qtest.c | 1 + tests/qtest/fuzz/qtest_wrappers.c | 3 +- softmmu/meson.build | 3 +- 9 files changed, 125 insertions(+), 70 deletions(-) create mode 100644 include/exec/cpu-io.h create mode 100644 softmmu/cpu-io.c diff --git a/include/exec/cpu-io.h b/include/exec/cpu-io.h new file mode 100644 index 00000000000..6538c451177 --- /dev/null +++ b/include/exec/cpu-io.h @@ -0,0 +1,30 @@ +/* + * QEMU CPU I/O instructions + * + * Copyright (c) 2003 Fabrice Bellard + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, see . + */ + +#ifndef CPU_IO_H +#define CPU_IO_H + +void cpu_outb(uint32_t addr, uint8_t val); +void cpu_outw(uint32_t addr, uint16_t val); +void cpu_outl(uint32_t addr, uint32_t val); +uint8_t cpu_inb(uint32_t addr); +uint16_t cpu_inw(uint32_t addr); +uint32_t cpu_inl(uint32_t addr); + +#endif /* CPU_IO_H */ diff --git a/include/exec/ioport.h b/include/exec/ioport.h index e34f668998d..e58f475a7f0 100644 --- a/include/exec/ioport.h +++ b/include/exec/ioport.h @@ -44,13 +44,6 @@ typedef struct MemoryRegionPortio { extern const MemoryRegionOps unassigned_io_ops; #endif -void cpu_outb(uint32_t addr, uint8_t val); -void cpu_outw(uint32_t addr, uint16_t val); -void cpu_outl(uint32_t addr, uint32_t val); -uint8_t cpu_inb(uint32_t addr); -uint16_t cpu_inw(uint32_t addr); -uint32_t cpu_inl(uint32_t addr); - typedef struct PortioList { const struct MemoryRegionPortio *ports; Object *owner; diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 7ce672e5a5c..56e0018a50e 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -34,6 +34,7 @@ #include "sysemu/xen-mapcache.h" #include "trace.h" #include "exec/address-spaces.h" +#include "exec/cpu-io.h" #include #include diff --git a/monitor/misc.c b/monitor/misc.c index a7650ed7470..d40c7d5afc0 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -77,7 +77,7 @@ #include "qapi/qmp-event.h" #include "sysemu/cpus.h" #include "qemu/cutils.h" - +#include "exec/cpu-io.h" #if defined(TARGET_S390X) #include "hw/s390x/storage-keys.h" #include "hw/s390x/storage-attributes.h" diff --git a/softmmu/cpu-io.c b/softmmu/cpu-io.c new file mode 100644 index 00000000000..6ee03555f2c --- /dev/null +++ b/softmmu/cpu-io.c @@ -0,0 +1,88 @@ +/* + * QEMU CPU I/O instructions + * + * Copyright (c) 2003-2008 Fabrice Bellard + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to deal + * in the Software without restriction, including without limitation the rights + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell + * copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN + * THE SOFTWARE. + */ + +#include "qemu/osdep.h" +#include "exec/address-spaces.h" +#include "exec/cpu-io.h" +#include "cpu.h" +#include "trace.h" + +void cpu_outb(uint32_t addr, uint8_t val) +{ + trace_cpu_out(addr, 'b', val); + address_space_write(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, + &val, 1); +} + +void cpu_outw(uint32_t addr, uint16_t val) +{ + uint8_t buf[2]; + + trace_cpu_out(addr, 'w', val); + stw_p(buf, val); + address_space_write(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, + buf, 2); +} + +void cpu_outl(uint32_t addr, uint32_t val) +{ + uint8_t buf[4]; + + trace_cpu_out(addr, 'l', val); + stl_p(buf, val); + address_space_write(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, + buf, 4); +} + +uint8_t cpu_inb(uint32_t addr) +{ + uint8_t val; + + address_space_read(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, + &val, 1); + trace_cpu_in(addr, 'b', val); + return val; +} + +uint16_t cpu_inw(uint32_t addr) +{ + uint8_t buf[2]; + uint16_t val; + + address_space_read(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, buf, 2); + val = lduw_p(buf); + trace_cpu_in(addr, 'w', val); + return val; +} + +uint32_t cpu_inl(uint32_t addr) +{ + uint8_t buf[4]; + uint32_t val; + + address_space_read(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, buf, 4); + val = ldl_p(buf); + trace_cpu_in(addr, 'l', val); + return val; +} diff --git a/softmmu/ioport.c b/softmmu/ioport.c index cb8adb0b936..69b13eed5e6 100644 --- a/softmmu/ioport.c +++ b/softmmu/ioport.c @@ -26,7 +26,6 @@ */ #include "qemu/osdep.h" -#include "cpu.h" #include "exec/ioport.h" #include "exec/memory.h" #include "exec/address-spaces.h" @@ -54,65 +53,6 @@ const MemoryRegionOps unassigned_io_ops = { .endianness = DEVICE_NATIVE_ENDIAN, }; -void cpu_outb(uint32_t addr, uint8_t val) -{ - trace_cpu_out(addr, 'b', val); - address_space_write(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, - &val, 1); -} - -void cpu_outw(uint32_t addr, uint16_t val) -{ - uint8_t buf[2]; - - trace_cpu_out(addr, 'w', val); - stw_p(buf, val); - address_space_write(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, - buf, 2); -} - -void cpu_outl(uint32_t addr, uint32_t val) -{ - uint8_t buf[4]; - - trace_cpu_out(addr, 'l', val); - stl_p(buf, val); - address_space_write(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, - buf, 4); -} - -uint8_t cpu_inb(uint32_t addr) -{ - uint8_t val; - - address_space_read(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, - &val, 1); - trace_cpu_in(addr, 'b', val); - return val; -} - -uint16_t cpu_inw(uint32_t addr) -{ - uint8_t buf[2]; - uint16_t val; - - address_space_read(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, buf, 2); - val = lduw_p(buf); - trace_cpu_in(addr, 'w', val); - return val; -} - -uint32_t cpu_inl(uint32_t addr) -{ - uint8_t buf[4]; - uint32_t val; - - address_space_read(&address_space_io, addr, MEMTXATTRS_UNSPECIFIED, buf, 4); - val = ldl_p(buf); - trace_cpu_in(addr, 'l', val); - return val; -} - void portio_list_init(PortioList *piolist, Object *owner, const MemoryRegionPortio *callbacks, diff --git a/softmmu/qtest.c b/softmmu/qtest.c index 130c3666154..ff253068657 100644 --- a/softmmu/qtest.c +++ b/softmmu/qtest.c @@ -31,6 +31,7 @@ #ifdef CONFIG_PSERIES #include "hw/ppc/spapr_rtas.h" #endif +#include "exec/cpu-io.h" #define MAX_IRQ 256 diff --git a/tests/qtest/fuzz/qtest_wrappers.c b/tests/qtest/fuzz/qtest_wrappers.c index 0580f8df860..921d1e5ed3a 100644 --- a/tests/qtest/fuzz/qtest_wrappers.c +++ b/tests/qtest/fuzz/qtest_wrappers.c @@ -12,8 +12,9 @@ */ #include "qemu/osdep.h" +#include "exec/address-spaces.h" +#include "exec/cpu-io.h" #include "hw/core/cpu.h" -#include "exec/ioport.h" #include "fuzz.h" diff --git a/softmmu/meson.build b/softmmu/meson.build index d8e03018abf..ebf063b8990 100644 --- a/softmmu/meson.build +++ b/softmmu/meson.build @@ -2,11 +2,11 @@ 'arch_init.c', 'balloon.c', 'cpus.c', + 'cpu-io.c', 'cpu-throttle.c', 'datadir.c', 'globals.c', 'physmem.c', - 'ioport.c', 'rtc.c', 'runstate.c', 'memory.c', @@ -24,6 +24,7 @@ softmmu_ss.add(files( 'bootdevice.c', 'dma-helpers.c', + 'ioport.c', 'qdev-monitor.c', ), sdl, libpmem, libdaxctl) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 15 01:20:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 01:20:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97821.185570 (Exim 4.92) (envelope-from ) id 1lLbuO-0001dg-Dm; Mon, 15 Mar 2021 01:20:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97821.185570; Mon, 15 Mar 2021 01:20:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLbuO-0001dZ-Am; Mon, 15 Mar 2021 01:20:36 +0000 Received: by outflank-mailman (input) for mailman id 97821; Mon, 15 Mar 2021 01:20:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLbuM-0001dR-6U; Mon, 15 Mar 2021 01:20:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLbuL-0003H2-Tp; Mon, 15 Mar 2021 01:20:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLbuL-0000I6-Kq; Mon, 15 Mar 2021 01:20:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLbuL-00041g-KM; Mon, 15 Mar 2021 01:20:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vKW2Lc6P7SX1JO8DTA8WRZSr9ZC8YCmYZUGMMByQbKQ=; b=mubM5DC9YjuYjZZgw7jKoJS2W8 k3H/j6wi5YYYkbDdSroFa2djtsIVkJD50WMtu3zbgzZ6qhfcqwyaJb06DXaspW7/pU1gOQyZk9zW+ Up6qMorEL+33uLqO7uMe1WjQYvUnN75xG1Lk3HmHGILcwFPJEehDKm5ND7H1ArsvP0SM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160079: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=6f8a81fc296535f73c48cf9563862e088cc71c57 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Mon, 15 Mar 2021 01:20:33 +0000 flight 160079 qemu-mainline real [real] flight 160081 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160079/ http://logs.test-lab.xenproject.org/osstest/logs/160081/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 6f8a81fc296535f73c48cf9563862e088cc71c57 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 206 days Failing since 152659 2020-08-21 14:07:39 Z 205 days 398 attempts Testing same since 160079 2021-03-14 16:39:11 Z 0 days 1 attempts ------------------------------------------------------------ 444 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 128327 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 15 03:09:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 03:09:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97830.185584 (Exim 4.92) (envelope-from ) id 1lLdbb-0003Iq-C2; Mon, 15 Mar 2021 03:09:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97830.185584; Mon, 15 Mar 2021 03:09:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLdbb-0003Ij-8K; Mon, 15 Mar 2021 03:09:19 +0000 Received: by outflank-mailman (input) for mailman id 97830; Mon, 15 Mar 2021 03:09:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLdbZ-0003Ib-M2; Mon, 15 Mar 2021 03:09:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLdbZ-0005tM-Bv; Mon, 15 Mar 2021 03:09:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLdbZ-000344-0v; Mon, 15 Mar 2021 03:09:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLdbZ-00029y-0L; Mon, 15 Mar 2021 03:09:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/Q/ChbT2vd+/h3ajfHd/cVwjJ5SmEO3N7VIhijJ/FuQ=; b=oecrnErYqXtCj6sKHxsgrs5/af dONKWLGnuKfqs98tIvqI3t2La6COxiyHdY9Q7dYfpoeEiiboFujELwMfsuCnwG7dkj1oQGXAICsPu y9EdnKNK6+0k+Jv7fBkRmeoCG1Ih7WK3DcM47LkHnpLFiZQe9Vf5W4zNSjtSGfzukoEQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160080: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore.2:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=88fe49249c99de14e543c632a46248d85411ab9e X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 15 Mar 2021 03:09:17 +0000 flight 160080 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160080/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 160072 pass in 160080 test-amd64-amd64-qemuu-freebsd11-amd64 18 guest-saverestore.2 fail pass in 160072 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux 88fe49249c99de14e543c632a46248d85411ab9e baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 226 days Failing since 152366 2020-08-01 20:49:34 Z 225 days 391 attempts Testing same since 160067 2021-03-13 21:10:30 Z 1 days 3 attempts ------------------------------------------------------------ 5207 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1290753 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 15 05:27:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 05:27:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97838.185600 (Exim 4.92) (envelope-from ) id 1lLfkz-0007tp-Bb; Mon, 15 Mar 2021 05:27:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97838.185600; Mon, 15 Mar 2021 05:27:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLfkz-0007ti-7w; Mon, 15 Mar 2021 05:27:09 +0000 Received: by outflank-mailman (input) for mailman id 97838; Mon, 15 Mar 2021 05:27:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLfky-0007ta-VJ; Mon, 15 Mar 2021 05:27:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLfky-0000FH-Le; Mon, 15 Mar 2021 05:27:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLfky-0008KJ-CZ; Mon, 15 Mar 2021 05:27:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLfky-0005CJ-C3; Mon, 15 Mar 2021 05:27:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XGhhBIL2GW+vroBqOhMbKq/Sxd7HHwtAp2JmN7ISRJk=; b=1rMFRmjnS8ScOWumYXMQFcG5jr zJQC0BOriaCTCbjLcZScPERCaTakg8VkerPQfYGnLbLLBPScUvwSPIbLFcl0iMFyDD/MwlYwD6Zv0 fnveyujVHdbYaBxzVYYdCOCsP0U/qHaqbad23wFVBnl4/uh4O/eGgsXbDDq3M5MLjUZs=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160085: regressions - trouble: blocked/fail/pass/starved X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=52a937d8a2328c83018f0a69393b2840788c2d25 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 15 Mar 2021 05:27:08 +0000 flight 160085 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160085/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 52a937d8a2328c83018f0a69393b2840788c2d25 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 248 days Failing since 151818 2020-07-11 04:18:52 Z 247 days 240 attempts Testing same since 160053 2021-03-13 04:18:52 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt starved build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt starved test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw starved test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 47222 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 15 06:42:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 06:42:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97846.185615 (Exim 4.92) (envelope-from ) id 1lLgvv-0006lj-5P; Mon, 15 Mar 2021 06:42:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97846.185615; Mon, 15 Mar 2021 06:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLgvv-0006lc-2B; Mon, 15 Mar 2021 06:42:31 +0000 Received: by outflank-mailman (input) for mailman id 97846; Mon, 15 Mar 2021 06:42:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLgvu-0006lX-1A for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 06:42:30 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 940b8ccb-63c6-40c3-b6ce-0b330825de02; Mon, 15 Mar 2021 06:42:25 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A1D1CD6E; Sun, 14 Mar 2021 23:42:24 -0700 (PDT) Received: from [10.57.18.146] (unknown [10.57.18.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E7E993F792; Sun, 14 Mar 2021 23:42:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 940b8ccb-63c6-40c3-b6ce-0b330825de02 Subject: Re: [PATCH v5] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210311142207.25556-1-michal.orzel@arm.com> <572b503c-6650-a0a7-74d6-f5f3ba076fea@suse.com> From: Michal Orzel Message-ID: <79317a40-9128-4d4d-4774-51632c0c393a@arm.com> Date: Mon, 15 Mar 2021 07:42:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <572b503c-6650-a0a7-74d6-f5f3ba076fea@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11.03.2021 15:50, Jan Beulich wrote: > On 11.03.2021 15:22, Michal Orzel wrote: >> Currently in order to link existing DTB into Xen image >> we need to either specify option CONFIG_DTB_FILE on the >> command line or manually add it into .config. >> Add Kconfig entry: CONFIG_DTB_FILE >> to be able to provide the path to DTB we want to embed >> into Xen image. If no path provided - the dtb will not >> be embedded. >> >> Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >> as it is not needed since Kconfig will define it in a header >> with all the other config options. >> >> Make a change in the linker script from: >> _sdtb = .; >> to: >> PROVIDE(_sdtb = .); >> to avoid creation of _sdtb if there is no reference to it. >> >> Signed-off-by: Michal Orzel > > Reviewed-by: Jan Beulich > albeit I think that, as suggested, ... > >> --- a/xen/arch/arm/xen.lds.S >> +++ b/xen/arch/arm/xen.lds.S >> @@ -222,7 +222,7 @@ SECTIONS >> >> #ifdef CONFIG_DTB_FILE >> /* Section for the device tree blob (if any). */ >> - _sdtb = .; >> + PROVIDE(_sdtb = .); >> .dtb : { *(.dtb) } :text >> #endif > > .. the now pointless (always true) #ifdef here should also go > away. > Will be done in v6. > Jan > Michal From xen-devel-bounces@lists.xenproject.org Mon Mar 15 06:51:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 06:51:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97849.185626 (Exim 4.92) (envelope-from ) id 1lLh4p-0007l2-2C; Mon, 15 Mar 2021 06:51:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97849.185626; Mon, 15 Mar 2021 06:51:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLh4o-0007kv-VZ; Mon, 15 Mar 2021 06:51:42 +0000 Received: by outflank-mailman (input) for mailman id 97849; Mon, 15 Mar 2021 06:51:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLh4m-0007kq-Vo for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 06:51:41 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 78b7bac2-4a26-4bc9-804d-b716a9726baf; Mon, 15 Mar 2021 06:51:38 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 44FDCD6E; Sun, 14 Mar 2021 23:51:38 -0700 (PDT) Received: from e123311-lin.arm.com (unknown [10.57.18.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 650793F792; Sun, 14 Mar 2021 23:51:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78b7bac2-4a26-4bc9-804d-b716a9726baf From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com Subject: [PATCH v6] arm: Add Kconfig entry to select CONFIG_DTB_FILE Date: Mon, 15 Mar 2021 07:51:29 +0100 Message-Id: <20210315065129.27036-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently in order to link existing DTB into Xen image we need to either specify option CONFIG_DTB_FILE on the command line or manually add it into .config. Add Kconfig entry: CONFIG_DTB_FILE to be able to provide the path to DTB we want to embed into Xen image. If no path provided - the dtb will not be embedded. Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" as it is not needed since Kconfig will define it in a header with all the other config options. Make a change in the linker script from: _sdtb = .; to: PROVIDE(_sdtb = .); to avoid creation of _sdtb if there is no reference to it. Signed-off-by: Michal Orzel --- xen/arch/arm/Makefile | 5 ++--- xen/arch/arm/arm32/head.S | 4 ++-- xen/arch/arm/arm64/head.S | 4 ++-- xen/arch/arm/xen.lds.S | 4 +--- xen/common/Kconfig | 8 ++++++++ 5 files changed, 15 insertions(+), 10 deletions(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 16e6523e2c..46e6a95fec 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -68,9 +68,8 @@ extra-y += $(TARGET_SUBARCH)/head.o #obj-bin-y += ....o -ifdef CONFIG_DTB_FILE +ifneq ($(CONFIG_DTB_FILE),"") obj-y += dtb.o -AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" endif ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c xen.lds: xen.lds.S $(CPP) -P $(a_flags) -MQ $@ -o $@ $< -dtb.o: $(CONFIG_DTB_FILE) +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) .PHONY: clean clean:: diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index c404fa973e..50f019ed98 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -156,10 +156,10 @@ past_zImage: sub r10, r9, r0 /* r10 := phys-offset */ /* Using the DTB in the .dtb section? */ -#ifdef CONFIG_DTB_FILE +.ifnes CONFIG_DTB_FILE,"" ldr r8, =_sdtb add r8, r10 /* r8 := paddr(DTB) */ -#endif +.endif /* Initialize the UART if earlyprintk has been enabled. */ #ifdef CONFIG_EARLY_PRINTK diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 5d44667bd8..f38a8dfca7 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -296,9 +296,9 @@ real_start_efi: sub x20, x19, x0 /* x20 := phys-offset */ /* Using the DTB in the .dtb section? */ -#ifdef CONFIG_DTB_FILE +.ifnes CONFIG_DTB_FILE,"" load_paddr x21, _sdtb -#endif +.endif /* Initialize the UART if earlyprintk has been enabled. */ #ifdef CONFIG_EARLY_PRINTK diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index 004b182acb..540a7ccc9d 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -220,11 +220,9 @@ SECTIONS } :text _end = . ; -#ifdef CONFIG_DTB_FILE /* Section for the device tree blob (if any). */ - _sdtb = .; + PROVIDE(_sdtb = .); .dtb : { *(.dtb) } :text -#endif /* Sections to be discarded */ /DISCARD/ : { diff --git a/xen/common/Kconfig b/xen/common/Kconfig index eb953d171e..71fc9e00cb 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -400,6 +400,14 @@ config DOM0_MEM Leave empty if you are not sure what to specify. +config DTB_FILE + string "Absolute path to device tree blob" + depends on HAS_DEVICE_TREE + help + When using a bootloader that has no device tree support or when there + is no bootloader at all, use this option to specify the absolute path + to a device tree that will be linked directly inside Xen binary. + config TRACEBUFFER bool "Enable tracing infrastructure" if EXPERT default y -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Mon Mar 15 07:37:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 07:37:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97853.185643 (Exim 4.92) (envelope-from ) id 1lLhmt-00037O-MK; Mon, 15 Mar 2021 07:37:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97853.185643; Mon, 15 Mar 2021 07:37:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLhmt-00037H-Ij; Mon, 15 Mar 2021 07:37:15 +0000 Received: by outflank-mailman (input) for mailman id 97853; Mon, 15 Mar 2021 07:37:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLhms-00037C-Sj for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 07:37:14 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e8cfad8d-de6c-4f00-8c58-fbb4102dd47d; Mon, 15 Mar 2021 07:37:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CAB97AC24; Mon, 15 Mar 2021 07:37:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8cfad8d-de6c-4f00-8c58-fbb4102dd47d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615793831; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bwd78NaMBJS1pn9tcLaXpIpPWKUE776gW0YAJW/t+Yk=; b=HQ6xkqgGon5mqpq4I81sK13FaiDhr6PWnDuWvv/qg++DeW89kVk64UUHd5PgF+/WfnBTyh bMGBrlYI8mUF39pTDQI7MxDCORBZUTfqpwASd68vNDiHyg481Mm1HblHmk1sbvtOqf+FNv 5cb2z83UhR/DcGG039aP/sx+oqtchDU= Subject: Re: [PATCH v6] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org References: <20210315065129.27036-1-michal.orzel@arm.com> From: Jan Beulich Message-ID: <3b6a5707-881c-7b85-84bf-ff75134b9738@suse.com> Date: Mon, 15 Mar 2021 08:37:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210315065129.27036-1-michal.orzel@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 15.03.2021 07:51, Michal Orzel wrote: > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -400,6 +400,14 @@ config DOM0_MEM > > Leave empty if you are not sure what to specify. > > +config DTB_FILE > + string "Absolute path to device tree blob" > + depends on HAS_DEVICE_TREE > + help > + When using a bootloader that has no device tree support or when there > + is no bootloader at all, use this option to specify the absolute path > + to a device tree that will be linked directly inside Xen binary. I'm sorry, it should have occurred to me earlier to ask, but: Shouldn't this text make explicit that this is an optional setting and hence leaving blank is generally okay? I.e. something along the lines of what is visible in context above from the prior setting? Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 15 08:06:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 08:06:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97861.185659 (Exim 4.92) (envelope-from ) id 1lLiFN-0006Tb-56; Mon, 15 Mar 2021 08:06:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97861.185659; Mon, 15 Mar 2021 08:06:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLiFN-0006TU-15; Mon, 15 Mar 2021 08:06:41 +0000 Received: by outflank-mailman (input) for mailman id 97861; Mon, 15 Mar 2021 08:06:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLiFL-0006TP-A8 for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 08:06:39 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 867e7d67-f64f-43c0-b24c-f75dab14cc77; Mon, 15 Mar 2021 08:06:38 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 51016ABD7; Mon, 15 Mar 2021 08:06:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 867e7d67-f64f-43c0-b24c-f75dab14cc77 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615795597; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Ws3SpyyAi9it/NT6gVbyOHCpYWOqJ8OfrDH6SnT6Ak=; b=ufckSlMj1P6inXfVUSdddEDf2kVeC/gbTCNiQ3KVLCz2UMHLrYNWv9etowYKY5jxIW2cb8 g9LDpf1nf4BraMxAZuw/BTl1QqLDORW+UCbvwzxUfzqA4iJxHeZDXBcTl8ADBCW6g6xpKZ j3/Eo96qDlJjrMbtfiUSH1C9zbNv+6Y= Subject: Re: [PATCH v3] xen: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped To: Stefano Stabellini Cc: andrew.cooper3@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, Stefano Stabellini , xen-devel@lists.xenproject.org References: <20210312231632.5666-1-sstabellini@kernel.org> From: Jan Beulich Message-ID: <0e35a613-fd93-0805-10b9-5ecee73bb15d@suse.com> Date: Mon, 15 Mar 2021 09:06:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210312231632.5666-1-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 13.03.2021 00:16, Stefano Stabellini wrote: > Introduce two feature flags to tell the domain whether it is > direct-mapped or not. It allows the guest kernel to make informed > decisions on things such as swiotlb-xen enablement. > > The introduction of both flags (XENFEAT_direct_mapped and > XENFEAT_not_direct_mapped) allows the guest kernel to avoid any > guesswork if one of the two is present, or fallback to the current > checks if neither of them is present. > > XENFEAT_direct_mapped is always set for not auto-translated guests. > > For auto-translated guests, only Dom0 on ARM is direct-mapped. Also, > see is_domain_direct_mapped() which refers to auto-translated guests: > xen/include/asm-arm/domain.h:is_domain_direct_mapped > xen/include/asm-x86/domain.h:is_domain_direct_mapped > > Signed-off-by: Stefano Stabellini > CC: jbeulich@suse.com > CC: andrew.cooper3@citrix.com > CC: julien@xen.org Any particular reason my previously given R-b isn't here? Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 15 08:19:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 08:19:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97867.185670 (Exim 4.92) (envelope-from ) id 1lLiRn-0007a9-AE; Mon, 15 Mar 2021 08:19:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97867.185670; Mon, 15 Mar 2021 08:19:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLiRn-0007a2-7F; Mon, 15 Mar 2021 08:19:31 +0000 Received: by outflank-mailman (input) for mailman id 97867; Mon, 15 Mar 2021 08:19:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLiRl-0007Zx-9k for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 08:19:29 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 5679f1a9-fdce-4205-86d9-f5cf756af2c9; Mon, 15 Mar 2021 08:19:28 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-JTYACgGdPaStKMrDzo-FLQ-1; Mon, 15 Mar 2021 04:19:22 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1B0E93920; Mon, 15 Mar 2021 08:19:19 +0000 (UTC) Received: from wangxiaodeMacBook-Air.local (ovpn-12-245.pek2.redhat.com [10.72.12.245]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4292E501D4; Mon, 15 Mar 2021 08:19:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5679f1a9-fdce-4205-86d9-f5cf756af2c9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615796368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+rRxAEJP0yb8hy5xLsHkEvRLysybMMWDqJwpU7ye9LI=; b=FRnHwA1mAbJCTuuN3rKx8pCngIS7aV3rgcM5H4Ums3BIBR7MP4Xu4nsnzOFoJVd5y8PEOr npD9hD1+ZkUymYT8UpzUiPR59nckUYTVvq6S9lh5dIK5oqhX5c3G5QFPuQfRedaA/4pz1+ oERSDfj/ykT4sqHlclhC8O8GqHS7caM= X-MC-Unique: JTYACgGdPaStKMrDzo-FLQ-1 Subject: Re: [PATCH v7 0/5] Introducing QMP query-netdev command To: Alexey Kirillov , Markus Armbruster , Thomas Huth , Eric Blake Cc: Laurent Vivier , Stefano Stabellini , Samuel Thibault , "Michael S. Tsirkin" , Stefan Weil , Paul Durrant , "qemu-devel@nongnu.org" , Vincenzo Maffione , Paolo Bonzini , "yc-core@yandex-team.ru" , Michael Roth , Anthony Perard , "xen-devel@lists.xenproject.org" , Giuseppe Lettieri , Luigi Rizzo References: <20210303095910.78277-1-lekiravi@yandex-team.ru> <32641615544652@mail.yandex-team.ru> From: Jason Wang Message-ID: <583ade39-fd95-b5af-6d8f-c2126e341cbe@redhat.com> Date: Mon, 15 Mar 2021 16:19:00 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <32641615544652@mail.yandex-team.ru> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit 在 2021/3/12 下午6:29, Alexey Kirillov 写道: > ping > > Patchew page: https://patchew.org/QEMU/20210303095910.78277-1-lekiravi@yandex-team.ru Applied. Thanks > > 03.03.2021, 13:01, "Alexey Kirillov" : >> This patch series introduces a new QMP command "query-netdev" to get >> information about currently attached backend network devices (netdevs). >> >> Also, since the "info_str" field of "NetClientState" is now deprecated, >> we no longer use it for netdevs, only for NIC/hubports. >> >> The HMP command "info network" now also uses QAPI structure inside. >> >> Usage example: >> >> -> { "execute": "query-netdev" } >> <- { "return": [ >>          { >>              "listen": "127.0.0.1:90", >>              "type": "socket", >>              "peer-id": "hub0port1", >>              "id": "__org.qemu.net1" >>          }, >>          { >>              "script": "/etc/qemu-ifup", >>              "downscript": "/etc/qemu-ifdown", >>              "ifname": "tap0", >>              "type": "tap", >>              "peer-id": "net5", >>              "vnet_hdr": true, >>              "id": "tap0" >>          }, >>          { >>              "ipv6": true, >>              "ipv4": true, >>              "host": "10.0.2.2", >>              "ipv6-dns": "fec0::3", >>              "ipv6-prefix": "fec0::", >>              "net": "10.0.2.0/255.255.255.0", >>              "ipv6-host": "fec0::2", >>              "type": "user", >>              "peer-id": "net0", >>              "dns": "10.0.2.3", >>              "hostfwd": [ >>                  { >>                      "str": "tcp::20004-:22" >>                  } >>              ], >>              "ipv6-prefixlen": 64, >>              "id": "netdev0", >>              "restrict": false >>          } >>      ] >>    } >> >> v6->v7: >> - Use macroses QAPI_LIST_PREPEND and QAPI_LIST_APPEND for lists. >> - Reorder NetBackend entries in alphabetical order. >> >> v5->v6: >> - Add QAPI visitor to generate info_str replacement directly from NetdevInfo. >> - Make info_str dynamically allocated. >> - Make commit messages more meaningful. >> >> v4->v5: >> - Enable qtest of query-netdevs for AVR and RX archs. >> - Bump "Since" version in QAPI to 6.0. >> >> v3->v4: >> - Rename "query-netdevs" to "query-netdev". >> - Copy netdev drivers to new QAPI enum "NetBackend". >> >> v2->v3: >> - Remove NIC and hubports from query-netdevs. >> - Remove several fields from NetdevInfo since they are unnecessary. >> - Rename field @peer to @peer-id. >> - Add support of vhost-vdpa. >> - Keep "info_str" for NIC/hubports, but remove it for netdevs. >> >> v1->v2: >> - Rewrite HMP "info network" to get information from results of QMP command. >> - Remove obsolete field "info_str" from "NetClientState". >> >> Alexey Kirillov (5): >>   qapi: net: Add query-netdev command >>   tests: Add tests for query-netdev command >>   net: Move NetClientState.info_str to dynamic allocations >>   hmp: Use QAPI NetdevInfo in hmp_info_network >>   net: Do not fill legacy info_str for backends >> >>  hw/net/xen_nic.c | 5 +- >>  include/net/net.h | 5 +- >>  include/qapi/hmp-output-visitor.h | 30 +++++ >>  net/l2tpv3.c | 8 +- >>  net/net.c | 73 +++++++++-- >>  net/netmap.c | 7 ++ >>  net/slirp.c | 124 ++++++++++++++++++- >>  net/socket.c | 92 ++++++++++---- >>  net/tap-win32.c | 10 +- >>  net/tap.c | 107 +++++++++++++++-- >>  net/vde.c | 25 +++- >>  net/vhost-user.c | 20 +++- >>  net/vhost-vdpa.c | 15 ++- >>  qapi/hmp-output-visitor.c | 193 ++++++++++++++++++++++++++++++ >>  qapi/meson.build | 1 + >>  qapi/net.json | 80 +++++++++++++ >>  tests/qtest/meson.build | 3 + >>  tests/qtest/test-query-netdev.c | 120 +++++++++++++++++++ >>  18 files changed, 856 insertions(+), 62 deletions(-) >>  create mode 100644 include/qapi/hmp-output-visitor.h >>  create mode 100644 qapi/hmp-output-visitor.c >>  create mode 100644 tests/qtest/test-query-netdev.c >> >> -- >> 2.25.1 > > -- > Alexey Kirillov > Yandex.Cloud > > From xen-devel-bounces@lists.xenproject.org Mon Mar 15 09:24:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 09:24:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97917.185683 (Exim 4.92) (envelope-from ) id 1lLjS7-0005U1-1Y; Mon, 15 Mar 2021 09:23:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97917.185683; Mon, 15 Mar 2021 09:23:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLjS6-0005Tu-UK; Mon, 15 Mar 2021 09:23:54 +0000 Received: by outflank-mailman (input) for mailman id 97917; Mon, 15 Mar 2021 09:23:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLjS5-0005Tp-HX for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 09:23:53 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id cc332ae1-9a9b-4ba1-8f50-ddfc12e1be3e; Mon, 15 Mar 2021 09:23:51 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D82AC1FB; Mon, 15 Mar 2021 02:23:50 -0700 (PDT) Received: from e123311-lin.arm.com (unknown [10.57.18.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 07EFE3F70D; Mon, 15 Mar 2021 02:23:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc332ae1-9a9b-4ba1-8f50-ddfc12e1be3e From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com Subject: [PATCH v7] arm: Add Kconfig entry to select CONFIG_DTB_FILE Date: Mon, 15 Mar 2021 10:23:42 +0100 Message-Id: <20210315092342.26533-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently in order to link existing DTB into Xen image we need to either specify option CONFIG_DTB_FILE on the command line or manually add it into .config. Add Kconfig entry: CONFIG_DTB_FILE to be able to provide the path to DTB we want to embed into Xen image. If no path provided - the dtb will not be embedded. Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" as it is not needed since Kconfig will define it in a header with all the other config options. Make a change in the linker script from: _sdtb = .; to: PROVIDE(_sdtb = .); to avoid creation of _sdtb if there is no reference to it. Signed-off-by: Michal Orzel --- xen/arch/arm/Makefile | 5 ++--- xen/arch/arm/arm32/head.S | 4 ++-- xen/arch/arm/arm64/head.S | 4 ++-- xen/arch/arm/xen.lds.S | 4 +--- xen/common/Kconfig | 10 ++++++++++ 5 files changed, 17 insertions(+), 10 deletions(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 16e6523e2c..46e6a95fec 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -68,9 +68,8 @@ extra-y += $(TARGET_SUBARCH)/head.o #obj-bin-y += ....o -ifdef CONFIG_DTB_FILE +ifneq ($(CONFIG_DTB_FILE),"") obj-y += dtb.o -AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" endif ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c xen.lds: xen.lds.S $(CPP) -P $(a_flags) -MQ $@ -o $@ $< -dtb.o: $(CONFIG_DTB_FILE) +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) .PHONY: clean clean:: diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index c404fa973e..50f019ed98 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -156,10 +156,10 @@ past_zImage: sub r10, r9, r0 /* r10 := phys-offset */ /* Using the DTB in the .dtb section? */ -#ifdef CONFIG_DTB_FILE +.ifnes CONFIG_DTB_FILE,"" ldr r8, =_sdtb add r8, r10 /* r8 := paddr(DTB) */ -#endif +.endif /* Initialize the UART if earlyprintk has been enabled. */ #ifdef CONFIG_EARLY_PRINTK diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 5d44667bd8..f38a8dfca7 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -296,9 +296,9 @@ real_start_efi: sub x20, x19, x0 /* x20 := phys-offset */ /* Using the DTB in the .dtb section? */ -#ifdef CONFIG_DTB_FILE +.ifnes CONFIG_DTB_FILE,"" load_paddr x21, _sdtb -#endif +.endif /* Initialize the UART if earlyprintk has been enabled. */ #ifdef CONFIG_EARLY_PRINTK diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index 004b182acb..540a7ccc9d 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -220,11 +220,9 @@ SECTIONS } :text _end = . ; -#ifdef CONFIG_DTB_FILE /* Section for the device tree blob (if any). */ - _sdtb = .; + PROVIDE(_sdtb = .); .dtb : { *(.dtb) } :text -#endif /* Sections to be discarded */ /DISCARD/ : { diff --git a/xen/common/Kconfig b/xen/common/Kconfig index eb953d171e..a1755cd380 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -400,6 +400,16 @@ config DOM0_MEM Leave empty if you are not sure what to specify. +config DTB_FILE + string "Absolute path to device tree blob" + depends on HAS_DEVICE_TREE + help + When using a bootloader that has no device tree support or when there + is no bootloader at all, use this option to specify the absolute path + to a device tree that will be linked directly inside Xen binary. + + This is an optional config. Leave empty if not needed. + config TRACEBUFFER bool "Enable tracing infrastructure" if EXPERT default y -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Mon Mar 15 10:30:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 10:30:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97930.185695 (Exim 4.92) (envelope-from ) id 1lLkUD-0003f9-8G; Mon, 15 Mar 2021 10:30:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97930.185695; Mon, 15 Mar 2021 10:30:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLkUD-0003f2-4v; Mon, 15 Mar 2021 10:30:09 +0000 Received: by outflank-mailman (input) for mailman id 97930; Mon, 15 Mar 2021 10:30:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLkUC-0003ex-7H for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 10:30:08 +0000 Received: from FRA01-MR2-obe.outbound.protection.outlook.com (unknown [40.107.9.77]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a2212335-9192-42f3-b8dc-17380361cf9c; Mon, 15 Mar 2021 10:30:06 +0000 (UTC) Received: from DB6PR0501CA0021.eurprd05.prod.outlook.com (2603:10a6:4:8f::31) by PR2PR08MB4796.eurprd08.prod.outlook.com (2603:10a6:101:21::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Mon, 15 Mar 2021 10:29:56 +0000 Received: from DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:8f:cafe::60) by DB6PR0501CA0021.outlook.office365.com (2603:10a6:4:8f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Mon, 15 Mar 2021 10:29:56 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT034.mail.protection.outlook.com (10.152.20.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Mon, 15 Mar 2021 10:29:56 +0000 Received: ("Tessian outbound 24a7072fdae6:v71"); Mon, 15 Mar 2021 10:29:56 +0000 Received: from f70850ec4f7a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C4B4825C-BF86-44AE-B6E7-A6099F0FA2A4.1; Mon, 15 Mar 2021 10:29:20 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f70850ec4f7a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 15 Mar 2021 10:29:20 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VI1PR0801MB1872.eurprd08.prod.outlook.com (2603:10a6:800:86::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Mon, 15 Mar 2021 10:29:16 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3933.032; Mon, 15 Mar 2021 10:29:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2212335-9192-42f3-b8dc-17380361cf9c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pSKQAci77+VJmJ0vscZTCxSI6oueURxbYe5hjUdP5TI=; b=v3Yx7PTW9R4p2PEHw+zsZSBUZdTA5S4/leam5NlbozLSRKhcOcfGrKOnVtHX6E73f5z3cnfSRqL3hodLlkad9bm87DibKgJP0E0DkFaAyfC/D8sC5QrFaQJaZxpXlmnjA4Jm3yCriC1TSPWQ04LVtUcYWH1LTapbMHKv+Pz6vjI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: d30a369b90a641c2 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gEIYJdc0yyi5RXnQOrQNUs6YHStEwHKlUP6grD2AZWAABBCHLTaD/p6nCVMiZ0BkyxFrI2MOW+RJQ6KYZH2k/pCIu/WnWBXYvDI4byiSc9LgD1fgX+kjGoCYkf23U1+Kl7UxEkbVyYIaOXWQMpClhkRJMaj64dSZfIEEcrNRgy8+UYIpCZV68b0HUKWFe9HWcLHw7BldmvgaOtMs4iX7U6gCNRxdj/0jfiIgD2k2BiViWiDUFawslVi0kcQaixpf75keukQJ+77AdkK4ZXXVuTJY7a/KAFlfep3hdpkEdwGHnF5El+KMEg5nlVHlB32OOZae1NfmHLSMpKVNv558ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pSKQAci77+VJmJ0vscZTCxSI6oueURxbYe5hjUdP5TI=; b=KWFfbPHSvfqKQjUEtO2A5NEtaxF/941eveGpbz/REFGLYwyQv6tYeeEK9i9cP0LmelfUDn62FLBvXEFJBf9XxUVKsswfxLl6bkNF5rHro5mDhB9/ISUDd4d2jLRJQj0OaacquaO8j9SjFXXOw+xKKRFPkMhb2za3XRM99Oe0u4ahsrw0soTlmek5btFhV7nCHGrF62ZQQVFVfu98XMcVEMKTaBh7bWyQ+5jPe0cAGaVJoCZTjIxZk80KGd3/8bCyE1QI59zFFmGUGpzhc12k/IJt2RCbNi7JeOW8nWzs5pkZjo4D2IktNb91AS17h5UGSvTw6Kejq6HSsnj45/EzZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pSKQAci77+VJmJ0vscZTCxSI6oueURxbYe5hjUdP5TI=; b=v3Yx7PTW9R4p2PEHw+zsZSBUZdTA5S4/leam5NlbozLSRKhcOcfGrKOnVtHX6E73f5z3cnfSRqL3hodLlkad9bm87DibKgJP0E0DkFaAyfC/D8sC5QrFaQJaZxpXlmnjA4Jm3yCriC1TSPWQ04LVtUcYWH1LTapbMHKv+Pz6vjI= From: Bertrand Marquis To: Michal Orzel CC: Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu Subject: Re: [PATCH v7] arm: Add Kconfig entry to select CONFIG_DTB_FILE Thread-Topic: [PATCH v7] arm: Add Kconfig entry to select CONFIG_DTB_FILE Thread-Index: AQHXGXzxZpQ/TGqhSkqtfY2YUu6quKqE2RuA Date: Mon, 15 Mar 2021 10:29:15 +0000 Message-ID: References: <20210315092342.26533-1-michal.orzel@arm.com> In-Reply-To: <20210315092342.26533-1-michal.orzel@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.26.33.241] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: dd74df1f-8ca1-4d92-492e-08d8e79d473a x-ms-traffictypediagnostic: VI1PR0801MB1872:|PR2PR08MB4796: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: O0pQdBtHg+briUXdrtne8wEVP1uBlS7+eYYZ3cAzW5tK9p17S8jk/i/OObxtZ3qdZiAU6IOf1qSLIoafMNXnlD+7UZcsC3Qa8lUT8G+cO29nHOL3HabarUp0V2dKJ5VKarsYHHgoD7W/yBfry/TDrA0anD9LqYAh9k6rcc2PXZ2AxJpKLL7VM4Dk+jb64D6Yv5IK+4FVe2QwwsEHyMfpSSBoQwAckpRq4g+J6zyaC0UTq4GZ1ftlr0tlP2ULBUA591gjEIblGoGeHVuYqANyrSyvbsXImD3k/Z8Xgo2/MBSV5JAAVPzFQuw/UZIhq0W5QQVLVed7k1D5SH5sst0rIznNLM1pjXqr8hPnGgrb7XwR9wS6ROC3gBQplP4YE+FOUvoi7dyc1sQg4NSCNIIm16btKpFnKSYT1f8QMHYE5I5YKTXMtQwVgKe8lFqiR0ILnozBSM2x0ri+kdqud46nUlk9IpalIzFCxn1gm/qhPUC3XK31BqUy1fEmSN7k8cXynmSnh7cI7Tyww3k0XrOhIawfaq6am3qXBenklMXLD7Rk0E6iwaiCsc49i1yLapTLfoj/qqRUuSRtTzffMq2DM1tGfT+3V6qDrCC0RpghJexF9fiUf1rAsV0Yvs2+XN7p X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(376002)(346002)(136003)(396003)(26005)(6512007)(6862004)(186003)(86362001)(2906002)(36756003)(33656002)(4326008)(37006003)(8676002)(54906003)(66556008)(6636002)(478600001)(5660300002)(316002)(91956017)(6506007)(66476007)(8936002)(64756008)(6486002)(71200400001)(2616005)(76116006)(66946007)(55236004)(53546011)(83380400001)(66446008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?rv4exRJ5ZzNZsPiY11N1KoMwDABXbwfT8f96VgXQJFzdBnYA8qq+YPdx2myW?= =?us-ascii?Q?QHGqhRI+L5qQFcUUcq4VNmyEV99difn1quRNQt0NYqo+s/I2rCvoTtwjzTMR?= =?us-ascii?Q?SRIgnoIb0Lqv0oURMu/Blr8sJPFVzLFKm/r0ZOqMl46GBQoTMy4EnKdzjqrs?= =?us-ascii?Q?p07/NtAO1xyLy8gqZL/DC957enkSf9Gb2KmAVnwoA5mDrit8JLAN5HcQdQ8Z?= =?us-ascii?Q?jYdmT50gV19RsobhjGRGRWZ1ptFlfE7FWZFi2YYdtf4FSYI5eeENavqD3vQZ?= =?us-ascii?Q?Jx3PVKhX0nCoiLDefajgbOJSgrAhr4V4rD5+H0K/nxD6tCRpZE9Ba2RSwzfX?= =?us-ascii?Q?IdN0Uy2VaiyxyV3g04WxJIbqNTQBTOWLLCWtahcBbTHKnYKUBI6mxm2aTtdJ?= =?us-ascii?Q?iTNA4i3/1AkfaQmuyMgxKxF5AJK8ivmiy4c2/YiBEUMqy/d0p4LugkKCNq2o?= =?us-ascii?Q?qqfIEMLv8uKBcQcao7pmRgS0c0kivb/59WtUkvMoL2MVT05f0kdITDvf1+Rg?= =?us-ascii?Q?4OwOS402lyEFJuKorT9IHcyDDvWWHG3Q0cLazOgyrUdcDKiB8nHrItgjUOlg?= =?us-ascii?Q?JtUF7wuAm+9N9kgW/o5+FPbK76td3aO3mJp/sm2pwqHwkYzHMSEXa3o5fE/o?= =?us-ascii?Q?EFR+S3FdwboLBRf8ozILm7IUAsfPo2xfcxLtNGmouOXR8v7ufnEhKU/WT1ms?= =?us-ascii?Q?43A+xFMHy7js0wvUQzmVUVamFFAFBI65OEAE0MyM3LNP9aLWVzb1wdnSiCaO?= =?us-ascii?Q?veWZJdZ1dgH3l5MRyVye1jPZLjw1U0Y3oTAbHlxQ6H1uY0jNOG1k/Ly57Ch6?= =?us-ascii?Q?1oSZfd5xnpw8u8CcKPo6Ucmqe1rMJ9EBBh9kIDwrDT4Uad41faqyVB/u7nyt?= =?us-ascii?Q?i3uSwFbSlNPsNCt+yRZ103i2eTrJMNZmZvjndVaq60H33hljlABtn5n7R/Bx?= =?us-ascii?Q?yPH2mbQ2wXRFOrJlJBuAvDhY2AHySNjiT4IUJ/mjmYbA/yztOWRCHanrxhmy?= =?us-ascii?Q?IscvcvRFLMdsxF+UManhZoaKo8tfJFVO/ihd29/D+bKYRXcioyRE/YaQtEvd?= =?us-ascii?Q?Ve92AI37I7EjXTZ/htJeGQYI0j5CWdW+rZiLBr4t4kSi31JDoHautxuFtpIY?= =?us-ascii?Q?p5sgjT3mNPWicjIE/cYxnmDzdkz87nOHMyNQnmpLFmHUcAZoro8oqVqK7ehz?= =?us-ascii?Q?/SWQTg0M1rGYceZj9F6JpVqdWi1WMAi/Ys8qY6VVrKmJjtWS39Ku/8zHf+y8?= =?us-ascii?Q?a5s7Pj6YfBKRRhSqocTj2iArXakdqj3Et1tQoxfJDI0JaAQtsXYuzIPEHbcq?= =?us-ascii?Q?jbCVLjddawUb2JVmFdAX8g6E?= Content-Type: text/plain; charset="us-ascii" Content-ID: <61B7C66E9F819D448C70081DB23EB031@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1872 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 744eded7-49d4-448e-6274-08d8e79d2f0a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /iy953T8Dczni2OQ5ew+IfYUCgmt68V8aZupSyVy1q/iGQZmcLuECwKpcUqsMpbA7xYXbECal/YDeScQMSh4lEo/2dwDocpTtMA4cc7Ou+QUqhnESKO2spbeS0Cob8kGCaDx67BJtYX8t8MlCRE3/w0flB5rUPXw8lW23qbkWrlqXpYNz4jYcNcdFzUjPzn2V1uMK/eYchO+jvmJysol3lT5aHx9XRQSqGUfACWxWik2dNOMUD7VOrK7+hIq6isWmeVj1nMhB+gwn2fhR8kZeUH2ZRUQkdeEniFElbMsiCtwQUHsH7ixP9twjS5r1TsvdfFDDLfEWWWe6JOFM8dtTUA6rU7L4bdjqsee903Kr27DojYIzp2i+JZLkklIvQwcIoluuIhKDIS3a8mV3AKTY2PZkl2/gAEGgNalbZTHi7WGEtC3BCCubB2560TDsp5ka7jFbIngZEuHthgWIg4oFvWQ2cMTg52v28E+zMcQ3RWAv/M/FK3Lg9fy9Xwr90wnJaf3IXv35hR/U8SItIWUm6tl+1avUndV5XeYjHl2J7QXkdjTkFVQJog/vtKPUP+JiapIHWirzDIlACIDqpxo13LmotX7OhiTzT0K+3N0o268LU3+arkZM3eBTFUevgzwnT564n4aAs2OIECJLV8zUaYXHLu8ZRQNW80gLVY5/Q4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(39860400002)(396003)(136003)(376002)(36840700001)(46966006)(83380400001)(356005)(47076005)(36756003)(316002)(6506007)(6486002)(82310400003)(5660300002)(86362001)(36860700001)(82740400003)(37006003)(54906003)(33656002)(478600001)(8936002)(81166007)(186003)(336012)(6636002)(70206006)(70586007)(2906002)(6512007)(6862004)(4326008)(26005)(2616005)(55236004)(53546011)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2021 10:29:56.3739 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd74df1f-8ca1-4d92-492e-08d8e79d473a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4796 Hi Michal, > On 15 Mar 2021, at 09:23, Michal Orzel wrote: >=20 > Currently in order to link existing DTB into Xen image > we need to either specify option CONFIG_DTB_FILE on the > command line or manually add it into .config. > Add Kconfig entry: CONFIG_DTB_FILE > to be able to provide the path to DTB we want to embed > into Xen image. If no path provided - the dtb will not > be embedded. >=20 > Remove the line: AFLAGS-y +=3D -DCONFIG_DTB_FILE=3D\"$(CONFIG_DTB_FILE)\" > as it is not needed since Kconfig will define it in a header > with all the other config options. >=20 > Make a change in the linker script from: > _sdtb =3D .; > to: > PROVIDE(_sdtb =3D .); > to avoid creation of _sdtb if there is no reference to it. >=20 > Signed-off-by: Michal Orzel Reviewed-by: Bertrand Marquis The use of ifnes and PROVIDE is very clever :-) Cheers Bertrand > --- > xen/arch/arm/Makefile | 5 ++--- > xen/arch/arm/arm32/head.S | 4 ++-- > xen/arch/arm/arm64/head.S | 4 ++-- > xen/arch/arm/xen.lds.S | 4 +--- > xen/common/Kconfig | 10 ++++++++++ > 5 files changed, 17 insertions(+), 10 deletions(-) >=20 > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index 16e6523e2c..46e6a95fec 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -68,9 +68,8 @@ extra-y +=3D $(TARGET_SUBARCH)/head.o >=20 > #obj-bin-y +=3D ....o >=20 > -ifdef CONFIG_DTB_FILE > +ifneq ($(CONFIG_DTB_FILE),"") > obj-y +=3D dtb.o > -AFLAGS-y +=3D -DCONFIG_DTB_FILE=3D\"$(CONFIG_DTB_FILE)\" > endif >=20 > ALL_OBJS :=3D $(TARGET_SUBARCH)/head.o $(ALL_OBJS) > @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c > xen.lds: xen.lds.S > $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >=20 > -dtb.o: $(CONFIG_DTB_FILE) > +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) >=20 > .PHONY: clean > clean:: > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S > index c404fa973e..50f019ed98 100644 > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -156,10 +156,10 @@ past_zImage: > sub r10, r9, r0 /* r10 :=3D phys-offset */ >=20 > /* Using the DTB in the .dtb section? */ > -#ifdef CONFIG_DTB_FILE > +.ifnes CONFIG_DTB_FILE,"" > ldr r8, =3D_sdtb > add r8, r10 /* r8 :=3D paddr(DTB) */ > -#endif > +.endif >=20 > /* Initialize the UART if earlyprintk has been enabled. */ > #ifdef CONFIG_EARLY_PRINTK > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 5d44667bd8..f38a8dfca7 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -296,9 +296,9 @@ real_start_efi: > sub x20, x19, x0 /* x20 :=3D phys-offset */ >=20 > /* Using the DTB in the .dtb section? */ > -#ifdef CONFIG_DTB_FILE > +.ifnes CONFIG_DTB_FILE,"" > load_paddr x21, _sdtb > -#endif > +.endif >=20 > /* Initialize the UART if earlyprintk has been enabled. */ > #ifdef CONFIG_EARLY_PRINTK > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S > index 004b182acb..540a7ccc9d 100644 > --- a/xen/arch/arm/xen.lds.S > +++ b/xen/arch/arm/xen.lds.S > @@ -220,11 +220,9 @@ SECTIONS > } :text > _end =3D . ; >=20 > -#ifdef CONFIG_DTB_FILE > /* Section for the device tree blob (if any). */ > - _sdtb =3D .; > + PROVIDE(_sdtb =3D .); > .dtb : { *(.dtb) } :text > -#endif >=20 > /* Sections to be discarded */ > /DISCARD/ : { > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index eb953d171e..a1755cd380 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -400,6 +400,16 @@ config DOM0_MEM >=20 > Leave empty if you are not sure what to specify. >=20 > +config DTB_FILE > + string "Absolute path to device tree blob" > + depends on HAS_DEVICE_TREE > + help > + When using a bootloader that has no device tree support or when there > + is no bootloader at all, use this option to specify the absolute path > + to a device tree that will be linked directly inside Xen binary. > + > + This is an optional config. Leave empty if not needed. > + > config TRACEBUFFER > bool "Enable tracing infrastructure" if EXPERT > default y > --=20 > 2.29.0 >=20 From xen-devel-bounces@lists.xenproject.org Mon Mar 15 10:38:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 10:38:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97935.185706 (Exim 4.92) (envelope-from ) id 1lLkcY-0003y3-42; Mon, 15 Mar 2021 10:38:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97935.185706; Mon, 15 Mar 2021 10:38:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLkcY-0003xw-18; Mon, 15 Mar 2021 10:38:46 +0000 Received: by outflank-mailman (input) for mailman id 97935; Mon, 15 Mar 2021 10:38:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLkcW-0003xr-8m for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 10:38:44 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 38702ad3-3c74-4245-beb8-ef545faee937; Mon, 15 Mar 2021 10:38:43 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F12C31FB; Mon, 15 Mar 2021 03:38:42 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 387793F70D; Mon, 15 Mar 2021 03:38:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38702ad3-3c74-4245-beb8-ef545faee937 From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2] xen/arm: Use register_t type of cpuinfo entries Date: Mon, 15 Mar 2021 10:38:30 +0000 Message-Id: <7a6a8c5c33d13fb43f3777f046036b91233534d3.1615804612.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.17.1 All cpu identification registers that we store in the cpuinfo structure are 64bit on arm64 and 32bit on arm32 so storing the values in 32bit on arm64 is removing the higher bits which might contain information in the future. This patch is changing the types in cpuinfo to register_t (which is 32bit on arm32 and 64bit on arm64) and adding the necessary paddings inside the unions. For consistency uint64_t entries are also changed to register_t on 64bit systems. It is also fixing all prints using directly the bits values from cpuinfo to use PRIregister and adapt the printed value to print all bits available on the architecture. Signed-off-by: Bertrand Marquis --- Changes since v1: - add sentence on changing 64bit types in commit message - fix smpboot printk split --- xen/arch/arm/setup.c | 17 ++++++++-------- xen/arch/arm/smpboot.c | 5 +++-- xen/include/asm-arm/cpufeature.h | 34 +++++++++++++++++++++----------- 3 files changed, 35 insertions(+), 21 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 2532ec9739..9ba2f267f6 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -116,8 +116,8 @@ static void __init processor_id(void) printk("Huh, cpu architecture %x, expected 0xf (defined by cpuid)\n", c->midr.architecture); - printk("Processor: %08"PRIx32": \"%s\", variant: 0x%x, part 0x%03x, rev 0x%x\n", - c->midr.bits, implementer, + printk("Processor: %"PRIregister": \"%s\", variant: 0x%x, part 0x%03x," + "rev 0x%x\n", c->midr.bits, implementer, c->midr.variant, c->midr.part_number, c->midr.revision); #if defined(CONFIG_ARM_64) @@ -163,7 +163,7 @@ static void __init processor_id(void) if ( cpu_has_aarch32 ) { printk("32-bit Execution:\n"); - printk(" Processor Features: %08"PRIx32":%08"PRIx32"\n", + printk(" Processor Features: %"PRIregister":%"PRIregister"\n", boot_cpu_data.pfr32.bits[0], boot_cpu_data.pfr32.bits[1]); printk(" Instruction Sets:%s%s%s%s%s%s\n", cpu_has_aarch32 ? " AArch32" : "", @@ -176,15 +176,16 @@ static void __init processor_id(void) cpu_has_gentimer ? " GenericTimer" : "", cpu_has_security ? " Security" : ""); - printk(" Debug Features: %08"PRIx32"\n", + printk(" Debug Features: %"PRIregister"\n", boot_cpu_data.dbg32.bits[0]); - printk(" Auxiliary Features: %08"PRIx32"\n", + printk(" Auxiliary Features: %"PRIregister"\n", boot_cpu_data.aux32.bits[0]); - printk(" Memory Model Features: " - "%08"PRIx32" %08"PRIx32" %08"PRIx32" %08"PRIx32"\n", + printk(" Memory Model Features: %"PRIregister" %"PRIregister"\n" + " %"PRIregister" %"PRIregister"\n", boot_cpu_data.mm32.bits[0], boot_cpu_data.mm32.bits[1], boot_cpu_data.mm32.bits[2], boot_cpu_data.mm32.bits[3]); - printk(" ISA Features: %08x %08x %08x %08x %08x %08x\n", + printk(" ISA Features: %"PRIregister" %"PRIregister" %"PRIregister"\n" + " %"PRIregister" %"PRIregister" %"PRIregister"\n", boot_cpu_data.isa32.bits[0], boot_cpu_data.isa32.bits[1], boot_cpu_data.isa32.bits[2], boot_cpu_data.isa32.bits[3], boot_cpu_data.isa32.bits[4], boot_cpu_data.isa32.bits[5]); diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index cae2179126..a1ee3146ef 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -321,8 +321,9 @@ void start_secondary(void) if ( !opt_hmp_unsafe && current_cpu_data.midr.bits != boot_cpu_data.midr.bits ) { - printk(XENLOG_ERR "CPU%u MIDR (0x%x) does not match boot CPU MIDR (0x%x),\n" - "disable cpu (see big.LITTLE.txt under docs/).\n", + printk(XENLOG_ERR + "CPU%u MIDR (0x%"PRIregister") does not match boot CPU MIDR (0x%"PRIregister"),\n" + XENLOG_ERR "disable cpu (see big.LITTLE.txt under docs/).\n", smp_processor_id(), current_cpu_data.midr.bits, boot_cpu_data.midr.bits); stop_cpu(); diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h index 9ea3970c70..ba48db3eac 100644 --- a/xen/include/asm-arm/cpufeature.h +++ b/xen/include/asm-arm/cpufeature.h @@ -118,13 +118,16 @@ int enable_nonboot_cpu_caps(const struct arm_cpu_capabilities *caps); */ struct cpuinfo_arm { union { - uint32_t bits; + register_t bits; struct { unsigned long revision:4; unsigned long part_number:12; unsigned long architecture:4; unsigned long variant:4; unsigned long implementer:8; +#ifdef CONFIG_ARM_64 + unsigned long _res0:32; +#endif }; } midr; union { @@ -148,7 +151,7 @@ struct cpuinfo_arm { #ifdef CONFIG_ARM_64 /* 64-bit CPUID registers. */ union { - uint64_t bits[2]; + register_t bits[2]; struct { /* PFR0 */ unsigned long el0:4; @@ -179,15 +182,15 @@ struct cpuinfo_arm { } pfr64; struct { - uint64_t bits[2]; + register_t bits[2]; } dbg64; struct { - uint64_t bits[2]; + register_t bits[2]; } aux64; union { - uint64_t bits[3]; + register_t bits[3]; struct { unsigned long pa_range:4; unsigned long asid_bits:4; @@ -213,7 +216,7 @@ struct cpuinfo_arm { } mm64; union { - uint64_t bits[2]; + register_t bits[2]; struct { /* ISAR0 */ unsigned long __res0:4; @@ -263,7 +266,7 @@ struct cpuinfo_arm { * when running in 32-bit mode. */ union { - uint32_t bits[3]; + register_t bits[3]; struct { /* PFR0 */ unsigned long arm:4; @@ -274,6 +277,9 @@ struct cpuinfo_arm { unsigned long amu:4; unsigned long dit:4; unsigned long ras:4; +#ifdef CONFIG_ARM_64 + unsigned long __res0:32; +#endif /* PFR1 */ unsigned long progmodel:4; @@ -284,29 +290,35 @@ struct cpuinfo_arm { unsigned long sec_frac:4; unsigned long virt_frac:4; unsigned long gic:4; +#ifdef CONFIG_ARM_64 + unsigned long __res1:32; +#endif /* PFR2 */ unsigned long csv3:4; unsigned long ssbs:4; unsigned long ras_frac:4; unsigned long __res2:20; +#ifdef CONFIG_ARM_64 + unsigned long __res3:32; +#endif }; } pfr32; struct { - uint32_t bits[2]; + register_t bits[2]; } dbg32; struct { - uint32_t bits[1]; + register_t bits[1]; } aux32; struct { - uint32_t bits[6]; + register_t bits[6]; } mm32; struct { - uint32_t bits[7]; + register_t bits[7]; } isa32; struct { -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 15 10:52:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 10:52:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97939.185719 (Exim 4.92) (envelope-from ) id 1lLkpb-0005gv-CT; Mon, 15 Mar 2021 10:52:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97939.185719; Mon, 15 Mar 2021 10:52:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLkpb-0005go-8h; Mon, 15 Mar 2021 10:52:15 +0000 Received: by outflank-mailman (input) for mailman id 97939; Mon, 15 Mar 2021 10:52:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLkpZ-0005gj-Oh for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 10:52:13 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:7e1a::628]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d3893d09-9167-46e6-a3ad-7966885ed812; Mon, 15 Mar 2021 10:52:12 +0000 (UTC) Received: from AM6P191CA0072.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::49) by AM6PR08MB4069.eurprd08.prod.outlook.com (2603:10a6:20b:af::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Mon, 15 Mar 2021 10:52:10 +0000 Received: from VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::ea) by AM6P191CA0072.outlook.office365.com (2603:10a6:209:7f::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Mon, 15 Mar 2021 10:52:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT039.mail.protection.outlook.com (10.152.19.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Mon, 15 Mar 2021 10:52:09 +0000 Received: ("Tessian outbound 520e67c3dd94:v71"); Mon, 15 Mar 2021 10:52:09 +0000 Received: from 259595590960.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AFB84612-68FB-4149-BDB0-13682B591499.1; Mon, 15 Mar 2021 10:51:52 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 259595590960.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 15 Mar 2021 10:51:52 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VI1PR08MB4445.eurprd08.prod.outlook.com (2603:10a6:803:fb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Mon, 15 Mar 2021 10:51:49 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3933.032; Mon, 15 Mar 2021 10:51:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3893d09-9167-46e6-a3ad-7966885ed812 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X0XzOQVLvAUXQn3ZyykpaVnxCndQp3EHLcUANcPacHc=; b=YEke+q5b3zog4GcFmxv5uGKMCgo3UnKAjH0LXDCMNb7LHw8OREnk8oA0eT3YWXGjD07zQOSliJHbuyH6azmb/MPDFdOMVBat1ybEuHEr8mms0JTC6/9SVnX5KlndUnnqr2KxU/uUAZnW7dyItqACM8rsbezOqLv9iVPU59gsqy8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: c44be2242d4fff11 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=blt5uR2ayGHbPA4glO4P1jqWJ4d05XiWIys7p1TDh5VpeRb1RRcgZmxhhaM//gQN66mZhitjFhhmtH4uptGypegTbJ/DtaZQzjv8Jd99CBmHHvb6GisvBYZZJJGp/g1nB5OjRvP7/V/YPAgci60LOfkXliC+5s0Ecq57y5+sXfx17y3j8wbc97exLENfvzJY6wbje2v/wX/bVr3tuaHDcCEiK1wj17CnYP/W/2zTC01IumsHnB1b4ovQQfIPO7tuJsIFp9digbpp3ksCAF0kF/yRNeM1gQUT7Vs8/GcQ/ZR0uYFOSXIJdNX1QfXanPF7TURvo13KUk8LzS6fZGjPUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X0XzOQVLvAUXQn3ZyykpaVnxCndQp3EHLcUANcPacHc=; b=ikT8kTMW2WImROxRoi/WRA81TI1FRITW3Sav+2eiURSnHiJ8TsN3dBn1GX7UadNrCgjmgV636VzHtYLIwKQ61BmBQGYJIdL0wTujTjBL6KlqecmsFsNI8YoWINh0hMB1ti+HuRg8NOXf3A2vJzb888nrFqUiFGVoXXBUWFV7RPejSNPxFex+1eo46jmhYp5+ZnNUse56yIxPxFHXAyGpXyVyA4D7uQ3nqEFOoWtyktBzVs0wftDKmvm781PlcipfROFMu0kjortZYqHRCuN8sobDLk5KFjuAcs6Op/+PZgSXOrLG8Xu28MTGZziMZ0lRxuzH01h+8UFdiZWwd2M2Gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X0XzOQVLvAUXQn3ZyykpaVnxCndQp3EHLcUANcPacHc=; b=YEke+q5b3zog4GcFmxv5uGKMCgo3UnKAjH0LXDCMNb7LHw8OREnk8oA0eT3YWXGjD07zQOSliJHbuyH6azmb/MPDFdOMVBat1ybEuHEr8mms0JTC6/9SVnX5KlndUnnqr2KxU/uUAZnW7dyItqACM8rsbezOqLv9iVPU59gsqy8= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , "volodymyr_babchuk@epam.com" , Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [PATCH for-4.15 v2] xen: Bump the minimum version of GCC supported to 4.9 for arm32 and 5.1 on arm64 Thread-Topic: [PATCH for-4.15 v2] xen: Bump the minimum version of GCC supported to 4.9 for arm32 and 5.1 on arm64 Thread-Index: AQHXGA6vB6atKsiK0Ei5Zy66swOEN6qE4kaA Date: Mon, 15 Mar 2021 10:51:49 +0000 Message-ID: References: <20210313134158.24363-1-julien@xen.org> In-Reply-To: <20210313134158.24363-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.26.33.241] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 97fd3115-4c31-4415-1eae-08d8e7a0620f x-ms-traffictypediagnostic: VI1PR08MB4445:|AM6PR08MB4069: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mJNY9Yt4CB+0zHkT+1X/UNIlAjdr4rFCY7OGoIu9MyP0s2WoL3fLh8Cr8i679Y/vWeqhJ8aiLpnPaCijq9zW854oKy3WXJj9IUr1AkueLqDiIop3Q70MmTj3ZiQ9FxVlnEwJsYoguT8kIjvky0s4j7ZnhdxlVZKntqwAQpG9rSyaCHnWUCviIvk3xlvfkOVoqSdJwe6/XuXBgJb1wHK0Bx61uU4s76t4C2zv8ngsd3+1qbhF2vwdNtgyJe+DtwAFSuQYACAlIQyHqKYhYXvS0sc77Inmoe3MzP5YPfk2/Ii8Q8Aj3k0HBGsNmz2DikKYkPry4ogfm5HA17YE2parXPT1wyNE5eElZG+9EEyJBmyNWn98PHR5FNCzPkgZSBkGrXJABqxSW5fZ3cGC811t+pSdmRvwTi04RJllCd2u+5yXAlnG7l9b4MXsTIa7qV/uzATA/e/gPOR8lnF7pqtIySHWxHYI8KNoHNAJtG4T9upUWH4PEt1hFx9qGFUUPT/FYqyarT4+i0Sy/lDa4+P7JGzTpdrQrdD68Cigq7sojIDimGoTsQvvkA+323PiYPzsc1HWr1v+gRzLyOjpRb/9t8y1bSeZy6Zoc+2f0YftqPaln2fOc2w3Hh+9vbUTmmi/tcKtUgyrOvDVpmqI+45o5co+Y3MHHschspg8P0FpZbafiskEu4c69lfGatBm5PAA/UtplYG9SnpmrME4VnmgPA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(396003)(346002)(366004)(376002)(7416002)(33656002)(2616005)(5660300002)(2906002)(83380400001)(4326008)(76116006)(6916009)(6486002)(71200400001)(66946007)(53546011)(66556008)(55236004)(6506007)(8676002)(8936002)(36756003)(86362001)(66476007)(26005)(66446008)(478600001)(316002)(186003)(6512007)(54906003)(91956017)(966005)(64756008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?leG63lO/we4kQFapDEBXLNoRKzOsi/KRGIJRq8IYMatN+FtAJrZib+l0RxIh?= =?us-ascii?Q?S9gAwPhdJy5TG32vRxpeJVVuY6buh1xQ+o/P9gYmSh+Vlq26rG1OYTAFZWL6?= =?us-ascii?Q?VOQ0Y0RTgD+F9J+gwNNa6hGt49LyubHw3r/Nf0aFin36OfCAi+SZv1PotHuJ?= =?us-ascii?Q?sSyaIHeMxV6aiMYydiurhc656/ZsvkvkikqW8RDeaOAP+RHCSee3huUHG8DP?= =?us-ascii?Q?MJjTmkkriUoIhhWrCGlLlJ3ima26UDCv7AoAXO0FAwv8oVtwio35qx1vausR?= =?us-ascii?Q?06IYoUFwHFh/EMJiSMW8Z+I5qGOKq0Auy1b8pD/jR4mYqb3Pix+gv4rhhamh?= =?us-ascii?Q?uUwItSAuEjFhbool4Ncn3elERbopm+MKHFP5s2N+X0dIsKk1AREIbHdk3TBc?= =?us-ascii?Q?uolXDE4ToRcsELK8zh4rG1m++g/jlqkAMdZ1S7vQOOpDQ0rGBjq64mAH3i16?= =?us-ascii?Q?5juhuVqTVsVdq7QqcF0wh81ETlvBFi6M9nUDx0O0nGXjxxNUs/9Yt+sdiIxX?= =?us-ascii?Q?dJ3XGpoU32CeL/A/xqLByjPvz12ipujfmdM+4OskT9S/zTOl6TeIkQA+/hRC?= =?us-ascii?Q?RsGlb7m8a5I/iNR5KJf5bKXWwOqesxf8sb9EGxZK7lCxxK9tpmQAydTuuxaM?= =?us-ascii?Q?4rIi+bTzj+bfsS8EO+1s1Tcqgkfp4G5fYEuWI76DL/QfopSpvQ5YuBgJIDUH?= =?us-ascii?Q?HFbl2q0BIqoPSCD/t/AdAGfaDaXb47a1UOkeyUSa3O/5qW13wh9EV/DnyhYP?= =?us-ascii?Q?9Lq6y9RrXM0yclTJQ9W5+jkiUFTazzIMQ5vKmAau8YS9h+PH1AlWkVISQfV3?= =?us-ascii?Q?sD0n467WskpbOt5siJAhwmej6usBAqdUzmj44cbB4oW79BveZdVfZgf7zph3?= =?us-ascii?Q?NWrPX6TaD5g2RimaHULaTOm0eXOqUhDakCAm9rrUfiOKKiouSPjI1Ej8St41?= =?us-ascii?Q?H8b00XHsj3qFzl9TPzs/hXWNuNHEar39bhuR5uj0WiIcPnXJvvRumR4t7oIl?= =?us-ascii?Q?wemdbAddY/1Cau/jS6lvNkhoaCvn9sSL21QPxR+yTVmmuwwQvTjcf4xHMWwb?= =?us-ascii?Q?ijkNRed9Yo6XJ/AnLHPOc3y6xshZwIIuEYDuJ9a7N2CUj5wgY5aXQNJM9qI8?= =?us-ascii?Q?+950nmSV/KaxpUE+hAFsa1qJUy2yShAJJqZ4JOsAa20kpae9zWGHHHjM8a4z?= =?us-ascii?Q?2k7r9y8LpQaxHmyuqbuwEZcDzBGPsnWC6kLgWyyvKXVbv1cNa94cxSMyA8e3?= =?us-ascii?Q?Z85rYPB+lhKc5MY6rbKhobecdHerNcX+XYSW3bWwW69lNa4Rp9OZ/OyMMn+S?= =?us-ascii?Q?8TQm5u7Frk0io6JVFEsxcQEn?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <276765872F5F3D4393A3FBA4F4A44B14@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4445 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 92d58005-0c1a-4d8c-a0ad-08d8e7a055f4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QvelMp/FhN09xOyErEvyQmi/2WFCPN+RtmDhIQ8G0ctvoyroOizcEZ45e5JXh/FHn9IUnOe0DDuKoV95sGuiWxOXkMb/eXEXppy3yoQemQGKFtIIj5Uap69aNceVC3cV4mHIA0gv4nadUjcpXEtZ9xbLy6aRH2znE5zFrD2LH2HX0ke3DPyi4IxupgD8XgeSVnSbELMklvIp8Pas+aCh0XIB0JI0eIT1reUAB0GJFHbVGLjTQK74lyNM7IfSh1mFH/Wn8KfvoSbBWtioBmJuFJaHHfXjndTcQkE/LEECwJVGz+qkMNLin+dwYG0O//WHOIwjjUSGp9dbT+0kuyUprYqQD2obVLe+EO+iHEUT301fDDVdzkwrpoazhCRirtT+fTGq0r+2fM16VVNuLgQjzyvOrVxuQGXSTYO9uELlDJfKI1vFBh1552wFKlaNwdnwYEk8K1jloU6LFYcQx9Z/LEBZ+gQHREPzhqHJrc72Ta+A6dRcG11NRWhcVPJNEE0gkApHhKJFbyadjrYq23v4jibADeEel1Umr60i/FKJRcV908dUCb78wiW/KKbo/VCgNuQKy2XIcd4Mt/MKPpADHQVhNw8HubJY36OQU1iQ5W+4YiZos2gv6r9WMZn2sTJnNJgT84oYBSYWU9vdxuzc8YZl6g7JxQ0BCexHNDlLmVebR6v/svSQNl5fhtsEU66qKGTspWpF6pbrTsRJL35l87M+fMk0KkgxsQGDMR3+Kr0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(136003)(376002)(396003)(346002)(46966006)(36840700001)(336012)(26005)(8676002)(54906003)(70206006)(4326008)(8936002)(36860700001)(86362001)(186003)(5660300002)(6862004)(53546011)(55236004)(6506007)(70586007)(356005)(966005)(6512007)(478600001)(316002)(81166007)(83380400001)(47076005)(36756003)(2906002)(82310400003)(2616005)(82740400003)(33656002)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2021 10:52:09.7587 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 97fd3115-4c31-4415-1eae-08d8e7a0620f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4069 Hi Julien, > On 13 Mar 2021, at 13:41, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Compilers older than 4.8 have known codegen issues which can lead to > silent miscompilation: >=20 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D58145 >=20 > Furthermore, pre-4.9 GCC have known bugs (including things like > internal compiler errors on Arm) which would require workaround (I > haven't checked if we have any in Xen). >=20 > The minimum version of GCC to build the hypervisor on arm is now > raised to 4.9. >=20 > In addition to that, on arm64, GCC version >=3D 4.9 and < 5.1 have been > shown to emit memory references beyond the stack pointer, resulting in > memory corruption if an interrupt is taken after the stack pointer has > been adjusted but before the reference has been executed. >=20 > Therefore, the minimum for arm64 is raised to 5.1. >=20 > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 > --- >=20 > This patch is candidate to 4.15 and backport. >=20 > This is only a build change and will be low-risk for anyone using newer > compiler (5.1+ for arm64 and 4.9+ for arm32). Xen will stop building > for anyone using older compiler. But it is better than fighting > with codegen issues. >=20 > Changes in v2: > - Only bump the GCC version for Arm. > --- > README | 7 +++++-- > xen/include/xen/compiler.h | 10 ++++++++++ > 2 files changed, 15 insertions(+), 2 deletions(-) >=20 > diff --git a/README b/README > index 8c99c30986c1..aa8b4fe126a8 100644 > --- a/README > +++ b/README > @@ -42,8 +42,11 @@ provided by your OS distributor: > - GNU Binutils 2.16.91.0.5 or later > or > - Clang/LLVM 3.5 or later > - - For ARM: > - - GCC 4.8 or later > + - For ARM 32-bit: > + - GCC 4.9 or later > + - GNU Binutils 2.24 or later > + - For ARM 64-bit: > + - GCC 5.1 or later > - GNU Binutils 2.24 or later > * Development install of zlib (e.g., zlib-dev) > * Development install of Python 2.6 or later (e.g., python-dev) > diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h > index 0ec0b4698ea7..17cf00e1ec92 100644 > --- a/xen/include/xen/compiler.h > +++ b/xen/include/xen/compiler.h > @@ -3,6 +3,16 @@ >=20 > #if !defined(__GNUC__) || (__GNUC__ < 4) > #error Sorry, your compiler is too old/not recognized. > +#elif CONFIG_CC_IS_GCC > +# if defined(CONFIG_ARM_32) && CONFIG_GCC_VERSION < 40900 > +# error Sorry, your version of GCC is too old - please use 4.9 or newer= . > +# elif defined(CONFIG_ARM_64) && CONFIG_GCC_VERSION < 50100 > +/* > + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D63293 > + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk > + */ > +# error Sorry, your version of GCC is too old - please use 5.1 or newer= . > +# endif > #endif >=20 > #define barrier() __asm__ __volatile__("": : :"memory") > --=20 > 2.17.1 >=20 From xen-devel-bounces@lists.xenproject.org Mon Mar 15 11:01:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 11:01:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97944.185731 (Exim 4.92) (envelope-from ) id 1lLkyQ-0006hW-AB; Mon, 15 Mar 2021 11:01:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97944.185731; Mon, 15 Mar 2021 11:01:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLkyQ-0006hP-6X; Mon, 15 Mar 2021 11:01:22 +0000 Received: by outflank-mailman (input) for mailman id 97944; Mon, 15 Mar 2021 11:01:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLkyO-0006hH-Tf; Mon, 15 Mar 2021 11:01:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLkyO-0006Lk-Hz; Mon, 15 Mar 2021 11:01:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLkyO-0003Wo-8B; Mon, 15 Mar 2021 11:01:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLkyO-0005xo-7i; Mon, 15 Mar 2021 11:01:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=A47dgOIo3xhR/Fgr1cFlzl2b4+INVb3ZRLKuXPmx1lw=; b=skMpISmlSq82q48WC0zGoPjqt4 LxsfZuQdzZyHQ06tFfixXCQTw1rgmkh8Rd6+0hxx+ABMQ9IRjvDdI2t3s+9TC4xsPQ8LUbvMkByak nnrp8aMt7SbA5xabj0BZwgaK3PzMNLvz2DX+R5gTzAXddo3yXa/81uT8lGESvBrfwN5g=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160086: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b4011741e6b39a8fd0ed5aded96c16c45ead5888 X-Osstest-Versions-That: xen=14b95b3b8546db201e7efd0636ae0e215fae98f3 From: osstest service owner Date: Mon, 15 Mar 2021 11:01:20 +0000 flight 160086 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160086/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen b4011741e6b39a8fd0ed5aded96c16c45ead5888 baseline version: xen 14b95b3b8546db201e7efd0636ae0e215fae98f3 Last test of basis 160044 2021-03-12 20:01:32 Z 2 days Testing same since 160086 2021-03-15 08:01:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 14b95b3b85..b4011741e6 b4011741e6b39a8fd0ed5aded96c16c45ead5888 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Mar 15 12:02:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 12:02:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97970.185750 (Exim 4.92) (envelope-from ) id 1lLlvC-0003td-6W; Mon, 15 Mar 2021 12:02:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97970.185750; Mon, 15 Mar 2021 12:02:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLlvC-0003tW-3O; Mon, 15 Mar 2021 12:02:06 +0000 Received: by outflank-mailman (input) for mailman id 97970; Mon, 15 Mar 2021 12:02:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLlvA-0003tO-P2; Mon, 15 Mar 2021 12:02:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLlvA-0007KV-Jg; Mon, 15 Mar 2021 12:02:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLlvA-00062u-8g; Mon, 15 Mar 2021 12:02:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLlvA-0001l8-8D; Mon, 15 Mar 2021 12:02:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rJB3til1dcX39ubFHtdHM1Zm1sqohomXDDj4C8CbxcI=; b=ebIzxNmBX+4F55FFmgMuXmKXx/ 9Y6Vee8mEwuG4yuZm2Ff7wu0QVU4PAMv2LNiMAZIh0rTVQurgmC3qJGZ0olOzYB73q7ATLTYCdg0I BDT5J6z/brUaR7gKZxznoZRSlp8ahKC05G1B9aKu135whtFV4tA5UR/GVMjYgtV481pU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160082: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=6157b0e19721aadb4c7fdcfe57b2924af6144b14 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Mon, 15 Mar 2021 12:02:04 +0000 flight 160082 qemu-mainline real [real] flight 160087 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160082/ http://logs.test-lab.xenproject.org/osstest/logs/160087/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 6157b0e19721aadb4c7fdcfe57b2924af6144b14 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 207 days Failing since 152659 2020-08-21 14:07:39 Z 205 days 399 attempts Testing same since 160082 2021-03-15 01:37:25 Z 0 days 1 attempts ------------------------------------------------------------ 446 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 128713 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 15 12:05:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 12:05:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97977.185764 (Exim 4.92) (envelope-from ) id 1lLlyN-000436-MN; Mon, 15 Mar 2021 12:05:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97977.185764; Mon, 15 Mar 2021 12:05:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLlyN-00042z-JO; Mon, 15 Mar 2021 12:05:23 +0000 Received: by outflank-mailman (input) for mailman id 97977; Mon, 15 Mar 2021 12:05:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLlyM-00042p-Ee for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 12:05:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLlyM-0007OL-CB for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 12:05:22 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lLlyM-00064C-9p for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 12:05:22 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lLlyJ-0004mW-50; Mon, 15 Mar 2021 12:05:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=5C6YHNb9mKMR9zGcpSuojSreFEYHt4Tjj7d+u737k3Q=; b=wpTj24yCWA5mmBBFqmrH+2YllC Mt+o3xuP5xUchgqN24x/025ft/CdQIGzncb9aCE5h9LrGuVSijiqns3JWZwRnWjDN1l/Q5omFN9TE DEfmDwSXLcGLmGiqueDSj02mIkgrEpE8KlGb59oO6dDnnoSIz00mXf7HejlkO7U+6iVs=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24655.19838.973233.143341@mariner.uk.xensource.com> Date: Mon, 15 Mar 2021 12:05:18 +0000 To: Julien Grall Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, volodymyr_babchuk@epam.com, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [PATCH for-4.15 v2] xen: Bump the minimum version of GCC supported to 4.9 for arm32 and 5.1 on arm64 In-Reply-To: <20210313134158.24363-1-julien@xen.org> References: <20210313134158.24363-1-julien@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("[PATCH for-4.15 v2] xen: Bump the minimum version of GCC supported to 4.9 for arm32 and 5.1 on arm64"): > From: Julien Grall > > Compilers older than 4.8 have known codegen issues which can lead to > silent miscompilation: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 > > Furthermore, pre-4.9 GCC have known bugs (including things like > internal compiler errors on Arm) which would require workaround (I > haven't checked if we have any in Xen). > > The minimum version of GCC to build the hypervisor on arm is now > raised to 4.9. > > In addition to that, on arm64, GCC version >= 4.9 and < 5.1 have been > shown to emit memory references beyond the stack pointer, resulting in > memory corruption if an interrupt is taken after the stack pointer has > been adjusted but before the reference has been executed. > > Therefore, the minimum for arm64 is raised to 5.1. > > Signed-off-by: Julien Grall Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Mon Mar 15 12:05:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 12:05:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97979.185776 (Exim 4.92) (envelope-from ) id 1lLlyd-00047b-Uj; Mon, 15 Mar 2021 12:05:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97979.185776; Mon, 15 Mar 2021 12:05:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLlyd-00047U-Ra; Mon, 15 Mar 2021 12:05:39 +0000 Received: by outflank-mailman (input) for mailman id 97979; Mon, 15 Mar 2021 12:05:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLlyc-00047D-9F for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 12:05:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLlyc-0007Ox-6w for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 12:05:38 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lLlyc-000675-6E for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 12:05:38 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lLlyZ-0004n2-38; Mon, 15 Mar 2021 12:05:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=EMxp4uZHJsd13v/nRw6ih9u5bji4EkS68qoT42V0L2w=; b=ot3EYrIn8q8Qvo3kHXR0ATy7ju Q/fYgckm/4gn5f7Ye46ikiPjs/oMebr7UWlF8Cbpv6ufkGu0iSwCywJr8w8JvyHrXR79UGZGCw9l5 4flEd/U0dv+k+Uj2eRYho+FNTy8q7wJ8IAHivqMGpZbqHf9nxrnHMmdijP0scaLHvDbo=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24655.19854.938658.909308@mariner.uk.xensource.com> Date: Mon, 15 Mar 2021 12:05:34 +0000 To: Julien Grall Cc: xen-devel@lists.xenproject.org, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Juergen Gross Subject: Re: [PATCH for-4.15] SUPPORT.MD: Mark C XenStored LiveUpdate as Tech Preview In-Reply-To: <20210313135500.27241-1-julien@xen.org> References: <20210313135500.27241-1-julien@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("[PATCH for-4.15] SUPPORT.MD: Mark C XenStored LiveUpdate as Tech Preview"): > From: Julien Grall > > Support to liveupdate C XenStored was adding during the 4.15 > development cycle. Add a section in SUPPORT.MD to explain what is the > support state. > > For now, it is a tech preview. > > Signed-off-by: Julien Grall Reviewed-by: Ian Jackson Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Mon Mar 15 12:15:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 12:15:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97985.185789 (Exim 4.92) (envelope-from ) id 1lLm7b-0005AQ-Ps; Mon, 15 Mar 2021 12:14:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97985.185789; Mon, 15 Mar 2021 12:14:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLm7b-0005AJ-Ms; Mon, 15 Mar 2021 12:14:55 +0000 Received: by outflank-mailman (input) for mailman id 97985; Mon, 15 Mar 2021 12:14:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLm7b-0005A4-01 for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 12:14:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLm7a-0007aN-VT for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 12:14:54 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lLm7a-0006js-US for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 12:14:54 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lLm7X-0003tJ-Mb; Mon, 15 Mar 2021 12:14:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID: Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=USBbzM/XOaBEpC7riV/wEGY0P7yozameGwecBSEVX2s=; b=uaCngqlBRqSfqWbY+m77sKuYOY oZnA3w+FmAN0o3pvSYYTG4mAKzqox7XeGUnphzDSki+jq8AZlnJeM7v3MvnyU61K0EFanCBTFhUpI o9j2K3YKVt95V6273tMyPZzz1e3aJaKIvae+MRy9Sd2sxIcXjxnOiVB2mI5IHIOuEYgc=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24655.20411.433579.576842@mariner.uk.xensource.com> Date: Mon, 15 Mar 2021 12:14:51 +0000 To: xen-announce@lists.xenproject.org CC: xen-devel@lists.xenproject.org, xen-users@lists.xenproject.org Subject: Xen 4.15 RC3 Xen 4.15 RC3 is now available. It is available from git: git clone https://xenbits.xenproject.org/git-http/xen.git -b 4.15.0-rc3 For your convenience a tarball is available: https://downloads.xenproject.org/release/xen/4.15.0-rc3/xen-4.15.0-rc3.tar.gz https://downloads.xenproject.org/release/xen/4.15.0-rc3/xen-4.15.0-rc3.tar.gz.sig Please send bug reports and test reports to xen-devel@lists.xenproject.org. When sending bug reports, please CC relevant maintainers and me (iwj@xenproject.org). I will send an update on the state of the release in a moment. Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 15 12:18:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 12:18:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97991.185801 (Exim 4.92) (envelope-from ) id 1lLmAo-0005QC-Dj; Mon, 15 Mar 2021 12:18:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97991.185801; Mon, 15 Mar 2021 12:18:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLmAo-0005Q5-9G; Mon, 15 Mar 2021 12:18:14 +0000 Received: by outflank-mailman (input) for mailman id 97991; Mon, 15 Mar 2021 12:18:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLmAn-0005Q0-9r for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 12:18:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLmAn-0007e6-8e for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 12:18:13 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lLmAn-0006r6-5x for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 12:18:13 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lLmAk-0003uH-1w; Mon, 15 Mar 2021 12:18:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID: Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=6fUQAluxGPgpdxAwSarKSvJdtmGcprvaQt1ogNA/Y+0=; b=0qqMdY2V0A0qX/QZuT833uAuaK ORMhnFspV2W604UZqVKtR9CE6jhrbIqBpvw/esWtjNt37aTu761RhBZ45BbSIXFyywzeJ16GLXATY jHfKAl6TDyqa0pmMk/ZsNuUL0VMsOgu2R3HG0YxZk+LoInhzH0kIIc34GWkUE23LBFTk=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24655.20609.834996.744652@mariner.uk.xensource.com> Date: Mon, 15 Mar 2021 12:18:09 +0000 To: committers@xenproject.org, xen-devel@lists.xenproject.org CC: Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Fr=E9d=E9ric?= Pierret , Dario Faggioli Subject: [ANNOUNCE] Xen 4.15 release update - still in feature freeze Thanks everyone for your hard work so far. I think things are looking pretty good, although we have slipped. Please see below for my updated list of release blockers and tracking issues. Please let me know if there is information missing, or if you have corrections. There is one issue on my radar that I am concerned about and want to see sorted out: "io-apic issue on Ryzen 1800X". If we can't get it fixed soon we may have to live with it as a release notes issue. I am probably going to take the scheduler issues off this list because I haven't seen any sign of activity, and because I don't actually think there are release critical bugs there. Please let me know if you disagree. As previously announced, we are still in codefreeze. All changes must have a release-ack. My current tentative schedule is: Tuesday 16th March RC3 test day Wednesday 17th March Branch, turn off debug on the 4.15 branch xen-next will be open but only for non-disruptive changes Monday 22nd March RC4 Tuesday 23nd March RC4 test day Week of 29th March **tentative* Release (probably Tuesday or Wednesday) Thanks, Ian. OPEN ISSUES AND BLOCKERS ======================== io-apic issue on Ryzen 1800X Related Qubes issue tracking this: https://github.com/QubesOS/qubes-issues/issues/6423 Information from Jan Beulich Andrew Cooper Frdric Pierret ABI stability checking [PATCH for-4.15 00/10] tools: Support to use abi-dumper on libraries [PATCH v2 for-4.15] tools/libxl: Work around unintialised variable libxl__domain_get_device_model_uid() etc. This is testing/build work and will enable ABI checking of future changes to 4.15 after its release. I don't think it's a blocker but it would be nice to have. My most recent impression is that there are still some loose ends here. SCHEDULER ISSUES NOT MAKING PROCESS ? ------------------------------------- BUG: credit=sched2 machine hang when using DRAKVUF Information from Dario Faggioli References https://lists.xen.org/archives/html/xen-devel/2020-05/msg01985.html https://lists.xenproject.org/archives/html/xen-devel/2020-10/msg01561.html https://bugzilla.opensuse.org/show_bug.cgi?id=1179246 Quoting Dario: | Manifests only with certain combination of hardware and workload. | I'm not reproducing, but there are multiple reports of it (see | above). I'm investigating and trying to come up at least with | debug patches that one of the reporter should be able and willing to | test. Dario is working on this. Last update 29.1.21 ? G. Null scheduler and vwfi native problem Information from Dario Faggioli References https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg01634.html Quoting Dario: | RCU issues, but manifests due to scheduler behavior (especially | NULL scheduler, especially on ARM). | | Patches that should solve the issue for ARM posted already. They | will need to be slightly adjusted to cover x86 as well. As of last update from Dario 29.1.21: waiting for test report from submitter. H. Ryzen 4000 (Mobile) Softlocks/Micro-stutters Information from Dario Faggioli As of last update from Dario 29.1.21: Discussions currently ongoing about the severity of this issue. ISSUES BELIEVED NEWLY RESOLVED ============================== Fallout from MSR handling behavioral change. I think there are now no outstanding patches to fix/change MSR behaviour and there is no longer any blocker here ? Key partipants: Jan Beulich Andrew Cooper Use-after-free in the IOMMU code Information from Julien Grall References [PATCH for-4.15 v5 0/3] xen/iommu: Collection of bug fixes for IOMMU teardown Now committed "x86/PV: avoid speculation abuse through guest accessors" Information from Jan Beulich | F. The almost-XSA "x86/PV: avoid speculation abuse through guest | accessors" - the first 4 patches are needed to address the actual | issue. The next 3 patches are needed to get the tree into | consistent state again, identifier-wise. The remaining patches | can probably wait. This has been committed. Problems with xl save / cancel Information from Jrgen Gro: xl daemon won't kill the domain after it has gone through a suspend-cancel cycle. I think this was fixed by tools/libs/light: fix xl save -c handling x86/time: calibration rendezvous adjustments Information from Jan Beulich Not entirely a regression. 3 out of the 4 patches seem to have been committed. Patch 4/ is not targeted at 4.15 I think. From xen-devel-bounces@lists.xenproject.org Mon Mar 15 12:18:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 12:18:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.97996.185813 (Exim 4.92) (envelope-from ) id 1lLmBN-0005Wr-RJ; Mon, 15 Mar 2021 12:18:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97996.185813; Mon, 15 Mar 2021 12:18:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLmBN-0005Wk-O0; Mon, 15 Mar 2021 12:18:49 +0000 Received: by outflank-mailman (input) for mailman id 97996; Mon, 15 Mar 2021 12:18:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLmBM-0005Vx-1x for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 12:18:48 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 93f307eb-1c54-4617-9d0a-8d454e5b4927; Mon, 15 Mar 2021 12:18:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93f307eb-1c54-4617-9d0a-8d454e5b4927 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615810726; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=sWjkr+PBpEwQK42pGbh45eeU4EpaRPSpIIvbQ/pJsvE=; b=YbtT0IqUUMKOEPbWNR/qFThvHUn4C+yeefi5eCmd6+tU6N26NzEvgvbk bYfsUdr9hMn8K5xenGDLptKVOfAnsFZYZX0Sle9YZRuPPefYQKgPwwIw3 pgMnQ98iFOorHxvsRZhJMg4Q+UQvTNynJRYpXwpMIppOLIvpw0g0lAY5A Y=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: iCdNJDbnT67zDCadoD73PNg2dC3BtHEYcIP2QFcHnhihO/GyESafgdVNNdApl0uWffWHagBgAs aLYneTBeX9ny64VX/pnTwZAroCGhNHEd6RbUoAS4pGzDV854J7D2tbn3YmhZhc7/m+Lts9GIeq mRY5hM+HdhZdlEzZsCwkfIdFHPlH5xDuhyooKQhFeLnkIX/wfQJS9OnQInkPdHvv799F1TPWI0 7QmARPsnzgt/8I2Nrx7BTtLAsVb0cqymhHQcClk27UDVft4lhwKAbDVwYOi8jxIkJO6y+9tQYT rAc= X-SBRS: 5.2 X-MesageID: 39295505 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Ud0KlKOT0LK1McBcT27w55DYdL4zR+YMi2QD/3taDTRIb82VkN 2vlvwH1RnyzA0cQm0khMroAse9aFvm39pQ7ZMKNbmvGDPntmyhMZ144eLZrAHIMxbVstRQ3a IIScRDIfXtEFl3itv76gGkE9AmhOKK6rysmP229RdQZCtBApsQiztRIACdD0FwWU1iDZ02CJ KT6qN81kSdUF4Qadm2AWRAYvPKoMfFmImjTRkNARMm7wfmt0LW1JfRFR+E0hACFw5e2LtKyx m4ryXVxIWG98u6xBjVynPJ4/1t+efJ59NfCKW3+7MoAxr2jALAXvUGZ5Sju3QPrPir+BIWlr D30modFuBSz1+UQW2vuxvq3GDboUQTwlvv00WRj3emgeGRfkNDN+N7iYhUcgTU5iMb1bkWus 87vBP6xu5qJCjNkyjn69/DWwsCrDvSnVMYnfMOlHsaaIMCadZq3P8i1XlIG5QNFj+S0vFfLM BSCqjnlZNrWG+BY2uclmdix8HEZAVIIj62BmIGusCTzgFMmmF4w0Yy1KUk7wc93aN4ZJ9e6+ veNKN00JlIU88NdKp4QNwMWM2tFwX2MFzxGVPXBW6iOLAMOnrLpZKyyLIp5NuycJhN6Jcpgp zOXH5RqGZaQTOuNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dQWeVVEHiaKb0rciK/yef8 z2FINdAvflI2erM51OxRfCV55bLmRbeNEJu+w8R0mFrqvwW87Xn92eVMyWCKvmED4iVG+6KG AERiLPKMJJ6V3udWT/hDTXRnPxam3y9Z99C8Hhjqwu4blIErcJnhkeiFy/6M3OAyZFqLYKcE x3J66isq7TnxjwwU/4q0FSfjZNBEdc57vtF1lQoxURDk/yebEf//GWeWVY2mq7NgZyJvmmVj J3lhBSw+aaPpaQzSctB5aMKWSBlUYeo3qMUtM6lrCc49zmPrc1FIwvVqA0NQijLW00pS9a7E N4LCMUTE7WET3jzY+/ioYPOe3Zf95gxCGxIcBVrnrbnV6Gpd4mQ0YaWzLGa7/TvS8eAx5vwn Fh+a4Wh7SN3Ry1L3Ekveg+OFpQLFiMDKl+FwSDboVMkrXNcAV9JF363ACyulUWQC7H5k8Sjm vuIWmxdevQClRQgHxez53n6Uh5bGmbYkJ2ZE1rqIEVLxWyhl9DlcuwIoaj2WqYbVUPhtsQNz zIehM+CAJjzdLf7m/ZpB+yUVEdgrk+NO3UC7ouN4zJ0nS2MYuSiOUtBPlP5qtoM9jor84GWe +SYBWuMTv9Eu8lsjbl/koNCW1Rkj0JgPno0Brq4CyEx3Y5G+PVO0kjaLcBId2QhlKUD8qg4d Fct5YSsuSxOGmqNYLD5qHTcjJZKhTc5USxVPolrJhIvaQ08Jt/dqOrJwfg5TVi5lEZKsyxqW Y1BIJcy5rFMpV0f8MTdzlCl2BZ3uinHQ8OiEjOHuQ6fVsRlHfVMNOC3qrQpdMUczq8jTq1HW PazjZU8PjEVRaSzLI2C6o/JmJNdUg3gU4Std+qRsn1CA+wcftE80f/GnihcKVFQKztI8Rdkj 9Kp/WJlfSQbSz2xUT5uiZ6OLtH9yKCTdmpCAyBXc5O/NrSAyXCvoKapOqyhizwUz21dgAxgp BEb1UZaoB7sQYZ5bdHmRSae+jQuUIqk1xX/DFhmBrM4+GdkRbmNHADFxbYjJVQVSRUKV6Sg6 3+gLOl6Eg= X-IronPort-AV: E=Sophos;i="5.81,249,1610427600"; d="scan'208";a="39295505" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GQWqMBRerlCoxB0hmdOW/xjUYbkFCwNpFnyEpHuqphtBJ9qdcFUtG8bQNe7bF4QGdvYF5XWfD9LUy8X6iOj3+oo6oTK09XRwmpSPFWe6q8RI8Al6nIxBU8f86N5sZjHh0thUXXVYl/Ou7NyEjABl6D1oJYQX6tbxFt8bMI8kyTXogDJjTMe2yZ2p88oZ5kuvBYAPgQYyapLZl34kkFLLtIia9BHgNdynH+289481KKoAIaK5DoqXN1kJnDvBRZ7XdvXFhWdRzhUsg/OAyYoKG7q/QCUZDJn6mhXQdh0KEwx9Y/nrUjEpYGKiMEc1FvKk3FCwzwAxhaoSYGyi/5e/Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sWjkr+PBpEwQK42pGbh45eeU4EpaRPSpIIvbQ/pJsvE=; b=KVJ8UiuWMfU+RUepSYRNQN/I8tEE1NUy3sYJWwbFuqXcza+IJHcu1YifEuVj2mpJfAZimU/p1/rhy0BUQuK2ammjYc5S3y4S3uN+VsvoQ1O/ma+l2il1p21BeE0Z56pUN6ZoYN00zKVPIkjvgzBhJLKbcZFWfmW4fZBpFDas3Egyiwo84xKGoFZDyPiVWKTE8cuAsm5JAKm8mNsYbaY5rUIJ4d/tryLp/Gn/dQiLi4ThmTzVSngB3qlvw0cX9qY5N51eLAzUKmgD+7P/d0T8t01RGY18q5YHlsMoxjZ/hLT9iuatQJvgLYUiUiJrumkL72ktVsfdLG7xm3HaTdS+DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sWjkr+PBpEwQK42pGbh45eeU4EpaRPSpIIvbQ/pJsvE=; b=obd2pzXx2Ux5PtI5fHVOhytLyHQG5HX4GxijULflaEAVInr5e/B6NNWg2/PDjFU4VfpqCaWZH8LiZLT2nDAeLSjaJ80QwmgZFPljlGyCF4OE8NGl4u6fB/rnkU7VA0YSekoha+hFuPQEsD8nInWl6RpKro8cinWeDeYPl/ejdeg= To: Julien Grall , CC: Julien Grall , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Juergen Gross References: <20210313135500.27241-1-julien@xen.org> From: Andrew Cooper Subject: Re: [PATCH for-4.15] SUPPORT.MD: Mark C XenStored LiveUpdate as Tech Preview Message-ID: <43d6d118-308d-6bb0-3b91-7dc0f8a38d56@citrix.com> Date: Mon, 15 Mar 2021 12:17:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210313135500.27241-1-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0235.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::6) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e38013a-8e3a-46f0-4f01-08d8e7ac4e41 X-MS-TrafficTypeDiagnostic: BN7PR03MB3825: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kRoMTjJSvnZn5+ylLzUjUC1v9zVsBgjjw7k+tldUoFM0vdksGXBv0qMv4HDSZpJNIC+zQOwzh5B/pS0x50t6YLXiqTZ8+g+h9tLHUkux56cLYwXDgXHv9V/86pS7xUjzeACfHyIPHeZ5Qx3jYi+9upkN7coyKR+tsivPaOjHyKxO/hEYAqjqbL/6/MCd4UGJeuCEinVzOI+4ZO32wEoKeZcaktHpNwEswaJCiLAbcmABs6N9US2Kc9B7tlgVuP2Th1+erQx8UPTqrc7th9UvHIYT7y8sJmxe4XewgFb8vfsIF+Z1WIcPzL1jXyElBdzxUFw5XEM842lDtO8TwfdH8SuQ3SW+ZGqokb8RfnJIDsCw9Wa7gNjr4kV56dttkXTDWHdF5TdcA7iUpnJtIIj/GBriPYDmvzJKl57q4VVyPgi+dhdai1l4xYe1e6LwyRgNw0ahP2rVDVRZCOuQ2+7dbWLrcPm56yRLc+Hxhxkq9KGIG+kOqdO5yzYfVeeWLGzWgUXmOiZq2b1i3AYFc9Cwy8JKGA4FqVJz7Rn4dOeKlrsL9E4bz+Ig3Y7jHhVUTbmbY6ZICsVLu/ZL9+VVHhfPy5PJUXsMoWhL/++3CT69o/NQp1EQqpY4jQOLAFmEr4JLSbv9mO1N0G6c1SMPed/jig== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(346002)(366004)(376002)(66946007)(83380400001)(66476007)(31686004)(4744005)(66556008)(5660300002)(6666004)(316002)(26005)(8936002)(4326008)(2906002)(8676002)(956004)(53546011)(16526019)(16576012)(31696002)(2616005)(478600001)(54906003)(186003)(86362001)(36756003)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dHhLUFJkODhTdW5lTm14RjdjSnNHKzNWbThtblZYd0hVVWwzeElYY1JxQUxJ?= =?utf-8?B?YzNjUUM1MTlVVElPZ1hzOUpOQ2FoNk5pSVBLTXU2MnlTMEtpOUNYRXdFMkxP?= =?utf-8?B?ak42VjFnMUZ3eEVWSVh3emlBNldONXBMeUgwL1NULzhNWnpNZ214R21LRG5n?= =?utf-8?B?YXNXQXp5YzBYTUZMdGVnNmZ4RERocnNJdGFER1NXNHM1YXlkaDR6aERZbUZl?= =?utf-8?B?UUNOYkl4Wm84bSt2ci8xTWhJWjJMY0FlMlVjY250M2tBUlljbFJXSzJDZThv?= =?utf-8?B?MVBjUU5MNSt3Y1VzYVlhM2RGeDJTOEdVSmpUZkNnNVp4bC9ycE1HMzVScGxJ?= =?utf-8?B?TjZFVEJ4TjhVem9sQUZNWW9TV0h5c0E4ZUkyUXBZRGJubjNzUWEzL1VNK1hE?= =?utf-8?B?cDg2MDhzRVF3NnR0TWx6ejFGK21OeUo5TFlpdFk2RStKNWRLYzAzYnhzT0FF?= =?utf-8?B?ZVdWMlV0dk1UL0wwNnBObTZtcG1ieHUxQmE1ZkZ2cXdmSDhIbW44dW1aVU1n?= =?utf-8?B?S28wVnl6RUR6UGY2MnZDekl4bENDRjg5a1BkUUM5WnZkNnRseVhkKytZbnQ0?= =?utf-8?B?b2k4WFFNamVmS0lzODVvTTAzcWExNG1FUkdyRTBuTTR6azZQMW9wSU5zRFpj?= =?utf-8?B?Q1d3UEJYb2sxNWlQYzg0TWNuSkRZYm55R0ZZSzV0WXZLbGovUURUa29xVnFo?= =?utf-8?B?aG5WSXgxczNONXhnYit6V21KUmdua0tHa0JwUTBocFhVZVgwNER4a2JVbThi?= =?utf-8?B?cmJaKzROR0hmVGhVM0dIcSsyd1g4ektVLzRNT2tISnZ2Y2hPQUE4cE9qOW5K?= =?utf-8?B?SEtLbnhHTDNURzh3OXZ4NkpaaVZDZ0lseDhmKzczeERkQkV1TjdtZkhEVTVE?= =?utf-8?B?bWoxaTkyUnd3emVqSzc2WWN1VFBNWjNMLzJRTEZZWmozVnFiVE9Vb0NaYS9h?= =?utf-8?B?aVk3R2daZ2FYdms2N1hLSGRGKzV3ZTRiSDFtdW1ZcVpFb1NwdnJ2Z0ZETno1?= =?utf-8?B?eERHYzlnOFhTNDN4c21MaFQ5TVlzY0FEbXVZUy9pWW5rZ3lQYjM4eVoxYWdU?= =?utf-8?B?djByYUowcWRwMlFxa0J2RjdqRnh3Y1VqTTlwQzFHRHdLUGlVYTZ6dy80WXJm?= =?utf-8?B?RE5XcDNvR3drUmZ0WEdNYUllN05jcjhLOWZEQXVUKzFyOUdPbjdGUmhyMS80?= =?utf-8?B?ckVXSEU0aW51bTZNQXFrWkFyZWR3blpJNGpVWXk0ODFIWGNBT29KVWJvc0Ra?= =?utf-8?B?Z0dQTWtOQS9VWFc3clI2TFQvcnhWc3JKOVZwWkJwYncvMmVXaWRIemo0b1pD?= =?utf-8?B?aTVEbEtyWmJWaHpPYWxPam1Sa2pTcWRIR3BoM2tURHZlWUYxSW8vL2o5bytZ?= =?utf-8?B?Y1liWU1ObGxmbTR5R1lMUVRLdE9BT01jVFl5bFpxY3A4L281dUNBU2I1dzZy?= =?utf-8?B?eE9QMEZZT2Vnbzc5T1BNL2dmbDZ2bWFTelA5TFk2Y2doMTdqVy9ua1ZBeTRj?= =?utf-8?B?MlRNaUd2T0NybGQxUStjWis1dG1ZRWJQcWxHUEtYMDVzRlRHMG5XT2ZINTZ4?= =?utf-8?B?QTNQZ3hGWGJOODhZZVM0NlZxR0trSjBUajdmTUFEeFMvRzhnSk1keWhQeGJv?= =?utf-8?B?K0xRQ1hzVTZPS1l4dFppSlQ4N2IySXlVbm5DVm11TUU2TUxobUdYOURpVVBP?= =?utf-8?B?ZnE2MnRaKzk2RmFxTW1scFpQTGFIZ2tNTEZvV3hBY2ZpcGhJOU9TNmZZc1Rl?= =?utf-8?Q?MGkexrIQ5YLOwM25wS+nrk2BhJmbYU3tJmIXTx1?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9e38013a-8e3a-46f0-4f01-08d8e7ac4e41 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2021 12:17:31.7262 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7fY6aR9M0duI9FiFtU2BOEAIBiBifmEyC+Rtu0N3sqn4HrzRZrFPcXwI9lN9pSi3JblhcAf7wzzR2Zl8di/SpV+RHUNKIDW1+5DQanVENnY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3825 X-OriginatorOrg: citrix.com On 13/03/2021 13:55, Julien Grall wrote: > From: Julien Grall > > Support to liveupdate C XenStored was adding during the 4.15 > development cycle. Add a section in SUPPORT.MD to explain what is the > support state. > > For now, it is a tech preview. > > Signed-off-by: Julien Grall > > --- > > CC: Juergen Gross > > It looks like the OCaml side was not merged in 4.15. Yes it was. > So I have only > described the support state for C XenStored. What about stub-cxenstored?=C2=A0 I think it wants pointing out specificall= y, whatever its status, to avoid confusion. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 15 13:10:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 13:10:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98005.185824 (Exim 4.92) (envelope-from ) id 1lLmzJ-0002Ih-Pr; Mon, 15 Mar 2021 13:10:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98005.185824; Mon, 15 Mar 2021 13:10:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLmzJ-0002Ia-Mm; Mon, 15 Mar 2021 13:10:25 +0000 Received: by outflank-mailman (input) for mailman id 98005; Mon, 15 Mar 2021 13:10:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLmzH-0002IU-It for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 13:10:23 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 99900c39-ac89-4816-8800-d70180679a22; Mon, 15 Mar 2021 13:10:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99900c39-ac89-4816-8800-d70180679a22 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615813821; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=kjWQGlDwdH7nECD7Bk+xM0dhigSxiu1m+WywbhwPd24=; b=FNtKqvjKDh0uK/gzbQ9Z2PnvMyRWLwRQr2loU9kNIlCUWCF9S5j58jsP 60JxuK1P9vigsF5mY0WtaW+ccYQqIoIn6puLmxUuPocX8KPdFueAkM7l8 res5FuRLYTtqV1Eaq3tsnEEDN9d0VU+mSX1wnF0RA9Wo+CMKBy17iGNLS 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: UYNE7QZKHapMC/dpTDfaT7IdEbCxDrVuy8n+ACm+4IOYeUvEqrkjoBRt7fAvSx3xMI3oGisTiw e+JX3tW6VdsAqjh79MMjCu5fMDJQyNbZabS69z/1pHs8ByrnWlWcCpw6W2WnyvC0rA8uXeLr44 H80vwhigh+cIV/GgX21lMLv5SOxfLrU+uNLwdC+ndReJ3zQcg/lREaJbUTFvpLDQ8ZJvYR6huU +I/pCcRDKZDxYEA/iGGG/yyD/3vq3OsHmHDazrpBzII+m55pnuw5Pb4r9tmzmTiqQP7EBw/701 nVY= X-SBRS: 5.2 X-MesageID: 39301357 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:GG5kza8p6PzPsuXM0XJuk+FRcL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmyybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIUHD38Zn/+ Nbf6B6YeecMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsKV4hLxW5Ce2OmO2dxQxRLAod8MZ Ka6NZOqTbIQwVpUu2QAH4ZU+/f4+DRnJX9bhIcQzIh4g+CjTSngYSKbySw9BEYTj9J3PMe4X HI+jaJm5mLntOa7lvn12HV54lLg9eJ8LV+LeGFl8R9EESVti+Gf4JkMofy2wwdgObq01oylc mJnhFIBbUI11r0XkWY5STgwBPh1jFG0Q6Q9Xa9jWH4qcL0ABIWYvAx/L5xSRfS50o+sNwU6s sitAj4xvkneC/opyjz68PFUBtnjCOP0B4fuNUekmBFVs8mYKJRxLZvjH99KosKHy7x9ekcYY 9TJfzbjcwmE2+yU2rUpS1GztCqQx0Ib2y7a3lHkMmU3z9KpWt+3ksVyecO901wha4Vet1q4f /JPb9vk6wLZsgKbbhlDONEesevDHfRKCi8fF66EBDCLuUqKnjNo5n47PEc4/yrQoUByN8XlI 7aWF1VmGYucyvVeIKz9awO1iqIbHS2XDzrxM0bzYN+oKfASL3iNjDGYEwykuO7ys9vQvHzar KWAtZ7EvXjJWzhFcJixAvlQaRfLnEYTYk8pss7YVSTucjGQ7ea99DzQbL2Hv7AADwkUmTwDj 8oRz7oPvhN6UitRzvWmx7Ud3TxelHu3J55HaTAltJjirQlB8lpiEw4mF657saEJXlpqaotZn ZzJ7vhj+eaqACNjCP1xlQsHiAYIlde4b3mXX8PjxQNKVnIfbEKvMjaXWhT2XCANyJuVs++Kn 8am31HvYaMa7CAzyErDNyqdkiAiWEImX6MR5AA3oqO+NniYZF9Kpo9QqR+GUHqGnVO6EhXgV YGTDVBal7UFzvoh6ngpocTHvvje951hxruB9VVp3LZvUC1vtouWXMfYj6rXaes8EUTbgsRom c0374UgbKGlzrqA3A4mv4EPFpFb3nSPKhLFz2fZIJfmqnifSZ5SWviv03ctzgDPk7Rs2kCjG 3oKiOZPdXGGEBUtHxj3qH2y19sbWmGc0Vsand1jJ1lGQ39ywRO+N7OQpD2/3qaa1MEzO1YCj 3DbDcICi5Fxty81neu6X2/PERj4q9rEv3WDbwlfb2W52ikL5eQk7oaW9VO+ox+CdzouugXcO 6WdgOPNgnkA+cx1wH9nAdiBABE7F0f1dXm1x3u4DLmgDoRAf/OLE9nQL9eCdeG9GTgT+uJ1p I8rd9dh5rGDkzBLvq9jYfQZHp/DzmWh0icZeQhs4pVsqI/r6EbJeiSbRL4kFV8mCwjJ8L1nn 4ESKt14Lr9KpZiFvZiDx5xzx4MrpCzN0MlvQz9P/8mcXwsh3HdOcmV47Cgk8tYPmSx4C/xM0 KY6StT4rPsWDaCz6cTD8sLUC5rQXl5zHRp5+WZcYLMTC2sauFY5VK/dluwaqVURqTAObIeqH 9Bkpy1tt7SUyrzwwbLuzRnZopI7ma8WMu3RDu2JtQgya3yBX28xo2w4MCyiz/rSTy0L2Qg7L c1C3A4X4BkkTktjIo+zy6obLf4y3hVymdj3Q== X-IronPort-AV: E=Sophos;i="5.81,249,1610427600"; d="scan'208";a="39301357" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gqll/SR6rdF4qLGK9yORCouEJWfQF8MD9PfacGneCCYcAkCUsbCirNK9lrLFzE1r+frynnC9CpTac5/nG5hr5yuQXBBWfIeTkoR5otm03SntGAfsrZxS/uwY0B892XWsafF7fPb/kZ9iW7KVJ6zY8uoJnu30rBYmsZAGJPNXtPc7oEtONVSURVDGwUHIfndofaoG/vY3GI5Ig6x1N0FNl6tl2lfW11oUwLR1VRwPGKBuvmWgrBvwGP/uv4E1eiWH3CT0f5Ub2rx/IZQ6BJ8fTqtzZo6z/LVvv3TyeTOiEHfzNxy7I9K9ERayPzi5YiLvBd7koAdGjFVrkmDnWqojBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3kLg4WT1Sz6m6LfVms0NcqEnTwEcIwi1eOjbAh5DHhQ=; b=P6qLpjikYtvehLv+52Q2hGFJkbMZo4NW6yV/FVHgur9RtBMGuDF7fH8YCY0xR0VQrMdF5q0L4H5kj6xBNQwWSO5VPG1ThL0tlC3+c6GAF9ZVygm9Vv8IKlhWu25iHLzisf3leSm3uBzFMORS7zigA20MXentgKMSKAnixCAuDksEt3aCiQ9Kryf8MlMY0Z54WYJjvBF2oUXYiiyXDHMOyW0YV9R3pWewmXINrzUYhMPk0oWOGywBi/RAJ4k5hj8lIVRoJqn8x0129NqFb4jg6tfSnG2vqKn+6ehbcE9eGUzNVhWZEB7t+499mSB6LP9ZeJQT5jh3FJx3QpfoQ2ltqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3kLg4WT1Sz6m6LfVms0NcqEnTwEcIwi1eOjbAh5DHhQ=; b=Z2Tqf8v1tz3BkW2i0r4O7UTh898xVfi72Udlt6GX6yHNfPia7VJWwJByvjtuVV1k1a0Owqe9TBUQxB8CI58t/CiPIxeCIyV97YC10t6UeJ4sQzVbissW5TkZedgedS5TBqgZmOg27UY+cFhivRoKs5tppsya++Bfcq6/RAc3/1w= To: Ian Jackson , , CC: Jan Beulich , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , Dario Faggioli References: <24655.20609.834996.744652@mariner.uk.xensource.com> From: Andrew Cooper Subject: Re: [ANNOUNCE] Xen 4.15 release update - still in feature freeze Message-ID: Date: Mon, 15 Mar 2021 13:10:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <24655.20609.834996.744652@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0151.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::12) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4d940651-696f-4d42-b638-08d8e7b3ad1a X-MS-TrafficTypeDiagnostic: BN8PR03MB4801: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: psGp3QT7ikyroxp4r9zmrkzedYs94QBMoMrqUGIsbJ6VA7CHQoGBy145Bfus/Wl2nR/cD6+lyN9EPtjwgpM41Yrhp+MqfXcO/afrsVqTeY6X97VZ0FGhHsgfCPIqlCTm3N/xX4/gkhUZCe99IlobzyLNaMTHFdAZhGSD3/7OmwtPS8VQ1fZCRGbmSwhoyi90RICtTbPrcGYJjr7/2PfCRBCcyv9Y4cKy/m95Y5bXz2ad2h9WOKZsTVDivFzOMFzfTZVhetQV/H++dCOX7zUVTGrwbbmQnqsaKhQXtEDyQBkZsgajzwOQB0xgFBXmsMFlpl4dLaGUpFOTT6R6Pgoz2PzBp1ygBfFv2/oRe+GPP4NLHWLB5z/C9/iyLcOzBHd97xYaBgABObyEwxlZEPcawXnFwgJOZighFJysmSTIJmA+awUHFP6CkRRxMhNm0X5njE6rCLvJ3Q8wkz7Rt4qG65C2hyGZdQBAG7DnRiUQzPGHfhVDV3BcVBiQlMD49II5aIFSM72R77m6Oh0GeJeXeDxoO61qXM6PlDvO3+G9krBjXwk8xPhxYzshppvbrmPJ4W0lXwQDp/bmQnUC5su4CZGnPorkMrwtusv8Ag4Z+NYI0GQaG5w6lLIcv+y3fSUyu9Rs1+HOO+2ajLKWragO7TcEZ0SO76RXuBSEAcDJNSFCtA/jf8AGqojEivrO4aIc2VInmz30tRFpfSsAMpAtn3Heof/tf3VwWbkCJM4Cwjo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39860400002)(366004)(396003)(376002)(346002)(8936002)(83380400001)(66574015)(2616005)(26005)(36756003)(16576012)(6486002)(956004)(2906002)(66556008)(966005)(54906003)(478600001)(66946007)(86362001)(31696002)(186003)(31686004)(53546011)(6666004)(66476007)(316002)(5660300002)(4326008)(8676002)(16526019)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?a0VXUi9iSDRvZmVRdTBtWmdBOU5Pa2FCTUZVRUpoZ0NXR0VXQUhMeUpqYS9D?= =?utf-8?B?QzdzdytGOEtWRTFobVlRajZUU0RSWUxiK0NEVDJoTWVHZlorUjduVHQxeDlj?= =?utf-8?B?MXdpbU8wVlFlV0U2cDdOYmx5ZkJNYzhZNnQzWThjZ2VuU3JDM0RYN1o5amJ0?= =?utf-8?B?Rkp4Z0ZTeC8vMks5WHN1enJmSTBxTTBlTnIxZE1qNEtiTVdhT1pmVVN2MmQr?= =?utf-8?B?dGgzOWxxSVJ1N253N2ZaczgzeXMralhpSGlPMmJwVlBkOEVrMWVBNGtpNjJR?= =?utf-8?B?OGhVMjY1dk9GYWhUdlpSRjlHNTNtNnVrVlRsMEV3bld3bklvVzJnRWhHcDUx?= =?utf-8?B?Yjc5YUhBVjlDSm8veS9BZ0F0RWNmRHdJcWhpbzlZQk5tWFVKV0NpY015eGxl?= =?utf-8?B?SHBLWlBwK3FTZkxrOHVRdkdSaHUwTjJ3UllrZUhqS2ZMRFhybDhMV0lKZ0FO?= =?utf-8?B?U0l1V05mako4a21SbUZMTGRrd3RpWjZjeFRYd0dkcDhDaDZiUnEwR2xXK0g3?= =?utf-8?B?TEUydUpHRXZhT2RzbFFnZFkzUTlRSTdDN0JsM1ZiM3dhS1diQmwzM3M1dmJx?= =?utf-8?B?ZFdGM3pNbzVoQjFOSVJONnAweEt6RlUrQkpoM3pJcWdFK0FtODVoclRBRUlk?= =?utf-8?B?RlV5bDhlMnJBdllaek1xREhmb2pIQzhHV3dzVDI2RVAxMnFmYlRJc3RiQVpE?= =?utf-8?B?YS85dXZVNGM4cG5nYURVamtIUUZvVk1jdjVjZjhqWjJ0ZjZ2VDh4a3NWYXhM?= =?utf-8?B?ZWN0QkV2QWQ2VlVEWHlMZXBCY1BwTXFWTWcrSGswekRZMzZ5Y3JDd2xHaUhv?= =?utf-8?B?UEU4MnFqNEZ2VkVLTlppdlZYckl1SjVaQmR3S1JDbXo3dTVIYVNncFY3OHZi?= =?utf-8?B?a2pmbXVHa1I3YWJScW9DV0Y0R2ZFeTZRejFhWnJUeENLZE5ZZHVkNm5Uc2VY?= =?utf-8?B?c1FwZnI5UlJWVzRoMkFaOFJPb0xKUXdyQ3N1L1RaV3NRTGVFODFlSDRDZE1m?= =?utf-8?B?RG5tczYyMnJIbTRWY3BVSXp2N3J4K2pDZlkxV1R4bEExb00xcHI0UDQ1VVdO?= =?utf-8?B?SWtmSlNRckpvWCtucy9BWHdKd3o4RmRvb0Q3d0pUMDZVdElsMlhGOS9yNXc1?= =?utf-8?B?cm9lTmU4USsxcFQ1MDc5V0t4Wmg3ak5paG51NWd5M3B0enhYSjBlU3FDRm9E?= =?utf-8?B?NGtZYS9JREt3Rm01SlMxZWNUMzIweVJrWlFNK245UkhGQnFkK2VYM3pUM2ta?= =?utf-8?B?c3FTd1RRSVlaVWRDZWxrQkJVTFRXU2cyQ1E0SzEydGF0bXVHWUIxMHI2cGxt?= =?utf-8?B?RWtrcm5udEVTeDJaM1p3NlJIUE9RazV1aHZ0SW0za2JEUVhVbW9PZUFKWDVO?= =?utf-8?B?bTFOa0hsMjdyY0Y3YU1ndDIrYkVObU14a1c4OWZ2TG5tVTUrM2xqYkNDRXRR?= =?utf-8?B?UmdUNzFCb2hzK3ZPYVdTVnVHUXFSZFJZMjg0NnNrOG84YlRRTlZYRlphQ2hL?= =?utf-8?B?Wnhvazg2SCtTTS9ydUNVT2FtMlkzMjQrZTdka01mRDRIck03SzhDUWtVMVQ1?= =?utf-8?B?L1JiR0RUT2xIWVJ0Wml4ZndkT2pKVnJYRmJqd1U5Wm9CcVhlOXEyS1BJc0Ix?= =?utf-8?B?VmFLYWozdlFISnNkRkU3bGE4V2tscVZzb21xNjVsYTRWV2FiSnhOSVdyVTh2?= =?utf-8?B?Uk5YYmJFMmZla3JxYi9yUlhMcmk1SFhlMFRWeWt3ZFkvMXRvVEx1bENUWmpW?= =?utf-8?Q?DetMwAdZiaY+0FLvQT8xgWb2Xf9VM/bIeokT06a?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4d940651-696f-4d42-b638-08d8e7b3ad1a X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2021 13:10:16.4465 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jJSSAaTUiMHdKEGyZFI9BfPHn78iiqpGmI08G6RuM3nm9kEJggIPE7xeN19t3IaXzLzwBRrH8Fsxn23xwpNFiU0qvmcD4EJFfk9IYDzlrw8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4801 X-OriginatorOrg: citrix.com On 15/03/2021 12:18, Ian Jackson wrote: > OPEN ISSUES AND BLOCKERS > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > io-apic issue on Ryzen 1800X > Related Qubes issue tracking this: > https://github.com/QubesOS/qubes-issues/issues/6423 > Information from > Jan Beulich > Andrew Cooper > Fr=C3=A9d=C3=A9ric Pierret Debugging ongoing. > ABI stability checking > > [PATCH for-4.15 00/10] tools: Support to use abi-dumper on libraries > [PATCH v2 for-4.15] tools/libxl: Work around unintialised variable lib= xl__domain_get_device_model_uid() > etc. The libxl thing is already committed (2ff2adc61fcfa0). > This is testing/build work and will enable ABI checking of future > changes to 4.15 after its release. I don't think it's a blocker but > it would be nice to have. > > My most recent impression is that there are still some loose ends > here. Plan 1 (committing dumps into the tree) won't work.=C2=A0 Plan 2 (OSSTest a= nd other systems doing a double checkout) probably does require a tweak or two in 4.15 to make it easy to start in 4.16. Also, "xenstore_lib.h and libxenstore API/ABI problems" still has work to do for 4.15. > ISSUES BELIEVED NEWLY RESOLVED > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > > Fallout from MSR handling behavioral change. > > I think there are now no outstanding patches to fix/change MSR > behaviour and there is no longer any blocker here ? Still one known issue remaining, as pointed out in Roger's summary.=C2=A0 I= 'm still working on it. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 15 13:26:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 13:26:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98010.185837 (Exim 4.92) (envelope-from ) id 1lLnF4-0003O4-5Y; Mon, 15 Mar 2021 13:26:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98010.185837; Mon, 15 Mar 2021 13:26:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnF4-0003Nx-2I; Mon, 15 Mar 2021 13:26:42 +0000 Received: by outflank-mailman (input) for mailman id 98010; Mon, 15 Mar 2021 13:26:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnF3-0003Np-Lv; Mon, 15 Mar 2021 13:26:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnF3-0000Lm-9B; Mon, 15 Mar 2021 13:26:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnF2-0000H1-Ta; Mon, 15 Mar 2021 13:26:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLnF2-0000RU-T7; Mon, 15 Mar 2021 13:26:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gZENOFYSIE9MVRhrVAzakB8OOrSj2PcYXMZGXF515ik=; b=k2M0qwo9eLf859TrF46eUvh63X f04UfNgg5yho9piyIP4I1Zfdfzdn9p/IXifL5vYn8wEKgqbBA15ebxU997tMc2lQ+ZAmIQBxvy6dW jR929dsWfM4fzmZfCjith/DPwM+0Pk48NQOweH0szYGvulaMHQymzHxn+hpdHuRWDnT8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160083: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=14b95b3b8546db201e7efd0636ae0e215fae98f3 X-Osstest-Versions-That: xen=14b95b3b8546db201e7efd0636ae0e215fae98f3 From: osstest service owner Date: Mon, 15 Mar 2021 13:26:40 +0000 flight 160083 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160083/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160069 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160069 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160069 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160069 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160069 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160069 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160069 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160069 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160069 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160069 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160069 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 14b95b3b8546db201e7efd0636ae0e215fae98f3 baseline version: xen 14b95b3b8546db201e7efd0636ae0e215fae98f3 Last test of basis 160083 2021-03-15 01:51:25 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Mar 15 13:26:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 13:26:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98012.185852 (Exim 4.92) (envelope-from ) id 1lLnFI-0003SE-Ju; Mon, 15 Mar 2021 13:26:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98012.185852; Mon, 15 Mar 2021 13:26:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnFI-0003S4-Gi; Mon, 15 Mar 2021 13:26:56 +0000 Received: by outflank-mailman (input) for mailman id 98012; Mon, 15 Mar 2021 13:26:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnFG-0003Rf-Mc for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 13:26:54 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c4fc416f-7459-409b-9668-29b55d9a2944; Mon, 15 Mar 2021 13:26:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4fc416f-7459-409b-9668-29b55d9a2944 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615814813; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=nPLzut19jIiEdJ7RGV40EqqCQzkHaj9E3VQdX1oFvoI=; b=OtWMIPiThwWaNSyLXbFKPnj66x4366vzDxMtweIiNh3XmZQEim2gJTfW B8M5nDueBSE2x7SP9lWG41YF0g/vJ/IlyQM7hghK8bQpoDKN6Ern0kNFD 72Rf3t0gQFCpzV9QerLHB/hf9mVC+uN6HaeSj00vm2+DqQClPcvl+G9ez 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: CcNjdDh6QItXoPJGXl+5zDh7UrS9XlcV/q/UhlTMj0Yi/uSBtPg1XVSVIpvAM+vDZ7jBKu1i+S iQpn4Vhqg9YajHv6O99sEsrcV3nkVxsNDGzUBT+qkab0u1MMLCUjAjPYBBNJESnROLD+xesyDe LawjiCYLJ4XHhluR6ySe37pJcUuRi/mMfUKUNIuHdeihHLQTi9R8MylktzTMr0+lxJqZG5FDXL nmwUDTzjXYjLKNs3g33z1csNAsZZutyC9AHW8GT/L8hS6KnbXcVv/vWW49XwT+QcZq4Bt3Wf7j IEg= X-SBRS: 5.2 X-MesageID: 39303409 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:eV0H56u+3q5YLlOFa6AoeSiy7skCIIoji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOjLU5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Q26Y 5JSII7MtH5CDFB5vrSyAOzH888hPyO9661jenTpk0dND1CQadm8gt/F0K/Gkp5WAFJCfMCZe Khz+BAoCetfmlSU9SjChA+Lqb+jvDCiZ6OW29iOzcJ8w+L5AnH1JfbFFyi0g4aQ3dzx94ZgA 74uijYwonmjP2h0B/b0AbontVrsf/s0MFKCsDJquV9EESJti+SaI5sW6KPsVkOyYnCh2oCq9 XCrwwtOM5+8RrqDwaIiCHw0Art2itG0R/f4GKYmnfqrIjYQz83GqN69OBkWybZ8EYpsZVA1r tK1QuixvlqJC7H9R6d2/H4EzVR0makq3srluAey1ZFV5EFUaRcqYwE8FkQOIscHQrhgbpXTd VGPYX53rJ7YFmaZ3fWsi1E29q3RE0pEhOHWEQZ/uSIzjlzkHp5x0wZ3sh3pAZdyLsND71/o8 jUOKVhk79DCuUMa7hmPfwMRcusBnaIaQ7QMViVPU/sGMg8Si3wgq+yxI9wyPCheZQOwpd3so /GSklgrmI3e1jjE4mk9rcjyGGffEyNGRDWju1O7ZlwvbPxAJDxNzeYcUsjl8u7r+9aI83ARv CpKPttctbeBFqrPbwM8xz1WpFUJ3VbetYSoMwDQF6LotjGMMnQuubaafbeI6eoKG1hZ3PnDh I4LRDODfQFynrudm7zgRDXVX+oUFf454hIC6Tf//Ie0sw2HKgkiHlFtX2JouWwbRFSuK0/e0 VzZJn9lLmgnHK7+WbT438sBwFUCVxN5q78bmhDqgALOX7laLprgaTARUlimF+8YjNvRcLfFw BS435t/7isFoedwSA5B8jiOmWGj2ELrHbPVZ0VnaeE4troa45QNOdwZIVBUSHwUzBlkwdjr2 lOLCUeQFXELyjjjaW+gIZRDP3DcdZ7mxmiOsNZpBvkxBGhjPBqYkFecy+lUMaRjwprbSFTnE dJ6KMagKCNg3KqJXEkiOo1KltRc26aaYg2XDitVcFxoPTGaQtwRWCFiXixkBcoYFPw+0ETnG D6aSuOef/KBVJZsHVZ3qH28Ep9e2iHc1hrA0oK47FVJCDjgDJewOWLbq283y+6cV0Z2NgHPD XEezcJZhp0wdq6zgSYlXKIBTEkwIk0OeTZDLMsGoujjE+FGcmtr+UrDvVU9JFqOJTFqekQS9 uFdwuUNj/jT/4z0wuOv3A/JTRuoHYqkfn0yATohVLIiUIXML73GhBLVrsbK9aT4yzPXPCTyq h0itozoK+ZLnjxQsTu89CUUxdzbjfo5UKmReAhrp5Z+YgosqFoIpXdWTzUkFlawRQFKtvunk 92etU/3JnxfqtUO+ACcSNQ+VQk0P6VKlEwjwDwCugiOXYgkmHcJNHMx7bTs7IgDgmgqWLLSB 2i2hwY282AczqI1LYcBa51C39RclIA5HNr+/7HeJbXDAmsauFf7Fu3OnKwa9ZmOe64MIRVii w/z8CDnueReSa98hvXpyFHLqVH9HviQc7aOnPUJcd4t/iBfXiciKqj58C+yB3tTyGgVkgejY pZMUgZbsFJjCg+nJQ6uxLCEpDfkwYAqR9z8Dtnnlni1syN+2HAB3xLNgXfn9FRRjlcMn+BiM zf6uiG3HHh4DxIsKOzU3t4T5VrIZw9X4L3JyBhJYw7p7iz5ZcihSxFfVMzFWImkSv82OlnxL +93/3XV4TZeCzVEGNE3QQAKp9/nyQtp20FXM6k85qnbwURGMsPBeJX3PEXrBtZ7nzIq3EMZR RksQIlkrzXJlv8JnJmCOzFho3tmiUVo6CE9nxjrHhdgUmclVmZolT59vzF4UYcnin4lEtHob /YbCYtiCxZ3zQXupBJAz6oayrQZl+rdHnw17AlPHV5D3tH8ZRQsDPza48RmJi4z3ltsDQ8BQ k9y7ymDXznUjmJGcbuID3CLqWfPPdCJ9BLOmQCKHaqMg/jgZpYdGOKRP5oygislnASBaKHJ6 OhZ0aHAIMQ+bELUpacPbK2iMLWkhFD8XwPpZ+Tsw35oNtm6NrePQJ1u888da8BAHbUwA5018 LWQg7VJYgQ50ju3hDcwDUdK9kMzwsPx04G4S8WBSOzHtu2AlpsvTgc1vbSNWEl4NfETNsQqH zGq1K6onXaXTrkRHWESvkI43gz8hzGT5+ft1+me6DpPxQ6woDnLY6p0S773RTdvdOPkX3XsQ 5sy3pVQVEwxx2OVNocT3fQwEZyCWsgKjp81A6j0LEa+H1pmAstdSEQXtAK+GHxEg/HZheU8g j4NH917cUKQmV1je9Gsz5BhV8jgkYdSfB5mo+UoFmge29YRm93tpUrohrLkNZ4W2V1Okf3Pu axotStLsiw1ppRHjyX7Jw+XbZEQzUKjaiQ6PjUSCpFYQjdwKxaygDS/Aogq1ckgM0ouSjb8f zlVym25KUssKELVaX43H9uCvlYfcRztHyIDo5L8Kk+i0f38sja3GYua86N0Wt1KDfuV8QHfh 45bX2f3a07mcCNpTyXaZJvqPrGzEwAGIXrHGd7+Zq3K3BIprgzypHVYo/FOzTOsslBDOUAzH 7+nAwD4nupnZ++Ep23Nh+ykS2SQ2AmApteBUAeIJCqeLFo+rQx2gdHwOZvPAtZketzZymOo5 ELuSr/juBn0PQQiVAcXtnPqVZz5FtLZLSgmZZh3WjcxmYkkuLDha1jr7LFNtF8B3K5 X-IronPort-AV: E=Sophos;i="5.81,249,1610427600"; d="scan'208";a="39303409" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vo3y7LoBlpRfnxlXiUBPVXO/pVDKGeThg3y69TcTkFjtvoUR0Z17PpI36FGvYy7bj7pFjamXtqRWZUOwKErq2wty46dPdyvO7g3nkbUwKjf1BexuTthftUibnhSephUVSIZrnZfTXV+ygj9+12ufGJan81H1MLIcrEnTRzg/jfRcKslps8Grh7ciqxUSSo8541JdQGlKE/vzYbI5NMrY/LJLKyEiCV/mwlo1mFLb3W/62PEwp9mDI2CXZbnotiD03ybcCY1NBrGpi4Nip5qG5dRiS4kjR0Iw6IcJvlwKsUalw/1uwxqBLrKWBHh8dzQOh4+B337rsygEJLWEeztuCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nPLzut19jIiEdJ7RGV40EqqCQzkHaj9E3VQdX1oFvoI=; b=cYjRFlujGa/sjUC1zwpGj+aoSl0KvI2FuVu8AJB2cfTRZnkbFWWlYCykrrLPXw9AD2iUOK824PhY0+rgUH9ufI+HJJgNSEd4J/5CBXmYNIBfhW6w18q702JNaze4SItIvKcxJmI5JQ3p11OPFuSozMDk8H8RD+hRAAtlIwfA+RpBnh+x1ClLlreWqWHHVZtXl5uGm+11pZB75+gqOAjCUFC7IH09Kn7XzAc2v2vdHE4MFmTqM+WE6ud8TYJ2Kmlt2HPUHssOOTsWQzOZ05hFVr9BwKbEaXgY0SYTxVSO7lsHi1wz4Hr9kaUfZ5erar6URNJezezFdfb1PK5LQkRaIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nPLzut19jIiEdJ7RGV40EqqCQzkHaj9E3VQdX1oFvoI=; b=Ti0G+ltSUrPZZ5tu1BHNUn0cHKQZ4NwAgFgl842W+LBoRpHuYNoodI4pQPmNBzZEJ/rUyUTSwUrj0+00i8fpgY1QdoP2ajSsHoj14Hn0CE4AiihhH7Pm5n8WPN1J0RijNDNWZbrRw6On0ZaSIDi/FKS+R3VWpkXsqd0lckpxH5k= From: George Dunlap To: Ian Jackson CC: "open list:X86" , Community Manager Subject: Re: [PATCH 4.15 3/3] CHANGELOG.md: Glean some information from SUPPORT.md Thread-Topic: [PATCH 4.15 3/3] CHANGELOG.md: Glean some information from SUPPORT.md Thread-Index: AQHXFPObmjsak1n05US1KozduC4yDaqFE8uA Date: Mon, 15 Mar 2021 13:26:47 +0000 Message-ID: <702645DF-2B40-42E9-95A3-11A8BF3E7E0C@citrix.com> References: <20210309145002.30359-1-iwj@xenproject.org> <20210309145002.30359-4-iwj@xenproject.org> In-Reply-To: <20210309145002.30359-4-iwj@xenproject.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aae63747-2878-4d51-39f5-08d8e7b5fc39 x-ms-traffictypediagnostic: PH0PR03MB5799: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cZsj47s+1UFH8W9++XYzS6gNuy1oAv3Xi+GV5IxN7/Ydk3r6WSdXjN3xC3HrG8VBJEZdWDml93+rjGFoLkMI5TgXIADYF2xStTPy0Vp/eLA3NXgv4Da9I8sRPxiDHNuvcRgzXciaMSnip3XemRszxsaezVgaGvMtPo6VhnKjp99STB0J3cqOkfaxVvnaTu/b6llouj5vqQRKTbiF57hkl1wvXK5a8+azhcV3lUdnIgCWS0UAIkn3RA/5md1CW0ZntJMNhszXKoSESTq6ySvGDpVZh/xr9K7l9RXnTeC6OybspyXV8CqxtVKtCcxpsMcJcNctyjQWMFLcA46Zji5F2AFDt7LrqVgrK6EYXgxupGdFdr8ePdx+dkF1pLPqtTuccJfELP182HTxBZV39QRuo0p75kt0HDxEZ+vpJd4CcpEb+O5tz9qFVIZeizbOrbhOXZzMujYsdoU1K//hniODA5VwqOynHXL74cXg3CspL2NKxUJrmQ9PLUDz4CxO1NsyRqISiIvKC9CiK+6QsR2C4hBdD/EVKK0TOtjb2tqR/PTuZQ6u+XJHzzoDxXP4k22bWNxGE1ptdf6LC/CuC4z3HKBcxuHEUapPAGP/7ZCCeigkwXPWnP1nNc0u1dk/2P9/RHtEB9DC0YFXctB/jOR6lSP2dwxHMmbjsVyTRzKhahV7IMpFYp0cRgZFYhgC7yCEpA5dGS6Dbl7hUn/BOHfdsdJuOHxqviQ2mL5ETWPtIbBOT2gFxSiCrXs9UmACDZiw x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(366004)(346002)(39860400002)(376002)(6506007)(8936002)(2906002)(53546011)(76116006)(64756008)(71200400001)(478600001)(8676002)(66476007)(66446008)(6486002)(26005)(2616005)(66946007)(66556008)(33656002)(186003)(54906003)(91956017)(86362001)(316002)(36756003)(6916009)(83380400001)(6512007)(4326008)(5660300002)(219803003)(207903002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?TkNQR3VGZTA5TlU5L0ttalRkaUkwS1hyOUs0SzhnQUlhK3QrcVEwNU9mdDRv?= =?utf-8?B?dG1kOE1QL3FPa2dwb2xFUHlBUXpoOXo0V2I3cE1vell3TEFYSlRFOHA0bDBB?= =?utf-8?B?T1oybWVEZUhvbElyVmJKOVB1djN4WitDaFh6S1Z4VmltdjBqT2JSd1NpNHVG?= =?utf-8?B?eWlabHBtMXV0MExrdVcxMGJLZDJQbzlFRXVERjVEU1kyZGVUcGZjdDE0SkVU?= =?utf-8?B?L3BmOW5qN25lUjJxVjVGdXRHeE81N3MyeElkMmtuUWdXZ1k3dVZ0S3dMbUxo?= =?utf-8?B?ZnpmbC9vazFmRzBuZDhnRHBYYzQyYktnczNCdHNNS3RNUTQ2dVh5azlyVDM0?= =?utf-8?B?UWdWU21xTUhFU2FIWlJvOVdDWWd0aUNYcVJjZSs5SmJQKzEzSmlDeEViNlRO?= =?utf-8?B?ZW1OdnF4aUY2VFVsRC8vb3ZCMTBrdEZsbXBNbDc5OVI4ZEQyWHVUVjE5bXYy?= =?utf-8?B?d1piRS9mNDFQLy9nRmlsOC93SGkwUlhTcTNzcllvbGpMZlZuY3A3L2RXS1p6?= =?utf-8?B?WS9NUFplUU1DclVGNldHVFdaVjlOUmlqQW1JSWgxN1dsSHdjTnZMdVFSak9a?= =?utf-8?B?bkdZZTdaTkVoNFg5Q3BCUEZTVndNTDJJWldXRHhOQjJsamQrWmpSL3haNWNy?= =?utf-8?B?MmFRTHhqQ1MzNjdnZmJXdlAzbStHS2x5dWowekxXL1NGUE9RZDFoYTdrSStl?= =?utf-8?B?b2pqVlNkWDc5VE1ZRjlhVDF2V1lNUS9MdW9CT25jRG80eXJMd2lGQkVmM1J2?= =?utf-8?B?a3VUbmxHeEpkSDZHZjlyVUhwRnJvNXJOaHJLWWxvVjQzcGdxeXNEaG8vYnp2?= =?utf-8?B?VTB6YTJXRldGUTZ1SVhlbko0VnRIcXJJRWp3OWw0ZzhSNXYwMXBma1U3ejhC?= =?utf-8?B?UnFyN3pabkhPRGVKTE9kSUVVT2FuTHdRaTU2engwNXhiNVVLd2h0Yis0Z0FJ?= =?utf-8?B?ZVF6U1VKeHE3RWZlSnExcU0wNWRkQ1hFSnl4bVU1bThLQVZzazhSbW8zQlNH?= =?utf-8?B?N29XYUFydkF5MkR0TWNCaFd6UHB3Tm5mM2wxRFRIN2JSZHo0clBycFo0djVn?= =?utf-8?B?ZEpISzRaV21seWdhWmo5TFlhRGFQc2tIYVh6OEpDb0FRZVVKbC9nMm5XSkhn?= =?utf-8?B?dFhJcnEvRkJXenRWeHFEM1o0NlNQVk02QjZkMGJGYWxmaWxRYTlZTWZnRUZk?= =?utf-8?B?VjZhTzRDTlJESjgzNUE4TUY3VG1TWCtReG9RYUNUaTF1TGFIWEU0SlRuTW90?= =?utf-8?B?elF0VTdQNmNnejFhL1RlSUx0RElsbVhlUjltcEdURFpVeWxpRFBhR0tQbUNZ?= =?utf-8?B?YU5wa1lmZUgwWnJyandkNlJDaS82N3d4Z2VYTWYvbGVNc3NIZzJjenhINHJU?= =?utf-8?B?RWxXczN6Q1VUN0ttaGRCbXlveHdQWkltUStGQkM1SlZFUFg3a29qdm4zK2ZR?= =?utf-8?B?c2dLNHJhSWVrbUNzeXYzZ3poZFludFFJVUpUTTN1ZWFlOFhQNGxteDhjc2NU?= =?utf-8?B?T0ZRZ2k5cjZQUlNPSTdvY2xtUnZKdVNvdU5SaVdkODdHaWdlT2VDTlVoZjIr?= =?utf-8?B?VisvMzBETWVoS0J4U0pHV3lXd3l3Tkh6MnFvRTZEV0d4c2RlK05jQkY1clZh?= =?utf-8?B?cXB0U1FmZ0U3eUlnVm1sckpTWmxHd1g0YkVXNENLMklsMmQ5TGw4WnFuMHJ3?= =?utf-8?B?RWVDMG1lS2x6Q1pQR0RGeDJKa1dNSlRoNVdILzRjT29ZdG52Z3c0a3JtZjRI?= =?utf-8?B?azExdWJ0MVhGWENqTFkyanh1dnJOUVhzdlNOc3F2L0MvdFNsZ284L0c2dUhM?= =?utf-8?B?VGJVNVkzSE5uUzNod3dJZz09?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <1E0ACCB8C81B644698A7733210674911@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aae63747-2878-4d51-39f5-08d8e7b5fc39 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2021 13:26:47.8376 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4UIxhwNYTXQFU2/7t+44OMvxXR7d4ARXSNo6eSS8LTVc7j46aBagPPReiFtbFxEVv9Q1as1r5rffW5HNuHoP8eTMX0DzqzXWNbAEu5FPTts= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5799 X-OriginatorOrg: citrix.com DQoNCj4gT24gTWFyIDksIDIwMjEsIGF0IDI6NTAgUE0sIElhbiBKYWNrc29uIDxpd2pAeGVucHJv amVjdC5vcmc+IHdyb3RlOg0KPiANCj4gU2lnbmVkLW9mZi1ieTogSWFuIEphY2tzb24gPGl3akB4 ZW5wcm9qZWN0Lm9yZz4NCj4gLS0tDQo+IENIQU5HRUxPRy5tZCB8IDEwICsrKysrKysrKysNCj4g MSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKykNCj4gDQo+IGRpZmYgLS1naXQgYS9DSEFO R0VMT0cubWQgYi9DSEFOR0VMT0cubWQNCj4gaW5kZXggNGVjZDE1N2EzNS4uY2NkYmI4MmMyZSAx MDA2NDQNCj4gLS0tIGEvQ0hBTkdFTE9HLm1kDQo+ICsrKyBiL0NIQU5HRUxPRy5tZA0KPiBAQCAt Niw2ICs2LDE2IEBAIFRoZSBmb3JtYXQgaXMgYmFzZWQgb24gW0tlZXAgYSBDaGFuZ2Vsb2ddKGh0 dHBzOi8va2VlcGFjaGFuZ2Vsb2cuY29tL2VuLzEuMC4wLykNCj4gDQo+ICMjIFtVbnJlbGVhc2Vk XShodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXNob3J0bG9nKQ0K PiANCj4gKyMjIEFkZGVkIC8gc3VwcG9ydCB1cGdyYWRlZA0KPiArIC0gTGludXggZGV2aWNlIG1v ZGVsIHN0dWJkb21haW5zIChUZWNoIFByZXZpZXcpDQo+ICsgLSBYZW4gUFYgZGlzcGxheSBwcm90 b2NvbCAiYmFja2VuZCBhbGxvY2F0aW9uIiBtb2RlIChFeHBlcmltZW50YWwpDQo+ICsgLSBBUk0g SU9SRVEgc2VydmVycyAoZGV2aWNlIGVtdWxhdGlvbiBldGMuKSAoVGVjaCBQcmV2aWV3KQ0KPiAr IC0gUmVuZXNhcyBJUE1NVS1WTVNBIChTdXBwb3J0ZWQsIG5vdCBzZWN1cml0eSBzdXBwb3J0ZWQ7 IHdhcyBUZWNoIFByZXZpZXcpDQo+ICsgLSBBUk0gU01NVXYzIChUZWNoIFByZXZpZXcpDQoNCk90 aGVyIGdlbmVyYWwgdGhpbmdzIEnigJltIHNlZWluZyBpbiB0aGUgdHJlZSAobWF5IG5lZWQgYm90 aCBTVVBQT1JULm1kIGFuZCBjaGFuZ2Vsb2cgdXBkYXRlcyk6DQoNCiogU3VwcG9ydCBmb3IgenN0 ZC1jb21wcmVzc2VkIGRvbTAga2VybmVscw0KKiB2bXRyYWNlIHN1cHBvcnQNCiogbmFtZWQgUENJ IGRldmljZXMgaW4geGwgLyBsaWJ4bA0KKiBnbnR0YWIgc3R1cHBvcnQgZm9yIE5ldEJTRA0KKiB2 aXJpZGlhbjogQmV0dGVyIHZpcnR1YWxpemVkIElQSSBzdXBwb3J0LCBjcHUgaG90cGx1ZywgcmVt b3ZhbCBvZiA2NC12Y3B1IGxpbWl0DQoqIHg4Nl9lbXVsYXRlIHN1cHBvcnQgZm9yIEFWWC1WTk5J DQoqIEV4cGFuZGVkIHRlc3QtY2FzZXMgZm9yIHg4Nl9lbXVsYXRlDQoqIEhWTS1zcGVjaWZpYyBN TSBjb2RlIChzaGFkb3csIHAybSkgY29kZSBmYWN0b3JlZCBvdXQgaW50byBhIHNlcGFyYXRlIGZp bGUNCiogaHlwZnM6IEFkZGVkIGNwdXBvb2wgZGlyZWN0b3JpZXMgYW5kIGNvbnRyb2xzDQoNCkNv dWxkIHByb2JhYmx5IHVzZSBzb21lIGlucHV0IG9uIHRoZSBuYW1pbmcgaGVyZSBmcm9tIHBlb3Bs ZSB3aG8gaGF2ZSBjb250cmlidXRlZC4NCg0KIC1HZW9yZ2UNCg0K From xen-devel-bounces@lists.xenproject.org Mon Mar 15 13:32:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 13:32:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98022.185864 (Exim 4.92) (envelope-from ) id 1lLnL4-0004TH-C3; Mon, 15 Mar 2021 13:32:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98022.185864; Mon, 15 Mar 2021 13:32:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnL4-0004TA-8B; Mon, 15 Mar 2021 13:32:54 +0000 Received: by outflank-mailman (input) for mailman id 98022; Mon, 15 Mar 2021 13:32:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnL2-0004T2-4e for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 13:32:52 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (unknown [40.107.3.66]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3e0a5629-3ab3-4835-a70b-35d500469464; Mon, 15 Mar 2021 13:32:51 +0000 (UTC) Received: from AS8PR04CA0035.eurprd04.prod.outlook.com (2603:10a6:20b:312::10) by DB6PR0801MB1733.eurprd08.prod.outlook.com (2603:10a6:4:37::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Mon, 15 Mar 2021 13:32:46 +0000 Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:312:cafe::54) by AS8PR04CA0035.outlook.office365.com (2603:10a6:20b:312::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Mon, 15 Mar 2021 13:32:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Mon, 15 Mar 2021 13:32:46 +0000 Received: ("Tessian outbound 24a7072fdae6:v71"); Mon, 15 Mar 2021 13:32:45 +0000 Received: from 3cb5440f8444.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B6001EC4-F279-4CF1-B982-5D84BAB30535.1; Mon, 15 Mar 2021 13:32:40 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3cb5440f8444.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 15 Mar 2021 13:32:40 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VI1PR08MB5295.eurprd08.prod.outlook.com (2603:10a6:803:e3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Mon, 15 Mar 2021 13:32:39 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3933.032; Mon, 15 Mar 2021 13:32:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e0a5629-3ab3-4835-a70b-35d500469464 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JGhOE4Py5arD3lbQI3F0gQPD07n7M5jkSpK9CzuCtLQ=; b=R0sWltPQf8wYbhIbdhHRvpBVyBFUp35/H1don1RvihocjGPP4CBGL+gW8CWhLhsTB6ThpY4SSH+W5LzDLSkMiK3670OzTdDp05etyroapRQ//wqo/tYdnl9qoFJLLntKMSlfiLTXUc5kRaautQbt3Ety0rokckPHFzk2J2XDdc8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 7f5b1d360f002ab9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=egNvqjpc1yPJ0lGEsLawvu4XzXlZBVzsrSiyXZwesa9MPflPjehvn4YViQqyx1A+ZtsZZ8/N90Pho7vHhlDBEBHKpyNevGCqYOY++9yTnhgEj6srqPTwzDsCsK84tWOoTKBMDwEuOCqq+fDkhvFf5tLRJ2NGaAXJMiIc8Lb3+sC6GLNWJTTiJ3J35NBWRs0lRnXaqXUCtFLSdw+jzBIAZ8AQHfzC9ZKIqiBk7aS30w54H/7x1MavPALE4JLCm6vYb8obX3kAv9WR97r2eU7TNpgFolKjxag4VL1D+dYsvYbPz3UmU/nuOzeVLBAfXMRklN2PyYPY3Js7m3PGdjCugQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JGhOE4Py5arD3lbQI3F0gQPD07n7M5jkSpK9CzuCtLQ=; b=dpjFS3ld6yhaES4stluOHypoWcdYcsiANtz4K+NxsKSO5QiirtQYdgY1Xt/DroLMkTLrwHXlG6oNmHwCa/hqg6biSTLW+yyqqpfOW6k4XOL/N3PACz1TO1ySwEJFYF1iTACEh+xGLyHhNbuQH8gHGuhATwnzhV/uGz9NeTIunkjcNnUhy2pDTvHK9dPE2vGdTgLzuu0EWl/tRUAR3F/b2Ghk29ZP4oJ2KZjCM5YfU/KGLm4d6sDph59iEZrLWoaQb5kSMuAPIKRH80tqdhXKmdyW1zFD+WB4zgN2y98PWAtPJ97U5rbgpXHpppqVLm5AaBZBkZEo65XCCSBzSRW39Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JGhOE4Py5arD3lbQI3F0gQPD07n7M5jkSpK9CzuCtLQ=; b=R0sWltPQf8wYbhIbdhHRvpBVyBFUp35/H1don1RvihocjGPP4CBGL+gW8CWhLhsTB6ThpY4SSH+W5LzDLSkMiK3670OzTdDp05etyroapRQ//wqo/tYdnl9qoFJLLntKMSlfiLTXUc5kRaautQbt3Ety0rokckPHFzk2J2XDdc8= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH for-next v2 0/2] xen/arm: Mitigate straight-line speculation Thread-Topic: [PATCH for-next v2 0/2] xen/arm: Mitigate straight-line speculation Thread-Index: AQHXGCLVbl4hty1bX0WFvkxXr3KxFaqFDwwA Date: Mon, 15 Mar 2021 13:32:37 +0000 Message-ID: References: <20210313160611.18665-1-julien@xen.org> In-Reply-To: <20210313160611.18665-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.26.33.241] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 5dd13a06-1578-4902-17fd-08d8e7b6d1d4 x-ms-traffictypediagnostic: VI1PR08MB5295:|DB6PR0801MB1733: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RtPsUVtGMJyNeqFG1wwx8FYZKxtZS9lLR4FfEX3qoG49+GVEz7USa161cvK7U12fq3GpuM6yxLma7VR5KsrpBguccjr2xhCLgMnKiFCg2re3UUxROOdyfmvFvu/CVr52404d1XEMcHEQhFVQbmem1k5vOf8uug8EDGTSz1JSAIKqNT2stw39eys+uGOO5P8i2uzt9o4453RHuQwSbPK+Rs3/YMKH43vlLi8Mm24+YtHDnePK8e7RXXP6moGF26GvvZoyVgB8VrSgZ9yB7Sb3L1FBayq9+3IdDp4SWaehC8U9RsSW5Q/76pBGILekooRcn3S6Agu9PR8qqoQJ04lDevT2dbejR9oncPVGEuRXbWoYRQznlHgBZzI2EnjKdJA9JdtWB9DjUuSlnC23CmIR+E9cmfkYPCSYsqFi/8nCFTcFbgeTl1qfR1vV8iQwQd52dnT8D5xYy/uNbs8+EVRZZ3R+kLVh4Bb8cW/+eMBIX7KPRPVamexuxv+9y232DYkY40QqX7MY87gsoEuNbKw2IG+l5q3kR6vGMkseT7WC8UpKzc2RuBpFOdono8C0I1d4Wp8CKrE9NiAI4sdQFiT8yl5niKG6mtDgbXUdQ8Ef3+afYkQWQfeB2vKG37+QfPFAZq5zjNAE8JVLu83DxXF8J3uzTQ5ZISkTxnmqpO0lqgfmsTMoeIlmfDiceQdAP4N/YrK7AaZas1LdaPAS//PwPA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(366004)(376002)(346002)(39860400002)(64756008)(66946007)(6506007)(66446008)(33656002)(8936002)(66556008)(6916009)(66476007)(76116006)(53546011)(6512007)(2616005)(4326008)(8676002)(91956017)(55236004)(5660300002)(86362001)(26005)(71200400001)(36756003)(478600001)(6486002)(186003)(83380400001)(54906003)(2906002)(966005)(316002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?lXaA2cUnB+cyWupLv3PAiAJQLaX1rSlqBVSSzw+dUKAdCuCRVYRLKF7KhYb9?= =?us-ascii?Q?6eO8SWarl+bP1ISHumqapprYcGDiXE/erBM9yEteuQES0PYyLCtoGFZRY1vG?= =?us-ascii?Q?+QdoiltScoumHg5+7zMjvkR7ZdnPStfRKLyhwyXYDUe0URUFaiJTnJe1Hl9X?= =?us-ascii?Q?M/rYHOIWmnzu+B3/CZ9Ux+VjFBmtKtQYQ89goUQiE7L0RZD9irnsbtX4osVZ?= =?us-ascii?Q?Lr9YOz17kGlD9fEWbCf+wx45AiMPNX16YFlwXYy4l/DRKcq944ucl+5tzGEv?= =?us-ascii?Q?QJiWh/0hb+w5RUF5zKokdZTugPfrrM6jlRSVxaIkSxR99lTe+JugmPeaSCpI?= =?us-ascii?Q?SKbiwFmqxHKAtxdRzz0Fx5deymgwCzLTXO3p7KidLC3aYuGNILtMxxvIWtHX?= =?us-ascii?Q?qSUQpkd78NpKxwLsfRhHaZIXAcPL7pj3lI7DIgrTXXPkVbynbaVDZ5mYmOrr?= =?us-ascii?Q?0HVbwu2t3L/BetLYGI9zrrkKdmDgSPLl9Y2e7dgIlhuzmkoqhBpy8ESiguSK?= =?us-ascii?Q?S8J+kBQvBeVmOOtpTqOmXeyKsErDKiPAxz3ytmoTBKSCyne3Vxgyc3cVe0pj?= =?us-ascii?Q?8qVRLO9b7jayGgLvQuupyzp7AQKzPkujIRlVsK3QlrC9bP2X67HIVY+fGi38?= =?us-ascii?Q?zadLS1TbdHBj+kwdv8xvf51oALeij6qRSE7f2mN7/VtL3m1Z+Dcrfmb1u4dy?= =?us-ascii?Q?75PV2Xt8Sm+nZwLfLiq4iyhLPvEl9c4Sk3NEiLN/srNDjkriavKTj4PfCiSY?= =?us-ascii?Q?zhJwYcPx+hIP54RJOMJ/hujzDBuBZeIKU8rk/19WCA0kDh2oKX8Fady6Jj6U?= =?us-ascii?Q?oqK/zaPSrHlo2GApb01m0E0/ZdXd4ZCXTeiWzeOVXQ9AhSq1YiCObkGAm4TB?= =?us-ascii?Q?kwLuvZJrP0cJJtVUznInm+TcFn2P0URruMhGxcyzVP2SFciJspU62JK2cJ2h?= =?us-ascii?Q?slaYqTJnOlTnHdPp+gvRhn6lad1GEbAWnzDHMgGNsFByEmtsJpKeKW7KIyJL?= =?us-ascii?Q?VNtiGvquLCytOlSw+UfzB+DJfziUYNAk9g8d54f1GT0pYtjWS2/dRjS0qhB7?= =?us-ascii?Q?oi+uLjqKfpn8tH+0m0RaepYqygp3IBSkEssnmpf9hxH+oqTaEXS5oRaeBx8K?= =?us-ascii?Q?xTTiT91WZ9kOUkx/T70dV+o2vDpk/ZmdCNK6R9kPLP3gG3X41P3mri9CtGR2?= =?us-ascii?Q?TMusFAa5zEQ1m+25t0lW0O5WAcOpT2VP4Yu9VJEPFp3fjXN08WROGaKhXLUK?= =?us-ascii?Q?sGL70+ZF/WWmqZLFbXiLHcpJYz858w6RPpjloK23tTWN5EM7p3cX0golWccA?= =?us-ascii?Q?ztKK2G/6XlvOYGxIxH9nhUFd?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <4DD6BFE69DAC314197F4D53CDF38C378@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5295 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 22095ddb-8cb0-470a-b63e-08d8e7b6cd12 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O5Rn6v23O9EuBZc1YHUclNVQyl1mg3AdIaDO8kCQM65cVi0+SEo7wTysjTY5le3SxIJC03RUbc71hSvO69JAwRGv6A6Jzu61IdwMcNcsoZ5jYei4rg1Z9YDsUOjUW0FpLGOJvUEzSCWCjawxODCBU7SjPJwQ2u6dshA9m8SP1YVZiTzJPA6LUqCs23yDjEbqeuem5xA4ty8hraFBCFcNXNnwPOMk9UT55pA7mgja4lOztWsF7JK84JDUBlOXaqdJiLqPso+bxD7uXmfqL1Mj+QrBOSeSShkPMYI/zxzYaTAhtq/NJ95DvBEobSyY54sj7TwOCBClZeioQ05C6WvZKb7OUvJMHl73WYMeT7z4qXiOrPWYn7FstR/fwABkQckgPptzXS8oXa/weCXG2nw41fxzg3wo1l074NU14PR7ABV/JEz/UeKuwfLmec5VUyiEZYnTMrfWdXugWCEpOszOpcNEzrJQGac1LVff2iiA3pIspr8ckqH/ErzRDGiA2YYGl+SYXONoD9uDh1+jpJ5P4veEFGJaK9r71RpNsoDHyhJ38j6R524bhZZMp3FC2DKYjdGFjlE8aEXFNQBLPmg+H2Y3Fm1DFQkezPH0GHLNEbAqwPHKibxDYAeBJPWody2oaFw9oGFsO1ubSICl0qnd0SdoMx1F9y8VXqrKmXRGyd24upLOGHZfDWy0F7h852ZeW6OrpmaMMVgd4AAC/w7Mea1VU7RAQ0Nqm2+7xw9z/vk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(376002)(39860400002)(136003)(396003)(46966006)(36840700001)(6862004)(4326008)(82310400003)(83380400001)(6486002)(478600001)(5660300002)(336012)(55236004)(356005)(47076005)(70206006)(8936002)(36860700001)(33656002)(26005)(53546011)(316002)(70586007)(81166007)(36756003)(86362001)(82740400003)(966005)(107886003)(186003)(8676002)(6512007)(2906002)(6506007)(54906003)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2021 13:32:46.1638 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5dd13a06-1578-4902-17fd-08d8e7b6d1d4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1733 Hi Julien, > On 13 Mar 2021, at 16:06, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Hi all, >=20 > Last year, Arm released a whitepaper about a new category of speculation. > (see [1] and [2]). In short, a processor may be able to speculate past > some of the unconditional control flow instructions (e.g eret, smc, br). >=20 > In some of the cases, the registers will contain values controlled by > the guest. While there is no known gadget afterwards, we still want to > prevent any leakage in the future. >=20 > The mitigation is planned in two parts: > 1) Arm provided patches for both GCC and LLVM to add speculation barrie= r > and remove problematic code sequence. > 2) Inspection of assembly code and call to higher level (e.g smc in our= case). >=20 > I still haven't looked at 1) and how to mitigate properly Arm32 (see > patch #1) and SMC call. So this issue is not fully addressed. >=20 > Note that the ERET instruction was already addressed as part of XSA-312. On my tests, this serie is breaking the arm64 build: | aarch64-poky-linux-ld --sysroot=3D/home/bermar01/Development/xen-dev/buil= d/profile-fvp-base.prj/tmp/work/fvp_base-poky-linux/xen/4.15+git1-r0/recipe= -sysroot -EL --fix-cortex-a53-843419 --fix-cortex-a53-843419 -r -o= built_in.o memcpy.o memcmp.o memmove.o memset.o memchr.o clear_page.o bito= ps.o find_next_bit.o strchr.o strcmp.o strlen.o strncmp.o strnlen.o strrchr= .o | arm64/head.S: Assembler messages: | arm64/head.S:305: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= "- Boot CPU booting -\r\n")' | arm64/head.S:331: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= "- Ready -\r\n")' | arm64/head.S:365: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= "- CPU ")' | make[6]: Leaving directory '/home/bermar01/Development/xen-dev/build/prof= ile-fvp-base.prj/tmp/work/fvp_base-poky-linux/xen/4.15+git1-r0/local-xen/xe= n/xen/arch/arm/arm64/lib' | arm64/head.S:367: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= " booting -\r\n")' | arm64/head.S:398: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= "- Ready -\r\n")' | arm64/head.S:412: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= "- Current EL ")' | arm64/head.S:415: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= " -\r\n")' | arm64/head.S:424: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= "- Xen must be entered in NS EL2 mode -\r\n")' | arm64/head.S:425: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= "- Please update the bootloader -\r\n")' | arm64/head.S:441: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= "- Zero BSS -\r\n")' | arm64/head.S:459: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= "- Initialize CPU -\r\n")' | arm64/head.S:654: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= "- Unable to build boot page tables - virt and phys addresses clash. -\r\n= ")' | arm64/head.S:666: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= "- Turning on paging -\r\n")' | arm64/head.S:800: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= "- Boot failed -\r\n")' | arm64/head.S:848: Error: unknown mnemonic `rodata_str' -- `rodata_str(98,= "- UART enabled -\r\n")' | {standard input}: Error: local label `"98" (instance number 1 of a fb lab= el)' is not defined | /home/bermar01/Development/xen-dev/build/profile-fvp-base.prj/tmp/work/fv= p_base-poky-linux/xen/4.15+git1-r0/local-xen/xen/xen/Rules.mk:204: recipe f= or target 'arm64/head.o' failed This was done adding your 2 patches on top of current staging. Cheers Bertrand >=20 > Cheers, >=20 > [1] https://developer.arm.com/support/arm-security-updates/speculative-pr= ocessor-vulnerability > [2] https://developer.arm.com/support/arm-security-updates/speculative-pr= ocessor-vulnerability/downloads/straight-line-speculation >=20 > Julien Grall (2): > xen/arm: Include asm/asm-offsets.h and asm/macros.h on every assembly > files > xen/arm64: Place a speculation barrier following an ret instruction >=20 > xen/arch/arm/Makefile | 2 +- > xen/arch/arm/arm32/entry.S | 2 +- > xen/arch/arm/arm32/head.S | 1 - > xen/arch/arm/arm32/lib/lib1funcs.S | 1 + > xen/arch/arm/arm32/proc-v7.S | 1 - > xen/arch/arm/arm64/debug-cadence.inc | 1 - > xen/arch/arm/arm64/debug-pl011.inc | 2 -- > xen/arch/arm/arm64/entry.S | 2 -- > xen/arch/arm/arm64/head.S | 2 -- > xen/arch/arm/arm64/smc.S | 3 --- > xen/include/asm-arm/arm64/macros.h | 6 ++++++ > xen/include/asm-arm/config.h | 6 ++++++ > xen/include/asm-arm/macros.h | 18 +++++++++--------- > 13 files changed, 24 insertions(+), 23 deletions(-) >=20 > --=20 > 2.17.1 >=20 From xen-devel-bounces@lists.xenproject.org Mon Mar 15 13:36:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 13:36:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98027.185875 (Exim 4.92) (envelope-from ) id 1lLnOv-0004ff-VA; Mon, 15 Mar 2021 13:36:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98027.185875; Mon, 15 Mar 2021 13:36:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnOv-0004fY-S7; Mon, 15 Mar 2021 13:36:53 +0000 Received: by outflank-mailman (input) for mailman id 98027; Mon, 15 Mar 2021 13:36:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnOu-0004fR-Q1 for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 13:36:52 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 30edc4db-3a29-46af-8724-30dfb3be76d5; Mon, 15 Mar 2021 13:36:50 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D1F4DAE15; Mon, 15 Mar 2021 13:36:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30edc4db-3a29-46af-8724-30dfb3be76d5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615815410; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dzV566CCmb8PhJv0y/Ywr9jy92JK01zrOmtc5+tgWjc=; b=Tmi8V83ipnb14Ub/SIMltcQeIb8OObUgBnaTCFKx9bxWKje6wNWMnsWCC2GAfdJduMDyY9 wNQcS/7qUyve0mhzgb1CQH0KoFQCLiQ0A66KYFyO1NTCYDIDvPTKI+N9ZgjEcbZd2Efjji X06LtB9Kb479QWCae9SFduLXP/Vvbvw= Subject: Re: [PATCH v3 2/5] xen/x86: manually build xen.mb.efi binary To: Bobby Eshleman Cc: Daniel Kiper , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Xen-devel References: <28d5536a2f7691e8f79d55f1470fa89ce4fae93d.1611273359.git.bobbyeshleman@gmail.com> From: Jan Beulich Message-ID: <3c621726-31c4-6a79-a020-88c59644111b@suse.com> Date: Mon, 15 Mar 2021 14:36:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <28d5536a2f7691e8f79d55f1470fa89ce4fae93d.1611273359.git.bobbyeshleman@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 22.01.2021 01:51, Bobby Eshleman wrote: > From: Daniel Kiper > > This patch introduces xen.mb.efi which contains a manually built PE > header. > > This allows us to support Xen on UEFI Secure Boot-enabled hosts via > multiboot2. > > xen.mb.efi is a single binary that is loadable by a UEFI loader or via > the Multiboot/Multiboot2 protocols. What's missing here yet very important is why the existing xen.efi doesn't fit and can't be made fit. > Signed-off-by: Daniel Kiper > Signed-off-by: Bobby Eshleman > --- Besides (or instead of) the series-wide change log, please have per-patch changes info here. > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -266,29 +266,31 @@ endif > .PHONY: _build > _build: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX) > > +define install_xen_links > + $(INSTALL_DATA) $(TARGET)$1 $(D)$(BOOT_DIR)/$(T)-$(XEN_FULLVERSION)$1 > + ln -f -s $(T)-$(XEN_FULLVERSION)$1 $(D)$(BOOT_DIR)/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION)$1 > + ln -f -s $(T)-$(XEN_FULLVERSION)$1 $(D)$(BOOT_DIR)/$(T)-$(XEN_VERSION)$1 > + ln -f -s $(T)-$(XEN_FULLVERSION)$1 $(D)$(BOOT_DIR)/$(T)$1 > +endef If you abstract this away, please take the opportunity to fold "-f -s" into a single option. > .PHONY: _install > _install: D=$(DESTDIR) > _install: T=$(notdir $(TARGET)) > _install: Z=$(CONFIG_XEN_INSTALL_SUFFIX) > _install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX) > [ -d $(D)$(BOOT_DIR) ] || $(INSTALL_DIR) $(D)$(BOOT_DIR) > - $(INSTALL_DATA) $(TARGET)$(Z) $(D)$(BOOT_DIR)/$(T)-$(XEN_FULLVERSION)$(Z) > - ln -f -s $(T)-$(XEN_FULLVERSION)$(Z) $(D)$(BOOT_DIR)/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION)$(Z) > - ln -f -s $(T)-$(XEN_FULLVERSION)$(Z) $(D)$(BOOT_DIR)/$(T)-$(XEN_VERSION)$(Z) > - ln -f -s $(T)-$(XEN_FULLVERSION)$(Z) $(D)$(BOOT_DIR)/$(T)$(Z) > + $(call install_xen_links,$(Z)) > + $(call install_xen_links,.mb.efi) This is common code, so will affect Arm as well. I don't think your addition can be unconditional. > [ -d "$(D)$(DEBUG_DIR)" ] || $(INSTALL_DIR) $(D)$(DEBUG_DIR) > $(INSTALL_DATA) $(TARGET)-syms $(D)$(DEBUG_DIR)/$(T)-syms-$(XEN_FULLVERSION) > $(INSTALL_DATA) $(TARGET)-syms.map $(D)$(DEBUG_DIR)/$(T)-syms-$(XEN_FULLVERSION).map > $(INSTALL_DATA) $(KCONFIG_CONFIG) $(D)$(BOOT_DIR)/$(T)-$(XEN_FULLVERSION).config > if [ -r $(TARGET).efi -a -n '$(EFI_DIR)' ]; then \ > [ -d $(D)$(EFI_DIR) ] || $(INSTALL_DIR) $(D)$(EFI_DIR); \ > - $(INSTALL_DATA) $(TARGET).efi $(D)$(EFI_DIR)/$(T)-$(XEN_FULLVERSION).efi; \ > if [ -e $(TARGET).efi.map ]; then \ > $(INSTALL_DATA) $(TARGET).efi.map $(D)$(DEBUG_DIR)/$(T)-$(XEN_FULLVERSION).efi.map; \ > fi; \ > - ln -sf $(T)-$(XEN_FULLVERSION).efi $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION).efi; \ > - ln -sf $(T)-$(XEN_FULLVERSION).efi $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).efi; \ > - ln -sf $(T)-$(XEN_FULLVERSION).efi $(D)$(EFI_DIR)/$(T).efi; \ > + $(call install_xen_links,.efi)) \ > if [ -n '$(EFI_MOUNTPOINT)' -a -n '$(EFI_VENDOR)' ]; then \ > $(INSTALL_DATA) $(TARGET).efi $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi; \ > elif [ "$(D)" = "$(patsubst $(shell cd $(XEN_ROOT) && pwd)/%,%,$(D))" ]; then \ Since this part of the patch is a non-negligible fraction of the patch and since this installation step doesn't need to be an integral part of the change, may I suggest / ask that you split this off into a separate change? Possibly the installing of the new binary could remain here, but then the breaking out of the install_xen_links macro (which imo also would better use dashes in place of the underscores) could still be factored out. > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -110,7 +110,7 @@ syms-warn-dup-$(CONFIG_SUPPRESS_DUPLICATE_SYMBOL_WARNINGS) := > syms-warn-dup-$(CONFIG_ENFORCE_UNIQUE_SYMBOLS) := --error-dup > > $(TARGET): TMP = $(@D)/.$(@F).elf32 > -$(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32 > +$(TARGET): $(TARGET).mb.efi $(TARGET)-syms $(efi-y) boot/mkelf32 While perhaps mostly cosmetic, I'd prefer additions to be done after the existing (pseudo-)dependencies, not as the very first item. $(TARGET)-syms still is the main dependency here, and it should remain this way. Speaking of (pseudo-)dependencies - I was hoping that we could avoid further extending this sub-optimal approach. > @@ -119,6 +119,11 @@ $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32 > { echo "No Multiboot2 header found" >&2; false; } > mv $(TMP) $(TARGET) > > +$(TARGET).mb.efi: $(TARGET)-syms > + $(OBJCOPY) -O binary -S --change-section-address \ > + ".efi.pe.header-`$(NM) $(TARGET)-syms | sed -ne 's/^\([^ ]*\) . __image_base__$$/0x\1/p'`" \ > + $(TARGET)-syms $(TARGET).mb.efi The quoting is very hard to follow here. While using the shell's $() would already seem to be an improvement, I don't see why you shouldn't be able to have make construct the tail of the section name by using $(shell ...). This way, in case of someone needing to debug this, the resulting command line would be more explict. I have to admit I could also do with a few words in the description as to what this playing with a specific section's address is actually needed for, and how it's guaranteed that this isn't going to end in confusion (e.g. because of trying to put the section at where other stuff is already sitting, perhaps just partially). It's also unclear to me why the new address is calculated by subtracting the image base address. The PE file header is, aiui, assumed to live at RVA 0, i.e. precisely at the image base. Further - why the -S? xen.efi comes with a proper symbol table. And finally I'm not convinced of it being a good idea to use __image_base__ here - that symbol exists only to help the linker script cover both ELF and PE binaries. It would be good is new road blocks towards eliminating this crutch could be avoided. Can't you e.g. get the main program header's specified address and subtract XEN_IMG_OFFSET? > --- a/xen/arch/x86/arch.mk > +++ b/xen/arch/x86/arch.mk > @@ -7,6 +7,8 @@ CFLAGS += -I$(BASEDIR)/include > CFLAGS += -I$(BASEDIR)/include/asm-x86/mach-generic > CFLAGS += -I$(BASEDIR)/include/asm-x86/mach-default > CFLAGS += -DXEN_IMG_OFFSET=$(XEN_IMG_OFFSET) > +CFLAGS += -DXEN_LOAD_ALIGN=XEN_IMG_OFFSET > +CFLAGS += -DXEN_FILE_ALIGN=0x20 The former is merely coincidence - I don't think you want to use an offset value as alignment. For both of them I think once you go this far, you also want to consolidate with xen.efi's --section-alignment= and --file-alignment= settings, such that the values don't need to be kept in sync "manually". What I could see is deriving XEN_IMG_OFFSET from a hypothetical XEN_SECTION_ALIGN value, because we indeed want the first section (.text) to start at the 2nd large page from the image base. > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > @@ -1,3 +1,4 @@ > +#include > #include > #include > #include Why? > --- /dev/null > +++ b/xen/arch/x86/boot/pecoff.S > @@ -0,0 +1,123 @@ > +#include > +#include > + > +#define sym_offs(sym) ((sym) - __XEN_VIRT_START) > + > + .section .efi.pe.header, "a", @progbits > + > +GLOBAL(efi_pe_head) I don't think this should be global. But I'll also comment on the linker script part using it. In any event there you only care about efi_pe_head - efi_pe_head_end, i.e. the size of this section. Linker scripts have SIZEOF() for this purpose - is it not possible to use that here? > + /* > + * Legacy EXE header. > + * > + * Most of it is copied from binutils package, version 2.30, > + * include/coff/pe.h:struct external_PEI_filehdr and > + * bfd/peXXigen.c:_bfd_XXi_only_swap_filehdr_out(). > + * > + * Page is equal 512 bytes here. > + * Paragraph is equal 16 bytes here. "is equal" is not very clear imo. How about '"Page" refers to an aligned block of 512 bytes here'? > + */ > + .short 0x5a4d /* EXE magic number. */ > + .short 0x90 /* Bytes on last page of file. */ > + .short 0x3 /* Pages in file. */ > + .short 0 /* Relocations. */ > + .short 0x4 /* Size of header in paragraphs. */ > + .short 0 /* Minimum extra paragraphs needed. */ > + .short 0xffff /* Maximum extra paragraphs needed. */ > + .short 0 /* Initial (relative) SS value. */ > + .short 0xb8 /* Initial SP value. */ > + .short 0 /* Checksum. */ > + .short 0 /* Initial IP value. */ > + .short 0 /* Initial (relative) CS value. */ > + .short 0x40 /* File address of relocation table. */ > + .short 0 /* Overlay number. */ > + .fill 4, 2, 0 /* Reserved words. */ > + .short 0 /* OEM identifier. */ > + .short 0 /* OEM information. */ > + .fill 10, 2, 0 /* Reserved words. */ > + .long Lpe_header - efi_pe_head /* File address of the PE header. */ > + > +Lpe_header: Was this meant to have a leading '.' (also again further down)? Else I don't see what the uppercase L is about. > + /* > + * PE/COFF header. > + * > + * The PE/COFF format is defined by Microsoft, and is available from > + * https://docs.microsoft.com/en-us/windows/win32/debug/pe-format > + * > + * Some ideas are taken from Linux kernel and Xen ARM64. > + */ > + .ascii "PE\0\0" /* PE signature. */ > + .short 0x8664 /* Machine: IMAGE_FILE_MACHINE_AMD64 */ > + .short 1 /* NumberOfSections. */ So like in xen-syms / xen.gz everything gets munged into a single section? Not very nice, I would say. > + .long XEN_COMPILE_POSIX_TIME /* TimeDateStamp. */ This wants to honor SOURCE_DATE_EPOCH (where for xen.efi we pass --no-insert-timestamp to the linker). Perhaps a missed re-base? > + .long 0 /* PointerToSymbolTable. */ > + .long 0 /* NumberOfSymbols. */ > + .short Lsection_table - Loptional_header /* SizeOfOptionalHeader. */ Nit: Too many blanks before the comment. > + .short 0x226 /* Characteristics: > + * IMAGE_FILE_EXECUTABLE_IMAGE | > + * IMAGE_FILE_LARGE_ADDRESS_AWARE | > + * IMAGE_FILE_DEBUG_STRIPPED | > + * IMAGE_FILE_LINE_NUMS_STRIPPED > + */ You don't specify IMAGE_FILE_RELOCS_STRIPPED here, but you also don't seem to generate base relocations. How is this going to work? > +Loptional_header: > + .short 0x20b /* PE format: PE32+ */ > + .byte 0 /* MajorLinkerVersion. */ > + .byte 0 /* MinorLinkerVersion. */ > + .long __2M_rwdata_end - efi_pe_head_end /* SizeOfCode. */ > + .long 0 /* SizeOfInitializedData. */ > + .long 0 /* SizeOfUninitializedData. */ Everything's code? > + .long sym_offs(efi_mb_start) /* AddressOfEntryPoint. */ > + .long sym_offs(start) /* BaseOfCode. */ > + .quad sym_offs(__image_base__) /* ImageBase. */ This last value is zero, isn't it? Can a PE image validly live at address 0? I have to admit that I question all of the sym_offs() uses here and below, which goes along with the lack of base relocations mentioned above. > + .long XEN_LOAD_ALIGN /* SectionAlignment. */ > + .long XEN_FILE_ALIGN /* FileAlignment. */ > + .short 2 /* MajorOperatingSystemVersion. */ > + .short 0 /* MinorOperatingSystemVersion. */ > + .short XEN_VERSION /* MajorImageVersion. */ > + .short XEN_SUBVERSION /* MinorImageVersion. */ > + .short 2 /* MajorSubsystemVersion. */ > + .short 0 /* MinorSubsystemVersion. */ > + .long 0 /* Win32VersionValue. */ > + .long __pe_SizeOfImage /* SizeOfImage. */ I'm not convinced of the utility of how you calculate this value just to use it here. Right now the value has to be MB(16) - any smaller value will cause breakage. > + .long efi_pe_head_end - efi_pe_head /* SizeOfHeaders. */ > + .long 0 /* CheckSum. */ > + .short 0xa /* Subsystem: EFI application. */ > + .short 0 /* DllCharacteristics. */ > + .quad 0 /* SizeOfStackReserve. */ > + .quad 0 /* SizeOfStackCommit. */ > + .quad 0 /* SizeOfHeapReserve. */ > + .quad 0 /* SizeOfHeapCommit. */ > + .long 0 /* LoaderFlags. */ > + .long 0x6 /* NumberOfRvaAndSizes. */ > + > + /* Data Directories. */ > + .quad 0 /* Export Table. */ > + .quad 0 /* Import Table. */ > + .quad 0 /* Resource Table. */ > + .quad 0 /* Exception Table. */ > + .quad 0 /* Certificate Table. */ > + .quad 0 /* Base Relocation Table. */ Based on what was the number of directory entries chosen here? 6 is a pretty unusual value - typically it would be 16, I think. I'm fine if this is for space savings (and known to be compatible), but then why not strip the other unused ones as well? Then again for the build ID don't you need the 7th entry (see xen.efi)? Or are you intentionally not exposing it in the PE way (in which case saying so, and why, would be needed in the description)? > +Lsection_table: > + .ascii ".text\0\0\0" /* Name. */ > + .long __2M_rwdata_end - efi_pe_head_end /* VirtualSize. */ > + .long sym_offs(start) /* VirtualAddress. */ > + .long __pe_text_raw_end - efi_pe_head_end /* SizeOfRawData. */ > + .long efi_pe_head_end - efi_pe_head /* PointerToRawData. */ Isn't this a file offset? If so, can it legitimately and reliably be calculated by a difference of two addresses? > + .long 0 /* PointerToRelocations. */ > + .long 0 /* PointerToLinenumbers. */ > + .short 0 /* NumberOfRelocations. */ > + .short 0 /* NumberOfLinenumbers. */ > + .long 0xe0500020 /* Characteristics: > + * IMAGE_SCN_CNT_CODE | > + * IMAGE_SCN_ALIGN_16BYTES | > + * IMAGE_SCN_MEM_EXECUTE | > + * IMAGE_SCN_MEM_READ | > + * IMAGE_SCN_MEM_WRITE > + */ At least the alignment specification here is fake. I realize it doesn't matter for loading purposes, but if an arbirary value was chosen it should imo be said so in a comment, to avoid future readers wondering. > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -32,7 +32,8 @@ static void __init edd_put_string(u8 *dst, size_t n, const char *src) > } > #define edd_put_string(d, s) edd_put_string(d, ARRAY_SIZE(d), s) > > -extern const intpte_t __page_tables_start[], __page_tables_end[]; > +extern intpte_t __page_tables_start[], __page_tables_end[]; I'm afraid I'm against this, no matter that it may be difficult to do differently what you do below. IOW ... > @@ -568,6 +569,7 @@ static void __init efi_arch_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, > > static void __init efi_arch_memory_setup(void) > { > + intpte_t *pte; > unsigned int i; > EFI_STATUS status; > > @@ -592,6 +594,13 @@ static void __init efi_arch_memory_setup(void) > if ( !efi_enabled(EFI_LOADER) ) > return; > > + if ( efi_enabled(EFI_MB_LOADER) ) > + for ( pte = __page_tables_start; pte < __page_tables_end; pte += ARRAY_SIZE(l2_directmap) ) > + /* Skip relocating the directmap because start_xen() does this for us when > + * when it updates all superpage-aligned mappings. */ > + if ( (pte != (intpte_t *)l2_directmap) && (get_pte_flags(*pte) & _PAGE_PRESENT) ) > + *pte += xen_phys_start; ... I consider this an RFC hack for which a clean solution wants to be found (note how __setup_arch() gets away without such). Also nit: Comment style. > @@ -724,7 +733,18 @@ static bool __init efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemTable) > > static void __init efi_arch_flush_dcache_area(const void *vaddr, UINTN size) { } > > -void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > +void EFIAPI efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable); > + > +void EFIAPI __init noreturn > +efi_mb_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > +{ > + __set_bit(EFI_MB_LOADER, &efi_flags); > + efi_start(ImageHandle, SystemTable); > +} > + > +void __init efi_multiboot2(EFI_HANDLE ImageHandle, > + EFI_SYSTEM_TABLE *SystemTable, > + multiboot2_tag_module_t *dom0_kernel) > { Hmm, yet another entry point. See also at the very bottom. > --- a/xen/arch/x86/efi/stub.c > +++ b/xen/arch/x86/efi/stub.c > @@ -15,9 +15,19 @@ > * Here we are in EFI stub. EFI calls are not supported due to lack > * of relevant functionality in compiler and/or linker. > * > - * efi_multiboot2() is an exception. Please look below for more details. > + * efi_mb_start() and efi_multiboot2() are the exceptions. > + * Please look below for more details. > */ > > +asm ( > + " .text \n" > + " .globl efi_mb_start \n" > + "efi_mb_start: \n" > + " mov %rcx,%rdi \n" > + " mov %rdx,%rsi \n" > + " call efi_multiboot2 \n" > + ); Okay, this I understand is for calling conventions translation. A comment saying so would be nice. Plus I don't see why this then uses "call", not "jmp". > --- a/xen/arch/x86/xen.lds.S > +++ b/xen/arch/x86/xen.lds.S > @@ -63,7 +63,22 @@ SECTIONS > > start_pa = ABSOLUTE(start - __XEN_VIRT_START); > > +#ifdef EFI > . = __XEN_VIRT_START + XEN_IMG_OFFSET; > +#else > + /* > + * Multiboot2 with an EFI PE/COFF header. > + * > + * The PE header must be followed by .text section which > + * starts at __XEN_VIRT_START + XEN_IMG_OFFSET address. > + */ > + . = __XEN_VIRT_START + XEN_IMG_OFFSET - efi_pe_head_end + efi_pe_head; > + > + DECL_SECTION(.efi.pe.header) { > + *(.efi.pe.header) > + } :NONE > +#endif "Must be followed" in the comment is about file layout, not address layout. Yet the latter is what matters in the linker script. If there is a true requirement for it to be exactly like this, more explanation is needed in the comment. But it seems more likely to me that this simply isn't correct. As said elsewhere, the executable header of a PE image lives at RVA 0 afaict. > @@ -289,6 +304,13 @@ SECTIONS > *(.data.rel) > *(.data.rel.*) > CONSTRUCTORS > + /* > + * A la the PE/COFF spec, the PE file data section must end at the > + * alignment boundary equal to FileAlignment in the optional header, > + * i.e., XEN_FILE_ALIGN. > + */ > + . = ALIGN(XEN_FILE_ALIGN); > + __pe_text_raw_end = .; > } :text What is a "PE file data section"? Yes, the file size of a section must be a multiple of the specified file alignment. With the present value of 32 bytes this isn't much of an issue, but already in case we were in need of going up to 512 bytes I'd say this is undue overhead for the ELF image. I could see you not advancing . here (by using __pe_text_raw_end = ALIGN(XEN_FILE_ALIGN); ) and then making sure the generated image gets padded as necessary. > @@ -392,5 +417,14 @@ ASSERT((trampoline_end - trampoline_start) < TRAMPOLINE_SPACE - MBI_SPACE_MIN, > ASSERT((wakeup_stack - wakeup_stack_start) >= WAKEUP_STACK_MIN, > "wakeup stack too small") > > +#ifndef EFI > +ASSERT(efi_pe_head_end == _start, "PE header does not end at the beginning of .text section") As said earlier - I question this relationship. > +ASSERT(_start == __XEN_VIRT_START + XEN_IMG_OFFSET, ".text section begins at wrong address") I'd then hope this could go away as well. > +ASSERT(IS_ALIGNED(_start, XEN_FILE_ALIGN), "_start misaligned") I can't see how this could trigger when the former one doesn't. > +ASSERT(IS_ALIGNED(__bss_start, XEN_FILE_ALIGN), "__bss_start misaligned") What is this trying to verify? > +ASSERT(IS_ALIGNED(__pe_SizeOfImage, XEN_LOAD_ALIGN), "__pe_SizeOfImage is not multiple of XEN_LOAD_ALIGN") This looks odd too, but I've commented on __pe_SizeOfImage further up already anyway. > +ASSERT(XEN_LOAD_ALIGN >= XEN_FILE_ALIGN, "XEN_LOAD_ALIGN < XEN_FILE_ALIGN") Why? I would generally consider the two values pretty much independent. > --- a/xen/include/xen/efi.h > +++ b/xen/include/xen/efi.h > @@ -11,6 +11,7 @@ extern unsigned int efi_flags; > #define EFI_BOOT 0 /* Were we booted from EFI? */ > #define EFI_LOADER 1 /* Were we booted directly from EFI loader? */ > #define EFI_RS 2 /* Can we use runtime services? */ > +#define EFI_MB_LOADER 4 /* xen.mb.efi booted directly from EFI loader? */ Is a separate flag really needed? I realize this is connected to the page table relocation approach, so might go away anyway. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 15 13:41:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 13:41:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98034.185888 (Exim 4.92) (envelope-from ) id 1lLnSv-0005Zm-Gc; Mon, 15 Mar 2021 13:41:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98034.185888; Mon, 15 Mar 2021 13:41:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnSv-0005Zf-C1; Mon, 15 Mar 2021 13:41:01 +0000 Received: by outflank-mailman (input) for mailman id 98034; Mon, 15 Mar 2021 13:41:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnSu-0005Za-1z for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 13:41:00 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3c9cf899-bb8f-4669-aa58-80eacfbfd43c; Mon, 15 Mar 2021 13:40:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c9cf899-bb8f-4669-aa58-80eacfbfd43c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615815658; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=RmDTRRT773a3FF+aRD9nWGNymyPgQV2shfmE2mJn5X8=; b=aSV/ZeXnrRlmXPPrUX0MI/YsNv54KWiKa0fHd5XAiAjQ9/3tKcqyV9iC jthWu9jYcGiPOmuVG7xCn7PQgAwMjzascBbfHDtY7wIPk9cN78OzzTnHr c8D+X59TXnG4ioUUOlREs5aqdMbyivRn3fIOJQkhiSMxUAg/R64h51J+O k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 4r2foL93q6no+3cyxg//tdBpmb88CsnnyZ1YyNYAFSFU5KPQZaYU3PkBGbQaV4GTqWVo0wBmdk xHFstwKuMtb+L7m1YnpPKr6Ms4EHRcNcVb5rGoWRKQXwmC22QSkGD7e4N7bhre5KEFc4jxmGxu OIMU/EBnJM96Mf/yX41PCXKB6GUdy1vjBfT+QVikGjRFWtpwfgSlsVmIJyPXk9iG/+jF3Fi39O dM/G4ozdpkwtdevC+0NJH7v6wXkWOezm1SyoXRDFs635u8bMtIf6OdQ8DxRoMrKxyT8iZHow/F FkU= X-SBRS: 5.2 X-MesageID: 39286645 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:l5uo8qn8gDY4e4ZgKBksaLh0E7bpDfK53DAbvn1ZSRFFG/Gwvc aogfgdyFvIkz4XQn4tgpStP6OHTHPa+/dOkOwsFJ2lWxTrv3btEZF64eLZsl/dMgDd1soY+q dkbqRkYeebMXFWr+bfpDO5HdEp3cWd/MmT6Nv24n9xQWhRGsVdxihjDALzKCFLbS1nIbZ8K5 aG/MpAoFObCBcqR+C2HGMMUeSGh/CjrvPbSCULDRIm9wWC5AnAgILSKBSA2wdbbjUn+9gf2F LYmA/07LjLiZGG4yLbvlW8071m3P/a67J4b/Cxtg== X-IronPort-AV: E=Sophos;i="5.81,249,1610427600"; d="scan'208";a="39286645" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G1phWj/2Q3Esd2vUtPmt/MqqxJTbWZbL99YQCa23IXurxG3k+3zSbyj36EHkSvcAb0323LhYN/wXptFMWagiJfA8AkODto7aV24OaTyIU6wKokUW1cHvXOnMoTJfLZPLihA7Q3xoWuZCNyNDWM8mZIbyjBZXIqmIXl1SFRTMCCIzoL8cBhXSb2t09iDvGwX+wGZ4PeTVP8siKKjE0rP12tia4mOPnOf1jQZ4QGE++bOOZNm3wrDGqiHlBejiUthZ7DMn0WlNqH415kdR/pZuMY1m/i9JUOLdkQFhRS7R6fybUmexocq11FBW3S/xwJujCqvt1rJEbz1J/T/6WBYn9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RmDTRRT773a3FF+aRD9nWGNymyPgQV2shfmE2mJn5X8=; b=DY/DCGYKi7hh+uEuJ0R7aR34L452Yk0QYin4XeeOHmWvQdX6IXjwKr0H1MNSrIVOksQBuBJxweJ3JZjvrJnoP0caMm0HhyZHBdImw/F/l3IMM7NbHs6d7Z+eDc2YrNdZUT5AFTnWUTlCz8zRvKzKkAj77JEkuWFPXkgTx5q1yr9Q9RPBiOPGgdohxhLwCnKCvpbS8AvE171jGqqJCGVXrUm6MeFi/aE0Dn851BRocq6AnEoOXnd+zHhTp+lMx9Vvufwe2M08XAY4kNK2sqM+prCsVGUno4DWhKmLfIIAhXeV2KmlqJTAgyTCujk3Cs1WJyR7iw3/eOUg1wf42PpD2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RmDTRRT773a3FF+aRD9nWGNymyPgQV2shfmE2mJn5X8=; b=Od5x45v5Liaz6Z4VwCucj+NOa7R769pPpjJk0kfqumC8ladndZYyTRt66s6S49NzGgjxhocG5A9LcYjativ8GLf971jS5pEP+lvrWTX4g5FLnQJYxXgxS/FAWCZnz21cp1siM3zoNArfC5n15vSVC5o4bZI2VivV9jOW3qXoujU= From: George Dunlap To: Ian Jackson CC: "open list:X86" , Community Manager Subject: Re: [PATCH 4.15 3/3] CHANGELOG.md: Glean some information from SUPPORT.md Thread-Topic: [PATCH 4.15 3/3] CHANGELOG.md: Glean some information from SUPPORT.md Thread-Index: AQHXFPObmjsak1n05US1KozduC4yDaqFE8uAgAAD7oA= Date: Mon, 15 Mar 2021 13:40:52 +0000 Message-ID: <07E3E597-6E99-4591-BE73-737B59DF5E17@citrix.com> References: <20210309145002.30359-1-iwj@xenproject.org> <20210309145002.30359-4-iwj@xenproject.org> <702645DF-2B40-42E9-95A3-11A8BF3E7E0C@citrix.com> In-Reply-To: <702645DF-2B40-42E9-95A3-11A8BF3E7E0C@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 99af2010-3190-458c-6c89-08d8e7b7f386 x-ms-traffictypediagnostic: PH0PR03MB5832: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tVm84epMHmFoDBqW4Hipx6XU7rf61Zm9dVH4Vk3i6XhIdpdZVPv1Pd1RJviPrBzLu6VKGkfVFn0hy9eIBlQVUqUu5AMrvnuQKmGQrOHP4HlLubTQfXm8neVVyO24nlVuM57KbG7EMfixq6EXFdtzJOg7Mvmawkk8R+fn1MQCyVsKlMNPwvZv2l8s2+HlqdHJR+s29pYjux/Te39/o4UbbWRyjzZueoeq9eIyVbI9SAyX86v0cnw/SgO6rcmtahNkXV7qckcfzM6I3y6napgRf/1bnIBeRI/lgoAwAEYib1yWNuBip+1A7hCdNRHMofSKbTWFHtJ6iuOTDORaJko/m4KmKGf5ibw/eGqGEA9i/4X7SPHjpma0mRADBBX1Ev6C81Y8NKGvISjKh0Xu+H+FQJe6HgdVtDl8DIF3OLnL7yICDw0z1bjhfSeF2dU0cmbj0VaXATTKfd5w/YhSCK2mk5gQw1oz+34PGoNNkp2RI9kvNkyv3Ahg3cYlhShJpbgRXGEoHdOFjzm0p0WY1Ox8ikseDKciTuKLwn6pFcEdOMh6gXfuhGg9VySwHhtd93p622fx5HPlZQNGgq1E0nZAVsGYGPi3EAkoyCU1Y9fxuZBmO5JeZH2jiZ3mwSDmMxXCdP+HjCRGkH1XKwdeOWjc9w65gN+oEg1e/5YpteDdJhdzLqJ5pTUZQ97QMx94uWkGWiEmcX0cEkAML09mhn30fPBTg8Y/FeorJw6K70jT2VGRaiQoVlnIqcTDI1vdGhrM x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(346002)(376002)(136003)(396003)(2906002)(83380400001)(8936002)(66446008)(33656002)(91956017)(5660300002)(66476007)(86362001)(2616005)(478600001)(36756003)(8676002)(6486002)(6916009)(316002)(66946007)(64756008)(4326008)(6512007)(66556008)(53546011)(6506007)(76116006)(26005)(71200400001)(54906003)(186003)(207903002)(219803003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?bFh5ckNZQ2wvSnVYSFVZNlZWWTluZ3ZSWUhkLzY5TmxXdDhuZXc3ekpzVDFN?= =?utf-8?B?eWszemZPYlBYdmtOWjVxQ3BSTEMycFNET3FMeWZTeUNkeE5vd0NhLzVZRjRG?= =?utf-8?B?ek9XVmNzM2Z5NWQyMnVSdFlZM2YzSHBXZmluc21HdE9YdGFncjFySnNEbm1s?= =?utf-8?B?UjQ4UmI5ZW9OS2tzYXE0YUN4TGozZ2NCTXJWKzNqWDN4WitUVU1MRjdMVXB4?= =?utf-8?B?cmE0MzMwdDJHbEtLRTJuWjFIamZvL3Z1N0Q1Y0gxYnQ3Zm1pUndseTNlK09u?= =?utf-8?B?NnZVVkZoY1JEUDV1WHJQVmc4N1UxbWxSVWkxczZ1USt2NDNheFdIc1Y2eVpa?= =?utf-8?B?KzhiWmtBRmJqb1FUcHRtdy9SNFFRYTdKTHRGWENQVGE2cnVpSlo5ZVNja2ZZ?= =?utf-8?B?VXBXbTdYU1dtSXdYVVluSlBCRTlUNENVSzFBMURicUQyNlgyVmZVdXV3cXlX?= =?utf-8?B?b3B1cnovVllIMllrcFpnSlJ3MWJoUG5zU3dkSDFwM0p2eGgxTmpzWUkxZ2Vq?= =?utf-8?B?MUFzNm4xOFFRVVhucE52TUxGd0lGYndVWDIwWS96K1NpcDI1TXdJZko3cEdO?= =?utf-8?B?cjFReWV0TnFyRi9zaWVRM0JCeFhGQWRvUGVJaUZ4bi9XTm5xZnpudlRlTUsx?= =?utf-8?B?SEt4VGx0WUJvcUFudWQ0eGxCN1ZKQ0tTek95dDRhQTduYTdJWVIrNzkyK2lr?= =?utf-8?B?QkhxL0VYalErWlhyazBmY01OZlZEUTg0eU9JWFM2eWtPdExhZVB0VFhJeHE5?= =?utf-8?B?dVJDWE5kM1k5UFZpWFFLak90SVRxUTlrSmIydU1DS0ZTYUhVQk5Pbm9KRGhh?= =?utf-8?B?aDU5TGlmSTFtNlZaYlNwbmErUTNpT3B2OWl6aXpOZkxNR0lWK0pTRVdxZ3dY?= =?utf-8?B?QnpEOGQ0UW5Ta2Y4NjhNUWFha2Vya1REQmRJeTlJOHc4K1BsR0ZESFRYUE1V?= =?utf-8?B?bGRudzNUbzVUb2FYeDdxeVJTK0RwRndmZFdrYkZvN2pJSXhFMzVwWE1yUzQ1?= =?utf-8?B?c01GVWo0UEdJQjhoZTA2UktEZEZiVDFtMHhSNWN3Qk94K3ZmL3Zqb2RPNzNa?= =?utf-8?B?TzJ3MCtWMTlxNElQZHdIcE52STZlalZHRHVla3FrRjJNNXhaaG1sZDZjUjFX?= =?utf-8?B?Z3Q5Y0pONXFNdzJ4UFFRZ290eFluTXhOdmgwRy9lYzVoZG5HcGs3LzdFblBa?= =?utf-8?B?RndMbnE1eVdIcVNCbk9oaHVOa0JWdlM2a2IwWEdkbjUybWcreEZXQ1VyQ0NY?= =?utf-8?B?d0NwRXpXb1NwQ1RjWEgxMHVMeThiYVdCSjFYWE5DVHBRZHNvTUhWR3kvRTRu?= =?utf-8?B?UFc2d2pqZTh5QmRtc0hIem9oUzQ5RVJFWDlvQk5DVGtraUIyQWR0T3ZiRDZ4?= =?utf-8?B?NnJDSU5CcHFWaFRrTzhEZDFKMU9Xam5KTGFHWFp5aHZLemlmKzU4aXg4aXpi?= =?utf-8?B?ZnROdHh1OG4zMHhzb3hSSzVOTEYzRWs0dmIrMmcxdFg2aWN0MkhMWHUyZ3p5?= =?utf-8?B?K0VGNzVMOGVScy9XbzJJZ3NUeFF1a0tsM08yajdhSW51RDZ0cXdHR29QRG9i?= =?utf-8?B?YUxmaGRjd2JjN3ZaejUyTGg3SVdtMnpqT0w1ZVBwcjhuakNpMEMyUHllM0hC?= =?utf-8?B?ZnQ5K2trMGJuKzBBMk9Lci9ReVZwNU9SQ2RRV25qb3huU0hlR2xIZFgwa0k2?= =?utf-8?B?cDJQOWFBd3E3NFZWalljV09UamJjWDJZTGdKNi9qeStTSWVzQ1pyT1lDK1U5?= =?utf-8?B?WHc0QlQwZEZudEp2dFZnTFQ2b0Rjd21kRngyMW12ZWVUQmZTalZXbVQrU2N5?= =?utf-8?B?UG1sTlpZeUxzT2dxOERDUT09?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <08F34D78830D334490EC327B0EDCC798@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99af2010-3190-458c-6c89-08d8e7b7f386 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2021 13:40:52.2863 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dLX0l3OCYsHC3U0O9Inb3Fa4sNJbMZdn9cMWbMDTl5hWMVfIvYfsLerbpl2dy6yN2DBX29LIN7lufddHjJeuAu+PdjcDqEg0CRESYrv5DV8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5832 X-OriginatorOrg: citrix.com DQoNCj4gT24gTWFyIDE1LCAyMDIxLCBhdCAxOjI2IFBNLCBHZW9yZ2UgRHVubGFwIDxHZW9yZ2Uu RHVubGFwQGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gDQo+IA0KPj4gT24gTWFyIDksIDIwMjEs IGF0IDI6NTAgUE0sIElhbiBKYWNrc29uIDxpd2pAeGVucHJvamVjdC5vcmc+IHdyb3RlOg0KPj4g DQo+PiBTaWduZWQtb2ZmLWJ5OiBJYW4gSmFja3NvbiA8aXdqQHhlbnByb2plY3Qub3JnPg0KPj4g LS0tDQo+PiBDSEFOR0VMT0cubWQgfCAxMCArKysrKysrKysrDQo+PiAxIGZpbGUgY2hhbmdlZCwg MTAgaW5zZXJ0aW9ucygrKQ0KPj4gDQo+PiBkaWZmIC0tZ2l0IGEvQ0hBTkdFTE9HLm1kIGIvQ0hB TkdFTE9HLm1kDQo+PiBpbmRleCA0ZWNkMTU3YTM1Li5jY2RiYjgyYzJlIDEwMDY0NA0KPj4gLS0t IGEvQ0hBTkdFTE9HLm1kDQo+PiArKysgYi9DSEFOR0VMT0cubWQNCj4+IEBAIC02LDYgKzYsMTYg QEAgVGhlIGZvcm1hdCBpcyBiYXNlZCBvbiBbS2VlcCBhIENoYW5nZWxvZ10oaHR0cHM6Ly9rZWVw YWNoYW5nZWxvZy5jb20vZW4vMS4wLjAvKQ0KPj4gDQo+PiAjIyBbVW5yZWxlYXNlZF0oaHR0cHM6 Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zaG9ydGxvZykNCj4+IA0KPj4g KyMjIEFkZGVkIC8gc3VwcG9ydCB1cGdyYWRlZA0KPj4gKyAtIExpbnV4IGRldmljZSBtb2RlbCBz dHViZG9tYWlucyAoVGVjaCBQcmV2aWV3KQ0KPj4gKyAtIFhlbiBQViBkaXNwbGF5IHByb3RvY29s ICJiYWNrZW5kIGFsbG9jYXRpb24iIG1vZGUgKEV4cGVyaW1lbnRhbCkNCj4+ICsgLSBBUk0gSU9S RVEgc2VydmVycyAoZGV2aWNlIGVtdWxhdGlvbiBldGMuKSAoVGVjaCBQcmV2aWV3KQ0KPj4gKyAt IFJlbmVzYXMgSVBNTVUtVk1TQSAoU3VwcG9ydGVkLCBub3Qgc2VjdXJpdHkgc3VwcG9ydGVkOyB3 YXMgVGVjaCBQcmV2aWV3KQ0KPj4gKyAtIEFSTSBTTU1VdjMgKFRlY2ggUHJldmlldykNCj4gDQo+ IE90aGVyIGdlbmVyYWwgdGhpbmdzIEnigJltIHNlZWluZyBpbiB0aGUgdHJlZSAobWF5IG5lZWQg Ym90aCBTVVBQT1JULm1kIGFuZCBjaGFuZ2Vsb2cgdXBkYXRlcyk6DQo+IA0KPiAqIFN1cHBvcnQg Zm9yIHpzdGQtY29tcHJlc3NlZCBkb20wIGtlcm5lbHMNCj4gKiB2bXRyYWNlIHN1cHBvcnQNCj4g KiBuYW1lZCBQQ0kgZGV2aWNlcyBpbiB4bCAvIGxpYnhsDQo+ICogZ250dGFiIHN0dXBwb3J0IGZv ciBOZXRCU0QNCj4gKiB2aXJpZGlhbjogQmV0dGVyIHZpcnR1YWxpemVkIElQSSBzdXBwb3J0LCBj cHUgaG90cGx1ZywgcmVtb3ZhbCBvZiA2NC12Y3B1IGxpbWl0DQo+ICogeDg2X2VtdWxhdGUgc3Vw cG9ydCBmb3IgQVZYLVZOTkkNCj4gKiBFeHBhbmRlZCB0ZXN0LWNhc2VzIGZvciB4ODZfZW11bGF0 ZQ0KPiAqIEhWTS1zcGVjaWZpYyBNTSBjb2RlIChzaGFkb3csIHAybSkgY29kZSBmYWN0b3JlZCBv dXQgaW50byBhIHNlcGFyYXRlIGZpbGUNCj4gKiBoeXBmczogQWRkZWQgY3B1cG9vbCBkaXJlY3Rv cmllcyBhbmQgY29udHJvbHMNCg0KTW9yZSB0aGluZ3M6DQoNCiogU29tZXRoaW5nIGFib3V0IE1T UnM/DQoqIENJIGxvb3A6IEFkZGVkIFVidW50dSBmb2NhbCwgYWxwaW5lIGxpbnV4IHRhcmdldHMN CiogQ0kgbG9vcDogQWRkZWQg4oCcYXJ0aWZhY3Rz4oCdIHN1cHBvcnQgZm9yIG1vcmUgZWZmaWNp ZW50IHRlc3RpbmcNCiogQ0kgbG9vcDogQWRkZWQgZG9tMGxlc3MsIGFscGluZSBMaW51eCBkb20w IHRlc3RzDQoNCkFnYWluLCB0aGlzIGlzIGp1c3QgbWUgdHJ5aW5nIHRvIGd1ZXNzIGZyb20gc2tp bW1pbmcgdGhlIGNoYW5nZWxvZy4NCg0KIC1HZW9yZ2U= From xen-devel-bounces@lists.xenproject.org Mon Mar 15 13:43:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 13:43:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98039.185900 (Exim 4.92) (envelope-from ) id 1lLnUv-0005kP-Vc; Mon, 15 Mar 2021 13:43:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98039.185900; Mon, 15 Mar 2021 13:43:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnUv-0005kI-Sc; Mon, 15 Mar 2021 13:43:05 +0000 Received: by outflank-mailman (input) for mailman id 98039; Mon, 15 Mar 2021 13:43:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnUu-0005kB-GY for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 13:43:04 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2b1a0909-b338-4a73-b334-6ffcdbb3d459; Mon, 15 Mar 2021 13:43:03 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 085B9AE1F; Mon, 15 Mar 2021 13:43:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b1a0909-b338-4a73-b334-6ffcdbb3d459 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615815783; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e4ABBFVGdT2XYXoO2vyay7DO/9ObTm0n//0dhYk0bSs=; b=ihcOiHsotN3ficjT3s3CYgD5m3XAuf+Hj2Q3i3XEdf0lEsQy++EmgmSZtgwxdLg2dTBN1S cZW+rFU7PMBzH76gDYui8xFKRybWMt27onGgRYCqjSu8dbACIteh49m/CqBBvgNREYVqrw OJTYFB2HqDcoaNInx+hGEAAoBpxiLfA= Subject: Re: [PATCH 4.15 3/3] CHANGELOG.md: Glean some information from SUPPORT.md To: George Dunlap Cc: "open list:X86" , Community Manager , Ian Jackson References: <20210309145002.30359-1-iwj@xenproject.org> <20210309145002.30359-4-iwj@xenproject.org> <702645DF-2B40-42E9-95A3-11A8BF3E7E0C@citrix.com> <07E3E597-6E99-4591-BE73-737B59DF5E17@citrix.com> From: Jan Beulich Message-ID: <8a53528d-73c1-bb78-c54d-ac25b60c29ae@suse.com> Date: Mon, 15 Mar 2021 14:43:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <07E3E597-6E99-4591-BE73-737B59DF5E17@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 15.03.2021 14:40, George Dunlap wrote: >> On Mar 15, 2021, at 1:26 PM, George Dunlap wrote: >>> On Mar 9, 2021, at 2:50 PM, Ian Jackson wrote: >>> >>> Signed-off-by: Ian Jackson >>> --- >>> CHANGELOG.md | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/CHANGELOG.md b/CHANGELOG.md >>> index 4ecd157a35..ccdbb82c2e 100644 >>> --- a/CHANGELOG.md >>> +++ b/CHANGELOG.md >>> @@ -6,6 +6,16 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>> >>> ## [Unreleased](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog) >>> >>> +## Added / support upgraded >>> + - Linux device model stubdomains (Tech Preview) >>> + - Xen PV display protocol "backend allocation" mode (Experimental) >>> + - ARM IOREQ servers (device emulation etc.) (Tech Preview) >>> + - Renesas IPMMU-VMSA (Supported, not security supported; was Tech Preview) >>> + - ARM SMMUv3 (Tech Preview) >> >> Other general things I’m seeing in the tree (may need both SUPPORT.md and changelog updates): >> >> * Support for zstd-compressed dom0 kernels >> * vmtrace support >> * named PCI devices in xl / libxl >> * gnttab stupport for NetBSD >> * viridian: Better virtualized IPI support, cpu hotplug, removal of 64-vcpu limit >> * x86_emulate support for AVX-VNNI >> * Expanded test-cases for x86_emulate >> * HVM-specific MM code (shadow, p2m) code factored out into a separate file >> * hypfs: Added cpupool directories and controls > > More things: > > * Something about MSRs? I guess that's rather something which needs mentioning in release notes. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 15 13:46:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 13:46:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98042.185911 (Exim 4.92) (envelope-from ) id 1lLnXv-0005tj-EB; Mon, 15 Mar 2021 13:46:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98042.185911; Mon, 15 Mar 2021 13:46:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnXv-0005tc-BG; Mon, 15 Mar 2021 13:46:11 +0000 Received: by outflank-mailman (input) for mailman id 98042; Mon, 15 Mar 2021 13:46:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLnXt-0005tV-SS for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 13:46:09 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e3738703-a2f8-4b3a-aea0-29bd42e0375c; Mon, 15 Mar 2021 13:46:09 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5C347AC17; Mon, 15 Mar 2021 13:46:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3738703-a2f8-4b3a-aea0-29bd42e0375c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615815968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oMJgGynccBEUh/WfqbIl3SA0Hb8VrWVgfQqFaCKvHjE=; b=REflTo1rbhpPPbWKt6opQXZfCDoF/Of4+OiCCF6itZg8Rfsnc+RpxCbWhMb1xSHk7u1CYF jxiOgMWTUCxD7B/c0gOQiiBiYXMbMW94w/m63fh9V9zlMMfBYmpsSX3pL/bpZ7TGckM+GB MPvgGMFlNCeui0+rRDOy7n0ORTqD6J4= Subject: Re: [ANNOUNCE] Xen 4.15 release update - still in feature freeze To: Ian Jackson Cc: Andrew Cooper , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , Dario Faggioli , committers@xenproject.org, xen-devel@lists.xenproject.org References: <24655.20609.834996.744652@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <4531d373-3915-ad90-ef99-4f8cbbdb5054@suse.com> Date: Mon, 15 Mar 2021 14:46:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <24655.20609.834996.744652@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 15.03.2021 13:18, Ian Jackson wrote: > ISSUES BELIEVED NEWLY RESOLVED > ============================== > > Fallout from MSR handling behavioral change. > > I think there are now no outstanding patches to fix/change MSR > behaviour and there is no longer any blocker here ? In addition to what Andrew has said, while not a blocker in that sense I think the excessive verbosity of the logging is also an issue. > x86/time: calibration rendezvous adjustments > > Information from > Jan Beulich > > Not entirely a regression. 3 out of the 4 patches seem to have been > committed. > > Patch 4/ is not targeted at 4.15 I think. Indeed. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 15 15:05:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 15:05:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98076.185927 (Exim 4.92) (envelope-from ) id 1lLomc-0004f3-IT; Mon, 15 Mar 2021 15:05:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98076.185927; Mon, 15 Mar 2021 15:05:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLomc-0004ew-ET; Mon, 15 Mar 2021 15:05:26 +0000 Received: by outflank-mailman (input) for mailman id 98076; Mon, 15 Mar 2021 15:05:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLomb-0004er-F0 for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 15:05:25 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6dd6a88d-618d-482f-bd47-6dca50e50ff6; Mon, 15 Mar 2021 15:05:23 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 62860AC17; Mon, 15 Mar 2021 15:05:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6dd6a88d-618d-482f-bd47-6dca50e50ff6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615820722; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zMjeCiwUpSUpApoVmciAPnZR/b20VgGEjDPEJRHbIF8=; b=jWNnzTu+UWgcvgjeaMpAuqJ2PKFznh7g212OP6e28pzkNCl2rjkYhOmwkuotyh5OMZS2Mi ibGliumQJOW6GrIUrQj6cR0wlOdUVVrm7i3JhVnr9HIdjtJh7Y1lqDiLjQT8ZHaLdRSTU3 TNJ9T4sv5U8Meq26fqVpHDM9y9HfDEo= Subject: Re: [PATCH v3 3/5] xen/x86: add some addresses to the Multiboot header To: Bobby Eshleman Cc: Daniel Kiper , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xen-devel References: <0b05bedc32833a2022d2698d4c116cb867a9119c.1611273359.git.bobbyeshleman@gmail.com> From: Jan Beulich Message-ID: Date: Mon, 15 Mar 2021 16:05:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <0b05bedc32833a2022d2698d4c116cb867a9119c.1611273359.git.bobbyeshleman@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 22.01.2021 01:51, Bobby Eshleman wrote: > From: Daniel Kiper > > In comparison to ELF the PE format is not supported by the Multiboot > protocol. So, if we wish to load xen.mb.efi using this protocol we > have to put header_addr, load_addr, load_end_addr, bss_end_addr and > entry_addr data into Multiboot header. > > The Multiboot protocol spec can be found at > https://www.gnu.org/software/grub/manual/multiboot/ And because of this spec saying "the boot loader should use them instead of the fields in the actual executable header to calculate where to load the OS image" this change will affect the ELF image as well. For example ... > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > @@ -50,13 +50,24 @@ ENTRY(start) > .balign 4 > multiboot1_header: /*** MULTIBOOT1 HEADER ****/ > #define MULTIBOOT_HEADER_FLAGS (MULTIBOOT_HEADER_MODS_ALIGNED | \ > - MULTIBOOT_HEADER_WANT_MEMORY) > + MULTIBOOT_HEADER_WANT_MEMORY | \ > + MULTIBOOT_HEADER_HAS_ADDR) > /* Magic number indicating a Multiboot header. */ > .long MULTIBOOT_HEADER_MAGIC > /* Flags to bootloader (see Multiboot spec). */ > .long MULTIBOOT_HEADER_FLAGS > /* Checksum: must be the negated sum of the first two fields. */ > .long -(MULTIBOOT_HEADER_MAGIC + MULTIBOOT_HEADER_FLAGS) > + /* header_addr */ > + .long sym_offs(multiboot1_header) > + /* load_addr */ > + .long sym_offs(start) > + /* load_end_addr */ > + .long sym_offs(__bss_start) > + /* bss_end_addr */ > + .long sym_offs(__2M_rwdata_end) ... the ELF image end at _end, not at __2M_rwdata_end. I realize that with 2M alignment in use, this may actually be a problem, as one of the modules (the initrd in particular) could be placed overlapping the (_end, __2M_rwdata_end) range. Nevertheless I think you want to specify _end (or __bss_end) here. As to the initial point made - would it be possible to leave the flag unset in the EFL image and force it set only in xen.mb.efi? Yes, this may require yet another post-processing step. Jan > + /* entry_addr */ > + .long sym_offs(__start) > > .size multiboot1_header, . - multiboot1_header > .type multiboot1_header, @object > From xen-devel-bounces@lists.xenproject.org Mon Mar 15 17:27:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 17:27:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98095.185943 (Exim 4.92) (envelope-from ) id 1lLqzx-0000Wj-Oz; Mon, 15 Mar 2021 17:27:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98095.185943; Mon, 15 Mar 2021 17:27:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLqzx-0000Wc-LS; Mon, 15 Mar 2021 17:27:21 +0000 Received: by outflank-mailman (input) for mailman id 98095; Mon, 15 Mar 2021 17:27:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLqzw-0000WU-9X; Mon, 15 Mar 2021 17:27:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLqzv-0005Tm-Vi; Mon, 15 Mar 2021 17:27:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLqzv-00031w-Lp; Mon, 15 Mar 2021 17:27:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLqzv-0005Gc-L8; Mon, 15 Mar 2021 17:27:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=N+zRblwQTpbE5RW7gGMQpxC4zjGmbo7rlf0o+leYzPI=; b=nEp74LdBkp3bd2GpXWDT22tOJn CIeXqMlzO3TdnKKOMTbefYzN1W6kq1npXwp6U82dhm27db1C/Cz/EjS/Wan/AXV6AWiKSp2xqIvby Ng84F8YrztpSuLai9xZak5Vxtlisl/SkS2WBixyyvdRA6LNewmE1PiKDIBldLaY6sB0I=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160084: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1e28eed17697bcf343c6743f0028cc3b5dd88bf0 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 15 Mar 2021 17:27:19 +0000 flight 160084 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160084/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux 1e28eed17697bcf343c6743f0028cc3b5dd88bf0 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 226 days Failing since 152366 2020-08-01 20:49:34 Z 225 days 392 attempts Testing same since 160084 2021-03-15 03:13:23 Z 0 days 1 attempts ------------------------------------------------------------ 5213 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1293527 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 15 18:34:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 18:34:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98104.185957 (Exim 4.92) (envelope-from ) id 1lLs2Q-0006jK-Rw; Mon, 15 Mar 2021 18:33:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98104.185957; Mon, 15 Mar 2021 18:33:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLs2Q-0006jD-P5; Mon, 15 Mar 2021 18:33:58 +0000 Received: by outflank-mailman (input) for mailman id 98104; Mon, 15 Mar 2021 18:33:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLs2P-0006j8-65 for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 18:33:57 +0000 Received: from mail-wm1-f53.google.com (unknown [209.85.128.53]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d77a38b9-cafc-4164-8056-b33122f25845; Mon, 15 Mar 2021 18:33:55 +0000 (UTC) Received: by mail-wm1-f53.google.com with SMTP id j4-20020a05600c4104b029010c62bc1e20so12469wmi.3 for ; Mon, 15 Mar 2021 11:33:55 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id h62sm497868wmf.37.2021.03.15.11.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 11:33:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d77a38b9-cafc-4164-8056-b33122f25845 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4D7f2OSz3pBZtWumkrjvu3FzHc2w5TORo1dgod9Oghk=; b=psYXFXmf0nSldC44n3dTo/y6c4nF5oNwok6GilrHRXQLW6AGICmyKlIAlSR8in6xAe YSWPwDU3thSCzeocpU17T1ZQbbV6eMx7kSwOHAXB04LJ+rpCSxRu6NFhSQsT22sUYEbN lPuR5P8O0QKpiz18t796drxoOz2sJDZPSxAEq/SeEppq01bgbiVHGiGjaBRCMBQu8cad 0VX+FEGLhhmOtSsN2vqAf1e5YlVIZOTNEY82AhPhoho1GaTjtbdJaNOiqkh3m3lyu/Af h6EhjS9lqOGqRm7XmaU9PPHukwUA+1xHcT34R5QcVsuV1vsOu1JN9h8wUMpbpCGn8FON 6taw== X-Gm-Message-State: AOAM5309wnp+xaktHdmhab5xKk2fBLcOj/TxgLchZicWTvtoBoQs/qoR yttYViq+DK5PzQVzdIefbYE= X-Google-Smtp-Source: ABdhPJyVz8IZJotlz//B/XcGOAMtX7OgOSYLI2jgMf6+916FJhatZnoDPedqIGL8Nzi5owJDhWZ9hQ== X-Received: by 2002:a7b:c750:: with SMTP id w16mr991205wmk.184.1615833234973; Mon, 15 Mar 2021 11:33:54 -0700 (PDT) Date: Mon, 15 Mar 2021 18:33:52 +0000 From: Wei Liu To: Stefano Stabellini Cc: cardoe@cardoe.com, wl@xen.org, andrew.cooper3@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Subject: Re: [PATCH] automation: remove allow_failure from Alpine Linux jobs Message-ID: <20210315183352.mtcefvizfnfrxqy3@liuwe-devbox-debian-v2> References: <20210312210526.14862-1-sstabellini@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210312210526.14862-1-sstabellini@kernel.org> On Fri, Mar 12, 2021 at 01:05:26PM -0800, Stefano Stabellini wrote: > Now that the Alpine Linux build jobs complete successfully on staging we > can remove the "allow_failure: true" tag. > > Signed-off-by: Stefano Stabellini Acked-by: Wei Liu From xen-devel-bounces@lists.xenproject.org Mon Mar 15 20:01:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 20:01:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98110.185969 (Exim 4.92) (envelope-from ) id 1lLtOx-0006B4-Ca; Mon, 15 Mar 2021 20:01:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98110.185969; Mon, 15 Mar 2021 20:01:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLtOx-0006Ax-9g; Mon, 15 Mar 2021 20:01:19 +0000 Received: by outflank-mailman (input) for mailman id 98110; Mon, 15 Mar 2021 20:01:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLtOv-0006As-Iv for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 20:01:17 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6e58bf83-4a0b-4822-9ae9-07b4b82eb3b3; Mon, 15 Mar 2021 20:01:12 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4097F64E83; Mon, 15 Mar 2021 20:01:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e58bf83-4a0b-4822-9ae9-07b4b82eb3b3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615838471; bh=5zCDEeEQ4HUmsoTFLwNHrSDDax9OLrpOT79hlauQfuw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=hbG5T1H7SK/sE5DyN5A2RwZfcyyeiJTSOptybqszKc/s4djbdUXRRvNMzs8yyci4I Zn3rVn7cJkKuqHrumsq3ibWkCsd3maiyTrigc8lrRk00s1w+HZpqDptcevp2/Vj1ny oml3I/a/Sr2twXNGxYbia2C07eGs8CmMq9uyqyzuId3mfzhqGDiQH+6shYuahsznY+ JQm6Mx2nff2aCxZrVxcftwh97FMfVshpwFgXXLKBFUz+4g5StzlD2fQuC1k3pMEtyB YzTlE4IRL9PpBTTTBUEU/1vvBFPEBXqKC9BzmSc9d990YwQlWOOfogSVq79/oTo2Bb sqekb4mrjLcJA== Date: Mon, 15 Mar 2021 13:01:03 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich cc: Stefano Stabellini , andrew.cooper3@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3] xen: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped In-Reply-To: <0e35a613-fd93-0805-10b9-5ecee73bb15d@suse.com> Message-ID: References: <20210312231632.5666-1-sstabellini@kernel.org> <0e35a613-fd93-0805-10b9-5ecee73bb15d@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 15 Mar 2021, Jan Beulich wrote: > On 13.03.2021 00:16, Stefano Stabellini wrote: > > Introduce two feature flags to tell the domain whether it is > > direct-mapped or not. It allows the guest kernel to make informed > > decisions on things such as swiotlb-xen enablement. > > > > The introduction of both flags (XENFEAT_direct_mapped and > > XENFEAT_not_direct_mapped) allows the guest kernel to avoid any > > guesswork if one of the two is present, or fallback to the current > > checks if neither of them is present. > > > > XENFEAT_direct_mapped is always set for not auto-translated guests. > > > > For auto-translated guests, only Dom0 on ARM is direct-mapped. Also, > > see is_domain_direct_mapped() which refers to auto-translated guests: > > xen/include/asm-arm/domain.h:is_domain_direct_mapped > > xen/include/asm-x86/domain.h:is_domain_direct_mapped > > > > Signed-off-by: Stefano Stabellini > > CC: jbeulich@suse.com > > CC: andrew.cooper3@citrix.com > > CC: julien@xen.org > > Any particular reason my previously given R-b isn't here? Hi Jan, I reworded part of the comment in the public header, and I decided to err on the side of caution and not add your R-b given this change compared to the previous version. From xen-devel-bounces@lists.xenproject.org Mon Mar 15 20:05:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 20:05:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98113.185982 (Exim 4.92) (envelope-from ) id 1lLtSh-0006Ko-UM; Mon, 15 Mar 2021 20:05:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98113.185982; Mon, 15 Mar 2021 20:05:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLtSh-0006Kh-Qv; Mon, 15 Mar 2021 20:05:11 +0000 Received: by outflank-mailman (input) for mailman id 98113; Mon, 15 Mar 2021 20:05:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLtSg-0006Kc-TR for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 20:05:10 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cbb016f7-db19-4687-b512-49965c6f0784; Mon, 15 Mar 2021 20:05:10 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2E96B64E12; Mon, 15 Mar 2021 20:05:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbb016f7-db19-4687-b512-49965c6f0784 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615838709; bh=Bqm/F5tvXhB5iCbk4OleFCmg5XUVqpi1wQu7OB6ptOQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=LdwZ2bnNN40YcUqIIisIWTkEJ1cNlkLUV1gMKgBVhiVLYxDx6CtH5xxWskkHOvhg+ lpZFmA/NujOpT0OPav05BoollwcLZDIsU/PEMSUTpIDNeadBZFiWcighvDKNOUCoZO RdyyUu92nBLBqMxrNSOOswk78KWC77qTxjAcUGLZfEOuhjhgL58EZeaz//cwOM+NGU 5Vf+CWZeR95O2sfzTEd7Ni0aqoWR7FYiasrcFVXKRHhL1kksMHDCb3BewgHiAzxJAp Of+2O2g+BWo/x4pNPV+b3j/9QpT6u26WtRncoHHPL1z9xjVlHGkNDSaR3jMsqZKuCN ssdfdr6lY98WQ== Date: Mon, 15 Mar 2021 13:05:08 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= cc: Stefano Stabellini , xen-devel@lists.xenproject.org, committers@xenproject.org, Bertrand.Marquis@arm.com, cardoe@cardoe.com, fam@euphon.net Subject: Re: patchew - gitlab-ci notifications during the Xen 4.16 cycle In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-602485141-1615838709=:5325" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-602485141-1615838709=:5325 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sat, 13 Mar 2021, Roger Pau Monné wrote: > On Fri, Mar 12, 2021 at 12:55:38PM -0800, Stefano Stabellini wrote: > > Hi all, > > > > During the last 6 months we have been working on improving the Xen > > Project gitlab-ci and patchew infrastructure. > > > > You can see the results from gitlab-ci tests on the staging branch here: > > > > https://gitlab.com/xen-project/xen/-/pipelines > > https://gitlab.com/xen-project/xen/-/pipelines/269678673 > > > > In addition, and more interestingly, now we have patchew integration. > > Patchew picks up patch series sent to xen-devel by any contributor and > > commits them to branches under this repository: > > > > https://gitlab.com/xen-project/patchew/xen > > > > Then, gitlab-ci tests start automatically. Patchew waits for the results > > and send a notification email. You can see patchew pipelines here: > > > > https://gitlab.com/xen-project/patchew/xen/-/pipelines > > > > All this typically happens before patches are even reviewed. Today the > > patchew notification emails are only sent to us in the Gitlab-CI working > > group. But the good news is that we think the results got to the point > > where they are reliable enough that it would be good to share them with > > the community. > > I'm not opposed to that, but we seem to have some random git clone > failures during builds (at least on the x86 side), that are more > frequent that expected. At least recently I had trouble getting a full > gitlab CI pipeline run that didn't hit one of those. > > I will try to figure out what's going on by adding some more debug to > git to see if I can get more verbose information from git on exactly > what's failing. Yeah we brifly talked about those during the last gitlab-ci meeting. The current theory is that they might be an infrastructure issue and we ask Doug to have a look too. Your idea to add more debug info to git is excellent. --8323329-602485141-1615838709=:5325-- From xen-devel-bounces@lists.xenproject.org Mon Mar 15 20:19:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 20:19:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98115.185994 (Exim 4.92) (envelope-from ) id 1lLtgR-0007Oa-6B; Mon, 15 Mar 2021 20:19:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98115.185994; Mon, 15 Mar 2021 20:19:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLtgR-0007OT-38; Mon, 15 Mar 2021 20:19:23 +0000 Received: by outflank-mailman (input) for mailman id 98115; Mon, 15 Mar 2021 20:19:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLtgQ-0007OO-9O for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 20:19:22 +0000 Received: from MTA-06-4.privateemail.com (unknown [198.54.122.56]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dd3ac662-a94f-449d-a895-c648d782c544; Mon, 15 Mar 2021 20:19:20 +0000 (UTC) Received: from MTA-06.privateemail.com (localhost [127.0.0.1]) by MTA-06.privateemail.com (Postfix) with ESMTP id 10675600CE for ; Mon, 15 Mar 2021 16:19:20 -0400 (EDT) Received: from mail-wm1-f50.google.com (unknown [10.20.151.235]) by MTA-06.privateemail.com (Postfix) with ESMTPA id C9F32600CB for ; Mon, 15 Mar 2021 16:19:19 -0400 (EDT) Received: by mail-wm1-f50.google.com with SMTP id c76-20020a1c9a4f0000b029010c94499aedso154951wme.0 for ; Mon, 15 Mar 2021 13:19:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd3ac662-a94f-449d-a895-c648d782c544 X-Gm-Message-State: AOAM531IFcbBSQRydcia3tPQUq0xlCcJkpQY9t6KS3G34Uv7ChzelPkC Oumfx6r8KSl0oLzqE5Z9QBPWYkza7FKvjKvHU4A= X-Google-Smtp-Source: ABdhPJzfeDAUbvlSAqPIQ7lulTcyFszqHTdsiGgjVfL/qZp3U4oRHTAxz133zLb1JcQ8ICF1dlN1+BYQfrlkTqHduNU= X-Received: by 2002:a1c:5f54:: with SMTP id t81mr1356942wmb.84.1615839558425; Mon, 15 Mar 2021 13:19:18 -0700 (PDT) MIME-Version: 1.0 From: Tamas K Lengyel Date: Mon, 15 Mar 2021 16:18:42 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: 4.15.0-rc3 can't create domain when dom0 uses newer kernel To: Xen-devel Content-Type: multipart/alternative; boundary="000000000000e4e06105bd98f6f5" X-Virus-Scanned: ClamAV using ClamSMTP --000000000000e4e06105bd98f6f5 Content-Type: text/plain; charset="UTF-8" Hi all, I've ran into a pretty strange issue. I have a freshly installed 4.15.0-rc3 system and everything works fine with the stock Ubuntu 20.04 vmlinuz-5.4.0-66-generic as the dom0 kernel - except vmtrace, which needs a newer kernel, that's expected. Now if I boot dom0 with vmlinuz-5.8.0-44-generic or vmlinuz-5.10.0-1016-oem I can't start any domains because of some strange disk error: root@t2:/shared/cfg# xl create ubuntu-20.04.cfg Parsing config from ubuntu-20.04.cfg libxl: error: libxl_device.c:1109:device_backend_callback: Domain 1:unable to add device with path /local/domain/0/backend/vbd/1/51712 libxl: error: libxl_create.c:1613:domcreate_launch_dm: Domain 1:unable to add disk devices libxl: error: libxl_device.c:1109:device_backend_callback: Domain 1:unable to remove device with path /local/domain/0/backend/vbd/1/51712 libxl: error: libxl_domain.c:1529:devices_destroy_cb: Domain 1:libxl__devices_destroy failed libxl: error: libxl_domain.c:1182:libxl__destroy_domid: Domain 1:Non-existant domain libxl: error: libxl_domain.c:1136:domain_destroy_callback: Domain 1:Unable to destroy guest libxl: error: libxl_domain.c:1063:domain_destroy_cb: Domain 1:Destruction of domain failed This is the disk config: disk = ['phy:/dev/t2vg/ubuntu-20.04,xvda,w'] It's a standard LVM volume that is active, lvscan shows: ACTIVE '/dev/t2vg/ubuntu-20.04' [40.00 GiB] inherit I checked all the logs and I don't see anything relevant anywhere. If I reboot the system with the older kernel everything works as expected as far as creating the same domain with the same config. Anyone has any idea what might be going on here? Thanks, Tamas --000000000000e4e06105bd98f6f5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi all,
I've ran into a pretty strange = issue. I have a freshly installed 4.15.0-rc3 system and everything works fi= ne with the stock Ubuntu 20.04 vmlinuz-5.4.0-66-generic as the dom0 kernel = - except vmtrace, which needs a newer kernel, that's expected. Now if I= boot dom0 with vmlinuz-5.8.0-44-generic or vmlinuz-5.10.0-1016-oem I can&#= 39;t start any domains because of some strange disk error:

root@t2:/shared/cfg# xl create ubuntu-20.04.cfg
Parsing config = from ubuntu-20.04.cfg
libxl: error: libxl_device.c:1109:device_backend_c= allback: Domain 1:unable to add device with path /local/domain/0/backend/vb= d/1/51712
libxl: error: libxl_create.c:1613:domcreate_launch_dm: Domain = 1:unable to add disk devices
libxl: error: libxl_device.c:1109:device_ba= ckend_callback: Domain 1:unable to remove device with path /local/domain/0/= backend/vbd/1/51712
libxl: error: libxl_domain.c:1529:devices_destroy_cb= : Domain 1:libxl__devices_destroy failed
libxl: error: libxl_domain.c:11= 82:libxl__destroy_domid: Domain 1:Non-existant domain
libxl: error: libx= l_domain.c:1136:domain_destroy_callback: Domain 1:Unable to destroy guestlibxl: error: libxl_domain.c:1063:domain_destroy_cb: Domain 1:Destruction= of domain failed

This is the disk config:

disk =3D ['phy:/dev/t2vg/ubuntu-20.04,xvda,w']

It's a standard LVM volume that is active, lvsca= n shows:

=C2=A0 ACTIVE =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0'/dev/t2vg/ubuntu-20.04' [40.00 GiB] inherit

I checked all the logs and I don't see anything re= levant anywhere. If I reboot the system with the older kernel everything wo= rks as expected as far as creating the same domain with the same config.

Anyone has any idea what might be going on here?

Thanks,
Tamas
--000000000000e4e06105bd98f6f5-- From xen-devel-bounces@lists.xenproject.org Mon Mar 15 21:37:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 21:37:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98118.186006 (Exim 4.92) (envelope-from ) id 1lLutp-0005rx-57; Mon, 15 Mar 2021 21:37:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98118.186006; Mon, 15 Mar 2021 21:37:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLutp-0005rq-1U; Mon, 15 Mar 2021 21:37:17 +0000 Received: by outflank-mailman (input) for mailman id 98118; Mon, 15 Mar 2021 21:37:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLutn-0005rl-3G for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 21:37:15 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dfd5f154-03b1-452d-b936-92398b91df6e; Mon, 15 Mar 2021 21:37:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfd5f154-03b1-452d-b936-92398b91df6e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615844233; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=eRu/7QqXV1LPazAGA0S5MkY2tmMDhj80miVMAVapgUQ=; b=TbBGqj+TVEWY5HThlr7kP3dk5XbLLYOgJi7OsPDfVTyCY+dSnxbpeXKv BTxISv3YXWWwgZ6XQFyPU5CucktKD5d/yWIU5pE9sJr6LbrJKB+pU/uiY RSsm+cE597f103MUse9a+DRESI3uh8ZEnAb+liyXLDHbWr7aWGwkfC3DQ c=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 4Iw5HmhmtZ4ranGuf4ngl41MFDYwhLukpq4zOgvGFKd2mkkijhAOtdCveLJGLhGjQsXjs/t7ni tH9Vupxq+8+OuqSHVU0YXsXcWdL/t2o1omjDtP3Lujolo5kNAvPP0q/mKBDJD8ymkWTvNEOGn3 X9GLUUL43JLvBLAzOMZ1fsysEc0QrYgEhFa2JksSkyDnTmp71CAgPvvBbGBkUPFBbIpxLXeowY jt3s4fI0wIe5BDBdfUr6+2pWU9rd4oNZ8tQvMxDQkkz9I1JTEWUPEX20AkBB+/O9f+cmwszmye 1+k= X-SBRS: 5.2 X-MesageID: 39237852 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:YDnL4a6mShye/30FCwPXwTWEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoexzh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdxHW3tV2kZ 1te60WMrDNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2BXQotLhj0JbTqzOEtwWQVAGN4VFI CE4NBGujqnfh0sH76GL1MCWPXOoMCOqYL+bXc9dmUawSStrRft0r71FBCEwgwTOgkg/Z4O+X XI+jaJhJmLnOq8znbnpgruxrRQ3ODs095SQPGL4/JlVwnEriaNSMBfV6aZvDYzydvfmWoCtN XXuR8vM4BSxhrqDxiIiCDg0QXhzzoigkWKoTTz4QqB0L/EbQk3BMZbiYVSfgGx0TtZgPhG3L 9WxGXcjpJLDHr77VrAzuLVXBJnnFfcmwtFrccviRVkIO8jQY4Uh4ke8ERJKYwHDSL35as2ed Mec/301bJ4d0iXYGveuXQq6NuwXm4rFhPDeUQavNeJugIm1kxR/g89/ogyj30A/JUyR91t4P nFCL1hkPVrQtUNZaxwKe8dSaKMeyHwaCOJFFjXDUXsFakBNX6IgYXw+q8J6Oajf4FN5Icumb zaOWko+1IaSgbLM4mjzZdL+hfCTCGWRjL20PxT4JB/p/nVWKfrCyueU1oj+vHQ7Mk3M4n+Yb KeKZhWC/jsIS/FAoBSxTDzXJFUND0wS8sQltEnW0+fg87CJ4Hw39arMMr7Ff7IK3IJS2n/Cn wMUHzYP8Nb9H2mXXf+nVzwVhrWCw/C1KM1NJKf0/kYyYALOIEJmBMSk06F6saCLiAHlqQ3eU B5MY72i6/Tnxj1wU/4q0FSfjZNBEdc57vtF1lQoxURDk/yebEf//KSZH5Vx3nCAhNkVcvZHE p+qj1MiO6KBq3V4RpnJ8OsM2qcgXdWjmmNVY0glqqK4tqgXIg5AJYgUKlYDh7KCBRxpAZvpA 54GU45b36aMgmrpbSujZQSCu2aXcJ7mh2XLcldrm+aiV+Rvvg1RnwQXyenVOmehQpGfUsQun RBt4skxJaQkzemLmUyxMA1KkdFZmisDLVaNwidf4lPlrf3eAZ/cHeSiVWh+mEOU1uv039Xqn 3qLCWSd/2OOFZbt3xC+ovB8V9/dAymDgtNQ0E/lbc4OXXNu3513+POW7G61HGJbEAehssHNi veXDcUKgRy5ty+2RKPggyeHXE+yphGBJ2YMJ0TN5XonlWjJ42DmftYQ7t6/JN5OMvvteFOe+ SFYAORJC75DeRs+wH9nAdRBABE7F0f1dXv01nZyUL9+lgVK//bOk5nSLEWOMv01RmTe9+4lL FCyesotu6xOFjrYtGIyavrfydOQymj01KefqUNk9Ropqo8u7t4IonDXRbJ3H9B2g8iLM2crj JrfI1LpJTAMJRoZcocZmZw+Ucojs2GKCIQw0TLK957WVEmlHnAOdyVp5LOtLo0G0WE4C/9I0 OW/SEY3/DLWUK4pPUnIpN1BWRdc04n7nt+uMuEao3LEQ2vM9h5w2DSCA7LTJZtDI6fGbsRqR 5m49aH28+vHhCIpDz4jH9cOaJB82GuXMWoJhmDcNQ4tOCHBQ== X-IronPort-AV: E=Sophos;i="5.81,251,1610427600"; d="scan'208";a="39237852" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W7TZf3OM2nimhrvQh7fb6lQmBzezuyr3S16SRGxiIpINK454UIv/+TGJ0cJh1owAi4U+Fivvs1kc4vQi8JkGFr1uUxa6x2Y2NcyxfNggzlBPAjfzzni9JPKafFDYxswgHrnegiY292jDFTe0qTlg4cE7KQsf+5X4VfipWOO906L48BsjYKeuT3hPaFwW/S105HL27+Rqp8SfWvjnr5BjvWMptxi8H1MPA1Hd0dYS0F0Cv2eU1O5o3u+Gh2IsGoCaM5lAkrgxfNnSZg3NPaMhxtXoQH2QBhqeCbwTo/d7zCWMrcVuLxH24qUMcz+/vHDXxSFHHGVzYRi/Yl5YEWoq7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q7AyxiCcAH4B4EZ0LcKoBMEivcT6RAuzIBjQmcVou+M=; b=RfYVGWq3SwdesCcw1h0J1C7cWWIog0c3oOzay3fxkbQT6oYxt3WszUexHN55tBIMUxfpPcY9IeEh+GZdgR98SY+fxSIvtGzBGaEDUumw9jg6Ee3RCubwvRcQ7XR13kX3uLJgd/fsbM1GS7nc+Bz8jNuBlPC7T1dciuzV/35XMPPOqySMfTXckCRhstE+GPboFIlAlMpA13s3/Mz32BJ7IWs5a2hf/Mhc3UqFl2RxXlGj6Fq9AuqQdWGUy0AxQI8Kbb7LsG71TFdTVZdcnycitdrAOzzK+VVx2OM3qgIwG1YGen2dBHTecfQRgcea+nEivfa5Et2Eyw9DsO6yHuEtCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q7AyxiCcAH4B4EZ0LcKoBMEivcT6RAuzIBjQmcVou+M=; b=U60qghwzMX52KnqTODe/02y5mihivZBqjiFdUouQ3iP6mTvr7/Cep/YGWACA3k27+Ejf9sPxRLHG2wTb1riBcRJ3g81F94wWQsWr8lpfJ6aC1rDG4rhxL+As3oLqeLORWjagaVvm2ZInbPU0b6iFSqZjrlKAgf9iu+SlUG55rlU= Date: Mon, 15 Mar 2021 22:37:01 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Tamas K Lengyel CC: Xen-devel Subject: Re: 4.15.0-rc3 can't create domain when dom0 uses newer kernel Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MR2P264CA0026.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6415a71b-020c-48c4-e348-08d8e7fa7ba2 X-MS-TrafficTypeDiagnostic: DM5PR03MB2969: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: czTITJCy70sZrNWQJ0/TlebKbMbrh0qm067s7j0OMnSJgIAyDA8jEkFTPjkP8fom8JNmlWqUoBGDsiMhPpOGJ9xNBzYnpUV9oD7DJ383zrO85fCb/5fqLu3oFLn4D3fUNJT16dJzCPbRJ6ovx69mPLAXsBpfjBuxutpi5u8W7nEXyFtJVobofkv+UdKbv6VuJ0ZCXSdpOE/s6N1De87SxFIxNiFX56+yl9OjaNwZefG48nG4nw7Mtl4SE3DQPVWk0WU1rJ1fYL29AwK2Hk9PNtBzAc9PGQ3tBU1TU992HySTr2iQaJo8ltRIzUhrV4Yx/FGkAIh7L/yp4umqYRdTiOjpivdBR7ETN0tqgwvnKju0gYDbQ9oukeH/hT8CoRwtISJBRpfQjWfhZus4OW8QeMdf6qwJh19zeV3KqVAcco5va0zQh42CYgr6C+XqU404oYf1UGgnJNsacSu9trwdCk90ppVtf5ZSEFGvn4JGTmVfm6ZNqh78819hEEhZoHIui4cpCwAVTe/xiLrbIDcbNuFKypR3A73PFqCje1XYbKMHR2S/hEQd3WX1gNws9xMh X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(376002)(346002)(39860400002)(136003)(396003)(366004)(85182001)(6916009)(2906002)(956004)(4326008)(6496006)(8676002)(9686003)(4744005)(5660300002)(66476007)(8936002)(316002)(26005)(6666004)(6486002)(186003)(33716001)(66556008)(66946007)(478600001)(16526019)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?U3VDQU9zWG1ZVVRiaU1USHhtQW0vRnhiWEYvWEhlMENsZDg4UjRjcCsrdGU2?= =?utf-8?B?bzRwQ0hXTCtGeXJQWWl4Z0NycnRSQktHQ0ViU253UmxnZUdzazlVT1RGL0dN?= =?utf-8?B?Mys0ano3MURraHpCWncwTUdCaHJrYW94QUJRSVZOSUl3a3hpZHdkcUV4Sklp?= =?utf-8?B?bG5FdFJBWHpBTDVRQkk0SThEOW0weG1KbXE1VEFkeTh4OGJ0NFRWdFlHS0lY?= =?utf-8?B?ZUlxUWR0UHBLNmFTSVhzN1Z1Z0ZWdGN2a0tNOW8xbHV6MVBxUDdFUC9kbTRt?= =?utf-8?B?RUpnd3I5bUNjN1IwMjVNa1o2WGluWWpoY2w0Ky9rbnNOenorUnVCcGN3aEow?= =?utf-8?B?RjhUT3IxRlVoK0VZQUNmL0VpbCtiR3R1OTVUYzJLU0llNmZESE56OFFpTW1k?= =?utf-8?B?dXFjcXk5MjNyNU9UWnF2aTJKZjlpSkVpZ2VqMVlrRG5nQWNGK0tzelI4U3po?= =?utf-8?B?aDNVREFYS0cvbjJDZWxORFcybkRKME8veUxuMlE3SnJNZlcxeEtBUElub1pI?= =?utf-8?B?RnJmUXFFTU56TkpxcG1Xcmk4Zko2QVFxSVZrNGJlUGcvRzJGelA1VkR6UTUw?= =?utf-8?B?bDVyOUYwNGMzTjFmN2pyTlkra1JwTzRXQnFDUXRaRUZBV2UrWW9pL1R3ZC9D?= =?utf-8?B?ZnM3NDNYb3IzR2EvdWp6Y3krSzhnNXB5SG1wT25aWVhLemJqWlloKzlCTDAz?= =?utf-8?B?T3M0anFIejExRHY0Zm8rMUpzdnZuVmZWWExQQVpCeHZ4MjdRaUdWTkVsa1Ns?= =?utf-8?B?cmw3enVSb3lzQWZzWFA3bE1lU1hlWU9NS0YrUGcxQklycm1tTmdaTzBkclpu?= =?utf-8?B?NVdPb3lJSngzUzBqSWJwekdMTmEvOTRXVnZXNDJpYTZkZ0srTWZZMG4wSnZz?= =?utf-8?B?WDNQRi9VL1plWGdHYWR5RlEwd1JpMEc3QVJFcWpsaXFRVTc3VXlmbWxUdHgv?= =?utf-8?B?MFFEWWxHbU1qUThod2pEUGlGd2hldjVhaUtUOS9CeU90cHA3L01iUHlGT002?= =?utf-8?B?cFEwNWVuL011QTBNSEtmUXpaWlJLbjhEanBuSlJ1ZmdFNGphTFhBdFBwYnYy?= =?utf-8?B?cEJBbWp2bGNrUC84RHpZN3gzTWcvTnVNWG1mVDlaenZoZytsR2ZNdFlVWjNr?= =?utf-8?B?R3M3NHhpa0xNSmNNTXVURkFQM05wZEFvTXFqdnY4VjdHSnlRMXZObjkwKzA3?= =?utf-8?B?RXh0eUhDdno4U2htWHh4MXpkTFc5TTFPMHRaTkxrZHduZU9RbjBmeDFTMUxk?= =?utf-8?B?SG1YbkF6VS9hS0JmajlwYVFQNlFPMmFHVCtJQ3ZuQ29BKy93T09XZVlPdnAx?= =?utf-8?B?dkNON3ZvVEFXSVVSbktFd29YQXFINkRSSGhuZllSdHlvOG50U0JUYlJnU3dz?= =?utf-8?B?ZC9haFpkakNMa2lWMFkzREhsV2REcnhXOTh5SkJLZzd2Y2dGOWJNS1dpdTJP?= =?utf-8?B?YUZkY0MzZXcvMzY4MDJ4K3d0NE5TVGE5NTBibXRvV051bFdlblkzNWRSck9y?= =?utf-8?B?R3YveEZ5ME8yL3RxRXFUOVRJczlwLzdLc2JGYTlnTnVZWXFGbXk2THk2RS9w?= =?utf-8?B?bUJCWWZabVRoaXRTS0FKeTY5eEhIeU9oK1JmeW51ZUp3R2RFUUE2bWpjSzk1?= =?utf-8?B?REErRnNaWmdlNUZCamh5elZiOWRrcS9nbWdxN1BwaCtRK21FUmtWUS9CK21H?= =?utf-8?B?VXhVWVNGK3UxUG1JNkgvQXRPYnowNFFJMFg4b2tmQjg1b2trTTYyMm9iQWw1?= =?utf-8?Q?k+F3iMs+2VJDckWZ72F2Aelz9VDtk/x0n3Tsgl9?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6415a71b-020c-48c4-e348-08d8e7fa7ba2 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2021 21:37:07.6551 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PSljr7yA/wrYKKCkQHbPvZ+CvdrXtTwr1b1dcYLGTgyGqyZExDwU0qJ6tvZPp8ruTbbigv8X+4xsVPb149H0Ag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2969 X-OriginatorOrg: citrix.com On Mon, Mar 15, 2021 at 04:18:42PM -0400, Tamas K Lengyel wrote: > Hi all, > I've ran into a pretty strange issue. I have a freshly installed 4.15.0-rc3 > system and everything works fine with the stock Ubuntu 20.04 > vmlinuz-5.4.0-66-generic as the dom0 kernel - except vmtrace, which needs a > newer kernel, that's expected. Now if I boot dom0 with > vmlinuz-5.8.0-44-generic or vmlinuz-5.10.0-1016-oem I can't start any > domains because of some strange disk error: > > root@t2:/shared/cfg# xl create ubuntu-20.04.cfg > Parsing config from ubuntu-20.04.cfg > libxl: error: libxl_device.c:1109:device_backend_callback: Domain 1:unable > to add device with path /local/domain/0/backend/vbd/1/51712 > libxl: error: libxl_create.c:1613:domcreate_launch_dm: Domain 1:unable to > add disk devices Can you paste the output with `xl -vvv create ...`? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 15 21:49:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 21:49:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98123.186018 (Exim 4.92) (envelope-from ) id 1lLv5S-0006uE-CB; Mon, 15 Mar 2021 21:49:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98123.186018; Mon, 15 Mar 2021 21:49:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLv5S-0006u7-8y; Mon, 15 Mar 2021 21:49:18 +0000 Received: by outflank-mailman (input) for mailman id 98123; Mon, 15 Mar 2021 21:49:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLv5R-0006tz-Di; Mon, 15 Mar 2021 21:49:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLv5R-0001QB-5u; Mon, 15 Mar 2021 21:49:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLv5Q-0000VD-Qs; Mon, 15 Mar 2021 21:49:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLv5Q-0003W4-QO; Mon, 15 Mar 2021 21:49:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vTBLYIEpPj9h9CfVdG4HGDyu7/ddMbFk5K3z4hH60oI=; b=CTjenc1cJ6z1FZXLuSJbPLWzTg vzh/xU7MrkhJMgl84HbXcJMq7US4fHIfyfKsDEMCXxYTgyRa4W8R9/XKyV0fYtGKQ3PZP6alwHfh/ b76KdmjjKZ0hLxsEZ6PT82wN5vNbrb914qyc/tjYaNgg69CusXE3xdCsZzCr71ZyBst0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160088: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=6157b0e19721aadb4c7fdcfe57b2924af6144b14 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Mon, 15 Mar 2021 21:49:16 +0000 flight 160088 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160088/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 152631 build-arm64-xsm 6 xen-build fail REGR. vs. 152631 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 build-arm64 6 xen-build fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 6157b0e19721aadb4c7fdcfe57b2924af6144b14 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 207 days Failing since 152659 2020-08-21 14:07:39 Z 206 days 400 attempts Testing same since 160082 2021-03-15 01:37:25 Z 0 days 2 attempts ------------------------------------------------------------ 446 people touched revisions under test, not listing them all jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm pass build-amd64 pass build-arm64 fail build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt blocked build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 128713 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 15 22:46:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 22:46:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98130.186033 (Exim 4.92) (envelope-from ) id 1lLvyw-0003gF-LJ; Mon, 15 Mar 2021 22:46:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98130.186033; Mon, 15 Mar 2021 22:46:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLvyw-0003g8-I3; Mon, 15 Mar 2021 22:46:38 +0000 Received: by outflank-mailman (input) for mailman id 98130; Mon, 15 Mar 2021 22:46:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLvyv-0003g3-8O for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 22:46:37 +0000 Received: from MTA-13-3.privateemail.com (unknown [198.54.118.204]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8d779b31-dfd1-4be5-8cdf-2f312d3965c9; Mon, 15 Mar 2021 22:46:34 +0000 (UTC) Received: from mta-13.privateemail.com (localhost [127.0.0.1]) by mta-13.privateemail.com (Postfix) with ESMTP id 002F08006B for ; Mon, 15 Mar 2021 18:46:33 -0400 (EDT) Received: from mail-wm1-f53.google.com (unknown [10.20.151.220]) by mta-13.privateemail.com (Postfix) with ESMTPA id 9340980060 for ; Mon, 15 Mar 2021 18:46:33 -0400 (EDT) Received: by mail-wm1-f53.google.com with SMTP id n11-20020a05600c4f8bb029010e5cf86347so3021859wmq.1 for ; Mon, 15 Mar 2021 15:46:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d779b31-dfd1-4be5-8cdf-2f312d3965c9 X-Gm-Message-State: AOAM530Klh5HMIlMAZDNpi0G55H+bInrrOeicl2B1wOkBm84sTBLdJPs Cx5gvrKzC4IAzfH5Q4sYhC3tdunDOEMIMmaGUvo= X-Google-Smtp-Source: ABdhPJxlLshNbPYrb7r+qCcYWCPfB52pQbhA1SNRFYaLghJowa+eagbEWkDcTS5YiAcgCc1hYKRm89bsvAkW29UMnuw= X-Received: by 2002:a7b:c214:: with SMTP id x20mr1748364wmi.186.1615848392236; Mon, 15 Mar 2021 15:46:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tamas K Lengyel Date: Mon, 15 Mar 2021 18:45:55 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: 4.15.0-rc3 can't create domain when dom0 uses newer kernel To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: Xen-devel Content-Type: multipart/alternative; boundary="0000000000006e232905bd9b056e" X-Virus-Scanned: ClamAV using ClamSMTP --0000000000006e232905bd9b056e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 15, 2021 at 5:37 PM Roger Pau Monn=C3=A9 wrote: > > On Mon, Mar 15, 2021 at 04:18:42PM -0400, Tamas K Lengyel wrote: > > Hi all, > > I've ran into a pretty strange issue. I have a freshly installed 4.15.0-rc3 > > system and everything works fine with the stock Ubuntu 20.04 > > vmlinuz-5.4.0-66-generic as the dom0 kernel - except vmtrace, which needs a > > newer kernel, that's expected. Now if I boot dom0 with > > vmlinuz-5.8.0-44-generic or vmlinuz-5.10.0-1016-oem I can't start any > > domains because of some strange disk error: > > > > root@t2:/shared/cfg# xl create ubuntu-20.04.cfg > > Parsing config from ubuntu-20.04.cfg > > libxl: error: libxl_device.c:1109:device_backend_callback: Domain 1:unable > > to add device with path /local/domain/0/backend/vbd/1/51712 > > libxl: error: libxl_create.c:1613:domcreate_launch_dm: Domain 1:unable to > > add disk devices > > Can you paste the output with `xl -vvv create ...`? Here you go: Parsing config from ubuntu-20.04.cfg libxl: debug: libxl_create.c:2022:do_domain_create: ao 0x561348383da0: create: how=3D(nil) callback=3D(nil) poller=3D0x561348383e40 libxl: detail: libxl_create.c:627:libxl__domain_make: passthrough: disabled libxl: debug: libxl_device.c:379:libxl__device_disk_set_backend: Disk vdev=3Dxvda spec.backend=3Dunknown libxl: debug: libxl_device.c:413:libxl__device_disk_set_backend: Disk vdev=3Dxvda, using backend phy libxl: debug: libxl_create.c:1284:initiate_domain_create: Domain 5:running bootloader libxl: debug: libxl_bootloader.c:328:libxl__bootloader_run: Domain 5:not a PV/PVH domain, skipping bootloader libxl: debug: libxl_event.c:864:libxl__ev_xswatch_deregister: watch w=3D0x561348386270: deregister unregistered domainbuilder: detail: xc_dom_allocate: cmdline=3D"", features=3D"" domainbuilder: detail: xc_dom_kernel_file: filename=3D"/usr/local/lib/xen/boot/hvmloader" domainbuilder: detail: xc_dom_malloc_filemap : 621 kB libxl: debug: libxl_dom.c:822:libxl__load_hvm_firmware_module: Loading BIOS: /usr/local/lib/xen/boot/seabios.bin domainbuilder: detail: xc_dom_boot_xen_init: ver 4.15, caps xen-3.0-x86_64 xen-3.0-x86_32p hvm-3.0-x86_32 hvm-3.0-x86_32p hvm-3.0-x86_64 domainbuilder: detail: xc_dom_parse_image: called domainbuilder: detail: xc_dom_find_loader: trying multiboot-binary loader ... domainbuilder: detail: loader probe failed domainbuilder: detail: xc_dom_find_loader: trying HVM-generic loader ... domainbuilder: detail: loader probe OK xc: detail: ELF: phdr: paddr=3D0x100000 memsz=3D0x61e04 xc: detail: ELF: memory: 0x100000 -> 0x161e04 domainbuilder: detail: xc_dom_mem_init: mem 10008 MB, pages 0x271800 pages, 4k each domainbuilder: detail: xc_dom_mem_init: 0x271800 pages domainbuilder: detail: xc_dom_boot_mem_init: called domainbuilder: detail: range: start=3D0x0 end=3D0xf0000000 domainbuilder: detail: range: start=3D0x100000000 end=3D0x281800000 xc: detail: PHYSICAL MEMORY ALLOCATION: xc: detail: 4KB PAGES: 0x0000000000000200 xc: detail: 2MB PAGES: 0x000000000000038b xc: detail: 1GB PAGES: 0x0000000000000008 domainbuilder: detail: xc_dom_build_image: called domainbuilder: detail: xc_dom_pfn_to_ptr_retcount: domU mapping: pfn 0x100+0x62 at 0x7fc72dd94000 domainbuilder: detail: xc_dom_alloc_segment: kernel : 0x100000 -> 0x162000 (pfn 0x100 + 0x62 pages) xc: detail: ELF: phdr 0 at 0x7fc72dd32000 -> 0x7fc72dd8a260 domainbuilder: detail: xc_dom_pfn_to_ptr_retcount: domU mapping: pfn 0x162+0x40 at 0x7fc72dd54000 domainbuilder: detail: xc_dom_alloc_segment: System Firmware module : 0x162000 -> 0x1a2000 (pfn 0x162 + 0x40 pages) domainbuilder: detail: xc_dom_pfn_to_ptr_retcount: domU mapping: pfn 0x1a2+0x1 at 0x7fc72e336000 domainbuilder: detail: xc_dom_alloc_segment: HVM start info : 0x1a2000 -> 0x1a3000 (pfn 0x1a2 + 0x1 pages) domainbuilder: detail: xc_dom_build_image : virt_alloc_end : 0x1a3000 domainbuilder: detail: xc_dom_build_image : virt_pgtab_end : 0x0 domainbuilder: detail: xc_dom_boot_image: called domainbuilder: detail: xc_dom_compat_check: supported guest type: xen-3.0-x86_64 domainbuilder: detail: xc_dom_compat_check: supported guest type: xen-3.0-x86_32p domainbuilder: detail: xc_dom_compat_check: supported guest type: hvm-3.0-x86_32 <=3D matches domainbuilder: detail: xc_dom_compat_check: supported guest type: hvm-3.0-x86_32p domainbuilder: detail: xc_dom_compat_check: supported guest type: hvm-3.0-x86_64 domainbuilder: detail: domain builder memory footprint domainbuilder: detail: allocated domainbuilder: detail: malloc : 7008 bytes domainbuilder: detail: anon mmap : 0 bytes domainbuilder: detail: mapped domainbuilder: detail: file mmap : 621 kB domainbuilder: detail: domU mmap : 652 kB domainbuilder: detail: vcpu_hvm: called domainbuilder: detail: xc_dom_set_gnttab_entry: d5 gnt[0] -> d0 0xfefff domainbuilder: detail: xc_dom_set_gnttab_entry: d5 gnt[1] -> d0 0xfeffc domainbuilder: detail: xc_dom_release: called libxl: debug: libxl_device.c:379:libxl__device_disk_set_backend: Disk vdev=3Dxvda spec.backend=3Dphy libxl: debug: libxl_event.c:813:libxl__ev_xswatch_register: watch w=3D0x561348389260 wpath=3D/local/domain/0/backend/vbd/5/51712/state token= =3D3/0: register slotnum=3D3 libxl: debug: libxl_create.c:2060:do_domain_create: ao 0x561348383da0: inprogress: poller=3D0x561348383e40, flags=3Di libxl: debug: libxl_event.c:750:watchfd_callback: watch w=3D0x561348389260 wpath=3D/local/domain/0/backend/vbd/5/51712/state token=3D3/0: event epath=3D/local/domain/0/backend/vbd/>libxl: debug: libxl_event.c:1055:devstate_callback: backend /local/domain/0/backend/vbd/5/51712/state wanted state 2 still waiting state 1 libxl: debug: libxl_aoutils.c:88:xswait_timeout_callback: backend /local/domain/0/backend/vbd/5/51712/state (hoping for state change to 2): xswait timeout (path=3D/local/doma>libxl: debug: libxl_event.c:850:libxl__ev_xswatch_deregister: watch w=3D0x561348389260 wpath=3D/local/domain/0/backend/vbd/5/51712/state token=3D3/0: deregister slotnum=3D3 libxl: debug: libxl_event.c:1039:devstate_callback: backend /local/domain/0/backend/vbd/5/51712/state wanted state 2 timed out libxl: debug: libxl_event.c:864:libxl__ev_xswatch_deregister: watch w=3D0x561348389260: deregister unregistered libxl: debug: libxl_device.c:1096:device_backend_callback: Domain 5:calling device_backend_cleanup libxl: debug: libxl_event.c:864:libxl__ev_xswatch_deregister: watch w=3D0x561348389260: deregister unregistered libxl: error: libxl_device.c:1109:device_backend_callback: Domain 5:unable to add device with path /local/domain/0/backend/vbd/5/51712 libxl: debug: libxl_event.c:864:libxl__ev_xswatch_deregister: watch w=3D0x561348389360: deregister unregistered libxl: error: libxl_create.c:1613:domcreate_launch_dm: Domain 5:unable to add disk devices libxl: debug: libxl_event.c:864:libxl__ev_xswatch_deregister: watch w=3D0x561348387c28: deregister unregistered libxl: debug: libxl_event.c:813:libxl__ev_xswatch_register: watch w=3D0x561348388130 wpath=3D/local/domain/0/backend/vbd/5/51712/state token= =3D3/1: register slotnum=3D3 libxl: debug: libxl_event.c:750:watchfd_callback: watch w=3D0x561348388130 wpath=3D/local/domain/0/backend/vbd/5/51712/state token=3D3/1: event epath=3D/local/domain/0/backend/vbd/>libxl: debug: libxl_event.c:1055:devstate_callback: backend /local/domain/0/backend/vbd/5/51712/state wanted state 6 still waiting state 5 libxl: debug: libxl_aoutils.c:88:xswait_timeout_callback: backend /local/domain/0/backend/vbd/5/51712/state (hoping for state change to 6): xswait timeout (path=3D/local/doma>libxl: debug: libxl_event.c:850:libxl__ev_xswatch_deregister: watch w=3D0x561348388130 wpath=3D/local/domain/0/backend/vbd/5/51712/state token=3D3/1: deregister slotnum=3D3 libxl: debug: libxl_event.c:1039:devstate_callback: backend /local/domain/0/backend/vbd/5/51712/state wanted state 6 timed out libxl: debug: libxl_event.c:864:libxl__ev_xswatch_deregister: watch w=3D0x561348388130: deregister unregistered libxl: debug: libxl_device.c:1096:device_backend_callback: Domain 5:calling device_backend_cleanup libxl: debug: libxl_event.c:864:libxl__ev_xswatch_deregister: watch w=3D0x561348388130: deregister unregistered libxl: error: libxl_device.c:1109:device_backend_callback: Domain 5:unable to remove device with path /local/domain/0/backend/vbd/5/51712 libxl: debug: libxl_event.c:864:libxl__ev_xswatch_deregister: watch w=3D0x561348388230: deregister unregistered libxl: error: libxl_domain.c:1529:devices_destroy_cb: Domain 5:libxl__devices_destroy failed libxl: debug: libxl_domain.c:1596:devices_destroy_cb: Domain 5:Forked pid 944059 for destroy of domain libxl: debug: libxl_event.c:2066:libxl__ao_complete: ao 0x561348383da0: complete, rc=3D-3 libxl: debug: libxl_event.c:2035:libxl__ao__destroy: ao 0x561348383da0: destroy libxl: debug: libxl_domain.c:1045:libxl_domain_destroy: Domain 5:ao 0x561348382810: create: how=3D(nil) callback=3D(nil) poller=3D0x561348383e4= 0 libxl: error: libxl_domain.c:1182:libxl__destroy_domid: Domain 5:Non-existant domain libxl: error: libxl_domain.c:1136:domain_destroy_callback: Domain 5:Unable to destroy guest libxl: error: libxl_domain.c:1063:domain_destroy_cb: Domain 5:Destruction of domain failed libxl: debug: libxl_event.c:2066:libxl__ao_complete: ao 0x561348382810: complete, rc=3D-21 libxl: debug: libxl_domain.c:1054:libxl_domain_destroy: Domain 5:ao 0x561348382810: inprogress: poller=3D0x561348383e40, flags=3Dic libxl: debug: libxl_event.c:2035:libxl__ao__destroy: ao 0x561348382810: destroy xencall:buffer: debug: total allocations:603 total releases:603 xencall:buffer: debug: current allocations:0 maximum allocations:3 xencall:buffer: debug: cache current size:3 xencall:buffer: debug: cache hits:587 misses:3 toobig:13 xencall:buffer: debug: total allocations:0 total releases:0 xencall:buffer: debug: current allocations:0 maximum allocations:0 xencall:buffer: debug: cache current size:0 xencall:buffer: debug: cache hits:0 misses:0 toobig:0 Thanks, Tamas --0000000000006e232905bd9b056e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Mar 15, 2021 at 5:37 PM Roger Pau Monn=C3= =A9 <roger.pau@citrix.com>= ; wrote:
>
> On Mon, Mar 15, 2021 at 04:18:42PM -0400, Tamas K = Lengyel wrote:
> > Hi all,
> > I've ran into a pretty= strange issue. I have a freshly installed 4.15.0-rc3
> > system a= nd everything works fine with the stock Ubuntu 20.04
> > vmlinuz-5= .4.0-66-generic as the dom0 kernel - except vmtrace, which needs a
> = > newer kernel, that's expected. Now if I boot dom0 with
> >= ; vmlinuz-5.8.0-44-generic or vmlinuz-5.10.0-1016-oem I can't start any=
> > domains because of some strange disk error:
> >
&= gt; > root@t2:/shared/cfg# xl create ubuntu-20.04.cfg
> > Parsi= ng config from ubuntu-20.04.cfg
> > libxl: error: libxl_device.c:1= 109:device_backend_callback: Domain 1:unable
> > to add device wit= h path /local/domain/0/backend/vbd/1/51712
> > libxl: error: libxl= _create.c:1613:domcreate_launch_dm: Domain 1:unable to
> > add dis= k devices
>
> Can you paste the output with `xl -vvv create ...= `?

Here you go:

Parsing config = from ubuntu-20.04.cfg
libxl: debug: libxl_create.c:2022:do_domain_create= : ao 0x561348383da0: create: how=3D(nil) callback=3D(nil) poller=3D0x561348= 383e40
libxl: detail: libxl_create.c:627:libxl__domain_make: passthrough= : disabled
libxl: debug: libxl_device.c:379:libxl__device_disk_set_backe= nd: Disk vdev=3Dxvda spec.backend=3Dunknown
libxl: debug: libxl_device.c= :413:libxl__device_disk_set_backend: Disk vdev=3Dxvda, using backend phylibxl: debug: libxl_create.c:1284:initiate_domain_create: Domain 5:running= bootloader
libxl: debug: libxl_bootloader.c:328:libxl__bootloader_run: = Domain 5:not a PV/PVH domain, skipping bootloader
libxl: debug: libxl_ev= ent.c:864:libxl__ev_xswatch_deregister: watch w=3D0x561348386270: deregiste= r unregistered
domainbuilder: detail: xc_dom_allocate: cmdline=3D"&= quot;, features=3D""
domainbuilder: detail: xc_dom_kernel_file= : filename=3D"/usr/local/lib/xen/boot/hvmloader"
domainbuilder= : detail: xc_dom_malloc_filemap =C2=A0 =C2=A0: 621 kB
libxl: debug: libx= l_dom.c:822:libxl__load_hvm_firmware_module: Loading BIOS: /usr/local/lib/x= en/boot/seabios.bin
domainbuilder: detail: xc_dom_boot_xen_init: ver 4.1= 5, caps xen-3.0-x86_64 xen-3.0-x86_32p hvm-3.0-x86_32 hvm-3.0-x86_32p hvm-3= .0-x86_64
domainbuilder: detail: xc_dom_parse_image: called
domainbui= lder: detail: xc_dom_find_loader: trying multiboot-binary loader ...
dom= ainbuilder: detail: loader probe failed
domainbuilder: detail: xc_dom_fi= nd_loader: trying HVM-generic loader ...
domainbuilder: detail: loader p= robe OK
xc: detail: ELF: phdr: paddr=3D0x100000 memsz=3D0x61e04
xc: d= etail: ELF: memory: 0x100000 -> 0x161e04
domainbuilder: detail: xc_do= m_mem_init: mem 10008 MB, pages 0x271800 pages, 4k each
domainbuilder: d= etail: xc_dom_mem_init: 0x271800 pages
domainbuilder: detail: xc_dom_boo= t_mem_init: called
domainbuilder: detail: range: start=3D0x0 end=3D0xf00= 00000
domainbuilder: detail: range: start=3D0x100000000 end=3D0x28180000= 0
xc: detail: PHYSICAL MEMORY ALLOCATION:
xc: detail: =C2=A0 4KB PAGE= S: 0x0000000000000200
xc: detail: =C2=A0 2MB PAGES: 0x000000000000038bxc: detail: =C2=A0 1GB PAGES: 0x0000000000000008
domainbuilder:= detail: xc_dom_build_image: called
domainbuilder: detail: xc_dom_pfn_to= _ptr_retcount: domU mapping: pfn 0x100+0x62 at 0x7fc72dd94000
domainbuil= der: detail: xc_dom_alloc_segment: =C2=A0 kernel =C2=A0 =C2=A0 =C2=A0 : 0x1= 00000 -> 0x162000 =C2=A0(pfn 0x100 + 0x62 pages)
xc: detail: ELF: phd= r 0 at 0x7fc72dd32000 -> 0x7fc72dd8a260
domainbuilder: detail: xc_dom= _pfn_to_ptr_retcount: domU mapping: pfn 0x162+0x40 at 0x7fc72dd54000
dom= ainbuilder: detail: xc_dom_alloc_segment: =C2=A0 System Firmware module : 0= x162000 -> 0x1a2000 =C2=A0(pfn 0x162 + 0x40 pages)
domainbuilder: det= ail: xc_dom_pfn_to_ptr_retcount: domU mapping: pfn 0x1a2+0x1 at 0x7fc72e336= 000
domainbuilder: detail: xc_dom_alloc_segment: =C2=A0 HVM start info := 0x1a2000 -> 0x1a3000 =C2=A0(pfn 0x1a2 + 0x1 pages)
domainbuilder: de= tail: xc_dom_build_image =C2=A0: virt_alloc_end : 0x1a3000
domainbuilder= : detail: xc_dom_build_image =C2=A0: virt_pgtab_end : 0x0
domainbuilder:= detail: xc_dom_boot_image: called
domainbuilder: detail: xc_dom_compat_= check: supported guest type: xen-3.0-x86_64
domainbuilder: detail: xc_do= m_compat_check: supported guest type: xen-3.0-x86_32p
domainbuilder: det= ail: xc_dom_compat_check: supported guest type: hvm-3.0-x86_32 <=3D matc= hes
domainbuilder: detail: xc_dom_compat_check: supported guest type: hv= m-3.0-x86_32p
domainbuilder: detail: xc_dom_compat_check: supported gues= t type: hvm-3.0-x86_64
domainbuilder: detail: domain builder memory foot= print
domainbuilder: detail: =C2=A0 =C2=A0allocated
domainbuilder: de= tail: =C2=A0 =C2=A0 =C2=A0 malloc =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= : 7008 bytes
domainbuilder: detail: =C2=A0 =C2=A0 =C2=A0 anon mmap =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: 0 bytes
domainbuilder: detail: =C2=A0 = =C2=A0mapped
domainbuilder: detail: =C2=A0 =C2=A0 =C2=A0 file mmap =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: 621 kB
domainbuilder: detail: =C2=A0 = =C2=A0 =C2=A0 domU mmap =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: 652 kB
domai= nbuilder: detail: vcpu_hvm: called
domainbuilder: detail: xc_dom_set_gnt= tab_entry: d5 gnt[0] -> d0 0xfefff
domainbuilder: detail: xc_dom_set_= gnttab_entry: d5 gnt[1] -> d0 0xfeffc
domainbuilder: detail: xc_dom_r= elease: called
libxl: debug: libxl_device.c:379:libxl__device= _disk_set_backend: Disk vdev=3Dxvda spec.backend=3Dphy
libxl: debug: lib= xl_event.c:813:libxl__ev_xswatch_register: watch w=3D0x561348389260 wpath= =3D/local/domain/0/backend/vbd/5/51712/state token=3D3/0: register slotnum= =3D3
libxl: debug: libxl_create.c:2060:do_domain_create: ao 0x561348383d= a0: inprogress: poller=3D0x561348383e40, flags=3Di
libxl: debug: libxl_e= vent.c:750:watchfd_callback: watch w=3D0x561348389260 wpath=3D/local/domain= /0/backend/vbd/5/51712/state token=3D3/0: event epath=3D/local/domain/0/bac= kend/vbd/>libxl: debug: libxl_event.c:1055:devstate_callback: backend /l= ocal/domain/0/backend/vbd/5/51712/state wanted state 2 still waiting state = 1
libxl: debug: libxl_aoutils.c:88:xswait_timeout_callback: backend /loc= al/domain/0/backend/vbd/5/51712/state (hoping for state change to 2): xswai= t timeout (path=3D/local/doma>libxl: debug: libxl_event.c:850:libxl__ev_= xswatch_deregister: watch w=3D0x561348389260 wpath=3D/local/domain/0/backen= d/vbd/5/51712/state token=3D3/0: deregister slotnum=3D3
libxl: debug: li= bxl_event.c:1039:devstate_callback: backend /local/domain/0/backend/vbd/5/5= 1712/state wanted state 2 =C2=A0timed out
libxl: debug: libxl_event.c:86= 4:libxl__ev_xswatch_deregister: watch w=3D0x561348389260: deregister unregi= stered
libxl: debug: libxl_device.c:1096:device_backend_callback: Domain= 5:calling device_backend_cleanup
libxl: debug: libxl_event.c:864:libxl_= _ev_xswatch_deregister: watch w=3D0x561348389260: deregister unregisteredlibxl: error: libxl_device.c:1109:device_backend_callback: Domain 5:unabl= e to add device with path /local/domain/0/backend/vbd/5/51712
libxl: deb= ug: libxl_event.c:864:libxl__ev_xswatch_deregister: watch w=3D0x56134838936= 0: deregister unregistered
libxl: error: libxl_create.c:1613:domcreate_l= aunch_dm: Domain 5:unable to add disk devices
libxl: debug: libxl_event.= c:864:libxl__ev_xswatch_deregister: watch w=3D0x561348387c28: deregister un= registered
libxl: debug: libxl_event.c:813:libxl__ev_xswatch_register: w= atch w=3D0x561348388130 wpath=3D/local/domain/0/backend/vbd/5/51712/state t= oken=3D3/1: register slotnum=3D3
libxl: debug: libxl_event.c:750:watchfd= _callback: watch w=3D0x561348388130 wpath=3D/local/domain/0/backend/vbd/5/5= 1712/state token=3D3/1: event epath=3D/local/domain/0/backend/vbd/>libxl= : debug: libxl_event.c:1055:devstate_callback: backend /local/domain/0/back= end/vbd/5/51712/state wanted state 6 still waiting state 5
libxl: debug:= libxl_aoutils.c:88:xswait_timeout_callback: backend /local/domain/0/backen= d/vbd/5/51712/state (hoping for state change to 6): xswait timeout (path=3D= /local/doma>libxl: debug: libxl_event.c:850:libxl__ev_xswatch_deregister= : watch w=3D0x561348388130 wpath=3D/local/domain/0/backend/vbd/5/51712/stat= e token=3D3/1: deregister slotnum=3D3
libxl: debug: libxl_event.c:1039:d= evstate_callback: backend /local/domain/0/backend/vbd/5/51712/state wanted = state 6 =C2=A0timed out
libxl: debug: libxl_event.c:864:libxl__ev_xswatc= h_deregister: watch w=3D0x561348388130: deregister unregistered
libxl: d= ebug: libxl_device.c:1096:device_backend_callback: Domain 5:calling device_= backend_cleanup
libxl: debug: libxl_event.c:864:libxl__ev_xswatch_deregi= ster: watch w=3D0x561348388130: deregister unregistered
libxl: error: li= bxl_device.c:1109:device_backend_callback: Domain 5:unable to remove device= with path /local/domain/0/backend/vbd/5/51712
libxl: debug: libxl_event= .c:864:libxl__ev_xswatch_deregister: watch w=3D0x561348388230: deregister u= nregistered
libxl: error: libxl_domain.c:1529:devices_destroy_cb: Domain= 5:libxl__devices_destroy failed
libxl: debug: libxl_domain.c:1596:devic= es_destroy_cb: Domain 5:Forked pid 944059 for destroy of domain
libxl: d= ebug: libxl_event.c:2066:libxl__ao_complete: ao 0x561348383da0: complete, r= c=3D-3
libxl: debug: libxl_event.c:2035:libxl__ao__destroy: ao 0x5613483= 83da0: destroy
libxl: debug: libxl_domain.c:1045:libxl_domain_destroy: D= omain 5:ao 0x561348382810: create: how=3D(nil) callback=3D(nil) poller=3D0x= 561348383e40
libxl: error: libxl_domain.c:1182:libxl__destroy_domid: Dom= ain 5:Non-existant domain
libxl: error: libxl_domain.c:1136:domain_destr= oy_callback: Domain 5:Unable to destroy guest
libxl: error: libxl_domain= .c:1063:domain_destroy_cb: Domain 5:Destruction of domain failed
libxl: = debug: libxl_event.c:2066:libxl__ao_complete: ao 0x561348382810: complete, = rc=3D-21
libxl: debug: libxl_domain.c:1054:libxl_domain_destroy: Domain = 5:ao 0x561348382810: inprogress: poller=3D0x561348383e40, flags=3Dic
libxl: debug: libxl_event.c:2035:libxl__ao__destroy: ao 0x561348382= 810: destroy
xencall:buffer: debug: total allocations:603 total releases= :603
xencall:buffer: debug: current allocations:0 maximum allocations:3<= br>xencall:buffer: debug: cache current size:3
xencall:buffer: debug: ca= che hits:587 misses:3 toobig:13
xencall:buffer: debug: total allocations= :0 total releases:0
xencall:buffer: debug: current allocations:0 maximum= allocations:0
xencall:buffer: debug: cache current size:0
xencall:bu= ffer: debug: cache hits:0 misses:0 toobig:0

Thanks= ,
Tamas
--0000000000006e232905bd9b056e-- From xen-devel-bounces@lists.xenproject.org Mon Mar 15 23:26:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 15 Mar 2021 23:26:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98138.186045 (Exim 4.92) (envelope-from ) id 1lLwbV-0007Ca-V4; Mon, 15 Mar 2021 23:26:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98138.186045; Mon, 15 Mar 2021 23:26:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLwbV-0007CT-Rt; Mon, 15 Mar 2021 23:26:29 +0000 Received: by outflank-mailman (input) for mailman id 98138; Mon, 15 Mar 2021 23:26:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLwbT-0007CO-Mj for xen-devel@lists.xenproject.org; Mon, 15 Mar 2021 23:26:27 +0000 Received: from wout2-smtp.messagingengine.com (unknown [64.147.123.25]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8e9b8687-bbd8-4677-8e1b-98ef93d556c0; Mon, 15 Mar 2021 23:26:26 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 0C977C58; Mon, 15 Mar 2021 19:26:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 15 Mar 2021 19:26:25 -0400 Received: from mail-itl (ip5b434f04.dynamic.kabel-deutschland.de [91.67.79.4]) by mail.messagingengine.com (Postfix) with ESMTPA id 165391080054; Mon, 15 Mar 2021 19:26:23 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e9b8687-bbd8-4677-8e1b-98ef93d556c0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=RUP+Qy 0XCC6YGjs6J6SHjKXK1rHiGlhcFbVleO5Jl0A=; b=ITigs272jgCHaLf+/xpx7E 7B5ujs2GP8rlHcCTspH6C83KyaWTkk3JRXxCVT8tOTuCw6VihzAoTPmxDquuXzJa 31ojOmo0flAEAo1Xoa62N8+XnVtiIPElF/Dx7gy/PnMwr6/Ey0UzJXOizK2gURzg tFDLnTIeJRYoAOnp9JbVNqD+8vM6R91QGvn9FjSZ3rqLM26NdU1tergiYGf9gsYJ QSV8uK1K/soatjYIpTpg3EZoHMXyT0PyQ+G2GrtDw+4ggL3Tzyh6NLP5QXJPX52C Yq10kbx7pucKYlwpzbtUj4tpSuQbEK31DnIfKtYtgxnrIw+9kl5bYvfaG+dt3hrQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefuddgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehvedv ueevheekhefhvefggffgvedugeetuefgleeivdehgfeuieeugfetteeiffenucffohhmrg hinhepkhgvrhhnvghlrdhorhhgnecukfhppeeluddrieejrdejledrgeenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Date: Tue, 16 Mar 2021 00:26:19 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Tamas K Lengyel Cc: Xen-devel Subject: Re: 4.15.0-rc3 can't create domain when dom0 uses newer kernel Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ry965KNaZSipdULv" Content-Disposition: inline In-Reply-To: --ry965KNaZSipdULv Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 16 Mar 2021 00:26:19 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Tamas K Lengyel Cc: Xen-devel Subject: Re: 4.15.0-rc3 can't create domain when dom0 uses newer kernel On Mon, Mar 15, 2021 at 04:18:42PM -0400, Tamas K Lengyel wrote: > Hi all, > I've ran into a pretty strange issue. I have a freshly installed 4.15.0-r= c3 > system and everything works fine with the stock Ubuntu 20.04 > vmlinuz-5.4.0-66-generic as the dom0 kernel - except vmtrace, which needs= a > newer kernel, that's expected. Now if I boot dom0 with > vmlinuz-5.8.0-44-generic or vmlinuz-5.10.0-1016-oem I can't start any > domains because of some strange disk error: >=20 > root@t2:/shared/cfg# xl create ubuntu-20.04.cfg > Parsing config from ubuntu-20.04.cfg > libxl: error: libxl_device.c:1109:device_backend_callback: Domain 1:unable > to add device with path /local/domain/0/backend/vbd/1/51712 > libxl: error: libxl_create.c:1613:domcreate_launch_dm: Domain 1:unable to > add disk devices > libxl: error: libxl_device.c:1109:device_backend_callback: Domain 1:unable > to remove device with path /local/domain/0/backend/vbd/1/51712 > libxl: error: libxl_domain.c:1529:devices_destroy_cb: Domain > 1:libxl__devices_destroy failed > libxl: error: libxl_domain.c:1182:libxl__destroy_domid: Domain > 1:Non-existant domain > libxl: error: libxl_domain.c:1136:domain_destroy_callback: Domain 1:Unable > to destroy guest > libxl: error: libxl_domain.c:1063:domain_destroy_cb: Domain 1:Destruction > of domain failed >=20 > This is the disk config: >=20 > disk =3D ['phy:/dev/t2vg/ubuntu-20.04,xvda,w'] >=20 > It's a standard LVM volume that is active, lvscan shows: >=20 > ACTIVE '/dev/t2vg/ubuntu-20.04' [40.00 GiB] inherit >=20 > I checked all the logs and I don't see anything relevant anywhere. If I > reboot the system with the older kernel everything works as expected as f= ar > as creating the same domain with the same config. >=20 > Anyone has any idea what might be going on here? Make sure your kernel has this patch: https://lore.kernel.org/xen-devel/4c9af052a6e0f6485d1de43f2c38b1461996db99.= camel@infradead.org/ I'm not sure about the 5.8.x, but for 5.10 it is in >=3D 5.10.13. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --ry965KNaZSipdULv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmBP7RwACgkQ24/THMrX 1ywqtQf9FH0/EcdxkzqBPJ+WOfh47qwhBXEoOH9jOVQpJiNVtaeCgUTCnFYELs1P 0U3ZbFCZxG3MU27OCCy3K+WoZaT6PFY608NzUJLdhE2WOvWH2UU73CoHsIxg9w4F eDhvlvS2KZo1wUrGdSWkepm2fwIgH4MLByWdBd1cvfXQ1968EV2EXjsFvV4LFv09 TYFFbCJb6KK3CXP9WuNSzz5i14MlNVpCDPuIkITlJhkWrq0e5/ZAlVPF8TDb2vWf G/oiOy4IHGzGB8nDhJW0lV5U/pUeA7KscpgDdhf0pOmOY0jEIxpn8R8Rzg+hl27N 66zWOmeweug5Qnovef5AEnvY0mWZFQ== =DuYy -----END PGP SIGNATURE----- --ry965KNaZSipdULv-- From xen-devel-bounces@lists.xenproject.org Tue Mar 16 00:07:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 00:07:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98140.186057 (Exim 4.92) (envelope-from ) id 1lLxEk-0002vD-Rk; Tue, 16 Mar 2021 00:07:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98140.186057; Tue, 16 Mar 2021 00:07:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLxEk-0002v6-Nz; Tue, 16 Mar 2021 00:07:02 +0000 Received: by outflank-mailman (input) for mailman id 98140; Tue, 16 Mar 2021 00:07:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLxEj-0002v1-At for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 00:07:01 +0000 Received: from MTA-14-4.privateemail.com (unknown [198.54.118.206]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8479674d-2bc3-49d1-bba2-c2cc3beea485; Tue, 16 Mar 2021 00:07:00 +0000 (UTC) Received: from mta-14.privateemail.com (localhost [127.0.0.1]) by mta-14.privateemail.com (Postfix) with ESMTP id 70DF780069 for ; Mon, 15 Mar 2021 20:06:59 -0400 (EDT) Received: from mail-wm1-f47.google.com (unknown [10.20.151.201]) by mta-14.privateemail.com (Postfix) with ESMTPA id 3A02C80065 for ; Mon, 15 Mar 2021 20:06:59 -0400 (EDT) Received: by mail-wm1-f47.google.com with SMTP id d191so9104526wmd.2 for ; Mon, 15 Mar 2021 17:06:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8479674d-2bc3-49d1-bba2-c2cc3beea485 X-Gm-Message-State: AOAM532iuDgwOntq34Dmt12s0h0zOT2jIprrqBmk2Ht5bToHts3gpMGX GPpybneJYLfY+qj4Cq80ykf8WAN+ZauTTpU1Vms= X-Google-Smtp-Source: ABdhPJyKxQicTCyus8S9gdc8tagFA/qW0dDvhdEzBO1KHCrKttUT//X91NW4lLud1AOHQBE9l+1ZDkVRVwIqbJG3nMo= X-Received: by 2002:a7b:c214:: with SMTP id x20mr1953853wmi.186.1615853217975; Mon, 15 Mar 2021 17:06:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tamas K Lengyel Date: Mon, 15 Mar 2021 20:06:21 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: 4.15.0-rc3 can't create domain when dom0 uses newer kernel To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: Xen-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Mar 15, 2021 at 7:26 PM Marek Marczykowski-G=C3=B3recki wrote: > > On Mon, Mar 15, 2021 at 04:18:42PM -0400, Tamas K Lengyel wrote: > > Hi all, > > I've ran into a pretty strange issue. I have a freshly installed 4.15.0= -rc3 > > system and everything works fine with the stock Ubuntu 20.04 > > vmlinuz-5.4.0-66-generic as the dom0 kernel - except vmtrace, which nee= ds a > > newer kernel, that's expected. Now if I boot dom0 with > > vmlinuz-5.8.0-44-generic or vmlinuz-5.10.0-1016-oem I can't start any > > domains because of some strange disk error: > > > > root@t2:/shared/cfg# xl create ubuntu-20.04.cfg > > Parsing config from ubuntu-20.04.cfg > > libxl: error: libxl_device.c:1109:device_backend_callback: Domain 1:una= ble > > to add device with path /local/domain/0/backend/vbd/1/51712 > > libxl: error: libxl_create.c:1613:domcreate_launch_dm: Domain 1:unable = to > > add disk devices > > libxl: error: libxl_device.c:1109:device_backend_callback: Domain 1:una= ble > > to remove device with path /local/domain/0/backend/vbd/1/51712 > > libxl: error: libxl_domain.c:1529:devices_destroy_cb: Domain > > 1:libxl__devices_destroy failed > > libxl: error: libxl_domain.c:1182:libxl__destroy_domid: Domain > > 1:Non-existant domain > > libxl: error: libxl_domain.c:1136:domain_destroy_callback: Domain 1:Una= ble > > to destroy guest > > libxl: error: libxl_domain.c:1063:domain_destroy_cb: Domain 1:Destructi= on > > of domain failed > > > > This is the disk config: > > > > disk =3D ['phy:/dev/t2vg/ubuntu-20.04,xvda,w'] > > > > It's a standard LVM volume that is active, lvscan shows: > > > > ACTIVE '/dev/t2vg/ubuntu-20.04' [40.00 GiB] inherit > > > > I checked all the logs and I don't see anything relevant anywhere. If I > > reboot the system with the older kernel everything works as expected as= far > > as creating the same domain with the same config. > > > > Anyone has any idea what might be going on here? > > Make sure your kernel has this patch: > https://lore.kernel.org/xen-devel/4c9af052a6e0f6485d1de43f2c38b1461996db9= 9.camel@infradead.org/ > I'm not sure about the 5.8.x, but for 5.10 it is in >=3D 5.10.13. Thanks, after bumping the version to https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.11.6 it all works now. There should really be some better checks in the toolstack to verify that the underlying kernel will work or not and give the user an informative warning if not. The libxl errors are really not indicative at all for what the underlying issue really is. Tamas From xen-devel-bounces@lists.xenproject.org Tue Mar 16 01:27:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 01:27:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98145.186069 (Exim 4.92) (envelope-from ) id 1lLyUQ-0003PC-O3; Tue, 16 Mar 2021 01:27:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98145.186069; Tue, 16 Mar 2021 01:27:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLyUQ-0003P3-IC; Tue, 16 Mar 2021 01:27:18 +0000 Received: by outflank-mailman (input) for mailman id 98145; Tue, 16 Mar 2021 01:27:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLyUP-0003Ov-CB; Tue, 16 Mar 2021 01:27:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLyUP-00077S-65; Tue, 16 Mar 2021 01:27:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLyUO-0003Nv-O9; Tue, 16 Mar 2021 01:27:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lLyUO-0002n8-Nc; Tue, 16 Mar 2021 01:27:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1ovcLJK6ib4dLY0J/rBRhCzNiT3sArO3rt9+NlhBj1g=; b=COgOfFjWkpUdRrWNp57QRx3V4k qts/QLTDktDutCEWH5GN7NowqgmyheypSd+bhUqIE1tmClFtx+WsgpA810b/9PVEYD8rncVOr+78n Ns0lX19XXsUejFIjhtDT2iUd6sTR7wXkSHiEbY/MhpOYQgf3faT8YWe/4d2DLf+GuAyQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160089: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b4011741e6b39a8fd0ed5aded96c16c45ead5888 X-Osstest-Versions-That: xen=14b95b3b8546db201e7efd0636ae0e215fae98f3 From: osstest service owner Date: Tue, 16 Mar 2021 01:27:16 +0000 flight 160089 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160089/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160083 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160083 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160083 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160083 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160083 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160083 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160083 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160083 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160083 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160083 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160083 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen b4011741e6b39a8fd0ed5aded96c16c45ead5888 baseline version: xen 14b95b3b8546db201e7efd0636ae0e215fae98f3 Last test of basis 160083 2021-03-15 01:51:25 Z 0 days Testing same since 160089 2021-03-15 13:38:40 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 14b95b3b85..b4011741e6 b4011741e6b39a8fd0ed5aded96c16c45ead5888 -> master From xen-devel-bounces@lists.xenproject.org Tue Mar 16 01:37:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 01:37:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98154.186088 (Exim 4.92) (envelope-from ) id 1lLyeF-0004PV-QK; Tue, 16 Mar 2021 01:37:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98154.186088; Tue, 16 Mar 2021 01:37:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLyeF-0004PO-N0; Tue, 16 Mar 2021 01:37:27 +0000 Received: by outflank-mailman (input) for mailman id 98154; Tue, 16 Mar 2021 01:37:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLyeE-0004PJ-J2 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 01:37:26 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0d17a672-95cc-4126-a697-ef13d43e6462; Tue, 16 Mar 2021 01:37:25 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 8519464FB5; Tue, 16 Mar 2021 01:37:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d17a672-95cc-4126-a697-ef13d43e6462 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615858644; bh=PyLXwa2OaPTwqhfA+5C4VHoYQhFc/ZQMhm4+gbHceaQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=IXxwy1/Heqor0UQ7X1gJGuUg1dZZZE0yvPXa6IDaiI60gyl7qUMPmUleBLgPQonLW 0CPQdyqjNeEnWcJwEK96c/zd/eXoEXZ+QL6ZOfJRjrzDS16AhCp91mXnGOQeYKtUzo 3UWD0pOMhYIk+a+PwLjXpEkrd0eli2yEhiijRds07jviXhFKTyrDmWZ4MuUPouSeKO 0lu86Bf1ZVcYFb+n741E1oH4X/3dwyKximAYUsgYxl5aDr4pWPXxoyg4M9jQWKF3Kn H42qvVQb2ynQxOQwZl0qDNwtNjwtKWpzTly+cYUMZF+7QD/+j/qyGqhGdv8FcWiyak NzFjFfDBUxLTQ== Date: Mon, 15 Mar 2021 18:37:23 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, volodymyr_babchuk@epam.com, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [PATCH for-4.15 v2] xen: Bump the minimum version of GCC supported to 4.9 for arm32 and 5.1 on arm64 In-Reply-To: <20210313134158.24363-1-julien@xen.org> Message-ID: References: <20210313134158.24363-1-julien@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sat, 13 Mar 2021, Julien Grall wrote: > From: Julien Grall > > Compilers older than 4.8 have known codegen issues which can lead to > silent miscompilation: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 > > Furthermore, pre-4.9 GCC have known bugs (including things like > internal compiler errors on Arm) which would require workaround (I > haven't checked if we have any in Xen). > > The minimum version of GCC to build the hypervisor on arm is now > raised to 4.9. > > In addition to that, on arm64, GCC version >= 4.9 and < 5.1 have been > shown to emit memory references beyond the stack pointer, resulting in > memory corruption if an interrupt is taken after the stack pointer has > been adjusted but before the reference has been executed. > > Therefore, the minimum for arm64 is raised to 5.1. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > > This patch is candidate to 4.15 and backport. > > This is only a build change and will be low-risk for anyone using newer > compiler (5.1+ for arm64 and 4.9+ for arm32). Xen will stop building > for anyone using older compiler. But it is better than fighting > with codegen issues. > > Changes in v2: > - Only bump the GCC version for Arm. > --- > README | 7 +++++-- > xen/include/xen/compiler.h | 10 ++++++++++ > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/README b/README > index 8c99c30986c1..aa8b4fe126a8 100644 > --- a/README > +++ b/README > @@ -42,8 +42,11 @@ provided by your OS distributor: > - GNU Binutils 2.16.91.0.5 or later > or > - Clang/LLVM 3.5 or later > - - For ARM: > - - GCC 4.8 or later > + - For ARM 32-bit: > + - GCC 4.9 or later > + - GNU Binutils 2.24 or later > + - For ARM 64-bit: > + - GCC 5.1 or later > - GNU Binutils 2.24 or later > * Development install of zlib (e.g., zlib-dev) > * Development install of Python 2.6 or later (e.g., python-dev) > diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h > index 0ec0b4698ea7..17cf00e1ec92 100644 > --- a/xen/include/xen/compiler.h > +++ b/xen/include/xen/compiler.h > @@ -3,6 +3,16 @@ > > #if !defined(__GNUC__) || (__GNUC__ < 4) > #error Sorry, your compiler is too old/not recognized. > +#elif CONFIG_CC_IS_GCC > +# if defined(CONFIG_ARM_32) && CONFIG_GCC_VERSION < 40900 > +# error Sorry, your version of GCC is too old - please use 4.9 or newer. > +# elif defined(CONFIG_ARM_64) && CONFIG_GCC_VERSION < 50100 > +/* > + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 > + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk > + */ > +# error Sorry, your version of GCC is too old - please use 5.1 or newer. > +# endif > #endif > > #define barrier() __asm__ __volatile__("": : :"memory") > -- > 2.17.1 > From xen-devel-bounces@lists.xenproject.org Tue Mar 16 02:10:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 02:10:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98157.186100 (Exim 4.92) (envelope-from ) id 1lLzAU-0008Do-GR; Tue, 16 Mar 2021 02:10:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98157.186100; Tue, 16 Mar 2021 02:10:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLzAU-0008Dh-Bb; Tue, 16 Mar 2021 02:10:46 +0000 Received: by outflank-mailman (input) for mailman id 98157; Tue, 16 Mar 2021 02:10:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLzAS-0008Dc-A0 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 02:10:44 +0000 Received: from mail-40131.protonmail.ch (unknown [185.70.40.131]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 929c9aee-560f-4f95-bcca-c8d6daa3682c; Tue, 16 Mar 2021 02:10:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 929c9aee-560f-4f95-bcca-c8d6daa3682c Date: Tue, 16 Mar 2021 02:10:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1615860638; bh=PEA2EZR3ehKhgiPU96rVBV/d0DERSXYyqzf7IqaLKWQ=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=KwIXzDIbF6KFMBIuaetzPD4Xr1xMURLOTdGs8c5Ox4K6WxVlSGt7DCPPOjR6NDlae fJ1RmauHWVTBTfywvXa4NylWSQ3KYGSQpwFzraTeC0zuEBaAj30p7xFaKTE/tjnA3j A+ZTh4zCwzP/iBoZeGm7WhXQHY3gS7tHDs/gwD/w= To: Jan Beulich From: Dylanger Daly Cc: Andrew Cooper , "xen-devel@lists.xenproject.org" , Dario Faggioli Reply-To: Dylanger Daly Subject: Re: Ryzen 4000 (Mobile) Softlocks/Micro-stutters Message-ID: In-Reply-To: <1fc0e850-8a08-760f-c8cb-ad73dda4a37b@suse.com> References: <9lQU_gCfRzGyyNb2j86pxTMi1IET1Iq7iK3994agUZPrTI5Xd-aCJAaRYuJlD3L5LT2WaV4N3-YF4xKl5ukialT0M_YD0ve6gmDFFfatpXw=@protonmail.com> <2cc5da3e-0ad0-4647-f1ca-190788c2910b@citrix.com> <3pKjdPYCiRimYjqHQP0xd_vqhoTOJqthTXOrY_rLeNvnQEpIF24gXDKgRhmr95JfARJzbVJVbfTrrJeiovGVHGbV0QBSZ2jez2Y_wt6db7g=@protonmail.com> <768d9dbb-4387-099f-b489-7952d7e883b0@suse.com> <815f3bc3a28a165e8fa41c6954a6d00db656e3c3.camel@suse.com> <1fc0e850-8a08-760f-c8cb-ad73dda4a37b@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Hi Everyone, I just wanted to close this off and let everyone know the issue ended up be= ing a faulty/misconfigured HPET clock. Appending `clocksource=3Dtsc tsc=3Dunstable hpetbroadcast=3D0` to Xen's CMD= LINE totally fixed my issue, I assume Xen was detecting TSC may have been '= off' and was trying to recover/self-correct? In any case it's working perfectly. Cheers From xen-devel-bounces@lists.xenproject.org Tue Mar 16 02:23:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 02:23:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98160.186112 (Exim 4.92) (envelope-from ) id 1lLzN7-0000nQ-KC; Tue, 16 Mar 2021 02:23:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98160.186112; Tue, 16 Mar 2021 02:23:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLzN7-0000nJ-GR; Tue, 16 Mar 2021 02:23:49 +0000 Received: by outflank-mailman (input) for mailman id 98160; Tue, 16 Mar 2021 02:23:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLzN6-0000nE-7Y for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 02:23:48 +0000 Received: from mail-qv1-xf30.google.com (unknown [2607:f8b0:4864:20::f30]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 79ec000e-e70b-4659-a6dd-38ab9324d96d; Tue, 16 Mar 2021 02:23:47 +0000 (UTC) Received: by mail-qv1-xf30.google.com with SMTP id q9so3386029qvm.6 for ; Mon, 15 Mar 2021 19:23:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79ec000e-e70b-4659-a6dd-38ab9324d96d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zededa.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BKFVgcP8rDu3O4/q+NqywBi00Mw2quqcf5bwocfHgn4=; b=bAJ9ssX9l8UhL4z+BAlHgWhLJQP+YRE+/ZPyoaTXVSxj+0sAQDfXxRN/kQgiiQl+La 7Lm3XB0uETopun/2sPTIdTFB4RS9ENrCzb+eEYGT69PXviiIDliiiH5dAr7mpzqZbXbq HQQLohFjK4mR4vTWW/t9a88grzQFivht+Mn0qgA5LqRFmW3XoHmnHlJavWt10iW5QI0f z00BP17+uBALq0D8hBmfn8ZnL3yhnW2y+2Ot4cQJc2T0f6DpUy0cBA1FaNW5yimaLqZZ y5hDyUaApIHU5nadDKTJvYhkKZgG5mNUBNjcr2pamMnvp6i++qw66Yev1UOalhXDTk8A gwpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BKFVgcP8rDu3O4/q+NqywBi00Mw2quqcf5bwocfHgn4=; b=fHHiAm9gfUqqah39SbSOpAIfsIdrU83hymxt9Uh4VEzWgPswL4WFNJy6ocsLjUwUjB cnredYLWlg+aKW7y4SSRzbRUcLao45Dg4J9er3Hsb7H44Luw/rmO6j9RUD1fuT3RUli+ 3KfE1IrMmvrPD+ACEgw+t8y6iZdMX+423bUas9C3wvn9St2tA5sRdJM+OIzIPmYIuK4k hjmJsZ+TU3u42rPqK5GQI7qrc+ZUYFUyWUPaFQZOulkT2NtLE7o9aC9oXgOSitCTgHBh 6yFr2t6GPbRfQWdDxrmyqWIyslZJ17at6c6hQz/6DtEMMlElslCf+5Ez95p6T2OUkGOX 871A== X-Gm-Message-State: AOAM532fXeWzjb43PcxStGV2bjhyyy+rB33k96bHvhNrhut0xgbCdyoQ UYznOlYMD1LvMqeGnRRFP+gqsswdSl4rhMR4aKVDHQ== X-Google-Smtp-Source: ABdhPJwcyPMpViRIX54o00BN829wIMTqMBk9AFVbsx4LM5HthKHDPF43kGCobYZRUeTRcKS0gjb7c+C4q83ojT665Dw= X-Received: by 2002:a0c:f702:: with SMTP id w2mr27809826qvn.0.1615861427110; Mon, 15 Mar 2021 19:23:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Roman Shaposhnik Date: Mon, 15 Mar 2021 19:23:43 -0700 Message-ID: Subject: Re: Xen 4.14 build failing on aarch64 with GCC 10.2.1 To: Julien Grall Cc: Xen-devel , Stefano Stabellini , Stefano Stabellini Content-Type: text/plain; charset="UTF-8" On Wed, Mar 10, 2021 at 3:15 PM Julien Grall wrote: > > On Wed, 10 Mar 2021 at 21:15, Roman Shaposhnik wrote: > > > > Hi! > > Hi, > > > > > just came across this failure on aarch64: > > > > ld: prelink.o: in function `_spin_lock_cb': > > 19187(.text+0x1f26c): undefined reference to `__aarch64_ldadd4_acq_rel' > > 19188ld: prelink.o: in function `_spin_lock': > > 19189(.text+0x1f2ec): undefined reference to `__aarch64_ldadd4_acq_rel' > > 19190ld: prelink.o: in function `_spin_lock_irq': > > 19191(.text+0x1f35c): undefined reference to `__aarch64_ldadd4_acq_rel' > > 19192ld: prelink.o: in function `_spin_lock_irqsave': > > 19193(.text+0x1f3d4): undefined reference to `__aarch64_ldadd4_acq_rel' > > 19194ld: prelink.o: in function `_spin_lock_recursive': > > 19195(.text+0x1f6b0): undefined reference to `__aarch64_ldadd4_acq_rel' > > > > This, of course, goes away if I build Xen with: > > CFLAGS=-mno-outline-atomics > > > > However, at this point I'm curious if this is going to get addressed in Xen > > proper or not. > > This has already been fixed and backported to Xen 4.14 (included in > 4.14.1). Are you using the latest 4.14 branch? Aaaand that appears to works as intended -- sorry for the noise -- I thought I was using the latest, but apparently not. Thanks, Roman. From xen-devel-bounces@lists.xenproject.org Tue Mar 16 03:03:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 03:03:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98164.186123 (Exim 4.92) (envelope-from ) id 1lLzzJ-0004M1-KQ; Tue, 16 Mar 2021 03:03:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98164.186123; Tue, 16 Mar 2021 03:03:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLzzJ-0004Lu-HZ; Tue, 16 Mar 2021 03:03:17 +0000 Received: by outflank-mailman (input) for mailman id 98164; Tue, 16 Mar 2021 03:03:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lLzzH-0004Ln-Tl for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 03:03:16 +0000 Received: from mail1.protonmail.ch (unknown [185.70.40.18]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9fe11349-e078-40b5-8cc3-fefd06a08e1a; Tue, 16 Mar 2021 03:03:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fe11349-e078-40b5-8cc3-fefd06a08e1a Date: Tue, 16 Mar 2021 03:02:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1615863790; bh=1ozaoiLet6V8xjl3FNLvNaYIC5oh6jcsq22ig7I+GYc=; h=Date:To:From:Reply-To:Subject:From; b=LSIeRsZVzBUFgTrE/MXAls1J2HkEHwwkF9nREdfeSb8Rud6LIGcAFkeoGXXQpsM7U 1mlnulJ6ekpfplczqk5QeXgqfFa3FsHxv0r3NfPL/uSj0KotuX/R8XxZ+3Nz2rUvnV Ubq5E9ySzRKtEe1q3CKr7ISzZwrjm/+63Qy8cdUE= To: "xen-devel@lists.xenproject.org" From: Dylanger Daly Reply-To: Dylanger Daly Subject: AMD Ryzen 4000 (Mobile) cpufreq issues Message-ID: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_MchBWW3k7cKLYYrkfEGk1OM0ngEv8cXg5kxrsaP2FY" X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch This is a multi-part message in MIME format. --b1_MchBWW3k7cKLYYrkfEGk1OM0ngEv8cXg5kxrsaP2FY Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SGkgWGVuIERldmVsb3BlcnMsCgpJdCBhcHBlYXJzIEFNRCBSeXplbiA0MDAwIGJhc2VkIENQVXMg YXJlIG5vdCBzdXBwb3J0ZWQgYnkgYHhlbnBtYCwgcnVubmluZyBgeGVucG0gZ2V0LWNwdWZyZXEt c3RhdGVzYCByZXR1cm5zIG5vdGhpbmcgYW5kIGBnZXQtY3B1ZnJlcS1wYXJhYCByZXR1cm5zIGBm YWlsZWQgdG8gZ2V0IGNwdWZyZXEgcGFyYW1ldGVyYAoKVGhpcyB3YXMgc29tZXdoYXQgZXhwZWN0 ZWQgYXMgUnl6ZW4gNDAwMCBzZXJpZXMgQ1BVcyBhcmUgcXVpdGUgbmV3LCBzbyBhcyBhIHdvcmth cm91bmQgSSB0cmllZCBwdXR0aW5nIGBjcHVmcmVxPWRvbTAta2VybmVsIGRvbTBfbWF4X3ZjcHVz PTggZG9tMF92Y3B1c19waW5gIG9udG8gQ01ETElORSwgZnJvbSB3aGF0IEkndmUgcmVhZCB0aGlz IHNob3VsZCBlc3NlbnRpYWxseSBwYXNzIGNvbnRyb2wgZm9yIENQVSBmcmVxdWVuY3kgc2NhbGlu ZyBkb3duIHRvIGRvbTAncyBrZXJuZWwgKDUuMTEuNCkuCgpIb3dldmVyIGFjcGktY3B1ZnJlcSBk b2Vzbid0IGxvYWQsIHdoZW4gdHJ5aW5nIHRvIGluc21vZCBpdCBJIGdldCB0aGUgZm9sbG93aW5n IGVycm9yIGBpbnNtb2Q6IEVSUk9SOiBjb3VsZCBub3QgaW5zZXJ0IG1vZHVsZSBhY3BpLWNwdWZy ZXEua286IE5vIHN1Y2ggZGV2aWNlYAoKSSBjYW4ndCBzZWVtIHRvIHNlZSBhbnl0aGluZyByZWxh dGVkIHRvIFhlbiByZWxpbnF1aXNoaW5nIGNvbnRyb2wgdG8gZG9tMCBpbiBYZW4ncyBjb25zb2xl LCBhbnkgaGVscCB3b3VsZCBiZSBhcHByZWNpYXRlZAoKQ2hlZXJz --b1_MchBWW3k7cKLYYrkfEGk1OM0ngEv8cXg5kxrsaP2FY Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGRpdj5IaSBYZW4gRGV2ZWxvcGVycyw8YnI+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj5JdCBh cHBlYXJzIEFNRCBSeXplbiA0MDAwIGJhc2VkIENQVXMgYXJlIG5vdCBzdXBwb3J0ZWQgYnkgYHhl bnBtYCwgcnVubmluZyBgeGVucG0gZ2V0LWNwdWZyZXEtc3RhdGVzYCByZXR1cm5zIG5vdGhpbmcg YW5kIGBnZXQtY3B1ZnJlcS1wYXJhYCByZXR1cm5zIGBmYWlsZWQgdG8gZ2V0IGNwdWZyZXEgcGFy YW1ldGVyYDxicj48L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2PlRoaXMgd2FzIHNvbWV3aGF0IGV4 cGVjdGVkIGFzIFJ5emVuIDQwMDAgc2VyaWVzIENQVXMgYXJlIHF1aXRlIG5ldywgc28gYXMgYSB3 b3JrYXJvdW5kIEkgdHJpZWQgcHV0dGluZyBgY3B1ZnJlcT1kb20wLWtlcm5lbCBkb20wX21heF92 Y3B1cz04IGRvbTBfdmNwdXNfcGluYCBvbnRvIENNRExJTkUsIGZyb20gd2hhdCBJJ3ZlIHJlYWQg dGhpcyBzaG91bGQgZXNzZW50aWFsbHkgcGFzcyBjb250cm9sIGZvciBDUFUgZnJlcXVlbmN5IHNj YWxpbmcgZG93biB0byBkb20wJ3Mga2VybmVsICg1LjExLjQpLjxicj48L2Rpdj48ZGl2Pjxicj48 L2Rpdj48ZGl2Pkhvd2V2ZXIgYWNwaS1jcHVmcmVxIGRvZXNuJ3QgbG9hZCwgd2hlbiB0cnlpbmcg dG8gaW5zbW9kIGl0IEkgZ2V0IHRoZSBmb2xsb3dpbmcgZXJyb3IgYGluc21vZDogRVJST1I6IGNv dWxkIG5vdCBpbnNlcnQgbW9kdWxlIGFjcGktY3B1ZnJlcS5rbzogTm8gc3VjaCBkZXZpY2VgPGJy PjwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+SSBjYW4ndCBzZWVtIHRvIHNlZSBhbnl0aGluZyBy ZWxhdGVkIHRvIFhlbiByZWxpbnF1aXNoaW5nIGNvbnRyb2wgdG8gZG9tMCBpbiBYZW4ncyBjb25z b2xlLCBhbnkgaGVscCB3b3VsZCBiZSBhcHByZWNpYXRlZDxicj48L2Rpdj48ZGl2Pjxicj48L2Rp dj48ZGl2PkNoZWVyczxicj48L2Rpdj4= --b1_MchBWW3k7cKLYYrkfEGk1OM0ngEv8cXg5kxrsaP2FY-- From xen-devel-bounces@lists.xenproject.org Tue Mar 16 03:11:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 03:11:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98168.186135 (Exim 4.92) (envelope-from ) id 1lM07M-0005In-GQ; Tue, 16 Mar 2021 03:11:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98168.186135; Tue, 16 Mar 2021 03:11:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM07M-0005Ig-DC; Tue, 16 Mar 2021 03:11:36 +0000 Received: by outflank-mailman (input) for mailman id 98168; Tue, 16 Mar 2021 03:11:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM07L-0005Ib-7W for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 03:11:35 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3973c1bc-fa6e-436a-9255-86840f9d0b18; Tue, 16 Mar 2021 03:11:34 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1615864281940780.4737021473826; Mon, 15 Mar 2021 20:11:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3973c1bc-fa6e-436a-9255-86840f9d0b18 ARC-Seal: i=1; a=rsa-sha256; t=1615864286; cv=none; d=zohomail.com; s=zohoarc; b=CLynJfaPKoeL0yAsBbuI6sDyc8bzTgo4uf5Us6uIQEWiDjsCtEoy1CIj03bZaX4wIwxrEN21OOyi5AQqxfw9BVqS89gXjEm0sOUBmRebVqydGroFUapAl4QoTmSv/1RZ4RFSnonU1FsRG3/62HnHkMXmr39urSxPpNlMaICJh8c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615864286; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=Q7wd0dGMDbaLZj8GpMrMXLp7yDYNO5sr0dYNSJcEYXk=; b=d2y/pTu5WSGc6SJ7HVJWBTD4J3QDTvD8HtFcbiuq6o7w7a7YObIgUKvky/FIIC+RXxCTxqJzFuaTPRUscwu00moWKlHgkc6TXSmhM3XP0da1zQ4SWBhYlWhVBRrzMdvVDRG1rOFY74x/RR3bhNG4AsjPs0TCdMQ6QfNj+7YmUko= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1615864286; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Message-ID:Subject:Date:MIME-Version:Content-Transfer-Encoding:Content-Type; bh=Q7wd0dGMDbaLZj8GpMrMXLp7yDYNO5sr0dYNSJcEYXk=; b=S3+lQBNSKLNGbgiDkMkkv8f9J8+W4+D6DrzR2+Nq808XdRRqBWXlOaYXLBMLRHcx a8bC03NdWDn7sClqftM73/8HpwUjdDpwsbWILRhilIFTX54yX0XJ2ci7qzdtv+mIDPy DuQ/lyun5+HUBFMJOAT91tnAzC7pCiKxt6iAklUs= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: christopher.w.clark@gmail.com, andrew.cooper3@citrix.com, stefano.stabellini@xilinx.com, jgrall@amazon.com, Julien.grall.oss@gmail.com, iwj@xenproject.org, wl@xen.org, george.dunlap@citrix.com, jbeulich@suse.com, persaur@gmail.com, Bertrand.Marquis@arm.com, roger.pau@citrix.com, luca.fancellu@arm.com, paul@xen.org, adam.schwalm@starlab.io Message-ID: <20210316031814.10311-1-dpsmith@apertussolutions.com> Subject: [PATCH 0/2] Introducing hyperlaunch capability design (formerly: DomB mode of dom0less) Date: Mon, 15 Mar 2021 23:18:12 -0400 X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Content-Type: text/plain; charset=utf8 We are submitting for inclusion in the Xen documentation: - the hyperlaunch design document, and - the hyperlaunch device tree design document to describe a new method for launching the Xen hypervisor. The hyperlaunch feature builds upon prior dom0less work and the DomB project to bring a flexible and security-minded means to launch a variety of VM configurations as part of the startup of Xen. Signed-off-by: Christopher Clark Signed-off by: Daniel P. Smith Daniel P. Smith (2): docs/designs/launch: hyperlaunch design document docs/designs/launch: hyperlaunch device tree .../designs/launch/hyperlaunch-devicetree.rst | 343 +++++++ docs/designs/launch/hyperlaunch.rst | 900 ++++++++++++++++++ 2 files changed, 1243 insertions(+) create mode 100644 docs/designs/launch/hyperlaunch-devicetree.rst create mode 100644 docs/designs/launch/hyperlaunch.rst --=20 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 16 03:12:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 03:12:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98171.186148 (Exim 4.92) (envelope-from ) id 1lM07n-0005OD-Qa; Tue, 16 Mar 2021 03:12:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98171.186148; Tue, 16 Mar 2021 03:12:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM07n-0005O5-Ll; Tue, 16 Mar 2021 03:12:03 +0000 Received: by outflank-mailman (input) for mailman id 98171; Tue, 16 Mar 2021 03:12:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM07l-0005Nv-VY for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 03:12:02 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d9995aef-5341-4efb-a38f-824150558daf; Tue, 16 Mar 2021 03:11:58 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1615864285140356.21387671266564; Mon, 15 Mar 2021 20:11:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9995aef-5341-4efb-a38f-824150558daf ARC-Seal: i=1; a=rsa-sha256; t=1615864287; cv=none; d=zohomail.com; s=zohoarc; b=h0adgPwZr6jIfjeB/prX7ewBtZpbD5B+TAPh9M9O1QYo9TDZMX1wRdtTuicS/xC+YgGdku73t/a61o9n6LAKsPvIS9ypqJtzqPdM1rgoxKkSEzvVxVkdB8XhsjQYOP9tC6pi541DqDq76e6phTAQZhx0FBp/UzPgXSKUBAQuR2Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615864287; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=U2BZdnvf1eec9AOLaRyCTOnUX0W1VdCEtpsL+QINqK4=; b=DRZZSzzkGfr/KCJkwRm1fi40GNomqZmDr8SNdcecCCkXic1ua9s+pY87CjEKzHLIABm/7qQq9jHWw+z9ltpFnfRpYMR9q31EOOg/YsHjNskB2iRpmG3wp/NmVAKTCUou9Roz3QDSgl6SyirM4qbph+m0VZWCmehveftWk0wz/Sc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1615864287; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=U2BZdnvf1eec9AOLaRyCTOnUX0W1VdCEtpsL+QINqK4=; b=fvmXq+duPBFV2bhrrfzKggFX8/XH71F3r51Q2gw3wJZNeuD0oePCQsi4WkvuPZET d+XmCME3INvvDvJXGG9Stvt0o9M7/F7gF0Kx9E+MQcyJiKxpC0I38C2yWiS5ZcrbfVQ ePS6s3YRawfmYYI71fZWKHMdroNcpjfbLxRij4VA= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: christopher.w.clark@gmail.com, andrew.cooper3@citrix.com, stefano.stabellini@xilinx.com, jgrall@amazon.com, Julien.grall.oss@gmail.com, iwj@xenproject.org, wl@xen.org, george.dunlap@citrix.com, jbeulich@suse.com, persaur@gmail.com, Bertrand.Marquis@arm.com, roger.pau@citrix.com, luca.fancellu@arm.com, paul@xen.org, adam.schwalm@starlab.io Subject: [PATCH 1/2] docs/designs/launch: hyperlaunch design document Date: Mon, 15 Mar 2021 23:18:13 -0400 Message-Id: <20210316031814.10311-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210316031814.10311-1-dpsmith@apertussolutions.com> References: <20210316031814.10311-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=Y Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Adds a design document for hyperlaunch, formerly DomB mode of dom0less. Signed-off-by: Christopher Clark Signed-off by: Daniel P. Smith Reviewed-by: Rich Persaud --- docs/designs/launch/hyperlaunch.rst | 900 ++++++++++++++++++++++++++++ 1 file changed, 900 insertions(+) create mode 100644 docs/designs/launch/hyperlaunch.rst diff --git a/docs/designs/launch/hyperlaunch.rst b/docs/designs/launch/hyperlaunch.rst new file mode 100644 index 0000000000..6450536b1a --- /dev/null +++ b/docs/designs/launch/hyperlaunch.rst @@ -0,0 +1,900 @@ +########################### +Hyperlaunch Design Document +########################### + + +.. sectnum:: :depth: 4 + +.. contents:: :depth: 3 + + +Introduction +============ + +This document describes the design and motivation for the funded development of +a new, flexible system for launching the Xen hypervisor and virtual machines +named: "hyperlaunch". + +The design enables seamless transition for existing systems that require a +dom0, and provides a new general capability to build and launch alternative +configurations of virtual machines, including support for static partitioning +and accelerated start of VMs during host boot, while adhering to the principles +of least privilege. It incorporates the existing dom0less functionality, +extended to fold in the new developments from the DomB project, with support +for both x86 and Arm platform architectures, building upon and replacing the +earlier 'late hardware domain' feature for disaggregation of dom0. + +Hyperlaunch is designed to be flexible and reusable across multiple use cases, +and our aim is to ensure that it is capable, widely exercised, comprehensively +tested, and well understood by the Xen community. + +Approach +======== + +Born out of improving support for Dynamic Root of Trust for Measurement (DRTM), +the DomB project is focused on restructuring the system launch of Xen. The +hyperlaunch design provides a security architecture that builds on the +principles of Least Privilege and Strong Isolation, achieving this through the +disaggregation of system functions. It enables this with the introduction of a +boot domain that works in conjunction with the hypervisor to provide the +ability to launch multiple domains as part of host boot while maintaining a +least privilege implementation. + +While the DomB project inception was and continues to be driven by a focus on +security through disaggregation, there are multiple use cases with a +non-security focus that require or benefit from the ability to launch multiple +domains at host boot. This was proven by the need that drove the implementation +of the dom0less capability in the Arm branch of Xen. + +Hyperlaunch is designed to be flexible and reusable across multiple use cases, +and our aim is to ensure that it is capable, widely exercised, comprehensively +tested, and provides a robust foundation for current and emerging system launch +requirements of the Xen community. + + +Objectives +---------- + +* In general strive to maintain compatibility with existing Xen behavior +* A default build of the hypervisor should be capable of booting both legacy-compatible and new styles of launch: + + * classic Xen boot: starting a single, privileged Dom0 + * classic Xen boot with late hardware domain: starting a Dom0 that transitions hardware access/control to another domain + * a dom0less boot: starting multiple domains without privilege assignment controls + * hyperlaunch: starting one or more VMs, with flexible configuration + +* Preferred that it be managed via KCONFIG options to govern inclusion of support for each style +* The selection between classic boot and hyperlaunch boot should be automatic + + * Preferred that it not require a kernel command line parameter for selection + +* It should not require modification to boot loaders +* It should provide a user friendly interface for its configuration and management +* It must provide a method for building systems that fallback to console access in the event of misconfiguration +* It should be able to boot an x86 Xen environment without the need for a Dom0 domain + + +Requirements and Design +======================= + +Hyperlaunch is defined as the ability of a hypervisor to construct and start +one or more virtual machines at system launch in a specific way. A hypervisor +can support one or both modes of configuration, Hyperlaunch Static and +Hyperlaunch Dynamic. The Hyperlaunch Static mode functions as a static +partitioning hypervisor ensuring only the virtual machines started at system +launch are running on the system. The Hyperlaunch Dynamic mode functions as a +dynamic hypervisor allowing for additional virtual machines to be started after +the initial virtual machines have started. The Xen hypervisor is capable of +both modes of configuration from the same binary and when paired with its XSM +flask, provides strong controls that enable fine grained system partitioning. + +Landscape +--------- + +This comparison table presents the distinctive capabilities of hyperlaunch with +reference to existing launch configurations currently available in Xen and +other hypervisors. + +:: + + +---------------+-----------+------------+-----------+-------------+---------------------+ + | **Xen Dom0** | **Linux** | **Late** | **Jail** | **Xen** | **Xen Hyperlaunch** | + | **(Classic)** | **KVM** | **HW Dom** | **house** | **dom0less**+---------+-----------+ + | | | | | | Static | Dynamic | + +===============+===========+============+===========+=============+=========+===========+ + | Hypervisor able to launch multiple VMs during host boot | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | | | | Y | Y | Y | Y | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | Hypervisor supports Static Partitioning | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | | | | Y | Y | Y | | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | Able to launch VMs dynamically after host boot | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | Y | Y | Y* | Y | Y* | | Y | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | Supports strong isolation between all VMs started at host boot | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | | | | Y | Y | Y | Y | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | Enables flexible sequencing of VM start during host boot | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | | | | | | Y | Y | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | Prevent all-powerful static root domain being launched at boot | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | | | | | Y* | Y | Y | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | Operates without a Highly-privileged management VM (eg. Dom0) | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | | | Y* | | Y* | Y | Y | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | Operates without a privileged toolstack VM (Control Domain) | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | | | | | Y* | Y | | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | Extensible VM configuration applied before launch of VMs at host boot | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | | | | | | Y | Y | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | Flexible granular assignment of permissions and functions to VMs | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | | | | | | Y | Y | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | Supports extensible VM measurement architecture for DRTM and attestation | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | | | | | | Y | Y | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | PCI passthrough configured at host boot | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + | | | | | | Y | Y | + +---------------+-----------+------------+-----------+-------------+---------+-----------+ + + + +Domain construction +------------------- + +An important aspect of the hyperlaunch architecture is that the hypervisor +performs domain construction for all the Initial Domains. ie. it builds each +domain that is described in the Launch Control Module. Please, see the +‘Hyperlaunch Device Tree’ design document, which describes the configuration +module that is provided to the hypervisor by the bootloader. + +The hypervisor determines how these domains are started as host boot completes: +in some systems the Boot Domain acts upon the extended boot configuration +supplied as part of launch, performing configuration tasks for preparing the +other domains for the hypervisor to commence running them. + +Common Boot Configurations +-------------------------- + +When looking across those that have expressed interest or discussed a need for +launching multiple domains at host boot, the hyperlaunch approach is to provide +the means to start nearly any combination of domains. Below is an enumerated +selection of common boot configurations for reference in the following section. + +Dynamic Launch with a Highly-Privileged Domain 0 +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +Hyperlaunch Classic: Dom0 + This configuration mimics the classic Xen start and domain construction + where a single domain is constructed with all privileges and functions for + managing hardware and running virtualization toolstack software. + +Hyperlaunch Classic: Extended Launch Dom0 + This configuration is where a Dom0 is started via a Boot Domain that runs + first. This is for cases where some preprocessing in a less privileged domain + is required before starting the all-privileged Domain 0. + +Hyperlaunch Classic: Basic Cloud + This configuration constructs a Dom0 that is started in parallel with some + number of workload domains. + +Hyperlaunch Classic: Cloud + This configuration builds a Dom0 and some number of workload domains, launched + via a Boot Domain that runs first. + + +Static Launch Configurations: without a Domain 0 or a Control Domain +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +Hyperlaunch Static: Basic + Simple static partitioning where all domains that can be run on this system are + built and started during host boot and where no domain is started with the + Control Domain permissions, thus making it not possible to create/start any + further new domains. + +Hyperlaunch Static: Standard + This is a variation of the “Hyperlaunch Static: Basic” static partitioning + configuration with the introduction of a Boot Domain. This configuration allows + for use of a Boot Domain to be able to parse and apply extended configuration + retrieved from the Device Tree to the Initial Domains before they are started. + +Hyperlaunch Static: Disaggregated + This is a variation of the “Hyperlaunch Static: Standard” configuration with + the introduction of a Boot Domain and an illustration that some functions can + be disaggregated to dedicated domains. + +Dynamic Launch of Disaggregated System Configurations +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +Hyperlaunch Dynamic: Hardware Domain + This configuration mimics the existing Xen feature late hardware domain with + the one difference being that the hardware domain is constructed by the + hypervisor at startup instead of later by Dom0. + +Hyperlaunch Dynamic: Flexible Disaggregation + This configuration is similar to the “Hyperlaunch Classic: Dom0” configuration + except that it includes starting a separate hardware domain during Xen startup. + It is also similar to “Hyperlaunch Dynamic: Hardware Domain” configuration, but + it launches via a Boot Domain that runs first. + +Hyperlaunch Dynamic: Full Disaggregation + In this configuration it is demonstrated how it is possible to start a fully + disaggregated system: the virtualization toolstack runs in a Control Domain, + separate from the domains responsible for managing hardware, XenStore, the Xen + Console and Crash functions, each launched via a Boot Domain. + + +Example Use Cases and Configurations +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +The following example use cases can be matched to configurations listed in the +previous section. + +Use case: Modern cloud hypervisor +""""""""""""""""""""""""""""""""" + +**Option:** Hyperlaunch Classic: Cloud + +This configuration will support strong isolation for virtual TPM domains and +measured launch in support of attestation to infrastructure management, while +allowing the use of existing Dom0 virtualization toolstack software. + +Use case: Edge device with security or safety requirements +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +**Option:** Hyperlaunch Static: Boot + +This configuration runs without requiring a highly-privileged Dom0, and enables +extended VM configuration to be applied to the Initial VMs prior to launching +them, optionally in a sequenced start. + +Use case: Client hypervisor +""""""""""""""""""""""""""" + +**Option:** Hyperlaunch Dynamic: Flexible Disaggregation + +**Option:** Hyperlaunch Dynamic: Full Disaggregation + +These configurations enable dynamic client workloads, strong isolation for the +domain running the virtualization toolstack software and each domain managing +hardware, with PCI passthrough performed during host boot and support for +measured launch. + +hyperlaunch Disaggregated Launch +-------------------------------- + +Existing in Xen today are two permissions, control domain and hardware domain, +and two functions, console domain and xenstore domain, that can be assigned to +a domain. A third implicit function also exists: the crash domain, intended to +assist with failure recovery during host boot.Traditionally these are all +assigned to Dom0 at start and can then be delegated to other domains created by +the toolstack in Dom0. With hyperlaunch it becomes possible to assign these +permissions and functions to any domain for which there is a definition +provided at startup. Additionally hyperlaunch promotes the crash domain +function to an explicit function and introduces the boot domain function. + +Supporting the booting of each of the above common boot configurations is +accomplished by considering the set of initial domains and the assignment of +Xen’s permissions and functions, including the ones introduced by hyperlaunch, +to these domains. A discussion of these will be covered later but for now they +are laid out in a table with a mapping to the common boot configurations. This +table is not intended to be an exhaustive list of configurations and does not +account for flask policy specified functions that are use case specific. + +In the table each number represents a separate domain being +constructed by the hyperlaunch construction path as Xen starts, and the +designator, ``{n}`` signifies that there may be “n” additional domains that may +be constructed that do not have any special role for a general Xen system. + +:: + + +-------------------+------------------+-----------------------------------+ + | Configuration | Permission | Function | + +===================+======+======+====+======+=======+=========+==========+ + | | None | Ctrl | HW | Boot | Crash | Console | Xenstore | + |-------------------+------+------+----+------+-------+---------+----------+ + | Classic: Dom0 | | 0 | 0 | | 0 | 0 | 0 | + +-------------------+------+------+----+------+-------+---------+----------+ + | Classic: Extended | | 1 | 1 | 0 | 1 | 1 | 1 | + | Launch Dom0 | | | | | | | | + +-------------------+------+------+----+------+-------+---------+----------+ + | Classic: | {n} | 0 | 0 | | 0 | 0 | 0 | + | Basic Cloud | | | | | | | | + +-------------------+------+------+----+------+-------+---------+----------+ + | Classic: Cloud | {n} | 1 | 1 | 0 | 1 | 1 | 1 | + +-------------------+------+------+----+------+-------+---------+----------+ + | Static: Basic | {n} | | 0 | | 0 | 0 | 0 | + +-------------------+------+------+----+------+-------+---------+----------+ + | Static: Standard | {n} | | 1 | 0 | 1 | 1 | 1 | + +-------------------+------+------+----+------+-------+---------+----------+ + | Static: | {n} | | 2 | 0 | 3 | 4 | 1 | + | Disaggregated | | | | | | | | + +-------------------+------+------+----+------+-------+---------+----------+ + | Dynamic: | | 0 | 1 | | 0 | 0 | 0 | + | Hardware Domain | | | | | | | | + +-------------------+------+------+----+------+-------+---------+----------+ + | Dynamic: Flexible | {n} | 1 | 2 | 0 | 1 | 1 | 1 | + | Disaggregation | | | | | | | | + +-------------------+------+------+----+------+-------+---------+----------+ + | Dynamic: Full | {n} | 2 | 3 | 0 | 4 | 5 | 1 | + | Disaggregation | | | | | | | | + +-------------------+------+------+----+------+-------+---------+----------+ + +Overview of hyperlaunch Flow +---------------------------- + +Before delving into hyperlaunch, a good basis to start with is an understanding +of the current process to create a domain. A way to view this process starts +with the core configuration which is the information the hypervisor requires to +make the call to `domain_create` followed by the extended configuration used by +the toolstack to provide a domain with any additional configuration +information. Until the extended configuration is completed, a domain has access +to no resources except its allocated vcpus and memory. The exception to this is +Dom0 which the hypervisor explicitly grants control and access to all system +resources except for those that only the hypervisor should have control over. +This exception for Dom0 is driven by the system structure with a monolithic +Dom0 domain predating introduction of support for disaggregation into Xen, and +the corresponding default assignment of multiple roles within the Xen system to +Dom0. + +While not a different domain creation path, there does exist the Hardware +Domain (hwdom), sometimes also referred to as late-Dom0. It is an early effort +to disaggregate Dom0’s roles into a separate control domain and hardware +domain. This capability is activated by the passing of a domain id to the +`hardware_dom` kernel command line parameter, and the Xen hypervisor will then +flag that domain id as the hardware domain. Later when the toolstack constructs +a domain with that domain id as the requested domid, the hypervisor will +transfer all device I/O from Dom0 to this domain. In addition it will also +transfer the “host shutdown on domain shutdown” flag from Dom0 to the hardware +domain. It is worth mentioning that this approach for disaggregation was +created in this manner due to the inability of Xen to launch more than one +domain at startup. + +hyperlaunch Xen startup +^^^^^^^^^^^^^^^^^^^^^^^ + +The hyperlaunch approach’s primary focus is on how to assign the roles +traditionally granted to Dom0 to one or more domains at host boot. While the +statement is simple to make, the implications are not trivial by any means. +This also explains why the hyperlaunch approach is orthogonal to the existing +dom0less capability. The dom0less capability focuses on enabling the launch of +multiple domains in parallel with Dom0 at host boot. A corollary for dom0less +is that for systems that don’t require Dom0 after all guest domains have +started, they are able to do the host boot without a Dom0. Though it should be +noted that it may be possible to start Dom0 at a later point. Whereas with +hyperlaunch, its approach of separating Dom0’s roles requires the ability to +launch multiple domains at host boot. The direct consequences from this +approach are profound and provide a myriad of possible configurations for which +a sample of common boot configurations were already presented. + +To enable the hyperlaunch approach a new alternative path for host boot within +the hypervisor must be introduced. This alternative path effectively branches +just before the current point of Dom0 construction and begins an alternate +means of system construction. The determination if this alternate path should +be taken is through the inspection of the boot chain. If the bootloader has +loaded a specific configuration, as described later, it will enable Xen to +detect that a hyperlaunch configuration has been provided. Once a hyperlaunch +configuration is detected, this alternate path can be thought of as occurring +in phases: domain creation, domain preparation, and launch finalization. + +Domain Creation +""""""""""""""" + +The domain creation phase begins with Xen parsing the bootloader provided +material, to understand the content of the modules provided. It will then load +any microcode or XSM policy it discovers. For each domain configuration Xen +finds, it parses the configuration to construct the necessary domain definition +to instantiate an instance of the domain and leave it in a paused state. When +all domain configurations have been instantiated as domains, if one of them is +flagged as the Boot Domain, that domain will be unpaused starting the domain +preparation phase. If there is no Boot Domain defined, then the domain +preparation phase will be skipped and Xen will trigger the launch finalization +phase. + +Domain Preparation Phase +"""""""""""""""""""""""" + +The domain preparation phase is an optional check point for the execution of a +workload specific domain, the Boot Domain. While the Boot Domain is the first +domain to run and has some degree of control over the system, it is extremely +restricted in both system resource access and hypervisor operations. Its +purpose is to: + +* Access the configuration provided by the bootloader +* Finalize the configuration of the domains +* Conduct any setup and launch related operations +* Do an ordered unpause of domains that require an ordered start + +When the Boot Domain has completed, it will notify the hypervisor that it is +done triggering the launch finalization phase. + + +Launch Finalization +""""""""""""""""""" + +The hypervisor handles the launch finalization phase which is equivalent to the +clean up phase. As such the steps taken by the hypervisor, not necessarily in +implementation order, are as follows, + +* Free the boot module chain +* If a Boot Domain was used, reclaim Boot Domain resources +* Unpause any domains still in a paused state +* Boot Domain uses a reserved function thus can never be respawned + +While the focus thus far has been on how the hyperlaunch capability will work, +it is worth mentioning what it does not do or limit from occurring. It does not +stop or inhibit the assigning of the control domain role which gives the domain +the ability to create, start, stop, restart, and destroy domains or the +hardware domain role which gives access to all I/O devices except those that +the hypervisor has reserved for itself. In particular it is still possible to +construct a domain with all the privileged roles, i.e. a Dom0, with or without +the domain id being zero. In fact what limitations are imposed now become fully +configurable without the risk of circumvention by an all privileged domain. + +Structuring of Hyperlaunch +-------------------------- + +The structure of hyperlaunch is built around the existing capabilities of the +host boot protocol. This approach was driven by the objective not to require +modifications to the boot loader. As a result, on x86 the hyperlaunch +capability does not rely on nor preclude any specific BIOS boot protocol, i.e +legacy BIOS boot or UEFI boot. The only requirement is that the boot loader +supports the Multiboot2 (MB2) protocol. Similarly on Arm platforms, hyperlaunch +is compatible with the existing interface for boot into the hypervisor. + + +x86 Multiboot2 +^^^^^^^^^^^^^^ + +The MB2 protocol has no concept of a manifest to tell the initial kernel what +is contained in the chain, leaving it to the kernel to impose a loading +convention, use magic number identification, or both. When considering the +passing of multiple kernels, ramdisks, and domain configuration along with any +existing modules already passed, there is no sane convention that could be +imposed and magic number identification is nearly impossible when considering +the objective not to impose unnecessary complication to the hypervisor. + +As it was alluded to previously, a manifest describing the contents in the MB2 +chain and how they relate within a Xen context is needed. To address this need +the Launch Control Module (LCM) was designed to provide such a manifest. The +LCM was designed to have a specific set of properties, + +* minimize the complexity of the parsing logic required by the hypervisor +* allow for expanding and optional configuration fragments without breaking + backwards compatibility + +To enable automatic detection of a hyperlaunch configuration, the LCM must be +the first MB2 module in the MB2 module chain. The LCM is implemented using the +Device Tree as defined in the hyperlaunch Device Tree design document. With the +LCM implemented in Device Tree, it has a magic number that enables the +hypervisor to detect its presence when used in a Multiboot2 module chain. The +hypervisor can confirm that it is a proper LCM Device Tree by checking for a +compliant hyperlaunch Device Tree. The hyperlaunch Device Tree nodes are +designed to allow, + +* for the hypervisor to parse only those entries it understands, +* for packing custom information for a custom boot domain, +* the ability to use a new LCM with an older hypervisor, +* and the ability to use an older LCM with a new hypervisor. + +Arm Device Tree +^^^^^^^^^^^^^^^ + +As discussed the LCM is in Device Tree format and was designed to co-exist in +the Device Tree ecosystem, and in particular in parallel with dom0less Device +Tree entries. On Arm, Xen is already designed to boot from a host Device Tree +description (dtb) file and the LCM entries can be embedded into this host dtb +file. This makes detecting the LCM entries and supporting hyperlaunch on Arm +relatively straight forward. Relative to the described x86 approach, at the +point where Xen inspects the first MB2 module, on Arm Xen will check if the top +level LCM node exists in the host dtb file. If the LCM node does exist, then at +that point it will enter into the same code path as the x86 entry would go. + +Xen hypervisor +^^^^^^^^^^^^^^ + +It was previously discussed at a higher level of the new host boot flow that +will be introduced. Within this new flow is the configuration parsing and +domain creation phase which will be expanded upon here. The hypervisor will +inspect the LCM for a config node and if found will iterate through all modules +nodes. The module nodes are used to identify if any modules contain microcode +or an XSM policy. As it processes domain nodes, it will construct the domain +using the node properties and the modules nodes. Once it has completed +iterating through all the entries in the LCM, if a constructed domain has the +Boot Domain attribute, it will then be unpaused. Otherwise the hypervisor will +start the launch finalization phase. + +Boot Domain +^^^^^^^^^^^ + +Traditionally domain creation was controlled by the user within the Dom0 +environment whereby custom toolstacks could be implemented to impose +requirements on the process. The Boot Domain is a means to enable the user to +continue to maintain a degree of that control over domain creation but within a +limited privilege environment. The Boot Domain will have access to the LCM and +the boot chain along with access to a subset of the hypercall operations. When +the Boot Domain is finished it will notify the hypervisor through a hypercall +op. + +Crash Domain +^^^^^^^^^^^^ + +With the existing Dom0 host boot path, when a failure occurs there are several +assumptions that can safely be made to get the user to a console for +troubleshooting. With the hyperlaunch host boot path those assumptions can no +longer be made, thus a means is needed to get the user to a console in the case +of a recoverable failure. To handle this situation hyperlaunch formalizes the +concept of a crash domain. The crash domain is configured by a domain +configuration entry in the LCM and it will not be unpaused at launch +finalization unless a failure is encountered. + +Control Domain +^^^^^^^^^^^^^^ + +The concept of the Control Domain already exists within Xen as a boolean, +`is_privileged`, that governs access to many of the privileged interfaces of +the hypervisor that support a domain running a virtualization system toolstack. +Hyperlaunch will allow the `is_privileged` flag to be set on any domain that is +created at launch, rather than only a Dom0. It may potentially be set on +multiple domains. + +Hardware Domain +^^^^^^^^^^^^^^^ + +The Hardware Domain is also an existing concept for Xen that is enabled through +the `is_hardware_domain` check. With hyperlaunch the previous process of I/O +accesses being assigned to Dom0 for later transfer to the hardware domain would +no longer be required. Instead during the configuration phase the Xen +hypervisor would directly assign the I/O accesses to the domain with the +hardware domain permission bit enabled. + +Console Domain +^^^^^^^^^^^^^^ + +Traditionally the Xen console is assigned to the control domain and then +reassignable by the toolstack to another domain. With hyperlaunch it becomes +possible to construct a boot configuration where there is no control domain or +have a use case where the Xen console needs to be isolated. As such it becomes +necessary to be able to designate which of the initial domains should be +assigned the Xen console. Therefore hyperlaunch introduces the ability to +specify an initial domain which the console is assigned along with a convention +of ordered assignment for when there is no explicit assignment. + +------------------------------------------------------------------------------- + +Appendix +======== + +Appendix 1: Flow Sequence of Steps of a hyperlaunch Boot +-------------------------------------------------------- + +Provided here is an ordered flow of a hyperlaunch with a highlight logic +decision points. Not all branch points are recorded, specifically for the +variety of error conditions that may occur. :: + + 1. Hypervisor Startup: + 2a. (x86) Inspect first module provided by the bootloader + a. Is the module an LCM + i. YES: proceed with the hyperlaunch host boot path + ii. NO: proceed with a Dom0 host boot path + 2b. (Arm) Inspect host dtb for `/chosen/hypervisor` node + a. Is the LCM present + i. YES: proceed with the hyperlaunch host boot path + ii. NO: proceed with a Dom0/dom0less host boot path + 3. Iterate through the LCM entries looking for the module description + entry + a. Check if any of the modules are microcode or policy and if so, + load + 4. Iterate through the LCM entries processing all domain description + entries + a. Use the details from the Basic Configuration to call + `domain_create` + b. Record if a domain is flagged as the Boot Domain + c. Record if a domain is flagged as the Crash Domain + 5. Was a Boot Domain created + a. YES: + i. Attach console to Boot Domain + ii. Unpause Boot Domain + iii. Goto Boot Domain (step 6) + b. NO: Goto Launch Finalization (step 10) + 6. Boot Domain: + 7. Boot Domain comes online and may do any of the following actions + a. Process the LCM + b. Validate the MB2 chain + c. Make additional configuration settings for staged domains + d. Unpause any precursor domains + e. Set any runtime configurations + 8. Boot Domain does any necessary cleanup + 9. Boot Domain make hypercall op call to signal it is finished + i. Hypervisor reclaims all Boot Domain resources + ii. Hypervisor records that the Boot Domain ran + ii. Goto Launch Finalization (step 9) + 10. Launch Finalization + 11. If a configured domain was flagged to have the console, the + hypervisor assigns it + 12. The hypervisor clears the LCM and bootloader loaded module, + reclaiming the memory + 13. The hypervisor iterates through domains unpausing any domain not + flagged as the crash domain + + +Appendix 2: Considerations in Naming the Hyperlaunch Feature +------------------------------------------------------------ + +* The term “Launch” is preferred over “Boot” + + * Multiple individual component boots can occur in the new system start + process; Launch is preferable for describing the whole process + * Fortunately there is consensus in the current group of stakeholders + that the term “Launch” is good and appropriate + +* The names we define must support becoming meaningful and simple to use + outside the Xen community + + * They must be able to be resolved quickly via search engine to a clear + * explanation (eg. Xen marketing material, documentation or wiki) + * We prefer that the terms be helpful for marketing communications + * Consequence: avoid the term “domain” which is Xen-specific and + requires a definition to be provided each time when used elsewhere + + +* There is a need to communicate that Xen is capable of being used as a Static + Partitioning hypervisor + + * The community members using and maintaining dom0less are the current + primary stakeholders for this + +* There is a need to communicate that the new launch functionality provides new + capabilities not available elsewhere, and is more than just supporting Static + Partitioning + + * No other hypervisor known to the authors of this document is capable + of providing what Hyperlaunch will be able to do. The launch sequence is + designed to: + + * Remove dependency on a single, highly-privileged initial domain + * Allow the initial domains started to be independent and fully + isolated from each other + * Support configurations where no further VMs can be launched + once the initial domains have started + * Use a standard, extensible format for conveying VM + configuration data + * Ensure that domain building of all initial domains is + performed by the hypervisor from materials supplied by the + bootloader + * Enable flexible configuration to be applied to all initial + domains by an optional Boot Domain, that runs with limited + privilege, before any other domain starts and obtains the VM + configuration data from the bootloader materials via the + hypervisor + * Enable measurements of all of the boot materials prior to + their use, in a sequence with minimized privilege + * Support use-case-specific customized Boot Domains + * Complement the hypervisor’s existing ability to enforce + policy-based Mandatory Access Control + + +* “Static” and “Dynamic” have different and important meanings in different + communities + + * Static and Dynamic Partitioning describe the ability to create new + virtual machines, or not, after the initial host boot process + completes + * Static and Dynamic Root of Trust describe the nature of the trust + chain for a measured launch. In this case Static is referring to the + fact that the trust chain is fixed and non-repeatable until the next + host reboot or shutdown. Whereas Dynamic in this case refers to the + ability to conduct the measured launch at any time and potentially + multiple times before the next host reboot or shutdown. + + * We will be using Hyperlaunch with both Static and Dynamic + Roots of Trust, to launch both Static and Dynamically + Partitioned Systems, and being clear about exactly which + combination is being started will be very important (eg. for + certification processes) + + * Consequence: uses of “Static” and “Dynamic” need to be qualified if + they are incorporated into the naming of this functionality + + * This can be done by adding the preceding, stronger branded + term: “Hyperlaunch”, before “Static” or “Dynamic” + * ie. “Hyperlaunch Static” describes launch of a Statically Partitioned system + * and “Hyperlaunch Dynamic” describes launch of a Dynamically Partitioned system + * In practice, this means that “Hyperlaunch Static” describes + starting a Static Partitioned system where no new domains can + be started later (ie. no VM has the Control Domain + permission), whereas “Hyperlaunch Dynamic” will launch some + VM with the Control Domain permission, able to create VMs + dynamically at a later point. + +**Naming Proposal:** + +* New Term: “Hyperlaunch” : the ability of a hypervisor to construct and start + one or more virtual machines at system launch, in the following manner: + + * The hypervisor must build all of the domains that it starts at host + boot + + * Similar to the way the dom0 domain is built by the hypervisor + today, and how dom0less works: it will run a loop to build + them all, driven from the configuration provided + * This is a requirement for ensuring that there is Strong + Isolation between each of the initial VMs + + * A single file contains the VM configs (“Launch Control Module”: LCM, + in Device Tree binary format) is provided to the hypervisor + + * The hypervisor parses it and builds domains + * If the LCM config says that a Boot Domain should run first, + then the LCM file itself is made available to the Boot Domain + for it to parse and act on, to invoke operations via the + hypervisor to apply additional configuration to the other VMs + (ie. executing a privilege-constrained toolstack) + +* New Term: “Hyperlaunch Static”: starts a Static Partitioned system, where + only the virtual machines started at system launch are running on the system + +* New Term: “Hyperlaunch Dynamic”: starts a system where virtual machines may + be dynamically added after the initial virtual machines have started. + + +In the default configuration, Xen will be capable of both styles of Hyperlaunch +from the same hypervisor binary, when paired with its XSM flask, provides +strong controls that enable fine grained system partitioning. + + +* Retiring Term: “DomB”: will no longer be used to describe the optional first + domain that is started. It is replaced with the more general term: “Boot + Domain”. + + * “DomB” will still be used in the meantime to refer to the project + that is under way to build the new boot process, but will not be used + to name a thing within Xen. + +* Retiring Term: “Dom0less”: it is to be replaced with “Hyperlaunch Static” + + +Appendix 3: Terminology +----------------------- + +To help ensure clarity in reading this document, the following is the +definition of terminology used within this document. + + +Domain + a running instance of a virtual machine; (as the term is commonly used in + the Xen Community) + +Dom0 + the highly-privileged, first and only domain started at host boot on a + conventional Xen system + + +Multiple Domain Boot + a system configuration where the hypervisor and multiple virtual machines + are all launched when the host system hardware boots + + +Dom0less + an existing feature of Xen on Arm that provides Multiple Domain Boot + + +DomB + the development project to build hyperlaunch Multiple Domain Boot for Xen + + +Control Domain + a privileged domain that has been granted Control Domain permissions which + are those that are required by the Xen toolstack for managing other domains. + These permissions are a subset of those that are granted to Dom0. + + +Hardware Domain + a privileged domain that has been granted permissions to access and manage + host hardware. These permissions are a subset of those that are granted to + Dom0. + + +Late Hardware Domain + a Hardware Domain that is launched after host boot has already completed + with a running Dom0. When the Late Hardware Domain is started, Dom0 + relinquishes and transfers the permissions to access and manage host hardware + to it.. + + +Disaggregation + the separation of system roles and responsibilities across multiple + connected components that work together to provide functionality + + +Boot Domain + a domain with limited privileges launched by the hypervisor during a + Multiple Domain Boot that runs as the first domain started. In the hyperlaunch + architecture, it is responsible for assisting with higher level operations of + the domain setup process. + + +Launch Control Module (LCM) + A file supplied to the hypervisor by the bootloader that contains + configuration data for the hypervisor and the initial set of virtual machines + to be run at boot + + +Device Tree + a standardized data structure, with defined file formats, for describing + initial system configuration + + +System Device Tree + this is the product of a community project to extend Device Tree to cover + more aspects of initial system configuration + + +Basic Configuration + the minimal information the hypervisor requires to instantiate a domain instance + + +Extended Configuration + any configuration options for a domain beyond its Basic Configuration + + +Host Boot + the system startup of Xen using the configuration provided by the bootloader + + +Classic Launch + a backwards-compatible host boot that ends with the launch of a single domain (Dom0) + + +hyperlaunch + a flexible host boot that ends with the launch of one or more domains + + +Crash Domain + a fallback domain that the hypervisor may launch in the event of a + detectable error during the multiple domain boot process + + +Console Domain + a domain that has the Xen console assigned to it + + +Launched Domain + a domain, aside from the boot domain and crash domain, that is started as + part of a multiple domain boot and remains running once the boot process is + complete + + +Initial Domain + a domain that is described in the LCM that is run as part of a multiple + domain boot. This includes the Boot Domain, Crash Domain and all Launched + Domains. + + +Appendix 4: Copyright License +----------------------------- + +This work is licensed under a Creative Commons Attribution 4.0 International +License. A copy of this license may be obtained from the Creative Commons +website (https://creativecommons.org/licenses/by/4.0/legalcode). + + +Contributions by: + +Christopher Clark are Copyright © 2021 Star Lab Corporation + +Daniel P. Smith are Copyright © 2021 Apertus Solutions, LLC -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 16 03:12:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 03:12:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98173.186160 (Exim 4.92) (envelope-from ) id 1lM08E-0005Ue-9s; Tue, 16 Mar 2021 03:12:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98173.186160; Tue, 16 Mar 2021 03:12:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM08E-0005UX-5j; Tue, 16 Mar 2021 03:12:30 +0000 Received: by outflank-mailman (input) for mailman id 98173; Tue, 16 Mar 2021 03:12:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM08C-0005UL-UW for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 03:12:28 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3d5bf7ce-b7c5-43f6-921c-6f7dccefd4c0; Tue, 16 Mar 2021 03:12:27 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1615864287068120.23057697352931; Mon, 15 Mar 2021 20:11:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d5bf7ce-b7c5-43f6-921c-6f7dccefd4c0 ARC-Seal: i=1; a=rsa-sha256; t=1615864289; cv=none; d=zohomail.com; s=zohoarc; b=jKlOCkqlHh3hvFADTRxcDezdBYav97vKeUQvaSuiQYhtJ4/9H5JCyqqf9IgMeKTA7Jq9WS+E24taqN8jgY3JD0kwwQV2wLJ2coPi7LkfuOa+O204WE8mMOq/2okWStIRg5ao/w4VlSLgZJn1eHPeuEhvIeBFLBuak80+7SztfOU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615864289; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=c75/ljSO7EUvb05LAP8qRYoze7Y9SmH5sS+qXF/Am7g=; b=jiT/zFmkq6ft/ePp2HG7YqK5gdXFFHuzUJt8Y1Y0y+npWIt92er4JnpKOKihs/NAyZ5MBQe9ujjqTThsCzO+Iyqjv3bzq4bOX61pSaaGTrsP0cjH5lI9zQT92toI0qeNvqoLCh/b64gUYCuyXpHzkPUgYoDI/5abPb4OSLcATtw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1615864289; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=c75/ljSO7EUvb05LAP8qRYoze7Y9SmH5sS+qXF/Am7g=; b=cF5Zn6FJ4Eb4CYAdt8R+S1XW+vSO4Vxr+uTmOXSqQiRwMak3n9FQo6MSntClXY3d kid3dlYClEhxPYTnWjTmMPugPNYqQT02yQcNMf+AhvONm55tA2JWzF1i2oB+/Cy3ArF EpnQR8Im2JEOC+4zPLZe6M1WH+CN0g1KaX+WEBGc= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: christopher.w.clark@gmail.com, andrew.cooper3@citrix.com, stefano.stabellini@xilinx.com, jgrall@amazon.com, Julien.grall.oss@gmail.com, iwj@xenproject.org, wl@xen.org, george.dunlap@citrix.com, jbeulich@suse.com, persaur@gmail.com, Bertrand.Marquis@arm.com, roger.pau@citrix.com, luca.fancellu@arm.com, paul@xen.org, adam.schwalm@starlab.io Subject: [PATCH] docs/designs/launch: hyperlaunch device tree Date: Mon, 15 Mar 2021 23:18:14 -0400 Message-Id: <20210316031814.10311-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210316031814.10311-1-dpsmith@apertussolutions.com> References: <20210316031814.10311-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=Y Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Adds a design document for hyperlaunch device tree structure. Signed-off-by: Christopher Clark Signed-off by: Daniel P. Smith --- .../designs/launch/hyperlaunch-devicetree.rst | 343 ++++++++++++++++++ 1 file changed, 343 insertions(+) create mode 100644 docs/designs/launch/hyperlaunch-devicetree.rst diff --git a/docs/designs/launch/hyperlaunch-devicetree.rst b/docs/designs/launch/hyperlaunch-devicetree.rst new file mode 100644 index 0000000000..f97d357407 --- /dev/null +++ b/docs/designs/launch/hyperlaunch-devicetree.rst @@ -0,0 +1,343 @@ +------------------------------------- +Xen Hyperlaunch Device Tree Bindings +------------------------------------- + +The Xen hyperlaunch device tree adopts the dom0less device tree structure and +extends it to meet the requirements for the hyperlaunch capability. The primary +difference is the introduction of the ``hypervisor`` node that is under the +``/chosen`` node. The move to a dedicated node was driven by: + +1. Reduces the need to walk over nodes that are not of interest, e.g. only + nodes of interest should be in ``/chosen/hypervisor`` + +2. Allows for the domain construction information to easily be sanitized by + simple removing the ``/chosen/hypervisor`` node. + +Example Configuration +--------------------- + +Below are two example device tree definitions for the hypervisor node. The +first is an example of a multiboot-based configuration for x86 and the second +is a module-based configuration for Arm. + +Multiboot x86 Configuration: +"""""""""""""""""""""""""""" + +:: + + hypervisor { + #address-cells = <1>; + #size-cells = <0>; + compatible = “hypervisor,xen” + + // Configuration container + config { + compatible = "xen,config"; + + module { + compatible = "module,microcode", "multiboot,module"; + mb-index = <1>; + }; + + module { + compatible = "module,xsm-policy", "multiboot,module"; + mb-index = <2>; + }; + }; + + // Boot Domain definition + domain { + compatible = "xen,domain"; + + domid = <0x7FF5>; + + // FUNCTION_NONE (0) + // FUNCTION_BOOT (1 << 0) + // FUNCTION_CRASH (1 << 1) + // FUNCTION_CONSOLE (1 << 2) + // FUNCTION_XENSTORE (1 << 30) + // FUNCTION_LEGACY_DOM0 (1 << 31) + functions = <0x00000001>; + + memory = <0x0 0x20000>; + cpus = <1>; + module { + compatible = "module,kernel", "multiboot,module"; + mb-index = <3>; + }; + + module { + compatible = "module,ramdisk", "multiboot,module"; + mb-index = <4>; + }; + module { + compatible = "module,config", "multiboot,module"; + mb-index = <5>; + }; + + // Classic Dom0 definition + domain { + compatible = "xen,domain"; + + domid = <0>; + + // PERMISSION_NONE (0) + // PERMISSION_CONTROL (1 << 0) + // PERMISSION_HARDWARE (1 << 1) + permissions = <3>; + + // FUNCTION_NONE (0) + // FUNCTION_BOOT (1 << 0) + // FUNCTION_CRASH (1 << 1) + // FUNCTION_CONSOLE (1 << 2) + // FUNCTION_XENSTORE (1 << 30) + // FUNCTION_LEGACY_DOM0 (1 << 31) + functions = <0xC0000006>; + + // MODE_PARAVIRTUALIZED (1 << 0) /* PV | PVH/HVM */ + // MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */ + // MODE_LONG (1 << 2) /* 64 BIT | 32 BIT */ + mode = <5>; /* 64 BIT, PV */ + + // UUID + domain-uuid = [B3 FB 98 FB 8F 9F 67 A3]; + + cpus = <1>; + memory = <0x0 0x20000>; + security-id = “dom0_t; + + module { + compatible = "module,kernel", "multiboot,module"; + mb-index = <6>; + bootargs = "console=hvc0"; + }; + module { + compatible = "module,ramdisk", "multiboot,module"; + mb-index = <7>; + }; + }; + +The multiboot modules supplied when using the above config would be, in order: + +* (the above config, compiled) +* CPU microcode +* XSM policy +* kernel for boot domain +* ramdisk for boot domain +* boot domain configuration file +* kernel for the classic dom0 domain +* ramdisk for the classic dom0 domain + +Module Arm Configuration: +""""""""""""""""""""""""" + +:: + + hypervisor { + compatible = “hypervisor,xen” + + // Configuration container + config { + compatible = "xen,config"; + + module { + compatible = "module,microcode”; + module-addr = <0x0000ff00 0x80>; + }; + + module { + compatible = "module,xsm-policy"; + module-addr = <0x0000ff00 0x80>; + + }; + }; + + // Boot Domain definition + domain { + compatible = "xen,domain"; + + domid = <0x7FF5>; + + // FUNCTION_NONE (0) + // FUNCTION_BOOT (1 << 0) + // FUNCTION_CRASH (1 << 1) + // FUNCTION_CONSOLE (1 << 2) + // FUNCTION_XENSTORE (1 << 30) + // FUNCTION_LEGACY_DOM0 (1 << 31) + functions = <0x00000001>; + + memory = <0x0 0x20000>; + cpus = <1>; + module { + compatible = "module,kernel"; + module-addr = <0x0000ff00 0x80>; + }; + + module { + compatible = "module,ramdisk"; + module-addr = <0x0000ff00 0x80>; + }; + module { + compatible = "module,config"; + module-addr = <0x0000ff00 0x80>; + }; + + // Classic Dom0 definition + domain@0 { + compatible = "xen,domain"; + + domid = <0>; + + // PERMISSION_NONE (0) + // PERMISSION_CONTROL (1 << 0) + // PERMISSION_HARDWARE (1 << 1) + permissions = <3>; + + // FUNCTION_NONE (0) + // FUNCTION_BOOT (1 << 0) + // FUNCTION_CRASH (1 << 1) + // FUNCTION_CONSOLE (1 << 2) + // FUNCTION_XENSTORE (1 << 30) + // FUNCTION_LEGACY_DOM0 (1 << 31) + functions = <0xC0000006>; + + // MODE_PARAVIRTUALIZED (1 << 0) /* PV | PVH/HVM */ + // MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */ + // MODE_LONG (1 << 2) /* 64 BIT | 32 BIT */ + mode = <5>; /* 64 BIT, PV */ + + // UUID + domain-uuid = [B3 FB 98 FB 8F 9F 67 A3]; + + cpus = <1>; + memory = <0x0 0x20000>; + security-id = “dom0_t”; + + module { + compatible = "module,kernel"; + module-addr = <0x0000ff00 0x80>; + bootargs = "console=hvc0"; + }; + module { + compatible = "module,ramdisk"; + module-addr = <0x0000ff00 0x80>; + }; + }; + +The modules that would be supplied when using the above config would be: + +* (the above config, compiled into hardware tree) +* CPU microcode +* XSM policy +* kernel for boot domain +* ramdisk for boot domain +* boot domain configuration file +* kernel for the classic dom0 domain +* ramdisk for the classic dom0 domain + +The hypervisor device tree would be compiled into the hardware device tree and +provided to Xen using the standard method currently in use. The remaining +modules would need to be loaded in the respective addresses specified in the +`module-addr` property. + + +The Hypervisor node +------------------- + +The hypervisor node is a top level container for the domains that will be built +by hypervisor on start up. On the ``hypervisor`` node the ``compatible`` +property is used to identify the type of hypervisor node present.. + +compatible + Identifies the type of node. Required. + +The Config node +--------------- + +A config node is for detailing any modules that are of interest to Xen itself. +For example this would be where Xen would be informed of microcode or XSM +policy locations. If the modules are multiboot modules and are able to be +located by index within the module chain, the ``mb-index`` property should be +used to specify the index in the multiboot module chain.. If the module will be +located by physical memory address, then the ``module-addr`` property should be +used to identify the location and size of the module. + +compatible + Identifies the type of node. Required. + +The Domain node +--------------- + +A domain node is for describing the construction of a domain. It may provide a +domid property which will be used as the requested domain id for the domain +with a value of “0” signifying to use the next available domain id, which is +the default behavior if omitted. A domain configuration is not able to request +a domid of “0”. After that a domain node may have any of the following +parameters, + +compatible + Identifies the type of node. Required. + +domid + Identifies the domid requested to assign to the domain. Required. + +permissions + This sets what Discretionary Access Control permissions + a domain is assigned. Optional, default is none. + +functions + This identifies what system functions a domain will fulfill. + Optional, the default is none. + +.. note:: The `functions` bits that have been selected to indicate + ``FUNCTION_XENSTORE`` and ``FUNCTION_LEGACY_DOM0`` are the last two bits + (30, 31) such that should these features ever be fully retired, the flags may + be dropped without leaving a gap in the flag set. + +mode + The mode the domain will be executed under. Required. + +domain-uuid + A globally unique identifier for the domain. Optional, + the default is NULL. + +cpus + The number of vCPUs to be assigned to the domain. Optional, + the default is “1”. + +memory + The amount of memory to assign to the domain, in KBs. + Required. + +security-id + The security identity to be assigned to the domain when XSM + is the access control mechanism being used. Optional, + the default is “domu_t”. + +The Module node +--------------- + +This node describes a boot module loaded by the boot loader. The required +compatible property follows the format: module, where type can be +“kernel”, “ramdisk”, “device-tree”, “microcode”, “xsm-policy” or “config”. In +the case the module is a multiboot module, the additional property string +“multiboot,module” may be present. One of two properties is required and +identifies how to locate the module. They are the mb-index, used for multiboot +modules, and the module-addr for memory address based location. + +compatible + This identifies what the module is and thus what the hypervisor + should use the module for during domain construction. Required. + +mb-index + This identifies the index for this module in the multiboot module chain. + Required for multiboot environments. + +module-addr + This identifies where in memory this module is located. Required for + non-multiboot environments. + +bootargs + This is used to provide the boot params to kernel modules. + +.. note:: The bootargs property is intended for situations where the same kernel multiboot module is used for more than one domain. -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 16 03:57:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 03:57:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98179.186172 (Exim 4.92) (envelope-from ) id 1lM0pC-0000gh-Pv; Tue, 16 Mar 2021 03:56:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98179.186172; Tue, 16 Mar 2021 03:56:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM0pC-0000ga-Lw; Tue, 16 Mar 2021 03:56:54 +0000 Received: by outflank-mailman (input) for mailman id 98179; Tue, 16 Mar 2021 03:56:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM0pB-0000gV-6j for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 03:56:53 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a5b3ad90-da25-4e90-9f55-c0b03ae724b0; Tue, 16 Mar 2021 03:56:51 +0000 (UTC) Received: from [10.10.1.24] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1615866996153781.5355650658495; Mon, 15 Mar 2021 20:56:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5b3ad90-da25-4e90-9f55-c0b03ae724b0 ARC-Seal: i=1; a=rsa-sha256; t=1615867001; cv=none; d=zohomail.com; s=zohoarc; b=QEFK8pBJmSKU1RaTofv/BGeAmEMDDuAZP7rYDBDmmY46DYLke80s7To1ApO0qiLdtddKbw/BRJV138yQ8Tprh3seWvnr8Pjg8x7z6IjSjTeUxK5k3HCCd97viW52AhTWQBd7uK4AzSUEvkO3Meu7Bwl+NuQ9oSI6WuXjCQtxcIY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615867001; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=1pU+1gJ+CyX5MIFGfzJ+W1NID/Yxhz2uZkPzqWIqgVg=; b=oJGqTKMs2FYR4J/KtS4Ch2cjAn78kbxR9odSy8JphXN27JYxzkhK5u6f/e1Gn6PRNNCT5Hq/bzk3jnQbd1RtIqRYtT3/oRg9x6DSCC1ru12C02o/S2iG89fg39U3p+s6LqFmglbjAO/73gANmYlXzSPCFMUdzjd0mPYPn/9WeTo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1615867001; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Message-ID:References:Subject:Date:MIME-Version:In-Reply-To:Content-Type; bh=1pU+1gJ+CyX5MIFGfzJ+W1NID/Yxhz2uZkPzqWIqgVg=; b=PyBv3zRBYmnUcy45asmC38hcXfagMEnKESMwLO6g0FuhNHlNkBrBYWkTgPhrkD5f 0H2+SA0h0QoKKpKbU0poA2JZFilPd+l8/gVMJAMPhH2En1H160ymLEByoVmCvx0f8j0 b/o0xY3Ea92UILQaPlU4KprFrmCh3H6gbvLJB7Sg= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: christopher.w.clark@gmail.com, andrew.cooper3@citrix.com, stefano.stabellini@xilinx.com, jgrall@amazon.com, Julien.grall.oss@gmail.com, iwj@xenproject.org, wl@xen.org, george.dunlap@citrix.com, jbeulich@suse.com, persaur@gmail.com, Bertrand.Marquis@arm.com, roger.pau@citrix.com, luca.fancellu@arm.com, paul@xen.org, adam.schwalm@starlab.io Message-ID: <6314f50f-b4fc-e472-4c9a-3591e168d2c3@apertussolutions.com> References: <20210316031814.10311-1-dpsmith@apertussolutions.com> Subject: Re: [PATCH 0/2] Introducing hyperlaunch capability design (formerly: DomB mode of dom0less) Date: Mon, 15 Mar 2021 23:56:33 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210316031814.10311-1-dpsmith@apertussolutions.com> Content-Type: multipart/mixed; boundary="------------DEE995035C8380D8C0329228" Content-Language: en-US X-Zoho-Virus-Status: 1 X-ZohoMailClient: External This is a multi-part message in MIME format. --------------DEE995035C8380D8C0329228 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 3/15/21 11:18 PM, Daniel P. Smith wrote: > We are submitting for inclusion in the Xen documentation: >=20 > - the hyperlaunch design document, and > - the hyperlaunch device tree design document >=20 > to describe a new method for launching the Xen hypervisor. >=20 > The hyperlaunch feature builds upon prior dom0less work and the DomB > project to bring a flexible and security-minded means to launch a > variety of VM configurations as part of the startup of Xen. >=20 > Signed-off-by: Christopher Clark > Signed-off by: Daniel P. Smith >=20 >=20 > Daniel P. Smith (2): > docs/designs/launch: hyperlaunch design document > docs/designs/launch: hyperlaunch device tree >=20 > .../designs/launch/hyperlaunch-devicetree.rst | 343 +++++++ > docs/designs/launch/hyperlaunch.rst | 900 ++++++++++++++++++ > 2 files changed, 1243 insertions(+) > create mode 100644 docs/designs/launch/hyperlaunch-devicetree.rst > create mode 100644 docs/designs/launch/hyperlaunch.rst >=20 To assist in reading, please find attached rendered copies of the design docs. It should be noted that due to poor rendering by pandoc, we forced the tables to stay as ASCII tables in the patches whereas the attached docs have the tables rendered properly by rst2pdf. V/r Daniel P. Smith --------------DEE995035C8380D8C0329228 Content-Type: application/pdf; name="hyperlaunch.pdf" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="hyperlaunch.pdf" JVBERi0xLjQNCiWTjIueIFJlcG9ydExhYiBHZW5lcmF0ZWQgUERGIGRvY3VtZW50IGh0dHA6 Ly93d3cucmVwb3J0bGFiLmNvbQ0KMSAwIG9iag0KPDwgL0YxIDIgMCBSIC9GMiAzIDAgUiAv RjMgNjMgMCBSIC9GNCA2NiAwIFIgL0Y1IDY3IDAgUiA+Pg0KZW5kb2JqDQoyIDAgb2JqDQo8 PCAvQmFzZUZvbnQgL0hlbHZldGljYSAvRW5jb2RpbmcgL1dpbkFuc2lFbmNvZGluZyAvTmFt ZSAvRjEgL1N1YnR5cGUgL1R5cGUxIC9UeXBlIC9Gb250ID4+DQplbmRvYmoNCjMgMCBvYmoN Cjw8IC9CYXNlRm9udCAvSGVsdmV0aWNhLUJvbGQgL0VuY29kaW5nIC9XaW5BbnNpRW5jb2Rp bmcgL05hbWUgL0YyIC9TdWJ0eXBlIC9UeXBlMSAvVHlwZSAvRm9udCA+Pg0KZW5kb2JqDQo0 IDAgb2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAgXSAvQ29udGVudHMgKCkgL0Rlc3QgWyA2MCAw IFIgL1hZWiA2Mi42OTI5MSAxODYuMDIzNiAwIF0gL1JlY3QgWyA2Mi42OTI5MSA2ODcuMDIz NiAxMzQuOTIyOSA2OTkuMDIzNiBdIC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+Pg0K ZW5kb2JqDQo1IDAgb2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAgXSAvQ29udGVudHMgKCkgL0Rl c3QgWyA2MCAwIFIgL1hZWiA2Mi42OTI5MSAxODYuMDIzNiAwIF0gL1JlY3QgWyA1MjcuMDIy NyA2ODcuNzczNiA1MzIuNTgyNyA2OTkuNzczNiBdIC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9B bm5vdCA+Pg0KZW5kb2JqDQo2IDAgb2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAgXSAvQ29udGVu dHMgKCkgL0Rlc3QgWyA2MSAwIFIgL1hZWiA2Mi42OTI5MSA2OTkuMDIzNiAwIF0gL1JlY3Qg WyA2Mi42OTI5MSA2NjkuMDIzNiAxMjMuMjYyOSA2ODEuMDIzNiBdIC9TdWJ0eXBlIC9MaW5r IC9UeXBlIC9Bbm5vdCA+Pg0KZW5kb2JqDQo3IDAgb2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAg XSAvQ29udGVudHMgKCkgL0Rlc3QgWyA2MSAwIFIgL1hZWiA2Mi42OTI5MSA2OTkuMDIzNiAw IF0gL1JlY3QgWyA1MjcuMDIyNyA2NjkuNzczNiA1MzIuNTgyNyA2ODEuNzczNiBdIC9TdWJ0 eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+Pg0KZW5kb2JqDQo4IDAgb2JqDQo8PCAvQm9yZGVy IFsgMCAwIDAgXSAvQ29udGVudHMgKCkgL0Rlc3QgWyA2MSAwIFIgL1hZWiA2Mi42OTI5MSA0 OTIuMDIzNiAwIF0gL1JlY3QgWyA4Mi42OTI5MSA2NTEuMDIzNiAxNTEuNjEyOSA2NjMuMDIz NiBdIC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+Pg0KZW5kb2JqDQo5IDAgb2JqDQo8 PCAvQm9yZGVyIFsgMCAwIDAgXSAvQ29udGVudHMgKCkgL0Rlc3QgWyA2MSAwIFIgL1hZWiA2 Mi42OTI5MSA0OTIuMDIzNiAwIF0gL1JlY3QgWyA1MjcuMDIyNyA2NTEuNzczNiA1MzIuNTgy NyA2NjMuNzczNiBdIC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+Pg0KZW5kb2JqDQox MCAwIG9iag0KPDwgL0JvcmRlciBbIDAgMCAwIF0gL0NvbnRlbnRzICgpIC9EZXN0IFsgNjIg MCBSIC9YWVogNjIuNjkyOTEgNzY1LjAyMzYgMCBdIC9SZWN0IFsgNjIuNjkyOTEgNjMzLjAy MzYgMTk5Ljk1MjkgNjQ1LjAyMzYgXSAvU3VidHlwZSAvTGluayAvVHlwZSAvQW5ub3QgPj4N CmVuZG9iag0KMTEgMCBvYmoNCjw8IC9Cb3JkZXIgWyAwIDAgMCBdIC9Db250ZW50cyAoKSAv RGVzdCBbIDYyIDAgUiAvWFlaIDYyLjY5MjkxIDc2NS4wMjM2IDAgXSAvUmVjdCBbIDUyNy4w MjI3IDYzMy43NzM2IDUzMi41ODI3IDY0NS43NzM2IF0gL1N1YnR5cGUgL0xpbmsgL1R5cGUg L0Fubm90ID4+DQplbmRvYmoNCjEyIDAgb2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAgXSAvQ29u dGVudHMgKCkgL0Rlc3QgWyA2MiAwIFIgL1hZWiA2Mi42OTI5MSA2MzAuMDIzNiAwIF0gL1Jl Y3QgWyA4Mi42OTI5MSA2MTUuMDIzNiAxNTMuODUyOSA2MjcuMDIzNiBdIC9TdWJ0eXBlIC9M aW5rIC9UeXBlIC9Bbm5vdCA+Pg0KZW5kb2JqDQoxMyAwIG9iag0KPDwgL0JvcmRlciBbIDAg MCAwIF0gL0NvbnRlbnRzICgpIC9EZXN0IFsgNjIgMCBSIC9YWVogNjIuNjkyOTEgNjMwLjAy MzYgMCBdIC9SZWN0IFsgNTI3LjAyMjcgNjE1Ljc3MzYgNTMyLjU4MjcgNjI3Ljc3MzYgXSAv U3VidHlwZSAvTGluayAvVHlwZSAvQW5ub3QgPj4NCmVuZG9iag0KMTQgMCBvYmoNCjw8IC9C b3JkZXIgWyAwIDAgMCBdIC9Db250ZW50cyAoKSAvRGVzdCBbIDY0IDAgUiAvWFlaIDYyLjY5 MjkxIDc2NS4wMjM2IDAgXSAvUmVjdCBbIDgyLjY5MjkxIDU5Ny4wMjM2IDE5Ni4wNzI5IDYw OS4wMjM2IF0gL1N1YnR5cGUgL0xpbmsgL1R5cGUgL0Fubm90ID4+DQplbmRvYmoNCjE1IDAg b2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAgXSAvQ29udGVudHMgKCkgL0Rlc3QgWyA2NCAwIFIg L1hZWiA2Mi42OTI5MSA3NjUuMDIzNiAwIF0gL1JlY3QgWyA1MjcuMDIyNyA1OTcuNzczNiA1 MzIuNTgyNyA2MDkuNzczNiBdIC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+Pg0KZW5k b2JqDQoxNiAwIG9iag0KPDwgL0JvcmRlciBbIDAgMCAwIF0gL0NvbnRlbnRzICgpIC9EZXN0 IFsgNjQgMCBSIC9YWVogNjIuNjkyOTEgNjM5LjAyMzYgMCBdIC9SZWN0IFsgODIuNjkyOTEg NTc5LjAyMzYgMjM2LjA5MjkgNTkxLjAyMzYgXSAvU3VidHlwZSAvTGluayAvVHlwZSAvQW5u b3QgPj4NCmVuZG9iag0KMTcgMCBvYmoNCjw8IC9Cb3JkZXIgWyAwIDAgMCBdIC9Db250ZW50 cyAoKSAvRGVzdCBbIDY0IDAgUiAvWFlaIDYyLjY5MjkxIDYzOS4wMjM2IDAgXSAvUmVjdCBb IDUyNy4wMjI3IDU3OS43NzM2IDUzMi41ODI3IDU5MS43NzM2IF0gL1N1YnR5cGUgL0xpbmsg L1R5cGUgL0Fubm90ID4+DQplbmRvYmoNCjE4IDAgb2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAg XSAvQ29udGVudHMgKCkgL0Rlc3QgWyA2NCAwIFIgL1hZWiA2Mi42OTI5MSA1NTUuMDIzNiAw IF0gL1JlY3QgWyAxMDIuNjkyOSA1NjEuMDIzNiAzNjAuMDAyOSA1NzMuMDIzNiBdIC9TdWJ0 eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+Pg0KZW5kb2JqDQoxOSAwIG9iag0KPDwgL0JvcmRl ciBbIDAgMCAwIF0gL0NvbnRlbnRzICgpIC9EZXN0IFsgNjQgMCBSIC9YWVogNjIuNjkyOTEg NTU1LjAyMzYgMCBdIC9SZWN0IFsgNTI3LjAyMjcgNTYxLjc3MzYgNTMyLjU4MjcgNTczLjc3 MzYgXSAvU3VidHlwZSAvTGluayAvVHlwZSAvQW5ub3QgPj4NCmVuZG9iag0KMjAgMCBvYmoN Cjw8IC9Cb3JkZXIgWyAwIDAgMCBdIC9Db250ZW50cyAoKSAvRGVzdCBbIDY0IDAgUiAvWFla IDYyLjY5MjkxIDMzMC4wMjM2IDAgXSAvUmVjdCBbIDEwMi42OTI5IDU0My4wMjM2IDQ0NC41 MTI5IDU1NS4wMjM2IF0gL1N1YnR5cGUgL0xpbmsgL1R5cGUgL0Fubm90ID4+DQplbmRvYmoN CjIxIDAgb2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAgXSAvQ29udGVudHMgKCkgL0Rlc3QgWyA2 NCAwIFIgL1hZWiA2Mi42OTI5MSAzMzAuMDIzNiAwIF0gL1JlY3QgWyA1MjcuMDIyNyA1NDMu NzczNiA1MzIuNTgyNyA1NTUuNzczNiBdIC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+ Pg0KZW5kb2JqDQoyMiAwIG9iag0KPDwgL0JvcmRlciBbIDAgMCAwIF0gL0NvbnRlbnRzICgp IC9EZXN0IFsgNjQgMCBSIC9YWVogNjIuNjkyOTEgMTM2LjAyMzYgMCBdIC9SZWN0IFsgMTAy LjY5MjkgNTI1LjAyMzYgMzkwLjA0MjkgNTM3LjAyMzYgXSAvU3VidHlwZSAvTGluayAvVHlw ZSAvQW5ub3QgPj4NCmVuZG9iag0KMjMgMCBvYmoNCjw8IC9Cb3JkZXIgWyAwIDAgMCBdIC9D b250ZW50cyAoKSAvRGVzdCBbIDY0IDAgUiAvWFlaIDYyLjY5MjkxIDEzNi4wMjM2IDAgXSAv UmVjdCBbIDUyNy4wMjI3IDUyNS43NzM2IDUzMi41ODI3IDUzNy43NzM2IF0gL1N1YnR5cGUg L0xpbmsgL1R5cGUgL0Fubm90ID4+DQplbmRvYmoNCjI0IDAgb2JqDQo8PCAvQm9yZGVyIFsg MCAwIDAgXSAvQ29udGVudHMgKCkgL0Rlc3QgWyA2NSAwIFIgL1hZWiA2Mi42OTI5MSA2MDQu MDIzNiAwIF0gL1JlY3QgWyAxMDIuNjkyOSA1MDcuMDIzNiAzMTAuNTYyOSA1MTkuMDIzNiBd IC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+Pg0KZW5kb2JqDQoyNSAwIG9iag0KPDwg L0JvcmRlciBbIDAgMCAwIF0gL0NvbnRlbnRzICgpIC9EZXN0IFsgNjUgMCBSIC9YWVogNjIu NjkyOTEgNjA0LjAyMzYgMCBdIC9SZWN0IFsgNTI3LjAyMjcgNTA3Ljc3MzYgNTMyLjU4Mjcg NTE5Ljc3MzYgXSAvU3VidHlwZSAvTGluayAvVHlwZSAvQW5ub3QgPj4NCmVuZG9iag0KMjYg MCBvYmoNCjw8IC9Cb3JkZXIgWyAwIDAgMCBdIC9Db250ZW50cyAoKSAvRGVzdCBbIDY1IDAg UiAvWFlaIDYyLjY5MjkxIDMwMS4wMjM2IDAgXSAvUmVjdCBbIDgyLjY5MjkxIDQ4OS4wMjM2 IDI2Mi43OTI5IDUwMS4wMjM2IF0gL1N1YnR5cGUgL0xpbmsgL1R5cGUgL0Fubm90ID4+DQpl bmRvYmoNCjI3IDAgb2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAgXSAvQ29udGVudHMgKCkgL0Rl c3QgWyA2NSAwIFIgL1hZWiA2Mi42OTI5MSAzMDEuMDIzNiAwIF0gL1JlY3QgWyA1MjcuMDIy NyA0ODkuNzczNiA1MzIuNTgyNyA1MDEuNzczNiBdIC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9B bm5vdCA+Pg0KZW5kb2JqDQoyOCAwIG9iag0KPDwgL0JvcmRlciBbIDAgMCAwIF0gL0NvbnRl bnRzICgpIC9EZXN0IFsgNjggMCBSIC9YWVogNjIuNjkyOTEgNDM1LjAyMzYgMCBdIC9SZWN0 IFsgODIuNjkyOTEgNDcxLjAyMzYgMjM4Ljg2MjkgNDgzLjAyMzYgXSAvU3VidHlwZSAvTGlu ayAvVHlwZSAvQW5ub3QgPj4NCmVuZG9iag0KMjkgMCBvYmoNCjw8IC9Cb3JkZXIgWyAwIDAg MCBdIC9Db250ZW50cyAoKSAvRGVzdCBbIDY4IDAgUiAvWFlaIDYyLjY5MjkxIDQzNS4wMjM2 IDAgXSAvUmVjdCBbIDUyNy4wMjI3IDQ3MS43NzM2IDUzMi41ODI3IDQ4My43NzM2IF0gL1N1 YnR5cGUgL0xpbmsgL1R5cGUgL0Fubm90ID4+DQplbmRvYmoNCjMwIDAgb2JqDQo8PCAvQm9y ZGVyIFsgMCAwIDAgXSAvQ29udGVudHMgKCkgL0Rlc3QgWyA2OSAwIFIgL1hZWiA2Mi42OTI5 MSA3NjUuMDIzNiAwIF0gL1JlY3QgWyAxMDIuNjkyOSA0NTMuMDIzNiAyNDEuNjYyOSA0NjUu MDIzNiBdIC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+Pg0KZW5kb2JqDQozMSAwIG9i ag0KPDwgL0JvcmRlciBbIDAgMCAwIF0gL0NvbnRlbnRzICgpIC9EZXN0IFsgNjkgMCBSIC9Y WVogNjIuNjkyOTEgNzY1LjAyMzYgMCBdIC9SZWN0IFsgNTI3LjAyMjcgNDUzLjc3MzYgNTMy LjU4MjcgNDY1Ljc3MzYgXSAvU3VidHlwZSAvTGluayAvVHlwZSAvQW5ub3QgPj4NCmVuZG9i ag0KMzIgMCBvYmoNCjw8IC9Cb3JkZXIgWyAwIDAgMCBdIC9Db250ZW50cyAoKSAvRGVzdCBb IDcwIDAgUiAvWFlaIDYyLjY5MjkxIDY5My4wMjM2IDAgXSAvUmVjdCBbIDgyLjY5MjkxIDQz NS4wMjM2IDIyMy4zMTI5IDQ0Ny4wMjM2IF0gL1N1YnR5cGUgL0xpbmsgL1R5cGUgL0Fubm90 ID4+DQplbmRvYmoNCjMzIDAgb2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAgXSAvQ29udGVudHMg KCkgL0Rlc3QgWyA3MCAwIFIgL1hZWiA2Mi42OTI5MSA2OTMuMDIzNiAwIF0gL1JlY3QgWyA1 MjcuMDIyNyA0MzUuNzczNiA1MzIuNTgyNyA0NDcuNzczNiBdIC9TdWJ0eXBlIC9MaW5rIC9U eXBlIC9Bbm5vdCA+Pg0KZW5kb2JqDQozNCAwIG9iag0KPDwgL0JvcmRlciBbIDAgMCAwIF0g L0NvbnRlbnRzICgpIC9EZXN0IFsgNzAgMCBSIC9YWVogNjIuNjkyOTEgNTg1LjAyMzYgMCBd IC9SZWN0IFsgMTAyLjY5MjkgNDE3LjAyMzYgMTk4LjMwMjkgNDI5LjAyMzYgXSAvU3VidHlw ZSAvTGluayAvVHlwZSAvQW5ub3QgPj4NCmVuZG9iag0KMzUgMCBvYmoNCjw8IC9Cb3JkZXIg WyAwIDAgMCBdIC9Db250ZW50cyAoKSAvRGVzdCBbIDcwIDAgUiAvWFlaIDYyLjY5MjkxIDU4 NS4wMjM2IDAgXSAvUmVjdCBbIDUyNy4wMjI3IDQxNy43NzM2IDUzMi41ODI3IDQyOS43NzM2 IF0gL1N1YnR5cGUgL0xpbmsgL1R5cGUgL0Fubm90ID4+DQplbmRvYmoNCjM2IDAgb2JqDQo8 PCAvQm9yZGVyIFsgMCAwIDAgXSAvQ29udGVudHMgKCkgL0Rlc3QgWyA3MCAwIFIgL1hZWiA2 Mi42OTI5MSAyNTIuMDIzNiAwIF0gL1JlY3QgWyAxMDIuNjkyOSAzOTkuMDIzNiAyMDguMjgy OSA0MTEuMDIzNiBdIC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+Pg0KZW5kb2JqDQoz NyAwIG9iag0KPDwgL0JvcmRlciBbIDAgMCAwIF0gL0NvbnRlbnRzICgpIC9EZXN0IFsgNzAg MCBSIC9YWVogNjIuNjkyOTEgMjUyLjAyMzYgMCBdIC9SZWN0IFsgNTI3LjAyMjcgMzk5Ljc3 MzYgNTMyLjU4MjcgNDExLjc3MzYgXSAvU3VidHlwZSAvTGluayAvVHlwZSAvQW5ub3QgPj4N CmVuZG9iag0KMzggMCBvYmoNCjw8IC9Cb3JkZXIgWyAwIDAgMCBdIC9Db250ZW50cyAoKSAv RGVzdCBbIDcxIDAgUiAvWFlaIDYyLjY5MjkxIDc2NS4wMjM2IDAgXSAvUmVjdCBbIDEwMi42 OTI5IDM4MS4wMjM2IDE5OS45NjI5IDM5My4wMjM2IF0gL1N1YnR5cGUgL0xpbmsgL1R5cGUg L0Fubm90ID4+DQplbmRvYmoNCjM5IDAgb2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAgXSAvQ29u dGVudHMgKCkgL0Rlc3QgWyA3MSAwIFIgL1hZWiA2Mi42OTI5MSA3NjUuMDIzNiAwIF0gL1Jl Y3QgWyA1MjcuMDIyNyAzODEuNzczNiA1MzIuNTgyNyAzOTMuNzczNiBdIC9TdWJ0eXBlIC9M aW5rIC9UeXBlIC9Bbm5vdCA+Pg0KZW5kb2JqDQo0MCAwIG9iag0KPDwgL0JvcmRlciBbIDAg MCAwIF0gL0NvbnRlbnRzICgpIC9EZXN0IFsgNzEgMCBSIC9YWVogNjIuNjkyOTEgNjQ4LjAy MzYgMCBdIC9SZWN0IFsgMTAyLjY5MjkgMzYzLjAyMzYgMTkxLjA3MjkgMzc1LjAyMzYgXSAv U3VidHlwZSAvTGluayAvVHlwZSAvQW5ub3QgPj4NCmVuZG9iag0KNDEgMCBvYmoNCjw8IC9C b3JkZXIgWyAwIDAgMCBdIC9Db250ZW50cyAoKSAvRGVzdCBbIDcxIDAgUiAvWFlaIDYyLjY5 MjkxIDY0OC4wMjM2IDAgXSAvUmVjdCBbIDUyNy4wMjI3IDM2My43NzM2IDUzMi41ODI3IDM3 NS43NzM2IF0gL1N1YnR5cGUgL0xpbmsgL1R5cGUgL0Fubm90ID4+DQplbmRvYmoNCjQyIDAg b2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAgXSAvQ29udGVudHMgKCkgL0Rlc3QgWyA3MSAwIFIg L1hZWiA2Mi42OTI5MSA1NDMuMDIzNiAwIF0gL1JlY3QgWyAxMDIuNjkyOSAzNDUuMDIzNiAx OTcuMTcyOSAzNTcuMDIzNiBdIC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+Pg0KZW5k b2JqDQo0MyAwIG9iag0KPDwgL0JvcmRlciBbIDAgMCAwIF0gL0NvbnRlbnRzICgpIC9EZXN0 IFsgNzEgMCBSIC9YWVogNjIuNjkyOTEgNTQzLjAyMzYgMCBdIC9SZWN0IFsgNTI3LjAyMjcg MzQ1Ljc3MzYgNTMyLjU4MjcgMzU3Ljc3MzYgXSAvU3VidHlwZSAvTGluayAvVHlwZSAvQW5u b3QgPj4NCmVuZG9iag0KNDQgMCBvYmoNCjw8IC9Cb3JkZXIgWyAwIDAgMCBdIC9Db250ZW50 cyAoKSAvRGVzdCBbIDcxIDAgUiAvWFlaIDYyLjY5MjkxIDQzOC4wMjM2IDAgXSAvUmVjdCBb IDEwMi42OTI5IDMyNy4wMjM2IDIwMi43MzI5IDMzOS4wMjM2IF0gL1N1YnR5cGUgL0xpbmsg L1R5cGUgL0Fubm90ID4+DQplbmRvYmoNCjQ1IDAgb2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAg XSAvQ29udGVudHMgKCkgL0Rlc3QgWyA3MSAwIFIgL1hZWiA2Mi42OTI5MSA0MzguMDIzNiAw IF0gL1JlY3QgWyA1MjcuMDIyNyAzMjcuNzczNiA1MzIuNTgyNyAzMzkuNzczNiBdIC9TdWJ0 eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+Pg0KZW5kb2JqDQo0NiAwIG9iag0KPDwgL0JvcmRl ciBbIDAgMCAwIF0gL0NvbnRlbnRzICgpIC9EZXN0IFsgNzEgMCBSIC9YWVogNjIuNjkyOTEg MzU3LjAyMzYgMCBdIC9SZWN0IFsgMTAyLjY5MjkgMzA5LjAyMzYgMjEzLjg0MjkgMzIxLjAy MzYgXSAvU3VidHlwZSAvTGluayAvVHlwZSAvQW5ub3QgPj4NCmVuZG9iag0KNDcgMCBvYmoN Cjw8IC9Cb3JkZXIgWyAwIDAgMCBdIC9Db250ZW50cyAoKSAvRGVzdCBbIDcxIDAgUiAvWFla IDYyLjY5MjkxIDM1Ny4wMjM2IDAgXSAvUmVjdCBbIDUyNy4wMjI3IDMwOS43NzM2IDUzMi41 ODI3IDMyMS43NzM2IF0gL1N1YnR5cGUgL0xpbmsgL1R5cGUgL0Fubm90ID4+DQplbmRvYmoN CjQ4IDAgb2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAgXSAvQ29udGVudHMgKCkgL0Rlc3QgWyA3 MSAwIFIgL1hZWiA2Mi42OTI5MSAyNjQuMDIzNiAwIF0gL1JlY3QgWyAxMDIuNjkyOSAyOTEu MDIzNiAyMDcuMTgyOSAzMDMuMDIzNiBdIC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+ Pg0KZW5kb2JqDQo0OSAwIG9iag0KPDwgL0JvcmRlciBbIDAgMCAwIF0gL0NvbnRlbnRzICgp IC9EZXN0IFsgNzEgMCBSIC9YWVogNjIuNjkyOTEgMjY0LjAyMzYgMCBdIC9SZWN0IFsgNTI3 LjAyMjcgMjkxLjc3MzYgNTMyLjU4MjcgMzAzLjc3MzYgXSAvU3VidHlwZSAvTGluayAvVHlw ZSAvQW5ub3QgPj4NCmVuZG9iag0KNTAgMCBvYmoNCjw8IC9Cb3JkZXIgWyAwIDAgMCBdIC9D b250ZW50cyAoKSAvRGVzdCBbIDcyIDAgUiAvWFlaIDYyLjY5MjkxIDc2NS4wMjM2IDAgXSAv UmVjdCBbIDYyLjY5MjkxIDI3My4wMjM2IDEyMi4xNTI5IDI4NS4wMjM2IF0gL1N1YnR5cGUg L0xpbmsgL1R5cGUgL0Fubm90ID4+DQplbmRvYmoNCjUxIDAgb2JqDQo8PCAvQm9yZGVyIFsg MCAwIDAgXSAvQ29udGVudHMgKCkgL0Rlc3QgWyA3MiAwIFIgL1hZWiA2Mi42OTI5MSA3NjUu MDIzNiAwIF0gL1JlY3QgWyA1MjEuNDYyNyAyNzMuNzczNiA1MzIuNTgyNyAyODUuNzczNiBd IC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+Pg0KZW5kb2JqDQo1MiAwIG9iag0KPDwg L0JvcmRlciBbIDAgMCAwIF0gL0NvbnRlbnRzICgpIC9EZXN0IFsgNzIgMCBSIC9YWVogNjIu NjkyOTEgNzMyLjAyMzYgMCBdIC9SZWN0IFsgODIuNjkyOTEgMjU1LjAyMzYgMzY4Ljk3Mjkg MjY3LjAyMzYgXSAvU3VidHlwZSAvTGluayAvVHlwZSAvQW5ub3QgPj4NCmVuZG9iag0KNTMg MCBvYmoNCjw8IC9Cb3JkZXIgWyAwIDAgMCBdIC9Db250ZW50cyAoKSAvRGVzdCBbIDcyIDAg UiAvWFlaIDYyLjY5MjkxIDczMi4wMjM2IDAgXSAvUmVjdCBbIDUyMS40NjI3IDI1NS43NzM2 IDUzMi41ODI3IDI2Ny43NzM2IF0gL1N1YnR5cGUgL0xpbmsgL1R5cGUgL0Fubm90ID4+DQpl bmRvYmoNCjU0IDAgb2JqDQo8PCAvQm9yZGVyIFsgMCAwIDAgXSAvQ29udGVudHMgKCkgL0Rl c3QgWyA3MiAwIFIgL1hZWiA2Mi42OTI5MSAxMjIuODIzNiAwIF0gL1JlY3QgWyA4Mi42OTI5 MSAyMzcuMDIzNiAzODcuODMyOSAyNDkuMDIzNiBdIC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9B bm5vdCA+Pg0KZW5kb2JqDQo1NSAwIG9iag0KPDwgL0JvcmRlciBbIDAgMCAwIF0gL0NvbnRl bnRzICgpIC9EZXN0IFsgNzIgMCBSIC9YWVogNjIuNjkyOTEgMTIyLjgyMzYgMCBdIC9SZWN0 IFsgNTIxLjQ2MjcgMjM3Ljc3MzYgNTMyLjU4MjcgMjQ5Ljc3MzYgXSAvU3VidHlwZSAvTGlu ayAvVHlwZSAvQW5ub3QgPj4NCmVuZG9iag0KNTYgMCBvYmoNCjw8IC9Cb3JkZXIgWyAwIDAg MCBdIC9Db250ZW50cyAoKSAvRGVzdCBbIDc1IDAgUiAvWFlaIDYyLjY5MjkxIDcxMS4wMjM2 IDAgXSAvUmVjdCBbIDgyLjY5MjkxIDIxOS4wMjM2IDIxNS41MzI5IDIzMS4wMjM2IF0gL1N1 YnR5cGUgL0xpbmsgL1R5cGUgL0Fubm90ID4+DQplbmRvYmoNCjU3IDAgb2JqDQo8PCAvQm9y ZGVyIFsgMCAwIDAgXSAvQ29udGVudHMgKCkgL0Rlc3QgWyA3NSAwIFIgL1hZWiA2Mi42OTI5 MSA3MTEuMDIzNiAwIF0gL1JlY3QgWyA1MjEuNDYyNyAyMTkuNzczNiA1MzIuNTgyNyAyMzEu NzczNiBdIC9TdWJ0eXBlIC9MaW5rIC9UeXBlIC9Bbm5vdCA+Pg0KZW5kb2JqDQo1OCAwIG9i ag0KPDwgL0JvcmRlciBbIDAgMCAwIF0gL0NvbnRlbnRzICgpIC9EZXN0IFsgNzcgMCBSIC9Y WVogNjIuNjkyOTEgNDg1LjAyMzYgMCBdIC9SZWN0IFsgODIuNjkyOTEgMjAxLjAyMzYgMjQw LjU1MjkgMjEzLjAyMzYgXSAvU3VidHlwZSAvTGluayAvVHlwZSAvQW5ub3QgPj4NCmVuZG9i ag0KNTkgMCBvYmoNCjw8IC9Cb3JkZXIgWyAwIDAgMCBdIC9Db250ZW50cyAoKSAvRGVzdCBb IDc3IDAgUiAvWFlaIDYyLjY5MjkxIDQ4NS4wMjM2IDAgXSAvUmVjdCBbIDUyMS40NjI3IDIw MS43NzM2IDUzMi41ODI3IDIxMy43NzM2IF0gL1N1YnR5cGUgL0xpbmsgL1R5cGUgL0Fubm90 ID4+DQplbmRvYmoNCjYwIDAgb2JqDQo8PCAvQW5ub3RzIFsgNCAwIFIgNSAwIFIgNiAwIFIg NyAwIFIgOCAwIFIgOSAwIFIgMTAgMCBSIDExIDAgUiAxMiAwIFIgMTMgMCBSIA0KICAxNCAw IFIgMTUgMCBSIDE2IDAgUiAxNyAwIFIgMTggMCBSIDE5IDAgUiAyMCAwIFIgMjEgMCBSIDIy IDAgUiAyMyAwIFIgDQogIDI0IDAgUiAyNSAwIFIgMjYgMCBSIDI3IDAgUiAyOCAwIFIgMjkg MCBSIDMwIDAgUiAzMSAwIFIgMzIgMCBSIDMzIDAgUiANCiAgMzQgMCBSIDM1IDAgUiAzNiAw IFIgMzcgMCBSIDM4IDAgUiAzOSAwIFIgNDAgMCBSIDQxIDAgUiA0MiAwIFIgNDMgMCBSIA0K ICA0NCAwIFIgNDUgMCBSIDQ2IDAgUiA0NyAwIFIgNDggMCBSIDQ5IDAgUiA1MCAwIFIgNTEg MCBSIDUyIDAgUiA1MyAwIFIgDQogIDU0IDAgUiA1NSAwIFIgNTYgMCBSIDU3IDAgUiA1OCAw IFIgNTkgMCBSIF0gL0NvbnRlbnRzIDExNiAwIFIgL01lZGlhQm94IFsgMCAwIDU5NS4yNzU2 IDg0MS44ODk4IF0gL1BhcmVudCAxMTUgMCBSIC9SZXNvdXJjZXMgPDwgL0ZvbnQgMSAwIFIg L1Byb2NTZXQgWyAvUERGIC9UZXh0IC9JbWFnZUIgL0ltYWdlQyAvSW1hZ2VJIF0gPj4gL1Jv dGF0ZSAwIA0KICAvVHJhbnMgPDwgID4+IC9UeXBlIC9QYWdlID4+DQplbmRvYmoNCjYxIDAg b2JqDQo8PCAvQ29udGVudHMgMTE3IDAgUiAvTWVkaWFCb3ggWyAwIDAgNTk1LjI3NTYgODQx Ljg4OTggXSAvUGFyZW50IDExNSAwIFIgL1Jlc291cmNlcyA8PCAvRm9udCAxIDAgUiAvUHJv Y1NldCBbIC9QREYgL1RleHQgL0ltYWdlQiAvSW1hZ2VDIC9JbWFnZUkgXSA+PiAvUm90YXRl IDAgL1RyYW5zIDw8ICA+PiANCiAgL1R5cGUgL1BhZ2UgPj4NCmVuZG9iag0KNjIgMCBvYmoN Cjw8IC9Db250ZW50cyAxMTggMCBSIC9NZWRpYUJveCBbIDAgMCA1OTUuMjc1NiA4NDEuODg5 OCBdIC9QYXJlbnQgMTE1IDAgUiAvUmVzb3VyY2VzIDw8IC9Gb250IDEgMCBSIC9Qcm9jU2V0 IFsgL1BERiAvVGV4dCAvSW1hZ2VCIC9JbWFnZUMgL0ltYWdlSSBdID4+IC9Sb3RhdGUgMCAv VHJhbnMgPDwgID4+IA0KICAvVHlwZSAvUGFnZSA+Pg0KZW5kb2JqDQo2MyAwIG9iag0KPDwg L0Jhc2VGb250IC9IZWx2ZXRpY2EtQm9sZE9ibGlxdWUgL0VuY29kaW5nIC9XaW5BbnNpRW5j b2RpbmcgL05hbWUgL0YzIC9TdWJ0eXBlIC9UeXBlMSAvVHlwZSAvRm9udCA+Pg0KZW5kb2Jq DQo2NCAwIG9iag0KPDwgL0NvbnRlbnRzIDExOSAwIFIgL01lZGlhQm94IFsgMCAwIDU5NS4y NzU2IDg0MS44ODk4IF0gL1BhcmVudCAxMTUgMCBSIC9SZXNvdXJjZXMgPDwgL0ZvbnQgMSAw IFIgL1Byb2NTZXQgWyAvUERGIC9UZXh0IC9JbWFnZUIgL0ltYWdlQyAvSW1hZ2VJIF0gPj4g L1JvdGF0ZSAwIC9UcmFucyA8PCAgPj4gDQogIC9UeXBlIC9QYWdlID4+DQplbmRvYmoNCjY1 IDAgb2JqDQo8PCAvQ29udGVudHMgMTIwIDAgUiAvTWVkaWFCb3ggWyAwIDAgNTk1LjI3NTYg ODQxLjg4OTggXSAvUGFyZW50IDExNSAwIFIgL1Jlc291cmNlcyA8PCAvRm9udCAxIDAgUiAv UHJvY1NldCBbIC9QREYgL1RleHQgL0ltYWdlQiAvSW1hZ2VDIC9JbWFnZUkgXSA+PiAvUm90 YXRlIDAgL1RyYW5zIDw8ICA+PiANCiAgL1R5cGUgL1BhZ2UgPj4NCmVuZG9iag0KNjYgMCBv YmoNCjw8IC9CYXNlRm9udCAvQ291cmllciAvRW5jb2RpbmcgL1dpbkFuc2lFbmNvZGluZyAv TmFtZSAvRjQgL1N1YnR5cGUgL1R5cGUxIC9UeXBlIC9Gb250ID4+DQplbmRvYmoNCjY3IDAg b2JqDQo8PCAvQmFzZUZvbnQgL0hlbHZldGljYS1PYmxpcXVlIC9FbmNvZGluZyAvV2luQW5z aUVuY29kaW5nIC9OYW1lIC9GNSAvU3VidHlwZSAvVHlwZTEgL1R5cGUgL0ZvbnQgPj4NCmVu ZG9iag0KNjggMCBvYmoNCjw8IC9Db250ZW50cyAxMjEgMCBSIC9NZWRpYUJveCBbIDAgMCA1 OTUuMjc1NiA4NDEuODg5OCBdIC9QYXJlbnQgMTE1IDAgUiAvUmVzb3VyY2VzIDw8IC9Gb250 IDEgMCBSIC9Qcm9jU2V0IFsgL1BERiAvVGV4dCAvSW1hZ2VCIC9JbWFnZUMgL0ltYWdlSSBd ID4+IC9Sb3RhdGUgMCAvVHJhbnMgPDwgID4+IA0KICAvVHlwZSAvUGFnZSA+Pg0KZW5kb2Jq DQo2OSAwIG9iag0KPDwgL0NvbnRlbnRzIDEyMiAwIFIgL01lZGlhQm94IFsgMCAwIDU5NS4y NzU2IDg0MS44ODk4IF0gL1BhcmVudCAxMTUgMCBSIC9SZXNvdXJjZXMgPDwgL0ZvbnQgMSAw IFIgL1Byb2NTZXQgWyAvUERGIC9UZXh0IC9JbWFnZUIgL0ltYWdlQyAvSW1hZ2VJIF0gPj4g L1JvdGF0ZSAwIC9UcmFucyA8PCAgPj4gDQogIC9UeXBlIC9QYWdlID4+DQplbmRvYmoNCjcw IDAgb2JqDQo8PCAvQ29udGVudHMgMTIzIDAgUiAvTWVkaWFCb3ggWyAwIDAgNTk1LjI3NTYg ODQxLjg4OTggXSAvUGFyZW50IDExNSAwIFIgL1Jlc291cmNlcyA8PCAvRm9udCAxIDAgUiAv UHJvY1NldCBbIC9QREYgL1RleHQgL0ltYWdlQiAvSW1hZ2VDIC9JbWFnZUkgXSA+PiAvUm90 YXRlIDAgL1RyYW5zIDw8ICA+PiANCiAgL1R5cGUgL1BhZ2UgPj4NCmVuZG9iag0KNzEgMCBv YmoNCjw8IC9Db250ZW50cyAxMjQgMCBSIC9NZWRpYUJveCBbIDAgMCA1OTUuMjc1NiA4NDEu ODg5OCBdIC9QYXJlbnQgMTE1IDAgUiAvUmVzb3VyY2VzIDw8IC9Gb250IDEgMCBSIC9Qcm9j U2V0IFsgL1BERiAvVGV4dCAvSW1hZ2VCIC9JbWFnZUMgL0ltYWdlSSBdID4+IC9Sb3RhdGUg MCAvVHJhbnMgPDwgID4+IA0KICAvVHlwZSAvUGFnZSA+Pg0KZW5kb2JqDQo3MiAwIG9iag0K PDwgL0NvbnRlbnRzIDEyNSAwIFIgL01lZGlhQm94IFsgMCAwIDU5NS4yNzU2IDg0MS44ODk4 IF0gL1BhcmVudCAxMTUgMCBSIC9SZXNvdXJjZXMgPDwgL0ZvbnQgMSAwIFIgL1Byb2NTZXQg WyAvUERGIC9UZXh0IC9JbWFnZUIgL0ltYWdlQyAvSW1hZ2VJIF0gPj4gL1JvdGF0ZSAwIC9U cmFucyA8PCAgPj4gDQogIC9UeXBlIC9QYWdlID4+DQplbmRvYmoNCjczIDAgb2JqDQo8PCAv Q29udGVudHMgMTI2IDAgUiAvTWVkaWFCb3ggWyAwIDAgNTk1LjI3NTYgODQxLjg4OTggXSAv UGFyZW50IDExNSAwIFIgL1Jlc291cmNlcyA8PCAvRm9udCAxIDAgUiAvUHJvY1NldCBbIC9Q REYgL1RleHQgL0ltYWdlQiAvSW1hZ2VDIC9JbWFnZUkgXSA+PiAvUm90YXRlIDAgL1RyYW5z IDw8ICA+PiANCiAgL1R5cGUgL1BhZ2UgPj4NCmVuZG9iag0KNzQgMCBvYmoNCjw8IC9Db250 ZW50cyAxMjcgMCBSIC9NZWRpYUJveCBbIDAgMCA1OTUuMjc1NiA4NDEuODg5OCBdIC9QYXJl bnQgMTE1IDAgUiAvUmVzb3VyY2VzIDw8IC9Gb250IDEgMCBSIC9Qcm9jU2V0IFsgL1BERiAv VGV4dCAvSW1hZ2VCIC9JbWFnZUMgL0ltYWdlSSBdID4+IC9Sb3RhdGUgMCAvVHJhbnMgPDwg ID4+IA0KICAvVHlwZSAvUGFnZSA+Pg0KZW5kb2JqDQo3NSAwIG9iag0KPDwgL0NvbnRlbnRz IDEyOCAwIFIgL01lZGlhQm94IFsgMCAwIDU5NS4yNzU2IDg0MS44ODk4IF0gL1BhcmVudCAx MTUgMCBSIC9SZXNvdXJjZXMgPDwgL0ZvbnQgMSAwIFIgL1Byb2NTZXQgWyAvUERGIC9UZXh0 IC9JbWFnZUIgL0ltYWdlQyAvSW1hZ2VJIF0gPj4gL1JvdGF0ZSAwIC9UcmFucyA8PCAgPj4g DQogIC9UeXBlIC9QYWdlID4+DQplbmRvYmoNCjc2IDAgb2JqDQo8PCAvQSA8PCAvUyAvVVJJ IC9UeXBlIC9BY3Rpb24gL1VSSSAoaHR0cHM6Ly9jcmVhdGl2ZWNvbW1vbnMub3JnL2xpY2Vu c2VzL2J5LzQuMC9sZWdhbGNvZGUpID4+IC9Cb3JkZXIgWyAwIDAgMCBdIC9SZWN0IFsgNjYu MDIyOTEgNDI1LjAyMzYgMzA2LjEyMjkgNDM3LjAyMzYgXSAvU3VidHlwZSAvTGluayAvVHlw ZSAvQW5ub3QgPj4NCmVuZG9iag0KNzcgMCBvYmoNCjw8IC9Bbm5vdHMgWyA3NiAwIFIgXSAv Q29udGVudHMgMTI5IDAgUiAvTWVkaWFCb3ggWyAwIDAgNTk1LjI3NTYgODQxLjg4OTggXSAv UGFyZW50IDExNSAwIFIgL1Jlc291cmNlcyA8PCAvRm9udCAxIDAgUiAvUHJvY1NldCBbIC9Q REYgL1RleHQgL0ltYWdlQiAvSW1hZ2VDIC9JbWFnZUkgXSA+PiAvUm90YXRlIDAgDQogIC9U cmFucyA8PCAgPj4gL1R5cGUgL1BhZ2UgPj4NCmVuZG9iag0KNzggMCBvYmoNCjw8IC9PdXRs aW5lcyA4MCAwIFIgL1BhZ2VMYWJlbHMgMTMwIDAgUiAvUGFnZU1vZGUgL1VzZU5vbmUgL1Bh Z2VzIDExNSAwIFIgL1R5cGUgL0NhdGFsb2cgPj4NCmVuZG9iag0KNzkgMCBvYmoNCjw8IC9B dXRob3IgKCkgL0NyZWF0aW9uRGF0ZSAoRDoyMDIxMDMxNjAzMzQyMCswMCcwMCcpIC9DcmVh dG9yIChcKHVuc3BlY2lmaWVkXCkpIC9LZXl3b3JkcyAoKSAvTW9kRGF0ZSAoRDoyMDIxMDMx NjAzMzQyMCswMCcwMCcpIC9Qcm9kdWNlciAoUmVwb3J0TGFiIFBERiBMaWJyYXJ5IC0gd3d3 LnJlcG9ydGxhYi5jb20pIA0KICAvU3ViamVjdCAoXCh1bnNwZWNpZmllZFwpKSAvVGl0bGUg KEh5cGVybGF1bmNoIERlc2lnbiBEb2N1bWVudCkgL1RyYXBwZWQgL0ZhbHNlID4+DQplbmRv YmoNCjgwIDAgb2JqDQo8PCAvQ291bnQgNDIgL0ZpcnN0IDgxIDAgUiAvTGFzdCAxMTAgMCBS IC9UeXBlIC9PdXRsaW5lcyA+Pg0KZW5kb2JqDQo4MSAwIG9iag0KPDwgL0Rlc3QgWyA2MCAw IFIgL1hZWiA2Mi42OTI5MSAxODYuMDIzNiAwIF0gL05leHQgODIgMCBSIC9QYXJlbnQgODAg MCBSIC9UaXRsZSAoXDM3NlwzNzdcMDAwMVwwMDBcMjQwXDAwMFwyNDBcMDAwXDI0MFwwMDBJ XDAwMG5cMDAwdFwwMDByXDAwMG9cMDAwZFwwMDB1XDAwMGNcMDAwdFwwMDBpXDAwMG9cMDAw bikgPj4NCmVuZG9iag0KODIgMCBvYmoNCjw8IC9Db3VudCAxIC9EZXN0IFsgNjEgMCBSIC9Y WVogNjIuNjkyOTEgNjk5LjAyMzYgMCBdIC9GaXJzdCA4MyAwIFIgL0xhc3QgODMgMCBSIC9O ZXh0IDg0IDAgUiAvUGFyZW50IDgwIDAgUiANCiAgL1ByZXYgODEgMCBSIC9UaXRsZSAoXDM3 NlwzNzdcMDAwMlwwMDBcMjQwXDAwMFwyNDBcMDAwXDI0MFwwMDBBXDAwMHBcMDAwcFwwMDBy XDAwMG9cMDAwYVwwMDBjXDAwMGgpID4+DQplbmRvYmoNCjgzIDAgb2JqDQo8PCAvRGVzdCBb IDYxIDAgUiAvWFlaIDYyLjY5MjkxIDQ5Mi4wMjM2IDAgXSAvUGFyZW50IDgyIDAgUiAvVGl0 bGUgKFwzNzZcMzc3XDAwMDJcMDAwLlwwMDAxXDAwMFwyNDBcMDAwXDI0MFwwMDBcMjQwXDAw ME9cMDAwYlwwMDBqXDAwMGVcMDAwY1wwMDB0XDAwMGlcMDAwdlwwMDBlXDAwMHMpID4+DQpl bmRvYmoNCjg0IDAgb2JqDQo8PCAvQ291bnQgMjUgL0Rlc3QgWyA2MiAwIFIgL1hZWiA2Mi42 OTI5MSA3NjUuMDIzNiAwIF0gL0ZpcnN0IDg1IDAgUiAvTGFzdCAxMDEgMCBSIC9OZXh0IDEx MCAwIFIgL1BhcmVudCA4MCAwIFIgDQogIC9QcmV2IDgyIDAgUiAvVGl0bGUgKFwzNzZcMzc3 XDAwMDNcMDAwXDI0MFwwMDBcMjQwXDAwMFwyNDBcMDAwUlwwMDBlXDAwMHFcMDAwdVwwMDBp XDAwMHJcMDAwZVwwMDBtXDAwMGVcMDAwblwwMDB0XDAwMHNcMDAwIFwwMDBhXDAwMG5cMDAw ZFwwMDAgXDAwMERcMDAwZVwwMDBzXDAwMGlcMDAwZ1wwMDBuKSA+Pg0KZW5kb2JqDQo4NSAw IG9iag0KPDwgL0Rlc3QgWyA2MiAwIFIgL1hZWiA2Mi42OTI5MSA2MzAuMDIzNiAwIF0gL05l eHQgODYgMCBSIC9QYXJlbnQgODQgMCBSIC9UaXRsZSAoXDM3NlwzNzdcMDAwM1wwMDAuXDAw MDFcMDAwXDI0MFwwMDBcMjQwXDAwMFwyNDBcMDAwTFwwMDBhXDAwMG5cMDAwZFwwMDBzXDAw MGNcMDAwYVwwMDBwXDAwMGUpID4+DQplbmRvYmoNCjg2IDAgb2JqDQo8PCAvRGVzdCBbIDY0 IDAgUiAvWFlaIDYyLjY5MjkxIDc2NS4wMjM2IDAgXSAvTmV4dCA4NyAwIFIgL1BhcmVudCA4 NCAwIFIgL1ByZXYgODUgMCBSIC9UaXRsZSAoXDM3NlwzNzdcMDAwM1wwMDAuXDAwMDJcMDAw XDI0MFwwMDBcMjQwXDAwMFwyNDBcMDAwRFwwMDBvXDAwMG1cMDAwYVwwMDBpXDAwMG5cMDAw IFwwMDBjXDAwMG9cMDAwblwwMDBzXDAwMHRcMDAwclwwMDB1XDAwMGNcMDAwdFwwMDBpXDAw MG9cMDAwbikgPj4NCmVuZG9iag0KODcgMCBvYmoNCjw8IC9Db3VudCA3IC9EZXN0IFsgNjQg MCBSIC9YWVogNjIuNjkyOTEgNjM5LjAyMzYgMCBdIC9GaXJzdCA4OCAwIFIgL0xhc3QgOTEg MCBSIC9OZXh0IDk1IDAgUiAvUGFyZW50IDg0IDAgUiANCiAgL1ByZXYgODYgMCBSIC9UaXRs ZSAoXDM3NlwzNzdcMDAwM1wwMDAuXDAwMDNcMDAwXDI0MFwwMDBcMjQwXDAwMFwyNDBcMDAw Q1wwMDBvXDAwMG1cMDAwbVwwMDBvXDAwMG5cMDAwIFwwMDBCXDAwMG9cMDAwb1wwMDB0XDAw MCBcMDAwQ1wwMDBvXDAwMG5cMDAwZlwwMDBpXDAwMGdcMDAwdVwwMDByXDAwMGFcMDAwdFww MDBpXDAwMG9cMDAwblwwMDBzKSA+Pg0KZW5kb2JqDQo4OCAwIG9iag0KPDwgL0Rlc3QgWyA2 NCAwIFIgL1hZWiA2Mi42OTI5MSA1NTUuMDIzNiAwIF0gL05leHQgODkgMCBSIC9QYXJlbnQg ODcgMCBSIC9UaXRsZSAoXDM3NlwzNzdcMDAwM1wwMDAuXDAwMDNcMDAwLlwwMDAxXDAwMFwy NDBcMDAwXDI0MFwwMDBcMjQwXDAwMERcMDAweVwwMDBuXDAwMGFcMDAwbVwwMDBpXDAwMGNc MDAwIFwwMDBMXDAwMGFcMDAwdVwwMDBuXDAwMGNcMDAwaFwwMDAgXDAwMHdcMDAwaVwwMDB0 XDAwMGhcMDAwIFwwMDBhXDAwMCBcMDAwSFwwMDBpXDAwMGdcMDAwaFwwMDBsXDAwMHlcMDAw LVwwMDBQXDAwMHJcMDAwaVwwMDB2XDAwMGlcMDAwbFwwMDBlXDAwMGdcMDAwZVwwMDBkXDAw MCBcMDAwRFwwMDBvXDAwMG1cMDAwYVwwMDBpXDAwMG5cMDAwIFwwMDAwKSA+Pg0KZW5kb2Jq DQo4OSAwIG9iag0KPDwgL0Rlc3QgWyA2NCAwIFIgL1hZWiA2Mi42OTI5MSAzMzAuMDIzNiAw IF0gL05leHQgOTAgMCBSIC9QYXJlbnQgODcgMCBSIC9QcmV2IDg4IDAgUiAvVGl0bGUgKFwz NzZcMzc3XDAwMDNcMDAwLlwwMDAzXDAwMC5cMDAwMlwwMDBcMjQwXDAwMFwyNDBcMDAwXDI0 MFwwMDBTXDAwMHRcMDAwYVwwMDB0XDAwMGlcMDAwY1wwMDAgXDAwMExcMDAwYVwwMDB1XDAw MG5cMDAwY1wwMDBoXDAwMCBcMDAwQ1wwMDBvXDAwMG5cMDAwZlwwMDBpXDAwMGdcMDAwdVww MDByXDAwMGFcMDAwdFwwMDBpXDAwMG9cMDAwblwwMDBzXDAwMDpcMDAwIFwwMDB3XDAwMGlc MDAwdFwwMDBoXDAwMG9cMDAwdVwwMDB0XDAwMCBcMDAwYVwwMDAgXDAwMERcMDAwb1wwMDBt XDAwMGFcMDAwaVwwMDBuXDAwMCBcMDAwMFwwMDAgXDAwMG9cMDAwclwwMDAgXDAwMGFcMDAw IFwwMDBDXDAwMG9cMDAwblwwMDB0XDAwMHJcMDAwb1wwMDBsXDAwMCBcMDAwRFwwMDBvXDAw MG1cMDAwYVwwMDBpXDAwMG4pID4+DQplbmRvYmoNCjkwIDAgb2JqDQo8PCAvRGVzdCBbIDY0 IDAgUiAvWFlaIDYyLjY5MjkxIDEzNi4wMjM2IDAgXSAvTmV4dCA5MSAwIFIgL1BhcmVudCA4 NyAwIFIgL1ByZXYgODkgMCBSIC9UaXRsZSAoXDM3NlwzNzdcMDAwM1wwMDAuXDAwMDNcMDAw LlwwMDAzXDAwMFwyNDBcMDAwXDI0MFwwMDBcMjQwXDAwMERcMDAweVwwMDBuXDAwMGFcMDAw bVwwMDBpXDAwMGNcMDAwIFwwMDBMXDAwMGFcMDAwdVwwMDBuXDAwMGNcMDAwaFwwMDAgXDAw MG9cMDAwZlwwMDAgXDAwMERcMDAwaVwwMDBzXDAwMGFcMDAwZ1wwMDBnXDAwMHJcMDAwZVww MDBnXDAwMGFcMDAwdFwwMDBlXDAwMGRcMDAwIFwwMDBTXDAwMHlcMDAwc1wwMDB0XDAwMGVc MDAwbVwwMDAgXDAwMENcMDAwb1wwMDBuXDAwMGZcMDAwaVwwMDBnXDAwMHVcMDAwclwwMDBh XDAwMHRcMDAwaVwwMDBvXDAwMG5cMDAwcykgPj4NCmVuZG9iag0KOTEgMCBvYmoNCjw8IC9D b3VudCAzIC9EZXN0IFsgNjUgMCBSIC9YWVogNjIuNjkyOTEgNjA0LjAyMzYgMCBdIC9GaXJz dCA5MiAwIFIgL0xhc3QgOTQgMCBSIC9QYXJlbnQgODcgMCBSIC9QcmV2IDkwIDAgUiANCiAg L1RpdGxlIChcMzc2XDM3N1wwMDAzXDAwMC5cMDAwM1wwMDAuXDAwMDRcMDAwXDI0MFwwMDBc MjQwXDAwMFwyNDBcMDAwRVwwMDB4XDAwMGFcMDAwbVwwMDBwXDAwMGxcMDAwZVwwMDAgXDAw MFVcMDAwc1wwMDBlXDAwMCBcMDAwQ1wwMDBhXDAwMHNcMDAwZVwwMDBzXDAwMCBcMDAwYVww MDBuXDAwMGRcMDAwIFwwMDBDXDAwMG9cMDAwblwwMDBmXDAwMGlcMDAwZ1wwMDB1XDAwMHJc MDAwYVwwMDB0XDAwMGlcMDAwb1wwMDBuXDAwMHMpID4+DQplbmRvYmoNCjkyIDAgb2JqDQo8 PCAvRGVzdCBbIDY1IDAgUiAvWFlaIDYyLjY5MjkxIDU1OS4wMjM2IDAgXSAvTmV4dCA5MyAw IFIgL1BhcmVudCA5MSAwIFIgL1RpdGxlIChcMzc2XDM3N1wwMDAzXDAwMC5cMDAwM1wwMDAu XDAwMDRcMDAwLlwwMDAxXDAwMFwyNDBcMDAwXDI0MFwwMDBcMjQwXDAwMFVcMDAwc1wwMDBl XDAwMCBcMDAwY1wwMDBhXDAwMHNcMDAwZVwwMDA6XDAwMCBcMDAwTVwwMDBvXDAwMGRcMDAw ZVwwMDByXDAwMG5cMDAwIFwwMDBjXDAwMGxcMDAwb1wwMDB1XDAwMGRcMDAwIFwwMDBoXDAw MHlcMDAwcFwwMDBlXDAwMHJcMDAwdlwwMDBpXDAwMHNcMDAwb1wwMDByKSA+Pg0KZW5kb2Jq DQo5MyAwIG9iag0KPDwgL0Rlc3QgWyA2NSAwIFIgL1hZWiA2Mi42OTI5MSA0NzUuMDIzNiAw IF0gL05leHQgOTQgMCBSIC9QYXJlbnQgOTEgMCBSIC9QcmV2IDkyIDAgUiAvVGl0bGUgKFwz NzZcMzc3XDAwMDNcMDAwLlwwMDAzXDAwMC5cMDAwNFwwMDAuXDAwMDJcMDAwXDI0MFwwMDBc MjQwXDAwMFwyNDBcMDAwVVwwMDBzXDAwMGVcMDAwIFwwMDBjXDAwMGFcMDAwc1wwMDBlXDAw MDpcMDAwIFwwMDBFXDAwMGRcMDAwZ1wwMDBlXDAwMCBcMDAwZFwwMDBlXDAwMHZcMDAwaVww MDBjXDAwMGVcMDAwIFwwMDB3XDAwMGlcMDAwdFwwMDBoXDAwMCBcMDAwc1wwMDBlXDAwMGNc MDAwdVwwMDByXDAwMGlcMDAwdFwwMDB5XDAwMCBcMDAwb1wwMDByXDAwMCBcMDAwc1wwMDBh XDAwMGZcMDAwZVwwMDB0XDAwMHlcMDAwIFwwMDByXDAwMGVcMDAwcVwwMDB1XDAwMGlcMDAw clwwMDBlXDAwMG1cMDAwZVwwMDBuXDAwMHRcMDAwcykgPj4NCmVuZG9iag0KOTQgMCBvYmoN Cjw8IC9EZXN0IFsgNjUgMCBSIC9YWVogNjIuNjkyOTEgNDAzLjAyMzYgMCBdIC9QYXJlbnQg OTEgMCBSIC9QcmV2IDkzIDAgUiAvVGl0bGUgKFwzNzZcMzc3XDAwMDNcMDAwLlwwMDAzXDAw MC5cMDAwNFwwMDAuXDAwMDNcMDAwXDI0MFwwMDBcMjQwXDAwMFwyNDBcMDAwVVwwMDBzXDAw MGVcMDAwIFwwMDBjXDAwMGFcMDAwc1wwMDBlXDAwMDpcMDAwIFwwMDBDXDAwMGxcMDAwaVww MDBlXDAwMG5cMDAwdFwwMDAgXDAwMGhcMDAweVwwMDBwXDAwMGVcMDAwclwwMDB2XDAwMGlc MDAwc1wwMDBvXDAwMHIpID4+DQplbmRvYmoNCjk1IDAgb2JqDQo8PCAvRGVzdCBbIDY1IDAg UiAvWFlaIDYyLjY5MjkxIDMwMS4wMjM2IDAgXSAvTmV4dCA5NiAwIFIgL1BhcmVudCA4NCAw IFIgL1ByZXYgODcgMCBSIC9UaXRsZSAoXDM3NlwzNzdcMDAwM1wwMDAuXDAwMDRcMDAwXDI0 MFwwMDBcMjQwXDAwMFwyNDBcMDAwaFwwMDB5XDAwMHBcMDAwZVwwMDByXDAwMGxcMDAwYVww MDB1XDAwMG5cMDAwY1wwMDBoXDAwMCBcMDAwRFwwMDBpXDAwMHNcMDAwYVwwMDBnXDAwMGdc MDAwclwwMDBlXDAwMGdcMDAwYVwwMDB0XDAwMGVcMDAwZFwwMDAgXDAwMExcMDAwYVwwMDB1 XDAwMG5cMDAwY1wwMDBoKSA+Pg0KZW5kb2JqDQo5NiAwIG9iag0KPDwgL0NvdW50IDQgL0Rl c3QgWyA2OCAwIFIgL1hZWiA2Mi42OTI5MSA0MzUuMDIzNiAwIF0gL0ZpcnN0IDk3IDAgUiAv TGFzdCA5NyAwIFIgL05leHQgMTAxIDAgUiAvUGFyZW50IDg0IDAgUiANCiAgL1ByZXYgOTUg MCBSIC9UaXRsZSAoXDM3NlwzNzdcMDAwM1wwMDAuXDAwMDVcMDAwXDI0MFwwMDBcMjQwXDAw MFwyNDBcMDAwT1wwMDB2XDAwMGVcMDAwclwwMDB2XDAwMGlcMDAwZVwwMDB3XDAwMCBcMDAw b1wwMDBmXDAwMCBcMDAwaFwwMDB5XDAwMHBcMDAwZVwwMDByXDAwMGxcMDAwYVwwMDB1XDAw MG5cMDAwY1wwMDBoXDAwMCBcMDAwRlwwMDBsXDAwMG9cMDAwdykgPj4NCmVuZG9iag0KOTcg MCBvYmoNCjw8IC9Db3VudCAzIC9EZXN0IFsgNjkgMCBSIC9YWVogNjIuNjkyOTEgNzY1LjAy MzYgMCBdIC9GaXJzdCA5OCAwIFIgL0xhc3QgMTAwIDAgUiAvUGFyZW50IDk2IDAgUiAvVGl0 bGUgKFwzNzZcMzc3XDAwMDNcMDAwLlwwMDA1XDAwMC5cMDAwMVwwMDBcMjQwXDAwMFwyNDBc MDAwXDI0MFwwMDBoXDAwMHlcMDAwcFwwMDBlXDAwMHJcMDAwbFwwMDBhXDAwMHVcMDAwblww MDBjXDAwMGhcMDAwIFwwMDBYXDAwMGVcMDAwblwwMDAgXDAwMHNcMDAwdFwwMDBhXDAwMHJc MDAwdFwwMDB1XDAwMHApID4+DQplbmRvYmoNCjk4IDAgb2JqDQo8PCAvRGVzdCBbIDY5IDAg UiAvWFlaIDYyLjY5MjkxIDUyMi4wMjM2IDAgXSAvTmV4dCA5OSAwIFIgL1BhcmVudCA5NyAw IFIgL1RpdGxlIChcMzc2XDM3N1wwMDAzXDAwMC5cMDAwNVwwMDAuXDAwMDFcMDAwLlwwMDAx XDAwMFwyNDBcMDAwXDI0MFwwMDBcMjQwXDAwMERcMDAwb1wwMDBtXDAwMGFcMDAwaVwwMDBu XDAwMCBcMDAwQ1wwMDByXDAwMGVcMDAwYVwwMDB0XDAwMGlcMDAwb1wwMDBuKSA+Pg0KZW5k b2JqDQo5OSAwIG9iag0KPDwgL0Rlc3QgWyA2OSAwIFIgL1hZWiA2Mi42OTI5MSA0MDguMDIz NiAwIF0gL05leHQgMTAwIDAgUiAvUGFyZW50IDk3IDAgUiAvUHJldiA5OCAwIFIgL1RpdGxl IChcMzc2XDM3N1wwMDAzXDAwMC5cMDAwNVwwMDAuXDAwMDFcMDAwLlwwMDAyXDAwMFwyNDBc MDAwXDI0MFwwMDBcMjQwXDAwMERcMDAwb1wwMDBtXDAwMGFcMDAwaVwwMDBuXDAwMCBcMDAw UFwwMDByXDAwMGVcMDAwcFwwMDBhXDAwMHJcMDAwYVwwMDB0XDAwMGlcMDAwb1wwMDBuXDAw MCBcMDAwUFwwMDBoXDAwMGFcMDAwc1wwMDBlKSA+Pg0KZW5kb2JqDQoxMDAgMCBvYmoNCjw8 IC9EZXN0IFsgNjkgMCBSIC9YWVogNjIuNjkyOTEgMjI4LjAyMzYgMCBdIC9QYXJlbnQgOTcg MCBSIC9QcmV2IDk5IDAgUiAvVGl0bGUgKFwzNzZcMzc3XDAwMDNcMDAwLlwwMDA1XDAwMC5c MDAwMVwwMDAuXDAwMDNcMDAwXDI0MFwwMDBcMjQwXDAwMFwyNDBcMDAwTFwwMDBhXDAwMHVc MDAwblwwMDBjXDAwMGhcMDAwIFwwMDBGXDAwMGlcMDAwblwwMDBhXDAwMGxcMDAwaVwwMDB6 XDAwMGFcMDAwdFwwMDBpXDAwMG9cMDAwbikgPj4NCmVuZG9iag0KMTAxIDAgb2JqDQo8PCAv Q291bnQgOCAvRGVzdCBbIDcwIDAgUiAvWFlaIDYyLjY5MjkxIDY5My4wMjM2IDAgXSAvRmly c3QgMTAyIDAgUiAvTGFzdCAxMDkgMCBSIC9QYXJlbnQgODQgMCBSIC9QcmV2IDk2IDAgUiAN CiAgL1RpdGxlIChcMzc2XDM3N1wwMDAzXDAwMC5cMDAwNlwwMDBcMjQwXDAwMFwyNDBcMDAw XDI0MFwwMDBTXDAwMHRcMDAwclwwMDB1XDAwMGNcMDAwdFwwMDB1XDAwMHJcMDAwaVwwMDBu XDAwMGdcMDAwIFwwMDBvXDAwMGZcMDAwIFwwMDBIXDAwMHlcMDAwcFwwMDBlXDAwMHJcMDAw bFwwMDBhXDAwMHVcMDAwblwwMDBjXDAwMGgpID4+DQplbmRvYmoNCjEwMiAwIG9iag0KPDwg L0Rlc3QgWyA3MCAwIFIgL1hZWiA2Mi42OTI5MSA1ODUuMDIzNiAwIF0gL05leHQgMTAzIDAg UiAvUGFyZW50IDEwMSAwIFIgL1RpdGxlIChcMzc2XDM3N1wwMDAzXDAwMC5cMDAwNlwwMDAu XDAwMDFcMDAwXDI0MFwwMDBcMjQwXDAwMFwyNDBcMDAweFwwMDA4XDAwMDZcMDAwIFwwMDBN XDAwMHVcMDAwbFwwMDB0XDAwMGlcMDAwYlwwMDBvXDAwMG9cMDAwdFwwMDAyKSA+Pg0KZW5k b2JqDQoxMDMgMCBvYmoNCjw8IC9EZXN0IFsgNzAgMCBSIC9YWVogNjIuNjkyOTEgMjUyLjAy MzYgMCBdIC9OZXh0IDEwNCAwIFIgL1BhcmVudCAxMDEgMCBSIC9QcmV2IDEwMiAwIFIgL1Rp dGxlIChcMzc2XDM3N1wwMDAzXDAwMC5cMDAwNlwwMDAuXDAwMDJcMDAwXDI0MFwwMDBcMjQw XDAwMFwyNDBcMDAwQVwwMDByXDAwMG1cMDAwIFwwMDBEXDAwMGVcMDAwdlwwMDBpXDAwMGNc MDAwZVwwMDAgXDAwMFRcMDAwclwwMDBlXDAwMGUpID4+DQplbmRvYmoNCjEwNCAwIG9iag0K PDwgL0Rlc3QgWyA3MSAwIFIgL1hZWiA2Mi42OTI5MSA3NjUuMDIzNiAwIF0gL05leHQgMTA1 IDAgUiAvUGFyZW50IDEwMSAwIFIgL1ByZXYgMTAzIDAgUiAvVGl0bGUgKFwzNzZcMzc3XDAw MDNcMDAwLlwwMDA2XDAwMC5cMDAwM1wwMDBcMjQwXDAwMFwyNDBcMDAwXDI0MFwwMDBYXDAw MGVcMDAwblwwMDAgXDAwMGhcMDAweVwwMDBwXDAwMGVcMDAwclwwMDB2XDAwMGlcMDAwc1ww MDBvXDAwMHIpID4+DQplbmRvYmoNCjEwNSAwIG9iag0KPDwgL0Rlc3QgWyA3MSAwIFIgL1hZ WiA2Mi42OTI5MSA2NDguMDIzNiAwIF0gL05leHQgMTA2IDAgUiAvUGFyZW50IDEwMSAwIFIg L1ByZXYgMTA0IDAgUiAvVGl0bGUgKFwzNzZcMzc3XDAwMDNcMDAwLlwwMDA2XDAwMC5cMDAw NFwwMDBcMjQwXDAwMFwyNDBcMDAwXDI0MFwwMDBCXDAwMG9cMDAwb1wwMDB0XDAwMCBcMDAw RFwwMDBvXDAwMG1cMDAwYVwwMDBpXDAwMG4pID4+DQplbmRvYmoNCjEwNiAwIG9iag0KPDwg L0Rlc3QgWyA3MSAwIFIgL1hZWiA2Mi42OTI5MSA1NDMuMDIzNiAwIF0gL05leHQgMTA3IDAg UiAvUGFyZW50IDEwMSAwIFIgL1ByZXYgMTA1IDAgUiAvVGl0bGUgKFwzNzZcMzc3XDAwMDNc MDAwLlwwMDA2XDAwMC5cMDAwNVwwMDBcMjQwXDAwMFwyNDBcMDAwXDI0MFwwMDBDXDAwMHJc MDAwYVwwMDBzXDAwMGhcMDAwIFwwMDBEXDAwMG9cMDAwbVwwMDBhXDAwMGlcMDAwbikgPj4N CmVuZG9iag0KMTA3IDAgb2JqDQo8PCAvRGVzdCBbIDcxIDAgUiAvWFlaIDYyLjY5MjkxIDQz OC4wMjM2IDAgXSAvTmV4dCAxMDggMCBSIC9QYXJlbnQgMTAxIDAgUiAvUHJldiAxMDYgMCBS IC9UaXRsZSAoXDM3NlwzNzdcMDAwM1wwMDAuXDAwMDZcMDAwLlwwMDA2XDAwMFwyNDBcMDAw XDI0MFwwMDBcMjQwXDAwMENcMDAwb1wwMDBuXDAwMHRcMDAwclwwMDBvXDAwMGxcMDAwIFww MDBEXDAwMG9cMDAwbVwwMDBhXDAwMGlcMDAwbikgPj4NCmVuZG9iag0KMTA4IDAgb2JqDQo8 PCAvRGVzdCBbIDcxIDAgUiAvWFlaIDYyLjY5MjkxIDM1Ny4wMjM2IDAgXSAvTmV4dCAxMDkg MCBSIC9QYXJlbnQgMTAxIDAgUiAvUHJldiAxMDcgMCBSIC9UaXRsZSAoXDM3NlwzNzdcMDAw M1wwMDAuXDAwMDZcMDAwLlwwMDA3XDAwMFwyNDBcMDAwXDI0MFwwMDBcMjQwXDAwMEhcMDAw YVwwMDByXDAwMGRcMDAwd1wwMDBhXDAwMHJcMDAwZVwwMDAgXDAwMERcMDAwb1wwMDBtXDAw MGFcMDAwaVwwMDBuKSA+Pg0KZW5kb2JqDQoxMDkgMCBvYmoNCjw8IC9EZXN0IFsgNzEgMCBS IC9YWVogNjIuNjkyOTEgMjY0LjAyMzYgMCBdIC9QYXJlbnQgMTAxIDAgUiAvUHJldiAxMDgg MCBSIC9UaXRsZSAoXDM3NlwzNzdcMDAwM1wwMDAuXDAwMDZcMDAwLlwwMDA4XDAwMFwyNDBc MDAwXDI0MFwwMDBcMjQwXDAwMENcMDAwb1wwMDBuXDAwMHNcMDAwb1wwMDBsXDAwMGVcMDAw IFwwMDBEXDAwMG9cMDAwbVwwMDBhXDAwMGlcMDAwbikgPj4NCmVuZG9iag0KMTEwIDAgb2Jq DQo8PCAvQ291bnQgNCAvRGVzdCBbIDcyIDAgUiAvWFlaIDYyLjY5MjkxIDc2NS4wMjM2IDAg XSAvRmlyc3QgMTExIDAgUiAvTGFzdCAxMTQgMCBSIC9QYXJlbnQgODAgMCBSIC9QcmV2IDg0 IDAgUiANCiAgL1RpdGxlIChcMzc2XDM3N1wwMDA0XDAwMFwyNDBcMDAwXDI0MFwwMDBcMjQw XDAwMEFcMDAwcFwwMDBwXDAwMGVcMDAwblwwMDBkXDAwMGlcMDAweCkgPj4NCmVuZG9iag0K MTExIDAgb2JqDQo8PCAvRGVzdCBbIDcyIDAgUiAvWFlaIDYyLjY5MjkxIDczMi4wMjM2IDAg XSAvTmV4dCAxMTIgMCBSIC9QYXJlbnQgMTEwIDAgUiAvVGl0bGUgKFwzNzZcMzc3XDAwMDRc MDAwLlwwMDAxXDAwMFwyNDBcMDAwXDI0MFwwMDBcMjQwXDAwMEFcMDAwcFwwMDBwXDAwMGVc MDAwblwwMDBkXDAwMGlcMDAweFwwMDAgXDAwMDFcMDAwOlwwMDAgXDAwMEZcMDAwbFwwMDBv XDAwMHdcMDAwIFwwMDBTXDAwMGVcMDAwcVwwMDB1XDAwMGVcMDAwblwwMDBjXDAwMGVcMDAw IFwwMDBvXDAwMGZcMDAwIFwwMDBTXDAwMHRcMDAwZVwwMDBwXDAwMHNcMDAwIFwwMDBvXDAw MGZcMDAwIFwwMDBhXDAwMCBcMDAwaFwwMDB5XDAwMHBcMDAwZVwwMDByXDAwMGxcMDAwYVww MDB1XDAwMG5cMDAwY1wwMDBoXDAwMCBcMDAwQlwwMDBvXDAwMG9cMDAwdCkgPj4NCmVuZG9i ag0KMTEyIDAgb2JqDQo8PCAvRGVzdCBbIDcyIDAgUiAvWFlaIDYyLjY5MjkxIDEyMi44MjM2 IDAgXSAvTmV4dCAxMTMgMCBSIC9QYXJlbnQgMTEwIDAgUiAvUHJldiAxMTEgMCBSIC9UaXRs ZSAoXDM3NlwzNzdcMDAwNFwwMDAuXDAwMDJcMDAwXDI0MFwwMDBcMjQwXDAwMFwyNDBcMDAw QVwwMDBwXDAwMHBcMDAwZVwwMDBuXDAwMGRcMDAwaVwwMDB4XDAwMCBcMDAwMlwwMDA6XDAw MCBcMDAwQ1wwMDBvXDAwMG5cMDAwc1wwMDBpXDAwMGRcMDAwZVwwMDByXDAwMGFcMDAwdFww MDBpXDAwMG9cMDAwblwwMDBzXDAwMCBcMDAwaVwwMDBuXDAwMCBcMDAwTlwwMDBhXDAwMG1c MDAwaVwwMDBuXDAwMGdcMDAwIFwwMDB0XDAwMGhcMDAwZVwwMDAgXDAwMEhcMDAweVwwMDBw XDAwMGVcMDAwclwwMDBsXDAwMGFcMDAwdVwwMDBuXDAwMGNcMDAwaFwwMDAgXDAwMEZcMDAw ZVwwMDBhXDAwMHRcMDAwdVwwMDByXDAwMGUpID4+DQplbmRvYmoNCjExMyAwIG9iag0KPDwg L0Rlc3QgWyA3NSAwIFIgL1hZWiA2Mi42OTI5MSA3MTEuMDIzNiAwIF0gL05leHQgMTE0IDAg UiAvUGFyZW50IDExMCAwIFIgL1ByZXYgMTEyIDAgUiAvVGl0bGUgKFwzNzZcMzc3XDAwMDRc MDAwLlwwMDAzXDAwMFwyNDBcMDAwXDI0MFwwMDBcMjQwXDAwMEFcMDAwcFwwMDBwXDAwMGVc MDAwblwwMDBkXDAwMGlcMDAweFwwMDAgXDAwMDNcMDAwOlwwMDAgXDAwMFRcMDAwZVwwMDBy XDAwMG1cMDAwaVwwMDBuXDAwMG9cMDAwbFwwMDBvXDAwMGdcMDAweSkgPj4NCmVuZG9iag0K MTE0IDAgb2JqDQo8PCAvRGVzdCBbIDc3IDAgUiAvWFlaIDYyLjY5MjkxIDQ4NS4wMjM2IDAg XSAvUGFyZW50IDExMCAwIFIgL1ByZXYgMTEzIDAgUiAvVGl0bGUgKFwzNzZcMzc3XDAwMDRc MDAwLlwwMDA0XDAwMFwyNDBcMDAwXDI0MFwwMDBcMjQwXDAwMEFcMDAwcFwwMDBwXDAwMGVc MDAwblwwMDBkXDAwMGlcMDAweFwwMDAgXDAwMDRcMDAwOlwwMDAgXDAwMENcMDAwb1wwMDBw XDAwMHlcMDAwclwwMDBpXDAwMGdcMDAwaFwwMDB0XDAwMCBcMDAwTFwwMDBpXDAwMGNcMDAw ZVwwMDBuXDAwMHNcMDAwZSkgPj4NCmVuZG9iag0KMTE1IDAgb2JqDQo8PCAvQ291bnQgMTQg L0tpZHMgWyA2MCAwIFIgNjEgMCBSIDYyIDAgUiA2NCAwIFIgNjUgMCBSIDY4IDAgUiA2OSAw IFIgNzAgMCBSIDcxIDAgUiA3MiAwIFIgDQogIDczIDAgUiA3NCAwIFIgNzUgMCBSIDc3IDAg UiBdIC9UeXBlIC9QYWdlcyA+Pg0KZW5kb2JqDQoxMTYgMCBvYmoNCjw8IC9MZW5ndGggODgx OCA+Pg0Kc3RyZWFtDQoxIDAgMCAxIDAgMCBjbSAgQlQgL0YxIDEyIFRmIDE0LjQgVEwgRVQN CnENCjEgMCAwIDEgNjIuNjkyOTEgNzQxLjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAg MCAxIDAgNCBUbSAvRjIgMjAgVGYgMjQgVEwgODYuNTg0ODggMCBUZCAoSHlwZXJsYXVuY2gg RGVzaWduIERvY3VtZW50KSBUaiBUKiAtODYuNTg0ODggMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAw IDAgMSA2Mi42OTI5MSA3MDguMDIzNiBjbQ0KcQ0KQlQgMSAwIDAgMSAwIDMuNSBUbSAyMSBU TCAvRjIgMTcuNSBUZiAwIDAgMCByZyAoQ29udGVudHMpIFRqIFQqIEVUDQpRDQpRDQpxDQox IDAgMCAxIDYyLjY5MjkxIDE5OC4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEy IFRMIEVUDQpxDQoxIDAgMCAxIDAgNDg5IGNtDQpxDQpCVCAxIDAgMCAxIDAgMiBUbSAxMiBU TCAvRjIgMTAgVGYgMCAwIC41MDE5NjEgcmcgKDEgICBJbnRyb2R1Y3Rpb24pIFRqIFQqIEVU DQpRDQpRDQpxDQoxIDAgMCAxIDM5Ny44ODk4IDQ4OSBjbQ0KcQ0KMCAwIC41MDE5NjEgcmcN CjAgMCAuNTAxOTYxIFJHDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIgVEwgNjYu NDQgMCBUZCAoMSkgVGogVCogLTY2LjQ0IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMCA0 NzEgY20NCnENCkJUIDEgMCAwIDEgMCAyIFRtIDEyIFRMIC9GMiAxMCBUZiAwIDAgLjUwMTk2 MSByZyAoMiAgIEFwcHJvYWNoKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzOTcuODg5 OCA0NzEgY20NCnENCjAgMCAuNTAxOTYxIHJnDQowIDAgLjUwMTk2MSBSRw0KQlQgMSAwIDAg MSAwIDIgVG0gL0YyIDEwIFRmIDEyIFRMIDY2LjQ0IDAgVGQgKDIpIFRqIFQqIC02Ni40NCAw IFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDAgNDUzIGNtDQpxDQpCVCAxIDAgMCAxIDIwIDIg VG0gMTIgVEwgL0YxIDEwIFRmIDAgMCAuNTAxOTYxIHJnICgyLjEgICBPYmplY3RpdmVzKSBU aiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzOTcuODg5OCA0NTMgY20NCnENCjAgMCAuNTAx OTYxIHJnDQowIDAgLjUwMTk2MSBSRw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEy IFRMIDY2LjQ0IDAgVGQgKDIpIFRqIFQqIC02Ni40NCAwIFRkIEVUDQpRDQpRDQpxDQoxIDAg MCAxIDAgNDM1IGNtDQpxDQpCVCAxIDAgMCAxIDAgMiBUbSAxMiBUTCAvRjIgMTAgVGYgMCAw IC41MDE5NjEgcmcgKDMgICBSZXF1aXJlbWVudHMgYW5kIERlc2lnbikgVGogVCogRVQNClEN ClENCnENCjEgMCAwIDEgMzk3Ljg4OTggNDM1IGNtDQpxDQowIDAgLjUwMTk2MSByZw0KMCAw IC41MDE5NjEgUkcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCA2Ni40NCAw IFRkICgzKSBUaiBUKiAtNjYuNDQgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAwIDQxNyBj bQ0KcQ0KQlQgMSAwIDAgMSAyMCAyIFRtIDEyIFRMIC9GMSAxMCBUZiAwIDAgLjUwMTk2MSBy ZyAoMy4xICAgTGFuZHNjYXBlKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzOTcuODg5 OCA0MTcgY20NCnENCjAgMCAuNTAxOTYxIHJnDQowIDAgLjUwMTk2MSBSRw0KQlQgMSAwIDAg MSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDY2LjQ0IDAgVGQgKDMpIFRqIFQqIC02Ni40NCAw IFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDAgMzk5IGNtDQpxDQpCVCAxIDAgMCAxIDIwIDIg VG0gMTIgVEwgL0YxIDEwIFRmIDAgMCAuNTAxOTYxIHJnICgzLjIgICBEb21haW4gY29uc3Ry dWN0aW9uKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzOTcuODg5OCAzOTkgY20NCnEN CjAgMCAuNTAxOTYxIHJnDQowIDAgLjUwMTk2MSBSRw0KQlQgMSAwIDAgMSAwIDIgVG0gL0Yx IDEwIFRmIDEyIFRMIDY2LjQ0IDAgVGQgKDQpIFRqIFQqIC02Ni40NCAwIFRkIEVUDQpRDQpR DQpxDQoxIDAgMCAxIDAgMzgxIGNtDQpxDQpCVCAxIDAgMCAxIDIwIDIgVG0gMTIgVEwgL0Yx IDEwIFRmIDAgMCAuNTAxOTYxIHJnICgzLjMgICBDb21tb24gQm9vdCBDb25maWd1cmF0aW9u cykgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMzk3Ljg4OTggMzgxIGNtDQpxDQowIDAg LjUwMTk2MSByZw0KMCAwIC41MDE5NjEgUkcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBU ZiAxMiBUTCA2Ni40NCAwIFRkICg0KSBUaiBUKiAtNjYuNDQgMCBUZCBFVA0KUQ0KUQ0KcQ0K MSAwIDAgMSAwIDM2MyBjbQ0KcQ0KQlQgMSAwIDAgMSA0MCAyIFRtIDEyIFRMIC9GMSAxMCBU ZiAwIDAgLjUwMTk2MSByZyAoMy4zLjEgICBEeW5hbWljIExhdW5jaCB3aXRoIGEgSGlnaGx5 LVByaXZpbGVnZWQgRG9tYWluIDApIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDM5Ny44 ODk4IDM2MyBjbQ0KcQ0KMCAwIC41MDE5NjEgcmcNCjAgMCAuNTAxOTYxIFJHDQpCVCAxIDAg MCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgNjYuNDQgMCBUZCAoNCkgVGogVCogLTY2LjQ0 IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMCAzNDUgY20NCnENCkJUIDEgMCAwIDEgNDAg MiBUbSAxMiBUTCAvRjEgMTAgVGYgMCAwIC41MDE5NjEgcmcgKDMuMy4yICAgU3RhdGljIExh dW5jaCBDb25maWd1cmF0aW9uczogd2l0aG91dCBhIERvbWFpbiAwIG9yIGEgQ29udHJvbCBE b21haW4pIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDM5Ny44ODk4IDM0NSBjbQ0KcQ0K MCAwIC41MDE5NjEgcmcNCjAgMCAuNTAxOTYxIFJHDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEg MTAgVGYgMTIgVEwgNjYuNDQgMCBUZCAoNCkgVGogVCogLTY2LjQ0IDAgVGQgRVQNClENClEN CnENCjEgMCAwIDEgMCAzMjcgY20NCnENCkJUIDEgMCAwIDEgNDAgMiBUbSAxMiBUTCAvRjEg MTAgVGYgMCAwIC41MDE5NjEgcmcgKDMuMy4zICAgRHluYW1pYyBMYXVuY2ggb2YgRGlzYWdn cmVnYXRlZCBTeXN0ZW0gQ29uZmlndXJhdGlvbnMpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAg MCAxIDM5Ny44ODk4IDMyNyBjbQ0KcQ0KMCAwIC41MDE5NjEgcmcNCjAgMCAuNTAxOTYxIFJH DQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgNjYuNDQgMCBUZCAoNCkgVGog VCogLTY2LjQ0IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMCAzMDkgY20NCnENCkJUIDEg MCAwIDEgNDAgMiBUbSAxMiBUTCAvRjEgMTAgVGYgMCAwIC41MDE5NjEgcmcgKDMuMy40ICAg RXhhbXBsZSBVc2UgQ2FzZXMgYW5kIENvbmZpZ3VyYXRpb25zKSBUaiBUKiBFVA0KUQ0KUQ0K cQ0KMSAwIDAgMSAzOTcuODg5OCAzMDkgY20NCnENCjAgMCAuNTAxOTYxIHJnDQowIDAgLjUw MTk2MSBSRw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDY2LjQ0IDAgVGQg KDUpIFRqIFQqIC02Ni40NCAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDAgMjkxIGNtDQpx DQpCVCAxIDAgMCAxIDIwIDIgVG0gMTIgVEwgL0YxIDEwIFRmIDAgMCAuNTAxOTYxIHJnICgz LjQgICBoeXBlcmxhdW5jaCBEaXNhZ2dyZWdhdGVkIExhdW5jaCkgVGogVCogRVQNClENClEN CnENCjEgMCAwIDEgMzk3Ljg4OTggMjkxIGNtDQpxDQowIDAgLjUwMTk2MSByZw0KMCAwIC41 MDE5NjEgUkcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCA2Ni40NCAwIFRk ICg1KSBUaiBUKiAtNjYuNDQgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAwIDI3MyBjbQ0K cQ0KQlQgMSAwIDAgMSAyMCAyIFRtIDEyIFRMIC9GMSAxMCBUZiAwIDAgLjUwMTk2MSByZyAo My41ICAgT3ZlcnZpZXcgb2YgaHlwZXJsYXVuY2ggRmxvdykgVGogVCogRVQNClENClENCnEN CjEgMCAwIDEgMzk3Ljg4OTggMjczIGNtDQpxDQowIDAgLjUwMTk2MSByZw0KMCAwIC41MDE5 NjEgUkcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCA2Ni40NCAwIFRkICg2 KSBUaiBUKiAtNjYuNDQgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAwIDI1NSBjbQ0KcQ0K QlQgMSAwIDAgMSA0MCAyIFRtIDEyIFRMIC9GMSAxMCBUZiAwIDAgLjUwMTk2MSByZyAoMy41 LjEgICBoeXBlcmxhdW5jaCBYZW4gc3RhcnR1cCkgVGogVCogRVQNClENClENCnENCjEgMCAw IDEgMzk3Ljg4OTggMjU1IGNtDQpxDQowIDAgLjUwMTk2MSByZw0KMCAwIC41MDE5NjEgUkcN CkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCA2Ni40NCAwIFRkICg3KSBUaiBU KiAtNjYuNDQgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAwIDIzNyBjbQ0KcQ0KQlQgMSAw IDAgMSAyMCAyIFRtIDEyIFRMIC9GMSAxMCBUZiAwIDAgLjUwMTk2MSByZyAoMy42ICAgU3Ry dWN0dXJpbmcgb2YgSHlwZXJsYXVuY2gpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDM5 Ny44ODk4IDIzNyBjbQ0KcQ0KMCAwIC41MDE5NjEgcmcNCjAgMCAuNTAxOTYxIFJHDQpCVCAx IDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgNjYuNDQgMCBUZCAoOCkgVGogVCogLTY2 LjQ0IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMCAyMTkgY20NCnENCkJUIDEgMCAwIDEg NDAgMiBUbSAxMiBUTCAvRjEgMTAgVGYgMCAwIC41MDE5NjEgcmcgKDMuNi4xICAgeDg2IE11 bHRpYm9vdDIpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDM5Ny44ODk4IDIxOSBjbQ0K cQ0KMCAwIC41MDE5NjEgcmcNCjAgMCAuNTAxOTYxIFJHDQpCVCAxIDAgMCAxIDAgMiBUbSAv RjEgMTAgVGYgMTIgVEwgNjYuNDQgMCBUZCAoOCkgVGogVCogLTY2LjQ0IDAgVGQgRVQNClEN ClENCnENCjEgMCAwIDEgMCAyMDEgY20NCnENCkJUIDEgMCAwIDEgNDAgMiBUbSAxMiBUTCAv RjEgMTAgVGYgMCAwIC41MDE5NjEgcmcgKDMuNi4yICAgQXJtIERldmljZSBUcmVlKSBUaiBU KiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzOTcuODg5OCAyMDEgY20NCnENCjAgMCAuNTAxOTYx IHJnDQowIDAgLjUwMTk2MSBSRw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRM IDY2LjQ0IDAgVGQgKDgpIFRqIFQqIC02Ni40NCAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAx IDAgMTgzIGNtDQpxDQpCVCAxIDAgMCAxIDQwIDIgVG0gMTIgVEwgL0YxIDEwIFRmIDAgMCAu NTAxOTYxIHJnICgzLjYuMyAgIFhlbiBoeXBlcnZpc29yKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0K MSAwIDAgMSAzOTcuODg5OCAxODMgY20NCnENCjAgMCAuNTAxOTYxIHJnDQowIDAgLjUwMTk2 MSBSRw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDY2LjQ0IDAgVGQgKDkp IFRqIFQqIC02Ni40NCAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDAgMTY1IGNtDQpxDQpC VCAxIDAgMCAxIDQwIDIgVG0gMTIgVEwgL0YxIDEwIFRmIDAgMCAuNTAxOTYxIHJnICgzLjYu NCAgIEJvb3QgRG9tYWluKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzOTcuODg5OCAx NjUgY20NCnENCjAgMCAuNTAxOTYxIHJnDQowIDAgLjUwMTk2MSBSRw0KQlQgMSAwIDAgMSAw IDIgVG0gL0YxIDEwIFRmIDEyIFRMIDY2LjQ0IDAgVGQgKDkpIFRqIFQqIC02Ni40NCAwIFRk IEVUDQpRDQpRDQpxDQoxIDAgMCAxIDAgMTQ3IGNtDQpxDQpCVCAxIDAgMCAxIDQwIDIgVG0g MTIgVEwgL0YxIDEwIFRmIDAgMCAuNTAxOTYxIHJnICgzLjYuNSAgIENyYXNoIERvbWFpbikg VGogVCogRVQNClENClENCnENCjEgMCAwIDEgMzk3Ljg4OTggMTQ3IGNtDQpxDQowIDAgLjUw MTk2MSByZw0KMCAwIC41MDE5NjEgUkcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAx MiBUTCA2Ni40NCAwIFRkICg5KSBUaiBUKiAtNjYuNDQgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAw IDAgMSAwIDEyOSBjbQ0KcQ0KQlQgMSAwIDAgMSA0MCAyIFRtIDEyIFRMIC9GMSAxMCBUZiAw IDAgLjUwMTk2MSByZyAoMy42LjYgICBDb250cm9sIERvbWFpbikgVGogVCogRVQNClENClEN CnENCjEgMCAwIDEgMzk3Ljg4OTggMTI5IGNtDQpxDQowIDAgLjUwMTk2MSByZw0KMCAwIC41 MDE5NjEgUkcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCA2Ni40NCAwIFRk ICg5KSBUaiBUKiAtNjYuNDQgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAwIDExMSBjbQ0K cQ0KQlQgMSAwIDAgMSA0MCAyIFRtIDEyIFRMIC9GMSAxMCBUZiAwIDAgLjUwMTk2MSByZyAo My42LjcgICBIYXJkd2FyZSBEb21haW4pIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDM5 Ny44ODk4IDExMSBjbQ0KcQ0KMCAwIC41MDE5NjEgcmcNCjAgMCAuNTAxOTYxIFJHDQpCVCAx IDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgNjYuNDQgMCBUZCAoOSkgVGogVCogLTY2 LjQ0IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMCA5MyBjbQ0KcQ0KQlQgMSAwIDAgMSA0 MCAyIFRtIDEyIFRMIC9GMSAxMCBUZiAwIDAgLjUwMTk2MSByZyAoMy42LjggICBDb25zb2xl IERvbWFpbikgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMzk3Ljg4OTggOTMgY20NCnEN CjAgMCAuNTAxOTYxIHJnDQowIDAgLjUwMTk2MSBSRw0KQlQgMSAwIDAgMSAwIDIgVG0gL0Yx IDEwIFRmIDEyIFRMIDY2LjQ0IDAgVGQgKDkpIFRqIFQqIC02Ni40NCAwIFRkIEVUDQpRDQpR DQpxDQoxIDAgMCAxIDAgNzUgY20NCnENCkJUIDEgMCAwIDEgMCAyIFRtIDEyIFRMIC9GMiAx MCBUZiAwIDAgLjUwMTk2MSByZyAoNCAgIEFwcGVuZGl4KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0K MSAwIDAgMSAzOTcuODg5OCA3NSBjbQ0KcQ0KMCAwIC41MDE5NjEgcmcNCjAgMCAuNTAxOTYx IFJHDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIgVEwgNjAuODggMCBUZCAoMTAp IFRqIFQqIC02MC44OCAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDAgNTcgY20NCnENCkJU IDEgMCAwIDEgMjAgMiBUbSAxMiBUTCAvRjEgMTAgVGYgMCAwIC41MDE5NjEgcmcgKDQuMSAg IEFwcGVuZGl4IDE6IEZsb3cgU2VxdWVuY2Ugb2YgU3RlcHMgb2YgYSBoeXBlcmxhdW5jaCBC b290KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzOTcuODg5OCA1NyBjbQ0KcQ0KMCAw IC41MDE5NjEgcmcNCjAgMCAuNTAxOTYxIFJHDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAg VGYgMTIgVEwgNjAuODggMCBUZCAoMTApIFRqIFQqIC02MC44OCAwIFRkIEVUDQpRDQpRDQpx DQoxIDAgMCAxIDAgMzkgY20NCnENCkJUIDEgMCAwIDEgMjAgMiBUbSAxMiBUTCAvRjEgMTAg VGYgMCAwIC41MDE5NjEgcmcgKDQuMiAgIEFwcGVuZGl4IDI6IENvbnNpZGVyYXRpb25zIGlu IE5hbWluZyB0aGUgSHlwZXJsYXVuY2ggRmVhdHVyZSkgVGogVCogRVQNClENClENCnENCjEg MCAwIDEgMzk3Ljg4OTggMzkgY20NCnENCjAgMCAuNTAxOTYxIHJnDQowIDAgLjUwMTk2MSBS Rw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDYwLjg4IDAgVGQgKDEwKSBU aiBUKiAtNjAuODggMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAwIDIxIGNtDQpxDQpCVCAx IDAgMCAxIDIwIDIgVG0gMTIgVEwgL0YxIDEwIFRmIDAgMCAuNTAxOTYxIHJnICg0LjMgICBB cHBlbmRpeCAzOiBUZXJtaW5vbG9neSkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMzk3 Ljg4OTggMjEgY20NCnENCjAgMCAuNTAxOTYxIHJnDQowIDAgLjUwMTk2MSBSRw0KQlQgMSAw IDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDYwLjg4IDAgVGQgKDEzKSBUaiBUKiAtNjAu ODggMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAwIDMgY20NCnENCkJUIDEgMCAwIDEgMjAg MiBUbSAxMiBUTCAvRjEgMTAgVGYgMCAwIC41MDE5NjEgcmcgKDQuNCAgIEFwcGVuZGl4IDQ6 IENvcHlyaWdodCBMaWNlbnNlKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzOTcuODg5 OCAzIGNtDQpxDQowIDAgLjUwMTk2MSByZw0KMCAwIC41MDE5NjEgUkcNCkJUIDEgMCAwIDEg MCAyIFRtIC9GMSAxMCBUZiAxMiBUTCA2MC44OCAwIFRkICgxNCkgVGogVCogLTYwLjg4IDAg VGQgRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMTY1LjAyMzYgY20N CnENCkJUIDEgMCAwIDEgMCAzLjUgVG0gMjEgVEwgL0YyIDE3LjUgVGYgMCAwIDAgcmcgKDEg ICBJbnRyb2R1Y3Rpb24pIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDEz NS4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAx MiBUTCAuMzg1MzE4IFR3IChUaGlzIGRvY3VtZW50IGRlc2NyaWJlcyB0aGUgZGVzaWduIGFu ZCBtb3RpdmF0aW9uIGZvciB0aGUgZnVuZGVkIGRldmVsb3BtZW50IG9mIGEgbmV3LCBmbGV4 aWJsZSBzeXN0ZW0pIFRqIFQqIDAgVHcgKGZvciBsYXVuY2hpbmcgdGhlIFhlbiBoeXBlcnZp c29yIGFuZCB2aXJ0dWFsIG1hY2hpbmVzIG5hbWVkOiAiaHlwZXJsYXVuY2giLikgVGogVCog RVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgODEuMDIzNjIgY20NCnENCjAgMCAwIHJn DQpCVCAxIDAgMCAxIDAgMzggVG0gL0YxIDEwIFRmIDEyIFRMIDEuNDYxMzE4IFR3IChUaGUg ZGVzaWduIGVuYWJsZXMgc2VhbWxlc3MgdHJhbnNpdGlvbiBmb3IgZXhpc3Rpbmcgc3lzdGVt cyB0aGF0IHJlcXVpcmUgYSBkb20wLCBhbmQgcHJvdmlkZXMgYSBuZXcpIFRqIFQqIDAgVHcg Ljc0NDU5NyBUdyAoZ2VuZXJhbCBjYXBhYmlsaXR5IHRvIGJ1aWxkIGFuZCBsYXVuY2ggYWx0 ZXJuYXRpdmUgY29uZmlndXJhdGlvbnMgb2YgdmlydHVhbCBtYWNoaW5lcywgaW5jbHVkaW5n IHN1cHBvcnQgZm9yKSBUaiBUKiAwIFR3IC43NzgxMSBUdyAoc3RhdGljIHBhcnRpdGlvbmlu ZyBhbmQgYWNjZWxlcmF0ZWQgc3RhcnQgb2YgVk1zIGR1cmluZyBob3N0IGJvb3QsIHdoaWxl IGFkaGVyaW5nIHRvIHRoZSBwcmluY2lwbGVzIG9mIGxlYXN0KSBUaiBUKiAwIFR3IDEuNDcw NzUxIFR3IChwcml2aWxlZ2UuIEl0IGluY29ycG9yYXRlcyB0aGUgZXhpc3RpbmcgZG9tMGxl c3MgZnVuY3Rpb25hbGl0eSwgZXh0ZW5kZWQgdG8gZm9sZCBpbiB0aGUgbmV3IGRldmVsb3Bt ZW50cykgVGogVCogMCBUdyBFVA0KUQ0KUQ0KIA0KZW5kc3RyZWFtDQplbmRvYmoNCjExNyAw IG9iag0KPDwgL0xlbmd0aCA4MTE3ID4+DQpzdHJlYW0NCjEgMCAwIDEgMCAwIGNtICBCVCAv RjEgMTIgVGYgMTQuNCBUTCBFVA0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA3NDEuMDIzNiBjbQ0K cQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAxNCBUbSAvRjEgMTAgVGYgMTIgVEwgMi4wNTM5 ODQgVHcgKGZyb20gdGhlIERvbUIgcHJvamVjdCwgd2l0aCBzdXBwb3J0IGZvciBib3RoIHg4 NiBhbmQgQXJtIHBsYXRmb3JtIGFyY2hpdGVjdHVyZXMsIGJ1aWxkaW5nIHVwb24gYW5kKSBU aiBUKiAwIFR3IChyZXBsYWNpbmcgdGhlIGVhcmxpZXIgJ2xhdGUgaGFyZHdhcmUgZG9tYWlu JyBmZWF0dXJlIGZvciBkaXNhZ2dyZWdhdGlvbiBvZiBkb20wLikgVGogVCogRVQNClENClEN CnENCjEgMCAwIDEgNjIuNjkyOTEgNzExLjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAg MCAxIDAgMTQgVG0gL0YxIDEwIFRmIDEyIFRMIC42MzUyOCBUdyAoSHlwZXJsYXVuY2ggaXMg ZGVzaWduZWQgdG8gYmUgZmxleGlibGUgYW5kIHJldXNhYmxlIGFjcm9zcyBtdWx0aXBsZSB1 c2UgY2FzZXMsIGFuZCBvdXIgYWltIGlzIHRvIGVuc3VyZSkgVGogVCogMCBUdyAodGhhdCBp dCBpcyBjYXBhYmxlLCB3aWRlbHkgZXhlcmNpc2VkLCBjb21wcmVoZW5zaXZlbHkgdGVzdGVk LCBhbmQgd2VsbCB1bmRlcnN0b29kIGJ5IHRoZSBYZW4gY29tbXVuaXR5LikgVGogVCogRVQN ClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNjc4LjAyMzYgY20NCnENCkJUIDEgMCAwIDEg MCAzLjUgVG0gMjEgVEwgL0YyIDE3LjUgVGYgMCAwIDAgcmcgKDIgICBBcHByb2FjaCkgVGog VCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNjAwLjAyMzYgY20NCnENCjAgMCAw IHJnDQpCVCAxIDAgMCAxIDAgNjIgVG0gL0YxIDEwIFRmIDEyIFRMIC43ODMxMSBUdyAoQm9y biBvdXQgb2YgaW1wcm92aW5nIHN1cHBvcnQgZm9yIER5bmFtaWMgUm9vdCBvZiBUcnVzdCBm b3IgTWVhc3VyZW1lbnQgXChEUlRNXCksIHRoZSBEb21CIHByb2plY3QgaXMpIFRqIFQqIDAg VHcgMy43Nzk5ODIgVHcgKGZvY3VzZWQgb24gcmVzdHJ1Y3R1cmluZyB0aGUgc3lzdGVtIGxh dW5jaCBvZiBYZW4uIFRoZSBoeXBlcmxhdW5jaCBkZXNpZ24gcHJvdmlkZXMgYSBzZWN1cml0 eSkgVGogVCogMCBUdyAuMTk5MzE4IFR3IChhcmNoaXRlY3R1cmUgdGhhdCBidWlsZHMgb24g dGhlIHByaW5jaXBsZXMgb2YgTGVhc3QgUHJpdmlsZWdlIGFuZCBTdHJvbmcgSXNvbGF0aW9u LCBhY2hpZXZpbmcgdGhpcyB0aHJvdWdoIHRoZSkgVGogVCogMCBUdyAxLjI5ODczNSBUdyAo ZGlzYWdncmVnYXRpb24gb2Ygc3lzdGVtIGZ1bmN0aW9ucy4gSXQgZW5hYmxlcyB0aGlzIHdp dGggdGhlIGludHJvZHVjdGlvbiBvZiBhIGJvb3QgZG9tYWluIHRoYXQgd29ya3MgaW4pIFRq IFQqIDAgVHcgLjM3MzUxNiBUdyAoY29uanVuY3Rpb24gd2l0aCB0aGUgaHlwZXJ2aXNvciB0 byBwcm92aWRlIHRoZSBhYmlsaXR5IHRvIGxhdW5jaCBtdWx0aXBsZSBkb21haW5zIGFzIHBh cnQgb2YgaG9zdCBib290IHdoaWxlKSBUaiBUKiAwIFR3IChtYWludGFpbmluZyBhIGxlYXN0 IHByaXZpbGVnZSBpbXBsZW1lbnRhdGlvbi4pIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAx IDYyLjY5MjkxIDU0Ni4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDM4IFRt IC9GMSAxMCBUZiAxMiBUTCAyLjgyODExIFR3IChXaGlsZSB0aGUgRG9tQiBwcm9qZWN0IGlu Y2VwdGlvbiB3YXMgYW5kIGNvbnRpbnVlcyB0byBiZSBkcml2ZW4gYnkgYSBmb2N1cyBvbiBz ZWN1cml0eSB0aHJvdWdoKSBUaiBUKiAwIFR3IDEuNTcxOTg0IFR3IChkaXNhZ2dyZWdhdGlv biwgdGhlcmUgYXJlIG11bHRpcGxlIHVzZSBjYXNlcyB3aXRoIGEgbm9uLXNlY3VyaXR5IGZv Y3VzIHRoYXQgcmVxdWlyZSBvciBiZW5lZml0IGZyb20gdGhlKSBUaiBUKiAwIFR3IC4wMTI5 MjcgVHcgKGFiaWxpdHkgdG8gbGF1bmNoIG11bHRpcGxlIGRvbWFpbnMgYXQgaG9zdCBib290 LiBUaGlzIHdhcyBwcm92ZW4gYnkgdGhlIG5lZWQgdGhhdCBkcm92ZSB0aGUgaW1wbGVtZW50 YXRpb24pIFRqIFQqIDAgVHcgKG9mIHRoZSBkb20wbGVzcyBjYXBhYmlsaXR5IGluIHRoZSBB cm0gYnJhbmNoIG9mIFhlbi4pIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5Mjkx IDUwNC4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDI2IFRtIC9GMSAxMCBU ZiAxMiBUTCAuNjM1MjggVHcgKEh5cGVybGF1bmNoIGlzIGRlc2lnbmVkIHRvIGJlIGZsZXhp YmxlIGFuZCByZXVzYWJsZSBhY3Jvc3MgbXVsdGlwbGUgdXNlIGNhc2VzLCBhbmQgb3VyIGFp bSBpcyB0byBlbnN1cmUpIFRqIFQqIDAgVHcgLjYxMjEyNiBUdyAodGhhdCBpdCBpcyBjYXBh YmxlLCB3aWRlbHkgZXhlcmNpc2VkLCBjb21wcmVoZW5zaXZlbHkgdGVzdGVkLCBhbmQgcHJv dmlkZXMgYSByb2J1c3QgZm91bmRhdGlvbiBmb3IgY3VycmVudCkgVGogVCogMCBUdyAoYW5k IGVtZXJnaW5nIHN5c3RlbSBsYXVuY2ggcmVxdWlyZW1lbnRzIG9mIHRoZSBYZW4gY29tbXVu aXR5LikgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNDc0LjAyMzYgY20N CnENCkJUIDEgMCAwIDEgMCAzIFRtIDE4IFRMIC9GMiAxNSBUZiAwIDAgMCByZyAoMi4xICAg T2JqZWN0aXZlcykgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNDYyLjAy MzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNDYyLjAyMzYgY20NClENCnENCjEgMCAw IDEgNjIuNjkyOTEgNDUwLjAyMzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwg RVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRt IC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQN ClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAg MiBUbSAvRjEgMTAgVGYgMTIgVEwgKEluIGdlbmVyYWwgc3RyaXZlIHRvIG1haW50YWluIGNv bXBhdGliaWxpdHkgd2l0aCBleGlzdGluZyBYZW4gYmVoYXZpb3IpIFRqIFQqIEVUDQpRDQpR DQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDQ0NC4wMjM2IGNtDQpRDQpxDQoxIDAg MCAxIDYyLjY5MjkxIDMzMC4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRM IEVUDQpxDQoxIDAgMCAxIDYgOTkgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBU bSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVU DQpRDQpRDQpxDQoxIDAgMCAxIDIzIDg3IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAw IDE0IFRtIC9GMSAxMCBUZiAxMiBUTCAuMTEwNjUxIFR3IChBIGRlZmF1bHQgYnVpbGQgb2Yg dGhlIGh5cGVydmlzb3Igc2hvdWxkIGJlIGNhcGFibGUgb2YgYm9vdGluZyBib3RoIGxlZ2Fj eS1jb21wYXRpYmxlIGFuZCBuZXcgc3R5bGVzKSBUaiBUKiAwIFR3IChvZiBsYXVuY2g6KSBU aiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyA4MSBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMyAt MyBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSAwIDIg VG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDc4IGNtDQpRDQpxDQoxIDAgMCAxIDIwIDc4IGNt DQpRDQpxDQoxIDAgMCAxIDIwIDY2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRM IEVUDQpxDQoxIDAgMCAxIDYgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBU bSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVU DQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAw IDIgVG0gL0YxIDEwIFRmIDEyIFRMIChjbGFzc2ljIFhlbiBib290OiBzdGFydGluZyBhIHNp bmdsZSwgcHJpdmlsZWdlZCBEb20wKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAw IDAgMSAyMCA2MCBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMCAzNiBjbQ0KMCAwIDAgcmcNCkJUIC9G MSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAgMSA2IDkgY20NCnENCjAgMCAwIHJnDQpCVCAx IDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAt MTAuNSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpxDQowIDAgMCByZw0K QlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAxMiBUTCAxLjkzMTY0NyBUdyAoY2xhc3Np YyBYZW4gYm9vdCB3aXRoIGxhdGUgaGFyZHdhcmUgZG9tYWluOiBzdGFydGluZyBhIERvbTAg dGhhdCB0cmFuc2l0aW9ucyBoYXJkd2FyZSkgVGogVCogMCBUdyAoYWNjZXNzL2NvbnRyb2wg dG8gYW5vdGhlciBkb21haW4pIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAx IDIwIDMwIGNtDQpRDQpxDQoxIDAgMCAxIDIwIDE4IGNtDQowIDAgMCByZw0KQlQgL0YxIDEw IFRmIDEyIFRMIEVUDQpxDQoxIDAgMCAxIDYgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAg MCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAu NSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpxDQowIDAgMCByZw0KQlQg MSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChhIGRvbTBsZXNzIGJvb3Q6IHN0YXJ0 aW5nIG11bHRpcGxlIGRvbWFpbnMgd2l0aG91dCBwcml2aWxlZ2UgYXNzaWdubWVudCBjb250 cm9scykgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgMjAgMTIgY20NClEN CnENCjEgMCAwIDEgMjAgMCBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0K cQ0KMSAwIDAgMSA2IC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0Yx IDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAoXDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0K UQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRt IC9GMSAxMCBUZiAxMiBUTCAoaHlwZXJsYXVuY2g6IHN0YXJ0aW5nIG9uZSBvciBtb3JlIFZN cywgd2l0aCBmbGV4aWJsZSBjb25maWd1cmF0aW9uKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0K UQ0KcQ0KMSAwIDAgMSAyMCAwIGNtDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNt DQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDMyNC4wMjM2IGNtDQpRDQpxDQox IDAgMCAxIDYyLjY5MjkxIDMxMi4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEy IFRMIEVUDQpxDQoxIDAgMCAxIDYgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAg MiBUbSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRk IEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAg MSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChQcmVmZXJyZWQgdGhhdCBpdCBiZSBtYW5hZ2Vk IHZpYSBLQ09ORklHIG9wdGlvbnMgdG8gZ292ZXJuIGluY2x1c2lvbiBvZiBzdXBwb3J0IGZv ciBlYWNoIHN0eWxlKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42 OTI5MSAzMDYuMDIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAyNzAuMDIzNiBjbQ0K MCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAgMSA2IDIxIGNtDQpx DQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBU ZCAoXDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAyMSBj bQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoVGhl IHNlbGVjdGlvbiBiZXR3ZWVuIGNsYXNzaWMgYm9vdCBhbmQgaHlwZXJsYXVuY2ggYm9vdCBz aG91bGQgYmUgYXV0b21hdGljKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAxNSBj bQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBU TCBFVA0KQlQgMSAwIDAgMSAwIDIgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDEyIGNtDQpR DQpxDQoxIDAgMCAxIDIwIDEyIGNtDQpRDQpxDQoxIDAgMCAxIDIwIDAgY20NCjAgMCAwIHJn DQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0KcQ0KMCAwIDAg cmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcp IFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAg MCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKFByZWZlcnJlZCB0 aGF0IGl0IG5vdCByZXF1aXJlIGEga2VybmVsIGNvbW1hbmQgbGluZSBwYXJhbWV0ZXIgZm9y IHNlbGVjdGlvbikgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgMjAgMCBj bQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAw IDAgMSA2Mi42OTI5MSAyNjQuMDIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAyNTIu MDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAgMSA2 IC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRM IDEwLjUgMCBUZCAoXDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAg MSAyMyAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAx MiBUTCAoSXQgc2hvdWxkIG5vdCByZXF1aXJlIG1vZGlmaWNhdGlvbiB0byBib290IGxvYWRl cnMpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDI0Ni4w MjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDIzNC4wMjM2IGNtDQowIDAgMCByZw0K QlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAgMCAxIDYgLTMgY20NCnENCjAgMCAwIHJn DQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3KSBU aiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpxDQowIDAg MCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChJdCBzaG91bGQgcHJv dmlkZSBhIHVzZXIgZnJpZW5kbHkgaW50ZXJmYWNlIGZvciBpdHMgY29uZmlndXJhdGlvbiBh bmQgbWFuYWdlbWVudCkgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIu NjkyOTEgMjI4LjAyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMjA0LjAyMzYgY20N CjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiA5IGNtDQpx DQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBU ZCAoXDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBj bQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAxNCBUbSAvRjEgMTAgVGYgMTIgVEwgMi42 MDYyMzUgVHcgKEl0IG11c3QgcHJvdmlkZSBhIG1ldGhvZCBmb3IgYnVpbGRpbmcgc3lzdGVt cyB0aGF0IGZhbGxiYWNrIHRvIGNvbnNvbGUgYWNjZXNzIGluIHRoZSBldmVudCBvZikgVGog VCogMCBUdyAobWlzY29uZmlndXJhdGlvbikgVGogVCogRVQNClENClENCnENClENClENCnEN CjEgMCAwIDEgNjIuNjkyOTEgMTk4LjAyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEg MTg2LjAyMzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAw IDEgNiAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAx MiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEg MCAwIDEgMjMgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAg VGYgMTIgVEwgKEl0IHNob3VsZCBiZSBhYmxlIHRvIGJvb3QgYW4geDg2IFhlbiBlbnZpcm9u bWVudCB3aXRob3V0IHRoZSBuZWVkIGZvciBhIERvbTAgZG9tYWluKSBUaiBUKiBFVA0KUQ0K UQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAxODYuMDIzNiBjbQ0KUQ0KIA0KZW5k c3RyZWFtDQplbmRvYmoNCjExOCAwIG9iag0KPDwgL0xlbmd0aCAxMzM5NCA+Pg0Kc3RyZWFt DQoxIDAgMCAxIDAgMCBjbSAgQlQgL0YxIDEyIFRmIDE0LjQgVEwgRVQNCnENCjEgMCAwIDEg NjIuNjkyOTEgNzQ0LjAyMzYgY20NCnENCkJUIDEgMCAwIDEgMCAzLjUgVG0gMjEgVEwgL0Yy IDE3LjUgVGYgMCAwIDAgcmcgKDMgICBSZXF1aXJlbWVudHMgYW5kIERlc2lnbikgVGogVCog RVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNjQyLjAyMzYgY20NCnENCjAgMCAwIHJn DQpCVCAxIDAgMCAxIDAgODYgVG0gL0YxIDEwIFRmIDEyIFRMIC4xMzcyMDkgVHcgKEh5cGVy bGF1bmNoIGlzIGRlZmluZWQgYXMgdGhlIGFiaWxpdHkgb2YgYSBoeXBlcnZpc29yIHRvIGNv bnN0cnVjdCBhbmQgc3RhcnQgb25lIG9yIG1vcmUgdmlydHVhbCBtYWNoaW5lcyBhdCkgVGog VCogMCBUdyAzLjYwOTk4NCBUdyAoc3lzdGVtIGxhdW5jaCBpbiBhIHNwZWNpZmljIHdheS4g QSBoeXBlcnZpc29yIGNhbiBzdXBwb3J0IG9uZSBvciBib3RoIG1vZGVzIG9mIGNvbmZpZ3Vy YXRpb24sKSBUaiBUKiAwIFR3IDMuMTcwODE0IFR3IChIeXBlcmxhdW5jaCBTdGF0aWMgYW5k IEh5cGVybGF1bmNoIER5bmFtaWMuIFRoZSBIeXBlcmxhdW5jaCBTdGF0aWMgbW9kZSBmdW5j dGlvbnMgYXMgYSBzdGF0aWMpIFRqIFQqIDAgVHcgMS42NDQ5ODMgVHcgKHBhcnRpdGlvbmlu ZyBoeXBlcnZpc29yIGVuc3VyaW5nIG9ubHkgdGhlIHZpcnR1YWwgbWFjaGluZXMgc3RhcnRl ZCBhdCBzeXN0ZW0gbGF1bmNoIGFyZSBydW5uaW5nIG9uIHRoZSkgVGogVCogMCBUdyAuNDA2 OTA1IFR3IChzeXN0ZW0uIFRoZSBIeXBlcmxhdW5jaCBEeW5hbWljIG1vZGUgZnVuY3Rpb25z IGFzIGEgZHluYW1pYyBoeXBlcnZpc29yIGFsbG93aW5nIGZvciBhZGRpdGlvbmFsIHZpcnR1 YWwpIFRqIFQqIDAgVHcgMS4yMzA2MSBUdyAobWFjaGluZXMgdG8gYmUgc3RhcnRlZCBhZnRl ciB0aGUgaW5pdGlhbCB2aXJ0dWFsIG1hY2hpbmVzIGhhdmUgc3RhcnRlZC4gVGhlIFhlbiBo eXBlcnZpc29yIGlzIGNhcGFibGUgb2YpIFRqIFQqIDAgVHcgMS4xMjY4NiBUdyAoYm90aCBt b2RlcyBvZiBjb25maWd1cmF0aW9uIGZyb20gdGhlIHNhbWUgYmluYXJ5IGFuZCB3aGVuIHBh aXJlZCB3aXRoIGl0cyBYU00gZmxhc2ssIHByb3ZpZGVzIHN0cm9uZykgVGogVCogMCBUdyAo Y29udHJvbHMgdGhhdCBlbmFibGUgZmluZSBncmFpbmVkIHN5c3RlbSBwYXJ0aXRpb25pbmcu KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA2MTIuMDIzNiBjbQ0KcQ0K QlQgMSAwIDAgMSAwIDMgVG0gMTggVEwgL0YyIDE1IFRmIDAgMCAwIHJnICgzLjEgICBMYW5k c2NhcGUpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDU4Mi4wMjM2IGNt DQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAxMiBUTCAuMTA0 NTk3IFR3IChUaGlzIGNvbXBhcmlzb24gdGFibGUgcHJlc2VudHMgdGhlIGRpc3RpbmN0aXZl IGNhcGFiaWxpdGllcyBvZiBoeXBlcmxhdW5jaCB3aXRoIHJlZmVyZW5jZSB0byBleGlzdGlu ZyBsYXVuY2gpIFRqIFQqIDAgVHcgKGNvbmZpZ3VyYXRpb25zIGN1cnJlbnRseSBhdmFpbGFi bGUgaW4gWGVuIGFuZCBvdGhlciBoeXBlcnZpc29ycy4pIFRqIFQqIEVUDQpRDQpRDQpxDQox IDAgMCAxIDYyLjY5MjkxIDU3Ni4wMjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDEw OC4wMjM2IGNtDQoxIDEgMSByZw0KbiAwIDQ2OCA0NjkuODg5OCAtMTggcmUgZioNCi44Nzg0 MzEgLjg3ODQzMSAuODc4NDMxIHJnDQpuIDAgNDUwIDQ2OS44ODk4IC0xOCByZSBmKg0KMSAx IDEgcmcNCm4gMCA0MzIgNDY5Ljg4OTggLTE4IHJlIGYqDQouODc4NDMxIC44Nzg0MzEgLjg3 ODQzMSByZw0KbiAwIDQxNCA0NjkuODg5OCAtMTggcmUgZioNCjEgMSAxIHJnDQpuIDAgMzk2 IDQ2OS44ODk4IC0xOCByZSBmKg0KLjg3ODQzMSAuODc4NDMxIC44Nzg0MzEgcmcNCm4gMCAz NzggNDY5Ljg4OTggLTE4IHJlIGYqDQoxIDEgMSByZw0KbiAwIDM2MCA0NjkuODg5OCAtMTgg cmUgZioNCi44Nzg0MzEgLjg3ODQzMSAuODc4NDMxIHJnDQpuIDAgMzQyIDQ2OS44ODk4IC0x OCByZSBmKg0KMSAxIDEgcmcNCm4gMCAzMjQgNDY5Ljg4OTggLTE4IHJlIGYqDQouODc4NDMx IC44Nzg0MzEgLjg3ODQzMSByZw0KbiAwIDMwNiA0NjkuODg5OCAtMTggcmUgZioNCjEgMSAx IHJnDQpuIDAgMjg4IDQ2OS44ODk4IC0xOCByZSBmKg0KLjg3ODQzMSAuODc4NDMxIC44Nzg0 MzEgcmcNCm4gMCAyNzAgNDY5Ljg4OTggLTE4IHJlIGYqDQoxIDEgMSByZw0KbiAwIDI1MiA0 NjkuODg5OCAtMTggcmUgZioNCi44Nzg0MzEgLjg3ODQzMSAuODc4NDMxIHJnDQpuIDAgMjM0 IDQ2OS44ODk4IC0xOCByZSBmKg0KMSAxIDEgcmcNCm4gMCAyMTYgNDY5Ljg4OTggLTE4IHJl IGYqDQouODc4NDMxIC44Nzg0MzEgLjg3ODQzMSByZw0KbiAwIDE5OCA0NjkuODg5OCAtMTgg cmUgZioNCjEgMSAxIHJnDQpuIDAgMTgwIDQ2OS44ODk4IC0xOCByZSBmKg0KLjg3ODQzMSAu ODc4NDMxIC44Nzg0MzEgcmcNCm4gMCAxNjIgNDY5Ljg4OTggLTE4IHJlIGYqDQoxIDEgMSBy Zw0KbiAwIDE0NCA0NjkuODg5OCAtMTggcmUgZioNCi44Nzg0MzEgLjg3ODQzMSAuODc4NDMx IHJnDQpuIDAgMTI2IDQ2OS44ODk4IC0xOCByZSBmKg0KMSAxIDEgcmcNCm4gMCAxMDggNDY5 Ljg4OTggLTE4IHJlIGYqDQouODc4NDMxIC44Nzg0MzEgLjg3ODQzMSByZw0KbiAwIDkwIDQ2 OS44ODk4IC0xOCByZSBmKg0KMSAxIDEgcmcNCm4gMCA3MiA0NjkuODg5OCAtMTggcmUgZioN Ci44Nzg0MzEgLjg3ODQzMSAuODc4NDMxIHJnDQpuIDAgNTQgNDY5Ljg4OTggLTE4IHJlIGYq DQoxIDEgMSByZw0KbiAwIDM2IDQ2OS44ODk4IC0xOCByZSBmKg0KLjg3ODQzMSAuODc4NDMx IC44Nzg0MzEgcmcNCm4gMCAxOCA0NjkuODg5OCAtMTggcmUgZioNCi45NjA3ODQgLjk2MDc4 NCAuODYyNzQ1IHJnDQpuIDAgNDY4IDQ2OS44ODk4IC0zNiByZSBmKg0KMCAwIDAgcmcNCkJU IC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAgMSA2IDQzNSBjbQ0KcQ0KLjk2MDc4NCAu OTYwNzg0IC44NjI3NDUgcmcNCm4gMCAwIDY3LjE5NDkgMjQgcmUgZioNClENCnENCkJUIDEg MCAwIDEgMCAxNCBUbSA5LjE0NzQ1MiAwIFRkIDEyIFRMIC9GMiAxMCBUZiAwIDAgMCByZyAo WGVuIERvbTApIFRqIC9GMSAxMCBUZiAgVCogMy42MSAwIFRkIC9GMiAxMCBUZiAoXChDbGFz c2ljXCkpIFRqIFQqIC0xMi43NTc0NSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDg1LjE5 NDkgNDM1IGNtDQpxDQouOTYwNzg0IC45NjA3ODQgLjg2Mjc0NSByZw0KbiAwIDAgNDYuMDc2 MjYgMjQgcmUgZioNClENCnENCkJUIDEgMCAwIDEgMCAxNCBUbSA5LjcwMzEzMSAwIFRkIDEy IFRMIC9GMiAxMCBUZiAwIDAgMCByZyAoTGludXgpIFRqIC9GMSAxMCBUZiAgVCogMi4yMjUg MCBUZCAvRjIgMTAgVGYgKEtWTSkgVGogVCogLTExLjkyODEzIDAgVGQgRVQNClENClENCnEN CjEgMCAwIDEgMTQzLjI3MTIgNDM1IGNtDQpxDQouOTYwNzg0IC45NjA3ODQgLjg2Mjc0NSBy Zw0KbiAwIDAgNTYuNjM1NTggMjQgcmUgZioNClENCnENCkJUIDEgMCAwIDEgMCAxNCBUbSA4 LjMxNzc5MiAwIFRkIDEyIFRMIC9GMiAxMCBUZiAwIDAgMCByZyAoTGF0ZSkgVGogL0YxIDEw IFRmICggKSBUaiAvRjIgMTAgVGYgKEhXKSBUaiBUKiA4Ljg5IDAgVGQgKERvbSkgVGogVCog LTE3LjIwNzc5IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjExLjkwNjggNDM1IGNtDQpx DQouOTYwNzg0IC45NjA3ODQgLjg2Mjc0NSByZw0KbiAwIDAgNDYuMDc2MjYgMjQgcmUgZioN ClENCnENCkJUIDEgMCAwIDEgMCAxNCBUbSAxNC42OTgxMyAwIFRkIDEyIFRMIC9GMiAxMCBU ZiAwIDAgMCByZyAoSmFpbCkgVGogL0YxIDEwIFRmICBUKiAtNi4zODQ5OTkgMCBUZCAvRjIg MTAgVGYgKGhvdXNlKSBUaiBUKiAtOC4zMTMxMzEgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAg MSAyNjkuOTgzIDQzNSBjbQ0KcQ0KLjk2MDc4NCAuOTYwNzg0IC44NjI3NDUgcmcNCm4gMCAw IDYxLjkxNTI0IDI0IHJlIGYqDQpRDQpxDQpCVCAxIDAgMCAxIDAgMTQgVG0gMjEuNzg3NjIg MCBUZCAxMiBUTCAvRjIgMTAgVGYgMCAwIDAgcmcgKFhlbikgVGogL0YxIDEwIFRmICBUKiAt MTMuODk1IDAgVGQgL0YyIDEwIFRmIChkb20wbGVzcykgVGogVCogLTcuODkyNjIyIDAgVGQg RVQNClENClENCnENCjEgMCAwIDEgMzQzLjg5ODMgNDUzIGNtDQpxDQouOTYwNzg0IC45NjA3 ODQgLjg2Mjc0NSByZw0KbiAwIDAgMTE5Ljk5MTUgMTIgcmUgZioNClENCnENCjAgMCAwIHJn DQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIgVEwgMTkuMTUwNzUgMCBUZCAoWGVu IEh5cGVybGF1bmNoKSBUaiBUKiAtMTkuMTUwNzUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAg MSAzNDMuODk4MyA0MzUgY20NCnENCi45NjA3ODQgLjk2MDc4NCAuODYyNzQ1IHJnDQpuIDAg MCA1MS4zNTU5MiAxMiByZSBmKg0KUQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRt IC9GMiAxMCBUZiAxMiBUTCAxMi4wNjI5NiAwIFRkIChTdGF0aWMpIFRqIFQqIC0xMi4wNjI5 NiAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDQwNy4yNTQyIDQzNSBjbQ0KcQ0KLjk2MDc4 NCAuOTYwNzg0IC44NjI3NDUgcmcNCm4gMCAwIDU2LjYzNTU4IDEyIHJlIGYqDQpRDQpxDQow IDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YyIDEwIFRmIDEyIFRMIDcuNDc3NzkyIDAg VGQgKER5bmFtaWMpIFRqIFQqIC03LjQ3Nzc5MiAwIFRkIEVUDQpRDQpRDQowIDAgMCByZw0K cQ0KMSAwIDAgMSA2IDQxNyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9G MSAxMCBUZiAxMiBUTCAoSHlwZXJ2aXNvciBhYmxlIHRvIGxhdW5jaCBtdWx0aXBsZSBWTXMg ZHVyaW5nIGhvc3QgYm9vdCkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMjExLjkwNjgg Mzk5IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRM IChZKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyNjkuOTgzIDM5OSBjbQ0KcQ0KMCAw IDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoWSkgVGogVCogRVQN ClENClENCnENCjEgMCAwIDEgMzQzLjg5ODMgMzk5IGNtDQpxDQowIDAgMCByZw0KQlQgMSAw IDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChZKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAw IDAgMSA0MDcuMjU0MiAzOTkgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAv RjEgMTAgVGYgMTIgVEwgKFkpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYgMzgxIGNt DQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChIeXBl cnZpc29yIHN1cHBvcnRzIFN0YXRpYyBQYXJ0aXRpb25pbmcpIFRqIFQqIEVUDQpRDQpRDQpx DQoxIDAgMCAxIDIxMS45MDY4IDM2MyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAy IFRtIC9GMSAxMCBUZiAxMiBUTCAoWSkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMjY5 Ljk4MyAzNjMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYg MTIgVEwgKFkpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDM0My44OTgzIDM2MyBjbQ0K cQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoWSkgVGog VCogRVQNClENClENCnENCjEgMCAwIDEgNiAzNDUgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAg MCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKEFibGUgdG8gbGF1bmNoIFZNcyBkeW5hbWlj YWxseSBhZnRlciBob3N0IGJvb3QpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYgMzI3 IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChZ KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA4NS4xOTQ5IDMyNyBjbQ0KcQ0KMCAwIDAg cmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoWSkgVGogVCogRVQNClEN ClENCnENCjEgMCAwIDEgMTQzLjI3MTIgMzI3IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAg MSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChZKikgVGogVCogRVQNClENClENCnENCjEgMCAw IDEgMjExLjkwNjggMzI3IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0Yx IDEwIFRmIDEyIFRMIChZKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyNjkuOTgzIDMy NyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAo WSopIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDQwNy4yNTQyIDMyNyBjbQ0KcQ0KMCAw IDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoWSkgVGogVCogRVQN ClENClENCnENCjEgMCAwIDEgNiAzMDkgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAg MiBUbSAvRjEgMTAgVGYgMTIgVEwgKFN1cHBvcnRzIHN0cm9uZyBpc29sYXRpb24gYmV0d2Vl biBhbGwgVk1zIHN0YXJ0ZWQgYXQgaG9zdCBib290KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAw IDAgMSAyMTEuOTA2OCAyOTEgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAv RjEgMTAgVGYgMTIgVEwgKFkpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDI2OS45ODMg MjkxIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRM IChZKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzNDMuODk4MyAyOTEgY20NCnENCjAg MCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKFkpIFRqIFQqIEVU DQpRDQpRDQpxDQoxIDAgMCAxIDQwNy4yNTQyIDI5MSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEg MCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoWSkgVGogVCogRVQNClENClENCnENCjEg MCAwIDEgNiAyNzMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAg VGYgMTIgVEwgKEVuYWJsZXMgZmxleGlibGUgc2VxdWVuY2luZyBvZiBWTSBzdGFydCBkdXJp bmcgaG9zdCBib290KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzNDMuODk4MyAyNTUg Y20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKFkp IFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDQwNy4yNTQyIDI1NSBjbQ0KcQ0KMCAwIDAg cmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoWSkgVGogVCogRVQNClEN ClENCnENCjEgMCAwIDEgNiAyMzcgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBU bSAvRjEgMTAgVGYgMTIgVEwgKFByZXZlbnQgYWxsLXBvd2VyZnVsIHN0YXRpYyByb290IGRv bWFpbiBiZWluZyBsYXVuY2hlZCBhdCBib290KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAg MSAyNjkuOTgzIDIxOSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAx MCBUZiAxMiBUTCAoWSopIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDM0My44OTgzIDIx OSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAo WSkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNDA3LjI1NDIgMjE5IGNtDQpxDQowIDAg MCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChZKSBUaiBUKiBFVA0K UQ0KUQ0KcQ0KMSAwIDAgMSA2IDIwMSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAy IFRtIC9GMSAxMCBUZiAxMiBUTCAoT3BlcmF0ZXMgd2l0aG91dCBhIEhpZ2hseS1wcml2aWxl Z2VkIG1hbmFnZW1lbnQgVk0gXChlZy4gRG9tMFwpKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAw IDAgMSAxNDMuMjcxMiAxODMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAv RjEgMTAgVGYgMTIgVEwgKFkqKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyNjkuOTgz IDE4MyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBU TCAoWSopIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDM0My44OTgzIDE4MyBjbQ0KcQ0K MCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoWSkgVGogVCog RVQNClENClENCnENCjEgMCAwIDEgNDA3LjI1NDIgMTgzIGNtDQpxDQowIDAgMCByZw0KQlQg MSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChZKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0K MSAwIDAgMSA2IDE2NSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAx MCBUZiAxMiBUTCAoT3BlcmF0ZXMgd2l0aG91dCBhIHByaXZpbGVnZWQgdG9vbHN0YWNrIFZN IFwoQ29udHJvbCBEb21haW5cKSkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMjY5Ljk4 MyAxNDcgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIg VEwgKFkqKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzNDMuODk4MyAxNDcgY20NCnEN CjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKFkpIFRqIFQq IEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYgMTI5IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAg MSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChFeHRlbnNpYmxlIFZNIGNvbmZpZ3VyYXRpb24g YXBwbGllZCBiZWZvcmUgbGF1bmNoIG9mIFZNcyBhdCBob3N0IGJvb3QpIFRqIFQqIEVUDQpR DQpRDQpxDQoxIDAgMCAxIDM0My44OTgzIDExMSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAw IDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoWSkgVGogVCogRVQNClENClENCnENCjEgMCAw IDEgNDA3LjI1NDIgMTExIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0Yx IDEwIFRmIDEyIFRMIChZKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2IDkzIGNtDQpx DQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChGbGV4aWJs ZSBncmFudWxhciBhc3NpZ25tZW50IG9mIHBlcm1pc3Npb25zIGFuZCBmdW5jdGlvbnMgdG8g Vk1zKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzNDMuODk4MyA3NSBjbQ0KcQ0KMCAw IDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoWSkgVGogVCogRVQN ClENClENCnENCjEgMCAwIDEgNDA3LjI1NDIgNzUgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAg MCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKFkpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAg MCAxIDYgNTcgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYg MTIgVEwgKFN1cHBvcnRzIGV4dGVuc2libGUgVk0gbWVhc3VyZW1lbnQgYXJjaGl0ZWN0dXJl IGZvciBEUlRNIGFuZCBhdHRlc3RhdGlvbikgVGogVCogRVQNClENClENCnENCjEgMCAwIDEg MzQzLjg5ODMgMzkgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAg VGYgMTIgVEwgKFkpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDQwNy4yNTQyIDM5IGNt DQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChZKSBU aiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2IDIxIGNtDQpxDQowIDAgMCByZw0KQlQgMSAw IDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChQQ0kgcGFzc3Rocm91Z2ggY29uZmlndXJl ZCBhdCBob3N0IGJvb3QpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDM0My44OTgzIDMg Y20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKFkp IFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDQwNy4yNTQyIDMgY20NCnENCjAgMCAwIHJn DQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKFkpIFRqIFQqIEVUDQpRDQpR DQpxDQoxIEoNCjEgag0KMCAwIDAgUkcNCi4yNSB3DQpuIDMzNy44OTgzIDQ1MCBtIDQ2OS44 ODk4IDQ1MCBsIFMNCm4gMCA0MzIgbSA0NjkuODg5OCA0MzIgbCBTDQpuIDAgNDE0IG0gNDY5 Ljg4OTggNDE0IGwgUw0KbiAwIDM5NiBtIDQ2OS44ODk4IDM5NiBsIFMNCm4gMCAzNzggbSA0 NjkuODg5OCAzNzggbCBTDQpuIDAgMzYwIG0gNDY5Ljg4OTggMzYwIGwgUw0KbiAwIDM0MiBt IDQ2OS44ODk4IDM0MiBsIFMNCm4gMCAzMjQgbSA0NjkuODg5OCAzMjQgbCBTDQpuIDAgMzA2 IG0gNDY5Ljg4OTggMzA2IGwgUw0KbiAwIDI4OCBtIDQ2OS44ODk4IDI4OCBsIFMNCm4gMCAy NzAgbSA0NjkuODg5OCAyNzAgbCBTDQpuIDAgMjUyIG0gNDY5Ljg4OTggMjUyIGwgUw0KbiAw IDIzNCBtIDQ2OS44ODk4IDIzNCBsIFMNCm4gMCAyMTYgbSA0NjkuODg5OCAyMTYgbCBTDQpu IDAgMTk4IG0gNDY5Ljg4OTggMTk4IGwgUw0KbiAwIDE4MCBtIDQ2OS44ODk4IDE4MCBsIFMN Cm4gMCAxNjIgbSA0NjkuODg5OCAxNjIgbCBTDQpuIDAgMTQ0IG0gNDY5Ljg4OTggMTQ0IGwg Uw0KbiAwIDEyNiBtIDQ2OS44ODk4IDEyNiBsIFMNCm4gMCAxMDggbSA0NjkuODg5OCAxMDgg bCBTDQpuIDAgOTAgbSA0NjkuODg5OCA5MCBsIFMNCm4gMCA3MiBtIDQ2OS44ODk4IDcyIGwg Uw0KbiAwIDU0IG0gNDY5Ljg4OTggNTQgbCBTDQpuIDAgMzYgbSA0NjkuODg5OCAzNiBsIFMN Cm4gMCAxOCBtIDQ2OS44ODk4IDE4IGwgUw0KbiA3OS4xOTQ5IDAgbSA3OS4xOTQ5IDE4IGwg Uw0KbiA3OS4xOTQ5IDM2IG0gNzkuMTk0OSA1NCBsIFMNCm4gNzkuMTk0OSA3MiBtIDc5LjE5 NDkgOTAgbCBTDQpuIDc5LjE5NDkgMTA4IG0gNzkuMTk0OSAxMjYgbCBTDQpuIDc5LjE5NDkg MTQ0IG0gNzkuMTk0OSAxNjIgbCBTDQpuIDc5LjE5NDkgMTgwIG0gNzkuMTk0OSAxOTggbCBT DQpuIDc5LjE5NDkgMjE2IG0gNzkuMTk0OSAyMzQgbCBTDQpuIDc5LjE5NDkgMjUyIG0gNzku MTk0OSAyNzAgbCBTDQpuIDc5LjE5NDkgMjg4IG0gNzkuMTk0OSAzMDYgbCBTDQpuIDc5LjE5 NDkgMzI0IG0gNzkuMTk0OSAzNDIgbCBTDQpuIDc5LjE5NDkgMzYwIG0gNzkuMTk0OSAzNzgg bCBTDQpuIDc5LjE5NDkgMzk2IG0gNzkuMTk0OSA0MTQgbCBTDQpuIDc5LjE5NDkgNDMyIG0g NzkuMTk0OSA0NjggbCBTDQpuIDEzNy4yNzEyIDAgbSAxMzcuMjcxMiAxOCBsIFMNCm4gMTM3 LjI3MTIgMzYgbSAxMzcuMjcxMiA1NCBsIFMNCm4gMTM3LjI3MTIgNzIgbSAxMzcuMjcxMiA5 MCBsIFMNCm4gMTM3LjI3MTIgMTA4IG0gMTM3LjI3MTIgMTI2IGwgUw0KbiAxMzcuMjcxMiAx NDQgbSAxMzcuMjcxMiAxNjIgbCBTDQpuIDEzNy4yNzEyIDE4MCBtIDEzNy4yNzEyIDE5OCBs IFMNCm4gMTM3LjI3MTIgMjE2IG0gMTM3LjI3MTIgMjM0IGwgUw0KbiAxMzcuMjcxMiAyNTIg bSAxMzcuMjcxMiAyNzAgbCBTDQpuIDEzNy4yNzEyIDI4OCBtIDEzNy4yNzEyIDMwNiBsIFMN Cm4gMTM3LjI3MTIgMzI0IG0gMTM3LjI3MTIgMzQyIGwgUw0KbiAxMzcuMjcxMiAzNjAgbSAx MzcuMjcxMiAzNzggbCBTDQpuIDEzNy4yNzEyIDM5NiBtIDEzNy4yNzEyIDQxNCBsIFMNCm4g MTM3LjI3MTIgNDMyIG0gMTM3LjI3MTIgNDY4IGwgUw0KbiAyMDUuOTA2OCAwIG0gMjA1Ljkw NjggMTggbCBTDQpuIDIwNS45MDY4IDM2IG0gMjA1LjkwNjggNTQgbCBTDQpuIDIwNS45MDY4 IDcyIG0gMjA1LjkwNjggOTAgbCBTDQpuIDIwNS45MDY4IDEwOCBtIDIwNS45MDY4IDEyNiBs IFMNCm4gMjA1LjkwNjggMTQ0IG0gMjA1LjkwNjggMTYyIGwgUw0KbiAyMDUuOTA2OCAxODAg bSAyMDUuOTA2OCAxOTggbCBTDQpuIDIwNS45MDY4IDIxNiBtIDIwNS45MDY4IDIzNCBsIFMN Cm4gMjA1LjkwNjggMjUyIG0gMjA1LjkwNjggMjcwIGwgUw0KbiAyMDUuOTA2OCAyODggbSAy MDUuOTA2OCAzMDYgbCBTDQpuIDIwNS45MDY4IDMyNCBtIDIwNS45MDY4IDM0MiBsIFMNCm4g MjA1LjkwNjggMzYwIG0gMjA1LjkwNjggMzc4IGwgUw0KbiAyMDUuOTA2OCAzOTYgbSAyMDUu OTA2OCA0MTQgbCBTDQpuIDIwNS45MDY4IDQzMiBtIDIwNS45MDY4IDQ2OCBsIFMNCm4gMjYz Ljk4MyAwIG0gMjYzLjk4MyAxOCBsIFMNCm4gMjYzLjk4MyAzNiBtIDI2My45ODMgNTQgbCBT DQpuIDI2My45ODMgNzIgbSAyNjMuOTgzIDkwIGwgUw0KbiAyNjMuOTgzIDEwOCBtIDI2My45 ODMgMTI2IGwgUw0KbiAyNjMuOTgzIDE0NCBtIDI2My45ODMgMTYyIGwgUw0KbiAyNjMuOTgz IDE4MCBtIDI2My45ODMgMTk4IGwgUw0KbiAyNjMuOTgzIDIxNiBtIDI2My45ODMgMjM0IGwg Uw0KbiAyNjMuOTgzIDI1MiBtIDI2My45ODMgMjcwIGwgUw0KbiAyNjMuOTgzIDI4OCBtIDI2 My45ODMgMzA2IGwgUw0KbiAyNjMuOTgzIDMyNCBtIDI2My45ODMgMzQyIGwgUw0KbiAyNjMu OTgzIDM2MCBtIDI2My45ODMgMzc4IGwgUw0KbiAyNjMuOTgzIDM5NiBtIDI2My45ODMgNDE0 IGwgUw0KbiAyNjMuOTgzIDQzMiBtIDI2My45ODMgNDY4IGwgUw0KbiAzMzcuODk4MyAwIG0g MzM3Ljg5ODMgMTggbCBTDQpuIDMzNy44OTgzIDM2IG0gMzM3Ljg5ODMgNTQgbCBTDQpuIDMz Ny44OTgzIDcyIG0gMzM3Ljg5ODMgOTAgbCBTDQpuIDMzNy44OTgzIDEwOCBtIDMzNy44OTgz IDEyNiBsIFMNCm4gMzM3Ljg5ODMgMTQ0IG0gMzM3Ljg5ODMgMTYyIGwgUw0KbiAzMzcuODk4 MyAxODAgbSAzMzcuODk4MyAxOTggbCBTDQpuIDMzNy44OTgzIDIxNiBtIDMzNy44OTgzIDIz NCBsIFMNCm4gMzM3Ljg5ODMgMjUyIG0gMzM3Ljg5ODMgMjcwIGwgUw0KbiAzMzcuODk4MyAy ODggbSAzMzcuODk4MyAzMDYgbCBTDQpuIDMzNy44OTgzIDMyNCBtIDMzNy44OTgzIDM0MiBs IFMNCm4gMzM3Ljg5ODMgMzYwIG0gMzM3Ljg5ODMgMzc4IGwgUw0KbiAzMzcuODk4MyAzOTYg bSAzMzcuODk4MyA0MTQgbCBTDQpuIDMzNy44OTgzIDQzMiBtIDMzNy44OTgzIDQ2OCBsIFMN Cm4gNDAxLjI1NDIgMCBtIDQwMS4yNTQyIDE4IGwgUw0KbiA0MDEuMjU0MiAzNiBtIDQwMS4y NTQyIDU0IGwgUw0KbiA0MDEuMjU0MiA3MiBtIDQwMS4yNTQyIDkwIGwgUw0KbiA0MDEuMjU0 MiAxMDggbSA0MDEuMjU0MiAxMjYgbCBTDQpuIDQwMS4yNTQyIDE0NCBtIDQwMS4yNTQyIDE2 MiBsIFMNCm4gNDAxLjI1NDIgMTgwIG0gNDAxLjI1NDIgMTk4IGwgUw0KbiA0MDEuMjU0MiAy MTYgbSA0MDEuMjU0MiAyMzQgbCBTDQpuIDQwMS4yNTQyIDI1MiBtIDQwMS4yNTQyIDI3MCBs IFMNCm4gNDAxLjI1NDIgMjg4IG0gNDAxLjI1NDIgMzA2IGwgUw0KbiA0MDEuMjU0MiAzMjQg bSA0MDEuMjU0MiAzNDIgbCBTDQpuIDQwMS4yNTQyIDM2MCBtIDQwMS4yNTQyIDM3OCBsIFMN Cm4gNDAxLjI1NDIgMzk2IG0gNDAxLjI1NDIgNDE0IGwgUw0KbiA0MDEuMjU0MiA0MzIgbSA0 MDEuMjU0MiA0NTAgbCBTDQpuIDAgNDY4IG0gNDY5Ljg4OTggNDY4IGwgUw0KbiAwIDAgbSA0 NjkuODg5OCAwIGwgUw0KbiAwIDAgbSAwIDQ2OCBsIFMNCm4gNDY5Ljg4OTggMCBtIDQ2OS44 ODk4IDQ2OCBsIFMNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMTA4LjAyMzYgY20NClEN CiANCmVuZHN0cmVhbQ0KZW5kb2JqDQoxMTkgMCBvYmoNCjw8IC9MZW5ndGggNjMyMCA+Pg0K c3RyZWFtDQoxIDAgMCAxIDAgMCBjbSAgQlQgL0YxIDEyIFRmIDE0LjQgVEwgRVQNCnENCjEg MCAwIDEgNjIuNjkyOTEgNzQ3LjAyMzYgY20NCnENCkJUIDEgMCAwIDEgMCAzIFRtIDE4IFRM IC9GMiAxNSBUZiAwIDAgMCByZyAoMy4yICAgRG9tYWluIGNvbnN0cnVjdGlvbikgVGogVCog RVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNjkzLjAyMzYgY20NCnENCjAgMCAwIHJn DQpCVCAxIDAgMCAxIDAgMzggVG0gL0YxIDEwIFRmIDEyIFRMIC44NzM4MjggVHcgKEFuIGlt cG9ydGFudCBhc3BlY3Qgb2YgdGhlIGh5cGVybGF1bmNoIGFyY2hpdGVjdHVyZSBpcyB0aGF0 IHRoZSBoeXBlcnZpc29yIHBlcmZvcm1zIGRvbWFpbiBjb25zdHJ1Y3Rpb24pIFRqIFQqIDAg VHcgMi4xMDY0NTcgVHcgKGZvciBhbGwgdGhlIEluaXRpYWwgRG9tYWlucy4gaWUuIGl0IGJ1 aWxkcyBlYWNoIGRvbWFpbiB0aGF0IGlzIGRlc2NyaWJlZCBpbiB0aGUgTGF1bmNoIENvbnRy b2wgTW9kdWxlLikgVGogVCogMCBUdyAxLjA4NTgxNCBUdyAoUGxlYXNlLCBzZWUgdGhlIFwy MjFIeXBlcmxhdW5jaCBEZXZpY2UgVHJlZVwyMjIgZGVzaWduIGRvY3VtZW50LCB3aGljaCBk ZXNjcmliZXMgdGhlIGNvbmZpZ3VyYXRpb24gbW9kdWxlKSBUaiBUKiAwIFR3ICh0aGF0IGlz IHByb3ZpZGVkIHRvIHRoZSBoeXBlcnZpc29yIGJ5IHRoZSBib290bG9hZGVyLikgVGogVCog RVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNjUxLjAyMzYgY20NCnENCjAgMCAwIHJn DQpCVCAxIDAgMCAxIDAgMjYgVG0gL0YxIDEwIFRmIDEyIFRMIC42NDY2NTEgVHcgKFRoZSBo eXBlcnZpc29yIGRldGVybWluZXMgaG93IHRoZXNlIGRvbWFpbnMgYXJlIHN0YXJ0ZWQgYXMg aG9zdCBib290IGNvbXBsZXRlczogaW4gc29tZSBzeXN0ZW1zIHRoZSkgVGogVCogMCBUdyA0 LjA3NjkwNSBUdyAoQm9vdCBEb21haW4gYWN0cyB1cG9uIHRoZSBleHRlbmRlZCBib290IGNv bmZpZ3VyYXRpb24gc3VwcGxpZWQgYXMgcGFydCBvZiBsYXVuY2gsIHBlcmZvcm1pbmcpIFRq IFQqIDAgVHcgKGNvbmZpZ3VyYXRpb24gdGFza3MgZm9yIHByZXBhcmluZyB0aGUgb3RoZXIg ZG9tYWlucyBmb3IgdGhlIGh5cGVydmlzb3IgdG8gY29tbWVuY2UgcnVubmluZyB0aGVtLikg VGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNjIxLjAyMzYgY20NCnENCkJU IDEgMCAwIDEgMCAzIFRtIDE4IFRMIC9GMiAxNSBUZiAwIDAgMCByZyAoMy4zICAgQ29tbW9u IEJvb3QgQ29uZmlndXJhdGlvbnMpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5 MjkxIDU2Ny4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDM4IFRtIC9GMSAx MCBUZiAxMiBUTCAyLjI3OTI2OSBUdyAoV2hlbiBsb29raW5nIGFjcm9zcyB0aG9zZSB0aGF0 IGhhdmUgZXhwcmVzc2VkIGludGVyZXN0IG9yIGRpc2N1c3NlZCBhIG5lZWQgZm9yIGxhdW5j aGluZyBtdWx0aXBsZSkgVGogVCogMCBUdyAuNjczMTEgVHcgKGRvbWFpbnMgYXQgaG9zdCBi b290LCB0aGUgaHlwZXJsYXVuY2ggYXBwcm9hY2ggaXMgdG8gcHJvdmlkZSB0aGUgbWVhbnMg dG8gc3RhcnQgbmVhcmx5IGFueSBjb21iaW5hdGlvbikgVGogVCogMCBUdyAyLjgzNDk4MyBU dyAob2YgZG9tYWlucy4gQmVsb3cgaXMgYW4gZW51bWVyYXRlZCBzZWxlY3Rpb24gb2YgY29t bW9uIGJvb3QgY29uZmlndXJhdGlvbnMgZm9yIHJlZmVyZW5jZSBpbiB0aGUpIFRqIFQqIDAg VHcgKGZvbGxvd2luZyBzZWN0aW9uLikgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIu NjkyOTEgNTQwLjAyMzYgY20NCnENCkJUIDEgMCAwIDEgMCAyLjUgVG0gMTUgVEwgL0YzIDEy LjUgVGYgMCAwIDAgcmcgKDMuMy4xICAgRHluYW1pYyBMYXVuY2ggd2l0aCBhIEhpZ2hseS1Q cml2aWxlZ2VkIERvbWFpbiAwKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5 MSA1MjIuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMiAxMCBU ZiAxMiBUTCAoSHlwZXJsYXVuY2ggQ2xhc3NpYzogRG9tMCkgVGogVCogRVQNClENClENCnEN CjEgMCAwIDEgNjIuNjkyOTEgNDgzLjAyMzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYg MTIgVEwgRVQNCkJUIDEgMCAwIDEgMCAyNiBUbSAgVCogRVQNCnENCjEgMCAwIDEgMjAgMCBj bQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyNiBUbSAvRjEgMTAgVGYgMTIgVEwgMS40 NDkyNjkgVHcgKFRoaXMgY29uZmlndXJhdGlvbiBtaW1pY3MgdGhlIGNsYXNzaWMgWGVuIHN0 YXJ0IGFuZCBkb21haW4gY29uc3RydWN0aW9uIHdoZXJlIGEgc2luZ2xlIGRvbWFpbiBpcykg VGogVCogMCBUdyAzLjQ1OTA2OSBUdyAoY29uc3RydWN0ZWQgd2l0aCBhbGwgcHJpdmlsZWdl cyBhbmQgZnVuY3Rpb25zIGZvciBtYW5hZ2luZyBoYXJkd2FyZSBhbmQgcnVubmluZyB2aXJ0 dWFsaXphdGlvbikgVGogVCogMCBUdyAodG9vbHN0YWNrIHNvZnR3YXJlLikgVGogVCogRVQN ClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNDY3LjAyMzYgY20NCnENCjAg MCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIgVEwgKEh5cGVybGF1bmNo IENsYXNzaWM6IEV4dGVuZGVkIExhdW5jaCBEb20wKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAw IDAgMSA2Mi42OTI5MSA0MjguMDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBU TCBFVA0KQlQgMSAwIDAgMSAwIDI2IFRtICBUKiBFVA0KcQ0KMSAwIDAgMSAyMCAwIGNtDQpx DQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDI2IFRtIC9GMSAxMCBUZiAxMiBUTCAxLjQ5Nzc2 NSBUdyAoVGhpcyBjb25maWd1cmF0aW9uIGlzIHdoZXJlIGEgRG9tMCBpcyBzdGFydGVkIHZp YSBhIEJvb3QgRG9tYWluIHRoYXQgcnVucyBmaXJzdC4gVGhpcyBpcyBmb3IgY2FzZXMpIFRq IFQqIDAgVHcgMS4zNDY5MDUgVHcgKHdoZXJlIHNvbWUgcHJlcHJvY2Vzc2luZyBpbiBhIGxl c3MgcHJpdmlsZWdlZCBkb21haW4gaXMgcmVxdWlyZWQgYmVmb3JlIHN0YXJ0aW5nIHRoZSBh bGwtcHJpdmlsZWdlZCkgVGogVCogMCBUdyAoRG9tYWluIDAuKSBUaiBUKiBFVA0KUQ0KUQ0K cQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA0MTIuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcN CkJUIDEgMCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoSHlwZXJsYXVuY2ggQ2xhc3Np YzogQmFzaWMgQ2xvdWQpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDM4 NS4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpCVCAxIDAgMCAx IDAgMTQgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDAgY20NCnENCjAgMCAwIHJnDQpCVCAx IDAgMCAxIDAgMTQgVG0gL0YxIDEwIFRmIDEyIFRMIDIuNzE5MjY5IFR3IChUaGlzIGNvbmZp Z3VyYXRpb24gY29uc3RydWN0cyBhIERvbTAgdGhhdCBpcyBzdGFydGVkIGluIHBhcmFsbGVs IHdpdGggc29tZSBudW1iZXIgb2Ygd29ya2xvYWQpIFRqIFQqIDAgVHcgKGRvbWFpbnMuKSBU aiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAzNjkuMDIzNiBj bQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoSHlw ZXJsYXVuY2ggQ2xhc3NpYzogQ2xvdWQpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYy LjY5MjkxIDM0Mi4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpC VCAxIDAgMCAxIDAgMTQgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDAgY20NCnENCjAgMCAw IHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEwIFRmIDEyIFRMIDIuMzU5OTgzIFR3IChU aGlzIGNvbmZpZ3VyYXRpb24gYnVpbGRzIGEgRG9tMCBhbmQgc29tZSBudW1iZXIgb2Ygd29y a2xvYWQgZG9tYWlucywgbGF1bmNoZWQgdmlhIGEgQm9vdCkgVGogVCogMCBUdyAoRG9tYWlu IHRoYXQgcnVucyBmaXJzdC4pIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAx IDYyLjY5MjkxIDMxNS4wMjM2IGNtDQpxDQpCVCAxIDAgMCAxIDAgMi41IFRtIDE1IFRMIC9G MyAxMi41IFRmIDAgMCAwIHJnICgzLjMuMiAgIFN0YXRpYyBMYXVuY2ggQ29uZmlndXJhdGlv bnM6IHdpdGhvdXQgYSBEb21haW4gMCBvciBhIENvbnRyb2wgRG9tYWluKSBUaiBUKiBFVA0K UQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAyOTcuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJU IDEgMCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoSHlwZXJsYXVuY2ggU3RhdGljOiBC YXNpYykgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMjU4LjAyMzYgY20N CjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCkJUIDEgMCAwIDEgMCAyNiBUbSAg VCogRVQNCnENCjEgMCAwIDEgMjAgMCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAy NiBUbSAvRjEgMTAgVGYgMTIgVEwgLjAxNDY5MiBUdyAoU2ltcGxlIHN0YXRpYyBwYXJ0aXRp b25pbmcgd2hlcmUgYWxsIGRvbWFpbnMgdGhhdCBjYW4gYmUgcnVuIG9uIHRoaXMgc3lzdGVt IGFyZSBidWlsdCBhbmQgc3RhcnRlZCBkdXJpbmcpIFRqIFQqIDAgVHcgMS4wNTgxMSBUdyAo aG9zdCBib290IGFuZCB3aGVyZSBubyBkb21haW4gaXMgc3RhcnRlZCB3aXRoIHRoZSBDb250 cm9sIERvbWFpbiBwZXJtaXNzaW9ucywgdGh1cyBtYWtpbmcgaXQgbm90KSBUaiBUKiAwIFR3 IChwb3NzaWJsZSB0byBjcmVhdGUvc3RhcnQgYW55IGZ1cnRoZXIgbmV3IGRvbWFpbnMuKSBU aiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAyNDIuMDIzNiBj bQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoSHlw ZXJsYXVuY2ggU3RhdGljOiBTdGFuZGFyZCkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEg NjIuNjkyOTEgMTkxLjAyMzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQN CkJUIDEgMCAwIDEgMCAzOCBUbSAgVCogRVQNCnENCjEgMCAwIDEgMjAgMCBjbQ0KcQ0KMCAw IDAgcmcNCkJUIDEgMCAwIDEgMCAzOCBUbSAvRjEgMTAgVGYgMTIgVEwgMy41MjYxMzYgVHcg KFRoaXMgaXMgYSB2YXJpYXRpb24gb2YgdGhlIFwyMjNIeXBlcmxhdW5jaCBTdGF0aWM6IEJh c2ljXDIyNCBzdGF0aWMgcGFydGl0aW9uaW5nIGNvbmZpZ3VyYXRpb24gd2l0aCB0aGUpIFRq IFQqIDAgVHcgLjIyODg3NiBUdyAoaW50cm9kdWN0aW9uIG9mIGEgQm9vdCBEb21haW4uIFRo aXMgY29uZmlndXJhdGlvbiBhbGxvd3MgZm9yIHVzZSBvZiBhIEJvb3QgRG9tYWluIHRvIGJl IGFibGUgdG8gcGFyc2UpIFRqIFQqIDAgVHcgMS4xMjg1NTUgVHcgKGFuZCBhcHBseSBleHRl bmRlZCBjb25maWd1cmF0aW9uIHJldHJpZXZlZCBmcm9tIHRoZSBEZXZpY2UgVHJlZSB0byB0 aGUgSW5pdGlhbCBEb21haW5zIGJlZm9yZSB0aGV5KSBUaiBUKiAwIFR3IChhcmUgc3RhcnRl ZC4pIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDE3NS4w MjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YyIDEwIFRmIDEyIFRM IChIeXBlcmxhdW5jaCBTdGF0aWM6IERpc2FnZ3JlZ2F0ZWQpIFRqIFQqIEVUDQpRDQpRDQpx DQoxIDAgMCAxIDYyLjY5MjkxIDE0OC4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRm IDEyIFRMIEVUDQpCVCAxIDAgMCAxIDAgMTQgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDAg Y20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEwIFRmIDEyIFRMIC42 ODI2NTEgVHcgKFRoaXMgaXMgYSB2YXJpYXRpb24gb2YgdGhlIFwyMjNIeXBlcmxhdW5jaCBT dGF0aWM6IFN0YW5kYXJkXDIyNCBjb25maWd1cmF0aW9uIHdpdGggdGhlIGludHJvZHVjdGlv biBvZiBhIEJvb3QpIFRqIFQqIDAgVHcgKERvbWFpbiBhbmQgYW4gaWxsdXN0cmF0aW9uIHRo YXQgc29tZSBmdW5jdGlvbnMgY2FuIGJlIGRpc2FnZ3JlZ2F0ZWQgdG8gZGVkaWNhdGVkIGRv bWFpbnMuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAx MjEuMDIzNiBjbQ0KcQ0KQlQgMSAwIDAgMSAwIDIuNSBUbSAxNSBUTCAvRjMgMTIuNSBUZiAw IDAgMCByZyAoMy4zLjMgICBEeW5hbWljIExhdW5jaCBvZiBEaXNhZ2dyZWdhdGVkIFN5c3Rl bSBDb25maWd1cmF0aW9ucykgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEg MTAzLjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYg MTIgVEwgKEh5cGVybGF1bmNoIER5bmFtaWM6IEhhcmR3YXJlIERvbWFpbikgVGogVCogRVQN ClENClENCiANCmVuZHN0cmVhbQ0KZW5kb2JqDQoxMjAgMCBvYmoNCjw8IC9MZW5ndGggNjE1 MCA+Pg0Kc3RyZWFtDQoxIDAgMCAxIDAgMCBjbSAgQlQgL0YxIDEyIFRmIDE0LjQgVEwgRVQN CnENCjEgMCAwIDEgNjIuNjkyOTEgNzM4LjAyMzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAg VGYgMTIgVEwgRVQNCkJUIDEgMCAwIDEgMCAxNCBUbSAgVCogRVQNCnENCjEgMCAwIDEgMjAg MCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAxNCBUbSAvRjEgMTAgVGYgMTIgVEwg Mi4wNzE1MiBUdyAoVGhpcyBjb25maWd1cmF0aW9uIG1pbWljcyB0aGUgZXhpc3RpbmcgWGVu IGZlYXR1cmUgbGF0ZSBoYXJkd2FyZSBkb21haW4gd2l0aCB0aGUgb25lIGRpZmZlcmVuY2Up IFRqIFQqIDAgVHcgKGJlaW5nIHRoYXQgdGhlIGhhcmR3YXJlIGRvbWFpbiBpcyBjb25zdHJ1 Y3RlZCBieSB0aGUgaHlwZXJ2aXNvciBhdCBzdGFydHVwIGluc3RlYWQgb2YgbGF0ZXIgYnkg RG9tMC4pIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDcy Mi4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YyIDEwIFRmIDEy IFRMIChIeXBlcmxhdW5jaCBEeW5hbWljOiBGbGV4aWJsZSBEaXNhZ2dyZWdhdGlvbikgVGog VCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNjgzLjAyMzYgY20NCjAgMCAwIHJn DQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCkJUIDEgMCAwIDEgMCAyNiBUbSAgVCogRVQNCnEN CjEgMCAwIDEgMjAgMCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyNiBUbSAvRjEg MTAgVGYgMTIgVEwgLjc0OTIxMyBUdyAoVGhpcyBjb25maWd1cmF0aW9uIGlzIHNpbWlsYXIg dG8gdGhlIFwyMjNIeXBlcmxhdW5jaCBDbGFzc2ljOiBEb20wXDIyNCBjb25maWd1cmF0aW9u IGV4Y2VwdCB0aGF0IGl0IGluY2x1ZGVzKSBUaiBUKiAwIFR3IC43NzQyNjkgVHcgKHN0YXJ0 aW5nIGEgc2VwYXJhdGUgaGFyZHdhcmUgZG9tYWluIGR1cmluZyBYZW4gc3RhcnR1cC4gSXQg aXMgYWxzbyBzaW1pbGFyIHRvIFwyMjNIeXBlcmxhdW5jaCBEeW5hbWljOikgVGogVCogMCBU dyAoSGFyZHdhcmUgRG9tYWluXDIyNCBjb25maWd1cmF0aW9uLCBidXQgaXQgbGF1bmNoZXMg dmlhIGEgQm9vdCBEb21haW4gdGhhdCBydW5zIGZpcnN0LikgVGogVCogRVQNClENClENCnEN ClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNjY3LjAyMzYgY20NCnENCjAgMCAwIHJnDQpC VCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIgVEwgKEh5cGVybGF1bmNoIER5bmFtaWM6 IEZ1bGwgRGlzYWdncmVnYXRpb24pIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5 MjkxIDYxNi4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpCVCAx IDAgMCAxIDAgMzggVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDAgY20NCnENCjAgMCAwIHJn DQpCVCAxIDAgMCAxIDAgMzggVG0gL0YxIDEwIFRmIDEyIFRMIDEuMzAwNjEgVHcgKEluIHRo aXMgY29uZmlndXJhdGlvbiBpdCBpcyBkZW1vbnN0cmF0ZWQgaG93IGl0IGlzIHBvc3NpYmxl IHRvIHN0YXJ0IGEgZnVsbHkgZGlzYWdncmVnYXRlZCBzeXN0ZW06IHRoZSkgVGogVCogMCBU dyAzLjgyMDgxNCBUdyAodmlydHVhbGl6YXRpb24gdG9vbHN0YWNrIHJ1bnMgaW4gYSBDb250 cm9sIERvbWFpbiwgc2VwYXJhdGUgZnJvbSB0aGUgZG9tYWlucyByZXNwb25zaWJsZSBmb3Ip IFRqIFQqIDAgVHcgMS45Mzk5ODIgVHcgKG1hbmFnaW5nIGhhcmR3YXJlLCBYZW5TdG9yZSwg dGhlIFhlbiBDb25zb2xlIGFuZCBDcmFzaCBmdW5jdGlvbnMsIGVhY2ggbGF1bmNoZWQgdmlh IGEgQm9vdCkgVGogVCogMCBUdyAoRG9tYWluLikgVGogVCogRVQNClENClENCnENClENClEN CnENCjEgMCAwIDEgNjIuNjkyOTEgNTg5LjAyMzYgY20NCnENCkJUIDEgMCAwIDEgMCAyLjUg VG0gMTUgVEwgL0YzIDEyLjUgVGYgMCAwIDAgcmcgKDMuMy40ICAgRXhhbXBsZSBVc2UgQ2Fz ZXMgYW5kIENvbmZpZ3VyYXRpb25zKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42 OTI5MSA1NzEuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAx MCBUZiAxMiBUTCAoVGhlIGZvbGxvd2luZyBleGFtcGxlIHVzZSBjYXNlcyBjYW4gYmUgbWF0 Y2hlZCB0byBjb25maWd1cmF0aW9ucyBsaXN0ZWQgaW4gdGhlIHByZXZpb3VzIHNlY3Rpb24u KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA1NDcuMDIzNiBjbQ0KcQ0K QlQgMSAwIDAgMSAwIDIgVG0gMTIgVEwgL0YzIDEwIFRmIDAgMCAwIHJnICgzLjMuNC4xICAg VXNlIGNhc2U6IE1vZGVybiBjbG91ZCBoeXBlcnZpc29yKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0K MSAwIDAgMSA2Mi42OTI5MSA1MjkuMDIzNiBjbQ0KcQ0KQlQgMSAwIDAgMSAwIDIgVG0gMTIg VEwgL0YyIDEwIFRmIDAgMCAwIHJnIChPcHRpb246ICkgVGogL0YxIDEwIFRmIChIeXBlcmxh dW5jaCBDbGFzc2ljOiBDbG91ZCkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjky OTEgNDg3LjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMjYgVG0gL0YxIDEw IFRmIDEyIFRMIC4yMDI2NTEgVHcgKFRoaXMgY29uZmlndXJhdGlvbiB3aWxsIHN1cHBvcnQg c3Ryb25nIGlzb2xhdGlvbiBmb3IgdmlydHVhbCBUUE0gZG9tYWlucyBhbmQgbWVhc3VyZWQg bGF1bmNoIGluIHN1cHBvcnQgb2YpIFRqIFQqIDAgVHcgLjgwODMxNCBUdyAoYXR0ZXN0YXRp b24gdG8gaW5mcmFzdHJ1Y3R1cmUgbWFuYWdlbWVudCwgd2hpbGUgYWxsb3dpbmcgdGhlIHVz ZSBvZiBleGlzdGluZyBEb20wIHZpcnR1YWxpemF0aW9uIHRvb2xzdGFjaykgVGogVCogMCBU dyAoc29mdHdhcmUuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA0NjMu MDIzNiBjbQ0KcQ0KQlQgMSAwIDAgMSAwIDIgVG0gMTIgVEwgL0YzIDEwIFRmIDAgMCAwIHJn ICgzLjMuNC4yICAgVXNlIGNhc2U6IEVkZ2UgZGV2aWNlIHdpdGggc2VjdXJpdHkgb3Igc2Fm ZXR5IHJlcXVpcmVtZW50cykgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEg NDQ1LjAyMzYgY20NCnENCkJUIDEgMCAwIDEgMCAyIFRtIDEyIFRMIC9GMiAxMCBUZiAwIDAg MCByZyAoT3B0aW9uOiApIFRqIC9GMSAxMCBUZiAoSHlwZXJsYXVuY2ggU3RhdGljOiBCb290 KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA0MTUuMDIzNiBjbQ0KcQ0K MCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAxNCBUbSAvRjEgMTAgVGYgMTIgVEwgNS4yNzcyNTEg VHcgKFRoaXMgY29uZmlndXJhdGlvbiBydW5zIHdpdGhvdXQgcmVxdWlyaW5nIGEgaGlnaGx5 LXByaXZpbGVnZWQgRG9tMCwgYW5kIGVuYWJsZXMgZXh0ZW5kZWQgVk0pIFRqIFQqIDAgVHcg KGNvbmZpZ3VyYXRpb24gdG8gYmUgYXBwbGllZCB0byB0aGUgSW5pdGlhbCBWTXMgcHJpb3Ig dG8gbGF1bmNoaW5nIHRoZW0sIG9wdGlvbmFsbHkgaW4gYSBzZXF1ZW5jZWQgc3RhcnQuKSBU aiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAzOTEuMDIzNiBjbQ0KcQ0KQlQg MSAwIDAgMSAwIDIgVG0gMTIgVEwgL0YzIDEwIFRmIDAgMCAwIHJnICgzLjMuNC4zICAgVXNl IGNhc2U6IENsaWVudCBoeXBlcnZpc29yKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2 Mi42OTI5MSAzNzMuMDIzNiBjbQ0KcQ0KQlQgMSAwIDAgMSAwIDIgVG0gMTIgVEwgL0YyIDEw IFRmIDAgMCAwIHJnIChPcHRpb246ICkgVGogL0YxIDEwIFRmIChIeXBlcmxhdW5jaCBEeW5h bWljOiBGbGV4aWJsZSBEaXNhZ2dyZWdhdGlvbikgVGogVCogRVQNClENClENCnENCjEgMCAw IDEgNjIuNjkyOTEgMzU1LjAyMzYgY20NCnENCkJUIDEgMCAwIDEgMCAyIFRtIDEyIFRMIC9G MiAxMCBUZiAwIDAgMCByZyAoT3B0aW9uOiApIFRqIC9GMSAxMCBUZiAoSHlwZXJsYXVuY2gg RHluYW1pYzogRnVsbCBEaXNhZ2dyZWdhdGlvbikgVGogVCogRVQNClENClENCnENCjEgMCAw IDEgNjIuNjkyOTEgMzEzLjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMjYg VG0gL0YxIDEwIFRmIDEyIFRMIDMuMTY5MTQ3IFR3IChUaGVzZSBjb25maWd1cmF0aW9ucyBl bmFibGUgZHluYW1pYyBjbGllbnQgd29ya2xvYWRzLCBzdHJvbmcgaXNvbGF0aW9uIGZvciB0 aGUgZG9tYWluIHJ1bm5pbmcgdGhlKSBUaiBUKiAwIFR3IDEuMDgzNjE1IFR3ICh2aXJ0dWFs aXphdGlvbiB0b29sc3RhY2sgc29mdHdhcmUgYW5kIGVhY2ggZG9tYWluIG1hbmFnaW5nIGhh cmR3YXJlLCB3aXRoIFBDSSBwYXNzdGhyb3VnaCBwZXJmb3JtZWQpIFRqIFQqIDAgVHcgKGR1 cmluZyBob3N0IGJvb3QgYW5kIHN1cHBvcnQgZm9yIG1lYXN1cmVkIGxhdW5jaC4pIFRqIFQq IEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDI4My4wMjM2IGNtDQpxDQpCVCAxIDAg MCAxIDAgMyBUbSAxOCBUTCAvRjIgMTUgVGYgMCAwIDAgcmcgKDMuNCAgIGh5cGVybGF1bmNo IERpc2FnZ3JlZ2F0ZWQgTGF1bmNoKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42 OTI5MSAxOTMuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCA3NCBUbSAvRjEg MTAgVGYgMTIgVEwgMi4wMDIxMjYgVHcgKEV4aXN0aW5nIGluIFhlbiB0b2RheSBhcmUgdHdv IHBlcm1pc3Npb25zLCBjb250cm9sIGRvbWFpbiBhbmQgaGFyZHdhcmUgZG9tYWluLCBhbmQg dHdvIGZ1bmN0aW9ucywpIFRqIFQqIDAgVHcgMS41MDc0ODUgVHcgKGNvbnNvbGUgZG9tYWlu IGFuZCB4ZW5zdG9yZSBkb21haW4sIHRoYXQgY2FuIGJlIGFzc2lnbmVkIHRvIGEgZG9tYWlu LiBBIHRoaXJkIGltcGxpY2l0IGZ1bmN0aW9uIGFsc28pIFRqIFQqIDAgVHcgLjgxMTQxMiBU dyAoZXhpc3RzOiB0aGUgY3Jhc2ggZG9tYWluLCBpbnRlbmRlZCB0byBhc3Npc3Qgd2l0aCBm YWlsdXJlIHJlY292ZXJ5IGR1cmluZyBob3N0IGJvb3QuVHJhZGl0aW9uYWxseSB0aGVzZSBh cmUpIFRqIFQqIDAgVHcgMS40MzEwOTggVHcgKGFsbCBhc3NpZ25lZCB0byBEb20wIGF0IHN0 YXJ0IGFuZCBjYW4gdGhlbiBiZSBkZWxlZ2F0ZWQgdG8gb3RoZXIgZG9tYWlucyBjcmVhdGVk IGJ5IHRoZSB0b29sc3RhY2sgaW4pIFRqIFQqIDAgVHcgLjA5MDY1MSBUdyAoRG9tMC4gV2l0 aCBoeXBlcmxhdW5jaCBpdCBiZWNvbWVzIHBvc3NpYmxlIHRvIGFzc2lnbiB0aGVzZSBwZXJt aXNzaW9ucyBhbmQgZnVuY3Rpb25zIHRvIGFueSBkb21haW4gZm9yKSBUaiBUKiAwIFR3IDIu NjI2MTM2IFR3ICh3aGljaCB0aGVyZSBpcyBhIGRlZmluaXRpb24gcHJvdmlkZWQgYXQgc3Rh cnR1cC4gQWRkaXRpb25hbGx5IGh5cGVybGF1bmNoIHByb21vdGVzIHRoZSBjcmFzaCBkb21h aW4pIFRqIFQqIDAgVHcgKGZ1bmN0aW9uIHRvIGFuIGV4cGxpY2l0IGZ1bmN0aW9uIGFuZCBp bnRyb2R1Y2VzIHRoZSBib290IGRvbWFpbiBmdW5jdGlvbi4pIFRqIFQqIEVUDQpRDQpRDQpx DQoxIDAgMCAxIDYyLjY5MjkxIDExNS4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAg MSAwIDYyIFRtIC9GMSAxMCBUZiAxMiBUTCAuNDUxNDEyIFR3IChTdXBwb3J0aW5nIHRoZSBi b290aW5nIG9mIGVhY2ggb2YgdGhlIGFib3ZlIGNvbW1vbiBib290IGNvbmZpZ3VyYXRpb25z IGlzIGFjY29tcGxpc2hlZCBieSBjb25zaWRlcmluZykgVGogVCogMCBUdyAxLjk0MTMxOCBU dyAodGhlIHNldCBvZiBpbml0aWFsIGRvbWFpbnMgYW5kIHRoZSBhc3NpZ25tZW50IG9mIFhl blwyMjJzIHBlcm1pc3Npb25zIGFuZCBmdW5jdGlvbnMsIGluY2x1ZGluZyB0aGUgb25lcykg VGogVCogMCBUdyAuMzM5OTg2IFR3IChpbnRyb2R1Y2VkIGJ5IGh5cGVybGF1bmNoLCB0byB0 aGVzZSBkb21haW5zLiBBIGRpc2N1c3Npb24gb2YgdGhlc2Ugd2lsbCBiZSBjb3ZlcmVkIGxh dGVyIGJ1dCBmb3Igbm93IHRoZXkpIFRqIFQqIDAgVHcgLjQ1NDQ4OCBUdyAoYXJlIGxhaWQg b3V0IGluIGEgdGFibGUgd2l0aCBhIG1hcHBpbmcgdG8gdGhlIGNvbW1vbiBib290IGNvbmZp Z3VyYXRpb25zLiBUaGlzIHRhYmxlIGlzIG5vdCBpbnRlbmRlZCB0byBiZSkgVGogVCogMCBU dyAuNzQyNDg1IFR3IChhbiBleGhhdXN0aXZlIGxpc3Qgb2YgY29uZmlndXJhdGlvbnMgYW5k IGRvZXMgbm90IGFjY291bnQgZm9yIGZsYXNrIHBvbGljeSBzcGVjaWZpZWQgZnVuY3Rpb25z IHRoYXQgYXJlIHVzZSkgVGogVCogMCBUdyAoY2FzZSBzcGVjaWZpYy4pIFRqIFQqIEVUDQpR DQpRDQogDQplbmRzdHJlYW0NCmVuZG9iag0KMTIxIDAgb2JqDQo8PCAvTGVuZ3RoIDEyNjUw ID4+DQpzdHJlYW0NCjEgMCAwIDEgMCAwIGNtICBCVCAvRjEgMTIgVGYgMTQuNCBUTCBFVA0K cQ0KMSAwIDAgMSA2Mi42OTI5MSA3MjkuMDIzNiBjbQ0KcQ0KQlQgMSAwIDAgMSAwIDI2IFRt IDQuMjA1MzY2IFR3IDEyIFRMIC9GMSAxMCBUZiAwIDAgMCByZyAoSW4gdGhlIHRhYmxlIGVh Y2ggbnVtYmVyIHJlcHJlc2VudHMgYSBzZXBhcmF0ZSBkb21haW4gYmVpbmcgY29uc3RydWN0 ZWQgYnkgdGhlIGh5cGVybGF1bmNoKSBUaiBUKiAwIFR3IDIuNDg5OTg0IFR3IChjb25zdHJ1 Y3Rpb24gcGF0aCBhcyBYZW4gc3RhcnRzLCBhbmQgdGhlIGRlc2lnbmF0b3IsICkgVGogL0Y0 IDEwIFRmIDAgMCAwIHJnICh7bn0gKSBUaiAvRjEgMTAgVGYgMCAwIDAgcmcgKHNpZ25pZmll cyB0aGF0IHRoZXJlIG1heSBiZSBcMjIzblwyMjQgYWRkaXRpb25hbCkgVGogVCogMCBUdyAo ZG9tYWlucyB0aGF0IG1heSBiZSBjb25zdHJ1Y3RlZCB0aGF0IGRvIG5vdCBoYXZlIGFueSBz cGVjaWFsIHJvbGUgZm9yIGEgZ2VuZXJhbCBYZW4gc3lzdGVtLikgVGogVCogRVQNClENClEN CnENCjEgMCAwIDEgNjIuNjkyOTEgNzIzLjAyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjky OTEgNDQ3LjAyMzYgY20NCjEgMSAxIHJnDQpuIDAgMjc2IDQ2OS44ODk4IC0xOCByZSBmKg0K Ljg3ODQzMSAuODc4NDMxIC44Nzg0MzEgcmcNCm4gMCAyNTggNDY5Ljg4OTggLTMwIHJlIGYq DQoxIDEgMSByZw0KbiAwIDIyOCA0NjkuODg5OCAtMTggcmUgZioNCi44Nzg0MzEgLjg3ODQz MSAuODc4NDMxIHJnDQpuIDAgMjEwIDQ2OS44ODk4IC0zMCByZSBmKg0KMSAxIDEgcmcNCm4g MCAxODAgNDY5Ljg4OTggLTE4IHJlIGYqDQouODc4NDMxIC44Nzg0MzEgLjg3ODQzMSByZw0K biAwIDE2MiA0NjkuODg5OCAtMTggcmUgZioNCjEgMSAxIHJnDQpuIDAgMTQ0IDQ2OS44ODk4 IC0xOCByZSBmKg0KLjg3ODQzMSAuODc4NDMxIC44Nzg0MzEgcmcNCm4gMCAxMjYgNDY5Ljg4 OTggLTE4IHJlIGYqDQoxIDEgMSByZw0KbiAwIDEwOCA0NjkuODg5OCAtMTggcmUgZioNCi44 Nzg0MzEgLjg3ODQzMSAuODc4NDMxIHJnDQpuIDAgOTAgNDY5Ljg4OTggLTMwIHJlIGYqDQox IDEgMSByZw0KbiAwIDYwIDQ2OS44ODk4IC0zMCByZSBmKg0KLjg3ODQzMSAuODc4NDMxIC44 Nzg0MzEgcmcNCm4gMCAzMCA0NjkuODg5OCAtMzAgcmUgZioNCi45NjA3ODQgLjk2MDc4NCAu ODYyNzQ1IHJnDQpuIDAgMjc2IDQ2OS44ODk4IC0xOCByZSBmKg0KMCAwIDAgcmcNCkJUIC9G MSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAgMSA2IDI2MSBjbQ0KcQ0KLjk2MDc4NCAuOTYw Nzg0IC44NjI3NDUgcmcNCm4gMCAwIDEyMS4yNTIzIDEyIHJlIGYqDQpRDQpxDQowIDAgMCBy Zw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDMwLjg5MTE2IDAgVGQgKENv bmZpZ3VyYXRpb24pIFRqIFQqIC0zMC44OTExNiAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAx IDEzOS4yNTIzIDI2MSBjbQ0KcQ0KLjk2MDc4NCAuOTYwNzg0IC44NjI3NDUgcmcNCm4gMCAw IDEwMC4yMTI1IDEyIHJlIGYqDQpRDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0g L0YxIDEwIFRmIDEyIFRMIDI1LjM4MTI0IDAgVGQgKFBlcm1pc3Npb24pIFRqIFQqIC0yNS4z ODEyNCAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDI1MS40NjQ4IDI2MSBjbQ0KcQ0KLjk2 MDc4NCAuOTYwNzg0IC44NjI3NDUgcmcNCm4gMCAwIDIxMi40MjUgMTIgcmUgZioNClENCnEN CjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgODcuMDM3NDgg MCBUZCAoRnVuY3Rpb24pIFRqIFQqIC04Ny4wMzc0OCAwIFRkIEVUDQpRDQpRDQowIDAgMCBy Zw0KcQ0KMSAwIDAgMSAxMzkuMjUyMyAyNDMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAx IDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKE5vbmUpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAg MCAxIDE4MS4zMzIgMjQzIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0Yx IDEwIFRmIDEyIFRMIChDdHJsKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMjMuNDEx NyAyMzEgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEwIFRmIDEy IFRMIChIKSBUaiBUKiAoVykgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMjUxLjQ2NDgg MjQzIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRM IChCb290KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyOTMuNTQ0NSAyNDMgY20NCnEN CjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKENyYXNoKSBU aiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzNDIuNjM3NCAyNDMgY20NCnENCjAgMCAwIHJn DQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKENvbnNvbGUpIFRqIFQqIEVU DQpRDQpRDQpxDQoxIDAgMCAxIDQwNS43NTcgMjQzIGNtDQpxDQowIDAgMCByZw0KQlQgMSAw IDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChYZW5zdG9yZSkgVGogVCogRVQNClENClEN CnENCjEgMCAwIDEgNiAyMTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAv RjEgMTAgVGYgMTIgVEwgKENsYXNzaWM6IERvbTApIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAg MCAxIDE4MS4zMzIgMjEzIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0Yx IDEwIFRmIDEyIFRMICgwKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMjMuNDExNyAy MTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwg KDApIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDI5My41NDQ1IDIxMyBjbQ0KcQ0KMCAw IDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoMCkgVGogVCogRVQN ClENClENCnENCjEgMCAwIDEgMzQyLjYzNzQgMjEzIGNtDQpxDQowIDAgMCByZw0KQlQgMSAw IDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMICgwKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAw IDAgMSA0MDUuNzU3IDIxMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9G MSAxMCBUZiAxMiBUTCAoMCkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNiAxODMgY20N CnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEwIFRmIDEyIFRMIChDbGFz c2ljOiBFeHRlbmRlZCBMYXVuY2gpIFRqIFQqIChEb20wKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0K MSAwIDAgMSAxODEuMzMyIDE5NSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRt IC9GMSAxMCBUZiAxMiBUTCAoMSkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMjIzLjQx MTcgMTk1IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEy IFRMICgxKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyNTEuNDY0OCAxOTUgY20NCnEN CjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKDApIFRqIFQq IEVUDQpRDQpRDQpxDQoxIDAgMCAxIDI5My41NDQ1IDE5NSBjbQ0KcQ0KMCAwIDAgcmcNCkJU IDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoMSkgVGogVCogRVQNClENClENCnEN CjEgMCAwIDEgMzQyLjYzNzQgMTk1IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIg VG0gL0YxIDEwIFRmIDEyIFRMICgxKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA0MDUu NzU3IDE5NSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAx MiBUTCAoMSkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNiAxNjUgY20NCnENCjAgMCAw IHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKENsYXNzaWM6IEJhc2lj IENsb3VkKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAxMzkuMjUyMyAxNjUgY20NCnEN CjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKHtufSkgVGog VCogRVQNClENClENCnENCjEgMCAwIDEgMTgxLjMzMiAxNjUgY20NCnENCjAgMCAwIHJnDQpC VCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKDApIFRqIFQqIEVUDQpRDQpRDQpx DQoxIDAgMCAxIDIyMy40MTE3IDE2NSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAy IFRtIC9GMSAxMCBUZiAxMiBUTCAoMCkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMjkz LjU0NDUgMTY1IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRm IDEyIFRMICgwKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzNDIuNjM3NCAxNjUgY20N CnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKDApIFRq IFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDQwNS43NTcgMTY1IGNtDQpxDQowIDAgMCByZw0K QlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMICgwKSBUaiBUKiBFVA0KUQ0KUQ0K cQ0KMSAwIDAgMSA2IDE0NyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9G MSAxMCBUZiAxMiBUTCAoQ2xhc3NpYzogQ2xvdWQpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAg MCAxIDEzOS4yNTIzIDE0NyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9G MSAxMCBUZiAxMiBUTCAoe259KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAxODEuMzMy IDE0NyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBU TCAoMSkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMjIzLjQxMTcgMTQ3IGNtDQpxDQow IDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMICgxKSBUaiBUKiBF VA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyNTEuNDY0OCAxNDcgY20NCnENCjAgMCAwIHJnDQpCVCAx IDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKDApIFRqIFQqIEVUDQpRDQpRDQpxDQox IDAgMCAxIDI5My41NDQ1IDE0NyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRt IC9GMSAxMCBUZiAxMiBUTCAoMSkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMzQyLjYz NzQgMTQ3IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEy IFRMICgxKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA0MDUuNzU3IDE0NyBjbQ0KcQ0K MCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoMSkgVGogVCog RVQNClENClENCnENCjEgMCAwIDEgNiAxMjkgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAx IDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKFN0YXRpYzogQmFzaWMpIFRqIFQqIEVUDQpRDQpR DQpxDQoxIDAgMCAxIDEzOS4yNTIzIDEyOSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEg MCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoe259KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAg MSAyMjMuNDExNyAxMjkgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEg MTAgVGYgMTIgVEwgKDApIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDI5My41NDQ1IDEy OSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAo MCkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMzQyLjYzNzQgMTI5IGNtDQpxDQowIDAg MCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMICgwKSBUaiBUKiBFVA0K UQ0KUQ0KcQ0KMSAwIDAgMSA0MDUuNzU3IDEyOSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAw IDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoMCkgVGogVCogRVQNClENClENCnENCjEgMCAw IDEgNiAxMTEgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYg MTIgVEwgKFN0YXRpYzogU3RhbmRhcmQpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDEz OS4yNTIzIDExMSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBU ZiAxMiBUTCAoe259KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMjMuNDExNyAxMTEg Y20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKDEp IFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDI1MS40NjQ4IDExMSBjbQ0KcQ0KMCAwIDAg cmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoMCkgVGogVCogRVQNClEN ClENCnENCjEgMCAwIDEgMjkzLjU0NDUgMTExIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAg MSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMICgxKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAg MSAzNDIuNjM3NCAxMTEgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEg MTAgVGYgMTIgVEwgKDEpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDQwNS43NTcgMTEx IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMICgx KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2IDkzIGNtDQpxDQowIDAgMCByZw0KQlQg MSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChTdGF0aWM6IERpc2FnZ3JlZ2F0ZWQp IFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDEzOS4yNTIzIDkzIGNtDQpxDQowIDAgMCBy Zw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMICh7bn0pIFRqIFQqIEVUDQpR DQpRDQpxDQoxIDAgMCAxIDIyMy40MTE3IDkzIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAg MSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMICgyKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAg MSAyNTEuNDY0OCA5MyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAx MCBUZiAxMiBUTCAoMCkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMjkzLjU0NDUgOTMg Y20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKDMp IFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDM0Mi42Mzc0IDkzIGNtDQpxDQowIDAgMCBy Zw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMICg0KSBUaiBUKiBFVA0KUQ0K UQ0KcQ0KMSAwIDAgMSA0MDUuNzU3IDkzIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAw IDIgVG0gL0YxIDEwIFRmIDEyIFRMICgxKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2 IDYzIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAxMiBU TCAoRHluYW1pYzogSGFyZHdhcmUpIFRqIFQqIChEb21haW4pIFRqIFQqIEVUDQpRDQpRDQpx DQoxIDAgMCAxIDE4MS4zMzIgNzUgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBU bSAvRjEgMTAgVGYgMTIgVEwgKDApIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIyMy40 MTE3IDc1IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEy IFRMICgxKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyOTMuNTQ0NSA3NSBjbQ0KcQ0K MCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoMCkgVGogVCog RVQNClENClENCnENCjEgMCAwIDEgMzQyLjYzNzQgNzUgY20NCnENCjAgMCAwIHJnDQpCVCAx IDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKDApIFRqIFQqIEVUDQpRDQpRDQpxDQox IDAgMCAxIDQwNS43NTcgNzUgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAv RjEgMTAgVGYgMTIgVEwgKDApIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYgMzMgY20N CnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEwIFRmIDEyIFRMIChEeW5h bWljOiBGbGV4aWJsZSkgVGogVCogKERpc2FnZ3JlZ2F0aW9uKSBUaiBUKiBFVA0KUQ0KUQ0K cQ0KMSAwIDAgMSAxMzkuMjUyMyA0NSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAy IFRtIC9GMSAxMCBUZiAxMiBUTCAoe259KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAx ODEuMzMyIDQ1IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRm IDEyIFRMICgxKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMjMuNDExNyA0NSBjbQ0K cQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoMikgVGog VCogRVQNClENClENCnENCjEgMCAwIDEgMjUxLjQ2NDggNDUgY20NCnENCjAgMCAwIHJnDQpC VCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKDApIFRqIFQqIEVUDQpRDQpRDQpx DQoxIDAgMCAxIDI5My41NDQ1IDQ1IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIg VG0gL0YxIDEwIFRmIDEyIFRMICgxKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzNDIu NjM3NCA0NSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAx MiBUTCAoMSkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNDA1Ljc1NyA0NSBjbQ0KcQ0K MCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoMSkgVGogVCog RVQNClENClENCnENCjEgMCAwIDEgNiAzIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAw IDE0IFRtIC9GMSAxMCBUZiAxMiBUTCAoRHluYW1pYzogRnVsbCkgVGogVCogKERpc2FnZ3Jl Z2F0aW9uKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAxMzkuMjUyMyAxNSBjbQ0KcQ0K MCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoe259KSBUaiBU KiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAxODEuMzMyIDE1IGNtDQpxDQowIDAgMCByZw0KQlQg MSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMICgyKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0K MSAwIDAgMSAyMjMuNDExNyAxNSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRt IC9GMSAxMCBUZiAxMiBUTCAoMykgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMjUxLjQ2 NDggMTUgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIg VEwgKDApIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDI5My41NDQ1IDE1IGNtDQpxDQow IDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMICg0KSBUaiBUKiBF VA0KUQ0KUQ0KcQ0KMSAwIDAgMSAzNDIuNjM3NCAxNSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEg MCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoNSkgVGogVCogRVQNClENClENCnENCjEg MCAwIDEgNDA1Ljc1NyAxNSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9G MSAxMCBUZiAxMiBUTCAoMSkgVGogVCogRVQNClENClENCnENCjEgSg0KMSBqDQowIDAgMCBS Rw0KLjI1IHcNCm4gMCAyNTggbSA0NjkuODg5OCAyNTggbCBTDQpuIDAgMjI4IG0gNDY5Ljg4 OTggMjI4IGwgUw0KbiAwIDIxMCBtIDQ2OS44ODk4IDIxMCBsIFMNCm4gMCAxODAgbSA0Njku ODg5OCAxODAgbCBTDQpuIDAgMTYyIG0gNDY5Ljg4OTggMTYyIGwgUw0KbiAwIDE0NCBtIDQ2 OS44ODk4IDE0NCBsIFMNCm4gMCAxMjYgbSA0NjkuODg5OCAxMjYgbCBTDQpuIDAgMTA4IG0g NDY5Ljg4OTggMTA4IGwgUw0KbiAwIDkwIG0gNDY5Ljg4OTggOTAgbCBTDQpuIDAgNjAgbSA0 NjkuODg5OCA2MCBsIFMNCm4gMCAzMCBtIDQ2OS44ODk4IDMwIGwgUw0KbiAxMzMuMjUyMyAw IG0gMTMzLjI1MjMgMjc2IGwgUw0KbiAxNzUuMzMyIDAgbSAxNzUuMzMyIDI1OCBsIFMNCm4g MjE3LjQxMTcgMCBtIDIxNy40MTE3IDI1OCBsIFMNCm4gMjQ1LjQ2NDggMCBtIDI0NS40NjQ4 IDI3NiBsIFMNCm4gMjg3LjU0NDUgMCBtIDI4Ny41NDQ1IDI1OCBsIFMNCm4gMzM2LjYzNzQg MCBtIDMzNi42Mzc0IDI1OCBsIFMNCm4gMzk5Ljc1NyAwIG0gMzk5Ljc1NyAyNTggbCBTDQpu IDAgMjc2IG0gNDY5Ljg4OTggMjc2IGwgUw0KbiAwIDAgbSA0NjkuODg5OCAwIGwgUw0KbiAw IDAgbSAwIDI3NiBsIFMNCm4gNDY5Ljg4OTggMCBtIDQ2OS44ODk4IDI3NiBsIFMNClENClEN CnENCjEgMCAwIDEgNjIuNjkyOTEgNDQ3LjAyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjky OTEgNDE3LjAyMzYgY20NCnENCkJUIDEgMCAwIDEgMCAzIFRtIDE4IFRMIC9GMiAxNSBUZiAw IDAgMCByZyAoMy41ICAgT3ZlcnZpZXcgb2YgaHlwZXJsYXVuY2ggRmxvdykgVGogVCogRVQN ClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMjkxLjAyMzYgY20NCnENCkJUIDEgMCAwIDEg MCAxMTAgVG0gLjc2NDEwNCBUdyAxMiBUTCAvRjEgMTAgVGYgMCAwIDAgcmcgKEJlZm9yZSBk ZWx2aW5nIGludG8gaHlwZXJsYXVuY2gsIGEgZ29vZCBiYXNpcyB0byBzdGFydCB3aXRoIGlz IGFuIHVuZGVyc3RhbmRpbmcgb2YgdGhlIGN1cnJlbnQgcHJvY2VzcyB0bykgVGogVCogMCBU dyAuMjYxMDk4IFR3IChjcmVhdGUgYSBkb21haW4uIEEgd2F5IHRvIHZpZXcgdGhpcyBwcm9j ZXNzIHN0YXJ0cyB3aXRoIHRoZSBjb3JlIGNvbmZpZ3VyYXRpb24gd2hpY2ggaXMgdGhlIGlu Zm9ybWF0aW9uIHRoZSkgVGogVCogMCBUdyAuMjczOTg0IFR3IChoeXBlcnZpc29yIHJlcXVp cmVzIHRvIG1ha2UgdGhlIGNhbGwgdG8gKSBUaiAvRjUgMTAgVGYgMCAwIDAgcmcgKGRvbWFp bl9jcmVhdGUgKSBUaiAvRjEgMTAgVGYgMCAwIDAgcmcgKGZvbGxvd2VkIGJ5IHRoZSBleHRl bmRlZCBjb25maWd1cmF0aW9uIHVzZWQgYnkgdGhlKSBUaiBUKiAwIFR3IDQuNjk2NjQ3IFR3 ICh0b29sc3RhY2sgdG8gcHJvdmlkZSBhIGRvbWFpbiB3aXRoIGFueSBhZGRpdGlvbmFsIGNv bmZpZ3VyYXRpb24gaW5mb3JtYXRpb24uIFVudGlsIHRoZSBleHRlbmRlZCkgVGogVCogMCBU dyAuMzEyNjUxIFR3IChjb25maWd1cmF0aW9uIGlzIGNvbXBsZXRlZCwgYSBkb21haW4gaGFz IGFjY2VzcyB0byBubyByZXNvdXJjZXMgZXhjZXB0IGl0cyBhbGxvY2F0ZWQgdmNwdXMgYW5k IG1lbW9yeS4pIFRqIFQqIDAgVHcgMS43ODg3MzUgVHcgKFRoZSBleGNlcHRpb24gdG8gdGhp cyBpcyBEb20wIHdoaWNoIHRoZSBoeXBlcnZpc29yIGV4cGxpY2l0bHkgZ3JhbnRzIGNvbnRy b2wgYW5kIGFjY2VzcyB0byBhbGwgc3lzdGVtKSBUaiBUKiAwIFR3IC42NDA2MSBUdyAocmVz b3VyY2VzIGV4Y2VwdCBmb3IgdGhvc2UgdGhhdCBvbmx5IHRoZSBoeXBlcnZpc29yIHNob3Vs ZCBoYXZlIGNvbnRyb2wgb3Zlci4gVGhpcyBleGNlcHRpb24gZm9yIERvbTAgaXMpIFRqIFQq IDAgVHcgMi40Mzk5ODMgVHcgKGRyaXZlbiBieSB0aGUgc3lzdGVtIHN0cnVjdHVyZSB3aXRo IGEgbW9ub2xpdGhpYyBEb20wIGRvbWFpbiBwcmVkYXRpbmcgaW50cm9kdWN0aW9uIG9mIHN1 cHBvcnQgZm9yKSBUaiBUKiAwIFR3IC4wMTU2OTcgVHcgKGRpc2FnZ3JlZ2F0aW9uIGludG8g WGVuLCBhbmQgdGhlIGNvcnJlc3BvbmRpbmcgZGVmYXVsdCBhc3NpZ25tZW50IG9mIG11bHRp cGxlIHJvbGVzIHdpdGhpbiB0aGUgWGVuIHN5c3RlbSkgVGogVCogMCBUdyAodG8gRG9tMC4p IFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDE3Ny4wMjM2IGNtDQpxDQpC VCAxIDAgMCAxIDAgOTggVG0gLjkzMjEyNiBUdyAxMiBUTCAvRjEgMTAgVGYgMCAwIDAgcmcg KFdoaWxlIG5vdCBhIGRpZmZlcmVudCBkb21haW4gY3JlYXRpb24gcGF0aCwgdGhlcmUgZG9l cyBleGlzdCB0aGUgSGFyZHdhcmUgRG9tYWluIFwoaHdkb21cKSwgc29tZXRpbWVzKSBUaiBU KiAwIFR3IDEuMjI0MTA0IFR3IChhbHNvIHJlZmVycmVkIHRvIGFzIGxhdGUtRG9tMC4gSXQg aXMgYW4gZWFybHkgZWZmb3J0IHRvIGRpc2FnZ3JlZ2F0ZSBEb20wXDIyMnMgcm9sZXMgaW50 byBhIHNlcGFyYXRlIGNvbnRyb2wpIFRqIFQqIDAgVHcgMy40NTMxMSBUdyAoZG9tYWluIGFu ZCBoYXJkd2FyZSBkb21haW4uIFRoaXMgY2FwYWJpbGl0eSBpcyBhY3RpdmF0ZWQgYnkgdGhl IHBhc3Npbmcgb2YgYSBkb21haW4gaWQgdG8gdGhlKSBUaiBUKiAwIFR3IC45Nzk5ODQgVHcg L0Y1IDEwIFRmIDAgMCAwIHJnIChoYXJkd2FyZV9kb20gKSBUaiAvRjEgMTAgVGYgMCAwIDAg cmcgKGtlcm5lbCBjb21tYW5kIGxpbmUgcGFyYW1ldGVyLCBhbmQgdGhlIFhlbiBoeXBlcnZp c29yIHdpbGwgdGhlbiBmbGFnIHRoYXQgZG9tYWluIGlkIGFzKSBUaiBUKiAwIFR3IC4zOTU2 MSBUdyAodGhlIGhhcmR3YXJlIGRvbWFpbi4gTGF0ZXIgd2hlbiB0aGUgdG9vbHN0YWNrIGNv bnN0cnVjdHMgYSBkb21haW4gd2l0aCB0aGF0IGRvbWFpbiBpZCBhcyB0aGUgcmVxdWVzdGVk KSBUaiBUKiAwIFR3IC41MDk5ODcgVHcgKGRvbWlkLCB0aGUgaHlwZXJ2aXNvciB3aWxsIHRy YW5zZmVyIGFsbCBkZXZpY2UgSS9PIGZyb20gRG9tMCB0byB0aGlzIGRvbWFpbi4gSW4gYWRk aXRpb24gaXQgd2lsbCBhbHNvIHRyYW5zZmVyKSBUaiBUKiAwIFR3IC41MDEyMzUgVHcgKHRo ZSBcMjIzaG9zdCBzaHV0ZG93biBvbiBkb21haW4gc2h1dGRvd25cMjI0IGZsYWcgZnJvbSBE b20wIHRvIHRoZSBoYXJkd2FyZSBkb21haW4uIEl0IGlzIHdvcnRoIG1lbnRpb25pbmcpIFRq IFQqIDAgVHcgLjA3MzMyIFR3ICh0aGF0IHRoaXMgYXBwcm9hY2ggZm9yIGRpc2FnZ3JlZ2F0 aW9uIHdhcyBjcmVhdGVkIGluIHRoaXMgbWFubmVyIGR1ZSB0byB0aGUgaW5hYmlsaXR5IG9m IFhlbiB0byBsYXVuY2ggbW9yZSkgVGogVCogMCBUdyAodGhhbiBvbmUgZG9tYWluIGF0IHN0 YXJ0dXAuKSBUaiBUKiBFVA0KUQ0KUQ0KIA0KZW5kc3RyZWFtDQplbmRvYmoNCjEyMiAwIG9i ag0KPDwgL0xlbmd0aCA4MTU5ID4+DQpzdHJlYW0NCjEgMCAwIDEgMCAwIGNtICBCVCAvRjEg MTIgVGYgMTQuNCBUTCBFVA0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA3NTAuMDIzNiBjbQ0KcQ0K QlQgMSAwIDAgMSAwIDIuNSBUbSAxNSBUTCAvRjMgMTIuNSBUZiAwIDAgMCByZyAoMy41LjEg ICBoeXBlcmxhdW5jaCBYZW4gc3RhcnR1cCkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEg NjIuNjkyOTEgNjI0LjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMTEwIFRt IC9GMSAxMCBUZiAxMiBUTCAuNjQwNjEgVHcgKFRoZSBoeXBlcmxhdW5jaCBhcHByb2FjaFwy MjJzIHByaW1hcnkgZm9jdXMgaXMgb24gaG93IHRvIGFzc2lnbiB0aGUgcm9sZXMgdHJhZGl0 aW9uYWxseSBncmFudGVkIHRvIERvbTAgdG8pIFRqIFQqIDAgVHcgLjY2Mjc2NSBUdyAob25l IG9yIG1vcmUgZG9tYWlucyBhdCBob3N0IGJvb3QuIFdoaWxlIHRoZSBzdGF0ZW1lbnQgaXMg c2ltcGxlIHRvIG1ha2UsIHRoZSBpbXBsaWNhdGlvbnMgYXJlIG5vdCB0cml2aWFsKSBUaiBU KiAwIFR3IC45MDQ2NTEgVHcgKGJ5IGFueSBtZWFucy4gVGhpcyBhbHNvIGV4cGxhaW5zIHdo eSB0aGUgaHlwZXJsYXVuY2ggYXBwcm9hY2ggaXMgb3J0aG9nb25hbCB0byB0aGUgZXhpc3Rp bmcgZG9tMGxlc3MpIFRqIFQqIDAgVHcgMS40MDcxMjYgVHcgKGNhcGFiaWxpdHkuIFRoZSBk b20wbGVzcyBjYXBhYmlsaXR5IGZvY3VzZXMgb24gZW5hYmxpbmcgdGhlIGxhdW5jaCBvZiBt dWx0aXBsZSBkb21haW5zIGluIHBhcmFsbGVsIHdpdGgpIFRqIFQqIDAgVHcgMS4yMTgzMiBU dyAoRG9tMCBhdCBob3N0IGJvb3QuIEEgY29yb2xsYXJ5IGZvciBkb20wbGVzcyBpcyB0aGF0 IGZvciBzeXN0ZW1zIHRoYXQgZG9uXDIyMnQgcmVxdWlyZSBEb20wIGFmdGVyIGFsbCBndWVz dCkgVGogVCogMCBUdyAuMjMwOTg4IFR3IChkb21haW5zIGhhdmUgc3RhcnRlZCwgdGhleSBh cmUgYWJsZSB0byBkbyB0aGUgaG9zdCBib290IHdpdGhvdXQgYSBEb20wLiBUaG91Z2ggaXQg c2hvdWxkIGJlIG5vdGVkIHRoYXQgaXQpIFRqIFQqIDAgVHcgMS41NDMxMSBUdyAobWF5IGJl IHBvc3NpYmxlIHRvIHN0YXJ0IERvbTAgYXQgYSBsYXRlciBwb2ludC4gV2hlcmVhcyB3aXRo IGh5cGVybGF1bmNoLCBpdHMgYXBwcm9hY2ggb2Ygc2VwYXJhdGluZykgVGogVCogMCBUdyAu NzU3OTg0IFR3IChEb20wXDIyMnMgcm9sZXMgcmVxdWlyZXMgdGhlIGFiaWxpdHkgdG8gbGF1 bmNoIG11bHRpcGxlIGRvbWFpbnMgYXQgaG9zdCBib290LiBUaGUgZGlyZWN0IGNvbnNlcXVl bmNlcyBmcm9tKSBUaiBUKiAwIFR3IC4wMTQ5ODUgVHcgKHRoaXMgYXBwcm9hY2ggYXJlIHBy b2ZvdW5kIGFuZCBwcm92aWRlIGEgbXlyaWFkIG9mIHBvc3NpYmxlIGNvbmZpZ3VyYXRpb25z IGZvciB3aGljaCBhIHNhbXBsZSBvZiBjb21tb24pIFRqIFQqIDAgVHcgKGJvb3QgY29uZmln dXJhdGlvbnMgd2VyZSBhbHJlYWR5IHByZXNlbnRlZC4pIFRqIFQqIEVUDQpRDQpRDQpxDQox IDAgMCAxIDYyLjY5MjkxIDUzNC4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAw IDc0IFRtIC9GMSAxMCBUZiAxMiBUTCAuOTg1NjEgVHcgKFRvIGVuYWJsZSB0aGUgaHlwZXJs YXVuY2ggYXBwcm9hY2ggYSBuZXcgYWx0ZXJuYXRpdmUgcGF0aCBmb3IgaG9zdCBib290IHdp dGhpbiB0aGUgaHlwZXJ2aXNvciBtdXN0IGJlKSBUaiBUKiAwIFR3IDEuMTI5MjEzIFR3IChp bnRyb2R1Y2VkLiBUaGlzIGFsdGVybmF0aXZlIHBhdGggZWZmZWN0aXZlbHkgYnJhbmNoZXMg anVzdCBiZWZvcmUgdGhlIGN1cnJlbnQgcG9pbnQgb2YgRG9tMCBjb25zdHJ1Y3Rpb24pIFRq IFQqIDAgVHcgLjUzMjY1MSBUdyAoYW5kIGJlZ2lucyBhbiBhbHRlcm5hdGUgbWVhbnMgb2Yg c3lzdGVtIGNvbnN0cnVjdGlvbi4gVGhlIGRldGVybWluYXRpb24gaWYgdGhpcyBhbHRlcm5h dGUgcGF0aCBzaG91bGQgYmUpIFRqIFQqIDAgVHcgLjQzNTI4IFR3ICh0YWtlbiBpcyB0aHJv dWdoIHRoZSBpbnNwZWN0aW9uIG9mIHRoZSBib290IGNoYWluLiBJZiB0aGUgYm9vdGxvYWRl ciBoYXMgbG9hZGVkIGEgc3BlY2lmaWMgY29uZmlndXJhdGlvbiwgYXMpIFRqIFQqIDAgVHcg LjkxNTYxIFR3IChkZXNjcmliZWQgbGF0ZXIsIGl0IHdpbGwgZW5hYmxlIFhlbiB0byBkZXRl Y3QgdGhhdCBhIGh5cGVybGF1bmNoIGNvbmZpZ3VyYXRpb24gaGFzIGJlZW4gcHJvdmlkZWQu IE9uY2UgYSkgVGogVCogMCBUdyAyLjM5NTY5NyBUdyAoaHlwZXJsYXVuY2ggY29uZmlndXJh dGlvbiBpcyBkZXRlY3RlZCwgdGhpcyBhbHRlcm5hdGUgcGF0aCBjYW4gYmUgdGhvdWdodCBv ZiBhcyBvY2N1cnJpbmcgaW4gcGhhc2VzOikgVGogVCogMCBUdyAoZG9tYWluIGNyZWF0aW9u LCBkb21haW4gcHJlcGFyYXRpb24sIGFuZCBsYXVuY2ggZmluYWxpemF0aW9uLikgVGogVCog RVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNTEwLjAyMzYgY20NCnENCkJUIDEgMCAw IDEgMCAyIFRtIDEyIFRMIC9GMyAxMCBUZiAwIDAgMCByZyAoMy41LjEuMSAgIERvbWFpbiBD cmVhdGlvbikgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNDIwLjAyMzYg Y20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgNzQgVG0gL0YxIDEwIFRmIDEyIFRMIC43 MjkyNjkgVHcgKFRoZSBkb21haW4gY3JlYXRpb24gcGhhc2UgYmVnaW5zIHdpdGggWGVuIHBh cnNpbmcgdGhlIGJvb3Rsb2FkZXIgcHJvdmlkZWQgbWF0ZXJpYWwsIHRvIHVuZGVyc3RhbmQg dGhlKSBUaiBUKiAwIFR3IDEuNTE4ODEgVHcgKGNvbnRlbnQgb2YgdGhlIG1vZHVsZXMgcHJv dmlkZWQuIEl0IHdpbGwgdGhlbiBsb2FkIGFueSBtaWNyb2NvZGUgb3IgWFNNIHBvbGljeSBp dCBkaXNjb3ZlcnMuIEZvciBlYWNoKSBUaiBUKiAwIFR3IC4yNTM1NTUgVHcgKGRvbWFpbiBj b25maWd1cmF0aW9uIFhlbiBmaW5kcywgaXQgcGFyc2VzIHRoZSBjb25maWd1cmF0aW9uIHRv IGNvbnN0cnVjdCB0aGUgbmVjZXNzYXJ5IGRvbWFpbiBkZWZpbml0aW9uIHRvKSBUaiBUKiAw IFR3IC4yNzI5MjcgVHcgKGluc3RhbnRpYXRlIGFuIGluc3RhbmNlIG9mIHRoZSBkb21haW4g YW5kIGxlYXZlIGl0IGluIGEgcGF1c2VkIHN0YXRlLiBXaGVuIGFsbCBkb21haW4gY29uZmln dXJhdGlvbnMgaGF2ZSkgVGogVCogMCBUdyAuMTM0NDMxIFR3IChiZWVuIGluc3RhbnRpYXRl ZCBhcyBkb21haW5zLCBpZiBvbmUgb2YgdGhlbSBpcyBmbGFnZ2VkIGFzIHRoZSBCb290IERv bWFpbiwgdGhhdCBkb21haW4gd2lsbCBiZSB1bnBhdXNlZCkgVGogVCogMCBUdyAuOTM5MzE4 IFR3IChzdGFydGluZyB0aGUgZG9tYWluIHByZXBhcmF0aW9uIHBoYXNlLiBJZiB0aGVyZSBp cyBubyBCb290IERvbWFpbiBkZWZpbmVkLCB0aGVuIHRoZSBkb21haW4gcHJlcGFyYXRpb24p IFRqIFQqIDAgVHcgKHBoYXNlIHdpbGwgYmUgc2tpcHBlZCBhbmQgWGVuIHdpbGwgdHJpZ2dl ciB0aGUgbGF1bmNoIGZpbmFsaXphdGlvbiBwaGFzZS4pIFRqIFQqIEVUDQpRDQpRDQpxDQox IDAgMCAxIDYyLjY5MjkxIDM5Ni4wMjM2IGNtDQpxDQpCVCAxIDAgMCAxIDAgMiBUbSAxMiBU TCAvRjMgMTAgVGYgMCAwIDAgcmcgKDMuNS4xLjIgICBEb21haW4gUHJlcGFyYXRpb24gUGhh c2UpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDM0Mi4wMjM2IGNtDQpx DQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDM4IFRtIC9GMSAxMCBUZiAxMiBUTCAuMzI2MjM1 IFR3IChUaGUgZG9tYWluIHByZXBhcmF0aW9uIHBoYXNlIGlzIGFuIG9wdGlvbmFsIGNoZWNr IHBvaW50IGZvciB0aGUgZXhlY3V0aW9uIG9mIGEgd29ya2xvYWQgc3BlY2lmaWMgZG9tYWlu LCkgVGogVCogMCBUdyAuNjU1Nzc3IFR3ICh0aGUgQm9vdCBEb21haW4uIFdoaWxlIHRoZSBC b290IERvbWFpbiBpcyB0aGUgZmlyc3QgZG9tYWluIHRvIHJ1biBhbmQgaGFzIHNvbWUgZGVn cmVlIG9mIGNvbnRyb2wgb3ZlcikgVGogVCogMCBUdyAyLjQ0MTQxMiBUdyAodGhlIHN5c3Rl bSwgaXQgaXMgZXh0cmVtZWx5IHJlc3RyaWN0ZWQgaW4gYm90aCBzeXN0ZW0gcmVzb3VyY2Ug YWNjZXNzIGFuZCBoeXBlcnZpc29yIG9wZXJhdGlvbnMuIEl0cykgVGogVCogMCBUdyAocHVy cG9zZSBpcyB0bzopIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDMzNi4w MjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDMzNi4wMjM2IGNtDQpRDQpxDQoxIDAg MCAxIDYyLjY5MjkxIDMyNC4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRM IEVUDQpxDQoxIDAgMCAxIDYgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBU bSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVU DQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAw IDIgVG0gL0YxIDEwIFRmIDEyIFRMIChBY2Nlc3MgdGhlIGNvbmZpZ3VyYXRpb24gcHJvdmlk ZWQgYnkgdGhlIGJvb3Rsb2FkZXIpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAg MCAxIDYyLjY5MjkxIDMxOC4wMjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDMwNi4w MjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAgMCAxIDYg LTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwg MTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAx IDIzIC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEy IFRMIChGaW5hbGl6ZSB0aGUgY29uZmlndXJhdGlvbiBvZiB0aGUgZG9tYWlucykgVGogVCog RVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMzAwLjAyMzYgY20NClEN CnENCjEgMCAwIDEgNjIuNjkyOTEgMjg4LjAyMzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAg VGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAw IDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41 IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAx IDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKENvbmR1Y3QgYW55IHNldHVwIGFuZCBs YXVuY2ggcmVsYXRlZCBvcGVyYXRpb25zKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0K MSAwIDAgMSA2Mi42OTI5MSAyODIuMDIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAy NzAuMDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAg MSA2IC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEy IFRMIDEwLjUgMCBUZCAoXDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAw IDAgMSAyMyAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBU ZiAxMiBUTCAoRG8gYW4gb3JkZXJlZCB1bnBhdXNlIG9mIGRvbWFpbnMgdGhhdCByZXF1aXJl IGFuIG9yZGVyZWQgc3RhcnQpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAx IDYyLjY5MjkxIDI3MC4wMjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDI0MC4wMjM2 IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAxMiBUTCAx LjM4NzA0NSBUdyAoV2hlbiB0aGUgQm9vdCBEb21haW4gaGFzIGNvbXBsZXRlZCwgaXQgd2ls bCBub3RpZnkgdGhlIGh5cGVydmlzb3IgdGhhdCBpdCBpcyBkb25lIHRyaWdnZXJpbmcgdGhl IGxhdW5jaCkgVGogVCogMCBUdyAoZmluYWxpemF0aW9uIHBoYXNlLikgVGogVCogRVQNClEN ClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMjE2LjAyMzYgY20NCnENCkJUIDEgMCAwIDEgMCAy IFRtIDEyIFRMIC9GMyAxMCBUZiAwIDAgMCByZyAoMy41LjEuMyAgIExhdW5jaCBGaW5hbGl6 YXRpb24pIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDE4Ni4wMjM2IGNt DQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAxMiBUTCAuNjcz MTEgVHcgKFRoZSBoeXBlcnZpc29yIGhhbmRsZXMgdGhlIGxhdW5jaCBmaW5hbGl6YXRpb24g cGhhc2Ugd2hpY2ggaXMgZXF1aXZhbGVudCB0byB0aGUgY2xlYW4gdXAgcGhhc2UuIEFzIHN1 Y2gpIFRqIFQqIDAgVHcgKHRoZSBzdGVwcyB0YWtlbiBieSB0aGUgaHlwZXJ2aXNvciwgbm90 IG5lY2Vzc2FyaWx5IGluIGltcGxlbWVudGF0aW9uIG9yZGVyLCBhcmUgYXMgZm9sbG93cywp IFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDE4MC4wMjM2IGNtDQpRDQpx DQoxIDAgMCAxIDYyLjY5MjkxIDE4MC4wMjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5Mjkx IDE2OC4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAg MCAxIDYgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYg MTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpxDQox IDAgMCAxIDIzIC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEw IFRmIDEyIFRMIChGcmVlIHRoZSBib290IG1vZHVsZSBjaGFpbikgVGogVCogRVQNClENClEN CnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMTYyLjAyMzYgY20NClENCnENCjEgMCAw IDEgNjIuNjkyOTEgMTUwLjAyMzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwg RVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRt IC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQN ClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAg MiBUbSAvRjEgMTAgVGYgMTIgVEwgKElmIGEgQm9vdCBEb21haW4gd2FzIHVzZWQsIHJlY2xh aW0gQm9vdCBEb21haW4gcmVzb3VyY2VzKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0K MSAwIDAgMSA2Mi42OTI5MSAxNDQuMDIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAx MzIuMDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAg MSA2IC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEy IFRMIDEwLjUgMCBUZCAoXDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAw IDAgMSAyMyAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBU ZiAxMiBUTCAoVW5wYXVzZSBhbnkgZG9tYWlucyBzdGlsbCBpbiBhIHBhdXNlZCBzdGF0ZSkg VGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMTI2LjAyMzYg Y20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMTE0LjAyMzYgY20NCjAgMCAwIHJnDQpCVCAv RjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJU IDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQq IC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAwIHJn DQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKEJvb3QgRG9tYWluIHVzZXMg YSByZXNlcnZlZCBmdW5jdGlvbiB0aHVzIGNhbiBuZXZlciBiZSByZXNwYXduZWQpIFRqIFQq IEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDExNC4wMjM2IGNtDQpR DQpxDQoxIDAgMCAxIDYyLjY5MjkxIDg0LjAyMzYyIGNtDQpxDQowIDAgMCByZw0KQlQgMSAw IDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAxMiBUTCAuMjI5OTg3IFR3IChXaGlsZSB0aGUgZm9j dXMgdGh1cyBmYXIgaGFzIGJlZW4gb24gaG93IHRoZSBoeXBlcmxhdW5jaCBjYXBhYmlsaXR5 IHdpbGwgd29yaywgaXQgaXMgd29ydGggbWVudGlvbmluZyB3aGF0KSBUaiBUKiAwIFR3IC45 NTY0ODggVHcgKGl0IGRvZXMgbm90IGRvIG9yIGxpbWl0IGZyb20gb2NjdXJyaW5nLiBJdCBk b2VzIG5vdCBzdG9wIG9yIGluaGliaXQgdGhlIGFzc2lnbmluZyBvZiB0aGUgY29udHJvbCBk b21haW4gcm9sZSkgVGogVCogMCBUdyBFVA0KUQ0KUQ0KIA0KZW5kc3RyZWFtDQplbmRvYmoN CjEyMyAwIG9iag0KPDwgL0xlbmd0aCA3MTY5ID4+DQpzdHJlYW0NCjEgMCAwIDEgMCAwIGNt ICBCVCAvRjEgMTIgVGYgMTQuNCBUTCBFVA0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA3MDUuMDIz NiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCA1MCBUbSAvRjEgMTAgVGYgMTIgVEwg MS41NDMxMSBUdyAod2hpY2ggZ2l2ZXMgdGhlIGRvbWFpbiB0aGUgYWJpbGl0eSB0byBjcmVh dGUsIHN0YXJ0LCBzdG9wLCByZXN0YXJ0LCBhbmQgZGVzdHJveSBkb21haW5zIG9yIHRoZSBo YXJkd2FyZSkgVGogVCogMCBUdyAuNDA3MDQ1IFR3IChkb21haW4gcm9sZSB3aGljaCBnaXZl cyBhY2Nlc3MgdG8gYWxsIEkvTyBkZXZpY2VzIGV4Y2VwdCB0aG9zZSB0aGF0IHRoZSBoeXBl cnZpc29yIGhhcyByZXNlcnZlZCBmb3IgaXRzZWxmLikgVGogVCogMCBUdyAxLjc0MDUxNCBU dyAoSW4gcGFydGljdWxhciBpdCBpcyBzdGlsbCBwb3NzaWJsZSB0byBjb25zdHJ1Y3QgYSBk b21haW4gd2l0aCBhbGwgdGhlIHByaXZpbGVnZWQgcm9sZXMsIGkuZS4gYSBEb20wLCB3aXRo IG9yKSBUaiBUKiAwIFR3IDEuNzk0NjUxIFR3ICh3aXRob3V0IHRoZSBkb21haW4gaWQgYmVp bmcgemVyby4gSW4gZmFjdCB3aGF0IGxpbWl0YXRpb25zIGFyZSBpbXBvc2VkIG5vdyBiZWNv bWUgZnVsbHkgY29uZmlndXJhYmxlKSBUaiBUKiAwIFR3ICh3aXRob3V0IHRoZSByaXNrIG9m IGNpcmN1bXZlbnRpb24gYnkgYW4gYWxsIHByaXZpbGVnZWQgZG9tYWluLikgVGogVCogRVQN ClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNjc1LjAyMzYgY20NCnENCkJUIDEgMCAwIDEg MCAzIFRtIDE4IFRMIC9GMiAxNSBUZiAwIDAgMCByZyAoMy42ICAgU3RydWN0dXJpbmcgb2Yg SHlwZXJsYXVuY2gpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDU5Ny4w MjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDYyIFRtIC9GMSAxMCBUZiAxMiBU TCAyLjQ5NzMxOCBUdyAoVGhlIHN0cnVjdHVyZSBvZiBoeXBlcmxhdW5jaCBpcyBidWlsdCBh cm91bmQgdGhlIGV4aXN0aW5nIGNhcGFiaWxpdGllcyBvZiB0aGUgaG9zdCBib290IHByb3Rv Y29sLiBUaGlzKSBUaiBUKiAwIFR3IC43NTI3NjUgVHcgKGFwcHJvYWNoIHdhcyBkcml2ZW4g YnkgdGhlIG9iamVjdGl2ZSBub3QgdG8gcmVxdWlyZSBtb2RpZmljYXRpb25zIHRvIHRoZSBi b290IGxvYWRlci4gQXMgYSByZXN1bHQsIG9uIHg4NikgVGogVCogMCBUdyAuMzI2MjM1IFR3 ICh0aGUgaHlwZXJsYXVuY2ggY2FwYWJpbGl0eSBkb2VzIG5vdCByZWx5IG9uIG5vciBwcmVj bHVkZSBhbnkgc3BlY2lmaWMgQklPUyBib290IHByb3RvY29sLCBpLmUgbGVnYWN5IEJJT1Mp IFRqIFQqIDAgVHcgLjg4MjQ4NSBUdyAoYm9vdCBvciBVRUZJIGJvb3QuIFRoZSBvbmx5IHJl cXVpcmVtZW50IGlzIHRoYXQgdGhlIGJvb3QgbG9hZGVyIHN1cHBvcnRzIHRoZSBNdWx0aWJv b3QyIFwoTUIyXCkgcHJvdG9jb2wuKSBUaiBUKiAwIFR3IDMuMTk0OTgzIFR3IChTaW1pbGFy bHkgb24gQXJtIHBsYXRmb3JtcywgaHlwZXJsYXVuY2ggaXMgY29tcGF0aWJsZSB3aXRoIHRo ZSBleGlzdGluZyBpbnRlcmZhY2UgZm9yIGJvb3QgaW50byB0aGUpIFRqIFQqIDAgVHcgKGh5 cGVydmlzb3IuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA1NzAuMDIz NiBjbQ0KcQ0KQlQgMSAwIDAgMSAwIDIuNSBUbSAxNSBUTCAvRjMgMTIuNSBUZiAwIDAgMCBy ZyAoMy42LjEgICB4ODYgTXVsdGlib290MikgVGogVCogRVQNClENClENCnENCjEgMCAwIDEg NjIuNjkyOTEgNDkyLjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgNjIgVG0g L0YxIDEwIFRmIDEyIFRMIDEuMjk4NDA5IFR3IChUaGUgTUIyIHByb3RvY29sIGhhcyBubyBj b25jZXB0IG9mIGEgbWFuaWZlc3QgdG8gdGVsbCB0aGUgaW5pdGlhbCBrZXJuZWwgd2hhdCBp cyBjb250YWluZWQgaW4gdGhlIGNoYWluLCkgVGogVCogMCBUdyAxLjA5MDYxIFR3IChsZWF2 aW5nIGl0IHRvIHRoZSBrZXJuZWwgdG8gaW1wb3NlIGEgbG9hZGluZyBjb252ZW50aW9uLCB1 c2UgbWFnaWMgbnVtYmVyIGlkZW50aWZpY2F0aW9uLCBvciBib3RoLiBXaGVuKSBUaiBUKiAw IFR3IDEuMTMwNzUxIFR3IChjb25zaWRlcmluZyB0aGUgcGFzc2luZyBvZiBtdWx0aXBsZSBr ZXJuZWxzLCByYW1kaXNrcywgYW5kIGRvbWFpbiBjb25maWd1cmF0aW9uIGFsb25nIHdpdGgg YW55IGV4aXN0aW5nKSBUaiBUKiAwIFR3IDMuMzg5OTgzIFR3IChtb2R1bGVzIGFscmVhZHkg cGFzc2VkLCB0aGVyZSBpcyBubyBzYW5lIGNvbnZlbnRpb24gdGhhdCBjb3VsZCBiZSBpbXBv c2VkIGFuZCBtYWdpYyBudW1iZXIpIFRqIFQqIDAgVHcgLjM0NTgxNCBUdyAoaWRlbnRpZmlj YXRpb24gaXMgbmVhcmx5IGltcG9zc2libGUgd2hlbiBjb25zaWRlcmluZyB0aGUgb2JqZWN0 aXZlIG5vdCB0byBpbXBvc2UgdW5uZWNlc3NhcnkgY29tcGxpY2F0aW9uKSBUaiBUKiAwIFR3 ICh0byB0aGUgaHlwZXJ2aXNvci4pIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5 MjkxIDQ1MC4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDI2IFRtIC9GMSAx MCBUZiAxMiBUTCAuNjI5OTg3IFR3IChBcyBpdCB3YXMgYWxsdWRlZCB0byBwcmV2aW91c2x5 LCBhIG1hbmlmZXN0IGRlc2NyaWJpbmcgdGhlIGNvbnRlbnRzIGluIHRoZSBNQjIgY2hhaW4g YW5kIGhvdyB0aGV5IHJlbGF0ZSkgVGogVCogMCBUdyAuNDA1MjggVHcgKHdpdGhpbiBhIFhl biBjb250ZXh0IGlzIG5lZWRlZC4gVG8gYWRkcmVzcyB0aGlzIG5lZWQgdGhlIExhdW5jaCBD b250cm9sIE1vZHVsZSBcKExDTVwpIHdhcyBkZXNpZ25lZCB0bykgVGogVCogMCBUdyAocHJv dmlkZSBzdWNoIGEgbWFuaWZlc3QuIFRoZSBMQ00gd2FzIGRlc2lnbmVkIHRvIGhhdmUgYSBz cGVjaWZpYyBzZXQgb2YgcHJvcGVydGllcywpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAx IDYyLjY5MjkxIDQ0NC4wMjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDQ0NC4wMjM2 IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDQzMi4wMjM2IGNtDQowIDAgMCByZw0KQlQg L0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAgMCAxIDYgLTMgY20NCnENCjAgMCAwIHJnDQpC VCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBU KiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpxDQowIDAgMCBy Zw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChtaW5pbWl6ZSB0aGUgY29t cGxleGl0eSBvZiB0aGUgcGFyc2luZyBsb2dpYyByZXF1aXJlZCBieSB0aGUgaHlwZXJ2aXNv cikgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNDI2LjAy MzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNDE0LjAyMzYgY20NCjAgMCAwIHJnDQpC VCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0KcQ0KMCAwIDAgcmcN CkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRq IFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAw IHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKGFsbG93IGZvciBleHBh bmRpbmcgYW5kIG9wdGlvbmFsIGNvbmZpZ3VyYXRpb24gZnJhZ21lbnRzIHdpdGhvdXQgYnJl YWtpbmcgYmFja3dhcmRzIGNvbXBhdGliaWxpdHkpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpR DQpxDQoxIDAgMCAxIDYyLjY5MjkxIDQxNC4wMjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5 MjkxIDMzNi4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDYyIFRtIC9GMSAx MCBUZiAxMiBUTCAuNzc4MTEgVHcgKFRvIGVuYWJsZSBhdXRvbWF0aWMgZGV0ZWN0aW9uIG9m IGEgaHlwZXJsYXVuY2ggY29uZmlndXJhdGlvbiwgdGhlIExDTSBtdXN0IGJlIHRoZSBmaXJz dCBNQjIgbW9kdWxlIGluKSBUaiBUKiAwIFR3IDEuMjY1NjEgVHcgKHRoZSBNQjIgbW9kdWxl IGNoYWluLiBUaGUgTENNIGlzIGltcGxlbWVudGVkIHVzaW5nIHRoZSBEZXZpY2UgVHJlZSBh cyBkZWZpbmVkIGluIHRoZSBoeXBlcmxhdW5jaCkgVGogVCogMCBUdyAxLjI2NzQ4NSBUdyAo RGV2aWNlIFRyZWUgZGVzaWduIGRvY3VtZW50LiBXaXRoIHRoZSBMQ00gaW1wbGVtZW50ZWQg aW4gRGV2aWNlIFRyZWUsIGl0IGhhcyBhIG1hZ2ljIG51bWJlciB0aGF0KSBUaiBUKiAwIFR3 IDEuMjM3OTg0IFR3IChlbmFibGVzIHRoZSBoeXBlcnZpc29yIHRvIGRldGVjdCBpdHMgcHJl c2VuY2Ugd2hlbiB1c2VkIGluIGEgTXVsdGlib290MiBtb2R1bGUgY2hhaW4uIFRoZSBoeXBl cnZpc29yKSBUaiBUKiAwIFR3IDEuMTYwNTc0IFR3IChjYW4gY29uZmlybSB0aGF0IGl0IGlz IGEgcHJvcGVyIExDTSBEZXZpY2UgVHJlZSBieSBjaGVja2luZyBmb3IgYSBjb21wbGlhbnQg aHlwZXJsYXVuY2ggRGV2aWNlIFRyZWUuKSBUaiBUKiAwIFR3IChUaGUgaHlwZXJsYXVuY2gg RGV2aWNlIFRyZWUgbm9kZXMgYXJlIGRlc2lnbmVkIHRvIGFsbG93LCkgVGogVCogRVQNClEN ClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMzMwLjAyMzYgY20NClENCnENCjEgMCAwIDEgNjIu NjkyOTEgMzMwLjAyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMzE4LjAyMzYgY20N CjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0K cQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAg VGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMg Y20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKGZv ciB0aGUgaHlwZXJ2aXNvciB0byBwYXJzZSBvbmx5IHRob3NlIGVudHJpZXMgaXQgdW5kZXJz dGFuZHMsKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAz MTIuMDIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAzMDAuMDIzNiBjbQ0KMCAwIDAg cmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAgMSA2IC0zIGNtDQpxDQowIDAg MCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAoXDE3 NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KcQ0K MCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoZm9yIHBhY2tp bmcgY3VzdG9tIGluZm9ybWF0aW9uIGZvciBhIGN1c3RvbSBib290IGRvbWFpbiwpIFRqIFQq IEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDI5NC4wMjM2IGNtDQpR DQpxDQoxIDAgMCAxIDYyLjY5MjkxIDI4Mi4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEw IFRmIDEyIFRMIEVUDQpxDQoxIDAgMCAxIDYgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAg MCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAu NSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpxDQowIDAgMCByZw0KQlQg MSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMICh0aGUgYWJpbGl0eSB0byB1c2UgYSBu ZXcgTENNIHdpdGggYW4gb2xkZXIgaHlwZXJ2aXNvciwpIFRqIFQqIEVUDQpRDQpRDQpxDQpR DQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDI3Ni4wMjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYy LjY5MjkxIDI2NC4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpx DQoxIDAgMCAxIDYgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEg MTAgVGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpR DQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0g L0YxIDEwIFRmIDEyIFRMIChhbmQgdGhlIGFiaWxpdHkgdG8gdXNlIGFuIG9sZGVyIExDTSB3 aXRoIGEgbmV3IGh5cGVydmlzb3IuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAw IDAgMSA2Mi42OTI5MSAyNjQuMDIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAyMzcu MDIzNiBjbQ0KcQ0KQlQgMSAwIDAgMSAwIDIuNSBUbSAxNSBUTCAvRjMgMTIuNSBUZiAwIDAg MCByZyAoMy42LjIgICBBcm0gRGV2aWNlIFRyZWUpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAg MCAxIDYyLjY5MjkxIDE0Ny4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDc0 IFRtIC9GMSAxMCBUZiAxMiBUTCAyLjcyOTM5OCBUdyAoQXMgZGlzY3Vzc2VkIHRoZSBMQ00g aXMgaW4gRGV2aWNlIFRyZWUgZm9ybWF0IGFuZCB3YXMgZGVzaWduZWQgdG8gY28tZXhpc3Qg aW4gdGhlIERldmljZSBUcmVlKSBUaiBUKiAwIFR3IDIuMzUzMzE4IFR3IChlY29zeXN0ZW0s IGFuZCBpbiBwYXJ0aWN1bGFyIGluIHBhcmFsbGVsIHdpdGggZG9tMGxlc3MgRGV2aWNlIFRy ZWUgZW50cmllcy4gT24gQXJtLCBYZW4gaXMgYWxyZWFkeSkgVGogVCogMCBUdyAuMTA0OTg3 IFR3IChkZXNpZ25lZCB0byBib290IGZyb20gYSBob3N0IERldmljZSBUcmVlIGRlc2NyaXB0 aW9uIFwoZHRiXCkgZmlsZSBhbmQgdGhlIExDTSBlbnRyaWVzIGNhbiBiZSBlbWJlZGRlZCBp bnRvKSBUaiBUKiAwIFR3IDEuNTcyNjUxIFR3ICh0aGlzIGhvc3QgZHRiIGZpbGUuIFRoaXMg bWFrZXMgZGV0ZWN0aW5nIHRoZSBMQ00gZW50cmllcyBhbmQgc3VwcG9ydGluZyBoeXBlcmxh dW5jaCBvbiBBcm0gcmVsYXRpdmVseSkgVGogVCogMCBUdyAxLjEyNTYxIFR3IChzdHJhaWdo dCBmb3J3YXJkLiBSZWxhdGl2ZSB0byB0aGUgZGVzY3JpYmVkIHg4NiBhcHByb2FjaCwgYXQg dGhlIHBvaW50IHdoZXJlIFhlbiBpbnNwZWN0cyB0aGUgZmlyc3QgTUIyKSBUaiBUKiAwIFR3 IC40MTQ1MzUgVHcgKG1vZHVsZSwgb24gQXJtIFhlbiB3aWxsIGNoZWNrIGlmIHRoZSB0b3Ag bGV2ZWwgTENNIG5vZGUgZXhpc3RzIGluIHRoZSBob3N0IGR0YiBmaWxlLiBJZiB0aGUgTENN IG5vZGUgZG9lcykgVGogVCogMCBUdyAoZXhpc3QsIHRoZW4gYXQgdGhhdCBwb2ludCBpdCB3 aWxsIGVudGVyIGludG8gdGhlIHNhbWUgY29kZSBwYXRoIGFzIHRoZSB4ODYgZW50cnkgd291 bGQgZ28uKSBUaiBUKiBFVA0KUQ0KUQ0KIA0KZW5kc3RyZWFtDQplbmRvYmoNCjEyNCAwIG9i ag0KPDwgL0xlbmd0aCA1NTI3ID4+DQpzdHJlYW0NCjEgMCAwIDEgMCAwIGNtICBCVCAvRjEg MTIgVGYgMTQuNCBUTCBFVA0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA3NTAuMDIzNiBjbQ0KcQ0K QlQgMSAwIDAgMSAwIDIuNSBUbSAxNSBUTCAvRjMgMTIuNSBUZiAwIDAgMCByZyAoMy42LjMg ICBYZW4gaHlwZXJ2aXNvcikgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEg NjYwLjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgNzQgVG0gL0YxIDEwIFRm IDEyIFRMIC41Njg0MDkgVHcgKEl0IHdhcyBwcmV2aW91c2x5IGRpc2N1c3NlZCBhdCBhIGhp Z2hlciBsZXZlbCBvZiB0aGUgbmV3IGhvc3QgYm9vdCBmbG93IHRoYXQgd2lsbCBiZSBpbnRy b2R1Y2VkLiBXaXRoaW4gdGhpcykgVGogVCogMCBUdyAuNTY5MzYgVHcgKG5ldyBmbG93IGlz IHRoZSBjb25maWd1cmF0aW9uIHBhcnNpbmcgYW5kIGRvbWFpbiBjcmVhdGlvbiBwaGFzZSB3 aGljaCB3aWxsIGJlIGV4cGFuZGVkIHVwb24gaGVyZS4gVGhlKSBUaiBUKiAwIFR3IC41Mzgz MiBUdyAoaHlwZXJ2aXNvciB3aWxsIGluc3BlY3QgdGhlIExDTSBmb3IgYSBjb25maWcgbm9k ZSBhbmQgaWYgZm91bmQgd2lsbCBpdGVyYXRlIHRocm91Z2ggYWxsIG1vZHVsZXMgbm9kZXMu IFRoZSkgVGogVCogMCBUdyAuOTk1MjggVHcgKG1vZHVsZSBub2RlcyBhcmUgdXNlZCB0byBp ZGVudGlmeSBpZiBhbnkgbW9kdWxlcyBjb250YWluIG1pY3JvY29kZSBvciBhbiBYU00gcG9s aWN5LiBBcyBpdCBwcm9jZXNzZXMpIFRqIFQqIDAgVHcgLjMzOTM5OCBUdyAoZG9tYWluIG5v ZGVzLCBpdCB3aWxsIGNvbnN0cnVjdCB0aGUgZG9tYWluIHVzaW5nIHRoZSBub2RlIHByb3Bl cnRpZXMgYW5kIHRoZSBtb2R1bGVzIG5vZGVzLiBPbmNlIGl0IGhhcykgVGogVCogMCBUdyAx Ljg4OTk4NSBUdyAoY29tcGxldGVkIGl0ZXJhdGluZyB0aHJvdWdoIGFsbCB0aGUgZW50cmll cyBpbiB0aGUgTENNLCBpZiBhIGNvbnN0cnVjdGVkIGRvbWFpbiBoYXMgdGhlIEJvb3QgRG9t YWluKSBUaiBUKiAwIFR3IChhdHRyaWJ1dGUsIGl0IHdpbGwgdGhlbiBiZSB1bnBhdXNlZC4g T3RoZXJ3aXNlIHRoZSBoeXBlcnZpc29yIHdpbGwgc3RhcnQgdGhlIGxhdW5jaCBmaW5hbGl6 YXRpb24gcGhhc2UuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA2MzMu MDIzNiBjbQ0KcQ0KQlQgMSAwIDAgMSAwIDIuNSBUbSAxNSBUTCAvRjMgMTIuNSBUZiAwIDAg MCByZyAoMy42LjQgICBCb290IERvbWFpbikgVGogVCogRVQNClENClENCnENCjEgMCAwIDEg NjIuNjkyOTEgNTU1LjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgNjIgVG0g L0YxIDEwIFRmIDEyIFRMIDEuMTc1MzY2IFR3IChUcmFkaXRpb25hbGx5IGRvbWFpbiBjcmVh dGlvbiB3YXMgY29udHJvbGxlZCBieSB0aGUgdXNlciB3aXRoaW4gdGhlIERvbTAgZW52aXJv bm1lbnQgd2hlcmVieSBjdXN0b20pIFRqIFQqIDAgVHcgLjIyMzczNSBUdyAodG9vbHN0YWNr cyBjb3VsZCBiZSBpbXBsZW1lbnRlZCB0byBpbXBvc2UgcmVxdWlyZW1lbnRzIG9uIHRoZSBw cm9jZXNzLiBUaGUgQm9vdCBEb21haW4gaXMgYSBtZWFucyB0bykgVGogVCogMCBUdyAuNTk4 MzIgVHcgKGVuYWJsZSB0aGUgdXNlciB0byBjb250aW51ZSB0byBtYWludGFpbiBhIGRlZ3Jl ZSBvZiB0aGF0IGNvbnRyb2wgb3ZlciBkb21haW4gY3JlYXRpb24gYnV0IHdpdGhpbiBhIGxp bWl0ZWQpIFRqIFQqIDAgVHcgMS45OTQ5ODUgVHcgKHByaXZpbGVnZSBlbnZpcm9ubWVudC4g VGhlIEJvb3QgRG9tYWluIHdpbGwgaGF2ZSBhY2Nlc3MgdG8gdGhlIExDTSBhbmQgdGhlIGJv b3QgY2hhaW4gYWxvbmcgd2l0aCkgVGogVCogMCBUdyAyLjUzMTE2MyBUdyAoYWNjZXNzIHRv IGEgc3Vic2V0IG9mIHRoZSBoeXBlcmNhbGwgb3BlcmF0aW9ucy4gV2hlbiB0aGUgQm9vdCBE b21haW4gaXMgZmluaXNoZWQgaXQgd2lsbCBub3RpZnkgdGhlKSBUaiBUKiAwIFR3IChoeXBl cnZpc29yIHRocm91Z2ggYSBoeXBlcmNhbGwgb3AuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAw IDAgMSA2Mi42OTI5MSA1MjguMDIzNiBjbQ0KcQ0KQlQgMSAwIDAgMSAwIDIuNSBUbSAxNSBU TCAvRjMgMTIuNSBUZiAwIDAgMCByZyAoMy42LjUgICBDcmFzaCBEb21haW4pIFRqIFQqIEVU DQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDQ1MC4wMjM2IGNtDQpxDQowIDAgMCByZw0K QlQgMSAwIDAgMSAwIDYyIFRtIC9GMSAxMCBUZiAxMiBUTCAxLjYxMjQ4NSBUdyAoV2l0aCB0 aGUgZXhpc3RpbmcgRG9tMCBob3N0IGJvb3QgcGF0aCwgd2hlbiBhIGZhaWx1cmUgb2NjdXJz IHRoZXJlIGFyZSBzZXZlcmFsIGFzc3VtcHRpb25zIHRoYXQgY2FuKSBUaiBUKiAwIFR3IC4w MDk5ODcgVHcgKHNhZmVseSBiZSBtYWRlIHRvIGdldCB0aGUgdXNlciB0byBhIGNvbnNvbGUg Zm9yIHRyb3VibGVzaG9vdGluZy4gV2l0aCB0aGUgaHlwZXJsYXVuY2ggaG9zdCBib290IHBh dGggdGhvc2UpIFRqIFQqIDAgVHcgLjEzNDUzNSBUdyAoYXNzdW1wdGlvbnMgY2FuIG5vIGxv bmdlciBiZSBtYWRlLCB0aHVzIGEgbWVhbnMgaXMgbmVlZGVkIHRvIGdldCB0aGUgdXNlciB0 byBhIGNvbnNvbGUgaW4gdGhlIGNhc2Ugb2YgYSkgVGogVCogMCBUdyAxLjAwOTI2OSBUdyAo cmVjb3ZlcmFibGUgZmFpbHVyZS4gVG8gaGFuZGxlIHRoaXMgc2l0dWF0aW9uIGh5cGVybGF1 bmNoIGZvcm1hbGl6ZXMgdGhlIGNvbmNlcHQgb2YgYSBjcmFzaCBkb21haW4uIFRoZSkgVGog VCogMCBUdyAxLjM3MTA5OCBUdyAoY3Jhc2ggZG9tYWluIGlzIGNvbmZpZ3VyZWQgYnkgYSBk b21haW4gY29uZmlndXJhdGlvbiBlbnRyeSBpbiB0aGUgTENNIGFuZCBpdCB3aWxsIG5vdCBi ZSB1bnBhdXNlZCBhdCkgVGogVCogMCBUdyAobGF1bmNoIGZpbmFsaXphdGlvbiB1bmxlc3Mg YSBmYWlsdXJlIGlzIGVuY291bnRlcmVkLikgVGogVCogRVQNClENClENCnENCjEgMCAwIDEg NjIuNjkyOTEgNDIzLjAyMzYgY20NCnENCkJUIDEgMCAwIDEgMCAyLjUgVG0gMTUgVEwgL0Yz IDEyLjUgVGYgMCAwIDAgcmcgKDMuNi42ICAgQ29udHJvbCBEb21haW4pIFRqIFQqIEVUDQpR DQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDM2OS4wMjM2IGNtDQpxDQpCVCAxIDAgMCAxIDAg MzggVG0gMS4zNDkzMTggVHcgMTIgVEwgL0YxIDEwIFRmIDAgMCAwIHJnIChUaGUgY29uY2Vw dCBvZiB0aGUgQ29udHJvbCBEb21haW4gYWxyZWFkeSBleGlzdHMgd2l0aGluIFhlbiBhcyBh IGJvb2xlYW4sICkgVGogL0Y1IDEwIFRmIDAgMCAwIHJnIChpc19wcml2aWxlZ2VkKSBUaiAv RjEgMTAgVGYgMCAwIDAgcmcgKCwgdGhhdCBnb3Zlcm5zKSBUaiBUKiAwIFR3IC4xMTg3MzUg VHcgKGFjY2VzcyB0byBtYW55IG9mIHRoZSBwcml2aWxlZ2VkIGludGVyZmFjZXMgb2YgdGhl IGh5cGVydmlzb3IgdGhhdCBzdXBwb3J0IGEgZG9tYWluIHJ1bm5pbmcgYSB2aXJ0dWFsaXph dGlvbikgVGogVCogMCBUdyAuNzAxMTYzIFR3IChzeXN0ZW0gdG9vbHN0YWNrLiBIeXBlcmxh dW5jaCB3aWxsIGFsbG93IHRoZSApIFRqIC9GNSAxMCBUZiAwIDAgMCByZyAoaXNfcHJpdmls ZWdlZCApIFRqIC9GMSAxMCBUZiAwIDAgMCByZyAoZmxhZyB0byBiZSBzZXQgb24gYW55IGRv bWFpbiB0aGF0IGlzIGNyZWF0ZWQgYXQpIFRqIFQqIDAgVHcgKGxhdW5jaCwgcmF0aGVyIHRo YW4gb25seSBhIERvbTAuIEl0IG1heSBwb3RlbnRpYWxseSBiZSBzZXQgb24gbXVsdGlwbGUg ZG9tYWlucy4pIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDM0Mi4wMjM2 IGNtDQpxDQpCVCAxIDAgMCAxIDAgMi41IFRtIDE1IFRMIC9GMyAxMi41IFRmIDAgMCAwIHJn ICgzLjYuNyAgIEhhcmR3YXJlIERvbWFpbikgVGogVCogRVQNClENClENCnENCjEgMCAwIDEg NjIuNjkyOTEgMjc2LjAyMzYgY20NCnENCkJUIDEgMCAwIDEgMCA1MCBUbSA2LjY4NTY5NyBU dyAxMiBUTCAvRjEgMTAgVGYgMCAwIDAgcmcgKFRoZSBIYXJkd2FyZSBEb21haW4gaXMgYWxz byBhbiBleGlzdGluZyBjb25jZXB0IGZvciBYZW4gdGhhdCBpcyBlbmFibGVkIHRocm91Z2gg dGhlKSBUaiBUKiAwIFR3IDEuNDU1ODE0IFR3IC9GNSAxMCBUZiAwIDAgMCByZyAoaXNfaGFy ZHdhcmVfZG9tYWluICkgVGogL0YxIDEwIFRmIDAgMCAwIHJnIChjaGVjay4gV2l0aCBoeXBl cmxhdW5jaCB0aGUgcHJldmlvdXMgcHJvY2VzcyBvZiBJL08gYWNjZXNzZXMgYmVpbmcgYXNz aWduZWQgdG8pIFRqIFQqIDAgVHcgMy4zMTI2NTEgVHcgKERvbTAgZm9yIGxhdGVyIHRyYW5z ZmVyIHRvIHRoZSBoYXJkd2FyZSBkb21haW4gd291bGQgbm8gbG9uZ2VyIGJlIHJlcXVpcmVk LiBJbnN0ZWFkIGR1cmluZyB0aGUpIFRqIFQqIDAgVHcgMS41NzEzMTggVHcgKGNvbmZpZ3Vy YXRpb24gcGhhc2UgdGhlIFhlbiBoeXBlcnZpc29yIHdvdWxkIGRpcmVjdGx5IGFzc2lnbiB0 aGUgSS9PIGFjY2Vzc2VzIHRvIHRoZSBkb21haW4gd2l0aCB0aGUpIFRqIFQqIDAgVHcgKGhh cmR3YXJlIGRvbWFpbiBwZXJtaXNzaW9uIGJpdCBlbmFibGVkLikgVGogVCogRVQNClENClEN CnENCjEgMCAwIDEgNjIuNjkyOTEgMjQ5LjAyMzYgY20NCnENCkJUIDEgMCAwIDEgMCAyLjUg VG0gMTUgVEwgL0YzIDEyLjUgVGYgMCAwIDAgcmcgKDMuNi44ICAgQ29uc29sZSBEb21haW4p IFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDE3MS4wMjM2IGNtDQpxDQow IDAgMCByZw0KQlQgMSAwIDAgMSAwIDYyIFRtIC9GMSAxMCBUZiAxMiBUTCAuNDk5MzYgVHcg KFRyYWRpdGlvbmFsbHkgdGhlIFhlbiBjb25zb2xlIGlzIGFzc2lnbmVkIHRvIHRoZSBjb250 cm9sIGRvbWFpbiBhbmQgdGhlbiByZWFzc2lnbmFibGUgYnkgdGhlIHRvb2xzdGFjayB0bykg VGogVCogMCBUdyAuMTYzMzE4IFR3IChhbm90aGVyIGRvbWFpbi4gV2l0aCBoeXBlcmxhdW5j aCBpdCBiZWNvbWVzIHBvc3NpYmxlIHRvIGNvbnN0cnVjdCBhIGJvb3QgY29uZmlndXJhdGlv biB3aGVyZSB0aGVyZSBpcyBubykgVGogVCogMCBUdyAxLjU1NTU0MiBUdyAoY29udHJvbCBk b21haW4gb3IgaGF2ZSBhIHVzZSBjYXNlIHdoZXJlIHRoZSBYZW4gY29uc29sZSBuZWVkcyB0 byBiZSBpc29sYXRlZC4gQXMgc3VjaCBpdCBiZWNvbWVzKSBUaiBUKiAwIFR3IDEuOTkyNDg1 IFR3IChuZWNlc3NhcnkgdG8gYmUgYWJsZSB0byBkZXNpZ25hdGUgd2hpY2ggb2YgdGhlIGlu aXRpYWwgZG9tYWlucyBzaG91bGQgYmUgYXNzaWduZWQgdGhlIFhlbiBjb25zb2xlLikgVGog VCogMCBUdyAxLjQ0NjQxMiBUdyAoVGhlcmVmb3JlIGh5cGVybGF1bmNoIGludHJvZHVjZXMg dGhlIGFiaWxpdHkgdG8gc3BlY2lmeSBhbiBpbml0aWFsIGRvbWFpbiB3aGljaCB0aGUgY29u c29sZSBpcyBhc3NpZ25lZCkgVGogVCogMCBUdyAoYWxvbmcgd2l0aCBhIGNvbnZlbnRpb24g b2Ygb3JkZXJlZCBhc3NpZ25tZW50IGZvciB3aGVuIHRoZXJlIGlzIG5vIGV4cGxpY2l0IGFz c2lnbm1lbnQuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAxNDIuNjc3 MiBjbQ0KbiAwIDE0LjE3MzIzIG0gNDY5Ljg4OTggMTQuMTczMjMgbCBTDQpRDQogDQplbmRz dHJlYW0NCmVuZG9iag0KMTI1IDAgb2JqDQo8PCAvTGVuZ3RoIDMzMzkgPj4NCnN0cmVhbQ0K MSAwIDAgMSAwIDAgY20gIEJUIC9GMSAxMiBUZiAxNC40IFRMIEVUDQpxDQoxIDAgMCAxIDYy LjY5MjkxIDc0NC4wMjM2IGNtDQpxDQpCVCAxIDAgMCAxIDAgMy41IFRtIDIxIFRMIC9GMiAx Ny41IFRmIDAgMCAwIHJnICg0ICAgQXBwZW5kaXgpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAg MCAxIDYyLjY5MjkxIDcxNC4wMjM2IGNtDQpxDQpCVCAxIDAgMCAxIDAgMyBUbSAxOCBUTCAv RjIgMTUgVGYgMCAwIDAgcmcgKDQuMSAgIEFwcGVuZGl4IDE6IEZsb3cgU2VxdWVuY2Ugb2Yg U3RlcHMgb2YgYSBoeXBlcmxhdW5jaCBCb290KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAg MSA2Mi42OTI5MSA2ODQuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAxNCBU bSAvRjEgMTAgVGYgMTIgVEwgMS4yMjM1MTYgVHcgKFByb3ZpZGVkIGhlcmUgaXMgYW4gb3Jk ZXJlZCBmbG93IG9mIGEgaHlwZXJsYXVuY2ggd2l0aCBhIGhpZ2hsaWdodCBsb2dpYyBkZWNp c2lvbiBwb2ludHMuIE5vdCBhbGwgYnJhbmNoKSBUaiBUKiAwIFR3IChwb2ludHMgYXJlIHJl Y29yZGVkLCBzcGVjaWZpY2FsbHkgZm9yIHRoZSB2YXJpZXR5IG9mIGVycm9yIGNvbmRpdGlv bnMgdGhhdCBtYXkgb2NjdXIuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5 MSAxMzQuODIzNiBjbQ0KcQ0KcQ0KMSAwIDAgMSAwIDAgY20NCnENCjEgMCAwIDEgNi42IDYu NiBjbQ0KcQ0KLjY2Mjc0NSAuNjYyNzQ1IC42NjI3NDUgUkcNCi41IHcNCi45NjA3ODQgLjk2 MDc4NCAuODYyNzQ1IHJnDQpuIC02IC02IDQ2OC42ODk4IDU0MCByZSBCKg0KUQ0KcQ0KMCAw IDAgcmcNCkJUIDEgMCAwIDEgMCA1MTggVG0gL0Y0IDEwIFRmIDEyIFRMICgxLiBIeXBlcnZp c29yIFN0YXJ0dXA6KSBUaiBUKiAoMmEuIFwoeDg2XCkgSW5zcGVjdCBmaXJzdCBtb2R1bGUg cHJvdmlkZWQgYnkgdGhlIGJvb3Rsb2FkZXIpIFRqIFQqICggICAgYS4gSXMgdGhlIG1vZHVs ZSBhbiBMQ00pIFRqIFQqICggICAgICAgIGkuIFlFUzogcHJvY2VlZCB3aXRoIHRoZSBoeXBl cmxhdW5jaCBob3N0IGJvb3QgcGF0aCkgVGogVCogKCAgICAgICAgaWkuIE5POiBwcm9jZWVk IHdpdGggYSBEb20wIGhvc3QgYm9vdCBwYXRoKSBUaiBUKiAoMmIuIFwoQXJtXCkgSW5zcGVj dCBob3N0IGR0YiBmb3IgYC9jaG9zZW4vaHlwZXJ2aXNvcmAgbm9kZSkgVGogVCogKCAgICBh LiBJcyB0aGUgTENNIHByZXNlbnQpIFRqIFQqICggICAgICAgIGkuIFlFUzogcHJvY2VlZCB3 aXRoIHRoZSBoeXBlcmxhdW5jaCBob3N0IGJvb3QgcGF0aCkgVGogVCogKCAgICAgICAgaWku IE5POiBwcm9jZWVkIHdpdGggYSBEb20wL2RvbTBsZXNzIGhvc3QgYm9vdCBwYXRoKSBUaiBU KiAoMy4gSXRlcmF0ZSB0aHJvdWdoIHRoZSBMQ00gZW50cmllcyBsb29raW5nIGZvciB0aGUg bW9kdWxlIGRlc2NyaXB0aW9uKSBUaiBUKiAoICAgZW50cnkpIFRqIFQqICggICAgYS4gQ2hl Y2sgaWYgYW55IG9mIHRoZSBtb2R1bGVzIGFyZSBtaWNyb2NvZGUgb3IgcG9saWN5IGFuZCBp ZiBzbywpIFRqIFQqICggICAgICAgbG9hZCkgVGogVCogKDQuIEl0ZXJhdGUgdGhyb3VnaCB0 aGUgTENNIGVudHJpZXMgcHJvY2Vzc2luZyBhbGwgZG9tYWluIGRlc2NyaXB0aW9uKSBUaiBU KiAoICAgZW50cmllcykgVGogVCogKCAgICBhLiBVc2UgdGhlIGRldGFpbHMgZnJvbSB0aGUg QmFzaWMgQ29uZmlndXJhdGlvbiB0byBjYWxsKSBUaiBUKiAoICAgICAgIGBkb21haW5fY3Jl YXRlYCkgVGogVCogKCAgICBiLiBSZWNvcmQgaWYgYSBkb21haW4gaXMgZmxhZ2dlZCBhcyB0 aGUgQm9vdCBEb21haW4pIFRqIFQqICggICAgYy4gUmVjb3JkIGlmIGEgZG9tYWluIGlzIGZs YWdnZWQgYXMgdGhlIENyYXNoIERvbWFpbikgVGogVCogKDUuIFdhcyBhIEJvb3QgRG9tYWlu IGNyZWF0ZWQpIFRqIFQqICggICAgYS4gWUVTOikgVGogVCogKCAgICAgICAgaS4gQXR0YWNo IGNvbnNvbGUgdG8gQm9vdCBEb21haW4pIFRqIFQqICggICAgICAgIGlpLiBVbnBhdXNlIEJv b3QgRG9tYWluKSBUaiBUKiAoICAgICAgICBpaWkuIEdvdG8gQm9vdCBEb21haW4gXChzdGVw IDZcKSkgVGogVCogKCAgICBiLiBOTzogR290byBMYXVuY2ggRmluYWxpemF0aW9uIFwoc3Rl cCAxMFwpKSBUaiBUKiAoNi4gQm9vdCBEb21haW46KSBUaiBUKiAoNy4gQm9vdCBEb21haW4g Y29tZXMgb25saW5lIGFuZCBtYXkgZG8gYW55IG9mIHRoZSBmb2xsb3dpbmcgYWN0aW9ucykg VGogVCogKCAgICBhLiBQcm9jZXNzIHRoZSBMQ00pIFRqIFQqICggICAgYi4gVmFsaWRhdGUg dGhlIE1CMiBjaGFpbikgVGogVCogKCAgICBjLiBNYWtlIGFkZGl0aW9uYWwgY29uZmlndXJh dGlvbiBzZXR0aW5ncyBmb3Igc3RhZ2VkIGRvbWFpbnMpIFRqIFQqICggICAgZC4gVW5wYXVz ZSBhbnkgcHJlY3Vyc29yIGRvbWFpbnMpIFRqIFQqICggICAgZS4gU2V0IGFueSBydW50aW1l IGNvbmZpZ3VyYXRpb25zKSBUaiBUKiAoOC4gQm9vdCBEb21haW4gZG9lcyBhbnkgbmVjZXNz YXJ5IGNsZWFudXApIFRqIFQqICg5LiBCb290IERvbWFpbiBtYWtlIGh5cGVyY2FsbCBvcCBj YWxsIHRvIHNpZ25hbCBpdCBpcyBmaW5pc2hlZCkgVGogVCogKCAgICBpLiBIeXBlcnZpc29y IHJlY2xhaW1zIGFsbCBCb290IERvbWFpbiByZXNvdXJjZXMpIFRqIFQqICggICAgaWkuIEh5 cGVydmlzb3IgcmVjb3JkcyB0aGF0IHRoZSBCb290IERvbWFpbiByYW4pIFRqIFQqICggICAg aWkuIEdvdG8gTGF1bmNoIEZpbmFsaXphdGlvbiBcKHN0ZXAgOVwpKSBUaiBUKiAoMTAuIExh dW5jaCBGaW5hbGl6YXRpb24pIFRqIFQqICgxMS4gSWYgYSBjb25maWd1cmVkIGRvbWFpbiB3 YXMgZmxhZ2dlZCB0byBoYXZlIHRoZSBjb25zb2xlLCB0aGUpIFRqIFQqICggICAgaHlwZXJ2 aXNvciBhc3NpZ25zIGl0KSBUaiBUKiAoMTIuIFRoZSBoeXBlcnZpc29yIGNsZWFycyB0aGUg TENNIGFuZCBib290bG9hZGVyIGxvYWRlZCBtb2R1bGUsKSBUaiBUKiAoICAgIHJlY2xhaW1p bmcgdGhlIG1lbW9yeSkgVGogVCogKDEzLiBUaGUgaHlwZXJ2aXNvciBpdGVyYXRlcyB0aHJv dWdoIGRvbWFpbnMgdW5wYXVzaW5nIGFueSBkb21haW4gbm90KSBUaiBUKiAoICAgIGZsYWdn ZWQgYXMgdGhlIGNyYXNoIGRvbWFpbikgVGogVCogRVQNClENClENClENClENClENCnENCjEg MCAwIDEgNjIuNjkyOTEgODYuODIzNjIgY20NCnENCkJUIDEgMCAwIDEgMCAyMSBUbSAxOCBU TCAvRjIgMTUgVGYgMCAwIDAgcmcgKDQuMiAgIEFwcGVuZGl4IDI6IENvbnNpZGVyYXRpb25z IGluIE5hbWluZyB0aGUgSHlwZXJsYXVuY2gpIFRqIFQqIChGZWF0dXJlKSBUaiBUKiBFVA0K UQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA3Ni44NjYxNCBjbQ0KUQ0KIA0KZW5kc3RyZWFt DQplbmRvYmoNCjEyNiAwIG9iag0KPDwgL0xlbmd0aCAxMTI3NCA+Pg0Kc3RyZWFtDQoxIDAg MCAxIDAgMCBjbSAgQlQgL0YxIDEyIFRmIDE0LjQgVEwgRVQNCnENCjEgMCAwIDEgNjIuNjky OTEgNzY1LjAyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNjg3LjAyMzYgY20NCjAg MCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiA2MyBjbQ0KcQ0K MCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQg KFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgNjMgY20N CnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKFRoZSB0 ZXJtIFwyMjNMYXVuY2hcMjI0IGlzIHByZWZlcnJlZCBvdmVyIFwyMjNCb290XDIyNCkgVGog VCogRVQNClENClENCnENCjEgMCAwIDEgMjMgNTcgY20NClENCnENCjEgMCAwIDEgMjMgLTMg Y20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCkJUIDEgMCAwIDEgMCAyIFRt ICBUKiBFVA0KcQ0KMSAwIDAgMSAyMCA1NCBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMCA1NCBjbQ0K UQ0KcQ0KMSAwIDAgMSAyMCAzMCBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBF VA0KcQ0KMSAwIDAgMSA2IDkgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAv RjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpR DQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0 IFRtIC9GMSAxMCBUZiAxMiBUTCAuNjI4NDQzIFR3IChNdWx0aXBsZSBpbmRpdmlkdWFsIGNv bXBvbmVudCBib290cyBjYW4gb2NjdXIgaW4gdGhlIG5ldyBzeXN0ZW0gc3RhcnQgcHJvY2Vz czsgTGF1bmNoIGlzKSBUaiBUKiAwIFR3IChwcmVmZXJhYmxlIGZvciBkZXNjcmliaW5nIHRo ZSB3aG9sZSBwcm9jZXNzKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSAy MCAyNCBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMCAwIGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRm IDEyIFRMIEVUDQpxDQoxIDAgMCAxIDYgOSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEg MCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAg VGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAg MCAxIDAgMTQgVG0gL0YxIDEwIFRmIDEyIFRMIC40OTg0NDMgVHcgKEZvcnR1bmF0ZWx5IHRo ZXJlIGlzIGNvbnNlbnN1cyBpbiB0aGUgY3VycmVudCBncm91cCBvZiBzdGFrZWhvbGRlcnMg dGhhdCB0aGUgdGVybSBcMjIzTGF1bmNoXDIyNCkgVGogVCogMCBUdyAoaXMgZ29vZCBhbmQg YXBwcm9wcmlhdGUpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDIwIDAg Y20NClENCnENClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NClENCnENClENClENCnENCjEg MCAwIDEgNjIuNjkyOTEgNjgxLjAyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNTY3 LjAyMzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEg NiA5OSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBU TCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAw IDEgMjMgODcgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEwIFRm IDEyIFRMIDIuODE5MjY5IFR3IChUaGUgbmFtZXMgd2UgZGVmaW5lIG11c3Qgc3VwcG9ydCBi ZWNvbWluZyBtZWFuaW5nZnVsIGFuZCBzaW1wbGUgdG8gdXNlIG91dHNpZGUgdGhlIFhlbikg VGogVCogMCBUdyAoY29tbXVuaXR5KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyA4 MSBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAx MiBUTCBFVA0KQlQgMSAwIDAgMSAwIDIgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDc4IGNt DQpRDQpxDQoxIDAgMCAxIDIwIDc4IGNtDQpRDQpxDQoxIDAgMCAxIDIwIDY2IGNtDQowIDAg MCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAgMCAxIDYgLTMgY20NCnENCjAg MCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRkIChc MTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpx DQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChUaGV5IG11 c3QgYmUgYWJsZSB0byBiZSByZXNvbHZlZCBxdWlja2x5IHZpYSBzZWFyY2ggZW5naW5lIHRv IGEgY2xlYXIpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDIwIDYwIGNt DQpRDQpxDQoxIDAgMCAxIDIwIDQ4IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRM IEVUDQpxDQoxIDAgMCAxIDYgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBU bSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVU DQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAw IDIgVG0gL0YxIDEwIFRmIDEyIFRMIChleHBsYW5hdGlvbiBcKGVnLiBYZW4gbWFya2V0aW5n IG1hdGVyaWFsLCBkb2N1bWVudGF0aW9uIG9yIHdpa2lcKSkgVGogVCogRVQNClENClENCnEN ClENClENCnENCjEgMCAwIDEgMjAgNDIgY20NClENCnENCjEgMCAwIDEgMjAgMzAgY20NCjAg MCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0KcQ0K MCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQg KFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMgY20N CnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKFdlIHBy ZWZlciB0aGF0IHRoZSB0ZXJtcyBiZSBoZWxwZnVsIGZvciBtYXJrZXRpbmcgY29tbXVuaWNh dGlvbnMpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDIwIDI0IGNtDQpR DQpxDQoxIDAgMCAxIDIwIDAgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQN CnENCjEgMCAwIDEgNiA5IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0Yx IDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAoXDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0K UQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAxNCBU bSAvRjEgMTAgVGYgMTIgVEwgLjA3MjI5IFR3IChDb25zZXF1ZW5jZTogYXZvaWQgdGhlIHRl cm0gXDIyM2RvbWFpblwyMjQgd2hpY2ggaXMgWGVuLXNwZWNpZmljIGFuZCByZXF1aXJlcyBh IGRlZmluaXRpb24gdG8gYmUpIFRqIFQqIDAgVHcgKHByb3ZpZGVkIGVhY2ggdGltZSB3aGVu IHVzZWQgZWxzZXdoZXJlKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSAy MCAwIGNtDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpRDQpxDQpRDQpRDQpx DQoxIDAgMCAxIDYyLjY5MjkxIDU2MS4wMjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5Mjkx IDUxMy4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAg MCAxIDYgMzMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYg MTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpxDQox IDAgMCAxIDIzIDMzIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEw IFRmIDEyIFRMIChUaGVyZSBpcyBhIG5lZWQgdG8gY29tbXVuaWNhdGUgdGhhdCBYZW4gaXMg Y2FwYWJsZSBvZiBiZWluZyB1c2VkIGFzIGEgU3RhdGljIFBhcnRpdGlvbmluZyBoeXBlcnZp c29yKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAyNyBjbQ0KUQ0KcQ0KMSAwIDAg MSAyMyAtMyBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAg MSAwIDIgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDI0IGNtDQpRDQpxDQoxIDAgMCAxIDIw IDI0IGNtDQpRDQpxDQoxIDAgMCAxIDIwIDAgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYg MTIgVEwgRVQNCnENCjEgMCAwIDEgNiA5IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAw IDIgVG0gL0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAoXDE3NykgVGogVCogLTEwLjUgMCBU ZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAw IDEgMCAxNCBUbSAvRjEgMTAgVGYgMTIgVEwgNC4xNTQ5NzYgVHcgKFRoZSBjb21tdW5pdHkg bWVtYmVycyB1c2luZyBhbmQgbWFpbnRhaW5pbmcgZG9tMGxlc3MgYXJlIHRoZSBjdXJyZW50 IHByaW1hcnkpIFRqIFQqIDAgVHcgKHN0YWtlaG9sZGVycyBmb3IgdGhpcykgVGogVCogRVQN ClENClENCnENClENClENCnENCjEgMCAwIDEgMjAgMCBjbQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAw IDAgMSAyMyAtMyBjbQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA1MDcuMDIz NiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAxODMuMDIzNiBjbQ0KMCAwIDAgcmcNCkJU IC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAgMSA2IDMwOSBjbQ0KcQ0KMCAwIDAgcmcN CkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRq IFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgMjk3IGNtDQpxDQowIDAg MCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAxMiBUTCAyLjAyNTY5NyBUdyAo VGhlcmUgaXMgYSBuZWVkIHRvIGNvbW11bmljYXRlIHRoYXQgdGhlIG5ldyBsYXVuY2ggZnVu Y3Rpb25hbGl0eSBwcm92aWRlcyBuZXcgY2FwYWJpbGl0aWVzIG5vdCkgVGogVCogMCBUdyAo YXZhaWxhYmxlIGVsc2V3aGVyZSwgYW5kIGlzIG1vcmUgdGhhbiBqdXN0IHN1cHBvcnRpbmcg U3RhdGljIFBhcnRpdGlvbmluZykgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMjMgMjkx IGNtDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEy IFRMIEVUDQpCVCAxIDAgMCAxIDAgMiBUbSAgVCogRVQNCnENCjEgMCAwIDEgMjAgMjg4IGNt DQpRDQpxDQoxIDAgMCAxIDIwIDI4OCBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMCAwIGNtDQowIDAg MCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAgMCAxIDYgMjczIGNtDQpxDQow IDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAo XDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAyNjEgY20N CnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEwIFRmIDEyIFRMIDEuMzM2 NDEyIFR3IChObyBvdGhlciBoeXBlcnZpc29yIGtub3duIHRvIHRoZSBhdXRob3JzIG9mIHRo aXMgZG9jdW1lbnQgaXMgY2FwYWJsZSBvZiBwcm92aWRpbmcgd2hhdCkgVGogVCogMCBUdyAo SHlwZXJsYXVuY2ggd2lsbCBiZSBhYmxlIHRvIGRvLiBUaGUgbGF1bmNoIHNlcXVlbmNlIGlz IGRlc2lnbmVkIHRvOikgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgMjMgMjU1IGNtDQpR DQpxDQoxIDAgMCAxIDIzIC0zIGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVU DQpCVCAxIDAgMCAxIDAgMiBUbSAgVCogRVQNCnENCjEgMCAwIDEgMjAgMjUyIGNtDQpRDQpx DQoxIDAgMCAxIDIwIDI1MiBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMCAyNDAgY20NCjAgMCAwIHJn DQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0KcQ0KMCAwIDAg cmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcp IFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAg MCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKFJlbW92ZSBkZXBl bmRlbmN5IG9uIGEgc2luZ2xlLCBoaWdobHktcHJpdmlsZWdlZCBpbml0aWFsIGRvbWFpbikg VGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgMjAgMjM0IGNtDQpRDQpxDQox IDAgMCAxIDIwIDIxMCBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0K MSAwIDAgMSA2IDkgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAg VGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpx DQoxIDAgMCAxIDIzIC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9G MSAxMCBUZiAxMiBUTCAxLjEyNDk4IFR3IChBbGxvdyB0aGUgaW5pdGlhbCBkb21haW5zIHN0 YXJ0ZWQgdG8gYmUgaW5kZXBlbmRlbnQgYW5kIGZ1bGx5IGlzb2xhdGVkIGZyb20gZWFjaCkg VGogVCogMCBUdyAob3RoZXIpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAx IDIwIDIwNCBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMCAxODAgY20NCjAgMCAwIHJnDQpCVCAvRjEg MTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiA5IGNtDQpxDQowIDAgMCByZw0KQlQgMSAw IDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAoXDE3NykgVGogVCogLTEw LjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJU IDEgMCAwIDEgMCAxNCBUbSAvRjEgMTAgVGYgMTIgVEwgMS43ODI3MDYgVHcgKFN1cHBvcnQg Y29uZmlndXJhdGlvbnMgd2hlcmUgbm8gZnVydGhlciBWTXMgY2FuIGJlIGxhdW5jaGVkIG9u Y2UgdGhlIGluaXRpYWwpIFRqIFQqIDAgVHcgKGRvbWFpbnMgaGF2ZSBzdGFydGVkKSBUaiBU KiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMCAxNzQgY20NClENCnENCjEgMCAw IDEgMjAgMTYyIGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAg MCAxIDYgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYg MTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpxDQox IDAgMCAxIDIzIC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEw IFRmIDEyIFRMIChVc2UgYSBzdGFuZGFyZCwgZXh0ZW5zaWJsZSBmb3JtYXQgZm9yIGNvbnZl eWluZyBWTSBjb25maWd1cmF0aW9uIGRhdGEpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpx DQoxIDAgMCAxIDIwIDE1NiBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMCAxMzIgY20NCjAgMCAwIHJn DQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiA5IGNtDQpxDQowIDAgMCBy Zw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAoXDE3Nykg VGogVCogLTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KcQ0KMCAw IDAgcmcNCkJUIDEgMCAwIDEgMCAxNCBUbSAvRjEgMTAgVGYgMTIgVEwgLjgwMzMxNCBUdyAo RW5zdXJlIHRoYXQgZG9tYWluIGJ1aWxkaW5nIG9mIGFsbCBpbml0aWFsIGRvbWFpbnMgaXMg cGVyZm9ybWVkIGJ5IHRoZSBoeXBlcnZpc29yKSBUaiBUKiAwIFR3IChmcm9tIG1hdGVyaWFs cyBzdXBwbGllZCBieSB0aGUgYm9vdGxvYWRlcikgVGogVCogRVQNClENClENCnENClENClEN CnENCjEgMCAwIDEgMjAgMTI2IGNtDQpRDQpxDQoxIDAgMCAxIDIwIDc4IGNtDQowIDAgMCBy Zw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAgMCAxIDYgMzMgY20NCnENCjAgMCAw IHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3 KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpxDQow IDAgMCByZw0KQlQgMSAwIDAgMSAwIDM4IFRtIC9GMSAxMCBUZiAxMiBUTCAxLjcyNjY0NyBU dyAoRW5hYmxlIGZsZXhpYmxlIGNvbmZpZ3VyYXRpb24gdG8gYmUgYXBwbGllZCB0byBhbGwg aW5pdGlhbCBkb21haW5zIGJ5IGFuIG9wdGlvbmFsKSBUaiBUKiAwIFR3IC40NzgzMTQgVHcg KEJvb3QgRG9tYWluLCB0aGF0IHJ1bnMgd2l0aCBsaW1pdGVkIHByaXZpbGVnZSwgYmVmb3Jl IGFueSBvdGhlciBkb21haW4gc3RhcnRzIGFuZCkgVGogVCogMCBUdyA0LjY4NDk3NiBUdyAo b2J0YWlucyB0aGUgVk0gY29uZmlndXJhdGlvbiBkYXRhIGZyb20gdGhlIGJvb3Rsb2FkZXIg bWF0ZXJpYWxzIHZpYSB0aGUpIFRqIFQqIDAgVHcgKGh5cGVydmlzb3IpIFRqIFQqIEVUDQpR DQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDIwIDcyIGNtDQpRDQpxDQoxIDAgMCAxIDIwIDQ4 IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAgMCAxIDYgOSBj bQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41 IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMg LTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEwIFRmIDEyIFRM IC4wNTE0MTIgVHcgKEVuYWJsZSBtZWFzdXJlbWVudHMgb2YgYWxsIG9mIHRoZSBib290IG1h dGVyaWFscyBwcmlvciB0byB0aGVpciB1c2UsIGluIGEgc2VxdWVuY2UpIFRqIFQqIDAgVHcg KHdpdGggbWluaW1pemVkIHByaXZpbGVnZSkgVGogVCogRVQNClENClENCnENClENClENCnEN CjEgMCAwIDEgMjAgNDIgY20NClENCnENCjEgMCAwIDEgMjAgMzAgY20NCjAgMCAwIHJnDQpC VCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0KcQ0KMCAwIDAgcmcN CkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRq IFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAw IHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKFN1cHBvcnQgdXNlLWNh c2Utc3BlY2lmaWMgY3VzdG9taXplZCBCb290IERvbWFpbnMpIFRqIFQqIEVUDQpRDQpRDQpx DQpRDQpRDQpxDQoxIDAgMCAxIDIwIDI0IGNtDQpRDQpxDQoxIDAgMCAxIDIwIDAgY20NCjAg MCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiA5IGNtDQpxDQow IDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAo XDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0K cQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAxNCBUbSAvRjEgMTAgVGYgMTIgVEwgMS4yNzYy MiBUdyAoQ29tcGxlbWVudCB0aGUgaHlwZXJ2aXNvclwyMjJzIGV4aXN0aW5nIGFiaWxpdHkg dG8gZW5mb3JjZSBwb2xpY3ktYmFzZWQgTWFuZGF0b3J5KSBUaiBUKiAwIFR3IChBY2Nlc3Mg Q29udHJvbCkgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgMjAgMCBjbQ0K UQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAg MSAyMCAwIGNtDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpRDQpxDQpRDQpR DQpxDQoxIDAgMCAxIDYyLjY5MjkxIDE3Ny4wMjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5 MjkxIDc2Ljg2NjE0IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQox IDAgMCAxIDYgODUuMTU3NDggY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAv RjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpR DQpRDQpxDQoxIDAgMCAxIDIzIDg1LjE1NzQ4IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAg MSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChcMjIzU3RhdGljXDIyNCBhbmQgXDIyM0R5bmFt aWNcMjI0IGhhdmUgZGlmZmVyZW50IGFuZCBpbXBvcnRhbnQgbWVhbmluZ3MgaW4gZGlmZmVy ZW50IGNvbW11bml0aWVzKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyA3OS4xNTc0 OCBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAx MiBUTCBFVA0KQlQgMSAwIDAgMSAwIDIgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDgyLjE1 NzQ4IGNtDQpRDQpxDQoxIDAgMCAxIDIwIDgyLjE1NzQ4IGNtDQpRDQpxDQoxIDAgMCAxIDIw IDU4LjE1NzQ4IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAg MCAxIDYgOSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAx MiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEg MCAwIDEgMjMgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEw IFRmIDEyIFRMIC41ODYxMzYgVHcgKFN0YXRpYyBhbmQgRHluYW1pYyBQYXJ0aXRpb25pbmcg ZGVzY3JpYmUgdGhlIGFiaWxpdHkgdG8gY3JlYXRlIG5ldyB2aXJ0dWFsIG1hY2hpbmVzLCBv ciBub3QsKSBUaiBUKiAwIFR3IChhZnRlciB0aGUgaW5pdGlhbCBob3N0IGJvb3QgcHJvY2Vz cyBjb21wbGV0ZXMpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDIwIDUy LjE1NzQ4IGNtDQpRDQpxDQoxIDAgMCAxIDIwIDAgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAg VGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAzNy4xNTc0OCBjbQ0KcQ0KMCAwIDAgcmcNCkJU IDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQq IC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgMTMuMTU3NDggY20NCnENCjAg MCAwIHJnDQpCVCAxIDAgMCAxIDAgMjYgVG0gL0YxIDEwIFRmIDEyIFRMIDEuNDY5OTg0IFR3 IChTdGF0aWMgYW5kIER5bmFtaWMgUm9vdCBvZiBUcnVzdCBkZXNjcmliZSB0aGUgbmF0dXJl IG9mIHRoZSB0cnVzdCBjaGFpbiBmb3IgYSBtZWFzdXJlZCkgVGogVCogMCBUdyAzLjQ2MTIz NSBUdyAobGF1bmNoLiBJbiB0aGlzIGNhc2UgU3RhdGljIGlzIHJlZmVycmluZyB0byB0aGUg ZmFjdCB0aGF0IHRoZSB0cnVzdCBjaGFpbiBpcyBmaXhlZCBhbmQpIFRqIFQqIDAgVHcgMi4y NTQxNDcgVHcgKG5vbi1yZXBlYXRhYmxlIHVudGlsIHRoZSBuZXh0IGhvc3QgcmVib290IG9y IHNodXRkb3duLiBXaGVyZWFzIER5bmFtaWMgaW4gdGhpcyBjYXNlKSBUaiBUKiAwIFR3IEVU DQpRDQpRDQpxDQpRDQpRDQpxDQpRDQpRDQpxDQpRDQpRDQogDQplbmRzdHJlYW0NCmVuZG9i ag0KMTI3IDAgb2JqDQo8PCAvTGVuZ3RoIDk5OTIgPj4NCnN0cmVhbQ0KMSAwIDAgMSAwIDAg Y20gIEJUIC9GMSAxMiBUZiAxNC40IFRMIEVUDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDUwMS4w MjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpCVCAxIDAgMCAxIDYg MjUxIFRtICBUKiBFVA0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAx MCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSAwIDIgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIw IDE4MCBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSA2 IDcxIFRtICBUKiBFVA0KcQ0KMSAwIDAgMSAyMyA1NyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEg MCAwIDEgMCAxNCBUbSAvRjEgMTAgVGYgMTIgVEwgMS40OTQ5ODMgVHcgKHJlZmVycyB0byB0 aGUgYWJpbGl0eSB0byBjb25kdWN0IHRoZSBtZWFzdXJlZCBsYXVuY2ggYXQgYW55IHRpbWUg YW5kIHBvdGVudGlhbGx5IG11bHRpcGxlKSBUaiBUKiAwIFR3ICh0aW1lcyBiZWZvcmUgdGhl IG5leHQgaG9zdCByZWJvb3Qgb3Igc2h1dGRvd24uKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAw IDAgMSAyMyA1MSBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KMCAwIDAgcmcNCkJUIC9G MSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSAwIDIgVG0gIFQqIEVUDQpxDQoxIDAgMCAx IDIwIDQ4IGNtDQpRDQpxDQoxIDAgMCAxIDIwIDQ4IGNtDQpRDQpxDQoxIDAgMCAxIDIwIDAg Y20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAzMyBj bQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41 IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMg LTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMzggVG0gL0YxIDEwIFRmIDEyIFRM IDEuNDI2MTM2IFR3IChXZSB3aWxsIGJlIHVzaW5nIEh5cGVybGF1bmNoIHdpdGggYm90aCBT dGF0aWMgYW5kIER5bmFtaWMgUm9vdHMgb2YgVHJ1c3QsIHRvKSBUaiBUKiAwIFR3IDEuMTgz OTc2IFR3IChsYXVuY2ggYm90aCBTdGF0aWMgYW5kIER5bmFtaWNhbGx5IFBhcnRpdGlvbmVk IFN5c3RlbXMsIGFuZCBiZWluZyBjbGVhciBhYm91dCkgVGogVCogMCBUdyAzLjkwOTA2OSBU dyAoZXhhY3RseSB3aGljaCBjb21iaW5hdGlvbiBpcyBiZWluZyBzdGFydGVkIHdpbGwgYmUg dmVyeSBpbXBvcnRhbnQgXChlZy4gZm9yKSBUaiBUKiAwIFR3IChjZXJ0aWZpY2F0aW9uIHBy b2Nlc3Nlc1wpKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMCAwIGNt DQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpRDQpxDQpRDQpRDQpxDQoxIDAg MCAxIDIwIDE3NCBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMCAwIGNtDQowIDAgMCByZw0KQlQgL0Yx IDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAgMCAxIDYgMTU5IGNtDQpxDQowIDAgMCByZw0KQlQg MSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAoXDE3NykgVGogVCog LTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAxNDcgY20NCnENCjAgMCAwIHJn DQpCVCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEwIFRmIDEyIFRMIC41NDE1MiBUdyAoQ29uc2Vx dWVuY2U6IHVzZXMgb2YgXDIyM1N0YXRpY1wyMjQgYW5kIFwyMjNEeW5hbWljXDIyNCBuZWVk IHRvIGJlIHF1YWxpZmllZCBpZiB0aGV5IGFyZSBpbmNvcnBvcmF0ZWQpIFRqIFQqIDAgVHcg KGludG8gdGhlIG5hbWluZyBvZiB0aGlzIGZ1bmN0aW9uYWxpdHkpIFRqIFQqIEVUDQpRDQpR DQpxDQoxIDAgMCAxIDIzIDE0MSBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KMCAwIDAg cmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSAwIDIgVG0gIFQqIEVUDQpx DQoxIDAgMCAxIDIwIDEzOCBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMCAxMzggY20NClENCnENCjEg MCAwIDEgMjAgMTE0IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQox IDAgMCAxIDYgOSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBU ZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnEN CjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0Yx IDEwIFRmIDEyIFRMIDYuNzM5OTc2IFR3IChUaGlzIGNhbiBiZSBkb25lIGJ5IGFkZGluZyB0 aGUgcHJlY2VkaW5nLCBzdHJvbmdlciBicmFuZGVkIHRlcm06KSBUaiBUKiAwIFR3IChcMjIz SHlwZXJsYXVuY2hcMjI0LCBiZWZvcmUgXDIyM1N0YXRpY1wyMjQgb3IgXDIyM0R5bmFtaWNc MjI0KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMCAxMDggY20NClEN CnENCjEgMCAwIDEgMjAgOTYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQN CnENCjEgMCAwIDEgNiAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9G MSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClEN ClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBU bSAvRjEgMTAgVGYgMTIgVEwgKGllLiBcMjIzSHlwZXJsYXVuY2ggU3RhdGljXDIyNCBkZXNj cmliZXMgbGF1bmNoIG9mIGEgU3RhdGljYWxseSBQYXJ0aXRpb25lZCBzeXN0ZW0pIFRqIFQq IEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDIwIDkwIGNtDQpRDQpxDQoxIDAgMCAx IDIwIDY2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAgMCAx IDYgOSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBU TCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAw IDEgMjMgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEwIFRm IDEyIFRMIDQuMDU2MjIgVHcgKGFuZCBcMjIzSHlwZXJsYXVuY2ggRHluYW1pY1wyMjQgZGVz Y3JpYmVzIGxhdW5jaCBvZiBhIER5bmFtaWNhbGx5IFBhcnRpdGlvbmVkKSBUaiBUKiAwIFR3 IChzeXN0ZW0pIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDIwIDYwIGNt DQpRDQpxDQoxIDAgMCAxIDIwIDAgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwg RVQNCnENCjEgMCAwIDEgNiA0NSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRt IC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQN ClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAg NTAgVG0gL0YxIDEwIFRmIDEyIFRMIDMuMDc1OTc2IFR3IChJbiBwcmFjdGljZSwgdGhpcyBt ZWFucyB0aGF0IFwyMjNIeXBlcmxhdW5jaCBTdGF0aWNcMjI0IGRlc2NyaWJlcyBzdGFydGlu ZyBhIFN0YXRpYykgVGogVCogMCBUdyAuMDUyMTI2IFR3IChQYXJ0aXRpb25lZCBzeXN0ZW0g d2hlcmUgbm8gbmV3IGRvbWFpbnMgY2FuIGJlIHN0YXJ0ZWQgbGF0ZXIgXChpZS4gbm8gVk0g aGFzIHRoZSkgVGogVCogMCBUdyAxLjI4MjQ3IFR3IChDb250cm9sIERvbWFpbiBwZXJtaXNz aW9uXCksIHdoZXJlYXMgXDIyM0h5cGVybGF1bmNoIER5bmFtaWNcMjI0IHdpbGwgbGF1bmNo IHNvbWUpIFRqIFQqIDAgVHcgMS44MjQxNDcgVHcgKFZNIHdpdGggdGhlIENvbnRyb2wgRG9t YWluIHBlcm1pc3Npb24sIGFibGUgdG8gY3JlYXRlIFZNcyBkeW5hbWljYWxseSBhdCBhKSBU aiBUKiAwIFR3IChsYXRlciBwb2ludC4pIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQox IDAgMCAxIDIwIDAgY20NClENCnENClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NClENCnEN ClENClENCnENCjEgMCAwIDEgMjAgMCBjbQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAt MyBjbQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA1MDEuMDIzNiBjbQ0KUQ0K cQ0KMSAwIDAgMSA2Mi42OTI5MSA0ODMuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAw IDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoTmFtaW5nIFByb3Bvc2FsOikgVGogVCogRVQN ClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNDc3LjAyMzYgY20NClENCnENCjEgMCAwIDEg NjIuNjkyOTEgNDc3LjAyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMjQzLjAyMzYg Y20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAyMTkg Y20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgMTAu NSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIz IDIwNyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAxNCBUbSAvRjEgMTAgVGYgMTIg VEwgMS45NDkzNiBUdyAoTmV3IFRlcm06IFwyMjNIeXBlcmxhdW5jaFwyMjQgOiB0aGUgYWJp bGl0eSBvZiBhIGh5cGVydmlzb3IgdG8gY29uc3RydWN0IGFuZCBzdGFydCBvbmUgb3IgbW9y ZSB2aXJ0dWFsKSBUaiBUKiAwIFR3IChtYWNoaW5lcyBhdCBzeXN0ZW0gbGF1bmNoLCBpbiB0 aGUgZm9sbG93aW5nIG1hbm5lcjopIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIzIDIw MSBjbQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAx MiBUTCBFVA0KQlQgMSAwIDAgMSAwIDIgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDE5OCBj bQ0KUQ0KcQ0KMSAwIDAgMSAyMCAxOTggY20NClENCnENCjEgMCAwIDEgMjAgMTA4IGNtDQow IDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAgMCAxIDYgNzUgY20NCnEN CjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRk IChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIzIDc1IGNt DQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChUaGUg aHlwZXJ2aXNvciBtdXN0IGJ1aWxkIGFsbCBvZiB0aGUgZG9tYWlucyB0aGF0IGl0IHN0YXJ0 cyBhdCBob3N0IGJvb3QpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIzIDY5IGNtDQpR DQpxDQoxIDAgMCAxIDIzIC0zIGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVU DQpCVCAxIDAgMCAxIDAgMiBUbSAgVCogRVQNCnENCjEgMCAwIDEgMjAgNjYgY20NClENCnEN CjEgMCAwIDEgMjAgNjYgY20NClENCnENCjEgMCAwIDEgMjAgMzAgY20NCjAgMCAwIHJnDQpC VCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAyMSBjbQ0KcQ0KMCAwIDAgcmcN CkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRq IFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAw IHJnDQpCVCAxIDAgMCAxIDAgMjYgVG0gL0YxIDEwIFRmIDEyIFRMIDEuNTIxNDEyIFR3IChT aW1pbGFyIHRvIHRoZSB3YXkgdGhlIGRvbTAgZG9tYWluIGlzIGJ1aWx0IGJ5IHRoZSBoeXBl cnZpc29yIHRvZGF5LCBhbmQgaG93KSBUaiBUKiAwIFR3IC42ODkyNjkgVHcgKGRvbTBsZXNz IHdvcmtzOiBpdCB3aWxsIHJ1biBhIGxvb3AgdG8gYnVpbGQgdGhlbSBhbGwsIGRyaXZlbiBm cm9tIHRoZSBjb25maWd1cmF0aW9uKSBUaiBUKiAwIFR3IChwcm92aWRlZCkgVGogVCogRVQN ClENClENCnENClENClENCnENCjEgMCAwIDEgMjAgMjQgY20NClENCnENCjEgMCAwIDEgMjAg MCBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAgMSA2IDkg Y20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgMTAu NSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIz IC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAxMiBU TCAuNjUzODI4IFR3IChUaGlzIGlzIGEgcmVxdWlyZW1lbnQgZm9yIGVuc3VyaW5nIHRoYXQg dGhlcmUgaXMgU3Ryb25nIElzb2xhdGlvbiBiZXR3ZWVuIGVhY2ggb2YpIFRqIFQqIDAgVHcg KHRoZSBpbml0aWFsIFZNcykgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEg MjAgMCBjbQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KUQ0KcQ0KUQ0KUQ0K cQ0KMSAwIDAgMSAyMCAxMDIgY20NClENCnENCjEgMCAwIDEgMjAgMCBjbQ0KMCAwIDAgcmcN CkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAgMSA2IDg3IGNtDQpxDQowIDAgMCBy Zw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAoXDE3Nykg VGogVCogLTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyA3NSBjbQ0KcQ0KMCAw IDAgcmcNCkJUIDEgMCAwIDEgMCAxNCBUbSAvRjEgMTAgVGYgMTIgVEwgLjA2OTI2OSBUdyAo QSBzaW5nbGUgZmlsZSBjb250YWlucyB0aGUgVk0gY29uZmlncyBcKFwyMjNMYXVuY2ggQ29u dHJvbCBNb2R1bGVcMjI0OiBMQ00sIGluIERldmljZSBUcmVlIGJpbmFyeSkgVGogVCogMCBU dyAoZm9ybWF0XCkgaXMgcHJvdmlkZWQgdG8gdGhlIGh5cGVydmlzb3IpIFRqIFQqIEVUDQpR DQpRDQpxDQoxIDAgMCAxIDIzIDY5IGNtDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQowIDAg MCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpCVCAxIDAgMCAxIDAgMiBUbSAgVCogRVQN CnENCjEgMCAwIDEgMjAgNjYgY20NClENCnENCjEgMCAwIDEgMjAgNjYgY20NClENCnENCjEg MCAwIDEgMjAgNTQgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEg MCAwIDEgNiAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBU ZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnEN CjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEg MTAgVGYgMTIgVEwgKFRoZSBoeXBlcnZpc29yIHBhcnNlcyBpdCBhbmQgYnVpbGRzIGRvbWFp bnMpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDIwIDQ4IGNtDQpRDQpx DQoxIDAgMCAxIDIwIDAgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnEN CjEgMCAwIDEgNiAzMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAx MCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClEN CnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMzggVG0g L0YxIDEwIFRmIDEyIFRMIC4wNDU2MSBUdyAoSWYgdGhlIExDTSBjb25maWcgc2F5cyB0aGF0 IGEgQm9vdCBEb21haW4gc2hvdWxkIHJ1biBmaXJzdCwgdGhlbiB0aGUgTENNIGZpbGUgaXRz ZWxmKSBUaiBUKiAwIFR3IDIuNjAzOTg0IFR3IChpcyBtYWRlIGF2YWlsYWJsZSB0byB0aGUg Qm9vdCBEb21haW4gZm9yIGl0IHRvIHBhcnNlIGFuZCBhY3Qgb24sIHRvIGludm9rZSkgVGog VCogMCBUdyAxLjIyNzI1MSBUdyAob3BlcmF0aW9ucyB2aWEgdGhlIGh5cGVydmlzb3IgdG8g YXBwbHkgYWRkaXRpb25hbCBjb25maWd1cmF0aW9uIHRvIHRoZSBvdGhlciBWTXMpIFRqIFQq IDAgVHcgKFwoaWUuIGV4ZWN1dGluZyBhIHByaXZpbGVnZS1jb25zdHJhaW5lZCB0b29sc3Rh Y2tcKSkgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgMjAgMCBjbQ0KUQ0K cQ0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSAy MCAwIGNtDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQpRDQpxDQpRDQpRDQpx DQoxIDAgMCAxIDYyLjY5MjkxIDIzNy4wMjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5Mjkx IDIxMy4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAg MCAxIDYgOSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAx MiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEg MCAwIDEgMjMgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEw IFRmIDEyIFRMIC42MDQ1OTcgVHcgKE5ldyBUZXJtOiBcMjIzSHlwZXJsYXVuY2ggU3RhdGlj XDIyNDogc3RhcnRzIGEgU3RhdGljIFBhcnRpdGlvbmVkIHN5c3RlbSwgd2hlcmUgb25seSB0 aGUgdmlydHVhbCBtYWNoaW5lcykgVGogVCogMCBUdyAoc3RhcnRlZCBhdCBzeXN0ZW0gbGF1 bmNoIGFyZSBydW5uaW5nIG9uIHRoZSBzeXN0ZW0pIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpR DQpxDQoxIDAgMCAxIDYyLjY5MjkxIDIwNy4wMjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5 MjkxIDE4My4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQox IDAgMCAxIDYgOSBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBU ZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnEN CjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0Yx IDEwIFRmIDEyIFRMIDEuODYyNDggVHcgKE5ldyBUZXJtOiBcMjIzSHlwZXJsYXVuY2ggRHlu YW1pY1wyMjQ6IHN0YXJ0cyBhIHN5c3RlbSB3aGVyZSB2aXJ0dWFsIG1hY2hpbmVzIG1heSBi ZSBkeW5hbWljYWxseSkgVGogVCogMCBUdyAoYWRkZWQgYWZ0ZXIgdGhlIGluaXRpYWwgdmly dHVhbCBtYWNoaW5lcyBoYXZlIHN0YXJ0ZWQuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0K cQ0KMSAwIDAgMSA2Mi42OTI5MSAxODMuMDIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5 MSAxNDEuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyNiBUbSAvRjEgMTAg VGYgMTIgVEwgLjgxMzExIFR3IChJbiB0aGUgZGVmYXVsdCBjb25maWd1cmF0aW9uLCBYZW4g d2lsbCBiZSBjYXBhYmxlIG9mIGJvdGggc3R5bGVzIG9mIEh5cGVybGF1bmNoIGZyb20gdGhl IHNhbWUgaHlwZXJ2aXNvcikgVGogVCogMCBUdyAzLjQzMjEyNiBUdyAoYmluYXJ5LCB3aGVu IHBhaXJlZCB3aXRoIGl0cyBYU00gZmxhc2ssIHByb3ZpZGVzIHN0cm9uZyBjb250cm9scyB0 aGF0IGVuYWJsZSBmaW5lIGdyYWluZWQgc3lzdGVtKSBUaiBUKiAwIFR3IChwYXJ0aXRpb25p bmcuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAxMzUuMDIzNiBjbQ0K UQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAxMzUuMDIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42 OTI5MSA3Ni44NjYxNCBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0K MSAwIDAgMSA2IDQzLjE1NzQ4IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0g L0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAoXDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0K UQ0KUQ0KcQ0KMSAwIDAgMSAyMyAzMS4xNTc0OCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAw IDEgMCAxNCBUbSAvRjEgMTAgVGYgMTIgVEwgLjU1ODgxIFR3IChSZXRpcmluZyBUZXJtOiBc MjIzRG9tQlwyMjQ6IHdpbGwgbm8gbG9uZ2VyIGJlIHVzZWQgdG8gZGVzY3JpYmUgdGhlIG9w dGlvbmFsIGZpcnN0IGRvbWFpbiB0aGF0IGlzIHN0YXJ0ZWQuIEl0KSBUaiBUKiAwIFR3IChp cyByZXBsYWNlZCB3aXRoIHRoZSBtb3JlIGdlbmVyYWwgdGVybTogXDIyM0Jvb3QgRG9tYWlu XDIyNC4pIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIzIDI1LjE1NzQ4IGNtDQpRDQpx DQoxIDAgMCAxIDIzIDEzLjE1NzQ4IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRM IEVUDQpCVCAxIDAgMCAxIDAgMiBUbSAgVCogRVQNCnENCjEgMCAwIDEgMjAgMCBjbQ0KUQ0K cQ0KMSAwIDAgMSAyMCAwIGNtDQpRDQpxDQpRDQpRDQpxDQpRDQpRDQogDQplbmRzdHJlYW0N CmVuZG9iag0KMTI4IDAgb2JqDQo8PCAvTGVuZ3RoIDgwMzUgPj4NCnN0cmVhbQ0KMSAwIDAg MSAwIDAgY20gIEJUIC9GMSAxMiBUZiAxNC40IFRMIEVUDQpxDQoxIDAgMCAxIDYyLjY5Mjkx IDc0MS4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpCVCAxIDAg MCAxIDYgMTEgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIzIC0zIGNtDQowIDAgMCByZw0KQlQg L0YxIDEwIFRmIDEyIFRMIEVUDQpCVCAxIDAgMCAxIDAgMiBUbSAgVCogRVQNCnENCjEgMCAw IDEgMjAgMCBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAg MSA2IDkgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIg VEwgMTAuNSAwIFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAg MCAxIDIzIC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBU ZiAxMiBUTCAuODI0OTg3IFR3IChcMjIzRG9tQlwyMjQgd2lsbCBzdGlsbCBiZSB1c2VkIGlu IHRoZSBtZWFudGltZSB0byByZWZlciB0byB0aGUgcHJvamVjdCB0aGF0IGlzIHVuZGVyIHdh eSB0byBidWlsZCkgVGogVCogMCBUdyAodGhlIG5ldyBib290IHByb2Nlc3MsIGJ1dCB3aWxs IG5vdCBiZSB1c2VkIHRvIG5hbWUgYSB0aGluZyB3aXRoaW4gWGVuLikgVGogVCogRVQNClEN ClENCnENClENClENCnENCjEgMCAwIDEgMjAgMCBjbQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAg MSAyMyAtMyBjbQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA3MzUuMDIzNiBj bQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA3MjMuMDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9G MSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAgMSA2IC0zIGNtDQpxDQowIDAgMCByZw0KQlQg MSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAoXDE3NykgVGogVCog LTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KcQ0KMCAwIDAgcmcN CkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoUmV0aXJpbmcgVGVybTogXDIy M0RvbTBsZXNzXDIyNDogaXQgaXMgdG8gYmUgcmVwbGFjZWQgd2l0aCBcMjIzSHlwZXJsYXVu Y2ggU3RhdGljXDIyNCkgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIu NjkyOTEgNzIzLjAyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNjkzLjAyMzYgY20N CnENCkJUIDEgMCAwIDEgMCAzIFRtIDE4IFRMIC9GMiAxNSBUZiAwIDAgMCByZyAoNC4zICAg QXBwZW5kaXggMzogVGVybWlub2xvZ3kpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYy LjY5MjkxIDY2My4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9G MSAxMCBUZiAxMiBUTCAuODQ4NzM1IFR3IChUbyBoZWxwIGVuc3VyZSBjbGFyaXR5IGluIHJl YWRpbmcgdGhpcyBkb2N1bWVudCwgdGhlIGZvbGxvd2luZyBpcyB0aGUgZGVmaW5pdGlvbiBv ZiB0ZXJtaW5vbG9neSB1c2VkIHdpdGhpbikgVGogVCogMCBUdyAodGhpcyBkb2N1bWVudC4p IFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDY0Ny4wMjM2IGNtDQpxDQow IDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YyIDEwIFRmIDEyIFRMIChEb21haW4pIFRq IFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDYzMi4wMjM2IGNtDQowIDAgMCBy Zw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpCVCAxIDAgMCAxIDAgMiBUbSAgVCogRVQNCnEN CjEgMCAwIDEgMjAgMCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAx MCBUZiAxMiBUTCAoYSBydW5uaW5nIGluc3RhbmNlIG9mIGEgdmlydHVhbCBtYWNoaW5lOyBc KGFzIHRoZSB0ZXJtIGlzIGNvbW1vbmx5IHVzZWQgaW4gdGhlIFhlbiBDb21tdW5pdHlcKSkg VGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNjE2LjAyMzYg Y20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIgVEwgKERv bTApIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDYwMS4wMjM2IGNtDQow IDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpCVCAxIDAgMCAxIDAgMiBUbSAgVCog RVQNCnENCjEgMCAwIDEgMjAgMCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRt IC9GMSAxMCBUZiAxMiBUTCAodGhlIGhpZ2hseS1wcml2aWxlZ2VkLCBmaXJzdCBhbmQgb25s eSBkb21haW4gc3RhcnRlZCBhdCBob3N0IGJvb3Qgb24gYSBjb252ZW50aW9uYWwgWGVuIHN5 c3RlbSkgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNTg1 LjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIg VEwgKE11bHRpcGxlIERvbWFpbiBCb290KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2 Mi42OTI5MSA1NTguMDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0K QlQgMSAwIDAgMSAwIDE0IFRtICBUKiBFVA0KcQ0KMSAwIDAgMSAyMCAwIGNtDQpxDQowIDAg MCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAxMiBUTCAuNDE1Njk3IFR3IChh IHN5c3RlbSBjb25maWd1cmF0aW9uIHdoZXJlIHRoZSBoeXBlcnZpc29yIGFuZCBtdWx0aXBs ZSB2aXJ0dWFsIG1hY2hpbmVzIGFyZSBhbGwgbGF1bmNoZWQgd2hlbiB0aGUpIFRqIFQqIDAg VHcgKGhvc3Qgc3lzdGVtIGhhcmR3YXJlIGJvb3RzKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0K UQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA1NDIuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEg MCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoRG9tMGxlc3MpIFRqIFQqIEVUDQpRDQpR DQpxDQoxIDAgMCAxIDYyLjY5MjkxIDUyNy4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEw IFRmIDEyIFRMIEVUDQpCVCAxIDAgMCAxIDAgMiBUbSAgVCogRVQNCnENCjEgMCAwIDEgMjAg MCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAo YW4gZXhpc3RpbmcgZmVhdHVyZSBvZiBYZW4gb24gQXJtIHRoYXQgcHJvdmlkZXMgTXVsdGlw bGUgRG9tYWluIEJvb3QpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYy LjY5MjkxIDUxMS4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0Yy IDEwIFRmIDEyIFRMIChEb21CKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5 MSA0OTYuMDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAw IDAgMSAwIDIgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDAgY20NCnENCjAgMCAwIHJnDQpC VCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKHRoZSBkZXZlbG9wbWVudCBwcm9q ZWN0IHRvIGJ1aWxkIGh5cGVybGF1bmNoIE11bHRpcGxlIERvbWFpbiBCb290IGZvciBYZW4p IFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDQ4MC4wMjM2 IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YyIDEwIFRmIDEyIFRMIChD b250cm9sIERvbWFpbikgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNDQx LjAyMzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCkJUIDEgMCAwIDEg MCAyNiBUbSAgVCogRVQNCnENCjEgMCAwIDEgMjAgMCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEg MCAwIDEgMCAyNiBUbSAvRjEgMTAgVGYgMTIgVEwgMS44MDQyNjkgVHcgKGEgcHJpdmlsZWdl ZCBkb21haW4gdGhhdCBoYXMgYmVlbiBncmFudGVkIENvbnRyb2wgRG9tYWluIHBlcm1pc3Np b25zIHdoaWNoIGFyZSB0aG9zZSB0aGF0IGFyZSkgVGogVCogMCBUdyAuNDk3MzE4IFR3IChy ZXF1aXJlZCBieSB0aGUgWGVuIHRvb2xzdGFjayBmb3IgbWFuYWdpbmcgb3RoZXIgZG9tYWlu cy4gVGhlc2UgcGVybWlzc2lvbnMgYXJlIGEgc3Vic2V0IG9mIHRob3NlKSBUaiBUKiAwIFR3 ICh0aGF0IGFyZSBncmFudGVkIHRvIERvbTAuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0K cQ0KMSAwIDAgMSA2Mi42OTI5MSA0MjUuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAw IDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoSGFyZHdhcmUgRG9tYWluKSBUaiBUKiBFVA0K UQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAzOTguMDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9G MSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSAwIDE0IFRtICBUKiBFVA0KcQ0KMSAwIDAg MSAyMCAwIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAx MiBUTCAuMjk0MjY5IFR3IChhIHByaXZpbGVnZWQgZG9tYWluIHRoYXQgaGFzIGJlZW4gZ3Jh bnRlZCBwZXJtaXNzaW9ucyB0byBhY2Nlc3MgYW5kIG1hbmFnZSBob3N0IGhhcmR3YXJlLiBU aGVzZSkgVGogVCogMCBUdyAocGVybWlzc2lvbnMgYXJlIGEgc3Vic2V0IG9mIHRob3NlIHRo YXQgYXJlIGdyYW50ZWQgdG8gRG9tMC4pIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQox IDAgMCAxIDYyLjY5MjkxIDM4Mi4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAw IDIgVG0gL0YyIDEwIFRmIDEyIFRMIChMYXRlIEhhcmR3YXJlIERvbWFpbikgVGogVCogRVQN ClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMzQzLjAyMzYgY20NCjAgMCAwIHJnDQpCVCAv RjEgMTAgVGYgMTIgVEwgRVQNCkJUIDEgMCAwIDEgMCAyNiBUbSAgVCogRVQNCnENCjEgMCAw IDEgMjAgMCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyNiBUbSAvRjEgMTAgVGYg MTIgVEwgMS4zODczMTggVHcgKGEgSGFyZHdhcmUgRG9tYWluIHRoYXQgaXMgbGF1bmNoZWQg YWZ0ZXIgaG9zdCBib290IGhhcyBhbHJlYWR5IGNvbXBsZXRlZCB3aXRoIGEgcnVubmluZyBE b20wLikgVGogVCogMCBUdyAxLjkwMjI5IFR3IChXaGVuIHRoZSBMYXRlIEhhcmR3YXJlIERv bWFpbiBpcyBzdGFydGVkLCBEb20wIHJlbGlucXVpc2hlcyBhbmQgdHJhbnNmZXJzIHRoZSBw ZXJtaXNzaW9ucyB0bykgVGogVCogMCBUdyAoYWNjZXNzIGFuZCBtYW5hZ2UgaG9zdCBoYXJk d2FyZSB0byBpdC4uKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42 OTI5MSAzMjcuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMiAx MCBUZiAxMiBUTCAoRGlzYWdncmVnYXRpb24pIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAx IDYyLjY5MjkxIDMwMC4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVU DQpCVCAxIDAgMCAxIDAgMTQgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDAgY20NCnENCjAg MCAwIHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEwIFRmIDEyIFRMIC44MDkxNDcgVHcg KHRoZSBzZXBhcmF0aW9uIG9mIHN5c3RlbSByb2xlcyBhbmQgcmVzcG9uc2liaWxpdGllcyBh Y3Jvc3MgbXVsdGlwbGUgY29ubmVjdGVkIGNvbXBvbmVudHMgdGhhdCB3b3JrKSBUaiBUKiAw IFR3ICh0b2dldGhlciB0byBwcm92aWRlIGZ1bmN0aW9uYWxpdHkpIFRqIFQqIEVUDQpRDQpR DQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDI4NC4wMjM2IGNtDQpxDQowIDAgMCBy Zw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YyIDEwIFRmIDEyIFRMIChCb290IERvbWFpbikgVGog VCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMjQ1LjAyMzYgY20NCjAgMCAwIHJn DQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCkJUIDEgMCAwIDEgMCAyNiBUbSAgVCogRVQNCnEN CjEgMCAwIDEgMjAgMCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyNiBUbSAvRjEg MTAgVGYgMTIgVEwgLjcyMTk4NCBUdyAoYSBkb21haW4gd2l0aCBsaW1pdGVkIHByaXZpbGVn ZXMgbGF1bmNoZWQgYnkgdGhlIGh5cGVydmlzb3IgZHVyaW5nIGEgTXVsdGlwbGUgRG9tYWlu IEJvb3QgdGhhdCBydW5zKSBUaiBUKiAwIFR3IC42ODM5ODQgVHcgKGFzIHRoZSBmaXJzdCBk b21haW4gc3RhcnRlZC4gSW4gdGhlIGh5cGVybGF1bmNoIGFyY2hpdGVjdHVyZSwgaXQgaXMg cmVzcG9uc2libGUgZm9yIGFzc2lzdGluZyB3aXRoIGhpZ2hlcikgVGogVCogMCBUdyAobGV2 ZWwgb3BlcmF0aW9ucyBvZiB0aGUgZG9tYWluIHNldHVwIHByb2Nlc3MuKSBUaiBUKiBFVA0K UQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAyMjkuMDIzNiBjbQ0KcQ0KMCAw IDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoTGF1bmNoIENvbnRy b2wgTW9kdWxlIFwoTENNXCkpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5Mjkx IDIwMi4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpCVCAxIDAg MCAxIDAgMTQgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDAgY20NCnENCjAgMCAwIHJnDQpC VCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEwIFRmIDEyIFRMIC42MDczMTggVHcgKEEgZmlsZSBz dXBwbGllZCB0byB0aGUgaHlwZXJ2aXNvciBieSB0aGUgYm9vdGxvYWRlciB0aGF0IGNvbnRh aW5zIGNvbmZpZ3VyYXRpb24gZGF0YSBmb3IgdGhlIGh5cGVydmlzb3IpIFRqIFQqIDAgVHcg KGFuZCB0aGUgaW5pdGlhbCBzZXQgb2YgdmlydHVhbCBtYWNoaW5lcyB0byBiZSBydW4gYXQg Ym9vdCkgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMTg2 LjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIg VEwgKERldmljZSBUcmVlKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAx NzEuMDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAg MSAwIDIgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDAgY20NCnENCjAgMCAwIHJnDQpCVCAx IDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKGEgc3RhbmRhcmRpemVkIGRhdGEgc3Ry dWN0dXJlLCB3aXRoIGRlZmluZWQgZmlsZSBmb3JtYXRzLCBmb3IgZGVzY3JpYmluZyBpbml0 aWFsIHN5c3RlbSBjb25maWd1cmF0aW9uKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0K MSAwIDAgMSA2Mi42OTI5MSAxNTUuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEg MCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoU3lzdGVtIERldmljZSBUcmVlKSBUaiBUKiBFVA0K UQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAxMjguMDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9G MSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSAwIDE0IFRtICBUKiBFVA0KcQ0KMSAwIDAg MSAyMCAwIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAx MiBUTCAxLjc0ODIyMSBUdyAodGhpcyBpcyB0aGUgcHJvZHVjdCBvZiBhIGNvbW11bml0eSBw cm9qZWN0IHRvIGV4dGVuZCBEZXZpY2UgVHJlZSB0byBjb3ZlciBtb3JlIGFzcGVjdHMgb2Yg aW5pdGlhbCkgVGogVCogMCBUdyAoc3lzdGVtIGNvbmZpZ3VyYXRpb24pIFRqIFQqIEVUDQpR DQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDExMi4wMjM2IGNtDQpxDQowIDAg MCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YyIDEwIFRmIDEyIFRMIChCYXNpYyBDb25maWd1 cmF0aW9uKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA5Ny4wMjM2MiBj bQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSAwIDIgVG0g IFQqIEVUDQpxDQoxIDAgMCAxIDIwIDAgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAg MiBUbSAvRjEgMTAgVGYgMTIgVEwgKHRoZSBtaW5pbWFsIGluZm9ybWF0aW9uIHRoZSBoeXBl cnZpc29yIHJlcXVpcmVzIHRvIGluc3RhbnRpYXRlIGEgZG9tYWluIGluc3RhbmNlKSBUaiBU KiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA4MS4wMjM2MiBjbQ0K cQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoRXh0ZW5k ZWQgQ29uZmlndXJhdGlvbikgVGogVCogRVQNClENClENCiANCmVuZHN0cmVhbQ0KZW5kb2Jq DQoxMjkgMCBvYmoNCjw8IC9MZW5ndGggNDE1NiA+Pg0Kc3RyZWFtDQoxIDAgMCAxIDAgMCBj bSAgQlQgL0YxIDEyIFRmIDE0LjQgVEwgRVQNCnENCjEgMCAwIDEgNjIuNjkyOTEgNzUwLjAy MzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCkJUIDEgMCAwIDEgMCAy IFRtICBUKiBFVA0KcQ0KMSAwIDAgMSAyMCAwIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAg MSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChhbnkgY29uZmlndXJhdGlvbiBvcHRpb25zIGZv ciBhIGRvbWFpbiBiZXlvbmQgaXRzIEJhc2ljIENvbmZpZ3VyYXRpb24pIFRqIFQqIEVUDQpR DQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDczNC4wMjM2IGNtDQpxDQowIDAg MCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YyIDEwIFRmIDEyIFRMIChIb3N0IEJvb3QpIFRq IFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDcxOS4wMjM2IGNtDQowIDAgMCBy Zw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpCVCAxIDAgMCAxIDAgMiBUbSAgVCogRVQNCnEN CjEgMCAwIDEgMjAgMCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAx MCBUZiAxMiBUTCAodGhlIHN5c3RlbSBzdGFydHVwIG9mIFhlbiB1c2luZyB0aGUgY29uZmln dXJhdGlvbiBwcm92aWRlZCBieSB0aGUgYm9vdGxvYWRlcikgVGogVCogRVQNClENClENCnEN ClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNzAzLjAyMzYgY20NCnENCjAgMCAwIHJnDQpC VCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIgVEwgKENsYXNzaWMgTGF1bmNoKSBUaiBU KiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA2ODguMDIzNiBjbQ0KMCAwIDAgcmcN CkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSAwIDIgVG0gIFQqIEVUDQpxDQox IDAgMCAxIDIwIDAgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAg VGYgMTIgVEwgKGEgYmFja3dhcmRzLWNvbXBhdGlibGUgaG9zdCBib290IHRoYXQgZW5kcyB3 aXRoIHRoZSBsYXVuY2ggb2YgYSBzaW5nbGUgZG9tYWluIFwoRG9tMFwpKSBUaiBUKiBFVA0K UQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA2NzIuMDIzNiBjbQ0KcQ0KMCAw IDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoaHlwZXJsYXVuY2gp IFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDY1Ny4wMjM2IGNtDQowIDAg MCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpCVCAxIDAgMCAxIDAgMiBUbSAgVCogRVQN CnENCjEgMCAwIDEgMjAgMCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9G MSAxMCBUZiAxMiBUTCAoYSBmbGV4aWJsZSBob3N0IGJvb3QgdGhhdCBlbmRzIHdpdGggdGhl IGxhdW5jaCBvZiBvbmUgb3IgbW9yZSBkb21haW5zKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0K UQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA2NDEuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEg MCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoQ3Jhc2ggRG9tYWluKSBUaiBUKiBFVA0K UQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA2MTQuMDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9G MSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSAwIDE0IFRtICBUKiBFVA0KcQ0KMSAwIDAg MSAyMCAwIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAx MiBUTCAuMTExNzUxIFR3IChhIGZhbGxiYWNrIGRvbWFpbiB0aGF0IHRoZSBoeXBlcnZpc29y IG1heSBsYXVuY2ggaW4gdGhlIGV2ZW50IG9mIGEgZGV0ZWN0YWJsZSBlcnJvciBkdXJpbmcg dGhlIG11bHRpcGxlKSBUaiBUKiAwIFR3IChkb21haW4gYm9vdCBwcm9jZXNzKSBUaiBUKiBF VA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA1OTguMDIzNiBjbQ0KcQ0K MCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoQ29uc29sZSBE b21haW4pIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDU4My4wMjM2IGNt DQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpCVCAxIDAgMCAxIDAgMiBUbSAg VCogRVQNCnENCjEgMCAwIDEgMjAgMCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAy IFRtIC9GMSAxMCBUZiAxMiBUTCAoYSBkb21haW4gdGhhdCBoYXMgdGhlIFhlbiBjb25zb2xl IGFzc2lnbmVkIHRvIGl0KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2 Mi42OTI5MSA1NjcuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9G MiAxMCBUZiAxMiBUTCAoTGF1bmNoZWQgRG9tYWluKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAw IDAgMSA2Mi42OTI5MSA1NDAuMDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBU TCBFVA0KQlQgMSAwIDAgMSAwIDE0IFRtICBUKiBFVA0KcQ0KMSAwIDAgMSAyMCAwIGNtDQpx DQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAxMiBUTCAuNDc2MDk4 IFR3IChhIGRvbWFpbiwgYXNpZGUgZnJvbSB0aGUgYm9vdCBkb21haW4gYW5kIGNyYXNoIGRv bWFpbiwgdGhhdCBpcyBzdGFydGVkIGFzIHBhcnQgb2YgYSBtdWx0aXBsZSBkb21haW4pIFRq IFQqIDAgVHcgKGJvb3QgYW5kIHJlbWFpbnMgcnVubmluZyBvbmNlIHRoZSBib290IHByb2Nl c3MgaXMgY29tcGxldGUpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYy LjY5MjkxIDUyNC4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0Yy IDEwIFRmIDEyIFRMIChJbml0aWFsIERvbWFpbikgVGogVCogRVQNClENClENCnENCjEgMCAw IDEgNjIuNjkyOTEgNDk3LjAyMzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwg RVQNCkJUIDEgMCAwIDEgMCAxNCBUbSAgVCogRVQNCnENCjEgMCAwIDEgMjAgMCBjbQ0KcQ0K MCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAxNCBUbSAvRjEgMTAgVGYgMTIgVEwgLjM0NTQ4OCBU dyAoYSBkb21haW4gdGhhdCBpcyBkZXNjcmliZWQgaW4gdGhlIExDTSB0aGF0IGlzIHJ1biBh cyBwYXJ0IG9mIGEgbXVsdGlwbGUgZG9tYWluIGJvb3QuIFRoaXMgaW5jbHVkZXMgdGhlKSBU aiBUKiAwIFR3IChCb290IERvbWFpbiwgQ3Jhc2ggRG9tYWluIGFuZCBhbGwgTGF1bmNoZWQg RG9tYWlucy4pIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5Mjkx IDQ2Ny4wMjM2IGNtDQpxDQpCVCAxIDAgMCAxIDAgMyBUbSAxOCBUTCAvRjIgMTUgVGYgMCAw IDAgcmcgKDQuNCAgIEFwcGVuZGl4IDQ6IENvcHlyaWdodCBMaWNlbnNlKSBUaiBUKiBFVA0K UQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA0MjUuMDIzNiBjbQ0KcQ0KQlQgMSAwIDAgMSAw IDI2IFRtIDEuODMyNjUxIFR3IDEyIFRMIC9GMSAxMCBUZiAwIDAgMCByZyAoVGhpcyB3b3Jr IGlzIGxpY2Vuc2VkIHVuZGVyIGEgQ3JlYXRpdmUgQ29tbW9ucyBBdHRyaWJ1dGlvbiA0LjAg SW50ZXJuYXRpb25hbCBMaWNlbnNlLiBBIGNvcHkgb2YgdGhpcykgVGogVCogMCBUdyAyNC42 OTYyMiBUdyAobGljZW5zZSBtYXkgYmUgb2J0YWluZWQgZnJvbSB0aGUgQ3JlYXRpdmUgQ29t bW9ucyB3ZWJzaXRlKSBUaiBUKiAwIFR3IChcKCkgVGogMCAwIC41MDE5NjEgcmcgKGh0dHBz Oi8vY3JlYXRpdmVjb21tb25zLm9yZy9saWNlbnNlcy9ieS80LjAvbGVnYWxjb2RlKSBUaiAw IDAgMCByZyAoXCkuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA0MDcu MDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBU TCAoQ29udHJpYnV0aW9ucyBieTopIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5 MjkxIDM4OS4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEw IFRmIDEyIFRMIChDaHJpc3RvcGhlciBDbGFyayBhcmUgQ29weXJpZ2h0IFwyNTEgMjAyMSBT dGFyIExhYiBDb3Jwb3JhdGlvbikgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjky OTEgMzcxLjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAg VGYgMTIgVEwgKERhbmllbCBQLiBTbWl0aCBhcmUgQ29weXJpZ2h0IFwyNTEgMjAyMSBBcGVy dHVzIFNvbHV0aW9ucywgTExDKSBUaiBUKiBFVA0KUQ0KUQ0KIA0KZW5kc3RyZWFtDQplbmRv YmoNCjEzMCAwIG9iag0KPDwgL051bXMgWyAwIDEzMSAwIFIgMSAxMzIgMCBSIDIgMTMzIDAg UiAzIDEzNCAwIFIgNCAxMzUgMCBSIA0KICA1IDEzNiAwIFIgNiAxMzcgMCBSIDcgMTM4IDAg UiA4IDEzOSAwIFIgOSAxNDAgMCBSIA0KICAxMCAxNDEgMCBSIDExIDE0MiAwIFIgMTIgMTQz IDAgUiAxMyAxNDQgMCBSIF0gPj4NCmVuZG9iag0KMTMxIDAgb2JqDQo8PCAvUyAvRCAvU3Qg MSA+Pg0KZW5kb2JqDQoxMzIgMCBvYmoNCjw8IC9TIC9EIC9TdCAyID4+DQplbmRvYmoNCjEz MyAwIG9iag0KPDwgL1MgL0QgL1N0IDMgPj4NCmVuZG9iag0KMTM0IDAgb2JqDQo8PCAvUyAv RCAvU3QgNCA+Pg0KZW5kb2JqDQoxMzUgMCBvYmoNCjw8IC9TIC9EIC9TdCA1ID4+DQplbmRv YmoNCjEzNiAwIG9iag0KPDwgL1MgL0QgL1N0IDYgPj4NCmVuZG9iag0KMTM3IDAgb2JqDQo8 PCAvUyAvRCAvU3QgNyA+Pg0KZW5kb2JqDQoxMzggMCBvYmoNCjw8IC9TIC9EIC9TdCA4ID4+ DQplbmRvYmoNCjEzOSAwIG9iag0KPDwgL1MgL0QgL1N0IDkgPj4NCmVuZG9iag0KMTQwIDAg b2JqDQo8PCAvUyAvRCAvU3QgMTAgPj4NCmVuZG9iag0KMTQxIDAgb2JqDQo8PCAvUyAvRCAv U3QgMTEgPj4NCmVuZG9iag0KMTQyIDAgb2JqDQo8PCAvUyAvRCAvU3QgMTIgPj4NCmVuZG9i ag0KMTQzIDAgb2JqDQo8PCAvUyAvRCAvU3QgMTMgPj4NCmVuZG9iag0KMTQ0IDAgb2JqDQo8 PCAvUyAvRCAvU3QgMTQgPj4NCmVuZG9iag0KeHJlZg0KMCAxNDUNCjAwMDAwMDAwMDAgNjU1 MzUgZg0KMDAwMDAwMDA3NSAwMDAwMCBuDQowMDAwMDAwMTUyIDAwMDAwIG4NCjAwMDAwMDAy NjIgMDAwMDAgbg0KMDAwMDAwMDM3NyAwMDAwMCBuDQowMDAwMDAwNTQ4IDAwMDAwIG4NCjAw MDAwMDA3MTkgMDAwMDAgbg0KMDAwMDAwMDg5MCAwMDAwMCBuDQowMDAwMDAxMDYxIDAwMDAw IG4NCjAwMDAwMDEyMzIgMDAwMDAgbg0KMDAwMDAwMTQwMyAwMDAwMCBuDQowMDAwMDAxNTc1 IDAwMDAwIG4NCjAwMDAwMDE3NDcgMDAwMDAgbg0KMDAwMDAwMTkxOSAwMDAwMCBuDQowMDAw MDAyMDkxIDAwMDAwIG4NCjAwMDAwMDIyNjMgMDAwMDAgbg0KMDAwMDAwMjQzNSAwMDAwMCBu DQowMDAwMDAyNjA3IDAwMDAwIG4NCjAwMDAwMDI3NzkgMDAwMDAgbg0KMDAwMDAwMjk1MSAw MDAwMCBuDQowMDAwMDAzMTIzIDAwMDAwIG4NCjAwMDAwMDMyOTUgMDAwMDAgbg0KMDAwMDAw MzQ2NyAwMDAwMCBuDQowMDAwMDAzNjM5IDAwMDAwIG4NCjAwMDAwMDM4MTEgMDAwMDAgbg0K MDAwMDAwMzk4MyAwMDAwMCBuDQowMDAwMDA0MTU1IDAwMDAwIG4NCjAwMDAwMDQzMjcgMDAw MDAgbg0KMDAwMDAwNDQ5OSAwMDAwMCBuDQowMDAwMDA0NjcxIDAwMDAwIG4NCjAwMDAwMDQ4 NDMgMDAwMDAgbg0KMDAwMDAwNTAxNSAwMDAwMCBuDQowMDAwMDA1MTg3IDAwMDAwIG4NCjAw MDAwMDUzNTkgMDAwMDAgbg0KMDAwMDAwNTUzMSAwMDAwMCBuDQowMDAwMDA1NzAzIDAwMDAw IG4NCjAwMDAwMDU4NzUgMDAwMDAgbg0KMDAwMDAwNjA0NyAwMDAwMCBuDQowMDAwMDA2MjE5 IDAwMDAwIG4NCjAwMDAwMDYzOTEgMDAwMDAgbg0KMDAwMDAwNjU2MyAwMDAwMCBuDQowMDAw MDA2NzM1IDAwMDAwIG4NCjAwMDAwMDY5MDcgMDAwMDAgbg0KMDAwMDAwNzA3OSAwMDAwMCBu DQowMDAwMDA3MjUxIDAwMDAwIG4NCjAwMDAwMDc0MjMgMDAwMDAgbg0KMDAwMDAwNzU5NSAw MDAwMCBuDQowMDAwMDA3NzY3IDAwMDAwIG4NCjAwMDAwMDc5MzkgMDAwMDAgbg0KMDAwMDAw ODExMSAwMDAwMCBuDQowMDAwMDA4MjgzIDAwMDAwIG4NCjAwMDAwMDg0NTUgMDAwMDAgbg0K MDAwMDAwODYyNyAwMDAwMCBuDQowMDAwMDA4Nzk5IDAwMDAwIG4NCjAwMDAwMDg5NzEgMDAw MDAgbg0KMDAwMDAwOTE0MyAwMDAwMCBuDQowMDAwMDA5MzE1IDAwMDAwIG4NCjAwMDAwMDk0 ODcgMDAwMDAgbg0KMDAwMDAwOTY1OSAwMDAwMCBuDQowMDAwMDA5ODMxIDAwMDAwIG4NCjAw MDAwMTAwMDMgMDAwMDAgbg0KMDAwMDAxMDYzMyAwMDAwMCBuDQowMDAwMDEwODQ1IDAwMDAw IG4NCjAwMDAwMTEwNTcgMDAwMDAgbg0KMDAwMDAxMTE4MCAwMDAwMCBuDQowMDAwMDExMzky IDAwMDAwIG4NCjAwMDAwMTE2MDQgMDAwMDAgbg0KMDAwMDAxMTcxMyAwMDAwMCBuDQowMDAw MDExODMyIDAwMDAwIG4NCjAwMDAwMTIwNDQgMDAwMDAgbg0KMDAwMDAxMjI1NiAwMDAwMCBu DQowMDAwMDEyNDY4IDAwMDAwIG4NCjAwMDAwMTI2ODAgMDAwMDAgbg0KMDAwMDAxMjg5MiAw MDAwMCBuDQowMDAwMDEzMTA0IDAwMDAwIG4NCjAwMDAwMTMzMTYgMDAwMDAgbg0KMDAwMDAx MzUyOCAwMDAwMCBuDQowMDAwMDEzNzM3IDAwMDAwIG4NCjAwMDAwMTM5NjggMDAwMDAgbg0K MDAwMDAxNDA3OSAwMDAwMCBuDQowMDAwMDE0MzY4IDAwMDAwIG4NCjAwMDAwMTQ0NDcgMDAw MDAgbg0KMDAwMDAxNDY0OSAwMDAwMCBuDQowMDAwMDE0ODg0IDAwMDAwIG4NCjAwMDAwMTUw NzMgMDAwMDAgbg0KMDAwMDAxNTM4NiAwMDAwMCBuDQowMDAwMDE1NTgzIDAwMDAwIG4NCjAw MDAwMTU4NDMgMDAwMDAgbg0KMDAwMDAxNjE3OCAwMDAwMCBuDQowMDAwMDE2NTgwIDAwMDAw IG4NCjAwMDAwMTcwOTUgMDAwMDAgbg0KMDAwMDAxNzUzNSAwMDAwMCBuDQowMDAwMDE3OTE3 IDAwMDAwIG4NCjAwMDAwMTgyNTQgMDAwMDAgbg0KMDAwMDAxODcyOSAwMDAwMCBuDQowMDAw MDE5MDM2IDAwMDAwIG4NCjAwMDAwMTkzNjEgMDAwMDAgbg0KMDAwMDAxOTcwNyAwMDAwMCBu DQowMDAwMDIwMDA4IDAwMDAwIG4NCjAwMDAwMjAyNTUgMDAwMDAgbg0KMDAwMDAyMDU2MSAw MDAwMCBuDQowMDAwMDIwODI5IDAwMDAwIG4NCjAwMDAwMjExNTQgMDAwMDAgbg0KMDAwMDAy MTM4OSAwMDAwMCBuDQowMDAwMDIxNjQzIDAwMDAwIG4NCjAwMDAwMjE4OTIgMDAwMDAgbg0K MDAwMDAyMjEyNiAwMDAwMCBuDQowMDAwMDIyMzY1IDAwMDAwIG4NCjAwMDAwMjI2MTQgMDAw MDAgbg0KMDAwMDAyMjg2OCAwMDAwMCBuDQowMDAwMDIzMTAzIDAwMDAwIG4NCjAwMDAwMjMz MjggMDAwMDAgbg0KMDAwMDAyMzc2MyAwMDAwMCBuDQowMDAwMDI0MjMyIDAwMDAwIG4NCjAw MDAwMjQ1MTYgMDAwMDAgbg0KMDAwMDAyNDgxNiAwMDAwMCBuDQowMDAwMDI0OTc3IDAwMDAw IG4NCjAwMDAwMzM4NTMgMDAwMDAgbg0KMDAwMDA0MjAyOCAwMDAwMCBuDQowMDAwMDU1NDgx IDAwMDAwIG4NCjAwMDAwNjE4NTkgMDAwMDAgbg0KMDAwMDA2ODA2NyAwMDAwMCBuDQowMDAw MDgwNzc2IDAwMDAwIG4NCjAwMDAwODg5OTMgMDAwMDAgbg0KMDAwMDA5NjIyMCAwMDAwMCBu DQowMDAwMTAxODA1IDAwMDAwIG4NCjAwMDAxMDUyMDIgMDAwMDAgbg0KMDAwMDExNjUzNSAw MDAwMCBuDQowMDAwMTI2NTg1IDAwMDAwIG4NCjAwMDAxMzQ2NzggMDAwMDAgbg0KMDAwMDEz ODg5MiAwMDAwMCBuDQowMDAwMTM5MDgwIDAwMDAwIG4NCjAwMDAxMzkxMTggMDAwMDAgbg0K MDAwMDEzOTE1NiAwMDAwMCBuDQowMDAwMTM5MTk0IDAwMDAwIG4NCjAwMDAxMzkyMzIgMDAw MDAgbg0KMDAwMDEzOTI3MCAwMDAwMCBuDQowMDAwMTM5MzA4IDAwMDAwIG4NCjAwMDAxMzkz NDYgMDAwMDAgbg0KMDAwMDEzOTM4NCAwMDAwMCBuDQowMDAwMTM5NDIyIDAwMDAwIG4NCjAw MDAxMzk0NjEgMDAwMDAgbg0KMDAwMDEzOTUwMCAwMDAwMCBuDQowMDAwMTM5NTM5IDAwMDAw IG4NCjAwMDAxMzk1NzggMDAwMDAgbg0KdHJhaWxlcg0KPDwgL0lEIA0KICUgUmVwb3J0TGFi IGdlbmVyYXRlZCBQREYgZG9jdW1lbnQgLS0gZGlnZXN0IChodHRwOi8vd3d3LnJlcG9ydGxh Yi5jb20pDQogWyhcMzE2XDMzNVwzMTFcMzMyMVwyNTBWXDIwMFwzNTV+TVwyNzRcMjUycWkt KSAoXDMxNlwzMzVcMzExXDMzMjFcMjUwVlwyMDBcMzU1fk1cMjc0XDI1MnFpLSldDQogL0lu Zm8gNzkgMCBSIC9Sb290IDc4IDAgUiAvU2l6ZSAxNDUgPj4NCnN0YXJ0eHJlZg0KMTM5NjE3 DQolJUVPRg0K --------------DEE995035C8380D8C0329228 Content-Type: application/pdf; name="hyperlaunch-devicetree.pdf" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="hyperlaunch-devicetree.pdf" JVBERi0xLjQNCiWTjIueIFJlcG9ydExhYiBHZW5lcmF0ZWQgUERGIGRvY3VtZW50IGh0dHA6 Ly93d3cucmVwb3J0bGFiLmNvbQ0KMSAwIG9iag0KPDwgL0YxIDIgMCBSIC9GMiAzIDAgUiAv RjMgNCAwIFIgL0Y0IDkgMCBSIC9GNSAxMSAwIFIgPj4NCmVuZG9iag0KMiAwIG9iag0KPDwg L0Jhc2VGb250IC9IZWx2ZXRpY2EgL0VuY29kaW5nIC9XaW5BbnNpRW5jb2RpbmcgL05hbWUg L0YxIC9TdWJ0eXBlIC9UeXBlMSAvVHlwZSAvRm9udCA+Pg0KZW5kb2JqDQozIDAgb2JqDQo8 PCAvQmFzZUZvbnQgL0hlbHZldGljYS1Cb2xkIC9FbmNvZGluZyAvV2luQW5zaUVuY29kaW5n IC9OYW1lIC9GMiAvU3VidHlwZSAvVHlwZTEgL1R5cGUgL0ZvbnQgPj4NCmVuZG9iag0KNCAw IG9iag0KPDwgL0Jhc2VGb250IC9Db3VyaWVyIC9FbmNvZGluZyAvV2luQW5zaUVuY29kaW5n IC9OYW1lIC9GMyAvU3VidHlwZSAvVHlwZTEgL1R5cGUgL0ZvbnQgPj4NCmVuZG9iag0KNSAw IG9iag0KPDwgL0NvbnRlbnRzIDI1IDAgUiAvTWVkaWFCb3ggWyAwIDAgNTk1LjI3NTYgODQx Ljg4OTggXSAvUGFyZW50IDI0IDAgUiAvUmVzb3VyY2VzIDw8IC9Gb250IDEgMCBSIC9Qcm9j U2V0IFsgL1BERiAvVGV4dCAvSW1hZ2VCIC9JbWFnZUMgL0ltYWdlSSBdID4+IC9Sb3RhdGUg MCAvVHJhbnMgPDwgID4+IA0KICAvVHlwZSAvUGFnZSA+Pg0KZW5kb2JqDQo2IDAgb2JqDQo8 PCAvQ29udGVudHMgMjYgMCBSIC9NZWRpYUJveCBbIDAgMCA1OTUuMjc1NiA4NDEuODg5OCBd IC9QYXJlbnQgMjQgMCBSIC9SZXNvdXJjZXMgPDwgL0ZvbnQgMSAwIFIgL1Byb2NTZXQgWyAv UERGIC9UZXh0IC9JbWFnZUIgL0ltYWdlQyAvSW1hZ2VJIF0gPj4gL1JvdGF0ZSAwIC9UcmFu cyA8PCAgPj4gDQogIC9UeXBlIC9QYWdlID4+DQplbmRvYmoNCjcgMCBvYmoNCjw8IC9Db250 ZW50cyAyNyAwIFIgL01lZGlhQm94IFsgMCAwIDU5NS4yNzU2IDg0MS44ODk4IF0gL1BhcmVu dCAyNCAwIFIgL1Jlc291cmNlcyA8PCAvRm9udCAxIDAgUiAvUHJvY1NldCBbIC9QREYgL1Rl eHQgL0ltYWdlQiAvSW1hZ2VDIC9JbWFnZUkgXSA+PiAvUm90YXRlIDAgL1RyYW5zIDw8ICA+ PiANCiAgL1R5cGUgL1BhZ2UgPj4NCmVuZG9iag0KOCAwIG9iag0KPDwgL0NvbnRlbnRzIDI4 IDAgUiAvTWVkaWFCb3ggWyAwIDAgNTk1LjI3NTYgODQxLjg4OTggXSAvUGFyZW50IDI0IDAg UiAvUmVzb3VyY2VzIDw8IC9Gb250IDEgMCBSIC9Qcm9jU2V0IFsgL1BERiAvVGV4dCAvSW1h Z2VCIC9JbWFnZUMgL0ltYWdlSSBdID4+IC9Sb3RhdGUgMCAvVHJhbnMgPDwgID4+IA0KICAv VHlwZSAvUGFnZSA+Pg0KZW5kb2JqDQo5IDAgb2JqDQo8PCAvQmFzZUZvbnQgL0hlbHZldGlj YS1PYmxpcXVlIC9FbmNvZGluZyAvV2luQW5zaUVuY29kaW5nIC9OYW1lIC9GNCAvU3VidHlw ZSAvVHlwZTEgL1R5cGUgL0ZvbnQgPj4NCmVuZG9iag0KMTAgMCBvYmoNCjw8IC9Db250ZW50 cyAyOSAwIFIgL01lZGlhQm94IFsgMCAwIDU5NS4yNzU2IDg0MS44ODk4IF0gL1BhcmVudCAy NCAwIFIgL1Jlc291cmNlcyA8PCAvRm9udCAxIDAgUiAvUHJvY1NldCBbIC9QREYgL1RleHQg L0ltYWdlQiAvSW1hZ2VDIC9JbWFnZUkgXSA+PiAvUm90YXRlIDAgL1RyYW5zIDw8ICA+PiAN CiAgL1R5cGUgL1BhZ2UgPj4NCmVuZG9iag0KMTEgMCBvYmoNCjw8IC9CYXNlRm9udCAvSGVs dmV0aWNhLUJvbGRPYmxpcXVlIC9FbmNvZGluZyAvV2luQW5zaUVuY29kaW5nIC9OYW1lIC9G NSAvU3VidHlwZSAvVHlwZTEgL1R5cGUgL0ZvbnQgPj4NCmVuZG9iag0KMTIgMCBvYmoNCjw8 IC9Db250ZW50cyAzMCAwIFIgL01lZGlhQm94IFsgMCAwIDU5NS4yNzU2IDg0MS44ODk4IF0g L1BhcmVudCAyNCAwIFIgL1Jlc291cmNlcyA8PCAvRm9udCAxIDAgUiAvUHJvY1NldCBbIC9Q REYgL1RleHQgL0ltYWdlQiAvSW1hZ2VDIC9JbWFnZUkgXSA+PiAvUm90YXRlIDAgL1RyYW5z IDw8ICA+PiANCiAgL1R5cGUgL1BhZ2UgPj4NCmVuZG9iag0KMTMgMCBvYmoNCjw8IC9Db250 ZW50cyAzMSAwIFIgL01lZGlhQm94IFsgMCAwIDU5NS4yNzU2IDg0MS44ODk4IF0gL1BhcmVu dCAyNCAwIFIgL1Jlc291cmNlcyA8PCAvRm9udCAxIDAgUiAvUHJvY1NldCBbIC9QREYgL1Rl eHQgL0ltYWdlQiAvSW1hZ2VDIC9JbWFnZUkgXSA+PiAvUm90YXRlIDAgL1RyYW5zIDw8ICA+ PiANCiAgL1R5cGUgL1BhZ2UgPj4NCmVuZG9iag0KMTQgMCBvYmoNCjw8IC9PdXRsaW5lcyAx NiAwIFIgL1BhZ2VMYWJlbHMgMzIgMCBSIC9QYWdlTW9kZSAvVXNlTm9uZSAvUGFnZXMgMjQg MCBSIC9UeXBlIC9DYXRhbG9nID4+DQplbmRvYmoNCjE1IDAgb2JqDQo8PCAvQXV0aG9yICgp IC9DcmVhdGlvbkRhdGUgKEQ6MjAyMTAzMTYwMzQzMTMrMDAnMDAnKSAvQ3JlYXRvciAoXCh1 bnNwZWNpZmllZFwpKSAvS2V5d29yZHMgKCkgL01vZERhdGUgKEQ6MjAyMTAzMTYwMzQzMTMr MDAnMDAnKSAvUHJvZHVjZXIgKFJlcG9ydExhYiBQREYgTGlicmFyeSAtIHd3dy5yZXBvcnRs YWIuY29tKSANCiAgL1N1YmplY3QgKFwodW5zcGVjaWZpZWRcKSkgL1RpdGxlIChYZW4gSHlw ZXJsYXVuY2ggRGV2aWNlIFRyZWUgQmluZGluZ3MpIC9UcmFwcGVkIC9GYWxzZSA+Pg0KZW5k b2JqDQoxNiAwIG9iag0KPDwgL0NvdW50IDggL0ZpcnN0IDE3IDAgUiAvTGFzdCAyMyAwIFIg L1R5cGUgL091dGxpbmVzID4+DQplbmRvYmoNCjE3IDAgb2JqDQo8PCAvQ291bnQgMiAvRGVz dCBbIDUgMCBSIC9YWVogNjIuNjkyOTEgNjIzLjAyMzYgMCBdIC9GaXJzdCAxOCAwIFIgL0xh c3QgMTkgMCBSIC9OZXh0IDIwIDAgUiAvUGFyZW50IDE2IDAgUiANCiAgL1RpdGxlIChFeGFt cGxlIENvbmZpZ3VyYXRpb24pID4+DQplbmRvYmoNCjE4IDAgb2JqDQo8PCAvRGVzdCBbIDYg MCBSIC9YWVogNjIuNjkyOTEgNzY1LjAyMzYgMCBdIC9OZXh0IDE5IDAgUiAvUGFyZW50IDE3 IDAgUiAvVGl0bGUgKE11bHRpYm9vdCB4ODYgQ29uZmlndXJhdGlvbjopID4+DQplbmRvYmoN CjE5IDAgb2JqDQo8PCAvRGVzdCBbIDggMCBSIC9YWVogNjIuNjkyOTEgNzY1LjAyMzYgMCBd IC9QYXJlbnQgMTcgMCBSIC9QcmV2IDE4IDAgUiAvVGl0bGUgKE1vZHVsZSBBcm0gQ29uZmln dXJhdGlvbjopID4+DQplbmRvYmoNCjIwIDAgb2JqDQo8PCAvRGVzdCBbIDEyIDAgUiAvWFla IDYyLjY5MjkxIDc2NS4wMjM2IDAgXSAvTmV4dCAyMSAwIFIgL1BhcmVudCAxNiAwIFIgL1By ZXYgMTcgMCBSIC9UaXRsZSAoVGhlIEh5cGVydmlzb3Igbm9kZSkgPj4NCmVuZG9iag0KMjEg MCBvYmoNCjw8IC9EZXN0IFsgMTIgMCBSIC9YWVogNjIuNjkyOTEgNjU5LjAyMzYgMCBdIC9O ZXh0IDIyIDAgUiAvUGFyZW50IDE2IDAgUiAvUHJldiAyMCAwIFIgL1RpdGxlIChUaGUgQ29u ZmlnIG5vZGUpID4+DQplbmRvYmoNCjIyIDAgb2JqDQo8PCAvRGVzdCBbIDEyIDAgUiAvWFla IDYyLjY5MjkxIDUyOS4wMjM2IDAgXSAvTmV4dCAyMyAwIFIgL1BhcmVudCAxNiAwIFIgL1By ZXYgMjEgMCBSIC9UaXRsZSAoVGhlIERvbWFpbiBub2RlKSA+Pg0KZW5kb2JqDQoyMyAwIG9i ag0KPDwgL0Rlc3QgWyAxMyAwIFIgL1hZWiA2Mi42OTI5MSA3MTQuMDIzNiAwIF0gL1BhcmVu dCAxNiAwIFIgL1ByZXYgMjIgMCBSIC9UaXRsZSAoVGhlIE1vZHVsZSBub2RlKSA+Pg0KZW5k b2JqDQoyNCAwIG9iag0KPDwgL0NvdW50IDcgL0tpZHMgWyA1IDAgUiA2IDAgUiA3IDAgUiA4 IDAgUiAxMCAwIFIgMTIgMCBSIDEzIDAgUiBdIC9UeXBlIC9QYWdlcyA+Pg0KZW5kb2JqDQoy NSAwIG9iag0KPDwgL0xlbmd0aCAyMjEzID4+DQpzdHJlYW0NCjEgMCAwIDEgMCAwIGNtICBC VCAvRjEgMTIgVGYgMTQuNCBUTCBFVA0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA3NDEuMDIzNiBj bQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCA0IFRtIC9GMiAyMCBUZiAyNCBUTCA0OC43 NzQ4OCAwIFRkIChYZW4gSHlwZXJsYXVuY2ggRGV2aWNlIFRyZWUgQmluZGluZ3MpIFRqIFQq IC00OC43NzQ4OCAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDY5NS4wMjM2 IGNtDQpxDQpCVCAxIDAgMCAxIDAgMjYgVG0gMS4wNTQ5ODUgVHcgMTIgVEwgL0YxIDEwIFRm IDAgMCAwIHJnIChUaGUgWGVuIGh5cGVybGF1bmNoIGRldmljZSB0cmVlIGFkb3B0cyB0aGUg ZG9tMGxlc3MgZGV2aWNlIHRyZWUgc3RydWN0dXJlIGFuZCBleHRlbmRzIGl0IHRvIG1lZXQg dGhlKSBUaiBUKiAwIFR3IDUuMzQ2NjQ3IFR3IChyZXF1aXJlbWVudHMgZm9yIHRoZSBoeXBl cmxhdW5jaCBjYXBhYmlsaXR5LiBUaGUgcHJpbWFyeSBkaWZmZXJlbmNlIGlzIHRoZSBpbnRy b2R1Y3Rpb24gb2YgdGhlKSBUaiBUKiAwIFR3IC9GMyAxMCBUZiAwIDAgMCByZyAoaHlwZXJ2 aXNvciApIFRqIC9GMSAxMCBUZiAwIDAgMCByZyAobm9kZSB0aGF0IGlzIHVuZGVyIHRoZSAp IFRqIC9GMyAxMCBUZiAwIDAgMCByZyAoL2Nob3NlbiApIFRqIC9GMSAxMCBUZiAwIDAgMCBy ZyAobm9kZS4gVGhlIG1vdmUgdG8gYSBkZWRpY2F0ZWQgbm9kZSB3YXMgZHJpdmVuIGJ5Oikg VGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNjg5LjAyMzYgY20NClENCnEN CjEgMCAwIDEgNjIuNjkyOTEgNjg5LjAyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEg NjY1LjAyMzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAw IDEgNiA5IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEy IFRMIDUuNjYgMCBUZCAoMS4pIFRqIFQqIC01LjY2IDAgVGQgRVQNClENClENCnENCjEgMCAw IDEgMjMgLTMgY20NCnENCkJUIDEgMCAwIDEgMCAxNCBUbSAuMTQ0NzI0IFR3IDEyIFRMIC9G MSAxMCBUZiAwIDAgMCByZyAoUmVkdWNlcyB0aGUgbmVlZCB0byB3YWxrIG92ZXIgbm9kZXMg dGhhdCBhcmUgbm90IG9mIGludGVyZXN0LCBlLmcuIG9ubHkgbm9kZXMgb2YgaW50ZXJlc3Qg c2hvdWxkIGJlIGluKSBUaiBUKiAwIFR3IC9GMyAxMCBUZiAwIDAgMCByZyAoL2Nob3Nlbi9o eXBlcnZpc29yKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5 MSA2NTkuMDIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA2MzUuMDIzNiBjbQ0KMCAw IDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAgMSA2IDkgY20NCnENCjAg MCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgNS42NiAwIFRkICgy LikgVGogVCogLTUuNjYgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KcQ0K QlQgMSAwIDAgMSAwIDE0IFRtIDMuMTY3Njc0IFR3IDEyIFRMIC9GMSAxMCBUZiAwIDAgMCBy ZyAoQWxsb3dzIGZvciB0aGUgZG9tYWluIGNvbnN0cnVjdGlvbiBpbmZvcm1hdGlvbiB0byBl YXNpbHkgYmUgc2FuaXRpemVkIGJ5IHNpbXBsZSByZW1vdmluZyB0aGUpIFRqIFQqIDAgVHcg L0YzIDEwIFRmIDAgMCAwIHJnICgvY2hvc2VuL2h5cGVydmlzb3IgKSBUaiAvRjEgMTAgVGYg MCAwIDAgcmcgKG5vZGUuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2 Mi42OTI5MSA2MzUuMDIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA2MDIuMDIzNiBj bQ0KcQ0KQlQgMSAwIDAgMSAwIDMuNSBUbSAyMSBUTCAvRjIgMTcuNSBUZiAwIDAgMCByZyAo RXhhbXBsZSBDb25maWd1cmF0aW9uKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42 OTI5MSA1NzIuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAxNCBUbSAvRjEg MTAgVGYgMTIgVEwgMi4xMzkzOTggVHcgKEJlbG93IGFyZSB0d28gZXhhbXBsZSBkZXZpY2Ug dHJlZSBkZWZpbml0aW9ucyBmb3IgdGhlIGh5cGVydmlzb3Igbm9kZS4gVGhlIGZpcnN0IGlz IGFuIGV4YW1wbGUgb2YgYSkgVGogVCogMCBUdyAobXVsdGlib290LWJhc2VkIGNvbmZpZ3Vy YXRpb24gZm9yIHg4NiBhbmQgdGhlIHNlY29uZCBpcyBhIG1vZHVsZS1iYXNlZCBjb25maWd1 cmF0aW9uIGZvciBBcm0uKSBUaiBUKiBFVA0KUQ0KUQ0KIA0KZW5kc3RyZWFtDQplbmRvYmoN CjI2IDAgb2JqDQo8PCAvTGVuZ3RoIDI0OTEgPj4NCnN0cmVhbQ0KMSAwIDAgMSAwIDAgY20g IEJUIC9GMSAxMiBUZiAxNC40IFRMIEVUDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDc0Ny4wMjM2 IGNtDQpxDQpCVCAxIDAgMCAxIDAgMyBUbSAxOCBUTCAvRjIgMTUgVGYgMCAwIDAgcmcgKE11 bHRpYm9vdCB4ODYgQ29uZmlndXJhdGlvbjopIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAx IDYyLjY5MjkxIDc3LjgyMzYyIGNtDQpxDQpxDQoxIDAgMCAxIDAgMCBjbQ0KcQ0KMSAwIDAg MSA2LjYgNi42IGNtDQpxDQouNjYyNzQ1IC42NjI3NDUgLjY2Mjc0NSBSRw0KLjUgdw0KLjk2 MDc4NCAuOTYwNzg0IC44NjI3NDUgcmcNCm4gLTYgLTYgNDY4LjY4OTggNjYwIHJlIEIqDQpR DQpxDQpCVCAxIDAgMCAxIDAgNjM4IFRtIDEyIFRMIC9GMyAxMCBUZiAwIDAgMCByZyAoaHlw ZXJ2aXNvciB7KSBUaiBUKiAoICAgICNhZGRyZXNzLWNlbGxzID0gKSBUaiAoPCkgVGogKDEp IFRqICg+KSBUaiAoOykgVGogVCogKCAgICAjc2l6ZS1jZWxscyA9ICkgVGogKDwpIFRqICgw KSBUaiAoPikgVGogKDspIFRqIFQqICggICAgY29tcGF0aWJsZSA9IFwyMjNoeXBlcnZpc29y LHhlblwyMjQpIFRqIFQqICBUKiAoICAgIC8vIENvbmZpZ3VyYXRpb24gY29udGFpbmVyKSBU aiBUKiAoICAgIGNvbmZpZyB7KSBUaiBUKiAoICAgICAgICBjb21wYXRpYmxlID0gInhlbixj b25maWciOykgVGogVCogIFQqICggICAgICAgIG1vZHVsZSB7KSBUaiBUKiAoICAgICAgICAg ICAgY29tcGF0aWJsZSA9ICJtb2R1bGUsbWljcm9jb2RlIiwgIm11bHRpYm9vdCxtb2R1bGUi OykgVGogVCogKCAgICAgICAgICAgIG1iLWluZGV4ID0gKSBUaiAoPCkgVGogKDEpIFRqICg+ KSBUaiAoOykgVGogVCogKCAgICAgICAgfTspIFRqIFQqICBUKiAoICAgICAgICBtb2R1bGUg eykgVGogVCogKCAgICAgICAgICAgIGNvbXBhdGlibGUgPSAibW9kdWxlLHhzbS1wb2xpY3ki LCAibXVsdGlib290LG1vZHVsZSI7KSBUaiBUKiAoICAgICAgICAgICAgbWItaW5kZXggPSAp IFRqICg8KSBUaiAoMikgVGogKD4pIFRqICg7KSBUaiBUKiAoICAgICAgICB9OykgVGogVCog KCAgICB9OykgVGogVCogIFQqICggICAgLy8gQm9vdCBEb21haW4gZGVmaW5pdGlvbikgVGog VCogKCAgICBkb21haW4geykgVGogVCogKCAgICAgICAgY29tcGF0aWJsZSA9ICJ4ZW4sZG9t YWluIjspIFRqIFQqICBUKiAoICAgICAgICBkb21pZCA9ICkgVGogKDwpIFRqICgweDdGRjUp IFRqICg+KSBUaiAoOykgVGogVCogIFQqICggICAgICAgIC8vIEZVTkNUSU9OX05PTkUgICAg ICAgICAgICBcKDBcKSkgVGogVCogKCAgICAgICAgLy8gRlVOQ1RJT05fQk9PVCAgICAgICAg ICAgIFwoMSApIFRqICg8KSBUaiAoPCkgVGogKCAwXCkpIFRqIFQqICggICAgICAgIC8vIEZV TkNUSU9OX0NSQVNIICAgICAgICAgICBcKDEgKSBUaiAoPCkgVGogKDwpIFRqICggMVwpKSBU aiBUKiAoICAgICAgICAvLyBGVU5DVElPTl9DT05TT0xFICAgICAgICAgXCgxICkgVGogKDwp IFRqICg8KSBUaiAoIDJcKSkgVGogVCogKCAgICAgICAgLy8gRlVOQ1RJT05fWEVOU1RPUkUg ICAgICAgIFwoMSApIFRqICg8KSBUaiAoPCkgVGogKCAzMFwpKSBUaiBUKiAoICAgICAgICAv LyBGVU5DVElPTl9MRUdBQ1lfRE9NMCAgICAgXCgxICkgVGogKDwpIFRqICg8KSBUaiAoIDMx XCkpIFRqIFQqICggICAgICAgIGZ1bmN0aW9ucyA9ICkgVGogKDwpIFRqICgweDAwMDAwMDAx KSBUaiAoPikgVGogKDspIFRqIFQqICBUKiAoICAgICAgICBtZW1vcnkgPSApIFRqICg8KSBU aiAoMHgwIDB4MjAwMDApIFRqICg+KSBUaiAoOykgVGogVCogKCAgICAgICAgY3B1cyA9ICkg VGogKDwpIFRqICgxKSBUaiAoPikgVGogKDspIFRqIFQqICggICAgICAgIG1vZHVsZSB7KSBU aiBUKiAoICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJtb2R1bGUsa2VybmVsIiwgIm11bHRp Ym9vdCxtb2R1bGUiOykgVGogVCogKCAgICAgICAgICAgIG1iLWluZGV4ID0gKSBUaiAoPCkg VGogKDMpIFRqICg+KSBUaiAoOykgVGogVCogKCAgICAgICAgfTspIFRqIFQqICBUKiAoICAg ICAgICBtb2R1bGUgeykgVGogVCogKCAgICAgICAgICAgIGNvbXBhdGlibGUgPSAibW9kdWxl LHJhbWRpc2siLCAibXVsdGlib290LG1vZHVsZSI7KSBUaiBUKiAoICAgICAgICAgICAgbWIt aW5kZXggPSApIFRqICg8KSBUaiAoNCkgVGogKD4pIFRqICg7KSBUaiBUKiAoICAgICAgICB9 OykgVGogVCogKCAgICAgICAgbW9kdWxlIHspIFRqIFQqICggICAgICAgICAgICBjb21wYXRp YmxlID0gIm1vZHVsZSxjb25maWciLCAibXVsdGlib290LG1vZHVsZSI7KSBUaiBUKiAoICAg ICAgICAgICAgbWItaW5kZXggPSApIFRqICg8KSBUaiAoNSkgVGogKD4pIFRqICg7KSBUaiBU KiAoICAgICAgICB9OykgVGogVCogIFQqICggICAgLy8gQ2xhc3NpYyBEb20wIGRlZmluaXRp b24pIFRqIFQqICggICAgZG9tYWluIHspIFRqIFQqICggICAgICAgIGNvbXBhdGlibGUgPSAi eGVuLGRvbWFpbiI7KSBUaiBUKiAgVCogRVQNClENClENClENClENClENCiANCmVuZHN0cmVh bQ0KZW5kb2JqDQoyNyAwIG9iag0KPDwgL0xlbmd0aCA1MDA5ID4+DQpzdHJlYW0NCjEgMCAw IDEgMCAwIGNtICBCVCAvRjEgMTIgVGYgMTQuNCBUTCBFVA0KcQ0KMSAwIDAgMSA2Mi42OTI5 MSAzMDcuODIzNiBjbQ0KcQ0KcQ0KMSAwIDAgMSAwIDAgY20NCnENCjEgMCAwIDEgNi42IDYu NiBjbQ0KcQ0KLjY2Mjc0NSAuNjYyNzQ1IC42NjI3NDUgUkcNCi41IHcNCi45NjA3ODQgLjk2 MDc4NCAuODYyNzQ1IHJnDQpuIC02IC02IDQ2OC42ODk4IDQ1NiByZSBCKg0KUQ0KcQ0KQlQg MSAwIDAgMSAwIDQzNCBUbSAxMiBUTCAvRjMgMTAgVGYgMCAwIDAgcmcgKCAgICAgICAgZG9t aWQgPSApIFRqICg8KSBUaiAoMCkgVGogKD4pIFRqICg7KSBUaiBUKiAgVCogKCAgICAgICAg Ly8gUEVSTUlTU0lPTl9OT05FICAgICAgICAgIFwoMFwpKSBUaiBUKiAoICAgICAgICAvLyBQ RVJNSVNTSU9OX0NPTlRST0wgICAgICAgXCgxICkgVGogKDwpIFRqICg8KSBUaiAoIDBcKSkg VGogVCogKCAgICAgICAgLy8gUEVSTUlTU0lPTl9IQVJEV0FSRSAgICAgIFwoMSApIFRqICg8 KSBUaiAoPCkgVGogKCAxXCkpIFRqIFQqICggICAgICAgIHBlcm1pc3Npb25zID0gKSBUaiAo PCkgVGogKDMpIFRqICg+KSBUaiAoOykgVGogVCogIFQqICggICAgICAgIC8vIEZVTkNUSU9O X05PTkUgICAgICAgICAgICBcKDBcKSkgVGogVCogKCAgICAgICAgLy8gRlVOQ1RJT05fQk9P VCAgICAgICAgICAgIFwoMSApIFRqICg8KSBUaiAoPCkgVGogKCAwXCkpIFRqIFQqICggICAg ICAgIC8vIEZVTkNUSU9OX0NSQVNIICAgICAgICAgICBcKDEgKSBUaiAoPCkgVGogKDwpIFRq ICggMVwpKSBUaiBUKiAoICAgICAgICAvLyBGVU5DVElPTl9DT05TT0xFICAgICAgICAgXCgx ICkgVGogKDwpIFRqICg8KSBUaiAoIDJcKSkgVGogVCogKCAgICAgICAgLy8gRlVOQ1RJT05f WEVOU1RPUkUgICAgICAgIFwoMSApIFRqICg8KSBUaiAoPCkgVGogKCAzMFwpKSBUaiBUKiAo ICAgICAgICAvLyBGVU5DVElPTl9MRUdBQ1lfRE9NMCAgICAgXCgxICkgVGogKDwpIFRqICg8 KSBUaiAoIDMxXCkpIFRqIFQqICggICAgICAgIGZ1bmN0aW9ucyA9ICkgVGogKDwpIFRqICgw eEMwMDAwMDA2KSBUaiAoPikgVGogKDspIFRqIFQqICBUKiAoICAgICAgICAvLyBNT0RFX1BB UkFWSVJUVUFMSVpFRCAgICAgXCgxICkgVGogKDwpIFRqICg8KSBUaiAoIDBcKSAvKiBQViB8 IFBWSC9IVk0gKi8pIFRqIFQqICggICAgICAgIC8vIE1PREVfRU5BQkxFX0RFVklDRV9NT0RF TCBcKDEgKSBUaiAoPCkgVGogKDwpIFRqICggMVwpIC8qIEhWTSB8IFBWSCAqLykgVGogVCog KCAgICAgICAgLy8gTU9ERV9MT05HICAgICAgICAgICAgICAgIFwoMSApIFRqICg8KSBUaiAo PCkgVGogKCAyXCkgLyogNjQgQklUIHwgMzIgQklUICovKSBUaiBUKiAoICAgICAgICBtb2Rl ID0gKSBUaiAoPCkgVGogKDUpIFRqICg+KSBUaiAoOyAvKiA2NCBCSVQsIFBWICovKSBUaiBU KiAgVCogKCAgICAgICAgLy8gVVVJRCkgVGogVCogKCAgICAgICAgZG9tYWluLXV1aWQgPSBb QjMgRkIgOTggRkIgOEYgOUYgNjcgQTNdOykgVGogVCogIFQqICggICAgICAgIGNwdXMgPSAp IFRqICg8KSBUaiAoMSkgVGogKD4pIFRqICg7KSBUaiBUKiAoICAgICAgICBtZW1vcnkgPSAp IFRqICg8KSBUaiAoMHgwIDB4MjAwMDApIFRqICg+KSBUaiAoOykgVGogVCogKCAgICAgICAg c2VjdXJpdHktaWQgPSBcMjIzZG9tMF90OykgVGogVCogIFQqICggICAgICAgIG1vZHVsZSB7 KSBUaiBUKiAoICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJtb2R1bGUsa2VybmVsIiwgIm11 bHRpYm9vdCxtb2R1bGUiOykgVGogVCogKCAgICAgICAgICAgIG1iLWluZGV4ID0gKSBUaiAo PCkgVGogKDYpIFRqICg+KSBUaiAoOykgVGogVCogKCAgICAgICAgICAgIGJvb3RhcmdzID0g ImNvbnNvbGU9aHZjMCI7KSBUaiBUKiAoICAgICAgICB9OykgVGogVCogKCAgICAgICAgbW9k dWxlIHspIFRqIFQqICggICAgICAgICAgICBjb21wYXRpYmxlID0gIm1vZHVsZSxyYW1kaXNr IiwgIm11bHRpYm9vdCxtb2R1bGUiOykgVGogVCogKCAgICAgICAgICAgIG1iLWluZGV4ID0g KSBUaiAoPCkgVGogKDcpIFRqICg+KSBUaiAoOykgVGogVCogKCAgICAgICAgfTspIFRqIFQq ICh9OykgVGogVCogRVQNClENClENClENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMjg3 LjgyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIg VEwgKFRoZSBtdWx0aWJvb3QgbW9kdWxlcyBzdXBwbGllZCB3aGVuIHVzaW5nIHRoZSBhYm92 ZSBjb25maWcgd291bGQgYmUsIGluIG9yZGVyOikgVGogVCogRVQNClENClENCnENCjEgMCAw IDEgNjIuNjkyOTEgMjgxLjgyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMjgxLjgy MzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMjY5LjgyMzYgY20NCjAgMCAwIHJnDQpC VCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0KcQ0KMCAwIDAgcmcN CkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRq IFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAw IHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKFwodGhlIGFib3ZlIGNv bmZpZywgY29tcGlsZWRcKSkgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEg NjIuNjkyOTEgMjYzLjgyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMjUxLjgyMzYg Y20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBj bQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41 IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMg LTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwg KENQVSBtaWNyb2NvZGUpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYy LjY5MjkxIDI0NS44MjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDIzMy44MjM2IGNt DQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAgMCAxIDYgLTMgY20N CnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAw IFRkIChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0z IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChY U00gcG9saWN5KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5 MSAyMjcuODIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAyMTUuODIzNiBjbQ0KMCAw IDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAgMSA2IC0zIGNtDQpxDQow IDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAo XDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0K cQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoa2VybmVs IGZvciBib290IGRvbWFpbikgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEg NjIuNjkyOTEgMjA5LjgyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMTk3LjgyMzYg Y20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBj bQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41 IDAgVGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMg LTMgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwg KHJhbWRpc2sgZm9yIGJvb3QgZG9tYWluKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0K MSAwIDAgMSA2Mi42OTI5MSAxOTEuODIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAx NzkuODIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAg MSA2IC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEy IFRMIDEwLjUgMCBUZCAoXDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAw IDAgMSAyMyAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBU ZiAxMiBUTCAoYm9vdCBkb21haW4gY29uZmlndXJhdGlvbiBmaWxlKSBUaiBUKiBFVA0KUQ0K UQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAxNzMuODIzNiBjbQ0KUQ0KcQ0KMSAw IDAgMSA2Mi42OTI5MSAxNjEuODIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBU TCBFVA0KcQ0KMSAwIDAgMSA2IC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIg VG0gL0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAoXDE3NykgVGogVCogLTEwLjUgMCBUZCBF VA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEg MCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoa2VybmVsIGZvciB0aGUgY2xhc3NpYyBkb20wIGRv bWFpbikgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMTU1 LjgyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMTQzLjgyMzYgY20NCjAgMCAwIHJn DQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0KcQ0KMCAwIDAg cmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcp IFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAg MCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKHJhbWRpc2sgZm9y IHRoZSBjbGFzc2ljIGRvbTAgZG9tYWluKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0K MSAwIDAgMSA2Mi42OTI5MSAxNDMuODIzNiBjbQ0KUQ0KIA0KZW5kc3RyZWFtDQplbmRvYmoN CjI4IDAgb2JqDQo8PCAvTGVuZ3RoIDI0MjIgPj4NCnN0cmVhbQ0KMSAwIDAgMSAwIDAgY20g IEJUIC9GMSAxMiBUZiAxNC40IFRMIEVUDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDc0Ny4wMjM2 IGNtDQpxDQpCVCAxIDAgMCAxIDAgMyBUbSAxOCBUTCAvRjIgMTUgVGYgMCAwIDAgcmcgKE1v ZHVsZSBBcm0gQ29uZmlndXJhdGlvbjopIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYy LjY5MjkxIDc3LjgyMzYyIGNtDQpxDQpxDQoxIDAgMCAxIDAgMCBjbQ0KcQ0KMSAwIDAgMSA2 LjYgNi42IGNtDQpxDQouNjYyNzQ1IC42NjI3NDUgLjY2Mjc0NSBSRw0KLjUgdw0KLjk2MDc4 NCAuOTYwNzg0IC44NjI3NDUgcmcNCm4gLTYgLTYgNDY4LjY4OTggNjYwIHJlIEIqDQpRDQpx DQpCVCAxIDAgMCAxIDAgNjM4IFRtIDEyIFRMIC9GMyAxMCBUZiAwIDAgMCByZyAoaHlwZXJ2 aXNvciB7KSBUaiBUKiAoICAgIGNvbXBhdGlibGUgPSBcMjIzaHlwZXJ2aXNvcix4ZW5cMjI0 KSBUaiBUKiAgVCogKCAgICAvLyBDb25maWd1cmF0aW9uIGNvbnRhaW5lcikgVGogVCogKCAg ICBjb25maWcgeykgVGogVCogKCAgICAgICAgY29tcGF0aWJsZSA9ICJ4ZW4sY29uZmlnIjsp IFRqIFQqICBUKiAoICAgICAgICBtb2R1bGUgeykgVGogVCogKCAgICAgICAgICAgIGNvbXBh dGlibGUgPSAibW9kdWxlLG1pY3JvY29kZVwyMjQ7KSBUaiBUKiAoICAgICAgICAgICAgbW9k dWxlLWFkZHIgPSApIFRqICg8KSBUaiAoMHgwMDAwZmYwMCAweDgwKSBUaiAoPikgVGogKDsp IFRqIFQqICggICAgICAgIH07KSBUaiBUKiAgVCogKCAgICAgICAgbW9kdWxlIHspIFRqIFQq ICggICAgICAgICAgICBjb21wYXRpYmxlID0gIm1vZHVsZSx4c20tcG9saWN5IjspIFRqIFQq ICggICAgICAgICAgICBtb2R1bGUtYWRkciA9ICkgVGogKDwpIFRqICgweDAwMDBmZjAwIDB4 ODApIFRqICg+KSBUaiAoOykgVGogVCogIFQqICggICAgICAgIH07KSBUaiBUKiAoICAgIH07 KSBUaiBUKiAgVCogKCAgICAvLyBCb290IERvbWFpbiBkZWZpbml0aW9uKSBUaiBUKiAoICAg IGRvbWFpbiB7KSBUaiBUKiAoICAgICAgICBjb21wYXRpYmxlID0gInhlbixkb21haW4iOykg VGogVCogIFQqICggICAgICAgIGRvbWlkID0gKSBUaiAoPCkgVGogKDB4N0ZGNSkgVGogKD4p IFRqICg7KSBUaiBUKiAgVCogKCAgICAgICAgLy8gRlVOQ1RJT05fTk9ORSAgICAgICAgICAg IFwoMFwpKSBUaiBUKiAoICAgICAgICAvLyBGVU5DVElPTl9CT09UICAgICAgICAgICAgXCgx ICkgVGogKDwpIFRqICg8KSBUaiAoIDBcKSkgVGogVCogKCAgICAgICAgLy8gRlVOQ1RJT05f Q1JBU0ggICAgICAgICAgIFwoMSApIFRqICg8KSBUaiAoPCkgVGogKCAxXCkpIFRqIFQqICgg ICAgICAgIC8vIEZVTkNUSU9OX0NPTlNPTEUgICAgICAgICBcKDEgKSBUaiAoPCkgVGogKDwp IFRqICggMlwpKSBUaiBUKiAoICAgICAgICAvLyBGVU5DVElPTl9YRU5TVE9SRSAgICAgICAg XCgxICkgVGogKDwpIFRqICg8KSBUaiAoIDMwXCkpIFRqIFQqICggICAgICAgIC8vIEZVTkNU SU9OX0xFR0FDWV9ET00wICAgICBcKDEgKSBUaiAoPCkgVGogKDwpIFRqICggMzFcKSkgVGog VCogKCAgICAgICAgZnVuY3Rpb25zID0gKSBUaiAoPCkgVGogKDB4MDAwMDAwMDEpIFRqICg+ KSBUaiAoOykgVGogVCogIFQqICggICAgICAgIG1lbW9yeSA9ICkgVGogKDwpIFRqICgweDAg MHgyMDAwMCkgVGogKD4pIFRqICg7KSBUaiBUKiAoICAgICAgICBjcHVzID0gKSBUaiAoPCkg VGogKDEpIFRqICg+KSBUaiAoOykgVGogVCogKCAgICAgICAgbW9kdWxlIHspIFRqIFQqICgg ICAgICAgICAgICBjb21wYXRpYmxlID0gIm1vZHVsZSxrZXJuZWwiOykgVGogVCogKCAgICAg ICAgICAgIG1vZHVsZS1hZGRyID0gKSBUaiAoPCkgVGogKDB4MDAwMGZmMDAgMHg4MCkgVGog KD4pIFRqICg7KSBUaiBUKiAoICAgICAgICB9OykgVGogVCogIFQqICggICAgICAgIG1vZHVs ZSB7KSBUaiBUKiAoICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJtb2R1bGUscmFtZGlzayI7 KSBUaiBUKiAoICAgICAgICAgICAgbW9kdWxlLWFkZHIgPSApIFRqICg8KSBUaiAoMHgwMDAw ZmYwMCAweDgwKSBUaiAoPikgVGogKDspIFRqIFQqICggICAgICAgIH07KSBUaiBUKiAoICAg ICAgICBtb2R1bGUgeykgVGogVCogKCAgICAgICAgICAgIGNvbXBhdGlibGUgPSAibW9kdWxl LGNvbmZpZyI7KSBUaiBUKiAoICAgICAgICAgICAgbW9kdWxlLWFkZHIgPSApIFRqICg8KSBU aiAoMHgwMDAwZmYwMCAweDgwKSBUaiAoPikgVGogKDspIFRqIFQqICggICAgICAgIH07KSBU aiBUKiAgVCogKCAgICAvLyBDbGFzc2ljIERvbTAgZGVmaW5pdGlvbikgVGogVCogKCAgICBk b21haW5AMCB7KSBUaiBUKiAoICAgICAgICBjb21wYXRpYmxlID0gInhlbixkb21haW4iOykg VGogVCogIFQqICggICAgICAgIGRvbWlkID0gKSBUaiAoPCkgVGogKDApIFRqICg+KSBUaiAo OykgVGogVCogRVQNClENClENClENClENClENCiANCmVuZHN0cmVhbQ0KZW5kb2JqDQoyOSAw IG9iag0KPDwgL0xlbmd0aCA1NDE0ID4+DQpzdHJlYW0NCjEgMCAwIDEgMCAwIGNtICBCVCAv RjEgMTIgVGYgMTQuNCBUTCBFVA0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAzMTkuODIzNiBjbQ0K cQ0KcQ0KMSAwIDAgMSAwIDAgY20NCnENCjEgMCAwIDEgNi42IDYuNiBjbQ0KcQ0KLjY2Mjc0 NSAuNjYyNzQ1IC42NjI3NDUgUkcNCi41IHcNCi45NjA3ODQgLjk2MDc4NCAuODYyNzQ1IHJn DQpuIC02IC02IDQ2OC42ODk4IDQ0NCByZSBCKg0KUQ0KcQ0KQlQgMSAwIDAgMSAwIDQyMiBU bSAxMiBUTCAvRjMgMTAgVGYgMCAwIDAgcmcgIFQqICggICAgICAgIC8vIFBFUk1JU1NJT05f Tk9ORSAgICAgICAgICBcKDBcKSkgVGogVCogKCAgICAgICAgLy8gUEVSTUlTU0lPTl9DT05U Uk9MICAgICAgIFwoMSApIFRqICg8KSBUaiAoPCkgVGogKCAwXCkpIFRqIFQqICggICAgICAg IC8vIFBFUk1JU1NJT05fSEFSRFdBUkUgICAgICBcKDEgKSBUaiAoPCkgVGogKDwpIFRqICgg MVwpKSBUaiBUKiAoICAgICAgICBwZXJtaXNzaW9ucyA9ICkgVGogKDwpIFRqICgzKSBUaiAo PikgVGogKDspIFRqIFQqICBUKiAoICAgICAgICAvLyBGVU5DVElPTl9OT05FICAgICAgICAg ICAgXCgwXCkpIFRqIFQqICggICAgICAgIC8vIEZVTkNUSU9OX0JPT1QgICAgICAgICAgICBc KDEgKSBUaiAoPCkgVGogKDwpIFRqICggMFwpKSBUaiBUKiAoICAgICAgICAvLyBGVU5DVElP Tl9DUkFTSCAgICAgICAgICAgXCgxICkgVGogKDwpIFRqICg8KSBUaiAoIDFcKSkgVGogVCog KCAgICAgICAgLy8gRlVOQ1RJT05fQ09OU09MRSAgICAgICAgIFwoMSApIFRqICg8KSBUaiAo PCkgVGogKCAyXCkpIFRqIFQqICggICAgICAgIC8vIEZVTkNUSU9OX1hFTlNUT1JFICAgICAg ICBcKDEgKSBUaiAoPCkgVGogKDwpIFRqICggMzBcKSkgVGogVCogKCAgICAgICAgLy8gRlVO Q1RJT05fTEVHQUNZX0RPTTAgICAgIFwoMSApIFRqICg8KSBUaiAoPCkgVGogKCAzMVwpKSBU aiBUKiAoICAgICAgICBmdW5jdGlvbnMgPSApIFRqICg8KSBUaiAoMHhDMDAwMDAwNikgVGog KD4pIFRqICg7KSBUaiBUKiAgVCogKCAgICAgICAgLy8gTU9ERV9QQVJBVklSVFVBTElaRUQg ICAgIFwoMSApIFRqICg8KSBUaiAoPCkgVGogKCAwXCkgLyogUFYgfCBQVkgvSFZNICovKSBU aiBUKiAoICAgICAgICAvLyBNT0RFX0VOQUJMRV9ERVZJQ0VfTU9ERUwgXCgxICkgVGogKDwp IFRqICg8KSBUaiAoIDFcKSAvKiBIVk0gfCBQVkggKi8pIFRqIFQqICggICAgICAgIC8vIE1P REVfTE9ORyAgICAgICAgICAgICAgICBcKDEgKSBUaiAoPCkgVGogKDwpIFRqICggMlwpIC8q IDY0IEJJVCB8IDMyIEJJVCAqLykgVGogVCogKCAgICAgICAgbW9kZSA9ICkgVGogKDwpIFRq ICg1KSBUaiAoPikgVGogKDsgLyogNjQgQklULCBQViAqLykgVGogVCogIFQqICggICAgICAg IC8vIFVVSUQpIFRqIFQqICggICAgICAgIGRvbWFpbi11dWlkID0gW0IzIEZCIDk4IEZCIDhG IDlGIDY3IEEzXTspIFRqIFQqICBUKiAoICAgICAgICBjcHVzID0gKSBUaiAoPCkgVGogKDEp IFRqICg+KSBUaiAoOykgVGogVCogKCAgICAgICAgbWVtb3J5ID0gKSBUaiAoPCkgVGogKDB4 MCAweDIwMDAwKSBUaiAoPikgVGogKDspIFRqIFQqICggICAgICAgIHNlY3VyaXR5LWlkID0g XDIyM2RvbTBfdFwyMjQ7KSBUaiBUKiAgVCogKCAgICAgICAgbW9kdWxlIHspIFRqIFQqICgg ICAgICAgICAgICBjb21wYXRpYmxlID0gIm1vZHVsZSxrZXJuZWwiOykgVGogVCogKCAgICAg ICAgICAgIG1vZHVsZS1hZGRyID0gKSBUaiAoPCkgVGogKDB4MDAwMGZmMDAgMHg4MCkgVGog KD4pIFRqICg7KSBUaiBUKiAoICAgICAgICAgICAgYm9vdGFyZ3MgPSAiY29uc29sZT1odmMw IjspIFRqIFQqICggICAgICAgIH07KSBUaiBUKiAoICAgICAgICBtb2R1bGUgeykgVGogVCog KCAgICAgICAgICAgIGNvbXBhdGlibGUgPSAibW9kdWxlLHJhbWRpc2siOykgVGogVCogKCAg ICAgICAgICAgIG1vZHVsZS1hZGRyID0gKSBUaiAoPCkgVGogKDB4MDAwMGZmMDAgMHg4MCkg VGogKD4pIFRqICg7KSBUaiBUKiAoICAgICAgICB9OykgVGogVCogKH07KSBUaiBUKiBFVA0K UQ0KUQ0KUQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAyOTkuODIzNiBjbQ0KcQ0KMCAw IDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoVGhlIG1vZHVsZXMg dGhhdCB3b3VsZCBiZSBzdXBwbGllZCB3aGVuIHVzaW5nIHRoZSBhYm92ZSBjb25maWcgd291 bGQgYmU6KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAyOTMuODIzNiBj bQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAyOTMuODIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2 Mi42OTI5MSAyODEuODIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0K cQ0KMSAwIDAgMSA2IC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0Yx IDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAoXDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0K UQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRt IC9GMSAxMCBUZiAxMiBUTCAoXCh0aGUgYWJvdmUgY29uZmlnLCBjb21waWxlZCBpbnRvIGhh cmR3YXJlIHRyZWVcKSkgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIu NjkyOTEgMjc1LjgyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMjYzLjgyMzYgY20N CjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0K cQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAg VGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMg Y20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKENQ VSBtaWNyb2NvZGUpIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5 MjkxIDI1Ny44MjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDI0NS44MjM2IGNtDQow IDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpxDQoxIDAgMCAxIDYgLTMgY20NCnEN CjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgMTAuNSAwIFRk IChcMTc3KSBUaiBUKiAtMTAuNSAwIFRkIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDIzIC0zIGNt DQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChYU00g cG9saWN5KSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAy MzkuODIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAyMjcuODIzNiBjbQ0KMCAwIDAg cmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAgMSA2IC0zIGNtDQpxDQowIDAg MCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAoXDE3 NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KcQ0K MCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoa2VybmVsIGZv ciBib290IGRvbWFpbikgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIu NjkyOTEgMjIxLjgyMzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMjA5LjgyMzYgY20N CjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0K cQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAg VGQgKFwxNzcpIFRqIFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMg Y20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKHJh bWRpc2sgZm9yIGJvb3QgZG9tYWluKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAw IDAgMSA2Mi42OTI5MSAyMDMuODIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAxOTEu ODIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KcQ0KMSAwIDAgMSA2 IC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRM IDEwLjUgMCBUZCAoXDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0KUQ0KUQ0KcQ0KMSAwIDAg MSAyMyAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAx MiBUTCAoYm9vdCBkb21haW4gY29uZmlndXJhdGlvbiBmaWxlKSBUaiBUKiBFVA0KUQ0KUQ0K cQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAxODUuODIzNiBjbQ0KUQ0KcQ0KMSAwIDAg MSA2Mi42OTI5MSAxNzMuODIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBF VA0KcQ0KMSAwIDAgMSA2IC0zIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0g L0YxIDEwIFRmIDEyIFRMIDEwLjUgMCBUZCAoXDE3NykgVGogVCogLTEwLjUgMCBUZCBFVA0K UQ0KUQ0KcQ0KMSAwIDAgMSAyMyAtMyBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAy IFRtIC9GMSAxMCBUZiAxMiBUTCAoa2VybmVsIGZvciB0aGUgY2xhc3NpYyBkb20wIGRvbWFp bikgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMTY3Ljgy MzYgY20NClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMTU1LjgyMzYgY20NCjAgMCAwIHJnDQpC VCAvRjEgMTAgVGYgMTIgVEwgRVQNCnENCjEgMCAwIDEgNiAtMyBjbQ0KcQ0KMCAwIDAgcmcN CkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAxMC41IDAgVGQgKFwxNzcpIFRq IFQqIC0xMC41IDAgVGQgRVQNClENClENCnENCjEgMCAwIDEgMjMgLTMgY20NCnENCjAgMCAw IHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKHJhbWRpc2sgZm9yIHRo ZSBjbGFzc2ljIGRvbTAgZG9tYWluKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAw IDAgMSA2Mi42OTI5MSAxNTUuODIzNiBjbQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAxMTMu ODIzNiBjbQ0KcQ0KQlQgMSAwIDAgMSAwIDI2IFRtIC45ODY4NiBUdyAxMiBUTCAvRjEgMTAg VGYgMCAwIDAgcmcgKFRoZSBoeXBlcnZpc29yIGRldmljZSB0cmVlIHdvdWxkIGJlIGNvbXBp bGVkIGludG8gdGhlIGhhcmR3YXJlIGRldmljZSB0cmVlIGFuZCBwcm92aWRlZCB0byBYZW4g dXNpbmcpIFRqIFQqIDAgVHcgLjYzODczNSBUdyAodGhlIHN0YW5kYXJkIG1ldGhvZCBjdXJy ZW50bHkgaW4gdXNlLiBUaGUgcmVtYWluaW5nIG1vZHVsZXMgd291bGQgbmVlZCB0byBiZSBs b2FkZWQgaW4gdGhlIHJlc3BlY3RpdmUpIFRqIFQqIDAgVHcgKGFkZHJlc3NlcyBzcGVjaWZp ZWQgaW4gdGhlICkgVGogL0Y0IDEwIFRmIDAgMCAwIHJnIChtb2R1bGUtYWRkciApIFRqIC9G MSAxMCBUZiAwIDAgMCByZyAocHJvcGVydHkuKSBUaiBUKiBFVA0KUQ0KUQ0KIA0KZW5kc3Ry ZWFtDQplbmRvYmoNCjMwIDAgb2JqDQo8PCAvTGVuZ3RoIDY4NTQgPj4NCnN0cmVhbQ0KMSAw IDAgMSAwIDAgY20gIEJUIC9GMSAxMiBUZiAxNC40IFRMIEVUDQpxDQoxIDAgMCAxIDYyLjY5 MjkxIDc0NC4wMjM2IGNtDQpxDQpCVCAxIDAgMCAxIDAgMy41IFRtIDIxIFRMIC9GMiAxNy41 IFRmIDAgMCAwIHJnIChUaGUgSHlwZXJ2aXNvciBub2RlKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0K MSAwIDAgMSA2Mi42OTI5MSA3MDIuMDIzNiBjbQ0KcQ0KQlQgMSAwIDAgMSAwIDI2IFRtIC4x MjI5ODggVHcgMTIgVEwgL0YxIDEwIFRmIDAgMCAwIHJnIChUaGUgaHlwZXJ2aXNvciBub2Rl IGlzIGEgdG9wIGxldmVsIGNvbnRhaW5lciBmb3IgdGhlIGRvbWFpbnMgdGhhdCB3aWxsIGJl IGJ1aWx0IGJ5IGh5cGVydmlzb3Igb24gc3RhcnQgdXAuIE9uKSBUaiBUKiAwIFR3IDIuODEz NTU1IFR3ICh0aGUgKSBUaiAvRjMgMTAgVGYgMCAwIDAgcmcgKGh5cGVydmlzb3IgKSBUaiAv RjEgMTAgVGYgMCAwIDAgcmcgKG5vZGUgdGhlICkgVGogL0YzIDEwIFRmIDAgMCAwIHJnIChj b21wYXRpYmxlICkgVGogL0YxIDEwIFRmIDAgMCAwIHJnIChwcm9wZXJ0eSBpcyB1c2VkIHRv IGlkZW50aWZ5IHRoZSB0eXBlIG9mIGh5cGVydmlzb3Igbm9kZSkgVGogVCogMCBUdyAocHJl c2VudC4uKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA2ODYuMDIzNiBj bQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoY29t cGF0aWJsZSkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNjcxLjAyMzYg Y20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCkJUIDEgMCAwIDEgMCAyIFRt ICBUKiBFVA0KcQ0KMSAwIDAgMSAyMCAwIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAw IDIgVG0gL0YxIDEwIFRmIDEyIFRMIChJZGVudGlmaWVzIHRoZSB0eXBlIG9mIG5vZGUuIFJl cXVpcmVkLikgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEg NjM4LjAyMzYgY20NCnENCkJUIDEgMCAwIDEgMCAzLjUgVG0gMjEgVEwgL0YyIDE3LjUgVGYg MCAwIDAgcmcgKFRoZSBDb25maWcgbm9kZSkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEg NjIuNjkyOTEgNTcyLjAyMzYgY20NCnENCkJUIDEgMCAwIDEgMCA1MCBUbSAxLjI2OTQ2MSBU dyAxMiBUTCAvRjEgMTAgVGYgMCAwIDAgcmcgKEEgY29uZmlnIG5vZGUgaXMgZm9yIGRldGFp bGluZyBhbnkgbW9kdWxlcyB0aGF0IGFyZSBvZiBpbnRlcmVzdCB0byBYZW4gaXRzZWxmLiBG b3IgZXhhbXBsZSB0aGlzIHdvdWxkIGJlKSBUaiBUKiAwIFR3IC4wODU2MSBUdyAod2hlcmUg WGVuIHdvdWxkIGJlIGluZm9ybWVkIG9mIG1pY3JvY29kZSBvciBYU00gcG9saWN5IGxvY2F0 aW9ucy4gSWYgdGhlIG1vZHVsZXMgYXJlIG11bHRpYm9vdCBtb2R1bGVzKSBUaiBUKiAwIFR3 IC42ODQ5ODcgVHcgKGFuZCBhcmUgYWJsZSB0byBiZSBsb2NhdGVkIGJ5IGluZGV4IHdpdGhp biB0aGUgbW9kdWxlIGNoYWluLCB0aGUgKSBUaiAvRjMgMTAgVGYgMCAwIDAgcmcgKG1iLWlu ZGV4ICkgVGogL0YxIDEwIFRmIDAgMCAwIHJnIChwcm9wZXJ0eSBzaG91bGQgYmUgdXNlZCB0 bykgVGogVCogMCBUdyAyLjQ4MTg2IFR3IChzcGVjaWZ5IHRoZSBpbmRleCBpbiB0aGUgbXVs dGlib290IG1vZHVsZSBjaGFpbi4uIElmIHRoZSBtb2R1bGUgd2lsbCBiZSBsb2NhdGVkIGJ5 IHBoeXNpY2FsIG1lbW9yeSkgVGogVCogMCBUdyAoYWRkcmVzcywgdGhlbiB0aGUgKSBUaiAv RjMgMTAgVGYgMCAwIDAgcmcgKG1vZHVsZS1hZGRyICkgVGogL0YxIDEwIFRmIDAgMCAwIHJn IChwcm9wZXJ0eSBzaG91bGQgYmUgdXNlZCB0byBpZGVudGlmeSB0aGUgbG9jYXRpb24gYW5k IHNpemUgb2YgdGhlIG1vZHVsZS4pIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5 MjkxIDU1Ni4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YyIDEw IFRmIDEyIFRMIChjb21wYXRpYmxlKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42 OTI5MSA1NDEuMDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQg MSAwIDAgMSAwIDIgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIwIDAgY20NCnENCjAgMCAwIHJn DQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwgKElkZW50aWZpZXMgdGhlIHR5 cGUgb2Ygbm9kZS4gUmVxdWlyZWQuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAw IDAgMSA2Mi42OTI5MSA1MDguMDIzNiBjbQ0KcQ0KQlQgMSAwIDAgMSAwIDMuNSBUbSAyMSBU TCAvRjIgMTcuNSBUZiAwIDAgMCByZyAoVGhlIERvbWFpbiBub2RlKSBUaiBUKiBFVA0KUQ0K UQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA0NTQuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEg MCAwIDEgMCAzOCBUbSAvRjEgMTAgVGYgMTIgVEwgLjU2OTk4NyBUdyAoQSBkb21haW4gbm9k ZSBpcyBmb3IgZGVzY3JpYmluZyB0aGUgY29uc3RydWN0aW9uIG9mIGEgZG9tYWluLiBJdCBt YXkgcHJvdmlkZSBhIGRvbWlkIHByb3BlcnR5IHdoaWNoIHdpbGwpIFRqIFQqIDAgVHcgLjM3 MTQ4OCBUdyAoYmUgdXNlZCBhcyB0aGUgcmVxdWVzdGVkIGRvbWFpbiBpZCBmb3IgdGhlIGRv bWFpbiB3aXRoIGEgdmFsdWUgb2YgXDIyMzBcMjI0IHNpZ25pZnlpbmcgdG8gdXNlIHRoZSBu ZXh0IGF2YWlsYWJsZSkgVGogVCogMCBUdyAuNTM3MjA5IFR3IChkb21haW4gaWQsIHdoaWNo IGlzIHRoZSBkZWZhdWx0IGJlaGF2aW9yIGlmIG9taXR0ZWQuIEEgZG9tYWluIGNvbmZpZ3Vy YXRpb24gaXMgbm90IGFibGUgdG8gcmVxdWVzdCBhIGRvbWlkKSBUaiBUKiAwIFR3IChvZiBc MjIzMFwyMjQuIEFmdGVyIHRoYXQgYSBkb21haW4gbm9kZSBtYXkgaGF2ZSBhbnkgb2YgdGhl IGZvbGxvd2luZyBwYXJhbWV0ZXJzLCkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIu NjkyOTEgNDM4LjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIg MTAgVGYgMTIgVEwgKGNvbXBhdGlibGUpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYy LjY5MjkxIDQyMy4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpC VCAxIDAgMCAxIDAgMiBUbSAgVCogRVQNCnENCjEgMCAwIDEgMjAgMCBjbQ0KcQ0KMCAwIDAg cmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBUZiAxMiBUTCAoSWRlbnRpZmllcyB0aGUg dHlwZSBvZiBub2RlLiBSZXF1aXJlZC4pIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQox IDAgMCAxIDYyLjY5MjkxIDQwNy4wMjM2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAw IDIgVG0gL0YyIDEwIFRmIDEyIFRMIChkb21pZCkgVGogVCogRVQNClENClENCnENCjEgMCAw IDEgNjIuNjkyOTEgMzkyLjAyMzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwg RVQNCkJUIDEgMCAwIDEgMCAyIFRtICBUKiBFVA0KcQ0KMSAwIDAgMSAyMCAwIGNtDQpxDQow IDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChJZGVudGlmaWVz IHRoZSBkb21pZCByZXF1ZXN0ZWQgdG8gYXNzaWduIHRvIHRoZSBkb21haW4uIFJlcXVpcmVk LikgVGogVCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMzc2LjAy MzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIgVEwg KHBlcm1pc3Npb25zKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAzNDku MDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSAw IDE0IFRtICBUKiBFVA0KcQ0KMSAwIDAgMSAyMCAwIGNtDQpxDQowIDAgMCByZw0KQlQgMSAw IDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAxMiBUTCAxLjA0ODQ0MyBUdyAoVGhpcyBzZXRzIHdo YXQgRGlzY3JldGlvbmFyeSBBY2Nlc3MgQ29udHJvbCBwZXJtaXNzaW9ucyBhIGRvbWFpbiBp cyBhc3NpZ25lZC4gT3B0aW9uYWwsIGRlZmF1bHQgaXMpIFRqIFQqIDAgVHcgKG5vbmUuKSBU aiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAzMzMuMDIzNiBj bQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAoZnVu Y3Rpb25zKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAzMTguMDIzNiBj bQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSAwIDIgVG0g IFQqIEVUDQpxDQoxIDAgMCAxIDIwIDAgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAg MiBUbSAvRjEgMTAgVGYgMTIgVEwgKFRoaXMgaWRlbnRpZmllcyB3aGF0IHN5c3RlbSBmdW5j dGlvbnMgYSBkb21haW4gd2lsbCBmdWxmaWxsLiBPcHRpb25hbCwgdGhlIGRlZmF1bHQgaXMg bm9uZS4pIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDMw Ni4wMjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDIxMS4wMjM2IGNtDQouOTYwNzg0 IC45NjA3ODQgLjg2Mjc0NSByZw0KbiAwIDk1IDQ2OS44ODk4IC05NSByZSBmKg0KMCAwIDAg cmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSA2IDY5IFRtICBUKiBFVA0K cQ0KMSAwIDAgMSAxNiA2NCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyLjUgVG0g L0Y1IDEyLjUgVGYgMTUgVEwgKE5vdGUpIFRqIFQqIEVUDQpRDQpRDQpxDQoxIDAgMCAxIDE2 IDE2IGNtDQpxDQpCVCAxIDAgMCAxIDAgMjYgVG0gNy40NzM5NzYgVHcgMTIgVEwgL0YxIDEw IFRmIDAgMCAwIHJnIChUaGUgKSBUaiAvRjQgMTAgVGYgMCAwIDAgcmcgKGZ1bmN0aW9ucyAp IFRqIC9GMSAxMCBUZiAwIDAgMCByZyAoYml0cyB0aGF0IGhhdmUgYmVlbiBzZWxlY3RlZCB0 byBpbmRpY2F0ZSApIFRqIC9GMyAxMCBUZiAwIDAgMCByZyAoRlVOQ1RJT05fWEVOU1RPUkUg KSBUaiAvRjEgMTAgVGYgMCAwIDAgcmcgKGFuZCkgVGogVCogMCBUdyAuOTg4NTU1IFR3IC9G MyAxMCBUZiAwIDAgMCByZyAoRlVOQ1RJT05fTEVHQUNZX0RPTTAgKSBUaiAvRjEgMTAgVGYg MCAwIDAgcmcgKGFyZSB0aGUgbGFzdCB0d28gYml0cyBcKDMwLCAzMVwpIHN1Y2ggdGhhdCBz aG91bGQgdGhlc2UgZmVhdHVyZXMgZXZlciBiZSkgVGogVCogMCBUdyAoZnVsbHkgcmV0aXJl ZCwgdGhlIGZsYWdzIG1heSBiZSBkcm9wcGVkIHdpdGhvdXQgbGVhdmluZyBhIGdhcCBpbiB0 aGUgZmxhZyBzZXQuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSBKDQoxIGoNCi42NjI3NDUgLjY2 Mjc0NSAuNjYyNzQ1IFJHDQouNSB3DQpuIDAgOTUgbSA0NjkuODg5OCA5NSBsIFMNCm4gMCAw IG0gNDY5Ljg4OTggMCBsIFMNCm4gMCAwIG0gMCA5NSBsIFMNCm4gNDY5Ljg4OTggMCBtIDQ2 OS44ODk4IDk1IGwgUw0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAyMDUuMDIzNiBjbQ0K UQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAxODkuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEg MCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAobW9kZSkgVGogVCogRVQNClENClENCnEN CjEgMCAwIDEgNjIuNjkyOTEgMTc0LjAyMzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYg MTIgVEwgRVQNCkJUIDEgMCAwIDEgMCAyIFRtICBUKiBFVA0KcQ0KMSAwIDAgMSAyMCAwIGNt DQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRmIDEyIFRMIChUaGUg bW9kZSB0aGUgZG9tYWluIHdpbGwgYmUgZXhlY3V0ZWQgdW5kZXIuIFJlcXVpcmVkLikgVGog VCogRVQNClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMTU4LjAyMzYgY20N CnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIgVEwgKGRvbWFp bi11dWlkKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAxNDMuMDIzNiBj bQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSAwIDIgVG0g IFQqIEVUDQpxDQoxIDAgMCAxIDIwIDAgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAg MiBUbSAvRjEgMTAgVGYgMTIgVEwgKEEgZ2xvYmFsbHkgdW5pcXVlIGlkZW50aWZpZXIgZm9y IHRoZSBkb21haW4uIE9wdGlvbmFsLCB0aGUgZGVmYXVsdCBpcyBOVUxMLikgVGogVCogRVQN ClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgMTI3LjAyMzYgY20NCnENCjAg MCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIgVEwgKGNwdXMpIFRqIFQq IEVUDQpRDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDExMi4wMjM2IGNtDQowIDAgMCByZw0K QlQgL0YxIDEwIFRmIDEyIFRMIEVUDQpCVCAxIDAgMCAxIDAgMiBUbSAgVCogRVQNCnENCjEg MCAwIDEgMjAgMCBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMSAxMCBU ZiAxMiBUTCAoVGhlIG51bWJlciBvZiB2Q1BVcyB0byBiZSBhc3NpZ25lZCB0byB0aGUgZG9t YWluLiBPcHRpb25hbCwgdGhlIGRlZmF1bHQgaXMgXDIyMzFcMjI0LikgVGogVCogRVQNClEN ClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgOTYuMDIzNjIgY20NCnENCjAgMCAw IHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIgVEwgKG1lbW9yeSkgVGogVCog RVQNClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgODEuMDIzNjIgY20NCjAgMCAwIHJnDQpC VCAvRjEgMTAgVGYgMTIgVEwgRVQNCkJUIDEgMCAwIDEgMCAyIFRtICBUKiBFVA0KcQ0KMSAw IDAgMSAyMCAwIGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDIgVG0gL0YxIDEwIFRm IDEyIFRMIChUaGUgYW1vdW50IG9mIG1lbW9yeSB0byBhc3NpZ24gdG8gdGhlIGRvbWFpbiwg aW4gS0JzLiBSZXF1aXJlZC4pIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQogDQplbmRzdHJl YW0NCmVuZG9iag0KMzEgMCBvYmoNCjw8IC9MZW5ndGggMzcyMSA+Pg0Kc3RyZWFtDQoxIDAg MCAxIDAgMCBjbSAgQlQgL0YxIDEyIFRmIDE0LjQgVEwgRVQNCnENCjEgMCAwIDEgNjIuNjky OTEgNzUzLjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAg VGYgMTIgVEwgKHNlY3VyaXR5LWlkKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42 OTI5MSA3MjYuMDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQg MSAwIDAgMSAwIDE0IFRtICBUKiBFVA0KcQ0KMSAwIDAgMSAyMCAwIGNtDQpxDQowIDAgMCBy Zw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9GMSAxMCBUZiAxMiBUTCAuMjU4NzM1IFR3IChUaGUg c2VjdXJpdHkgaWRlbnRpdHkgdG8gYmUgYXNzaWduZWQgdG8gdGhlIGRvbWFpbiB3aGVuIFhT TSBpcyB0aGUgYWNjZXNzIGNvbnRyb2wgbWVjaGFuaXNtIGJlaW5nKSBUaiBUKiAwIFR3ICh1 c2VkLiBPcHRpb25hbCwgdGhlIGRlZmF1bHQgaXMgXDIyM2RvbXVfdFwyMjQuKSBUaiBUKiBF VA0KUQ0KUQ0KcQ0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA2OTMuMDIzNiBjbQ0KcQ0K QlQgMSAwIDAgMSAwIDMuNSBUbSAyMSBUTCAvRjIgMTcuNSBUZiAwIDAgMCByZyAoVGhlIE1v ZHVsZSBub2RlKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA2MjcuMDIz NiBjbQ0KcQ0KQlQgMSAwIDAgMSAwIDUwIFRtIC44Mjk5ODQgVHcgMTIgVEwgL0YxIDEwIFRm IDAgMCAwIHJnIChUaGlzIG5vZGUgZGVzY3JpYmVzIGEgYm9vdCBtb2R1bGUgbG9hZGVkIGJ5 IHRoZSBib290IGxvYWRlci4gVGhlIHJlcXVpcmVkIGNvbXBhdGlibGUgcHJvcGVydHkgZm9s bG93cykgVGogVCogMCBUdyAuNDgzNjE1IFR3ICh0aGUgZm9ybWF0OiBtb2R1bGUsKSBUaiAo PCkgVGogKHR5cGUpIFRqICg+IHdoZXJlIHR5cGUgY2FuIGJlIFwyMjNrZXJuZWxcMjI0LCBc MjIzcmFtZGlza1wyMjQsIFwyMjNkZXZpY2UtdHJlZVwyMjQsIFwyMjNtaWNyb2NvZGVcMjI0 LCBcMjIzeHNtLXBvbGljeVwyMjQpIFRqIFQqIDAgVHcgLjIzODY1MSBUdyAob3IgXDIyM2Nv bmZpZ1wyMjQuIEluIHRoZSBjYXNlIHRoZSBtb2R1bGUgaXMgYSBtdWx0aWJvb3QgbW9kdWxl LCB0aGUgYWRkaXRpb25hbCBwcm9wZXJ0eSBzdHJpbmcgXDIyM211bHRpYm9vdCxtb2R1bGVc MjI0KSBUaiBUKiAwIFR3IC43MjIyMDkgVHcgKG1heSBiZSBwcmVzZW50LiBPbmUgb2YgdHdv IHByb3BlcnRpZXMgaXMgcmVxdWlyZWQgYW5kIGlkZW50aWZpZXMgaG93IHRvIGxvY2F0ZSB0 aGUgbW9kdWxlLiBUaGV5IGFyZSB0aGUpIFRqIFQqIDAgVHcgKG1iLWluZGV4LCB1c2VkIGZv ciBtdWx0aWJvb3QgbW9kdWxlcywgYW5kIHRoZSBtb2R1bGUtYWRkciBmb3IgbWVtb3J5IGFk ZHJlc3MgYmFzZWQgbG9jYXRpb24uKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42 OTI5MSA2MTEuMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAwIDEgMCAyIFRtIC9GMiAx MCBUZiAxMiBUTCAoY29tcGF0aWJsZSkgVGogVCogRVQNClENClENCnENCjEgMCAwIDEgNjIu NjkyOTEgNTg0LjAyMzYgY20NCjAgMCAwIHJnDQpCVCAvRjEgMTAgVGYgMTIgVEwgRVQNCkJU IDEgMCAwIDEgMCAxNCBUbSAgVCogRVQNCnENCjEgMCAwIDEgMjAgMCBjbQ0KcQ0KMCAwIDAg cmcNCkJUIDEgMCAwIDEgMCAxNCBUbSAvRjEgMTAgVGYgMTIgVEwgMS40NzM3MzUgVHcgKFRo aXMgaWRlbnRpZmllcyB3aGF0IHRoZSBtb2R1bGUgaXMgYW5kIHRodXMgd2hhdCB0aGUgaHlw ZXJ2aXNvciBzaG91bGQgdXNlIHRoZSBtb2R1bGUgZm9yIGR1cmluZykgVGogVCogMCBUdyAo ZG9tYWluIGNvbnN0cnVjdGlvbi4gUmVxdWlyZWQuKSBUaiBUKiBFVA0KUQ0KUQ0KcQ0KUQ0K UQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA1NjguMDIzNiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEg MCAwIDEgMCAyIFRtIC9GMiAxMCBUZiAxMiBUTCAobWItaW5kZXgpIFRqIFQqIEVUDQpRDQpR DQpxDQoxIDAgMCAxIDYyLjY5MjkxIDU0MS4wMjM2IGNtDQowIDAgMCByZw0KQlQgL0YxIDEw IFRmIDEyIFRMIEVUDQpCVCAxIDAgMCAxIDAgMTQgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIw IDAgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMTQgVG0gL0YxIDEwIFRmIDEyIFRM IDIuODc2NDEyIFR3IChUaGlzIGlkZW50aWZpZXMgdGhlIGluZGV4IGZvciB0aGlzIG1vZHVs ZSBpbiB0aGUgbXVsdGlib290IG1vZHVsZSBjaGFpbi4gUmVxdWlyZWQgZm9yIG11bHRpYm9v dCkgVGogVCogMCBUdyAoZW52aXJvbm1lbnRzLikgVGogVCogRVQNClENClENCnENClENClEN CnENCjEgMCAwIDEgNjIuNjkyOTEgNTI1LjAyMzYgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAg MCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIgVEwgKG1vZHVsZS1hZGRyKSBUaiBUKiBFVA0KUQ0K UQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA1MTAuMDIzNiBjbQ0KMCAwIDAgcmcNCkJUIC9GMSAx MCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSAwIDIgVG0gIFQqIEVUDQpxDQoxIDAgMCAxIDIw IDAgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEgMTAgVGYgMTIgVEwg KFRoaXMgaWRlbnRpZmllcyB3aGVyZSBpbiBtZW1vcnkgdGhpcyBtb2R1bGUgaXMgbG9jYXRl ZC4gUmVxdWlyZWQgZm9yIG5vbi1tdWx0aWJvb3QgZW52aXJvbm1lbnRzLikgVGogVCogRVQN ClENClENCnENClENClENCnENCjEgMCAwIDEgNjIuNjkyOTEgNDk0LjAyMzYgY20NCnENCjAg MCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjIgMTAgVGYgMTIgVEwgKGJvb3RhcmdzKSBU aiBUKiBFVA0KUQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSA0NzkuMDIzNiBjbQ0KMCAwIDAg cmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSAwIDIgVG0gIFQqIEVUDQpx DQoxIDAgMCAxIDIwIDAgY20NCnENCjAgMCAwIHJnDQpCVCAxIDAgMCAxIDAgMiBUbSAvRjEg MTAgVGYgMTIgVEwgKFRoaXMgaXMgdXNlZCB0byBwcm92aWRlIHRoZSBib290IHBhcmFtcyB0 byBrZXJuZWwgbW9kdWxlcy4pIFRqIFQqIEVUDQpRDQpRDQpxDQpRDQpRDQpxDQoxIDAgMCAx IDYyLjY5MjkxIDQ2Ny4wMjM2IGNtDQpRDQpxDQoxIDAgMCAxIDYyLjY5MjkxIDM4NC4wMjM2 IGNtDQouOTYwNzg0IC45NjA3ODQgLjg2Mjc0NSByZw0KbiAwIDgzIDQ2OS44ODk4IC04MyBy ZSBmKg0KMCAwIDAgcmcNCkJUIC9GMSAxMCBUZiAxMiBUTCBFVA0KQlQgMSAwIDAgMSA2IDU3 IFRtICBUKiBFVA0KcQ0KMSAwIDAgMSAxNiA1MiBjbQ0KcQ0KMCAwIDAgcmcNCkJUIDEgMCAw IDEgMCAyLjUgVG0gL0Y1IDEyLjUgVGYgMTUgVEwgKE5vdGUpIFRqIFQqIEVUDQpRDQpRDQpx DQoxIDAgMCAxIDE2IDE2IGNtDQpxDQowIDAgMCByZw0KQlQgMSAwIDAgMSAwIDE0IFRtIC9G MSAxMCBUZiAxMiBUTCAuODI3ODQgVHcgKFRoZSBib290YXJncyBwcm9wZXJ0eSBpcyBpbnRl bmRlZCBmb3Igc2l0dWF0aW9ucyB3aGVyZSB0aGUgc2FtZSBrZXJuZWwgbXVsdGlib290IG1v ZHVsZSBpcyB1c2VkKSBUaiBUKiAwIFR3IChmb3IgbW9yZSB0aGFuIG9uZSBkb21haW4uKSBU aiBUKiBFVA0KUQ0KUQ0KcQ0KMSBKDQoxIGoNCi42NjI3NDUgLjY2Mjc0NSAuNjYyNzQ1IFJH DQouNSB3DQpuIDAgODMgbSA0NjkuODg5OCA4MyBsIFMNCm4gMCAwIG0gNDY5Ljg4OTggMCBs IFMNCm4gMCAwIG0gMCA4MyBsIFMNCm4gNDY5Ljg4OTggMCBtIDQ2OS44ODk4IDgzIGwgUw0K UQ0KUQ0KcQ0KMSAwIDAgMSA2Mi42OTI5MSAzNzguMDIzNiBjbQ0KUQ0KIA0KZW5kc3RyZWFt DQplbmRvYmoNCjMyIDAgb2JqDQo8PCAvTnVtcyBbIDAgMzMgMCBSIDEgMzQgMCBSIDIgMzUg MCBSIDMgMzYgMCBSIDQgMzcgMCBSIA0KICA1IDM4IDAgUiA2IDM5IDAgUiBdID4+DQplbmRv YmoNCjMzIDAgb2JqDQo8PCAvUyAvRCAvU3QgMSA+Pg0KZW5kb2JqDQozNCAwIG9iag0KPDwg L1MgL0QgL1N0IDIgPj4NCmVuZG9iag0KMzUgMCBvYmoNCjw8IC9TIC9EIC9TdCAzID4+DQpl bmRvYmoNCjM2IDAgb2JqDQo8PCAvUyAvRCAvU3QgNCA+Pg0KZW5kb2JqDQozNyAwIG9iag0K PDwgL1MgL0QgL1N0IDUgPj4NCmVuZG9iag0KMzggMCBvYmoNCjw8IC9TIC9EIC9TdCA2ID4+ DQplbmRvYmoNCjM5IDAgb2JqDQo8PCAvUyAvRCAvU3QgNyA+Pg0KZW5kb2JqDQp4cmVmDQow IDQwDQowMDAwMDAwMDAwIDY1NTM1IGYNCjAwMDAwMDAwNzUgMDAwMDAgbg0KMDAwMDAwMDE1 MCAwMDAwMCBuDQowMDAwMDAwMjYwIDAwMDAwIG4NCjAwMDAwMDAzNzUgMDAwMDAgbg0KMDAw MDAwMDQ4MyAwMDAwMCBuDQowMDAwMDAwNjkyIDAwMDAwIG4NCjAwMDAwMDA5MDEgMDAwMDAg bg0KMDAwMDAwMTExMCAwMDAwMCBuDQowMDAwMDAxMzE5IDAwMDAwIG4NCjAwMDAwMDE0Mzcg MDAwMDAgbg0KMDAwMDAwMTY0NyAwMDAwMCBuDQowMDAwMDAxNzcwIDAwMDAwIG4NCjAwMDAw MDE5ODAgMDAwMDAgbg0KMDAwMDAwMjE5MCAwMDAwMCBuDQowMDAwMDAyMjk5IDAwMDAwIG4N CjAwMDAwMDI1OTcgMDAwMDAgbg0KMDAwMDAwMjY3NCAwMDAwMCBuDQowMDAwMDAyODM5IDAw MDAwIG4NCjAwMDAwMDI5NzEgMDAwMDAgbg0KMDAwMDAwMzEwMCAwMDAwMCBuDQowMDAwMDAz MjM3IDAwMDAwIG4NCjAwMDAwMDMzNzAgMDAwMDAgbg0KMDAwMDAwMzUwMyAwMDAwMCBuDQow MDAwMDAzNjIzIDAwMDAwIG4NCjAwMDAwMDM3MjUgMDAwMDAgbg0KMDAwMDAwNTk5NSAwMDAw MCBuDQowMDAwMDA4NTQzIDAwMDAwIG4NCjAwMDAwMTM2MDkgMDAwMDAgbg0KMDAwMDAxNjA4 OCAwMDAwMCBuDQowMDAwMDIxNTU5IDAwMDAwIG4NCjAwMDAwMjg0NzAgMDAwMDAgbg0KMDAw MDAzMjI0OCAwMDAwMCBuDQowMDAwMDMyMzUwIDAwMDAwIG4NCjAwMDAwMzIzODcgMDAwMDAg bg0KMDAwMDAzMjQyNCAwMDAwMCBuDQowMDAwMDMyNDYxIDAwMDAwIG4NCjAwMDAwMzI0OTgg MDAwMDAgbg0KMDAwMDAzMjUzNSAwMDAwMCBuDQowMDAwMDMyNTcyIDAwMDAwIG4NCnRyYWls ZXINCjw8IC9JRCANCiAlIFJlcG9ydExhYiBnZW5lcmF0ZWQgUERGIGRvY3VtZW50IC0tIGRp Z2VzdCAoaHR0cDovL3d3dy5yZXBvcnRsYWIuY29tKQ0KIFsoI1wwMDZoa1wyMjJcMjI3XDIw N1wyNjJcMzQ0fVwzMjNcMzY1SCxGXDI0NSkgKCNcMDA2aGtcMjIyXDIyN1wyMDdcMjYyXDM0 NH1cMzIzXDM2NUgsRlwyNDUpXQ0KIC9JbmZvIDE1IDAgUiAvUm9vdCAxNCAwIFIgL1NpemUg NDAgPj4NCnN0YXJ0eHJlZg0KMzI2MDkNCiUlRU9GDQo= --------------DEE995035C8380D8C0329228-- From xen-devel-bounces@lists.xenproject.org Tue Mar 16 04:10:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 04:10:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98185.186184 (Exim 4.92) (envelope-from ) id 1lM11r-0001ol-6q; Tue, 16 Mar 2021 04:09:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98185.186184; Tue, 16 Mar 2021 04:09:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM11r-0001oe-2E; Tue, 16 Mar 2021 04:09:59 +0000 Received: by outflank-mailman (input) for mailman id 98185; Tue, 16 Mar 2021 04:09:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM11p-0001oZ-OX for xen-devel@lists.xen.org; Tue, 16 Mar 2021 04:09:57 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8319066c-6599-4f2b-a213-d71227e16644; Tue, 16 Mar 2021 04:09:56 +0000 (UTC) Received: from [10.10.1.24] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1615867780086180.53138227604438; Mon, 15 Mar 2021 21:09:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8319066c-6599-4f2b-a213-d71227e16644 ARC-Seal: i=1; a=rsa-sha256; t=1615867783; cv=none; d=zohomail.com; s=zohoarc; b=IglvTLeIPX3ueH5OK3zWZvBTPMb4Nh/QPEjt6b5dRemjX3J+24zrzw5Zx+TFURBEi7OlDI2WRLaB0G1o+3RoA0+gWXnwxf77vRYtDQnZ0AbhvDVqEXGKzE8VsV4Xg0FZbxsvpryvw1XnLqZRX77naB/IeN0BCFqEbAxu/IwLDH8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615867783; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=ErJk0DpONtsisG//WqPXEOOXFvbjn4LxdxKfTINfx1M=; b=dRaSEe2rvIHdbi5bVWxSL76QPUArpKEobcMTzSK4mxajsMnXLXTLVQnoolnh1qtP1vFjYWIzkcD/HuJpuv5wHLeurkz2zl/zvjBLgG4srQxofKc51NeKWW4C+Ig7GTEBeb77lTUIzJ9oiy1sXe2gq3RAd9ZGcSpjw4wMOfvQpXQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1615867783; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=To:From:Cc:Message-ID:Subject:Date:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=ErJk0DpONtsisG//WqPXEOOXFvbjn4LxdxKfTINfx1M=; b=tARHFBELEkTmt3zRu1fIGo+lI/8FyzkAWdZhLHqKslNrNZgIr3X5+a5BMKVZdSNm LbPBbj+hOvtfwMgQqEn/+bX1hXk4k9p6Jtgm/G22aD1Xc6B5ZhsvOHum/41y344hpvs uVbfJtmbFm9aid3R0Miz0KGiOh3aHS5t6CNU90is= To: Xen-devel From: "Daniel P. Smith" Cc: christopher.w.clark@gmail.com, stefano.stabellini@xilinx.com, jgrall@amazon.com, iwj@xenproject.org, wl@xen.org, george.dunlap@citrix.com, jbeulich@suse.com, persaur@gmail.com, bertrand.marquis@arm.com, roger.pau@citrix.com, luca.fancellu@arm.com, adam.schwalm@starlab.io, Andrew Cooper , paul@xen.org Message-ID: <2e7213c1-e01c-9d9d-3ac1-3086eb6889e5@apertussolutions.com> Subject: Working Group Meeting for hyperlaunch Date: Tue, 16 Mar 2021 00:09:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External All, We have posted[1][2] the design documents for hyperlaunch and would invite attendance at a working group call to discuss two agenda items. The first item is a review of the documents and the second is a discussion about bringing production-ready revisions of our previous prototype in as patches to provide a near-term implementation of the design. If possible please join us this Thursday 3/18 at 1700CET/1600GMT/1200EDT/0900PDT. Below are the call details. [1] https://lists.xenproject.org/archives/html/xen-devel/2021-03/msg00939.html [2] https://lists.xenproject.org/archives/html/xen-devel/2021-03/pdfCV4LaWCrTN.= pdf Call Details: Daniel Smith's Meeting Please join my meeting from your computer, tablet or smartphone. https://www.gotomeet.me/apertussolutions You can also dial in using your phone. (For supported devices, tap a one-touch number below to join instantly.) United States (Toll Free): 1 877 568 4106 - One-touch: tel:+18775684106,,691818141# Access Code: 691-818-141 More phone numbers: (For supported devices, tap a one-touch number below to join instantly.) Austria (Toll Free): 0 800 202148 - One-touch: tel:+43800202148,,691818141# Belarus (Toll Free): 8 820 0011 0400 - One-touch: tel:+37582000110400,,691818141# Belgium (Toll Free): 0 800 78884 - One-touch: tel:+3280078884,,691818141# Bulgaria (Toll Free): 00800 120 4417 - One-touch: tel:+3598001204417,,691818141# Canada (Toll Free): 1 888 455 1389 - One-touch: tel:+18884551389,,691818141# China (Toll Free): 4000 762962 - One-touch: tel:+864000762962,,691818141# Czech Republic (Toll Free): 800 500448 - One-touch: tel:+420800500448,,691818141# Denmark (Toll Free): 8025 3126 - One-touch: tel:+4580253126,,691818141# Finland (Toll Free): 0 800 917656 - One-touch: tel:+358800917656,,691818141# France (Toll Free): 0 805 541 047 - One-touch: tel:+33805541047,,691818141# Germany (Toll Free): 0 800 184 4222 - One-touch: tel:+498001844222,,691818141# Greece (Toll Free): 00 800 4414 3838 - One-touch: tel:+3080044143838,,691818141# Hungary (Toll Free): (06) 80 986 255 - One-touch: tel:+3680986255,,691818141# Iceland (Toll Free): 800 7204 - One-touch: tel:+3548007204,,691818141# India (Toll Free): 18002669254 - One-touch: tel:18002669254,,691818141# Ireland (Toll Free): 1 800 901 610 - One-touch: tel:+3531800901610,,691818141# Italy (Toll Free): 800 793887 - One-touch: tel:800793887,,691818141# Netherlands (Toll Free): 0 800 020 0182 - One-touch: tel:+318000200182,,691818141# Norway (Toll Free): 800 69 046 - One-touch: tel:+4780069046,,691818141# Poland (Toll Free): 00 800 1124759 - One-touch: tel:+488001124759,,691818141# Portugal (Toll Free): 800 819 575 - One-touch: tel:+351800819575,,691818141# Romania (Toll Free): 0 800 400 819 - One-touch: tel:+40800400819,,691818141# Slovakia (Toll Free): 0 800 105 748 - One-touch: tel:+421800105748,,691818141# Spain (Toll Free): 800 900 582 - One-touch: tel:+34800900582,,691818141# Sweden (Toll Free): 0 200 330 905 - One-touch: tel:+46200330905,,691818141# Switzerland (Toll Free): 0 800 002 348 - One-touch: tel:+41800002348,,691818141# Ukraine (Toll Free): 0 800 60 9135 - One-touch: tel:+380800609135,,691818141# United Kingdom (Toll Free): 0 800 169 0432 - One-touch: tel:+448001690432,,691818141# New to GoToMeeting? Get the app now and be ready when your first meeting starts: https://global.gotomeeting.com/install/691818141 From xen-devel-bounces@lists.xenproject.org Tue Mar 16 04:48:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 04:48:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98188.186196 (Exim 4.92) (envelope-from ) id 1lM1cX-0005Ua-71; Tue, 16 Mar 2021 04:47:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98188.186196; Tue, 16 Mar 2021 04:47:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM1cX-0005UT-23; Tue, 16 Mar 2021 04:47:53 +0000 Received: by outflank-mailman (input) for mailman id 98188; Tue, 16 Mar 2021 04:47:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM1cV-0005UJ-Iy; Tue, 16 Mar 2021 04:47:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM1cV-0002Z7-Co; Tue, 16 Mar 2021 04:47:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM1cV-0004Ls-04; Tue, 16 Mar 2021 04:47:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lM1cU-0002bn-Vn; Tue, 16 Mar 2021 04:47:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9L+E7f42FpViWLcPlV8WKrJGpl3CDFbW5XfGlDgYk7E=; b=YPd0eUzdsPVYgYNItsJ51mXfYd WZWm3Q7v/bRmkh6lBaxCb6ONjk0RLGhvi8BQ+YLxdZNVhHaFQgvCE7buVVix0GYcuYhHjaVeQ6mcY L/teThaUdZYW4+uAkEmaZj+Zcf7r3k+MUwSGgo2pnuzKbvQ4fdmT/i2PyuLUWduIT054=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160090: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1e28eed17697bcf343c6743f0028cc3b5dd88bf0 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Tue, 16 Mar 2021 04:47:50 +0000 flight 160090 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160090/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: linux 1e28eed17697bcf343c6743f0028cc3b5dd88bf0 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 227 days Failing since 152366 2020-08-01 20:49:34 Z 226 days 393 attempts Testing same since 160084 2021-03-15 03:13:23 Z 1 days 2 attempts ------------------------------------------------------------ 5213 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1293527 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 16 05:58:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 05:58:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98196.186211 (Exim 4.92) (envelope-from ) id 1lM2iY-0003VR-Ey; Tue, 16 Mar 2021 05:58:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98196.186211; Tue, 16 Mar 2021 05:58:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM2iY-0003VK-BV; Tue, 16 Mar 2021 05:58:10 +0000 Received: by outflank-mailman (input) for mailman id 98196; Tue, 16 Mar 2021 05:58:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM2iW-0003VC-Qp; Tue, 16 Mar 2021 05:58:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM2iW-0003zg-Hs; Tue, 16 Mar 2021 05:58:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM2iW-0007cO-41; Tue, 16 Mar 2021 05:58:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lM2iW-0000D2-3Z; Tue, 16 Mar 2021 05:58:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=k+Mgm9GNKhZBXZ5MaMOdphtPv62usxkYpbdjrya1tHM=; b=ajEbdZ4cn+0pOz8XthaPZQyVcu N9dLkwyiZZMPhq0hJVItivfFtd3TMycQXEU/o1jYV4nNUv9ZHmJUcOT+hmMtO519yIpd8T/poBkfJ s0lsZch9rVc/j1J2EKX6XbxMiUBtyTKzg58Xff4FJfduwYuUwgqbzUBSov+UwaYfP7U0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160093: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=53454b7b346794fb564bae587af0ccbf63514b7c X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 16 Mar 2021 05:58:08 +0000 flight 160093 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160093/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 53454b7b346794fb564bae587af0ccbf63514b7c baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 249 days Failing since 151818 2020-07-11 04:18:52 Z 248 days 241 attempts Testing same since 160093 2021-03-16 04:19:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 47553 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 16 07:51:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 07:51:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98207.186228 (Exim 4.92) (envelope-from ) id 1lM4UN-0005aN-QU; Tue, 16 Mar 2021 07:51:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98207.186228; Tue, 16 Mar 2021 07:51:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM4UN-0005aG-NB; Tue, 16 Mar 2021 07:51:39 +0000 Received: by outflank-mailman (input) for mailman id 98207; Tue, 16 Mar 2021 07:51:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM4UM-0005aB-BL for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 07:51:38 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6c7e8aef-c616-45ff-9a6e-1d7bda322d57; Tue, 16 Mar 2021 07:51:37 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2D4FFAC5C; Tue, 16 Mar 2021 07:51:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c7e8aef-c616-45ff-9a6e-1d7bda322d57 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615881096; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cCt8X04kFCPL+HlbEF40rUayFBIytXBEXXO2B+QHQEU=; b=uMKzE/xsTprjGrjeak+TacSyTgP79ZdpfmvitwGDXkqFJRX4vdo5A9EAOLieYAITZlVJWr 9iOsgfMNzy34Bj0mMyjIabnUMrv066Y2CgGAn3JA7nWZhWZuzLV0PpR/a9qbhxz2bRyPvf soNIYGPqBqGg+plOrJOmFSOL18z+t1I= Subject: Re: [PATCH v3] xen: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped To: Stefano Stabellini Cc: andrew.cooper3@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, Stefano Stabellini , xen-devel@lists.xenproject.org References: <20210312231632.5666-1-sstabellini@kernel.org> <0e35a613-fd93-0805-10b9-5ecee73bb15d@suse.com> From: Jan Beulich Message-ID: <48a7ea93-06b4-21f1-5db2-0104058a2446@suse.com> Date: Tue, 16 Mar 2021 08:51:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 15.03.2021 21:01, Stefano Stabellini wrote: > On Mon, 15 Mar 2021, Jan Beulich wrote: >> On 13.03.2021 00:16, Stefano Stabellini wrote: >>> Introduce two feature flags to tell the domain whether it is >>> direct-mapped or not. It allows the guest kernel to make informed >>> decisions on things such as swiotlb-xen enablement. >>> >>> The introduction of both flags (XENFEAT_direct_mapped and >>> XENFEAT_not_direct_mapped) allows the guest kernel to avoid any >>> guesswork if one of the two is present, or fallback to the current >>> checks if neither of them is present. >>> >>> XENFEAT_direct_mapped is always set for not auto-translated guests. >>> >>> For auto-translated guests, only Dom0 on ARM is direct-mapped. Also, >>> see is_domain_direct_mapped() which refers to auto-translated guests: >>> xen/include/asm-arm/domain.h:is_domain_direct_mapped >>> xen/include/asm-x86/domain.h:is_domain_direct_mapped >>> >>> Signed-off-by: Stefano Stabellini >>> CC: jbeulich@suse.com >>> CC: andrew.cooper3@citrix.com >>> CC: julien@xen.org >> >> Any particular reason my previously given R-b isn't here? > > I reworded part of the comment in the public header, and I decided to > err on the side of caution and not add your R-b given this change > compared to the previous version. I see. FAOD, despite me not being overly happy with the "older Xen assumptions" part of the comment, feel free to add it back. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 16 08:02:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 08:02:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98217.186240 (Exim 4.92) (envelope-from ) id 1lM4eo-0007Al-2g; Tue, 16 Mar 2021 08:02:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98217.186240; Tue, 16 Mar 2021 08:02:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM4en-0007Ae-W2; Tue, 16 Mar 2021 08:02:25 +0000 Received: by outflank-mailman (input) for mailman id 98217; Tue, 16 Mar 2021 08:02:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM4em-0007AZ-B9 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 08:02:24 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3008581c-28c7-460b-9d96-3288052e0b05; Tue, 16 Mar 2021 08:02:23 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8730AAC1F; Tue, 16 Mar 2021 08:02:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3008581c-28c7-460b-9d96-3288052e0b05 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615881742; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M2jUnwx30oLup+3RF6idd9C+gHMgvw06OY6GSdwq9n4=; b=Tsclj9QDv8yGsn0KqH4ftv9Aw1GoGHyf4ZJEzBCLXANbPadxf329KDsNCw5S/DJZ6g/0/X 9stKCug9IdqI+Fq6Ez5MZid4MDTjNLqlVHh3fPoCYFt4sbTz6ZtSphPiQ/OzX+8Xl+ZYVC Seit5z6zQzstA89Ak/UkiKm92lRxk/4= Subject: Re: Ryzen 4000 (Mobile) Softlocks/Micro-stutters To: Dylanger Daly Cc: Andrew Cooper , "xen-devel@lists.xenproject.org" , Dario Faggioli References: <9lQU_gCfRzGyyNb2j86pxTMi1IET1Iq7iK3994agUZPrTI5Xd-aCJAaRYuJlD3L5LT2WaV4N3-YF4xKl5ukialT0M_YD0ve6gmDFFfatpXw=@protonmail.com> <2cc5da3e-0ad0-4647-f1ca-190788c2910b@citrix.com> <3pKjdPYCiRimYjqHQP0xd_vqhoTOJqthTXOrY_rLeNvnQEpIF24gXDKgRhmr95JfARJzbVJVbfTrrJeiovGVHGbV0QBSZ2jez2Y_wt6db7g=@protonmail.com> <768d9dbb-4387-099f-b489-7952d7e883b0@suse.com> <815f3bc3a28a165e8fa41c6954a6d00db656e3c3.camel@suse.com> <1fc0e850-8a08-760f-c8cb-ad73dda4a37b@suse.com> From: Jan Beulich Message-ID: <4916dec1-1bb9-7e6f-2fe5-577bbab92861@suse.com> Date: Tue, 16 Mar 2021 09:02:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 16.03.2021 03:10, Dylanger Daly wrote: > I just wanted to close this off and let everyone know the issue ended up being a faulty/misconfigured HPET clock. > > Appending `clocksource=tsc tsc=unstable hpetbroadcast=0` to Xen's CMDLINE totally fixed my issue, I assume Xen was detecting TSC may have been 'off' and was trying to recover/self-correct? I find this a very confusing combination of command line options. In particular "tsc=unstable" clears one of the feature prereqs (TSC_RELIABLE) that are required for "clocksource=tsc" to take any effect, afaict. I therefore would conclude that you're not actually running with TSC as the clock source. Did you check the hypervisor log (which might prove me wrong)? Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 16 08:49:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 08:49:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98224.186253 (Exim 4.92) (envelope-from ) id 1lM5OT-0002T3-Mk; Tue, 16 Mar 2021 08:49:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98224.186253; Tue, 16 Mar 2021 08:49:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM5OT-0002Sw-JX; Tue, 16 Mar 2021 08:49:37 +0000 Received: by outflank-mailman (input) for mailman id 98224; Tue, 16 Mar 2021 08:49:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM5OR-0002Sr-Jw for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 08:49:35 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9678c398-dd82-42a4-81f7-aaf8c851609c; Tue, 16 Mar 2021 08:49:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9678c398-dd82-42a4-81f7-aaf8c851609c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615884574; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=mBbFwb/KuX2+Y3vs3c/wXzZRoZx5HgEYfOjFVqwiukw=; b=c2tLsxov1Pd8DEfr9lWBZDa1ZD7lS+v0nSSMNKWFZkwwHJycw2rXnWRi AtYz+5e7jh+kBSPeVdNdiVLyjz814DltYAtX4nQU9BpWgInQGDJGA2Kx4 wC5s/pNx2ny6lubzk5ZBV4pMPgmS3bp0Q3f3vPjqaOyB8ttfAlKrKJb6m 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: QtGgo7M/W94/eKqoszkiTa9+QPQlMCTCM023F+aPh3DkNGC0k3PKcA7RXzB2k1l0/Emsb72wlZ BVfIMVy5FScgxuOGc4hRdlaRjMEo+6J9Nzx9fEGiVPLbhwrOo3xjW9lW3nDmP+tXaFtz+WZHMy x6PBKcQ/hrakyifnR8Za3nsr2ata/tSuz86vBWkZnwVyFRslL0yYffjNAZrA252cHB4VLcUuuB zWAo4k/3YUQkeV36Oo8xYxV3LZaX5Wj2qLCKc0ZjDXlWPbCcU9fSRttWWqBwsDiv9wMwsskceu dmE= X-SBRS: 5.2 X-MesageID: 39540860 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:tjnme6w90dgo5ZtTXqUZKrPxsO4kLtp033Aq2lEZdDV8Sebdv9 yynfgdyB//gCsQXnZlotybJKycWxrnmqJdybI6eZOvRhPvtmftFoFt6oP+3ybtcheTysd07o 0lSaR3DbTLYGRSpdrm4QW+DtYryMSG9qftvuvF03JxV2hRCp1IxS0RMHf9LmRdQg5aCZ0lUL ed/NNAvTq8eXIRB/7LfEUtde7FutHNidbaehYAHREq802jijmv5b78HXGjr2ojehlIxqov9n WArhzh6syYwoqG4zL/90uW1ZRZn9P91sBObfbjtuE5Iijh4zzYBrhJdKaFuFkO0YSSwXYs1O LBuhIxe/l0gkmhAl2dhTvI903e3C0163nkoGXo8UfLhcDiXjo1B45gqOtiA2LkwnEttt19z6 5Htljx3/E8bWKi7VbAzuPFWB1wmk2/rWBKq59qs1VlXZYDc7gUlIQD/SpuYeY9NRjn44MqGv QGNrC72N9qdzqhHhTkl1gq6tmtUnMvJwyBU0gPt+eEugIm4kxR/g82wtcSkWwH8494Y55Y5/ 7cOqAtr71WSNQKBJgNSdspcI+SMCjgUBjMOGWdLRDOE7wGAWvEr9rS7K8u7O+nVZQUxPIJ6d j8eWIdkVR3V1PlCMWI0pEO2AvKWn+BUTPkzdwbz4Rlu5XnLYCbcBGreRQLqY+Nsv8fCsrUV7 KYI5RNGcLuKmPoBMJgwxD+YZ9PMnMTOfdl9OoTaharmIbmO4fqvuvUfLL4P7z2CwspXWv5Hz 8tRz72CMJc7l26e3PxjRTLMkmdOXDXzNZVKuz37uITwI8COslnqQ4Ok2m04cmNNHljv8UNDQ lDCYKitpn+iXi9/G7O4WksEAFaFFxp7LLpVG4PgQcLNkjzYIsSotn3QxEW4FK3YjtEC+/GGg 9WoFp6vYitKYaL+CwkA9W7dkWXkmUUv3DPa5sHgKWM6YPEd/oDf9kbcZ00MT+OOw1+mA5spm sGQhQDXFXjGjTnjrjgqocVCuHZf9xVmxyqPsZQlHLauSyn1IESb0peewTrfd+cgA4oSTYRrE Z26bUjjL2JnivqFXEym90iMFpHaH2eBZVPCAjtXvQRppnbPCVLCUuajz2TjB8+Pk7n7V8biG DaISqIQv3TGVZGtndE0qHlzUNsegymDjFNQ0E/lbc4OXXNu3513+POXKa13meLQnYpw+0WMl j+EHMvCzIr4+ry+A+emT6EG3lj+44nOfbFCq8/N5vJ3Gm2FYGOnaYaPvNd8Zp/LuryuusTXe /3QX7TEBrIT8cSnyqbqXYuNHMq9D0Kkfb01Abk62b99nglGvbWKElnQbZeA9z01RmRe9+4lL FCyfQytq+MF0+0TPis46TedSRCJRPeunTedZBglblk+YYJ8IJuFJzaWwbS3H5J3B8CPN75/X luNZhT0fTkAMtTZMQcdCJSw0oxmPmOJEUttBbqAuVWRyBbs1bre/eI6aHPs7whHwmooxbxI0 CW90Rmjrz4dhrG8b4REKQrJ2tKLGA69XR55euHM6ndEh+jee0G3F20NBaGAfVgYZnAPbUbtR Bh5d6U28eRairjwQjV+QJBHZgmyRfQfeqCRCSWGeBJ9NSmOVODxouSifTD8wvfeH+ccEQXhY pMaEoKSN9M4wNSyrEK7g== X-IronPort-AV: E=Sophos;i="5.81,251,1610427600"; d="scan'208";a="39540860" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NqqUpDzF4+VBJbIdmSfoWggLY7QJOfb9khIY19KtTvdnhp3XsDdIwsn/O4vyUKBIwl/y8OBtf/nUjHscKsdpgWZT9N8yE1vxZ+8lRGQgoL62dVma1V4w73xCjyXu4raqBVp0INnyj70NeFNbmoR01rSkcdi5vb0D3U39oOyep0RgsKsf/riWg9eA3R9niVq60Oy6c6FxH9ONm7VjRe6K5ZsUeV7CYFvSw6jumDbHMhmP9YzmX8hD3q09H3A0bXdq0EAYXf+cnI83vC4RZB0qNYW6txyxgw83PPyc8AGLp3NcYz54uWuPAoIffUjSaGSkdh9DmSkchqO+ILsDw4Qemg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rlasv4Jn1OoVRsj0rAUhjQMBr2L+njGmzqACO3Ed0yY=; b=AqhaQJfIiqUBjO1tV28eYMEG8yIP3DQd5Qj793XOaYnaFPim3r5LhdlTjTK1Kj5xHmDj5zsGxlc148AsZY/MN3x4Jrx/fDoVJ5MdDmYhEewfI1u3BMJmMJhZDDRG45xjsHGA0e/7Yulw3vlqgDDX+4YvbM0mAcL0yjQ7gjDNZA8uxLiVgXEpfM33r1Evw3l+UUFiC7TnTSZw14vVICA75ZLp82H4B3MSarULdgRxPG2TJ+Sq2I2LcXqnvJdK6yy8Vvpe2M9bVlq3HBBbG133iD+rpgpRrr8XrFQi/qxlmghxlcHucFYk9lvDbEPejfRMbRzt1fBwPJUOQBs5A8EmsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rlasv4Jn1OoVRsj0rAUhjQMBr2L+njGmzqACO3Ed0yY=; b=uNMcCRKZi3SCQV5I/hLotk1tPjYcAeSpYVzpIuIoVTvE3zURNBlfZjbuOusVeQm6FrpFYmcwqLSPv50sGt3nA9hS5RgKJle6OxENQV5L2MzxuVbRM2q8NNqzBgTcsG3FccCX5G8oquW/i+9s9c3zv2QuZqYgZ02N64tUY6II0v8= Date: Tue, 16 Mar 2021 09:49:23 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Stefano Stabellini CC: , , , , Subject: Re: patchew - gitlab-ci notifications during the Xen 4.16 cycle Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR1P264CA0026.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2f::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 69ff6a47-f112-4e28-8c9f-08d8e85869dc X-MS-TrafficTypeDiagnostic: DM6PR03MB4763: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wpqvMpao8t/lhNRJcqAGdTWomge/2ugndrDIhUBjXnnPP7WoBEa9wQe4FwvnCVW8R4dnEwhdHUI0BA5f6C3aG/JmEr6xbV413sdUK0L1+d7n6Kl1Sw/4j1aqDvCcBvH2N3bmGN33g9zaWudKcPmQBbt7FpfhD8cHCkNpmk9MTn7ktH0GkjEW/k/SY97GGGCDEwK8vFpld2w7/2+72afvIgvco0SrOR6+EDoM07/GIeZs46a2gusqn6QeEN1A3aqkHIngCSDu6hA7gJjexuzzNYR+O2ZMe5iAFh52kohshJlKaLtGihNhcn5Qk/S8iHK2e99mBSRlPgiWqnL25FO4mpFQaNKSinRzEJvp0hdSyYjfst+hgZsISmf9h4u8Al+JXRQe8NfQyQAvfZQX6LZsa4BZklQG+Ye7GZ+lcvTLg0WqJQ0sxVPUaNVmPr2kzsGYQAit8hIaOt3mBvusPCpFnYgCr12zNdzZtX2Lxfj3GCeHbJrRGLbmAM0mvLeXXWmV80j3N+D5H9ayCn4Bo0Pi2N8vx1OECDlFXqodZBAApaP+o9mZpr9kVgsoBRkf/Pkamz16fvf8tPB+UhoXfD7OrL9eiIU+e+y73yb8vroWyc4UwMrW543Fqny+g+3nXIzPEkNOcHLuOrWuJWZFAYzFIw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(346002)(136003)(376002)(396003)(39860400002)(15650500001)(86362001)(33716001)(6666004)(5660300002)(316002)(2906002)(66556008)(6916009)(83380400001)(8676002)(6496006)(66946007)(66476007)(6486002)(9686003)(966005)(26005)(956004)(4326008)(16526019)(478600001)(85182001)(186003)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?TkpydDZiZ2tsZEsrWnJJUTU3RUY3L0R0eU5mUjZhR205aVJWc3ppaFprT0FZ?= =?utf-8?B?bDJURHZ0RndkNDZoZVRLcFMvcXNoYzRaUi84SjhHc3dxRi8rd2JlMVFpem1i?= =?utf-8?B?c05oYXRqSWQzU3JNbkpiRVBSdnJLQVdFV2ZSNk9hR3Azc0VQZTBtb1RoL0dX?= =?utf-8?B?NXZYMGZLVlZwdFhkc21sV041ZGtuUkg1eGJTYmcwZ1BwSmtiR3RlclIvZVdu?= =?utf-8?B?TzVWMm5EYnNvOVBVR1dlc05kSWNXTTJkTUYzRzJGaSs3U0ZMSVdEWXRLUkFx?= =?utf-8?B?d2tnUXlxVEhvdytBWFJISmlOWFBlY0N6R0FIaDUwc3N0dlhQODJOcVprWGhy?= =?utf-8?B?eDVmZkk2T0RISmY5SDdyd25wSUpZU2ZFSDlnSFdHaldTUk1iVWoxaFlCaHFy?= =?utf-8?B?Y1FIK2xWK1E4S1J1MnZ3d3NvRzhYcllZcTdIVVAxUi9sQ2lXNWNWekpVQnBk?= =?utf-8?B?WFBEaFFGWnExVmZSMTZkaHRiZU1UcXY2RUxuNEY5OW9DeVJoaW5VOWcyZkNV?= =?utf-8?B?Rm14TVhNU0FGc00ydklwYXFMMk8wbGpQaThEa05ONUZZMis1bDdERFpSQXBm?= =?utf-8?B?cTBGbzlqWndSZUpncXhpZVNKdFdmQy9JU2xONmZzNCtMbWVBb2RzWUdOVXdt?= =?utf-8?B?U3NCbXJxdU5tZmdyZXlpVU1Id21RY05ibWYzR3p3Z3Rla0wrbk45bVBONmV4?= =?utf-8?B?SVNZcXJSeUtWZmNsb3BycDN3U2dZeS9lV2xlQ1gwbjFmMXRsVVhGVGc4VWNq?= =?utf-8?B?Rys3dkY1UTBxOVcvNkJOK0drQzYvSFQ5RjNnV2ovZlVZTzFoS0Y5ejZXUCtI?= =?utf-8?B?Y3RkdlR6dVlpSDZQUVZLclV6ZmZWb0J0S1dyNkxiRWl3Q0x5SHNmc1gvQXRv?= =?utf-8?B?UXg1dlVLbVZPM29yTG0rZzJjRndFVnJFMTc4U0JwK2w5ZXVhVWVQUG1jQStj?= =?utf-8?B?bTFXa0pra1dPZklRTFA4V0h4SG43b0Z3RWZwL0lmdHNIYWw3Y2t2OExkcVR2?= =?utf-8?B?UEQ0ZjFCR0Mrd0J3R0RQaUFDRFU1RXZRUTJocmF6NDZ0RkhLMDRaVm1aS2pG?= =?utf-8?B?N1JIbVY5OWVVNnRRYmVVakxZTEFlVXd0OVBXMC9YUWNleGpoT05WMThHNkY0?= =?utf-8?B?T1lLY0dnSmRxdldxUUFzZDRvK1c2cVc1KzVZTU12cXZYa0dUZkR5V1BHUmZK?= =?utf-8?B?cjJRQVE5dytjeXI3UFFRdnZDM1JzWTErbW9LZExSL1VWTmsvYjRPV21IOER3?= =?utf-8?B?QWNuVURwcDdpUzdUOHgzYkY2L3N3MzJVQXc2dXhjc0ZEcjFQWlJJNlUvcWpF?= =?utf-8?B?TlQxR0J4TU04cEdvVHdXc3MxWGEyRlFETGNnZ3VrcDRJejRmTGJNV0JySkxL?= =?utf-8?B?d0NoeWdBQ3g1NzQvNmx4cmQ0bnVmNS9YU0ovUDRST1hEelpXQ2E4WDh5UXlj?= =?utf-8?B?RXp4RGdkYXMvemt2Vnp4TjRRZVg3R0hHWmh4ZHY5eUVPRTBxSjRDWGo2am1m?= =?utf-8?B?Q3lCdHFIeFFnYW4xT0ZBLzdHVk4yTTRBUnJRRWtoVDRPdlJaRkwwRTdpa2I2?= =?utf-8?B?QnpjV2RkcEZ1QTFpMjlTSFQ5NDFkczJrUTM1UnEyYWJFSkticGJrZ2hPREQ1?= =?utf-8?B?bDg1dkgvL2JXb2hIb2hNeG1INXB2S094UUFSNEYxV0k4d1RlVWFUSUxNNnZF?= =?utf-8?B?VElHN2swT3VKTHg1bWhUVDZiSTdZSXhSc3ErVFgxQnJ5cnlSWTFla3pTZXBx?= =?utf-8?Q?7i8jpJOmOBWDR7vLRB0xjK0Jb06CUxBZGn0zt3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 69ff6a47-f112-4e28-8c9f-08d8e85869dc X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 08:49:30.6460 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eEATiLi/Xu15q/EdZgIf5UMp+vn9bm+Aa0LLb3ES+2reiO5Hy8YM05Eb4wXBar63REFyXlWQxE53o6kur/8KDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4763 X-OriginatorOrg: citrix.com On Mon, Mar 15, 2021 at 01:05:08PM -0700, Stefano Stabellini wrote: > On Sat, 13 Mar 2021, Roger Pau Monné wrote: > > On Fri, Mar 12, 2021 at 12:55:38PM -0800, Stefano Stabellini wrote: > > > Hi all, > > > > > > During the last 6 months we have been working on improving the Xen > > > Project gitlab-ci and patchew infrastructure. > > > > > > You can see the results from gitlab-ci tests on the staging branch here: > > > > > > https://gitlab.com/xen-project/xen/-/pipelines > > > https://gitlab.com/xen-project/xen/-/pipelines/269678673 > > > > > > In addition, and more interestingly, now we have patchew integration. > > > Patchew picks up patch series sent to xen-devel by any contributor and > > > commits them to branches under this repository: > > > > > > https://gitlab.com/xen-project/patchew/xen > > > > > > Then, gitlab-ci tests start automatically. Patchew waits for the results > > > and send a notification email. You can see patchew pipelines here: > > > > > > https://gitlab.com/xen-project/patchew/xen/-/pipelines > > > > > > All this typically happens before patches are even reviewed. Today the > > > patchew notification emails are only sent to us in the Gitlab-CI working > > > group. But the good news is that we think the results got to the point > > > where they are reliable enough that it would be good to share them with > > > the community. > > > > I'm not opposed to that, but we seem to have some random git clone > > failures during builds (at least on the x86 side), that are more > > frequent that expected. At least recently I had trouble getting a full > > gitlab CI pipeline run that didn't hit one of those. > > > > I will try to figure out what's going on by adding some more debug to > > git to see if I can get more verbose information from git on exactly > > what's failing. > > Yeah we brifly talked about those during the last gitlab-ci meeting. > The current theory is that they might be an infrastructure issue and > we ask Doug to have a look too. > > Your idea to add more debug info to git is excellent. I've just realized that all the failures seem to happen on the -bobcat runner, which is maintained by the Xen Project itself. The -dingo runner seems to be fine. AFAIK they both run on Rackspace infrastructure, so maybe there's some tweaking to be done? Maybe the machines used by the XenProject runner have some kind of network limitation? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 16 09:43:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 09:43:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98236.186265 (Exim 4.92) (envelope-from ) id 1lM6Ei-0007cy-0d; Tue, 16 Mar 2021 09:43:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98236.186265; Tue, 16 Mar 2021 09:43:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM6Eh-0007cr-TM; Tue, 16 Mar 2021 09:43:35 +0000 Received: by outflank-mailman (input) for mailman id 98236; Tue, 16 Mar 2021 09:43:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM6Eg-0007cm-Pi for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 09:43:34 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 631c2e8a-ac56-46b6-b4ef-076a9137fa33; Tue, 16 Mar 2021 09:43:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 631c2e8a-ac56-46b6-b4ef-076a9137fa33 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615887813; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=GD6J4yQnRJatN/Re/S+emCfZY9wFlpXF++z0J13EmiA=; b=MfqvbouDUe784Lm7Tfee+k/e9v/VHS5F4AzzsNf/jEiJKk2/nrC6Jl1B C+PJIORf8GqSXHZCH2K0KEVVlcvvc1iYGPmxhawa0wYEaADTEFxjP7XZo n4uliNcruB7usu68CyVg3Xrxw+8xty9uyWPcJgNAQq8XVsQqh9pAUlt2E 0=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: oVJ0cUotRVM93uwQGmpXp3zPVcNc8jcCIaTZ/hEV/xBNLeGwmpZg0vgICNGm9ExVmnKTN9jnhS rly6Dl9PgmMNyXopECexYdVSi1cttvqV16/b8DG0xMOlHfI/0TSYTwM0Ugg+avBYOtAP7mNFsG B2q2IH+K3kEBo3PpKfU0jkIVTQPq7BOV3goptWGImzsWhxpDc22Z+4nKcVnNyASkrwCcpc6nCS sPg2rndGH+JN1QwrB6tZDGy3WLmYflLzIKtJj+8xoYumf+kVV5hW7sGQHIEDzRFXh4d7tdbcY/ Pxw= X-SBRS: 5.2 X-MesageID: 39380055 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Tcb646pEEETwss8Y+FvWgRAaV5u4KtV00zAX/kB9WHVpW+SivY SHgOkb2RjoiDwYRXEnnpS6NLOdRG7HnKQa3aA4Bp3neAX9omOnIMVZ7YXkyyD9ACGWzIFg/I 9aWexFBNX0ZGIXse/T/BS4H9E8wNOO7aCvgqPkw21wSBxxApsB0y5SIG+gYytLbSNBAoc0E4 fZy8pcvjy7eWkWaMPTPAh5Y8HoodrXmJX6JSMXHhJP0nj1sRqEyp7fVyKZ0BAXTi9Vzd4ZkF TtvgTl6syYwpSG4zDG0Wu71eUzpPLAzZ95CNWImowpLFzX+3qVTaBAf5HHgzwvuuGo7z8R4a nxijMtJd565X+UXkzdm2qU5yDa3Dwj62DvxDaj6BOJy6GJJ0NZerh8rLlUfRfD500rsMsU6t Mx40uju4dKFhSFpSzh5rHzJmBXv3Cpqnkvm/N7tQ0nbaIibtZq3Osi1XIQOpIBECXm0ZsgAe ljAerNjcwmD2+yXjT3uHJiz8erWWl2NhCaQlIassjQ6DROmmtlpnFoiPA3rzMlztYQWpNE7+ PLPuBBk6xPdNYfaeZYCP0aScW6J2TRSXv3QS2vCGWiMJtCF2PGqpbx7rlwzvqtYoY0wJw7n4 mEeE9EtEYpEnieSfGm7dluyFTgUW+9VTPixoV1/J5ioIDxQ7LtLGmqVE0uqc29uP8Sa/erGs qbCdZzObvOPGHuEYFG00nVQJ9JM0QTV8UTp5IVQFSLjsXXKpD7l+DSffrJTYCdUwoMayfaOD 8uTTLzLMJP4gSAQXnjmiXcXHvrZwje8PtLYe3n1tlW7LJIGpxHswATh1j8zNqMMyd+vqs/e1 Y7BLvml6i8tFSn5Gqg1RQsBjNtSmJupJnwWXJDogEHd2nud6wYhtmZcWdOmFyKOwF4VMGTNA JEvVx49eaWIvWrtG4fIuPiFljfo2oYpXqMQZtZsLaE/93ZdpQxCYtjfrdwGwXNHxlcgh1rt2 9HVQ8BSibkZ3DToJTgqKZRKPDUdtF6jgvuC9VTs2jjuUKVotxqemEWRAe0UcmcgR8nQh1dgl EZyd5ZvJOw3RKUbUcviuUxN1NBLECaGqhPAgi+aIJIobzzYw1rQWCWhTuVtgErdgPRhjYvr1 2kCRfRVeDAA1JbtHwd6Krs/V9uXki2fk57aBlBwMZAPFWDnkw2/f6AZ6K13WfUV0ALxfsFNi rZJREIJBl1+tyx3BmJuTqLGHk83K8yNujFALlLScCU5lqdbKmz0Y0WFf5d+5hocO30uugQSO SFZku7Kij7B+5B4X3iml8VfA1P7F8qnvPj1Ee7sCyW3HsjDeHTJ1ojbbcBON2Y53XlQfHN8J gRt6NAgcKAdkHKLviBwuXrShQGDDX5i2u/VfspppBZprhajso6I7DrFR/zkEha1xA/JvrunE wQQK5H8KnMU7UfCvA6SmZ8xB4Vj9yBI0sgjxzuDsI/dV8riWXHP9nh2cu+lZMfRmmArhD3I1 +R7ml0+OrERTKK0dcheugNCFUTTEg383J5+uyeM6XWFQWxbulGuH63KGW0frMYaK+LH9wr31 tHyuDNu++cbCzj3g/M+RN9P6JV6m6iBfqIPzjkI58Az/WKfXKWgqWr58avjDD4DRuDAn5o+r FtRAg3dcRMij4rkYst9DO9I5aH+34Yrw== X-IronPort-AV: E=Sophos;i="5.81,251,1610427600"; d="scan'208";a="39380055" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FAkT87ypccD2OCHYgJjf/0jzk4xneycbelU19wkKvN1Qob9Q2vq65Opi9w46iq9jc3qCv9T3dH7P3y1zMJUiqAjwwnJUc3YGgtC3mLCRFp6SucgSXh7Z9MA2LiwGwhsTyfPh2pqAfMdNcw2rJecoIyMdgVaGA2Ge2T3PkGQJ5aGPNXjHbFNVZiQoX8m7h7dxQQ/ZQLZr7SHSkcPL8h78RYtIxA0aiudvzjCOIP9r6+tLGF2TtJPrGonsg+TrRDFWMwihauyNn11fVgiYWiD5zcI0Sp/anSOgbMjDBAxDJ74LJ8Wk7P/w5rHveaEUdVP8ABBLo0LtlnoqD05NeSyWCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jY+H3aeiJdIw5LYC3xAbVdwK0B+UdoN9Ybvz3FB+Ugs=; b=m6oXz/IFvG4/+6qrMJxvUwyLnRQRNPhaEU0M6vsbuMs9aDj9rDl4DfFIC3cknm/OtWW0rN17KU82R0Oi9EdI178qBkrWnx9O2tyWbMj3XlOXCfMQoXCfgMga/5lBhifvl3iLGdaKa/a7kjLHNMcVs3DguelvofYto2dUm+p0VGg9vUgw3V00KtSjmm4WrW4wTcNE3DjDG6arXl975FKphcF6OFVi5LrcMlJ0VHXOp/gO7XjxKY/a6sk9fOz2CQxq5fi/ap3EDU1Fuq2uKiKFO0GFnK5ZydgjgXOz64CPu1uZTaw7q2jqmuUZkUUQNQiAvrC1GArMCBChmFgcvW3KAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jY+H3aeiJdIw5LYC3xAbVdwK0B+UdoN9Ybvz3FB+Ugs=; b=vLqf12mzF0o0o6186UCsl+S2WPo3xQxGe0gvTlF4YlX8m+enQDOImas1BxKgmUkq4gmX6FhKf4NWWAwT+iAtnx4yWN2zjc9NWlYg9RK9Rm6z5CBEA0qe1nsKXudxii+odYCjO43Ku4Vq9dk6d2uSxXEjrKMnkhRnqaII/llZgGE= Date: Tue, 16 Mar 2021 10:43:23 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Ian Jackson , Andrew Cooper , =?utf-8?B?RnLDqWTDqXJpYw==?= Pierret , Dario Faggioli , , Subject: Re: [ANNOUNCE] Xen 4.15 release update - still in feature freeze Message-ID: References: <24655.20609.834996.744652@mariner.uk.xensource.com> <4531d373-3915-ad90-ef99-4f8cbbdb5054@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4531d373-3915-ad90-ef99-4f8cbbdb5054@suse.com> X-ClientProxiedBy: MR1P264CA0028.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2f::15) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fe08838f-21de-4b87-aa1e-08d8e85ff464 X-MS-TrafficTypeDiagnostic: DM5PR03MB2715: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2ar5zQI+uk1mgGMt137iWRkqWeqex0lf2brqVUY3yQ2n16XMCF+p/D1ojqO2dKcyY33FaflUfyDeHKGvIWd+ZECKjlIEMnUXZdy2JvpdFX/Lvo9qtt7cphuPzR3VtCX7eD5r2B7hu3bcRWQKHkxXn+PReVkgvBk25wBlgWI+m0dpsFLh6GKld1/lFD4yatj/jNQQEXZGWOrqh/aovdStVY1ZJ6fbzsBkii1SKdJdYbfHv+E0QOQ9Ga8Ahu5WogBWxBcyUPDMTnNTDgEM+ogsJ2vShJZn5VdlGmT4mQGFC8RbNPbAx7tUXK0/tfRaiB8JOeqWc5CRIIEMvvw70PoestHOBqPXi7u4AALETXr1rK3cviQiv1zUYcavYoffjUXBDRSajVE2i5hP2tSEkIlyM8Vs0o4rA+tbVvjf/E5eGpmmOycGxFdBn5OLP/HjYTGBM04M6QwM2HRlqsFQwZKCvV/xsbzPwbZwPjDoS9lJQ2vPoUKisWz5dVzOAkqAk73M9vIhzCDMqaTDIfKZkblOx43VguhmwLVfUM/NlE/8siGYfN4UepqaEyAsQdv3Kg0a X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(376002)(366004)(346002)(39860400002)(136003)(396003)(2906002)(6916009)(33716001)(83380400001)(8936002)(16526019)(66476007)(6486002)(85182001)(66556008)(4326008)(53546011)(316002)(86362001)(8676002)(956004)(66946007)(26005)(54906003)(6666004)(6496006)(478600001)(9686003)(186003)(5660300002)(15650500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?RGRDV2drWGNJWFJYVTZsOW5iN0dPNlllMDdoNTNjNGZVVHczTlQwcVFab041?= =?utf-8?B?a0NHcVNJdmVMTW83Y0ljSUlZdkdnVjJKcldBTEFnTXFvL1ArMHBoT2FPckRY?= =?utf-8?B?ZW9KSEx2NFJWaXd3bzh5VzdGMGx4d1kxbjVra0kyd3BQMXRKREZaNE5LSGV6?= =?utf-8?B?YzRRSmhRTFNzZEs2WEIvYkc2UllTRzNUcDNrenlWV2hLNkROdGVwYjluVytO?= =?utf-8?B?SGlNMVZ6aS9EV2diWTc3TDJxOE1HQzRVSG5vY09iSUlQSGMyakowMkJMelFD?= =?utf-8?B?cVdkdThHdFRHcXY0a01CWkhaanJYYWxFQVNvU0YrRmdqdnlVellPd3VqajlD?= =?utf-8?B?ai9mRG81N2ZpSi9GQ2NVaStUZGJobWFUWVNlTUlVMnJxUW9FM1VSNzQzR01L?= =?utf-8?B?eFBZdUs0Z05tNjNWdVBlRlJtTy8zQmxMNkxSR2FFNDFzanp2Q3hjWDN3dExn?= =?utf-8?B?ZFNrRnZ2SW0rSHlBRldZUUJZTktERzcvNGtIY2lHbVNwNE9vb0RhbHo5QURX?= =?utf-8?B?SmREVndnamErUWxhOVEzNUg1RmxFQTE2aUlHdzZnL0IybjBzMC80WDdyMS9m?= =?utf-8?B?aHFDZTdiYjk2ZUZwM1Jub0NhU3dFM1I1azl2OGp1U1U4aVFrMUFnVWFTbm5q?= =?utf-8?B?RUY1NHJITUxzUEN3c0VUTlFsRmtTTlE5aTBXUlBITmZhN2ZQL29scmhLeTky?= =?utf-8?B?b0xXWll3TVpKaW0zc1VHL1hxTTFDQU1abE4rL3pYditiSDNYTkVMYlVLWEpv?= =?utf-8?B?SjVPN28rRTVQVll4UTVDNG44Q2s1TkdxakJuUCt3a3VKNU1laU5lRG5qYTl1?= =?utf-8?B?SksvVVdndW55a09oWktXUzJDMDBLWFRzaUpBQjJhV3ROZ0VLdTRNTnNLSTlP?= =?utf-8?B?d2JSSlZSUlNSVEpkaXRDcW1COHRTb2NwY3pqM0hYcUhXWjBoSHVUeTBhbVJV?= =?utf-8?B?UVlEZ3dxRnZjVUJYanArbEpOT0xzUE9Xb2pQMWgyeTVkWkJyRFUrdk1McW1v?= =?utf-8?B?Y1YvdGNUUEVYdkJpQS8yUVRnNGEvU2NnNmpCSWtMQk9nSE5wNXdpUkI0MkFk?= =?utf-8?B?TkI0RXJBUWsrVUVFZkxlQzFFL2dkWkhvTjh1b2IxeVQ0OVkwMERMNWxYVWx1?= =?utf-8?B?ckROZi9tOXhSZTZPbUIwTlRlUGxjUys3emRxV1J0cDRDTGxGREdSNytqUS9h?= =?utf-8?B?ZjhVSERqVDl5T2JqMWlOcmNtMEs4RWZBV3B1b0Z4QkdaRDIzZUZpUmJMa2JY?= =?utf-8?B?Y0ovaENhb0sxZ3Z5VnJNTnd3WC9MRUJia1QzTzcwN3RIRmpvRmF1TTJybDJG?= =?utf-8?B?OHEvV0hZbGpsSUhhM2N4eXYxUVRmWE10TWZDRm1xcEhObkNmVnFwbmRvNnY4?= =?utf-8?B?bURCTENDbVF4bWVXb0tUbUR4YmFNdG50OERGWDE5eXhTQzVDMlV0eU1XclUr?= =?utf-8?B?M2s0TnVweVpzQmdENTloTjNBUWpMajYxWGtNT0h2SzhsSUZDOVZOMDJhb3Q3?= =?utf-8?B?ZXlmd1NKVDM3OGlTNTBqcW9qVytWK3JPRmVQemMwZHNtSWEzZmpSL1h4b09i?= =?utf-8?B?SnNGcVd2SVhNRFJjUlNBbjJ5Z25XNW5mbVpiVGVqOFFCWENnNldFa1JuaXV2?= =?utf-8?B?MGVwc29pSUMzdWxkSmVINHNMamwzYU5BYmJtMUdQTDFWS2hZNWZZZVBaRUlt?= =?utf-8?B?MUZxdkl3NzVNSzNYSzlKMW1VazJSVzZhbkN5SkJCWEtnbmEzZElmODh0Zm5O?= =?utf-8?Q?8IwE33oehoaS3Hojzc4zIkvTvbJ1qSqAKYaCP+a?= X-MS-Exchange-CrossTenant-Network-Message-Id: fe08838f-21de-4b87-aa1e-08d8e85ff464 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 09:43:29.5199 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CUKD9cHwe7f7sR9cyQhTvyQHnjzOfEkXGuBZ0iI/6eHHShKWmjTiW5vvXKQ6scNGdo+Ow78PI26LREP7hmZkIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2715 X-OriginatorOrg: citrix.com On Mon, Mar 15, 2021 at 02:46:07PM +0100, Jan Beulich wrote: > On 15.03.2021 13:18, Ian Jackson wrote: > > ISSUES BELIEVED NEWLY RESOLVED > > ============================== > > > > Fallout from MSR handling behavioral change. > > > > I think there are now no outstanding patches to fix/change MSR > > behaviour and there is no longer any blocker here ? > > In addition to what Andrew has said, while not a blocker in that > sense I think the excessive verbosity of the logging is also an > issue. I think you meant the logging done for each MSR that's not explicitly handled? While I agree it might be too verbose, I don't see how we can change that right now. We could introduce a command line parameter to select whether to print those messages or not, but I think that's too specific for a command line option. We should look into some kind of logging improvements that allow selecting which messages to print on a per-domain basis IMO. In any case, those messages will only show up in debug builds, so it's mostly annoying to developers but transparent to consumers of the production build. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 16 10:06:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 10:06:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98240.186277 (Exim 4.92) (envelope-from ) id 1lM6b3-00018A-UV; Tue, 16 Mar 2021 10:06:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98240.186277; Tue, 16 Mar 2021 10:06:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM6b3-000183-QZ; Tue, 16 Mar 2021 10:06:41 +0000 Received: by outflank-mailman (input) for mailman id 98240; Tue, 16 Mar 2021 10:06:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM6b2-00017v-89; Tue, 16 Mar 2021 10:06:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM6b2-0000JA-1X; Tue, 16 Mar 2021 10:06:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM6b1-0003wq-NQ; Tue, 16 Mar 2021 10:06:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lM6b1-0006ky-Mx; Tue, 16 Mar 2021 10:06:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qrqe9fWdac4N8JFgoSO+0GKPTT1F36sv+efQ3Mt1NcU=; b=DkCGHKuWP83cSQADgNXoZpc1kz CqLAxh6WxTNmgbD8KvvKDnwzL8YHJ2tiq1XYmPaTZkj48VNNgPU7PlIlB1z2uUhcC8lcKuZ6v549w C93Zb46t8np/e+NPbeuqGeHiY0y//H2h+q3I77RG1sOZAU8r2ULYA22TDgQrZ+V6cHT8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160091: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=e7c6a8cf9f5c82aa152273e1c9e80d07b1b0c32c X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Tue, 16 Mar 2021 10:06:39 +0000 flight 160091 qemu-mainline real [real] flight 160096 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160091/ http://logs.test-lab.xenproject.org/osstest/logs/160096/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu e7c6a8cf9f5c82aa152273e1c9e80d07b1b0c32c baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 208 days Failing since 152659 2020-08-21 14:07:39 Z 206 days 401 attempts Testing same since 160091 2021-03-15 22:09:24 Z 0 days 1 attempts ------------------------------------------------------------ 452 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 129371 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 16 10:13:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 10:13:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98249.186291 (Exim 4.92) (envelope-from ) id 1lM6hB-00024P-Q1; Tue, 16 Mar 2021 10:13:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98249.186291; Tue, 16 Mar 2021 10:13:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM6hB-00024I-Md; Tue, 16 Mar 2021 10:13:01 +0000 Received: by outflank-mailman (input) for mailman id 98249; Tue, 16 Mar 2021 10:13:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM6hA-00024D-SC for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 10:13:00 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8d15762e-b892-4d39-a3c1-f56dbdaff138; Tue, 16 Mar 2021 10:13:00 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2AA84AE5C; Tue, 16 Mar 2021 10:12:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d15762e-b892-4d39-a3c1-f56dbdaff138 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615889579; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wb4bjy5/2C8ijMBFZMSB47gOHPtLNDU7OWz1ZChrhjg=; b=r4TjIAbfZF7de4A3gLd4Mq2M36FIhG2BY4M6NO3LKvnpg5GUaOzd7yV0fOyhXZO2hcNw/w wfUos7NrZDaVc6X2f/XxQF7jYpyMkwbZ82O24ebfNuqMNc0P2sffJGrl2fHeqAKdbkjC2m IPC6Jr4zUCVKOS/AHb80+8y4CKjy3CM= Subject: Re: [ANNOUNCE] Xen 4.15 release update - still in feature freeze To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Ian Jackson , Andrew Cooper , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , Dario Faggioli , committers@xenproject.org, xen-devel@lists.xenproject.org References: <24655.20609.834996.744652@mariner.uk.xensource.com> <4531d373-3915-ad90-ef99-4f8cbbdb5054@suse.com> From: Jan Beulich Message-ID: <7d27dffb-834d-1948-a410-c6d0c462ae63@suse.com> Date: Tue, 16 Mar 2021 11:12:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 16.03.2021 10:43, Roger Pau Monné wrote: > On Mon, Mar 15, 2021 at 02:46:07PM +0100, Jan Beulich wrote: >> On 15.03.2021 13:18, Ian Jackson wrote: >>> ISSUES BELIEVED NEWLY RESOLVED >>> ============================== >>> >>> Fallout from MSR handling behavioral change. >>> >>> I think there are now no outstanding patches to fix/change MSR >>> behaviour and there is no longer any blocker here ? >> >> In addition to what Andrew has said, while not a blocker in that >> sense I think the excessive verbosity of the logging is also an >> issue. > > I think you meant the logging done for each MSR that's not explicitly > handled? > > While I agree it might be too verbose, I don't see how we can change > that right now. We could introduce a command line parameter to select > whether to print those messages or not, but I think that's too > specific for a command line option. Yes, I agree. > We should look into some kind of logging improvements that allow > selecting which messages to print on a per-domain basis IMO. Indeed, this was my thinking as well. I was wondering whether we could at least limit reporting each unhandled MSR only once per domain. But yes, this would require at least two extra pages to hold the required bitmaps (one for the MSRs starting at 0x00000000 and the other for the group up from 0xC0000000; a 3rd one for AMD for the group up from 0xC0010000). > In any case, those messages will only show up in debug builds, so it's > mostly annoying to developers but transparent to consumers of the > production build. Or when, because of things working differently than before, people need to be told to increase verbosity for debugging purposes. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 16 11:58:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 11:58:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98271.186307 (Exim 4.92) (envelope-from ) id 1lM8KR-0002QV-Al; Tue, 16 Mar 2021 11:57:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98271.186307; Tue, 16 Mar 2021 11:57:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM8KR-0002QO-7c; Tue, 16 Mar 2021 11:57:39 +0000 Received: by outflank-mailman (input) for mailman id 98271; Tue, 16 Mar 2021 11:57:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM8KQ-0002QJ-Dj for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 11:57:38 +0000 Received: from mail-lf1-x129.google.com (unknown [2a00:1450:4864:20::129]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6cf8c17e-c1ea-47af-b483-bc3c613230c4; Tue, 16 Mar 2021 11:57:37 +0000 (UTC) Received: by mail-lf1-x129.google.com with SMTP id 18so61937343lff.6 for ; Tue, 16 Mar 2021 04:57:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6cf8c17e-c1ea-47af-b483-bc3c613230c4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=e4Hc1uNcOeVtQqWE85Je96hp9PhB4a4FXst+jLi+FjY=; b=BsfHeOktPXzSzeNBLAa6HH7mzTJgO3UKkpX7XeuRz89dtvyKU1n57zjm+5YwgioyzD KFdnSobjpeBBvNMCjAqcthnPbGKPDp8515uCIiU8v3qLTmqAjnPCHiuCGOLyc74tZXMw 3zB9XmgpFrLx0rkscSR7hTZ+OHY8jCCTvF2OXVi2CLSCeIwg51TBbF0cZRy93A0TYaYZ HjgVVyJq9wTo1u46qMAlBrFO+RXLlhgpfFD77saFptl5dGJF3oeMPszKr2JgSnuF4b6Y e/e0DCO+tnzNICi9OeXBJWnyplBROR+TzGR953a0NbBiY0Sz0/I6gCgb34bjcKuGWylA 8yZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=e4Hc1uNcOeVtQqWE85Je96hp9PhB4a4FXst+jLi+FjY=; b=tpDRrxcdPZIdibQJvccjA8pddGtp17Zl3HEFMsFsCqgV5wdHfUDsBAox3S07E3xlV+ HQ0SaBqGFHlhsDxfB3xR+SiLD7CcwISb+Oe9+ZE8If/In9+2d+jFpo4dBcSganc4Y1TU ElSaFqX1dNRIKQhWLCU5ZS/5YrDFIV5Qwm+YFHphVe5k5dm7J866BpG7swg9abk/kr5C fKmSj66Prfl9h7MSqbE9jrdwbH8vP+/cESIadeVbgPsdwwS8tO8cSiKzb2gNsNy653zp n6LbfQI8cS9fd0uAYrdVrq+hcgkrfYfifILeP3DDMqCpmmhEDSPuZNazMTRx/pqhasGd AaRQ== X-Gm-Message-State: AOAM533AsNph923icrsYBJJBUWunuhOTf0w7G4I2Q36+d2zRd7GYLN0z U4liVcaFn7aw9MHHEjwzD7GSWFboRfe9sanoQz0= X-Google-Smtp-Source: ABdhPJwsCbOdhZOxyX7/7EhZgnH+9wIxsRYLSDbsAQ5l0OB5n1goXOJu3JRTIwzpG9BjsnR7kzl83TbLCdWVLYaUrqY= X-Received: by 2002:a05:6512:243:: with SMTP id b3mr11383621lfo.529.1615895856149; Tue, 16 Mar 2021 04:57:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jason Andryuk Date: Tue, 16 Mar 2021 07:57:24 -0400 Message-ID: Subject: Re: AMD Ryzen 4000 (Mobile) cpufreq issues To: Dylanger Daly Cc: "xen-devel@lists.xenproject.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 15, 2021 at 11:03 PM Dylanger Daly wrote: > > Hi Xen Developers, > > It appears AMD Ryzen 4000 based CPUs are not supported by `xenpm`, runnin= g `xenpm get-cpufreq-states` returns nothing and `get-cpufreq-para` returns= `failed to get cpufreq parameter` In dom0, do `modprobe xen-acpi-processor` and see if `xenpm get-cpufreq-para` works. Xen needs Dom0 to load some ACPI info before xenpm can work. Are you running Qubes? For some reason xen-acpi-processor doesn't load there automatically. > This was somewhat expected as Ryzen 4000 series CPUs are quite new, so as= a workaround I tried putting `cpufreq=3Ddom0-kernel dom0_max_vcpus=3D8 dom= 0_vcpus_pin` onto CMDLINE, from what I've read this should essentially pass= control for CPU frequency scaling down to dom0's kernel (5.11.4). > > However acpi-cpufreq doesn't load, when trying to insmod it I get the fol= lowing error `insmod: ERROR: could not insert module acpi-cpufreq.ko: No su= ch device` > > I can't seem to see anything related to Xen relinquishing control to dom0= in Xen's console, any help would be appreciated I haven't tried using cpufreq=3Ddom0-kernel, so I can't help here. Regards, Jason From xen-devel-bounces@lists.xenproject.org Tue Mar 16 12:57:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 12:57:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98278.186318 (Exim 4.92) (envelope-from ) id 1lM9Ff-0007e1-2q; Tue, 16 Mar 2021 12:56:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98278.186318; Tue, 16 Mar 2021 12:56:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM9Fe-0007du-W7; Tue, 16 Mar 2021 12:56:46 +0000 Received: by outflank-mailman (input) for mailman id 98278; Tue, 16 Mar 2021 12:56:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM9Fd-0007dp-71 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 12:56:45 +0000 Received: from mail-lf1-x135.google.com (unknown [2a00:1450:4864:20::135]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id af5b446d-10d4-466b-88fb-338cefbc446e; Tue, 16 Mar 2021 12:56:44 +0000 (UTC) Received: by mail-lf1-x135.google.com with SMTP id n16so62317801lfb.4 for ; Tue, 16 Mar 2021 05:56:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af5b446d-10d4-466b-88fb-338cefbc446e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LRp0Gn/s4sstafJyNalG8Ny8BaROlPuhfcdfOAjqlnI=; b=l7psML7/Xh2uRJ9hVhEd9SfjK99X5Fvh0zcyO/VW8YjDh/2Tcp3NoM4tEGolqBlPXe XAonTXlNTMiUgHFT37snTmJT67Gb5OoMwOkU/Ltnkp+bpoKs8vG3eP2BDghfvRw2ww8M mPVf7waSDTZ9ERXYOPBybkzefRcUJ6ahiv7FrmIK5Ddok0CDQxKHKQlJoNcVg80VbnG8 ctWL0ANcKGe/IX+joymhS1ZcvHFyCfqajiReRvj/3as4F6qUz4Ou9rniuGl0QfUVJ6bV JGsKPPDTmcWcPGh+C3HoX6HNNFPGxHrHY2IW1Qa+Jb5l59R4MqddGe5roafDimfHgEvm /e9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LRp0Gn/s4sstafJyNalG8Ny8BaROlPuhfcdfOAjqlnI=; b=N4tjUVCYQ5Bx1BuTKbD1Uq6L4gvehEtVJupUk0mzuSFLtavLXS407hu+jIVu7QI7Ij hjea6TwXx+Xzzppw/D+4qmPQ8vEcRWMewF11Q/aY35hvYRnqOfWTXvi7H+9xAh8a+gFD qSSjhJFK3YWZVBkA1p+t3KHi4Rq9ffro4M5meDPi1EBs9vE8v363ZnO13XwkeuMw32iD qfG/+8JseXYrivL3w98Y2CAB+K/T4zO5Pi66Fg0euPN7umU4OfpRwFvOuw4rOxfJMN8a 02Bt0GW7OJRqsWGVPVDnCNfJGNOZFl5qSmE8EUNbZgg3wff+5OpzUQoaeL4UckYLWSjU gnNg== X-Gm-Message-State: AOAM5319K5sSxeSHFggeDt4pzqiT2Pp03/W1Ez85ITt04I+icA7wt/0A HKaG27X0Cp37m1GEnm/HN8fFPEb7hGPvwC5b44g= X-Google-Smtp-Source: ABdhPJxzFcDQ/TJqf3OouuxOYGTNdBGMtM1McRMAAvTzfvKMkKelJqakjw0Hs9iFxyenMB+loRwtaHHL/IrI3Od06q4= X-Received: by 2002:ac2:5932:: with SMTP id v18mr11467951lfi.659.1615899402966; Tue, 16 Mar 2021 05:56:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jason Andryuk Date: Tue, 16 Mar 2021 08:56:31 -0400 Message-ID: Subject: Re: xen-blkfront: BUG_ON(info->nr_rings) To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: Paul Durrant , xen-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 11, 2021 at 5:37 AM Roger Pau Monn=C3=A9 = wrote: > > On Thu, Mar 11, 2021 at 09:01:51AM +0000, Paul Durrant wrote: > > On 10/03/2021 14:58, Jason Andryuk wrote: > > > Hi, > > > > > > I was running a loop of `xl block-attach ; xl block-detach` and I > > > triggered a BUG in xen-blkfront, drivers/block/xen-blkfront.c:1917 > > > This is BUG_ON(info->nr_rings) in negotiate_mq called by blkback_chan= ged. > > > > > > I'm using Linux 5.4.103 and blktap3 on Xen 4.12 (OpenXT), though I > > > don't think that matters. The backtrace and some preceding logs (fro= m > > > the reproducer) are below. > > > > > > I just repro-ed with this: > > > path=3D > > > xenstore-write $path 5 ; xenstore-write $path 4 > > > > > > info->nr_rings is still set because of the unexpected transition > > > XenbusStateClosing -> XenbusStateConnected: > > > dom7: [ 2866.574853] vbd vbd-51728: blkfront:blkback_changed to state= 5. > > > dom7: [ 2866.578385] vbd vbd-51728: blkfront:blkback_changed to state= 4. > > > > > > I'm not totally sure how to handle this. The XenbusStateConnected > > > event should be creating a new blkfront device, but instead it's seen > > > by the old one which hasn't been cleaned up yet. > > IIRC xenbus state changes (like you perform above) never trigger the > creation or destruction of devices on the bus. See > xenbus_otherend_changed. > > xl block-detach however should indeed remove the device. We should add > an option to `xl block-detach -w` to wait for the device to actually > be removed before returning (or exit with a timeout). I didn't realize `xl block-detach` didn't wait. There is some timeout logic with detaching devices, but I have to investigate this more. > > > > > > > Sounds like blkfront needs to be fixed. Once it is in state 5 the only = state > > it should go to should be 6. From there it can cycle back to 4. Ok, thanks for the feedback. So blocking 5->6 is straight forward. 6->4 triggered the same BUG, so I'm still investigating. > Indeed, there's likely some logic to be improved in blkfront so it > doesn't get messed up so badly on state changes by blkback. > > I'm happy to review patch for both blkfront and libxl/xl in order to > make this better :). Okay. Regards, Jason From xen-devel-bounces@lists.xenproject.org Tue Mar 16 13:06:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 13:06:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98281.186331 (Exim 4.92) (envelope-from ) id 1lM9Ok-0000A4-1P; Tue, 16 Mar 2021 13:06:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98281.186331; Tue, 16 Mar 2021 13:06:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM9Oj-00009t-U6; Tue, 16 Mar 2021 13:06:09 +0000 Received: by outflank-mailman (input) for mailman id 98281; Tue, 16 Mar 2021 13:06:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM9Oj-00009k-9u; Tue, 16 Mar 2021 13:06:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM9Oj-0003Ga-1H; Tue, 16 Mar 2021 13:06:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM9Oi-0003e4-Lx; Tue, 16 Mar 2021 13:06:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lM9Oi-00085B-LQ; Tue, 16 Mar 2021 13:06:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=baZKU5XVz3xEH+C17mnvQTv59Vpnr6m7HRVgDGM2b7A=; b=RiYfpROL2DxnzhkWB7uNIXotcD NJOs0PUFUPFh+YmfHrdp2Vox2Q3yk0tpxIBhhuydqF9Nkiy+Ks7wpaMSV/rs1ztE+MNHu6ZJ1Hfw1 He++495RiSJw3F/3Rzb/dEGOWp1howrsh2+hJURucx67VyYDWRbEs9ZDVQyJOnTV/OIA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160092: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-examine:reboot:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b4011741e6b39a8fd0ed5aded96c16c45ead5888 X-Osstest-Versions-That: xen=b4011741e6b39a8fd0ed5aded96c16c45ead5888 From: osstest service owner Date: Tue, 16 Mar 2021 13:06:08 +0000 flight 160092 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160092/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-examine 8 reboot fail pass in 160089 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160089 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160089 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160089 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160089 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160089 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160089 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160089 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160089 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160089 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160089 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160089 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen b4011741e6b39a8fd0ed5aded96c16c45ead5888 baseline version: xen b4011741e6b39a8fd0ed5aded96c16c45ead5888 Last test of basis 160092 2021-03-16 01:53:34 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Mar 16 13:13:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 13:13:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98287.186346 (Exim 4.92) (envelope-from ) id 1lM9Vu-00017b-S3; Tue, 16 Mar 2021 13:13:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98287.186346; Tue, 16 Mar 2021 13:13:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM9Vu-00017U-OU; Tue, 16 Mar 2021 13:13:34 +0000 Received: by outflank-mailman (input) for mailman id 98287; Tue, 16 Mar 2021 13:13:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lM9Vt-00017P-J3 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 13:13:33 +0000 Received: from mail-40136.protonmail.ch (unknown [185.70.40.136]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f0b7db35-a875-4801-80a5-08dc145a344c; Tue, 16 Mar 2021 13:13:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0b7db35-a875-4801-80a5-08dc145a344c Date: Tue, 16 Mar 2021 13:13:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1615900409; bh=Hh7Ith+yQfLnkaPjGf1TlqppumOt5t6STJJkMB4hbhI=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=OJQazPY7Zj0hvDqp7Fxl+g349yyjgfaD1v5sQJ/qW/rXO0tbMA2WMHD9hMwOselZI jad4h3T0UoOzV3wNQJ66UTjUchz0gB/ILaI1iXdKdoeb0FMIqwU2EJTdNJl1yfehGA VawzzYz4mCnChWqDLcvzns44vYpgSJSJg0fCefJ8= To: Jason Andryuk From: Dylanger Daly Cc: "xen-devel@lists.xenproject.org" Reply-To: Dylanger Daly Subject: Re: AMD Ryzen 4000 (Mobile) cpufreq issues Message-ID: <8cr1SEPLgE6uLkQ9wBv-f6z3cZ976RBeSAQ17VJpcwIzBiaMpNJQzbEK5vv5p4exI9bEoArBP-rohjxU0ayurdJrSEvFgF3AyRW6yDv0hHU=@protonmail.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch On Tuesday, March 16th, 2021 at 10:57 PM, Jason Andryuk wrote: > On Mon, Mar 15, 2021 at 11:03 PM Dylanger Daly > > dylangerdaly@protonmail.com wrote: > > > Hi Xen Developers, > > > > It appears AMD Ryzen 4000 based CPUs are not supported by `xenpm`, runn= ing `xenpm get-cpufreq-states` returns nothing and `get-cpufreq-para` retur= ns `failed to get cpufreq parameter` > > In dom0, do `modprobe xen-acpi-processor` and see if `xenpm get-cpufreq-p= ara` works. Xen needs Dom0 to load some ACPI info before > > xenpm can work. Thanks for your reply Jason :) Nice, indeed modprobing produces the following: ``` [ 84.055724] xen_acpi_processor: Uploading Xen processor PM info ``` ``` [user@dom0 ~]$ sudo xenpm get-cpufreq-states cpu id : 0 total P-states : 3 usable P-states : 3 current frequency : 1400 MHz P0 [1700 MHz]: transition [ 133] residency [ 5350 ms] P1 [1600 MHz]: transition [ 17] residency [ 98 ms] *P2 [1400 MHz]: transition [ 130] residency [ 4205 ms] cpu id : 2 total P-states : 3 usable P-states : 3 current frequency : 1400 MHz P0 [1700 MHz]: transition [ 128] residency [ 4604 ms] P1 [1600 MHz]: transition [ 13] residency [ 110 ms] *P2 [1400 MHz]: transition [ 122] residency [ 4030 ms] cpu id : 4 total P-states : 3 usable P-states : 3 current frequency : 1400 MHz P0 [1700 MHz]: transition [ 135] residency [ 3785 ms] P1 [1600 MHz]: transition [ 19] residency [ 124 ms] *P2 [1400 MHz]: transition [ 131] residency [ 4175 ms] cpu id : 6 total P-states : 3 usable P-states : 3 current frequency : 1400 MHz P0 [1700 MHz]: transition [ 131] residency [ 4726 ms] P1 [1600 MHz]: transition [ 11] residency [ 80 ms] *P2 [1400 MHz]: transition [ 128] residency [ 4125 ms] cpu id : 8 total P-states : 3 usable P-states : 3 current frequency : 1400 MHz P0 [1700 MHz]: transition [ 122] residency [ 4237 ms] P1 [1600 MHz]: transition [ 14] residency [ 151 ms] *P2 [1400 MHz]: transition [ 115] residency [ 4155 ms] cpu id : 10 total P-states : 3 usable P-states : 3 current frequency : 1700 MHz *P0 [1700 MHz]: transition [ 123] residency [ 3897 ms] P1 [1600 MHz]: transition [ 15] residency [ 125 ms] P2 [1400 MHz]: transition [ 115] residency [ 4146 ms] cpu id : 12 total P-states : 3 usable P-states : 3 current frequency : 1400 MHz P0 [1700 MHz]: transition [ 122] residency [ 4625 ms] P1 [1600 MHz]: transition [ 13] residency [ 127 ms] *P2 [1400 MHz]: transition [ 116] residency [ 4328 ms] cpu id : 14 total P-states : 3 usable P-states : 3 current frequency : 1400 MHz P0 [1700 MHz]: transition [ 119] residency [ 3430 ms] P1 [1600 MHz]: transition [ 11] residency [ 119 ms] *P2 [1400 MHz]: transition [ 114] residency [ 4065 ms] [user@dom0 ~]$ sudo xenpm get-cpufreq-para cpu id : 0 affected_cpus : 0 cpuinfo frequency : max [1700000] min [1400000] cur [1400000] scaling_driver : powernow scaling_avail_gov : userspace performance powersave ondemand current_governor : ondemand ondemand specific : sampling_rate : max [10000000] min [10000] cur [20000] up_threshold : 80 scaling_avail_freq : 1700000 1600000 *1400000 scaling frequency : max [1700000] min [1400000] cur [1400000] turbo mode : enabled [CPU1] failed to get cpufreq parameter cpu id : 2 affected_cpus : 2 cpuinfo frequency : max [1700000] min [1400000] cur [1400000] scaling_driver : powernow scaling_avail_gov : userspace performance powersave ondemand current_governor : ondemand ondemand specific : sampling_rate : max [10000000] min [10000] cur [20000] up_threshold : 80 scaling_avail_freq : 1700000 1600000 *1400000 scaling frequency : max [1700000] min [1400000] cur [1400000] turbo mode : enabled [CPU3] failed to get cpufreq parameter cpu id : 4 affected_cpus : 4 cpuinfo frequency : max [1700000] min [1400000] cur [1400000] scaling_driver : powernow scaling_avail_gov : userspace performance powersave ondemand current_governor : ondemand ondemand specific : sampling_rate : max [10000000] min [10000] cur [20000] up_threshold : 80 scaling_avail_freq : 1700000 1600000 *1400000 scaling frequency : max [1700000] min [1400000] cur [1400000] turbo mode : enabled [CPU5] failed to get cpufreq parameter cpu id : 6 affected_cpus : 6 cpuinfo frequency : max [1700000] min [1400000] cur [1400000] scaling_driver : powernow scaling_avail_gov : userspace performance powersave ondemand current_governor : ondemand ondemand specific : sampling_rate : max [10000000] min [10000] cur [20000] up_threshold : 80 scaling_avail_freq : 1700000 1600000 *1400000 scaling frequency : max [1700000] min [1400000] cur [1400000] turbo mode : enabled [CPU7] failed to get cpufreq parameter cpu id : 8 affected_cpus : 8 cpuinfo frequency : max [1700000] min [1400000] cur [1400000] scaling_driver : powernow scaling_avail_gov : userspace performance powersave ondemand current_governor : ondemand ondemand specific : sampling_rate : max [10000000] min [10000] cur [20000] up_threshold : 80 scaling_avail_freq : 1700000 1600000 *1400000 scaling frequency : max [1700000] min [1400000] cur [1400000] turbo mode : enabled [CPU9] failed to get cpufreq parameter cpu id : 10 affected_cpus : 10 cpuinfo frequency : max [1700000] min [1400000] cur [1400000] scaling_driver : powernow scaling_avail_gov : userspace performance powersave ondemand current_governor : ondemand ondemand specific : sampling_rate : max [10000000] min [10000] cur [20000] up_threshold : 80 scaling_avail_freq : 1700000 1600000 *1400000 scaling frequency : max [1700000] min [1400000] cur [1400000] turbo mode : enabled [CPU11] failed to get cpufreq parameter cpu id : 12 affected_cpus : 12 cpuinfo frequency : max [1700000] min [1400000] cur [1700000] scaling_driver : powernow scaling_avail_gov : userspace performance powersave ondemand current_governor : ondemand ondemand specific : sampling_rate : max [10000000] min [10000] cur [20000] up_threshold : 80 scaling_avail_freq : *1700000 1600000 1400000 scaling frequency : max [1700000] min [1400000] cur [1700000] turbo mode : enabled [CPU13] failed to get cpufreq parameter cpu id : 14 affected_cpus : 14 cpuinfo frequency : max [1700000] min [1400000] cur [1400000] scaling_driver : powernow scaling_avail_gov : userspace performance powersave ondemand current_governor : ondemand ondemand specific : sampling_rate : max [10000000] min [10000] cur [20000] up_threshold : 80 scaling_avail_freq : 1700000 1600000 *1400000 scaling frequency : max [1700000] min [1400000] cur [1400000] turbo mode : enabled [CPU15] failed to get cpufreq parameter ``` There's a lot more going on there then before, I'm noticing I'm now boostin= g ~3Ghz! :tada: ``` [user@dom0 ~]$ xenpm start 1|grep Avg freq Avg freq2975000KHz Avg freq2975000KHz Avg freq3009000KHz Avg freq3009000KHz Avg freq3179000KHz Avg freq3179000KHz Avg freq3179000KHz Avg freq3179000KHz Avg freq2771000KHz Avg freq2771000KHz Avg freq2839000KHz Avg freq2839000KHz Avg freq2873000KHz Avg freq2873000KHz Avg freq2924000KHz Avg freq2924000KHz ``` > > Are you running Qubes? For some reason xen-acpi-processor doesn't > > load there automatically. Yeah I'm running Qubes 4.1 (Xen 4.14), interesting it's not auto loading, I= 'll create an issue. > > > This was somewhat expected as Ryzen 4000 series CPUs are quite new, so = as a workaround I tried putting `cpufreq=3Ddom0-kernel dom0_max_vcpus=3D8 d= om0_vcpus_pin` onto CMDLINE, from what I've read this should essentially pa= ss control for CPU frequency scaling down to dom0's kernel (5.11.4). > > > > However acpi-cpufreq doesn't load, when trying to insmod it I get the f= ollowing error `insmod: ERROR: could not insert module acpi-cpufreq.ko: No = such device` > > > > I can't seem to see anything related to Xen relinquishing control to do= m0 in Xen's console, any help would be appreciated > > I haven't tried using cpufreq=3Ddom0-kernel, so I can't help here. No worries, I think it maybe a depreciated option now. > > Regards, > > Jason Cheers, Dylanger From xen-devel-bounces@lists.xenproject.org Tue Mar 16 14:27:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 14:27:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98304.186357 (Exim 4.92) (envelope-from ) id 1lMAf8-0007LV-AX; Tue, 16 Mar 2021 14:27:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98304.186357; Tue, 16 Mar 2021 14:27:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAf8-0007LO-7i; Tue, 16 Mar 2021 14:27:10 +0000 Received: by outflank-mailman (input) for mailman id 98304; Tue, 16 Mar 2021 14:27:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAf6-0007LJ-UG for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 14:27:08 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f6916d55-6b5b-4832-bef6-19585d47080c; Tue, 16 Mar 2021 14:27:07 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 502DFAC75; Tue, 16 Mar 2021 14:27:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6916d55-6b5b-4832-bef6-19585d47080c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615904826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/1j9Ff2jV/b/CPFIP6stH7jt/5y0/txE3Pw0WedSKhc=; b=rP3yqDyTITgXnX8Gd74Tt7g0DhL67EWm/knP3vK1rChhjUqqnYEW0ZQvY7kUYJ1dv2aFNW i73GOIr7BRXagOfWiwCf7m/gsh2dngMP36n/UOpjPxZhxLhMzrtFT+Sws/gDqTsTJD97Jp YAddpBXJ2FITM/hDGZY5QRfNYllzzOE= To: "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Wei Liu , Anthony Perard , Juergen Gross , Boris Ostrovsky From: Jan Beulich Subject: libxl / xen-pciback interaction Message-ID: Date: Tue, 16 Mar 2021 15:27:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit All, while trying to test a pciback fix for how SR-IOV VFs get placed in the guest PCI topology I noticed that my test VM would only ever see the 1st out of 3 VFs that I passed to it. As it turns out, the driver watches its own (backend) node, and upon first receiving notification it evaluates state found in xenstore to set up the backend device. Subsequently it switches the device to Initialised. After this switching, not further instances of the watch triggering would do anything. In all instances I observed the watch event getting processed when the "num_devs" node still reported 1. Trying to deal with this in libxl, by delaying the writing of the "num_devs" node, led to a fatal error ("num_devs" not being available to read) in the driver, causing the device to move to Closing state. Therefore I decided that the issue has to be addressed in the driver, resulting in a patch (reproduced below) that I'm not overly happy with. I think the present libxl behavior is wrong - it shouldn't trigger driver initialization without having fully populated the information the driver is supposed to consume for its device initialization. The only solution that I can think of, however, doesn't look very appealing either: Instead of putting all pieces of the data for one device in a transaction, make a single transaction cover all devices collectively. Are there opinions about where to address the issue, or suggestions as to better approaches than the ones shown / outlined? While doing this it also occurred to me as odd how "num_devs" is actually used: It's not really a "number of devices" indicator, but instead a "next device has this number" one: libxl reads the present value and increments it by one for every new device. Destroying (hot-unplugging) of devices doesn't have any effect on the value. If addition / removal of a device happens a number of times for a VM, quite a few leftover, no longer used entries would accumulate afaict. This isn't only consuming space in xenstore for no good reason, but also means pciback has to do an increasing amount of processing every time a reconfigure event happens. Jan xen-pciback: reconfigure also from backend watch handler When multiple PCI devices get assigned to a guest right at boot, libxl incrementally populates the backend tree. The writes for the first of the devices trigger the backend watch. In turn xen_pcibk_setup_backend() will set the XenBus state to Initialised, at which point no further reconfigures would happen unless a device got hotplugged. Arrange for reconfigure to also get triggered from the backend watch handler. Signed-off-by: Jan Beulich Cc: stable@vger.kernel.org --- I will admit that this isn't entirely race-free (with the guest actually attaching in parallel), but from the looks of it such a race ought to be benign (not the least thanks to the mutex). Ideally the tool stack wouldn't write num_devs until all devices had their information populated. I tried doing so in libxl, but xen_pcibk_setup_backend() calling xenbus_dev_fatal() when not being able to read that node prohibits such an approach (or else libxl and driver changes would need to go into use in lock-step). I wonder why what is being watched isn't just the num_devs node. Right now the watch triggers quite frequently without anything relevant actually having changed (I suppose in at least some cases in response to writes by the backend itself). --- a/drivers/xen/xen-pciback/xenbus.c +++ b/drivers/xen/xen-pciback/xenbus.c @@ -359,7 +359,8 @@ out: return err; } -static int xen_pcibk_reconfigure(struct xen_pcibk_device *pdev) +static int xen_pcibk_reconfigure(struct xen_pcibk_device *pdev, + enum xenbus_state state) { int err = 0; int num_devs; @@ -374,8 +375,7 @@ static int xen_pcibk_reconfigure(struct mutex_lock(&pdev->dev_lock); /* Make sure we only reconfigure once */ - if (xenbus_read_driver_state(pdev->xdev->nodename) != - XenbusStateReconfiguring) + if (xenbus_read_driver_state(pdev->xdev->nodename) != state) goto out; err = xenbus_scanf(XBT_NIL, pdev->xdev->nodename, "num_devs", "%d", @@ -500,6 +500,9 @@ static int xen_pcibk_reconfigure(struct } } + if (state != XenbusStateReconfiguring) + goto out; + err = xenbus_switch_state(pdev->xdev, XenbusStateReconfigured); if (err) { xenbus_dev_fatal(pdev->xdev, err, @@ -525,7 +528,7 @@ static void xen_pcibk_frontend_changed(s break; case XenbusStateReconfiguring: - xen_pcibk_reconfigure(pdev); + xen_pcibk_reconfigure(pdev, XenbusStateReconfiguring); break; case XenbusStateConnected: @@ -664,6 +667,10 @@ static void xen_pcibk_be_watch(struct xe xen_pcibk_setup_backend(pdev); break; + case XenbusStateInitialised: + xen_pcibk_reconfigure(pdev, XenbusStateInitialised); + break; + default: break; } From xen-devel-bounces@lists.xenproject.org Tue Mar 16 14:30:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 14:30:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98306.186370 (Exim 4.92) (envelope-from ) id 1lMAiK-0008CU-QV; Tue, 16 Mar 2021 14:30:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98306.186370; Tue, 16 Mar 2021 14:30:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAiK-0008CN-Mp; Tue, 16 Mar 2021 14:30:28 +0000 Received: by outflank-mailman (input) for mailman id 98306; Tue, 16 Mar 2021 14:30:27 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAiJ-0008CI-Ki for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 14:30:27 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 74006899-4a21-4cbd-8182-282d17db0948; Tue, 16 Mar 2021 14:30:26 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5A508AC24; Tue, 16 Mar 2021 14:30:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74006899-4a21-4cbd-8182-282d17db0948 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615905025; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4A2LYziD1JqclB2MuncuRlyny5vbQA1utP7FCnQOn6A=; b=m8LgtBEhtaIq3OwOZ8W61Lr3595U0cmAFLAE8/ngZdjteGnuXTcidNulWPyWlhJrB9boPH f2DXHVNBUhOPCQ9Uxylxv5ka2DsTc3IcqYZqswIiP3qappwNmKv4aIoQ/1UpTmVLYWaGUc UhxBU3BVoTVPblZU72mxKwu4UFymu4k= Subject: Re: AMD Ryzen 4000 (Mobile) cpufreq issues To: Dylanger Daly References: Cc: "xen-devel@lists.xenproject.org" From: Jan Beulich Message-ID: Date: Tue, 16 Mar 2021 15:30:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 16.03.2021 04:02, Dylanger Daly wrote: > It appears AMD Ryzen 4000 based CPUs are not supported by `xenpm`, running `xenpm get-cpufreq-states` returns nothing and `get-cpufreq-para` returns `failed to get cpufreq parameter` > > This was somewhat expected as Ryzen 4000 series CPUs are quite new, so as a workaround I tried putting `cpufreq=dom0-kernel dom0_max_vcpus=8 dom0_vcpus_pin` onto CMDLINE, from what I've read this should essentially pass control for CPU frequency scaling down to dom0's kernel (5.11.4). Just fyi, seeing that you found a solution for your problem: I firmly believe "cpufreq=dom0-kernel" should never have been introduced. I'm not surprised at all if, as it looks, it stopped working at some point. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 16 14:32:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 14:32:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98309.186382 (Exim 4.92) (envelope-from ) id 1lMAk9-0008Lb-5j; Tue, 16 Mar 2021 14:32:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98309.186382; Tue, 16 Mar 2021 14:32:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAk9-0008LU-1r; Tue, 16 Mar 2021 14:32:21 +0000 Received: by outflank-mailman (input) for mailman id 98309; Tue, 16 Mar 2021 14:32:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAk7-0008LP-HL for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 14:32:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAk2-0004jR-7o; Tue, 16 Mar 2021 14:32:14 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMAk1-00011s-Vm; Tue, 16 Mar 2021 14:32:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=P38jW0ZrUc4mgSmrD2bRZCVC/piTf3mnY1PCdJqr4yA=; b=VfXg7Cio5cfhlpUljWStQBUwUI 2ChnFh+yjKCCi5slEyXqmU4bhS6pnAwJas/MQOdZwIeac1LDBy8bJp7C4fzDIWNvM47vkBRBAZGDi aJUKnRR3L1v+KaQfRSF6xsaVVD8fXV23zWTocNPeyWq8rp4GV96PZ3eMgreJrby3Xso8=; Subject: Re: [PATCH for-4.15 v2] xen: Bump the minimum version of GCC supported to 4.9 for arm32 and 5.1 on arm64 To: Ian Jackson Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, volodymyr_babchuk@epam.com, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20210313134158.24363-1-julien@xen.org> <24655.19838.973233.143341@mariner.uk.xensource.com> From: Julien Grall Message-ID: <56403f29-5ee3-97f3-1a74-34254669adb4@xen.org> Date: Tue, 16 Mar 2021 14:32:11 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <24655.19838.973233.143341@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Ian, On 15/03/2021 12:05, Ian Jackson wrote: > Julien Grall writes ("[PATCH for-4.15 v2] xen: Bump the minimum version of GCC supported to 4.9 for arm32 and 5.1 on arm64"): >> From: Julien Grall >> >> Compilers older than 4.8 have known codegen issues which can lead to >> silent miscompilation: >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 >> >> Furthermore, pre-4.9 GCC have known bugs (including things like >> internal compiler errors on Arm) which would require workaround (I >> haven't checked if we have any in Xen). >> >> The minimum version of GCC to build the hypervisor on arm is now >> raised to 4.9. >> >> In addition to that, on arm64, GCC version >= 4.9 and < 5.1 have been >> shown to emit memory references beyond the stack pointer, resulting in >> memory corruption if an interrupt is taken after the stack pointer has >> been adjusted but before the reference has been executed. >> >> Therefore, the minimum for arm64 is raised to 5.1. >> >> Signed-off-by: Julien Grall > > Release-Acked-by: Ian Jackson Thanks! I have committed the patch with Bertrand and Stefano's reviewed-by. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 16 14:35:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 14:35:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98313.186398 (Exim 4.92) (envelope-from ) id 1lMAmp-0008V5-LZ; Tue, 16 Mar 2021 14:35:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98313.186398; Tue, 16 Mar 2021 14:35:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAmp-0008Uy-Hm; Tue, 16 Mar 2021 14:35:07 +0000 Received: by outflank-mailman (input) for mailman id 98313; Tue, 16 Mar 2021 14:35:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAmo-0008Ut-MR for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 14:35:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAmm-0004nP-KJ; Tue, 16 Mar 2021 14:35:04 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMAmm-0001NL-Bi; Tue, 16 Mar 2021 14:35:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=1JgT5H2OswUF1HRhz3gQ0+ex4CQvD4/YhzhA6QiIwlM=; b=btTiuOLpn8Q8zeg6E5QAV+ejC4 YOfc+AsUNfX5o5YlnXhyRf4OzptfiRZLRWXY4EMPUg1UUp/+2V8KLVCJGYMTFJ8ek82cr+APw6W9R ai/Y9FV2pq6t0jSl9WZ3BvpeccpGpvIrtAL8ocFeJRocerKnKj1is80NR0E52jN7wCi8=; Subject: Re: [PATCH for-4.15] SUPPORT.MD: Mark C XenStored LiveUpdate as Tech Preview To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Julien Grall , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Juergen Gross References: <20210313135500.27241-1-julien@xen.org> <43d6d118-308d-6bb0-3b91-7dc0f8a38d56@citrix.com> From: Julien Grall Message-ID: <663f08cf-a7cb-2e53-fe22-69d232e6aa07@xen.org> Date: Tue, 16 Mar 2021 14:35:02 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <43d6d118-308d-6bb0-3b91-7dc0f8a38d56@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi, On 15/03/2021 12:17, Andrew Cooper wrote: > On 13/03/2021 13:55, Julien Grall wrote: >> From: Julien Grall >> >> Support to liveupdate C XenStored was adding during the 4.15 >> development cycle. Add a section in SUPPORT.MD to explain what is the >> support state. >> >> For now, it is a tech preview. >> >> Signed-off-by: Julien Grall >> >> --- >> >> CC: Juergen Gross >> >> It looks like the OCaml side was not merged in 4.15. > > Yes it was. > >> So I have only >> described the support state for C XenStored. > > What about stub-cxenstored?  I think it wants pointing out specifically, > whatever its status, to avoid confusion. Is it even working? @Juergen? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 16 14:36:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 14:36:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98316.186409 (Exim 4.92) (envelope-from ) id 1lMAnx-0000AL-VQ; Tue, 16 Mar 2021 14:36:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98316.186409; Tue, 16 Mar 2021 14:36:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAnx-0000AE-SU; Tue, 16 Mar 2021 14:36:17 +0000 Received: by outflank-mailman (input) for mailman id 98316; Tue, 16 Mar 2021 14:36:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAnw-0000A2-SM for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 14:36:16 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 363a8f4c-e242-4bf1-ac16-9fa6a33d4545; Tue, 16 Mar 2021 14:36:16 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3AA0DAC24; Tue, 16 Mar 2021 14:36:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 363a8f4c-e242-4bf1-ac16-9fa6a33d4545 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615905375; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h/q4K9e4H0Zu3cSkwfRmZdcTKIqOV0RtY9aTJQ2kmAw=; b=MN4UvV2y14Pgd62GNgoUQ6iTFmLXzlASADkRxIEBsP/Dsmh72MqFP6zf86UBswjWegZiwV dNDLKyxPLXJJhrcjyWURy7/mPWx1PxU3ybSTYp8322PPPXY7LjPOlUtzoN6JGU1/LJgqeo 99EGkmVlHrJ+JWKpCOZGNZYR5fgHdjw= Subject: Re: [PATCH for-4.15] SUPPORT.MD: Mark C XenStored LiveUpdate as Tech Preview To: Julien Grall , Andrew Cooper , xen-devel@lists.xenproject.org Cc: Julien Grall , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu References: <20210313135500.27241-1-julien@xen.org> <43d6d118-308d-6bb0-3b91-7dc0f8a38d56@citrix.com> <663f08cf-a7cb-2e53-fe22-69d232e6aa07@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <03787b98-9acd-f1a8-66d4-953d7c99ee0d@suse.com> Date: Tue, 16 Mar 2021 15:36:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <663f08cf-a7cb-2e53-fe22-69d232e6aa07@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WJl28zx2WOijmssbcSvivsKFEuYYgKkAU" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WJl28zx2WOijmssbcSvivsKFEuYYgKkAU Content-Type: multipart/mixed; boundary="cnWzeKboVdvbeNdJVFkDV2gI3IBfIvU8W"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , Andrew Cooper , xen-devel@lists.xenproject.org Cc: Julien Grall , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Message-ID: <03787b98-9acd-f1a8-66d4-953d7c99ee0d@suse.com> Subject: Re: [PATCH for-4.15] SUPPORT.MD: Mark C XenStored LiveUpdate as Tech Preview References: <20210313135500.27241-1-julien@xen.org> <43d6d118-308d-6bb0-3b91-7dc0f8a38d56@citrix.com> <663f08cf-a7cb-2e53-fe22-69d232e6aa07@xen.org> In-Reply-To: <663f08cf-a7cb-2e53-fe22-69d232e6aa07@xen.org> --cnWzeKboVdvbeNdJVFkDV2gI3IBfIvU8W Content-Type: multipart/mixed; boundary="------------7B5EC05A112CD4B92482378F" Content-Language: en-US This is a multi-part message in MIME format. --------------7B5EC05A112CD4B92482378F Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 16.03.21 15:35, Julien Grall wrote: > Hi, >=20 > On 15/03/2021 12:17, Andrew Cooper wrote: >> On 13/03/2021 13:55, Julien Grall wrote: >>> From: Julien Grall >>> >>> Support to liveupdate C XenStored was adding during the 4.15 >>> development cycle. Add a section in SUPPORT.MD to explain what is the= >>> support state. >>> >>> For now, it is a tech preview. >>> >>> Signed-off-by: Julien Grall >>> >>> --- >>> >>> CC: Juergen Gross >>> >>> It looks like the OCaml side was not merged in 4.15. >> >> Yes it was. >> >>> So I have only >>> described the support state for C XenStored. >> >> What about stub-cxenstored?=C2=A0 I think it wants pointing out specif= ically, >> whatever its status, to avoid confusion. >=20 > Is it even working? @Juergen? LU of xenstore-stubdom isn't working yet. Juergen --------------7B5EC05A112CD4B92482378F Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------7B5EC05A112CD4B92482378F-- --cnWzeKboVdvbeNdJVFkDV2gI3IBfIvU8W-- --WJl28zx2WOijmssbcSvivsKFEuYYgKkAU Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBQwl4FAwAAAAAACgkQsN6d1ii/Ey/M nwf9GaQwuaRlq+ZgvMcQEyf1+uTjgzBk1gH4K4Ft8gHBSXwj6jS3FaaDeyBoAyBmqs0MA4iN6ZtK mJKXjTGwusVR6pkHZRsWkl63UFgg9t1QWD6ZqoaiTxhC2JW49O1+nvnsByudAN/Q/uW/NvAiByHQ wiTaE2booXcMragR1MdGButgXsto09Aq7aoqt3a2F5nS5S6M/LcnCSqlo/uHnh1LXrA5kINrD8fK St+qMFR5abZbK4jYHRcCcWrx1VAoFma5RIt4Y0xiVbKosfpaihQM3H+rIKZP2INB3HGfifX6gUiv pil2FEH03/DEpjY5PnW774wRrjH6kMasWy1lqwZPoA== =qQrn -----END PGP SIGNATURE----- --WJl28zx2WOijmssbcSvivsKFEuYYgKkAU-- From xen-devel-bounces@lists.xenproject.org Tue Mar 16 14:39:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 14:39:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98319.186421 (Exim 4.92) (envelope-from ) id 1lMArA-0000O5-EN; Tue, 16 Mar 2021 14:39:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98319.186421; Tue, 16 Mar 2021 14:39:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMArA-0000Ny-BY; Tue, 16 Mar 2021 14:39:36 +0000 Received: by outflank-mailman (input) for mailman id 98319; Tue, 16 Mar 2021 14:39:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAr8-0000Nt-IN for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 14:39:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAr7-0004qs-0Q; Tue, 16 Mar 2021 14:39:33 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMAr5-0001m7-R7; Tue, 16 Mar 2021 14:39:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=EBKEQhSIx4f0lLRksQ9MTl13pQWhozrcIVkbXi2KStQ=; b=2UanwEREz/J+8bjz5IkGiCpXrI DhBJk6uKK2b9Eqo8EM2gTF62xXhApB/6mOf/nJc1mbECT3Z1/NvPHVU7i6abY4X4psPZqUi+d1mme 5F9sxDV1G545Xfd5NFf57iEaFYke/nxKNRuEELqHfXvoELSow9x6aUgO+lPkkH1+CeYI=; Subject: Re: [PATCH for-4.15] SUPPORT.MD: Mark C XenStored LiveUpdate as Tech Preview To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Andrew Cooper , xen-devel@lists.xenproject.org Cc: Julien Grall , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu References: <20210313135500.27241-1-julien@xen.org> <43d6d118-308d-6bb0-3b91-7dc0f8a38d56@citrix.com> <663f08cf-a7cb-2e53-fe22-69d232e6aa07@xen.org> <03787b98-9acd-f1a8-66d4-953d7c99ee0d@suse.com> From: Julien Grall Message-ID: Date: Tue, 16 Mar 2021 14:39:28 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <03787b98-9acd-f1a8-66d4-953d7c99ee0d@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 16/03/2021 14:36, Jürgen Groß wrote: > On 16.03.21 15:35, Julien Grall wrote: >> Hi, >> >> On 15/03/2021 12:17, Andrew Cooper wrote: >>> On 13/03/2021 13:55, Julien Grall wrote: >>>> From: Julien Grall >>>> >>>> Support to liveupdate C XenStored was adding during the 4.15 >>>> development cycle. Add a section in SUPPORT.MD to explain what is the >>>> support state. >>>> >>>> For now, it is a tech preview. >>>> >>>> Signed-off-by: Julien Grall >>>> >>>> --- >>>> >>>> CC: Juergen Gross >>>> >>>> It looks like the OCaml side was not merged in 4.15. >>> >>> Yes it was. >>> >>>> So I have only >>>> described the support state for C XenStored. >>> >>> What about stub-cxenstored?  I think it wants pointing out specifically, >>> whatever its status, to avoid confusion. >> >> Is it even working? @Juergen? > > LU of xenstore-stubdom isn't working yet. Ok. Would renaming the section to "Dom0 C Xen-Stored LiveUpdate" would be suitable? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 16 14:40:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 14:40:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98324.186433 (Exim 4.92) (envelope-from ) id 1lMArw-0001Be-SC; Tue, 16 Mar 2021 14:40:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98324.186433; Tue, 16 Mar 2021 14:40:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMArw-0001BX-PB; Tue, 16 Mar 2021 14:40:24 +0000 Received: by outflank-mailman (input) for mailman id 98324; Tue, 16 Mar 2021 14:40:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMArv-0001BQ-Ba for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 14:40:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAru-0004tM-Ea; Tue, 16 Mar 2021 14:40:22 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMAru-0001pq-8u; Tue, 16 Mar 2021 14:40:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Q4x92eJQXVTjGSQCEF4eVh1G2P/+GTVFhlijNEpD2CM=; b=wwTbf2+WOUZ0rAaJ4wgee9A7uO J0bh9KwuOOTZhamshVRT+67BZaigKbE9d2PQYoUFJ6+euHi2NqUCJYrafiDwymig4I151j2KVseUz XmC/ubg2DJ0bn7pLJ5xvrma4+koQOD/xjq0qQSe5FCmI8P/LnvCpN6Jsu4b/5Xhveyb8=; Subject: Re: [PATCH v2] xen/arm: Use register_t type of cpuinfo entries To: Bertrand Marquis , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk References: <7a6a8c5c33d13fb43f3777f046036b91233534d3.1615804612.git.bertrand.marquis@arm.com> From: Julien Grall Message-ID: <722ebf03-d037-de42-69d7-625f2ae13d2c@xen.org> Date: Tue, 16 Mar 2021 14:40:20 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <7a6a8c5c33d13fb43f3777f046036b91233534d3.1615804612.git.bertrand.marquis@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Bertrand, On 15/03/2021 10:38, Bertrand Marquis wrote: > All cpu identification registers that we store in the cpuinfo structure > are 64bit on arm64 and 32bit on arm32 so storing the values in 32bit on > arm64 is removing the higher bits which might contain information in the > future. > > This patch is changing the types in cpuinfo to register_t (which is > 32bit on arm32 and 64bit on arm64) and adding the necessary paddings > inside the unions. > For consistency uint64_t entries are also changed to register_t on 64bit > systems. > > It is also fixing all prints using directly the bits values from cpuinfo > to use PRIregister and adapt the printed value to print all bits > available on the architecture. > > Signed-off-by: Bertrand Marquis Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 16 14:42:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 14:42:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98326.186446 (Exim 4.92) (envelope-from ) id 1lMAtc-0001LL-7k; Tue, 16 Mar 2021 14:42:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98326.186446; Tue, 16 Mar 2021 14:42:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAtc-0001LE-4Q; Tue, 16 Mar 2021 14:42:08 +0000 Received: by outflank-mailman (input) for mailman id 98326; Tue, 16 Mar 2021 14:42:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAtb-0001L9-EW for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 14:42:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAta-0004v0-DS; Tue, 16 Mar 2021 14:42:06 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMAta-0001u4-89; Tue, 16 Mar 2021 14:42:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:References:Cc:To:From:Subject; bh=L/fTNfVtEEXDtNdkuhqM0cmc4L+3SavwYBL00dDdZAg=; b=AP5CDHXBlSc5oc+I3oPK+qHXIY G6kojEBU2eM9IKXV4UXZk7DvRVtQySSs85vgMHKdjtW936SjGx6Ty/bYx6Jyj8uKobaQVA5iDNnoH YqNGcIui3BeOknFHM/Pz7jznb/5fmZ9zlKeNJ7W8AfcH/5y+W8PHT/6GCWuWlNx2fjaA=; Subject: Re: [PATCH v2] xen/arm: Use register_t type of cpuinfo entries From: Julien Grall To: Bertrand Marquis , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk References: <7a6a8c5c33d13fb43f3777f046036b91233534d3.1615804612.git.bertrand.marquis@arm.com> <722ebf03-d037-de42-69d7-625f2ae13d2c@xen.org> Message-ID: <967f25ef-6d17-18b6-1eb1-763efd0882ff@xen.org> Date: Tue, 16 Mar 2021 14:42:04 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <722ebf03-d037-de42-69d7-625f2ae13d2c@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 16/03/2021 14:40, Julien Grall wrote: > Hi Bertrand, > > On 15/03/2021 10:38, Bertrand Marquis wrote: >> All cpu identification registers that we store in the cpuinfo structure >> are 64bit on arm64 and 32bit on arm32 so storing the values in 32bit on >> arm64 is removing the higher bits which might contain information in the >> future. >> >> This patch is changing the types in cpuinfo to register_t (which is >> 32bit on arm32 and 64bit on arm64) and adding the necessary paddings >> inside the unions. >> For consistency uint64_t entries are also changed to register_t on 64bit >> systems. >> >> It is also fixing all prints using directly the bits values from cpuinfo >> to use PRIregister and adapt the printed value to print all bits >> available on the architecture. >> >> Signed-off-by: Bertrand Marquis > > Acked-by: Julien Grall I have committed it to my for-next/4.16 branch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 16 14:44:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 14:44:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98329.186458 (Exim 4.92) (envelope-from ) id 1lMAvj-0001TO-Kx; Tue, 16 Mar 2021 14:44:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98329.186458; Tue, 16 Mar 2021 14:44:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAvj-0001TH-HK; Tue, 16 Mar 2021 14:44:19 +0000 Received: by outflank-mailman (input) for mailman id 98329; Tue, 16 Mar 2021 14:44:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAvh-0001TC-Ou for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 14:44:18 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7803fcb7-5b9b-40a9-a706-fadc4572ec0b; Tue, 16 Mar 2021 14:44:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7803fcb7-5b9b-40a9-a706-fadc4572ec0b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615905856; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=vq1kxDCErFH3ye2opvEmexZIwiPef/LOJbwpjbGKkD4=; b=IsaeW2F87+sNGldiK2+3rxGq8IPPWH0HLqJUiZDxK7H4hwg4gf53UVB0 WyfLsL7CuyIH4KzCi2d4GCfNYRf7JoYFXWV7w+aAe6km2M5Ikb0LVAwVl Hhkq/JR54OP8YH0misfzP4kaXXorPMV+WiE4IKhXLsfpWNubWWaR1sSWk s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: VM6CGPCsYCA3ByD412LBUHkRIwcgEDGq0dW2i5G6Q5p1QE87BCv5DX6ZE3vmWC39xLL4emk/Q4 lBKT1PKibpXFPtNrKzEFmv8lHSPAIr8DDYKMJtPLjqdHua8a7LwBgLA5QMXIS2Qiyjn1DGPRmh W4duAoLFd7YlCN26kcqbiv3KXBss2cGOpKxvbwmkxSL3IyddJ9GbIVgkxMJ9PcN9vkWdzBs0/5 dHg41zI4AWRRxZD91jRe+70t5WS9zQurG9yKmjyX0mCKTnC1Usv/r5TGK71wV7+9Opm1syqR/2 R3g= X-SBRS: 5.2 X-MesageID: 40819300 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:wV8VD63j5FdizruToKyViQqjBDkkLtp033Aq2lEZdDV+dMuEm8 ey2MkKzBOcskd0ZFgMkc2NUZPwI0/02oVy5eAqXIuKeCnDlC+WIJp57Y3kqgePJwTb+vRG3a ltN4hSYeeaMXFAgcz34Ba1Hr8bqbG62ZulnOLPi0pqJDsaCJ1I1RtzCQqQDyRNNWx7LKc5D5 aV645moDetaB0sAviTO39tZYj+juyOvI76Z1o8CwQ/7g6VgXeT9KfiCBSDxH4lOQ9n8PMA8X XPkxG826Wosf2n6jK07QDuxqUTvNPgz9dZbfbgtvQo X-IronPort-AV: E=Sophos;i="5.81,251,1610427600"; d="scan'208";a="40819300" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dkcjwPHUm5DSsIYvii5O9YAS7G/H7mfLtP33MNSEqwqJw/xhhq1Sj+Az4NbHl+6keEm5kxeciUPyg8MsXaA3n7EOWpEYIfTfIuvO8wDm8fNnv5MtjzokNxkkL+yuymQ3KqFAhUa3n9G6n1I1hpNm1FhhtligH59fH257/4FlGHl/6zc15t3m1GQEAK9Y98oiwDNZq5qbS34TsEvQwJ2dpVRmdAX5FPVLIf89zZivhjwd3ssQNr8WikIMTkKfP606yc8uqbpXEJzDaja4CUyjOlCim23vue5xKmSSJJpxm3Q8W5pG4ctxtJkcwVDV5W73riutAuagBkCINFbVabCyjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vq1kxDCErFH3ye2opvEmexZIwiPef/LOJbwpjbGKkD4=; b=Fr/sSlQTvg3bCJ9jAlD4cR/y1OlvlmDqEzaFJoeAeRz/gYlUouU3Xc1fKFUSgKXcwNwIM4POflGXFK/c8XQBxuH4uGNYqrik/AsEGcX/qsJp6OaZvG/+QPohaus+9qsCANJuv/nKMkzkRnRU2FZLYtGoKf1jcGNhDtBdH7HBpBGekfRzjfdngEkLgdaTlEqiFa/HW5IopUo6fljGZwiPLFknK01Kw/FE/WuqYyQb8NLq8+Lbhbh59Z4xnWUCXZcLpxQDMdwpTEouALJ0737NBRe76Uqyxohpc2IoMQ+ALRf/I9qHsZ5pIL9TQy66dghntvdp7ZHYJdawaTFXU0FiMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vq1kxDCErFH3ye2opvEmexZIwiPef/LOJbwpjbGKkD4=; b=xVLG+AbOE5ESVOPStiocKguEJ23a0FnuqYc2zAsJZ2DJ6QEs+Gi8w/z6cs0JxL6sFhNXXxELpg+n5lcu7ouhMZvYiJr+ILg4N5yu6miqM+tLZWiYnoFFRy6LkvVENvsx7CHyLQJpHClhe0Lz/Njvl9eb2kO4nqYRG9LRACH1YMs= Subject: Re: AMD Ryzen 4000 (Mobile) cpufreq issues To: Jan Beulich , Dylanger Daly CC: "xen-devel@lists.xenproject.org" References: From: Andrew Cooper Message-ID: <16899023-31e7-44b1-a0e2-a40f7771c889@citrix.com> Date: Tue, 16 Mar 2021 14:44:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0319.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::19) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6dd6c643-edc3-42de-3f68-08d8e889f673 X-MS-TrafficTypeDiagnostic: BN9PR03MB6028: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MIat6vjzrAosqFNG7hcCTZoSvqEqFbRiXLKV3OIARASGDTTz+iqMInwDgEtylu2nmvWpd2ZtS2KahiNjsvo68EC7x1NEm0RQSCFN40vgidksfgcttIURaTvPI20HoVzpxrVENRE7bihFL0ShbMEi9Sj+q2VsTjXJANHV1AXgPTygT4UuuPq6Yq0jLGy0gCWXFaL/2CnnQ3RlztIG8TaQfLBp3X+W+1WGPeLsemZfo3ufE7vMCH/xGoDJCfbxqaA2e/R01EPX2qzRmHLgdtWiPnsU3221dTR/eI8zHzrhcGGMvUk8n4HxTfRZza9pBG0dPu+G86hzISZsFcPrX2YFBoS3rSUCpZ7b8efeZylrYMJiEGbYYKts1fChGZAudjr8lwt64gpqTJl1+vo1kRp6u4Tm/J7ILeo3hbm2n6OESNG+cCLgAYEdFvLCstFGuRI9WAWc3pGGxRU91RtCYq1PgmXbX3rFZHNtPUsMirxGxlHIYMNXLauTf5z0dblHyt7Uj/iWCCYZZvYDdfhLWYrEXhVp3AVras9a5dqxH/llZwurHjaX7quLuE3/VVtH+AppigJfDHi5SJPOad1l62JUjfiv5CkADg2HFizeaCiIhCY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(396003)(376002)(366004)(346002)(136003)(956004)(36756003)(66946007)(53546011)(2616005)(8676002)(186003)(66476007)(110136005)(26005)(31686004)(31696002)(316002)(16576012)(86362001)(66556008)(6666004)(2906002)(8936002)(6486002)(5660300002)(478600001)(4744005)(4326008)(16526019)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WDZ3TTlUcm92YTBtRng3am00MnM5UG4vSlJDcEN2bDB5VHZXUGNZNUI0anRj?= =?utf-8?B?SHBDWkJRV3MvL0c2Rk0vT2tzK3I5NU9RQXFRdGNDTXB1cy95QkhwVkdzTGNk?= =?utf-8?B?R3FNQzUxRXk2N0tHWmo2N1l3akVUMmdhUmwzOHJtV0VtVnB6eG9aNFNtYWVl?= =?utf-8?B?MWE1aDBkU2dyN3p4TXVobm5ld2FtWEE3TW0wU3JQWnNyZnk1WnhZMjlmZldX?= =?utf-8?B?bUVKL25IeE9iaTZuT0xkU1plaWdQVDlLbHFRaHpEdkl1WUM1UXNaRXNRMUdC?= =?utf-8?B?YzNkb0wwaEdzVVd1Q1EwdkVRKzlYekdLQitZTlhTUytBZmxRcEtTTzVTSzJU?= =?utf-8?B?WGRUNStnK3VXaXd6WUkyOXl0M0hYZko0YUxmdzQvdHpONnM3OW5RNjhSR3hp?= =?utf-8?B?NXV5MksxRi92MFB5ektkVHY1QnUzVVZsSkEzUjg4blJ6WGNxSHJadXphckN6?= =?utf-8?B?cTdlbW05NEFHZDRnWDBSMTdTQlFrZ1JnTHo5RUY3dXFqTDk3eUdYME9mQ1FN?= =?utf-8?B?NjMvRUtBUVhMeFhGTTJQMEhLRzJ2L21ORlNIVnllMHNVNXVlaHhGZmhkK0lx?= =?utf-8?B?RTJPR3Yyc0tGM1JoaWc5TEtranYzUFEyalpFYS9tSlpqM1czK3JNK0haTkxw?= =?utf-8?B?N2xTcm04ZUtYMjVPMW1DODNuV1haQ00rS0pjMUhrWVhJdzhyemRNSTRnREFP?= =?utf-8?B?dmx2TEc5NGdRbStLaVowbGlKMEI0dytZMzZrOWhsV3FBUFRDc3dmb3dTdWZ0?= =?utf-8?B?dXlvdFNoTFl4NkJKZUxWMzNWZWgzN2xCWXdCcmY0NGVjazFOZEljUDhVZm1i?= =?utf-8?B?ZkdSdDZnajVoNlVSamQ4UU5CUDYzaGV0S0hSdWs5aHNuck04MHl0ZzMwOTB1?= =?utf-8?B?T0ZjTlJCR1hud21kRVBJMk1JSDJlbXlCYlVzRS83UUpBOXNHM3EzTmpNcSt0?= =?utf-8?B?cjIxNHp1SmFXcVhXcFdVOGtDeXFHSmZySUlaZ0xhWTkweTNYSXl5WVg5WXpo?= =?utf-8?B?SVllVGl5RzJLV2FmZ2hHMWs3REFMVUYreEV2YXJhcmNSTW9JM1AyRmswK2o4?= =?utf-8?B?eC9ReEdyU3MvMVhqK1JoMFR1MFJGNXRyRWorbHFXMlowb21ZWVN1SGtVUVNG?= =?utf-8?B?aWwxcGI1Y3E1SDNPTDJHNjhzRXZLeDhLb0J4Z3lvQ2FkaVlzeGNaakJJVWgz?= =?utf-8?B?YVpIN3BzK3hRTmdBcFlGVW1iS3U5VFpOUWRxMTl5UDlZNjZGWklHY2RXWTh0?= =?utf-8?B?RlZvWWUxUUUxZGZyNmJYK2d4dDRwTnZ1dWxuL2s4RnhQWTVRcFo2VmhBWUZm?= =?utf-8?B?djlUQnJHSkNPalNkQk5VMC9TWHZLVWY4aWdvWnhxM2grK3UwZmYyWkUzQlFR?= =?utf-8?B?NDcwdldNS2JLWVBBQUlvUEdmTGxWc3FFMFV0c2x0WjlFUjJSdlFkTkx4TG1L?= =?utf-8?B?TXg2b0RCWFJnaGJseUhXSmxvalNUcHpCUk5ya1VMUUFjYzRvTzFFbDBPbkRB?= =?utf-8?B?UldJNy9MbncxZmVSMlpJNlh6RVpPYmZMald1UXZsQmNiLy9vMVVSV3lmM3ZF?= =?utf-8?B?Z3lieDJJbmQ5dmRqOS90Sk5YbnJtZWlNblEwaHgzUDZCVkFUQmFIWE5RbFBS?= =?utf-8?B?KzFzYzFpRXlIZHdjS01wL3EveTVTU1hKQ3VxZXplaWVtNk15WGRRVUhtOERt?= =?utf-8?B?NzJaaC8rUEpHbkgyMWJGdTFsMVpUQ1JvaVJGRXJxaFV5MmdoaUo5ZDRHbHFM?= =?utf-8?Q?au2/dYmffX0QFkHVg5CMv0ZZPnwF85gN6sDUwC7?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6dd6c643-edc3-42de-3f68-08d8e889f673 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 14:44:11.8505 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TquZ269X92l1iUJQ4FrjEz+F9XskKvhL1GWb9SQlE43Bce6+TLX2wwf6MresMeYjQmUYiE6iH0lcnQgtUbfqlB7jLUJ8nJaa6ZzaBVp92c8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6028 X-OriginatorOrg: citrix.com On 16/03/2021 14:30, Jan Beulich wrote: > On 16.03.2021 04:02, Dylanger Daly wrote: >> It appears AMD Ryzen 4000 based CPUs are not supported by `xenpm`, running `xenpm get-cpufreq-states` returns nothing and `get-cpufreq-para` returns `failed to get cpufreq parameter` >> >> This was somewhat expected as Ryzen 4000 series CPUs are quite new, so as a workaround I tried putting `cpufreq=dom0-kernel dom0_max_vcpus=8 dom0_vcpus_pin` onto CMDLINE, from what I've read this should essentially pass control for CPU frequency scaling down to dom0's kernel (5.11.4). > Just fyi, seeing that you found a solution for your problem: I > firmly believe "cpufreq=dom0-kernel" should never have been > introduced. I'm not surprised at all if, as it looks, it stopped > working at some point. I agree that cpufreq=dom0-kernel can't reasonably work. Lets just take it out - it doesn't serve any good tricking people into thinking it might plausibly work. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Mar 16 14:47:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 14:47:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98331.186470 (Exim 4.92) (envelope-from ) id 1lMAyP-0001d4-4a; Tue, 16 Mar 2021 14:47:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98331.186470; Tue, 16 Mar 2021 14:47:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAyP-0001cw-06; Tue, 16 Mar 2021 14:47:05 +0000 Received: by outflank-mailman (input) for mailman id 98331; Tue, 16 Mar 2021 14:47:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMAyN-0001cq-Gy for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 14:47:03 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:fe0c::620]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5a120ad2-e93a-4ebc-b14f-42fbf4ec4ebd; Tue, 16 Mar 2021 14:47:01 +0000 (UTC) Received: from AM5PR0701CA0069.eurprd07.prod.outlook.com (2603:10a6:203:2::31) by HE1PR0801MB2122.eurprd08.prod.outlook.com (2603:10a6:3:88::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Tue, 16 Mar 2021 14:46:58 +0000 Received: from VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::16) by AM5PR0701CA0069.outlook.office365.com (2603:10a6:203:2::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.11 via Frontend Transport; Tue, 16 Mar 2021 14:46:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT050.mail.protection.outlook.com (10.152.19.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Tue, 16 Mar 2021 14:46:58 +0000 Received: ("Tessian outbound 26664f7d619a:v87"); Tue, 16 Mar 2021 14:46:57 +0000 Received: from b7b27420c0c0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FDF15061-72CD-4862-B2E1-0D4E3C732977.1; Tue, 16 Mar 2021 14:46:50 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b7b27420c0c0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 16 Mar 2021 14:46:50 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VI1PR0801MB1661.eurprd08.prod.outlook.com (2603:10a6:800:56::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Tue, 16 Mar 2021 14:46:46 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3933.032; Tue, 16 Mar 2021 14:46:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a120ad2-e93a-4ebc-b14f-42fbf4ec4ebd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=502hhquAsz4C6PePJ+D/1WquiqQ1u/qvKv1jDcf709k=; b=AWxLz9E8lFPy+HY6EVFkKEmWOxdAqbc/gu6AFSJVbydxQ+qYJbJ/ImIrXml9EyAv4dpKsiLPfFnQJndZhki/cscSAySKpKA1KlW+AhxEvYcv7ImG6AjZVs1bBxT5u4iloUfq15gWp/c+P6Yy8wbOLxEYKCEa/MAAoB8IU9+ysiM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 01b4c183cc878b8e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dCux68JHLE9/txYFI8wl6rnyMh2VoWR1+TyNvlGyxRhxVadh3x0Ga1ERdmdSQpjH/LTpox+Y6kcXveG3YW7pNuh+yddrG7C7jCLPoXhNLi5gooxUt8P/l7dmVNG8Nob4Ceag5dKaLfD61jQCRdjsRTKIYXYAfWm+jViBJKCofydpvcp4EAMnPTNcmjxam/apEYCGpkT903A2a4oN5VAV1dkj1g38RDW4ZhxmsokDvLS9WcJRnOr7qIi8rD6k/lczGP3IhVjjLncPI04lUEbELj/dG3PSx8aJhKlTBd3ipis6V2syDOjolb76dmG5yQYUfjOPSdBqAQteyKOPDRSEMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=502hhquAsz4C6PePJ+D/1WquiqQ1u/qvKv1jDcf709k=; b=MYkbMM7P/KBCkR6x0K31PRGDTNF78ft9x6SaCqHlPlv6kWSFuNwYoJvsK9dMMH7tAzYOFOZ1E2JNGCzJBzf/0/BrF6g0a2r9vuIz4qasqZCt388FM7ADY+lxMojZhdLHPz7Fwkke9vG2GQKTc7aZCtg6iod5YDtIhMS7b/rGg7EhBX2Z7FBtML++n3kRbwGmnnyp2+KMowxEvat87iZFmI9YQtLRNAWMKNyKgv1OIT98Qk4lEu8laC1G4utXR0ieAzgqtjepXy+iWxB+PftZ58c0H7bDm2hpJhXuc/cFivNvlb3GJrz/MvSx3/Xe5yP4sppJ7hn0SRSX3OdnWR1xdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=502hhquAsz4C6PePJ+D/1WquiqQ1u/qvKv1jDcf709k=; b=AWxLz9E8lFPy+HY6EVFkKEmWOxdAqbc/gu6AFSJVbydxQ+qYJbJ/ImIrXml9EyAv4dpKsiLPfFnQJndZhki/cscSAySKpKA1KlW+AhxEvYcv7ImG6AjZVs1bBxT5u4iloUfq15gWp/c+P6Yy8wbOLxEYKCEa/MAAoB8IU9+ysiM= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v2] xen/arm: Use register_t type of cpuinfo entries Thread-Topic: [PATCH v2] xen/arm: Use register_t type of cpuinfo entries Thread-Index: AQHXGYdqjLxhKB84IUOgt1y/chNQHKqGsYUAgAAAfACAAAFPgA== Date: Tue, 16 Mar 2021 14:46:45 +0000 Message-ID: <1BBC6549-FC75-4644-A05D-0B79EE4D62F1@arm.com> References: <7a6a8c5c33d13fb43f3777f046036b91233534d3.1615804612.git.bertrand.marquis@arm.com> <722ebf03-d037-de42-69d7-625f2ae13d2c@xen.org> <967f25ef-6d17-18b6-1eb1-763efd0882ff@xen.org> In-Reply-To: <967f25ef-6d17-18b6-1eb1-763efd0882ff@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.26.33.241] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0e2170b5-0b05-4614-5a0b-08d8e88a59d2 x-ms-traffictypediagnostic: VI1PR0801MB1661:|HE1PR0801MB2122: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xHs+Hwgm8PqBP3GdEw+7dCqHubk3FPTernHiDZXmUkAIhzJNGyQtWe9q1uBdE3czQOXZ+CJc9FzijPOZh97+a3+LCvEtSQ44klkHm44CCzw46IZs2nim8BU8yXLaitaHW1iIPvMTCXBqnZK2C51pvbD6ys+kIR9rFd1l3FdgPaDZF7MwelatBqoOS9d2hOQxTsgZJXLzvGqgPsTeWUwpzqHVOPzAb//Jh5vsUiRz5tP8QPFxfHZ69898QBIoCz7KOiYEax5pCdWdVYNWlrMMMO79sQj1yekDCRMLguSWhfFfb9j2O2+IcDLtSIryKqSkBQDzA6IPumq3rr6ZB7opFCFHTPr+RLmZFrrUDuM5o76iDKycCB8DnU9qSPupIt7h6ryW2Dacu9PuwRZG/sBwM/GnPKEoPDF3pCn0mrIpR/B76hO8JhzqL8n+4vdPr02BEJ8AL9IOwmsJrL+Bv2tVJtbXaE3CWv1fWgrfwPNSxq250t0kZZEttN581EQipF/VunBSapoUOOwvrE31il8Vtq3KfxzJs5Ug1YN5a07tPMrkOeK6NJksafBpW5tmGY5xg8JegR7vnsgD5WcwkFFlHD1v39+XiwktYcCdasgVA8sfFuF5w+wnjCzq6UG7uCLD X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39850400004)(366004)(346002)(396003)(136003)(376002)(33656002)(66946007)(91956017)(54906003)(76116006)(478600001)(2906002)(316002)(186003)(26005)(86362001)(6916009)(8936002)(8676002)(6512007)(2616005)(66556008)(71200400001)(66476007)(6486002)(6506007)(55236004)(66446008)(5660300002)(64756008)(53546011)(4326008)(36756003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?h/rVXO2p/JSW/5nFGk2XRJREaOugeAkdAXHlLDS2V/GlO1UvzJqqZuRsORhU?= =?us-ascii?Q?2gZ4HCzFMQcK6OApLx4qHNKVfxrNPox3brL+t1Pr41C5V48vojNNHYm/Vk6B?= =?us-ascii?Q?2xun1e00RRgnBOVD/kUKHcrX0QVuO1UouLEkbi7Vha6I6nmBwdDvrdXZ7RmS?= =?us-ascii?Q?h4CHKKFCBAYFAQgJ24S/5Zme9X8PnA0Y4llD4udHMuFOOqGcDdX0RlayIact?= =?us-ascii?Q?IiFdtFfOS3wl+Z0We/JbIlRXzXeJVCX/IFPXMv5llHedJknMMvx8ca6j5xwJ?= =?us-ascii?Q?CS4WtT+0Ul/W4XLAS4HczX3PDXKXpI0QlhzQupdqhl3Otar5c0jPWl15jMgH?= =?us-ascii?Q?IaYF989AwN57IdCafFlRkU+q32o6zdj30E8ytC/zDZyFbL28ctnqxhYTsF+U?= =?us-ascii?Q?B47M+7UNWqzRjQwszLnCZDmU1LfTxqXshyFeeNNqC182at+sF/rgSlKi3bf+?= =?us-ascii?Q?nharSyQ1GZkZByZKR+rluWRbTxW3d4Sf/bUDvjxYjL+RvsQtVA/6SQnpIGZb?= =?us-ascii?Q?ThAb6H8cgr6K5AZK+YQgXEQYDTa1SEz/7ZBbAPBUfl4us2YLjjgacvkJm7+S?= =?us-ascii?Q?yaE54XVvVvIpZSpKdlueHVRwDJGhgeceB4c2VobzjXGP3Lg2vgoqrkFExm9r?= =?us-ascii?Q?Ioim+L16vvukGmnSYb4DY3UqW8kRWaI9a0zlEsu1F9+CpeYUwS+3s7WC5uT4?= =?us-ascii?Q?SdGGX17UwzU8H8gcNRl/lPwWvgogE3w+zwqNaWXpNnVdQVxjZay2UoeP0Zwc?= =?us-ascii?Q?fxI5pOAsa+PiuTv8nZLwAF3Dn8GOwDFliJL8HyGnokbcMiHx+vMT9fXAi8EY?= =?us-ascii?Q?XrHh3/3k1D7yQ7VaN7CTE8LjzSp+Z0mwrMYXc5Kcvvo9ALIQhz28GFHzTEqi?= =?us-ascii?Q?8d48/5qxdJ2E+Hr9+Cl4WnLjvhej3eDpb0PjW9THi+A1lmUa5G5TsOrPd2Ku?= =?us-ascii?Q?UddUxI+IB3Ipfe+hqBxVlIs2QRz9nxOcTsLrl8k/McwoTiWSNdZum3HTMO+U?= =?us-ascii?Q?s3HI1IrVEDuD0CSvVXHbjmx+fqkNb2BQgKGP74VaADje0X+kkwoI6Y36EI3R?= =?us-ascii?Q?hijEcvugAMmx8bKvlaCwMZ+1bwoBhl+Q4tNDGhMZwqPa2/aUZIIe2+DAOqc1?= =?us-ascii?Q?/akqWQIL2FLNiE17/wGs8y1Z/jhQp/neluZUBwfS6Lo6FJnoa5Jrl4n+ndcx?= =?us-ascii?Q?8s0IyNguaBIQJIf8FX0tbCYR1ZbhUx1/Gl+k8tz5zvmkzmfklCn3NXJXXuxX?= =?us-ascii?Q?lgUQXWBcCdkttyFPKbukDkLcIAmLX/HAO4nk9GYNgjWFIE5EOBkamNJA06Ua?= =?us-ascii?Q?mRvCchcMgDBbG3YOvQ76Qi7x?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <43A015BAAFD184468D524DC397503D62@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1661 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 35acc52f-56d0-4a4b-7ceb-08d8e88a5284 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DryO+ggW8Txtq0YF+g65N1Pdls4VYwkxh0RB6tGD/PJD9OHVmY3c0HPFG2mO8SYtf7nD3ZCko+KHw0h1T4zx3W2kznbo4YNecsgORxvEbjNAgz9eGED0cN0NssnDOG4ZYQAcw0Hh6jibKa0p6PlyFtra8e9XeLBYinWPZo20EPHhde+nFybskBdEf9RM8r3jwSWnv85sv7DpkO6ebKO3d1Kt6K1VZ48cuoVB97LX+qtOX/REISdrgkJM5N+ipiGSoZr4xDsVyPPU5fFnHT/sav4uZDBdCXAnZXWiGHpQsiDh3eDEyyVNZoitHKV86/9Jx0+zmwHy9+eVhWE642iFmnE0s4RH7twg8XA+uSvEjvDdP5IYqT36ARX/nyLwjo3QLU3R79Cb7/W1M1CCeZEbkacQAZG+iioh3q5IyHTsGYQ8TWmFsExGqKLJP0tiFXnug+0NdIrB39Wk2WbEK/Hnk41RfmTGHZlHzBVFnts8Oz8tsottFqJIqSCzgdchLmDS/BoeKDx/pMLiWIOasvVgePKxZrGngEtAsnNooXpa1j8NU+p979Met6NR0DicpnFSn7oUJtW19qq8XhhDXkMXgWuv2/JHRjxNrByUy9VsE7NeZg9vJWEHpVU7Gs/s15DXQftw4Rw0UZjIKYbbukS72A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(39850400004)(396003)(136003)(346002)(36840700001)(46966006)(6862004)(336012)(4326008)(26005)(2616005)(70586007)(186003)(36756003)(107886003)(47076005)(356005)(81166007)(82310400003)(82740400003)(8936002)(36860700001)(70206006)(2906002)(55236004)(5660300002)(8676002)(86362001)(6506007)(53546011)(54906003)(33656002)(478600001)(6486002)(316002)(6512007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 14:46:58.1744 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0e2170b5-0b05-4614-5a0b-08d8e88a59d2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2122 Hi Julien, > On 16 Mar 2021, at 14:42, Julien Grall wrote: >=20 >=20 >=20 > On 16/03/2021 14:40, Julien Grall wrote: >> Hi Bertrand, >> On 15/03/2021 10:38, Bertrand Marquis wrote: >>> All cpu identification registers that we store in the cpuinfo structure >>> are 64bit on arm64 and 32bit on arm32 so storing the values in 32bit on >>> arm64 is removing the higher bits which might contain information in th= e >>> future. >>>=20 >>> This patch is changing the types in cpuinfo to register_t (which is >>> 32bit on arm32 and 64bit on arm64) and adding the necessary paddings >>> inside the unions. >>> For consistency uint64_t entries are also changed to register_t on 64bi= t >>> systems. >>>=20 >>> It is also fixing all prints using directly the bits values from cpuinf= o >>> to use PRIregister and adapt the printed value to print all bits >>> available on the architecture. >>>=20 >>> Signed-off-by: Bertrand Marquis >> Acked-by: Julien Grall >=20 > I have committed it to my for-next/4.16 branch. Thanks Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 16 14:54:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 14:54:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98337.186482 (Exim 4.92) (envelope-from ) id 1lMB5n-0002aM-2c; Tue, 16 Mar 2021 14:54:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98337.186482; Tue, 16 Mar 2021 14:54:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMB5m-0002aF-US; Tue, 16 Mar 2021 14:54:42 +0000 Received: by outflank-mailman (input) for mailman id 98337; Tue, 16 Mar 2021 14:54:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMB5l-0002aA-IK for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 14:54:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMB5h-00056d-LR; Tue, 16 Mar 2021 14:54:37 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMB5h-00032Q-9v; Tue, 16 Mar 2021 14:54:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=n2kOiMwSHxMqR8hZj9YfYLH98BsKpldd6abPrGzqNP8=; b=hiwdSbtyhWzngaxtwkieHRzdA7 Cy9jmabMZ/JRKp8AHEDxjTtgbZhokM1KrB2Fv+lkqN9+LnLsV18rs1JFUrttlBzJVG0ELY5f/5OF/ BzSG+bPQoIOxcN4uyKaBHLPg5m9Ek/Zo0enAv59eJCvuqR3aR9JKpFa/KAg1TLd1N31c=; Subject: Re: [PATCH v7] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com References: <20210315092342.26533-1-michal.orzel@arm.com> From: Julien Grall Message-ID: <3473f8d3-c42a-9182-b4fa-c3eacb44338f@xen.org> Date: Tue, 16 Mar 2021 14:54:33 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210315092342.26533-1-michal.orzel@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Michal, On 15/03/2021 09:23, Michal Orzel wrote: > Currently in order to link existing DTB into Xen image > we need to either specify option CONFIG_DTB_FILE on the > command line or manually add it into .config. > Add Kconfig entry: CONFIG_DTB_FILE > to be able to provide the path to DTB we want to embed > into Xen image. If no path provided - the dtb will not > be embedded. > > Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" > as it is not needed since Kconfig will define it in a header > with all the other config options. > > Make a change in the linker script from: > _sdtb = .; > to: > PROVIDE(_sdtb = .); > to avoid creation of _sdtb if there is no reference to it. This means that if someone is using #ifdef CONFIG_DTB_FILE rather than .ifnes, _sdtb will get defined. The difference between two is quite subttle and can be easily missed during review. How about defining _sdtb in dtb.S? With that approach, we would get a compiler error if someone protect _sdtb with #ifdef rather than .ifnes. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 16 14:58:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 14:58:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98343.186494 (Exim 4.92) (envelope-from ) id 1lMB9a-0002nc-Il; Tue, 16 Mar 2021 14:58:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98343.186494; Tue, 16 Mar 2021 14:58:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMB9a-0002nV-Fd; Tue, 16 Mar 2021 14:58:38 +0000 Received: by outflank-mailman (input) for mailman id 98343; Tue, 16 Mar 2021 14:58:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMB9Z-0002nQ-Iq for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 14:58:37 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4243338d-15c7-489a-a9f0-2c7046827b2a; Tue, 16 Mar 2021 14:58:36 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1472DAED2; Tue, 16 Mar 2021 14:58:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4243338d-15c7-489a-a9f0-2c7046827b2a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615906715; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eca4pwWETZTFwlJnPTfMcgVq8pRE72m9y4FUN9C7HKY=; b=t2Bv+mp+Inr8UwoV4TnESbeVs29g/NEtoKKWASXlCJ2aHVNK5FZmCeG6nTQm0kPpZQ7Hvm wR4NLyAkAndWjtAIRbvA1TdoTBpVLSWKhGlhjwFgdeGR2/Z1Obpb//jivExpoqsx1ec/kE hTqHcwMYlEoFJ3FZqW6jYU9R5AGzMf8= Subject: Re: [PATCH for-4.15] SUPPORT.MD: Mark C XenStored LiveUpdate as Tech Preview To: Julien Grall , Andrew Cooper , xen-devel@lists.xenproject.org Cc: Julien Grall , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu References: <20210313135500.27241-1-julien@xen.org> <43d6d118-308d-6bb0-3b91-7dc0f8a38d56@citrix.com> <663f08cf-a7cb-2e53-fe22-69d232e6aa07@xen.org> <03787b98-9acd-f1a8-66d4-953d7c99ee0d@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Tue, 16 Mar 2021 15:58:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uV2XMkcbMzcE14axfDQS7P5hAOLzJbfBF" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uV2XMkcbMzcE14axfDQS7P5hAOLzJbfBF Content-Type: multipart/mixed; boundary="3ihHxHyIpK7p0yGB8NQSnVYmmZysdKgXt"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , Andrew Cooper , xen-devel@lists.xenproject.org Cc: Julien Grall , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Message-ID: Subject: Re: [PATCH for-4.15] SUPPORT.MD: Mark C XenStored LiveUpdate as Tech Preview References: <20210313135500.27241-1-julien@xen.org> <43d6d118-308d-6bb0-3b91-7dc0f8a38d56@citrix.com> <663f08cf-a7cb-2e53-fe22-69d232e6aa07@xen.org> <03787b98-9acd-f1a8-66d4-953d7c99ee0d@suse.com> In-Reply-To: --3ihHxHyIpK7p0yGB8NQSnVYmmZysdKgXt Content-Type: multipart/mixed; boundary="------------5A8EC9A87308BC7B002E1C19" Content-Language: en-US This is a multi-part message in MIME format. --------------5A8EC9A87308BC7B002E1C19 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 16.03.21 15:39, Julien Grall wrote: >=20 >=20 > On 16/03/2021 14:36, J=C3=BCrgen Gro=C3=9F wrote: >> On 16.03.21 15:35, Julien Grall wrote: >>> Hi, >>> >>> On 15/03/2021 12:17, Andrew Cooper wrote: >>>> On 13/03/2021 13:55, Julien Grall wrote: >>>>> From: Julien Grall >>>>> >>>>> Support to liveupdate C XenStored was adding during the 4.15 >>>>> development cycle. Add a section in SUPPORT.MD to explain what is t= he >>>>> support state. >>>>> >>>>> For now, it is a tech preview. >>>>> >>>>> Signed-off-by: Julien Grall >>>>> >>>>> --- >>>>> >>>>> CC: Juergen Gross >>>>> >>>>> It looks like the OCaml side was not merged in 4.15. >>>> >>>> Yes it was. >>>> >>>>> So I have only >>>>> described the support state for C XenStored. >>>> >>>> What about stub-cxenstored?=C2=A0 I think it wants pointing out=20 >>>> specifically, >>>> whatever its status, to avoid confusion. >>> >>> Is it even working? @Juergen? >> >> LU of xenstore-stubdom isn't working yet. >=20 > Ok. Would renaming the section to "Dom0 C Xen-Stored LiveUpdate" would = > be suitable? "Xen-Stored" in rather unusual. What about "LiveUpdate of C Xenstore daemon"? Juergen --------------5A8EC9A87308BC7B002E1C19 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------5A8EC9A87308BC7B002E1C19-- --3ihHxHyIpK7p0yGB8NQSnVYmmZysdKgXt-- --uV2XMkcbMzcE14axfDQS7P5hAOLzJbfBF Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBQx5gFAwAAAAAACgkQsN6d1ii/Ey92 wQf/Y/8UPgbINJpExKlxi2gbMpbkhSyW0C4ktXUnb3WPD1smzpueMYUx6/QBxVaMTzH+jqL1a4jP CYlGb6NKQLhOyGkoBaT2hC/foWs8pAuuJB9T8S3Ow8K1PKzWdwfBkwY5i8eUrg6KKCTcGmV3VSWD 6+ojIXcZ8CXxDvuwHnkKx4/2PQLLm6YUnyShsmBDiyDidmNAgtdQMEMrx80MqQCUZiIe63/Ntcbe ZPh0peZPeXln6TNDTaZm+HaFlWAtTiSP43T1ipooyr2k7o2cb7aSym2m1nSUku1z/RSBtqI+tu7k rMNq5w5D2R0q2JuNc33vIkQ0ZJCWhwwYDAXwAFpelg== =XKGb -----END PGP SIGNATURE----- --uV2XMkcbMzcE14axfDQS7P5hAOLzJbfBF-- From xen-devel-bounces@lists.xenproject.org Tue Mar 16 15:04:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 15:04:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98346.186506 (Exim 4.92) (envelope-from ) id 1lMBEm-0003gp-8A; Tue, 16 Mar 2021 15:04:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98346.186506; Tue, 16 Mar 2021 15:04:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBEm-0003gi-3y; Tue, 16 Mar 2021 15:04:00 +0000 Received: by outflank-mailman (input) for mailman id 98346; Tue, 16 Mar 2021 15:03:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBEl-0003gd-8g for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 15:03:59 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bc1658b2-effb-4266-887f-c14327b862d4; Tue, 16 Mar 2021 15:03:58 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 59B3BAD72; Tue, 16 Mar 2021 15:03:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc1658b2-effb-4266-887f-c14327b862d4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615907037; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k1nZcjDpdu+poBSXNwFWYDFI7JDSS46d5Da0XbaYFxc=; b=M7cXjsAiU8cZnHqgJ0BfphEErgJextR3gRyDLOt0nJj9BIPFxTxpnZ9jTy2OwPojdrxzls UkzPNnqR+PPBICNwoqLIhQPOtzx/KGfOXAQkoSrMnp9oEZyU90xu/uS+sHRZQR4BWwevCW 5En3bZbFVH+ybF5OKgW34RPqvTPAs6k= Subject: Re: libxl / xen-pciback interaction To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Wei Liu , Anthony Perard , Boris Ostrovsky References: From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Tue, 16 Mar 2021 16:03:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lozyrYSf1icFEANjtLBBeq2rxAmJsZBAB" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lozyrYSf1icFEANjtLBBeq2rxAmJsZBAB Content-Type: multipart/mixed; boundary="nGkb9WbA7obsvSYnVumQTs2Z1dhuV1YZE"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Ian Jackson , Wei Liu , Anthony Perard , Boris Ostrovsky Message-ID: Subject: Re: libxl / xen-pciback interaction References: In-Reply-To: --nGkb9WbA7obsvSYnVumQTs2Z1dhuV1YZE Content-Type: multipart/mixed; boundary="------------85D18B880C0D7F3894E3D66D" Content-Language: en-US This is a multi-part message in MIME format. --------------85D18B880C0D7F3894E3D66D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 16.03.21 15:27, Jan Beulich wrote: > All, >=20 > while trying to test a pciback fix for how SR-IOV VFs get placed in the= > guest PCI topology I noticed that my test VM would only ever see the 1s= t > out of 3 VFs that I passed to it. As it turns out, the driver watches > its own (backend) node, and upon first receiving notification it > evaluates state found in xenstore to set up the backend device. > Subsequently it switches the device to Initialised. After this switchin= g, > not further instances of the watch triggering would do anything. >=20 > In all instances I observed the watch event getting processed when the > "num_devs" node still reported 1. Trying to deal with this in libxl, by= > delaying the writing of the "num_devs" node, led to a fatal error > ("num_devs" not being available to read) in the driver, causing the > device to move to Closing state. Therefore I decided that the issue has= > to be addressed in the driver, resulting in a patch (reproduced below) > that I'm not overly happy with. I think the present libxl behavior is > wrong - it shouldn't trigger driver initialization without having fully= > populated the information the driver is supposed to consume for its > device initialization. The only solution that I can think of, however, > doesn't look very appealing either: Instead of putting all pieces of th= e > data for one device in a transaction, make a single transaction cover > all devices collectively. Any reason why you don't like this solution? Its not as if there would be a large problem to be expected with using a single transaction for all PCI devices passed through (assuming you didn't mean to pack really all devices of the guest into that single transaction). Juergen --------------85D18B880C0D7F3894E3D66D Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------85D18B880C0D7F3894E3D66D-- --nGkb9WbA7obsvSYnVumQTs2Z1dhuV1YZE-- --lozyrYSf1icFEANjtLBBeq2rxAmJsZBAB Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBQyNwFAwAAAAAACgkQsN6d1ii/Ey9j lwf9FOfwDDSrWEeFXcCzkwxjS4mxgywS/+aACxZsVkfuOXKEoz075zgcZ9eLe5naRZ91Fl2koLzl LcBeh93citjrXj6tFTkS6q2CmNWM7Q12AFTIB2tHhtbUU5ikjEHSOGeD4Alz3J9K5Yiaa3+EwH+P t1NIlaTuQDsnyfqwYcFBqRweKCjEzvrF3x4Wrdx+rBYBTVUHa0HkHmT7IbTvs1zOAmI9InxHuIcj KBozpw8ELO/3j+hxs9V1dAJxgvOt2ilKdaQvmN9BvpQwa3+pHouZ8YtbNEg8T2n9/UC9JkPYp9q9 YaF4CZ9dtm62IULMISZOMGJmfx+JJ3E8C+SiqUaV5A== =9yzP -----END PGP SIGNATURE----- --lozyrYSf1icFEANjtLBBeq2rxAmJsZBAB-- From xen-devel-bounces@lists.xenproject.org Tue Mar 16 15:04:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 15:04:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98347.186517 (Exim 4.92) (envelope-from ) id 1lMBFB-0003lG-Fb; Tue, 16 Mar 2021 15:04:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98347.186517; Tue, 16 Mar 2021 15:04:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBFB-0003l9-Ce; Tue, 16 Mar 2021 15:04:25 +0000 Received: by outflank-mailman (input) for mailman id 98347; Tue, 16 Mar 2021 15:04:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBFA-0003l2-D6 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 15:04:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBF9-0005JL-8V; Tue, 16 Mar 2021 15:04:23 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMBF8-00040e-TW; Tue, 16 Mar 2021 15:04:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=CKLsUcxn0nSs2TWPzS8VFxiIR3DQGkyvO4SLheuwtA4=; b=UxK+I724f4EWWRe0jgFIQyJMNH /1fND+eKcYOyWZp8tFHsunRNf+GVe5j08Hrsm5RH3f2GCImKDghWP8oog32X7EXI5IpR9mpzZx0M3 cEOfiohSvI4KPDDlRNJnynIf7SxTxVABvlWTJ/Mu3Ksta2ShsXzin/cDi10u7nHPgmXg=; Subject: Re: [PATCH 0/5] xen/arm: smmuv1: Fix stream match conflict issue To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk References: From: Julien Grall Message-ID: <7b521058-7e83-2651-aa1b-02098e9bbc19@xen.org> Date: Tue, 16 Mar 2021 15:04:21 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Rahul, On 09/03/2021 18:19, Rahul Singh wrote: > This patch is the work to fix the stream match conflict issue when two devices > have the same stream-id. > > Approach taken is to merge the below commit from Linux driver to fix the > issue. > > 1. "iommu/arm-smmu: Handle stream IDs more dynamically" > commit 21174240e4f4439bb8ed6c116cdbdc03eba2126e > 2. "iommu/arm-smmu: Consolidate stream map entry state" > commit 1f3d5ca43019bff1105838712d55be087d93c0da > 3. "iommu/arm-smmu: Keep track of S2CR state" > commit 8e8b203eabd8b9e96d02d6339e4abce3e5a7ea4b > 4. "iommu/arm-smmu: Add a stream map entry iterator" > commit d3097e39302083d58922a3d1032d7d59a63d263d > 5. "iommu/arm-smmu: Intelligent SMR allocation" > commit 588888a7399db352d2b1a41c9d5b3bf0fd482390 A couple of questions: * Are they backported verbatim from Linux upstream? * Did you check there was no bug fix afterwards? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 16 15:08:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 15:08:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98352.186529 (Exim 4.92) (envelope-from ) id 1lMBJC-00040Q-1i; Tue, 16 Mar 2021 15:08:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98352.186529; Tue, 16 Mar 2021 15:08:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBJB-00040J-UV; Tue, 16 Mar 2021 15:08:33 +0000 Received: by outflank-mailman (input) for mailman id 98352; Tue, 16 Mar 2021 15:08:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBJA-00040E-62 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 15:08:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBJ9-0005Ou-72; Tue, 16 Mar 2021 15:08:31 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMBJ8-0004JU-WE; Tue, 16 Mar 2021 15:08:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=88hueI9QdPJDJU5HXKt+1gfDC37JXW57BZzi1Ln4yAY=; b=nmO86/cX0dzU1HQiAMU+2Y0P2p lT08dYjEsNQW8HDpRlktKxPQ10ZIlEtDc8bdSVj1jz/8U6hQ11BbxhIKnAd2+VOyam0e8EPBVxVlo AYJ5k5XgrBAVm1F26bqZenq1SJYSFUSe42dH55K+FKHfYC8zuP2rwOfXMWcPRLvrDd4E=; Subject: Re: [PATCH 5/5] xen/arm: smmuv1: Intelligent SMR allocation To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk References: <789abfb57568dcbaba122ea9b68c627e6c9707c4.1615312254.git.rahul.singh@arm.com> From: Julien Grall Message-ID: <299c8294-5f76-2fd6-85ec-d20c0b99368b@xen.org> Date: Tue, 16 Mar 2021 15:08:29 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <789abfb57568dcbaba122ea9b68c627e6c9707c4.1615312254.git.rahul.singh@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Rahul, On 09/03/2021 18:19, Rahul Singh wrote: > Backport 588888a7399db352d2b1a41c9d5b3bf0fd482390 > "iommu/arm-smmu: Intelligent SMR allocation" from the Linux kernel > > This patch fix the stream match conflict issue when two devices have the > same stream-id. > > Only difference while applying this patch is to use spinlock in place of > mutex and move iommu_group_alloc(..) function call in > arm_smmu_add_device(..) function from the start of the function > to the end. As you may remember the discussion on the SMMUv3 thread, replacing a spinlock by a mutex has consequences. Can you explain why this is fine? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 16 15:08:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 15:08:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98353.186542 (Exim 4.92) (envelope-from ) id 1lMBJZ-00045U-BR; Tue, 16 Mar 2021 15:08:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98353.186542; Tue, 16 Mar 2021 15:08:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBJZ-00045N-7x; Tue, 16 Mar 2021 15:08:57 +0000 Received: by outflank-mailman (input) for mailman id 98353; Tue, 16 Mar 2021 15:08:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBJX-00045E-Si for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 15:08:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f1ce2870-9f57-4a52-bf65-701ea9ae0e27; Tue, 16 Mar 2021 15:08:54 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CE638AC24; Tue, 16 Mar 2021 15:08:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1ce2870-9f57-4a52-bf65-701ea9ae0e27 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615907333; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D5Q0FZLg0YSHnXmpGl6RFh/nV7Mg0ceTrLYn9AYFV8o=; b=pCiS2eHLqG38v45KjElxdffKkZd8BOBAdjqvSBgPbUMN86yAna8lEBEu9orF75NV0Gp6Qt dpZwJyER3WkxxK2gjbrawsjlte9BZSvUjepxp1nHON4AXVem3CuHkCY59CdDFhfyGlKGfI oQ8oNFeDszXq8y8mI7ZjbJnoYizJ0To= Subject: Re: [PATCH v3 5/5] xen/x86/efi: Verify dom0 kernel with SHIM_LOCK protocol in efi_multiboot2() To: Bobby Eshleman Cc: Daniel Kiper , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xen-devel References: <44cb9567aa17d6255beadaa48defccd246b35669.1611273359.git.bobbyeshleman@gmail.com> From: Jan Beulich Message-ID: <0ba72288-6753-a049-7a9d-7fcdc124cd47@suse.com> Date: Tue, 16 Mar 2021 16:08:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <44cb9567aa17d6255beadaa48defccd246b35669.1611273359.git.bobbyeshleman@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 22.01.2021 01:51, Bobby Eshleman wrote: > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > @@ -244,9 +244,13 @@ __efi64_mb2_start: > jmp x86_32_switch > > .Lefi_multiboot2_proto: > - /* Zero EFI SystemTable and EFI ImageHandle addresses. */ > + /* > + * Zero EFI SystemTable, EFI ImageHandle and > + * dom0 kernel module struct addresses. > + */ > xor %esi,%esi > xor %edi,%edi > + xor %r14d, %r14d Nit: There's little point in having the d suffixes here and below, and the code would be slightly easier to read without. > /* Skip Multiboot2 information fixed part. */ > lea (MB2_fixed_sizeof+MULTIBOOT2_TAG_ALIGN-1)(%rbx),%ecx > @@ -284,6 +288,15 @@ __efi64_mb2_start: > cmove MB2_efi64_ih(%rcx),%rdi > je .Lefi_mb2_next_tag > > + /* Get Dom0 kernel module struct address from Multiboot2 information. */ > + cmpl $MULTIBOOT2_TAG_TYPE_MODULE,MB2_tag_type(%rcx) Not: If elsewhere in the code additions you put blanks after the comma (which I appreciate), please do so here as well. > + jne .Lefi_mb2_end > + > + test %r14d, %r14d > + cmovz %ecx, %r14d So this doesn't truncate the address because higher up %ecx was loaded instead of %rcx. I realize that's not code you add, but it still strikes me as odd. Are there indeed guarantees that all of this will live below 4Gb? > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -3,6 +3,8 @@ > * is intended to be included by common/efi/boot.c _only_, and > * therefore can define arch specific global variables. > */ > +#include > +#include > #include > #include > #include > @@ -762,6 +764,10 @@ void __init efi_multiboot2(EFI_HANDLE ImageHandle, Isn't there a hunk missing up from here to add the new parameter to efi_multiboot2()? > gop = efi_get_gop(); > > + if ( dom0_kernel && dom0_kernel->mod_end > dom0_kernel->mod_start ) > + efi_shim_lock((VOID *)(unsigned long)dom0_kernel->mod_start, > + dom0_kernel->mod_end - dom0_kernel->mod_start); While somewhat unrelated to the change itself - how come the fields are all u32 (and hence you need to cast to unsigned long first)? There having been requests to allow for about 1Gb initrd images, I find it quite reasonable to expect that modules may not all fit below 4Gb. > --- a/xen/arch/x86/efi/stub.c > +++ b/xen/arch/x86/efi/stub.c > @@ -1,7 +1,9 @@ > +#include Please don't, even less so without honoring the alphabetical sorting. > #include > #include > #include > #include > +#include > #include > #include > #include > @@ -29,7 +31,8 @@ asm ( > ); > > void __init noreturn efi_multiboot2(EFI_HANDLE ImageHandle, > - EFI_SYSTEM_TABLE *SystemTable) > + EFI_SYSTEM_TABLE *SystemTable, > + multiboot2_tag_module_t *dom0_kernel) const? > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -133,6 +133,7 @@ static void efi_console_set_mode(void); > static EFI_GRAPHICS_OUTPUT_PROTOCOL *efi_get_gop(void); > static UINTN efi_find_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, > UINTN cols, UINTN rows, UINTN depth); > +static void efi_shim_lock(const VOID *Buffer, UINT32 Size); > static void efi_tables(void); > static void setup_efi_pci(void); > static void efi_variables(void); > @@ -830,6 +831,17 @@ static UINTN __init efi_find_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, > return gop_mode; > } > > +static void __init efi_shim_lock(const VOID *Buffer, UINT32 Size) Maybe better efi_shim_lock_verify()? > +{ > + static EFI_GUID __initdata shim_lock_guid = SHIM_LOCK_PROTOCOL_GUID; > + EFI_SHIM_LOCK_PROTOCOL *shim_lock; > + EFI_STATUS status; > + > + if ( !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL, (void **)&shim_lock)) && Nit: Overly long line. > + (status = shim_lock->Verify(Buffer, Size)) != EFI_SUCCESS ) > + PrintErrMesg(L"Dom0 kernel image could not be verified", status); I'm willing to let it be as is, but in principle this function is not Dom0-specific the way you've split it out. _If_ you leave it this way, perhaps (on top of the suggestion above) perhaps better name it efi_shim_lock_verify_dom0()? Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 16 15:16:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 15:16:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98361.186554 (Exim 4.92) (envelope-from ) id 1lMBRE-00052E-C5; Tue, 16 Mar 2021 15:16:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98361.186554; Tue, 16 Mar 2021 15:16:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBRE-000527-8u; Tue, 16 Mar 2021 15:16:52 +0000 Received: by outflank-mailman (input) for mailman id 98361; Tue, 16 Mar 2021 15:16:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBRC-000522-Cw for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 15:16:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBRB-0005Xp-Bm; Tue, 16 Mar 2021 15:16:49 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMBRB-0004oa-15; Tue, 16 Mar 2021 15:16:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=AJCtys3Ycj9+nYGl0ckgjrzm8wyybxIJBMYSMKkBcyI=; b=ldsethmlSM0HcyQbj9dr8Bcwwr gM4OsmJ6D/pv7HLf0RMA2QNe7WvumLMSTdrCfcs6ARnl5a239tOQByaO0Wc5b9MYfij7LMFJAnGwT uTRI6okO5vOPu1ezy1OqqM80BtDm/WLgQbDBW8lbXRBFYid9Gty241jXr8Y1eDJ39tY8=; Subject: Re: [PATCH 1/5] xen/arm: smmuv1: Handle stream IDs more dynamically To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk References: <7775719c50c56b801e69d952e4ce255b8da1481c.1615312254.git.rahul.singh@arm.com> From: Julien Grall Message-ID: <0ff580cf-0e06-ae17-32c9-bf8dce26aead@xen.org> Date: Tue, 16 Mar 2021 15:16:47 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <7775719c50c56b801e69d952e4ce255b8da1481c.1615312254.git.rahul.singh@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Rahul, On 09/03/2021 18:19, Rahul Singh wrote: > Backport commit 21174240e4f4439bb8ed6c116cdbdc03eba2126e > "iommu/arm-smmu: Handle stream IDs more dynamically" from the Linux > ernel. > > This patch is the preparatory work to fix the stream match conflict > when two devices have the same stream-id. > > Original commit message: > > Rather than assuming fixed worst-case values for stream IDs and SMR > masks, keep track of whatever implemented bits the hardware actually > reports. This also obviates the slightly questionable validation of SMR > fields in isolation - rather than aborting the whole SMMU probe for a > hardware configuration which is still architecturally valid, we can > simply refuse masters later if they try to claim an unrepresentable ID > or mask (which almost certainly implies a DT error anyway). For single backported and verbatim commit, it is common to keep the origin tags (I usually indent them) to show who is the original author of the patch. Since 7936671da9fbf645d6bb207608f7b81c27f992de from Wei Chen as an example. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 16 15:20:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 15:20:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98364.186565 (Exim 4.92) (envelope-from ) id 1lMBUP-0005td-RN; Tue, 16 Mar 2021 15:20:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98364.186565; Tue, 16 Mar 2021 15:20:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBUP-0005tW-OU; Tue, 16 Mar 2021 15:20:09 +0000 Received: by outflank-mailman (input) for mailman id 98364; Tue, 16 Mar 2021 15:20:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBUN-0005tR-Q8 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 15:20:07 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1683cf10-62db-4629-860e-ff2d02998545; Tue, 16 Mar 2021 15:20:07 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2BF47AE8F; Tue, 16 Mar 2021 15:20:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1683cf10-62db-4629-860e-ff2d02998545 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615908006; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M+EFSiJBAgv4LuOsaKjj5FZHTCKXDtFob7XJSKYZB0M=; b=hA5EyEXHc4OdJLTNBkUVaoK5S9TSh4DPP4wngGXB01tJUIHh7WFayO/WBSwU+2eAZoi8Ag 48Z5tSt6tHv+e8WzTC7uP5JmUunwdcMh042FU+UW9mIJ+z153rVPTV2/0B8xYE3R69Y3q+ cAWbLEaeG91d4mogUEqHxtE3UKEhpVw= Subject: Re: libxl / xen-pciback interaction To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: Ian Jackson , Wei Liu , Anthony Perard , Boris Ostrovsky , "xen-devel@lists.xenproject.org" References: From: Jan Beulich Message-ID: <278e73d6-c3f4-b415-d98c-0e083d9414bd@suse.com> Date: Tue, 16 Mar 2021 16:20:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 16.03.2021 16:03, Jürgen Groß wrote: > On 16.03.21 15:27, Jan Beulich wrote: >> All, >> >> while trying to test a pciback fix for how SR-IOV VFs get placed in the >> guest PCI topology I noticed that my test VM would only ever see the 1st >> out of 3 VFs that I passed to it. As it turns out, the driver watches >> its own (backend) node, and upon first receiving notification it >> evaluates state found in xenstore to set up the backend device. >> Subsequently it switches the device to Initialised. After this switching, >> not further instances of the watch triggering would do anything. >> >> In all instances I observed the watch event getting processed when the >> "num_devs" node still reported 1. Trying to deal with this in libxl, by >> delaying the writing of the "num_devs" node, led to a fatal error >> ("num_devs" not being available to read) in the driver, causing the >> device to move to Closing state. Therefore I decided that the issue has >> to be addressed in the driver, resulting in a patch (reproduced below) >> that I'm not overly happy with. I think the present libxl behavior is >> wrong - it shouldn't trigger driver initialization without having fully >> populated the information the driver is supposed to consume for its >> device initialization. The only solution that I can think of, however, >> doesn't look very appealing either: Instead of putting all pieces of the >> data for one device in a transaction, make a single transaction cover >> all devices collectively. > > Any reason why you don't like this solution? It would be quite a bit of code churn afaict (i.e. not an undertaking I would like to start for code I'm not really familiar with), and error cleanup might also become quite ugly. > Its not as if there would > be a large problem to be expected with using a single transaction for > all PCI devices passed through (assuming you didn't mean to pack really > all devices of the guest into that single transaction). I meant all PCI devices; I can't even see a remote reason why all devices regardless of type would want packing in a single transaction. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 16 15:22:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 15:22:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98367.186578 (Exim 4.92) (envelope-from ) id 1lMBWl-00062W-A9; Tue, 16 Mar 2021 15:22:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98367.186578; Tue, 16 Mar 2021 15:22:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBWl-00062P-6U; Tue, 16 Mar 2021 15:22:35 +0000 Received: by outflank-mailman (input) for mailman id 98367; Tue, 16 Mar 2021 15:22:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBWk-00062K-Ot for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 15:22:34 +0000 Received: from smtp-fw-2101.amazon.com (unknown [72.21.196.25]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7eb9bcfe-b68c-4075-9c1e-b7ae4c5f17c2; Tue, 16 Mar 2021 15:22:33 +0000 (UTC) Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2c-456ef9c9.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP; 16 Mar 2021 15:22:25 +0000 Received: from EX13D12EUA002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2c-456ef9c9.us-west-2.amazon.com (Postfix) with ESMTPS id 0861EA7AF9; Tue, 16 Mar 2021 15:22:23 +0000 (UTC) Received: from 147dda3ee008.ant.amazon.com (10.43.165.192) by EX13D12EUA002.ant.amazon.com (10.43.165.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 16 Mar 2021 15:22:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 7eb9bcfe-b68c-4075-9c1e-b7ae4c5f17c2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1615908154; x=1647444154; h=to:cc:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding:subject; bh=q5kbSbegqpzzJVt427pixcj7nixefER90+FzIpRlpB8=; b=CnKppP079/z2Mt9hxlBR9CqwHY3XruWxwHY0AtgGduZV0PpRNij5zl/X gaPC5e5zWyPjOpIiQFhJDuR92t9nZ6zEe/iOAR5jkZoiIGxhPaPQN0hHV lFXpyQbec/pEtR4ZHHjFeBOr/ciz3vUXIDHxqf4Y2bMDOD2JK+mEFq0nm I=; X-IronPort-AV: E=Sophos;i="5.81,251,1610409600"; d="scan'208";a="94984210" Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring To: Leon Romanovsky , Andrew Lunn CC: , , , , , References: <20210311225944.24198-1-andyhsu@amazon.com> From: "Hsu, Chiahao" Message-ID: <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> Date: Tue, 16 Mar 2021 16:22:21 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.43.165.192] X-ClientProxiedBy: EX13D01EUA004.ant.amazon.com (10.43.165.123) To EX13D12EUA002.ant.amazon.com (10.43.165.103) Precedence: Bulk Leon Romanovsky 於 2021/3/14 11:04 寫道: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > On Fri, Mar 12, 2021 at 09:36:59PM +0100, Andrew Lunn wrote: >> On Fri, Mar 12, 2021 at 04:18:02PM +0100, Hsu, Chiahao wrote: >>> Andrew Lunn 於 2021/3/12 15:52 寫道: >>>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. >>>> >>>> >>>> >>>> On Thu, Mar 11, 2021 at 10:59:44PM +0000, ChiaHao Hsu wrote: >>>>> In order to support live migration of guests between kernels >>>>> that do and do not support 'feature-ctrl-ring', we add a >>>>> module parameter that allows the feature to be disabled >>>>> at run time, instead of using hardcode value. >>>>> The default value is enable. >>>> Hi ChiaHao >>>> >>>> There is a general dislike for module parameters. What other mechanisms >>>> have you looked at? Would an ethtool private flag work? >>>> >>>> Andrew >>> >>> Hi Andrew, >>> >>> I can survey other mechanisms, however before I start doing that, >>> >>> could you share more details about what the problem is with using module >>> parameters? thanks. >> It is not very user friendly. No two kernel modules use the same >> module parameters. Often you see the same name, but different >> meaning. There is poor documentation, you often need to read the >> kernel sources it figure out what it does, etc. > +1, It is also global parameter to whole system/devices that use this > module, which is rarely what users want. > > Thanks Hi, I think I would say the current implementation(modparams) isappropriate after reviewing it again. We are talking about 'feature leveling', a way to support live migrationof guest between kernels that do and do not support the features. So we want to refrain fromadding the features if guest would be migrated to the kernel which does not support the feature. Everythingshould be done (in probe function) before frontend connects, and this is why ethtool is not appropriate for this. Thanks From xen-devel-bounces@lists.xenproject.org Tue Mar 16 15:27:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 15:27:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98370.186590 (Exim 4.92) (envelope-from ) id 1lMBbX-0006DY-Tf; Tue, 16 Mar 2021 15:27:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98370.186590; Tue, 16 Mar 2021 15:27:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBbX-0006DR-QO; Tue, 16 Mar 2021 15:27:31 +0000 Received: by outflank-mailman (input) for mailman id 98370; Tue, 16 Mar 2021 15:27:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBbW-0006DM-KT for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 15:27:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMBbV-0005ix-0Y; Tue, 16 Mar 2021 15:27:29 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMBbU-0005MR-N4; Tue, 16 Mar 2021 15:27:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=2f+DffYtfP586Gt7KcILZOW7qRBjCxkX8gbjH0PBWPc=; b=TUhonIeLYssYje98Bq9pMC6+90 Bef5IY/HAAZVc/fISttsRP5h9HcfiR+8Ik2fv4VwaG2NBXLdfFSvIFiSmA9EOGMxbcvlQjoJKw0GM ugBewRJvKnQX9cFmPGPEd8XAiBl8fC7wetkzD30araa9Tdd1Xa0Q9r9JayzrtIn0xjlM=; Subject: Re: [PATCH for-next v2 0/2] xen/arm: Mitigate straight-line speculation To: Bertrand Marquis Cc: Xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk References: <20210313160611.18665-1-julien@xen.org> From: Julien Grall Message-ID: <119bdbc0-5400-87eb-e6ad-87b59ec4e07c@xen.org> Date: Tue, 16 Mar 2021 15:27:27 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 15/03/2021 13:32, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, > >> On 13 Mar 2021, at 16:06, Julien Grall wrote: >> >> From: Julien Grall >> >> Hi all, >> >> Last year, Arm released a whitepaper about a new category of speculation. >> (see [1] and [2]). In short, a processor may be able to speculate past >> some of the unconditional control flow instructions (e.g eret, smc, br). >> >> In some of the cases, the registers will contain values controlled by >> the guest. While there is no known gadget afterwards, we still want to >> prevent any leakage in the future. >> >> The mitigation is planned in two parts: >> 1) Arm provided patches for both GCC and LLVM to add speculation barrier >> and remove problematic code sequence. >> 2) Inspection of assembly code and call to higher level (e.g smc in our case). >> >> I still haven't looked at 1) and how to mitigate properly Arm32 (see >> patch #1) and SMC call. So this issue is not fully addressed. >> >> Note that the ERET instruction was already addressed as part of XSA-312. > > On my tests, this serie is breaking the arm64 build: > | aarch64-poky-linux-ld --sysroot=/home/bermar01/Development/xen-dev/build/profile-fvp-base.prj/tmp/work/fvp_base-poky-linux/xen/4.15+git1-r0/recipe-sysroot -EL --fix-cortex-a53-843419 --fix-cortex-a53-843419 -r -o built_in.o memcpy.o memcmp.o memmove.o memset.o memchr.o clear_page.o bitops.o find_next_bit.o strchr.o strcmp.o strlen.o strncmp.o strnlen.o strrchr.o I can't see any build failure with the following GCC: 42sh> aarch64-linux-gnu-gcc aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) 7.5.0 Copyright (C) 2017 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. AFAICT, there is also no compilation issue reported by gitlab: https://gitlab.com/xen-project/patchew/xen/-/pipelines/269989894 What's the version of your compiler? Do you have steps to reproduce your setup? > | arm64/head.S: Assembler messages: > | arm64/head.S:305: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, "- Boot CPU booting -\r\n")' This is strange, the code should use RODATA_STR() but here it is in lower case. Can you check in your tree whether there some instance of the lower case version? If not, this may just be GAS printing in lower cases. > | arm64/head.S:331: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, "- Ready -\r\n")' > | arm64/head.S:365: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, "- CPU ")' > | make[6]: Leaving directory '/home/bermar01/Development/xen-dev/build/profile-fvp-base.prj/tmp/work/fvp_base-poky-linux/xen/4.15+git1-r0/local-xen/xen/xen/arch/arm/arm64/lib' > | arm64/head.S:367: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, " booting -\r\n")' > | arm64/head.S:398: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, "- Ready -\r\n")' > | arm64/head.S:412: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, "- Current EL ")' > | arm64/head.S:415: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, " -\r\n")' > | arm64/head.S:424: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, "- Xen must be entered in NS EL2 mode -\r\n")' > | arm64/head.S:425: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, "- Please update the bootloader -\r\n")' > | arm64/head.S:441: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, "- Zero BSS -\r\n")' > | arm64/head.S:459: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, "- Initialize CPU -\r\n")' > | arm64/head.S:654: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, "- Unable to build boot page tables - virt and phys addresses clash. -\r\n")' > | arm64/head.S:666: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, "- Turning on paging -\r\n")' > | arm64/head.S:800: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, "- Boot failed -\r\n")' > | arm64/head.S:848: Error: unknown mnemonic `rodata_str' -- `rodata_str(98, "- UART enabled -\r\n")' > | {standard input}: Error: local label `"98" (instance number 1 of a fb label)' is not defined > | /home/bermar01/Development/xen-dev/build/profile-fvp-base.prj/tmp/work/fvp_base-poky-linux/xen/4.15+git1-r0/local-xen/xen/xen/Rules.mk:204: recipe for target 'arm64/head.o' failed > > This was done adding your 2 patches on top of current staging. > > Cheers > Bertrand > >> >> Cheers, >> >> [1] https://developer.arm.com/support/arm-security-updates/speculative-processor-vulnerability >> [2] https://developer.arm.com/support/arm-security-updates/speculative-processor-vulnerability/downloads/straight-line-speculation >> >> Julien Grall (2): >> xen/arm: Include asm/asm-offsets.h and asm/macros.h on every assembly >> files >> xen/arm64: Place a speculation barrier following an ret instruction >> >> xen/arch/arm/Makefile | 2 +- >> xen/arch/arm/arm32/entry.S | 2 +- >> xen/arch/arm/arm32/head.S | 1 - >> xen/arch/arm/arm32/lib/lib1funcs.S | 1 + >> xen/arch/arm/arm32/proc-v7.S | 1 - >> xen/arch/arm/arm64/debug-cadence.inc | 1 - >> xen/arch/arm/arm64/debug-pl011.inc | 2 -- >> xen/arch/arm/arm64/entry.S | 2 -- >> xen/arch/arm/arm64/head.S | 2 -- >> xen/arch/arm/arm64/smc.S | 3 --- >> xen/include/asm-arm/arm64/macros.h | 6 ++++++ >> xen/include/asm-arm/config.h | 6 ++++++ >> xen/include/asm-arm/macros.h | 18 +++++++++--------- >> 13 files changed, 24 insertions(+), 23 deletions(-) >> >> -- >> 2.17.1 >> > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 16 16:19:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 16:19:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98384.186626 (Exim 4.92) (envelope-from ) id 1lMCPd-0002pd-Iw; Tue, 16 Mar 2021 16:19:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98384.186626; Tue, 16 Mar 2021 16:19:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMCPd-0002pR-Eo; Tue, 16 Mar 2021 16:19:17 +0000 Received: by outflank-mailman (input) for mailman id 98384; Tue, 16 Mar 2021 16:19:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMCPc-0002kv-S1 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 16:19:16 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9863bba2-0946-4b55-9ef0-6c206ee58d6e; Tue, 16 Mar 2021 16:19:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9863bba2-0946-4b55-9ef0-6c206ee58d6e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615911553; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=qDVzQrkqOORjK1tpTv/h9844QV+q3KXmjnsN49ior48=; b=PvHkHYGRvijSWYUvobdTJSv5H2IAJWA7O8yyJ337TIUjhKBs+5LwrSSj 37CC6rJji6KQ8iAIlBVbgpCh7D9zuewC0+bZeGzLBryfHTD+adfDAeoTl 951Yelsbyb8O/Cm5sshYDbNkqgx5PymFVM6qw4CPhN5ODiK99K9JIrCZA I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: P3HDpFx97VuZkhun39VBuWLw8ueXFh3aqbIIpafB+iRN7D4Z2dbRuNZm6M/yDqzNduKmCFKYKS 0zSCLPtGNlFqaPkLl5IFE3wFshwhLS91k224IT8L/0LhCkPTO4682Pe3ctGYa3fWyG9J+daJg+ NFazLYr5Z7e5WplqV9557kTJpQZV8RZQHjUAY2hiPuAv5CBsBqCfaoV44QBxx/XVIzNkyV3P8U mZNufYDbeGbxhJrxLg6nEj7qFikycVm7j/SZsVfeu9JhTOZiPzHNs+If6j2g5LuG3uckMelSNt 7N8= X-SBRS: 5.1 X-MesageID: 39309516 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:8lR+Pqg5dmupob9vJkJu5o3vynBQXj4ji2hD6mlwRA09T+Wzva mV8sgz/xnylToXRTUcgtiGIqaNWjfx8pRy7IkXM96ZLW7bkUGvK5xv6pan/i34F0TFh4pg/I ppbqQWMr3NJHdgi8KS2mWFOvIB5PXCz6yyn+fZyB5WPGRXQoVt9R1wBAreMmAefngkObMDGJ CR5tVKqlObEBx9BKmGL0IIQvTZoJnznI/mCCR2YSIP0hWEjj+j9dfBciSw4xF2aVxy6IZn1W DElgDjj5/T0c2G9g== X-IronPort-AV: E=Sophos;i="5.81,251,1610427600"; d="scan'208";a="39309516" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Boris Ostrovsky , Ian Jackson Subject: [PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351 Date: Tue, 16 Mar 2021 16:18:41 +0000 Message-ID: <20210316161844.1658-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This is slightly complicated. Patches 1 and 2 rearrange the code to look and behave more like 4.14, and patch 3 fixes a Solaris (and turbostat) bug in a manner which can be backported to all security trees. Andrew Cooper (3): Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" x86/msr: Forward port XSA-351 changes from 4.14 x86/msr: Fix Solaris and turbostat following XSA-351 xen/arch/x86/msr.c | 78 +++++++++++++++++++++++++++++++++++++++++ xen/include/asm-x86/msr-index.h | 39 +++++++++++++++++++++ 2 files changed, 117 insertions(+) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Mar 16 16:19:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 16:19:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98383.186614 (Exim 4.92) (envelope-from ) id 1lMCPZ-0002mn-As; Tue, 16 Mar 2021 16:19:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98383.186614; Tue, 16 Mar 2021 16:19:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMCPZ-0002mf-5w; Tue, 16 Mar 2021 16:19:13 +0000 Received: by outflank-mailman (input) for mailman id 98383; Tue, 16 Mar 2021 16:19:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMCPX-0002kv-Rr for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 16:19:11 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7caab44e-cc54-404a-acd4-d8a0b92f7b51; Tue, 16 Mar 2021 16:19:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7caab44e-cc54-404a-acd4-d8a0b92f7b51 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615911547; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rf/HGM31QWHWGX+1+ToUsMdeOvi8pCwabBY2/qPrlZY=; b=ULucW+b2UFs5Cgm97eEvPEVkAJHOhn5OAJWdHEmx1RGezMBoZOUjhFgt sz4x7ruozuvmq+khkV574ZVQw3UVQlvMf7rCQX6WPTpE0NLJ3AB5Wby3R zb69rXoENhnt+GdrYd0trT9R+qkQhjjXtbhYe9wG1dcJWz78rwStPfxo7 A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 3iUKy1CtPOjR9xr4a/YNZQvVPT3nhPYif2nwlxPGZFMEyj9P5yMHvLTvGag8cK8Ak2Zp3uC4JQ YOaKh5NqUv7oMhDAeAo/cv3kv/NvK3LJ0rK7hpw1dmds+EffaE1Xrd6IXkctN+Bjn+zeOW3lTv 6qDkGnDWyjfA1EmnFRef+WF/g4SvVtOMY/nqRu1B6LaR3rkZRQlR7dKPJY1steXu3uL6cwOmfl MAEEly3DvbolK6O4gJN2xYZ9P1IAisoCntP0LCuvQ77IJECjwRkN/dn0gbdm/aWK5ImaOQMAZE mgg= X-SBRS: 5.1 X-MesageID: 39773267 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:EtnUN6+GQ0i5cDfOtcpuk+FtcL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEm8ybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIUPD38Zn/+ Nbf6B6YeeeMXFTh8z3+RT9Nt4mzsWO/qzAv5ag815GZ2hRGsZdxi1+DRuWFVAzYQFAC4YwGp b03Ls4mxOLf3MLYsOnQkQURuSrnayLqLvKQz4jQyQm5g6HkC+y5NfBcySw8x8CX1p0sMwf2E fflQiR3NTHj9iazVvm23bX/9BqnrLau6d+LeitruRQFTn2kAavY+1aKv2/lRQ4uvum5lpvsP SkmWZbA+1J53ncfn64rHLWsmGKultDmhySq2Owunftrdf0Qzg3EaN69P9kWyHE4EkttswU6t Ms40ultoFaBR6FvCPx68mgbWATqmOIoGEvmeNWsnpHUYF2Us4pkaUj+ipuYfM9NRO/zLpiPP hlDcna6voTW0iddWrlsm5mx8HpdmgvHz+dK3Jy+fC94nxzpjRU3kEYzMsQkjMr75QmUaRJ4O zCL+BBiKxOdMkLdqhwbd1xA/efOyjoe1bhIWiSKVPoGOUsIHTWsaP6570z+aWMdIEXyoAx3L DMSklRu2J3W0+GM7zK4LR7tjT2BEmtVzXkzc9To7JjvKfnebbtOSqfDF80lc+tpOgeH93bV/ 6/NIk+OY6lEULeXaJymyHuUZhbLncTFOcPvMwgZl6IqsXXbo3m39arNsr7Ff7IK3IJS2n/Cn wMUHzYP8Nb9H2mXXf+nVzUU3PpcUrv4IJoHMHhjrEu4blIErcJnhkeiFy/6M3OAyZFqLYKcE x3J66ilLi6q2mw9WPB9H5oJRJZE0ZQ7NzbIjd3jD5PF3mxXacIut2Zd2wX9mCAPAVDQ8TfFx Mau0564rutL5ubxTkrDtWuNm7ytQpKmFu6C7Mn3oGT78bsfZ01Sqs8UKtqDAPRClheggBxsl pObwcCW27SHj7jkr+ekZQRHe3THuMM2zuDEIpxkzb/vV/ZjdwzTnEbNgTeIPK/sEILfX5ooX Fft4UYm6GNnD6zL3BXupVJDHR8LEKNALxHCwyZYp5zgb6DQnArcU6DmSGahxYvemDj6kUVgS j7ITeJfOzQa2AtyUxww+Lk9kh5eX6aeF81YndmsZdlHWCDoXpr1/SXD5DDnFe5ex8Gz6UFKz fObSEJLg4G/aHA6DeF3DKDH24h3JMgI6jUC6kiaaja3hqWWcC1vLBDG/9f55B+Mt/y9ucNTO KEYgeQaDf1Efkg1QDQpnErPkBP2TUZuOKt3B3u926j2nEjRfLUPVR9XrkeZ8iG8HKMfYfB7L xpydYu+eegOGT4bdCLjanRcj5YMxvW5Wq7Vfshp5xYtb873YEDUaXzQH/NzjVKzR8+JMD7mA cFTKN37KvIN4Vvc8YREhgptGYBhZCKNg8mowb2CugxcRUxlHfdJcqO+KeNprw1AEGNzTGAcG W34mlY5bPCUCSC37JBVP51LmRSdUQm6HNtuOmFbJbdDQ22d+dFuFq2W0XNBIN1WeyAA/EXqB 0//tSD2+mQfCD80BrLvTR6LrlVmlzXCv+aEUaJA6pQ79e+OV6QmaOk7864kSfvRVKAGjElrJ wAcVZVc99KhTYjhpAmyyS+SqT4pUQ+jltViAsX4WLFy8yh+2fUHUZPLA3fjNFXRFBoQwq1sf g= X-IronPort-AV: E=Sophos;i="5.81,251,1610427600"; d="scan'208";a="39773267" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Boris Ostrovsky , Ian Jackson Subject: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" Date: Tue, 16 Mar 2021 16:18:42 +0000 Message-ID: <20210316161844.1658-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210316161844.1658-1-andrew.cooper3@citrix.com> References: <20210316161844.1658-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit In hindsight, this was a poor move. Some of these MSRs require probing for, causing unhelpful spew into xl dmesg, as well as spew from unit tests explicitly checking behaviour. This restores behaviour close to that of Xen 4.14. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Boris Ostrovsky CC: Ian Jackson For 4.15. Restoring behaviour closer to 4.14, and prereq for a bugfix needing backporting. --- xen/arch/x86/msr.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 0ebcb04259..c3a988bd11 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -175,6 +175,30 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) switch ( msr ) { + /* Write-only */ + case MSR_AMD_PATCHLOADER: + case MSR_IA32_UCODE_WRITE: + case MSR_PRED_CMD: + case MSR_FLUSH_CMD: + + /* Not offered to guests. */ + case MSR_TEST_CTRL: + case MSR_CORE_CAPABILITIES: + case MSR_TSX_FORCE_ABORT: + case MSR_TSX_CTRL: + case MSR_MCU_OPT_CTRL: + case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): + case MSR_U_CET: + case MSR_S_CET: + case MSR_PL0_SSP ... MSR_INTERRUPT_SSP_TABLE: + case MSR_AMD64_LWP_CFG: + case MSR_AMD64_LWP_CBADDR: + case MSR_PPIN_CTL: + case MSR_PPIN: + case MSR_AMD_PPIN_CTL: + case MSR_AMD_PPIN: + goto gp_fault; + case MSR_IA32_FEATURE_CONTROL: /* * Architecturally, availability of this MSR is enumerated by the @@ -382,6 +406,30 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) { uint64_t rsvd; + /* Read-only */ + case MSR_IA32_PLATFORM_ID: + case MSR_CORE_CAPABILITIES: + case MSR_INTEL_CORE_THREAD_COUNT: + case MSR_INTEL_PLATFORM_INFO: + case MSR_ARCH_CAPABILITIES: + + /* Not offered to guests. */ + case MSR_TEST_CTRL: + case MSR_TSX_FORCE_ABORT: + case MSR_TSX_CTRL: + case MSR_MCU_OPT_CTRL: + case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): + case MSR_U_CET: + case MSR_S_CET: + case MSR_PL0_SSP ... MSR_INTERRUPT_SSP_TABLE: + case MSR_AMD64_LWP_CFG: + case MSR_AMD64_LWP_CBADDR: + case MSR_PPIN_CTL: + case MSR_PPIN: + case MSR_AMD_PPIN_CTL: + case MSR_AMD_PPIN: + goto gp_fault; + case MSR_AMD_PATCHLEVEL: BUILD_BUG_ON(MSR_IA32_UCODE_REV != MSR_AMD_PATCHLEVEL); /* -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Mar 16 16:19:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 16:19:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98382.186601 (Exim 4.92) (envelope-from ) id 1lMCPU-0002l7-T7; Tue, 16 Mar 2021 16:19:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98382.186601; Tue, 16 Mar 2021 16:19:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMCPU-0002l0-Q9; Tue, 16 Mar 2021 16:19:08 +0000 Received: by outflank-mailman (input) for mailman id 98382; Tue, 16 Mar 2021 16:19:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMCPT-0002kv-1R for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 16:19:07 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c5875003-9fc3-438f-8ad6-81bc9887a3b0; Tue, 16 Mar 2021 16:19:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5875003-9fc3-438f-8ad6-81bc9887a3b0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615911545; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nhAX0yyRIBSeaz93pFWYK1z2uQ1J1CjJXlWF+mLEc70=; b=CBhszXhJW9KtURAl6iYjZaEUe0TbavZJcUQGu+6lkywI15gGy86ArN92 jLsxSDdlixrv1NTkmENLOw2/P+CKm4EQFheMweLPj/jwtew+oLp87/H7B bPK8OsrTia4RNIKRWO4iGi0ym5ePNCcjrmGuHcWK/Wa4GWCoDx6MVBPhd s=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: n5BQTAtLxqxafpFEdbx0CgRATm/N9FByb1BTMPGz+5IUy/d4lXv8xcSDA6HDCkCrcpUC57TnTM LWI7cd38qgdJcu03Cwj2qMqqDRe8xwBAmUxwWOxran2w3OxgQpzMbzHkG2YS3dm8+WSaJNExyH j1s57lhe4ECcZhbjmVUp/nsWFY8CHRvGOXcNid2BlXvY3T6hRQPVWf85Uy6Xxxc4x4y4MszrOr uM2J+D1kt1ui6dz1+TIIqS1jMI1YdHJpZEA7IWw6cFmlWN1muk+KUGAancjA7NcLwgNChp/pt1 8Sw= X-SBRS: 5.1 X-MesageID: 39404104 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:9rE3+q4hZN5th5CqIQPXwE/XdLJzesId70hD6mlaY3VuE/Cwvc aogfgdyFvIkz4XQn4tgpStP6OHTHPa+/dOkPEsFJ2lWxTrv3btEZF64eLZskTdMgD36+I179 YCT4FQE9v1ZGIUse/b502CH88k0J279smT9IPj5lNMaS0vVK169Qd+DW+gYytLbS1LH4AwGp bZxucvnUvDRV0tYs62BmYIUoH4zrWh/v+LXTc8CxEq8wWIhz+zgYSKdCSw5RsCTyhJhY4r7G mtqX2D2oyYr/q5xhXAvlWy071qnrLapOdrNYipgsgRJi6EsHfMWLhc X-IronPort-AV: E=Sophos;i="5.81,251,1610427600"; d="scan'208";a="39404104" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Boris Ostrovsky , Ian Jackson Subject: [PATCH 2/3] x86/msr: Forward port XSA-351 changes from 4.14 Date: Tue, 16 Mar 2021 16:18:43 +0000 Message-ID: <20210316161844.1658-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210316161844.1658-1-andrew.cooper3@citrix.com> References: <20210316161844.1658-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit staging was not impacted by XSA-351 at the time of release, due to c/s 322ec7c89f and 84e848fd7a which disallows read access by default. Forward port the XSA-351 changes to make the code structure consistent between 4.14 and 4.15. This removes logspew for guests probing for the RAPL interface. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Boris Ostrovsky CC: Ian Jackson Technically this breaks Solaris/turbostat insofar as you can no longer use msr_relaxed to "fix" the guest. The subsequent patch will unbreak it differently. For 4.15. Restoring behaviour closer to 4.14, and prereq for a bugfix needing backporting. --- xen/arch/x86/msr.c | 19 +++++++++++++++++++ xen/include/asm-x86/msr-index.h | 39 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 58 insertions(+) diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index c3a988bd11..5927b6811b 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -188,6 +188,13 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) case MSR_TSX_CTRL: case MSR_MCU_OPT_CTRL: case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): + case MSR_RAPL_POWER_UNIT: + case MSR_PKG_POWER_LIMIT ... MSR_PKG_POWER_INFO: + case MSR_DRAM_POWER_LIMIT ... MSR_DRAM_POWER_INFO: + case MSR_PP0_POWER_LIMIT ... MSR_PP0_POLICY: + case MSR_PP1_POWER_LIMIT ... MSR_PP1_POLICY: + case MSR_PLATFORM_ENERGY_COUNTER: + case MSR_PLATFORM_POWER_LIMIT: case MSR_U_CET: case MSR_S_CET: case MSR_PL0_SSP ... MSR_INTERRUPT_SSP_TABLE: @@ -195,6 +202,8 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) case MSR_AMD64_LWP_CBADDR: case MSR_PPIN_CTL: case MSR_PPIN: + case MSR_F15H_CU_POWER ... MSR_F15H_CU_MAX_POWER: + case MSR_AMD_RAPL_POWER_UNIT ... MSR_AMD_PKG_ENERGY_STATUS: case MSR_AMD_PPIN_CTL: case MSR_AMD_PPIN: goto gp_fault; @@ -412,6 +421,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) case MSR_INTEL_CORE_THREAD_COUNT: case MSR_INTEL_PLATFORM_INFO: case MSR_ARCH_CAPABILITIES: + case MSR_IA32_PERF_STATUS: /* Not offered to guests. */ case MSR_TEST_CTRL: @@ -419,6 +429,13 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) case MSR_TSX_CTRL: case MSR_MCU_OPT_CTRL: case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): + case MSR_RAPL_POWER_UNIT: + case MSR_PKG_POWER_LIMIT ... MSR_PKG_POWER_INFO: + case MSR_DRAM_POWER_LIMIT ... MSR_DRAM_POWER_INFO: + case MSR_PP0_POWER_LIMIT ... MSR_PP0_POLICY: + case MSR_PP1_POWER_LIMIT ... MSR_PP1_POLICY: + case MSR_PLATFORM_ENERGY_COUNTER: + case MSR_PLATFORM_POWER_LIMIT: case MSR_U_CET: case MSR_S_CET: case MSR_PL0_SSP ... MSR_INTERRUPT_SSP_TABLE: @@ -426,6 +443,8 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) case MSR_AMD64_LWP_CBADDR: case MSR_PPIN_CTL: case MSR_PPIN: + case MSR_F15H_CU_POWER ... MSR_F15H_CU_MAX_POWER: + case MSR_AMD_RAPL_POWER_UNIT ... MSR_AMD_PKG_ENERGY_STATUS: case MSR_AMD_PPIN_CTL: case MSR_AMD_PPIN: goto gp_fault; diff --git a/xen/include/asm-x86/msr-index.h b/xen/include/asm-x86/msr-index.h index f2e34dd22b..49c1afdd22 100644 --- a/xen/include/asm-x86/msr-index.h +++ b/xen/include/asm-x86/msr-index.h @@ -101,6 +101,38 @@ #define MSR_RTIT_ADDR_A(n) (0x00000580 + (n) * 2) #define MSR_RTIT_ADDR_B(n) (0x00000581 + (n) * 2) +/* + * Intel Runtime Average Power Limiting (RAPL) interface. Power plane base + * addresses (MSR_*_POWER_LIMIT) are model specific, but have so-far been + * consistent since their introduction in SandyBridge. + * + * Offsets of functionality from the power plane base is architectural, but + * not all power planes support all functionality. + */ +#define MSR_RAPL_POWER_UNIT 0x00000606 + +#define MSR_PKG_POWER_LIMIT 0x00000610 +#define MSR_PKG_ENERGY_STATUS 0x00000611 +#define MSR_PKG_PERF_STATUS 0x00000613 +#define MSR_PKG_POWER_INFO 0x00000614 + +#define MSR_DRAM_POWER_LIMIT 0x00000618 +#define MSR_DRAM_ENERGY_STATUS 0x00000619 +#define MSR_DRAM_PERF_STATUS 0x0000061b +#define MSR_DRAM_POWER_INFO 0x0000061c + +#define MSR_PP0_POWER_LIMIT 0x00000638 +#define MSR_PP0_ENERGY_STATUS 0x00000639 +#define MSR_PP0_POLICY 0x0000063a + +#define MSR_PP1_POWER_LIMIT 0x00000640 +#define MSR_PP1_ENERGY_STATUS 0x00000641 +#define MSR_PP1_POLICY 0x00000642 + +/* Intel Platform-wide power interface. */ +#define MSR_PLATFORM_ENERGY_COUNTER 0x0000064d +#define MSR_PLATFORM_POWER_LIMIT 0x0000065c + #define MSR_U_CET 0x000006a0 #define MSR_S_CET 0x000006a2 #define CET_SHSTK_EN (_AC(1, ULL) << 0) @@ -116,10 +148,17 @@ #define PASID_PASID_MASK 0x000fffff #define PASID_VALID (_AC(1, ULL) << 31) +#define MSR_F15H_CU_POWER 0xc001007a +#define MSR_F15H_CU_MAX_POWER 0xc001007b + #define MSR_K8_VM_CR 0xc0010114 #define VM_CR_INIT_REDIRECTION (_AC(1, ULL) << 1) #define VM_CR_SVM_DISABLE (_AC(1, ULL) << 4) +#define MSR_AMD_RAPL_POWER_UNIT 0xc0010299 +#define MSR_AMD_CORE_ENERGY_STATUS 0xc001029a +#define MSR_AMD_PKG_ENERGY_STATUS 0xc001029b + /* * Legacy MSR constants in need of cleanup. No new MSRs below this comment. */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Mar 16 16:19:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 16:19:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98385.186638 (Exim 4.92) (envelope-from ) id 1lMCPp-0002xO-Sl; Tue, 16 Mar 2021 16:19:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98385.186638; Tue, 16 Mar 2021 16:19:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMCPp-0002xH-P5; Tue, 16 Mar 2021 16:19:29 +0000 Received: by outflank-mailman (input) for mailman id 98385; Tue, 16 Mar 2021 16:19:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMCPo-0002wi-LF for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 16:19:28 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 39508681-bf94-4099-8062-d0420bfaea3e; Tue, 16 Mar 2021 16:19:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39508681-bf94-4099-8062-d0420bfaea3e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615911567; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=guXIUW2Hj1C8CTUWbOZUc8Q4qeZcP62gPTH+3TYZdDc=; b=NlHSVPvkzxS3vOeqhWrxYpA7PzB86h9LBpY4vqlBjcVwQFD79cm5zr7Q rnUgog+X/ko18MHB4Zv3aPFmYztPVJCcN3qO2RqraWnBriYHCpcvUOr+m 0GnX85GXNu40Ooo+wRZV1sUUuBwl+YDpjZpb5amcLBDHZNwFVAlj3NFgt I=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 5K15W2ANNPrmne+aw5lDyfY7SCi7xsJBU1A+bb8JSMJNB8HllYsedpmc5XB7uCIC27OBpOO3v1 XtmWFHXO2QGvIvvCB/AcBFCGf46AVs2AAI7n33SZLKcwpyiWZbd/YirGqOr17EubzOpwLSnRV1 Q94nvWd3T9U/hHBspaJTCK3vQ/rxTbPNexlHgHgc3bKP+6Edh56Z5YCgQJy8ywb+9+BVMbQoB+ a3DumS+HaWyuVyN4vY3swxv0yNZadUl0TUgs/AkhXnbqcf8WLlf8Cn7TdXNv4yuv2aAQOC0+7e Eqk= X-SBRS: 5.1 X-MesageID: 40833138 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:AbhGrqrtED33HaFeaWT+3t4aV5qseYIsi2QD101hICF9WObwra GTtd4c0gL5jytUZWopnsqONLLFbXTX85N05od5B8bbYCDNvmy0IIZ+qbbz2jGIIVyGysdx3b ptGpIOa+HYIkN9ia/BjzWQM9Fl+9Wf9bDtuOG29QYIcShPS4VNqzh0ERyaFEoefnghObMcGI CH7sRK4xqMEE5nDPiTPXUOU+jdq9CjrvuPCnRqayIP0wWAgSil77T3CXGjr3AjeghC3Ks49i z9mxH5j5/TyM2T8APW1GPY8v1t+OfJ990rPqKxo/lQDj3tjwqyDb4RPoG/gA== X-IronPort-AV: E=Sophos;i="5.81,251,1610427600"; d="scan'208";a="40833138" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Boris Ostrovsky , Ian Jackson Subject: [PATCH 3/3] x86/msr: Fix Solaris and turbostat following XSA-351 Date: Tue, 16 Mar 2021 16:18:44 +0000 Message-ID: <20210316161844.1658-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210316161844.1658-1-andrew.cooper3@citrix.com> References: <20210316161844.1658-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Boris Ostrovsky CC: Ian Jackson For 4.15 This wants backporting to all security trees, as it is a fix to a regression introduced in XSA-351. Also it means that users don't need msr_relaxed=1 to unbreak Solaris guests, which is a strict useability improvement. --- xen/arch/x86/msr.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 5927b6811b..a83a1d7fba 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -188,7 +188,6 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) case MSR_TSX_CTRL: case MSR_MCU_OPT_CTRL: case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): - case MSR_RAPL_POWER_UNIT: case MSR_PKG_POWER_LIMIT ... MSR_PKG_POWER_INFO: case MSR_DRAM_POWER_LIMIT ... MSR_DRAM_POWER_INFO: case MSR_PP0_POWER_LIMIT ... MSR_PP0_POLICY: @@ -284,6 +283,18 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) goto gp_fault; break; + case MSR_RAPL_POWER_UNIT: + /* + * This MSR is non-architectural. However, some versions of Solaris + * blindly reads it without a #GP guard, and some versions of + * turbostat crash after expecting a read of /proc/cpu/0/msr not to + * fail. Read as zero on Intel hardware. + */ + if ( !(cp->x86_vendor & X86_VENDOR_INTEL) ) + goto gp_fault; + *val = 0; + break; + /* * These MSRs are not enumerated in CPUID. They have been around * since the Pentium 4, and implemented by other vendors. -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Mar 16 16:21:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 16:21:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98396.186650 (Exim 4.92) (envelope-from ) id 1lMCRY-0003tD-8c; Tue, 16 Mar 2021 16:21:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98396.186650; Tue, 16 Mar 2021 16:21:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMCRY-0003t6-5M; Tue, 16 Mar 2021 16:21:16 +0000 Received: by outflank-mailman (input) for mailman id 98396; Tue, 16 Mar 2021 16:21:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMCRW-0003sx-KG; Tue, 16 Mar 2021 16:21:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMCRW-0007A5-Cq; Tue, 16 Mar 2021 16:21:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMCRW-0003Pz-4E; Tue, 16 Mar 2021 16:21:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMCRW-00044D-3l; Tue, 16 Mar 2021 16:21:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6oy71Qdlyfyt1XVu372T74ieAvH3Lv0AYimJhvvVnF0=; b=WhqE6QobrpQWHuTb/UAewqPo9I kUJpTmeeQi7RbvBDDqpt5AiUdem/OedkZOjr/xPRQIkY67Br76f0u1IbTyIBuXuutnR2nXH4K0sgg Abdp9Anc4ruDrmHCYDYL7tRuARPkEQm6cbPU0PCH/J283gkyYpgAoCHxJmdGs5fIf2ZI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160094: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-amd64-amd64-qemuu-nested-amd::broken:regression linux-linus:test-amd64-amd64-examine:host-install:broken:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:host-install(5):broken:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1a4431a5db2bf800c647ee0ed87f2727b8d6c29c X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Tue, 16 Mar 2021 16:21:14 +0000 flight 160094 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160094/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd broken test-amd64-amd64-examine 5 host-install broken REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 5 host-install(5) broken blocked in 152332 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 1a4431a5db2bf800c647ee0ed87f2727b8d6c29c baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 227 days Failing since 152366 2020-08-01 20:49:34 Z 226 days 394 attempts Testing same since 160094 2021-03-16 04:50:50 Z 0 days 1 attempts ------------------------------------------------------------ 5214 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd broken test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-qemuu-nested-amd broken broken-step test-amd64-amd64-qemuu-nested-amd host-install(5) broken-step test-amd64-amd64-examine host-install Not pushing. (No revision log; it would be 1293661 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 16 16:57:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 16:57:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98406.186664 (Exim 4.92) (envelope-from ) id 1lMD0B-0006w0-7j; Tue, 16 Mar 2021 16:57:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98406.186664; Tue, 16 Mar 2021 16:57:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMD0B-0006vt-4e; Tue, 16 Mar 2021 16:57:03 +0000 Received: by outflank-mailman (input) for mailman id 98406; Tue, 16 Mar 2021 16:57:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMD09-0006vo-Ez for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 16:57:01 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0fde48c2-619d-4deb-a654-c2f61091bab9; Tue, 16 Mar 2021 16:57:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fde48c2-619d-4deb-a654-c2f61091bab9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615913819; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Fy4fYtsW0uznKhJmjpg3BsB/hQfLvOLZRqHtlJV7/VI=; b=C5bt1g5SK8zf/ShrBEV+YM0gv8gycQnTEfKv6X7l1Ifvp3p+zWP0mwPu bFd561zkLIqWZKCR6kkHK3ti7Bf5KrPn7TQ14YYlNKzRUw3ciU1gU9p3Z PqyxHWRFY5Sny5Yne2AFLWiv+zYgFI6qvUryBI2goZh/NyVXGw4tE7iO+ 0=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: a6jNA+HNR6+ZELLmCpqg8EiDcute/q/ASAEBiQYz305h3hOp16AQg4i0yP1lOgaec5sAogC29d ghRjfFW5QQ2gMi7egq0zN/WHg5z8YjCBV/EMEflSSHbhBJW5Lla09yMxQKQzOkEtUuqT4fy8SQ Je93BgK4aBEHBTCKOP/+4w6PDL6z+jQ1OJIH6bdbWkbYVPhnBbQ4eJNcuSGPDX+SXMrHzYt9xE vuf6Y+MZJie6ePYz1Q0sCaqA4piHbAoMqjSjX0X+yxzI94KcH2ZWgDLpylX4K5Jh9S8IbhRjYN /DM= X-SBRS: 5.2 X-MesageID: 39424115 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:hON646517ePWDYSnQQPXwRKBI+orLtY04lQ7vn1ZYQBJc8Ceis CllOka0xixszoKRHQ8g7m7VZWoa3Xa6JJz/M0tLa6vNTOW3VeAAaNDyc/ZwzPmEzDj7eI178 1dWoV3FdGYNzdHpOng5g3QKbgd6f2m1IztuuvE1XdqSmhRGsNdxiN0EBySHEEzZCQuP/oEPa GR7MZGuDasEE5/BqiGL0IIQvTZoJnznI/mCCRsOzcc9AKMgTm0gYSKcCSw4xF2aVJy6IZny0 fpuUjT5qKvs/a0oyWsrVP73tBtt/bKjvdGDMyIoMAJJjvrkRbAXvUdZ5Sy+AobjcvqxFE2kM TdgxpIBbUO11rhOlubjDGo+w783C0g43XvoGXo/kfLkIjCax8RT+9i7LgpFifx2g4bk/xXlJ 9v5Sa/saFaCBvR9R6Nn+TgZlVRuWef5UY5nfV7tQ05baIuLIV/gKY4501vHJIJDEvBmfsaOd grNs3a6fpMGGnqCUzxjy1qyNyoaHw5Ag2LdEgEotCUyDhbhhlCvjIl+PA= X-IronPort-AV: E=Sophos;i="5.81,254,1610427600"; d="scan'208";a="39424115" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vyn3XuK/xfuGDRomolcYeIhgpwcp4nsbpYaWXENDzjww3LnYn+wRtZypffpX8ldHp7WpZy8MMvr5KS5JlSLyIj5uvA9/bPrnIWpJ03YOPTQ4Qqs2Z/qCZYRPxL8OWPNZOk1jpXgJffqF8lY5PSMEMoFSFYbSzA8KwuW5ud7dMxxFLJD/Xxj7MaRZsx8lqYpbqVoUtXOlnVw4Be5n13COwE2ROSopwiy1uwCs3/i7AZAbdzDdNW7lAJB6bT2MjVrAo04D/DyUD6EkPCNtlVKV7RvU+Y6CoyKBbfDW1Yz1hmA/az3UPxRSB63uzqmz00yiJL5kEihNe6xK5OpxA795/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hVIvL2AQAwlGUKJpF3Vu/Q8SeQcDuyYF4lk2o3iA9wA=; b=hfqFeDVTjFxpohJWiKhFlfxDDR5bpqv4lZwnWaPqs3VtKbVTRaL/ebUO2hJutOwFn53hf7ABE0qU+s9KZCG0rukFJwsDf7Dv/3wGofvecS5aT9QZm0i8ZaWAnqI53yJ8vIHu5LjYXqsjJBmXSmsJpvSgvEJ3GfzWFbatLw8tOoujwiIlYfhFuwsPkM7MZy0mWhfAJEvlUB8k9CjQb9D4mGfeP9bSMyIHE3R17cjXS16qgiKeRvhD+IPS1g/LUNwj6XC+StHXPEAhOAK69IlDuyCfXuDLciWO1ISHEzTL6KbIPdd7j7q+8ew0QmTcha4f3XUpQI+B61x5VdVqHkXUdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hVIvL2AQAwlGUKJpF3Vu/Q8SeQcDuyYF4lk2o3iA9wA=; b=AQBFYEwH6BUaxkWsxS8woNWMN3B1a5P8ZAo4xHlVH3Yc8QbGwN+7szkRruQrn6HxqFHmNrwJV+buLhXbo2uMSEJ7X0UI0X00o59Bv9ltpNBNrmFHi8CWFSbFMLPtNXqP713fyh9JtEhR31ubUq81uI2cQY+tAduAg1eOMsYgJO0= Date: Tue, 16 Mar 2021 17:56:49 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Xen-devel , Jan Beulich , Wei Liu , Boris Ostrovsky , Ian Jackson Subject: Re: [PATCH 3/3] x86/msr: Fix Solaris and turbostat following XSA-351 Message-ID: References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210316161844.1658-4-andrew.cooper3@citrix.com> X-ClientProxiedBy: MR2P264CA0189.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::28) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6b40d159-75c9-4ae2-a8f0-08d8e89c81a4 X-MS-TrafficTypeDiagnostic: DM5PR03MB2713: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h2KO5B2wzsVACKbITwMVagi6TLok1H+GyVW963au1R4yirWMWO3PivWDrjyA2ctGPZLW2RORhSmp09SQxUPhVcsN/2S0pnHj1eU5BmZWNIHEwY04Y5bA5mYE37N2leykHwXsFI4I9eTgdsSn2QsybWZzhW9C0gN9meJO8Htk1neGZs5CUwvBBa8PeGydlb2idVml308Ys8o4sWNOybxU5xMvEBhbY0MRhsD/tpLhvbDa4pBegQq5+G2YBe9/DAg4maKO3ZurUbJePnxm60ReAtD1fCHLb0nVam8iz4p6EGLhdZdKhSGTE2QXiaJaaO7npuqomJtxqq8BVJ+PyvgCYHwOljsBWNChqArvg7AZcoF5fbjROB3nwuW1wWmMuOYYCuHGTJ7XjxjluQtzwhvrOZLWqIo5gbs8SXw6dzBhPKNCihR/tDA7f7+Jvyf5WNxnxbwZEakUYoAanWU6ceeowCislpt/Xvi4gdwOqK2qeEaV8uMlvLKQRArV2CDKQN1K/IvxGPJvsc7KVJo4YfU2/g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(136003)(376002)(396003)(39860400002)(346002)(366004)(85182001)(54906003)(6666004)(6636002)(86362001)(33716001)(6862004)(8676002)(186003)(66556008)(26005)(66946007)(2906002)(66476007)(956004)(16526019)(316002)(6486002)(6496006)(83380400001)(4326008)(9686003)(478600001)(5660300002)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?OWFCYnNraFd6c3FRRW4wN2FJYkxaZ21yU1hVRDhQYjVRUHA2ZWpVV1l1MXI3?= =?utf-8?B?MTRkQ1V0OVo2KzloSzZjMU9KYXlrOE5xZ2d3NUhYeFVzZXcvTFgzQmNHVG4x?= =?utf-8?B?LzdTQVM4UWRWaDlUZzZSVllUL2ZRU0FKZ3hHNytBVmcrakRxL2lzZjBWMi9S?= =?utf-8?B?TktONE03ZTBwWFNLLytHWG43clZtUHAvZWVudzVxeERuMzhBdnVxQ3hNQkxt?= =?utf-8?B?WDZtcWsvSXdES3VmRW41cUZFMnVWc2N1ZkN1VHFrdzh6aWF5bjR1aUUxYnBz?= =?utf-8?B?T1hhMyt1V2M1V2pNT0NtQkljZTdvbTNZTUFNMzhEM1AxeTdDRStEelY2V3Y1?= =?utf-8?B?dEwwbE85YXVndWlDYndvOVc2QU5xcVdEckJEbmJhSlBjN1hYZ1h3YVk5V3Zv?= =?utf-8?B?bUxKbGJseGhZQnh4MmtITWdGSGxzSFdmSkEyazZtcXJLR3RaSWl5WDhzY0FE?= =?utf-8?B?VmNXcW9RRUlXVzZremIraG1OYkhKdWlBRXZYdUZzYlo2WkMzWk9rSW1LMVda?= =?utf-8?B?ekN4Z3IzWG13SWxvanFXek1zdDE0M0g2Skh2VHBIQi9IYzM1cERiR3BLT0Zv?= =?utf-8?B?ODVkQU1BZ1Q1N2Riekt4NDJTRXg1QjJad2dGRnFUeFRmZTgvVUErOUFGOTZm?= =?utf-8?B?aXZidU1VM0E0YVBaOFgyV3ViL1cxOE9YaHdPZzF3QkJYQ00vWGZJaDdvbERN?= =?utf-8?B?TUMzSVo3N01XVEVSR2ovZjFENDRXQXN2KzNXNFJTR0xwYlp4YzhSVEtDME90?= =?utf-8?B?d3ozT0JVaWZQZ1pTZE1nLzhISjZzREE1aThLbWRZU3h3UDdXZXIwTTd4NG4y?= =?utf-8?B?aVhVWXp2anBkVjRyRit4U0w1SXhFK3c2dDZDN2VqM1I2QWx3M1FNTHZGU3FV?= =?utf-8?B?aE5HSEhZa3d6dUE5RW1PNnR0MGxoODQrTitOTlI1K2ZSQzZmTi95cVNzc3V2?= =?utf-8?B?TmFHdVhUTFR1dGxycHVIZU5jY3Vhb2dnenhoUDVoQnQ4TU0vT0VZN095TXkx?= =?utf-8?B?V2wxK204UXF6bkh3RGZkQnNjQUwrcWZRaUJvNFIzSURtSzVjaWp0MGVwdFFO?= =?utf-8?B?akZGK0xMOXpoTHM1cHVJdUpnV09SdVJ1R0YrQXBrbTBPdXA5M3B1THlJTjZs?= =?utf-8?B?dkYrZTNWSm12RUlJZkJLMENaZDhwVFp5QVUxV3JQWnNlYVZ6ZldKRTFIN3Zj?= =?utf-8?B?eHA4RWVnQzRiVGN6cmtrc09rL0NqV3B1QzI4cGtKRVJYdEJaeDZVTXgybjBL?= =?utf-8?B?SHZ2Uzl5c2dEb3JqM2ZiaFc4blRRbmdoc2tzMlRhdW9iaThqVkZ4Y3VFLyt3?= =?utf-8?B?MjFydTRxQUMxQmVoQUdPTUFpK1pEZmVUSEw1a21HcVQyd3dqVzdRb1NYR3o1?= =?utf-8?B?S05KZlVnVGw5LzVqcFBUUkwzbUpyU3EybXZBd2R4bmo5bklDbFlhNFFBajA3?= =?utf-8?B?RUJZdkVNRnh5WEd6QXFLWkxXYzdZeFR0dThnL0lvemhJeVpucUU4ZnRMYVdZ?= =?utf-8?B?UDZpMHl3WHRKL1hLWHRlVWllbUxoZ2NMVUpydTQ1QU1YR05aZlRqT0d5ZEhq?= =?utf-8?B?NlJMWXJEMUliL1FXZEJjclh6QTJpR1QrWGc0WXRoL3Vxc1d2ZmJZVnhYNExM?= =?utf-8?B?L1NQWnIvY0xNTlVPWjBkL3EzekJ5b1p3N3cwS09jN1lmbThnUEcxTVdhSHk5?= =?utf-8?B?MkxZYis3YjlkbGZ1aHVsVUdJdHBUVTl6ODYxR2pyU1ljTTlmVkdjcjVaTnhZ?= =?utf-8?Q?HfhSREWJ67o9i1h8Ek1z+REHWFBFme/ix0C3cya?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6b40d159-75c9-4ae2-a8f0-08d8e89c81a4 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 16:56:56.2879 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K73AwcDkzvjoG/faH6oaiMrHxycJ7CldnEWQtA+61gQjYwS8MEaD7AOPef13KCKQpqMDSUhEGVnKko3eM8tFSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2713 X-OriginatorOrg: citrix.com On Tue, Mar 16, 2021 at 04:18:44PM +0000, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper Thanks! > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > CC: Boris Ostrovsky > CC: Ian Jackson > > For 4.15 This wants backporting to all security trees, as it is a fix to a > regression introduced in XSA-351. > > Also it means that users don't need msr_relaxed=1 to unbreak Solaris guests, > which is a strict useability improvement. > --- > xen/arch/x86/msr.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c > index 5927b6811b..a83a1d7fba 100644 > --- a/xen/arch/x86/msr.c > +++ b/xen/arch/x86/msr.c > @@ -188,7 +188,6 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) > case MSR_TSX_CTRL: > case MSR_MCU_OPT_CTRL: > case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): > - case MSR_RAPL_POWER_UNIT: > case MSR_PKG_POWER_LIMIT ... MSR_PKG_POWER_INFO: > case MSR_DRAM_POWER_LIMIT ... MSR_DRAM_POWER_INFO: > case MSR_PP0_POWER_LIMIT ... MSR_PP0_POLICY: > @@ -284,6 +283,18 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) > goto gp_fault; > break; > > + case MSR_RAPL_POWER_UNIT: > + /* > + * This MSR is non-architectural. However, some versions of Solaris > + * blindly reads it without a #GP guard, and some versions of > + * turbostat crash after expecting a read of /proc/cpu/0/msr not to > + * fail. Read as zero on Intel hardware. > + */ > + if ( !(cp->x86_vendor & X86_VENDOR_INTEL) ) > + goto gp_fault; AFAICT from Linux usage this is Intel specific (not present in any of the clones). > + *val = 0; > + break; Do we also need to care about MSR_AMD_RAPL_POWER_UNIT (0xc0010299) for Solaris? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 16 16:58:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 16:58:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98409.186677 (Exim 4.92) (envelope-from ) id 1lMD1P-00074T-JA; Tue, 16 Mar 2021 16:58:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98409.186677; Tue, 16 Mar 2021 16:58:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMD1P-00074M-Fe; Tue, 16 Mar 2021 16:58:19 +0000 Received: by outflank-mailman (input) for mailman id 98409; Tue, 16 Mar 2021 16:58:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMD1O-00074G-B1 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 16:58:18 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d55991bb-0153-4a3d-a78d-39c8b32f8bc9; Tue, 16 Mar 2021 16:58:16 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 054C9AC1F; Tue, 16 Mar 2021 16:58:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d55991bb-0153-4a3d-a78d-39c8b32f8bc9 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615913896; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WIz8ysMRreoa8wBnKxkWghvV2fqzA5RHl2nEEHwHTbY=; b=HhSJoA/2rH/iJ171MYlp9iOoaTNzRl4ZRGRcHY/Shstjl444UBqMvzG3zdlLbPKdklxhWH fH6T3VUtyabmIqDgDDLnGXsVphBLW7vCFZa3BytdM+nhA5kAzUPOFZiYBAsMMOmTjJ/iGh hmxxaUAQsKfDb8SRfBiaSfcqp6pmaRc= Subject: Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Boris Ostrovsky , Ian Jackson , Xen-devel References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: Date: Tue, 16 Mar 2021 17:58:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210316161844.1658-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 16.03.2021 17:18, Andrew Cooper wrote: > In hindsight, this was a poor move. Some of these MSRs require probing for, > causing unhelpful spew into xl dmesg, as well as spew from unit tests > explicitly checking behaviour. I can indeed see your point for MSRs that require probing. But what about the others (which, as it seems, is the majority)? And perhaps specifically what about the entire WRMSR side, which won't be related to probing? I'm not opposed to the change, but I'd like to understand the reasoning for every one of the MSRs, not just a subset. Of course such ever-growing lists of case labels aren't very nice - this going away was one of the things I particularly liked about the original change. Jan > --- a/xen/arch/x86/msr.c > +++ b/xen/arch/x86/msr.c > @@ -175,6 +175,30 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) > > switch ( msr ) > { > + /* Write-only */ > + case MSR_AMD_PATCHLOADER: > + case MSR_IA32_UCODE_WRITE: > + case MSR_PRED_CMD: > + case MSR_FLUSH_CMD: > + > + /* Not offered to guests. */ > + case MSR_TEST_CTRL: > + case MSR_CORE_CAPABILITIES: > + case MSR_TSX_FORCE_ABORT: > + case MSR_TSX_CTRL: > + case MSR_MCU_OPT_CTRL: > + case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): > + case MSR_U_CET: > + case MSR_S_CET: > + case MSR_PL0_SSP ... MSR_INTERRUPT_SSP_TABLE: > + case MSR_AMD64_LWP_CFG: > + case MSR_AMD64_LWP_CBADDR: > + case MSR_PPIN_CTL: > + case MSR_PPIN: > + case MSR_AMD_PPIN_CTL: > + case MSR_AMD_PPIN: > + goto gp_fault; > + > case MSR_IA32_FEATURE_CONTROL: > /* > * Architecturally, availability of this MSR is enumerated by the > @@ -382,6 +406,30 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) > { > uint64_t rsvd; > > + /* Read-only */ > + case MSR_IA32_PLATFORM_ID: > + case MSR_CORE_CAPABILITIES: > + case MSR_INTEL_CORE_THREAD_COUNT: > + case MSR_INTEL_PLATFORM_INFO: > + case MSR_ARCH_CAPABILITIES: > + > + /* Not offered to guests. */ > + case MSR_TEST_CTRL: > + case MSR_TSX_FORCE_ABORT: > + case MSR_TSX_CTRL: > + case MSR_MCU_OPT_CTRL: > + case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): > + case MSR_U_CET: > + case MSR_S_CET: > + case MSR_PL0_SSP ... MSR_INTERRUPT_SSP_TABLE: > + case MSR_AMD64_LWP_CFG: > + case MSR_AMD64_LWP_CBADDR: > + case MSR_PPIN_CTL: > + case MSR_PPIN: > + case MSR_AMD_PPIN_CTL: > + case MSR_AMD_PPIN: > + goto gp_fault; > + > case MSR_AMD_PATCHLEVEL: > BUILD_BUG_ON(MSR_IA32_UCODE_REV != MSR_AMD_PATCHLEVEL); > /* > From xen-devel-bounces@lists.xenproject.org Tue Mar 16 17:03:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 17:03:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98412.186688 (Exim 4.92) (envelope-from ) id 1lMD6a-0007yt-7B; Tue, 16 Mar 2021 17:03:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98412.186688; Tue, 16 Mar 2021 17:03:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMD6a-0007ym-3z; Tue, 16 Mar 2021 17:03:40 +0000 Received: by outflank-mailman (input) for mailman id 98412; Tue, 16 Mar 2021 17:03:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMD6Y-0007yh-Tq for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 17:03:39 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown [40.107.22.85]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 972cda3b-12cc-488e-8832-eb44080b4806; Tue, 16 Mar 2021 17:03:35 +0000 (UTC) Received: from AM6P195CA0107.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::48) by HE1PR08MB2858.eurprd08.prod.outlook.com (2603:10a6:7:33::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.26; Tue, 16 Mar 2021 17:03:14 +0000 Received: from AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:86:cafe::4b) by AM6P195CA0107.outlook.office365.com (2603:10a6:209:86::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Tue, 16 Mar 2021 17:03:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT008.mail.protection.outlook.com (10.152.16.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Tue, 16 Mar 2021 17:03:13 +0000 Received: ("Tessian outbound eae0c21066a4:v87"); Tue, 16 Mar 2021 17:03:13 +0000 Received: from 04a2200e7df6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 52AFEE51-D55E-4542-926D-DC5F52EC2179.1; Tue, 16 Mar 2021 17:03:06 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 04a2200e7df6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 16 Mar 2021 17:03:06 +0000 Received: from DB7PR08MB3500.eurprd08.prod.outlook.com (2603:10a6:10:49::10) by DB6PR0801MB1991.eurprd08.prod.outlook.com (2603:10a6:4:71::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Tue, 16 Mar 2021 17:03:00 +0000 Received: from DB7PR08MB3500.eurprd08.prod.outlook.com ([fe80::5959:35df:3647:b78d]) by DB7PR08MB3500.eurprd08.prod.outlook.com ([fe80::5959:35df:3647:b78d%7]) with mapi id 15.20.3933.032; Tue, 16 Mar 2021 17:03:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 972cda3b-12cc-488e-8832-eb44080b4806 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XpdsNT/0W2Q+Lc807unc1Uhwzf7v4rCqEvbSwrwDcTA=; b=LtqVVQuF10loyTlONNbdEwyTZ4Sved+k3yBV59IxZT7ZBkQyuk6Cc9Um0iDR8qnKrTll/iqzCeJj6pOodV+IQeH5lKpPcJitS21F8Cw5BcgxeFhskKGbsUhmrFynaeVTw989zWcInlJqbvf8YPltc9mbhwKBR5z876QgquBqwH8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 80b46cef7a0eacaf X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ioPX2LlDtrY88Ht/OLSsAz8hRW8AIv4IxPCFTT8SejB3BfUNrUftKQhgWQ7wYgLX0x8gFr6tpnGZUXYLL/YRV+aBYCTyW6GLGMC8C10mkJLiIEUf/A96odzs63DECXndupGG6oSbg5ivTaMGtvFitWyMMzxm1TybFAsIDnL59XYZBeFPupwqyebR1cbw6hVSPyec23uqgs8MJTZnStTzLzSPmuNdecgMGwzcvNUQsAgndJfRsyT6dbwgUSOcioTKBQeyOuTd9ebEh3w9AC5b5q/Yt6u7/yg+viPLngFz0UX4wTiFrcuZq6fG0+9xWLAnNikVzDMYQaZkSB/Mabt1cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XpdsNT/0W2Q+Lc807unc1Uhwzf7v4rCqEvbSwrwDcTA=; b=VSoVOJJrph1vVB8gaJ225dHGev5FUkjDbsxpXShtNF14fLSgkoVyRbkN77rRrbPwAkJDcelRJFUMT274S8ci90GoYAyf2CDcO1ve3VqjE5B1Z8yGSgncx89/vikgXG/xbZBiBU/XmjT4Mn6wfYIINd0I2Y3/WYsYWeX0Dzu7HnuvordbfdDTPMcVGxs1u21CLKmZP/zXbooTvJa7IExNK+9DFA8Pee2vN3xxN2Tb0mWMlNN9HwvFG5tQ9wTx/DVY+PqRl/5GLXbvMAJS+JyZ2hge7+txN8ns+5Eu32bSuq25D23s4p8rParBkglxt12v7lOIfWfTCM0wH8Yi2SJYDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XpdsNT/0W2Q+Lc807unc1Uhwzf7v4rCqEvbSwrwDcTA=; b=LtqVVQuF10loyTlONNbdEwyTZ4Sved+k3yBV59IxZT7ZBkQyuk6Cc9Um0iDR8qnKrTll/iqzCeJj6pOodV+IQeH5lKpPcJitS21F8Cw5BcgxeFhskKGbsUhmrFynaeVTw989zWcInlJqbvf8YPltc9mbhwKBR5z876QgquBqwH8= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 1/5] xen/arm: smmuv1: Handle stream IDs more dynamically Thread-Topic: [PATCH 1/5] xen/arm: smmuv1: Handle stream IDs more dynamically Thread-Index: AQHXFRDxe8GGVnZwKkOnqqCxaz3gPqqGxKGAgAAdrQA= Date: Tue, 16 Mar 2021 17:03:00 +0000 Message-ID: <33CC3689-401C-49DC-9F62-2A30AEEA4F46@arm.com> References: <7775719c50c56b801e69d952e4ce255b8da1481c.1615312254.git.rahul.singh@arm.com> <0ff580cf-0e06-ae17-32c9-bf8dce26aead@xen.org> In-Reply-To: <0ff580cf-0e06-ae17-32c9-bf8dce26aead@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [80.1.41.211] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: beb36ead-ac2a-445c-9f33-08d8e89d629a x-ms-traffictypediagnostic: DB6PR0801MB1991:|HE1PR08MB2858: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:989;OLM:989; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 46ZUT8M2b8aBtDLdX6vuR/Zrt1gvQlzDxq3FeD1laQ0VttKWeJk3M5voOFqMZZYvRzaHxLYmtEf/zaWXVy3MQQWlCvt14qcsAsGwJT0x2fHCoyB0QOTOU8SMLPZKvxLiw7SjbXqTfk77q4tVL7tZZR8eUErqGmaQaz/P9DezeC6p/d1k4kpMZeZGxiIcuaWrFl4qLqFUtoZojZEnp1xO0oCWZ526XOtFMc33EKzNGN8nCOvGeCr5bBbYrhw8zSIKKyRwH+wKbfN9F8hptMvHsfjh5BpuWBGcxV4rs2MFuoX4SKlKVMRxzaNnfRmqpX/wXhzpCDFpRxZQf8sbIbQqdIGU7WVor0Nu5Z+lHJrQT5mL4qF6MwBUsBG2YcbbLSpC1ULfYnpQB51GRTt+f9Clgawusvz0LaPKPtA1PMLvQHB8QyhJJamBj1bO/Xgt81a2noRccyT5+zhqmCUZNF8e9OpG24tlQ93brJvy3hUlRzqY1jyK+J2rAO94T1W8SW+XTBw1U5BfEpVhBia832zRsLs6KfwO7X4dA1tRaHBYGgx1kyYzjubyfzrlJMnfjSePyoD97XbHkUa5PPlCjto/i2yRLfPRjCWTjUtA3nXqrklUONr0QJbgWOBF9PNI5oyW X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3500.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(136003)(396003)(366004)(376002)(86362001)(2906002)(83380400001)(66446008)(64756008)(6486002)(316002)(4326008)(8936002)(66556008)(66476007)(53546011)(54906003)(8676002)(36756003)(6512007)(6916009)(2616005)(33656002)(26005)(76116006)(71200400001)(66946007)(478600001)(186003)(5660300002)(91956017)(6506007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?cr8cbBRw23MXbVSZPfUnmE00t4Mc/tMKGMoc8eKSNgBZGXUSuc8IrGUd+ioJ?= =?us-ascii?Q?24l+fKi//SGLVf096KKTyi0FplTPYw3zynu+C6ck9PAbnA3W8X3qrnpG5ShT?= =?us-ascii?Q?i/XZ+Ft0wrs4RSA3uqbgbvBZaUzivUCIxQfuSFuMbSf01EaQwcmW3puR5QJe?= =?us-ascii?Q?+Xy5pXOLFtP5Pl5VbcRDZnVnbHy4Y5CCsCOVZ+bZ86qKWOtzf1jMI5E5iXTO?= =?us-ascii?Q?8Ca7LlxaY2RCrowpTexdzQyLxNVPIsgdqMhMokVWiz1pvj8+HvYL0JumjcZk?= =?us-ascii?Q?DP3GOj4mY3oDI9ByC5MoczTAFdq8M7/fWG5pvUc6CoEyquZSeALF8it+xQp/?= =?us-ascii?Q?qC4mjUkJNIins5IMyuNR35RWWvScrqTf1k8syNP5RipwXfVc0q4HGnezkZ/g?= =?us-ascii?Q?AlCN8lvNSMzw9zqVnJhj2L13XvTIj1htVMzxorRXIDD5iIvoEBrTIGzixiOZ?= =?us-ascii?Q?CVjjUndDk9CeuWASjrlC8/eEKkDWBLiVhzUx7qEXgPNBRd8ALRSpHiRM+XJV?= =?us-ascii?Q?vU0wLa4ORf4siqLW9NPvdsDctlo+wup+ctC0rpAVD1oIofOwhVDGMTenLG81?= =?us-ascii?Q?TNH3ZE7gCCClgRFNgdc1854UJ5NtFYyk7YkMAvUczvREgpF3RazHkLj4H3yA?= =?us-ascii?Q?FFFJaHQnNDxss/mii5ehKj62JI+poe1geyXjA68LGt6tkl5ncPqWu0Wxeuhm?= =?us-ascii?Q?Nt/EhSHcxv++CVVs9RQYhmHTf10Sm617NQenREVV/RY1SLQyOw0sVuoQoW3T?= =?us-ascii?Q?slsesaTOzOqRETK0T3YJj8mmbEV/T1h3hxULKcq2USN5kBYzgacbpUHRs1DP?= =?us-ascii?Q?oXZBL0e7TbLig9smc/GosnJTCspXIyHg9FQoU+/+/Wos9opAZNWfjPH+tiNP?= =?us-ascii?Q?IsFyyIj0KEUwg4dOWRdcQXcXSHaGD9rVseOu7pcRi5dw9BI/eN6KZyczTa7o?= =?us-ascii?Q?M1r+Oy0Vf6QlJYp5vrmBl+PzOa60tVivxB1YJuhuuSf8G8/U5B2XjmnK7W8/?= =?us-ascii?Q?O9EvGr+5FakA28x6/j76W9D3sXt5V1D9gKFsTSDcW0NSzuVldvh1L/hS8zvR?= =?us-ascii?Q?QhT8/KtVybMwwfB1BjjDftqw31aAPXzL0PLzVPPnDzZ8pgpVKG9+7sb38Ekc?= =?us-ascii?Q?Z8kk0vzhw+SYwnIi+ky3na24BYI/CfRdFnENlaIXbKGmYVaWn4ul+33orDHP?= =?us-ascii?Q?zME7RT9i5EXSxzGlNVic86MgRXAN6KsoKRQlu3jSbBtuWBIAK3v4tDpwtpbR?= =?us-ascii?Q?k8QZuRNwTkwNRWoLTBN8IeyV5loru44yq8AWroqWLV1w6WmvQvTJFKj2gIYU?= =?us-ascii?Q?73U0pFOt5t3hLl3x2AKw/La5?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1991 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 77801180-1727-4d05-938c-08d8e89d5b0f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pit3vup9p0fwZlhxfd6PTuQxKK6pH8CVm9ykZUV9U8bTv4WnUfxJAiRlJarMcbN0bQbYB++KfHPoEzWgsl0ILUaCKerEEkm9hePqsRAudjD5/Ax9yD7JYsbfnWPRRLfDPgUzopS8MGBmM0ffU9Q2Nm/kwWSazPUDHwysZfvc0SRCEJI0mO+XWnfkoc7KKkn2QYjtKxqYuBbJhWHx4oP68JEKH1M2wLk/DybJmlt9XZNbFtEDaydU8cy/LEaJMUiGC3eH0x0UtD6g1jwzN1EEhGUubrms5n/X81nUBq2IL4SqrHbHA+1HVfWYXnq50nnGeMOVU4XW1zNugo7fQ7ZIucoH0FwYhuWQ8+GMCGuF/rcDTymeZcmMtzgTWLyFd5FUP/rB8wHcqpW/L12cSXbbhfn6pY7CpLFAVTzZC7O1i7giNeuEoMy0x07jOt5vc1K05tCJ8EXPtflLE2URVlILfNRtmlf2qm/KeNvCu0XsC3/eX5YO9vhFsRVlg2YNsd1GYCyiFrhkL6PQHYOolIpN2VYKLu3Pilw/qwWktBdDKEmyWDM6yb5bNx9Rb5SyrtXxDFgrlxI2DoIPRlpnXPfo6ZU88jEbjH7bLpCH8BLK5G20UP8hdLcJDJVyXZEM/oF4BRlcfd3onCh/Gg4lHHX1ivwinVpVsODPw56tRJjNT8s= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(346002)(136003)(39860400002)(376002)(36840700001)(46966006)(2616005)(5660300002)(6486002)(36756003)(36860700001)(6862004)(4326008)(8676002)(478600001)(2906002)(186003)(26005)(107886003)(336012)(8936002)(6506007)(81166007)(70206006)(356005)(70586007)(53546011)(82310400003)(316002)(82740400003)(83380400001)(86362001)(33656002)(54906003)(47076005)(6512007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 17:03:13.4215 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: beb36ead-ac2a-445c-9f33-08d8e89d629a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2858 Hello Julien > On 16 Mar 2021, at 3:16 pm, Julien Grall wrote: >=20 > Hi Rahul, >=20 > On 09/03/2021 18:19, Rahul Singh wrote: >> Backport commit 21174240e4f4439bb8ed6c116cdbdc03eba2126e >> "iommu/arm-smmu: Handle stream IDs more dynamically" from the Linux >> ernel. >> This patch is the preparatory work to fix the stream match conflict >> when two devices have the same stream-id. >> Original commit message: >> Rather than assuming fixed worst-case values for stream IDs and SMR >> masks, keep track of whatever implemented bits the hardware actually >> reports. This also obviates the slightly questionable validation of SMR >> fields in isolation - rather than aborting the whole SMMU probe for a >> hardware configuration which is still architecturally valid, we can >> simply refuse masters later if they try to claim an unrepresentable ID >> or mask (which almost certainly implies a DT error anyway). >=20 > For single backported and verbatim commit, it is common to keep the origi= n tags (I usually indent them) to show who is the original author of the pa= tch. >=20 > Since 7936671da9fbf645d6bb207608f7b81c27f992de from Wei Chen as an exampl= e. Thanks for reviewing the series. I will add the origin tags in the next ver= sion. Regards, Rahul >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 16 17:07:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 17:07:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98417.186701 (Exim 4.92) (envelope-from ) id 1lMD9v-0008A5-Qm; Tue, 16 Mar 2021 17:07:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98417.186701; Tue, 16 Mar 2021 17:07:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMD9v-00089y-Na; Tue, 16 Mar 2021 17:07:07 +0000 Received: by outflank-mailman (input) for mailman id 98417; Tue, 16 Mar 2021 17:07:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMD9u-00089s-B7 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 17:07:06 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown [40.107.21.88]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 60d6f742-51ae-48d8-8dd3-7b6466fd81c4; Tue, 16 Mar 2021 17:07:03 +0000 (UTC) Received: from AM6P194CA0019.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::32) by AM0PR08MB4274.eurprd08.prod.outlook.com (2603:10a6:208:148::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Tue, 16 Mar 2021 17:07:01 +0000 Received: from AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:90:cafe::64) by AM6P194CA0019.outlook.office365.com (2603:10a6:209:90::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Tue, 16 Mar 2021 17:07:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT027.mail.protection.outlook.com (10.152.16.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.30 via Frontend Transport; Tue, 16 Mar 2021 17:07:01 +0000 Received: ("Tessian outbound de94f9ae513a:v87"); Tue, 16 Mar 2021 17:07:00 +0000 Received: from 0c995e595dc9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EDF8E1D4-0845-4384-975E-0F31808A12D0.1; Tue, 16 Mar 2021 17:06:54 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0c995e595dc9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 16 Mar 2021 17:06:54 +0000 Received: from DB7PR08MB3500.eurprd08.prod.outlook.com (2603:10a6:10:49::10) by DBBPR08MB4631.eurprd08.prod.outlook.com (2603:10a6:10:df::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Tue, 16 Mar 2021 17:06:53 +0000 Received: from DB7PR08MB3500.eurprd08.prod.outlook.com ([fe80::5959:35df:3647:b78d]) by DB7PR08MB3500.eurprd08.prod.outlook.com ([fe80::5959:35df:3647:b78d%7]) with mapi id 15.20.3933.032; Tue, 16 Mar 2021 17:06:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60d6f742-51ae-48d8-8dd3-7b6466fd81c4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mm8MdkA4KdSN0n1Dij2AW5qLN6F/GlSkM5fRrXQnwNk=; b=FgaJHwzWBao7BLSz9XPQb5IaEJ67T5DuiUE7QRqRSVDY+v5ke1bKQvYWRCLduStbE5KCuItbxoIQJuYW1M10rw4HHCCIpjTdGCfMNTy1vHhRCiAlDLw32Z/TnVtO4+sBHuz2M2SCYlLIjRVi+wlsO0ECeV19JJaxVlTTw9TpChM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 835dc192ede73ba6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nqb9/1pxzngVSxxD2hXONK5EU8LKs++m4HtBJP9ckh3ZQUTexEhgBganUBeNlpCHXcLUajIGr6eBjqwTLgCqms7yN4vFW9OH9Vbd0TZL6rPk34gbY8xvCDw2kxog81Dq6+HFSqctNXtWHV9hd176EUquDUzD6bCTJbdGCpDozSzSVp87fZIHSY1Oe8tL4bZDEudrZN+DN2SkiF7lM2JlVeAYXZsxUe3mx8heJa9tVNP2PVU7jYPxtiVxvi6+acC+/bSm2ztx3q8lvt4ZYLk8MxTmyBtRsMgiIhUurovDug95OfYtilgAbNGmylPKVM0DseovOTUXK1+x0ip9gPPWsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mm8MdkA4KdSN0n1Dij2AW5qLN6F/GlSkM5fRrXQnwNk=; b=eZFmQjhAhGpe2wWUA20MG0tEO9wVcgMqGzmb4rvC6/RD3gnO/g0IShulrDA+u5WBv+0grXJTsoyBZap/EPZ8F0xbTv6/YGO8c3QLmX11FunqosETTF47vOgRJArudopoIDM6eMY+S6b75MD8RAtnNgl6JdIFoNIJoeJSFPauzqbA0RkJ3cndXADIXtRbJGKxF+kCNf+JsxRdoSAlmeAomCeP+CCIrRW/EQrWZY3L6dCmUYH4J2BdIB37J+qJ9lqzPEXEhiJ4HkazNWbmwGKNDAhYu/RKKcXIVWcqcuoUvuhK7PAvb3Dby3qlp0J9JjxnGRN8L8guojNbikm6kfDcXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mm8MdkA4KdSN0n1Dij2AW5qLN6F/GlSkM5fRrXQnwNk=; b=FgaJHwzWBao7BLSz9XPQb5IaEJ67T5DuiUE7QRqRSVDY+v5ke1bKQvYWRCLduStbE5KCuItbxoIQJuYW1M10rw4HHCCIpjTdGCfMNTy1vHhRCiAlDLw32Z/TnVtO4+sBHuz2M2SCYlLIjRVi+wlsO0ECeV19JJaxVlTTw9TpChM= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 0/5] xen/arm: smmuv1: Fix stream match conflict issue Thread-Topic: [PATCH 0/5] xen/arm: smmuv1: Fix stream match conflict issue Thread-Index: AQHXFRDsIQlmaPX4d0+O/QrVoxXC06qGwSeAgAAiOwA= Date: Tue, 16 Mar 2021 17:06:52 +0000 Message-ID: <422FB89E-E5A3-446A-BCD9-650F4EC79BA5@arm.com> References: <7b521058-7e83-2651-aa1b-02098e9bbc19@xen.org> In-Reply-To: <7b521058-7e83-2651-aa1b-02098e9bbc19@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [80.1.41.211] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: cef07b92-016c-4a7f-c468-08d8e89dea5d x-ms-traffictypediagnostic: DBBPR08MB4631:|AM0PR08MB4274: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:923;OLM:923; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QpcMOaQ4OY+KOE0WX9y2GT3MojS8SDDJHrPKv2HpyNX+Fch+h2CKOXaHTsmp748W0KKygp2tKTRGyHOckhvHO/UC71aKgGKsZGCBY+RwXpuavmYEHRAsWW7iFiJg4xKXExRubq4W39vdKUvuE0cV0qCqOsz6RrIiOU6NlD4g+9VUvXeNaKLO2I6fFPH+KJ7pFFzs0XUEqpdXocsyiklxN07U9oTDAUf31atig2dO7A2hw02WOn0G2bUDlQQG5BLaVSdu1gQOKRCr5J/k64LNB5v13rjn1quQfdpz+3xXnXUthfb+kZEXBGUmif3erSzLJ3ittynk1kki17qduxXG4e4xUQBdd7OQkDkasUemnfZsAlj7yOwpfuvTtIgCSj7w135HUR0jxof43Hc+37iUPg4TLNlje125v8taGnvRqB0PkRrQP5wHWR/d4gtytV4qwy7iSmXZJewh1W8U5riygjtjBhLRWy5Mv1Dhk10nMRrANrnHGH+rF1dsiCXK5HTnboJFvaL+M9E0tFPUlq7sdvY9Au3vxlmQl+aqExxWAuVqa702TwVaT/oDie3NpGtePYgbGYpkXR4FuEt0k24+0V5hTn7vfADcdzHFp2OWuE5aFu/Rb4milB/fSMkCK0/i X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3500.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(136003)(366004)(346002)(396003)(316002)(2616005)(6486002)(66556008)(33656002)(86362001)(6512007)(71200400001)(36756003)(2906002)(64756008)(54906003)(91956017)(76116006)(66476007)(4326008)(6506007)(8936002)(53546011)(8676002)(26005)(6916009)(66446008)(5660300002)(478600001)(66946007)(186003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?XujBSLXN7AJVdJyQiR6geNuhMMBCqGCqM4jOGUbYfungsuJjvGKqJQOwzmWZ?= =?us-ascii?Q?0q0fu36Gpsq9JeF8rZdvv0a5uUQAGVZxToSogL7JZTLPVc6Z3mR3WO0HIhP/?= =?us-ascii?Q?BJXH2aTTw+OHr14bsuIz0THEk3ZpK2Oa2sZCdVXQK8Hz3Gd+czq2xioVMDRV?= =?us-ascii?Q?WdBLjgcaBVZtinfquao2Z/TIGUX48Koc0xcXmVpMVm3nGb/QSJguvjfdq9NC?= =?us-ascii?Q?B6XNVY56yFHjqpkhXKPdp+kz/ATWQzm9EPxZLQ3SkAOy5u2ZBZ2ARjzYzYPD?= =?us-ascii?Q?zX5fmEckCHibexP0eHD4kCa0RxZRaFT++NQxZFCiQSiTRqFjPR0lBaVioYHC?= =?us-ascii?Q?JxVhTorhmoPQyD/ZEX6MYqM07Q4OiFDXgHGgES1fptynWNA1vMnf1Ywj3CQf?= =?us-ascii?Q?C5INA3KU0mUwbr8bTc27z1HYduB/EOdN3xlIr2U7jYlfzGoirSn9xNBTMQzB?= =?us-ascii?Q?1pWpd+XVs/dTbXzftrfUyNTreuu55DhdXqoHhw37I/+drrkCFxU1LdG20UgH?= =?us-ascii?Q?BRsQ7onv5yXqKS6iSoRs+FTPoamj+4EWOOm6hledJqZODu4C2pq0kocwuzc6?= =?us-ascii?Q?ltOzXmlmIC50oXw86kdAy8m2y9VvntZsiUZp6sslVrU/Ci8YeiKy5Qh8i2qS?= =?us-ascii?Q?FuI8I2xcoaHRmG2J9bITlMIv8vkoLD4j7YybsWaKsYWkpqxhVOfSUIpPYQPC?= =?us-ascii?Q?0Ru9u3GXPIooBDqYGRXvpNX5f8Md09LeNtP8DJak/zbS22Ok+rZrwCc6TQ9t?= =?us-ascii?Q?wX85nmNo1mjm4BQvWstQoBLpUChgqTGdYO1vDPW0jZWsadXX6dcvnwfWxXHu?= =?us-ascii?Q?n3JDjFujuA9qsPJTou2Qlky14EWNt1/iST+zcpPIW/nY5x1oGAbGmZdBmiKS?= =?us-ascii?Q?IpKlLrh2aTRK4qVZFZBwd28Yk0SuCQTfSW1ZR+lv+UX8Krta0UZJJebLO4pa?= =?us-ascii?Q?Flb0B2q2+5lbDAgIntXrpjDi40HoIzRNs1GiBfaNUxosWwEPv56t38nl9ROb?= =?us-ascii?Q?Ql3Fb3CHBOHS+YDEd1w8z/d33hTR0ovsMvdgdXZ88BBBhDVCEVfG9qE3JrWk?= =?us-ascii?Q?1Nw4AEkuc8P4FS/5vgDs7E5fY3aYFNr2Tx0rWFQ9Uhy3JawMzF2QYuQX+8eN?= =?us-ascii?Q?l7ky7zM6JyAP/rR16zNF5mGb8ixseQQCKx1IPl0lT2P0hiEy1MReOKU54JfN?= =?us-ascii?Q?+ZEukaza39JU4lUvjhL+CC8nBfwWJB2wBtMylv8RpuRBqj4lBea86uPDuyBC?= =?us-ascii?Q?cFa+sMJq1Jv8sW95oAVXj0BQn1zk7rUHpPL/sXQepaq+Wc1HXzWv2N2ySpun?= =?us-ascii?Q?iMc8ceEqttfye7qL12hgNEDW?= Content-Type: text/plain; charset="us-ascii" Content-ID: <29753B9EC39B0741AE9DDC5C0557F98D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4631 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 10b0f058-1c67-41fc-4efd-08d8e89de583 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7n8g2itlCOky85cYDGGhMULg0upfSJQLloMMCJcS2y0mpG5I3HlKqRJoilVHmzXQdcI3rzyUKl08CShCPNbK8kgwU/vJ6mQbVpmru9TnmeitNJJ71O6m+W5dTJ1Kjn61UGth9t0RjL8/Hbq5ydriywKv8Z9sbFeSaj7rTifkrGUMy/XFaogyxcFXeXIUQ/5S7yQ0kcL/rsxBvgm+EahbTDa9/SgOc+SMqqZSjp/bGZkM5rSYerO0FoxOAQNbneoM2Ihe/3KeUP+me8ltoHpgzOngL8AHQ4XLO0+O7klaxddhKynBuFCDAtku9KbOWo/kySnVRGMAU9Dudi1u7gIVsmdE/ymmhPyONprs9I4JqFPv6Lwi7iuO9ezOVGYiF3Kw7v14Q7oLYOoHgeBO/aIIKBn47F4yboa5mcPb9+onysV2pzU5TL9v16B40PyDsuzeR9mlcWWGUQf9UWjqfza1zoU9a6q5HQdKJ6jIQSsApokW4wZmJuSfLeTvfKadW15axwFoNCTcU23uF4YcLStI2WmxCEy2QqxVp3kkk/O5m/hBZlgPcQBEwvyBVvnLrmqNHRUSmbV/dUlUgdXBADqlddueCgkFIsMPubUsEsbeZ1sVHybXQlemPIqIbz91yNOwORooBdrtItWY0b7724YJVb+a6b+395S3Bes8+veZ/DU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(39860400002)(396003)(346002)(376002)(36840700001)(46966006)(336012)(4326008)(33656002)(186003)(70586007)(26005)(47076005)(6512007)(107886003)(81166007)(36860700001)(8676002)(356005)(86362001)(6862004)(6486002)(53546011)(6506007)(70206006)(82310400003)(2906002)(36756003)(54906003)(5660300002)(2616005)(316002)(478600001)(82740400003)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 17:07:01.1858 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cef07b92-016c-4a7f-c468-08d8e89dea5d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4274 Hello Julien, > On 16 Mar 2021, at 3:04 pm, Julien Grall wrote: >=20 > Hi Rahul, >=20 > On 09/03/2021 18:19, Rahul Singh wrote: >> This patch is the work to fix the stream match conflict issue when two d= evices >> have the same stream-id. >> Approach taken is to merge the below commit from Linux driver to fix the >> issue. >> 1. "iommu/arm-smmu: Handle stream IDs more dynamically" >> commit 21174240e4f4439bb8ed6c116cdbdc03eba2126e >> 2. "iommu/arm-smmu: Consolidate stream map entry state" >> commit 1f3d5ca43019bff1105838712d55be087d93c0da >> 3. "iommu/arm-smmu: Keep track of S2CR state" >> commit 8e8b203eabd8b9e96d02d6339e4abce3e5a7ea4b >> 4. "iommu/arm-smmu: Add a stream map entry iterator" >> commit d3097e39302083d58922a3d1032d7d59a63d263d >> 5. "iommu/arm-smmu: Intelligent SMR allocation" >> commit 588888a7399db352d2b1a41c9d5b3bf0fd482390 >=20 > A couple of questions: > * Are they backported verbatim from Linux upstream? Yes all the patches are backported verbatim form Linux upstream. > * Did you check there was no bug fix afterwards? Yes I checked there is no bug afterwards related to the patches added. Regards, Rahul >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 16 17:11:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 17:11:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98424.186716 (Exim 4.92) (envelope-from ) id 1lMDEL-0000g6-Eq; Tue, 16 Mar 2021 17:11:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98424.186716; Tue, 16 Mar 2021 17:11:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMDEL-0000fz-BQ; Tue, 16 Mar 2021 17:11:41 +0000 Received: by outflank-mailman (input) for mailman id 98424; Tue, 16 Mar 2021 17:11:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMDEJ-0000fp-8a; Tue, 16 Mar 2021 17:11:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMDEI-000837-VU; Tue, 16 Mar 2021 17:11:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMDEI-0005sL-LS; Tue, 16 Mar 2021 17:11:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMDEI-0006Oo-L1; Tue, 16 Mar 2021 17:11:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+tKglXJfd+62SvXV8wVEvlFGVqtE1ijtd101fUG6rwc=; b=D2jPKaKn/eiDH7C+EyLZ0TVvr5 WU8C2xSgv/MSASPny24qQK4vvEhvmtoqg9uJHutw10JLR86U+ynRdqjvuQqsBnE/f1qjqdRbiDHKE cjAA7SjtSgVJOPA6OLVGlAaXYbaEJuWG563mUJ4bzhijNCLVtP23qxmGNkaDX3xtcrUc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160099: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=21657ad4f01a634beac570c64c0691e51b9cf366 X-Osstest-Versions-That: xen=b4011741e6b39a8fd0ed5aded96c16c45ead5888 From: osstest service owner Date: Tue, 16 Mar 2021 17:11:38 +0000 flight 160099 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160099/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 21657ad4f01a634beac570c64c0691e51b9cf366 baseline version: xen b4011741e6b39a8fd0ed5aded96c16c45ead5888 Last test of basis 160086 2021-03-15 08:01:27 Z 1 days Testing same since 160099 2021-03-16 15:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b4011741e6..21657ad4f0 21657ad4f01a634beac570c64c0691e51b9cf366 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Mar 16 17:16:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 17:16:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98430.186731 (Exim 4.92) (envelope-from ) id 1lMDJL-0000sZ-3o; Tue, 16 Mar 2021 17:16:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98430.186731; Tue, 16 Mar 2021 17:16:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMDJL-0000sS-0F; Tue, 16 Mar 2021 17:16:51 +0000 Received: by outflank-mailman (input) for mailman id 98430; Tue, 16 Mar 2021 17:16:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMDJK-0000sN-60 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 17:16:50 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown [40.107.22.71]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b0ea7f46-78e9-4d16-9cac-593a4e300526; Tue, 16 Mar 2021 17:16:49 +0000 (UTC) Received: from DB6PR0802CA0036.eurprd08.prod.outlook.com (2603:10a6:4:a3::22) by DBBPR08MB6313.eurprd08.prod.outlook.com (2603:10a6:10:202::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Tue, 16 Mar 2021 17:16:47 +0000 Received: from DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a3:cafe::4) by DB6PR0802CA0036.outlook.office365.com (2603:10a6:4:a3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Tue, 16 Mar 2021 17:16:47 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT056.mail.protection.outlook.com (10.152.21.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Tue, 16 Mar 2021 17:16:47 +0000 Received: ("Tessian outbound 259fb7427a57:v87"); Tue, 16 Mar 2021 17:16:47 +0000 Received: from 9f2d0a9b12f0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D7014543-FA7A-4C27-8A9B-C4CEFFDC0899.1; Tue, 16 Mar 2021 17:16:40 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9f2d0a9b12f0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 16 Mar 2021 17:16:40 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VE1PR08MB4703.eurprd08.prod.outlook.com (2603:10a6:802:b1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Tue, 16 Mar 2021 17:16:36 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3933.032; Tue, 16 Mar 2021 17:16:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0ea7f46-78e9-4d16-9cac-593a4e300526 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FxZQ4dQ4ONBqprdwygfqlLRxjnGYVCv+JAFlVxH/v0Y=; b=oc9TzB+8OOKg6u6ZZ0ZUoVQNWlKLhQ1dLUqDDHv8PDccFUHWGxMlk6EM4fca+Sgmiv8jZreR2Ef1tGGX1vZm7bZix1lOy3pAgsoBT9oJu90eo6+8AvA2R96HHuta7kc0v7EpjMoB+ZnSq9TM04jC0bk7+A8Z+LgQlLvDsHk/E4c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 01ba933043eaa1af X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WqVek89DHntji3CWD/ZCra1wiPwVZKsPWXNcTqL4CCK607R2/N4fq3b4feZxW8NycJW6iMzM7J0QFiYTVgfL9Mex+RFInzJwEXEfgJe/Ti/erk18BQj012JK75yHdEvGQxUfM+dCfRhgQjzCCf9OaDj2DDLxfVntYl8GxXZI4RYsaC0rAnnyC7FUo3brYkXux3dfrfbKifzo6nWiGAGLOmrypGAhNppMgUR8KymxjQ9QCie4TcXjt+UcFRDCz1ByqEnrHPoTJJzDPDXLnmYf81Go5Pvfkwd5tw6s+egpx+LnfixvUOO2IXKmQjZQ37+QwSWCxI8rRmPp8m/jtd6Tuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FxZQ4dQ4ONBqprdwygfqlLRxjnGYVCv+JAFlVxH/v0Y=; b=C4Fb+ap6eZ8vuZtsYlgKvla6qDP7iXAnqZuZHqr77uQaQVB/piQO6enY9HI4vl3ChVy3OiRbBkjTO/s9t9tRUHqu1x/NJWerj1m7LFPWquCw0p7hCKXkA5opJE93apTu+DmFKyezXSNiD6tmXrDNAYUmRT4vh3S9hGRHMWDUYsBQeCxw+W2cob1Pd8Kjj3k2gZ90m6rYW7NATE03fA044mubpOqQKORVjl59Go1xqfUbTITq/cAaDngT7ZkaaHMvVZAjwaQv8llWjfRJ+uxHFfTBeDDc6u+K8eoYil74aQPtwMZs8EzI/uF8OMKRXP2G2WIA4V7fYHBQ+9kohiJLrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FxZQ4dQ4ONBqprdwygfqlLRxjnGYVCv+JAFlVxH/v0Y=; b=oc9TzB+8OOKg6u6ZZ0ZUoVQNWlKLhQ1dLUqDDHv8PDccFUHWGxMlk6EM4fca+Sgmiv8jZreR2Ef1tGGX1vZm7bZix1lOy3pAgsoBT9oJu90eo6+8AvA2R96HHuta7kc0v7EpjMoB+ZnSq9TM04jC0bk7+A8Z+LgQlLvDsHk/E4c= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH for-next v2 0/2] xen/arm: Mitigate straight-line speculation Thread-Topic: [PATCH for-next v2 0/2] xen/arm: Mitigate straight-line speculation Thread-Index: AQHXGCLVbl4hty1bX0WFvkxXr3KxFaqFDwwAgAGybICAAB5+gA== Date: Tue, 16 Mar 2021 17:16:36 +0000 Message-ID: <4066B6A3-2904-4800-B63A-7EAD1EFC7D16@arm.com> References: <20210313160611.18665-1-julien@xen.org> <119bdbc0-5400-87eb-e6ad-87b59ec4e07c@xen.org> In-Reply-To: <119bdbc0-5400-87eb-e6ad-87b59ec4e07c@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.26.33.241] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0f22e1ff-c619-4213-a21c-08d8e89f47b3 x-ms-traffictypediagnostic: VE1PR08MB4703:|DBBPR08MB6313: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: flCxCAhQOsJC4d60fcWrDF9A7HiGLqlECWe0FmD4r8F7A0MWGXUf6Q/OERR/Pxn1zZc26DY7qltHkO7kUdWHQmd/FBkkPhEMX5tLon6FHM1IMWWaxazRhByiZRAufV1R8NIO3+QBBETXgcqaDy7FMwAZb92KWAWFbTHXAACyC0rEE00Uf5De/B60puAh8IRh4d79PYQBFOdG/0jBUcdpbxBdQDaaD/Wek3rn/2yzJ7k1dSw2eugU5xFCo5RS9rYLNRUdhtKWsXeXYixU1EMACKT1lJ657izIM5yUHgppiyc6oHOxnA2JC9WzdbaugmoAOLgQX0SOXGF8EHsXy9b2OgKNNT9CxSSX3chZaSVPealO7vPlZWXzyZFUQxAnk1Y8CsRSTb/t75w30bZayMbdfK656B/RB+1583oqzuQBAotZMgX0AIUVN7ZR6peeOY0MK7xJLfzuttbwtqGsca4CkKAzDBCPtuXkj4BuurQUqzKYIxXsfybXcXqfG96ucTDQyZ0uRH363EJ+O9F1oaRrFfeZfRNLjFkNC7t1b3jpcBwaliCRuLztex+/7Wxhph+Cd7lzA/SuuPuzwzl7gLo8SAkJ8+SKPjznCAs7AewPT4GYGr6H9//v7tRiV7WCwr6Vgq2v12BndzBmg+ClssjiNZNbk9oXYTu8gGVyUPmKmMoEGcLxGzurImE7kR9zvTFxBH+6cNtBvrZxXdeMnESSbP6ES79+7GJ8Uwt+hpBbYaU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(396003)(366004)(136003)(346002)(4326008)(6486002)(2616005)(76116006)(71200400001)(66946007)(36756003)(966005)(6916009)(5660300002)(55236004)(478600001)(66446008)(66556008)(53546011)(316002)(91956017)(6506007)(64756008)(66476007)(54906003)(33656002)(8936002)(2906002)(86362001)(8676002)(83380400001)(6512007)(26005)(186003)(2004002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?aE1BeVRjcGdnVFJLdWtra1o5T2xyV2VNaStKU3B0T2xobGhKTHJnS1Nwa0VH?= =?utf-8?B?UmJlMExuMjBEZVN3S3Zuam5GSk1OV1gwVGdnNTZ0Mmt0Q1NOV1NFSHFpWDJt?= =?utf-8?B?VlNYTkhNbjc5bXFrQXU5akpVN2JYVXNhM1BOdUszTzhjdWhLUjQvMGVMeUNW?= =?utf-8?B?YTF2cWJnWGs0Z2p2NDF0UVRCb0k0VDRJUEtTWDlTcnVtSDRKT0pNSmo1dEpi?= =?utf-8?B?L1RrQlF0N3d6WlZidmdKdUF3R3dSVU9vZU95aGRoeERDYnRNS0VwbTJIUmYz?= =?utf-8?B?YzQwa1p4VU9ZaVZsM2RuNkJnN1diT0trWllLSzZ5dzBxV1M0cVU4aGJjc2FQ?= =?utf-8?B?ZWJxUWZ6Mjl1MHJVSlByK2s4T2VPdDlkUENKeEI0WXNwc3dVRTBqazdRUkds?= =?utf-8?B?ME1yU25mdEpuWTVYUktoRUdmTUEzczdYNit0bFlqMGpDU1hLaTVicnFEMjFn?= =?utf-8?B?K0dmYWxZNUxrSXJTVFl6SkRBemx0OUlTZHpxTE1iUVBsRWdlLzZTcHFWZDRl?= =?utf-8?B?Wm1WV050SHQxZ0FHS2VDOW5hTXR0VkhJMnZoNW5Tb1pLbEQ1RWtZdk40UjVC?= =?utf-8?B?V0Q2WHVYYitOVmJvNFVSbnZHaVhNRXRLMGhGL0lScFZHV2RJcDM5RHdSeW9r?= =?utf-8?B?cmVBVFdmOGJvU3ZvU3RES25waU1NdFJvVEJGL1NucEFJMHZNVll4V1VuVDNl?= =?utf-8?B?ZmdWVFA0QW55SGI5dW5Ec2JQdDdmTVJXaHNQVE5PUzJUZU5sU1M5WmZ5QU4x?= =?utf-8?B?K0tSNGNReGhzQXhKb0ZLT3hpMlFoUDN1VTdZUzZkVW91VWpPWUtOc3dHRzhn?= =?utf-8?B?bEgrT2xsU3FkZHpsdUZuR0d0bzl1ajRyWTE3dm9CcXFYVEdIaVh1TXR4Zmpu?= =?utf-8?B?a3M5dWpIWUpaekY2R3BHRUhkaGNkN1ovaitEUVV5Z3lXWlgySlRGM3paV3p5?= =?utf-8?B?M1FpMlNBekZucExtWlZ5RFJOZytNS1J4cmc0Nmw5Wit6dHpQTnQzQnBvMU00?= =?utf-8?B?SmlEMjgyRW9NazJDdmI1WHlnR1lEZjdiWGhVVXNTL2RPV1hScWp3TldTTW5r?= =?utf-8?B?cTdZTW4wZExTNHpIVHg3Um5LRWg4M3FIWGt1OUlzYnJaWVlSZmc3akJYN0gx?= =?utf-8?B?R0UrZWZoRnluZXg5Mjh5NWZEb1BJbU5VaGZsZVk4ZHVvZE5WcEo2KzhSQ0t6?= =?utf-8?B?UEpHWldQVExiWDJYdVFLNTRvZWtqR2kyQkNRV3djaVBXekhOUjV0aWMxN3FC?= =?utf-8?B?OWdhUGJkZkFacENyTjJ4Y0k4WmJ4RzgrcnpZb0lmSEJNSXNERGNscG1Wek45?= =?utf-8?B?T0xwUDVnKzNheFFGTmMwaDNRWnN5ck9ETWtXdGRZZXc5emtvNVJMMmwzTHdT?= =?utf-8?B?cmxZcjRJa3VkUFNWT1hvSlJUb093NXNHOW1kWkZLMURmNGRBKzJDYmQ1ZFk1?= =?utf-8?B?bm9VT3h4MlNmZ3lNNXZhK3pWcVJ5ZFQ2a0xnaDIvMU1yK0Y2dlRnRVk0azJC?= =?utf-8?B?VnVSUGp6Kys0NGhDNE9lTTdHNU96NVp6a1hrdVFLRzNxSEp5amxRRldFQ3dT?= =?utf-8?B?RnhXUUJ4ejNwQTc2UXlIeU5xeGJNeWlJbFFGYUpJOTFJU0xLTFZ0QTdmWUtR?= =?utf-8?B?VFF0NC9Ubm5ncHBtWVlrWXM1STErSURETVd4eU9WRkNzUzVWSUtmdEd5Znlw?= =?utf-8?B?cEhHaXdhSGZnZmRsMkNJV2d6NVVhaGROaEc5Zm9XRndGd2J6Q3JNVkczMllC?= =?utf-8?Q?ilNzxtxXMNqhfY3IHACD+tiLoWQoyYC304B1ljz?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4703 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 9bdbf9c0-012c-4ae7-42bf-08d8e89f414b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZK6+Q6iXmMFpsLBJu9WukNUhy50x7ipd1NQu697AdhjbJadX/TvLfwQejaBGGaORnkKLxTw9mzoDDP8VfCq5h1xiRu8OCX6n/QIs0TIeE6oSIRexOz/wjFFZM6yM7bM5YZrrESNedUQAZUsslUdV8kCcU7uv7CkjbajpKx9wKDUtPWcYJQ6OPLCjWIpFxQ4wy4SwZO0uDMPKGVgvAqfbP/aEjKRFR4dl+D6Y0Oed10AyRHl/V2sEOegqEGb5rySfWVT8376ytlqc/vCSkIT1x07lxeDzB3P3aFXeyZ/5Xa74pdLwMzbrRmg0S48coMopx9qYerukP8ev0yU4qFfjD5BGAaHkGPGIhruKZ+3zrgD0ZFyhkeUK7QRImB/bkeRYe/Kc45QilTJfsxNL1G6NuGdrZQutCd+Y21je/n9V4OUwtZv71Hx0GDSVafiWVgLMd8amN3jHT484OfptK3zHtBDLC6zD5q0LXKfbNilgFvBf1zirA1TMFtg//h/AZFP4E2MyfEyJ6UKfz2HaW99yWN/YSnXD6TxqXMRvnjA3HPHpGhlK4yqZdzp6aTSCpx0z6n90S9Jxnc6f90FxOeSYATmS+s+hLMvww1wE0dySiWaGC6h8iTmcmlb+u2TDBv171JU2zAfZ26+o7G8wXSYo4JHj1O/XawkfLulK2qx4swTNEa2dVdvXMn3rlZfH38XPl+VlUNkBWGaZ9BFr56urK/ilAiZNdRnRxTRtfanJIysx0/G6OrsA5IV9VV0sj9SY X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(346002)(396003)(376002)(39860400002)(36840700001)(46966006)(107886003)(6862004)(316002)(86362001)(4326008)(82310400003)(6486002)(356005)(36756003)(966005)(8936002)(8676002)(55236004)(336012)(5660300002)(2906002)(6512007)(6506007)(82740400003)(53546011)(81166007)(54906003)(83380400001)(2616005)(47076005)(70586007)(186003)(26005)(36860700001)(70206006)(33656002)(478600001)(2004002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 17:16:47.3244 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f22e1ff-c619-4213-a21c-08d8e89f47b3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6313 SGkgSnVsaWVuLA0KDQo+IE9uIDE2IE1hciAyMDIxLCBhdCAxNToyNywgSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiANCj4gDQo+IE9uIDE1LzAzLzIwMjEgMTM6MzIs IEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+PiBIaSBKdWxpZW4sDQo+IA0KPiBIaSBCZXJ0cmFu ZCwNCj4gDQo+Pj4gT24gMTMgTWFyIDIwMjEsIGF0IDE2OjA2LCBKdWxpZW4gR3JhbGwgPGp1bGll bkB4ZW4ub3JnPiB3cm90ZToNCj4+PiANCj4+PiBGcm9tOiBKdWxpZW4gR3JhbGwgPGpncmFsbEBh bWF6b24uY29tPg0KPj4+IA0KPj4+IEhpIGFsbCwNCj4+PiANCj4+PiBMYXN0IHllYXIsIEFybSBy ZWxlYXNlZCBhIHdoaXRlcGFwZXIgYWJvdXQgYSBuZXcgY2F0ZWdvcnkgb2Ygc3BlY3VsYXRpb24u DQo+Pj4gKHNlZSBbMV0gYW5kIFsyXSkuIEluIHNob3J0LCBhIHByb2Nlc3NvciBtYXkgYmUgYWJs ZSB0byBzcGVjdWxhdGUgcGFzdA0KPj4+IHNvbWUgb2YgdGhlIHVuY29uZGl0aW9uYWwgY29udHJv bCBmbG93IGluc3RydWN0aW9ucyAoZS5nIGVyZXQsIHNtYywgYnIpLg0KPj4+IA0KPj4+IEluIHNv bWUgb2YgdGhlIGNhc2VzLCB0aGUgcmVnaXN0ZXJzIHdpbGwgY29udGFpbiB2YWx1ZXMgY29udHJv bGxlZCBieQ0KPj4+IHRoZSBndWVzdC4gV2hpbGUgdGhlcmUgaXMgbm8ga25vd24gZ2FkZ2V0IGFm dGVyd2FyZHMsIHdlIHN0aWxsIHdhbnQgdG8NCj4+PiBwcmV2ZW50IGFueSBsZWFrYWdlIGluIHRo ZSBmdXR1cmUuDQo+Pj4gDQo+Pj4gVGhlIG1pdGlnYXRpb24gaXMgcGxhbm5lZCBpbiB0d28gcGFy dHM6DQo+Pj4gICAxKSBBcm0gcHJvdmlkZWQgcGF0Y2hlcyBmb3IgYm90aCBHQ0MgYW5kIExMVk0g dG8gYWRkIHNwZWN1bGF0aW9uIGJhcnJpZXINCj4+PiAgIGFuZCByZW1vdmUgcHJvYmxlbWF0aWMg Y29kZSBzZXF1ZW5jZS4NCj4+PiAgIDIpIEluc3BlY3Rpb24gb2YgYXNzZW1ibHkgY29kZSBhbmQg Y2FsbCB0byBoaWdoZXIgbGV2ZWwgKGUuZyBzbWMgaW4gb3VyIGNhc2UpLg0KPj4+IA0KPj4+IEkg c3RpbGwgaGF2ZW4ndCBsb29rZWQgYXQgMSkgYW5kIGhvdyB0byBtaXRpZ2F0ZSBwcm9wZXJseSBB cm0zMiAoc2VlDQo+Pj4gcGF0Y2ggIzEpIGFuZCBTTUMgY2FsbC4gU28gdGhpcyBpc3N1ZSBpcyBu b3QgZnVsbHkgYWRkcmVzc2VkLg0KPj4+IA0KPj4+IE5vdGUgdGhhdCB0aGUgRVJFVCBpbnN0cnVj dGlvbiB3YXMgYWxyZWFkeSBhZGRyZXNzZWQgYXMgcGFydCBvZiBYU0EtMzEyLg0KPj4gT24gbXkg dGVzdHMsIHRoaXMgc2VyaWUgaXMgYnJlYWtpbmcgdGhlIGFybTY0IGJ1aWxkOg0KPj4gfCBhYXJj aDY0LXBva3ktbGludXgtbGQgLS1zeXNyb290PS9ob21lL2Jlcm1hcjAxL0RldmVsb3BtZW50L3hl bi1kZXYvYnVpbGQvcHJvZmlsZS1mdnAtYmFzZS5wcmovdG1wL3dvcmsvZnZwX2Jhc2UtcG9reS1s aW51eC94ZW4vNC4xNStnaXQxLXIwL3JlY2lwZS1zeXNyb290ICAgICAgICAgLUVMICAtLWZpeC1j b3J0ZXgtYTUzLTg0MzQxOSAtLWZpeC1jb3J0ZXgtYTUzLTg0MzQxOSAtciAtbyBidWlsdF9pbi5v IG1lbWNweS5vIG1lbWNtcC5vIG1lbW1vdmUubyBtZW1zZXQubyBtZW1jaHIubyBjbGVhcl9wYWdl Lm8gYml0b3BzLm8gZmluZF9uZXh0X2JpdC5vIHN0cmNoci5vIHN0cmNtcC5vIHN0cmxlbi5vIHN0 cm5jbXAubyBzdHJubGVuLm8gc3RycmNoci5vDQo+IA0KPiBJIGNhbid0IHNlZSBhbnkgYnVpbGQg ZmFpbHVyZSB3aXRoIHRoZSBmb2xsb3dpbmcgR0NDOg0KPiANCj4gNDJzaD4gYWFyY2g2NC1saW51 eC1nbnUtZ2NjDQo+IGFhcmNoNjQtbGludXgtZ251LWdjYyAoVWJ1bnR1L0xpbmFybyA3LjUuMC0z dWJ1bnR1MX4xOC4wNCkgNy41LjANCj4gQ29weXJpZ2h0IChDKSAyMDE3IEZyZWUgU29mdHdhcmUg Rm91bmRhdGlvbiwgSW5jLg0KPiBUaGlzIGlzIGZyZWUgc29mdHdhcmU7IHNlZSB0aGUgc291cmNl IGZvciBjb3B5aW5nIGNvbmRpdGlvbnMuICBUaGVyZSBpcyBOTw0KPiB3YXJyYW50eTsgbm90IGV2 ZW4gZm9yIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9T RS4NCj4gDQo+IEFGQUlDVCwgdGhlcmUgaXMgYWxzbyBubyBjb21waWxhdGlvbiBpc3N1ZSByZXBv cnRlZCBieSBnaXRsYWI6DQo+IA0KPiBodHRwczovL2dpdGxhYi5jb20veGVuLXByb2plY3QvcGF0 Y2hldy94ZW4vLS9waXBlbGluZXMvMjY5OTg5ODk0DQo+IA0KPiBXaGF0J3MgdGhlIHZlcnNpb24g b2YgeW91ciBjb21waWxlcj8gRG8geW91IGhhdmUgc3RlcHMgdG8gcmVwcm9kdWNlIHlvdXIgc2V0 dXA/DQoNCllvdSBuZWVkIHRvIGhhdmUgZWFybHlwcmludGsgZW5hYmxlZA0KSSBhbSB1c2luZyBn Y2MgNy41LjA6DQphYXJjaDY0LWxpbnV4LWdudS1nY2MgKFVidW50dS9MaW5hcm8gNy41LjAtM3Vi dW50dTF+MTguMDQpIDcuNS4wDQoNCm9uZSBjb25maWd1cmF0aW9uIHRyaWdnZXJpbmcgdGhlIGlz c3VlIGlzIHVzaW5nIHRoZSBkZWZhdWx0IC5jb25maWcgd2l0aCB0aGUgZm9sbG93aW5nIGl0ZW1z IGFkZGVkOg0KQ09ORklHX1NVUFBSRVNTX0RVUExJQ0FURV9TWU1CT0xfV0FSTklOR1M9eQ0KQ09O RklHX0RFQlVHX0xPQ0tfUFJPRklMRT15DQpDT05GSUdfUEVSRl9DT1VOVEVSUz15DQpDT05GSUdf UEVSRl9BUlJBWVM9eQ0KQ09ORklHX0RFVklDRV9UUkVFX0RFQlVHPXkNCkNPTkZJR19ERUJVR19U UkFDRT15DQpDT05GSUdfRUFSTFlfUFJJTlRLX0pVTk89eQ0KQ09ORklHX0VBUkxZX1VBUlRfUEww MTE9eQ0KQ09ORklHX0VBUkxZX1BSSU5USz15DQpDT05GSUdfRUFSTFlfVUFSVF9CQVNFX0FERFJF U1M9MHg3ZmY4MDAwMA0KQ09ORklHX0VBUkxZX1VBUlRfUEwwMTFfQkFVRF9SQVRFPTExNTIwMA0K Q09ORklHX0VBUkxZX1VBUlRfSU5JVD15DQpDT05GSUdfRUFSTFlfUFJJTlRLX0lOQz0iZGVidWct cGwwMTEuaW5j4oCdDQoNCj4gDQo+PiB8IGFybTY0L2hlYWQuUzogQXNzZW1ibGVyIG1lc3NhZ2Vz Og0KPj4gfCBhcm02NC9oZWFkLlM6MzA1OiBFcnJvcjogdW5rbm93biBtbmVtb25pYyBgcm9kYXRh X3N0cicgLS0gYHJvZGF0YV9zdHIoOTgsICItIEJvb3QgQ1BVIGJvb3RpbmcgLVxyXG4iKScNCj4g DQo+IFRoaXMgaXMgc3RyYW5nZSwgdGhlIGNvZGUgc2hvdWxkIHVzZSBST0RBVEFfU1RSKCkgYnV0 IGhlcmUgaXQgaXMgaW4gbG93ZXIgY2FzZS4gQ2FuIHlvdSBjaGVjayBpbiB5b3VyIHRyZWUgd2hl dGhlciB0aGVyZSBzb21lIGluc3RhbmNlIG9mIHRoZSBsb3dlciBjYXNlIHZlcnNpb24/DQoNCkkg aGF2ZSBubyBpbnN0YW5jZSBvZiByb2RhdGFfc3RyIGluIGxvd2VyIGNhc2UuDQoNCj4gDQo+IElm IG5vdCwgdGhpcyBtYXkganVzdCBiZSBHQVMgcHJpbnRpbmcgaW4gbG93ZXIgY2FzZXMuDQoNCml0 IHByb2JhYmx5IGlzIHRoZW4uDQoNCklmIHlvdSBuZWVkIGhlbHAgb24gdGhpcyBpIGNhbiB0cnkg dG8gZGlnIG9uIHRoYXQgYSBiaXQgbGF0ZXIgdGhpcyB3ZWVrICh0aHVyc2RheSBvciBmcmlkYXkp Lg0KDQpDaGVlcnMNCkJlcnRyYW5kDQoNCj4gDQo+PiB8IGFybTY0L2hlYWQuUzozMzE6IEVycm9y OiB1bmtub3duIG1uZW1vbmljIGByb2RhdGFfc3RyJyAtLSBgcm9kYXRhX3N0cig5OCwgIi0gUmVh ZHkgLVxyXG4iKScNCj4+IHwgYXJtNjQvaGVhZC5TOjM2NTogRXJyb3I6IHVua25vd24gbW5lbW9u aWMgYHJvZGF0YV9zdHInIC0tIGByb2RhdGFfc3RyKDk4LCAiLSBDUFUgIiknDQo+PiB8IG1ha2Vb Nl06IExlYXZpbmcgZGlyZWN0b3J5ICcvaG9tZS9iZXJtYXIwMS9EZXZlbG9wbWVudC94ZW4tZGV2 L2J1aWxkL3Byb2ZpbGUtZnZwLWJhc2UucHJqL3RtcC93b3JrL2Z2cF9iYXNlLXBva3ktbGludXgv eGVuLzQuMTUrZ2l0MS1yMC9sb2NhbC14ZW4veGVuL3hlbi9hcmNoL2FybS9hcm02NC9saWInDQo+ PiB8IGFybTY0L2hlYWQuUzozNjc6IEVycm9yOiB1bmtub3duIG1uZW1vbmljIGByb2RhdGFfc3Ry JyAtLSBgcm9kYXRhX3N0cig5OCwgIiBib290aW5nIC1cclxuIiknDQo+PiB8IGFybTY0L2hlYWQu UzozOTg6IEVycm9yOiB1bmtub3duIG1uZW1vbmljIGByb2RhdGFfc3RyJyAtLSBgcm9kYXRhX3N0 cig5OCwgIi0gUmVhZHkgLVxyXG4iKScNCj4+IHwgYXJtNjQvaGVhZC5TOjQxMjogRXJyb3I6IHVu a25vd24gbW5lbW9uaWMgYHJvZGF0YV9zdHInIC0tIGByb2RhdGFfc3RyKDk4LCAiLSBDdXJyZW50 IEVMICIpJw0KPj4gfCBhcm02NC9oZWFkLlM6NDE1OiBFcnJvcjogdW5rbm93biBtbmVtb25pYyBg cm9kYXRhX3N0cicgLS0gYHJvZGF0YV9zdHIoOTgsICIgLVxyXG4iKScNCj4+IHwgYXJtNjQvaGVh ZC5TOjQyNDogRXJyb3I6IHVua25vd24gbW5lbW9uaWMgYHJvZGF0YV9zdHInIC0tIGByb2RhdGFf c3RyKDk4LCAiLSBYZW4gbXVzdCBiZSBlbnRlcmVkIGluIE5TIEVMMiBtb2RlIC1cclxuIiknDQo+ PiB8IGFybTY0L2hlYWQuUzo0MjU6IEVycm9yOiB1bmtub3duIG1uZW1vbmljIGByb2RhdGFfc3Ry JyAtLSBgcm9kYXRhX3N0cig5OCwgIi0gUGxlYXNlIHVwZGF0ZSB0aGUgYm9vdGxvYWRlciAtXHJc biIpJw0KPj4gfCBhcm02NC9oZWFkLlM6NDQxOiBFcnJvcjogdW5rbm93biBtbmVtb25pYyBgcm9k YXRhX3N0cicgLS0gYHJvZGF0YV9zdHIoOTgsICItIFplcm8gQlNTIC1cclxuIiknDQo+PiB8IGFy bTY0L2hlYWQuUzo0NTk6IEVycm9yOiB1bmtub3duIG1uZW1vbmljIGByb2RhdGFfc3RyJyAtLSBg cm9kYXRhX3N0cig5OCwgIi0gSW5pdGlhbGl6ZSBDUFUgLVxyXG4iKScNCj4+IHwgYXJtNjQvaGVh ZC5TOjY1NDogRXJyb3I6IHVua25vd24gbW5lbW9uaWMgYHJvZGF0YV9zdHInIC0tIGByb2RhdGFf c3RyKDk4LCAiLSBVbmFibGUgdG8gYnVpbGQgYm9vdCBwYWdlIHRhYmxlcyAtIHZpcnQgYW5kIHBo eXMgYWRkcmVzc2VzIGNsYXNoLiAtXHJcbiIpJw0KPj4gfCBhcm02NC9oZWFkLlM6NjY2OiBFcnJv cjogdW5rbm93biBtbmVtb25pYyBgcm9kYXRhX3N0cicgLS0gYHJvZGF0YV9zdHIoOTgsICItIFR1 cm5pbmcgb24gcGFnaW5nIC1cclxuIiknDQo+PiB8IGFybTY0L2hlYWQuUzo4MDA6IEVycm9yOiB1 bmtub3duIG1uZW1vbmljIGByb2RhdGFfc3RyJyAtLSBgcm9kYXRhX3N0cig5OCwgIi0gQm9vdCBm YWlsZWQgLVxyXG4iKScNCj4+IHwgYXJtNjQvaGVhZC5TOjg0ODogRXJyb3I6IHVua25vd24gbW5l bW9uaWMgYHJvZGF0YV9zdHInIC0tIGByb2RhdGFfc3RyKDk4LCAiLSBVQVJUIGVuYWJsZWQgLVxy XG4iKScNCj4+IHwge3N0YW5kYXJkIGlucHV0fTogRXJyb3I6IGxvY2FsIGxhYmVsIGAiOTgiIChp bnN0YW5jZSBudW1iZXIgMSBvZiBhIGZiIGxhYmVsKScgaXMgbm90IGRlZmluZWQNCj4+IHwgL2hv bWUvYmVybWFyMDEvRGV2ZWxvcG1lbnQveGVuLWRldi9idWlsZC9wcm9maWxlLWZ2cC1iYXNlLnBy ai90bXAvd29yay9mdnBfYmFzZS1wb2t5LWxpbnV4L3hlbi80LjE1K2dpdDEtcjAvbG9jYWwteGVu L3hlbi94ZW4vUnVsZXMubWs6MjA0OiByZWNpcGUgZm9yIHRhcmdldCAnYXJtNjQvaGVhZC5vJyBm YWlsZWQNCj4+IFRoaXMgd2FzIGRvbmUgYWRkaW5nIHlvdXIgMiBwYXRjaGVzIG9uIHRvcCBvZiBj dXJyZW50IHN0YWdpbmcuDQo+PiBDaGVlcnMNCj4+IEJlcnRyYW5kDQo+Pj4gDQo+Pj4gQ2hlZXJz LA0KPj4+IA0KPj4+IFsxXSBodHRwczovL2RldmVsb3Blci5hcm0uY29tL3N1cHBvcnQvYXJtLXNl Y3VyaXR5LXVwZGF0ZXMvc3BlY3VsYXRpdmUtcHJvY2Vzc29yLXZ1bG5lcmFiaWxpdHkNCj4+PiBb Ml0gaHR0cHM6Ly9kZXZlbG9wZXIuYXJtLmNvbS9zdXBwb3J0L2FybS1zZWN1cml0eS11cGRhdGVz L3NwZWN1bGF0aXZlLXByb2Nlc3Nvci12dWxuZXJhYmlsaXR5L2Rvd25sb2Fkcy9zdHJhaWdodC1s aW5lLXNwZWN1bGF0aW9uDQo+Pj4gDQo+Pj4gSnVsaWVuIEdyYWxsICgyKToNCj4+PiAgeGVuL2Fy bTogSW5jbHVkZSBhc20vYXNtLW9mZnNldHMuaCBhbmQgYXNtL21hY3Jvcy5oIG9uIGV2ZXJ5IGFz c2VtYmx5DQo+Pj4gICAgZmlsZXMNCj4+PiAgeGVuL2FybTY0OiBQbGFjZSBhIHNwZWN1bGF0aW9u IGJhcnJpZXIgZm9sbG93aW5nIGFuIHJldCBpbnN0cnVjdGlvbg0KPj4+IA0KPj4+IHhlbi9hcmNo L2FybS9NYWtlZmlsZSAgICAgICAgICAgICAgICB8ICAyICstDQo+Pj4geGVuL2FyY2gvYXJtL2Fy bTMyL2VudHJ5LlMgICAgICAgICAgIHwgIDIgKy0NCj4+PiB4ZW4vYXJjaC9hcm0vYXJtMzIvaGVh ZC5TICAgICAgICAgICAgfCAgMSAtDQo+Pj4geGVuL2FyY2gvYXJtL2FybTMyL2xpYi9saWIxZnVu Y3MuUyAgIHwgIDEgKw0KPj4+IHhlbi9hcmNoL2FybS9hcm0zMi9wcm9jLXY3LlMgICAgICAgICB8 ICAxIC0NCj4+PiB4ZW4vYXJjaC9hcm0vYXJtNjQvZGVidWctY2FkZW5jZS5pbmMgfCAgMSAtDQo+ Pj4geGVuL2FyY2gvYXJtL2FybTY0L2RlYnVnLXBsMDExLmluYyAgIHwgIDIgLS0NCj4+PiB4ZW4v YXJjaC9hcm0vYXJtNjQvZW50cnkuUyAgICAgICAgICAgfCAgMiAtLQ0KPj4+IHhlbi9hcmNoL2Fy bS9hcm02NC9oZWFkLlMgICAgICAgICAgICB8ICAyIC0tDQo+Pj4geGVuL2FyY2gvYXJtL2FybTY0 L3NtYy5TICAgICAgICAgICAgIHwgIDMgLS0tDQo+Pj4geGVuL2luY2x1ZGUvYXNtLWFybS9hcm02 NC9tYWNyb3MuaCAgIHwgIDYgKysrKysrDQo+Pj4geGVuL2luY2x1ZGUvYXNtLWFybS9jb25maWcu aCAgICAgICAgIHwgIDYgKysrKysrDQo+Pj4geGVuL2luY2x1ZGUvYXNtLWFybS9tYWNyb3MuaCAg ICAgICAgIHwgMTggKysrKysrKysrLS0tLS0tLS0tDQo+Pj4gMTMgZmlsZXMgY2hhbmdlZCwgMjQg aW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pDQo+Pj4gDQo+Pj4gLS0gDQo+Pj4gMi4xNy4x DQo+Pj4gDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Tue Mar 16 17:46:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 17:46:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98437.186742 (Exim 4.92) (envelope-from ) id 1lMDlR-0003dG-I2; Tue, 16 Mar 2021 17:45:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98437.186742; Tue, 16 Mar 2021 17:45:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMDlR-0003d9-F0; Tue, 16 Mar 2021 17:45:53 +0000 Received: by outflank-mailman (input) for mailman id 98437; Tue, 16 Mar 2021 17:45:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMDlP-0003d4-I0 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 17:45:51 +0000 Received: from aserp2130.oracle.com (unknown [141.146.126.79]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4c7ab7e7-f53c-474c-b779-2907a01faf20; Tue, 16 Mar 2021 17:45:49 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12GHdpmA165634; Tue, 16 Mar 2021 17:45:47 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 378jwbh7tv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Mar 2021 17:45:47 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12GHjjl2188302; Tue, 16 Mar 2021 17:45:47 GMT Received: from nam04-sn1-obe.outbound.protection.outlook.com (mail-sn1nam04lp2051.outbound.protection.outlook.com [104.47.44.51]) by aserp3020.oracle.com with ESMTP id 3797a1h1tm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Mar 2021 17:45:46 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by SJ0PR10MB4414.namprd10.prod.outlook.com (2603:10b6:a03:2d0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Tue, 16 Mar 2021 17:45:43 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3933.032; Tue, 16 Mar 2021 17:45:43 +0000 Received: from [192.168.1.195] (73.249.50.119) by BY5PR04CA0011.namprd04.prod.outlook.com (2603:10b6:a03:1d0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Tue, 16 Mar 2021 17:45:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c7ab7e7-f53c-474c-b779-2907a01faf20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=kcpvcCoIM0xxonXgBrVXpFNy89LYrWOFkQnLx/8LnYY=; b=mFiLTGQwCfC90A0sYrKhP+Ji0Zxaxosz8Ak5XIovzYwOj9fnCYKJ5pADbzK5e0trhwIx KzgH3wbeC0Sh6ErO1mCX7aunheMQagFk/WxYVU/Vp5c3dypv4YITN7zWdxhcsaeVtwk8 3KNENqIesLeW2uuBZ9wVFHioF/lksPzCb+HWigFpF3uincN9b0EBCeC1GDuzPJlvs2lm Rvph53V7bafvN8roOCksXnIC3I9S6VKb8iHkYqDY1ptJFGmvcY4F+yE8mSFJu9K7sz58 OGy80WZ5vuH1xdV9nThRuXk2dc+gw2uOha8C6M9uFo/HrJfIM6UhkXzictWwIHkJPCI6 Dg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ld5zoZrI/3qZRp9VTkWngQxfmtVOMgTqsttXAyGgLPyfX/0+znnA++fq9t50REEGotvXr/5mwSysQTeS6TqRT/A+SYfyED3Da9Yaz0HQkJx3o2YAa7wpgddzsnw9RZ5/MGyJFRtAoSBBeR+qg9HJmAZnYE4SFTXfr7q+TokP2ZaQ5fSENO0C4Jle+nqg8nG8L9B/cxS3Yg60y6si76vS4Qq2n5RNf2JT5M5ZVF3Eerotqt97Qup7+qiewi2MpoBn0E53lulr9YN+smjg1cMpb7GldqPq2fDf+gMbUN4pkYN4mU2NRyQ4Z76AI8oYXXwE6VmPJlNBuYT5T8uTvHa8lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kcpvcCoIM0xxonXgBrVXpFNy89LYrWOFkQnLx/8LnYY=; b=FEQjg5vRj6Ny9ex8DQeFdfW2Uqe52sI6St9Dpc8xqEjqMWC3dUyvtM/RasqeI3QQadVtZ6rwhpgielVIZF2QvaFaa6KavduIis6DP5Hvxuetb655F0Kwt6C4DgIcOc53KY8XChJiUGIVtZmmw9osSMCd4tXwC64CRrJWEfFBnwgevTCV02Sysr4t6Kp/kYr4IK7ICni0RcqCI6TNRA9H9Oun+ISywo1aIdNARlJNbn2bQahZ6W1Ec82keWICHF/QLya/ljgWAy4ZmqdAF7ycDWmrRZd5V5r8/uQN5Wn9WZCdq+EJrv7xdvWvyMaUJFE5cbPntrguFE320103mHYi9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kcpvcCoIM0xxonXgBrVXpFNy89LYrWOFkQnLx/8LnYY=; b=D9ZOtlW+T8TCCbJaTSwgmmwbWvKqpstU0haxiWFgMwFjNrfP3KVHekebfxgXS4ajs8Zrj0iYqrNi6CRQ/mJgF4r7JKO06DOScVhSk9apG+9Vxvi4dhiY+fjPHxqvOl4oU7kpUo2k9orqFw3frHkhtg7m1qRH4YkNr5CwU1GPJYw= Authentication-Results: xenproject.org; dkim=none (message not signed) header.d=none;xenproject.org; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH 3/3] x86/msr: Fix Solaris and turbostat following XSA-351 To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper Cc: Xen-devel , Jan Beulich , Wei Liu , Ian Jackson References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-4-andrew.cooper3@citrix.com> From: Boris Ostrovsky Message-ID: Date: Tue, 16 Mar 2021 13:45:40 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [73.249.50.119] X-ClientProxiedBy: BY5PR04CA0011.namprd04.prod.outlook.com (2603:10b6:a03:1d0::21) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bae24770-f2f2-4234-0420-08d8e8a35251 X-MS-TrafficTypeDiagnostic: SJ0PR10MB4414: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EmGCu8fxM/seEEEUdNlZi5A9guPCR74NTJHuEqmYG1DVjWgaIuq1l3f8Lf9vlBdYhkPVt/qRONmeoiTpUR7pgSThTbUBBcsqJhFS1A9Ep6tPYTjiTRPgFIFCY1xayWtE/AYDv/4oE4AAD72O5OTB3ZYSRNJY35lmM229sCYJltJIASagpJtCw6s/EPLHZOOh112LJLdHMPZTSZrS2EDgYSnfh/TDN50CJDvmMMhIAiA+3IzHFPuzliEuKhVZR+9SfILZzR6GVQLIrDC27ugDUVUS+z10Rf2NmQp7P2jHNzhi+s08ROawBcHqTVMqpx9QNt/eEKHtHk8tHnY2JyqDJYXLbEUxS4fQIzBD6JZw19l3LQl0SFES0vHByEwsj8jE+wfOLgn4KcZm9yTcRYyY+QJlDnFEi73ayHB1CDmOsl0jD3wSaxfyhwfTYcEUpy7eEhOJssZu0Q9anBFqGC2EIicIgFH0jBTHglk9FK/AW66Ydt93fKnXR/eKIy3f86dXlreW1UVFOnuNM2guke8Ea8McVYJDzNnVx2oY3nUr20nRq0kvRI+e8yXzc7OAEtuxiQ6IpbuigMqsIZlQog7+fuaWr8VBDjiChf5ltFWExFMwspQMwwKDpOH/q6Aq53WBFhwbFaJMNO2R7kaadKkk1w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(376002)(136003)(366004)(396003)(39860400002)(316002)(558084003)(16576012)(2906002)(8676002)(110136005)(8936002)(956004)(83380400001)(4326008)(2616005)(54906003)(478600001)(31686004)(31696002)(44832011)(86362001)(53546011)(186003)(66946007)(66476007)(36756003)(26005)(66556008)(16526019)(6486002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?M3BMcEhWampDd29vUFlxc016S204MENaU2J2NFdWaXdlc01nK1RiSFdMemFw?= =?utf-8?B?bysxclNaRTM4ak1neTFmYkx0c3FhYy9JaUJvTFZQV3VZUnA5Uk5KTERLR2ds?= =?utf-8?B?VEtrd2Y1ditjVTN0cFkzWVU3cXJUQlJzV29lS0JSRktFODlQMzMxYzhLN2E5?= =?utf-8?B?N0c3ckhrTUhic2d1eHVjbjJyNzBobGZ4R2Joc25pYVYxV3ErT2NLbWtaZjNF?= =?utf-8?B?enU5Z3lSSUU1THJnVVhncCtvRWRza1d6bDZNQm93SlV2UHVmdzdCQnlLcGlp?= =?utf-8?B?R3dnN1c0VExhM29sODNKMU5KdGpZYWZ2b0ZUcUZNdEI0aW1JMmhkN2JEVjNi?= =?utf-8?B?MklINjRaV2pwME56QWROT1ZRY3lXT3N5UHNWZEthL2dTZ1AxU0lkeXFLZXN2?= =?utf-8?B?QlloMHJFczNnYzRFWEl4RUs4d0h2TGpvbVNDY003RlBDQTJ2THBpQ3B0ZE1v?= =?utf-8?B?ZVUxSS9uM0MrcFRmYkFIb2x5VFYzbHkrZGkxRGtUejVQVFcvV2ozL1BuT2Vk?= =?utf-8?B?OFV1dmVyM1ZmZkpoUWZNNUl1bzI5RCs2NEFmWlAxcklod2pNelRaMG1WeWx6?= =?utf-8?B?NHo4b25XaXRKU1RIUUVINllDYm5Rd2xCaUorb2xlN1AweG45NU1ITm5VMzJJ?= =?utf-8?B?L1dOWm1SNGVTNG5hNENYL3kyQnV5bEZGdU4rTXNWbHJlWlhQWkFQOEgzSzFT?= =?utf-8?B?MERXS052UnlSZythMml3bFdOL3RJajZETFlsV3k0ZUJ1d2o3NWd4RVhSUUo1?= =?utf-8?B?WmNIWGZQc0FEY2EranpvVG5NRDdNc2c1dGZLV29nOFBEUnNyTURJNysyZ3Nw?= =?utf-8?B?K0VzYWlTSm9xZXhrUkFsdUV2eTM1ZkxTTG9yS0lLVXFwUmlnVHVnVENIUFBK?= =?utf-8?B?RkpVaVlyNmhxR09KaWRoUTU3Q0V0cm5MRjFPZmVFbFAxc045aTRVaGo2cmMx?= =?utf-8?B?UEZVdlN1bG5tSTBQRUhQcTU1TDZxZG4xTDlHL0wvOWYvY2ZNWXNIMWgvRWxC?= =?utf-8?B?eFA5SS9rcmdGMEFOaHRMMWtPbXpsTlZsMVdJcjg3NWYzaWpPdjZvQk1sOXFW?= =?utf-8?B?SDM5TCs1T3h2eHlqU2VqYXZKY1ZaNkxLV25HS2tsa2hzMUxjTzIwM1JFeVZk?= =?utf-8?B?OWJ1cFJNejVUd3hGME5uYnQvRHdPTllWc1hnMUdIV3VybFRXVG5HcXFIdUNi?= =?utf-8?B?NG9nK2FFMUZxSmtSZHNJMStWcUZDTVNtQnRsTjF5Y0owZHlQeFhCM2txVUtl?= =?utf-8?B?a2Z5U0tnQmwyb0RFL09nQXl4SHY1dCs2aEJSUnFFY2ZIcjV2THkxc2RKZE5S?= =?utf-8?B?Uzh2eDc3aUtDRlFscTdpSUxkalZLSEVkc0I2RTU0QzI2SlJyOVhCUEN5QlNT?= =?utf-8?B?NnVjZWZ6a3hxNjlxSzVCUnRaWEZmb0pDYzJoa1E4NmF2UXVPanUveURNOVFY?= =?utf-8?B?TTFlczRCMDFkaitjd09obUszdFFSb3hxUkxPZUFvM0lJTWlWMWlra2pBUkQ2?= =?utf-8?B?UkF6YjFuYUVMa3BSQnQ0Uy9sVVdLeDNBcFZBbVdVZVYzdzBHNjdWR0w0dGFH?= =?utf-8?B?Z1BlamkvN1hJTit3M2JoS1dwK29ZRTl1TldUd3pIVStMYk9zaGdpc2pCM2Rq?= =?utf-8?B?NjRCRTlMK29HZUhsQnZIYWdoanJscWxVZ2V4NHkyK0lzUUVKNjI1RjVPK0xG?= =?utf-8?B?SmR3cWlhQWR1eGVpVUkzajQ3c1ZPV3VTZHNvWnE4ZHdUeXNxbDRxcnh4SEJK?= =?utf-8?Q?PlSzE7VEI3DrDDiX6JUUfijpc/K6ssU8jdOwGBw?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: bae24770-f2f2-4234-0420-08d8e8a35251 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 17:45:43.2349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cK8mWqnazvvZ9sAYwdTrJ3pKNmqjevYQFUXv38btKVxYq1rG0ptArew6W9Ega2arTE/7QSDaVKNVhbiQvRCOPjN7QwIM700JGSXpgwLTXSw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4414 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103160113 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 adultscore=0 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103160112 On 3/16/21 12:56 PM, Roger Pau Monné wrote: > > Do we also need to care about MSR_AMD_RAPL_POWER_UNIT (0xc0010299) for > Solaris? I can't test it but I don't believe Solaris accesses this register. -boris From xen-devel-bounces@lists.xenproject.org Tue Mar 16 17:54:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 17:54:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98441.186755 (Exim 4.92) (envelope-from ) id 1lMDtj-0004aI-Dv; Tue, 16 Mar 2021 17:54:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98441.186755; Tue, 16 Mar 2021 17:54:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMDtj-0004aB-An; Tue, 16 Mar 2021 17:54:27 +0000 Received: by outflank-mailman (input) for mailman id 98441; Tue, 16 Mar 2021 17:54:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMDth-0004a6-L6 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 17:54:25 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (unknown [40.107.1.50]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 82565abf-1c4c-400d-90b3-75cf495dad40; Tue, 16 Mar 2021 17:54:23 +0000 (UTC) Received: from AS8PR04CA0130.eurprd04.prod.outlook.com (2603:10a6:20b:127::15) by HE1PR08MB2828.eurprd08.prod.outlook.com (2603:10a6:7:2e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Tue, 16 Mar 2021 17:54:19 +0000 Received: from AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:127:cafe::d8) by AS8PR04CA0130.outlook.office365.com (2603:10a6:20b:127::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Tue, 16 Mar 2021 17:54:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT003.mail.protection.outlook.com (10.152.16.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.30 via Frontend Transport; Tue, 16 Mar 2021 17:54:18 +0000 Received: ("Tessian outbound de94f9ae513a:v87"); Tue, 16 Mar 2021 17:54:17 +0000 Received: from e9fc613119e8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C9305DE4-AD30-4604-ADE4-F2C89B67A15D.1; Tue, 16 Mar 2021 17:54:11 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e9fc613119e8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 16 Mar 2021 17:54:11 +0000 Received: from DB7PR08MB3500.eurprd08.prod.outlook.com (2603:10a6:10:49::10) by DBAPR08MB5654.eurprd08.prod.outlook.com (2603:10a6:10:1a6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Tue, 16 Mar 2021 17:54:09 +0000 Received: from DB7PR08MB3500.eurprd08.prod.outlook.com ([fe80::5959:35df:3647:b78d]) by DB7PR08MB3500.eurprd08.prod.outlook.com ([fe80::5959:35df:3647:b78d%7]) with mapi id 15.20.3933.032; Tue, 16 Mar 2021 17:54:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82565abf-1c4c-400d-90b3-75cf495dad40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l+MBN7cKfFPeJ9kNJiqi4ei7+ENVT3/uLQGPG91NxQ0=; b=RS8nyvMeQSfNV/05PO4hAeDbXDUgV0getXO3GtMehHYO9Nl2y8ZOVjClZcqvbh5jCOaqMzktVc2fBla1thGUV2eIqsrnHcxMtUugggtTRYGrN274AArvfqgHrsXArb+u2Ogi4BtNeJ4S8vTIt6ycEXb8CkWriKSQlY2iey+kC18= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: d80dd835a00bab58 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iTx4Qoh+CPi4DewnDYaWTDUocXpYamXqtHidmVy3zHi5AkJA4mnB6ZY7gyotRpRpvCE/8YFt3M+mLtmUbiWT1yOtMnBODvTIilL+6GMO5aeFmyswjfnjhP576OECnTQpA+QVDXJiLvc9+5l8vIOb3DLziU2toZd0gItTMtcS9P8BccV8b+y0Jgn8m3k08RRUD5rvcD+8TG68Iq6i36/3pP7sjEmDImVkc6XW+ulXNtJnu5X8f5frdrU2zAziqHDDYpAZ1WrC2K8HbHIijG72rze29YO3iRL9PTpQ2oeDTtLywzoMrfFy9xkayMBpYzXv/IGdSncd7RYJTlYJtvFp7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l+MBN7cKfFPeJ9kNJiqi4ei7+ENVT3/uLQGPG91NxQ0=; b=BBNlSWCHALzvk6+vcK3pYM5cyRZNSWSyxW6JXqRf8GvCRr6Lor/Gkp/Vf5Vr8timdhE+fXsk6NblANnGuyDq1Sbo9Mn3Ynr8TERDH15zA+NaEcyXz3gpBtaCoLt/rImmiFcB575I2OhfJgwZv19LGu66WE8clGoxzUjJgM3zbjymejm0ijrwd5BGmj2bo2+26WBZU7je51R9ciBJUatPCah6Qg6ePymN3mofXno5fs3A24ScQqvCNwDD9rWRCM+Dkn7VUB01qMYnZIB8hoWjuWjm9fJr2J+j6ekh+mgdDjaQiFzfnsCnK8mwubUMEZT7IblIRDVbtzYbDiOW1V0rTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l+MBN7cKfFPeJ9kNJiqi4ei7+ENVT3/uLQGPG91NxQ0=; b=RS8nyvMeQSfNV/05PO4hAeDbXDUgV0getXO3GtMehHYO9Nl2y8ZOVjClZcqvbh5jCOaqMzktVc2fBla1thGUV2eIqsrnHcxMtUugggtTRYGrN274AArvfqgHrsXArb+u2Ogi4BtNeJ4S8vTIt6ycEXb8CkWriKSQlY2iey+kC18= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 5/5] xen/arm: smmuv1: Intelligent SMR allocation Thread-Topic: [PATCH 5/5] xen/arm: smmuv1: Intelligent SMR allocation Thread-Index: AQHXFRE3FfFdAlAZ8Eu9+88zMBZ+gqqGwk6AgAAuSQA= Date: Tue, 16 Mar 2021 17:54:08 +0000 Message-ID: <1C808D23-E8F3-4888-86AD-C37FCBAAD0D1@arm.com> References: <789abfb57568dcbaba122ea9b68c627e6c9707c4.1615312254.git.rahul.singh@arm.com> <299c8294-5f76-2fd6-85ec-d20c0b99368b@xen.org> In-Reply-To: <299c8294-5f76-2fd6-85ec-d20c0b99368b@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [80.1.41.211] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 77750f22-c552-4451-8b0c-08d8e8a48541 x-ms-traffictypediagnostic: DBAPR08MB5654:|HE1PR08MB2828: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: yP7oIHsJvQuJCdjUsmyxWnlRvOg/cM1mXZjat5DnRE0aIs/kvYqGxqsOGPcILnbrf3gUY9pjnsB72mrnp4ONuqdOJ/QjUA3/oT2a7JK2VEOPBzyI2JP6IZWaKewBwuPw25lS6ioOLWo7kqQ0+ZgwOVYbeAR+fyNg9QEHIWnsuYK+rKL+E4eOHNBdHdEfKQPQ6j1oo7bw2mp2NSNf7yGNnhLbNJ1uvh7NmbfXnuhj/s385SFdymrDh4RbRxL2zMi0mvbmmTxwlRuz5eqateZf3MSEKwneYMTeYDmk1jzNQ+O0VCsMSBBqHaZjqTNNT68cHOrEJAscq4HLklEiPk5XBQJentQQdX8j1j2g2AJLD/PCgiADYJjAk9YhvMyjrKxuJpQUdKAkbDp/fNYQmIRuFCa2zuaswA+Gy6ZCq8AuMOq0XoTSqoK3Ne4UqEBDQFUvvZbd82HlODfXEmENfO7wB9fffTXMfhx7bG83pr0xZ/HBVqFLh6MgHxXJJITmUJC5KescndIeFcjtShIB70XeZeuxfSPq6wm59JfouLCL+Ta5tg0pehM9+B4Sasb5qAro1CjxPfwRbCmIyODbGs0gU1L0CL81YPn6UxAF4DAJEFpd2e9E1copLdLBX8Lt8Xm9nzWutVxktLV2iH14uG6WYA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3500.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(376002)(346002)(366004)(396003)(186003)(4326008)(76116006)(36756003)(2906002)(66556008)(26005)(83380400001)(8676002)(5660300002)(66446008)(64756008)(71200400001)(6486002)(6506007)(6916009)(66476007)(53546011)(66946007)(478600001)(91956017)(8936002)(86362001)(33656002)(316002)(6512007)(2616005)(54906003)(3714002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Rp3b6lFM1hRLfcSpphJtx+YkLjI/OrGKnQWFEGojqo798bmAZBqDXjAHYW0j?= =?us-ascii?Q?9YgfO9tKLZ+9JSnAXdxeZY4VR6+ki7pUHwvHUERrizwo0FYQoOwXy2KUvZrX?= =?us-ascii?Q?1F/X1beUgqJkYw4Vu4v2+DWWSBY+JfglPdHXOp3ZX6/qBdkxSN6LeQSBFuyp?= =?us-ascii?Q?rd2nR23MdezZ1zUe+GvP0Gtv40KMlkEort3Fc0OO6xt8BqQkHJJNgIzxtEPM?= =?us-ascii?Q?td9DDXSSjJG7oSzfncR7vPEXQLa86M/ZKzNyGTYWnqeHbMormlea8QpqvdLE?= =?us-ascii?Q?sMQ3isGWJXnTnF5PO/PzQJRfesdyGxDJbdP8i8x2pMcT5Fx2kj2wvZrHZvyd?= =?us-ascii?Q?DuaSBYVbTaEYBB0ibZXXi9MeOvAPJthH/ujplFfqIlfg8EjCJJXP9qR6x1yy?= =?us-ascii?Q?u+GgqOfD4Q31TOg9jJIdkOaVsoATqjRRxSA2fkuqNUqgHge0TW4/Xzw99wKv?= =?us-ascii?Q?sho3/hKJ45Dxr4PX6A5je5+KrxTIxjV9lvb5QhLeMzjaYZNTB1kWUjGGwjbI?= =?us-ascii?Q?FkshS5H1/ItDatBBEw4jYTuRl1aC8Rk1ukUATduDemwPgjCEjns50w4y9oxS?= =?us-ascii?Q?OPL/NxF0CYld2CokguP3G7D4B9YwoetNSZhH/I2snEh1PCQwHHFkVktVfGsT?= =?us-ascii?Q?m7w4KlbqzGiLwmYkvK8AvPpL0JFte+L35Nd9rNY4nkCaNysvCuIKyHWjI2Jy?= =?us-ascii?Q?sd4UkgDHTmDZBfDDtpQbmdPNwu9KJKF229tQxG3mjWscaSXZ/jF12+8iuMTO?= =?us-ascii?Q?5XtrWsjpHJO+nqTvTRH9Aw5mugQ9ZV+kO0zXlAbNs0suM5Gfl20Yxg3XgXE/?= =?us-ascii?Q?qaZDgmQ4KxhuVSCCvvEBEXiARJAdRtuBH2ds54sPf9pT3iJqXO+CNQpHjcjo?= =?us-ascii?Q?rMQYngeiG/h9VBmpg9mrVhykwp9Ih2L8JO0RG3FUwRznlRpnWyCOaZMQitSu?= =?us-ascii?Q?8MlySj7WcA7k7QseLUM4iksL0kL+s8kEkPKd2qFcPzPIfTH2q69aeI3IFjhi?= =?us-ascii?Q?QBnUGoQWKWwfkpqfvTIsmrqTpPI3OUhWYyDu/K5SWvxPz4Wrq7C8exC3X1NX?= =?us-ascii?Q?dHOM4uIiR09rQsGGSEXNSe7IliskOs4aOTbKqxS4GpAZ97wTBJrHzAsOsER3?= =?us-ascii?Q?w4TUGjjtIuFRH7S8cHTp6g4n5hGuvuiC08Vdrin++rgBOiL2JwkSLQMwf8CU?= =?us-ascii?Q?GucWxeFJaAnhNvpzPS9f6MqIfQhflkAM0ORsklVLnVX6el/UHsDcNLaocPwf?= =?us-ascii?Q?59+28xcUMX1A9nW0mf1Po4ODjM1C1hNl9gxUe+x6WeJiSmimicBBr/8DyXNh?= =?us-ascii?Q?7OsvSos5VamSYkPdv9H1SsDC?= Content-Type: text/plain; charset="us-ascii" Content-ID: <9A5F0B26D191E247B360DC09181C1F27@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5654 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 54839c3e-e8e6-4f9c-57d9-08d8e8a47fd9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wT6EzCOPutPMkkCUoMCizYWQLD1utY6cqJDvyK8c7nC8e9Kq+FpYK+HAcuq6WSqZwDMvvS6m9JAy6RcA2/aV0wVPHcePwZSlQdQQohIRPryKB12wwNzOOKNiSF6oomoFwb1LE4VSSJn0XhEdpk+9DLb9jZM+GFZycXW5UmhHTC7OITapTdpJ1+hL5b0f+xF7Ry5vov+HxXO0lqrGtM5EYC+Qo5nWqwT5gj3W86uSd34TzVj35ZG+KqW1XFHB7Pg3Kg4TFgarRBI8hfofrowG27DmQSWRRxZzqI+P9U+Ww4NXhjZMXJBJkV4UuZCd6TvHQiVXPSk0cL8/W7nrInuVG+DUcAwWfJX/uVXtf+vPmDOG9cdQshuiXDGBJ9LP0tqsQmG4HFwN6j4c44m4BYEaC7CYZIHUggV2qXbVsIcP3zjyYUDBJVVQrGK9GcWaIAIW2w8gj8P1BOh2p+9uB5ijxvwe8uv6ZvLghEzp47pyTHbHy6Jq1jejGEBY8IVa5dcqQLVRffTKXouJc+vvoB5NgKx26XwFuUmK8u7yIougCdjejRq8tpTYpkUvHrZtR2Tzx9i+JlDVsZl+pV2O0IK6siy8waQ88dqTNVFeEgOcLU0khToa3dURmuakEgOyWWFv6P9r3ZqBKj35uj9mnFy2+50LosO4xOOJpQ/Duu9ayfKrCSs+njQlBVIaVC5HRdWA X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(39860400002)(376002)(396003)(136003)(46966006)(36840700001)(2616005)(6486002)(82310400003)(8676002)(36756003)(86362001)(316002)(5660300002)(4326008)(186003)(70206006)(53546011)(6506007)(70586007)(36860700001)(81166007)(83380400001)(8936002)(82740400003)(33656002)(2906002)(47076005)(6512007)(107886003)(478600001)(356005)(26005)(336012)(6862004)(54906003)(3714002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 17:54:18.0371 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 77750f22-c552-4451-8b0c-08d8e8a48541 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2828 Hello Julien, > On 16 Mar 2021, at 3:08 pm, Julien Grall wrote: >=20 > Hi Rahul, >=20 > On 09/03/2021 18:19, Rahul Singh wrote: >> Backport 588888a7399db352d2b1a41c9d5b3bf0fd482390 >> "iommu/arm-smmu: Intelligent SMR allocation" from the Linux kernel >> This patch fix the stream match conflict issue when two devices have the >> same stream-id. >> Only difference while applying this patch is to use spinlock in place of >> mutex and move iommu_group_alloc(..) function call in >> arm_smmu_add_device(..) function from the start of the function >> to the end. >=20 > As you may remember the discussion on the SMMUv3 thread, replacing a spin= lock by a mutex has consequences. Can you explain why this is fine? Yes, I remember the discussion on the SMMUv3 thread, replacing a spinlock w= ith a mutex has consequences.=20 I replaced the mutex with spinlock in the SMMUv1 code when we are configuri= ng the SMMUv1 hardware arm_smmu_master_alloc_smes(..). I think it is fine to use the spinlock in place of mutex in SMMUv1 where we= are configuring the hardware via registers as compared to SMMUv3 where we = are configuring the SMMUv3 hardware with Memory-based circular buffer queue= s. Configuring the hardware via queues might take a long time that why mute= x is a good choice but if we are configuring the hardware via registers it = is very fast. Configuring the SMMUv1 with the register is very fast and there are no side= effects of this if we use spinlock. Let me know your view on this. Regards, Rahul > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 16 18:38:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 18:38:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98448.186766 (Exim 4.92) (envelope-from ) id 1lMEZo-0008Hn-KJ; Tue, 16 Mar 2021 18:37:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98448.186766; Tue, 16 Mar 2021 18:37:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMEZo-0008Hg-HI; Tue, 16 Mar 2021 18:37:56 +0000 Received: by outflank-mailman (input) for mailman id 98448; Tue, 16 Mar 2021 18:37:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMEZn-0008HY-7E; Tue, 16 Mar 2021 18:37:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMEZm-0001HI-UC; Tue, 16 Mar 2021 18:37:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMEZm-0001IB-L6; Tue, 16 Mar 2021 18:37:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMEZm-0005BK-Kc; Tue, 16 Mar 2021 18:37:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fXQgPlF8vO85Q8Qcdo5c1ie3dZF8M8fRui7KEzJECoE=; b=yuxpEBbTwYkq7y/WgOCEjAPcI3 zq+VF2guZuJ+AEMY/MSrPnO4zHOn19lPlvOK4ln5mEYQBIqYznJwXD7W4sMimGmBkxrvWPAoMTkOd WMt7mo4kei09DVeH8ctd50BpTkBt3pKKqzhk2HnM5OSDlEdeoUqGm850l5zXPB8MPYwQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160098: all pass - PUSHED X-Osstest-Versions-This: ovmf=f3bdfc41866edf7c256e689deb9d091a950c8fca X-Osstest-Versions-That: ovmf=4751a48aeb2ab828b0a5cbdc585fd3642967cda1 From: osstest service owner Date: Tue, 16 Mar 2021 18:37:54 +0000 flight 160098 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160098/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f3bdfc41866edf7c256e689deb9d091a950c8fca baseline version: ovmf 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 Last test of basis 159932 2021-03-11 09:09:46 Z 5 days Testing same since 160098 2021-03-16 13:41:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ankur Arora jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 4751a48aeb..f3bdfc4186 f3bdfc41866edf7c256e689deb9d091a950c8fca -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Mar 16 19:42:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 19:42:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98457.186781 (Exim 4.92) (envelope-from ) id 1lMFaJ-0005v9-PO; Tue, 16 Mar 2021 19:42:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98457.186781; Tue, 16 Mar 2021 19:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMFaJ-0005v2-MN; Tue, 16 Mar 2021 19:42:31 +0000 Received: by outflank-mailman (input) for mailman id 98457; Tue, 16 Mar 2021 19:42:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMFaI-0005uw-S3 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 19:42:30 +0000 Received: from mail-pg1-x52b.google.com (unknown [2607:f8b0:4864:20::52b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1cf557f5-2c31-4743-9102-119282c43342; Tue, 16 Mar 2021 19:42:29 +0000 (UTC) Received: by mail-pg1-x52b.google.com with SMTP id q5so10650831pgk.5 for ; Tue, 16 Mar 2021 12:42:29 -0700 (PDT) Received: from ?IPv6:2601:1c2:4f80:d230::5? ([2601:1c2:4f80:d230::5]) by smtp.gmail.com with ESMTPSA id q15sm212165pje.28.2021.03.16.12.42.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Mar 2021 12:42:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cf557f5-2c31-4743-9102-119282c43342 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7bidFJbtkCx1tTF0G5sFxG5Z+mLbn55iVfmgjUpLhtQ=; b=POwV4Ao5DTgC+rE8etwqrJVWWQlAuvIyTZDsHwRiTpvlhduZ2qqbfNq7RU6sfhkh3y RXQvb7xlPEfsso6izSOdNLu4sgKYYx3Odl2m5U8MSlTZWZgEza6/N0Kw+bPwLGBevZLC xxpfA/l5A6mVCMRpTn7qFtkditY14J90MGiLRJc/0r2u7fvLcBz/RdLJQNq0Mk4HYPmo /vhMmmQuu5CY9yy1WjtbKHYztEEmnRl2zeNGhEYB+HGxpXIGG2Wd7QT3uVdPp3VE3KoM DB3e0PwjL+UMtDVTmwv5bjL28RT76dC3CNMi6WEW76wca3ukAbSkWpm8SrcU2YKqNEbK Si0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=7bidFJbtkCx1tTF0G5sFxG5Z+mLbn55iVfmgjUpLhtQ=; b=QUkgAjyenyh1pbsqBgjxTB6ZhfMZ6vxNrY9WT7uqHNAupW02ZmfQurnmCEIngM6bbM XPsc7I8V4tV8B1xQvQRAEUm/VzsgCRKoQQ3NMxbClySyLdIANhOD+Xoi7KLbUceSixdr v8Cnm+vp2frjiBFlhpEH0ABDZC8G+TxstYggDYAzUAJob1UNTtMinKDjRGelQjsQcnmw QoKGHDmfCSNiX2G9rsvltbXX4rRSqaZlt7eMhqQ/8AF6J8LaEcTwwQE15nhdtDoFLx78 tJAFHCyS8TG0Xi7jsuNknot/LpHY98WgwO7T92G6UzikMCxFef8WGEsVQceWucyVcjVS RSJg== X-Gm-Message-State: AOAM533PotE//e3riSu3A59WWn4EInRGTQycTbJum2mwuJ24j+TektAT I4lM94D+DIulm1x4tBptX0I= X-Google-Smtp-Source: ABdhPJzM37Il9GlMP03Dv+H0xzcvPURkQFFjWlzQYO94vJbuUk96bsyNO4II7kF6HJA13yK+C3vWAg== X-Received: by 2002:a62:7f45:0:b029:205:9617:a819 with SMTP id a66-20020a627f450000b02902059617a819mr886047pfd.17.1615923749030; Tue, 16 Mar 2021 12:42:29 -0700 (PDT) Subject: Re: Working Group for Secure Boot From: Bob Eshleman To: Xen-devel Cc: Andrew Cooper , George Dunlap , piotr.krol@3mdeb.com, Olivier Lambert , Trammell Hudson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , "Daniel P. Smith" , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Roman Shaposhnik References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> <1039be05-cbf2-95aa-5eba-246fb06be8e5@gmail.com> Organization: Vates SAS Message-ID: Date: Tue, 16 Mar 2021 12:42:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <1039be05-cbf2-95aa-5eba-246fb06be8e5@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hey everyone, I think most who are interested have acked the thread at this point and I've CC'd everyone (please add anyone if I've missed them). I'd like to suggest we have a first group call to set out an agenda, define scope, and start identifying the direction the project would like to go for secure boot. I'll prepare the call similar to how community calls are handled, with a public cryptpad for agenda items and such. Which of these dates work best for you? Which absolutely do not work? Mon. March 29th, 16:00 UTC Wed. March 31st, 16:00 UTC Mon. April 5th, 16:00 UTC Given the Xen community call is at 16:00 UTC, I figure that probably best captures our geographic spread. Feel free to suggest alternative dates/times if none of the above work. We can host the meeting on Jitsi which works quite well from any web browser. I'll send out a invite link when we've decided on a suitable date and time. Thanks. -- Bobby Eshleman SE at Vates SAS From xen-devel-bounces@lists.xenproject.org Tue Mar 16 20:07:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 20:07:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98461.186794 (Exim 4.92) (envelope-from ) id 1lMFyC-0007ta-Th; Tue, 16 Mar 2021 20:07:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98461.186794; Tue, 16 Mar 2021 20:07:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMFyC-0007tT-OR; Tue, 16 Mar 2021 20:07:12 +0000 Received: by outflank-mailman (input) for mailman id 98461; Tue, 16 Mar 2021 20:07:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMFyB-0007tO-RC for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 20:07:11 +0000 Received: from mail-qk1-x72b.google.com (unknown [2607:f8b0:4864:20::72b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2a6739ac-60b8-4418-aa67-4831c3109de1; Tue, 16 Mar 2021 20:07:10 +0000 (UTC) Received: by mail-qk1-x72b.google.com with SMTP id b130so36603546qkc.10 for ; Tue, 16 Mar 2021 13:07:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a6739ac-60b8-4418-aa67-4831c3109de1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zededa.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FlvTazR6HIYPQzlRgPOdqYHYhD/aC4QCFeHEiJLQpnU=; b=gJp4g8fv8NXPHJRMc2RRG4wctAhpKRFgONibcqSvRhLhGiMbVgLEsAnDtjUoEJ0TYP 8WfcyR5EEm0cIvbbV17WZnqVh6F61D9CydIb3BbDlxGf/+LJ2ULwGQesIEkz7WZtnYsn EVSXHvg1sNPnH5ltOpYGUFWgmRnkRCedVvL31zvAJF1FrV9J42t3HsfA5WI/UsBmlJml 9ioxW+XgVRLyUoXw2YUcjMESj1tcLh2yliFIFNQLVbYmDB0KnBU1ZdNT62IZCD87NwTk jIPDlZWbWYhPIKfCXIlOksn14TB504zfVf3lO5tnYtL1cVVGUKdMDHZrJ4AYwENk/fSY ZMqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FlvTazR6HIYPQzlRgPOdqYHYhD/aC4QCFeHEiJLQpnU=; b=F74P8pXPfnvJGY1R9QkYnAtmJgt5ONq6AJOd0a6a8m8VL9vfPq6VMTyiwTdtoGq7tW b8R85orvhoZx4MD9Q7faYXm2SUQAlUB0P8PdExGeLfXLZXojE1/stzsqGX8qjbnuozKn n+fn+ds5fYcEkFT0OQP08qv+dDXWS7tfxPOXfej+JGseQnQrPYP+/hIb/huqSDfFKnso aT/HYJfw87L2//J38iHtQKSc1srmfvPjZrx8Hrg10sIVzSMG56I1zR6xcQZPSXBba1hc GBv//2NgHZ/VTNQxx2gQyTvOisJGMnnXZc9k7sIUBK8oqmR1yAi54WwuCANYKI7pXD4I lZZA== X-Gm-Message-State: AOAM531nyBuzdsjJ/sPwgPVVk/hsBF9WJxvI71jo13fxuQ6gbH5/iInT iS7zNqIU47ytSRj0GwhwuoYgCM9NcFTd/KvWueEZ3w== X-Google-Smtp-Source: ABdhPJwaveTsccwlJQOCT9RBWSIt4lF3ocAV+x6v7mTyJ5Y5cV5Ex/L+XOpj4fCTAVqhUdil2d4WXWsnFqwX05jGeoA= X-Received: by 2002:ae9:c30e:: with SMTP id n14mr794574qkg.291.1615925230495; Tue, 16 Mar 2021 13:07:10 -0700 (PDT) MIME-Version: 1.0 References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> <1039be05-cbf2-95aa-5eba-246fb06be8e5@gmail.com> In-Reply-To: From: Roman Shaposhnik Date: Tue, 16 Mar 2021 13:07:03 -0700 Message-ID: Subject: Re: Working Group for Secure Boot To: Bob Eshleman Cc: Xen-devel , Andrew Cooper , George Dunlap , =?UTF-8?Q?Piotr_Kr=C3=B3l?= , Olivier Lambert , Trammell Hudson , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= , "Daniel P. Smith" , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Type: text/plain; charset="UTF-8" WFIW: all 3 time slots work for me. Looking forward to this! Thanks, Roman. On Tue, Mar 16, 2021 at 12:42 PM Bob Eshleman wrote: > > Hey everyone, > > I think most who are interested have acked the thread at > this point and I've CC'd everyone (please add anyone if > I've missed them). > > I'd like to suggest we have a first group call to > set out an agenda, define scope, and start identifying > the direction the project would like to go for secure > boot. > > I'll prepare the call similar to how > community calls are handled, with a public cryptpad > for agenda items and such. > > Which of these dates work best for you? Which absolutely > do not work? > > Mon. March 29th, 16:00 UTC > Wed. March 31st, 16:00 UTC > Mon. April 5th, 16:00 UTC > > Given the Xen community call is at 16:00 UTC, I figure > that probably best captures our geographic spread. Feel > free to suggest alternative dates/times if none of the > above work. > > We can host the meeting on Jitsi which works quite well > from any web browser. I'll send out a invite link when > we've decided on a suitable date and time. > > Thanks. > > -- > Bobby Eshleman > SE at Vates SAS From xen-devel-bounces@lists.xenproject.org Tue Mar 16 20:54:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 20:54:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98469.186806 (Exim 4.92) (envelope-from ) id 1lMGhM-0003ps-FE; Tue, 16 Mar 2021 20:53:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98469.186806; Tue, 16 Mar 2021 20:53:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMGhM-0003pl-Ap; Tue, 16 Mar 2021 20:53:52 +0000 Received: by outflank-mailman (input) for mailman id 98469; Tue, 16 Mar 2021 20:53:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMGhL-0003pg-2i for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 20:53:51 +0000 Received: from mail-pg1-x52d.google.com (unknown [2607:f8b0:4864:20::52d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6e39a9ea-3556-46d5-8192-0b3414a6509f; Tue, 16 Mar 2021 20:53:50 +0000 (UTC) Received: by mail-pg1-x52d.google.com with SMTP id w34so22370464pga.8 for ; Tue, 16 Mar 2021 13:53:50 -0700 (PDT) Received: from ?IPv6:2601:1c2:4f80:d230::5? ([2601:1c2:4f80:d230::5]) by smtp.gmail.com with ESMTPSA id y19sm18798333pfo.0.2021.03.16.13.53.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Mar 2021 13:53:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e39a9ea-3556-46d5-8192-0b3414a6509f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vxGHpLyrbonFYrwtGokt0tk7MeUMi7n2NCzzUY3q9ZA=; b=Hj4RcyurvjzOSz9dvEP3ZC1sHILcsUVF0y6WQgGfrOc1VK8j+IfjHKUV5ENzIBtNWx 8Ih1XfbmRkjR4mVegbbg/xBCByp+A4PFF4ebnG3MH+Kp7UZaL2q6pi6elMAoiU6ea7dE bRuyqfB9uyp2IJsdsxAzOejPe/a6JMMtEbBztOr7O3xcNdS9BCnJCt2BP9I43rYjU8AJ hY5ZJjFvBYgTTsn8JJprz3apafLp9FbKVt3wZnBVyp+ynj9CbO4vXZsveUTRd9bC6fgu fQ9/Je3KbXSPOgBZppnVQYkzDHeMBALiChM2lFO+RSGYPwimbtBZEpE91rHSKJjPpRLr 9fmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=vxGHpLyrbonFYrwtGokt0tk7MeUMi7n2NCzzUY3q9ZA=; b=C2TFKl/AFSAmeXgI1EO1bfYhQPluiSElA056KOTEwHMdU1wD5msIFS7PssmSmzzo6O GtQP1xHTQcDdvFwa1U6S+dWs/2v3nEdY6ZnlNr99/hO45vKQ8c6cM3ZFiAKis7+8geXz 5vZWamCwGP6E3St76nuH04I0PsSwQ9kG+FMZ4zpD9nWz4KdiPhptMGMFBSUao4K80avw /25omXuQ3moh7XHp/780htabWFF6uDUBp2dMiGd+xr43SJmeqd398uC3/NEPhf9Nwijb 2dYdv/5T3JIYZ8bXtxIEh6dJGTLoUZHDdqJ5+OB7NrQGlVFceME/m9b8renGqOKCRfFl DDnw== X-Gm-Message-State: AOAM533SZPlhybvg1JhHmo83aS1Kpw6gxZ+g1+AZDYtzz5ezskNp48Ee KYSVgveOJ/m6pprOloyBGWw= X-Google-Smtp-Source: ABdhPJyVf9iitM7749tPEdmtMpONXdZmDrk2c5JQKsc7c2mIJtNgz7YO/e9q8idQv6fFelmA4Mpyig== X-Received: by 2002:a63:4654:: with SMTP id v20mr1326032pgk.129.1615928029360; Tue, 16 Mar 2021 13:53:49 -0700 (PDT) Subject: Re: Working Group for Secure Boot To: Roman Shaposhnik Cc: Xen-devel , Andrew Cooper , George Dunlap , =?UTF-8?Q?Piotr_Kr=c3=b3l?= , Olivier Lambert , Trammell Hudson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , "Daniel P. Smith" , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> <1039be05-cbf2-95aa-5eba-246fb06be8e5@gmail.com> From: Bob Eshleman Organization: Vates SAS Message-ID: Date: Tue, 16 Mar 2021 13:53:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/16/21 1:07 PM, Roman Shaposhnik wrote: > WFIW: all 3 time slots work for me. > > Looking forward to this! > > Thanks, > Roman. > Thanks Roman, same here! -- Bobby Eshleman SE at Vates SAS From xen-devel-bounces@lists.xenproject.org Tue Mar 16 21:20:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 21:20:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98474.186818 (Exim 4.92) (envelope-from ) id 1lMH73-0006TV-Ip; Tue, 16 Mar 2021 21:20:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98474.186818; Tue, 16 Mar 2021 21:20:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMH73-0006TO-E3; Tue, 16 Mar 2021 21:20:25 +0000 Received: by outflank-mailman (input) for mailman id 98474; Tue, 16 Mar 2021 21:20:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMH71-0006TI-CH for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 21:20:23 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dced77c6-f5ee-493f-9b23-842f8396504d; Tue, 16 Mar 2021 21:20:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dced77c6-f5ee-493f-9b23-842f8396504d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615929622; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=6Z41Bv9Zh3MJsjEEqeG2uocWQjWkZgiFe1RiAmGy1+A=; b=Uf+4NK2UEbsbb20xuO5kAoOOITSchVF8sIqmtzD7aDP/ufofucGClgMP BjnRrNceRziHfqd1TVZ/hZHHS6zGlTAtU/OX8gIhR3Nx/5GEpLOvKAH9r oJGbfZtQ5tdUGB715gnctNY5rN9AYG1xEhVpy34Pf+QmD8h1BK67S6HGM M=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 3p3J0/6orKRbLkSiW6GRz6OMmoDeUvoRKQ8VHXLNe7yCvw1poc08Ktod2Xw0oZOBeIg99+ksqI 3LTC7dDOBKhXe1IXDnzbCyNXIIXZXvm1Xxc9mQQpSmyDLrC8q/XoDaY/ae0L6I260P/FbwqCZW t21Vg0dBYkPHLK9SRHDOXwnlZnXQ4vs5u7UDdK4vIODV0/y13XYQi3bijGIRqAa+1cSn3pMS1o rM1cJ00L60D57NPl0/RtsYs3ukwbUc+tPFQ1ubsd4GIxVmJKyXMG68LXEpMpFSawkQTtjKnb1F Ge0= X-SBRS: 5.2 X-MesageID: 39434071 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:rq0sY68pOgWVTDmei/Juk+F1cL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmyybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIUHD38Zn/+ Nbf6B6YeecMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsKV4hLxW5Ce2OmO2dxQxRLAod8MZ Ka6NZOqTbIQwVpUu2QAH4ZU+/f4+DRnJX9bhIcQzIh4g+CjTSngYSKbySw9BEYTj9J3PMe4X HI+jaJm5mLntOa7lvn12HV54lLg9eJ8LV+LeGFl8R9EESVti+Gf4JkMofy2wwdgObq01oylc mJnhFIBbUI11r0XkWY5STgwBPh1jFG0Q6Q9Xa9jWH4qcL0ABIWYvAx/L5xSRfS50o+sNwU6s sitAj4xvkneC/opyjz68PFUBtnjCOP0B4fuNUekmBFVs8mYKJRxLZvjH99KosKHy7x9ekcYY 9TJfzbjcwmE2+yU2rUpS1GztCqQx0Ib2y7a3lHkMmU3z9KpWt+3ksVyecO901wha4Vet1q4f /JPb9vk6wLZsgKbbhlDONEesevDHfRKCi8f166EBDCLuUqKnjNo5n47PEc4/yrQoUByN8XlI 7aWF1VmGYucyvVeIOz9awO1iqIbHS2XDzrxM0bzYN+oKfASL3iNjDGYEwykuO7ys9vQfHzar KWAtZ7EvXjJWzhFcJixAvlQaRfLnEYTYk8pss7YVSTucjGQ7ea9tDzQbL2Hv7AADwkUmTwDj 8oRz7oPvhN6UitRzvWmx7Ud3TxelHu3J55HaTAltJjjbQlB8lpiEw4mF657saEJXlpqaotZn ZzJ7vhj+eaqACNjCL1xlQsHiAYIlde4b3mXX8PjxQNKVnIfbEKvMjaXWhT2XCANyJuVs++Kn 8Zm31HvYaMa7CAzyErDNyqdkiAiWEImX6MR5AA3oqO+NniYZF9Kpo9QqR+GUHqGnVO6EdXgV YGTDVBal7UFzvoh6ngpocTHvvje951hxruB9VVp3LZvUC1vtouWXMfYj6rXaes8EQTbgsRom c0374UgbKGlzrqA3A4mv4EPFpFb3nSPKhLFz2fZIJfmqnifSZ5SWviv03dtzgDPk7Rs2kCjG 3oKiOZPdXGGEBUtHxj3qH2y19sbWmGc0Vsand1jJ1lGQ39ywRO+N7OQpD2/3qaa1MEzO1YCj 3DbDcICi5Fxty81neu6Xy/PERj4q9rEv3WDbwlfb2W52ikL5eQk7oaW9VO+ox+CdzouugXcO 6WdgOPNgnkA+cx1wH9nAd9BABE7F0f1d/40hzs62a1mEMlCf3JOVJ8WvU1Jcqf42WMfYfA7L xJyfYO+c2+PWX6ZoTYleX5bztfJgjSpmDzZecyspxQtb8zsrw2P5Sza0q+6Fh3mDEFaOHznw ciZY4+xpbrEIpmZdYTdCJU5UBBrqXFEGIb9ijNRtYjdlQshULBN9yH47D0uaMia3fx0DfYCB 26yWlh5P/LUCuI6K4CB48xKWpQblIg6H4KxpL1S6TgTCGrffpE5ly0LzuUd6JcUrGMHdwr31 tHyuDNu++cbCzj3g/M+RN9P6JV6m6iBee/GhiFF+IN09u0Pz238+eXyf/2qDf8Uj2gbUsEwa VDaEwLd8xGzgAYs7df6Fn7doXH5mQ/k1Vf5jl7llninqieiV2rY31uAEn+mZVZXT5aL36Sq9 /KmNLojEjA3A== X-IronPort-AV: E=Sophos;i="5.81,254,1610427600"; d="scan'208";a="39434071" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qc6UY3baIfPZI4IklCy0gq4Hw0dIQFQ31m9bn4W1ZXvR2r9TCuTpWGAz5mqBX3Xca0hbgzCTZUuUnS5oHv4Z48LGdrWWZa4lH0hu/80T22g3u9JjnFUDA9LJysW/EAkYESTqAxmXc2EaYAWFfz9/D0+XyKApj91WF/TAEjnAfp4olRF6Ay6eWwsZPupjsLuzMr8beYlB5rsFDbCj0MFpS86JgNqDfStccarbP64Q6896RqAl1OAyPl/LCQm/Nd7iEgNxYzRv0qHXjQuLmK9xQ3ua1fx7zid56ywgW3om8ecUb5W8D5Z8kCcly9UlQHqjvaO6/b+SeYTfnsWhjX+u2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GEzroIj0gAs/8HZEqRSFg63+ZpN1LwgWVvxr7JUIQAw=; b=Naq3TFOBNXBgNm82+jnIX22DFDAHwV9NWPt2z3n3UbbwYoKVPNiBGQM660FthymynMAeyUBwjRycT3XLax6uRJq/PYFyhFxBfYratvAT91PLsYevqMnn7jsYU16yAxcUy74NoSCx8lpb7+4+sTCmIu1THkrBloLoM+dnWCiURXcdzMo6Bnb41sMkCsn+CqKp7KA0cmRzMrTCprsPFrzce2nms5hvSN00iVbKVs5jWSp0XqZdHpzJJKhq5SMJ6Q6OD1GVNCR0zGXv2E4OcSByzx4BQtJmCHGvll/UBtZL/rDgxYrlW14J2xoox4tu1W1W8bgfhQIAJ+NG3NS8vDPN0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GEzroIj0gAs/8HZEqRSFg63+ZpN1LwgWVvxr7JUIQAw=; b=hkTuDrc7AKgk0JGtbe8sHZdPHnfG0EIaMuDHK0+PnCyESQtG3D7wD1PM9KWtRKhh2kjfmgd3mxM/LA1VFxcQ93xe9Z32ETw+IPrEpIwdTSIiBPnfgW2e783fM7YWcd+XP87OyNJrI30iAce8JL3LC7cxZiSwGOOHh/Nan7sn7+M= To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Xen-devel , Jan Beulich , Wei Liu , Boris Ostrovsky , Ian Jackson References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-4-andrew.cooper3@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 3/3] x86/msr: Fix Solaris and turbostat following XSA-351 Message-ID: Date: Tue, 16 Mar 2021 21:20:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0402.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::11) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2048d646-1a14-4c83-8b03-08d8e8c14ad8 X-MS-TrafficTypeDiagnostic: BN3PR03MB2372: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FT+lndZ2f/NvlhjazkZGC3zo0KAcT6oB/9c+88JI4iFRc/NKM3V8VDBBbFU5R8Dyj5z5ng5yHKh5dPC6RXwwjtctkbeOKzd++XWG8U/MAiyUe7OyY7EMTa69hrPlPjI48+VGDGHiBgOEiac5lWIqrpXqrXcWTONCz+oPIgYdOS3WxJnmFFalAW9l19C1shLB5mZ/O0hPpRFkPUEuoYBQuUiGJ8uZawXyz7RBThlZ6tdDJLw9nBPx731AEXpg8uMWWIlDqZCsONaTz+t3T+3f1utjlDoiRLdNRqKD0o8JPkqVbG3rGKYe4udMYe3yIVFWGk3DZ/cbHgMLWumKwwylCNdO9cH6CulT6Y/3cKmUeOzbcvLZRTISuqxwej5PeRSuHG/gy1sHASN1gST1pHduowyOcQx5j7LxQf4lnqfZw+mSE0PEIzRAN8FlwAIe0i4vjMvS9rsT+B4UAFF3ivIo35HdGnXJHro+PiR4pUSQqJg5rqS2wEchl4AJ1shGSqtsXHZGhLSCVwKraX3/G0ZMIhzqWgTsD9v2QviB2VJill0+7VpqM9Ov+Yx0p515jGEQMFODhktwaPAVsff5/O5Bx9mzO1cqsNorc2xV/o6bIs8vrV4O+/KWfoEJIMfY08omQdm3yNMPNLtakdflAIO87g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(5660300002)(956004)(2616005)(6862004)(66946007)(66476007)(66556008)(6636002)(8676002)(53546011)(6486002)(83380400001)(54906003)(16576012)(6666004)(16526019)(26005)(2906002)(37006003)(36756003)(86362001)(186003)(498600001)(31686004)(4326008)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?L0xJZldXK0Y1dUpnS2xIeHpOd1YyYkhUVHZKSjZDN2diR2NoZ3cxWmpCbUtx?= =?utf-8?B?N2hRZ1BCOXJFWU1GU083OElrVjIyYmNDUENUV3ZSbXB5aXlLY0lMS3g2OEhy?= =?utf-8?B?bG5tMVJ1d3FvTjM3anVLWUxFRVpNeWFLWllTMk5hOGxQT1JxVDd4T21ZV3Vr?= =?utf-8?B?Ny9yOWlMVGlCOWZ3S3YyRUlvQzZiM05PQmZVSzBvMGdMdFVRd2ZNeEpieXVq?= =?utf-8?B?cWE2cWZtTWRJN1MwRXVQd1BzS0h0dlpoeTZUMTF0Z0hDanlSRWRvZ2NzdkZl?= =?utf-8?B?VFFNZEF1bVNXc0ZYeklXYXp2QzRLL0ZuelV3dklSQXhxckZUZmQ4ZzZ6L255?= =?utf-8?B?c2EyamV6ZUp1OHlVeEhiUlZzazk2OEtDQzU3aTd2clF2Z0FveEdsajJORUYx?= =?utf-8?B?eDFGVysxdUJTNXVVT2t6bnlMWHMrUlVnNFpqNUlCdG5ObG1BTEJ4a21VNldu?= =?utf-8?B?U2xzN0lORkRqUGdmMG5oQW04d3p3RnlvaVd6OGNyZk1USTNtdkVUYm5PRjFO?= =?utf-8?B?UUtrTitrRnFBNStxSVFFOXZPMW0veWtHSUhKODROdWtpRDN1cXJYSEg5U2Ez?= =?utf-8?B?Zm8yK2w0V2UvL3N6aHNUQmhpTys5SzlHdGFvRGJ3S01wV3U5VmxIWEpjeEhw?= =?utf-8?B?a2xhWEtWZG5RSTZ1NTlLQXY2TURWMzh2RjQ2cG5qeHoxY3VRTXNYSWhLdmZx?= =?utf-8?B?RGVqd0pIY0krK2dKT0hmbkFtWEp0UXFQMzNHWHpqUU4rc2h3cXhnTEMrS0lF?= =?utf-8?B?V3JGOGxOaWg3TzBpTmFVcWdLMy9lY1VlNk5vT2czNGpPaDBHV004OGtjRVA2?= =?utf-8?B?TE5GRmJsSFpoQ1BBQ2tuSFF6Qldnc25DdGpjUTY1UG9aMVhITWJkaCtiT2lF?= =?utf-8?B?OUczcG8wYXRNNzMzK3ZGNXJxWGtLOGx4MjQ3bk1rVU0ra3RUaVBlNW1ORis1?= =?utf-8?B?TjNBSy9XMTlpbGk3TW45QWp0NGd4bUxMZXFNZk1pcEdXcC81YldtUXdTckph?= =?utf-8?B?alVBQVhSWGN6Z3IxZGlUNnFaN0FYNGt6UEU4QUdYZVBvQm80S254QmJXNmVG?= =?utf-8?B?SzJsWWhPeVR3SjZMNG5ZYXM3NDkxRmxYcUpoeEVtdE51RVNUMEpjekZDcXZ2?= =?utf-8?B?YVZVQytlVm1jbENCKy83QlBPTHFPZkdRaDZES1BRTEcxM294dmRWMzFCS1Ro?= =?utf-8?B?d2pNcW1DSHlYQ3oxUEdyd3NPcmxBNTljYTNaK3dGZWFzemtKeCsyZ1Y1MFdC?= =?utf-8?B?YzdmcFY4NlI2Q3hwWDA4WUdNLzY2QU1XUTFScDQ4VmRWSG44emVHVjBLczRL?= =?utf-8?B?bmpkS3pDRUN6aWZrWDhzVDdWYyt6OU9GZHRXWFRFWVVDK0VGd0xPcWdQNTVv?= =?utf-8?B?SStzN2p5V1lxVnNpYnFFZVdVVU1vQ1U0WXJuN0ZrdjZYNUpFMkxyT0FTN0Zk?= =?utf-8?B?T2YwdnJjVDh5TVJzU3JsZU91dFExaEZnWFdLMzdIUkFPVEtmZVF0Zm9iamFO?= =?utf-8?B?OUJMbzVNMk9kbzNqMXVORFBUcTRENHJYWkxSdHovOVFWbGlSejFXNldHcXZh?= =?utf-8?B?MnhvVnVNdnVkMThWUi84NlFhRHFZaFByZmxYemUwenpsR3BLL1FCcDhUcWFm?= =?utf-8?B?NmhabzRwV1JHSC82SjdkNW9sUDVkRTY5ZHFmcXlsS2tRTXM1YU4vRGhBVHgr?= =?utf-8?B?OXBCQXBSd3B6L3IyNkZqVmpuWkJiaWZJOHVHMnNGaG5QeXRobkJQdzQ0ZzdN?= =?utf-8?Q?eZK0zZaFilP+gtD6p8GCSKJhAF49Qx7nO/aVwpD?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2048d646-1a14-4c83-8b03-08d8e8c14ad8 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 21:20:15.6531 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FhG31z7XPnHs16IMfrNGVCxpJuHQ/kwUN5mqXi4aDJebMxN0fpVfKqaEGI9X8klhzZAJr4Idd48vlBpmd76mIQYsNTjn2kT1ZM4kIo4wOvU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2372 X-OriginatorOrg: citrix.com On 16/03/2021 16:56, Roger Pau Monn=C3=A9 wrote: > On Tue, Mar 16, 2021 at 04:18:44PM +0000, Andrew Cooper wrote: >> Signed-off-by: Andrew Cooper > Thanks! > >> --- >> CC: Jan Beulich >> CC: Roger Pau Monn=C3=A9 >> CC: Wei Liu >> CC: Boris Ostrovsky >> CC: Ian Jackson >> >> For 4.15 This wants backporting to all security trees, as it is a fix to= a >> regression introduced in XSA-351. >> >> Also it means that users don't need msr_relaxed=3D1 to unbreak Solaris g= uests, >> which is a strict useability improvement. >> --- >> xen/arch/x86/msr.c | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c >> index 5927b6811b..a83a1d7fba 100644 >> --- a/xen/arch/x86/msr.c >> +++ b/xen/arch/x86/msr.c >> @@ -188,7 +188,6 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64= _t *val) >> case MSR_TSX_CTRL: >> case MSR_MCU_OPT_CTRL: >> case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): >> - case MSR_RAPL_POWER_UNIT: >> case MSR_PKG_POWER_LIMIT ... MSR_PKG_POWER_INFO: >> case MSR_DRAM_POWER_LIMIT ... MSR_DRAM_POWER_INFO: >> case MSR_PP0_POWER_LIMIT ... MSR_PP0_POLICY: >> @@ -284,6 +283,18 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint6= 4_t *val) >> goto gp_fault; >> break; >> =20 >> + case MSR_RAPL_POWER_UNIT: >> + /* >> + * This MSR is non-architectural. However, some versions of So= laris >> + * blindly reads it without a #GP guard, and some versions of >> + * turbostat crash after expecting a read of /proc/cpu/0/msr no= t to >> + * fail. Read as zero on Intel hardware. >> + */ >> + if ( !(cp->x86_vendor & X86_VENDOR_INTEL) ) >> + goto gp_fault; > AFAICT from Linux usage this is Intel specific (not present in any of > the clones). Indeed. > >> + *val =3D 0; >> + break; > Do we also need to care about MSR_AMD_RAPL_POWER_UNIT (0xc0010299) for > Solaris? AMD has a CPUID bit for this interface, 0x80000007.EDX[14]. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Mar 16 21:21:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 21:21:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98477.186830 (Exim 4.92) (envelope-from ) id 1lMH86-0006ZU-S9; Tue, 16 Mar 2021 21:21:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98477.186830; Tue, 16 Mar 2021 21:21:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMH86-0006ZN-P1; Tue, 16 Mar 2021 21:21:30 +0000 Received: by outflank-mailman (input) for mailman id 98477; Tue, 16 Mar 2021 21:21:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMH85-0006ZH-Eh for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 21:21:29 +0000 Received: from mail-pf1-x42b.google.com (unknown [2607:f8b0:4864:20::42b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2a228680-165e-44da-9f2c-91186a2ec62c; Tue, 16 Mar 2021 21:21:28 +0000 (UTC) Received: by mail-pf1-x42b.google.com with SMTP id 16so9714043pfn.5 for ; Tue, 16 Mar 2021 14:21:28 -0700 (PDT) Received: from ?IPv6:2600:380:8024:351d:e408:e9a3:21f:c070? ([2600:380:8024:351d:e408:e9a3:21f:c070]) by smtp.gmail.com with ESMTPSA id p184sm17575536pgp.13.2021.03.16.14.21.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Mar 2021 14:21:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a228680-165e-44da-9f2c-91186a2ec62c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=mdHeWv0B3/tMyhBE9ZB8sjNcuRBGkqEoiWe/K/cvJdA=; b=XrEaU964dBg1inEOZGdCFyCvjtQOC9RsWWLGh0MBfYif3teurzhg4YaKyvpNcuER59 wWISe9L+J6pKFWfltanY2ozEWXK32gJQC+xedn8izv867w2nR/wJstqcei0KyfDQ22rA gY/XA4Zm+D71ie0sj3pVz/kXH1UwNce3Af36WR1UKiz8ktDYxajlIRH7TWrAnhXLjiGz UkK0MObKYKMcKormIKUOdXT8JIXtjKngVY7YHCtDKyuu+2JXiXMCx1r5Kr3Eahnc76W3 H+OmyHSNzWDZQiYS1lJrKgFLuvFVfaY+wCHIWIhy4w0RWAqTtbQBiMBesOxh5P/58YZD 5dAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=mdHeWv0B3/tMyhBE9ZB8sjNcuRBGkqEoiWe/K/cvJdA=; b=nH1rhzDHu8MIDXrkhOkDxb90fwV0ZFxtKOInCSNbwnFhOYMsU0wvtlZsAKO2MCFB+C YL2OftKv1uZ6SeFkklw98ZeADl/Yu+uVucCcQC3yfjaXVkerPkS7gtaWC+0M15cUQ7Jn S316ni5SyZtAoxIvqpCMq2sfZutW5cJ+B8dIPGVAVdiZKjO3rwJgWXzAEtruka5s5Xug jPumDg+w0ugz+J9vJU/MqmmwWh68Yfj9jcbkXKJZaVLiWnINvhSpaqcj1n2PBhrsjM8i ml5qjfFHdT48WvP+PWh8P2AQO1yjArWUb2IFGfO/oabzHmy9ZHcpoqsP0cw27jnhQ+T0 dxIw== X-Gm-Message-State: AOAM530ZL5h5iNIRmk7/BX4UQQgL0RP7wy8cqNpOdu7M3x8VzwM1S89C k7IZFI7h/PfsqkaPfCT4Bgc= X-Google-Smtp-Source: ABdhPJyQEGlCa0VeV44dfhyNty0GNS7s5Ciqa9YSHxbE4ldWY10OCgL+qHU8eJDjPmd8jup/gwHgsg== X-Received: by 2002:a62:1713:0:b029:1f1:56e2:8ec6 with SMTP id 19-20020a6217130000b02901f156e28ec6mr1334638pfx.56.1615929688073; Tue, 16 Mar 2021 14:21:28 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Christopher Clark Mime-Version: 1.0 (1.0) Subject: Re: Working Group for Secure Boot Date: Tue, 16 Mar 2021 14:21:25 -0700 Message-Id: <967E23A4-A194-4C3B-98ED-2B6510FDE5FB@gmail.com> References: Cc: Xen-devel , Andrew Cooper , George Dunlap , piotr.krol@3mdeb.com, Olivier Lambert , Trammell Hudson , =?utf-8?Q?Marek_Marczykowski-G=C3=B3recki?= , "Daniel P. Smith" , Jan Beulich , =?utf-8?Q?Roger_Pau_Monn=C3=A9?= , Roman Shaposhnik In-Reply-To: To: Bob Eshleman X-Mailer: iPhone Mail (18D52) > On Mar 16, 2021, at 12:43 PM, Bob Eshleman wrote= : >=20 > =EF=BB=BFHey everyone, >=20 > I think most who are interested have acked the thread at > this point and I've CC'd everyone (please add anyone if > I've missed them). Hi Bobby, Please add me to your list too - this will be interesting work! >=20 > I'd like to suggest we have a first group call to > set out an agenda, define scope, and start identifying > the direction the project would like to go for secure > boot. >=20 > I'll prepare the call similar to how > community calls are handled, with a public cryptpad > for agenda items and such. >=20 > Which of these dates work best for you? Which absolutely > do not work? >=20 > Mon. March 29th, 16:00 UTC > Wed. March 31st, 16:00 UTC > Mon. April 5th, 16:00 UTC >=20 > Given the Xen community call is at 16:00 UTC, I figure > that probably best captures our geographic spread. Feel > free to suggest alternative dates/times if none of the > above work. I appreciate the time of day choice and can be available for whichever of th= ose is chosen. Thanks! Christopher=20 >=20 > We can host the meeting on Jitsi which works quite well > from any web browser. I'll send out a invite link when > we've decided on a suitable date and time. >=20 > Thanks. >=20 > --=20 > Bobby Eshleman > SE at Vates SAS >=20 From xen-devel-bounces@lists.xenproject.org Tue Mar 16 21:40:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 21:40:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98484.186841 (Exim 4.92) (envelope-from ) id 1lMHPy-0007jH-Iq; Tue, 16 Mar 2021 21:39:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98484.186841; Tue, 16 Mar 2021 21:39:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMHPy-0007jA-Fo; Tue, 16 Mar 2021 21:39:58 +0000 Received: by outflank-mailman (input) for mailman id 98484; Tue, 16 Mar 2021 21:39:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMHPw-0007j5-S0 for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 21:39:56 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c7b30479-ee19-4c55-a02b-8503332b00b9; Tue, 16 Mar 2021 21:39:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7b30479-ee19-4c55-a02b-8503332b00b9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615930794; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=psAzulsjRhOdgca3K5DwGIP3hRqcLknZvmmtUbFh/S8=; b=BtEzG+UDJEie2pO37hlDIwOjO1O4dhGOEJt3m2wSw4CkvEpZ2Fftyb4k 5wA/ZQ3nfESTxtqEdlPPJz81nl1He8D+J+h7JpmUZYrLsTcXJX9AXuINw +X8u6Sk/pNi/uZrWGKXlUgOZdl9MajXQAwunPP97WCYCQ0SfEAMwrNaPA o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 2dxl6zPrUAz05Al3q24hHSMinsC0AoRo0Wf4DMR9QUpKgnoXc5jPUZgQRudmZj2d/GoZP4A3sZ Hpp0J3TOaiso8sQ728znVPUVhFfgUKBK5lDW6J49rdbCybHP+5G9P+4HG7xMMiVqSEoyhUs5cd qYgvpmt9fMcIdPA4CHZcWToIfhfyxu9WNJ4sgEmVQRnF+8laP6W1MAH+dC63NG+84JHZHlxxay 51YFezH6fCZJlQHpv8C1gFDZEHSZ2WGx2wHVyWDsXivNzgUbhX1IhzhRS/1vEExJO2qHQfVlY/ f7E= X-SBRS: 5.2 X-MesageID: 39450767 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:wNK8Qqmoby/K98HdIz1Y3IpbweDpDfOBj2dD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLN/AZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 tdWoBEIpnLAVB+5PyW3CCRD8sgzN6b8KqhmOfZyDNXQRt3brx7hj0ZNi+wOCRNNW17LLA+E4 eR4dcCgjKmd2geYMjTPAh7Y8HoodrXmJX6JSMcDxk85wWUyR+u4rj2Ex+Xty1uLw9n67Ek7G TDjkjF9ryu2svLtyP0+k3yy9BtmNXnwsZeH8DksKYoAxjllwrAXvUYZ5SspzYwydvfjmoCsN 6JmBs4OtQ21nW5RBDOnTLI+y3NlAkj8GXjz1jwuwqRneXcSCghA8RMwaJ1GyGpknYIh9133K JV02/xjfM+Znmh7UeNkuTgbB1kmlG5pnAvi4co/htieLATdaNLqsgn9F5Vea1wbB7S0pwtE+ VlEajnlZRrWG6dBkqp21VH/MahRTAaEBuAXyE5y7eo+gkTtnV4w0wE/dcYj3cN+bksIqM0lt jsA+BGkqpDQdQRar84LOAdQdGvAmiIeh7UNnmOSG6XW50vCjbokdra8b817OaldNghy4Yzoo 3IVBd9uXQpc0zjJMWS1PRwg17waVT4eQ6o5tBV5pB/tLG5bqHsKze/RFcnlNbli+kDA+XAMs zDe65+MrvGFy/DCIxJ1wrxV915Mn8FSvAYvd49Rhanvt/LEIv3rebWGcyjZIbFIHIBYCfSE3 EDVD/8KIFr9UawQEL1hxDXRjfDYUr60ZVsELXL3uQaxYQXX7c89zQ9uBCc3IWmODdCuqs5cA 9VO7X8iJ62omGw4CLp4gxSS15gJ3cQxI+lf2JBpAcMPU+xW60Eoc+jdWdb22bCAhd+SsjRAT NOvlgfw9PxE7WggQQZT/63OGOTiHUe4FiQSY0Hp6GF7cD5PrQ1E4ghQ640MQnQDRR6lUJLpQ 54GU45b36aMgmrpbSujZQSCu2aXcJ7mh2XLcldrm+ak16dq8EpTn4yRCWvTsaTvAYrS1Nv9x 9M2p5apIDFtSekKGM5juh9GkZLcn6rDLVPCxnAWJ9ZgYnxeAZ7TX6DgBuTjx1bQButy2wiwk jaaQGEc/DCBVRQ/lRVyLzj/l9PemKBRE5ocXxhvYphFWPJh2Zr3YawF9iO+lrUTmFH7vAWMT nDbzdXGA9oytyt/DO+mTqJFxwdt98TF92YKI5mX6DY23urJoHNqLoPGOVM+o15cPr0tPUQbO 6ZcwiJDT/xBu8zwTaJrnI9NCQckgh8rdrYnDneqESo1n82BvTfZGl8T7YAOteG8izKQe2L3J gRt6N9gcKAdkHKLviIxqHcY2Qddlf9oWuqQ/oprp4Rl6Qor7d3F4TaVzyN9Hwv5mRIEO7E0G clBIJ86/T9H6UqWeo4USdQ5EAom9SCN1FDiH28PsYOOXUWy0bGNNaI6YfSobUhAke9tBL9UG PvhxF1zrPgZW+/zrYUBKI7HHROZGU94Hpk+vmed4e4MnTdS8hzuH67OGS6arlTVeysHqgRtA 9z57iz7qKqXhu9/ADbpj1gJK1St06hXMOpGQqJXcpF6cazN1jJoqyk5qeI/XvKYAr+T0QTno tec0MMKuxFlzk5lYUylhGIdZafmDNsr3JupRd9llDs3YC64GDUWWF+WDep/Kl+bH10KXiHjc PM7O6C8m/yiQI1gaX+KA== X-IronPort-AV: E=Sophos;i="5.81,254,1610427600"; d="scan'208";a="39450767" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hV+rIKrevz2HFu08pQ2uKr+ylkWn0XDBevc/HymYbt43XL/XiqYfWYsIPCh5P5d14wUjgPAJ5ZB6y2WvjnH258y1myfU1kx7MtEbbXF7gQ1FemgIvVDBec29XLFBlFyvy+0rMjTmeEnDzgj8BgjZkc23aglt3LAQta7QV+LSa1cLObaLP1xMJIGYwdvptI36Wvoh5DRMXXl05dLMl1rIfnZFHHVlxFulJkxPx0S8W66//6+cKDcZcN7W8zSkCcwvji4e8E4c2/equ2NfNVTPgLQsPtVVJw7HisyYlBewuibyVzqZ/mJqYMfpRJY26v3vBI+OqrkXpv4BonXTAC4eiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2XXqKxyPLYZ/kelmn64GroWCplbQONPCQMoe2hUTVcA=; b=I/SaScaB/XrBoEKdTbXBEdqjOspdhEDeoLCnm94Poi1GHsg1QqxmL1UKJ466EihAJ357mu35yoLglu3xBkw3Q1x5L6J8nTp2JoX00N8O0xwW0MGe6OCCWL1TrakmLBkRtoWq2wx24Tyh9S8YT6rdDc1+p85OEAlG8MPDMyGnyGONjS5EacYQTLVmotof/FSojUQBMlI2wAZZpAZ3mF6FGw184fCVkIYj9NZTcluN9PxOJjCtlDgj3iQjN2ZtJzMWMdeSaaqG8xOFQXQtEhTUCynaMMyJEYybOp2buwc/4s5zbwxQ4Sd0R+Br/B3SioI9/V85UNIW88JW+KVLYOE3/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2XXqKxyPLYZ/kelmn64GroWCplbQONPCQMoe2hUTVcA=; b=EQLRpEYZOWca02foL6F2edNOqYpKULBvAo10iqT1KynvM0QF9BpOeSa0QdN+ovUt12JjM5gZZu20bVEt3yxyaFykQGP6FFRvid3KkDoH+P69855j6iMmPb8xp23zEDI2HwDvFvdpswFQAyF8UJgSc2o/bsRS6UFSFEedDVoo9Es= Subject: Re: Working Group for Secure Boot To: Bob Eshleman , Xen-devel CC: George Dunlap , , Olivier Lambert , Trammell Hudson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , "Daniel P. Smith" , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Roman Shaposhnik References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> <1039be05-cbf2-95aa-5eba-246fb06be8e5@gmail.com> From: Andrew Cooper Message-ID: Date: Tue, 16 Mar 2021 21:39:21 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0304.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::28) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fdcea5be-ef46-440d-2d28-08d8e8c3f95b X-MS-TrafficTypeDiagnostic: BN6PR03MB2418: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h0VkaHuZkgi26U1kwaySxe4k/eshKM5Dy8GV3gOaAwIxeY0FtqLFlat1zmu2tUVSG+kjrcRRKqXcxOczEDfDsb61+/X1JWHA/ZF5+pDOZTMnvblU5OcqM3nHfeJ6OTjbmLJkg+yfTfwccyC5tw7DtIP7tCZ8vF+cYjk9YQwcs9Qu2ah0wG4Pqa9YJyWJ1s4XWNOyPTNVnbHW+ZaL/9Q0TpzqEV1VQa2paHhOi9uZSN9q3ZnDoTloFVd6IK1tEhJDi7j5Ac3AKmkGY3TgC+Hk1D2rgAZlt1atbBZD3ivuLdyanCo2Hwc5VoeubOi0FM373p3bEZI8ezcPSpwAJVUKjf7JmdaAeMxCUBhMTPYY45Gp1JVMRSAjwqLYTK44eYnnlfWdABFmnJlWotIb1AhDqACYaU/ORwjMw9ao5pccwPR+us9z+5WN+uqMrVsy2Uv7Dvhn81wcNwYPmBmsmILUlwe2Gw0TjMcMFRwrQLo3+NQ19BXcRghvyCNtPxJvaa+LcJKqGfN0mncPZgHa4l/MCkdDh0vBK2QkP5AILPUTlJlz04RiCFMUUNp6HctyVqNqm2A+57QcRajiYWev3M3PVBCaVVqZsp7SEE9mCRPf/7yWYwEdsgH0YheQF/IucPktCFfc3Udl6wXJg/K4y98dxw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(346002)(39830400003)(396003)(136003)(8676002)(31696002)(2616005)(16576012)(66556008)(66476007)(86362001)(6666004)(36756003)(66946007)(31686004)(110136005)(6486002)(54906003)(53546011)(4326008)(558084003)(478600001)(26005)(186003)(16526019)(2906002)(8936002)(316002)(5660300002)(956004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dW02ajAwNUN5TGZEZjdxZFlIMFdsSm5KY0lwNzdFRHdCNVlRQy9UMEpJdWRL?= =?utf-8?B?T2VqSW9lby9nU1IybHJHRTZCNnRZVEF5MXBEUWUrdmtsQ09jYS92dmR1TmMv?= =?utf-8?B?ZmhBRm9JZVU3Sm91WDBoMEpROFBlbGZ2TVMzbWgrdnhtK1l5S0hySHNTSncz?= =?utf-8?B?bHI1TE4yZmlSdCtMTHhXbHJSOHJOOWlpN2RmblhYZVJ6WlE5cmlYZktoeGMz?= =?utf-8?B?UVZHUWxpN1NaYkZKSkNJZUV2c3dkNUJTS2ZLWlAxdTl4cUZRTnJEZlFGZ1FZ?= =?utf-8?B?OHNyV1ZISUhVb0wvUlowNGU0Ly9LMXdBMVNQY1ZDa0pxdHVXQ2U4T1dmNW9R?= =?utf-8?B?M2VBaXZVb2RFQXZZS2xSMkVQZVA4dUphZ0VNdkt4eEdudUo4bndPbWVxU2dV?= =?utf-8?B?OERIZ2tKUjQrTzJKV3lobHpMOWFFcnU0R2lhaTNzbXFTRi9ieHlCMDJPeFlQ?= =?utf-8?B?dUZvZzRaZ1l2bHMwVTVpVjZXcUVPQ3lScmw5WG9CUmNXek44akRSZFNRZjFx?= =?utf-8?B?aWkreXN2UEpYUFp5cEVSZ01jRjBFaXlFTko0UTRDRTU2RTdBTEt5bXZCZk5L?= =?utf-8?B?UmtER2t2Z1dsSkQxQmRnaUhCbzBJWXY1Y2lYQ2NOU0FKNEoxUnhqcWl0OWJN?= =?utf-8?B?TWROM3hSOHBzZkdqb0h6cVlsd3dpWWZJYU1sZWEzNEFNRTBIK3RJb3ZZV1lw?= =?utf-8?B?dFI1OWdidEMraFhmcEcwRU9oSDdDQVdEY0R5bkJQU2twbmt2dGJJTzlZZW1X?= =?utf-8?B?MWt1cjkrUVc3S1JKNXIxQTdhVzdONGtYRWtrcGgwVGNzYVg5dmNlQUZnRGJF?= =?utf-8?B?aTlRZ3REMW4rekc5alo5alIrL3N3YnVhRXhWd1JudmhMMlJXR3RJRUZ1U0ZN?= =?utf-8?B?Sk1PZjFoR3lhUk1XNFJneGdWa3JWemdVRzgzYnpGdmpXby9NWTE0WHNIMzJr?= =?utf-8?B?YkJydWNudFFYbEJoTFd1NGJ1amliSXlmangwNzlFbCtkWG4ya016eVBwdnBn?= =?utf-8?B?VjdLazArbldab1FTMlNrQnFKM3FKbzlZUDRjMVVGcFBnaTFNRWtERzNpd1Bo?= =?utf-8?B?cHhPeU1aMzlWU3oyTVNleGRFeENiVlQ3WkxWYUQ3bHduZDVaMVFIRjUydXhL?= =?utf-8?B?WHZUTFdIdFo3Uk1SN2ord2QwWmhCWnFaZTVSQzhKVGJueURjZ1FSWktHT0VD?= =?utf-8?B?Y0xwUjVBaS9OMm5qMmUwR3lsTDN5ZHRjVTJDZHZGeS9SOXljZUhCcGpNc0c5?= =?utf-8?B?aDFkU3JmYXpDK3E4RXFibThMQUNDOFI2ejZteWMxdXUrQU9FNTV0bVNmZzRU?= =?utf-8?B?cnRQTGhUL0VWMjdMR2JuWVVtUUp5ZU96UVZMaENwWm1JQmJOM0psL29qdis1?= =?utf-8?B?NmdXdE0zRWdHSXJtOTFhb0UyZWFKWmkvYzVwMWFNUlBlUGFiSWNBTTNYdk9G?= =?utf-8?B?L3FTQVlDMFlZekNMYlJkem1YMUhDa3hUblBHVUtRdXlKbE9FQXVrallScEpl?= =?utf-8?B?SXRGand5NU5UbWtHS3h3VGs3dDJOeTRFTzRpSXJ6dHFSNVBaYmxLT056MWRk?= =?utf-8?B?Tm5XaGR3czdESU9NMWJTRFFDWGp0U2x3aEZyZEI5UThpMUFYSzFGV3R3Vk9j?= =?utf-8?B?Nm1mU1BQMmttZ2dHM2xmVU90SUN6VjB0dnluVHoxaGEvNnpRd1Jrd21QNVlV?= =?utf-8?B?cFFsd2FlakdKSVBjcVpTRDNlNkhGSDdiRFpZSlA3bFdXODc5ekRVWWVXNDBa?= =?utf-8?Q?0Z8+dj2MHjkEJ/YPeKgyqtwtLc1I9A5fYr1Wemn?= X-MS-Exchange-CrossTenant-Network-Message-Id: fdcea5be-ef46-440d-2d28-08d8e8c3f95b X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 21:39:27.4343 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3piA45U5vweTGYJlbEMBRqY5nCN4BjhRMYlfDM6RQeRgokfaaJAcvTZ9D6Hr9LJ4RVpQnZSSUNRO3So05dm1gJiEWF2P1FqlyV9FR/bH5dY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2418 X-OriginatorOrg: citrix.com On 16/03/2021 19:42, Bob Eshleman wrote: > Which of these dates work best for you? Which absolutely > do not work? > > Mon. March 29th, 16:00 UTC > Wed. March 31st, 16:00 UTC > Mon. April 5th, 16:00 UTC All fine by me.  Thanks, ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Mar 16 21:59:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 21:59:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98487.186854 (Exim 4.92) (envelope-from ) id 1lMHj0-00016w-9p; Tue, 16 Mar 2021 21:59:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98487.186854; Tue, 16 Mar 2021 21:59:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMHj0-00016p-6D; Tue, 16 Mar 2021 21:59:38 +0000 Received: by outflank-mailman (input) for mailman id 98487; Tue, 16 Mar 2021 21:59:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMHiy-00016h-Gq; Tue, 16 Mar 2021 21:59:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMHiy-0004q7-8Z; Tue, 16 Mar 2021 21:59:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMHix-0002Xm-OZ; Tue, 16 Mar 2021 21:59:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMHix-0006mp-Nf; Tue, 16 Mar 2021 21:59:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QnaCZqS/xJnu4dZ9cz1zDYW8fVH2RrGS25Qv9HLkgYA=; b=jctLM8h1f0xg5KpkYg/6PqgEpK GQ8z6eYeTeVYDMJGszF6gb3dvPxZatSHtQZN2cotgMX2qQNNli2SJjZGqur6FUmVtyTgI2fuEEwN/ ZBiFy3aS4KGRJCdWc1wsbFZGsH0uzIYvqjuzAr/ZC189DbOTrsNKHYcohCPZTpV8m4h0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160097: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=2615a5e433aeb812c300d3a48e1a88e1303e2339 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Tue, 16 Mar 2021 21:59:35 +0000 flight 160097 qemu-mainline real [real] flight 160102 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160097/ http://logs.test-lab.xenproject.org/osstest/logs/160102/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 2615a5e433aeb812c300d3a48e1a88e1303e2339 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 208 days Failing since 152659 2020-08-21 14:07:39 Z 207 days 402 attempts Testing same since 160097 2021-03-16 10:10:00 Z 0 days 1 attempts ------------------------------------------------------------ 452 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 129410 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 16 22:03:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 22:03:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98492.186869 (Exim 4.92) (envelope-from ) id 1lMHmS-0001zS-RM; Tue, 16 Mar 2021 22:03:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98492.186869; Tue, 16 Mar 2021 22:03:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMHmS-0001zL-OM; Tue, 16 Mar 2021 22:03:12 +0000 Received: by outflank-mailman (input) for mailman id 98492; Tue, 16 Mar 2021 22:03:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMHmR-0001zF-JO for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 22:03:11 +0000 Received: from wnew3-smtp.messagingengine.com (unknown [64.147.123.17]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ededde26-63bc-4a44-8a85-7217511a7845; Tue, 16 Mar 2021 22:03:10 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 9604DE70; Tue, 16 Mar 2021 18:03:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 16 Mar 2021 18:03:09 -0400 Received: from mail-itl (ip5b434f04.dynamic.kabel-deutschland.de [91.67.79.4]) by mail.messagingengine.com (Postfix) with ESMTPA id D3179240054; Tue, 16 Mar 2021 18:03:05 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ededde26-63bc-4a44-8a85-7217511a7845 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=AoyIDT hAW8nctfMtr9MDZyqtoc2Z154bW8bqp9W1djU=; b=HgqUmXLdGz9/TIWV12kIAt t0fCLcsm73l9UUHiH5YSrNhvY9RSyyJPZ1XEIoTt8VnM8/c5K4Upowd+V+UUkzC/ /4vZkpS141NELeRJ6fpyU3qvcFZQOeYq5o7BeUB+GW6L+1VqKxNa15CCxrATXKEh NdPHAVVPBh793ReNtwvlbb8DQjY86GyLeLBZKhcrh2RTUjIT4BnOIGYq8q+7TtBG 3mxD2gddY7R70/mlQ7W0FW1MUYMA1Rfz0qswrozVsLdpM9RkXQWIEB0AoUQZmRSd tU7MBSLqD//cjT2pmtz8W4MSXh11DuPXUbI9Q2c5djhNZY1l2VHkvEj+KdyvZwCA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefvddgudehkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepteev ffeigffhkefhgfegfeffhfegveeikeettdfhheevieehieeitddugeefteffnecukfhppe eluddrieejrdejledrgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrd gtohhm X-ME-Proxy: Date: Tue, 16 Mar 2021 23:03:02 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Bob Eshleman Cc: Xen-devel , Andrew Cooper , George Dunlap , piotr.krol@3mdeb.com, Olivier Lambert , Trammell Hudson , "Daniel P. Smith" , Jan Beulich , Roger Pau =?utf-8?B?TW9ubsOp?= , Roman Shaposhnik Subject: Re: Working Group for Secure Boot Message-ID: References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> <1039be05-cbf2-95aa-5eba-246fb06be8e5@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7iZ1OBKMTPuvUzsU" Content-Disposition: inline In-Reply-To: --7iZ1OBKMTPuvUzsU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 16, 2021 at 12:42:26PM -0700, Bob Eshleman wrote: > Which of these dates work best for you? Which absolutely > do not work? >=20 > Mon. March 29th, 16:00 UTC > Wed. March 31st, 16:00 UTC > Mon. April 5th, 16:00 UTC All three works for me, with a slight preference to either Monday. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --7iZ1OBKMTPuvUzsU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmBRKxcACgkQ24/THMrX 1yz1ugf/TNaMrXLiC5cvIRllDpnJAYUgrtSqapxmKfwrUqY8gH//TAhAjF8Hdnp5 qfbmbenqla2s5bpJT5ln08v+mxpfGwNyZqCAMdXP1yAW1TQxjlcUqVAak2eidtLn WfNB8oDhbxrzHdv6/lS2OEkN8xfGvb8t7p9LDrhejD3UvCqleyrssf29we5p1r8b vH8Ow6d/RtEOAoC5zobMIGqR9ZaGBugwn5AWbUVfQ8355p+cb6mupEYWSdDh75Ix PeSu5Hxt88YKgS2Oq1QNx0tbHWyiFA9Z9Y8MwjQBZA2bLkClbRFWPRSacVvkBVyO dMTAevJ0qHxGA9ihuzAqUcTE4HM9Xg== =csJ1 -----END PGP SIGNATURE----- --7iZ1OBKMTPuvUzsU-- From xen-devel-bounces@lists.xenproject.org Tue Mar 16 22:45:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 22:45:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98500.186881 (Exim 4.92) (envelope-from ) id 1lMIQo-0005ZG-7r; Tue, 16 Mar 2021 22:44:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98500.186881; Tue, 16 Mar 2021 22:44:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMIQo-0005Z9-4o; Tue, 16 Mar 2021 22:44:54 +0000 Received: by outflank-mailman (input) for mailman id 98500; Tue, 16 Mar 2021 22:44:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMIQm-0005Z4-4M for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 22:44:52 +0000 Received: from mo6-p00-ob.smtp.rzone.de (unknown [2a01:238:400:100::c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id adefc1e6-a416-4f50-a526-02115ad17201; Tue, 16 Mar 2021 22:44:50 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.21.0 SBL|AUTH) with ESMTPSA id u08c13x2GMiZ7PY (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)) (Client did not present a certificate); Tue, 16 Mar 2021 23:44:35 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: adefc1e6-a416-4f50-a526-02115ad17201 ARC-Seal: i=1; a=rsa-sha256; t=1615934675; cv=none; d=strato.com; s=strato-dkim-0002; b=C8TXa5XeHZwpup6coS6Ybg7qt8dadA/Zj9g3e5yxRAxB9GS1QujHxMG7SQEDhL2O3c 3WoKVZfrIgAjeLpv8Q7nar2dj2lQGPmFfH4KQ3ASSA8Z5p6EybLpyb/ezEjxkZc2MO18 L8YuKYsOF7dYP0Jgxu5GAAenaiSCxyQrvADRsisH2cMlmxgVLim+IiK8py48WylCYFUW kCcJ7oHztZDyegmCP6niA3ZwdMnebpPgqcHtPwYPe33nW4wRV1USNl6KNEhv1j47u43l DwlFslkwR5EjiU9iF9Vg7AznqGoAAGJhojHLIy+0DTqhClrBNlDtPKLYSv0PoPQDQ+dJ NGDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1615934675; s=strato-dkim-0002; d=strato.com; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=spRfbSf2EEd/CxkfCsgqRwYK32rzUNZ5IzSUCc4F8sE=; b=jKWlsPcNfGCDI+0IerHjFkVQzPBra8OQHIasTlFP1nekmnqt6CYrKfQCXcsiC9PfHA UkzMgTilP08dMybzWXMgBalp90QOFFYTSqDpQl42JRRrOwXSf6a/iic8gefLwpKOuJLF bQ3uZUXOXWP5lL5jzoqxbG5iHJ69UwFvlNJiVjnxs8Jal5toYRbljyQwWmNV3DZSJBsa kDA+xbUtqrIo9FbXWiFgNs0Rjqqg4hH9ZaYd8alhd3MDd/wSDQAmDLsteGi+0Wdajbkc Mb/Pl6soIYWTbSNEopDhP3n44ATttcPK7QrHou9GSPOO7DmHN42YkG4clZBzw8P/rQmq 8F8w== ARC-Authentication-Results: i=1; strato.com; dkim=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1615934675; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=spRfbSf2EEd/CxkfCsgqRwYK32rzUNZ5IzSUCc4F8sE=; b=GaZSz3vCR8zScvKLRGoWsbMwqCisU0+job6YMkP9x6YBV/KZnjpPD+Xu/dAoZL8ivf +JVXzVjifdt3m/6ji5C88QrgXFou4bFB2VOGmK6zbXvSF6t4koqWVteOWSCieI1CMZLb Yz0c2zJ/ANzOvSmDDgd+uwNgPTX6k5ejLGZ3RE5g9pCyVRQsMIkFkzJFGYgiaXKz1Oyg XczVLBKYnQQ9H+DzsPm/vFA5kpJ5EB4mpPBQxFm1L4P5w8XFeC2wU0LISUMI4W3FFDUV ihT0ppn8mnNBPq4zoxiFCIR9Mun4Qdq5R0ewUcj3/RIdJesqkOsem5euD+If1TDeFsur /gtA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzBW/OdlBZQ4AHSS325Pjw==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org, qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Olaf Hering , John Snow Subject: [PATCH v1] piix: fix regression during unplug in Xen HVM domUs Date: Tue, 16 Mar 2021 23:44:12 +0100 Message-Id: <20210316224412.11609-1-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit ee358e919e385fdc79d59d0d47b4a81e349cd5c9 causes a regression in Xen HVM domUs which run xenlinux based kernels. If the domU has an USB device assigned, for example with "usbdevice=['tablet']" in domU.cfg, the late unplug of devices will kill the emulated USB host. As a result the khubd thread hangs, and as a result the entire boot process. For some reason this does not affect pvops based kernels. This is most likely caused by the fact that unplugging happens very early during boot. Signed-off-by: Olaf Hering --- hw/ide/piix.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index b9860e35a5..2a380a90e9 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -34,6 +34,7 @@ #include "hw/ide/pci.h" #include "trace.h" +static bool pci_piix3_xen_ide_unplug_done; static uint64_t bmdma_read(void *opaque, hwaddr addr, unsigned size) { BMDMAState *bm = opaque; @@ -109,6 +110,8 @@ static void piix_ide_reset(DeviceState *dev) uint8_t *pci_conf = pd->config; int i; + if (pci_piix3_xen_ide_unplug_done == true) + return; for (i = 0; i < 2; i++) { ide_bus_reset(&d->bus[i]); } @@ -169,6 +172,7 @@ int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux) IDEBus *idebus; BlockBackend *blk; + pci_piix3_xen_ide_unplug_done = true; pci_ide = PCI_IDE(dev); for (i = aux ? 1 : 0; i < 4; i++) { @@ -259,6 +263,7 @@ static const TypeInfo piix4_ide_info = { static void piix_ide_register_types(void) { + pci_piix3_xen_ide_unplug_done = false; type_register_static(&piix3_ide_info); type_register_static(&piix3_ide_xen_info); type_register_static(&piix4_ide_info); From xen-devel-bounces@lists.xenproject.org Tue Mar 16 22:49:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 16 Mar 2021 22:49:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98502.186893 (Exim 4.92) (envelope-from ) id 1lMIUy-0005m4-PS; Tue, 16 Mar 2021 22:49:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98502.186893; Tue, 16 Mar 2021 22:49:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMIUy-0005lx-MV; Tue, 16 Mar 2021 22:49:12 +0000 Resent-Date: Tue, 16 Mar 2021 22:49:12 +0000 Resent-Message-Id: Received: by outflank-mailman (input) for mailman id 98502; Tue, 16 Mar 2021 22:49:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMIUw-0005ls-HF for xen-devel@lists.xenproject.org; Tue, 16 Mar 2021 22:49:10 +0000 Received: from sender4-of-o53.zoho.com (unknown [136.143.188.53]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1cdb01bf-8e86-473b-b883-332da37dba4a; Tue, 16 Mar 2021 22:49:08 +0000 (UTC) Received: from [172.17.0.3] (23.253.156.214 [23.253.156.214]) by mx.zohomail.com with SMTPS id 1615934935641742.6421852983427; Tue, 16 Mar 2021 15:48:55 -0700 (PDT) Resent-From: X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cdb01bf-8e86-473b-b883-332da37dba4a ARC-Seal: i=1; a=rsa-sha256; t=1615934939; cv=none; d=zohomail.com; s=zohoarc; b=bV6BJdS970lmRrZADS3e8UrN1fwkr9UuhISi6DRU+IyX2yOgVCLy2mwKV1kNbgT3S5YnySG5jItaVZNP34sAHBCc/iwJptk3xeVChRV0ddB8DWZqblwIHyHdy/Ev1EuZQsoBPl6kJ2ioHtJrGB6OLZABZ5nZnNhYEMszmr5lFZU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615934939; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:Reply-To:Subject:To; bh=tF8oDA4fa83Iw7SEm+BG8QQkhZXDWl7Jec7f/Xk3zOg=; b=HvAeBi49Ca1dFLzo+4aBOqNd4VlsM2OSjdSTM+wahGQUKasJCKir9KyfTQiAhmaI0hHnWyCSdJrrX8z3rx2HVKoNKaFn1Ux2y3enoO2PZvFyeuIqBDifwscNZR9s78TjqI6qr4ZUZpU6zRHB0stwSVwqGwoO6mEgJjxnB8Gmors= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass smtp.mailfrom=no-reply@patchew.org; dmarc=pass header.from= header.from= In-Reply-To: <20210316224412.11609-1-olaf@aepfle.de> Reply-To: Subject: Re: [PATCH v1] piix: fix regression during unplug in Xen HVM domUs Message-ID: <161593493442.18566.14612876295503290944@c9d4d6fbb2f1> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 From: no-reply@patchew.org To: olaf@aepfle.de Cc: xen-devel@lists.xenproject.org, qemu-block@nongnu.org, qemu-devel@nongnu.org, olaf@aepfle.de, jsnow@redhat.com Date: Tue, 16 Mar 2021 15:48:55 -0700 (PDT) X-ZohoMailClient: External UGF0Y2hldyBVUkw6IGh0dHBzOi8vcGF0Y2hldy5vcmcvUUVNVS8yMDIxMDMxNjIyNDQxMi4xMTYw OS0xLW9sYWZAYWVwZmxlLmRlLwoKCgpIaSwKClRoaXMgc2VyaWVzIHNlZW1zIHRvIGhhdmUgc29t ZSBjb2Rpbmcgc3R5bGUgcHJvYmxlbXMuIFNlZSBvdXRwdXQgYmVsb3cgZm9yCm1vcmUgaW5mb3Jt YXRpb246CgpUeXBlOiBzZXJpZXMKTWVzc2FnZS1pZDogMjAyMTAzMTYyMjQ0MTIuMTE2MDktMS1v bGFmQGFlcGZsZS5kZQpTdWJqZWN0OiBbUEFUQ0ggdjFdIHBpaXg6IGZpeCByZWdyZXNzaW9uIGR1 cmluZyB1bnBsdWcgaW4gWGVuIEhWTSBkb21VcwoKPT09IFRFU1QgU0NSSVBUIEJFR0lOID09PQoj IS9iaW4vYmFzaApnaXQgcmV2LXBhcnNlIGJhc2UgPiAvZGV2L251bGwgfHwgZXhpdCAwCmdpdCBj b25maWcgLS1sb2NhbCBkaWZmLnJlbmFtZWxpbWl0IDAKZ2l0IGNvbmZpZyAtLWxvY2FsIGRpZmYu cmVuYW1lcyBUcnVlCmdpdCBjb25maWcgLS1sb2NhbCBkaWZmLmFsZ29yaXRobSBoaXN0b2dyYW0K Li9zY3JpcHRzL2NoZWNrcGF0Y2gucGwgLS1tYWlsYmFjayBiYXNlLi4KPT09IFRFU1QgU0NSSVBU IEVORCA9PT0KClVwZGF0aW5nIDNjOGNmNWE5YzIxZmY4NzgyMTY0ZDFkZWY3ZjQ0YmQ4ODg3MTMz ODQKRnJvbSBodHRwczovL2dpdGh1Yi5jb20vcGF0Y2hldy1wcm9qZWN0L3FlbXUKIC0gW3RhZyB1 cGRhdGVdICAgICAgcGF0Y2hldy8yMDIxMDMxMTE0Mzk1OC41NjI2MjUtMS1yaWNoYXJkLmhlbmRl cnNvbkBsaW5hcm8ub3JnIC0+IHBhdGNoZXcvMjAyMTAzMTExNDM5NTguNTYyNjI1LTEtcmljaGFy ZC5oZW5kZXJzb25AbGluYXJvLm9yZwogKiBbbmV3IHRhZ10gICAgICAgICBwYXRjaGV3LzIwMjEw MzE2MjI0NDEyLjExNjA5LTEtb2xhZkBhZXBmbGUuZGUgLT4gcGF0Y2hldy8yMDIxMDMxNjIyNDQx Mi4xMTYwOS0xLW9sYWZAYWVwZmxlLmRlClN3aXRjaGVkIHRvIGEgbmV3IGJyYW5jaCAndGVzdCcK OWI3ZWMwZiBwaWl4OiBmaXggcmVncmVzc2lvbiBkdXJpbmcgdW5wbHVnIGluIFhlbiBIVk0gZG9t VXMKCj09PSBPVVRQVVQgQkVHSU4gPT09CkVSUk9SOiBicmFjZXMge30gYXJlIG5lY2Vzc2FyeSBm b3IgYWxsIGFybXMgb2YgdGhpcyBzdGF0ZW1lbnQKIzQxOiBGSUxFOiBody9pZGUvcGlpeC5jOjEx MzoKKyAgICBpZiAocGNpX3BpaXgzX3hlbl9pZGVfdW5wbHVnX2RvbmUgPT0gdHJ1ZSkKWy4uLl0K CnRvdGFsOiAxIGVycm9ycywgMCB3YXJuaW5ncywgMjkgbGluZXMgY2hlY2tlZAoKQ29tbWl0IDli N2VjMGZlNWQ3YyAocGlpeDogZml4IHJlZ3Jlc3Npb24gZHVyaW5nIHVucGx1ZyBpbiBYZW4gSFZN IGRvbVVzKSBoYXMgc3R5bGUgcHJvYmxlbXMsIHBsZWFzZSByZXZpZXcuICBJZiBhbnkgb2YgdGhl c2UgZXJyb3JzCmFyZSBmYWxzZSBwb3NpdGl2ZXMgcmVwb3J0IHRoZW0gdG8gdGhlIG1haW50YWlu ZXIsIHNlZQpDSEVDS1BBVENIIGluIE1BSU5UQUlORVJTLgo9PT0gT1VUUFVUIEVORCA9PT0KClRl c3QgY29tbWFuZCBleGl0ZWQgd2l0aCBjb2RlOiAxCgoKVGhlIGZ1bGwgbG9nIGlzIGF2YWlsYWJs ZSBhdApodHRwOi8vcGF0Y2hldy5vcmcvbG9ncy8yMDIxMDMxNjIyNDQxMi4xMTYwOS0xLW9sYWZA YWVwZmxlLmRlL3Rlc3RpbmcuY2hlY2twYXRjaC8/dHlwZT1tZXNzYWdlLgotLS0KRW1haWwgZ2Vu ZXJhdGVkIGF1dG9tYXRpY2FsbHkgYnkgUGF0Y2hldyBbaHR0cHM6Ly9wYXRjaGV3Lm9yZy9dLgpQ bGVhc2Ugc2VuZCB5b3VyIGZlZWRiYWNrIHRvIHBhdGNoZXctZGV2ZWxAcmVkaGF0LmNvbQ== From xen-devel-bounces@lists.xenproject.org Wed Mar 17 00:05:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 00:05:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98511.186905 (Exim 4.92) (envelope-from ) id 1lMJgK-0004ry-2N; Wed, 17 Mar 2021 00:05:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98511.186905; Wed, 17 Mar 2021 00:05:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMJgJ-0004rr-Uq; Wed, 17 Mar 2021 00:04:59 +0000 Received: by outflank-mailman (input) for mailman id 98511; Wed, 17 Mar 2021 00:04:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMJgI-0004rm-Dz for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 00:04:58 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 44b7673d-d745-40cc-8663-734e1f22fe6e; Wed, 17 Mar 2021 00:04:57 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 1BC0E64F8F; Wed, 17 Mar 2021 00:04:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44b7673d-d745-40cc-8663-734e1f22fe6e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615939496; bh=MLQeIxWmuOOSLEldExy57QoNjB2H7psugvKU3Qv2uFc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=m2YPxi5XFjgfd4Vp6vFggYOV1lxm1wheRPQcUPpMJcydEzW7r5c4XXsCd2RJ/gbr+ uDePLcW2XvPh2axQSe++64MiUaX3iQQD5cDiySXrwNuE6iF4QJT0iRRZCST4i13rRA Uqw4a2LpivrZgZ2bI6dPzBD9jPfg7EHcGGaq0R1tRbO2VTNqM8ZQLjjjJIHnB4mDkY SyAjyEQ4BFJflHT+KgCXjnDwPWI/YS6nHE5f1JIKi8UiDiO363jphOfO01AfM31tDV wo8bHLBU/hqQVAFH6+KjEoTwR2uy8fb5rnH44e/EmKNaJ3h0fYQFwS4ImCUT5mh/gp QP0dKplBuLtlw== Date: Tue, 16 Mar 2021 17:04:48 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich cc: Stefano Stabellini , andrew.cooper3@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3] xen: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped In-Reply-To: <48a7ea93-06b4-21f1-5db2-0104058a2446@suse.com> Message-ID: References: <20210312231632.5666-1-sstabellini@kernel.org> <0e35a613-fd93-0805-10b9-5ecee73bb15d@suse.com> <48a7ea93-06b4-21f1-5db2-0104058a2446@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 16 Mar 2021, Jan Beulich wrote: > On 15.03.2021 21:01, Stefano Stabellini wrote: > > On Mon, 15 Mar 2021, Jan Beulich wrote: > >> On 13.03.2021 00:16, Stefano Stabellini wrote: > >>> Introduce two feature flags to tell the domain whether it is > >>> direct-mapped or not. It allows the guest kernel to make informed > >>> decisions on things such as swiotlb-xen enablement. > >>> > >>> The introduction of both flags (XENFEAT_direct_mapped and > >>> XENFEAT_not_direct_mapped) allows the guest kernel to avoid any > >>> guesswork if one of the two is present, or fallback to the current > >>> checks if neither of them is present. > >>> > >>> XENFEAT_direct_mapped is always set for not auto-translated guests. > >>> > >>> For auto-translated guests, only Dom0 on ARM is direct-mapped. Also, > >>> see is_domain_direct_mapped() which refers to auto-translated guests: > >>> xen/include/asm-arm/domain.h:is_domain_direct_mapped > >>> xen/include/asm-x86/domain.h:is_domain_direct_mapped > >>> > >>> Signed-off-by: Stefano Stabellini > >>> CC: jbeulich@suse.com > >>> CC: andrew.cooper3@citrix.com > >>> CC: julien@xen.org > >> > >> Any particular reason my previously given R-b isn't here? > > > > I reworded part of the comment in the public header, and I decided to > > err on the side of caution and not add your R-b given this change > > compared to the previous version. > > I see. FAOD, despite me not being overly happy with the "older > Xen assumptions" part of the comment, feel free to add it back. Thank you! Julien, please go ahead and commit it to your for-next/4.16 branch when it is convenient. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 00:09:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 00:09:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98515.186917 (Exim 4.92) (envelope-from ) id 1lMJkH-00054m-Jo; Wed, 17 Mar 2021 00:09:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98515.186917; Wed, 17 Mar 2021 00:09:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMJkH-00054f-Gh; Wed, 17 Mar 2021 00:09:05 +0000 Received: by outflank-mailman (input) for mailman id 98515; Wed, 17 Mar 2021 00:09:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMJkG-00054a-VM for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 00:09:04 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c738ce73-60f2-48a3-83a5-965096ff78d8; Wed, 17 Mar 2021 00:09:04 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9AB4660190; Wed, 17 Mar 2021 00:09:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c738ce73-60f2-48a3-83a5-965096ff78d8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615939743; bh=2TdN+1rPBXOeK4/pa9Coxhp8QtlR4qU/uSvCQV6kvKs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=MGWyw9hB+LzxGgAtA0bRIz2bH4bUZvX9RgjMHQF+hJDzZsgxqzoEdastDy6Wwb7CY FLVFGywpLKVnFmPMa+MuWrJB9tZmNjWldRxCvTK51G5MrDVj9O4q//otddZaSMdy1j 02soG5VkYxjiVhW7C1SO800g2zj4LX+EHu3EVTi7AiBZdmROV4UorjqZr6jr+yt9hv ye8dnTpYJ0LZtrD+EKmMMkhmA5Q0eV9HG/BVwy5vW7zdNxYvXDKen/jjMclOYgyHMz jsykehwf3R0DUg1PhI2QxXISwge011jDvIBTMNpkl0KRkOrADwxqlLPg1VXVaqTJR1 tMxyml7YkEdkw== Date: Tue, 16 Mar 2021 17:09:01 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Stefano Stabellini cc: jgross@suse.com, boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org, Stefano Stabellini Subject: Re: [PATCH] xen/arm: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped In-Reply-To: <20210225235158.24001-1-sstabellini@kernel.org> Message-ID: References: <20210225235158.24001-1-sstabellini@kernel.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Gentle ping, now that the Xen side is acked (not committed due to the imminent release): https://marc.info/?l=xen-devel&m=161559099506456 On Thu, 25 Feb 2021, Stefano Stabellini wrote: > Newer Xen versions expose two Xen feature flags to tell us if the domain > is directly mapped or not. Only when a domain is directly mapped it > makes sense to enable swiotlb-xen on ARM. > > Introduce a function on ARM to check the new Xen feature flags and also > to deal with the legacy case. Call the function xen_swiotlb_detect. > > Also rename the existing pci_xen_swiotlb_detect on x86 to > xen_swiotlb_detect so that we can share a common function declaration. > > Signed-off-by: Stefano Stabellini > --- > > This is the corresponding Xen patch under review: > https://marc.info/?l=xen-devel&m=161421618217686 > > We don't *have to* make the x86 function and the ARM function exactly > the same, but I thought it would be much nicer if we did. However, we > can't really call it pci_* on ARM as there is no PCI necessarily. > > --- > arch/arm/xen/mm.c | 14 +++++++++++++- > arch/arm64/mm/dma-mapping.c | 2 +- > arch/x86/include/asm/xen/swiotlb-xen.h | 4 ++-- > arch/x86/kernel/pci-swiotlb.c | 2 +- > arch/x86/xen/pci-swiotlb-xen.c | 6 +++--- > include/xen/interface/features.h | 7 +++++++ > include/xen/swiotlb-xen.h | 6 ++++++ > 7 files changed, 33 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c > index 467fa225c3d0..f8e5acbef05d 100644 > --- a/arch/arm/xen/mm.c > +++ b/arch/arm/xen/mm.c > @@ -135,10 +135,22 @@ void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order) > return; > } > > +int __init xen_swiotlb_detect(void) > +{ > + if (!xen_domain()) > + return 0; > + if (xen_feature(XENFEAT_direct_mapped)) > + return 1; > + /* legacy case */ > + if (!xen_feature(XENFEAT_not_direct_mapped) && xen_initial_domain()) > + return 1; > + return 0; > +} > + > static int __init xen_mm_init(void) > { > struct gnttab_cache_flush cflush; > - if (!xen_initial_domain()) > + if (!xen_swiotlb_detect()) > return 0; > xen_swiotlb_init(1, false); > > diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c > index 93e87b287556..4bf1dd3eb041 100644 > --- a/arch/arm64/mm/dma-mapping.c > +++ b/arch/arm64/mm/dma-mapping.c > @@ -53,7 +53,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size, > iommu_setup_dma_ops(dev, dma_base, size); > > #ifdef CONFIG_XEN > - if (xen_initial_domain()) > + if (xen_swiotlb_detect()) > dev->dma_ops = &xen_swiotlb_dma_ops; > #endif > } > diff --git a/arch/x86/include/asm/xen/swiotlb-xen.h b/arch/x86/include/asm/xen/swiotlb-xen.h > index 6b56d0d45d15..494694744844 100644 > --- a/arch/x86/include/asm/xen/swiotlb-xen.h > +++ b/arch/x86/include/asm/xen/swiotlb-xen.h > @@ -2,14 +2,14 @@ > #ifndef _ASM_X86_SWIOTLB_XEN_H > #define _ASM_X86_SWIOTLB_XEN_H > > +#include > + > #ifdef CONFIG_SWIOTLB_XEN > extern int xen_swiotlb; > -extern int __init pci_xen_swiotlb_detect(void); > extern void __init pci_xen_swiotlb_init(void); > extern int pci_xen_swiotlb_init_late(void); > #else > #define xen_swiotlb (0) > -static inline int __init pci_xen_swiotlb_detect(void) { return 0; } > static inline void __init pci_xen_swiotlb_init(void) { } > static inline int pci_xen_swiotlb_init_late(void) { return -ENXIO; } > #endif > diff --git a/arch/x86/kernel/pci-swiotlb.c b/arch/x86/kernel/pci-swiotlb.c > index c2cfa5e7c152..c18eb6629326 100644 > --- a/arch/x86/kernel/pci-swiotlb.c > +++ b/arch/x86/kernel/pci-swiotlb.c > @@ -30,7 +30,7 @@ int __init pci_swiotlb_detect_override(void) > return swiotlb; > } > IOMMU_INIT_FINISH(pci_swiotlb_detect_override, > - pci_xen_swiotlb_detect, > + xen_swiotlb_detect, > pci_swiotlb_init, > pci_swiotlb_late_init); > > diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c > index 19ae3e4fe4e9..0a35657eeb85 100644 > --- a/arch/x86/xen/pci-swiotlb-xen.c > +++ b/arch/x86/xen/pci-swiotlb-xen.c > @@ -21,12 +21,12 @@ > int xen_swiotlb __read_mostly; > > /* > - * pci_xen_swiotlb_detect - set xen_swiotlb to 1 if necessary > + * xen_swiotlb_detect - set xen_swiotlb to 1 if necessary > * > * This returns non-zero if we are forced to use xen_swiotlb (by the boot > * option). > */ > -int __init pci_xen_swiotlb_detect(void) > +int __init xen_swiotlb_detect(void) > { > > if (!xen_pv_domain()) > @@ -90,7 +90,7 @@ int pci_xen_swiotlb_init_late(void) > } > EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late); > > -IOMMU_INIT_FINISH(pci_xen_swiotlb_detect, > +IOMMU_INIT_FINISH(xen_swiotlb_detect, > NULL, > pci_xen_swiotlb_init, > NULL); > diff --git a/include/xen/interface/features.h b/include/xen/interface/features.h > index 6d1384abfbdf..f0d00bb0ac63 100644 > --- a/include/xen/interface/features.h > +++ b/include/xen/interface/features.h > @@ -83,6 +83,13 @@ > */ > #define XENFEAT_linux_rsdp_unrestricted 15 > > +/* > + * A direct-mapped (or 1:1 mapped) domain is a domain for which its > + * local pages have gfn == mfn. > + */ > +#define XENFEAT_not_direct_mapped 16 > +#define XENFEAT_direct_mapped 17 > + > #define XENFEAT_NR_SUBMAPS 1 > > #endif /* __XEN_PUBLIC_FEATURES_H__ */ > diff --git a/include/xen/swiotlb-xen.h b/include/xen/swiotlb-xen.h > index d5eaf9d682b8..6a2fc4e4b838 100644 > --- a/include/xen/swiotlb-xen.h > +++ b/include/xen/swiotlb-xen.h > @@ -12,4 +12,10 @@ void xen_dma_sync_for_device(struct device *dev, dma_addr_t handle, > extern int xen_swiotlb_init(int verbose, bool early); > extern const struct dma_map_ops xen_swiotlb_dma_ops; > > +#ifdef CONFIG_SWIOTLB_XEN > +extern int __init xen_swiotlb_detect(void); > +#else > +static inline int __init xen_swiotlb_detect(void) { return 0; } > +#endif > + > #endif /* __LINUX_SWIOTLB_XEN_H */ > -- > 2.17.1 > From xen-devel-bounces@lists.xenproject.org Wed Mar 17 00:16:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 00:16:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98518.186929 (Exim 4.92) (envelope-from ) id 1lMJrs-0005yY-D7; Wed, 17 Mar 2021 00:16:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98518.186929; Wed, 17 Mar 2021 00:16:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMJrs-0005yR-9v; Wed, 17 Mar 2021 00:16:56 +0000 Received: by outflank-mailman (input) for mailman id 98518; Wed, 17 Mar 2021 00:16:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMJrq-0005yM-W8 for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 00:16:55 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [170.10.133.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id fada098a-140c-4350-9092-4232696fd056; Wed, 17 Mar 2021 00:16:53 +0000 (UTC) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-260-yQR7w5CNN8-zDj-kcLmRSQ-1; Tue, 16 Mar 2021 20:16:51 -0400 Received: by mail-wr1-f72.google.com with SMTP id r6so4212882wrt.20 for ; Tue, 16 Mar 2021 17:16:51 -0700 (PDT) Received: from [192.168.1.36] (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id h20sm787637wmm.19.2021.03.16.17.16.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Mar 2021 17:16:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fada098a-140c-4350-9092-4232696fd056 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615940213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gPxaUrgJTpkqTxod0daPMNseXWx1OJaVOiNLeL0Mjq4=; b=Kz84s+y+KUhR1o+Mt1xXDfjfegrBOP7BJFeNtmC/4p84pCS8DviHSKsn7w6Yqo5hrYAg6K O527Ew4GHOY1i+2LlAcxUCuibZXMv/VfVfX7T4zgqkKBxp8mqd3Mu5G/6rGAVt+QfWo4EG lk8m0Q4V6qsnZnmOrdK1rLUojQUBebY= X-MC-Unique: yQR7w5CNN8-zDj-kcLmRSQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gPxaUrgJTpkqTxod0daPMNseXWx1OJaVOiNLeL0Mjq4=; b=MfP4vPxiD9MMCstj3y93RCxTf+mIb9EPpLKnPFAGrmk8vEEfS4DtBN2En9IFZ1uPtg toWOcTZTke+/ljyqMJLRyDESCi722ELA15xGGJamx7OLG9BvMpTL4juNW5FYW74U51YT 9813PRelPILLLvTI5WOeAhI0P45eOrgMDMEq6QDB3/4SYHrNxmNTyEsqLCGlm/lcTrey MPVnjjr3qnqjAmGton07OVXgyLtLaCHsojlwuEnjq56Q6lMlfF3JtkriWBVzDHuIqttW DUdNINPdrOstOX219d6RO46faGlg0Qz/z5JoyHUUn5ETSX1AUGCjnjWxwiQ4M0WjVUYI 5UzA== X-Gm-Message-State: AOAM532SgV1nIqw7pl6l/aUpiBC5ON8YbO7sh+TI5WoSRTmBoE2drevg 6jNoMeOCunKcxZMA1sgVH0DxvgW/yw3lyZbEWEq+0QK2oShDfCq4J656pO61kgzXMkgiRvUE1+R YNPoriJoi7w9ikU5uCBR+ov8Z9h8= X-Received: by 2002:a5d:4708:: with SMTP id y8mr1552623wrq.382.1615940210686; Tue, 16 Mar 2021 17:16:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrocL9jUxEN3TUc5sZWquXWQ0lm0uzy5CHm2VrcOCniDMwIAcG+Q/hYU0MwBofCcAkc0t9cA== X-Received: by 2002:a5d:4708:: with SMTP id y8mr1552616wrq.382.1615940210563; Tue, 16 Mar 2021 17:16:50 -0700 (PDT) Subject: Re: [PATCH v1] piix: fix regression during unplug in Xen HVM domUs To: Olaf Hering , xen-devel@lists.xenproject.org, qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: John Snow References: <20210316224412.11609-1-olaf@aepfle.de> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Wed, 17 Mar 2021 01:16:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210316224412.11609-1-olaf@aepfle.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/16/21 11:44 PM, Olaf Hering wrote: > Commit ee358e919e385fdc79d59d0d47b4a81e349cd5c9 causes a regression in > Xen HVM domUs which run xenlinux based kernels. > > If the domU has an USB device assigned, for example with > "usbdevice=['tablet']" in domU.cfg, the late unplug of devices will > kill the emulated USB host. As a result the khubd thread hangs, and as > a result the entire boot process. > > For some reason this does not affect pvops based kernels. This is > most likely caused by the fact that unplugging happens very early > during boot. > > Signed-off-by: Olaf Hering > --- > hw/ide/piix.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hw/ide/piix.c b/hw/ide/piix.c > index b9860e35a5..2a380a90e9 100644 > --- a/hw/ide/piix.c > +++ b/hw/ide/piix.c > @@ -34,6 +34,7 @@ > #include "hw/ide/pci.h" > #include "trace.h" > > +static bool pci_piix3_xen_ide_unplug_done; This field belongs to the device state (PCIIDEState or BMDMAState). > static uint64_t bmdma_read(void *opaque, hwaddr addr, unsigned size) > { > BMDMAState *bm = opaque; > @@ -109,6 +110,8 @@ static void piix_ide_reset(DeviceState *dev) > uint8_t *pci_conf = pd->config; > int i; > > + if (pci_piix3_xen_ide_unplug_done == true) > + return; > for (i = 0; i < 2; i++) { > ide_bus_reset(&d->bus[i]); > } > @@ -169,6 +172,7 @@ int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux) > IDEBus *idebus; > BlockBackend *blk; > > + pci_piix3_xen_ide_unplug_done = true; > pci_ide = PCI_IDE(dev); > > for (i = aux ? 1 : 0; i < 4; i++) { > @@ -259,6 +263,7 @@ static const TypeInfo piix4_ide_info = { > > static void piix_ide_register_types(void) > { > + pci_piix3_xen_ide_unplug_done = false; > type_register_static(&piix3_ide_info); > type_register_static(&piix3_ide_xen_info); > type_register_static(&piix4_ide_info); > From xen-devel-bounces@lists.xenproject.org Wed Mar 17 00:25:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 00:25:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98521.186941 (Exim 4.92) (envelope-from ) id 1lMJzq-0006to-80; Wed, 17 Mar 2021 00:25:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98521.186941; Wed, 17 Mar 2021 00:25:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMJzq-0006th-4F; Wed, 17 Mar 2021 00:25:10 +0000 Received: by outflank-mailman (input) for mailman id 98521; Wed, 17 Mar 2021 00:25:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMJzo-0006tc-8G for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 00:25:08 +0000 Received: from userp2120.oracle.com (unknown [156.151.31.85]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e45c40c7-8606-4776-b4df-ff5762b1d9a1; Wed, 17 Mar 2021 00:25:05 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12H0Dbdr128230; Wed, 17 Mar 2021 00:24:43 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 378p1ntc12-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 00:24:42 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12H0FuaT030472; Wed, 17 Mar 2021 00:24:42 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2046.outbound.protection.outlook.com [104.47.66.46]) by userp3030.oracle.com with ESMTP id 3797b0t33a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 00:24:42 +0000 Received: from BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27) by BY5PR10MB4113.namprd10.prod.outlook.com (2603:10b6:a03:20d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Wed, 17 Mar 2021 00:24:40 +0000 Received: from BYAPR10MB2999.namprd10.prod.outlook.com ([fe80::50f2:e203:1cc5:d4f7]) by BYAPR10MB2999.namprd10.prod.outlook.com ([fe80::50f2:e203:1cc5:d4f7%6]) with mapi id 15.20.3955.018; Wed, 17 Mar 2021 00:24:40 +0000 Received: from konrad-char-us-oracle-com.allregionaliads.osdevelopmeniad.oraclevcn.com (209.17.40.37) by SJ0PR03CA0071.namprd03.prod.outlook.com (2603:10b6:a03:331::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Wed, 17 Mar 2021 00:24:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e45c40c7-8606-4776-b4df-ff5762b1d9a1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=ajlBZqg6etRYPnU9lgBgBWTJ3x93HiaJoEjobjGKwIU=; b=DEK439wemGAVuqgHCjxBKpe+OiTCLf3GJVoeuVxfVgV7L2xLzJVynSlgWGSuz5UdBTb2 kZZX15lHwAAFh4sP4Z++almUaiC9WSCeESH4ar6uCcP8env3ZsZBhIqhfx1pfWySQj4b oqOofWW1AS1nvTStRdso5o6yVxbC6iZa0nHDiVpLVy1rKVbdmn6opJZbFO6L2GHVY5lY sBJRBFO3AR1go4B+6ufZcPPKF9E9UL059zdPnqN9VwlpJNHD/qDHV10aQ2HiGdpNKTHH hqPMQBbleT5tCq+rkwxq+LCRtd3+PKPm/tGxDBOH404gENSwg6ogq6yRglwd2Nam/l34 6g== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PtUuh9Mhg9F8vSNFzz6E4JBR6RpqXRN/zBsvkR44cz0P05bTD8RoKPBK8YxxIxeI07DnYPJ9YcpTjkyro0Ym1yYwU995y6Mc6KeDgASDSViDoDI4JMInY+TyhOCwQyj+Jx7nqXEkkTtdvEup6NECHUjZeErDtFtp0ZB7vwvF+QN6IWj7JaCmrR3/7qLE/s6G7jf5cNZlr3R7BJYJud7/4En8+OF0/xSPtgIkqdW6c1V8xrikznpGTexZau7xiPERyT9cpQ08TAYph1dNoCayD/0XMPK6ucgaGzQSh4n5shOv4X5zWothUaKu1cU6dJ+Oeke+Pbh9BdSqFEc7gBod1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ajlBZqg6etRYPnU9lgBgBWTJ3x93HiaJoEjobjGKwIU=; b=dOLDENHauXGEySfMGwA7hcII501RhZeTn7fcKuB90cyywAWg+8fG993YhrvifhG6IFFm5j1ZxnkojfQB+/QeZLwEciouhr8Ulom/85B8P45DRLHNW/0U3g1hWAUaxr2gXjeTH/bbFXjavtkUPlx0DGQxznqqwxLarKXNuhzsBUE7NG0VJeLW9oNU9t6+cZvMaIrQa14oQzQYXkcnqsbgy+fnh7ETVdkkrhRZF73jcsa4HeKKZGNa2PgLNYXwh1yxzl5G/Hjzrtwv0YyOLqC+a8B68qZrTj9f2hOJlngYANY45q9zrRNdxBA/EfkJPW8dYt2zv5NTp/uZsr1kv0O8pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ajlBZqg6etRYPnU9lgBgBWTJ3x93HiaJoEjobjGKwIU=; b=c7cEMMfJAORiEiTH1VG6G6k2QURYByDj4A1VxI50uIp7UAtNPuOv5a9UVkO73B+B3P0WPAR1AH/yxPVq2LiEGAY1QbYRJugk4BMTef0+dyl0uw5Ps8XVs9/iO1mUgmEERFCZb/XnEWS2g65lntoI/WO3ml+37wZUCA5yWSqQhvk= Authentication-Results: lst.de; dkim=none (message not signed) header.d=none;lst.de; dmarc=none action=none header.from=oracle.com; Date: Wed, 17 Mar 2021 00:24:36 +0000 From: Konrad Rzeszutek Wilk To: Christoph Hellwig Cc: Michael Ellerman , iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Claire Chang , linuxppc-dev@lists.ozlabs.org, Dongli Zhang Subject: Re: [PATCH 02/14] swiotlb: remove the alloc_size parameter to swiotlb_tbl_unmap_single Message-ID: <20210317002433.GA80752@konrad-char-us-oracle-com.allregionaliads.osdevelopmeniad.oraclevcn.com> References: <20210301074436.919889-1-hch@lst.de> <20210301074436.919889-3-hch@lst.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210301074436.919889-3-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [209.17.40.37] X-ClientProxiedBy: SJ0PR03CA0071.namprd03.prod.outlook.com (2603:10b6:a03:331::16) To BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 518c6071-4445-4074-d04c-08d8e8db0e25 X-MS-TrafficTypeDiagnostic: BY5PR10MB4113: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v8J01Q++C1M0bY9xSJV4J6+AMmIvKZFMUnVCgCuaWf62kGns0Jez0Xx2EGsgywoIg+tneE5ji3/c5UfJOHEgQsU+WniYVY88uQSHqy5ARVT3XQYHECzqqLcJsvVTcTgg+Bgsh9UOeggB1pbV4bDWJlby4kkt0yF72BgE1CPob2I4Qm1PLBK06ZO8BCBEclEomevu2R+jnIhEwX4BhUy7r2xt1ZR9WsyeTvxwvXW8N8HxOiA8VcoZMGd2jOiN+0QL8354HmAtWs3JUFPvDb/nwJIi9GoGFfqmorw9CaOxNn4VuB2q27xQhfXfcHNM2e17MAEU20vDn3emIzj6gJcPcjIWt6MhDATq1LwM6l6a1ecFmKPPOhMdlUoPgTVnhMKX0tUeIW8G4DTm7U81x0B5kQthosybzaYdknIfDQcuXFV9mYFfSi7L4CZnNJDiTgZQbsSsbmztSjgdKUjFkKV9t2Lj/vUqr2/VaZJMei/Ed60o8DhRkIEpgfz/D+qHBaGBMk0YU0syZ4bgSjAqGxCyUIPXG6r61P0KZKsTBnMZnpw+/oeZaUTC7qErNZXxrokj X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(346002)(366004)(376002)(136003)(5660300002)(54906003)(478600001)(4326008)(6916009)(316002)(1076003)(9686003)(55016002)(186003)(558084003)(107886003)(8936002)(2906002)(52116002)(7696005)(86362001)(66556008)(66476007)(6666004)(26005)(16526019)(6506007)(956004)(66946007)(8676002)(33656002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?2OiDiTVsNE3Hr73ctb1olDqr8owqrPQUiyAYgnup7uKhyW6EEWRLMMODlcOA?= =?us-ascii?Q?YNC9ab6QSRIOQUSCk2Cm2hK+3ITqaJhM6O3+Xn3ejKlPREWJDRgfzLniDqFd?= =?us-ascii?Q?pQrin8vC737wIi85qXvGL6oVh7lFLfJjoJLR4XwC9MIuJMl6cOUL4vA1pfF9?= =?us-ascii?Q?bWLtxrXOj0ccYKeQMxQlRSOXslpFzeqVqK25bZUDw4zalDqfYPGtZwZT4Sg9?= =?us-ascii?Q?ROU1mlfXZs1nTt5ianmpATapJowMzGNF+UKX5WaBanWTs9XgH3/c072mKW/c?= =?us-ascii?Q?GE9ZWwCQn4tc9qhv6Ym7V+Qf+WAYjHnuB6gKkqRtkvFoHxTCJAJiClr/PKNI?= =?us-ascii?Q?gAZUZUhM2e5lPvBdjSApftkBLdvWPTkPjO2BmkwSXXmAa9/LuEeL2Z2jhDDD?= =?us-ascii?Q?p6gTAXoWtK+jLZfGvSNHCNJ5SqQJ/6aMWbSF9kqjpzLrI1hydZ/uzhdKxduh?= =?us-ascii?Q?PxeX8sXj7xmbygucsKavcBwImKEbpCwg3mbsIQhPZcvq069Cym9dyNoZa3QX?= =?us-ascii?Q?TqHacX+CDga/MvVxdfNWt6sVolXruMu1fQ/cOccnnaqgkwc8sKF4jaAC3HMh?= =?us-ascii?Q?qnuM3HJgWvkwpKmbWYdW9ZtYkbzUm7RFaZQ+GLMj3kF+AE34ugGs4UckSFbx?= =?us-ascii?Q?huDrI9lRvJImAqBueSjjkNXOpnv8pfJGxyANuy7HgCyCYT9qnE5K0cHCwfGH?= =?us-ascii?Q?jOL9IP4Eyqr+UEMRVChRiF8kuq4xRGC/gWSznGPCLYrL9pAxTv2HT8kGcl2z?= =?us-ascii?Q?TqwpcSwn47qPQZfufMfPN55Z7sydijTwUQkPKTovACVw2PEDmxeIp90OkpoH?= =?us-ascii?Q?rx0DaJeOM/N3q6H9oQXKJ5SOtOAtHBY92iVW5FHkXefVP6S8h76iAX450HPX?= =?us-ascii?Q?/Jz3mj8s0yemegNyLRcGEqUkGXu5EbIE4+q8eKKWdRH0IuDFtpYxDgc5q0Uk?= =?us-ascii?Q?AMJmtiTMG+Sioq4g0ga2/giAHHCJMMRmjhu9TQanJ0l9P+kHnmEAKCDTKKQl?= =?us-ascii?Q?SrL3hqmlZXwbxUxJ30iq/SYRVznwMI5xPbkiTb9Mgip1XwZJn4dHpzs42P7k?= =?us-ascii?Q?5utDm96Ioo+LyFjJV7ROUAWhQjJK045V5UNrok8rA1DP4QDXyyMDQ8wZTGqq?= =?us-ascii?Q?gQpmxSZNup9POK+nfZ8B70Ei2SWFEKS9f3HR2fN84hlHeqlUBPjsipWCfRB3?= =?us-ascii?Q?V4qP+tTRwCjIlNLoVejCUWVRN5FQUSsm4eI4eqiJzsWUc0MgJDd71JvahrDG?= =?us-ascii?Q?wjFTMewOHbcJF3znkmQzFhzDLlbqT5YJsuOQKHnZ214apA/4R1lp5B9ea1nL?= =?us-ascii?Q?t7NgC1H7wAGANFaCOQUpf8p0?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 518c6071-4445-4074-d04c-08d8e8db0e25 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 00:24:40.7455 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oGS0AMie1F3nrVReND0XmoKp9saY/bwGAU2qblU3uQNo/h9Q1kpsbl2Yj5cC28bA6+Ec29tb7b6pkhZtJEj6Ng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4113 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0 adultscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170000 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 adultscore=0 spamscore=0 clxscore=1015 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170000 On Mon, Mar 01, 2021 at 08:44:24AM +0100, Christoph Hellwig wrote: > Now that swiotlb remembers the allocation size there is no need to pass > it back to swiotlb_tbl_unmap_single. Reviewed-by: Konrad Rzeszutek Wilk From xen-devel-bounces@lists.xenproject.org Wed Mar 17 00:31:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 00:31:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98526.186953 (Exim 4.92) (envelope-from ) id 1lMK5a-0007p3-1a; Wed, 17 Mar 2021 00:31:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98526.186953; Wed, 17 Mar 2021 00:31:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMK5Z-0007ow-Um; Wed, 17 Mar 2021 00:31:05 +0000 Received: by outflank-mailman (input) for mailman id 98526; Wed, 17 Mar 2021 00:31:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMK5Z-0007or-JH for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 00:31:05 +0000 Received: from aserp2130.oracle.com (unknown [141.146.126.79]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fe50403e-241c-40d3-b027-d34536cfced6; Wed, 17 Mar 2021 00:31:04 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12H0TvvK055859; Wed, 17 Mar 2021 00:30:53 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 378jwbjfus-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 00:30:52 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12H0Tl9J141958; Wed, 17 Mar 2021 00:30:52 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2048.outbound.protection.outlook.com [104.47.66.48]) by aserp3020.oracle.com with ESMTP id 3797a1wnmj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 00:30:52 +0000 Received: from BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27) by SJ0PR10MB4445.namprd10.prod.outlook.com (2603:10b6:a03:2ae::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Wed, 17 Mar 2021 00:30:50 +0000 Received: from BYAPR10MB2999.namprd10.prod.outlook.com ([fe80::50f2:e203:1cc5:d4f7]) by BYAPR10MB2999.namprd10.prod.outlook.com ([fe80::50f2:e203:1cc5:d4f7%6]) with mapi id 15.20.3955.018; Wed, 17 Mar 2021 00:30:50 +0000 Received: from konrad-char-us-oracle-com.allregionaliads.osdevelopmeniad.oraclevcn.com (209.17.40.37) by BL0PR02CA0035.namprd02.prod.outlook.com (2603:10b6:207:3c::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Wed, 17 Mar 2021 00:30:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe50403e-241c-40d3-b027-d34536cfced6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=MqhKdxUI8LwYf06J6INY/KXNITf0zAV9/TtiHVgje8I=; b=EpvOgOYOq9MDCVf+4duRwpNXV5kdn92V4+d5wAll9Bi0p50dpeKumykYvYXssXF6qZrW g6PQAECkGZ8cywTD/aUTYpLMYvITJjdCDfEjjqWPlutXt94yTX/vSCfkKLsrXbxPiLIJ 0Prd3cKPKe1vamvGlDxfIxFWWxtXEd/1jtnBtoZRqoc1lhnVizip8VvUEiGpK1yc3RB7 yCo7k6ijGgf9K5pKffAA0QRI7ewbw9zkS5MiIP8uj2+ltmV8dqwOJzTx+SJz+r1rv+1A V2JLoeEoZm8x8Jcayu3gLONFqSo6M2JJufce2AG1LjPnxLFeIsP1BbM24SHDy5kXAeob oA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hWdgJ6YZgOYDCU16tiroiMBD+6aPoZz+0IeAQf+ob4Efi6/ro6aBcPlJuPzL5loBJLeVgTd4hSpZ/2C2thkseDNYbc1BPFx/5y3yG7b9FMaGqx+Rvg2iGi8oC2tOEB5CfJ1L1wKTHggO8+eft/SyxtodljI8SplPwugUyw5n7unpdTgZFCwDjHdkX/csOkdunVtGc2IjWDeLUWjmPecZrJucqfnKQaei6cA5/jBzj2mOJLiBlRSB11qKWTkw1HTV5ZOWbMrDl09np4UE5Qyj3ppyDQHVfyIxl/ixNukwyuFd50TJ+6oOofQngi6iChHSSiQb0SIY69+UMwGa7zeDsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MqhKdxUI8LwYf06J6INY/KXNITf0zAV9/TtiHVgje8I=; b=XixOG/Fxi+d6hoPrC3H2ST6CXpYNLSr49AbTOh6yoL2CB8dsBD4hS/inn8/LAu5eJtb2r5tXCAKr3fyut1oXgDWxBvtz3s0tugmcGFReCh5Rp3NbqNIh+GkG0sZlJmbV6gFcvHMRQ/txLULxig94dMI4+Cea6vKlJqoRcysZzsNS0LVDBNkIrK2c/D8ld2WfFIBSn19RTeoVzmUut38/ci8hzu1jtDXwfJT6pTU/PJffwhSfbnEutyjZU1mEjnpQG/OiTgsz7zcsbws8mPpN69m5Hal/a3PCT2Dmd3ywzGOfoNv68obMi7JOfj5Dq+FzNswtGvzdARqRGhg81kBJhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MqhKdxUI8LwYf06J6INY/KXNITf0zAV9/TtiHVgje8I=; b=hRz2XbkaNc4S5gMGVSoehCpK4sBLeXkKmlEm8AT6gozqwOZNPPxQEKvcqHmCCl90eZxAA6v8kUYioixGOeCKseGop9uSNVntfew4X9er41TldPoXOz9e5Nlz2eQB7Ph4C16ysYeOqsu4RfLHSisDo11AKg7wE7RVpm7FQSAdEAM= Authentication-Results: lst.de; dkim=none (message not signed) header.d=none;lst.de; dmarc=none action=none header.from=oracle.com; Date: Wed, 17 Mar 2021 00:30:47 +0000 From: Konrad Rzeszutek Wilk To: Christoph Hellwig Cc: Michael Ellerman , iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Claire Chang , linuxppc-dev@lists.ozlabs.org, Dongli Zhang Subject: Re: [PATCH 03/14] swiotlb: move orig addr and size validation into swiotlb_bounce Message-ID: <20210317003037.GB80752@konrad-char-us-oracle-com.allregionaliads.osdevelopmeniad.oraclevcn.com> References: <20210301074436.919889-1-hch@lst.de> <20210301074436.919889-4-hch@lst.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210301074436.919889-4-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [209.17.40.37] X-ClientProxiedBy: BL0PR02CA0035.namprd02.prod.outlook.com (2603:10b6:207:3c::48) To BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 968f3c57-0a09-4974-a33c-08d8e8dbea78 X-MS-TrafficTypeDiagnostic: SJ0PR10MB4445: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vKQuzYNrl6utvhHUKHrC6FC8ZfOirMpmDQ9KoeH+NFxcVThGkvBqdOvAc3RGjqUfm6ubhWasXw+7G/TQKnqE6dZz1yd++ryEeF6G9wtacYWRf5gRGu6G4NDYREGutAiVgo0s+eal/PnSLeoNozpta15kkb1C2ibu+8S4vxMYoOc8dtu4Gvhnao3vYWkJgj22vbmTxNNdCF6d5QIuR2ArdOSE3dOUPmvd5kxZf+BpDMwjMfAvlEcLO1zJzpPTqeRg9ZuUK4MxCeo5huufzX8aMp8s3K11KQtaSo2IbTOfbJt6uwJK/giIaXjOuWBEgiz0RoIYB0U0Vx4eWxcTja3Awy8Jx9U6OBJQb6ns7eik5JVwQAwFgxY1X75O2yRVpn2rmAGGkMkI/NtEOS0b4o1wV1lxpP2CItVrcxJjIzA5Fkyuqc9gSY7c1OJDLOBvY7yx+MKfdLEtABWBO7TTuZUZ90xez2kOUZOK74fsgs3lAm2EL3+YHF6m26uGjKLGBAcwDbbLUZJT/EqmPGh2J2ooB8JaLm9rs7WIbPO4t4NksE5Yft24Uw+otcwSpiYBwTze X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(366004)(136003)(376002)(346002)(1076003)(9686003)(2906002)(316002)(26005)(54906003)(16526019)(186003)(8676002)(86362001)(55016002)(5660300002)(6506007)(107886003)(6916009)(33656002)(8936002)(52116002)(478600001)(4744005)(956004)(66476007)(83380400001)(66556008)(66946007)(7696005)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?4IiTvCGZ+9dN/yDNl9WPIUdKPgvJuGaeQe/6PexKQpozRbyuTzDFg6S4vOwk?= =?us-ascii?Q?mLGBwX8gpoIKda9Axb2RpnO3eEmq5JAjHduCwW1RkspO3pwHUUy/01Oybjza?= =?us-ascii?Q?Q+PDF25eXQCmzV7UxZOx9Wl1Gd8/A0vIVRKeHmZd4864WN4ol3K5k9gPt3ZD?= =?us-ascii?Q?dpreqmAikiDMGJwYVIHRfMPZpnz4372+93ApksBWzmaEGqodBiTRRiFZMlKt?= =?us-ascii?Q?jjMiFhSi1FbAcyTKLfsDB0NrotJxn6gYT0KIQBuDci+LfxfEtJkd0OC/sbGn?= =?us-ascii?Q?yEkJWQ2lFg4SWbJsATIGlZ8bjuJz4cz8WH9h8FaHgRVLEHz/darcezw4a19S?= =?us-ascii?Q?zOfZS6HBGXv0vnlPpv8Lrpx1Cwc75qVZPm5cMemI395uUVBijZrFWq6qYWpv?= =?us-ascii?Q?fPcNZ3Jtg1r6kRgGxrljVzxxeRShBmNlM3LMrkw0opnGcTyQ4PRRqMeBoDbj?= =?us-ascii?Q?AGY0Vjqk346nsoiEO9A0bjcTfr/DEKEUN88BDMUBfOIOS2VkLQXku5WPZAf2?= =?us-ascii?Q?PvTfgZNSyoOEoNcrgjceTiig6awswrJM9iLRrhcYQUPcoQVcIJ1bLbGD1Pts?= =?us-ascii?Q?5LdXHX07lWb2TFyvwGe41TtvLdNuIPmBDfLv46+ewfHxkhub59vJub7BY0OR?= =?us-ascii?Q?Zh+/ca1bxNZVlLIIsmL2qDxg+hT7ufzmrXJSNI+qNbTENxNt7GgUv3DPTcb2?= =?us-ascii?Q?CQrKYbP70H7xY63/XHXdVYs2HVt3V1haZTPez0iKlCAGQ5Ln+h5PtBsL31ic?= =?us-ascii?Q?NkzTwcVoKyPrbf2jFSbQZ8mveeM2vYNvzSTfDx9gOc6hl0f5Z0i1Zi8V652M?= =?us-ascii?Q?XQl9p2Occ+ikCbkzIULwxpHbijiFdDU1jdSKHsu+DEVKD+gtro1XpvSxksyk?= =?us-ascii?Q?4TX7kQ7dWUwHgsJ2u7dKbjDGkVLZwqpQf/lMKC/z/Mt+JXAFnh5uY/yzHaV5?= =?us-ascii?Q?FSN7q2FhhrvITSJkSa1E1/9PWnyheaNtQi/fqm7LcbflhAwwI200U2e6oXT4?= =?us-ascii?Q?k+Hsc50HrF3FCkH5PZQEecMPUYtahiznLYc9dCNfXmZiWbtEG/F38cBgCwaA?= =?us-ascii?Q?k8VFp/FXkng2DA4EdfqPnjCMIqnkZkuKTaitTR8LUBIu4oU21svjKD7nMo9Z?= =?us-ascii?Q?/H8htBkvneCdcMT1wuAzuZitdmPDKJ/TdtODbPWOSlsYzEH9jKylNypqommy?= =?us-ascii?Q?jU6l07Yax7WD9LTaxfUfdL4pu+MAovXI324Qm7WtGxNF90vPRerqx9zedLVw?= =?us-ascii?Q?tWoMi9XWJ3b8EYDU2iV5VsTy51KvaSNab+MxV9iujUoE+IONl4wtMJv+tG+v?= =?us-ascii?Q?7BYp9GBnYEK9Brp8Mft9GwMD?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 968f3c57-0a09-4974-a33c-08d8e8dbea78 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 00:30:50.5030 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: go2eOFypX5B9nVPRMIQmYMGrOdhGuNBT2DeGDJYygZrdUN2XAp7Y02uj3YLn5X34YB/p+UL9m75QO6kGfuQk1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4445 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170001 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 adultscore=0 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170001 On Mon, Mar 01, 2021 at 08:44:25AM +0100, Christoph Hellwig wrote: > Move the code to find and validate the original buffer address and size > from the callers into swiotlb_bounce. This means a tiny bit of extra > work in the swiotlb_map path, but avoids code duplication and a leads to > a better code structure. Reviewed-by: Konrad Rzeszutek Wilk From xen-devel-bounces@lists.xenproject.org Wed Mar 17 01:19:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 01:19:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98529.186965 (Exim 4.92) (envelope-from ) id 1lMKqK-00053c-KJ; Wed, 17 Mar 2021 01:19:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98529.186965; Wed, 17 Mar 2021 01:19:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMKqK-00053V-H0; Wed, 17 Mar 2021 01:19:24 +0000 Received: by outflank-mailman (input) for mailman id 98529; Wed, 17 Mar 2021 01:19:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMKqJ-00053N-Hz; Wed, 17 Mar 2021 01:19:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMKqJ-0001mw-AN; Wed, 17 Mar 2021 01:19:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMKqI-0005Qv-VI; Wed, 17 Mar 2021 01:19:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMKqI-0003q3-Un; Wed, 17 Mar 2021 01:19:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pLor/me+pkQo393JU/Gp6AY4hQ9aHeDYptsjz3z51KU=; b=Q2O8fkJwwIHqqBAPd9iRCi4eY7 4H18cMWwFzclmNTX4RGPJmB13HUetbrOeriiZXlU6rCUWUXroGgVd80xAnueo80A1tQozcdzfsh77 X2dXcwTZrkdfmCVvmtldVhg8IUFpfzVyekpW+qa9i0l4ufpsOJEIbRDBjFcdDqbaUY80=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160100: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-qemuu-nested-amd::broken:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-examine:host-install:broken:heisenbug linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-qemuu-nested-amd:host-install(5):broken:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1a4431a5db2bf800c647ee0ed87f2727b8d6c29c X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Wed, 17 Mar 2021 01:19:22 +0000 flight 160100 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160100/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd broken in 160094 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-examine 5 host-install broken in 160094 pass in 160100 test-amd64-amd64-examine 4 memdisk-try-append fail in 160094 pass in 160100 test-amd64-amd64-xl-rtds 8 xen-boot fail pass in 160094 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 5 host-install(5) broken in 160094 blocked in 152332 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 1a4431a5db2bf800c647ee0ed87f2727b8d6c29c baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 228 days Failing since 152366 2020-08-01 20:49:34 Z 227 days 395 attempts Testing same since 160094 2021-03-16 04:50:50 Z 0 days 2 attempts ------------------------------------------------------------ 5214 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-qemuu-nested-amd broken Not pushing. (No revision log; it would be 1293661 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 17 03:05:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 03:05:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98538.186980 (Exim 4.92) (envelope-from ) id 1lMMUi-0006U7-IO; Wed, 17 Mar 2021 03:05:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98538.186980; Wed, 17 Mar 2021 03:05:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMMUi-0006U0-Ei; Wed, 17 Mar 2021 03:05:12 +0000 Received: by outflank-mailman (input) for mailman id 98538; Wed, 17 Mar 2021 03:05:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMMUh-0006Tv-78 for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 03:05:11 +0000 Received: from out30-133.freemail.mail.aliyun.com (unknown [115.124.30.133]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8e544caa-ce6e-4322-a560-740453efbcfc; Wed, 17 Mar 2021 03:05:09 +0000 (UTC) Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0USD1H6X_1615950300) by smtp.aliyun-inc.com(127.0.0.1); Wed, 17 Mar 2021 11:05:06 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e544caa-ce6e-4322-a560-740453efbcfc X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R321e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0USD1H6X_1615950300; From: Jiapeng Chong To: boris.ostrovsky@oracle.com Cc: jgross@suse.com, sstabellini@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] xen/evtchn: replace if (cond) BUG() with BUG_ON() Date: Wed, 17 Mar 2021 11:04:59 +0800 Message-Id: <1615950299-96787-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Fix the following coccicheck warnings: ./drivers/xen/evtchn.c:412:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/xen/evtchn.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c index c99415a..b1c59bc 100644 --- a/drivers/xen/evtchn.c +++ b/drivers/xen/evtchn.c @@ -408,8 +408,7 @@ static int evtchn_bind_to_user(struct per_user_data *u, evtchn_port_t port) err: /* bind failed, should close the port now */ close.port = port; - if (HYPERVISOR_event_channel_op(EVTCHNOP_close, &close) != 0) - BUG(); + BUG_ON(HYPERVISOR_event_channel_op(EVTCHNOP_close, &close) != 0); del_evtchn(u, evtchn); return rc; } -- 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 17 04:09:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 04:09:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98542.186992 (Exim 4.92) (envelope-from ) id 1lMNUO-0003VA-8q; Wed, 17 Mar 2021 04:08:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98542.186992; Wed, 17 Mar 2021 04:08:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMNUO-0003V3-5c; Wed, 17 Mar 2021 04:08:56 +0000 Received: by outflank-mailman (input) for mailman id 98542; Wed, 17 Mar 2021 04:08:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMNUN-0003Uf-2T; Wed, 17 Mar 2021 04:08:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMNUM-0005By-RC; Wed, 17 Mar 2021 04:08:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMNUM-0004ft-Iq; Wed, 17 Mar 2021 04:08:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMNUM-0007wy-IF; Wed, 17 Mar 2021 04:08:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ihrMyVwEzPwvRIiPMSPH8Ok64wTJyHwEC7tKIsWzyHM=; b=fByiBjKHUYNk32Yyske2Tg8as/ yFDJ3S7kWMmjLEYmEtCExf16XHmjkey2Kg2YUnpQW+ikOFdhHlNbC0rDOo98D42w0PrrY1bCX9rpp JxXPcZn9yHGhBIHCg4ovVM1ztKDqX4V91IhyGzjL9iegn25tpCoIRZv0YkuNYBuvTsfM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160103: all pass - PUSHED X-Osstest-Versions-This: ovmf=66a31de7eeed62a7aa68fe0613a597a8bf08bc16 X-Osstest-Versions-That: ovmf=f3bdfc41866edf7c256e689deb9d091a950c8fca From: osstest service owner Date: Wed, 17 Mar 2021 04:08:54 +0000 flight 160103 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160103/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 66a31de7eeed62a7aa68fe0613a597a8bf08bc16 baseline version: ovmf f3bdfc41866edf7c256e689deb9d091a950c8fca Last test of basis 160098 2021-03-16 13:41:59 Z 0 days Testing same since 160103 2021-03-16 21:09:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Matthew Carlson jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git f3bdfc4186..66a31de7ee 66a31de7eeed62a7aa68fe0613a597a8bf08bc16 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Mar 17 06:26:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 06:26:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98550.187007 (Exim 4.92) (envelope-from ) id 1lMPdF-0007cJ-4e; Wed, 17 Mar 2021 06:26:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98550.187007; Wed, 17 Mar 2021 06:26:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMPdF-0007cC-1U; Wed, 17 Mar 2021 06:26:13 +0000 Received: by outflank-mailman (input) for mailman id 98550; Wed, 17 Mar 2021 06:26:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMPdD-0007c4-9L; Wed, 17 Mar 2021 06:26:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMPdC-0007jL-VX; Wed, 17 Mar 2021 06:26:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMPdC-0002c6-J7; Wed, 17 Mar 2021 06:26:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMPdC-0003KM-Id; Wed, 17 Mar 2021 06:26:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Okou1V9NZEQxLDJgTcwsWX3W8iJA8FSlTvHlP/U+9AE=; b=OSSYilhoqjUzy2UmdlFUTNOwbP I+cQjTCz7uGDOIlttNSE36vyZzY6UaKkiwciNdp4cnq6FhxWHYGOlhHzkze+5nW2velS5yrVIjOma CA1MFAeIPg4GF5cPU6KNTt1kmmM7q51r5GpKrPDGq1PFPDNx6M0VvynBwWp9VB+rPX6Y=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160107: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=78bcf5546bf04080473b40a4de2e483399188222 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 17 Mar 2021 06:26:10 +0000 flight 160107 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160107/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 78bcf5546bf04080473b40a4de2e483399188222 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 250 days Failing since 151818 2020-07-11 04:18:52 Z 249 days 242 attempts Testing same since 160107 2021-03-17 04:18:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 47607 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 17 06:57:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 06:57:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98557.187025 (Exim 4.92) (envelope-from ) id 1lMQ6w-0001vJ-IZ; Wed, 17 Mar 2021 06:56:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98557.187025; Wed, 17 Mar 2021 06:56:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMQ6w-0001vC-FP; Wed, 17 Mar 2021 06:56:54 +0000 Received: by outflank-mailman (input) for mailman id 98557; Wed, 17 Mar 2021 06:56:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMQ6v-0001v4-O0; Wed, 17 Mar 2021 06:56:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMQ6v-0008DQ-He; Wed, 17 Mar 2021 06:56:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMQ6v-0003uy-7z; Wed, 17 Mar 2021 06:56:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMQ6v-0005lN-7Q; Wed, 17 Mar 2021 06:56:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AH3smZ0MBoTcn+NKx0mjIKk6x8+bs1pnwGZMEVhbVsw=; b=Qau12QimP+bf8r/QevscDlypKy md+JjmnQoSE7CLf1w8GZcs8qAOv2fIWCUmjUTfmHiMqDUQxqqMHS/x1M7KBz+XTbBFdWUOeg5TvKD 8jp47J4weI2zCCyLfUEPkhyePNbqc9bEmr9oCJLEkZl4tx3kf2gpFLWgVLCVjES0XmpE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160101: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=21657ad4f01a634beac570c64c0691e51b9cf366 X-Osstest-Versions-That: xen=b4011741e6b39a8fd0ed5aded96c16c45ead5888 From: osstest service owner Date: Wed, 17 Mar 2021 06:56:53 +0000 flight 160101 xen-unstable real [real] flight 160108 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160101/ http://logs.test-lab.xenproject.org/osstest/logs/160108/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160108-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160092 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160092 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160092 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160092 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160092 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160092 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160092 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160092 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160092 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160092 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160092 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 21657ad4f01a634beac570c64c0691e51b9cf366 baseline version: xen b4011741e6b39a8fd0ed5aded96c16c45ead5888 Last test of basis 160092 2021-03-16 01:53:34 Z 1 days Testing same since 160101 2021-03-16 17:38:35 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b4011741e6..21657ad4f0 21657ad4f01a634beac570c64c0691e51b9cf366 -> master From xen-devel-bounces@lists.xenproject.org Wed Mar 17 07:01:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 07:01:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98565.187041 (Exim 4.92) (envelope-from ) id 1lMQAy-0002si-9n; Wed, 17 Mar 2021 07:01:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98565.187041; Wed, 17 Mar 2021 07:01:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMQAy-0002sb-6j; Wed, 17 Mar 2021 07:01:04 +0000 Received: by outflank-mailman (input) for mailman id 98565; Wed, 17 Mar 2021 07:01:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMQAw-0002sK-FV for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 07:01:02 +0000 Received: from mo6-p00-ob.smtp.rzone.de (unknown [2a01:238:400:100::b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c7d2328b-98dc-4a87-8758-b16c388084dc; Wed, 17 Mar 2021 07:01:01 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.21.0 SBL|AUTH) with ESMTPSA id u08c13x2H70o88o (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)) (Client did not present a certificate); Wed, 17 Mar 2021 08:00:50 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7d2328b-98dc-4a87-8758-b16c388084dc ARC-Seal: i=1; a=rsa-sha256; t=1615964450; cv=none; d=strato.com; s=strato-dkim-0002; b=QhJziYMy38tKBzT+jnW2C4YmGZ1LpnM1yOXvawVOjXRBFWX8xjgf2Yc130VDLvcvQP iaEdu9J+cagSPiEUt6y4FiNaE9Mt7V+UfKRWG+/6CtWlSmYzkRY5hajvM6f1Wx+mShpd u0MfiP0I1K4TJ5WRfOiPNxAql3NaezGb51GKtNlVt1PX4p+EvQf7tGzbWDMzDVFVLjwN r/WbxGEzgi+Tv/lkEHfTSL4BeWpXnQwNGXe0f3NPQhmVnxay8/GPYv15egHhFQ7CSS/m 62b8dyr11AaIkhKRvBd+O8gPMMIaK2FDKAwF+Vu5F5kpvXfkd8mtoBYVwvFeT89crnK+ Xrnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1615964450; s=strato-dkim-0002; d=strato.com; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=F5gsroM5N4Gb38oAx76awNUeg6mdAvkdztZJQE8rvpw=; b=bD5n6UEJ0IumSyeyLQRM+en8Q2cd3gGFofEVOxEgpzMq4oF/jWSY7zYcuwLTkySv2v i4ayvCeg67oMz7cu1ssPYNMeSOCFa5pOXDvpg1Xj/7ETx6rzoIPJC5zNOmdu7YvLUNmk uAMhA0K7zghET97gJVGvHOehvZ5ZpSrpAI54FnAbb5aJVvsSZ6Z0wD/EyZ1TjJCF2FkP yfyqVWbIzdrQmCPSxmZGgEQfahwQa0jdEEXSU+/SN2eLJWWL0TJs3yajIiQkznW4SHzO vvOXxkiolOEWMAo9NWmmslcEoPQhcJhDEqNeDRg7hmlxD+2fxIRdbhUXdAv7wk5OxE+m INvw== ARC-Authentication-Results: i=1; strato.com; dkim=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1615964450; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=F5gsroM5N4Gb38oAx76awNUeg6mdAvkdztZJQE8rvpw=; b=mzzd+qADwgwU7fgLB7cnhPrFYNn4DwI6ai1ZXd9r2AvGg3mLnzScIIjHwb5aUB+3tq QnnYZd29ov7wQXeDwT0nHVAmoedYK3Ux7SMCdoU7gC5bvt5IPqn2/scQqDiqsPGl8MD2 ZK7Pt4IFRWWkDGP3RnYT8P12z/ds47aiTV046FGB0vr8tZKwoeC2vbxu7jaqrbl3j6QF z4V9eVPR78NAPlzwyg3hItqK3Z5a2BJ52qtTryktJRpBiST/WsdYyF+WDgICcKGOWjio ZwNcKxIatwSJcmD2oPJNu1H6E9J63C48tfSsPNRaEivaMQp7q+UPvh50GqnGWONBUafW bRpg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzBW/OdlBZQ4AHSS325Pjw==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org, qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Olaf Hering , John Snow Subject: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs Date: Wed, 17 Mar 2021 08:00:46 +0100 Message-Id: <20210317070046.17860-1-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit ee358e919e385fdc79d59d0d47b4a81e349cd5c9 causes a regression in Xen HVM domUs which run xenlinux based kernels. If the domU has an USB device assigned, for example with "usbdevice=['tablet']" in domU.cfg, the late unplug of devices will kill the emulated USB host. As a result the khubd thread hangs, and as a result the entire boot process. For some reason this does not affect pvops based kernels. This is most likely caused by the fact that unplugging happens very early during boot. Signed-off-by: Olaf Hering --- hw/ide/piix.c | 5 +++++ include/hw/ide/pci.h | 1 + 2 files changed, 6 insertions(+) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index b9860e35a5..7f1998bf04 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -109,6 +109,9 @@ static void piix_ide_reset(DeviceState *dev) uint8_t *pci_conf = pd->config; int i; + if (d->xen_unplug_done == true) { + return; + } for (i = 0; i < 2; i++) { ide_bus_reset(&d->bus[i]); } @@ -151,6 +154,7 @@ static void pci_piix_ide_realize(PCIDevice *dev, Error **errp) PCIIDEState *d = PCI_IDE(dev); uint8_t *pci_conf = dev->config; + d->xen_unplug_done = false; pci_conf[PCI_CLASS_PROG] = 0x80; // legacy ATA mode bmdma_setup_bar(d); @@ -170,6 +174,7 @@ int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux) BlockBackend *blk; pci_ide = PCI_IDE(dev); + pci_ide->xen_unplug_done = true; for (i = aux ? 1 : 0; i < 4; i++) { idebus = &pci_ide->bus[i / 2]; diff --git a/include/hw/ide/pci.h b/include/hw/ide/pci.h index d8384e1c42..9e71cfec3b 100644 --- a/include/hw/ide/pci.h +++ b/include/hw/ide/pci.h @@ -50,6 +50,7 @@ struct PCIIDEState { IDEBus bus[2]; BMDMAState bmdma[2]; uint32_t secondary; /* used only for cmd646 */ + bool xen_unplug_done; MemoryRegion bmdma_bar; MemoryRegion cmd_bar[2]; MemoryRegion data_bar[2]; From xen-devel-bounces@lists.xenproject.org Wed Mar 17 08:32:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 08:32:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98575.187053 (Exim 4.92) (envelope-from ) id 1lMRbb-00030e-9R; Wed, 17 Mar 2021 08:32:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98575.187053; Wed, 17 Mar 2021 08:32:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMRbb-00030X-6O; Wed, 17 Mar 2021 08:32:39 +0000 Received: by outflank-mailman (input) for mailman id 98575; Wed, 17 Mar 2021 08:32:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMRbZ-00030S-Ag for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 08:32:37 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0bf144e0-13b7-4e00-9689-bafa52b56587; Wed, 17 Mar 2021 08:32:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bf144e0-13b7-4e00-9689-bafa52b56587 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615969955; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/DCCVV615bfnZ7YEotovwWJkhckCXTT0wENqsoENMO8=; b=gb7QK8+ZsdjQSQ6CZizf8ZrF14hmnvdvPiRCDzypOgAVdNnr8pyL91dW gtXtcN5zqHU3VbsBBz7XDI5QyxHR06+fupmOK11dCKMbhxq9Wb+CZyi4n UflPQsf0D6lHO+uyHtzHYFSCNAMKQORjtZ30wM486j9URuIc0E4C4b+nw 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ttqiE4udgdHXHe8gTFK25Bv3i4u4DQSXPFIvJ4awyIJiafScpJrz4PCEHqFiMn4iRphH+GbQF9 Cup1YhaXKX3X0xQ/HIJkEt15iSM+617gdfA4ivcKEurM0fZAU2kyIeURnixPPQvq3R3lp3+ohL HjkQe4+A/AXr6+HmWuTPYThM33aggjf0x7QWAA6SXSD4Wu6UipN/GwJxzQH1zWOvb2LPzZ89r+ Ax5nK+u1Dc8q/dE/zihs+x9vcuiLILyji9s7cTqTSYfiwrFysMw4rPt+N7CG+GxsUWGA4+MkEZ /zY= X-SBRS: 5.2 X-MesageID: 39368451 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:rMRnOK2Q8/qdkGbdyrD5NgqjBQJ3eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/FIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFmtJ1/Z xLN5JzANiYNzVHpO7n/Qi1FMshytGb8KauwdzT1WtpUBsCUcBdxi1SYzzrdXFebg9AGJY/Cd 6w5tBfoSChZHQQaa2AdwM4dsLEoMDGk4+jXAUPAAQp5BLLoTSj7rP7FBbw5GZibxpkx7A+/W /Z1zHo/6nLiYDB9jbw9U/2q65Xltzo18dZCKW35PQ9Bz3whm+TFeZccpKYujRdmpDL1H8Ll5 32rw4kL4BP7RrqDx2IiD/M/yWl7zo08X/lzjaj8AveiOj0XigzBcYEpa8xSGqh12MasNtx0L 1G0gui3vI9Z3Ow/1WO2/HyWx5njUayq3Y5+NRj90B3aocCdKRX6bUW4UI9KuZwIAvB9IslHO NyZfusgsp+TFXyVQG8gkBfhPaoXng1Ay6cRFkDtsG/w1Ft7Q5E5npd68oFknga8pUhD7FC+u TfK6xt0IpDV8kMcMtGdas8aPryLlaIbQPHMWqUL1iiPKYbO0jVo5qyxLku/umldLEB0ZNaou WPbHpo8UoJP27+A8yH25NGtjrXRn+mYDjrwsZCo7Bkp7zVXtPQQG2+YWFrt/Hlj+QUA8XdVf r2EolRGeXfIWznHpsM9xHiWqNVNWIVXKQuy5cGcmPLhviOBpzht+TdfvqWDqHqCywYVmT2BW ZGcyP0IOlG80C3Sl71iBXcQBrWCw7C1KM1NJKf0/kYyYALOIEJmBMSk06F6saCLiAHkqFeRj o6HJrX1oeA4UWm92fB6GtkfjBHCFxO3bnmW3RW4SsDM0b+d6c/q8ySEFoimEevF1tadYf7AQ Rfr1N49eacNJqL3x0vDNqhLya8g2YMommJC7MRgLeK68ugWp5QNOdpZIVBUSHwUzBlkwdjr2 lOLCUeQFXEKz/ogaK5yLoOBO/ecNF4qByxIdFdrE/esUn0n7BtelIrGxqVFeKHiwcnQDRZwn dr9bUEvbaGkTGzbVckjP8AK11KYmSPCLdgBACIDb8k3YzDSUVVdyOnlDaagxY8di7P+18Jjm LsFyGSZMrGG0FQoHxez6bs/m5lb2n1RTMCVllK9alGUUjWsHd61uGGIpC+1GaccXMu6OAQOj OtW0pYHipeg/SMkDKFkjeLEnsrgqg0NuvGFbI5bvX4wXW2MrCFkqkAAt5Z9JtoL8rVr+cOSO 6TEjXlag/QOqcM4Ui4t3wlMC57pD0YivvuwgTi93X983glA/beSW4WMY0zEpW51SzDSPmJ2p ki0o5wkuu0L2nratmJjYvQdCVOLxvPoWiwC8EkwKokyZ4ahf9WJd38VzCN6VRsmDMZB+3wnF kFQKt67KvaU7UfN/A6SmZ8xB4RiN+LLEEXqQT4De81QEE1gxbgTqa0youNjYBqP1aIqwTxM2 SO6iFx///KWC2YyL4RYphAVlh+WQwZ6H54+vmFeJCVIAK2d/tb9F7SCA72TJZtDIyEE64XtB B0/pWhmPKWbTPx3ET1sSFgKqxDt0ahTsXaOnPAJcd4t/i7M0+LmK2k/Yqaiyr2UyKybwAgvr J+HHZgJ/hru30Fl4040i+7V6zxrAYEqjJlkE5av2+o/JOn7mfdFVxBKivDjPxtLGBuDkQ= X-IronPort-AV: E=Sophos;i="5.81,255,1610427600"; d="scan'208";a="39368451" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ESOjIKVOOa1TwZeituf2ZPETd7UoC1uRxnJ50j5zzI9dns6tLnWH3P2RrBXWrZ1CVxTU+EgLksGZDIhNwTORk0s/HYDWbISWnXCgn6pbaSPSkheBcKEldajTwtXCdOR/5OmY7yoOanRI7QxHgY32Fq3wQVjIOg+aTvMCoS7YolQ2jK/Kku582OxsaZcZNgGqdEEUun2dFc6vcaGAtqK8mWu90/Y0lj9i3zlgeKjAKYPsYi8KGmSESGU5xGSIghOaS5j4mps8ZGl4XQDA7c11gD0Sb2H3dVLpH6iUv4DtAryATfa4n4/JhErBfq0O4pgf5rjKobBz1YVKce3G1vIbbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2bAnlotiP0mzCSlLRX4b0h1kwvlfLAQmOZuMy8axsTA=; b=PdwAr7gzij1X//XwMcGzkYD4uKWcsKno5P7i8BGycCQqcz1AfjWKoUujrc1nZqv2t6G7izQFjgvgPZhOOK0sjwUU0aQmXkm7aJvbgtx9rk3y1Gg1+ueufIofYTf/cDTZMWgh+FQBXPOHIjRd7ZaQSP2rgWYPrSJMFdaW87VUXK9ya6IhRCShvejTGdzIynTySGRGKFhKv5oFyNxmAnsJQvL+3aqJFZ+JqjwzuG7uTfe2KVbdeU5T3C7tHy85owegcF4y7GIycSX1kH+CrRDcUyGkDNKkkQjRW49yjGIDPSWxgfVM8TNXUnawAh+8mZXwMi9RIFDXA7z7O1aliABxow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2bAnlotiP0mzCSlLRX4b0h1kwvlfLAQmOZuMy8axsTA=; b=PPjn+6622O8qI95+qwH/EROZ0qdT0+zAxqDYIa1vwyihHHLdADU7m3YxCZOsjMCyNG7NTlKPJZ5xfvmqEAgLZ1cXf49MFuyALdJvZdBVflSMQksQEMkAOIOXJEzJUbCNEL/6AJ1iMR9jfH63Tw8AyNJQct7CpgwpI6KA5LNZMEw= Date: Wed, 17 Mar 2021 09:32:20 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Xen-devel , Jan Beulich , Wei Liu , Boris Ostrovsky , Ian Jackson Subject: Re: [PATCH 3/3] x86/msr: Fix Solaris and turbostat following XSA-351 Message-ID: References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MRXP264CA0041.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:14::29) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 183cf8b5-f103-4436-6c16-08d8e91f325c X-MS-TrafficTypeDiagnostic: DM5PR03MB3066: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D3+ojkV4lNyyogpj+Z6keqIISQcKVYnsrsq4aYldDUpjeEIoREQBKfPsU8yOM+e7Nj7ceFTQpq2egkgtFp3w1kdB9mVyLtmgh2PrU2M9kes669e5HXcP3q1E33QvOjKtG8IchB8NcEkeKppVSkuwMhnfu8AXj5d9Upk7AcR8dym27snkbkdWXl70xlOF2/bDbACCQXdzKRLpqi0mxK+0yq2qc/SLCgV2i1ZJHIlcQQKuc7oi/g6vhvm1hmbcK02fA372gAJqgFRpGQjyXrwyAxpvFpX63D08j6dsPIEMRG40OnIIbTqpmr4Az7zF7y+ti7wIBPau0UlYRAtSCWDLB6HhwvqFQMfiSJ8HmdMFm9Qes1IgpscEkapmpJDuGhGBna9xJhUXGGj78dqSgb7JuW+3UapWFrwpHbedmISErJRp6RSL/RguAnlFcioO+Qx9WHb9n1z2Exo/IlDPU5KIWuptI+aJVmGkCQ2ug/ETLGmFqJqLkdsWUCDjJN7KhuOAbR6P5lMztRehQYsrir3XBTHTFXvwIuEgEHz316bm9Hh5s63J246eR0EdR1pFxkBKC/8cIXiWUfIx/S3Kiwebo8clePasXqoJrH9lkCvXQMSfkVM25wFoO0szwJ970p5g X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(396003)(39860400002)(136003)(376002)(346002)(6666004)(8676002)(66556008)(33716001)(6636002)(66946007)(6862004)(66476007)(478600001)(85182001)(86362001)(8936002)(83380400001)(966005)(4326008)(956004)(6486002)(316002)(26005)(186003)(54906003)(16526019)(5660300002)(53546011)(2906002)(6496006)(9686003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?QzBZQm02VnMxbVI3b2VnN1ovYlc2NUU4NVU3N2x2d0piY0VNc0FHSUZRbmg0?= =?utf-8?B?eUFYdHJHU3pNeUdsODUvcGw3SUVKVlNNZ0MvQUVyaytubDVBWjZkQ09TSG56?= =?utf-8?B?K2lGOE5PTlV5L1ozbXA0TlV6dm1QeFFKeU8vZm9HR1p1VGlOaVpJQURiR1Zr?= =?utf-8?B?WDlWMm04YklEY3FoWE15STZGcVNLcEtPcW15NHdVdHRVcVMxZThlbVB5YTUr?= =?utf-8?B?UG0vQi8zT29TaDM3UDh5cXkyU2NJcUQrTHpBU2xSdHp4S1RwVFB2dVhTVzZ6?= =?utf-8?B?dU9wSzM3eWFNQURPWlpKcVRseTVyOVpIOHZYNDJweTNEb3R2Ti9HclB1SFd3?= =?utf-8?B?MnI4aFN1cEUwR1V1TVdJdDBCMERWSWZqYjBDek90NmtuQ1pLUVRvWTB0N0Vr?= =?utf-8?B?R2ozeGYxUWVCOHpnTlBSeExZK1VUM2RSQ2VDTjI5M2RSeVdKRnd2aVlweERG?= =?utf-8?B?Q0NzOU01emlhQVNTOTBHK21HZFFKdnhtMkJGRkdvOEdQbHl2amlpRFJSbEx6?= =?utf-8?B?TFVWd3liWFJ4ZjkvR2l1VW1DZWFXRi9qTDc2MUlkZG0wYTJJMU5GNFhDS1dz?= =?utf-8?B?LzZxNDFDYVN5cFVCcytsTWpLNkIzd1BubU1LN0l5VERsWjZVOCtYcnhhYjdT?= =?utf-8?B?UEI4cFVyS2daNWZnYm9XSGhOajM5aENpaTYwaXF5a3pKbUpHZnR6TXVCYmpX?= =?utf-8?B?R0JjdzJpZ1FoSjBFZ0QvU2k1Sy9XUy9aTFZNRzF4SEw2SGh5SVNCbllHL1A2?= =?utf-8?B?WjQ5Z3VZOTh5MjBJYTZSVGtTQ1pRR3JHVWVNWERXdlVTQlZLZkJoNmNuWWlt?= =?utf-8?B?UW9pZWVEK1lIc2JxQTljYzZWSnlDNXJ6ZmNZcEx2VzhGZ01jVW5NejZuSklj?= =?utf-8?B?NHRuZ3pyZEhUa3RPMTI5K1hvVVIyM1o1b1NYdFg0UlQyWTNEZFJnU09lSXBy?= =?utf-8?B?U3luWm1sR05qTWk3cXNIRWl2c3RyK1Z0UGx6R0JZSWMvaW1iKy9hc2g5Uzkz?= =?utf-8?B?TFNFY3ZkSEsydlJ6MmdYTmdJczlCSnZXVm1wb0REdDNST0lXVnZxMHRWd2FJ?= =?utf-8?B?MHh0cG5sK1plbnlIUHJqRnYrYWdYWTNDWmNNbHJzSDFLVTMreE1BaTk2NWJX?= =?utf-8?B?MEtWYm5ML0ZtMHBaVkQ3RytYTkUxSlpyZDZHRi91bVhBQktFSEQ4cFd2dXVG?= =?utf-8?B?OFAwSXo1c1ZtYmdKYWI4aDhpdEF4Wk16NUNzVjZKUm5tSFhHcHM3RVppbEVK?= =?utf-8?B?bUgyMHBzU2tFaG9sM1Q3TjlYNEl4V2JGRndkdkdRaHhjU0QzN2NFNGF4eXBs?= =?utf-8?B?bC9wQ2RNKzZETkJwcVI4ejRiOWJhdklOTHBPbUM2Z3E2K0VvTDRaTUl4V1A2?= =?utf-8?B?aytXMUc0TGVBeFFOSndHcVRwMGhuRm1PVlM4WUs5WXJ5NzNpRE91ajhveUZC?= =?utf-8?B?OVVNeW5EZFRTUFpURkVaYTBHTVpLZHprcEdSMjdJeTJqclkrR000ejVDZ2RV?= =?utf-8?B?eWZpVGtpdlhSNjZKeTBMYWM5ZWx3WDI2ME9wNEZVcS8xZDdHVys1aU8zSDhn?= =?utf-8?B?T1Z0dTBmaDVQY1VHWXZvUS9hWG1oZllzU1YyeldBS2UrR3Q2ai9MRzhOcEdI?= =?utf-8?B?T0doL3BFMmRwOFY0cG9OTFltM3M2b1pleG8zWEFhbUMzNWVkVGRtVFExenlS?= =?utf-8?B?eUFmbkw0RFc3eXphNlYrTzVzcnk3WE9qZEFXczBVT2VPUWRoWXcxL1Mxa1pM?= =?utf-8?Q?jRfPtiB2to7j0zJwGPHbrm5y8kvHZbl3lb+aNYY?= X-MS-Exchange-CrossTenant-Network-Message-Id: 183cf8b5-f103-4436-6c16-08d8e91f325c X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 08:32:27.4038 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DBMlZudHxO/HodN32MaRbQP6OcCsvlbK3vnN9SCjaN8njR0yIqmGVtwcmwcbC9r29cdGDJHFta/kJlcuC2LVmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3066 X-OriginatorOrg: citrix.com On Tue, Mar 16, 2021 at 09:20:10PM +0000, Andrew Cooper wrote: > On 16/03/2021 16:56, Roger Pau Monné wrote: > > On Tue, Mar 16, 2021 at 04:18:44PM +0000, Andrew Cooper wrote: > >> Signed-off-by: Andrew Cooper > > Thanks! > > > >> --- > >> CC: Jan Beulich > >> CC: Roger Pau Monné > >> CC: Wei Liu > >> CC: Boris Ostrovsky > >> CC: Ian Jackson > >> > >> For 4.15 This wants backporting to all security trees, as it is a fix to a > >> regression introduced in XSA-351. > >> > >> Also it means that users don't need msr_relaxed=1 to unbreak Solaris guests, > >> which is a strict useability improvement. > >> --- > >> xen/arch/x86/msr.c | 13 ++++++++++++- > >> 1 file changed, 12 insertions(+), 1 deletion(-) > >> > >> diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c > >> index 5927b6811b..a83a1d7fba 100644 > >> --- a/xen/arch/x86/msr.c > >> +++ b/xen/arch/x86/msr.c > >> @@ -188,7 +188,6 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) > >> case MSR_TSX_CTRL: > >> case MSR_MCU_OPT_CTRL: > >> case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): > >> - case MSR_RAPL_POWER_UNIT: > >> case MSR_PKG_POWER_LIMIT ... MSR_PKG_POWER_INFO: > >> case MSR_DRAM_POWER_LIMIT ... MSR_DRAM_POWER_INFO: > >> case MSR_PP0_POWER_LIMIT ... MSR_PP0_POLICY: > >> @@ -284,6 +283,18 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) > >> goto gp_fault; > >> break; > >> > >> + case MSR_RAPL_POWER_UNIT: > >> + /* > >> + * This MSR is non-architectural. However, some versions of Solaris > >> + * blindly reads it without a #GP guard, and some versions of > >> + * turbostat crash after expecting a read of /proc/cpu/0/msr not to > >> + * fail. Read as zero on Intel hardware. > >> + */ > >> + if ( !(cp->x86_vendor & X86_VENDOR_INTEL) ) > >> + goto gp_fault; > > AFAICT from Linux usage this is Intel specific (not present in any of > > the clones). > > Indeed. > > > > >> + *val = 0; > >> + break; > > Do we also need to care about MSR_AMD_RAPL_POWER_UNIT (0xc0010299) for > > Solaris? > > AMD has a CPUID bit for this interface, 0x80000007.EDX[14]. Right, I see now on the manual. I guess I was confused because I don't seem to see Linux checking this CPUID bit in: https://elixir.bootlin.com/linux/latest/source/arch/x86/events/rapl.c#L773 And instead it seems to attach the RAPL driver based on CPU model information. That's fine on Linux because accesses are using the _safe variants. The patch looks good to me, I wonder whether you should move the "users don't need msr_relaxed=1..." to the commit log, but that might be weird if the patch is backported, because it won't make sense for any older Xen version. Reviewed-by: Roger Pau Monné Thanks. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 08:34:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 08:34:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98578.187065 (Exim 4.92) (envelope-from ) id 1lMRd1-00036s-M3; Wed, 17 Mar 2021 08:34:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98578.187065; Wed, 17 Mar 2021 08:34:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMRd1-00036l-I8; Wed, 17 Mar 2021 08:34:07 +0000 Received: by outflank-mailman (input) for mailman id 98578; Wed, 17 Mar 2021 08:34:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMRd0-00036d-J0; Wed, 17 Mar 2021 08:34:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMRd0-0001sM-D8; Wed, 17 Mar 2021 08:34:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMRd0-00086I-3v; Wed, 17 Mar 2021 08:34:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMRd0-0004vb-3R; Wed, 17 Mar 2021 08:34:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QaIbv1ER/P94OYH7MiV+WmhlXnELwJ785Y9V9o6oNws=; b=rSPmCPO0Nq56jkD17GvfKA3apY mqeqb2dJBkg3DVOrlfDcrskfwFX4afjumiwyl8qbwp7l+NuozfpVGHbl52aGLTkWb+2Lgb7KIuxpa 5h3XTY2xCqw0R5D3ObMiorFdWRoD9HV5oqO/o+X1+PKxEMAZqjpzRd+1TUGatj49Llcw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160106: all pass - PUSHED X-Osstest-Versions-This: ovmf=2e51b27fed31eb7b2a2cb4245806c8c7859207f7 X-Osstest-Versions-That: ovmf=66a31de7eeed62a7aa68fe0613a597a8bf08bc16 From: osstest service owner Date: Wed, 17 Mar 2021 08:34:06 +0000 flight 160106 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160106/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 2e51b27fed31eb7b2a2cb4245806c8c7859207f7 baseline version: ovmf 66a31de7eeed62a7aa68fe0613a597a8bf08bc16 Last test of basis 160103 2021-03-16 21:09:41 Z 0 days Testing same since 160106 2021-03-17 04:11:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chandramohan Akula jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 66a31de7ee..2e51b27fed 2e51b27fed31eb7b2a2cb4245806c8c7859207f7 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Mar 17 08:41:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 08:41:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98583.187080 (Exim 4.92) (envelope-from ) id 1lMRjx-00044D-Ec; Wed, 17 Mar 2021 08:41:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98583.187080; Wed, 17 Mar 2021 08:41:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMRjx-000446-BP; Wed, 17 Mar 2021 08:41:17 +0000 Received: by outflank-mailman (input) for mailman id 98583; Wed, 17 Mar 2021 08:41:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMRjw-000441-HC for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 08:41:16 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c3804235-f04a-4878-a7bf-0219438dd8df; Wed, 17 Mar 2021 08:41:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3804235-f04a-4878-a7bf-0219438dd8df DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615970474; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=/RMgB6BBRjGqIs/Yg9pdp4/vYfjRYLQgoiBoy++X+N8=; b=FZBsvSliFzlnh8FNrwfbf6UUBtucdH6clW7AjqgO4NnUErGRc2djbzB0 Gm+gb425qAIo6cYCEqtxaIIRF9mzzFqAEH3l4L2Z48lj9LjPUAHJ1krZY y5FDGUULn8LOb9yEuNCv3SpnusktfoGY3IG5NKJyUAGC7GXBVfEOha8bI o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: cD8GqvqOqlwgKcg83JCp1iIizneX98ZRZq6hqW/Fr81Y0Busdf5z0piajlzhaipb7vBFNlt7NP vn9xi1Hj/wB80i/6dYU/33gATduD7f7iyusKUabD/rmstrUVB8fs1f6Gg5eV/+hrVSeXyrq8JU E7tWUMyBUCjqb8sauYfXt9VP9eDQLK5oiq0aQbPuCMjGh7Q0Xd7q1o34bXVv4Oq2rweS5/xErH nHAGkS+3aZFdmBC2Zoqbt1193uUPpLi4JwPQewMd9qXc+rRlmyd1Lv24G619BdLMmuG4p37uXu 0DI= X-SBRS: 5.2 X-MesageID: 39480783 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:zP9yHqzXciinHuQnE3e3KrPxve4kLtp033Aq2lEZdDV8Sebdv9 yynfgdyB//gCsQXnZlotybJKycWxrnmqJdybI6eZOvRhPvtmftFoFt6oP+3ybtcheTysd07o 0lSaR3DbTLYGRSpdrm4QW+DtYryMSG9qftvuvF03JxV2hRCp1IxS0RMHf9LmRdQg5aCZ0lUL ed/NNAvTq8eXIRB/7LfEUtde7FutHNidbacQcLbiRXkzWmoBGJzPrBExae1goDSD8n+9kf2E XMjgCR3NTAj9iV0RnZvlWjiqh+uNyk8ddbAdzJt859EESQti+NRKBMH4KPpyo0pubH0idarP Dprw07N8p+r1P9F1vF2CfF4AXr3DYw53KK8zbx6hGC0K+JNw4SMMZPiZlUdRHU8SMbzalB+Z lGwn6DsN5vBQ7A9R6NmeTgbQ1glUa/vBMZ4IgupkFYOLFuDIN5nMg0+UNYF4o4ByTq6IwrO/ kGNrCi2N9mNXyddHzXpW9p3ZiFWWkyBA6PRgw4ttWSyCU+pgE182IogOgk2lsQ/pM0TJdJo8 zCL6RTjblLCusbd7h0CustSda+Y1a9DS7kASa3GxDKBasHM3XCp9rc+7Mu/tynf5QO0d8bhI nBeEkwjx9yR2veTem1mLFb+BHER2uwGR73zNtF2pR/srrgAJL2LCy4Tkw0mcfImYRQPuTrH9 KIfL5GCf7qKmXjXaxT2RflZpVUIX4CFOIPvNIWXE+Pv9LrJoXmuvezSoeRGJPdVRIfHk/vCH oKWzb+YO9a6FqwZ3P+iB/NH1PhE3aPv65YIez/xaw+2YINPopDvkw+klKi/PyGLjVEr+gTdE t6K7X3r7OjqQCNjCP1xlQsHiAYIlde4b3mXX8PjxQNKVnIfbEKvMjaXmxOwn2dJFtaQ9nNGA BS43R7kJjHYKC49GQHMZaKI2iah3wcqDahVJEHgJCO4s/jZ9cfFZYpWKt4EC3RDBxrkQNWqG NOATV0BnP3J3fLs+GInZYUDObQe51XmwGwO/NZrnrZqAGhv801f2AaWDSvSMaTpg4rS1Nv9x lM2p5apIDFtSekKGM5juh9FFFXcmyYDIhLCxm/aJxOlqrmfxxxSmm2lSWX4itDClbCxgE3vC jMPCeUcfbEDh5mtndU3r3D3Xl0em+eFngAIkxSgMlYLyDrq3xz2eiEau6PyGOXcEIF2fxYGi rCeyEuLgRnwM2X2BaZlC2ZL2gvwowjM4XmffMeWoCW/knoBJyDlKkAEfMRwY1sM8r2tPQXFc 2YYA2YIVrDepQU8j3QgkxgHiZ6qHMpy6y1nDLk6XW1x345D775Jk98S7QSPtGb6CzFSp+zoe BEpONwmdH1FGP7LuOi4+XwSRVoLxvIu264T+0ys/lvzOsPnYo2O6OeaCfC0XFM4Q43I8j1nn 4PWagT2sGyBqZfO+gpPx9D9lUnlN6zPFImnwz/DOg5Z0wshRbgTqe0youNjbokGUuaogTsfX GZ7i1G5v/ANhHznoIyOuYVIW5MblI752kn1OSed5fIAAHvU+1Y5lK1Pjucd7BaIZL1U4k4n1 Jf49uSmfWQeDe98AfMvSFjKqYLyl2Ze6qJcXSxMN8N1ce7N1SKirar58D2rA6fc0rGV20owa tfdUIRacxfjCIFl4Nf6Fn1dpDK X-IronPort-AV: E=Sophos;i="5.81,255,1610427600"; d="scan'208";a="39480783" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DJm0zpJiTGp633nyEHPZiPyLq5H4BuzxIpDTgN85Wt8m4FOVS35LTG74/uv7uqh5Cu+zRjTnOe4m2istjO1yG3qL24clb+0Ps1GVly7OAkDkCqq0U2Pw5Eg9ACHVMAYPHfNChHA6AprDuJYT4iZxA2KCQlAkIEmGfUTVFxHjsspMj4mPCnzBDLTg+o5x93NxVMxsKp2U6LxVMkqeOjzfzu41P5s/5hZhNzB4K5q1Lt9T4i4PTt8TBIVgq1xTQNWQhCtuLoFPTQsofEW5s92LPbHfy+TZX8okIMLMxWzAwwALmebfhm/rq5tTpXNqQ8r5/KKWUf/IMj9e2umkUjGP2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hFyGBI/eiR7KrWqWCdQTtNC4YUgmYVqHlxSKYFtdePA=; b=Mbfee2XNnk62Peup5hY2UhQz282NnQxcA6dIXwOqyyPFloltc4Mxo+q0l8GbqkZZ2F9CutSx5C7MBEnnvjTiVqFaM5tZNVAH+tu+NPFdgm5CfD74oRET7fX1E0yPOp2o1oEQeIMnTVoTMk34u/HujcOmc65aXwLnljag1lJjlLh5ggYK1kILuYQar1ysAyMwk8wdI9MsfXlnqzPG5lKofkgFwv2GX47Z3Xk6ZiOxGY8ryVGNwOstUZcKL2XnH4EoLSZvoX4sdqh6Lo0kapeeon3u7kLSmYBDHzcAwItKNVKClG5fGaAyjDCbmbN2Juy41lvdi/VMuIHzfpPXa4tUUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hFyGBI/eiR7KrWqWCdQTtNC4YUgmYVqHlxSKYFtdePA=; b=ps186h8VS8LycLq/eufAeoNi8Bqxv94LyyAQyJ0KyPcWPN1yfxvVML5aY3GwxrTej+n9nsdY7NJgK2bZnsSvNoIYUxI/o3M3pEdkTNFD+xnUY6VTWopnuPo9cYoVDE770AFtwubT1CvzDIu11Ip4MqS42DDSmDEBNeEuFmmAIoI= Date: Wed, 17 Mar 2021 09:40:42 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Xen-devel , Jan Beulich , Wei Liu , Boris Ostrovsky , Ian Jackson Subject: Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" Message-ID: References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210316161844.1658-2-andrew.cooper3@citrix.com> X-ClientProxiedBy: AM5P194CA0022.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::32) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 771e6944-02a2-4a2c-aaac-08d8e9205ce6 X-MS-TrafficTypeDiagnostic: DM4PR03MB6190: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oMa4V1Lq02Y7RtH4Re+U7X0Ur0qKwhu2Opepk+u74D8TlnHUTn28GYJ+boO8aUkt5+cZkL+DBE5OJ8OqwZ3e/HUgtjBJm7DPl4ydKxu5Qx9m8PLFQNfAOprVatLSA8P24/y4G4RbBNx6dJ15lcisUAmIHSQyLr1GlS/Z/Rqf2cvI3+6G54aIQLAVx6c5XIwvHCntD0HKJ9V9AAlsnVe/4jpL4s2vkrRw5NlediOIBNFXQ7AKUtyEAYLlkhTL2q/CYQPqaJ0W9QGnesBcWgsnke8XPJHrqVQBMehoIJ+sRxTEaaJJuibcoAD3Xl/81uzjB7E7TIb8+eGYIl5lJuXtPU2PbzQWsjuV7ykekEHUt9VUf0vOESeTcAo8yGdN3D1+o2Ydk++GTrVBOH+Ysrh7r5mHGRCIERTinTURRjFGK0Gq7pA8qEzqvmZv2wUDt0Kk4/txuiXj2j7NEgf7tPFqkTJ1jDdfsWnpC7tA4cEbHwIt6gEszchcmOP7WfMgffVSpl86IlU8eCP3WiiVaHc+/6cjB45eG0OOVgjvcDCZd+gZTMSibeB9cTpbSbHQUiL9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(376002)(396003)(366004)(346002)(136003)(39860400002)(2906002)(478600001)(85182001)(316002)(6862004)(956004)(16526019)(66556008)(54906003)(5660300002)(4326008)(186003)(83380400001)(66946007)(33716001)(8676002)(6666004)(9686003)(6486002)(6496006)(26005)(8936002)(66476007)(86362001)(6636002)(4744005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?b3FpQzkySDBJbjR2WnFiUDBEREZYMVJwZCtpZEdyaVkwMUluaFRzYlZaQWt2?= =?utf-8?B?bUlUSCtBNWxVK3VDVFBZdVE5dUNYbllHMFl0UUhONEE0SHF4V2QzVzV6ZWsr?= =?utf-8?B?MmVBenhFT3JseHNhbXNnN3VwTWFxcXREbUVldU1lMmNnOWp6bWdRUjhNRDcz?= =?utf-8?B?QTQwbzhhdDEyNlBsRTBtNnBsZ1VxdHdMazAvNFFwR2Izbk1GT0tNTTZiT1BD?= =?utf-8?B?UjNyUVVpUzM5bVVEY0JqcTZYYmhjZ2tmL1BQMEVabEFjcWNoblRST0NSRTdw?= =?utf-8?B?QTJnNWNRdnhXeENweXcvbXE4eXFkOWFRSlRjekcyVk91SDN3Y3J5SGZtZms3?= =?utf-8?B?YnBqRTVZSWFyczFQMmwzNWl2UkEzYlpSQldhckRrSUhvTTVsb2hIMHdHNnZo?= =?utf-8?B?K1ZQblJwbkJCcFg5V0RGaXlTYWZwSndUMFB3YStNUGhqWDJjM0lvaWhXQmZ0?= =?utf-8?B?ZmNtOUh4NFR6Y09GUTc0c2ZENENpS2kxZCtaajFJYzNBV1NVcjliZnJ5UnNE?= =?utf-8?B?enQxRFBZZE1LSi9CUEZqMnBBWXBDc0doYjBjeHN6aUs5N0NrS3pXcklNeC91?= =?utf-8?B?YVlVVm5VelIwL2J1eDU1ZldzWXVCZk93QzJMVGlweGR5aExtUGVISDZvWXJm?= =?utf-8?B?TGVwVm1FTlRHQ0VyK2NpaEczUkxiN05CYlUrYk9oTzU5YVQyQ3FUOWJlZE5V?= =?utf-8?B?RHRab0UyRFFqVTJtWXgxd1h0YXZRNjlvSlVxNzRPQUNLNmVjM0EvSHNTeTd1?= =?utf-8?B?eExTQ3pEVC8wVWVJSGVTanZyTHY1bkNhNWlPNWhHTTZ4MjNING9TK1AyNkcx?= =?utf-8?B?VHZIQ0dIRU1TMlk0eEZMcFZ3WGRVdS8waHNBbCtZbE43bnNWUG1UdjBhbmha?= =?utf-8?B?NDBVRkJmQkJLZnpNSGxzSThoKzVhTCtCQm5Zc2ZjWXkvUHdubXRVUE1BRGlG?= =?utf-8?B?MUJIV05EQm9qOEJsV2NlZHQyd3V4dGt4WjBXVEprdENneUhsdzZ0T1FYYWdj?= =?utf-8?B?dlFRVXpLNDEvUndSRGF6YlZIVUpsVkdPdm1odzc0R0hNRU8rTXRPbTBaOFNN?= =?utf-8?B?Sm94YnVRMk5TK0hrYm1Jdnd3dThjSHZNYjE2dlExcXpTWGtZZnFYd1hGaWRL?= =?utf-8?B?amZOZVVyTkpNLzJMVThEWEQvREtIeDQ4MXBsZlpCRlovSm0zeit3blB5Zk5m?= =?utf-8?B?bG1oSXovYkJqTHNDdlBYU2hOSWwveVJTdy9vek56N3hCckpRVkhSMEJlWW41?= =?utf-8?B?eGJFRlY0ek53dkQ4QlJ5a2s5TmNVT2YvUDRPYkRIR09wOFJKcXRnSTZwSmJa?= =?utf-8?B?bm9BZmE3dEhmVDFmM3BxckFVek41MUJCTVNHUkpENWwwRUJBRk5iQnZaODlG?= =?utf-8?B?b2Q1Q0dCUWh4aWZhS2w1Y3VqL21nL0NDOFRrMWcwY2R3dzFRenRMd042cHg3?= =?utf-8?B?Y1czM3FGQVVnWjY4M2tXby9JMkxlemh4WkJYdlc1anJQMkFHTGdiTHU0NVNV?= =?utf-8?B?NldqNnRJRkRyYmwraDZhWXZiUGUwVVVVVHFOa09jMjdpK1E4N0hhcFJrNUQ4?= =?utf-8?B?MStZVDlqU2hkMTgxd2l6RGhUNFJ5YUsyVlNxamJ6ODl4RklaZ2hFUXpsTUkw?= =?utf-8?B?Rnd0dmQ2NkFsM0hZZUNoOWlTOGkwZ0VGV3hRUmZaWnFNUnNzZnZXaWcrSHlh?= =?utf-8?B?YUJxR254bUtQRHBDdWxrb3A2aGwvbWNRUktPcHRBQ1ZYVGYwQ1dGakxCNURS?= =?utf-8?Q?/IdeKanPartWDZdJDICaZg4qsDd+zXRkNG6MG3i?= X-MS-Exchange-CrossTenant-Network-Message-Id: 771e6944-02a2-4a2c-aaac-08d8e9205ce6 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 08:40:48.0906 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ozefVMY4TBqZivIy0K5u50pgKMAVPVwd25tC/TS6I4pf/+gyyZNit8NaJbsVXE+4fvGBD3Xi59CIxzJY9Qz5iw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6190 X-OriginatorOrg: citrix.com On Tue, Mar 16, 2021 at 04:18:42PM +0000, Andrew Cooper wrote: > In hindsight, this was a poor move. Some of these MSRs require probing for, > causing unhelpful spew into xl dmesg, as well as spew from unit tests > explicitly checking behaviour. > > This restores behaviour close to that of Xen 4.14. I think it might be worth adding that guest access to those MSRs will now always trigger a #GP, even when msr_relaxed is used. This is however fine, as that's not a regression when compared to older Xen versions, where access to the MSRs also trigger a #GP unconditionally. I assume the wrmsr side is added so that when using msr_relaxed Xen also injects a #GP for writes to those MSRs, as it would do for reads? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 08:52:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 08:52:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98590.187092 (Exim 4.92) (envelope-from ) id 1lMRuk-00055m-JS; Wed, 17 Mar 2021 08:52:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98590.187092; Wed, 17 Mar 2021 08:52:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMRuk-00055f-GJ; Wed, 17 Mar 2021 08:52:26 +0000 Received: by outflank-mailman (input) for mailman id 98590; Wed, 17 Mar 2021 08:52:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMRuj-00055a-7l for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 08:52:25 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9563a52d-c816-43fd-89e6-e8544d550ff9; Wed, 17 Mar 2021 08:52:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9563a52d-c816-43fd-89e6-e8544d550ff9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615971143; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=xiyVtiiGMxHuZ31sEqNBV4I0rAGUMo395hxy9E97LLI=; b=GqV6u8msiSgbRUYYHecwf5anH91PSTH74QVBCC82FCzkaBPIxEQ8zwv1 SHjkfZTVoj3YGHiw0CGLxF5sCYFJUEcrtlC4P09DnNtYf3l+GHa1/bGHz 4AUDZ31lFIYUIxC8Wd8CLaA6/riUtFKNjTQUS8ExHwi+lQxNXBK0ZheoR E=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: O1nk1fK76BgWlVcv6A7LKeKjpJUkJ8Z53qwVVjHVjOi7D9HobMvGckgpIxRsPJ+7QA1aGObsCG iz4Nr25Zatb+K3Nfl94dHxWoV9TMSyUkorMnzXP4WfFn1GH/MTRMbuyu8Axd6xO+MJCoAoEX9K NzQ9BqeaU0AXxbC9cA4I+C0gIN41mDQlzEQUE8ZLS2kYnKgVg64C2d+LV0xkwponHMEZRAF2Iw QnD3lgrAb3CeojK9BHRojDYx5O20JgR23jL1Q+DXR1m+xV1QkvubiYyqdUCj6l8q/3kbAona3S FEA= X-SBRS: 5.2 X-MesageID: 40897749 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:DDnFfK3ri6Tgn14W2/0t4gqjBQJ3eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/FIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFmtJ1/Z xLN5JzANiYNzVHpO7n/Qi1FMshytGb8KauwdzT1WtpUBsCUcBdxi1SYzzrdXFebg9AGJY/Cd 6w5tBfoSChZHQQaa2AdwM4dsLEoMDGk4+jXAUPAAQp5BLLoTSj7rP7FBbw5GZibxpkx7A+/W /Z1zHo/6nLiYDB9jbw9U/2q65Xltzo18dZCKW35PQ9Bz3whm+TFeZccpKYujRdmpDL1H8Ll5 32rw4kL4BP7RrqDx2IiD/M/yWl7zo08X/lzjaj8AveiOj0XigzBcYEpa8xSGqh12MasNtx0L 1G0gui3vI9Z3Ow/1WO2/HyWx5njUayq3Y5+NRj90B3aocCdKRX6bUW4UI9KuZwIAvB9IslHO NyZfusgsp+TFXyVQG8gkBfhPaoXng1Ay6cRFkDtsG/w1Ft7Q5E5npd68oFknga8pUhD7FC+u TfK6xt0IpDV8kMcMtGdas8aPryLlaIbQPHMWqUL1iiPKYbO0jVo5qyxLku/umldLEB0ZNaou WPbHpo8UoJP27+A8yH25NGtjrXRn+mYDjrwsZCo7Bkp7zVXtPQQG2+YWFrt/Hlj+QUA8XdVf r2EolRGeXfIWznHpsM9xHiWqNVNWIVXKQuy5cGcmPLhviOBpzht+TdfvqWDqHqCywYVmT2BW ZGcyP0IOlG80C3Sl71iBXcQBrWCw7C1KM1NJKf0/kYyYALOIEJmBMSk06F6saCLiAHkqFeRj o6HJrX1oeA4UWm92fB6GtkfjBHCFxO3bnmW3RW4SsDM0b+d6c/q8ySEFoimEevF1tadYf7AQ Rfr1N49eacNJqL3x0vDNqhLya8g2YMommJC7MRgLeK68ugWp5QNOdpZIVBUSHwUzBlkwdjr2 lOLCUeQFXEKz/ogaK5yLoOBO/ecNF4qByxIdFdrE/esUn0n7BtelIrGxqVFeKHiwcnQDRZwn dr9bUEvbaGkTGzbVckjP8AK11KYmSPCLdgBACIDb8k3YzDSUVVdyOnlDaagxY8di7P+18Jjm LsFyGSZMrGG0FQoHxez6bs/m5lb2n1RTMCVllK9alGUUjWsHd61uGGIpC+1GaccXMu6OAQOj OtW0pYHipeg/SMkDKFkjeLEnsrgqg0NuvGFbI5bvX4wXW2MrCFkqkAAt5Z9JtoL8rVr+cOSO 6TEjXlag/QOqcM4Ui4t3wlMC57pD0YivvuwgTi93X983glA/beSW4WMY0zEpW51SzDSPmJ2p ki0o5wkuu0L2nratmJjYvQdCVOLxvPoWiwC8EkwKokyZ4ahf9WJd38VzCN6VRsmDMZB+3wnF kFQKt67KvaU7UfN/A6SmZ8xB4RiN+LLEEXqQT4De81QEE1gxbgTqa0youNjYBqP1aIqwTxM2 SO6iFx///KWC2YyL4RYphAVlh+WQwZ6H54+vmFeJCVIAK2d/tb9F7SCA72TJZtDIyEE64XtB B0/pWhmPKWbTPx3ET1sSFgKqxDt0ahTsXaOnPAJcd4t/i7M0+LmK2k/Yqaiyr2UyKybwAgvr J+HHZgJ/hru30Fl4040i+7V6zxrAYEqjJlkE5av2+o/JOn7mfdFVxBKivDjPxtLGBuDkQ= X-IronPort-AV: E=Sophos;i="5.81,255,1610427600"; d="scan'208";a="40897749" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hLH2CJGtHtidGAwidq5csmJUx/ejEa3+k8Z/xOwFGS4tZh5/ZReriFx0MOULJAQEBjGy/O868ECso2ZC7V0jcDeTlvNUSz6tj489MudEHJHKvKnRYDu72CMsdgUll4aCElbxjoivNxLjN98bY0ZqPdlbnHa6Bk7olM6LQANhBjnCg/UZlynDPE442rFcplxRlva0eg72+wt1q4ZCZmEjmA9YVRQwD1dIMzxArZrZJ3/HCJPFZdXkvOcivjzHUCJFyRv3Rp6Tz+u6me7e1Kl5OxV9izhD35KQwbTWHvc7kHjU6oTXxO4lYFfkyFZCH3sKTs4XitAvj2pDipbJMs/j+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RHQUwttASt7RhW2MN55+wcIRzwQZgBIkB/veUU4YPEM=; b=mhr+mBe2JXgKRobdZOEY8ap+VNVRpkItG2LkZcGtPx4YBvP73EEOtDkTjfW1eHJLj42iBIg2cgRSOOqAzzSwMD/qKz1DiwQu0QBDQDed61Y2k8D+8QSkH4OqfSi/OUvSmlrUJmJFMoMzHESutn9buKKme2Ew2FuwVKI29FhjdgR9vs2fE70N3Kla/F+c/RmFo8IVtGzXcltZwbi6pYr/BIA/4lGAMMakpIM91iS37PfufaQtjRPS/slSUmqZv7PDBCS7ZZTS27jLoN/qHF3032bTt2Qy5B/8MNE+pTD+7PpZJ9esw8JU97VkAvi9030lQMGv0WBit0qDCfuldRSfWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RHQUwttASt7RhW2MN55+wcIRzwQZgBIkB/veUU4YPEM=; b=wRK3enjzP7g931kqT2xCI/hEzU9l6c41U0uZ6Vjzec6hym0EeoQ0BcgzTcgr9GW3Tur1gCnH4yfkejXv6cmiy72c1oWk1kU0psTnR/rPzUXl3L2iRjUnUPuSJ97njzC96EvceYa1hjywBOJTIxl8XryGNyafKjcY5TYbZU2hueY= Date: Wed, 17 Mar 2021 09:52:12 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Xen-devel , Jan Beulich , Wei Liu , Boris Ostrovsky , Ian Jackson Subject: Re: [PATCH 2/3] x86/msr: Forward port XSA-351 changes from 4.14 Message-ID: References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210316161844.1658-3-andrew.cooper3@citrix.com> X-ClientProxiedBy: PR2P264CA0014.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::26) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a3ac1124-8b66-4937-ee87-08d8e921f88a X-MS-TrafficTypeDiagnostic: DM5PR03MB3291: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CViDytryaFgJo0u5Mpq0MrK48fMrXp0bSlyyEWNGcerfB0sCFDw71JH4mZ//JgRED9Qotw8jL40ppUadoQcyOrKUqsGnDw1gwfcf5cYJZsyJzQsr40Xb1FHj8C+Q7lygDly0aXGFUwGcIVOphm+g0zu1GqObY+Lrn5OQh4xIvCyAjgT/+M07soyisyRck0qzmXZgWqkMxUgfH90U3+58WnB4At3dG6nK9uPc+8IyVhwI0JF28zhOeNDMgQwpeMZUptvKsGjp3HVp2KvKNMP0/rLvHZf7RwsS/ip5cfcsyJDbBR+e1tuuz+KbDt8Rd0vd+BHpaGLwzCGF1l/Czj1MFP0N2K+vphChQBF0FPxO0VmtY66F5bWchPq+cqamP7j+v6QN7T2n7eacLIK3Eyno7EUNk9vPpp4WODkQOocOm7r5NkCW/HGy+JVCtXdjZjQ4qKtRpUapVd9hp+vGCUzTf/z3ShexeJSvTzFZpPZnmMzjmkFvnFJywwIlnL/RHLLaFqqA0xt4i/YRNXIuJGVe7ZQLUrQ4oayEno8D5GZlYA9l0Lz3RXOGhGlPlIjK3/ic8ili/fjDKGrtFchBnyLZPOrRnPhtreAndicwfg9AJYU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(136003)(39860400002)(366004)(376002)(396003)(346002)(2906002)(66556008)(85182001)(4326008)(9686003)(66946007)(6862004)(6666004)(33716001)(6486002)(86362001)(83380400001)(5660300002)(316002)(186003)(956004)(54906003)(16526019)(6496006)(8676002)(8936002)(6636002)(26005)(66476007)(478600001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?OGV3eUFQNWlkOE9LTzA0U2RreWN6ZDRKa2FLZWMyeVNuSnpzME1vRVZiLzJW?= =?utf-8?B?SUdKN3kweWUrWWdrVUV5eFZQTnlib2dxNG9hSmlDeW5tdnVXb3lUbExNMkdr?= =?utf-8?B?ZHd4blhTZ1o0TDhNN0VaZ21ZWnB1SURqMVB5SkJzeGpvZmlKcWdjaGdTdzVG?= =?utf-8?B?czJ4OExLN2ZkbHJsa3NFS1d3Y29ObDlPY3NnbXNNZEJzOWlSdU05T09FdUtH?= =?utf-8?B?VmVmLzVXejJmTnJ6RElGRlNrSys1T3pEOGdqSXY0WmEzRmZ1QnUxUkFLSFJT?= =?utf-8?B?REsyb2R4aDRydDI1UVpmRUFOVURCUmd2a292NmlMaE51QTc1RHpXcllpWXBY?= =?utf-8?B?TzFVQkk3enV3emRZUTMzWlBveDAzaktTQmxqV3IxZmxvNXFPd2xRek12MVhr?= =?utf-8?B?cERKSXp4WUxLUXNUQUxUY25QMG8ycG0yNnlBVnQ0WG8xWk5HRkpjMFZCdjZu?= =?utf-8?B?b2NHalhvTnFiUnE5Ykk5UE80c3FwVDIzSkVla3BYM0ZsbE1SdVhDZUh0SmZ5?= =?utf-8?B?SjBwaWpHWW41blJsVnNFdWNIR0dlc0puRThsMzdHNWZ0WUFIUENkOWU2VCtw?= =?utf-8?B?Rjh1M2dKdUpLUjlEWXJDaUNsMnppczRUaDBlNklra3Nyc3dXZFN2VThLT3d3?= =?utf-8?B?QXVkWHdHa1VkQ3lYRWlOSVNLbkRkbFFrZjdFUDVYVXBOMkl3anJENy9SU242?= =?utf-8?B?S3pJc1VIRUs4YStQNDhyTFk3SGc2RGZQZERVT1VKbUt2QkFpbFdadkhMdFlG?= =?utf-8?B?aThwNlEzVGh5RVBHY0paWklPTFAwUzVYaHo3OWtDV0w5OThmempuTXo2Z0d3?= =?utf-8?B?U1F5amN5Y1FPc3ZHQlhKVFpQbzlQaE1raStSRXR3MDgzS3g0Nk0rUnBPNjhB?= =?utf-8?B?WGQxWEZQamFDL0pNSFBWTGh2T1ZxUEdXUlRWU0ttNEQ0OEtHbkZOQjNDRklQ?= =?utf-8?B?T01UT2p2cGNQVW9iUTN5WVF6ZGVXTVhYR2tEMHh4U3dYTXVUTVhiak1EemQ4?= =?utf-8?B?akpJWmxGSnNTeWlTdEhlTmIwMGNDdTFqdHd2d2hkaUQrV0IydGhTRWpLN1Z3?= =?utf-8?B?MFdITlF4RHhjVG45WTVmNGFCMW5maFNvTDdmYllkNStJSldmTTZ1Wnd5b2dH?= =?utf-8?B?TmFpREpFU2NaWmV6ek1Wa0g3a1NaeFBxYWo3RU9wUjZTRVhkd0c1cUdWSDNH?= =?utf-8?B?SjFCdGd0QytqazN1QXluMzkvZGYvTDhlMlhkVnZsb1ZONmtabzU5MVVNYVJJ?= =?utf-8?B?Vkxjd1ZxTnNDRnVGRWJNei9SSW5aNVloNE5mQ3dWUFdxa0VpNTZNbGZhOG4x?= =?utf-8?B?UFoybng5bytrSDM0RGlmUDlKOHVGUDBmZEx3VWtnOCtJcHFZTEF5RUhOYkZL?= =?utf-8?B?ZC9Sb1BvM0RZaFBIa0RQU2U1dGVoa3VNOTBMcXFURlpjaysxUjJHelRTOEQr?= =?utf-8?B?YkFOeVZTeXloSXdGTkhFL1FUQVJQclBLb09hL0FodkxHVTkwOHFyZklGaUVl?= =?utf-8?B?UXoyQzMzMENoY0k4L3lVSnNESGloaUZ2R3RzM1lVa3ByRW5lYlkyT0l0bzBv?= =?utf-8?B?TjZxb3NVWlVYSVZMNnJnZG03dkhtVEVua2dTYzB0aHdHRW03azRtVXgrRW00?= =?utf-8?B?RmNMVm9NY05ISTIzMHd3M2dMMXQ0UDlxcjU0dnl1UWZwcXpQUUR3aGZuUGxr?= =?utf-8?B?SzZsdjFIYmEzSURuZUM1c29TQXBFNGR4T29WMjlFUFBiQVNIb1dHd3JUT2FS?= =?utf-8?Q?mgQDUXMBDLCXAKNT9atz/W+kbgZET3NDiJQ6iI8?= X-MS-Exchange-CrossTenant-Network-Message-Id: a3ac1124-8b66-4937-ee87-08d8e921f88a X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 08:52:18.8252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uq2lZJOfBFI5296gcrLfBF31rw2UrMc6oZ3HDlaMa6BeRv6xF9y71xgNXLAkrqb+BtK/BgFnLrZ0Kq6dqJ9brA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3291 X-OriginatorOrg: citrix.com On Tue, Mar 16, 2021 at 04:18:43PM +0000, Andrew Cooper wrote: > staging was not impacted by XSA-351 at the time of release, due to c/s > 322ec7c89f and 84e848fd7a which disallows read access by default. > > Forward port the XSA-351 changes to make the code structure consistent between > 4.14 and 4.15. > > This removes logspew for guests probing for the RAPL interface. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > CC: Boris Ostrovsky > CC: Ian Jackson > > Technically this breaks Solaris/turbostat insofar as you can no longer use > msr_relaxed to "fix" the guest. The subsequent patch will unbreak it > differently. > > For 4.15. Restoring behaviour closer to 4.14, and prereq for a bugfix needing > backporting. > --- > xen/arch/x86/msr.c | 19 +++++++++++++++++++ > xen/include/asm-x86/msr-index.h | 39 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 58 insertions(+) > > diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c > index c3a988bd11..5927b6811b 100644 > --- a/xen/arch/x86/msr.c > +++ b/xen/arch/x86/msr.c > @@ -188,6 +188,13 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) > case MSR_TSX_CTRL: > case MSR_MCU_OPT_CTRL: > case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): > + case MSR_RAPL_POWER_UNIT: > + case MSR_PKG_POWER_LIMIT ... MSR_PKG_POWER_INFO: > + case MSR_DRAM_POWER_LIMIT ... MSR_DRAM_POWER_INFO: > + case MSR_PP0_POWER_LIMIT ... MSR_PP0_POLICY: > + case MSR_PP1_POWER_LIMIT ... MSR_PP1_POLICY: > + case MSR_PLATFORM_ENERGY_COUNTER: > + case MSR_PLATFORM_POWER_LIMIT: > case MSR_U_CET: > case MSR_S_CET: > case MSR_PL0_SSP ... MSR_INTERRUPT_SSP_TABLE: > @@ -195,6 +202,8 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) > case MSR_AMD64_LWP_CBADDR: > case MSR_PPIN_CTL: > case MSR_PPIN: > + case MSR_F15H_CU_POWER ... MSR_F15H_CU_MAX_POWER: > + case MSR_AMD_RAPL_POWER_UNIT ... MSR_AMD_PKG_ENERGY_STATUS: > case MSR_AMD_PPIN_CTL: > case MSR_AMD_PPIN: > goto gp_fault; > @@ -412,6 +421,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) > case MSR_INTEL_CORE_THREAD_COUNT: > case MSR_INTEL_PLATFORM_INFO: > case MSR_ARCH_CAPABILITIES: > + case MSR_IA32_PERF_STATUS: Should the MSR_IA32_PERF_STATUS addition maybe be part of the previous commit, as it's not related to the XSA-351 content? The rest LGTM: Reviewed-by: Roger Pau Monné I wonder whether we could squash this with 3/3 for staging commit, and then only backport 3/3 for older branches. But it's likely too much work just to prevent breaking msr_relaxed for Solaris for a single commit time span. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 09:27:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 09:27:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98599.187104 (Exim 4.92) (envelope-from ) id 1lMSS6-0007s5-JR; Wed, 17 Mar 2021 09:26:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98599.187104; Wed, 17 Mar 2021 09:26:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMSS6-0007ry-FZ; Wed, 17 Mar 2021 09:26:54 +0000 Received: by outflank-mailman (input) for mailman id 98599; Wed, 17 Mar 2021 09:26:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMSS5-0007rt-Mb for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 09:26:53 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 516989ac-021a-4eaf-8c96-6aea65d1b6dc; Wed, 17 Mar 2021 09:26:52 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9F2B5AB8C; Wed, 17 Mar 2021 09:26:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 516989ac-021a-4eaf-8c96-6aea65d1b6dc X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615973211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SXmDT6Of9ce644ypGmVsd0TWrzwGbJJ4Xnkb4B9HVoQ=; b=mAVjqkt6Kti/Nf1yMXoVBmTEHUKI+AlJsIfEeT6bnqg6bLj3K8eo00Jhm1plSM7uRlRiVa R/i+idQi8AYxq0z70OtYO3i3lNi2AhfOaQdpdDeISqwGNtqZe7ucZxF8J76BDgAvP7eDOn LooUqksUMyRA43gWWPQp+XfUbHRwgWk= Subject: Re: [PATCH 3/3] x86/msr: Fix Solaris and turbostat following XSA-351 To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Boris Ostrovsky , Ian Jackson , Xen-devel References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-4-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 17 Mar 2021 10:26:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210316161844.1658-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 16.03.2021 17:18, Andrew Cooper wrote: > @@ -284,6 +283,18 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) > goto gp_fault; > break; > > + case MSR_RAPL_POWER_UNIT: > + /* > + * This MSR is non-architectural. However, some versions of Solaris > + * blindly reads it without a #GP guard, and some versions of > + * turbostat crash after expecting a read of /proc/cpu/0/msr not to > + * fail. Read as zero on Intel hardware. > + */ > + if ( !(cp->x86_vendor & X86_VENDOR_INTEL) ) > + goto gp_fault; > + *val = 0; > + break; > + > /* > * These MSRs are not enumerated in CPUID. They have been around > * since the Pentium 4, and implemented by other vendors. > I find all of this confusing, at best: I'd expect any entity reading this MSR to - when successful - go on and read further MSRs. I have a hard time seeing why those subsequent reads would be any less prone to being unguarded. In fact I went and looked at the turbostat sources. From its introduction the read of this MSR was done with - afaict - appropriate error handling. There are anomalies (do_rapl getting set prior to the probing of this MSR), but they look to not matter stability-wise as the respective MSR reads are similarly guarded. Were the observed crashes perhaps just in some private versions of the tool? If so, I guess saying so in the comment (or description) would be appropriate, but this still wouldn't invalidate the general aspect of my remark. On the good side the value of zero isn't entirely invalid, at least as far as defined bitfields of the MSR go. While looking around I also came across MSR_PLATFORM_ENERGY_COUNTER. This one has specific precautions in the SDM: "This MSR is valid only if both platform vendor hardware implementation and BIOS enablement support it. This MSR will read 0 if not valid." Isn't this a fairly strong suggestion that instead of raising #GP for it, we'd better return zero as well? Because of the remark, unlike for certain other MSRs, consumers have to expect zero possibly coming back. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 17 11:05:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 11:05:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98626.187129 (Exim 4.92) (envelope-from ) id 1lMTzZ-0008S9-4g; Wed, 17 Mar 2021 11:05:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98626.187129; Wed, 17 Mar 2021 11:05:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMTzZ-0008S2-1b; Wed, 17 Mar 2021 11:05:33 +0000 Received: by outflank-mailman (input) for mailman id 98626; Wed, 17 Mar 2021 11:05:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMTzW-0008Rx-MR for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 11:05:30 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a161885d-e66b-4252-8d7d-b1cff585775a; Wed, 17 Mar 2021 11:05:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a161885d-e66b-4252-8d7d-b1cff585775a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615979129; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=Dj3WEWtfLuyd0K8fjqjOFWZBygM37snkgOFZ1PuAd7s=; b=GGVGEuN815hiHpM/o1KQWY/fR+veuDiwnvjoLEFi5I1RLjvqRIUVnrjh k1ni9XkxriiUKGLwVM9O/h+PmnCJP7VLBl2159R22XWeQrn25rit2oszA 71jSFpYjp6giT/nlwLEKnf9KAEnWgoGHA9CONi2I61axgFqQhRapHJDSm c=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: cEkfH64iLi94QlrgEQDnTmEqp9mnN89fAMmSKpnsRwZU5VZawiSRO5OqCPXNET415hgrIfacO6 DN8h9ScFg/MOZOOrU9u+GgnE76l1zy+LB5jZ2ZQKSYRaHXVW/M246xb7HQnxLmlgSTfXofTKIF 33x3mQpwH08+KR/QoDJvjhf/C/xcCdRe4OdRFQQYKHy2KnSpRJDorNIu5EVWm6+obqqwKmgvXN SGQeNtBGNHCVDCqORiSy/s6SjsIbLO1U3NYwgOCDJOfUztst9onCro+6SXxL88Tge5Y4umhnvG mc0= X-SBRS: 5.2 X-MesageID: 39488637 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:v7NBpalG7l9Tth1wK7wlojCMgvfpDfNMjWdD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLNxAZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 ldWoBEIpnLAVB+5PyU3CCRGdwt2cTC1aiui/vXwXsFd3AaV4hLxW5Ce2GmO2dxQxRLAod8MZ Ka6NZOqTbIQwVmUu2QAH4ZU+/f4+DajZ6OW29HOzcLyimryQmp5rnzDgSC0n4lMw9n7L8+/Q H+4nHEz4q5tfXT8G6460by641Rg8bozdFObfb88fQ9CjKpsQqwYZQkZrvqhkFKnMiKyHIH1O bBuA0hOcMb0QKTQkiQrQH20wftlBYCgkWStWOwunforcznSD9SMaMo7+80A3ipiXYIh91y3L lG2GiUrfNsfGz9tR/w+sTSUFVSnle0yEBIrccok3ddXYECAYUhy7A3wUJPHJ8MWAL85Yw3ed MedP302fdMfVuWK03ep2lkqebcJ0gbIxHueDlnhuWllxRmtlVQ7281/4g6szMr0rUTa7cs3Z WZDo1Y0JV1CuMGZ6N0A+kMBeGtDHbWfB7KOGWOZXz6CaAuIRv22tzKyYRwwNvvVI0DzZM0lp iEekhfr3QOd0XnDtDL9IFX8yrKXH62UV3Wu4Rjzqk8noe5aKvgMCWFRlxrudCnue8jDsrSXO v2H55KHfn5Ly/LFZxS1wPzH7leQENuFPE9i5IeYRajs8jLIorluqjwa/DIPofgFj4iRyfxGX 0GUD/vJNhR70yiV3Pi6SKhHU/FSwjax9ZdAaLa9+8cxMwmLYtXqDUYjly/+4WKJFR5w/ULVX o7BImivrKwpGGw82qNxX5uIABhAkFc56ilV3tLoAQNIl7laLprgaTGRUlimF+8YjNvRcLfFw BS435t/7isEpCWzSc+T9S9MmybiHMXrGmQT4gVn7CC4cuNQOJ+Mr8WHIhKUSnbHR18nghn7E 1ZbhUfe0PZHjTyzbm+gIcMH+HZfdlkiAKtKcpZwEiv7nm0lIUKfD82TjSuWcmYjUISXDJSnE R26LJaqqGHgyyTJWw2h/kYPFVAZH+MOq9PCB2Iaexv6+rWUTA1aV3PpDSBzzkvZ2Lh9iwp9x /cBBzRXcuOP31wlTRz1L3w/FZ9a2OHFngAGExSgMlaDmTJunF6zOmRQLG8ulHhN2cq86UlKz HCejsOMmpVtqqK/S/QkjOFCXhj3JklIvfcEaRLScCF5lqdbIeMk70KW+VZ9op/NM3/9sIKX+ 6EZmauXWfFItJs0QmSuntgIiV/tGIljOOt/BXk6WCi1n8+HpPpUQVbboBeKdSb82WhXfqDzI 54kMJwmeOxN23rYN+H1rzGdjIrEGKCnUeGC+ssr4xY+bg/vqdpH4TKFQTJz21cxh83K67P5R AjaZU+6rXGJoIqZcAZZzlY40psntKJK0cgr2XNc7oDVGBohXrcI97M+bbDtaEuH13EqQvrM1 yW8ylQ5J7+Lnm+/I9fAac3PWkTckQ39G9j4fPHbIHbCByre+ZflWDKbEOVQftWTa6YFPELoh xn+NGUj6uMey301Bu4h0olHotH73unTcSuAAiFBO5P9JigNU6Rh7axifTD+QvfWH+1bV8Vip ZCclFVZsNfiiM6hIlyySSqTLfry3hV3Gd28HVillT33JKh73qeFUZaMRfBipE+Z0gfDlGYyc DE+/OfznLz/XxM3oTCDl5ZepVLF8ILRob6aydoJs54hs/lw4M/xiBCagwpFWgylXT02P5nx6 6w3LHKQPL5YE2YcW4p6HpAHMp5jyYroWZPf4y36o+8eBweEqoND+Ek7o5bnTp1ojHInhMhRg QoshZt2pDGL1ThMXg5D6TokIfsiBUTpaSJ6TRV1T9ts0LijEvZt0n+ns6ztXZxsnbUqRV/r7 6BADQ2myRUu2dcsO1cG2vIVXSpR3yLMFn6lvR1fXJkDH0i0OUtgl7IKbIRmpW30mpjqnA6D0 ELsseWP3eaTS/XE9v6aC2uHpCyBtV5Zv5KIGoNL3KsLn3/698NZwONfM0kzwmmn3cFGLOHNa ynah+MFZVlxt1mB4X8B4qFwdrU3gdX93sOv5v2hHyMkvVt996aLGdHwJsAWrksPByr8id+2s aSWgyKP5F/2lCgk1Dc X-IronPort-AV: E=Sophos;i="5.81,256,1610427600"; d="scan'208";a="39488637" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VG12hFFH2uopaIwkpXWtTX6wSn7bqfVG//lZy9sbnqJixv9bgqu/KBd3HNxyoX2HDbhU6s+xUf1/3gPXJrCG58qL8sHIkPLBoEAlIAv/4tq1Tq7PJmplS4yIFXp6oedh2UU7uDShel7Oh/cXGWt4YLuU7SApFpdIbu66VlTu7QM6DXakTSg4TR6p3Mu69qxb8RsC5kCYSgPnLzNeOQC1jWt0qntDiaeEV/evIBPILU55AbqowpBL94Gt02vKuy4L+qiJ0ORTjn6KD/EXyxkDBsSGJhsLmerd2iB2xLtckshKrPoKE4tUJ14VfkS3Tig9yIK5uO71AJkCCVX79TSqwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xAYosD/NdQQbVF91epopKWbQaq49dZ/bZFcLDV5M054=; b=FNm2Jg0Z7l/OUZGjh7MenDsXP14VJWkY4b46oPVTLV4D8wkGmiOoSh2qekelqQ/wNp7gfuqRC+GYmRUboCWM92eO87MgjliJz1uPLz3cRAj1ZAMcurVnCIc9wF/tkzz1MdBEm9c3oC6Zu2XDHc9Srrya+yt/Vp62wvSqknwzKQqzrEYmX+AE+UmvSu7knizyV8jqtpT2TGqc9jriYs+iF+Ua98AJ0ciZdAS2u0yt9If+w9ZeloTjoI/yTo2RDhGIFQvoSf5T5Q/Mmo2vtskHvvHUa8H2zruDNbtwk8bBx4X2ReWvFgNl1MOrhxvI3rn0aSm4Oj7Ay2e6z105w1/lpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xAYosD/NdQQbVF91epopKWbQaq49dZ/bZFcLDV5M054=; b=Fh+bn77WJl22UpYmiH2mJB6lW2t5F88T7XbaMNZxB9YronCBB6NdYWZec3/TXcnuuEzIjE4Cc5v/VBGUjbu0dgmewbqWP7fIsKFr9e5njoYudh63/ayhMmC9vIig4OpeLXd4PF86YrZtNyY0kb5qHSPbVP9GgVH7yG5toWwbTuE= From: Roger Pau Monne To: CC: Roger Pau Monne , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Jan Beulich , Subject: [PATCH 0/2] xen/x86: alternative fix for XSA-369 Date: Wed, 17 Mar 2021 12:03:59 +0100 Message-ID: <20210317110401.46322-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0168.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::31) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e3ca4c43-bfca-4fae-3c44-08d8e9349111 X-MS-TrafficTypeDiagnostic: DM6PR03MB4137: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SUAEzJh1WvLYv5aq90gF9un93IdwAJLBC4XhB0tpLshASB1aeHnT66WGxZK5gSLtfnWG/azgR5RgU/rcT6y83rA5yXUmyfFeLAvZf+VYRA0JlLR+h4M8rWmlEJQ+dtT4+gsRFw52HIs/B7WCVafQNmRCY+FsRG0Pew/cY2i6VsMQqAbxN+alSV1o/U0oGWCH680S8E58AZKLPeRc1JRpm4ImmTctU3dzf/qEKNQZLvObbRg6Izp7Zmph8quP56W2rn05v5R1a+qXo2dIXJseM6T75o44Pc4RNZ1t3jGqFnH5QeYquD2iPKt6pc8DKGyqz4HyX3fpTtxEDCJ/qishHYX9FAvKSuBf3qGuul1stJRv+CZYxpJpWFSS5eLrkz9v5IzX2JQ6naoUyVU+WdgwbSmiV04Qe0xuk+ToT1+5rqHFh0ZibDHqdNCqmBSGCa/CcvDCdFZraL/n8zq3VVUWYJqtQVgwyNNfUIaoQpQMZf+lAFrDZVHtSwKDeKxoxxGzWVGZC8edpKiQJ2fUMStOsETW0XVeELgpa2eHxsRAJDq5nXqlOPf0DLXQg3mGvnPy X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(136003)(396003)(376002)(366004)(36756003)(4326008)(2616005)(956004)(83380400001)(8676002)(8936002)(86362001)(5660300002)(66946007)(6486002)(66476007)(6496006)(478600001)(26005)(16526019)(186003)(66556008)(1076003)(6916009)(2906002)(6666004)(54906003)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?N2RYQSt6bFJjcUVncmlsdVJtRDBrTitXTzEvRWJzeGF2NlEzL2J0OS9OT0tu?= =?utf-8?B?cEZXblYxSDRJZ1ZjT0s4WkhUOEx0NkhTSWpnZnM0OTdISmFWVUNia3piQ0h2?= =?utf-8?B?TjRSUVBia1pKbkVOMHFMYW11RTZhRks3K2h5ZUJaVEpEUWNJSkJsanFqRkZM?= =?utf-8?B?Q3JXTXhvY29tTEM5MW9UWk4vU1RwVjNnY09tOGlmdmVSYklaZmpxZkp3QldJ?= =?utf-8?B?YS8rNDJzS3pjYytyRlRuM2U4T0d1M3hySkQvSnNLbWtUNi93MzdzK0hGNnZl?= =?utf-8?B?L3luSnBDaFBSM2VwUkFEZ0Y2VHV4YVlpR3JXMUlIeTA3cG52Zndod2lRNStV?= =?utf-8?B?NUttbkdPbjhGOGhGVy9rbnM1dU5Jb1AvU0N5Zld2RDlDMkJzMjN0SWoxRk0r?= =?utf-8?B?T3hBY3MrcnY3TVMzcnE2OWxpRG1mSEtudVdCN1pMaWJvQkpseEJzSXp0WW1q?= =?utf-8?B?WDUwNFpIQXdnZktxTUpWUHk4SEpINEQ0SXJLZmRWNUZHUjJuNDRnT2NVWnJX?= =?utf-8?B?Vk5acWxLMldZUWluWk1WK2QvYkV6V2ljWjVBTU1hcFpOajVsUmRGNDZ3UktU?= =?utf-8?B?M0ZkcnF6OVg0K3hSNFY3ODN2aXl1ZVJtWHVWTERWTHNmK3cwWXZHV3RiSjBO?= =?utf-8?B?LytTUHNPVVByeTVValNqaWk0aEdRNU9sWmlMUDgvUkdqbVNnM3pMTnphQ0Ni?= =?utf-8?B?NjFES1Z3UHk5R2Y1eU1vSjhrYnZVQ2svTHdJZktzamFURGsxaXcyY3pXRXFL?= =?utf-8?B?NjVhWXorSXdNVDBpWnRSdFlnSWw0RDBkSExLVlpkL1ltSktydzBGb1JKR3N2?= =?utf-8?B?amJieUZNKzJ4K3M4ZEdIVHFjUElEMnY1dU5jNnRMdUhhVS9QUEt2cUl1b1NY?= =?utf-8?B?bTZUREhqOHUwQUpoMzFQNHV0ckptQUJhMEg3WGZvSjZ1MHBEc29KUjZUV1JT?= =?utf-8?B?V1poQlhrUVVvSTJsVnN0bWdSeERnY2l0RUFzQ1NrbHNSdENQVGdVU3RNVVNU?= =?utf-8?B?d016Ump5d2Z2VVZFbHhGZUhGK0NPODc2LzVra0Judkc5QUtZNnJuZVdQbzdz?= =?utf-8?B?NUFqNWdxQTdVejl5MmZFWHpxWnFiMWJOS0NDa2VRTk9YVGFlcmxscVBlNEhK?= =?utf-8?B?QVZpOGlEc2pMek42ZVE3Q3VJRHQ5RWFZZ3h3R095RTZxbEZSekZBREVlcDRu?= =?utf-8?B?LzVyVkV4bHJkc1pKUkhMYXlKYm9pYTZGcTRLQ25xWmVmZHZ4MWpBeG0vZ1Fw?= =?utf-8?B?TjVnbGpnM1dabWNvUmNwSWpDaU41NUNiaGxuUldzZTRkQVFlcFp1RnJTMUpM?= =?utf-8?B?TkQ0cWI3TzRWNW5qd3ExRTF0djNZMlk1clFraVNidmhTN2gwUks0UGxNQ3Zm?= =?utf-8?B?YmxiamxNZXhEdjRGa0NUT2FpWE11ejhpMFpsWUVnS1NXSUdKS2NlSExxVGlv?= =?utf-8?B?WkNzTXdHUlMvV3NDRGdrS2pHZDJNYVRETXRkZ1Z2VTF4ZnFMSDZWVVdEME5R?= =?utf-8?B?SzNrZk00UVFwNHpUQWxiWWptdjFVWW5FZytrRzhSZXUvdFNQaHJPQTl3QnE1?= =?utf-8?B?NlpEUmo1WDZXWEU1UUsrZ2oyYmltTWdCZDQ5dndWaDVTSzUrdFlFUFVId0tD?= =?utf-8?B?b0ZSL2ptUCt5Y1J3N0NBZ09wQVJyMHRJWU5YRDJRdnprbUs1SldHRUhMQS9E?= =?utf-8?B?TUoweGJRZEcxTlV0ZkZ6dUdxNjVwdDZobTZLQzBHczRkb1VMdE9id013WFNH?= =?utf-8?Q?QDmDwVM1I5ZYUl/eacjm4FGiVUr8ERZCz4w4lg/?= X-MS-Exchange-CrossTenant-Network-Message-Id: e3ca4c43-bfca-4fae-3c44-08d8e9349111 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 11:05:25.6492 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Nc3av+x7AojimneYJ2kgThdWBB14nBDW1n5zUCShw20IylZx1Bc+W5vwwUtHeHkcIXWEKFuJLLYqFlkcCCr4fA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4137 X-OriginatorOrg: citrix.com Hello, This is a proposal for an alternative fix for XSA-369 that instead of special casing XEN_UNPOPULATED_ALLOC to size the p2m relies on making XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on the generic MEMORY_HOTPLUG option rather than XEN_BALLOON_MEMORY_HOTPLUG. I think this is safer, as we don't want to be special casing any option that pulls in generic MEMORY_HOTPLUG without XEN_BALLOON_MEMORY_HOTPLUG. Without this we would also need to at least special case ZONE_DEVICE which also relies on MEMORY_HOTPLUG, and is what pulls the generic MEMORY_HOTPLUG option even when XEN_BALLOON_MEMORY_HOTPLUG is disabled with XEN_UNPOPULATED_ALLOC. Thanks, Roger. Roger Pau Monne (2): xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on MEMORY_HOTPLUG Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" arch/x86/include/asm/xen/page.h | 12 ------------ arch/x86/xen/p2m.c | 7 ++----- arch/x86/xen/setup.c | 25 ++++++++++++++++++++++--- drivers/xen/Kconfig | 4 ++-- 4 files changed, 26 insertions(+), 22 deletions(-) -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 17 11:05:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 11:05:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98627.187142 (Exim 4.92) (envelope-from ) id 1lMTzc-0008TO-Ix; Wed, 17 Mar 2021 11:05:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98627.187142; Wed, 17 Mar 2021 11:05:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMTzc-0008TH-El; Wed, 17 Mar 2021 11:05:36 +0000 Received: by outflank-mailman (input) for mailman id 98627; Wed, 17 Mar 2021 11:05:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMTzb-0008Rx-IQ for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 11:05:35 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b583e291-a162-4caa-9f71-64d8892872b2; Wed, 17 Mar 2021 11:05:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b583e291-a162-4caa-9f71-64d8892872b2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615979133; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=wp0RccVI1tCqlieLeZR40m+vQPb4oS3BJx8bkuHZwN0=; b=XklvQePTUfA8fzYAEY23VNWeDIFALw/Oo54gWIvwANdKxfwdz/oPZk+U +X9zKEwTiEEyT6u0yCDNMQsyxoxmEXiv/OyImy/vhjJfYuB+58VChaKxn ur/KYc9HaaPrwJTDOcl6GmGH+LEfqzLU1pSyB1no2rqIYp8CASP89bxyd w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: hoRtLp/ly252ADuLwJafpUylXwz4p4ZiwRc5U6scuqSgiki0SkUt7B0C2n88f8x2BDVlM26gDS URlQmWOOswm/gDLbd+UG94itg7FJZifMGkW5L4zLwojf1+rXQlE0yp2wxMg07AWJwTSoqrWRD2 B40Lmfm5j7RBlx5P+tMg17quQ4/tTdsgjnDClMj7dqDJV4j8EjL/oRC0JxiE0Ya1L6jX7zzbI1 G+MngiXMEdO7Y/UW0jlLWv7ND/OjI43EEuJuIRyLpdNDqzmQssmNBD9+2aL2DKQfVu+cW28n3T Cks= X-SBRS: 5.2 X-MesageID: 39488646 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:HKNhB6kcXwf/Yrolt1Uu+ZaU3ArpDfP2imdD5ilNYBxZY6Wkvu izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/NIyKMWOqqvWxSjhXuwIOhZnO7f6hDDOwm7zO5S0q 98b7NzYeebMXFWhdv3iTPWL/8O29+CmZrHuc7771NACT5ncLth6QARMHf4LmRTSBNdDZQ0UL qwj/AmmxOadX4abtu2CxA+NoCum/TxmI/7ehlDPhY76WC15g+A0qLwEBSTw34lIlBy6IolmF KlryXJop+Nntv+4R/a2m/V4f1t6aHc4+oGPuOgoIw4Lj3tjyyheYhuXaaT1QpF3d2H2RIRv/ Tn5zsmIsRv+1PdF1vF3SfF6k3b/xsFr1/k1FOCjnPoraXCNU0HIvsEv611WF/9ySMbzbVB+Z MO5U21nd5rKCmFuyLH693BR3hR5zKJiEtnq8E/pThiS4cEAYUhyrA3zQduP7orOjn104wjGP kGNrCm2N9mNWmXaH3UpQBUsbqRd0V2Gh+HR34LsdCO3w5Xm2hkz1AZyNZ3pAZ4yK4A X-IronPort-AV: E=Sophos;i="5.81,256,1610427600"; d="scan'208";a="39488646" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NJpMJF05/FZw3BFa1guhmg91XypIA7XIg07QNSAWFG34jxaNVL3gezDeji69GhLJUlBizfzItd8pKzx0lPkOzTThBbhrga2lwhPpBnWWvFB8zV4+EIE/apjL9SzSTXDKbpazom+vzsClpOjv3Bs6NbahcNCm/34pK63u66SqBf6PaPZElWmDUF5b1a5PzMmi87CIzDnQITi4ISK9vayBaSeNSkIE+/NFB0UrfK8kbQR09PPqytOovuXWJeEHHnm2J+qM7LoynQI9c/Fat+PNt/Jq8lFYdMmujWz2by3CKRuC5aNgh53nnWsCsn7kybNaU+J5kkghBLGnrwrR/rBgzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sdo8EeuM+xU2F1GMX+fxj8Mg5M4tPEbvnO/5QsPd9n8=; b=DK1LMh3RYXcHu1wjCIupI8WWwcRMxusZNcmYEX0Zw2ATMNzs9pddkEoPtWHj2KvS24SodlEBFVyGjJKsJazHl6XtJkGXsHw8waSWWnnW54cCNzrUIxJMegO446YhkXEqMD8gNkixGALLP3WipiA+eJJL6WKYT/f4HDxJilVZblHJsz75HhZmf99HwbAn2jBn1ugua/r9jReMV7LZH94e/4BeSCJkE6TxcA4WSUX5/DCrDLCciYfPuCL7xthfpmFAvzgdzamdFvnMkSceHmeVWh2f2W5NGxPSV5jfQQAgRoz80ZiIDo4DxG6A6UN5KocEip+mifLbQrXrDD8JGenpFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sdo8EeuM+xU2F1GMX+fxj8Mg5M4tPEbvnO/5QsPd9n8=; b=xljdE8q/Cvv6vda3O5BEPtD3EnC3eh0OomAeMevvBgS2THxJg8iPQTETFpLhpzUpmdT7e0fz/rXfxhGjIavuZvpAmEnONPguO/lN2YEBqoDWoSg/vKH/NItKwdLfrhHe7HEzWL8/kq3vZaKkomWIx3Yi+ftMlmaldrFWJl8kdDE= From: Roger Pau Monne To: CC: Roger Pau Monne , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Jan Beulich , Subject: [PATCH 1/2] xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on MEMORY_HOTPLUG Date: Wed, 17 Mar 2021 12:04:00 +0100 Message-ID: <20210317110401.46322-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210317110401.46322-1-roger.pau@citrix.com> References: <20210317110401.46322-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0161.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::24) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 171b86a0-9674-4c4c-cf25-08d8e9349471 X-MS-TrafficTypeDiagnostic: DM6PR03MB4137: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J+9A5LLVZaOp20IHx3zrh37q0KdRAFLYT1Q6iAJ1KnB+Naxi4udSAuXmKuj6gUxF5qwR/udgkMsbbYeeQdEv8oibcKoXVbLJf4CnIQ4sqX+71k6f+Mv0co53uS6d6D+uPmixqjaB3UjX/H4uYdFWNt9Gsv7Nt0JUC1MrdGj4zS7q2v4R+chi8F8YOPNOmeo282MYB3JwL0I1/Ga9QedWfsBpNHrr0rKbBPfeOsPMXqR0c6BX6ELjN124Csg1QzcjDa/IwLU/E11FsV4TUtP6e5Ajhn8hRdGixQsH6ZYr4UAkTUgmom8ahMSoBlW0kWyUtMK4nObunweZ7DTiqW1lJyKHx0aSvALP0Wrxshv45YskX6LqZhPLoISWoNsB718aPyJtPt8mSYTm7U310uMpNolA6I7B6+wTwOGzk4EAHx46ebZMuVVAwy+zmoAWDgz+Ge2QRqg2WrnYlL41ru7YiClDZYiKK4pOD8PI7qoOidwinIYUtDoxRofRdlSWGIbh6fGrDKp5i5RnnGJsoYQTX5t+R+mog3FAwZvVH3+DtH7pyzJ041EpXVLPHyM/ZN2H X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(136003)(396003)(376002)(366004)(36756003)(4326008)(2616005)(956004)(83380400001)(8676002)(8936002)(86362001)(5660300002)(66946007)(6486002)(66476007)(6496006)(478600001)(26005)(16526019)(186003)(66556008)(1076003)(6916009)(2906002)(6666004)(54906003)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?OWlRWkx4RkluZzVnclVBY0tjZTZDaHFWTEJpRENsNVNzVG1sYnNjMThBUFZm?= =?utf-8?B?d0JhNkUrdS9qWjhqZEduYm1SWWtES2ZRdE94ZHU0a2ZyY08xdnpwNFNwcWRT?= =?utf-8?B?U0xZYmdjTkpUSU9PUGNKRHE1OC80a2hKYkxRU21GKzY4MnNxZzd2blRnNUlT?= =?utf-8?B?T0FtcEFuZFpOSFJVUnplN3hjZ0lZeDI2ZzNuTnJPb1VRSVp2VzBnNXM4aDcr?= =?utf-8?B?ZWZnN1Vzb1BvM3llNkxjTnhTOGNSM2oyT1E3TWZkblVJelVPL0s1WU1zYjNH?= =?utf-8?B?V3ZOelQxbXExUzNSckNqU3pieGRYVHJ5dWNrazl0aDhuQklVYm82bDJEbVgr?= =?utf-8?B?cGs3M0JYSjloZXQxMW1Md1BpT2dhcU1JUHE5NVpxU1Qra3c5QVZrbDd4amp5?= =?utf-8?B?b212RkszZVZEMmZrcFQrRE1SZ01IVVcxMXRvdDJmSGhTRVpuTlZSR3I3UWQ3?= =?utf-8?B?UC95aXRJV3ZwYWR2c05BanNkSGwrUFprU0pkd3didlBPbmR2M2lQSHFwTVh5?= =?utf-8?B?RmF1ZzZOcEI0ZExBOEcwVGdzSCtWdWMvVUZpMnFhWmg0SjY1a3ZXZnk4YTM5?= =?utf-8?B?VStidTA5dFk2UjgxZW1BUlhKREluWmdnUjNHMGx4eUhPOW1uWHAvZVJ4Kzhk?= =?utf-8?B?NC9XLzRDTWNNSW04UlBkWWFua0NQR1Q2dlV4allrNUFMNWlwWmcrbVdhOVZs?= =?utf-8?B?b0d1bVFvcitGSWtQdUljSk0vTGlaTGV4ZkJwUWNlOFJiSnhtUjdXSXIvVm15?= =?utf-8?B?czdnWXRDdjZoRTcwcXpxQ0RQUlZYdHBJaldJM2sxYmVGV0ZKenY4a003S2lR?= =?utf-8?B?a0tXYm1FcHo1NnN5ME9Idzg2MzVvOWFpMkFGY2VxdnVJblZmVHBvbVBYb2s2?= =?utf-8?B?RE11c01hVW1DSnlNOHJuM2J5MzJaOWVDeDZRMWd1eklVbTlKZWxJc0o4S3Ns?= =?utf-8?B?eDlaVjJubG5vL0xoOTMwNzdma0dNbFY4Vnh2OVI0WUZwY2g1TlBKakpOc3R2?= =?utf-8?B?MWVHaTRad0F3RDNYa2NKT1JaZk1Mb1VlQTBxNmk2QW5Obm1VdnJIclFtaW92?= =?utf-8?B?ZTQzTU03R1BaRXB1akIzcnpNZnY3Tkxhc1VxZ0E0S01ITnJsSlhLTGJYeFBo?= =?utf-8?B?NFVqS3k5ZXlpbmVlNUZvaktTTmZ3bDhKTlArVG5OUVhja0dwdUpWU0VmTEZz?= =?utf-8?B?OVdDdkl4SkIvWk9tOFlTenNWaUpKMFBmT20wR1U0V2E3TEIrakVvUjB3cmdx?= =?utf-8?B?a0VOTWN1eklvSUt5d0RpRVllUGxQOEVBRnlQZ0M2N1phK0pPRnVKbTRxdXM5?= =?utf-8?B?UGg5N0t3QTF3SnZ5a0JGQVhoWHRCU1htUFVPYjQwRHEwQnV6aERlWGlNZE9z?= =?utf-8?B?TnhwODA3TWprWnhvODJQS2Fia0ZHVUM3YnpSRXVPVnREbVBWVWJYMVFrWkFp?= =?utf-8?B?VDAyWkJqa2FyakcxaXVxVW9jUlJ4WU9oekF3Vk91cFJDb1AvWmtMdkJLcGRK?= =?utf-8?B?bnhESk4vVlZLd2VXYnZnOHljNGZWZTZQcnZwcUtBRnFIdnJwa2l5NkR0SmxT?= =?utf-8?B?Q3hIdC93YUlacHhsejVxRG9sM0g3bysrSHQ0TlNMVElyYnVOd2xxWG9oQTA4?= =?utf-8?B?SVlzN2Y5Q25LWTRreUJ1d1Z2L2FCNWZhWGM3bDlPS2FWaC9RaWhzN0N6UU1t?= =?utf-8?B?UisxVnAxQTE4ZHZYenRIZmJxR2ZDMUtlYUZmeC9jbVFJV1crMHdPQjZCQUZJ?= =?utf-8?Q?VOSS21qhCKzPVdCe9/hKXRfj7YbpGl6miuccKhd?= X-MS-Exchange-CrossTenant-Network-Message-Id: 171b86a0-9674-4c4c-cf25-08d8e9349471 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 11:05:31.3133 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EbYWaCZfLzd0baby1vWRHqeu+h7e3oJ82QAEm4XoAZG9HVkmnUWEM0i+KJkmeugMzVPJ3uw+IlCtaK5JQy6W5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4137 X-OriginatorOrg: citrix.com The Xen memory hotplug limit should depend on the memory hotplug generic option, rather than the Xen balloon configuration. It's possible to have a kernel with generic memory hotplug enabled, but without Xen balloon enabled, at which point memory hotplug won't work correctly due to the size limitation of the p2m. Rename the option to XEN_MEMORY_HOTPLUG_LIMIT since it's no longer tied to ballooning. Fixes: 9e2369c06c8a18 ("xen: add helpers to allocate unpopulated memory") Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Jan Beulich Cc: xen-devel@lists.xenproject.org --- arch/x86/xen/p2m.c | 4 ++-- drivers/xen/Kconfig | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c index 17d80f751fcb..a33902d05e45 100644 --- a/arch/x86/xen/p2m.c +++ b/arch/x86/xen/p2m.c @@ -98,8 +98,8 @@ EXPORT_SYMBOL_GPL(xen_p2m_size); unsigned long xen_max_p2m_pfn __read_mostly; EXPORT_SYMBOL_GPL(xen_max_p2m_pfn); -#ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG_LIMIT -#define P2M_LIMIT CONFIG_XEN_BALLOON_MEMORY_HOTPLUG_LIMIT +#ifdef CONFIG_XEN_MEMORY_HOTPLUG_LIMIT +#define P2M_LIMIT CONFIG_XEN_MEMORY_HOTPLUG_LIMIT #else #define P2M_LIMIT 0 #endif diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index 41645fe6ad48..ea0efd290c37 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -50,11 +50,11 @@ config XEN_BALLOON_MEMORY_HOTPLUG SUBSYSTEM=="memory", ACTION=="add", RUN+="/bin/sh -c '[ -f /sys$devpath/state ] && echo online > /sys$devpath/state'" -config XEN_BALLOON_MEMORY_HOTPLUG_LIMIT +config XEN_MEMORY_HOTPLUG_LIMIT int "Hotplugged memory limit (in GiB) for a PV guest" default 512 depends on XEN_HAVE_PVMMU - depends on XEN_BALLOON_MEMORY_HOTPLUG + depends on MEMORY_HOTPLUG help Maxmium amount of memory (in GiB) that a PV guest can be expanded to when using memory hotplug. -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 17 11:05:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 11:05:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98628.187154 (Exim 4.92) (envelope-from ) id 1lMTzk-000068-QP; Wed, 17 Mar 2021 11:05:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98628.187154; Wed, 17 Mar 2021 11:05:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMTzk-00005z-N9; Wed, 17 Mar 2021 11:05:44 +0000 Received: by outflank-mailman (input) for mailman id 98628; Wed, 17 Mar 2021 11:05:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMTzj-00005D-0w for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 11:05:43 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 129053de-0480-43bd-888d-03877a60ed45; Wed, 17 Mar 2021 11:05:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 129053de-0480-43bd-888d-03877a60ed45 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615979141; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=JjifyQYBWEZf3votvo8D/SBs1EAoJKrZOarp5mqtzfc=; b=eJhQ9hv0d3kuBjJTMNt/bYj/dylP+5BFk8oHGp31s3i/ubvsB/EyCuYI MqAhu5gvvVL6nuSq/XmOZi2RURMc13wRuY+dN0cvYkmF13zP3kCOeXz46 0AZQpIehXLdlq6lEz5HFyTLQU+Ngtq8WNkgb9Ad0mevx5TbovlPsselvs A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: q3PJ0H+xSkxicawBPLIxgUufCGJmCyQkQI3Q5pG2O/H4XcawlBv9/Ol0ZFj1fxDkGr0BA0ao6J mnaxyS1QbndzfnP30xIun/Jlkd9g+FJ/aVO1HPmKthnB3LWt3FnizXGBS9I8ovFTJNrMCGLB5s 4oM6DAyi18AHztOuTQLWNl6bEn4Fx2wPN7usb0S1JjxZTFyAGuDFe7RTHfE8Hbomz5a+Ukeaka 3zdzWPFlZvsHxIy0jaiLstbO67nbPLhhadFQjZJortff5qeRq9fNZE1GqrT9RYaIthDdhf55RT ieM= X-SBRS: 5.2 X-MesageID: 39376917 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:4qp65K7UEVhalkalSQPXwU+EI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoex3h3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdBHW3tV2kZ 1te60WMrHNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2FXQotLhj0JbTqzOEtwWQVAGN4FD5 Ka/MVKvH6Nfn4QY8S9CBA+Lpf+jvfMk4/rZgNDOg4/5GC1/E+VwZPZMzzd5BcRVDtT3awvmF KlryXV7riu2svLsyP0+HTU6/1t6b7c4/tFQPeBk80Ebgjr4zzYHrhJf52nkHQLrPq06FAs+e O80CsIG8ho8XveciWUjHLWqnHd+Q0j4XPj1lOU6EGLyaeSKUNYeqgx8L5xSRfX51Etu9txys twrh+knqFaEA/am2DF78XIPisa5nacm2YokuIYkhVkIO0jQYJWxLZvmH99IdMrGSL3750fC+ 9+DM3Qz+Y+SyLqU1np+kZo29CiRXI1A1OvRVUDoNWc13xskGl+1FZw/r1Rol4wsLYGD7VU7e XNNapl0JlIU88tdKp4QMMMW9G+BGDhSQ/FWVjib2jPJeUiATbgupT36LI66KWBY5oT1qY/n5 zHTRdxqXMyU1iGM7zM4LR7tjT2BEmtVzXkzc9To7JjvKfnebbtOSqfDHgzjsqbpekFCMGzYY fyBLtmR9vYaUf+E4dA2APzH7NIL2MFbcETstEnH32UpMbmLZDrq/z7fP7fKKGFK0dgZkrPRl 84GBTjLsRJ6U6mHlXihgLKZn/rckvjubJ8eZKqu9Q7+cwoDMlhowIVgVO26oWgMjtZqJE7e0 N4PffCmqO/rm+mwHbQ4wxSS11gJ3cQxI+lf2JBpAcMPU+xW60Eoc+jdWdb22bCARNjUcXMEk p6q05s8ay6a7ycrBpSSu6PAya/tT8+tXiKR5ATlumo/sH+YK41CZ4gRehWDgXEFxt8nC5ws2 ddYAo4RkvSfwmey5mNvdgxPqXyZtN8iACkLYp/snTEr3iRoskpWz8mRTK0aNWWhgwvXjJQoV V0/8Yk8fy9sAfqDVF6rPUzMVVKZmjSJL5dFgyKaL9Zna3RdBhqQX2HgiGbjB8PanPnnn9i9F DJHGmxQ7XmE1BdsndX3uLR/FR4en60UmhwZnp52LcNX1juizJW66umd6Cz22yeZh8+2ekbKi jCeiZXCBhp3cqL2BmcnyuiGX0qyo41BPHUCK0uftjoqyqQAbzNsZtDM+5f/Z5jOtyrj/QCVv iHfRSJaBz/EOEk1mWu1z8YERgxjENht/zm2BfotjflmFE+BOffO1RgSfUwJcqG423tWvaP19 FYgLsOzJyNG1S0TuTD76fdKwNnAFf0h0WdSukzs5Bava4ortJIbtLmeAqN8EsC5Qk0Kcf/qV gXT6t66o3QI4MHRb1nRwtpun4S0OmVJEQlsgbKEvYzUFEkgXjcJc6I6dPz2MwSK3zEgAPxPF WFmhcthMvtbm+m1bQADbg3LnkTQE8g6G569OfqTfycNCyaM8VC9kG9KHmzbft0T7WEA6wZql Jf78uTl+GaMwr+1wa4h0o2Hot+t0KmS9i1GgSCBKph9MG7I02Fhu+S2/GI5Q2HAQeTWgA/no 1KdUsZc8RFhH0DteQMo1aPY52yhFkknVtY6SxgjXj31OGdkT/mIX0= X-IronPort-AV: E=Sophos;i="5.81,256,1610427600"; d="scan'208";a="39376917" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gv+Uo4KTSQTAit3Y/Ara4j2Zln5sX5NvhPHSBe0a3rPi1bAeOusVgIeD5dn8JaZs0f2r6QKj64Y8IgRzg/bJ2IqVVURS6ik2RyMUssyN9G9MkCSZfwneQmWpROIdj41YZZ5bI1dF4Jkd7+GVXOYMk9kLK5w39GfjeQM5Bke3Lc3EplV9eZSvxqKP5yz1lyPhqJoNqEFj2FSwDWokqWJqkBcLg/gsergIpBKdCaWMqSpnHZUv2zgdiEIcy5Q1vF7Oe5Q3kg89OOMX/oLmEGTrEW8Z/lQwswBJUJqU/sWIqVCPnrQxkbJxbYvN7atyHjp+rQzMwCYb47mgbx1ar3gvyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a9NK4I28nJimLBCaFSNjZA+gzCPe3+u58agzQpiG2Co=; b=HNwwlyJMswgsdp+et6bRVWZRPehcc0WPIF2MU3tbdrifhdyBxr782ud0coUsr++6NDehK/eY4JOw4gXHkiig3PESP7+u60/7n47/aXd8wqt5O1gx56l9vl5SGCh9GlPP44Tk4VMn7fmBPlM1G0hvnjduxbhtQke5/Loh1VNT/CTlXvD74s+bnPFdqCuwJxjSrhvPPqgwTKlLUbbG3LPUW867KdWvXAPugY1kV/VsWGEAWd4pNE71p3ce2CmNyHEpG8SnEzRo2Nr3pJg/GukX6fI9W0wNt/gwkps+AIn0cg0jKMCVx/goVhyDKH5wxgS1NFknS5gdKgzxC6NVZhMpLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a9NK4I28nJimLBCaFSNjZA+gzCPe3+u58agzQpiG2Co=; b=JuvPjs1qGxl8+boEJ3ymqFmbXcsiNcsty+sS/sP0tRZMc4dAxo2upNxcxEAQZU7ijAl60JPzqtpYuavV2DuC6w0Dndcchr3mB4rkzs/0wdk0ir1DDhxvOAgFLjNJYeGv3zmYXAG5TPY/HCkHEPUOVPpfCjGmQf8DYjge2cSKIrw= From: Roger Pau Monne To: CC: Roger Pau Monne , Boris Ostrovsky , Juergen Gross , "Stefano Stabellini" , Jan Beulich , Subject: [PATCH 2/2] Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" Date: Wed, 17 Mar 2021 12:04:01 +0100 Message-ID: <20210317110401.46322-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210317110401.46322-1-roger.pau@citrix.com> References: <20210317110401.46322-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0166.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::29) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 53f24b2b-06b5-4f3d-e6cf-08d8e9349889 X-MS-TrafficTypeDiagnostic: DM6PR03MB4137: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:972; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tJaaDoqe0+GXF/dWYvL9HSzoSYdxwiFtPmWSEb/RuugAPzPKEqb/AuqiH7qporA/tAmF2TschW5o1gL9MYMdlXLlgWyuT3ldM5YF5r3A6BKqgQcwiristG0Y+kcJvHuvCZlrumRbsGJe+wvalYgpjHAVWOsd8nOeLki6DyTvAFPsd91j5f8jAbWGaCtQEnmCfu1HiFu38tjZNP8H+k0ShjqH3OkZ4mzlyLhGyMD08wETbdhGqi3c06eaRJtjiS0KxqkIUrWT1+CnxAcW7dWjNG/nSK8P6jQPmb9hyAk+EjO6lPkFZ3pPC46fCslcYgaAzzbkqANX9EPjzab0JoDmgbWN6CUzPTlsXrC3sVNwAu0O8C2nx7IadraGxuzJB5hbQTfF8ueMBcWa/sqAYu8Pz0RhSuG+F8xkeM4bBhCqgFg5ibnZ3iMnwFnGCT5n0TQsMXPDPfd6p86fPwR9O+QmUNMpNVCHDGebb+5G1im7LeywBWuRALtqjkMt19d3m+fRZIN1ENvELIIOgbho1kMoYNzNuHvTvmuI9QvT3/Sk4eeUtcs507GsOv/Pzy4tLhoP X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(136003)(396003)(376002)(366004)(36756003)(4326008)(2616005)(956004)(83380400001)(8676002)(8936002)(86362001)(5660300002)(66946007)(6486002)(66476007)(6496006)(478600001)(26005)(16526019)(186003)(66556008)(1076003)(6916009)(2906002)(6666004)(54906003)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?QnFBYTIvMVB2bHpDbjVlaDk3SDZVODZ0OU1raDhTcGs1ZGVybnkzU3pZdnJy?= =?utf-8?B?TG5yQkExTURBdmlsRkI1TVpJb2QvTjRwa2x4M2NkL0I1aHRJS0J3VTVZazVH?= =?utf-8?B?WlZheUlqR3Q5cEY4UzZBYXF3THVYQnZlSm1xb1FuM0RLMFhJOEx3ZUR4dGFI?= =?utf-8?B?RTREaWVQcVRRemlpM01OTmRUQ3hselFlVitSZTRsWmRxeFo4MjlnbWNJd21x?= =?utf-8?B?QnZTSHByelBwZ3lvck83T0x5WlNiRXFJU2d1ZkV3TlFDMjRneHE2L3MxaGpD?= =?utf-8?B?OGU3VWVSVlJmVDhuR2xjVWprVllXeE5udXJrNmtlalZPbFo5QXNrWmo5ZSsw?= =?utf-8?B?cmdtQXpTeFVXY1RzZFduZ2VWd0t3bjhzY0FxdEI0ZStvdUR0R2dmY0U3UkFQ?= =?utf-8?B?eU9BWG1nWjJhMmpEWEhnc0c0RjY2U3JtODIzblBCWXdXczN3aWk2eE1oa1ZG?= =?utf-8?B?bytPWEZTeTRia3Z3NnhrOUJQZGt6b2FmZ2tTeHpOdG10d0RsbzIxcy9FUTI5?= =?utf-8?B?ZW1vL050bDZSNHpYTzcxODgycVhwZEhFNFZ2Y0VOT0lNb21OZEF2dW5TT0ly?= =?utf-8?B?Z2FVeXBRd21CMEtwdVFsQ2VwRnRYdXNacmM2NkY1Zlh5WGROc0hReUNHQTN1?= =?utf-8?B?Y0xuc01zMGhzdUYyL0YzbWRyTnFRTjZmOFVvVzh0U2dLaTZnMW9XbjdZTUpL?= =?utf-8?B?TUtMaUJJV2J1K3FJN0o0b3pSUzZST1pST0svYjhldzhhTWR0cnEyaHFDUGFi?= =?utf-8?B?MXhuMDdkcGVzTkd2NWpucE5PRGVIN0NzWUgxcEtRUjcvK2tEUDJVTFU2VENZ?= =?utf-8?B?Z0JlU01tWnRDR3dWWmtZaHFZNHZ0NlpLc0ErSmUvSnprY0MzbTlmRHJvdTBF?= =?utf-8?B?S1o3Z2NhbWlLZEorMmNvTm5SQkxJeVcyY21wNEF4Z05ocFliaisra213by81?= =?utf-8?B?M25nT1NYMGcxYXNnSERmSzhLWWI4eHhnZ1p2a1JBVVUxeUJTQU8xS3hoVmNB?= =?utf-8?B?Z3lOeWRvNmY5d2dlRDlQeS9WcU5lMjRuN24xWjIrVVhVVzdBUTVlaFJoSTBH?= =?utf-8?B?U2Q2SG42d0JZQVM3NkJUU0N1QXplZEJkZi9VdFdrZmYvc3ZFTjF2OXdRTkMx?= =?utf-8?B?dklidmpHbjlVaWFtSi9XMGxsdnFNeHdnQUNqYlphT25kNVpPaUpQYnAzOVo5?= =?utf-8?B?MWcwYlArWUpFaTFmTWtua0ZxS0lhM2UxWXN0T0o4MENQa0t0eVFlMjBJbW5u?= =?utf-8?B?MkRudDhLNEhUZ0lDQW1yRUpESm1yNHVjT0lwdkdMUXVoMHVXRmVNZnFDR215?= =?utf-8?B?Y3VqeEZKQy9GRDQwWkxUY1FZR05aLzV3L3krQ2JFYXNrd0ZIZTVJZnVkbVVi?= =?utf-8?B?UE1HQlhXT1hVamF2c1pzV3F3WmJFVFRDTzYyK2VtTnRwQ05oeGlMQmJobVY0?= =?utf-8?B?bzU2eGNVZmd6OTZIVzlSOFNrbFVpNTNlZDF1NFVpMW4zbUxIT2p4ZFNxMTVy?= =?utf-8?B?aC9GMzR4UHhJL1I5NDZSS0F3Zk5TQnpuZ1k1WEJYSzRiK0xrN3YxN3lIdW01?= =?utf-8?B?SmFqMnYxcmNOdGhnSGhyOEJDNVhpQTVHRjJONVBpRFFPenNaOXEwa2VYeERk?= =?utf-8?B?aHV6S2ZZWStxdlpWYStrZVVuZ0twY0Rxb3VPTUQrTE4wWiswcU5uaThjZnRh?= =?utf-8?B?eW5naUczYmd5NklMK0VFWmZGMnNVYmNBQTJPZld4Q0RUWWIzL3I1YzdhZE5n?= =?utf-8?Q?R5gB3gQBaIJvTW+GV6tzakGgipKPD4WoQmPFfRO?= X-MS-Exchange-CrossTenant-Network-Message-Id: 53f24b2b-06b5-4f3d-e6cf-08d8e9349889 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 11:05:38.1791 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 14FtMN1D3ZYvIY54wPQHWG7Pi1hKZ8fqLXK/+0K1WLCYVPXCay0OADwfDl7BdmLj+BWuMFyjzrAl3RTONVZ97Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4137 X-OriginatorOrg: citrix.com This partially reverts commit 882213990d32fd224340a4533f6318dd152be4b2. There's no need to special case XEN_UNPOPULATED_ALLOC anymore in order to correctly size the p2m. The generic memory hotplug option has already been tied together with the Xen hotplug limit, so enabling memory hotplug should already trigger a properly sized p2m on Xen PV. Leave the check added to __set_phys_to_machine. Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Jan Beulich Cc: xen-devel@lists.xenproject.org --- arch/x86/include/asm/xen/page.h | 12 ------------ arch/x86/xen/p2m.c | 3 --- arch/x86/xen/setup.c | 25 ++++++++++++++++++++++--- 3 files changed, 22 insertions(+), 18 deletions(-) diff --git a/arch/x86/include/asm/xen/page.h b/arch/x86/include/asm/xen/page.h index 7068e4bb057d..1a162e559753 100644 --- a/arch/x86/include/asm/xen/page.h +++ b/arch/x86/include/asm/xen/page.h @@ -86,18 +86,6 @@ clear_foreign_p2m_mapping(struct gnttab_unmap_grant_ref *unmap_ops, } #endif -/* - * The maximum amount of extra memory compared to the base size. The - * main scaling factor is the size of struct page. At extreme ratios - * of base:extra, all the base memory can be filled with page - * structures for the extra memory, leaving no space for anything - * else. - * - * 10x seems like a reasonable balance between scaling flexibility and - * leaving a practically usable system. - */ -#define XEN_EXTRA_MEM_RATIO (10) - /* * Helper functions to write or read unsigned long values to/from * memory, when the access may fault. diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c index a33902d05e45..ac06ca32e9ef 100644 --- a/arch/x86/xen/p2m.c +++ b/arch/x86/xen/p2m.c @@ -416,9 +416,6 @@ void __init xen_vmalloc_p2m_tree(void) xen_p2m_last_pfn = xen_max_p2m_pfn; p2m_limit = (phys_addr_t)P2M_LIMIT * 1024 * 1024 * 1024 / PAGE_SIZE; - if (!p2m_limit && IS_ENABLED(CONFIG_XEN_UNPOPULATED_ALLOC)) - p2m_limit = xen_start_info->nr_pages * XEN_EXTRA_MEM_RATIO; - vm.flags = VM_ALLOC; vm.size = ALIGN(sizeof(unsigned long) * max(xen_max_p2m_pfn, p2m_limit), PMD_SIZE * PMDS_PER_MID_PAGE); diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index 1a3b75652fa4..7eab14d56369 100644 --- a/arch/x86/xen/setup.c +++ b/arch/x86/xen/setup.c @@ -59,6 +59,18 @@ static struct { } xen_remap_buf __initdata __aligned(PAGE_SIZE); static unsigned long xen_remap_mfn __initdata = INVALID_P2M_ENTRY; +/* + * The maximum amount of extra memory compared to the base size. The + * main scaling factor is the size of struct page. At extreme ratios + * of base:extra, all the base memory can be filled with page + * structures for the extra memory, leaving no space for anything + * else. + * + * 10x seems like a reasonable balance between scaling flexibility and + * leaving a practically usable system. + */ +#define EXTRA_MEM_RATIO (10) + static bool xen_512gb_limit __initdata = IS_ENABLED(CONFIG_XEN_512GB); static void __init xen_parse_512gb(void) @@ -778,13 +790,20 @@ char * __init xen_memory_setup(void) extra_pages += max_pages - max_pfn; /* - * Clamp the amount of extra memory to a XEN_EXTRA_MEM_RATIO - * factor the base size. + * Clamp the amount of extra memory to a EXTRA_MEM_RATIO + * factor the base size. On non-highmem systems, the base + * size is the full initial memory allocation; on highmem it + * is limited to the max size of lowmem, so that it doesn't + * get completely filled. * * Make sure we have no memory above max_pages, as this area * isn't handled by the p2m management. + * + * In principle there could be a problem in lowmem systems if + * the initial memory is also very large with respect to + * lowmem, but we won't try to deal with that here. */ - extra_pages = min3(XEN_EXTRA_MEM_RATIO * min(max_pfn, PFN_DOWN(MAXMEM)), + extra_pages = min3(EXTRA_MEM_RATIO * min(max_pfn, PFN_DOWN(MAXMEM)), extra_pages, max_pages - max_pfn); i = 0; addr = xen_e820_table.entries[0].addr; -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 17 11:09:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 11:09:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98636.187166 (Exim 4.92) (envelope-from ) id 1lMU3B-0000TM-C1; Wed, 17 Mar 2021 11:09:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98636.187166; Wed, 17 Mar 2021 11:09:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMU3B-0000TF-7H; Wed, 17 Mar 2021 11:09:17 +0000 Received: by outflank-mailman (input) for mailman id 98636; Wed, 17 Mar 2021 11:09:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMU3A-0000T4-0c; Wed, 17 Mar 2021 11:09:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMU39-0004Sj-Nf; Wed, 17 Mar 2021 11:09:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMU39-0007jV-Ee; Wed, 17 Mar 2021 11:09:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMU39-0001sr-EA; Wed, 17 Mar 2021 11:09:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=az/kIoyBa9rwrkEs1Mj6NKX/33OjHjDoC7+KCq6gn1c=; b=vf1lw2ZTAoUvQ05Gr3vByyJshl KRt29fnC/+WH6DpMQtfowG09tQQghRtYg2cmJBGEsfE4c8e5jQUTNChsMjrWb7mTunOCnocHGgAX7 yGQpuiBbLnNs5U8tAhT5P9r0NgpRUCIaSq9rIMOpTz6rni/TF70M3SCpolhi3nngE5Cc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160104: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=5b7f5586d182b0cafb1f8d558992a14763e2953e X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Wed, 17 Mar 2021 11:09:15 +0000 flight 160104 qemu-mainline real [real] flight 160111 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160104/ http://logs.test-lab.xenproject.org/osstest/logs/160111/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 5b7f5586d182b0cafb1f8d558992a14763e2953e baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 209 days Failing since 152659 2020-08-21 14:07:39 Z 207 days 403 attempts Testing same since 160104 2021-03-16 22:09:11 Z 0 days 1 attempts ------------------------------------------------------------ 453 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 130051 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 17 11:18:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 11:18:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98644.187181 (Exim 4.92) (envelope-from ) id 1lMUBo-0001ST-FV; Wed, 17 Mar 2021 11:18:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98644.187181; Wed, 17 Mar 2021 11:18:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUBo-0001SM-Aq; Wed, 17 Mar 2021 11:18:12 +0000 Received: by outflank-mailman (input) for mailman id 98644; Wed, 17 Mar 2021 11:18:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUBm-0001RT-Vr; Wed, 17 Mar 2021 11:18:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUBm-0004bo-O1; Wed, 17 Mar 2021 11:18:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUBm-00087y-Fs; Wed, 17 Mar 2021 11:18:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMUBm-00084k-FO; Wed, 17 Mar 2021 11:18:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=llIOs1agaojugFMmfmiGAFenmLjoNgOSnvi63b0eK3Q=; b=XZMsxi8TZsdNszNAieMs3JSu5T LH5jxgs3Nzl84EA7Khfl/YpueuqNXCT31Z3mFEpb39MxrH5i3rv941dLSpeKMXwz5ITgYRtwTnPlW m1HKlJzjyfSQskwUJpVbAaAAQ5mIDO8UsiiRrWHj+VYWTUbBpxZGj88zXGmWWVFZYne0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 160110: regressions - ALL FAIL X-Osstest-Failures: xen-unstable-coverity:coverity-amd64:coverity-upload:fail:regression X-Osstest-Versions-This: xen=21657ad4f01a634beac570c64c0691e51b9cf366 X-Osstest-Versions-That: xen=1b47cc852fd130ed9ce274a0f1600a4a62949a2c From: osstest service owner Date: Wed, 17 Mar 2021 11:18:10 +0000 flight 160110 xen-unstable-coverity real [real] flight 160112 xen-unstable-coverity real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160110/ http://logs.test-lab.xenproject.org/osstest/logs/160112/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: coverity-amd64 7 coverity-upload fail REGR. vs. 159907 version targeted for testing: xen 21657ad4f01a634beac570c64c0691e51b9cf366 baseline version: xen 1b47cc852fd130ed9ce274a0f1600a4a62949a2c Last test of basis 159907 2021-03-10 09:18:33 Z 7 days Failing since 160076 2021-03-14 09:18:27 Z 3 days 2 attempts Testing same since 160110 2021-03-17 09:20:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Boris Ostrovsky Christian Lindig Dario Faggioli Doug Goldstein Elliott Mitchell Ian Jackson Igor Druzhinin Jan Beulich Julien Grall Roger Pau Monne Roger Pau Monné Wei Liu jobs: coverity-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 389 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 17 11:21:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 11:21:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98648.187196 (Exim 4.92) (envelope-from ) id 1lMUEL-0002Gk-Sq; Wed, 17 Mar 2021 11:20:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98648.187196; Wed, 17 Mar 2021 11:20:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUEL-0002Gd-Po; Wed, 17 Mar 2021 11:20:49 +0000 Received: by outflank-mailman (input) for mailman id 98648; Wed, 17 Mar 2021 11:20:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUEK-0002GY-AR for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 11:20:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUEI-0004fA-Vo; Wed, 17 Mar 2021 11:20:46 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMUEI-0007Z8-OY; Wed, 17 Mar 2021 11:20:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=/JaFqClbbdto82Yup5bj4jOhAqVhsibuW3DYqaAoAOo=; b=uQjBCFaxlZfQOz45MJUNaNi7HN ErZCXOFybVTpHVzcRXZJCpD8r6wooO3LcbLnG4MGAQ9PP4r8TGOqHv0VYxeZPkCh1rlUZNa/c7dTB PbQrZGlmGdLQLbfJgjxcvdSL7fj+gG9CVkWLN4xxTHq5R8v9A+ccrB+cRvwcRSEQkOcE=; Subject: Re: [PATCH for-next v2 0/2] xen/arm: Mitigate straight-line speculation To: Bertrand Marquis Cc: Xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk References: <20210313160611.18665-1-julien@xen.org> <119bdbc0-5400-87eb-e6ad-87b59ec4e07c@xen.org> <4066B6A3-2904-4800-B63A-7EAD1EFC7D16@arm.com> From: Julien Grall Message-ID: Date: Wed, 17 Mar 2021 11:20:45 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <4066B6A3-2904-4800-B63A-7EAD1EFC7D16@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 16/03/2021 17:16, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, > >> On 16 Mar 2021, at 15:27, Julien Grall wrote: >> >> >> >> On 15/03/2021 13:32, Bertrand Marquis wrote: >>> Hi Julien, >> >> Hi Bertrand, >> >>>> On 13 Mar 2021, at 16:06, Julien Grall wrote: >>>> >>>> From: Julien Grall >>>> >>>> Hi all, >>>> >>>> Last year, Arm released a whitepaper about a new category of speculation. >>>> (see [1] and [2]). In short, a processor may be able to speculate past >>>> some of the unconditional control flow instructions (e.g eret, smc, br). >>>> >>>> In some of the cases, the registers will contain values controlled by >>>> the guest. While there is no known gadget afterwards, we still want to >>>> prevent any leakage in the future. >>>> >>>> The mitigation is planned in two parts: >>>> 1) Arm provided patches for both GCC and LLVM to add speculation barrier >>>> and remove problematic code sequence. >>>> 2) Inspection of assembly code and call to higher level (e.g smc in our case). >>>> >>>> I still haven't looked at 1) and how to mitigate properly Arm32 (see >>>> patch #1) and SMC call. So this issue is not fully addressed. >>>> >>>> Note that the ERET instruction was already addressed as part of XSA-312. >>> On my tests, this serie is breaking the arm64 build: >>> | aarch64-poky-linux-ld --sysroot=/home/bermar01/Development/xen-dev/build/profile-fvp-base.prj/tmp/work/fvp_base-poky-linux/xen/4.15+git1-r0/recipe-sysroot -EL --fix-cortex-a53-843419 --fix-cortex-a53-843419 -r -o built_in.o memcpy.o memcmp.o memmove.o memset.o memchr.o clear_page.o bitops.o find_next_bit.o strchr.o strcmp.o strlen.o strncmp.o strnlen.o strrchr.o >> >> I can't see any build failure with the following GCC: >> >> 42sh> aarch64-linux-gnu-gcc >> aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) 7.5.0 >> Copyright (C) 2017 Free Software Foundation, Inc. >> This is free software; see the source for copying conditions. There is NO >> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. >> >> AFAICT, there is also no compilation issue reported by gitlab: >> >> https://gitlab.com/xen-project/patchew/xen/-/pipelines/269989894 >> >> What's the version of your compiler? Do you have steps to reproduce your setup? > > You need to have earlyprintk enabled > I am using gcc 7.5.0: > aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) 7.5.0 > > one configuration triggering the issue is using the default .config with the following items added: > CONFIG_SUPPRESS_DUPLICATE_SYMBOL_WARNINGS=y > CONFIG_DEBUG_LOCK_PROFILE=y > CONFIG_PERF_COUNTERS=y > CONFIG_PERF_ARRAYS=y > CONFIG_DEVICE_TREE_DEBUG=y > CONFIG_DEBUG_TRACE=y > CONFIG_EARLY_PRINTK_JUNO=y > CONFIG_EARLY_UART_PL011=y > CONFIG_EARLY_PRINTK=y > CONFIG_EARLY_UART_BASE_ADDRESS=0x7ff80000 > CONFIG_EARLY_UART_PL011_BAUD_RATE=115200 > CONFIG_EARLY_UART_INIT=y > CONFIG_EARLY_PRINTK_INC="debug-pl011.inc” Thanks for providing the .config. I managed to reproduce it. So I removed "asm_defns.h" everywhere but forgot to include it in the "config.h" :/. This small change fixed the error: diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h index 51273b9db1fc..c7b77912013e 100644 --- a/xen/include/asm-arm/config.h +++ b/xen/include/asm-arm/config.h @@ -192,7 +192,7 @@ extern unsigned long frametable_virt_end; #define watchdog_enable() ((void)0) #if defined(__ASSEMBLY__) && !defined(__LINKER__) -#include +#include #include #endif Would you still be happy to review the series before I send a v3? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 17 11:24:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 11:24:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98652.187208 (Exim 4.92) (envelope-from ) id 1lMUHi-0002Qx-Cp; Wed, 17 Mar 2021 11:24:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98652.187208; Wed, 17 Mar 2021 11:24:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUHi-0002Qq-9m; Wed, 17 Mar 2021 11:24:18 +0000 Received: by outflank-mailman (input) for mailman id 98652; Wed, 17 Mar 2021 11:24:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUHg-0002Qi-PU for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 11:24:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUHf-0004i1-2c; Wed, 17 Mar 2021 11:24:15 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMUHe-0007qq-Rb; Wed, 17 Mar 2021 11:24:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=vnLoC/NN0N+ln/7bTx1mJ+d9P3InPoGIVqHoCZVHg8E=; b=JZmM+eua6+CbLzAoHiZvEMPF8C iagYHNZmXqsrhXTYaJ0LJQdRV2IzoS+Bzv3nKICQVHZxU6Lu9nwwWpI+6Hmfy+N88sKOZFpR0SCKH DTLmxPViv+lmSTykk1gR+GoVrB2s9ny22IMY79Ry/xFtzeA3TO/VGj5VnpbxrKitx9ok=; Subject: Re: [PATCH for-4.15] SUPPORT.MD: Mark C XenStored LiveUpdate as Tech Preview To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Andrew Cooper , xen-devel@lists.xenproject.org Cc: Julien Grall , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu References: <20210313135500.27241-1-julien@xen.org> <43d6d118-308d-6bb0-3b91-7dc0f8a38d56@citrix.com> <663f08cf-a7cb-2e53-fe22-69d232e6aa07@xen.org> <03787b98-9acd-f1a8-66d4-953d7c99ee0d@suse.com> From: Julien Grall Message-ID: Date: Wed, 17 Mar 2021 11:24:12 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Juergen, On 16/03/2021 14:58, Jürgen Groß wrote: > On 16.03.21 15:39, Julien Grall wrote: >> >> >> On 16/03/2021 14:36, Jürgen Groß wrote: >>> On 16.03.21 15:35, Julien Grall wrote: >>>> Hi, >>>> >>>> On 15/03/2021 12:17, Andrew Cooper wrote: >>>>> On 13/03/2021 13:55, Julien Grall wrote: >>>>>> From: Julien Grall >>>>>> >>>>>> Support to liveupdate C XenStored was adding during the 4.15 >>>>>> development cycle. Add a section in SUPPORT.MD to explain what is the >>>>>> support state. >>>>>> >>>>>> For now, it is a tech preview. >>>>>> >>>>>> Signed-off-by: Julien Grall >>>>>> >>>>>> --- >>>>>> >>>>>> CC: Juergen Gross >>>>>> >>>>>> It looks like the OCaml side was not merged in 4.15. >>>>> >>>>> Yes it was. >>>>> >>>>>> So I have only >>>>>> described the support state for C XenStored. >>>>> >>>>> What about stub-cxenstored?  I think it wants pointing out >>>>> specifically, >>>>> whatever its status, to avoid confusion. >>>> >>>> Is it even working? @Juergen? >>> >>> LU of xenstore-stubdom isn't working yet. >> >> Ok. Would renaming the section to "Dom0 C Xen-Stored LiveUpdate" would >> be suitable? > > "Xen-Stored" in rather unusual. > > What about "LiveUpdate of C Xenstore daemon"? I am fine with that. I will respin it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 17 11:27:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 11:27:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98655.187219 (Exim 4.92) (envelope-from ) id 1lMUL8-0002e3-S4; Wed, 17 Mar 2021 11:27:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98655.187219; Wed, 17 Mar 2021 11:27:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUL8-0002dw-P1; Wed, 17 Mar 2021 11:27:50 +0000 Received: by outflank-mailman (input) for mailman id 98655; Wed, 17 Mar 2021 11:27:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUL7-0002dr-Lp for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 11:27:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUL6-0004mB-Sg; Wed, 17 Mar 2021 11:27:48 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMUL6-0007ws-CR; Wed, 17 Mar 2021 11:27:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=XlF8rrW4tjGwtwdIfgdzDd++2n1pZEO7qz4puUQ3oJE=; b=wqJe9dCBvg9ZkBnx/GFlWqvi0G YNfnhT+gAMp4NFgFEVEsQ4SBpFdqQfCY/FQIuwu7fZ/yGESNgRkImDKzt/3eVO9k3/vZANrVopH6/ j8kNkOS3+cmVataabPhFhZZL8uIXyuTxaTgGwRnQ3F7hA7lf62mY5J8GMlEj/n3Bip/k=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Juergen Gross Subject: [PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview Date: Wed, 17 Mar 2021 11:27:45 +0000 Message-Id: <20210317112745.15207-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall Support to liveupdate C XenStored daemon was added during the 4.15 development cycle. Add a section in SUPPORT.MD to explain what is the support state. For now, it is a tech preview. Signed-off-by: Julien Grall --- CC: Juergen Gross Changes in v2: - Clarify this is only supported for the daemon version - Fix typoes --- SUPPORT.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index 7db4568f1a0f..4c93afa3613b 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -177,6 +177,10 @@ Support for running qemu-xen device model in a linux stubdomain. Status: Tech Preview +## Liveupdate of C XenStored daemon + + Status: Tech Preview + ## Toolstack/3rd party ### libvirt driver for xl -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 17 11:32:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 11:32:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98658.187231 (Exim 4.92) (envelope-from ) id 1lMUPO-0003Uq-E7; Wed, 17 Mar 2021 11:32:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98658.187231; Wed, 17 Mar 2021 11:32:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUPO-0003Uj-Ap; Wed, 17 Mar 2021 11:32:14 +0000 Received: by outflank-mailman (input) for mailman id 98658; Wed, 17 Mar 2021 11:32:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUPN-0003Ue-Fz for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 11:32:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUPM-0004rt-SH; Wed, 17 Mar 2021 11:32:12 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMUPM-00086c-IP; Wed, 17 Mar 2021 11:32:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=OOmcNHKjT72WKKW0QAtzb5FxL86wcFMAHxWNXS5v4Fg=; b=Tq53AUQsO9npujsXcYiw6gluzx /QZYsUIc8LT0sNPK4bVipDAdbcTf9IO4m+v4IWSqku8wh5jk6JKdezc2qv5ZdTou8OIs0DHbO/qV7 w2QW7DjsFhiHOaegZGiiCVHObNwvKjXT64DT34+ZwFtnI5kr/Q20crWw+ldYT/BRp+GU=; Subject: Re: [PATCH v3] xen: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped To: Stefano Stabellini , Jan Beulich Cc: andrew.cooper3@citrix.com, Bertrand.Marquis@arm.com, Stefano Stabellini , xen-devel@lists.xenproject.org References: <20210312231632.5666-1-sstabellini@kernel.org> <0e35a613-fd93-0805-10b9-5ecee73bb15d@suse.com> <48a7ea93-06b4-21f1-5db2-0104058a2446@suse.com> From: Julien Grall Message-ID: Date: Wed, 17 Mar 2021 11:32:10 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Stefano, On 17/03/2021 00:04, Stefano Stabellini wrote: > On Tue, 16 Mar 2021, Jan Beulich wrote: >> On 15.03.2021 21:01, Stefano Stabellini wrote: >>> On Mon, 15 Mar 2021, Jan Beulich wrote: >>>> On 13.03.2021 00:16, Stefano Stabellini wrote: >>>>> Introduce two feature flags to tell the domain whether it is >>>>> direct-mapped or not. It allows the guest kernel to make informed >>>>> decisions on things such as swiotlb-xen enablement. >>>>> >>>>> The introduction of both flags (XENFEAT_direct_mapped and >>>>> XENFEAT_not_direct_mapped) allows the guest kernel to avoid any >>>>> guesswork if one of the two is present, or fallback to the current >>>>> checks if neither of them is present. >>>>> >>>>> XENFEAT_direct_mapped is always set for not auto-translated guests. >>>>> >>>>> For auto-translated guests, only Dom0 on ARM is direct-mapped. Also, >>>>> see is_domain_direct_mapped() which refers to auto-translated guests: >>>>> xen/include/asm-arm/domain.h:is_domain_direct_mapped >>>>> xen/include/asm-x86/domain.h:is_domain_direct_mapped >>>>> >>>>> Signed-off-by: Stefano Stabellini >>>>> CC: jbeulich@suse.com >>>>> CC: andrew.cooper3@citrix.com >>>>> CC: julien@xen.org >>>> >>>> Any particular reason my previously given R-b isn't here? >>> >>> I reworded part of the comment in the public header, and I decided to >>> err on the side of caution and not add your R-b given this change >>> compared to the previous version. >> >> I see. FAOD, despite me not being overly happy with the "older >> Xen assumptions" part of the comment, feel free to add it back. > > Thank you! > > Julien, please go ahead and commit it to your for-next/4.16 branch when > it is convenient. I have committed it to my for-next/4.16 branch. I will merge the branch after the tree has re-opened. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 17 11:43:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 11:43:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98661.187244 (Exim 4.92) (envelope-from ) id 1lMUaQ-0004UD-GS; Wed, 17 Mar 2021 11:43:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98661.187244; Wed, 17 Mar 2021 11:43:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUaQ-0004U6-DH; Wed, 17 Mar 2021 11:43:38 +0000 Received: by outflank-mailman (input) for mailman id 98661; Wed, 17 Mar 2021 11:43:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUaP-0004U1-7u for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 11:43:37 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b1320efa-5926-4bdc-826b-6c83a091654a; Wed, 17 Mar 2021 11:43:35 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7E5F7AC23; Wed, 17 Mar 2021 11:43:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1320efa-5926-4bdc-826b-6c83a091654a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615981414; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CuQLi8iZI/3hWTVAUYr5sOP8XgztHXl5oVmxgVMuVTo=; b=H71kIURFq3VU4OTGHPm6l0A4iZ2glwyqEtYDGbFlBWUahMcCdxjH1p/8Wg0KxfK37P63XQ W5t3kOTDCoYe78Gff7E0P2eHHKUMnoopfaVFteWzyOYx3MYDM6/tnUGIStX34RlDUiRRB6 ziny98aGBLTgwqfraIPAY1ykB3mZz1Y= Subject: Re: [PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu References: <20210317112745.15207-1-julien@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <2765192a-76c2-7051-7353-c57ea507eeb8@suse.com> Date: Wed, 17 Mar 2021 12:43:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210317112745.15207-1-julien@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UUYAStVJnwFSGqA7VPkIlO4PIeGHl2hvi" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UUYAStVJnwFSGqA7VPkIlO4PIeGHl2hvi Content-Type: multipart/mixed; boundary="H5V4ujhlwaUoEHyT4500R1HXCtzNtSvlr"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Message-ID: <2765192a-76c2-7051-7353-c57ea507eeb8@suse.com> Subject: Re: [PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview References: <20210317112745.15207-1-julien@xen.org> In-Reply-To: <20210317112745.15207-1-julien@xen.org> --H5V4ujhlwaUoEHyT4500R1HXCtzNtSvlr Content-Type: multipart/mixed; boundary="------------9B2333EE9950156487446FE2" Content-Language: en-US This is a multi-part message in MIME format. --------------9B2333EE9950156487446FE2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 17.03.21 12:27, Julien Grall wrote: > From: Julien Grall >=20 > Support to liveupdate C XenStored daemon was added during the 4.15 > development cycle. Add a section in SUPPORT.MD to explain what is the > support state. >=20 > For now, it is a tech preview. >=20 > Signed-off-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------9B2333EE9950156487446FE2 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------9B2333EE9950156487446FE2-- --H5V4ujhlwaUoEHyT4500R1HXCtzNtSvlr-- --UUYAStVJnwFSGqA7VPkIlO4PIeGHl2hvi Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBR62UFAwAAAAAACgkQsN6d1ii/Ey8M rwf+KdC3jHG3m/7ZmCLwGvWAviYx7BF8WvzfLG3pEyUQfH2abxCRw5RiEKXtuWV6oCzw26UQXsKs 7d/y4v3zqS5oklA2moRlY6NzTSsDUiagwkqdramfJNC1NeByHMwaNQELlE49R9qoYx0qUh7mhyU3 g4Y4k4ET51JPsn0xcrInoI3o75b0ru9GFSzSoCQD7YK8tiYhW+n3722z3DexHsUASx+ujMuSFvYb IdC9Vl/dtL7qs5Ae7+Mr6q4e2wza4M9vS8OjwpbqRMRJ6V56Q+3cuTMCfWcPCyeCHogjLBA6qVWm K1a0YsaVuxKyA3kQabYt3YNkkMc82EjaFeIbUHjOHQ== =DppA -----END PGP SIGNATURE----- --UUYAStVJnwFSGqA7VPkIlO4PIeGHl2hvi-- From xen-devel-bounces@lists.xenproject.org Wed Mar 17 11:49:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 11:49:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98666.187255 (Exim 4.92) (envelope-from ) id 1lMUgC-0004kA-BD; Wed, 17 Mar 2021 11:49:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98666.187255; Wed, 17 Mar 2021 11:49:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUgC-0004k3-8D; Wed, 17 Mar 2021 11:49:36 +0000 Received: by outflank-mailman (input) for mailman id 98666; Wed, 17 Mar 2021 11:49:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUgA-0004jy-Or for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 11:49:34 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8f73085d-8825-4ac8-ae9f-35f12ccca221; Wed, 17 Mar 2021 11:49:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f73085d-8825-4ac8-ae9f-35f12ccca221 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615981773; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=qSQN8ZkzZ/7nBInBg2N/bvEXaj2QZYkYt3PsxnNHIG8=; b=YwVkj5QDqRqZ5MTLpx3u0y8/e3OSqhQNl2Sb+zafYdFsF2YdE3fanR1+ JeDZdJb9SoJlcs7opEdeygiWlKNvu/9sXsaRxhfnL5QDSS6MAnUolaHdU ZLQRdTUhGi43Pi5MAg8RUjAEJfPunjcOQHk0dFJAOr2HE4Y3gtEgMzyTn c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: LGCvD1yZqbJbdHw993E0YPT4ZDHJYA1aC9h8ksVSqzbJ+bPrIVBWuXLhezGB5T9Oq5gmJfdvqC 2XOdNOTxIitMmJ4rWWALikwFXFic0AC6lDYRaeZSpuo3HLKG30OAoJAi8l5M6Ua83xpo0e/SWj a/2zpxsMG/WIdUqPzwuUrSfg4UyS37csvUUYa8iKc1HkkvW8rrSPTmDzppyrZ3dBiousy4gz9O q4m/LaWFdZRmPHfE1VmaqvnreJy7qhnas8O3BtA7aehQ9u7fownUveniIm/wDPcgEQQx/mNb+V pwA= X-SBRS: 5.2 X-MesageID: 39476402 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:h37z5q66bndR+ota0QPXwRqBI+orLtY04lQ7vn1ZYQBJc8Ceis CllOka0xixszoKRHQ8g7m7VZWoa3m0z/5IyKMWOqqvWxSjhXuwIOhZnO/f6hDDOwm7zO5S0q 98b7NzYeebMXFWhdv3iTPWL/8O29+CmZrHuc7771NACT5ncLth6QARMHf/LmRTSBNdDZQ0UL qwj/A3xAaIQngcYsSlCnRtZYGqy+Hjr576fQUAQycu9Qjmt1iVwYTnGBuV1Ap2aUIs/Z4e9w H+8jDR1+GYnNyQjjTd0GLS6Jo+oqqd9vJzQPaip+JQBjHligODbJlsVbuYrFkO0Z2SwWdvqv bgiVMNONly9mPwcwiO0GTQ8jil6hkCwTvDzkKVmnTqq8CRfkNFN+Nxwbh3XzGczmhIhqAa7I t7m1i3mrASMDb72AP63NTMXwECrDvOnVMS1dQ9olYabZETc9Zq3Ooi1XIQKrgsNgTg5rsqFe F/Zfusnsp+QBehY3fVsnIH+q3UYl0DWhOPQk01sseIyTRhnHdg00sCxMAE901wjK4Adw== X-IronPort-AV: E=Sophos;i="5.81,256,1610427600"; d="scan'208";a="39476402" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F5cZ4BGGCh3RNiWqSbR6uwBGY9bQmpY2qLRG60bu0sue1Ipn45iTYs8luoGKLARwKFOmQIT49wic88+By/T8w0bmlDCiZkVsEmPLI83gRXc3ZOEuIRPG5hQCgQAVJgQFb65L9FTkB1YemX9IPNUnki7+H0mzSpqBpVEJ3fQRpUvjNylOJ9WmXXSc91bXVop1aH9vuBh3g8TGI6bhL6N/8qLDsxIKYLythGHJsefLxsOIeI8ChjCyfgG8EPgyGuhNI3OKud7w3p9UA9FsrH3tMNgv0sopIbiVGehRBITp6p8RqpBJLXlrm+CN/5Oxxxp5Sx/wMttFKwDxo8tnwtha7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qSQN8ZkzZ/7nBInBg2N/bvEXaj2QZYkYt3PsxnNHIG8=; b=n0LEuYs4qzbTH1lIvSDx3H+6fgio8OUntL2QDGHQ6objUMhl59Z2L8lBRh1nB+vEIy64+hthl7m3lVdOquq/76Wz4rBVO0PKBGzbbnva+oeLvW2U1qBMpDLDHX7Cy57n7x2sXwLGNF+1IsMAHAUm1CE8Poh/WnA59L5pbXbEZCYW6KAxvXyNVEofPDv6MTmp8JfPERYrH5B1OJ5e0Awz0EMZ7oiUtKfaFceH29U7XxXLfBhfATd+Zt7ovZeu/ElvAdCYHv4v4RwVTRNcooTpPvnMrjewr5T42DKyFsokLyPGvkK0zzPa+HdT6uTItzZru78+FtEXSvnchprELUKPJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qSQN8ZkzZ/7nBInBg2N/bvEXaj2QZYkYt3PsxnNHIG8=; b=X/vj04Nc/WhbRgZY2QXTyC/DTCg4YkfvwO4pd6mNafxbbqvbTJoSMq/Mr1MLTFihr/Cob6Vi2K60SLzCIKbrStZb6RrGkJhNDm3Xdys6hCyrMCgQwoAIKWhL/ohRJrDi+cdEY1lQ5vKp3/zieJupbfw6ELUtwHyhrBJ/4DP7bo4= Subject: Re: [PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview To: Julien Grall , CC: Julien Grall , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Juergen Gross References: <20210317112745.15207-1-julien@xen.org> From: Andrew Cooper Message-ID: Date: Wed, 17 Mar 2021 11:49:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210317112745.15207-1-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0305.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::29) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d2016537-59b6-4890-6a30-08d8e93ab88b X-MS-TrafficTypeDiagnostic: BN6PR03MB2673: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tg78Cl4YiaRcrqpVtFbv8DRoD7eRSI+Gbdaefg7bFwGQ9gn4ohrONwo6IfpeUp7Pjtko114K+3jhyh4Yh7eh/AQ+Pm43Kcb3KV5CQ/pjQlxoUsW97ZuCHyXLEPac3ggVyj4EJbTWlHaB+xw80NU9tSnWrvKcgPbfAucRu8cEeNnPF3Umts5aYsp9ogn9/nuEN1L5dmKhRDsGxn06Qtiz5ljuVrct6ARiTJsjHtuUB2SGIja+HbfIxnHyk1t6tLzpASU7ZYpqyO3Yfpakb+cihv3F2C7pQpCvGFWMLLVcaHzagLxpNZ9zSvrh0nzcStxW8GgQf2IyqTfhLCYVtjal8DyZ7ker7NAM0fv6qJsFFJNz7hhq0VExfxhmliT90RHwVOuNmDeWsBYoGTJhjCcbeWjY4ngRUDLoXFETf7hDCQr8SPDg2AalilbG9mBiMQ+OV36hUs872BaZPzBnfEIMHiVMSShBlSirddMx9SumJ+bSdCeUVjd9muKuTkR/3s7E8ZVEzG7Oy+EhqWLXPqQfwNV0puQH531ikcZ9vQEWVq71YQkKrarSJS9iQOp1AwDztoSIdGmSGukU974VgAnO6TWbGGMS9OYEYZzXW1WZyoWJJac0TELOsx4Ir9ju1ropgD5TxJPuj02F3kQo+dWZVg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(136003)(376002)(39860400002)(346002)(26005)(83380400001)(956004)(5660300002)(4326008)(6486002)(478600001)(16576012)(53546011)(31696002)(31686004)(36756003)(8936002)(6666004)(66946007)(2616005)(66556008)(186003)(2906002)(66476007)(16526019)(316002)(86362001)(8676002)(4744005)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aXR1dTVBRnp0UDI2L3FLTUQ3OGpBS1hMS2o4c1IySXlJU0k3bnBLL2kxVllQ?= =?utf-8?B?Slh3YVd2VTNsNUkzWTA2M01sRE9FaWZwTDJjV3BYUFVNeHdwSkNDZnkvRjlp?= =?utf-8?B?d29QTXg0WjdyTnNCbzdvOEtlOVU0dEdEblU4dHNRdW9kT1cyYXduNEY1eEFp?= =?utf-8?B?cmpPUVpuOFViWmV4QUdyMzhCYkoxdWI4UnBjNmcwVE1LSzdNWHRldVc0emFr?= =?utf-8?B?Njh6cTVJTWx5QjR0bDJQQWI2bml0czkwbTJPeER0Rk5walo3T3VYVmt2cVh3?= =?utf-8?B?aW9OdkNZcjRoT29VeEwyR3RBUXRWdmsvK29uWWtSZExpWkhqZWpzb0JFK2tJ?= =?utf-8?B?cjhzWEJlUTNJS29vcDNlTndrMHRoV1F4djR1bll3bGM0bzVVTU5iam5MQ0NX?= =?utf-8?B?bmdjdnpHSWt0QjVYTUs3anhhQnBPWGlBZlVReDlGdFBNRXpNbFJVazZnNkUr?= =?utf-8?B?M2VJMmtEZXRhemQzQ29ZRmxyTDF2bUpOaGxYUXh3YnZOYm9YRWZHQzFhcWNM?= =?utf-8?B?MXgrVVdBV1JLdUJ1SjNuM0UxVWVOOWR0YXpadGdXWmFneUhxLzAzdEFhb0pJ?= =?utf-8?B?dWhkSXFEU3doL05QclFPYndQYmEvM2V1bXhYZ2loSmRlNk43NHVsQVptQzlI?= =?utf-8?B?NjNVY3k5bWJrSWZKaVoyY01nVVVtTUNURWFCZTkvTWVWRFdRbitvL3YrT1hM?= =?utf-8?B?VVJxREp3RkRERGVET3VNTHlHMzl0YzFFREZLNjI5eXNvZ3RGNVR4WS9KdDdp?= =?utf-8?B?bVhEajlaUml1bmxVc2dQVkthUGk0L1I1Q3crNmVmb3JwRHVZMlgwaGc5eTRQ?= =?utf-8?B?N1JKa1pjNkRYdk83cThtdURPNk15QlZKcVpKaDZLSXIvNUQ0ZmNmWlNuSllm?= =?utf-8?B?K0VUT09XeHU1SmJXR3dKaElpd2xRSmRBUFRUeUNCcyt4WEdMSHkzWGx3Mngx?= =?utf-8?B?cGVEclQrMERYZ0NMbkRCTk1kcXJwUjlsbVRPM0s5Q0pEWGJPZmhxTnNyYndE?= =?utf-8?B?blVYKy9lWDhyUGlJTGdxenE2UkZwUnlPVFVsQ0pycGQyM3hYOFhLdElXb3dz?= =?utf-8?B?b0ZQU1kxWFcxUk03N2ZXSmFvZ1FpK1BtSVBaYm8yZWhxWXZOWGdyR2FITkUw?= =?utf-8?B?RHZmc0JYSE5TdUNXOS9jc3hlamx4ZjBvZjVjVStBc3AvZ3VjMGE4a2QrSU5P?= =?utf-8?B?am1YUWlESkpNdVg4Z0h0cmdsZE9FcGE1WUhTUE80Ly8wWlhFWmdHSXFpRXZk?= =?utf-8?B?UkpvSThkcFZqR3I4MHFxOG1jMUVWc2dNNnRsM2xaczUwdi8yY0taWnoxY2tJ?= =?utf-8?B?ZmFsV1JlbStsb056Q0JNQkdtQ21pSnprR2JNZ0Q0VmNGUHdpT2gvVkpqbkJT?= =?utf-8?B?dVYvanlTQkZvS3RNa0hYZm5PNWpST0hmUFdCVjM2YlZNUnVDQzB5aUowb1Vh?= =?utf-8?B?VENRdGlRL2NXTmFRanVNbjlEWGFtOFB4UVJFdGY5V0laRStUUDc2Q05RZEVN?= =?utf-8?B?VklLamttWDU0dVdxQnptYXdjR1ZPcHlvOUZ1NXJ0THhhS0UwTXAvNkJNcWdX?= =?utf-8?B?RXBzbFR6TlJzZUtuRHZ1a0REWnpOY3VqSHp2aWUvR1BvZHlWQjdMY0xyVTlJ?= =?utf-8?B?K0xlMjZKcVRzMjNvbnhGRnNxbWMyMmNXaTZ2bnd5MWxkWWVoMGNQb2VlSmdz?= =?utf-8?B?clNNVG93L09UcGRuTEVKSTJCWi9aZ3QzSVdKRWh6V1c4MzVla09XU0dhWk91?= =?utf-8?Q?WgtEc35PjLtOhfPKoUoqoBA32KFllz/o1i+iSgr?= X-MS-Exchange-CrossTenant-Network-Message-Id: d2016537-59b6-4890-6a30-08d8e93ab88b X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 11:49:28.8393 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ozd9N/IzRHmqdgHDeTZYOM3E92aa2ywwzE0d9L34mUQUYo3jNfHdvUvphAtY8EgjSbAaMBWAy5H7ytsuBMizluH3mPLz+zU2Ln49jAPThmA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2673 X-OriginatorOrg: citrix.com On 17/03/2021 11:27, Julien Grall wrote: > From: Julien Grall > > Support to liveupdate C XenStored daemon was added during the 4.15 > development cycle. Add a section in SUPPORT.MD to explain what is the > support state. > > For now, it is a tech preview. > > Signed-off-by: Julien Grall What about oxenstored ? ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Mar 17 11:54:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 11:54:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98669.187268 (Exim 4.92) (envelope-from ) id 1lMUlE-0005b3-Uy; Wed, 17 Mar 2021 11:54:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98669.187268; Wed, 17 Mar 2021 11:54:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUlE-0005aw-S2; Wed, 17 Mar 2021 11:54:48 +0000 Received: by outflank-mailman (input) for mailman id 98669; Wed, 17 Mar 2021 11:54:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUlD-0005ar-H5 for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 11:54:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUlA-0005Fd-Gb; Wed, 17 Mar 2021 11:54:44 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMUlA-0001FR-7W; Wed, 17 Mar 2021 11:54:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=c//ys24c5UYVm+BYnE/A+cLez1A+IVc+8GG/DkQMbts=; b=NawzYYqF4vgOM1IH2srIO3xg0u ec+rFkImZO8CxIBike4XoE8+rpseyVhD+OOrwzCR9o/1zuZPW7yEcJ68dy8gS4i4+nprPTvQcw6WL LGWVbVA3h6fTEqN4C3bHfLf1ZJxYJzPkzaupiEyoQqrZS9tQ2GcAVyZsbDJCPC51h0Xo=; Subject: Re: [PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Julien Grall , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Juergen Gross References: <20210317112745.15207-1-julien@xen.org> From: Julien Grall Message-ID: <87fff120-5ed8-4775-2340-3852ee7475e8@xen.org> Date: Wed, 17 Mar 2021 11:54:42 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 17/03/2021 11:49, Andrew Cooper wrote: > On 17/03/2021 11:27, Julien Grall wrote: >> From: Julien Grall >> >> Support to liveupdate C XenStored daemon was added during the 4.15 >> development cycle. Add a section in SUPPORT.MD to explain what is the >> support state. >> >> For now, it is a tech preview. >> >> Signed-off-by: Julien Grall > > What about oxenstored ? Oh, I read your answer as there is no support. I can resend a patch with the following title: "LiveUpdate of C/Ocaml XenStored daemon" Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 17 11:59:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 11:59:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98671.187280 (Exim 4.92) (envelope-from ) id 1lMUpi-0005oh-HA; Wed, 17 Mar 2021 11:59:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98671.187280; Wed, 17 Mar 2021 11:59:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUpi-0005oa-E8; Wed, 17 Mar 2021 11:59:26 +0000 Received: by outflank-mailman (input) for mailman id 98671; Wed, 17 Mar 2021 11:59:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUph-0005oV-OL for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 11:59:25 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 07450d08-1dd8-4e1c-8e06-ffa5c3328902; Wed, 17 Mar 2021 11:59:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07450d08-1dd8-4e1c-8e06-ffa5c3328902 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615982364; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=hNF4kb/u3xwNeIKb+FS2d/cW9g9oKs0SmqQRrrUmjjo=; b=QSDdnoLKCONOqvwCntDkZinLkiUrOsOHlMdU7c2+HvRgd/QISHEhsSd1 Sx9LNVxgLFnXQKAep/MbUdOjAmw4yFq3yO2U0QVUz8m3yULX6tixsAroj ZOWWqilQXr0qkVe1KHuMt5+EBoYfk29/j3uzjZ+rB+VLgCi3cd5Kb3Z9X o=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: QNMgavCVX4nX2dV6qZbLIDna6bHu7klltddf9Ssub0O9eCkeYApo7jsdJSq2v+9YRrKg8JoRIc +D9dMrb0RNusqaj0YfTtfJGn9SaSWFxGjWLsZ++NQh5obd5l9QQmLmGg2905Dgod2F1O7Vs82D 4Nd4o/WX2pnmD+a+cz7d1cr4nK8N3ZcEOT01y5mcmwJt5hWcUGY7hs3qP2HFnFFyWFlQPcF/iP t3XjCCzyislRlNTRGBPa3CIyh01zm8Bly1OeIZ4HQm0e307Er9ZBeq/w5h2dxy1qAShQGjz+9b +6s= X-SBRS: 5.2 X-MesageID: 39656890 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:6dSSQKO0C8J4+sBcT27w55DYdL4zR+YMi2QD/3taDTRIb82VkN 2vlvwH1RnyzA0cQm0khMroAse9aFvm39pQ7ZMKNbmvGDPntmyhMZ144eLZrAHIMxbVstRQ3a IIScRDIfXtEFl3itv76gGkE9AmhOKK6rysmP229RdQZCtBApsQiDtRIACdD0FwWU1iDZ02CJ KT6qN81kSdUF4Qadm2AWRAYvPKoMfFmImjTRkNARMm7wfmt0LW1JfRFR+E0hACFw5e2LtKyx m4ryXVxIWG98u6xBjVynPJ4/1t+efJ59NfCKW3+7MoAxr2jALAXvUZZ5Sju3QPrPir+BIWlr D30modFuBSz1+UQW2vuxvq3GDboUQTwlvv00WRj3emgeGRfkNDN+N7iYhUcgTU5iMb1bkWus 87vBP6xu5qJCjNkyjn69/DWwsCrDvTnVMYnfMOlHsaaIMCadZq3P8i1XlIG5QNFj+S0vFDLM BSCqjnlZJrWG+BY2uclmdix8HEZAVIIj62BmIGusCTzgFMmmF4w0Yy1KUk7wc93aN4ZJ9e6+ veNKN00JlIU88NdKp4QNwMWM2tFwX2MFzxGVPXBW6iOLAMOnrLpZKyyLIp5NuycJhN6Jcpgp zOXH5RqGZaQTOuNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dQWeVVEHiaKb0rciK/yef8 z2FINdAvflI2erM51OxRfCV55bLmRbeNEJu+w8R0mFrqvwW87Xn92eVMyWCKvmED4iVG+6KG AERiLPKMJJ6V3udWT/hDTXRnPxam3y9Z99C8Hhjqwu4blIErcJnhkeiFy/6M3OAyZFqLYKcE x3J66isq7TnxjwwU/4q0FSfjZNBEdc57vtF1lQoxURDk/yebEf//GWeWVY2mq7NgZyJvmmVj J3lhBSw+aaPpaQzSctB5aMKWSBlUYeo3qMUtM6lrCc49zmPrc1FIwvVqA0NQijLW00pS9a7E N4LCMUTE7WET3jzY+/ioYPOe3Zf95gxCGxIcBVrnrbnV6Gpd4mQ0YaWzLGa7/TvS8eAx5vwn Fh+a4Wh7SN3Ry1L3Ekveg+OFpQLFiMDKl+FwSDboVMkrXNcAV9JF363ACyulUWQC7H5k8Sjm vuIWmxdevQClRQgHxez53n6Uh5bGmbYkJ2ZE1rqIEVLxWyhl9DlcuwIoaj2WqYbVUPhtsQNz zIehM+CAJjzdLf7m/ZpB+yUVEdgrk+NO3UC7ouN4zJ0nS2MYuSiOUtBPlP5qtoM9jor84GWe +SYBWuMTv9Eu8lsjbl/koNCW1Rkj0JgPno0Brq4CyEx3Y5G+PVO0kjaLcBId2QhlKUD8qg4d Fct5YSsuSxOGmqNYLD5qHTcjJZKhTc5USxVPolrJhIvaQ08Jt/dqOrJwfg5TVi5lEZKsyxqW Y1BIJcy5rFMpV0f8MTdzlCl2BZ3uinHQ8OiEjOHuQ6fVsRlHfVMNOC3qrQpdMUczq8jTq1HW PazjZU8PjEVRaSzLI2C6o/JmJNdUg3gU4Std+qRsn1CA+wcftE80f/GnihcKVFQKztI8Rdkj 9Kp/WJlfSQbSz2xUT5uiZ6OLtH9yKCTdmpCAyBXc5O/NrSAyXCvoKapOqyhizwUz21dgAxgp BEb1UZaoB7sQYZ5bdHmRSae+jQuUIqk1xX/DFhmBrM4+GdkRbmNHADFxbYjJVQVSRUKV6Sg6 3+gLOl6Eg= X-IronPort-AV: E=Sophos;i="5.81,256,1610427600"; d="scan'208";a="39656890" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WlRdWO6KyUXXnGBabdLSwhISvp6e5XAM/tJf9WUDJMPncVILEf5YhEJXrWPu4bVL9iuyohAiKXmIUpKtcLTRKG9Ykw8G3jyoCahTUgn1lKUXesoXx3GdeL8B9shlgy/YjIeFLmcflXAxD4kCP98GcqG1B2gZjaxStAD37x3Mw94qIVJy1OKf2+I+NcLpfDHfTsr1+2aNM4ZR4Q2Gx/7pEB/OAgS0t3ZidiE6D95CPM9AIC12VuiVGZbBLGGh9THcfPVwV3fiktgbTTZikwkpUv/zWwkN+Pib1G7U0FI6d2JKJSs94s5WWWq4GwOuKYPQpv9MGLrZNvtRW8y+A2tUdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNF4kb/u3xwNeIKb+FS2d/cW9g9oKs0SmqQRrrUmjjo=; b=GAomSkqZFtWZvIQkeBXjMfoUzAYQJ1+8z5hnpytdRpMtz8+LvwFmM5veETVrPAtXC6qwICBXascX6RIaLThxHtZqzYTU2DUVpQeczgYUIPYgwXbegi1CCFMSwP1dskB1ahNZCsZpoFN21txuqDjraLlZWpstxnSCnmqRB4IJmlTsL8C9ySNPMqKkuaGVZpLQP7Lln29nES1p2uuH9e/MWiDrNdYqeJwI5f0/GuQraLSlPREecA6Wava/x6BQct4T35HqPYIcql3LSSGHtU4Xz/NvuWY6nj/F/9I7b7HsYjq1NdFkixPrxoIDM1pDc3ef8vWU2P0MmYPDGYrIfbO56g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNF4kb/u3xwNeIKb+FS2d/cW9g9oKs0SmqQRrrUmjjo=; b=aF3SM5tElmlvwamMXNLF/hxcT8S2c+kBCPqB84LimL9Z4upyZW0y7APY4M2Fp8XSt1EJ+bOeqU10nhoIY5+aSh3UfDUCc0ZTt7z1APtipRF/x/KJaRV/Fq0bJ10fUaRPSxNHoDOz+gBg7QQDLKMEWYnISysIE4TnEZ/kxiG3HGc= Subject: Re: [PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview To: Julien Grall , CC: Julien Grall , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Juergen Gross References: <20210317112745.15207-1-julien@xen.org> <87fff120-5ed8-4775-2340-3852ee7475e8@xen.org> From: Andrew Cooper Message-ID: <89c5a560-4d71-64b7-ac1d-07fc86ab3fc3@citrix.com> Date: Wed, 17 Mar 2021 11:59:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <87fff120-5ed8-4775-2340-3852ee7475e8@xen.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0361.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::6) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2e2f00e3-e45c-4b1d-ffe8-08d8e93c1930 X-MS-TrafficTypeDiagnostic: BN3PR03MB2131: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DdKBDbeF6T/Q30jg2FAFMnSTmyXsC1/iyARgaj5BVXHSo9i/fI24pnc6Cx100ZAJdlJ0Y3rlRTiMSCfusmcahOmLcb2yxcQQKAx/ASqvo88ql+lE0VL42sHPTlkjRVKqV34CQbF8nlIQTMGXmeoI6ZzORByhae4oMgt1O/ClEhPiOrkF1UutQ35LGBOs0Vshorch3VvdRuyBPhMKggRTmyoZQ9FYPOTGrHlhmvp1oDUePPhBYfigHuLTRIBXfL5rNtYlNXJEmLHcZhCWFL6CfwsTvm6OPbWdm8uOKHI148E3tn+SJzPtfisN31HwUGEgFDQjwbaqpx8F11XxAXf+6hhO4wPXLLcjn+vCiPXQaDU84iCCMP1oozhTZJ2F/pR05BU1b97t0SwJme4YuKZ8h+N7DigprqNtPr+zX35iBFaiuDQVCYYlqIAISX7c7seRQ+PsU3Ytqj8QlY5k7yIHYtkJ1WhwqKMJFBBedBUvJEcTiycxbwKez8uW0wszg3MGBRqQ156zGt2Hw2pYw2xqpg4dbwvxAh0/tcVPEy/yxCpsrTuyKIGal/XI7ItQPyNnRnH/rZuSNdXSsfGSo9ewR2Qyf6qt/Wlo2fjQglCOkjg8xgLKpuKO4Tg2mmo8XIc1OqQA/cudE11wsz7GjgWPAg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(39860400002)(136003)(346002)(366004)(4326008)(956004)(36756003)(2616005)(16576012)(53546011)(83380400001)(316002)(16526019)(31696002)(54906003)(186003)(31686004)(6666004)(2906002)(66946007)(8676002)(5660300002)(66476007)(4744005)(66556008)(26005)(8936002)(6486002)(478600001)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?c3B2SDVZSGFUUW9GcDd2eTBORWpDdTZHYlpYeDF0K2hEa2ltNFRSc0FyeW1o?= =?utf-8?B?aFFaN2dMTGFjRExkb2dvQ3BJQW82N3ZSVlRtaytxNjZzT05WbWY0VjF1TUh5?= =?utf-8?B?ZFNxalBwTWZQVllPWTdYc1A3NEpROXFyOVgvemM4cFYzdHlhQlFSbWV2T09O?= =?utf-8?B?TG12U0RWb3VFZkF4STBhY1gxMU5IOTBLVVJNWXhMU1RzYSszM0lCWldHaHIy?= =?utf-8?B?ZHdkVVlNd0NNNHYrUkI1RTVPSkkvSCs1NTFUcFpldnlKRzg4OFNGdmhUR081?= =?utf-8?B?NjFLUXdscjhSMHE2a00wclFHQ3F0d1RMZ1hEVklUcHRORDZINStWa2xydVVC?= =?utf-8?B?VGtjRXE2UGdJRzBsbGhkVndwS2xjZDNEVTlTeXpnM1pYbTZLRzdaeTg1bjVh?= =?utf-8?B?NHg2QUNIUmhBNnV3RWg0Vi9rYTRCWjA4NEZJaVBtNFJPRFdFQ1FZL3dzZ0xh?= =?utf-8?B?NnJFSGFNZVN6dTc5RHp0VDY2WWJhUDkyRkd0V25vNnBacjM5aHE2amhaZVlU?= =?utf-8?B?YWNMaW1BOUdPU0E5alBhcStFMjdDamxzSlIvSnpCTFp0WmdWQVZmcTZtNkwr?= =?utf-8?B?SHdFTEhwc3l2TGpsY0VyZE9VR000MkF6b3pzTnNvWWJBcDJERStOL2kwMTkx?= =?utf-8?B?M2JqSnBjL1M0Z0RSWVUydC9yYUdoajJrWDgxcWNOQ2FTNFBLYzlOQURaRXNW?= =?utf-8?B?WXM0VHJoNlV0WktzUDRmRDVkS1B0N0U5TWJMVDV0SlF5OW9MMHFORSthMVcz?= =?utf-8?B?TkdRSG5oemRaQVY3ajVNZnd0bWxQYlU5RzBidHdhVGJReUtoL3pPUmk4Wk9T?= =?utf-8?B?UVo0MlBINjN5RXlYaHArUTJzb1J5eGE5RHlFK2NKK3pQUU1nclVoSWU4OUdq?= =?utf-8?B?TEh4OXdic2YzM0xxMDdoQk9OTzJCWmJocVJoQkhiRGN1Q29iUlBab2N0WXhi?= =?utf-8?B?Vmg0ZHB2Wkg3bVFIbVlrLzZheGFTai9pTFVFK0dVeTlzem9Ib1RySUVBZnB4?= =?utf-8?B?Qk9QK1owcmFBQXF2eC83cEV3Y2t4dmhhUlZKNnBkQ0dKQjFxb0dqUE5ZNE52?= =?utf-8?B?MVd2aG90dHRLUU1FZUgweDZRbzVBMDlVU3Y3NkM2eUduZGQxbmtrTE5OSUN6?= =?utf-8?B?bjBYSmhCc2Q3VmZMV05KNzAwUk4xSDhnamsrTUs0YVRGRGxUNVlRdmpUUDYz?= =?utf-8?B?QlFRZ3hkcU12K1RvTXJEZ1lpZWZRR0tlSnlZTlROVWhDWFgxR3RPTWFFOGxq?= =?utf-8?B?TXBuWTdDYzhHbFpoSzVlTDc4QS8rek9zQXhOeTlTYnkzVXdBamhCVjhDdysv?= =?utf-8?B?RGZGbm5ZcGFBRGRGenlsWVpJTWYvNUtxREdIdDlwcEtKNlZTWVJlS0NJNDlC?= =?utf-8?B?NzZvTXFyTlB1V3J1NFJrWmp4SUJuZGt4QVk2dkRkbGVzWXRDcFpRdWhZaitU?= =?utf-8?B?L0R4ZmNNRllZVVVjSnlPckMzalZ1dlFDN1BtY3hJVThjK0JmYTk5MVFUNlQv?= =?utf-8?B?RndqVEg0SHZaWitqdUFOcDF6NWhWSStXUk5MbURxY1IrZHN5Y21lZGNUb2cy?= =?utf-8?B?bkc5N0JKdE9nWTVYNVVMVXc1MVVtUDRBNUVPdlRMMXlVdTVGcjdKQW9zUkkx?= =?utf-8?B?TGhLUzBOY0NucEVuU0wwb0hMVVR6M3hTRkk3aTdVME9oQnYvcjJtUHFjMEYr?= =?utf-8?B?cnZLTjRRRXVkVEhPTDVSTjNkbDN1cmxNVDFuVjFSa29wNWVqOHdzVXJGdllJ?= =?utf-8?Q?nySRKqefofvg/K59gBUYh+3k1UNRGjrLp8/IQ/B?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2e2f00e3-e45c-4b1d-ffe8-08d8e93c1930 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 11:59:20.5874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F7yJF4JNl1ijmbHIqQKnxrg0fPVj7kTjhwYiokWUILaTr4cwDP7oUfCW8wmviJE/GUS96rpKjCklEEeddGepSVLi7z9sCsxipnWNdsxEXdI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2131 X-OriginatorOrg: citrix.com On 17/03/2021 11:54, Julien Grall wrote: > On 17/03/2021 11:49, Andrew Cooper wrote: >> On 17/03/2021 11:27, Julien Grall wrote: >>> From: Julien Grall >>> >>> Support to liveupdate C XenStored daemon was added during the 4.15 >>> development cycle. Add a section in SUPPORT.MD to explain what is the >>> support state. >>> >>> For now, it is a tech preview. >>> >>> Signed-off-by: Julien Grall >> >> What about oxenstored ? > > Oh, I read your answer as there is no support. I can resend a patch > with the following title: > > "LiveUpdate of C/Ocaml XenStored daemon" I'd put it at tech preview, just like Cxenstored.  In particular, it has the same issues concerning outstanding transactions. It might however be worth having separate line items in SUPPORT.md to start with, just in case the different implementations progress to supported at different times.  (More likely, as there isn't an embargo adding urgency the work now.) ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Mar 17 12:06:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 12:06:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98680.187292 (Exim 4.92) (envelope-from ) id 1lMUwR-0006mQ-Hw; Wed, 17 Mar 2021 12:06:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98680.187292; Wed, 17 Mar 2021 12:06:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUwR-0006mJ-Ek; Wed, 17 Mar 2021 12:06:23 +0000 Received: by outflank-mailman (input) for mailman id 98680; Wed, 17 Mar 2021 12:06:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUwQ-0006mE-3p for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 12:06:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUwN-0005TC-3V; Wed, 17 Mar 2021 12:06:19 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMUwM-0002BB-NN; Wed, 17 Mar 2021 12:06:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=ttAf8WMCxXbBRdwDCROIRSb6uIR+TP6/CkTxboqus1w=; b=r4u6AXsrqaHNpxcnMgDnGcb03k m4E8ZPjNU15pm7yXLZKd+6Wbe7/pX3mUpdOKbv0L5v3TeuwbMfKP53Y+XGjJiid1E47rCicMA9QkQ VkJYFhNDbMfa4FihKgfTlry6TQ4Tut+Q9uPvScTblYX2/AohCM3G/eeo3sw26eWiyxns=; Subject: Re: [PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Julien Grall , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Juergen Gross References: <20210317112745.15207-1-julien@xen.org> <87fff120-5ed8-4775-2340-3852ee7475e8@xen.org> <89c5a560-4d71-64b7-ac1d-07fc86ab3fc3@citrix.com> From: Julien Grall Message-ID: <487a6677-168c-1270-cdfb-ae4678b0d2d5@xen.org> Date: Wed, 17 Mar 2021 12:06:16 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <89c5a560-4d71-64b7-ac1d-07fc86ab3fc3@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Andrew, On 17/03/2021 11:59, Andrew Cooper wrote: > On 17/03/2021 11:54, Julien Grall wrote: >> On 17/03/2021 11:49, Andrew Cooper wrote: >>> On 17/03/2021 11:27, Julien Grall wrote: >>>> From: Julien Grall >>>> >>>> Support to liveupdate C XenStored daemon was added during the 4.15 >>>> development cycle. Add a section in SUPPORT.MD to explain what is the >>>> support state. >>>> >>>> For now, it is a tech preview. >>>> >>>> Signed-off-by: Julien Grall >>> >>> What about oxenstored ? >> >> Oh, I read your answer as there is no support. I can resend a patch >> with the following title: >> >> "LiveUpdate of C/Ocaml XenStored daemon" > > I'd put it at tech preview, just like Cxenstored.  In particular, it has > the same issues concerning outstanding transactions. I have some work planned for C XenStored to mitigate that as Paul recently discovered that some Windows PV drivers may leak transactions (see [1]). > It might however be worth having separate line items in SUPPORT.md to > start with, just in case the different implementations progress to > supported at different times.  (More likely, as there isn't an embargo > adding urgency the work now.) Sure. Let me respin the patch. Cheers, [1] https://xenbits.xen.org/gitweb/?p=pvdrivers/win/xenbus.git;a=commit;h=4d3c233a51aef91d464db4d295a1d76ef774a27d -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 17 12:09:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 12:09:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98683.187304 (Exim 4.92) (envelope-from ) id 1lMUyx-0006yv-Vs; Wed, 17 Mar 2021 12:08:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98683.187304; Wed, 17 Mar 2021 12:08:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUyx-0006yo-Sq; Wed, 17 Mar 2021 12:08:59 +0000 Received: by outflank-mailman (input) for mailman id 98683; Wed, 17 Mar 2021 12:08:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUyw-0006yj-4o for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 12:08:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMUyv-0005V6-RG; Wed, 17 Mar 2021 12:08:57 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMUyv-0002OV-DZ; Wed, 17 Mar 2021 12:08:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=UuGE2Hn38TCab/AUY1GqL3H5+H9JAMYDF0NMkEX8SvE=; b=Z/q+JX2J84npfzeRCHCQ+rDUEL 8ikB4sEzXKcf5VJREUYIAkz7WyIf6dYRNv8T+nijx8VBjjTPyf0b8QdIdE60gMuMmEY/4eT8dyFA/ eA1qbeV95WTfjLQCXgrvoSV+wK/lwgmhB70eekaiTuCC9fWil7qrBRZokQaqZqyRG3ac=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Juergen Gross Subject: [PATCH for-4.15 v3] SUPPORT.MD: Mark LiveUpdate of C/OCaml XenStored daemon as Tech Preview Date: Wed, 17 Mar 2021 12:08:54 +0000 Message-Id: <20210317120854.19903-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall Support to liveupdate C/OCaml XenStored daemon was added during the 4.15 development cycle. Add two new sections in SUPPORT.MD to explain what is the support state. For now, it is a tech preview. Signed-off-by: Julien Grall --- CC: Juergen Gross Changes in v3: - Add a section of OCaml XenStored Changes in v2: - Clarify this is only supported for the daemon version - Fix typoes --- SUPPORT.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index 7db4568f1a0f..1021a24801dc 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -177,6 +177,14 @@ Support for running qemu-xen device model in a linux stubdomain. Status: Tech Preview +## Liveupdate of C XenStored daemon + + Status: Tech Preview + +## Liveupdate of OCaml XenStored daemon + + Status: Tech Preview + ## Toolstack/3rd party ### libvirt driver for xl -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 17 12:31:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 12:31:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98686.187315 (Exim 4.92) (envelope-from ) id 1lMVKw-0001Al-R0; Wed, 17 Mar 2021 12:31:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98686.187315; Wed, 17 Mar 2021 12:31:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMVKw-0001Ae-Np; Wed, 17 Mar 2021 12:31:42 +0000 Received: by outflank-mailman (input) for mailman id 98686; Wed, 17 Mar 2021 12:31:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMVKv-0001AZ-VY for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 12:31:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d0cdb3ab-98e3-422b-8d22-78236217b43e; Wed, 17 Mar 2021 12:31:40 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B7FCAAB8C; Wed, 17 Mar 2021 12:31:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0cdb3ab-98e3-422b-8d22-78236217b43e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615984299; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lDT/V6NvAB2iH9eTYJmJDLJee6mfTmo/0zrRP3hp/+Q=; b=GT314JB2PU23aVYN/qCtUaaDwQeZ+QKpb+RsX81l1QC06NPwJsy4KKc4lbjObMJjmDgY22 J1/dOviFUhk45Q22XiWtMxf7Td2XF3Zhbs75t8YoMf1yvZynL9dvcw3PfCvK4Fuq//5Vt3 JkKi2h5NcdAsqEhIiATbTMIfMj6HIT4= Subject: Re: [PATCH for-4.15 v3] SUPPORT.MD: Mark LiveUpdate of C/OCaml XenStored daemon as Tech Preview To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall References: <20210317120854.19903-1-julien@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <2db25b94-1f2f-c4be-0b5f-486c1cd83518@suse.com> Date: Wed, 17 Mar 2021 13:31:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210317120854.19903-1-julien@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IJenQ6oLL16CtKMJecpoZQpwM2OyXqjif" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IJenQ6oLL16CtKMJecpoZQpwM2OyXqjif Content-Type: multipart/mixed; boundary="pv8pPLj74RbiJVayUompya97ErcJFHZdp"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall Message-ID: <2db25b94-1f2f-c4be-0b5f-486c1cd83518@suse.com> Subject: Re: [PATCH for-4.15 v3] SUPPORT.MD: Mark LiveUpdate of C/OCaml XenStored daemon as Tech Preview References: <20210317120854.19903-1-julien@xen.org> In-Reply-To: <20210317120854.19903-1-julien@xen.org> --pv8pPLj74RbiJVayUompya97ErcJFHZdp Content-Type: multipart/mixed; boundary="------------D18F7D0FA9210AF23AF72FE4" Content-Language: en-US This is a multi-part message in MIME format. --------------D18F7D0FA9210AF23AF72FE4 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 17.03.21 13:08, Julien Grall wrote: > From: Julien Grall >=20 > Support to liveupdate C/OCaml XenStored daemon was added during the > 4.15 development cycle. Add two new sections in SUPPORT.MD to explain > what is the support state. >=20 > For now, it is a tech preview. >=20 > Signed-off-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------D18F7D0FA9210AF23AF72FE4 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------D18F7D0FA9210AF23AF72FE4-- --pv8pPLj74RbiJVayUompya97ErcJFHZdp-- --IJenQ6oLL16CtKMJecpoZQpwM2OyXqjif Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBR9qoFAwAAAAAACgkQsN6d1ii/Ey/c LAf9EzvBEUYfSyp2FTlo4ZQxSXFbHRX33oMo2tatQIrXL3pRSTwhw2aUbIITYJVXgoBTsQODte8r qhGw27h//XatVQJmSHfplR0makheYPXN/gOQsuGkET/hzy80e2XV18Mds3M6Fi3+/WpbUXZoxpIf DDHU++V9LEgjErwZYTWP3JsmM1TYJ6NofIsIk1kvPh5jglUX8gRDI90sGRbv/08AO+GStbyRw2gA 4rwcEjN6Qt82Xb9JcjnkwugOaMSyJixAOnuKdFvRXcmVteT9+BooPGki+dFm1KsQrY1l4q+Qtyfh 383fe1m2FygVdFy4CTnca9pDUBVPYKSXiN04dBIAdQ== =A7Qz -----END PGP SIGNATURE----- --IJenQ6oLL16CtKMJecpoZQpwM2OyXqjif-- From xen-devel-bounces@lists.xenproject.org Wed Mar 17 12:45:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 12:45:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98690.187328 (Exim 4.92) (envelope-from ) id 1lMVYL-0002Aq-0k; Wed, 17 Mar 2021 12:45:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98690.187328; Wed, 17 Mar 2021 12:45:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMVYK-0002Aj-T1; Wed, 17 Mar 2021 12:45:32 +0000 Received: by outflank-mailman (input) for mailman id 98690; Wed, 17 Mar 2021 12:45:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMVYJ-0002Ae-Iu for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 12:45:32 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dcc5ac69-11bc-48c0-8079-81273cc8d118; Wed, 17 Mar 2021 12:45:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dcc5ac69-11bc-48c0-8079-81273cc8d118 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615985130; h=subject:to:references:from:message-id:date:in-reply-to: content-transfer-encoding:mime-version; bh=KlTX4UsfeiGhV//szxriwHkLDC+vLgA9f/95c/FNTa4=; b=cCqFSrsRIGbsl3mCD8cMJOrogoaMuZE02RIsHZaFrfDmKMD5eqNncxmz ouk+vpe/bWelp2BHJDBE8kWoAEz4Hk1WQaKgtsqwG3bvPBMcXStuj/1Y0 dLx6zoIVkfBdRUnLyiOssACNm30FxF7OcgzDwq5nKPgm0Nc64vn1NlTK1 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 7JxEDF+lBuj+Etc2WhtyqY1E4prMu3cNqq6lpBrytolYmV2RhLVbVTWzSND5VoMv4Vseuq6MOE h3lJSj0YIS/EUv+LjKthQOOPWzAbTm6MebOwOGysdxHNQkSwHlmT/V+bZUPaIGNpN+cQHjtWGG xWmfYFVLHD/1OzPseevoCG2X55PNdf6bI283m6PDzCES9KxPhxr6LwBoHlnle9Mlzf77U6w53i PCDswPmInmY02StmeVL/WKAVLMF5ngqW4WxG9wMIih90C41lTe0WebJKP9+EaaovBQTnLEVHDw qEM= X-SBRS: 5.2 X-MesageID: 39660410 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:YIbVtqtB1zNEmlp7ybUnmvry7skC5YYji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOj7U5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qz6Y 5JSII7MtH5CDFB4frSyBWkEtom3dmM+L2pg+Cb9Ht2UQR2cchbjztRIACdD0FwWU1iDZ02CJ KT6qN81kWdUF4Qadm2AWRAYvPKoMfFmImjTRkNARMm7wfmt0LV1JfRFR+E0hACFw5e2LtKyx m5ryXVxIWG98u6xBjVynPJ4/1t+efJ59NfCKW3+7AoAxr2jALAXvUGZ5Sju3QPrPir+BIWlr D30m0dFuBSz1+UQW2vuxvq3GDboUUTwlvv00WRj3emgeGRfkNCN+N7iYhUcgTU5iMb1bkWus 87vBP6xu9qJCjNkyjn69/DWwsCrDvSnVMYnfMOlHsaaIMCadZq3Pwi1XlIG5QNFj+S0vFDLM BSCqjnlZJrWG+BY2uclmdix8HEZAVJIj62BmIGusCTzgFMmmF4w0Yy1KUk7wY93aN4ZJ9e6+ veNKN00JlIU88NdKp4QNwMWM2tFwX2MF7xGVPXBW6iOLAMOnrLpZKyyLIp5NuycJhN6Jcpgp zOXH5RqGZaQTOgNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dQWeVVEHiaKb0rUiK/yef8 z2FINdAvflI2erM51OxRfCV55bLmRbeNEJu+w8R0mFrqvwW8zXn92eVMyWCKvmED4iVG+6KG AERiLPKMJJ6V3udWT/hDTXRnPxam3y9Z99C8Hhjqou4blIErcJnhkeiFy/6M3OAyZFqLYKcE x3J66isq7TnxjywU/4q0FSfjZNBEdc57vtF1lQoxURDk/yebEf//GWeWVY2mq7NgZyJvmmVD J3lhBSw+aaPpaQzSctB5aMKWSBlUYeo3qMUtM6lrCc49zmPrc1FIwvVqA0NQijLW06pS9a7E N4LCMUTE7WET3jzY+/ioYPOe3Zf95gxCGxIcBVrnrbnV6Gpd4mQ0YaWzLGa7/VvS8eAx5vwn Fh+a4Wh7SN3Ry1L3Ekveg+OFpQLFiMDKl+FwSDboVMkrXNcAV9JF36wgCyulUWQC7H5k8Sjm vuIWmxdevQClRQgHxez53n6Uh5bGmbYkJ2ZE1rqIEVLxW1hl9DlcuwIoaj2WqYbVUPhtsQNz zIehM+CAJjzdLf7m/fpB+yUVEdgrk+NO3UC7ouN4zJ0nS2MYuSiOUtBPlP5qtoM9jor84GWe +SYBWuMTv9Eu8lsjbl4EoNCW1Rkj0Dnvzp0hG+szT98347HPbIIFNpA5scOMqR6mD4R/COlL V15OhFyteYAyHUUJqhz6qSUhtobjX0ikSyR/szqZ9Vsbkp3YEDV6XzYH/t7jV/wB46LM3Ij0 sQT6Rw3aDZNuZUDrgvUhMc2mBsqc+GI0QquDHnG+MSfVkiiHnAItOCioC434YHMwmkpAHqP0 OY/DAY1/DZXzGb3bpyMdN7HU1mLGw94m9l5uWMasn5DxirbfhK+B6fPmWmeLFQDIiDFrN4lG c23/i428uWfTH/wgbeoH9SJb9P6X+uRYeKOz23cNQ4uuCSCBCrmaul4Mm6kTfxR3+aUi0j9P N4XH1VSN9ChDkkhJAwyQ6oRMXM0xsYr2c= X-IronPort-AV: E=Sophos;i="5.81,256,1610427600"; d="scan'208";a="39660410" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cAdqeUYehD41EjXI1ZK91WSCLH7877AAD63Q1CpcWDfnGHFH5m+WiAHSutZCVh6ul+po0C55C6QITBC3g3PsprgZ/IHKDfDFJxNESxsL7+U1OxJeIj76sTQHvpqfL+FjCQVSHoVgYpsboiQ8Ktm7WXYwa9VCc7Xbb1euL40aFtBIgcjxTXWoRCL6ZkCOV9VMbV6u26pOqXqHG7jDF5koqP5pWeMjOHHNoWGUKhI1mA6Zi24TutyaHldm0fmmFcGDmiKgF1P56s8lZ+EIwFiBRaKF4SyNVZ958L3GQ6qq5cQyiooeVOqQGxS1ZCVUtMC41DMBgYSgV7goFEH0IlbPng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KlTX4UsfeiGhV//szxriwHkLDC+vLgA9f/95c/FNTa4=; b=L8Rb4L0y6R6lb+6Ty4ooaBUgdvhkpjF88Wuzaz4ZEi5UmoumLsaZeMgb+n4LajR0bCqMh5e5hOAoB3kUQsTV01uE3/eypFP35e2txHf5Z9z+z57AlNIUFTEd+NpAK/C78gFAHfkd0+VdAw2jsSX6FF2a+EftvFPUoUruJX1LXUQTbfJND7w9Dbr3NirCYQThuKgpNbyHy+I92Oq0WUvBWMQUw1xVZN0fYg3uRrH94mCrmGyE3SJwUepWo+iwrJjTqVIWfzJdnFFwK9I/sGo37tf7Z4zKWgHQkjZToTD3pFGE34LWIClDbBbu8j7+eJmOhGYU28rbqUh4Yw/AkU7q1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KlTX4UsfeiGhV//szxriwHkLDC+vLgA9f/95c/FNTa4=; b=btt78hDHm47JLRAR0Bh73HU8J9U4UNYlyKPW/L95GKCcrnhsRnsBrbFPI91axwWeK9j6xHMXnMIeXcH2+eVfa3S2QQM9qsH+58RvzZgaoTbPPxFC+6UGYXC/ik/ytH8lcBIkVF+aIba8KAGFn4lFN8bP3TK1WZiUFFVrChvQRVI= Subject: Re: [PATCH for-4.15 v3] SUPPORT.MD: Mark LiveUpdate of C/OCaml XenStored daemon as Tech Preview To: References: <20210317120854.19903-1-julien@xen.org> <2db25b94-1f2f-c4be-0b5f-486c1cd83518@suse.com> From: Andrew Cooper Message-ID: Date: Wed, 17 Mar 2021 12:45:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <2db25b94-1f2f-c4be-0b5f-486c1cd83518@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0039.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::8) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8f0e660c-416e-44a6-0dbd-08d8e942881c X-MS-TrafficTypeDiagnostic: BN6PR03MB2417: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PwNEM3lT/+4FlEg5TQ5N7Y7DCpJ6VDTmHC+Qyf6NCz3zxFGG/DX1UPup9DiDgyPAFG7IqKVox5634jIVG+ByQ+WDXmvrYVR4Kf8PK74hb6kBUY3pmOU7Z/7gh7HawOORpd7ePe1gq1YZk5SZVmrzef7wAXlVQFQWUykqWbreXfIlgF7aDxph/BdZI3j7f67joVyT7yIhDLVMJ3WHwpUiqQ+dxXReFOSCwyUI4vCprvhondPoZOpNxcoNUjxxuGDaHeGfrpQV7OI9EUZOF2d0I+forTZGLBPzMQ/6kHAQB/H0iE4ochaVm1R6fdPbyZFgp0cDVnesuzP6NAWOM6fmxIKE/AFYuuGTpSlDKV6VBB4VSSL5CTwYsW9AUaZKK3QHDfPSRzPmvo1Nl9RchNDsjzpOFCG6gDU0UEKoFW7sBHEbk41bEybc9rJ1SVHix33gumj3aoEpmAhA6zQUH6GgTQTHoD/qD7Mjm6ZUTNgrs5zAG1Gu/4pjrME+JkUC3QP9GN08RNw/r6n4MblNwjDecvU4QT3R/O7cxY/uig8NqtZG5dQ6TxuN5EClukcgqSNzA5ekD1p69NOiPXvD5d1Qm2d0Ok9mTeFpzb4Hx+Ug1PHAPUkMLhZ4noVj0PtgxF8cRo8h6jcWfVJ1z+LWbOUElg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(366004)(346002)(396003)(376002)(16526019)(6916009)(316002)(186003)(8936002)(478600001)(31686004)(16576012)(26005)(4744005)(8676002)(956004)(2906002)(36756003)(6666004)(31696002)(66574015)(83380400001)(2616005)(53546011)(5660300002)(66946007)(6486002)(66556008)(86362001)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?cy9QNHRqQjZRcXhoeC8wVUZoakh0MnQ5dm40RnV4MGZ5b0dzNHprMVdSU2ll?= =?utf-8?B?ZFhQWVFlL2U3emw2elhHWmYvcEVOM2VkMU1EUFcrRFJ0dW9Nd3NXYnFRd1lp?= =?utf-8?B?bElFSEFxaGZYN2dnM1FzZXhqZmlLQlA2b1Jna051TE9RN2Z6bHhaK003Q2Vs?= =?utf-8?B?SVhCaFdVUUJuZ3cyNUhvL28xc0RRbUhzQnVUYTBPVFp4VzlPck56NmZLNVZH?= =?utf-8?B?aXcvVUNUS01nWTVRWUpqM09xc2VXd1JtRldaRnR2TU1aRHJRblowV0grMlBG?= =?utf-8?B?WUF4QnJTaE85a2RNZndLOEhZVGp2Mmk3SEVMZkFsd1B3WTNDRzg0M3Z3NFZT?= =?utf-8?B?NUl1c3pMY2p6ZTBwTmRlc2hsU3E3TC9aTTFzME44QjZtdWRZaUJ2cmw4VzQ5?= =?utf-8?B?OUVXR0plVVlYUG5UbEp6a2JncHg4alFyMDllQXBvQW9oSkpUOGdXczVqbmlX?= =?utf-8?B?QVR4OHFPaDRSMURTVjVBWmc3VWhNMGxvV2pwV1NkWUxPczBnU25MTFBwYkMz?= =?utf-8?B?aFVBY0Erck5JWXVIa0hyQVU0aGZzTjBiNXIwa3J3R2lGWHZreVV4TklVMGt5?= =?utf-8?B?azN6eWdVclNEcHBDRHdFRFVBdjNoUEhuMFpWVnM0ODdnZGlaMU9nTEFQcnZw?= =?utf-8?B?bWM1dDhlZnpsNW5LK1MwUUhNZ3FGZ2dBWGc2eWhTTjk3a2lDVWpOOFQ4L0Mw?= =?utf-8?B?NkoxSzlYSnhndHdmQUU5bXNmYlRuRHVzZ0lwQlJrWXFoWVJOREYrQ21DZFdv?= =?utf-8?B?U21LWmhkNVFUYWZ5R1BWNHdncXVhMGhFSjZ0NVdYQmxXaUgwSTc4VW9pZkRF?= =?utf-8?B?MHlIcktlN3RmdDA1a1VRRUFpRUhEYlJoV3I2eE1jSDNyZEJsd2JzM0FJbVZi?= =?utf-8?B?SHdiLzY1Z0dtU0ZsUmxmbGZZbzNNcitPNkZqVVREV3AxLzFwTzJpK0ZCKzJ2?= =?utf-8?B?V0l2bDNZTk5oS3BVVTNablFYMVFhdk01OUVNa1Ntd1VuVE5Cb2V3OExVUWVR?= =?utf-8?B?Q1F2dmZSV0Q4cEZPNlppTWZGZC9JVG15YTMzcCtSZnp5UjhxK00yWWQxT3NF?= =?utf-8?B?Mk9oTVc1VlZKMjNlREswYURkdmhkendIN29ERmFjWUUrKzBkSFdVdkhGV2k0?= =?utf-8?B?ZkQ4QnIvV2o2QmRsUkVFTE04WkJTQlV2Mkh1dWdjbEZ5WlhtZVpJeThZQlhr?= =?utf-8?B?aVpTOGI3OFFMMzkrVTV1U1ViWjhjeGVTanZOK0ZQeThjKytCMnNkU0I4bmdG?= =?utf-8?B?dzhkeDVjTlB5MDFIdXE4L09xSklMTTMyYXprTUh3QjRvb0VsY3pOY0RGNmdG?= =?utf-8?B?cTc2UVVoWlRReDloc2s4eW4zck9nZitsb21PZ3RELzJqdWY4WjN2NmxjVGVm?= =?utf-8?B?blNoeVpGR3M1Y3U4SHQ2dTFsb0dIamt6VnpNOURtakRwK2dNZHhOeUF6dVpt?= =?utf-8?B?emxiTUNEakcvZnRsVjJ6UjU5N1lUOVk5NjNRY09oU2Jvb1YzVkJqbG8vQlVo?= =?utf-8?B?Rk51Y21UWXprU2NzUy9aOVJPZWF1eHFGZmhXeU82YWRMOTlpUVZ4eEluSnl4?= =?utf-8?B?WDV0bUwwYThyY3JIT05IczlBYVZ5MlBXYkRCODh2MS84UmRheDQvamEzRXZV?= =?utf-8?B?WitwVmZtUjlIQ3Q5bllQbWUrUS9xaDBLOEdKSURiVnU5T25jeHp6T014N045?= =?utf-8?B?MWl2NjAyTDVxS3FQZ3FaandLYkRYMS9tc0hHNzdzYkJSc1V0UEZwYllTQ2pH?= =?utf-8?Q?rmBmxpHrDhFfNajCWqMRZkegqucFjddXGVPlsd0?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8f0e660c-416e-44a6-0dbd-08d8e942881c X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 12:45:23.6366 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wc/GJRjr+egxiVSXEd8oh+liwqvLJ1uwUpH/s1OmOoK/FiusWDM+kTKjHkn3BHwedTp6IGG/q2rq31OYeCPU/dU+pB44kVtePFiLR3q899g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2417 X-OriginatorOrg: citrix.com On 17/03/2021 12:31, Jürgen Groß wrote: > On 17.03.21 13:08, Julien Grall wrote: >> From: Julien Grall >> >> Support to liveupdate C/OCaml XenStored daemon was added during the >> 4.15 development cycle. Add two new sections in SUPPORT.MD to explain >> what is the support state. >> >> For now, it is a tech preview. >> >> Signed-off-by: Julien Grall > > Reviewed-by: Juergen Gross Reviewed-by: Andrew Cooper I'll add "how to live update" to my pile of docs needing to happen for 4.15. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 13:22:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 13:22:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98694.187340 (Exim 4.92) (envelope-from ) id 1lMW7d-0005lW-Sn; Wed, 17 Mar 2021 13:22:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98694.187340; Wed, 17 Mar 2021 13:22:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMW7d-0005lP-PY; Wed, 17 Mar 2021 13:22:01 +0000 Received: by outflank-mailman (input) for mailman id 98694; Wed, 17 Mar 2021 13:22:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMW7c-0005ky-Dg; Wed, 17 Mar 2021 13:22:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMW7c-0006gO-5Y; Wed, 17 Mar 2021 13:22:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMW7b-0005F0-Nj; Wed, 17 Mar 2021 13:21:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMW7b-00078d-N9; Wed, 17 Mar 2021 13:21:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SdHreEHNzK2RvW76jlOUbCuvdwEdPN77cvECt/Yjpz0=; b=pJFUxjqKou/i6tHeNSrCsOBHhy hJICQXjKuLOdoaOilOWBXnUHpgcaeblSZFf8YvwLPK0eLXVGVpH2Efucak7eQFJLBcpE2EAJVxzu2 1tEJ5Lrl6IXtk55oM7xfqDkNOg4MWQ4bdi0ZbCZXSTuNcjXXNKFWwE96Lp7u3lZXIdQI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160105: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1df27313f50a57497c1faeb6a6ae4ca939c85a7d X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Wed, 17 Mar 2021 13:21:59 +0000 flight 160105 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160105/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 1df27313f50a57497c1faeb6a6ae4ca939c85a7d baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 228 days Failing since 152366 2020-08-01 20:49:34 Z 227 days 396 attempts Testing same since 160105 2021-03-17 01:42:05 Z 0 days 1 attempts ------------------------------------------------------------ 5217 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1294111 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 17 13:38:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 13:38:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98701.187355 (Exim 4.92) (envelope-from ) id 1lMWN3-0006st-Ai; Wed, 17 Mar 2021 13:37:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98701.187355; Wed, 17 Mar 2021 13:37:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMWN3-0006sm-5t; Wed, 17 Mar 2021 13:37:57 +0000 Received: by outflank-mailman (input) for mailman id 98701; Wed, 17 Mar 2021 13:37:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMWN1-0006sh-6R for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 13:37:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMWN1-0006vv-3Y for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 13:37:55 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lMWN1-0000Rh-1O for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 13:37:55 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lMWMx-000219-Sg; Wed, 17 Mar 2021 13:37:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=BdLNvDW7OyxARwrysB3soG4zVUGjI42P1eAMoZYCUTM=; b=Acjh+u1oXFU7AgB6n2TIDGgJGb CdRV+juMMF6p4d1ahpQwjQ2ZIZI+Ztw+GHNpoX/lcexipLIjxGSd9F531WFwn9e4dlxOi7ArAvEnz wxg8X//c9iOCcP4sUZO/oN2+WIDlWHB+c7qkhrtdLq1ktvwIc+YDjxgfIDnrY2yl5dII=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24658.1583.601613.903527@mariner.uk.xensource.com> Date: Wed, 17 Mar 2021 13:37:51 +0000 To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: Xen-devel , Jan Beulich , Andrew Cooper , Wei Liu , Boris Ostrovsky , Ian Jackson Subject: Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" In-Reply-To: <20210316161844.1658-2-andrew.cooper3@citrix.com> References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) I have read this thread and with my release manager hat on I feel confused and/or ignorant. Patch 3/ has a good explanation of what the problem is it is addressing and why this is important for 4.15. But then there is Jan's most recent reply starting "I find all of this confusing". Jan, can you please tell me in words of one syllable what the implication of that message is ? In particular is any of what you say a reason for me to withhold my release-ack ? AFAICT there is no explanation for why patches 1/ and 2/ deserve to go into 4.15. We are late in the freeze now, so I would ideally be looking for a clear and compelling argument. I'd also like to understand what the risks are of taking these. Can someone please enlighten me ? Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 13:42:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 13:42:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98703.187367 (Exim 4.92) (envelope-from ) id 1lMWRW-0007jh-SV; Wed, 17 Mar 2021 13:42:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98703.187367; Wed, 17 Mar 2021 13:42:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMWRW-0007ja-P2; Wed, 17 Mar 2021 13:42:34 +0000 Received: by outflank-mailman (input) for mailman id 98703; Wed, 17 Mar 2021 13:42:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMWRV-0007jV-In for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 13:42:33 +0000 Received: from userp2120.oracle.com (unknown [156.151.31.85]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7cdd0e11-62cb-491b-9ca8-5c799ca724d5; Wed, 17 Mar 2021 13:42:32 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12HDa1mp109003; Wed, 17 Mar 2021 13:42:15 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 378p1nv2fg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 13:42:15 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12HDYke7134481; Wed, 17 Mar 2021 13:42:14 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2102.outbound.protection.outlook.com [104.47.58.102]) by aserp3030.oracle.com with ESMTP id 3796yuum12-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 13:42:14 +0000 Received: from BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27) by BY5PR10MB4211.namprd10.prod.outlook.com (2603:10b6:a03:20c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Wed, 17 Mar 2021 13:42:10 +0000 Received: from BYAPR10MB2999.namprd10.prod.outlook.com ([fe80::50f2:e203:1cc5:d4f7]) by BYAPR10MB2999.namprd10.prod.outlook.com ([fe80::50f2:e203:1cc5:d4f7%6]) with mapi id 15.20.3955.018; Wed, 17 Mar 2021 13:42:10 +0000 Received: from konrad-char-us-oracle-com.allregionaliads.osdevelopmeniad.oraclevcn.com (209.17.40.37) by SJ0PR13CA0183.namprd13.prod.outlook.com (2603:10b6:a03:2c3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.9 via Frontend Transport; Wed, 17 Mar 2021 13:42:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7cdd0e11-62cb-491b-9ca8-5c799ca724d5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=UO4nQ+8IdYLmNMwK0SJ17RQ/xMqltbB4iQCeQZxLkyA=; b=Gv7n6DMUMB+pC9z/cjnKUEXtX9SisSGueGRzVAX7j5Jq3+n888KQR2FuMy7LZo6FIxGD eOg7BWJGzWZwDu7gSCz/REkcbuIMjzQIJcYNRfxPcSk0SjKUPYjun/VfqrnhvWD2uZcL 5iX9Gl+IRf9k2hT2K2sebh5pSjI8WiPVQDRows+prUGx+/6JYujvbC3ANORvHb992bPW vRdo6dLE1fx1T0qqA6IWOni29NCmLpveX38GTKVLeWgonQi/tmPQlHeBc20ceYlPlDOj kffp0e5Qi6wPNjoHzfp+vphELZuEb7QiA2gNTu+/fvWZ5p3xNJWlIA9f4yxF4+XA75yR SA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SUHw/HVbau2QpVJgPzEeDCfUvHE++N9q5bs3ZyswhLKxaxQFCaddF11f7KDSXQqxPemadFJ4eM0RhodtSwVSzSw2fh6OKt0xZBrigIr1tsySewQNeUlhi4iFVFpMzTROHEQ/iuFKzbLB+ya37uoyMSrUnaIbWrwWwkdtoA/r6/j33JyNJxMcNeDSPEBwt9skrwrAF9bGspbu90WdBNBZXKY5KWYmutikHexnxb2nGdrU4uhvtC5LewXVVjUEWIXTiMojruOp8aG+XIkcKme1BTQga/CbdaWH/7NKt8qP8fhlsmi2/J0OsxE8WWF/H1bv69q9WYJ9gxgcz6KZL0ANRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UO4nQ+8IdYLmNMwK0SJ17RQ/xMqltbB4iQCeQZxLkyA=; b=c7RkZEXb7vVIUr09Z4PxUgBTosjGFGqzozg4GhTNt02HbDIquv1K1J+lmxZZF6P3qdTM7p0xHpPb0i0pCfkCli0kJxkalAFR0apECxQ8gjOnh5DWsFF5gu15mtXJf7VgZUnMCy0kfAvxzomNkD0DoV8yUdBgEHTHf+eaS6ddzPRzloz1XhGpBy8daUNZDh+dcxuyr/WWj8wxkGvJiVP1xC7bGRsJUWNvyH2WJk/NdeNZLVZfsxqE6PQoEeVPiM7da7q0Lc5dVEyQK1ytle5UyPxw5RPYS7w9qmhzBN4efoojZOgdmkegEWRQ/4NCJFNACBzAR/78o4Rfc4BSiaxLFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UO4nQ+8IdYLmNMwK0SJ17RQ/xMqltbB4iQCeQZxLkyA=; b=bmGiU51H/2Hy6nFzEnWV6rw8V+3m2dc+iK66r/1vTV51CrmrxomLQJ0xlTxtURPFHVXcQUEzw3vyNIS6zwezuqcLRilOje5p+nSmCknde2+FPMjKPObKMFRoe64DeLgBjJG0pK3IMFExAWbDEJOitNRScThyFPkrhzd5NQOqH8I= Authentication-Results: lst.de; dkim=none (message not signed) header.d=none;lst.de; dmarc=none action=none header.from=oracle.com; Date: Wed, 17 Mar 2021 13:42:07 +0000 From: Konrad Rzeszutek Wilk To: Christoph Hellwig Cc: Michael Ellerman , iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Claire Chang , linuxppc-dev@lists.ozlabs.org, Dongli Zhang Subject: Re: [PATCH 12/14] swiotlb: move global variables into a new io_tlb_mem structure Message-ID: <20210317134204.GA315788@konrad-char-us-oracle-com.allregionaliads.osdevelopmeniad.oraclevcn.com> References: <20210301074436.919889-1-hch@lst.de> <20210301074436.919889-13-hch@lst.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210301074436.919889-13-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [209.17.40.37] X-ClientProxiedBy: SJ0PR13CA0183.namprd13.prod.outlook.com (2603:10b6:a03:2c3::8) To BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6961133c-965f-4efe-1fd4-08d8e94a76f4 X-MS-TrafficTypeDiagnostic: BY5PR10MB4211: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:901; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ape6wbm2igxDebgQnT7GV3m7/wqyfrp3AhiSrNOr9HvaK5jejQn6gJmwQuB7h8InCWsNmn+HmUwljlwGTEsfre0qRAJzmJZCWDU5D8aXh8i4vBdc/d8h8JHVIoZ/uSsy384GD0+QUdc1rAoAefIpUh04G4/5pt3TENwlTcrt0IFU5wmTzgVvPv/l43ihxkGsh+wcAoE4Pw0fqJuLG5dTop/ZgaUJXoobsWjUw4MKlUWMVhODg5+RoTX1krylcDBLjqfkQzInB8x7k1i0XT90tUz3jCQUcgCzQUm4SBabgupD43TaEYD+kiM0P2XnPK8np55HgPOYlEZWWeHrNkDhssUSHV5cYC+vWf9WeNTlglt0o0BRemPAoNTH/iE9zxPHaF10dpuVvlS7aLNHXMoFeqxuGyBhN8e4PfAojruSfoekklZaruEUA1vnJP19fdkQL5i6VNOX4ADHsk1W5REt5njN262oHmZDNZxiFtjtbnqkYaoIH5kUhbDnpWhJOfmaOhddRMTw5YUwWWeuCnMTkXnIV+J3N//HvLUo8K6pgWKi9sH3Dwbredn4qGMIyzze X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(396003)(136003)(376002)(346002)(33656002)(66556008)(83380400001)(8676002)(7696005)(956004)(186003)(52116002)(5660300002)(316002)(66946007)(478600001)(4326008)(54906003)(6506007)(107886003)(1076003)(2906002)(86362001)(66476007)(8936002)(9686003)(26005)(6916009)(55016002)(16526019);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?c4NHgPWKCyxISLqtAYw9IABI9HTRLFGk7eQXtLrx8394X8nbY5LD+PMn2RxU?= =?us-ascii?Q?etEck+L18nIxPfG65Wty5CX4SQ1nobGfwSBMpjm0iB2mlbyhYTgT82nx/7Ac?= =?us-ascii?Q?aJdNZgTZPMA+p5KSA7jXvmhNR9UZkJZOgYNomnOSipR8rYdsyDq8QLBwKecE?= =?us-ascii?Q?pHNfv2gEmgRxtWqBfV83CYVORkHJlYPIzqKFgDinxh2gHbcpebtH9qpb1CwY?= =?us-ascii?Q?vlxzBjc1rKwe4W/slarx6eq4YkAHTvZix97LCxRM6JwaUWwuY2j82nMhUP6D?= =?us-ascii?Q?SUWEmGKwDJxK4N5hTihj37x06wQdASpvWx9fhl6nNCMDgNgjzUx5etamCx2O?= =?us-ascii?Q?VmvU927AzwxRO5nKCx8xWln3/DfDtftBBerhb/WjOaHnmmpJ80AJqqGUsPK7?= =?us-ascii?Q?a8U5adiaJrFq7LbaxYHo8716V9KOI3M1mGetfFysFmExM2qBG6rdhAcN6Fn2?= =?us-ascii?Q?NHTRjFdmDnla3wuhaqd4Pdx4Yg8P2quUfYIAEEPpUozMt4GsCld+Z2hltqOI?= =?us-ascii?Q?pnw6deEXBqANWios4hIhn/j/uOzK2ebfuuP70BcqE+I2lYn0BiUxiOQUH+SS?= =?us-ascii?Q?qTqwHL3VZb5OkAMblwQiO58w5dE9BYWG1AcXSOC/0U+rMQ167tFEVzCsMl2c?= =?us-ascii?Q?Q9lKPDSuv6PLfJiNsZSAOzv3floZssHaJaNg0pLbEuUIsNATXAZvZMC0X/nS?= =?us-ascii?Q?dPeQcQohmZHsjjRPA6waMDlO/+GBoOywMjWVRMYPwOP6F+mEAtYL7lJj4gZE?= =?us-ascii?Q?+Hs0zBx0C44SwQZ5iSlJjM+R5f4R6k32XNhl++Rsrn5OHX6IOcD2Dto0d2Ql?= =?us-ascii?Q?IXeii0GyT5STGkMgJAV+g0X/F+I8aa1QMH67U3XXEm549edvpRgsPZdL/Y2v?= =?us-ascii?Q?62E/ndK31bjSiBKv5EE2k1sAUU12SmTKidRPHplgj0GNl+1D+veKPjCtZRlJ?= =?us-ascii?Q?vtqjSSE/ab1T2eidnxZMToO6feWJ7y3PZrktI1ihwT42CwO5x2dM6tKl8WGA?= =?us-ascii?Q?04Gs9sPJ4fyQF3s/uojqfKpTHJa+GbZosMCmTzT05meJ6ut9ZkW5hgQCp89s?= =?us-ascii?Q?tO3cyUQNaQVms81dww90HeAgqmoT1YKmEUFmvXZAkjh8BkKPkNMrnrQsUTvb?= =?us-ascii?Q?LSM0Qkv2+6yT80bRtHfTGH1ErDcQPQ8xtN9J3ijsU3+WshehwlVza/3zcuMe?= =?us-ascii?Q?paha8YhImvkpnHxI9nJFjblS8szrbf2xeBsvc0yB7vbq0xlDWC7SXRVA2Ho/?= =?us-ascii?Q?lcFh4mXQsEoljdy+6U2oftY67vPgSfwt2sKC5C+5YgqD9Tuzx+KehQunVlFI?= =?us-ascii?Q?XQ4GC0Y+rdYm8iG5Sw9/KALO?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6961133c-965f-4efe-1fd4-08d8e94a76f4 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 13:42:10.6416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NohjA6T9zVgAmd9QK+HG/yofgX25tRhrTL1oB6nry7jvyclCJcNaVCkxSoPncGdLTw3NgeTS8BcFCTgOUHM/bw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4211 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170102 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 adultscore=0 spamscore=0 clxscore=1015 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170102 ..snip.. > int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) > { ..snip.. > /* > * Allocate and initialize the free list array. This array is used > * to find contiguous free memory regions of size up to IO_TLB_SEGSIZE > - * between io_tlb_start and io_tlb_end. > + * between mem->start and mem->end. > */ > - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(int)); > - io_tlb_list = memblock_alloc(alloc_size, PAGE_SIZE); > - if (!io_tlb_list) > + alloc_size = PAGE_ALIGN(mem->nslabs * sizeof(int)); > + mem->list = memblock_alloc(alloc_size, PAGE_SIZE); > + if (!mem->list) > panic("%s: Failed to allocate %zu bytes align=0x%lx\n", > __func__, alloc_size, PAGE_SIZE); > > - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(phys_addr_t)); > - io_tlb_orig_addr = memblock_alloc(alloc_size, PAGE_SIZE); > - if (!io_tlb_orig_addr) > + alloc_size = PAGE_ALIGN(mem->nslabs * sizeof(phys_addr_t)); > + mem->orig_addr = memblock_alloc(alloc_size, PAGE_SIZE); > + if (!mem->orig_addr) > panic("%s: Failed to allocate %zu bytes align=0x%lx\n", > __func__, alloc_size, PAGE_SIZE); > > - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t)); > - io_tlb_alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); > - if (!io_tlb_alloc_size) > - panic("%s: Failed to allocate %zu bytes align=0x%lx\n", > - __func__, alloc_size, PAGE_SIZE); Shouldn't this be converted to: mem->alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); if (...) Seems that it got lost in the search and replace? > - > - for (i = 0; i < io_tlb_nslabs; i++) { > - io_tlb_list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); > - io_tlb_orig_addr[i] = INVALID_PHYS_ADDR; > - io_tlb_alloc_size[i] = 0; > + for (i = 0; i < mem->nslabs; i++) { > + mem->list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); > + mem->orig_addr[i] = INVALID_PHYS_ADDR; > + mem->alloc_size[i] = 0; > } > - io_tlb_index = 0; > no_iotlb_memory = false; > > if (verbose) > swiotlb_print_info(); > > - swiotlb_set_max_segment(io_tlb_nslabs << IO_TLB_SHIFT); > + swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT); > return 0; > } > ..snip.. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 13:46:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 13:46:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98706.187379 (Exim 4.92) (envelope-from ) id 1lMWUt-0007rx-CR; Wed, 17 Mar 2021 13:46:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98706.187379; Wed, 17 Mar 2021 13:46:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMWUt-0007rq-8P; Wed, 17 Mar 2021 13:46:03 +0000 Received: by outflank-mailman (input) for mailman id 98706; Wed, 17 Mar 2021 13:46:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMWUr-0007rS-EP for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 13:46:01 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e61311af-6f35-42dc-bdbf-b3ef6e23a502; Wed, 17 Mar 2021 13:46:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e61311af-6f35-42dc-bdbf-b3ef6e23a502 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615988760; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=0YzWHjNAnPhWN9Kh6JB5HhheT9rg02M3FcBUziUqsNk=; b=CBSnCRPbHYzoJizg1AuRBjCUq65462ryyEJpoAdg96cGvg5VQD3Vrtuv bBQ67QMBcwldbePCNa0bYAoQYtk1qdb1BhRKWP6AMKWXbJP6dphvt6iwH 7eSv5DVJYHr+lyGH5uJx6y7BmevdtN9Tfv/8g4+wGK5RtgK8KxQT7LuA2 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ZVlHBufiYEkPiZFnMEELk08j0xve2b3z+pdjV+YQp7BPTcOEcRRIMZCx2UPVTs9GA5Jctl/Pg5 WgPc75VQi5CLuClDJAwyUjVCMMijqPKh41ji+Ke7lGknSdVaQV11g3eaLhEhu0t+kKBZOr4GJH h9qA+P96WdYSsCZnrN5K64VLygP5QjgbGWAg56uCYFiAQePwTO6QH0Jt40SDIpQEMI2Ui4K6UK YW95NcAHHJEOn/x1+aWve2r4v0/Jju4ECxpm9ZkKjsD6p5Ce9SSlEKyDOTynGZapf0nn+ayqyj hTI= X-SBRS: 5.2 X-MesageID: 39388489 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:G0Ykv6pB7WYLrzwkKhd/NDMaV5trKNV00zAX/kB9WHVpW+SivY SHgOkb2RjoiDwYRXEnnpS6NLOdRG7HnKQV3aA4Bp3neAX9omOnIMVZ7YXkyyD9ACGWzIBg/I 9aWexFBNX0ZGIUse/T6gO1Cstl5dGB/ryhi+u29QYTcShBQchbnmBEIyycFVB7QxQDIJI/Go aV6MYvnUvfRV08aMOnCn4ZG9XSvtGjruOpXTcqJT4CrDOPgzSh9aLgH3Gjvis2fjtTzd4ZgB P4uiPj4KHLiYDf9jb90Cvp441SiJ/dzLJ4dbCxo+w0DhmptQqyfoRmXNS5zXEIicWi8kwjnt WJgzpIBbUI11rrcmu4oQTg1mDbuV5FhhOSqi77vVLZrcP0Xz48AcZa7LgpDyfx0EY8oMp6lJ tCwmPxjfFqJCndlyfw7cWgbWANqmOIoGEvmeNWr3tTXZp2Us4okaUj/VhYGJpFISTi6IpPKp gWMOjg4p9tADenRkGcklhE5fSNelgJWjOqBmIlneO0/VFt7SpE5npd4PZasmYL9Zo7RZUBzf /DKL5UmLZHSdJTRb5hBc8aKPHHSlDlcFbpCia/MF7nHKYINzbmsJjs+og44+msZdgh0IYyop LcS1lV3FRCOH7GOImr5tlm4xrNSGKyUXDG0cdF/aV0vbX6Wf7NPTCcTkst1++tue8WDMGee/ vbAuMVP9bTaU/VXapZ1Qz3XJdfbVMEVtcOh9o9U1WS5s3RLInnsfHabebTKLLhHS1MYBK6Pl IzGBzIYOlQ5EGiXXH1xDLLXWn2R0D59ZVsVKjWltJjj7QlB8lpiEw4mF657saEJXlpqaotZn ZzJ7vhj+e+rWmy9mDY8nVxNnNmfwBoyYSld0kPiR4BMkvyf7pGkc6YY3pu0HyOIQI6SdjXHg 5Zr1F+4rm2MJSU2CAnB7ucQyenpkpWgEjPY4YXm6WF68ugUIg/FIwaVKt4EhiOCwZ4gh9wqG BIaBYNQ0jWEj+Gs9T9sLUkQMXkM/VsigaiJsBZ7U/FvUKHvMc1Wz8wRDi1S/Oahg4oWhtZjl B86LUknbKFgDqjQFFP2NgQARlpUiC3CKgDJBmZbI9U84qbCT1YfCOvv3imrD0dPkDt7F4fg2 T9Kzb8Q4C6PnNt/lZC0qjr91tocH66ZEwYUAEgjaRNUW7CvGp/lfWGbLap03aAA2Fyl901AX XOZD0PL0d1y9qqzx6JiHKuFXsr3IhGBJ2OMJ0TN7vX3G+hbJeFn70cH+JFuLJsNNXnqeULUf 33QX7LEBrIT+kt3RCZ4mwoMjVuqGQ11dfh2Bjs92K43GEjEePfSW4WGY0zEpWX6m75SrKT3J 9kltIpra+OMn7scMSNwaa/VU8TFjrj5WSySf0k7YpZt74otKZiW5PcVjzF3mwv5mRsEO7E0E kaRrh3pKrMMJN1f9EDPy9Y5FAtnNSKIFBDiH2nPsYOOVspiWPXe8mE6abSqac+RlaMrgvoOV WZ7kRmjqv4dhrG37sdF691O2hddFM99WQn5u+EeoHKYT/aKt1r9EamM3O7bb9WQLWEH7JVtR ph/9SUhYasBlnF8RGVsj1hLq1U9WG7Bcu0HQKXAOZNt8e3IFKWn8KRkYOOpSayTTuwcEIDg4 JZMUQWc8RYkzEn5bdHmRSaW+jyokg/lUFZ7iwinlnx2pK+6GOeGU1dKwXWjtFXWjZUW0L4x/ jt4Kyd1H7n5iJC1oSGHEBMfstWE9xVV5PpNU5VWL4tla/t+7BqjjVIYR8oAWJ5gDfh3/l+1b P83PnJQeXtBXrhJFppw08IOqdk2igw7W1Qecm36pywJh8aEeMFGPMz7IFbmjABkCm603QMKx F28gA43IDEKVLqe2lmHa/1hI3snVwWorOB51AGngQepnq3zFWH/177kMa+tyBq8ynTrgp7pb 6cQzV0iiBDrQJjybFgNH3IUWOEewLwDHrniK8zfXtiAiQzzu9uihzJJawCjIq/wGppti5TOF l4/5i7UmLEDSyPHtjxJi2wHNu7ANRuc+9cU1BzWkKeJVDBgNAsVRrGd9dqywW0lnoPDaaIPL m6YAj1Nuh7wIUAf6r2Q4Cfgs/S1g9Ws3EKxriL+0C4oA== X-IronPort-AV: E=Sophos;i="5.81,256,1610427600"; d="scan'208";a="39388489" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NNhWkU/888rPyhgcktrIERNeJptgOHOLszNW/nYSbPFv22sKMEW/wpBtuDiiF6fXr7IuIqcOlBqorIPPr7FDKVMP2+wiUgaQun8XuvA8Yn5P5/og0IHkrFyo8bFrPAiDpXrPk++Z8dNrfo/vUixA4a+xNW5O47DpXFKoPs4p1ThAihnE6lmJfz5favTc7rQZaFUWRxxkGvDOIdGXAc+4fOkoBIY+N1uxNwIGmSzwUNrZslocUY/D7eqCAHw5yzbhPCx9+z1EF4ZuSF7gt3HOIBVPskxizU1f1Dy1XyiK8nqkOCp8j+94BYqR7Fm92OdyAMCzsBcYpr/CH6/rTF3ISQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gy3NqsFP3OnRutrrUYLpp1kAnLMNdN/HNf9rhiY+1I0=; b=YcvTJdjwzVdayG+37+mRu7leWothMDT9rpgWUPa8Z7MlXEpMuCUE5ubcNRHnVFCVRj+t+pCrJFSamI37Htak76QclUy58+SBDz0MA901DrEoBbn8zoBBYI+KYuaUEGclogJ9xQZ7SvJY71VkKguLrRTXYK25ndPACmf+3r7cWbIMfo4e/GykzgrOIxCAOi9n9NPG6fJalNoNuVRWXDTIot1b2+PhNyIJUnOn1uxG3cmhNbJRm9xPN0pBBEuxQyawWMmmPdNSFNXHKIwZ5k/UNYuPakn60wTzkIjim7OMYxvKGBjakoRlDAsCqm4mSqlT5bO1UbT6JE0aTQVfWfe4TA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gy3NqsFP3OnRutrrUYLpp1kAnLMNdN/HNf9rhiY+1I0=; b=w/nLhwYKClRnD8PaUUhxHPWB1EwZME0XF9/g7JzjriopopXalgTMAfh0CGB8ATdFvJfRE7pWXoRx4bmhb0YYZEeO8qh9GO0eMAardPrHoowVBOp3q4RR2gK+U/Ybvbk/8dFL5QEa2P+69uLS090iQp7q+6JO4X4ALxVsQ8wGCMk= Subject: Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" To: Ian Jackson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Xen-devel , Jan Beulich , Wei Liu , Boris Ostrovsky References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> <24658.1583.601613.903527@mariner.uk.xensource.com> From: Andrew Cooper Message-ID: <4b1c13ee-f121-3379-6fb3-c0d4dbb76e48@citrix.com> Date: Wed, 17 Mar 2021 13:45:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <24658.1583.601613.903527@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0201.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::8) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a9a9172-b12f-4962-59bb-08d8e94afdd8 X-MS-TrafficTypeDiagnostic: BN7PR03MB3827: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6/jCeK9Orn8TC//fj1Jz+OdEWObmLP3JEYhG8E/P8lxJgVEBM3v9lO5C8okark7XeZuVn6OhcvMILIYW7zakKFKguUUtlIvT71/QuSxcCPHtdsVNNKlhMmENbbtgQMeuHea48W24xy3rXDa2GkLXgdJeHij71M50J2TGeWwyjvlomO1aBBPXowR0SaQzruEg7jVNU0+R3ACxQC6lC5q3RaqsKKAkv4lbg8Amnauue9XqzqC9j2cdYddZYviTVuYBTRnSM/pRILhJcpqGKSfReyv5Zv+Bx8MSwU34mi0vlSrtqCo+sqWj+I0z/ovLBeg7tlH1nUlHvbH52hUm4B6j4kqW5FTYWTtq/sESxsyKRxtTVZOe4OFslQ8cTYxJiS/VFczWtog8LbHk+G1o0pllVk2mL57NChudQnxEWr4vpSyld6xFtkooQQYf3vnQJKc2XYCjnKPFsNNFOfQ72Sepvvw6ZWmfTiBKZ+pY/qLlHSMeSbs2fqAc1ifgkYq0zyZ70dOvwRjzWAVsoPcufqCXzDUS0hCAQ0Wx1bwXAxJczMI6Cj3mY+zpxMOeGyM2CGCwy/VKMRlozmBkBpwhMPc5VSuJ9FNJn4TbvuwLNgoi3CXoFJLGIAxbEcuXFc4KTsd3ynzDQEdN4DcZmND8f/tD7A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(346002)(136003)(39860400002)(366004)(478600001)(31686004)(2906002)(66556008)(54906003)(186003)(36756003)(5660300002)(6636002)(31696002)(66946007)(66476007)(86362001)(83380400001)(316002)(6666004)(4326008)(53546011)(8936002)(26005)(6486002)(16526019)(8676002)(956004)(2616005)(110136005)(16576012)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aHVFQzNqcURjcnFZaHZHaUlob3BUS0hVRk9mcHB0SVRtYjc1cUtYQ1lUMU5o?= =?utf-8?B?cmF0NEdQSjJQUHFlS2s0TTZvYVA0K0lMMlJwVUlsc1hQanEzbUliOUJBN29W?= =?utf-8?B?SUlrUXAzYWxjaDZBTGpNV25XeFIyM0NGZXhQOHVVOUtpNU5STWdTY2QvTVZC?= =?utf-8?B?VCswOXVlci9mNjQweXNuVFdWZ2I0TlhQczRoVUh5YXp2VHhGY1QzSHBnNERt?= =?utf-8?B?VTlERk1FT0x2NG45S0F6VldJOUorb3JldE9YTGY0Z0pCeW1aSmdOcUc1V1g3?= =?utf-8?B?L1RMTThKZmo0YUFCcjJpaUNCZDZlaUJPRzRXMXVXNFRMbFlnODRCWU1Kby9l?= =?utf-8?B?VkVaYmppRnZXSDZMaytFSnNiVGpzdTIwMkdJZWpPcVlLaVJadnAwTDlWT3A3?= =?utf-8?B?NzZGZEhuUFVGYnM1QjVwbUp3KzRkTUNGQkh1dFV1cERRK2oyWndwZVk5QUYw?= =?utf-8?B?dk5uSmNoMmh6NHVaeTN6SEc1eXY3c1phTEl1ZmZPMmlEcmtzVjFZOFNMQ2Iv?= =?utf-8?B?S2JadUkyenRiVXl3amIxVGxJaDBYNlN3SS91MkVQTFhEVjljM2dGLzczMVNt?= =?utf-8?B?R1RGaHFHbVg1UDNLak96SlJ3a2JCemhsM01QcVk4WU9qOXBIakNQdWRWdlI1?= =?utf-8?B?YVdPZWY1S1pKVFdYZERTTnJvWEdDRnhvZHZSSGV6NG1MMU5wbUNHSU1ScGQz?= =?utf-8?B?TnVGL2o5K1RaR3BwVTBnSFBNS056SjB1YWRXSUd3MFFoS2svQzhRUGttQ2xj?= =?utf-8?B?Nmc3SzhER2lxSW9FMHNYblBaVkVqd05OaFdhZEJqc2VyN2RrY0Vsek1KTTV2?= =?utf-8?B?aEJoUTQ3b3ErL0hhVUhMQitiTDgxbUU5N01reXlzLytrRi95QUM0Z1plM0dS?= =?utf-8?B?dEdPUjkrVTZ5SkRYSGNOYmJoYjJ2MkczM1RVU1lIakRQRk9DMXlSNmIwdE40?= =?utf-8?B?aFBVVzBBR2VHK2Fjc0hQZFEyYWtNWlh1SEZHV256MU8yNTM0NEpmaHF5T3Zq?= =?utf-8?B?dzZpaXNvbHZJbWlpZ0FmUVkvSldadkw2dTh3amhodFdKaFhIUkRxZldoQkJn?= =?utf-8?B?anZqZDdOWGx1bDEyTlMvdTl3UXR4d3p5cXAyU1UxVnVjVHFJbExXcVk4dDY5?= =?utf-8?B?YUE1RTY0clducTJRK1lDUmIvNSt5Z3hNcmh2ZDBQejJmVTRmMy93dFRMdFI0?= =?utf-8?B?emliU1owUDhKcXBQRVg3SzB3ZkFlczJWMUVTaW95SEJGZjNJcTdQa1FaK0Fz?= =?utf-8?B?NFRpYnlKQUJXaXlsZnNCMGFBdlV4NTROMnN0VHZLYkVySDJkUHRGZk5DTUZR?= =?utf-8?B?YWhEbjFDbFZuUlpmZDJHaEtsT0FFV0NPTSsxd09ZSFpVdGtjZXJlV3pXZSt0?= =?utf-8?B?THVtWThuOGZSTnZ2NDh4WThDQmtLR0QyckFrY01pWC90Zm1iSzR1NklNZnJP?= =?utf-8?B?M2lLUGdGL2RvUnV0Nm1IS2g1MXUycGVxa01nT25oNU5nWkpNSWRGZUlndGN0?= =?utf-8?B?eTUrVnhBRmVVUzEwaldZOTFWaEpIUDFrMnpOYk8vVm5kVDRacVB6MXhEMnZR?= =?utf-8?B?OUxqNGdTTmNmWnQyVmlhTFRZemd1RlRUNUZUd2dxRjdwa3lzMzZIRndkNWNH?= =?utf-8?B?bXlvYnRQQUNmOWpUSy9tT2RDR0M3cFdiVXgxaGM2SjdVZDIrUWJxTktyTG9W?= =?utf-8?B?RTdjZlNZU0RWZ08za3kvNCszQ2IrTGN5WEMrWE9LaE5WODJZbjZxc2JSTUlW?= =?utf-8?Q?wM0UP5WWFTCXwossY9IXa8o2cveWmEq4ewB5LY2?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1a9a9172-b12f-4962-59bb-08d8e94afdd8 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 13:45:57.1019 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1Xfc+18DJcoRs/iEzTp+12/QXjkKOULtHbjamaZh+D9lwhAdpzSTbgvrlkDOFPh6JT26QO4OvywYQxy0bIL7ZGylsChzVVLI4oUen/5wgrE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3827 X-OriginatorOrg: citrix.com On 17/03/2021 13:37, Ian Jackson wrote: > I have read this thread and with my release manager hat on I feel > confused and/or ignorant. > > Patch 3/ has a good explanation of what the problem is it is > addressing and why this is important for 4.15. But then there is > Jan's most recent reply starting "I find all of this confusing". Jan, > can you please tell me in words of one syllable what the implication > of that message is ? In particular is any of what you say a reason > for me to withhold my release-ack ? > > AFAICT there is no explanation for why patches 1/ and 2/ deserve to go > into 4.15. We are late in the freeze now, so I would ideally be > looking for a clear and compelling argument. I'd also like to > understand what the risks are of taking these. Can someone please > enlighten me ? To make the code in 4.15 match 4.14, so patch 3 can be written in the first place. Also, as a side benefit, patches 1 and 2 reduce the quantity of logspew from the impacted MSRs. We cannot simply take patch 3 as-is, and say "4.14 and earlier" for backport, because that still forces end users to specify msr_relaxed to unbreak their Solaris guests, which is usability regression vs 4.14 ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Mar 17 13:53:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 13:53:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98710.187391 (Exim 4.92) (envelope-from ) id 1lMWcB-0000Ou-2P; Wed, 17 Mar 2021 13:53:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98710.187391; Wed, 17 Mar 2021 13:53:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMWcA-0000On-VN; Wed, 17 Mar 2021 13:53:34 +0000 Received: by outflank-mailman (input) for mailman id 98710; Wed, 17 Mar 2021 13:53:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMWc9-0000Oh-HD for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 13:53:33 +0000 Received: from verein.lst.de (unknown [213.95.11.211]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 68aeecdd-82e1-4cbf-9ec1-d43e61e727dd; Wed, 17 Mar 2021 13:53:32 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id C896B68BFE; Wed, 17 Mar 2021 14:53:27 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68aeecdd-82e1-4cbf-9ec1-d43e61e727dd Date: Wed, 17 Mar 2021 14:53:27 +0100 From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Christoph Hellwig , Michael Ellerman , iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Claire Chang , linuxppc-dev@lists.ozlabs.org, Dongli Zhang Subject: Re: [PATCH 12/14] swiotlb: move global variables into a new io_tlb_mem structure Message-ID: <20210317135327.GA10797@lst.de> References: <20210301074436.919889-1-hch@lst.de> <20210301074436.919889-13-hch@lst.de> <20210317134204.GA315788@konrad-char-us-oracle-com.allregionaliads.osdevelopmeniad.oraclevcn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210317134204.GA315788@konrad-char-us-oracle-com.allregionaliads.osdevelopmeniad.oraclevcn.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Mar 17, 2021 at 01:42:07PM +0000, Konrad Rzeszutek Wilk wrote: > > - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t)); > > - io_tlb_alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); > > - if (!io_tlb_alloc_size) > > - panic("%s: Failed to allocate %zu bytes align=0x%lx\n", > > - __func__, alloc_size, PAGE_SIZE); > > Shouldn't this be converted to: > mem->alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); > if (...) > > Seems that it got lost in the search and replace? Yes, I messed that up during the rebase. That being said it magically gets fixed in the next patch.. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 14:05:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 14:05:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98716.187403 (Exim 4.92) (envelope-from ) id 1lMWnA-0001Tt-83; Wed, 17 Mar 2021 14:04:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98716.187403; Wed, 17 Mar 2021 14:04:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMWnA-0001Tm-4y; Wed, 17 Mar 2021 14:04:56 +0000 Received: by outflank-mailman (input) for mailman id 98716; Wed, 17 Mar 2021 14:04:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMWn8-0001Td-CN for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 14:04:54 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown [40.107.6.64]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7e187e55-a485-4a2a-bed9-76e15e49629f; Wed, 17 Mar 2021 14:04:52 +0000 (UTC) Received: from DB6PR07CA0111.eurprd07.prod.outlook.com (2603:10a6:6:2c::25) by AM6PR08MB3317.eurprd08.prod.outlook.com (2603:10a6:209:42::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Wed, 17 Mar 2021 14:04:50 +0000 Received: from DB5EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::a2) by DB6PR07CA0111.outlook.office365.com (2603:10a6:6:2c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.9 via Frontend Transport; Wed, 17 Mar 2021 14:04:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT048.mail.protection.outlook.com (10.152.21.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Wed, 17 Mar 2021 14:04:49 +0000 Received: ("Tessian outbound eae0c21066a4:v87"); Wed, 17 Mar 2021 14:04:49 +0000 Received: from 4fb79844b01e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F2C75CD0-BAA9-4ED4-808B-596C4E615D53.1; Wed, 17 Mar 2021 14:04:43 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4fb79844b01e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 17 Mar 2021 14:04:43 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VE1PR08MB4813.eurprd08.prod.outlook.com (2603:10a6:802:ae::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Wed, 17 Mar 2021 14:04:42 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3933.032; Wed, 17 Mar 2021 14:04:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e187e55-a485-4a2a-bed9-76e15e49629f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U7ti9llXCWTFMe6QSQtdT4PxC4YV4LOHHo6FuekhJxo=; b=kZHL82Y6Aq5ctnedH6OLmSuOXz0MjO2nMNEtiCYOe1f67RGzThZ6yyT7Ie7o6Wf+JNgxh0fwuxv2JgpLYdhUq6ngFI1imlUC3i0Ylr1e3g8Zew/efoTuoYgipX36n1kMbtaokQtuERQMew9FVaYYAYW9p6yfCUiWGPulCfnEDRM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: ed504178a1f7e50c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VC3BH7VoHY8O2ElunVhyGHr4HQdvk/7eOEuuZQvQJuW4SMptaPpovvkAUSU7Tkwhf7Vj8xIlWT9XxnMlpOqZlV2jAbu/O0rrEmnjluPih2GgjuiAjMf9IGUngILCIgFZA6RSre2ZIBlqxwLNxyEnoP7srk9t2ift2tlHyCsdg3rw6w5upo3wY4L2eLXk+o2JIkOYfeFfoDmfV5o/+9DbzwN1vPOc7t6EPG2Te8M1sVl+osX+v4fDknmRU40T5xGONdbVyz3y7kzaq+1V2NZJZZj9f9OxYs980uFd+9nLKoqCD9AHNhQGLq34Ct/BM5/jjyuOVrkOtQmruvzoyk0Dgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U7ti9llXCWTFMe6QSQtdT4PxC4YV4LOHHo6FuekhJxo=; b=cmZoKBUql/0i+fodMQkjEF+h1h0fpbQnqO8BnNEP+Yv9l+eNtJWihCKhXzim6J2Sk6XLZaWe9n2kaiaXhSReLKrTpJHoRWRKelbmmBXfzWmqld4y5SUWzVVbO04IDdOzHQ/goZvtV4o4tS3fHZue4UZ981usrzuM5SXb87n/jIbIg6fF05DsFZ3o6sTiXHz+dRAoCHWA2JUSOgLzmW59svXMxQCeRYngp0hwvrdugKAYWtOWsTfRixFM2Q4+hDSiO5elF2AsKulx4xfgazAkw34QrNgLPXNrDAlNgpMt/m6xoskNikOjrD65Vu3pjNN7rVz6jZKWBhO6tcA8ZA1krA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U7ti9llXCWTFMe6QSQtdT4PxC4YV4LOHHo6FuekhJxo=; b=kZHL82Y6Aq5ctnedH6OLmSuOXz0MjO2nMNEtiCYOe1f67RGzThZ6yyT7Ie7o6Wf+JNgxh0fwuxv2JgpLYdhUq6ngFI1imlUC3i0Ylr1e3g8Zew/efoTuoYgipX36n1kMbtaokQtuERQMew9FVaYYAYW9p6yfCUiWGPulCfnEDRM= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH for-next v2 0/2] xen/arm: Mitigate straight-line speculation Thread-Topic: [PATCH for-next v2 0/2] xen/arm: Mitigate straight-line speculation Thread-Index: AQHXGCLVbl4hty1bX0WFvkxXr3KxFaqFDwwAgAGybICAAB5+gIABLumAgAAtzoA= Date: Wed, 17 Mar 2021 14:04:42 +0000 Message-ID: <8E74D116-C7CC-42C3-AE70-A780F43AB1BB@arm.com> References: <20210313160611.18665-1-julien@xen.org> <119bdbc0-5400-87eb-e6ad-87b59ec4e07c@xen.org> <4066B6A3-2904-4800-B63A-7EAD1EFC7D16@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.26.33.241] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 91d16442-2623-4414-207f-08d8e94da11e x-ms-traffictypediagnostic: VE1PR08MB4813:|AM6PR08MB3317: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jsJ4j//1Pxo20DdWub6O1UAvPuCwqNu7PoqiUr/z52iwlehEcbpqyWsyqQHQ92OB8/IEIUDQcireUePqCmMJZt4ZNXR7Fke7N9/YNoku9sCujrXOe+NjKl612QFmN998GJ0UwShEZszv3YKekWXLFLebnTpRPYEiLsIzFAujAedS4Q8pqCSFtLg/2hcMAtKEoBnYrJ3YqQslLchxPR6FJaqXvED+sy9M06AyHXGMDVIXIXK1lKJ6Rp6aq0W65O0HgMnboUS3VBMSF2iN/F2QHzjPaWnwLu735F+xS1BdD/owmAZoamjvjzakjBEXGmD/TjIFFQnRqToFAIQ7/cVTwASxtb1CbMk6HpnvJm5ic+0wQpu4ec/lIM4gjviz2hYI5FQHDFpOkINGNxWsmT0kI4q809K9x3suysQ0kiWJzevLc6bKhx/FTfaebB4Vk9JaKmrAQaX0b9ODO9NI48L8jJNGFIRQ/Ht3Y4oZjWAi0kpsjSY5dHt0xw34OIwzmm9NqYho7+f64Ke9ifvS+jAXIOp+4EfmNqWr/tEbyv8ZHsRGJ5GJg5xAM7FE2eP1XTbzwCXqbtM+QvksEmleoUCf7XEJw1HEyaJd/TF4rU0Wr7kjGtb/7sf9l+Xjeoyfj/lFJcGTQXE3wQxJtepN19/X4Wjm6SJGU06Ih73v9ELKFnqXsWszOdevt4k1NH3HNc2ZI0zDlFFyOsFks0lPzfLmS93UPLd4KJEEE737IWHTBbw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(366004)(346002)(39860400002)(136003)(966005)(26005)(6916009)(5660300002)(8936002)(53546011)(54906003)(36756003)(8676002)(186003)(2616005)(316002)(66446008)(2906002)(64756008)(4326008)(6486002)(6512007)(83380400001)(478600001)(33656002)(55236004)(86362001)(6506007)(76116006)(66556008)(91956017)(71200400001)(66476007)(66946007)(2004002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?OW50RHJ0SFB2MGpFa0FqUEUrNmxOWUUySEZWRUJlR1JOb2RCZlhWbmtERFhu?= =?utf-8?B?WVZUWFZnTzIxR1pURzl1amtCRVBDdUU5YkdweU5CRFQweC9pS1owOVQ5UmVa?= =?utf-8?B?eUZNbDhsUjdDRVJQV0x6cW04ZWt6K1FtSksrdWtJeW5uZDlycTluS2NPRmM5?= =?utf-8?B?UzJRM0Jjd0UzYlR2aDNhMUljM0N4NCtHbUdueXFSQVVPKzVkTnB5bytQa3dB?= =?utf-8?B?OENieENBUDAxWTJrbmpLM1JRbXNnK1g4L1BWZmlhN3hUZzhpT01WNnZkSHZo?= =?utf-8?B?akdEendsNUpnQ1UvSmRlL01sRkttK1dtaFloVmZKZjRsMFNWWGI5bytjMGlj?= =?utf-8?B?SHNSQW5nc2RCYUxDQkdxTXNQZWRpcjlsZnVnTUkycFJZTlBablM5OGt2UXg2?= =?utf-8?B?YUVRbStmL3oxVDN0R21vYklaOVRyKzFFK1dPWkhEM21pWm0yek1IM3JkS1dH?= =?utf-8?B?VVdZRDNOWXBibFI3STU5bW1vYy9vSlVxMklOZkRKNDU5WnpWcUJ4ZDIzeW1u?= =?utf-8?B?K202LzJuUFUxWjhvV3oycEcwZ0l1K2o4S1hmb2p5MkZVSzd4TEFkb1NCWno3?= =?utf-8?B?VTlva2p1bms0WVZvYktWbEgrRkZvSHE0Q2gzdmhuaFdITVRMYy9mMjNJaWlV?= =?utf-8?B?bkxVQ09pTlNiMzRGQ0h1cHNLTG04OTFZQTRMcEVXQzFBVWVuUmdYSGJGa1A5?= =?utf-8?B?aHJabkdKdlhNTTBiWDVQSmVLZ2ltTVIxV01kVVZvRTU3aERGT0l6bEo1L0lH?= =?utf-8?B?UXFlWFBDZGZsNndlT3J5ZzBaMkdFK1FmbzB2S0gxSk1tWDNHbVRHSWFDbS9k?= =?utf-8?B?bDdNTWd4Qm1kR3JtZldhMERSejhEQkJXS0pGOHhIQ0l6bDZla1NzRFNQN0l6?= =?utf-8?B?WkdNZVBkbGhhNFAwZG5yWGQzR3FIOHQrVGlPQmZTcWRCRDV1YWFrS2VtZHFs?= =?utf-8?B?T2FDRzBuVkxxd1BPeE9vMHJiazh0dFBKaW1pNytXWTVXSmp3VGVTZ1p4UGNS?= =?utf-8?B?a3NUU1VCU1l0S1dtYUoybzRPd3l2VWJDd1ZUSzY4cWY5L1R0RVc5L3dmcnhX?= =?utf-8?B?VExUQURFZUxCMFo3WWpHM05oMjI2OVN2bWtrTm0yYXlybVlVK2g1NGVZTWEr?= =?utf-8?B?WU9DcDJzOEVzQmEzTkpka3paUFpZTlB6MUd6alFKZ1h5Y21qSThkMHM4UERL?= =?utf-8?B?eVdIYkhVb1V5S2Njc2ZvYVlyVkw2L1VWeTFFK2ZNM3pxOGpNUzluZHRXL2hy?= =?utf-8?B?c2tpa0xjTzBYVmllUFc1MkQzUjFFaUdoSnRkZElPVXVqVzhUUnk3eHhvTmJY?= =?utf-8?B?YUQ5d0ExWFVWeTRsT1RwQVdpVWpkOFNncE5VbXdDdXN2ZFpzK1gweUxYYWw5?= =?utf-8?B?UGJRWlVidkx5M1gxaEsrcWJZQ0xVeUFUU3FXVUl1ZlZYV3BGeXNFdnh3dkp1?= =?utf-8?B?VGJDVVY0NndUSUZGUjYwOWJSc2JUZWxoS2F5ZTN0RGVhdTdmS2tnU2oydWRD?= =?utf-8?B?YnFuTElWMXFBWk1RTGhwVzdFa04rTTBNUHZ4RU1mUnowczQ0VGh5RDR3cmdZ?= =?utf-8?B?eXFDb3lIcE16RWl0OFl5QllxM25JeDNZOVp2TVo1bzNNTFhxUzZFL2pQYmFC?= =?utf-8?B?a2orRWxEejBUK1RjQWxzRkliNjYySFdRdGQrMDVkUHp5NXgxeWkvZUROZlEr?= =?utf-8?B?U2kwTWg1dzJsQ0djWWVCd3BNQmV5TE1iV1ZqSmllaFJWc1k4M0JWWDVXQWRu?= =?utf-8?Q?Sc3CQXNvZSck3ETCOvbeZTuko6x91EjD6EEYvZ/?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4813 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: fab80550-1123-4c98-ab61-08d8e94d9c8f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2KP5aaqEhDGgcm6/PTvJQWxDLyL2Xc+7FU7rhaKIULNzoB0l272f/zH/tfh6kR0mN6OzBiApCXYPIRpNQolm2xPfDw7GB7DinLysJosbAfMZ8moKH1qUlTjQM8OKmPPDb4k+seS+fooyB7+jN4XpwuhISL5w/xrATyoyrrnPTmBoPNR3n/NF/35aAEJ2EFTMY8uk2yrnXkG3HJ0UdyJRbP8nNGMcGxl1/uRX6Ne4L6DYx5zKq1mpEa1UEKwg4vI8UY0k+u8WSt/mBTJJg7KOZfl9g3qoLcT5J8/4Rjj9zCZobSI4QCGCBiOet0aNT3jEi2d9MQ13Eyu3r3tTR+IcxfFffWff/A13uEKHHRR+XbAuwi9gaFzYUugS7Y960Mq/pIv+ANuw3hmZ1+KruEcKnI16yG7kUaK1AkMaL2dMGcD30ixNOpJDVWw5WYUr4X2wFZFfdPJNzNdUeCe2u8eEzjVoIXly49gqagXHW+xIvuwcLdpCepxsqqAOgDmE0xi8v3mRlWbbHDS/9iYxGyeqed3cvnWEW/V17VsF/sZsND13POChEfcINJqToutOuvEEPQxopKs16dLnJ8Ytc/p4AGzk2vj13o84oRPq9koinVvCoQkKlB3e9mIhrWONcRT+G+g1LRz3PvMeBNIFMOqV0P1RAzweB4ZyhdboHcPts5p9SWZdhZVTSI+zVyLjE9XT+kGAP1K1Kzc795fc+UbYp8sb3UTya5M2MJa0FTvTYWEYz71bB3EFZLW9i+yuYH4U X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(39860400002)(346002)(376002)(136003)(46966006)(36840700001)(6512007)(53546011)(2616005)(82740400003)(107886003)(6506007)(6486002)(36860700001)(8676002)(186003)(8936002)(36756003)(4326008)(2906002)(81166007)(478600001)(70586007)(86362001)(316002)(966005)(83380400001)(5660300002)(55236004)(26005)(33656002)(70206006)(82310400003)(336012)(356005)(47076005)(54906003)(6862004)(2004002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 14:04:49.7695 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91d16442-2623-4414-207f-08d8e94da11e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3317 SGkgSnVsaWVuLA0KDQo+IE9uIDE3IE1hciAyMDIxLCBhdCAxMToyMCwgSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiANCj4gDQo+IE9uIDE2LzAzLzIwMjEgMTc6MTYs IEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+PiBIaSBKdWxpZW4sDQo+IA0KPiBIaSBCZXJ0cmFu ZCwNCj4gDQo+Pj4gT24gMTYgTWFyIDIwMjEsIGF0IDE1OjI3LCBKdWxpZW4gR3JhbGwgPGp1bGll bkB4ZW4ub3JnPiB3cm90ZToNCj4+PiANCj4+PiANCj4+PiANCj4+PiBPbiAxNS8wMy8yMDIxIDEz OjMyLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+PiBIaSBKdWxpZW4sDQo+Pj4gDQo+Pj4g SGkgQmVydHJhbmQsDQo+Pj4gDQo+Pj4+PiBPbiAxMyBNYXIgMjAyMSwgYXQgMTY6MDYsIEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+Pj4gDQo+Pj4+PiBGcm9tOiBKdWxp ZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KPj4+Pj4gDQo+Pj4+PiBIaSBhbGwsDQo+Pj4+ PiANCj4+Pj4+IExhc3QgeWVhciwgQXJtIHJlbGVhc2VkIGEgd2hpdGVwYXBlciBhYm91dCBhIG5l dyBjYXRlZ29yeSBvZiBzcGVjdWxhdGlvbi4NCj4+Pj4+IChzZWUgWzFdIGFuZCBbMl0pLiBJbiBz aG9ydCwgYSBwcm9jZXNzb3IgbWF5IGJlIGFibGUgdG8gc3BlY3VsYXRlIHBhc3QNCj4+Pj4+IHNv bWUgb2YgdGhlIHVuY29uZGl0aW9uYWwgY29udHJvbCBmbG93IGluc3RydWN0aW9ucyAoZS5nIGVy ZXQsIHNtYywgYnIpLg0KPj4+Pj4gDQo+Pj4+PiBJbiBzb21lIG9mIHRoZSBjYXNlcywgdGhlIHJl Z2lzdGVycyB3aWxsIGNvbnRhaW4gdmFsdWVzIGNvbnRyb2xsZWQgYnkNCj4+Pj4+IHRoZSBndWVz dC4gV2hpbGUgdGhlcmUgaXMgbm8ga25vd24gZ2FkZ2V0IGFmdGVyd2FyZHMsIHdlIHN0aWxsIHdh bnQgdG8NCj4+Pj4+IHByZXZlbnQgYW55IGxlYWthZ2UgaW4gdGhlIGZ1dHVyZS4NCj4+Pj4+IA0K Pj4+Pj4gVGhlIG1pdGlnYXRpb24gaXMgcGxhbm5lZCBpbiB0d28gcGFydHM6DQo+Pj4+PiAgIDEp IEFybSBwcm92aWRlZCBwYXRjaGVzIGZvciBib3RoIEdDQyBhbmQgTExWTSB0byBhZGQgc3BlY3Vs YXRpb24gYmFycmllcg0KPj4+Pj4gICBhbmQgcmVtb3ZlIHByb2JsZW1hdGljIGNvZGUgc2VxdWVu Y2UuDQo+Pj4+PiAgIDIpIEluc3BlY3Rpb24gb2YgYXNzZW1ibHkgY29kZSBhbmQgY2FsbCB0byBo aWdoZXIgbGV2ZWwgKGUuZyBzbWMgaW4gb3VyIGNhc2UpLg0KPj4+Pj4gDQo+Pj4+PiBJIHN0aWxs IGhhdmVuJ3QgbG9va2VkIGF0IDEpIGFuZCBob3cgdG8gbWl0aWdhdGUgcHJvcGVybHkgQXJtMzIg KHNlZQ0KPj4+Pj4gcGF0Y2ggIzEpIGFuZCBTTUMgY2FsbC4gU28gdGhpcyBpc3N1ZSBpcyBub3Qg ZnVsbHkgYWRkcmVzc2VkLg0KPj4+Pj4gDQo+Pj4+PiBOb3RlIHRoYXQgdGhlIEVSRVQgaW5zdHJ1 Y3Rpb24gd2FzIGFscmVhZHkgYWRkcmVzc2VkIGFzIHBhcnQgb2YgWFNBLTMxMi4NCj4+Pj4gT24g bXkgdGVzdHMsIHRoaXMgc2VyaWUgaXMgYnJlYWtpbmcgdGhlIGFybTY0IGJ1aWxkOg0KPj4+PiB8 IGFhcmNoNjQtcG9reS1saW51eC1sZCAtLXN5c3Jvb3Q9L2hvbWUvYmVybWFyMDEvRGV2ZWxvcG1l bnQveGVuLWRldi9idWlsZC9wcm9maWxlLWZ2cC1iYXNlLnByai90bXAvd29yay9mdnBfYmFzZS1w b2t5LWxpbnV4L3hlbi80LjE1K2dpdDEtcjAvcmVjaXBlLXN5c3Jvb3QgICAgICAgICAtRUwgIC0t Zml4LWNvcnRleC1hNTMtODQzNDE5IC0tZml4LWNvcnRleC1hNTMtODQzNDE5IC1yIC1vIGJ1aWx0 X2luLm8gbWVtY3B5Lm8gbWVtY21wLm8gbWVtbW92ZS5vIG1lbXNldC5vIG1lbWNoci5vIGNsZWFy X3BhZ2UubyBiaXRvcHMubyBmaW5kX25leHRfYml0Lm8gc3RyY2hyLm8gc3RyY21wLm8gc3RybGVu Lm8gc3RybmNtcC5vIHN0cm5sZW4ubyBzdHJyY2hyLm8NCj4+PiANCj4+PiBJIGNhbid0IHNlZSBh bnkgYnVpbGQgZmFpbHVyZSB3aXRoIHRoZSBmb2xsb3dpbmcgR0NDOg0KPj4+IA0KPj4+IDQyc2g+ IGFhcmNoNjQtbGludXgtZ251LWdjYw0KPj4+IGFhcmNoNjQtbGludXgtZ251LWdjYyAoVWJ1bnR1 L0xpbmFybyA3LjUuMC0zdWJ1bnR1MX4xOC4wNCkgNy41LjANCj4+PiBDb3B5cmlnaHQgKEMpIDIw MTcgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuDQo+Pj4gVGhpcyBpcyBmcmVlIHNvZnR3 YXJlOyBzZWUgdGhlIHNvdXJjZSBmb3IgY29weWluZyBjb25kaXRpb25zLiAgVGhlcmUgaXMgTk8N Cj4+PiB3YXJyYW50eTsgbm90IGV2ZW4gZm9yIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZP UiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4NCj4+PiANCj4+PiBBRkFJQ1QsIHRoZXJlIGlzIGFsc28g bm8gY29tcGlsYXRpb24gaXNzdWUgcmVwb3J0ZWQgYnkgZ2l0bGFiOg0KPj4+IA0KPj4+IGh0dHBz Oi8vZ2l0bGFiLmNvbS94ZW4tcHJvamVjdC9wYXRjaGV3L3hlbi8tL3BpcGVsaW5lcy8yNjk5ODk4 OTQNCj4+PiANCj4+PiBXaGF0J3MgdGhlIHZlcnNpb24gb2YgeW91ciBjb21waWxlcj8gRG8geW91 IGhhdmUgc3RlcHMgdG8gcmVwcm9kdWNlIHlvdXIgc2V0dXA/DQo+PiBZb3UgbmVlZCB0byBoYXZl IGVhcmx5cHJpbnRrIGVuYWJsZWQNCj4+IEkgYW0gdXNpbmcgZ2NjIDcuNS4wOg0KPj4gYWFyY2g2 NC1saW51eC1nbnUtZ2NjIChVYnVudHUvTGluYXJvIDcuNS4wLTN1YnVudHUxfjE4LjA0KSA3LjUu MA0KPj4gb25lIGNvbmZpZ3VyYXRpb24gdHJpZ2dlcmluZyB0aGUgaXNzdWUgaXMgdXNpbmcgdGhl IGRlZmF1bHQgLmNvbmZpZyB3aXRoIHRoZSBmb2xsb3dpbmcgaXRlbXMgYWRkZWQ6DQo+PiBDT05G SUdfU1VQUFJFU1NfRFVQTElDQVRFX1NZTUJPTF9XQVJOSU5HUz15DQo+PiBDT05GSUdfREVCVUdf TE9DS19QUk9GSUxFPXkNCj4+IENPTkZJR19QRVJGX0NPVU5URVJTPXkNCj4+IENPTkZJR19QRVJG X0FSUkFZUz15DQo+PiBDT05GSUdfREVWSUNFX1RSRUVfREVCVUc9eQ0KPj4gQ09ORklHX0RFQlVH X1RSQUNFPXkNCj4+IENPTkZJR19FQVJMWV9QUklOVEtfSlVOTz15DQo+PiBDT05GSUdfRUFSTFlf VUFSVF9QTDAxMT15DQo+PiBDT05GSUdfRUFSTFlfUFJJTlRLPXkNCj4+IENPTkZJR19FQVJMWV9V QVJUX0JBU0VfQUREUkVTUz0weDdmZjgwMDAwDQo+PiBDT05GSUdfRUFSTFlfVUFSVF9QTDAxMV9C QVVEX1JBVEU9MTE1MjAwDQo+PiBDT05GSUdfRUFSTFlfVUFSVF9JTklUPXkNCj4+IENPTkZJR19F QVJMWV9QUklOVEtfSU5DPSJkZWJ1Zy1wbDAxMS5pbmPigJ0NCj4gDQo+IFRoYW5rcyBmb3IgcHJv dmlkaW5nIHRoZSAuY29uZmlnLiBJIG1hbmFnZWQgdG8gcmVwcm9kdWNlIGl0LiBTbyBJIHJlbW92 ZWQgImFzbV9kZWZucy5oIiBldmVyeXdoZXJlIGJ1dCBmb3Jnb3QgdG8gaW5jbHVkZSBpdCBpbiB0 aGUgImNvbmZpZy5oIiA6Ly4NCj4gDQo+IFRoaXMgc21hbGwgY2hhbmdlIGZpeGVkIHRoZSBlcnJv cjoNCj4gDQo+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20tYXJtL2NvbmZpZy5oIGIveGVu L2luY2x1ZGUvYXNtLWFybS9jb25maWcuaA0KPiBpbmRleCA1MTI3M2I5ZGIxZmMuLmM3Yjc3OTEy MDEzZSAxMDA2NDQNCj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS9jb25maWcuaA0KPiArKysg Yi94ZW4vaW5jbHVkZS9hc20tYXJtL2NvbmZpZy5oDQo+IEBAIC0xOTIsNyArMTkyLDcgQEAgZXh0 ZXJuIHVuc2lnbmVkIGxvbmcgZnJhbWV0YWJsZV92aXJ0X2VuZDsNCj4gI2RlZmluZSB3YXRjaGRv Z19lbmFibGUoKSAgKCh2b2lkKTApDQo+IA0KPiAjaWYgZGVmaW5lZChfX0FTU0VNQkxZX18pICYm ICFkZWZpbmVkKF9fTElOS0VSX18pDQo+IC0jaW5jbHVkZSA8YXNtL2FzbS1vZmZzZXRzLmg+DQo+ ICsjaW5jbHVkZSA8YXNtL2FzbV9kZWZucy5oPg0KPiAjaW5jbHVkZSA8YXNtL21hY3Jvcy5oPg0K PiAjZW5kaWYNCj4gDQo+IFdvdWxkIHlvdSBzdGlsbCBiZSBoYXBweSB0byByZXZpZXcgdGhlIHNl cmllcyBiZWZvcmUgSSBzZW5kIGEgdjM/DQoNClN1cmUsDQoNCkkgd2lsbCByZXN0YXJ0IG15IHRl c3RzIHdpdGggdGhpcyBjaGFuZ2Ugbm93IGFuZCByZXZpZXcgdGhlIHYyIG9uY2UgcGFzc2VkLg0K DQpDaGVlcnMNCkJlcnRyYW5kDQoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tIA0KPiBKdWxpZW4g R3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Wed Mar 17 14:32:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 14:32:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98721.187415 (Exim 4.92) (envelope-from ) id 1lMXE1-0004Df-Ih; Wed, 17 Mar 2021 14:32:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98721.187415; Wed, 17 Mar 2021 14:32:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXE1-0004DY-Fh; Wed, 17 Mar 2021 14:32:41 +0000 Received: by outflank-mailman (input) for mailman id 98721; Wed, 17 Mar 2021 14:32:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXE0-0004DT-V6 for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 14:32:41 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [40.107.20.70]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5e46b871-170f-427b-bd62-ff163f5c3882; Wed, 17 Mar 2021 14:32:38 +0000 (UTC) Received: from MRXP264CA0032.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:14::20) by AM0PR08MB4996.eurprd08.prod.outlook.com (2603:10a6:208:15a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Wed, 17 Mar 2021 14:32:35 +0000 Received: from VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:14:cafe::d0) by MRXP264CA0032.outlook.office365.com (2603:10a6:500:14::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Wed, 17 Mar 2021 14:32:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT056.mail.protection.outlook.com (10.152.19.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Wed, 17 Mar 2021 14:32:35 +0000 Received: ("Tessian outbound 259fb7427a57:v87"); Wed, 17 Mar 2021 14:32:34 +0000 Received: from 9157386a9c25.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D011235A-E4C7-4900-9763-1ED049FC39AB.1; Wed, 17 Mar 2021 14:32:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9157386a9c25.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 17 Mar 2021 14:32:27 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) by VE1PR08MB5728.eurprd08.prod.outlook.com (2603:10a6:800:1a0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Wed, 17 Mar 2021 14:32:26 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642]) by VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642%4]) with mapi id 15.20.3933.032; Wed, 17 Mar 2021 14:32:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e46b871-170f-427b-bd62-ff163f5c3882 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aVrl4Ub3251jU+WymCbyLkna78vFyP8vTELrcAsssrM=; b=i4HaqaETqVCtpLoIw1C9jBEBgF1r0nKp3AkEik/W9TsdV9xRhMr8ko4EyytJfZbXDlSCjNuVsQj+b9vUWZZMeWeyO803dxeFmP53LCsRB3HDbCHnrOiG0rigyP84dFyTmem7wJZg+Tg+eDWoLd2GplrjaMAM4MoS/dlTfDR+nw4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 274dfdc947c5059f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XpvSzLyOj2cVLOnQ4aUdpjarntlmNFRZHyl6IZXY9GvQBfncNO4S3l04bT65LEUW9pR/1GsodpTh1cdC8my2SQ9o+ANwukP4JYFQnXdtGnr4TCrxrJ/I7HAbbDzECiQ6eWFtn1cbb3wh304nnXCb9PYtzABASYDHtNyD1HGalRpqI/AFroQfJ4fgYOYEXARtHFIHyhPeqxlMhsjHxFpCMzXEPWFwMqxGe/43yQ+toQ5fiSHeNO1eBG3HmOUFiwFO+UnXBMESyCjs08ETA1OhGaUtyUblyUoqjZerbKV4mz+q+B41orQquZedEsdzNghqKP9Y1ZU5Lvo/al5opodX/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aVrl4Ub3251jU+WymCbyLkna78vFyP8vTELrcAsssrM=; b=QACw31/IuInIyO++bjjHouRmXIEzD+TyOm+dgSOf4btcmrIhYFhJfMd/bT56rOCdPGRzNcrbMFWUvi4pM3zk/4S/nLbllKaPY4K0q8+/1Bw/4Ie6kKfZHi0vsHi3SPc5WVR5ppyinsvlMUjyObeX4JwAdcTPyXcljf6Gxj7TKnanpNvcJh54OgMMYj5bE5FMjJ8sdKXm+BUHedg/SnaH/NyOjjTPQmgSNDbEQHdfiiLIjxr5gz3Wl2KVX1fsCjFYeQKPx1BKLgaQgl79Y7hyu16+OcA1ADHIlapxV4dmYk7ye5bzZf97iZwv1oaGBx/ivsJivoDEjrwkWu05SOu7Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aVrl4Ub3251jU+WymCbyLkna78vFyP8vTELrcAsssrM=; b=i4HaqaETqVCtpLoIw1C9jBEBgF1r0nKp3AkEik/W9TsdV9xRhMr8ko4EyytJfZbXDlSCjNuVsQj+b9vUWZZMeWeyO803dxeFmP53LCsRB3HDbCHnrOiG0rigyP84dFyTmem7wJZg+Tg+eDWoLd2GplrjaMAM4MoS/dlTfDR+nw4= From: Luca Fancellu To: "xen-devel@lists.xenproject.org" CC: Juergen Gross , "jgrall@amazon.com" Subject: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 Thread-Topic: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 Thread-Index: AQHXGzaro+yJ53YhvEak45F6mQniMqqIPN21 Date: Wed, 17 Mar 2021 14:32:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [82.8.129.65] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8ddc0296-202a-4c4b-455f-08d8e95181eb x-ms-traffictypediagnostic: VE1PR08MB5728:|AM0PR08MB4996: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sD8TwS6dVUxfEMcpi1QezXlywfI4Hy5/bXBPlFGiIC86DllGRKK66NmSEEUn5ZQAgUjoQAzFDoNsIOJg8qJl0+Te7tVuZi1WbaZqlJdTGFBOKNfE3KzXwxAaaTQzfrkj2SETUN+8jO4e01432PhoIIdz9mym0Zh1ZHld0nBS48UP7145ZkIkUZct0bADvWWGMoLT/QBnAh+hMO2igUfujtD5ig761dE+X+ZELruFy0GkmIiwCxka+y7XQ0K/uX7Zcc7K0WY/+yKslXzT+E2rDNUufPPS1vn5Hvpr4rcwUTZid/tecidj0rHLATPR04DgXfFo531d78F33eVCnN3oODdrnqn9FRuaYbpkYa1L7YhldyUaKdVtsakF3bTD9KKR7VMQLFYISeATxI4KpMyGMqAcv/XoADvE8OZEwc2iC1ZuqhAsL8xaUnBdXvCGijFk92lWtmHNlDt7DEsZVS84m7RHowB6GOQ2VrGT1jQjBQVoJphBmuuI56GNjJ/y7CPgCeLu/pE8Pv9EO92DtZgQ0VsQ2YL6ZIV1g++ZfJj1MXrHIE4/Miwfi+B1Dsq3iVfp X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3629.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(39860400002)(136003)(376002)(346002)(83380400001)(54906003)(33656002)(45080400002)(66946007)(4326008)(66476007)(66446008)(64756008)(2940100002)(186003)(76116006)(9686003)(6506007)(52536014)(6916009)(8936002)(86362001)(5660300002)(7696005)(478600001)(71200400001)(55016002)(2906002)(66556008)(26005)(316002)(19627405001)(8676002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?ZlgzTTY3T2N2M2FkWHhWREovcGIweExGZ2ExcVVSTHc1Q0R0N3FRT0FmY0lO?= =?utf-8?B?T0VPb0diMzkxS1Bvd0psWjdNbDdWSk1XNnpPdFhWWHRhRCtkQ0xId0NFN2J5?= =?utf-8?B?WUZ2THpsU3pOdjBYd2wrSUUzTUo5Z3h0RTRDSjdub2MyNGtwZDI2K1I3ODZF?= =?utf-8?B?bHlScC9uYkNmVHRzNFRoblpROFBGLzJ1WWxvb1lXUlkxeFpTRnFjc3pSVEhw?= =?utf-8?B?TE9HOUdhZ1hUSXlFQ3BMSUlEU3NCNkpQMmJZcW90aGorNkMrK256M2Q1dS9F?= =?utf-8?B?OHQveGpNb0ZKZDd3UWtnaWlWOVVQazU1TlorWVlRRmozQTkzVG9wLzZYMlJN?= =?utf-8?B?QnZPMTMvQ1FIOHVuZ0RzSUlTTTlsbi9FZWNhK1MrM0dRZGZGc25JamFhTFB3?= =?utf-8?B?VDhrWnhGa3h1VGdXdDhmVE14Rmt5VjNLaVRyYkptbHIzVjJaQ1htYWk2cDMx?= =?utf-8?B?dm9HUTJ4aGwrcnJ3UjZQNWhRcEgzdmcyRjI1c3JFNXRBSDR5UHBMT1ZIQnhk?= =?utf-8?B?RndiUnJYT2Mzdk8zejhtOGxYeGhxOW1rbGVtNGRVWndvNllKbkVNclU0MTlV?= =?utf-8?B?R3BLcHkrTTlNdVMwdXovTGtnY2todFdqVjRsb05CQnp2RjFFdjhWVi9yWjZx?= =?utf-8?B?RzNtUUE2cHhrOUF3K082Nk02VkcwUzhWUmxsMVI4VmptUElPSHFwMDVpK3VU?= =?utf-8?B?am0zSStRbHloMlA3Yk13eVFORHJWVjhWQkllUGdvMThvWXpnZ0p1UFJYakV1?= =?utf-8?B?NVBNc00xMlIxb0JLc3J5TFJZRHJDWWdIYTJndFRPS3J4TGhKbFFXSkxzdkJ5?= =?utf-8?B?b3FCcUg1YVdLMlQzUlo2d2VsdENKYVI3cDdDZzNWYlhoaC9peEZhSFc4NnVv?= =?utf-8?B?WEc3REF0STQxcVpUczNoZnZQbFdzV0UzWjlBejNZSXlJa1gxQmFSclFSb1hj?= =?utf-8?B?TVMyZzZFSHJ5NVVDbVdOcjJJNU4yaTllOVYvYkFSaTJPRVRyODBYMGp6Z1J6?= =?utf-8?B?S3FtblBQNVR5K2c2blRRWmNDN1oydDEwZDZxVWpwc2pqeWs3U0hzNTdhSDlE?= =?utf-8?B?UVZPVzVWcFlIUXU3WXhqdTM4MTBlUmpQaldXMjdmMDJ2UXBwYVFYQXVLQ3JH?= =?utf-8?B?dlNEZitpU01nQlArRmc0cFZqNUdUeE5lTlZxZDN2Z3RSWllXNUJkMEU4blcr?= =?utf-8?B?UE96czNLdDBhbkoreVdGNHMrMmpwMk5kdWhETFcwR212Q3JFRkZzMUw1S2hX?= =?utf-8?B?RWJBRWVLM0oxNFVoWE5LcDNEZ1ZqTFJXZ3JqOC9laWdyYWVodXdqL0hQaWx5?= =?utf-8?B?bE1zK2EvVnlCalBHMitZSEZLai82Q1o1aUxaNDljY3pOSVY2TVl2KzNieEVG?= =?utf-8?B?ckJJYnh3a3ExSWRGN2NKM1FtVVpnK0t6YXJRRUJ0dHhBVGlONDNTaHpJWm52?= =?utf-8?B?QjhiR3ZYemxIS0k1Um1oV0lIYktYdkxPcVFnWGpsTGMrY05FSzNWellJaUl5?= =?utf-8?B?eUwyQnZjRnM4T1ovOXl2SE4vTG82R25wcFZKeWtpTFlQTmlyd2t5eUNxVTl0?= =?utf-8?B?eUsvS3RrRmNqNVlkZWlzM3VZZGZGREM0bWsybDdhNWxHMWR4am1aYXNmS2Ru?= =?utf-8?B?b0RSYWZCcjlMQ082TkJPVXN1RWJNdks3eVNTODJZNUJRbTc4czJhcWY4MFZm?= =?utf-8?B?clhyVVNxUWtxOElGU3FEWUc5Y2J4L0d3YVZhS2JWdFI4amJvOVFtNUxDTXpa?= =?utf-8?Q?wuVJNyfz6httN3vgdE=3D?= x-ms-exchange-transport-forked: True Content-Type: multipart/alternative; boundary="_000_VI1PR08MB36292202FAA817F9FFDCAD81E46A9VI1PR08MB3629eurp_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5728 Original-Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: dbb448fa-7509-484d-df3f-08d8e9517c87 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xHh/rASsEkLhEEP9coBWdXt8gtUrFPNVwYmKihJiFcIzN+cI2qnKtdpSTx6OzEQMw9C32J+dtEZK4T9lzvc9wVj29uwflh+3haLOcgXZtmZ3kMCwyrg/UZSv5Lnt1/CfBb2FevnxabxacfEz+E1z0OHSE57ueadSdz8cZfvLwiqaRNoBx9XQV/Yv3WRCrdVk/EN1V8JFv0tgPLqxwoZAVgitXCkArQE9dEmaJjDJaAKxKARJiL58xfHsiO98k847rE8/3aqRlDzNLTo4Pdb+kaZd4GhLxtvJQzr3kPMA6W/fjL0QVzwk8S06fD6+bvEGTcK63bjRPi+EowVqJat/fHfYCpRirM+4amT7QDITSVYn9jRZXe9zlhKrdSW/UuxaBCGRTAcsvjEUutqSgZWQ4N36XFDD/AmgPZxwmCluH+Dq1k+eMWOXGFpNfZSwwcdV3Ndt0z4d4z1XXM1dFkadEYoKQkessrFrMbKCB75OKOxruh7NYnPLGs8JraUWuQcTrREoRqzZMeHby825+POZzboFGXH/iZ+k2lJWK/U8Bu3yZxAyjEQtnHMygEKGHxXCFbO2XMPGc0lKnHCl32mMfcq6YAyOQWJNjrsDvBpFU7XUBxNrubtoHCBTLXNTBRn+TyXkeXi5M6GoDn+xRlVacS39mWZr2GLUWmF/N7XN0tM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(39860400002)(136003)(376002)(396003)(46966006)(36840700001)(82740400003)(5660300002)(478600001)(81166007)(52536014)(19627405001)(6506007)(70586007)(9686003)(2940100002)(6916009)(82310400003)(86362001)(107886003)(47076005)(186003)(336012)(54906003)(70206006)(2906002)(33964004)(4326008)(83380400001)(45080400002)(26005)(8936002)(33656002)(7696005)(36860700001)(356005)(55016002)(316002)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 14:32:35.2548 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ddc0296-202a-4c4b-455f-08d8e95181eb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4996 --_000_VI1PR08MB36292202FAA817F9FFDCAD81E46A9VI1PR08MB3629eurp_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DQpIaSBhbGwsDQoNCndlJ3ZlIGJlZW4gZW5jb3VudGVyaW5nIGFuIGlzc3VlIHdoZW4gdXNpbmcg dGhlIGtlcm5lbCA1LjEwIHdpdGggcHJlZW1wdF9ydCBzdXBwb3J0IGZvciBEb20wLCB0aGUgcHJv YmxlbSBpcyB0aGF0IGR1cmluZyB0aGUgYm9vdCBvZiBEb20wLCBpdCBoaXRzIGEgQlVHX09OKCFp cnFzX2Rpc2FibGVkKCkpIGZyb20gdGhlIGZ1bmN0aW9uIGV2dGNobl9maWZvX3VubWFzayBkZWZp bmVkIGluIGV2ZW50c19maWZvLmMuDQoNClRoaXMgaXMgdGhlIGNhbGwgc3RhY2s6DQoNClsgICAx Ny44MTcwMThdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgIDE3Ljgx NzAyMV0ga2VybmVsIEJVRyBhdCBkcml2ZXJzL3hlbi9ldmVudHMvZXZlbnRzX2ZpZm8uYzoyNTgh DQpbICAgMTguODE3MDc5XSBJbnRlcm5hbCBlcnJvcjogT29wcyAtIEJVRzogMCBbIzFdIFBSRUVN UFRfUlQgU01QDQpbICAgMTguODE3MDgxXSBNb2R1bGVzIGxpbmtlZCBpbjogYnJpZGdlIHN0cCBs bGMgaXB2Ng0KWyAgIDE4LjgxNzA4Nl0gQ1BVOiAzIFBJRDogNTU4IENvbW06IHhlbnN0b3JlZCBO b3QgdGFpbnRlZCA1LjEwLjE2LXJ0MjUteW9jdG8tcHJlZW1wdC1ydCAjMQ0KWyAgIDE4LjgxNzA4 OV0gSGFyZHdhcmUgbmFtZTogQXJtIE5lb3ZlcnNlIE4xIFN5c3RlbSBEZXZlbG9wbWVudCBQbGF0 Zm9ybSAoRFQpDQpbICAgMTguODE3MDkwXSBwc3RhdGU6IDYwNDAwMDA1IChuWkN2IGRhaWYgK1BB TiAtVUFPIC1UQ08gQlRZUEU9LS0pDQpbICAgMTguODE3MDkyXSBwYyA6IGV2dGNobl9maWZvX3Vu bWFzaysweGQ0LzB4ZTANClsgICAxOC44MTcwOTldIGxyIDogeGVuX2lycV9sYXRlZW9pX2xvY2tl ZCsweGVjLzB4MjAwDQpbICAgMTguODE3MTAyXSBzcCA6IGZmZmY4MDAwMTIzZjNjYzANClsgICAx OC44MTcxMDJdIHgyOTogZmZmZjgwMDAxMjNmM2NjMCB4Mjg6IGZmZmYwMDAwNDI3YjFkODANClsg ICAxOC44MTcxMDRdIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IDAwMDAwMDAwMDAwMDAwMDAN ClsgICAxOC44MTcxMDZdIHgyNTogMDAwMDAwMDAwMDAwMDAwMSB4MjQ6IDAwMDAwMDAwMDAwMDAw MDENClsgICAxOC44MTcxMDddIHgyMzogZmZmZjAwMDA0MTJmYzkwMCB4MjI6IDAwMDAwMDAwMDAw MDAwMDQNClsgICAxOC44MTcxMDldIHgyMTogMDAwMDAwMDAwMDAwMDAwMCB4MjA6IGZmZmYwMDAw NDJlMDY5OTANClsgICAxOC44MTcxMTBdIHgxOTogZmZmZjAwMDA0MjdiMWQ4MCB4MTg6IDAwMDAw MDAwMDAwMDAwMTANClsgICAxOC44MTcxMTJdIHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAw MDAwMDAwMDAwMDAwMDANClsgICAxOC44MTcxMTNdIHgxNTogMDAwMDAwMDAwMDAwMDAwMiB4MTQ6 IDAwMDAwMDAwMDAwMDAwMDENClsgICAxOC44MTcxMTRdIHgxMzogMDAwMDAwMDAwMDAxYTdlOCB4 MTI6IDAwMDAwMDAwMDAwMDAwNDANClsgICAxOC44MTcxMTZdIHgxMTogZmZmZjAwMDA0MDQwMDI0 OCB4MTA6IGZmZmYwMDAwNDA0MDAyNGENClsgICAxOC44MTcxMTddIHg5IDogZmZmZjgwMDAxMWJl NTIwMCB4OCA6IGZmZmYwMDAwNDA0MDAyNzANClsgICAxOC44MTcxMTldIHg3IDogMDAwMDAwMDAw MDAwMDAwMCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMNClsgICAxOC44MTcxMjBdIHg1IDogMDAwMDAw MDAwMDAwMDAwMCB4NCA6IGZmZmYwMDAwNDA0MDAzMDgNClsgICAxOC44MTcxMjFdIHgzIDogZmZm ZjAwMDA0MDhhNDAwYyB4MiA6IDAwMDAwMDAwMDAwMDAwMDANClsgICAxOC44MTcxMjJdIHgxIDog MDAwMDAwMDAwMDAwMDAwMCB4MCA6IGZmZmYwMDAwNDA4YTQwMDANClsgICAxOC44MTcxMjRdIENh bGwgdHJhY2U6DQpbICAgMTguODE3MTI1XSAgZXZ0Y2huX2ZpZm9fdW5tYXNrKzB4ZDQvMHhlMA0K WyAgIDE4LjgxNzEyN10gIHhlbl9pcnFfbGF0ZWVvaV9sb2NrZWQrMHhlYy8weDIwMA0KWyAgIDE4 LjgxNzEyOV0gIHhlbl9pcnFfbGF0ZWVvaSsweDQ4LzB4NjQNClsgICAxOC44MTcxMzFdICBldnRj aG5fd3JpdGUrMHgxMjQvMHgxNWMNClsgICAxOC44MTcxMzRdICB2ZnNfd3JpdGUrMHhmMC8weDJj Yw0KWyAgIDE4LjgxNzEzN10gIGtzeXNfd3JpdGUrMHhlMC8weDEwMA0KWyAgIDE4LjgxNzEzOV0g IF9fYXJtNjRfc3lzX3dyaXRlKzB4MjAvMHgzMA0KWyAgIDE4LjgxNzE0Ml0gIGVsMF9zdmNfY29t bW9uLmNvbnN0cHJvcC4wKzB4NzgvMHgxYTANClsgICAxOC44MTcxNDVdICBkb19lbDBfc3ZjKzB4 MjQvMHg5MA0KWyAgIDE4LjgxNzE0N10gIGVsMF9zdmMrMHgxNC8weDIwDQpbICAgMTguODE3MTUx XSAgZWwwX3N5bmNfaGFuZGxlcisweDFhNC8weDFiMA0KWyAgIDE4LjgxNzE1M10gIGVsMF9zeW5j KzB4MTc0LzB4MTgwDQpbICAgMTguODE3MTU2XSBDb2RlOiA1MjgwMDEyMCBiOTAwMjNlNiA5N2U2 ZDEwNCAxN2ZmZmZmMCAoZDQyMTAwMDApDQpbICAgMTguODE3MTU4XSAtLS1bIGVuZCB0cmFjZSAw MDAwMDAwMDAwMDAwMDAyIF0tLS0NCg0KT3VyIGxhc3QgdGVzdGVkIGtlcm5lbCB3YXMgdGhlIDUu NCBhbmQgb3VyIGFuYWx5c2lzIHBvaW50ZWQgb3V0IHRoYXQgdGhlIGludHJvZHVjdGlvbiBvZiB0 aGUgbGF0ZWVvaSBmcmFtZXdvcmsgKHhlbi9ldmVudHM6IGFkZCBhIG5ldyAibGF0ZSBFT0kiIGV2 dGNobiBmcmFtZXdvcmspIGluIGNvbmp1bmN0aW9uIHdpdGggdGhlIHByZWVtcHRfcnQgcGF0Y2hl cyAoaXJxcyBrZXB0IGVuYWJsZWQgYmV0d2VlbiBzcGlubG9ja190L3J3bG9ja190IF9pcnFzYXZl L+KAi19pcnFyZXN0b3JlIG9wZXJhdGlvbnMpIGlzIHRoZSByb290IGNhdXNlLg0KDQpHaXZlbiB0 aGF0IG1hbnkgbW9kaWZpY2F0aW9ucyB3ZXJlIG1hZGUgdG8gdGhlIG1hc2svdW5tYXNrIG9wZXJh dGlvbnMsIGEgYmlnIG9uZSBmcm9tIEp1ZXJnZW4gR3Jvc3MgKHhlbi9ldmVudHM6IGRvbid0IHVu bWFzayBhbiBldmVudCBjaGFubmVsIHdoZW4gYW4gZW9pIGlzIHBlbmRpbmcpLCBpcyB0aGUgQlVH X09OKC4uLikgc3RpbGwgbmVlZGVkPw0KDQpXaXRoIHRoZSBtZW50aW9uZWQgY29tbWl0IGV2ZXJ5 IGNhbGwgdG8gYSBtYXNrL3VubWFzayBvcGVyYXRpb24gaXMgcHJvdGVjdGVkIGJ5IGEgc3Bpbmxv Y2ssIHNvIEkgd291bGQgbGlrZSB0byBoYXZlIHNvbWUgZmVlZGJhY2tzIGZyb20gd2hvIGhhcyBt b3JlIGV4cGVyaWVuY2UgdGhhbiBtZSBvbiB0aGlzIHBhcnQgb2YgdGhlIGNvZGUuDQoNClRoYW5r IHlvdSwNCg0KTHVjYQ0KDQo= --_000_VI1PR08MB36292202FAA817F9FFDCAD81E46A9VI1PR08MB3629eurp_ Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIgc3R5bGU9 ImRpc3BsYXk6bm9uZTsiPiBQIHttYXJnaW4tdG9wOjA7bWFyZ2luLWJvdHRvbTowO30gPC9zdHls ZT4NCjwvaGVhZD4NCjxib2R5IGRpcj0ibHRyIj4NCjxkaXYgc3R5bGU9ImZvbnQtZmFtaWx5OiBD YWxpYnJpLCBBcmlhbCwgSGVsdmV0aWNhLCBzYW5zLXNlcmlmOyBmb250LXNpemU6IDEycHQ7IGNv bG9yOiByZ2IoMCwgMCwgMCk7Ij4NCiZuYnNwOzxicj4NCjwvZGl2Pg0KPGRpdj4NCjxkaXYgZGly PSJsdHIiPg0KPGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6Q2FsaWJyaSxBcmlhbCxIZWx2ZXRpY2Es c2Fucy1zZXJpZjsgZm9udC1zaXplOjEycHQ7IGNvbG9yOnJnYigwLDAsMCkiPg0KSGkgYWxsLDwv ZGl2Pg0KPGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6Q2FsaWJyaSxBcmlhbCxIZWx2ZXRpY2Esc2Fu cy1zZXJpZjsgZm9udC1zaXplOjEycHQ7IGNvbG9yOnJnYigwLDAsMCkiPg0KPGJyPg0KPC9kaXY+ DQo8ZGl2IHN0eWxlPSJmb250LWZhbWlseTpDYWxpYnJpLEFyaWFsLEhlbHZldGljYSxzYW5zLXNl cmlmOyBmb250LXNpemU6MTJwdDsgY29sb3I6cmdiKDAsMCwwKSI+DQp3ZSd2ZSBiZWVuIGVuY291 bnRlcmluZyBhbiBpc3N1ZSB3aGVuIHVzaW5nIHRoZSBrZXJuZWwgNS4xMCB3aXRoIHByZWVtcHRf cnQgc3VwcG9ydCBmb3IgRG9tMCwgdGhlIHByb2JsZW0gaXMgdGhhdCBkdXJpbmcgdGhlIGJvb3Qg b2YgRG9tMCwgaXQgaGl0cyBhIEJVR19PTighaXJxc19kaXNhYmxlZCgpKSBmcm9tIHRoZSBmdW5j dGlvbiZuYnNwO2V2dGNobl9maWZvX3VubWFzayBkZWZpbmVkIGluIGV2ZW50c19maWZvLmMuPC9k aXY+DQo8ZGl2IHN0eWxlPSJmb250LWZhbWlseTpDYWxpYnJpLEFyaWFsLEhlbHZldGljYSxzYW5z LXNlcmlmOyBmb250LXNpemU6MTJwdDsgY29sb3I6cmdiKDAsMCwwKSI+DQo8YnI+DQo8L2Rpdj4N CjxkaXYgc3R5bGU9ImZvbnQtZmFtaWx5OkNhbGlicmksQXJpYWwsSGVsdmV0aWNhLHNhbnMtc2Vy aWY7IGZvbnQtc2l6ZToxMnB0OyBjb2xvcjpyZ2IoMCwwLDApIj4NClRoaXMgaXMgdGhlIGNhbGwg c3RhY2s6PC9kaXY+DQo8ZGl2IHN0eWxlPSJmb250LWZhbWlseTpDYWxpYnJpLEFyaWFsLEhlbHZl dGljYSxzYW5zLXNlcmlmOyBmb250LXNpemU6MTJwdDsgY29sb3I6cmdiKDAsMCwwKSI+DQo8YnI+ DQo8L2Rpdj4NCjxkaXYgc3R5bGU9ImZvbnQtZmFtaWx5OkNhbGlicmksQXJpYWwsSGVsdmV0aWNh LHNhbnMtc2VyaWY7IGZvbnQtc2l6ZToxMnB0OyBjb2xvcjpyZ2IoMCwwLDApIj4NClsgJm5ic3A7 IDE3LjgxNzAxOF0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQo8ZGl2Plsg Jm5ic3A7IDE3LjgxNzAyMV0ga2VybmVsIEJVRyBhdCBkcml2ZXJzL3hlbi9ldmVudHMvZXZlbnRz X2ZpZm8uYzoyNTghPC9kaXY+DQo8ZGl2PlsgJm5ic3A7IDE4LjgxNzA3OV0gSW50ZXJuYWwgZXJy b3I6IE9vcHMgLSBCVUc6IDAgWyMxXSBQUkVFTVBUX1JUIFNNUDwvZGl2Pg0KPGRpdj5bICZuYnNw OyAxOC44MTcwODFdIE1vZHVsZXMgbGlua2VkIGluOiBicmlkZ2Ugc3RwIGxsYyBpcHY2PC9kaXY+ DQo8ZGl2PlsgJm5ic3A7IDE4LjgxNzA4Nl0gQ1BVOiAzIFBJRDogNTU4IENvbW06IHhlbnN0b3Jl ZCBOb3QgdGFpbnRlZCA1LjEwLjE2LXJ0MjUteW9jdG8tcHJlZW1wdC1ydCAjMTwvZGl2Pg0KPGRp dj5bICZuYnNwOyAxOC44MTcwODldIEhhcmR3YXJlIG5hbWU6IEFybSBOZW92ZXJzZSBOMSBTeXN0 ZW0gRGV2ZWxvcG1lbnQgUGxhdGZvcm0gKERUKTwvZGl2Pg0KPGRpdj5bICZuYnNwOyAxOC44MTcw OTBdIHBzdGF0ZTogNjA0MDAwMDUgKG5aQ3YgZGFpZiArUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSk8 L2Rpdj4NCjxkaXY+WyAmbmJzcDsgMTguODE3MDkyXSBwYyA6IGV2dGNobl9maWZvX3VubWFzaysw eGQ0LzB4ZTA8L2Rpdj4NCjxkaXY+WyAmbmJzcDsgMTguODE3MDk5XSBsciA6IHhlbl9pcnFfbGF0 ZWVvaV9sb2NrZWQrMHhlYy8weDIwMDwvZGl2Pg0KPGRpdj5bICZuYnNwOyAxOC44MTcxMDJdIHNw IDogZmZmZjgwMDAxMjNmM2NjMDwvZGl2Pg0KPGRpdj5bICZuYnNwOyAxOC44MTcxMDJdIHgyOTog ZmZmZjgwMDAxMjNmM2NjMCB4Mjg6IGZmZmYwMDAwNDI3YjFkODAgPC9kaXY+DQo8ZGl2PlsgJm5i c3A7IDE4LjgxNzEwNF0geDI3OiAwMDAwMDAwMDAwMDAwMDAwIHgyNjogMDAwMDAwMDAwMDAwMDAw MCA8L2Rpdj4NCjxkaXY+WyAmbmJzcDsgMTguODE3MTA2XSB4MjU6IDAwMDAwMDAwMDAwMDAwMDEg eDI0OiAwMDAwMDAwMDAwMDAwMDAxIDwvZGl2Pg0KPGRpdj5bICZuYnNwOyAxOC44MTcxMDddIHgy MzogZmZmZjAwMDA0MTJmYzkwMCB4MjI6IDAwMDAwMDAwMDAwMDAwMDQgPC9kaXY+DQo8ZGl2Plsg Jm5ic3A7IDE4LjgxNzEwOV0geDIxOiAwMDAwMDAwMDAwMDAwMDAwIHgyMDogZmZmZjAwMDA0MmUw Njk5MCA8L2Rpdj4NCjxkaXY+WyAmbmJzcDsgMTguODE3MTEwXSB4MTk6IGZmZmYwMDAwNDI3YjFk ODAgeDE4OiAwMDAwMDAwMDAwMDAwMDEwIDwvZGl2Pg0KPGRpdj5bICZuYnNwOyAxOC44MTcxMTJd IHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAgPC9kaXY+DQo8ZGl2 PlsgJm5ic3A7IDE4LjgxNzExM10geDE1OiAwMDAwMDAwMDAwMDAwMDAyIHgxNDogMDAwMDAwMDAw MDAwMDAwMSA8L2Rpdj4NCjxkaXY+WyAmbmJzcDsgMTguODE3MTE0XSB4MTM6IDAwMDAwMDAwMDAw MWE3ZTggeDEyOiAwMDAwMDAwMDAwMDAwMDQwIDwvZGl2Pg0KPGRpdj5bICZuYnNwOyAxOC44MTcx MTZdIHgxMTogZmZmZjAwMDA0MDQwMDI0OCB4MTA6IGZmZmYwMDAwNDA0MDAyNGEgPC9kaXY+DQo8 ZGl2PlsgJm5ic3A7IDE4LjgxNzExN10geDkgOiBmZmZmODAwMDExYmU1MjAwIHg4IDogZmZmZjAw MDA0MDQwMDI3MCA8L2Rpdj4NCjxkaXY+WyAmbmJzcDsgMTguODE3MTE5XSB4NyA6IDAwMDAwMDAw MDAwMDAwMDAgeDYgOiAwMDAwMDAwMDAwMDAwMDAzIDwvZGl2Pg0KPGRpdj5bICZuYnNwOyAxOC44 MTcxMjBdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IGZmZmYwMDAwNDA0MDAzMDggPC9kaXY+ DQo8ZGl2PlsgJm5ic3A7IDE4LjgxNzEyMV0geDMgOiBmZmZmMDAwMDQwOGE0MDBjIHgyIDogMDAw MDAwMDAwMDAwMDAwMCA8L2Rpdj4NCjxkaXY+WyAmbmJzcDsgMTguODE3MTIyXSB4MSA6IDAwMDAw MDAwMDAwMDAwMDAgeDAgOiBmZmZmMDAwMDQwOGE0MDAwIDwvZGl2Pg0KPGRpdj5bICZuYnNwOyAx OC44MTcxMjRdIENhbGwgdHJhY2U6PC9kaXY+DQo8ZGl2PlsgJm5ic3A7IDE4LjgxNzEyNV0gJm5i c3A7ZXZ0Y2huX2ZpZm9fdW5tYXNrKzB4ZDQvMHhlMDwvZGl2Pg0KPGRpdj5bICZuYnNwOyAxOC44 MTcxMjddICZuYnNwO3hlbl9pcnFfbGF0ZWVvaV9sb2NrZWQrMHhlYy8weDIwMDwvZGl2Pg0KPGRp dj5bICZuYnNwOyAxOC44MTcxMjldICZuYnNwO3hlbl9pcnFfbGF0ZWVvaSsweDQ4LzB4NjQ8L2Rp dj4NCjxkaXY+WyAmbmJzcDsgMTguODE3MTMxXSAmbmJzcDtldnRjaG5fd3JpdGUrMHgxMjQvMHgx NWM8L2Rpdj4NCjxkaXY+WyAmbmJzcDsgMTguODE3MTM0XSAmbmJzcDt2ZnNfd3JpdGUrMHhmMC8w eDJjYzwvZGl2Pg0KPGRpdj5bICZuYnNwOyAxOC44MTcxMzddICZuYnNwO2tzeXNfd3JpdGUrMHhl MC8weDEwMDwvZGl2Pg0KPGRpdj5bICZuYnNwOyAxOC44MTcxMzldICZuYnNwO19fYXJtNjRfc3lz X3dyaXRlKzB4MjAvMHgzMDwvZGl2Pg0KPGRpdj5bICZuYnNwOyAxOC44MTcxNDJdICZuYnNwO2Vs MF9zdmNfY29tbW9uLmNvbnN0cHJvcC4wKzB4NzgvMHgxYTA8L2Rpdj4NCjxkaXY+WyAmbmJzcDsg MTguODE3MTQ1XSAmbmJzcDtkb19lbDBfc3ZjKzB4MjQvMHg5MDwvZGl2Pg0KPGRpdj5bICZuYnNw OyAxOC44MTcxNDddICZuYnNwO2VsMF9zdmMrMHgxNC8weDIwPC9kaXY+DQo8ZGl2PlsgJm5ic3A7 IDE4LjgxNzE1MV0gJm5ic3A7ZWwwX3N5bmNfaGFuZGxlcisweDFhNC8weDFiMDwvZGl2Pg0KPGRp dj5bICZuYnNwOyAxOC44MTcxNTNdICZuYnNwO2VsMF9zeW5jKzB4MTc0LzB4MTgwPC9kaXY+DQo8 ZGl2PlsgJm5ic3A7IDE4LjgxNzE1Nl0gQ29kZTogNTI4MDAxMjAgYjkwMDIzZTYgOTdlNmQxMDQg MTdmZmZmZjAgKGQ0MjEwMDAwKSA8L2Rpdj4NClsgJm5ic3A7IDE4LjgxNzE1OF0gLS0tWyBlbmQg dHJhY2UgMDAwMDAwMDAwMDAwMDAwMiBdLS0tPGJyPg0KPC9kaXY+DQo8ZGl2IHN0eWxlPSJmb250 LWZhbWlseTpDYWxpYnJpLEFyaWFsLEhlbHZldGljYSxzYW5zLXNlcmlmOyBmb250LXNpemU6MTJw dDsgY29sb3I6cmdiKDAsMCwwKSI+DQo8YnI+DQo8L2Rpdj4NCjxkaXYgc3R5bGU9ImZvbnQtZmFt aWx5OkNhbGlicmksQXJpYWwsSGVsdmV0aWNhLHNhbnMtc2VyaWY7IGZvbnQtc2l6ZToxMnB0OyBj b2xvcjpyZ2IoMCwwLDApIj4NCk91ciBsYXN0IHRlc3RlZCBrZXJuZWwgd2FzIHRoZSA1LjQgYW5k IG91ciBhbmFseXNpcyBwb2ludGVkIG91dCB0aGF0IHRoZSBpbnRyb2R1Y3Rpb24gb2YgdGhlIGxh dGVlb2kgZnJhbWV3b3JrICh4ZW4vZXZlbnRzOiBhZGQgYSBuZXcgJnF1b3Q7bGF0ZSBFT0kmcXVv dDsgZXZ0Y2huIGZyYW1ld29yaykgaW4gY29uanVuY3Rpb24gd2l0aCB0aGUgcHJlZW1wdF9ydCBw YXRjaGVzIChpcnFzIGtlcHQgZW5hYmxlZCBiZXR3ZWVuIHNwaW5sb2NrX3Qvcndsb2NrX3QgX2ly cXNhdmU8aT4vPC9pPuKAi19pcnFyZXN0b3JlDQogb3BlcmF0aW9ucykgaXMgdGhlIHJvb3QgY2F1 c2UuPC9kaXY+DQo8ZGl2IHN0eWxlPSJmb250LWZhbWlseTpDYWxpYnJpLEFyaWFsLEhlbHZldGlj YSxzYW5zLXNlcmlmOyBmb250LXNpemU6MTJwdDsgY29sb3I6cmdiKDAsMCwwKSI+DQo8YnI+DQo8 L2Rpdj4NCjxkaXYgc3R5bGU9ImZvbnQtZmFtaWx5OkNhbGlicmksQXJpYWwsSGVsdmV0aWNhLHNh bnMtc2VyaWY7IGZvbnQtc2l6ZToxMnB0OyBjb2xvcjpyZ2IoMCwwLDApIj4NCkdpdmVuIHRoYXQg bWFueSBtb2RpZmljYXRpb25zIHdlcmUgbWFkZSB0byB0aGUgbWFzay91bm1hc2sgb3BlcmF0aW9u cywgYSBiaWcgb25lIGZyb20mbmJzcDtKdWVyZ2VuIEdyb3NzICh4ZW4vZXZlbnRzOiBkb24ndCB1 bm1hc2sgYW4gZXZlbnQgY2hhbm5lbCB3aGVuIGFuIGVvaSBpcyBwZW5kaW5nKSwgaXMgdGhlIEJV R19PTiguLi4pIHN0aWxsIG5lZWRlZD8mbmJzcDs8L2Rpdj4NCjxkaXYgc3R5bGU9ImZvbnQtZmFt aWx5OkNhbGlicmksQXJpYWwsSGVsdmV0aWNhLHNhbnMtc2VyaWY7IGZvbnQtc2l6ZToxMnB0OyBj b2xvcjpyZ2IoMCwwLDApIj4NCjxicj4NCjwvZGl2Pg0KPGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6 Q2FsaWJyaSxBcmlhbCxIZWx2ZXRpY2Esc2Fucy1zZXJpZjsgZm9udC1zaXplOjEycHQ7IGNvbG9y OnJnYigwLDAsMCkiPg0KV2l0aCB0aGUgbWVudGlvbmVkIGNvbW1pdCBldmVyeSBjYWxsIHRvIGEg bWFzay91bm1hc2sgb3BlcmF0aW9uIGlzIHByb3RlY3RlZCBieSBhIHNwaW5sb2NrLCBzbyBJIHdv dWxkIGxpa2UgdG8gaGF2ZSBzb21lIGZlZWRiYWNrcyBmcm9tIHdobyBoYXMgbW9yZSBleHBlcmll bmNlIHRoYW4gbWUgb24gdGhpcyBwYXJ0IG9mIHRoZSBjb2RlLjwvZGl2Pg0KPGRpdiBzdHlsZT0i Zm9udC1mYW1pbHk6Q2FsaWJyaSxBcmlhbCxIZWx2ZXRpY2Esc2Fucy1zZXJpZjsgZm9udC1zaXpl OjEycHQ7IGNvbG9yOnJnYigwLDAsMCkiPg0KPGJyPg0KPC9kaXY+DQo8ZGl2IHN0eWxlPSJmb250 LWZhbWlseTpDYWxpYnJpLEFyaWFsLEhlbHZldGljYSxzYW5zLXNlcmlmOyBmb250LXNpemU6MTJw dDsgY29sb3I6cmdiKDAsMCwwKSI+DQpUaGFuayB5b3UsPC9kaXY+DQo8ZGl2IHN0eWxlPSJmb250 LWZhbWlseTpDYWxpYnJpLEFyaWFsLEhlbHZldGljYSxzYW5zLXNlcmlmOyBmb250LXNpemU6MTJw dDsgY29sb3I6cmdiKDAsMCwwKSI+DQo8YnI+DQo8L2Rpdj4NCjxkaXYgc3R5bGU9ImZvbnQtZmFt aWx5OkNhbGlicmksQXJpYWwsSGVsdmV0aWNhLHNhbnMtc2VyaWY7IGZvbnQtc2l6ZToxMnB0OyBj b2xvcjpyZ2IoMCwwLDApIj4NCkx1Y2E8L2Rpdj4NCjxkaXY+DQo8ZGl2IHN0eWxlPSJmb250LWZh bWlseTpDYWxpYnJpLEFyaWFsLEhlbHZldGljYSxzYW5zLXNlcmlmOyBmb250LXNpemU6MTJwdDsg Y29sb3I6cmdiKDAsMCwwKSI+DQo8YnI+DQo8L2Rpdj4NCjwvZGl2Pg0KPC9kaXY+DQo8L2Rpdj4N CjwvYm9keT4NCjwvaHRtbD4NCg== --_000_VI1PR08MB36292202FAA817F9FFDCAD81E46A9VI1PR08MB3629eurp_-- From xen-devel-bounces@lists.xenproject.org Wed Mar 17 14:39:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 14:39:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98726.187427 (Exim 4.92) (envelope-from ) id 1lMXKa-0004Ti-DP; Wed, 17 Mar 2021 14:39:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98726.187427; Wed, 17 Mar 2021 14:39:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXKa-0004Tb-A8; Wed, 17 Mar 2021 14:39:28 +0000 Received: by outflank-mailman (input) for mailman id 98726; Wed, 17 Mar 2021 14:39:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXKZ-0004TW-Fd for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 14:39:27 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown [40.107.7.80]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b2bea3a6-d2be-4dc6-8a14-2d739f3df3ec; Wed, 17 Mar 2021 14:39:24 +0000 (UTC) Received: from MR2P264CA0149.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::12) by PA4PR08MB6093.eurprd08.prod.outlook.com (2603:10a6:102:e8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Wed, 17 Mar 2021 14:39:00 +0000 Received: from VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:501:1:cafe::d8) by MR2P264CA0149.outlook.office365.com (2603:10a6:501:1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Wed, 17 Mar 2021 14:39:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT007.mail.protection.outlook.com (10.152.18.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Wed, 17 Mar 2021 14:38:59 +0000 Received: ("Tessian outbound 10f3eddefbbf:v87"); Wed, 17 Mar 2021 14:38:59 +0000 Received: from 38254fbcce4a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 86E0B9E1-0139-488D-89A3-F138C91A65A2.1; Wed, 17 Mar 2021 14:38:51 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 38254fbcce4a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 17 Mar 2021 14:38:51 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VI1PR08MB3021.eurprd08.prod.outlook.com (2603:10a6:803:47::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Wed, 17 Mar 2021 14:38:49 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3933.032; Wed, 17 Mar 2021 14:38:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2bea3a6-d2be-4dc6-8a14-2d739f3df3ec DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4OIHF80mRt7tjGXqM/ku41ULBLVuIoHdxRWkfRd2rzw=; b=abOM1r9LEzdHLWkIuIlouP8eA/wOuXpNL8ebmcn4Jy/XEnHNhuuJ5Z4q2sFTMqFiGKK/STDy5ZIbmM5vopvMspUPElKb9Ke85s8c0H8OKnj0BDpkhpNTDHxezIeyA0vDXd/H9IZjIMevTXrQ3hgux62edeZs9mCuvZbBRfqhNsg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: e3a82717172f382e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SDUsYNyQfOCMS9PQVGzdCCHizpngc4n2YHO+H3GcrhDqrStGiPPM3SUnZJjIWXipjwYY8vnP2o0zzB9lk8hNbUud92/sl7FK9/49exbwRuJcxTShmlXO9vnb8FuqQjDeyQhzbwUEeR0RSKkyswkUCBUqqo3n3Bn+5pIM159X9nwgibzf4oZLnRo5Oiqt0uB1JHJ7zjgZ1o2mYn0Y/GhgNImJh5TjZfBZcL7NTOPnH0xIxmArS1rUGWcaw5UmOwERH+zmmiY/Tr/uB0stUPWiTwjbgWedCojZC41/tNfMVdkug1+ZR9irPU9xbMvSU4pWjg+shE9lC1FHixqOhCTYAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4OIHF80mRt7tjGXqM/ku41ULBLVuIoHdxRWkfRd2rzw=; b=OWGivg61zUUN+HD6lltObXhC41MhB5tzkUud+UFvwrscyfeDs7V1YX9zadubfNTqTeC7KZorFbmYX9Po0a6UUir2cTsXiVRoxcz4iFJBLJLLtGNCmQox1iAuya2t+ZrGBACoc5R4FPudn/fbjIW2+H7/hZBEFdaCfOk1n5c4vhSSsqXrXpi7HT6JFOJhbOSV5FAuyYEJsuXX66lr3kRmIo0Sk8WNU53pvcxgCw53o8lQaUnCLegtn7mzVlulYtVI5bg9SJW/f5UKfESMsgOi0vp8UqI0i/w40ov5SFebP8UVBDMVkbXvDgveLNn0kPtMDokq569HnWp99PAW/JKJwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4OIHF80mRt7tjGXqM/ku41ULBLVuIoHdxRWkfRd2rzw=; b=abOM1r9LEzdHLWkIuIlouP8eA/wOuXpNL8ebmcn4Jy/XEnHNhuuJ5Z4q2sFTMqFiGKK/STDy5ZIbmM5vopvMspUPElKb9Ke85s8c0H8OKnj0BDpkhpNTDHxezIeyA0vDXd/H9IZjIMevTXrQ3hgux62edeZs9mCuvZbBRfqhNsg= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH for-next v2 1/2] xen/arm: Include asm/asm-offsets.h and asm/macros.h on every assembly files Thread-Topic: [PATCH for-next v2 1/2] xen/arm: Include asm/asm-offsets.h and asm/macros.h on every assembly files Thread-Index: AQHXGCLU4+TkVELU2EmVwv7bZbEE7KqIRjUA Date: Wed, 17 Mar 2021 14:38:49 +0000 Message-ID: <2B11BB5C-EF9B-4CE0-8477-D94091DA0870@arm.com> References: <20210313160611.18665-1-julien@xen.org> <20210313160611.18665-2-julien@xen.org> In-Reply-To: <20210313160611.18665-2-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.26.33.241] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 19e7f20b-3796-4352-8e57-08d8e952670b x-ms-traffictypediagnostic: VI1PR08MB3021:|PA4PR08MB6093: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: uvTu5Icqoaa4OkrhORZ6J8GCHEneg4gJAfL9FRbntNfbz5f9FAgSJs5mK8T0oQFObWTi/o58cOTVmheMO88sGr6K9BdYV0ZSd/CUxNoQOxMcJLSxbqVlm/dObYWfAD83axqwCEYSQMn769aBwVCrc4EUvLbsmHwtCwa9rMwRnsF+OnLzdMhx4Q20QvHp5+Mu/DLw0ma4qLraFcU8m7jwdKJCkRVHVu2vTyKpertAUBQlwekC7C42oBrtl+lTNowOKbLGzyPkjEZ12w/p6r4TFqMQfTXsMQ8wN/06/0+w1ftZlcrF7neyjZnLxvm1FcrE+3Lya0SSJMUWBxqoQlR20FuHiCeb4mMQKMQX9mvpzp/NoiQ71v3sowqEZrFNbF/WE6jMSjbPiA3ceHwTnaAGw6K+uwB4oduLpKtBzIM60qoN8hQBfw2dDpfLooFRES9tsymB3H4eHYiLYj4vFM94i6PBpjSGNKLk58HK2e9q5RrtKgsh3+NlczvRtFUn1ZDIIeVqb0fewbwExGbDChzqkR9cE0Acuf2MQRPKh6v+OUnYN+1CKzxk2Jy7GXladDGb3nL3TeycEggbPdhmx0iHABS0MFAEKbpG0uVPiRlc3KiywGwzrsGZntQsg/DNLddn X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39860400002)(366004)(396003)(376002)(346002)(478600001)(54906003)(76116006)(2906002)(5660300002)(6512007)(64756008)(33656002)(55236004)(316002)(2616005)(26005)(53546011)(6506007)(6486002)(71200400001)(66946007)(66476007)(36756003)(8936002)(66556008)(86362001)(8676002)(4326008)(186003)(83380400001)(91956017)(66446008)(6916009)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?CAerU8tvcW57jP61IjV4UGSRpCIVSEPN94c4mUE2k9C4hOyY2SZjpFzKvU7D?= =?us-ascii?Q?owZZ0sXIToPHHP6gZmyUImcidas8kcm+NlbPkKSXOtnfknsxuRU3zjH6OGVi?= =?us-ascii?Q?EQr0woCiU8e2P7Gjhv1I0+RF9l+FckG3Zhq4ZsICc2iy1nP5l6cT+M6rTLdU?= =?us-ascii?Q?1fX66tjHdj8mSsMZC/crcnJXor1/nzib5LxYJHa50nGfvyBkC9lTjHNj/rH9?= =?us-ascii?Q?5pZVcozkerJHuU7A7+4UefUk08ldLLeWabxQyMY1BTQ5Y5I/vFeNz62kGDf5?= =?us-ascii?Q?oyl0keXvW7wcc0q8ADBTrJDVoqtohOC3r0zcXjQsbPjLvYx2grDPK3c55hVF?= =?us-ascii?Q?pV5vwtMGmgY1FdCoucujBRF9Hi4sdSxBd8tAOB+e64TgoK5+vlnk7DFtvmUr?= =?us-ascii?Q?YHrzZiy7SnTmJh58Q+EmEuJpZhl1q0/ETNb1VS9GBJ9cX89lJHKyLAE0IRWQ?= =?us-ascii?Q?xTbCFJ18Vbw9UALbpRmylCuZWh+vo+IJN8OMVCJnzqzXli6uIIUXJvIg/CuW?= =?us-ascii?Q?SvYDrRP53NcBK7wmzMHt2m1AaWpO5AKam9gePtIwmZZ3RNM+dVJM8wOoSikE?= =?us-ascii?Q?KZNUJ/e4qT80pgJNePjXrzzrWMUcM7fRXQ7jlRo3jh3HCOtlONqErf+M4z95?= =?us-ascii?Q?Y2Mv6hIq/eF90Wm8GE+/EuB81ug+OJbt6mzgU4bjj8IiyW7rGYF6CuZ+rbV+?= =?us-ascii?Q?Q1QY8AYDIIMDWBCrzWQQbBBTOC5glU4T6lglG+MMoLSG8ZAbBb0M2EbFK9Wc?= =?us-ascii?Q?00sZVbEgBAizgnxvYMEY5+KZcwO4/nNowphu0nufszef3TBndju3u1+vXEEA?= =?us-ascii?Q?+XufsV7lfeiPETz4N3LYvn1moFEkf3zLY8lNcdZvCzJIxy2Q/yBaQOjdqfVA?= =?us-ascii?Q?U+aRM/amn7iI+N2u/siF+OOHq3KOkTGyO+gwdXMfSmVfnRoldYTlYuTkRrCI?= =?us-ascii?Q?n/g0pZNb25sVRP4zBJlfl/eqfdGxRujpi3V7bt/kCqwl/oMS1itN2nb/j/Gq?= =?us-ascii?Q?2eGuD8AaGU1ART7YqLjDVck3IYeWJ6JzgX+2oTDBkHPBt7tkQ8NU+ABRNti+?= =?us-ascii?Q?VkcoDz5DQomEaL2FwZPXXKBg3Y51L1HB8suz7+tmgAmHiV96BhiFphHUSKd7?= =?us-ascii?Q?hvFBQW7xTMCh4EPKP89eYQ9xsSpF/b3f/HM0PMDtJBhOs+kjJbohwlMbsoVO?= =?us-ascii?Q?deBOtkmZmtr67v8+I0v/TuwWUyHxTiiFZIqDgY5nSjy8rIV/3l4ZGqM00ama?= =?us-ascii?Q?+aM6g2pjTNzScmaftfMXLY57OpEJzixI/Kbrsuupc+EelwuJzFl5dZT1Ap7+?= =?us-ascii?Q?J5TA7/7ReZTFwoaCqstgwsAH?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3021 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: c67bd563-23c0-4d1b-287b-08d8e95260e7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1lZgr++LJ3yn5fvFtnS93wV3cp0xWA0F3mQ3wwmTC5o5bkEHHA/9tOVncHHW2AKwR5YRKFwCyucSCWyXtvluiqb1CKjlCt1Ifpz4RPNp5ES/ULeYE8Gd1b5WiR4zcdlO15yg49CjCO0j9KuqT2iGg+8Io8Vdd7CUPcOfuh0Dn6bpkhW9DF3JstO6BYaLvqZfzUe9eF7N6nbVkKVC9E4W362+lyAWUhT7+ucNKRL6nt0PuQMTTZOiQiBfxHxp9c8eURo0LxlJEO/0x8XbUZa6A/XKYM+NkIVBciuytH96z3752irqRYqDZ6XLUMrN8zdM4YpOs5xnPEJANUtREHFPkLYdE4xCLJSKG7/Se6DgXyzbXeDjL4YccLVzAkQWHZUUvBIrnE5Loi9XQTJKYhOnuSf7gZYAOeYSxkkLdieDspvwVxM6IRnUFV/rHmKz5XPtMKyJNPtSxvecXyx6yAhKbtxzYDWyx3thhSQ2lnz1MwNoj9AETY5He8DkEUXgkB3Jdz6eFuAcFSETnQz387SAYTT4hn+bw42Mnnnxm0WksMFBi2Zp+PurZt8sR56a09Z4x8YGnhmlVcNReBnjBMDfU66hG3HeR0c1SMLqYlo4lKzzZ3O+VyCU1lQveV5VnNytRISXuOlNotL/6a69P7/w98F56DQ0TAneRDLFh0YMVSM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(36840700001)(46966006)(8676002)(55236004)(2906002)(6512007)(478600001)(107886003)(316002)(5660300002)(70586007)(356005)(70206006)(2616005)(53546011)(81166007)(54906003)(4326008)(8936002)(6506007)(6486002)(82310400003)(26005)(82740400003)(33656002)(36860700001)(186003)(86362001)(47076005)(36756003)(83380400001)(6862004)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 14:38:59.6366 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 19e7f20b-3796-4352-8e57-08d8e952670b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6093 Hi Julien, > On 13 Mar 2021, at 16:06, Julien Grall wrote: >=20 > From: Julien Grall >=20 > In a follow-up patch we may want to automatically replace some > mnemonics (such as ret) with a different sequence. >=20 > To ensure all the assembly files will include asm/macros.h it is best to > automatically include it on single assembly. This can be done via > config.h. >=20 > It was necessary to include a few more headers as dependency: > - to define sizeof_* > - which is already a latent issue given STACK_ORDER > rely on PAGE_SIZE. >=20 > Unfortunately the build system will use -D__ASSEMBLY__ when generating > the linker script. A new option -D__LINKER__ is introduceed and used for > the linker script to avoid including headers (such as asm/macros.h) that > may not be compatible with the syntax. >=20 > Lastly, take the opportunity to remove both asm/asm-offsets.h and > asm/macros.h from the various assembly files as they are now > automagically included. >=20 > Signed-off-by: Julien Grall Everything is now building :-) I could not find a better then your define as filtering out or undefining _= _ASSEMBLY__ is actually not working. So with the fix from offset to defns: Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/Makefile | 2 +- > xen/arch/arm/arm32/entry.S | 1 - > xen/arch/arm/arm32/head.S | 1 - > xen/arch/arm/arm32/proc-v7.S | 1 - > xen/arch/arm/arm64/debug-cadence.inc | 1 - > xen/arch/arm/arm64/debug-pl011.inc | 2 -- > xen/arch/arm/arm64/entry.S | 2 -- > xen/arch/arm/arm64/head.S | 2 -- > xen/arch/arm/arm64/smc.S | 3 --- > xen/include/asm-arm/config.h | 6 ++++++ > 10 files changed, 7 insertions(+), 14 deletions(-) >=20 > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index 16e6523e2cc6..9ffc3f771c51 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -135,7 +135,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c > $(CC) $(filter-out -flto,$(c_flags)) -S -o $@ $< >=20 > xen.lds: xen.lds.S > - $(CPP) -P $(a_flags) -MQ $@ -o $@ $< > + $(CPP) -P $(a_flags) -D__LINKER__ -MQ $@ -o $@ $< >=20 > dtb.o: $(CONFIG_DTB_FILE) >=20 > diff --git a/xen/arch/arm/arm32/entry.S b/xen/arch/arm/arm32/entry.S > index b228d44b190c..f2f1bc7a3158 100644 > --- a/xen/arch/arm/arm32/entry.S > +++ b/xen/arch/arm/arm32/entry.S > @@ -1,4 +1,3 @@ > -#include > #include > #include > #include > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S > index c404fa973e9b..9084023a6ed9 100644 > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -18,7 +18,6 @@ > */ >=20 > #include > -#include > #include >=20 > #define ZIMAGE_MAGIC_NUMBER 0x016f2818 > diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S > index 46bfc7a9074c..1efde2d72da0 100644 > --- a/xen/arch/arm/arm32/proc-v7.S > +++ b/xen/arch/arm/arm32/proc-v7.S > @@ -17,7 +17,6 @@ > * GNU General Public License for more details. > */ >=20 > -#include > #include > #include >=20 > diff --git a/xen/arch/arm/arm64/debug-cadence.inc b/xen/arch/arm/arm64/de= bug-cadence.inc > index 7df0abe4756f..0b6f2e094e18 100644 > --- a/xen/arch/arm/arm64/debug-cadence.inc > +++ b/xen/arch/arm/arm64/debug-cadence.inc > @@ -17,7 +17,6 @@ > * GNU General Public License for more details. > */ >=20 > -#include > #include >=20 > /* > diff --git a/xen/arch/arm/arm64/debug-pl011.inc b/xen/arch/arm/arm64/debu= g-pl011.inc > index 385deff49b1b..1928a2e3ffbb 100644 > --- a/xen/arch/arm/arm64/debug-pl011.inc > +++ b/xen/arch/arm/arm64/debug-pl011.inc > @@ -16,8 +16,6 @@ > * GNU General Public License for more details. > */ >=20 > -#include > - > /* > * PL011 UART initialization > * xb: register which containts the UART base address > diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S > index 175ea2981e72..ab9a65fc1475 100644 > --- a/xen/arch/arm/arm64/entry.S > +++ b/xen/arch/arm/arm64/entry.S > @@ -1,6 +1,4 @@ > -#include > #include > -#include > #include > #include > #include > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 5d44667bd89d..fa7a3ffd2926 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -21,11 +21,9 @@ > */ >=20 > #include > -#include > #include > #include > #include > -#include >=20 > #define PT_PT 0xf7f /* nG=3D1 AF=3D1 SH=3D11 AP=3D01 NS=3D1 ATTR=3D11= 1 T=3D1 P=3D1 */ > #define PT_MEM 0xf7d /* nG=3D1 AF=3D1 SH=3D11 AP=3D01 NS=3D1 ATTR=3D11= 1 T=3D0 P=3D1 */ > diff --git a/xen/arch/arm/arm64/smc.S b/xen/arch/arm/arm64/smc.S > index b0752be57e8f..91bae62dd4d2 100644 > --- a/xen/arch/arm/arm64/smc.S > +++ b/xen/arch/arm/arm64/smc.S > @@ -13,9 +13,6 @@ > * GNU General Public License for more details. > */ >=20 > -#include > -#include > - > /* > * void __arm_smccc_1_0_smc(register_t a0, register_t a1, register_t a2, > * register_t a3, register_t a4, register_t a5, > diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h > index 5c10c755db46..51273b9db1fc 100644 > --- a/xen/include/asm-arm/config.h > +++ b/xen/include/asm-arm/config.h > @@ -69,6 +69,7 @@ > #endif >=20 > #include > +#include >=20 > /* > * Common ARM32 and ARM64 layout: > @@ -190,6 +191,11 @@ extern unsigned long frametable_virt_end; > #define watchdog_disable() ((void)0) > #define watchdog_enable() ((void)0) >=20 > +#if defined(__ASSEMBLY__) && !defined(__LINKER__) > +#include > +#include > +#endif > + > #endif /* __ARM_CONFIG_H__ */ > /* > * Local variables: > --=20 > 2.17.1 >=20 From xen-devel-bounces@lists.xenproject.org Wed Mar 17 14:46:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 14:46:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98729.187438 (Exim 4.92) (envelope-from ) id 1lMXRM-0005LZ-50; Wed, 17 Mar 2021 14:46:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98729.187438; Wed, 17 Mar 2021 14:46:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXRM-0005LS-28; Wed, 17 Mar 2021 14:46:28 +0000 Received: by outflank-mailman (input) for mailman id 98729; Wed, 17 Mar 2021 14:46:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXRK-0005LN-As for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 14:46:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXRJ-0008Ac-QI for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 14:46:25 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lMXRJ-0004XA-Nt for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 14:46:25 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lMXRF-0002GD-3v; Wed, 17 Mar 2021 14:46:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=Srs2h+RYvR2DBEbDO90F2mqfb3rlxgh8NiI51hYMaPY=; b=GvgoNtdXGzJfwhhidlA0l/bbTg eGiDUF8N0CjmwBLycoANKWFv3IjbBLR9RhsJw2UVfpvo1ydnMA2ds/QjVUE3ur5fXyEBgBlVP3cRr DyL5y0PtiopezlD8IL5r1rnAr7wwIaVpVgRjwGmnH3YG553UaZNDYrgg4asiFz8dEOP4=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24658.5692.932979.892439@mariner.uk.xensource.com> Date: Wed, 17 Mar 2021 14:46:20 +0000 To: Andrew Cooper Cc: Roger Pau =?iso-8859-1?Q?Monn=E9?= , Xen-devel , Jan Beulich , Wei Liu , Boris Ostrovsky Subject: Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" In-Reply-To: <4b1c13ee-f121-3379-6fb3-c0d4dbb76e48@citrix.com> References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> <24658.1583.601613.903527@mariner.uk.xensource.com> <4b1c13ee-f121-3379-6fb3-c0d4dbb76e48@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()""): > On 17/03/2021 13:37, Ian Jackson wrote: > > AFAICT there is no explanation for why patches 1/ and 2/ deserve to go > > into 4.15. I see now, rereading the thread, that there was a sentence about this in each patch betwen the commit message and the diff. Sorry for missing that. (Although TBH at least one of those messages could usefully have gone into the commit message, as useful motivational background.) > > We are late in the freeze now, so I would ideally be > > looking for a clear and compelling argument. I'd also like to > > understand what the risks are of taking these. Can someone please > > enlighten me ? > > To make the code in 4.15 match 4.14, so patch 3 can be written in the > first place. > > Also, as a side benefit, patches 1 and 2 reduce the quantity of logspew > from the impacted MSRs. > > We cannot simply take patch 3 as-is, and say "4.14 and earlier" for > backport, because that still forces end users to specify msr_relaxed to > unbreak their Solaris guests, which is usability regression vs 4.14 This is plausible and going in the right direction but I still feel uncertain. Jan, what is your summary opinion about patch 3 ? Roger, can I get your opinion about the possible downside risks of this patch ? Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 14:55:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 14:55:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98732.187451 (Exim 4.92) (envelope-from ) id 1lMXZz-0006Jj-2q; Wed, 17 Mar 2021 14:55:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98732.187451; Wed, 17 Mar 2021 14:55:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXZy-0006Jc-UE; Wed, 17 Mar 2021 14:55:22 +0000 Received: by outflank-mailman (input) for mailman id 98732; Wed, 17 Mar 2021 14:55:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXZx-0006JX-Ja for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 14:55:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXZx-0008Ji-Ga for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 14:55:21 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lMXZx-00055F-Cc for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 14:55:21 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lMXZs-0002Hj-Ku; Wed, 17 Mar 2021 14:55:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=Lppww/5fj3La1xHnXVfpjZMCX9yQLxDR3gk9pptxD4U=; b=ckdpDKPsP42KCltCnbYxZ81qDj fR9jmOH8YTveJfHFTJ35KopmDHljf7+ytoOtcP7DAYt3jKM+0CE7XoDy/zks9vzM8QWfLG4Qi0btv QUQj8Y4GjqaiumrB+ldVzbnwx5eduBBwp+Ld4BBB9E5ylGfOJs5J5hiSItIdEijvItpI=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24658.6228.390535.850901@mariner.uk.xensource.com> Date: Wed, 17 Mar 2021 14:55:16 +0000 To: Julien Grall Cc: Jan Beulich , "xen-devel\@lists.xenproject.org" , Stefano Stabellini , George Dunlap , Wei Liu , Anthony Perard Subject: Call for tools backports (was Re: preparations for 4.13.3) In-Reply-To: References: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("Re: preparations for 4.13.3"): > On 08/03/2021 09:49, Jan Beulich wrote: > > All, > > > > the release is overdue (my apologies). Please point out backports > > you find missing from the respective staging branches, but which > > you consider relevant. > > > Ones that I have queued already, but which hadn't passed the push > > gate to master yet when doing a swipe late last week, are > > > > c6ad5a701b9a crypto: adjust rijndaelEncrypt() prototype for gcc11 > > 9318fdf757ec x86/shadow: suppress "fast fault path" optimization without reserved bits > > 60c0444fae21 x86/shadow: suppress "fast fault path" optimization when running virtualized > > I would like to also consider the following one: > > 28804c0ce9fd SUPPORT.MD: Clarify the support state for the Arm SMMUv{1, > 2} drivers (4.11+ as updating the security support) > 067935804a8e xen/vgic: Implement write to ISPENDR in vGICv{2, 3} (4.13+) > To support newer kernel on stable Xen > d81133d45d81 xen/arm: Add workaround for Cortex-A53 erratum #843419 (4.13+) > fd7479b9aec2 xen/arm: Add workaround for Cortex-A55 erratum #1530923 (4.13+) > 5505f5f8e7e8 xen/arm: Add Cortex-A73 erratum 858921 workaround (4.13+) > 63b4c9bfb788 xen/arm: mm: Access a PT entry before the table is unmapped > (4.13 only) > f6790389613c xen/arm: sched: Ensure the vCPU context is seen before > vcpu_pause() returns (4.13 only) > > I have put in parentheses the list of versions targeted. My backport list seems to have very few tools patches on it. If anyone has any tools bugfixes that ought to go into 4.13 please do let me know! Additionally, perhaps this one commit to be backported ? 935e0836710ce8cab584155b2844cea8497a5159 arm: replace typeof() with __typeof__() Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 14:56:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 14:56:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98735.187463 (Exim 4.92) (envelope-from ) id 1lMXbF-0006Ro-Bh; Wed, 17 Mar 2021 14:56:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98735.187463; Wed, 17 Mar 2021 14:56:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXbF-0006Rh-8Y; Wed, 17 Mar 2021 14:56:41 +0000 Received: by outflank-mailman (input) for mailman id 98735; Wed, 17 Mar 2021 14:56:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXbE-0006Rc-9P for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 14:56:40 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown [40.107.21.60]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6f17cd48-49aa-4500-892f-2ccfecd364da; Wed, 17 Mar 2021 14:56:37 +0000 (UTC) Received: from MR2P264CA0172.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::11) by AM6PR08MB4600.eurprd08.prod.outlook.com (2603:10a6:20b:84::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Wed, 17 Mar 2021 14:56:34 +0000 Received: from VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:501:0:cafe::5) by MR2P264CA0172.outlook.office365.com (2603:10a6:501::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Wed, 17 Mar 2021 14:56:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT012.mail.protection.outlook.com (10.152.18.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Wed, 17 Mar 2021 14:56:33 +0000 Received: ("Tessian outbound 26664f7d619a:v87"); Wed, 17 Mar 2021 14:56:33 +0000 Received: from 57935c781b62.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C6B8F8D6-3D09-4F18-A609-951C8A2207BF.1; Wed, 17 Mar 2021 14:56:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 57935c781b62.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 17 Mar 2021 14:56:26 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VI1PR08MB5501.eurprd08.prod.outlook.com (2603:10a6:803:138::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Wed, 17 Mar 2021 14:56:25 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3933.032; Wed, 17 Mar 2021 14:56:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f17cd48-49aa-4500-892f-2ccfecd364da DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RlbL7v8bpY9VAQR/1LAtAHwMNa+Ynp8uqeKiEXogAXo=; b=9fwFWgk1qfGZ6bMZ+IluecLPu5TZ7HhenWJscrTU8vKlV37YjB7y6NObKK4vAkjHDJRuUD8D+6n7S1+EEWJoFzf3XRB906HFv4dCA4HURkzx68B3M0LnQWTOGpw1pJTy9Z0rakT8i45obZsoY4kEBPSy6+cLZWMpK33+qmE9378= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 9d245bf465aaa8ea X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L3oac2ajcMGQygxs8Vdi2pMuovluolsT+nJbKUeGLtSkCWmFvZfKTjU5DZwh/WxuKFvN8e9QRvWK+0QiqCsP3hCaF4O+9/4JbN5MD25NbdbEu1xboFFgLafCckEfX5FWlgxvfrxNiKTxlAJ2QHMj1Os9w411hGvRob9K3hzODlc2kxVMXBPysvjvZTnj+Y38Y1P9s1LjCWgGT79sRlVh9MvJNOO1oRS9bTyheZMZXFPxnINuvMNGOrKREE8OivbuNrTBXQCL+i2uycOZv6aYbWwkKJnlWJ9OVIoCFCYcB3VU5pzbZBCq0dBL+n1t534woQNCybSOBUeyw24LAJNMrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RlbL7v8bpY9VAQR/1LAtAHwMNa+Ynp8uqeKiEXogAXo=; b=J4ddzLOeIrVvLqwr2XMrI1S2fRy1KA4bA6HbuyIDik5SIns9xkCljgDvHljjsyMS1P17ugqmQk482yg4WoexCjMPM1B4uZWeU9AUp8dvlCMGeu4y0z/4tgWiCNbbZgyph9lDzxg/wExeSEcJRiTmprbcOn8uRiv3W+XtBattRLc7Ea9y/EqBN30sCJECfdCj1KOYXWm8exkI3Di/VlvZMQtcgO871bd1qmlzphWmu/9lxbq7UalgRcuT9gpCQblo4u/tHVyxXfc5NbqB9GUi1X6z6H+Nq77W4RGFnmTtSxOfWEIK2MGR3AWTyKQh69YhBi6FRR+vw9Mgfg2R3TopRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RlbL7v8bpY9VAQR/1LAtAHwMNa+Ynp8uqeKiEXogAXo=; b=9fwFWgk1qfGZ6bMZ+IluecLPu5TZ7HhenWJscrTU8vKlV37YjB7y6NObKK4vAkjHDJRuUD8D+6n7S1+EEWJoFzf3XRB906HFv4dCA4HURkzx68B3M0LnQWTOGpw1pJTy9Z0rakT8i45obZsoY4kEBPSy6+cLZWMpK33+qmE9378= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH for-next v2 2/2] xen/arm64: Place a speculation barrier following an ret instruction Thread-Topic: [PATCH for-next v2 2/2] xen/arm64: Place a speculation barrier following an ret instruction Thread-Index: AQHXGCLUePNZXth41EOpDgjR62uDxqqISyAA Date: Wed, 17 Mar 2021 14:56:25 +0000 Message-ID: References: <20210313160611.18665-1-julien@xen.org> <20210313160611.18665-3-julien@xen.org> In-Reply-To: <20210313160611.18665-3-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.26.33.241] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 671c925a-e118-446c-d86d-08d8e954db68 x-ms-traffictypediagnostic: VI1PR08MB5501:|AM6PR08MB4600: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GvVRwn7qDlYf3D0hEvnlLwYmLrwW4+9KYNQMnfojlFa1nN3K6s9z1hmMEyKl9Ou5A2KijaOBajVUpzKUmg9NnFnWQoRLLMEsfWvULbJggosx5pQP9jR9K4ZiZsAzhU8fK2gji3N1jAzQilEOWSyO4g/Q+ovGvHxdEGkJaF8eEMII2wnT+Ewp3d7VQo6JA5IRfueXDC+v1QN19jDgbWcVzPiXL6HdBE/aa8DfL7Q6msa8syy93VqcXG9tsE1EkYOM+mUDyGWXDKu70+lVSWZMVWtvT4tN8wu9hnrNwybVnDNoboTK8iMqflnSLgj0Euizl8fB2BBInnl4oWwdtpssiJFE13sUauzNbPaFSeUC6qfPKkmFUg4PvxS5QR1VL8c8dbbOXKtwCxIsF+l/z7OKuA4BsndK12PSUJb+TUpuQ5XSOGAp9hkBUoaTsGCDWqUbQ7sboT2Taw9pylAvn81jRj1brULpKYepgxg6fpLQEddJs3BSSpdTqjrVJIZpXbU/sWFXioCIsMqpPIpjQyOAW6EkonuT5/u3PKwmQG88e8ZSnEt7MVxuiEPocRJBIWOk9x8+gIOReiXInnYB78zGLS7k2xqyv3F85VJaAWF0AuVhVnH5A8QHRtdRlIoP773WsJrxPSGh4zOs95uGzd9jcA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(8676002)(26005)(6506007)(8936002)(54906003)(53546011)(2616005)(33656002)(2906002)(478600001)(186003)(86362001)(4326008)(83380400001)(6916009)(316002)(55236004)(71200400001)(6512007)(5660300002)(36756003)(66946007)(64756008)(66446008)(66476007)(66556008)(76116006)(91956017)(6486002)(21314003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?DpOJVkwQ3JtIUq1fy0ST/xXsPl2P6Z0c2H4EF26GZ7joXofjPbH4SyBZrnCg?= =?us-ascii?Q?f7Z8c9CnYGH8nlZdQ1BvY42QFpV5fCIhRgxP7Mpzeb/gAdrIUU5LoflqW34x?= =?us-ascii?Q?PJIxW1nXnlvssKSjuwVFdTbw9nBFK4qC3txfTFQWzOXuPH9HrLI2qVMXRPid?= =?us-ascii?Q?tQu0rTjty+tlSkvWURvp+GSprgfKTBEoeDvwXRlRa+9Vg/P0XcxQJRB0TVFs?= =?us-ascii?Q?DOEw2VE12J8z6/0/DBj9mhJ1sJXVgzKxTven/bNeJ/rngBQ7ddZWYchE95WP?= =?us-ascii?Q?JrwPvx4cHMp3pE3Nq+klWGcHNO1GywOCd8UEW9rm1k5tK5VNRI3IIPXvQ4pi?= =?us-ascii?Q?xTbg/uVgFSyD/9Ep8yxElawZxgcxkE5S1sSfpfIn/kcQJ6QrjULK68/xXxbh?= =?us-ascii?Q?Ky/0aM/lZktPUS8GxBGmD2xLTPw1UVQU2hDb/ezo3UpJGS1MJpacV8HdPAMh?= =?us-ascii?Q?2jJ2B908FNTWcgrC62XGi9yawEIaV4RGucniq/Srop8Dh1lE1UryV5mYPTT3?= =?us-ascii?Q?kIN+KLG1qtJTXHeG61BGlwvmolnvqMA/yrpBrbMolQnvUelMI0ylXpa98Smq?= =?us-ascii?Q?eN11BkvkSrKOx/1ZGzgxMA1NVnzL5cK/6Teiza7eD0FD0SdpRLGCnj4W62jt?= =?us-ascii?Q?5NXG0kem+B2vBAoCOCPVkjqgvc49T0p8ffz4Ea8fjEBznYH6N4sL4mUTPbWR?= =?us-ascii?Q?Xvj7ZjJLsKOZIRyx8WVBEK1sFXpM7ne3AK065Dzaq89ALDw6JZ5t7WCIblUv?= =?us-ascii?Q?wo9yttuBkKa4vRynaAdZGAEDILYoIgDa0pSyfnion+VPcbZThWbTx0xBIoTp?= =?us-ascii?Q?oDbFkL14IKFXAKcX585jcQN93rIJItKBbuFziARo7laCNNug8n2QC6pCXCaK?= =?us-ascii?Q?1jMKkUQg5e0AxADLb85tVxxRni3awaUj/1+hKk3mQlRMwBQE05gr2SeA31rj?= =?us-ascii?Q?BYeyOOcrl7rQ1jhAvYaFPNNuku7s6dtKE4wHo3OoLcrQjnnwiGmZzhJB61PI?= =?us-ascii?Q?nQZ4n6foiHt/LAjZlhuSejuxC1tvi54qQlweHDPfPRkAcCk29O5EnLCaV3SZ?= =?us-ascii?Q?hTVPKD11wY/tgpimbN0ByNM0iUtIwYSN/Z1SN3+dCwULHQ5sT16z5OPTw5xI?= =?us-ascii?Q?Q/tRVGWTKLmMPQkJ4OJE5EwI4yIzJWcvCV3aenvbs+6ABF+C8peHs3la/har?= =?us-ascii?Q?XlHjxvS1O4rhuK7psvofClsfgLMvEYhS56hiz29rvJ2rwRIeEFqzPBgWrDF/?= =?us-ascii?Q?Kts5gCXoYr920iKh3o4G2yJajXGr1HuaSPJqdZ15UsQetY3U5wskS0qIOnZk?= =?us-ascii?Q?r2HLwoiPg6+ZwKyqmUHmKMYW?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <0FB0C4D73A0D384AB3CD92959E787F3D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5501 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 34d1c221-cebb-485c-cce6-08d8e954d66d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ga61WpWIPQZYWo/RBEvxZcD/YIU27pllrTyC7Hd8IKi6CjOQ2NSaGuAo1hpiL/H2IhdcuOsJZp/3PM9LEjef7bTIcUPTdez5Dzp90RJfGjD0rd34uohg3zvvOZYm8HG9Hrp5Ro3jdDKfgZq8v8FeaNRBbxCtuQyJwGPNNG+QbGiY5QvGH348W1nzJbIZZ+o+ZByBUwW6T12oxIzEExfjp4zImbIoSms57JnGpqH/gRG8fDSUSQ/9vDCS3Nbt+vaZbTjUXqTHuaMtdwobNZPqCPJUDvC0zc0uiAsXhQ8nbdyPzUz5jB6+fGU2QQDSNw4Z370K9Qx6hgWHoR5cGmVaeCKSQKpMDfsU1mMho+dzN0DuCxyWK5B6aJ5zvlNbiMoz8XryNx9fMWKiAvj+s/sTVxdLLbvn1qBOaczjQOpALrUxwpNcSAIxI3fhAkke7JvVXLF1Ju9pJVJ1AMivDuDO5rcxJ8FLG/XadJdApjyzggrRZ90WV30WPYSTXYmDZYDJ4IfLAYGpc5625cKLoMiNw+qRucP0BmpIXCTBv+2hhe5LKfh/uqhSwa4nnzoY/njA2KNWUuP2zBCkeKlHC53b/1CK717zTOZE1JJy+j1c06P3uNY2CdWitwa6UC7YhCKUcaQROJFari/SKW/ZruU5Mv8LsxYWlr3LfuoGLwAXBIzgqXUsQCWBz7wKDJPeIex5 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(346002)(39860400002)(136003)(376002)(46966006)(36840700001)(2616005)(70586007)(6506007)(55236004)(82740400003)(54906003)(2906002)(5660300002)(53546011)(70206006)(33656002)(81166007)(83380400001)(8936002)(8676002)(6512007)(6486002)(36860700001)(26005)(47076005)(82310400003)(356005)(316002)(36756003)(86362001)(107886003)(478600001)(6862004)(336012)(4326008)(186003)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 14:56:33.9261 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 671c925a-e118-446c-d86d-08d8e954db68 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4600 Hi Julien, > On 13 Mar 2021, at 16:06, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Some CPUs can speculate past a RET instruction and potentially perform > speculative accesses to memory before processing the return. >=20 > There is no known gadget available after the RET instruction today. > However some of the registers (such as in check_pending_guest_serror()) > may contain a value provided by the guest. >=20 > In order to harden the code, it would be better to add a speculation > barrier after each RET instruction. The performance impact is meant to > be negligeable as the speculation barrier is not meant to be > architecturally executed. >=20 > Rather than manually inserting a speculation barrier, use a macro > which overrides the mnemonic RET and replace with RET + SB. We need to > use the opcode for RET to prevent any macro recursion. >=20 > This patch is only covering the assembly code. C code would need to be > covered separately using the compiler support. >=20 > This is part of the work to mitigate straight-line speculation. >=20 > Signed-off-by: Julien Grall The macro solution is definitely a great improvement compared to v1 and I c= ould confirm the presence of the sb in the generated code. I also think that the mitigation on arm32/v7 would be messy to do. Shall we mark v7/aarch32 as not security supported ? Apart from this global question (which does not need to be answered in this= serie): Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 > --- >=20 > It is not clear to me whether Armv7 (we don't officially support 32-bit > hypervisor on Armv8) is also affected by straight-line speculation. >=20 > But the mitigation is a lot messier because opcode can be optionally > executed. So this Arm32 is left alone for now. >=20 > Changes in v2: > - Use a macro rather than inserting the speculation barrier > manually > - Remove mitigation for arm32 > --- > xen/arch/arm/arm32/entry.S | 1 + > xen/arch/arm/arm32/lib/lib1funcs.S | 1 + > xen/include/asm-arm/arm64/macros.h | 6 ++++++ > xen/include/asm-arm/macros.h | 18 +++++++++--------- > 4 files changed, 17 insertions(+), 9 deletions(-) >=20 > diff --git a/xen/arch/arm/arm32/entry.S b/xen/arch/arm/arm32/entry.S > index f2f1bc7a3158..d0a066484f13 100644 > --- a/xen/arch/arm/arm32/entry.S > +++ b/xen/arch/arm/arm32/entry.S > @@ -441,6 +441,7 @@ ENTRY(__context_switch) >=20 > add r4, r1, #VCPU_arch_saved_context > ldmia r4, {r4 - sl, fp, sp, pc} /* Load registers and ret= urn */ > + sb >=20 > /* > * Local variables: > diff --git a/xen/arch/arm/arm32/lib/lib1funcs.S b/xen/arch/arm/arm32/lib/= lib1funcs.S > index f1278bd6c139..8c33ffbbcc4c 100644 > --- a/xen/arch/arm/arm32/lib/lib1funcs.S > +++ b/xen/arch/arm/arm32/lib/lib1funcs.S > @@ -382,5 +382,6 @@ UNWIND(.save {lr}) > bl __div0 > mov r0, #0 @ About as wrong as it could be. > ldr pc, [sp], #8 > + sb > UNWIND(.fnend) > ENDPROC(Ldiv0) > diff --git a/xen/include/asm-arm/arm64/macros.h b/xen/include/asm-arm/arm= 64/macros.h > index f981b4f43e84..4614394b3dd5 100644 > --- a/xen/include/asm-arm/arm64/macros.h > +++ b/xen/include/asm-arm/arm64/macros.h > @@ -21,6 +21,12 @@ > ldr \dst, [\dst, \tmp] > .endm >=20 > + .macro ret > + // ret opcode > + .inst 0xd65f03c0 > + sb > + .endm > + > /* > * Register aliases. > */ > diff --git a/xen/include/asm-arm/macros.h b/xen/include/asm-arm/macros.h > index 4833671f4ced..1aa373760f98 100644 > --- a/xen/include/asm-arm/macros.h > +++ b/xen/include/asm-arm/macros.h > @@ -5,6 +5,15 @@ > # error "This file should only be included in assembly file" > #endif >=20 > + /* > + * Speculative barrier > + * XXX: Add support for the 'sb' instruction > + */ > + .macro sb > + dsb nsh > + isb > + .endm > + > #if defined (CONFIG_ARM_32) > # include > #elif defined(CONFIG_ARM_64) > @@ -20,13 +29,4 @@ > .endr > .endm >=20 > - /* > - * Speculative barrier > - * XXX: Add support for the 'sb' instruction > - */ > - .macro sb > - dsb nsh > - isb > - .endm > - > #endif /* __ASM_ARM_MACROS_H */ > --=20 > 2.17.1 >=20 From xen-devel-bounces@lists.xenproject.org Wed Mar 17 15:07:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 15:07:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98740.187475 (Exim 4.92) (envelope-from ) id 1lMXla-0007UL-IT; Wed, 17 Mar 2021 15:07:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98740.187475; Wed, 17 Mar 2021 15:07:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXla-0007UE-EU; Wed, 17 Mar 2021 15:07:22 +0000 Received: by outflank-mailman (input) for mailman id 98740; Wed, 17 Mar 2021 15:07:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXlY-0007U9-Lb for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 15:07:21 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4b0ac4cd-9f40-47f1-b25c-2155bf93ee69; Wed, 17 Mar 2021 15:07:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b0ac4cd-9f40-47f1-b25c-2155bf93ee69 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1615993639; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=fwoVPiTMsI7OQJjVUsU8lIr/aJr3effL5BzkN3VeDQs=; b=PaRrtb0Y0G4eQZcshsey+T0IpcKe7NiASnDRNlfMqRsv3ZZrrzWqIBZ1 cnOD5Gkw8ANQlgWfUvu9tqAOIh2zZnWwT9v+EutkKduDajYY9WIxED7lU zHKHFUu/2+t3XkYOkRX+L0tVP95aiqhLlK95q8tj/hD/DjhjwBKJzA4WW 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: +Ih4W3uqsltdSwFX8LqTCdRL4YYtAUzOvPdTaNA2rHM4kE07YF7uOwOScB/gvGHBgF8RGP3Dj1 xsA8D8/1TtTnJV5pnnl0BaI02vvMNfl8tMAzjf+SfeEYED4nu4IOCk9IF4k9E2WN50yqQ9uS/I 7rzunycoJnClLkB1Hlt4eYIHNIF/ZWhRyKOX+NZck6DCYnT6s1bHFfvzos//VhufhcPpRYzwvl iOQ3IVCC7aCBTeR5ZKR/UWbBf1+19O4SUf9DNjqpST1+B5Fys+R4oF60IvGaJZ+W+Mni5Yg157 pZI= X-SBRS: None X-MesageID: 39869556 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:adv6WK8U8B2UnHEiE85uk+HWdb1zdoIgy1knxilNYDRIb8rdrd ykmPQHyBP44QxhP00Is9aGJaWGXDf4/Zl6/YEeMd6ZMjXOkm2uMY1k8M/e0yTtcheTysdx3b ptGpISNPTeFl5/5PyQ3CCZFJIazMCD4OSUg47lr0tFaSFPR+Ve4xxiCgCde3cfeCBjCYAiHJ SRouprzgDARV0tYs62BmYIUoH4zuHjr57obQULABQq8mC1/FCVwYTnGBuV1Ap2aUIq/Z4e8H PImwG8xqKvv+DT8G6460bv7o9bkNak991bBMbksLl2FhzQjG+TDrhJavmppzYuuti15FIrit XXghspMshp8VzQe3y4uhfh8Bnb3DEiwXnkzlOTnH35yPaJIg4SOo5kv8Z0YxHZ400vsJVZ3L hQ12yU87pMSTTMh03GiOTgZlVNjUS9pnowmfMSiXt/XYMSZKRKlJcS5k9PD5sMdRiKkbwaLA == X-IronPort-AV: E=Sophos;i="5.81,256,1610427600"; d="scan'208";a="39869556" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mlM2ym3KGO0CC3vngedBGvtkvUx9i8y46LYumqvkUH/XvAbSXJcmSgpXZ00Nfic38dgVZLdmvitzjICSUW9PQUl1oSSWCnzQTG/c1mwf6n74AqxGHiruk9H8WBAR3MRjaNwdagOZBXoA5TWsEJDePK7Eux/ynxXCq16v/VdI0fnbYMqjMWCx//JKEjrfbRggb5maS5CezNWpv0JznAkbL4DryqM076rIFR+hangAbIUKIq6neGQk85Rc8ptsv/4E0D5Pl5dU6OsDok+e3e8q7Jfx3VwAM2QdkHNLW0kpCJ36QVJhB2vguLUfIsD1knqlaMa0PfXXH5l24ove3ZESuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hsOO55P4euXDpj9CtiLi0erl2aPxZQ6WCsK+nCPuPWw=; b=QAotuKIVKWz6DrbCrBBioi+pL+Ms6w38o2LhLOoIXsdFdMBtLEgCJrO5fLLkAPprHm1B+MiX+YXhYd6vJWUyw8EA4Jvf4mmJAiZ267vYmRr9A8YaOdgz5j/R1D5yQ5X4VZlyVLMRKgz+F0NWexBalboxeQz/WqEh5cQDRt2UAEyPlOSX31NlbBOeCczCK5MvBAuv1dXQ/2+WtM2Tp7JAuJD7NNfIk9oTS6hyloScyVHq4etQGrl8rxQOHBt66/0D+WGVP8WWfCNrNKwBRZJn/lG6KQeEavACTywgEsnJxZRog0Pn7vo9M/rLbdzJNBPtmBXrMhFSnJTSa4vkGbl/ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hsOO55P4euXDpj9CtiLi0erl2aPxZQ6WCsK+nCPuPWw=; b=SoTJ6lFQ0ZgOctlIXVevUpvb6dfZKzniUJlcAw30DohHIJZveNcrN971RyAMrQbaXbn4hn9LOhUzLq9I4UCARJawQMkLs/DfauAFtRq1EcL9qM2JyTZ4FeulkSPRIHakljPHUsllVS6GlQoR3+SYC23ZJta2GNNoocR7LYiC7tE= Date: Wed, 17 Mar 2021 16:06:58 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ian Jackson CC: Andrew Cooper , Xen-devel , Jan Beulich , Wei Liu , Boris Ostrovsky Subject: Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" Message-ID: References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> <24658.1583.601613.903527@mariner.uk.xensource.com> <4b1c13ee-f121-3379-6fb3-c0d4dbb76e48@citrix.com> <24658.5692.932979.892439@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <24658.5692.932979.892439@mariner.uk.xensource.com> X-ClientProxiedBy: PR0P264CA0132.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1a::24) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f7eb9742-ec15-422e-de2f-08d8e9565378 X-MS-TrafficTypeDiagnostic: DM5PR03MB3211: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YD0I/jivxoPUeWExPFEAYv1HVA70ebsJbXPIMPJJYHwsFLdpGaK5OGmlO2lo9t6ClBDpTqNWzdXiKAC+cVp4DvH8AoWQrsT+IJ/a2JU/YyqUsg5wB23qyALONWzydLFxZVAX0K2Ff6RZBX93/KRiBBt+/t/9Gmo+wCUNQxq9O+JqnfH3SKxiaeIisFLkYKWTVpSvjLxqWkQ8ApXbpRGYRlnHfpOTuIoPwa6UGc5lTKQ3wHlafKbFgaUWGfiDmnMTmYmdcoGCMo22/vM+PoaoANvTdqx4YSrLSgYyG5DAn42lUfI9QugZvpdsQvovc3nCyX8iAfNQsWV2PUvlh2hT3XdL5hPliIUAj+q+vW3PC9s4kiNTZO3helpWZA/+tDdGW9DeQ2f0ej+N9vVPJM9+4U/jtzmob1EjljVMsGiyxzIPXNY1bLdY2AqvK2BI+bzHWQL7r5wha8s/fskhMOzLZ90neM/NuOX3qHEJRunx27Hco8Iau4+bQf3A4nc/amjTfRg99EzbkSzdGDpAy9aWppFmug4cXl/0/A+w22kexixvXaAe6Y0zjnY7DpbBekFW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(346002)(376002)(39860400002)(136003)(396003)(9686003)(6486002)(66556008)(26005)(6916009)(33716001)(2906002)(316002)(53546011)(83380400001)(16526019)(85182001)(6496006)(8936002)(478600001)(186003)(956004)(8676002)(54906003)(6666004)(4326008)(86362001)(66946007)(66476007)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UlpJTTRqSGV5cC9DTUdhWEc4K1dWc2ZIemNnVmlhRjQ2dEM2WVVIZ0lBNFJx?= =?utf-8?B?Q1pST2FwR0hRQUhEeG44OWFVSExUY3RoTVhnb3V3Mkh2M2VjbHFnZy9xSGQ3?= =?utf-8?B?RjdnY3VjejYrV0k5QWlqZFZzRENJV24rQVROK3NFaWRUYnllUDBieXpwT2hP?= =?utf-8?B?YmZsaWVlU0xNcFFxcUs4azZiZHVFOFpDQ3NiYTNKalhqS2FyN2s1ZUlXRTgy?= =?utf-8?B?blIyTWZVbU5VMFZSU3o5VTZsK0FMMnlDQXZJYlFKR2xwb0p2bmF6a2J1SHR3?= =?utf-8?B?c1g5Kzg4RUJwY1JGMGtlSVdyQlBuZ2p2NXhiKzV1cnFmd1NYdW9UUWVDOEc4?= =?utf-8?B?NmhtWjhRU2dFVllueVVCcVEwTlhhNTIzVUYrMGNHbnVpM2ozNmV0OGpQVWZY?= =?utf-8?B?cmdnSUF4cVJxOFFxNUo2UVBqZkJWblQ0VHY4Nnp4VnpuMjlSV1N1RlFZTVRz?= =?utf-8?B?SGtvcHM5c3pQSmhGRTR0bFVpakV6WmN1MFp0dExaNUlQTXZXNG5UT2pNaC9m?= =?utf-8?B?VzNUMkFORUlHL29YR0xnSzdlNHkrM2lJb0RFQTlhK1BGVWtOZDF6bFJpemZI?= =?utf-8?B?NlJ1ZUF3dzZOV3VNeEV1c1VpbFlQc0NPM3JSMElGbERlR3phZnRPcG5xTytp?= =?utf-8?B?Skwwa3ZHZktETGR5TWM5NEM2RGV6REVaOEE1YjRnUERwaHhQVWo2b1Foc1la?= =?utf-8?B?M1ZWZXI3UEE1czZhb1paRzJVWGdoVi85Z0I4aWZWY2VyME45Vm9iVG5paEpT?= =?utf-8?B?UUxnNlpPb1RNZXpNeFU2bEllOHZMQ1VwSmVGUVR6N05IU2xHNlFhVEkvL1hJ?= =?utf-8?B?UitCU3JJK0Q1UjFUVWs0SFArcjlxc2ViK2ZscWdITlV5U1Erc0xGWTVHU1hB?= =?utf-8?B?cDFGWnRwdjFicDg2QnlVNHI3dzJOcFlkMjY0a2Ryejc3UHVvcWQ5T0lMRnpH?= =?utf-8?B?NWNYU3NVeGk3U2pFV0pkVG84RTNxTnNicTVzRVNrb2wrMTlpWXRCakhjWnFW?= =?utf-8?B?MGQ0R1F5TVpVU3Z5bVc4Y1Jicktma1RTZmxBbUdqc1lLVndnU0pYOVlRcEx2?= =?utf-8?B?WURHejlJcy8xVmN4UWxMc0Zoam9tNTJFSVFwekhONDJ6R3JJS1hYTTBPUERF?= =?utf-8?B?OCthSjREVUxGM0Y3WGFqUEZTT2NVSUpGc0NqUFoyYkNUODdscitwbzRuOWo4?= =?utf-8?B?ZzNxRS9zd094ckc2N29YK05ZZmpiSTV0ZEJGem1sdE9BUmZvWmU1TExzTWJ3?= =?utf-8?B?aFRwelFBdEVUN1FBZEYxampMN1h5alhCMllFUEdMakRJK2pOUmhBY2RLbzJR?= =?utf-8?B?a1BEblpXUzJFdnFhYnNlbElBSHlLVXhCNWxEQ21ZeGFDc1FRRkpVb2RFRHkv?= =?utf-8?B?ZXBnei8xZm4xbGNwUDhxbDlwd3ZYaE1xM3VaVmVpRFFPSFNjVkZObldZTSt6?= =?utf-8?B?RERDSXFQUTZWYlVvZjVyMDU1Ylh1eWlGRDltQ09XdWZVY2hwVlJsSUR5VWha?= =?utf-8?B?UlhqdGNkL2NmUG9ESnBKdFRvNis0SUREa3FiNWRXcGZCWVdrYmZ4YmEycU5R?= =?utf-8?B?V2NlZ3BvbCtuMXdwV2tielE1VGNOdW9GUWY2Yy9CbUdRbWtoMkJwNVRiOWVJ?= =?utf-8?B?VTdCbnlhL1lYa3NOemJLZ2JKai9RcXFWbmNsRDVMY3d1cDRDalcxamV1aVpK?= =?utf-8?B?Y3kraWpXODBnOURrOFdLYlVOWFE1enA2eDhVRHJpNlh3K08wc2lIT0U5QkZs?= =?utf-8?Q?pEMyqk4v3MhK0WJ1zU7XiMcrWTdUoTb3b8stBQv?= X-MS-Exchange-CrossTenant-Network-Message-Id: f7eb9742-ec15-422e-de2f-08d8e9565378 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 15:07:05.1845 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pnUvGkCgNOCxEhM5Bczw/t0V/boghEyzSlVLtPq26peuRzdCYfadb3Dupfxblxcl5TJW0yjIjgORE9FLuDAtWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3211 X-OriginatorOrg: citrix.com On Wed, Mar 17, 2021 at 02:46:20PM +0000, Ian Jackson wrote: > Andrew Cooper writes ("Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()""): > > On 17/03/2021 13:37, Ian Jackson wrote: > > > AFAICT there is no explanation for why patches 1/ and 2/ deserve to go > > > into 4.15. > > I see now, rereading the thread, that there was a sentence about this > in each patch betwen the commit message and the diff. Sorry for > missing that. (Although TBH at least one of those messages could > usefully have gone into the commit message, as useful motivational > background.) > > > > We are late in the freeze now, so I would ideally be > > > looking for a clear and compelling argument. I'd also like to > > > understand what the risks are of taking these. Can someone please > > > enlighten me ? > > > > To make the code in 4.15 match 4.14, so patch 3 can be written in the > > first place. > > > > Also, as a side benefit, patches 1 and 2 reduce the quantity of logspew > > from the impacted MSRs. > > > > We cannot simply take patch 3 as-is, and say "4.14 and earlier" for > > backport, because that still forces end users to specify msr_relaxed to > > unbreak their Solaris guests, which is usability regression vs 4.14 > > This is plausible and going in the right direction but I still feel > uncertain. > > Jan, what is your summary opinion about patch 3 ? > > Roger, can I get your opinion about the possible downside risks of > this patch ? For patches 1 and 2 the risk is low I think. This is already the same handling that we do in pre-4.15, so it's unlikely to cause issues. >From a guests PoV they don't change the result of trying to access any of the modified MSRs, accessing them will still result in a #GP being injected to the guest. The main risk for patch 3 would be that reporting 0 for MSR_RAPL_POWER_UNIT would result in some kind of issue on certain guests, or that it triggers the poking of other MSRs in the expectation that they would be available. I think those are quite unlikely, and the patch fixes a real issue with Solaris guests. Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 15:13:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 15:13:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98743.187486 (Exim 4.92) (envelope-from ) id 1lMXr3-0008PO-6F; Wed, 17 Mar 2021 15:13:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98743.187486; Wed, 17 Mar 2021 15:13:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXr3-0008PH-3M; Wed, 17 Mar 2021 15:13:01 +0000 Received: by outflank-mailman (input) for mailman id 98743; Wed, 17 Mar 2021 15:12:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXr1-0008PC-Jr for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 15:12:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXr1-0000Ay-Hn for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 15:12:59 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lMXr1-0006Lk-Fo for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 15:12:59 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lMXqw-0002KP-Pd; Wed, 17 Mar 2021 15:12:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=Aw4H8mLfFfZz4bs1vDAoFr4gYg/s4oCojpI5o2UkSjU=; b=BWWCcrFenpzxAxGMuB1DABADVs i3ByjaDtLZghGcMtU0vEvYZJ/jdcV/vVbhjf/JbGVxHRExxNsNEdQAqrL2/xlwIZ4giwwBqiCS999 U/lsuFugoOPSUOi8zgWbIJZF95XEusKzTir9V1TM70y7J8Fh/veWlHoj8gNYUILy7AiQ=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24658.7286.533794.293151@mariner.uk.xensource.com> Date: Wed, 17 Mar 2021 15:12:54 +0000 To: =?iso-8859-1?Q?J=FCrgen_Gro=DF?= , Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Wei Liu , Anthony Perard , Boris Ostrovsky Subject: Re: libxl / xen-pciback interaction [and 1 more messages] In-Reply-To: , References: X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("libxl / xen-pciback interaction"): > while trying to test a pciback fix for how SR-IOV VFs get placed in the > guest PCI topology I noticed that my test VM would only ever see the 1st > out of 3 VFs that I passed to it. As it turns out, the driver watches > its own (backend) node, and upon first receiving notification it > evaluates state found in xenstore to set up the backend device. > Subsequently it switches the device to Initialised. After this switching, > not further instances of the watch triggering would do anything. This makes it sound like this driver does not support hotplug. > While doing this it also occurred to me as odd how "num_devs" is > actually used: It's not really a "number of devices" indicator, but > instead a "next device has this number" one: libxl reads the present > value and increments it by one for every new device. Destroying > (hot-unplugging) of devices doesn't have any effect on the value. But this makes it sound like the driver *does* support hotplug. How does what libxl is doing differ from a setup, immediately followed by a hot-add ? > If addition / removal of a device happens a number of times for a > VM, quite a few leftover, no longer used entries would accumulate > afaict. This isn't only consuming space in xenstore for no good > reason, but also means pciback has to do an increasing amount of > processing every time a reconfigure event happens. I'm kind of surprised that num_devs is used this way by the driver. I guess the obvious approach of just listing the directory to find the devices would often be accidentally-quadratic in the number of simultaneous PCI devices but that hardly seems like a problem. I wonder if there is some race/reuse hazard that would prevent libxl knowing when to reuse a dev number. Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 15:16:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 15:16:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98746.187499 (Exim 4.92) (envelope-from ) id 1lMXu1-00005v-NS; Wed, 17 Mar 2021 15:16:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98746.187499; Wed, 17 Mar 2021 15:16:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXu1-00005o-I3; Wed, 17 Mar 2021 15:16:05 +0000 Received: by outflank-mailman (input) for mailman id 98746; Wed, 17 Mar 2021 15:16:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXu0-00005i-95 for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 15:16:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMXu0-0000FI-8F for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 15:16:04 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lMXu0-0006VW-7W for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 15:16:04 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lMXtv-0002LQ-G4; Wed, 17 Mar 2021 15:15:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=Icv57Gp6+BsuyhEq7m+9iroCpbGX5bsczcoIxbrzdy0=; b=V/b9JJtVuvGr4f/gUd9NfoNgLW xqVPm76U1RM7393omizClVMCYYMA0Y9TyJuaVoN4Zf0l02mzio59CRngUlYDluwPmEQwteyiT+Z6g eNl9y8G5ducgfYI5CEaf62LmNweGIwNaJvfUWl4i+5ZdltFkP/FaDxOwwPszhmEZA4xs=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24658.7471.309734.168120@mariner.uk.xensource.com> Date: Wed, 17 Mar 2021 15:15:59 +0000 To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: Andrew Cooper , Xen-devel , Jan Beulich , Wei Liu , Boris Ostrovsky Subject: Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" In-Reply-To: References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> <24658.1583.601613.903527@mariner.uk.xensource.com> <4b1c13ee-f121-3379-6fb3-c0d4dbb76e48@citrix.com> <24658.5692.932979.892439@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monn writes ("Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()""): > On Wed, Mar 17, 2021 at 02:46:20PM +0000, Ian Jackson wrote: > > Roger, can I get your opinion about the possible downside risks of > > this patch ? > > For patches 1 and 2 the risk is low I think. This is already the same > handling that we do in pre-4.15, so it's unlikely to cause issues. > >From a guests PoV they don't change the result of trying to access any > of the modified MSRs, accessing them will still result in a #GP being > injected to the guest. > > The main risk for patch 3 would be that reporting 0 for > MSR_RAPL_POWER_UNIT would result in some kind of issue on certain > guests, or that it triggers the poking of other MSRs in the > expectation that they would be available. I think those are quite > unlikely, and the patch fixes a real issue with Solaris guests. Thanks. That is very helpful. All three patches Release-Acked-by: Ian Jackson but subject to Jan's questions on patch 3 being resolved somehow. Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 15:44:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 15:44:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98750.187511 (Exim 4.92) (envelope-from ) id 1lMYLS-0002p7-In; Wed, 17 Mar 2021 15:44:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98750.187511; Wed, 17 Mar 2021 15:44:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMYLS-0002p0-Eq; Wed, 17 Mar 2021 15:44:26 +0000 Received: by outflank-mailman (input) for mailman id 98750; Wed, 17 Mar 2021 15:44:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMYLQ-0002ov-I2 for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 15:44:24 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 25b9a652-8330-4a56-8551-2eec20f2b215; Wed, 17 Mar 2021 15:44:22 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E91BEAE53; Wed, 17 Mar 2021 15:44:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25b9a652-8330-4a56-8551-2eec20f2b215 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615995862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1hZjxPf3tQDtsQ35IKl5jQ5nhr0vTUqzjPVrG3qjetE=; b=XaC7+4xhCYFvlOUWNzHDcUZHCBB9MmBy+u/bMnPohAzUTyuwojA49JVABnlEYkftRgkZuw 3kvO8Bp7I1ko8SnhaVM2CtuhJrijdGzbzD7t0IUhW+jfuFy8tBEvD2ywikTHD0oWeyaBvf ExtGswRQEwjtRGQ136cB7BvGYab6Bc4= Subject: Re: libxl / xen-pciback interaction [and 1 more messages] To: Ian Jackson Cc: "xen-devel@lists.xenproject.org" , Wei Liu , Anthony Perard , Boris Ostrovsky , =?UTF-8?B?SsO8cmdlbiBHcm8=?= =?UTF-8?B?w58=?= References: <24658.7286.533794.293151@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <11bf64f2-401d-03cb-59d7-a84b5c56552e@suse.com> Date: Wed, 17 Mar 2021 16:44:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <24658.7286.533794.293151@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 17.03.2021 16:12, Ian Jackson wrote: > Jan Beulich writes ("libxl / xen-pciback interaction"): >> while trying to test a pciback fix for how SR-IOV VFs get placed in the >> guest PCI topology I noticed that my test VM would only ever see the 1st >> out of 3 VFs that I passed to it. As it turns out, the driver watches >> its own (backend) node, and upon first receiving notification it >> evaluates state found in xenstore to set up the backend device. >> Subsequently it switches the device to Initialised. After this switching, >> not further instances of the watch triggering would do anything. > > This makes it sound like this driver does not support hotplug. > >> While doing this it also occurred to me as odd how "num_devs" is >> actually used: It's not really a "number of devices" indicator, but >> instead a "next device has this number" one: libxl reads the present >> value and increments it by one for every new device. Destroying >> (hot-unplugging) of devices doesn't have any effect on the value. > > But this makes it sound like the driver *does* support hotplug. > > How does what libxl is doing differ from a setup, immediately followed > by a hot-add ? In the hot-add case libxl drives things through Reconfiguring state. I'm not sure this would be an appropriate (and backwards compatible) thing to do when initially populating xenstore. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 17 15:56:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 15:56:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98753.187523 (Exim 4.92) (envelope-from ) id 1lMYWX-0003oU-Jr; Wed, 17 Mar 2021 15:55:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98753.187523; Wed, 17 Mar 2021 15:55:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMYWX-0003oN-GO; Wed, 17 Mar 2021 15:55:53 +0000 Received: by outflank-mailman (input) for mailman id 98753; Wed, 17 Mar 2021 15:55:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMYWX-0003oI-4Y for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 15:55:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMYWX-0000t2-0h for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 15:55:53 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lMYWW-0000cF-Vm for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 15:55:52 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lMYWT-0002RV-O0; Wed, 17 Mar 2021 15:55:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=OQNfc1t/LhbslkH3XFWi8ft0jVggZWvGBzN/q0y6Gto=; b=JfjQQlfa0MRUR2mrOi/dxF+iIY 9t6pNILNem3hKEir0szDnRP5OI/K7SB+46bqSMCgM7pjS9LDvkbHllKhSrhDM0JjZ1U9EZcSPlbhJ IsHb5fIPmX6rbigYfMuZ6iYYClfAUHJLe1hFlqzH5ViL+3xybeD06/RCiNXN+uaqJaNo=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24658.9861.547014.443884@mariner.uk.xensource.com> Date: Wed, 17 Mar 2021 15:55:49 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Wei Liu , Anthony Perard , Boris Ostrovsky , =?iso-8859-1?Q?J=FCrgen_Gro=DF?= Subject: Re: libxl / xen-pciback interaction [and 1 more messages] In-Reply-To: <11bf64f2-401d-03cb-59d7-a84b5c56552e@suse.com> References: <24658.7286.533794.293151@mariner.uk.xensource.com> <11bf64f2-401d-03cb-59d7-a84b5c56552e@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: libxl / xen-pciback interaction [and 1 more messages]"): > On 17.03.2021 16:12, Ian Jackson wrote: > > How does what libxl is doing differ from a setup, immediately followed > > by a hot-add ? > > In the hot-add case libxl drives things through Reconfiguring state. > I'm not sure this would be an appropriate (and backwards compatible) > thing to do when initially populating xenstore. Ah. Tbanks, that is precisely the answer to my question. I think that means, therefore, populating the whole lot in one transaction. (From what you say it doesn't sound like it's possible to write only a subset, perhaps with state "not ready yet" and then set them all go "go" at the end.) Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 17:05:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 17:05:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98759.187535 (Exim 4.92) (envelope-from ) id 1lMZbh-0002Am-PW; Wed, 17 Mar 2021 17:05:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98759.187535; Wed, 17 Mar 2021 17:05:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMZbh-0002Af-MM; Wed, 17 Mar 2021 17:05:17 +0000 Received: by outflank-mailman (input) for mailman id 98759; Wed, 17 Mar 2021 17:05:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMZbg-0002Aa-Tu for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 17:05:17 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown [40.107.8.79]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d31074d9-9e0b-4819-8dfa-9dcceee74ed0; Wed, 17 Mar 2021 17:05:15 +0000 (UTC) Received: from AM4PR0202CA0013.eurprd02.prod.outlook.com (2603:10a6:200:89::23) by PAXPR08MB6944.eurprd08.prod.outlook.com (2603:10a6:102:135::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Wed, 17 Mar 2021 17:05:12 +0000 Received: from AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:200:89:cafe::3d) by AM4PR0202CA0013.outlook.office365.com (2603:10a6:200:89::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Wed, 17 Mar 2021 17:05:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT044.mail.protection.outlook.com (10.152.17.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Wed, 17 Mar 2021 17:05:12 +0000 Received: ("Tessian outbound 26664f7d619a:v87"); Wed, 17 Mar 2021 17:05:12 +0000 Received: from 83af946044a4.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B4C0D0EA-5E5C-46B2-89B3-F533C0067DF8.1; Wed, 17 Mar 2021 17:05:06 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 83af946044a4.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 17 Mar 2021 17:05:06 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) by VI1PR08MB4557.eurprd08.prod.outlook.com (2603:10a6:803:f5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Wed, 17 Mar 2021 17:05:04 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642]) by VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642%4]) with mapi id 15.20.3933.032; Wed, 17 Mar 2021 17:05:04 +0000 Received: from a75445.arm.com (82.8.129.65) by LO4P123CA0101.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Wed, 17 Mar 2021 17:05:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d31074d9-9e0b-4819-8dfa-9dcceee74ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sjoirN9hJ9lCOrBH9wWVcqrLpaZmOEcCPlOyfu+EaLM=; b=yV8ssXXFH400J8Hw5KLsEYWLLsJ4CueSKldweeTFizqnG38s13FKOYWPwSLbQ0tm57dpGi4JJTaJv15LneiE9ZfqbEGjxShKLZi8JkevKVWq8+rqfv9CUhDHrm9odeHe1Ufx/0zpxs7cfoGfih8eFYfbxj77S4J2F7lmDenS+VM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 46f6b5e081251376 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VRUJjgLgj8kxG5NOYqBxYhQnr1dULhf5gOFTNzN9Ylm+hYzQhk0UEMm3HS5XhQLSpnnWSEkIsBGioOW9ggKvi2E3MXzVHVU7Aumrm24CjjAf7Xb81DMdR4IdpLSDHTuvk8YF5lYTFoIJVju48jpg9q+/PM9sph5qHZziGy3os/VCCjWhw0ZnAxy1G6JPAAPEQGRR86Ou4zdBucEMjxTmyonQT2irCG+1txptYSa3Sh5BHkBJP9dG6gJ6KLdAqPXEYngI7ATitEWRgM1kEP5+d12Y969zrM7cXnQbvKXjSbrZmCNYfr31y6H/14NMC6aU2CnOg7dyUOIRi5cNwXWEEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sjoirN9hJ9lCOrBH9wWVcqrLpaZmOEcCPlOyfu+EaLM=; b=WxQpho7J4vqgv5TVBaYHEukDLZxsnsRte4E9m4+3oHagrKg07UhhgAvB0JhWVDQ34AJyyxWA+4xuviwjaY3PnNKmO7BzpnkoTTzrmBKsdtOaUEzX7IleIuKOTkcJx5X18oWBp7txNpyAprUEE8ncW2EMfGuEME/2npCLLioPbjAgZuUtFhguvIqGTXOas3dP5kF2E/+qR69Buvx11JwRMwRGJjNF+JetLdJj+nN2/cQHIxXdaFV76m7XBfxGzAwgqrIH2Vh5B4A1iyDDSbtVEhnORLntxiIvBETz/REfp7qGL5xvo/BOTZeqtIUwj98GeapL1fPHF9gmD3E0WnLm1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sjoirN9hJ9lCOrBH9wWVcqrLpaZmOEcCPlOyfu+EaLM=; b=yV8ssXXFH400J8Hw5KLsEYWLLsJ4CueSKldweeTFizqnG38s13FKOYWPwSLbQ0tm57dpGi4JJTaJv15LneiE9ZfqbEGjxShKLZi8JkevKVWq8+rqfv9CUhDHrm9odeHe1Ufx/0zpxs7cfoGfih8eFYfbxj77S4J2F7lmDenS+VM= Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less From: Luca Fancellu In-Reply-To: <7ed12d12-6fed-cc3a-4a0b-76ad732d4337@xen.org> Date: Wed, 17 Mar 2021 17:04:57 +0000 Cc: Stefano Stabellini , Jan Beulich , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Bertrand Marquis , wei.chen@arm.com Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210308115610.48203-1-luca.fancellu@arm.com> <1921ff88-7637-6454-74a7-1cbab8dafc61@xen.org> <72E0C95C-D5E1-471B-9590-F4D42E3E066B@arm.com> <7ed12d12-6fed-cc3a-4a0b-76ad732d4337@xen.org> To: Julien Grall X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO4P123CA0101.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::16) To VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ebfcb938-9dbb-484f-5e75-08d8e966d410 X-MS-TrafficTypeDiagnostic: VI1PR08MB4557:|PAXPR08MB6944: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: iAn46fQD6v7EsKq00yMnagcQOQPOC7GPTEvyk8Oz8DSceY+Crm5ow+2KFyI1pCCyKlUaLk5COOmP+HlvszbAJtSjItcvb3DyvD07Uj6B6A3UJ0U9bOBDfcFlPes6sfMxXc95UcTfLJBqGEhD6ny6rNWPbxBn8WoPMIrZDFcEjSG7rptZnvXAfqHQqUB/MV1zmxJiv/YzB5FBvc/Xr2ToL6zxvLihg8blHmUvJ84NKOGoe7ZAM1FEJwi6wa+lBa8uW7Po8b58KChojvTKOn2z59sKW1qbzO0f0QNG6oGl1Trycr+kW3I/MYDuHFIDRyPfwBFqkJkPnSXocbdphVuGpg60gdGJ8lrwUjM3qaUCLtaW2SrY3Urd+PVkmjWqMiw5cMXyydtuWurozKsNOeHnZRw+bgU0HsbXW6zWbbywA48iMyCJkkckF5RiU3ALXxv/YJtHQQCI5y4QYDWg35cl9jpwnyEmHCvx/guLKh78an/sSWThEryRsqm5z/xfcn5oiZIcIgaFq9mVYWryW89xQFse511Zlh9Xx2oFgeIN0wzHoIiwnKy8DvCIFd8U189nBegsPywCkDk6+8bckjNgGrK7XtsW3qDC9ohChZM3xz0H6uc4clpAhGRzigz7x6IIKdDLGU1j/rv4crPwx+qr+g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3629.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(396003)(136003)(39860400002)(376002)(54906003)(316002)(8936002)(44832011)(5660300002)(83380400001)(6666004)(2906002)(86362001)(26005)(4326008)(66556008)(478600001)(6916009)(66946007)(33656002)(8676002)(66476007)(956004)(2616005)(186003)(7696005)(16526019)(53546011)(6486002)(36756003)(52116002)(32563001)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?U3JrczE4b0MybS9VK2c1TzdkdmRhL3JmSWgzMEtoME1sVVY4aG5ETFFTZ2ho?= =?utf-8?B?eEU4VlJLSWxGTVJtWmxYWUY4RUQwRk8xRnRhaE5aZE5CSks3UWpCQUhoZzZy?= =?utf-8?B?aktYazlCUmM1WHhpcHVDMytKN0luOWEvMXlKZjZQQmtxenNodkpLdzFzRUFE?= =?utf-8?B?REdOMG5BTW0xQTdaQjhCd3U4ZlFnaUczQnNPbmx0aG5hUVhlQ2FaRnVLek4r?= =?utf-8?B?ajdZNXd2ZVZXbTVXM2NtWW9tUHZlWGpOaTdsejBmcnR6b0I3S29hSFBQTGNm?= =?utf-8?B?M092L1lsampBSW1iK2J3dFdBZXV3bVVlK3dBV1BLMm12Z0Q5dWMvQ0cxcEJD?= =?utf-8?B?OFZtTk5tY1RMeXZ5bzk4NUpsZ09WR3dtWHA4WUhOQ3RpNE82QXhDMkhlbDVn?= =?utf-8?B?aENiWnRhNnh2bGhsV2Q1NURqRWFvcWhUM25Nam9rTUQ3OEhRaEk1cHV1T0Ro?= =?utf-8?B?Mko2emtRV0ttNUd0bzNRZDZXZ3Z5aXlYaTZRTUZ5QS9nS2F2OUdhRE44R1dy?= =?utf-8?B?d3pjditaK0RKMmU5L0N4N3l0Q2g1S0JtN0s0UUNyWTR1T01CaUZmSm96Zjky?= =?utf-8?B?Ky9KbFBCcGh1amxnUW5XeDhodnBaMjNpVGpCWmpNc1lPU2VwWDhLUDFjNDJ6?= =?utf-8?B?S0svN1c3RVJtN1NIRWUvU3RoamZoTHBmb24vdWlTNENCS2FwWGJQNVRGZjho?= =?utf-8?B?R3F5bHFXTElnUnpPbGhlczlhMmJrQUE0QjJqTWIrTUlKTUk4bUQvMHU3YzhC?= =?utf-8?B?T0x1RXVIRzRMSU5JOEJUTlcyMzdQNUh0NTBYQ0lRcUx5VjdsQm1tNzVGcElD?= =?utf-8?B?VXpzSUZud2ljZnBLdFB4OUlKaUcxS0RVOGdZMnFHdXBoTktCTW8vSTBqaTVz?= =?utf-8?B?ZUZncStOMExSdGM5dk1QaDFuNTlyNTRsMitoaUs0RmJTOCtpTDFzNzliYjJu?= =?utf-8?B?RHM2SUxicStTVWpvVVNwekdjNXNKUCtFNVdaNjhGeFo0bWsyOE93WjVXU2hG?= =?utf-8?B?SFVtOGZENWR0ZUVjN3QzTHFKcjdKczN6RlM5cUpjWDMzOGNXMGpraG5OVUNN?= =?utf-8?B?dlplNExlV0pjWmlENitEYWhZZ3Q0YjNDNUROdWMxbXd1b3JkdmFCSkZhalg2?= =?utf-8?B?K2c0ZVdWMFlaYVIyTWxRSjhHU2hqL2JFUnVkeUVuYk9qS3AxcUpRYzNsQW10?= =?utf-8?B?ZXFNbE43K2F0L1gyNno1K0xsUi83bzlsMFpTcEEraWFVcEo4R1dBbzEvWll1?= =?utf-8?B?NCtLWk5JSHUvQzNTZiswR0RmLzdPcVMzSERndmVzdTNtWXJEeUtpK3ZJRGlh?= =?utf-8?B?UDRJUWgzOVozNXczc2hMbW5XWEhsUkRVb3M2SlhVNkN5NnBuQUEzZC80c0wz?= =?utf-8?B?NTNrUElaNDc2Wk1ubVBJZC92NXgvQnBZaVE5emxYL2cvSlA2QkhxRHZhblc2?= =?utf-8?B?Y0VYbTZGSktMUDErdFFqQ0dJOUhzSGx0YjBsYkdqZE5SMXEvODQyVkU5dUZD?= =?utf-8?B?dG1Bc1V3RnBzalM5ZWkxMFFsbi9SK2RUYmJGYnpUUkQyOFRSY3FNSEIrNVhP?= =?utf-8?B?alA3bGVuUmlHSGhsWWUwUFk2aHRoOUU0MXhUMUszQjlHSmd1NXBDeFZpeTFN?= =?utf-8?B?ZytwQ3kvbm9rUjJLNG9qeDFkbnJuSERFWXY5ckI3eHgxOUZCK2wzVE9teFJ6?= =?utf-8?B?WDNaOGFuZ0RyYjQ4TElTcU9QSHhvUTc5R3Bib3JDYkRQTloreGlBWHZCNk5M?= =?utf-8?Q?QPToHmNGKlmQ5RiVh3rKE2w7rxZkAB2uSB7VmWp?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4557 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 14651aaa-9337-4754-8ffe-08d8e966cebc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cRD/o+yX0+41Htu1EyhPl9PCq+bb8/ubsXqdlDMGuc2J1Jyn6cWaLGJ2RWglpgRNZFJIa9n3mYSivTgLsZ9/Vz0PK+kLGnfpLEJRIrns0LLU+Vx78K68UY+nVmhW9j/uA7OCklUbWRspZEIgsN3ByaPBJuFnDJjzR7t/kCEAEZrE14lokOysHiHhLk3pdhttCQdjNw6asPIbNy7MuknKeLuuWVrlYIH7bJwGCh6T18wE7bGJfM9/2dlpiNR3poY1dS4+j1MAMemgeuDxB3j1DIEt04Cca+oyVPowbcTXz4zoo89/+O+ubgNk8125U12/k6EuTTKMZId4JzpXxK38TcSujstp9DIRFPpYkAgUH9voBQvYJU3U8DyVdW62j90gUGZkUqFQJ7XsjztinJ8KpUqIJjQzy1BhvpP3bij9HzJQ4tmZGqx+4P2Diup9naMsOZ7o7hxuKxQrjcuTD4WY2P0Ki/BMlSDlqlOzWPTXmwCeJCvGJUvN9lvTzs6yOosUIe0hhLpcwCbhnY7+WZT5HssN2KTqmPRlJW9WqfjjnAnjHvR09L9COHcapESTNbiohJHZiEC0cl1To9DEee44BO+av8+cv/HUuMmvdkuA/EZW0DqBAvPErQh+I6dXZtKmQLxf93BhTPp52j0mjQkFoAQ6/U4mWmoG88ss/1bo/X9udNSAiDd9J6Ejuh1R4rLq X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39830400003)(376002)(346002)(396003)(136003)(36840700001)(46966006)(356005)(54906003)(6862004)(70586007)(44832011)(16526019)(478600001)(4326008)(83380400001)(36756003)(81166007)(2906002)(33656002)(316002)(8676002)(956004)(336012)(26005)(70206006)(53546011)(86362001)(82310400003)(6666004)(47076005)(36860700001)(6486002)(7696005)(5660300002)(2616005)(186003)(8936002)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 17:05:12.6104 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ebfcb938-9dbb-484f-5e75-08d8e966d410 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6944 Hi, I=E2=80=99ve checked the common code and the arm part, I can confirm that t= he domid 0 is never allocated even if the domain 0 is not present, here the= only places where domain_create(=E2=80=A6) is called using a variable valu= e: 1) xen/arch/arm/domain_build.c d =3D domain_create(++max_init_domid, &d_cfg, false); Where max_init_domid has value 0 and it is defined in setup.c 2) xen/common/domctl.c d =3D domain_create(dom, &op->u.createdomain, false); For me seems that the dom variable won=E2=80=99t take the 0 value, if someo= ne could give another feedback it would be great. On every other part where domain_create(=E2=80=A6) is used, it is called wi= th a constant value different from 0. For the hardware_domain being NULL and not handled in some situation, it se= ems that it=E2=80=99s not directly related to this patch, but I can handle = it on a next serie, from a quick look it seems that many cases can be handl= ed by checking if the domain is NULL in is_hardware_domain(=E2=80=A6). So, if the community agree, I can push a v2 patch with all the discussed th= ings (moving dom0 creation code) Cheers, Luca > On 12 Mar 2021, at 11:31, Julien Grall wrote: >=20 > Hi Luca, >=20 > On 12/03/2021 09:38, Luca Fancellu wrote: >>>> + >>>> size_t __read_mostly dcache_line_bytes; >>>> /* C entry point for boot CPU */ >>>> @@ -804,7 +833,7 @@ void __init start_xen(unsigned long boot_phys_offs= et, >>>> int cpus, i; >>>> const char *cmdline; >>>> struct bootmodule *xen_bootmodule; >>>> - struct domain *dom0; >>>> + struct domain *dom0 =3D NULL; >>>> struct xen_domctl_createdomain dom0_cfg =3D { >>>> .flags =3D XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, >>>> .max_evtchn_port =3D -1, >>>> @@ -964,28 +993,33 @@ void __init start_xen(unsigned long boot_phys_of= fset, >>>> apply_alternatives_all(); >>>> enable_errata_workarounds(); >>>> - /* Create initial domain 0. */ >>>> - /* The vGIC for DOM0 is exactly emulating the hardware GIC */ >>>> - dom0_cfg.arch.gic_version =3D XEN_DOMCTL_CONFIG_GIC_NATIVE; >>>> - /* >>>> - * Xen vGIC supports a maximum of 992 interrupt lines. >>>> - * 32 are substracted to cover local IRQs. >>>> - */ >>>> - dom0_cfg.arch.nr_spis =3D min(gic_number_lines(), (unsigned int) = 992) - 32; >>>> - if ( gic_number_lines() > 992 ) >>>> - printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\= n"); >>>> - dom0_cfg.arch.tee_type =3D tee_get_type(); >>>> - dom0_cfg.max_vcpus =3D dom0_max_vcpus(); >>>> - >>>> - if ( iommu_enabled ) >>>> - dom0_cfg.flags |=3D XEN_DOMCTL_CDF_iommu; >>>> - >>>> - dom0 =3D domain_create(0, &dom0_cfg, true); >>>> - if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) =3D=3D NULL) ) >>>> - panic("Error creating domain 0\n"); >>>> - >>>> - if ( construct_dom0(dom0) !=3D 0) >>>> - panic("Could not set up DOM0 guest OS\n"); >>>> + if ( !is_dom0less_mode() ) >>>> + { >>>> + /* Create initial domain 0. */ >>>> + /* The vGIC for DOM0 is exactly emulating the hardware GIC */ >>>> + dom0_cfg.arch.gic_version =3D XEN_DOMCTL_CONFIG_GIC_NATIVE; >>>> + /* >>>> + * Xen vGIC supports a maximum of 992 interrupt lines. >>>> + * 32 are substracted to cover local IRQs. >>>> + */ >>>> + dom0_cfg.arch.nr_spis =3D min(gic_number_lines(), (unsigned i= nt) 992) - 32; >>>> + if ( gic_number_lines() > 992 ) >>>> + printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceed= ed.\n"); >>>> + dom0_cfg.arch.tee_type =3D tee_get_type(); >>>> + dom0_cfg.max_vcpus =3D dom0_max_vcpus(); >>>> + >>>> + if ( iommu_enabled ) >>>> + dom0_cfg.flags |=3D XEN_DOMCTL_CDF_iommu; >>>> + >>>> + dom0 =3D domain_create(0, &dom0_cfg, true); >>>> + if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) =3D=3D NULL) ) >>>> + panic("Error creating domain 0\n"); >>>> + >>>> + if ( construct_dom0(dom0) !=3D 0) >>>> + panic("Could not set up DOM0 guest OS\n"); >>>> + } >>>=20 >>> It always felt a bit strange the dom0 creation is partly happening in s= etup.c when for domU everythink will happen in domain_build.c. >>>=20 >>> Woule you be able to create a patch that will first move the code in a = new function (maybe create_dom0())? The function would return NULL in case = of an error or the domain. >> Yes I will create a new patch with this change and I will put on top the= v2 dom0less patch >=20 > I think it would be better to put it first. This will avoid some churn if= the code movmement comes second (you would first indent and then move the = code). >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 17 17:23:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 17:23:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98765.187547 (Exim 4.92) (envelope-from ) id 1lMZst-00041s-Bz; Wed, 17 Mar 2021 17:23:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98765.187547; Wed, 17 Mar 2021 17:23:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMZst-00041l-84; Wed, 17 Mar 2021 17:23:03 +0000 Received: by outflank-mailman (input) for mailman id 98765; Wed, 17 Mar 2021 17:23:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMZss-00041g-2F for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 17:23:02 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7f5895e0-d597-4679-badc-e5883ad12c51; Wed, 17 Mar 2021 17:23:00 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 210CA64E0F; Wed, 17 Mar 2021 17:22:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f5895e0-d597-4679-badc-e5883ad12c51 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616001779; bh=74/f/Wzopymb3TYHhkM3Uc2jmgW+8Uo0wBgVU5snhhs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qG9K6j+XqZdFmnn7p+OgtyN64Q3HOBvZ6JUF+0I38SYZyB7TB1ikUDGIvj/6bf6bS nKDfc/N0wwSZ81hNYRrZO4Rs6iiWzxsTd0R1r7AZu+otzbHNBGZC2vBGgVVulzID95 AGlWEBh5G6I0KVr5BYiyCJbtsI8e6OPhMuvLjKBjYh358T2wjAp+gUTqsym7F5iUap RsZen7di5+xf1yYlqwFXgKAc4VqmCvE7Uk5OOSAe2KQDPXHnwNQeYgKGekUVVVd6MT Znx/HnhSM/FVgDL4JPhFwWRWKa3ViwPiUl4DZ+cD2a+381kaPFG17vAXvR6TwjAAp9 ToOOCHfmxJ6og== Date: Wed, 17 Mar 2021 19:22:55 +0200 From: Leon Romanovsky To: "Hsu, Chiahao" Cc: Andrew Lunn , netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring Message-ID: References: <20210311225944.24198-1-andyhsu@amazon.com> <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> On Tue, Mar 16, 2021 at 04:22:21PM +0100, Hsu, Chiahao wrote: > > > Leon Romanovsky 於 2021/3/14 11:04 寫道: > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > > > > > On Fri, Mar 12, 2021 at 09:36:59PM +0100, Andrew Lunn wrote: > > > On Fri, Mar 12, 2021 at 04:18:02PM +0100, Hsu, Chiahao wrote: > > > > Andrew Lunn 於 2021/3/12 15:52 寫道: > > > > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > > > > > > > > > > > > > > > > > On Thu, Mar 11, 2021 at 10:59:44PM +0000, ChiaHao Hsu wrote: > > > > > > In order to support live migration of guests between kernels > > > > > > that do and do not support 'feature-ctrl-ring', we add a > > > > > > module parameter that allows the feature to be disabled > > > > > > at run time, instead of using hardcode value. > > > > > > The default value is enable. > > > > > Hi ChiaHao > > > > > > > > > > There is a general dislike for module parameters. What other mechanisms > > > > > have you looked at? Would an ethtool private flag work? > > > > > > > > > > Andrew > > > > > > > > Hi Andrew, > > > > > > > > I can survey other mechanisms, however before I start doing that, > > > > > > > > could you share more details about what the problem is with using module > > > > parameters? thanks. > > > It is not very user friendly. No two kernel modules use the same > > > module parameters. Often you see the same name, but different > > > meaning. There is poor documentation, you often need to read the > > > kernel sources it figure out what it does, etc. > > +1, It is also global parameter to whole system/devices that use this > > module, which is rarely what users want. > > > > Thanks > > Hi, > I think I would say the current implementation(modparams) isappropriate > after reviewing it again. > > We are talking about 'feature leveling', a way to support live migrationof > guest > between kernels that do and do not support the features. So we want to > refrain > fromadding the features if guest would be migrated to the kernel which does > not support the feature. Everythingshould be done (in probe function) before > frontend connects, and this is why ethtool is not appropriate for this. It wouldn't be a surprise to you that feature discovery is not supposed to be done through module parameters. Instead of asking from user to randomly disable some feature, the system is expected to be backward compatible and robust enough to query the list of supported/needed features. Thanks > > Thanks > > From xen-devel-bounces@lists.xenproject.org Wed Mar 17 17:37:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 17:37:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98768.187559 (Exim 4.92) (envelope-from ) id 1lMa7G-00058f-Lk; Wed, 17 Mar 2021 17:37:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98768.187559; Wed, 17 Mar 2021 17:37:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMa7G-00058Y-IF; Wed, 17 Mar 2021 17:37:54 +0000 Received: by outflank-mailman (input) for mailman id 98768; Wed, 17 Mar 2021 17:37:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMa7E-00058T-UM for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 17:37:53 +0000 Received: from userp2120.oracle.com (unknown [156.151.31.85]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7160e7e4-651d-443d-a417-cc92f157085f; Wed, 17 Mar 2021 17:37:52 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12HHXdOC165915; Wed, 17 Mar 2021 17:37:49 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 378p1nvwg6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 17:37:49 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12HHZRfP084443; Wed, 17 Mar 2021 17:37:49 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2104.outbound.protection.outlook.com [104.47.70.104]) by userp3020.oracle.com with ESMTP id 37a4eupf7c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 17:37:49 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BYAPR10MB2679.namprd10.prod.outlook.com (2603:10b6:a02:b2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Wed, 17 Mar 2021 17:37:47 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3933.032; Wed, 17 Mar 2021 17:37:47 +0000 Received: from [10.74.97.52] (138.3.200.52) by SJ0PR03CA0345.namprd03.prod.outlook.com (2603:10b6:a03:39c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Wed, 17 Mar 2021 17:37:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7160e7e4-651d-443d-a417-cc92f157085f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=rhcXYAjuXe0KIPC1Ig00JEBH7t0HNM2no7c088fpuPo=; b=0aF0Q+BhGNeMsXoYE8ePu6hNcrBvNsOhbWV6DoQvj4ObuLRanVK50mRORDs8hgMnzckZ hdt8nYL8Tuwe649Bl38CA5Qj9bMVGycUj/c3wA30mxIWFbeavrZJLfAHq9IZRAk35Vao 1hs9bOmaAUdHTQ156SrpVTeydcnsBZwvI3ofwaBLXpeKRFwfW+sJe5XF3tMXf4vdDoyw V6K7QD7Pyg5ksosHy5++I5vncFQGt1YWhGK1oztfoMH/Qn1fAdFEFuL2EveWh1aHODwQ tFihM5dFVYjaCHJ7s6nXX0Oh6F3gQV7qsgA+Dm0cPrDhb2RVHwnCzzH8F/2ho3B5FEme ag== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fBkCfU2NdBjhR1ScCTYnU+7fZelIvB6NnCwBytFVaEuqsT4mz7ZspePv00ZYt+FwJ5IxizPM8XyfAUtU7noQiDAsaDgJUDeVTLOe2RD+uwUc3EmvP5Onk2rvmyywfeAOXnkDgt76UHQ64PEooNfeo7KhvKp+CLdHUKwGWSgxIVQtR/NA+nYcxd91r/COEoZOEUpw3dKJLJIJdScRMc9xJx1QsU1diTdgnfk7NuMoE5We5u7bewJpOmFA7eWNJJpYtMcD+KPuOrpRtGzkXf9GZ1Ml4kluLPn6QWyxbE1Z0U3K4ZyaZEZhD7aB6FIgzBeNaJAPTWAprOUt1Z052iB1wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rhcXYAjuXe0KIPC1Ig00JEBH7t0HNM2no7c088fpuPo=; b=aJLUS4w2T194uFRggzEukmxSApRsY4zObLGzm0S1n0t/3IpF6EAK1Sviz3r/2V4LDm616nfEqtkZ5gQdzqTbbJPfOrBKLievfS6wj3uVhTvYUZ+hc8ANklSm3MxfW+UXbFkrjlBXaihZTzccyagfX4eu8lxP/0uVpD7Y8/Vf94+d0QvVjR6TJC8JDSJjgS1s39+4WsskEn37rN8y6bx6Asf/EWhBpFir0e5rDIqHHP5mMTNNS3y7ZQW5CigRwccwwY1gQmMzohaycydVoWYaVh43TP8LBaDowd8JoqVggV1KTP1fUJVKV4FWoYneb07ejLbdQGAORrEnuGLku/hP8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rhcXYAjuXe0KIPC1Ig00JEBH7t0HNM2no7c088fpuPo=; b=L8Im1oUDfH04cFu0FlT+cUKmPBkVFR845DcokdWbeqE/oZclzKen4dCpTuo+p/cDUd6cfoLwVGdslYy+daEiZ7UURahtMkt7GJNJtIT4Ihfxlxv+Qa9IIvV/38FexzUvzpv5c8VkHjmblddzg7aKv8HfwlVZ98vxn5d3yPgwT0s= Authentication-Results: xilinx.com; dkim=none (message not signed) header.d=none;xilinx.com; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH] xen/arm: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped To: Stefano Stabellini , jgross@suse.com Cc: xen-devel@lists.xenproject.org, Stefano Stabellini References: <20210225235158.24001-1-sstabellini@kernel.org> From: Boris Ostrovsky Message-ID: <4707b219-eee1-22e8-8dd3-6b7d821de333@oracle.com> Date: Wed, 17 Mar 2021 13:37:43 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210225235158.24001-1-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [138.3.200.52] X-ClientProxiedBy: SJ0PR03CA0345.namprd03.prod.outlook.com (2603:10b6:a03:39c::20) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 072615ae-703a-4f11-25eb-08d8e96b60da X-MS-TrafficTypeDiagnostic: BYAPR10MB2679: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wW1VL+4uwdC5wZN3oIssoSSRL9Ix+ATBUAIfqudKK0MZ70+nkHg4rngmeYqzooqvdUo60VmVN6dCU/x0AUSHlxZPDjkvhUUJ1I/PiWSboOVjX2r5NctzgCHom+mFXcPwh+0l/eOyjkk4lqotm/9dWdSiP9e5nqcYXd2gxi1pXsgKvmTgrhMfAWFjFJ4qdinE/zcX/tnxBaaBly3uYZHGHq/IXwvwUK6yyTXm/GnKZrfiT8cLCUEUbxwsELpN23o9w50gOyQ13V02RZ/cYGVBcdd81tTBar59d+J+eNmDbeFmDdS5Tt7+lHTcZ+ehy02GLKttcaFGv+OHxZKfvvKiHK2slcsnoPMg73JlKApOvvFzodH2JpjehhrTFC+Sjdpux6yZFtQszdeMmiv9GYRaPdnffLSw/QRlrPdU1IzXtOIMXk07GfvguxiCYfUTEKaB2y/anSYlXc37Na9TzfkH8KQAvoL2gpQZOOvQzKJw/3iR7GFWvSPWt6kEbj2c/9gfhFgkkJKbrHSs0Z2fxbnspLhlT7syr93gLmbEW0EEmk4OSUyUerX7LKpUmE8R78+PH9h9b2TbNhTXPeBucgV3bJFr1vhPkJEGurkSSSANH3aKbUThP9rTHURM1JW9JSuWGexeDdeze7FPjlaTgcPRsye9fnZUwX9jc1zYS0Tj1N8gTULYjVfeWcC8/MuMifs50jDHX4KEb68sVkmJQg/wQ+8znNcyjucMWXxJdiEX4wYxSgRm6qqMeRQGD3GlxV3j X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(366004)(346002)(376002)(136003)(39860400002)(316002)(44832011)(31686004)(36756003)(5660300002)(6486002)(16576012)(478600001)(31696002)(66946007)(66556008)(66476007)(6666004)(2906002)(53546011)(8676002)(956004)(2616005)(8936002)(26005)(86362001)(16526019)(186003)(4326008)(966005)(83380400001)(43740500002)(45980500001)(6606295002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WVdEU3FVY05Hd3NpcGc1Umk1T3hseFN0azBTUWtOWHFKb1dmeG00WFZaVzRX?= =?utf-8?B?eGk0UzFtVy80enB4ZXJBak9iLytFWFdEVlFZWUh4WnFQWFRMZ2pJdk1BSUdF?= =?utf-8?B?WCtpT0tLMklIelNvb200NVN5MWFXcitOWFlFWnh4QlFNL3lDZUdLdXRCa1cz?= =?utf-8?B?NHAwOW1FckJYSHR2R2poZU1rQ09HdzFOemFkVXR1cHpnbUNaYkE3dk13YUhy?= =?utf-8?B?QXc5M0VBc2Exb0cwTnBzaWhmejJVYVFBY3lxRnFRZ01EeTAxZkpMYU9zMTBi?= =?utf-8?B?aVloT20yYnRyMWRpdkNZaHdud3VXL1RoRHRMdSs3WnVNMVVmWkJjUUFhbys1?= =?utf-8?B?ZXM0SGJiT1doV0drTk1WTVcxaUt0Z2ExaUdiMldHeWRtdlJkV2lXRmJjNW1I?= =?utf-8?B?UGFCeXk3ZHRuOUpZbVlialNnUXhMSWdGZHZSTUdJUGdJcC9JVjJHL2Y0V3F2?= =?utf-8?B?alk5SzZaNlVEeFBDaThOUTZGcU9XMGNQbUo0UGdpR2U5eFZIZGU4ZkZMYXow?= =?utf-8?B?N2xWSWloVDQ3THR3Q25nNGc5ZEE0eEYvYk42enMreHRJMGZWUWszTjNhUXpM?= =?utf-8?B?Zy8wNnkzSXZ3TGhSdFhxdk5OU2loTmVuMy90R0U1V1I4eWY2V0k3N1lHZEVa?= =?utf-8?B?Q1kyeHppTGl5bTNtSlRvaXRuM3d4bWhoNFlINUZnWkNlUjhZRTg5VGRIQTZN?= =?utf-8?B?cHZob2s4UE42WldERGZqNkJpR2hZUmZmUjRGajArdUl5MmlrMjBFQTRacWtv?= =?utf-8?B?cmNkYVUzY3ViaFhFYTNlMm1PNG5UQ3lHYjhFTnF0VzhsQkt2d0xmUm14bElj?= =?utf-8?B?dHhwTXFCOVBIVG9PMjJ2R21udmt0ZHBCazZDQW55bFhCMDZqUW9KcGtCZE53?= =?utf-8?B?RmxoOThyRzAxRGU1ZE5kR0F4eXVrSmIyc004NUtqbXg2dDZCYmxDYlpKMVRv?= =?utf-8?B?OU1xcHZhSmNVRHlySWpXcmFMQ3NuK093S1orTnVDK3NnMFUxRFZEbUQrQ094?= =?utf-8?B?MGJyT0RSWlNWcXRYM2t5eHhkWFN6alBmZUdycGpWcWV6aHpFc3F1QXpvWTFp?= =?utf-8?B?cWlVcnREdTJabzRtU2d1R0F3K2czNWphSVJGdUZOL21rem5KNU9BZG5xT1d4?= =?utf-8?B?bDk1UFV2eHlUdEhVTjlyUkFVM2RLOXo0RjlsM1FMMllaOWlFMFBXd1FWYTFW?= =?utf-8?B?WTZOSzdyMFhiUWc3YzVBNHFRVlFTcUp0c0tGaU0zL2Q5clIwM2hNYUJkWVBu?= =?utf-8?B?b3VlTTFDRDB5ZDRLQS9NUE85L0h3Q2pWa3AvRWFJRzVFRk9oc1FGZlpkVlJL?= =?utf-8?B?TkVvdW8wUHBucHpuU05hbnVDZ2hMdW5kNFp0T2pNdGpMZzNaa2RBVjMxQnhy?= =?utf-8?B?TFdJbEdYWVJWUTVlTTMxTFFnNEhjRXJ1ZDRwOVJTNGFPUHdGNFVqOHFnS1B1?= =?utf-8?B?V3UwWW93MWNpY3UyWUhRYm5LTEw1RUZQZXFSRDFJQnBjSXlDOXJHT0FUeGV1?= =?utf-8?B?S3ZmWTNBRHdRRlZ0eDgyMmR3TWpjUytsblBrWkFNeHQxVG0yN0xnTkhvTjhY?= =?utf-8?B?MTZzUEo0WXFBRmR2ZlZKZ3RZNG9ST2duT2NQVDhHbHJNaTl0U2U3eFBOOWFr?= =?utf-8?B?MU1vTzVzTFFZc0NhKzcwSW9jL3crYVR4NWNNVS9zaDhhSFhGT01ET0RNODZR?= =?utf-8?B?UURGT0NYZGZ6Z1lES1JCbEgzcFBmZ2Jlb1F0ck05dmhhUDJkQ1AzbFU0Nm40?= =?utf-8?Q?vecOxUhXP0yU63PUWPQiyFgZT130f0VYNKkVMui?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 072615ae-703a-4f11-25eb-08d8e96b60da X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 17:37:47.0036 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G86NFKKKF2M4CDd/jjkt9q8mmbb0p3/mINkIWTtq2jbDCMH/2aCebolsjH7YoUTpRxSKYBsT/1lT9w/DNLVQOjGIkxp5hMJR7zYIq23tjPk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2679 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9926 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 mlxscore=0 mlxlogscore=991 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170120 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9926 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 adultscore=0 spamscore=0 clxscore=1011 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170120 On 2/25/21 6:51 PM, Stefano Stabellini wrote: > Newer Xen versions expose two Xen feature flags to tell us if the domain > is directly mapped or not. Only when a domain is directly mapped it > makes sense to enable swiotlb-xen on ARM. > > Introduce a function on ARM to check the new Xen feature flags and also > to deal with the legacy case. Call the function xen_swiotlb_detect. > > Also rename the existing pci_xen_swiotlb_detect on x86 to > xen_swiotlb_detect so that we can share a common function declaration. > > Signed-off-by: Stefano Stabellini > --- > > This is the corresponding Xen patch under review: > https://marc.info/?l=xen-devel&m=161421618217686 > > We don't *have to* make the x86 function and the ARM function exactly > the same, but I thought it would be much nicer if we did. However, we > can't really call it pci_* on ARM as there is no PCI necessarily. I would prefer to keep existing names for consistency on x86 side (but making that inconsistent with ARM, as you point out).  But if you feel strongly about making the change you would have to have x86 maintainers agree to this (arch/x86/kernel/pci-swiotlb.c). -boris From xen-devel-bounces@lists.xenproject.org Wed Mar 17 17:52:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 17:52:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98771.187571 (Exim 4.92) (envelope-from ) id 1lMaLK-0006ra-Rz; Wed, 17 Mar 2021 17:52:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98771.187571; Wed, 17 Mar 2021 17:52:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMaLK-0006rT-Nv; Wed, 17 Mar 2021 17:52:26 +0000 Received: by outflank-mailman (input) for mailman id 98771; Wed, 17 Mar 2021 17:52:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMaLI-0006rN-Tp for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 17:52:24 +0000 Received: from userp2120.oracle.com (unknown [156.151.31.85]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e3b29c92-e9cb-4d5c-8525-8819a2353c9c; Wed, 17 Mar 2021 17:52:24 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12HHjfH8009868; Wed, 17 Mar 2021 17:52:04 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 378p1nvxtx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 17:52:04 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12HHolTG188948; Wed, 17 Mar 2021 17:52:03 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2108.outbound.protection.outlook.com [104.47.70.108]) by aserp3030.oracle.com with ESMTP id 3796yv54qa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 17:52:03 +0000 Received: from BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27) by BYAPR10MB3685.namprd10.prod.outlook.com (2603:10b6:a03:124::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Wed, 17 Mar 2021 17:52:01 +0000 Received: from BYAPR10MB2999.namprd10.prod.outlook.com ([fe80::50f2:e203:1cc5:d4f7]) by BYAPR10MB2999.namprd10.prod.outlook.com ([fe80::50f2:e203:1cc5:d4f7%6]) with mapi id 15.20.3955.018; Wed, 17 Mar 2021 17:52:01 +0000 Received: from Konrads-MacBook-Pro.local (138.3.200.3) by SJ0PR13CA0157.namprd13.prod.outlook.com (2603:10b6:a03:2c7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.9 via Frontend Transport; Wed, 17 Mar 2021 17:52:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3b29c92-e9cb-4d5c-8525-8819a2353c9c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=AuI7WZwh+THy66uOk/dX3AZL5VQVLUSbLO1vN8BYNn0=; b=q7MYbIvZ6XMGjyOchRWzSW4ZJV9PXDxgAxsHR0bCU11jzHqB/0qlMbzS3LR1GwamuOw2 WGAsF+dk2sTsXcFjn3Ep5sB6cZFzB0l1SZwuw3qVfusDBr0u2qHzdLrZpcBUbt6cWt9b GPypjNYpqC7IN5y0SL3GpbZ6Syyx8iTesdRhrGgYBJSR/etjfiKlCpKYAz3+7ykbf/PV 5K3Hkey9IOQya3dHeRFJ+dO+8kKyESEFG4UZjKkUnn5UeitjYfIOuUcBza3f9zce5LF1 eHF1ufETgY/oRCyEeyi87FMVH6XNwAPu9ca0hzlE2pzd4nXTLslJyWiKxurd0gNsX5Am tg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kcn/OjkRge8LRRP9YU/yXyzkWHOmNItw1fflnCQtErFqe43UOBpVw/FXv2hgRoNipg6yCqhebnN8HMd+pYJwPVuUgl6jY/noZ/u+hrjO8j9kkVP40XTNyKcBCTD7mwcmV/URn9aWl7ceK/hz8ns6oTU7mh195Ur8WxXn3LmEZenbl7jsx8plEe14shYAw0gE0DHH4hH1tHk17Co7VYohUf3EWIVoTCS4pkQQoziIM7mjBBPeqP+Bb+deOqdvEeAqRT1i7OzgXmGQdbXC+TdBxf+rCea73JMHUm+Rpr6P1B/zOAtHECHQdlgXiY3mZua9jUctRyD5m7SxiMUxqzJgEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AuI7WZwh+THy66uOk/dX3AZL5VQVLUSbLO1vN8BYNn0=; b=oSYlbGapY7yAud4JHRULDxIdcFgcRiWIVoYYb1MMcgGKqy6sGKKDR6sYcucR+6huAwI7iTbrLSWiW0hhStMiAu7t2Aoezm1GPFZvH4U5vvs4uhEof+uZrAGo5wdWClXFR1obEnYK2HrB9i+9p4EsBLV2A9ZVo+0P+iYs8WgmQ9A719Ch04jnrTP6V8OTcvKTQkTO41Eo96mjpzQUfhdvFy8Q1kh3mQbR9NgZaaegoFsuRlXmfWggICuTwkIM5I+k9bjNL2NpKwIlVoiFtqsYFuirPVzb3elhERj7twf8OEScJkMb6upOJ07V/d1Ty8Wtw4woAZfoZyHfXbR5ZlmH1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AuI7WZwh+THy66uOk/dX3AZL5VQVLUSbLO1vN8BYNn0=; b=zfL6FH13MdOTEy+2aWuMUWZXnarmlVGA9yqKLcNVH/ruodNqoCx3nSr5i+xV9uwxm+3SUOLWhj6/VW1qJR5omKaTK3b3pLufrKLZ66AhgWzcyGXhL6WoN3jJ1vOrvsucvpj1p107v7eLPo78TZzvsC6h5uiGKZCmpopdHH/zSJU= Authentication-Results: lst.de; dkim=none (message not signed) header.d=none;lst.de; dmarc=none action=none header.from=oracle.com; Date: Wed, 17 Mar 2021 13:51:56 -0400 From: Konrad Rzeszutek Wilk To: Christoph Hellwig Cc: Michael Ellerman , iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Claire Chang , linuxppc-dev@lists.ozlabs.org, Dongli Zhang Subject: Re: [PATCH 12/14] swiotlb: move global variables into a new io_tlb_mem structure Message-ID: References: <20210301074436.919889-1-hch@lst.de> <20210301074436.919889-13-hch@lst.de> <20210317134204.GA315788@konrad-char-us-oracle-com.allregionaliads.osdevelopmeniad.oraclevcn.com> <20210317135327.GA10797@lst.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210317135327.GA10797@lst.de> X-Originating-IP: [138.3.200.3] X-ClientProxiedBy: SJ0PR13CA0157.namprd13.prod.outlook.com (2603:10b6:a03:2c7::12) To BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7fbf9615-15e3-487b-32ef-08d8e96d5e39 X-MS-TrafficTypeDiagnostic: BYAPR10MB3685: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cg6vtXO6MX/vimR6TjsQK3eGF7dB1pf/RHbbE/yxEHzIpd43hQ4lNXA1O4mM/0q4O2BDRSLiuW/desJr6Lqo22PJgRHWhFbgQL+2kziLt8xMoWcKVTAwd7JYEkdesN5VZao+Zrxm5lB4Bcf7oIHzr+LokzLdmZQoSwoC6sHPQpUBxS6sPW3N2UX7L4FgwYbz8ypk0w7/9Em+CdiFnvqfLgL/+0AXvw7vjR6bPVfRWMBu71PRN7GbZ/0KyrHsKRyKSsTyiBwruage4hNuKMRiT3RmkLLVLmSn4amNIrUABsu7ZLHKVh53myhYMFegW/q/5zFEZh+q4BA6gUxPc+c2aroz21R1xrJDW9pKoIIzabN6ucPPkpRREnjZp6UBlu73p/amgqcc7ao6G102wTl0DU17cETBT8X3Lp+MxIBQw4WV22lbOeg2IKQNwUUbptfsLqHkbp/7y70iR3ypmM+K+KfBJCLjz7RJjjNGmu5iqKw9PiJjlNElCwBz1p0yOH1S1qIqIWCK97/I4KB1+fp5arG0mYBfJ/gGOyf71HXyVXH+ob1FMAX+4F/E18EwkNR0 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(396003)(136003)(366004)(346002)(9686003)(478600001)(107886003)(16526019)(956004)(4326008)(186003)(55016002)(26005)(52116002)(54906003)(86362001)(6666004)(83380400001)(66556008)(2906002)(6916009)(4744005)(8936002)(5660300002)(66946007)(7696005)(66476007)(6506007)(8676002)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?pFahNcWwbr+sh5HdDal7q2UqMPQ5bGD0l0l+kCf79QilCOQvTr+8iLTPRWMx?= =?us-ascii?Q?lsbkwOiEoP4oFpERPxfbqL5tlPCHfMgwcjoWK/K5PWO13lzHRDhgKMWWVGRX?= =?us-ascii?Q?kA3AyabgIFN7VTYzbONsr/zhCaTmWlCF15l3sADlGp3Fa0Sn23YKBFl8a+1A?= =?us-ascii?Q?YbRVOdDu82odfOej1PCUI5GV88CqHIvnL5N5zfEo1uwZg/wga/MOJNr2J+3Z?= =?us-ascii?Q?WsvCY1flmMxEBrvClV1cEbBRsHsXje6FmgCVMhDdp3uMGUJ/CEBnVBHtHg9/?= =?us-ascii?Q?uX1EJOYLQ7OPtgWPXg3lObGyz2zdvfUcV9Jw0QDhLLGIfGDvAyS7CEJge3go?= =?us-ascii?Q?hUwdocRbhc1v+QA1XukKKu6yPCt0vPIsCC/gX29HzBpUjPmAZHlQvNMpsTqu?= =?us-ascii?Q?ONgObmKaE1OMlDgFAQfl4hKtDKILPHX31Z3TPmS1793vKMr9bgwuBg4qfqLk?= =?us-ascii?Q?7xUkVveiG00YNfA9k3R3HfAF1TBlY94GAZWrHoJYS5Fc324PYVsVnAr8hSjf?= =?us-ascii?Q?qvhOzeuJmJMiWgI9bsy7Od1ZSKTKhNbqX5S/8He/BdUj37QuJcARu8n46LHh?= =?us-ascii?Q?FND/lAc7iIlxsLiXWGw5IaKGEwyqRdJMxWY/uBokjO8LwVxL4qMBVsWTgdrX?= =?us-ascii?Q?gK/yzjMTGi++lEr9GkZH0Vm0+JQBU59M+uRm86cja/z6bOdhKB7+Q++N4tvj?= =?us-ascii?Q?GENnWLErIJddMOaLzKm4X6Ym+hNA7x3AH0fio5kgZxozODfE+LbZcia8nvA8?= =?us-ascii?Q?4dHuW+HfsBBz2PVeawU3PlSkKN1pN17NV2j0RN2Sasfv6J2d8fajbwgEo5Nt?= =?us-ascii?Q?QW30RBSpoFgasw21s4xXE/2F0oNb7NuP44hItFC8WOcP/0qk+TwaTXRb+650?= =?us-ascii?Q?P+WxjqQBQC3ya1R99iWqMIhtJOP40M89yM8C/tFUyf5G2kUeN600LF4ljdfX?= =?us-ascii?Q?iVkIcYF0QD8pYhbnroz2hiNKqL/49EuNP8eYrZCrYM3jY0B9f7VyzWQnGk9c?= =?us-ascii?Q?bCbEzHJDNsxo4YR/+QA1LxYbiwhLkY+i35LP3IjEJyYCptn6sGchJocVslDa?= =?us-ascii?Q?/YQVR0J5a/rZ/l/h3OGrPuzkWroBd/QshiPMH3BCDXkN6PEdUiON4KsNjrDt?= =?us-ascii?Q?EvmfYMPtRlXHYHORQTpAGIq+2SG6kFkxytWR4cYbu5yHsNWjq7eVeClxF3Um?= =?us-ascii?Q?s7BFLsrGenkp3bVbxpxNj0HxWXbnb6U181zEAv3jdQ4Ji6FgvuSgNF7k6/lD?= =?us-ascii?Q?eQZzledKoRnPYnMCLs5NmcJdfxz/4qB4Lxg9gA7XmENBZm9u2lDEVKEb8bzS?= =?us-ascii?Q?Ljz9mVtM0NWuuvNj9MkR+C4H?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fbf9615-15e3-487b-32ef-08d8e96d5e39 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 17:52:01.5958 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m/8aLUIRs+feJbm4KItJpG0Ipp0ZNh2sYGazLu/mxiZBrxNC3dcUS2K2QRWICEvQzErxzpvKggL0kf42ENh5vw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3685 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9926 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170123 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9926 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 adultscore=0 spamscore=0 clxscore=1011 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170122 On Wed, Mar 17, 2021 at 02:53:27PM +0100, Christoph Hellwig wrote: > On Wed, Mar 17, 2021 at 01:42:07PM +0000, Konrad Rzeszutek Wilk wrote: > > > - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t)); > > > - io_tlb_alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); > > > - if (!io_tlb_alloc_size) > > > - panic("%s: Failed to allocate %zu bytes align=0x%lx\n", > > > - __func__, alloc_size, PAGE_SIZE); > > > > Shouldn't this be converted to: > > mem->alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); > > if (...) > > > > Seems that it got lost in the search and replace? > > Yes, I messed that up during the rebase. That being said it magically > gets fixed in the next patch.. Yes. However if someone does a bisection they are going to be mighty unhappy with you. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 17:57:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 17:57:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98774.187583 (Exim 4.92) (envelope-from ) id 1lMaQV-00076F-Gb; Wed, 17 Mar 2021 17:57:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98774.187583; Wed, 17 Mar 2021 17:57:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMaQV-000768-Ce; Wed, 17 Mar 2021 17:57:47 +0000 Received: by outflank-mailman (input) for mailman id 98774; Wed, 17 Mar 2021 17:57:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMaQU-000763-OC for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 17:57:46 +0000 Received: from verein.lst.de (unknown [213.95.11.211]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 82fd35b1-43bd-4e86-8796-7be9ea12fd7a; Wed, 17 Mar 2021 17:57:44 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 6243568BFE; Wed, 17 Mar 2021 18:57:42 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82fd35b1-43bd-4e86-8796-7be9ea12fd7a Date: Wed, 17 Mar 2021 18:57:42 +0100 From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Christoph Hellwig , Michael Ellerman , iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Claire Chang , linuxppc-dev@lists.ozlabs.org, Dongli Zhang Subject: Re: [PATCH 12/14] swiotlb: move global variables into a new io_tlb_mem structure Message-ID: <20210317175742.GA29280@lst.de> References: <20210301074436.919889-1-hch@lst.de> <20210301074436.919889-13-hch@lst.de> <20210317134204.GA315788@konrad-char-us-oracle-com.allregionaliads.osdevelopmeniad.oraclevcn.com> <20210317135327.GA10797@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Mar 17, 2021 at 01:51:56PM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 17, 2021 at 02:53:27PM +0100, Christoph Hellwig wrote: > > On Wed, Mar 17, 2021 at 01:42:07PM +0000, Konrad Rzeszutek Wilk wrote: > > > > - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t)); > > > > - io_tlb_alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); > > > > - if (!io_tlb_alloc_size) > > > > - panic("%s: Failed to allocate %zu bytes align=0x%lx\n", > > > > - __func__, alloc_size, PAGE_SIZE); > > > > > > Shouldn't this be converted to: > > > mem->alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); > > > if (...) > > > > > > Seems that it got lost in the search and replace? > > > > Yes, I messed that up during the rebase. That being said it magically > > gets fixed in the next patch.. > > Yes. However if someone does a bisection they are going to be mighty unhappy > with you. Sure, I was planning on fixing it anyway. Just waiting for feedback on the rest of the patches before doing a respin. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 18:19:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 18:19:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98779.187595 (Exim 4.92) (envelope-from ) id 1lMakh-0000cw-C8; Wed, 17 Mar 2021 18:18:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98779.187595; Wed, 17 Mar 2021 18:18:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMakh-0000cp-88; Wed, 17 Mar 2021 18:18:39 +0000 Received: by outflank-mailman (input) for mailman id 98779; Wed, 17 Mar 2021 18:18:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMakg-0000ck-EO for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 18:18:38 +0000 Received: from userp2120.oracle.com (unknown [156.151.31.85]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f47dddb2-ae79-4f95-9864-f64ff992164f; Wed, 17 Mar 2021 18:18:37 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12HIGv0T127203; Wed, 17 Mar 2021 18:18:28 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 378p1nw1cb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 18:18:28 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12HIFqvN154125; Wed, 17 Mar 2021 18:18:27 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2055.outbound.protection.outlook.com [104.47.36.55]) by aserp3020.oracle.com with ESMTP id 3797a2xaer-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 18:18:27 +0000 Received: from BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27) by BY5PR10MB4276.namprd10.prod.outlook.com (2603:10b6:a03:201::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Wed, 17 Mar 2021 18:18:25 +0000 Received: from BYAPR10MB2999.namprd10.prod.outlook.com ([fe80::50f2:e203:1cc5:d4f7]) by BYAPR10MB2999.namprd10.prod.outlook.com ([fe80::50f2:e203:1cc5:d4f7%6]) with mapi id 15.20.3955.018; Wed, 17 Mar 2021 18:18:25 +0000 Received: from Konrads-MacBook-Pro.local (138.3.200.3) by CH0PR07CA0016.namprd07.prod.outlook.com (2603:10b6:610:32::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Wed, 17 Mar 2021 18:18:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f47dddb2-ae79-4f95-9864-f64ff992164f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=wRdmGtgo4XK/l/pi1Z/4bjFdiEXScxvAsYXaLMWX8HI=; b=pbksK3uFoBv8jN/wwIujSF9/XgE+1CxrIBf0isrI8SiLrHTvuLVKnWlZgNG/eXUp3i4d kdwd4JeAFVflZy/fACUDztI9HVEQUQxstI7y8fJep0F+Pf61PFRXEbK6ZvmwE+ZhMwsO FcJyKerTnEuXfPsWPQoKRrkByic41cJzk7OTWwH3j7+Yfb3a2AkIvMytd9tMebRFVT9I N4YyxQgtvAJCF8FnQ+1IaL8uy4U18Orcmb+hx1zvuhAKEZkMyV6Eq0a0+M9eJnaPh0H9 XpPq/T7z9q4JW1xgJU2rSlQ4Q24124LxuUH+EQUQXN6wdeRIdoNjvbrUi7DInQTHZZ1g /g== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m7HjDhO9o2jvLEAk1ODdhP6qFJDYSs+P5TM+WQb9K6PXkt1OSyzxtXRy9ypq6yWWwSyrEkCH5ccnuk2OL7ewh+wJWCqlpZ2B4pF07YSCe3FD/avZ86nM4ekSqDo66QzGZoHA7C4Qop69tf8V3IUx4F2IalO1qTWQWFYWdKYncFNU4LUUZrYA77VMahHz5f4X7v4SsEFPh+BdmX8xSu0P+BXSLSNTA6AfPp6StO1+6Ye4z1Yc3cAhHmKFk3oLYIt2o9vJ0F/sGmx/pxeMkSUSUxoy/2iTvFBSGEday8fy75w/b0zNk0Co/eCya1sU38kCAUdvjAx+2WyTb3sa7ik8dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wRdmGtgo4XK/l/pi1Z/4bjFdiEXScxvAsYXaLMWX8HI=; b=IhjadvwVg35RkPi9ogcBV8CRs4FRKYUpA5BTiqxO43Mjqwmi3xZOgyFkewdz6WYywcxh0+YfYKouxJihsSXfq7kenqmbrh2l9e28+VWC67ouBlwvPQu+e/E/Lr0EeEcNcLVGj6JAG0sH2rjzfhTY4X0b5n5IGY9WLP5y//JAz0V0OtUnfzFclHVV38ttMTyVVGD1j9pjuZVZiYHBnnhSatRHgEJpoVsuVCJdhL2j6EPfK0w8e3Y9aLySrMgRpFSnRvIR1YLEYQC1xvJfJ39OkDOsHQ8Wnd2FH4Pis+PFkwl8vj/p8gtFGqOcJwcSTnLi48vb8iYf/ip9fk9lOP8NiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wRdmGtgo4XK/l/pi1Z/4bjFdiEXScxvAsYXaLMWX8HI=; b=WkMu1nqAl5+fetUsDACDaVKBHUMVCafzSWtQsUp+rUa8pycmx0EH2yK2vsjAa9LYwxzJ9ouSGNGR2c4X7r5sGrqlpIqVNZBZAheS7rFi26Jlbfq5jR0QFTH2Ly9pJBHD5p8dtiUglEu7JREsNRG+vJ+Qlf/YVWwCE5j0r5MSisE= Authentication-Results: lst.de; dkim=none (message not signed) header.d=none;lst.de; dmarc=none action=none header.from=oracle.com; Date: Wed, 17 Mar 2021 14:18:18 -0400 From: Konrad Rzeszutek Wilk To: Christoph Hellwig , jgross@suse.com Cc: Michael Ellerman , iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Claire Chang , linuxppc-dev@lists.ozlabs.org, Dongli Zhang Subject: Re: [PATCH 12/14] swiotlb: move global variables into a new io_tlb_mem structure Message-ID: References: <20210301074436.919889-1-hch@lst.de> <20210301074436.919889-13-hch@lst.de> <20210317134204.GA315788@konrad-char-us-oracle-com.allregionaliads.osdevelopmeniad.oraclevcn.com> <20210317135327.GA10797@lst.de> <20210317175742.GA29280@lst.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210317175742.GA29280@lst.de> X-Originating-IP: [138.3.200.3] X-ClientProxiedBy: CH0PR07CA0016.namprd07.prod.outlook.com (2603:10b6:610:32::21) To BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1e53fdb7-ab97-400e-f073-08d8e9710e74 X-MS-TrafficTypeDiagnostic: BY5PR10MB4276: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DlrkTVWW/e7zc1JJihtgu8t91wb9elr29Kftpn9KBl+1QJb20Y+TqJ+Xez3vp2i4GOfRvXtPZ/8SmAXJ6ZZLJvUyV0GUcqXZxC0gRx2H7SAJYjLJOdKEBN7F+uyEnzs0/IeIK5l9VLWE97p8xxgY/9ocTQbNWb83ZxuUl0Hp2ngZj0n77bpDnQDF7WQ0KJ+x/w6QIlUObEIRNEvbKP6w19sRjDXRtyxjBuZ3jCuP+Kp3YfjhcoikwME6r/2P5qgQ6mIqvKC1sR8gSheNln+k4Ujloj5PGIMIi1Z7WAw+dGYj8GxvYMJFJuOy+8YP99hoUbWY8JHFKIdd/flj1ERliNtufdH44C6pQ2fpEJFN7MZIIbZEnXhQnNU7JUFwaEeEhFPjiFsJqQVgR5NDJM/JjAOx/J2BqshJRCPSQqdvp8lWYTVXexE1uaQtuAhwn6QcWF33d7TZhch3n/oULxXLjRfkriOTMeV+O8wszSbIcuh4IYEHGW8CXF7gG4wtcdrMEJ4+kvozEJjrcUTDa0TMDHl0RMTgNRB0rGHG1eTBdM5ebV01BLuGP8JWhOhPI7wq X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(396003)(366004)(346002)(39860400002)(376002)(9686003)(8676002)(6666004)(5660300002)(83380400001)(54906003)(2906002)(55016002)(956004)(186003)(8936002)(66556008)(86362001)(66946007)(66476007)(52116002)(26005)(16526019)(478600001)(316002)(7696005)(4326008)(107886003)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?domb47Ad3+oBW8VUH8U/3fTzd226BaZwyIt4Ktk589XTg9xrqRff2gTJNQsM?= =?us-ascii?Q?F0RRz7B4KIkfuTNho7905xBtmqhSd8hRYYi6Yhh4FidxRAyI0PdkapJ90rP2?= =?us-ascii?Q?Duh6VXDVoBt0jmNwgzgsv+lz/xPjOw4lwjhhvWhOT8rUrtCOVaaZRt9TB8qh?= =?us-ascii?Q?Gl/k63Wwmj6SzfgZzEN2qVdBBdLYdW6MBzAEqOBGNVTIUueofebOsfMsygrK?= =?us-ascii?Q?JNlx69QVB8K/XSPyCkqWZshW+yfNZmY7fZDroawbDVJAL3B1EBYzjlW2kmBy?= =?us-ascii?Q?qphfhRrkW0ctAXpD906/Z1OGu7b+P6L4LRTUVegT0NWjTehUeR4dq3LHO3Y/?= =?us-ascii?Q?A4JaKsFmDL28r5o2yLjp/3B7SRIqG6Fdfx9zopkS2W3q4nGjnSnt9mLDyVBY?= =?us-ascii?Q?S2+GSbASP6erGGWtIXHTLkg4gULbX5Tud7paaYactqJ4iYkc0dUUJfELg4hl?= =?us-ascii?Q?KYBTHs2BEK6brDLPU/OMwMuSdKJN9UyiXCTHeedttPdskD1LAcE6xb3yNkEL?= =?us-ascii?Q?NSaRWuHXceX3WnXfCqNHuyuxNuYOwH8mekK1z7KRetySHoG6eg1o/umnsEj/?= =?us-ascii?Q?PGIevtlu0+g1LLclkCGA/RnyHIjBPw+P6ZmlkLoAqWvTfgxV482uZsU8WjI8?= =?us-ascii?Q?BrFvm5qTfWdmQA7h+941UM8+rSnlOc6u8XhcJnkmRPWHNReW70TuyrBDPAZH?= =?us-ascii?Q?2nDkyLy0iLZCU5MgU0J9mHbJbu3jrEGYwEmu4EgTkQ/bh1oeyCziqZCq4skv?= =?us-ascii?Q?3mtc45SCPGo1Y71Em4OdBhtILrujMgbGIeqd3qfGHWVL3dbqB2mKOvOCAdNT?= =?us-ascii?Q?FK+0qhAIFkwnBLUa60DREeJOsXqiWsRMcdjRDIa5rKUEpX4XTxRE7c4lAcfK?= =?us-ascii?Q?d+549ZIsR4ZHRhF1uETZ30Jhodx9a8vNX/HoUromjdvgLYtZDD5nIDcrmXF7?= =?us-ascii?Q?m8SxdloxpjRQVelZF1w93lYY0hsJ2CSebFYt+r3EV9xD3vE0gCYdUUtw/URV?= =?us-ascii?Q?HLOzhWwHE18D1XZCaXpqG0ejTis8ZusHILwkTUKkkuG/JKlzyKVBjw+MAq84?= =?us-ascii?Q?rUV2ywbP4fsoMAsP6QNgfMEXDBl+98gn44bpj6m6ZXCmI8/Gjxh2UxmsOEOR?= =?us-ascii?Q?o8jmXUZKCtWCc6DN2MqhrJs7aYcvc8mEoHtGbTu9C9Fni/JASSfmOsG4sMXV?= =?us-ascii?Q?T1jPGOUiBIohSwXgjPnWHYctM7LXbzAYaJgHJDTz7o8Fokjv4wzsG8qwZlm2?= =?us-ascii?Q?upwC5cY2mtoUKIvbv6WNJp5ePGenSKReqkb/j7+yyO3M/3rbW/JBfdwcTeG8?= =?us-ascii?Q?wCNUQ4k3NEt9x/k+If00eHng?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e53fdb7-ab97-400e-f073-08d8e9710e74 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 18:18:25.6935 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B6oHeA/c3erElwCCUHT4pLP7VcA2cD28uRMJfL/ipJKFjinXMf5e2REZiVVnm+Bjd+7a51uJLsAwHYcPMvBY7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4276 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9926 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170126 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9926 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 adultscore=0 spamscore=0 clxscore=1015 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170126 On Wed, Mar 17, 2021 at 06:57:42PM +0100, Christoph Hellwig wrote: > On Wed, Mar 17, 2021 at 01:51:56PM -0400, Konrad Rzeszutek Wilk wrote: > > On Wed, Mar 17, 2021 at 02:53:27PM +0100, Christoph Hellwig wrote: > > > On Wed, Mar 17, 2021 at 01:42:07PM +0000, Konrad Rzeszutek Wilk wrote: > > > > > - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t)); > > > > > - io_tlb_alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); > > > > > - if (!io_tlb_alloc_size) > > > > > - panic("%s: Failed to allocate %zu bytes align=0x%lx\n", > > > > > - __func__, alloc_size, PAGE_SIZE); > > > > > > > > Shouldn't this be converted to: > > > > mem->alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); > > > > if (...) > > > > > > > > Seems that it got lost in the search and replace? > > > > > > Yes, I messed that up during the rebase. That being said it magically > > > gets fixed in the next patch.. > > > > Yes. However if someone does a bisection they are going to be mighty unhappy > > with you. > > Sure, I was planning on fixing it anyway. Just waiting for feedback > on the rest of the patches before doing a respin. I put the patches up-to this one on : git://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb devel/for-linus-5.13 Would you be OK rebasing on top of that and sending the patches? Juergen, would you be OK testing that branch on your Xen setup? From xen-devel-bounces@lists.xenproject.org Wed Mar 17 18:35:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 18:35:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98782.187606 (Exim 4.92) (envelope-from ) id 1lMb0z-0002Ml-QZ; Wed, 17 Mar 2021 18:35:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98782.187606; Wed, 17 Mar 2021 18:35:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMb0z-0002Me-NT; Wed, 17 Mar 2021 18:35:29 +0000 Received: by outflank-mailman (input) for mailman id 98782; Wed, 17 Mar 2021 18:35:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMb0y-0002MW-Lu; Wed, 17 Mar 2021 18:35:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMb0y-00044X-ES; Wed, 17 Mar 2021 18:35:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMb0y-0004ib-4C; Wed, 17 Mar 2021 18:35:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMb0y-0003de-3h; Wed, 17 Mar 2021 18:35:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=n1Mwm3zVp+lY0NCkM0qcR3ON5SG8HfyPYMyZf8INa+c=; b=VgipBZfA/m53c4sUnPm9Fg2fzT D31CiHR8oUFu/kit6UW1qGoqcdRilxQ3ZrqE2eiUBCajIt5gmqpGs+q/yX0O8U+XJgASXauYRCXrp aJESC8gmAxTbPC84ANcQcWBqhHN5vt5SgJe7AgaUxJ/b6dnfYFfKfwC/J5w8N5TjU5YY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160109: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=21657ad4f01a634beac570c64c0691e51b9cf366 X-Osstest-Versions-That: xen=21657ad4f01a634beac570c64c0691e51b9cf366 From: osstest service owner Date: Wed, 17 Mar 2021 18:35:28 +0000 flight 160109 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160109/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 160101 pass in 160109 test-amd64-amd64-examine 4 memdisk-try-append fail pass in 160101 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160101 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160101 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160101 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160101 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160101 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160101 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160101 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160101 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160101 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160101 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160101 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 21657ad4f01a634beac570c64c0691e51b9cf366 baseline version: xen 21657ad4f01a634beac570c64c0691e51b9cf366 Last test of basis 160109 2021-03-17 06:59:53 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed Mar 17 20:18:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 20:18:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98791.187621 (Exim 4.92) (envelope-from ) id 1lMccI-00033j-Oi; Wed, 17 Mar 2021 20:18:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98791.187621; Wed, 17 Mar 2021 20:18:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMccI-00033c-Lj; Wed, 17 Mar 2021 20:18:06 +0000 Received: by outflank-mailman (input) for mailman id 98791; Wed, 17 Mar 2021 20:18:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMccH-00033B-Pc; Wed, 17 Mar 2021 20:18:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMccH-0005lB-Hp; Wed, 17 Mar 2021 20:18:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMccH-0000sx-9Y; Wed, 17 Mar 2021 20:18:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMccH-0005WN-95; Wed, 17 Mar 2021 20:18:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bCx+8gkA5FJcKZxM1irBIzX0WiMv4/RPZvBENqPo5pQ=; b=fW4QQAbSTJZPqcxCzoGrr/5x1a ih1T5W2vd2KAvIb7pbkLq4CSbQDZsgDRRb4VZwAtMgzzfLJcrPSXKfmL2R/uHXe41J8xah0U+W46h +Gy4VGydn3xXDLMp66rXckUadp6m9Zf4s4kZ1VMYrhixcvYQLPeqiWLZVTbyqBE5diik=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160114: all pass - PUSHED X-Osstest-Versions-This: ovmf=e4ff3773b711527ff46759759f34ea1cb9ff2a45 X-Osstest-Versions-That: ovmf=2e51b27fed31eb7b2a2cb4245806c8c7859207f7 From: osstest service owner Date: Wed, 17 Mar 2021 20:18:05 +0000 flight 160114 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160114/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e4ff3773b711527ff46759759f34ea1cb9ff2a45 baseline version: ovmf 2e51b27fed31eb7b2a2cb4245806c8c7859207f7 Last test of basis 160106 2021-03-17 04:11:49 Z 0 days Testing same since 160114 2021-03-17 11:39:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jason Lou Lou, Yun jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 2e51b27fed..e4ff3773b7 e4ff3773b711527ff46759759f34ea1cb9ff2a45 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Mar 17 22:32:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 22:32:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98798.187637 (Exim 4.92) (envelope-from ) id 1lMehV-0006xv-BK; Wed, 17 Mar 2021 22:31:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98798.187637; Wed, 17 Mar 2021 22:31:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMehV-0006xo-7Z; Wed, 17 Mar 2021 22:31:37 +0000 Received: by outflank-mailman (input) for mailman id 98798; Wed, 17 Mar 2021 22:31:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMehT-0006xh-Dc for xen-devel@lists.xenproject.org; Wed, 17 Mar 2021 22:31:35 +0000 Received: from aserp2120.oracle.com (unknown [141.146.126.78]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5fb6fc99-4eea-40a5-8665-fd3984818369; Wed, 17 Mar 2021 22:31:33 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12HMT7ds107855; Wed, 17 Mar 2021 22:31:28 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 378nbmdqgg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 22:31:28 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12HMUmdt040661; Wed, 17 Mar 2021 22:31:27 GMT Received: from nam02-bl2-obe.outbound.protection.outlook.com (mail-bl2nam02lp2054.outbound.protection.outlook.com [104.47.38.54]) by aserp3030.oracle.com with ESMTP id 3796yvdcyv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Mar 2021 22:31:27 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by SJ0PR10MB4448.namprd10.prod.outlook.com (2603:10b6:a03:2ad::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Wed, 17 Mar 2021 22:31:25 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3933.032; Wed, 17 Mar 2021 22:31:25 +0000 Received: from [10.74.97.52] (138.3.200.52) by CH2PR15CA0021.namprd15.prod.outlook.com (2603:10b6:610:51::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Wed, 17 Mar 2021 22:31:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5fb6fc99-4eea-40a5-8665-fd3984818369 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=1xsl4Sp7vVhV1/McVvgxVvbShTrrJX7i6O0SN0cZZ7E=; b=0hRkaezyia1UoQ/QW1pOvSskhSGV+m19U2ItG5XRupsdzIUNvpvDdmfJhEP/u9V3PTxB LjHIUroZ5Fklk//SwdxtV7Opw6Qjy4/VNFbqt57NhxEh7SFNBDKK8CuiRGxnH80bloqS zoZzOWcsCz1AMVM+ltNMMRDcVSRZpvyvXNo0WWqNUun7Yoi21+zbbDlXK0a4dxxxxgoT 1+P46sAbe2I7KFOj/rh2QB6NaFqIbZgaaG5aMs7WZH9SqmJ69Dj5A12ZX0w9Uhq6R1OB G4ik+oZo+w6uIryE4deDpCxwVkJAHLH5Zq70X48VTRAX0J1SZbX8WGMpEqnnjfg55dOo OA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ExRP+n2fqvow2rJeu6AJRmetjqioreXASrySF4zEFyfIZye8LhlFMNRuDBx++uPb3mfnWU2bOieP3tgCUa0R87QJ7LRVW1/i0EeQREkYcSKlTr50WVEA6P+PxTKKfGEafxgAxuo+OcFgnEBN0Fafl1zgnRVRF1zxUzA90knIICgC61HtyvimTYEkXcLBDv6C9nOh2D9iHZUUDjE98wl9gXZn/L7tpVh1BTYRws7oD/HFAue0wLx88cfPjeTG9jByd7tZtyBO+STZofxC2fygqjmQU55+deaW0mHY4yRRspmRRjCMqOR8L9RirrhCg1LsNX3LAxCsQNIdHnvLbNqEXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1xsl4Sp7vVhV1/McVvgxVvbShTrrJX7i6O0SN0cZZ7E=; b=bAzBYJuc123nRAjXW2cywWYE3+pAbw4FOWNFmkwkaXTB0N0yDHDwdG2527Mr7f5UdtlDSwgOmkaE5YMAdpbWSVte7fNFYz6YR7tnyMc/+Es688is1KrvGCYmISfMvs/UMidXqHX6WtWoC0WwKU9qOCGfgIAsqN4y0Bcn/S6i+iuQVzgF7wEzXQUrwTX0q30il3PORHmVFIYa2Sg58bqUz3c/JDBOYJNcCv8F3sFP6YuVjDgOrbil8xBcNUFKXIm2svYhJEst2srFV4c+utwEg2hwr8AcN4x4/Es43+EaLB/cojHFJ2brl9Z43JeYcUiSWAbRZtl1I5kvPRy+ol8iuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1xsl4Sp7vVhV1/McVvgxVvbShTrrJX7i6O0SN0cZZ7E=; b=tg83fvC7O9Lnkoy/R9tYbpYmMO3IgBIGbm+UCzgBNaZO0zje+pdjsp9oebnUs9iqWW1s8o+XqKvDfTh9lzl1I1jug8KKehsG9mClGQc0cL/bZVkav6n9kdnk8ENxIyMnO4AzlSY3ISxJKz1KeXLUZmLG11KCWvkygDVtDENA4ek= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH] xen/evtchn: replace if (cond) BUG() with BUG_ON() To: Jiapeng Chong Cc: jgross@suse.com, sstabellini@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <1615950299-96787-1-git-send-email-jiapeng.chong@linux.alibaba.com> From: Boris Ostrovsky Message-ID: <5ae410c5-6b7a-70d4-128a-255f80cddda3@oracle.com> Date: Wed, 17 Mar 2021 18:31:20 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <1615950299-96787-1-git-send-email-jiapeng.chong@linux.alibaba.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [138.3.200.52] X-ClientProxiedBy: CH2PR15CA0021.namprd15.prod.outlook.com (2603:10b6:610:51::31) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a6591767-3888-47f1-78a6-08d8e9946681 X-MS-TrafficTypeDiagnostic: SJ0PR10MB4448: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1417; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gphi1ozmTqTPQ9VMT9WRdKfbs3kN3tgKUtUUBnqq30GJk9H//AsrCbAbzie+rcwJJdPmQvXqVCGhZYUHlDehfxpg9LZFMmVHNGyeYjKWkz/Hus+Xz6ttNQcff03K22i/d4XgpX0QHja8mB/DOXV02WtgpHn0SjzqFuG78H8hjgIQ4iuMPwF3XgcQ6kvZZZGSyDhX71DWhISppXmh+YG/NIVdyk1yxnHY6epEApZs7PaNYzXPiM120VkLIDpZJhJD9nXkJ8KO9r2G6HvC1M6bYgmb2o93sDX5PFNF6oWfcKaxobb4Pk/oRhzyRQVHymAeoET0cW+U+h+Jc5AeHVSUm0DpMJpF7iKBm/Z2Vt+X3N5dGKVr3p8KjD5FIx9UnisolqGanINfcJahIKv4Sl9riwVsqRiTj3/zAav7KRjkRJTgo/Qpt5amnilmGZX7jYtmN+t+cQOWh3iuZdu0NlSoWmOtzpY183WuXo6Jb7xzofxFq3SOVs6rFn+tUaAv9oNE5L2U19v64tmEGShrtSlVDklNyLi489YFqe4OaVy1Qx2D75CUxlAMaAM7H1xIXgH3qq/DyqhV8SjdQhio4K5vfjKLKNUNIhXLxkWxslU4DIQsm61daGILX6YzELHMEQrDH/A/cm/ALhWnr0A0dkhH+A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(366004)(376002)(39860400002)(396003)(346002)(6666004)(478600001)(6486002)(86362001)(31696002)(66556008)(53546011)(66476007)(26005)(66946007)(16576012)(316002)(31686004)(36756003)(8936002)(2906002)(8676002)(5660300002)(956004)(2616005)(44832011)(6916009)(4326008)(83380400001)(186003)(16526019)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?N2VEUkdrNms2d2RxaVR4bFdaSlpHdFlBcW4xaTRTYW54WnpHbFQ3OVBaaDZ2?= =?utf-8?B?VFUvb1ZMcDZFd1JmaVVLcmN1dnZFVHFXZWRMMFVDamIzT0dqbnN6QWdjTVRZ?= =?utf-8?B?Z2IySG9RcUJrOFMzMHVzYTVvai83OFFTQTAxcC8zRzloUUpneWNkQ1N0eTJE?= =?utf-8?B?bG9vekNzaGN6M2NSUE12MTZsQUlodm1UcTRkOVRnQ3VldmJLcTNIaTEvczBX?= =?utf-8?B?SXFnTFBQandyS2VUWDhGZEk0c1M2TW52cWhQNUhva2cyRExqNW4wMWE2TGlD?= =?utf-8?B?cUxndHRudUsyYVM3WVNIRU9kZUxxZ2hwMjB0NGoya0Z2K2c4VXJlZUs2SmdJ?= =?utf-8?B?VFRWa1JUTUd3dHBIbEpOaXorakZObk5YajV1d0pxTmRMaWttV3puMmlRYjBU?= =?utf-8?B?ZnorM0R3NGErZ0Mxd2pIQlFXUlorY0Y5MFBOSXIrbFd2bXFJQW9TNXBiSmRl?= =?utf-8?B?ZmJDNjlmaTcwNElFYlluWW5WRkxaZTI0TzRjcnh0VGs1aW9FSnU1Mk5mMWo2?= =?utf-8?B?dDRNenFCbHovMVJuRmVjNmlxQzNDMmV1WW5OaDR0VkpGN3REWXYyWTIzQ3dK?= =?utf-8?B?RjJBNkZ2L3JrNkxRajdvR0UxU3lPWlRMZUp2V0p2Q2ZDZWF0TFVTcEtrODFo?= =?utf-8?B?UC9zK2VPSXpXOGNLSTVMcllNT3JmTUdMdXNoakJsYzhIbFJOVCszbWFhNXNw?= =?utf-8?B?Nk5Id0Z2ZEFoVEhFRDkzMk1CN1hwcGNZMGViU2hLSW1VajBzcmRzem4wcmhl?= =?utf-8?B?YW5WcXdVMmRkcHNTUGY2NmRjRHRxczk1MWQrTVcxT3ExWXJROEJRRDVOMWpz?= =?utf-8?B?by9rRVVsSnIvQ1lFM2xWTG9sRW1mbXZwWUlLMUJvK0toY21jQWhNRTU2OXVY?= =?utf-8?B?aXlaUWRjVnZHTm1IWW5yTDh6K2Jva0x6QlhJQTFvN1hoSllJZTdscTZjSmFn?= =?utf-8?B?V01GcUxxNjRSUXQzRFNINGZ4MC9TS09pWENlUjhWQ3c3K1NaRVY0SjN6YWty?= =?utf-8?B?WEVvN0NHVC9CRERqaVlnOGdtL29FVmpWLzBYUlpXOGlyWkRxRDNTdGMwTlFh?= =?utf-8?B?NDVaWDlzYVlVdjlKK1IrZnJ1UnMyVVR6cE52MVIzN2pkdnIvZHhrVU4xNHRx?= =?utf-8?B?dHF5ZEJmK29RNEtxc1cxcWNVWmlzK2N2Zjh0WVlBOURNSnB3bUYyNUU1V01J?= =?utf-8?B?bmRwSFNQbEdGYnU0ZzJhUWJ5Q2x3UWQzTUxzVXUzOFpTb1hLcEE3Q25CSFZB?= =?utf-8?B?anFXVm5uQ3ZMSVVsOHpGMW9QL2hYMCswUDFOcWZkY2M0d0Y1Tm44VVJjNHE3?= =?utf-8?B?eEoyMVN4ckpoNXNyREVTMEZmN09RY3AvaUNoUU9vTmVUY1o5RGhsUitHUU5z?= =?utf-8?B?QU53TnBuRFdUdGVqYktmbnZ5ajRMQ1ZGclh3VTJ0WnlHWkgwNzBHcWlJVENp?= =?utf-8?B?aTcvZTExOG9nZjN5SWpzU2h3WWttMTVVSWpLQWxoT012dWMxSW1LTnBDMklW?= =?utf-8?B?bmZSRGVNYzM4cExYQkhkVWJpY2JKekl1eWdybnFEdHdUdEV5VnhrZTBUUjRW?= =?utf-8?B?RGY4UmxCQTFrZ1JQNlRTMjRvT1JnVHBuZEtzc01pWTgyd3N6Yi9KSW5teDMx?= =?utf-8?B?T2NSVHNnZGhIQmptbG5sUVpqMWgvR3ZlZEpCa2xJSXhUb1hPdExYK0s1eW9S?= =?utf-8?B?S1V3dnZpSmUzekd2WmN3OG1JTHdDUWkzeGxEOThwVHZEUlhXRHRjVEJMVjBs?= =?utf-8?Q?gFj5CEuwJtFmhEJJnvSbe7QuKa3UkwmNklq1cRY?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6591767-3888-47f1-78a6-08d8e9946681 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 22:31:25.8547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TbArWLtj+KBeJ83inU+rxCAa0rfjbFUjXkdrr2BdVgtvqTem0zbWFhH1gYIRPyDpfqHGulJC404hu9BOppJldZW8zJtyT++L4KpHb3/iUbM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4448 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9926 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170158 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9926 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 impostorscore=0 malwarescore=0 adultscore=0 mlxscore=0 clxscore=1011 mlxlogscore=999 lowpriorityscore=0 phishscore=0 priorityscore=1501 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103170158 On 3/16/21 11:04 PM, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/xen/evtchn.c:412:2-5: WARNING: Use BUG_ON instead of if > condition followed by BUG. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/xen/evtchn.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c > index c99415a..b1c59bc 100644 > --- a/drivers/xen/evtchn.c > +++ b/drivers/xen/evtchn.c > @@ -408,8 +408,7 @@ static int evtchn_bind_to_user(struct per_user_data *u, evtchn_port_t port) > err: > /* bind failed, should close the port now */ > close.port = port; > - if (HYPERVISOR_event_channel_op(EVTCHNOP_close, &close) != 0) > - BUG(); > + BUG_ON(HYPERVISOR_event_channel_op(EVTCHNOP_close, &close) != 0); Is it actually worth doing a BUG() here at all? Seems to me WARN_ON_ONCE() should be sufficient. -boris > del_evtchn(u, evtchn); > return rc; > } From xen-devel-bounces@lists.xenproject.org Wed Mar 17 23:51:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 17 Mar 2021 23:51:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98801.187649 (Exim 4.92) (envelope-from ) id 1lMfwf-0005fR-B9; Wed, 17 Mar 2021 23:51:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98801.187649; Wed, 17 Mar 2021 23:51:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMfwf-0005fK-7j; Wed, 17 Mar 2021 23:51:21 +0000 Received: by outflank-mailman (input) for mailman id 98801; Wed, 17 Mar 2021 23:51:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMfwd-0005fA-Vw; Wed, 17 Mar 2021 23:51:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMfwd-0000jm-PC; Wed, 17 Mar 2021 23:51:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMfwd-0001mq-GI; Wed, 17 Mar 2021 23:51:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMfwd-0003Su-Fm; Wed, 17 Mar 2021 23:51:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wA4TfVw/FOldiNK3WIfowZz3nu/2VAbn+jkBaib3bhw=; b=5KPeg3aogEPT8CCDO5fOl9lvvZ e9V7pBU2/BvJrz989ssBcM9AZDj+w7sl47k5DA86vnxiNG3eDDE8UUzPfjzC7VKgvoZ7M+8JPeOXH zyXkZxvm6yz/I99BrzBMsQuXRnGGxxxHJ+BWUyC/w0R7Vfo92ZcTcZB6Txz9Cn9hE5ts=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160113: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=5d1428d6c43942cfb40a909e4c30a5cbb81bda8f X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Wed, 17 Mar 2021 23:51:19 +0000 flight 160113 qemu-mainline real [real] flight 160118 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160113/ http://logs.test-lab.xenproject.org/osstest/logs/160118/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160118-retest Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 5d1428d6c43942cfb40a909e4c30a5cbb81bda8f baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 209 days Failing since 152659 2020-08-21 14:07:39 Z 208 days 404 attempts Testing same since 160113 2021-03-17 11:11:37 Z 0 days 1 attempts ------------------------------------------------------------ 455 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 130343 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 18 02:24:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 02:24:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98810.187664 (Exim 4.92) (envelope-from ) id 1lMiKc-0005EB-2W; Thu, 18 Mar 2021 02:24:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98810.187664; Thu, 18 Mar 2021 02:24:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMiKb-0005E4-Uu; Thu, 18 Mar 2021 02:24:13 +0000 Received: by outflank-mailman (input) for mailman id 98810; Thu, 18 Mar 2021 02:24:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMiKa-0005Dw-Pd; Thu, 18 Mar 2021 02:24:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMiKa-0005kq-Ez; Thu, 18 Mar 2021 02:24:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMiKa-0001Y7-4i; Thu, 18 Mar 2021 02:24:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMiKa-0000W5-43; Thu, 18 Mar 2021 02:24:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aAy+apcMGRhHXkUTEkkubbuCGjy8UpBaspFZKwkgu4g=; b=S1AOwkHMlmPmUsJHbSxwRHJa4j I0AxksyqKM07ppl5Hc/JEONDzeCvR87NkDmcxw69EK3MKjbN554QAzk5WgsXHy907jxXnX6OvhrAP uwRry6NUPjnGAFK7A5pOLdUdonOO1bRL07cPL9mgoCENMvo2ySAOSFVfa042jGEE6mGA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160115: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1df27313f50a57497c1faeb6a6ae4ca939c85a7d X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Thu, 18 Mar 2021 02:24:12 +0000 flight 160115 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160115/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 1df27313f50a57497c1faeb6a6ae4ca939c85a7d baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 229 days Failing since 152366 2020-08-01 20:49:34 Z 228 days 397 attempts Testing same since 160105 2021-03-17 01:42:05 Z 1 days 2 attempts ------------------------------------------------------------ 5217 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1294111 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 18 04:41:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 04:41:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98816.187679 (Exim 4.92) (envelope-from ) id 1lMkT4-0001Bs-9j; Thu, 18 Mar 2021 04:41:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98816.187679; Thu, 18 Mar 2021 04:41:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMkT4-0001Bl-4n; Thu, 18 Mar 2021 04:41:06 +0000 Received: by outflank-mailman (input) for mailman id 98816; Thu, 18 Mar 2021 04:41:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMkT2-0001Bd-VM; Thu, 18 Mar 2021 04:41:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMkT2-0007zh-QU; Thu, 18 Mar 2021 04:41:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMkT2-0006wd-Cp; Thu, 18 Mar 2021 04:41:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMkT2-0003m6-CK; Thu, 18 Mar 2021 04:41:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=H4hmkS2/xGxD4KUEE9Ldvtk0k3oQ8sZRYLpEJX2lVtU=; b=5IJkHkQRgiGY5rQflvjfxwn7Mh YtykLxkQ+O6xl9slB0umLMF/BSFxCk+xNo3IN8UaiFTFVJ1yKjzCG3u2kwwio5xemI+qPO+0vCQYA vCLVR8tkCo9OYUSUAcxgCy45LjmfMY6/Q8U7J6tVWlRtacdNku+0z/NKadAr68Y8R4xk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160117: all pass - PUSHED X-Osstest-Versions-This: ovmf=030ba3097a6e7d08b99f8a9d19a322f61409c1f6 X-Osstest-Versions-That: ovmf=e4ff3773b711527ff46759759f34ea1cb9ff2a45 From: osstest service owner Date: Thu, 18 Mar 2021 04:41:04 +0000 flight 160117 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160117/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 baseline version: ovmf e4ff3773b711527ff46759759f34ea1cb9ff2a45 Last test of basis 160114 2021-03-17 11:39:41 Z 0 days Testing same since 160117 2021-03-17 20:41:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Laszlo Ersek Ray Ni jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git e4ff3773b7..030ba3097a 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Mar 18 04:43:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 04:43:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98821.187693 (Exim 4.92) (envelope-from ) id 1lMkVp-0001LQ-NL; Thu, 18 Mar 2021 04:43:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98821.187693; Thu, 18 Mar 2021 04:43:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMkVp-0001LJ-KG; Thu, 18 Mar 2021 04:43:57 +0000 Received: by outflank-mailman (input) for mailman id 98821; Thu, 18 Mar 2021 04:43:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMkVn-0001LB-OW; Thu, 18 Mar 2021 04:43:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMkVn-00081b-Hm; Thu, 18 Mar 2021 04:43:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMkVn-00073R-65; Thu, 18 Mar 2021 04:43:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMkVn-0005jj-5Y; Thu, 18 Mar 2021 04:43:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KTLYBeJON15ohtbkQ4N7foACAGcyvJKJTlH9ZrYJAqs=; b=XCkxQnIiWZGwqQ7gl05neqO3T9 +QbBSgY3eAM0RjeR6RwK7Xop5n/mbvNE+QO9Suk+xvCUfqNHK42+ToVZVtWKlQ2keihDE2nkAHPhF sw6WKcpYW+qwE9w9ReZroEqM6IkU2fw1kRMt4IFZeYspg9ymoOSXgRfF1CcENWJESbv0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 160116: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0437de26e28dd844f51fde7a749a82cb2d3694ad X-Osstest-Versions-That: linux=ce615a08404c821bcb3c6f358b8f34307bfe30c9 From: osstest service owner Date: Thu, 18 Mar 2021 04:43:55 +0000 flight 160116 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/160116/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159939 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159939 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159939 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159939 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159939 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159939 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159939 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159939 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159939 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159939 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159939 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 0437de26e28dd844f51fde7a749a82cb2d3694ad baseline version: linux ce615a08404c821bcb3c6f358b8f34307bfe30c9 Last test of basis 159939 2021-03-11 13:40:17 Z 6 days Testing same since 160116 2021-03-17 16:11:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abhishek Sahu Adrian Hunter Al Viro Alain Volmat Aleksandr Miloserdov Andreas Kempe Andreas Larsson Andrew Morton Andrey Konovalov Andy Shevchenko Anna Schumaker Anna-Maria Behnsen Anshuman Khandual Antony Antony Ard Biesheuvel Arnaldo Carvalho de Melo Arnd Bergmann Artem Lapkin Athira Rajeev Balazs Nemeth Benjamin Coddington Bernhard Biju Das Bjoern Walk Bjorn Helgaas Björn Töpel Bjørn Mork Boris Ostrovsky Borislav Petkov Catalin Marinas Chaotian Jing Christian Brauner Christian Hewitt Christoph Hellwig Christoph Lameter Christophe JAILLET Christophe Leroy Colin Ian King Daiyue Zhang Dan Carpenter Daniel Borkmann Daniel Vetter Daniel Vetter Daniele Palmas Danielle Ratson David Hildenbrand David S. Miller Dmitry Baryshkov Dmitry Torokhov Dmitry V. Levin Dmitry Vyukov Edwin Peer Eric Dumazet Eric Farman Eric W. Biederman Felix Fietkau Filipe Laíns Florian Fainelli Florian Westphal Forest Crossman Frank Li Frank Li Ge Qiu Geert Uytterhoeven Gerd Hoffmann Greg Kroah-Hartman Greg Kurz Guangbin Huang Guenter Roeck Hangbin Liu Hans de Goede Hans Verkuil Hans Verkuil Heikki Krogerus Heiko Carstens Helge Deller Hillf Danton Huazhong Tan Hulk Robot Ian Abbott Ian Rogers Ido Schimmel Ingo Molnar Ivan Babrou Jakub Kicinski Jan Kara Jason Self Jens Axboe Jia-Ju Bai Jian Shen Jiri Kosina Jiri Wiesner Joakim Zhang Joerg Roedel Johan Hovold John Ernberg John Fastabend Jon Hunter Josh Poimboeuf Juergen Gross Kalle Valo Karan Singhal Keita Suzuki Keith Busch Kevin Hilman Kevin(Yudong) Yang Khalid Aziz Krzysztof Wilczyński Lee Gibson Lin Feng Linus Torvalds Linux Kernel Functional Testing Lior Ribak Lorenzo Bianconi Lorenzo Colitti Lorenzo Pieralisi Lubomir Rintel Maarten Lankhorst Maciej Fijalkowski Marc Kleine-Budde Marc Zyngier Mark Brown Martin K. Petersen Martin Kaiser Martin Schiller Masahiro Yamada Mathias Nyman Mathieu Desnoyers Matthew Wilcox (Oracle) Matthias Kaehlcke Mauro Carvalho Chehab Maxim Mikityanskiy Maxime Ripard Maximilian Heyne Michael Chan Michael Ellerman Michael Walle Michal Hocko Mika Westerberg Mikael Beckius Mike Christie Mike Rapoport Minchan Kim Namhyung Kim Naveen N. Rao Neil Armstrong Neil Roberts Nicholas Piggin Niv Sardi Oleksij Rempel Oliver O'Halloran Ondrej Mosnacek Ong Boon Leong Pablo Neira Ayuso Paul Cercueil Paul Moore Paulo Alcantara (SUSE) Paulo Alcantara Pavel Skripkin Pete Zaitcev Peter Zijlstra (Intel) Rafael J. Wysocki Ramesh Babu B Ronald Tschalär Ross Lagerwall Ross Schmidt Ruslan Bilovol Sasha Levin Sean Young Sebastian Reichel Segher Boessenkool Serge Semin Sergey Shtylyov Shannon Nelson Shile Zhang Shuah Khan Simeon Simeonoff Stanislaw Gruszka Stefan Haberland Steve French Steven J. Magnani Steven Price Suravee Suthikulpanit Takashi Iwai Thomas Gleixner Tj (Elloe Linux) Tony Brelinski Tony Nguyen Torin Cooper-Bennun Trond Myklebust Ulf Hansson Vasily Averin Vasily Gorbik Vladimir Oltean Wang Qing Will Deacon Willem de Bruijn William Tu Wolfram Sang Wolfram Sang Xie He Yauheni Kaliuta Yi Chen Yorick de Wid Yoshihiro Shimoda Zbynek Michl jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git ce615a08404c..0437de26e28d 0437de26e28dd844f51fde7a749a82cb2d3694ad -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Thu Mar 18 07:22:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 07:22:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98831.187709 (Exim 4.92) (envelope-from ) id 1lMmye-0007Yb-BG; Thu, 18 Mar 2021 07:21:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98831.187709; Thu, 18 Mar 2021 07:21:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMmye-0007YU-83; Thu, 18 Mar 2021 07:21:52 +0000 Received: by outflank-mailman (input) for mailman id 98831; Thu, 18 Mar 2021 07:21:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMmyd-0007YP-AB for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 07:21:51 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 724c1f0b-7f41-451b-8063-ef195b2d8597; Thu, 18 Mar 2021 07:21:49 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9800EED1; Thu, 18 Mar 2021 00:21:48 -0700 (PDT) Received: from [10.57.19.39] (unknown [10.57.19.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E30D13F718; Thu, 18 Mar 2021 00:21:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 724c1f0b-7f41-451b-8063-ef195b2d8597 Subject: Re: [PATCH v7] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com References: <20210315092342.26533-1-michal.orzel@arm.com> <3473f8d3-c42a-9182-b4fa-c3eacb44338f@xen.org> From: Michal Orzel Message-ID: <75800277-4107-0060-aece-d01cf29d3086@arm.com> Date: Thu, 18 Mar 2021 08:21:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <3473f8d3-c42a-9182-b4fa-c3eacb44338f@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Julien, On 16.03.2021 15:54, Julien Grall wrote: > Hi Michal, > > On 15/03/2021 09:23, Michal Orzel wrote: >> Currently in order to link existing DTB into Xen image >> we need to either specify option CONFIG_DTB_FILE on the >> command line or manually add it into .config. >> Add Kconfig entry: CONFIG_DTB_FILE >> to be able to provide the path to DTB we want to embed >> into Xen image. If no path provided - the dtb will not >> be embedded. >> >> Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >> as it is not needed since Kconfig will define it in a header >> with all the other config options. >> >> Make a change in the linker script from: >> _sdtb = .; >> to: >> PROVIDE(_sdtb = .); >> to avoid creation of _sdtb if there is no reference to it. > > This means that if someone is using #ifdef CONFIG_DTB_FILE rather than .ifnes, _sdtb will get defined. Do we really want to overengineer something that simple? Why would someone use #ifdef CONFIG_DTB_FILE? In my opinion the rule of thumb is that you don't use #ifdef on configs of string type. Using #ifdef CONFIG_DTB_FILE means that someone modifying the code did not even spend 1 minute checking the Kconfig. If you do not agree, I can modify the code so _sdtb will be created in dtb.S. In that case I would like Jan Beulich to give his opinion before I will send v8. > > The difference between two is quite subttle and can be easily missed during review. > > How about defining _sdtb in dtb.S? With that approach, we would get a compiler error if someone protect _sdtb with #ifdef rather than .ifnes. > > Cheers, > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Thu Mar 18 07:54:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 07:54:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98834.187720 (Exim 4.92) (envelope-from ) id 1lMnU5-0001t6-UZ; Thu, 18 Mar 2021 07:54:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98834.187720; Thu, 18 Mar 2021 07:54:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMnU5-0001sz-RO; Thu, 18 Mar 2021 07:54:21 +0000 Received: by outflank-mailman (input) for mailman id 98834; Thu, 18 Mar 2021 07:54:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMnU4-0001su-5p for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 07:54:20 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ca0553d6-f24f-4936-9f84-e1fa217f704e; Thu, 18 Mar 2021 07:54:18 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 12D71AC17; Thu, 18 Mar 2021 07:54:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca0553d6-f24f-4936-9f84-e1fa217f704e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616054058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KqVTQOSlwTnfGVatGEsqZH6VD+3sffoqhHtQT353LWI=; b=iji9pk69Hcds/yscgjDIX7sMc55IS7SzAMrua3FS9Q2RC2JaGJuZXQOJuc2dAUPZlfjBjt XlEhqOvMikPGltEzTD0qjb0DO0iHLMgdEPXmVnF65XSlT/KECBuwGKl0zS+TNow8TnHaXB EOlzINDi7EVX+YJxvEz7CavBa/XVUMc= To: Luca Fancellu , "xen-devel@lists.xenproject.org" Cc: "jgrall@amazon.com" References: From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 Message-ID: Date: Thu, 18 Mar 2021 08:54:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TKNWxujNkbkYNCaB91laL1dpKBarJ4Dgu" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TKNWxujNkbkYNCaB91laL1dpKBarJ4Dgu Content-Type: multipart/mixed; boundary="OqlQoihluSx1iltbYMXdla8xQvGq1xXXE"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Luca Fancellu , "xen-devel@lists.xenproject.org" Cc: "jgrall@amazon.com" Message-ID: Subject: Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 References: In-Reply-To: --OqlQoihluSx1iltbYMXdla8xQvGq1xXXE Content-Type: multipart/mixed; boundary="------------E9E146BC0F21D1B1EA776613" Content-Language: en-US This is a multi-part message in MIME format. --------------E9E146BC0F21D1B1EA776613 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 17.03.21 15:32, Luca Fancellu wrote: >=20 > Hi all, >=20 > we've been encountering an issue when using the kernel 5.10 with=20 > preempt_rt support for Dom0, the problem is that during the boot of=20 > Dom0, it hits a BUG_ON(!irqs_disabled()) from the=20 > function=C2=A0evtchn_fifo_unmask defined in events_fifo.c. >=20 > This is the call stack: >=20 > [ =C2=A0 17.817018] ------------[ cut here ]------------ > [ =C2=A0 17.817021] kernel BUG at drivers/xen/events/events_fifo.c:258!= > [ =C2=A0 18.817079] Internal error: Oops - BUG: 0 [#1] PREEMPT_RT SMP > [ =C2=A0 18.817081] Modules linked in: bridge stp llc ipv6 > [ =C2=A0 18.817086] CPU: 3 PID: 558 Comm: xenstored Not tainted=20 > 5.10.16-rt25-yocto-preempt-rt #1 > [ =C2=A0 18.817089] Hardware name: Arm Neoverse N1 System Development=20 > Platform (DT) > [ =C2=A0 18.817090] pstate: 60400005 (nZCv daif +PAN -UAO -TCO BTYPE=3D= --) > [ =C2=A0 18.817092] pc : evtchn_fifo_unmask+0xd4/0xe0 > [ =C2=A0 18.817099] lr : xen_irq_lateeoi_locked+0xec/0x200 > [ =C2=A0 18.817102] sp : ffff8000123f3cc0 > [ =C2=A0 18.817102] x29: ffff8000123f3cc0 x28: ffff0000427b1d80 > [ =C2=A0 18.817104] x27: 0000000000000000 x26: 0000000000000000 > [ =C2=A0 18.817106] x25: 0000000000000001 x24: 0000000000000001 > [ =C2=A0 18.817107] x23: ffff0000412fc900 x22: 0000000000000004 > [ =C2=A0 18.817109] x21: 0000000000000000 x20: ffff000042e06990 > [ =C2=A0 18.817110] x19: ffff0000427b1d80 x18: 0000000000000010 > [ =C2=A0 18.817112] x17: 0000000000000000 x16: 0000000000000000 > [ =C2=A0 18.817113] x15: 0000000000000002 x14: 0000000000000001 > [ =C2=A0 18.817114] x13: 000000000001a7e8 x12: 0000000000000040 > [ =C2=A0 18.817116] x11: ffff000040400248 x10: ffff00004040024a > [ =C2=A0 18.817117] x9 : ffff800011be5200 x8 : ffff000040400270 > [ =C2=A0 18.817119] x7 : 0000000000000000 x6 : 0000000000000003 > [ =C2=A0 18.817120] x5 : 0000000000000000 x4 : ffff000040400308 > [ =C2=A0 18.817121] x3 : ffff0000408a400c x2 : 0000000000000000 > [ =C2=A0 18.817122] x1 : 0000000000000000 x0 : ffff0000408a4000 > [ =C2=A0 18.817124] Call trace: > [ =C2=A0 18.817125] =C2=A0evtchn_fifo_unmask+0xd4/0xe0 > [ =C2=A0 18.817127] =C2=A0xen_irq_lateeoi_locked+0xec/0x200 > [ =C2=A0 18.817129] =C2=A0xen_irq_lateeoi+0x48/0x64 > [ =C2=A0 18.817131] =C2=A0evtchn_write+0x124/0x15c > [ =C2=A0 18.817134] =C2=A0vfs_write+0xf0/0x2cc > [ =C2=A0 18.817137] =C2=A0ksys_write+0xe0/0x100 > [ =C2=A0 18.817139] =C2=A0__arm64_sys_write+0x20/0x30 > [ =C2=A0 18.817142] =C2=A0el0_svc_common.constprop.0+0x78/0x1a0 > [ =C2=A0 18.817145] =C2=A0do_el0_svc+0x24/0x90 > [ =C2=A0 18.817147] =C2=A0el0_svc+0x14/0x20 > [ =C2=A0 18.817151] =C2=A0el0_sync_handler+0x1a4/0x1b0 > [ =C2=A0 18.817153] =C2=A0el0_sync+0x174/0x180 > [ =C2=A0 18.817156] Code: 52800120 b90023e6 97e6d104 17fffff0 (d4210000= ) > [ =C2=A0 18.817158] ---[ end trace 0000000000000002 ]--- >=20 > Our last tested kernel was the 5.4 and our analysis pointed out that th= e=20 > introduction of the lateeoi framework (xen/events: add a new "late EOI"= =20 > evtchn framework) in conjunction with the preempt_rt patches (irqs kept= =20 > enabled between spinlock_t/rwlock_t _irqsave///=E2=80=8B_irqrestore ope= rations)=20 > is the root cause. >=20 > Given that many modifications were made to the mask/unmask operations, = a=20 > big one from=C2=A0Juergen Gross (xen/events: don't unmask an event chan= nel=20 > when an eoi is pending), is the BUG_ON(...) still needed? >=20 > With the mentioned commit every call to a mask/unmask operation is=20 > protected by a spinlock, so I would like to have some feedbacks from wh= o=20 > has more experience than me on this part of the code. I think this BUG_ON() can be removed. Are you planning to send a patch? Juergen --------------E9E146BC0F21D1B1EA776613 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------E9E146BC0F21D1B1EA776613-- --OqlQoihluSx1iltbYMXdla8xQvGq1xXXE-- --TKNWxujNkbkYNCaB91laL1dpKBarJ4Dgu Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBTBygFAwAAAAAACgkQsN6d1ii/Ey+i aQgAmE15CmXClDlmul+s2G428TjtQULnxpJfHeNWNyiDO/1Jp05Dc1fzM+geso8HkOeBQp8sKItD 08M20G6FJx7h8OiYnAMFQXmZjHTPP6LE1AIYJkVLYRZ+WpHd4OSYlfsNKI+HcujHVrlpQqIUuwIW 2g0SfLQH9977mjc7/vK8MjAwVnhnMLaap51A/FKchL4/n3D/m96vKwPRuPLOXIIzBQjUFoVwnvfx lHigeEu3r9wQ2bJzSEY2FUtzD04VTHH0R2q4dhvpT/ZTB5/nF4WyqXyTcUrb61H5GpR2HWADZttk atb2VOySNwUJkfYzf4t8cR4PThozKoYpXS3aQfyowQ== =mfN4 -----END PGP SIGNATURE----- --TKNWxujNkbkYNCaB91laL1dpKBarJ4Dgu-- From xen-devel-bounces@lists.xenproject.org Thu Mar 18 08:47:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 08:47:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98841.187733 (Exim 4.92) (envelope-from ) id 1lMoJY-0006zT-3K; Thu, 18 Mar 2021 08:47:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98841.187733; Thu, 18 Mar 2021 08:47:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMoJX-0006zM-W6; Thu, 18 Mar 2021 08:47:31 +0000 Received: by outflank-mailman (input) for mailman id 98841; Thu, 18 Mar 2021 08:47:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMoJW-0006zH-P2 for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 08:47:30 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (unknown [40.107.5.41]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 55a5a849-ff6d-4fe5-a5d0-93db679bce82; Thu, 18 Mar 2021 08:47:27 +0000 (UTC) Received: from DU2PR04CA0010.eurprd04.prod.outlook.com (2603:10a6:10:3b::15) by PR3PR08MB5676.eurprd08.prod.outlook.com (2603:10a6:102:82::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Thu, 18 Mar 2021 08:47:25 +0000 Received: from DB5EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3b:cafe::98) by DU2PR04CA0010.outlook.office365.com (2603:10a6:10:3b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Thu, 18 Mar 2021 08:47:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT022.mail.protection.outlook.com (10.152.20.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Thu, 18 Mar 2021 08:47:24 +0000 Received: ("Tessian outbound 259fb7427a57:v87"); Thu, 18 Mar 2021 08:47:24 +0000 Received: from cad2983a9133.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D6E58E56-CFF0-4D6B-A259-B704B630338E.1; Thu, 18 Mar 2021 08:47:17 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cad2983a9133.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 18 Mar 2021 08:47:17 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) by VE1PR08MB5661.eurprd08.prod.outlook.com (2603:10a6:800:1b3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Thu, 18 Mar 2021 08:47:15 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642]) by VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642%4]) with mapi id 15.20.3933.033; Thu, 18 Mar 2021 08:47:15 +0000 Received: from a75445.arm.com (82.8.129.65) by LO4P123CA0069.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Thu, 18 Mar 2021 08:47:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55a5a849-ff6d-4fe5-a5d0-93db679bce82 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOaFZqw/94qy9TlAD5tyDSboUXLAWK6+zX2L7IxX6dE=; b=anJUY5wh6o1S6iMtKPSFO/ById3hlWXKvKM3Eyjxmpf3LjDGvBrG79/ZL9V9N//NGx5+TF+8Pim6/Qe2+8e38NS50jh5LKAnKmXaHd163NRz4FCbz9mrsmtKwFtq1eER5ARgbJXpoPlY+94ytAadvJHm/b5mXMu8akPNnQ/bk88= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 0c83773d974617e7 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G305x5fNoKgG4fcFqLXQx8I1HJrncUWk3GEIoyWlvT7gAtm2i4Xwtpq3kCn+Dm130jHauAaIYH5UOHTiwkoHA9v2BLkM9Teo23T5wxIfqXLnxO5GlZabZYWLz1qljgzKUQ6FdMrx1t285AWyGnYBUz5B+TYRQcFc2LCLwhY+btBje7PgZbHrLMEHDtY2bBd01mEJ5pP1qwq1WrOAxIRDsI63W4c25F28PfRbVKNAa6O/EN0y+4F5heS/iRYPmhb3nJx5tavIyO+eghf2R/FfVvFWrXSKnrIpssa/ApEDgQ4tL+R6E5gciKmlbkehIGyd5Dabfcqp18Ivhq+WXGwQrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOaFZqw/94qy9TlAD5tyDSboUXLAWK6+zX2L7IxX6dE=; b=JbqJNkDETlBnF0i6JgYX8RiTGrCUpWw956j+97WW6Hk+vEI3YIvfQsYFpbDiiYr4Jyxgyy1Ioi7RzBIiKgfduDsF+C5etYmKLmRjXpb/NxbploxViZAkKEXDTjiZ67hyuYNUYGZE44MOoWI/vvJmOOtRlO5kpNNQF4/FyA4X+zPJ379CAFoidAhqX2w3bpiglsL5L4zxAOkoV8LOJ4xJh585EogWgIBgX/Wfil2UOo+ldiynldkmFeuZNCHm2sVV+I97kbi8m+RJIS2mC8fvYjetzwy/pcJVDyF/jkY0m4JQk5XrhXjuMAWMkwb2aQXT/r17toQFon2sOjUlplkwKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOaFZqw/94qy9TlAD5tyDSboUXLAWK6+zX2L7IxX6dE=; b=anJUY5wh6o1S6iMtKPSFO/ById3hlWXKvKM3Eyjxmpf3LjDGvBrG79/ZL9V9N//NGx5+TF+8Pim6/Qe2+8e38NS50jh5LKAnKmXaHd163NRz4FCbz9mrsmtKwFtq1eER5ARgbJXpoPlY+94ytAadvJHm/b5mXMu8akPNnQ/bk88= Authentication-Results-Original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 From: Luca Fancellu In-Reply-To: Date: Thu, 18 Mar 2021 08:47:07 +0000 Cc: "xen-devel@lists.xenproject.org" , "jgrall@amazon.com" Content-Transfer-Encoding: quoted-printable Message-Id: References: To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO4P123CA0069.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::20) To VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b9c4a6b2-629f-4fe8-cbe9-08d8e9ea73d5 X-MS-TrafficTypeDiagnostic: VE1PR08MB5661:|PR3PR08MB5676: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3jLtFGf1izX1kvs825T8ZIz9LivRGxlZ2SaQi3yTq1q684EcJ4etgH1dGoyWarAshv0iD157RGoN+wB7xhsg2oDVLOG/Hc2RdgKXxf0Q4vc+FdEq7J4/AjlFWzGEDkqpC+n1m1Pg1AKX/T8NhZ09gmuQQTpLY6bfebD6EyOAS17C7SxF1uKOP6Ig2RUB8K+KwuSY3e5sA6k13tO7rjxMo+YKLXC7asa00xRmDD5eEJ8UaCk3C18jozqFC0El3GWj9ck3D0PuvZ5Z9+W4nvf91g4X2V0Znv2YyYtKLMKXGnL0cWWTJTMq5PFkIPSPvh3n+rgI3+4JLJTJzpOK3vg15oghlJznQmlnBPjtf+/zTITtIA+ZJHOe3eZXJWguWdGMumdbg2uRAteFi+TT9a+Q3DQ/yk1fyfvnSywQymGzzFKw9l9zJ4YBgZ1Yhy4XSavWUVDN7DiHsfYnPAzyI1YsMvgLmRlKE8Z/P/eRO/qra/vg8kUXfPquADVMHjMTepgvYwRHrVJ/YztKla4aIyW2UBZ/bzr0HMqsoPO9p8xFvaLPBTHlW35GT/5voKEzWdj3UnTSJnH0B4XXNWuIbyPEmTmP5NWgiAjvwtNleY0D9nKs5VUIulOzqGfr1pcLjFvlLu89rkrgq/GiIgMCpUx9GA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3629.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39850400004)(366004)(376002)(346002)(136003)(66946007)(6916009)(6486002)(7696005)(86362001)(66476007)(8936002)(5660300002)(33656002)(52116002)(83380400001)(38100700001)(6666004)(4326008)(66574015)(36756003)(53546011)(54906003)(316002)(44832011)(478600001)(2616005)(26005)(8676002)(186003)(16526019)(2906002)(45080400002)(956004)(66556008)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NTl1L0NYM0ZPbjg3MEpWWkh2bzllbyt5M2t6TXB6MXpUN05IaXIzbmRBVlBO?= =?utf-8?B?bm82UldSY3dKbXNXWnNzNnkxaGtjeGc3YjhKQUVhcTh1VmFEZ0NEeEoxNmdM?= =?utf-8?B?SndwbVhHZ1BnRVU2N2REeC80ejBwQWt5TG1JTjB3NFR2OE9aQ0N6YW1CRW9L?= =?utf-8?B?bkR4TEFQREpaWDFFQk0vTkx3Nm5CMmRCK1B6cmtQUFNoTVgvUFVVbWVFWlJp?= =?utf-8?B?VG1iWkVicnRMRkxvOW9lNU5TSzNuQ0ZGcGdnS3NGTXZtNUpaSFM2cW80TExK?= =?utf-8?B?SzFFMC9lK2NvUXdvUnYvVWNvbm5EczEwc2toNUxlM3RWR1FBUXIycUFaL3o0?= =?utf-8?B?TEsyUWVqMXAzY0hCc245M0FiNll4aEdFYS9saVZCaWx4dVhHT2srcnVMVWEw?= =?utf-8?B?NUw5MzhSZExUeDdVMlFaMncxYUt5ai8wTTBvTlgrUVRuYWsra3ZZSndnNEI5?= =?utf-8?B?bWMvdnpxanBMWk0rRWp0NUJoc29EWjFhbnRaU1h3YmFVT3NkZ3FsVTRqS2o1?= =?utf-8?B?QlJwMDI2VC8rQk9SMWlOajlBaEhsTEs1TFREZTdZS3JrZnVRS0RvMnVBYlZI?= =?utf-8?B?UFVMeGpiSHR0dmdSb1Q5U3FvL1EvM2VVcDVyeUNkOFV5Z2ZhYkpORlpQLzNi?= =?utf-8?B?Y2xWZXh3TVM1RnU0WUFYSnArRVEySHQvUWNSK0F4Yk1Zdk5QTWxkNDBvNTBV?= =?utf-8?B?WkdDak1Ja1h2RkY4c2xzc3pDcllJekNha0x4SVRINm1hemZQNFNXcGdhdUll?= =?utf-8?B?N0JkbmJKVWRWL0crVFBZOHFvK2oxWnNZNi8wN2FpUXBSenYxMEswVE8rbTBl?= =?utf-8?B?bXo4ZW9zK29FSHlmVDY0a1E2RE52dUJJbGdzeUxmKzlNZUpITGM0N3dNN3VV?= =?utf-8?B?TzgrRTc2SWtRQlBYRlF6QXl2OEl1ZEhsU3FpZlhFTWlBMEM5OXV6UjJsbmVy?= =?utf-8?B?WkhLYkFYTUxHa2c5Y0xzc0lOVlRuNzB4YWN2L21wdjROanhNcU13K1ZyNWht?= =?utf-8?B?dkY4U1kvSGdBSWZPVVhPOVptTU81c0Z6cy84M2t2UW9kMSs0OHlZUVdzZ0t4?= =?utf-8?B?MFIwVnhIYWZxUFVWc1hMYUlVZ1dqd09XQ3pidTd5dVF4WDNoK2pORS9aenQ4?= =?utf-8?B?Sk1MZGV6Q3JBQkRraHlLMy9HamZvcGdoL1RYbHVMeFFKejlwYW1Ob2F3eFZ1?= =?utf-8?B?Ny9VWEpyaU85b29UTGhjTzNIMDVtRWpOVWxaL09SQXhlaDc5dktCRllSc3Z1?= =?utf-8?B?K2hUdnV4S2RpRW84VHlYbkFWS2RsTkZ4cXFIRzl5TVBzQU44L1ZzbHp2dUxF?= =?utf-8?B?elY5Y1lpK3pkYVRjMTNDOWtYZ1JBOXl5dmVKZHIwZU90OGNOa0lrWExleGhj?= =?utf-8?B?N3E5NjQ3L04xR2xDOVRPL21FL09rdk9rMFp2Q2VwNGNnZ2dqVFZYQzFiRm1i?= =?utf-8?B?UWJZNUkrY2lQNUprT0h1MlkzYUd2K1FDVDNNNDdhaWF6WVpYREgvMTcyUUtB?= =?utf-8?B?eTdaazFrWW92THM2WWNyTnFZOXlZWVZWUDF2bjc4aVBFWnkvN3d6Z0JFMTBl?= =?utf-8?B?QkRLekxPYy8xUldqeTB4cTFQeGNxc3ZvZWQwQmZrNVdXY1BMYWowWk5CYk50?= =?utf-8?B?Y1VwTDAzdCtEVENzOEFScTlQWVpRM1FveFdOd2FrMU1iZXVNeWxzOCt1ejda?= =?utf-8?B?ajM5THFCNDcrL0c4cmRNNmZRbFZUSE5IK0JUdU9RTnVvUTZBS0k2OTdXb1ZC?= =?utf-8?Q?ZCPuh/Wc2l5lR7TctatY5bnSiMsGNjw3h9/aoXO?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5661 Original-Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 0161cdbf-80e1-4128-2030-08d8e9ea6e3d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N43gc9c9YJ3DWlwntdain9z50OJWBAbelvIPywJ1j/p85Z68GvcR0E/ajDlPIf68w5kKJCGKzyct/e/Ot9Srl/53oc7rohqXO3vZMS3t8J8k0n5cqYylwfGorH6Tmr46V5SwvzwlMYoHdT9wPZQ8/8cf29eTxnk5g11Md5dBsp4PF55XjLuzNaD4u1fLZhl54SAc60al6A5FzOlo9mUZUwgyenZp7xiTwst29nenUr38lMSf+fjqDya9fqfMvfKh8eoIY8WGVsvrx+DEHI5x2SERTtXYryFsrinG4y7ER2qwhSZyXtoS1qBJh92OIP4VXzUz+phD3sX+vn84F3+oco8yfGmPOhuCFU3JCNZDoBbpWeOrrhQmHyO4ERuT99RkOzQPulnVSnoaYuSzIArQhcpuf11FWWWTRmA08EOqiTSVHsQbUG74l+ImjWuvpRhliQcf2qJFqyf/1mzK1xQN2mQAbuI4afAMwgP0ucvxvHDUIut1D3hbd05FWYOaNjAKrMN2wopgehs8YGYMCq2VMNmXgK148Ky59VY2r9cYkDzQzQ2kM2s/TUPE5HTupmpjxFk1JRrYJNG82TrCXDN9i2L6o1oYN4CVPkXJJbyIJDNgZhDflrhIl1WdTLuEiuKNcM+Z3eOaW6O5/RYt048lPLC0xlFGhffwRxmiej0Jrtk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(39850400004)(346002)(136003)(376002)(36840700001)(46966006)(81166007)(83380400001)(5660300002)(316002)(7696005)(70586007)(4326008)(6666004)(6862004)(26005)(356005)(336012)(8676002)(70206006)(6486002)(8936002)(186003)(86362001)(45080400002)(16526019)(47076005)(82310400003)(54906003)(107886003)(36860700001)(33656002)(44832011)(478600001)(2906002)(36756003)(956004)(82740400003)(66574015)(2616005)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2021 08:47:24.7815 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b9c4a6b2-629f-4fe8-cbe9-08d8e9ea73d5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5676 Hi Juergen, If you are willing to do the patch I think it will be faster to being accep= ted, what about the BUG_ON(=E2=80=A6) in evtchn_2l_unmask from events_2l.c = file? Cheers, Luca > On 18 Mar 2021, at 07:54, J=C3=BCrgen Gro=C3=9F wrote: >=20 > On 17.03.21 15:32, Luca Fancellu wrote: >> Hi all, >> we've been encountering an issue when using the kernel 5.10 with preempt= _rt support for Dom0, the problem is that during the boot of Dom0, it hits = a BUG_ON(!irqs_disabled()) from the function evtchn_fifo_unmask defined in = events_fifo.c. >> This is the call stack: >> [ 17.817018] ------------[ cut here ]------------ >> [ 17.817021] kernel BUG at drivers/xen/events/events_fifo.c:258! >> [ 18.817079] Internal error: Oops - BUG: 0 [#1] PREEMPT_RT SMP >> [ 18.817081] Modules linked in: bridge stp llc ipv6 >> [ 18.817086] CPU: 3 PID: 558 Comm: xenstored Not tainted 5.10.16-rt25-= yocto-preempt-rt #1 >> [ 18.817089] Hardware name: Arm Neoverse N1 System Development Platfor= m (DT) >> [ 18.817090] pstate: 60400005 (nZCv daif +PAN -UAO -TCO BTYPE=3D--) >> [ 18.817092] pc : evtchn_fifo_unmask+0xd4/0xe0 >> [ 18.817099] lr : xen_irq_lateeoi_locked+0xec/0x200 >> [ 18.817102] sp : ffff8000123f3cc0 >> [ 18.817102] x29: ffff8000123f3cc0 x28: ffff0000427b1d80 >> [ 18.817104] x27: 0000000000000000 x26: 0000000000000000 >> [ 18.817106] x25: 0000000000000001 x24: 0000000000000001 >> [ 18.817107] x23: ffff0000412fc900 x22: 0000000000000004 >> [ 18.817109] x21: 0000000000000000 x20: ffff000042e06990 >> [ 18.817110] x19: ffff0000427b1d80 x18: 0000000000000010 >> [ 18.817112] x17: 0000000000000000 x16: 0000000000000000 >> [ 18.817113] x15: 0000000000000002 x14: 0000000000000001 >> [ 18.817114] x13: 000000000001a7e8 x12: 0000000000000040 >> [ 18.817116] x11: ffff000040400248 x10: ffff00004040024a >> [ 18.817117] x9 : ffff800011be5200 x8 : ffff000040400270 >> [ 18.817119] x7 : 0000000000000000 x6 : 0000000000000003 >> [ 18.817120] x5 : 0000000000000000 x4 : ffff000040400308 >> [ 18.817121] x3 : ffff0000408a400c x2 : 0000000000000000 >> [ 18.817122] x1 : 0000000000000000 x0 : ffff0000408a4000 >> [ 18.817124] Call trace: >> [ 18.817125] evtchn_fifo_unmask+0xd4/0xe0 >> [ 18.817127] xen_irq_lateeoi_locked+0xec/0x200 >> [ 18.817129] xen_irq_lateeoi+0x48/0x64 >> [ 18.817131] evtchn_write+0x124/0x15c >> [ 18.817134] vfs_write+0xf0/0x2cc >> [ 18.817137] ksys_write+0xe0/0x100 >> [ 18.817139] __arm64_sys_write+0x20/0x30 >> [ 18.817142] el0_svc_common.constprop.0+0x78/0x1a0 >> [ 18.817145] do_el0_svc+0x24/0x90 >> [ 18.817147] el0_svc+0x14/0x20 >> [ 18.817151] el0_sync_handler+0x1a4/0x1b0 >> [ 18.817153] el0_sync+0x174/0x180 >> [ 18.817156] Code: 52800120 b90023e6 97e6d104 17fffff0 (d4210000) >> [ 18.817158] ---[ end trace 0000000000000002 ]--- >> Our last tested kernel was the 5.4 and our analysis pointed out that the= introduction of the lateeoi framework (xen/events: add a new "late EOI" ev= tchn framework) in conjunction with the preempt_rt patches (irqs kept enabl= ed between spinlock_t/rwlock_t _irqsave///=E2=80=8B_irqrestore operations) = is the root cause. >> Given that many modifications were made to the mask/unmask operations, a= big one from Juergen Gross (xen/events: don't unmask an event channel when= an eoi is pending), is the BUG_ON(...) still needed? >> With the mentioned commit every call to a mask/unmask operation is prote= cted by a spinlock, so I would like to have some feedbacks from who has mor= e experience than me on this part of the code. >=20 > I think this BUG_ON() can be removed. >=20 > Are you planning to send a patch? >=20 >=20 > Juergen > From xen-devel-bounces@lists.xenproject.org Thu Mar 18 08:49:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 08:49:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98846.187745 (Exim 4.92) (envelope-from ) id 1lMoLi-0007CD-Jw; Thu, 18 Mar 2021 08:49:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98846.187745; Thu, 18 Mar 2021 08:49:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMoLi-0007C6-FV; Thu, 18 Mar 2021 08:49:46 +0000 Received: by outflank-mailman (input) for mailman id 98846; Thu, 18 Mar 2021 08:49:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMoLh-0007Bx-O0; Thu, 18 Mar 2021 08:49:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMoLh-0004b4-FU; Thu, 18 Mar 2021 08:49:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMoLh-0002iv-66; Thu, 18 Mar 2021 08:49:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMoLh-0008IH-5c; Thu, 18 Mar 2021 08:49:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6VdQENZCHcGjwh5Gjk3MGzz7h5Np1Wzzjodmd8Zp8Lc=; b=qz+dKspEK5rtXvfPWQfztxfJA0 wTkwPa8+b5nOfU5yEHPlNsWHKaBp+krp4vPEjEhUYMc/VgawxHha+9mUewcQoyM10AV8iVuvVOALQ V5jeNM95xKJ1/ak9EINU1mJs5MxlMoAg9oJkhjH5oEfa2lOAiUvGNHAzJ979A+g2KHJ8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160122: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=f07ae0fcbd84f52da6660a7ad0b19c99f6a6f9d6 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 18 Mar 2021 08:49:45 +0000 flight 160122 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160122/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt f07ae0fcbd84f52da6660a7ad0b19c99f6a6f9d6 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 251 days Failing since 151818 2020-07-11 04:18:52 Z 250 days 243 attempts Testing same since 160122 2021-03-18 04:20:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 47708 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 18 09:08:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 09:08:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98853.187760 (Exim 4.92) (envelope-from ) id 1lModV-0000hW-6W; Thu, 18 Mar 2021 09:08:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98853.187760; Thu, 18 Mar 2021 09:08:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lModV-0000hP-3J; Thu, 18 Mar 2021 09:08:09 +0000 Received: by outflank-mailman (input) for mailman id 98853; Thu, 18 Mar 2021 09:08:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lModT-0000hK-LV for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 09:08:07 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 116e30d0-bdd8-469d-bba7-0a9881f93a54; Thu, 18 Mar 2021 09:08:06 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EB3AAAC17; Thu, 18 Mar 2021 09:08:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 116e30d0-bdd8-469d-bba7-0a9881f93a54 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616058486; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ObbefyfY7RVzriGhjjAbBIa8n8g+c4OQjcZK1J0V2wU=; b=YuEdH6eqaXxshxd8sohByjfR1e/uU8Udv/QR5Sovb1RvxE1plD9K1rmxi7KuAqaFgtI5ED 24tvwCSQ3p0/hchbzC35ldjQO+NT5ywbMsCUxZxrfdOIt2wVH5Sso0MehAvvxOxnUfv9bx qwVd5bximTYL9bnnFq+Zs6RoD5AiLns= Subject: Re: libxl / xen-pciback interaction [and 1 more messages] To: Ian Jackson Cc: "xen-devel@lists.xenproject.org" , Wei Liu , Anthony Perard , Boris Ostrovsky , =?UTF-8?B?SsO8cmdlbiBHcm8=?= =?UTF-8?B?w58=?= References: <24658.7286.533794.293151@mariner.uk.xensource.com> <11bf64f2-401d-03cb-59d7-a84b5c56552e@suse.com> <24658.9861.547014.443884@mariner.uk.xensource.com> From: Jan Beulich Message-ID: Date: Thu, 18 Mar 2021 10:08:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <24658.9861.547014.443884@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 17.03.2021 16:55, Ian Jackson wrote: > Jan Beulich writes ("Re: libxl / xen-pciback interaction [and 1 more messages]"): >> On 17.03.2021 16:12, Ian Jackson wrote: >>> How does what libxl is doing differ from a setup, immediately followed >>> by a hot-add ? >> >> In the hot-add case libxl drives things through Reconfiguring state. >> I'm not sure this would be an appropriate (and backwards compatible) >> thing to do when initially populating xenstore. > > Ah. Tbanks, that is precisely the answer to my question. > > I think that means, therefore, populating the whole lot in one > transaction. > > (From what you say it doesn't sound like it's possible to write only a > subset, perhaps with state "not ready yet" and then set them all go > "go" at the end.) Indeed, that's my understanding and a consequence of pciback's watch covering the entire backend subtree, rather than e.g. just the num_devs node. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 18 09:20:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 09:20:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98856.187772 (Exim 4.92) (envelope-from ) id 1lMopO-0002OV-9q; Thu, 18 Mar 2021 09:20:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98856.187772; Thu, 18 Mar 2021 09:20:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMopO-0002OO-6p; Thu, 18 Mar 2021 09:20:26 +0000 Received: by outflank-mailman (input) for mailman id 98856; Thu, 18 Mar 2021 09:20:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMopM-0002OJ-4T for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 09:20:24 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d493eab5-9dba-40b6-acc3-6a6f4ea05cf7; Thu, 18 Mar 2021 09:20:23 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 831B3AC17; Thu, 18 Mar 2021 09:20:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d493eab5-9dba-40b6-acc3-6a6f4ea05cf7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616059222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4PFxnLA5DQDp0QvIsOAuC+OAoMsVHswJZXjWzzVlZKE=; b=NXTX+m+833l1c3YAe0guvbw6C39uZV8kgf0HdXiZFaEBdwZHE9IpFhRVKGr5a9vRMk1C4B ZXrNmvkOLj4IRUJH5aDioop208NsexkRlldA/RdoBbYuM56hZMSERLBpVAnlMoYIK5sAlv l8roX/hYZrns6bz33o7rVTkk2ntUUJg= Subject: Re: [PATCH v7] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org, Julien Grall References: <20210315092342.26533-1-michal.orzel@arm.com> <3473f8d3-c42a-9182-b4fa-c3eacb44338f@xen.org> <75800277-4107-0060-aece-d01cf29d3086@arm.com> From: Jan Beulich Message-ID: <728bb60b-adc0-7218-95a5-e733aadd5cfa@suse.com> Date: Thu, 18 Mar 2021 10:20:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <75800277-4107-0060-aece-d01cf29d3086@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 18.03.2021 08:21, Michal Orzel wrote: > Hi Julien, > > On 16.03.2021 15:54, Julien Grall wrote: >> Hi Michal, >> >> On 15/03/2021 09:23, Michal Orzel wrote: >>> Currently in order to link existing DTB into Xen image >>> we need to either specify option CONFIG_DTB_FILE on the >>> command line or manually add it into .config. >>> Add Kconfig entry: CONFIG_DTB_FILE >>> to be able to provide the path to DTB we want to embed >>> into Xen image. If no path provided - the dtb will not >>> be embedded. >>> >>> Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>> as it is not needed since Kconfig will define it in a header >>> with all the other config options. >>> >>> Make a change in the linker script from: >>> _sdtb = .; >>> to: >>> PROVIDE(_sdtb = .); >>> to avoid creation of _sdtb if there is no reference to it. >> >> This means that if someone is using #ifdef CONFIG_DTB_FILE rather than .ifnes, _sdtb will get defined. > > Do we really want to overengineer something that simple? > Why would someone use #ifdef CONFIG_DTB_FILE? > In my opinion the rule of thumb is that you don't use #ifdef on configs of string type. > Using #ifdef CONFIG_DTB_FILE means that someone modifying the code did not even spend 1 minute checking the Kconfig. > > If you do not agree, I can modify the code so _sdtb will be created in dtb.S. > In that case I would like Jan Beulich to give his opinion before I will send v8. TBH I'd find it more natural in any event if the symbol came from dtb.S. So far I was assuming there was some (hidden) reason why this wouldn't work. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 18 09:35:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 09:35:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98859.187783 (Exim 4.92) (envelope-from ) id 1lMp41-0003RZ-K9; Thu, 18 Mar 2021 09:35:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98859.187783; Thu, 18 Mar 2021 09:35:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMp41-0003RS-Gz; Thu, 18 Mar 2021 09:35:33 +0000 Received: by outflank-mailman (input) for mailman id 98859; Thu, 18 Mar 2021 09:35:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMp40-0003RN-Sg for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 09:35:32 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 11b65bdf-67a5-46d2-a19b-e7168f5ba626; Thu, 18 Mar 2021 09:35:32 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 427B3AC1E; Thu, 18 Mar 2021 09:35:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11b65bdf-67a5-46d2-a19b-e7168f5ba626 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616060131; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zzFbb52yauBhIb4jLC2X7NPZ4IOcEkpAI3KYM8pSyoQ=; b=PgiYkB1otAZbfp2pXVFZiO3NsaK1wIsPPHzAmPAJ9hDpsfc6B1/RbgFtI+FQ/BcjXyt+cW AD4i5m64uEhIQ4JWUFzyBiB1hndDVk85dbIZ6Z6pzzKBEcyccY5rQkwRZtMVqlNb/UlzZb W0TV/jvdVq6Fgy9QgEb/MWO0jluInAk= Subject: Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" To: Ian Jackson Cc: Xen-devel , Andrew Cooper , Wei Liu , Boris Ostrovsky , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> <24658.1583.601613.903527@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <6eb6f686-d67e-6db3-6b4b-8c63e676e311@suse.com> Date: Thu, 18 Mar 2021 10:35:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <24658.1583.601613.903527@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 17.03.2021 14:37, Ian Jackson wrote: > I have read this thread and with my release manager hat on I feel > confused and/or ignorant. > > Patch 3/ has a good explanation of what the problem is it is > addressing and why this is important for 4.15. But then there is > Jan's most recent reply starting "I find all of this confusing". Jan, > can you please tell me in words of one syllable what the implication > of that message is ? In particular is any of what you say a reason > for me to withhold my release-ack ? Answering the last question first - I don't think so. Something may indeed want doing here beyond what we already have, and it may well be precisely what Andrew is proposing, possibly just with extended descriptions and/or comments. My confusion about patch 3 is that it (a) claims behavior in turbostat that I can't locate and (b) implies (describes) behavior of code that I find entirely unexpected (as in: not making sense to me). And I'm sorry: Not all of the words are of one syllable. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 18 09:37:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 09:37:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98862.187796 (Exim 4.92) (envelope-from ) id 1lMp5i-0003a3-03; Thu, 18 Mar 2021 09:37:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98862.187796; Thu, 18 Mar 2021 09:37:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMp5h-0003Zw-T8; Thu, 18 Mar 2021 09:37:17 +0000 Received: by outflank-mailman (input) for mailman id 98862; Thu, 18 Mar 2021 09:37:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMp5g-0003Zr-WC for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 09:37:17 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 58efed81-6adc-4f99-b7a4-9a9e6c567116; Thu, 18 Mar 2021 09:37:16 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B3732AC17; Thu, 18 Mar 2021 09:37:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58efed81-6adc-4f99-b7a4-9a9e6c567116 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616060235; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ukLAMNIvBpq4HyhRpau2cPanzqY5VLTTuKDiy09K4O4=; b=CkGqLCTOrHcLxo+EVNv9nR0j5gXBbXeLR0pY2PiX9VskQh/xd2ItsYyIvT/qxbR05dRqf2 1sSa6/LqTnK0iOdYEpRWDNWuo/NGi+sMa5egnDT1jroU6q+ZXA/A3k5VVrzlpHTIcL+k7w BJsJcI7ydTkvPHNhMiI07KOXtdyltjg= Subject: Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" To: Ian Jackson Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xen-devel , Wei Liu , Boris Ostrovsky , Andrew Cooper References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> <24658.1583.601613.903527@mariner.uk.xensource.com> <4b1c13ee-f121-3379-6fb3-c0d4dbb76e48@citrix.com> <24658.5692.932979.892439@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <089b9e31-e767-8e01-7a62-466d45f83b7d@suse.com> Date: Thu, 18 Mar 2021 10:37:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <24658.5692.932979.892439@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 17.03.2021 15:46, Ian Jackson wrote: > Jan, what is your summary opinion about patch 3 ? Just to answer this question explicitly: I can't form one yet without further information provided to me. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 18 10:12:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 10:12:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98866.187808 (Exim 4.92) (envelope-from ) id 1lMpdX-0007G0-Pg; Thu, 18 Mar 2021 10:12:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98866.187808; Thu, 18 Mar 2021 10:12:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMpdX-0007Ft-Ln; Thu, 18 Mar 2021 10:12:15 +0000 Received: by outflank-mailman (input) for mailman id 98866; Thu, 18 Mar 2021 10:12:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMpdV-0007FV-Qw for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 10:12:13 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 02c3b7f5-1177-430f-a102-acbb10363387; Thu, 18 Mar 2021 10:12:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 89C5EAC1E; Thu, 18 Mar 2021 10:12:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02c3b7f5-1177-430f-a102-acbb10363387 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616062331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lit+KV0NKZXvfbZ/W+r7zpLORCmoXtveGaFf5dpAd9U=; b=HlnpA/241fEptfr0UKjOpvqqKa93iU1m4lA/zGOjfN0271/T6OMMgtPIePOxFHpB/YsWZ5 2Wm3KhBGqox8u4l0q3QTb7MIzXXVwDiK59727XLHxDbl0YacnJoR68VLFJmfquoBQlPPz1 EeDmRf4tBdyMxwtLpdwPRv1kvIFC7TY= To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian , Ian Jackson From: Jan Beulich Subject: [PATCH 0/4][4.15?] VT-d: mostly S3 related corrections Message-ID: Date: Thu, 18 Mar 2021 11:12:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit None of these are regressions afaict, so considering how late we are in the 4.15 process, I can see reasons to not take any of these. All of them are backporting candidates though, imo. 1: correct off-by-1 in number-of-IOMMUs check 2: leave FECTL write to vtd_resume() 3: re-order register restoring in vtd_resume() 4: restore flush hooks when disabling qinval Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 18 10:13:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 10:13:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98871.187819 (Exim 4.92) (envelope-from ) id 1lMpef-0007Mz-9o; Thu, 18 Mar 2021 10:13:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98871.187819; Thu, 18 Mar 2021 10:13:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMpef-0007Ms-6b; Thu, 18 Mar 2021 10:13:25 +0000 Received: by outflank-mailman (input) for mailman id 98871; Thu, 18 Mar 2021 10:13:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMpee-0007Mm-6W for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 10:13:24 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 442177c9-9ab5-4fee-8f59-82895bfbff01; Thu, 18 Mar 2021 10:13:23 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B1ABFAC1E; Thu, 18 Mar 2021 10:13:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 442177c9-9ab5-4fee-8f59-82895bfbff01 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616062402; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y1982WR6j3cpgGsFbVcaDaicMn2WceMWsDl7cYZX9Vg=; b=lFyVfQDVjWzAMl2oA21/i6bVwBTG2NkB0Ir071fgQUFk7xuVaNo6YWTMpzmSUTxn75dWFz NVfq/T6tgSTXsnH0sfXJis3oN6Byhs4bBnvi1bkf909pavpl4m7t5+wW8VvApdjIr0ZkGh UqsCwVlrqcL6xPC/pH+lBbFqA7mjM90= Subject: [PATCH 1/4][4.15?] VT-d: correct off-by-1 in number-of-IOMMUs check From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian , Ian Jackson References: Message-ID: <68084b4f-bcd2-59dd-bea7-781b8aa75ef7@suse.com> Date: Thu, 18 Mar 2021 11:13:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Otherwise, if we really run on a system with this many IOMMUs, entering/leaving S3 would overrun iommu_state[]. Signed-off-by: Jan Beulich --- There are more anomalies here, but since we were asked to not make any cosmetic changes for patches to have a chance to go into 4.15, I've put off correcting even the most obvious things (scope of MAX_IOMMUS and nr_iommus) for a later patch. --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -1168,10 +1168,10 @@ int __init iommu_alloc(struct acpi_drhd_ unsigned long sagaw, nr_dom; int agaw; - if ( nr_iommus > MAX_IOMMUS ) + if ( nr_iommus >= MAX_IOMMUS ) { dprintk(XENLOG_ERR VTDPREFIX, - "IOMMU: nr_iommus %d > MAX_IOMMUS\n", nr_iommus); + "IOMMU: nr_iommus %d > MAX_IOMMUS\n", nr_iommus + 1); return -ENOMEM; } From xen-devel-bounces@lists.xenproject.org Thu Mar 18 10:14:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 10:14:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98874.187832 (Exim 4.92) (envelope-from ) id 1lMpfE-0007Sw-KT; Thu, 18 Mar 2021 10:14:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98874.187832; Thu, 18 Mar 2021 10:14:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMpfE-0007Sp-HA; Thu, 18 Mar 2021 10:14:00 +0000 Received: by outflank-mailman (input) for mailman id 98874; Thu, 18 Mar 2021 10:13:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMpfD-0007Sh-BF for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 10:13:59 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id eff9bc1d-c2c1-4203-9268-4c90312ff026; Thu, 18 Mar 2021 10:13:58 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B9C21AC1E; Thu, 18 Mar 2021 10:13:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eff9bc1d-c2c1-4203-9268-4c90312ff026 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616062437; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jqnxm854ZkzHnoc/cGVME3wbWF5nHrJSeLOnsd7AR3U=; b=Hmwoh+M3z8oP9tjzgCwN6Ee6cUFd/1Hxa1TOQ2G5QPHB7x0Zk9NhupoD9q2ORtUjr4WgsS Q5BuVPoi6bdoOY/Wt2Nk5E5YBXZOPKwlzjKpNupRaCcVAh7c01gLTyEJqxOrWo1bU6WjZZ cRsEfLoel7NpPiL+bstBi/6LipUFxoI= Subject: [PATCH 2/4][4.15?] VT-d: leave FECTL write to vtd_resume() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian , Ian Jackson References: Message-ID: <57976bd9-6c50-26c3-1f06-62f1a5546e06@suse.com> Date: Thu, 18 Mar 2021 11:13:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit We shouldn't blindly unmask the interrupt when resuming. vtd_resume() will restore the intended state. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -2092,7 +2092,7 @@ static int adjust_vtd_irq_affinities(voi } __initcall(adjust_vtd_irq_affinities); -static int __must_check init_vtd_hw(void) +static int __must_check init_vtd_hw(bool resume) { struct acpi_drhd_unit *drhd; struct vtd_iommu *iommu; @@ -2121,6 +2121,10 @@ static int __must_check init_vtd_hw(void disable_qinval(iommu); } + if ( resume ) + /* FECTL write done by vtd_resume(). */ + continue; + spin_lock_irqsave(&iommu->register_lock, flags); sts = dmar_readl(iommu->reg, DMAR_FECTL_REG); sts &= ~DMA_FECTL_IM; @@ -2320,7 +2324,7 @@ static int __init vtd_setup(void) P(iommu_hap_pt_share, "Shared EPT tables"); #undef P - ret = init_vtd_hw(); + ret = init_vtd_hw(false); if ( ret ) goto error; @@ -2590,7 +2594,7 @@ static void vtd_resume(void) if ( !iommu_enabled ) return; - if ( init_vtd_hw() != 0 && force_iommu ) + if ( init_vtd_hw(true) != 0 && force_iommu ) panic("IOMMU setup failed, crash Xen for security purpose\n"); for_each_drhd_unit ( drhd ) From xen-devel-bounces@lists.xenproject.org Thu Mar 18 10:14:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 10:14:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98877.187843 (Exim 4.92) (envelope-from ) id 1lMpfn-0007Zm-UB; Thu, 18 Mar 2021 10:14:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98877.187843; Thu, 18 Mar 2021 10:14:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMpfn-0007Zf-Qw; Thu, 18 Mar 2021 10:14:35 +0000 Received: by outflank-mailman (input) for mailman id 98877; Thu, 18 Mar 2021 10:14:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMpfm-0007ZU-DJ for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 10:14:34 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f42204a6-c052-46cf-8a96-b10a1d5f3c30; Thu, 18 Mar 2021 10:14:33 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DF035AD20; Thu, 18 Mar 2021 10:14:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f42204a6-c052-46cf-8a96-b10a1d5f3c30 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616062473; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GPmVawULsDWDzc2AL6YzBoU9qI4rbrFjxnykvjGJcYI=; b=NEmSx4pvrG7l2F8X//6YOPn/o3iD96gvZjEg5yY6K9Fd+Tn+SZVl5rM3AqYLayF2+8nED1 ceIr53Mww7wBfDWSkuGjG5YlEGbjrEnHd+2zeIGp93U23cLvK31APitU3tVxDqsugiJvg2 hg/+EqIJGRdaiJ5/qYjVgvyQR5u5SSI= Subject: [PATCH 3/4][4.15?] VT-d: re-order register restoring in vtd_resume() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian , Ian Jackson References: Message-ID: <04332d46-a595-3f42-71f8-a933048982ab@suse.com> Date: Thu, 18 Mar 2021 11:14:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit For one FECTL must be written last - the interrupt shouldn't be unmasked without first having written the data and address needed to actually deliver it. In the common case (when dma_msi_set_affinity() doesn't end up bailing early) this happens from init_vtd_hw(), but for this to actually have the intended effect we shouldn't subsequently overwrite what was written there - this is only benign when old and new settings match. Instead we should restore the registers ahead of calling init_vtd_hw(), just for the unlikely case of dma_msi_set_affinity() bailing early. In the moved code drop some stray casts as well. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -2594,6 +2594,21 @@ static void vtd_resume(void) if ( !iommu_enabled ) return; + for_each_drhd_unit ( drhd ) + { + iommu = drhd->iommu; + i = iommu->index; + + spin_lock_irqsave(&iommu->register_lock, flags); + dmar_writel(iommu->reg, DMAR_FEDATA_REG, + iommu_state[i][DMAR_FEDATA_REG]); + dmar_writel(iommu->reg, DMAR_FEADDR_REG, + iommu_state[i][DMAR_FEADDR_REG]); + dmar_writel(iommu->reg, DMAR_FEUADDR_REG, + iommu_state[i][DMAR_FEUADDR_REG]); + spin_unlock_irqrestore(&iommu->register_lock, flags); + } + if ( init_vtd_hw(true) != 0 && force_iommu ) panic("IOMMU setup failed, crash Xen for security purpose\n"); @@ -2605,12 +2620,6 @@ static void vtd_resume(void) spin_lock_irqsave(&iommu->register_lock, flags); dmar_writel(iommu->reg, DMAR_FECTL_REG, (u32) iommu_state[i][DMAR_FECTL_REG]); - dmar_writel(iommu->reg, DMAR_FEDATA_REG, - (u32) iommu_state[i][DMAR_FEDATA_REG]); - dmar_writel(iommu->reg, DMAR_FEADDR_REG, - (u32) iommu_state[i][DMAR_FEADDR_REG]); - dmar_writel(iommu->reg, DMAR_FEUADDR_REG, - (u32) iommu_state[i][DMAR_FEUADDR_REG]); spin_unlock_irqrestore(&iommu->register_lock, flags); iommu_enable_translation(drhd); From xen-devel-bounces@lists.xenproject.org Thu Mar 18 10:15:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 10:15:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98879.187856 (Exim 4.92) (envelope-from ) id 1lMpgS-0007gp-8c; Thu, 18 Mar 2021 10:15:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98879.187856; Thu, 18 Mar 2021 10:15:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMpgS-0007gi-43; Thu, 18 Mar 2021 10:15:16 +0000 Received: by outflank-mailman (input) for mailman id 98879; Thu, 18 Mar 2021 10:15:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMpgQ-0007gF-ID for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 10:15:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMpgN-000653-7b; Thu, 18 Mar 2021 10:15:11 +0000 Received: from [54.239.6.177] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMpgN-000822-0k; Thu, 18 Mar 2021 10:15:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=IpuP7dYuP8jYNJNMRhy+8iDIGI0O1skuE4Btb5+dgvo=; b=O0Bn7qmLJnv65MWGP7ZGvHyMLa oWNHzJYJZ79BqjQcQ0XI9m3cEd3LfbU4EmiazxZHNS51lJKib7eeVDBs1Y0bBcECKEwpDMQQ1e89x 6Ck7LA9P6BxLFKnWm5svwbiR2/L462q0oS6AHSSMa8PKYlojtYFwc1b9L2dzwlWL5BvM=; Subject: Re: [PATCH v7] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com References: <20210315092342.26533-1-michal.orzel@arm.com> <3473f8d3-c42a-9182-b4fa-c3eacb44338f@xen.org> <75800277-4107-0060-aece-d01cf29d3086@arm.com> From: Julien Grall Message-ID: <29b3ca45-8e84-4997-5e97-c31030d246d3@xen.org> Date: Thu, 18 Mar 2021 10:15:08 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <75800277-4107-0060-aece-d01cf29d3086@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 18/03/2021 07:21, Michal Orzel wrote: > Hi Julien, > > On 16.03.2021 15:54, Julien Grall wrote: >> Hi Michal, >> >> On 15/03/2021 09:23, Michal Orzel wrote: >>> Currently in order to link existing DTB into Xen image >>> we need to either specify option CONFIG_DTB_FILE on the >>> command line or manually add it into .config. >>> Add Kconfig entry: CONFIG_DTB_FILE >>> to be able to provide the path to DTB we want to embed >>> into Xen image. If no path provided - the dtb will not >>> be embedded. >>> >>> Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>> as it is not needed since Kconfig will define it in a header >>> with all the other config options. >>> >>> Make a change in the linker script from: >>> _sdtb = .; >>> to: >>> PROVIDE(_sdtb = .); >>> to avoid creation of _sdtb if there is no reference to it. >> >> This means that if someone is using #ifdef CONFIG_DTB_FILE rather than .ifnes, _sdtb will get defined. > > Do we really want to overengineer something that simple? Interesting, I would argue that using PROVIDE is over-engineered (and error-prone) when you likely can define _sdtb in .S. > Why would someone use #ifdef CONFIG_DTB_FILE? > In my opinion the rule of thumb is that you don't use #ifdef on configs of string type. > Using #ifdef CONFIG_DTB_FILE means that someone modifying the code did not even spend 1 minute checking the Kconfig. I'd like to point out that your first approach didn't replace #ifdef. This was fully reviewed and nearly committed. When I pointed out the issue, I had to argue that this was broken. This is not quite the same as adding #ifdef but it shows that such mistake can be easily slipped in master. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 18 10:15:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 10:15:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98882.187867 (Exim 4.92) (envelope-from ) id 1lMph1-0007nU-I1; Thu, 18 Mar 2021 10:15:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98882.187867; Thu, 18 Mar 2021 10:15:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMph1-0007nN-EZ; Thu, 18 Mar 2021 10:15:51 +0000 Received: by outflank-mailman (input) for mailman id 98882; Thu, 18 Mar 2021 10:15:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMph0-0007nE-F3 for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 10:15:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 92e2fb4a-7283-4df8-9bd1-08757255efec; Thu, 18 Mar 2021 10:15:49 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CAEBFACBF; Thu, 18 Mar 2021 10:15:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92e2fb4a-7283-4df8-9bd1-08757255efec X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616062548; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1jAuOft1lat9ybZ5l7PuD+O//EBqhMIy794TtaMQe6M=; b=EBhdd20VtJHzJGZyjJcXbjnn4HdIBMkVaTz9b20KNztVaLjeU2LmItT/PULBBTkNKasknX tYe8NrC8CU3rtAzfN9WrQJZ8FuA/Lk6ITht8jVYpm3jwKXNZsVThLZ7/lWRXxsjtRT8DaS TcO8mLqwX2B+UaILh6GSj/dBcpuiPhw= Subject: [PATCH 4/4][4.15?] VT-d: restore flush hooks when disabling qinval From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian , Ian Jackson References: Message-ID: <1fa377f7-d709-2615-55fe-f4d5e0d4f317@suse.com> Date: Thu, 18 Mar 2021 11:15:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Leaving the hooks untouched is at best a latent risk: There may well be cases where some flush is needed, which then needs carrying out the "register" way. Switch from u to uint_t while needing to touch the function headers anyway. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/vtd/extern.h +++ b/xen/drivers/passthrough/vtd/extern.h @@ -49,6 +49,16 @@ int iommu_flush_iec_global(struct vtd_io int iommu_flush_iec_index(struct vtd_iommu *iommu, u8 im, u16 iidx); void clear_fault_bits(struct vtd_iommu *iommu); +int __must_check vtd_flush_context_reg(struct vtd_iommu *iommu, uint16_t did, + uint16_t source_id, + uint8_t function_mask, uint64_t type, + bool flush_non_present_entry); +int __must_check vtd_flush_iotlb_reg(struct vtd_iommu *iommu, uint16_t did, + uint64_t addr, unsigned int size_order, + uint64_t type, + bool flush_non_present_entry, + bool flush_dev_iotlb); + struct vtd_iommu *ioapic_to_iommu(unsigned int apic_id); struct vtd_iommu *hpet_to_iommu(unsigned int hpet_id); struct acpi_drhd_unit *ioapic_to_drhd(unsigned int apic_id); --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -380,10 +380,9 @@ static void iommu_flush_write_buffer(str } /* return value determine if we need a write buffer flush */ -static int __must_check flush_context_reg(struct vtd_iommu *iommu, u16 did, - u16 source_id, u8 function_mask, - u64 type, - bool flush_non_present_entry) +int vtd_flush_context_reg(struct vtd_iommu *iommu, uint16_t did, + uint16_t source_id, uint8_t function_mask, + uint64_t type, bool flush_non_present_entry) { u64 val = 0; unsigned long flags; @@ -449,11 +448,9 @@ static int __must_check iommu_flush_cont } /* return value determine if we need a write buffer flush */ -static int __must_check flush_iotlb_reg(struct vtd_iommu *iommu, u16 did, - u64 addr, - unsigned int size_order, u64 type, - bool flush_non_present_entry, - bool flush_dev_iotlb) +int vtd_flush_iotlb_reg(struct vtd_iommu *iommu, uint16_t did, uint64_t addr, + unsigned int size_order, uint64_t type, + bool flush_non_present_entry, bool flush_dev_iotlb) { int tlb_offset = ecap_iotlb_offset(iommu->ecap); u64 val = 0; @@ -2144,8 +2141,8 @@ static int __must_check init_vtd_hw(bool */ if ( enable_qinval(iommu) != 0 ) { - iommu->flush.context = flush_context_reg; - iommu->flush.iotlb = flush_iotlb_reg; + iommu->flush.context = vtd_flush_context_reg; + iommu->flush.iotlb = vtd_flush_iotlb_reg; } } --- a/xen/drivers/passthrough/vtd/qinval.c +++ b/xen/drivers/passthrough/vtd/qinval.c @@ -462,4 +462,7 @@ void disable_qinval(struct vtd_iommu *io !(sts & DMA_GSTS_QIES), sts); out: spin_unlock_irqrestore(&iommu->register_lock, flags); + + iommu->flush.context = vtd_flush_context_reg; + iommu->flush.iotlb = vtd_flush_iotlb_reg; } From xen-devel-bounces@lists.xenproject.org Thu Mar 18 11:14:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 11:14:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98887.187880 (Exim 4.92) (envelope-from ) id 1lMqb7-0005IG-U4; Thu, 18 Mar 2021 11:13:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98887.187880; Thu, 18 Mar 2021 11:13:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMqb7-0005I9-Pq; Thu, 18 Mar 2021 11:13:49 +0000 Received: by outflank-mailman (input) for mailman id 98887; Thu, 18 Mar 2021 11:13:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMqb6-0005I4-C6 for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 11:13:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMqb5-00070O-TI; Thu, 18 Mar 2021 11:13:47 +0000 Received: from [54.239.6.177] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMqb5-0003rD-Jm; Thu, 18 Mar 2021 11:13:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=dr1ZIw/8uERAU6bmkajAXw9DCggg9HIKaG5EAygBmIs=; b=hOWu0nSAWRiN7lNHnxnRpj8hT+ 9/ePLdF6yq/nAsiWXK67bSeicgCtRC7qoLn2GhIujgJVUlyzjp/RMrvzlfAqCgxvFzNnf31oKJCTd 501xutzm043CW6ahw9RHMrE3cReW8JVbFJX8TtsNdqwzignQvcw51vlXElF7qzbcPSzM=; Subject: Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less To: Luca Fancellu Cc: Stefano Stabellini , Jan Beulich , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Bertrand Marquis , wei.chen@arm.com References: <20210308115610.48203-1-luca.fancellu@arm.com> <1921ff88-7637-6454-74a7-1cbab8dafc61@xen.org> <72E0C95C-D5E1-471B-9590-F4D42E3E066B@arm.com> <7ed12d12-6fed-cc3a-4a0b-76ad732d4337@xen.org> From: Julien Grall Message-ID: Date: Thu, 18 Mar 2021 11:13:45 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 17/03/2021 17:04, Luca Fancellu wrote: > Hi, Hi Luca, > I’ve checked the common code and the arm part, I can confirm that the domid 0 is never allocated even if the domain 0 is not present, here the only places where domain_create(…) is called using a variable value: Thanks for checking it! > 1) xen/arch/arm/domain_build.c > d = domain_create(++max_init_domid, &d_cfg, false); > Where max_init_domid has value 0 and it is defined in setup.c We might want to add a comment on top of this code to explain why the '++a' rather than 'a++'. > > 2) xen/common/domctl.c > d = domain_create(dom, &op->u.createdomain, false); > For me seems that the dom variable won’t take the 0 value, if someone could give another feedback it would be great. > > On every other part where domain_create(…) is used, it is called with a constant value different from 0. I agree with the analysis. However, I feel this is fragile because we rely on the caller to never pass 0. But it looks like domain_create() doesn't check if the ID is already used. So it would already be possible to overwrite hardware_domain. Therefore, this can probably be deffered. > > For the hardware_domain being NULL and not handled in some situation, it seems that it’s not directly related to this patch, but I can handle it on a next serie, from a quick look it seems that many cases can be handled by checking if the domain is NULL in is_hardware_domain(…). Before this series, it is not possible to have hardware_domain == NULL at runtime because dom0 is always created. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 18 11:39:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 11:39:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98891.187891 (Exim 4.92) (envelope-from ) id 1lMqzV-0007PH-02; Thu, 18 Mar 2021 11:39:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98891.187891; Thu, 18 Mar 2021 11:39:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMqzU-0007PA-TG; Thu, 18 Mar 2021 11:39:00 +0000 Received: by outflank-mailman (input) for mailman id 98891; Thu, 18 Mar 2021 11:38:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMqzT-0007P5-Hg for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 11:38:59 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 3ee7218d-a62b-491a-ab3d-2e687501b81b; Thu, 18 Mar 2021 11:38:57 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7D108ED1; Thu, 18 Mar 2021 04:38:56 -0700 (PDT) Received: from [10.57.19.39] (unknown [10.57.19.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 18F8D3F792; Thu, 18 Mar 2021 04:38:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ee7218d-a62b-491a-ab3d-2e687501b81b Subject: Re: [PATCH v7] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Jan Beulich Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , bertrand.marquis@arm.com, xen-devel@lists.xenproject.org, Julien Grall References: <20210315092342.26533-1-michal.orzel@arm.com> <3473f8d3-c42a-9182-b4fa-c3eacb44338f@xen.org> <75800277-4107-0060-aece-d01cf29d3086@arm.com> <728bb60b-adc0-7218-95a5-e733aadd5cfa@suse.com> From: Michal Orzel Message-ID: Date: Thu, 18 Mar 2021 12:38:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <728bb60b-adc0-7218-95a5-e733aadd5cfa@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 18.03.2021 10:20, Jan Beulich wrote: > On 18.03.2021 08:21, Michal Orzel wrote: >> Hi Julien, >> >> On 16.03.2021 15:54, Julien Grall wrote: >>> Hi Michal, >>> >>> On 15/03/2021 09:23, Michal Orzel wrote: >>>> Currently in order to link existing DTB into Xen image >>>> we need to either specify option CONFIG_DTB_FILE on the >>>> command line or manually add it into .config. >>>> Add Kconfig entry: CONFIG_DTB_FILE >>>> to be able to provide the path to DTB we want to embed >>>> into Xen image. If no path provided - the dtb will not >>>> be embedded. >>>> >>>> Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" >>>> as it is not needed since Kconfig will define it in a header >>>> with all the other config options. >>>> >>>> Make a change in the linker script from: >>>> _sdtb = .; >>>> to: >>>> PROVIDE(_sdtb = .); >>>> to avoid creation of _sdtb if there is no reference to it. >>> >>> This means that if someone is using #ifdef CONFIG_DTB_FILE rather than .ifnes, _sdtb will get defined. >> >> Do we really want to overengineer something that simple? >> Why would someone use #ifdef CONFIG_DTB_FILE? >> In my opinion the rule of thumb is that you don't use #ifdef on configs of string type. >> Using #ifdef CONFIG_DTB_FILE means that someone modifying the code did not even spend 1 minute checking the Kconfig. >> >> If you do not agree, I can modify the code so _sdtb will be created in dtb.S. >> In that case I would like Jan Beulich to give his opinion before I will send v8. > > TBH I'd find it more natural in any event if the symbol came from > dtb.S. So far I was assuming there was some (hidden) reason why > this wouldn't work. > > Jan > Then if both of you agree that _sdtb should be defined in dtb.S, I will make it in v8 Michal From xen-devel-bounces@lists.xenproject.org Thu Mar 18 11:58:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 11:58:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98896.187903 (Exim 4.92) (envelope-from ) id 1lMrHg-0000mt-LV; Thu, 18 Mar 2021 11:57:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98896.187903; Thu, 18 Mar 2021 11:57:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMrHg-0000mm-IQ; Thu, 18 Mar 2021 11:57:48 +0000 Received: by outflank-mailman (input) for mailman id 98896; Thu, 18 Mar 2021 11:57:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMrHe-0000mf-Gg for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 11:57:46 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (unknown [40.107.5.79]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8d658fa4-18b6-4e74-a333-5b41e7c33703; Thu, 18 Mar 2021 11:57:45 +0000 (UTC) Received: from DB9PR06CA0025.eurprd06.prod.outlook.com (2603:10a6:10:1db::30) by DB7PR08MB3628.eurprd08.prod.outlook.com (2603:10a6:10:44::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Thu, 18 Mar 2021 11:57:42 +0000 Received: from DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1db:cafe::bc) by DB9PR06CA0025.outlook.office365.com (2603:10a6:10:1db::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Thu, 18 Mar 2021 11:57:42 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT061.mail.protection.outlook.com (10.152.21.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Thu, 18 Mar 2021 11:57:41 +0000 Received: ("Tessian outbound eae0c21066a4:v87"); Thu, 18 Mar 2021 11:57:41 +0000 Received: from ba563b853073.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B517CB43-3F85-469B-93C3-D8E04C798B79.1; Thu, 18 Mar 2021 11:57:35 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ba563b853073.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 18 Mar 2021 11:57:35 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) by VI1PR08MB5486.eurprd08.prod.outlook.com (2603:10a6:803:13b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Thu, 18 Mar 2021 11:57:33 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642]) by VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642%4]) with mapi id 15.20.3933.033; Thu, 18 Mar 2021 11:57:33 +0000 Received: from a75445.arm.com (82.8.129.65) by LO4P123CA0200.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Thu, 18 Mar 2021 11:57:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d658fa4-18b6-4e74-a333-5b41e7c33703 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=59GxXDnR8AYB0nQcvHH9zOhiO9jslDGqXyWUrvSuISU=; b=rvHlYHTrW1FnAe4ILKY5CqyiUuEDACE07i0yxL5zp3y2G3eo9TtJUNt1MH/Lwbyqs/QFi4cSQItkNH1dkOE7G8haI+9NhRchhOUgUOh2Kd+UOXAimCiKLJiLIJ5piDUM3y0prRzdNa8gXWv+gkVbSC/NQApBCt5hzHy/RUJB+vw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 0d048c893c9d313a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H6rHw/5l4Qa3f2FJ2X36MsGGiiT5yax2Fgvzeol0InWG6/GfzfYU2oOT/jC+I9wKA/hfJAZeWwvJx3g1PWU26Src5YtKItsbe4b9sQrvC/1z/HVfpkmGC5FvWYrfRhLNko66zW+3V+wAK+8O6NTtahTLn8Iy2t5bBlaNIiwiMfaZ8O2EBdkaMFaDnvsTcCnjKzVFNyXOBphvwraX1ivYVhKQ4NPDPDYCGTXYyalwv1te2g1WyaZKk6h9X8zESeSlo1uNNklAqIy7C0E+UJDFWR916Q96a3nf3t/oNfYc2Qn6Rl7VVkcx6PqvRHr0oMzTtWfy8DaNCnx1/rYGwrYLzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=59GxXDnR8AYB0nQcvHH9zOhiO9jslDGqXyWUrvSuISU=; b=L6gqrGsFy6npIx2WJbITo/m+/x5zlhmJ7DXZ+88f45KxiAH1rtFxNg5VU5VjnsMfl6Ba2gCys+8KVx7mQC07If2Dd/hPeHy6aqanWc+cEx0Dg4MNVZWuVjCTtzwFbn/lxcYykJHLy4WfkzdoFo55M4htQMDR2HB3kyozygbcFG9rVVqwsrZd7PUMDD5/VL8mQ5TuXJ5xebOhW6A5J847Q+CBN7O11LopuNg/kSGZWSbdTU4cKIKGXmfWlolJ3qG2Ky16MdIxBkl7VEA2ZoCFjOisyt5DQv4arfmJpia3pgI+EDoWMgTJq5GhinMnqRVUYD8Em9BOaN88VXaHVpU4IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=59GxXDnR8AYB0nQcvHH9zOhiO9jslDGqXyWUrvSuISU=; b=rvHlYHTrW1FnAe4ILKY5CqyiUuEDACE07i0yxL5zp3y2G3eo9TtJUNt1MH/Lwbyqs/QFi4cSQItkNH1dkOE7G8haI+9NhRchhOUgUOh2Kd+UOXAimCiKLJiLIJ5piDUM3y0prRzdNa8gXWv+gkVbSC/NQApBCt5hzHy/RUJB+vw= Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less From: Luca Fancellu In-Reply-To: Date: Thu, 18 Mar 2021 11:57:26 +0000 Cc: Stefano Stabellini , Jan Beulich , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Bertrand Marquis , wei.chen@arm.com Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210308115610.48203-1-luca.fancellu@arm.com> <1921ff88-7637-6454-74a7-1cbab8dafc61@xen.org> <72E0C95C-D5E1-471B-9590-F4D42E3E066B@arm.com> <7ed12d12-6fed-cc3a-4a0b-76ad732d4337@xen.org> To: Julien Grall X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO4P123CA0200.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::7) To VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0f381fcc-a3e2-4af6-3c0e-08d8ea0508e5 X-MS-TrafficTypeDiagnostic: VI1PR08MB5486:|DB7PR08MB3628: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1DjQhP2eJ1l4yOf94lIIBSxkXN+a8WVCnxyX82xrsSnX8wST4BPVDVgKJ1CHhiYqfmQm/HVUW1emLidyrpcoAyQTrASNK094SD7tOIL0U2ZY47O8DYHtncPTMNEv1S9V1GO6LLCRoIdGCIKBv9In8nSQQpmd0mjjQx8ryEXifvDnaK5SA1m8UU9KWDXj94uXW9JkLsw3yriVawA3J1m741ntQrxgtHEC17SEsJpahKozSO/zn2lfXOcUaLp0vsbj8ptJVoOkwHvHmbBJCvi+9kwWApV11EBhSSUOXoekqLmN49S/lL6nu23P61a9xul6lp6Rz14K7RFbXHJtwMyUPgRIu8o4y3p5Vt0YdSYL9IBNAlXC9lLG03EhsCMPsGJbj8wWyUi+UNEwRhEZWgFKm6stubFq15mWFnsjrBlDCeikv3EynbCppLv9GEoJq9RqxXuIkpPgKJf/VZsHkAPPOqKCCgGYxW6ruvGAiXiZeLKx6oRldb5PExQS042Q7lcpsH5YZJGGk3URPZhaNSnqlYLSNlpcTC5HpQlOyeBRIoQUuFpGjfTOWl/LSy1xT7Pg8veBJT1wAKcBFssim472K9baOY6xGt63F3/pdLzBJw9mVmXeVstvYTEpzCxDYapKV4tBhDa1GEum+/zeWrD4Qoc5mJ+eQqkGsK0SWq2/RE4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3629.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(346002)(136003)(396003)(366004)(7696005)(956004)(66946007)(4326008)(478600001)(316002)(6666004)(5660300002)(44832011)(38100700001)(53546011)(66556008)(186003)(66476007)(2906002)(8936002)(86362001)(6916009)(33656002)(36756003)(6486002)(2616005)(8676002)(54906003)(16526019)(26005)(83380400001)(52116002)(32563001)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZVNzTGpwRHlNQ0pQNFBGSWJUNEdaTmlIdjAwaEo0SUJEOXRlWVRCdWVob3hG?= =?utf-8?B?cnZoREM2MkJ5L2M4ZVJtemhWbFB1TFV4ekpua2VMblRFSGY5TW4xVVpRSFFz?= =?utf-8?B?Z1JZa3B1TGFaWkFKblFLU05iVUNhMHEycEsvMElVOWVZdDV2WDI2OWN0SU0r?= =?utf-8?B?K2ZSb3d4ZlNkdzErTTl0S0hpdUlBM29SN25Lc1lPZ3FITCs4RWFSTmpKaGE4?= =?utf-8?B?SEFueDBTYnJDUlVsVDBWd2t2Zm5vck5URlREaW1MWVFHeEFwdmVuMnVOZjBl?= =?utf-8?B?Z3ViM21yVE5tVTR2S1pBMVQwS1hwNFpNOGQ0blJjdGE3K1dEc2pBNHRBR3NR?= =?utf-8?B?OWdYNHVvVTJFUGVoODBzWmpPTjZSOE0rdDU4YTVkdnJ6U0pkMkcwVWR6NEZV?= =?utf-8?B?OFN4TFNORWFJQU4rSXZLMTBDLzl4NkhwY1VEMnJaV2V1VGRzZVpnMUdseEdO?= =?utf-8?B?Um5QcytscEFzUDNFQWdsUURmT1NIdnFFNEVnUFBjajhpaU1NcEgrRXphVE1E?= =?utf-8?B?VEM4dHlFckw5OEI2aWFrbmdYUStOdUJ5VlFncXc3R0w2dHJxb1ZxNlg2NjVR?= =?utf-8?B?dFl2cC9wWG11VThiNUlqTzEvdm1lYVpLZlpGd3pzY2lod3g3aldDMFRoOE5N?= =?utf-8?B?R2FybS9vNGg0WHN4am5aSzk4UnZ5YUMvK3JITnFtNlRQaHd0V3d1QVBIN1I3?= =?utf-8?B?dk1keVBSWlk3MlJTWmtzV0RnMWVrcHhVcnJqL2pZdHE1c1ppekZvRzJTb05r?= =?utf-8?B?c3N0OVFpWU9nT1JPSzNjNGxTN0l2VU0rbVVhMWRVWk9FTTZsTW9OcWVhUFda?= =?utf-8?B?UStSK1IyYnlWNGZWYldxVUFWWGtsdVdkVkhKazRBcWxuMTd2amxSYkpRekht?= =?utf-8?B?SFZnV3VEczJGSVF2V1NkUTk4Z1o1czBUaUppTTIyUFErVTJaOWxzOGZYUkNs?= =?utf-8?B?ZEhXS0dtRXVCaWhUL1ZZVWpySW43dUVDMzV5ZVhZN1JqdS84RUtqa2UvdGt2?= =?utf-8?B?UUQrTFJKbnBYMWl2R1VBUUtVREhzTXluUld0YkxURU5MdUxQTXl1SW1aWWFR?= =?utf-8?B?OGYwYkVnTURFMjV4Zjc5ZWx5MjUrOFJlVS8yQTZ4SHVQV1RQNTlmUU9VU2ZP?= =?utf-8?B?RWFnRC9TY0lVMUxOaEFWbUFBNHhaV2dGanhtUTNvbFdTK0phbDlOdzlmMmVH?= =?utf-8?B?MHBhdFJCNEFST2hrWEZtTjFsY1hkMDZXNTQwZFNYQ2laZE43NkZ3NU1GUElP?= =?utf-8?B?Qk5pUG9JOElPVThTL1ZsU1c5WmlIZ0M3RE1XL2VUNDFpeDFlY1lLeWs0aFpO?= =?utf-8?B?Q0ZMNW5rSERqeWJUZThuQzFqRlk2Z3oyeElSeXNEZUNIaEZ4REo3enBYazRP?= =?utf-8?B?OTYwQWI2d3lNQ2lCUWRqaUVHSDM2SmVYenZwQ1B2a0NlYUd0NkF3TWd6UzBE?= =?utf-8?B?QnNuN3ZwQWdRM3NGc0x3a1ZSQ1pMb1A1Q1Fpd1EzRy82cTBCdlFkeW9TNEYw?= =?utf-8?B?N1hKSEVKNDNGa2g0dDZmamswWkVMWmpZczk2cEpBdWdxS1JqdTNSYy9xUEE0?= =?utf-8?B?SkFZTlhmazYxR0Ewdm1YM1lkOElhVzhUTjhKZHFVc0RWdFBXak1mR01tUS9h?= =?utf-8?B?QllvQUNLZEVXanhwQ09YOGtmTXlIYWY2MFU1N1A2Ym1SMWJNNzAvbFlHNjYr?= =?utf-8?B?UzhPSHJ1YWRWNDl5RW5GcG5CYklBcmNPVmgwZzRPQVVqaE9hdGI5SmhTUTlm?= =?utf-8?Q?90GjYLmx0Cz5hYySxvKYR+Z+G2lZB2C4IgHSWpN?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5486 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 6089f9da-0abf-446c-8a7f-08d8ea050394 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ipw07+X9drCfVznDcmzCQdVAfEQ1OmvO0DWX2E0NGbP/M9kbQ41sDj3Wir9aBpf1W/QlMn0OWyrT/IGiqFr4Gm6QD31A04pxnyJwvZN3V+qfY2VACKQlrfW2+8brXtOrLev+IPJ4G/s6hSLP2rnZA0cStbjhrGWMxck6bPWe7E2WmW6Fpz6cSkIPkxfJissHkS5UPw9NDB5tI7kbudQ6JsJvOuSVrUOP6XsUFDlxekNToDO+6yle6ee6zDqKElfiynDttwHvwsyu6rhwEqkfw4L7oRMEBKyRNsljPhqbG+jfpXlSR+hZj1txXe9OGh5bBGo0Q0pSGPwIe7fg08SM+ub8/hmh1CAw8YWO3s7hnNOOHVsOOk+wVWQLRCyfK5fTcg8ji+5L7f9oyLP9prQVzY93J2CPN+ZQ8YuWmqmu6FztCkZ3qFBwCowodi5qzBoQDfQewn5JP5r7Y/j1Ro8RtlPtcilFkQIcnQmN8c/BCA+6EDQchb5vA7tDrHOQvdn1S9hNvQy3M2HT2a0Wz310l1fS2+FjmId86rZnJlcZrdTYXN+JqzW0R5zHqxQf32WQi/FGW/EJ6AkRmNqk/xCyCKOSiD1AP+uNDjGEbKegKpU/ZHhQY6vW+q+w//toUpl+EuofZF6N2sWZADFRYpLTZ67E1B5/1gxRM2WmtclBU9X5ENQXNAFDYTy/f6UmN7W7 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(136003)(396003)(346002)(39860400002)(36840700001)(46966006)(5660300002)(4326008)(86362001)(2906002)(54906003)(6666004)(82310400003)(336012)(82740400003)(33656002)(53546011)(36860700001)(47076005)(6862004)(316002)(44832011)(36756003)(6486002)(26005)(356005)(70206006)(81166007)(2616005)(8676002)(8936002)(956004)(7696005)(16526019)(478600001)(186003)(70586007)(83380400001)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2021 11:57:41.7472 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f381fcc-a3e2-4af6-3c0e-08d8ea0508e5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3628 Hi Julien, I will create a new serie with all the improvements we have discussed. Thank you for your time. Cheers, Luca > On 18 Mar 2021, at 11:13, Julien Grall wrote: >=20 >=20 >=20 > On 17/03/2021 17:04, Luca Fancellu wrote: >> Hi, >=20 > Hi Luca, >=20 >> I=E2=80=99ve checked the common code and the arm part, I can confirm tha= t the domid 0 is never allocated even if the domain 0 is not present, here = the only places where domain_create(=E2=80=A6) is called using a variable v= alue: >=20 > Thanks for checking it! >=20 >=20 >> 1) xen/arch/arm/domain_build.c >> d =3D domain_create(++max_init_domid, &d_cfg, false); >> Where max_init_domid has value 0 and it is defined in setup.c >=20 > We might want to add a comment on top of this code to explain why the '++= a' rather than 'a++'. >=20 >> 2) xen/common/domctl.c >> d =3D domain_create(dom, &op->u.createdomain, false); >> For me seems that the dom variable won=E2=80=99t take the 0 value, if so= meone could give another feedback it would be great. >> On every other part where domain_create(=E2=80=A6) is used, it is called= with a constant value different from 0. >=20 > I agree with the analysis. However, I feel this is fragile because we rel= y on the caller to never pass 0. But it looks like domain_create() doesn't = check if the ID is already used. So it would already be possible to overwri= te hardware_domain. >=20 > Therefore, this can probably be deffered. >=20 >> For the hardware_domain being NULL and not handled in some situation, it= seems that it=E2=80=99s not directly related to this patch, but I can hand= le it on a next serie, from a quick look it seems that many cases can be ha= ndled by checking if the domain is NULL in is_hardware_domain(=E2=80=A6). >=20 > Before this series, it is not possible to have hardware_domain =3D=3D NUL= L at runtime because dom0 is always created. >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 18 12:00:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 12:00:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98899.187916 (Exim 4.92) (envelope-from ) id 1lMrKA-0001ie-9y; Thu, 18 Mar 2021 12:00:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98899.187916; Thu, 18 Mar 2021 12:00:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMrKA-0001iX-64; Thu, 18 Mar 2021 12:00:22 +0000 Received: by outflank-mailman (input) for mailman id 98899; Thu, 18 Mar 2021 12:00:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMrK8-0001iQ-J5 for xen-devel@lists.xen.org; Thu, 18 Mar 2021 12:00:20 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7fe64e6f-40c5-4b41-afd7-b488ea1a4ef3; Thu, 18 Mar 2021 12:00:18 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMrJv-0007mb-KC; Thu, 18 Mar 2021 12:00:07 +0000 Received: from iwj by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMrJv-00073c-GM; Thu, 18 Mar 2021 12:00:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fe64e6f-40c5-4b41-afd7-b488ea1a4ef3 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=0oQDx6XVZVbI4x/2m9DAoJyP+AFavQiMYTB2bg2sd+c=; b=ZQH7tbTVCW/suZxet6R3c8OEKI LIN9t5JkawZimzkTV1tikEZuB/I8e4tViP+MNEUGN98Y5vney8h5u59VYb0FhMR0MDMLaQlhVODIj g0vTT6d1icaEnEcT2QQtLJ9asaggrbiVQ7DMJ5lOLfb2DBElTCGbOdJdbHp27MQpxWtU=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 368 v2 - HVM soft-reset crashes toolstack Message-Id: Date: Thu, 18 Mar 2021 12:00:07 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory XSA-368 version 2 HVM soft-reset crashes toolstack UPDATES IN VERSION 2 ==================== Public release. ISSUE DESCRIPTION ================= libxl requires all data structures passed across its public interface to be initialized before use and disposed of afterwards by calling a specific set of functions. Many internal data structures also require this initialize / dispose discipline, but not all of them. When the "soft reset" feature was implemented, the libxl__domain_suspend_state structure didn't require any initialization or disposal. At some point later, an initialization function was introduced for the structure; but the "soft reset" path wasn't refactored to call the initialization function. When a guest nwo initiates a "soft reboot", uninitialized data structure leads to an assert() when later code finds the structure in an unexpected state. The effect of this is to crash the process monitoring the guest. How this affects the system depends on the structure of the toolstack. For xl, this will have no security-relevant effect: every VM has its own independent monitoring process, which contains no state. The domain in question will hang in a crashed state, but can be destroyed by `xl destroy` just like any other non-cooperating domain. For daemon-based toolstacks linked against libxl, such as libvirt, this will crash the toolstack, losing the state of any in-progress operations (localized DoS), and preventing further administrator operations unless the daemon is configured to restart automatically (system-wide DoS). If crashes "leak" resources, then repeated crashes could use up resources, also causing a system-wide DoS. IMPACT ====== A malicious guest can crash the management daemon, leading to at least a localized, possibly system-wide denial-of-service. VULNERABLE SYSTEMS ================== Only Xen versions 4.12 through 4.14 are affected. Earlier versions are not affected. The issue affects only systems with a guest monitoring process, which is linked against libxl, and which is important other than simply for the functioning of one particular guest. libvirt is one common toolstack affected. Systems using the `xl` command-line tool should generally suffer no security-relevant effects. The xapi toolstack does not currently link against libxl, and so is not affected. MITIGATION ========== Ensuring that any management daemons are restarted automatically after a crash will partially mitigate the issue. CREDITS ======= This issue was discovered by Olaf Hering. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa368.patch xen-unstable xsa368-4.14.patch Xen 4.14.x xsa368-4.13.patch Xen 4.13.x - Xen 4.12.x $ sha256sum xsa368* e80f33c3ce45372fef7bd91ec71b2b66e557176b79f9771872ce111bfff34150 xsa368.meta b82f2b110514cdf47a2688913ad5af68b01050751d56705a15ddf9a970b6fa0d xsa368.patch 636df70ae5eaf00b50ef0b5ac219a2aeda771c66833fae88e7ee43b18ae889f4 xsa368-4.13.patch 55bbe59c75b69f493e364dfcf6cdbc7db4acd32dbf0b4d2466815b7c1f1823ce xsa368-4.14.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmBTQEMMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZDAIH/ibVSFJRukaH4TKAtm0Qy7Qb0jSF6u5lHdUH4lfa EXTAS4/vAJI70bMt2yePGoaa+QPSJ340MwlKcW8GerAEWeW0hTxOp23GGavEwbtu I+OFdls2YGrxGM2FMQR0ZEftV4jsyVAcCNF6oq6nqzTDe1OZC0bQSDUL69CWnIKn hC9Br/hV3AuijwwQdOGQoe+rj8aZK134UaNjr0AI9e1l2jEsJ3NxC3IxeHy4/J3E meoHKtTRZXFdG2VMu709jqrnhpOQcZDT+meiNhoOdUvXyPBa2MzVj3XY32yWuJxa Fi7qrpXIAZ8qNbCbLIbNYMGlgB+7sLsKQULycgai8Sk7QpU= =ea+C -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa368.meta" Content-Disposition: attachment; filename="xsa368.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiAzNjgsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNCIsCiAgICAiNC4xMyIsCiAgICAiNC4xMiIK ICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwKICAiUmVjaXBlcyI6 IHsKICAgICI0LjEyIjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAi eGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICI0Y2Y1OTI5NjA2YWRj MmZiMWFiNGUyOTIxYzE0YmE0YjgwNDZlY2QxIiwKICAgICAgICAgICJQcmVy ZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAg InhzYTM2OC00LjEzLnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAg ICAgfQogICAgfSwKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6IHsK ICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICJkN2Ex ZTA2ZWZkM2FlMmIxNmQ1YmIzMzU5MzIzNzZiN2Q3ZWFmNjMzIiwKICAgICAg ICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAg ICAgICAgICAgInhzYTM2OC00LjEzLnBhdGNoIgogICAgICAgICAgXQogICAg ICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE0IjogewogICAgICAiUmVj aXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJl ZiI6ICJiMGI3MzRhOGIzZTUxNmZmMTA0MDg4NGI3NTVhOGQ0N2FmZWQzMWVh IiwKICAgICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hl cyI6IFsKICAgICAgICAgICAgInhzYTM2OC00LjE0LnBhdGNoIgogICAgICAg ICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICJtYXN0ZXIiOiB7 CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4iOiB7CiAgICAgICAg ICAiU3RhYmxlUmVmIjogIjQ4MzQ5MzY1NDlmNzg4Mzc4OTE4ZGE4ZTliYzk3 ZGY3ZGQzZWUxNmQiLAogICAgICAgICAgIlByZXJlcXMiOiBbXSwKICAgICAg ICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhMzY4LnBhdGNoIgog ICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfQogIH0KfQ== --=separator Content-Type: application/octet-stream; name="xsa368.patch" Content-Disposition: attachment; filename="xsa368.patch" Content-Transfer-Encoding: base64 RnJvbSBlYWIyYjRhYjA2NDE5YjgyYmUxZTJjZmNkYzViYTJhNDYyNTI4ZDY4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRob255IFBFUkFS RCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KRGF0ZTogV2VkLCAyNCBG ZWIgMjAyMSAxODozOToyMCArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIGxpYnhs OiBGaXggZG9tYWluIHNvZnQgcmVzZXQgc3RhdGUgaGFuZGxpbmcKCkluIGRv X2RvbWFpbl9zb2Z0X3Jlc2V0KCksIGEgYGxpYnhsX19kb21haW5fc3VzcGVu ZF9zdGF0ZScgaXMgdXNlZAp3aXRob3V0IGJlZW4gcHJvcGVybHkgaW5pdGlh bGlzZWQgYW5kIGRpc3Bvc2VkIG9mLiBUaGlzIGxlYWQgZG8gYQphYm9ydCgp IGluIGxpYnhsIGR1ZSB0byB0aGUgYGRzcHMucW1wJyBzdGF0ZSBiZWVuIHVz ZWQgYmVmb3JlIGJlZW4KaW5pdGlhbGlzZWQ6CiAgICBsaWJ4bF9fZXZfcW1w X3NlbmQ6IEFzc2VydGlvbiBgZXYtPnN0YXRlID09IHFtcF9zdGF0ZV9kaXNj b25uZWN0ZWQgfHwgZXYtPnN0YXRlID09IHFtcF9zdGF0ZV9jb25uZWN0ZWQn IGZhaWxlZC4KCk9uY2UgaW5pdGlhbGlzZWQsIGBkc3BzJyBhbHNvIG5lZWRz IHRvIGJlIGRpc3Bvc2VkIG9mIGFzIHRoZSBgcW1wJwpzdGF0ZSBtaWdodCBz dGlsbCBiZSBpbiB0aGUgYENvbm5lY3RlZCcgc3RhdGUgaW4gdGhlIGNhbGxi YWNrIGZvcgpsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGV2aWNlX21vZGVsKCku IFNvIHRoaXMgcGF0Y2ggYWRkcwpsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGlz cG9zZSgpIHdoaWNoIGNhbiBiZSBjYWxsZWQgZnJvbSB0aGUgdHdvCnBsYWNl cyB3aGVyZSB3ZSBuZWVkIHRvIGRpc3Bvc2Ugb2YgYGRzcHMnLgoKUmVwb3J0 ZWQtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT4KU2lnbmVkLW9m Zi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5j b20+ClJldmlld2VkLWJ5OiBJYW4gSmFja3NvbiA8aXdqQHhlbnByb2plY3Qu b3JnPgpUZXN0ZWQtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT4K LS0tCiB0b29scy9saWJzL2xpZ2h0L2xpYnhsX2NyZWF0ZS5jICAgICAgfCAx MSArKysrKysrKy0tLQogdG9vbHMvbGlicy9saWdodC9saWJ4bF9kb21fc3Vz cGVuZC5jIHwgMTUgKysrKysrKysrKystLS0tCiB0b29scy9saWJzL2xpZ2h0 L2xpYnhsX2ludGVybmFsLmggICAgfCAgMiArKwogMyBmaWxlcyBjaGFuZ2Vk LCAyMSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3JlYXRlLmMgYi90b29scy9s aWJzL2xpZ2h0L2xpYnhsX2NyZWF0ZS5jCmluZGV4IDQ2ZjY4ZGE2OTcuLmRj YTI3NjY4MDUgMTAwNjQ0Ci0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxf Y3JlYXRlLmMKKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9jcmVhdGUu YwpAQCAtMjE3OSw5ICsyMTc5LDcgQEAgc3RhdGljIGludCBkb19kb21haW5f c29mdF9yZXNldChsaWJ4bF9jdHggKmN0eCwKICAgICBzdGF0ZS0+Y29uc29s ZV90dHkgPSBsaWJ4bF9fc3RyZHVwKGdjLCBjb25zb2xlX3R0eSk7CiAKICAg ICBkc3MtPmFvID0gYW87Ci0gICAgZHNzLT5kb21pZCA9IGRzcy0+ZHNwcy5k b21pZCA9IGRvbWlkOwotICAgIGRzcy0+ZHNwcy5kbV9zYXZlZmlsZSA9IEdD U1BSSU5URihMSUJYTF9ERVZJQ0VfTU9ERUxfU0FWRV9GSUxFIi4lZCIsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWlkKTsK KyAgICBkc3MtPmRvbWlkID0gZG9taWQ7CiAKICAgICByYyA9IGxpYnhsX19z YXZlX2VtdWxhdG9yX3hlbnN0b3JlX2RhdGEoZHNzLCAmc3JzLT50b29sc3Rh Y2tfYnVmLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAmc3JzLT50b29sc3RhY2tfbGVuKTsKQEAgLTIxOTEsNiArMjE4 OSwxMSBAQCBzdGF0aWMgaW50IGRvX2RvbWFpbl9zb2Z0X3Jlc2V0KGxpYnhs X2N0eCAqY3R4LAogICAgIH0KIAogICAgIGRzcy0+ZHNwcy5hbyA9IGFvOwor ICAgIGRzcy0+ZHNwcy5kb21pZCA9IGRvbWlkOworICAgIGRzcy0+ZHNwcy5s aXZlID0gZmFsc2U7CisgICAgcmMgPSBsaWJ4bF9fZG9tYWluX3N1c3BlbmRf aW5pdChlZ2MsICZkc3MtPmRzcHMsIGRfY29uZmlnLT5iX2luZm8udHlwZSk7 CisgICAgaWYgKHJjKQorICAgICAgICBnb3RvIG91dDsKICAgICBkc3MtPmRz cHMuY2FsbGJhY2tfZGV2aWNlX21vZGVsX2RvbmUgPSBzb2Z0X3Jlc2V0X2Rt X3N1c3BlbmRlZDsKICAgICBsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGV2aWNl X21vZGVsKGVnYywgJmRzcy0+ZHNwcyk7IC8qIG11c3QgYmUgbGFzdCAqLwog CkBAIC0yMjA5LDYgKzIyMTIsOCBAQCBzdGF0aWMgdm9pZCBzb2Z0X3Jlc2V0 X2RtX3N1c3BlbmRlZChsaWJ4bF9fZWdjICplZ2MsCiAgICAgICAgIENPTlRB SU5FUl9PRihkc3BzLCAqc3JzLCBkc3MuZHNwcyk7CiAgICAgbGlieGxfX2Fw cF9kb21haW5fY3JlYXRlX3N0YXRlICpjZGNzID0gJnNycy0+Y2RjczsKIAor ICAgIGxpYnhsX19kb21haW5fc3VzcGVuZF9kaXNwb3NlKGdjLCBkc3BzKTsK KwogICAgIC8qCiAgICAgICogQXNrIGFsbCBiYWNrZW5kcyB0byBkaXNjb25u ZWN0IGJ5IHJlbW92aW5nIHRoZSBkb21haW4gZnJvbQogICAgICAqIHhlbnN0 b3JlLiBPbiB0aGUgY3JlYXRpb24gcGF0aCB0aGUgZG9tYWluIHdpbGwgYmUg aW50cm9kdWNlZCB0bwpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9s aWJ4bF9kb21fc3VzcGVuZC5jIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9k b21fc3VzcGVuZC5jCmluZGV4IGY3ODIzYmJjOGYuLjRmYTIyYmI3MzkgMTAw NjQ0Ci0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfZG9tX3N1c3BlbmQu YworKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2RvbV9zdXNwZW5kLmMK QEAgLTY3LDYgKzY3LDE2IEBAIG91dDoKICAgICByZXR1cm4gcmM7CiB9CiAK K3ZvaWQgbGlieGxfX2RvbWFpbl9zdXNwZW5kX2Rpc3Bvc2UobGlieGxfX2dj ICpnYywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGli eGxfX2RvbWFpbl9zdXNwZW5kX3N0YXRlICAqZHNwcykKK3sKKyAgICBsaWJ4 bF9feHN3YWl0X3N0b3AoZ2MsICZkc3BzLT5wdmNvbnRyb2wpOworICAgIGxp YnhsX19ldl9ldnRjaG5fY2FuY2VsKGdjLCAmZHNwcy0+Z3Vlc3RfZXZ0Y2hu KTsKKyAgICBsaWJ4bF9fZXZfeHN3YXRjaF9kZXJlZ2lzdGVyKGdjLCAmZHNw cy0+Z3Vlc3Rfd2F0Y2gpOworICAgIGxpYnhsX19ldl90aW1lX2RlcmVnaXN0 ZXIoZ2MsICZkc3BzLT5ndWVzdF90aW1lb3V0KTsKKyAgICBsaWJ4bF9fZXZf cW1wX2Rpc3Bvc2UoZ2MsICZkc3BzLT5xbXApOworfQorCiAvKi0tLS0tIGNh bGxiYWNrcywgY2FsbGVkIGJ5IHhjX2RvbWFpbl9zYXZlIC0tLS0tKi8KIAog dm9pZCBsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGV2aWNlX21vZGVsKGxpYnhs X19lZ2MgKmVnYywKQEAgLTM4OCwxMCArMzk4LDcgQEAgc3RhdGljIHZvaWQg ZG9tYWluX3N1c3BlbmRfY29tbW9uX2RvbmUobGlieGxfX2VnYyAqZWdjLAog ewogICAgIEVHQ19HQzsKICAgICBhc3NlcnQoIWxpYnhsX194c3dhaXRfaW51 c2UoJmRzcHMtPnB2Y29udHJvbCkpOwotICAgIGxpYnhsX19ldl9ldnRjaG5f Y2FuY2VsKGdjLCAmZHNwcy0+Z3Vlc3RfZXZ0Y2huKTsKLSAgICBsaWJ4bF9f ZXZfeHN3YXRjaF9kZXJlZ2lzdGVyKGdjLCAmZHNwcy0+Z3Vlc3Rfd2F0Y2gp OwotICAgIGxpYnhsX19ldl90aW1lX2RlcmVnaXN0ZXIoZ2MsICZkc3BzLT5n dWVzdF90aW1lb3V0KTsKLSAgICBsaWJ4bF9fZXZfcW1wX2Rpc3Bvc2UoZ2Ms ICZkc3BzLT5xbXApOworICAgIGxpYnhsX19kb21haW5fc3VzcGVuZF9kaXNw b3NlKGdjLCBkc3BzKTsKICAgICBkc3BzLT5jYWxsYmFja19jb21tb25fZG9u ZShlZ2MsIGRzcHMsIHJjKTsKIH0KIApkaWZmIC0tZ2l0IGEvdG9vbHMvbGli cy9saWdodC9saWJ4bF9pbnRlcm5hbC5oIGIvdG9vbHMvbGlicy9saWdodC9s aWJ4bF9pbnRlcm5hbC5oCmluZGV4IDAyOGJjMDEzZDkuLmM2YTRhMTg3ZjUg MTAwNjQ0Ci0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfaW50ZXJuYWwu aAorKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2ludGVybmFsLmgKQEAg LTM2MTcsNiArMzYxNyw4IEBAIHN0cnVjdCBsaWJ4bF9fZG9tYWluX3N1c3Bl bmRfc3RhdGUgewogaW50IGxpYnhsX19kb21haW5fc3VzcGVuZF9pbml0KGxp YnhsX19lZ2MgKmVnYywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBsaWJ4bF9fZG9tYWluX3N1c3BlbmRfc3RhdGUgKmRzcHMsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfZG9tYWluX3R5cGUgdHlw ZSk7Cit2b2lkIGxpYnhsX19kb21haW5fc3VzcGVuZF9kaXNwb3NlKGxpYnhs X19nYyAqZ2MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGxpYnhsX19kb21haW5fc3VzcGVuZF9zdGF0ZSAgKmRzcHMpOwogCiAvKiBj YWxscyBkc3BzLT5jYWxsYmFja19kZXZpY2VfbW9kZWxfZG9uZSB3aGVuIGRv bmUKICAqIG1heSBzeW5jaHJvbm91c2x5IGNhbGxzIHRoaXMgY2FsbGJhY2sg Ki8KLS0gCjIuMzAuMQoK --=separator Content-Type: application/octet-stream; name="xsa368-4.13.patch" Content-Disposition: attachment; filename="xsa368-4.13.patch" Content-Transfer-Encoding: base64 RnJvbSBhNzMzZmNjYTk3ZDRlMGQ3NTAzMTk4YmExZGQ3MzlhNWQ3YTAwZGFj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRob255IFBFUkFS RCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KRGF0ZTogV2VkLCAyNCBG ZWIgMjAyMSAxODozOToyMCArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIGxpYnhs OiBGaXggZG9tYWluIHNvZnQgcmVzZXQgc3RhdGUgaGFuZGxpbmcKCkluIGRv X2RvbWFpbl9zb2Z0X3Jlc2V0KCksIGEgYGxpYnhsX19kb21haW5fc3VzcGVu ZF9zdGF0ZScgaXMgdXNlZAp3aXRob3V0IGJlZW4gcHJvcGVybHkgaW5pdGlh bGlzZWQgYW5kIGRpc3Bvc2VkIG9mLiBUaGlzIGxlYWQgZG8gYQphYm9ydCgp IGluIGxpYnhsIGR1ZSB0byB0aGUgYGRzcHMucW1wJyBzdGF0ZSBiZWVuIHVz ZWQgYmVmb3JlIGJlZW4KaW5pdGlhbGlzZWQ6CiAgICBsaWJ4bF9fZXZfcW1w X3NlbmQ6IEFzc2VydGlvbiBgZXYtPnN0YXRlID09IHFtcF9zdGF0ZV9kaXNj b25uZWN0ZWQgfHwgZXYtPnN0YXRlID09IHFtcF9zdGF0ZV9jb25uZWN0ZWQn IGZhaWxlZC4KCk9uY2UgaW5pdGlhbGlzZWQsIGBkc3BzJyBhbHNvIG5lZWRz IHRvIGJlIGRpc3Bvc2VkIG9mIGFzIHRoZSBgcW1wJwpzdGF0ZSBtaWdodCBz dGlsbCBiZSBpbiB0aGUgYENvbm5lY3RlZCcgc3RhdGUgaW4gdGhlIGNhbGxi YWNrIGZvcgpsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGV2aWNlX21vZGVsKCku IFNvIHRoaXMgcGF0Y2ggYWRkcwpsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGlz cG9zZSgpIHdoaWNoIGNhbiBiZSBjYWxsZWQgZnJvbSB0aGUgdHdvCnBsYWNl cyB3aGVyZSB3ZSBuZWVkIHRvIGRpc3Bvc2Ugb2YgYGRzcHMnLgoKUmVwb3J0 ZWQtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT4KU2lnbmVkLW9m Zi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5j b20+ClJldmlld2VkLWJ5OiBJYW4gSmFja3NvbiA8aXdqQHhlbnByb2plY3Qu b3JnPgpUZXN0ZWQtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT4K LS0tCiB0b29scy9saWJ4bC9saWJ4bF9jcmVhdGUuYyAgICAgIHwgMTEgKysr KysrKystLS0KIHRvb2xzL2xpYnhsL2xpYnhsX2RvbV9zdXNwZW5kLmMgfCAx NSArKysrKysrKysrKy0tLS0KIHRvb2xzL2xpYnhsL2xpYnhsX2ludGVybmFs LmggICAgfCAgMiArKwogMyBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25z KCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhs L2xpYnhsX2NyZWF0ZS5jIGIvdG9vbHMvbGlieGwvbGlieGxfY3JlYXRlLmMK aW5kZXggMzJkNDVkY2VmMC4uNjUxYWQxOGQyZCAxMDA2NDQKLS0tIGEvdG9v bHMvbGlieGwvbGlieGxfY3JlYXRlLmMKKysrIGIvdG9vbHMvbGlieGwvbGli eGxfY3JlYXRlLmMKQEAgLTE5NzQsOSArMTk3NCw3IEBAIHN0YXRpYyBpbnQg ZG9fZG9tYWluX3NvZnRfcmVzZXQobGlieGxfY3R4ICpjdHgsCiAgICAgc3Rh dGUtPmNvbnNvbGVfdHR5ID0gbGlieGxfX3N0cmR1cChnYywgY29uc29sZV90 dHkpOwogCiAgICAgZHNzLT5hbyA9IGFvOwotICAgIGRzcy0+ZG9taWQgPSBk c3MtPmRzcHMuZG9taWQgPSBkb21pZF9zb2Z0X3Jlc2V0OwotICAgIGRzcy0+ ZHNwcy5kbV9zYXZlZmlsZSA9IEdDU1BSSU5URihMSUJYTF9ERVZJQ0VfTU9E RUxfU0FWRV9GSUxFIi4lZCIsCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGRvbWlkX3NvZnRfcmVzZXQpOworICAgIGRzcy0+ZG9t aWQgPSBkb21pZF9zb2Z0X3Jlc2V0OwogCiAgICAgcmMgPSBsaWJ4bF9fc2F2 ZV9lbXVsYXRvcl94ZW5zdG9yZV9kYXRhKGRzcywgJnNycy0+dG9vbHN0YWNr X2J1ZiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJnNycy0+dG9vbHN0YWNrX2xlbik7CkBAIC0xOTg2LDYgKzE5ODQs MTEgQEAgc3RhdGljIGludCBkb19kb21haW5fc29mdF9yZXNldChsaWJ4bF9j dHggKmN0eCwKICAgICB9CiAKICAgICBkc3MtPmRzcHMuYW8gPSBhbzsKKyAg ICBkc3MtPmRzcHMuZG9taWQgPSBkb21pZF9zb2Z0X3Jlc2V0OworICAgIGRz cy0+ZHNwcy5saXZlID0gZmFsc2U7CisgICAgcmMgPSBsaWJ4bF9fZG9tYWlu X3N1c3BlbmRfaW5pdChlZ2MsICZkc3MtPmRzcHMsIGRfY29uZmlnLT5iX2lu Zm8udHlwZSk7CisgICAgaWYgKHJjKQorICAgICAgICBnb3RvIG91dDsKICAg ICBkc3MtPmRzcHMuY2FsbGJhY2tfZGV2aWNlX21vZGVsX2RvbmUgPSBzb2Z0 X3Jlc2V0X2RtX3N1c3BlbmRlZDsKICAgICBsaWJ4bF9fZG9tYWluX3N1c3Bl bmRfZGV2aWNlX21vZGVsKGVnYywgJmRzcy0+ZHNwcyk7IC8qIG11c3QgYmUg bGFzdCAqLwogCkBAIC0yMDA0LDYgKzIwMDcsOCBAQCBzdGF0aWMgdm9pZCBz b2Z0X3Jlc2V0X2RtX3N1c3BlbmRlZChsaWJ4bF9fZWdjICplZ2MsCiAgICAg ICAgIENPTlRBSU5FUl9PRihkc3BzLCAqc3JzLCBkc3MuZHNwcyk7CiAgICAg bGlieGxfX2FwcF9kb21haW5fY3JlYXRlX3N0YXRlICpjZGNzID0gJnNycy0+ Y2RjczsKIAorICAgIGxpYnhsX19kb21haW5fc3VzcGVuZF9kaXNwb3NlKGdj LCBkc3BzKTsKKwogICAgIC8qCiAgICAgICogQXNrIGFsbCBiYWNrZW5kcyB0 byBkaXNjb25uZWN0IGJ5IHJlbW92aW5nIHRoZSBkb21haW4gZnJvbQogICAg ICAqIHhlbnN0b3JlLiBPbiB0aGUgY3JlYXRpb24gcGF0aCB0aGUgZG9tYWlu IHdpbGwgYmUgaW50cm9kdWNlZCB0bwpkaWZmIC0tZ2l0IGEvdG9vbHMvbGli eGwvbGlieGxfZG9tX3N1c3BlbmQuYyBiL3Rvb2xzL2xpYnhsL2xpYnhsX2Rv bV9zdXNwZW5kLmMKaW5kZXggMjVkMTU3MTg5NS4uMmEyODBmNjlhMSAxMDA2 NDQKLS0tIGEvdG9vbHMvbGlieGwvbGlieGxfZG9tX3N1c3BlbmQuYworKysg Yi90b29scy9saWJ4bC9saWJ4bF9kb21fc3VzcGVuZC5jCkBAIC02Nyw2ICs2 NywxNiBAQCBvdXQ6CiAgICAgcmV0dXJuIHJjOwogfQogCit2b2lkIGxpYnhs X19kb21haW5fc3VzcGVuZF9kaXNwb3NlKGxpYnhsX19nYyAqZ2MsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxpYnhsX19kb21haW5f c3VzcGVuZF9zdGF0ZSAgKmRzcHMpCit7CisgICAgbGlieGxfX3hzd2FpdF9z dG9wKGdjLCAmZHNwcy0+cHZjb250cm9sKTsKKyAgICBsaWJ4bF9fZXZfZXZ0 Y2huX2NhbmNlbChnYywgJmRzcHMtPmd1ZXN0X2V2dGNobik7CisgICAgbGli eGxfX2V2X3hzd2F0Y2hfZGVyZWdpc3RlcihnYywgJmRzcHMtPmd1ZXN0X3dh dGNoKTsKKyAgICBsaWJ4bF9fZXZfdGltZV9kZXJlZ2lzdGVyKGdjLCAmZHNw cy0+Z3Vlc3RfdGltZW91dCk7CisgICAgbGlieGxfX2V2X3FtcF9kaXNwb3Nl KGdjLCAmZHNwcy0+cW1wKTsKK30KKwogLyotLS0tLSBjYWxsYmFja3MsIGNh bGxlZCBieSB4Y19kb21haW5fc2F2ZSAtLS0tLSovCiAKIHZvaWQgbGlieGxf X2RvbWFpbl9zdXNwZW5kX2RldmljZV9tb2RlbChsaWJ4bF9fZWdjICplZ2Ms CkBAIC0zODgsMTAgKzM5OCw3IEBAIHN0YXRpYyB2b2lkIGRvbWFpbl9zdXNw ZW5kX2NvbW1vbl9kb25lKGxpYnhsX19lZ2MgKmVnYywKIHsKICAgICBFR0Nf R0M7CiAgICAgYXNzZXJ0KCFsaWJ4bF9feHN3YWl0X2ludXNlKCZkc3BzLT5w dmNvbnRyb2wpKTsKLSAgICBsaWJ4bF9fZXZfZXZ0Y2huX2NhbmNlbChnYywg JmRzcHMtPmd1ZXN0X2V2dGNobik7Ci0gICAgbGlieGxfX2V2X3hzd2F0Y2hf ZGVyZWdpc3RlcihnYywgJmRzcHMtPmd1ZXN0X3dhdGNoKTsKLSAgICBsaWJ4 bF9fZXZfdGltZV9kZXJlZ2lzdGVyKGdjLCAmZHNwcy0+Z3Vlc3RfdGltZW91 dCk7Ci0gICAgbGlieGxfX2V2X3FtcF9kaXNwb3NlKGdjLCAmZHNwcy0+cW1w KTsKKyAgICBsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGlzcG9zZShnYywgZHNw cyk7CiAgICAgZHNwcy0+Y2FsbGJhY2tfY29tbW9uX2RvbmUoZWdjLCBkc3Bz LCByYyk7CiB9CiAKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX2lu dGVybmFsLmggYi90b29scy9saWJ4bC9saWJ4bF9pbnRlcm5hbC5oCmluZGV4 IDI0NzUxOGE3YWMuLjViNDc5NTkwOGIgMTAwNjQ0Ci0tLSBhL3Rvb2xzL2xp YnhsL2xpYnhsX2ludGVybmFsLmgKKysrIGIvdG9vbHMvbGlieGwvbGlieGxf aW50ZXJuYWwuaApAQCAtMzU2OSw2ICszNTY5LDggQEAgc3RydWN0IGxpYnhs X19kb21haW5fc3VzcGVuZF9zdGF0ZSB7CiBpbnQgbGlieGxfX2RvbWFpbl9z dXNwZW5kX2luaXQobGlieGxfX2VnYyAqZWdjLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGxpYnhsX19kb21haW5fc3VzcGVuZF9zdGF0ZSAq ZHNwcywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9k b21haW5fdHlwZSB0eXBlKTsKK3ZvaWQgbGlieGxfX2RvbWFpbl9zdXNwZW5k X2Rpc3Bvc2UobGlieGxfX2djICpnYywKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgbGlieGxfX2RvbWFpbl9zdXNwZW5kX3N0YXRlICAq ZHNwcyk7CiAKIC8qIGNhbGxzIGRzcHMtPmNhbGxiYWNrX2RldmljZV9tb2Rl bF9kb25lIHdoZW4gZG9uZQogICogbWF5IHN5bmNocm9ub3VzbHkgY2FsbHMg dGhpcyBjYWxsYmFjayAqLwotLSAKMi4zMC4xCgo= --=separator Content-Type: application/octet-stream; name="xsa368-4.14.patch" Content-Disposition: attachment; filename="xsa368-4.14.patch" Content-Transfer-Encoding: base64 RnJvbSBiMWQ1ZTAzM2RmMTg1OGVkZDZmYTMyOGFiZDEyNjUyMjk0NzQ0MGFh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRob255IFBFUkFS RCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KRGF0ZTogV2VkLCAyNCBG ZWIgMjAyMSAxODozOToyMCArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIGxpYnhs OiBGaXggZG9tYWluIHNvZnQgcmVzZXQgc3RhdGUgaGFuZGxpbmcKCkluIGRv X2RvbWFpbl9zb2Z0X3Jlc2V0KCksIGEgYGxpYnhsX19kb21haW5fc3VzcGVu ZF9zdGF0ZScgaXMgdXNlZAp3aXRob3V0IGJlZW4gcHJvcGVybHkgaW5pdGlh bGlzZWQgYW5kIGRpc3Bvc2VkIG9mLiBUaGlzIGxlYWQgZG8gYQphYm9ydCgp IGluIGxpYnhsIGR1ZSB0byB0aGUgYGRzcHMucW1wJyBzdGF0ZSBiZWVuIHVz ZWQgYmVmb3JlIGJlZW4KaW5pdGlhbGlzZWQ6CiAgICBsaWJ4bF9fZXZfcW1w X3NlbmQ6IEFzc2VydGlvbiBgZXYtPnN0YXRlID09IHFtcF9zdGF0ZV9kaXNj b25uZWN0ZWQgfHwgZXYtPnN0YXRlID09IHFtcF9zdGF0ZV9jb25uZWN0ZWQn IGZhaWxlZC4KCk9uY2UgaW5pdGlhbGlzZWQsIGBkc3BzJyBhbHNvIG5lZWRz IHRvIGJlIGRpc3Bvc2VkIG9mIGFzIHRoZSBgcW1wJwpzdGF0ZSBtaWdodCBz dGlsbCBiZSBpbiB0aGUgYENvbm5lY3RlZCcgc3RhdGUgaW4gdGhlIGNhbGxi YWNrIGZvcgpsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGV2aWNlX21vZGVsKCku IFNvIHRoaXMgcGF0Y2ggYWRkcwpsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGlz cG9zZSgpIHdoaWNoIGNhbiBiZSBjYWxsZWQgZnJvbSB0aGUgdHdvCnBsYWNl cyB3aGVyZSB3ZSBuZWVkIHRvIGRpc3Bvc2Ugb2YgYGRzcHMnLgoKUmVwb3J0 ZWQtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT4KU2lnbmVkLW9m Zi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5j b20+ClJldmlld2VkLWJ5OiBJYW4gSmFja3NvbiA8aXdqQHhlbnByb2plY3Qu b3JnPgpUZXN0ZWQtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT4K LS0tCiB0b29scy9saWJ4bC9saWJ4bF9jcmVhdGUuYyAgICAgIHwgMTEgKysr KysrKystLS0KIHRvb2xzL2xpYnhsL2xpYnhsX2RvbV9zdXNwZW5kLmMgfCAx NSArKysrKysrKysrKy0tLS0KIHRvb2xzL2xpYnhsL2xpYnhsX2ludGVybmFs LmggICAgfCAgMiArKwogMyBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25z KCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhs L2xpYnhsX2NyZWF0ZS5jIGIvdG9vbHMvbGlieGwvbGlieGxfY3JlYXRlLmMK aW5kZXggMjgxNDgxOGUzNC4uODNiMGViMDBiZiAxMDA2NDQKLS0tIGEvdG9v bHMvbGlieGwvbGlieGxfY3JlYXRlLmMKKysrIGIvdG9vbHMvbGlieGwvbGli eGxfY3JlYXRlLmMKQEAgLTIxNzQsOSArMjE3NCw3IEBAIHN0YXRpYyBpbnQg ZG9fZG9tYWluX3NvZnRfcmVzZXQobGlieGxfY3R4ICpjdHgsCiAgICAgc3Rh dGUtPmNvbnNvbGVfdHR5ID0gbGlieGxfX3N0cmR1cChnYywgY29uc29sZV90 dHkpOwogCiAgICAgZHNzLT5hbyA9IGFvOwotICAgIGRzcy0+ZG9taWQgPSBk c3MtPmRzcHMuZG9taWQgPSBkb21pZDsKLSAgICBkc3MtPmRzcHMuZG1fc2F2 ZWZpbGUgPSBHQ1NQUklOVEYoTElCWExfREVWSUNFX01PREVMX1NBVkVfRklM RSIuJWQiLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBkb21pZCk7CisgICAgZHNzLT5kb21pZCA9IGRvbWlkOwogCiAgICAgcmMg PSBsaWJ4bF9fc2F2ZV9lbXVsYXRvcl94ZW5zdG9yZV9kYXRhKGRzcywgJnNy cy0+dG9vbHN0YWNrX2J1ZiwKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJnNycy0+dG9vbHN0YWNrX2xlbik7CkBAIC0y MTg2LDYgKzIxODQsMTEgQEAgc3RhdGljIGludCBkb19kb21haW5fc29mdF9y ZXNldChsaWJ4bF9jdHggKmN0eCwKICAgICB9CiAKICAgICBkc3MtPmRzcHMu YW8gPSBhbzsKKyAgICBkc3MtPmRzcHMuZG9taWQgPSBkb21pZDsKKyAgICBk c3MtPmRzcHMubGl2ZSA9IGZhbHNlOworICAgIHJjID0gbGlieGxfX2RvbWFp bl9zdXNwZW5kX2luaXQoZWdjLCAmZHNzLT5kc3BzLCBkX2NvbmZpZy0+Yl9p bmZvLnR5cGUpOworICAgIGlmIChyYykKKyAgICAgICAgZ290byBvdXQ7CiAg ICAgZHNzLT5kc3BzLmNhbGxiYWNrX2RldmljZV9tb2RlbF9kb25lID0gc29m dF9yZXNldF9kbV9zdXNwZW5kZWQ7CiAgICAgbGlieGxfX2RvbWFpbl9zdXNw ZW5kX2RldmljZV9tb2RlbChlZ2MsICZkc3MtPmRzcHMpOyAvKiBtdXN0IGJl IGxhc3QgKi8KIApAQCAtMjIwNCw2ICsyMjA3LDggQEAgc3RhdGljIHZvaWQg c29mdF9yZXNldF9kbV9zdXNwZW5kZWQobGlieGxfX2VnYyAqZWdjLAogICAg ICAgICBDT05UQUlORVJfT0YoZHNwcywgKnNycywgZHNzLmRzcHMpOwogICAg IGxpYnhsX19hcHBfZG9tYWluX2NyZWF0ZV9zdGF0ZSAqY2RjcyA9ICZzcnMt PmNkY3M7CiAKKyAgICBsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGlzcG9zZShn YywgZHNwcyk7CisKICAgICAvKgogICAgICAqIEFzayBhbGwgYmFja2VuZHMg dG8gZGlzY29ubmVjdCBieSByZW1vdmluZyB0aGUgZG9tYWluIGZyb20KICAg ICAgKiB4ZW5zdG9yZS4gT24gdGhlIGNyZWF0aW9uIHBhdGggdGhlIGRvbWFp biB3aWxsIGJlIGludHJvZHVjZWQgdG8KZGlmZiAtLWdpdCBhL3Rvb2xzL2xp YnhsL2xpYnhsX2RvbV9zdXNwZW5kLmMgYi90b29scy9saWJ4bC9saWJ4bF9k b21fc3VzcGVuZC5jCmluZGV4IDI1ZDE1NzE4OTUuLjJhMjgwZjY5YTEgMTAw NjQ0Ci0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsX2RvbV9zdXNwZW5kLmMKKysr IGIvdG9vbHMvbGlieGwvbGlieGxfZG9tX3N1c3BlbmQuYwpAQCAtNjcsNiAr NjcsMTYgQEAgb3V0OgogICAgIHJldHVybiByYzsKIH0KIAordm9pZCBsaWJ4 bF9fZG9tYWluX3N1c3BlbmRfZGlzcG9zZShsaWJ4bF9fZ2MgKmdjLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9fZG9tYWlu X3N1c3BlbmRfc3RhdGUgICpkc3BzKQoreworICAgIGxpYnhsX194c3dhaXRf c3RvcChnYywgJmRzcHMtPnB2Y29udHJvbCk7CisgICAgbGlieGxfX2V2X2V2 dGNobl9jYW5jZWwoZ2MsICZkc3BzLT5ndWVzdF9ldnRjaG4pOworICAgIGxp YnhsX19ldl94c3dhdGNoX2RlcmVnaXN0ZXIoZ2MsICZkc3BzLT5ndWVzdF93 YXRjaCk7CisgICAgbGlieGxfX2V2X3RpbWVfZGVyZWdpc3RlcihnYywgJmRz cHMtPmd1ZXN0X3RpbWVvdXQpOworICAgIGxpYnhsX19ldl9xbXBfZGlzcG9z ZShnYywgJmRzcHMtPnFtcCk7Cit9CisKIC8qLS0tLS0gY2FsbGJhY2tzLCBj YWxsZWQgYnkgeGNfZG9tYWluX3NhdmUgLS0tLS0qLwogCiB2b2lkIGxpYnhs X19kb21haW5fc3VzcGVuZF9kZXZpY2VfbW9kZWwobGlieGxfX2VnYyAqZWdj LApAQCAtMzg4LDEwICszOTgsNyBAQCBzdGF0aWMgdm9pZCBkb21haW5fc3Vz cGVuZF9jb21tb25fZG9uZShsaWJ4bF9fZWdjICplZ2MsCiB7CiAgICAgRUdD X0dDOwogICAgIGFzc2VydCghbGlieGxfX3hzd2FpdF9pbnVzZSgmZHNwcy0+ cHZjb250cm9sKSk7Ci0gICAgbGlieGxfX2V2X2V2dGNobl9jYW5jZWwoZ2Ms ICZkc3BzLT5ndWVzdF9ldnRjaG4pOwotICAgIGxpYnhsX19ldl94c3dhdGNo X2RlcmVnaXN0ZXIoZ2MsICZkc3BzLT5ndWVzdF93YXRjaCk7Ci0gICAgbGli eGxfX2V2X3RpbWVfZGVyZWdpc3RlcihnYywgJmRzcHMtPmd1ZXN0X3RpbWVv dXQpOwotICAgIGxpYnhsX19ldl9xbXBfZGlzcG9zZShnYywgJmRzcHMtPnFt cCk7CisgICAgbGlieGxfX2RvbWFpbl9zdXNwZW5kX2Rpc3Bvc2UoZ2MsIGRz cHMpOwogICAgIGRzcHMtPmNhbGxiYWNrX2NvbW1vbl9kb25lKGVnYywgZHNw cywgcmMpOwogfQogCmRpZmYgLS1naXQgYS90b29scy9saWJ4bC9saWJ4bF9p bnRlcm5hbC5oIGIvdG9vbHMvbGlieGwvbGlieGxfaW50ZXJuYWwuaAppbmRl eCA5NGEyMzE3OWQzLi4zYmMzYmJjZjg0IDEwMDY0NAotLS0gYS90b29scy9s aWJ4bC9saWJ4bF9pbnRlcm5hbC5oCisrKyBiL3Rvb2xzL2xpYnhsL2xpYnhs X2ludGVybmFsLmgKQEAgLTM2MTUsNiArMzYxNSw4IEBAIHN0cnVjdCBsaWJ4 bF9fZG9tYWluX3N1c3BlbmRfc3RhdGUgewogaW50IGxpYnhsX19kb21haW5f c3VzcGVuZF9pbml0KGxpYnhsX19lZ2MgKmVnYywKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBsaWJ4bF9fZG9tYWluX3N1c3BlbmRfc3RhdGUg KmRzcHMsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxf ZG9tYWluX3R5cGUgdHlwZSk7Cit2b2lkIGxpYnhsX19kb21haW5fc3VzcGVu ZF9kaXNwb3NlKGxpYnhsX19nYyAqZ2MsCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGxpYnhsX19kb21haW5fc3VzcGVuZF9zdGF0ZSAg KmRzcHMpOwogCiAvKiBjYWxscyBkc3BzLT5jYWxsYmFja19kZXZpY2VfbW9k ZWxfZG9uZSB3aGVuIGRvbmUKICAqIG1heSBzeW5jaHJvbm91c2x5IGNhbGxz IHRoaXMgY2FsbGJhY2sgKi8KLS0gCjIuMzAuMQoK --=separator-- From xen-devel-bounces@lists.xenproject.org Thu Mar 18 12:41:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 12:41:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98943.187962 (Exim 4.92) (envelope-from ) id 1lMrxc-0005ta-Ab; Thu, 18 Mar 2021 12:41:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98943.187962; Thu, 18 Mar 2021 12:41:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMrxc-0005tT-7X; Thu, 18 Mar 2021 12:41:08 +0000 Received: by outflank-mailman (input) for mailman id 98943; Thu, 18 Mar 2021 12:41:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMrxa-0005tL-M0; Thu, 18 Mar 2021 12:41:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMrxa-0008RK-GR; Thu, 18 Mar 2021 12:41:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMrxa-0007Gi-5y; Thu, 18 Mar 2021 12:41:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMrxa-0007Yk-5V; Thu, 18 Mar 2021 12:41:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jPlDJB95SZRGKIl3iDgMFajAADKEeOgAcbk6ZcjHSZc=; b=YqqgpFp9nxF/t9VUQoBm0VGNsy vQftSUd5YiZW8PlddOvh8xqXIphgKTr/12d55FmoDSM1/5haRIlbKg3kvOlBSGtr6fFx71BNnPHHP 91p5xf98JGrR8Wq95LSZlV/e39wbNQ0MpwnS0bCSiMq/cij1o3kSMHMA+UPRaNxkKzf8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160119: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=571d413b5da6bc6f1c2aaca8484717642255ddb0 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Thu, 18 Mar 2021 12:41:06 +0000 flight 160119 qemu-mainline real [real] flight 160124 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160119/ http://logs.test-lab.xenproject.org/osstest/logs/160124/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 571d413b5da6bc6f1c2aaca8484717642255ddb0 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 210 days Failing since 152659 2020-08-21 14:07:39 Z 208 days 405 attempts Testing same since 160119 2021-03-18 00:08:21 Z 0 days 1 attempts ------------------------------------------------------------ 456 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 131281 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 18 13:56:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 13:56:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.98976.188031 (Exim 4.92) (envelope-from ) id 1lMt8o-0004Rg-GZ; Thu, 18 Mar 2021 13:56:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 98976.188031; Thu, 18 Mar 2021 13:56:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMt8o-0004RZ-CS; Thu, 18 Mar 2021 13:56:46 +0000 Received: by outflank-mailman (input) for mailman id 98976; Thu, 18 Mar 2021 13:56:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMt8n-0004Jq-2w for xen-devel@lists.xen.org; Thu, 18 Mar 2021 13:56:45 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 820487c9-4685-42a4-ae71-10b3d4814333; Thu, 18 Mar 2021 13:56:28 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMt8S-0001Dx-0g; Thu, 18 Mar 2021 13:56:24 +0000 Received: from iwj by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMt8R-000718-Sb; Thu, 18 Mar 2021 13:56:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 820487c9-4685-42a4-ae71-10b3d4814333 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=Ut4jnS8RkrbTcZZFmLZa5+CbVR3NJ6IAwQOVyYtLDRM=; b=tTBFURJp6HO4MuTixVQ8klB+6t GpnF9pgijqkUDAfN2iW7BKZqg9YRLFp3ncPEUMOOABANAJm6IK7h/TjQJRw8iIOOST9403SBmOAre hQERHZX8PhtwKSvRfscYA/KvGVvaMXgbXk7d0UdJlal2QLXfF4n+CVVIapzcnLsGB9dg=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 368 v3 (CVE-2021-28687) - HVM soft-reset crashes toolstack Message-Id: Date: Thu, 18 Mar 2021 13:56:23 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2021-28687 / XSA-368 version 3 HVM soft-reset crashes toolstack UPDATES IN VERSION 3 ==================== CVE assigned. ISSUE DESCRIPTION ================= libxl requires all data structures passed across its public interface to be initialized before use and disposed of afterwards by calling a specific set of functions. Many internal data structures also require this initialize / dispose discipline, but not all of them. When the "soft reset" feature was implemented, the libxl__domain_suspend_state structure didn't require any initialization or disposal. At some point later, an initialization function was introduced for the structure; but the "soft reset" path wasn't refactored to call the initialization function. When a guest nwo initiates a "soft reboot", uninitialized data structure leads to an assert() when later code finds the structure in an unexpected state. The effect of this is to crash the process monitoring the guest. How this affects the system depends on the structure of the toolstack. For xl, this will have no security-relevant effect: every VM has its own independent monitoring process, which contains no state. The domain in question will hang in a crashed state, but can be destroyed by `xl destroy` just like any other non-cooperating domain. For daemon-based toolstacks linked against libxl, such as libvirt, this will crash the toolstack, losing the state of any in-progress operations (localized DoS), and preventing further administrator operations unless the daemon is configured to restart automatically (system-wide DoS). If crashes "leak" resources, then repeated crashes could use up resources, also causing a system-wide DoS. IMPACT ====== A malicious guest can crash the management daemon, leading to at least a localized, possibly system-wide denial-of-service. VULNERABLE SYSTEMS ================== Only Xen versions 4.12 through 4.14 are affected. Earlier versions are not affected. The issue affects only systems with a guest monitoring process, which is linked against libxl, and which is important other than simply for the functioning of one particular guest. libvirt is one common toolstack affected. Systems using the `xl` command-line tool should generally suffer no security-relevant effects. The xapi toolstack does not currently link against libxl, and so is not affected. MITIGATION ========== Ensuring that any management daemons are restarted automatically after a crash will partially mitigate the issue. CREDITS ======= This issue was discovered by Olaf Hering. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa368.patch xen-unstable xsa368-4.14.patch Xen 4.14.x xsa368-4.13.patch Xen 4.13.x - Xen 4.12.x $ sha256sum xsa368* e80f33c3ce45372fef7bd91ec71b2b66e557176b79f9771872ce111bfff34150 xsa368.meta b82f2b110514cdf47a2688913ad5af68b01050751d56705a15ddf9a970b6fa0d xsa368.patch 636df70ae5eaf00b50ef0b5ac219a2aeda771c66833fae88e7ee43b18ae889f4 xsa368-4.13.patch 55bbe59c75b69f493e364dfcf6cdbc7db4acd32dbf0b4d2466815b7c1f1823ce xsa368-4.14.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmBTXAAMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZdgcH/RTW41tLPh8KHJ+82qefaI2EUBK3nmNnR5hnye3c 9GPP/QB7QdHp+JSIRTAZxOayBQeFEcYSX/5VxDypIiqT02wHS9hDr3jcpOfGLcdt MiN9kB3vYqe353Lask0mN7AX3J5v3wvrYzBRx9ccaYcX/Jcubrx6Jy5laQSYpTUu 4GCeLZQ2tHI8N3ZHiKI7YUyxmn9vKgvFil1gyuk8L5x6npnW4ixdWF0MRyHe7wbS dbZbug0g6bbJbs4CFZbm1CbQjGGOwznfT8z9ppmgPdi+33X+Cimz3wlbpXeJKpZk /nJObobdPGk7ClChvUjntv0oaZ+2zFoUoe3Yc08aa+B29e8= =Dehk -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa368.meta" Content-Disposition: attachment; filename="xsa368.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiAzNjgsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNCIsCiAgICAiNC4xMyIsCiAgICAiNC4xMiIK ICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwKICAiUmVjaXBlcyI6 IHsKICAgICI0LjEyIjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAi eGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICI0Y2Y1OTI5NjA2YWRj MmZiMWFiNGUyOTIxYzE0YmE0YjgwNDZlY2QxIiwKICAgICAgICAgICJQcmVy ZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAg InhzYTM2OC00LjEzLnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAg ICAgfQogICAgfSwKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6IHsK ICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICJkN2Ex ZTA2ZWZkM2FlMmIxNmQ1YmIzMzU5MzIzNzZiN2Q3ZWFmNjMzIiwKICAgICAg ICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAg ICAgICAgICAgInhzYTM2OC00LjEzLnBhdGNoIgogICAgICAgICAgXQogICAg ICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE0IjogewogICAgICAiUmVj aXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJl ZiI6ICJiMGI3MzRhOGIzZTUxNmZmMTA0MDg4NGI3NTVhOGQ0N2FmZWQzMWVh IiwKICAgICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hl cyI6IFsKICAgICAgICAgICAgInhzYTM2OC00LjE0LnBhdGNoIgogICAgICAg ICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICJtYXN0ZXIiOiB7 CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4iOiB7CiAgICAgICAg ICAiU3RhYmxlUmVmIjogIjQ4MzQ5MzY1NDlmNzg4Mzc4OTE4ZGE4ZTliYzk3 ZGY3ZGQzZWUxNmQiLAogICAgICAgICAgIlByZXJlcXMiOiBbXSwKICAgICAg ICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhMzY4LnBhdGNoIgog ICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfQogIH0KfQ== --=separator Content-Type: application/octet-stream; name="xsa368.patch" Content-Disposition: attachment; filename="xsa368.patch" Content-Transfer-Encoding: base64 RnJvbSBlYWIyYjRhYjA2NDE5YjgyYmUxZTJjZmNkYzViYTJhNDYyNTI4ZDY4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRob255IFBFUkFS RCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KRGF0ZTogV2VkLCAyNCBG ZWIgMjAyMSAxODozOToyMCArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIGxpYnhs OiBGaXggZG9tYWluIHNvZnQgcmVzZXQgc3RhdGUgaGFuZGxpbmcKCkluIGRv X2RvbWFpbl9zb2Z0X3Jlc2V0KCksIGEgYGxpYnhsX19kb21haW5fc3VzcGVu ZF9zdGF0ZScgaXMgdXNlZAp3aXRob3V0IGJlZW4gcHJvcGVybHkgaW5pdGlh bGlzZWQgYW5kIGRpc3Bvc2VkIG9mLiBUaGlzIGxlYWQgZG8gYQphYm9ydCgp IGluIGxpYnhsIGR1ZSB0byB0aGUgYGRzcHMucW1wJyBzdGF0ZSBiZWVuIHVz ZWQgYmVmb3JlIGJlZW4KaW5pdGlhbGlzZWQ6CiAgICBsaWJ4bF9fZXZfcW1w X3NlbmQ6IEFzc2VydGlvbiBgZXYtPnN0YXRlID09IHFtcF9zdGF0ZV9kaXNj b25uZWN0ZWQgfHwgZXYtPnN0YXRlID09IHFtcF9zdGF0ZV9jb25uZWN0ZWQn IGZhaWxlZC4KCk9uY2UgaW5pdGlhbGlzZWQsIGBkc3BzJyBhbHNvIG5lZWRz IHRvIGJlIGRpc3Bvc2VkIG9mIGFzIHRoZSBgcW1wJwpzdGF0ZSBtaWdodCBz dGlsbCBiZSBpbiB0aGUgYENvbm5lY3RlZCcgc3RhdGUgaW4gdGhlIGNhbGxi YWNrIGZvcgpsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGV2aWNlX21vZGVsKCku IFNvIHRoaXMgcGF0Y2ggYWRkcwpsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGlz cG9zZSgpIHdoaWNoIGNhbiBiZSBjYWxsZWQgZnJvbSB0aGUgdHdvCnBsYWNl cyB3aGVyZSB3ZSBuZWVkIHRvIGRpc3Bvc2Ugb2YgYGRzcHMnLgoKUmVwb3J0 ZWQtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT4KU2lnbmVkLW9m Zi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5j b20+ClJldmlld2VkLWJ5OiBJYW4gSmFja3NvbiA8aXdqQHhlbnByb2plY3Qu b3JnPgpUZXN0ZWQtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT4K LS0tCiB0b29scy9saWJzL2xpZ2h0L2xpYnhsX2NyZWF0ZS5jICAgICAgfCAx MSArKysrKysrKy0tLQogdG9vbHMvbGlicy9saWdodC9saWJ4bF9kb21fc3Vz cGVuZC5jIHwgMTUgKysrKysrKysrKystLS0tCiB0b29scy9saWJzL2xpZ2h0 L2xpYnhsX2ludGVybmFsLmggICAgfCAgMiArKwogMyBmaWxlcyBjaGFuZ2Vk LCAyMSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3JlYXRlLmMgYi90b29scy9s aWJzL2xpZ2h0L2xpYnhsX2NyZWF0ZS5jCmluZGV4IDQ2ZjY4ZGE2OTcuLmRj YTI3NjY4MDUgMTAwNjQ0Ci0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxf Y3JlYXRlLmMKKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9jcmVhdGUu YwpAQCAtMjE3OSw5ICsyMTc5LDcgQEAgc3RhdGljIGludCBkb19kb21haW5f c29mdF9yZXNldChsaWJ4bF9jdHggKmN0eCwKICAgICBzdGF0ZS0+Y29uc29s ZV90dHkgPSBsaWJ4bF9fc3RyZHVwKGdjLCBjb25zb2xlX3R0eSk7CiAKICAg ICBkc3MtPmFvID0gYW87Ci0gICAgZHNzLT5kb21pZCA9IGRzcy0+ZHNwcy5k b21pZCA9IGRvbWlkOwotICAgIGRzcy0+ZHNwcy5kbV9zYXZlZmlsZSA9IEdD U1BSSU5URihMSUJYTF9ERVZJQ0VfTU9ERUxfU0FWRV9GSUxFIi4lZCIsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWlkKTsK KyAgICBkc3MtPmRvbWlkID0gZG9taWQ7CiAKICAgICByYyA9IGxpYnhsX19z YXZlX2VtdWxhdG9yX3hlbnN0b3JlX2RhdGEoZHNzLCAmc3JzLT50b29sc3Rh Y2tfYnVmLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAmc3JzLT50b29sc3RhY2tfbGVuKTsKQEAgLTIxOTEsNiArMjE4 OSwxMSBAQCBzdGF0aWMgaW50IGRvX2RvbWFpbl9zb2Z0X3Jlc2V0KGxpYnhs X2N0eCAqY3R4LAogICAgIH0KIAogICAgIGRzcy0+ZHNwcy5hbyA9IGFvOwor ICAgIGRzcy0+ZHNwcy5kb21pZCA9IGRvbWlkOworICAgIGRzcy0+ZHNwcy5s aXZlID0gZmFsc2U7CisgICAgcmMgPSBsaWJ4bF9fZG9tYWluX3N1c3BlbmRf aW5pdChlZ2MsICZkc3MtPmRzcHMsIGRfY29uZmlnLT5iX2luZm8udHlwZSk7 CisgICAgaWYgKHJjKQorICAgICAgICBnb3RvIG91dDsKICAgICBkc3MtPmRz cHMuY2FsbGJhY2tfZGV2aWNlX21vZGVsX2RvbmUgPSBzb2Z0X3Jlc2V0X2Rt X3N1c3BlbmRlZDsKICAgICBsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGV2aWNl X21vZGVsKGVnYywgJmRzcy0+ZHNwcyk7IC8qIG11c3QgYmUgbGFzdCAqLwog CkBAIC0yMjA5LDYgKzIyMTIsOCBAQCBzdGF0aWMgdm9pZCBzb2Z0X3Jlc2V0 X2RtX3N1c3BlbmRlZChsaWJ4bF9fZWdjICplZ2MsCiAgICAgICAgIENPTlRB SU5FUl9PRihkc3BzLCAqc3JzLCBkc3MuZHNwcyk7CiAgICAgbGlieGxfX2Fw cF9kb21haW5fY3JlYXRlX3N0YXRlICpjZGNzID0gJnNycy0+Y2RjczsKIAor ICAgIGxpYnhsX19kb21haW5fc3VzcGVuZF9kaXNwb3NlKGdjLCBkc3BzKTsK KwogICAgIC8qCiAgICAgICogQXNrIGFsbCBiYWNrZW5kcyB0byBkaXNjb25u ZWN0IGJ5IHJlbW92aW5nIHRoZSBkb21haW4gZnJvbQogICAgICAqIHhlbnN0 b3JlLiBPbiB0aGUgY3JlYXRpb24gcGF0aCB0aGUgZG9tYWluIHdpbGwgYmUg aW50cm9kdWNlZCB0bwpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9s aWJ4bF9kb21fc3VzcGVuZC5jIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9k b21fc3VzcGVuZC5jCmluZGV4IGY3ODIzYmJjOGYuLjRmYTIyYmI3MzkgMTAw NjQ0Ci0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfZG9tX3N1c3BlbmQu YworKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2RvbV9zdXNwZW5kLmMK QEAgLTY3LDYgKzY3LDE2IEBAIG91dDoKICAgICByZXR1cm4gcmM7CiB9CiAK K3ZvaWQgbGlieGxfX2RvbWFpbl9zdXNwZW5kX2Rpc3Bvc2UobGlieGxfX2dj ICpnYywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGli eGxfX2RvbWFpbl9zdXNwZW5kX3N0YXRlICAqZHNwcykKK3sKKyAgICBsaWJ4 bF9feHN3YWl0X3N0b3AoZ2MsICZkc3BzLT5wdmNvbnRyb2wpOworICAgIGxp YnhsX19ldl9ldnRjaG5fY2FuY2VsKGdjLCAmZHNwcy0+Z3Vlc3RfZXZ0Y2hu KTsKKyAgICBsaWJ4bF9fZXZfeHN3YXRjaF9kZXJlZ2lzdGVyKGdjLCAmZHNw cy0+Z3Vlc3Rfd2F0Y2gpOworICAgIGxpYnhsX19ldl90aW1lX2RlcmVnaXN0 ZXIoZ2MsICZkc3BzLT5ndWVzdF90aW1lb3V0KTsKKyAgICBsaWJ4bF9fZXZf cW1wX2Rpc3Bvc2UoZ2MsICZkc3BzLT5xbXApOworfQorCiAvKi0tLS0tIGNh bGxiYWNrcywgY2FsbGVkIGJ5IHhjX2RvbWFpbl9zYXZlIC0tLS0tKi8KIAog dm9pZCBsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGV2aWNlX21vZGVsKGxpYnhs X19lZ2MgKmVnYywKQEAgLTM4OCwxMCArMzk4LDcgQEAgc3RhdGljIHZvaWQg ZG9tYWluX3N1c3BlbmRfY29tbW9uX2RvbmUobGlieGxfX2VnYyAqZWdjLAog ewogICAgIEVHQ19HQzsKICAgICBhc3NlcnQoIWxpYnhsX194c3dhaXRfaW51 c2UoJmRzcHMtPnB2Y29udHJvbCkpOwotICAgIGxpYnhsX19ldl9ldnRjaG5f Y2FuY2VsKGdjLCAmZHNwcy0+Z3Vlc3RfZXZ0Y2huKTsKLSAgICBsaWJ4bF9f ZXZfeHN3YXRjaF9kZXJlZ2lzdGVyKGdjLCAmZHNwcy0+Z3Vlc3Rfd2F0Y2gp OwotICAgIGxpYnhsX19ldl90aW1lX2RlcmVnaXN0ZXIoZ2MsICZkc3BzLT5n dWVzdF90aW1lb3V0KTsKLSAgICBsaWJ4bF9fZXZfcW1wX2Rpc3Bvc2UoZ2Ms ICZkc3BzLT5xbXApOworICAgIGxpYnhsX19kb21haW5fc3VzcGVuZF9kaXNw b3NlKGdjLCBkc3BzKTsKICAgICBkc3BzLT5jYWxsYmFja19jb21tb25fZG9u ZShlZ2MsIGRzcHMsIHJjKTsKIH0KIApkaWZmIC0tZ2l0IGEvdG9vbHMvbGli cy9saWdodC9saWJ4bF9pbnRlcm5hbC5oIGIvdG9vbHMvbGlicy9saWdodC9s aWJ4bF9pbnRlcm5hbC5oCmluZGV4IDAyOGJjMDEzZDkuLmM2YTRhMTg3ZjUg MTAwNjQ0Ci0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfaW50ZXJuYWwu aAorKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2ludGVybmFsLmgKQEAg LTM2MTcsNiArMzYxNyw4IEBAIHN0cnVjdCBsaWJ4bF9fZG9tYWluX3N1c3Bl bmRfc3RhdGUgewogaW50IGxpYnhsX19kb21haW5fc3VzcGVuZF9pbml0KGxp YnhsX19lZ2MgKmVnYywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBsaWJ4bF9fZG9tYWluX3N1c3BlbmRfc3RhdGUgKmRzcHMsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfZG9tYWluX3R5cGUgdHlw ZSk7Cit2b2lkIGxpYnhsX19kb21haW5fc3VzcGVuZF9kaXNwb3NlKGxpYnhs X19nYyAqZ2MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGxpYnhsX19kb21haW5fc3VzcGVuZF9zdGF0ZSAgKmRzcHMpOwogCiAvKiBj YWxscyBkc3BzLT5jYWxsYmFja19kZXZpY2VfbW9kZWxfZG9uZSB3aGVuIGRv bmUKICAqIG1heSBzeW5jaHJvbm91c2x5IGNhbGxzIHRoaXMgY2FsbGJhY2sg Ki8KLS0gCjIuMzAuMQoK --=separator Content-Type: application/octet-stream; name="xsa368-4.13.patch" Content-Disposition: attachment; filename="xsa368-4.13.patch" Content-Transfer-Encoding: base64 RnJvbSBhNzMzZmNjYTk3ZDRlMGQ3NTAzMTk4YmExZGQ3MzlhNWQ3YTAwZGFj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRob255IFBFUkFS RCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KRGF0ZTogV2VkLCAyNCBG ZWIgMjAyMSAxODozOToyMCArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIGxpYnhs OiBGaXggZG9tYWluIHNvZnQgcmVzZXQgc3RhdGUgaGFuZGxpbmcKCkluIGRv X2RvbWFpbl9zb2Z0X3Jlc2V0KCksIGEgYGxpYnhsX19kb21haW5fc3VzcGVu ZF9zdGF0ZScgaXMgdXNlZAp3aXRob3V0IGJlZW4gcHJvcGVybHkgaW5pdGlh bGlzZWQgYW5kIGRpc3Bvc2VkIG9mLiBUaGlzIGxlYWQgZG8gYQphYm9ydCgp IGluIGxpYnhsIGR1ZSB0byB0aGUgYGRzcHMucW1wJyBzdGF0ZSBiZWVuIHVz ZWQgYmVmb3JlIGJlZW4KaW5pdGlhbGlzZWQ6CiAgICBsaWJ4bF9fZXZfcW1w X3NlbmQ6IEFzc2VydGlvbiBgZXYtPnN0YXRlID09IHFtcF9zdGF0ZV9kaXNj b25uZWN0ZWQgfHwgZXYtPnN0YXRlID09IHFtcF9zdGF0ZV9jb25uZWN0ZWQn IGZhaWxlZC4KCk9uY2UgaW5pdGlhbGlzZWQsIGBkc3BzJyBhbHNvIG5lZWRz IHRvIGJlIGRpc3Bvc2VkIG9mIGFzIHRoZSBgcW1wJwpzdGF0ZSBtaWdodCBz dGlsbCBiZSBpbiB0aGUgYENvbm5lY3RlZCcgc3RhdGUgaW4gdGhlIGNhbGxi YWNrIGZvcgpsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGV2aWNlX21vZGVsKCku IFNvIHRoaXMgcGF0Y2ggYWRkcwpsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGlz cG9zZSgpIHdoaWNoIGNhbiBiZSBjYWxsZWQgZnJvbSB0aGUgdHdvCnBsYWNl cyB3aGVyZSB3ZSBuZWVkIHRvIGRpc3Bvc2Ugb2YgYGRzcHMnLgoKUmVwb3J0 ZWQtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT4KU2lnbmVkLW9m Zi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5j b20+ClJldmlld2VkLWJ5OiBJYW4gSmFja3NvbiA8aXdqQHhlbnByb2plY3Qu b3JnPgpUZXN0ZWQtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT4K LS0tCiB0b29scy9saWJ4bC9saWJ4bF9jcmVhdGUuYyAgICAgIHwgMTEgKysr KysrKystLS0KIHRvb2xzL2xpYnhsL2xpYnhsX2RvbV9zdXNwZW5kLmMgfCAx NSArKysrKysrKysrKy0tLS0KIHRvb2xzL2xpYnhsL2xpYnhsX2ludGVybmFs LmggICAgfCAgMiArKwogMyBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25z KCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhs L2xpYnhsX2NyZWF0ZS5jIGIvdG9vbHMvbGlieGwvbGlieGxfY3JlYXRlLmMK aW5kZXggMzJkNDVkY2VmMC4uNjUxYWQxOGQyZCAxMDA2NDQKLS0tIGEvdG9v bHMvbGlieGwvbGlieGxfY3JlYXRlLmMKKysrIGIvdG9vbHMvbGlieGwvbGli eGxfY3JlYXRlLmMKQEAgLTE5NzQsOSArMTk3NCw3IEBAIHN0YXRpYyBpbnQg ZG9fZG9tYWluX3NvZnRfcmVzZXQobGlieGxfY3R4ICpjdHgsCiAgICAgc3Rh dGUtPmNvbnNvbGVfdHR5ID0gbGlieGxfX3N0cmR1cChnYywgY29uc29sZV90 dHkpOwogCiAgICAgZHNzLT5hbyA9IGFvOwotICAgIGRzcy0+ZG9taWQgPSBk c3MtPmRzcHMuZG9taWQgPSBkb21pZF9zb2Z0X3Jlc2V0OwotICAgIGRzcy0+ ZHNwcy5kbV9zYXZlZmlsZSA9IEdDU1BSSU5URihMSUJYTF9ERVZJQ0VfTU9E RUxfU0FWRV9GSUxFIi4lZCIsCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGRvbWlkX3NvZnRfcmVzZXQpOworICAgIGRzcy0+ZG9t aWQgPSBkb21pZF9zb2Z0X3Jlc2V0OwogCiAgICAgcmMgPSBsaWJ4bF9fc2F2 ZV9lbXVsYXRvcl94ZW5zdG9yZV9kYXRhKGRzcywgJnNycy0+dG9vbHN0YWNr X2J1ZiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJnNycy0+dG9vbHN0YWNrX2xlbik7CkBAIC0xOTg2LDYgKzE5ODQs MTEgQEAgc3RhdGljIGludCBkb19kb21haW5fc29mdF9yZXNldChsaWJ4bF9j dHggKmN0eCwKICAgICB9CiAKICAgICBkc3MtPmRzcHMuYW8gPSBhbzsKKyAg ICBkc3MtPmRzcHMuZG9taWQgPSBkb21pZF9zb2Z0X3Jlc2V0OworICAgIGRz cy0+ZHNwcy5saXZlID0gZmFsc2U7CisgICAgcmMgPSBsaWJ4bF9fZG9tYWlu X3N1c3BlbmRfaW5pdChlZ2MsICZkc3MtPmRzcHMsIGRfY29uZmlnLT5iX2lu Zm8udHlwZSk7CisgICAgaWYgKHJjKQorICAgICAgICBnb3RvIG91dDsKICAg ICBkc3MtPmRzcHMuY2FsbGJhY2tfZGV2aWNlX21vZGVsX2RvbmUgPSBzb2Z0 X3Jlc2V0X2RtX3N1c3BlbmRlZDsKICAgICBsaWJ4bF9fZG9tYWluX3N1c3Bl bmRfZGV2aWNlX21vZGVsKGVnYywgJmRzcy0+ZHNwcyk7IC8qIG11c3QgYmUg bGFzdCAqLwogCkBAIC0yMDA0LDYgKzIwMDcsOCBAQCBzdGF0aWMgdm9pZCBz b2Z0X3Jlc2V0X2RtX3N1c3BlbmRlZChsaWJ4bF9fZWdjICplZ2MsCiAgICAg ICAgIENPTlRBSU5FUl9PRihkc3BzLCAqc3JzLCBkc3MuZHNwcyk7CiAgICAg bGlieGxfX2FwcF9kb21haW5fY3JlYXRlX3N0YXRlICpjZGNzID0gJnNycy0+ Y2RjczsKIAorICAgIGxpYnhsX19kb21haW5fc3VzcGVuZF9kaXNwb3NlKGdj LCBkc3BzKTsKKwogICAgIC8qCiAgICAgICogQXNrIGFsbCBiYWNrZW5kcyB0 byBkaXNjb25uZWN0IGJ5IHJlbW92aW5nIHRoZSBkb21haW4gZnJvbQogICAg ICAqIHhlbnN0b3JlLiBPbiB0aGUgY3JlYXRpb24gcGF0aCB0aGUgZG9tYWlu IHdpbGwgYmUgaW50cm9kdWNlZCB0bwpkaWZmIC0tZ2l0IGEvdG9vbHMvbGli eGwvbGlieGxfZG9tX3N1c3BlbmQuYyBiL3Rvb2xzL2xpYnhsL2xpYnhsX2Rv bV9zdXNwZW5kLmMKaW5kZXggMjVkMTU3MTg5NS4uMmEyODBmNjlhMSAxMDA2 NDQKLS0tIGEvdG9vbHMvbGlieGwvbGlieGxfZG9tX3N1c3BlbmQuYworKysg Yi90b29scy9saWJ4bC9saWJ4bF9kb21fc3VzcGVuZC5jCkBAIC02Nyw2ICs2 NywxNiBAQCBvdXQ6CiAgICAgcmV0dXJuIHJjOwogfQogCit2b2lkIGxpYnhs X19kb21haW5fc3VzcGVuZF9kaXNwb3NlKGxpYnhsX19nYyAqZ2MsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxpYnhsX19kb21haW5f c3VzcGVuZF9zdGF0ZSAgKmRzcHMpCit7CisgICAgbGlieGxfX3hzd2FpdF9z dG9wKGdjLCAmZHNwcy0+cHZjb250cm9sKTsKKyAgICBsaWJ4bF9fZXZfZXZ0 Y2huX2NhbmNlbChnYywgJmRzcHMtPmd1ZXN0X2V2dGNobik7CisgICAgbGli eGxfX2V2X3hzd2F0Y2hfZGVyZWdpc3RlcihnYywgJmRzcHMtPmd1ZXN0X3dh dGNoKTsKKyAgICBsaWJ4bF9fZXZfdGltZV9kZXJlZ2lzdGVyKGdjLCAmZHNw cy0+Z3Vlc3RfdGltZW91dCk7CisgICAgbGlieGxfX2V2X3FtcF9kaXNwb3Nl KGdjLCAmZHNwcy0+cW1wKTsKK30KKwogLyotLS0tLSBjYWxsYmFja3MsIGNh bGxlZCBieSB4Y19kb21haW5fc2F2ZSAtLS0tLSovCiAKIHZvaWQgbGlieGxf X2RvbWFpbl9zdXNwZW5kX2RldmljZV9tb2RlbChsaWJ4bF9fZWdjICplZ2Ms CkBAIC0zODgsMTAgKzM5OCw3IEBAIHN0YXRpYyB2b2lkIGRvbWFpbl9zdXNw ZW5kX2NvbW1vbl9kb25lKGxpYnhsX19lZ2MgKmVnYywKIHsKICAgICBFR0Nf R0M7CiAgICAgYXNzZXJ0KCFsaWJ4bF9feHN3YWl0X2ludXNlKCZkc3BzLT5w dmNvbnRyb2wpKTsKLSAgICBsaWJ4bF9fZXZfZXZ0Y2huX2NhbmNlbChnYywg JmRzcHMtPmd1ZXN0X2V2dGNobik7Ci0gICAgbGlieGxfX2V2X3hzd2F0Y2hf ZGVyZWdpc3RlcihnYywgJmRzcHMtPmd1ZXN0X3dhdGNoKTsKLSAgICBsaWJ4 bF9fZXZfdGltZV9kZXJlZ2lzdGVyKGdjLCAmZHNwcy0+Z3Vlc3RfdGltZW91 dCk7Ci0gICAgbGlieGxfX2V2X3FtcF9kaXNwb3NlKGdjLCAmZHNwcy0+cW1w KTsKKyAgICBsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGlzcG9zZShnYywgZHNw cyk7CiAgICAgZHNwcy0+Y2FsbGJhY2tfY29tbW9uX2RvbmUoZWdjLCBkc3Bz LCByYyk7CiB9CiAKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX2lu dGVybmFsLmggYi90b29scy9saWJ4bC9saWJ4bF9pbnRlcm5hbC5oCmluZGV4 IDI0NzUxOGE3YWMuLjViNDc5NTkwOGIgMTAwNjQ0Ci0tLSBhL3Rvb2xzL2xp YnhsL2xpYnhsX2ludGVybmFsLmgKKysrIGIvdG9vbHMvbGlieGwvbGlieGxf aW50ZXJuYWwuaApAQCAtMzU2OSw2ICszNTY5LDggQEAgc3RydWN0IGxpYnhs X19kb21haW5fc3VzcGVuZF9zdGF0ZSB7CiBpbnQgbGlieGxfX2RvbWFpbl9z dXNwZW5kX2luaXQobGlieGxfX2VnYyAqZWdjLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGxpYnhsX19kb21haW5fc3VzcGVuZF9zdGF0ZSAq ZHNwcywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9k b21haW5fdHlwZSB0eXBlKTsKK3ZvaWQgbGlieGxfX2RvbWFpbl9zdXNwZW5k X2Rpc3Bvc2UobGlieGxfX2djICpnYywKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgbGlieGxfX2RvbWFpbl9zdXNwZW5kX3N0YXRlICAq ZHNwcyk7CiAKIC8qIGNhbGxzIGRzcHMtPmNhbGxiYWNrX2RldmljZV9tb2Rl bF9kb25lIHdoZW4gZG9uZQogICogbWF5IHN5bmNocm9ub3VzbHkgY2FsbHMg dGhpcyBjYWxsYmFjayAqLwotLSAKMi4zMC4xCgo= --=separator Content-Type: application/octet-stream; name="xsa368-4.14.patch" Content-Disposition: attachment; filename="xsa368-4.14.patch" Content-Transfer-Encoding: base64 RnJvbSBiMWQ1ZTAzM2RmMTg1OGVkZDZmYTMyOGFiZDEyNjUyMjk0NzQ0MGFh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRob255IFBFUkFS RCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KRGF0ZTogV2VkLCAyNCBG ZWIgMjAyMSAxODozOToyMCArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIGxpYnhs OiBGaXggZG9tYWluIHNvZnQgcmVzZXQgc3RhdGUgaGFuZGxpbmcKCkluIGRv X2RvbWFpbl9zb2Z0X3Jlc2V0KCksIGEgYGxpYnhsX19kb21haW5fc3VzcGVu ZF9zdGF0ZScgaXMgdXNlZAp3aXRob3V0IGJlZW4gcHJvcGVybHkgaW5pdGlh bGlzZWQgYW5kIGRpc3Bvc2VkIG9mLiBUaGlzIGxlYWQgZG8gYQphYm9ydCgp IGluIGxpYnhsIGR1ZSB0byB0aGUgYGRzcHMucW1wJyBzdGF0ZSBiZWVuIHVz ZWQgYmVmb3JlIGJlZW4KaW5pdGlhbGlzZWQ6CiAgICBsaWJ4bF9fZXZfcW1w X3NlbmQ6IEFzc2VydGlvbiBgZXYtPnN0YXRlID09IHFtcF9zdGF0ZV9kaXNj b25uZWN0ZWQgfHwgZXYtPnN0YXRlID09IHFtcF9zdGF0ZV9jb25uZWN0ZWQn IGZhaWxlZC4KCk9uY2UgaW5pdGlhbGlzZWQsIGBkc3BzJyBhbHNvIG5lZWRz IHRvIGJlIGRpc3Bvc2VkIG9mIGFzIHRoZSBgcW1wJwpzdGF0ZSBtaWdodCBz dGlsbCBiZSBpbiB0aGUgYENvbm5lY3RlZCcgc3RhdGUgaW4gdGhlIGNhbGxi YWNrIGZvcgpsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGV2aWNlX21vZGVsKCku IFNvIHRoaXMgcGF0Y2ggYWRkcwpsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGlz cG9zZSgpIHdoaWNoIGNhbiBiZSBjYWxsZWQgZnJvbSB0aGUgdHdvCnBsYWNl cyB3aGVyZSB3ZSBuZWVkIHRvIGRpc3Bvc2Ugb2YgYGRzcHMnLgoKUmVwb3J0 ZWQtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT4KU2lnbmVkLW9m Zi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5j b20+ClJldmlld2VkLWJ5OiBJYW4gSmFja3NvbiA8aXdqQHhlbnByb2plY3Qu b3JnPgpUZXN0ZWQtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT4K LS0tCiB0b29scy9saWJ4bC9saWJ4bF9jcmVhdGUuYyAgICAgIHwgMTEgKysr KysrKystLS0KIHRvb2xzL2xpYnhsL2xpYnhsX2RvbV9zdXNwZW5kLmMgfCAx NSArKysrKysrKysrKy0tLS0KIHRvb2xzL2xpYnhsL2xpYnhsX2ludGVybmFs LmggICAgfCAgMiArKwogMyBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25z KCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhs L2xpYnhsX2NyZWF0ZS5jIGIvdG9vbHMvbGlieGwvbGlieGxfY3JlYXRlLmMK aW5kZXggMjgxNDgxOGUzNC4uODNiMGViMDBiZiAxMDA2NDQKLS0tIGEvdG9v bHMvbGlieGwvbGlieGxfY3JlYXRlLmMKKysrIGIvdG9vbHMvbGlieGwvbGli eGxfY3JlYXRlLmMKQEAgLTIxNzQsOSArMjE3NCw3IEBAIHN0YXRpYyBpbnQg ZG9fZG9tYWluX3NvZnRfcmVzZXQobGlieGxfY3R4ICpjdHgsCiAgICAgc3Rh dGUtPmNvbnNvbGVfdHR5ID0gbGlieGxfX3N0cmR1cChnYywgY29uc29sZV90 dHkpOwogCiAgICAgZHNzLT5hbyA9IGFvOwotICAgIGRzcy0+ZG9taWQgPSBk c3MtPmRzcHMuZG9taWQgPSBkb21pZDsKLSAgICBkc3MtPmRzcHMuZG1fc2F2 ZWZpbGUgPSBHQ1NQUklOVEYoTElCWExfREVWSUNFX01PREVMX1NBVkVfRklM RSIuJWQiLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBkb21pZCk7CisgICAgZHNzLT5kb21pZCA9IGRvbWlkOwogCiAgICAgcmMg PSBsaWJ4bF9fc2F2ZV9lbXVsYXRvcl94ZW5zdG9yZV9kYXRhKGRzcywgJnNy cy0+dG9vbHN0YWNrX2J1ZiwKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJnNycy0+dG9vbHN0YWNrX2xlbik7CkBAIC0y MTg2LDYgKzIxODQsMTEgQEAgc3RhdGljIGludCBkb19kb21haW5fc29mdF9y ZXNldChsaWJ4bF9jdHggKmN0eCwKICAgICB9CiAKICAgICBkc3MtPmRzcHMu YW8gPSBhbzsKKyAgICBkc3MtPmRzcHMuZG9taWQgPSBkb21pZDsKKyAgICBk c3MtPmRzcHMubGl2ZSA9IGZhbHNlOworICAgIHJjID0gbGlieGxfX2RvbWFp bl9zdXNwZW5kX2luaXQoZWdjLCAmZHNzLT5kc3BzLCBkX2NvbmZpZy0+Yl9p bmZvLnR5cGUpOworICAgIGlmIChyYykKKyAgICAgICAgZ290byBvdXQ7CiAg ICAgZHNzLT5kc3BzLmNhbGxiYWNrX2RldmljZV9tb2RlbF9kb25lID0gc29m dF9yZXNldF9kbV9zdXNwZW5kZWQ7CiAgICAgbGlieGxfX2RvbWFpbl9zdXNw ZW5kX2RldmljZV9tb2RlbChlZ2MsICZkc3MtPmRzcHMpOyAvKiBtdXN0IGJl IGxhc3QgKi8KIApAQCAtMjIwNCw2ICsyMjA3LDggQEAgc3RhdGljIHZvaWQg c29mdF9yZXNldF9kbV9zdXNwZW5kZWQobGlieGxfX2VnYyAqZWdjLAogICAg ICAgICBDT05UQUlORVJfT0YoZHNwcywgKnNycywgZHNzLmRzcHMpOwogICAg IGxpYnhsX19hcHBfZG9tYWluX2NyZWF0ZV9zdGF0ZSAqY2RjcyA9ICZzcnMt PmNkY3M7CiAKKyAgICBsaWJ4bF9fZG9tYWluX3N1c3BlbmRfZGlzcG9zZShn YywgZHNwcyk7CisKICAgICAvKgogICAgICAqIEFzayBhbGwgYmFja2VuZHMg dG8gZGlzY29ubmVjdCBieSByZW1vdmluZyB0aGUgZG9tYWluIGZyb20KICAg ICAgKiB4ZW5zdG9yZS4gT24gdGhlIGNyZWF0aW9uIHBhdGggdGhlIGRvbWFp biB3aWxsIGJlIGludHJvZHVjZWQgdG8KZGlmZiAtLWdpdCBhL3Rvb2xzL2xp YnhsL2xpYnhsX2RvbV9zdXNwZW5kLmMgYi90b29scy9saWJ4bC9saWJ4bF9k b21fc3VzcGVuZC5jCmluZGV4IDI1ZDE1NzE4OTUuLjJhMjgwZjY5YTEgMTAw NjQ0Ci0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsX2RvbV9zdXNwZW5kLmMKKysr IGIvdG9vbHMvbGlieGwvbGlieGxfZG9tX3N1c3BlbmQuYwpAQCAtNjcsNiAr NjcsMTYgQEAgb3V0OgogICAgIHJldHVybiByYzsKIH0KIAordm9pZCBsaWJ4 bF9fZG9tYWluX3N1c3BlbmRfZGlzcG9zZShsaWJ4bF9fZ2MgKmdjLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9fZG9tYWlu X3N1c3BlbmRfc3RhdGUgICpkc3BzKQoreworICAgIGxpYnhsX194c3dhaXRf c3RvcChnYywgJmRzcHMtPnB2Y29udHJvbCk7CisgICAgbGlieGxfX2V2X2V2 dGNobl9jYW5jZWwoZ2MsICZkc3BzLT5ndWVzdF9ldnRjaG4pOworICAgIGxp YnhsX19ldl94c3dhdGNoX2RlcmVnaXN0ZXIoZ2MsICZkc3BzLT5ndWVzdF93 YXRjaCk7CisgICAgbGlieGxfX2V2X3RpbWVfZGVyZWdpc3RlcihnYywgJmRz cHMtPmd1ZXN0X3RpbWVvdXQpOworICAgIGxpYnhsX19ldl9xbXBfZGlzcG9z ZShnYywgJmRzcHMtPnFtcCk7Cit9CisKIC8qLS0tLS0gY2FsbGJhY2tzLCBj YWxsZWQgYnkgeGNfZG9tYWluX3NhdmUgLS0tLS0qLwogCiB2b2lkIGxpYnhs X19kb21haW5fc3VzcGVuZF9kZXZpY2VfbW9kZWwobGlieGxfX2VnYyAqZWdj LApAQCAtMzg4LDEwICszOTgsNyBAQCBzdGF0aWMgdm9pZCBkb21haW5fc3Vz cGVuZF9jb21tb25fZG9uZShsaWJ4bF9fZWdjICplZ2MsCiB7CiAgICAgRUdD X0dDOwogICAgIGFzc2VydCghbGlieGxfX3hzd2FpdF9pbnVzZSgmZHNwcy0+ cHZjb250cm9sKSk7Ci0gICAgbGlieGxfX2V2X2V2dGNobl9jYW5jZWwoZ2Ms ICZkc3BzLT5ndWVzdF9ldnRjaG4pOwotICAgIGxpYnhsX19ldl94c3dhdGNo X2RlcmVnaXN0ZXIoZ2MsICZkc3BzLT5ndWVzdF93YXRjaCk7Ci0gICAgbGli eGxfX2V2X3RpbWVfZGVyZWdpc3RlcihnYywgJmRzcHMtPmd1ZXN0X3RpbWVv dXQpOwotICAgIGxpYnhsX19ldl9xbXBfZGlzcG9zZShnYywgJmRzcHMtPnFt cCk7CisgICAgbGlieGxfX2RvbWFpbl9zdXNwZW5kX2Rpc3Bvc2UoZ2MsIGRz cHMpOwogICAgIGRzcHMtPmNhbGxiYWNrX2NvbW1vbl9kb25lKGVnYywgZHNw cywgcmMpOwogfQogCmRpZmYgLS1naXQgYS90b29scy9saWJ4bC9saWJ4bF9p bnRlcm5hbC5oIGIvdG9vbHMvbGlieGwvbGlieGxfaW50ZXJuYWwuaAppbmRl eCA5NGEyMzE3OWQzLi4zYmMzYmJjZjg0IDEwMDY0NAotLS0gYS90b29scy9s aWJ4bC9saWJ4bF9pbnRlcm5hbC5oCisrKyBiL3Rvb2xzL2xpYnhsL2xpYnhs X2ludGVybmFsLmgKQEAgLTM2MTUsNiArMzYxNSw4IEBAIHN0cnVjdCBsaWJ4 bF9fZG9tYWluX3N1c3BlbmRfc3RhdGUgewogaW50IGxpYnhsX19kb21haW5f c3VzcGVuZF9pbml0KGxpYnhsX19lZ2MgKmVnYywKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBsaWJ4bF9fZG9tYWluX3N1c3BlbmRfc3RhdGUg KmRzcHMsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxf ZG9tYWluX3R5cGUgdHlwZSk7Cit2b2lkIGxpYnhsX19kb21haW5fc3VzcGVu ZF9kaXNwb3NlKGxpYnhsX19nYyAqZ2MsCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGxpYnhsX19kb21haW5fc3VzcGVuZF9zdGF0ZSAg KmRzcHMpOwogCiAvKiBjYWxscyBkc3BzLT5jYWxsYmFja19kZXZpY2VfbW9k ZWxfZG9uZSB3aGVuIGRvbmUKICAqIG1heSBzeW5jaHJvbm91c2x5IGNhbGxz IHRoaXMgY2FsbGJhY2sgKi8KLS0gCjIuMzAuMQoK --=separator-- From xen-devel-bounces@lists.xenproject.org Thu Mar 18 15:00:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 15:00:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99034.188095 (Exim 4.92) (envelope-from ) id 1lMu7a-0002Rq-Mz; Thu, 18 Mar 2021 14:59:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99034.188095; Thu, 18 Mar 2021 14:59:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMu7a-0002Rj-JN; Thu, 18 Mar 2021 14:59:34 +0000 Received: by outflank-mailman (input) for mailman id 99034; Thu, 18 Mar 2021 14:59:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMu7Z-0002Rb-J9; Thu, 18 Mar 2021 14:59:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMu7Z-0002Mr-DS; Thu, 18 Mar 2021 14:59:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMu7Z-0004br-5n; Thu, 18 Mar 2021 14:59:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMu7Z-0003Hm-56; Thu, 18 Mar 2021 14:59:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zDHqKSFqhyJH+jlbnQL4MT7/0cpjbIpvvzVIqBD3w+k=; b=JyhvFrOwEFkzDF7a36kssjsbCt Ftsk5Zcv1GCBLemiXdgR1v9eR7yoIHhzVNtzZtaMOjGDeuhj3y7NCN7B9hITtychYoI0QTBRMOnty ox7C/6P/cpbkvrkR0mH3AkTMNyb1fv162sUgEYp8LnyMdbhE6YCLl5yE+ViGJYQDdr44=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160123: all pass - PUSHED X-Osstest-Versions-This: ovmf=9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 X-Osstest-Versions-That: ovmf=030ba3097a6e7d08b99f8a9d19a322f61409c1f6 From: osstest service owner Date: Thu, 18 Mar 2021 14:59:33 +0000 flight 160123 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160123/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 baseline version: ovmf 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 Last test of basis 160117 2021-03-17 20:41:58 Z 0 days Testing same since 160123 2021-03-18 04:45:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiaxin Wu Mars CC Lin Pierre Gondois Ray Ni jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 030ba3097a..9fd7e88c23 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Mar 18 15:33:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 15:33:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99042.188110 (Exim 4.92) (envelope-from ) id 1lMueR-00061u-Io; Thu, 18 Mar 2021 15:33:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99042.188110; Thu, 18 Mar 2021 15:33:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMueR-00061n-Fp; Thu, 18 Mar 2021 15:33:31 +0000 Received: by outflank-mailman (input) for mailman id 99042; Thu, 18 Mar 2021 15:33:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMueP-00061i-Et for xen-devel@lists.xen.org; Thu, 18 Mar 2021 15:33:29 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 653412d4-31d9-4555-816c-12e24945a30b; Thu, 18 Mar 2021 15:33:28 +0000 (UTC) Received: from [10.10.1.24] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1616081591390133.4538303262699; Thu, 18 Mar 2021 08:33:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 653412d4-31d9-4555-816c-12e24945a30b ARC-Seal: i=1; a=rsa-sha256; t=1616081596; cv=none; d=zohomail.com; s=zohoarc; b=lHqhF+8TXg92tG6VYPqEUIdiRPFJ6o4XCFfGa8ekIEMiqeSAJh6fBEbUN2xfafb6la5IHlamKMtur7LtWVhPdCgVfbIi0GY4b813P7A2SCnjHDTtyS1VBD9t5z+SVn9D8k5vbb14S1WvoGw2UJfIHu7v6FnobGu8o24QkJ+V2/c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616081596; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=JSTC0KlpqwRZ1Y9KG7KnEJ+ZMXT8qVqzatoEKhnUWOk=; b=jMzakG7h+OEHWahYufdBb+gTX/tRNtEKMyGIOB4NZhBZcl2zgTeJr+xZsQg6IYwFPAfihRrfS6y6n7vT9/4/efKNNqUdl0emyM9tR5q31UUN25OCyaqe9kv6ihHj4LARc1flla5c57SfTWU5pZjJD8Vt42QfHao/bgkE4vHbcis= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1616081596; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Subject:From:To:Cc:References:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=JSTC0KlpqwRZ1Y9KG7KnEJ+ZMXT8qVqzatoEKhnUWOk=; b=qM95uCTC2F2WMlcpKyq4yQG4kn6x89M0E+f1r0bEX6Z7xzJetiQIl+BBbNMH3bs3 4quR9fIJwz6s7/x5xbmmrmhj416D0GJ5eQGDV6SFZr5zHGr3PjQJ/vL9nC42j9duWVp vtj8eji4zgzJHP8f4vhZ8QO9/IJTtsNdYv3DjIEE= Subject: Re: Working Group Meeting for hyperlaunch From: "Daniel P. Smith" To: Xen-devel Cc: christopher.w.clark@gmail.com, stefano.stabellini@xilinx.com, jgrall@amazon.com, iwj@xenproject.org, wl@xen.org, george.dunlap@citrix.com, jbeulich@suse.com, persaur@gmail.com, bertrand.marquis@arm.com, roger.pau@citrix.com, luca.fancellu@arm.com, adam.schwalm@starlab.io, Andrew Cooper , paul@xen.org References: <2e7213c1-e01c-9d9d-3ac1-3086eb6889e5@apertussolutions.com> Message-ID: Date: Thu, 18 Mar 2021 11:33:08 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <2e7213c1-e01c-9d9d-3ac1-3086eb6889e5@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 3/16/21 12:09 AM, Daniel P. Smith wrote: > All, > > We have posted[1][2] the design documents for hyperlaunch and would > invite attendance at a working group call to discuss two agenda items. > The first item is a review of the documents and the second is a > discussion about bringing production-ready revisions of our previous > prototype in as patches to provide a near-term implementation of the > design. If possible please join us this Thursday 3/18 at > 1700CET/1600GMT/1200EDT/0900PDT. Below are the call details. > > [1] > https://lists.xenproject.org/archives/html/xen-devel/2021-03/msg00939.html > [2] > https://lists.xenproject.org/archives/html/xen-devel/2021-03/pdfCV4LaWCrTN.pdf Agenda link, https://cryptpad.fr/pad/#/2/pad/edit/+MJgJ0EkalH81-YVOlsp1bEo/ > Call Details: > > Daniel Smith's Meeting > > > Please join my meeting from your computer, tablet or smartphone. > > https://www.gotomeet.me/apertussolutions > > You can also dial in using your phone. > (For supported devices, tap a one-touch number below to join instantly.) > > United States (Toll Free): 1 877 568 4106 > - One-touch: tel:+18775684106,,691818141# > > Access Code: 691-818-141 > From xen-devel-bounces@lists.xenproject.org Thu Mar 18 16:17:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 16:17:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99045.188122 (Exim 4.92) (envelope-from ) id 1lMvKZ-0001tQ-T0; Thu, 18 Mar 2021 16:17:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99045.188122; Thu, 18 Mar 2021 16:17:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvKZ-0001tJ-Q1; Thu, 18 Mar 2021 16:17:03 +0000 Received: by outflank-mailman (input) for mailman id 99045; Thu, 18 Mar 2021 16:17:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvKX-0001tE-Mg for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 16:17:02 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2c0d6296-b286-44c9-82a3-025209e06be1; Thu, 18 Mar 2021 16:16:58 +0000 (UTC) Received: from 089144199244.atnat0008.highway.a1.net ([89.144.199.244] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lMvK6-003Cyb-Sl; Thu, 18 Mar 2021 16:16:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c0d6296-b286-44c9-82a3-025209e06be1 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=rjzqCoXPd0DSY0h2TMvxPFkgf9ifPYkw6FECGpmC4c0=; b=qrHiJp69lC0mUjzOZxkbiQY1vH RjF7mCLDZQnhGmlcLuA8E6EF5g9h6D4/rJfvTDeJHWwXFvMxkh8pUqaX8FJBORDFGleNpyhLUeZqQ SR5E3LOLO9UYhbb6RVnJERw+qKRkfMQNTVXPnuPwMl5xO64fuRpLV64sQi6gmft2ANo8rZSNeH8nD 4zXDTLBX3+xKb34YQR9bPptQ4GcmSQXeHmuwcyO6saX63tq0moDxzj9fhvGF/w/4/5t5rq9XCQy1a nQJ66+9c8lGKHcw2CSM56PQynNopNaM20O/Q2h8fhxcqYfEbbvaJeQUICVMs623BlBpww+YoUlPR0 k5yjh5jg==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: swiotlb cleanups v3 Date: Thu, 18 Mar 2021 17:14:21 +0100 Message-Id: <20210318161424.489045-1-hch@lst.de> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Hi Konrad, this series contains a bunch of swiotlb cleanups, mostly to reduce the amount of internals exposed to code outside of swiotlb.c, which should helper to prepare for supporting multiple different bounce buffer pools. Changes since v2: - fix a bisetion hazard that did not allocate the alloc_size array - dropped all patches already merged Changes since v1: - rebased to v5.12-rc1 - a few more cleanups - merge and forward port the patch from Claire to move all the global variables into a struct to prepare for multiple instances From xen-devel-bounces@lists.xenproject.org Thu Mar 18 16:18:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 16:18:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99048.188134 (Exim 4.92) (envelope-from ) id 1lMvM1-000257-7s; Thu, 18 Mar 2021 16:18:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99048.188134; Thu, 18 Mar 2021 16:18:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvM1-000250-4q; Thu, 18 Mar 2021 16:18:33 +0000 Received: by outflank-mailman (input) for mailman id 99048; Thu, 18 Mar 2021 16:18:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvM0-00024s-8e; Thu, 18 Mar 2021 16:18:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvLz-0004GI-VW; Thu, 18 Mar 2021 16:18:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvLz-0007jV-Lh; Thu, 18 Mar 2021 16:18:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMvLz-00039f-LD; Thu, 18 Mar 2021 16:18:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/7UPMFv9/R2HHA8L1PxCTDsHEdIVjfexc8v+QhaUx6A=; b=ZTSwMEu7X38vKheJk+h9CNiV+G YNjDBaiY6ereJz8Ykh1Cd+Vntovxd2T1bL63ByUL1X4YscmygFa9KyOl4m/0v3dSilomnrK2//pWD KormmYYe2CincmWjjg7km9IDgJn1OZ3l5GGgWEx1d9kIUnfM606TJBYPDwe9uciwGy7I=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160120: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=21657ad4f01a634beac570c64c0691e51b9cf366 X-Osstest-Versions-That: xen=21657ad4f01a634beac570c64c0691e51b9cf366 From: osstest service owner Date: Thu, 18 Mar 2021 16:18:31 +0000 flight 160120 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160120/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-examine 4 memdisk-try-append fail in 160109 pass in 160120 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160109 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160109 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160109 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160109 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160109 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160109 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160109 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160109 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160109 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160109 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160109 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160109 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 21657ad4f01a634beac570c64c0691e51b9cf366 baseline version: xen 21657ad4f01a634beac570c64c0691e51b9cf366 Last test of basis 160120 2021-03-18 01:52:30 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Mar 18 16:19:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 16:19:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99052.188149 (Exim 4.92) (envelope-from ) id 1lMvNM-0002DE-L1; Thu, 18 Mar 2021 16:19:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99052.188149; Thu, 18 Mar 2021 16:19:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvNM-0002D7-Hf; Thu, 18 Mar 2021 16:19:56 +0000 Received: by outflank-mailman (input) for mailman id 99052; Thu, 18 Mar 2021 16:19:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvNK-0002Cy-Jq for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 16:19:54 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a9fb07d9-1eb5-47a0-adcc-f86183f0ee07; Thu, 18 Mar 2021 16:19:52 +0000 (UTC) Received: from 089144199244.atnat0008.highway.a1.net ([89.144.199.244] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lMvMO-003D4Z-67; Thu, 18 Mar 2021 16:19:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9fb07d9-1eb5-47a0-adcc-f86183f0ee07 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=78JqL12hfilwgAUTgwpwqVmLjHyse+0bkKJPFXykxPo=; b=GoBGYY+YPdHwqcDgr7fucfOAYk uZm68MCY5NLWQaitSXvwfJ1ehNCzVac87ksi+xjnpTzXVOBOCX9L8pbKtqe+mhIQclEVbr1lkbhs6 SEHgVkJLJvW7bAtrEJwa6ax7GmMkvc2dgEYuXYYgd71HSS3/H5tmJEwRgimEVReLtzjEsIX/KCppf f2txbgmpkdqKdJnPEQ8+Iyd3BwCanjZeADGxEifOWTz1l/UBSKYWuFkXyLnk8N3N/MFyTUDMLSHmi 4hNhW7NWpnw/DXHSTdUG/Pkw5ygO4hJFMxR1jy2f2exXvw7AeMLgHP/AUvIQjj0uOjqOOVl3vbBsl coELaO7w==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 1/3] swiotlb: move global variables into a new io_tlb_mem structure Date: Thu, 18 Mar 2021 17:14:22 +0100 Message-Id: <20210318161424.489045-2-hch@lst.de> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210318161424.489045-1-hch@lst.de> References: <20210318161424.489045-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html From: Claire Chang Added a new struct, io_tlb_mem, as the IO TLB memory pool descriptor and moved relevant global variables into that struct. This will be useful later to allow for restricted DMA pool. Signed-off-by: Claire Chang [hch: rebased] Signed-off-by: Christoph Hellwig --- drivers/xen/swiotlb-xen.c | 2 +- include/linux/swiotlb.h | 43 ++++- kernel/dma/swiotlb.c | 354 ++++++++++++++++++-------------------- 3 files changed, 206 insertions(+), 193 deletions(-) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 4ecfce2c6f7263..5329ad54a5f34e 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -548,7 +548,7 @@ xen_swiotlb_sync_sg_for_device(struct device *dev, struct scatterlist *sgl, static int xen_swiotlb_dma_supported(struct device *hwdev, u64 mask) { - return xen_phys_to_dma(hwdev, io_tlb_end - 1) <= mask; + return xen_phys_to_dma(hwdev, io_tlb_default_mem.end - 1) <= mask; } const struct dma_map_ops xen_swiotlb_dma_ops = { diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 0696bdc8072e97..5ec5378b17c333 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -6,6 +6,7 @@ #include #include #include +#include struct device; struct page; @@ -61,11 +62,49 @@ dma_addr_t swiotlb_map(struct device *dev, phys_addr_t phys, #ifdef CONFIG_SWIOTLB extern enum swiotlb_force swiotlb_force; -extern phys_addr_t io_tlb_start, io_tlb_end; + +/** + * struct io_tlb_mem - IO TLB Memory Pool Descriptor + * + * @start: The start address of the swiotlb memory pool. Used to do a quick + * range check to see if the memory was in fact allocated by this + * API. + * @end: The end address of the swiotlb memory pool. Used to do a quick + * range check to see if the memory was in fact allocated by this + * API. + * @nslabs: The number of IO TLB blocks (in groups of 64) between @start and + * @end. This is command line adjustable via setup_io_tlb_npages. + * @used: The number of used IO TLB block. + * @list: The free list describing the number of free entries available + * from each index. + * @index: The index to start searching in the next round. + * @orig_addr: The original address corresponding to a mapped entry. + * @alloc_size: Size of the allocated buffer. + * @lock: The lock to protect the above data structures in the map and + * unmap calls. + * @debugfs: The dentry to debugfs. + * @late_alloc: %true if allocated using the page allocator + */ +struct io_tlb_mem { + phys_addr_t start; + phys_addr_t end; + unsigned long nslabs; + unsigned long used; + unsigned int *list; + unsigned int index; + phys_addr_t *orig_addr; + size_t *alloc_size; + spinlock_t lock; + struct dentry *debugfs; + bool late_alloc; +}; +extern struct io_tlb_mem io_tlb_default_mem; static inline bool is_swiotlb_buffer(phys_addr_t paddr) { - return paddr >= io_tlb_start && paddr < io_tlb_end; + struct io_tlb_mem *mem = &io_tlb_default_mem; + + return paddr >= mem->start && paddr < mem->end; } void __init swiotlb_exit(void); diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 35e24f0ff8b207..d9c097f0f78cec 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -59,32 +59,11 @@ */ #define IO_TLB_MIN_SLABS ((1<<20) >> IO_TLB_SHIFT) -enum swiotlb_force swiotlb_force; - -/* - * Used to do a quick range check in swiotlb_tbl_unmap_single and - * swiotlb_tbl_sync_single_*, to see if the memory was in fact allocated by this - * API. - */ -phys_addr_t io_tlb_start, io_tlb_end; - -/* - * The number of IO TLB blocks (in groups of 64) between io_tlb_start and - * io_tlb_end. This is command line adjustable via setup_io_tlb_npages. - */ -static unsigned long io_tlb_nslabs; +#define INVALID_PHYS_ADDR (~(phys_addr_t)0) -/* - * The number of used IO TLB block - */ -static unsigned long io_tlb_used; +enum swiotlb_force swiotlb_force; -/* - * This is a free list describing the number of free entries available from - * each index - */ -static unsigned int *io_tlb_list; -static unsigned int io_tlb_index; +struct io_tlb_mem io_tlb_default_mem; /* * Max segment that we can provide which (if pages are contingous) will @@ -92,32 +71,15 @@ static unsigned int io_tlb_index; */ static unsigned int max_segment; -/* - * We need to save away the original address corresponding to a mapped entry - * for the sync operations. - */ -#define INVALID_PHYS_ADDR (~(phys_addr_t)0) -static phys_addr_t *io_tlb_orig_addr; - -/* - * The mapped buffer's size should be validated during a sync operation. - */ -static size_t *io_tlb_alloc_size; - -/* - * Protect the above data structures in the map and unmap calls - */ -static DEFINE_SPINLOCK(io_tlb_lock); - -static int late_alloc; - static int __init setup_io_tlb_npages(char *str) { + struct io_tlb_mem *mem = &io_tlb_default_mem; + if (isdigit(*str)) { - io_tlb_nslabs = simple_strtoul(str, &str, 0); + mem->nslabs = simple_strtoul(str, &str, 0); /* avoid tail segment of size < IO_TLB_SEGSIZE */ - io_tlb_nslabs = ALIGN(io_tlb_nslabs, IO_TLB_SEGSIZE); + mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); } if (*str == ',') ++str; @@ -125,7 +87,7 @@ setup_io_tlb_npages(char *str) swiotlb_force = SWIOTLB_FORCE; } else if (!strcmp(str, "noforce")) { swiotlb_force = SWIOTLB_NO_FORCE; - io_tlb_nslabs = 1; + mem->nslabs = 1; } return 0; @@ -136,7 +98,7 @@ static bool no_iotlb_memory; unsigned long swiotlb_nr_tbl(void) { - return unlikely(no_iotlb_memory) ? 0 : io_tlb_nslabs; + return unlikely(no_iotlb_memory) ? 0 : io_tlb_default_mem.nslabs; } EXPORT_SYMBOL_GPL(swiotlb_nr_tbl); @@ -158,13 +120,14 @@ unsigned long swiotlb_size_or_default(void) { unsigned long size; - size = io_tlb_nslabs << IO_TLB_SHIFT; + size = io_tlb_default_mem.nslabs << IO_TLB_SHIFT; return size ? size : (IO_TLB_DEFAULT_SIZE); } void __init swiotlb_adjust_size(unsigned long new_size) { + struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned long size; /* @@ -172,10 +135,10 @@ void __init swiotlb_adjust_size(unsigned long new_size) * architectures such as those supporting memory encryption to * adjust/expand SWIOTLB size for their use. */ - if (!io_tlb_nslabs) { + if (!mem->nslabs) { size = ALIGN(new_size, IO_TLB_SIZE); - io_tlb_nslabs = size >> IO_TLB_SHIFT; - io_tlb_nslabs = ALIGN(io_tlb_nslabs, IO_TLB_SEGSIZE); + mem->nslabs = size >> IO_TLB_SHIFT; + mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); pr_info("SWIOTLB bounce buffer size adjusted to %luMB", size >> 20); } @@ -183,14 +146,15 @@ void __init swiotlb_adjust_size(unsigned long new_size) void swiotlb_print_info(void) { - unsigned long bytes = io_tlb_nslabs << IO_TLB_SHIFT; + struct io_tlb_mem *mem = &io_tlb_default_mem; + unsigned long bytes = mem->nslabs << IO_TLB_SHIFT; if (no_iotlb_memory) { pr_warn("No low mem\n"); return; } - pr_info("mapped [mem %pa-%pa] (%luMB)\n", &io_tlb_start, &io_tlb_end, + pr_info("mapped [mem %pa-%pa] (%luMB)\n", &mem->start, &mem->end, bytes >> 20); } @@ -212,68 +176,71 @@ static inline unsigned long nr_slots(u64 val) */ void __init swiotlb_update_mem_attributes(void) { + struct io_tlb_mem *mem = &io_tlb_default_mem; void *vaddr; unsigned long bytes; - if (no_iotlb_memory || late_alloc) + if (no_iotlb_memory || mem->late_alloc) return; - vaddr = phys_to_virt(io_tlb_start); - bytes = PAGE_ALIGN(io_tlb_nslabs << IO_TLB_SHIFT); + vaddr = phys_to_virt(mem->start); + bytes = PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT); set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT); memset(vaddr, 0, bytes); } int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) { + struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned long i, bytes; size_t alloc_size; /* protect against double initialization */ - if (WARN_ON_ONCE(io_tlb_start)) + if (WARN_ON_ONCE(mem->start)) return -ENOMEM; bytes = nslabs << IO_TLB_SHIFT; - io_tlb_nslabs = nslabs; - io_tlb_start = __pa(tlb); - io_tlb_end = io_tlb_start + bytes; + mem->nslabs = nslabs; + mem->start = __pa(tlb); + mem->end = mem->start + bytes; + mem->index = 0; + spin_lock_init(&mem->lock); /* * Allocate and initialize the free list array. This array is used * to find contiguous free memory regions of size up to IO_TLB_SEGSIZE - * between io_tlb_start and io_tlb_end. + * between mem->start and mem->end. */ - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(int)); - io_tlb_list = memblock_alloc(alloc_size, PAGE_SIZE); - if (!io_tlb_list) + alloc_size = PAGE_ALIGN(mem->nslabs * sizeof(int)); + mem->list = memblock_alloc(alloc_size, PAGE_SIZE); + if (!mem->list) panic("%s: Failed to allocate %zu bytes align=0x%lx\n", __func__, alloc_size, PAGE_SIZE); - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(phys_addr_t)); - io_tlb_orig_addr = memblock_alloc(alloc_size, PAGE_SIZE); - if (!io_tlb_orig_addr) + alloc_size = PAGE_ALIGN(mem->nslabs * sizeof(phys_addr_t)); + mem->orig_addr = memblock_alloc(alloc_size, PAGE_SIZE); + if (!mem->orig_addr) panic("%s: Failed to allocate %zu bytes align=0x%lx\n", __func__, alloc_size, PAGE_SIZE); - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t)); - io_tlb_alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); - if (!io_tlb_alloc_size) + alloc_size = PAGE_ALIGN(mem->nslabs * sizeof(size_t)); + mem->alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); + if (mem->alloc_size) panic("%s: Failed to allocate %zu bytes align=0x%lx\n", __func__, alloc_size, PAGE_SIZE); - for (i = 0; i < io_tlb_nslabs; i++) { - io_tlb_list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); - io_tlb_orig_addr[i] = INVALID_PHYS_ADDR; - io_tlb_alloc_size[i] = 0; + for (i = 0; i < mem->nslabs; i++) { + mem->list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); + mem->orig_addr[i] = INVALID_PHYS_ADDR; + mem->alloc_size[i] = 0; } - io_tlb_index = 0; no_iotlb_memory = false; if (verbose) swiotlb_print_info(); - swiotlb_set_max_segment(io_tlb_nslabs << IO_TLB_SHIFT); + swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT); return 0; } @@ -284,26 +251,27 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) void __init swiotlb_init(int verbose) { + struct io_tlb_mem *mem = &io_tlb_default_mem; size_t default_size = IO_TLB_DEFAULT_SIZE; unsigned char *vstart; unsigned long bytes; - if (!io_tlb_nslabs) { - io_tlb_nslabs = (default_size >> IO_TLB_SHIFT); - io_tlb_nslabs = ALIGN(io_tlb_nslabs, IO_TLB_SEGSIZE); + if (!mem->nslabs) { + mem->nslabs = (default_size >> IO_TLB_SHIFT); + mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); } - bytes = io_tlb_nslabs << IO_TLB_SHIFT; + bytes = mem->nslabs << IO_TLB_SHIFT; /* Get IO TLB memory from the low pages */ vstart = memblock_alloc_low(PAGE_ALIGN(bytes), PAGE_SIZE); - if (vstart && !swiotlb_init_with_tbl(vstart, io_tlb_nslabs, verbose)) + if (vstart && !swiotlb_init_with_tbl(vstart, mem->nslabs, verbose)) return; - if (io_tlb_start) { - memblock_free_early(io_tlb_start, - PAGE_ALIGN(io_tlb_nslabs << IO_TLB_SHIFT)); - io_tlb_start = 0; + if (mem->start) { + memblock_free_early(mem->start, + PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT)); + mem->start = 0; } pr_warn("Cannot allocate buffer"); no_iotlb_memory = true; @@ -317,22 +285,23 @@ swiotlb_init(int verbose) int swiotlb_late_init_with_default_size(size_t default_size) { - unsigned long bytes, req_nslabs = io_tlb_nslabs; + struct io_tlb_mem *mem = &io_tlb_default_mem; + unsigned long bytes, req_nslabs = mem->nslabs; unsigned char *vstart = NULL; unsigned int order; int rc = 0; - if (!io_tlb_nslabs) { - io_tlb_nslabs = (default_size >> IO_TLB_SHIFT); - io_tlb_nslabs = ALIGN(io_tlb_nslabs, IO_TLB_SEGSIZE); + if (!mem->nslabs) { + mem->nslabs = (default_size >> IO_TLB_SHIFT); + mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); } /* * Get IO TLB memory from the low pages */ - order = get_order(io_tlb_nslabs << IO_TLB_SHIFT); - io_tlb_nslabs = SLABS_PER_PAGE << order; - bytes = io_tlb_nslabs << IO_TLB_SHIFT; + order = get_order(mem->nslabs << IO_TLB_SHIFT); + mem->nslabs = SLABS_PER_PAGE << order; + bytes = mem->nslabs << IO_TLB_SHIFT; while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) { vstart = (void *)__get_free_pages(GFP_DMA | __GFP_NOWARN, @@ -343,15 +312,15 @@ swiotlb_late_init_with_default_size(size_t default_size) } if (!vstart) { - io_tlb_nslabs = req_nslabs; + mem->nslabs = req_nslabs; return -ENOMEM; } if (order != get_order(bytes)) { pr_warn("only able to allocate %ld MB\n", (PAGE_SIZE << order) >> 20); - io_tlb_nslabs = SLABS_PER_PAGE << order; + mem->nslabs = SLABS_PER_PAGE << order; } - rc = swiotlb_late_init_with_tbl(vstart, io_tlb_nslabs); + rc = swiotlb_late_init_with_tbl(vstart, mem->nslabs); if (rc) free_pages((unsigned long)vstart, order); @@ -360,26 +329,32 @@ swiotlb_late_init_with_default_size(size_t default_size) static void swiotlb_cleanup(void) { - io_tlb_end = 0; - io_tlb_start = 0; - io_tlb_nslabs = 0; + struct io_tlb_mem *mem = &io_tlb_default_mem; + + mem->end = 0; + mem->start = 0; + mem->nslabs = 0; max_segment = 0; } int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) { + struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned long i, bytes; /* protect against double initialization */ - if (WARN_ON_ONCE(io_tlb_start)) + if (WARN_ON_ONCE(mem->start)) return -ENOMEM; bytes = nslabs << IO_TLB_SHIFT; - io_tlb_nslabs = nslabs; - io_tlb_start = virt_to_phys(tlb); - io_tlb_end = io_tlb_start + bytes; + mem->nslabs = nslabs; + mem->start = virt_to_phys(tlb); + mem->end = mem->start + bytes; + mem->index = 0; + mem->late_alloc = 1; + spin_lock_init(&mem->lock); set_memory_decrypted((unsigned long)tlb, bytes >> PAGE_SHIFT); memset(tlb, 0, bytes); @@ -387,52 +362,45 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) /* * Allocate and initialize the free list array. This array is used * to find contiguous free memory regions of size up to IO_TLB_SEGSIZE - * between io_tlb_start and io_tlb_end. + * between mem->start and mem->end. */ - io_tlb_list = (unsigned int *)__get_free_pages(GFP_KERNEL, - get_order(io_tlb_nslabs * sizeof(int))); - if (!io_tlb_list) + mem->list = (unsigned int *)__get_free_pages(GFP_KERNEL, + get_order(mem->nslabs * sizeof(int))); + if (!mem->list) goto cleanup3; - io_tlb_orig_addr = (phys_addr_t *) + mem->orig_addr = (phys_addr_t *) __get_free_pages(GFP_KERNEL, - get_order(io_tlb_nslabs * + get_order(mem->nslabs * sizeof(phys_addr_t))); - if (!io_tlb_orig_addr) + if (!mem->orig_addr) goto cleanup4; - io_tlb_alloc_size = (size_t *) + mem->alloc_size = (size_t *) __get_free_pages(GFP_KERNEL, - get_order(io_tlb_nslabs * + get_order(mem->nslabs * sizeof(size_t))); - if (!io_tlb_alloc_size) + if (!mem->alloc_size) goto cleanup5; - - for (i = 0; i < io_tlb_nslabs; i++) { - io_tlb_list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); - io_tlb_orig_addr[i] = INVALID_PHYS_ADDR; - io_tlb_alloc_size[i] = 0; + for (i = 0; i < mem->nslabs; i++) { + mem->list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); + mem->orig_addr[i] = INVALID_PHYS_ADDR; + mem->alloc_size[i] = 0; } - io_tlb_index = 0; no_iotlb_memory = false; swiotlb_print_info(); - - late_alloc = 1; - - swiotlb_set_max_segment(io_tlb_nslabs << IO_TLB_SHIFT); - + swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT); return 0; cleanup5: - free_pages((unsigned long)io_tlb_orig_addr, get_order(io_tlb_nslabs * - sizeof(phys_addr_t))); - + free_pages((unsigned long)mem->orig_addr, + get_order(mem->nslabs * sizeof(phys_addr_t))); cleanup4: - free_pages((unsigned long)io_tlb_list, get_order(io_tlb_nslabs * - sizeof(int))); - io_tlb_list = NULL; + free_pages((unsigned long)mem->list, + get_order(mem->nslabs * sizeof(int))); + mem->list = NULL; cleanup3: swiotlb_cleanup(); return -ENOMEM; @@ -440,27 +408,29 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) void __init swiotlb_exit(void) { - if (!io_tlb_orig_addr) + struct io_tlb_mem *mem = &io_tlb_default_mem; + + if (!mem->orig_addr) return; - if (late_alloc) { - free_pages((unsigned long)io_tlb_alloc_size, - get_order(io_tlb_nslabs * sizeof(size_t))); - free_pages((unsigned long)io_tlb_orig_addr, - get_order(io_tlb_nslabs * sizeof(phys_addr_t))); - free_pages((unsigned long)io_tlb_list, get_order(io_tlb_nslabs * - sizeof(int))); - free_pages((unsigned long)phys_to_virt(io_tlb_start), - get_order(io_tlb_nslabs << IO_TLB_SHIFT)); + if (mem->late_alloc) { + free_pages((unsigned long)mem->alloc_size, + get_order(mem->nslabs * sizeof(size_t))); + free_pages((unsigned long)mem->orig_addr, + get_order(mem->nslabs * sizeof(phys_addr_t))); + free_pages((unsigned long)mem->list, + get_order(mem->nslabs * sizeof(int))); + free_pages((unsigned long)phys_to_virt(mem->start), + get_order(mem->nslabs << IO_TLB_SHIFT)); } else { - memblock_free_late(__pa(io_tlb_orig_addr), - PAGE_ALIGN(io_tlb_nslabs * sizeof(phys_addr_t))); - memblock_free_late(__pa(io_tlb_alloc_size), - PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t))); - memblock_free_late(__pa(io_tlb_list), - PAGE_ALIGN(io_tlb_nslabs * sizeof(int))); - memblock_free_late(io_tlb_start, - PAGE_ALIGN(io_tlb_nslabs << IO_TLB_SHIFT)); + memblock_free_late(__pa(mem->alloc_size), + PAGE_ALIGN(mem->nslabs * sizeof(size_t))); + memblock_free_late(__pa(mem->orig_addr), + PAGE_ALIGN(mem->nslabs * sizeof(phys_addr_t))); + memblock_free_late(__pa(mem->list), + PAGE_ALIGN(mem->nslabs * sizeof(int))); + memblock_free_late(mem->start, + PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT)); } swiotlb_cleanup(); } @@ -471,9 +441,10 @@ void __init swiotlb_exit(void) static void swiotlb_bounce(struct device *dev, phys_addr_t tlb_addr, size_t size, enum dma_data_direction dir) { - int index = (tlb_addr - io_tlb_start) >> IO_TLB_SHIFT; - size_t alloc_size = io_tlb_alloc_size[index]; - phys_addr_t orig_addr = io_tlb_orig_addr[index]; + struct io_tlb_mem *mem = &io_tlb_default_mem; + int index = (tlb_addr - mem->start) >> IO_TLB_SHIFT; + phys_addr_t orig_addr = mem->orig_addr[index]; + size_t alloc_size = mem->alloc_size[index]; unsigned long pfn = PFN_DOWN(orig_addr); unsigned char *vaddr = phys_to_virt(tlb_addr); @@ -538,9 +509,9 @@ static inline unsigned long get_max_slots(unsigned long boundary_mask) return nr_slots(boundary_mask + 1); } -static unsigned int wrap_index(unsigned int index) +static unsigned int wrap_index(struct io_tlb_mem *mem, unsigned int index) { - if (index >= io_tlb_nslabs) + if (index >= mem->nslabs) return 0; return index; } @@ -552,9 +523,10 @@ static unsigned int wrap_index(unsigned int index) static int find_slots(struct device *dev, phys_addr_t orig_addr, size_t alloc_size) { + struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned long boundary_mask = dma_get_seg_boundary(dev); dma_addr_t tbl_dma_addr = - phys_to_dma_unencrypted(dev, io_tlb_start) & boundary_mask; + phys_to_dma_unencrypted(dev, mem->start) & boundary_mask; unsigned long max_slots = get_max_slots(boundary_mask); unsigned int iotlb_align_mask = dma_get_min_align_mask(dev) & ~(IO_TLB_SIZE - 1); @@ -573,15 +545,15 @@ static int find_slots(struct device *dev, phys_addr_t orig_addr, if (alloc_size >= PAGE_SIZE) stride = max(stride, stride << (PAGE_SHIFT - IO_TLB_SHIFT)); - spin_lock_irqsave(&io_tlb_lock, flags); - if (unlikely(nslots > io_tlb_nslabs - io_tlb_used)) + spin_lock_irqsave(&mem->lock, flags); + if (unlikely(nslots > mem->nslabs - mem->used)) goto not_found; - index = wrap = wrap_index(ALIGN(io_tlb_index, stride)); + index = wrap = wrap_index(mem, ALIGN(mem->index, stride)); do { if ((slot_addr(tbl_dma_addr, index) & iotlb_align_mask) != (orig_addr & iotlb_align_mask)) { - index = wrap_index(index + 1); + index = wrap_index(mem, index + 1); continue; } @@ -593,34 +565,34 @@ static int find_slots(struct device *dev, phys_addr_t orig_addr, if (!iommu_is_span_boundary(index, nslots, nr_slots(tbl_dma_addr), max_slots)) { - if (io_tlb_list[index] >= nslots) + if (mem->list[index] >= nslots) goto found; } - index = wrap_index(index + stride); + index = wrap_index(mem, index + stride); } while (index != wrap); not_found: - spin_unlock_irqrestore(&io_tlb_lock, flags); + spin_unlock_irqrestore(&mem->lock, flags); return -1; found: for (i = index; i < index + nslots; i++) - io_tlb_list[i] = 0; + mem->list[i] = 0; for (i = index - 1; io_tlb_offset(i) != IO_TLB_SEGSIZE - 1 && - io_tlb_list[i]; i--) - io_tlb_list[i] = ++count; + mem->list[i]; i--) + mem->list[i] = ++count; /* * Update the indices to avoid searching in the next round. */ - if (index + nslots < io_tlb_nslabs) - io_tlb_index = index + nslots; + if (index + nslots < mem->nslabs) + mem->index = index + nslots; else - io_tlb_index = 0; - io_tlb_used += nslots; + mem->index = 0; + mem->used += nslots; - spin_unlock_irqrestore(&io_tlb_lock, flags); + spin_unlock_irqrestore(&mem->lock, flags); return index; } @@ -628,6 +600,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, size_t mapping_size, size_t alloc_size, enum dma_data_direction dir, unsigned long attrs) { + struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned int offset = swiotlb_align_offset(dev, orig_addr); unsigned int index, i; phys_addr_t tlb_addr; @@ -649,7 +622,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, if (!(attrs & DMA_ATTR_NO_WARN)) dev_warn_ratelimited(dev, "swiotlb buffer is full (sz: %zd bytes), total %lu (slots), used %lu (slots)\n", - alloc_size, io_tlb_nslabs, io_tlb_used); + alloc_size, mem->nslabs, mem->used); return (phys_addr_t)DMA_MAPPING_ERROR; } @@ -659,10 +632,10 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, * needed. */ for (i = 0; i < nr_slots(alloc_size + offset); i++) { - io_tlb_orig_addr[index + i] = slot_addr(orig_addr, i); - io_tlb_alloc_size[index+i] = alloc_size - (i << IO_TLB_SHIFT); + mem->orig_addr[index + i] = slot_addr(orig_addr, i); + mem->alloc_size[index + i] = alloc_size - (i << IO_TLB_SHIFT); } - tlb_addr = slot_addr(io_tlb_start, index) + offset; + tlb_addr = slot_addr(mem->start, index) + offset; if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) && (dir == DMA_TO_DEVICE || dir == DMA_BIDIRECTIONAL)) swiotlb_bounce(dev, tlb_addr, mapping_size, DMA_TO_DEVICE); @@ -676,10 +649,11 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, size_t mapping_size, enum dma_data_direction dir, unsigned long attrs) { + struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned long flags; unsigned int offset = swiotlb_align_offset(hwdev, tlb_addr); - int index = (tlb_addr - offset - io_tlb_start) >> IO_TLB_SHIFT; - int nslots = nr_slots(io_tlb_alloc_size[index] + offset); + int index = (tlb_addr - offset - mem->start) >> IO_TLB_SHIFT; + int nslots = nr_slots(mem->alloc_size[index] + offset); int count, i; /* @@ -695,9 +669,9 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, * While returning the entries to the free list, we merge the entries * with slots below and above the pool being returned. */ - spin_lock_irqsave(&io_tlb_lock, flags); + spin_lock_irqsave(&mem->lock, flags); if (index + nslots < ALIGN(index + 1, IO_TLB_SEGSIZE)) - count = io_tlb_list[index + nslots]; + count = mem->list[index + nslots]; else count = 0; @@ -706,9 +680,9 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, * superceeding slots */ for (i = index + nslots - 1; i >= index; i--) { - io_tlb_list[i] = ++count; - io_tlb_orig_addr[i] = INVALID_PHYS_ADDR; - io_tlb_alloc_size[i] = 0; + mem->list[i] = ++count; + mem->orig_addr[i] = INVALID_PHYS_ADDR; + mem->alloc_size[i] = 0; } /* @@ -716,11 +690,11 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, * available (non zero) */ for (i = index - 1; - io_tlb_offset(i) != IO_TLB_SEGSIZE - 1 && io_tlb_list[i]; + io_tlb_offset(i) != IO_TLB_SEGSIZE - 1 && mem->list[i]; i--) - io_tlb_list[i] = ++count; - io_tlb_used -= nslots; - spin_unlock_irqrestore(&io_tlb_lock, flags); + mem->list[i] = ++count; + mem->used -= nslots; + spin_unlock_irqrestore(&mem->lock, flags); } void swiotlb_sync_single_for_device(struct device *dev, phys_addr_t tlb_addr, @@ -783,21 +757,21 @@ size_t swiotlb_max_mapping_size(struct device *dev) bool is_swiotlb_active(void) { /* - * When SWIOTLB is initialized, even if io_tlb_start points to physical - * address zero, io_tlb_end surely doesn't. + * When SWIOTLB is initialized, even if mem->start points to physical + * address zero, mem->end surely doesn't. */ - return io_tlb_end != 0; + return io_tlb_default_mem.end != 0; } #ifdef CONFIG_DEBUG_FS static int __init swiotlb_create_debugfs(void) { - struct dentry *root; + struct io_tlb_mem *mem = &io_tlb_default_mem; - root = debugfs_create_dir("swiotlb", NULL); - debugfs_create_ulong("io_tlb_nslabs", 0400, root, &io_tlb_nslabs); - debugfs_create_ulong("io_tlb_used", 0400, root, &io_tlb_used); + mem->debugfs = debugfs_create_dir("swiotlb", NULL); + debugfs_create_ulong("io_tlb_nslabs", 0400, mem->debugfs, &mem->nslabs); + debugfs_create_ulong("io_tlb_used", 0400, mem->debugfs, &mem->used); return 0; } -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Thu Mar 18 16:22:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 16:22:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99059.188161 (Exim 4.92) (envelope-from ) id 1lMvPe-00034z-7y; Thu, 18 Mar 2021 16:22:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99059.188161; Thu, 18 Mar 2021 16:22:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvPe-00034s-4R; Thu, 18 Mar 2021 16:22:18 +0000 Received: by outflank-mailman (input) for mailman id 99059; Thu, 18 Mar 2021 16:22:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvPd-00034n-1r for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 16:22:17 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 21c95da8-3a81-4521-8c1d-30efe5e6079c; Thu, 18 Mar 2021 16:22:13 +0000 (UTC) Received: from 089144199244.atnat0008.highway.a1.net ([89.144.199.244] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lMvP1-003DDr-Vs; Thu, 18 Mar 2021 16:21:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21c95da8-3a81-4521-8c1d-30efe5e6079c DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=KCPWbNUqPjuDm+2aG9XOMZ1UU7QB4nBnQPolRBMiA9Q=; b=rO16yUYSL2PHGWtEkM0jKHsFo7 tZpt0IRLw668ViIaxRKxVEbUSjJrrd/0bOoeZRc1wU68xwUNnONlQD2mRKj2r9TV4F4s9inII40NY qBhMCfv21CpZr09i/afyk4cl7ghrHjvSiJgMIH8vJGnm7IlJnCO0vrLE/cms+DMonA6TaB7SJl8q8 sSyFVkriV9yL4He1fU9+voaFROku2BU7guy4FS3rze9Uk7zWkKNqeR2TMprQwskfAfu/Wq+PTY6qD wng/yNEcubjWYGLSTTVvH40LTarr8p2RTZHnYr4J1XMLrp+ruRKFW9evBFdgWrCq8tvmpV+SCHE8/ NjBOMbwQ==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 2/3] swiotlb: dynamically allocate io_tlb_default_mem Date: Thu, 18 Mar 2021 17:14:23 +0100 Message-Id: <20210318161424.489045-3-hch@lst.de> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210318161424.489045-1-hch@lst.de> References: <20210318161424.489045-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Instead of allocating ->list and ->orig_addr separately just do one dynamic allocation for the actual io_tlb_mem structure. This simplifies a lot of the initialization code, and also allows to just check io_tlb_default_mem to see if swiotlb is in use. Signed-off-by: Christoph Hellwig --- drivers/xen/swiotlb-xen.c | 22 +-- include/linux/swiotlb.h | 18 ++- kernel/dma/swiotlb.c | 306 ++++++++++++-------------------------- 3 files changed, 117 insertions(+), 229 deletions(-) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 5329ad54a5f34e..4c89afc0df6289 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -158,17 +158,14 @@ static const char *xen_swiotlb_error(enum xen_swiotlb_err err) int __ref xen_swiotlb_init(void) { enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN; - unsigned long nslabs, bytes, order; - unsigned int repeat = 3; + unsigned long bytes = swiotlb_size_or_default(); + unsigned long nslabs = bytes >> IO_TLB_SHIFT; + unsigned int order, repeat = 3; int rc = -ENOMEM; char *start; - nslabs = swiotlb_nr_tbl(); - if (!nslabs) - nslabs = DEFAULT_NSLABS; retry: m_ret = XEN_SWIOTLB_ENOMEM; - bytes = nslabs << IO_TLB_SHIFT; order = get_order(bytes); /* @@ -221,19 +218,16 @@ int __ref xen_swiotlb_init(void) #ifdef CONFIG_X86 void __init xen_swiotlb_init_early(void) { - unsigned long nslabs, bytes; + unsigned long bytes = swiotlb_size_or_default(); + unsigned long nslabs = bytes >> IO_TLB_SHIFT; unsigned int repeat = 3; char *start; int rc; - nslabs = swiotlb_nr_tbl(); - if (!nslabs) - nslabs = DEFAULT_NSLABS; retry: /* * Get IO TLB memory from any location. */ - bytes = nslabs << IO_TLB_SHIFT; start = memblock_alloc(PAGE_ALIGN(bytes), PAGE_SIZE); if (!start) panic("%s: Failed to allocate %lu bytes align=0x%lx\n", @@ -248,8 +242,8 @@ void __init xen_swiotlb_init_early(void) if (repeat--) { /* Min is 2MB */ nslabs = max(1024UL, (nslabs >> 1)); - pr_info("Lowering to %luMB\n", - (nslabs << IO_TLB_SHIFT) >> 20); + bytes = nslabs << IO_TLB_SHIFT; + pr_info("Lowering to %luMB\n", bytes >> 20); goto retry; } panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc); @@ -548,7 +542,7 @@ xen_swiotlb_sync_sg_for_device(struct device *dev, struct scatterlist *sgl, static int xen_swiotlb_dma_supported(struct device *hwdev, u64 mask) { - return xen_phys_to_dma(hwdev, io_tlb_default_mem.end - 1) <= mask; + return xen_phys_to_dma(hwdev, io_tlb_default_mem->end - 1) <= mask; } const struct dma_map_ops xen_swiotlb_dma_ops = { diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 5ec5378b17c333..63f7a63f61d098 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -90,28 +90,30 @@ struct io_tlb_mem { phys_addr_t end; unsigned long nslabs; unsigned long used; - unsigned int *list; unsigned int index; - phys_addr_t *orig_addr; - size_t *alloc_size; spinlock_t lock; struct dentry *debugfs; bool late_alloc; + struct io_tlb_slot { + phys_addr_t orig_addr; + size_t alloc_size; + unsigned int list; + } slots[]; }; -extern struct io_tlb_mem io_tlb_default_mem; +extern struct io_tlb_mem *io_tlb_default_mem; static inline bool is_swiotlb_buffer(phys_addr_t paddr) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; - return paddr >= mem->start && paddr < mem->end; + return mem && paddr >= mem->start && paddr < mem->end; } void __init swiotlb_exit(void); unsigned int swiotlb_max_segment(void); size_t swiotlb_max_mapping_size(struct device *dev); bool is_swiotlb_active(void); -void __init swiotlb_adjust_size(unsigned long new_size); +void __init swiotlb_adjust_size(unsigned long size); #else #define swiotlb_force SWIOTLB_NO_FORCE static inline bool is_swiotlb_buffer(phys_addr_t paddr) @@ -135,7 +137,7 @@ static inline bool is_swiotlb_active(void) return false; } -static inline void swiotlb_adjust_size(unsigned long new_size) +static inline void swiotlb_adjust_size(unsigned long size) { } #endif /* CONFIG_SWIOTLB */ diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index d9c097f0f78cec..13de669a9b4681 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -63,7 +63,7 @@ enum swiotlb_force swiotlb_force; -struct io_tlb_mem io_tlb_default_mem; +struct io_tlb_mem *io_tlb_default_mem; /* * Max segment that we can provide which (if pages are contingous) will @@ -71,15 +71,15 @@ struct io_tlb_mem io_tlb_default_mem; */ static unsigned int max_segment; +static unsigned long default_nslabs = IO_TLB_DEFAULT_SIZE >> IO_TLB_SHIFT; + static int __init setup_io_tlb_npages(char *str) { - struct io_tlb_mem *mem = &io_tlb_default_mem; - if (isdigit(*str)) { - mem->nslabs = simple_strtoul(str, &str, 0); /* avoid tail segment of size < IO_TLB_SEGSIZE */ - mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); + default_nslabs = + ALIGN(simple_strtoul(str, &str, 0), IO_TLB_SEGSIZE); } if (*str == ',') ++str; @@ -87,24 +87,22 @@ setup_io_tlb_npages(char *str) swiotlb_force = SWIOTLB_FORCE; } else if (!strcmp(str, "noforce")) { swiotlb_force = SWIOTLB_NO_FORCE; - mem->nslabs = 1; + default_nslabs = 1; } return 0; } early_param("swiotlb", setup_io_tlb_npages); -static bool no_iotlb_memory; - unsigned long swiotlb_nr_tbl(void) { - return unlikely(no_iotlb_memory) ? 0 : io_tlb_default_mem.nslabs; + return io_tlb_default_mem ? io_tlb_default_mem->nslabs : 0; } EXPORT_SYMBOL_GPL(swiotlb_nr_tbl); unsigned int swiotlb_max_segment(void) { - return unlikely(no_iotlb_memory) ? 0 : max_segment; + return io_tlb_default_mem ? max_segment : 0; } EXPORT_SYMBOL_GPL(swiotlb_max_segment); @@ -118,44 +116,32 @@ void swiotlb_set_max_segment(unsigned int val) unsigned long swiotlb_size_or_default(void) { - unsigned long size; - - size = io_tlb_default_mem.nslabs << IO_TLB_SHIFT; - - return size ? size : (IO_TLB_DEFAULT_SIZE); + return default_nslabs << IO_TLB_SHIFT; } -void __init swiotlb_adjust_size(unsigned long new_size) +void __init swiotlb_adjust_size(unsigned long size) { - struct io_tlb_mem *mem = &io_tlb_default_mem; - unsigned long size; - /* * If swiotlb parameter has not been specified, give a chance to * architectures such as those supporting memory encryption to * adjust/expand SWIOTLB size for their use. */ - if (!mem->nslabs) { - size = ALIGN(new_size, IO_TLB_SIZE); - mem->nslabs = size >> IO_TLB_SHIFT; - mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); - - pr_info("SWIOTLB bounce buffer size adjusted to %luMB", size >> 20); - } + size = ALIGN(size, IO_TLB_SIZE); + default_nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE); + pr_info("SWIOTLB bounce buffer size adjusted to %luMB", size >> 20); } void swiotlb_print_info(void) { - struct io_tlb_mem *mem = &io_tlb_default_mem; - unsigned long bytes = mem->nslabs << IO_TLB_SHIFT; + struct io_tlb_mem *mem = io_tlb_default_mem; - if (no_iotlb_memory) { + if (!mem) { pr_warn("No low mem\n"); return; } pr_info("mapped [mem %pa-%pa] (%luMB)\n", &mem->start, &mem->end, - bytes >> 20); + (mem->nslabs << IO_TLB_SHIFT) >> 20); } static inline unsigned long io_tlb_offset(unsigned long val) @@ -176,13 +162,12 @@ static inline unsigned long nr_slots(u64 val) */ void __init swiotlb_update_mem_attributes(void) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; void *vaddr; unsigned long bytes; - if (no_iotlb_memory || mem->late_alloc) + if (!mem || mem->late_alloc) return; - vaddr = phys_to_virt(mem->start); bytes = PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT); set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT); @@ -191,55 +176,33 @@ void __init swiotlb_update_mem_attributes(void) int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) { - struct io_tlb_mem *mem = &io_tlb_default_mem; - unsigned long i, bytes; + unsigned long bytes = nslabs << IO_TLB_SHIFT, i; + struct io_tlb_mem *mem; size_t alloc_size; /* protect against double initialization */ - if (WARN_ON_ONCE(mem->start)) + if (WARN_ON_ONCE(io_tlb_default_mem)) return -ENOMEM; - bytes = nslabs << IO_TLB_SHIFT; - + alloc_size = PAGE_ALIGN(struct_size(mem, slots, nslabs)); + mem = memblock_alloc(alloc_size, PAGE_SIZE); + if (!mem) + panic("%s: Failed to allocate %zu bytes align=0x%lx\n", + __func__, alloc_size, PAGE_SIZE); mem->nslabs = nslabs; mem->start = __pa(tlb); mem->end = mem->start + bytes; mem->index = 0; spin_lock_init(&mem->lock); - - /* - * Allocate and initialize the free list array. This array is used - * to find contiguous free memory regions of size up to IO_TLB_SEGSIZE - * between mem->start and mem->end. - */ - alloc_size = PAGE_ALIGN(mem->nslabs * sizeof(int)); - mem->list = memblock_alloc(alloc_size, PAGE_SIZE); - if (!mem->list) - panic("%s: Failed to allocate %zu bytes align=0x%lx\n", - __func__, alloc_size, PAGE_SIZE); - - alloc_size = PAGE_ALIGN(mem->nslabs * sizeof(phys_addr_t)); - mem->orig_addr = memblock_alloc(alloc_size, PAGE_SIZE); - if (!mem->orig_addr) - panic("%s: Failed to allocate %zu bytes align=0x%lx\n", - __func__, alloc_size, PAGE_SIZE); - - alloc_size = PAGE_ALIGN(mem->nslabs * sizeof(size_t)); - mem->alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); - if (mem->alloc_size) - panic("%s: Failed to allocate %zu bytes align=0x%lx\n", - __func__, alloc_size, PAGE_SIZE); - for (i = 0; i < mem->nslabs; i++) { - mem->list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); - mem->orig_addr[i] = INVALID_PHYS_ADDR; - mem->alloc_size[i] = 0; + mem->slots[i].list = IO_TLB_SEGSIZE - io_tlb_offset(i); + mem->slots[i].orig_addr = INVALID_PHYS_ADDR; + mem->slots[i].alloc_size = 0; } - no_iotlb_memory = false; + io_tlb_default_mem = mem; if (verbose) swiotlb_print_info(); - swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT); return 0; } @@ -251,30 +214,21 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) void __init swiotlb_init(int verbose) { - struct io_tlb_mem *mem = &io_tlb_default_mem; - size_t default_size = IO_TLB_DEFAULT_SIZE; - unsigned char *vstart; - unsigned long bytes; - - if (!mem->nslabs) { - mem->nslabs = (default_size >> IO_TLB_SHIFT); - mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); - } - - bytes = mem->nslabs << IO_TLB_SHIFT; + size_t bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT); + void *tlb; /* Get IO TLB memory from the low pages */ - vstart = memblock_alloc_low(PAGE_ALIGN(bytes), PAGE_SIZE); - if (vstart && !swiotlb_init_with_tbl(vstart, mem->nslabs, verbose)) - return; - - if (mem->start) { - memblock_free_early(mem->start, - PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT)); - mem->start = 0; - } + tlb = memblock_alloc_low(bytes, PAGE_SIZE); + if (!tlb) + goto fail; + if (swiotlb_init_with_tbl(tlb, default_nslabs, verbose)) + goto fail_free_mem; + return; + +fail_free_mem: + memblock_free_early(__pa(tlb), bytes); +fail: pr_warn("Cannot allocate buffer"); - no_iotlb_memory = true; } /* @@ -285,23 +239,19 @@ swiotlb_init(int verbose) int swiotlb_late_init_with_default_size(size_t default_size) { - struct io_tlb_mem *mem = &io_tlb_default_mem; - unsigned long bytes, req_nslabs = mem->nslabs; + unsigned long nslabs = + ALIGN(default_size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE); + unsigned long bytes; unsigned char *vstart = NULL; unsigned int order; int rc = 0; - if (!mem->nslabs) { - mem->nslabs = (default_size >> IO_TLB_SHIFT); - mem->nslabs = ALIGN(mem->nslabs, IO_TLB_SEGSIZE); - } - /* * Get IO TLB memory from the low pages */ - order = get_order(mem->nslabs << IO_TLB_SHIFT); - mem->nslabs = SLABS_PER_PAGE << order; - bytes = mem->nslabs << IO_TLB_SHIFT; + order = get_order(nslabs << IO_TLB_SHIFT); + nslabs = SLABS_PER_PAGE << order; + bytes = nslabs << IO_TLB_SHIFT; while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) { vstart = (void *)__get_free_pages(GFP_DMA | __GFP_NOWARN, @@ -311,43 +261,35 @@ swiotlb_late_init_with_default_size(size_t default_size) order--; } - if (!vstart) { - mem->nslabs = req_nslabs; + if (!vstart) return -ENOMEM; - } + if (order != get_order(bytes)) { pr_warn("only able to allocate %ld MB\n", (PAGE_SIZE << order) >> 20); - mem->nslabs = SLABS_PER_PAGE << order; + nslabs = SLABS_PER_PAGE << order; } - rc = swiotlb_late_init_with_tbl(vstart, mem->nslabs); + rc = swiotlb_late_init_with_tbl(vstart, nslabs); if (rc) free_pages((unsigned long)vstart, order); return rc; } -static void swiotlb_cleanup(void) -{ - struct io_tlb_mem *mem = &io_tlb_default_mem; - - mem->end = 0; - mem->start = 0; - mem->nslabs = 0; - max_segment = 0; -} - int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) { - struct io_tlb_mem *mem = &io_tlb_default_mem; - unsigned long i, bytes; + unsigned long bytes = nslabs << IO_TLB_SHIFT, i; + struct io_tlb_mem *mem; /* protect against double initialization */ - if (WARN_ON_ONCE(mem->start)) + if (WARN_ON_ONCE(io_tlb_default_mem)) return -ENOMEM; - bytes = nslabs << IO_TLB_SHIFT; + mem = (void *)__get_free_pages(GFP_KERNEL, + get_order(struct_size(mem, slots, nslabs))); + if (!mem) + return -ENOMEM; mem->nslabs = nslabs; mem->start = virt_to_phys(tlb); @@ -355,84 +297,35 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) mem->index = 0; mem->late_alloc = 1; spin_lock_init(&mem->lock); + for (i = 0; i < mem->nslabs; i++) { + mem->slots[i].list = IO_TLB_SEGSIZE - io_tlb_offset(i); + mem->slots[i].orig_addr = INVALID_PHYS_ADDR; + mem->slots[i].alloc_size = 0; + } set_memory_decrypted((unsigned long)tlb, bytes >> PAGE_SHIFT); memset(tlb, 0, bytes); - /* - * Allocate and initialize the free list array. This array is used - * to find contiguous free memory regions of size up to IO_TLB_SEGSIZE - * between mem->start and mem->end. - */ - mem->list = (unsigned int *)__get_free_pages(GFP_KERNEL, - get_order(mem->nslabs * sizeof(int))); - if (!mem->list) - goto cleanup3; - - mem->orig_addr = (phys_addr_t *) - __get_free_pages(GFP_KERNEL, - get_order(mem->nslabs * - sizeof(phys_addr_t))); - if (!mem->orig_addr) - goto cleanup4; - - mem->alloc_size = (size_t *) - __get_free_pages(GFP_KERNEL, - get_order(mem->nslabs * - sizeof(size_t))); - if (!mem->alloc_size) - goto cleanup5; - - for (i = 0; i < mem->nslabs; i++) { - mem->list[i] = IO_TLB_SEGSIZE - io_tlb_offset(i); - mem->orig_addr[i] = INVALID_PHYS_ADDR; - mem->alloc_size[i] = 0; - } - no_iotlb_memory = false; - + io_tlb_default_mem = mem; swiotlb_print_info(); swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT); return 0; - -cleanup5: - free_pages((unsigned long)mem->orig_addr, - get_order(mem->nslabs * sizeof(phys_addr_t))); -cleanup4: - free_pages((unsigned long)mem->list, - get_order(mem->nslabs * sizeof(int))); - mem->list = NULL; -cleanup3: - swiotlb_cleanup(); - return -ENOMEM; } void __init swiotlb_exit(void) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; + size_t size; - if (!mem->orig_addr) + if (!mem) return; - if (mem->late_alloc) { - free_pages((unsigned long)mem->alloc_size, - get_order(mem->nslabs * sizeof(size_t))); - free_pages((unsigned long)mem->orig_addr, - get_order(mem->nslabs * sizeof(phys_addr_t))); - free_pages((unsigned long)mem->list, - get_order(mem->nslabs * sizeof(int))); - free_pages((unsigned long)phys_to_virt(mem->start), - get_order(mem->nslabs << IO_TLB_SHIFT)); - } else { - memblock_free_late(__pa(mem->alloc_size), - PAGE_ALIGN(mem->nslabs * sizeof(size_t))); - memblock_free_late(__pa(mem->orig_addr), - PAGE_ALIGN(mem->nslabs * sizeof(phys_addr_t))); - memblock_free_late(__pa(mem->list), - PAGE_ALIGN(mem->nslabs * sizeof(int))); - memblock_free_late(mem->start, - PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT)); - } - swiotlb_cleanup(); + size = struct_size(mem, slots, mem->nslabs); + if (mem->late_alloc) + free_pages((unsigned long)mem, get_order(size)); + else + memblock_free_late(__pa(mem), PAGE_ALIGN(size)); + io_tlb_default_mem = NULL; } /* @@ -441,10 +334,10 @@ void __init swiotlb_exit(void) static void swiotlb_bounce(struct device *dev, phys_addr_t tlb_addr, size_t size, enum dma_data_direction dir) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; int index = (tlb_addr - mem->start) >> IO_TLB_SHIFT; - phys_addr_t orig_addr = mem->orig_addr[index]; - size_t alloc_size = mem->alloc_size[index]; + phys_addr_t orig_addr = mem->slots[index].orig_addr; + size_t alloc_size = mem->slots[index].alloc_size; unsigned long pfn = PFN_DOWN(orig_addr); unsigned char *vaddr = phys_to_virt(tlb_addr); @@ -523,7 +416,7 @@ static unsigned int wrap_index(struct io_tlb_mem *mem, unsigned int index) static int find_slots(struct device *dev, phys_addr_t orig_addr, size_t alloc_size) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; unsigned long boundary_mask = dma_get_seg_boundary(dev); dma_addr_t tbl_dma_addr = phys_to_dma_unencrypted(dev, mem->start) & boundary_mask; @@ -565,7 +458,7 @@ static int find_slots(struct device *dev, phys_addr_t orig_addr, if (!iommu_is_span_boundary(index, nslots, nr_slots(tbl_dma_addr), max_slots)) { - if (mem->list[index] >= nslots) + if (mem->slots[index].list >= nslots) goto found; } index = wrap_index(mem, index + stride); @@ -577,11 +470,11 @@ static int find_slots(struct device *dev, phys_addr_t orig_addr, found: for (i = index; i < index + nslots; i++) - mem->list[i] = 0; + mem->slots[i].list = 0; for (i = index - 1; io_tlb_offset(i) != IO_TLB_SEGSIZE - 1 && - mem->list[i]; i--) - mem->list[i] = ++count; + mem->slots[i].list; i--) + mem->slots[i].list = ++count; /* * Update the indices to avoid searching in the next round. @@ -600,12 +493,12 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, size_t mapping_size, size_t alloc_size, enum dma_data_direction dir, unsigned long attrs) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; unsigned int offset = swiotlb_align_offset(dev, orig_addr); unsigned int index, i; phys_addr_t tlb_addr; - if (no_iotlb_memory) + if (!mem) panic("Can not allocate SWIOTLB buffer earlier and can't now provide you with the DMA bounce buffer"); if (mem_encrypt_active()) @@ -632,8 +525,9 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, * needed. */ for (i = 0; i < nr_slots(alloc_size + offset); i++) { - mem->orig_addr[index + i] = slot_addr(orig_addr, i); - mem->alloc_size[index + i] = alloc_size - (i << IO_TLB_SHIFT); + mem->slots[index + i].orig_addr = slot_addr(orig_addr, i); + mem->slots[index + i].alloc_size = + alloc_size - (i << IO_TLB_SHIFT); } tlb_addr = slot_addr(mem->start, index) + offset; if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) && @@ -649,11 +543,11 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, size_t mapping_size, enum dma_data_direction dir, unsigned long attrs) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; unsigned long flags; unsigned int offset = swiotlb_align_offset(hwdev, tlb_addr); int index = (tlb_addr - offset - mem->start) >> IO_TLB_SHIFT; - int nslots = nr_slots(mem->alloc_size[index] + offset); + int nslots = nr_slots(mem->slots[index].alloc_size + offset); int count, i; /* @@ -671,7 +565,7 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, */ spin_lock_irqsave(&mem->lock, flags); if (index + nslots < ALIGN(index + 1, IO_TLB_SEGSIZE)) - count = mem->list[index + nslots]; + count = mem->slots[index + nslots].list; else count = 0; @@ -680,9 +574,9 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, * superceeding slots */ for (i = index + nslots - 1; i >= index; i--) { - mem->list[i] = ++count; - mem->orig_addr[i] = INVALID_PHYS_ADDR; - mem->alloc_size[i] = 0; + mem->slots[i].list = ++count; + mem->slots[i].orig_addr = INVALID_PHYS_ADDR; + mem->slots[i].alloc_size = 0; } /* @@ -690,9 +584,9 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr, * available (non zero) */ for (i = index - 1; - io_tlb_offset(i) != IO_TLB_SEGSIZE - 1 && mem->list[i]; + io_tlb_offset(i) != IO_TLB_SEGSIZE - 1 && mem->slots[i].list; i--) - mem->list[i] = ++count; + mem->slots[i].list = ++count; mem->used -= nslots; spin_unlock_irqrestore(&mem->lock, flags); } @@ -756,19 +650,17 @@ size_t swiotlb_max_mapping_size(struct device *dev) bool is_swiotlb_active(void) { - /* - * When SWIOTLB is initialized, even if mem->start points to physical - * address zero, mem->end surely doesn't. - */ - return io_tlb_default_mem.end != 0; + return io_tlb_default_mem != NULL; } #ifdef CONFIG_DEBUG_FS static int __init swiotlb_create_debugfs(void) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_mem *mem = io_tlb_default_mem; + if (!mem) + return 0; mem->debugfs = debugfs_create_dir("swiotlb", NULL); debugfs_create_ulong("io_tlb_nslabs", 0400, mem->debugfs, &mem->nslabs); debugfs_create_ulong("io_tlb_used", 0400, mem->debugfs, &mem->used); -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Thu Mar 18 16:22:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 16:22:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99061.188173 (Exim 4.92) (envelope-from ) id 1lMvQ5-0003Ag-I5; Thu, 18 Mar 2021 16:22:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99061.188173; Thu, 18 Mar 2021 16:22:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvQ5-0003AZ-EO; Thu, 18 Mar 2021 16:22:45 +0000 Received: by outflank-mailman (input) for mailman id 99061; Thu, 18 Mar 2021 16:22:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvQ4-0003AM-1o; Thu, 18 Mar 2021 16:22:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvQ3-0004LH-SW; Thu, 18 Mar 2021 16:22:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvQ3-0007qw-IE; Thu, 18 Mar 2021 16:22:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMvQ3-0006Bg-Hi; Thu, 18 Mar 2021 16:22:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8u42r4Wt4Gow3IZjy1v1paOiVYIMbEs/gDhq/DcC9LY=; b=RlD+fSaVdg/S3xjC9I2ho6t2K1 F0AqrIsF0p8bTQC808XhP/XetuRS5F69FFCjmfSciEt9wY042LK2AEfPKT0kbdCaRxhF8a0sB5U46 l84RUsGuHTaLztCr1xOQmrqkud5a5PYlpw/Viny4BKwEgfyKVh9PnH54W6ezE9iXHDlo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160126: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=dae3c3e8b257cd27d6b35a467a34bf79a6650340 X-Osstest-Versions-That: xen=21657ad4f01a634beac570c64c0691e51b9cf366 From: osstest service owner Date: Thu, 18 Mar 2021 16:22:43 +0000 flight 160126 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160126/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen dae3c3e8b257cd27d6b35a467a34bf79a6650340 baseline version: xen 21657ad4f01a634beac570c64c0691e51b9cf366 Last test of basis 160099 2021-03-16 15:00:26 Z 2 days Testing same since 160126 2021-03-18 14:01:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Olaf Hering jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 21657ad4f0..dae3c3e8b2 dae3c3e8b257cd27d6b35a467a34bf79a6650340 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Mar 18 16:25:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 16:25:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99067.188188 (Exim 4.92) (envelope-from ) id 1lMvSf-0003Ko-07; Thu, 18 Mar 2021 16:25:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99067.188188; Thu, 18 Mar 2021 16:25:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvSe-0003Kh-TL; Thu, 18 Mar 2021 16:25:24 +0000 Received: by outflank-mailman (input) for mailman id 99067; Thu, 18 Mar 2021 16:25:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvSd-0003Ka-RE for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 16:25:23 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e5ae8642-de36-4435-836c-bd10dd68b670; Thu, 18 Mar 2021 16:25:22 +0000 (UTC) Received: from 089144199244.atnat0008.highway.a1.net ([89.144.199.244] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lMvRV-003DLG-Ih; Thu, 18 Mar 2021 16:24:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5ae8642-de36-4435-836c-bd10dd68b670 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=9gEP8raZOg3EB9wo1YlmqP5MKZV8/kqbQaScw+YfWuE=; b=JnuhGi9J4kooWrHzFkSJvSQB/f H1LyP5FBzoY04johHQs63+EOvbbCIVrj5RI97Wzqrpu5/ANSHEXfUXSSHmdx8qZkrYl0CqZPmQyqD gUuOdJ02W96mrTGr0lh+bCwDZO6ub/Uc/WxBzk9LMWBGZefHttJAq4B8N6Oi+F+13iVW8MEutZfAR KhQuThABIusZgmw132kdn9enlQGOEPn3Q5pRjO2nNpenvm5KpiptkisJ0z5ZklqDVtXsxC2KvXNFB IxMjAONqS2TPXowUqOYB3qGo+qaWd6+I+m/Zd/mrIzgAeF0iNeQFlhB66jMOxkfVk2r8Yaub0v3Mb dDfJBBug==; From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Michael Ellerman , Dongli Zhang , Claire Chang , xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org Subject: [PATCH 3/3] swiotlb: remove swiotlb_nr_tbl Date: Thu, 18 Mar 2021 17:14:24 +0100 Message-Id: <20210318161424.489045-4-hch@lst.de> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210318161424.489045-1-hch@lst.de> References: <20210318161424.489045-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html All callers just use it to check if swiotlb is active at all, for which they can just use is_swiotlb_active. In the longer run drivers need to stop using is_swiotlb_active as well, but let's do the simple step first. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/i915/gem/i915_gem_internal.c | 2 +- drivers/gpu/drm/nouveau/nouveau_ttm.c | 2 +- drivers/pci/xen-pcifront.c | 2 +- include/linux/swiotlb.h | 1 - kernel/dma/swiotlb.c | 7 +------ 5 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_internal.c b/drivers/gpu/drm/i915/gem/i915_gem_internal.c index ad22f42541bda6..a9d65fc8aa0eab 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_internal.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_internal.c @@ -42,7 +42,7 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj) max_order = MAX_ORDER; #ifdef CONFIG_SWIOTLB - if (swiotlb_nr_tbl()) { + if (is_swiotlb_active()) { unsigned int max_segment; max_segment = swiotlb_max_segment(); diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index a37bc3d7b38b3b..9662522aa0664a 100644 --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c @@ -321,7 +321,7 @@ nouveau_ttm_init(struct nouveau_drm *drm) } #if IS_ENABLED(CONFIG_SWIOTLB) && IS_ENABLED(CONFIG_X86) - need_swiotlb = !!swiotlb_nr_tbl(); + need_swiotlb = is_swiotlb_active(); #endif ret = ttm_bo_device_init(&drm->ttm.bdev, &nouveau_bo_driver, diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c index 2d75026482197d..b7a8f3a1921f83 100644 --- a/drivers/pci/xen-pcifront.c +++ b/drivers/pci/xen-pcifront.c @@ -693,7 +693,7 @@ static int pcifront_connect_and_init_dma(struct pcifront_device *pdev) spin_unlock(&pcifront_dev_lock); - if (!err && !swiotlb_nr_tbl()) { + if (!err && !is_swiotlb_active()) { err = pci_xen_swiotlb_init_late(); if (err) dev_err(&pdev->xdev->dev, "Could not setup SWIOTLB!\n"); diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 63f7a63f61d098..216854a5e5134b 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -37,7 +37,6 @@ enum swiotlb_force { extern void swiotlb_init(int verbose); int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose); -extern unsigned long swiotlb_nr_tbl(void); unsigned long swiotlb_size_or_default(void); extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs); extern int swiotlb_late_init_with_default_size(size_t default_size); diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 13de669a9b4681..539c76beb52e07 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -94,12 +94,6 @@ setup_io_tlb_npages(char *str) } early_param("swiotlb", setup_io_tlb_npages); -unsigned long swiotlb_nr_tbl(void) -{ - return io_tlb_default_mem ? io_tlb_default_mem->nslabs : 0; -} -EXPORT_SYMBOL_GPL(swiotlb_nr_tbl); - unsigned int swiotlb_max_segment(void) { return io_tlb_default_mem ? max_segment : 0; @@ -652,6 +646,7 @@ bool is_swiotlb_active(void) { return io_tlb_default_mem != NULL; } +EXPORT_SYMBOL_GPL(is_swiotlb_active); #ifdef CONFIG_DEBUG_FS -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Thu Mar 18 16:44:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 16:44:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99074.188200 (Exim 4.92) (envelope-from ) id 1lMvkU-0005Fd-NK; Thu, 18 Mar 2021 16:43:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99074.188200; Thu, 18 Mar 2021 16:43:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvkU-0005FW-KK; Thu, 18 Mar 2021 16:43:50 +0000 Received: by outflank-mailman (input) for mailman id 99074; Thu, 18 Mar 2021 16:43:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMvkS-0005FR-Kh for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 16:43:48 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ce61e370-e5d0-47bb-b95f-ad5dbbc02cf6; Thu, 18 Mar 2021 16:43:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce61e370-e5d0-47bb-b95f-ad5dbbc02cf6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616085827; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=jdJO+d8yQA7FbPlZgN/81nCXqS+6l2yHPZ7IYVw7wj8=; b=Cd4hn6TMWUVNExc2xw6FlXuS9Qlkk5X6gdVH3k+2t00I6lf63Gsd8Cn2 OzMCUn+oQZBuEK2BpgnymG3E8sE1/jzpE/MwEwv0YRixO6loH07Br34pN 0lofO3B1dkVGzoKq5eKFuqa7JvRfW4tBwRCoHMaZs5Y7xsTYNSC+9XIHt 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: V8Rqo/QChW/200UkVJ/8N7olqbN13IhkQlnbT5UWXMgHlf9gnxqW9pE46pxTQSGFVOoHYtpz+9 8XLsWJfqxyMr26WYBrOvCGmLxD11oYwKiCr3D9m1oBuh+47R3rtM3fV5Mm5HKo1K8iS7cgDCsc XzraIj8xm5NRtTQG9s7ed41hclbMgKqAQSE7eqvTVnEz07qh79PUKtOO8Q3471JZiRUTo+Hlhz 8aJnTwc3FYjbjUce36DkXWCJw0pVRpeVwsUqcwDnE7UOcwt7rjsS1z4G+RdD8A08VaEVw05SDP 1bY= X-SBRS: 5.2 X-MesageID: 39619828 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:wsjtqqN5uZyzqMBcT9vz55DYdL4zR+YMi2QD/0p6RQVJNumRkM 6zlPoWvCWE/go5cltIo6H/BICrR3TA+ZlppawYOrm/VAfr0VHYZb1Kx43k3jHmBmnC5vdQvJ 0QWZRWJf/RKRxBjcj86BSlCNpI+rO62Y2hmOu29QYecShEcKdlhj0JdjqzMkozfwVeAIp8KZ z03LsxmxOFWVA6Kvu2HWMEWe+rnaznqLvDbQQdDxAqrCmi5AnYnYLSKBST0hcAXz4n+95LnB mg4muJgNTbwonLsW6nphLuxq9bl9f7xtxICNbksLlgFhzWhhu1f4MkYrWevVkOy92H0kogk9 XHvn4bTrVOwk7RZW28rF/M3ATtwV8Vmgzf4GKYmnfqrIjFQis7AaN69PJkWybegnBQw+1U4e ZhxGKWtodSBRPE2Bnn79LLWwoCrCaJiEtnvekNy0ZSVoYTc9ZqwrA3zQdwKtMgFDi/wJ07GO NuZfusrMp+QBe/VTTlmUVBhParRW8+Gx+aRFNqgL3f7xFm2FRiwQ8iyMN3pBk93aN4bYJF6e TCOrlpk78LbvZ+V8NALdZEZ9C2BGzLSQ/LK0SILz3cZY06EkOIka7SyvEY3tvvUpkJwJwu3L zcTVIwjw4PUnOrM9CHx6dA+heIe2m2UTTzxsw23ekbhpTMAID3OTa4Qlgo1/StuO8eBMqzYY fQBLtmR8DiNnf1M4dE1Q/zVvBpWBwjecUPsJIyR0+OrsXXKofjq+zcd7LJKKDwFCs/M1mPUk crVCP4YMFN9FqiVHO9mhjeXHvxZlfylKgAQZTy9/MYjJIAPogkiHlKtX28/MGTHzhLuaAySh IlfOPpzPrm4TK89T+Nsjk1MV4MBElepOrrXy9ArwcDORqoKIAKscief2dT0RK8V19CZsfNEB doolx99aeAdsbNlS99Uo7iaWmT1j9P+C+AC8cXlafGus3oJpgzBp4tAfEpIw/MEAF4nhtgqH pYATV0BXP3EinvkJOhhJcZAdeHLYUtj1nzfYoOonqH8RjB+MpqFnEVVXrwW8LKigwnTzAM2w RG/6gWi7+NlF+UWCYCqeAjMER7bWydDLdxVV7YNIoLw+yuIwp5FCPW2WGQz0E4dWCvqE8f2m fqJSWfIKyTNF5Qp3Ff38/RgRxJX2GGf1tHb3hwvYhKTD6b6nksiLPOPaG6ii/NNgYIhrEWPz uAPjEffghlz9i8jUPNrjGLEXlO/ORhAsXYFrQ7RbTa0X+pHtTTyfEIQaYJuM1vPImr77NXWq bOcQCeaGzzB78j0QScrC95YR9vpGQome7lsSeVoFSQ2GQ+GMzWKF9rQodDeY3N4Da8G7LS25 0hyY9o4OD1Ym//YJrYw62KZDRKIhmL/DeBVeE0pZBY1JhC9YdbG4PaSA3M3HpK2Q9WFra/qG oOBKt8+7zPIYlpYogbfD9Y5EMgkJCVIFIsqRGeOJ5iQXg9y3vaNciO+bzGtP4mBVCAvhL5PT CkgnZg1uaAWyuIzrgBDa0sZWxQdUgn8XxnuOePbZfZBgnvd+ZN+jOBQyWAWa4YTKiOArMLqB lmp9mOgu+MbiL9nBnKoiETGNMJz0+3BcepRA6cE+9B9NK3fVyKn6ux+ca2yDP6UyGyZUgUjZ BMHHZgMvhrm30nlsk6wyKyQqv4rgYuiF1F+yxqkVbrx8yv/HrbFVsuC3yLvrxGGT1IdnSYh8 XM9uaVkH7n5iJexJXFHEBMOtlTBtkLSJTtJSsGE7lDgJe4u640xihTahYnCGAxzDrn2fl9wL u/0PLOH+L4D3PlPk8A5C5FCoZ4kjdDkxAWT+GuqZamJgkHHO8BBPUyoopMlihyt1T151oAKx Vh3zZYgL3lPxjiJTBxBKLulYz5jFwTv66Z8UBjo31WhxeigFGYsF7lgtattxMP3kTghx4irb /YSCo6gS5fuAIiy7dmKGCRXWnlRm7AN1/r0q0yOzlgBXo0w+smyBrPRpN7w6yW3i5ht3A2Ey Iwy7akGiLUUjOJD8D9KzisCZCyG959Y/FYP2IZNH6oPBHYmpA9Jyi4LOtJx1GpgDMDFKKOMq SpbEaWF58W5rEdPKTqXsqDn8vUzxNY8HsTtor/jnSAkJtRnOumDx85tch4f7liOw+s8is9yN eVUA7VN4Uc4S3erQXamHxlDc5Txx5QzVgRpC8WFi/tGsi6QVt5oiUaj5XzQjcD1MqHQdFJsG vIrFK7omPKPASMPETEYcwn31s5sALaBI7KtVmzfLT8cw1I8Pa3CKGjiG700RTZq9jptkiAij p9lWdHARM7xAeeUI5PVzPYz0UGPwFtER0pmgy4waYZ6mZmg0hhcjF5frhGwAz5TRTHSyvjj3 DMIDE18YcNWWp8n/JIsHpFmVhKoi5McZ1s0pGU7E6wfWJFRBtWz9UYiwGShNUwPk4OfnPZIa 7xopy3OMyk0ZdRAiCE4vgEJPN/bD5Tibi93piZdQtTKwKC3blSyhLW+hYzq1g78vVV9n3dvA == X-IronPort-AV: E=Sophos;i="5.81,259,1610427600"; d="scan'208";a="39619828" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T3faJItipjp3c9B2pAZu8LeO9yAKUvRvz/gvStwsJMM99iZcRb5sHcs36If/HJvmiywX+o9hymFWEWp6CQ4gQSYeZZkCLhcHM9KT/HRZxKiYDpXXjE/L201E6AAM5hVcUBcsMgFgpZxghoWTxiNGFP/H5IrKQCTK8s3kFVDGAI8rn8A4JZRXMshjRb40aTEeIoy1DRUPn454W1lvaRnUrclUbDc9miJNJRakjnDityAHf2X3sYJWVIYxCateadE3HJ/zNMAmMU/C7d4D7MKqnCM9apeBRu6P8IWOPBrBFz1qkiS1Zw7Bre7y6gNKaPlXytyhy0Z/PtXYbG3FRgoO7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sxDZB9dQLgRIPvV5DwjxQaV7NJLdr6+APJD95DS2e+o=; b=cjfpnm2ekfdWrrUuXWOeYKX9Y4R7tPeNxpYqCAsW3sCQlQ3zy0cMEUOhI1PuOFv6OAod3+VSvMvnrSfv8BgfIlHPAb+/PLjHBVuMGjNzzPt1dgQwi7bf+bVqz3R6zKglGgtqd/+d8JvXPiNx7tojQ2R5e6nvfoG5ZRDqhNHIu3YndPLBYlT3bssC7ogBTo68zToAz9PtO8PF9ZmhovOr3PDdiLdcUSnCnt3tPmaTT9kiWLxPGsFubVmo16DlOW1+V88Hv7jQay7TCaYJ5pulpksw3AJtIWUt7868N5coyn+ebTnNsBr6GBpPm0kxGVOamJLcoDSFPqqW29C0nm4uoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sxDZB9dQLgRIPvV5DwjxQaV7NJLdr6+APJD95DS2e+o=; b=occ8PBLSpPMzVUFhtZrXINd7uZbNjCBTVPP+f0ajBL/VlCehvyclMtFXO9NJByWvGsUJkg7AstQRqu0RdH6V7EkxL9EAnO0hfhmEQlLRRatxClqV7YcmsioI4F3l6mr4ap2mcD1mxIVDonGrWFWqnkrXiVduiWbDSzyn2PXIaew= Date: Thu, 18 Mar 2021 17:43:38 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: "Daniel P. Smith" CC: , , , , , , , , , , , , , , Subject: Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document Message-ID: References: <20210316031814.10311-1-dpsmith@apertussolutions.com> <20210316031814.10311-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210316031814.10311-2-dpsmith@apertussolutions.com> X-ClientProxiedBy: MR2P264CA0059.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:31::23) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d7ee27b5-2de6-43d0-da7d-08d8ea2cfe3d X-MS-TrafficTypeDiagnostic: DM6PR03MB3673: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kx1Z7T753rv5/OOHMKwIldVnW8+vvguEtjXktMlTIJ4LC+Z2IFM66sCrLqHYYhY9KiM8eJ8v5Ckrz3noC04WwE9BvLT9sm1Ga7eCNrJtvCfC4fGGhCw4uure+KYpVf+wyQz1eb/fFZTNZRbECx4wmihMz8fGNJGfGy2wcv4W8qvW/1Sj/sMKyBesnCMpWxmo/NubzV3EEfPrDbyiUfiYE972+dJTUHXfLb7wkSzIu9hw7fdG7PugBpemptpQrdb3orL0eOqyyRo88nfxpJyWk44zBPaYxTD1LUcE65fX60PMktHy74AleuMrDRViZtogd/2mrB5Dudh8qD6uK0Y8xqHya7J7LyvSAEwkPZ/DwY4O8drtTphd5fTlRJibKdufS53ETrzDcmfPFnSGWN5DrwQCMRHf6igOWyB0G8I96lXdqYdPfKMKTfKd0txh6c1cWcEWcouvrp60UPYfBJzWmkcEsrJPEVgAuxUY7mshrZOvZplmiD34eoYb1kOSS2Xu2thNMvh+qatSf14y59364sogkZg8UnX1bG+4CJuLmtMJcBYSfdp6ADNyzH4CPz5yKbut1h9b8PbogGUpCj89c2jkypcfbhfJY/+kcswbAmJ6KHiM/H3xymJxmhw2ZcTy X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(39860400002)(136003)(366004)(346002)(396003)(376002)(316002)(8676002)(26005)(186003)(66476007)(956004)(66946007)(86362001)(16526019)(66556008)(6916009)(6496006)(9686003)(5660300002)(6486002)(478600001)(4326008)(38100700001)(6666004)(2906002)(85182001)(33716001)(7416002)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?QmRqV2FoN3JLQjdxd0lTTnJlakVRb05TcWxlWlA4aURtT3IybElxT0pkK0RS?= =?utf-8?B?a1lQSGs5MWtGdE5MaExrZDZTazZHcXVDUmJIM3RjZGFjZWhsNlBCczZ5ei9a?= =?utf-8?B?YWlaOU5XRlEvY2lPWGM5d0JlM3hJUzVzczZkYXIvVVNGTWtCQ2toMEJEeXM4?= =?utf-8?B?d3pxbHY0Z2RJRE13U3pJYVl6NTNsNHZOWmpGbTNjWlVUS3pIVUthYUNDYnZJ?= =?utf-8?B?TjVYZndwb25wdnlkOUJJRk5vaFk2aHpmZFdTVW1Sb0xxaHpnSVJ4ZDY1ZndG?= =?utf-8?B?Ri8wT0RDRFFKSFcwMHBCWVpEa2NPWVFtalMvVExGVWUyMXcxVU9Xak5STEU0?= =?utf-8?B?bk1ZQURsdjZpeFkvem9aaUtUMkFHZ2dzUkQ3OGhTZGJDWGpFOEF4UThoc25q?= =?utf-8?B?OWFxeENva25vL09VZXRjYnB5SXFZbGhpNlBMalZMVXFPVlhSWEhnYThyQWIw?= =?utf-8?B?VFNXWGpIZ3dLVS9ZWno0ck9jR1NkNG1MMWh2QTMvaTkra0ZmaTdJM3VEZmVM?= =?utf-8?B?SVpNYk1TOUdJWXlhRkVsb1RCaWZ1bk84WWU4U3ByK0RhdUtKZGsxMTZOZTRB?= =?utf-8?B?czQzcWdGem5BTXIxZ3NVZld2cXEzeHZCRGhhclpRODhSQVcya05GNkQ4d1Ir?= =?utf-8?B?MmttT20xbU9IYW5CV2tZTXo2eWlKdUhvOE1kNzVRZTQ0dHhFb09aR1V3NDVP?= =?utf-8?B?UnZxWmNxYWZxU2dRZE1Bc1kycnhFNkVISWlYeFVVUSszc2p0K2tXeC9peEg4?= =?utf-8?B?WUoxOWJ3a01xdy9TVnV5UjZBaWVLbTdENTJ4M3R4YlBhdUNScHlVYmZ3SVZZ?= =?utf-8?B?bk5kYTg3Wit1djdaZldyZHlwWnFiSThoa25STmozZ1VtcU5mbVlSSlVtUzVk?= =?utf-8?B?aGZVQkRxb3N0aS9LVUtEZVAwUng5eWtNbWIzTFBIcXRKWmRTNEVBNFNnVzRt?= =?utf-8?B?YXhKck5URS9GbWgySGVlWmNNaWM2andGT2pzSGIrL05Da0VKMXprUXpPQkVC?= =?utf-8?B?S3dhU0V5cGxjaS9HTmFUb1hlcHZBRXRWRDBBd205T1h3amdQc0thVzNvV29o?= =?utf-8?B?M0NiQWhQNnozK1dUNE4zc2tIOHFzaklWODF1NnhXNG80NjZTMXk4SHBMQmxE?= =?utf-8?B?U0pUWnZkT1ByT2xQdXd6YVhXVnVLalcweVV6cDhZZjdMbFZDSVJ4WWZOVnp4?= =?utf-8?B?NjlwYk5QeEw3aW1LU0IwNHZFb3QrNDlVeGJOczMyVDJiUDM4cFZCczFzd3dq?= =?utf-8?B?M0pYZDNwbnBpNUFSc21odFA2a0c3TGFJdHpXa0NQZnRTZ2p4VmE4Y2FaVjFi?= =?utf-8?B?RkhQMUlmOG9SR1JpM1BwZXFjVnlLalNTdVowbzdkN1REL1lwNjlOT2dsTWQ5?= =?utf-8?B?SFhWOG5aQlZaT3FUTkphM2E5cFpWNFBpRVAwbFFxODZ1cWpiOG5Yb3RZa1lJ?= =?utf-8?B?ZldiMXJWNW5Fb1plQjViNjhuTGRYNUFTR3FpYnBhSEdsSk5xS3oyQ01xWC9I?= =?utf-8?B?RGdpVlVnVWx2Zzh0TkhPcnRPNWZSUUYrMVNUOW5iOVBkbXRvdGNCMTM0NEFC?= =?utf-8?B?NkRvdkJlSm81ejZHa2VRWmNPUWlGSGhvYUdzU1VWZHJueFlDbVZRTGt6dHZj?= =?utf-8?B?SlJVMzdDVkdSUDMxeVpOY1NDR2I0dDh1UmFBODBaUE5xMUJuenJTY1U5V1BU?= =?utf-8?B?c2FDSWJLWEtnbWU1ZmIyVE1JaTlzc1p4ZTZaSEdRdkpTOE1LdjVBc1BHY3hu?= =?utf-8?Q?V5Impm5i8Kk5FFeCDdm+cnoCQSOd2gQdV3C2Lwz?= X-MS-Exchange-CrossTenant-Network-Message-Id: d7ee27b5-2de6-43d0-da7d-08d8ea2cfe3d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2021 16:43:44.0291 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZBOJGPGLMMmHn4cbPA/mpgkYAwD964h4227D/0hQ6wkaz1Hc4OWTYdDSFtLCIi36lrXnRuzI4JR+gsQ2kC3kQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3673 X-OriginatorOrg: citrix.com Just took a quick look at it. On Mon, Mar 15, 2021 at 11:18:13PM -0400, Daniel P. Smith wrote: > + +---------------+-----------+------------+-----------+-------------+---------------------+ > + | **Xen Dom0** | **Linux** | **Late** | **Jail** | **Xen** | **Xen Hyperlaunch** | > + | **(Classic)** | **KVM** | **HW Dom** | **house** | **dom0less**+---------+-----------+ > + | | | | | | Static | Dynamic | > + +===============+===========+============+===========+=============+=========+===========+ > + | Hypervisor able to launch multiple VMs during host boot | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | | | | Y | Y | Y | Y | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | Hypervisor supports Static Partitioning | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | | | | Y | Y | Y | | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | Able to launch VMs dynamically after host boot | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | Y | Y | Y* | Y | Y* | | Y | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | Supports strong isolation between all VMs started at host boot | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | | | | Y | Y | Y | Y | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | Enables flexible sequencing of VM start during host boot | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | | | | | | Y | Y | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | Prevent all-powerful static root domain being launched at boot | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | | | | | Y* | Y | Y | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | Operates without a Highly-privileged management VM (eg. Dom0) | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | | | Y* | | Y* | Y | Y | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | Operates without a privileged toolstack VM (Control Domain) | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | | | | | Y* | Y | | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | Extensible VM configuration applied before launch of VMs at host boot | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | | | | | | Y | Y | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | Flexible granular assignment of permissions and functions to VMs | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | | | | | | Y | Y | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | Supports extensible VM measurement architecture for DRTM and attestation | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | | | | | | Y | Y | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | PCI passthrough configured at host boot | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > + | | | | | | Y | Y | > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ I'm curious about this, I assume this is done using vPCI so that there's no hardware domain (and user-space device model) involved for PCI passthrough? I'm also not sure how you are going to handle things like SR-IOV devices. Right now SR-IOV capability is setup and initialized by the hardware domain, and the new virtual devices are notified to Xen once setup is done. Do you plan to move those bits into Xen, so that it can setup and initialize the SR-IOV capability? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 18 18:11:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 18:11:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99083.188211 (Exim 4.92) (envelope-from ) id 1lMx73-00055q-4P; Thu, 18 Mar 2021 18:11:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99083.188211; Thu, 18 Mar 2021 18:11:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMx73-00055j-1R; Thu, 18 Mar 2021 18:11:13 +0000 Received: by outflank-mailman (input) for mailman id 99083; Thu, 18 Mar 2021 18:11:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMx72-00055e-GK for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 18:11:12 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id caa166a9-0f2e-416c-98a2-30e6e038449b; Thu, 18 Mar 2021 18:11:10 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2F58EAD20; Thu, 18 Mar 2021 18:11:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: caa166a9-0f2e-416c-98a2-30e6e038449b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616091069; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kkc/RK+p1Y/q0jZSgtqnTJ/NDIsKZRV/Pu/ANVA5xKI=; b=nyybdpi1hcefqi14lds6E6oVike9vicrbtUGkzAfr+9OIwQlPc7DUTZaSfySH+IwzNCuge yQ9jPis+Qwa93Z0cePrb35P397QnmpXBsNaofgUF5jKkJTsfy83TpX2JyQsbpQECZp/u7/ yErg/JUdMmEsjcO4InKi2z/E75/YoUw= Message-ID: Subject: Re: [ANNOUNCE] Xen 4.15 release update - still in feature freeze From: Dario Faggioli To: Ian Jackson , committers@xenproject.org, xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?ISO-8859-1?Q?Fr=E9d=E9ric?= Pierret , George Dunlap Date: Thu, 18 Mar 2021 19:11:07 +0100 In-Reply-To: <24655.20609.834996.744652@mariner.uk.xensource.com> References: <24655.20609.834996.744652@mariner.uk.xensource.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-a1wSd6wZ38TPP0U8OQ5q" User-Agent: Evolution 3.38.4 (by Flathub.org) MIME-Version: 1.0 --=-a1wSd6wZ38TPP0U8OQ5q Content-Type: multipart/mixed; boundary="=-cpQTGjAn1Xhh+dvzwC6L" --=-cpQTGjAn1Xhh+dvzwC6L Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable [Adding George, since it's scheduling] On Mon, 2021-03-15 at 12:18 +0000, Ian Jackson wrote: >=20 > OPEN ISSUES AND BLOCKERS > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > [...] >=20 > SCHEDULER ISSUES NOT MAKING PROCESS ? > ------------------------------------- >=20 Yeah... let's try. > BUG: credit=3Dsched2 machine hang when using DRAKVUF >=20 > Information from > =C2=A0 Dario Faggioli > References > =C2=A0 https://lists.xen.org/archives/html/xen-devel/2020-05/msg01985.htm= l > =C2=A0 =20 > https://lists.xenproject.org/archives/html/xen-devel/2020-10/msg01561.htm= l > =C2=A0 https://bugzilla.opensuse.org/show_bug.cgi?id=3D1179246 >=20 So, this is mostly about the third issue, the one described in the openSUSE bug, which was however also reported here, by different people. As I've just wrote there (on the bug), I've been working on trying to reproduce the problem on a variety of different machines. Seems AMD seemed to be the most impacted, I've lately focused on hardware from such vendor. I have been, however, unable to re-create a situation where the symptoms described in the reports occur. I specifically looked for hardware that was the same, or similar enough, and I replayed the dom0 vcpu pinning configuration and the creation of domUs, both PV and HVM, but the problem did not show up for me. The only difference between what I've done so far and what is described, e.g., in the bug is that I've not been able to check Windows guests yet. (I'll try that as soon as I can, but if this would really be a scheduling issue, which OS runs in the guest should not really matter much, I think). Code inspection for something that comes from and/or affects the scheduler and is both: - CPU-vendor specific, and - guest-type specific also led me pretty much nowhere. I produced a debug patch (I attach two versions of it, one for staging and one for v4.13.2) that should help me tell whether or not the scheduler is being invoked every time it should be and whether or not there are vcpus that manages to run for longer than how the scheduler would want them to. But as you can imagine, a debug patch is not really helpful if it can't be used within the scenario it is meant to debug, i.e., without a reproducer. I did manage to find an actual bug in Credit2, but that's totally unrelated to the problem at hand (and that will hence be discussed in another email). So, that's the status. I definitely was hoping for things to be better at this point of the release cycle. Sorry they're not. And of course I'll keep digging, but unless I find a way to reproduce, I don't expect big breakthrough. :-/ > G. Null scheduler and vwfi native problem >=20 > Information from > =C2=A0 Dario Faggioli >=20 > References > =C2=A0 =20 > https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg01634.htm= l >=20 > Quoting Dario: > > RCU issues, but manifests due to scheduler behavior (especially=C2=A0= =C2=A0=20 > > NULL scheduler, especially on ARM). > >=20 > > Patches that should solve the issue for ARM posted already. They > > will need to be slightly adjusted to cover x86 as well. >=20 > As of last update from Dario 29.1.21: > waiting for test report from submitter. >=20 For this, I made progress toward making an actual patch that works for both ARM and x86, but I've been sidetracked by a number of things, and have not finished it. The ARM-only fix has been tested successfully and would be ready already. The full solution may not be ready in time for 4.15. So, I'd say we can either merge the ARM part (ARM is where the issue manifests most of the times and more severely) or wait for a full solution during 4.16 development, which we will then backport. Thanks and Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-cpQTGjAn1Xhh+dvzwC6L Content-Disposition: attachment; filename="xen-sched-suspect-debug.patch" Content-Type: text/x-patch; name="xen-sched-suspect-debug.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 Y29tbWl0IDI3ODMwNWFmZjAzZWRkMzI2MzgyMzc0ZDc3NTc4MjJhMjBkOTZjODYKQXV0aG9yOiBE YXJpbyBGYWdnaW9saSA8ZGZhZ2dpb2xpQHN1c2UuY29tPgpEYXRlOiAgIFR1ZSBNYXIgMiAxOTow MzowNSAyMDIxICswMDAwCgogICAgRGVidWcgcGF0Y2ggZm9yIHN1c3BlY3Qgc2NoZWR1bGVyIGlz c3Vlcy4KICAgIAogICAgU2lnbmVkLW9mZi1ieTogRGFyaW8gRmFnZ2lvbGkgPGRmYWdnaW9saUBz dXNlLmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW50cmFjZS94ZW5hbHl6ZS5jIGIvdG9vbHMv eGVudHJhY2UveGVuYWx5emUuYwppbmRleCBiN2Y0ZTJiZWE4Li44Y2U3MDViZDQ4IDEwMDY0NAot LS0gYS90b29scy94ZW50cmFjZS94ZW5hbHl6ZS5jCisrKyBiL3Rvb2xzL3hlbnRyYWNlL3hlbmFs eXplLmMKQEAgLTc0NDAsNiArNzQ0MCwxNyBAQCB2b2lkIHNjaGVkX3Byb2Nlc3Moc3RydWN0IHBj cHVfaW5mbyAqcCkKICAgICAgICAgLyogVFJDX1NDSEVEX1ZFUkJPU0UgKi8KICAgICAgICAgc3dp dGNoKHJpLT5ldmVudCkKICAgICAgICAgeworICAgICAgICBjYXNlIFRSQ19TQ0hFRF9NQVhfSU5U UlY6CisgICAgICAgICAgICBpZihvcHQuZHVtcF9hbGwpIHsKKyAgICAgICAgICAgICAgICBzdHJ1 Y3QgeworICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZG9taWQsIHZjcHVpZDsKKyAg ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGludGVydiwgdGltZSwgbGFzdDsKKyAgICAg ICAgICAgICAgICB9ICpyID0gKHR5cGVvZihyKSlyaS0+ZDsKKworICAgICAgICAgICAgICAgIHBy aW50ZigiICVzIHNjaGVkX21heF9pbnRlcnYgJXUgdXNlY3MsIGF0ICV1IHVzZWNzIHdpdGggZCV1 diV1IChsYXN0OiAldSB1c2VjcylcbiIsCisgICAgICAgICAgICAgICAgICAgICAgIHJpLT5kdW1w X2hlYWRlciwgci0+aW50ZXJ2LCByLT50aW1lLCByLT5kb21pZCwgci0+dmNwdWlkLCByLT5sYXN0 KTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIFRSQ19T Q0hFRF9ET01fQUREOgogICAgICAgICAgICAgaWYob3B0LmR1bXBfYWxsKSB7CiAgICAgICAgICAg ICAgICAgc3RydWN0IHsKQEAgLTc5MDQsNiArNzkxNSwxOCBAQCB2b2lkIHNjaGVkX3Byb2Nlc3Mo c3RydWN0IHBjcHVfaW5mbyAqcCkKICAgICAgICAgICAgICAgICAgICAgICAgcmktPmR1bXBfaGVh ZGVyLCByLT5kb21pZCwgci0+dmNwdWlkKTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGJy ZWFrOworICAgICAgICBjYXNlIFRSQ19TQ0hFRF9DTEFTU19FVlQoQ1NDSEVEMiwgMjQpOgorICAg ICAgICAgICAgaWYob3B0LmR1bXBfYWxsKSB7CisgICAgICAgICAgICAgICAgc3RydWN0IHsKKyAg ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGRvbWlkLCB2Y3B1aWQ7CisgICAgICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGludCBsaW1pdHMsIG5vdywgZXhlYzsKKyAgICAgICAgICAgICAg ICB9ICpyID0gKHR5cGVvZihyKSlyaS0+ZDsKKworICAgICAgICAgICAgICAgIHByaW50ZigiICVz IGNzY2hlZDI6bGltaXRfY3JlZGl0X2xvc3NbIyV1XSBkJXV2JXUsIGF0ICV1LCBleGVjJ2QgJXUg dXNlY3MhXG4iLAorICAgICAgICAgICAgICAgICAgICAgICByaS0+ZHVtcF9oZWFkZXIsIHItPmxp bWl0cywgci0+ZG9taWQsIHItPnZjcHVpZCwgci0+bm93LCByLT5leGVjKTsKKyAgICAgICAgICAg IH0KKyAgICAgICAgICAgIGJyZWFrOworCiAgICAgICAgIC8qIFJURFMgKFRSQ19SVERTX3h4eCkg Ki8KICAgICAgICAgY2FzZSBUUkNfU0NIRURfQ0xBU1NfRVZUKFJURFMsIDEpOiAvKiBUSUNLTEUg ICAgICAgICAgICovCiAgICAgICAgICAgICBpZihvcHQuZHVtcF9hbGwpIHsKZGlmZiAtLWdpdCBh L3hlbi9jb21tb24vc2NoZWQvY29yZS5jIGIveGVuL2NvbW1vbi9zY2hlZC9jb3JlLmMKaW5kZXgg NmQzNDc2NGQzOC4uYTg4ZTJhMWQwZiAxMDA2NDQKLS0tIGEveGVuL2NvbW1vbi9zY2hlZC9jb3Jl LmMKKysrIGIveGVuL2NvbW1vbi9zY2hlZC9jb3JlLmMKQEAgLTI2MjcsNiArMjYyNywxMiBAQCBz dGF0aWMgdm9pZCBzY2hlZF9zbGF2ZSh2b2lkKQogICAgICAgICAgICAgICAgICAgICAgICAgIGlz X2lkbGVfdW5pdChuZXh0KSAmJiAhaXNfaWRsZV91bml0KHByZXYpLCBub3cpOwogfQogCitzdGF0 aWMgREVGSU5FX1BFUl9DUFUoc190aW1lX3QsIGxhc3Rfc2NoZWRfdGltZSk7CitzdGF0aWMgREVG SU5FX1BFUl9DUFUoc190aW1lX3QsIGxhc3Rfc2NoZWRfaW50ZXJ2YWwpOworc3RhdGljIERFRklO RV9QRVJfQ1BVKHNfdGltZV90LCBtYXhfc2NoZWRfaW50ZXJ2YWwpOworc3RhdGljIERFRklORV9Q RVJfQ1BVKHNfdGltZV90LCBtYXhfc2NoZWRfdGltZSk7CitzdGF0aWMgREVGSU5FX1BFUl9DUFUo c3RydWN0IHZjcHUgKiwgbWF4X3NjaGVkX2ludGVydl92cHJldik7CisKIC8qCiAgKiBUaGUgbWFp biBmdW5jdGlvbgogICogLSBkZXNjaGVkdWxlIHRoZSBjdXJyZW50IGRvbWFpbiAoc2NoZWR1bGVy IGluZGVwZW5kZW50KS4KQEAgLTI2NDEsNiArMjY0Nyw3IEBAIHN0YXRpYyB2b2lkIHNjaGVkdWxl KHZvaWQpCiAgICAgc3BpbmxvY2tfdCAgICAgICAgICAgKmxvY2s7CiAgICAgaW50IGNwdSA9IHNt cF9wcm9jZXNzb3JfaWQoKTsKICAgICB1bnNpZ25lZCBpbnQgICAgICAgICAgZ3JhbjsKKyAgICBz X3RpbWVfdCAgICAgICAgICAgICAgc2NoZWRfaW50ZXJ2YWw7CiAKICAgICBBU1NFUlRfTk9UX0lO X0FUT01JQygpOwogCkBAIC0yNjUwLDYgKzI2NTcsMjEgQEAgc3RhdGljIHZvaWQgc2NoZWR1bGUo dm9pZCkKIAogICAgIGxvY2sgPSBwY3B1X3NjaGVkdWxlX2xvY2tfaXJxKGNwdSk7CiAKKyAgICBu b3cgPSBOT1coKTsKKworICAgIHNjaGVkX2ludGVydmFsID0gdGhpc19jcHUobGFzdF9zY2hlZF9p bnRlcnZhbCkgPSBub3cgLSB0aGlzX2NwdShsYXN0X3NjaGVkX3RpbWUpOworICAgIGlmICggc2No ZWRfaW50ZXJ2YWwgPiB0aGlzX2NwdShtYXhfc2NoZWRfaW50ZXJ2YWwpICkKKyAgICB7CisgICAg ICAgIHRoaXNfY3B1KG1heF9zY2hlZF9pbnRlcnZhbCkgPSBzY2hlZF9pbnRlcnZhbDsKKyAgICAg ICAgdGhpc19jcHUobWF4X3NjaGVkX2ludGVydl92cHJldikgPSB2cHJldjsKKwl0aGlzX2NwdSht YXhfc2NoZWRfdGltZSkgPSBub3c7CisgICAgICAgIFRSQUNFXzVEKFRSQ19TQ0hFRF9NQVhfSU5U UlYsIHZwcmV2LT5kb21haW4tPmRvbWFpbl9pZCwgdnByZXYtPnZjcHVfaWQsCisgICAgICAgICAg ICAgICAgICh1aW50MzJfdCkodGhpc19jcHUobWF4X3NjaGVkX2ludGVydmFsKSAvIE1JQ1JPU0VD UygxKSksCisJCSAodWludDMyX3QpKHRoaXNfY3B1KG1heF9zY2hlZF90aW1lKSAvIE1JQ1JPU0VD UygxKSksCisgICAgICAgICAgICAgICAgICh1aW50MzJfdCkodGhpc19jcHUobGFzdF9zY2hlZF9p bnRlcnZhbCkgLyBNSUNST1NFQ1MoMSkpKTsKKyAgICB9CisgICAgdGhpc19jcHUobGFzdF9zY2hl ZF90aW1lKSA9IG5vdzsKKwogICAgIHNyID0gZ2V0X3NjaGVkX3JlcyhjcHUpOwogICAgIGdyYW4g PSBzci0+Z3JhbnVsYXJpdHk7CiAKQEAgLTI2NjksOCArMjY5MSw2IEBAIHN0YXRpYyB2b2lkIHNj aGVkdWxlKHZvaWQpCiAKICAgICBzdG9wX3RpbWVyKCZzci0+c190aW1lcik7CiAKLSAgICBub3cg PSBOT1coKTsKLQogICAgIGlmICggZ3JhbiA+IDEgKQogICAgIHsKICAgICAgICAgY3B1bWFza190 ICptYXNrID0gY3B1bWFza19zY3JhdGNoX2NwdShjcHUpOwpAQCAtMzM2NSw2ICszMzg1LDEyIEBA IHZvaWQgc2NoZWR1bGVfZHVtcChzdHJ1Y3QgY3B1cG9vbCAqYykKICAgICAgICAgcHJpbnRrKCJD UFVbJTAyZF0gY3VycmVudD0lcHYsIGN1cnI9JXB2LCBwcmV2PSVwdlxuIiwgaSwKICAgICAgICAg ICAgICAgIGdldF9jcHVfY3VycmVudChpKSwgc3ItPmN1cnIgPyBzci0+Y3Vyci0+dmNwdV9saXN0 IDogTlVMTCwKICAgICAgICAgICAgICAgIHNyLT5wcmV2ID8gc3ItPnByZXYtPnZjcHVfbGlzdCA6 IE5VTEwpOworICAgICAgICBwcmludGsoIlx0bGFzdCBzY2hlZHVsZTogJSJQUklfc3RpbWUiLCBs YXN0X2ludGVydmFsPSUiUFJJX3N0aW1lIiwgIgorICAgICAgICAgICAgICAgIm1heF9pbnRlcnZh bD0lIlBSSV9zdGltZSIgYXQgJSJQUklfc3RpbWUiIChhZnRlciBydW5uaW5nICVwdilcbiIsCisg ICAgICAgICAgICAgICBwZXJfY3B1KGxhc3Rfc2NoZWRfdGltZSwgaSksIHBlcl9jcHUobGFzdF9z Y2hlZF9pbnRlcnZhbCwgaSksCisgICAgICAgICAgICAgICBwZXJfY3B1KG1heF9zY2hlZF9pbnRl cnZhbCwgaSksIHBlcl9jcHUobWF4X3NjaGVkX3RpbWUsIGkpLAorCSAgICAgICBwZXJfY3B1KG1h eF9zY2hlZF9pbnRlcnZfdnByZXYsIGkpKTsKKyAgICAgICAgICAgICAgIHBlcl9jcHUobWF4X3Nj aGVkX2ludGVydmFsLCBpKSA9IDA7CiAgICAgICAgIGZvcl9lYWNoX2NwdSAoaiwgc3ItPmNwdXMp CiAgICAgICAgICAgICBpZiAoIGkgIT0gaiApCiAgICAgICAgICAgICAgICAgcHJpbnRrKCJDUFVb JTAyZF0gY3VycmVudD0lcHZcbiIsIGosIGdldF9jcHVfY3VycmVudChqKSk7CmRpZmYgLS1naXQg YS94ZW4vY29tbW9uL3NjaGVkL2NyZWRpdDIuYyBiL3hlbi9jb21tb24vc2NoZWQvY3JlZGl0Mi5j CmluZGV4IGViNWU1YTc4YzUuLjQyNjNiNjdmMjMgMTAwNjQ0Ci0tLSBhL3hlbi9jb21tb24vc2No ZWQvY3JlZGl0Mi5jCisrKyBiL3hlbi9jb21tb24vc2NoZWQvY3JlZGl0Mi5jCkBAIC02MSw2ICs2 MSw3IEBACiAjZGVmaW5lIFRSQ19DU0NIRUQyX1NDSEVEVUxFICAgICAgICAgVFJDX1NDSEVEX0NM QVNTX0VWVChDU0NIRUQyLCAyMSkKICNkZWZpbmUgVFJDX0NTQ0hFRDJfUkFURUxJTUlUICAgICAg ICBUUkNfU0NIRURfQ0xBU1NfRVZUKENTQ0hFRDIsIDIyKQogI2RlZmluZSBUUkNfQ1NDSEVEMl9S VU5RX0NBTkRfQ0hFQ0sgIFRSQ19TQ0hFRF9DTEFTU19FVlQoQ1NDSEVEMiwgMjMpCisjZGVmaW5l IFRSQ19DU0NIRUQyX0xJTUlUX0NSRURJVFMgICAgVFJDX1NDSEVEX0NMQVNTX0VWVChDU0NIRUQy LCAyNCkKIAogLyoKICAqIFRPRE86CkBAIC03OTgsNiArNzk5LDExIEBAIHN0YXRpYyBpbnQgZ2V0 X2ZhbGxiYWNrX2NwdShzdHJ1Y3QgY3NjaGVkMl91bml0ICpzdmMpCiAgICAgcmV0dXJuIGNwdW1h c2tfYW55KGNwdW1hc2tfc2NyYXRjaF9jcHUoc2NoZWRfdW5pdF9tYXN0ZXIodW5pdCkpKTsKIH0K IAorc3RhdGljIERFRklORV9QRVJfQ1BVKHVuc2lnbmVkIGludCwgbGltaXRfY3JlZGl0cyk7Citz dGF0aWMgREVGSU5FX1BFUl9DUFUoc190aW1lX3QsIGxpbWl0X2NyZWRpdHNfdGltZSk7CitzdGF0 aWMgREVGSU5FX1BFUl9DUFUoc190aW1lX3QsIGxpbWl0X2NyZWRpdHNfZXhlYyk7CitzdGF0aWMg REVGSU5FX1BFUl9DUFUoc3RydWN0IHNjaGVkX3VuaXQgKiwgbGltaXRfY3JlZGl0c191bml0KTsK KwogLyoKICAqIFRpbWUtdG8tY3JlZGl0LCBjcmVkaXQtdG8tdGltZS4KICAqCkBAIC04MTUsNyAr ODIxLDE3IEBAIHN0YXRpYyB2b2lkIHQyY191cGRhdGUoY29uc3Qgc3RydWN0IGNzY2hlZDJfcnVu cXVldWVfZGF0YSAqcnFkLCBzX3RpbWVfdCB0aW1lLAogICAgIC8qIEdldHRpbmcgdG8gbG93ZXIg Y3JlZGl0IHRoYW4gQ1NDSEVEMl9DUkVESVRfTUlOIG1ha2VzIG5vIHNlbnNlLiAqLwogICAgIHZh bCA9IHN2Yy0+Y3JlZGl0IC0gdmFsOwogICAgIGlmICggdW5saWtlbHkodmFsIDwgQ1NDSEVEMl9D UkVESVRfTUlOKSApCisgICAgeworICAgICAgICB0aGlzX2NwdShsaW1pdF9jcmVkaXRzKSsrOwor ICAgICAgICB0aGlzX2NwdShsaW1pdF9jcmVkaXRzX3RpbWUpID0gTk9XKCk7CisgICAgICAgIHRo aXNfY3B1KGxpbWl0X2NyZWRpdHNfZXhlYykgPSB0aW1lOworICAgICAgICB0aGlzX2NwdShsaW1p dF9jcmVkaXRzX3VuaXQpID0gc3ZjLT51bml0OworICAgICAgICBUUkFDRV81RChUUkNfQ1NDSEVE Ml9MSU1JVF9DUkVESVRTLCBzdmMtPnVuaXQtPmRvbWFpbi0+ZG9tYWluX2lkLAorICAgICAgICAg ICAgICAgICBzdmMtPnVuaXQtPnVuaXRfaWQsIHRoaXNfY3B1KGxpbWl0X2NyZWRpdHMpLAorICAg ICAgICAgICAgICAgICAodWludDMyX3QpKHRoaXNfY3B1KGxpbWl0X2NyZWRpdHNfdGltZSkvTUlD Uk9TRUNTKDEpKSwKKyAgICAgICAgICAgICAgICAgKHVpbnQzMl90KSh0aGlzX2NwdShsaW1pdF9j cmVkaXRzX2V4ZWMpL01JQ1JPU0VDUygxKSkpOwogICAgICAgICBzdmMtPmNyZWRpdCA9IENTQ0hF RDJfQ1JFRElUX01JTjsKKyAgICB9CiAgICAgZWxzZQogICAgICAgICBzdmMtPmNyZWRpdCA9IHZh bDsKIH0KQEAgLTM3NTcsNiArMzc3MywxMiBAQCBkdW1wX3BjcHUoY29uc3Qgc3RydWN0IHNjaGVk dWxlciAqb3BzLCBpbnQgY3B1KQogICAgICAgICAgICBjcHUsIGMycihjcHUpLAogICAgICAgICAg ICBDUFVNQVNLX1BSKHBlcl9jcHUoY3B1X3NpYmxpbmdfbWFzaywgY3B1KSksCiAgICAgICAgICAg IENQVU1BU0tfUFIocGVyX2NwdShjcHVfY29yZV9tYXNrLCBjcHUpKSk7CisgICAgaWYgKCBwZXJf Y3B1KGxpbWl0X2NyZWRpdHNfdW5pdCwgY3B1KSAhPSBOVUxMICkgeworICAgICAgICBwcmludGso Ilx0Q3JlZGl0IGxpbWl0ZWQ6ICMldSwgbGFzdCBhdCAlIlBSSV9zdGltZSIgYXMgZCV1diV1IGV4 ZWMnZCAlIlBSSV9zdGltZSJcbiIsCisgICAgICAgICAgICAgICBwZXJfY3B1KGxpbWl0X2NyZWRp dHMsIGNwdSksIHBlcl9jcHUobGltaXRfY3JlZGl0c190aW1lLCBjcHUpLAorICAgICAgICAgICAg ICAgcGVyX2NwdShsaW1pdF9jcmVkaXRzX3VuaXQsIGNwdSktPmRvbWFpbi0+ZG9tYWluX2lkLAor ICAgICAgICAgICAgICAgcGVyX2NwdShsaW1pdF9jcmVkaXRzX3VuaXQsIGNwdSktPnVuaXRfaWQs IHBlcl9jcHUobGltaXRfY3JlZGl0c19leGVjLCBjcHUpKTsKKyAgICB9CiAKICAgICAvKiBjdXJy ZW50IFVOSVQgKG5vdGhpbmcgdG8gc2F5IGlmIHRoYXQncyB0aGUgaWRsZSB1bml0KSAqLwogICAg IHN2YyA9IGNzY2hlZDJfdW5pdChjdXJyX29uX2NwdShjcHUpKTsKZGlmZiAtLWdpdCBhL3hlbi9p bmNsdWRlL3B1YmxpYy90cmFjZS5oIGIveGVuL2luY2x1ZGUvcHVibGljL3RyYWNlLmgKaW5kZXgg ZDVmYTRhZWE4ZC4uNWIzZmFmMGZkNSAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvcHVibGljL3Ry YWNlLmgKKysrIGIveGVuL2luY2x1ZGUvcHVibGljL3RyYWNlLmgKQEAgLTExNyw2ICsxMTcsNyBA QAogI2RlZmluZSBUUkNfU0NIRURfU1dJVENIX0lORk5FWFQgKFRSQ19TQ0hFRF9WRVJCT1NFICsg MTUpCiAjZGVmaW5lIFRSQ19TQ0hFRF9TSFVURE9XTl9DT0RFICAoVFJDX1NDSEVEX1ZFUkJPU0Ug KyAxNikKICNkZWZpbmUgVFJDX1NDSEVEX1NXSVRDSF9JTkZDT05UIChUUkNfU0NIRURfVkVSQk9T RSArIDE3KQorI2RlZmluZSBUUkNfU0NIRURfTUFYX0lOVFJWICAgICAgKFRSQ19TQ0hFRF9WRVJC T1NFICsgMTgpCiAKICNkZWZpbmUgVFJDX0RPTTBfRE9NX0FERCAgICAgICAgIChUUkNfRE9NMF9E T01PUFMgKyAxKQogI2RlZmluZSBUUkNfRE9NMF9ET01fUkVNICAgICAgICAgKFRSQ19ET00wX0RP TU9QUyArIDIpCg== --=-cpQTGjAn1Xhh+dvzwC6L Content-Disposition: attachment; filename="xen-sched-suspect-debug_4.13.2.patch" Content-Type: text/x-patch; name="xen-sched-suspect-debug_4.13.2.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 Y29tbWl0IDBmOGVmOGYyMzcxOGNjMjRiMGJjOTU4OTc5YWE3ODliZTRlZDg5ZDUKQXV0aG9yOiBE YXJpbyBGYWdnaW9saSA8ZGZhZ2dpb2xpQHN1c2UuY29tPgpEYXRlOiAgIFR1ZSBNYXIgMiAxOTow MzowNSAyMDIxICswMDAwCgogICAgRGVidWcgcGF0Y2ggZm9yIHN1c3BlY3Qgc2NoZWR1bGVyIGlz c3Vlcy4KICAgIAogICAgU2lnbmVkLW9mZi1ieTogRGFyaW8gRmFnZ2lvbGkgPGRmYWdnaW9saUBz dXNlLmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW50cmFjZS94ZW5hbHl6ZS5jIGIvdG9vbHMv eGVudHJhY2UveGVuYWx5emUuYwppbmRleCBiN2Y0ZTJiZWE4Li44Y2U3MDViZDQ4IDEwMDY0NAot LS0gYS90b29scy94ZW50cmFjZS94ZW5hbHl6ZS5jCisrKyBiL3Rvb2xzL3hlbnRyYWNlL3hlbmFs eXplLmMKQEAgLTc0NDAsNiArNzQ0MCwxNyBAQCB2b2lkIHNjaGVkX3Byb2Nlc3Moc3RydWN0IHBj cHVfaW5mbyAqcCkKICAgICAgICAgLyogVFJDX1NDSEVEX1ZFUkJPU0UgKi8KICAgICAgICAgc3dp dGNoKHJpLT5ldmVudCkKICAgICAgICAgeworICAgICAgICBjYXNlIFRSQ19TQ0hFRF9NQVhfSU5U UlY6CisgICAgICAgICAgICBpZihvcHQuZHVtcF9hbGwpIHsKKyAgICAgICAgICAgICAgICBzdHJ1 Y3QgeworICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZG9taWQsIHZjcHVpZDsKKyAg ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGludGVydiwgdGltZSwgbGFzdDsKKyAgICAg ICAgICAgICAgICB9ICpyID0gKHR5cGVvZihyKSlyaS0+ZDsKKworICAgICAgICAgICAgICAgIHBy aW50ZigiICVzIHNjaGVkX21heF9pbnRlcnYgJXUgdXNlY3MsIGF0ICV1IHVzZWNzIHdpdGggZCV1 diV1IChsYXN0OiAldSB1c2VjcylcbiIsCisgICAgICAgICAgICAgICAgICAgICAgIHJpLT5kdW1w X2hlYWRlciwgci0+aW50ZXJ2LCByLT50aW1lLCByLT5kb21pZCwgci0+dmNwdWlkLCByLT5sYXN0 KTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIFRSQ19T Q0hFRF9ET01fQUREOgogICAgICAgICAgICAgaWYob3B0LmR1bXBfYWxsKSB7CiAgICAgICAgICAg ICAgICAgc3RydWN0IHsKQEAgLTc5MDQsNiArNzkxNSwxOCBAQCB2b2lkIHNjaGVkX3Byb2Nlc3Mo c3RydWN0IHBjcHVfaW5mbyAqcCkKICAgICAgICAgICAgICAgICAgICAgICAgcmktPmR1bXBfaGVh ZGVyLCByLT5kb21pZCwgci0+dmNwdWlkKTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGJy ZWFrOworICAgICAgICBjYXNlIFRSQ19TQ0hFRF9DTEFTU19FVlQoQ1NDSEVEMiwgMjQpOgorICAg ICAgICAgICAgaWYob3B0LmR1bXBfYWxsKSB7CisgICAgICAgICAgICAgICAgc3RydWN0IHsKKyAg ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGRvbWlkLCB2Y3B1aWQ7CisgICAgICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGludCBsaW1pdHMsIG5vdywgZXhlYzsKKyAgICAgICAgICAgICAg ICB9ICpyID0gKHR5cGVvZihyKSlyaS0+ZDsKKworICAgICAgICAgICAgICAgIHByaW50ZigiICVz IGNzY2hlZDI6bGltaXRfY3JlZGl0X2xvc3NbIyV1XSBkJXV2JXUsIGF0ICV1LCBleGVjJ2QgJXUg dXNlY3MhXG4iLAorICAgICAgICAgICAgICAgICAgICAgICByaS0+ZHVtcF9oZWFkZXIsIHItPmxp bWl0cywgci0+ZG9taWQsIHItPnZjcHVpZCwgci0+bm93LCByLT5leGVjKTsKKyAgICAgICAgICAg IH0KKyAgICAgICAgICAgIGJyZWFrOworCiAgICAgICAgIC8qIFJURFMgKFRSQ19SVERTX3h4eCkg Ki8KICAgICAgICAgY2FzZSBUUkNfU0NIRURfQ0xBU1NfRVZUKFJURFMsIDEpOiAvKiBUSUNLTEUg ICAgICAgICAgICovCiAgICAgICAgICAgICBpZihvcHQuZHVtcF9hbGwpIHsKZGlmZiAtLWdpdCBh L3hlbi9jb21tb24vc2NoZWRfY3JlZGl0Mi5jIGIveGVuL2NvbW1vbi9zY2hlZF9jcmVkaXQyLmMK aW5kZXggY2U3YzU2MTQ3Yi4uMjlhYTk5ZGI4NiAxMDA2NDQKLS0tIGEveGVuL2NvbW1vbi9zY2hl ZF9jcmVkaXQyLmMKKysrIGIveGVuL2NvbW1vbi9zY2hlZF9jcmVkaXQyLmMKQEAgLTU3LDYgKzU3 LDcgQEAKICNkZWZpbmUgVFJDX0NTQ0hFRDJfU0NIRURVTEUgICAgICAgICBUUkNfU0NIRURfQ0xB U1NfRVZUKENTQ0hFRDIsIDIxKQogI2RlZmluZSBUUkNfQ1NDSEVEMl9SQVRFTElNSVQgICAgICAg IFRSQ19TQ0hFRF9DTEFTU19FVlQoQ1NDSEVEMiwgMjIpCiAjZGVmaW5lIFRSQ19DU0NIRUQyX1JV TlFfQ0FORF9DSEVDSyAgVFJDX1NDSEVEX0NMQVNTX0VWVChDU0NIRUQyLCAyMykKKyNkZWZpbmUg VFJDX0NTQ0hFRDJfTElNSVRfQ1JFRElUUyAgICBUUkNfU0NIRURfQ0xBU1NfRVZUKENTQ0hFRDIs IDI0KQogCiAvKgogICogVE9ETzoKQEAgLTc3NSw2ICs3NzYsMTEgQEAgc3RhdGljIGludCBnZXRf ZmFsbGJhY2tfY3B1KHN0cnVjdCBjc2NoZWQyX3VuaXQgKnN2YykKICAgICByZXR1cm4gY3B1bWFz a19hbnkoY3B1bWFza19zY3JhdGNoX2NwdShzY2hlZF91bml0X21hc3Rlcih1bml0KSkpOwogfQog CitzdGF0aWMgREVGSU5FX1BFUl9DUFUodW5zaWduZWQgaW50LCBsaW1pdF9jcmVkaXRzKTsKK3N0 YXRpYyBERUZJTkVfUEVSX0NQVShzX3RpbWVfdCwgbGltaXRfY3JlZGl0c190aW1lKTsKK3N0YXRp YyBERUZJTkVfUEVSX0NQVShzX3RpbWVfdCwgbGltaXRfY3JlZGl0c19leGVjKTsKK3N0YXRpYyBE RUZJTkVfUEVSX0NQVShzdHJ1Y3Qgc2NoZWRfdW5pdCAqLCBsaW1pdF9jcmVkaXRzX3VuaXQpOwor CiAvKgogICogVGltZS10by1jcmVkaXQsIGNyZWRpdC10by10aW1lLgogICoKQEAgLTc5Miw3ICs3 OTgsMTcgQEAgc3RhdGljIHZvaWQgdDJjX3VwZGF0ZShzdHJ1Y3QgY3NjaGVkMl9ydW5xdWV1ZV9k YXRhICpycWQsIHNfdGltZV90IHRpbWUsCiAgICAgLyogR2V0dGluZyB0byBsb3dlciBjcmVkaXQg dGhhbiBDU0NIRUQyX0NSRURJVF9NSU4gbWFrZXMgbm8gc2Vuc2UuICovCiAgICAgdmFsID0gc3Zj LT5jcmVkaXQgLSB2YWw7CiAgICAgaWYgKCB1bmxpa2VseSh2YWwgPCBDU0NIRUQyX0NSRURJVF9N SU4pICkKKyAgICB7CisgICAgICAgIHRoaXNfY3B1KGxpbWl0X2NyZWRpdHMpKys7CisgICAgICAg IHRoaXNfY3B1KGxpbWl0X2NyZWRpdHNfdGltZSkgPSBOT1coKTsKKyAgICAgICAgdGhpc19jcHUo bGltaXRfY3JlZGl0c19leGVjKSA9IHRpbWU7CisgICAgICAgIHRoaXNfY3B1KGxpbWl0X2NyZWRp dHNfdW5pdCkgPSBzdmMtPnVuaXQ7CisgICAgICAgIFRSQUNFXzVEKFRSQ19DU0NIRUQyX0xJTUlU X0NSRURJVFMsIHN2Yy0+dW5pdC0+ZG9tYWluLT5kb21haW5faWQsCisgICAgICAgICAgICAgICAg IHN2Yy0+dW5pdC0+dW5pdF9pZCwgdGhpc19jcHUobGltaXRfY3JlZGl0cyksCisgICAgICAgICAg ICAgICAgICh1aW50MzJfdCkodGhpc19jcHUobGltaXRfY3JlZGl0c190aW1lKS9NSUNST1NFQ1Mo MSkpLAorICAgICAgICAgICAgICAgICAodWludDMyX3QpKHRoaXNfY3B1KGxpbWl0X2NyZWRpdHNf ZXhlYykvTUlDUk9TRUNTKDEpKSk7CiAgICAgICAgIHN2Yy0+Y3JlZGl0ID0gQ1NDSEVEMl9DUkVE SVRfTUlOOworICAgIH0KICAgICBlbHNlCiAgICAgICAgIHN2Yy0+Y3JlZGl0ID0gdmFsOwogfQpA QCAtMzY2MSw2ICszNjc3LDEyIEBAIGR1bXBfcGNwdShjb25zdCBzdHJ1Y3Qgc2NoZWR1bGVyICpv cHMsIGludCBjcHUpCiAgICAgICAgICAgIGNwdSwgYzJyKGNwdSksCiAgICAgICAgICAgIENQVU1B U0tfUFIocGVyX2NwdShjcHVfc2libGluZ19tYXNrLCBjcHUpKSwKICAgICAgICAgICAgQ1BVTUFT S19QUihwZXJfY3B1KGNwdV9jb3JlX21hc2ssIGNwdSkpKTsKKyAgICBpZiAoIHBlcl9jcHUobGlt aXRfY3JlZGl0c191bml0LCBjcHUpICE9IE5VTEwgKSB7CisgICAgICAgIHByaW50aygiXHRDcmVk aXQgbGltaXRlZDogIyV1LCBsYXN0IGF0ICUiUFJJX3N0aW1lIiBhcyBkJXV2JXUgZXhlYydkICUi UFJJX3N0aW1lIlxuIiwKKyAgICAgICAgICAgICAgIHBlcl9jcHUobGltaXRfY3JlZGl0cywgY3B1 KSwgcGVyX2NwdShsaW1pdF9jcmVkaXRzX3RpbWUsIGNwdSksCisgICAgICAgICAgICAgICBwZXJf Y3B1KGxpbWl0X2NyZWRpdHNfdW5pdCwgY3B1KS0+ZG9tYWluLT5kb21haW5faWQsCisgICAgICAg ICAgICAgICBwZXJfY3B1KGxpbWl0X2NyZWRpdHNfdW5pdCwgY3B1KS0+dW5pdF9pZCwgcGVyX2Nw dShsaW1pdF9jcmVkaXRzX2V4ZWMsIGNwdSkpOworICAgIH0KIAogICAgIC8qIGN1cnJlbnQgVU5J VCAobm90aGluZyB0byBzYXkgaWYgdGhhdCdzIHRoZSBpZGxlIHVuaXQpICovCiAgICAgc3ZjID0g Y3NjaGVkMl91bml0KGN1cnJfb25fY3B1KGNwdSkpOwpkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9z Y2hlZHVsZS5jIGIveGVuL2NvbW1vbi9zY2hlZHVsZS5jCmluZGV4IDZiMWFlN2JmOGMuLjRhOTUw ZjNiNTcgMTAwNjQ0Ci0tLSBhL3hlbi9jb21tb24vc2NoZWR1bGUuYworKysgYi94ZW4vY29tbW9u L3NjaGVkdWxlLmMKQEAgLTIzODUsNiArMjM4NSwxMiBAQCBzdGF0aWMgdm9pZCBzY2hlZF9zbGF2 ZSh2b2lkKQogICAgICAgICAgICAgICAgICAgICAgICAgIGlzX2lkbGVfdW5pdChuZXh0KSAmJiAh aXNfaWRsZV91bml0KHByZXYpLCBub3cpOwogfQogCitzdGF0aWMgREVGSU5FX1BFUl9DUFUoc190 aW1lX3QsIGxhc3Rfc2NoZWRfdGltZSk7CitzdGF0aWMgREVGSU5FX1BFUl9DUFUoc190aW1lX3Qs IGxhc3Rfc2NoZWRfaW50ZXJ2YWwpOworc3RhdGljIERFRklORV9QRVJfQ1BVKHNfdGltZV90LCBt YXhfc2NoZWRfaW50ZXJ2YWwpOworc3RhdGljIERFRklORV9QRVJfQ1BVKHNfdGltZV90LCBtYXhf c2NoZWRfdGltZSk7CitzdGF0aWMgREVGSU5FX1BFUl9DUFUoc3RydWN0IHZjcHUgKiwgbWF4X3Nj aGVkX2ludGVydl92cHJldik7CisKIC8qCiAgKiBUaGUgbWFpbiBmdW5jdGlvbgogICogLSBkZXNj aGVkdWxlIHRoZSBjdXJyZW50IGRvbWFpbiAoc2NoZWR1bGVyIGluZGVwZW5kZW50KS4KQEAgLTIz OTksNiArMjQwNSw3IEBAIHN0YXRpYyB2b2lkIHNjaGVkdWxlKHZvaWQpCiAgICAgc3BpbmxvY2tf dCAgICAgICAgICAgKmxvY2s7CiAgICAgaW50IGNwdSA9IHNtcF9wcm9jZXNzb3JfaWQoKTsKICAg ICB1bnNpZ25lZCBpbnQgICAgICAgICAgZ3JhbjsKKyAgICBzX3RpbWVfdCAgICAgICAgICAgICAg c2NoZWRfaW50ZXJ2YWw7CiAKICAgICBBU1NFUlRfTk9UX0lOX0FUT01JQygpOwogCkBAIC0yNDA4 LDYgKzI0MTUsMjEgQEAgc3RhdGljIHZvaWQgc2NoZWR1bGUodm9pZCkKIAogICAgIGxvY2sgPSBw Y3B1X3NjaGVkdWxlX2xvY2tfaXJxKGNwdSk7CiAKKyAgICBub3cgPSBOT1coKTsKKworICAgIHNj aGVkX2ludGVydmFsID0gdGhpc19jcHUobGFzdF9zY2hlZF9pbnRlcnZhbCkgPSBub3cgLSB0aGlz X2NwdShsYXN0X3NjaGVkX3RpbWUpOworICAgIGlmICggc2NoZWRfaW50ZXJ2YWwgPiB0aGlzX2Nw dShtYXhfc2NoZWRfaW50ZXJ2YWwpICkKKyAgICB7CisgICAgICAgIHRoaXNfY3B1KG1heF9zY2hl ZF9pbnRlcnZhbCkgPSBzY2hlZF9pbnRlcnZhbDsKKyAgICAgICAgdGhpc19jcHUobWF4X3NjaGVk X2ludGVydl92cHJldikgPSB2cHJldjsKKwl0aGlzX2NwdShtYXhfc2NoZWRfdGltZSkgPSBub3c7 CisgICAgICAgIFRSQUNFXzVEKFRSQ19TQ0hFRF9NQVhfSU5UUlYsIHZwcmV2LT5kb21haW4tPmRv bWFpbl9pZCwgdnByZXYtPnZjcHVfaWQsCisgICAgICAgICAgICAgICAgICh1aW50MzJfdCkodGhp c19jcHUobWF4X3NjaGVkX2ludGVydmFsKSAvIE1JQ1JPU0VDUygxKSksCisJCSAodWludDMyX3Qp KHRoaXNfY3B1KG1heF9zY2hlZF90aW1lKSAvIE1JQ1JPU0VDUygxKSksCisgICAgICAgICAgICAg ICAgICh1aW50MzJfdCkodGhpc19jcHUobGFzdF9zY2hlZF9pbnRlcnZhbCkgLyBNSUNST1NFQ1Mo MSkpKTsKKyAgICB9CisgICAgdGhpc19jcHUobGFzdF9zY2hlZF90aW1lKSA9IG5vdzsKKwogICAg IHNyID0gZ2V0X3NjaGVkX3JlcyhjcHUpOwogICAgIGdyYW4gPSBzci0+Z3JhbnVsYXJpdHk7CiAK QEAgLTI0MjcsOCArMjQ0OSw2IEBAIHN0YXRpYyB2b2lkIHNjaGVkdWxlKHZvaWQpCiAKICAgICBz dG9wX3RpbWVyKCZzci0+c190aW1lcik7CiAKLSAgICBub3cgPSBOT1coKTsKLQogICAgIGlmICgg Z3JhbiA+IDEgKQogICAgIHsKICAgICAgICAgY3B1bWFza190IG1hc2s7CkBAIC0zMDg1LDcgKzMx MDUsNyBAQCB2b2lkIHNjaGVkdWxlcl9mcmVlKHN0cnVjdCBzY2hlZHVsZXIgKnNjaGVkKQogCiB2 b2lkIHNjaGVkdWxlX2R1bXAoc3RydWN0IGNwdXBvb2wgKmMpCiB7Ci0gICAgdW5zaWduZWQgaW50 ICAgICAgaTsKKyAgICB1bnNpZ25lZCBpbnQgICAgICBpLGo7CiAgICAgc3RydWN0IHNjaGVkdWxl ciAqc2NoZWQ7CiAgICAgY3B1bWFza190ICAgICAgICAqY3B1czsKIApAQCAtMzEwNiwxMSArMzEy NiwzMCBAQCB2b2lkIHNjaGVkdWxlX2R1bXAoc3RydWN0IGNwdXBvb2wgKmMpCiAgICAgICAgIGNw dXMgPSAmY3B1cG9vbF9mcmVlX2NwdXM7CiAgICAgfQogCi0gICAgaWYgKCBzY2hlZC0+ZHVtcF9j cHVfc3RhdGUgIT0gTlVMTCApCi0gICAgewotICAgICAgICBwcmludGsoIkNQVXMgaW5mbzpcbiIp OwotICAgICAgICBmb3JfZWFjaF9jcHUgKGksIGNwdXMpCi0gICAgICAgICAgICBzY2hlZF9kdW1w X2NwdV9zdGF0ZShzY2hlZCwgaSk7CisgICAgcHJpbnRrKCJDUFVzIGluZm86XG4iKTsKKyAgICBm b3JfZWFjaF9jcHUgKGksIGNwdXMpIHsKKyAgICAgICAgc3RydWN0IHNjaGVkX3Jlc291cmNlICpz ciA9IGdldF9zY2hlZF9yZXMoaSk7CisgICAgICAgIHVuc2lnbmVkIGxvbmcgZmxhZ3M7CisgICAg ICAgIHNwaW5sb2NrX3QgKmxvY2s7CisKKyAgICAgICAgbG9jayA9IHBjcHVfc2NoZWR1bGVfbG9j a19pcnFzYXZlKGksICZmbGFncyk7CisKKyAgICAgICAgcHJpbnRrKCJDUFVbJTAyZF0gY3VycmVu dD0lcHYsIGN1cnI9JXB2LCBwcmV2PSVwdlxuIiwgaSwKKyAgICAgICAgICAgICAgIGdldF9jcHVf Y3VycmVudChpKSwgc3ItPmN1cnIgPyBzci0+Y3Vyci0+dmNwdV9saXN0IDogTlVMTCwKKyAgICAg ICAgICAgICAgIHNyLT5wcmV2ID8gc3ItPnByZXYtPnZjcHVfbGlzdCA6IE5VTEwpOworICAgICAg ICBwcmludGsoIlx0bGFzdCBzY2hlZHVsZTogJSJQUklfc3RpbWUiLCBsYXN0X2ludGVydmFsPSUi UFJJX3N0aW1lIiwgIgorICAgICAgICAgICAgICAgIm1heF9pbnRlcnZhbD0lIlBSSV9zdGltZSIg YXQgJSJQUklfc3RpbWUiIChhZnRlciBydW5uaW5nICVwdilcbiIsCisgICAgICAgICAgICAgICBw ZXJfY3B1KGxhc3Rfc2NoZWRfdGltZSwgaSksIHBlcl9jcHUobGFzdF9zY2hlZF9pbnRlcnZhbCwg aSksCisgICAgICAgICAgICAgICBwZXJfY3B1KG1heF9zY2hlZF9pbnRlcnZhbCwgaSksIHBlcl9j cHUobWF4X3NjaGVkX3RpbWUsIGkpLAorICAgICAgICAgICAgICAgcGVyX2NwdShtYXhfc2NoZWRf aW50ZXJ2X3ZwcmV2LCBpKSk7CisgICAgICAgICAgICAgICBwZXJfY3B1KG1heF9zY2hlZF9pbnRl cnZhbCwgaSkgPSAwOworICAgICAgICBmb3JfZWFjaF9jcHUgKGosIHNyLT5jcHVzKQorICAgICAg ICAgICAgaWYgKCBpICE9IGogKQorICAgICAgICAgICAgICAgIHByaW50aygiQ1BVWyUwMmRdIGN1 cnJlbnQ9JXB2XG4iLCBqLCBnZXRfY3B1X2N1cnJlbnQoaikpOworCisgICAgICAgIHBjcHVfc2No ZWR1bGVfdW5sb2NrX2lycXJlc3RvcmUobG9jaywgZmxhZ3MsIGkpOworCisgICAgICAgIHNjaGVk X2R1bXBfY3B1X3N0YXRlKHNjaGVkLCBpKTsKICAgICB9CiAKICAgICByY3VfcmVhZF91bmxvY2so JnNjaGVkX3Jlc19yY3Vsb2NrKTsKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3B1YmxpYy90cmFj ZS5oIGIveGVuL2luY2x1ZGUvcHVibGljL3RyYWNlLmgKaW5kZXggZDVmYTRhZWE4ZC4uNWIzZmFm MGZkNSAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvcHVibGljL3RyYWNlLmgKKysrIGIveGVuL2lu Y2x1ZGUvcHVibGljL3RyYWNlLmgKQEAgLTExNyw2ICsxMTcsNyBAQAogI2RlZmluZSBUUkNfU0NI RURfU1dJVENIX0lORk5FWFQgKFRSQ19TQ0hFRF9WRVJCT1NFICsgMTUpCiAjZGVmaW5lIFRSQ19T Q0hFRF9TSFVURE9XTl9DT0RFICAoVFJDX1NDSEVEX1ZFUkJPU0UgKyAxNikKICNkZWZpbmUgVFJD X1NDSEVEX1NXSVRDSF9JTkZDT05UIChUUkNfU0NIRURfVkVSQk9TRSArIDE3KQorI2RlZmluZSBU UkNfU0NIRURfTUFYX0lOVFJWICAgICAgKFRSQ19TQ0hFRF9WRVJCT1NFICsgMTgpCiAKICNkZWZp bmUgVFJDX0RPTTBfRE9NX0FERCAgICAgICAgIChUUkNfRE9NMF9ET01PUFMgKyAxKQogI2RlZmlu ZSBUUkNfRE9NMF9ET01fUkVNICAgICAgICAgKFRSQ19ET00wX0RPTU9QUyArIDIpCg== --=-cpQTGjAn1Xhh+dvzwC6L-- --=-a1wSd6wZ38TPP0U8OQ5q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmBTl7sACgkQFkJ4iaW4 c+4BIQ//bePFMnquGBeaWLw3LmFPgO/vmoL4of+XNSYQ+kdEJbfxmjuXxYnFx3Gt pB2buqCcYp6B3R5if2qB7G0l5SPtYEz6wKs74NuybtrZNc6KhwZlW0rbhs35mOWG JT750eD8Kz0oq6aSwvnKCzdFheKN9WHE2svsDSEqa0p/xOzp1i9apEX/+9+pzxUB 4Svez8Xhj+inF/VI6GGeL/xmqJWSFm+7sATL34mhDxMF0pFUAD/8tq9/sjAmo+8S ZMRIKih/je7jqlFZ1818pAQg7xFNe4ZwDHooprA1WKTcfIY2TToyGQhR+SuhMftR W4uWFzgmJJ9/aR/Aq20FqquN+Lc5QZ7v6ywsMO+nnGnXjzMCtqIkFWLWa2LWFea6 0gHhIjys4uAiWpCUIh3RNx3GUfFwSTzjX+sntd5ezK7dVpPd6NTdUxH5CKiYt2SO JJfPSh6yu6L3gtphjmJvQ8t5+LxqDcjJvnb6U8j0rkoM61G0sa6I9BoszLsUY0xC eHIoPQQPH+eUpViNksKeZdeF9WAesPmFjv4hYzignmttZumUaCUZu5HnubgNsupJ VwBjRI6wce7L8bjNti/xU+mtKPYzAk96rlW2/5oalJ+0c80HoMybGbiJxg/lK2PW 3gY/JgeroM1Fj1g3pyNzYVeuzOHkko+Z4MvEmiFQva/W9QUJOmI= =yHXB -----END PGP SIGNATURE----- --=-a1wSd6wZ38TPP0U8OQ5q-- From xen-devel-bounces@lists.xenproject.org Thu Mar 18 18:48:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 18:48:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99089.188224 (Exim 4.92) (envelope-from ) id 1lMxgx-00087M-5v; Thu, 18 Mar 2021 18:48:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99089.188224; Thu, 18 Mar 2021 18:48:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMxgx-00087F-2T; Thu, 18 Mar 2021 18:48:19 +0000 Received: by outflank-mailman (input) for mailman id 99089; Thu, 18 Mar 2021 18:48:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMxgv-000877-SE; Thu, 18 Mar 2021 18:48:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMxgu-0006p5-Ps; Thu, 18 Mar 2021 18:48:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lMxgu-0006z5-Dz; Thu, 18 Mar 2021 18:48:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lMxgu-00049a-DU; Thu, 18 Mar 2021 18:48:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Gnj4RKVh6h78xZsyipKGgckAa1xIZoTH1dTxQckK0Og=; b=2llPj/sMjLVSS+EXjhBUgeCuHi LDksH9u5f+Lxep1Q47SV7IV++iVdvHo/hLLk/wBFr+U/zRmrSeZNuNth6VtORcn8wy+nh3+9T1v/L sHh7pzX2XjS/ZOYkdLwb026AI7FVNdliO77ZWBkdJFdfcBV6hJEvQZsjba+PjyJ1/MAc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160121: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-qemuu-freebsd11-amd64:guest-start/freebsd.repeat:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=6417f03132a6952cd17ddd8eaddbac92b61b17e0 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Thu, 18 Mar 2021 18:48:16 +0000 flight 160121 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160121/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-qemuu-freebsd11-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 6417f03132a6952cd17ddd8eaddbac92b61b17e0 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 229 days Failing since 152366 2020-08-01 20:49:34 Z 228 days 398 attempts Testing same since 160121 2021-03-18 02:28:12 Z 0 days 1 attempts ------------------------------------------------------------ 5218 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1294218 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 18 21:37:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 21:37:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99096.188239 (Exim 4.92) (envelope-from ) id 1lN0K0-0006mO-C0; Thu, 18 Mar 2021 21:36:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99096.188239; Thu, 18 Mar 2021 21:36:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN0K0-0006mH-8z; Thu, 18 Mar 2021 21:36:48 +0000 Received: by outflank-mailman (input) for mailman id 99096; Thu, 18 Mar 2021 21:36:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN0Jy-0006mC-Ty for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 21:36:46 +0000 Received: from mga11.intel.com (unknown [192.55.52.93]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 94e665e2-818a-49b0-8076-167991c15e4d; Thu, 18 Mar 2021 21:36:44 +0000 (UTC) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2021 14:36:43 -0700 Received: from uscipion-mobl.amr.corp.intel.com (HELO ubuntu.localdomain) ([10.212.120.33]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2021 14:36:41 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94e665e2-818a-49b0-8076-167991c15e4d IronPort-SDR: khfWbVH43/eYuUSi6uwRCy2I7RtfVRvxv4znCh2qkKShJ1gefAipzOIQ1e3yYpTOyeNBFwRPhn zk1ygg1pxDiQ== X-IronPort-AV: E=McAfee;i="6000,8403,9927"; a="186421945" X-IronPort-AV: E=Sophos;i="5.81,259,1610438400"; d="scan'208";a="186421945" IronPort-SDR: U3WcM3RW5tct+EwOFvhYDnoFepoNdbX8jUezrZ0exlGXn0LN8oytr5OXtGmd1BqpN/VTY0udx6 q6xf2j/LVnIw== X-IronPort-AV: E=Sophos;i="5.81,259,1610438400"; d="scan'208";a="523408007" From: Tamas K Lengyel To: xen-devel@lists.xenproject.org Cc: Tamas K Lengyel , Tamas K Lengyel , Jan Beulich , Andrew Cooper , George Dunlap , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking Date: Thu, 18 Mar 2021 14:36:32 -0700 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When creating a VM fork copy the parent VM's hostp2m max_mapped_pfn value. Some toolstack relies on the XENMEM_maximum_gpfn value to establish the maximum addressable physical memory in the VM and for forks that have not yet been unpaused that value is not going to reflect the correct max gpfn that's possible to populate into the p2m. This patch fixes the issue. Signed-off-by: Tamas K Lengyel --- xen/arch/x86/mm/mem_sharing.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c index 00ada05c10..98b14f7b0a 100644 --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -1761,6 +1761,7 @@ static int copy_settings(struct domain *cd, struct domain *d) return rc; copy_tsc(cd, d); + p2m_get_hostp2m(cd)->max_mapped_pfn = p2m_get_hostp2m(d)->max_mapped_pfn; return rc; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Mar 18 23:28:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 18 Mar 2021 23:28:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99099.188250 (Exim 4.92) (envelope-from ) id 1lN23x-00004u-FC; Thu, 18 Mar 2021 23:28:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99099.188250; Thu, 18 Mar 2021 23:28:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN23x-0008WT-C3; Thu, 18 Mar 2021 23:28:21 +0000 Received: by outflank-mailman (input) for mailman id 99099; Thu, 18 Mar 2021 23:28:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN23w-0008WO-Cn for xen-devel@lists.xenproject.org; Thu, 18 Mar 2021 23:28:20 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d756e0cf-5c36-49b5-aafc-67b344543687; Thu, 18 Mar 2021 23:28:19 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 512BE64F30; Thu, 18 Mar 2021 23:28:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d756e0cf-5c36-49b5-aafc-67b344543687 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616110098; bh=exYUfoIUBvnRcJr3UssflJUi1hyTbpqC7KzxYXBGsO0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=cLGL4vEKQ5qn1seTIdNogIzFV+v7BYcNxLW74grg7a+VTBV/41lHH1gQGyJNQOFkD 8IGJVHbq3YHSdrR2EpgnFrD5V9Cm37sPFNuoy01jHTq3FFV7387DcHJzhV2w4tHF55 LfylDw+kb37TvL9ezR7qJ3lRU50ohsQe9uY4YV8TLTjUXLGLvlZNVxG+EWPoZk7P21 VuVFIxpJDqrgUwUkCjL858dzXpegRtezJtzyo0yzMqjvTY+gt7DoSfU8wV2ZPQUBdj 1BoMH9H6Vpxvw3fVUVZ53N4JjhQm+pFRWPk9ovCfj+c4GlCDRxsOUnVMkAYfDnXfUf F2k0xp3ZJf2Bg== Date: Thu, 18 Mar 2021 16:28:17 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Boris Ostrovsky cc: Stefano Stabellini , jgross@suse.com, xen-devel@lists.xenproject.org, Stefano Stabellini Subject: Re: [PATCH] xen/arm: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped In-Reply-To: <4707b219-eee1-22e8-8dd3-6b7d821de333@oracle.com> Message-ID: References: <20210225235158.24001-1-sstabellini@kernel.org> <4707b219-eee1-22e8-8dd3-6b7d821de333@oracle.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-776278941-1616110098=:439" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-776278941-1616110098=:439 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 17 Mar 2021, Boris Ostrovsky wrote: > On 2/25/21 6:51 PM, Stefano Stabellini wrote: > > Newer Xen versions expose two Xen feature flags to tell us if the domain > > is directly mapped or not. Only when a domain is directly mapped it > > makes sense to enable swiotlb-xen on ARM. > > > > Introduce a function on ARM to check the new Xen feature flags and also > > to deal with the legacy case. Call the function xen_swiotlb_detect. > > > > Also rename the existing pci_xen_swiotlb_detect on x86 to > > xen_swiotlb_detect so that we can share a common function declaration. > > > > Signed-off-by: Stefano Stabellini > > --- > > > > This is the corresponding Xen patch under review: > > https://marc.info/?l=xen-devel&m=161421618217686 > > > > We don't *have to* make the x86 function and the ARM function exactly > > the same, but I thought it would be much nicer if we did. However, we > > can't really call it pci_* on ARM as there is no PCI necessarily. > > > I would prefer to keep existing names for consistency on x86 side (but making that inconsistent with ARM, as you point out).  But if you feel strongly about making the change you would have to have x86 maintainers agree to this (arch/x86/kernel/pci-swiotlb.c). OK. And from an x86 point of view, it makes sense for it to be called pci_xen_swiotlb_detect given that it is passed to IOMMU_INIT_FINISH in arch/x86/kernel/pci-swiotlb.c. So, I'll follow you suggestion, keep the x86 side named as it is today, and provide a tiny wrapper so that we can still have an arch-neutral xen_swiotlb_detect function (on x86 just calls pci_xen_swiotlb_detect.) See below. >From 5f6c91990df1e834c78501799905b04916105836 Mon Sep 17 00:00:00 2001 From: Stefano Stabellini Date: Thu, 18 Mar 2021 16:17:21 -0700 Subject: [PATCH] xen/arm: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped Newer Xen versions expose two Xen feature flags to tell us if the domain is directly mapped or not. Only when a domain is directly mapped it makes sense to enable swiotlb-xen on ARM. Introduce a function on ARM to check the new Xen feature flags and also to deal with the legacy case. Call the function xen_swiotlb_detect. Also implement xen_swiotlb_detect on x88 using the existing pci_xen_swiotlb_detect() so that we can share a common function declaration. Signed-off-by: Stefano Stabellini --- arch/arm/xen/mm.c | 14 +++++++++++++- arch/arm64/mm/dma-mapping.c | 2 +- arch/x86/include/asm/xen/swiotlb-xen.h | 4 ++-- arch/x86/xen/pci-swiotlb-xen.c | 7 ++++++- include/xen/interface/features.h | 14 ++++++++++++++ include/xen/swiotlb-xen.h | 6 ++++++ 6 files changed, 42 insertions(+), 5 deletions(-) diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c index 467fa225c3d0..e1b12b242a32 100644 --- a/arch/arm/xen/mm.c +++ b/arch/arm/xen/mm.c @@ -135,10 +135,22 @@ void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order) return; } +int xen_swiotlb_detect(void) +{ + if (!xen_domain()) + return 0; + if (xen_feature(XENFEAT_direct_mapped)) + return 1; + /* legacy case */ + if (!xen_feature(XENFEAT_not_direct_mapped) && xen_initial_domain()) + return 1; + return 0; +} + static int __init xen_mm_init(void) { struct gnttab_cache_flush cflush; - if (!xen_initial_domain()) + if (!xen_swiotlb_detect()) return 0; xen_swiotlb_init(1, false); diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c index 93e87b287556..4bf1dd3eb041 100644 --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -53,7 +53,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size, iommu_setup_dma_ops(dev, dma_base, size); #ifdef CONFIG_XEN - if (xen_initial_domain()) + if (xen_swiotlb_detect()) dev->dma_ops = &xen_swiotlb_dma_ops; #endif } diff --git a/arch/x86/include/asm/xen/swiotlb-xen.h b/arch/x86/include/asm/xen/swiotlb-xen.h index 6b56d0d45d15..66d576486509 100644 --- a/arch/x86/include/asm/xen/swiotlb-xen.h +++ b/arch/x86/include/asm/xen/swiotlb-xen.h @@ -4,12 +4,12 @@ #ifdef CONFIG_SWIOTLB_XEN extern int xen_swiotlb; -extern int __init pci_xen_swiotlb_detect(void); +extern int pci_xen_swiotlb_detect(void); extern void __init pci_xen_swiotlb_init(void); extern int pci_xen_swiotlb_init_late(void); #else #define xen_swiotlb (0) -static inline int __init pci_xen_swiotlb_detect(void) { return 0; } +static inline int pci_xen_swiotlb_detect(void) { return 0; } static inline void __init pci_xen_swiotlb_init(void) { } static inline int pci_xen_swiotlb_init_late(void) { return -ENXIO; } #endif diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c index 19ae3e4fe4e9..0555f68a773f 100644 --- a/arch/x86/xen/pci-swiotlb-xen.c +++ b/arch/x86/xen/pci-swiotlb-xen.c @@ -26,7 +26,7 @@ int xen_swiotlb __read_mostly; * This returns non-zero if we are forced to use xen_swiotlb (by the boot * option). */ -int __init pci_xen_swiotlb_detect(void) +int pci_xen_swiotlb_detect(void) { if (!xen_pv_domain()) @@ -56,6 +56,11 @@ int __init pci_xen_swiotlb_detect(void) return xen_swiotlb; } +int xen_swiotlb_detect(void) +{ + return pci_xen_swiotlb_detect(); +} + void __init pci_xen_swiotlb_init(void) { if (xen_swiotlb) { diff --git a/include/xen/interface/features.h b/include/xen/interface/features.h index 6d1384abfbdf..5a7bdefa06a8 100644 --- a/include/xen/interface/features.h +++ b/include/xen/interface/features.h @@ -83,6 +83,20 @@ */ #define XENFEAT_linux_rsdp_unrestricted 15 +/* + * A direct-mapped (or 1:1 mapped) domain is a domain for which its + * local pages have gfn == mfn. If a domain is direct-mapped, + * XENFEAT_direct_mapped is set; otherwise XENFEAT_not_direct_mapped + * is set. + * + * If neither flag is set (e.g. older Xen releases) the assumptions are: + * - not auto_translated domains (x86 only) are always direct-mapped + * - on x86, auto_translated domains are not direct-mapped + * - on ARM, Dom0 is direct-mapped, DomUs are not + */ +#define XENFEAT_not_direct_mapped 16 +#define XENFEAT_direct_mapped 17 + #define XENFEAT_NR_SUBMAPS 1 #endif /* __XEN_PUBLIC_FEATURES_H__ */ diff --git a/include/xen/swiotlb-xen.h b/include/xen/swiotlb-xen.h index d5eaf9d682b8..336356b61738 100644 --- a/include/xen/swiotlb-xen.h +++ b/include/xen/swiotlb-xen.h @@ -12,4 +12,10 @@ void xen_dma_sync_for_device(struct device *dev, dma_addr_t handle, extern int xen_swiotlb_init(int verbose, bool early); extern const struct dma_map_ops xen_swiotlb_dma_ops; +#ifdef CONFIG_SWIOTLB_XEN +extern int xen_swiotlb_detect(void); +#else +static inline int xen_swiotlb_detect(void) { return 0; } +#endif + #endif /* __LINUX_SWIOTLB_XEN_H */ -- 2.17.1 --8323329-776278941-1616110098=:439-- From xen-devel-bounces@lists.xenproject.org Fri Mar 19 02:08:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 02:08:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99109.188263 (Exim 4.92) (envelope-from ) id 1lN4YM-0000tR-FZ; Fri, 19 Mar 2021 02:07:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99109.188263; Fri, 19 Mar 2021 02:07:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN4YM-0000tI-8J; Fri, 19 Mar 2021 02:07:54 +0000 Received: by outflank-mailman (input) for mailman id 99109; Fri, 19 Mar 2021 02:07:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN4YK-0000t9-8u; Fri, 19 Mar 2021 02:07:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN4YK-0008JQ-0F; Fri, 19 Mar 2021 02:07:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN4YJ-0003cA-F4; Fri, 19 Mar 2021 02:07:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lN4YJ-0003kJ-D0; Fri, 19 Mar 2021 02:07:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JcIJsmdsiR8hEg8V5BCTSW2boIH8Mp7u2q9CKrTwtc8=; b=J9AZ1GnNXq5jC/hRQ97fWqSk7H FXUo4sxt+NnXLZgybZUMHiQ21jtQ9H/EYbz49z4zD1Wi5wVRcWXGqBMvomD6XBvXefEZWVTCRkCfn oFG7DxnmC4dQGAKs9Yld+46Jg8oefC1o0O14rJVwp94C8WN3AEMPSU7uOLOnIIKNikvI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160125: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-arm64-arm64-xl-thunderx:debian-install:fail:heisenbug qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=b12498fc575f2ad30f09fe78badc7fef526e2d76 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Fri, 19 Mar 2021 02:07:51 +0000 flight 160125 qemu-mainline real [real] flight 160133 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160125/ http://logs.test-lab.xenproject.org/osstest/logs/160133/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-thunderx 12 debian-install fail pass in 160133-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 160133 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 160133 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu b12498fc575f2ad30f09fe78badc7fef526e2d76 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 210 days Failing since 152659 2020-08-21 14:07:39 Z 209 days 406 attempts Testing same since 160125 2021-03-18 12:43:06 Z 0 days 1 attempts ------------------------------------------------------------ 457 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 131728 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Mar 19 05:58:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 05:58:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99122.188298 (Exim 4.92) (envelope-from ) id 1lN892-0005VZ-Ep; Fri, 19 Mar 2021 05:58:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99122.188298; Fri, 19 Mar 2021 05:58:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN892-0005VS-Bc; Fri, 19 Mar 2021 05:58:00 +0000 Received: by outflank-mailman (input) for mailman id 99122; Fri, 19 Mar 2021 05:57:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN891-0005VK-7K; Fri, 19 Mar 2021 05:57:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN891-00047C-25; Fri, 19 Mar 2021 05:57:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN890-0000K9-LL; Fri, 19 Mar 2021 05:57:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lN890-0007IZ-Kc; Fri, 19 Mar 2021 05:57:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bYIsuMMaZUFRpTtvuajSKjgq2Ul1vsOy/SjG8dolajY=; b=kcokwm5QYsTt4R92pBSDk03DfL tCX15r/FsjsdSrDP4OJPkOgxPaLeODDTes7la9ByoIw/FMtKUPgIw4eiFGk1QKHmX1jiHC+MwQyxB v2KYn8Lis2h2hrVAVBYjaeT8YQUEthhmp6uhjfeubKvNtzZZchCsr3wTwGNuu5PUUGsQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 160127: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.14-testing:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b0d7739f10dc93d9565220b4e79ebc6675548c02 X-Osstest-Versions-That: xen=a1dab05393ec5654e2a88be296cc973595ffb1d0 From: osstest service owner Date: Fri, 19 Mar 2021 05:57:58 +0000 flight 160127 xen-4.14-testing real [real] flight 160136 xen-4.14-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160127/ http://logs.test-lab.xenproject.org/osstest/logs/160136/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 160136-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159840 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159840 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159840 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159840 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159840 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159840 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159840 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159840 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159840 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159840 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159840 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen b0d7739f10dc93d9565220b4e79ebc6675548c02 baseline version: xen a1dab05393ec5654e2a88be296cc973595ffb1d0 Last test of basis 159840 2021-03-05 15:07:16 Z 13 days Testing same since 160127 2021-03-18 14:06:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Dario Faggioli Igor Druzhinin Jan Beulich Olaf Hering Tim Deegan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a1dab05393..b0d7739f10 b0d7739f10dc93d9565220b4e79ebc6675548c02 -> stable-4.14 From xen-devel-bounces@lists.xenproject.org Fri Mar 19 07:52:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 07:52:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99134.188313 (Exim 4.92) (envelope-from ) id 1lN9vT-00080n-7d; Fri, 19 Mar 2021 07:52:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99134.188313; Fri, 19 Mar 2021 07:52:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN9vT-00080g-2R; Fri, 19 Mar 2021 07:52:07 +0000 Received: by outflank-mailman (input) for mailman id 99134; Fri, 19 Mar 2021 07:52:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN9vR-00080Y-Fw; Fri, 19 Mar 2021 07:52:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN9vR-000667-5g; Fri, 19 Mar 2021 07:52:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lN9vQ-0006Es-Nx; Fri, 19 Mar 2021 07:52:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lN9vQ-00060J-NR; Fri, 19 Mar 2021 07:52:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=03s+zqA8Rs6YXKJdZFT6WMhy8d/Q2YaPPE95sgSK+jk=; b=1VrCkX+wZaOg4UPqOA3bFoFzA5 7fbee/2z07+a0hZ/a7ac1cemA0R3qt+JX66wcqRwB503W50RPC+lnhLkJu96orX4hCRvTd2quR4OT RZhUT1OV3qgFLmfn9Ds+0cLh4c4X2U3sYNzI1xo8+fnCOU1z7vhbZAtG3yt86pwU3ZGI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160128: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b8737d236e525315504fc7b271de21101288d67f X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Fri, 19 Mar 2021 07:52:04 +0000 flight 160128 xen-4.12-testing real [real] flight 160137 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160128/ http://logs.test-lab.xenproject.org/osstest/logs/160137/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail REGR. vs. 159418 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: xen b8737d236e525315504fc7b271de21101288d67f baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 30 days Testing same since 160128 2021-03-18 14:36:18 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Jan Beulich Olaf Hering jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit b8737d236e525315504fc7b271de21101288d67f Author: Anthony PERARD Date: Thu Mar 18 15:10:37 2021 +0100 libxl: Fix domain soft reset state handling In do_domain_soft_reset(), a `libxl__domain_suspend_state' is used without been properly initialised and disposed of. This lead do a abort() in libxl due to the `dsps.qmp' state been used before been initialised: libxl__ev_qmp_send: Assertion `ev->state == qmp_state_disconnected || ev->state == qmp_state_connected' failed. Once initialised, `dsps' also needs to be disposed of as the `qmp' state might still be in the `Connected' state in the callback for libxl__domain_suspend_device_model(). So this patch adds libxl__domain_suspend_dispose() which can be called from the two places where we need to dispose of `dsps'. This is XSA-368. Reported-by: Olaf Hering Signed-off-by: Anthony PERARD Reviewed-by: Ian Jackson Tested-by: Olaf Hering master commit: dae3c3e8b257cd27d6b35a467a34bf79a6650340 master date: 2021-03-18 14:56:33 +0100 commit 70c53eaf596ef34c202257418e6684803cd96a4c Author: Jan Beulich Date: Thu Mar 18 15:09:38 2021 +0100 crypto: adjust rijndaelEncrypt() prototype for gcc11 The upcoming release complains, not entirely unreasonably: In file included from rijndael.c:33: .../xen/include/crypto/rijndael.h:55:53: note: previously declared as 'const unsigned char[]' 55 | void rijndaelEncrypt(const unsigned int [], int, const unsigned char [], | ^~~~~~~~~~~~~~~~~~~~~~ rijndael.c:865:8: error: argument 4 of type 'u8[16]' {aka 'unsigned char[16]'} with mismatched bound [-Werror=array-parameter=] 865 | u8 ct[16]) | ~~~^~~~~~ In file included from rijndael.c:33: .../xen/include/crypto/rijndael.h:56:13: note: previously declared as 'unsigned char[]' 56 | unsigned char []); | ^~~~~~~~~~~~~~~~ Simply declare the correct array dimensions right away. This then allows compilers to apply checking at call sites, which seems desirable anyway. For the moment I'm leaving untouched the disagreement between u8/u32 used in the function definition and unsigned {char,int} used in the declaration, as making this consistent would call for touching further functions. Reported-by: Charles Arnold Signed-off-by: Jan Beulich Reviewed-by: Julien Grall master commit: c6ad5a701b9a6df443a6c98d9e7201c958bbcafc master date: 2021-03-04 16:47:51 +0100 (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Mar 19 09:04:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 09:04:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99147.188331 (Exim 4.92) (envelope-from ) id 1lNB2a-0006he-N2; Fri, 19 Mar 2021 09:03:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99147.188331; Fri, 19 Mar 2021 09:03:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNB2a-0006hX-JT; Fri, 19 Mar 2021 09:03:32 +0000 Received: by outflank-mailman (input) for mailman id 99147; Fri, 19 Mar 2021 09:03:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNB2Y-0006hC-VW for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 09:03:31 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 10b824fe-a3de-4b39-b034-c12489ac566a; Fri, 19 Mar 2021 09:03:30 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3A4BEAE42; Fri, 19 Mar 2021 09:03:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10b824fe-a3de-4b39-b034-c12489ac566a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616144609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EWfP7UzloOiAPorS85pHk23RXUijFI78X2molTUlK08=; b=PDWukbk2bZaCqZFG2XB1Q+PBrbIS+GKA0qpkfpj6P4HzxFgYAYYR9zi7Mp40BMLppv+t5B 4S3MpkAyGoq6m3YpGWYnEgjKmDuEzeS7RrdT09Eqafc3WUe4Qg+ICza5fFCaYodmFg6OrH pdKy/815cwelWDcwfIVzmqV4GwrAJ9c= Message-ID: Subject: Re: Ryzen 4000 (Mobile) Softlocks/Micro-stutters From: Dario Faggioli To: Jan Beulich , Dylanger Daly Cc: Andrew Cooper , "xen-devel@lists.xenproject.org" Date: Fri, 19 Mar 2021 10:03:28 +0100 In-Reply-To: <4916dec1-1bb9-7e6f-2fe5-577bbab92861@suse.com> References: <9lQU_gCfRzGyyNb2j86pxTMi1IET1Iq7iK3994agUZPrTI5Xd-aCJAaRYuJlD3L5LT2WaV4N3-YF4xKl5ukialT0M_YD0ve6gmDFFfatpXw=@protonmail.com> <2cc5da3e-0ad0-4647-f1ca-190788c2910b@citrix.com> <3pKjdPYCiRimYjqHQP0xd_vqhoTOJqthTXOrY_rLeNvnQEpIF24gXDKgRhmr95JfARJzbVJVbfTrrJeiovGVHGbV0QBSZ2jez2Y_wt6db7g=@protonmail.com> <768d9dbb-4387-099f-b489-7952d7e883b0@suse.com> <815f3bc3a28a165e8fa41c6954a6d00db656e3c3.camel@suse.com> <1fc0e850-8a08-760f-c8cb-ad73dda4a37b@suse.com> <4916dec1-1bb9-7e6f-2fe5-577bbab92861@suse.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-GoX3ylmGFV4yNyyCHmnh" User-Agent: Evolution 3.38.4 (by Flathub.org) MIME-Version: 1.0 --=-GoX3ylmGFV4yNyyCHmnh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2021-03-16 at 09:02 +0100, Jan Beulich wrote: > On 16.03.2021 03:10, Dylanger Daly wrote: > > I just wanted to close this off and let everyone know the issue > > ended up being a faulty/misconfigured HPET clock. > >=20 > > Appending `clocksource=3Dtsc tsc=3Dunstable hpetbroadcast=3D0` to Xen's > > CMDLINE totally fixed my issue, I assume Xen was detecting TSC may > > have been 'off' and was trying to recover/self-correct? >=20 > I find this a very confusing combination of command line options. > In particular "tsc=3Dunstable" clears one of the feature prereqs > (TSC_RELIABLE) that are required for "clocksource=3Dtsc" to take > any effect, afaict. I therefore would conclude that you're not > actually running with TSC as the clock source.=C2=A0 > Right. Also, isn't hpetbroadcast set to 0 by default already? Dario --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-GoX3ylmGFV4yNyyCHmnh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmBUaOAACgkQFkJ4iaW4 c+6jsw//Qhucgz4gNZj09uf6iyo4vLt1MFzq62SMB2MkxKpEh/kHb3TnJjBMbkw2 zqp1bJI+ysDl+T3i0yWofFaXP+zdmTTtxggdj3QoZLIpM83osGgZ3x4Z4/YQ7cPu KY1YLryFlYXJpc3sQPRJOll5x12/U7SGq+j3k0BtBQkJcB90NIY5uUoDP5F3kKvN wTqHAuKufOKdr7nMhEly6J+bNXkMP9E5LRMn5M7YrrnebMufEuL+eo5uSK/+gJ8d kFN2fWtVTjrtSUldjOtZudMz/jkBMgwNggGv3lF6L7L8IE/FaR5IxGT9Gg91ICfi 22sX3HzrXaMiCbn2YmLo0bEGCBhjcmZw/BQv3ycKxq7uFHczTA/WKWGDYcZiH9yu RRicpR0O74/fgqvbZ2kVuXceNDQqVadXcDAiUDTn61OB/W+wscYM1U9LbtZea3bU eIF1HR5BsHdlpT9gu/fuaBLeMdf2WFRwFN8q67nwWpdeOayhU7vgOjwJRPjxGbyz mI5usjwrrql+lFS4WO2wP/HDiz0hFfPopRJMTbC4N3kbPzWXi4F6kEWNTUy/2jxw Fbpw6rR2+PECIsSO1M4V7wLn+OgIa/fC6/ktgVkWhcDWQgfucTd4nkxXqKpKmRPM MSK/gHjIL3Mbep0hRhwS7kaiNCd0FJK9Wn3s1Ufe6tAt8fTEERY= =t5Qz -----END PGP SIGNATURE----- --=-GoX3ylmGFV4yNyyCHmnh-- From xen-devel-bounces@lists.xenproject.org Fri Mar 19 09:41:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 09:41:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99153.188343 (Exim 4.92) (envelope-from ) id 1lNBch-0001vh-LD; Fri, 19 Mar 2021 09:40:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99153.188343; Fri, 19 Mar 2021 09:40:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNBch-0001va-Hd; Fri, 19 Mar 2021 09:40:51 +0000 Received: by outflank-mailman (input) for mailman id 99153; Fri, 19 Mar 2021 09:40:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNBcf-0001vV-Ki for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 09:40:49 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f3189259-6cea-45b0-903c-388a86421e4c; Fri, 19 Mar 2021 09:40:46 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0315AAE05; Fri, 19 Mar 2021 09:40:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3189259-6cea-45b0-903c-388a86421e4c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616146846; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BDSC5ohYDZgClzQ920JJC1vvfwqO6RRsmKC/d/XO3rI=; b=GwSNFyOMsLsaeQvhxuh56K3rc//gFuSXULPqSbviWgLmdOAJ28RnhJoC6zGwAsS10V1PpQ h+ElzLpE04Skq98FAXJGtRAdbgeKPS+gUs7cUvzWZdF8GbAeV0Sv+RxTtXRCyarw1YqBGp bVzgXDN1brBkGRQGQ1EpYFgARIX4kn4= Subject: Re: Troubles analyzing crash dumps from xl dump-core To: Igor Druzhinin , Roman Shaposhnik Cc: Xen-devel References: <91837fa8-1d57-8b37-bf66-9e021855348d@suse.com> <2bbb347c-bc5b-63f7-3e94-b90145ff5166@suse.com> <6466c5e156bf4afbb9fbbd44d7ff20b8@FTLPEX02CL02.citrite.net> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <3e15967e-a243-d728-e66d-31f700539221@suse.com> Date: Fri, 19 Mar 2021 10:40:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <6466c5e156bf4afbb9fbbd44d7ff20b8@FTLPEX02CL02.citrite.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qCUDw5HfKVmisMSQaeQuwr9dUW5MlCHlR" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qCUDw5HfKVmisMSQaeQuwr9dUW5MlCHlR Content-Type: multipart/mixed; boundary="56KizhKZjHM3lCODhiMjtgMIgqZQw0VQo"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Igor Druzhinin , Roman Shaposhnik Cc: Xen-devel Message-ID: <3e15967e-a243-d728-e66d-31f700539221@suse.com> Subject: Re: Troubles analyzing crash dumps from xl dump-core References: <91837fa8-1d57-8b37-bf66-9e021855348d@suse.com> <2bbb347c-bc5b-63f7-3e94-b90145ff5166@suse.com> <6466c5e156bf4afbb9fbbd44d7ff20b8@FTLPEX02CL02.citrite.net> In-Reply-To: <6466c5e156bf4afbb9fbbd44d7ff20b8@FTLPEX02CL02.citrite.net> --56KizhKZjHM3lCODhiMjtgMIgqZQw0VQo Content-Type: multipart/mixed; boundary="------------BD568719CF22F0C3FB34ED2C" Content-Language: en-US This is a multi-part message in MIME format. --------------BD568719CF22F0C3FB34ED2C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 10.03.21 20:37, Igor Druzhinin wrote: >> On 30.01.21 19:53, Roman Shaposhnik wrote: >>> On Fri, Jan 29, 2021 at 11:28 PM J=C3=BCrgen Gro=C3=9F wrote: >>>> >>>> On 29.01.21 21:12, Roman Shaposhnik wrote: >>>>> Hi! >>>>> >>>>> I'm trying to see how much mileage I can get out of >>>>> crash(1) 7.2.8 (based on gdb 7.6) when it comes to analyzing crash >>>>> dumps taken via xl dump-core (this is all on x86_64 with stock Xen >>>>> v. 4.14). >>>>> >>>>> The good news is that the image actually does load up but it throws= >>>>> the following WARNINGs in the process: >>>>> >>>>> WARNING: cannot access vmalloc'd module memory >>>>> crash: read error: kernel virtual address: ffffffff93613480 type: >>>>> "fill_task_struct" >>>>> WARNING: active task ffffffff93613480 on cpu 0 not found in PID has= h >>>>> crash: read error: kernel virtual address: ffffffff93613480 type: >>>>> "fill_task_struct" >>>>> WARNING: cannot read log_buf contents >>>>> >>>>> And then the info that it gives me around basic things like ps, mod= , >>>>> log, etc. is really super limited (and I am now suspecting may even= >>>>> be wrong). >>>>> >>>>> Since I was primarily after dmesg/log initially, I tried: >>>>> crash> log >>>>> log: WARNING: cannot read log_buf contents >>>>> >>>>> Then I tried taking an xl dump-core from the domU that was still >>>>> very much alive and happy and got similar results -- so it clearly >>>>> doesn't seem to be related to the state domU is in. >>>>> >>>>> As matter of fact, I actually got to the desired dmesg output by >>>>> simply running strings(1) on the core file -- so the info is >>>>> definitely there -- but I guess some kind of index/reference maybe >>>>> broken. >>>>> >>>>> With all that in mind, if there's anyone on this ML who has recentl= y >>>>> done Xen DomU crash dump analysis -- I would definitely appreciate >>>>> the pointers! >>>> >>>> For me it just works (openSUSE). >>> >>> Can you please run: >>> >>> crash --version and readelf -a XXXX (on the xl dump-core output) and >>> post the results? >> >> # crash --version >> >> crash 7.2.1 >=20 > I tried to build this version but I still get the following while tryin= g to open a dump file > produced by "xl dump-core": >=20 > [root@lcy2-dt92 crash]# ./crash ../vmlinux-5.8.0-44-generic ../xxx.dmp >=20 > crash 7.2.1 > Copyright (C) 2002-2017 Red Hat, Inc. > Copyright (C) 2004, 2005, 2006, 2010 IBM Corporation > Copyright (C) 1999-2006 Hewlett-Packard Co > Copyright (C) 2005, 2006, 2011, 2012 Fujitsu Limited > Copyright (C) 2006, 2007 VA Linux Systems Japan K.K. > Copyright (C) 2005, 2011 NEC Corporation > Copyright (C) 1999, 2002, 2007 Silicon Graphics, Inc. > Copyright (C) 1999, 2000, 2001, 2002 Mission Critical Linux, Inc. > This program is free software, covered by the GNU General Public Licens= e, > and you are welcome to change it and/or distribute copies of it under > certain conditions. Enter "help copying" to see the conditions. > This program has absolutely no warranty. Enter "help warranty" for det= ails. >=20 > GNU gdb (GDB) 7.6 > Copyright (C) 2013 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. Type "show copyi= ng" > and "show warranty" for details. > This GDB was configured as "x86_64-unknown-linux-gnu"... >=20 > crash: cannot determine base kernel version > crash: ../vmlinux-5.8.0-44-generic and ../xxx.dmp do not match! >=20 >=20 > Am I doing something wrong? How do I need to use crash for it to work? Could you try the attached patch? Juergen --------------BD568719CF22F0C3FB34ED2C Content-Type: text/x-patch; charset=UTF-8; name="0001-tools-libs-ctrl-fix-xc_core_arch_map_p2m-to-support-.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-tools-libs-ctrl-fix-xc_core_arch_map_p2m-to-support-.pa"; filename*1="tch" =46rom e7265739e0db957176261236be53c0c270c2efa1 Mon Sep 17 00:00:00 2001 From: Juergen Gross Date: Thu, 18 Mar 2021 14:26:24 +0100 Subject: [PATCH] tools/libs/ctrl: fix xc_core_arch_map_p2m() to support l= inear p2m table The core of a pv linux guest produced via "xl dump-core" is nor usable as since kernel 4.14 only the linear p2m table is kept if Xen indicates it is supporting that. Unfortunately xc_core_arch_map_p2m() is still supporting the 3-level p2m tree only. Fix that by copying the functionality of map_p2m() from libxenguest to libxenctrl. Fixes: dc6d60937121 ("libxc: set flag for support of linear p2m list in d= omain builder") Signed-off-by: Juergen Gross --- This is a backport candidate. --- tools/libs/ctrl/xc_core_x86.c | 235 ++++++++++++++++++++++++++++++---- tools/libs/ctrl/xc_private.h | 1 + 2 files changed, 208 insertions(+), 28 deletions(-) diff --git a/tools/libs/ctrl/xc_core_x86.c b/tools/libs/ctrl/xc_core_x86.= c index cb76e6207b..a8806efb4a 100644 --- a/tools/libs/ctrl/xc_core_x86.c +++ b/tools/libs/ctrl/xc_core_x86.c @@ -17,6 +17,7 @@ * */ =20 +#include #include "xc_private.h" #include "xc_core.h" #include @@ -65,34 +66,169 @@ xc_core_arch_memory_map_get(xc_interface *xch, struc= t xc_core_arch_context *unus return 0; } =20 -static int -xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *d= info, xc_dominfo_t *info, - shared_info_any_t *live_shinfo, xen_pfn_t **live= _p2m, - unsigned long *pfnp, int rw) +static inline bool is_canonical_address(uint64_t vaddr) { - /* Double and single indirect references to the live P2M table */ - xen_pfn_t *live_p2m_frame_list_list =3D NULL; - xen_pfn_t *live_p2m_frame_list =3D NULL; - /* Copies of the above. */ - xen_pfn_t *p2m_frame_list_list =3D NULL; - xen_pfn_t *p2m_frame_list =3D NULL; + return ((int64_t)vaddr >> 47) =3D=3D ((int64_t)vaddr >> 63); +} =20 - uint32_t dom =3D info->domid; - int ret =3D -1; - int err; - int i; +/* Virtual address ranges reserved for hypervisor. */ +#define HYPERVISOR_VIRT_START_X86_64 0xFFFF800000000000ULL +#define HYPERVISOR_VIRT_END_X86_64 0xFFFF87FFFFFFFFFFULL =20 - if ( xc_domain_nr_gpfns(xch, info->domid, &dinfo->p2m_size) < 0 ) +#define HYPERVISOR_VIRT_START_X86_32 0x00000000F5800000ULL +#define HYPERVISOR_VIRT_END_X86_32 0x00000000FFFFFFFFULL + +static xen_pfn_t * +xc_core_arch_map_p2m_list_rw(xc_interface *xch, struct domain_info_conte= xt *dinfo, + uint32_t dom, shared_info_any_t *live_shinf= o, + uint64_t p2m_cr3) +{ + uint64_t p2m_vaddr, p2m_end, mask, off; + xen_pfn_t p2m_mfn, mfn, saved_mfn, max_pfn; + uint64_t *ptes =3D NULL; + xen_pfn_t *mfns =3D NULL; + unsigned int fpp, n_pages, level, n_levels, shift, + idx_start, idx_end, idx, saved_idx; + + p2m_vaddr =3D GET_FIELD(live_shinfo, arch.p2m_vaddr, dinfo->guest_wi= dth); + fpp =3D PAGE_SIZE / dinfo->guest_width; + dinfo->p2m_frames =3D (dinfo->p2m_size - 1) / fpp + 1; + p2m_end =3D p2m_vaddr + dinfo->p2m_frames * PAGE_SIZE - 1; + + if ( dinfo->guest_width =3D=3D 8 ) { - ERROR("Could not get maximum GPFN!"); - goto out; + mask =3D 0x0000ffffffffffffULL; + n_levels =3D 4; + p2m_mfn =3D p2m_cr3 >> 12; + if ( !is_canonical_address(p2m_vaddr) || + !is_canonical_address(p2m_end) || + p2m_end < p2m_vaddr || + (p2m_vaddr <=3D HYPERVISOR_VIRT_END_X86_64 && + p2m_end > HYPERVISOR_VIRT_START_X86_64) ) + { + ERROR("Bad virtual p2m address range %#" PRIx64 "-%#" PRIx64= , + p2m_vaddr, p2m_end); + errno =3D ERANGE; + goto out; + } + } + else + { + mask =3D 0x00000000ffffffffULL; + n_levels =3D 3; + if ( p2m_cr3 & ~mask ) + p2m_mfn =3D ~0UL; + else + p2m_mfn =3D (uint32_t)((p2m_cr3 >> 12) | (p2m_cr3 << 20)); + if ( p2m_vaddr > mask || p2m_end > mask || p2m_end < p2m_vaddr |= | + (p2m_vaddr <=3D HYPERVISOR_VIRT_END_X86_32 && + p2m_end > HYPERVISOR_VIRT_START_X86_32) ) + { + ERROR("Bad virtual p2m address range %#" PRIx64 "-%#" PRIx64= , + p2m_vaddr, p2m_end); + errno =3D ERANGE; + goto out; + } } =20 - if ( dinfo->p2m_size < info->nr_pages ) + mfns =3D malloc(sizeof(*mfns)); + if ( !mfns ) { - ERROR("p2m_size < nr_pages -1 (%lx < %lx", dinfo->p2m_size, info= ->nr_pages - 1); + ERROR("Cannot allocate memory for array of %u mfns", 1); goto out; } + mfns[0] =3D p2m_mfn; + off =3D 0; + saved_mfn =3D 0; + idx_start =3D idx_end =3D saved_idx =3D 0; + + for ( level =3D n_levels; level > 0; level-- ) + { + n_pages =3D idx_end - idx_start + 1; + ptes =3D xc_map_foreign_pages(xch, dom, PROT_READ, mfns, n_pages= ); + if ( !ptes ) + { + PERROR("Failed to map %u page table pages for p2m list", n_p= ages); + goto out; + } + free(mfns); + + shift =3D level * 9 + 3; + idx_start =3D ((p2m_vaddr - off) & mask) >> shift; + idx_end =3D ((p2m_end - off) & mask) >> shift; + idx =3D idx_end - idx_start + 1; + mfns =3D malloc(sizeof(*mfns) * idx); + if ( !mfns ) + { + ERROR("Cannot allocate memory for array of %u mfns", idx); + goto out; + } + + for ( idx =3D idx_start; idx <=3D idx_end; idx++ ) + { + mfn =3D (ptes[idx] & 0x000ffffffffff000ULL) >> PAGE_SHIFT; + if ( mfn =3D=3D 0 ) + { + ERROR("Bad mfn %#lx during page table walk for vaddr %#"= PRIx64 " at level %d of p2m list", + mfn, off + ((uint64_t)idx << shift), level); + errno =3D ERANGE; + goto out; + } + mfns[idx - idx_start] =3D mfn; + + /* Maximum pfn check at level 2. Same reasoning as for p2m t= ree. */ + if ( level =3D=3D 2 ) + { + if ( mfn !=3D saved_mfn ) + { + saved_mfn =3D mfn; + saved_idx =3D idx - idx_start; + } + } + } + + if ( level =3D=3D 2 ) + { + if ( saved_idx =3D=3D idx_end ) + saved_idx++; + max_pfn =3D ((xen_pfn_t)saved_idx << 9) * fpp; + if ( max_pfn < dinfo->p2m_size ) + { + dinfo->p2m_size =3D max_pfn; + dinfo->p2m_frames =3D (dinfo->p2m_size + fpp - 1) / fpp;= + p2m_end =3D p2m_vaddr + dinfo->p2m_frames * PAGE_SIZE - = 1; + idx_end =3D idx_start + saved_idx; + } + } + + munmap(ptes, n_pages * PAGE_SIZE); + ptes =3D NULL; + off =3D p2m_vaddr & ((mask >> shift) << shift); + } + + return mfns; + + out: + free(mfns); + if ( ptes ) + munmap(ptes, n_pages * PAGE_SIZE); + + return NULL; +} + +static xen_pfn_t * +xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct domain_info_conte= xt *dinfo, + uint32_t dom, shared_info_any_t *live_shinf= o) +{ + /* Double and single indirect references to the live P2M table */ + xen_pfn_t *live_p2m_frame_list_list; + xen_pfn_t *live_p2m_frame_list =3D NULL; + /* Copies of the above. */ + xen_pfn_t *p2m_frame_list_list =3D NULL; + xen_pfn_t *p2m_frame_list; + + int err; + int i; =20 live_p2m_frame_list_list =3D xc_map_foreign_range(xch, dom, PAGE_SIZE, PROT_READ, @@ -151,10 +287,61 @@ xc_core_arch_map_p2m_rw(xc_interface *xch, struct d= omain_info_context *dinfo, xc for ( i =3D P2M_FL_ENTRIES - 1; i >=3D 0; i-- ) p2m_frame_list[i] =3D ((uint32_t *)p2m_frame_list)[i]; =20 + dinfo->p2m_frames =3D P2M_FL_ENTRIES; + + return p2m_frame_list; + + out: + err =3D errno; + + if ( live_p2m_frame_list_list ) + munmap(live_p2m_frame_list_list, PAGE_SIZE); + + if ( live_p2m_frame_list ) + munmap(live_p2m_frame_list, P2M_FLL_ENTRIES * PAGE_SIZE); + + free(p2m_frame_list_list); + + errno =3D err; + + return NULL; +} + +static int +xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *d= info, xc_dominfo_t *info, + shared_info_any_t *live_shinfo, xen_pfn_t **live= _p2m, + unsigned long *pfnp, int rw) +{ + xen_pfn_t *p2m_frame_list =3D NULL; + uint64_t p2m_cr3; + uint32_t dom =3D info->domid; + int ret =3D -1; + int err; + + if ( xc_domain_nr_gpfns(xch, info->domid, &dinfo->p2m_size) < 0 ) + { + ERROR("Could not get maximum GPFN!"); + goto out; + } + + if ( dinfo->p2m_size < info->nr_pages ) + { + ERROR("p2m_size < nr_pages -1 (%lx < %lx", dinfo->p2m_size, info= ->nr_pages - 1); + goto out; + } + + p2m_cr3 =3D GET_FIELD(live_shinfo, arch.p2m_cr3, dinfo->guest_width)= ; + + p2m_frame_list =3D p2m_cr3 ? xc_core_arch_map_p2m_list_rw(xch, dinfo= , dom, live_shinfo, p2m_cr3) + : xc_core_arch_map_p2m_tree_rw(xch, dinfo, = dom, live_shinfo); + + if ( !p2m_frame_list ) + goto out; + *live_p2m =3D xc_map_foreign_pages(xch, dom, rw ? (PROT_READ | PROT_WRITE) : PROT= _READ, p2m_frame_list, - P2M_FL_ENTRIES); + dinfo->p2m_frames); =20 if ( !*live_p2m ) { @@ -169,14 +356,6 @@ xc_core_arch_map_p2m_rw(xc_interface *xch, struct do= main_info_context *dinfo, xc out: err =3D errno; =20 - if ( live_p2m_frame_list_list ) - munmap(live_p2m_frame_list_list, PAGE_SIZE); - - if ( live_p2m_frame_list ) - munmap(live_p2m_frame_list, P2M_FLL_ENTRIES * PAGE_SIZE); - - free(p2m_frame_list_list); - free(p2m_frame_list); =20 errno =3D err; diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index f0b5f83ac8..8ebc0b59da 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -79,6 +79,7 @@ struct iovec { =20 struct domain_info_context { unsigned int guest_width; + unsigned int p2m_frames; unsigned long p2m_size; }; =20 --=20 2.26.2 --------------BD568719CF22F0C3FB34ED2C Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------BD568719CF22F0C3FB34ED2C-- --56KizhKZjHM3lCODhiMjtgMIgqZQw0VQo-- --qCUDw5HfKVmisMSQaeQuwr9dUW5MlCHlR Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBUcZ0FAwAAAAAACgkQsN6d1ii/Ey8w WAf/XnhgOUWMUC8pLHPITVuLpqov0+nXKZmIePQy/+XW/VT8vzxmkaWq+8TUK7XnXpEj4hzfD3dv XlASRfHQilaH3ZiGTmrh80+6tqEo0jbZQQOJL4Gjj6V4iIXZPhadw//eXEBJFpF9lkAOG9JVMnqs FpR9qK7PjjL5z3ZVmj4EhPVNLLI0wX+GyvAyDuBzX3yMZcwB6GlrogytGTOv7gKPPhVAF1mIEUud Xkhnh6GA0V1DJ3zdIswL0xXyhXEK73rf41S9aB6VGKQ/2gsJXovqPu426A+1M5x8lcixkSWprUkO 2F0IuEUcKMnHOWAIXXQ2dOiRMxlqNW/d1o/hji8Cmg== =wyh2 -----END PGP SIGNATURE----- --qCUDw5HfKVmisMSQaeQuwr9dUW5MlCHlR-- From xen-devel-bounces@lists.xenproject.org Fri Mar 19 10:23:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 10:23:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99158.188355 (Exim 4.92) (envelope-from ) id 1lNCHb-0005mm-32; Fri, 19 Mar 2021 10:23:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99158.188355; Fri, 19 Mar 2021 10:23:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNCHa-0005mf-Ue; Fri, 19 Mar 2021 10:23:06 +0000 Received: by outflank-mailman (input) for mailman id 99158; Fri, 19 Mar 2021 10:23:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNCHa-0005ma-3A for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 10:23:06 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9fda5cdf-89b1-4568-a9bf-434eaa21627e; Fri, 19 Mar 2021 10:23:05 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 29EA5ACC6; Fri, 19 Mar 2021 10:23:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fda5cdf-89b1-4568-a9bf-434eaa21627e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616149384; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wf7SiD2UhTJcHykNRnvUH7BeKEo3lRIyj9GVuRHdhs0=; b=XzAYZplBPi1nk98KJTdamJx0BAJxKo6DPBo/1XrwsLyYq91gEyVMs3g5n+qsHFL+g9r33I peZi7/ImobrLbfFaAXkin5rlx49q0P8Csg22Zzt8g0RoMLIBR5Yjo09OTCwOyZnrTdcDsL P1V38h9TuMyzFZl04Otk43Cix3lXjNU= Subject: Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking To: Tamas K Lengyel Cc: Tamas K Lengyel , Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich Message-ID: <193bfae5-a80a-d02a-377d-c9e11ad038a8@suse.com> Date: Fri, 19 Mar 2021 11:23:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 18.03.2021 22:36, Tamas K Lengyel wrote: > --- a/xen/arch/x86/mm/mem_sharing.c > +++ b/xen/arch/x86/mm/mem_sharing.c > @@ -1761,6 +1761,7 @@ static int copy_settings(struct domain *cd, struct domain *d) > return rc; > > copy_tsc(cd, d); > + p2m_get_hostp2m(cd)->max_mapped_pfn = p2m_get_hostp2m(d)->max_mapped_pfn; Makes sense to me, yes, but then an immediate question is: What about the somewhat similar {min,max}_remapped_gfn fields? Which of course implies the more general question of how alternate p2m-s (are supposed to) get treated in the first place. From my looking at it, fork() doesn't appear to also fork those, but also doesn't appear to refuse cloning when altp2m is in use. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 19 10:27:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 10:27:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99161.188367 (Exim 4.92) (envelope-from ) id 1lNCLE-0005wX-Jx; Fri, 19 Mar 2021 10:26:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99161.188367; Fri, 19 Mar 2021 10:26:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNCLE-0005wP-Gl; Fri, 19 Mar 2021 10:26:52 +0000 Received: by outflank-mailman (input) for mailman id 99161; Fri, 19 Mar 2021 10:26:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNCLC-0005wK-Qb for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 10:26:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNCLA-0000of-RK; Fri, 19 Mar 2021 10:26:48 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lNCLA-0004sx-LG; Fri, 19 Mar 2021 10:26:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=ByQsvHaWqbqT7IjMthJp1f64qUUUnq8G2JVmLNsveYc=; b=Lzg1LRFldjcOt+b5GAg8S2oMNq uV1rTruFVSg1g7o8fPk6b7peuO9kijmDKH74DqTu/AEFl2zgt5p386xSFVA0ZEr9T94AO2pP2eBQt 9ls+ffnBUovz86mg0m7mgpDwMwI+zzm6LJcK3L3vV8Iz4nrHkkuu9x5j2cF/WVuuOmGo=; Subject: Re: Call for tools backports (was Re: preparations for 4.13.3) To: Ian Jackson Cc: Jan Beulich , "xen-devel@lists.xenproject.org" , Stefano Stabellini , George Dunlap , Wei Liu , Anthony Perard References: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> <24658.6228.390535.850901@mariner.uk.xensource.com> From: Julien Grall Message-ID: Date: Fri, 19 Mar 2021 10:26:46 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <24658.6228.390535.850901@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Ian, On 17/03/2021 14:55, Ian Jackson wrote: > Julien Grall writes ("Re: preparations for 4.13.3"): >> On 08/03/2021 09:49, Jan Beulich wrote: >>> All, >>> >>> the release is overdue (my apologies). Please point out backports >>> you find missing from the respective staging branches, but which >>> you consider relevant. >>>> Ones that I have queued already, but which hadn't passed the push >>> gate to master yet when doing a swipe late last week, are >>> >>> c6ad5a701b9a crypto: adjust rijndaelEncrypt() prototype for gcc11 >>> 9318fdf757ec x86/shadow: suppress "fast fault path" optimization without reserved bits >>> 60c0444fae21 x86/shadow: suppress "fast fault path" optimization when running virtualized >> >> I would like to also consider the following one: >> >> 28804c0ce9fd SUPPORT.MD: Clarify the support state for the Arm SMMUv{1, >> 2} drivers (4.11+ as updating the security support) >> 067935804a8e xen/vgic: Implement write to ISPENDR in vGICv{2, 3} (4.13+) >> To support newer kernel on stable Xen >> d81133d45d81 xen/arm: Add workaround for Cortex-A53 erratum #843419 (4.13+) >> fd7479b9aec2 xen/arm: Add workaround for Cortex-A55 erratum #1530923 (4.13+) >> 5505f5f8e7e8 xen/arm: Add Cortex-A73 erratum 858921 workaround (4.13+) >> 63b4c9bfb788 xen/arm: mm: Access a PT entry before the table is unmapped >> (4.13 only) >> f6790389613c xen/arm: sched: Ensure the vCPU context is seen before >> vcpu_pause() returns (4.13 only) >> >> I have put in parentheses the list of versions targeted. > > My backport list seems to have very few tools patches on it. > > If anyone has any tools bugfixes that ought to go into 4.13 please do > let me know! > > Additionally, perhaps this one commit to be backported ? > 935e0836710ce8cab584155b2844cea8497a5159 > arm: replace typeof() with __typeof__() I think it would be useful. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Mar 19 10:27:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 10:27:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99164.188379 (Exim 4.92) (envelope-from ) id 1lNCM7-00062v-UJ; Fri, 19 Mar 2021 10:27:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99164.188379; Fri, 19 Mar 2021 10:27:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNCM7-00062o-Qf; Fri, 19 Mar 2021 10:27:47 +0000 Received: by outflank-mailman (input) for mailman id 99164; Fri, 19 Mar 2021 10:27:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNCM6-00062d-If for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 10:27:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNCM3-0000pM-R1; Fri, 19 Mar 2021 10:27:43 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lNCM3-0004u6-IU; Fri, 19 Mar 2021 10:27:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:References:Cc:To:From:Subject; bh=+W4oxHwqzy81FKgupvP4mnRf46K3U1wqhmvHgeweaSk=; b=VPSQi0WQiTgKc+hoHP3J730Z6D dNwPVKAkm6zTkR5iGIjlM1FkTCbrhk3ZT/xg/atq1OAYys+yL6tffnwRhsMsdv6cqbx9Fii3GpAAD zbAPXWhzUJwTsQw86Ild78G51pnFtvw2hfVNYWWVNMwjBTRC7luQrlSFSqXOsvps0ozM=; Subject: Re: preparations for 4.13.3 From: Julien Grall To: "xen-devel@lists.xenproject.org" , Stefano Stabellini Cc: George Dunlap , Ian Jackson , Wei Liu , Anthony Perard , Jan Beulich References: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> Message-ID: <11f8d1e6-15b2-1fa2-2f50-a30df2fb1a24@xen.org> Date: Fri, 19 Mar 2021 10:27:41 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Stefano, Gentle ping. On IRC, Jan pointed out that he would like to realize the 4.13.3 pretty soon. Cheers, On 13/03/2021 15:29, Julien Grall wrote: > Hi Jan & Stefano, > > On 08/03/2021 09:49, Jan Beulich wrote: >> All, >> >> the release is overdue (my apologies). Please point out backports >> you find missing from the respective staging branches, but which >> you consider relevant. >> > Ones that I have queued already, but which hadn't passed the push >> gate to master yet when doing a swipe late last week, are >> >> c6ad5a701b9a crypto: adjust rijndaelEncrypt() prototype for gcc11 >> 9318fdf757ec x86/shadow: suppress "fast fault path" optimization >> without reserved bits >> 60c0444fae21 x86/shadow: suppress "fast fault path" optimization when >> running virtualized > > I would like to also consider the following one: > > 28804c0ce9fd SUPPORT.MD: Clarify the support state for the Arm SMMUv{1, > 2} drivers (4.11+ as updating the security support) > 067935804a8e xen/vgic: Implement write to ISPENDR in vGICv{2, 3} (4.13+) >     To support newer kernel on stable Xen > d81133d45d81 xen/arm: Add workaround for Cortex-A53 erratum #843419 (4.13+) > fd7479b9aec2 xen/arm: Add workaround for Cortex-A55 erratum #1530923 > (4.13+) > 5505f5f8e7e8 xen/arm: Add Cortex-A73 erratum 858921 workaround (4.13+) > 63b4c9bfb788 xen/arm: mm: Access a PT entry before the table is unmapped > (4.13 only) > f6790389613c xen/arm: sched: Ensure the vCPU context is seen before > vcpu_pause() returns (4.13 only) > > I have put in parentheses the list of versions targeted. > > Cheers, > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Mar 19 11:06:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 11:06:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99170.188391 (Exim 4.92) (envelope-from ) id 1lNCxY-0001N4-Vp; Fri, 19 Mar 2021 11:06:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99170.188391; Fri, 19 Mar 2021 11:06:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNCxY-0001Mx-Rx; Fri, 19 Mar 2021 11:06:28 +0000 Received: by outflank-mailman (input) for mailman id 99170; Fri, 19 Mar 2021 11:06:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNCxW-0001Ms-TO for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 11:06:26 +0000 Received: from MTA-13-4.privateemail.com (unknown [198.54.127.109]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ba289b2c-bdbe-44f8-88f4-7fd22dc5fe01; Fri, 19 Mar 2021 11:06:25 +0000 (UTC) Received: from mta-13.privateemail.com (localhost [127.0.0.1]) by mta-13.privateemail.com (Postfix) with ESMTP id BC1D180066 for ; Fri, 19 Mar 2021 07:06:24 -0400 (EDT) Received: from mail-wr1-f44.google.com (unknown [10.20.151.227]) by mta-13.privateemail.com (Postfix) with ESMTPA id 81EDA8005D for ; Fri, 19 Mar 2021 07:06:24 -0400 (EDT) Received: by mail-wr1-f44.google.com with SMTP id z2so8669881wrl.5 for ; Fri, 19 Mar 2021 04:06:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba289b2c-bdbe-44f8-88f4-7fd22dc5fe01 X-Gm-Message-State: AOAM533VJXnVe4NR1kaH7keU4yreT7lq4GX4GWzL2Ml84dYDCtSTp6pk gycjXljQWFaqwo4GMlWR8Lwyh0UI/oRBDss6Xf8= X-Google-Smtp-Source: ABdhPJx5Sa+PV1wA7EMvqa8I5iJZNyowPoY+9fO8ufPGL/y4Nnvl2HGNLOVfV2BeAUdA/y4OuUZgNMypGYLGMOaH09c= X-Received: by 2002:a05:6000:1868:: with SMTP id d8mr3950424wri.301.1616151983275; Fri, 19 Mar 2021 04:06:23 -0700 (PDT) MIME-Version: 1.0 References: <193bfae5-a80a-d02a-377d-c9e11ad038a8@suse.com> In-Reply-To: <193bfae5-a80a-d02a-377d-c9e11ad038a8@suse.com> From: Tamas K Lengyel Date: Fri, 19 Mar 2021 07:06:10 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking To: Jan Beulich Cc: Tamas K Lengyel , Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Xen-devel Content-Type: multipart/alternative; boundary="000000000000ddcee005bde1b4dd" X-Virus-Scanned: ClamAV using ClamSMTP --000000000000ddcee005bde1b4dd Content-Type: text/plain; charset="UTF-8" On Fri, Mar 19, 2021, 6:23 AM Jan Beulich wrote: > On 18.03.2021 22:36, Tamas K Lengyel wrote: > > --- a/xen/arch/x86/mm/mem_sharing.c > > +++ b/xen/arch/x86/mm/mem_sharing.c > > @@ -1761,6 +1761,7 @@ static int copy_settings(struct domain *cd, struct > domain *d) > > return rc; > > > > copy_tsc(cd, d); > > + p2m_get_hostp2m(cd)->max_mapped_pfn = > p2m_get_hostp2m(d)->max_mapped_pfn; > > Makes sense to me, yes, but then an immediate question is: What > about the somewhat similar {min,max}_remapped_gfn fields? Which > of course implies the more general question of how alternate > p2m-s (are supposed to) get treated in the first place. From my > looking at it, fork() doesn't appear to also fork those, but > also doesn't appear to refuse cloning when altp2m is in use. > It's untested, forking and altp2m is not currently used simultaniously. Don't know if it should be restricted as not working as I haven't tested it. Both forking and altp2m is experimental so there be dragons. At some point I would like to be able to use altp2m in forks but forking a domain that has altp2m enabled will likely be a setup that's too insane to try to get working. Tamas > --000000000000ddcee005bde1b4dd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, Mar 19, 2021, 6:23 AM Jan Beulich <jbeulich@suse.com> wrote:
On 18.03.2021 22:36, Tamas K Lengyel wrote:
> --- a/xen/arch/x86/mm/mem_sharing.c
> +++ b/xen/arch/x86/mm/mem_sharing.c
> @@ -1761,6 +1761,7 @@ static int copy_settings(struct domain *cd, stru= ct domain *d)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return rc;
>=C2=A0
>=C2=A0 =C2=A0 =C2=A0 copy_tsc(cd, d);
> +=C2=A0 =C2=A0 p2m_get_hostp2m(cd)->max_mapped_pfn =3D p2m_get_host= p2m(d)->max_mapped_pfn;

Makes sense to me, yes, but then an immediate question is: What
about the somewhat similar {min,max}_remapped_gfn fields? Which
of course implies the more general question of how alternate
p2m-s (are supposed to) get treated in the first place. From my
looking at it, fork() doesn't appear to also fork those, but
also doesn't appear to refuse cloning when altp2m is in use.

It's un= tested, forking and altp2m is not currently used simultaniously. Don't = know if it should be restricted as not working as I haven't tested it. = Both forking and altp2m is experimental so there be dragons. At some point = I would like to be able to use altp2m in forks but forking a domain that ha= s altp2m enabled will likely be a setup that's too insane to try to get= working.

Tamas
--000000000000ddcee005bde1b4dd-- From xen-devel-bounces@lists.xenproject.org Fri Mar 19 11:26:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 11:26:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99174.188403 (Exim 4.92) (envelope-from ) id 1lNDGH-0003HC-KG; Fri, 19 Mar 2021 11:25:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99174.188403; Fri, 19 Mar 2021 11:25:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNDGH-0003H5-Gf; Fri, 19 Mar 2021 11:25:49 +0000 Received: by outflank-mailman (input) for mailman id 99174; Fri, 19 Mar 2021 11:25:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNDGH-0003H0-1G for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 11:25:49 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ea2e306f-e8d4-4871-9f35-c569a93774a8; Fri, 19 Mar 2021 11:25:48 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2B553AE05; Fri, 19 Mar 2021 11:25:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea2e306f-e8d4-4871-9f35-c569a93774a8 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616153147; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gX7dBS8PxOqB1DHdSEvhEbIqa4PyVCfh0UAbbhQCg3E=; b=J8Jq+P+ryR8k3dNIDTRk+kbGkTaEFc3Qlv6BFTsgcYp+8DtNBtKdVxQsxKHa5a8AmQMB6e myvdhpvT/DPIKN3WPxBre9zOaojAu0KSXaE048L5P/z9GD1pZWtAwNN5RA4txdF1rN4Nsr FEveI5Zl8v8mGOgSSrgvEJiaXNLEWsI= Subject: Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking To: Tamas K Lengyel Cc: Tamas K Lengyel , Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <193bfae5-a80a-d02a-377d-c9e11ad038a8@suse.com> From: Jan Beulich Message-ID: <960d2a7a-7be0-58f8-56cc-26d1fa90b7a0@suse.com> Date: Fri, 19 Mar 2021 12:25:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 19.03.2021 12:06, Tamas K Lengyel wrote: > On Fri, Mar 19, 2021, 6:23 AM Jan Beulich wrote: > >> On 18.03.2021 22:36, Tamas K Lengyel wrote: >>> --- a/xen/arch/x86/mm/mem_sharing.c >>> +++ b/xen/arch/x86/mm/mem_sharing.c >>> @@ -1761,6 +1761,7 @@ static int copy_settings(struct domain *cd, struct >> domain *d) >>> return rc; >>> >>> copy_tsc(cd, d); >>> + p2m_get_hostp2m(cd)->max_mapped_pfn = >> p2m_get_hostp2m(d)->max_mapped_pfn; >> >> Makes sense to me, yes, but then an immediate question is: What >> about the somewhat similar {min,max}_remapped_gfn fields? Which >> of course implies the more general question of how alternate >> p2m-s (are supposed to) get treated in the first place. From my >> looking at it, fork() doesn't appear to also fork those, but >> also doesn't appear to refuse cloning when altp2m is in use. >> > > It's untested, forking and altp2m is not currently used simultaniously. > Don't know if it should be restricted as not working as I haven't tested > it. Both forking and altp2m is experimental so there be dragons. At some > point I would like to be able to use altp2m in forks but forking a domain > that has altp2m enabled will likely be a setup that's too insane to try to > get working. Well, I see only two (consistent) options - either the other two fields mentioned get copied as well, or altp2m use results in forking getting refused. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 19 11:44:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 11:44:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99177.188415 (Exim 4.92) (envelope-from ) id 1lNDYF-0005BO-7V; Fri, 19 Mar 2021 11:44:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99177.188415; Fri, 19 Mar 2021 11:44:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNDYF-0005BH-42; Fri, 19 Mar 2021 11:44:23 +0000 Received: by outflank-mailman (input) for mailman id 99177; Fri, 19 Mar 2021 11:44:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNDYD-0005BC-GU for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 11:44:21 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 38c56a9d-daad-40dc-b33e-c88cedfc3d4d; Fri, 19 Mar 2021 11:44:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38c56a9d-daad-40dc-b33e-c88cedfc3d4d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616154260; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=w90PAMN+ZOc/LLOMhwDArwCDErFYNiB+ygI+sb58HKw=; b=fhLySOvVbwtelL/mcpyYI+f4J9+bxBDPtu3jdsNdIjrPdRAau5486Vm7 x742f1hggMj0LNIBuQj+o+E1UXgjj0IQg8Snec3OualW3s7jPRn03euCl am4WW7ie1+bxGpMCRVw/UyyPI9lRVe2jijoTlQ/OGQrv64quazhZrG8kl k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: S0bNys7qSRVcbbOw01R1xl0ksa/Gt+YyBclHvy35D7lKcLKhVhP9wV371QhBpaMU5Jpr14jXD0 ip+2znOa7756CDer+3xUf7u7o5zGWQv3qXMZlJP1Jx0oT0F9bWGRmdr0vz7txBv6vzrcuYKDYj d76Y12FSVIssOwjfpjz0qvlihK5s3LSRtPgnPWYD4kf1SyClXL+A8hBDQT3sEcZ5yRCcpuUUf5 TU+ugqEGW+XmfMs/o1B3tyLRdLPG1CRzWx+CE3v+Mtcfatsari3/taICYfJVi762fyKGX6s5kV 3oo= X-SBRS: 5.2 X-MesageID: 39665510 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:F1ux265MyG9NgBzRoAPXwWeEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoex3h3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdBHW3tV2kZ 1te60WMrHNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2FXQotLhj0JbTqzOEtwWQVAGN4dHJ 2T+sJIq1ObCAoqR+68AWQIWPWGmsbCk4jobQVDKxks7gSPij3A0s+ELzGz2BACXzRThYoz6G StqX2E2oyPkdGejiXd2Wja8ohMlLLaq+drKcSQhqEuW07RoymyYoAJYcz6gBkUp6WV5E8ugJ 3wpX4bTrlOwlfwWk3wnhf3wQnn118Vmg3f4HuVm2Hqr8C8ZB9SMbs4uatjfhHU61UtsbhHuc ohtQ/p1Os0fGf9tR/w6NTSWxZhmlDcmwtFrccpg2FCSoxbUbdNrOUkjTBoOa0dFyH34p1PKp gKMOjg4p9tADenRkzCsnIq6NKhWWlbJGb9fmEy/uaR0zRQgUljyVoZyME1jh47heIAYqgByO LePqtykrZSCucQcKJmHe8EBfC6E2rXXHv3QSyvCGWiMJtCF2PGqpbx7rlwzOa2eKYQxJ93vJ jaSltXuUM7ZkqGM7zO4LR7tjT2BEmtVzXkzc9To7JjvKfnebbtOSqfDHgzjsqJuZwkc4/mcs f2HKgTL+7oLGPoF4oM9Rb5QYNuJX4XV9BQksonWmiJvtnAJuTRx6/mWceWAICoPScvW2v5DH dGdiP0Pt984keiXWK9rwPWX1/rZ0zj7bN9GKXX5IEoucwwH7wJljJQpUWy58mNJzEHmLcxZl FCLLTulb7+hWTexxeO00xZfj5mSmpF6rTpVH1H4SUQNVnvTLoFs9KDPURb3H6NIA5DX9rbeT Qv4WhfyOaSFdi91CoiA9WoPiaxlH0Ivk+HSJ8ah+ml6dr6fIg7SrIrQrZ4GwmONxEdo3crlE 5zLCs/AmPPHDLnjquoyLYOAvvEStV6iAC3ZehOqXzesk2Yjdo1RmQSWgOvVcL/u3dqexNkwn lKt4MPiruJnjiibUElhv4jDVFKYGOLRI5dAB+9f4VSkLDzcARWRWOH7Abq0i0bSy7PzQE/l2 bhJSqbdbXuDkBGsn5V6Krs7Wh5b36QZU52d3B8v7BsDGiugAcH7ca7Io6Il0eBYFoLxe8QdA vIZjYfOStC7dG63hz9okfOKVwWgrEVesDNBrUqdL/enk63IIqTjKccArt/55B+Lu3jtecNTM OScwKYNynDFusswgCZz0xVYBVcmT0Bq7fFyRfl5G+30DoDGvLUOk1hXKxeDNeG7WToLsz4mK lRvJYQh6+XPWrwYNLdlv2SQD5HNx/JoWm5C8svsotZuKoutL11W7nXOAG4ok1v7VEbFoPTkk hbfYFQpJbmEaVrd9YJey1Y8kEy/e7/ZncDg0jTOKsGYVopj3XnJNuH7LrDlKo3DiS61XzNEG ja1xcYwuzMUCSC34MLEq4cIWxZb04n9XRpldnyPrH4OUGPd+tZ+kC9PWL4WLhBSLKdEbF4lG c33/i428uWfTH/wgbeoH9SJb9P6X+uRYeXDBiXEeBFt/y8NlLkuNrk3OeDyBP2QyC8cUIWmM lsclERdN1Kjn0at7IMuxLCAZDfkwYCiFtR4TZui17r1MyH2Q7gbDB7GDycpI5XUzlVOmWPlu Lf/4GjpS/A3AQ= X-IronPort-AV: E=Sophos;i="5.81,261,1610427600"; d="scan'208";a="39665510" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fXC1cOI5IZAtlWV0DL0HeS98u7uMhMOKYJKXrJh0oBd855Amy3jYvUFmo4AJHGvCQRruWJ91CKCoNZ8P9DO/zqu+waiUbqkx7rm3G3sKkEfYkiwPNCehtrkvdAnFsv1spqINnm5BzZ00CleGfuwSYzDSjmVv1TdtdKMjnl0Uq3mU7+CPqiy0fq1DTqEhdyYIP8jp6TLg6gShtBuzU7WEX8X0/9gUSQbpfFKGSqMl5dPXeaqNcKkit7rQfWopOe6a/xO/p1rbkDlK4HG843S25piSQGikJbz3sUsOsk3BsCIbnDRebRzf1rCu0ANmSOCr4KohlLOc+/5SOysrf2KmUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w90PAMN+ZOc/LLOMhwDArwCDErFYNiB+ygI+sb58HKw=; b=E5Jx6DAnbF7HwrrdrN7IQYwEo2kpdsJyNArz6mWZc/AySHPxdGyar/rDB0lYZquj47vrYvUZCOiLmBGrJoxeznbRCGxpWfOKRTYKvLFPelzlIqIeJB35qzJvpY6cKbC7tOFS7ud+kiopWu6UpqnoUmknKSo7CsP3Ma4RUvQo1jv6tw7FSmMTK7uaYccL5JfYHFIXuGDfI4RnZZuIsfccDsjPkzm0Bb+//WRf7cnTkMChvsn89DVYiyx+qZW0t0tfIYWp+PmHmjgavi1+mM3Mm1JsWjeIu+6EqZf/TGiP1sXaHde93zEc5PfeSgl1I+yZVaAR/doDOviZHgtF/5kGFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w90PAMN+ZOc/LLOMhwDArwCDErFYNiB+ygI+sb58HKw=; b=er+gmSKhdbJQD+gQWCZ66+Y1D78k8MJhGB62jE5cdBd11HXen/E0yRc5XWXKGWXm/mvdxwptaIppinJsTdhugjShKHdZafIzO4m0OyDyvh/qYmyytCJkaXmBN3LpbYv3CB2nGF/8jx1WTCUIhqQuhzQepnZT+mzXiPDQ9dlQNFA= Subject: Re: preparations for 4.13.3 To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: George Dunlap , Stefano Stabellini , Ian Jackson , Wei Liu , Anthony Perard , Julien Grall References: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> From: Andrew Cooper Message-ID: <7b3a06af-103a-db05-b494-94f5a1081bc7@citrix.com> Date: Fri, 19 Mar 2021 11:44:09 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0511.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::18) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 89308fae-0f2d-4be2-d9d4-08d8eacc52d7 X-MS-TrafficTypeDiagnostic: BN7PR03MB3620: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1HXqhpPZoTx2phesDRLB22Se/sqV/uOBRR/mkUeomWvRWLvSt+u9bUT6x7so5S1EK/wnxqkSbgAmTSVBALWcWpheH4iU/WSrUbnpTCmS921APfIVOPJ1jQtsSDmdzFaCrJpadGy8uMgRcgIJ7I55s2VhbxxPhSQSn8Uc06lY8e3K05DLSx/XYzmIwl42q4bf1AsawlSGbH8t5P31NwGi30XnRTbnnlA21Umxd5kvrcgU1H1IKLk/uvyeRXTjyTU/zCMAvm9DUr54Er2hH2es9UhPequjmvn3oBGIenjXhYXgZPUDFGm178g6dw8RDLS5oyjcB8CNmJXx8KPX4T4XDh4aTxb7BBgP8O1xB+qdbDYLnlfvuXQMmGtsQ6UgZvmBfluNiJeJAVC5S0bAwJqEHwnFI777JZVci05vaTfYEK9hq8h16pDWln6p2d/zKKzlYUuKkSV6aKaF+jHCVwjHdLyRRaVplgRFlJq2iKnlk7hyxt0UKZtfIxFk8OPtsgmALzky15V5bqYWosUAmc7JVGYHYGSSFK7UREJciwqpEd+Nz/4vrOD6n6vE3yCA94y6l6o0ZSjaCSwb+xC0mH+KHfsxp+dvhj35ABbw9Jg4P6TKn8YkvOAtV9iYMiKwjRQXgwu0rXwLm9XkCBQ1ee0f5V+Or34Wg/18pjVlDNh3uC1foUXAhNOu7iZZvzWqRA0chBHpV/drg/dL1rtOaHKF4BcDvPX7vIDUef+oEGyH2tA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(366004)(39860400002)(396003)(136003)(31696002)(478600001)(66476007)(66556008)(2616005)(54906003)(66946007)(316002)(53546011)(16526019)(86362001)(110136005)(36756003)(38100700001)(26005)(16576012)(6486002)(4326008)(8936002)(31686004)(956004)(7116003)(2906002)(5660300002)(186003)(4744005)(6666004)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?SnVETFZaRjkzV0RDRG5MdVFRU20xblpKdWhNMUhxaDJmSzcwbUZJaXNpeTVt?= =?utf-8?B?ZmlMQ2xEcmZqZGJqZEh4RGtzeUtHSHJxWWt6dW5ZMmxRZDZ4RXZ5L3B0bTlX?= =?utf-8?B?amR4dXVCWExhQTBKbENKalRnK3NQUmprenptMllvU2hKQXR4Q3A5QldsSys5?= =?utf-8?B?THgva0h1UlZtVFZkTFJTVUoyRVRUNWpPMWFONlQrbGZWejdIRUp1clM2aGd5?= =?utf-8?B?Z0krS0hwejk4WDhjTS82M0ZhaDZzb09pellFN0xsNmV1bXdmTTArdEZOdE5U?= =?utf-8?B?WmZOeXRoSmFSQXhqZHlWQlhSSlEyQTZPR0ZXV3YwL1R1Wm9PcCtQcVYySVdT?= =?utf-8?B?VE91WExOdHM2dkZ0M0FOQ0RoOURPaHNhc1g0QUY0NzFyKzM0cE8zUDY5NS9W?= =?utf-8?B?K0xZaEhjMTBlZ3MwTDMyNGhOYS9hckxZMXYzdVZsblpMbzJBaEgzV01UdkZL?= =?utf-8?B?aVZUTzZFU1VBaDA0enVRVHVWbDQ3SWdtRG53TTk1c3A0NGUxZ0RxU1dwQnV2?= =?utf-8?B?VWs3RVp5bGVtN3hJSWlYdDZ1Y3RNVlFmK21Wa3FvMkZuU1RqVkh3MW1weDZv?= =?utf-8?B?YUdzUVBkN2d5N0pKYUF4OHVFSzNOMFZWZ0VJU083SDF0bEdZTkJGa0c4ZDlI?= =?utf-8?B?TkQyMElYTDlxQXlSQk5pVi9iMGVRYWV2dlVpQ0diR1d4QU1Db0FSbXpkcXZR?= =?utf-8?B?TkV2T2tuREM1ajluSURCZEtMdjBtemZkQUlJT1lPNS9XQ2tDWnNxdC9jeXVa?= =?utf-8?B?NGZ6SDd0aTNsRnVReDFDUWU0TEhFdmZGVU9PeTA3eFJBQ3FPS2hac0JlMmhQ?= =?utf-8?B?c0dyUDFDbUFaaFdnSTNDV214YW9NT2MvcDBxTFJiVGQ0a2VCNjNiRnhFZ0xm?= =?utf-8?B?WW9VRXpTVGpCdTlORW8wcE9ML0Y2TzI2aFhwbmdnMmpMNWFPNjg3aDRBRXFE?= =?utf-8?B?UnlXNENlM1lSWFpKUG1pRFpLL1o5dSsyQ2tYbjJlZ1hneEFrM21QTVdCQmFR?= =?utf-8?B?ZnpDOVpqd0pEc3ZYSFJ5cXJmTE5QeDhuUGhxSDc5ajQyUzNGRmZPWFJXbE1k?= =?utf-8?B?NHF5N3U5Q0Q2NmNKdldDeE1GZ2FqcWszZEVEWnowdU1JZ1B3TlN6OTBrYldH?= =?utf-8?B?OWQ4MXM0d2JBNU1TVU1sSm5ZSHRCTm53Z1RzY1dkVnkxWVQxWWZEZkd1SGlG?= =?utf-8?B?UGV3YXE5amNNZkk1MG9NbEhxaXA5YmI2OVpGZ0lDaUNpMzRHUm5acC9IdE1Q?= =?utf-8?B?RUR4T1NzS3N3NFFRUGR0cUxFSmNXa0hiaWRZZ0hZT0x3MkNyRTBROGh2ZXdp?= =?utf-8?B?NVJkSkFqeDFwUGxRaFVJb1pWWXdYZ3dxMWJOQnlvUjVPNko1ZEJkK1ovaGl0?= =?utf-8?B?WVV2TGtyMkk5V2dadVp1WXZGTkZxYlRoM3c4QUpVcE8wNHdVWU9nYkxIM1hx?= =?utf-8?B?MWkwT1l4NjM1Z0F5WGxQSW9VNXNrVXpkSUFzMXAxSzVjZHhoZXlpTkh0RHRj?= =?utf-8?B?VnBjVmlSSWp3SW1ETVRRaTVuUkJidW5UNlNqVUNPaGwyMXRRd3B6S2V3VWpZ?= =?utf-8?B?TXFrTlFhbk9xK09XclMrcGpaci9MMDczbndEa0xmT1VxRG0xZXdWTFJMYUh1?= =?utf-8?B?OUEwb2RSSERLeDF2aC9VTkhKc3R5UFFIRHFIUHlyckRUVU9ZdGVrTTBLMERL?= =?utf-8?B?VXBBTVhpMEFYTC9lMnBpcTQ5aWRiNHZ4dzUyVzd3WmZGVDZDeWh4NmNJdm5E?= =?utf-8?Q?c+clGdIJW0CO2s1DxfO22WNZ6W2BkLccWA39Ysg?= X-MS-Exchange-CrossTenant-Network-Message-Id: 89308fae-0f2d-4be2-d9d4-08d8eacc52d7 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 11:44:16.1748 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cedvezWIZbaJ0w0z7YVOZ8Dk4DQTkWC4aEOF8Gh842Qooor9S7MwxbFPhE4GS57H5ocNFDnepR8soaWaaJp76GCQowSBlnj8G677YrQkrCc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3620 X-OriginatorOrg: citrix.com On 08/03/2021 09:49, Jan Beulich wrote: > All, > > the release is overdue (my apologies). Please point out backports > you find missing from the respective staging branches, but which > you consider relevant. > > Ones that I have queued already, but which hadn't passed the push > gate to master yet when doing a swipe late last week, are > > c6ad5a701b9a crypto: adjust rijndaelEncrypt() prototype for gcc11 > 9318fdf757ec x86/shadow: suppress "fast fault path" optimization without reserved bits > 60c0444fae21 x86/shadow: suppress "fast fault path" optimization when running virtualized fe36a173d110 - x86/amd: Initial support for Fam19h processors 90b014a6e6ec - x86/ucode/amd: Fix microcode payload size for Fam19 processors ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 19 11:51:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 11:51:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99182.188427 (Exim 4.92) (envelope-from ) id 1lNDej-0006A2-4D; Fri, 19 Mar 2021 11:51:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99182.188427; Fri, 19 Mar 2021 11:51:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNDej-00069v-0i; Fri, 19 Mar 2021 11:51:05 +0000 Received: by outflank-mailman (input) for mailman id 99182; Fri, 19 Mar 2021 11:51:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNDeh-00069q-0n for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 11:51:03 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (unknown [40.107.4.77]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 22c7f23f-f1f0-4305-b23b-c4180d84012e; Fri, 19 Mar 2021 11:51:00 +0000 (UTC) Received: from AM6P192CA0034.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::47) by DB6PR0802MB2152.eurprd08.prod.outlook.com (2603:10a6:4:83::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Fri, 19 Mar 2021 11:50:58 +0000 Received: from VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:83:cafe::21) by AM6P192CA0034.outlook.office365.com (2603:10a6:209:83::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Fri, 19 Mar 2021 11:50:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT033.mail.protection.outlook.com (10.152.18.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Fri, 19 Mar 2021 11:50:57 +0000 Received: ("Tessian outbound 04b74cf98e3c:v87"); Fri, 19 Mar 2021 11:50:57 +0000 Received: from cbfe67f02811.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6F664234-22C8-453B-A036-C0491DE8D40A.1; Fri, 19 Mar 2021 11:50:48 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cbfe67f02811.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 19 Mar 2021 11:50:48 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) by VI1PR0801MB1840.eurprd08.prod.outlook.com (2603:10a6:800:5b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Fri, 19 Mar 2021 11:50:46 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642]) by VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642%4]) with mapi id 15.20.3955.018; Fri, 19 Mar 2021 11:50:46 +0000 Received: from a75445.arm.com (82.8.129.65) by ZR0P278CA0025.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Fri, 19 Mar 2021 11:50:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22c7f23f-f1f0-4305-b23b-c4180d84012e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FM0m4dceXDmzZ5Y7JaceturxEaCYIsESfTG+xWu/3Jo=; b=GBAZyJGl+ZoC0HwSAJfuiOhUaqBXtC8Po+1RXqI+4KPa5fUIemueq/hZVmIqdqHyLEQ7AVnUOtJ0QXECUy0KRqdIC9UYQxsUFX4NZbdy5h6labSBULq2maGyYq37JXxAX+ZCYZdP6AKMr9686jB/k3/xmQGIN0NFixhghHbLC1s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: b6d4a71b84555dc0 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NcZevTLp94gHBVhnzZ+9QPGL9Y19iGA4S75+WwzDsPnbQJYFuWUja9Lk5PWyEwmDRdutmXXh67WkmegVuCPtSyKzFKfU/KKpylOCCPVy5kFeO+G+CV8iF4hpjY+mjPgnisvv+psWOh8cLVPPjxvhGNA88SgruaEZ6rMsBZlsJefRhSh1t1OeZLneTsXNrYEzv4KzcFMQNtHiQiNlo+L/EQf1pgSJhFfZS/png8+M8ptmzWMrNDmf/CHsTf3ljjwac4AQTXFt7UnUvZSCxLSOnWqtMQn3rdbUMRSNTCHCA2V8tu11p7fiA507WeiyAgEhFLTfJQ/MT1WXR9pLpFcU+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FM0m4dceXDmzZ5Y7JaceturxEaCYIsESfTG+xWu/3Jo=; b=fF5/ZULUiSXUepTHfrtzTgTo8uqScF4K1epq4G9nXIu8P81L5aR2e0wOnqyinmKZ5DwnuV3HrzAfXiJr8jBBjdZONJLw+vfzbI8OL8sHdqKOq6OYuwZj9JEZj8mmsR4Hk9PZmcCPa9nGLjB7LWfQe0NfZVGk8MD5C9KcwsWwPqEh6WIGJrgJoYyISdVji/rooXrBep/IOolNRzz9D4tEHEKi4Dd8Eqt9R/gP/WC2JhVBFxVcRaf3CMeyMSd05YKD5gsREVRNZkhtQDotY/OK2M+HJgw8UR2yVuipHWbyGTARUMxo3rqNUW9NbckP7Y7zUS/zukkQSJ4xX9xMF+hbuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FM0m4dceXDmzZ5Y7JaceturxEaCYIsESfTG+xWu/3Jo=; b=GBAZyJGl+ZoC0HwSAJfuiOhUaqBXtC8Po+1RXqI+4KPa5fUIemueq/hZVmIqdqHyLEQ7AVnUOtJ0QXECUy0KRqdIC9UYQxsUFX4NZbdy5h6labSBULq2maGyYq37JXxAX+ZCYZdP6AKMr9686jB/k3/xmQGIN0NFixhghHbLC1s= Authentication-Results-Original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 From: Luca Fancellu In-Reply-To: Date: Fri, 19 Mar 2021 11:50:39 +0000 Cc: "xen-devel@lists.xenproject.org" , "jgrall@amazon.com" Content-Transfer-Encoding: quoted-printable Message-Id: <1FAD6C91-2B3A-48F0-88D7-CFCFC8B53BA9@arm.com> References: To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: ZR0P278CA0025.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::12) To VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: dc292da0-6b18-44ee-9d08-08d8eacd427b X-MS-TrafficTypeDiagnostic: VI1PR0801MB1840:|DB6PR0802MB2152: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: g5rsz/HuW/dBIUSeAemU4EZ1wRscmlQbYvPluNC8soBybCIq2iVtej9SYhrXC+OsY7mjfuK2GjH61/a4C5h1n5Aol0h/GZ+T+s6szgr3h/7J5hF4kd54LQg3q8PGA/05usZ9Enc2oMf5RTi1O4h42xvlo/fjC3cWLdKikiYQq3t/4C19foixVFlTxVIb3ciCNLgOXnZfxw+HJLEEMPJyDAe84FDSalWZukIDD1pYTX9B2bGivqM4H1hfN0/UtUdDN3Cpspf6JjcspdE2GH6jdQSSPrkpPel+Sz8DRmCC/AXyOqa+JYS26J1TPBCb7+6Pi7MvWEEFNARJoRoaM9hO1ldWa55afzqMvy0ycssOJfuN/pWbeZSUK36LtU2xC5PLCU2RKsbctb33RZmlYFl2QF/7ZqU+7vPTwbnfQTrm5PGMA2gG+rvCmz8yYWvxyq/6x6B4xpN39/sGXpwFRo8Z7r0F3J93VugCIqnRXx4M2GtwUQHkWz375bqwd1c8aumlaia1+pOBZqTgXyJLhP/67rE0bbhnkgCReBfQs+oV0x8Ko1AsFn4IzbJ7FpFNdnTwESE2yBAJB62sktV9pn7Q3/b6HKlqUwReuE5XPyeiapr8JIXHgf73npRRBWAZO1kFHbfu+qaupyi6qUiS0R3tIOlgvsdmJ8qQLBLI9PbbKu67QwHCXOfYiRESYtv3FghXnzJYLAd9qTg1O15T28rKpxI7eKyULWH8v+/w/JyWOpFQzQ6nXBmyMj5YxGDXECzxu5JS0Y6tBlyai+ZRsH7u8Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3629.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(346002)(136003)(366004)(396003)(8676002)(16526019)(186003)(66556008)(66476007)(54906003)(316002)(478600001)(966005)(2906002)(26005)(66946007)(8936002)(36756003)(45080400002)(6666004)(83380400001)(5660300002)(7696005)(44832011)(6916009)(33656002)(66574015)(53546011)(52116002)(38100700001)(2616005)(86362001)(4326008)(956004)(6486002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?azVWanM1ckdGZUVDS3o3VWRiN2RqRXBUZ0YxcHlyM0tVK3Mwd1hIZFhFQU0w?= =?utf-8?B?VE9XcW5KZGJnMzNwZ0FraGJ4NmtXUDljcW5GK0s5Q1dUaHBlc29odDJhZWVS?= =?utf-8?B?VWo5TjRFU1JGSjQ1TnFwM3loVEpMc3FHcFFUTXpLQjllbEFLOFZzQUQ5U0JU?= =?utf-8?B?aGt2RmQwbnFlbEp6RHZvUGd5eFovZU1yZTVLdWNhUmFyUW1KL0EyYUk5bjFi?= =?utf-8?B?cEc0Y1c4eGkxVTAwMjZFM056Y3RQbFhQOHVYanBlNzk4S0hZNyt5bGo5Sndu?= =?utf-8?B?THJxeXVNcUNwb01samxnNFBmeWU0bnJmR29PN0ZVMnZFN09XTHAzcWtSYnEz?= =?utf-8?B?cVJKRjg1TkVDU0VWL3o1a1JzT0dvNjhCT1pWd1I1NEEvZjI5OEMrcHJ4V1pm?= =?utf-8?B?RGhKZkNMNGxHMzgrak00VHh5dEtMUzk1cGlpdm02MHlFOWNYRXoySzBObTJ0?= =?utf-8?B?dDJ2alE0SDRZSkg3ZFRQWTBqMnpxbjMzMjQzQ0V2eFhvUlBoa0JFNTRieXVj?= =?utf-8?B?eUU0djVRUDB5UzRkbnRwUE00bWhWWkZ4bWhxMkJGUjV1TmlVWGMwSEdlSys3?= =?utf-8?B?UEdtNUN6RCtuWGk5ZXNZSWMxbTFDSkp0b2llT3RLZHNhdjVRMEdMRlZJSDlk?= =?utf-8?B?aVFXcDJiQVgxckJ1MzBGdml6SEZFL3prSXI1emFtSTNyRGFWczVIa0dQemh4?= =?utf-8?B?Y2lRcURjVVVmNHpKSGJLZUt5N1lHQ1o1c1hxSjhabVFGcnNOcnF3VnBrc2dD?= =?utf-8?B?QnlwNFloZFcwZ3pncjdhYnFyb25LVkRJREJBY0QzTSs4bmlDRUp0UDNZdGpB?= =?utf-8?B?eG1PZDBFRndRU1h2c2MrMTFwdVByWkJPRGhrd3IvNkxDWXdiSkt1RzE1V1d3?= =?utf-8?B?WGNLYlcwa1M3dUxXQ1B2a1dFMG1LNlNqdXg2S2xIR1lOekVCRDl0ZlVGKzND?= =?utf-8?B?bHFtR1M3dVlkbjRqUXc4c3VqWjdrSkc5SXZnUGMyZjhaTDZOcHVDUFJXaTQv?= =?utf-8?B?UGhBVzRjdnJHQUROMWtxOERqNHVNWFUwRG96S0FHb1Zlbk9QVk9pUGRKdGVj?= =?utf-8?B?dkJNbmlWNkZuL3RVK1Vib3Z0OXN5SU5iMEpTTHV0ek9GS2picDNKclc2bzU0?= =?utf-8?B?aThCOW5Mbnd0RmRNbFhSay9ZcHBwUkx0cnppQVNVZnY5ZWZtWHlJYklXQnlB?= =?utf-8?B?MUxCWkFuV3pQVjNJM0MvaEpKMDVJZDFEaUpuZ08zZDJPaXl2bW5mSGsxcGRk?= =?utf-8?B?WWM2NUFIdGY2V0dUQ2xVd2xacVJtTTBwejVQQUx4YXpWcURuaVdsOE8yOFV3?= =?utf-8?B?dUdhTFZRNzJNaW9IUEN2MzBVc1h4K3V4V1I4eC9rSzE5cmtldG9xVG43cUVq?= =?utf-8?B?MytuRjRTRjZzZUlsQWJ5TjhYS0RpL1ZXWEg3M0szSmxhdEVIdFdzSE5QWkVC?= =?utf-8?B?dU8yZFljT0FzYjl3QzhKd1JEUHhVUXVTclZDQzUxdE85UEVYQU4vS3RzVEFI?= =?utf-8?B?b3RKNHUyU3hpd1djODhYT2c2T1dKNWZRTTRPQWxGbUdYNEtlQmx3LytFRVk1?= =?utf-8?B?cFNkK052QmlENHkxOTdRMUs1bE0zTmozRjhmcmNBZUEzOXp5bUI0TE5HVG1F?= =?utf-8?B?K1BzMWEvYWdkeitrZml6R0plUjVzZ3lzYUc5OGlkUURiOGNNWTZEdHJzdUN0?= =?utf-8?B?enN3dkxtRytSdzFHTHJBdGRCTm5aeFhPSUNLZldxamVORVhTdUxNT3EybjJU?= =?utf-8?Q?9Bfc1vmlzfwXQ9H6IUpQxuTZKaSWBclXZNCY6t/?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1840 Original-Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 2c15a93a-3aa7-4afa-49e0-08d8eacd3b74 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZMSkkh22pCgXkGUuBw+o0Bb4ykMsWjG9Ht3TaQmulYE8+kdN0VAw99AlgsBl0lHpD2P5E0Fs6quqkp387sfdaX4sGt0Hkr9Wu1SgWpyprggmHgYj4rZ+uzhAkQ4BMLr4ZbGfAe6FakfyonfGXy63B+NvujSXOd8lOJBo1s96HzjqPUtfO7saf3HND2fSyW0UgCrLuM+q3RThZn04gfaaUONI6x4DUmftKEUYmJF4P3z69Y9KRIaBIEt++Rcp2hX1Is+2ilZ+bltGdZzEIcwRs73fmg+5BSiieOJ/hZNahlFlRxXtdS2VEy7fjPeH2vrS92MRBNr5odSxtbIxH2uq6LgWv7VlbyQ933SD2lHIAHUmxse4MGetOEqhjMurjLVotJlvCyeXJFZ5vYte+61iY/kxObv9GRQTFKBIH+uVZ3VzA+vX2uC6wbbzRKTJZjx7SNPF1Sa+p/kDle9wL54Q+8oDfGxFwu6qllrHi9dwPrxP1qRxsZnVrvkj4DKnRbeMrCCXBSbJ1yf9bR83I+OaVjpg5DAgdFgrimnu87GUW7a+mYrV64c2ZGUf6jARM+FVtnxuSqQ0Am0Y3UoRggMNbonJhh9MvdJ0CaxFJhIsPTLkpG/W52hp5kX5ktLd2Dj7ShIoAddDtBpvHaclakv7v1CnhVKtjfwh3B+3LFdIplAW6hXezBJoqieROZIew5+OZRJGi2aeOEhlW6+ivO0nmRwuQ4q4cPMUNusBNXGmvog= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(346002)(376002)(46966006)(36840700001)(54906003)(36756003)(4326008)(45080400002)(36860700001)(6666004)(478600001)(5660300002)(316002)(956004)(81166007)(2616005)(33656002)(966005)(83380400001)(8936002)(6862004)(107886003)(16526019)(26005)(336012)(8676002)(356005)(186003)(2906002)(7696005)(66574015)(70586007)(70206006)(47076005)(44832011)(82740400003)(86362001)(53546011)(6486002)(82310400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 11:50:57.5758 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc292da0-6b18-44ee-9d08-08d8eacd427b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2152 Hi Juergen, Could you confirm that back porting this two serie to the linux kernel 5.10= : https://patchwork.kernel.org/project/xen-devel/cover/20201210192536.1184321= 46@linutronix.de/ https://patchwork.kernel.org/project/xen-devel/cover/20210306161833.4552-1-= jgross@suse.com/ Is needed to remove the BUG_ON(=E2=80=A6)? Thank you for your time. Cheers, Luca > On 18 Mar 2021, at 08:47, Luca Fancellu wrote: >=20 > Hi Juergen, >=20 > If you are willing to do the patch I think it will be faster to being acc= epted, what about the BUG_ON(=E2=80=A6) in evtchn_2l_unmask from events_2l.= c file? >=20 > Cheers, >=20 > Luca >=20 >> On 18 Mar 2021, at 07:54, J=C3=BCrgen Gro=C3=9F wrote: >>=20 >> On 17.03.21 15:32, Luca Fancellu wrote: >>> Hi all, >>> we've been encountering an issue when using the kernel 5.10 with preemp= t_rt support for Dom0, the problem is that during the boot of Dom0, it hits= a BUG_ON(!irqs_disabled()) from the function evtchn_fifo_unmask defined in= events_fifo.c. >>> This is the call stack: >>> [ 17.817018] ------------[ cut here ]------------ >>> [ 17.817021] kernel BUG at drivers/xen/events/events_fifo.c:258! >>> [ 18.817079] Internal error: Oops - BUG: 0 [#1] PREEMPT_RT SMP >>> [ 18.817081] Modules linked in: bridge stp llc ipv6 >>> [ 18.817086] CPU: 3 PID: 558 Comm: xenstored Not tainted 5.10.16-rt25= -yocto-preempt-rt #1 >>> [ 18.817089] Hardware name: Arm Neoverse N1 System Development Platfo= rm (DT) >>> [ 18.817090] pstate: 60400005 (nZCv daif +PAN -UAO -TCO BTYPE=3D--) >>> [ 18.817092] pc : evtchn_fifo_unmask+0xd4/0xe0 >>> [ 18.817099] lr : xen_irq_lateeoi_locked+0xec/0x200 >>> [ 18.817102] sp : ffff8000123f3cc0 >>> [ 18.817102] x29: ffff8000123f3cc0 x28: ffff0000427b1d80 >>> [ 18.817104] x27: 0000000000000000 x26: 0000000000000000 >>> [ 18.817106] x25: 0000000000000001 x24: 0000000000000001 >>> [ 18.817107] x23: ffff0000412fc900 x22: 0000000000000004 >>> [ 18.817109] x21: 0000000000000000 x20: ffff000042e06990 >>> [ 18.817110] x19: ffff0000427b1d80 x18: 0000000000000010 >>> [ 18.817112] x17: 0000000000000000 x16: 0000000000000000 >>> [ 18.817113] x15: 0000000000000002 x14: 0000000000000001 >>> [ 18.817114] x13: 000000000001a7e8 x12: 0000000000000040 >>> [ 18.817116] x11: ffff000040400248 x10: ffff00004040024a >>> [ 18.817117] x9 : ffff800011be5200 x8 : ffff000040400270 >>> [ 18.817119] x7 : 0000000000000000 x6 : 0000000000000003 >>> [ 18.817120] x5 : 0000000000000000 x4 : ffff000040400308 >>> [ 18.817121] x3 : ffff0000408a400c x2 : 0000000000000000 >>> [ 18.817122] x1 : 0000000000000000 x0 : ffff0000408a4000 >>> [ 18.817124] Call trace: >>> [ 18.817125] evtchn_fifo_unmask+0xd4/0xe0 >>> [ 18.817127] xen_irq_lateeoi_locked+0xec/0x200 >>> [ 18.817129] xen_irq_lateeoi+0x48/0x64 >>> [ 18.817131] evtchn_write+0x124/0x15c >>> [ 18.817134] vfs_write+0xf0/0x2cc >>> [ 18.817137] ksys_write+0xe0/0x100 >>> [ 18.817139] __arm64_sys_write+0x20/0x30 >>> [ 18.817142] el0_svc_common.constprop.0+0x78/0x1a0 >>> [ 18.817145] do_el0_svc+0x24/0x90 >>> [ 18.817147] el0_svc+0x14/0x20 >>> [ 18.817151] el0_sync_handler+0x1a4/0x1b0 >>> [ 18.817153] el0_sync+0x174/0x180 >>> [ 18.817156] Code: 52800120 b90023e6 97e6d104 17fffff0 (d4210000) >>> [ 18.817158] ---[ end trace 0000000000000002 ]--- >>> Our last tested kernel was the 5.4 and our analysis pointed out that th= e introduction of the lateeoi framework (xen/events: add a new "late EOI" e= vtchn framework) in conjunction with the preempt_rt patches (irqs kept enab= led between spinlock_t/rwlock_t _irqsave///=E2=80=8B_irqrestore operations)= is the root cause. >>> Given that many modifications were made to the mask/unmask operations, = a big one from Juergen Gross (xen/events: don't unmask an event channel whe= n an eoi is pending), is the BUG_ON(...) still needed? >>> With the mentioned commit every call to a mask/unmask operation is prot= ected by a spinlock, so I would like to have some feedbacks from who has mo= re experience than me on this part of the code. >>=20 >> I think this BUG_ON() can be removed. >>=20 >> Are you planning to send a patch? >>=20 >>=20 >> Juergen >> From xen-devel-bounces@lists.xenproject.org Fri Mar 19 11:54:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 11:54:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99185.188438 (Exim 4.92) (envelope-from ) id 1lNDi6-0006K4-Ke; Fri, 19 Mar 2021 11:54:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99185.188438; Fri, 19 Mar 2021 11:54:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNDi6-0006Jx-HK; Fri, 19 Mar 2021 11:54:34 +0000 Received: by outflank-mailman (input) for mailman id 99185; Fri, 19 Mar 2021 11:54:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNDi5-0006Js-Mb for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 11:54:33 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c64431ed-7641-48b2-b9fb-08362a73c38c; Fri, 19 Mar 2021 11:54:33 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1CA8FAE57; Fri, 19 Mar 2021 11:54:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c64431ed-7641-48b2-b9fb-08362a73c38c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616154872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qnd4Cx4qQlj+LFhUs5wkCqitPC9lJA+Npc4JlGDp96c=; b=uhr+Aw2Jcx/DalICXmHwXYnbP/I1L2BbkPjUsy9vmmObmLZAcNvo4E9pizOEsUTngBiZ0I WDesvwdR5YBrJ/cKbS7g+PF3LPn7Ejz667XX/uXWFOinZEeyeIksBEyxDbIQ2vHx2FdIPU ZnA3GkDd5I55bzUmkYK9YJ3/df9SoUU= Subject: Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 To: Luca Fancellu Cc: "xen-devel@lists.xenproject.org" , "jgrall@amazon.com" References: <1FAD6C91-2B3A-48F0-88D7-CFCFC8B53BA9@arm.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Fri, 19 Mar 2021 12:54:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <1FAD6C91-2B3A-48F0-88D7-CFCFC8B53BA9@arm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8dGMO0sRxtkG8JlWUotK7B9NCRR011xB9" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8dGMO0sRxtkG8JlWUotK7B9NCRR011xB9 Content-Type: multipart/mixed; boundary="6BcT3tUMT26vE6UdZBlOmYuxzLggm1Aa3"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Luca Fancellu Cc: "xen-devel@lists.xenproject.org" , "jgrall@amazon.com" Message-ID: Subject: Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 References: <1FAD6C91-2B3A-48F0-88D7-CFCFC8B53BA9@arm.com> In-Reply-To: <1FAD6C91-2B3A-48F0-88D7-CFCFC8B53BA9@arm.com> --6BcT3tUMT26vE6UdZBlOmYuxzLggm1Aa3 Content-Type: multipart/mixed; boundary="------------ED7F01860E129EA63C3CB1BE" Content-Language: en-US This is a multi-part message in MIME format. --------------ED7F01860E129EA63C3CB1BE Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 19.03.21 12:50, Luca Fancellu wrote: > Hi Juergen, >=20 > Could you confirm that back porting this two serie to the linux kernel = 5.10: >=20 > https://patchwork.kernel.org/project/xen-devel/cover/20201210192536.118= 432146@linutronix.de/ I don't see why this one would be needed? > https://patchwork.kernel.org/project/xen-devel/cover/20210306161833.455= 2-1-jgross@suse.com/ This is already part of 5.10.24. Juergen --------------ED7F01860E129EA63C3CB1BE Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ED7F01860E129EA63C3CB1BE-- --6BcT3tUMT26vE6UdZBlOmYuxzLggm1Aa3-- --8dGMO0sRxtkG8JlWUotK7B9NCRR011xB9 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBUkPcFAwAAAAAACgkQsN6d1ii/Ey8O bQf9Gm5xmbToc27qsLpCaX+gfrUkpmWxBfYrUymdZfuldhNImnHouT0kmR3qtSrul6QAVyjJJZuG JawOnIkrGJ1tDeSHD77q1FfQT5AYZa6EVd08YlD5NHXmZRLM8ox/boiAa4IMGmiKg6lL4f+VvmW4 RIIaG0r4B2AMAEzcAqpZuaJZDdkm+NJYSCzA2H5WSyN0IJh1BCnJBZXG+T+Ax1AmeDd+K44k4aCN DDoicbZmWREkJ/mwih4RqvTT25S7RqLx6Vf03wMhlfDD9evUyorCH/ioqLrRl2Ye3GvBjJxgN0f1 yYjvVbYe4TPTm7xyzCY3YgW/5h/5tjOyRjO3wWb6aw== =rVQH -----END PGP SIGNATURE----- --8dGMO0sRxtkG8JlWUotK7B9NCRR011xB9-- From xen-devel-bounces@lists.xenproject.org Fri Mar 19 11:57:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 11:57:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99188.188451 (Exim 4.92) (envelope-from ) id 1lNDkv-0006TB-58; Fri, 19 Mar 2021 11:57:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99188.188451; Fri, 19 Mar 2021 11:57:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNDku-0006T4-W9; Fri, 19 Mar 2021 11:57:28 +0000 Received: by outflank-mailman (input) for mailman id 99188; Fri, 19 Mar 2021 11:57:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNDku-0006Sz-9s for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 11:57:28 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d06afab2-67a3-4cbd-857f-a6efc522ee0f; Fri, 19 Mar 2021 11:57:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d06afab2-67a3-4cbd-857f-a6efc522ee0f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616155047; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=OCyjjQXnTBoDvFNQszyHClghT4OnlH6xOaByZJpeKfI=; b=dP0NzrlGmTBS6Ve+633SCxU9Hu66adEfcwGrrCCJk9mzPD9nfjwmh9Fv XodOiD3BlFaZnGakyiLHL6tVhj8vhCRwMaqwm5AWxqbAdAnGpjjr/4y7K 4UDB7wL//pQZLUVxE+NTRIqEEdiCkI+yPsd2225nimF0rSZ/3NNz5/qZh s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ++HRilZzOYDzK83EstmEtFlYzZGEzDNaEVO16QOfW4J1ItjGbE3+uLWZOgVPljl0fjGPbjlyp2 AxVv60YY1U2wamEYRKbs9PcU5E73FNL5IebfOZ7g4/TRYQrUXAtc9mmSyVF2l8I7BdXFoIb6D8 3OMzFR0PNwxwh9hQB8GJZiXS7VJx01KQEvNJKJrS9pY0lJMokBsJC87d65s353KOy8gC014SgP eCz03f2qcDfuHKx+y6SFPmZcYjMAyXc7ocRePDpzERZmUcYwvmG1S9Tf5e0v331ixU3w9mX6Tb F1g= X-SBRS: 5.2 X-MesageID: 39682422 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:2pQNaqEsZlUlSx5hpLqFRZTXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7Lk/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeNJwTXzcQY76 tpdsFFZeHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLD1CQYsI1XYdNi+wFEpqSA5aQb8wE5 SB7sRKzgDQBkg/RMK9G3UDQqz/vNXNjp3relorABQg5QmIg1qTmcLHOjKf2QoTVC4K/Kc6/Q H+4nHEz4iAk9X+8B/T0GfP849b8eGO9vJvDNGB4/JlUgnEpR2vYO1aKtq/lRAz5Nqi8VM71O TLyi1QRfhbz1P0UiWLrQD22w/muQxemEPK7VODm3PsrYjYaVsBerN8rLlUeBfY9EYs1esUuM kgvxP7xu9qJCjNkyjn69/DWwsCrDvRnVMYnfMOlHsaaIMCadZq3Pwi1XlIG5QNFj+S0vFALM BSCqjnlZRrWG+BY2uclmdix8HEZAVJIj62BmIGusCTzgFMmmF4w0Yy1KUk7wY93aN4ZJ9e6+ veNKN00JlIU88NdKp4QNwMWM2tFwX2MF3xGVPXBW6iOLAMOnrLpZKyyLIp5NuycJhN6Jcpgp zOXH5RqGZaQTOhNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dQWeVVEHiaKb0rYiK/yef8 z2FINdAvflI2erM51OxRfCV55bLmRbeNEJu+w8R0mFrqvwW83Xn92eVMyWCKvmED4iVG+6KG AERiLPKMJJ6V3udWT/hDTXRnPxam3y9Z99C8Hhjq0u4blIErcJnhkeiFy/6M3OAyZFqLYKcE x3J66isq7TnxjzwU/4q0FSfjZNBEdc57vtF1lQoxURDk/yebEf//GWeWVY2mq7NgZyJvmmVz J3lhBSw+aaPpaQzSctB5aMKWSBlUYeo3qMUtM6lrCc49zmPrc1FIwvVqA0NQijLW01pS9a7E N4LCMUTE7WET3jzY+/ioYPOe3Zf95gxCGxIcBVrnrbnV6Gpd4mQ0YaWzLGa7/UvS8eAx5vwn Fh+a4Wh7SN3Ry1L3Ekveg+OFpQLFiMDKl+FwSDboVMkrXNcAV9JF36wwCyulUWQC7H5k8Sjm vuIWmxdevQClRQgHxez53n6Uh5bGmbYkJ2ZE1rqIEVLxW1hl9DlcuwIoaj2WqYbVUPhtsQNz zIehM+CAJjzdLf7m/epB+yUVEdgrk+NO3UC7ouN4zJ0nS2MYuSiOUtBPlP5qtoM9jor84GWe +SYBWuMTv9Eu8lsjbl/0oNCW1Rkj0JgPno0Brq4CyEx3Y5G+PVO0kjaLcBId2QhlKUDsqg4d Fct5YSsuSxOGmqNYLD5qHTcjJZKhTc5USxVPolrJhIvaQ08Jt/dqOrJgfg5TVi5lEZKsyxqW Y1BIJcy5rFMpV0f8MTdzlCl2BZ3+inHQ8OiEjOHuQ6fVsRlHfVMNOC3qrQpdMUczm8jTq1HW PazjZU8PjEVRaSzLI2C6o/JmJNdUg3gU4Sit+qRsn1CA+wcftE80f/GnihcKVFQKztI8Rckj 9Kp/WJlfSQbSz2xUT5uiZ6OLtH9yKCTdmpCAyBXc5O/NrSAyXBvoKapOqyhizwUz21dgAxgp BEb1UZaoB7sQYZ5bdHmhSae+jQuUIqk1xX/DFhmBrM4+GdkRnmNHADFxbYjJVQVSRUKV6Sg6 3+gLCl6Eg= X-IronPort-AV: E=Sophos;i="5.81,261,1610427600"; d="scan'208";a="39682422" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gvvEWHqq2zO6hVcWw77oY71ABWa9Y+KRV9Shx5MWqsidXxd9/KkSqKGGQ6L15NG/7jU+XzFFGjCaygrNbOV3KW+0IhmaP8K8ddDkZz855J/GoK7KRpTRpgGPrPYIEBbUYDhdB8jX0MyZzNb173kPfGlUcvYCY0R++vWJQz9X+gcB1rC7AzIsVEKfmdew1txe+PiqFYkTpbuVod/wOtxyoi9nStnfZkgamTIMyMD2MXcSxNsusNJeVB6lZqnnzTbfOWm1xA3AKf+jwplO8xRzk5bXkX/xEQY5xiTjADFhulZRjL55yJy0ZebRCYSRMX7xbXVXgzuALFOYEx0EAuSbxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lsqooOdB76lGAtjkkaoc3F6WpDipErIvdHTplSG30tU=; b=mHo2RkuH9HpCLgguFij5RCInYwPgKxleWOQs7w1iNwu2bJj0TtaaEMbQx2H7n+KRa+T5a5ULHvA4O6tv1U7pjnARaN+1glBRM0VoOnQSZLfvfL6tXA2vIoSvBp22qw0UfuK23uBNH8TesTfDsN2UCdI/FE+HM5fu8LFsLkmJewl0X9YUvvqjp0Gh8xBfeJp+rXIWwMFTTWQ86uej24jvdgkqIHLAvNRjkH8d39bIbMWTdOGItodWszNUD9DH89Yz3lWYffJA1g/3b4107ONJaIEM2RTE86Y065Iov1Erzmz25jm7UQZbM7kWeSbXuGIL6uNplZYdk1szEIEJjTQYtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lsqooOdB76lGAtjkkaoc3F6WpDipErIvdHTplSG30tU=; b=nAgVFbOhFdb1JP0g56yls0NuavbaI2zJ9ZXaf8b9h7x9Adbrmxn/mjwJOnFW3Qen+lNEgYJqhE5f540gWLow9i7vW2Wx2yjWx74KFI59jT2J/IcsY8txpWc7B3qYe85PvgvnMvyyaX2vCAfcudIjpab0yInlYVAhQPYvCMc02ig= To: Ian Jackson , Julien Grall CC: Jan Beulich , "xen-devel@lists.xenproject.org" , Stefano Stabellini , George Dunlap , Wei Liu , Anthony Perard References: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> <24658.6228.390535.850901@mariner.uk.xensource.com> From: Andrew Cooper Subject: Re: Call for tools backports (was Re: preparations for 4.13.3) Message-ID: Date: Fri, 19 Mar 2021 11:57:16 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <24658.6228.390535.850901@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0496.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::21) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bdf35de6-7645-46b7-ffdd-08d8eace2791 X-MS-TrafficTypeDiagnostic: BN6PR03MB2771: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qcskd58xjHPsHKptS4MtrCTSVMx/H1cCaiBDSoAhCrD1zsHAf723hDf0RifFWVKtHunV/8g+ZCPtnyRQPy8AQX0onKOaY/D44NUjCrLT5++qu16xkhWfYKHHE0C5HCEm+ygJYEsQybZ1cBfZzB0VHDsTwCKEKmiXUL6krexu39edKIlYtD1MC4KMzWSkdP7DVluElEby3Krm9OlG0gAnbbDiszKnL6X2z+7LeG9GuK1/wyTYzgU72uPujRROXUj2/w44dGfA2nZSzy151noGuIJ8iaUHF0TRXJFm5u0PsIE0syA/90iPMsCiPQfrjoURY45cd1VboMdSxcbOoght3mNfPeiEf7UPaj+/gwu1V4VzquxMFogArAehMDwPwJJ6F8EaCXOSPmZev7Uj38A4x4cgzrjRxtrsNu4mL3tCg0LvCv0I3c64Mfe1Puj4pZFgL09XEtT+Un133Oq+MbbT+WIf9PqPHsgXXFNyabwi7QuhlEJDCpCfvqpYfAptooZDj1BFGfkz3PBMzrlb2S6Hedvv46iR+9hojjeZWcQlgAo0xioeEfFO8F2J7iupqz6VRy7eccv3v8GsgfUnmsXpNjkYwV8ecam96glO9tL2tR1wWJzmEmxGIENDDnmD8PbJeMGevarWQAEx8pzPOi15XYMbCNOZ824VNqHwI6XDnbBoHMy3Hjoz7Vm9epE1TntoGHOLo/O6AmgClDgpu2SKoenuGRp6xt1Nb1NF5mnwpNQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(366004)(376002)(136003)(39860400002)(53546011)(83380400001)(31696002)(478600001)(107886003)(2906002)(2616005)(956004)(6486002)(86362001)(110136005)(8676002)(16576012)(26005)(54906003)(66946007)(66476007)(186003)(6666004)(316002)(5660300002)(38100700001)(31686004)(4326008)(36756003)(8936002)(66556008)(16526019)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?TExRV0pUU2pWMW9qb1ZvVmIreHpPYk0yTW1qbnhlZndWVkljUnpqMWo4REZr?= =?utf-8?B?SFdyb1FMQnZxWm5MY0pzZkJLYkdrakZkc25UZDZNS0dkNm5ReHFpNEJwZkp2?= =?utf-8?B?dmJlZWwxQ2NxUjNmckhram43YzExS3lYRUxBb3FKMWRCK01STUJxWkgraVhP?= =?utf-8?B?bmEyNFBadXZWQU5KSURhWEFiZHQ2RWpLU05tbjNJd2lUSjR1UkxCQ1BkNzQ4?= =?utf-8?B?MkJ0Qi9YYVRSSFIvZDBMNEhPQ0ZpT2YzYzdqNVR0WVRZZXM1bWh2Q250VVpU?= =?utf-8?B?YkVCaWxDajlLTWdQNkRqZ2V6Wk5TbklWekdaUFZTUklVUzVOSVlQL3VhLzhk?= =?utf-8?B?bVgxQTBjS3dRYzhlSE1JbXNYZ2tlYVhlSzJyVU85M2g4Qy9TLzdtVXlwd2xZ?= =?utf-8?B?UVlsUWJCNi8rNU1wYUdTaVVoRUFPRXNCVlYwRHc5dGd6eDRWZkJkTEgrNVor?= =?utf-8?B?dDZrNUFlV2xSUHowNGN5N01HMmZuQnhmb2lSanY5TGduQ0VJOHQ0cW9UY2R2?= =?utf-8?B?YlBYOVBhNXZmNVdWemN3UkFXRWJPMm9jTlR4SmhkSllZNTRTc004RldqUG03?= =?utf-8?B?ZFBQeTNuRTl3Zys4d05SUktQSlg3WitNcVRJblUxTDVScGY1ci9WWDV3Q2d3?= =?utf-8?B?ZE1Oc1JiMThCc21oblpZamZWNVdIdGcxSFhSTFVxVmxxSUpoRlpNOUt5eEJ5?= =?utf-8?B?SGdqbUF2UWl4SFdXNndieXNUcFRmcHF1Uk5kQjhXd3pycjZVclFDK0xZK1dW?= =?utf-8?B?WHFYQ21MQU91d2ora3hhSWV3Z05Tdm8zcUdJME1tRlBTQTlNd0trTmlwYmF1?= =?utf-8?B?dHl5a0g1RmQyRkZrSTM1VWpaVW80a2JJb053QnYwNzlMV1BYayt6YWpheVdQ?= =?utf-8?B?NFNBTEtHTVB4dC9ZWEJpZzNrOE1tbGM5Ui9KL283RnV6b1hnNGxDSWlPTjRm?= =?utf-8?B?MlR0Uzg0a0tGNFNLTGlEaitHWmQ0SWpSQlRWUkExUzNHVmY2cm9UVmNJazEx?= =?utf-8?B?aGY1RHE5SmlSQjAwbUZJTUFIQzVhV0ZpVHBCYkNBYXlJOFVqc01RYVdJdmZn?= =?utf-8?B?Zy9mK3BkTy9pckJLaStiWnlVaUFRU25vdFZuUjFOaHgvZUl4L1pNT3BncFU3?= =?utf-8?B?NzJ2NWpMekNrWks3RmJhbCtYM0hOcjhpNHpZK2Q2S1N2ZUtXVTdFQ2Y5Tkd6?= =?utf-8?B?ZHhtOFFKZTFhRzFlNGorQXBHK3gvYnRpWEVVOFpUeUpXUm9IN3NxMDdDeFJp?= =?utf-8?B?blJORGpKbTl3dFMyaE5CdXJ2dzFhN1BpczV6K2IzdjJDaXJUOThYVzh3MlF5?= =?utf-8?B?ZEdpS1VVU3ZjaWRCTEQyL3plaGpDNThJVkwzbGNuUWN6YldGa1BETVNDbTRa?= =?utf-8?B?NHFyOEoyaDFhTWlya1RCR3d0Y095NzZ3UUlZSW56SGlKcjhrSGVLeDJZd3dn?= =?utf-8?B?ZG1CazJ1bXlMZlRjM0dGNDQwR1JkbHg3alRRdWV6eU1xdFpvTXVWNE9XTG93?= =?utf-8?B?SW5nOGFDbEdzNjlPUjZhRHI0NVNIUlZRaGhJNXZPK3dmVzltVGg1ZnRINXBJ?= =?utf-8?B?d1hJQWRoR3ptSDhvMGJuaE9sNGw3TmJ5c2lKNmQ2Z25HVlZJUTdzbW1Nc042?= =?utf-8?B?Q0thYzVkMkhFaVZBWFVlc0NRclNWUmVaNm9VUWxMNXFWaThmYTU5WGFsN2RP?= =?utf-8?B?Mk9nSDg5Y2tyNEFiU1VVUnNYaENKRGF1MlNoU0VFcHQwT1drNlVOdVR1VW5T?= =?utf-8?Q?wm691fFhwaZ8k2jvUkWCf0SUtxooue862RAofcC?= X-MS-Exchange-CrossTenant-Network-Message-Id: bdf35de6-7645-46b7-ffdd-08d8eace2791 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 11:57:22.3755 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QqehHRC2208mF1YJ5R48BY+ybqH6kDL4x7HS9uLU0xJ+wCcsQyPtAPu+/YlMw9/Mpgit5J2gtrqBK8cJeU63XsSYARrioYtbtuivTrlI6u0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2771 X-OriginatorOrg: citrix.com On 17/03/2021 14:55, Ian Jackson wrote: > Julien Grall writes ("Re: preparations for 4.13.3"): >> On 08/03/2021 09:49, Jan Beulich wrote: >>> All, >>> >>> the release is overdue (my apologies). Please point out backports >>> you find missing from the respective staging branches, but which >>> you consider relevant. >>>> Ones that I have queued already, but which hadn't passed the push >>> gate to master yet when doing a swipe late last week, are >>> >>> c6ad5a701b9a crypto: adjust rijndaelEncrypt() prototype for gcc11 >>> 9318fdf757ec x86/shadow: suppress "fast fault path" optimization withou= t reserved bits >>> 60c0444fae21 x86/shadow: suppress "fast fault path" optimization when r= unning virtualized >> I would like to also consider the following one: >> >> 28804c0ce9fd SUPPORT.MD: Clarify the support state for the Arm SMMUv{1,= =20 >> 2} drivers (4.11+ as updating the security support) >> 067935804a8e xen/vgic: Implement write to ISPENDR in vGICv{2, 3} (4.13+) >> To support newer kernel on stable Xen >> d81133d45d81 xen/arm: Add workaround for Cortex-A53 erratum #843419 (4.1= 3+) >> fd7479b9aec2 xen/arm: Add workaround for Cortex-A55 erratum #1530923 (4.= 13+) >> 5505f5f8e7e8 xen/arm: Add Cortex-A73 erratum 858921 workaround (4.13+) >> 63b4c9bfb788 xen/arm: mm: Access a PT entry before the table is unmapped= =20 >> (4.13 only) >> f6790389613c xen/arm: sched: Ensure the vCPU context is seen before=20 >> vcpu_pause() returns (4.13 only) >> >> I have put in parentheses the list of versions targeted. > My backport list seems to have very few tools patches on it. > > If anyone has any tools bugfixes that ought to go into 4.13 please do > let me know! > > Additionally, perhaps this one commit to be backported ? > 935e0836710ce8cab584155b2844cea8497a5159 > arm: replace typeof() with __typeof__() These are general backport requests, not specifically for 4.13 d92ba1aa7cf8 - tools/ocaml: libxb: Harden stub_header_of_string() 59b087e39544 - tools/ocaml: Fix stubs build when OCaml has been compiled with -safe-string 78686437e949 - tools/ocaml: libxb: Avoid to use String_val() when value is bytes 2b8079610ec5 - tools/libxc: misc: Mark const the parameter 'keys' of xc_send_debug_keys() a6ed77f1e033 - oxenstored: fix ABI breakage introduced in Xen 4.9.0 The penultimate one is an API change, but strictly in a relaxing direction.=C2=A0 The final one is an ABI change, but fixing a regression. 5e31789634 - tools/ocaml/libs/xb: Do not crash after xenbus is unmapped 2a47797d1f - tools/oxenstored: Trim txhistory on xenbus reconnect c8b9670825 - tools/oxenstored: Fix quota calculation for mkdir EEXIST dc8caf214fb - tools/oxenstored: Reject invalid watch paths early 45dee7d92b - tools/oxenstored: mkdir conflicts were sometimes missed Do we want to backport the -Og fixes so we can get ABI checking working? ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 19 12:00:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 12:00:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99193.188463 (Exim 4.92) (envelope-from ) id 1lNDnN-0006lp-Q1; Fri, 19 Mar 2021 12:00:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99193.188463; Fri, 19 Mar 2021 12:00:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNDnN-0006lN-Js; Fri, 19 Mar 2021 12:00:01 +0000 Received: by outflank-mailman (input) for mailman id 99193; Fri, 19 Mar 2021 12:00:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNDnM-0006hq-1M for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 12:00:00 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a370f509-9f15-4f80-a45b-91bfca125097; Fri, 19 Mar 2021 11:59:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7942AAE05; Fri, 19 Mar 2021 11:59:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a370f509-9f15-4f80-a45b-91bfca125097 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616155198; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fFUyjSuYC33Up51520sQxDFGwTsig4GVwFdSVC313BM=; b=RLNgt37qCemtyMCNWuolcnBVn0Bu/jHVlN/6MeDHiHFNqGeX2FSFiHum3lRtwRKaAA2f+V MfkN3Wa5ipz4lDL8yhab/As4f97RKA/C33mK1h/O/1O0BR7zuZnaPaCsxffpmiuy8yRBRj eOlDqGcR8FfD50ESzmi0re49NiJtijQ= Subject: Re: Call for tools backports (was Re: preparations for 4.13.3) To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , George Dunlap , Wei Liu , Anthony Perard , Ian Jackson , Julien Grall References: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> <24658.6228.390535.850901@mariner.uk.xensource.com> From: Jan Beulich Message-ID: Date: Fri, 19 Mar 2021 12:59:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 19.03.2021 12:57, Andrew Cooper wrote: > Do we want to backport the -Og fixes so we can get ABI checking working? Do we have a finalized picture of how this checking is going to work? I was under the impression that this is still in flux, in which case I'm not convinced of backporting changes just because they're prereqs to this. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 19 12:14:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 12:14:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99209.188475 (Exim 4.92) (envelope-from ) id 1lNE1F-00008U-C0; Fri, 19 Mar 2021 12:14:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99209.188475; Fri, 19 Mar 2021 12:14:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNE1F-00008M-8s; Fri, 19 Mar 2021 12:14:21 +0000 Received: by outflank-mailman (input) for mailman id 99209; Fri, 19 Mar 2021 12:14:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNE1E-00008H-55 for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 12:14:20 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 98cdc527-cff8-4d5c-92c4-40256dc92afd; Fri, 19 Mar 2021 12:14:19 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8A537AE05; Fri, 19 Mar 2021 12:14:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98cdc527-cff8-4d5c-92c4-40256dc92afd X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616156058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pNBXp255V4Nv7U4JgUZxv/Bqd55c27yiYgH2ytB94Js=; b=cPBWJlkpY7ZZGPzojAjldjfqKI8ipwpojijn1fuFUiE/2UII2hz+/t7DFrBEJB/Odh67I+ WFcwisi+QoXiVxRYhNSnq/PrKP6AN6Q9LtOaMycwjMRUvyXVB7LDjRj3YfJdyP3is6GeQd /406ECkgjw7Z9Rz4FA+Ildjzj5j8wYU= Subject: [Bugfix PATCH for-4.15] xen: credit2: fix per-entity load tracking when continuing running From: Dario Faggioli To: xen-devel@lists.xenproject.org Cc: George Dunlap , Ian Jackson Date: Fri, 19 Mar 2021 12:14:17 +0000 Message-ID: <161615605709.5036.4052641880659992679.stgit@Wayrath> User-Agent: StGit/0.23 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit If we schedule, and the current vCPU continues to run, its statistical load is not properly updated, resulting in something like this, even if all the 8 vCPUs are 100% busy: (XEN) Runqueue 0: (XEN) [...] (XEN) aveload = 2097152 (~800%) (XEN) [...] (XEN) Domain: 0 w 256 c 0 v 8 (XEN) 1: [0.0] flags=2 cpu=4 credit=9996885 [w=256] load=35 (~0%) (XEN) 2: [0.1] flags=2 cpu=2 credit=9993725 [w=256] load=796 (~0%) (XEN) 3: [0.2] flags=2 cpu=1 credit=9995885 [w=256] load=883 (~0%) (XEN) 4: [0.3] flags=2 cpu=5 credit=9998833 [w=256] load=487 (~0%) (XEN) 5: [0.4] flags=2 cpu=6 credit=9998942 [w=256] load=1595 (~0%) (XEN) 6: [0.5] flags=2 cpu=0 credit=9994669 [w=256] load=22 (~0%) (XEN) 7: [0.6] flags=2 cpu=7 credit=9997706 [w=256] load=0 (~0%) (XEN) 8: [0.7] flags=2 cpu=3 credit=9992440 [w=256] load=0 (~0%) As we can see, the average load of the runqueue as a whole is, instead, computed properly. This issue would, in theory, potentially affect Credit2 load balancing logic. In practice, however, the problem only manifests (at least with these characteristics) when there is only 1 runqueue active in the cpupool, which also means there is no need to do any load-balancing. Hence its real impact is pretty much limited to wrong per-vCPU load percentages, when looking at the output of the 'r' debug-key. With this patch, the load is updated and displayed correctly: (XEN) Runqueue 0: (XEN) [...] (XEN) aveload = 2097152 (~800%) (XEN) [...] (XEN) Domain info: (XEN) Domain: 0 w 256 c 0 v 8 (XEN) 1: [0.0] flags=2 cpu=4 credit=9995584 [w=256] load=262144 (~100%) (XEN) 2: [0.1] flags=2 cpu=6 credit=9992992 [w=256] load=262144 (~100%) (XEN) 3: [0.2] flags=2 cpu=3 credit=9998918 [w=256] load=262118 (~99%) (XEN) 4: [0.3] flags=2 cpu=5 credit=9996867 [w=256] load=262144 (~100%) (XEN) 5: [0.4] flags=2 cpu=1 credit=9998912 [w=256] load=262144 (~100%) (XEN) 6: [0.5] flags=2 cpu=2 credit=9997842 [w=256] load=262144 (~100%) (XEN) 7: [0.6] flags=2 cpu=7 credit=9994623 [w=256] load=262144 (~100%) (XEN) 8: [0.7] flags=2 cpu=0 credit=9991815 [w=256] load=262144 (~100%) Signed-off-by: Dario Faggioli --- Cc: George Dunlap Cc: Ian Jackson --- Despite the limited effect, it's a bug. So: - it should be backported; - I think it should be included in 4.15. The risk is pretty low, for the same reasons already explained when describing its limited impact. --- xen/common/sched/credit2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c index eb5e5a78c5..b3b5de94cf 100644 --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -3646,6 +3646,8 @@ static void csched2_schedule( runq_remove(snext); __set_bit(__CSFLAG_scheduled, &snext->flags); } + else + update_load(ops, rqd, snext, 0, now); /* Clear the idle mask if necessary */ if ( cpumask_test_cpu(sched_cpu, &rqd->idle) ) From xen-devel-bounces@lists.xenproject.org Fri Mar 19 12:18:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 12:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99213.188487 (Exim 4.92) (envelope-from ) id 1lNE5L-0000Py-U1; Fri, 19 Mar 2021 12:18:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99213.188487; Fri, 19 Mar 2021 12:18:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNE5L-0000Pr-Qc; Fri, 19 Mar 2021 12:18:35 +0000 Received: by outflank-mailman (input) for mailman id 99213; Fri, 19 Mar 2021 12:18:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNE5K-0000Pm-Vv for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 12:18:35 +0000 Received: from MTA-14-4.privateemail.com (unknown [198.54.118.206]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ff5f25ba-72d8-4481-aec8-f405b681282d; Fri, 19 Mar 2021 12:18:34 +0000 (UTC) Received: from mta-14.privateemail.com (localhost [127.0.0.1]) by mta-14.privateemail.com (Postfix) with ESMTP id 278D080068 for ; Fri, 19 Mar 2021 08:18:33 -0400 (EDT) Received: from mail-wm1-f53.google.com (unknown [10.20.151.218]) by mta-14.privateemail.com (Postfix) with ESMTPA id E64FF80065 for ; Fri, 19 Mar 2021 08:18:32 -0400 (EDT) Received: by mail-wm1-f53.google.com with SMTP id r10-20020a05600c35cab029010c946c95easo5111830wmq.4 for ; Fri, 19 Mar 2021 05:18:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff5f25ba-72d8-4481-aec8-f405b681282d X-Gm-Message-State: AOAM532hBKR/t5jsxrS/KUhs9I9S8wIY8aJUFhlI3bcFz5bPu8ewglki GTIQWVdRZ9+H8DldgNDWU4u2rWpZ8FF9YK7ib3Y= X-Google-Smtp-Source: ABdhPJzIwTHUfLYYl3lbtC+wAqnC+sz+GYS9Fir+xR0wF4jObos29xuDy5jBTZAKv9t1F+EMgkossrVgcEcYw9o7Aho= X-Received: by 2002:a1c:c206:: with SMTP id s6mr3437346wmf.77.1616156311635; Fri, 19 Mar 2021 05:18:31 -0700 (PDT) MIME-Version: 1.0 References: <193bfae5-a80a-d02a-377d-c9e11ad038a8@suse.com> <960d2a7a-7be0-58f8-56cc-26d1fa90b7a0@suse.com> In-Reply-To: <960d2a7a-7be0-58f8-56cc-26d1fa90b7a0@suse.com> From: Tamas K Lengyel Date: Fri, 19 Mar 2021 08:17:55 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking To: Jan Beulich Cc: Tamas K Lengyel , Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Xen-devel Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Mar 19, 2021 at 7:25 AM Jan Beulich wrote: > > On 19.03.2021 12:06, Tamas K Lengyel wrote: > > On Fri, Mar 19, 2021, 6:23 AM Jan Beulich wrote: > > > >> On 18.03.2021 22:36, Tamas K Lengyel wrote: > >>> --- a/xen/arch/x86/mm/mem_sharing.c > >>> +++ b/xen/arch/x86/mm/mem_sharing.c > >>> @@ -1761,6 +1761,7 @@ static int copy_settings(struct domain *cd, struct > >> domain *d) > >>> return rc; > >>> > >>> copy_tsc(cd, d); > >>> + p2m_get_hostp2m(cd)->max_mapped_pfn = > >> p2m_get_hostp2m(d)->max_mapped_pfn; > >> > >> Makes sense to me, yes, but then an immediate question is: What > >> about the somewhat similar {min,max}_remapped_gfn fields? Which > >> of course implies the more general question of how alternate > >> p2m-s (are supposed to) get treated in the first place. From my > >> looking at it, fork() doesn't appear to also fork those, but > >> also doesn't appear to refuse cloning when altp2m is in use. > >> > > > > It's untested, forking and altp2m is not currently used simultaniously. > > Don't know if it should be restricted as not working as I haven't tested > > it. Both forking and altp2m is experimental so there be dragons. At some > > point I would like to be able to use altp2m in forks but forking a domain > > that has altp2m enabled will likely be a setup that's too insane to try to > > get working. > > Well, I see only two (consistent) options - either the other two > fields mentioned get copied as well, or altp2m use results in > forking getting refused. Sure, but that's a separate issue from what this patch addresses so at this point I don't plan on including that work in here. Tamas From xen-devel-bounces@lists.xenproject.org Fri Mar 19 12:33:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 12:33:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99218.188498 (Exim 4.92) (envelope-from ) id 1lNEIm-00029y-5A; Fri, 19 Mar 2021 12:32:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99218.188498; Fri, 19 Mar 2021 12:32:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNEIm-00029r-26; Fri, 19 Mar 2021 12:32:28 +0000 Received: by outflank-mailman (input) for mailman id 99218; Fri, 19 Mar 2021 12:32:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNEIk-00029m-A2 for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 12:32:26 +0000 Received: from MTA-05-3.privateemail.com (unknown [68.65.122.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c079862a-8a7f-4524-9710-e4b2d057ce5c; Fri, 19 Mar 2021 12:32:25 +0000 (UTC) Received: from MTA-05.privateemail.com (localhost [127.0.0.1]) by MTA-05.privateemail.com (Postfix) with ESMTP id E53A16004E for ; Fri, 19 Mar 2021 08:32:24 -0400 (EDT) Received: from mail-wr1-f42.google.com (unknown [10.20.151.231]) by MTA-05.privateemail.com (Postfix) with ESMTPA id ADDB06004B for ; Fri, 19 Mar 2021 08:32:24 -0400 (EDT) Received: by mail-wr1-f42.google.com with SMTP id v11so8929200wro.7 for ; Fri, 19 Mar 2021 05:32:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c079862a-8a7f-4524-9710-e4b2d057ce5c X-Gm-Message-State: AOAM530Ork8CC0ezEzAiRTQW5pt7YHrKLTBN5qwqc/vjUl3yDyE16Blx x64/7zbZf/eseWW2hAggRq5eSMuUsUM9+wfllAs= X-Google-Smtp-Source: ABdhPJy5XovMdnvGxCcKOrT9r4BM8AiXk0Bgc8m4/fdv7LkLDY0XvbaWZXko+H6ISgWAdYeiB2bGNZZ4FKMRklgBjGs= X-Received: by 2002:a5d:4d8d:: with SMTP id b13mr2044980wru.259.1616157143440; Fri, 19 Mar 2021 05:32:23 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tamas K Lengyel Date: Fri, 19 Mar 2021 08:31:47 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking To: Tamas K Lengyel Cc: Xen-devel , Jan Beulich , Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Ian Jackson Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Mar 18, 2021 at 5:36 PM Tamas K Lengyel wrote: > > When creating a VM fork copy the parent VM's hostp2m max_mapped_pfn value. Some > toolstack relies on the XENMEM_maximum_gpfn value to establish the maximum > addressable physical memory in the VM and for forks that have not yet been > unpaused that value is not going to reflect the correct max gpfn that's > possible to populate into the p2m. This patch fixes the issue. > > Signed-off-by: Tamas K Lengyel > --- > xen/arch/x86/mm/mem_sharing.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c > index 00ada05c10..98b14f7b0a 100644 > --- a/xen/arch/x86/mm/mem_sharing.c > +++ b/xen/arch/x86/mm/mem_sharing.c > @@ -1761,6 +1761,7 @@ static int copy_settings(struct domain *cd, struct domain *d) > return rc; > > copy_tsc(cd, d); > + p2m_get_hostp2m(cd)->max_mapped_pfn = p2m_get_hostp2m(d)->max_mapped_pfn; > > return rc; > } > -- > 2.25.1 > CC-ing Ian as 4.15 release manager. This patch is safe to include in 4.15 as it's a minor fix in a tech preview feature that's not even compiled by default. Thanks, Tamas From xen-devel-bounces@lists.xenproject.org Fri Mar 19 12:46:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 12:46:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99221.188510 (Exim 4.92) (envelope-from ) id 1lNEWB-0003Cn-DF; Fri, 19 Mar 2021 12:46:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99221.188510; Fri, 19 Mar 2021 12:46:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNEWB-0003Cg-AN; Fri, 19 Mar 2021 12:46:19 +0000 Received: by outflank-mailman (input) for mailman id 99221; Fri, 19 Mar 2021 12:46:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNEW9-0003Cb-Qy for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 12:46:18 +0000 Received: from mail-40133.protonmail.ch (unknown [185.70.40.133]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5f27d8bb-2a08-40a7-a98a-83997d437c41; Fri, 19 Mar 2021 12:46:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f27d8bb-2a08-40a7-a98a-83997d437c41 Date: Fri, 19 Mar 2021 12:45:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1616157974; bh=hrDDYoJlWz4/zn8ir+LdTRoz9rA2Zirrg0N3b5XRaw8=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=ZNzHh/fq2CNYkWetqDwjbviqeGEAlI0m4iRn55CJnhHVksJJPP6fA0cK7d7qEyNhG uXUZW/eWP0n2BpaXv8th7uObv1esyWgNl1Yy8jlKXqWsh9ttO1AzfxubJ50htM1Myn QZopQCViz+u1JRWDS7AoMpInSg8exfjSide9i9OY= To: Dario Faggioli From: Dylanger Daly Cc: Jan Beulich , Andrew Cooper , "xen-devel@lists.xenproject.org" Reply-To: Dylanger Daly Subject: Re: Ryzen 4000 (Mobile) Softlocks/Micro-stutters Message-ID: In-Reply-To: References: <9lQU_gCfRzGyyNb2j86pxTMi1IET1Iq7iK3994agUZPrTI5Xd-aCJAaRYuJlD3L5LT2WaV4N3-YF4xKl5ukialT0M_YD0ve6gmDFFfatpXw=@protonmail.com> <815f3bc3a28a165e8fa41c6954a6d00db656e3c3.camel@suse.com> <1fc0e850-8a08-760f-c8cb-ad73dda4a37b@suse.com> <4916dec1-1bb9-7e6f-2fe5-577bbab92861@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Hi Everyone, I've just confirmed only `tsc=3Dunstable` is required, that sp= ecific change has fixed the issues I was having on the Lenovo X13, I assume= this is because Lenovo's Clock isn't correct? > Right. Also, isn't hpetbroadcast set to 0 by default already? > > Dario > -------------------------------------------------------------------- > > Dario Faggioli, Ph.D > > http://about.me/dario.faggioli > > Virtualization Software Engineer > > SUSE Labs, SUSE https://www.suse.com/ > -------------------------------------------------------------------------= ---------------------------------------------------- > > <> (Raistlin Majere) From xen-devel-bounces@lists.xenproject.org Fri Mar 19 12:51:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 12:51:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99224.188523 (Exim 4.92) (envelope-from ) id 1lNEab-0004AW-0D; Fri, 19 Mar 2021 12:50:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99224.188523; Fri, 19 Mar 2021 12:50:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNEaa-0004AP-TD; Fri, 19 Mar 2021 12:50:52 +0000 Received: by outflank-mailman (input) for mailman id 99224; Fri, 19 Mar 2021 12:50:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNEaZ-0004AH-Fd; Fri, 19 Mar 2021 12:50:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNEaZ-0003G0-7E; Fri, 19 Mar 2021 12:50:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNEaY-0005SE-SD; Fri, 19 Mar 2021 12:50:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNEaY-0003fA-RX; Fri, 19 Mar 2021 12:50:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HcRdCfWikYZbZZOc5ZQXA4xr3mJnPBWmAZN5+IYKTPc=; b=kYbobpGfetC1yXX36HUvGTsoeQ WlGXzXBp9AdPW9gZ8ngmmux/xwMn0RkCUMJwSv1YrPksNiirNHULvU/v3QmF7MJoI5GHrD1bhIZAq YTRi49FV65VdycX7F57qv5YBsW4RGh2ZmlKuYjngUPuPA+9959drekAOXT8MHCTw6Udc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.13-testing test] 160129: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.13-testing:test-amd64-i386-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:heisenbug xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:heisenbug xen-4.13-testing:test-arm64-arm64-xl-credit1:xen-boot:fail:heisenbug xen-4.13-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-4.13-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4547f01640f43ab04458da0f75854b3377ae4dbd X-Osstest-Versions-That: xen=24b181e4e4c6c6fe28217c845d6d753da1606aeb From: osstest service owner Date: Fri, 19 Mar 2021 12:50:50 +0000 flight 160129 xen-4.13-testing real [real] flight 160140 xen-4.13-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160129/ http://logs.test-lab.xenproject.org/osstest/logs/160140/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail pass in 160140-retest test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail pass in 160140-retest test-arm64-arm64-xl-credit1 8 xen-boot fail pass in 160140-retest test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 160140-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 159839 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail in 160140 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 160140 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 160140 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159839 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159839 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159839 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159839 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159839 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159839 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159839 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159839 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159839 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159839 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159839 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 4547f01640f43ab04458da0f75854b3377ae4dbd baseline version: xen 24b181e4e4c6c6fe28217c845d6d753da1606aeb Last test of basis 159839 2021-03-05 15:07:16 Z 13 days Testing same since 160129 2021-03-18 14:36:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Dario Faggioli Igor Druzhinin Jan Beulich Olaf Hering Tim Deegan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 24b181e4e4..4547f01640 4547f01640f43ab04458da0f75854b3377ae4dbd -> stable-4.13 From xen-devel-bounces@lists.xenproject.org Fri Mar 19 13:00:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 13:00:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99237.188558 (Exim 4.92) (envelope-from ) id 1lNEk9-0005Ky-5w; Fri, 19 Mar 2021 13:00:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99237.188558; Fri, 19 Mar 2021 13:00:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNEk9-0005Kr-2S; Fri, 19 Mar 2021 13:00:45 +0000 Received: by outflank-mailman (input) for mailman id 99237; Fri, 19 Mar 2021 13:00:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNEk7-0005Km-La for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:00:43 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d6a96612-d6ab-44ae-a499-143a71a7f702; Fri, 19 Mar 2021 13:00:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6a96612-d6ab-44ae-a499-143a71a7f702 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616158841; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=jC9l/x/KU6qMZ2tu/k28lA/bQ5dXJbtKwW3CzD3rfMI=; b=Imga5r4/OV33hm3E0drjxPwAl9vIRn8DVmIJBjF+YCmM5ZxWJTag4Qd5 x1i0Cq3PIMDt2Z7J7tgSzgAT7w37qOvyhL2rWQV5kIn4tHe3ytl3Jwj4e EAQf6p3tAhBgirappQts/nHxHOqdFCCBHCXbvglBKwf4FpVz5A8Le0gDQ Q=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: MNV4IfXtrF4P4scRYYVQv5ZRieTNQE9gHtcu0qw2IhKqpGhmh8rsuzNEW9zimNP4LC6GgyZ5GX RTR0Ag+mpIlLrvMiJGrhBteXN4EWg8FiwpqycmqSZQEw25Uu5bEZU1fRHDB1oEVtFCeei6avOM gNs04ulwjDYOcht6bAMle3OBxK7bOp31ocDdpOrrQ5gZOyrKADK68sDFWIWCOqKHNWGi3hCN0Y U1FcQDQDD2zxoVuHeyfitu41vPncH8f6wCJrHtWNPYm+OZr5/DG+bf/PESz9z2IhwLqxHVOa3d L18= X-SBRS: 5.2 X-MesageID: 39849250 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Ut/yPqBIcYbnfeXlHegBtMeALOonbusQ8zAX/mhLY1h8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPufVr1zrQwxYUKJ7+tUE3duGWuJJx/9oeK+VHdMgXE3Kpm2a 9kGpISNPTZEUV6gcHm4AOxDtYnx529/Lq1gPrFpk0NcShBQchbnmJEIyycFVB7QxQDIJI/Go aV6MYvnUveRV08aMOnCn4ZG9XZr9rQm578JTIADRgr6A6B5AnYlILSOR6ewxsYTndz0a4vmF K17jDRy4eCl7WAyhHa33LO9Jg+orXc4/ZKGcDksLlsFhzCkQCtDb4RPIGqnDdwm+237UZvrd +kmWZbA+1Wy1f8Ol64ugHs3Q6I6kdc11bHxUWDiXXu5ezVLQhKcvZpvo5SfhvH50dIhrgVu8 gqrgHpwqZ/Nh/OkD/w4NLFTXhR5y6JiEEvjPIJiDhnWZYeAYUh3bA3xl9fE5sLAUvBmeYaOd RpZfushsp+TUmXdDTwsGVp3bWXLw8ONybDaE0DtsuJ6iNRjXB0wmAJrfZv70soxdYTTYJJ6P /DNbktvLZSTtUOZaY4P+sZR9CrY1a9Di7kASa3GxDKBasHM3XCp9re56g03vijfNgtwIEpkJ rMfVtEvQcJCgzTIPzL+KcO3gHGQW27Uzio4NpZ/YJFtrr1Q6euGTGfSXg1+vHQ4Mk3M4n+Yb KeKZhWC/jsIS/FAoBSxTDzXJFUND03TNAVgNAmQFiDy/i7arHCh6j+SrL+NbDtGTErVifUGX 0YRgX+I81G8wSFQXn9rB/NW278W0D28J5qeZKqutQ7+cwoDMlhowIVgVO26oWgMjtZqJE7e0 N4PffGn8qA1C2L1FeNy18sFgtWD05T7rmleWhNvxU2P0T9dqtGn92efGtVzUaWPxMXdbKQLC dv43BMvY6nJZ2Zwi4vT/i9NHiBsncVrHWWC7ARh7OE/sWgXp8jFJ4pVOhQGGzwZl1IsDcvjF 0GRB4PR0fZGD+ro76iloYoCObWcMQ5phyqL85SoXf2rl6duskre3seU1eVIIyqqDdrYwARqk x68qcZjrbFsy2oM3EDjOMxN0AJVH6aG4tcDAOOZJxdn5fifA0YdxbNuRWqzzUIPkb6/UQbgW LsaQmZY+vCDFZmtndE6ary619vemKBf0V/V2BiveRGZBb7k0c29dXOSru40mOXZFdH+O0bPT 3fSRY5Iw9lxbmMpVSosQfHMU9j6oQlP+TbArhmTqra3Wm1LpaU0YscGeVPwZpjPNfyk+MCXO 6FYTWJJDfgB+5B4X3Nml8VfA1P7FU0m/Lh3xPoqFWi1HkkGPzIPRBIQaoYL9z01Rmse9+4lL FCyfQ7suu7Pj+vNpqoyaTLYyVCLR2Wi2isVO0soY1Vu6V3lLYbJeitbRL4kFV8mDM5J4PIsW lbZoJRyrXIIJVucMwfYDgxxCtjqP2/aG8Q9jXrCeo/d2w3h3DVP9m186PFwIBfdnGplU/VAx 2j6CVT8PfOYjub2ZMbA6w2J35KaEJU0gUVwMqyM6nRAh6tbedN4R6TNWK8aqZUTMG+aPgthy c/x9GDhOmMcSXknCjWoDtgO6pLt0KqW9m7Dg7JOelG9bWBSBixq5rvxM64lzHsTzSnL2wemI 1ebEQVKv15tQNKtvx+7gGCDortokwklFNC4TZo0n7Vs7LWnlvzLAVhKg3WgpJfQD9JFGOH5P 61qdSl6A== X-IronPort-AV: E=Sophos;i="5.81,261,1610427600"; d="scan'208";a="39849250" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ea85uEtH31bAUXrF+CJnqdm54Wg73ihVoGPGoP2D4W0iZEITwhQzMg1dcQbSg5mbV+Rg2HyZxZ9vN7GOLjYl0szWAAjBxrAEG7AEPE52+WEO38DI0CepvxHIHiCLmq4WeNMGcybKHloU5btpXDQF4VgFH2qv4Xl8P9whLEreSTSYua5DOWkl3XrJo6YSAs5pqCVk7xssN2GdaQB52TK0iZldn6KEWnP+R9Qsu2TZoIRtxPH1xdviw3FT4f+EKtMDWwT93rmX4q1F7SgYdfoLG/AckgcEuTcL55UWPwXW6PiXrj1tr9wtE2zvqJSu8e8u55Q0/Q16ohAZs7svf8xhew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aMapGbUkc8nJroiuKd7gLHmcVz6oX0BZvmv4G79ZRvk=; b=JMBZcmIZfoF4dIkd/LRkCviHtt8h6TsB5i7LHLAuMCZo3fm7LPIgO4YRGL35/sfsF+8isYUqzF5GOI/AebQC2jck5NiSgx285pfuA+nSrO9zY63g0nJDrfglvupXF8NpcIBla2TWPM7JEo1bkc5+EDvoLI1hMKHwOE9n4XUMbWFFGSYTj9VSKko5W63y6MMZ5n9VyCRc9McmmIT5UZ4xjT7H7gOpF6FsBciDyLaLOHPjwLGSmvTsu6Z62pRt1LEkkS/gXQG6Gyy7TKVEZMvEcWz4UPMo6Mt63I4EUgWFHt6zYw/FUeglAgsEzZje+h8UMxI3GZ0po/tYgHlxDiMzFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aMapGbUkc8nJroiuKd7gLHmcVz6oX0BZvmv4G79ZRvk=; b=jJ/y8bNHnT0cu1rKlWe9x+iL/zafiaWh4pXbrhJgY0XXbb/SytBhrm22AHD87EQ9S4n6EtmzBy1uGucXFEA0hZr8OxLh+92kidaiGmKvcbkyFyu+JUme2Cnf8RGoQ88Pd6XJlolFwhJxKnv3UtomxYQ32szQXafLfkeKKn9URls= To: Jan Beulich CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Boris Ostrovsky , Ian Jackson , Xen-devel References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" Message-ID: Date: Fri, 19 Mar 2021 12:59:38 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0284.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::19) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d87dd8f6-874d-4fe1-4c09-08d8ead6f705 X-MS-TrafficTypeDiagnostic: BN7PR03MB4515: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qqFfbidbI0g3v71Pm/IKEhyom4Lsju/swADXYta+96n3GPEOiT3zWDGg9WuQriIPph7VAouNR2vPxjL+2jupYv7GOk6CSlWqeVScWCSY2HzvZ/btaAFWPdJr9Ku1mocLLqHbExE/raDOdrAc8nzNp0gKw/13iRQSEjf5lG+KsLxMHH/4n/2gmT0rOySxv21jJ4+uINMpGT0RDROYiYHla40m4a6QL8/yBygxQ9K/hJjxT3YYzAKdcKm2Mp7E/0c3+OdE6GPUOzMUvOekn8FDtgWn4Qd9tc+BxZ+HhttLNriRU5ecLT7+5zyR8oSO0j3X+6H+j6oDWiS3To5lPokhm7qkskIDi/DaIfFsabIB8Fm/apLSi2TBvfxmEXck0nun4NtH0PNsmMhsDyU7lkU+Gpyr2ZXetXzyCm4x+X8EmbZLQddB6Mr7mas88fsLTkAv0S4RUi/MHudqzRamF7BB0vTARB5WTnOQUg8ACn1hQ9c6Dx2/DEh/B5EEJMQbNVC7P7igaXXfGOzQ3tCI2w+XVZnEQpcl5Z3SFE935diocW5jDKGwABQ6Xm5F+7BML17PJUNAkZEgfCYM2F0VJs58R1NZVzxffQfdgurEVxe9jToUhyJIXm7tvEIJy2hY12tQwTb4lSxNSEF+hsgay13iGSlTksvsEv1VCKKu4PUSgKvJHMx+fk6rTbf8Q9oIRE4xuTTOwR4KAbz/cc+uVKanKA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(376002)(39860400002)(346002)(396003)(66946007)(8676002)(956004)(31696002)(4326008)(6666004)(54906003)(31686004)(6486002)(16576012)(53546011)(2906002)(16526019)(66476007)(5660300002)(316002)(38100700001)(186003)(8936002)(86362001)(36756003)(66556008)(26005)(2616005)(6916009)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dUtmRnIzbzNmUGdHUFNaR1kxNGs5UnI2QWJsMWJwc3ExSWRBZGZaTEhOQXBo?= =?utf-8?B?aTZwakE1Y2Y0REFjZHBCdTA4NmtEM0xIMUxTT0k2MlFrQW5od0NocGhWVTZs?= =?utf-8?B?ZkdJbER3eHZUU2JZYU4vK2dJamhMN2xpZGlQTE1TQ1o1d3ZrbVh6aFN0NWFJ?= =?utf-8?B?UDdVejVnSGlvQlc1RW00WlJkWGU2UzlGY1o2bVhiTmxFbXlpbHQvQmxUdmFZ?= =?utf-8?B?SEp6eUdtYU1pcTFtSzlVVnhwZVZjVU9tejY4QzJMQXZLeHB5TVZpTmxZSEdq?= =?utf-8?B?REhZWFEzeWd2NjBnbkJLa1hLVVFCVEl5S3VreVN3NkFobHRiMjh6Q1lIbE5U?= =?utf-8?B?emt2LytNSFF6VHV1Vnd4UFBnckJVQmxQZlhLWFJoQ0dtMHhhLyt3a2FRY1Vl?= =?utf-8?B?R2VtQit6S21DclZGQmZIVE5IczMwY0lSRmlpNlJEWXZ5UTJpY1QvaVQ0Nmtt?= =?utf-8?B?cnFTRy9lcmkvZkRXalRTTENkb3ZOdytrVnl6NEJSYVEvQi96Zy90RExCNUFi?= =?utf-8?B?UWovU0ZQNjF0aGo4QjFIY1FmUHMzZmY4aHQ1YWJSQ1A4MnJ4NDBqNk9hN1J6?= =?utf-8?B?UWFQbVoxSUkzeHdhVURUZ0cya1hHSzNBR3EwK1VSamY1bXh6RnZucEdzSW9Y?= =?utf-8?B?MjgyL3N5eDA0Zm4yU3NHbmtMM2N5MFhjem5XWmtDR1Q0aWN4b1FDeGgySGZX?= =?utf-8?B?SUJXVFhleUxqVlk1NzdYUXBVd2JvUW1OY29mRERvSWlwTEVHZUFWV0Q2M0Zi?= =?utf-8?B?RHNtUWlOWkFHUm91bml2WmZINGxOblZyUldiQjVUOTcvKy9heFpoV2d5dDI0?= =?utf-8?B?ZzNmQWc3RkF2RXNVRHJPQlY0K1gybHc0c0JtbFJQYlBMdjhzSU45azA0M2o2?= =?utf-8?B?OTFXcDcyMUs3cFZwUzBTNkt2SE1sWGsrUHp3R0kzbThoRVh4dFlZeU5kN245?= =?utf-8?B?M2lJT0FpZ29raEtuVUQrS3lIallEQUc3alFjbzNSek9IOGVrTmgyY1U5NU5L?= =?utf-8?B?cDFOOVRXVWo2Tmx6WWV4NmpXQ29oQWZoOXVodG1wb3drMkxmeUtnRmpIZE50?= =?utf-8?B?V2xyaEExWndYcmZyY1FxV3hQeGxyQkpOdnpzQnRETVNiZUJjdGtpcnJwVk1a?= =?utf-8?B?MDhTdk9GTHUvSHUvOEJzNGNFS3Q0WXlaUTRNRy8raXN4ek13TnlCd0hoMVdQ?= =?utf-8?B?L3o5MWYrWmlMS2ZLRzlVR2JjdkFzdXcxQUFHYm1oaitpMWZvSXRPZE9DZktj?= =?utf-8?B?ZWhpUlhDdy9jbHdoTTBKWm5uK2RBYWVrTGJTeDM0WGFnZ3FKV3JCRHV3U2Rl?= =?utf-8?B?RDExbGk3MWYyQUwzWGVmYnU1UzhhL2VtenZZSEM3T3g4WXRFT1FwYUpNVEw5?= =?utf-8?B?WUtuRnN6OTVrTTk2bEZsQTQyU1kxTy9vMDJISThPaldaZm9ZcWtVV09nWm03?= =?utf-8?B?NlVhMWZ5bDVDZWozc1Q1bUVmSTI1eXFPVGg0YUE4djcyaXU5ZUJDNUNiRzJw?= =?utf-8?B?Tm96RWpvaEhZaFNjaklHa3V0bVU2N0t0dHVaMU42QjJ1TUF2ckMxTmJGeWcv?= =?utf-8?B?bi9NQWFiRXpERklUSXhqK01rT01nT2NvTXRDS2lBVGt2blIyRjhFTWNQUUhj?= =?utf-8?B?dHBQR04xVGhraDZ3aFkzY2hMV2ZyMzVKOXBhNjBxTnRwVGphRG0xbXNnL2RC?= =?utf-8?B?NHRwQ2s0dEhRQ2pzMmRNRGsvemJhSmVPTHFRMmM5N3JqU0RkVjdYUkdiNTV4?= =?utf-8?Q?sGPm4dYR7uLDZRYKYH8se9ipcy7JxOb4Xf3cC0X?= X-MS-Exchange-CrossTenant-Network-Message-Id: d87dd8f6-874d-4fe1-4c09-08d8ead6f705 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 13:00:26.3054 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ea/fixBoQ1CaZI3xuEVOh+0IHh8/KNprK6EhbX+prHiTWKXSAvTxNsVStO5/WlvNUWRnQ53aVsACBnp8D5hpz/Rh0datc2HubAE0qFY+2zI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4515 X-OriginatorOrg: citrix.com On 16/03/2021 16:58, Jan Beulich wrote: > On 16.03.2021 17:18, Andrew Cooper wrote: >> In hindsight, this was a poor move. Some of these MSRs require probing = for, >> causing unhelpful spew into xl dmesg, as well as spew from unit tests >> explicitly checking behaviour. > I can indeed see your point for MSRs that require probing. But what about > the others (which, as it seems, is the majority)? And perhaps specificall= y > what about the entire WRMSR side, which won't be related to probing? I'm > not opposed to the change, but I'd like to understand the reasoning for > every one of the MSRs, not just a subset. > > Of course such ever-growing lists of case labels aren't very nice - this > going away was one of the things I particularly liked about the original > change. The logging in the default case is only useful when it is genuinely MSRs we haven't considered. It is very useful at pointing bugs in guests, or bugs in Xen, but only when the logging is not drowned out by things we know about. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 19 13:12:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 13:12:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99240.188570 (Exim 4.92) (envelope-from ) id 1lNEuh-0006OC-74; Fri, 19 Mar 2021 13:11:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99240.188570; Fri, 19 Mar 2021 13:11:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNEuh-0006O5-3z; Fri, 19 Mar 2021 13:11:39 +0000 Received: by outflank-mailman (input) for mailman id 99240; Fri, 19 Mar 2021 13:11:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNEuf-0006O0-OZ for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:11:37 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b2969e72-26a4-494a-a1d5-ea8b4ce39c90; Fri, 19 Mar 2021 13:11:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2969e72-26a4-494a-a1d5-ea8b4ce39c90 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616159496; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=x9xzZdNEeMItWFRkbLmUULYsVemJFeq/wyAB1bQxplo=; b=FIkdQyOOW1RpgLndD58jHQsCBE8+zS64YcHF5MlqZBTw74ocFG7Krgd8 1v8Ti9XtJHPhcfZLY6Odeyq1UKU9eNhnK03ejTSRvC1FC0PczsX/TaiWk p88fuKPksvnOqcEnlCmRDa9GCRVIgFEpc2x0AYSStmBitMOdB0sS3E1fg M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: MrEMg0GOTf7pGvt5JzjoznEDeOFcIHheHcLas2l3Md0DDioUZc5VfxUCEE5veFy/Ykhsznjtyd ScvgaocgvlL6YOOYoBj/Tu646y1NwVb9LqYQ4RAXQEf+Z2Sr/5R/sNkIoZswq5zDfAZVia3/a6 VMxRDGR9CDznHiZw/xn4BrWWU4HyFJjKPHXhXrHKhcnPzbieS43nYFjjo/CmtGVEklPSjj0G3d xFAyVy7wSQpBSO7RIy3Mq493tCoo1bITpun9RgDIAdHZMW/8/KnK0eqPmV4SQXePdvVoJ3SS4Q uqs= X-SBRS: 5.2 X-MesageID: 40049230 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:DwYNcKiDe/z3+Iq1JOG6WSaSNXBQXwh13DAbvn1ZSRFFG/Gwv9 yynfgdyB//gCsQXnZlotybJKycWxrnmKJdy4N5B9efdSPhv3alK5wn0Jv6z1TbaknD38N+9Y MlSahxD9XsEUN35PyR3CCUG8stqePpzImGnuHbpk0CcShPS4VNqzh0ERyaFEoefngiObMcGI CH7sRK4xqMEE5nDfiTPXUOU+jdq9CjrvuPDSIuPBI79BKIyQqh9b+SKXOl9y0DWDBCy6pKyx mmryXF4MyY0s2T+1vn+EL4q79Xn9bgzdUrPr3wtuElbg/CpyztSIBoW7iptC04rue1+D8R4a XxiiZlBetfwTf8eXy0vAvM1mDboUkTwk6n83C0qz/CptH0Xz0zAcYpv/MmTjLpr3AOkfs59Y Aj5RP/i7NnSSnusQ642v3zEzZtrUawqWpKq59ps1VvFbEwRZUUkZYS5ypuYfE9NRO/0q8LOs 90AvrR4f5HGGnqFUzxjy1UzNugUm9bJGb+fmEy/sic0z1hlHtk1UcvxMsGgnca9J4mIqM0n9 j5Dg== X-IronPort-AV: E=Sophos;i="5.81,261,1610427600"; d="scan'208";a="40049230" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vy49PQcXlplBqhc+qBHIwlcuZ0CJLLS5NW5YxDfu3QbfiZzgPyeSS6B+Thr6joehFuffjKWqbHpPwrR8IibRJfTIpzAW7Q4CrKdncsEAFbAAUs3euJbs4ohri4hBTuoSTDVX72frhXU/tzkhehyKG6IPVDSUHea0jRSpNCVgl8Lv2TwFbUNibhIhgYOP27hNcQP8zVk2yFr13PT0aXMA1KLy7f8ZWfTTcnuq4cUglAi3yJWSy8OdCsqP/O3JEtCIFU8Wn7udtskZbMVNW/y6PTmXsIU5GU9z5fpcKuftnXv+oDyR97lUEOiqi7i1AhbxRsUO1qkz4eMWIL2VncvH4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8jM8qdwwfFOCDRt77RJ+JAWvBOuX8McM9bLag1QMCR4=; b=GbITMBmap9IB46VPPX6T/nTXHt6n6hjZLZh+KJRgdQl9kExNxkaassviP4aHJAs2Z+35KL4J1Myy2dEadj6+/WgQxauQ/qgOIj5poem5PL4x2Afjfn480nCOFL2ven0acBwtu0Chhc0yqHyMtHmkdaxsQp8fYXM1LSUSfyoWaP46CYoqBnuieejaXY3cgIlHt8kR2LaFVO7b1m6Fn2Us/sGdxngrH/+JnR9kX3edV/Sh5JN/anyUJAPI7J+k7cTKAJ/5UTTWcnrV3byMrB1bAUoowlgKmkL+Vlkd2VNPYVZRLmYVFhR7UdXncNJqYrp/gtGSjhmIDJ+KFbdIEdWcZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8jM8qdwwfFOCDRt77RJ+JAWvBOuX8McM9bLag1QMCR4=; b=SiQ+Cn3jsl9P+0+Tp2A0Sz4GtiAnJlBwhuXbEZ/uGY0jJ9mQSMzMP4iTy3ujw9sLoPlb3itBfmoHY6yW1mGbMMqi/AeBBqxfLKxXidJLL984CPejLUgyYyyyX+RS+sVz8aD814KnEBATj27OdONJZaq04LPidz07JM937CEI3tI= Subject: Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" To: Jan Beulich , Ian Jackson CC: Xen-devel , Wei Liu , Boris Ostrovsky , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> <24658.1583.601613.903527@mariner.uk.xensource.com> <6eb6f686-d67e-6db3-6b4b-8c63e676e311@suse.com> From: Andrew Cooper Message-ID: Date: Fri, 19 Mar 2021 13:11:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <6eb6f686-d67e-6db3-6b4b-8c63e676e311@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0307.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::6) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2d6477d-7cb2-4758-c8ed-08d8ead8841f X-MS-TrafficTypeDiagnostic: BN7PR03MB4386: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wXT087dQMUCHb5kkCsZzALbT/7B77+TkeWFzDBvO8lOlGzNxoPD+FeMi8vOXqA/oQFyps9uGdSbDeSh9GGPfGcfwM7wHuxQpdZngYWBDuyTsqKaYPLlX6//Q/Av31clIPLiJLLmi/IwgGZlkcl60tXkul3ATmSatLppYJZhW0ag3ii3oFPSJID+pRh/x7yBlp1ISbsDZg6uN7BS0FDv0kn+pkejdFciB5d/TUdySuwJsPVAC16D1bnlwHsD+YYg7yjY/on2OnYdH7FCw5XYSDSLcJdHnULNHnhG+vc6GlUnhyf/4+tKog1L88Dz2yb4tlWaAFg9Az/KbTqC218sylJPl9c8o1HXJKT2bW/JPRKJXuru1PN1edH+BVNEhvVnsh5v9wTM/gWmggsp0frCcSd/C9X7xr9vC53GxXTXeF1NShpb8feMZIPN7W2MVLZ1elJvg+S6iihJC2LRt7psqxlo7HQCPmqlV9ZkSSvcbStMd3m/orkvxOjmpxU4SC3NDs8so4CX32Zb37Bpcs1OOGkx2pjVG+9EzFbrLb1Yf9GFHWaZv/c6SIsAXLjmBH16jXGjVpROx1EdFH8iEV4zonrk7kQ7FJhxrCswYVMbWIp1evJT7rcjo36tcvxukP7KAK3iiWHhBeWc+JOqVeptDmVHHeoZIurywoTPyIzuWNo7U+y6KTCklJUeC0tAtAs/O7viOK/X1vFhwoR2xpg2yWDjwnrOGDuuM2kA9rrKg77M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(366004)(396003)(346002)(136003)(186003)(956004)(16526019)(2616005)(66946007)(16576012)(83380400001)(66556008)(38100700001)(53546011)(316002)(2906002)(5660300002)(107886003)(31696002)(86362001)(8936002)(31686004)(6666004)(110136005)(478600001)(54906003)(8676002)(36756003)(26005)(4326008)(66476007)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?b1kwVjh0NEw4SDRVWWNJOWU3UFlGKzArRXFyUm1qNjJ2UWZlVm5QU3V6TkxH?= =?utf-8?B?QUFHdUpkZ1Zocmdxa2owV28rcnhqaW15ME5nTWI4UkJGUll2Vlo0d2JYOEVE?= =?utf-8?B?bG5pUTNaRldpVXVCYUd3OUJFNGRzSGNKbTh0Q3puVE1udEVCekZGQmt3cldJ?= =?utf-8?B?MVkzeHJZUVA3UnlyeXZGSTJudW1Udms4Wk1KeUR6aGpjWEt1VUpYNWh4NjVh?= =?utf-8?B?cjNCSVAyL3JmcHdWYmI1WnJnaEZrTXpmWVl0a1R5SHM5amZEQW1ZU0FIYjNR?= =?utf-8?B?c29NMUs1YVlhK2xPcWJKczgrTTZJNms2K2NzbjAxeW1oaEN4Q2hpVEZKUTdD?= =?utf-8?B?WFNLVmJORnArZHo2Z1U2TldZL0RqOWJ0cmNXY3JEUDEyeERnVnNERHlCMFhv?= =?utf-8?B?M2twclU2TGNuejlaamM0RGJNaldIUWdhb2huVm15TldnZ2tTRFhPak96WVZI?= =?utf-8?B?c1FxOXliTk1lZ2h4WWJUSzFPaVh3R21pZGtseG5ObHhrOWxRb2NRSyt0Mndz?= =?utf-8?B?OW1GUTBUcUF2Lzc0QUgzWStCNW1nRFVGalE5UXl3UTVNZ1Z1aEI4VGVZOUpY?= =?utf-8?B?elRMc0FSK0I2dGJ1cGJETHhIaE1YejhoQXlyOVNtZU5GbXU1TmM4REpzbnBS?= =?utf-8?B?NVc1b2JHTW9QSUJqMnA5ZlArdTB4dURFVkVnUkxyR1RPTDF3empIK2JqczBl?= =?utf-8?B?NlpBd01qR1NxSEEwTExJMkplOHgxRmVxNTh0NjZ2NkpCVk1mSDgxdGZFZWU4?= =?utf-8?B?a1h0SmFoMHhaTmVrUHBaVnJEdUFVYlhycnBqc09wR2d4V2ZNenFZbFBoYzY5?= =?utf-8?B?UUZDRmNPY054c3ZUc3dESVVNZzNGdjl0T3d0dGFha2V0TVh3NHFXald1VEhI?= =?utf-8?B?KzR6cWwvcHRRbW1YL2kwQm00VnJVSnpMSWZWWHdPcGptY1djcXErYXl4KzZz?= =?utf-8?B?eE12OXRuQ2dQSzdUbzlUOFQ3cDBuVU5HYzFRRmVPRGw2RklzSnlRaTh6MGNi?= =?utf-8?B?ejBMK0N1NzZmT0xucHZmaG9mbUFDUXBiQjl0VHVQN2NxelFFMVBtbFRFK0tj?= =?utf-8?B?RXpPYi9pOGE4WVFJL1U5RFAxNUcwdi9rTGZWMUtBMy9sOHh6UElNS2Rta3Ex?= =?utf-8?B?RGVzN3VRZm1ySmJnZUV0dUlGcmNBOEZhakRzc3pIQWFveDlOT01vRzgza3FQ?= =?utf-8?B?eUhaak5FeURkY0phS0JFVm1uMUI0RHZMRnZpTkFld1hKeGt0MVpaSVV4V2xi?= =?utf-8?B?U00xWmhSYmtpL2xkVnc5TXFiVXdnNjdjR1pYWC9tUFQ4c0gzb1ZjTGtlemJU?= =?utf-8?B?N1RtZjcrVDB6RVBJL1N3dCtGZExraTAwNDNqNnB2OWpCcjROMVlxNVozN1V3?= =?utf-8?B?bWNHUHJrTHhkNEJFTSs2czVNbjZMT2YzeGZPVTJzcTJjb1hCamFWcU4yR08z?= =?utf-8?B?MkNtblBDeW9iZ3ZZTEplYXpJQjBiNU1ZWmVHRFZZaTlFNjdjNUtPNjZpaTV0?= =?utf-8?B?ak9rZGRGZ0Iwd0d1ZkVmdVp4WDY4TzN6M0c4NlpRcXBkWHVjSUg2Q3Jmcmh5?= =?utf-8?B?YjM5OTl5WTVERExkUlVhaE9lWEdmN2YyWXNvMFNLUGk2Mi9kcEtuMXJPekh6?= =?utf-8?B?di95UjlUVzBBYy9EYW9uUWIvQnpmVklaeG5rakdmRDl6SXNDd0l4RHo0dUlB?= =?utf-8?B?UHdENE1qM1IvTTFSSkExYzVaT1AzMFRJNWY5b2c2ME9aV2tOcUpmRDk4RXZn?= =?utf-8?Q?Vre+CWMXP3NSpxtExkUCVnik4qY6MgpAYuiErFv?= X-MS-Exchange-CrossTenant-Network-Message-Id: b2d6477d-7cb2-4758-c8ed-08d8ead8841f X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 13:11:32.5075 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KgCIoPlXPVxZuvpweyK8kUAUYzFskTWkzReTKNkHiS0TncpKNxxheLvGkSLDMix1yj08nwNomm9T5ZZcbpUmVe+TKh05Ap23rSQaVDvq+pI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4386 X-OriginatorOrg: citrix.com On 18/03/2021 09:35, Jan Beulich wrote: > On 17.03.2021 14:37, Ian Jackson wrote: >> I have read this thread and with my release manager hat on I feel >> confused and/or ignorant. >> >> Patch 3/ has a good explanation of what the problem is it is >> addressing and why this is important for 4.15. But then there is >> Jan's most recent reply starting "I find all of this confusing". Jan, >> can you please tell me in words of one syllable what the implication >> of that message is ? In particular is any of what you say a reason >> for me to withhold my release-ack ? > Answering the last question first - I don't think so. Something may > indeed want doing here beyond what we already have, and it may well > be precisely what Andrew is proposing, possibly just with extended > descriptions and/or comments. My confusion about patch 3 is that it > (a) claims behavior in turbostat that I can't locate and (b) implies > (describes) behavior of code that I find entirely unexpected (as in: > not making sense to me). Turbostat was discussed on the LKML thread where KVM fixed the same bug, IIRC, but I'm struggling to find the reference. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 19 13:19:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 13:19:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99244.188582 (Exim 4.92) (envelope-from ) id 1lNF2f-0006iG-2j; Fri, 19 Mar 2021 13:19:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99244.188582; Fri, 19 Mar 2021 13:19:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNF2e-0006i9-Vg; Fri, 19 Mar 2021 13:19:52 +0000 Received: by outflank-mailman (input) for mailman id 99244; Fri, 19 Mar 2021 13:19:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNF2e-0006i2-7f for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:19:52 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f5eb267a-dd63-43a8-9215-d59a63c1594f; Fri, 19 Mar 2021 13:19:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f5eb267a-dd63-43a8-9215-d59a63c1594f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616159990; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=0NcWoEzdbXhmf/cdxX1hw5z8CvUJ1kuG0SVKrxwSwAs=; b=cuAxaMJM1sP7yrKnSJSlG+3mII7ImAaO3oYeaL3iVTF+zcXkTc9w7K7I WMXaIpRAsoKSjPz5vw1AmJ43U9qHPo9CsQe+uJi4aY12r9VS4wi73UthB lbtaBcfIYcKt5V/Fb242Z/5j6YFgrITzQLK8/huRAg0eJnT1ZxWKczRzm Y=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: SitBBHG6+155rW5S1rP+5eKp+FR2hVL7UL+5Kdx2ReUUUE3jEUe1cL1k8my2CfYPzb0cvf6rgY /wz5c4PVpCzHyCydjTQ7X/LLvb07DKllV7MRukuBZQz8/FdKnH96WWKi72Jk+SCbRgvwYSwYrm 05qR8YSQuDcKM1jS7hvii3oC+L0//wLpZG+9iEArFhhhUSrU9bygda9/1DTQ4+ozpEazC44Pxp uunDYEqle4B9Pj0wHcqhO0+KY5GnQHX7AK+IcU2E/m17Jcsl7sr1U2QAqaPR+OUdcST7WQjxdG w1s= X-SBRS: 5.2 X-MesageID: 39572767 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:te7oIKEsvPblY6rCpLqECseALOonbusQ8zAX/mp2TgFYddHdqt unm+4V2QSxpDEaXnwhnt7oAtjjfVr385lp7Y4NeYqzRQWOghrKEKhO5ZbvqgeNJwTQ7ehYvJ 0OT4FbKPndSWd3ltz75g7QKadF/PCi/LqzjenTi1dBJDsFV4ha4w10ChmWHyRNLWEsb/cEPa GR+9ZdoH6YcWkXB/7LY0UtZfTJpNHAifvdASIuOhhP0mizpALtwpH7FgWVxVM6VTVXqI1Sll T4rw== X-IronPort-AV: E=Sophos;i="5.81,261,1610427600"; d="scan'208";a="39572767" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EKYcTY3y6eZ3DaXkF7/OPvwCenDraTuPr+P4ds2At4Pe9A37o/OPP4FlHuHLWLlVEjaNmFrL1SVByzuhuEEaWySG4vRcFAAevkr+TTbaXVOV25tFVxGxSP2e0JNxXRvrxKvxbhQyCqxnS1f7sekn/5cLr3uneXVxc7NIERaF5AVq/bkQHNOg8bCFxikxC6MzHcwgcW43VXBiKFT8OVEnyZvVwV8cHwMTM57RBD6kXRVCmGxnRadcI/Gkm6BPPhkWTCqWZ1OREn831dMXkFnwEZy3EAnrah8fHVo84LVi09iDKUFlY1XmNfYgQsKnSOVl1cz1exLu/lJwQTs7vs0X/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w5bDv9kfZkr+AU1/mzly39sY+NHjKP0bnPnEXb8xafA=; b=J01fgCgsa3WVud/vbQTfMWkAgD1d/v6ZB5/1Ss+zBDc/x2ko2Zg6X0M8ibJNDk0BzMzvwYFySVO1s7jQsJztgDutOYn0E2sZYpX+SKDYrrTZ7WNw9K0wycUPQSjhJ8eXn8cPAsn1XM49IWivm6B+Bk3KL0tmSawlsmBSFIh9zLODpkEdJsQgWwG4esg/JE2d39elgYbqTtCy5qFWmK+pZWf2MlJTJf5KIdcssIh1OiRfkYfrgps5CXtSGg3wubz2FjqQTZ3Upi0scnj6c0xNQrG/VGmbwuvpK6X+9WqUbZyLtXqAc7LD93hYYBd0K9YIkPeJyLElsLBRKrW3ynT/Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w5bDv9kfZkr+AU1/mzly39sY+NHjKP0bnPnEXb8xafA=; b=b3UdXkdAqbd5PC1o+KfLPrSYxOtZhEX/GD4LnpuBbkLrcY0aAhipKk7BL5BnloFSWsWg51lbX+oBR/KOOSmAe7+nVhD8EdDG6H8Ol7nP3ZvCsPyx/uF2LnuaTMdqRPYEBGjs1nLMnjLjwQaI86KgMRYDANGOE9wkyCfC5ABxap0= To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Xen-devel , Jan Beulich , Wei Liu , Boris Ostrovsky , Ian Jackson References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-3-andrew.cooper3@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 2/3] x86/msr: Forward port XSA-351 changes from 4.14 Message-ID: <35b5b492-23f3-12d0-e7b5-363f23a52ccc@citrix.com> Date: Fri, 19 Mar 2021 13:19:41 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LNXP265CA0067.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::31) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e9176e4e-c42f-47fb-2847-08d8ead9aaca X-MS-TrafficTypeDiagnostic: BN3PR03MB2369: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3513; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CUh8elPY+CF6sGanRvPDVydXVjEor8iAutH7s/OkjeZ04YNjr/9xaPbR4l2pgXHZRjffC0EArtZ7XnCHiywYoJwT9FWJoDcz2YmgwP7iHuzU0TfwWxGhigNKu5b3HRBwPKeIvBihKlrr2ABSyEyL8hG9nw9KfnttnxNWW4gsxPIIOCZh0Szg+AksMx+wC7+jsYVilQ/EzgJ8HnTxI3G/PANzRomMdOXV8wKQ3zTxw9dIyiIipdf4oUMHdbfuNQ7JthKN1w8O6obKi7nekYEgXsAgvS2Fbxws1Lk5A8WDYtyX9UFbFynynUuRn0TnlrP0fSIPYnGbt/aHLYEFsbVB7x70dG855lYZv7BhPPOidLiQ7Eogi6IM+bh1VgRS+qzdtzNBuLNoCWNl3oMFrjzei+m32nn35r27hexx3AErutnGf+GPSBCNyPvWr/WFELvFxaf/KW9ZcsH9nR781n/eWiNm+0FjVilw+DRvZQRVgC1wgLItuMgvEi/p7w29TItOB0FHyyM9obWveY0KFX8q2uBTgZtIpKYT3K/K2PyHDo6KrDSIRzLdapvNDeNB/QswPW3rPeN/HxR3hHUzGsOzHWzFlucBW0GhORA3YGMRDUzDUuNRm3xDxcKXTjAttSG+XmPCBp7e0DINOfz3vO6vxBBvU2RODfcrxKSnMxR1RV+kiJx57t5nIHzuynfNiEZg2cLObl35EmxpcFR5tm5oocK/Sx/rINoFzC3uujcv3NU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(39860400002)(396003)(136003)(38100700001)(66946007)(66476007)(66556008)(31696002)(5660300002)(53546011)(86362001)(6486002)(2906002)(6666004)(316002)(16576012)(478600001)(37006003)(54906003)(4326008)(26005)(8676002)(16526019)(186003)(36756003)(6636002)(31686004)(8936002)(6862004)(956004)(83380400001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Z1FJYURlMGtBODBrQ0VKWjBGdm5XNFI5dFYxWFYyS2oxcjcwU0wxeW10Q0Nl?= =?utf-8?B?NG9DTFpSSDhRMHpIR3NzNjU5UEFxV3g3cXBnSVpia1ZzRGM0VXlBNzlvZk9I?= =?utf-8?B?WVV1dTFaYjBMYzNNZ3dxRUtwT2F0TFRiSlhSdmU3TUlpUFgxYm96Q3pHemtN?= =?utf-8?B?N3ZJekRyWUFDWHBHUk5VRWZUNE1vZ09GK3JNL1hrUGVYWEM4WWdOcE9TZXJ0?= =?utf-8?B?bmQrMXV6YWJDWVZ2UC9naENveDU2QkdoZnpMN1REdzYwQWNqdGxxSHpSUkpK?= =?utf-8?B?ZmVvRjVrRDJjbW1BTWJ5cjY1L0FCMjE3YWovOFE1RFFYSUNCbnFUdUNXWUNt?= =?utf-8?B?d0FzVytoVGxGTEd0M1NkV3BOT2QwNDlqVXNTeDFPdWp2bmRvZ1VoY240VlVV?= =?utf-8?B?RGY5aGlTSHJiWEZBS2FsSE1jaDdSUjBSWnlqbVY3bE4rSmg5QU1Jdlg5aFJT?= =?utf-8?B?OXdqMXdWUzc5V1V2YlJYU1hEaHgzUnBNdm5uWllKT0JpRXV5WWZNZVZNTFNJ?= =?utf-8?B?RmJQa2NrNWkyVlpmcFZ3SXpNV1JFQmhvS05MOHBpY2lYQTZQYVAvRVBFYVhO?= =?utf-8?B?RUd2SnR3RXBmOGZRb05FZVRvd2krb0ZDN3YxTTJ1UWtub0pvejloNVZOMS9q?= =?utf-8?B?RE5Yd1dTUEIvUUllcVhvaW4zVnNEMmN4NlNxWlZLUGMyRERCOWsxeGV2eUcv?= =?utf-8?B?eHpnOUdPUWRUNklQSVZ5YVN2TmJITGVRaE45SkxWdDhtcURUdXdQNVBjbzZ2?= =?utf-8?B?SUoweTIvZEtFYlZLVWhTQXRUejR2a3QzV2VMRGFKRUxYSjFvR1pmZXpLc0di?= =?utf-8?B?bE1HbkovTi9qeFhhSjh0ODcweUoxKzFnWHFjc0s0RXppTTBjWEg3b2w5TzNj?= =?utf-8?B?SU0ybDViN0lLU3JvUlFRTms5QkVhMzZDMGJMMHMrZ05iTithUWxXM2h0dm5q?= =?utf-8?B?NHBONzNrN1lYY1N5UW9oVnVGU0EwU3duL2w4ZDk0eXM0NnQ5aHVoNE1iN2J4?= =?utf-8?B?ajBGeHA2b2lxVndwRUNYWUIxanB3UjJXSzh3WkVEVm9UNkdYdWZxWnU1Ly9L?= =?utf-8?B?czdhYTk4WVZKMnFVa2VSZ3h6N0tQR1pMbGhwYmF2bEdIRTJqaWd4Rmp4WDJM?= =?utf-8?B?d0E2My9vTmhWcU5LemdGem92bStSby9CM1hvU2F3M3ZJckNkTFZ0TjFGZmhY?= =?utf-8?B?MGZOMnpkS3pxVWtNL0NTWnFBaXAyd3dLT1hBaTNuZ1ZCSWFlb01IK01Fd2RS?= =?utf-8?B?aEZlMXovTEIvYnhpYWlqK0N4eWlVc3hYSnRhMUwyRWlrZ2Y3aVRET09FZU5R?= =?utf-8?B?YXBsWEF1ZWcyallERThuSVVqRkdaNnpVWDFDZlBER1ZuelFOUXYyMi9Gc2pa?= =?utf-8?B?MmZIZGc2VytjYWJjODYwTHpLbEtucjVRek5IQ3RydWJpbFp2SW05M0RiSVRK?= =?utf-8?B?eVUxbE5hcXFjVEFEd1c0TVBKNFFsL3pZa3QxT01OcGFDZmhWa0o5cFVEOXJI?= =?utf-8?B?eUp3RmRGMXRUZStpcUl4ZzhoT1FFWmpkZ3Y4aENadlB3UDQyU2JIcE16dUx0?= =?utf-8?B?MVlhRld6R0pVZWY2YkVYcklObXZJamhhZEo0b0JweVkvcGx6Umkxb0Fvb1Ft?= =?utf-8?B?blFhcjR1Nis1YUlHZ1dmYnpPenhpeElPY0NBeDQxS1VZeDJFUTFFRmJXcTd1?= =?utf-8?B?Z0h5bFY2UXY2YjlwOEVIMTQvcmFna2tONWJSeHJkM1NOSS9pNmdCVWpiOGRy?= =?utf-8?Q?PyK1dJZEaZfXNJImhsWUHCLsIO/f9KO5c9c0/J2?= X-MS-Exchange-CrossTenant-Network-Message-Id: e9176e4e-c42f-47fb-2847-08d8ead9aaca X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 13:19:46.9961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mq1QVt1u5kWBtsDMQgDWjbhDILCVCzVPbQdj8RaUELPCaGuTeRTgpR6EJAcpv90Pu8DUEWrO3LOrHjmhEk40WK8EtXoM5ub676RRxKI7OyU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2369 X-OriginatorOrg: citrix.com On 17/03/2021 08:52, Roger Pau Monn=C3=A9 wrote: > On Tue, Mar 16, 2021 at 04:18:43PM +0000, Andrew Cooper wrote: >> staging was not impacted by XSA-351 at the time of release, due to c/s >> 322ec7c89f and 84e848fd7a which disallows read access by default. >> >> Forward port the XSA-351 changes to make the code structure consistent b= etween >> 4.14 and 4.15. >> >> This removes logspew for guests probing for the RAPL interface. >> >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: Roger Pau Monn=C3=A9 >> CC: Wei Liu >> CC: Boris Ostrovsky >> CC: Ian Jackson >> >> Technically this breaks Solaris/turbostat insofar as you can no longer u= se >> msr_relaxed to "fix" the guest. The subsequent patch will unbreak it >> differently. >> >> For 4.15. Restoring behaviour closer to 4.14, and prereq for a bugfix n= eeding >> backporting. >> --- >> xen/arch/x86/msr.c | 19 +++++++++++++++++++ >> xen/include/asm-x86/msr-index.h | 39 ++++++++++++++++++++++++++++++++++= +++++ >> 2 files changed, 58 insertions(+) >> >> diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c >> index c3a988bd11..5927b6811b 100644 >> --- a/xen/arch/x86/msr.c >> +++ b/xen/arch/x86/msr.c >> @@ -188,6 +188,13 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint6= 4_t *val) >> case MSR_TSX_CTRL: >> case MSR_MCU_OPT_CTRL: >> case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): >> + case MSR_RAPL_POWER_UNIT: >> + case MSR_PKG_POWER_LIMIT ... MSR_PKG_POWER_INFO: >> + case MSR_DRAM_POWER_LIMIT ... MSR_DRAM_POWER_INFO: >> + case MSR_PP0_POWER_LIMIT ... MSR_PP0_POLICY: >> + case MSR_PP1_POWER_LIMIT ... MSR_PP1_POLICY: >> + case MSR_PLATFORM_ENERGY_COUNTER: >> + case MSR_PLATFORM_POWER_LIMIT: >> case MSR_U_CET: >> case MSR_S_CET: >> case MSR_PL0_SSP ... MSR_INTERRUPT_SSP_TABLE: >> @@ -195,6 +202,8 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64= _t *val) >> case MSR_AMD64_LWP_CBADDR: >> case MSR_PPIN_CTL: >> case MSR_PPIN: >> + case MSR_F15H_CU_POWER ... MSR_F15H_CU_MAX_POWER: >> + case MSR_AMD_RAPL_POWER_UNIT ... MSR_AMD_PKG_ENERGY_STATUS: >> case MSR_AMD_PPIN_CTL: >> case MSR_AMD_PPIN: >> goto gp_fault; >> @@ -412,6 +421,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64= _t val) >> case MSR_INTEL_CORE_THREAD_COUNT: >> case MSR_INTEL_PLATFORM_INFO: >> case MSR_ARCH_CAPABILITIES: >> + case MSR_IA32_PERF_STATUS: > Should the MSR_IA32_PERF_STATUS addition maybe be part of the previous > commit, as it's not related to the XSA-351 content? It is XSA-351.=C2=A0 We sent out two patches in the end. c/s 3059178798a (the PERF_STATUS/CTL fix in 4.15) was backported to 4.14 as one half of XSA-351, and gained the above hunk because it went backwards over the #GP-default change. In light of patch 1, it now needs reintroducing. It doesn't really matter if this hunk is in patch 1 or 2, but it needs to be present, and fits better here IMO. > > The rest LGTM: > > Reviewed-by: Roger Pau Monn=C3=A9 > > I wonder whether we could squash this with 3/3 for staging commit, and > then only backport 3/3 for older branches. But it's likely too much > work just to prevent breaking msr_relaxed for Solaris for a single > commit time span. I did consider the bisectability, but the reality is that it has only been a week or so with msr_relaxed working at all. Splitting them apart is simpler to review. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 19 13:21:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 13:21:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99249.188594 (Exim 4.92) (envelope-from ) id 1lNF4P-0007Z3-Hp; Fri, 19 Mar 2021 13:21:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99249.188594; Fri, 19 Mar 2021 13:21:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNF4P-0007Yw-EI; Fri, 19 Mar 2021 13:21:41 +0000 Received: by outflank-mailman (input) for mailman id 99249; Fri, 19 Mar 2021 13:21:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNF4N-0007Yp-SB for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:21:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNF4N-0003o1-OH for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:21:39 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lNF4N-0007os-NL for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:21:39 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lNF4H-00089u-Jl; Fri, 19 Mar 2021 13:21:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=Q8fjqgpZVjoqbFYbjK4175+vAtXULHxyNR7OQW9Lmck=; b=UZohfa8fob4N1k5NA+Noiwl5IS Ww5ILT1O1ahme65kvxMcvioPqlrQaxtTWmDQZtIpyV6x+msEku+XUBd5LQky/AvH0knZehMkHG1Cz 7nmsxbDZX19f4bF+pMbFxaSM9iZTFDlZeupmDYhPo2ugjLD2yRkjUsbhTK7jv+P6d5t8=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24660.42333.417431.528632@mariner.uk.xensource.com> Date: Fri, 19 Mar 2021 13:21:33 +0000 To: Andrew Cooper Cc: Julien Grall , Jan Beulich , "xen-devel\@lists.xenproject.org" , Stefano Stabellini , George Dunlap , Wei Liu , Anthony Perard Subject: Re: Call for tools backports (was Re: preparations for 4.13.3) In-Reply-To: References: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> <24658.6228.390535.850901@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("Re: Call for tools backports (was Re: preparations for 4.13.3)"): > These are general backport requests, not specifically for 4.13 Thanks! > d92ba1aa7cf8 - tools/ocaml: libxb: Harden stub_header_of_string() > 59b087e39544 - tools/ocaml: Fix stubs build when OCaml has been compiled > with -safe-string > 78686437e949 - tools/ocaml: libxb: Avoid to use String_val() when value > is bytes These look straightforward. > 2b8079610ec5 - tools/libxc: misc: Mark const the parameter 'keys' of > xc_send_debug_keys() ... > The penultimate one is an API change, but strictly in a relaxing > direction. I am happy with this and will backport it. > a6ed77f1e033 - oxenstored: fix ABI breakage introduced in Xen 4.9.0 > > The final one is an ABI change, but fixing a regression. I'm not sure about this but I think the effect can only be on "Reset_watches" ? I guess I will take it. > 5e31789634 - tools/ocaml/libs/xb: Do not crash after xenbus is unmapped > 2a47797d1f - tools/oxenstored: Trim txhistory on xenbus reconnect > c8b9670825 - tools/oxenstored: Fix quota calculation for mkdir EEXIST > dc8caf214fb - tools/oxenstored: Reject invalid watch paths early > 45dee7d92b - tools/oxenstored: mkdir conflicts were sometimes missed Ack, thanks. > Do we want to backport the -Og fixes so we can get ABI checking working? As Jan says, I think these are still in a state of flux ? Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 19 13:24:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 13:24:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99252.188605 (Exim 4.92) (envelope-from ) id 1lNF6o-0007hY-VM; Fri, 19 Mar 2021 13:24:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99252.188605; Fri, 19 Mar 2021 13:24:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNF6o-0007hR-S3; Fri, 19 Mar 2021 13:24:10 +0000 Received: by outflank-mailman (input) for mailman id 99252; Fri, 19 Mar 2021 13:24:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNF6n-0007hM-EA for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:24:09 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a5f6d200-9528-47a8-aa04-f3805c966645; Fri, 19 Mar 2021 13:24:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5f6d200-9528-47a8-aa04-f3805c966645 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616160248; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=xn7rjvu3dh8SwpcE84e66nM6tuCBjnvG8vY5CRsFkAg=; b=f6Zto/i6a6tOzawZWLHvmPQL5PR7xH0G2BJ4ExhVwNxCXbDitO7d5gtp e9Q++ZiyXX5j6xjL2hXY5Q1pjNTQj8GbFTGeZYG7AMawYVzwNVvc45kKl mVnKZ1zT3rXhoGqAICoBKyVjWLqjIrzxseWZkwI0KY1Qh2sOmuTzRUgat I=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: HWYsxmfsb21hJ2LyZw21BUArwPAy/ze/piahpMUbVlmp4wPON0fjr1dX9Dx3ewlKOXtVBT0UYv yUWe9mVkuVYCEik+TbkW3CE4SVLt2DD1Q/9lJ4ehTXD4sBYmWp6hy/tl5QtKBAAm9LLWfSWD31 vAd2DBYtd+c7sf2ofgFNO0+lkvcjZHdhmFoxUMdZQo9qfYmfsONI8hhE+518kbTHkl8KExJyFN woFXW76mzpKoUWUtgiFUExeNt4aAhVpLQ3uiVsmjbraCBt/DDibsZszUikfutganUEg+gl/kWE Y58= X-SBRS: 5.2 X-MesageID: 41116999 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:jhDf6aFVsfqG1mOQpLqFRZTXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7Lk/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeNJwTXzcQY76 tpdsFFZeHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLD1CQYsI1XYcNi+wFEpqSA5aQb8wE5 SB7sRKzgDQBkg/RMK9G3UDQqz/vNXNjp3relorABQg5QmIg1qTmcLHOjKf2QoTVC4K/Kc6/Q H+4nHEz4iAk9X+8B/T0GfP849b8eGO9vJvDNGB4/JlUgnEpR2vYO1aKtu/lRAz5Nqi8VM71O TLyi1QRfhbz1P0UiWLrQD22w/muQxemEPK7VODm3PsrYjYaVsBerN8rLlUeBfY9EYs1esUuM kgvxP7xu9qJCjNkyjn69/DWwsCrDvSnVMYnfMOlHsaaIMCadZq3Pwi1XlIG5QNFj+S0vFELM BSCqjnlZNrWG+BY2uclmdix8HEZAVJIj62BmIGusCTzgFMmmF4w0Yy1KUk7wY93aN4ZJ9e6+ veNKN00JlIU88NdKp4QNwMWM2tFwX2MF3xGVPXBW6iOLAMOnrLpZKyyLIp5NuycJhN6Jcpgp zOXH5RqGZaQTOhNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dQWeVVEHiaKb0rYiK/yef8 z2FINdAvflI2erM51OxRfCV55bLmRbeNEJu+w8R0mFrqvwW83Xn92eVMyWCKvmED4iVG+6KG AERiLPKMJJ6V3udWT/hDTXRnPxam3y9Z99C8Hhjq0u4blIErcJnhkeiFy/6M3OAyZFqLYKcE x3J66isq7TnxjzwU/4q0FSfjZNBEdc57vtF1lQoxURDk/yebEf//GWeWVY2mq7NgZyJvmmVz J3lhBSw+aaPpaQzSctB5aMKWSBlUYeo3qMUtM6lrCc49zmPrc1FIwvVqA0NQijLW01pS9a7E N4LCMUTE7WET3jzY+/ioYPOe3Zf95gxCGxIcBVrnrbnV6Gpd4mQ0YaWzLGa7/UvS8eAx5vwn Fh+a4Wh7SN3Ry1L3Ekveg+OFpQLFiMDKl+FwSDboVMkrXNcAV9JF36wwCyulUWQC7H5k8Sjm vuIWmxdevQClRQgHxez53n6Uh5bGmbYkJ2ZE1rqIEVLxW1hl9DlcuwIoaj2WqYbVUPhtsQNz zIehM+CAJjzdLf7m/epB+yUVEdgrk+NO3UC7ouN4zJ0nS2MYuSiOUtBPlP5qtoM9jor84GWe +SYBWuMTv9Eu8lsjbl/0oNCW1Rkj0JgPno0Brq4CyEx3Y5G+PVO0kjaLcBId2QhlKUDsqg4d Fct5YSsuSxOGmqNYLD5qHTcjJZKhTc5USxVPolrJhIvaQ08Jt/dqOrJgfg5TVi5lEZKsyxqW Y1BIJcy5rFMpV0f8MTdzlCl2BZ3+inHQ8OiEjOHuQ6fVsRlHfVMNOC3qrQpdMUczm8jTq1HW PazjZU8PjEVRaSzLI2C6o/JmJNdUg3gU4Sit+qRsn1CA+wcftE80f/GnihcKVFQKztI8Rckj 9Kp/WJlfSQbSz2xUT5uiZ6OLtH9yKCTdmpCAyBXc5O/NrSAyXBvoKapOqyhizwUz21dgAxgp BEb1UZaoB7sQYZ5bdHmhSae+jQuUIqk1xX/DFhmBrM4+GdkRnmNHADFxbYjJVQVSRUKV6Sg6 3+gLCl6Eg= X-IronPort-AV: E=Sophos;i="5.81,261,1610427600"; d="scan'208";a="41116999" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XOmqEcKnSNYJhZenmWo4p8+gF6c4dAEYSsFgrB8OLD0GiBz/GVY0ewm39FtMJMYDbElYLeKzsspEuPDZLFHozHQAYt4OMzYpO/rFMejFMMSTSsm3buJIFfViyV2rf95Rvueb4cgOQG8gpgWv0m+tgzp5VafRsggybC268NiVb4RdB2ERPYJTgzP3I3aO1VvEVxclvU/SqEggvn8FmsfM4D/wQvw4c6kN+AT4XVyen0xnLCFrMnp0qKtKUzytfYJlJoBTtzwrtTw5I9CKxiiG4s32rwpGG5dD3QnynFoaiFcTCYUK2zB4LnAe5K02dX2PKk8L++jzgq0vTjadOjO39w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IfG1W2Ad7ubJ7si/eLmP7oml4UMH9F+7v2uWsAC/LRw=; b=OT7LvHnpnsNwDfDTsNHFiPwceeFsKUOB5G/C6YFIfMZ6y0Q790gqR7o7XujYFRMm3xr0eIhJ87MfNcqbUxrwmGVxMVCSR0tzqW1VQAhTWJmmGerOBDUCOdsKp5w1716SJzfkrC+WLhiV3iLV4RsrOQgeqKvgxLO4K9QpuMsrwBOOZgtXoF3vcgCP5UaJvC2NzMkgI2uwuhbQBaXIt1hhCXC3tgkEyMpqN72BGBc8km7GWwN8g/Nv+al6/rSwST/FRG58968EW/kxDMgZU85jhoDhHhEwR7XNRITTjc3h6SwDehJk3TeoLwc9WDjx96tsvAM4B0PKO3QL1WGlRQnJ9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IfG1W2Ad7ubJ7si/eLmP7oml4UMH9F+7v2uWsAC/LRw=; b=dDUtnBxrj2lZp4re+4DAXp+KcZ9PPl1i5AuebqUUeGSJYigwzmAtTlxgtQQR4CdvLYo+6HDME9FhDn/YxVCfK4AaS0lW3i6gBpUHJxX7/ceeNZEOAm/6ZbsMkLaQn1tucP2o3wWzJelnQQb1Jd7Djt5bZesFD1ln6GkJ0S0Walg= Subject: Re: [PATCH 3/3] x86/msr: Fix Solaris and turbostat following XSA-351 To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Xen-devel , Jan Beulich , Wei Liu , Boris Ostrovsky , Ian Jackson References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-4-andrew.cooper3@citrix.com> From: Andrew Cooper Message-ID: <210d1177-9f7c-e3d5-eac4-be66619f1cf8@citrix.com> Date: Fri, 19 Mar 2021 13:23:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LNXP265CA0032.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::20) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31e8f827-0a39-43fc-c35f-08d8eada22a0 X-MS-TrafficTypeDiagnostic: BN9PR03MB6187: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aQW4UO0RDKj9JBStXeg6TbR6OW5NgGZlNeM6XrZwuLcoUNX/lAB2U+oyxEVVMtKhNxCNDKXbPs/e7obASKpwToqole5p261kHXCrS9O04sdlk1Vg2eDRTACT/JXJrq9hQAoc2WiuJRN92Bp4Kd6qF/OD2GyAC4/S+TowhhCvValIgraQtZ3qcnrvubHCkGTTNHeoUuxHI1AmsypT4p5sewQJKayr9sR9Mk9k1JmPDUMMaCSCKWqQ19OyrJHCM0ooNHvGdo2pf5mgeJvu3mqla/K/3K2X6Zw70Hj+Ylg7kwovlXVJZ7ld1yjY6jAqHEIZIDTbV9dRvKI2I/6oTu1QeKwUiQANrvRHCkurAeP/in5e8cd0myvkaMmZoKsF7is8BJYBBjggqQfcf7rLNMhsoGmbH7EY19A7JmHetaVSfvs2s3q4mt9iW0BHyOrCA69qdRP5pm9r7sO8wsAPo2LQx9OpnNMXJZZkRWMT2ncVKjgejO7nIMl3pDIXHC7K4aibrecerfNGNEqY4Q2CmOaNoFwJmq/G02Il9aVQ6YvUXFSKUeXT5JxY5v93jc5pJUW4r2ylclI3T1H+LO1b5sGZh//DiRcXMO4sKdx35OpQT3/2CAaeQdsZwV3LBTFXCEQDadamea3mFSbuOBamLiKJeD8j1ytJZlcke0Vuy3qAK3iGXblPe9+mJVUmROwTJ/rnuyhB3Ox/0DUlL8ooXNs+Ku1zB689mcoJUGah7M7gZDAmS0fB1ls5AuQ2dFW+Ad7giM58npTexsawvSGJyELDICiLV/62pU+5UCncIopes4U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(396003)(39860400002)(346002)(136003)(6636002)(8936002)(8676002)(6862004)(6666004)(6486002)(66946007)(66476007)(966005)(66556008)(478600001)(36756003)(5660300002)(86362001)(31696002)(31686004)(4326008)(316002)(2906002)(2616005)(956004)(38100700001)(26005)(53546011)(83380400001)(54906003)(16576012)(16526019)(186003)(37006003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Y2ZOdzlVZExUVUkxUlVDeUhGYXo3d245ZW16WW1QMzZuSEYwN3FoYmprYTVI?= =?utf-8?B?Z2o0TWw1bmxyMGwrbmVNR3hRTUZRNlpVdmJOUWRLVlBqNm9YMDB1SHFmMXVu?= =?utf-8?B?ZEg1YmlzR0NWSFUxMzZYb0I5RVBFc0JpSm5wQWErQ0lrOE1OWlU4dDVnWGZL?= =?utf-8?B?eHVvRExSTjFucVk3cmo1M1ZhN01XWU44S3hYRWl6b0poOWtObkdONVRmd1ZN?= =?utf-8?B?WWNjRlBqbEQ0N0IrUjlJY2VjZDEzTlpwaDd0RU9UbUhLRm80NVF1WGFUcmpU?= =?utf-8?B?QXlKYTMrcVkrN1NoSG53eEF2TE5YWHd0L2xaUjNTS1ZiWnZOVVdDQzBGUUUz?= =?utf-8?B?anNhMlVrQVZaejZHOWcxU1o4YUV2L2ZWWHNBQllvRFl4dnQ5amJJd1ZiUElw?= =?utf-8?B?WFZ4dklBZGgzT0tZVGZpRTMyeUF6MWs4bmNxK1g5ZmVXbDJZbHZNZjdSODFp?= =?utf-8?B?MEtWY1FaZjN2MEMwNWZuY0pTOFh2QjVnQ05pYjdDYktrVENyUWZXY1JnS0Fh?= =?utf-8?B?RU1PUFFPajB0cHBOLytReVR2cUVBWTg0bGtTTnVibnJxSHE0RUhSY2FzRzVi?= =?utf-8?B?cHIzMlNSWUdlQk1iaWlyVWpOODl1L3ltQXoza1kwOUw1WTloSHZQZHExM3l1?= =?utf-8?B?NmZ2V1luc1VjekRJOSs0Q0dEM2hmL2Y4TDZDWTd2QUwzRTJzZmYyWWFORjRs?= =?utf-8?B?eDY4V1ZkamJsUm5LM0owd01tdHFNRXBlUGtxVUN1VTlMNVRHYy9adTdzUDMw?= =?utf-8?B?b3lNUUlwbERDYlN5Ym9icWZXeEpoQ1hJWEZwL0ZFcUN0Q1BiVVNYRnRMM1NO?= =?utf-8?B?ZU1DSkk4SThIY3A4M0JJUlprbGU5Q2JyWUFEdXBjNzlEVW9HYmQ1WU9zRnZl?= =?utf-8?B?dDcxczhXMEJmNTVLeG9aajBUNmJNb1MvOVcwYnRiV2xmTFY4MnAvUTI5ZzZz?= =?utf-8?B?VEc2TnhQRkxxR1hlOG9XSm4rcTBlMTNOSVphMXRFWFlXZkhEL3VnamNrR2xk?= =?utf-8?B?YURwNTlmWCtScEZaaXlUMEJjdWhGTW9tSExPR25ZV1d3eWpXMHdFdHB5RGVk?= =?utf-8?B?TyttTldWanpSQnRnZHc2NDQ1d2k5S1ppTXd3K3FUUHg4eXdoeVhCRnU3UG1W?= =?utf-8?B?cWFqVXZ3MFc1K3dwTmw0ZGg3anNERERsekYrQ2dzVmY4Y2ZKVE1RNTY0bm1P?= =?utf-8?B?RmdtYzhWS01neU5lajEvaDhCR3hxWldpc1Zxd3lWb1pYem1hcGRkM3N3Nk10?= =?utf-8?B?RmI2aEtMYnQxeHZFc1JQRWIvVlFiaXY1eXU0bG1CNlpvVENQUXdZbVpOYUE2?= =?utf-8?B?ZTF2bURZSUY5eHBGZUxidnBrSmxnQnEvcm1mNjZWK0FRYUJYRDdGdDNhZmZD?= =?utf-8?B?ZzlCNXBud253MjN3blo4Znk1RW0vNjN6N0RESkRSdTN3STlZY2pzV09LM0FF?= =?utf-8?B?Qy9GOVgvY0MzTktYaWpvaTg1bUlXU0U0cTZnN29PcUozNEQ5NWJocHk4TGRF?= =?utf-8?B?UDQwdWlsN0FKVldWbmo5ZTFhRlJTbEdKOTMyb1B2eUZ5M3d2RTlmQjlaaVcv?= =?utf-8?B?Zm1Wdk9ZaklvMjgrRnAza1kxaUtjU0Y2L0J5SU9WcjJqblo2dUttQjVTQWNE?= =?utf-8?B?WU8rOXh0d2czZExrMXFQeHcxaC9ORWNTMUVVTDV6RjVSeW5YSzdoaW1CZjZV?= =?utf-8?B?cnJ0Qk1hSCs0L2cwRjRvRXRqNVJSdWUvRDBGMlNhUWJLVHcrRC9TUFZ6ZWRx?= =?utf-8?Q?fwX8VlFAsJ/VVvuyMb+Q2/mWSxJ9OXHF2NuzIry?= X-MS-Exchange-CrossTenant-Network-Message-Id: 31e8f827-0a39-43fc-c35f-08d8eada22a0 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 13:23:07.9615 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2BIJe3jIwEhh3bDbbeHow+MCiAL6+t9ojil5SJ9Zdd6V8nNXZNx0NUQFOXChOvWMJ8jTsg5cDMAAfX0ADPnCTJfK29liXk7xI/3oH/o3ICE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6187 X-OriginatorOrg: citrix.com On 17/03/2021 08:32, Roger Pau Monné wrote: > On Tue, Mar 16, 2021 at 09:20:10PM +0000, Andrew Cooper wrote: >> On 16/03/2021 16:56, Roger Pau Monné wrote: >>> On Tue, Mar 16, 2021 at 04:18:44PM +0000, Andrew Cooper wrote: >>>> Signed-off-by: Andrew Cooper >>> Thanks! >>> >>>> --- >>>> CC: Jan Beulich >>>> CC: Roger Pau Monné >>>> CC: Wei Liu >>>> CC: Boris Ostrovsky >>>> CC: Ian Jackson >>>> >>>> For 4.15 This wants backporting to all security trees, as it is a fix to a >>>> regression introduced in XSA-351. >>>> >>>> Also it means that users don't need msr_relaxed=1 to unbreak Solaris guests, >>>> which is a strict useability improvement. >>>> --- >>>> xen/arch/x86/msr.c | 13 ++++++++++++- >>>> 1 file changed, 12 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c >>>> index 5927b6811b..a83a1d7fba 100644 >>>> --- a/xen/arch/x86/msr.c >>>> +++ b/xen/arch/x86/msr.c >>>> @@ -188,7 +188,6 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) >>>> case MSR_TSX_CTRL: >>>> case MSR_MCU_OPT_CTRL: >>>> case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): >>>> - case MSR_RAPL_POWER_UNIT: >>>> case MSR_PKG_POWER_LIMIT ... MSR_PKG_POWER_INFO: >>>> case MSR_DRAM_POWER_LIMIT ... MSR_DRAM_POWER_INFO: >>>> case MSR_PP0_POWER_LIMIT ... MSR_PP0_POLICY: >>>> @@ -284,6 +283,18 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) >>>> goto gp_fault; >>>> break; >>>> >>>> + case MSR_RAPL_POWER_UNIT: >>>> + /* >>>> + * This MSR is non-architectural. However, some versions of Solaris >>>> + * blindly reads it without a #GP guard, and some versions of >>>> + * turbostat crash after expecting a read of /proc/cpu/0/msr not to >>>> + * fail. Read as zero on Intel hardware. >>>> + */ >>>> + if ( !(cp->x86_vendor & X86_VENDOR_INTEL) ) >>>> + goto gp_fault; >>> AFAICT from Linux usage this is Intel specific (not present in any of >>> the clones). >> Indeed. >> >>>> + *val = 0; >>>> + break; >>> Do we also need to care about MSR_AMD_RAPL_POWER_UNIT (0xc0010299) for >>> Solaris? >> AMD has a CPUID bit for this interface, 0x80000007.EDX[14]. > Right, I see now on the manual. I guess I was confused because I don't > seem to see Linux checking this CPUID bit in: > > https://elixir.bootlin.com/linux/latest/source/arch/x86/events/rapl.c#L773 > > And instead it seems to attach the RAPL driver based on CPU model > information. That's fine on Linux because accesses are using the _safe > variants. Borislav also wants a bugfix for that, seeing as there is a CPUID bit. > > The patch looks good to me, I wonder whether you should move the > "users don't need msr_relaxed=1..." to the commit log, but that might > be weird if the patch is backported, because it won't make sense for > any older Xen version. Will do. > Reviewed-by: Roger Pau Monné Thanks. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 19 13:37:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 13:37:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99257.188617 (Exim 4.92) (envelope-from ) id 1lNFIg-0000MN-2p; Fri, 19 Mar 2021 13:36:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99257.188617; Fri, 19 Mar 2021 13:36:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFIf-0000MG-WB; Fri, 19 Mar 2021 13:36:25 +0000 Received: by outflank-mailman (input) for mailman id 99257; Fri, 19 Mar 2021 13:36:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFIe-0000M8-OG for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:36:24 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fac01dab-476d-4c3e-b730-20c5ed49577e; Fri, 19 Mar 2021 13:36:23 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CF610AC17; Fri, 19 Mar 2021 13:36:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fac01dab-476d-4c3e-b730-20c5ed49577e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616160982; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kQLG9AatNAgHgO+1lP39jZTeoNoMecd0012Bi/J59j8=; b=tZvzLXgfVZ4XhUDGLhK0GxRQ8t2Zwl/snXDZUkVTwgQuxlhGaBEbj4izsbRamuFXLrViRV gjj5vaRy83jzLXPE+omC4jDW+w3hjXQOdpG6XoD2L54xnfkgxQL+SvCDRmBBZHFk2Mhtjm 2bXdv8PKExJVaDig3L9ZR2PH2Tv7d2A= Subject: Re: Ryzen 4000 (Mobile) Softlocks/Micro-stutters To: Dylanger Daly Cc: Andrew Cooper , Dario Faggioli , "xen-devel@lists.xenproject.org" References: <9lQU_gCfRzGyyNb2j86pxTMi1IET1Iq7iK3994agUZPrTI5Xd-aCJAaRYuJlD3L5LT2WaV4N3-YF4xKl5ukialT0M_YD0ve6gmDFFfatpXw=@protonmail.com> <815f3bc3a28a165e8fa41c6954a6d00db656e3c3.camel@suse.com> <1fc0e850-8a08-760f-c8cb-ad73dda4a37b@suse.com> <4916dec1-1bb9-7e6f-2fe5-577bbab92861@suse.com> From: Jan Beulich Message-ID: <0e963858-6834-96de-4bf2-956f905160b4@suse.com> Date: Fri, 19 Mar 2021 14:36:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 19.03.2021 13:45, Dylanger Daly wrote: > Hi Everyone, I've just confirmed only `tsc=unstable` is required, > that specific change has fixed the issues I was having on the > Lenovo X13, I assume this is because Lenovo's Clock isn't correct? Hard to tell without knowing what actually went wrong. It wasn't very long ago that we had to fix an issue where iirc a machine wouldn't even boot because of some strange state firmware put the TSCs in. We were able to work around this, such that "tsc=unstable" wouldn't be needed. So while there may indeed be some oddity with what firmware does, there may also be a way to work around this. But I guess it would take someone debugging this on an affected system... Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 19 13:40:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 13:40:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99262.188630 (Exim 4.92) (envelope-from ) id 1lNFMD-0001BU-Kd; Fri, 19 Mar 2021 13:40:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99262.188630; Fri, 19 Mar 2021 13:40:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFMD-0001Aw-GI; Fri, 19 Mar 2021 13:40:05 +0000 Received: by outflank-mailman (input) for mailman id 99262; Fri, 19 Mar 2021 13:40:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFMC-00013O-RW for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:40:04 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5245e5bc-c1ae-4d23-b78c-b210bb4769ea; Fri, 19 Mar 2021 13:40:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5245e5bc-c1ae-4d23-b78c-b210bb4769ea DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616161204; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=3KM7opIg/JZK6NQVGXPTmJgelggvLHIq7CdfMY+3gVs=; b=BQj3FRK7ctAVLyhBBL37l2tvPZmvirvm/xNtV5nMGu/e5JmgBV06hYnQ XZXbgM6aVeDVOdfspb9pVI+ztyw3C5Py+qGUJXTMqt05UThgQoWFGeVXg NY1TFiXCwaLq77JANcpqIASCLxl3+hoDLADkxTqvPL+iG9EoASgYNiYzl M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: pDubzEnuIDpdr7Vuo75E+RwsYHdJuSBtjY4xSBAem00FUBL6ZwJx6wKdnvCXJgdZyUC653QUVS +Yt/JAoGL1JVb/76vKmzdH96mfl3wX2/5Rhw6Pi9nqZ9N7owvqRNdbjCND455DOPtMJW1I/sCc rxFRrgZsr7MIU0wBn9cOXgdLjlBaxePaH4QTEbV+fp30aytJUqXeu8DrWXGHvYGIhtFv0H9ZLg BAR0ksfEQK8jWaFYBrSbYqsLK0CaXhuKlBrSBIZS/RR5YHYM4Bu8PE87MmCNJSMRcJmpcjdI0h 9Hs= X-SBRS: 5.2 X-MesageID: 40051532 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:nhQ3q6Af+soTC4XlHegBtMeALOonbusQ8zAX/mhLY1h8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPufVr1zrQwxYUKJ7+tUE3duGWuJJx/9oeK+VHdMgXE3Kpm2a 9kGpISNPTZEUV6gcHm4AOxDtYnx529/Lq1gPrFpk0NcShBQchbnmJEIyycFVB7QxQDIJI/Go aV6MYvnUveRV08aMOnCn4ZG9XZr9rQm578JTIADRgr6A6B5AnYlILSOR6ewxsYTndz0a4vmF K17jDRy4eCl7WAyhHa33LO9Jg+orXc4/ZKGcDksLlsFhzCkQCtDb4RPIGqnDdwm+237UZvrd +kmWZbA+1Wy1f8Ol64ugHs3Q6I6kdc11bHxUWDiXXu5ezVLQhKcvZpvo5SfhvH50dIhrgVu8 gqrgHpwqZ/Nh/OkD/w4NLFTXhR5y6JiEEvjPIJiDhnWZYeAYUh3bA3xl9fE5sLAUvBmeYaOd RpZfushsp+TUmXdDTwsGVp3bWXLw8ONybDaE0DtsuJ6iNRjXB0wmAJrfZv70soxdYTTYJJ6P /DNbktvLZSTtUOZaY4P+sZR9CrY1a9Di7kASa3GxDKBasHM3XCp9re56g03vijfNgtwIEpkJ rMfVtEvQcJCgzTIPzL+KcO3gHGQW27Uzio4NpZ/YJFtrr1Q6euGTGfSXg1+vHQ4Mk3M4n+Yb KeKZhWC/jsIS/FAoBSxTDzXJFUND03TNAVgNAmQFiDy/i7arHCh6j+SrL+NbDtGTErVifUGX 0YRgX+I81G8wSFQXn9rB/NW278W0D28J5qeZKqutQ7+cwoDMlhowIVgVO26oWgMjtZqJE7e0 N4PffGn8qA1C2L1FeNy18sFgtWD05T7rmleWhNvxU2P0T9dqtGn92efGtVzUaWPxMXdbKQLC dv43BMvY6nJZ2Zwi4vT/i9NHiBsncVrHWWC7ARh7OE/sWgXp8jFJ4pVOhQGGzwZl1IsDcvjF 0GRB4PR0fZGD+ro76iloYoCObWcMQ5phyqL85SoXf2rl6duskre3seU1eVIIyqqDdrYwARqk x68qcZjrbFsy2oM3EDjOMxN0AJVH6aG4tcDAOOZJxdn5fifA0YdxbNuRWqzzUIPkb6/UQbgW LsaQmZY+vCDFZmtndE6ary619vemKBf0V/V2BiveRGZBb7k0c29dXOSru40mOXZFdH+O0bPT 3fSRY5Iw9lxbmMpVSosQfHMU9j6oQlP+TbArhmTqra3Wm1LpaU0YscGeVPwZpjPNfyk+MCXO 6FYTWJJDfgB+5B4X3Nml8VfA1P7FU0m/Lh3xPoqFWi1HkkGPzIPRBIQaoYL9z01Rmse9+4lL FCyfQ7suu7Pj+vNpqoyaTLYyVCLR2Wi2isVO0soY1Vu6V3lLYbJeitbRL4kFV8mDM5J4PIsW lbZoJRyrXIIJVucMwfYDgxxCtjqP2/aG8Q9jXrCeo/d2w3h3DVP9m186PFwIBfdnGplU/VAx 2j6CVT8PfOYjub2ZMbA6w2J35KaEJU0gUVwMqyM6nRAh6tbedN4R6TNWK8aqZUTMG+aPgthy c/x9GDhOmMcSXknCjWoDtgO6pLt0KqW9m7Dg7JOelG9bWBSBixq5rvxM64lzHsTzSnL2wemI 1ebEQVKv15tQNKtvx+7gGCDortokwklFNC4TZo0n7Vs7LWnlvzLAVhKg3WgpJfQD9JFGOH5P 61qdSl6A== X-IronPort-AV: E=Sophos;i="5.81,261,1610427600"; d="scan'208";a="40051532" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DM/yIvzTognaK2xg9AGLsMFh9HSkkW7lQPh1AqfsFMamfWAfuJGFKFVit6iDyxhmYfCZhVj2IJzypATKpHwDYizS2niIP93X/xDAS7a0kXnBYf/95kplAH8ERc2bghg2+nmyW/n0qL3CQ4dp1nkqFXwwBs2crgMBNNpa9rSDg5tGS1zdHz0g1akdRxNdz9WO4N3yDoKTQij716K139QURZFgac/OfXhzJx157hlyAGW592b3yAWip82pJ4WxjB2zc3mpNUTS1vKPz+8pGutX6oRNgDbqSuXfKEn25mzxCR764yCgt+dBvj+DbtenGDV3F8Jl8CHE8geiFeXjaN9OLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=maS8I8IUEiTkrWdnnaaj1tEbuiithGPZlMk+bf3CO3Y=; b=WhbCShzoCR3cweTTDYVJjtwAciX+bWcciiRM5rpolmQvHKNJei/kDp6yi7j33nlPCKx/N8fA7P8DWUeD2TdmnuZWU2duPlETkxaf9n1t3QhTgjuv6piRUnv+XJ/hWEYzGM6KJSlRK0g9BBxpB9s+CdXSBjj+7wHYXCMCfVbpeltX8Dl4b5d5RL3reCOSNf9ttTChxcdb/DLfvGgb0irdlTwqOpc2P96YgDOSZPA95uq3Mtm4+BmHPH9iKfbBmTs9lf7juqEOniGBKjjUDK44CrteT1nMv+HyT9u2FPeoqQCRCraSdVU+Nkyd5iwobzlpi5JmUH+d/JIcYrIVpqDSBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=maS8I8IUEiTkrWdnnaaj1tEbuiithGPZlMk+bf3CO3Y=; b=G3Vt74ix4s3rdzJZTUd65+dI6hx+OlV0d2CH0Uf78/w0wATwIEDHWEEGuRDTfFKc8zgohI/zAuQsB3r0RB5eYBwroe6ou6Rc6YGYVLTURrb677MIMd5yyxp1FrwRKdMfkx7jCWyEAME8hRkYy37CM0YsRp3AVPe/1Gpm9A9HJv8= To: Ian Jackson CC: Julien Grall , Jan Beulich , "xen-devel@lists.xenproject.org" , Stefano Stabellini , George Dunlap , Wei Liu , Anthony Perard References: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> <24658.6228.390535.850901@mariner.uk.xensource.com> <24660.42333.417431.528632@mariner.uk.xensource.com> From: Andrew Cooper Subject: Re: Call for tools backports (was Re: preparations for 4.13.3) Message-ID: Date: Fri, 19 Mar 2021 13:39:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <24660.42333.417431.528632@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0369.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::14) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4ed4b69c-b97e-4f6d-ed3d-08d8eadc700f X-MS-TrafficTypeDiagnostic: BN8PR03MB4948: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1X58uSa2H4WXiEpla4lLz/CgbsDx9rqBU0o1OY1LlgLMACkwnEjb5viiZtqOgVKDuM211K/WYN1WPamNyzWz3Wy/UTg+tRKzU0UqRfFczYO1UghjNo4uXLyAU2nF3DE6vqK8ccNzweM+0t8dXjEGFBXtRbBdFeUhPXyHKjqprHzBS5kQC4+K6g4eIg2UHTQLo3Qr3BHzgkY2zBk6/R2PnXq78EF1/p/E3WnOHbgOe+CMD3pKHBXo2H9Ufs8dkC/z+SCDGi5m30CdGul9H0FbekH07I14xOXS3N48ui4MeVgGTciPyIivXCKeEeZrPOqU2Ut1I3c2lUSPaqRsct61R7FNyo76n+GP+MtmDG/IlZ+urOpHgC6YAYuPmHwn4olH07G8X8tPLQa5iQaaQhH48tBQIO2zAO6i2Ndx6I7+haRcUifCYVxFWyC8Sj6vEokBZOqK7YHxgbrfyhZluXkPsFSUiOkyllhz+6k7xd2mTDWAKYUZppRSGHKsVS77uTZlcvTyq7CF7ZDMdFGaw2FAFl+A676RHuM5xooHPEKr4x+0zECIqAuAICwjIQv2CQCIdsK0597kVy8L0VDYVQ+Ud/LmRPiUiPVR2OXpXRXG0CiZbfd0kb2W5NR1LktrNMscstWt8PG4PRtMp/pzmDF/1gAp44d90WfVNwT4J7TTumngOFY1x1IsgZjWGAPYHdHebXfObx6yfrRaEeBNuXhghc006xYU+s1DYGnQARazdtY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(396003)(136003)(366004)(346002)(2616005)(6916009)(2906002)(86362001)(53546011)(66476007)(186003)(31696002)(26005)(956004)(6486002)(54906003)(66946007)(66556008)(31686004)(83380400001)(5660300002)(4326008)(107886003)(36756003)(316002)(8676002)(8936002)(478600001)(16526019)(6666004)(16576012)(4744005)(38100700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZStoMnNBcGFTNlpNUlV4VjVweTFSQWdWVzBsSVpTVnBpbnA4N3JQNWJUeFZ4?= =?utf-8?B?cmllaFdnL0Z2bDh6WUgxOHd1bG91SnpqY29ON2wvL1cyWTh0Y2R0UnJSSC9p?= =?utf-8?B?ODJkT3FXSHNydWJ1ekFyMVMwWDZWQTl5ZnkvbkZJZlFqM3Nmd2FaWnVyYS9z?= =?utf-8?B?bTVxZGxTWGdzUUFVbVBZbzRzd2pWdWszbndRd3Z5R1BVdnhuQnY4M3d5MXJS?= =?utf-8?B?ZThkS3ZsendRTlM1em5rL0V2QkI5WjlYUEJsak8xbE5NT2ZsTHRCdVZ0cnRH?= =?utf-8?B?T3RNMmdUYXBYd2c2dzViUU9HcnhnV2Z1MW1NZzg3N3hRTlg5c2cxK2FjQldm?= =?utf-8?B?VFpkbDNFZDYvWFd5cGdySTlZTDIyUlp5Si8yT2NiT2ZBem9YcUt5akdzcFQ5?= =?utf-8?B?QmFDd1hOSm9DNkp3OStOWDh4bmFJZHk4UVh2c0RoZWdyOTVQSUlMaHdSVHkv?= =?utf-8?B?MEN6VEE4M3JaMitsV3cxSGtEeU1xeStqVVU1aHdMWk5USEJqc0VGYUlVcHFD?= =?utf-8?B?bmRFNVZhOCtyajI3SXZIRU9EazJDZHBiL29aME15cmVHZ3Y4VEZHOFdYUGpJ?= =?utf-8?B?V0RYRGFkMFNYc25GVUFtWm5ZSnJzdnlOeWQ0TitTVE1NWU1HUVUvUTlnYThv?= =?utf-8?B?Ry93SHlyT0hBSVYwTmRyMEpHRCtPUFdqams4WWJMOUVvTFBzUW1WdndIZm56?= =?utf-8?B?dlZyeEdsZjdtR0NpN0FMc3JnWUV6VmVpemc0NWtCVzZPeWxCaW1NMGtIcWZi?= =?utf-8?B?a2dQaVNIekVKdWlab3BORFcyK3EyanZlTXBrWUtnblY5MDBKSEpISzQvbyt2?= =?utf-8?B?TGpabzFHT2JZZUFtdmphdHZLak1VbFpLVkhkczJjbW85UldmbkZwVElIZC9l?= =?utf-8?B?anRnYlFOR0pzMnZCZ2pWdW4zcjhwRW1Fb25OZFRiT1IrSkFzaWRXaE1NK0Jr?= =?utf-8?B?Wms3VktCd3l3ZHo3WXhOak13QTkyNThYUDFHbTQ3dDV3aGlRRmRkeFhaNDJC?= =?utf-8?B?a05sdmpKeHhOdm1NbkFyZXdwV1dXNkxLL0dBZ0ZRcEYybGhpUnpvVERadXdV?= =?utf-8?B?RWdsenQzYlVJZ1V2ZXZHcVcwY1p4TnZ1YzhNZlYxLytpdlhtS2x4L3RtV2ww?= =?utf-8?B?bFE4azExVW1DdWtqdHJoNjljbm54V3JLSkpUQ0JXTnhMeDZsWlhobUIzaVQ1?= =?utf-8?B?T280T2ZXaEs4c0pRdlZBenBsMnJSOHBIQ0FmSXYrY3BvYW5MQnFROC9jSE5y?= =?utf-8?B?WFUzdGpkNzdXSkRlY3lhS2xKTm5vcEo5c0Qyc2ZKdFd6cWZYVVZhR2FvRFNF?= =?utf-8?B?Y2lYd2N2T1Q0Zkxxck40MmFiQnlnQ2x0N0U4ZjVvcmpBY0YxOE9vSUtTSU1h?= =?utf-8?B?YW1JaURZeE52R1UxUit2SmZKZGlteE1zalpRbGJ2YlZZc25XNFhFYlQ3Y3o5?= =?utf-8?B?N2VhRkdSRmhiWDRhQ3hzVk5ZUEVEclRjL295aUhvSThoYzRoeFpmQ2FZRWc4?= =?utf-8?B?bGlSSDdkUkpocGZpeWRORWdlMHprZmNVRTRDL3daa2tkWk9QaEdjWDZUb2hC?= =?utf-8?B?b2s0b0dMV3NHTWpQWlNrNk5FcTV2cmZSN29rbDZHN3pWWGl0Qzhocm54ZVlz?= =?utf-8?B?OUV0NzNoblJEeFJsRVMrMlVmNVZxcDlrU1dzc2FVL3RtVlNrc1RyeFh4VFJp?= =?utf-8?B?dVJmUE1YK0JxRkJlcGFxRk5iU3NGejlRaTVtd3hTUHpzb1dTWncxdjRTUDFX?= =?utf-8?Q?h2N62NbbcTwLAZ0Pvv3DblLlSebnmK+RGSjLzJC?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4ed4b69c-b97e-4f6d-ed3d-08d8eadc700f X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 13:39:37.1179 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u1jl39/rKQAUptd/QOdeODqAMQ5SqazhPNKeVvJsZcMhRpa+LoM480KP29zLPwgo0roAWdPcT3efdLYsgIeTYCsXTcGJFu1zOJDJ2XD5CME= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4948 X-OriginatorOrg: citrix.com On 19/03/2021 13:21, Ian Jackson wrote: >> a6ed77f1e033 - oxenstored: fix ABI breakage introduced in Xen 4.9.0 >> >> The final one is an ABI change, but fixing a regression. > I'm not sure about this but I think the effect can only be on > "Reset_watches" ? I guess I will take it. The effects of the bug were twofold: =C2=A0* A client actually requesting Reset_watches has the request rejected =C2=A0* A client actually requesting Restrict got Reset_watches instead We spotted the bug when trying to add soft-reset support to Xapi, where a Reset_watches request got a hard error and the guest choked. >> Do we want to backport the -Og fixes so we can get ABI checking working? > As Jan says, I think these are still in a state of flux ? The ABI checking side, yes, but the -Og is a prerequisite which is fairly self contained. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 19 13:48:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 13:48:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99269.188642 (Exim 4.92) (envelope-from ) id 1lNFUb-0001hp-Ko; Fri, 19 Mar 2021 13:48:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99269.188642; Fri, 19 Mar 2021 13:48:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFUb-0001hi-GA; Fri, 19 Mar 2021 13:48:45 +0000 Received: by outflank-mailman (input) for mailman id 99269; Fri, 19 Mar 2021 13:48:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFUZ-0001hd-PZ for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:48:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFUZ-0004Hj-N8 for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:48:43 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lNFUZ-00015B-MB for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:48:43 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lNFUT-0008FZ-8H; Fri, 19 Mar 2021 13:48:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:To:Date: Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=ZmFMA9Nxjl+/tOWcMNDm7X+CTkHhLSqQuSouR4BKC80=; b=cCJzX2wjRvDYDeXEBAedQyusgn 8/A4YsGfkK9jszvOr4XvQ+RcerDZ70LvPqSDZ83xEKU8hnG8wYFoIY3Cjy8zCp1Y8TigwjGrH7zrZ wictq/ZRiUo0PPCklSswtQIDq7MyRZUEXfG7kt1pLZYkU85Ru4/+wCBy5Uhop7koIboY=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24660.43957.65406.857669@mariner.uk.xensource.com> Date: Fri, 19 Mar 2021 13:48:37 +0000 To: Andrew Cooper , Julien Grall , Jan Beulich , "xen-devel\@lists.xenproject.org" , Stefano Stabellini , George Dunlap , Wei Liu , Anthony Perard Subject: Re: Call for tools backports (was Re: preparations for 4.13.3) In-Reply-To: <24660.42333.417431.528632@mariner.uk.xensource.com> References: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> <24658.6228.390535.850901@mariner.uk.xensource.com> <24660.42333.417431.528632@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Ian Jackson writes ("Re: Call for tools backports (was Re: preparations for 4.13.3)"): > Andrew Cooper writes ("Re: Call for tools backports (was Re: preparations for 4.13.3)"): > > These are general backport requests, not specifically for 4.13 > > Thanks! I have now applied these, I think each to the appropriate trees. I went back to 4.11, which is still security-supported, because several of the oxenstored changes seemed to have some kind of possible security implications even if they weren't XSA-worthy. It seemed better to backport the whole lot for 4.11 and 4.12 than to try to pick apart which, if any, were security-relevant. So, thanks for the information. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 19 13:50:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 13:50:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99272.188654 (Exim 4.92) (envelope-from ) id 1lNFVy-0002V1-UX; Fri, 19 Mar 2021 13:50:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99272.188654; Fri, 19 Mar 2021 13:50:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFVy-0002Uu-RY; Fri, 19 Mar 2021 13:50:10 +0000 Received: by outflank-mailman (input) for mailman id 99272; Fri, 19 Mar 2021 13:50:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFVw-0002Up-UT for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:50:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFVw-0004LC-Su for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:50:08 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lNFVw-0001FM-S0 for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:50:08 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lNFVq-0008GX-JU; Fri, 19 Mar 2021 13:50:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=l09ndsQ7lTvklq3VAWZpHO+MFG0EPEtlp4PzVaYYYuU=; b=MailvVCpoEZhSnDPBEx58zz2hh Wvvoz9gq20MX7Q0e6U9Zw0stcbtNhsXlRTIm+bYW9ql6qKlZAj+qLeJpQ27NhGYba8UM+kkOe6nJ5 8IzOrog7QactHJATLRk35zYviP5Y5ItZB+KhoTIzS/DKIDvkFzpoTfNwl4yg8r90ztcI=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24660.44042.398498.293837@mariner.uk.xensource.com> Date: Fri, 19 Mar 2021 13:50:02 +0000 To: Andrew Cooper Cc: Julien Grall , Jan Beulich , "xen-devel\@lists.xenproject.org" , Stefano Stabellini , George Dunlap , Wei Liu , Anthony Perard Subject: Re: Call for tools backports (was Re: preparations for 4.13.3) In-Reply-To: References: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> <24658.6228.390535.850901@mariner.uk.xensource.com> <24660.42333.417431.528632@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("Re: Call for tools backports (was Re: preparations for 4.13.3)"): > The effects of the bug were twofold: > * A client actually requesting Reset_watches has the request rejected > * A client actually requesting Restrict got Reset_watches instead > > We spotted the bug when trying to add soft-reset support to Xapi, where > a Reset_watches request got a hard error and the guest choked. Thanks for the info. What fun. I have taken it. > >> Do we want to backport the -Og fixes so we can get ABI checking working? > > As Jan says, I think these are still in a state of flux ? > > The ABI checking side, yes, but the -Og is a prerequisite which is > fairly self contained. I think I would prefer to wait for the ABI checking as a whole to congeal before backporting even this self-contained prereq. Feel free to try to change my mind if you think this is a wrong decision. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 19 13:57:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 13:57:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99283.188698 (Exim 4.92) (envelope-from ) id 1lNFc3-0002qY-44; Fri, 19 Mar 2021 13:56:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99283.188698; Fri, 19 Mar 2021 13:56:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFc2-0002qR-Vz; Fri, 19 Mar 2021 13:56:26 +0000 Received: by outflank-mailman (input) for mailman id 99283; Fri, 19 Mar 2021 13:56:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFc2-0002qF-55 for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 13:56:26 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ce5efbd0-5202-45af-a337-089d63042537; Fri, 19 Mar 2021 13:56:25 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 80715AE05; Fri, 19 Mar 2021 13:56:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce5efbd0-5202-45af-a337-089d63042537 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616162184; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HAo5E0y/7xOSSY4s+/UThEcv+vl5mdnIlMxGgRH0bWc=; b=R5hI7HBo0+dTi0G43BQGWxOCM6ulzqUZFByTBYTWq7Z4Synq6vY3np80pVQyqyucbb+PWS 4DFZiO835gIA4ys1171is3EMfXpcltU/uc6QtG4ZEms/u7ry3de/UAeqeptCrxMVnZXJ1H h36YHCXUU1PmU7nYZq0/bYZbwGivqss= Subject: Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Boris Ostrovsky , Ian Jackson , Xen-devel References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <1c5f3162-8451-5e6c-e5b3-e5368fc0a871@suse.com> Date: Fri, 19 Mar 2021 14:56:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 19.03.2021 13:59, Andrew Cooper wrote: > On 16/03/2021 16:58, Jan Beulich wrote: >> On 16.03.2021 17:18, Andrew Cooper wrote: >>> In hindsight, this was a poor move. Some of these MSRs require probing for, >>> causing unhelpful spew into xl dmesg, as well as spew from unit tests >>> explicitly checking behaviour. >> I can indeed see your point for MSRs that require probing. But what about >> the others (which, as it seems, is the majority)? And perhaps specifically >> what about the entire WRMSR side, which won't be related to probing? I'm >> not opposed to the change, but I'd like to understand the reasoning for >> every one of the MSRs, not just a subset. >> >> Of course such ever-growing lists of case labels aren't very nice - this >> going away was one of the things I particularly liked about the original >> change. > > The logging in the default case is only useful when it is genuinely MSRs > we haven't considered. > > It is very useful at pointing bugs in guests, or bugs in Xen, but only > when the logging is not drowned out by things we know about. So would you mind adjusting the description accordingly? Right now, the way it's written, it reads (to my non-native interpretation) as entirely focusing on guests' probing needs. Even an adjustment as simple as "In hindsight, this was a poor move. Some of these MSRs require probing for, cause unhelpful spew into xl dmesg, or cause spew from unit tests explicitly checking behaviour." would already shift the focus imo. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 19 14:03:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 14:03:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99314.188821 (Exim 4.92) (envelope-from ) id 1lNFiS-0004Vr-2Y; Fri, 19 Mar 2021 14:03:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99314.188821; Fri, 19 Mar 2021 14:03:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFiR-0004Vk-Vi; Fri, 19 Mar 2021 14:03:03 +0000 Received: by outflank-mailman (input) for mailman id 99314; Fri, 19 Mar 2021 14:03:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFiQ-0004Vf-Hz for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 14:03:02 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f3c768c4-b6d7-473e-b4ce-7714ab5c9ee8; Fri, 19 Mar 2021 14:03:01 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9DE1EAC82; Fri, 19 Mar 2021 14:03:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3c768c4-b6d7-473e-b4ce-7714ab5c9ee8 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616162580; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kxRpz34eIfKrBnmxFIyqyhHx/CTSSR6OFZGUuhBmH58=; b=oSJU2wyw5db8L8FWtooshWlH7dZFHsnr0/CJc5nJ2894Wd/iPs3dvr2F4joxwl9omsIJm3 c+I028cD+kiM9+QsBZKdMO6YHBWrxw43SNy8L7IRgH0pbPalhisBJnvCvUPFliLifKr5Yl a5Z+Z81GH3kFrgzProeXJKRCi66r4S4= Subject: Re: preparations for 4.13.3 To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Ian Jackson , Wei Liu , Anthony Perard , Julien Grall , "xen-devel@lists.xenproject.org" References: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> <7b3a06af-103a-db05-b494-94f5a1081bc7@citrix.com> From: Jan Beulich Message-ID: Date: Fri, 19 Mar 2021 15:02:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <7b3a06af-103a-db05-b494-94f5a1081bc7@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 19.03.2021 12:44, Andrew Cooper wrote: > On 08/03/2021 09:49, Jan Beulich wrote: >> the release is overdue (my apologies). Please point out backports >> you find missing from the respective staging branches, but which >> you consider relevant. >> >> Ones that I have queued already, but which hadn't passed the push >> gate to master yet when doing a swipe late last week, are >> >> c6ad5a701b9a crypto: adjust rijndaelEncrypt() prototype for gcc11 >> 9318fdf757ec x86/shadow: suppress "fast fault path" optimization without reserved bits >> 60c0444fae21 x86/shadow: suppress "fast fault path" optimization when running virtualized > > fe36a173d110 - x86/amd: Initial support for Fam19h processors > 90b014a6e6ec - x86/ucode/amd: Fix microcode payload size for Fam19 > processors For the latter one, didn't you indicate to me elsewhere that there was still some uncertainty about the value? Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 19 14:03:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 14:03:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99317.188834 (Exim 4.92) (envelope-from ) id 1lNFj0-0004bS-CP; Fri, 19 Mar 2021 14:03:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99317.188834; Fri, 19 Mar 2021 14:03:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFj0-0004bL-8N; Fri, 19 Mar 2021 14:03:38 +0000 Received: by outflank-mailman (input) for mailman id 99317; Fri, 19 Mar 2021 14:03:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNFiy-0004bE-JY for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 14:03:36 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ea55a92d-d1fd-4e55-82c1-9a51faa32e26; Fri, 19 Mar 2021 14:03:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea55a92d-d1fd-4e55-82c1-9a51faa32e26 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616162615; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=7oFDwaLHzSERP4K6uSIc5Lkm6sm1sUbofwbeaG8HygE=; b=e+NjLavoZ1j7TeQ7a2FYCRlKeefbgRVMt5vdPYliRGjDA4qg7K/i6XLo y5WWLZmtkWqTJptHKP9hRcbjRSpRcI4XDeGLC3YLUhdBWI3cpcIB8oZBO BELHeChkwccIDxjEDV7lSU1Q2MYxx/ISKkTO/CLlCSwcgo3TPxFEMg75r 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: /5cvwnNQZWF2Tgi498BfZvYdIu8CAWwk0NeWL2QX946Wdiv8tkpW9dJvhgGEFNkiw6nG5kMZWu zxaWu/nSk3BSGtFnsQroQ/TTFQPRa8p7Nrl8rhVQRgX1a91751ZdM4oa3UHSYco5rM2zLp4dnU Jbr8A4kSIX16G9WXO0xy3NgB7PwUttfS6Q8sZ6XNtQb/clanI6xm0DmX/JLEv0I2wwTikOIwzK NJLsazWHy/GrRuZMpaiMVmVO2qBYKK+G3l8hqNxtmhTMLM2qL8a41FzlPEFmz7KSPEvjmQ8mh4 1no= X-SBRS: 5.2 X-MesageID: 40053831 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:NKf6LapUtefhjFedqEApd5MaV5v5L9V00zAX/kB9WHVpW+SFis Gjm+ka3xfoiDAXHEotg8yEJbPoex7h3LR+iLNwAZ6JWg76tGy0aLxz9IeK+UyFJwTS1M54kZ 1hfa93FcHqATFB5/rSzQGkH78br+Wv37uvgY7loUtFaSFPR+Ve4xxiCgCde3cGITVuIZYiDp KT6o5milObCBcqR/+2DHUEQOTPzuej/P7bSCULGgI97022hS6ogYSQLzGjwhwcXzlTqI1Sk1 TtrgqR3MSemsD+8DDw/Sv575NamNzuo+EzefCku4wuBRjHziqtbIRlcbWesD4yu/HH0idXrP D85y0OEu42x3TNfnykgRaF4Xie7B8er0XM5HXdoXz/rdf3TDg3YvAx+75xQ1/ixGcL+PRfuZ g7uF6xht5sIj7r2BnZ3ZzuUSpnk0KlyEBS6tI7vjhkfqY1LINKoZd3xjIyLL4wWBjUxaoAC+ dUAMTV9J9tACmnRkGchGVpzdC2N05DZyuucwwHssyR5TBcgGp0+Use3NAehXcN7vsGOuF529 g= X-IronPort-AV: E=Sophos;i="5.81,262,1610427600"; d="scan'208";a="40053831" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OXgSaU5wWI+E93adkL1xRPRWCO29oedjf7Te2lQZjQ0tDuEU3Ih4wlArs5HpTFk5SwL62kK1zwWaoO0NLuT8KWOFYpcmiTNuhsZyitLWs36JITFxDFm7rV9y900cZiBuxecY8lROBsgVW3bo86zFrm4963phEC/r3uo/zaIjN30WcjwZSvTBuaLzjYN+0ybMeS90YDmM/42w67l5IkCsMYq4xfbKHylId3zxtKZZqAItOANeqNhAl17a8D7yIKghONAlAZNsIh5velJOEUvcLgJYi+jrqLgQljqAXgzEJwYJhIJ8UNDRDyryiVoarmjh6PtSw20TwXLwTrqLFiw0Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5l3qePY/1n+xM1joQFLQ/DuqU4YPkqsTmKVM66m0n10=; b=Waxer8AlOodXxYz2OnIeoSV/xYCBiPxK7raaY3K3Sqo8H+2Fv4BFlqGQTbLe/hSYNBRsDXzDzSBZTncSIf9OgjO0a6IbsRj4UE6YMh89ACjfI4kkWJmIDezBH47GmCKNMpO4MjcEkW4fFth0GFHFWOPKuTTHtB0H4zg7q8+/hWK+dB6PHFW3cYRJXPEKVZdUavYrn9aU62gJIMa1Npg0b7CRNmtGfWzehkVvacv/JTprcQDGgsb9M7KmQQUyNteLYMJtIMJY9J1m0sAPGZHT95Es7uWAtZQ3WySmysxYK+Y3VAKrIQqyD4uvvbm2h1tE2OIDr55GciyrMOmmg8NU5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5l3qePY/1n+xM1joQFLQ/DuqU4YPkqsTmKVM66m0n10=; b=U/cngl9/13W+CwxAgnE2krveP/jRBxChZ1miqmFo5df7vzGvvkvUhCJe9j7ZDsJKBpgEZM198ho1C/ODIkj46eVcbrJqBBgIUnzg+fjj4awueDjv3I31o1r9Ot6feygbTBqk4l3pZOOwlwEsO/IpPRk7SM9DQrGlhYEgX02C1b0= Subject: Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" To: Jan Beulich CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Boris Ostrovsky , Ian Jackson , Xen-devel References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> <1c5f3162-8451-5e6c-e5b3-e5368fc0a871@suse.com> From: Andrew Cooper Message-ID: <13a21f92-3275-64c6-8afb-27ae4f772171@citrix.com> Date: Fri, 19 Mar 2021 14:03:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <1c5f3162-8451-5e6c-e5b3-e5368fc0a871@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0116.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::32) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b9120d55-5670-4672-f88f-08d8eadfc760 X-MS-TrafficTypeDiagnostic: BN8PR03MB5137: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K7c39Ojr56g0qUY8FOCLKIuXOX5wZ1lAMJcobg5bKRYupY3ZMJkeqwnpO/AL6Hfz2Dnlmua2U3nSxIG6qwBx7u4/AXMUFn1ZoabDRzTflM3uKRXZLMmYUBACTJZOb9TUkQzcE0w2h+TWH5AppqpUsAL+GehsgXzgvVznHTUwkTYVIxX1Pgcr6IaZTJLy7yRCdI07PLdurxdKMPi30tRTr1OIlSmQV6u5iWGi6yh5EWcccW5V9mzIKxmeqQyip+AvDUpQzKlgg6MSArKhPKeOxZjla4ucQkKJ4N180jA0I0/1enOm/TvE6J7xaFeRZ6/WXdBwGLqxyS2NR4GZsyu3eU0mc1B6My10wsFpWtz70GncnTqUVRJrbZLNAGobwqy55VajOEp9oJFq1OFL95SkjbU2FlKIAvU378T67IQPFaAPafovd5WmLYvXbiC1KV48KzN0NN/3jjmrTM/AhyXXZhn2NYpbnei+aHeiR2fSjzSWoNBaGZ1JknTvajWR2s8rluC0ZntUF1JRnjZwbdBDB3u+DqJo878rQJFhE/7JxN8qef2ho9TvSuCY6pkJnaKpLDZ2D1A/vm5BYVzXU/2k9x+34A5dO4cBhfPiwFzLqIQi01NX1kMHu/207QYQExJC+63HaxcP8W5HOOuXKizyyPeJBZRMhCo9ZHbZuQ941V4iHSY9PGcPKTw0PRXCCTxrY7LnlUHez9pUHhE2xo19/w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(346002)(39860400002)(376002)(136003)(31686004)(54906003)(2616005)(956004)(66946007)(6666004)(4326008)(66476007)(8676002)(6486002)(16526019)(31696002)(5660300002)(6916009)(16576012)(66556008)(26005)(478600001)(86362001)(36756003)(2906002)(8936002)(38100700001)(316002)(53546011)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZlNlempoQjJXT2paazhSME00SnZMSVFadEdESzZ5R1NTbUc0eVpncW5PSTJv?= =?utf-8?B?WHhSaGtIRnpJUWZJK3VyNHR4SUdmazFmeXpYYVlIdTJ3Y1UvMm13bTdPOWFh?= =?utf-8?B?OUhtbTI5Nm8zVytVbUFpdzd4dXZVTzE4TGE0Q0ZHTTZBRzFOSmVobGJFWGl2?= =?utf-8?B?eDhVaDlDNjZ6SXM2YmZZc2h2WUM2OFdYVGt0V1dlQmd1bVRPY2lNdkFBR2l5?= =?utf-8?B?T2dkcEdTR2kxTGZwUnBxZStWUzlQR2FEcm1RdGFPVFN0ekNNdWxvYTh5WjFB?= =?utf-8?B?ZjNtaVBNcVNsdng1SFVNTHpmMXFQeE5MUEp2ZjAyZk02MjhmVnpTWDNVcjEv?= =?utf-8?B?cHNZNHM1V2tZbFBkdjRjWnp1NURNMDJ2MVRudUFXTmU2SzZEOHVob255ZVIv?= =?utf-8?B?RjVCQUdXS2hXOFB2N3hoWS9aNzI4eXo2SE1uSEo4bnQwSWpnaEpraHVzL1BF?= =?utf-8?B?eEZydkVuZ3pDQWo4Sm5XZXF3SnBLTzR0aTNJR3NNeERWb3Q3d2dCbTc2TXVR?= =?utf-8?B?RDhwcmNmNTVFVG56VEhWYUZ3TDk1Y2xoZ09ZWEpaaTUxeUZOT1kvb0pSS3BD?= =?utf-8?B?SzJ6WG4yU2NSZjNucWc1T0E3aHdzeWFheDlvYSsyTUx3Zi9XMDRWQVdTQnA3?= =?utf-8?B?S2c2NGJDdGpvNTdHVmRhVWI4L0cwOFJGTTJDV2tRWEhRVHZFMlBLQlBMTzhQ?= =?utf-8?B?ckJHZC9SOFZTWjNYTUgwWERMZUVleStFcDRJZ3F6WlNHeTRTdGFsWnRaclRm?= =?utf-8?B?OGkzNjgrYTUwWXRrWFhvVTV5eHRBMGRvQUpwZWtFT0pIM3lsd2NmR3QvL2dy?= =?utf-8?B?RUp6R0xGcDRjbE8vcTZFdlJ0Q3RNQkZCMWRvcW9Vc3hocVYxK1d3ZUYrdGMw?= =?utf-8?B?L0VkcUFoNGpTeVJmdzJRUGJWODdaaCs2RHE1OGV5T28rNEFhZjB6eDRBV1NJ?= =?utf-8?B?aXYxb3lsMjhXbC9hMFBwRGx4RzBRK3hqME0wM3Y1cWE4VmdzWXoxbjZBZ2k0?= =?utf-8?B?M0p3RlBVb1FLMjdFWkZHR1ViZTlUWmVYc2JRVndOeG5teFZ3dzYxSEtURjR5?= =?utf-8?B?Zi85c2lKL2ZPaXQ2a1EveHUybkZJb1VPSlFZSlN2WUdvaXp0T1RzajFFNnBq?= =?utf-8?B?VHpLZFpGVENKMVo1Q29OTjdJcGlMN2VhL2lUaDV6OGlYMTVERXkrMkhIR2ZK?= =?utf-8?B?QUpuemdyWjYvaS9RT2t0RzhlSnVySS9BcGN1MDVrQkRFZUMxYzNydWVEK3ZF?= =?utf-8?B?cENwazlLNVlQdzJjeEpxMkxmMG91NTk5RFNPcy9hbXdpSmc1Rmk2RXVqZkp0?= =?utf-8?B?dEJ3ZDdhZjlyVWF6bUtwa3lzcGdyRndhLzE1UzFobmtLSHVMT21vMHhGcjlL?= =?utf-8?B?U05PZ3ViTXFwUE1ZREZkSHNIYWFUN1FaeElwSUZPTHhneUVjUDhpOXcwaGd2?= =?utf-8?B?aUhNZi8xam9DRXhrS1VYTm01aXlnbU5vTDFoUkw0aFByWmV0ckcvREFwRFU0?= =?utf-8?B?UXplZWdWS3huMytzU21zcHBqV0JMVGxpYnRqYmdxNjB6WGIyNC9MQUhwelZx?= =?utf-8?B?OEVtcFNyNDA4alhjUkwwd3lIT282MitncWxKWDhtU1FJUDlxQ21zZ2ptRDJv?= =?utf-8?B?L2hVejBJL0xDSFdkTUQ1N3VUUS9oam5XdGt6L2ZPQlZUenl0SE5nallNV1NH?= =?utf-8?B?OVpINFFBUEtlUmFhckFMUzM4Mmc1WWpwWUFidC9JVzFUWXVGaSszTlljTWMz?= =?utf-8?Q?9KDp6UxeiY2QmaUWuNZCM7n75vEtpox5WhAAx3I?= X-MS-Exchange-CrossTenant-Network-Message-Id: b9120d55-5670-4672-f88f-08d8eadfc760 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 14:03:31.7452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BqwpdsCZ0AyDIwsYrf+RH2vE9wbJZme3A2GZSbcPfprFkOMihQfX94WzlNio0HMLx7mE/u//bKJ5GUmk3krTaYZF34vQLRhrBAVqqNf70Og= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5137 X-OriginatorOrg: citrix.com On 19/03/2021 13:56, Jan Beulich wrote: > On 19.03.2021 13:59, Andrew Cooper wrote: >> On 16/03/2021 16:58, Jan Beulich wrote: >>> On 16.03.2021 17:18, Andrew Cooper wrote: >>>> In hindsight, this was a poor move. Some of these MSRs require probing for, >>>> causing unhelpful spew into xl dmesg, as well as spew from unit tests >>>> explicitly checking behaviour. >>> I can indeed see your point for MSRs that require probing. But what about >>> the others (which, as it seems, is the majority)? And perhaps specifically >>> what about the entire WRMSR side, which won't be related to probing? I'm >>> not opposed to the change, but I'd like to understand the reasoning for >>> every one of the MSRs, not just a subset. >>> >>> Of course such ever-growing lists of case labels aren't very nice - this >>> going away was one of the things I particularly liked about the original >>> change. >> The logging in the default case is only useful when it is genuinely MSRs >> we haven't considered. >> >> It is very useful at pointing bugs in guests, or bugs in Xen, but only >> when the logging is not drowned out by things we know about. > So would you mind adjusting the description accordingly? Right now, the > way it's written, it reads (to my non-native interpretation) as entirely > focusing on guests' probing needs. Even an adjustment as simple as > > "In hindsight, this was a poor move. Some of these MSRs require probing for, > cause unhelpful spew into xl dmesg, or cause spew from unit tests > explicitly checking behaviour." > > would already shift the focus imo. Sure.  I'll try to make this clearer. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 19 15:01:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 15:01:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99328.188858 (Exim 4.92) (envelope-from ) id 1lNGcR-0001of-RH; Fri, 19 Mar 2021 15:00:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99328.188858; Fri, 19 Mar 2021 15:00:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNGcR-0001oY-Nw; Fri, 19 Mar 2021 15:00:55 +0000 Received: by outflank-mailman (input) for mailman id 99328; Fri, 19 Mar 2021 15:00:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNGcP-0001oT-TL for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 15:00:54 +0000 Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 96fdfc40-1b93-44e8-8bb2-1df0875adc22; Fri, 19 Mar 2021 15:00:52 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12JEspZ8124537; Fri, 19 Mar 2021 15:00:50 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 37a4em07be-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Mar 2021 15:00:50 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12JEu6pC014063; Fri, 19 Mar 2021 15:00:50 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by aserp3020.oracle.com with ESMTP id 37cf2vjgga-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Mar 2021 15:00:49 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BY5PR10MB3939.namprd10.prod.outlook.com (2603:10b6:a03:1f7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Fri, 19 Mar 2021 15:00:48 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3955.023; Fri, 19 Mar 2021 15:00:48 +0000 Received: from [10.74.102.27] (138.3.201.27) by SJ0PR03CA0219.namprd03.prod.outlook.com (2603:10b6:a03:39f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Fri, 19 Mar 2021 15:00:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96fdfc40-1b93-44e8-8bb2-1df0875adc22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=yTvQAh21u5lJPTBC4tu7w6h3+TwtqNoE7L4tquNswHI=; b=DfBqhLY4/A142S9gfZ9hrlWuM7uRo4xo0S9vS4O+JsfVJW9erJKSnhJvWUpv88wq871f CoXx4hCC/g7tKU93h3S394surcVvITzTXY7j68yacMhboo43nRNYlSlHfk+4LVcebqVm 6vNKtDHvXlXiTM6jWeBhfEUdia4qYIpiwSLKYWyEQlq34ZN+bZdg5rWYMs2JNxr7PNkY Hray9RfYNL7NX5LNDIktcQPZif5KdjLpgssXdYQERONE7XEWukaquYtht1Sx7yUogK60 AepReKaw2Vrri1UojdjLD4o5qhl5zmd5xjkBfVcP/d2Icom6hPlgRwUg15GEZosNFDNc xQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q542thT8pik9jqMNJG88KY2YUKVs6EsWRSKZry8mrUG5rgBri+hyOWkSDD0Ckp0rW7xib37bB96iCIePEVMLOj8wTwVCx6+XoPIFhNi0O5j1jcQ5f/Q/zLfuYbhb8beNKowttBr/eMdTPRqurLCjdrbrD3oST5CwRlf4KXaxK/giYMU+3C8NSQpBXlUvXuRqa1iB+NuujhXClnJW4hOOPMPllKDunWjx1YZpo1p1oP1nwxv/KjY7VZ+5Yy/Bya1EHxeAAu/2z5Z68keYW0IL52xn2+eemcphfWAGc10pOpuy3pmnalCwZVNndGSJUv5UFBSjNSJfKzSM2Lu7jJYg5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yTvQAh21u5lJPTBC4tu7w6h3+TwtqNoE7L4tquNswHI=; b=oCiL0lplrA5gdkcQ4lbCl2r+Hl+GgGwbfeymh7FCkGOO1CooXVcWJqUMxzjTS+ULUz66m62y0xGqRvCe2/RpaTMedtBW4fJxaPKp0/cF+vn0vugLhhc4ziMXGtn2NVHbOm17w0XEsIQPNjudUYI09DNR0nt1tk/WEuj8PI4Lw4Ma6rT/2VAv9DIwqC8pBXo5s6jpm3KV/QC3CnFgb2GcXQHgcz8uAhV2SXq6P90EVb/tuv6pC0CH6ivyR4vlMFO3QVqCWOzdI3vEJUd6ak79Ftgs9sx9vPs3L87POElayA+NbGHN4QShoKCFQv3exdED7yfT6aaD2Jw+kLrvQRSkUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yTvQAh21u5lJPTBC4tu7w6h3+TwtqNoE7L4tquNswHI=; b=zSPpUP49L4cjvL8/RMr+O5BZJ2J4PXQ7MlkDdW0sRGAfEOp90s1Gt+A6OvpQlckQ03UqXNQnyY+HP2HLyI3lUmFnHmkJphmHatlXX45Q2sEW3EWbPsSOXPMD5ayMsKpl0thyXGmhYsHPl8tlK5LNJQe/y44MTGqtM992OTQq5ls= Authentication-Results: xilinx.com; dkim=none (message not signed) header.d=none;xilinx.com; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH] xen/arm: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped To: Stefano Stabellini Cc: jgross@suse.com, xen-devel@lists.xenproject.org, Stefano Stabellini References: <20210225235158.24001-1-sstabellini@kernel.org> <4707b219-eee1-22e8-8dd3-6b7d821de333@oracle.com> From: Boris Ostrovsky Message-ID: <47d6b423-5414-f14a-2730-74834bfa18f5@oracle.com> Date: Fri, 19 Mar 2021 11:00:43 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [138.3.201.27] X-ClientProxiedBy: SJ0PR03CA0219.namprd03.prod.outlook.com (2603:10b6:a03:39f::14) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 59c3f1cd-c920-4a5c-d670-08d8eae7c763 X-MS-TrafficTypeDiagnostic: BY5PR10MB3939: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W9tC2pawP8oA3+L3mRLJv2mRAtiaBYbS2bU4DQ1harHsIrFlfQuU4evqrxDHmibmXlloKjppCk300ZtqHZkGI3eTVkWfcfPqZuL4Aclw0brR09UfhZxO3F8QXy7EBNrpEaqxn9WptW04trZj65ttfF1Odq4Zq1eV4dht1/YXMa7ZPBgnn6OpzfZDsUu42oguyw3JWQUOgKHkswb7uyQO91zWcGh9u0RwyIQA1E/bdVVX6heF71nL3Sz5U5DPEGgJ4ACsFUvVT0NhVuQ2RMi7ZhU3MDrKiXi7UcURYhgOGldjxh8AsFcQIque/eR0s9xGt2LVhEmZ0MBwMfpsSr2djXKSmc5zl0dhEpsfNH7fB0vgQC42e7Exg05pmfWOlivVz4fJJfXHgpCyALe4j8oPAIUpfKlpVtw4JyMrpu8jX+mUUXuNXq63eoxuwoQVCSY3rJy7mH75L/loheHCeMH+7W6SDken7jM2JEXL9ZsatPseUhvKdLhdavj+8d3bV+J27etMggc5yPnPoNVdP2M8LdpunRUAJr3gcJbflH1ZKuDw8i4UC/1rPtgmADzxI7cSncnL7DtE1Dgz84Cbeu7WjsOiRHVeqvGgT0mRwWtovIRGR+O9cRkIVPddm10cvoCkZnjd0HxrxdpIWQ1wKOrh2UFzgLDbWp386U6+/vSBnw6e4WeqpGbk+SoalQeS3ZQUOj+XHfwl2fJ12XVIH9pTwxWkdu77aPnzqUgIof/pKJs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(396003)(376002)(346002)(136003)(956004)(86362001)(2616005)(6666004)(31686004)(66946007)(44832011)(53546011)(6916009)(316002)(83380400001)(31696002)(38100700001)(66476007)(66556008)(8936002)(16576012)(186003)(4326008)(5660300002)(478600001)(26005)(36756003)(16526019)(6486002)(4744005)(2906002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eWlBVXhCNXZPUnBuM1E3VC9sN2w4S3hOR0dnaUJuY3FTTVBPVUxDSnBwS1h0?= =?utf-8?B?NUZGc3BaK0U0cEVsaThBSG1UeDVURlFiWWlTN01LQlU2ZjdsOVFCN0dHUnFJ?= =?utf-8?B?L0lHUE1hbkFwTm5QZnRqMitmVFd1WFczYS9LdDhFQ3JZdmVYS3N3aWY2aTEw?= =?utf-8?B?WEJVQWZCVWNwdnV6YmFSejhyRkl6S28yU1JBQVA0RWozc1ZhZzkwTFJRR0o2?= =?utf-8?B?a2pWRlhqQWJaNHhXb3JHM2xWUnVGZ2dINVhXSlpRRlFTWFZINEo5SFlQYnUy?= =?utf-8?B?bVhqUDJBMXhEY0ZoYUZmeHpnU0lMK0c2WWlWejJ6V01RWnpaRkt0bDlGYmhF?= =?utf-8?B?VVlyMW44a3AvK0gxUFliRHBvbUVZdGxEVTdtK0RUcnJPUnBZRTFqV3A5Qmpu?= =?utf-8?B?KzVZT1VwVVV3enErdmxlM1kyQWVOVVFtYUZLWnJKZXlaclhzd3lVRjQ5TlJi?= =?utf-8?B?SWtqZjdINk1UanRtSHU2TzMxcHVvUDJCVzNzWlB0TVVvcmRFbEpRWVR4U21P?= =?utf-8?B?eVcxcWQxR1dJME42WTljWUovQWtRbGN1eTNZbXdHUWdHTU9wZ0cwbXoyZ1Vp?= =?utf-8?B?VlVqYnRzNTg2ZXhpeHVla0t1NTZ4SmUzZVZkL1FTVWtNNTFaWmN2N0U4dGJp?= =?utf-8?B?aW9iRVFoTmc4S1I5U1FtZ0J6M3ZDNDIvbzdqZW1ReW1EdzNPa3ZKMmt2SUtj?= =?utf-8?B?UVloZDJwdWJMeGhQR3JpL1VTZG5BK05MQUY0ZWFXM1FJTXEzenEvSmh1N2Yr?= =?utf-8?B?SDBDOGhVNkNzdjIxZ014RUhZb1NEUVZUZjVidG9kTHBQL3p3NGNRbzV5QStr?= =?utf-8?B?VHZUV1hSeE9yK3pFQUg5NGUyTklGVEFjMG5kOGxnVkQzNFZEMDZwNzU2L0JM?= =?utf-8?B?THljS2lhalB2SERIN0haYjdQd3JzUSthc3lnSVJ3Y0g2Q2tGTVRHZThpTkF3?= =?utf-8?B?OUhGNlVVQ3pESlBOSFluNGQzWnJ0THlZb2NvT3lTNDVUV0E5L21tZWt4a2ZY?= =?utf-8?B?YURvaWc1MTgreWx5cC9uUi9aTGlBT25BS2xJWXBTdWkyT1RXYS8rcVd5TlZl?= =?utf-8?B?TGcxOXFjZllKNGFtMDhXZlZuL29Qbnk1WkhMTE11VUJiTXByR3BWVXhVQWZM?= =?utf-8?B?MEhrT1QwVnY3YytUbnlJaGI4ajEwcXVMb0gvd3FCUlNkbXphb3ByR2lYQTBx?= =?utf-8?B?bHJJcUl6dlhkR2cyc0ZWYTNJOHk4MW5tdUFQd1pCbHA2Rk5UbHZRL0k5RWdE?= =?utf-8?B?Ky9vMjhVL1NwSE5zYU5SZStXRHg5cFZ3a2xSaEtKS25LNzBsZEpkSjg2YnBj?= =?utf-8?B?cDlzd2RKZEhRS0x1WjU2V1ptdElwV2hFN081aWpXaXZsRExvV2xWQkw5N1JG?= =?utf-8?B?MWJhTm4ySXZZS1VZZXBkc00vcTBZUjNTOHdaSEFJbGZCL3k4dnJOSzVGUDFq?= =?utf-8?B?eXE0TG1EaS9tUzU0QlRwWmZXMkxGSjFKWFJhZmhzUm1PU09zUDg4dUZWQlY0?= =?utf-8?B?bDdZQkd5R3JUN21PRkZ4d2RCMnBVMmJWMStDT2VsQ3hQaVRRa0hsc1MxQW5J?= =?utf-8?B?emlranVtUG5DS3hZM2NXa0Vvclcyajg1bk50c3Ywd3FWSVA4MkJmVFBtQlRM?= =?utf-8?B?cmNnY0t2cG1tWVZXdWZZQjV6UktKQUZUOVRtMGsrRGpBbW9EMU9kNUZ5TGJz?= =?utf-8?B?N0U2eVNaeVlrVmhRZkVzY2Y1TWx2dlpwaDE2SFVONHRXek9JaDVvcjdINTI3?= =?utf-8?Q?RdcZADjqLll1y6R0bpmvxvR+SdjLXZ1uiusmgNl?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59c3f1cd-c920-4a5c-d670-08d8eae7c763 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 15:00:47.8757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JgoxI5buHhMC+v+X0cIhu8lnTMOi48lmpBNXjmJy9fkMF6wG6DaAiy9LhRHwfNsMP4PWEAJyo6aKu1H2y0iSvee/6udyR8fhGqv5rWWCI0o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3939 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9928 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103190107 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9928 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 adultscore=0 phishscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103190107 On 3/18/21 7:28 PM, Stefano Stabellini wrote: > > So, I'll follow you suggestion, keep the x86 side named as it is today, > and provide a tiny wrapper so that we can still have an arch-neutral > xen_swiotlb_detect function (on x86 just calls pci_xen_swiotlb_detect.) But now on x86 side we end up with a routine that noone calls. And pci_xen_swiotlb_detect() becomes not __init and so it will have to stick around after boot for no good reason. (You could have made it __ref btw). I think we should leave x86 alone. And if there is a declaration in include/xen/swiotlb-xen.h that's only relevant to ARM --- well, so be it. Or perhaps you can create arch/arm/include/asm/xen/swiotlb-xen.h -boris From xen-devel-bounces@lists.xenproject.org Fri Mar 19 17:06:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 17:06:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99339.188880 (Exim 4.92) (envelope-from ) id 1lNIZ3-0005Ia-6k; Fri, 19 Mar 2021 17:05:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99339.188880; Fri, 19 Mar 2021 17:05:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNIZ3-0005IT-3m; Fri, 19 Mar 2021 17:05:33 +0000 Received: by outflank-mailman (input) for mailman id 99339; Fri, 19 Mar 2021 17:05:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNIZ1-0005IL-Ln; Fri, 19 Mar 2021 17:05:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNIZ1-0008MH-E4; Fri, 19 Mar 2021 17:05:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNIZ1-0001DV-3f; Fri, 19 Mar 2021 17:05:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNIZ1-0005dF-2u; Fri, 19 Mar 2021 17:05:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YsijrWeDd8Qmy5U/XwmXlMTqNgQxWYz012Gi8500FE8=; b=iwuFphzJ+JEx13lpXq1E6cq1Vs FePN1vvci0aeruMgbKzu6xEfP8Oz+QKWQ6+i/XObGejCh3WMsaPrmfR3+6rerzcxwtwLt1ihWj5hO Y+CB/ZhV2Nn8kVuXEd1AkMH7BupeDbqhMe9lsErPZoWHfAG3Zvfv5MKhbXXQ4lpLNWNE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160130: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=dae3c3e8b257cd27d6b35a467a34bf79a6650340 X-Osstest-Versions-That: xen=21657ad4f01a634beac570c64c0691e51b9cf366 From: osstest service owner Date: Fri, 19 Mar 2021 17:05:31 +0000 flight 160130 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160130/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 160120 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160120 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160120 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160120 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160120 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160120 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160120 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160120 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160120 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160120 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160120 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160120 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen dae3c3e8b257cd27d6b35a467a34bf79a6650340 baseline version: xen 21657ad4f01a634beac570c64c0691e51b9cf366 Last test of basis 160120 2021-03-18 01:52:30 Z 1 days Testing same since 160130 2021-03-18 16:38:51 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Olaf Hering jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 21657ad4f0..dae3c3e8b2 dae3c3e8b257cd27d6b35a467a34bf79a6650340 -> master From xen-devel-bounces@lists.xenproject.org Fri Mar 19 17:37:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 17:37:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99348.188901 (Exim 4.92) (envelope-from ) id 1lNJ49-0008It-SM; Fri, 19 Mar 2021 17:37:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99348.188901; Fri, 19 Mar 2021 17:37:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNJ49-0008Im-N2; Fri, 19 Mar 2021 17:37:41 +0000 Received: by outflank-mailman (input) for mailman id 99348; Fri, 19 Mar 2021 17:37:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNJ48-0008Ie-HD; Fri, 19 Mar 2021 17:37:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNJ47-0000Qd-Rs; Fri, 19 Mar 2021 17:37:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNJ47-0002Ee-G0; Fri, 19 Mar 2021 17:37:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNJ47-0003ux-FT; Fri, 19 Mar 2021 17:37:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1QOEtMhp2L17sqid/9CRdxCCf3PhLH/2PPN3yK17WW4=; b=CE6AVNQ79OOArKabRTv2CRJ9Fd HfOtfjgQ8Ws0WFG64ffO3dnuAhbMK3JhD2SbcurX8kc8fQlXKaLo45iRwOnG3aoWuB9L9HuOByLsc TvobyXy/8FoC3sZd0/4MXFmIWpFwGVuVywMTF8RKid+Mtf8Jrx6pThpB/uSar6viF8vg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160135: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=c91fa273062ec388385bf8cc081117c78c2f7af5 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 19 Mar 2021 17:37:39 +0000 flight 160135 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160135/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt c91fa273062ec388385bf8cc081117c78c2f7af5 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 252 days Failing since 151818 2020-07-11 04:18:52 Z 251 days 244 attempts Testing same since 160135 2021-03-19 04:19:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 48034 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Mar 19 17:54:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 17:54:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99357.188919 (Exim 4.92) (envelope-from ) id 1lNJJq-0001gs-Gj; Fri, 19 Mar 2021 17:53:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99357.188919; Fri, 19 Mar 2021 17:53:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNJJq-0001gl-Cx; Fri, 19 Mar 2021 17:53:54 +0000 Received: by outflank-mailman (input) for mailman id 99357; Fri, 19 Mar 2021 17:53:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNJJo-0001gg-Oi for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 17:53:52 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b5ccc73d-eff0-4bd8-a522-da24adbc0ade; Fri, 19 Mar 2021 17:53:51 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 89AF661940; Fri, 19 Mar 2021 17:53:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5ccc73d-eff0-4bd8-a522-da24adbc0ade DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616176430; bh=BEJ9RkjzI1WOzBgPTlN0SlBzqS9pkrrm/I4Zj4Xc4NQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=P5JMoiWykU6EzK9XYK5IDb80VfXP71S9Pz8byPp/It9vQfXmFRKLi/CuafX0HoUwk /CGv/cmF2n/4WVBKpGGdUjisXfzCRa5EuOiQab96RkjeTt+O78kU5oHjJYIhzD+Djt ezABY1BoTBvc7vYyUIF3Pk51ueODqq8Ej21ComrLRUslWVU11KFb78FnduNBy9b4mf 79o9PmKczGojp+VT836U450mNCwXK0dTLlWv0O+Uky5BfQNu50LJ9zXLvi6J7jHZe4 EaA6NBX/skSLbLs7aCwoI6B1TM9He/5iUpchZ4A/2Gc8kLxahI66mjWv03DhkIrQGq OCvoaaXdRCjbA== Date: Fri, 19 Mar 2021 10:53:49 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Boris Ostrovsky cc: Stefano Stabellini , jgross@suse.com, xen-devel@lists.xenproject.org, Stefano Stabellini Subject: Re: [PATCH] xen/arm: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped In-Reply-To: <47d6b423-5414-f14a-2730-74834bfa18f5@oracle.com> Message-ID: References: <20210225235158.24001-1-sstabellini@kernel.org> <4707b219-eee1-22e8-8dd3-6b7d821de333@oracle.com> <47d6b423-5414-f14a-2730-74834bfa18f5@oracle.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 19 Mar 2021, Boris Ostrovsky wrote: > On 3/18/21 7:28 PM, Stefano Stabellini wrote: > > > > So, I'll follow you suggestion, keep the x86 side named as it is today, > > and provide a tiny wrapper so that we can still have an arch-neutral > > xen_swiotlb_detect function (on x86 just calls pci_xen_swiotlb_detect.) > > > But now on x86 side we end up with a routine that noone calls. And pci_xen_swiotlb_detect() becomes not __init and so it will have to stick around after boot for no good reason. (You could have made it __ref btw). > > > I think we should leave x86 alone. And if there is a declaration in include/xen/swiotlb-xen.h that's only relevant to ARM --- well, so be it. Or perhaps you can create arch/arm/include/asm/xen/swiotlb-xen.h Yeah I wanted to avoid creating arch/arm/include/asm/xen/swiotlb-xen.h because I would have to do one of the following: 1) add one more #include to arch/arm64/mm/dma-mapping.c (#include is there already) 2) add #include to include/xen/swiotlb-xen.h What's your preference? If I have to create arch/arm/include/asm/xen/swiotlb-xen.h, I would go with 2). From xen-devel-bounces@lists.xenproject.org Fri Mar 19 18:07:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 18:07:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99360.188931 (Exim 4.92) (envelope-from ) id 1lNJWl-0002po-NL; Fri, 19 Mar 2021 18:07:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99360.188931; Fri, 19 Mar 2021 18:07:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNJWl-0002ph-Js; Fri, 19 Mar 2021 18:07:15 +0000 Received: by outflank-mailman (input) for mailman id 99360; Fri, 19 Mar 2021 18:07:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNJWl-0002pY-3D; Fri, 19 Mar 2021 18:07:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNJWk-0000zf-HZ; Fri, 19 Mar 2021 18:07:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNJWk-0003Z6-7V; Fri, 19 Mar 2021 18:07:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNJWk-0004r7-6z; Fri, 19 Mar 2021 18:07:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=o6kD3XHb1ba8UrwRQHifXLcgYjiPoJhmjg5sdMFzAnM=; b=jhApg/LPyI0lymLhQwzQQLaVhg N2mpjXSmzIuCS0y+5JvzaSV/JlcCbWjlizAD9AUueRu7VyNnSEMu5ATtr1N+oy96egmtSkE9NpEdK 5NmsgByOJFspN51UFKXQ58qKh45W2lm69E45pWhnwx9usa6a6FswUz7lXzgdOpmqosis=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160131: all pass - PUSHED X-Osstest-Versions-This: ovmf=eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 X-Osstest-Versions-That: ovmf=9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 From: osstest service owner Date: Fri, 19 Mar 2021 18:07:14 +0000 flight 160131 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160131/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 baseline version: ovmf 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 Last test of basis 160123 2021-03-18 04:45:10 Z 1 days Testing same since 160131 2021-03-18 17:39:48 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Brijesh Singh James Bottomley Jiewen Yao Laszlo Ersek Leif Lindholm Min Xu Tom Lendacky jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 9fd7e88c23..eb07bfb09e eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Mar 19 18:41:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 18:41:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99367.188946 (Exim 4.92) (envelope-from ) id 1lNK3o-0006Wf-Bq; Fri, 19 Mar 2021 18:41:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99367.188946; Fri, 19 Mar 2021 18:41:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNK3o-0006WY-8j; Fri, 19 Mar 2021 18:41:24 +0000 Received: by outflank-mailman (input) for mailman id 99367; Fri, 19 Mar 2021 18:41:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNK3m-0006WT-Dr for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 18:41:22 +0000 Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 90c15901-fcad-44cc-9c20-edade0f9bfad; Fri, 19 Mar 2021 18:41:21 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12JIOdK1085297; Fri, 19 Mar 2021 18:41:19 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 37a4em0v9t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Mar 2021 18:41:19 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12JIPjgp035185; Fri, 19 Mar 2021 18:41:19 GMT Received: from nam02-cy1-obe.outbound.protection.outlook.com (mail-cys01nam02lp2056.outbound.protection.outlook.com [104.47.37.56]) by userp3020.oracle.com with ESMTP id 37cf2c3k4b-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Mar 2021 18:41:19 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BYAPR10MB3126.namprd10.prod.outlook.com (2603:10b6:a03:15c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Fri, 19 Mar 2021 18:41:17 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3955.023; Fri, 19 Mar 2021 18:41:17 +0000 Received: from [10.74.102.27] (138.3.201.27) by SJ0PR03CA0151.namprd03.prod.outlook.com (2603:10b6:a03:338::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Fri, 19 Mar 2021 18:41:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90c15901-fcad-44cc-9c20-edade0f9bfad DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=tEz2JFMr1dvD5djeC9s6X8ftcCzTFEKLa21UzJKdQEQ=; b=Dg2PLw7e32TwltPWbNXPOGJCg5LPRdPi/+XwHKAguOHeCo72R3ZLMnElTTllZNjqko3e /t/BAA2pMw7q1qMD0cXISIb/Yfy0HMf2rfzOtj8VHl2bb87HxerwCi59X55Z9mJBrFuM 3D/TJSQf6squLpHI1S1EefBDYqB7XDKbsEEo3/TNsVhosBBuPfmyvqd4M6RQrT6qQjqy wo97EI1fvUnwVqoi7DdTUrKZwW1lIk3n/P/pdctA2AwD6b16/fU+IaQ1tRGsz3VGTPwP aPIeEVXwP7sewyt0jdZ/8YfmJTtMe0H9eZ91eWLNy1eaji9xpuKm/QyqmlzsbVd86HJw pg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fnxzbWVbmuVq3vAEH+th2uIFsxbB9g9DCQ38W0fwR/fgMWYHQtzCzRXMdKLSRyqWJvKEn9gL+f6R6+RLhRwNhcIbXq2AjMbpG6UspIjDcBVNeouOWRqpDCoi3QoHyrhDpImw5sqbUGH4FSICRjQo7HITwYp7GbNub8f93ypOjsKoda8JwCiNo5yOnzJVMgvn2LqbLmzJ8uBCvr5wq7lRBePL/5MFQGm+phAEoh7cTjsz09zLI+DB5fClOCNeJNmwj1rbi6sjae/o8EZJcPMFu/EtT8GNBJHHFz45ymnZ6W3o0/5M3CkBpNLTizkdGmIYFoWC2GQ/Y6dRsHRYbKjaHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tEz2JFMr1dvD5djeC9s6X8ftcCzTFEKLa21UzJKdQEQ=; b=VhtMwierE7FwOITZ8FbZzNmUlePLN2E2aCsvgFmVrmNfRjDNk/mIBoyRfflDAprrRNTKMRC1GfhW74TYTAljoWudXMqgK4gpN4c53MU6AG9TKl+LmKB1X7R8vnOlyjrowcQ56NUFj1dNJXu0VuhiwDAyE255m02RWvLgKLgwKcOuzdKAAPHIYwP6LujWEzcUSbTlOKIPEUzxNIOVOvutCvVr0ZTwBuONoUtu1Qw42XXMBELFP36hDcaRBpXaolh/7mFU3z00+bLGbNDOu14BojS2E+uqYbsVeODkhRzGLePSBAb4RcbmXKEgABW/xaoniXQwARJTsqSuvjkFLqvg4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tEz2JFMr1dvD5djeC9s6X8ftcCzTFEKLa21UzJKdQEQ=; b=aARO8e0ZDddAssJkospLWQM4G3U0SoJ4vcpl6p78YoBegOIr1xKvb0z3k3aosUhWIzeuW3DuhpkQbEKr/NMeIukliZI2ZP8eGtP9BSQg9777YRXLihC1Jq8QTe5miFV/y9gAiJCsJIE4ReISGdkXHnfQ0/AGGbsH1K6Vou1hsbs= Authentication-Results: xilinx.com; dkim=none (message not signed) header.d=none;xilinx.com; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH] xen/arm: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped To: Stefano Stabellini Cc: jgross@suse.com, xen-devel@lists.xenproject.org, Stefano Stabellini References: <20210225235158.24001-1-sstabellini@kernel.org> <4707b219-eee1-22e8-8dd3-6b7d821de333@oracle.com> <47d6b423-5414-f14a-2730-74834bfa18f5@oracle.com> From: Boris Ostrovsky Message-ID: <0c62cee9-e7b2-f616-a3a9-dac29d4b9d43@oracle.com> Date: Fri, 19 Mar 2021 14:41:12 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [138.3.201.27] X-ClientProxiedBy: SJ0PR03CA0151.namprd03.prod.outlook.com (2603:10b6:a03:338::6) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 61e88422-63c0-40ae-4fbf-08d8eb0694aa X-MS-TrafficTypeDiagnostic: BYAPR10MB3126: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fjo0jJnfZdV1mXG48+qLP6djL5ysSJ62hLYBLLC3wBZY+MLen1BZ5rP/+dlIr5k0c1sT6YozR1FvKiWV5fhtgUqn+P2+MwbX1f6elrzj82L2AqJ20KV3dTo3JEVoC21JgrjCydU9JFia2+uM0T02SS1KjT0fOWqTTqSF1l45UIaj2ljTRPcfuyt2eSnSgqrbRQ5Ky8cF1gsHOR96XIJf9dPV3PkYZZ2kAUrDyn6w65o3TklcFowHyv8DGaqxCpSei9/tbEgBEJUbmgEkyUfdLwksQsbZEfbXj+J1dE1hMArTEQvlWvyrkg4B5GRxsgspEIVErCjKx9eeHrkj3ky7dWboZ3DeGIVtfcbyXLqhvajxToUYVPVeoIrOr2SfunC0qAW5odbJ7IAptC6lhtkUf/4Z7wXmEuktFjM81lNhY9AgB/iyCMDpognntNphckGUJILppXMcEWUN1OvxhxjSd45y5Myw2KrqXP7wWYhnnq773oGDIjjdDSa5Si3v+GXAFpO3EgOnVKc7JKZzky7rAO1SOTqpyjx3nmJkx7nNS6YVai9B/ql78ASOdqrc5366qArwfpJiPOACssPHNUDsnzdpXRsPY5EvoMpzKvnBBcHmeME272zjgswvdlLexJfFstDMg89+WNWCsKPd1G6tnHJ7c7YGZm1BQbAbkUNe9jcs6IJyo5ixaNPGxBDf7+qAZHi9Ylbrf5KDkYG0GyDjJ5Q/dtzeClVGBzImezGyPxk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(136003)(366004)(376002)(346002)(39860400002)(38100700001)(6486002)(8676002)(6916009)(316002)(8936002)(31686004)(478600001)(16526019)(186003)(31696002)(6666004)(2906002)(86362001)(44832011)(2616005)(4326008)(956004)(66946007)(36756003)(5660300002)(26005)(16576012)(53546011)(83380400001)(66476007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Y1NvbU8vZlFCV3VPS1NNQkxWanJVUXBWUERVS0Z4MHJmajh0K1Bad3VWWkVi?= =?utf-8?B?Mm9TMGJUdlBEb1dESW1UeDJscEhtSkdHNWdNSHZPejVuN0c0OVpsRmlWeEVa?= =?utf-8?B?U1JoYjBZa2txRlpBZnJuQTNBZytiUnRlYVhLN29RbkI4aUdjWldDR0kwUmpp?= =?utf-8?B?ZDdOZWhVWjlZcG4zWmpMWmtCZG02UW5EVzNqTVZkZUpFSk9oeDAwVVo1cS9F?= =?utf-8?B?VDJNSEZRa3NZQjQwcml2YU9EQjZJTnY2Um80RnFMVmJBTGZZMWpZL2laMkhk?= =?utf-8?B?L2FTS1psQlc5Z0VxSjJ6cGZSV2MrSWhHZEFWcjNCTzR6SFpVSFZBbXRCU09O?= =?utf-8?B?Q2Z1VkdTejczeW92cmVaNTkyTlJzeFhoSFVuL1hQVmFaRUlZWlhKUDdVMFNN?= =?utf-8?B?anhxUW9kSTFrSU5CRmNpUHNpU0xGTmVOR3VQbkRxN3oyTFdFcXVXQjdCbXFV?= =?utf-8?B?eGZUcm12NVJ6QnNXUVVvc2p5N2dybS8wdUdIRCt1YXpEK0h5NEFJNThuUXJM?= =?utf-8?B?NzQzRjBzaE11NmJDV2F2MHk0NytCem9adjJDaW5XYlovbmhkem9vaUNxRUNu?= =?utf-8?B?ajU0MXlRbUdzb1h6Qy9ONDdHTnBkRGgvWUhINzdhU21PSGJtNGlLZnpTNk9h?= =?utf-8?B?Q2doZ1V0NGhJcDA1UXhremQ1WG5KVzBXYU9UMDBkQTJJOHB2TnlrTkxiengr?= =?utf-8?B?bFVYc0FZMDJ6RTFKanFnV2JnOUNlOXlidWFocjBmZlpLNlNUK3hBaUJTQ01o?= =?utf-8?B?YzgxNlBSUkRqcXZxa1Z0d1RnNzY5ZFhEeVhKMDhGekxCcW1keThINWR4aUIr?= =?utf-8?B?cUFUZHhQbEsrUVlUM2FtYXpFcm1zUVpsT1VLR1YyNHRLNUJROW9wd1BMKzFq?= =?utf-8?B?ZCtuVGRINGQvaHZUbkdNTVRnb0g3aTJyMjV5NkdYWGwxSWQxcjBIU0pBQjBh?= =?utf-8?B?ZGdDM2ZLN2wvNjZXZTZvTkJkNWZENndNMXQyS2hIRmMwOGVOZHl6WkhTeGkz?= =?utf-8?B?N1EvbEYrdnQzcGtzMWI4M21IZkYwT1RGV1VRS3BWNXFuekdMdU1la0N3L2ZF?= =?utf-8?B?aVV3bjRTSVBxY3RTVHIvRnVNZWpISDdwVi8rM1dxT3JlVHdrTXBIanJQYUE2?= =?utf-8?B?M0dGNmx4ZGZ1ZGhIWDBoRG9BVXpQSG5rWW5VeVJIZDF2eFNvOEtOeHMxOTBU?= =?utf-8?B?Sm1oZmtRMEhKQUlKSkZzZmFBU1pwRStCYndCeVlFZEUxdUxkMFM3VGtRWG5w?= =?utf-8?B?ekNtclhqa3FFUHBaVk51L2kxMWF1dW5zUmlQN3Bvbk9obkRTL1NpN3NzRHM5?= =?utf-8?B?WnMyK3IwYzJFTzZjSFRUdU0wRFdFU2hPczR6YVJhUk5LVXlPOWxERVQvRW51?= =?utf-8?B?QW1IemNTVnhuREwxN0U2cnRmUlVwOVU4Z1VSdG8wcGlkbUVkdEdlZ2dSTEZD?= =?utf-8?B?VFJWU0tWaE93b2lRVzlzYW1kWmFSNExvNHRZeVhDb3gySnFSN3l2aUxrU05C?= =?utf-8?B?cGxOSzZXNkJHbUpycHJrbnRVejhYaDBYeTFQU0N1eUlsSkNFV0Vzei9RMWha?= =?utf-8?B?VWRFaE9QMHR4NHNKZXVrVmx2Y3FScVljMWp2bGxKT3J5eWtZOTdUeUVlMzdi?= =?utf-8?B?L2w5Qk9GbFh2OHJaVE9lU2JMSW42YVBoL1BDK1REZnpVYkRPYWRUd1pVaitD?= =?utf-8?B?TTMyUDlJYXdjMnUzUGVRdTJwZFhoQWRTZVFhcjB1dXFTdnJDWjNwMEFMdnlF?= =?utf-8?Q?XMRkLfOjPj9hTe1TTq+JgaQzzW9wouvSj1HwJ11?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61e88422-63c0-40ae-4fbf-08d8eb0694aa X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 18:41:17.0615 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: efFERi9JEfGZ61sTS2Wu37RgsL11T/Le2np3bk4RE/RYPd1Nl85XvxnG4PcnIpJqOd429xAMzFuPZBSDuWHDtDcFlgnlK5D4FCjT42mt+dI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3126 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9928 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103190125 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9928 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 adultscore=0 phishscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103190125 On 3/19/21 1:53 PM, Stefano Stabellini wrote: > On Fri, 19 Mar 2021, Boris Ostrovsky wrote: >> On 3/18/21 7:28 PM, Stefano Stabellini wrote: >>> So, I'll follow you suggestion, keep the x86 side named as it is today, >>> and provide a tiny wrapper so that we can still have an arch-neutral >>> xen_swiotlb_detect function (on x86 just calls pci_xen_swiotlb_detect.) >> >> But now on x86 side we end up with a routine that noone calls. And pci_xen_swiotlb_detect() becomes not __init and so it will have to stick around after boot for no good reason. (You could have made it __ref btw). >> >> >> I think we should leave x86 alone. And if there is a declaration in include/xen/swiotlb-xen.h that's only relevant to ARM --- well, so be it. Or perhaps you can create arch/arm/include/asm/xen/swiotlb-xen.h > Yeah I wanted to avoid creating arch/arm/include/asm/xen/swiotlb-xen.h > because I would have to do one of the following: > > 1) add one more #include to arch/arm64/mm/dma-mapping.c > (#include is there already) > 2) add #include to include/xen/swiotlb-xen.h > > What's your preference? If I have to create > arch/arm/include/asm/xen/swiotlb-xen.h, I would go with 2). Yes, I agree --- #2 is the better choice. -boris From xen-devel-bounces@lists.xenproject.org Fri Mar 19 18:44:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 18:44:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99370.188958 (Exim 4.92) (envelope-from ) id 1lNK6D-0006fw-Ps; Fri, 19 Mar 2021 18:43:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99370.188958; Fri, 19 Mar 2021 18:43:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNK6D-0006fp-Mn; Fri, 19 Mar 2021 18:43:53 +0000 Received: by outflank-mailman (input) for mailman id 99370; Fri, 19 Mar 2021 18:43:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNK6C-0006fi-8P for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 18:43:52 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 81c080c9-1fce-4209-b2b4-f1cafc3b517b; Fri, 19 Mar 2021 18:43:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81c080c9-1fce-4209-b2b4-f1cafc3b517b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616179431; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=SikAD/si2SLckmDGNhPpWymn0rNwZdsyoiN1eJKVspw=; b=IP9w+VAS8FdgAY5imBr5Fjd/OCoI2xU5XCoUifYIelGKDQpL4KGHWL46 KbJ0w213r2YlR/jerwhE8XHpwMMlmC/q3jiabwXZiNiFAoQtWw2Iplf/5 VOrgjkYuCdvUA4lkkLXI5EQggmtAzYcun/novMvHWyiJw7tJcbuppsjRy w=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ElyVwfaKzokPxK2Z+SaxTYHgvVyWzWQfoRG/yFFBs44CE+8HQvFoiVdT1n75QfvCWl7DMEBiZF Hyby8z9liwrEdm+Vk2Egt/ye3H9HtVViXWVTXQizcU9nr3BmHm8R/zB3SV45UA3VkNKyIGQcVo ReCfZBNsux6xnnyGCunOf4UOB0puGuKl4UuZar+wwHVSVkdRHaBaqgBZ6jm8f89ZUrCjV0EJpI EP6Qe7S1U4dWu026m8CQblnZ6+1g8//yx4SgrZ8xAI5Zr6GT3I6QTldsvvwCHn6iRr8bRsxFzB 3bI= X-SBRS: 5.2 X-MesageID: 40078075 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:v/NRIqpHo4BTDlAFErGimEcaV5v5L9V00zAX/kB9WHVpW+SFis Gjm+ka3xfoiDAXHEotg8yEJbPoex7h3LR+iLNwAZ6JWg76tGy0aLxz9IeK+UyFJwTS1M54kZ 1hfa93FcHqATFB5/rSzQGkH78br+Wv37uvgY7loUtFaSFPR+Ve4xxiCgCde3cGITVuIZYiDp KT6o5milObCBcqR/+2DHUEQOTPzuej/P7bSCULGgI97022hS6ogYSQLzGjwhwcXzlTqI1Sk1 TtrgqR3MSemsD+8DDw/Sv575NamNzuo+EzefCku4wuBRjHziqtbIRlcbWesD4yu/HH0idXrP D85y0OEu42x3TNfnykgRaF4Xie7B8er0XM5HXdoXz/rdf3TDg3YvAx+75xQ1/ixGcL+PRfuZ g7uF6xht5sIj7r2BnZ3ZzuUSpnk0KlyEBS6tI7vjhkfqY1LINKoZd3xjIyLL4wWBjUxaoAC+ dUAMTV9J9tACmnRkGchGVpzdC2N05DZyuucwwHssyR5TBcgGp0+Use3NAehXcN7vsGOuF529 g= X-IronPort-AV: E=Sophos;i="5.81,262,1610427600"; d="scan'208";a="40078075" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NHkw/nU03X5rsLEPPnwF6eH22GqWsm5zMpWpkGvRMGPWojcqF/8TLWFfkZvaLvxJ8GHGyXvZFCG4K0uMhM7D5Z2zdtDn1tJlfNnDqjjBMsVnRyMf++3JEdVSalsIBtgFYSiKHDq5aSBKKfS14/lGFccgnzl1T1/WVh3bdfPDpnGHUPx8PYDyxEsY3Qj9DAc2hKfjFtgRi6rDwNSWvP2R74vO67XXOo3W5heguYAxxLoh39HzgbWahdida4MmJe2/M6pxgM1HmNBRZ212SShH0LB4UcX9283vHkvS8kSLcqYCarCPP2NMaolnsUqAKu5ddi1Y8a+oQ463WNeQFWtB+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SikAD/si2SLckmDGNhPpWymn0rNwZdsyoiN1eJKVspw=; b=btwPyfscbPOkrjdObr+o/5jZkrH5FjAUebsFjVlRcqx3OshWdKLbjdywxSjdx42JTZ9kUb2mWmT82KYh8XAWcgTAMEqWBDUZNwe6N7PWbpY6T1FmLlLM0sP6bJIjPdBSrwxV8+z9b+yPDInO48geRhEsmDpdKuJkCa21+1uPK3fqbxwvlF42K+nBOnqXoGMz6Szl5WLsmOBabQhTWJ7g8Oe59vNXb6SruZ2nfhixcTutP4zAlEBlyJMDZr/jEh6KSQIxjOVlC+xToA4K5Ha6mZA6EVHitBSh4ErKFLZs7jpS4cHVnGkixictK0LQnTqTRVipYdNwAFRUpgIObgBeTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SikAD/si2SLckmDGNhPpWymn0rNwZdsyoiN1eJKVspw=; b=kvM5gz4+BbEVzpPF2Pqgjj3rt5V7XMHFLl0Z+pXBz3z32XJLYU+i3t7YXj09w8vyN9SDbD/m7bfSD/CP2ZQQwwPtD70G1BPsjZO5N4rw7IB3QWhG5O03/Kv9btrnY0cOM3XGXCv5IgmRglTM1YrmUQ9slHcUv9ocCH3nOx6o5Lw= Subject: Re: preparations for 4.13.3 To: Jan Beulich CC: George Dunlap , Stefano Stabellini , Ian Jackson , Wei Liu , Anthony Perard , Julien Grall , "xen-devel@lists.xenproject.org" References: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> <7b3a06af-103a-db05-b494-94f5a1081bc7@citrix.com> From: Andrew Cooper Message-ID: <4cbfc75d-2850-95a7-2de8-e9f76fd68336@citrix.com> Date: Fri, 19 Mar 2021 18:43:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0384.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::11) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ae431e8c-b6da-4500-1170-08d8eb06ed8f X-MS-TrafficTypeDiagnostic: BN6PR03MB2513: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mNvCQwO5a/0HcvBSbw75TEgduesIuzTFM74sl/DNn9sPdQtFvZdgsNRy3ppIqei1uY+E3b8216BxuvRFDsRa2c40J2cA2ZBRV5dUeRWlbbKcTW6tBjB51MlOk5mcZsjMry/8rpnm8rkFvhUOzSTjTAalI5KEPSyn+JxIboRwAJmuMbLSj940D2rhyMtt9YjQIBuSr7s00tMvBqEI5ZQWhL+O4P6NlqkfLGugg8/wRIqCTJhw20kH3M7GZCfvuFYsH/O/qDNxTQUMMNwagYsE0L5y+i6sqdPQ8SMmQbZ4zh4jY6mIi4GvnQY6M8nF6f8UWJ8pgsi9/L1/FXDI0Fm4iIEtPoPWjhk26SrQwvLL7SWmGzOwYcbUV0H+kytT917U4vUZZH6y+fIfGKRxG0GuWXw6ETNaYZ6QMZbA6T4H9/cg6KQPgawzUnDwMCxv4quPLnA3kvIldMa2famp2FDS2onpiYhOsAA2I5cskWzKhJDfGWpIkpPwPSmZorMO/V31dE3GWsm886hFQ+xYxTl8x/9R5YZPwuHtA/bsndMczVZp8jhrYiQlim/gdO4+eOgJZ7UmoOtCAsZT4uSczzqCn6zlKB6hDjLEmWMQSd+ozz0YOgKEhXu5I3haIf4tLjAu52hwmeOfOwT8Vu87kQd+5Lf1UOUZB+/UFxBX2Ql2F8XnD7iptA+sCgwiYSGnBc13ZZMSdjF/L9py2vy2IbkM//LvNkcKhQmeT0Omn2sY1x0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(396003)(346002)(136003)(39860400002)(2906002)(5660300002)(26005)(38100700001)(16526019)(186003)(6666004)(54906003)(6916009)(86362001)(6486002)(8676002)(66476007)(16576012)(36756003)(4326008)(31686004)(66556008)(66946007)(478600001)(8936002)(316002)(53546011)(7116003)(2616005)(956004)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?SjhaNEFPbVFiNW9VTFhHNElxb1hvVldYWW1ST2NXR2pweHpxWjBGZW9zOEVQ?= =?utf-8?B?SlZ6K1p6ZjR6Vmt1UmQrMkpweUkwSjZFcStLTkdVQkNnc3NFeUJaSzMrN3I3?= =?utf-8?B?aUxxMGtoTnNsRDVmckw4ZkI5bFN0RDFjNEE5ZGtGV3NndWpDd0czbVR6YlI0?= =?utf-8?B?SmJ1NTBBYnZ2QW9vUWNHQ3llT1AwNENoMzdXN0MzdXVFU0tHbkhqU1NiaHhK?= =?utf-8?B?Um5NU3k3UWZCMTV6R093cnJjM0hNUk1oT2p2M080N0U2RTJGMEIySkkxMy94?= =?utf-8?B?Y0swS1ZEKzlwYWFjZFlkOTcyV3pFVUNmRjdXVEhHWjg0MWZSM1BJaHZRUW9i?= =?utf-8?B?RnZOZGZCb29jSW9KT3prS2p0bmJiandzNjY5a2VOcFR1M0tsOW1tL1d5cHVZ?= =?utf-8?B?UGEwa2J0U2NhOEF6Y3VXTFRpVEgvNTlnY0s3WG02TGEyWndFK0t5T3pOd2sr?= =?utf-8?B?N1UzVlorblVyUEhhaDlDV2YzcTlrdHBMc2tRZEZPQ0lxYVNjYmFUUVdCTmJy?= =?utf-8?B?RXJiaG1CbEVPZDV0Tk8ybVdnQ290ZzQ3Nm9PQm9qMGVJRVJ0Y3JPU3BZbTFP?= =?utf-8?B?L0k4dVpQYTFIRTZ1YlhYV0p3VGR0akNMN2xBbzNwcm1qaCszM2hQWVdya2tH?= =?utf-8?B?Y2c3UUJEVGMvZ1lkRFNrZDRnMkovbnFnSGFXK2pNMFBwSUpPN25hbWZ6T2VQ?= =?utf-8?B?ZTRVSU4vbGN0NkR3SmgzWmdGMFYzU1lPTFpvRzNudk5jSy8rVVVibE4xQlhr?= =?utf-8?B?UkhFOUhJRlNHdm1RdU9JaUdISHlmalFpcGxVaE5JRjFYdmswZCtIWnBzaFBQ?= =?utf-8?B?djlVQUw4bW9BK0wvMlpObzkrVXM1ZTNhK1hqNlpnWlFQQXBhZkc0bU5EelFL?= =?utf-8?B?ckNESk5jOUxDQmlMY3U2bjJRbWNISDhCV1Y0ek1JWlZKdVZhd0pjU2o4TVVH?= =?utf-8?B?OVE0cVBLcGpMWGdlZTJKOStYaWVjODMzZWZMMS9SZDQzY3JZWU90aEdCbFZI?= =?utf-8?B?R3V2NjZCbisySXZkR1BFNnlLSE04S1hQdGd0L1M1S1dxZ2VaMnF1cHU0WDVV?= =?utf-8?B?Y2FqMHhJU0xSVGZDeUltWTUvZ1FZR3dXWXdDTG5qZGx1U2c5YWxhK000S3RM?= =?utf-8?B?QVNualB4TFUrb2ZzUko5Rzdmc3llbTZ3YmVOcU12d1pRV3dpS2Z1VW4zemd6?= =?utf-8?B?T3VweVRuNVljeDFYV09kbXhKcUNQMkJuanlOU2QybXFMMHBrT2p2NDNCaTJ3?= =?utf-8?B?amlFSEJLZzRQdlZWMUNNWWhDeUc4K0FZS3Z2c0FTVW5wQkJZUlJhUTdod3Fq?= =?utf-8?B?ZEc2c0dXY3NKVFJXSE11ejZMQlZneWRxaUxnbjB4ditqeGVGRml5VHFTYnRZ?= =?utf-8?B?OXJka04vQlBWY3VlclplQjJuM29lWFNQT3RIN0d3bnhBbG5ydGRHN1JJN1Jv?= =?utf-8?B?OUg2ZFVQTllPdU1MbFJCYm1jZU9sbndmVGp1OUI4OStUajNacnc1bTdGbVFa?= =?utf-8?B?cjlnbGdsc0w4eVFvendsdWkzV2FoeFdrYjgvaEhDZmNaN2NRM01yRzVlMjBq?= =?utf-8?B?OEVkeEhRcEF2NGRkTkJHd2VNWXZadHpvdEVsOHpLdjZhNlFIeElaTFcvSTBE?= =?utf-8?B?TkZxd2hENUNYa0gwQ2JpT3hPcVVROGk4T01nL0ljVGZqeGI0ZGZFNTUwTk1H?= =?utf-8?B?Vk43d1lHa0l2VDQxekladXl4Qkg1dnFYQTZqYWxRSmNqTUlMT002RVl5ajNv?= =?utf-8?Q?BVRjXIZ1CDyZkme+q05yRqJR3G55AEy4Ow+hcbI?= X-MS-Exchange-CrossTenant-Network-Message-Id: ae431e8c-b6da-4500-1170-08d8eb06ed8f X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 18:43:46.6599 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Rh4ytbRKK01qjaiLf1pCF8QZTmTbYscS3iPj9Ssm3yJx5qWXd7g+xS9tH38TU84Q9qBWzRSfGxZkL1A3Y56thQzRm6EwuNnVn62fUXOU3pg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2513 X-OriginatorOrg: citrix.com On 19/03/2021 14:02, Jan Beulich wrote: > On 19.03.2021 12:44, Andrew Cooper wrote: >> On 08/03/2021 09:49, Jan Beulich wrote: >>> the release is overdue (my apologies). Please point out backports >>> you find missing from the respective staging branches, but which >>> you consider relevant. >>> >>> Ones that I have queued already, but which hadn't passed the push >>> gate to master yet when doing a swipe late last week, are >>> >>> c6ad5a701b9a crypto: adjust rijndaelEncrypt() prototype for gcc11 >>> 9318fdf757ec x86/shadow: suppress "fast fault path" optimization without reserved bits >>> 60c0444fae21 x86/shadow: suppress "fast fault path" optimization when running virtualized >> fe36a173d110 - x86/amd: Initial support for Fam19h processors >> 90b014a6e6ec - x86/ucode/amd: Fix microcode payload size for Fam19 >> processors > For the latter one, didn't you indicate to me elsewhere that there > was still some uncertainty about the value? I'm attempting to get the number put somewhere helpful in documentation, but I'm fairly confident this is the correct number now. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 19 19:14:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 19:14:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99375.188970 (Exim 4.92) (envelope-from ) id 1lNKZu-00019K-5x; Fri, 19 Mar 2021 19:14:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99375.188970; Fri, 19 Mar 2021 19:14:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNKZu-00019D-2d; Fri, 19 Mar 2021 19:14:34 +0000 Received: by outflank-mailman (input) for mailman id 99375; Fri, 19 Mar 2021 19:14:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNKZs-000198-CG for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 19:14:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNKZs-000240-2P; Fri, 19 Mar 2021 19:14:32 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lNKZr-0007f6-Qh; Fri, 19 Mar 2021 19:14:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=JOhUg8bR9Vk5ydA3hCDnEtFp1auHpIkAhcpi/2PSF80=; b=DpruOTWrDeRGjyMt3nqOVnrwro NptjmFBI7c3Lez9NHL3Hc4KQGofTIMTJAMt/qHwLINXf39nSoqT7z6BGdwUeUJDMruWPSL6/eH9GY Qv0sX3ZcF/v8nD25poTkmpK46Qrl7jUU0Sbb0sdV6HrJlTyOPBTJulXfQdqZ74ho+eCk=; Subject: Re: [PATCH] xen/arm: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped To: Stefano Stabellini , Boris Ostrovsky Cc: jgross@suse.com, xen-devel@lists.xenproject.org, Stefano Stabellini References: <20210225235158.24001-1-sstabellini@kernel.org> <4707b219-eee1-22e8-8dd3-6b7d821de333@oracle.com> <47d6b423-5414-f14a-2730-74834bfa18f5@oracle.com> From: Julien Grall Message-ID: <93f1fd99-456e-f7d9-aeda-d69ef0738761@xen.org> Date: Fri, 19 Mar 2021 19:14:30 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Stefano, On 19/03/2021 17:53, Stefano Stabellini wrote: > On Fri, 19 Mar 2021, Boris Ostrovsky wrote: >> On 3/18/21 7:28 PM, Stefano Stabellini wrote: >>> >>> So, I'll follow you suggestion, keep the x86 side named as it is today, >>> and provide a tiny wrapper so that we can still have an arch-neutral >>> xen_swiotlb_detect function (on x86 just calls pci_xen_swiotlb_detect.) >> >> >> But now on x86 side we end up with a routine that noone calls. And pci_xen_swiotlb_detect() becomes not __init and so it will have to stick around after boot for no good reason. (You could have made it __ref btw). >> >> >> I think we should leave x86 alone. And if there is a declaration in include/xen/swiotlb-xen.h that's only relevant to ARM --- well, so be it. Or perhaps you can create arch/arm/include/asm/xen/swiotlb-xen.h > > Yeah I wanted to avoid creating arch/arm/include/asm/xen/swiotlb-xen.h If the header is going to be useed by arch/arm and arch/arm64, then it should be defined in include/xen/arm/ to avoid any packaging issue. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Mar 19 19:40:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 19:40:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99391.189034 (Exim 4.92) (envelope-from ) id 1lNKz0-0004EA-Sb; Fri, 19 Mar 2021 19:40:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99391.189034; Fri, 19 Mar 2021 19:40:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNKz0-0004E3-Pe; Fri, 19 Mar 2021 19:40:30 +0000 Received: by outflank-mailman (input) for mailman id 99391; Fri, 19 Mar 2021 19:40:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNKyy-0004Dx-UL for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 19:40:28 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f7fc75cf-206c-44e0-9bf5-42b82bf637f9; Fri, 19 Mar 2021 19:40:28 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 264AD61970; Fri, 19 Mar 2021 19:40:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7fc75cf-206c-44e0-9bf5-42b82bf637f9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616182827; bh=T7flvrSgdHXO3f/MiGIVzYZs0Fury6+UcbBVEbxOjEM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=CnKfQ4BeVPDGMUTUafutFmXqQSlXx5hXQ4X/Kl6/bJwSVa4i47uFc9XIP53XVVoQV HULVXseGb4hu8D8s4QeFYmOZb5bnVZ6pNj8lRIIAfdxXpoN8JVb6YGag1gGwXQEGMh +NqpNVl1xEMpjxtWr1wECavrRR48gxRGeRW7iRMAEJratA8QeCF+D6nYbnM3hShoVD 068tRl6jDuEDQgYB6oyEvQ5UBpdgjq9yfPds1x6BTZ16i+oP7KgFslhgmZc8vFQCq8 SnWgd3ahTZkNM9W3mcU4HJ6Gs4JU547qBvzKj8r2J+ZbSBjePIflHVGflReV13E4pS OeNTeEdu0zDhA== Date: Fri, 19 Mar 2021 12:40:26 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall cc: Jan Beulich , "xen-devel@lists.xenproject.org" , Stefano Stabellini , George Dunlap , Ian Jackson , Wei Liu , Anthony Perard Subject: Re: preparations for 4.13.3 In-Reply-To: Message-ID: References: <5373f9d5-fc03-1967-8181-d77bbdaf25b9@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sat, 13 Mar 2021, Julien Grall wrote: > Hi Jan & Stefano, > > On 08/03/2021 09:49, Jan Beulich wrote: > > All, > > > > the release is overdue (my apologies). Please point out backports > > you find missing from the respective staging branches, but which > > you consider relevant. > > > Ones that I have queued already, but which hadn't passed the push > > gate to master yet when doing a swipe late last week, are > > > > c6ad5a701b9a crypto: adjust rijndaelEncrypt() prototype for gcc11 > > 9318fdf757ec x86/shadow: suppress "fast fault path" optimization without > > reserved bits > > 60c0444fae21 x86/shadow: suppress "fast fault path" optimization when > > running virtualized > > I would like to also consider the following one: > > 28804c0ce9fd SUPPORT.MD: Clarify the support state for the Arm SMMUv{1, 2} > drivers (4.11+ as updating the security support) > 067935804a8e xen/vgic: Implement write to ISPENDR in vGICv{2, 3} (4.13+) > To support newer kernel on stable Xen > d81133d45d81 xen/arm: Add workaround for Cortex-A53 erratum #843419 (4.13+) > fd7479b9aec2 xen/arm: Add workaround for Cortex-A55 erratum #1530923 (4.13+) > 5505f5f8e7e8 xen/arm: Add Cortex-A73 erratum 858921 workaround (4.13+) > 63b4c9bfb788 xen/arm: mm: Access a PT entry before the table is unmapped (4.13 > only) > f6790389613c xen/arm: sched: Ensure the vCPU context is seen before > vcpu_pause() returns (4.13 only) > > I have put in parentheses the list of versions targeted. Thanks that was very helpful. I took care of those commits plus a couple of others: 934bb4c87cf2 xen/arm: Document the erratum #853709 related to Cortex A72 a702c80ec193 xen/arm: call iomem_permit_access for passthrough devices 2fb361c36aa9 xen/arm: mm: Remove ; at the end of mm_printk() 284aed024f58 xen/arm: vgic-v3: fix GICD_ISACTIVER range From xen-devel-bounces@lists.xenproject.org Fri Mar 19 20:01:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 20:01:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99401.189074 (Exim 4.92) (envelope-from ) id 1lNLJX-0006Qc-Ug; Fri, 19 Mar 2021 20:01:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99401.189074; Fri, 19 Mar 2021 20:01:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNLJX-0006QV-RV; Fri, 19 Mar 2021 20:01:43 +0000 Received: by outflank-mailman (input) for mailman id 99401; Fri, 19 Mar 2021 20:01:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNLJX-0006QQ-BU for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 20:01:43 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9566f02b-5b90-4b07-941e-abee63570c39; Fri, 19 Mar 2021 20:01:42 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 79FDA61976; Fri, 19 Mar 2021 20:01:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9566f02b-5b90-4b07-941e-abee63570c39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616184101; bh=spE54JSHaVmbOM/94skCFsybasDYxZUijV8bIpX+UK8=; h=From:To:Cc:Subject:Date:From; b=f8gc5ta3rUp2wkMTeobyuvq6qTK6gD6Nv04MpCS9HQG4QBt+FYZzd5MJLxUD5YWWv TMUGfbb1I0ZcJ8mwVlFa4yTAGmXi/zpwz1V3+KOhUI0wfIxoZE31Ux8YTvT8PAgaT2 mS4q+CAp1ZFAgtrkE+b3m8SxA4ECCaSC6YN6KuvGY/t3geL2x9rdb2m/NlQIrR7uLG iIdhPpPecj6JhkFQFIqQlrYoIOlGXNzh3YlhN75llevocVGxf2dBpHGWmcaDSBuyVK VifwQfrij4Mq+ImooaSs4xidvqP5z7+FKxiswuzCCFvXpy1Q4oVB7DKDFgivjLM1nz QwKJne6AiDsWg== From: Stefano Stabellini To: boris.ostrovsky@oracle.com Cc: jgross@suse.com, sstabellini@kernel.org, xen-devel@lists.xenproject.org, Stefano Stabellini Subject: [PATCH v3] xen/arm: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped Date: Fri, 19 Mar 2021 13:01:40 -0700 Message-Id: <20210319200140.12512-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 From: Stefano Stabellini Newer Xen versions expose two Xen feature flags to tell us if the domain is directly mapped or not. Only when a domain is directly mapped it makes sense to enable swiotlb-xen on ARM. Introduce a function on ARM to check the new Xen feature flags and also to deal with the legacy case. Call the function xen_swiotlb_detect. Signed-off-by: Stefano Stabellini --- Changes in v3: - remove any x86 changes - introduce asm/xen/swiotlb-xen.h for arm --- arch/arm/include/asm/xen/swiotlb-xen.h | 1 + arch/arm/xen/mm.c | 14 +++++++++++++- arch/arm64/include/asm/xen/swiotlb-xen.h | 1 + arch/arm64/mm/dma-mapping.c | 2 +- include/xen/arm/swiotlb-xen.h | 7 +++++++ include/xen/interface/features.h | 14 ++++++++++++++ include/xen/swiotlb-xen.h | 1 + 7 files changed, 38 insertions(+), 2 deletions(-) create mode 100644 arch/arm/include/asm/xen/swiotlb-xen.h create mode 100644 arch/arm64/include/asm/xen/swiotlb-xen.h create mode 100644 include/xen/arm/swiotlb-xen.h diff --git a/arch/arm/include/asm/xen/swiotlb-xen.h b/arch/arm/include/asm/xen/swiotlb-xen.h new file mode 100644 index 000000000000..455ade5d5320 --- /dev/null +++ b/arch/arm/include/asm/xen/swiotlb-xen.h @@ -0,0 +1 @@ +#include diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c index 467fa225c3d0..e1b12b242a32 100644 --- a/arch/arm/xen/mm.c +++ b/arch/arm/xen/mm.c @@ -135,10 +135,22 @@ void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order) return; } +int xen_swiotlb_detect(void) +{ + if (!xen_domain()) + return 0; + if (xen_feature(XENFEAT_direct_mapped)) + return 1; + /* legacy case */ + if (!xen_feature(XENFEAT_not_direct_mapped) && xen_initial_domain()) + return 1; + return 0; +} + static int __init xen_mm_init(void) { struct gnttab_cache_flush cflush; - if (!xen_initial_domain()) + if (!xen_swiotlb_detect()) return 0; xen_swiotlb_init(1, false); diff --git a/arch/arm64/include/asm/xen/swiotlb-xen.h b/arch/arm64/include/asm/xen/swiotlb-xen.h new file mode 100644 index 000000000000..455ade5d5320 --- /dev/null +++ b/arch/arm64/include/asm/xen/swiotlb-xen.h @@ -0,0 +1 @@ +#include diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c index 93e87b287556..4bf1dd3eb041 100644 --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -53,7 +53,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size, iommu_setup_dma_ops(dev, dma_base, size); #ifdef CONFIG_XEN - if (xen_initial_domain()) + if (xen_swiotlb_detect()) dev->dma_ops = &xen_swiotlb_dma_ops; #endif } diff --git a/include/xen/arm/swiotlb-xen.h b/include/xen/arm/swiotlb-xen.h new file mode 100644 index 000000000000..2994fe6031a0 --- /dev/null +++ b/include/xen/arm/swiotlb-xen.h @@ -0,0 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_ARM_SWIOTLB_XEN_H +#define _ASM_ARM_SWIOTLB_XEN_H + +extern int xen_swiotlb_detect(void); + +#endif /* _ASM_ARM_SWIOTLB_XEN_H */ diff --git a/include/xen/interface/features.h b/include/xen/interface/features.h index 6d1384abfbdf..5a7bdefa06a8 100644 --- a/include/xen/interface/features.h +++ b/include/xen/interface/features.h @@ -83,6 +83,20 @@ */ #define XENFEAT_linux_rsdp_unrestricted 15 +/* + * A direct-mapped (or 1:1 mapped) domain is a domain for which its + * local pages have gfn == mfn. If a domain is direct-mapped, + * XENFEAT_direct_mapped is set; otherwise XENFEAT_not_direct_mapped + * is set. + * + * If neither flag is set (e.g. older Xen releases) the assumptions are: + * - not auto_translated domains (x86 only) are always direct-mapped + * - on x86, auto_translated domains are not direct-mapped + * - on ARM, Dom0 is direct-mapped, DomUs are not + */ +#define XENFEAT_not_direct_mapped 16 +#define XENFEAT_direct_mapped 17 + #define XENFEAT_NR_SUBMAPS 1 #endif /* __XEN_PUBLIC_FEATURES_H__ */ diff --git a/include/xen/swiotlb-xen.h b/include/xen/swiotlb-xen.h index d5eaf9d682b8..dbc4a4b785f6 100644 --- a/include/xen/swiotlb-xen.h +++ b/include/xen/swiotlb-xen.h @@ -3,6 +3,7 @@ #define __LINUX_SWIOTLB_XEN_H #include +#include void xen_dma_sync_for_cpu(struct device *dev, dma_addr_t handle, size_t size, enum dma_data_direction dir); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Mar 19 21:04:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 21:04:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99408.189088 (Exim 4.92) (envelope-from ) id 1lNMI7-0003fY-T6; Fri, 19 Mar 2021 21:04:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99408.189088; Fri, 19 Mar 2021 21:04:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNMI7-0003fR-Ps; Fri, 19 Mar 2021 21:04:19 +0000 Received: by outflank-mailman (input) for mailman id 99408; Fri, 19 Mar 2021 21:04:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNMI6-0003fJ-Ft; Fri, 19 Mar 2021 21:04:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNMI6-000435-6l; Fri, 19 Mar 2021 21:04:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNMI5-0003DH-OO; Fri, 19 Mar 2021 21:04:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNMI5-0002d9-Nx; Fri, 19 Mar 2021 21:04:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nnKyN8HC03R8t3YGCMQ1v9od9uixGRKH2xmXqqgqxz4=; b=q2E/gJIHyTsZb8tza2RKnVQLJm 9jm5ZTZoqGurNTyJtsZkdOd1sFcIuOgXuKr1JXMtJ1zjJz7SwnaL5P3RxvkFgwKtmHVUzYSUnpacq THQQMNFn9/mDXQsSt4OqybgWMh4uMdlK1+uMP74YATXtyWH6jIc5DIGJoBi8mwAx7ho4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160132: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=bf152b0b41dc141c8d32eb6e974408f5804f4d00 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Fri, 19 Mar 2021 21:04:17 +0000 flight 160132 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160132/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux bf152b0b41dc141c8d32eb6e974408f5804f4d00 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 231 days Failing since 152366 2020-08-01 20:49:34 Z 230 days 399 attempts Testing same since 160132 2021-03-18 19:12:01 Z 1 days 1 attempts ------------------------------------------------------------ 5219 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1294478 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Mar 19 23:00:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 19 Mar 2021 23:00:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99419.189104 (Exim 4.92) (envelope-from ) id 1lNO6P-0006Of-LN; Fri, 19 Mar 2021 23:00:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99419.189104; Fri, 19 Mar 2021 23:00:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNO6P-0006OY-IB; Fri, 19 Mar 2021 23:00:21 +0000 Received: by outflank-mailman (input) for mailman id 99419; Fri, 19 Mar 2021 23:00:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNO6N-0006OT-BC for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 23:00:19 +0000 Received: from aserp2130.oracle.com (unknown [141.146.126.79]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 48df2e68-4d2a-4620-9c73-fe644e4389c1; Fri, 19 Mar 2021 23:00:18 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12JN0GpG068496; Fri, 19 Mar 2021 23:00:16 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 378jwbvj5q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Mar 2021 23:00:16 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12JMxkif097195; Fri, 19 Mar 2021 23:00:15 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173]) by userp3020.oracle.com with ESMTP id 37cf2caf3k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Mar 2021 23:00:15 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BYAPR10MB2631.namprd10.prod.outlook.com (2603:10b6:a02:ac::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.23; Fri, 19 Mar 2021 23:00:12 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3955.023; Fri, 19 Mar 2021 23:00:12 +0000 Received: from [10.74.102.27] (138.3.201.27) by BYAPR07CA0038.namprd07.prod.outlook.com (2603:10b6:a03:60::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Fri, 19 Mar 2021 23:00:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48df2e68-4d2a-4620-9c73-fe644e4389c1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=oEXYc3RG3bs8i4IIp7BuuahetRs8esN7ZssVDIZ35Ns=; b=Ta5THl58Ud1NPKvRLG5aZrNZfrNdhu25fFHU8b4GUbXhZFKHolk6difTqXpu7qPIj9My UhAEnSap7lHzjdGvIRZEx79h02HA9rCzUvJAHGyus7KuJH46U96tpTZzOMhbB53dltdV JVaVor9scSCgGYaJHz3YPVgIteLECKlhRanzTrrUTmbrzNyU1q/DBXHapmi2HEoQWVrA usaFob7WhgQwJtXP8LgCznn6CqEwyJaKl7oCLUvJ6ounOcLnu7Od9h0JyimZfh3GpW+Z TI/laDRaDnTVpbIPf0FFYgVgQMXBfoCPf0c7hjGUJkUNcdZ4icjbcha7GuF0rjO5D568 KQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=avZCpA5/Ng1RWExGr+750ev24BxNZXrIJ5zHKFqpi37wrVSykzWg4GcN1w1Hp59O+OZv18tW1SijBrsG+CcBb/HsY5AqT0/7IDXt4XUz69rFNy0DJkXLFQ3JmCi4t5H0OK7Uj/cVyOli1c9Rm5tmbZ2gIpzCAXM1Khkbm1VZg+PaQwThW0myh+DNfEJCznjLa2chfWdL6OawbjsunNGzSU/JqOAP2yLtZ/1JY8ffTseEc9DXZ/U50E9bCSQFa5L9TVqe8VWpf6grPxMN9ZxwSEkbJqLA2B8mNUY87d0CWDWn7eThZj0MMfIx6H7X9lOQi906EgIsycXSeilxiyfnkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oEXYc3RG3bs8i4IIp7BuuahetRs8esN7ZssVDIZ35Ns=; b=FeNyMeVqLnaGdjZ3XhTRUKUSgZ1AA2IkLs4lgQKiEH0yV7+iDg+rVVNNFqKDTu9qjN3xyVhMgUBB/iW9yi7DAFDPglHMpdqoK8vDPiWjHUqOq+so3vc51MXDb7fkaiRxFkLO9wBqv+oca2/Do0aNZCRQ6w5ZuWTna1k4Q0kZ9LyaiAzO8J9As9diw7hwGcH2miTbTn+shlp4RaJZb0sP9aZzMbQUYhYtBGuOroGB2DUn/zPriNXXmwKb3RLoSge2n9JnUC2mVE6Nt1yCyDAV0PUoZalC1OjyFTWgOuM3V7R2SQ87A+Qh+g5vtRHYTh4dTh8ttpWyJtjMbVyxWy9LRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oEXYc3RG3bs8i4IIp7BuuahetRs8esN7ZssVDIZ35Ns=; b=rTHnMblV+CsL7q/f58K3uAa29qvQNlsfCYo0+ZIJxLYedNK2rh1VGeBLYJ49IyhidVhOWLhEYAfpWvN5VrNtIPVW3fSExUqt1uVO5FJCn2Ff6BeyhIY3ii/ytZI0DJc3SCVxPrulnwN5UhPWTpwtz93di/NJ8cH7J6F6dKD0Mx0= Authentication-Results: xilinx.com; dkim=none (message not signed) header.d=none;xilinx.com; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH v3] xen/arm: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped To: Stefano Stabellini Cc: jgross@suse.com, xen-devel@lists.xenproject.org, Stefano Stabellini References: <20210319200140.12512-1-sstabellini@kernel.org> From: Boris Ostrovsky Message-ID: Date: Fri, 19 Mar 2021 19:00:07 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210319200140.12512-1-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [138.3.201.27] X-ClientProxiedBy: BYAPR07CA0038.namprd07.prod.outlook.com (2603:10b6:a03:60::15) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 19e62573-fa8a-4da1-8688-08d8eb2ac043 X-MS-TrafficTypeDiagnostic: BYAPR10MB2631: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2512; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bg+FA5UaHIoWMwUYv3Mc8suMf7sF+p0zMSbQ3u4cIHbt9ma7mSsUeZq5GlrE8s+L+IEDhhUKDiV+cE+VBBJ+IzKpsgqIp1n+ISPWsN/k5FFhS/Uhg8AjnJplQzIG61AhoIHawC0TwDl1ZATAREfbFSKnpsiPHbNuR666DWjQAjJR+71s0s2zo+V1hfnap9FZCp5Ihspzm6CtbDzdJlPO1EqI4MTSIid9F476h7+edzb4j1j24mJygLIsEFloaql3V+XZMm5sYWP/0fDDA97gpqfDahOamUawrSsceOfsDcJ/dyyJvOUakBTKEOqyYSyB01kE5Y06VHD7uLHW8QSS5JocUuZSU4OQxFoi4EI1B2u7tty+Qjt+mBlA1L/u/i/hqAwr9V6OeuLJ9DUS7vXMQyTTdz7WcI++CLWKmjAE3fTgsMdUsjahTxuobLL7b0i/G+HxQyIIbLJrnHprRpTtobw/WvXcH2DfyIGcdNhDTStMoW4/qcbZ6q0/91W9jzBH8p/oAKL1PyrqyDGE5hVnxDDHxwY5WZJu//wRX3utAt6Dn9EkHBrvQtrdcPHyzrluiK1Drc2AUfqrrFxh/TH1o8Gl/uIwiM5DgFzil0yL05a/F4ZOxdZmrUuOkjjjtj2BwsZbcAL84zHAHGZqlroJ2GDKTrnVeWylXtJZpGVt5FhExYZEM8GbBMpjGHbAyhds377CwpicZAuQqR7xa/tdlHXJ1XladNLgkj4sclA+hDo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(396003)(39860400002)(346002)(366004)(376002)(53546011)(83380400001)(4744005)(5660300002)(31686004)(26005)(38100700001)(186003)(2906002)(16526019)(66946007)(956004)(2616005)(4326008)(66476007)(16576012)(86362001)(44832011)(6916009)(36756003)(8936002)(6486002)(31696002)(6666004)(316002)(8676002)(66556008)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Z1l2cFVWc0d2VzY4VlBBK0JXSFkvMERyYldvNVlGR2RzMUZvYzEvY0pUTjVz?= =?utf-8?B?RVNLbE9EOVM0em9sMDBrZFJ6QkFZd1lFSDBwMTVSUFNYVFNoMThsWVBZUmgw?= =?utf-8?B?MEVDSmt2TGl2OFpkWE5WMitUTUI3Vk9Ga2dDeVd2QnJCVlF3aHVCRy9XS1Aw?= =?utf-8?B?SHd6dHlTZ1p2ckRvcUdaSFF5d3NqeXVUYkIrZnJpMWNka2hUV0tkWjQ5eFBj?= =?utf-8?B?K2xUbVMwWXBERlduYkcrbG9jMmRDRnkzV1BxT2FqRXAzWW5GdGtmR0p5enFZ?= =?utf-8?B?dEpZYWc4bkNNRGZXYVd4cUloSXpHMW9yOUw4S3VGYnYwNDFjOXIwUWx3UEtv?= =?utf-8?B?VXh5dURjbUIzMVlNVkFDeE50SlBwbE1hamwyNjJYTHVhcmJWZE0zWXNqYmg2?= =?utf-8?B?T3VsNHhXM2l1ejRXRnZqVHlXMjNFRnBNdnlPYXgrakNGQldFWE5teFR1Z2tY?= =?utf-8?B?QkFUNXRPRi9hOHpvL1dZSUMrYmNPc0ZUbGw1SUN4QWxweDlXY3puWGozWE16?= =?utf-8?B?TXhkdWFTQVhiakdKc09FYVVYdy9RL2ZsZkFQQUJ5UHpoZnl0cXVDTHR6Yity?= =?utf-8?B?bUh2RExaa0ZYU1ZxVTByWVIxemlBTzBUMEp6WXR5dmhLb3FJOVovY212bTZD?= =?utf-8?B?SHFMQUZCaFlrMHdCU2dWc3hHM01kTUFoWGFENUg2Y1R3YitEbDJrUmpZMXhi?= =?utf-8?B?TzlZZHBkTFJrdHJvYk9sY2hENVJuL05tSnhqSU1mRFk1RithSVZ0aGp1STZL?= =?utf-8?B?cEp5bGltcHhzcHFYZDRZRkhzYTdWMmE2d2s2d0MwYWNYekVyZWdETnJEZ0lj?= =?utf-8?B?c2FON0dlZkovYWlTdE1INk5CWHlqVHovOUhYWTFXeVlYQTZDNDZVQVNYOWZ3?= =?utf-8?B?d1dmZC9yamxMc2ozWDdDR1NUVnRMU0ltWm5FY2JKcU5MSDVmVzlLOVFYWkd1?= =?utf-8?B?THBGTkZDb3ZVSGU0SnRGRmp1Sk1ZMEVXWlY1YmhNajM5UXNzN0FwV0sxblZN?= =?utf-8?B?OVpYSHMxQWpGRkpBS3NwbEwrcDZCaE5Fd0lLMStSR0VRUCtOQVNtVjZsbGVJ?= =?utf-8?B?eDZBYjJTZlFQYnBzV3JxU3k2YnpMN0FzQkhTQ3dKNkJCeTMweUd4WGRVV3NW?= =?utf-8?B?YnllVVVDWXdKR3dLWFN4Z2k0NVlDSm4zYWdNTUFScjZrVy9KRWN1ZE5PbnZ6?= =?utf-8?B?b3g3c2JwbENXVlE4S0l2MkxqRkh0cFhrWmY4bWhRUlRRTkJBNnJaVmp1WGhF?= =?utf-8?B?V3ljWDVXVmtiSGpETHRiWld6U1IrcmRCSXlQSzNGZTFGNjFhaFltZEpoc2hR?= =?utf-8?B?dEtqRjFlY0tKWGhTZmREVnRzaVBQcGsveFpJUlRQbS84VjZpVW1hQlBaeG55?= =?utf-8?B?OVlMWmVXdC9ub3lMNXhGUlA0MHM4RURFWkpSK1piUnFOa3Qrb3hOVHEyZjF3?= =?utf-8?B?UUZ1ZW11bEVNbW00RGk4UTNqVG8ycVJoamEvZ3JnY2pDdi9PSmpEaVluek5O?= =?utf-8?B?cmQvRHZZVEo0Unl0UUFaSG9rd1VBUml3bmN3QnlPcC9MU3pkZlU2S2E5aXph?= =?utf-8?B?UkxBa1BRbzZGeTByVjhSSFpPWHJuS2QvbTRNN3dvV3M4RDl0ODUzRGIrMGFH?= =?utf-8?B?aDVxdFl6VXUzaElGcEVob0JncHB4Qzd4NWhiL0ljT0VNWFR0MndUYzhBSGww?= =?utf-8?B?dHN1YVhKcXk4QWNLSkJ2ekdybVFXaW9mU0hNd2UzOEhVNnhKRkFyVjdCajcv?= =?utf-8?Q?s7vYDfiFXWBo4qH0bnlTsi2w4mm5RLrxmdaE8bk?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19e62573-fa8a-4da1-8688-08d8eb2ac043 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 23:00:12.2018 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hM8YTuRyfk6bdDqFyr4suOscSJp/PN7bMsqqDOxHB5zE876QLCiuXxn1sj3j1Fs0eupqxIdHfcvTt+hJ+HYiFRepw9tphWHY+nN2jacMhzA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2631 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9928 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103190159 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9928 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 adultscore=0 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103190159 On 3/19/21 4:01 PM, Stefano Stabellini wrote: > From: Stefano Stabellini > > Newer Xen versions expose two Xen feature flags to tell us if the domain > is directly mapped or not. Only when a domain is directly mapped it > makes sense to enable swiotlb-xen on ARM. > > Introduce a function on ARM to check the new Xen feature flags and also > to deal with the legacy case. Call the function xen_swiotlb_detect. > > Signed-off-by: Stefano Stabellini Reviewed-by: Boris Ostrovsky From xen-devel-bounces@lists.xenproject.org Sat Mar 20 00:02:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 20 Mar 2021 00:02:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99423.189116 (Exim 4.92) (envelope-from ) id 1lNP3m-0004FN-Im; Sat, 20 Mar 2021 00:01:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99423.189116; Sat, 20 Mar 2021 00:01:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNP3m-0004FG-Fc; Sat, 20 Mar 2021 00:01:42 +0000 Received: by outflank-mailman (input) for mailman id 99423; Sat, 20 Mar 2021 00:01:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNP3k-0004Ev-8l for xen-devel@lists.xenproject.org; Sat, 20 Mar 2021 00:01:40 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8328651e-14e6-4a21-aab4-a1991100ec93; Sat, 20 Mar 2021 00:01:38 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 5078C6197D; Sat, 20 Mar 2021 00:01:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8328651e-14e6-4a21-aab4-a1991100ec93 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616198497; bh=ApYMVxKR/77D/IWKJUkM2y6g8Yf3Vz+ZW156dJIj5QQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=rZiYRQsYtykbOkA2a2FEENGLjKgE/U1VHIFjVeFKJx95o2XXcvrJM9UpPDqVhrszq WMOaX3t0WFbAF6KS8q+Vq8qwO+KsVlj5Bu8pPut1jSQp6o95wi2PArPhBdPUOzta7f +vhu3plDxSPV2K3MwyRE8YG2BW9REKTGqqN1DvdNf3/+26RfMs9iz6PEXmM4rPGaAK wWaTLJarGb8eXo05G6f1iboikZGAoEtW+v5UEai0OrzRxf2rf8vmWxaCrKeK2837+f Pj/Uvyem/f4U84utmqKBo3m/s9wztLR21aYaUxLVuG8QMUVaGvCzITGS0FEWru9Kh9 Au/BvwFLFj4TQ== Date: Fri, 19 Mar 2021 17:01:36 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall cc: Stefano Stabellini , xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, ash.j.wilding@gmail.com, Julien Grall , Volodymyr Babchuk , Dario Faggioli , George Dunlap Subject: Re: [PATCH] xen/arm: Ensure the vCPU context is seen before clearing the _VPF_down In-Reply-To: Message-ID: References: <20210226205158.20991-1-julien@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sat, 27 Feb 2021, Julien Grall wrote: > (+ Dario and George) > > Hi Stefano, > > I have added Dario and George to get some inputs from the scheduling part. > > On 27/02/2021 01:58, Stefano Stabellini wrote: > > On Fri, 26 Feb 2021, Julien Grall wrote: > > > From: Julien Grall > > > > > > A vCPU can get scheduled as soon as _VPF_down is cleared. As there is > > > currently not ordering guarantee in arch_set_info_guest(), it may be > > > possible that flag can be observed cleared before the new values of vCPU > > > registers are observed. > > > > > > Add an smp_mb() before the flag is cleared to prevent re-ordering. > > > > > > Signed-off-by: Julien Grall > > > > > > --- > > > > > > Barriers should work in pair. However, I am not entirely sure whether to > > > put the other half. Maybe at the beginning of context_switch_to()? > > > > It should be right after VGCF_online is set or cleared, right? > > vcpu_guest_context_t is variable allocated on the heap just for the purpose of > this call. So an ordering with VGFC_online is not going to do anything. > > > So it > > would be: > > > > xen/arch/arm/domctl.c:arch_get_info_guest > > xen/arch/arm/vpsci.c:do_common_cpu_on > > > > But I think it is impossible that either of them get called at the same > > time as arch_set_info_guest, which makes me wonder if we actually need > > the barrier... > arch_get_info_guest() is called without the domain lock held and I can't see > any other lock that could prevent it to be called in // of > arch_set_info_guest(). > > So you could technically get corrupted information from > XEN_DOMCTL_getvcpucontext. For this case, we would want a smp_wmb() before > writing to v->is_initialised. The corresponding read barrier would be in > vcpu_pause() -> vcpu_sleep_sync() -> sync_vcpu_execstate(). > > But this is not the issue I was originally trying to solve. Currently, > do_common_cpu_on() will roughly do: > > 1) domain_lock(d) > > 2) v->arch.sctlr = ... > v->arch.ttbr0 = ... > > 3) clear_bit(_VFP_down, &v->pause_flags); > > 4) domain_unlock(d) > > 5) vcpu_wake(v); > > If we had only one pCPU on the system, then we would only wake the vCPU in > step 5. We would be fine in this situation. But that's not the interesting > case. > > If you add a second pCPU in the story, it may be possible to have vcpu_wake() > happening in // (see more below). As there is no memory barrier, step 3 may be > observed before 2. So, assuming the vcpu is runnable, we could start to > schedule a vCPU before any update to the registers (step 2) are observed. > > This means that when context_switch_to() is called, we may end up to restore > some old values. > > Now the question is can vcpu_wake() be called in // from another pCPU? AFAICT, > it would be only called if a given flag in v->pause_flags is cleared (e.g. > _VFP_blocked). But can we rely on that? > > Even if we can rely on it, v->pause_flags has other flags in it. I couldn't > rule out that _VPF_down cannot be set at the same time as the other _VPF_*. > > Therefore, I think a barrier is necessary to ensure the ordering. > > Do you agree with this analysis? Yes, I think this makes sense. The corresponding barrier in the scheduling code would have to be after reading _VPF_down and before reading v->arch.sctlr, etc. > > > The issues described here is also quite theoritical because there are > > > hundreds of instructions executed between the time a vCPU is seen > > > runnable and scheduled. But better be safe than sorry :). > > > --- > > > xen/arch/arm/domain.c | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > > > index bdd3d3e5b5d5..2b705e66be81 100644 > > > --- a/xen/arch/arm/domain.c > > > +++ b/xen/arch/arm/domain.c > > > @@ -914,7 +914,14 @@ int arch_set_info_guest( > > > v->is_initialised = 1; > > > if ( ctxt->flags & VGCF_online ) > > > + { > > > + /* > > > + * The vCPU can be scheduled as soon as _VPF_down is cleared. > > > + * So clear the bit *after* the context was loaded. > > > + */ > > > + smp_mb(); > > From the discussion above, I would move this barrier before v->is_initialised. > So we also take care of the issue with arch_get_info_guest(). > > This barrier also can be reduced to a smp_wmb() as we only expect an ordering > between writes. > > The barrier would be paired with the barrier in: > - sync_vcpu_execstate() in the case of arch_get_vcpu_info_guest(). > - context_switch_to() in the case of scheduling (The exact barrier is TDB). OK, this makes sense, but why before: v->is_initialised = 1; instead of right after it? It is just v->pause_flags we care about, right? > > > clear_bit(_VPF_down, &v->pause_flags); > > > + } > > > else > > > set_bit(_VPF_down, &v->pause_flags); > > > From xen-devel-bounces@lists.xenproject.org Sat Mar 20 00:29:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 20 Mar 2021 00:29:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99427.189128 (Exim 4.92) (envelope-from ) id 1lNPUf-0006NG-L7; Sat, 20 Mar 2021 00:29:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99427.189128; Sat, 20 Mar 2021 00:29:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNPUf-0006N9-HQ; Sat, 20 Mar 2021 00:29:29 +0000 Received: by outflank-mailman (input) for mailman id 99427; Sat, 20 Mar 2021 00:29:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNPUe-0006N1-U0; Sat, 20 Mar 2021 00:29:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNPUe-00084s-Mf; Sat, 20 Mar 2021 00:29:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNPUe-0006Jr-BO; Sat, 20 Mar 2021 00:29:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNPUe-0008JF-AA; Sat, 20 Mar 2021 00:29:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0X+7iZUgddyXMr62HChU4L8Dmp9rKornXh/ABWh+PzQ=; b=Ak6VFyJroeKT/sAdDSNR63Nj2o fjPyxY59IxzcRlchUbuPnxYyQ8H4OTmph2RVYD4SOyPIBVQOpL2DKTmVqd5gnx/EACI1C+oJDyX0B kzpGKyRIPaNOxiDqheyYmK37fkWiNd6as4ydVsSdXrM39XY6aTFPv1lsq+H9mfx/n+oU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160134: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=8a40754bca14df63c6d2ffe473b68a270dc50679 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sat, 20 Mar 2021 00:29:28 +0000 flight 160134 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160134/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 8a40754bca14df63c6d2ffe473b68a270dc50679 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 211 days Failing since 152659 2020-08-21 14:07:39 Z 210 days 407 attempts Testing same since 160134 2021-03-19 02:11:07 Z 0 days 1 attempts ------------------------------------------------------------ 461 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 133143 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 20 04:10:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 20 Mar 2021 04:10:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99447.189146 (Exim 4.92) (envelope-from ) id 1lNSvz-0003uP-83; Sat, 20 Mar 2021 04:09:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99447.189146; Sat, 20 Mar 2021 04:09:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNSvz-0003uG-1f; Sat, 20 Mar 2021 04:09:55 +0000 Received: by outflank-mailman (input) for mailman id 99447; Sat, 20 Mar 2021 04:09:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNSvx-0003u8-NX; Sat, 20 Mar 2021 04:09:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNSvx-0005GU-Da; Sat, 20 Mar 2021 04:09:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNSvx-0000DH-1u; Sat, 20 Mar 2021 04:09:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNSvx-0005U2-0w; Sat, 20 Mar 2021 04:09:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ds4K4hBpYW5hS6R2WZNfLx/GfJpPGzELabhrmQv7anU=; b=zSZNa09Zmhz1MPyYE4mmiUxwfE z+o0oMxILfruWLuGdIXhFNjoKX5QWoR+k1LwJGYlrKfyLQ95Hw7MN7dhx81khNvojQY4KZ2STqibn 7JIhKHD1NF32ag1sK8yvb5vPdQl+WxLTrwlwb4mbV/5OS3CGfF5Fll65P1nlpbjml5D4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160139: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b8737d236e525315504fc7b271de21101288d67f X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Sat, 20 Mar 2021 04:09:53 +0000 flight 160139 xen-4.12-testing real [real] flight 160149 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160139/ http://logs.test-lab.xenproject.org/osstest/logs/160149/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail REGR. vs. 159418 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen b8737d236e525315504fc7b271de21101288d67f baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 31 days Testing same since 160128 2021-03-18 14:36:18 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Jan Beulich Olaf Hering jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit b8737d236e525315504fc7b271de21101288d67f Author: Anthony PERARD Date: Thu Mar 18 15:10:37 2021 +0100 libxl: Fix domain soft reset state handling In do_domain_soft_reset(), a `libxl__domain_suspend_state' is used without been properly initialised and disposed of. This lead do a abort() in libxl due to the `dsps.qmp' state been used before been initialised: libxl__ev_qmp_send: Assertion `ev->state == qmp_state_disconnected || ev->state == qmp_state_connected' failed. Once initialised, `dsps' also needs to be disposed of as the `qmp' state might still be in the `Connected' state in the callback for libxl__domain_suspend_device_model(). So this patch adds libxl__domain_suspend_dispose() which can be called from the two places where we need to dispose of `dsps'. This is XSA-368. Reported-by: Olaf Hering Signed-off-by: Anthony PERARD Reviewed-by: Ian Jackson Tested-by: Olaf Hering master commit: dae3c3e8b257cd27d6b35a467a34bf79a6650340 master date: 2021-03-18 14:56:33 +0100 commit 70c53eaf596ef34c202257418e6684803cd96a4c Author: Jan Beulich Date: Thu Mar 18 15:09:38 2021 +0100 crypto: adjust rijndaelEncrypt() prototype for gcc11 The upcoming release complains, not entirely unreasonably: In file included from rijndael.c:33: .../xen/include/crypto/rijndael.h:55:53: note: previously declared as 'const unsigned char[]' 55 | void rijndaelEncrypt(const unsigned int [], int, const unsigned char [], | ^~~~~~~~~~~~~~~~~~~~~~ rijndael.c:865:8: error: argument 4 of type 'u8[16]' {aka 'unsigned char[16]'} with mismatched bound [-Werror=array-parameter=] 865 | u8 ct[16]) | ~~~^~~~~~ In file included from rijndael.c:33: .../xen/include/crypto/rijndael.h:56:13: note: previously declared as 'unsigned char[]' 56 | unsigned char []); | ^~~~~~~~~~~~~~~~ Simply declare the correct array dimensions right away. This then allows compilers to apply checking at call sites, which seems desirable anyway. For the moment I'm leaving untouched the disagreement between u8/u32 used in the function definition and unsigned {char,int} used in the declaration, as making this consistent would call for touching further functions. Reported-by: Charles Arnold Signed-off-by: Jan Beulich Reviewed-by: Julien Grall master commit: c6ad5a701b9a6df443a6c98d9e7201c958bbcafc master date: 2021-03-04 16:47:51 +0100 (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Mar 20 11:48:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 20 Mar 2021 11:48:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99464.189161 (Exim 4.92) (envelope-from ) id 1lNa4z-0005PZ-Ap; Sat, 20 Mar 2021 11:47:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99464.189161; Sat, 20 Mar 2021 11:47:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNa4z-0005PS-6E; Sat, 20 Mar 2021 11:47:41 +0000 Received: by outflank-mailman (input) for mailman id 99464; Sat, 20 Mar 2021 11:47:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNa4y-0005PN-0j for xen-devel@lists.xenproject.org; Sat, 20 Mar 2021 11:47:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNa4t-0005Ib-Gu; Sat, 20 Mar 2021 11:47:35 +0000 Received: from home.octic.net ([81.187.162.82] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lNa4t-0004ZF-72; Sat, 20 Mar 2021 11:47:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Xf+dJZi0n8P2FwywPOcg2u8L+kvJQeN7OpXBD1m6dq4=; b=Ec4F/tNcpA5onMojxRYITCyCNQ Kih7iIB79+c6b+x+Ynpu25r83R6gg5ENiM4yyOpYuxV0ijBM5y2Z11QpJOJr7OIc1cG/Mu7SEZSpY RtQxBpH9C3epmcPFyX2OtZBr3t07qam6Gu+eXcZ2zlsL8+m00mXPi3dUQ86GbGRRVImI=; Subject: Re: [PATCH] xen/arm: Ensure the vCPU context is seen before clearing the _VPF_down To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, ash.j.wilding@gmail.com, Julien Grall , Volodymyr Babchuk , Dario Faggioli , George Dunlap References: <20210226205158.20991-1-julien@xen.org> From: Julien Grall Message-ID: <86165804-34a1-59e5-1b51-fecc60dbf796@xen.org> Date: Sat, 20 Mar 2021 11:47:33 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 20/03/2021 00:01, Stefano Stabellini wrote: > On Sat, 27 Feb 2021, Julien Grall wrote: >> (+ Dario and George) >> >> Hi Stefano, >> >> I have added Dario and George to get some inputs from the scheduling part. >> >> On 27/02/2021 01:58, Stefano Stabellini wrote: >>> On Fri, 26 Feb 2021, Julien Grall wrote: >>>> From: Julien Grall >>>> >>>> A vCPU can get scheduled as soon as _VPF_down is cleared. As there is >>>> currently not ordering guarantee in arch_set_info_guest(), it may be >>>> possible that flag can be observed cleared before the new values of vCPU >>>> registers are observed. >>>> >>>> Add an smp_mb() before the flag is cleared to prevent re-ordering. >>>> >>>> Signed-off-by: Julien Grall >>>> >>>> --- >>>> >>>> Barriers should work in pair. However, I am not entirely sure whether to >>>> put the other half. Maybe at the beginning of context_switch_to()? >>> >>> It should be right after VGCF_online is set or cleared, right? >> >> vcpu_guest_context_t is variable allocated on the heap just for the purpose of >> this call. So an ordering with VGFC_online is not going to do anything. >> >>> So it >>> would be: >>> >>> xen/arch/arm/domctl.c:arch_get_info_guest >>> xen/arch/arm/vpsci.c:do_common_cpu_on >>> >>> But I think it is impossible that either of them get called at the same >>> time as arch_set_info_guest, which makes me wonder if we actually need >>> the barrier... >> arch_get_info_guest() is called without the domain lock held and I can't see >> any other lock that could prevent it to be called in // of >> arch_set_info_guest(). >> >> So you could technically get corrupted information from >> XEN_DOMCTL_getvcpucontext. For this case, we would want a smp_wmb() before >> writing to v->is_initialised. The corresponding read barrier would be in >> vcpu_pause() -> vcpu_sleep_sync() -> sync_vcpu_execstate(). >> >> But this is not the issue I was originally trying to solve. Currently, >> do_common_cpu_on() will roughly do: >> >> 1) domain_lock(d) >> >> 2) v->arch.sctlr = ... >> v->arch.ttbr0 = ... >> >> 3) clear_bit(_VFP_down, &v->pause_flags); >> >> 4) domain_unlock(d) >> >> 5) vcpu_wake(v); >> >> If we had only one pCPU on the system, then we would only wake the vCPU in >> step 5. We would be fine in this situation. But that's not the interesting >> case. >> >> If you add a second pCPU in the story, it may be possible to have vcpu_wake() >> happening in // (see more below). As there is no memory barrier, step 3 may be >> observed before 2. So, assuming the vcpu is runnable, we could start to >> schedule a vCPU before any update to the registers (step 2) are observed. >> >> This means that when context_switch_to() is called, we may end up to restore >> some old values. >> >> Now the question is can vcpu_wake() be called in // from another pCPU? AFAICT, >> it would be only called if a given flag in v->pause_flags is cleared (e.g. >> _VFP_blocked). But can we rely on that? >> >> Even if we can rely on it, v->pause_flags has other flags in it. I couldn't >> rule out that _VPF_down cannot be set at the same time as the other _VPF_*. >> >> Therefore, I think a barrier is necessary to ensure the ordering. >> >> Do you agree with this analysis? > > Yes, I think this makes sense. The corresponding barrier in the > scheduling code would have to be after reading _VPF_down and before > reading v->arch.sctlr, etc. > > >>>> The issues described here is also quite theoritical because there are >>>> hundreds of instructions executed between the time a vCPU is seen >>>> runnable and scheduled. But better be safe than sorry :). >>>> --- >>>> xen/arch/arm/domain.c | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c >>>> index bdd3d3e5b5d5..2b705e66be81 100644 >>>> --- a/xen/arch/arm/domain.c >>>> +++ b/xen/arch/arm/domain.c >>>> @@ -914,7 +914,14 @@ int arch_set_info_guest( >>>> v->is_initialised = 1; >>>> if ( ctxt->flags & VGCF_online ) >>>> + { >>>> + /* >>>> + * The vCPU can be scheduled as soon as _VPF_down is cleared. >>>> + * So clear the bit *after* the context was loaded. >>>> + */ >>>> + smp_mb(); >> >> From the discussion above, I would move this barrier before v->is_initialised. >> So we also take care of the issue with arch_get_info_guest(). >> >> This barrier also can be reduced to a smp_wmb() as we only expect an ordering >> between writes. >> >> The barrier would be paired with the barrier in: >> - sync_vcpu_execstate() in the case of arch_get_vcpu_info_guest(). >> - context_switch_to() in the case of scheduling (The exact barrier is TDB). > > OK, this makes sense, but why before: > > v->is_initialised = 1; > > instead of right after it? It is just v->pause_flags we care about, > right? The issue I originally tried to address was a race with v->pause_flags. But I also discovered one with v->initialised while answering to your previous e-mail. This was only briefly mentioned so let me expand it. A toolstack can take a snapshot of the vCPU context using XEN_DOMCTL_get_vcpucontext. The helper will bail out if v->is_initialized is 0. If v->is_initialized is 1, it will temporarily pause the vCPU and then call arch_get_info_guest(). AFAICT, arch_get_info_guest() and arch_set_info_guest() (called from PSCI CPU on) can run concurrently. If you put the barrier right after v->is_initialised, then a processor/compiler is allowed to re-order the write with what comes before. Therefore, the new value of v->is_initialised may be observed before v->arch.{sctlr, ttbr0,...}. Hence, we need a barrier before setting v->is_initialized so the new value is observed *after* the changes to v->arch.{sctlr, ttbr0, ...) have been observed. A single smp_wmb() barrier before v->is_initialized should be sufficient to cover the two problems discussed as I don't think we need to observe v->is_initialized *before* v->pause_flags. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Mar 20 12:01:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 20 Mar 2021 12:01:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99471.189173 (Exim 4.92) (envelope-from ) id 1lNaIE-0007D5-Qq; Sat, 20 Mar 2021 12:01:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99471.189173; Sat, 20 Mar 2021 12:01:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNaIE-0007Cy-N9; Sat, 20 Mar 2021 12:01:22 +0000 Received: by outflank-mailman (input) for mailman id 99471; Sat, 20 Mar 2021 12:01:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNaID-0007Ct-Tc for xen-devel@lists.xenproject.org; Sat, 20 Mar 2021 12:01:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNaIC-0005YI-P1; Sat, 20 Mar 2021 12:01:20 +0000 Received: from home.octic.net ([81.187.162.82] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lNaIC-0005Se-H3; Sat, 20 Mar 2021 12:01:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=83efPL5Alrv5nhdcp2Q7lF7t8Cc7ahwNlnonU8nkjNE=; b=r14jCNUfRB1vKdfcZX7RdW8KLv Cyzhz2C+ajxYmVd7uVrFGDNJw7zcktSfAgMzvr14458bNifgwPy4mCYMyfMSDn7t5VgsNAIkdzHb/ 7zdFH6OS9qNXp8ULfuxCRLQB53vyQ8dWhoHmnDhlBfUaGfBrXb77TIbjMa8Y7VgPR8V8=; Subject: Re: [PATCH 5/5] xen/arm: smmuv1: Intelligent SMR allocation To: Rahul Singh Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk References: <789abfb57568dcbaba122ea9b68c627e6c9707c4.1615312254.git.rahul.singh@arm.com> <299c8294-5f76-2fd6-85ec-d20c0b99368b@xen.org> <1C808D23-E8F3-4888-86AD-C37FCBAAD0D1@arm.com> From: Julien Grall Message-ID: Date: Sat, 20 Mar 2021 12:01:18 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1C808D23-E8F3-4888-86AD-C37FCBAAD0D1@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 16/03/2021 17:54, Rahul Singh wrote: > Hello Julien, Hi Rahul, >> On 16 Mar 2021, at 3:08 pm, Julien Grall wrote: >> >> Hi Rahul, >> >> On 09/03/2021 18:19, Rahul Singh wrote: >>> Backport 588888a7399db352d2b1a41c9d5b3bf0fd482390 >>> "iommu/arm-smmu: Intelligent SMR allocation" from the Linux kernel >>> This patch fix the stream match conflict issue when two devices have the >>> same stream-id. >>> Only difference while applying this patch is to use spinlock in place of >>> mutex and move iommu_group_alloc(..) function call in >>> arm_smmu_add_device(..) function from the start of the function >>> to the end. >> >> As you may remember the discussion on the SMMUv3 thread, replacing a spinlock by a mutex has consequences. Can you explain why this is fine? > Yes, I remember the discussion on the SMMUv3 thread, replacing a spinlock with a mutex has consequences. > > I replaced the mutex with spinlock in the SMMUv1 code when we are configuring the SMMUv1 hardware arm_smmu_master_alloc_smes(..). > > I think it is fine to use the spinlock in place of mutex in SMMUv1 where we are configuring the hardware via registers as compared to SMMUv3 where we are configuring the SMMUv3 hardware with Memory-based circular buffer queues. Configuring the hardware via queues might take a long time that why mutex is a good choice but if we are configuring the hardware via registers it is very fast. > > Configuring the SMMUv1 with the register is very fast and there are no side effects of this if we use spinlock. Let me know your view on this. This looks fine. Can you explain it the commit message? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Mar 20 12:09:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 20 Mar 2021 12:09:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99475.189185 (Exim 4.92) (envelope-from ) id 1lNaQK-0007XC-Lh; Sat, 20 Mar 2021 12:09:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99475.189185; Sat, 20 Mar 2021 12:09:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNaQK-0007X5-IF; Sat, 20 Mar 2021 12:09:44 +0000 Received: by outflank-mailman (input) for mailman id 99475; Sat, 20 Mar 2021 12:09:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNaQJ-0007X0-1H for xen-devel@lists.xenproject.org; Sat, 20 Mar 2021 12:09:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNaQH-0005gt-OQ; Sat, 20 Mar 2021 12:09:41 +0000 Received: from home.octic.net ([81.187.162.82] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lNaQH-0005ru-I2; Sat, 20 Mar 2021 12:09:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=eRwJPj+z72UMylNV3VDbMUJRhrRD3K+cnX2jCCFbNu0=; b=leXhkRYFITlJsj7rQvW4vroqpu J/vkv3xK9ijUdj58X1IxtL/3gfHdAg215vg0Y7X2JeV37AS5Rs/6N4g7+JrnDEMzoL8Js2R8NC2nX 82Mz+MFh1Oqp9wCKUyh/8WPavbNWcCCW3E4Q4qq9vIeZCXaOyE7rxifyNkDeRbHXzs6Y=; Subject: Re: [PATCH for-next v2 1/2] xen/arm: Include asm/asm-offsets.h and asm/macros.h on every assembly files To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk References: <20210313160611.18665-1-julien@xen.org> <20210313160611.18665-2-julien@xen.org> <2B11BB5C-EF9B-4CE0-8477-D94091DA0870@arm.com> From: Julien Grall Message-ID: <311a97f6-e4ad-9f5e-cca5-301c79cae52b@xen.org> Date: Sat, 20 Mar 2021 12:09:39 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <2B11BB5C-EF9B-4CE0-8477-D94091DA0870@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 17/03/2021 14:38, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, >> On 13 Mar 2021, at 16:06, Julien Grall wrote: >> >> From: Julien Grall >> >> In a follow-up patch we may want to automatically replace some >> mnemonics (such as ret) with a different sequence. >> >> To ensure all the assembly files will include asm/macros.h it is best to >> automatically include it on single assembly. This can be done via >> config.h. >> >> It was necessary to include a few more headers as dependency: >> - to define sizeof_* >> - which is already a latent issue given STACK_ORDER >> rely on PAGE_SIZE. >> >> Unfortunately the build system will use -D__ASSEMBLY__ when generating >> the linker script. A new option -D__LINKER__ is introduceed and used for >> the linker script to avoid including headers (such as asm/macros.h) that >> may not be compatible with the syntax. >> >> Lastly, take the opportunity to remove both asm/asm-offsets.h and >> asm/macros.h from the various assembly files as they are now >> automagically included. >> >> Signed-off-by: Julien Grall > > Everything is now building :-) > > I could not find a better then your define as filtering out or undefining __ASSEMBLY__ > is actually not working. Yes, unfortunately the linker is also relying on __ASSEMBLY__ for a few macros and to also remove the definitions of structure/function from headers that can be included either in C or assembly. -D__LINKER__ was the best option I could come up with. > > So with the fix from offset to defns: > > Reviewed-by: Bertrand Marquis Thanks! I will resend a new version with the fix fold in this patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Mar 20 12:40:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 20 Mar 2021 12:40:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99478.189197 (Exim 4.92) (envelope-from ) id 1lNatU-0001zp-S0; Sat, 20 Mar 2021 12:39:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99478.189197; Sat, 20 Mar 2021 12:39:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNatU-0001zi-Nu; Sat, 20 Mar 2021 12:39:52 +0000 Received: by outflank-mailman (input) for mailman id 99478; Sat, 20 Mar 2021 12:39:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNatT-0001za-OF; Sat, 20 Mar 2021 12:39:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNatT-0006A8-FQ; Sat, 20 Mar 2021 12:39:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNatT-00069d-4s; Sat, 20 Mar 2021 12:39:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNatT-0005mr-46; Sat, 20 Mar 2021 12:39:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2wfsS3IWbEdyCilLhDmlmhC9d2E6ovoHeyP6k+S8Vig=; b=biYU4h/426nGj72FQDbOey6B3V ZdSEZbQjSOsUSF6YUUb/OZXMOe8pySNLaCGb2Z5E8tx4yTPoC8dRwQ5EkVNezUJ5Gxtdj7ylJkcNJ mVE4o3V7d4N9SOuBMVpRoBYROG9PqHOBWgeOUQ6F4ql9W83mB9h+dLtFkS+2LXp2zXhw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.13-testing test] 160142: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f2e50a048a1430117f14fa42bde75c31ff85a7aa X-Osstest-Versions-That: xen=4547f01640f43ab04458da0f75854b3377ae4dbd From: osstest service owner Date: Sat, 20 Mar 2021 12:39:51 +0000 flight 160142 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160142/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160129 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160129 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160129 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160129 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160129 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160129 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160129 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160129 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160129 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160129 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160129 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen f2e50a048a1430117f14fa42bde75c31ff85a7aa baseline version: xen 4547f01640f43ab04458da0f75854b3377ae4dbd Last test of basis 160129 2021-03-18 14:36:25 Z 1 days Testing same since 160142 2021-03-19 14:07:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Christian Lindig Edwin Török Igor Druzhinin Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4547f01640..f2e50a048a f2e50a048a1430117f14fa42bde75c31ff85a7aa -> stable-4.13 From xen-devel-bounces@lists.xenproject.org Sat Mar 20 13:13:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 20 Mar 2021 13:13:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99496.189252 (Exim 4.92) (envelope-from ) id 1lNbQ8-0005rD-2e; Sat, 20 Mar 2021 13:13:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99496.189252; Sat, 20 Mar 2021 13:13:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNbQ7-0005r6-Uu; Sat, 20 Mar 2021 13:13:35 +0000 Received: by outflank-mailman (input) for mailman id 99496; Sat, 20 Mar 2021 13:13:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNbQ7-0005r1-8a for xen-devel@lists.xenproject.org; Sat, 20 Mar 2021 13:13:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNbPz-0006ie-PE; Sat, 20 Mar 2021 13:13:27 +0000 Received: from home.octic.net ([81.187.162.82] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lNbPz-0001Ys-GX; Sat, 20 Mar 2021 13:13:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=epyuPrJiv1ZCy4VoJ1gJhDE9ctAryyrGcCx+X4ZfE5k=; b=RQH8pI7xMZ9PZmPRSi4Yjrv3ez j0pFa+no2XMxgwtth1FLfnBsKFe8tKxeI+vgm+UgvWyRQcUb1oq0uhHs9IHfGJ30jk510I1Bu9d23 m81NcgId9u3X1uC76p+Cof/zzEDMjAKY0CRNEQu02kK9S42LWMRCiFMwa+PH+jzSc1y8=; Subject: Re: [PATCH for-next v2 2/2] xen/arm64: Place a speculation barrier following an ret instruction To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , "Xen.org security team" References: <20210313160611.18665-1-julien@xen.org> <20210313160611.18665-3-julien@xen.org> From: Julien Grall Message-ID: <50175d48-6f0b-2d96-8ea9-33f4f65f920f@xen.org> Date: Sat, 20 Mar 2021 13:13:25 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit (+ Security) On 17/03/2021 14:56, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, > >> On 13 Mar 2021, at 16:06, Julien Grall wrote: >> >> From: Julien Grall >> >> Some CPUs can speculate past a RET instruction and potentially perform >> speculative accesses to memory before processing the return. >> >> There is no known gadget available after the RET instruction today. >> However some of the registers (such as in check_pending_guest_serror()) >> may contain a value provided by the guest. >> >> In order to harden the code, it would be better to add a speculation >> barrier after each RET instruction. The performance impact is meant to >> be negligeable as the speculation barrier is not meant to be >> architecturally executed. >> >> Rather than manually inserting a speculation barrier, use a macro >> which overrides the mnemonic RET and replace with RET + SB. We need to >> use the opcode for RET to prevent any macro recursion. >> >> This patch is only covering the assembly code. C code would need to be >> covered separately using the compiler support. >> >> This is part of the work to mitigate straight-line speculation. >> >> Signed-off-by: Julien Grall > > The macro solution is definitely a great improvement compared to v1 and I could > confirm the presence of the sb in the generated code. Thanks for testing! It is indeed a lot nicer and less error-prone. We can thansk Jan for the idea as he originally introduced it on x86 :). > > I also think that the mitigation on arm32/v7 would be messy to do. It is messy but not impossible :). Some of the assembly function could be rewritten in C to take advantage of the compiler mitigations. I went through the paper again today. Straight-line mitigation only refers to unconditional control flow change (e.g. RET) on AArch64 Armv8. A recent submission to LLVM seems to suggest that Armv7 and AArch32 Armv8 is also affected [2]. So I think we only need to care of unconditional return instruction (e.g. mov pc, lr). For conditional return instructions, they would be treated as spectre v2 which we already mitigate. > Shall we mark v7/aarch32 as not security supported ? This would have consequence beyond just speculation. There might be processor out which are not affected by straight-line speculation and we would not issue any security update for them. So I am not in favor with this approach. What we could consider is mentioning in SUPPORT.MD that speculation attack using Straight-Line speculation are not security support on Arm (the 64-bit is not fully mitigated). Cheers, [1] https://reviews.llvm.org/D92395 -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Mar 20 13:35:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 20 Mar 2021 13:35:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99512.189304 (Exim 4.92) (envelope-from ) id 1lNbks-000831-CR; Sat, 20 Mar 2021 13:35:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99512.189304; Sat, 20 Mar 2021 13:35:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNbks-00082u-8U; Sat, 20 Mar 2021 13:35:02 +0000 Received: by outflank-mailman (input) for mailman id 99512; Sat, 20 Mar 2021 13:35:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNbkr-00082l-Vw; Sat, 20 Mar 2021 13:35:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNbkr-00075m-Rm; Sat, 20 Mar 2021 13:35:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNbkr-0007za-FK; Sat, 20 Mar 2021 13:35:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNbkr-0000zm-El; Sat, 20 Mar 2021 13:35:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8Sm2aD9zaJz3pvsByYtDhCVPAjZzUd47qUKx5jIcKCs=; b=UBzYa4q5q3KpQIRGtNXXrWQzuR 9addnXcBwbdYdn2cAz5Zp8+HKtVj7WzufmEjkBAdMj2v4XlevdsolOFtedqyljHWlzjVYX2FhJ9dP TwFNiTfoXKzG2BkJMo7qtzI0W9Y4HdM2qG3vVHROuos7X2hHZr/DopNLzsdREVwnszxk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.11-testing test] 160141: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.11-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.11-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.11-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=1d5581d352f7bb6408636e8aeaf0edda7d321aee X-Osstest-Versions-That: xen=76d369d33179a5f8e5f6607f3917db9ab8c22968 From: osstest service owner Date: Sat, 20 Mar 2021 13:35:01 +0000 flight 160141 xen-4.11-testing real [real] flight 160153 xen-4.11-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160141/ http://logs.test-lab.xenproject.org/osstest/logs/160153/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160153-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail like 159459 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail like 159459 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159459 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159459 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159459 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159459 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159459 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159459 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159459 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159459 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159459 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159459 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159459 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 1d5581d352f7bb6408636e8aeaf0edda7d321aee baseline version: xen 76d369d33179a5f8e5f6607f3917db9ab8c22968 Last test of basis 159459 2021-02-18 12:07:00 Z 30 days Testing same since 160141 2021-03-19 14:07:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Christian Lindig Edwin Török Igor Druzhinin Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 76d369d331..1d5581d352 1d5581d352f7bb6408636e8aeaf0edda7d321aee -> stable-4.11 From xen-devel-bounces@lists.xenproject.org Sat Mar 20 13:59:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 20 Mar 2021 13:59:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99518.189318 (Exim 4.92) (envelope-from ) id 1lNc7t-0001kB-Be; Sat, 20 Mar 2021 13:58:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99518.189318; Sat, 20 Mar 2021 13:58:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNc7t-0001k4-8m; Sat, 20 Mar 2021 13:58:49 +0000 Received: by outflank-mailman (input) for mailman id 99518; Sat, 20 Mar 2021 13:58:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNc7r-0001jz-Kc for xen-devel@lists.xenproject.org; Sat, 20 Mar 2021 13:58:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNc7r-0007SC-Gy for xen-devel@lists.xenproject.org; Sat, 20 Mar 2021 13:58:47 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lNc7r-000491-Fz for xen-devel@lists.xenproject.org; Sat, 20 Mar 2021 13:58:47 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lNc7n-0002xv-VQ; Sat, 20 Mar 2021 13:58:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=CeFCcc52cHmx3OyDtw56cS5LkV3mqaeE0Yfy/9Jkk5M=; b=GgyDBR9nW/fAyp59oiCPRztA6Y Aqk8aM94M5TCPzp1JujfzHAj1m0w8GKAy98LBG16+gZjXultLY6ixmz+Kr2t8Urk9CjHM6HFmyy8z u8znGPlYz9O8Ccem2w22gVeghEkJpBd6bdw06hAhI9ad384hUBPL+fBxbL9u1sEP2Qjg=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24661.65427.691862.12219@mariner.uk.xensource.com> Date: Sat, 20 Mar 2021 13:58:43 +0000 To: Julien Grall Cc: xen-devel@lists.xenproject.org, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Juergen Gross Subject: Re: [PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview In-Reply-To: <20210317112745.15207-1-julien@xen.org> References: <20210317112745.15207-1-julien@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("[PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview"): > From: Julien Grall > > Support to liveupdate C XenStored daemon was added during the 4.15 > development cycle. Add a section in SUPPORT.MD to explain what is the > support state. > > For now, it is a tech preview. Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Sat Mar 20 17:14:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 20 Mar 2021 17:14:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99556.189354 (Exim 4.92) (envelope-from ) id 1lNfAx-000414-0G; Sat, 20 Mar 2021 17:14:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99556.189354; Sat, 20 Mar 2021 17:14:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNfAw-00040x-TP; Sat, 20 Mar 2021 17:14:10 +0000 Received: by outflank-mailman (input) for mailman id 99556; Sat, 20 Mar 2021 17:14:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNfAv-00040p-C5; Sat, 20 Mar 2021 17:14:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNfAv-0002jo-61; Sat, 20 Mar 2021 17:14:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNfAu-0002o3-U6; Sat, 20 Mar 2021 17:14:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNfAu-0000Sa-Qk; Sat, 20 Mar 2021 17:14:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FhUFBOqtAjtvztsc3aAD9NGH8wsgR8ekhP31My8/Oyo=; b=pzTcd1VZHT/XjDRp8n9VDkUf2u xj93wY1i/mtz0yfGdjfb6JconC5IAeGz6uPisNldyQeZeVNMw7bPbSsnamLkmXvRpeAabKCtbGRpR vYMiA4xzGA7lDy/8FXNSiwKZD5BKn3Ysy7z1TzkT0rt4jYAPDVlXTCVDDPcCATETGawk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 160143: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=048af4453c2cfaf63ff5a1abd811fc7625c20c3c X-Osstest-Versions-That: xen=b0d7739f10dc93d9565220b4e79ebc6675548c02 From: osstest service owner Date: Sat, 20 Mar 2021 17:14:08 +0000 flight 160143 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160143/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160127 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160127 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160127 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160127 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160127 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160127 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160127 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160127 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160127 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160127 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160127 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: xen 048af4453c2cfaf63ff5a1abd811fc7625c20c3c baseline version: xen b0d7739f10dc93d9565220b4e79ebc6675548c02 Last test of basis 160127 2021-03-18 14:06:28 Z 2 days Testing same since 160143 2021-03-19 14:07:09 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Christian Lindig Edwin Török Igor Druzhinin jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b0d7739f10..048af4453c 048af4453c2cfaf63ff5a1abd811fc7625c20c3c -> stable-4.14 From xen-devel-bounces@lists.xenproject.org Sat Mar 20 22:44:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 20 Mar 2021 22:44:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99581.189370 (Exim 4.92) (envelope-from ) id 1lNkJw-0000r4-1T; Sat, 20 Mar 2021 22:43:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99581.189370; Sat, 20 Mar 2021 22:43:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNkJv-0000qx-UC; Sat, 20 Mar 2021 22:43:47 +0000 Received: by outflank-mailman (input) for mailman id 99581; Sat, 20 Mar 2021 22:43:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNkJu-0000qp-6n; Sat, 20 Mar 2021 22:43:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNkJt-00088A-UH; Sat, 20 Mar 2021 22:43:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNkJt-000431-F9; Sat, 20 Mar 2021 22:43:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNkJt-0005jQ-ES; Sat, 20 Mar 2021 22:43:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hXPcn2Gw/rNr9khnsJSJUbHVezHGDPl/dqH90uBdQJY=; b=VK2g/V7s5OaNncOJOx27+wv4A2 G/1WYRWK0RbneCQ1kvM/lrF2mbcULbnOz3CNZbVGi8DGIaIvi17Lx+Z1IHd1aZGEO/xf6reuZ8nfU 9m76HSziYSlmpkbBvygREy9IjF3btLyhW4kIj9Mk3lEUaICZUOHRlg4mhj3aX9XBT6po=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160145: all pass - PUSHED X-Osstest-Versions-This: ovmf=ca318882714080fb81fe9eb89a7b7934efc5bfae X-Osstest-Versions-That: ovmf=eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 From: osstest service owner Date: Sat, 20 Mar 2021 22:43:45 +0000 flight 160145 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160145/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ca318882714080fb81fe9eb89a7b7934efc5bfae baseline version: ovmf eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 Last test of basis 160131 2021-03-18 17:39:48 Z 2 days Testing same since 160145 2021-03-19 18:44:15 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Martin Radev Tom Lendacky jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git eb07bfb09e..ca31888271 ca318882714080fb81fe9eb89a7b7934efc5bfae -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Mar 21 00:40:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 00:40:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99600.189397 (Exim 4.92) (envelope-from ) id 1lNm8P-0003pG-EG; Sun, 21 Mar 2021 00:40:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99600.189397; Sun, 21 Mar 2021 00:40:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNm8P-0003p9-AQ; Sun, 21 Mar 2021 00:40:01 +0000 Received: by outflank-mailman (input) for mailman id 99600; Sun, 21 Mar 2021 00:40:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNm8O-0003p0-Ci; Sun, 21 Mar 2021 00:40:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNm8O-0002DQ-5O; Sun, 21 Mar 2021 00:40:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNm8N-00088g-PW; Sun, 21 Mar 2021 00:39:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNm8N-0004KC-P0; Sun, 21 Mar 2021 00:39:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4kvcgvWfOH/QbNPUo3dE6hkjme0Lsa1IeigGEDliF0I=; b=uj52XyOZGs7SKiH7qmAgD4ow9h T74yYAOIQt+xwjtSF61g3uPRhF05pJ3ndwkq91ldKxcRWMtOAVdwxiWv9NqOzoQPBipmV19YpNA9t fUqGcobTUZO8VkZdOcUWbkjEJ5usKA7tqbFP9C2MrN64ZGX6Lth8PsIzEh+VsP44f3Q4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160144: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=dae3c3e8b257cd27d6b35a467a34bf79a6650340 X-Osstest-Versions-That: xen=dae3c3e8b257cd27d6b35a467a34bf79a6650340 From: osstest service owner Date: Sun, 21 Mar 2021 00:39:59 +0000 flight 160144 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160144/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 160130 pass in 160144 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 160130 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail pass in 160130 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160130 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160130 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160130 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160130 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160130 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160130 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160130 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160130 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160130 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160130 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160130 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: xen dae3c3e8b257cd27d6b35a467a34bf79a6650340 baseline version: xen dae3c3e8b257cd27d6b35a467a34bf79a6650340 Last test of basis 160144 2021-03-19 17:08:52 Z 1 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Mar 21 01:54:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 01:54:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99609.189418 (Exim 4.92) (envelope-from ) id 1lNnHi-0004am-0j; Sun, 21 Mar 2021 01:53:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99609.189418; Sun, 21 Mar 2021 01:53:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNnHh-0004af-Rj; Sun, 21 Mar 2021 01:53:41 +0000 Received: by outflank-mailman (input) for mailman id 99609; Sun, 21 Mar 2021 01:53:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNnHg-0004aX-D0; Sun, 21 Mar 2021 01:53:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNnHg-0004uy-1u; Sun, 21 Mar 2021 01:53:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNnHf-0002z9-Oo; Sun, 21 Mar 2021 01:53:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNnHf-0002pj-OI; Sun, 21 Mar 2021 01:53:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jVPyaRnZJPmtdRuA8aPTTGmCriQ+5GniYsqkXIHEuO4=; b=Sd59IkyC2rlHgSefb8eUCpa888 3KhTZUR2OfbnLT33WU2yORdl1wI0Y9njw9zQWXk31ROE0ojd9gH+EFeE72wJHUVDRw81uCC1tfUrk yFQQ4rZjPXIz6D0JwxNmAc0xns/z/1NdRL1pLppy93MxEbIJbekkX8P0QGX3jtGuf15E=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160151: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=63bed955dffb9163464a38e2ae14a20934bc8770 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 21 Mar 2021 01:53:39 +0000 flight 160151 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160151/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 63bed955dffb9163464a38e2ae14a20934bc8770 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 253 days Failing since 151818 2020-07-11 04:18:52 Z 252 days 245 attempts Testing same since 160151 2021-03-20 04:19:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 48222 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 21 02:34:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 02:34:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99616.189432 (Exim 4.92) (envelope-from ) id 1lNnv4-0000Ho-4U; Sun, 21 Mar 2021 02:34:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99616.189432; Sun, 21 Mar 2021 02:34:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNnv4-0000Hh-1d; Sun, 21 Mar 2021 02:34:22 +0000 Received: by outflank-mailman (input) for mailman id 99616; Sun, 21 Mar 2021 02:34:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNnv2-0000HQ-2g; Sun, 21 Mar 2021 02:34:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNnv1-00060I-Sl; Sun, 21 Mar 2021 02:34:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNnv1-0004f5-HZ; Sun, 21 Mar 2021 02:34:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNnv1-0003SW-Gx; Sun, 21 Mar 2021 02:34:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=naBUn1BeBwKnn5Kbf5CPwDDu3GLxIr9UvmNmA9mzkX4=; b=MSmXvJPWZ+TemINLMHfaxZQ25n KasjLE8TN6O/NkbSFOFqNY88FRlPOTeNtPH+dwKRwPW+GGPIzLzV41+xsCUrMfH1cZhqfcEn0XUgy YeRyWky7JiweJ4obPV2mCIjYGxhKbLDtGBhTC2o5lyGFj51R/7h00HKE/fjDx1s3/Bzk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160146: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=8b12a62a4e3ed4ae99c715034f557eb391d6b196 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sun, 21 Mar 2021 02:34:19 +0000 flight 160146 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160146/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 8b12a62a4e3ed4ae99c715034f557eb391d6b196 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 232 days Failing since 152366 2020-08-01 20:49:34 Z 231 days 400 attempts Testing same since 160146 2021-03-19 21:08:26 Z 1 days 1 attempts ------------------------------------------------------------ 5222 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1295648 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 21 06:59:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 06:59:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99634.189472 (Exim 4.92) (envelope-from ) id 1lNs36-0008EK-Et; Sun, 21 Mar 2021 06:58:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99634.189472; Sun, 21 Mar 2021 06:58:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNs36-0008ED-BY; Sun, 21 Mar 2021 06:58:56 +0000 Received: by outflank-mailman (input) for mailman id 99634; Sun, 21 Mar 2021 06:58:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNs35-0008E5-P4; Sun, 21 Mar 2021 06:58:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNs35-0002KH-K4; Sun, 21 Mar 2021 06:58:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNs35-0003p0-A8; Sun, 21 Mar 2021 06:58:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNs35-0000vr-9L; Sun, 21 Mar 2021 06:58:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sZxb3iKBpeCnfV9+kz611+mNMTpBeyrN0bw9mEypsqg=; b=OoIH4mvhhi4z/JKj+JGJb/rA0D P1bYnHFHVE25r3GpWlUwJ9ZspJVT5QN3GtGZB15losXeeXfYLwrkgdEXm7QxGq+kE/kcicxMpfenV 8AHJCZ6RYYLimCaoqjXVQ+XsvObO09v/rAwHso1/J5J5iyIBQ7M2KlG6H2/v3xuoQn+g=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160147: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=2e1293cbaac75e84f541f9acfa8e26749f4c3562 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sun, 21 Mar 2021 06:58:55 +0000 flight 160147 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160147/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 2e1293cbaac75e84f541f9acfa8e26749f4c3562 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 212 days Failing since 152659 2020-08-21 14:07:39 Z 211 days 408 attempts Testing same since 160147 2021-03-20 00:40:18 Z 1 days 1 attempts ------------------------------------------------------------ 461 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 134616 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 21 09:17:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 09:17:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99653.189499 (Exim 4.92) (envelope-from ) id 1lNuCz-0004jM-2E; Sun, 21 Mar 2021 09:17:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99653.189499; Sun, 21 Mar 2021 09:17:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNuCy-0004jF-Uj; Sun, 21 Mar 2021 09:17:16 +0000 Received: by outflank-mailman (input) for mailman id 99653; Sun, 21 Mar 2021 09:17:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNuCx-0004j7-2H; Sun, 21 Mar 2021 09:17:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNuCw-00053n-Ro; Sun, 21 Mar 2021 09:17:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNuCw-0001yH-KI; Sun, 21 Mar 2021 09:17:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNuCw-00070l-JQ; Sun, 21 Mar 2021 09:17:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WK/YlPzT+f3efppq/0CWeL367mTEVhvP5fDkCLt/8/o=; b=aELz2Vlg+vspoa8d6OK2mpnItz 3bvGa21W4fuUgnJeWkuigftdBO8uZN5tdLz4Qqv+VVBNiKpZbUUhVbIWc7B60A3YVNRuHYOrUZDkW vzKKlYQfp4aIrW0MAliI4jbPkX6Y9pGeGBZ6TAVfNChCNXaw3XWySeGQpTRt0AIaFFow=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160150: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:build-amd64-xsm:xen-build:fail:regression xen-4.12-testing:build-amd64-prev:xen-build:fail:regression xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-amd64-migrupgrade:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-i386-migrupgrade:build-check(1):blocked:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Sun, 21 Mar 2021 09:17:14 +0000 flight 160150 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160150/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 159418 build-amd64-prev 6 xen-build fail REGR. vs. 159418 test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail REGR. vs. 159418 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemut-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-migrupgrade 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-migrupgrade 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 32 days Failing since 160128 2021-03-18 14:36:18 Z 2 days 3 attempts Testing same since 160150 2021-03-20 04:11:48 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm fail build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev fail build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm blocked test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemut-debianhvm-i386-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade blocked test-amd64-i386-migrupgrade blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 21 12:40:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 12:40:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99704.189567 (Exim 4.92) (envelope-from ) id 1lNxNP-0007CZ-8i; Sun, 21 Mar 2021 12:40:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99704.189567; Sun, 21 Mar 2021 12:40:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNxNP-0007CS-5p; Sun, 21 Mar 2021 12:40:15 +0000 Received: by outflank-mailman (input) for mailman id 99704; Sun, 21 Mar 2021 12:40:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNxNN-0007CK-Fs; Sun, 21 Mar 2021 12:40:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNxNN-0008LL-7p; Sun, 21 Mar 2021 12:40:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNxNM-0002oa-Tm; Sun, 21 Mar 2021 12:40:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNxNM-0000pf-TF; Sun, 21 Mar 2021 12:40:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=o5U2T0Zo8s9ApZ5BXytKS0Nos3Pa95GUTzIZ843bJ10=; b=L0ZHTeHLPZz86nYTWSaMz1LT9w qqE8xqukw3hD1w/4U/MoYZkp+jWoYsipszMcXVsLCRP44N3OHGe4bhh9kMZMaQ2LnCif/LGAaOh/W BvYwwzckpZxL+hmGzGF3hV/Td6xUZ7kT0H61tJ7+8wYu1JvEjMWa9Hzbpu+f5HappEZI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 160171: regressions - ALL FAIL X-Osstest-Failures: xen-unstable-coverity:coverity-amd64:coverity-upload:fail:regression X-Osstest-Versions-This: xen=dae3c3e8b257cd27d6b35a467a34bf79a6650340 X-Osstest-Versions-That: xen=1b47cc852fd130ed9ce274a0f1600a4a62949a2c From: osstest service owner Date: Sun, 21 Mar 2021 12:40:12 +0000 flight 160171 xen-unstable-coverity real [real] flight 160177 xen-unstable-coverity real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160171/ http://logs.test-lab.xenproject.org/osstest/logs/160177/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: coverity-amd64 7 coverity-upload fail REGR. vs. 159907 version targeted for testing: xen dae3c3e8b257cd27d6b35a467a34bf79a6650340 baseline version: xen 1b47cc852fd130ed9ce274a0f1600a4a62949a2c Last test of basis 159907 2021-03-10 09:18:33 Z 11 days Failing since 160076 2021-03-14 09:18:27 Z 7 days 3 attempts Testing same since 160171 2021-03-21 09:19:35 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Boris Ostrovsky Christian Lindig Dario Faggioli Doug Goldstein Elliott Mitchell Ian Jackson Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Roger Pau Monne Roger Pau Monné Wei Liu jobs: coverity-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 412 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 21 13:46:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 13:46:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99720.189607 (Exim 4.92) (envelope-from ) id 1lNyPH-0004On-73; Sun, 21 Mar 2021 13:46:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99720.189607; Sun, 21 Mar 2021 13:46:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNyPH-0004Og-3t; Sun, 21 Mar 2021 13:46:15 +0000 Received: by outflank-mailman (input) for mailman id 99720; Sun, 21 Mar 2021 13:46:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNyPF-0004OY-6t; Sun, 21 Mar 2021 13:46:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNyPE-0000yY-RL; Sun, 21 Mar 2021 13:46:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNyPE-0006jh-B4; Sun, 21 Mar 2021 13:46:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lNyPE-00013N-AZ; Sun, 21 Mar 2021 13:46:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UQp072hsEjsZZFOC539cR/TJCSFsP4EA6eEUDlcLC6g=; b=W/hiowqG4SYWVNEqxiPslsj9JQ M4GHbvzKq9IzvlpOY4x50YIo3OIVQqXZfNE7YwFJNW/0mExlZbLvOagrsAkIItLzJaz1q2Xna+XM5 821qk63uWDoj8oJDuj7/XO/NdeCKSE8nyoMCVZ6jA+j1cklKQjGgQCz+4fWVs1vUkzws=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 160152: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a65e788634437d7cdaf402930acdf210000f3957 X-Osstest-Versions-That: linux=0437de26e28dd844f51fde7a749a82cb2d3694ad From: osstest service owner Date: Sun, 21 Mar 2021 13:46:12 +0000 flight 160152 linux-5.4 real [real] flight 160183 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160152/ http://logs.test-lab.xenproject.org/osstest/logs/160183/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160183-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160116 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160116 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160116 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160116 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160116 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160116 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160116 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160116 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160116 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160116 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160116 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux a65e788634437d7cdaf402930acdf210000f3957 baseline version: linux 0437de26e28dd844f51fde7a749a82cb2d3694ad Last test of basis 160116 2021-03-17 16:11:22 Z 3 days Testing same since 160152 2021-03-20 10:11:17 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexei Starovoitov Amir Goldstein Ard Biesheuvel Colin Xu Daniel Borkmann David S. Miller David Sterba DENG Qingfang Eric Biggers # x86_64 Florian Fainelli Greg Kroah-Hartman Guenter Roeck Herbert Xu Jakub Kicinski Jason Self João Moreira Kees Cook Linux Kernel Functional Testing Marc Zyngier Miklos Szeredi Piotr Krysiuk Qu Wenruo Sasha Levin Suzuki K Poulose Uros Bizjak Zhenyu Wang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 0437de26e28d..a65e78863443 a65e788634437d7cdaf402930acdf210000f3957 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Sun Mar 21 16:31:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 16:31:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99765.189694 (Exim 4.92) (envelope-from ) id 1lO0z4-0003cU-GY; Sun, 21 Mar 2021 16:31:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99765.189694; Sun, 21 Mar 2021 16:31:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO0z4-0003cJ-Ci; Sun, 21 Mar 2021 16:31:22 +0000 Received: by outflank-mailman (input) for mailman id 99765; Sun, 21 Mar 2021 16:31:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO0z3-0003cD-29 for xen-devel@lists.xenproject.org; Sun, 21 Mar 2021 16:31:21 +0000 Received: from smtp-fw-2101.amazon.com (unknown [72.21.196.25]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d0f2a1a4-bfed-44b9-9ab1-c3bd123db180; Sun, 21 Mar 2021 16:31:19 +0000 (UTC) Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2a-119b4f96.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP; 21 Mar 2021 16:31:13 +0000 Received: from EX13D12EUA002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2a-119b4f96.us-west-2.amazon.com (Postfix) with ESMTPS id AB7991A01BD; Sun, 21 Mar 2021 16:31:11 +0000 (UTC) Received: from 147dda3ee008.ant.amazon.com (10.43.165.62) by EX13D12EUA002.ant.amazon.com (10.43.165.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 21 Mar 2021 16:31:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: d0f2a1a4-bfed-44b9-9ab1-c3bd123db180 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1616344280; x=1647880280; h=to:cc:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding:subject; bh=/YenUM5sZuq/Q41I5eoUqo3Fp3T8FhBehiqwfNkqKUY=; b=RKGyQ5NwT7DdP6Eq+Mi5YMGOKn2VZV4nVVttiSmCHHGPmF5cfTAlS3Rt MSfIaQvUlPc/phImK7c57CG0zV2f+4y9D1a9jDtiobIgvf93G9uv4RvEx oxIP2kRfWbe+d+kYf5BNWrHz9HFG+fNQe8+lxE1XE3N0JfYaFtlGc6TbV 8=; X-IronPort-AV: E=Sophos;i="5.81,266,1610409600"; d="scan'208";a="96528257" Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring To: Leon Romanovsky CC: Andrew Lunn , , , , , , References: <20210311225944.24198-1-andyhsu@amazon.com> <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> From: "Hsu, Chiahao" Message-ID: Date: Sun, 21 Mar 2021 17:31:08 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.43.165.62] X-ClientProxiedBy: EX13D08EUB004.ant.amazon.com (10.43.166.158) To EX13D12EUA002.ant.amazon.com (10.43.165.103) Precedence: Bulk Leon Romanovsky 於 2021/3/17 18:22 寫道: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > On Tue, Mar 16, 2021 at 04:22:21PM +0100, Hsu, Chiahao wrote: >> >> Leon Romanovsky 於 2021/3/14 11:04 寫道: >>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. >>> >>> >>> >>> On Fri, Mar 12, 2021 at 09:36:59PM +0100, Andrew Lunn wrote: >>>> On Fri, Mar 12, 2021 at 04:18:02PM +0100, Hsu, Chiahao wrote: >>>>> Andrew Lunn 於 2021/3/12 15:52 寫道: >>>>>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. >>>>>> >>>>>> >>>>>> >>>>>> On Thu, Mar 11, 2021 at 10:59:44PM +0000, ChiaHao Hsu wrote: >>>>>>> In order to support live migration of guests between kernels >>>>>>> that do and do not support 'feature-ctrl-ring', we add a >>>>>>> module parameter that allows the feature to be disabled >>>>>>> at run time, instead of using hardcode value. >>>>>>> The default value is enable. >>>>>> Hi ChiaHao >>>>>> >>>>>> There is a general dislike for module parameters. What other mechanisms >>>>>> have you looked at? Would an ethtool private flag work? >>>>>> >>>>>> Andrew >>>>> Hi Andrew, >>>>> >>>>> I can survey other mechanisms, however before I start doing that, >>>>> >>>>> could you share more details about what the problem is with using module >>>>> parameters? thanks. >>>> It is not very user friendly. No two kernel modules use the same >>>> module parameters. Often you see the same name, but different >>>> meaning. There is poor documentation, you often need to read the >>>> kernel sources it figure out what it does, etc. >>> +1, It is also global parameter to whole system/devices that use this >>> module, which is rarely what users want. >>> >>> Thanks >> Hi, >> I think I would say the current implementation(modparams) isappropriate >> after reviewing it again. >> >> We are talking about 'feature leveling', a way to support live migrationof >> guest >> between kernels that do and do not support the features. So we want to >> refrain >> fromadding the features if guest would be migrated to the kernel which does >> not support the feature. Everythingshould be done (in probe function) before >> frontend connects, and this is why ethtool is not appropriate for this. > It wouldn't be a surprise to you that feature discovery is not supposed > to be done through module parameters. Instead of asking from user to > randomly disable some feature, the system is expected to be backward > compatible and robust enough to query the list of supported/needed > features. > > Thanks > >> Thanks >> >> Typically there should be one VM running netback on each host, and having control over what interfaces or features it exposes is also important for stability. How about we create a 'feature flags' modparam, each bits is specified for different new features? From xen-devel-bounces@lists.xenproject.org Sun Mar 21 16:38:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 16:38:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99771.189712 (Exim 4.92) (envelope-from ) id 1lO15W-0003vy-Fj; Sun, 21 Mar 2021 16:38:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99771.189712; Sun, 21 Mar 2021 16:38:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO15W-0003vr-Be; Sun, 21 Mar 2021 16:38:02 +0000 Received: by outflank-mailman (input) for mailman id 99771; Sun, 21 Mar 2021 16:38:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO15V-0003vm-5m for xen-devel@lists.xenproject.org; Sun, 21 Mar 2021 16:38:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO15R-0004IF-Ry; Sun, 21 Mar 2021 16:37:57 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lO15R-0003aC-Iy; Sun, 21 Mar 2021 16:37:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=QMGU/Qm2+TLIrPzxYuMCSpwH0AxT10xkyqXGpM4qBCQ=; b=OD7mcCGWnHInFV4rlXcKxzFwR7 LI8+cQKG4UDx59TFAnZpx35Uz6eF1ozRPT9FipgqWcHfzSqrdrGwMYmujj2e8/pkvcJNP6rndVdgc xFWssSvHGKS07sTJWO8MxS6FtqlS8Zncv7j+8D9Xt1MJdd8H2rRZYxd4zBz6Jq/c6Kgw=; Subject: Re: [PATCH for-4.15 v3] SUPPORT.MD: Mark LiveUpdate of C/OCaml XenStored daemon as Tech Preview To: xen-devel@lists.xenproject.org, Ian Jackson Cc: Julien Grall , Juergen Gross References: <20210317120854.19903-1-julien@xen.org> From: Julien Grall Message-ID: Date: Sun, 21 Mar 2021 16:37:55 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210317120854.19903-1-julien@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit (+ Ian) Hi Ian, Sorry I forgot to CC you on the original Ian. Would it be possible to give an R-A for the patch below? Cheers, On 17/03/2021 12:08, Julien Grall wrote: > From: Julien Grall > > Support to liveupdate C/OCaml XenStored daemon was added during the > 4.15 development cycle. Add two new sections in SUPPORT.MD to explain > what is the support state. > > For now, it is a tech preview. > > Signed-off-by: Julien Grall > > --- > > CC: Juergen Gross > > Changes in v3: > - Add a section of OCaml XenStored > > Changes in v2: > - Clarify this is only supported for the daemon version > - Fix typoes > --- > SUPPORT.md | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/SUPPORT.md b/SUPPORT.md > index 7db4568f1a0f..1021a24801dc 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -177,6 +177,14 @@ Support for running qemu-xen device model in a linux stubdomain. > > Status: Tech Preview > > +## Liveupdate of C XenStored daemon > + > + Status: Tech Preview > + > +## Liveupdate of OCaml XenStored daemon > + > + Status: Tech Preview > + > ## Toolstack/3rd party > > ### libvirt driver for xl > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Mar 21 17:22:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 17:22:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99785.189750 (Exim 4.92) (envelope-from ) id 1lO1mW-0008T5-5y; Sun, 21 Mar 2021 17:22:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99785.189750; Sun, 21 Mar 2021 17:22:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO1mW-0008Sy-2u; Sun, 21 Mar 2021 17:22:28 +0000 Received: by outflank-mailman (input) for mailman id 99785; Sun, 21 Mar 2021 17:22:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO1mU-0008St-BR for xen-devel@lists.xenproject.org; Sun, 21 Mar 2021 17:22:26 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5290f112-2052-497c-a101-9ce123ad64da; Sun, 21 Mar 2021 17:22:25 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 370216192D; Sun, 21 Mar 2021 17:22:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5290f112-2052-497c-a101-9ce123ad64da DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616347344; bh=grRbkHiGMiSHWVuRSSoESXsJfOIy2CjZklOAVeWnZfw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lcb9EomaSRSVie+gdKKsQwIdFn/WQrFhUrocsGftn4xKjEuAb/x2g77wzd/sVauDs Xf59ahHNOYLQTAYJHjLqLcNjgkmj2xPSNhKTxbbkSMlH8Y9CFF5dX3OPQqrBslq/XU u2hfZg+BnhopjlvQyqJ3V9RTjCZx7wbBvJeKybIojz/4SGkiB771j2DTjG11r2Aot1 6pCoJvR5rKCUl1n/lmG4h4jvnj/ixtCesI6+8yKLVrdDpIIUaGE11XpX3y4Aottgux dJdYY0ioXlP9jbOaS1+yU/x0hPPC8meih0pKze6ZXth0crA1GrmxwXr2mLuzt4ZCQW aC15QJ9UD3XQw== Date: Sun, 21 Mar 2021 19:22:21 +0200 From: Leon Romanovsky To: "Hsu, Chiahao" Cc: Andrew Lunn , netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring Message-ID: References: <20210311225944.24198-1-andyhsu@amazon.com> <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Mar 21, 2021 at 05:31:08PM +0100, Hsu, Chiahao wrote: > > > Leon Romanovsky 於 2021/3/17 18:22 寫道: > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > > > > > On Tue, Mar 16, 2021 at 04:22:21PM +0100, Hsu, Chiahao wrote: > > > > > > Leon Romanovsky 於 2021/3/14 11:04 寫道: > > > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > > > > > > > > > > > > > On Fri, Mar 12, 2021 at 09:36:59PM +0100, Andrew Lunn wrote: > > > > > On Fri, Mar 12, 2021 at 04:18:02PM +0100, Hsu, Chiahao wrote: > > > > > > Andrew Lunn 於 2021/3/12 15:52 寫道: > > > > > > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Mar 11, 2021 at 10:59:44PM +0000, ChiaHao Hsu wrote: > > > > > > > > In order to support live migration of guests between kernels > > > > > > > > that do and do not support 'feature-ctrl-ring', we add a > > > > > > > > module parameter that allows the feature to be disabled > > > > > > > > at run time, instead of using hardcode value. > > > > > > > > The default value is enable. > > > > > > > Hi ChiaHao > > > > > > > > > > > > > > There is a general dislike for module parameters. What other mechanisms > > > > > > > have you looked at? Would an ethtool private flag work? > > > > > > > > > > > > > > Andrew > > > > > > Hi Andrew, > > > > > > > > > > > > I can survey other mechanisms, however before I start doing that, > > > > > > > > > > > > could you share more details about what the problem is with using module > > > > > > parameters? thanks. > > > > > It is not very user friendly. No two kernel modules use the same > > > > > module parameters. Often you see the same name, but different > > > > > meaning. There is poor documentation, you often need to read the > > > > > kernel sources it figure out what it does, etc. > > > > +1, It is also global parameter to whole system/devices that use this > > > > module, which is rarely what users want. > > > > > > > > Thanks > > > Hi, > > > I think I would say the current implementation(modparams) isappropriate > > > after reviewing it again. > > > > > > We are talking about 'feature leveling', a way to support live migrationof > > > guest > > > between kernels that do and do not support the features. So we want to > > > refrain > > > fromadding the features if guest would be migrated to the kernel which does > > > not support the feature. Everythingshould be done (in probe function) before > > > frontend connects, and this is why ethtool is not appropriate for this. > > It wouldn't be a surprise to you that feature discovery is not supposed > > to be done through module parameters. Instead of asking from user to > > randomly disable some feature, the system is expected to be backward > > compatible and robust enough to query the list of supported/needed > > features. > > > > Thanks > > > > > Thanks > > > > > > > Typically there should be one VM running netback on each host, > and having control over what interfaces or features it exposes is also > important for stability. > How about we create a 'feature flags' modparam, each bits is specified for > different new features? At the end, it will be more granular module parameter that user still will need to guess. Thanks > From xen-devel-bounces@lists.xenproject.org Sun Mar 21 17:55:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 17:55:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99796.189778 (Exim 4.92) (envelope-from ) id 1lO2I6-0002su-TK; Sun, 21 Mar 2021 17:55:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99796.189778; Sun, 21 Mar 2021 17:55:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO2I6-0002sn-PI; Sun, 21 Mar 2021 17:55:06 +0000 Received: by outflank-mailman (input) for mailman id 99796; Sun, 21 Mar 2021 17:55:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO2I5-0002si-ML for xen-devel@lists.xenproject.org; Sun, 21 Mar 2021 17:55:05 +0000 Received: from smtp-fw-6002.amazon.com (unknown [52.95.49.90]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2eb40b76-857d-411a-82f8-f52560fe0141; Sun, 21 Mar 2021 17:55:03 +0000 (UTC) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2b-81e76b79.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-6002.iad6.amazon.com with ESMTP; 21 Mar 2021 17:54:57 +0000 Received: from EX13D12EUA002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2b-81e76b79.us-west-2.amazon.com (Postfix) with ESMTPS id 8B10BA2000; Sun, 21 Mar 2021 17:54:55 +0000 (UTC) Received: from 147dda3ee008.ant.amazon.com (10.43.165.62) by EX13D12EUA002.ant.amazon.com (10.43.165.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 21 Mar 2021 17:54:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 2eb40b76-857d-411a-82f8-f52560fe0141 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1616349304; x=1647885304; h=to:cc:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding:subject; bh=4HNoEkyknGviSeugId+Rs1Iff5i9zQ8AvBezxLDNACA=; b=N0YFNSxz4gtQ43v+7SZbFU4Ri0KHk94FH3rCksaMQ4iG1Vtk5TDyuCav SY1PsuIIfbZjlLH/8xiFKEuyzJjMuu2Yy1BqfjfzZ5v/g3Tj9Es+VzWlS H90+F48ncHAZQGLNF1/wuB+bYMKkC5Zyr0kabQxfHLsfvgVXjvSg9u/et k=; X-IronPort-AV: E=Sophos;i="5.81,266,1610409600"; d="scan'208";a="99371535" Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring To: Leon Romanovsky CC: Andrew Lunn , , , , , , References: <20210311225944.24198-1-andyhsu@amazon.com> <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> From: "Hsu, Chiahao" Message-ID: <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> Date: Sun, 21 Mar 2021 18:54:52 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.43.165.62] X-ClientProxiedBy: EX13D08EUB002.ant.amazon.com (10.43.166.232) To EX13D12EUA002.ant.amazon.com (10.43.165.103) Precedence: Bulk Leon Romanovsky 於 2021/3/21 18:22 寫道: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > On Sun, Mar 21, 2021 at 05:31:08PM +0100, Hsu, Chiahao wrote: >> >> Leon Romanovsky 於 2021/3/17 18:22 寫道: >>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. >>> >>> >>> >>> On Tue, Mar 16, 2021 at 04:22:21PM +0100, Hsu, Chiahao wrote: >>>> Leon Romanovsky 於 2021/3/14 11:04 寫道: >>>>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. >>>>> >>>>> >>>>> >>>>> On Fri, Mar 12, 2021 at 09:36:59PM +0100, Andrew Lunn wrote: >>>>>> On Fri, Mar 12, 2021 at 04:18:02PM +0100, Hsu, Chiahao wrote: >>>>>>> Andrew Lunn 於 2021/3/12 15:52 寫道: >>>>>>>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Mar 11, 2021 at 10:59:44PM +0000, ChiaHao Hsu wrote: >>>>>>>>> In order to support live migration of guests between kernels >>>>>>>>> that do and do not support 'feature-ctrl-ring', we add a >>>>>>>>> module parameter that allows the feature to be disabled >>>>>>>>> at run time, instead of using hardcode value. >>>>>>>>> The default value is enable. >>>>>>>> Hi ChiaHao >>>>>>>> >>>>>>>> There is a general dislike for module parameters. What other mechanisms >>>>>>>> have you looked at? Would an ethtool private flag work? >>>>>>>> >>>>>>>> Andrew >>>>>>> Hi Andrew, >>>>>>> >>>>>>> I can survey other mechanisms, however before I start doing that, >>>>>>> >>>>>>> could you share more details about what the problem is with using module >>>>>>> parameters? thanks. >>>>>> It is not very user friendly. No two kernel modules use the same >>>>>> module parameters. Often you see the same name, but different >>>>>> meaning. There is poor documentation, you often need to read the >>>>>> kernel sources it figure out what it does, etc. >>>>> +1, It is also global parameter to whole system/devices that use this >>>>> module, which is rarely what users want. >>>>> >>>>> Thanks >>>> Hi, >>>> I think I would say the current implementation(modparams) isappropriate >>>> after reviewing it again. >>>> >>>> We are talking about 'feature leveling', a way to support live migrationof >>>> guest >>>> between kernels that do and do not support the features. So we want to >>>> refrain >>>> fromadding the features if guest would be migrated to the kernel which does >>>> not support the feature. Everythingshould be done (in probe function) before >>>> frontend connects, and this is why ethtool is not appropriate for this. >>> It wouldn't be a surprise to you that feature discovery is not supposed >>> to be done through module parameters. Instead of asking from user to >>> randomly disable some feature, the system is expected to be backward >>> compatible and robust enough to query the list of supported/needed >>> features. >>> >>> Thanks >>> >>>> Thanks >>>> >>>> >> Typically there should be one VM running netback on each host, >> and having control over what interfaces or features it exposes is also >> important for stability. >> How about we create a 'feature flags' modparam, each bits is specified for >> different new features? > At the end, it will be more granular module parameter that user still > will need to guess. I believe users always need to know any parameter or any tool's flag before they use it. For example, before user try to set/clear this ctrl_ring_enabled, they should already have basic knowledge about this feature, or else they shouldn't use it (the default value is same as before), and that's also why we use the 'ctrl_ring_enabled' as parameter name. Thanks > Thanks > From xen-devel-bounces@lists.xenproject.org Sun Mar 21 19:04:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 19:04:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99828.189878 (Exim 4.92) (envelope-from ) id 1lO3Mt-0001JE-SO; Sun, 21 Mar 2021 19:04:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99828.189878; Sun, 21 Mar 2021 19:04:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO3Mt-0001J7-P9; Sun, 21 Mar 2021 19:04:07 +0000 Received: by outflank-mailman (input) for mailman id 99828; Sun, 21 Mar 2021 19:04:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO3Mr-0001Iz-Hp; Sun, 21 Mar 2021 19:04:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO3Mr-0007AL-Bf; Sun, 21 Mar 2021 19:04:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO3Mr-0006Ed-1c; Sun, 21 Mar 2021 19:04:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lO3Mr-0007FB-18; Sun, 21 Mar 2021 19:04:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eBAMYGfCGymCVhmSn4k5V8D8dVafeSunEtb3O43zq80=; b=hMHviRk5YfOngr2F8yxWAWRKE7 moLyF+k0wzXS/8XAgNg7Cgjj0vh3GtBlPgBwuSYALkDZihgEauDBYcosn3f1fIl1sFpxSq30EBuIu OtBRaj1mk+nDTjneScjp8/RrDGCr8QP2USrVAEyjCK9sa+6blpVop3UKFrbCUDe9JGNM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.13-testing test] 160154: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.13-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d705cba5ae917aece3921f38df1bc0a579267d12 X-Osstest-Versions-That: xen=f2e50a048a1430117f14fa42bde75c31ff85a7aa From: osstest service owner Date: Sun, 21 Mar 2021 19:04:05 +0000 flight 160154 xen-4.13-testing real [real] flight 160208 xen-4.13-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160154/ http://logs.test-lab.xenproject.org/osstest/logs/160208/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160208-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160142 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160142 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160142 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160142 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160142 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160142 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160142 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160142 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160142 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160142 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160142 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen d705cba5ae917aece3921f38df1bc0a579267d12 baseline version: xen f2e50a048a1430117f14fa42bde75c31ff85a7aa Last test of basis 160142 2021-03-19 14:07:08 Z 2 days Testing same since 160154 2021-03-20 12:41:50 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Bertrand Marquis Jan Beulich Julien Grall Julien Grall Luca Fancellu Michal Orzel Peng Fan Penny Zheng Stefano Stabellini Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f2e50a048a..d705cba5ae d705cba5ae917aece3921f38df1bc0a579267d12 -> stable-4.13 From xen-devel-bounces@lists.xenproject.org Sun Mar 21 20:09:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 20:09:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99848.189929 (Exim 4.92) (envelope-from ) id 1lO4NW-00075k-CH; Sun, 21 Mar 2021 20:08:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99848.189929; Sun, 21 Mar 2021 20:08:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO4NW-00075d-8n; Sun, 21 Mar 2021 20:08:50 +0000 Received: by outflank-mailman (input) for mailman id 99848; Sun, 21 Mar 2021 20:08:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO4NU-00075V-RN; Sun, 21 Mar 2021 20:08:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO4NU-0008H3-G8; Sun, 21 Mar 2021 20:08:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO4NU-0001VH-9Q; Sun, 21 Mar 2021 20:08:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lO4NU-00060J-8v; Sun, 21 Mar 2021 20:08:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=/CrQLWVxWxfNy7qiL0B1b0ZXvQz8J4lA69zFK8e0ANU=; b=7LcB8DZHJE4Fz/bSPetTIPtOIz twntoqpolAFXM+jUepsd99IC5pomq8jnGzkSMi949JYUtHYJcC2HTVEqMmsf8htaWf/UGA6a39vzf B7WSwQ8WvoHg0mr+SuIiS+VDXzYwP34r3KRn/e4dQZ0xEMEn/oIDakKJpDmI8UYsN0Lo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Subject: [qemu-mainline bisection] complete test-amd64-amd64-qemuu-freebsd11-amd64 Message-Id: From: osstest service owner Date: Sun, 21 Mar 2021 20:08:48 +0000 branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-qemuu-freebsd11-amd64 testid guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 1b507e55f8199eaad99744613823f6929e4d57c6 Bug not present: 4083904bc9fe5da580f7ca397b1e828fbc322732 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160218/ commit 1b507e55f8199eaad99744613823f6929e4d57c6 Merge: 4083904bc9 8d17adf34f Author: Peter Maydell Date: Thu Mar 18 19:00:49 2021 +0000 Merge remote-tracking branch 'remotes/berrange-gitlab/tags/dep-many-pull-request' into staging Remove many old deprecated features The following features have been deprecated for well over the 2 release cycle we promise ``-drive file=json:{...{'driver':'file'}}`` (since 3.0) ``-vnc acl`` (since 4.0.0) ``-mon ...,control=readline,pretty=on|off`` (since 4.1) ``migrate_set_downtime`` and ``migrate_set_speed`` (since 2.8.0) ``query-named-block-nodes`` result ``encryption_key_missing`` (since 2.10.0) ``query-block`` result ``inserted.encryption_key_missing`` (since 2.10.0) ``migrate-set-cache-size`` and ``query-migrate-cache-size`` (since 2.11.0) ``query-named-block-nodes`` and ``query-block`` result dirty-bitmaps[i].status (since 4.0) ``query-cpus`` (since 2.12.0) ``query-cpus-fast`` ``arch`` output member (since 3.0.0) ``query-events`` (since 4.0) chardev client socket with ``wait`` option (since 4.0) ``acl_show``, ``acl_reset``, ``acl_policy``, ``acl_add``, ``acl_remove`` (since 4.0.0) ``ide-drive`` (since 4.2) ``scsi-disk`` (since 4.2) # gpg: Signature made Thu 18 Mar 2021 09:23:39 GMT # gpg: using RSA key DAF3A6FDB26B62912D0E8E3FBE86EBB415104FDF # gpg: Good signature from "Daniel P. Berrange " [full] # gpg: aka "Daniel P. Berrange " [full] # Primary key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF * remotes/berrange-gitlab/tags/dep-many-pull-request: block: remove support for using "file" driver with block/char devices block: remove 'dirty-bitmaps' field from 'BlockInfo' struct block: remove dirty bitmaps 'status' field block: remove 'encryption_key_missing' flag from QAPI hw/scsi: remove 'scsi-disk' device hw/ide: remove 'ide-drive' device chardev: reject use of 'wait' flag for socket client chardevs machine: remove 'arch' field from 'query-cpus-fast' QMP command machine: remove 'query-cpus' QMP command migrate: remove QMP/HMP commands for speed, downtime and cache size monitor: remove 'query-events' QMP command monitor: raise error when 'pretty' option is used with HMP ui, monitor: remove deprecated VNC ACL option and HMP commands Signed-off-by: Peter Maydell commit 8d17adf34f501ded65a106572740760f0a75577c Author: Daniel P. Berrangé Date: Mon Feb 22 11:16:32 2021 +0000 block: remove support for using "file" driver with block/char devices The 'host_device' and 'host_cdrom' drivers must be used instead. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé commit e67d8e2928200e24ecb47c7be3ea8270077f2996 Author: Daniel P. Berrangé Date: Fri Feb 19 19:22:36 2021 +0000 block: remove 'dirty-bitmaps' field from 'BlockInfo' struct The same data is available in the 'BlockDeviceInfo' struct. Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Daniel P. Berrangé commit 81cbfd5088690c53541ffd0d74851c8ab055a829 Author: Daniel P. Berrangé Date: Fri Feb 19 19:19:54 2021 +0000 block: remove dirty bitmaps 'status' field The same information is available via the 'recording' and 'busy' fields. Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Daniel P. Berrangé commit ad1324e044240ae9fcf67e4c215481b7a35591b9 Author: Daniel P. Berrangé Date: Fri Feb 19 18:53:17 2021 +0000 block: remove 'encryption_key_missing' flag from QAPI This has been hardcoded to "false" since 2.10.0, since secrets required to unlock block devices are now always provided up front instead of using interactive prompts. Reviewed-by: Eric Blake Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé commit 879be3af49132d232602e0ca783ec9b4112530fa Author: Daniel P. Berrangé Date: Mon Feb 22 13:40:56 2021 +0000 hw/scsi: remove 'scsi-disk' device The 'scsi-hd' and 'scsi-cd' devices provide suitable alternatives. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé commit b50101833987b47e0740f1621de48637c468c3d1 Author: Daniel P. Berrangé Date: Mon Feb 22 13:40:56 2021 +0000 hw/ide: remove 'ide-drive' device The 'ide-hd' and 'ide-cd' devices provide suitable alternatives. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé commit 24e13a4dc1eb1630eceffc7ab334145d902e763d Author: Daniel P. Berrangé Date: Mon Feb 22 13:47:17 2021 +0000 chardev: reject use of 'wait' flag for socket client chardevs This only makes sense conceptually when used with listener chardevs. Reviewed-by: Marc-André Lureau Signed-off-by: Daniel P. Berrangé commit 445a5b4087567bf4d4ce76d394adf78d9d5c88a5 Author: Daniel P. Berrangé Date: Mon Feb 22 13:29:31 2021 +0000 machine: remove 'arch' field from 'query-cpus-fast' QMP command Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé commit 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 Author: Daniel P. Berrangé Date: Mon Feb 22 12:54:55 2021 +0000 machine: remove 'query-cpus' QMP command The newer 'query-cpus-fast' command avoids side effects on the guest execution. Note that some of the field names are different in the 'query-cpus-fast' command. Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta Signed-off-by: Daniel P. Berrangé commit cbde7be900d2a2279cbc4becb91d1ddd6a014def Author: Daniel P. Berrangé Date: Fri Feb 19 18:40:12 2021 +0000 migrate: remove QMP/HMP commands for speed, downtime and cache size The generic 'migrate_set_parameters' command handle all types of param. Only the QMP commands were documented in the deprecations page, but the rationale for deprecating applies equally to HMP, and the replacements exist. Furthermore the HMP commands are just shims to the QMP commands, so removing the latter breaks the former unless they get re-implemented. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé commit 8becb36063fb14df1e3ae4916215667e2cb65fa2 Author: Daniel P. Berrangé Date: Mon Feb 22 13:35:15 2021 +0000 monitor: remove 'query-events' QMP command The code comment suggests removing QAPIEvent_(str|lookup) symbols too, however, these are both auto-generated as standard for any enum in QAPI. As such it they'll exist whether we use them or not. Reviewed-by: Eric Blake Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé commit 283d845c9164f57f5dba020a4783bb290493802f Author: Daniel P. Berrangé Date: Fri Feb 19 17:56:13 2021 +0000 monitor: raise error when 'pretty' option is used with HMP This is only semantically useful for QMP. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé commit 5994dcb8d8525ac044a31913c6bceeee788ec700 Author: Daniel P. Berrangé Date: Fri Feb 19 17:47:31 2021 +0000 ui, monitor: remove deprecated VNC ACL option and HMP commands The VNC ACL concept has been replaced by the pluggable "authz" framework which does not use monitor commands. Reviewed-by: Thomas Huth Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/test-amd64-amd64-qemuu-freebsd11-amd64.guest-saverestore.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/test-amd64-amd64-qemuu-freebsd11-amd64.guest-saverestore --summary-out=tmp/160218.bisection-summary --basis-template=152631 --blessings=real,real-bisect,real-retry qemu-mainline test-amd64-amd64-qemuu-freebsd11-amd64 guest-saverestore Searching for failure / basis pass: 160147 fail [host=godello0] / 160125 ok. Failure / basis pass flights: 160147 / 160125 (tree with no url: minios) Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2e1293cbaac75e84f541f9acfa8e26749f4c3562 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b12498fc575f2ad30f09fe78badc7fef526e2d76 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#030ba3097a6e7d08b99f8a9d19a322f61409c1f6-eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c74\ 37ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#b12498fc575f2ad30f09fe78badc7fef526e2d76-2e1293cbaac75e84f541f9acfa8e26749f4c3562 git://xenbits.xen.org/osstest/seabios.git#b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee-b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee git://xenbits.xen.org/xen.git#21657ad4f01a634beac570c64c0691e51b9cf366-dae3c3e8b257cd27d6b35a467a34bf79a6650340 Loaded 25036 nodes in revision graph Searching for test results: 160125 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b12498fc575f2ad30f09fe78badc7fef526e2d76 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160134 fail irrelevant 160148 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b12498fc575f2ad30f09fe78badc7fef526e2d76 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160157 fail irrelevant 160158 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3754df04ec291b933c18285210793d02c9d9787a b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160160 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b12498fc575f2ad30f09fe78badc7fef526e2d76 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160162 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 f7dcd31885cbe801cac95536a279bbc7e55af4f6 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160163 pass irrelevant 160165 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 397fbb5b32558dd2b5cd35cb4d25126879384079 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160147 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2e1293cbaac75e84f541f9acfa8e26749f4c3562 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160166 pass irrelevant 160168 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2e1293cbaac75e84f541f9acfa8e26749f4c3562 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160169 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 f2a9a6c2a86570ccbf8c5c30cbb8bf723168c459 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160174 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 17422da082ffcecb38bd1f2e2de6d56a61e8cd9c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160178 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 0f418a207696b37f05d38f978c8873ee0a4f9815 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160181 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 1b507e55f8199eaad99744613823f6929e4d57c6 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160185 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6e71c36557ed41017e634ae392fa80f03ced7fa1 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160190 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 87a80dc4f2f5e51894db143685a5e39c8ce6f651 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 4083904bc9fe5da580f7ca397b1e828fbc322732 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160195 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 4083904bc9fe5da580f7ca397b1e828fbc322732 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160199 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 1b507e55f8199eaad99744613823f6929e4d57c6 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160202 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 4083904bc9fe5da580f7ca397b1e828fbc322732 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160206 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 1b507e55f8199eaad99744613823f6929e4d57c6 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160211 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 4083904bc9fe5da580f7ca397b1e828fbc322732 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160218 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 1b507e55f8199eaad99744613823f6929e4d57c6 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 Searching for interesting versions Result found: flight 160125 (pass), for basis pass Result found: flight 160147 (fail), for basis failure Repro found: flight 160148 (pass), for basis pass Repro found: flight 160168 (fail), for basis failure 0 revisions at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 4083904bc9fe5da580f7ca397b1e828fbc322732 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 No revisions left to test, checking graph state. Result found: flight 160195 (pass), for last pass Result found: flight 160199 (fail), for first failure Repro found: flight 160202 (pass), for last pass Repro found: flight 160206 (fail), for first failure Repro found: flight 160211 (pass), for last pass Repro found: flight 160218 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 1b507e55f8199eaad99744613823f6929e4d57c6 Bug not present: 4083904bc9fe5da580f7ca397b1e828fbc322732 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160218/ commit 1b507e55f8199eaad99744613823f6929e4d57c6 Merge: 4083904bc9 8d17adf34f Author: Peter Maydell Date: Thu Mar 18 19:00:49 2021 +0000 Merge remote-tracking branch 'remotes/berrange-gitlab/tags/dep-many-pull-request' into staging Remove many old deprecated features The following features have been deprecated for well over the 2 release cycle we promise ``-drive file=json:{...{'driver':'file'}}`` (since 3.0) ``-vnc acl`` (since 4.0.0) ``-mon ...,control=readline,pretty=on|off`` (since 4.1) ``migrate_set_downtime`` and ``migrate_set_speed`` (since 2.8.0) ``query-named-block-nodes`` result ``encryption_key_missing`` (since 2.10.0) ``query-block`` result ``inserted.encryption_key_missing`` (since 2.10.0) ``migrate-set-cache-size`` and ``query-migrate-cache-size`` (since 2.11.0) ``query-named-block-nodes`` and ``query-block`` result dirty-bitmaps[i].status (since 4.0) ``query-cpus`` (since 2.12.0) ``query-cpus-fast`` ``arch`` output member (since 3.0.0) ``query-events`` (since 4.0) chardev client socket with ``wait`` option (since 4.0) ``acl_show``, ``acl_reset``, ``acl_policy``, ``acl_add``, ``acl_remove`` (since 4.0.0) ``ide-drive`` (since 4.2) ``scsi-disk`` (since 4.2) # gpg: Signature made Thu 18 Mar 2021 09:23:39 GMT # gpg: using RSA key DAF3A6FDB26B62912D0E8E3FBE86EBB415104FDF # gpg: Good signature from "Daniel P. Berrange " [full] # gpg: aka "Daniel P. Berrange " [full] # Primary key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF * remotes/berrange-gitlab/tags/dep-many-pull-request: block: remove support for using "file" driver with block/char devices block: remove 'dirty-bitmaps' field from 'BlockInfo' struct block: remove dirty bitmaps 'status' field block: remove 'encryption_key_missing' flag from QAPI hw/scsi: remove 'scsi-disk' device hw/ide: remove 'ide-drive' device chardev: reject use of 'wait' flag for socket client chardevs machine: remove 'arch' field from 'query-cpus-fast' QMP command machine: remove 'query-cpus' QMP command migrate: remove QMP/HMP commands for speed, downtime and cache size monitor: remove 'query-events' QMP command monitor: raise error when 'pretty' option is used with HMP ui, monitor: remove deprecated VNC ACL option and HMP commands Signed-off-by: Peter Maydell commit 8d17adf34f501ded65a106572740760f0a75577c Author: Daniel P. Berrangé Date: Mon Feb 22 11:16:32 2021 +0000 block: remove support for using "file" driver with block/char devices The 'host_device' and 'host_cdrom' drivers must be used instead. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé commit e67d8e2928200e24ecb47c7be3ea8270077f2996 Author: Daniel P. Berrangé Date: Fri Feb 19 19:22:36 2021 +0000 block: remove 'dirty-bitmaps' field from 'BlockInfo' struct The same data is available in the 'BlockDeviceInfo' struct. Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Daniel P. Berrangé commit 81cbfd5088690c53541ffd0d74851c8ab055a829 Author: Daniel P. Berrangé Date: Fri Feb 19 19:19:54 2021 +0000 block: remove dirty bitmaps 'status' field The same information is available via the 'recording' and 'busy' fields. Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Daniel P. Berrangé commit ad1324e044240ae9fcf67e4c215481b7a35591b9 Author: Daniel P. Berrangé Date: Fri Feb 19 18:53:17 2021 +0000 block: remove 'encryption_key_missing' flag from QAPI This has been hardcoded to "false" since 2.10.0, since secrets required to unlock block devices are now always provided up front instead of using interactive prompts. Reviewed-by: Eric Blake Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé commit 879be3af49132d232602e0ca783ec9b4112530fa Author: Daniel P. Berrangé Date: Mon Feb 22 13:40:56 2021 +0000 hw/scsi: remove 'scsi-disk' device The 'scsi-hd' and 'scsi-cd' devices provide suitable alternatives. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé commit b50101833987b47e0740f1621de48637c468c3d1 Author: Daniel P. Berrangé Date: Mon Feb 22 13:40:56 2021 +0000 hw/ide: remove 'ide-drive' device The 'ide-hd' and 'ide-cd' devices provide suitable alternatives. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé commit 24e13a4dc1eb1630eceffc7ab334145d902e763d Author: Daniel P. Berrangé Date: Mon Feb 22 13:47:17 2021 +0000 chardev: reject use of 'wait' flag for socket client chardevs This only makes sense conceptually when used with listener chardevs. Reviewed-by: Marc-André Lureau Signed-off-by: Daniel P. Berrangé commit 445a5b4087567bf4d4ce76d394adf78d9d5c88a5 Author: Daniel P. Berrangé Date: Mon Feb 22 13:29:31 2021 +0000 machine: remove 'arch' field from 'query-cpus-fast' QMP command Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé commit 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 Author: Daniel P. Berrangé Date: Mon Feb 22 12:54:55 2021 +0000 machine: remove 'query-cpus' QMP command The newer 'query-cpus-fast' command avoids side effects on the guest execution. Note that some of the field names are different in the 'query-cpus-fast' command. Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta Signed-off-by: Daniel P. Berrangé commit cbde7be900d2a2279cbc4becb91d1ddd6a014def Author: Daniel P. Berrangé Date: Fri Feb 19 18:40:12 2021 +0000 migrate: remove QMP/HMP commands for speed, downtime and cache size The generic 'migrate_set_parameters' command handle all types of param. Only the QMP commands were documented in the deprecations page, but the rationale for deprecating applies equally to HMP, and the replacements exist. Furthermore the HMP commands are just shims to the QMP commands, so removing the latter breaks the former unless they get re-implemented. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé commit 8becb36063fb14df1e3ae4916215667e2cb65fa2 Author: Daniel P. Berrangé Date: Mon Feb 22 13:35:15 2021 +0000 monitor: remove 'query-events' QMP command The code comment suggests removing QAPIEvent_(str|lookup) symbols too, however, these are both auto-generated as standard for any enum in QAPI. As such it they'll exist whether we use them or not. Reviewed-by: Eric Blake Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé commit 283d845c9164f57f5dba020a4783bb290493802f Author: Daniel P. Berrangé Date: Fri Feb 19 17:56:13 2021 +0000 monitor: raise error when 'pretty' option is used with HMP This is only semantically useful for QMP. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé commit 5994dcb8d8525ac044a31913c6bceeee788ec700 Author: Daniel P. Berrangé Date: Fri Feb 19 17:47:31 2021 +0000 ui, monitor: remove deprecated VNC ACL option and HMP commands The VNC ACL concept has been replaced by the pluggable "authz" framework which does not use monitor commands. Reviewed-by: Thomas Huth Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Revision graph left in /home/logs/results/bisect/qemu-mainline/test-amd64-amd64-qemuu-freebsd11-amd64.guest-saverestore.{dot,ps,png,html,svg}. ---------------------------------------- 160218: tolerable ALL FAIL flight 160218 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/160218/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail baseline untested jobs: test-amd64-amd64-qemuu-freebsd11-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Sun Mar 21 20:29:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 20:29:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99858.189947 (Exim 4.92) (envelope-from ) id 1lO4he-0000d9-Ed; Sun, 21 Mar 2021 20:29:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99858.189947; Sun, 21 Mar 2021 20:29:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO4he-0000d2-AM; Sun, 21 Mar 2021 20:29:38 +0000 Received: by outflank-mailman (input) for mailman id 99858; Sun, 21 Mar 2021 20:29:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO4hd-0000cx-FV for xen-devel@lists.xenproject.org; Sun, 21 Mar 2021 20:29:37 +0000 Received: from vps0.lunn.ch (unknown [185.16.172.187]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dd132347-0223-4639-83af-40d68505389b; Sun, 21 Mar 2021 20:29:35 +0000 (UTC) Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lO4hP-00CIAJ-Ab; Sun, 21 Mar 2021 21:29:23 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd132347-0223-4639-83af-40d68505389b Date: Sun, 21 Mar 2021 21:29:23 +0100 From: Andrew Lunn To: "Hsu, Chiahao" Cc: Leon Romanovsky , netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring Message-ID: References: <20210311225944.24198-1-andyhsu@amazon.com> <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> > > At the end, it will be more granular module parameter that user still > > will need to guess. > I believe users always need to know any parameter or any tool's flag before > they use it. > For example, before user try to set/clear this ctrl_ring_enabled, they > should already have basic knowledge about this feature, > or else they shouldn't use it (the default value is same as before), and > that's also why we use the 'ctrl_ring_enabled' as parameter name. To me, it seems you are fixing this problem in the wrong place. As a VM user in the cloud, i have no idea how the cloud provider needs the VM configured to allow the cloud provider to migrate the VM to somewhere else in the bitbarn. As the VM user, it should not be my problem. I would expect the cloud provider to configure the VM host to only expose facilities to the VM which allows it to be migrated. This is a VM host problem, not a VM problem. Andrew From xen-devel-bounces@lists.xenproject.org Sun Mar 21 21:00:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 21:00:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99867.189977 (Exim 4.92) (envelope-from ) id 1lO5Bn-0004BR-1r; Sun, 21 Mar 2021 21:00:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99867.189977; Sun, 21 Mar 2021 21:00:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO5Bm-0004BK-Uz; Sun, 21 Mar 2021 21:00:46 +0000 Received: by outflank-mailman (input) for mailman id 99867; Sun, 21 Mar 2021 21:00:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO5Bm-0004BF-0Z for xen-devel@lists.xenproject.org; Sun, 21 Mar 2021 21:00:46 +0000 Received: from smtp-fw-6002.amazon.com (unknown [52.95.49.90]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e59c070d-cc04-47f1-ad6b-d0192263843d; Sun, 21 Mar 2021 21:00:45 +0000 (UTC) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-1a-821c648d.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-6002.iad6.amazon.com with ESMTP; 21 Mar 2021 21:00:39 +0000 Received: from EX13D12EUA002.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-1a-821c648d.us-east-1.amazon.com (Postfix) with ESMTPS id C740FA1F51; Sun, 21 Mar 2021 21:00:36 +0000 (UTC) Received: from 147dda3ee008.ant.amazon.com (10.43.166.52) by EX13D12EUA002.ant.amazon.com (10.43.165.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 21 Mar 2021 21:00:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: e59c070d-cc04-47f1-ad6b-d0192263843d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1616360446; x=1647896446; h=to:cc:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding:subject; bh=bR/zGL5bgmIYKJX4KBNvUn1W7VU3s2jvkoCpPNEsc+Y=; b=D+80gHtukbZoYMZx8KbnoPhQyra/OZnnFHS7/XDep9bqxDXTZIR6vCnz QPj3mzZEIsBYjFWqDHndISrWokjBAmCVvGwbjXEttGPPUj/uei55tI48E X+278dJOrIIHhVvRDJopZNwLlJpG4irJX3jgW5vS5CrNLmtVVq33SztIU c=; X-IronPort-AV: E=Sophos;i="5.81,266,1610409600"; d="scan'208";a="99384150" Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring To: Andrew Lunn CC: Leon Romanovsky , , , , , , References: <20210311225944.24198-1-andyhsu@amazon.com> <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> From: "Hsu, Chiahao" Message-ID: <818b5f7c-92ce-dca9-ee83-c6220c8292da@amazon.com> Date: Sun, 21 Mar 2021 22:00:21 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.43.166.52] X-ClientProxiedBy: EX13D10EUA003.ant.amazon.com (10.43.165.52) To EX13D12EUA002.ant.amazon.com (10.43.165.103) Precedence: Bulk Andrew Lunn 於 2021/3/21 21:29 寫道: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > >>> At the end, it will be more granular module parameter that user still >>> will need to guess. >> I believe users always need to know any parameter or any tool's flag before >> they use it. >> For example, before user try to set/clear this ctrl_ring_enabled, they >> should already have basic knowledge about this feature, >> or else they shouldn't use it (the default value is same as before), and >> that's also why we use the 'ctrl_ring_enabled' as parameter name. > To me, it seems you are fixing this problem in the wrong place. As a > VM user in the cloud, i have no idea how the cloud provider needs the > VM configured to allow the cloud provider to migrate the VM to > somewhere else in the bitbarn. As the VM user, it should not be my > problem. I would expect the cloud provider to configure the VM host to > only expose facilities to the VM which allows it to be migrated. 'the users' I mentioned it's the cloud provider, not a VM user. Sorry for the confusion. And agree with you, just wondering how the cloud provider can expose the facilities to the VM if there's no way to set/clr it at runtime, unless reconfigure kernel?  These features are enabled by default. > > This is a VM host problem, not a VM problem. > > Andrew Thanks From xen-devel-bounces@lists.xenproject.org Sun Mar 21 23:06:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 21 Mar 2021 23:06:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99889.190043 (Exim 4.92) (envelope-from ) id 1lO78j-0006tK-JE; Sun, 21 Mar 2021 23:05:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99889.190043; Sun, 21 Mar 2021 23:05:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO78j-0006tD-Fu; Sun, 21 Mar 2021 23:05:45 +0000 Received: by outflank-mailman (input) for mailman id 99889; Sun, 21 Mar 2021 23:05:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO78i-0006t5-NA; Sun, 21 Mar 2021 23:05:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO78i-0002iS-Hd; Sun, 21 Mar 2021 23:05:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lO78i-0002qg-6d; Sun, 21 Mar 2021 23:05:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lO78i-0000x9-67; Sun, 21 Mar 2021 23:05:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WO9H5aoZ4JO+9NqSy1rdJmlHBR6LfRC+h87A/qD5HoQ=; b=IruyG87pb96K190YAoRMJICUxm J8mAiq30eMTJqLKiv3pF8tQXucQhW6E2gDw7g5iprAQAI/S8GPxesqhGJSjRjSXvBkuvB5SS4G1pP lEEnAyhJbNpPMi5mbFwA14BjIubo4DVO/n+vZoumgiZu3Xw2YMWsSzjdIsnrR/K1owGQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.11-testing test] 160155: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.11-testing:test-arm64-arm64-xl-seattle:debian-fixup:fail:heisenbug xen-4.11-testing:test-armhf-armhf-xl-rtds:host-ping-check-native:fail:allowable xen-4.11-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=8bce4698f6264f4b359643233b1878d0f61ed7b0 X-Osstest-Versions-That: xen=1d5581d352f7bb6408636e8aeaf0edda7d321aee From: osstest service owner Date: Sun, 21 Mar 2021 23:05:44 +0000 flight 160155 xen-4.11-testing real [real] flight 160231 xen-4.11-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160155/ http://logs.test-lab.xenproject.org/osstest/logs/160231/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-seattle 13 debian-fixup fail pass in 160231-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 6 host-ping-check-native fail REGR. vs. 160141 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 160231 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 160231 never pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail like 160141 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail like 160141 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160141 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160141 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160141 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160141 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160141 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160141 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160141 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160141 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160141 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160141 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160141 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 8bce4698f6264f4b359643233b1878d0f61ed7b0 baseline version: xen 1d5581d352f7bb6408636e8aeaf0edda7d321aee Last test of basis 160141 2021-03-19 14:07:08 Z 2 days Testing same since 160155 2021-03-20 13:37:02 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 1d5581d352..8bce4698f6 8bce4698f6264f4b359643233b1878d0f61ed7b0 -> stable-4.11 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 03:40:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 03:40:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99943.190194 (Exim 4.92) (envelope-from ) id 1lOBQF-0002F7-E2; Mon, 22 Mar 2021 03:40:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99943.190194; Mon, 22 Mar 2021 03:40:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOBQF-0002F0-9v; Mon, 22 Mar 2021 03:40:07 +0000 Received: by outflank-mailman (input) for mailman id 99943; Mon, 22 Mar 2021 03:40:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOBQD-000236-E2; Mon, 22 Mar 2021 03:40:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOBQD-0001h5-3C; Mon, 22 Mar 2021 03:40:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOBQC-0007hq-TG; Mon, 22 Mar 2021 03:40:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOBQC-0003vI-So; Mon, 22 Mar 2021 03:40:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LCEAFGeLcedKpfaUgzLiiIBFZPp7BOJQMHzjIa7aLwY=; b=zJJpoKeBDHH38yOz1obHuasfc7 C6nM5Muq7fGr7A8bF2mmQLiFuQwojLfRGtfdeEZZjxgWJ29e1modZgwR6fIp/Z7JagWqKutuOWptm x3yRxJzI5Trae4gOxZZ0N4aN9Rm2UfcXAnFgVSPSVpLc/VTbvdZgx/iIWYe00Zf1oczw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160164: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=63bed955dffb9163464a38e2ae14a20934bc8770 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 22 Mar 2021 03:40:04 +0000 flight 160164 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160164/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 63bed955dffb9163464a38e2ae14a20934bc8770 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 254 days Failing since 151818 2020-07-11 04:18:52 Z 253 days 246 attempts Testing same since 160151 2021-03-20 04:19:22 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 48222 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 22 04:34:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 04:34:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99966.190261 (Exim 4.92) (envelope-from ) id 1lOCGZ-0007N6-8d; Mon, 22 Mar 2021 04:34:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99966.190261; Mon, 22 Mar 2021 04:34:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOCGZ-0007Mz-5g; Mon, 22 Mar 2021 04:34:11 +0000 Received: by outflank-mailman (input) for mailman id 99966; Mon, 22 Mar 2021 04:34:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOCGX-0007Mp-PH; Mon, 22 Mar 2021 04:34:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOCGX-0002la-Iy; Mon, 22 Mar 2021 04:34:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOCGX-0001tp-7j; Mon, 22 Mar 2021 04:34:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOCGX-0007xM-77; Mon, 22 Mar 2021 04:34:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jvNRKlgG8yeNYUe3RK0cncRkYFTbuEUkanO/ULbrv0U=; b=KugvDWU+RYf2F86CVMzl9l4dSb 0IW4mnYHy6rBJxN5VjxJO+mSeUiTR+lUp1sLJw0t8YqUU36qcSUMwaPrmPZiyndvGJ7G376qogMQP s7lWOZ5KKE7vXe9viIehMZ2EW+kNwEe2LrKySMWUYhdxsTYp/FaCEcBL6QX+0r+umjLM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 160156: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.14-testing:test-armhf-armhf-xl-vhd:leak-check/check:fail:heisenbug xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ddb39ba714257debb9b66936abb0dd3039e85abd X-Osstest-Versions-That: xen=048af4453c2cfaf63ff5a1abd811fc7625c20c3c From: osstest service owner Date: Mon, 22 Mar 2021 04:34:09 +0000 flight 160156 xen-4.14-testing real [real] flight 160254 xen-4.14-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160156/ http://logs.test-lab.xenproject.org/osstest/logs/160254/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 20 leak-check/check fail pass in 160254-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160143 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160143 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160143 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160143 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160143 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160143 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160143 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160143 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160143 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160143 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160143 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen ddb39ba714257debb9b66936abb0dd3039e85abd baseline version: xen 048af4453c2cfaf63ff5a1abd811fc7625c20c3c Last test of basis 160143 2021-03-19 14:07:09 Z 2 days Testing same since 160156 2021-03-20 17:17:05 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Bertrand Marquis Jan Beulich Julien Grall Luca Fancellu Michal Orzel Penny Zheng Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 048af4453c..ddb39ba714 ddb39ba714257debb9b66936abb0dd3039e85abd -> stable-4.14 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 05:39:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 05:39:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99981.190298 (Exim 4.92) (envelope-from ) id 1lODHa-0004yg-9Q; Mon, 22 Mar 2021 05:39:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99981.190298; Mon, 22 Mar 2021 05:39:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lODHa-0004yZ-5y; Mon, 22 Mar 2021 05:39:18 +0000 Received: by outflank-mailman (input) for mailman id 99981; Mon, 22 Mar 2021 05:39:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lODHY-0004y8-Iq for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 05:39:16 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 81c9bebf-19d0-4232-8cea-4e4401c6b5e0; Mon, 22 Mar 2021 05:39:15 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 69882601FE; Mon, 22 Mar 2021 05:39:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81c9bebf-19d0-4232-8cea-4e4401c6b5e0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616391555; bh=wtAYmmg5bTmlX11026gT4vxnsv9pHiDO0GoAP4cPjN0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xp3IMm9BgBDPBrOU1gWtYBz1KmnBjDWnIdISWcsoy2IrleEvHTAPJbAheSq5/Vx/R p7+dSW+ZKB82D5dxUnKt64B+vMhMxTKWfnRzpqMwuxvxVpZ4DupgF2GjPAflm5tDxU njaKmhxIc0qnlPFFGKPCqHwdJ2EHy9f9D/R4OYYrm3Y1m0C0H8I9ngJKXSB5DvU7sF pAEsY6pNUJFrwksSP7ZWcfa6E/pSIFskPZ9I7AhtB1XpDr7+q+IxrfWNKvKFTgtyFY I/9dYM98IvxgM7zcDu5L6PARQcTCOjXj/s0xsVBfBIpQSoc5WV/hOG9gz054d0YytQ 22szeX2q8CKUA== Date: Mon, 22 Mar 2021 07:39:11 +0200 From: Leon Romanovsky To: "Hsu, Chiahao" Cc: Andrew Lunn , netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring Message-ID: References: <20210311225944.24198-1-andyhsu@amazon.com> <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> On Sun, Mar 21, 2021 at 06:54:52PM +0100, Hsu, Chiahao wrote: > <...> > > > Typically there should be one VM running netback on each host, > > > and having control over what interfaces or features it exposes is also > > > important for stability. > > > How about we create a 'feature flags' modparam, each bits is specified for > > > different new features? > > At the end, it will be more granular module parameter that user still > > will need to guess. > I believe users always need to know any parameter or any tool's flag before > they use it. > For example, before user try to set/clear this ctrl_ring_enabled, they > should already have basic knowledge about this feature, > or else they shouldn't use it (the default value is same as before), and > that's also why we use the 'ctrl_ring_enabled' as parameter name. It solves only forward migration flow. Move from machine A with no option X to machine B with option X. It doesn't work for backward flow. Move from machine B to A back will probably break. In your flow, you want that users will set all module parameters for every upgrade and keep those parameters differently per-version. Thanks > > Thanks > > Thanks > > > From xen-devel-bounces@lists.xenproject.org Mon Mar 22 05:58:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 05:58:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.99988.190322 (Exim 4.92) (envelope-from ) id 1lODaJ-0006tt-1F; Mon, 22 Mar 2021 05:58:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99988.190322; Mon, 22 Mar 2021 05:58:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lODaI-0006tm-UR; Mon, 22 Mar 2021 05:58:38 +0000 Received: by outflank-mailman (input) for mailman id 99988; Mon, 22 Mar 2021 05:58:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lODaH-0006th-Di for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 05:58:37 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d5f0792e-f3d3-4ce1-9f5d-a864a789db8d; Mon, 22 Mar 2021 05:58:36 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 302E5AC1F; Mon, 22 Mar 2021 05:58:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5f0792e-f3d3-4ce1-9f5d-a864a789db8d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616392715; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rpfcsvKFLtYwXTwkcaD3SMIT07anvDjM2o1RlVIT5tQ=; b=a83pjg1mYWQrab/nZveqt0sAahlov+NEHXk/jorvLIE3o8R4oh0oZqPIA8d80cKrO37GZ3 82nr32pVBkDB3/3ybYnkLsI2JAB5W627O1uuv2/nPXI2yl29eExydW3feZpmMZx/cz6krA yAeIO+L3z6+ftuUNVs4wX2726g9GmEk= Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring To: Leon Romanovsky , "Hsu, Chiahao" Cc: Andrew Lunn , netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org References: <20210311225944.24198-1-andyhsu@amazon.com> <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Mon, 22 Mar 2021 06:58:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GEck0MXAkH1N6s1uP2AhJml1gohEKJuvu" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GEck0MXAkH1N6s1uP2AhJml1gohEKJuvu Content-Type: multipart/mixed; boundary="XUP3wTaC5PcuOZo2Tj6lUqDgZCIZPhCqg"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Leon Romanovsky , "Hsu, Chiahao" Cc: Andrew Lunn , netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org Message-ID: Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring References: <20210311225944.24198-1-andyhsu@amazon.com> <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> In-Reply-To: --XUP3wTaC5PcuOZo2Tj6lUqDgZCIZPhCqg Content-Type: multipart/mixed; boundary="------------E31744AF77CBCB1800D0DE83" Content-Language: en-US This is a multi-part message in MIME format. --------------E31744AF77CBCB1800D0DE83 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 22.03.21 06:39, Leon Romanovsky wrote: > On Sun, Mar 21, 2021 at 06:54:52PM +0100, Hsu, Chiahao wrote: >> >=20 > <...> >=20 >>>> Typically there should be one VM running netback on each host, >>>> and having control over what interfaces or features it exposes is al= so >>>> important for stability. >>>> How about we create a 'feature flags' modparam, each bits is specifi= ed for >>>> different new features? >>> At the end, it will be more granular module parameter that user still= >>> will need to guess. >> I believe users always need to know any parameter or any tool's flag b= efore >> they use it. >> For example, before user try to set/clear this ctrl_ring_enabled, they= >> should already have basic knowledge about this feature, >> or else they shouldn't use it (the default value is same as before), a= nd >> that's also why we use the 'ctrl_ring_enabled' as parameter name. >=20 > It solves only forward migration flow. Move from machine A with no > option X to machine B with option X. It doesn't work for backward > flow. Move from machine B to A back will probably break. >=20 > In your flow, you want that users will set all module parameters for > every upgrade and keep those parameters differently per-version. I think the flag should be a per guest config item. Adding this item to the backend Xenstore nodes for netback to consume it should be rather easy. Yes, this would need a change in Xen tools, too, but it is the most flexible way to handle it. And in case of migration the information would be just migrated to the new host with the guest's config data. Juergen --------------E31744AF77CBCB1800D0DE83 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------E31744AF77CBCB1800D0DE83-- --XUP3wTaC5PcuOZo2Tj6lUqDgZCIZPhCqg-- --GEck0MXAkH1N6s1uP2AhJml1gohEKJuvu Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBYMgoFAwAAAAAACgkQsN6d1ii/Ey+c BQf+IQ+ho3RQLTWFN65txeg1WgkVlfNNUdCRW2SHljtxWQOhLidl7/zqHCT0gWlO8z+Cv6L5SaYm gWX1MxOoeqcKi0m42Om8N6uypfWBcsuWj4/Zr0bYr+4l+8l2IjyB884Si6hmd5He4nra8eqVb5y4 d0DuBy4jTt9oNW3oIKF+CoVkCDsy5EfXYO8YtRqXuxGooG1umzjrnvmTcQuqi8pqWI2dynJlDufr chtN1hlXYi8ON/HAic/dOmRbKtb7en+nhoDTcm3hyQ6bULq2zGwbFI58fcuZroB4JjWP+5IO2JAJ Bd9Grs8g3bxnS9rBXl8mgs58k4VFx8jCq6yJb4vZYA== =C3yn -----END PGP SIGNATURE----- --GEck0MXAkH1N6s1uP2AhJml1gohEKJuvu-- From xen-devel-bounces@lists.xenproject.org Mon Mar 22 06:49:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 06:49:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100003.190364 (Exim 4.92) (envelope-from ) id 1lOEMl-0003G3-B8; Mon, 22 Mar 2021 06:48:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100003.190364; Mon, 22 Mar 2021 06:48:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOEMl-0003Fw-7G; Mon, 22 Mar 2021 06:48:43 +0000 Received: by outflank-mailman (input) for mailman id 100003; Mon, 22 Mar 2021 06:48:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOEMj-0003Fr-1k for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 06:48:41 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fc377903-84b0-46bc-b925-3af9b1627445; Mon, 22 Mar 2021 06:48:40 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DAA10614A5; Mon, 22 Mar 2021 06:48:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc377903-84b0-46bc-b925-3af9b1627445 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616395719; bh=aBATp9cF4F75lj0dyqnEuKbgcMuvl6XXRbrTzcy1hz8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jxLByM1eDq0pAWzRAwSsBEtuDaWYZqg6zod0MvQTrLNHpY8NTSNjhfdxcHiCxcly0 DQvAMqQD2ShMoUpfkDwdvPTp96vCTOQyyF5JNn/wSHhGwxZeLsrClVpece2ySaXawI 9PkHyUmoarBs6z/o6d5PNp531EJr0zEVQXexQChe8sA1IHKUtWghq6em8yj3+fdj38 zgiMLsTuOooSmiopAu7+/VWDYsgtH5oeVEN0wZFXwmRUVemE/khxfZ35KmlLTwSlW4 xQS8cccvEqeyLjNm11wnNaA/JB3l3/LOHvJ2RWO1sG9lws3q2FUmQMgtnHgX4oak0F zLXRmzzHY7zJA== Date: Mon, 22 Mar 2021 08:48:35 +0200 From: Leon Romanovsky To: =?iso-8859-1?Q?J=FCrgen_Gro=DF?= Cc: "Hsu, Chiahao" , Andrew Lunn , netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring Message-ID: References: <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: On Mon, Mar 22, 2021 at 06:58:34AM +0100, J=FCrgen Gro=DF wrote: > On 22.03.21 06:39, Leon Romanovsky wrote: > > On Sun, Mar 21, 2021 at 06:54:52PM +0100, Hsu, Chiahao wrote: > > >=20 > >=20 > > <...> > >=20 > > > > > Typically there should be one VM running netback on each host, > > > > > and having control over what interfaces or features it exposes is= also > > > > > important for stability. > > > > > How about we create a 'feature flags' modparam, each bits is spec= ified for > > > > > different new features? > > > > At the end, it will be more granular module parameter that user sti= ll > > > > will need to guess. > > > I believe users always need to know any parameter or any tool's flag = before > > > they use it. > > > For example, before user try to set/clear this ctrl_ring_enabled, they > > > should already have basic knowledge about this feature, > > > or else they shouldn't use it (the default value is same as before), = and > > > that's also why we use the 'ctrl_ring_enabled' as parameter name. > >=20 > > It solves only forward migration flow. Move from machine A with no > > option X to machine B with option X. It doesn't work for backward > > flow. Move from machine B to A back will probably break. > >=20 > > In your flow, you want that users will set all module parameters for > > every upgrade and keep those parameters differently per-version. >=20 > I think the flag should be a per guest config item. Adding this item to > the backend Xenstore nodes for netback to consume it should be rather > easy. >=20 > Yes, this would need a change in Xen tools, too, but it is the most > flexible way to handle it. And in case of migration the information > would be just migrated to the new host with the guest's config data. Yes, it will overcome global nature of module parameters, but how does it solve backward compatibility concern? Thanks >=20 >=20 > Juergen From xen-devel-bounces@lists.xenproject.org Mon Mar 22 07:01:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 07:01:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100008.190381 (Exim 4.92) (envelope-from ) id 1lOEZ0-00053K-HE; Mon, 22 Mar 2021 07:01:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100008.190381; Mon, 22 Mar 2021 07:01:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOEZ0-00053D-Dw; Mon, 22 Mar 2021 07:01:22 +0000 Received: by outflank-mailman (input) for mailman id 100008; Mon, 22 Mar 2021 07:01:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOEYy-000538-WE for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 07:01:21 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0154e2f1-4fd2-4703-801d-5f346ba97c7d; Mon, 22 Mar 2021 07:01:19 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 00DD3AD4A; Mon, 22 Mar 2021 07:01:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0154e2f1-4fd2-4703-801d-5f346ba97c7d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616396479; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ikdRbjYwrh6jMOeo5QgfZnIqyWaL0H+nMzfLn9qBY+0=; b=i3fuAO3/9AJ6D78I8hJbTgo7/dJINVsaVaiq5rqBsLQNwwLHqBLM63NvFuspPOh6OtKms3 JEW/vNHZP7NjQlMgSS4Z91h7zr03OQOF1wMHQsVW1O6on2indryxLVZMHx4Qq85zP/j4H8 1oNf/90t4g4YFYaYuYQK5o40fWdf0pE= To: Leon Romanovsky Cc: "Hsu, Chiahao" , Andrew Lunn , netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org References: <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring Message-ID: Date: Mon, 22 Mar 2021 08:01:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XNey0EOIqh5lWhHqjRdvYYllC8uxFqu6T" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XNey0EOIqh5lWhHqjRdvYYllC8uxFqu6T Content-Type: multipart/mixed; boundary="Ov0WnZb01U1s0agqQzQ7tBpupQeAGgOZ7"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Leon Romanovsky Cc: "Hsu, Chiahao" , Andrew Lunn , netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org Message-ID: Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring References: <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> In-Reply-To: --Ov0WnZb01U1s0agqQzQ7tBpupQeAGgOZ7 Content-Type: multipart/mixed; boundary="------------8A2B5EA9D8912C96E9D361F3" Content-Language: en-US This is a multi-part message in MIME format. --------------8A2B5EA9D8912C96E9D361F3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 22.03.21 07:48, Leon Romanovsky wrote: > On Mon, Mar 22, 2021 at 06:58:34AM +0100, J=C3=BCrgen Gro=C3=9F wrote: >> On 22.03.21 06:39, Leon Romanovsky wrote: >>> On Sun, Mar 21, 2021 at 06:54:52PM +0100, Hsu, Chiahao wrote: >>>> >>> >>> <...> >>> >>>>>> Typically there should be one VM running netback on each host, >>>>>> and having control over what interfaces or features it exposes is = also >>>>>> important for stability. >>>>>> How about we create a 'feature flags' modparam, each bits is speci= fied for >>>>>> different new features? >>>>> At the end, it will be more granular module parameter that user sti= ll >>>>> will need to guess. >>>> I believe users always need to know any parameter or any tool's flag= before >>>> they use it. >>>> For example, before user try to set/clear this ctrl_ring_enabled, th= ey >>>> should already have basic knowledge about this feature, >>>> or else they shouldn't use it (the default value is same as before),= and >>>> that's also why we use the 'ctrl_ring_enabled' as parameter name. >>> >>> It solves only forward migration flow. Move from machine A with no >>> option X to machine B with option X. It doesn't work for backward >>> flow. Move from machine B to A back will probably break. >>> >>> In your flow, you want that users will set all module parameters for >>> every upgrade and keep those parameters differently per-version. >> >> I think the flag should be a per guest config item. Adding this item t= o >> the backend Xenstore nodes for netback to consume it should be rather >> easy. >> >> Yes, this would need a change in Xen tools, too, but it is the most >> flexible way to handle it. And in case of migration the information >> would be just migrated to the new host with the guest's config data. >=20 > Yes, it will overcome global nature of module parameters, but how does > it solve backward compatibility concern? When creating a guest on A the (unknown) feature will not be set to any value in the guest's config data. A migration stream not having any value for that feature on B should set it to "false". When creating a guest on B it will either have the feature value set explicitly in the guest config (either true or false), or it will get the server's default (this value should be configurable in a global config file, default for that global value would be "true"). So with the guest created on B with feature specified as "false" (either for this guest only, or per global config), it will be migratable to machine A without problem. Migrating it back to B would work the same way as above. Trying to migrate a guest with feature set to "true" to B would not work, but this would be the host admin's fault due to not configuring the guest correctly. Juergen --------------8A2B5EA9D8912C96E9D361F3 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------8A2B5EA9D8912C96E9D361F3-- --Ov0WnZb01U1s0agqQzQ7tBpupQeAGgOZ7-- --XNey0EOIqh5lWhHqjRdvYYllC8uxFqu6T Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBYQL0FAwAAAAAACgkQsN6d1ii/Ey9G CQgAiHIxxi5KIe3wo0sRuWyXuC7W48WgTdRt0A5zxkVkfT8QCGk50L3jRKk4ykkWw5ksw4j0ttEt ks4I5B+2FixAsKqQnv7ZqhropUQhMrn9KIr+UYXN2pCyxgVEtQbrRKr+XK5ylnAD3UwZnfjrsizT Q2mKKQWgk83KFyCTmW5FsE0FhIcMfJl9npdxeTewaucsycTAG9vGj2Gjxk4j/v/qBxRKUPLWfY+s cezaGKS7OuUDvnKf1ZRYgpNnfnQLltGZ6t+ESN/yEe+1xFXPjjz14Puax6hu8TDgRTZo+TXVuDG1 Y3nLga6TPeyTYbEBwTVL7EZdhNy6KZpefOqU5iYbGA== =fEL1 -----END PGP SIGNATURE----- --XNey0EOIqh5lWhHqjRdvYYllC8uxFqu6T-- From xen-devel-bounces@lists.xenproject.org Mon Mar 22 07:13:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 07:13:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100013.190399 (Exim 4.92) (envelope-from ) id 1lOEkk-000674-M5; Mon, 22 Mar 2021 07:13:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100013.190399; Mon, 22 Mar 2021 07:13:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOEkk-00066x-JC; Mon, 22 Mar 2021 07:13:30 +0000 Received: by outflank-mailman (input) for mailman id 100013; Mon, 22 Mar 2021 07:13:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOEkj-00066s-EU for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 07:13:29 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c9f20681-ec23-4df5-be74-ccdf84a541c9; Mon, 22 Mar 2021 07:13:28 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6E91661924; Mon, 22 Mar 2021 07:13:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9f20681-ec23-4df5-be74-ccdf84a541c9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616397208; bh=LFgbb7l9KEu7Z6OAYZRvyu6Do2gcidBM2ddbIvOEWrA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zd3+s2OeoaOuzP1Xenkromp3abbFxeEdHfs6d7rqu0IVAMmK+ykrB9MRNcHuNJ2MR vkHlkZWY0FilJxuZCdG3GGRLDZ0PC3Rm+xM0y6bHgYqcXg0Cx3xrrmH0Evgrp2IyS6 kg/W95bfTCSERGyq9naq2YYwqdRZ3DqD61CQhEEIFhYnhFyCpsCQSu3C6GYLl0GDBs wWBLVXJRpdJxeLsnFjmV8FqIX36ZAQMmks+JUrdpDmpF8mUGUplaM/IG3LFtnl9iP1 CCvwIktMW6m1AarZ3tfDhyPeeDVzpRDmGI4Alvab1O8ZxhUxfrgAHtLlHpvnJrZInP LSHX4pxgZd4RA== Date: Mon, 22 Mar 2021 09:13:24 +0200 From: Leon Romanovsky To: =?iso-8859-1?Q?J=FCrgen_Gro=DF?= Cc: "Hsu, Chiahao" , Andrew Lunn , netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring Message-ID: References: <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: On Mon, Mar 22, 2021 at 08:01:17AM +0100, J=FCrgen Gro=DF wrote: > On 22.03.21 07:48, Leon Romanovsky wrote: > > On Mon, Mar 22, 2021 at 06:58:34AM +0100, J=FCrgen Gro=DF wrote: > > > On 22.03.21 06:39, Leon Romanovsky wrote: > > > > On Sun, Mar 21, 2021 at 06:54:52PM +0100, Hsu, Chiahao wrote: > > > > >=20 > > > >=20 > > > > <...> > > > >=20 > > > > > > > Typically there should be one VM running netback on each host, > > > > > > > and having control over what interfaces or features it expose= s is also > > > > > > > important for stability. > > > > > > > How about we create a 'feature flags' modparam, each bits is = specified for > > > > > > > different new features? > > > > > > At the end, it will be more granular module parameter that user= still > > > > > > will need to guess. > > > > > I believe users always need to know any parameter or any tool's f= lag before > > > > > they use it. > > > > > For example, before user try to set/clear this ctrl_ring_enabled,= they > > > > > should already have basic knowledge about this feature, > > > > > or else they shouldn't use it (the default value is same as befor= e), and > > > > > that's also why we use the 'ctrl_ring_enabled' as parameter name. > > > >=20 > > > > It solves only forward migration flow. Move from machine A with no > > > > option X to machine B with option X. It doesn't work for backward > > > > flow. Move from machine B to A back will probably break. > > > >=20 > > > > In your flow, you want that users will set all module parameters for > > > > every upgrade and keep those parameters differently per-version. > > >=20 > > > I think the flag should be a per guest config item. Adding this item = to > > > the backend Xenstore nodes for netback to consume it should be rather > > > easy. > > >=20 > > > Yes, this would need a change in Xen tools, too, but it is the most > > > flexible way to handle it. And in case of migration the information > > > would be just migrated to the new host with the guest's config data. > >=20 > > Yes, it will overcome global nature of module parameters, but how does > > it solve backward compatibility concern? >=20 > When creating a guest on A the (unknown) feature will not be set to > any value in the guest's config data. A migration stream not having any > value for that feature on B should set it to "false". >=20 > When creating a guest on B it will either have the feature value set > explicitly in the guest config (either true or false), or it will get > the server's default (this value should be configurable in a global > config file, default for that global value would be "true"). >=20 > So with the guest created on B with feature specified as "false" (either > for this guest only, or per global config), it will be migratable to > machine A without problem. Migrating it back to B would work the same > way as above. Trying to migrate a guest with feature set to "true" to > B would not work, but this would be the host admin's fault due to not > configuring the guest correctly. As long as all new features are disabled by default, it will be ok. Thanks >=20 >=20 > Juergen From xen-devel-bounces@lists.xenproject.org Mon Mar 22 08:17:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 08:17:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100032.190448 (Exim 4.92) (envelope-from ) id 1lOFkd-0003yE-4Y; Mon, 22 Mar 2021 08:17:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100032.190448; Mon, 22 Mar 2021 08:17:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOFkd-0003y7-0M; Mon, 22 Mar 2021 08:17:27 +0000 Received: by outflank-mailman (input) for mailman id 100032; Mon, 22 Mar 2021 08:17:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOFkc-0003y2-I8 for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 08:17:26 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 361744bb-cdba-4ba6-a5ec-7bacc7b3d8cb; Mon, 22 Mar 2021 08:17:24 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7C3591042; Mon, 22 Mar 2021 01:17:23 -0700 (PDT) Received: from e123311-lin.arm.com (unknown [10.57.15.231]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 084413F719; Mon, 22 Mar 2021 01:17:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 361744bb-cdba-4ba6-a5ec-7bacc7b3d8cb From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com Subject: [PATCH v8] arm: Add Kconfig entry to select CONFIG_DTB_FILE Date: Mon, 22 Mar 2021 09:17:15 +0100 Message-Id: <20210322081715.26175-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently in order to link existing DTB into Xen image we need to either specify option CONFIG_DTB_FILE on the command line or manually add it into .config. Add Kconfig entry: CONFIG_DTB_FILE to be able to provide the path to DTB we want to embed into Xen image. If no path provided - the dtb will not be embedded. Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" as it is not needed since Kconfig will define it in a header with all the other config options. Move definition of _sdtb into dtb.S to prevent defining it if there is no reference to it or if someone protects _sdtb with #ifdef rather than with .ifnes. If the latter, we will get a compiler error. Signed-off-by: Michal Orzel --- xen/arch/arm/Makefile | 5 ++--- xen/arch/arm/arm32/head.S | 4 ++-- xen/arch/arm/arm64/head.S | 4 ++-- xen/arch/arm/dtb.S | 1 + xen/arch/arm/xen.lds.S | 3 --- xen/common/Kconfig | 10 ++++++++++ 6 files changed, 17 insertions(+), 10 deletions(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 16e6523e2c..46e6a95fec 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -68,9 +68,8 @@ extra-y += $(TARGET_SUBARCH)/head.o #obj-bin-y += ....o -ifdef CONFIG_DTB_FILE +ifneq ($(CONFIG_DTB_FILE),"") obj-y += dtb.o -AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" endif ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c xen.lds: xen.lds.S $(CPP) -P $(a_flags) -MQ $@ -o $@ $< -dtb.o: $(CONFIG_DTB_FILE) +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) .PHONY: clean clean:: diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index c404fa973e..50f019ed98 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -156,10 +156,10 @@ past_zImage: sub r10, r9, r0 /* r10 := phys-offset */ /* Using the DTB in the .dtb section? */ -#ifdef CONFIG_DTB_FILE +.ifnes CONFIG_DTB_FILE,"" ldr r8, =_sdtb add r8, r10 /* r8 := paddr(DTB) */ -#endif +.endif /* Initialize the UART if earlyprintk has been enabled. */ #ifdef CONFIG_EARLY_PRINTK diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 5d44667bd8..f38a8dfca7 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -296,9 +296,9 @@ real_start_efi: sub x20, x19, x0 /* x20 := phys-offset */ /* Using the DTB in the .dtb section? */ -#ifdef CONFIG_DTB_FILE +.ifnes CONFIG_DTB_FILE,"" load_paddr x21, _sdtb -#endif +.endif /* Initialize the UART if earlyprintk has been enabled. */ #ifdef CONFIG_EARLY_PRINTK diff --git a/xen/arch/arm/dtb.S b/xen/arch/arm/dtb.S index c703aef12b..c39f3a095c 100644 --- a/xen/arch/arm/dtb.S +++ b/xen/arch/arm/dtb.S @@ -1,2 +1,3 @@ .section .dtb,#alloc + GLOBAL(_sdtb) .incbin CONFIG_DTB_FILE diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index 004b182acb..fc1d39a886 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -220,11 +220,8 @@ SECTIONS } :text _end = . ; -#ifdef CONFIG_DTB_FILE /* Section for the device tree blob (if any). */ - _sdtb = .; .dtb : { *(.dtb) } :text -#endif /* Sections to be discarded */ /DISCARD/ : { diff --git a/xen/common/Kconfig b/xen/common/Kconfig index eb953d171e..a1755cd380 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -400,6 +400,16 @@ config DOM0_MEM Leave empty if you are not sure what to specify. +config DTB_FILE + string "Absolute path to device tree blob" + depends on HAS_DEVICE_TREE + help + When using a bootloader that has no device tree support or when there + is no bootloader at all, use this option to specify the absolute path + to a device tree that will be linked directly inside Xen binary. + + This is an optional config. Leave empty if not needed. + config TRACEBUFFER bool "Enable tracing infrastructure" if EXPERT default y -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 08:46:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 08:46:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100041.190477 (Exim 4.92) (envelope-from ) id 1lOGCH-0006nC-IZ; Mon, 22 Mar 2021 08:46:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100041.190477; Mon, 22 Mar 2021 08:46:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOGCH-0006n5-FT; Mon, 22 Mar 2021 08:46:01 +0000 Received: by outflank-mailman (input) for mailman id 100041; Mon, 22 Mar 2021 08:46:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOGCG-0006n0-H5 for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 08:46:00 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:fe1e::61b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 88ff52de-bf2f-4ab0-9fcf-915ae4d7a72d; Mon, 22 Mar 2021 08:45:58 +0000 (UTC) Received: from AS8PR04CA0047.eurprd04.prod.outlook.com (2603:10a6:20b:312::22) by AM6PR08MB4167.eurprd08.prod.outlook.com (2603:10a6:20b:ad::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Mon, 22 Mar 2021 08:45:53 +0000 Received: from VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:312:cafe::7a) by AS8PR04CA0047.outlook.office365.com (2603:10a6:20b:312::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Mon, 22 Mar 2021 08:45:53 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT005.mail.protection.outlook.com (10.152.18.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Mon, 22 Mar 2021 08:45:52 +0000 Received: ("Tessian outbound eae0c21066a4:v87"); Mon, 22 Mar 2021 08:45:52 +0000 Received: from 3c02ffebfa19.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E5AACAEC-A6BD-44BE-B5E4-C4D60C82E6ED.1; Mon, 22 Mar 2021 08:45:46 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3c02ffebfa19.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 22 Mar 2021 08:45:46 +0000 Received: from DB7PR08MB3500.eurprd08.prod.outlook.com (2603:10a6:10:49::10) by DB9PR08MB6442.eurprd08.prod.outlook.com (2603:10a6:10:259::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Mon, 22 Mar 2021 08:45:45 +0000 Received: from DB7PR08MB3500.eurprd08.prod.outlook.com ([fe80::5959:35df:3647:b78d]) by DB7PR08MB3500.eurprd08.prod.outlook.com ([fe80::5959:35df:3647:b78d%7]) with mapi id 15.20.3955.025; Mon, 22 Mar 2021 08:45:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88ff52de-bf2f-4ab0-9fcf-915ae4d7a72d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NT0AObk4Ev3tKcCe1mU2Cya2/nyvJkUnm7haIPLQ4dA=; b=NeBgjK00G6AHaHCt7Hgo5+rmQDSw5ZUce8cJXuBj++pMOzwbPLd7atVE4Ht2doRKYwpvEETgL9YrZPWEpMbx3w2IruIpBUFBLN5zZV8nmX92XpUrGNtwRQurYehinl8mk7IUKLOtIdmjpmS3aiYS36djnqd5mPrNYttnqWhIjZk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: fa8cae128acfbca1 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NPH327ymgBCPwZhXs4OcfwHcLLgRfN9cKIJmQa3juBAM43uRXJG+rnY3+/WN1ki8eBSrO67g3RT/6y2uckz7KBrIj5o2+beJDFXRRDjFOnc8+EgDzke0G9koEKopZ/UGo6y/PtBWdJy/Z6jLKKLXl4Fr7tv/Aab77VFz0qOTSLEwqTYaN7zfbuCl//s7SdYiVp6jTVtniwYImJLeXQEQzGk2yX46HKUyjdrZzslBrSUrPSMDM4J15bXHznFPrUF5Xn0iDm92Z4nlH7YLK8m6lIzNwnX+pMa8rQgoxl90EI4QQGGd5wM2x/uSyhKFORiE5Tcy9u9vpnsZNDeLAw1dGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NT0AObk4Ev3tKcCe1mU2Cya2/nyvJkUnm7haIPLQ4dA=; b=TBBDS6Vy7QzVsFa+3ZyL1uIIG+4ICxT9Ic855dSswJjK4qySLFLfWoUpcuC4+0xYQjp/A/GsC70fY8LeMaXkqFsPw4E7JrOCSlkM/XuIcN6sV14coAR4ioVC8pyMdf9wy01JvB5rivZliePEPX05Cg8torZCbVKmidkdQ1KYoKXERIu3PbABRTbcejo9yiNzut3MctmtjX63hhGGV4XSlsXrtpsIUqsXdnYJBfRWZnGEmbwhhksSQpwcRuQNIupuoPRLZ4F4AIVOU83lB8CF4pwp33Ja6lRewDbyQOmSdktoL5hz/qVusB/oVXFe+KvYeRNyKQp5q6JCPEV4mfL81w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NT0AObk4Ev3tKcCe1mU2Cya2/nyvJkUnm7haIPLQ4dA=; b=NeBgjK00G6AHaHCt7Hgo5+rmQDSw5ZUce8cJXuBj++pMOzwbPLd7atVE4Ht2doRKYwpvEETgL9YrZPWEpMbx3w2IruIpBUFBLN5zZV8nmX92XpUrGNtwRQurYehinl8mk7IUKLOtIdmjpmS3aiYS36djnqd5mPrNYttnqWhIjZk= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 5/5] xen/arm: smmuv1: Intelligent SMR allocation Thread-Topic: [PATCH 5/5] xen/arm: smmuv1: Intelligent SMR allocation Thread-Index: AQHXFRE3FfFdAlAZ8Eu9+88zMBZ+gqqGwk6AgAAuSQCABea+AIAC7gYA Date: Mon, 22 Mar 2021 08:45:44 +0000 Message-ID: <17645655-7580-4E22-913E-4D7D919CB7AD@arm.com> References: <789abfb57568dcbaba122ea9b68c627e6c9707c4.1615312254.git.rahul.singh@arm.com> <299c8294-5f76-2fd6-85ec-d20c0b99368b@xen.org> <1C808D23-E8F3-4888-86AD-C37FCBAAD0D1@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.99.251] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7cd4d50e-3f1f-49b5-d950-08d8ed0ee6c2 x-ms-traffictypediagnostic: DB9PR08MB6442:|AM6PR08MB4167: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3383;OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6JY2zNiJK3Xd8FoAvUTpP5t0hxnrU7hHymHfWn1+pxNsVXoeu4g/WAXia5zVkDrr8f5vHuSMGnpLK86uGddh/FMqMrWTqIa3RZC4hI7KzBzwBB7SrWddQJVnmteW8OAQEQu0Qb831tbXaPLldZGcFEPlyHJPMsN//dIaIJ9kV61vcqUIFomDR91y1excx7DQnsq//s1T0ZdnVLX3WK0kS6iiyZZM5by7gNNcM9iCE16WvfO/iok+yWjXB/PEetBmK/54HnWG4raJX7z6eaF+BIyyQrjOvBAEMnrF1uJpv21fRSptf0NpHEMbjwAYWmtof7a+S+Od9HtVqR2bSx2lRz4byvfZvWa0cs24V69Nf+ecMD+PmesNjmfysROMTQRyT9VUfmhEyyBKWcJbjmE7t2JYZGs5oQ7NAIs8JaAMe+NuxdtIVurcs2MVSijZ5YVhFwMPldXQLoNBOAKdgkCepjgm1NJ0SxO/R13SZ3HQx/u64lIVlFiEargWWjsSpqW/O8g4hi8inH0wna3WxSgj1Zv1F55LSCo0lhq91IkdTLV3ryWMWftk42yBbIUyh+WjTyajN3sWuETTuwCLcOPIhOuWEDgIhpZG2Y0moh/GVl0HKFYA8Fc14rsxQSK+/N1eNKIs8+iEzicyDw0Rsc9+OOU1Fx3EmJ4+bvMKTqnZm4MHP1cUPeXAk5SnmG3s74kaMYz/zxcImHGJQGI0r6E2ZQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3500.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(396003)(346002)(136003)(366004)(71200400001)(316002)(8676002)(478600001)(26005)(38100700001)(33656002)(2616005)(5660300002)(6916009)(186003)(4326008)(54906003)(8936002)(6486002)(86362001)(2906002)(36756003)(76116006)(91956017)(6512007)(66476007)(66556008)(66946007)(66446008)(64756008)(53546011)(6506007)(83380400001)(3714002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?qpXZ6Y1u+i+u9EIECMWVG2hzkkYeGJkcyC3d2VL3IfqfWwsunMQqO8Tq4mVL?= =?us-ascii?Q?UYp1V5MGSwWnod4PrHBKf+al8DJbbcX7orurTB5X1atBFDqT/KD3NUDRzDov?= =?us-ascii?Q?Ruhex+gtufgwBpUfAS56zu5YGyNLifpAhon0RtZZeIKZF3awQSr92e1jwBGA?= =?us-ascii?Q?IOS0LQIIf8S6wDDH2cvaLKlpP37xHT+U2fplEljLAJ1k54MBOJ0e15zthM1z?= =?us-ascii?Q?nx2Yc1Dc0vYbc0fIGyj7vrOvB/r8w32egkJdHxChKqvyEW3mq6IrbfLsq0lm?= =?us-ascii?Q?pppoRxqYt5gJ/ArVA0h9k6jChwglsOZOpEYFA+XxuDUoEJy7fZYiU/cTpUAd?= =?us-ascii?Q?Y8hlG3XgNd1BXEBDpJyjGdvdHALhyyCr5+6dFb7EwvZjFGzOYYNeuystz3sN?= =?us-ascii?Q?ciqB1bsugHRonSsGRe0s8pNLpMcuGLTbEBXYpsSYeqeWMoEU7WO05+p4Zz95?= =?us-ascii?Q?ueMXr8idTt+6JwT2MR487s8mG3KucPiDwW71mfs1dltQmIJfoN7836zW0Rsa?= =?us-ascii?Q?B2BLCPQi8DC2+KA8GII8+Tbb/gJ86aHUgRdOSkmcjO8iCgcHRsVA0bGDzlxw?= =?us-ascii?Q?aBCId+D8N08WOqmpi8iM0c5ZG8N0MaSkCQL11+dyNrX/1mFPQz9jMAX4DhR5?= =?us-ascii?Q?HcWDsFtXsYb4IBBjr6sDlZAUQatXxHyz1k3tPOEPuL9bwdt3/JxGhCcNenR3?= =?us-ascii?Q?lsJp6fKclXv8AFKOPr1Y9sOOHxX3OKHiDenWN59mRvaut6em7iyARlbSSsj5?= =?us-ascii?Q?ctbCfO9nwZvQNlnP59qrbYLB29mXwdgSfW3SyuSoz+nB/hRxYrsxPRy/k3mN?= =?us-ascii?Q?XYUpXsVFe6dAqRr+K8kVanUhQ0aMaEahwieo0R+FRegv31CEoyXSL4DgjTgY?= =?us-ascii?Q?nKvxOHzAyzPpX4CjByLtlhpZ60iqUHSV4LgM7EoA/R0ECiQ2AnxU+YnaOp2+?= =?us-ascii?Q?TOBPAXTn6hVouETChJzrgrl3nROYrmKd1UIccFU7bmErm1p54MuYCv2RpQjE?= =?us-ascii?Q?4y4zUFnYKgfYD2W6va52q7NK4e9yX3Ui1x9k/37vHuZrpz0i6Pdrdzm4fGDP?= =?us-ascii?Q?bB7TRg9PsA1hm75UTHCP58dBJXYXmbAc7s2TkgA45ltcLOROME5WfND5T2O+?= =?us-ascii?Q?UzepGvYqQQvMCg2jD3MLv2HQSzKBFlxgVdDSnn5R4wM45VCyRUo89/VGRVMx?= =?us-ascii?Q?jYn8Bk+ew36IWmmIs1xWfVXEAaoz750U8SL73RaRyNtJkLmzP/2iaoWWDKAx?= =?us-ascii?Q?aIjxT8RrvqepzW9P4w+jhaYfWGKy1TAwnb6T8a/2iEthtfVrzcTK4HPsvsGj?= =?us-ascii?Q?LWAX6HCGlJcZRbmAWv++9+tZ?= Content-Type: text/plain; charset="us-ascii" Content-ID: <3EAD3F7D50C03642A3DCDDFF48042476@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6442 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: c5810349-0265-4f68-078f-08d8ed0ee204 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TOAXCz2+c/9dia73sU+/kAav3h/V3KUQwl7GvvSyS+MqiFc5ioxStTOIKmgKXIP4sdh3ZAoOpSgTfhgll8uhZqqNqLVKkzsze8xR+17t83lXOUHhrKE5eYyJSvGe7QGrBhlUv3CtpLKM5I3X46Qqkq2H0duByuQ9qRKsiL1jShz9VRTp9kdVB8q6tgaZPhJGH4vldUFLkL4RuAeE3QdJ3jC40i/vmmOyt0kXN31FRfsFStivwLmAIVSdH1UvhbheGLufIbFu6arzSb9jROSWXuBoGPdslezdNR3UCo62VJZTnlp6SbAGaxXtuW1br/Ms8hplDCnVoqtyMrqdbad38CUX2LPQDSTy59Po+ZqsvzOoBm8+OVPcxPo7OPF5M3KxTjDFbU+3Qpm9vOrM++EW0x6MIGNPX2rauxphGXDDbxy91y2hZvqywE4ZCSFkEZnKSeY+BmKtXkFk7Vv3sDo5/xOGLZvShpJVIlIQHbnLSLCuV2vcWnHVKGiCeEqCPA0u0MciK8xOwPnWTFPvKYaHMONxhvUEfQRrwNMgOzcjXq9sZWo2MWGzFHQNvYJnZLJhxKBTmcieY64wvHk7AeEzwl2eMOGXmJvmFVHBFsshp09n47Pwb0Do63GfzLPkxwZn6s2nrrj9p6uQONVp1E0JoYRRrvfP28aFcfUoCk5WKhVW2lj/gVfaw65y2qsDvtky X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(396003)(136003)(346002)(39860400002)(36840700001)(46966006)(316002)(478600001)(26005)(8676002)(6862004)(36860700001)(336012)(82740400003)(33656002)(5660300002)(2616005)(47076005)(54906003)(4326008)(186003)(8936002)(86362001)(2906002)(82310400003)(36756003)(70586007)(356005)(6512007)(107886003)(83380400001)(53546011)(6506007)(6486002)(81166007)(70206006)(3714002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2021 08:45:52.8430 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7cd4d50e-3f1f-49b5-d950-08d8ed0ee6c2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4167 Hello Julien, > On 20 Mar 2021, at 12:01 pm, Julien Grall wrote: >=20 >=20 >=20 > On 16/03/2021 17:54, Rahul Singh wrote: >> Hello Julien, >=20 > Hi Rahul, >=20 >>> On 16 Mar 2021, at 3:08 pm, Julien Grall wrote: >>>=20 >>> Hi Rahul, >>>=20 >>> On 09/03/2021 18:19, Rahul Singh wrote: >>>> Backport 588888a7399db352d2b1a41c9d5b3bf0fd482390 >>>> "iommu/arm-smmu: Intelligent SMR allocation" from the Linux kernel >>>> This patch fix the stream match conflict issue when two devices have t= he >>>> same stream-id. >>>> Only difference while applying this patch is to use spinlock in place = of >>>> mutex and move iommu_group_alloc(..) function call in >>>> arm_smmu_add_device(..) function from the start of the function >>>> to the end. >>>=20 >>> As you may remember the discussion on the SMMUv3 thread, replacing a sp= inlock by a mutex has consequences. Can you explain why this is fine? >> Yes, I remember the discussion on the SMMUv3 thread, replacing a spinloc= k with a mutex has consequences. >> I replaced the mutex with spinlock in the SMMUv1 code when we are config= uring the SMMUv1 hardware arm_smmu_master_alloc_smes(..). >> I think it is fine to use the spinlock in place of mutex in SMMUv1 where= we are configuring the hardware via registers as compared to SMMUv3 where = we are configuring the SMMUv3 hardware with Memory-based circular buffer qu= eues. Configuring the hardware via queues might take a long time that why m= utex is a good choice but if we are configuring the hardware via registers = it is very fast. >> Configuring the SMMUv1 with the register is very fast and there are no s= ide effects of this if we use spinlock. Let me know your view on this. >=20 > This looks fine. Can you explain it the commit message? Yes, I will add the explanation in the commit message and will send the v2. Regards, Rahul >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Mar 22 10:33:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 10:33:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100121.190543 (Exim 4.92) (envelope-from ) id 1lOHrk-0000TX-Br; Mon, 22 Mar 2021 10:32:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100121.190543; Mon, 22 Mar 2021 10:32:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOHrk-0000TQ-8b; Mon, 22 Mar 2021 10:32:56 +0000 Received: by outflank-mailman (input) for mailman id 100121; Mon, 22 Mar 2021 10:32:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOHrj-0000TL-K7 for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 10:32:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOHrj-0001Ct-JF for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 10:32:55 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOHrj-0002ki-IL for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 10:32:55 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOHrg-00083n-Ap; Mon, 22 Mar 2021 10:32:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=vtPSTz4CW1VPx+bNbF230raYrB2ZHcoGx51a9ARb9JQ=; b=1MAgjRrVn55TIBgUq26iYA/VfS 4Bd8rKKfgqDECeiO8CX2e/EAocuk5b2gMkM9bhawCo6YxD1MQziAkvndsgOaIj8prabj7uoC8gHP6 FwdgRV3NoZcgSk6EuvNoYu6nq+UVw36KID9lQfaoys3UyV5N/NueeGZYWczSww7plyu0=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24664.29268.129126.416099@mariner.uk.xensource.com> Date: Mon, 22 Mar 2021 10:32:52 +0000 To: Julien Grall Cc: xen-devel@lists.xenproject.org, Julien Grall , Juergen Gross Subject: Re: [PATCH for-4.15 v3] SUPPORT.MD: Mark LiveUpdate of C/OCaml XenStored daemon as Tech Preview In-Reply-To: References: <20210317120854.19903-1-julien@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("Re: [PATCH for-4.15 v3] SUPPORT.MD: Mark LiveUpdate of C/OCaml XenStored daemon as Tech Preview"): > Sorry I forgot to CC you on the original Ian. Would it be possible to > give an R-A for the patch below? Sure, Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Mon Mar 22 10:38:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 10:38:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100125.190559 (Exim 4.92) (envelope-from ) id 1lOHx8-0000iI-10; Mon, 22 Mar 2021 10:38:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100125.190559; Mon, 22 Mar 2021 10:38:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOHx7-0000iB-U9; Mon, 22 Mar 2021 10:38:29 +0000 Received: by outflank-mailman (input) for mailman id 100125; Mon, 22 Mar 2021 10:38:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOHx7-0000i6-1j for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 10:38:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOHx3-0001IY-L0; Mon, 22 Mar 2021 10:38:25 +0000 Received: from [54.239.6.177] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lOHx3-00039v-B7; Mon, 22 Mar 2021 10:38:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=QCoak+ANm+NEE5qZKDNlUXJHy9E+KUH97l9vkmQOqUM=; b=as+49ftfqwa7Nhj6+PY+fBo6Mp fq7lTwKodhbt7itkbQo9JgS9BwA+JLBD4EL0LD4yebor8TaUgDE/p2J7hqgSr8P8+lrE6BLGlJeHU UuTA1CxOX/MbWihV9R1weVFhQjVhNcTGL8L1GzV/ej/373vZOeFtmFKUUBaexPxby+I0=; Subject: Re: [PATCH for-4.15 v3] SUPPORT.MD: Mark LiveUpdate of C/OCaml XenStored daemon as Tech Preview To: Ian Jackson Cc: xen-devel@lists.xenproject.org, Julien Grall , Juergen Gross References: <20210317120854.19903-1-julien@xen.org> <24664.29268.129126.416099@mariner.uk.xensource.com> From: Julien Grall Message-ID: <0d43dbe3-9ed6-6b54-2aac-2be185283de0@xen.org> Date: Mon, 22 Mar 2021 10:38:23 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <24664.29268.129126.416099@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Ian, On 22/03/2021 10:32, Ian Jackson wrote: > Julien Grall writes ("Re: [PATCH for-4.15 v3] SUPPORT.MD: Mark LiveUpdate of C/OCaml XenStored daemon as Tech Preview"): >> Sorry I forgot to CC you on the original Ian. Would it be possible to >> give an R-A for the patch below? > > Sure, > > Release-Acked-by: Ian Jackson Thanks! I will also s/XenStored/xenstored/ as you pointed out on IRC. Cheers, > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Mar 22 10:39:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 10:39:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100129.190571 (Exim 4.92) (envelope-from ) id 1lOHy0-0000pz-Ah; Mon, 22 Mar 2021 10:39:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100129.190571; Mon, 22 Mar 2021 10:39:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOHy0-0000ps-7Q; Mon, 22 Mar 2021 10:39:24 +0000 Received: by outflank-mailman (input) for mailman id 100129; Mon, 22 Mar 2021 10:39:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOHxy-0000pm-Ch for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 10:39:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOHxy-0001JN-B8 for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 10:39:22 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOHxy-0003Dc-AD for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 10:39:22 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOHxt-00084v-Ip; Mon, 22 Mar 2021 10:39:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:CC:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=dTgu+ZmNB6jLiEXtr4zaPwKP0l7BuML/9AULT5g8M9c=; b=Yg+gV6JFoLNPL9bS09J5aDuIRO mO4AubrR7JQUhAfDh55y0utzRg/Drn14CNIud+p58eMCAasMGYYfeGXhRYE2/x//6LyEvwYkjvkZM jlDvUQBdECuzrT47hV7XkrhAvW+ec/M3PICYRNePA0gnNWal0qplO4aIh+Ur22Zri97M=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24664.29653.380819.75765@mariner.uk.xensource.com> Date: Mon, 22 Mar 2021 10:39:17 +0000 To: Anthony PERARD CC: Peter Maydell , xen-devel@lists.xenproject.org Subject: Re: [qemu-mainline bisection] complete test-amd64-amd64-qemuu-freebsd11-amd64 In-Reply-To: References: X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) (CCing Peter FYI, not because I think there is anything wrong on the qemu side here...) Anthony, would you be able to look at this ? I'm *hoping* we only need to update our command line generation code in libxl. With the Xen 4.15 freeze ongoing, whether such a change gets into 4.15 will depend on how big it is. Thanks, Ian. osstest service owner writes ("[qemu-mainline bisection] complete test-amd64-amd64-qemuu-freebsd11-amd64"): > branch xen-unstable > xenbranch xen-unstable > job test-amd64-amd64-qemuu-freebsd11-amd64 > testid guest-saverestore > > Tree: linux git://xenbits.xen.org/linux-pvops.git > Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git > Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git > Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git > Tree: qemuu git://git.qemu.org/qemu.git > Tree: seabios git://xenbits.xen.org/osstest/seabios.git > Tree: xen git://xenbits.xen.org/xen.git > > *** Found and reproduced problem changeset *** > > Bug is in tree: qemuu git://git.qemu.org/qemu.git > Bug introduced: 1b507e55f8199eaad99744613823f6929e4d57c6 > Bug not present: 4083904bc9fe5da580f7ca397b1e828fbc322732 > Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160218/ > > > commit 1b507e55f8199eaad99744613823f6929e4d57c6 > Merge: 4083904bc9 8d17adf34f > Author: Peter Maydell > Date: Thu Mar 18 19:00:49 2021 +0000 > > Merge remote-tracking branch 'remotes/berrange-gitlab/tags/dep-many-pull-request' into staging > > Remove many old deprecated features > > The following features have been deprecated for well over the 2 > release cycle we promise > > ``-drive file=json:{...{'driver':'file'}}`` (since 3.0) > ``-vnc acl`` (since 4.0.0) > ``-mon ...,control=readline,pretty=on|off`` (since 4.1) > ``migrate_set_downtime`` and ``migrate_set_speed`` (since 2.8.0) > ``query-named-block-nodes`` result ``encryption_key_missing`` (since 2.10.0) > ``query-block`` result ``inserted.encryption_key_missing`` (since 2.10.0) > ``migrate-set-cache-size`` and ``query-migrate-cache-size`` (since 2.11.0) > ``query-named-block-nodes`` and ``query-block`` result dirty-bitmaps[i].status (since 4.0) > ``query-cpus`` (since 2.12.0) > ``query-cpus-fast`` ``arch`` output member (since 3.0.0) > ``query-events`` (since 4.0) > chardev client socket with ``wait`` option (since 4.0) > ``acl_show``, ``acl_reset``, ``acl_policy``, ``acl_add``, ``acl_remove`` (since 4.0.0) > ``ide-drive`` (since 4.2) > ``scsi-disk`` (since 4.2) ... > Revision graph left in /home/logs/results/bisect/qemu-mainline/test-amd64-amd64-qemuu-freebsd11-amd64.guest-saverestore.{dot,ps,png,html,svg}. > ---------------------------------------- > 160218: tolerable ALL FAIL > > flight 160218 qemu-mainline real-bisect [real] > http://logs.test-lab.xenproject.org/osstest/logs/160218/ > > Failures :-/ but no regressions. > > Tests which did not succeed, > including tests which could not be run: > test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail baseline untested > > > jobs: > test-amd64-amd64-qemuu-freebsd11-amd64 fail From xen-devel-bounces@lists.xenproject.org Mon Mar 22 10:56:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 10:56:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100136.190596 (Exim 4.92) (envelope-from ) id 1lOIER-0002fB-Vd; Mon, 22 Mar 2021 10:56:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100136.190596; Mon, 22 Mar 2021 10:56:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIER-0002f4-Rf; Mon, 22 Mar 2021 10:56:23 +0000 Received: by outflank-mailman (input) for mailman id 100136; Mon, 22 Mar 2021 10:56:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIEQ-0002ew-Fy; Mon, 22 Mar 2021 10:56:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIEQ-0001bg-8F; Mon, 22 Mar 2021 10:56:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIEQ-0002eF-0B; Mon, 22 Mar 2021 10:56:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOIEP-0005jS-Vy; Mon, 22 Mar 2021 10:56:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mAjkb/UUwwC5DLQVOgfnIyMkaY8iez1n300B2zOTLCQ=; b=t6rxw9uI7yk4YNiSh+C1NcWqsp FpPA+2SnxHchywA+iB4iocmld2HG8eERVInp2whUKFegFGD8bbNtpTqS1iyPxG1RRRuM86J9ONif5 ZyECUzPTbYQdWo6xKzGm7gUQUZOOCe9mvthDTLh5+gGXVZrGUxuDy9NRTJRiEK5uKCUc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160159: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=dae3c3e8b257cd27d6b35a467a34bf79a6650340 X-Osstest-Versions-That: xen=dae3c3e8b257cd27d6b35a467a34bf79a6650340 From: osstest service owner Date: Mon, 22 Mar 2021 10:56:21 +0000 flight 160159 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160159/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160144 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160144 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160144 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160144 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160144 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160144 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160144 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160144 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160144 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160144 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160144 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: xen dae3c3e8b257cd27d6b35a467a34bf79a6650340 baseline version: xen dae3c3e8b257cd27d6b35a467a34bf79a6650340 Last test of basis 160159 2021-03-21 00:41:55 Z 1 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Mar 22 10:58:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 10:58:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100143.190611 (Exim 4.92) (envelope-from ) id 1lOIGk-0002uX-M3; Mon, 22 Mar 2021 10:58:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100143.190611; Mon, 22 Mar 2021 10:58:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIGk-0002uQ-J9; Mon, 22 Mar 2021 10:58:46 +0000 Received: by outflank-mailman (input) for mailman id 100143; Mon, 22 Mar 2021 10:58:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIGj-0002uF-2p for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 10:58:45 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ffcb592c-6243-45ae-960b-7ca1bdfedfa2; Mon, 22 Mar 2021 10:58:43 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F23EAAD4A; Mon, 22 Mar 2021 10:58:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ffcb592c-6243-45ae-960b-7ca1bdfedfa2 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616410723; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tjSqSzrxyOhDRheoWrWFZDUlo6j7nic01nXgHuiD6/I=; b=Lm6IBvisEECX07+Kcy68KmyXjWZgSvIrDzlT3NzO5X3/0mDAueKJRvJnyKuMaKk+vKVV/p dQctHr1vG8YGXnQY/F5vEx6745abV9WUmehlWWsx8AP7DO9VSr2lcA/yP8wEWW5NAqJgf3 C98WNTPPoIt+aZ7IWRZSSxmWrtdmmOg= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH 0/6] tools/libs: add missing support of linear p2m_list, cleanup Date: Mon, 22 Mar 2021 11:58:34 +0100 Message-Id: <20210322105840.11224-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are some corners left which don't support the not so very new linear p2m list of pv guests, which has been introduced in Linux kernel 3.19 and which is mandatory for non-legacy versions of Xen since kernel 4.14. This series adds support for the linear p2m list where it is missing (colo support and "xl dump-core"). In theory it should be possible to merge the p2m list mapping code from migration handling and core dump handling, but this needs quite some cleanup before this is possible. The first three patches of this series are fixing real problems, so I've put them at the start of this series, especially in order to make backports easier. The other three patches are only the first steps of cleanup. The main work done here is to concentrate all p2m mapping in libxenguest instead of having one implementation in each of libxenguest and libxenctrl. Merging the two implementations should be rather easy, but this will require to touch many lines of code, as the migration handling variant seems to be more mature, but it is using the migration stream specific structures heavily. So I'd like to have some confirmation that my way to clean this up is the right one. My idea would be to add the data needed for p2m mapping to struct domain_info_context and replace the related fields in struct xc_sr_context with a struct domain_info_context. Modifying the interface of xc_core_arch_map_p2m() to take most current parameters via struct domain_info_context would then enable migration coding to use xc_core_arch_map_p2m() for mapping the p2m. xc_core_arch_map_p2m() should look basically like the current migration p2m mapping code afterwards. Any comments to that plan? Juergen Gross (6): tools/libs/guest: fix max_pfn setting in map_p2m() tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table tools/libs/ctrl: use common p2m mapping code in xc_domain_resume_any() tools/libs: move xc_resume.c to libxenguest tools/libs: move xc_core* from libxenctrl to libxenguest tools/libs/guest: make some definitions private to libxenguest tools/include/xenctrl.h | 63 --- tools/include/xenguest.h | 63 +++ tools/libs/ctrl/Makefile | 4 - tools/libs/ctrl/xc_core_x86.c | 223 ---------- tools/libs/ctrl/xc_domain.c | 2 - tools/libs/ctrl/xc_private.h | 43 +- tools/libs/guest/Makefile | 4 + .../libs/{ctrl/xc_core.c => guest/xg_core.c} | 7 +- .../libs/{ctrl/xc_core.h => guest/xg_core.h} | 15 +- .../xc_core_arm.c => guest/xg_core_arm.c} | 31 +- .../xc_core_arm.h => guest/xg_core_arm.h} | 0 tools/libs/guest/xg_core_x86.c | 399 ++++++++++++++++++ .../xc_core_x86.h => guest/xg_core_x86.h} | 0 tools/libs/guest/xg_dom_boot.c | 2 +- tools/libs/guest/xg_domain.c | 19 +- tools/libs/guest/xg_offline_page.c | 2 +- tools/libs/guest/xg_private.h | 16 +- .../{ctrl/xc_resume.c => guest/xg_resume.c} | 69 +-- tools/libs/guest/xg_sr_save_x86_pv.c | 2 +- 19 files changed, 544 insertions(+), 420 deletions(-) delete mode 100644 tools/libs/ctrl/xc_core_x86.c rename tools/libs/{ctrl/xc_core.c => guest/xg_core.c} (99%) rename tools/libs/{ctrl/xc_core.h => guest/xg_core.h} (92%) rename tools/libs/{ctrl/xc_core_arm.c => guest/xg_core_arm.c} (72%) rename tools/libs/{ctrl/xc_core_arm.h => guest/xg_core_arm.h} (100%) create mode 100644 tools/libs/guest/xg_core_x86.c rename tools/libs/{ctrl/xc_core_x86.h => guest/xg_core_x86.h} (100%) rename tools/libs/{ctrl/xc_resume.c => guest/xg_resume.c} (80%) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 10:58:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 10:58:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100144.190622 (Exim 4.92) (envelope-from ) id 1lOIGl-0002vu-Tw; Mon, 22 Mar 2021 10:58:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100144.190622; Mon, 22 Mar 2021 10:58:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIGl-0002vl-Qn; Mon, 22 Mar 2021 10:58:47 +0000 Received: by outflank-mailman (input) for mailman id 100144; Mon, 22 Mar 2021 10:58:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIGk-0002uK-DF for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 10:58:46 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ba060220-ad9c-463c-95c0-c97de1519a6e; Mon, 22 Mar 2021 10:58:43 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 22E90AD79; Mon, 22 Mar 2021 10:58:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba060220-ad9c-463c-95c0-c97de1519a6e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616410723; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r2eCqlORFLfVmLFfiEovHQm+H5lydtlCD/BZ4XW/beY=; b=A4bADNg+6697VwI4UcAjmrjv9AZlaVwjMiQufCU5j33i23rNv5aAu3fl/NIMZfjGIeJMEx 11jc6d8cd8G+JoIJXF1Y5VmcLpkZsLfLpL6hAfAUhwz5LNZVY9IkTqs2VBwxFkXilv4JRv f4NSVhN7j/3QZKHPggOlAIpHpfa+/ZQ= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH 1/6] tools/libs/guest: fix max_pfn setting in map_p2m() Date: Mon, 22 Mar 2021 11:58:35 +0100 Message-Id: <20210322105840.11224-2-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210322105840.11224-1-jgross@suse.com> References: <20210322105840.11224-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When setting the highest pfn used in the guest, don't subtract 1 from the value read from the shared_info data. The value read already is the correct pfn. Fixes: 91e204d37f449 ("libxc: try to find last used pfn when migrating") Signed-off-by: Juergen Gross --- This is a backport candidate --- tools/libs/guest/xg_sr_save_x86_pv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/guest/xg_sr_save_x86_pv.c b/tools/libs/guest/xg_sr_save_x86_pv.c index 4964f1f7b8..dae7f2817f 100644 --- a/tools/libs/guest/xg_sr_save_x86_pv.c +++ b/tools/libs/guest/xg_sr_save_x86_pv.c @@ -468,7 +468,7 @@ static int map_p2m(struct xc_sr_context *ctx) ctx->x86.pv.p2m_generation = ~0ULL; ctx->x86.pv.max_pfn = GET_FIELD(ctx->x86.pv.shinfo, arch.max_pfn, - ctx->x86.pv.width) - 1; + ctx->x86.pv.width); p2m_cr3 = GET_FIELD(ctx->x86.pv.shinfo, arch.p2m_cr3, ctx->x86.pv.width); return p2m_cr3 ? map_p2m_list(ctx, p2m_cr3) : map_p2m_tree(ctx); -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 10:58:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 10:58:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100145.190635 (Exim 4.92) (envelope-from ) id 1lOIGp-0002yw-7D; Mon, 22 Mar 2021 10:58:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100145.190635; Mon, 22 Mar 2021 10:58:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIGp-0002yo-30; Mon, 22 Mar 2021 10:58:51 +0000 Received: by outflank-mailman (input) for mailman id 100145; Mon, 22 Mar 2021 10:58:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIGo-0002uF-1D for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 10:58:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2d8f94fb-3b04-4247-a4e5-e9ccfe4f623c; Mon, 22 Mar 2021 10:58:44 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 52529ADAA; Mon, 22 Mar 2021 10:58:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d8f94fb-3b04-4247-a4e5-e9ccfe4f623c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616410723; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hsU1Tia/8TAchqKhiuRA5Y2svprMqymbiqcqRl8SGa0=; b=Xa3SH5Jm9gvR826bDKnDRnIOARNUe4kStg8hl41mD5GQ862r2UKEzmZcQA3UpYGRfRbs7z F/EJ7IwZOl22S0M5lcI89ZgbWafNrPp5q5axS64Hlve7Q/xzugJa/TT0lhhdvA+KfPniCG 9Ml1Yg27h/mrXr6l7mkPzFO+zg+2ZrU= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH 2/6] tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table Date: Mon, 22 Mar 2021 11:58:36 +0100 Message-Id: <20210322105840.11224-3-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210322105840.11224-1-jgross@suse.com> References: <20210322105840.11224-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The core of a pv linux guest produced via "xl dump-core" is nor usable as since kernel 4.14 only the linear p2m table is kept if Xen indicates it is supporting that. Unfortunately xc_core_arch_map_p2m() is still supporting the 3-level p2m tree only. Fix that by copying the functionality of map_p2m() from libxenguest to libxenctrl. Additionally the mapped p2m isn't of a fixed length now, so the interface to the mapping functions needs to be adapted. In order not to add even more parameters, expand struct domain_info_context and use a pointer to that as a parameter. Fixes: dc6d60937121 ("libxc: set flag for support of linear p2m list in domain builder") Signed-off-by: Juergen Gross --- This is a backport candidate. --- tools/include/xenguest.h | 1 + tools/libs/ctrl/xc_core.c | 5 +- tools/libs/ctrl/xc_core.h | 8 +- tools/libs/ctrl/xc_core_arm.c | 23 +-- tools/libs/ctrl/xc_core_x86.c | 256 ++++++++++++++++++++++++++++------ tools/libs/ctrl/xc_private.h | 1 + tools/libs/guest/xg_domain.c | 17 +-- 7 files changed, 233 insertions(+), 78 deletions(-) diff --git a/tools/include/xenguest.h b/tools/include/xenguest.h index 217022b6e7..781d40c119 100644 --- a/tools/include/xenguest.h +++ b/tools/include/xenguest.h @@ -700,6 +700,7 @@ struct xc_domain_meminfo { xen_pfn_t *pfn_type; xen_pfn_t *p2m_table; unsigned long p2m_size; + unsigned int p2m_frames; }; int xc_map_domain_meminfo(xc_interface *xch, uint32_t domid, diff --git a/tools/libs/ctrl/xc_core.c b/tools/libs/ctrl/xc_core.c index b47ab2f6d8..9576bec5a3 100644 --- a/tools/libs/ctrl/xc_core.c +++ b/tools/libs/ctrl/xc_core.c @@ -574,8 +574,7 @@ xc_domain_dumpcore_via_callback(xc_interface *xch, goto out; } - sts = xc_core_arch_map_p2m(xch, dinfo->guest_width, &info, live_shinfo, - &p2m, &dinfo->p2m_size); + sts = xc_core_arch_map_p2m(xch, dinfo, &info, live_shinfo, &p2m); if ( sts != 0 ) goto out; @@ -945,7 +944,7 @@ out: if ( memory_map != NULL ) free(memory_map); if ( p2m != NULL ) - munmap(p2m, PAGE_SIZE * P2M_FL_ENTRIES); + munmap(p2m, PAGE_SIZE * dinfo->p2m_frames); if ( p2m_array != NULL ) free(p2m_array); if ( pfn_array != NULL ) diff --git a/tools/libs/ctrl/xc_core.h b/tools/libs/ctrl/xc_core.h index 36fb755da2..8ea1f93a10 100644 --- a/tools/libs/ctrl/xc_core.h +++ b/tools/libs/ctrl/xc_core.h @@ -138,14 +138,14 @@ int xc_core_arch_memory_map_get(xc_interface *xch, xc_dominfo_t *info, shared_info_any_t *live_shinfo, xc_core_memory_map_t **mapp, unsigned int *nr_entries); -int xc_core_arch_map_p2m(xc_interface *xch, unsigned int guest_width, +int xc_core_arch_map_p2m(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, shared_info_any_t *live_shinfo, - xen_pfn_t **live_p2m, unsigned long *pfnp); + xen_pfn_t **live_p2m); -int xc_core_arch_map_p2m_writable(xc_interface *xch, unsigned int guest_width, +int xc_core_arch_map_p2m_writable(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, shared_info_any_t *live_shinfo, - xen_pfn_t **live_p2m, unsigned long *pfnp); + xen_pfn_t **live_p2m); int xc_core_arch_get_scratch_gpfn(xc_interface *xch, uint32_t domid, xen_pfn_t *gpfn); diff --git a/tools/libs/ctrl/xc_core_arm.c b/tools/libs/ctrl/xc_core_arm.c index 7b587b4cc5..93765a565f 100644 --- a/tools/libs/ctrl/xc_core_arm.c +++ b/tools/libs/ctrl/xc_core_arm.c @@ -66,33 +66,24 @@ xc_core_arch_memory_map_get(xc_interface *xch, struct xc_core_arch_context *unus static int xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, - shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, - unsigned long *pfnp, int rw) + shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, int rw) { errno = ENOSYS; return -1; } int -xc_core_arch_map_p2m(xc_interface *xch, unsigned int guest_width, xc_dominfo_t *info, - shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, - unsigned long *pfnp) +xc_core_arch_map_p2m(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, + shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m) { - struct domain_info_context _dinfo = { .guest_width = guest_width }; - struct domain_info_context *dinfo = &_dinfo; - return xc_core_arch_map_p2m_rw(xch, dinfo, info, - live_shinfo, live_p2m, pfnp, 0); + return xc_core_arch_map_p2m_rw(xch, dinfo, info, live_shinfo, live_p2m, 0); } int -xc_core_arch_map_p2m_writable(xc_interface *xch, unsigned int guest_width, xc_dominfo_t *info, - shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, - unsigned long *pfnp) +xc_core_arch_map_p2m_writable(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, + shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m) { - struct domain_info_context _dinfo = { .guest_width = guest_width }; - struct domain_info_context *dinfo = &_dinfo; - return xc_core_arch_map_p2m_rw(xch, dinfo, info, - live_shinfo, live_p2m, pfnp, 1); + return xc_core_arch_map_p2m_rw(xch, dinfo, info, live_shinfo, live_p2m, 1); } int diff --git a/tools/libs/ctrl/xc_core_x86.c b/tools/libs/ctrl/xc_core_x86.c index cb76e6207b..c8f71d4b75 100644 --- a/tools/libs/ctrl/xc_core_x86.c +++ b/tools/libs/ctrl/xc_core_x86.c @@ -17,6 +17,7 @@ * */ +#include #include "xc_private.h" #include "xc_core.h" #include @@ -65,34 +66,169 @@ xc_core_arch_memory_map_get(xc_interface *xch, struct xc_core_arch_context *unus return 0; } -static int -xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, - shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, - unsigned long *pfnp, int rw) +static inline bool is_canonical_address(uint64_t vaddr) { - /* Double and single indirect references to the live P2M table */ - xen_pfn_t *live_p2m_frame_list_list = NULL; - xen_pfn_t *live_p2m_frame_list = NULL; - /* Copies of the above. */ - xen_pfn_t *p2m_frame_list_list = NULL; - xen_pfn_t *p2m_frame_list = NULL; + return ((int64_t)vaddr >> 47) == ((int64_t)vaddr >> 63); +} - uint32_t dom = info->domid; - int ret = -1; - int err; - int i; +/* Virtual address ranges reserved for hypervisor. */ +#define HYPERVISOR_VIRT_START_X86_64 0xFFFF800000000000ULL +#define HYPERVISOR_VIRT_END_X86_64 0xFFFF87FFFFFFFFFFULL - if ( xc_domain_nr_gpfns(xch, info->domid, &dinfo->p2m_size) < 0 ) +#define HYPERVISOR_VIRT_START_X86_32 0x00000000F5800000ULL +#define HYPERVISOR_VIRT_END_X86_32 0x00000000FFFFFFFFULL + +static xen_pfn_t * +xc_core_arch_map_p2m_list_rw(xc_interface *xch, struct domain_info_context *dinfo, + uint32_t dom, shared_info_any_t *live_shinfo, + uint64_t p2m_cr3) +{ + uint64_t p2m_vaddr, p2m_end, mask, off; + xen_pfn_t p2m_mfn, mfn, saved_mfn, max_pfn; + uint64_t *ptes = NULL; + xen_pfn_t *mfns = NULL; + unsigned int fpp, n_pages, level, n_levels, shift, + idx_start, idx_end, idx, saved_idx; + + p2m_vaddr = GET_FIELD(live_shinfo, arch.p2m_vaddr, dinfo->guest_width); + fpp = PAGE_SIZE / dinfo->guest_width; + dinfo->p2m_frames = (dinfo->p2m_size - 1) / fpp + 1; + p2m_end = p2m_vaddr + dinfo->p2m_frames * PAGE_SIZE - 1; + + if ( dinfo->guest_width == 8 ) { - ERROR("Could not get maximum GPFN!"); - goto out; + mask = 0x0000ffffffffffffULL; + n_levels = 4; + p2m_mfn = p2m_cr3 >> 12; + if ( !is_canonical_address(p2m_vaddr) || + !is_canonical_address(p2m_end) || + p2m_end < p2m_vaddr || + (p2m_vaddr <= HYPERVISOR_VIRT_END_X86_64 && + p2m_end > HYPERVISOR_VIRT_START_X86_64) ) + { + ERROR("Bad virtual p2m address range %#" PRIx64 "-%#" PRIx64, + p2m_vaddr, p2m_end); + errno = ERANGE; + goto out; + } + } + else + { + mask = 0x00000000ffffffffULL; + n_levels = 3; + if ( p2m_cr3 & ~mask ) + p2m_mfn = ~0UL; + else + p2m_mfn = (uint32_t)((p2m_cr3 >> 12) | (p2m_cr3 << 20)); + if ( p2m_vaddr > mask || p2m_end > mask || p2m_end < p2m_vaddr || + (p2m_vaddr <= HYPERVISOR_VIRT_END_X86_32 && + p2m_end > HYPERVISOR_VIRT_START_X86_32) ) + { + ERROR("Bad virtual p2m address range %#" PRIx64 "-%#" PRIx64, + p2m_vaddr, p2m_end); + errno = ERANGE; + goto out; + } } - if ( dinfo->p2m_size < info->nr_pages ) + mfns = malloc(sizeof(*mfns)); + if ( !mfns ) { - ERROR("p2m_size < nr_pages -1 (%lx < %lx", dinfo->p2m_size, info->nr_pages - 1); + ERROR("Cannot allocate memory for array of %u mfns", 1); goto out; } + mfns[0] = p2m_mfn; + off = 0; + saved_mfn = 0; + idx_start = idx_end = saved_idx = 0; + + for ( level = n_levels; level > 0; level-- ) + { + n_pages = idx_end - idx_start + 1; + ptes = xc_map_foreign_pages(xch, dom, PROT_READ, mfns, n_pages); + if ( !ptes ) + { + PERROR("Failed to map %u page table pages for p2m list", n_pages); + goto out; + } + free(mfns); + + shift = level * 9 + 3; + idx_start = ((p2m_vaddr - off) & mask) >> shift; + idx_end = ((p2m_end - off) & mask) >> shift; + idx = idx_end - idx_start + 1; + mfns = malloc(sizeof(*mfns) * idx); + if ( !mfns ) + { + ERROR("Cannot allocate memory for array of %u mfns", idx); + goto out; + } + + for ( idx = idx_start; idx <= idx_end; idx++ ) + { + mfn = (ptes[idx] & 0x000ffffffffff000ULL) >> PAGE_SHIFT; + if ( mfn == 0 ) + { + ERROR("Bad mfn %#lx during page table walk for vaddr %#" PRIx64 " at level %d of p2m list", + mfn, off + ((uint64_t)idx << shift), level); + errno = ERANGE; + goto out; + } + mfns[idx - idx_start] = mfn; + + /* Maximum pfn check at level 2. Same reasoning as for p2m tree. */ + if ( level == 2 ) + { + if ( mfn != saved_mfn ) + { + saved_mfn = mfn; + saved_idx = idx - idx_start; + } + } + } + + if ( level == 2 ) + { + if ( saved_idx == idx_end ) + saved_idx++; + max_pfn = ((xen_pfn_t)saved_idx << 9) * fpp; + if ( max_pfn < dinfo->p2m_size ) + { + dinfo->p2m_size = max_pfn; + dinfo->p2m_frames = (dinfo->p2m_size + fpp - 1) / fpp; + p2m_end = p2m_vaddr + dinfo->p2m_frames * PAGE_SIZE - 1; + idx_end = idx_start + saved_idx; + } + } + + munmap(ptes, n_pages * PAGE_SIZE); + ptes = NULL; + off = p2m_vaddr & ((mask >> shift) << shift); + } + + return mfns; + + out: + free(mfns); + if ( ptes ) + munmap(ptes, n_pages * PAGE_SIZE); + + return NULL; +} + +static xen_pfn_t * +xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct domain_info_context *dinfo, + uint32_t dom, shared_info_any_t *live_shinfo) +{ + /* Double and single indirect references to the live P2M table */ + xen_pfn_t *live_p2m_frame_list_list; + xen_pfn_t *live_p2m_frame_list = NULL; + /* Copies of the above. */ + xen_pfn_t *p2m_frame_list_list = NULL; + xen_pfn_t *p2m_frame_list; + + int err; + int i; live_p2m_frame_list_list = xc_map_foreign_range(xch, dom, PAGE_SIZE, PROT_READ, @@ -151,10 +287,60 @@ xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc for ( i = P2M_FL_ENTRIES - 1; i >= 0; i-- ) p2m_frame_list[i] = ((uint32_t *)p2m_frame_list)[i]; + dinfo->p2m_frames = P2M_FL_ENTRIES; + + return p2m_frame_list; + + out: + err = errno; + + if ( live_p2m_frame_list_list ) + munmap(live_p2m_frame_list_list, PAGE_SIZE); + + if ( live_p2m_frame_list ) + munmap(live_p2m_frame_list, P2M_FLL_ENTRIES * PAGE_SIZE); + + free(p2m_frame_list_list); + + errno = err; + + return NULL; +} + +static int +xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, + shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, int rw) +{ + xen_pfn_t *p2m_frame_list = NULL; + uint64_t p2m_cr3; + uint32_t dom = info->domid; + int ret = -1; + int err; + + if ( xc_domain_nr_gpfns(xch, info->domid, &dinfo->p2m_size) < 0 ) + { + ERROR("Could not get maximum GPFN!"); + goto out; + } + + if ( dinfo->p2m_size < info->nr_pages ) + { + ERROR("p2m_size < nr_pages -1 (%lx < %lx", dinfo->p2m_size, info->nr_pages - 1); + goto out; + } + + p2m_cr3 = GET_FIELD(live_shinfo, arch.p2m_cr3, dinfo->guest_width); + + p2m_frame_list = p2m_cr3 ? xc_core_arch_map_p2m_list_rw(xch, dinfo, dom, live_shinfo, p2m_cr3) + : xc_core_arch_map_p2m_tree_rw(xch, dinfo, dom, live_shinfo); + + if ( !p2m_frame_list ) + goto out; + *live_p2m = xc_map_foreign_pages(xch, dom, rw ? (PROT_READ | PROT_WRITE) : PROT_READ, p2m_frame_list, - P2M_FL_ENTRIES); + dinfo->p2m_frames); if ( !*live_p2m ) { @@ -162,21 +348,11 @@ xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc goto out; } - *pfnp = dinfo->p2m_size; - ret = 0; out: err = errno; - if ( live_p2m_frame_list_list ) - munmap(live_p2m_frame_list_list, PAGE_SIZE); - - if ( live_p2m_frame_list ) - munmap(live_p2m_frame_list, P2M_FLL_ENTRIES * PAGE_SIZE); - - free(p2m_frame_list_list); - free(p2m_frame_list); errno = err; @@ -184,25 +360,17 @@ out: } int -xc_core_arch_map_p2m(xc_interface *xch, unsigned int guest_width, xc_dominfo_t *info, - shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, - unsigned long *pfnp) +xc_core_arch_map_p2m(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, + shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m) { - struct domain_info_context _dinfo = { .guest_width = guest_width }; - struct domain_info_context *dinfo = &_dinfo; - return xc_core_arch_map_p2m_rw(xch, dinfo, info, - live_shinfo, live_p2m, pfnp, 0); + return xc_core_arch_map_p2m_rw(xch, dinfo, info, live_shinfo, live_p2m, 0); } int -xc_core_arch_map_p2m_writable(xc_interface *xch, unsigned int guest_width, xc_dominfo_t *info, - shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m, - unsigned long *pfnp) +xc_core_arch_map_p2m_writable(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, + shared_info_any_t *live_shinfo, xen_pfn_t **live_p2m) { - struct domain_info_context _dinfo = { .guest_width = guest_width }; - struct domain_info_context *dinfo = &_dinfo; - return xc_core_arch_map_p2m_rw(xch, dinfo, info, - live_shinfo, live_p2m, pfnp, 1); + return xc_core_arch_map_p2m_rw(xch, dinfo, info, live_shinfo, live_p2m, 1); } int diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index f0b5f83ac8..8ebc0b59da 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -79,6 +79,7 @@ struct iovec { struct domain_info_context { unsigned int guest_width; + unsigned int p2m_frames; unsigned long p2m_size; }; diff --git a/tools/libs/guest/xg_domain.c b/tools/libs/guest/xg_domain.c index 5019c84e0e..dd7db2cbd8 100644 --- a/tools/libs/guest/xg_domain.c +++ b/tools/libs/guest/xg_domain.c @@ -24,13 +24,9 @@ int xc_unmap_domain_meminfo(xc_interface *xch, struct xc_domain_meminfo *minfo) { - struct domain_info_context _di = { .guest_width = minfo->guest_width, - .p2m_size = minfo->p2m_size}; - struct domain_info_context *dinfo = &_di; - free(minfo->pfn_type); if ( minfo->p2m_table ) - munmap(minfo->p2m_table, P2M_FL_ENTRIES * PAGE_SIZE); + munmap(minfo->p2m_table, minfo->p2m_frames * PAGE_SIZE); minfo->p2m_table = NULL; return 0; @@ -40,7 +36,6 @@ int xc_map_domain_meminfo(xc_interface *xch, uint32_t domid, struct xc_domain_meminfo *minfo) { struct domain_info_context _di; - struct domain_info_context *dinfo = &_di; xc_dominfo_t info; shared_info_any_t *live_shinfo; @@ -96,16 +91,16 @@ int xc_map_domain_meminfo(xc_interface *xch, uint32_t domid, return -1; } - if ( xc_core_arch_map_p2m_writable(xch, minfo->guest_width, &info, - live_shinfo, &minfo->p2m_table, - &minfo->p2m_size) ) + if ( xc_core_arch_map_p2m_writable(xch, &_di, &info, + live_shinfo, &minfo->p2m_table) ) { PERROR("Could not map the P2M table"); munmap(live_shinfo, PAGE_SIZE); return -1; } munmap(live_shinfo, PAGE_SIZE); - _di.p2m_size = minfo->p2m_size; + minfo->p2m_size = _di.p2m_size; + minfo->p2m_frames = _di.p2m_frames; /* Make space and prepare for getting the PFN types */ minfo->pfn_type = calloc(sizeof(*minfo->pfn_type), minfo->p2m_size); @@ -141,7 +136,7 @@ failed: } if ( minfo->p2m_table ) { - munmap(minfo->p2m_table, P2M_FL_ENTRIES * PAGE_SIZE); + munmap(minfo->p2m_table, minfo->p2m_frames * PAGE_SIZE); minfo->p2m_table = NULL; } -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 10:58:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 10:58:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100146.190647 (Exim 4.92) (envelope-from ) id 1lOIGq-00031Y-P5; Mon, 22 Mar 2021 10:58:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100146.190647; Mon, 22 Mar 2021 10:58:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIGq-00031Q-Jq; Mon, 22 Mar 2021 10:58:52 +0000 Received: by outflank-mailman (input) for mailman id 100146; Mon, 22 Mar 2021 10:58:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIGp-0002uK-Bq for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 10:58:51 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c14ea851-a261-40f7-a0ff-7d7be2bd9291; Mon, 22 Mar 2021 10:58:44 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7760BADD7; Mon, 22 Mar 2021 10:58:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c14ea851-a261-40f7-a0ff-7d7be2bd9291 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616410723; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QkccH15XtocbQaI1+xCepvWqUPsOA3/9wDy4REwshYU=; b=tpGKTi4dWouWzumA2xQIYE4sW+/5vQYXUy1ts4cA9jaJUrF9ZuPVk3EOg0072/5XnVJGHa 6RCixeeg6LBZHj8nhUrfJez5PITM/EWzFsIupbKL9BzYVI+MkTjA3nkTnwg6YdPBydJaZW NOjbq9wpXZq7ljqQt2Spd5pym4CrhyM= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH 3/6] tools/libs/ctrl: use common p2m mapping code in xc_domain_resume_any() Date: Mon, 22 Mar 2021 11:58:37 +0100 Message-Id: <20210322105840.11224-4-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210322105840.11224-1-jgross@suse.com> References: <20210322105840.11224-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of open coding the mapping of the p2m list use the already existing xc_core_arch_map_p2m() call, especially as the current code does not support guests with the linear p2m map. It should be noted that this code is needed for colo/remus only. Switching to xc_core_arch_map_p2m() drops the need to bail out for bitness of tool stack and guest differing. Signed-off-by: Juergen Gross --- This might be a backport candidate --- tools/libs/ctrl/xc_resume.c | 66 ++++++++++++------------------------- 1 file changed, 21 insertions(+), 45 deletions(-) diff --git a/tools/libs/ctrl/xc_resume.c b/tools/libs/ctrl/xc_resume.c index 94c6c9fb31..e3c8e83aa9 100644 --- a/tools/libs/ctrl/xc_resume.c +++ b/tools/libs/ctrl/xc_resume.c @@ -20,6 +20,7 @@ #include #include #include +#include "xc_core.h" static int modify_returncode(xc_interface *xch, uint32_t domid) { @@ -137,12 +138,10 @@ static int xc_domain_resume_any(xc_interface *xch, uint32_t domid) struct domain_info_context _dinfo = { .guest_width = 0, .p2m_size = 0 }; struct domain_info_context *dinfo = &_dinfo; - unsigned long mfn; + xen_pfn_t mfn, store_mfn, console_mfn; vcpu_guest_context_any_t ctxt; - start_info_t *start_info; - shared_info_t *shinfo = NULL; - xen_pfn_t *p2m_frame_list_list = NULL; - xen_pfn_t *p2m_frame_list = NULL; + start_info_any_t *start_info; + shared_info_any_t *shinfo = NULL; xen_pfn_t *p2m = NULL; #endif @@ -164,11 +163,6 @@ static int xc_domain_resume_any(xc_interface *xch, uint32_t domid) PERROR("Could not get domain width"); return rc; } - if ( dinfo->guest_width != sizeof(long) ) - { - ERROR("Cannot resume uncooperative cross-address-size guests"); - return rc; - } /* Map the shared info frame */ shinfo = xc_map_foreign_range(xch, domid, PAGE_SIZE, @@ -179,34 +173,8 @@ static int xc_domain_resume_any(xc_interface *xch, uint32_t domid) goto out; } - dinfo->p2m_size = shinfo->arch.max_pfn; - - p2m_frame_list_list = - xc_map_foreign_range(xch, domid, PAGE_SIZE, PROT_READ, - shinfo->arch.pfn_to_mfn_frame_list_list); - if ( p2m_frame_list_list == NULL ) - { - ERROR("Couldn't map p2m_frame_list_list"); - goto out; - } - - p2m_frame_list = xc_map_foreign_pages(xch, domid, PROT_READ, - p2m_frame_list_list, - P2M_FLL_ENTRIES); - if ( p2m_frame_list == NULL ) - { - ERROR("Couldn't map p2m_frame_list"); - goto out; - } - - /* Map all the frames of the pfn->mfn table. For migrate to succeed, - the guest must not change which frames are used for this purpose. - (its not clear why it would want to change them, and we'll be OK - from a safety POV anyhow. */ - p2m = xc_map_foreign_pages(xch, domid, PROT_READ, - p2m_frame_list, - P2M_FL_ENTRIES); - if ( p2m == NULL ) + /* Map the p2m list */ + if ( xc_core_arch_map_p2m(xch, dinfo, &info, shinfo, &p2m) ) { ERROR("Couldn't map p2m table"); goto out; @@ -228,8 +196,20 @@ static int xc_domain_resume_any(xc_interface *xch, uint32_t domid) goto out; } - start_info->store_mfn = p2m[start_info->store_mfn]; - start_info->console.domU.mfn = p2m[start_info->console.domU.mfn]; + store_mfn = GET_FIELD(start_info, store_mfn, dinfo->guest_width); + console_mfn = GET_FIELD(start_info, console.domU.mfn, dinfo->guest_width); + if ( dinfo->guest_width == 4 ) + { + store_mfn = ((uint32_t *)p2m)[store_mfn]; + console_mfn = ((uint32_t *)p2m)[console_mfn]; + } + else + { + store_mfn = ((uint64_t *)p2m)[store_mfn]; + console_mfn = ((uint64_t *)p2m)[console_mfn]; + } + SET_FIELD(start_info, store_mfn, store_mfn, dinfo->guest_width); + SET_FIELD(start_info, console.domU.mfn, console_mfn, dinfo->guest_width); munmap(start_info, PAGE_SIZE); #endif /* defined(__i386__) || defined(__x86_64__) */ @@ -250,11 +230,7 @@ static int xc_domain_resume_any(xc_interface *xch, uint32_t domid) out: #if defined(__i386__) || defined(__x86_64__) if (p2m) - munmap(p2m, P2M_FL_ENTRIES*PAGE_SIZE); - if (p2m_frame_list) - munmap(p2m_frame_list, P2M_FLL_ENTRIES*PAGE_SIZE); - if (p2m_frame_list_list) - munmap(p2m_frame_list_list, PAGE_SIZE); + munmap(p2m, dinfo->p2m_frames * PAGE_SIZE); if (shinfo) munmap(shinfo, PAGE_SIZE); #endif -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 10:58:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 10:58:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100148.190658 (Exim 4.92) (envelope-from ) id 1lOIGv-00036v-2s; Mon, 22 Mar 2021 10:58:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100148.190658; Mon, 22 Mar 2021 10:58:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIGu-00036m-VC; Mon, 22 Mar 2021 10:58:56 +0000 Received: by outflank-mailman (input) for mailman id 100148; Mon, 22 Mar 2021 10:58:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIGt-0002uF-1G for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 10:58:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cdc69337-cac4-4762-a14c-05bab90bddde; Mon, 22 Mar 2021 10:58:44 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9D1FFADE3; Mon, 22 Mar 2021 10:58:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cdc69337-cac4-4762-a14c-05bab90bddde X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616410723; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9lSZVDHBJO9o342eIYRKM8hbyMeKeAJ7KWKA4F6tztw=; b=NWw81ML6CFHaFTdFVaA4YHw2UU6n8n5UOHRDSN/YGg7DJV+8eU9nJVQd4m/sSyX0nI2v6R JBKVAWGjoDjyHcm979aoOJp0GSrgg9gS/otjcAAuegvjH+c5dS2EU31xXbP+GyCJ77ykkX 3rmRKRHxlwtEMlgU8Tw4f+3x+PJuWz8= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH 4/6] tools/libs: move xc_resume.c to libxenguest Date: Mon, 22 Mar 2021 11:58:38 +0100 Message-Id: <20210322105840.11224-5-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210322105840.11224-1-jgross@suse.com> References: <20210322105840.11224-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The guest suspend functionality is already part of libxenguest. Move the resume functionality from libxenctrl to libxenguest, too. Signed-off-by: Juergen Gross --- tools/include/xenctrl.h | 63 ------------------- tools/include/xenguest.h | 62 ++++++++++++++++++ tools/libs/ctrl/Makefile | 1 - tools/libs/guest/Makefile | 1 + .../{ctrl/xc_resume.c => guest/xg_resume.c} | 1 + 5 files changed, 64 insertions(+), 64 deletions(-) rename tools/libs/{ctrl/xc_resume.c => guest/xg_resume.c} (99%) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 318920166c..8a6bede5b0 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -576,69 +576,6 @@ int xc_domain_destroy(xc_interface *xch, uint32_t domid); -/** - * This function resumes a suspended domain. The domain should have - * been previously suspended. - * - * Note that there are 'xc_domain_suspend' as suspending a domain - * is quite the endeavour. - * - * For the purpose of this explanation there are three guests: - * PV (using hypercalls for privilgied operations), HVM - * (fully hardware virtualized guests using emulated devices for everything), - * and PVHVM (PV aware with hardware virtualisation). - * - * HVM guest are the simplest - they suspend via S3 / S4 and resume from - * S3 / S4. Upon resume they have to re-negotiate with the emulated devices. - * - * PV and PVHVM communicate via hypercalls for suspend (and resume). - * For suspend the toolstack initiates the process by writing an value - * in XenBus "control/shutdown" with the string "suspend". - * - * The PV guest stashes anything it deems neccessary in 'struct - * start_info' in case of failure (PVHVM may ignore this) and calls - * the SCHEDOP_shutdown::SHUTDOWN_suspend hypercall (for PV as - * argument it passes the MFN to 'struct start_info'). - * - * And then the guest is suspended. - * - * The checkpointing or notifying a guest that the suspend failed or - * cancelled (in case of checkpoint) is by having the - * SCHEDOP_shutdown::SHUTDOWN_suspend hypercall return a non-zero - * value. - * - * The PV and PVHVM resume path are similar. For PV it would be - * similar to bootup - figure out where the 'struct start_info' is (or - * if the suspend was cancelled aka checkpointed - reuse the saved - * values). - * - * From here on they differ depending whether the guest is PV or PVHVM - * in specifics but follow overall the same path: - * - PV: Bringing up the vCPUS, - * - PVHVM: Setup vector callback, - * - Bring up vCPU runstates, - * - Remap the grant tables if checkpointing or setup from scratch, - * - * - * If the resume was not checkpointing (or if suspend was succesful) we would - * setup the PV timers and the different PV events. Lastly the PV drivers - * re-negotiate with the backend. - * - * This function would return before the guest started resuming. That is - * the guest would be in non-running state and its vCPU context would be - * in the the SCHEDOP_shutdown::SHUTDOWN_suspend hypercall return path - * (for PV and PVHVM). For HVM it would be in would be in QEMU emulated - * BIOS handling S3 suspend. - * - * @parm xch a handle to an open hypervisor interface - * @parm domid the domain id to resume - * @parm fast use cooperative resume (guest must support this) - * return 0 on success, -1 on failure - */ -int xc_domain_resume(xc_interface *xch, - uint32_t domid, - int fast); - /** * This function will shutdown a domain. This is intended for use in * fully-virtualized domains where this operation is analogous to the diff --git a/tools/include/xenguest.h b/tools/include/xenguest.h index 781d40c119..44300a8658 100644 --- a/tools/include/xenguest.h +++ b/tools/include/xenguest.h @@ -689,6 +689,68 @@ int xc_query_page_offline_status(xc_interface *xch, unsigned long start, int xc_exchange_page(xc_interface *xch, uint32_t domid, xen_pfn_t mfn); +/** + * This function resumes a suspended domain. The domain should have + * been previously suspended. + * + * Note that there are 'xc_domain_suspend' as suspending a domain + * is quite the endeavour. + * + * For the purpose of this explanation there are three guests: + * PV (using hypercalls for privilgied operations), HVM + * (fully hardware virtualized guests using emulated devices for everything), + * and PVHVM (PV aware with hardware virtualisation). + * + * HVM guest are the simplest - they suspend via S3 / S4 and resume from + * S3 / S4. Upon resume they have to re-negotiate with the emulated devices. + * + * PV and PVHVM communicate via hypercalls for suspend (and resume). + * For suspend the toolstack initiates the process by writing an value + * in XenBus "control/shutdown" with the string "suspend". + * + * The PV guest stashes anything it deems neccessary in 'struct + * start_info' in case of failure (PVHVM may ignore this) and calls + * the SCHEDOP_shutdown::SHUTDOWN_suspend hypercall (for PV as + * argument it passes the MFN to 'struct start_info'). + * + * And then the guest is suspended. + * + * The checkpointing or notifying a guest that the suspend failed or + * cancelled (in case of checkpoint) is by having the + * SCHEDOP_shutdown::SHUTDOWN_suspend hypercall return a non-zero + * value. + * + * The PV and PVHVM resume path are similar. For PV it would be + * similar to bootup - figure out where the 'struct start_info' is (or + * if the suspend was cancelled aka checkpointed - reuse the saved + * values). + * + * From here on they differ depending whether the guest is PV or PVHVM + * in specifics but follow overall the same path: + * - PV: Bringing up the vCPUS, + * - PVHVM: Setup vector callback, + * - Bring up vCPU runstates, + * - Remap the grant tables if checkpointing or setup from scratch, + * + * + * If the resume was not checkpointing (or if suspend was succesful) we would + * setup the PV timers and the different PV events. Lastly the PV drivers + * re-negotiate with the backend. + * + * This function would return before the guest started resuming. That is + * the guest would be in non-running state and its vCPU context would be + * in the the SCHEDOP_shutdown::SHUTDOWN_suspend hypercall return path + * (for PV and PVHVM). For HVM it would be in would be in QEMU emulated + * BIOS handling S3 suspend. + * + * @parm xch a handle to an open hypervisor interface + * @parm domid the domain id to resume + * @parm fast use cooperative resume (guest must support this) + * return 0 on success, -1 on failure + */ +int xc_domain_resume(xc_interface *xch, + uint32_t domid, + int fast); /** * Memory related information, such as PFN types, the P2M table, diff --git a/tools/libs/ctrl/Makefile b/tools/libs/ctrl/Makefile index ce9ecae710..fbeb3a3537 100644 --- a/tools/libs/ctrl/Makefile +++ b/tools/libs/ctrl/Makefile @@ -20,7 +20,6 @@ SRCS-y += xc_rt.c SRCS-y += xc_tbuf.c SRCS-y += xc_pm.c SRCS-y += xc_cpu_hotplug.c -SRCS-y += xc_resume.c SRCS-y += xc_vm_event.c SRCS-y += xc_vmtrace.c SRCS-y += xc_monitor.c diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile index 604e1695d6..8309bbcd20 100644 --- a/tools/libs/guest/Makefile +++ b/tools/libs/guest/Makefile @@ -9,6 +9,7 @@ endif SRCS-y += xg_private.c SRCS-y += xg_domain.c SRCS-y += xg_suspend.c +SRCS-y += xg_resume.c ifeq ($(CONFIG_MIGRATE),y) SRCS-y += xg_sr_common.c SRCS-$(CONFIG_X86) += xg_sr_common_x86.c diff --git a/tools/libs/ctrl/xc_resume.c b/tools/libs/guest/xg_resume.c similarity index 99% rename from tools/libs/ctrl/xc_resume.c rename to tools/libs/guest/xg_resume.c index e3c8e83aa9..3bdefb2eef 100644 --- a/tools/libs/ctrl/xc_resume.c +++ b/tools/libs/guest/xg_resume.c @@ -14,6 +14,7 @@ */ #include "xc_private.h" +#include "xenguest.h" #if defined(__i386__) || defined(__x86_64__) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 10:58:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 10:58:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100149.190664 (Exim 4.92) (envelope-from ) id 1lOIGv-000380-IH; Mon, 22 Mar 2021 10:58:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100149.190664; Mon, 22 Mar 2021 10:58:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIGv-00037i-Ba; Mon, 22 Mar 2021 10:58:57 +0000 Received: by outflank-mailman (input) for mailman id 100149; Mon, 22 Mar 2021 10:58:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIGu-0002uK-Bn for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 10:58:56 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0147daa2-e41c-4113-8fc6-56ac6bb6244c; Mon, 22 Mar 2021 10:58:45 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C4767ADFC; Mon, 22 Mar 2021 10:58:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0147daa2-e41c-4113-8fc6-56ac6bb6244c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616410723; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KSoo0QZ4m0mzUVtd8hHAUln3Z9oHo6ai82Gx5/Y5nMs=; b=W4q0BzCMO1m/qW3by3td5ed9xiJuKwGpXPkkHQK1bt8zJ/UOd6Fg2Ydalm+EBd/u6m81Ah hIXdwBKE/P3N0qj0sIVYVTKpB71AzRvHe+pLR+Ixl+sOi5O6+YkpQ9VvtlE9CFNToFP2uJ gDSi55hz54qtfvxxJwkHcs9ZBUksQYA= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH 5/6] tools/libs: move xc_core* from libxenctrl to libxenguest Date: Mon, 22 Mar 2021 11:58:39 +0100 Message-Id: <20210322105840.11224-6-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210322105840.11224-1-jgross@suse.com> References: <20210322105840.11224-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The functionality in xc_core* should be part of libxenguest instead of libxenctrl. Users are already either in libxenguest, or in xl. There is one single exception: xc_core_arch_auto_translated_physmap() is being used by xc_domain_memory_mapping(), which is used by qemu. So leave the xc_core_arch_auto_translated_physmap() functionality in libxenctrl. This will make it easier to merge common functionality of xc_core* and xg_sr_save*. Signed-off-by: Juergen Gross --- tools/libs/ctrl/Makefile | 3 --- tools/libs/ctrl/xc_domain.c | 2 -- tools/libs/ctrl/xc_private.h | 12 ++++++++++++ tools/libs/guest/Makefile | 3 +++ tools/libs/{ctrl/xc_core.c => guest/xg_core.c} | 2 +- tools/libs/{ctrl/xc_core.h => guest/xg_core.h} | 5 ++--- .../libs/{ctrl/xc_core_arm.c => guest/xg_core_arm.c} | 8 +------- .../libs/{ctrl/xc_core_arm.h => guest/xg_core_arm.h} | 0 .../libs/{ctrl/xc_core_x86.c => guest/xg_core_x86.c} | 8 +------- .../libs/{ctrl/xc_core_x86.h => guest/xg_core_x86.h} | 0 tools/libs/guest/xg_dom_boot.c | 2 +- tools/libs/guest/xg_domain.c | 2 +- tools/libs/guest/xg_offline_page.c | 2 +- tools/libs/guest/xg_resume.c | 2 +- 14 files changed, 24 insertions(+), 27 deletions(-) rename tools/libs/{ctrl/xc_core.c => guest/xg_core.c} (99%) rename tools/libs/{ctrl/xc_core.h => guest/xg_core.h} (97%) rename tools/libs/{ctrl/xc_core_arm.c => guest/xg_core_arm.c} (96%) rename tools/libs/{ctrl/xc_core_arm.h => guest/xg_core_arm.h} (100%) rename tools/libs/{ctrl/xc_core_x86.c => guest/xg_core_x86.c} (99%) rename tools/libs/{ctrl/xc_core_x86.h => guest/xg_core_x86.h} (100%) diff --git a/tools/libs/ctrl/Makefile b/tools/libs/ctrl/Makefile index fbeb3a3537..519246b0d6 100644 --- a/tools/libs/ctrl/Makefile +++ b/tools/libs/ctrl/Makefile @@ -2,9 +2,6 @@ XEN_ROOT = $(CURDIR)/../../.. include $(XEN_ROOT)/tools/Rules.mk SRCS-y += xc_altp2m.c -SRCS-y += xc_core.c -SRCS-$(CONFIG_X86) += xc_core_x86.c -SRCS-$(CONFIG_ARM) += xc_core_arm.c SRCS-y += xc_cpupool.c SRCS-y += xc_domain.c SRCS-y += xc_evtchn.c diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c index e7cea4a17d..7d118848f1 100644 --- a/tools/libs/ctrl/xc_domain.c +++ b/tools/libs/ctrl/xc_domain.c @@ -19,8 +19,6 @@ * Copyright (c) 2003, K A Fraser. */ -#include "xc_private.h" -#include "xc_core.h" #include "xc_private.h" #include #include diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index 8ebc0b59da..dff0f0289b 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -467,6 +467,18 @@ void *xc_vm_event_enable(xc_interface *xch, uint32_t domain_id, int param, int do_dm_op(xc_interface *xch, uint32_t domid, unsigned int nr_bufs, ...); +#if defined (__i386__) || defined (__x86_64__) +static inline int xc_core_arch_auto_translated_physmap(const xc_dominfo_t *info) +{ + return info->hvm; +} +#elif defined (__arm__) || defined(__aarch64__) +static inline int xc_core_arch_auto_translated_physmap(const xc_dominfo_t *info) +{ + return 1; +} +#endif + #endif /* __XC_PRIVATE_H__ */ /* diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile index 8309bbcd20..85a6f45592 100644 --- a/tools/libs/guest/Makefile +++ b/tools/libs/guest/Makefile @@ -24,6 +24,9 @@ SRCS-y += xg_offline_page.c else SRCS-y += xg_nomigrate.c endif +SRCS-y += xg_core.c +SRCS-$(CONFIG_X86) += xg_core_x86.c +SRCS-$(CONFIG_ARM) += xg_core_arm.c CFLAGS += -I$(XEN_libxenctrl) diff --git a/tools/libs/ctrl/xc_core.c b/tools/libs/guest/xg_core.c similarity index 99% rename from tools/libs/ctrl/xc_core.c rename to tools/libs/guest/xg_core.c index 9576bec5a3..c52f1161c1 100644 --- a/tools/libs/ctrl/xc_core.c +++ b/tools/libs/guest/xg_core.c @@ -61,7 +61,7 @@ */ #include "xc_private.h" -#include "xc_core.h" +#include "xg_core.h" #include #include diff --git a/tools/libs/ctrl/xc_core.h b/tools/libs/guest/xg_core.h similarity index 97% rename from tools/libs/ctrl/xc_core.h rename to tools/libs/guest/xg_core.h index 8ea1f93a10..f07584aaa6 100644 --- a/tools/libs/ctrl/xc_core.h +++ b/tools/libs/guest/xg_core.h @@ -131,7 +131,6 @@ struct xc_core_memory_map { uint64_t size; }; typedef struct xc_core_memory_map xc_core_memory_map_t; -int xc_core_arch_auto_translated_physmap(const xc_dominfo_t *info); struct xc_core_arch_context; int xc_core_arch_memory_map_get(xc_interface *xch, struct xc_core_arch_context *arch_ctxt, @@ -152,9 +151,9 @@ int xc_core_arch_get_scratch_gpfn(xc_interface *xch, uint32_t domid, #if defined (__i386__) || defined (__x86_64__) -# include "xc_core_x86.h" +# include "xg_core_x86.h" #elif defined (__arm__) || defined(__aarch64__) -# include "xc_core_arm.h" +# include "xg_core_arm.h" #else # error "unsupported architecture" #endif diff --git a/tools/libs/ctrl/xc_core_arm.c b/tools/libs/guest/xg_core_arm.c similarity index 96% rename from tools/libs/ctrl/xc_core_arm.c rename to tools/libs/guest/xg_core_arm.c index 93765a565f..aaabd07558 100644 --- a/tools/libs/ctrl/xc_core_arm.c +++ b/tools/libs/guest/xg_core_arm.c @@ -17,7 +17,7 @@ */ #include "xc_private.h" -#include "xc_core.h" +#include "xg_core.h" #include @@ -31,12 +31,6 @@ xc_core_arch_gpfn_may_present(struct xc_core_arch_context *arch_ctxt, return 0; } -int -xc_core_arch_auto_translated_physmap(const xc_dominfo_t *info) -{ - return 1; -} - int xc_core_arch_memory_map_get(xc_interface *xch, struct xc_core_arch_context *unused, xc_dominfo_t *info, shared_info_any_t *live_shinfo, diff --git a/tools/libs/ctrl/xc_core_arm.h b/tools/libs/guest/xg_core_arm.h similarity index 100% rename from tools/libs/ctrl/xc_core_arm.h rename to tools/libs/guest/xg_core_arm.h diff --git a/tools/libs/ctrl/xc_core_x86.c b/tools/libs/guest/xg_core_x86.c similarity index 99% rename from tools/libs/ctrl/xc_core_x86.c rename to tools/libs/guest/xg_core_x86.c index c8f71d4b75..09f5d696ce 100644 --- a/tools/libs/ctrl/xc_core_x86.c +++ b/tools/libs/guest/xg_core_x86.c @@ -19,7 +19,7 @@ #include #include "xc_private.h" -#include "xc_core.h" +#include "xg_core.h" #include int @@ -33,12 +33,6 @@ xc_core_arch_gpfn_may_present(struct xc_core_arch_context *arch_ctxt, return 1; } -int -xc_core_arch_auto_translated_physmap(const xc_dominfo_t *info) -{ - return info->hvm; -} - int xc_core_arch_memory_map_get(xc_interface *xch, struct xc_core_arch_context *unused, xc_dominfo_t *info, shared_info_any_t *live_shinfo, diff --git a/tools/libs/ctrl/xc_core_x86.h b/tools/libs/guest/xg_core_x86.h similarity index 100% rename from tools/libs/ctrl/xc_core_x86.h rename to tools/libs/guest/xg_core_x86.h diff --git a/tools/libs/guest/xg_dom_boot.c b/tools/libs/guest/xg_dom_boot.c index 2a002e7349..dac96b17a5 100644 --- a/tools/libs/guest/xg_dom_boot.c +++ b/tools/libs/guest/xg_dom_boot.c @@ -31,7 +31,7 @@ #include #include "xg_private.h" -#include "xc_core.h" +#include "xg_core.h" #include #include diff --git a/tools/libs/guest/xg_domain.c b/tools/libs/guest/xg_domain.c index dd7db2cbd8..155e337427 100644 --- a/tools/libs/guest/xg_domain.c +++ b/tools/libs/guest/xg_domain.c @@ -20,7 +20,7 @@ */ #include "xg_private.h" -#include "xc_core.h" +#include "xg_core.h" int xc_unmap_domain_meminfo(xc_interface *xch, struct xc_domain_meminfo *minfo) { diff --git a/tools/libs/guest/xg_offline_page.c b/tools/libs/guest/xg_offline_page.c index d4722f0e8c..cfe0e2d537 100644 --- a/tools/libs/guest/xg_offline_page.c +++ b/tools/libs/guest/xg_offline_page.c @@ -25,7 +25,7 @@ #include #include #include -#include +#include #include "xc_private.h" #include "xg_private.h" diff --git a/tools/libs/guest/xg_resume.c b/tools/libs/guest/xg_resume.c index 3bdefb2eef..d201c1488d 100644 --- a/tools/libs/guest/xg_resume.c +++ b/tools/libs/guest/xg_resume.c @@ -21,7 +21,7 @@ #include #include #include -#include "xc_core.h" +#include "xg_core.h" static int modify_returncode(xc_interface *xch, uint32_t domid) { -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 10:59:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 10:59:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100150.190683 (Exim 4.92) (envelope-from ) id 1lOIH0-0003GA-0G; Mon, 22 Mar 2021 10:59:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100150.190683; Mon, 22 Mar 2021 10:59:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIGz-0003Fv-Rh; Mon, 22 Mar 2021 10:59:01 +0000 Received: by outflank-mailman (input) for mailman id 100150; Mon, 22 Mar 2021 10:59:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOIGy-0002uF-1S for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 10:59:00 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 947bfb90-8967-472a-9b6a-911f6106b9da; Mon, 22 Mar 2021 10:58:45 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EBA06AE1B; Mon, 22 Mar 2021 10:58:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 947bfb90-8967-472a-9b6a-911f6106b9da X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616410724; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r/d1m/nwqJtLr2C9cFqF0W7SDbqgauwOmuYrIPpnLeM=; b=bcvOklLkydyG3egU54tomkEqfURs0yRAGppOBZOjvhucIw4mJLFWkTTInKdgsj4Yc7yBDq BZUVh3D8l33/QtL7M+yGEPKVjzmDA43hPexRRevMVdcWxppNe0OIbSZwFcMkf4WuCYLHaj dnvJH7wEnQ/xBHlT7p8prl17pTP8DvQ= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH 6/6] tools/libs/guest: make some definitions private to libxenguest Date: Mon, 22 Mar 2021 11:58:40 +0100 Message-Id: <20210322105840.11224-7-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210322105840.11224-1-jgross@suse.com> References: <20210322105840.11224-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are some definitions which are used in libxenguest only now. Move them from libxenctrl over to libxenguest. Remove an unused macro. Signed-off-by: Juergen Gross --- tools/libs/ctrl/xc_private.h | 32 -------------------------------- tools/libs/guest/xg_core.h | 2 +- tools/libs/guest/xg_core_x86.c | 16 +++++++++++++++- tools/libs/guest/xg_private.h | 16 +++++++++++++++- tools/libs/guest/xg_resume.c | 2 +- 5 files changed, 32 insertions(+), 36 deletions(-) diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index dff0f0289b..3e299b943f 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -65,38 +65,6 @@ struct iovec { #define ROUNDUP(_x,_w) (((unsigned long)(_x)+(1UL<<(_w))-1) & ~((1UL<<(_w))-1)) -#define GET_FIELD(_p, _f, _w) (((_w) == 8) ? ((_p)->x64._f) : ((_p)->x32._f)) - -#define SET_FIELD(_p, _f, _v, _w) do { \ - if ((_w) == 8) \ - (_p)->x64._f = (_v); \ - else \ - (_p)->x32._f = (_v); \ -} while (0) - -/* XXX SMH: following skanky macros rely on variable p2m_size being set */ -/* XXX TJD: also, "guest_width" should be the guest's sizeof(unsigned long) */ - -struct domain_info_context { - unsigned int guest_width; - unsigned int p2m_frames; - unsigned long p2m_size; -}; - -/* Number of xen_pfn_t in a page */ -#define FPP (PAGE_SIZE/(dinfo->guest_width)) - -/* Number of entries in the pfn_to_mfn_frame_list_list */ -#define P2M_FLL_ENTRIES (((dinfo->p2m_size)+(FPP*FPP)-1)/(FPP*FPP)) - -/* Number of entries in the pfn_to_mfn_frame_list */ -#define P2M_FL_ENTRIES (((dinfo->p2m_size)+FPP-1)/FPP) - -/* Size in bytes of the pfn_to_mfn_frame_list */ -#define P2M_GUEST_FL_SIZE ((P2M_FL_ENTRIES) * (dinfo->guest_width)) -#define P2M_TOOLS_FL_SIZE ((P2M_FL_ENTRIES) * \ - max_t(size_t, sizeof(xen_pfn_t), dinfo->guest_width)) - #define DECLARE_DOMCTL struct xen_domctl domctl #define DECLARE_SYSCTL struct xen_sysctl sysctl #define DECLARE_PHYSDEV_OP struct physdev_op physdev_op diff --git a/tools/libs/guest/xg_core.h b/tools/libs/guest/xg_core.h index f07584aaa6..aaca9e0a8b 100644 --- a/tools/libs/guest/xg_core.h +++ b/tools/libs/guest/xg_core.h @@ -21,7 +21,7 @@ #define XC_CORE_H #include "xen/version.h" -#include "xc_private.h" +#include "xg_private.h" #include "xen/libelf/elfstructs.h" /* section names */ diff --git a/tools/libs/guest/xg_core_x86.c b/tools/libs/guest/xg_core_x86.c index 09f5d696ce..61106b98b8 100644 --- a/tools/libs/guest/xg_core_x86.c +++ b/tools/libs/guest/xg_core_x86.c @@ -18,10 +18,24 @@ */ #include -#include "xc_private.h" +#include "xg_private.h" #include "xg_core.h" #include +/* Number of xen_pfn_t in a page */ +#define FPP (PAGE_SIZE/(dinfo->guest_width)) + +/* Number of entries in the pfn_to_mfn_frame_list_list */ +#define P2M_FLL_ENTRIES (((dinfo->p2m_size)+(FPP*FPP)-1)/(FPP*FPP)) + +/* Number of entries in the pfn_to_mfn_frame_list */ +#define P2M_FL_ENTRIES (((dinfo->p2m_size)+FPP-1)/FPP) + +/* Size in bytes of the pfn_to_mfn_frame_list */ +#define P2M_GUEST_FL_SIZE ((P2M_FL_ENTRIES) * (dinfo->guest_width)) +#define P2M_TOOLS_FL_SIZE ((P2M_FL_ENTRIES) * \ + max_t(size_t, sizeof(xen_pfn_t), dinfo->guest_width)) + int xc_core_arch_gpfn_may_present(struct xc_core_arch_context *arch_ctxt, unsigned long pfn) diff --git a/tools/libs/guest/xg_private.h b/tools/libs/guest/xg_private.h index 8f9b257a2f..ff57f8b832 100644 --- a/tools/libs/guest/xg_private.h +++ b/tools/libs/guest/xg_private.h @@ -42,6 +42,21 @@ #endif #endif +#define GET_FIELD(_p, _f, _w) (((_w) == 8) ? ((_p)->x64._f) : ((_p)->x32._f)) + +#define SET_FIELD(_p, _f, _v, _w) do { \ + if ((_w) == 8) \ + (_p)->x64._f = (_v); \ + else \ + (_p)->x32._f = (_v); \ +} while (0) + +struct domain_info_context { + unsigned int guest_width; + unsigned int p2m_frames; + unsigned long p2m_size; +}; + struct xc_dom_loader { char *name; /* Sadly the error returns from these functions are not consistent: */ @@ -139,7 +154,6 @@ static inline xen_pfn_t xc_pfn_to_mfn(xen_pfn_t pfn, xen_pfn_t *p2m, /* Masks for PTE<->PFN conversions */ #define MADDR_BITS_X86 ((dinfo->guest_width == 8) ? 52 : 44) #define MFN_MASK_X86 ((1ULL << (MADDR_BITS_X86 - PAGE_SHIFT_X86)) - 1) -#define MADDR_MASK_X86 (MFN_MASK_X86 << PAGE_SHIFT_X86) int pin_table(xc_interface *xch, unsigned int type, unsigned long mfn, uint32_t dom); diff --git a/tools/libs/guest/xg_resume.c b/tools/libs/guest/xg_resume.c index d201c1488d..77e2451a3c 100644 --- a/tools/libs/guest/xg_resume.c +++ b/tools/libs/guest/xg_resume.c @@ -13,7 +13,7 @@ * License along with this library; If not, see . */ -#include "xc_private.h" +#include "xg_private.h" #include "xenguest.h" #if defined(__i386__) || defined(__x86_64__) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 12:46:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 12:46:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100186.190725 (Exim 4.92) (envelope-from ) id 1lOJwn-0005AG-Cg; Mon, 22 Mar 2021 12:46:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100186.190725; Mon, 22 Mar 2021 12:46:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOJwn-0005A9-8F; Mon, 22 Mar 2021 12:46:17 +0000 Received: by outflank-mailman (input) for mailman id 100186; Mon, 22 Mar 2021 12:46:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOJwl-0005A4-OO for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 12:46:16 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ad929400-7d24-4d09-8626-0901d97b63b4; Mon, 22 Mar 2021 12:46:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad929400-7d24-4d09-8626-0901d97b63b4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616417174; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=+4/XYcFCnN5QqOjwreFnJCDJLz2vFwD5GScCbDeSmdo=; b=HtXpdoAwG/wtWkNqEXsdHPU1g1beKNNYmxMtyLMQ2O2OxNtdPVJfo2yT n1Q+dHL6w8Q0s+TV7KQM9AVJGjDAFnEXr2B+ag4e628qB6P3cCA5KFkYO akzwvGm3Cxsy7QlTFg7TVX/BfLJhmolAmUi4226Rhwi3ADEtliYIa/hda I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: k+zyy8smYtM1C4ydKbMA4lkCI7t6a54bcHSDt+2gWG5iwwJWj4GZ+C0CSH75vPtAyR4iRtQnXs 7JhSz+DkyDCnAfofEVt1t9TER+gv+BJ6ihqkzi8wAAQc25OUjNrB6ddz/9rgJHNAF2nOPX+u6a fWDAg+MDA1wXhZ+9uiYMCfpJqWKGJnwvO3qv1MMDR+QNT9MPO3gAD34HnXdma9H1544ZN+ifbA sr7Cc9c6KYNcEpIcwZCCAPDtil6XHC1IDlClQEeWchM3zymbUK3ih7abY3J0wMqOp2FvCQ9sUp tNE= X-SBRS: 5.2 X-MesageID: 40179052 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:xtC59qrZyOajfLmnessxWwQaV5v5L9V00zAX/kB9WHVpW+SFis Gjm+ka3xfoiDAXHEotg8yEJbPoex7h3LR+iLNwAZ6JWg76tGy0aLxz9IeK+UyFJwTS1M54kZ 1hfa93FcHqATFB5/rSzQGkH78br+Wv37uvgY7loUtFaSFPR+Ve4xxiCgCde3cGITVuIZYiDp KT6o5milObCBcqR/+2DHUEQOTPzuej/P7bSCULGgI97022hS6ogYSQLzGjwhwcXzlTqI1Sk1 TtrgqR3MSemsD+8DDw/Sv575NamNzuo+EzefCku4wuBRjHziqtbIRlcbWesD4yu/HH0idXrP D85y0OEu42x3TNfnykgRaF4Xie7B8er0XM5HXdoXz/rdf3TDg3YvAx+75xQ1/ixGcL+PRfuZ g7uF6xht5sIj7r2BnZ3ZzuUSpnk0KlyEBS6tI7vjhkfqY1LINKoZd3xjIyLL4wWBjUxaoAC+ dUAMTV9J9tACmnRkGchGVpzdC2N05DZyuucwwHssyR5TBcgGp0+Use3NAehXcN7vsGOuF529 g= X-IronPort-AV: E=Sophos;i="5.81,268,1610427600"; d="scan'208";a="40179052" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C1SD6Q65ioodaMk6EQVkQxX3T9c17yz5a888mDePSwiC9I06G+bYO/W07g58m1r/vFpZ8RDVNIoDi6A7wJH/fYSVp5R7OCbfxZJspLM1IJVfnBfufSk8V6sGkF+YA5FcJu4y3G4nDzyXi4LSWpYanaRAZupIHzFKyZyH2lWVEWpt0KPu5zKTrTLIRFiNm3FD3gyvSKq9TpUseGKXm9PVxGlVrJDUGbtrFe18AamwaCnUcdtAder9mPdiEX4dvls+xGVhDNd5avkWIFt0cCSJrhMOkAlq3uofmqc+1Uo5+UtlTca0byoZ6BGhSnBq3Ak35CZ0eMvtCTCCDcelQhMTLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UJDNkkH/vzI+iZBh+0yrj1IXH9B10obPpkIrSyfHwhQ=; b=DxN6x/JPY5sIQWedQzkW+BxpNc+UO2HjkAxcoWBKLgtZLkHjEA2H2DNyWFHGfzGeCixnPBEBrrV+K/nSNU8pSUIAlEHjO/PdPUGY3Bt5F8gKxMKYAF6kNQQhC+oXZTbGbRCWotM4APVlIUIz6q+cDCgwaJNoe/aQ3Up6bdLv7johV2/R5/T96L/1gRwpUhRFYUrH5F9CZqhUfJ+xLMJbMLuUBhkvgKfuISTrR51RU1evNnpdBI5VzpVjPYaDrrR/zAVplXXMMCdaS/wTRDB2x5ohtUtAb8CNfyOxhzyrW5SxphPHdBttFN2LokNTsD3yW8lpIUf6eC+0Pr3HS/kLTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UJDNkkH/vzI+iZBh+0yrj1IXH9B10obPpkIrSyfHwhQ=; b=ZtrbhZD/GR70poJLR135abqMMjoWHQXV4vKF6gKU3vaMLr0L6hOv8XW1V+w7bbyA6fpm4n4lgcwqMQ2zgerm8Cujv0a2+uhd3512X3UGwFxkiSO1fD83AXfcT1YiuO3ZkHjvs77/2YCrIUcxA/95t4J7YBoAd2HoFfYaCAtwwwM= Subject: Re: [PATCH 0/6] tools/libs: add missing support of linear p2m_list, cleanup To: Juergen Gross , CC: Ian Jackson , Wei Liu References: <20210322105840.11224-1-jgross@suse.com> From: Andrew Cooper Message-ID: <48642c84-9f19-d029-6823-814e389086d8@citrix.com> Date: Mon, 22 Mar 2021 12:46:04 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210322105840.11224-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0340.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::21) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 91d2fe96-036b-42f7-5b1f-08d8ed307787 X-MS-TrafficTypeDiagnostic: BN7PR03MB3874: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TRNVJyTugEtM0XLash0HiRzXnEBlM3JKxq2VBkN59ErLopMm0k+4f3JBf/Bufq8ZrriNj64TCxfcRmU7EpX6hi4/Sl9Tq2WCgd/Mop6LUVH9npj4XAFhsgI/Ce1J7xNL5RqI2vVI044E5PDNT6zfynU9azatMV1qeYjMv3kHlpkf4DeCWbaaHWRMY3csjWwp3ibyfte0bXYydjFK2gyTePB07b2kiVwgMyCHqbJAyMhyrLNNYRfgHkef/1jMST2FhyWatyL5GL6rbD9/818/ey2ANl2LAdwJo6upBrD+5XTguRxC0p1LvAJ7METLJA2Wvzn+UfYJWGrjGbOY8hOXKFJFRT3QiDBFkeTPGLVYYQUz7A4x//EzszsSjMIVm+JgIfjbP8K1JO60BnJlG7/CkopNhfGvc5qjeBuZFLmAwGnDGYapQ73Znol2RvgAg4s+GbPOKcLw2u638Z1zcs37ZQv9W153keyWBFG/cstEU9zT+m77PadVUcvGftu+B9fKrmE/xO+NiyOxF5WojK+z1udPIQSJhaXImDqHxf75kEKUz8ae0ZQveURzW1ahKnVT4QqihvdAxTnydGpRa9LV7eXDSZZECo14HUOEEEP2hhHi5uaz6siTjWwCfSFHLdvCAQdiw1ngls1GZbeT3y25ZCLUNdLsRqxBbEWa8qmUziyriSi6o+d0yvrOH4RU6qg+7qy1bahD/dwLdLvyDSO2RX0gWeYCjIcI3mROFmzl17QEtGTkDKHXwif9iCdtLHnS3FMDu0h2durWtDQ16s4I1n6k3N/Iq198DvcMUC+zNZY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(376002)(136003)(39860400002)(396003)(956004)(86362001)(66476007)(31686004)(8676002)(316002)(83380400001)(54906003)(8936002)(66946007)(66556008)(2616005)(16576012)(2906002)(31696002)(6666004)(4326008)(6486002)(53546011)(16526019)(36756003)(478600001)(5660300002)(966005)(186003)(26005)(38100700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VEJsbmpOZTU3S2M3YmJXK3J2eFF6VGZ6Uk1zaG90bHhNZWh1MkkyNEVwY3lK?= =?utf-8?B?Q3dMQ1JGNmNkQUpIVVNabmtGcHFrdVFnY1V0VnBGM3k3VDVwVFEzaFZhWDVB?= =?utf-8?B?aC91eHRuWGN6cGl5ZnRXdXJYZ0piWXVoVXM4aDgwMDBRcndGVXc1UndIajc2?= =?utf-8?B?K2V6Y0xBbUtXVC9FdHJMOUFKdDVzcTcwd0tENnM0QitwdTJxMklwd2ZGR3Jl?= =?utf-8?B?TW5abWdpeWx4NmswY0JIME5LeW5UdjVaeURNSU1CejhnQnc4aDBiRFU4RGs0?= =?utf-8?B?NmQraTMrdUJRbW1zNS90Y1R6NUdZVlByOW5VaTZXSUxLYTlhMVlnZ05CUFRt?= =?utf-8?B?eWhiYVVZYkFjb1gyU0ZKRlc0UUxKMTlwcnIrYS9CanFsdmZ5bkRlREZsc1FP?= =?utf-8?B?dEpRbXBEbFByelFHS2orLzlNckdRWGJLeHpoZjNndEtpb2hEa1puK2QxdmlK?= =?utf-8?B?LzlCWnlZNXlXSEhaWTlwc0UyVVZZdWtOalpPb2FsWWhpd0w0SXVKNkxhekli?= =?utf-8?B?RVFCYkY5ZTBPUG9Zckh6enlCaTk2dTR3MDlTT0R2eGJYZzU4NzQyYmZhUlBk?= =?utf-8?B?VjA3Vnp1NGFGQ2RaSmNOTUxEdmVqWE9LZHM2SldtakdPWVplbDM0M1E2WmpN?= =?utf-8?B?RVB5bmZsdDJsNXFZaGtMeFhwTjlsN05ZUExvRDJxMjJVY3pxMjZuMDlJWTlV?= =?utf-8?B?aTNQZjdXalViYk9FQWZVTENrYUJWOVRBZHlURXRXNG9SenVIazNPNVJrVXdS?= =?utf-8?B?TE1zSVFQODB4VUUxU3lrZXg1UXU3Tjh2MEFzQy9yKzE4SXlaV1RFZ1p6YjRX?= =?utf-8?B?d0xLdHgrelZsdERlWVFoMTQ1bHh2S0srcmJRZ21xOWVLcmRHWnlWcWdmUWcw?= =?utf-8?B?QXJ2d1B4ZmowRUFDVFUrVlgxR214aUxXdDRCaWVjNzJDR2pFa3dTTjBvSXFj?= =?utf-8?B?OHFPc0ZSS1ZuUzhGQk5xclJuL0Y2RkdsRVpFbHlIMm5LclNJeXVWRmQrRTRV?= =?utf-8?B?dXFiY1RRRnJCelg4YXI4c2U4N1Q1Wmo4UUpmbmdvWmo5N29pajBYd3NjcGRP?= =?utf-8?B?eGZ1b3BQZVEycm5OTEhUU1N4bkYrQXBSODltSERacE1vQ3BZWEd5ZGo4T0t1?= =?utf-8?B?bkgrOHhrb0hKRDl1WG5TbjNMR3huUm5SWUEzUEthTGV2VitsRGtUb1Y4MHJ0?= =?utf-8?B?bmZEaEU1WTc3Y0ZLT0NnOEJwcHY3ZDExQ0JETjZXSW9mbXFiOFR2QTVNSG1w?= =?utf-8?B?YW81R3JBMkVKNG1QOXFKanJwRHA4aFpoODhqYUVzQVh4bEQ4QTBXTkpuUGUw?= =?utf-8?B?UnRYc1ZRcDA5RUVkRjBLWEQzb1htTjFjdkFZTW5NQnozTDhob3NuMHRlL2pT?= =?utf-8?B?VWVoMWxKaE80WXNXQm0wbEZWeEoxRTcyM3VOR1BoUjZHVUxLOXZjUjlvdkQw?= =?utf-8?B?dTJ3Yk1HVnMyRUgwYmFkQk8wVW9YUjN1RnZja0s1M0doLzN4TktJT29oanNk?= =?utf-8?B?UmZvc3lwREhwYnNxejVZVHJ6UlQ3c1B3aEluT3FEN0FaTlpySTBCbXJVSmpr?= =?utf-8?B?OVo4Szl6SEdFek03RTcyTjloNjQvWDNIZmdHNXhic0VLRml0UkdWM2NiWkQr?= =?utf-8?B?eG10UjAzcnkvOXBoN0hCVGNyWFpzYVEwOGtMY1BvOFRqZHRrb3NFTmJmaEoz?= =?utf-8?B?d1NYdWNRMFdOd2J0Nno2WkVoak10NDhvaWN2U2p1ak8zVjBSdlprY2U5a0ZQ?= =?utf-8?Q?I7hYrENmupzlJ+p3McfqPkDNGhLdiGkLG+C5Ojg?= X-MS-Exchange-CrossTenant-Network-Message-Id: 91d2fe96-036b-42f7-5b1f-08d8ed307787 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2021 12:46:09.5905 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wbIlSyT8K9OfzCBBOq/f4AqPu73UNe1QLmia17ABGmk3SwrxkDggpIb02unfvg5W7CBmOEObY+zIHreNOl9u58TsO7uAWANxZe8IUno51+A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3874 X-OriginatorOrg: citrix.com On 22/03/2021 10:58, Juergen Gross wrote: > There are some corners left which don't support the not so very new > linear p2m list of pv guests, which has been introduced in Linux kernel > 3.19 and which is mandatory for non-legacy versions of Xen since kernel > 4.14. > > This series adds support for the linear p2m list where it is missing > (colo support and "xl dump-core"). > > In theory it should be possible to merge the p2m list mapping code > from migration handling and core dump handling, but this needs quite > some cleanup before this is possible. > > The first three patches of this series are fixing real problems, so > I've put them at the start of this series, especially in order to make > backports easier. > > The other three patches are only the first steps of cleanup. The main > work done here is to concentrate all p2m mapping in libxenguest instead > of having one implementation in each of libxenguest and libxenctrl. > > Merging the two implementations should be rather easy, but this will > require to touch many lines of code, as the migration handling variant > seems to be more mature, but it is using the migration stream specific > structures heavily. So I'd like to have some confirmation that my way > to clean this up is the right one. > > My idea would be to add the data needed for p2m mapping to struct > domain_info_context and replace the related fields in struct > xc_sr_context with a struct domain_info_context. Modifying the > interface of xc_core_arch_map_p2m() to take most current parameters > via struct domain_info_context would then enable migration coding to > use xc_core_arch_map_p2m() for mapping the p2m. xc_core_arch_map_p2m() > should look basically like the current migration p2m mapping code > afterwards. > > Any comments to that plan? > > Juergen Gross (6): > tools/libs/guest: fix max_pfn setting in map_p2m() > tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m > table > tools/libs/ctrl: use common p2m mapping code in xc_domain_resume_any() > tools/libs: move xc_resume.c to libxenguest > tools/libs: move xc_core* from libxenctrl to libxenguest > tools/libs/guest: make some definitions private to libxenguest https://gitlab.com/xen-project/patchew/xen/-/jobs/1116936958 xenctrl_stubs.c:342:11: error: implicit declaration of function 'xc_domain_resume' is invalid in C99 [-Werror,-Wimplicit-function-declaration]         result = xc_domain_resume(_H(xch), c_domid, 1);                  ^ 1 error generated. I suspect you need to shuffle the headers in use for the Ocaml stubs too. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 22 13:21:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 13:21:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100196.190755 (Exim 4.92) (envelope-from ) id 1lOKUn-0000RE-AT; Mon, 22 Mar 2021 13:21:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100196.190755; Mon, 22 Mar 2021 13:21:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOKUn-0000R7-7F; Mon, 22 Mar 2021 13:21:25 +0000 Received: by outflank-mailman (input) for mailman id 100196; Mon, 22 Mar 2021 13:21:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOKUm-0000Qz-16; Mon, 22 Mar 2021 13:21:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOKUl-0003zq-Pd; Mon, 22 Mar 2021 13:21:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOKUl-0001bL-HC; Mon, 22 Mar 2021 13:21:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOKUl-0006KK-Gi; Mon, 22 Mar 2021 13:21:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5+53DdXWjvMNJe3sk5mSTkKto2ERvIvzyavxTtDQpyI=; b=DR+1XNhcg68NIOIWAngiUTRSjm h4RtvjwXfoQVZnJUOvoxoTp7261HkkT3/s9MpaxyW0bHcYYPJjq2vwR5S/+VWMgRy6DVeYdqL9ap3 Y7rL01F/ZH0vAn4/Lj8R6hW4W6K6PoEESiL/UCw59kogfbFyvM7e1t/v5OAZMqwFPSMA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160161: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=812da4d39463a060738008a46cfc9f775e4bfcf6 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 22 Mar 2021 13:21:23 +0000 flight 160161 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160161/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 812da4d39463a060738008a46cfc9f775e4bfcf6 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 233 days Failing since 152366 2020-08-01 20:49:34 Z 232 days 401 attempts Testing same since 160161 2021-03-21 02:37:33 Z 1 days 1 attempts ------------------------------------------------------------ 5230 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1298775 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 22 13:33:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 13:33:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100208.190781 (Exim 4.92) (envelope-from ) id 1lOKg9-0001Wv-PW; Mon, 22 Mar 2021 13:33:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100208.190781; Mon, 22 Mar 2021 13:33:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOKg9-0001Wo-MO; Mon, 22 Mar 2021 13:33:09 +0000 Received: by outflank-mailman (input) for mailman id 100208; Mon, 22 Mar 2021 13:33:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOKg8-0001Wj-Gg for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 13:33:08 +0000 Received: from mail-qv1-xf32.google.com (unknown [2607:f8b0:4864:20::f32]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6fb2aa84-6827-43a6-b9e6-d2844e411a9b; Mon, 22 Mar 2021 13:33:07 +0000 (UTC) Received: by mail-qv1-xf32.google.com with SMTP id cx5so8571609qvb.10 for ; Mon, 22 Mar 2021 06:33:07 -0700 (PDT) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:1322:1f91:8356:c0dd]) by smtp.gmail.com with ESMTPSA id k4sm10969035qke.13.2021.03.22.06.33.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 06:33:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6fb2aa84-6827-43a6-b9e6-d2844e411a9b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FQPB8K9PrmdKAV92Jc/Bf3qOZoqSuvhFC01n7H41QLE=; b=o0OH2/UcTaXjiQQM1TkArTdytlCWeCuPXSzjY9KSueBTnhzR7ZDXYDric7SkI8moFI lPNbrUNdr/ZivENdhSs9P4drNETY895eocMsPqU++hqmVgNovDuepbT2dwCNZ+MrUxAm TaarQ4pyfTv0aRls1emvJGClsiwDS8red2IBV3O49c8VVPRi7v4CLHT06KaF7lNclpdh 4oi59tk3L70zsuN+0/QbpD0lTEqAEHcpZRKQWNXhMYttpHY98qPGeLnVqruHfh6ELLvY UQNHiCbU6ezxAzzk1rtAKhR1RzedCsiCCfycl/saDaqVgI3gz+TToSOo7UaaI2qNhDeX uJYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FQPB8K9PrmdKAV92Jc/Bf3qOZoqSuvhFC01n7H41QLE=; b=bIKrv3q+rMWd+202ZxDKFUuYAbYwLDFxK4EYHW1yA8leDUvrDqzCYJ4dTBRY0wgG03 F8us6fsYeDL13GCy+n01St8kI6AVW17gAki5fw5dPkpp7YdnXUHrd/pUl/2PjTfUon8S DAbdtYMc3gtR5z9oMwxIjTuPuor9UaliwzAS0Dq9+IPAD1eZfOhPMHvHpacPsTt91720 w/i8kIm9AB2KwClsjGXhxm8HMJUFIpxSW71yhoHj/V1ZDTs0on4HK5DeT617RA/5A1RE Fk5vxT+++DC9egrZBgNk+Mtb2AAXCfV/XKPYNAzUzsrc3+/11YA1zzf554nIbtKTUsnX C+9A== X-Gm-Message-State: AOAM530QLXVM5o3PwBNzzpzcGj/QfpyEHWZl3JsZE14LKqdJ+NwgBHJk jDqzkPkTfL6CgJ/zo2Ak+a7HCn+B9y8= X-Google-Smtp-Source: ABdhPJy6BKHEK5AUYST4TUCw1SxNYltZ6z4A5LPZ6VUsyAYE+Q9Lh347gQ1+vftNtMxpYesM5iqI8g== X-Received: by 2002:a0c:f9cc:: with SMTP id j12mr21059219qvo.15.1616419987147; Mon, 22 Mar 2021 06:33:07 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] xen: Create EFI_VENDOR directory Date: Mon, 22 Mar 2021 09:33:01 -0400 Message-Id: <20210322133301.11308-1-jandryuk@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit make install-xen fails when EFI_VENDOR is set (=fedora) with: install: cannot create regular file '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No such file or directory Create the EFI_VENDOR directory so xen.efi can be installed within. This removes the need for Fedora and Qubes xen.spec files to manually create the directory in advance. Signed-off-by: Jason Andryuk --- xen/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/Makefile b/xen/Makefile index 0b97e459e2..f372b44de3 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -289,6 +289,7 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX) ln -sf $(T)-$(XEN_FULLVERSION).efi $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).efi; \ ln -sf $(T)-$(XEN_FULLVERSION).efi $(D)$(EFI_DIR)/$(T).efi; \ if [ -n '$(EFI_MOUNTPOINT)' -a -n '$(EFI_VENDOR)' ]; then \ + $(INSTALL_DIR) $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR); \ $(INSTALL_DATA) $(TARGET).efi $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi; \ elif [ "$(D)" = "$(patsubst $(shell cd $(XEN_ROOT) && pwd)/%,%,$(D))" ]; then \ echo 'EFI installation only partially done (EFI_VENDOR not set)' >&2; \ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 13:39:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 13:39:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100211.190794 (Exim 4.92) (envelope-from ) id 1lOKlw-0001nC-GM; Mon, 22 Mar 2021 13:39:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100211.190794; Mon, 22 Mar 2021 13:39:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOKlw-0001n5-CX; Mon, 22 Mar 2021 13:39:08 +0000 Received: by outflank-mailman (input) for mailman id 100211; Mon, 22 Mar 2021 13:39:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOKlu-0001n0-Op for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 13:39:06 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2ae121b1-f4bc-4295-9144-dbffec54d022; Mon, 22 Mar 2021 13:39:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ae121b1-f4bc-4295-9144-dbffec54d022 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616420345; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=s6t2bp70Zm8/cQavqkiKctT3lrKLuZWZ+RA0W16eFQM=; b=FhRx1JcM1vnYb4Fl16GW7258T9KCAPHTD578/ngtkjCNHj/ASFUYK5sA xjD7ShPKGOh1glXhrZB6LaL1f5ad+GrefGzXywPlXTRBmmr0pjvVKVkqu ivm4f4KbUbBI+8HmKYWNLp7iBGwKKj095NpWs7Z5T5fKzyshVDLvqRzWm I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: MKLP+c4jYlDH+IWjF33KjXNWbb3utZgNFfaTl2gJX+y1x8qE/Yjq62tiDhFGVPr/yG1UFehg/j KsFQ66Ha6AfWiajzFBFITuliOMJr4SCutXYOnnuUHR5INzd6jy8ksQjWwnyfpMwFcNmwImweEy ay3I+BRqw/1hDLvUinoltzXp4tgUsvR6AgKhL6LVqIgHFyksIO4t21jKMEIXlejwMw8j4RM1Kc ziTTeDOpUdkfr1ggCxRW5kV0AfJUItgv4IvgJ/1EqcwfchplKYdumUEd8EPlKgVelt3CzHggqD 8EI= X-SBRS: 5.2 X-MesageID: 39704035 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:tM7AE67qyUcR9/bSfwPXwRqBI+orLtY04lQ7vn1ZYQBJc8Ceis CllOka0xixszoKRHQ8g7m7VZWoa3m0z/5IyKMWOqqvWxSjhXuwIOhZnO/f6hDDOwm7zO5S0q 98b7NzYeebMXFWhdv3iTPWL/8O29+CmZrHuc7771NACT5ncLth6QARMHf/LmRTSBNdDZQ0UL qwj/A3xAaIQngcYsSlCnRtZYGqy+Hjr576fQUAQycu9Qjmt1iVwYTnGBuV1Ap2aUIs/Z4e9w H+8jDR1+GYnNyQjjTd0GLS6Jo+oqqd9vJzQPaip+JQBjHligODbJlsVbuYrFkO0Z2SwWdvqv bgiVMNONly9mPwcwiO0GTQ8jil6hkCwTvDzkKVmnTqq8CRfkNFN+Nxwbh3XzGczmhIhqAa7I t7m1i3mrASMDb72AP63NTMXwECrDvOnVMS1dQ9olYabZETc9Zq3Ooi1XIQKrgsNgTg5rsqFe F/Zfusnsp+QBehY3fVsnIH+q3UYl0DWhOPQk01sseIyTRhnHdg00sCxMAE901wjK4Adw== X-IronPort-AV: E=Sophos;i="5.81,269,1610427600"; d="scan'208";a="39704035" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lc97mgy2q2yp5/fb8IP4lrsI3i6VMCxoB0QI64ukZPryU9plC4gmT5n5TSQ4ef+tQxqBf7j9trBV4/B4ArLv9jAM7i2/RMJgmLUVJI+SOh9dmEZ/MgqtAzR/iBDOIJ0TTbI1UrIoE119m7A7bPoB6Qv4oULOa11CJRCs4n2nCJnK1fffQ7gg24QZB6GTPSVq+Opq5HNp0KvPqLAzm6WSpZMKUS5P7/7i2BnKsdYu6bKyzhx9/bs6Q6BrmPxgzU37zVtgURyaIim32mKhVtqQ+ayan+iOYh382i+M8jxJ0KjSUC0vp3EkvwRLnmB2s7Q9Pn1HUC3WzidkRVIKvqJqVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s6t2bp70Zm8/cQavqkiKctT3lrKLuZWZ+RA0W16eFQM=; b=grgWK/a5JpYyAfS8pJmAoeAAhKUQzaTUfsU0w/xA/LGwRiAHoSHhczg9afPnd3DYg6nva3thp5mHZbtLlufAakG6ZPGvlgHKHqqS+fQDGpbX2PFu0zjcWAHT0KFeSCjuiUL4aA0OqSW9erESiJ/+FPV8PJURA1UxgUe4hRFloQjLlmXLsB6U+3wyQVjV2oYdta3rWMyMYqAvfOKK5zwvNh1f0YntOAC92y/EpyawtWoBrlDSHm5o62beCMJxs2V6BeC6b0rstFV83hUWHa6SQgIZjyLOkw/BL1lyFtML4AK51wzcr0SVwjULg1eCtfs0fUiv74qkIfmgC/v2edI3kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s6t2bp70Zm8/cQavqkiKctT3lrKLuZWZ+RA0W16eFQM=; b=BC+Ls6PcIeyaSuDBbkRZxVcGRrEuhP1MCHauR1AGe0fQokcQNats0I66nykSL1OprDJ/NE0MiVvjU5xzAJwxW+SwURX7JfC5TkivciLIYvmlFDRfdiQdahX9YeiRmouApDgL09/eqAa2bUDYO+LJj4SfsPIzlJJ0JO3+RfLQS44= Subject: Re: for-4.15 [PATCH] xen: Create EFI_VENDOR directory To: Jason Andryuk , CC: George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20210322133301.11308-1-jandryuk@gmail.com> From: Andrew Cooper Message-ID: <22ea1195-60c7-9f7c-4d19-cf3709106ed7@citrix.com> Date: Mon, 22 Mar 2021 13:38:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210322133301.11308-1-jandryuk@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LNXP265CA0077.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::17) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 56b8b340-f093-4356-345c-08d8ed37d53e X-MS-TrafficTypeDiagnostic: BN6PR03MB3124: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L1k+lE/YbQot3lJXErLJpOtl5wlzZVmRIaqLOQZkP/xOGWaO9gtRvrY1KNmJMj/r4J4o1JGwWOOAP+3RLHF5IEHhZT4EoyNUwVgujQq0eYGYyjYkexf9YeAXmpsnlhCtDtdcWM32C2mUywW0gg3OdmeS/DmnzkNPcLPZwKo22YXjLe2C5Y4NS7BuDBEJTt/g2G+INAWUFH3KR6qaTMxBQgPtRJJoNRtypOmNlYxSfnIzjfpy1FZHPTD5tUhaxF55YLmz+d25vPyjjVjKMFHtO+hmkvFVxL4CFiRmNNrpP9DoXyaXze+m0QY4FQh+oPwroVnoWfpMw98BxFe1S6+FRFBILRAtrQn9YVgPd7hIpnkxb8eJm0BMEKJN77/LiSv4XJT4n7grIDE7fH4tuK/hrmQP+RAdrY+NWxsNzaZh81p5F3guemhGDoJn8mFvgmZNlftOtNfoU2zT4EM96RoEYZZ/R7Xkm0E2N1r1L8PDZPptGxsd2ysLfM7oKGzgiYyoJjDAnK+44/WOOfbfjD8LA+lojzr2oSFt5UxlLyWJcK2BlEbMw0/0iz4RTeiwAnWi07MJXpvLL+zvxJ3QDbUFiheNGmR6l1+KUt4yEmmarkFDPJbqYZDfpo/RJ42ZeHREBklAuVgcTdxRNoanXNUuFlwsUhswOjjvC/ixIl/caGf7pytZ9AxdBWofm0UHgpMUKUOXsgL+GJimdWHAsq0N0Ue/3kmANzXVmrRzOL/hXD8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(39860400002)(366004)(136003)(396003)(38100700001)(66556008)(54906003)(8936002)(956004)(66476007)(6486002)(316002)(2616005)(6666004)(4326008)(16576012)(31696002)(31686004)(66946007)(86362001)(36756003)(186003)(478600001)(8676002)(4744005)(2906002)(26005)(16526019)(53546011)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YTEwSExqMW5ndkpUTU9BckxqVDMvY0FLNGNqZCtRcGV1RTU2ME5oZWlQa2t3?= =?utf-8?B?ZmNJdU11cTA1MVgyMHpRS2VTbGErOHhtUm5iMlBSM0pORzVxOVN3cTZPZ2Fh?= =?utf-8?B?akliYXVHc1NiejdSRkZlaEE3U1pPL2JnbFFqVEt2RVQzVHVyYUdNY0pJd2dw?= =?utf-8?B?aGhYYUxFNno2TDFMS2lISmI0VzBkMkNHQ3A1WXJSVnlZZXhHSHpuUnRVSVZL?= =?utf-8?B?MEJSYWszR1AyVjhqVlM2ZWFhS2VBYm11YWFOblRYZGtzdS9QUGJZcmdMcmpY?= =?utf-8?B?RWtxOEdmTy9vTDJlaXlIdlpGM2FkM2o0V2N4WGszZXVrMndlTUkvZ1c0VkVU?= =?utf-8?B?MWQ1M0dtNkZUQWw2TGtWeDJ6NkwxMlJiTG8ya2ZXNVRVL1MrUkxYWTdpWVY4?= =?utf-8?B?VGRJbHdOdC9Oem84Qlk0ZllpMWM0VElkb1FFKzJWbDVZYjFJUnMzaDZqbjZj?= =?utf-8?B?anJEQVlBQnZTemszamYzc1NhdHZUWEJmR0ZsQUI1MDVja1NpWmt5WG1OMFd5?= =?utf-8?B?TDhuWExOZTU3TnRQMTFlbTRVNkdMSnFzUzZGN2V2OTdPMFZHbUtLVUkxWnhO?= =?utf-8?B?ZEpXcHJWSDFQYlVKN0tzNTF2K2VGOGpCVXBrYmNYZ2pPaldZZW0vaXBRUFA4?= =?utf-8?B?aU5EODRrRFd6cDI4ZWpGN2tYRmQzTXlFeGtZSkxwMzNOSm1rMHI2OU1MWjNM?= =?utf-8?B?SCtwU3RZcXpUSDl1NXRkbzdiVkZUUm1JSHpnRi8rQ01SMVVnTDVIWmg5bDJ4?= =?utf-8?B?UFRoTzdSTkNyWEQwVnk1M1B0MDJvRXBhVmREV2RpYVR1anlIN2kyRG9xRTVa?= =?utf-8?B?QitYZGxtb0ZKUE4wMHVqLzdJbTYwRVJPcFNkOXRLNkNWcWhxUXhKZm5pQjdB?= =?utf-8?B?MHZ5VS9BdmROaUpHZkd3Q0ZlNHROdG9OZ2V4TU94dUVSM21LVHAydXJTSlBt?= =?utf-8?B?dkZyWDA2UmhSY2NGdHl1aVQxTnN5bEVNZlNNWVVMN0VOdjhYWndxeko2SENo?= =?utf-8?B?b0FsNEVrQVZpWFM4QmxvSFJIWVBuOUtWMDlKRTN4WS9RSTFNcjlDNld1M2hO?= =?utf-8?B?L1hUTTNUTE9ISXQxVXU0VkRNNTJjSlJBdTI0ajNndW9rL1BKSHlkcFJLVVRa?= =?utf-8?B?ZTZjNTJXcFVXYUN4aXQrVytFb0tsWDdlTTRhbUVrUkp5dGlub1VRS1VoQzBp?= =?utf-8?B?TVhzSm9UeHQva0RmMVpabmUwamRPUEZmK3dBNnFySVdjMVM3U3h0NHBCbjJ2?= =?utf-8?B?RUFtdldnN3EvamRhdHhUcVNRRUhNemRNck1lRHRQa1E0aGE0UG54RmVyeEIz?= =?utf-8?B?dUNZeEhWaHVxUDRwczRHek5WM0pGOUhLd0twQ0VCSXk3Y0o4emd5UEdma1hD?= =?utf-8?B?b29kNjFjb251eExyalkrRFhTcVl0OTFFZUY2dzkzd0VGSzFQZHRLU01Fd2Rz?= =?utf-8?B?SVJURnVEcWYzWVczdGdNaytSblNZWnhtZlZXVklSNTVCbEdXbllqVWpCZFZX?= =?utf-8?B?dlhGWTRLS1B2S0xidEVqajAyZWtIUGR0UHRjUmJDNHhSMml5WDY3SWMwS1p6?= =?utf-8?B?NHNKck1hZy9qQmFJdlJxNU9jaUpMVVRKZE1SaUtJMHdMbmRMRVV4VHc1RGk3?= =?utf-8?B?Z1FJZ3VEcVBja2ZPODNwWE5CLzdwV0ozWUdOaStUTFNGaFpqOE8yVEFRSmZD?= =?utf-8?B?MlNBa0FxWmRRVEpmMjYxaDBpellPNmZERndXY2lTTXVSeWF3UUdFbm9hazFQ?= =?utf-8?Q?4js2vyTg3qEMih6tdnehin6wzpS0S4M2nUt78TB?= X-MS-Exchange-CrossTenant-Network-Message-Id: 56b8b340-f093-4356-345c-08d8ed37d53e X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2021 13:38:53.0642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aN+4N/qDywruMLbehL359SCW+uzSOwYSX+aGgKOBYolmJ3FxrXZMUAEATcqLNuyI/fS2qdtEKLbgLuSNMYJFAzybvFtjwUYdl6AwBYm/+iQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3124 X-OriginatorOrg: citrix.com On 22/03/2021 13:33, Jason Andryuk wrote: > make install-xen fails when EFI_VENDOR is set (=fedora) with: > install: cannot create regular file '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No such file or directory > > Create the EFI_VENDOR directory so xen.efi can be installed within. > > This removes the need for Fedora and Qubes xen.spec files to manually > create the directory in advance. > > Signed-off-by: Jason Andryuk Acked-by: Andrew Cooper This wants backporting, and should be considered for 4.15 at this point. From xen-devel-bounces@lists.xenproject.org Mon Mar 22 14:02:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 14:02:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100220.190812 (Exim 4.92) (envelope-from ) id 1lOL86-0004X3-9I; Mon, 22 Mar 2021 14:02:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100220.190812; Mon, 22 Mar 2021 14:02:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOL86-0004Ww-5y; Mon, 22 Mar 2021 14:02:02 +0000 Received: by outflank-mailman (input) for mailman id 100220; Mon, 22 Mar 2021 14:02:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOL85-0004Wr-5M for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:02:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOL85-0004jm-03 for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:02:01 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOL84-00009y-T7 for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:02:00 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOL81-00005i-JT; Mon, 22 Mar 2021 14:01:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=F4qLdFWFXRUl3b12FAWiWDbU8JykQhAnHQLSabiETLA=; b=u7CNK8pm6/SdJ3j5bRwfAQZs/l VEnOgJOkRPjbEjjmdMFvtIsnuuCcsIvSS9LNT2vlAZCSUmdZulSETMo5o8GlbrmA8m/vX8gasmKHq qtE2zx2pGl45Yfu8HFg6ptescYuI2Tn3AlfbABrTnlda/KBnchwUehnh1tUBxLe98a2I=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24664.41813.347129.390771@mariner.uk.xensource.com> Date: Mon, 22 Mar 2021 14:01:57 +0000 To: Jason Andryuk Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH] xen: Create EFI_VENDOR directory In-Reply-To: <20210322133301.11308-1-jandryuk@gmail.com> References: <20210322133301.11308-1-jandryuk@gmail.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jason Andryuk writes ("[PATCH] xen: Create EFI_VENDOR directory"): > make install-xen fails when EFI_VENDOR is set (=fedora) with: > install: cannot create regular file '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No such file or directory > > Create the EFI_VENDOR directory so xen.efi can be installed within. > > This removes the need for Fedora and Qubes xen.spec files to manually > create the directory in advance. I reviewed this. Release-Acked-by: Ian Jackson Presuming someone else also reviews it. Andy, was your Acked-by a Reviewed-by ? Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 22 14:02:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 14:02:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100221.190824 (Exim 4.92) (envelope-from ) id 1lOL8T-0004bS-JF; Mon, 22 Mar 2021 14:02:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100221.190824; Mon, 22 Mar 2021 14:02:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOL8T-0004bL-FP; Mon, 22 Mar 2021 14:02:25 +0000 Received: by outflank-mailman (input) for mailman id 100221; Mon, 22 Mar 2021 14:02:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOL8S-0004b8-Jy; Mon, 22 Mar 2021 14:02:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOL8S-0004kQ-G8; Mon, 22 Mar 2021 14:02:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOL8S-0003JM-9A; Mon, 22 Mar 2021 14:02:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOL8S-00068h-8g; Mon, 22 Mar 2021 14:02:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1kPzPNj4SPLtNjrIm+MTRewJJYvkw5TGHSMsNRNYOc8=; b=1GISFkcR+wVJ6IsknENocWhyqg 45xxPkhtCcj/yjgIFzC+iymA58d02crcst0KMfvVDJg8iShZ+EzksbMQOk2OoLtIBiD89Nrzg/1OA 7tk5jKuPLTWNwD/MCv2cUioduQLdQotlgGZlLEdT+uTQJXB+x9oqK8DlGNUaiBttAg5Q=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160297: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ecdff2f5a03210119b71806c3f5571d6906dd85e X-Osstest-Versions-That: xen=dae3c3e8b257cd27d6b35a467a34bf79a6650340 From: osstest service owner Date: Mon, 22 Mar 2021 14:02:24 +0000 flight 160297 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160297/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen ecdff2f5a03210119b71806c3f5571d6906dd85e baseline version: xen dae3c3e8b257cd27d6b35a467a34bf79a6650340 Last test of basis 160126 2021-03-18 14:01:29 Z 4 days Testing same since 160297 2021-03-22 11:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git dae3c3e8b2..ecdff2f5a0 ecdff2f5a03210119b71806c3f5571d6906dd85e -> smoke From xen-devel-bounces@lists.xenproject.org Mon Mar 22 14:05:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 14:05:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100228.190839 (Exim 4.92) (envelope-from ) id 1lOLBR-0004mD-3U; Mon, 22 Mar 2021 14:05:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100228.190839; Mon, 22 Mar 2021 14:05:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLBQ-0004m5-WB; Mon, 22 Mar 2021 14:05:28 +0000 Received: by outflank-mailman (input) for mailman id 100228; Mon, 22 Mar 2021 14:05:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLBP-0004m0-BW for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:05:27 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f2aaa61d-07b6-48c8-ad8f-caccc87e5d90; Mon, 22 Mar 2021 14:05:26 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7718EAC1F; Mon, 22 Mar 2021 14:05:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2aaa61d-07b6-48c8-ad8f-caccc87e5d90 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616421925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IqsifDIsg4tyBUiOgM2OBSWPkeKV4obEH1uKv8DND2k=; b=Z+b+lY+ovWsTzd+fI/i8KEbnrhrZ2BwOIYAO3C2exO8K3CgpS4ArBxrJcQUZaihCOh+Sp8 OWaVkgDpERfd+W/l3uLGggZ2n4Hz7sZir3cvX50b6ogCWUsIoEtrgy5fVo9a4WXyBj8Kc4 NqmvI6bcXzeECyYrObeo1r6DVB8uk74= Subject: Re: [PATCH 0/6] tools/libs: add missing support of linear p2m_list, cleanup To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu References: <20210322105840.11224-1-jgross@suse.com> <48642c84-9f19-d029-6823-814e389086d8@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <109e3c6a-a167-d9c5-ef71-113faba78ce7@suse.com> Date: Mon, 22 Mar 2021 15:05:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <48642c84-9f19-d029-6823-814e389086d8@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qMglr0ZHBnTBgGyBBobtfnUhtlUth0ZDT" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qMglr0ZHBnTBgGyBBobtfnUhtlUth0ZDT Content-Type: multipart/mixed; boundary="q9aMeLn6J3nbyTzQiLX0leeYJwuPjcNX1"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu Message-ID: <109e3c6a-a167-d9c5-ef71-113faba78ce7@suse.com> Subject: Re: [PATCH 0/6] tools/libs: add missing support of linear p2m_list, cleanup References: <20210322105840.11224-1-jgross@suse.com> <48642c84-9f19-d029-6823-814e389086d8@citrix.com> In-Reply-To: <48642c84-9f19-d029-6823-814e389086d8@citrix.com> --q9aMeLn6J3nbyTzQiLX0leeYJwuPjcNX1 Content-Type: multipart/mixed; boundary="------------0751B21AB08A02EDA77F9E0D" Content-Language: en-US This is a multi-part message in MIME format. --------------0751B21AB08A02EDA77F9E0D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 22.03.21 13:46, Andrew Cooper wrote: > On 22/03/2021 10:58, Juergen Gross wrote: >> There are some corners left which don't support the not so very new >> linear p2m list of pv guests, which has been introduced in Linux kerne= l >> 3.19 and which is mandatory for non-legacy versions of Xen since kerne= l >> 4.14. >> >> This series adds support for the linear p2m list where it is missing >> (colo support and "xl dump-core"). >> >> In theory it should be possible to merge the p2m list mapping code >> from migration handling and core dump handling, but this needs quite >> some cleanup before this is possible. >> >> The first three patches of this series are fixing real problems, so >> I've put them at the start of this series, especially in order to make= >> backports easier. >> >> The other three patches are only the first steps of cleanup. The main >> work done here is to concentrate all p2m mapping in libxenguest instea= d >> of having one implementation in each of libxenguest and libxenctrl. >> >> Merging the two implementations should be rather easy, but this will >> require to touch many lines of code, as the migration handling variant= >> seems to be more mature, but it is using the migration stream specific= >> structures heavily. So I'd like to have some confirmation that my way >> to clean this up is the right one. >> >> My idea would be to add the data needed for p2m mapping to struct >> domain_info_context and replace the related fields in struct >> xc_sr_context with a struct domain_info_context. Modifying the >> interface of xc_core_arch_map_p2m() to take most current parameters >> via struct domain_info_context would then enable migration coding to >> use xc_core_arch_map_p2m() for mapping the p2m. xc_core_arch_map_p2m()= >> should look basically like the current migration p2m mapping code >> afterwards. >> >> Any comments to that plan? >> >> Juergen Gross (6): >> tools/libs/guest: fix max_pfn setting in map_p2m() >> tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m >> table >> tools/libs/ctrl: use common p2m mapping code in xc_domain_resume_an= y() >> tools/libs: move xc_resume.c to libxenguest >> tools/libs: move xc_core* from libxenctrl to libxenguest >> tools/libs/guest: make some definitions private to libxenguest >=20 > https://gitlab.com/xen-project/patchew/xen/-/jobs/1116936958 >=20 > xenctrl_stubs.c:342:11: error: implicit declaration of function > 'xc_domain_resume' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 result =3D xc_domain_resume= (_H(xch), c_domid, 1); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 ^ > 1 error generated. >=20 > I suspect you need to shuffle the headers in use for the Ocaml stubs to= o. Yes. Patch 4 needs to gain an "#include " in tools/ocaml/libs/xc/xenctrl_stubs.c Juergen --------------0751B21AB08A02EDA77F9E0D Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0751B21AB08A02EDA77F9E0D-- --q9aMeLn6J3nbyTzQiLX0leeYJwuPjcNX1-- --qMglr0ZHBnTBgGyBBobtfnUhtlUth0ZDT Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBYpCQFAwAAAAAACgkQsN6d1ii/Ey+p OQgAkQGbYISAi2CEHje8I+fR6OO02GEqQJKvFlS3zMaJk1NQAEcslOvc/zlRbtQ4K62GBBdTZyR6 eZKDL8nXrMjKnCsJ8G7hatakAfewKer1D6hRR6qP/S5IxYKEUPDZ41EoZGhNEBI/Xs8XtoITRfPB AZ+ulGoB8hmF6fJe9C/NZ9OmXdHenSuBBx8MAvHChqfE0xskjmgIm1HYf07737TZNTgXInZm25k4 cKaSePfHuxb5bfmD6ijFF5Y6XcZ2hNLSqlmEnEFB4YD0pDWVVgfYBhyAUKngxxV52wIZIOnP0JGQ ub0ulosgjP89gA2gMUv5a6b21HnCmWB3tXAazuGwzw== =3lX5 -----END PGP SIGNATURE----- --qMglr0ZHBnTBgGyBBobtfnUhtlUth0ZDT-- From xen-devel-bounces@lists.xenproject.org Mon Mar 22 14:18:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 14:18:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100237.190857 (Exim 4.92) (envelope-from ) id 1lOLNT-0005ws-F3; Mon, 22 Mar 2021 14:17:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100237.190857; Mon, 22 Mar 2021 14:17:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLNT-0005wl-Bl; Mon, 22 Mar 2021 14:17:55 +0000 Received: by outflank-mailman (input) for mailman id 100237; Mon, 22 Mar 2021 14:17:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLNR-0005wg-IF for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:17:53 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4f112ac4-98f6-4f94-ac7f-98ffaa9f65c6; Mon, 22 Mar 2021 14:17:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f112ac4-98f6-4f94-ac7f-98ffaa9f65c6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616422672; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=zbCA7xPzOeIvFMMUTDAmfGCrX4UtpDvlzVZISRSEDMo=; b=aZUFkAZ2qIzuFn5WuMWtR9ajrQM0QTE5u+hiRSy1yRNFymMeX5XhIfMc kJUmdC/O5aEE/vPU8vA+e3VmvoEWB/R1RnMau8JT5NyqeglPvDs1eUz6f 7ftmYs4gc17cDq8O4IxSx8t1xNrlF0j2agH6zhKWY4lDPfXzNZ5Z+XT32 o=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: gDU9YOZltnPkmbL5qfoHnDE2uuKo84dBf3CW8NukPI6cUvyn19Z92/c42QM1Kl+6PtDZGOjwrY AOKdU7b9fGFoh2tyEN9HIcBv2z7YcNRRFWilY1rciwOIdp0KBdp70jD2o4TPn16rX0gEdW19jp 68rK4YlO2x5hXnycSL79ZIYNygiHi2Gd5QvH+6LYgKhPVJzQy7JEdBUHdKMh1roMaMoaj6dcM7 9TZlEJ6ULNQ/TwA9wWJRKv6GNnR5JzJ4kbYwGfGRzx63Nm09AGCyllrFX4mYpAHTokgKwsU8NF l/c= X-SBRS: 5.1 X-MesageID: 41257215 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:zfm48q20pkwbpXJTZ3UPIwqjBFAkLtp033Aq2lEZdDV+WKWj+P yGtvIdyBPylXItQ3kmg9+NI+2tRnnb+J5z7+AqTNKfdSPhv3alK5wn0Jv6z1TbakrD38NUyK sISclDIfLqC1wSt6vHyS2ZN/pl/9Wd6qCvgo7lvhVQZCVncbtp4Qs8KivzKC1LbTJLD5Y4C5 aQj/Avz1HLRV0tYtmmHX5AZuDfprTw5fbbSCQbDB0q4hTmt12VwYP9eiL14j4uFxdGwbIv6g H+4m/E2pk= X-IronPort-AV: E=Sophos;i="5.81,269,1610427600"; d="scan'208";a="41257215" From: Anthony PERARD To: CC: Anthony PERARD , Ian Jackson , Wei Liu Subject: [XEN PATCH for-4.15] libxl: Replace deprecated QMP command by "query-cpus-fast" Date: Mon, 22 Mar 2021 14:17:44 +0000 Message-ID: <20210322141744.522041-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain We use the deprecated QMP command "query-cpus" which will be remove in the upcoming QEMU 6.0 release. There's a replacement which is "query-cpus-fast", and have been available since QEMU 2.12 (April 2018). In order to been able to keep using recent version of QEMU, this patch replace the deprecated command by the newer version. And because we are in the "feature freeze" period, this patch is kept simple without fallback (which could have been used when "query-cpus-fast" wasn't available). Signed-off-by: Anthony PERARD --- tools/libs/light/libxl_domain.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c index 5d4ec9071160..e32e1cd39fea 100644 --- a/tools/libs/light/libxl_domain.c +++ b/tools/libs/light/libxl_domain.c @@ -1740,23 +1740,23 @@ static int libxl__set_vcpuonline_xenstore(libxl__gc *gc, uint32_t domid, return rc; } -static int qmp_parse_query_cpus(libxl__gc *gc, - libxl_domid domid, - const libxl__json_object *response, - libxl_bitmap *const map) +static int qmp_parse_query_cpus_fast(libxl__gc *gc, + libxl_domid domid, + const libxl__json_object *response, + libxl_bitmap *const map) { int i; const libxl__json_object *cpu; libxl_bitmap_set_none(map); - /* Parse response to QMP command "query-cpus": - * [ { 'CPU': 'int',...} ] + /* Parse response to QMP command "query-cpus-fast": + * [ { 'cpu-index': 'int',...} ] */ for (i = 0; (cpu = libxl__json_array_get(response, i)); i++) { unsigned int cpu_index; const libxl__json_object *o; - o = libxl__json_map_get("CPU", cpu, JSON_INTEGER); + o = libxl__json_map_get("cpu-index", cpu, JSON_INTEGER); if (!o) { LOGD(ERROR, domid, "Failed to retrieve CPU index."); return ERROR_QEMU_API; @@ -1841,7 +1841,7 @@ int libxl_set_vcpuonline(libxl_ctx *ctx, uint32_t domid, LIBXL_QMP_CMD_TIMEOUT * 1000); if (rc) goto out; qmp->callback = set_vcpuonline_qmp_cpus_queried; - rc = libxl__ev_qmp_send(egc, qmp, "query-cpus", NULL); + rc = libxl__ev_qmp_send(egc, qmp, "query-cpus-fast", NULL); if (rc) goto out; return AO_INPROGRESS; default: @@ -1876,7 +1876,7 @@ static void set_vcpuonline_qmp_cpus_queried(libxl__egc *egc, if (rc) goto out; libxl_bitmap_alloc(CTX, ¤t_map, svos->info.vcpu_max_id + 1); - rc = qmp_parse_query_cpus(gc, qmp->domid, response, ¤t_map); + rc = qmp_parse_query_cpus_fast(gc, qmp->domid, response, ¤t_map); if (rc) goto out; libxl_bitmap_copy_alloc(CTX, final_map, svos->cpumap); @@ -2199,7 +2199,7 @@ static void retrieve_domain_configuration_lock_acquired( libxl_bitmap_alloc(CTX, &rdcs->qemuu_cpus, d_config->b_info.max_vcpus); rdcs->qmp.callback = retrieve_domain_configuration_cpu_queried; - rc = libxl__ev_qmp_send(egc, &rdcs->qmp, "query-cpus", NULL); + rc = libxl__ev_qmp_send(egc, &rdcs->qmp, "query-cpus-fast", NULL); if (rc) goto out; has_callback = true; } @@ -2220,7 +2220,7 @@ static void retrieve_domain_configuration_cpu_queried( if (rc) goto out; - rc = qmp_parse_query_cpus(gc, qmp->domid, response, &rdcs->qemuu_cpus); + rc = qmp_parse_query_cpus_fast(gc, qmp->domid, response, &rdcs->qemuu_cpus); out: retrieve_domain_configuration_end(egc, rdcs, rc); -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Mar 22 14:32:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 14:32:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100243.190878 (Exim 4.92) (envelope-from ) id 1lOLb6-0007k9-Pr; Mon, 22 Mar 2021 14:32:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100243.190878; Mon, 22 Mar 2021 14:32:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLb6-0007k2-MU; Mon, 22 Mar 2021 14:32:00 +0000 Received: by outflank-mailman (input) for mailman id 100243; Mon, 22 Mar 2021 14:31:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLb5-0007jx-HE for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:31:59 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1c617306-5602-4f18-80db-d6aabc99ed3c; Mon, 22 Mar 2021 14:31:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c617306-5602-4f18-80db-d6aabc99ed3c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616423518; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nyr8KSk+KDPShgitquX43mntR61x5GxDgHO+N7oBzic=; b=BLRTbuXsOVOdkB+wKvHbSQgEshXRjxx7BrKpBTJVfp1KjeZlbYEctuuC lqrGK+81uwJUsVNPzMBiWNoT+gGpgyw2teePuGk0wbYjppPZM/2QvNPoZ 476GfCndxL+gbUiB8ooU1ez95/ZFqNm9mq0vLToRTA1Ziwk49377Gf7zz Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: YVWbBJuBGOAQTWgyEqclvkf4VOJr4eJz3KJSkuniw0VkBeBN7px9XY5p504LvHluUxBhdTehuV KjDHwF3WBcrfdo1Qr7ySAEUI/l8H3hl8Y+nW2htupQqOOGmLbazAJtSkklQ0A9bIhMR1T4Cmpy tvtUM/K6v5f8qdcH7kC0X7c8xU+mfnOl3SK5zAd8rcad4mr/4InKcks+XwS/6xONHrRCpHFYUT BDrIfJrkesy+727zF0QB5ruwUG82YhASU8hV4KmBzb6N5PjxIn0fhLCFJFuU7nBin9NQBAkfc/ u+g= X-SBRS: 5.1 X-MesageID: 39812241 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:qTNpx66woxGi2m+VigPXweaEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoexzh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdxHW3tV2kZ 1te60WMrDNJHBxh8ri/U2cG9Ev3NGI/MmT9J3j5l1GJDsaCZ1IxQF/FwqdDwlSTA5JGZI2GP Onl7d6jhCnfmkaadn+O2kdU4H41pD2vb/vfBJuPW9A1CCgljWtgYSbLzG52VMkXypL0fMe9w H+4nfEz4GCl93+9RPGzW/U6P1t6Zfc4/9OHtaFhMRQChiEsHfQWK1bV7ePvC84rYiUgT5A+r esnz4aM8t+8H/XdG2uyCGdozXI6zoy92TkjWaRnHqLm728eBsBF8FDiYhFGyGpjnYIgdBm3K pHm0KfupZHZCmw+xjV2tnSWxlm0nezuHop+NRj60B3bI12Us4zkaUvuGduVLsQFiPz744qVM N0CtvH2fpQeVSGK1jEo2hG2rWXLzsONybDZnJHlt2e0jBQknw85VAf3tYjknAJ8494Y4VY5t 7DLr9jmNh1P4ErRJM4IN1Ebdq8C2TLTx6JGnmVO07bGKYOPG+IjJLr/rMv5qWPdIYTxJU/3L TNOWko9FIaSgbLM4mjzZdL+hfCTCGWRjL20PxT4JB/p/nyX7zuPSqfSE0/kseprvkFa/erGM qbCdZzObvOPGHuEYFG00nVQJ9JM0QTV8UTp5I6Vju104D2A7yvktaeXOfYJbLrHzphcHj4GG E/UD/6I9gF6FuqVH/+iB3YQGjsZUT74JJ1HMHhjqgu4blIErcJnhkeiFy/6M3OFCZLtbYuel BiZJn9lLmgmGWw9WHUzmlgNxZHFHxJ6LH4X34in35OD2rENZI4//SWYyR7wWaOLB4XdbKrLC dv43BMvZ+RA7PV7yY4EN6jOn+dlBIo1Q23ZqZZvLaC68fjco4/FbA8VsVKZEL2PhRohAdnr3 pCYgcYRknZUijjk7mhkYZ8PpCgS/BsxAisOsJasnTZqAGVotwuXGISW3q0XdeQmhtGfUseun Rht6seiqGHgzChNC82h/k5KkRFbA2scft7JRXAYIVfgbbwfg5sCW+MmDyBkhk2Pm7n7V8biG CkLSqaf5jwcxJgk2Ed1qbh61VvcGqBO0p2d3BhqIV4UX3cpWwb657+WoOjl2+KLlcSyOAUNz /IJTMUPwN13tiykBqYgiyLG3kqzognV9atRogLYvXWwDegOYeInaYJE7tP8JFpOMvnv+ULXe icEjXlWg/QGqcswUiYt3wlMC57pD04ivvuwgTi93X903glA/beSW4WMo0zMpWZ9SzjSPmJ2p ki0o5wsuu0L2nratmJjavQdCVOLxvPoWiwC+EkwKokzp4apf92Bd3cVzCNyXRMmBM5J83wnF kFQKt67KvaU7UfCPA6amZc5B4xiN+LLEE3qQT4De81YEE1gxbgTqO0yquNraBqH1aIqwTxM0 SO6iFR///KWC2YyL4RYphAU1h+eQw783Rt/OSLao3WBkGrboh4jSuHDkM= X-IronPort-AV: E=Sophos;i="5.81,269,1610427600"; d="scan'208";a="39812241" Date: Mon, 22 Mar 2021 14:31:54 +0000 From: Anthony PERARD To: , Stefano Stabellini , Paul Durrant CC: , Subject: Re: [PATCH] xen-block: Fix removal of backend instance via xenstore Message-ID: References: <20210308143232.83388-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210308143232.83388-1-anthony.perard@citrix.com> Hi Paul, Stefano, Could one of you could give a Ack to this patch? Thanks, On Mon, Mar 08, 2021 at 02:32:32PM +0000, Anthony PERARD wrote: > From: Anthony PERARD > > Whenever a Xen block device is detach via xenstore, the image > associated with it remained open by the backend QEMU and an error is > logged: > qemu-system-i386: failed to destroy drive: Node xvdz-qcow2 is in use > > This happened since object_unparent() doesn't immediately frees the > object and thus keep a reference to the node we are trying to free. > The reference is hold by the "drive" property and the call > xen_block_drive_destroy() fails. > > In order to fix that, we call drain_call_rcu() to run the callback > setup by bus_remove_child() via object_unparent(). > > Fixes: 2d24a6466154 ("device-core: use RCU for list of children of a bus") > > Signed-off-by: Anthony PERARD > --- > CCing people whom introduced/reviewed the change to use RCU to give > them a chance to say if the change is fine. > --- > hw/block/xen-block.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c > index a3b69e27096f..fe5f828e2d25 100644 > --- a/hw/block/xen-block.c > +++ b/hw/block/xen-block.c > @@ -972,6 +972,15 @@ static void xen_block_device_destroy(XenBackendInstance *backend, > > object_unparent(OBJECT(xendev)); > > + /* > + * Drall all pending RCU callbacks as object_unparent() frees `xendev' > + * in a RCU callback. > + * And due to the property "drive" still existing in `xendev', we > + * cann't destroy the XenBlockDrive associated with `xendev' with > + * xen_block_drive_destroy() below. > + */ > + drain_call_rcu(); > + > if (iothread) { > xen_block_iothread_destroy(iothread, errp); > if (*errp) { > -- > Anthony PERARD > -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Mar 22 14:32:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 14:32:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100245.190893 (Exim 4.92) (envelope-from ) id 1lOLbP-0007od-3B; Mon, 22 Mar 2021 14:32:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100245.190893; Mon, 22 Mar 2021 14:32:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLbP-0007oW-08; Mon, 22 Mar 2021 14:32:19 +0000 Received: by outflank-mailman (input) for mailman id 100245; Mon, 22 Mar 2021 14:32:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLbN-0007oH-P5 for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:32:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLbN-0005EU-Np for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:32:17 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOLbN-0002Ba-Mn for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:32:17 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOLbK-0000AQ-Bs; Mon, 22 Mar 2021 14:32:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=mmQETQBI35ScJsVnqDaaPgevsGpc2rmSd+HCoW5ptp4=; b=53Yk5vfoJ6kbcZwZnu5ze/huAR KSC6al/GJx9AnzrazCZMtVCO4GAgWCDr/B96fILZPahIgjOt2IRTNNf3UybUBxcVUKN5pI1af6wUo ZMtPAewROMgwFm3oah81fx8D6crKK4Z3P5UpRnLtfBQ+9zRBD9oeA2ltuN3heFuKoi7Y=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24664.43630.78608.264828@mariner.uk.xensource.com> Date: Mon, 22 Mar 2021 14:32:14 +0000 To: Anthony PERARD Cc: , Wei Liu , Daniel P. =?iso-8859-1?Q?Berrang=E9?= Subject: Re: [XEN PATCH for-4.15] libxl: Replace deprecated QMP command by "query-cpus-fast" In-Reply-To: <20210322141744.522041-1-anthony.perard@citrix.com> References: <20210322141744.522041-1-anthony.perard@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) We use the deprecated QMP command "query-cpus" which will be remove in > the upcoming QEMU 6.0 release. There's a replacement which is > "query-cpus-fast", and have been available since QEMU 2.12 (April > 2018). > > In order to been able to keep using recent version of QEMU, this patch > replace the deprecated command by the newer version. And because we > are in the "feature freeze" period, this patch is kept simple without > fallback (which could have been used when "query-cpus-fast" wasn't > available). Thank you. I observe that Daniel Berrange also wrote a libxl patch to solve this problem. I read the interdiff and the only difference is that Anthony's patch changes the internal function name to qmp_parse_query_cpus_fast whereas Daniel's doesn't. This gives me a fairly high confidence in the patch :-). Acked-by: Ian Jackson Release-Acked-by: Ian Jackson Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 22 14:48:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 14:48:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100252.190910 (Exim 4.92) (envelope-from ) id 1lOLqZ-0000eU-Ha; Mon, 22 Mar 2021 14:47:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100252.190910; Mon, 22 Mar 2021 14:47:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLqZ-0000eN-ET; Mon, 22 Mar 2021 14:47:59 +0000 Received: by outflank-mailman (input) for mailman id 100252; Mon, 22 Mar 2021 14:47:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLqY-0000eI-8F for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:47:58 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8a287f36-3800-4acd-a284-7f67d9bfecd5; Mon, 22 Mar 2021 14:47:57 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4D0A3ACA8; Mon, 22 Mar 2021 14:47:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a287f36-3800-4acd-a284-7f67d9bfecd5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616424476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nq5tWpmWSEJC7niqzN3YI0POON8gQ/7JH/TmS0++xJA=; b=C5QiO6cnOFy9lZc9FKtDTwCogp3q8kuGl92YM9/5k3hcMlPhHRlbq/1gCm2BIIWX3piiXz isYknDz5OCci+1JNejF/HttMVkz7dpBaqBoI5xTMcfMHfuOOcMyZsVGgU7JgmDnZDjhYBh VmX+rbRFTERgWBfon+QCqnkK1e55ygM= Subject: Re: [XEN PATCH for-4.15] libxl: Replace deprecated QMP command by "query-cpus-fast" To: Anthony PERARD Cc: Ian Jackson , Wei Liu , xen-devel@lists.xenproject.org References: <20210322141744.522041-1-anthony.perard@citrix.com> From: Jan Beulich Message-ID: <03346623-23bb-78d6-b7f4-fa41ac88e782@suse.com> Date: Mon, 22 Mar 2021 15:47:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210322141744.522041-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 22.03.2021 15:17, Anthony PERARD wrote: > We use the deprecated QMP command "query-cpus" which will be remove in > the upcoming QEMU 6.0 release. There's a replacement which is > "query-cpus-fast", and have been available since QEMU 2.12 (April > 2018). IOW the tool stack then isn't going to work anymore on a system with a distro provided qemu just around 3 years old? Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 22 14:52:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 14:52:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100257.190928 (Exim 4.92) (envelope-from ) id 1lOLvC-0001Wv-7T; Mon, 22 Mar 2021 14:52:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100257.190928; Mon, 22 Mar 2021 14:52:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLvC-0001Wo-4G; Mon, 22 Mar 2021 14:52:46 +0000 Received: by outflank-mailman (input) for mailman id 100257; Mon, 22 Mar 2021 14:52:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLvB-0001Wj-Bh for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:52:45 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b09b01e2-82bd-40ee-a1f0-bee7a151b143; Mon, 22 Mar 2021 14:52:44 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C32A5AC1F; Mon, 22 Mar 2021 14:52:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b09b01e2-82bd-40ee-a1f0-bee7a151b143 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616424763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pnWCkOBFtDviVyH70kqDUX1jwe4zQ2RfE46n72j+fqY=; b=mLuA4j47SJNJj5Jjzmg9u8/bRqzbsgPtlutKMpg6clXWnJDWRnoE0h+z4il3PPCZhl/yR7 k2p+VrH0V2p55BSa03fC2IUdkk+rGkqXfvX9zAKnNgTw3gMsvExJXMQ1MMuMMTzMO7XrBZ JrbGCUjicBxoVo7o9kKBRWgDWpoBcFg= Subject: Re: [PATCH] xen: Create EFI_VENDOR directory To: Jason Andryuk Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210322133301.11308-1-jandryuk@gmail.com> From: Jan Beulich Message-ID: Date: Mon, 22 Mar 2021 15:52:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210322133301.11308-1-jandryuk@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 22.03.2021 14:33, Jason Andryuk wrote: > make install-xen fails when EFI_VENDOR is set (=fedora) with: > install: cannot create regular file '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No such file or directory > > Create the EFI_VENDOR directory so xen.efi can be installed within. > > This removes the need for Fedora and Qubes xen.spec files to manually > create the directory in advance. While I'm not strictly against, I'd like to point out that it was deliberate to not create this directory here. I also didn't expect anyone's xen.spec to do so. Instead I'd expect the distro to create it during OS installation. If this was a bad assumption, I'd prefer if the commit message here could point out why such an expectation won't hold in general. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 22 14:59:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 14:59:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100261.190941 (Exim 4.92) (envelope-from ) id 1lOM1x-0001oJ-14; Mon, 22 Mar 2021 14:59:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100261.190941; Mon, 22 Mar 2021 14:59:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOM1w-0001oC-Tl; Mon, 22 Mar 2021 14:59:44 +0000 Received: by outflank-mailman (input) for mailman id 100261; Mon, 22 Mar 2021 14:59:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOM1v-0001o7-9e for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:59:43 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3ec84d2d-820f-486e-b16b-c79a395bb0d0; Mon, 22 Mar 2021 14:59:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ec84d2d-820f-486e-b16b-c79a395bb0d0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616425182; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=k+ThIadZaVI+ovXVbO/r8tuMVO8UAQd0KHXYB3V3zVA=; b=Z1BwDeoMighm5D3Ssd4EqZeRM21N+T7HYOIaVtDterqzq5MRczHSTkVP holOR/QvSIY2Ee3h4D0tFHDtkjvncMSEC5IX8ZtJXMXwFP4551O0u8wHp 1w4Ydue+iZQYZS976xLJAQb5+dO1Fsga9ZxCB4bSGTnLiOl27xT7N6qxD Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: TQgnT4lTxJ4JfykOqvSs8zhoXi4fEaSea6zjeDfhhuItGSr1AJqn1wzc8JYVgTwEqth3yW3mco UcKpW7PNIc1SrdmqeIq8RhDgS00TFDBUG+dbv/UCTYkVzI49/0fO/8V4Y6wVAGlaiEDwppzchD /TUN9MLZt+urWgIq/68mazDwLXk2rczorrEobeWjBodXUccTM7Ze3ljZiMZ2IxxL9H0z3a/qzo atuCz5DRpZAPNd8ziplrYTcacoWngqlRRzYHtho3henrSmVL4HCIFUunJcTazPzHREx4F1vEsk /F0= X-SBRS: 5.2 X-MesageID: 40193820 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:DD9nVaGy+j2z3HKHpLqFRZTXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7Lk/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeNJwTXzcQY76 tpdsFFZeHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLD1CQYsI1XYdNi+wFEpqSA5aQb8wE5 SB7sRKzgDQBkg/RMK9G3UDQqz/vNXNjp3relorABQg5QmIg1qTmcLHOjKf2QoTVC4K/Kc6/Q H+4nHEz4iAk9X+8B/T0GfP849b8eGO9vJvDNGB4/JlUgnEpR2vYO1aKtq/lRAz5Nqi8VM71O TLyi1QRfhbz1P0UiWLrQD22w/muQxemEPK7VODm3PsrYjYaVsBerN8rLlUeBfY9EYs1esUuM kgvxP7xu9qJCjNkyjn69/DWwsCrDvRnVMYnfMOlHsaaIMCadZq3Pwi1XlIG5QNFj+S0vFALM BSCqjnlZRrWG+BY2uclmdix8HEZAVJIj62BmIGusCTzgFMmmF4w0Yy1KUk7wY93aN4ZJ9e6+ veNKN00JlIU88NdKp4QNwMWM2tFwX2MF3xGVPXBW6iOLAMOnrLpZKyyLIp5NuycJhN6Jcpgp zOXH5RqGZaQTOhNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dQWeVVEHiaKb0rYiK/yef8 z2FINdAvflI2erM51OxRfCV55bLmRbeNEJu+w8R0mFrqvwW83Xn92eVMyWCKvmED4iVG+6KG AERiLPKMJJ6V3udWT/hDTXRnPxam3y9Z99C8Hhjq0u4blIErcJnhkeiFy/6M3OAyZFqLYKcE x3J66isq7TnxjzwU/4q0FSfjZNBEdc57vtF1lQoxURDk/yebEf//GWeWVY2mq7NgZyJvmmVz J3lhBSw+aaPpaQzSctB5aMKWSBlUYeo3qMUtM6lrCc49zmPrc1FIwvVqA0NQijLW01pS9a7E N4LCMUTE7WET3jzY+/ioYPOe3Zf95gxCGxIcBVrnrbnV6Gpd4mQ0YaWzLGa7/UvS8eAx5vwn Fh+a4Wh7SN3Ry1L3Ekveg+OFpQLFiMDKl+FwSDboVMkrXNcAV9JF36wwCyulUWQC7H5k8Sjm vuIWmxdevQClRQgHxez53n6Uh5bGmbYkJ2ZE1rqIEVLxW1hl9DlcuwIoaj2WqYbVUPhtsQNz zIehM+CAJjzdLf7m/epB+yUVEdgrk+NO3UC7ouN4zJ0nS2MYuSiOUtBPlP5qtoM9jor84GWe +SYBWuMTv9Eu8lsjbl/0oNCW1Rkj0JgPno0Brq4CyEx3Y5G+PVO0kjaLcBId2QhlKUDsqg4d Fct5YSsuSxOGmqNYLD5qHTcjJZKhTc5USxVPolrJhIvaQ08Jt/dqOrJgfg5TVi5lEZKsyxqW Y1BIJcy5rFMpV0f8MTdzlCl2BZ3+inHQ8OiEjOHuQ6fVsRlHfVMNOC3qrQpdMUczm8jTq1HW PazjZU8PjEVRaSzLI2C6o/JmJNdUg3gU4Sit+qRsn1CA+wcftE80f/GnihcKVFQKztI8Rckj 9Kp/WJlfSQbSz2xUT5uiZ6OLtH9yKCTdmpCAyBXc5O/NrSAyXBvoKapOqyhizwUz21dgAxgp BEb1UZaoB7sQYZ5bdHmhSae+jQuUIqk1xX/DFhmBrM4+GdkRnmNHADFxbYjJVQVSRUKV6Sg6 3+gLCl6Eg= X-IronPort-AV: E=Sophos;i="5.81,269,1610427600"; d="scan'208";a="40193820" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=keJPN0EswLSqPpG1vOsrF33b7S6ImO49DGCcWdwCIPhZQD9O6EJjkbZ+f33isRgCvjju6/SkSj9iIKE62Kd4bJWeZAalbYDd+B6eMLtk+/RocKyF5cUD4jtNUGeDAZpoVRy+Vvas1KEHFZ0u/fTKTYXWTyrRM1NhvGAgHdViHwtVH9NMQpjPPYzakkSLPkaD1wUhOw81SRWVJqU22TKpllGEAiLbhb4jNbTDIGxwrYfBK1l6HxF6RXkl54qAzNwrAmWfzq+gru53EF2vqr0nJL2JFSt+gUkELIu3jfmjEXDCgmzccVxrcA9SbLEUH5Z0TWKPiqvqvPrY2WA874eLDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k+ThIadZaVI+ovXVbO/r8tuMVO8UAQd0KHXYB3V3zVA=; b=b2g9xmXpRnpWzExfOGu1S8D9+rSAaaurl6DenTP7dztikiMA8kOU1+Oz38hv4lORz6N/znq6hGP+35tokaz+wG/Sh1xbwOkAmhgA/2/FGAOUbJgdtWXF6pbeAbADSvpKHrl+/TDxjPP4hDJlkyi7y53uEo72btkvVJxPYmr6CMjDVVL/I5bmWML/2bC+t959kxeNB5X1BXKNxIjTEoXsG9Ra8OOvF0yF4BHafaZZhkApMPbVz3NgC56Hwm50k9tpBI+7HYsjW1zqNpYndnHEar+uKc1vcm/z1pcWPUrqY3WyOB5qKVz5q6XMxc7R3hriBXpHv2ykc3F2AHWpVFJo1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k+ThIadZaVI+ovXVbO/r8tuMVO8UAQd0KHXYB3V3zVA=; b=ZtBHNWiwJYBml75LCeYfUbMF3AvNL7vWLgR1lh4YhlQDzIJ4kzwXfnNo4fu7P808m6BdqBOu2yp7H56uQmAXczVW4AMjIJVyOOixfh/sw+f4iR6XXkPrJECFGXOTtLHCbE600h6hQRL4e0rcDJL3UKjKDbJtaNO1tqp+nnZ6ROM= To: Jan Beulich , Jason Andryuk CC: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , References: <20210322133301.11308-1-jandryuk@gmail.com> From: Andrew Cooper Subject: Re: [PATCH] xen: Create EFI_VENDOR directory Message-ID: Date: Mon, 22 Mar 2021 14:59:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0143.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::22) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7ece9696-d1f5-4a18-4e5a-08d8ed431437 X-MS-TrafficTypeDiagnostic: BN7PR03MB3876: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iQY/u8pOIKv2kB8C9MT1JTeUUHWYgiySQhhCwlC754oJBzSQM4XpBvQd90J6Oq/c2mHpinZkErNxTWd4JNk7s5v2AWrAtgVfcXQCGFNqpL4CAlG0edNoaisHhZ3R+0lpezK66j1dCAEbKTKpwIt2cIVVTqec+nBjW+lld0h4DrVDhUgX3PD6S0WeSzJ1Kw4wcqQZrmIcbBqMyaSS+v4mP2CdRQ03jWoxVut4PFYnz2xzKa4RhTf473UXfHOfYrqMyJ/zfplzEv0umDLCsiQnIUCF3Lo7ZIzpJKa80x5A88c6e5yHCHyKwoP2wu3wMAiAWSuB15J/brt1aDMsn6lX0DZkYUdF5Zo697F5Cai7G5RAT33agPPuhEES1UcF07tJXB55FBSd8cU/nY4vvKAqa3YGWJcQySORI9E8aaWY+A4bHikSJJ06yqeqn/eia1fcivatQnmBsNO/X+lIn2Y1em4v4o495u3+28dmksOt3zbqyP+QQKgVqdkcwJZo82DGqpcZv/hqF/kxATR6yLKyD/eX16tI5TU5jX/mzizMQhFpWgTQL3axWWzCaAYPk5GloHUS63k0NaF2bGi7XtcAjJrkHmQJ7kQslYZVVrUic/ZcxvDO2Apv/G7nmEPKHa+VMDDWYU4JGX7NBab5/HnjkkNFrVdPjxgM+mF6APnvUsZp+p7rnN2+8SVdKB4WzkT7xM3kNbMuNIUtCyaWPdiSLJrOYePwjVP8i5eBrNH1Ad4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(376002)(39860400002)(396003)(136003)(2906002)(31696002)(5660300002)(66556008)(16526019)(4326008)(53546011)(38100700001)(31686004)(478600001)(4744005)(8676002)(316002)(66946007)(66476007)(956004)(2616005)(83380400001)(8936002)(26005)(110136005)(6666004)(16576012)(86362001)(54906003)(6486002)(36756003)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZFRyc1ZNZUtBQXFoTUJGMGxuNHA5VG1YN2hVQXRvQll1YkdDNSthRS9Mb04z?= =?utf-8?B?RnNtY0swMHZZZE01SFN2T3htQXkzYlFQOUFPcDFJVmV5V09vZVh3Q0NibnQ1?= =?utf-8?B?L0VqNzlLYy9kTmY5ME9UaUNiSytWVitDRzBEcUpENGJOQkFVaE11M3YzMGZ0?= =?utf-8?B?Yjg4dFZrc2hGR2t4dFpNMCsxVVpuWFUvc3h3T2NDL0xRdE9XeVovbk1pUmta?= =?utf-8?B?amVnZzZvb0dZcWlsOXpIa0RQc0hsQUxTRnFHMEVlTjBSN0lRODhzRmdaaFRt?= =?utf-8?B?UVhhVUpvSkg1UE5jdXhUUngzQTJvRXUwZFcxbis3TGFNc0ZUUlBrdUtrSzlx?= =?utf-8?B?NWtMWXZvR1R4cHkrc1dyeXIxTExRTTlpNmZxYittUnRIZDJ3V2U3TG12N3cz?= =?utf-8?B?cmdXZUdvZUlvOEhKWVZieGhiNWlUTVBhTGVpWFVVUkFxZE9rQjVGckY4Smpl?= =?utf-8?B?S2l0a01LQzdGMituVEtoU1VpUHc2NFYzWjZSby85em5NU1pwRmtTWUxKUXds?= =?utf-8?B?YkZRcUxiaVQrclJYMXdEbFN0R3g0YzY3L25PQ2xMTWtWYzdRRE9wNHJVdWFF?= =?utf-8?B?SmtxdElCOTBqelZ0VUpsMnhWRSs1UktmZm5BSExCclUyMHhkY0h3OUpkQ1J5?= =?utf-8?B?ZFNPTWlKQkFEWFNGVlg4aUhpRHRwZCsyZW1JdnFUV1NlYnMxRlp1M01zL2ZZ?= =?utf-8?B?aTUrSDJMbFNoMG1JcjA1OHVNY1ZmMGViQTMydGJlMldnYnNsK1QrSDF0c2Y1?= =?utf-8?B?UFM3MkR4RzgxZEk3MmtVYk54M2FXa0djT0tiTWJTZ3JPNCtvRTFsSE1pM2RS?= =?utf-8?B?bFd0cVhHK3pGNEo2VDNrcncweS9tbDg4YkpRM21Bd2xMYXY3NEcvN2hMTERT?= =?utf-8?B?ajF4c2lqWjRYMHBTbWJXSCtyU05sczNmODRxQU9OZVdOV0tYOVhsZUtNMUxD?= =?utf-8?B?ZWh5ZE9iZzVmUlNDbG9qcHZCZE9rRXZsbTllN1FTVmZsd2hhODNKaHlvSlZp?= =?utf-8?B?bnU5blpjTDZObnBERWltR1p6ZGF2Z2tlVldDQjhRdzZ2RTY2SlNjTE5BZG9r?= =?utf-8?B?djkzY0QxT2VzY2ZXQW5aK2tqVzNEVW9qK0h3bjZBNWJDWWtkbjdhQVRPRnlZ?= =?utf-8?B?SlZTM25hQWUvWGlzT0FRUTFudm82K2FValZYVnhJL2V2Z3VlN0oyUThXOXUv?= =?utf-8?B?VFpITjB1andHRVJ0d2lkQzA5QUxoY2p4OFdLeDNhWFhJVlcyL2RMUDhqSWdt?= =?utf-8?B?NWR2ZWNiYWkxdmlsMDBBN3FMZFVVY0E0UmhFWk5uUXhXckJNMU1XY3k4TGtw?= =?utf-8?B?UTd4ajVzenFVYU5pZjduQmZLbTEwNUlyVFVQbEZNNUdTZDZzNTladGEvUk1C?= =?utf-8?B?VzBmalhFdUxhUWZ3YmNZbmtpRGVwaEtrbkRVQkpVU0NFTUxIckZnbUpOa1kz?= =?utf-8?B?Q2tXczNVMFdyRzVhWWRESFRCZUxXNGQ5b0ZDSWN1Y3NrazlrVXpLaTlyZzdm?= =?utf-8?B?VTRQOWg1OWROMHQrMkZuenZ0WW5INUxuYXVhMm5YbHEzTDB5Z1FCcTZ5Sm5a?= =?utf-8?B?cHczaERsNGlhd0JHZTRyOG01VHFCWW1yeXhXT094a0gybnZWTTVPVk5HRGhu?= =?utf-8?B?dFpRVjFFUXhvSGk0UkRRcDJqZ2k4RlhaUFNwSEFNbHRqL1I1UnN6ci9aVW05?= =?utf-8?B?T0IralM4UFhiNzB1NG5mbk0xRVpnc1BOS1RGV3FtSWtINFg0NmZDNmNXU2h4?= =?utf-8?Q?Zsv+02nXVTD9wsoxLgkHKAgE7m7xBKqFHhybnFf?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7ece9696-d1f5-4a18-4e5a-08d8ed431437 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2021 14:59:23.2594 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2m4WgpMOFs/3j+yk/zrRIxJUBsCJiPduoH5xf5I1USRDU7IEAGNs8P/FmI1c7l7ERyviUv3C+Arivo05WEgLzJnCrn7IFMbBQOY+TifK71s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3876 X-OriginatorOrg: citrix.com On 22/03/2021 14:52, Jan Beulich wrote: > On 22.03.2021 14:33, Jason Andryuk wrote: >> make install-xen fails when EFI_VENDOR is set (=3Dfedora) with: >> install: cannot create regular file '/home/user/xen/dist/install/boot/ef= i/efi/fedora/xen-4.15.0-rc.efi': No such file or directory >> >> Create the EFI_VENDOR directory so xen.efi can be installed within. >> >> This removes the need for Fedora and Qubes xen.spec files to manually >> create the directory in advance. > While I'm not strictly against, I'd like to point out that it was > deliberate to not create this directory here. I also didn't expect > anyone's xen.spec to do so. Instead I'd expect the distro to create > it during OS installation. If this was a bad assumption, I'd prefer > if the commit message here could point out why such an expectation > won't hold in general. This reasoning is broken for anything other `make install DESTDIR=3D/` on a live system. It is incompatible with how RPM, deb, etc packages work. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 22 15:00:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 15:00:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100264.190953 (Exim 4.92) (envelope-from ) id 1lOM2N-0002cL-D0; Mon, 22 Mar 2021 15:00:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100264.190953; Mon, 22 Mar 2021 15:00:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOM2N-0002cE-9T; Mon, 22 Mar 2021 15:00:11 +0000 Received: by outflank-mailman (input) for mailman id 100264; Mon, 22 Mar 2021 15:00:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOM2L-0002c1-Gd for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 15:00:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOM2L-0005jl-CI for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 15:00:09 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOM2L-0004n6-B5 for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 15:00:09 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOM2F-0000F2-0W; Mon, 22 Mar 2021 15:00:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=2N1jnvurNKUtii5hwDVxnCrCLxQBod9h6uKWLslqKsQ=; b=hHhNBoaoehZIOGilAvV9Rxo3ju I2iObO6J6H077iUaAPkiA3yNYpno9n1xRcTr1mePcme75zo4sxX50991vBSKXNsXvaSVEhj9d9Q7O pulORLF2btdx3apg/XMl3os31B4GWNBNIksqCeRcSBfzYGIAfvvIcIdmTJtxxYJsV43Y=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24664.45298.802322.862546@mariner.uk.xensource.com> Date: Mon, 22 Mar 2021 15:00:02 +0000 To: Jan Beulich Cc: Anthony PERARD , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH for-4.15] libxl: Replace deprecated QMP command by "query-cpus-fast" In-Reply-To: <03346623-23bb-78d6-b7f4-fa41ac88e782@suse.com> References: <20210322141744.522041-1-anthony.perard@citrix.com> <03346623-23bb-78d6-b7f4-fa41ac88e782@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [XEN PATCH for-4.15] libxl: Replace deprecated QMP command by "query-cpus-fast""): > On 22.03.2021 15:17, Anthony PERARD wrote: > > We use the deprecated QMP command "query-cpus" which will be remove in > > the upcoming QEMU 6.0 release. There's a replacement which is > > "query-cpus-fast", and have been available since QEMU 2.12 (April > > 2018). > > IOW the tool stack then isn't going to work anymore on a system with > a distro provided qemu just around 3 years old? 4.15.0 won't, unless we take the further "do it both ways" patch. I think my inclination is to do that after .0. That doesn't seem so unreasonable for a newly-released Xen. Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 22 15:04:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 15:04:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100272.190970 (Exim 4.92) (envelope-from ) id 1lOM5g-0002pV-UI; Mon, 22 Mar 2021 15:03:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100272.190970; Mon, 22 Mar 2021 15:03:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOM5g-0002pO-R8; Mon, 22 Mar 2021 15:03:36 +0000 Received: by outflank-mailman (input) for mailman id 100272; Mon, 22 Mar 2021 15:03:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOM5f-0002pJ-1a for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 15:03:35 +0000 Received: from mail-wr1-x431.google.com (unknown [2a00:1450:4864:20::431]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5d2df914-acb7-4cbf-9885-cbb33211ccaf; Mon, 22 Mar 2021 15:03:34 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id x16so17403688wrn.4 for ; Mon, 22 Mar 2021 08:03:34 -0700 (PDT) Received: from [192.168.1.186] (host86-180-176-157.range86-180.btcentralplus.com. [86.180.176.157]) by smtp.gmail.com with ESMTPSA id h20sm16581667wmm.19.2021.03.22.08.03.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 08:03:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d2df914-acb7-4cbf-9885-cbb33211ccaf DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FyP9CipjvFpnfIqIEbRW3KkKZKHL4tdWtHw8eenVhOs=; b=ngsJbkSbB68/BK8rR8NN4PR8UYpk7qy0aweAHGnrs3lvNHF+79dWdjGn5dfdnzKv1q 187iK4judF55K+6+yw7N3pPYUvpkWLd+iYyLk/ytKZUl3GM67n0/AW7MBb406TA+RU31 wLT5Dqox1/LyC9NKW7I6QCYZgEzHiD8kqMRI+FPdypGgB4B6R1K1RnV9JefMwBhmbh7O e3sGwZmtXgnz+YznGhSoihqT60QPiDXBru1Bb9esXsS/V5j6v7VUv6KuEOtv5k0AP4OR cMV7aX0bL5Qn1TuJYPa6vYb3+4X0oyiEsX3Vb32luXEhu0VzgIrB4A/ccwNaPGH0tNXl FcNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:cc:references :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=FyP9CipjvFpnfIqIEbRW3KkKZKHL4tdWtHw8eenVhOs=; b=p6SP4Bz3va/wYFuRxRHZrzR59kZ/EFMhvHOFiYP/sTz6aEQ+7+VQF+izscNLD3iI6D H8Hc13HTicoDlc38j7g2j3udWWjcGKA24XxzIZhdj2Nyhdt6EYtXJDlOR1t+9X0hzKj7 QC7/xRmUBbG/uZs1cWINO/GxMyQoj6v+WwBHGGSW7Ylkazfc8OQo8cDD4Y0B6+/ML5iL 9Qfza40OGwWMKWGNP7HSrq8Am114sXAZndiJ/Qdso7qQMbsy+U4tGimfQ1xA8kkao9Ta auwycGRck+pObbkXOwhtwqt6tHCUXbVpOxvsdT5v35hs5WPbQz5CyDQgjMGwE74FT4sj 8ATw== X-Gm-Message-State: AOAM530g39vMir2eKmkOiZxw1NOhon4of/zjqZZ8i6vx8qD9DixvqgxD i4ZJjtZGfNZNqB3y04WrSes= X-Google-Smtp-Source: ABdhPJwl+Akc0f4Vw6dmZAHeDuIS90Prg7ispLruT5TEXhAJEajQoiQ3XN64LU46pmJxRWSgR67SSQ== X-Received: by 2002:adf:fd48:: with SMTP id h8mr18745163wrs.229.1616425413226; Mon, 22 Mar 2021 08:03:33 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] xen-block: Fix removal of backend instance via xenstore To: Anthony PERARD , qemu-devel@nongnu.org Cc: Paolo Bonzini , Stefan Hajnoczi , Maxim Levitsky , Stefano Stabellini , Kevin Wolf , Max Reitz , xen-devel@lists.xenproject.org, qemu-block@nongnu.org References: <20210308143232.83388-1-anthony.perard@citrix.com> Message-ID: Date: Mon, 22 Mar 2021 15:03:31 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210308143232.83388-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/03/2021 14:32, Anthony PERARD wrote: > From: Anthony PERARD > > Whenever a Xen block device is detach via xenstore, the image > associated with it remained open by the backend QEMU and an error is > logged: > qemu-system-i386: failed to destroy drive: Node xvdz-qcow2 is in use > > This happened since object_unparent() doesn't immediately frees the > object and thus keep a reference to the node we are trying to free. > The reference is hold by the "drive" property and the call > xen_block_drive_destroy() fails. > > In order to fix that, we call drain_call_rcu() to run the callback > setup by bus_remove_child() via object_unparent(). > > Fixes: 2d24a6466154 ("device-core: use RCU for list of children of a bus") > > Signed-off-by: Anthony PERARD > --- > CCing people whom introduced/reviewed the change to use RCU to give > them a chance to say if the change is fine. > --- > hw/block/xen-block.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c > index a3b69e27096f..fe5f828e2d25 100644 > --- a/hw/block/xen-block.c > +++ b/hw/block/xen-block.c > @@ -972,6 +972,15 @@ static void xen_block_device_destroy(XenBackendInstance *backend, > > object_unparent(OBJECT(xendev)); > > + /* > + * Drall all pending RCU callbacks as object_unparent() frees `xendev' s/Drall/Drain ? > + * in a RCU callback. > + * And due to the property "drive" still existing in `xendev', we > + * cann't destroy the XenBlockDrive associated with `xendev' with s/cann't/can't With those fixed... Reviewed-by: Paul Durrant > + * xen_block_drive_destroy() below. > + */ > + drain_call_rcu(); > + > if (iothread) { > xen_block_iothread_destroy(iothread, errp); > if (*errp) { > From xen-devel-bounces@lists.xenproject.org Mon Mar 22 15:15:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 15:15:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100278.190989 (Exim 4.92) (envelope-from ) id 1lOMHR-0003rf-4X; Mon, 22 Mar 2021 15:15:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100278.190989; Mon, 22 Mar 2021 15:15:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOMHR-0003rY-0z; Mon, 22 Mar 2021 15:15:45 +0000 Received: by outflank-mailman (input) for mailman id 100278; Mon, 22 Mar 2021 15:15:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOMHQ-0003rT-03 for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 15:15:44 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a53eac39-0335-46c8-bd93-9f858c093683; Mon, 22 Mar 2021 15:15:43 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2DC2CACFC; Mon, 22 Mar 2021 15:15:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a53eac39-0335-46c8-bd93-9f858c093683 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616426142; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LMnxDHlFh0KEiXr2igI18wn4J3EBLsaAX28JH8HC9wY=; b=lsXhN1Bf2XxKoAxctghnaemkmDTagHb4JbTV9yKQEtZ+ckyVukLQG8ZmjYjfeDrNo3ejdo HVlH16LgE2v+LCNydMc3sBivz5rWZ1AETeeoEoB41uOSaqJXqgiX9hJNbjSpque/UQYzDg IDE3joDHCA6yQe2i/ju9E/nzl1BeUQ0= Subject: Re: [PATCH] xen: Create EFI_VENDOR directory To: Andrew Cooper Cc: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Jason Andryuk References: <20210322133301.11308-1-jandryuk@gmail.com> From: Jan Beulich Message-ID: Date: Mon, 22 Mar 2021 16:15:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 22.03.2021 15:59, Andrew Cooper wrote: > On 22/03/2021 14:52, Jan Beulich wrote: >> On 22.03.2021 14:33, Jason Andryuk wrote: >>> make install-xen fails when EFI_VENDOR is set (=fedora) with: >>> install: cannot create regular file '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No such file or directory >>> >>> Create the EFI_VENDOR directory so xen.efi can be installed within. >>> >>> This removes the need for Fedora and Qubes xen.spec files to manually >>> create the directory in advance. >> While I'm not strictly against, I'd like to point out that it was >> deliberate to not create this directory here. I also didn't expect >> anyone's xen.spec to do so. Instead I'd expect the distro to create >> it during OS installation. If this was a bad assumption, I'd prefer >> if the commit message here could point out why such an expectation >> won't hold in general. > > This reasoning is broken for anything other `make install DESTDIR=/` on > a live system. > > It is incompatible with how RPM, deb, etc packages work. I'm afraid I don't understand, for both of your statements. If distro installation put in place the designated directory, there wouldn't be any live system lacking it, and there wouldn't be any concern in the packaging of any software. To take a perhaps too extreme example - packages typically expect e.g. /usr to exist as well, don't they? Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 22 15:37:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 15:37:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100283.191006 (Exim 4.92) (envelope-from ) id 1lOMc3-0005p8-Qm; Mon, 22 Mar 2021 15:37:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100283.191006; Mon, 22 Mar 2021 15:37:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOMc3-0005p1-Ns; Mon, 22 Mar 2021 15:37:03 +0000 Received: by outflank-mailman (input) for mailman id 100283; Mon, 22 Mar 2021 15:37:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOMc2-0005ow-Ii for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 15:37:02 +0000 Received: from mail-lj1-x230.google.com (unknown [2a00:1450:4864:20::230]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8a71d934-5a16-45c2-b3d8-f8951cf58ee8; Mon, 22 Mar 2021 15:37:01 +0000 (UTC) Received: by mail-lj1-x230.google.com with SMTP id z8so21562602ljm.12 for ; Mon, 22 Mar 2021 08:37:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a71d934-5a16-45c2-b3d8-f8951cf58ee8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Tex42UKk0K+rcZYZjkKMwzBk0Yr4t+pr+Afe9kjbTqU=; b=MA0rN0PWT4EaFk3ko8leqNmKMr1wm5Cjpk5WPLfrZvlbviUR473lY8jB+GsIn9Ly5m mU4q+/Wytp1mQxYIAB7pReMds8go9VnJa1YfMj6gzxgrZIkdg8qf3ZhOz3nlz+RO7RAQ NBi3hRAj/Ww2jhCE2jE6D8IrxfWCNe8wduC0aXiyPMRtUkOsB+khZTwy8QY/uUVSPSka +r+joGiJ/ravz+BtCq6L7BtUfsqFpBfiZlpmEiUAoFYqbyTWk+N7wgDRbEjDp1h8s8GC lhVjTpsF2sHGp7JYxzpv593LYVOu8TvmRoCCngwadwWr5IynJmXf9cMGZ8gq0wDR+qxQ wXTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Tex42UKk0K+rcZYZjkKMwzBk0Yr4t+pr+Afe9kjbTqU=; b=A2zSmEGl1yHymvSpBAUxs13oiU67MW2ZcrP8Z0wgrpU7K6VKrNdF1h1Sv8TheFii2B 8D5UevixbPT6DEn9ISelCooNtbsxUbZgChf7sql/MwKZvAePD74ypV5oHEYC9tMJudaw NsER2nMa0aKdGhqGKjmSvWWKrYLdan40l8hcHv+UgNxPqgaw3qWgpADQydIqh51AWKeZ 3GCGosGMxeHkS6ulC+AE/+xxPQJblaAmOQXdyreDDuScIhnr21KDJ7HKQo5w4De550lV 2fQWRNpPFFQ2vPWVJN7XfGm5fneDHpYJBnKeZa8Carss8B858bX7Zr08tO+OjMV9RFBK LIJA== X-Gm-Message-State: AOAM533ajYZXhtySv3B2cUL3yx75WJlPxOS6vKdye/vm/oIVY9s9sMPB 49HhVgV4aU8qX4WQs2fHYbY0BQi2Y/dVeV6l96M= X-Google-Smtp-Source: ABdhPJyiyD7DLTei0gjr0Azw2mhflht4Qr/F4Yanpt2kG/0qc2ulHZFmrW6n7psdQgwt0Wu1foQLxdbz6fpzXd8PmwM= X-Received: by 2002:a2e:9e8e:: with SMTP id f14mr110380ljk.285.1616427420600; Mon, 22 Mar 2021 08:37:00 -0700 (PDT) MIME-Version: 1.0 References: <20210322133301.11308-1-jandryuk@gmail.com> In-Reply-To: From: Jason Andryuk Date: Mon, 22 Mar 2021 11:36:48 -0400 Message-ID: Subject: Re: [PATCH] xen: Create EFI_VENDOR directory To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel Content-Type: text/plain; charset="UTF-8" On Mon, Mar 22, 2021 at 11:15 AM Jan Beulich wrote: > > On 22.03.2021 15:59, Andrew Cooper wrote: > > On 22/03/2021 14:52, Jan Beulich wrote: > >> On 22.03.2021 14:33, Jason Andryuk wrote: > >>> make install-xen fails when EFI_VENDOR is set (=fedora) with: > >>> install: cannot create regular file '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No such file or directory > >>> > >>> Create the EFI_VENDOR directory so xen.efi can be installed within. > >>> > >>> This removes the need for Fedora and Qubes xen.spec files to manually > >>> create the directory in advance. > >> While I'm not strictly against, I'd like to point out that it was > >> deliberate to not create this directory here. I also didn't expect > >> anyone's xen.spec to do so. Instead I'd expect the distro to create > >> it during OS installation. If this was a bad assumption, I'd prefer > >> if the commit message here could point out why such an expectation > >> won't hold in general. I didn't write this for an rpm xen.spec - I just cross referenced out of curiosity. > > This reasoning is broken for anything other `make install DESTDIR=/` on > > a live system. > > > > It is incompatible with how RPM, deb, etc packages work. > > I'm afraid I don't understand, for both of your statements. If distro > installation put in place the designated directory, there wouldn't be > any live system lacking it, and there wouldn't be any concern in the > packaging of any software. > > To take a perhaps too extreme example - packages typically expect e.g. > /usr to exist as well, don't they? But you have to install -d ${D}/usr before install ${D}/usr/file, right? It's a surprising sequence to: 1) see 'EFI installation only partially done (EFI_VENDOR not set)' 2) set EFI_VENDOR 3) see xen.efi installation fail I was working on a fedora system, and I was using `make && sh install.sh` to install (but be sure to `rm -r dist/install/var/run` since otherwise that'll break booting). I wanted xen.efi to end up in /boot/efi/EFI/fedora after running `sh install.sh`, and EFI_VENDOR appeared to be the way to do it. Again, it was surprising to enable an option and then have it break. Regards, Jason From xen-devel-bounces@lists.xenproject.org Mon Mar 22 15:47:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 15:47:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100291.191028 (Exim 4.92) (envelope-from ) id 1lOMlq-0006s7-V3; Mon, 22 Mar 2021 15:47:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100291.191028; Mon, 22 Mar 2021 15:47:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOMlq-0006s0-Rn; Mon, 22 Mar 2021 15:47:10 +0000 Received: by outflank-mailman (input) for mailman id 100291; Mon, 22 Mar 2021 15:47:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOMlp-0006ro-NE for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 15:47:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOMlp-0006VL-Lb for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 15:47:09 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOMlp-0007Zm-Ko for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 15:47:09 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOMlm-0000SU-Dc; Mon, 22 Mar 2021 15:47:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID: Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=QFVieVe62zkpf8DxrvcbVuPF/MGQ0CiXLe0qGXhW0ek=; b=cmcsQ6bt3tOplT+Csjxg7G1pyC 5P3MJsfZ994ErY6rHPvs6aqofl2nHmvUdbNtWkf/ExhLzjsa335NN7/KaiUumNC1XRPjsjkiwyItC Nr5AnXsngo4Gjt0GBPmT3WsYLwc0+IkwYk9UQK+eTTKNpYnslgZ7fsmgXoT/mEh20SUU=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24664.48122.241503.647432@mariner.uk.xensource.com> Date: Mon, 22 Mar 2021 15:47:06 +0000 To: xen-announce@lists.xenproject.org CC: xen-devel@lists.xenproject.org, xen-users@lists.xenproject.org Subject: Xen 4.15 RC4 From: Ian Jackson Date: Mon, 15 Mar 2021 12:14:51 +0000 Xen 4.15 RC4 is now available. It is available from git: git clone https://xenbits.xenproject.org/git-http/xen.git -b 4.15.0-rc4 For your convenience a tarball is available: https://downloads.xenproject.org/release/xen/4.15.0-rc4/xen-4.15.0-rc4.tar.gz https://downloads.xenproject.org/release/xen/4.15.0-rc4/xen-4.15.0-rc4.tar.gz.sig Please send bug reports and test reports to xen-devel@lists.xenproject.org. When sending bug reports, please CC relevant maintainers and me (iwj@xenproject.org). I will send an update on the state of the release fairly soon. Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 22 16:12:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 16:12:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100321.191074 (Exim 4.92) (envelope-from ) id 1lON9o-000223-Iu; Mon, 22 Mar 2021 16:11:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100321.191074; Mon, 22 Mar 2021 16:11:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lON9o-00021w-FM; Mon, 22 Mar 2021 16:11:56 +0000 Received: by outflank-mailman (input) for mailman id 100321; Mon, 22 Mar 2021 16:11:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lON9n-00021r-CS for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 16:11:55 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 528b16e0-b123-458d-a83c-84fab25a6446; Mon, 22 Mar 2021 16:11:53 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 059B31042; Mon, 22 Mar 2021 09:11:53 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F3BE43F719; Mon, 22 Mar 2021 09:11:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 528b16e0-b123-458d-a83c-84fab25a6446 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2 0/5] xen/arm: smmuv1: Fix stream match conflict issue Date: Mon, 22 Mar 2021 16:11:34 +0000 Message-Id: X-Mailer: git-send-email 2.17.1 This patch is the work to fix the stream match conflict issue when two devices have the same stream-id. Approach taken is to merge the below commit from Linux driver to fix the issue. 1. "iommu/arm-smmu: Handle stream IDs more dynamically" commit 21174240e4f4439bb8ed6c116cdbdc03eba2126e 2. "iommu/arm-smmu: Consolidate stream map entry state" commit 1f3d5ca43019bff1105838712d55be087d93c0da 3. "iommu/arm-smmu: Keep track of S2CR state" commit 8e8b203eabd8b9e96d02d6339e4abce3e5a7ea4b 4. "iommu/arm-smmu: Add a stream map entry iterator" commit d3097e39302083d58922a3d1032d7d59a63d263d 5. "iommu/arm-smmu: Intelligent SMR allocation" commit 588888a7399db352d2b1a41c9d5b3bf0fd482390 Changes since v2: - Updated commit message to show the original author of the patch. - Added Acked-by: Stefano Stabellini - Addded Reviewed-by: Bertrand Marquis Rahul Singh (5): xen/arm: smmuv1: Handle stream IDs more dynamically xen/arm: smmuv1: Consolidate stream map entry state xen/arm: smmuv1: Keep track of S2CR state xen/arm: smmuv1: Add a stream map entry iterator xen/arm: smmuv1: Intelligent SMR allocation xen/drivers/passthrough/arm/smmu.c | 423 ++++++++++++++++++----------- 1 file changed, 262 insertions(+), 161 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 16:12:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 16:12:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100322.191087 (Exim 4.92) (envelope-from ) id 1lONAJ-00026r-St; Mon, 22 Mar 2021 16:12:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100322.191087; Mon, 22 Mar 2021 16:12:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONAJ-00026k-PG; Mon, 22 Mar 2021 16:12:27 +0000 Received: by outflank-mailman (input) for mailman id 100322; Mon, 22 Mar 2021 16:12:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONAI-00026e-NI for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 16:12:26 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 8ae1e02f-de04-4a52-a967-bee1c5d9d7af; Mon, 22 Mar 2021 16:12:25 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 46EF81042; Mon, 22 Mar 2021 09:12:25 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4E09F3F719; Mon, 22 Mar 2021 09:12:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ae1e02f-de04-4a52-a967-bee1c5d9d7af From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2 1/5] xen/arm: smmuv1: Handle stream IDs more dynamically Date: Mon, 22 Mar 2021 16:11:35 +0000 Message-Id: <7bef784872009bced133b327e3c7bcfce198bb65.1616428314.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Backport commit 21174240e4f4439bb8ed6c116cdbdc03eba2126e "iommu/arm-smmu: Handle stream IDs more dynamically" from the Linux ernel. This patch is the preparatory work to fix the stream match conflict when two devices have the same stream-id. Original commit message: iommu/arm-smmu: Handle stream IDs more dynamically Rather than assuming fixed worst-case values for stream IDs and SMR masks, keep track of whatever implemented bits the hardware actually reports. This also obviates the slightly questionable validation of SMR fields in isolation - rather than aborting the whole SMMU probe for a hardware configuration which is still architecturally valid, we can simply refuse masters later if they try to claim an unrepresentable ID or mask (which almost certainly implies a DT error anyway). Acked-by: Will Deacon Tested-by: Lorenzo Pieralisi Signed-off-by: Robin Murphy Signed-off-by: Will Deacon Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini Reviewed-by: Bertrand Marquis --- xen/drivers/passthrough/arm/smmu.c | 43 +++++++++++++++--------------- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 3e8aa37866..adfab8ee84 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -440,9 +440,7 @@ static struct iommu_group *iommu_group_get(struct device *dev) #define ARM_SMMU_GR0_SMR(n) (0x800 + ((n) << 2)) #define SMR_VALID (1U << 31) #define SMR_MASK_SHIFT 16 -#define SMR_MASK_MASK 0x7fff #define SMR_ID_SHIFT 0 -#define SMR_ID_MASK 0x7fff #define ARM_SMMU_GR0_S2CR(n) (0xc00 + ((n) << 2)) #define S2CR_CBNDX_SHIFT 0 @@ -632,6 +630,8 @@ struct arm_smmu_device { atomic_t irptndx; u32 num_mapping_groups; + u16 streamid_mask; + u16 smr_mask_mask; DECLARE_BITMAP(smr_map, ARM_SMMU_MAX_SMRS); unsigned long s1_input_size; @@ -2140,39 +2140,40 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu) dev_notice(smmu->dev, "\tcoherent table walk\n"); } + /* Max. number of entries we have for stream matching/indexing */ + size = 1 << ((id >> ID0_NUMSIDB_SHIFT) & ID0_NUMSIDB_MASK); + smmu->streamid_mask = size - 1; if (id & ID0_SMS) { - u32 smr, sid, mask; + u32 smr; smmu->features |= ARM_SMMU_FEAT_STREAM_MATCH; - smmu->num_mapping_groups = (id >> ID0_NUMSMRG_SHIFT) & - ID0_NUMSMRG_MASK; - if (smmu->num_mapping_groups == 0) { + size = (id >> ID0_NUMSMRG_SHIFT) & ID0_NUMSMRG_MASK; + if (size == 0) { dev_err(smmu->dev, "stream-matching supported, but no SMRs present!\n"); return -ENODEV; } - smr = SMR_MASK_MASK << SMR_MASK_SHIFT; - smr |= (SMR_ID_MASK << SMR_ID_SHIFT); + /* + * SMR.ID bits may not be preserved if the corresponding MASK + * bits are set, so check each one separately. We can reject + * masters later if they try to claim IDs outside these masks. + */ + smr = smmu->streamid_mask << SMR_ID_SHIFT; writel_relaxed(smr, gr0_base + ARM_SMMU_GR0_SMR(0)); smr = readl_relaxed(gr0_base + ARM_SMMU_GR0_SMR(0)); + smmu->streamid_mask = smr >> SMR_ID_SHIFT; - mask = (smr >> SMR_MASK_SHIFT) & SMR_MASK_MASK; - sid = (smr >> SMR_ID_SHIFT) & SMR_ID_MASK; - if ((mask & sid) != sid) { - dev_err(smmu->dev, - "SMR mask bits (0x%x) insufficient for ID field (0x%x)\n", - mask, sid); - return -ENODEV; - } + smr = smmu->streamid_mask << SMR_MASK_SHIFT; + writel_relaxed(smr, gr0_base + ARM_SMMU_GR0_SMR(0)); + smr = readl_relaxed(gr0_base + ARM_SMMU_GR0_SMR(0)); + smmu->smr_mask_mask = smr >> SMR_MASK_SHIFT; dev_notice(smmu->dev, - "\tstream matching with %u register groups, mask 0x%x\n", - smmu->num_mapping_groups, mask); - } else { - smmu->num_mapping_groups = (id >> ID0_NUMSIDB_SHIFT) & - ID0_NUMSIDB_MASK; + "\tstream matching with %lu register groups, mask 0x%x", + size, smmu->smr_mask_mask); } + smmu->num_mapping_groups = size; /* ID1 */ id = readl_relaxed(gr0_base + ARM_SMMU_GR0_ID1); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 16:13:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 16:13:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100328.191098 (Exim 4.92) (envelope-from ) id 1lONAu-0002Dp-Aj; Mon, 22 Mar 2021 16:13:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100328.191098; Mon, 22 Mar 2021 16:13:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONAu-0002Di-7W; Mon, 22 Mar 2021 16:13:04 +0000 Received: by outflank-mailman (input) for mailman id 100328; Mon, 22 Mar 2021 16:13:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONAt-0002Db-1M for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 16:13:03 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 4b8f546e-4dcf-4c43-b689-0f5293e28e42; Mon, 22 Mar 2021 16:13:01 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2F0551042; Mon, 22 Mar 2021 09:13:01 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E0483F719; Mon, 22 Mar 2021 09:13:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b8f546e-4dcf-4c43-b689-0f5293e28e42 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2 2/5] xen/arm: smmuv1: Consolidate stream map entry state Date: Mon, 22 Mar 2021 16:11:36 +0000 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Backport commit 1f3d5ca43019bff1105838712d55be087d93c0da "iommu/arm-smmu: Consolidate stream map entry state" from the Linux kernel. This patch is the preparatory work to fix the stream match conflict when two devices have the same stream-id. Original commit message: iommu/arm-smmu: Consolidate stream map entry state In order to consider SMR masking, we really want to be able to validate ID/mask pairs against existing SMR contents to prevent stream match conflicts, which at best would cause transactions to fault unexpectedly, and at worst lead to silent unpredictable behaviour. With our SMMU instance data holding only an allocator bitmap, and the SMR values themselves scattered across master configs hanging off devices which we may have no way of finding, there's essentially no way short of digging everything back out of the hardware. Similarly, the thought of power management ops to support suspend/resume faces the exact same problem. By massaging the software state into a closer shape to the underlying hardware, everything comes together quite nicely; the allocator and the high-level view of the data become a single centralised state which we can easily keep track of, and to which any updates can be validated in full before being synchronised to the hardware itself. Signed-off-by: Robin Murphy Signed-off-by: Will Deacon Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini Reviewed-by: Bertrand Marquis --- xen/drivers/passthrough/arm/smmu.c | 138 +++++++++++++++++------------ 1 file changed, 79 insertions(+), 59 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index adfab8ee84..c41e94f836 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -308,9 +308,6 @@ static struct iommu_group *iommu_group_get(struct device *dev) /* Maximum number of context banks per SMMU */ #define ARM_SMMU_MAX_CBS 128 -/* Maximum number of mapping groups per SMMU */ -#define ARM_SMMU_MAX_SMRS 128 - /* SMMU global address space */ #define ARM_SMMU_GR0(smmu) ((smmu)->base) #define ARM_SMMU_GR1(smmu) ((smmu)->base + (1 << (smmu)->pgshift)) @@ -589,16 +586,17 @@ enum arm_smmu_arch_version { }; struct arm_smmu_smr { - u8 idx; u16 mask; u16 id; + bool valid; }; struct arm_smmu_master_cfg { int num_streamids; u16 streamids[MAX_MASTER_STREAMIDS]; - struct arm_smmu_smr *smrs; + s16 smendx[MAX_MASTER_STREAMIDS]; }; +#define INVALID_SMENDX -1 struct arm_smmu_master { struct device_node *of_node; @@ -632,7 +630,7 @@ struct arm_smmu_device { u32 num_mapping_groups; u16 streamid_mask; u16 smr_mask_mask; - DECLARE_BITMAP(smr_map, ARM_SMMU_MAX_SMRS); + struct arm_smmu_smr *smrs; unsigned long s1_input_size; unsigned long s1_output_size; @@ -818,6 +816,7 @@ static int register_smmu_master(struct arm_smmu_device *smmu, return -ERANGE; } master->cfg.streamids[i] = streamid; + master->cfg.smendx[i] = INVALID_SMENDX; } return insert_smmu_master(smmu, master); } @@ -1384,79 +1383,91 @@ static void arm_smmu_domain_destroy(struct iommu_domain *domain) kfree(smmu_domain); } -static int arm_smmu_master_configure_smrs(struct arm_smmu_device *smmu, - struct arm_smmu_master_cfg *cfg) +static int arm_smmu_alloc_smr(struct arm_smmu_device *smmu) { int i; - struct arm_smmu_smr *smrs; - void __iomem *gr0_base = ARM_SMMU_GR0(smmu); - if (!(smmu->features & ARM_SMMU_FEAT_STREAM_MATCH)) - return 0; + for (i = 0; i < smmu->num_mapping_groups; i++) + if (!cmpxchg(&smmu->smrs[i].valid, false, true)) + return i; - if (cfg->smrs) - return -EEXIST; + return INVALID_SMENDX; +} - smrs = kmalloc_array(cfg->num_streamids, sizeof(*smrs), GFP_KERNEL); - if (!smrs) { - dev_err(smmu->dev, "failed to allocate %d SMRs\n", - cfg->num_streamids); - return -ENOMEM; - } +static void arm_smmu_free_smr(struct arm_smmu_device *smmu, int idx) +{ + writel_relaxed(~SMR_VALID, ARM_SMMU_GR0(smmu) + ARM_SMMU_GR0_SMR(idx)); + write_atomic(&smmu->smrs[idx].valid, false); +} + +static void arm_smmu_write_smr(struct arm_smmu_device *smmu, int idx) +{ + struct arm_smmu_smr *smr = smmu->smrs + idx; + u32 reg = (smr->id & smmu->streamid_mask) << SMR_ID_SHIFT | + (smr->mask & smmu->smr_mask_mask) << SMR_MASK_SHIFT; + + if (smr->valid) + reg |= SMR_VALID; + writel_relaxed(reg, ARM_SMMU_GR0(smmu) + ARM_SMMU_GR0_SMR(idx)); +} + +static int arm_smmu_master_alloc_smes(struct arm_smmu_device *smmu, + struct arm_smmu_master_cfg *cfg) +{ + struct arm_smmu_smr *smrs = smmu->smrs; + int i, idx; /* Allocate the SMRs on the SMMU */ for (i = 0; i < cfg->num_streamids; ++i) { - int idx = __arm_smmu_alloc_bitmap(smmu->smr_map, 0, - smmu->num_mapping_groups); + if (cfg->smendx[i] != INVALID_SMENDX) + return -EEXIST; + + /* ...except on stream indexing hardware, of course */ + if (!smrs) { + cfg->smendx[i] = cfg->streamids[i]; + continue; + } + + idx = arm_smmu_alloc_smr(smmu); if (IS_ERR_VALUE(idx)) { dev_err(smmu->dev, "failed to allocate free SMR\n"); goto err_free_smrs; } + cfg->smendx[i] = idx; - smrs[i] = (struct arm_smmu_smr) { - .idx = idx, - .mask = 0, /* We don't currently share SMRs */ - .id = cfg->streamids[i], - }; + smrs[idx].id = cfg->streamids[i]; + smrs[idx].mask = 0; /* We don't currently share SMRs */ } + if (!smrs) + return 0; + /* It worked! Now, poke the actual hardware */ - for (i = 0; i < cfg->num_streamids; ++i) { - u32 reg = SMR_VALID | smrs[i].id << SMR_ID_SHIFT | - smrs[i].mask << SMR_MASK_SHIFT; - writel_relaxed(reg, gr0_base + ARM_SMMU_GR0_SMR(smrs[i].idx)); - } + for (i = 0; i < cfg->num_streamids; ++i) + arm_smmu_write_smr(smmu, cfg->smendx[i]); - cfg->smrs = smrs; return 0; err_free_smrs: - while (--i >= 0) - __arm_smmu_free_bitmap(smmu->smr_map, smrs[i].idx); - kfree(smrs); + while (i--) { + arm_smmu_free_smr(smmu, cfg->smendx[i]); + cfg->smendx[i] = INVALID_SMENDX; + } return -ENOSPC; } -static void arm_smmu_master_free_smrs(struct arm_smmu_device *smmu, +static void arm_smmu_master_free_smes(struct arm_smmu_device *smmu, struct arm_smmu_master_cfg *cfg) { int i; - void __iomem *gr0_base = ARM_SMMU_GR0(smmu); - struct arm_smmu_smr *smrs = cfg->smrs; - - if (!smrs) - return; /* Invalidate the SMRs before freeing back to the allocator */ for (i = 0; i < cfg->num_streamids; ++i) { - u8 idx = smrs[i].idx; + if (smmu->smrs) + arm_smmu_free_smr(smmu, cfg->smendx[i]); - writel_relaxed(~SMR_VALID, gr0_base + ARM_SMMU_GR0_SMR(idx)); - __arm_smmu_free_bitmap(smmu->smr_map, idx); + cfg->smendx[i] = INVALID_SMENDX; } - - cfg->smrs = NULL; - kfree(smrs); } static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain, @@ -1467,14 +1478,14 @@ static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain, void __iomem *gr0_base = ARM_SMMU_GR0(smmu); /* Devices in an IOMMU group may already be configured */ - ret = arm_smmu_master_configure_smrs(smmu, cfg); + ret = arm_smmu_master_alloc_smes(smmu, cfg); if (ret) return ret == -EEXIST ? 0 : ret; for (i = 0; i < cfg->num_streamids; ++i) { u32 idx, s2cr; - idx = cfg->smrs ? cfg->smrs[i].idx : cfg->streamids[i]; + idx = cfg->smendx[i]; s2cr = S2CR_TYPE_TRANS | (smmu_domain->cfg.cbndx << S2CR_CBNDX_SHIFT); writel_relaxed(s2cr, gr0_base + ARM_SMMU_GR0_S2CR(idx)); @@ -1490,23 +1501,23 @@ static void arm_smmu_domain_remove_master(struct arm_smmu_domain *smmu_domain, struct arm_smmu_device *smmu = smmu_domain->smmu; void __iomem *gr0_base = ARM_SMMU_GR0(smmu); - /* An IOMMU group is torn down by the first device to be removed */ - if ((smmu->features & ARM_SMMU_FEAT_STREAM_MATCH) && !cfg->smrs) - return; - /* * We *must* clear the S2CR first, because freeing the SMR means * that it can be re-allocated immediately. * Xen: Unlike Linux, any access to non-configured stream will fault. */ for (i = 0; i < cfg->num_streamids; ++i) { - u32 idx = cfg->smrs ? cfg->smrs[i].idx : cfg->streamids[i]; + int idx = cfg->smendx[i]; + + /* An IOMMU group is torn down by the first device to be removed */ + if (idx == INVALID_SMENDX) + return; writel_relaxed(S2CR_TYPE_FAULT, gr0_base + ARM_SMMU_GR0_S2CR(idx)); } - arm_smmu_master_free_smrs(smmu, cfg); + arm_smmu_master_free_smes(smmu, cfg); } static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) @@ -2017,16 +2028,20 @@ static void arm_smmu_device_reset(struct arm_smmu_device *smmu) { void __iomem *gr0_base = ARM_SMMU_GR0(smmu); void __iomem *cb_base; - int i = 0; + int i; u32 reg; /* clear global FSR */ reg = readl_relaxed(ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sGFSR); writel(reg, ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sGFSR); - /* Mark all SMRn as invalid and all S2CRn as bypass */ + /* + * Reset stream mapping groups: Initial values mark all SMRn as + * invalid and all S2CRn as bypass unless overridden. + */ for (i = 0; i < smmu->num_mapping_groups; ++i) { - writel_relaxed(0, gr0_base + ARM_SMMU_GR0_SMR(i)); + if (smmu->smrs) + arm_smmu_write_smr(smmu, i); /* * Xen: Unlike Linux, any access to a non-configure stream * will fault by default. @@ -2169,6 +2184,11 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu) smr = readl_relaxed(gr0_base + ARM_SMMU_GR0_SMR(0)); smmu->smr_mask_mask = smr >> SMR_MASK_SHIFT; + /* Zero-initialised to mark as invalid */ + smmu->smrs = devm_kzalloc(smmu->dev, sizeof(*smmu->smrs), GFP_KERNEL); + if (!smmu->smrs) + return -ENOMEM; + dev_notice(smmu->dev, "\tstream matching with %lu register groups, mask 0x%x", size, smmu->smr_mask_mask); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 16:13:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 16:13:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100330.191111 (Exim 4.92) (envelope-from ) id 1lONBH-0002K7-Kw; Mon, 22 Mar 2021 16:13:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100330.191111; Mon, 22 Mar 2021 16:13:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONBH-0002K0-H5; Mon, 22 Mar 2021 16:13:27 +0000 Received: by outflank-mailman (input) for mailman id 100330; Mon, 22 Mar 2021 16:13:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONBG-0002Jn-5Y for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 16:13:26 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 1404e66a-5069-4d81-84be-58c4b0b5d4ff; Mon, 22 Mar 2021 16:13:24 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 939AA1042; Mon, 22 Mar 2021 09:13:24 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AA7213F719; Mon, 22 Mar 2021 09:13:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1404e66a-5069-4d81-84be-58c4b0b5d4ff From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2 3/5] xen/arm: smmuv1: Keep track of S2CR state Date: Mon, 22 Mar 2021 16:11:37 +0000 Message-Id: <51b8e499135a733862d803e6c7aba63f5260b7f1.1616428314.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Backport commit 8e8b203eabd8b9e96d02d6339e4abce3e5a7ea4b "iommu/arm-smmu: Keep track of S2CR state" from the Linux kernel. This patch is the preparatory work to fix the stream match conflict when two devices have the same stream-id. Original commit message: iommu/arm-smmu: Keep track of S2CR state Making S2CRs first-class citizens within the driver with a high-level representation of their state offers a neat solution to a few problems: Firstly, the information about which context a device's stream IDs are associated with is already present by necessity in the S2CR. With that state easily accessible we can refer directly to it and obviate the need to track an IOMMU domain in each device's archdata (its earlier purpose of enforcing correct attachment of multi-device groups now being handled by the IOMMU core itself). Secondly, the core API now deprecates explicit domain detach and expects domain attach to move devices smoothly from one domain to another; for SMMUv2, this notion maps directly to simply rewriting the S2CRs assigned to the device. By giving the driver a suitable abstraction of those S2CRs to work with, we can massively reduce the overhead of the current heavy-handed "detach, free resources, reallocate resources, attach" approach. Thirdly, making the software state hardware-shaped and attached to the SMMU instance once again makes suspend/resume of this register group that much simpler to implement in future. Signed-off-by: Robin Murphy Signed-off-by: Will Deacon Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini Reviewed-by: Bertrand Marquis --- xen/drivers/passthrough/arm/smmu.c | 150 +++++++++++++++++------------ 1 file changed, 89 insertions(+), 61 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index c41e94f836..e1b937bd4b 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -444,9 +444,20 @@ static struct iommu_group *iommu_group_get(struct device *dev) #define S2CR_CBNDX_MASK 0xff #define S2CR_TYPE_SHIFT 16 #define S2CR_TYPE_MASK 0x3 -#define S2CR_TYPE_TRANS (0 << S2CR_TYPE_SHIFT) -#define S2CR_TYPE_BYPASS (1 << S2CR_TYPE_SHIFT) -#define S2CR_TYPE_FAULT (2 << S2CR_TYPE_SHIFT) +enum arm_smmu_s2cr_type { + S2CR_TYPE_TRANS, + S2CR_TYPE_BYPASS, + S2CR_TYPE_FAULT, +}; + +#define S2CR_PRIVCFG_SHIFT 24 +#define S2CR_PRIVCFG_MASK 0x3 +enum arm_smmu_s2cr_privcfg { + S2CR_PRIVCFG_DEFAULT, + S2CR_PRIVCFG_DIPAN, + S2CR_PRIVCFG_UNPRIV, + S2CR_PRIVCFG_PRIV, +}; /* Context bank attribute registers */ #define ARM_SMMU_GR1_CBAR(n) (0x0 + ((n) << 2)) @@ -585,6 +596,16 @@ enum arm_smmu_arch_version { ARM_SMMU_V2, }; +struct arm_smmu_s2cr { + enum arm_smmu_s2cr_type type; + enum arm_smmu_s2cr_privcfg privcfg; + u8 cbndx; +}; + +#define s2cr_init_val (struct arm_smmu_s2cr){ \ + .type = S2CR_TYPE_FAULT \ +} + struct arm_smmu_smr { u16 mask; u16 id; @@ -631,6 +652,7 @@ struct arm_smmu_device { u16 streamid_mask; u16 smr_mask_mask; struct arm_smmu_smr *smrs; + struct arm_smmu_s2cr *s2crs; unsigned long s1_input_size; unsigned long s1_output_size; @@ -1411,6 +1433,23 @@ static void arm_smmu_write_smr(struct arm_smmu_device *smmu, int idx) writel_relaxed(reg, ARM_SMMU_GR0(smmu) + ARM_SMMU_GR0_SMR(idx)); } +static void arm_smmu_write_s2cr(struct arm_smmu_device *smmu, int idx) +{ + struct arm_smmu_s2cr *s2cr = smmu->s2crs + idx; + u32 reg = (s2cr->type & S2CR_TYPE_MASK) << S2CR_TYPE_SHIFT | + (s2cr->cbndx & S2CR_CBNDX_MASK) << S2CR_CBNDX_SHIFT | + (s2cr->privcfg & S2CR_PRIVCFG_MASK) << S2CR_PRIVCFG_SHIFT; + + writel_relaxed(reg, ARM_SMMU_GR0(smmu) + ARM_SMMU_GR0_S2CR(idx)); +} + +static void arm_smmu_write_sme(struct arm_smmu_device *smmu, int idx) +{ + arm_smmu_write_s2cr(smmu, idx); + if (smmu->smrs) + arm_smmu_write_smr(smmu, idx); +} + static int arm_smmu_master_alloc_smes(struct arm_smmu_device *smmu, struct arm_smmu_master_cfg *cfg) { @@ -1461,6 +1500,23 @@ static void arm_smmu_master_free_smes(struct arm_smmu_device *smmu, { int i; + /* + * We *must* clear the S2CR first, because freeing the SMR means + * that it can be re-allocated immediately. + */ + for (i = 0; i < cfg->num_streamids; ++i) { + int idx = cfg->smendx[i]; + + /* An IOMMU group is torn down by the first device to be removed */ + if (idx == INVALID_SMENDX) + return; + + smmu->s2crs[idx] = s2cr_init_val; + arm_smmu_write_s2cr(smmu, idx); + } + /* Sync S2CR updates before touching anything else */ + __iowmb(); + /* Invalidate the SMRs before freeing back to the allocator */ for (i = 0; i < cfg->num_streamids; ++i) { if (smmu->smrs) @@ -1473,51 +1529,30 @@ static void arm_smmu_master_free_smes(struct arm_smmu_device *smmu, static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain, struct arm_smmu_master_cfg *cfg) { - int i, ret; + int i, ret = 0; struct arm_smmu_device *smmu = smmu_domain->smmu; - void __iomem *gr0_base = ARM_SMMU_GR0(smmu); + struct arm_smmu_s2cr *s2cr = smmu->s2crs; + enum arm_smmu_s2cr_type type = S2CR_TYPE_TRANS; + u8 cbndx = smmu_domain->cfg.cbndx; - /* Devices in an IOMMU group may already be configured */ - ret = arm_smmu_master_alloc_smes(smmu, cfg); + if (cfg->smendx[0] == INVALID_SMENDX) + ret = arm_smmu_master_alloc_smes(smmu, cfg); if (ret) - return ret == -EEXIST ? 0 : ret; - - for (i = 0; i < cfg->num_streamids; ++i) { - u32 idx, s2cr; - - idx = cfg->smendx[i]; - s2cr = S2CR_TYPE_TRANS | - (smmu_domain->cfg.cbndx << S2CR_CBNDX_SHIFT); - writel_relaxed(s2cr, gr0_base + ARM_SMMU_GR0_S2CR(idx)); - } - - return 0; -} - -static void arm_smmu_domain_remove_master(struct arm_smmu_domain *smmu_domain, - struct arm_smmu_master_cfg *cfg) -{ - int i; - struct arm_smmu_device *smmu = smmu_domain->smmu; - void __iomem *gr0_base = ARM_SMMU_GR0(smmu); + return ret; - /* - * We *must* clear the S2CR first, because freeing the SMR means - * that it can be re-allocated immediately. - * Xen: Unlike Linux, any access to non-configured stream will fault. - */ for (i = 0; i < cfg->num_streamids; ++i) { int idx = cfg->smendx[i]; - /* An IOMMU group is torn down by the first device to be removed */ - if (idx == INVALID_SMENDX) - return; + /* Devices in an IOMMU group may already be configured */ + if (type == s2cr[idx].type && cbndx == s2cr[idx].cbndx) + break; - writel_relaxed(S2CR_TYPE_FAULT, - gr0_base + ARM_SMMU_GR0_S2CR(idx)); + s2cr[idx].type = type ; + s2cr[idx].privcfg = S2CR_PRIVCFG_UNPRIV; + s2cr[idx].cbndx = cbndx; + arm_smmu_write_s2cr(smmu, idx); } - - arm_smmu_master_free_smes(smmu, cfg); + return 0; } static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) @@ -1564,24 +1599,17 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) if (!cfg) return -ENODEV; - ret = arm_smmu_domain_add_master(smmu_domain, cfg); - - if (!ret) - dev_iommu_domain(dev) = domain; - return ret; + return arm_smmu_domain_add_master(smmu_domain, cfg); } static void arm_smmu_detach_dev(struct iommu_domain *domain, struct device *dev) { - struct arm_smmu_domain *smmu_domain = domain->priv; - struct arm_smmu_master_cfg *cfg; + struct arm_smmu_device *smmu = find_smmu_for_device(dev); + struct arm_smmu_master_cfg *cfg = find_smmu_master_cfg(dev); - cfg = find_smmu_master_cfg(dev); - if (!cfg) - return; + if (smmu && cfg) + arm_smmu_master_free_smes(smmu, cfg); - dev_iommu_domain(dev) = NULL; - arm_smmu_domain_remove_master(smmu_domain, cfg); } #if 0 /* @@ -2039,16 +2067,8 @@ static void arm_smmu_device_reset(struct arm_smmu_device *smmu) * Reset stream mapping groups: Initial values mark all SMRn as * invalid and all S2CRn as bypass unless overridden. */ - for (i = 0; i < smmu->num_mapping_groups; ++i) { - if (smmu->smrs) - arm_smmu_write_smr(smmu, i); - /* - * Xen: Unlike Linux, any access to a non-configure stream - * will fault by default. - */ - writel_relaxed(S2CR_TYPE_FAULT, - gr0_base + ARM_SMMU_GR0_S2CR(i)); - } + for (i = 0; i < smmu->num_mapping_groups; ++i) + arm_smmu_write_sme(smmu, i); /* Make sure all context banks are disabled and clear CB_FSR */ for (i = 0; i < smmu->num_context_banks; ++i) { @@ -2110,6 +2130,7 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu) unsigned long size; void __iomem *gr0_base = ARM_SMMU_GR0(smmu); u32 id; + int i; dev_notice(smmu->dev, "probing hardware configuration...\n"); dev_notice(smmu->dev, "SMMUv%d with:\n", smmu->version); @@ -2193,6 +2214,13 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu) "\tstream matching with %lu register groups, mask 0x%x", size, smmu->smr_mask_mask); } + /* s2cr->type == 0 means translation, so initialise explicitly */ + smmu->s2crs = kmalloc_array(size, sizeof(*smmu->s2crs), GFP_KERNEL); + if (!smmu->s2crs) + return -ENOMEM; + for (i = 0; i < size; i++) + smmu->s2crs[i] = s2cr_init_val; + smmu->num_mapping_groups = size; /* ID1 */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 16:14:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 16:14:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100340.191123 (Exim 4.92) (envelope-from ) id 1lONC9-0002TJ-Vr; Mon, 22 Mar 2021 16:14:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100340.191123; Mon, 22 Mar 2021 16:14:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONC9-0002TC-SP; Mon, 22 Mar 2021 16:14:21 +0000 Received: by outflank-mailman (input) for mailman id 100340; Mon, 22 Mar 2021 16:14:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONC8-0002T0-OZ for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 16:14:20 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 39779ff6-3add-4511-85a4-8d84bfeba642; Mon, 22 Mar 2021 16:14:19 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2168D1042; Mon, 22 Mar 2021 09:14:19 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3986D3F719; Mon, 22 Mar 2021 09:14:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39779ff6-3add-4511-85a4-8d84bfeba642 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2 4/5] xen/arm: smmuv1: Add a stream map entry iterator Date: Mon, 22 Mar 2021 16:11:38 +0000 Message-Id: <662c4a4872e471df1d185002988700cd738080a0.1616428314.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Backport commit d3097e39302083d58922a3d1032d7d59a63d263d "iommu/arm-smmu: Add a stream map entry iterator" from the Linux kernel. This patch is the preparatory work to fix the stream match conflict when two devices have the same stream-id. Original commit message: iommu/arm-smmu: Add a stream map entry iterator We iterate over the SMEs associated with a master config quite a lot in various places, and are about to do so even more. Let's wrap the idiom in a handy iterator macro before the repetition gets out of hand. Tested-by: Lorenzo Pieralisi Signed-off-by: Robin Murphy Signed-off-by: Will Deacon Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini Reviewed-by: Bertrand Marquis --- xen/drivers/passthrough/arm/smmu.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index e1b937bd4b..2c1ea8e6ff 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -618,6 +618,8 @@ struct arm_smmu_master_cfg { s16 smendx[MAX_MASTER_STREAMIDS]; }; #define INVALID_SMENDX -1 +#define for_each_cfg_sme(cfg, i, idx) \ + for (i = 0; idx = cfg->smendx[i], i < cfg->num_streamids; ++i) struct arm_smmu_master { struct device_node *of_node; @@ -1457,8 +1459,8 @@ static int arm_smmu_master_alloc_smes(struct arm_smmu_device *smmu, int i, idx; /* Allocate the SMRs on the SMMU */ - for (i = 0; i < cfg->num_streamids; ++i) { - if (cfg->smendx[i] != INVALID_SMENDX) + for_each_cfg_sme(cfg, i, idx) { + if (idx != INVALID_SMENDX) return -EEXIST; /* ...except on stream indexing hardware, of course */ @@ -1482,8 +1484,8 @@ static int arm_smmu_master_alloc_smes(struct arm_smmu_device *smmu, return 0; /* It worked! Now, poke the actual hardware */ - for (i = 0; i < cfg->num_streamids; ++i) - arm_smmu_write_smr(smmu, cfg->smendx[i]); + for_each_cfg_sme(cfg, i, idx) + arm_smmu_write_smr(smmu, idx); return 0; @@ -1498,15 +1500,13 @@ err_free_smrs: static void arm_smmu_master_free_smes(struct arm_smmu_device *smmu, struct arm_smmu_master_cfg *cfg) { - int i; + int i, idx; /* * We *must* clear the S2CR first, because freeing the SMR means * that it can be re-allocated immediately. */ - for (i = 0; i < cfg->num_streamids; ++i) { - int idx = cfg->smendx[i]; - + for_each_cfg_sme(cfg, i, idx) { /* An IOMMU group is torn down by the first device to be removed */ if (idx == INVALID_SMENDX) return; @@ -1518,9 +1518,9 @@ static void arm_smmu_master_free_smes(struct arm_smmu_device *smmu, __iowmb(); /* Invalidate the SMRs before freeing back to the allocator */ - for (i = 0; i < cfg->num_streamids; ++i) { + for_each_cfg_sme(cfg, i, idx) { if (smmu->smrs) - arm_smmu_free_smr(smmu, cfg->smendx[i]); + arm_smmu_free_smr(smmu, idx); cfg->smendx[i] = INVALID_SMENDX; } @@ -1529,7 +1529,7 @@ static void arm_smmu_master_free_smes(struct arm_smmu_device *smmu, static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain, struct arm_smmu_master_cfg *cfg) { - int i, ret = 0; + int i, idx, ret = 0; struct arm_smmu_device *smmu = smmu_domain->smmu; struct arm_smmu_s2cr *s2cr = smmu->s2crs; enum arm_smmu_s2cr_type type = S2CR_TYPE_TRANS; @@ -1540,9 +1540,7 @@ static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain, if (ret) return ret; - for (i = 0; i < cfg->num_streamids; ++i) { - int idx = cfg->smendx[i]; - + for_each_cfg_sme(cfg, i, idx) { /* Devices in an IOMMU group may already be configured */ if (type == s2cr[idx].type && cbndx == s2cr[idx].cbndx) break; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 16:14:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 16:14:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100341.191135 (Exim 4.92) (envelope-from ) id 1lONCC-0002V9-7m; Mon, 22 Mar 2021 16:14:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100341.191135; Mon, 22 Mar 2021 16:14:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONCC-0002V1-4A; Mon, 22 Mar 2021 16:14:24 +0000 Received: by outflank-mailman (input) for mailman id 100341; Mon, 22 Mar 2021 16:14:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONCA-0002US-Sw for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 16:14:22 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 0c1d9c19-5ffc-4d73-8821-6a0a5fb3455a; Mon, 22 Mar 2021 16:14:22 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E43071042; Mon, 22 Mar 2021 09:14:21 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F3E493F719; Mon, 22 Mar 2021 09:14:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c1d9c19-5ffc-4d73-8821-6a0a5fb3455a From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2 5/5] xen/arm: smmuv1: Intelligent SMR allocation Date: Mon, 22 Mar 2021 16:11:39 +0000 Message-Id: <48ce5f4e4558cbbc3b09431e2a0dcf6f3c594fca.1616428314.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Backport 588888a7399db352d2b1a41c9d5b3bf0fd482390 "iommu/arm-smmu: Intelligent SMR allocation" from the Linux kernel This patch fix the stream match conflict issue when two devices have the same stream-id. Only difference while applying this patch with regard to Linux patch are as follows: 1. Spinlock is used in place of mutex when attaching a device to the SMMU via arm_smmu_master_alloc_smes(..) function call.Replacing the mutex with spinlock is fine here as we are configuring the hardware via registers and it is very fast. 2. move iommu_group_alloc(..) function call in arm_smmu_add_device(..) function from the start of the function to the end. Original commit message: iommu/arm-smmu: Intelligent SMR allocation Stream Match Registers are one of the more awkward parts of the SMMUv2 architecture; there are typically never enough to assign one to each stream ID in the system, and configuring them such that a single ID matches multiple entries is catastrophically bad - at best, every transaction raises a global fault; at worst, they go *somewhere*. To address the former issue, we can mask ID bits such that a single register may be used to match multiple IDs belonging to the same device or group, but doing so also heightens the risk of the latter problem (which can be nasty to debug). Tackle both problems at once by replacing the simple bitmap allocator with something much cleverer. Now that we have convenient in-memory representations of the stream mapping table, it becomes straightforward to properly validate new SMR entries against the current state, opening the door to arbitrary masking and SMR sharing. Another feature which falls out of this is that with IDs shared by separate devices being automatically accounted for, simply associating a group pointer with the S2CR offers appropriate group allocation almost for free, so hook that up in the process. Signed-off-by: Robin Murphy Signed-off-by: Will Deacon Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini Reviewed-by: Bertrand Marquis --- xen/drivers/passthrough/arm/smmu.c | 230 ++++++++++++++++++----------- 1 file changed, 142 insertions(+), 88 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 2c1ea8e6ff..20ac672e91 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -597,6 +597,8 @@ enum arm_smmu_arch_version { }; struct arm_smmu_s2cr { + struct iommu_group *group; + int count; enum arm_smmu_s2cr_type type; enum arm_smmu_s2cr_privcfg privcfg; u8 cbndx; @@ -613,6 +615,7 @@ struct arm_smmu_smr { }; struct arm_smmu_master_cfg { + struct arm_smmu_device *smmu; int num_streamids; u16 streamids[MAX_MASTER_STREAMIDS]; s16 smendx[MAX_MASTER_STREAMIDS]; @@ -655,6 +658,7 @@ struct arm_smmu_device { u16 smr_mask_mask; struct arm_smmu_smr *smrs; struct arm_smmu_s2cr *s2crs; + spinlock_t stream_map_lock; unsigned long s1_input_size; unsigned long s1_output_size; @@ -1407,23 +1411,6 @@ static void arm_smmu_domain_destroy(struct iommu_domain *domain) kfree(smmu_domain); } -static int arm_smmu_alloc_smr(struct arm_smmu_device *smmu) -{ - int i; - - for (i = 0; i < smmu->num_mapping_groups; i++) - if (!cmpxchg(&smmu->smrs[i].valid, false, true)) - return i; - - return INVALID_SMENDX; -} - -static void arm_smmu_free_smr(struct arm_smmu_device *smmu, int idx) -{ - writel_relaxed(~SMR_VALID, ARM_SMMU_GR0(smmu) + ARM_SMMU_GR0_SMR(idx)); - write_atomic(&smmu->smrs[idx].valid, false); -} - static void arm_smmu_write_smr(struct arm_smmu_device *smmu, int idx) { struct arm_smmu_smr *smr = smmu->smrs + idx; @@ -1452,98 +1439,143 @@ static void arm_smmu_write_sme(struct arm_smmu_device *smmu, int idx) arm_smmu_write_smr(smmu, idx); } -static int arm_smmu_master_alloc_smes(struct arm_smmu_device *smmu, - struct arm_smmu_master_cfg *cfg) +static int arm_smmu_find_sme(struct arm_smmu_device *smmu, u16 id, u16 mask) { struct arm_smmu_smr *smrs = smmu->smrs; - int i, idx; + int i, free_idx = -ENOSPC; - /* Allocate the SMRs on the SMMU */ - for_each_cfg_sme(cfg, i, idx) { - if (idx != INVALID_SMENDX) - return -EEXIST; + /* Stream indexing is blissfully easy */ + if (!smrs) + return id; - /* ...except on stream indexing hardware, of course */ - if (!smrs) { - cfg->smendx[i] = cfg->streamids[i]; + /* Validating SMRs is... less so */ + for (i = 0; i < smmu->num_mapping_groups; ++i) { + if (!smrs[i].valid) { + /* + * Note the first free entry we come across, which + * we'll claim in the end if nothing else matches. + */ + if (free_idx < 0) + free_idx = i; continue; } + /* + * If the new entry is _entirely_ matched by an existing entry, + * then reuse that, with the guarantee that there also cannot + * be any subsequent conflicting entries. In normal use we'd + * expect simply identical entries for this case, but there's + * no harm in accommodating the generalisation. + */ + if ((mask & smrs[i].mask) == mask && + !((id ^ smrs[i].id) & ~smrs[i].mask)) + return i; + /* + * If the new entry has any other overlap with an existing one, + * though, then there always exists at least one stream ID + * which would cause a conflict, and we can't allow that risk. + */ + if (!((id ^ smrs[i].id) & ~(smrs[i].mask | mask))) + return -EINVAL; + } - idx = arm_smmu_alloc_smr(smmu); - if (IS_ERR_VALUE(idx)) { - dev_err(smmu->dev, "failed to allocate free SMR\n"); - goto err_free_smrs; + return free_idx; +} + +static bool arm_smmu_free_sme(struct arm_smmu_device *smmu, int idx) +{ + if (--smmu->s2crs[idx].count) + return false; + + smmu->s2crs[idx] = s2cr_init_val; + if (smmu->smrs) + smmu->smrs[idx].valid = false; + + return true; +} + +static int arm_smmu_master_alloc_smes(struct device *dev) +{ + struct arm_smmu_master_cfg *cfg = find_smmu_master_cfg(dev); + struct arm_smmu_device *smmu = cfg->smmu; + struct arm_smmu_smr *smrs = smmu->smrs; + struct iommu_group *group; + int i, idx, ret; + + spin_lock(&smmu->stream_map_lock); + /* Figure out a viable stream map entry allocation */ + for_each_cfg_sme(cfg, i, idx) { + if (idx != INVALID_SMENDX) { + ret = -EEXIST; + goto out_err; } - cfg->smendx[i] = idx; - smrs[idx].id = cfg->streamids[i]; - smrs[idx].mask = 0; /* We don't currently share SMRs */ + ret = arm_smmu_find_sme(smmu, cfg->streamids[i], 0); + if (ret < 0) + goto out_err; + + idx = ret; + if (smrs && smmu->s2crs[idx].count == 0) { + smrs[idx].id = cfg->streamids[i]; + smrs[idx].mask = 0; /* We don't currently share SMRs */ + smrs[idx].valid = true; + } + smmu->s2crs[idx].count++; + cfg->smendx[i] = (s16)idx; } - if (!smrs) - return 0; + group = iommu_group_get(dev); + if (!group) + group = ERR_PTR(-ENOMEM); + if (IS_ERR(group)) { + ret = PTR_ERR(group); + goto out_err; + } + iommu_group_put(group); /* It worked! Now, poke the actual hardware */ - for_each_cfg_sme(cfg, i, idx) - arm_smmu_write_smr(smmu, idx); + for_each_cfg_sme(cfg, i, idx) { + arm_smmu_write_sme(smmu, idx); + smmu->s2crs[idx].group = group; + } + spin_unlock(&smmu->stream_map_lock); return 0; -err_free_smrs: +out_err: while (i--) { - arm_smmu_free_smr(smmu, cfg->smendx[i]); + arm_smmu_free_sme(smmu, cfg->smendx[i]); cfg->smendx[i] = INVALID_SMENDX; } - return -ENOSPC; + spin_unlock(&smmu->stream_map_lock); + return ret; } -static void arm_smmu_master_free_smes(struct arm_smmu_device *smmu, - struct arm_smmu_master_cfg *cfg) +static void arm_smmu_master_free_smes(struct arm_smmu_master_cfg *cfg) { + struct arm_smmu_device *smmu = cfg->smmu; int i, idx; - /* - * We *must* clear the S2CR first, because freeing the SMR means - * that it can be re-allocated immediately. - */ + spin_lock(&smmu->stream_map_lock); for_each_cfg_sme(cfg, i, idx) { - /* An IOMMU group is torn down by the first device to be removed */ - if (idx == INVALID_SMENDX) - return; - - smmu->s2crs[idx] = s2cr_init_val; - arm_smmu_write_s2cr(smmu, idx); - } - /* Sync S2CR updates before touching anything else */ - __iowmb(); - - /* Invalidate the SMRs before freeing back to the allocator */ - for_each_cfg_sme(cfg, i, idx) { - if (smmu->smrs) - arm_smmu_free_smr(smmu, idx); - + if (arm_smmu_free_sme(smmu, idx)) + arm_smmu_write_sme(smmu, idx); cfg->smendx[i] = INVALID_SMENDX; } + spin_unlock(&smmu->stream_map_lock); } static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain, struct arm_smmu_master_cfg *cfg) { - int i, idx, ret = 0; struct arm_smmu_device *smmu = smmu_domain->smmu; struct arm_smmu_s2cr *s2cr = smmu->s2crs; enum arm_smmu_s2cr_type type = S2CR_TYPE_TRANS; u8 cbndx = smmu_domain->cfg.cbndx; - - if (cfg->smendx[0] == INVALID_SMENDX) - ret = arm_smmu_master_alloc_smes(smmu, cfg); - if (ret) - return ret; + int i, idx; for_each_cfg_sme(cfg, i, idx) { - /* Devices in an IOMMU group may already be configured */ if (type == s2cr[idx].type && cbndx == s2cr[idx].cbndx) - break; + continue; s2cr[idx].type = type ; s2cr[idx].privcfg = S2CR_PRIVCFG_UNPRIV; @@ -1602,11 +1634,10 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) static void arm_smmu_detach_dev(struct iommu_domain *domain, struct device *dev) { - struct arm_smmu_device *smmu = find_smmu_for_device(dev); struct arm_smmu_master_cfg *cfg = find_smmu_master_cfg(dev); - if (smmu && cfg) - arm_smmu_master_free_smes(smmu, cfg); + if (cfg) + arm_smmu_master_free_smes(cfg); } @@ -1935,31 +1966,44 @@ static void __arm_smmu_release_pci_iommudata(void *data) kfree(data); } +static struct iommu_group *arm_smmu_device_group(struct + arm_smmu_master_cfg *cfg) +{ + struct arm_smmu_device *smmu = cfg->smmu; + struct iommu_group *group = NULL; + int i, idx; + + for_each_cfg_sme(cfg, i, idx) { + if (group && smmu->s2crs[idx].group && + group != smmu->s2crs[idx].group) + return ERR_PTR(-EINVAL); + + group = smmu->s2crs[idx].group; + } + + if (group) + return group; + + return NULL; +} + static int arm_smmu_add_device(struct device *dev) { struct arm_smmu_device *smmu; struct arm_smmu_master_cfg *cfg; struct iommu_group *group; void (*releasefn)(void *) = NULL; - int ret; smmu = find_smmu_for_device(dev); if (!smmu) return -ENODEV; - group = iommu_group_alloc(); - if (IS_ERR(group)) { - dev_err(dev, "Failed to allocate IOMMU group\n"); - return PTR_ERR(group); - } - if (dev_is_pci(dev)) { struct pci_dev *pdev = to_pci_dev(dev); cfg = kzalloc(sizeof(*cfg), GFP_KERNEL); if (!cfg) { - ret = -ENOMEM; - goto out_put_group; + return -ENOMEM; } cfg->num_streamids = 1; @@ -1970,24 +2014,33 @@ static int arm_smmu_add_device(struct device *dev) pci_for_each_dma_alias(pdev, __arm_smmu_get_pci_sid, &cfg->streamids[0]); releasefn = __arm_smmu_release_pci_iommudata; + cfg->smmu = smmu; } else { struct arm_smmu_master *master; master = find_smmu_master(smmu, dev->of_node); if (!master) { - ret = -ENODEV; - goto out_put_group; + return -ENODEV; } cfg = &master->cfg; + cfg->smmu = smmu; } - iommu_group_set_iommudata(group, cfg, releasefn); - ret = iommu_group_add_device(group, dev); + group = arm_smmu_device_group(cfg); + if (!group) { + group = iommu_group_alloc(); + if (IS_ERR(group)) { + dev_err(dev, "Failed to allocate IOMMU group\n"); + return PTR_ERR(group); + } + } -out_put_group: + iommu_group_set_iommudata(group, cfg, releasefn); + iommu_group_add_device(group, dev); iommu_group_put(group); - return ret; + + return arm_smmu_master_alloc_smes(dev); } #if 0 /* Xen: We don't support remove device for now. Will be useful for PCI */ @@ -2220,6 +2273,7 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu) smmu->s2crs[i] = s2cr_init_val; smmu->num_mapping_groups = size; + spin_lock_init(&smmu->stream_map_lock); /* ID1 */ id = readl_relaxed(gr0_base + ARM_SMMU_GR0_ID1); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 16:20:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 16:20:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100356.191149 (Exim 4.92) (envelope-from ) id 1lONI3-0003bw-5I; Mon, 22 Mar 2021 16:20:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100356.191149; Mon, 22 Mar 2021 16:20:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONI3-0003bp-2O; Mon, 22 Mar 2021 16:20:27 +0000 Received: by outflank-mailman (input) for mailman id 100356; Mon, 22 Mar 2021 16:20:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONI1-0003bU-58 for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 16:20:25 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 867f9026-ca93-46a5-8636-ebb2ce9ba8f2; Mon, 22 Mar 2021 16:20:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 867f9026-ca93-46a5-8636-ebb2ce9ba8f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616430023; h=from:to:cc:subject:date:message-id:mime-version; bh=y/VrRIkRtCsbqXMRtQyZrTrERhDdgdKiJmxLk/MkOGs=; b=BANFuIBS5RUNTOuT2yNyVgOXADS9xqOpGANYwN2Fkcd8pb5miC37ClUy amJFfpbrZq0HWdX+xyCvVnlxLV7azkMG1sShadYMRT2cTQzIH7dJ+PCjR TlY+NMjcwvhMbpOJ2uG9Qe74cF7IMXn9LaQvf5PNwKS1ULV9pDshInUej U=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 2pLE+HFpiq1q2zd/dDqAWPiz/i2B0PmBiJSxieKwE2w/OIVm9cfdYWhfxQCXjcHyh+FyaZi8Hw idMTdKNA8wfLxLhU23Vo45rrbl3LHNFHf4rZOFv0ignK7LcCpeaUldbtpol2gzfy16VoVKDVoy 0oDB7BpDvvV60aQ4XKn1UaKRZxWZzg7FI1MJhOtwO9ld9t/pkydUiXs5TiPqivC1eQSmQ7LmHJ KplKonf0fttAPPN2OtaW9OnypubLtjdfeu7UEbueHbUbie9LUoFwimxfB2xdKTnqgxZ9LE1m0u BDA= X-SBRS: 5.1 X-MesageID: 39823330 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:PeERgqtcZx5B7hNHSDlXjOpg7skC54Yji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOjLU5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Q26Y 5JSII7MtH5CDFB5vrSyAOzH888hPyO9661jenTpk0dNT1CQadm8gt/F0K/Gkp5WAFJCfMCZe Ghz+BAoCetfmlSU9SjChA+LqP+jvDotLajWx4JABY79BKD5AnF1JfWGwWVty1uNw9n7qwl9Q H+8jDRxqLmiP2jzw+Z6mm71eUupPLE6v9uQPOBkdIULDKEsHfjWK1EV6eZtD445MGDgWxa9+ XkmBsrM8Rt5365RAjcznXQ8jLt3zo053jpxUXwuwqEneXCWDk4B8Bd7LgpESfx1ks6sNlwlI JN0m6J3qAnaC/ooSXn69DEEyxtj0q/yEBS89I7sno3a+sjQY4UibZa0FJeEZ8GEi6/wpsgCv NSAMbV4+sTWU+GbljC11MfjOCEbzAWJFOrU0ICssua33x9h3Zi1XYVw8QZgzMp6I89cZ9Z/O 7JW54Y241mf4szV+ZQFe0BScy4BijmWhTXKl+fJlzhCeUhN2/SrYX0pJE4/vujdpBN7JZaou WObHpo8UoJP27+A8yH25NGtjrXRn+mYDjrwsZCo5djvLnxQ6fqLD2DRFgin9DImYRePuTrH9 KIfL5GCf7qKmXjXaxT2RflZpVUIX4CFM0Z0+xLGG6mk4buEMnHp+bbePHcKP7GCjA/QF7yBX MFQXz2LMVE5Ua7R2/gjHHqKjHQU3262ag1PLnR/uAVxoRIHJZLqBIphVOw4dzOLyZDvKwwdE 53O6jmjau/uGmz8Q/zniRUEysYKnwQzKTrUntMqwNPGVjza6w/t9KWfn0XwGGKPQZlT8TdEB dWolN+/a7fFe3U+QkST/acdk6KhXoao3yHC6oGkqqY/MH/Z9cTFZA9QpF8Eg3NCj14kQtns3 14dQcBX0PTfwmezZmNvdgxPqX/f8M5qBq3KcRUwEivz3m0lIUKfD8neBKAFeSQmh0jQjJIgE YZyd5jvJOw3RC1KWU+h+wkNkZrc2r/OsMKMC2MeJhUlrf3eAt5UGeNgniAhwsuf3fxnn9i+l DJPGmaf+rGDUFavW0d2qH28ElsfmHYZE5obGtm2LcNXFjuqzJ20eWRYLC03HbUYlwewvsFOD WtW0pkHip+g9S23gWSgjCMCDEvwYgvJPXUCPAmf6vI0n2gbI2OmqduJY4jwL91cNTvuPQMS+ SRZkucKy75Efog30iNvWk+URME2kUMgLftwlno/WK41HkwDb7bJ0lnXagSJ5WZ43L/T/iF3Z 1lhbsOzKONG3S0bsTDxbDcbjZFJB+Wu2KwQu0yoZ1fvK45ttJIbu3meCqN0GsC0AQ1Lc/ymk 9bXb9y56rZPJRzO8MVYCBU8zMS5aeyBVputhazBOAwfVsg1SCGe9yI5qfFsropDAmKohDqNV yW7i1a+LPEUkK4pM8nIrN1JX4Tbk42rGlm9qeFcYbbDQ2xbeFN/FagKBaGAcpgYbnAHa9Vtw pw5tGDgvSeeCX50h3BpDcTGNMxz0+3BcepRB+WEeFG89amKU2Bj6uj7sm0lir2Q1KAGjQlrJ wAc1cRYMRFgiQji4Ny0jHacN2Jnn4Y X-IronPort-AV: E=Sophos;i="5.81,269,1610427600"; d="scan'208";a="39823330" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Ian Jackson , Wei Liu , Juergen Gross , Jan Beulich Subject: [PATCH for-4.14] tools: Fix pkg-config file for libxenstore Date: Mon, 22 Mar 2021 16:20:13 +0000 Message-ID: <20210322162013.12639-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain There is no dependency on libxenctrl. Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore") Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Juergen Gross CC: Jan Beulich This has been fixed in Xen 4.15 by the uselibs.mk logic, but 4.14 and older cause everything linking against libxenstore to also try linking against libxenctrl. It also causes RPM to create unexpected dependencies between subpackages, which is a problem when trying to separate the stable and unstable libs. --- tools/xenstore/xenstore.pc.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstore/xenstore.pc.in b/tools/xenstore/xenstore.pc.in index 2f64a6b824..98c3f1ab39 100644 --- a/tools/xenstore/xenstore.pc.in +++ b/tools/xenstore/xenstore.pc.in @@ -8,4 +8,4 @@ Version: @@version@@ Cflags: -I${includedir} @@cflagslocal@@ Libs: @@libsflag@@${libdir} -lxenstore Libs.private: -ldl -Requires.private: xenevtchn,xencontrol,xengnttab,xentoolcore +Requires.private: xenevtchn,xengnttab,xentoolcore -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 16:33:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 16:33:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100368.191172 (Exim 4.92) (envelope-from ) id 1lONTz-0004io-Al; Mon, 22 Mar 2021 16:32:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100368.191172; Mon, 22 Mar 2021 16:32:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONTz-0004ih-7V; Mon, 22 Mar 2021 16:32:47 +0000 Received: by outflank-mailman (input) for mailman id 100368; Mon, 22 Mar 2021 16:32:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONTy-0004ic-90 for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 16:32:46 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bfdf7647-56ba-4a11-8f82-598cf8c4f097; Mon, 22 Mar 2021 16:32:44 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 066F4AF0D; Mon, 22 Mar 2021 16:32:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bfdf7647-56ba-4a11-8f82-598cf8c4f097 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616430764; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aFOmkKDTv73qJ2yeITDcJ++vFdsMJeUyOGgBj87j1Vc=; b=G/mQlMeM56EPan/CGKZp4Tfimvj23JJtz2047nZevf29kbi5ykUYbj8ia1cK+c6zMK5bKt qSunmZnzGgueQodQ9mhe0mgiItttmsHwJOWAJHu/QdaGvqDE6KEEOMMNv45S0e5lU++EuZ v77fWECMIj0X/yzktx9xAf/aq+nVCb8= Subject: Re: [PATCH for-4.14] tools: Fix pkg-config file for libxenstore To: Andrew Cooper , Xen-devel Cc: Ian Jackson , Wei Liu , Jan Beulich References: <20210322162013.12639-1-andrew.cooper3@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <0a006343-4d2c-acd7-d2ce-abd04220e0de@suse.com> Date: Mon, 22 Mar 2021 17:32:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210322162013.12639-1-andrew.cooper3@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2bmbxXVaXr22Ps88AGM8Pb2xFxf7SRExT" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2bmbxXVaXr22Ps88AGM8Pb2xFxf7SRExT Content-Type: multipart/mixed; boundary="Fu28pdw7D7dlcS4cf9xLP4rFA07CqfuNe"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Andrew Cooper , Xen-devel Cc: Ian Jackson , Wei Liu , Jan Beulich Message-ID: <0a006343-4d2c-acd7-d2ce-abd04220e0de@suse.com> Subject: Re: [PATCH for-4.14] tools: Fix pkg-config file for libxenstore References: <20210322162013.12639-1-andrew.cooper3@citrix.com> In-Reply-To: <20210322162013.12639-1-andrew.cooper3@citrix.com> --Fu28pdw7D7dlcS4cf9xLP4rFA07CqfuNe Content-Type: multipart/mixed; boundary="------------BFACF1303978B6FFDEB638B5" Content-Language: en-US This is a multi-part message in MIME format. --------------BFACF1303978B6FFDEB638B5 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 22.03.21 17:20, Andrew Cooper wrote: > There is no dependency on libxenctrl. >=20 > Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore") > Signed-off-by: Andrew Cooper > --- > CC: Ian Jackson > CC: Wei Liu > CC: Juergen Gross > CC: Jan Beulich >=20 > This has been fixed in Xen 4.15 by the uselibs.mk logic, but 4.14 and o= lder > cause everything linking against libxenstore to also try linking agains= t > libxenctrl. It also causes RPM to create unexpected dependencies betwe= en > subpackages, which is a problem when trying to separate the stable and > unstable libs. > --- > tools/xenstore/xenstore.pc.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tools/xenstore/xenstore.pc.in b/tools/xenstore/xenstore.pc= =2Ein > index 2f64a6b824..98c3f1ab39 100644 > --- a/tools/xenstore/xenstore.pc.in > +++ b/tools/xenstore/xenstore.pc.in > @@ -8,4 +8,4 @@ Version: @@version@@ > Cflags: -I${includedir} @@cflagslocal@@ > Libs: @@libsflag@@${libdir} -lxenstore > Libs.private: -ldl > -Requires.private: xenevtchn,xencontrol,xengnttab,xentoolcore > +Requires.private: xenevtchn,xengnttab,xentoolcore Any reason you are keeping xenevtchn and xengnttab? Juergen --------------BFACF1303978B6FFDEB638B5 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------BFACF1303978B6FFDEB638B5-- --Fu28pdw7D7dlcS4cf9xLP4rFA07CqfuNe-- --2bmbxXVaXr22Ps88AGM8Pb2xFxf7SRExT Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBYxqsFAwAAAAAACgkQsN6d1ii/Ey/7 agf/dUVX8bXgTJwMvrgKWWaYAwfzOazflm4rvGK6dk20kIw+4XJRcHz3bQQ7ZOTfzP8PqdsyHLqd zh6O+HI9e9LJolE+7u1+CVkhcqnhvLwVyktQbe2vTgAU/xsUQFkTMPc1NU75AA3tNp1pzHI48yxh pRv0dLPJi7nvDyIcMmlommAaEzhDJQsXYf85MItKSU+iit0Orvz2e8FC3l+zxcu3WlxIyfZr2+Kx YzQrZdg4bL2FGUzAGtNIi4Qi6FePsiN401UzQ9P3jnzOtUs7quTx3zRhcIuXFv+No0cMcqTEVCPU kmtDVfmgGoQkG/3BOyVMmNVdpWTrdH7Gmpi9kUHDKg== =E9zg -----END PGP SIGNATURE----- --2bmbxXVaXr22Ps88AGM8Pb2xFxf7SRExT-- From xen-devel-bounces@lists.xenproject.org Mon Mar 22 16:35:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 16:35:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100371.191183 (Exim 4.92) (envelope-from ) id 1lONX3-0004qd-Pz; Mon, 22 Mar 2021 16:35:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100371.191183; Mon, 22 Mar 2021 16:35:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONX3-0004qW-Mo; Mon, 22 Mar 2021 16:35:57 +0000 Received: by outflank-mailman (input) for mailman id 100371; Mon, 22 Mar 2021 16:35:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONX2-0004qR-N3 for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 16:35:56 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5e907e63-9de5-410f-af48-0aaa9061c69e; Mon, 22 Mar 2021 16:35:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e907e63-9de5-410f-af48-0aaa9061c69e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616430955; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=61rUhLM+UZf/K/gBDqfpryxPK0ZOcihIw7fPC067+bY=; b=b4GS23MoXwh54hakL6zRbPcIJ/jK14iUYmLJUD5E80ZV+Rv34f3vlM5X dvku/6JaW6JbivKRFjhwAvkfNvPUgTuEySBR+uUk8NfOibmT05IpC9fWN uSD6tU6KFVt3b5sZiLrTKVd/XBHDOpRXTYKjvNiSiXgzbhQRkdQw+X82W U=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: bcLKy1VG/wKD9EBA/RIzeIgPZ5Yorn9f0tKNPiOGj5kyCWflWCLrwr2c7tcmeGRoo0L/pS9jNg 0BS0V1lw8JwhJb/gfc7yXkQeF87K3YsCRiJ3ps5RjP8XZAswYqZyz0IK+6aY4QEB/Oon5mF3Ow pzvyqA5OuJsLL+sl484Fnbs8hQ2iGwovBriy1rGlnlM1RG25Ir5twQNwpjfEfobYb9bC18IlqM FPYKqioQcxuBsW9jdRAyphKTwEpwSBCUH2RbHWN+uj0v52WfzxneB83jwfRM04Mll0vCcF5RbO dko= X-SBRS: 5.2 X-MesageID: 39722982 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:2zQ3eaPnaeNt4sBcT0jw55DYdL4zR+YMi2QD/3taDTRIb82VkN 2vlvwH1RnyzA0cQm0khMroAsa9aFvm39pQ7ZMKNbmvGDPntmyhMZ144eLZrwHIMxbVstRQ3a IIScVDIfXtEFl3itv76gGkE9AmhOKK6rysmP229RZQZCtBApsQiztRIACdD0FwWU1iDZ02CJ KT6qN81kWdUF4Qadm2AWRAYvPKoMfFmImjTRkNARMm7wfmt0LV1JfRFR+E0hACFw5e2LtKyx m5ryXVxIWG98u6xBjVynPJ4/1t9ufJ59NfCKW3+7AoAxr2jALAXvUGZ5Sju3QPrPir+BIWlr D30m0dFuBSz1+UQW2vuxvq3GDboUUTwlvv00WRj3emgeGRfkNCN+N7iYhUcgTU5iMb1bkWus I7vBPti7NtARzNhyj77dTTPisa8XacmnY+jfUVy0VWTIp2Us4gkaUk4EhXHJ0cdRiKirwPLe 8GNrC42N9ra1+AK1jWsm5zqebcJUgbL1OtR0gPvdGtyD5GnHx15Ftw/r1vol4wsL06UJVK/O LCL+BBk6xPVNYfaeZHCP4GWtbfMB2AfTv8dEapZXj3HqAOPHzA77bx/bUO/emvPLgF1oE7lp jtWE5R3FRCNH7GOImr5tlm4xrNSGKyUXDG0cdF/aV0vbX6Wf7CLTCDYEpGqbrhn9wvRungH9 qjMpNfBPHuaUH0H5xS4gH4U55ObVEDTcwuvMohUV7mmLOLFqTa8sjgNNrDLrvkFjgpHknlBG EYYTT1LMJcqm+xXHvVhwXQRmPNdkTz8YkYKtmZw8EjjKw2cqFcuAkcjlq0ouuRLydZj6AwdE xiZJPr+5nL4FWezCLt1SFEKxBdBkFa7PHLSHVRvzIHNEvybPIms9WbcmZC4WufKnZEPofrOT 8ag24y1bO8LpSWyyxnIcmgKHimg3wao2/PaJsAhKuZ54PAdokjBpgrHIx9fD+7WSBdqEJPki NueQUETkjQGnfFkqO+lqEZA+nZap1bmwekIcldrFrFrkWCrcQTRn8WNgTeEvK/sEILfX55l1 dx+6gQjP6rgjC0M1Yyh+w+LRlxcmiNOalHCw6EfY1QvbjudGhLPCC3rA3fryt2Vnvh9k0UiG CkCSGPY/nEDmBQvW1i3r/w/El5cXiceExMeml32LcNZ1juizJW66umd6Cz22yeZh85zuYRPC rsTBESLgltrurHnyK9qXKnLzEL158uNuvSAPAfaLnVwGqqM5DNv7oBBeVo8JFsM83OvucHXf mEQRKcKCr1BooSqkqoj0dgHBMxjnYqkfnlgkK4qEe52WMyGvrULhBNQaoBL9SV8mjjQLKp3f xC/KUIlNr1Fl+0TNiMjZzzRXpkDDj4pGatVeEmqZxOp8sJxfNONqiedQGN7W1N2RU1Edz9m0 wfSplq+bypAP4aQ+UiPwZiumcznNuBLEEXohX7L+83c1YqlWLaNbqyksz1gItqJk2Kvw3rP1 aDtwVb4vfeRiOGvIRqQZ4YECBzaEIm7m5l8/7HX4rMCB+yf+UG2FahKHeyfPt8T6eCcI9g4y pS0pWtn+WNcTD/1x2VlTxnIrhW+2LiePiMOmu3aKd12u3/H0+NjKus6NOyizmyaQLTUTVnua R1MWoKbspCjTE+ipYQySbacN2vnn4Y X-IronPort-AV: E=Sophos;i="5.81,269,1610427600"; d="scan'208";a="39722982" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hSmFyJDOMt3mlGqJagnk2CpV+hiUdBvYFThXGtECp6tMK+eUC7ZaOqCLo2W4XzIudWD9NM6WxWdXAQb8WBIcf0oSRlkJm6WhiV1R6Z8pFXCXkidpQfbU2H+XWz6REGS4oDxLjFs9DjZ/Ck30Kt0rYC7zFRYCiIlSEg+5G8rwwPMlOwCffn4Dn0voWA68wRi5JlUyA0sDQ+EbEnsWa69HYHqtHwfJIKvvZNI1INESBAx1aHKteCisNgO9f48LL9A6Ufsr4owAiloCrT7nK6+Tf1NoHBmzzmUEKPd6PYzLRYgmkDd3xlhV738Y5/b+KES6OR+P48KcARAxm2L4P9nkbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=61rUhLM+UZf/K/gBDqfpryxPK0ZOcihIw7fPC067+bY=; b=hqwb3JKlqk4uKKRwzxYNPIUq4kW64MOnxvpip/I4O4+lIYHaYcVb24DxEXniITZNnCtCzEla7I+jLjQlEtyjFh+6hi1h0sSCKYRdNH9WCU7lyrdswrSg2aCUYeV37+gFaHoWzbPoCSZbFOqzrrPSUfaQl5oQ+J2gVZ6yLBJ+JV0q24T1TcZNWd4ADfe7kqBseaSUOb109Ykrg2/un2zgDW9K8tjZtCR80Q5AM2iA6iusu1lTTY8kCn3+hZ9jFvDtY4L2QNWeBscdanp/SBentAHumovq74yjjom6LKJEMvbg1bAKagBRk39f8H2av7IVReOqhORcdjEiX7b5pxfbSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=61rUhLM+UZf/K/gBDqfpryxPK0ZOcihIw7fPC067+bY=; b=hY8UErlruj1Ky/9FS+VBZPGfu6zR/YDauQVQkUUXXusMaKi49EvMDcAXxLCvtrpxy7bdW1xMEQVrq+tsHXp7YT1px1brU5dz77/+riA6XWstzAGToH9tLjHp+MDHdkrrNvsEuH2jZ0xgJV3ifRJPA3xn2EKSW5DFW9932GN0IjI= Subject: Re: [PATCH for-4.14] tools: Fix pkg-config file for libxenstore To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Xen-devel CC: Ian Jackson , Wei Liu , Jan Beulich References: <20210322162013.12639-1-andrew.cooper3@citrix.com> <0a006343-4d2c-acd7-d2ce-abd04220e0de@suse.com> From: Andrew Cooper Message-ID: <1926a28a-2fea-33c6-b729-5a9b4692da58@citrix.com> Date: Mon, 22 Mar 2021 16:35:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <0a006343-4d2c-acd7-d2ce-abd04220e0de@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0286.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::34) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d5ed6d38-7033-4ae0-3337-08d8ed508f38 X-MS-TrafficTypeDiagnostic: BN3PR03MB2372: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HMqh/wm/Uif2f6IgKGe3qeiW/dnAS6OHzvBYUoYlf2YnagLRpBmFQIzKB9u58VuEDZtF1QcUUJY8SYCZRdxOCZeIxWc05neK1fY2l6DVZyJzBOPYvHY6LVztbjU06rUkPDrjBHU/OL5pkb5rEtKoFaJbiXlH2fvFoDmfedViC7jWEqk2x4sBzS11U93DBc0ikcTAw6n7rIgnAu3JzSaKJXLOUn32/hZeTXoAxkZaFEtdBPR9nWiL1HborsFk+p6TBT0lcyBicw5M/nyhEELqNoios1FDvt1AAzQXMQpwMDsDX1S2l/f7/lPj3NLT/ljXZ5sB1XNvzN05QuuUoz4otcS4TptC1RBPNS4SpeLeJIlseTB+JBHstfXPMC6LbuAZd6eurLVYWOoNMUzf/Lz9GZH85bG7ZzrBvET1bApFEj3r8+zm0I/u+EJ0vH417GNiCi0IUPewe1ZibibsT3A0L8oeUNT8NFcDrbubTOxfPjOFZSV9+3+nsOgskS/Bf+TkH4EPF9WOvQn+CCeeOQ7hquvwXoNkfvVbQjNQPrB8kS9OoYOR+9fczl3eLArlxsnGBl8rbHUU2PgRyn7m0ak5x104CH8IDaj7vqf5ndRq2HwqtheBzQVYRoWaND8Ma9lCoKt06+BtnC7nVZybasrZgPS4PBa5mpfC0RW/gg34RPr/z1LX8IX9EJZpAxUj22/d4H9KJyhAN073WV28oIJjOD5Qnukm9kmiZOXsAUhn90A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(376002)(396003)(39860400002)(366004)(16576012)(66946007)(66556008)(66476007)(186003)(16526019)(54906003)(53546011)(956004)(8676002)(2616005)(26005)(86362001)(31686004)(316002)(110136005)(2906002)(8936002)(66574015)(31696002)(36756003)(83380400001)(5660300002)(6486002)(6666004)(478600001)(4326008)(38100700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?cDRqa1RCYXgyTitmQjBVY2w1OVpiZzlHMFU4bE8ybUN6MkZzRUpwY2xTYlkr?= =?utf-8?B?V0taS21rdFY2Q2o2OTVRTm5nZkVsdFVPaiswdHhZM20xVE91NTR4d2NUaWsv?= =?utf-8?B?RU91a0ZwUXpiQWdON3UyWFdOSk5nMlZkRG9VOUtkMm9hMnRZb2dpL2EyM3Ft?= =?utf-8?B?TU9LMzczaFd6bWhGVW8wb3B2eW82bko3VERQWmVDVFVhNnFMVVlUOE44MFJG?= =?utf-8?B?T1A5THhGMjlVclh2VlRGRTFtQXNNY2JzSmd6d1V3RDlPVkgyMzhZeTlLVjVC?= =?utf-8?B?eHd0QjAzT1JlbjdwSFhZZEVhSHg5SkRPc2Jjb0dtNjgzNG5Day9tb2lDQ2tV?= =?utf-8?B?UlNWK0lkUWVmaXJ1QXpPLzAzdUhMRzd0d2JVMFgrMVJpelA2L2tteDJjTU05?= =?utf-8?B?dEkreXJES1VSRVhVTlI0RUNwNlpBekI1QkZDQWp0T081ZFFYK0pkcUxtNW53?= =?utf-8?B?dlVTazJpcnRsTUhYSUZkMnhzWGw0NGQrSWZVTlF5Y01pMHp1TzRzNG1sajJE?= =?utf-8?B?TnBDL3Evck5pZVNCaVpZYVlNZDNwbHlCOXV5Titqa3dmekJUYXBjOWM0bVFv?= =?utf-8?B?cmttNFJMVGJQdjkydzJkbndhQnR0dkM0U3NqR01TNjk1YXJJQ1lYRkdwb2Na?= =?utf-8?B?K0hWZ3JUVnlLS3NqamJUb1dhbnFmb0RQTHlDR2djakl4S245NHJhVW9iYnlx?= =?utf-8?B?YTVNZ0JuQjg4N1dSLzY1cG9LZHM2emRmUUU1S1hOZmRiWWhGYzd6WElzcFZu?= =?utf-8?B?N3ZlbzBSczRGeHZMcGtNZm5jaDBZNjVIajRURWZuYWkvY2hIanZEbTlBUVVs?= =?utf-8?B?RkhNd3IyeEJTR2N3UUNoN2tXVVBpRTQyYi95ZHZnY1dZZE85VWtpRlNodFRy?= =?utf-8?B?OXNGOVZrVWFGN2RteDZlRVhhT1hiQjFJVG9KWng5d2VoWXZ3U0Q2Z2V2UW1L?= =?utf-8?B?eXMxN3MvOVVyTllDeVBrRUw4OVVEYkZxM2dPaENLNi9peWQxRlJUWlBuekVO?= =?utf-8?B?aXZkQWMvUllsZzgwTGpCemE4K0JzUWNQUVhsTlMrRHY1NUVpOHdNQXlnN0NQ?= =?utf-8?B?UDFpRk9VT2VvQ1pBR1FHcEpvVTJwdlNhcUZ6bDRXQlBSUnYxS3kyNHBnSzFw?= =?utf-8?B?ekNsVHFIUHFxZlp2TlJBYkdEVjdLa2daRHJNbU1XWHE4T2JXOUFJeGlLZGoz?= =?utf-8?B?anNBNDJJaHMyelVldVJuZFFzTnJxeU5DVEptSzRTU2w5ckNZdHFIbHJnQk1i?= =?utf-8?B?MkQrMHZJcnlMYTZhVitISkswLzRQYmxHbGdMTlVvUUY2cFdHRUpwWUpreG5R?= =?utf-8?B?ZGpvWmhtQlNsTyt6a1NsY1pGZXhFRE9hVExlL0lGUWkzczBnbjhkZE9uMVRL?= =?utf-8?B?WHR6bk4rN1dJSCthdWkzQWd3WDNyaVRqYTkrS0lnM3NXWEREVEJhMncvQm5k?= =?utf-8?B?SHl3WDRpSURib3lDTW85d2Z6TkkyMDNNTC9RSXhHWVRST2NyWUpUWGs2dWc3?= =?utf-8?B?NlZXSTYwa05wbFJZdlFsZlc3NE9XNFQ2MGlIalZvenZkK2V3YjNoOXBLZGEz?= =?utf-8?B?c2t3eVdFNW1BL0ZNbE1VVFptS1dkeFY2QXdlWEVqdi9RTFFCWDFiVTc1bFlE?= =?utf-8?B?REZBQnNDb2JvendmM2t0OVNncVZSM25NZFM1RldjWW9HZG04WTFrYlFpU1dL?= =?utf-8?B?ZEZDMkpZK0JzK1RxMHkxUTBhTjRvbVdFUkRSTW54aExibU1nY1VxVjRnc0hD?= =?utf-8?Q?O+ZDEfhUcnp8uWWZQM9KmhEwCRbuiPk14s1McPU?= X-MS-Exchange-CrossTenant-Network-Message-Id: d5ed6d38-7033-4ae0-3337-08d8ed508f38 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2021 16:35:53.0945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9Bssbo7+IjchjLk+cERdYJkjN1ZiDtMTUDpPO7FNBI8Z1YMHqULgb2ijmgl0lDoPYQIIKpQnnfbvXMy8u3kSdKgN92V4AbUmUl2z7m54WiY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2372 X-OriginatorOrg: citrix.com On 22/03/2021 16:32, Jürgen Groß wrote: > On 22.03.21 17:20, Andrew Cooper wrote: >> There is no dependency on libxenctrl. >> >> Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore") >> Signed-off-by: Andrew Cooper >> --- >> CC: Ian Jackson >> CC: Wei Liu >> CC: Juergen Gross >> CC: Jan Beulich >> >> This has been fixed in Xen 4.15 by the uselibs.mk logic, but 4.14 and >> older >> cause everything linking against libxenstore to also try linking against >> libxenctrl.  It also causes RPM to create unexpected dependencies >> between >> subpackages, which is a problem when trying to separate the stable and >> unstable libs. >> --- >>   tools/xenstore/xenstore.pc.in | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/xenstore/xenstore.pc.in >> b/tools/xenstore/xenstore.pc.in >> index 2f64a6b824..98c3f1ab39 100644 >> --- a/tools/xenstore/xenstore.pc.in >> +++ b/tools/xenstore/xenstore.pc.in >> @@ -8,4 +8,4 @@ Version: @@version@@ >>   Cflags: -I${includedir} @@cflagslocal@@ >>   Libs: @@libsflag@@${libdir} -lxenstore >>   Libs.private: -ldl >> -Requires.private: xenevtchn,xencontrol,xengnttab,xentoolcore >> +Requires.private: xenevtchn,xengnttab,xentoolcore > > Any reason you are keeping xenevtchn and xengnttab? Oh - good point.  I misread uselibs.  Its only toolcore who's dependency remains in 4.15. I'll send out a v2. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 22 16:39:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 16:39:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100375.191199 (Exim 4.92) (envelope-from ) id 1lONa1-00056v-AO; Mon, 22 Mar 2021 16:39:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100375.191199; Mon, 22 Mar 2021 16:39:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONa1-00056o-6e; Mon, 22 Mar 2021 16:39:01 +0000 Received: by outflank-mailman (input) for mailman id 100375; Mon, 22 Mar 2021 16:39:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONa0-00056j-7f for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 16:39:00 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d72de622-c353-4c4c-b21b-b292c001eaba; Mon, 22 Mar 2021 16:38:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d72de622-c353-4c4c-b21b-b292c001eaba DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616431139; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=HoxMUdfnY8hP4fqC/GeGi36qJO4A5BdcIq5ysDQMYoE=; b=LjEnRKwabYGeZ5j7TtYGoqtmfn7JtbSO1lI9XB0JskJSQmZLAXHVtIZE bYrpGjZnHaryEzzSbq+njtvXD0Ki0umLkdJaj+84NOF3X8WYPMsIWXvYf i9KoZD7kt3vN7er3fbAqd2OyxdvMbdFxUF45uk8zlgOWahT+viaZWEgcC g=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 1f7+OmeiNStR+oW8+BG228YJKuGMKyEwCYbzKm1Lt4vRN/r7I83St//su36Fvjxn6MCmiPO8Mq W0fO+wZdDnwBLR1PSk6SFTiAdZbYsN/+MIAi/xUExgpzTMmwqclmR/ZbB8IqeANMAPaFQAFR7+ GhFd6B031Cc+D8RVWCIystDiOmIWtU5b6K5u//0M9NFrNpWqzH2vtH37s8Gcsu9jcpgx4522nw QHfxllLHHYSiYcjYCijKsMHeoueUvC4Gi49UDlTrLEHSWSTgKyHC0Ak/fnuu3o3sy/ST8Xdk5H I7k= X-SBRS: 5.1 X-MesageID: 39825042 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:dFzSnqMKtuQJUcBcTlujsMiAIKoaSvp033AA0UdtRRtJNvGCn8 e1k/gBkTPygjAdWHYv8OrwW5Woa3Xa6JJz/M0tLa6vNTOHhEKEJJxvhLGN/xTOACv7n9Qw6Y 5FU4xTTOL9FkJ7i8GS2mSFOvIt2sOO/qztpeq29R1QZDpnYa1h8At1YzzzeiZLbTNbDpk0Ho f03Kt6jgenEE55Uu2LQl8YQuPEu9rH0LXhbBJuPW9D1CC+yRW19bX9Dx+Umi07bgoK67Ij/W /Z+jaJhJmejw== X-IronPort-AV: E=Sophos;i="5.81,269,1610427600"; d="scan'208";a="39825042" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Ian Jackson , Wei Liu , Juergen Gross , Jan Beulich Subject: [PATCH v2 for-4.14] tools: Fix pkg-config file for libxenstore Date: Mon, 22 Mar 2021 16:38:47 +0000 Message-ID: <20210322163847.23941-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210322162013.12639-1-andrew.cooper3@citrix.com> References: <20210322162013.12639-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain There are no dependenices on evtchn, ctrl or gnttab. Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore") Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Juergen Gross CC: Jan Beulich v2: * Drop xenevtchn and xengnttab as well This has been fixed in Xen 4.15 by the uselibs.mk logic, but 4.14 and older cause everything linking against libxenstore to also try linking against libxenctrl. It also causes RPM to create unexpected dependencies between subpackages, which is a problem when trying to separate the stable and unstable libs. --- tools/xenstore/xenstore.pc.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstore/xenstore.pc.in b/tools/xenstore/xenstore.pc.in index 2f64a6b824..2a278b4395 100644 --- a/tools/xenstore/xenstore.pc.in +++ b/tools/xenstore/xenstore.pc.in @@ -8,4 +8,4 @@ Version: @@version@@ Cflags: -I${includedir} @@cflagslocal@@ Libs: @@libsflag@@${libdir} -lxenstore Libs.private: -ldl -Requires.private: xenevtchn,xencontrol,xengnttab,xentoolcore +Requires.private: xentoolcore -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Mar 22 16:54:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 16:54:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100383.191216 (Exim 4.92) (envelope-from ) id 1lONoM-0006uo-OC; Mon, 22 Mar 2021 16:53:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100383.191216; Mon, 22 Mar 2021 16:53:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONoM-0006uh-LD; Mon, 22 Mar 2021 16:53:50 +0000 Received: by outflank-mailman (input) for mailman id 100383; Mon, 22 Mar 2021 16:53:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lONoK-0006uc-Sl for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 16:53:48 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b8105d54-07e7-42ae-afce-23d3707ddf8f; Mon, 22 Mar 2021 16:53:47 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8727DAF0D; Mon, 22 Mar 2021 16:53:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8105d54-07e7-42ae-afce-23d3707ddf8f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616432026; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rPR682WIHuCagi0j74zp3+OiB5sB38u/YRtUa9hb4Yc=; b=JRG4iHR+5f5tTJQrZbGK34f7xSbmVTD7gJW0O7Lzyhr461febRpB1WIQUfw+IQu1n+5Jxz QOb5EKjs6OJ+ZdgFcH0zjeWp84T8/9jQX0inEDExgYw9u8OImCik/rFgviWYOlZxqPya/Z b2k6ZRTLs+UIAOOsUvgV783cXpPzHhw= Subject: Re: [PATCH] xen: Create EFI_VENDOR directory To: Jason Andryuk Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel References: <20210322133301.11308-1-jandryuk@gmail.com> From: Jan Beulich Message-ID: <23556ca9-86f4-854f-5178-6fb927166245@suse.com> Date: Mon, 22 Mar 2021 17:53:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 22.03.2021 16:36, Jason Andryuk wrote: > On Mon, Mar 22, 2021 at 11:15 AM Jan Beulich wrote: >> >> On 22.03.2021 15:59, Andrew Cooper wrote: >>> On 22/03/2021 14:52, Jan Beulich wrote: >>>> On 22.03.2021 14:33, Jason Andryuk wrote: >>>>> make install-xen fails when EFI_VENDOR is set (=fedora) with: >>>>> install: cannot create regular file '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No such file or directory >>>>> >>>>> Create the EFI_VENDOR directory so xen.efi can be installed within. >>>>> >>>>> This removes the need for Fedora and Qubes xen.spec files to manually >>>>> create the directory in advance. >>>> While I'm not strictly against, I'd like to point out that it was >>>> deliberate to not create this directory here. I also didn't expect >>>> anyone's xen.spec to do so. Instead I'd expect the distro to create >>>> it during OS installation. If this was a bad assumption, I'd prefer >>>> if the commit message here could point out why such an expectation >>>> won't hold in general. > > I didn't write this for an rpm xen.spec - I just cross referenced out > of curiosity. > >>> This reasoning is broken for anything other `make install DESTDIR=/` on >>> a live system. >>> >>> It is incompatible with how RPM, deb, etc packages work. >> >> I'm afraid I don't understand, for both of your statements. If distro >> installation put in place the designated directory, there wouldn't be >> any live system lacking it, and there wouldn't be any concern in the >> packaging of any software. >> >> To take a perhaps too extreme example - packages typically expect e.g. >> /usr to exist as well, don't they? > > But you have to install -d ${D}/usr before install ${D}/usr/file, right? Sure, but I take it that about every package can rely on it to be there, and not have to take care of creating it. There ought to be an "owning" package for that directory, and that's the package responsible for creating it. The same would then go for wherever you want xen.efi to go. > It's a surprising sequence to: > 1) see 'EFI installation only partially done (EFI_VENDOR not set)' > 2) set EFI_VENDOR > 3) see xen.efi installation fail > > I was working on a fedora system, and I was using `make && sh > install.sh` to install (but be sure to `rm -r dist/install/var/run` > since otherwise that'll break booting). I wanted xen.efi to end up in > /boot/efi/EFI/fedora after running `sh install.sh`, and EFI_VENDOR > appeared to be the way to do it. Again, it was surprising to enable > an option and then have it break. Well - the thing is that according to my understanding you don't simply pick a directory name of your liking, but you use the one your distro uses. Otherwise I consider it quite likely that upon next re-building of the EFI partition your binary won't be put back. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 22 17:09:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 17:09:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100390.191239 (Exim 4.92) (envelope-from ) id 1lOO34-00089Q-6t; Mon, 22 Mar 2021 17:09:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100390.191239; Mon, 22 Mar 2021 17:09:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOO34-00089J-3k; Mon, 22 Mar 2021 17:09:02 +0000 Received: by outflank-mailman (input) for mailman id 100390; Mon, 22 Mar 2021 17:09:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOO33-00089E-Ct for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 17:09:01 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2f7509f6-1552-48dd-902b-5d5dc3f793f0; Mon, 22 Mar 2021 17:09:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f7509f6-1552-48dd-902b-5d5dc3f793f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616432939; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=QPtX9B06g+oughc1P4agimdfnvEc+taVde1WpUDghLI=; b=f0F6yHT1SrLwU/ri2Sa3HRjlI1HjKFlxhuQKjhRkK8L0i9DJNHUHRlo7 aLy4gT1rqbAw7/QgQ9x3UDPtwhIOcYedkRDCtzqT8dHWQqzo11kYe8dlY s9TZsPHddj6pI2/OJk88h3YUtIUf87/OEY6ovy5PUwzQ2fsfgdxhAQ2q4 A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: QhDkJ2biR9Hhp9G0bkt2a+0qgwDYk2FeLvotNXhS/9r+7Uy5L4NqW77n2AJlLpUNTdqUmfAyow ANkPX9BX09dpvkKqkbDbc1ZvBQKvCRLu7zIzefkIzaTp8IV5JBgI0XQqCmvFHXfuT+b7XPo69L G4gu9crGeGxavK28UrYfgknG9ojEWsnm47dcuCDNwbMcs8YRKHgHlQcn1/09+vlte2+w0DrN1F 7GXMaOggpSwesuzdyzzi/uydbNeI1ygyY8e4YPfjFikwSgdnLnRx0XXJyC4JcuNmzz1ZSl5kCw 0f8= X-SBRS: 5.2 X-MesageID: 40207814 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:c60wIaPE+EYqk8BcT4X155DYdL4zR+YMi2QD/UZ3VBBTb4ikh9 mj9c5rsCPcpRQwfDUbmd6GMLSdWn+0z/QZ3aA9NaqvNTOLhEKGN4dnhLGM/xTEGzfistJbz7 tqaaJkCNb9ZGIK9PrSxCmdP5IezMKc8Kau7N2urUtFaQ1xcalv40NYJ2+gcnFefwVNCZonGJ f03KMumxOadW0TfoCHABA+MdTrncHBl57tfHc9dn0awTSJ5AnI1JfKVzOZ2RofVD0n+8ZHzU H11yjCyY6H2svR9jbsk0vo364TsOLAo+Ezf/Cku4wwIjXohR2vYO1aKtu/lQFwhOm16lo2lv ngyi1QWPhb2jf0fHycuhHt2xbtuQxek0PK+Bu9g2bGqcz9aRAbL6N69PhkTic= X-IronPort-AV: E=Sophos;i="5.81,269,1610427600"; d="scan'208";a="40207814" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H0029rH7hZKX9nAZDPefqX3dn88Ju/gMxDU6taYZgryYB6NMcAnhVyGvFQ6b06roPHEEeKD7u6H1Rb3CprOjeFB/oYUpSUBR69nenXjHOZx1eiFO6YHV1L4t2YxP8chWCnH3JwCaRkuZP5h05+dbl3o5yodfnvBhdql5vVHjTSTRfOqszCCfIKOhLbvhn8gzuQNoYwrmZxvTbaeJA7xv5LdgYkYbpd6ARS30PHfjv7XkSsGksTHhGHOs60wFGwZrQSkA2ZEwwFnrToWE6GqBCHGk1RdHyKeCOMLkuIXh+Nujzj+a4f11gtGslxi50UWdYbAvaTt8uIysoTtHhJZalA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QPtX9B06g+oughc1P4agimdfnvEc+taVde1WpUDghLI=; b=ShB23OdYxPQjzdq5GTThvqHO0nZ2rP7pKbNz0JgFYneUS6FJzmkGlgWQgexeyxR8QVmplBJgiuzxWSpLVwty5wxWQkAeZwDB2oOMmuOZsmb+d+Ii5+7INX+5V4vAPteniEpp01SXb6TxhOHP/R/guoBba/WBfEeiUTeMQb4hKWEZv+ca6kBScCo3qJgEqKOER9pCvpsS/ymiZhvu9LRqUeef7IkWPetl8mItyBFoNzrJSRafx9Gu6KNn81Ysahzpgz8uojtSJEXY0Jjt1wdmbken1mle/U9uzN2xhfRntnZdJXGDvkopvHFTPLHSORFz1NqonBTTZHwhkpcKkJhLgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QPtX9B06g+oughc1P4agimdfnvEc+taVde1WpUDghLI=; b=ESalTWftqoJM0WTz9pcGS1UvJ2pnDsFxEW3YHfHd+KMgPXkJFuXj2tVMa7Uy6WQGAGptlK58Duca2iMIfdDGasM4V69W6dZsUrEJBVtYX0dHdz52PU2bd5pJysJPYBdM/1bppjTRzh2viPFKTw6xAjeaG1L6ussUodf3NidWD3k= To: Jan Beulich CC: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , , Jason Andryuk References: <20210322133301.11308-1-jandryuk@gmail.com> From: Andrew Cooper Subject: Re: [PATCH] xen: Create EFI_VENDOR directory Message-ID: <09b5e7ee-b44b-a8ab-f29d-6617b6af93a0@citrix.com> Date: Mon, 22 Mar 2021 17:08:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LNXP265CA0066.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::30) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 138f6e69-3d1e-4066-e246-08d8ed552d50 X-MS-TrafficTypeDiagnostic: BN3PR03MB2372: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kFtVQ/oJdHYbrme8RThaqU+dfC23eDhOx74W8WvB6QNbn7qHj/62cdktl/hd7yyFBg/Xjvwr9hEMUck6ghDWBRobG7Yh3t+BvVZNrMOE5eQdu+G2hkgFL44nu6ipzOjNnsq9fLWWrrO9qw7gdmqV3NsRvKbO0J/ye3+CWuqKbwc1ZwKoCPhjJ8U2eFDXu1+gGKMD6pD0SYbdMjoStzR0U8RfU0S+HpPot3rDr88zEh6HO6LEOEgRmtcaSo8Cov8Hak4r0lE6LXCDn0zoxt9YzLBr2/h/GSHAh5Rb3sn89MctMNJVIeT2PxeXZVjhfhIm0nnnPSIV5rVOikY/E81vQFm2XIqWt6N3ipaf3JQHolXMp3HPVRBuvKaHoY+k/RwKC5aSA7FVEi6Z7wHDORz78GzsH0AXpalPCJWvF9ZG7vz2pjDn7QxdjHmtMvEDuHE/eA2xT4WPMlvuU3puf2yFM/kgOc0aPrA4hySjAL4+UKlfzpLSNXDZZr8M9lrgO+vElUYcz4Uwb41pR2AECKxQ/cLu6WLvoW7oFaD1/MwzQQdR4peS5KqETkesYMUQpk7yIsfrIJcumYH5owQc3nTP8GKji206EDSTmJhlLp929SG5swq77E1cx1P3RhQcqUj/nJsemxHY8cMPiTfqSRMS4MKq/z+tI70btDicpV2tg9Z9+/iC6iJKT2oFgabNjcUh7Qnew4vgeiDXSfNiqYSFq+/fjQP/nU1Yriw5wkEmYM8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(16576012)(66946007)(66556008)(66476007)(186003)(16526019)(54906003)(53546011)(956004)(2616005)(8676002)(26005)(86362001)(31686004)(316002)(2906002)(8936002)(31696002)(6916009)(36756003)(83380400001)(5660300002)(6486002)(6666004)(478600001)(4326008)(38100700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WjJOamZiVjAybDZMczZYdXV6aEdtL0tZM0FpNkZyeVFNaERCMlhTMWlXcG1q?= =?utf-8?B?TVU5NWRLU0NGaVhkRTJEZVpzNkJSWWYyNHB0bnJ6VnNrYzkyTFRvcmlBU3Z5?= =?utf-8?B?NzJFNnEraU9rNy9vdm11OENDMmhDbTdMangzTHdPaFRqRU1LYkV0MzRrYUIv?= =?utf-8?B?Y0lYaHNFTWJtaC9wdUk2VkpxY2VtalVmM3JFWGJ3ZzloblEwb25GWDZ3TDBa?= =?utf-8?B?QjNicW02QkEvVjFnamdtQTdnUU56NDBITmd3LzFMTElUMjZ5Ym8rTUNRU1dj?= =?utf-8?B?T1FkT0lDN1crZXEyUGVWZkNiTVhIOEdTaG1FUTRLVDdxeGV4V2dTYUh2Y2hl?= =?utf-8?B?WjRwS28xdmJiSEdSRStLVjFGZWlNdUQwYUVpSHpFaGlURGN1WGErcC94dkI1?= =?utf-8?B?eXV5eExmSll4ejIwL0lpZHptNzJtZkZqcXVJSzFmVy91cVlabGViZFFONWxh?= =?utf-8?B?RjNEUkVIYnJhOG44bGM1QWxqVTREdGZSeDVuc3h4WjEzQ3JMN2RITEtaN3FO?= =?utf-8?B?TFkrazloang1ZVZSQjVqTktzZHZPUEY5eEMvVXkzR1M2UEF2Q2twNHZhbE9z?= =?utf-8?B?cm5FTHova20wOG56NjExRmVqbzF6aE8wanAzYWNURkM4a0QxTlhPWnBoWHJJ?= =?utf-8?B?U2ZVbWpmRXBxQUZYWTFBS0szNzVXNGNGbDR6eWlYZzR6alNucS91QTExU0J2?= =?utf-8?B?azY2d0VTTHpUWUw5enJJaENYTklKU3p4UzUwTkl4SGloWnB4RExNbHFpTk9H?= =?utf-8?B?bVRWN2dOV3Y3QUljR2tLOVV6M1RHU2IrbGpZTDNGWVBPZHB5cUxsazVKZFRK?= =?utf-8?B?TDRpSUVhbDJqbnRDczUxVWJPYU1DeE0xbGFZblZQR2xsOXY4WUFBRHM5Ulhj?= =?utf-8?B?Q1pVUHpEWkJaeVRuMVFRaGkxQ1AwRXVTeXFQUmRGK3ZHS0ROczZueHRmL1VV?= =?utf-8?B?TGNScXhabGl5aFJFRU42NEJLMWRGalZ4cXBKa3ErZk91UVArOVEwWkVLeGNH?= =?utf-8?B?Y0UwSjd6UjlMbFRoS25uVVorcklQdGhxYmNkMkNUNHgrTXRNckJLUmRCdHgw?= =?utf-8?B?dmcvWXJPdmlOM2Jvb1NzMVZJcGdycm5YeUNiekhya3pqRHFRNG8rRExCaU9L?= =?utf-8?B?NnNBMkQxN01XTnR5R3ZyL2VJNVg0emZJS3phVkNxNDhDUllPRkpJejQzV2Rk?= =?utf-8?B?aGJtRUE4TnJpTGN5L0pGUGw0cmJiVDBvVjBENGh4RGJmVlNrMitNMkxMbWVz?= =?utf-8?B?b0E5MXdmRmlic1pxS1ZsbG5DRk5kYVJWOWlUaFdLczhWMXFMc0xIcThwQnov?= =?utf-8?B?SXBFN3NCNmRXSG82Y0NFY2UxV0V0SDVSUnZXRmlReHFWWnpkVmtwdTMxbC83?= =?utf-8?B?QmR0QXJpVzB2QVhWVE5UbTBES0V4VCtlZHFlNUNnZjhadC9iZWpCY09NZllO?= =?utf-8?B?NlQ0aTk5bGxBNGsvbVN2dWJlbERlNElkTWpYeG40Y3BQczhYRWRRbVZtcnFh?= =?utf-8?B?YjFTYmJaQzhleG8vOFdFNkNSaHJ5aXpZeVdDcHJGbGIvcWZUMUJCVVdFemVs?= =?utf-8?B?Z0xEdVZwcTJBY2hCSDNqYXBxUk1YMUhrSUNYbEJWQ0tkRzNLUWNFMFdTRE5s?= =?utf-8?B?YnVPZ2VEYitmZWx4ZVdWTXNtNjBhSm1ZL3dZSllQTTFrNlNqZS9UWExUN3BI?= =?utf-8?B?UTJSc2FWRnZyVEVZa0FHVldLYjlZV2JvSkY0U0pEaDFXQ0FHSnBNSzRKczJ2?= =?utf-8?Q?pvG5vc8wELvZBpFC82sv6jXzygkzqoINqWv3Rhl?= X-MS-Exchange-CrossTenant-Network-Message-Id: 138f6e69-3d1e-4066-e246-08d8ed552d50 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2021 17:08:56.2952 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RcIMDRcPZxi6VHdpKDlGbGczq69X4mwKA2/MovBc0FDcScchOqz6YW+rFqmwdsc1gbvc9FHxBPAtWYht/NsDt671DUyF5+stM50tQIp6D7E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2372 X-OriginatorOrg: citrix.com On 22/03/2021 15:15, Jan Beulich wrote: > On 22.03.2021 15:59, Andrew Cooper wrote: >> On 22/03/2021 14:52, Jan Beulich wrote: >>> On 22.03.2021 14:33, Jason Andryuk wrote: >>>> make install-xen fails when EFI_VENDOR is set (=3Dfedora) with: >>>> install: cannot create regular file '/home/user/xen/dist/install/boot/= efi/efi/fedora/xen-4.15.0-rc.efi': No such file or directory >>>> >>>> Create the EFI_VENDOR directory so xen.efi can be installed within. >>>> >>>> This removes the need for Fedora and Qubes xen.spec files to manually >>>> create the directory in advance. >>> While I'm not strictly against, I'd like to point out that it was >>> deliberate to not create this directory here. I also didn't expect >>> anyone's xen.spec to do so. Instead I'd expect the distro to create >>> it during OS installation. If this was a bad assumption, I'd prefer >>> if the commit message here could point out why such an expectation >>> won't hold in general. >> This reasoning is broken for anything other `make install DESTDIR=3D/` o= n >> a live system. >> >> It is incompatible with how RPM, deb, etc packages work. > I'm afraid I don't understand, for both of your statements. If distro > installation put in place the designated directory, there wouldn't be > any live system lacking it, and there wouldn't be any concern in the > packaging of any software. > > To take a perhaps too extreme example - packages typically expect e.g. > /usr to exist as well, don't they? No.=C2=A0 A buildroot starts out fully empty, by design. The packaging environment (usually a chroot) invokes `make install DESTDIR=3D/path/to/staging/root` so you don't interfere with any of the tools inside the environment, and the resulting tar/cpio has the buildroot stripped out of paths. The failure being discussed here is the build within the packaging environment, not the metadata which forms the final package.=C2=A0 Installi= ng a deb/rpm/etc will make directories as applicable. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 22 17:29:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 17:29:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100393.191251 (Exim 4.92) (envelope-from ) id 1lOOMW-0001dR-WA; Mon, 22 Mar 2021 17:29:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100393.191251; Mon, 22 Mar 2021 17:29:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOOMW-0001dK-Sm; Mon, 22 Mar 2021 17:29:08 +0000 Received: by outflank-mailman (input) for mailman id 100393; Mon, 22 Mar 2021 17:29:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOOMV-0001dC-0o; Mon, 22 Mar 2021 17:29:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOOMU-0000Jk-Q1; Mon, 22 Mar 2021 17:29:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOOMU-0006YH-GY; Mon, 22 Mar 2021 17:29:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOOMU-0008Dc-G0; Mon, 22 Mar 2021 17:29:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZF1QPPb/vENCg1fSGSn2zlz5y04f0gkoDCJnWizAajg=; b=Y8YIJRxW/1d2bPWVA8QiNeZ9lU cLL5TAjT8bHvZr+zfeNwv6xCxyDFchKYg0doTrXIltQVP4f8eaEIPEK8sttOtixuul/TZBlombYlD HMmvy1UB6Q8MSqvrd8RydpWMuXyXmecg/wJv/Tfmo6/A1/cs/07dcTNEZfSCWr2F/g3k=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160167: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=bdee969c0e65d4d509932b1d70e3a3b2ffbff6d5 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Mon, 22 Mar 2021 17:29:06 +0000 flight 160167 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160167/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu bdee969c0e65d4d509932b1d70e3a3b2ffbff6d5 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 214 days Failing since 152659 2020-08-21 14:07:39 Z 213 days 409 attempts Testing same since 160167 2021-03-21 07:00:51 Z 1 days 1 attempts ------------------------------------------------------------ 461 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 134764 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 22 18:09:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 18:09:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100407.191283 (Exim 4.92) (envelope-from ) id 1lOOzN-0005W9-Hz; Mon, 22 Mar 2021 18:09:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100407.191283; Mon, 22 Mar 2021 18:09:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOOzN-0005W2-Eb; Mon, 22 Mar 2021 18:09:17 +0000 Received: by outflank-mailman (input) for mailman id 100407; Mon, 22 Mar 2021 18:09:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOOzM-0005Vr-8A; Mon, 22 Mar 2021 18:09:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOOzL-000137-Ud; Mon, 22 Mar 2021 18:09:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOOzL-0008P0-Mq; Mon, 22 Mar 2021 18:09:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOOzL-0001eQ-ML; Mon, 22 Mar 2021 18:09:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pWBZMyCgFUW2rUL+2vwYVqWbtbFVTwvZ5Cg/+1HHDyM=; b=1teRjQiTO/JWFEpJF1zOavgzXo BR5Ts94VMfQy7mkF3F70lJtMxXVFkgJJPwL3yxbiZ7kILrwPuCHKwJ4mrcDzsE9Q3HcQ84/+0jOix COrmg7CNRJSrbhDnjRnijNZg4HY65bJJLIvY1ivibnFyoyN7TZMr+7Nv38CfZjkt8vsw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160262: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=63bed955dffb9163464a38e2ae14a20934bc8770 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 22 Mar 2021 18:09:15 +0000 flight 160262 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160262/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 63bed955dffb9163464a38e2ae14a20934bc8770 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 255 days Failing since 151818 2020-07-11 04:18:52 Z 254 days 247 attempts Testing same since 160151 2021-03-20 04:19:22 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 48222 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 22 18:25:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 18:25:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100417.191310 (Exim 4.92) (envelope-from ) id 1lOPEr-0007KB-4R; Mon, 22 Mar 2021 18:25:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100417.191310; Mon, 22 Mar 2021 18:25:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOPEr-0007K4-1T; Mon, 22 Mar 2021 18:25:17 +0000 Received: by outflank-mailman (input) for mailman id 100417; Mon, 22 Mar 2021 18:25:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOPEp-0007Jz-Ua for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 18:25:16 +0000 Received: from mail-pf1-x429.google.com (unknown [2607:f8b0:4864:20::429]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2bdf8ecd-19d7-4c7c-9026-80119fa032f1; Mon, 22 Mar 2021 18:25:15 +0000 (UTC) Received: by mail-pf1-x429.google.com with SMTP id h3so11551633pfr.12 for ; Mon, 22 Mar 2021 11:25:15 -0700 (PDT) Received: from ?IPv6:2601:1c2:4f80:d230::5? ([2601:1c2:4f80:d230::5]) by smtp.gmail.com with ESMTPSA id w26sm14498001pfj.58.2021.03.22.11.25.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 11:25:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2bdf8ecd-19d7-4c7c-9026-80119fa032f1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IxoEKJOUOQFmvYGa36soNK+UytaHxHgyUxN5OgIsxow=; b=SGCkAK1nqgwb7kITZZ6i/gT5sc1vrPzk0//+H+ltfa//+5vfPjROMhQ3q7Yi/HcLuN GFS3HT8Yc/BEt14fbnqZAPq50oh8840X9W9Gn00ijU4GjxShkx4cjTn1XRybjrNQ4oOg XaIEfwYlHbNMEyzlCejJT/UWy5tRpWbmvPbJHd7yVSYoNz8w1zt2caPrD8f7DcQGzc/m tvxy6rVKtRNSS6v5vZyo6pfbw568cI2XUqynrOlIZyNExpI/xCkbL7N+ornb/wzzneiy OggTUkEjUt8sqyvkqVtsJMMSRQ8C84XSJiFGfMVVkbX29n3cMZlkUMeMpsPFgPBHyXix 7zow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=IxoEKJOUOQFmvYGa36soNK+UytaHxHgyUxN5OgIsxow=; b=tK/2HpWZPGfphGIgJCN9XyH23DwYgS4TdM/P8PYPjpcWOt/seJhbMesXTnpsleVhJC bCnf+8cdqSti7mwsiO7DkC5VjGiyGq5UZX/319al1F15if/vuZCBSYX2rn+TaHMxuGJb afAyX7YjNCo/4yL3aLhRMTAY4kSOPWN3m0oOGf+OTx2jUOMPnMphvtShYUeeTu8oqD1E cDd/wCJ8ff8TrqiDuywuefBrHwaV4uHaBrIkrNUpSlj88ClQE1VxY/qAUyGvRv9XYbAJ yj/F6Gxc5GD97OGlLvNTDVwMRx4In02ANyQ3+wsordjV6fVW9Wd4l/FDhl7mSRvALXfT VngQ== X-Gm-Message-State: AOAM5330JzOSaJN5Dh3Stju89CWDiitfwdEqONC5z9AmdPOYH/fE+5wV b6j1AmpN6qAa8dn8/NJjVDY= X-Google-Smtp-Source: ABdhPJw4VeESk0vVXFZAdTBiDu08om918RRIrwSoRcqramhmtMpz67Fn5+NeaneUm1F9Zk0ljkfvoQ== X-Received: by 2002:a62:5247:0:b029:215:719d:1aed with SMTP id g68-20020a6252470000b0290215719d1aedmr791280pfb.52.1616437514134; Mon, 22 Mar 2021 11:25:14 -0700 (PDT) Subject: Re: Working Group for Secure Boot From: Bob Eshleman To: Xen-devel Cc: Andrew Cooper , Olivier Lambert , Trammell Hudson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , "Daniel P. Smith" , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Roman Shaposhnik , Christopher Clark , =?UTF-8?Q?Piotr_Kr=c3=b3l?= References: <9280f0d0-e994-71c1-9482-63f97296acb7@gmail.com> <1039be05-cbf2-95aa-5eba-246fb06be8e5@gmail.com> Organization: Vates SAS Message-ID: Date: Mon, 22 Mar 2021 11:25:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hey all, It looks like the following date works best: Mon. March 29th, 16:00 UTC The meeting place URL: https://meet.vates.fr/xen-lockdown Feel free to let us know if the time presents a conflict. -- Bobby Eshleman SE at Vates SAS From xen-devel-bounces@lists.xenproject.org Mon Mar 22 19:09:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 19:09:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100449.191359 (Exim 4.92) (envelope-from ) id 1lOPuz-00035T-4B; Mon, 22 Mar 2021 19:08:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100449.191359; Mon, 22 Mar 2021 19:08:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOPuy-00035M-VT; Mon, 22 Mar 2021 19:08:48 +0000 Received: by outflank-mailman (input) for mailman id 100449; Mon, 22 Mar 2021 19:08:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOPuy-00035H-3n for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 19:08:48 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown [40.107.7.77]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 50860b29-d22a-43af-a5f3-594a3a79bd55; Mon, 22 Mar 2021 19:08:45 +0000 (UTC) Received: from AM6P194CA0103.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::44) by VI1PR0802MB2287.eurprd08.prod.outlook.com (2603:10a6:800:9d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.24; Mon, 22 Mar 2021 19:08:37 +0000 Received: from AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8f:cafe::c1) by AM6P194CA0103.outlook.office365.com (2603:10a6:209:8f::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Mon, 22 Mar 2021 19:08:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT015.mail.protection.outlook.com (10.152.16.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Mon, 22 Mar 2021 19:08:36 +0000 Received: ("Tessian outbound 6484dad39064:v89"); Mon, 22 Mar 2021 19:08:36 +0000 Received: from 8ca154a56113.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2D163889-3DDB-40BD-984B-3D7808A0F3ED.1; Mon, 22 Mar 2021 19:08:29 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8ca154a56113.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 22 Mar 2021 19:08:29 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) by VE1PR08MB5069.eurprd08.prod.outlook.com (2603:10a6:803:105::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Mon, 22 Mar 2021 19:08:22 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642]) by VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642%4]) with mapi id 15.20.3955.024; Mon, 22 Mar 2021 19:08:22 +0000 Received: from a75445.arm.com (82.8.129.65) by LO2P265CA0099.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.24 via Frontend Transport; Mon, 22 Mar 2021 19:08:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50860b29-d22a-43af-a5f3-594a3a79bd55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WtCUcluG2i0OOfOxFYabbi/hVb+K2lHtBjvpxI/FEiY=; b=bouSnlQxGmG/xxaruTw+Bz2G+eZ8sIqV6VGrsAwNT0fHS8znw2oxjS7KRErWy6ap3OI64dEbdlwoXwx5PlIapDCSuoe0+UR56G/CzVWip5KmL8IoRKvc6lIuNgqZjWu75HwPpvlBrsjchsdd3lEU3F3hsNPrfw8BjiWA+wirr2E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 59742b422956e216 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C7r3anjIiLY/yoT0epNoWdiRvTUIluORJDLnQm+teikzqFO1WCXTFSX21xp8gn0lv7Ct+SLMZJZxGhlUv6xbSwiF0Dyu2RhJQXGyqxPlShvGpj8epN8kycabVqRN1nu4iP8RQhe40ERSz6Grk9O1zsUhttg0KZiE4Z65gZUufapx3VnpS/5ZHPmhZ8D1vWGQUaswjOyDsNXtGWlRLiT9f6lAi6NttdLsW1gK2gJBKIUQ1V1VGdJIMbenIVAMRueYdpHCZOQPcN+gMmbunVgZ7T2IDfBl/WSW4FBs4m8Fk398/5Tsxc5Xh6dRgenWW5pVWeoFhWIFayKEZ26uX4PH5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WtCUcluG2i0OOfOxFYabbi/hVb+K2lHtBjvpxI/FEiY=; b=bbmkLbQ6XCLPErJXezru1zSDqoLrPvYepa2NvIa+hW84AOkCcbeeb/h5AEMPeZ5QPo1fQ96eAjw3tlSnnBV4wCrF1cUvMpI3Az6L2LZRtjFH6o5H8g8H+OgVI6rsLQGKFwTQ3osJ9IYR9td/TM03pq3PI0g5n7WvLp0ciQiSEiVJcXlORvjmvRJaVmAV/dxs6/XIsPHEq2za+JhAPOHnDatY5HK7t4Ld+UKb0JPE6tqQiw07+zy2lZ1fKiGHdrG1XzybE6zfQDlqp8f3qjXGf4u7JRJhqM/zv9g+0YzWNktrOphocXQ/mk2GWqRFChX5WSG2y+5yH1dDlr1GJM18Kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WtCUcluG2i0OOfOxFYabbi/hVb+K2lHtBjvpxI/FEiY=; b=bouSnlQxGmG/xxaruTw+Bz2G+eZ8sIqV6VGrsAwNT0fHS8znw2oxjS7KRErWy6ap3OI64dEbdlwoXwx5PlIapDCSuoe0+UR56G/CzVWip5KmL8IoRKvc6lIuNgqZjWu75HwPpvlBrsjchsdd3lEU3F3hsNPrfw8BjiWA+wirr2E= Authentication-Results-Original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 From: Luca Fancellu In-Reply-To: Date: Mon, 22 Mar 2021 19:08:13 +0000 Cc: "xen-devel@lists.xenproject.org" Content-Transfer-Encoding: quoted-printable Message-Id: <2BC82A95-DFB9-4F90-8CC6-AE39405157ED@arm.com> References: <1FAD6C91-2B3A-48F0-88D7-CFCFC8B53BA9@arm.com> To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO2P265CA0099.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::15) To VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0e195c13-154e-43a1-ef01-08d8ed65e55b X-MS-TrafficTypeDiagnostic: VE1PR08MB5069:|VI1PR0802MB2287: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mkRXV0dba+2BrECMtMwqQ1/smNFVJ1le6KD+QqBvLsCBuUDo7W5euU4YLDXm9hPBnC3zShRZlx6Fz/hA/sweE/p6jwhKstK9rnLY5QeOorQxkyOzhnsJQ1EY4sKVCJsE8r6x6zW3As/2TC18aAJVWl9jN1Sopoal04srTIBIz2xwz/rpSwFmS+HeDHE+ljLVIm6tjgvsEx8yn+pTQBQf2OWHwCfMC+UGdhgMN1fKUZZtcDn4cG1anrQrMvRREfAbhZE7wY9OJqy4BkNmjcpRYnoiwvFDY3VpiXUtWZBiuiuFhwPx/ssZbKcOr4ESqrHMB5Lgz9/QSY8wtqAGM+I8nFiVnU28Nnj4oL11ZLGqPgXBo4O7bO2zeWYV7RRsU/hvuCBKlrpfm7oPZ8b7gnzvf2vRKFg2PzW295PanjdSZoNtusiNQpsjEMLL/73FuHkiJk73z84eaxnir1W2ffdnWwZ+NvMXgsbXQ6Xc2WGhlOjPrcsFvnYdM76P2njE5z5+j9FEsQFd/TvRke6F1myJttf5PEAFz6eaH7GsgfK0ZkmGHv1IujB/uP1RMHfirXoV17Lf0K/oNUzhQqyfJdE2+vq2R3jYShq0u6L510WS6g7Lu0d9qUT0DVe+loHRvorCF6IN0NsieWEXo3YLrHKZsvgTvHcCKJHkn4MUUgzaCaZlBPRlrpiDp+IOYKEyn37BT8xc43luKeckPcZszv7fz4IAfN3zoV7M9GICWhXCygS6ysgUqq9lXr9ruqugnPhOdSrJYbCv3PRmVxmCy+QBVg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3629.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(39860400002)(396003)(376002)(136003)(6916009)(966005)(36756003)(8936002)(66574015)(44832011)(478600001)(52116002)(38100700001)(4326008)(7696005)(6486002)(83380400001)(5660300002)(6666004)(53546011)(956004)(66556008)(66476007)(66946007)(16526019)(186003)(316002)(26005)(86362001)(33656002)(2906002)(8676002)(2616005)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NFFLTnRXV1dWN04vOXJLVjM5WmdsbnRheThnMWlRZVptQ21Kd3dSZXA4R2o0?= =?utf-8?B?bUE0cGNlaWpOTlpxMzJDZE5PREdFZStQZWFtc3hhOWtWajhDSi9oQWdQaVJm?= =?utf-8?B?cEVlVTU3Z2Z5cnhxck9kcU16eUovN3EvRnI5SGZVYUc1ZTB2ZHphblR3cTRp?= =?utf-8?B?NlpFTTU5S0ZlUGtPaXdseUlXZi81bzJ5TzBiNmFaQ2ZKQ0xTWXowSEh2aWZU?= =?utf-8?B?MWRaaDBwQXRFakdVK2h0d3pnajJ2K1VWZlhaTHFPNVRucnBHVUVHRE1GcFVH?= =?utf-8?B?SUlwQ0tRYjh0TlM4QjFLdGZhdm94NWxpZVdmTnY1WisyRC9mQjhxUk9MTjE0?= =?utf-8?B?TGh4MkdlMU13citsZ3NjTHZNWng0RExJd2tLeGU5b29icWhhRjJNeEZhM0hD?= =?utf-8?B?MGpDNnNleFFXYkJWcG0vRVpXOTRJSWdiUm5NWjZnWDZsK3h3eFBpWUZnckV4?= =?utf-8?B?VlRXQ0RxN1hYN044c0VPSnY1dEpZL3pycDVCM01hZnU5VTZXc3R3d3ZCbzJr?= =?utf-8?B?ckNrTWJGeTZWdlRORnhPZitXYzY4S2RMaVJKbzJuYjJyVjE3ZGhwbHU0Rmtv?= =?utf-8?B?TFJIVEdSc201dzZVY1dYaWVBcXp3VmR6Qkx0cnZ4TnN2R1AwSzh3QmI1b1ZC?= =?utf-8?B?VERSNTA2MW5UM3NvVXBpd3JnWkw2SVYwamYxOE9NdTljNEpjT09FSXN4eFZ2?= =?utf-8?B?VWdWaVJuUDNjT2FWOWNpOVNOcHRuaGIyWlZPVm5CNkNCNFBDbCtvbmFUVFR1?= =?utf-8?B?ZTBZendhcW4yT09MZlY2aWZuTkV5RTFZZXFIcDVYYVhFMTdmOEU1ZzJXZjJj?= =?utf-8?B?Z0toakZPZVA4QmhOTmlXQWxlUjBhUitMN2M0WTdFdEN4b2FzM1FzOEVwZ0dx?= =?utf-8?B?UlZsS3BTNG4vQmdQUElLUTdiRkZ6bStKQWJrT2NiMXQ4bTg1ZDJjN0J4bjFq?= =?utf-8?B?a21YZjFNT3RhUERVMVZrRFRwVXNDTEx4NG1uYjRDdUxjcDJxTWJucUF1bGgv?= =?utf-8?B?VTJwNm1uYTByQ2E2WHcrRy9qY3ZKQ3g1SUJrMHZpWVpBQVZTa0c1MndGSGFv?= =?utf-8?B?c2VTL3hVamY1VVZqMmNNR0tHL3dYQUJNcjFjVmFUVzN4U3NhWjFNZU5Yd0Vn?= =?utf-8?B?MnZrUnlOTURhd0JJQ0JmNFlvVlJlcTZJUjhPakgrWXlnS2ZnczVTNlZxaTFZ?= =?utf-8?B?cDVMVzkvc2pCdnMvRS95NmdJVlRLK1hWd0JqS253SWh4MDMvS2JWY3JDSEQ2?= =?utf-8?B?UkNxMks1VUxuUEVoclFwWWlrRkFSSCtyQlViWmp1VHcwVmxyeTN1dElaMEEz?= =?utf-8?B?R2tOTlhRRXlwWkZRdVBCajVXcFdEVGE3UXNndU9pazFXbUpkL09ZdS9paDFR?= =?utf-8?B?b2FManV2UENsamlmTnhRYXRXbWFGMTVCZDNIeWh4QXVPazJNdEtGT2p4VEhR?= =?utf-8?B?bm1VZ1lPQnpQVnpKWWhrdmlLTlVvZE1ybHpORjRSQktBVC8waFdBZkhlYUs1?= =?utf-8?B?ci8va0VJV2VTZEM5UXE3SmdObUExNG1NVEIzd1NQY0g4eXhwR2pXUTlFZlJC?= =?utf-8?B?NVNZcVl5TjVoQnc4OTJmd0JWL3ZXYTc0MGJreWFKS1VsWlNuTTRqQnFydEhJ?= =?utf-8?B?ejc0UDFUQVM3WEJGRW93YmVCYjdyOFErV1hLZUVURlZ3REhCM2hNRHlLdElJ?= =?utf-8?B?RlZrU1hqYkFGUktBRVRzNTRiUENOUHpPVFIzTnVxNUtwNVMzd21tTld3RENG?= =?utf-8?Q?S2yIzdCGB9Xwafk/sDdPyHjRdY6O+qUSdKqEc3h?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5069 Original-Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f76566b4-aa5b-4eb2-4be3-08d8ed65dc30 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S5YksgIdxDOlPm8cyKXWaRcaIfPALz69TEyiu8veyRPuLZ96x5yw0FZdAhQkI5tQvalDc4828QAhMoKLY4yZVz1btKq7iSFe+4Ol+0yy0wl5jBNbb5kStTwCoWaJt1sota2uKWQo4UoJiVqjat/+vJe8i7FsJBDYetETD0UxeXlouJlFzTSOk0SgqTVlcRFmP5iiGwHgu89NbjRKyxuz8ZgXHMtgr8XrW8CloHpNQZT7g1n41VUy5vDP+wp2nkuA57xnnTMIXHu/iTJKc+RrTNz/3oipHNTkicvdLxxtBVm/XqQBrDiX5LmnDIWNicTWbtAY9oBr6aOSdFHox4TJ6ZTS8TJCp/Pw/OgUz2Vf7xAW8kzQkjkgyKEX3NY8k+eA9aPGmcVot0xNRriu8dBgdX3qfrGNh95PXRj2ZgqmaMWEay2gqRGUse0EBfG50SWozNEMyV9+5vsZp49QF1Qx0zcogYtZLb9/56wzKvsJPcj/+RX7emUqrIcjOrAdgkB7EUJgybdSGHmFp3KnbC+V4gV/XzDszmIpZ+tYcH+sZ4YpnkAYSCNRuSSBo50odbUe3MN37oJruQr19JiEOBK9N5qH3EZzt3UvoehKlrmt3LMrGPNu0J5OeTefSUL1xN4Vbd52w1WBS4PpW3L+0aEG1pEvA+sswbKNPC+UjPG6GhtW5wACJ3a96Xnkz5/945jm7UtOiHDfAjCjVBRWv/BCrfF/gP71zhzB8n0PbvwQGm0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(39860400002)(376002)(396003)(346002)(46966006)(36840700001)(86362001)(7696005)(82310400003)(70586007)(8676002)(33656002)(2616005)(44832011)(956004)(70206006)(356005)(5660300002)(186003)(6862004)(966005)(6486002)(16526019)(36860700001)(81166007)(8936002)(47076005)(2906002)(66574015)(83380400001)(478600001)(53546011)(26005)(4326008)(6666004)(336012)(82740400003)(316002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2021 19:08:36.7792 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0e195c13-154e-43a1-ef01-08d8ed65e55b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2287 Hi Juergen, Yes you are right it was my mistake, as you said to remove the BUG_ON(=E2= =80=A6) this serie (https://patchwork.kernel.org/project/xen-devel/cover/20= 210306161833.4552-1-jgross@suse.com/) is needed, since I=E2=80=99m using yo= cto I=E2=80=99m able to build a preempt_rt kernel up to the 5.10.23 and for= this reason I=E2=80=99m applying that serie on top of this version, then I= =E2=80=99m removing the BUG_ON(=E2=80=A6). A thing that was not expected is that now the Dom0 kernel is stuck on =E2= =80=9CSetting domain 0 name, domid and JSON config=E2=80=A6=E2=80=9D step a= nd the system seems unresponsive. Seems like a deadlock issue but looking i= nto the serie we can=E2=80=99t spot anything and that serie was also tested= by others from the community. Do you have any idea on that? Thank you for your time. > On 19 Mar 2021, at 11:54, J=C3=BCrgen Gro=C3=9F wrote: >=20 > On 19.03.21 12:50, Luca Fancellu wrote: >> Hi Juergen, >> Could you confirm that back porting this two serie to the linux kernel 5= .10: >> https://patchwork.kernel.org/project/xen-devel/cover/20201210192536.1184= 32146@linutronix.de/ >=20 > I don't see why this one would be needed? >=20 >> https://patchwork.kernel.org/project/xen-devel/cover/20210306161833.4552= -1-jgross@suse.com/ >=20 > This is already part of 5.10.24. >=20 >=20 > Juergen > Cheers, Luca= From xen-devel-bounces@lists.xenproject.org Mon Mar 22 19:09:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 19:09:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100453.191371 (Exim 4.92) (envelope-from ) id 1lOPve-0003Bc-Eh; Mon, 22 Mar 2021 19:09:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100453.191371; Mon, 22 Mar 2021 19:09:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOPve-0003BV-Bb; Mon, 22 Mar 2021 19:09:30 +0000 Received: by outflank-mailman (input) for mailman id 100453; Mon, 22 Mar 2021 19:09:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOPvc-0003BN-SW for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 19:09:29 +0000 Received: from aserp2130.oracle.com (unknown [141.146.126.79]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c7b693f7-0dfd-49da-82cb-2781285e916b; Mon, 22 Mar 2021 19:09:28 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12MJ4AxC094132; Mon, 22 Mar 2021 19:09:25 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 37d6jbcphn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Mar 2021 19:09:25 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12MJ6MrN041457; Mon, 22 Mar 2021 19:09:25 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2106.outbound.protection.outlook.com [104.47.70.106]) by aserp3020.oracle.com with ESMTP id 37dtxxaw7k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Mar 2021 19:09:24 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by SJ0PR10MB4734.namprd10.prod.outlook.com (2603:10b6:a03:2d2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Mon, 22 Mar 2021 19:09:23 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3955.027; Mon, 22 Mar 2021 19:09:23 +0000 Received: from [10.74.101.211] (138.3.201.19) by BYAPR02CA0037.namprd02.prod.outlook.com (2603:10b6:a03:54::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Mon, 22 Mar 2021 19:09:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7b693f7-0dfd-49da-82cb-2781285e916b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=zPn+iu7Ye/W2MmnTGOHRETUDtVmPyAC2+mP2WpRSSlc=; b=Vy2stZql1bm9ynr2mTr5L2alkQqsZTjdWZoXNTOkaPBkG7gO6pW1aTy52JCzbN/wNKi3 QVzV4BBC0sqQPhvmKW9pZaRuqto+jfoLqb/dim9Q7b5VQs8rZy3qom7jTsGIM8Od6Eza +kEsku5K5O9Olq92mmtXyxmmEs016exyfAeBHqq5iI+XGcAQxWjiujg5qwMWolxOmAkZ x9RyfHDn4oFTeY9sL2Ej8K5B4CyYe+9okgIOrlufIiqc5mULo4T9d3hwiJcczzExv1uz NgnbsIv9iVODkA5yBgZOLP9Yu7JUgiPeS6u6dSTDNZm121iKPy8FKSWyb5o0HDOe3Buz tw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dMR45aSgKcP5hzx158TFPS5rNSwIt2R2bTvgVLkeGWvKfNNuon4wVhhAjqI4JiMkYj9XAtPGziqS3/4rXvoZb7hYcSTDUbCDfLjjUodtVyRnuSklZb8c8x0LMFgWSzmzbR9H83w121XRDx/wucow84lV5Ok4siTN7vGe+GJWHGGQnK7wfDm6BkpWWDpWBq+bNJHJpMqX8dJhrtCaSPhNZ+ow1mpSTHSVTT4cuXwsex8JLRHWD5ASG8FRrBIJOvj1dhVWquHQ9jGZCoXrHSTBs/Uq3jHr8Cdt1IRXdmLTXkB2fkZKdME6DUDcHcNDwcg1Z2bkau3BAhKZM2G5QHT/Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zPn+iu7Ye/W2MmnTGOHRETUDtVmPyAC2+mP2WpRSSlc=; b=ik2CvQfGEHkAQYrJUVpxPWv00z2yzLIRSw6tXFsVjVmm5TvCG4SahPmPfMDlzPAWqxzZI7MckaqvaypljtUlOdLibMRItWO0pfQ1Ho3qNJmFcO+//NQsx5QKfJQDNcEBFA+uLdMnh44GicggznVyHfH4Aj7P8cHDI7yzUvaA//jkpw9kAC0grcrp4u1Y7I9l2wgl167QLo/tB8wsdvsZmNTWJ9WQ4lXMU0bziye1U+j4FhIJoODPM9U5Devd4jU548ACm2sgCvGnaYwFFwyv7GCWBuYel6/MJbUOc65J6+9sekvx1l06Pzg6pFXNGNvbFagfQVZIwYQNby2f69e4lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zPn+iu7Ye/W2MmnTGOHRETUDtVmPyAC2+mP2WpRSSlc=; b=pqbrbdTi16q6ItNk3cOXvacNXKnXvUROuLoA8jATY9xdXktRz4Q7Gjs25GDCgJaMXVDu3fkvZQ6zgi+5KFKsfXvVTQDR8V4pIwfo7PPvnxR7nqLlFNKWiqy8pTgUj15Sm0esc6NhALE12Sc0TkHHJu2b6x5N9BxA6PZXqkxnig0= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH 2/2] Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" To: Roger Pau Monne , linux-kernel@vger.kernel.org Cc: Juergen Gross , Stefano Stabellini , Jan Beulich , xen-devel@lists.xenproject.org References: <20210317110401.46322-1-roger.pau@citrix.com> <20210317110401.46322-3-roger.pau@citrix.com> From: Boris Ostrovsky Message-ID: Date: Mon, 22 Mar 2021 15:09:19 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210317110401.46322-3-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [138.3.201.19] X-ClientProxiedBy: BYAPR02CA0037.namprd02.prod.outlook.com (2603:10b6:a03:54::14) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0c92eae6-9992-4f4c-615e-08d8ed6600bf X-MS-TrafficTypeDiagnostic: SJ0PR10MB4734: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /2oy0h82ICFEHtw/Hsn+JHrTDQfGEegVPbzJoNqmX/Yyjn3yVU5sSLL8rFH76B17v9siLMTDXzlieeISMzmzfaiEDcuV1Xa2Islrx3pyqzIciOcYuxQ/w6mcwt29HlONd3ccjVm3HNVtG/OGjxc+zS3yziTT1acrIW6jrr3eDQGEID5ywilrXDP6x5uLiv1N3D0/1t3p/H5e1FUu09lm5UcoGKOJ57It4dkax00zbEFjkKU45hUA4EGaG1OKX/KFbsmT81SaEydv1f2aHoeAF/J3hwRvxrA/ldFoF3tfuvpEY9UNQFzo7EKcZvkmfPJ+fscbS6qdLUJ21Ds/TDBk9LiJA2cO7KCTIoMXEpEQm9h+IGqreBgHuyfs6GI46n5+hvn2lXgWQiEqikXzwYDt5A+/8PynR4/crNo0iQpL/PqMOZZvvscrJWSmT7jv1DJ6pih3pjzqCXgwcgcqZRs4W2WSyFhZsCNOCmYGiDQ0FWkomOrey7ai0cb0mhPx7AJNyxmM9wOZp8wH3Tgamv79DyuQphNRHgWyGHpTuBlpChdRB1WQ6UvVY1xDAZcjAJertDr8kk1LHM5hIyAmTIgnC4rd7zD6HgdKuz6y4QPM1voHdsIj3ZUnmJdJ7bhgvO9s23RbZtzn/oB9s2sjov8xI5b+ErmIVssEq3YLfpr1FL5mprg/yuTR34PiT70qGMWfNCwj+4Blc4Id5pYb8n9dXTezd5WzCmAaT3szjbSr+1s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(396003)(376002)(366004)(39860400002)(6486002)(478600001)(86362001)(8676002)(66556008)(31696002)(83380400001)(2906002)(38100700001)(8936002)(31686004)(66946007)(66476007)(4744005)(316002)(16576012)(54906003)(5660300002)(36756003)(53546011)(44832011)(2616005)(4326008)(16526019)(26005)(956004)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZFM2M3lSbHhDZTh0NE9KVnh5MjUvTnJ1bWswYk9KMFJadWNZSWN2QUVTbTFk?= =?utf-8?B?SnhmT0U3RnA0a3N1UjhjV1kxU3B3QWhJbGw0azRPZWhzVVZsNHd6QzdNSmVq?= =?utf-8?B?QVIxUGRHVzFXMVExbWdyNnMwOVNjUWhKb3k4NVNhN2l4OFNlMWJVaStzNUxh?= =?utf-8?B?N2J2Wjk2NjZoSDFPVGhPKzhseFAyWk80bWJKYjVQUUFIck1iN21mVGk1MGFT?= =?utf-8?B?am0xeWNibnZhMkRuTjdEMWdqYWJ1aW1pUXh6d0YxbXUwSHdxSnVZNkNKRXFF?= =?utf-8?B?RXdBSFdiOFFDUFloUDl2OEEwRzhCK201U013dVlDRWxTL3ZiQ2YxT3FiVzYx?= =?utf-8?B?MzZJMGNVNnFyNW1CbHVrUGNhdEpHcXE1c2NmRzVXTTlKVUtPMnphQStoNE9z?= =?utf-8?B?VTU0c24yWXgzRGRHaWFUR0Q1aE9JNSt3U1hjS1VLV1RETXcwU21NbkZPN2JN?= =?utf-8?B?Wm9FMDNjKzUreHU2ZU92Q1ZaR0lmZkk4K1MyKzlRNHdZait1ajNmaStkNklw?= =?utf-8?B?aHg3KzhMM3N2cmllTnVXdmNvYWtJb1N5TTJOL2hCYW82Q01KVkpCWlA1SzNM?= =?utf-8?B?S252bFNCdFpGYmVldU5IR1JFMmNLK1RUR0NkTWZLbW9JYk51SHZoWnpMV1dU?= =?utf-8?B?cHJXeGRBakhSWUdHVk1MVEtHTUxSazlnanVlOC9iV092QlRzYVJUMktDTjVY?= =?utf-8?B?TlgyQnJXejRyZnZ6YktlOEgwczh6aVJucDhxVEo2UXl4NUVHNHJ4d1JyRXlk?= =?utf-8?B?U25udFF4ZjFHRkVCOXNWZHpjYit3VERjbkE5aTJDU2J5cFFxdnplTjVHZ3pV?= =?utf-8?B?aEdiMlJ1RTJ5dWZ2eEN3WmJSQnRqaG9FcFlOMjRhWkZkaTRZdDI1enJRMm9u?= =?utf-8?B?RjZMR1dXSTRjU1pVcEN3N0h4Rit2djJEWFBROHhwMXFrNFlXQXZtMG1wcERJ?= =?utf-8?B?aG1RQmtPMmt3SlpRNUw3cTFMc3ZTTUJza3NtMmhLZS9yRThjYUs5TUtqS2k0?= =?utf-8?B?MVJSekJQM1hNVkdldndCVHQ0QmZmdE4rTlNsekFYdmVlOExYbkZ2QWR2VjZ6?= =?utf-8?B?NzJtYnJHY0dGVzRodnZ3eGF1aDVrZkRsQit1VkJmNFZnUzBiR1ZoY0k1TjU3?= =?utf-8?B?Q3RiY3pGL2RVMk5UeHBTb0s2TjRXY0JqMkIydG1md25BdzVBbVNtVzNBRGJq?= =?utf-8?B?VDlxYzdySVZ3THVCQ01iaVNDRTdwVk1rMUQxbW1taW1GU3lPVHdzUUFsYlpP?= =?utf-8?B?bGdrL1dhcGtyYnh6OGcxWkkwd0RiUk9sSUphZ3JTTDd3c09uSmN6ZUkzcnRm?= =?utf-8?B?bTZQVzNKa25BWmpnNGN2aGs5ZnlWOEo5a3pNd0tEdVhFdyt2VG9mMjNkS29U?= =?utf-8?B?NXVFQmV1ZFlaV3M2WHNpR3ZVZmg2UmhXZG9rL3FDT1NlSDZ2ZzdsZ1FvU2k4?= =?utf-8?B?SEFKZEJUaWxXd3U4Z1pMWnFiZFFqckU3UkMvQnRqaEJZdzA0WjQ4N0hEK1FY?= =?utf-8?B?MUwvWkkwZ2FuRGRJcmgyYkhrK2F2dUxodXNLcllWSWFvb0pLaUdwREpUV1lI?= =?utf-8?B?S0EvbFRkU1IxRlpJY2M3ZmZUd2ltSnR0dFltZnlwR0RPbExWMHc0L3dla0pK?= =?utf-8?B?SmdiT2pPTk9WNElzT1hkS01CZ3E0RU1nM0NnWmlVSEhveXZzaXR1Y2o4YlRm?= =?utf-8?B?VFIyZXY2akJCRk5XZGZhU2l1RnVrUkdpZHRlVUhzaWI5M0k5NjFiazlpMGpD?= =?utf-8?Q?71oh2UHPMrjDTVnhS8j/lH+qCGeSeTn82K4xAaD?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c92eae6-9992-4f4c-615e-08d8ed6600bf X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2021 19:09:22.9293 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jugGJqx/9G8W8EXvsQ6CXeCINi8keBJ3znTjGh+chSi6fxNhN7JcH94tOPyKLGW3WP1hte2T93L1W6N6iXtEp7kyhxvcVG664En4ZQOOBaY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4734 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9931 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103220138 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9931 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 adultscore=0 impostorscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103220138 On 3/17/21 7:04 AM, Roger Pau Monne wrote: > > /* > - * Clamp the amount of extra memory to a XEN_EXTRA_MEM_RATIO > - * factor the base size. > + * Clamp the amount of extra memory to a EXTRA_MEM_RATIO > + * factor the base size. On non-highmem systems, the base > + * size is the full initial memory allocation; on highmem it > + * is limited to the max size of lowmem, so that it doesn't > + * get completely filled. > * > * Make sure we have no memory above max_pages, as this area > * isn't handled by the p2m management. > + * > + * In principle there could be a problem in lowmem systems if > + * the initial memory is also very large with respect to > + * lowmem, but we won't try to deal with that here. > */ This comment looks out-of-date in light of deprecated support for 32-bit PV. So I think we don't need to revert this part (except for the macro name). -boris From xen-devel-bounces@lists.xenproject.org Mon Mar 22 19:40:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 19:40:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100462.191401 (Exim 4.92) (envelope-from ) id 1lOQPN-0006nQ-5F; Mon, 22 Mar 2021 19:40:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100462.191401; Mon, 22 Mar 2021 19:40:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOQPN-0006nJ-1Z; Mon, 22 Mar 2021 19:40:13 +0000 Received: by outflank-mailman (input) for mailman id 100462; Mon, 22 Mar 2021 19:40:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOQPK-0006nB-Rv; Mon, 22 Mar 2021 19:40:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOQPK-0002X3-Gc; Mon, 22 Mar 2021 19:40:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOQPK-000510-9P; Mon, 22 Mar 2021 19:40:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOQPK-00010M-8u; Mon, 22 Mar 2021 19:40:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iqKCWUgW/2rxZswSkvRXt5DDXDeB9Uln888Wi5gXd1A=; b=seXTT77ONMbIBPE7vqaVJf/ybW 4yYXd1yHaftJUROqt4wi2Ye2dL2kMokjqA7UCPtezCgURsdBpxaLWXHRm2xuXTWrz0VsD/e5dReoj 0nr9T0quIYfseeunZDvJlC/avmypZhLMPP6lMWEKWcHTEjyWS0CsQcKaw6xDoZCIvR9k=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160249: all pass - PUSHED X-Osstest-Versions-This: ovmf=3d0df0f076e120c6faf3c1892fffa21b4f31ed84 X-Osstest-Versions-That: ovmf=ca318882714080fb81fe9eb89a7b7934efc5bfae From: osstest service owner Date: Mon, 22 Mar 2021 19:40:10 +0000 flight 160249 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160249/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3d0df0f076e120c6faf3c1892fffa21b4f31ed84 baseline version: ovmf ca318882714080fb81fe9eb89a7b7934efc5bfae Last test of basis 160145 2021-03-19 18:44:15 Z 3 days Testing same since 160249 2021-03-22 01:39:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: VincentX Ke jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git ca31888271..3d0df0f076 3d0df0f076e120c6faf3c1892fffa21b4f31ed84 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Mar 22 21:27:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 21:27:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100475.191437 (Exim 4.92) (envelope-from ) id 1lOS4n-0007p7-E9; Mon, 22 Mar 2021 21:27:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100475.191437; Mon, 22 Mar 2021 21:27:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOS4n-0007p0-AM; Mon, 22 Mar 2021 21:27:05 +0000 Received: by outflank-mailman (input) for mailman id 100475; Mon, 22 Mar 2021 21:27:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOS4l-0007os-R0; Mon, 22 Mar 2021 21:27:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOS4l-0004L5-H8; Mon, 22 Mar 2021 21:27:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOS4l-0001Rb-8C; Mon, 22 Mar 2021 21:27:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOS4l-0000JC-7h; Mon, 22 Mar 2021 21:27:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hfMJUHp/uS3UmvVy50HRZX4rJADa+Njlllq3pu/Ey04=; b=LHiHURa33x7ReQg4yek2lWd+dO 6wosC/sjPe9l+9LrhceqR7bm9lETFxU0kYGrWcWZ54Xr9wrUwNwpIinxLoboAK5o1Ef+wiUp+C9F6 NAlL8WuFOTXUAZYaR/lf2xpcP6qc9HSoynqatHI48imlNk4de3gePTmx+abrxVOZrMlM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160170: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Mon, 22 Mar 2021 21:27:03 +0000 flight 160170 xen-4.12-testing real [real] flight 160343 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160170/ http://logs.test-lab.xenproject.org/osstest/logs/160343/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160343-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 34 days Failing since 160128 2021-03-18 14:36:18 Z 4 days 4 attempts Testing same since 160150 2021-03-20 04:11:48 Z 2 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 22 22:09:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 22 Mar 2021 22:09:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100484.191452 (Exim 4.92) (envelope-from ) id 1lOSjl-0003IK-WB; Mon, 22 Mar 2021 22:09:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100484.191452; Mon, 22 Mar 2021 22:09:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOSjl-0003ID-TA; Mon, 22 Mar 2021 22:09:25 +0000 Received: by outflank-mailman (input) for mailman id 100484; Mon, 22 Mar 2021 22:09:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOSjk-0003I8-PC for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 22:09:24 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 4120a9e1-40a9-4a74-a38b-f866095f9450; Mon, 22 Mar 2021 22:09:23 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-561-of8FnGqCMB6H2Ad8KT-cDQ-1; Mon, 22 Mar 2021 18:09:21 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7AE631007467; Mon, 22 Mar 2021 22:09:19 +0000 (UTC) Received: from [10.10.117.181] (ovpn-117-181.rdu2.redhat.com [10.10.117.181]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3D7B360BE5; Mon, 22 Mar 2021 22:09:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4120a9e1-40a9-4a74-a38b-f866095f9450 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616450963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dJZZKC0AcGAtD/3j9IffcYlWsC2MGI85T7Z7r3MA1rc=; b=J95leSl0TWBcyeTYYX+2idqkhgFzyeuBWK0gJxD2f9+reyv5TeJlLneUbNsnGC5gbLHalc cZ8KBlxLzYCRgypb39Bajjb2dQyDbVqwCYg84Psyjb+H+HYDBVdFQIR0zAlvvUZgAf8i1/ S3IplrShfoN34WdqxeBdIn5N4upZ2uI= X-MC-Unique: of8FnGqCMB6H2Ad8KT-cDQ-1 Subject: Re: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs To: Olaf Hering References: <20210317070046.17860-1-olaf@aepfle.de> From: John Snow Cc: xen-devel@lists.xenproject.org, qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefano Stabellini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <4441d32f-bd52-9408-cabc-146b59f0e4dc@redhat.com> Date: Mon, 22 Mar 2021 18:09:17 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210317070046.17860-1-olaf@aepfle.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/17/21 3:00 AM, Olaf Hering wrote: > Commit ee358e919e385fdc79d59d0d47b4a81e349cd5c9 causes a regression in > Xen HVM domUs which run xenlinux based kernels. > > If the domU has an USB device assigned, for example with > "usbdevice=['tablet']" in domU.cfg, the late unplug of devices will > kill the emulated USB host. As a result the khubd thread hangs, and as > a result the entire boot process. > > For some reason this does not affect pvops based kernels. This is > most likely caused by the fact that unplugging happens very early > during boot. > I'm not entirely sure of how the commit message relates to the patch, actually. (Sorry, I am not well familiar with XEN.) > Signed-off-by: Olaf Hering > --- > hw/ide/piix.c | 5 +++++ > include/hw/ide/pci.h | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/hw/ide/piix.c b/hw/ide/piix.c > index b9860e35a5..7f1998bf04 100644 > --- a/hw/ide/piix.c > +++ b/hw/ide/piix.c > @@ -109,6 +109,9 @@ static void piix_ide_reset(DeviceState *dev) > uint8_t *pci_conf = pd->config; > int i; > > + if (d->xen_unplug_done == true) { > + return; > + } My understanding is that XEN has some extra disks that it unplugs when it later figures out it doesn't need them. How exactly this works is something I've not looked into too closely. So if these IDE devices have been "unplugged" already, we avoid resetting them here. What about this reset causes the bug you describe in the commit message? Does this reset now happen earlier/later as compared to what it did prior to ee358e91 ? > for (i = 0; i < 2; i++) { > ide_bus_reset(&d->bus[i]); > } > @@ -151,6 +154,7 @@ static void pci_piix_ide_realize(PCIDevice *dev, Error **errp) > PCIIDEState *d = PCI_IDE(dev); > uint8_t *pci_conf = dev->config; > > + d->xen_unplug_done = false; > pci_conf[PCI_CLASS_PROG] = 0x80; // legacy ATA mode > > bmdma_setup_bar(d); > @@ -170,6 +174,7 @@ int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux) > BlockBackend *blk; > > pci_ide = PCI_IDE(dev); > + pci_ide->xen_unplug_done = true; > > for (i = aux ? 1 : 0; i < 4; i++) { > idebus = &pci_ide->bus[i / 2]; > diff --git a/include/hw/ide/pci.h b/include/hw/ide/pci.h > index d8384e1c42..9e71cfec3b 100644 > --- a/include/hw/ide/pci.h > +++ b/include/hw/ide/pci.h > @@ -50,6 +50,7 @@ struct PCIIDEState { > IDEBus bus[2]; > BMDMAState bmdma[2]; > uint32_t secondary; /* used only for cmd646 */ > + bool xen_unplug_done; I am hesitant to put a new XEN-specific boolean here, but don't know enough about the problem to outright say "no". This looks like a band-aid that's out of place, but I don't understand the problem well enough yet to suggest a better place. > MemoryRegion bmdma_bar; > MemoryRegion cmd_bar[2]; > MemoryRegion data_bar[2]; > (If anyone else with more experience with XEN wants to take over the review of this patch, let me know. I only really care about the IDE bits.) From xen-devel-bounces@lists.xenproject.org Tue Mar 23 03:12:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 03:12:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100498.191485 (Exim 4.92) (envelope-from ) id 1lOXSG-0000sW-5b; Tue, 23 Mar 2021 03:11:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100498.191485; Tue, 23 Mar 2021 03:11:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOXSF-0000sO-WB; Tue, 23 Mar 2021 03:11:40 +0000 Received: by outflank-mailman (input) for mailman id 100498; Tue, 23 Mar 2021 03:11:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOXSF-0000sG-7U; Tue, 23 Mar 2021 03:11:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOXSF-0004C6-09; Tue, 23 Mar 2021 03:11:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOXSE-0001Gb-LV; Tue, 23 Mar 2021 03:11:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOXSE-0002ur-L4; Tue, 23 Mar 2021 03:11:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L630lOWmk/OYm8hxG5eG1htunkLDGIDAt+spTRj/Au4=; b=OmBxG68xBg03Ghz2NRQg2RQNi6 Mt33o0I9hxb5JkZ1xpKU/gFzsNK/uAV9G17wH4CXPqcO3yNummUf0tuHhaYoYcWdOF/MdmRKHssOI VajJZGR1e7mWjoK/4LeOPCItBN5UyTUBmYgTh47DUJLIxfFVYfYZ8+OskrlYm3cqNUVo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160296: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=dae3c3e8b257cd27d6b35a467a34bf79a6650340 X-Osstest-Versions-That: xen=dae3c3e8b257cd27d6b35a467a34bf79a6650340 From: osstest service owner Date: Tue, 23 Mar 2021 03:11:38 +0000 flight 160296 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160296/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160159 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160159 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160159 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160159 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160159 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160159 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160159 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160159 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160159 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160159 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160159 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160159 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160159 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: xen dae3c3e8b257cd27d6b35a467a34bf79a6650340 baseline version: xen dae3c3e8b257cd27d6b35a467a34bf79a6650340 Last test of basis 160296 2021-03-22 10:58:16 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Mar 23 05:15:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 05:15:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100494.191512 (Exim 4.92) (envelope-from ) id 1lOZNq-0004OI-7K; Tue, 23 Mar 2021 05:15:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100494.191512; Tue, 23 Mar 2021 05:15:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOZNq-0004OB-3f; Tue, 23 Mar 2021 05:15:14 +0000 Received: by outflank-mailman (input) for mailman id 100494; Tue, 23 Mar 2021 01:47:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOW8Z-0000l8-K4 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 01:47:22 +0000 Received: from ustc.edu.cn (unknown [2001:da8:d800::8]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 1d3eeaa0-2052-45cb-ae63-f449f2dd0a6b; Tue, 23 Mar 2021 01:47:06 +0000 (UTC) Received: from ubuntu.localdomain (unknown [202.38.69.14]) by newmailweb.ustc.edu.cn (Coremail) with SMTP id LkAmygAHTZySSFlgFboXAA--.232S4; Tue, 23 Mar 2021 09:46:59 +0800 (CST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d3eeaa0-2052-45cb-ae63-f449f2dd0a6b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ustc.edu.cn; s=dkim; h=Received:From:To:Cc:Subject:Date: Message-Id:MIME-Version:Content-Transfer-Encoding; bh=XcjGkHVa6C nee3IqKp4QVabZFCLc/bBbQsfdChM0o8M=; b=JxgXXgrPjt06IXfD+VfFyt55xH rfybtg0zY7Ipzrz2pOjyfe7kCglsSbH693814QChtOgpNQWSuB7N3OO3dAaFQIMx IsIdu1PxcDfXYiSRTfGLAlWO+2JVBq4p0I3wD/J3isBRHcRhKaJUbWAG+tSys/n7 /g4LCOa5RRLjhk0Ww= From: Lv Yunlong To: oleksandr_andrushchenko@epam.com, airlied@linux.ie, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Lv Yunlong Subject: [PATCH] gpu/xen: Fix a use after free in xen_drm_drv_init Date: Mon, 22 Mar 2021 18:46:56 -0700 Message-Id: <20210323014656.10068-1-lyl2019@mail.ustc.edu.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:LkAmygAHTZySSFlgFboXAA--.232S4 X-Coremail-Antispam: 1UD129KBjvJXoW7Zw4fXw1fCFy8Xw4kWry5twb_yoW8Xw47pF 4fZFy5KrWUtws2kr15A3Wku3W5JanrKa1fGr9xA3y3Cw45ZFy09a15t34xuFyUArWfCrn5 tr9xXFyUAFyDCr7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvl14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1lnxkEFVAIw20F6cxK64vIFxWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xv F2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r 4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I 648v4I1lc2xSY4AK67AK6w4l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr 1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE 14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7 IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvE x4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvj DU0xZFpf9x0JUmNtcUUUUU= X-CM-SenderInfo: ho1ojiyrz6zt1loo32lwfovvfxof0/ In function displback_changed, has the call chain displback_connect(front_info)->xen_drm_drv_init(front_info). We can see that drm_info is assigned to front_info->drm_info and drm_info is freed in fail branch in xen_drm_drv_init(). Later displback_disconnect(front_info) is called and it calls xen_drm_drv_fini(front_info) cause a use after free by drm_info = front_info->drm_info statement. My patch has done two things. First fixes the fail label which drm_info = kzalloc() failed and still free the drm_info. Second sets front_info->drm_info to NULL to avoid uaf. Signed-off-by: Lv Yunlong --- drivers/gpu/drm/xen/xen_drm_front.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c index 30d9adf31c84..9f14d99c763c 100644 --- a/drivers/gpu/drm/xen/xen_drm_front.c +++ b/drivers/gpu/drm/xen/xen_drm_front.c @@ -521,7 +521,7 @@ static int xen_drm_drv_init(struct xen_drm_front_info *front_info) drm_dev = drm_dev_alloc(&xen_drm_driver, dev); if (IS_ERR(drm_dev)) { ret = PTR_ERR(drm_dev); - goto fail; + goto fail_dev; } drm_info->drm_dev = drm_dev; @@ -551,8 +551,10 @@ static int xen_drm_drv_init(struct xen_drm_front_info *front_info) drm_kms_helper_poll_fini(drm_dev); drm_mode_config_cleanup(drm_dev); drm_dev_put(drm_dev); -fail: +fail_dev: kfree(drm_info); + front_info->drm_info = NULL; +fail: return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 05:20:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 05:20:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100517.191524 (Exim 4.92) (envelope-from ) id 1lOZTA-0005N4-0A; Tue, 23 Mar 2021 05:20:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100517.191524; Tue, 23 Mar 2021 05:20:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOZT9-0005Mx-TI; Tue, 23 Mar 2021 05:20:43 +0000 Received: by outflank-mailman (input) for mailman id 100517; Tue, 23 Mar 2021 05:20:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOZT8-0005Ms-89 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 05:20:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e2386b14-b378-49e0-adfa-799cdf4d1668; Tue, 23 Mar 2021 05:20:40 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BC6C9AB8A; Tue, 23 Mar 2021 05:20:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2386b14-b378-49e0-adfa-799cdf4d1668 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616476839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5I+ECwluVxNDYjbroJ18babfeVRF43gPcdMo1xXHs6E=; b=mFaNNH1uo+pz0uBwSXZRBDsfhCJd6SDjvN9fdSVQIDPQ5acOsrZqUUCgPiaDwPzAaX02hP 6Md33ReNwGBW+svmvF7dg4Rt8QFfZhCWLaYYjz6VbI7MsI+I/iTVOk7Pqfoblyi1TQfYWs V0i3IAvr9l4YXnwntux+7VH/NfmJMvw= Subject: Re: [PATCH v2 for-4.14] tools: Fix pkg-config file for libxenstore To: Andrew Cooper , Xen-devel Cc: Ian Jackson , Wei Liu , Jan Beulich References: <20210322162013.12639-1-andrew.cooper3@citrix.com> <20210322163847.23941-1-andrew.cooper3@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <9204d9c3-d8e9-db75-f209-1b23b7ee2f45@suse.com> Date: Tue, 23 Mar 2021 06:20:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210322163847.23941-1-andrew.cooper3@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Jfjippe6nk70T9Wmw0VO0DnhyKi5GUTye" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Jfjippe6nk70T9Wmw0VO0DnhyKi5GUTye Content-Type: multipart/mixed; boundary="mXcjw0XiVHI0irVC4UNe7aK2YOajojIL5"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Andrew Cooper , Xen-devel Cc: Ian Jackson , Wei Liu , Jan Beulich Message-ID: <9204d9c3-d8e9-db75-f209-1b23b7ee2f45@suse.com> Subject: Re: [PATCH v2 for-4.14] tools: Fix pkg-config file for libxenstore References: <20210322162013.12639-1-andrew.cooper3@citrix.com> <20210322163847.23941-1-andrew.cooper3@citrix.com> In-Reply-To: <20210322163847.23941-1-andrew.cooper3@citrix.com> --mXcjw0XiVHI0irVC4UNe7aK2YOajojIL5 Content-Type: multipart/mixed; boundary="------------0F618CB599365888ECB3F791" Content-Language: en-US This is a multi-part message in MIME format. --------------0F618CB599365888ECB3F791 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 22.03.21 17:38, Andrew Cooper wrote: > There are no dependenices on evtchn, ctrl or gnttab. >=20 > Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore") > Signed-off-by: Andrew Cooper Reviewed-by: Juergen Gross Juergen --------------0F618CB599365888ECB3F791 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0F618CB599365888ECB3F791-- --mXcjw0XiVHI0irVC4UNe7aK2YOajojIL5-- --Jfjippe6nk70T9Wmw0VO0DnhyKi5GUTye Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBZeqYFAwAAAAAACgkQsN6d1ii/Ey9I ogf9Fltjax/k23S21iT+tu7npOgBzD41r+URe8p0ggyLUmXpGxZDC6n+C7MXYTgF2VUZNX3qfH1N 4bZCIu7zhPcB4fqK1/ATJ582BlljQ90Jq7uRHoin1/BMZTddyJCIx6D7du5HIPedBm1YJohw7zkx h9FTeO7muHZRgdIerX6sssSJIv3UAaePr3e00ndwTZgeO8aaemErPY6GPOWrpbOyOhmJqgZCrtSg QPK9oVfw9KW1/ixawn9+i/4PtmdL5p4MKxZ4zPqtDWjue1mcq+u4Mh30f0G8+frW502xT6riC927 vRmgrSeRCaajWseaTy4sda+V9yoWkU13uyuSDD9R9g== =mOBw -----END PGP SIGNATURE----- --Jfjippe6nk70T9Wmw0VO0DnhyKi5GUTye-- From xen-devel-bounces@lists.xenproject.org Tue Mar 23 05:45:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 05:45:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100519.191536 (Exim 4.92) (envelope-from ) id 1lOZql-0007MU-1e; Tue, 23 Mar 2021 05:45:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100519.191536; Tue, 23 Mar 2021 05:45:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOZqk-0007MN-UG; Tue, 23 Mar 2021 05:45:06 +0000 Received: by outflank-mailman (input) for mailman id 100519; Tue, 23 Mar 2021 05:45:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOZqj-0007MF-Nq; Tue, 23 Mar 2021 05:45:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOZqj-0007Df-Bu; Tue, 23 Mar 2021 05:45:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOZqj-0008Bl-42; Tue, 23 Mar 2021 05:45:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOZqj-0001Uv-3a; Tue, 23 Mar 2021 05:45:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OC2mPV6tDE26DQT0cZwuI5INsrKNm9h4Jf/odmZQn+0=; b=utbYjSXLfwqkJDBOBoRNSrfcZV hOB3Ne28iR7mY2/piL1AtUUBH/lBx/W1CppHbHjrXLhitdW/FjJ2RzsK4AQR6llvcsFGokS3x3ieM t64edvjnnzaG1tpbSpIqJsUq93oY9GgONteoI9JD3HdFR1bXy9jOBl3mLh8dVJvkZlv4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160307: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Tue, 23 Mar 2021 05:45:05 +0000 flight 160307 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160307/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 234 days Failing since 152366 2020-08-01 20:49:34 Z 233 days 402 attempts Testing same since 160307 2021-03-22 13:24:17 Z 0 days 1 attempts ------------------------------------------------------------ 5235 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1300767 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 23 06:43:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 06:43:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100529.191557 (Exim 4.92) (envelope-from ) id 1lOalG-0004cB-Pe; Tue, 23 Mar 2021 06:43:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100529.191557; Tue, 23 Mar 2021 06:43:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOalG-0004c4-LS; Tue, 23 Mar 2021 06:43:30 +0000 Received: by outflank-mailman (input) for mailman id 100529; Tue, 23 Mar 2021 06:43:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOalF-0004bz-Et for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 06:43:29 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 32fcd8e7-4112-422e-98ee-698a331381c6; Tue, 23 Mar 2021 06:43:28 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 90CBAAC1D; Tue, 23 Mar 2021 06:43:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32fcd8e7-4112-422e-98ee-698a331381c6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616481807; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4+J7sSDIvj9y/zAn9QU5NutVEzWadCStd/aNpRQiSdo=; b=qQQzdVPkr+M1kwoWp1l4X2g4T0sUXkuxK+QyhkM2fZNZzseKA3+8A8K5g44fwOALNQPcsH sZDo12EqwB4Uci3RaLb8Wc7oT7Tg1FW590LxFZg2t8ooXVTpigXnZveTNKo8kuEiuCZnbm p1j9aL2Iy2BXT2/A3d3PozgFI6TqnB4= Subject: Re: [PATCH 2/2] Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" To: Roger Pau Monne , linux-kernel@vger.kernel.org Cc: Boris Ostrovsky , Stefano Stabellini , Jan Beulich , xen-devel@lists.xenproject.org References: <20210317110401.46322-1-roger.pau@citrix.com> <20210317110401.46322-3-roger.pau@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Tue, 23 Mar 2021 07:43:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210317110401.46322-3-roger.pau@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ifWB3LGqY1k1qOmNVnq2VDRqZzZaosRZ5" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ifWB3LGqY1k1qOmNVnq2VDRqZzZaosRZ5 Content-Type: multipart/mixed; boundary="pUzoMSktAAxtEQwxmACON8972zP1zHqb6"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Roger Pau Monne , linux-kernel@vger.kernel.org Cc: Boris Ostrovsky , Stefano Stabellini , Jan Beulich , xen-devel@lists.xenproject.org Message-ID: Subject: Re: [PATCH 2/2] Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" References: <20210317110401.46322-1-roger.pau@citrix.com> <20210317110401.46322-3-roger.pau@citrix.com> In-Reply-To: <20210317110401.46322-3-roger.pau@citrix.com> --pUzoMSktAAxtEQwxmACON8972zP1zHqb6 Content-Type: multipart/mixed; boundary="------------A0B69D3B8ED2300231DFC1EF" Content-Language: en-US This is a multi-part message in MIME format. --------------A0B69D3B8ED2300231DFC1EF Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 17.03.21 12:04, Roger Pau Monne wrote: > This partially reverts commit 882213990d32fd224340a4533f6318dd152be4b2.= >=20 > There's no need to special case XEN_UNPOPULATED_ALLOC anymore in order > to correctly size the p2m. The generic memory hotplug option has > already been tied together with the Xen hotplug limit, so enabling > memory hotplug should already trigger a properly sized p2m on Xen PV. Can you add some words here that XEN_UNPOPULATED_ALLOC depends on MEMORY_HOTPLUG via ZONE_DEVICE? Juergen --------------A0B69D3B8ED2300231DFC1EF Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------A0B69D3B8ED2300231DFC1EF-- --pUzoMSktAAxtEQwxmACON8972zP1zHqb6-- --ifWB3LGqY1k1qOmNVnq2VDRqZzZaosRZ5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBZjg4FAwAAAAAACgkQsN6d1ii/Ey8T pwgAgkQmk7ZYJ1ZPz0h4CgGGDGYV0kbjFNUa6Lso76tXMHd/PPpI+GqHKbaFkPU8IdguvnxHNFBp Ek4cJFBnKwE6n+PwyU+FUTdcQmvr79VL1ae7jijgPMnlFqS2Zn19sNt7mFzg0beNbcmSFg5RdBY1 jJBRNZhmHZOiKLlcl05LoMzZx7XVX/bDlEAA/GNd29WzO4gOudSHjbjVo57XCD8EL9+1fj5hUEVS DEA+HyC0eU6I7j3lxQvjTU+jd85twpH4duy8RrlZADHPXLeWChJO+Zj6Q9f3HnR5Kc3pP/a5cf0k sXqvOeLJrK1DiEeCUycUHO8r8pAhaJdPCHcUIy3PUg== =D9vP -----END PGP SIGNATURE----- --ifWB3LGqY1k1qOmNVnq2VDRqZzZaosRZ5-- From xen-devel-bounces@lists.xenproject.org Tue Mar 23 07:23:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 07:23:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100531.191569 (Exim 4.92) (envelope-from ) id 1lObNn-0008Si-Ru; Tue, 23 Mar 2021 07:23:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100531.191569; Tue, 23 Mar 2021 07:23:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lObNn-0008Sb-OY; Tue, 23 Mar 2021 07:23:19 +0000 Received: by outflank-mailman (input) for mailman id 100531; Tue, 23 Mar 2021 07:23:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lObNl-0008SW-Si for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 07:23:17 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d5bb6cb2-4c6e-4e47-b99f-2e80031f7a51; Tue, 23 Mar 2021 07:23:16 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CBF89AE42; Tue, 23 Mar 2021 07:23:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5bb6cb2-4c6e-4e47-b99f-2e80031f7a51 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616484195; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=os5aB1CoCk44ZDSVhSK3ym0ilu3lkI3YzGHTrwM/xGA=; b=AeuKGkpyuREqdYqCimsqkhhc7dM23J2ukrvtOiD4wU5WwaFtyOehsCIFPuQThFmSxPufU6 MG6rQk3iRoqm1ja/YVha5DSQnixaOneZTxlWq0UPusQHnFJdOzPXLCJJJlnR76W7gWzLOw O7la1ZCWIZreg39mico4ZSXBw4JeyUE= Subject: Re: [PATCH] xen: Create EFI_VENDOR directory To: Andrew Cooper , Jason Andryuk Cc: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210322133301.11308-1-jandryuk@gmail.com> <09b5e7ee-b44b-a8ab-f29d-6617b6af93a0@citrix.com> From: Jan Beulich Message-ID: <9b071192-a443-4bdc-8dac-107bbd4a0481@suse.com> Date: Tue, 23 Mar 2021 08:23:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <09b5e7ee-b44b-a8ab-f29d-6617b6af93a0@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 22.03.2021 18:08, Andrew Cooper wrote: > On 22/03/2021 15:15, Jan Beulich wrote: >> On 22.03.2021 15:59, Andrew Cooper wrote: >>> On 22/03/2021 14:52, Jan Beulich wrote: >>>> On 22.03.2021 14:33, Jason Andryuk wrote: >>>>> make install-xen fails when EFI_VENDOR is set (=fedora) with: >>>>> install: cannot create regular file '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No such file or directory >>>>> >>>>> Create the EFI_VENDOR directory so xen.efi can be installed within. >>>>> >>>>> This removes the need for Fedora and Qubes xen.spec files to manually >>>>> create the directory in advance. >>>> While I'm not strictly against, I'd like to point out that it was >>>> deliberate to not create this directory here. I also didn't expect >>>> anyone's xen.spec to do so. Instead I'd expect the distro to create >>>> it during OS installation. If this was a bad assumption, I'd prefer >>>> if the commit message here could point out why such an expectation >>>> won't hold in general. >>> This reasoning is broken for anything other `make install DESTDIR=/` on >>> a live system. >>> >>> It is incompatible with how RPM, deb, etc packages work. >> I'm afraid I don't understand, for both of your statements. If distro >> installation put in place the designated directory, there wouldn't be >> any live system lacking it, and there wouldn't be any concern in the >> packaging of any software. >> >> To take a perhaps too extreme example - packages typically expect e.g. >> /usr to exist as well, don't they? > > No.  A buildroot starts out fully empty, by design. > > The packaging environment (usually a chroot) invokes `make install > DESTDIR=/path/to/staging/root` so you don't interfere with any of the > tools inside the environment, and the resulting tar/cpio has the > buildroot stripped out of paths. > > The failure being discussed here is the build within the packaging > environment, not the metadata which forms the final package.  Installing > a deb/rpm/etc will make directories as applicable. Ah, I see. But then this _still_ isn't the right thing to do. In fact, the package build and installation shouldn't put xen.efi in the EFI partition _at all_. The build system doing so is for developers only, so they don't need to invoke boot loader configuration every time they rebuild and re-install. Hence the packaging build shouldn't set EFI_VENDOR in the first place. There it instead should be a subsequent boot loader re-configuration which picks up xen.efi from its install location (under $(EFI_DIR)) and places it on the EFI partition. With the above I take back my "I'm not strictly against" - I'm pretty firmly against. If the warning emitted is deemed a problem, I'm sure we can find a way to silence it. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 23 08:12:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 08:12:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100537.191581 (Exim 4.92) (envelope-from ) id 1lOc9M-0005Nb-TX; Tue, 23 Mar 2021 08:12:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100537.191581; Tue, 23 Mar 2021 08:12:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOc9M-0005NU-PT; Tue, 23 Mar 2021 08:12:28 +0000 Received: by outflank-mailman (input) for mailman id 100537; Tue, 23 Mar 2021 08:12:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOc9L-0005NN-MS for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 08:12:27 +0000 Received: from mga12.intel.com (unknown [192.55.52.136]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dd30cf12-73d5-41a4-a2f4-fe13e2bdb705; Tue, 23 Mar 2021 08:12:22 +0000 (UTC) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 01:12:21 -0700 Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 23 Mar 2021 01:12:19 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Mar 2021 01:12:16 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 23 Mar 2021 01:12:16 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 23 Mar 2021 01:12:16 -0700 Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by MWHPR11MB1550.namprd11.prod.outlook.com (2603:10b6:301:b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 08:12:15 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::75b0:a8e9:60cb:7a29]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::75b0:a8e9:60cb:7a29%9]) with mapi id 15.20.3955.027; Tue, 23 Mar 2021 08:12:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd30cf12-73d5-41a4-a2f4-fe13e2bdb705 IronPort-SDR: +J+8DNzzXEA8KiNzrmtYDVa/KcQfaA2NOkjfMH/J0FKnqGuLrQWrVdoYksoVlRglcu3l0bDzaA nn3FNP9sc6sw== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="169764895" X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="169764895" IronPort-SDR: Dt4S00gxIzibZ1XyzmnRt+8ZZs0eODZP7jLTVWs3frT5JEYyWKcqEZtgMwFWWR8h+DFwYty1zt 5WpjUuqpwmYQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="604211958" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SgpDd/JfrmLW1vuXzkT5sjl2mJlTuy549Dmqou+L/VS4Qn5PUtzrFbevNdkYJuWk9oNZ51Q729LgzC7c2Fhlrv6Iy0kRXgW72M5AbSBBg/1WSq2VD89UMF+//D7+ygGq25k60rM06XHNFWPQmAeb16W2Kebt2Qrb1E42RfIlx1MsOtnKr/ns7s6iFavjfAH572G6+nt+ZHCLBm1XR5A0ARV9ucpystIILXxS/JqDF4DvPk/SFm2WB0XoN/jw+Y/Cwhq+m+JvQQbx+M21TjkG6I0fTNnKLo2++AS7RU9dxGKWwesCaf7kYskUWaQORlgznLML3cGLVi3O8557mp69HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TqHLCoWoZ1rYFPgtZ4Cu7PmZodqbAvTisK7++AyjNmE=; b=eqnF0f0j4BzBElJv5PkD+b/OseXletKhfrHDyjX/WCD2EwTN3AarKAUl4sACuVvuBnQPAAl83YRZG1IiEDk06o4gDjsNH5LtT3I0nnnb8jy7jq1IQFYGHM36ni4dMaqOaNu7bpI3hX2m4QDy+Ks4ZL6XGrEnaH/H9d6lqTqHM9+BqrDaSau7ewpC+1eT8QIw2ZaE6Gt8OL+9YH3BmI7AQ95uYmIcC/FXLUmTzdnwYus3AJnPZnnlyNNOGxqQAo7TZbZOhnHHvuwR/QmVj7kGFun+FNBnhJAfHJhqq8K9jvU06C3b6ZNKN5ObOecOIxBCk0H8QtlGOk4Zmh02rKvoAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TqHLCoWoZ1rYFPgtZ4Cu7PmZodqbAvTisK7++AyjNmE=; b=yQQJHaFbBaZzc+KEWXDkQ65z9UefKf4PgZHAsFKVODlsI8yh7lve+txQfFFSNEdb/a/VVyXDNb96FXzY2+ORGS+xwkcvMG3C2mYZgxURJX4+V+mcl5r8yKmzBvx3xbFbv3Urls+4o/tesrpi2ofzF+S/GFUQTEd83s2Jogn8nKg= From: "Tian, Kevin" To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Ian Jackson Subject: RE: [PATCH 0/4][4.15?] VT-d: mostly S3 related corrections Thread-Topic: [PATCH 0/4][4.15?] VT-d: mostly S3 related corrections Thread-Index: AQHXG98vy5+4PMtWhkqpUd8FCjUkXaqRQJ3g Date: Tue, 23 Mar 2021 08:12:15 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.203] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2100e363-2c3c-4bed-792e-08d8edd35e87 x-ms-traffictypediagnostic: MWHPR11MB1550: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v+zDQlVtReaVDZ1kFiaoBM3+0dkqu8gwORAOAU20mYJiDJ9bqp/Y7mnlqi+f7h4k7lMkfGwyWOSapKMkIUah/rOqxtjBJgqlnEdMAvzgpkkjRDldfQAY2I27QRFYVvLbYFgaeXzwVYTMXmtU6LLXTiK1mqwAQnb/NWxFQeA6u4sdDfhLQ5Ua+x+cLRKxkGdiMUzgVMiNOGXoX74gDRaAWQYyPDq21+g1JxB5VMp+QoYIHYkF5azxl6D4fdHsIUaIC6McR8upL42CIa2+6QK42ZywXfzLgIPfBkil6H6ZDUZLxPerSgRPKVbYM4NPO6beQyLW85Hfaf10hRJD9Bsjj+VoPODR6rGsjJ9BV1rZF7u+/xQ8pXMHl5GMR6WZauyf6jPXnYbFCvF+Wy8AHxGTHmrazvMLkixbOcczB3lSgyfzTJ+0892tiIh1no07kUAznSDnHNwxnnDQBtDoe70iFLsupZz5mvMWHyH4CKiV2JEj9PIXIM64q4LXuAU6AvsLXCO3Q442YkzGC4d8jsYu6Dzsa/VtuS8D5HwYUT5lfNoSm0iE+Y3hgBMbSJLXe1vmMhApmM3Ed1oZd/8Bfn47s1qT642FsDa5dhluBgncxGDsc9wTflwNlqdZiawda4iRtQft2t9ZLmfLdhpKpynq0hYP9pt80MRSIHxwCRVgAk0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1886.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(396003)(376002)(366004)(39860400002)(6506007)(8676002)(4744005)(9686003)(33656002)(26005)(66476007)(7696005)(186003)(64756008)(2906002)(52536014)(5660300002)(316002)(38100700001)(110136005)(66946007)(76116006)(66556008)(8936002)(4326008)(71200400001)(83380400001)(478600001)(86362001)(55016002)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?utf-8?B?SjR5blVXczhvWllzK3VmSmNPakt1dnAzeTQ1TytqaHBXeWwyc1BaczBvS25S?= =?utf-8?B?dC9ZWER5TU5oR3lHS0RvcHEwQ01TSXNsR1Q0ZnZLYVRGR0FwS2UvdFVJMCs2?= =?utf-8?B?aVdqbHNVZ3J4SHdRazFpL1QyNVVzeGhhdkNWdGFqdkpRcVQrV05YQUFZYlYy?= =?utf-8?B?NzVWYWF2QXZtSm8vUE8xNVJxZlNMNkIySXUrQzc5RFR1UmJjN0p5Q2hOaWtZ?= =?utf-8?B?Q1I0a0dmZWFGc2pmckpzdjhHQWlzSFNBUlhJeEdlOFdMZmhPbTRwVHp0cEI1?= =?utf-8?B?N2RJSTdvaStTUndZRmFZSytMZUtCWWdKQ2dwb29CbzJIbHZwZTJYa21QMndU?= =?utf-8?B?SmR2cjBRcmloc0k4UllRM3JaUk1kbm5MSW8vczFTcEV3dDJ4Y0VnUXMwTlF1?= =?utf-8?B?aHM3S0ZEMmFhMnJiR3V0MWtrT3J2bE0raVJ6NjRuQ2dKUVVhenBvaktMNmZz?= =?utf-8?B?eGR2akpUY09kOFZZeWp4bEJXU1VvZS9kSEpjZm4xSWtTMXp4L0MyeVFVRDYy?= =?utf-8?B?UEhVWFZIUTZTQWJFWWdSUUsxelFMZGRQTmNwbzV1bkl1OGxkbmZVcnN0Q0tV?= =?utf-8?B?UmJEUURibEpMeFdsdXJqbGg4cGFBdUZ1SkdtbTRCdWJrMzlhbmpEdHFSK2NX?= =?utf-8?B?R3FkWThHb0ttcytJNUYxMW0yN055TTh3ZUhQM1JvTmo0RWtnOVVzbHYyVDkx?= =?utf-8?B?Q0p5U0FVR05MbDlpYzFZQ09kVHhmKzBwV29aK1FZc3pRQjdEVUJjaHVjaEl1?= =?utf-8?B?OVg3LzZCUmVHTFh2TmRTQStOck1ob0FZdWFFbUFNbTZmTWpBM1NuKzdnbzAw?= =?utf-8?B?NDhtenRBWjFRU3YwSjNZcWdOMHFNTWhNR2U3enpXSHdRMTduOEhRcURqUGo5?= =?utf-8?B?VlVYZHlQNDVyVTRuZExqVTdoU1hEbndMcXl6QnpqMGhxNm9YZ09TN2VZdEtB?= =?utf-8?B?L0gvTmVvM3FLZTY5ODNDWFNiZDlKdU4rVitHb0grL3RpM201YW04S2dFNVdS?= =?utf-8?B?UTBjR3hFNDVwVjJVT0J0dGpyek0rV2hKRUNSTVdqM1lkSU9lSVFudzBiRHhM?= =?utf-8?B?aWhncERQNWF0NjkzTmVVdHJrenp3bU81S2hKUThZZVVWK1ZHRDBXLzYrR0oy?= =?utf-8?B?QThrUzRHZG1FaTJUNmt4aUJUbWRHT1lEeGsxOXgrd2VacUlxNm9WaTdCbmFy?= =?utf-8?B?NXdSU1EraVVQMFc2VE9CeDJ5VXJIc2tmL3JhZjA4VUIrOTk2TEJoMFVKMFp3?= =?utf-8?B?K0c5UWdJSThpZ3lGWUc5aWFaakg3NnViNDVDYzBwRXp3RG5jSzY5WnRNVlFw?= =?utf-8?B?UHEyVGJ5VlV3RWJyWDRWU05ZTE00bXVlWFd4ZlJWNWtCSzliamhTTU1uUDJG?= =?utf-8?B?ZUY1R1puQXBISXpKd29mZlhnWGFRaDE2TzJnN2VoaEoybGR2R05LRHU1blU0?= =?utf-8?B?RXpXK3hQQkVnQVV1UlhleVlYOEEzNHlzNmtCa0tNWDNaV2YyTmNuR3hjRXVK?= =?utf-8?B?WS9ubE1MUnFvMDB6UVRhVjgzVEYvK2tTSGRsYXJoMDZxNExDOTRjK0tPQ1oz?= =?utf-8?B?ZUJ2OVNGZ1FySGVLajh4YjN0RERoMm00SjhNeDQrSW9vTVZBK0xvZk5LWmRw?= =?utf-8?B?VHlJUTVKOVZXditjNll3Q3k1eXFoMG56Q1lUQXRyclM0M0MxVzFmSDU3U0Nj?= =?utf-8?B?MnpKVkhIRlRFZDR1YnhJSXpzV1U1VkJlSkNsbFppSEQzb0FNQ0pFRS93TlZa?= =?utf-8?Q?PlXFDYa/OWozgyCZPQd26rBaHhB4eJ4LdSVLzWp?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2100e363-2c3c-4bed-792e-08d8edd35e87 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 08:12:15.1624 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A4C+4Qf5xvIBZlCBOlU8qbjXUINx6+ofBZVf2YwV/GNKTnvD1pxOHP5UngurMY80JdSniQllY+NGzxJ4CZuqZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1550 X-OriginatorOrg: intel.com PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFRodXJzZGF5 LCBNYXJjaCAxOCwgMjAyMSA2OjEyIFBNDQo+IA0KPiBOb25lIG9mIHRoZXNlIGFyZSByZWdyZXNz aW9ucyBhZmFpY3QsIHNvIGNvbnNpZGVyaW5nIGhvdyBsYXRlIHdlIGFyZQ0KPiBpbiB0aGUgNC4x NSBwcm9jZXNzLCBJIGNhbiBzZWUgcmVhc29ucyB0byBub3QgdGFrZSBhbnkgb2YgdGhlc2UuIEFs bA0KPiBvZiB0aGVtIGFyZSBiYWNrcG9ydGluZyBjYW5kaWRhdGVzIHRob3VnaCwgaW1vLg0KPiAN Cj4gMTogY29ycmVjdCBvZmYtYnktMSBpbiBudW1iZXItb2YtSU9NTVVzIGNoZWNrDQo+IDI6IGxl YXZlIEZFQ1RMIHdyaXRlIHRvIHZ0ZF9yZXN1bWUoKQ0KPiAzOiByZS1vcmRlciByZWdpc3RlciBy ZXN0b3JpbmcgaW4gdnRkX3Jlc3VtZSgpDQo+IDQ6IHJlc3RvcmUgZmx1c2ggaG9va3Mgd2hlbiBk aXNhYmxpbmcgcWludmFsDQo+IA0KDQpGb3IgdGhlIHNlcmllczoNCg0KUmV2aWV3ZWQtYnk6IEtl dmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPg0K From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:00:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:00:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100548.191614 (Exim 4.92) (envelope-from ) id 1lOdp3-0006Xq-Ka; Tue, 23 Mar 2021 09:59:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100548.191614; Tue, 23 Mar 2021 09:59:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdp3-0006Xj-Gj; Tue, 23 Mar 2021 09:59:37 +0000 Received: by outflank-mailman (input) for mailman id 100548; Tue, 23 Mar 2021 09:59:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdp2-0006Vg-Ck for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 09:59:36 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8ab031c7-56d0-40b7-beaf-f6a45e2ad81a; Tue, 23 Mar 2021 09:59:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ab031c7-56d0-40b7-beaf-f6a45e2ad81a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493574; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=PijAI5WJCS5+jGvyOmq8HEdjQLOsv2uzbAMVwnz4R4I=; b=dE96m4hI+fgdyp5soDR/SODvILKj+/1QYzaY+MiW9L73HUlHa6qdzVgm ieD2lvZrZ2IwESOws//fVHIyzuhdFCklRb99gE4iyCUoeDbhimNHn/MbG /m36OGSt6cgevSnaXAjzLUWSm105zPO5u8GN81543mF8XPmhnUBLU2SoF Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ugGyEmGTlfRVXvU7KgMXiZsUkATpxf1Mf71f+f1Y9Wh3ALapg6EFF4qrRUluziSIuJankSqkBP u++H4XfNDT89ilDg5Xodb6pAHkbIx5gX+Enlt5iQrfQ7TQx9rbuB8amBbR0v2bJ7WvR1aRNVFd 8I3JVDxxrnI/dmvpG6LMsyABTXufjR7NxYjU7R64f2AAbyBtCPlu3V/rf/EfQldpvBjx3uBpKM 5jKTxAnejaGNRTI0I5MshCULWx8tlODci6CHFyEqyfj0rCK+3gjaePweUzLvfzuhM20k8AMCQJ cnk= X-SBRS: 5.2 X-MesageID: 40261118 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:wvcCTahyKw4yP/z1oeC+eX3h43BQXwh13DAbvn1ZSRFFG/Gwv9 yynfgdyB//gCsQXnZlotybJKycWxrnmKJdy4N5B9efdSPhv3alK5wn0Jv6z1TbaknD38N+9Y MlSahxD9XsEUN35PyR3CCUG8stqePpzImGnuHbpk0CcShPS4VNqzh0ERyaFEoefngiObMcGI CH7sRK4xqMEE5nDfiTPXUOU+jdq9CjrvuPDSIuPBI79BKIyQqh9b+SKXOl9y0DWDBCy6pKyx mmryXF4MyY0s2T+1vn+EL4q79Xn9bgzdUrPr3wtuElbg/CpyztSIBoW7iptC04rue1+D8R4a XxiiZlBetfwTf8eXy0vAvM1mDboUkTwk6n83C0qz/CptH0Xz0zAcYpv/MmTjLpr3AOkfs59Y Aj5RP/i7NnSSnusQ642v3zEzZtrUawqWpKq59ps1VvFbEwRZUUkZYS5ypuYfE9NRO/0q8LOs 90AvrR4f5HGGnqFUzxjy1UzNugUm9bJGb+fmEy/sic0z1hlHtk1UcvxMsGgnca9J4mIqM0n9 j5Dg== X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="40261118" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TUHFiOvalbjAJ1KRVujnpCGSDnBZx1m22DiTTQd9ad4t/rDrA+TkZIWu0QLPbJdpO91ANPbFXsSxk5fZTYZIkDOwxwk1HMhCMiQRk+kN8w/8fz8sV7ODckIVxyh225CXfHfhy7oa0wVQs2GigFuXwkvGLTpS/fSN/Svwsdq4Ith2ROEsee5K7dMENxQpEJQd82jcCMBPsfT/+OnTOWmvDmEWaFlLZAYJ9BgN3MZR4bXuAZ1wFWFqPspxxL3v3oFsWDRKsmvvWZ7H9T3Mnz5rBP4qyvD50RgJRaW2Cm7TCg+P/bWwgpvtm9jRX2AVRMmgEr3qCgjZCh9j1gxcT4aHEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fCYKj9xS+9yyRL8nU+5448nJ4c9TjD90m81OST2t//U=; b=TznS6BIuduPX0LyNwDULCZXItBI1PsB4mbubcohFIKVC2a6EJvMgi/StrESaEHizLk0GfoH9TsIBpspx9kelivCWeT+ymbhrtg+3GHmweKcSTcKvM9QuQQAjSzwN4a0dvcg7Ag//t2tSh1+aX+5Ur9U91GVvbEDfBtz0m/8jlm10locMeubOq+ggNYvksxRR7r/Rlox60izYslks9YJDH2QG+iwZ8lWEiLaotRMag2CrCI5ppw3GBHUlbSniZtqJBzguMirqVpxKHWbJtiWLHm9HPAvXZM/gwKxG1Tr1HYiprOazjfA3Suc6KrWuXsW4ntwzcEvDB8bPd9edao8yMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fCYKj9xS+9yyRL8nU+5448nJ4c9TjD90m81OST2t//U=; b=sdpK6Sxa5RWxwmUcpmUL6/H+O7BEyrppgxhFoXeMjfc2enBlJ1whaBqEIq9hSldW2cenbaSO6G06GiqsXL8Lq8S322SH48bYOA2nbLjRHk55f91EFI/rBPRpOn0Og8z9+c6+pXm3ZKAyC0zQo+Nzf5kJyiU062mfSSoSAYSytE8= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu , Anthony PERARD Subject: [PATCH 01/21] libxl: don't ignore the return value from xc_cpuid_apply_policy Date: Tue, 23 Mar 2021 10:58:29 +0100 Message-ID: <20210323095849.37858-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR1P264CA0010.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2e::15) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c8566e7d-f617-4e26-e009-08d8ede25a99 X-MS-TrafficTypeDiagnostic: DM5PR03MB2633: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Euvyp0dSa54nH95+HqYgiwNPuJMGbrFJLCG7pl/O2XAVKLqFEQH2LbiTF8joHYXiarrIKFFpkPEuWPjxKBEhCdXF6fnH2QVhXYsWqUAadTTH0A5wnS48kRlqwup//fUDu19kCnywo8sOARwLhPKGiaSIFQPivK0l7XNWUZAwmf6FcJQU05vbQYLfi41m6zkalLSyAdet9thD4TWPi4zlzQsbs/CjhvJynb8cZEe/pk/M4AEetUwvP/vaFLSm5W2G4MpTJNwveWGpPbev08hP6DgeZN8lc4Ogg6rt5YR4aO0wMoZTiBsj59JSAODcrco1pZ6oixyoo2Y9B+K5jwOMXVggI4f9e9Jmrau5RLUaLB6rwrlhbL51ccu6tQSSNGNKyzwkHtDLX7j/PnpxnEJiIIf2VlWlu/BEPNzetja+QOXn9hT67k+vhgEAMgIboL2KykLwiv8pVp9u7CVMokH8Gbh30ParHdn6J+ftsyBJUFqbjvAFHlPLgTKyWnMmTe1hDKRkBRqWHetHi7oiNaHEAn5LpudbpBbk/p7fY9fb/6esJUle4UoRX2izYam9akHmmr9FUK0UQPDZKrnN9YQ9b29FhTuDQiIyegQ3fgPTULMMw+VuedBC84O9c+sw1r9+4EWV5O0UAgdygdvcRDYeoeNLl3bjvlJ1NGVSs6uIX0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(6486002)(6916009)(36756003)(6496006)(2906002)(8676002)(66476007)(5660300002)(186003)(66556008)(66946007)(8936002)(86362001)(4326008)(54906003)(83380400001)(1076003)(16526019)(316002)(2616005)(107886003)(38100700001)(956004)(478600001)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bkQrWXJ5RWZNTzZqbnkvblY1NEdiejE1ckN6ZUhNWDJ5NytYY3ptMU9SS2pV?= =?utf-8?B?dlRJekt4ZVZaOUY0dnBnNFNDeTZaL2c0UDVkTG1BUHJ2dS9KbFdnZDVXNS8y?= =?utf-8?B?cjNjMFhwc2ZKanVCQS9nK0liNnY3cU14V3NycU4xZUR2d1l1ZWZnN2pyQmdO?= =?utf-8?B?OEZGc2o0Um9zRDRIVHV5cDYvUXBYQUNvRDdPOEtpTWxhbUxWUVlvTzQydXBa?= =?utf-8?B?a1JiZ1JDdGpYT2lOQTBnUFVnd3ZLZ2gwZ0JRMVV4YzBhRXgyUi9Hb2pzV3BZ?= =?utf-8?B?RGhlNGR6YzM4NWFrellTcnZ6L3hMUE12TjN4Z3NpckNBNjM5VjBhbnY5Y1hU?= =?utf-8?B?L21VaGJhV2NaTXpiOGhNUlg2RFJKdlJ5SmZ6VFBFUUxJOVZFWHM1OW8xSzFU?= =?utf-8?B?bEFrQzJrTWVmblVZVlRBSFNoZWxwb3hSREViUHFQSW9XQkhCK1g5SS9QMDNN?= =?utf-8?B?MFZuVkpqM3VvTDNhVCt2amN2YVMra1RHSmUzYkx2Qk5KaHowMkgza0FiUWt6?= =?utf-8?B?a2RwUFNDTnBnY0ZIeUZGak9GdFIxUTBUeG53cEtNQkUxSmdTR2c5NENtNTB6?= =?utf-8?B?eFlzS0FkeHVYeisvL3FtblB0dDkvS1VXbVVxUlpkeGtQRVo2YnVnMURmc0Ny?= =?utf-8?B?NGlRejEyK0ticmZyNkZwUEw1NnBJeTVmTEs3RnM2OS9IUXlZaHN3SitnYWpJ?= =?utf-8?B?bFgyZmR2V1hVQTRsdWdTdERBaGM4b3JBK09jdWF6Q2J6SmZ1Z3FERllwd3N6?= =?utf-8?B?b1QxNVd6WGNGOGFuUFYrZERqTGQ1WmF1TTJtUmJWMnlybWdkc1psdndpcHlY?= =?utf-8?B?YWlUSTR2NFEyRW8xZlRzc0w5TmNmcmkzTmk2N09pWVE1bjE5cElXQ2hpSTY5?= =?utf-8?B?amNpejFXSHdLNFlTcTFuOHd6eHdOM0NqZElNZGlkYkV0Z2w0UXkrdnVwbkxJ?= =?utf-8?B?UTFCYzEyREhVUVYrekUvdUJGVDFha0MwbEJubklpNCtqdUdUK3VXUmEyNlla?= =?utf-8?B?S2VxUW1rZTFQOEJad01wNVE1Ly96SE5QOEN1VUgwOFIveVBMUk1nbXZpdGhs?= =?utf-8?B?elRqdzkrbnFWVVR6dXZjT1hEV1VWS2ZWNDV1bkZvT2dLTlEyYkxHbnJWcDlu?= =?utf-8?B?RXFtV1Mwb1YxVFFyazJaanNkaHZmOXY3d0Rsa3BBcWpuN3lYQ0dVOUo1ZFJO?= =?utf-8?B?K3M3VFFGcS9sUTRaOVlRdE4rNmM1T3J0YTJzVVZJMXQ2a0NjbWNTT3JtTUFD?= =?utf-8?B?dHFTVFJBOVRzTFF3bHJwRitsSUxoVnBkaGVqMmZDTGVsVUY1QW5lbC9lWEk3?= =?utf-8?B?ampySHBZNStHbGVCTkQwYWRBUGlCTHVMTnBNSXVROFU1QjJJZ044SnRPY1ZB?= =?utf-8?B?QjhGcTVQSjBMZG5yWlB2bGM5Z0Y2dlMzT0ViWUlaa0Q3bEYzQ0xOcXZndlo4?= =?utf-8?B?NHpQTTRySXF4RlNUTTUwYlo2ZWR0V0pWblU4dTNsYlBEWVVZT1hGN0tKYmlZ?= =?utf-8?B?d0JkYld6NDVEOUNNK0kwRXA5T1k4NC9oWitrVFhoSDRsRkxnZVNadVVNbUlM?= =?utf-8?B?M1ErbDZ3aGpIcXZLZG1ZMUVnNDdLRGZrL0hOdm5JUlNHSW5RVjRZbWpVeWtk?= =?utf-8?B?ZkZvVEtVNHFERkxFMEtzQWNyb2h6MTkvbi9uTVFWVXM4alAzbFEyMVRFbi84?= =?utf-8?B?RjZYK29XQjJCVlFpem5KRGEveGdpUk5JelB0R1c4ZVZpd0VJcEMxbUh1c0U5?= =?utf-8?Q?vygnJRu00xybhGc+ex+MNbJK9IPhF5ZrNQi31ek?= X-MS-Exchange-CrossTenant-Network-Message-Id: c8566e7d-f617-4e26-e009-08d8ede25a99 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 09:59:31.3461 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 31M2cxtKkcMMBQwSRy1Z0j4Je1T0gzth5uwK/LT37pkvCrRU6YPwUsrXWePjqmYRAIu/otOX/tqsC5TQ0WD3bw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2633 X-OriginatorOrg: citrix.com Also change libxl__cpuid_legacy to propagate the error from xc_cpuid_apply_policy into callers. Signed-off-by: Roger Pau Monné --- tools/libs/light/libxl_cpuid.c | 15 +++++++++++---- tools/libs/light/libxl_create.c | 5 +++-- tools/libs/light/libxl_dom.c | 2 +- tools/libs/light/libxl_internal.h | 4 ++-- tools/libs/light/libxl_nocpuid.c | 5 +++-- 5 files changed, 20 insertions(+), 11 deletions(-) diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c index 289c59c7420..a7b33bbcd06 100644 --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -419,11 +419,13 @@ int libxl_cpuid_parse_config_xend(libxl_cpuid_policy_list *cpuid, return 0; } -void libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore, - libxl_domain_build_info *info) +int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore, + libxl_domain_build_info *info) { + GC_INIT(ctx); bool pae = true; bool itsc; + int rc; /* * Gross hack. Using libxl_defbool_val() here causes libvirt to crash in @@ -462,8 +464,13 @@ void libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore, itsc = (libxl_defbool_val(info->disable_migrate) || info->tsc_mode == LIBXL_TSC_MODE_ALWAYS_EMULATE); - xc_cpuid_apply_policy(ctx->xch, domid, restore, NULL, 0, - pae, itsc, nested_virt, info->cpuid); + rc = xc_cpuid_apply_policy(ctx->xch, domid, restore, NULL, 0, + pae, itsc, nested_virt, info->cpuid); + if (rc) + LOGE(ERROR, "Failed to apply CPUID policy"); + + GC_FREE; + return rc; } static const char *input_names[2] = { "leaf", "subleaf" }; diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index 1131b2a733e..3b7474979de 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -1443,6 +1443,7 @@ int libxl__srm_callout_callback_static_data_done(unsigned int missing, libxl_domain_config *d_config = dcs->guest_config; libxl_domain_build_info *info = &d_config->b_info; + int rc = 0; /* * CPUID/MSR information is not present in pre Xen-4.14 streams. @@ -1452,9 +1453,9 @@ int libxl__srm_callout_callback_static_data_done(unsigned int missing, * stream doesn't contain any CPUID data. */ if (missing & XGR_SDD_MISSING_CPUID) - libxl__cpuid_legacy(ctx, dcs->guest_domid, true, info); + rc = libxl__cpuid_legacy(ctx, dcs->guest_domid, true, info); - return 0; + return rc; } void libxl__srm_callout_callback_restore_results(xen_pfn_t store_mfn, diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c index 842a51c86cb..e9f58ee4b2b 100644 --- a/tools/libs/light/libxl_dom.c +++ b/tools/libs/light/libxl_dom.c @@ -384,7 +384,7 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid, * being migrated-in/restored have CPUID handled during the * static_data_done() callback. */ if (!state->restore) - libxl__cpuid_legacy(ctx, domid, false, info); + rc = libxl__cpuid_legacy(ctx, domid, false, info); return rc; } diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index 028bc013d9c..22b1775b752 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -2052,8 +2052,8 @@ typedef yajl_gen_status (*libxl__gen_json_callback)(yajl_gen hand, void *); _hidden char *libxl__object_to_json(libxl_ctx *ctx, const char *type, libxl__gen_json_callback gen, void *p); -_hidden void libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool retore, - libxl_domain_build_info *info); +_hidden int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool retore, + libxl_domain_build_info *info); /* Calls poll() again - useful to check whether a signaled condition * is still true. Cannot fail. Returns currently-true revents. */ diff --git a/tools/libs/light/libxl_nocpuid.c b/tools/libs/light/libxl_nocpuid.c index f47336565b9..0630959e760 100644 --- a/tools/libs/light/libxl_nocpuid.c +++ b/tools/libs/light/libxl_nocpuid.c @@ -34,9 +34,10 @@ int libxl_cpuid_parse_config_xend(libxl_cpuid_policy_list *cpuid, return 0; } -void libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore, - libxl_domain_build_info *info) +int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore, + libxl_domain_build_info *info) { + return 0; } yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand, -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:00:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:00:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100547.191602 (Exim 4.92) (envelope-from ) id 1lOdoy-0006Vx-79; Tue, 23 Mar 2021 09:59:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100547.191602; Tue, 23 Mar 2021 09:59:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdoy-0006Vq-3h; Tue, 23 Mar 2021 09:59:32 +0000 Received: by outflank-mailman (input) for mailman id 100547; Tue, 23 Mar 2021 09:59:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdox-0006Vg-7u for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 09:59:31 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 49e851fe-54a9-4ef3-afdd-4687a4a484de; Tue, 23 Mar 2021 09:59:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49e851fe-54a9-4ef3-afdd-4687a4a484de DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493569; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=m2sJFlRZrCcr9VQ23BQRU862yHjdPgMiGukXblN3Etw=; b=HIsXWeqqebJVsDjghgmmQ5DE+C1t1/zUBUzUd06qgdv1WvBMGeJ0Q+Eo PRp4WBW1suxLufsPyHFvvjCQrCxYo5zM4pY+qfX+eexDx7RDBu5WrDUg3 wQovQ5mI/rhnZ8Xqemmk+3PlXM5BNkfet70x6gMkm6brAkukJV8EyNwSy c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: j1z4ZbtuiCBorV6zVUrrpkFZOZ7xLcs1+ZvJukWn1fem32KHBR7WYwVcQUTiOBzUwWlOg8Psrf e7I7czrtH+4vMe56CrdWzBf6xn4NJqNqnDI1WevIVkVz1+5lEvcpfUNOgDPizpioqYyJPs6/A1 D0sQENXe34JOUFBpODJzkcZCT6S0cmPpRm8r3o1ia0qCILCuxtVHp+uu27zqtCWT8zUA3mxYUT ilc0Hly6coFVK6ZVWWBEYB4xMT+vlzRhFyzRPAZquC5WjXBMAzHydrNolB+gzBjSBudAd2XrOX C9c= X-SBRS: 5.2 X-MesageID: 40055371 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:3JW5Dq429bT2gATsqQPXwS6EI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoex3h3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdBHW3tV2kZ 1te60WMrHNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2FXQotLhj0JbTqzOEtwWQVAGN4FD5 Ka/MVKvH6Nfn4QY8S9CBA+LpX+jvfMk4/rZgNDOg4/5GC1/EmVwZPZMzzd5BcRVDtT3awvmF KlryXV7riu2svLsyP0+HTU6/1t6b7c4/9iIODJtcQPMDXrjW+TFfVccpmPpio8ru3qyHtCqq i1nz4aM85+62zccwiOyHOHsWSQs0dNmgzf4GSVnGf5pojBTC86YvAx+75xSAfT6EYrobhHoc R29l+e3qAnaS/orWDW4tjFUAxSjUykoXYuuv57tQ0hbaIuLJBWtoAR50VTDdMpGz/78pkuFK 1UANjb/+s+SyLWU1np+k1UhPC8VHU6GRmLBmAEp8yuyjBT2FR01VERysAzlmoJnahNB6Vs1q DhCOBFhbtORsgZYeZWH+EaW/a6DWTLXFblLH+SCU6PLtBHB1v977rMpJkl7uCjf5IFiLEono 7abV9evWkuP2rzFMy12oFR+BylehTyYR3djuVlo7RpsLz1Q7TmdQeZTko1rsemq/IDRuLBXf KeP49XHu/DIWPiFZ0h5Xy8Z7BibV0lFOEFsNcyXFyD5ujRLJfxi+DdePHPYJrheAxUGF/XMz 8mZnzeNc9A5kekVjvTmx7KQU7gfUT54NZVGKje9O4D9ZgVOuR3w00ooGX8wvvOBSxJs6Qwck c7CqjgiLmHqW6/+nuNyGl1JBxHDAJw7K/7W31H4S8GWnmEPooripG6QyR/zXGHLhhwQ4f9Cw hEvWl6/qqxMti33iAtC9WuN0qAlHsNrHe2T5MR85fzpfvNS9cdNNILSaZxHQLEG1heggBxsl pObwcCWwviDD/0sL6ki5YVHenbUNF5jG6QUIppgEOakX/ZidAkR3MdUTLrdcKMmw4hSwBZgU BL/7YFjKCNniuuLmUDkP01WWc8GFi/MfZjNkCodY9UkrfkdEVLQWCGiSezpjszdmDpnn9izl DJHGmxQ7XmE1BdsndX3uLW61tybHyaZF81QGt9q5dBGWPPvWtT3eeHarGo6XaYbkIPz4gmQX b4SApXBjkr68G81RaTljrHKG4vwY82OPfBSJskaLPe1xqWWfq1vJBDO8UR2plrNNrj6LBWFc 2efhKYNzP+BacC3RePqnMsJSlzrz0FnJrTqWjYxVn9+ER6J/zYZGlCbfU8Bfq36mD/XfaG0J ljl7sOzKKNG1S0TuTD8L3daj5IFwjarmG3Rdw5sJw8h9NBiJJDW73gFQbS3H5J3B8CPN75uU MXTqN8+q3AMOZUDrgvUhMc2lIokdiVRXFbyTDeM6sbfVs3iWXcMM7My73UqaA3Cknpnnq6BX Cvtwlc9ezCRS2NyPozDL8xO31fbAwZ5G559O2PM63WBwPCTZAIwHOKdlu8eqRaUq6LBPE5qQ t7+ciBm6uvTBXDsTqgywdTE+Zp6GaoQcS7HQKKF6ppyrWBSCixq5rvxtWygjfxQSa8cGICi+ R+BAotUvg= X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="40055371" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tvz4+P1xVv1L4IUWH9tKQry8Mj0fe6fiNv6tzRPuxr0MCRl5MQQD4cB9G7ITmOyPu+E8rw5ZtOWNmGT7GXOJFaEwsQPmIbHvw+dc0XiOq2oxrrFMRhhJJkQcxQtugl9MWW5I4+3dG5W89B4KTWdPF4ga5lGLVhrxR7kCXCP/Bp72UDA86EXcHIBpUgorVlBPJyH6nvs5y2+yk8vRLBBtFl7rGwpVvHtcKjb9tclE+fpViyCuac/ayqIkk6zuAKRh0Yp2hQ/cKjuhEQkebT/g6YFbt8Wg0Nuy2ZQkvEFsLvgcjVZpC5lonDuCmUjPG6kGQQxRJNj2Kyl8dyZ4aoVfcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NNH21g3qxXPN6ozUOJ43J5EqhCLkuO9vrTe0vMZLM2o=; b=l7H7eJutsrpHUGues2gtVxWj/3Sq3o7zz3FHLQoqR0FJgO1C9Wl9/SX9IF+18baDylXP3FOcqIsU+hQtmpaESTIwoxyDHjh6yFZHcuBbPhk9lt3f+zpP4zSGTqyPPPvnQS2Xun88RUOPru/djb8tZNOqoY1PJuF6dyrQGzh5pTgc1STpKxOTkmG+ImVyKykx1Dvvs7btZLVo5Ns63DB6xbu+N9iWRCoxiHQUidfJqOQnTYuXxaT8RWbwjGPTWXJr0lZP1njqtGFyLYFNZYw2DR1M1oG/Y1tk3uiO17wE5C2kYkt/e1IVY3bvUEDZzmk4inIWP06TJkhoYvKQDV5qPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NNH21g3qxXPN6ozUOJ43J5EqhCLkuO9vrTe0vMZLM2o=; b=BETjUux3fc0Q26xCtZEswqfc7dCpl5Cp0P7n5PtjU7V3aG3Bx7mWIsE2nOSmcwF80C2+1n8Qeqpivw0C+dzoQjOXMRxZujmASTdAmrTLbb4RE9qsjARy3HT8BtYclh2cwZJXnZiYV93UzROwOBLbKd3vN1UFcF0mfceQV/Hkp2M= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu , Anthony PERARD , Jan Beulich Subject: [PATCH 00/21] libs/guest: new CPUID/MSR interface Date: Tue, 23 Mar 2021 10:58:28 +0100 Message-ID: <20210323095849.37858-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MRXP264CA0034.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:14::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3066deb2-31d7-462e-e0b4-08d8ede2570b X-MS-TrafficTypeDiagnostic: DM5PR03MB2633: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MJHzTk+cd5v0ApdEQo5D0qg356B05XFO3oVO1cqUqDgMNA9pEqzuRGDBl6p8cF9R8DzJvUONp8Kc5hqMgvp/qFd2g0NhzgbC9FsjYjg3+GbB6i0vaCZJviHHGRQj2kRRzjKo5e7ForY31BHCtDfr21gXy/ALtl7gMjqun7RAnbT/XkrJ3LEOM3e+M5R4NudA4wvI1mqLZFX7ILO/emv20pqG7y4Upqlgkic7PTNwlnSU81GN0sSPxu6Ws6fh0gyPwA3QFAaxTTdlJPDVjtasmQgd5o8MPGzBSJcxVMjAelCopmJ0Of7Urk5AZ3L3dEhRVKhNFr9DgprXXnUMhoQjCOuDajgRylSxRXZ/7grO7/3pp+cFpZpV2Rj6dxGCEx23WfE7VzF/SA8q1lav6Zz3yHGUQcJnkTaOwxnwmKFhdu2ut7fsjqfaeLyACbZQMScoAoY8cBVpV/neOwcXODI24n4/2W27K13aZVROQpBnvwglijJ3cR1cOO7W7/pTM3dkevse1Pbp3W7GYO+yLlF1MzkrxrnfsZVFBadk54GT5pFbMaLa4vcuOl6eZnq6DLagoqcMA9qUCubCjPz0aAvtbilPMZgV4CYqpCC7f1rUtbULIF9Bz3Vk3ypVVmmHN7GYxbvVBMyZH4MP9mQ9V0drRA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(6486002)(6916009)(36756003)(6496006)(2906002)(8676002)(66476007)(5660300002)(186003)(66556008)(66946007)(8936002)(86362001)(4326008)(54906003)(83380400001)(1076003)(16526019)(316002)(2616005)(38100700001)(956004)(478600001)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Q1VsT0diTDlOVDgvbnBWWWhYN2ttWTlDdlkxZXBxTUN0TmdCcTNRTlpUOXVr?= =?utf-8?B?SHduQjdqL1N2UW9QV2tOTHRMTnp0OGZGUjBoWC9rMmhnajFqQUJ4Z1RMTWFx?= =?utf-8?B?WWFzSStTdldtakY5TlFXbDloRFB2eE5SYWtkQ0dQWmk1WWJxTjRYbzh1enc3?= =?utf-8?B?VVF5SWVnaG1icXowQUQ0OHpwQWV4UkZTUC9zQXIzZHRMbkNpckVnMVpUL2U5?= =?utf-8?B?VTY4VlhzUmQ5a2ZYSzRlUlZ1WHJISXBaWHg0SUwwcHRLazJ0RGl4K2ZOanl3?= =?utf-8?B?V29jRW5wTHR4MlQ0RUh0VFVCb2hjYjA2eU5LRUJzRUxMb2VjTGF1N0hOLzJB?= =?utf-8?B?VXJoWWhid1ZycGtpWFlqWEEyTXRTeGhnRzJZTmZGQU5EMmRqS3hXaWR0Vnc0?= =?utf-8?B?TXJaRlJ3cFV4aHR6aTZYd29mR1gzUXBIMjh3WDFGYU5jdmtuSGkvV3oyS1FE?= =?utf-8?B?VDNBYnB2RVJqcFdLdHd3TE5ucElCZXhvL1l0cEdPM3c4M3hEQjBNY1VuV0Rp?= =?utf-8?B?V29vaERla3BxZG8zVjBjekE0SERBeFk4MWRNOTg1SmxtcDZLUXNpdkZTSEFN?= =?utf-8?B?WkFNZXAweWJzZ1o2M1MwNnUwbzM4ZUFqQ0VtRzZRTHRUdHNnclQ5bW5OL0k2?= =?utf-8?B?NnVFZlNObWVYR2svTmd6VDJ6NlBCL1FVSVp6YWdnRGR4NWQ1blA5aVFTRFJx?= =?utf-8?B?bXhKVE91MkxrWjQ1ZEdDeS9LdktOZmhNL3VPSmRqL0lUZm1SZWkvVWdlKy9F?= =?utf-8?B?VGFRNnlIK1FlOXpVVGZRL2pqL3ZBeHNFR21XWUlKM09NZ0lQTDQxSlpkRmIw?= =?utf-8?B?Q0VGZno1TGo5eTZsR0s3U0pjQURVaHBaM2F0Q3lvekErV2dndUNuOHR3cWNq?= =?utf-8?B?MXRlblRKcEVJeTJYdFpQOTZYWGdKL0U5MjA2Sm52RklnSnVLR1JwWDlKRXZs?= =?utf-8?B?ZGhxeTArRDFLS041MUd1YkRqSXNrTjVka1dnMVAvVmtyaVhFUFV0blB3S3RJ?= =?utf-8?B?QUQwVFhHdkZJWU5qdG03d0NWYms4ZWMzVEdIalFSczVyeWZ3UmdzdGhKQnJI?= =?utf-8?B?TWN6MU8yb2dwS3Fub2lyalhkYWNBdEZXcWhPYWgyN2lsQ1AraitWRC9OQitk?= =?utf-8?B?N3FIWWtvN0xoaGhVU2JGTVZtdy9pWHFoVnhzSWRrSll0VVBLMVJHTHRnMDVT?= =?utf-8?B?YjNhUHZuT3hmMXhxZmlOeXRkQlB6ZFpRaDkzam5QLzhYMlRCK2dhSmtMWUV0?= =?utf-8?B?LzUvaFIxRWNJb3Y4WnpBd21ENEcxMm14MDlQb0lheXJRUzA5dFVNazhGRjZl?= =?utf-8?B?MTV1WGdjUU0vNTRNMUJsZVZzZExhb1Vzc2dIQTJBblR1K3dVSkNsVmI0SWVl?= =?utf-8?B?M2VUeDJRaXl5SkNrWS9ST2tUWVBmMkFCK0ZXcVdNdE40czZncjVGaG5yTk5l?= =?utf-8?B?YUIzWm1ra1ZBWEliVVpOTnZkcHdOUjFKU3kwRkdRQ0F6YnlubVVlYm90K1lY?= =?utf-8?B?V3ptSmZzTmZpVXN4bE8zQW40eWxqOVZ2Njg4K1ZzWE45YThFY1lnL1Zzd0xU?= =?utf-8?B?TUZzL1lFeVJCNFdaZk5welFsQ2ZlK3VKRXE4bHVKMG5FZ0VKMythOG5keXd6?= =?utf-8?B?K0ZQL2tZNWhkRE05TFRKUnNvbXBrMEE2enBvTm5BNDFHa3UvQi8yNDRkWDB4?= =?utf-8?B?OHFYR1JER2N2ZVhTV2FDaFhBMzNjam15TUlDWnFqVWRWM0tlWWhSQ0NHbzQr?= =?utf-8?Q?IVsb68LW7CUXFiamcjTb2iMlsnDkO5sYYwQ78Hf?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3066deb2-31d7-462e-e0b4-08d8ede2570b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 09:59:25.3744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D0N4l5alw0u0dW/pmDLBKOHpT3t0FZwXkH3h8hku9VfkQqoPjh83XM61On1ju7SEU5HRWoI5zfK13RIhSKgvGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2633 X-OriginatorOrg: citrix.com Hello, The following series introduces a new CPUID/MSR interface for the xenguest library. Such interface handles both CPUID and MSRs using the same opaque object, and provides some helpers for the user to peek or modify such data without exposing the backing type. This is useful for future development as CPUID and MSRs are closely related, so it makes handling those much easier if they are inside the same object (ie: a change to a CPUID bit might expose or hide an MSR). In this patch series libxl and other in tree users have been switched to use the new interface, so it shouldn't result in any functional change from a user point of view. Note there are still some missing pieces likely. The way to modify CPUID data is not ideal, as it requires fetching a leaf and modifying it directly. We might want some kind of interface in order to set specific CPUID features more easily, but that's to be discussed, and would be done as a follow up series. There are two functions kind of related that I've left alone: int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, uint32_t *nr_features, uint32_t *featureset); We might want to rename those to also use the xc_cpu_* prefix at least? Using xc_cpu_policy_* would be wrong here IMO, as such functions don't use the newly introduced xc_cpu_policy_t object. Thanks, Roger. Roger Pau Monne (21): libxl: don't ignore the return value from xc_cpuid_apply_policy libs/guest: rename xc_get_cpu_policy_size to xc_cpu_policy_get_size libs/guest: introduce xc_cpu_policy_t libs/guest: introduce helper to fetch a system cpu policy libs/guest: introduce helper to fetch a domain cpu policy libs/guest: introduce helper to serialize a cpu policy tools: switch existing users of xc_get_{system,domain}_cpu_policy libs/guest: introduce a helper to apply a cpu policy to a domain libs/guest: allow fetching a specific CPUID leaf from a cpu policy libs/guest: allow fetching a specific MSR entry from a cpu policy libs/guest: allow updating a cpu policy CPUID data libs/guest: allow updating a cpu policy MSR data libs/guest: switch users of xc_set_domain_cpu_policy libs/guest: introduce helper to check cpu policy compatibility libs/guest: obtain a compatible cpu policy from two input ones libs/guest: make a cpu policy compatible with older Xen versions libs/guest: introduce helper set cpu topology in cpu policy libs/guest: rework xc_cpuid_xend_policy libs/guest: apply a featureset into a cpu policy libs/{light,guest}: implement xc_cpuid_apply_policy in libxl libs/guest: (re)move xc_cpu_policy_apply_cpuid tools/include/libxl.h | 4 +- tools/include/xen-tools/libs.h | 5 + tools/include/xenctrl.h | 107 ++-- tools/libs/guest/Makefile | 2 +- tools/libs/guest/xg_cpuid_x86.c | 849 +++++++++++++++++++--------- tools/libs/guest/xg_sr_common_x86.c | 45 +- tools/libs/light/libxl_cpuid.c | 229 +++++++- tools/libs/light/libxl_create.c | 5 +- tools/libs/light/libxl_dom.c | 2 +- tools/libs/light/libxl_internal.h | 32 +- tools/libs/light/libxl_nocpuid.c | 5 +- tools/misc/xen-cpuid.c | 23 +- 12 files changed, 960 insertions(+), 348 deletions(-) -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:00:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:00:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100549.191626 (Exim 4.92) (envelope-from ) id 1lOdpE-0006cj-TQ; Tue, 23 Mar 2021 09:59:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100549.191626; Tue, 23 Mar 2021 09:59:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdpE-0006cc-QA; Tue, 23 Mar 2021 09:59:48 +0000 Received: by outflank-mailman (input) for mailman id 100549; Tue, 23 Mar 2021 09:59:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdpD-0006c2-2x for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 09:59:47 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2ed01982-7002-44c2-a005-1d398e41eba3; Tue, 23 Mar 2021 09:59:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ed01982-7002-44c2-a005-1d398e41eba3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493585; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=zcfmbEe4UCyttYXsnFBGL6aT4m16gCdnmGNRMv3yYUY=; b=QSR3AvSA+N+nfREPB4cgLKiYeGBIbRN/dMJU5jyPZfra4L9x/+aZgaPs zcdZ7fWaftWrKrwHjcIXa33pnr2kyzXZPgnnTVhJoZVXb+hRIUvD787gh ZsjyHQ8jXzLVU2R50WvymkGBzkbtZWgMjaWLY3YS/MMTnyvqdSNl2dNsi 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: g1PO2tYsGB+bltiKrfzuycs9uxjztNWl4I4fPHHlZKtof4HRwmfoZEjUQRbFuzQ3v86PEz87J9 pWWODA/SpKVTXgBCfPznSJ0npzyjDYV7uXKYAPIYQs5SsKud3PSpcGeK31nsufrvG+yNclEJ7R AyIbB+qtMOYfvfHR/NCgQNhhylGWNqr5KMpqXLS/XTseeWkPen7GO3gW6LDEHjNY96lYJ/L1D8 zQHLLQOfR7a0a5he9ZZIXTKsZR/ATkdLB7R2HFkri1pnOKoz6pUMZBcVR846et9YgE3XDWP95V 4cE= X-SBRS: 5.2 X-MesageID: 40055392 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:i7m16Kt+oYjsieunWxZsjk2L7skCCYcji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOjbU5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qx6Y 5JSII7MtH5CDFB5/rSyAOzH888hPyO9661jenTpk0dND1CQYsI1WZEIyycFVB7QxQDIJI/Go aV6MYvnUvZRV08aMOnCn4ZG9XSvtGjruOsXTcqJT4CrDOPgzSh9aLgH3GjtSs2fjtTzd4ZgA 34uiPj4KHLiZ6G4z/ak1Te9pFH3Obmo+EzYvCkrugwBnHShh2zZIJnMofy9gwdhO208l4lnJ 3tjn4bTqBOwkjcdG20vhfhsjOIuAoG0HPsxUSVhnHuu6XCNVUHIvBcjoFUeAax0Sodlex8y6 5C0ia4sJdaHHr77UbAzuXITB1jmw6Ip2Mjm4co/h9ieLYZAYU+kaUvuGduVLsQFiPz744qVM N0CtvH2fpQeVSGK1jEo2hG2rWXLzkONybDZnJHlt2e0jBQknw85VAf3tYjknAJ8494Y4VY5t 7DLr9jmNh1P4MrRJM4IN1Ebdq8C2TLTx6JGnmVO07bGKYOPG+IjJLr/rMv5qWPdIYTxJU/3L TNOWko+lIaSgbLM4mjzZdL+hfCTCGWRjL20PxT4JB/p/nyX7zuPSqfSE0/kseprvkFa/erGs qbCdZzObvOPGHuEYFG00nVQJ9JM0QTV8UTp5I6Vju104L2A7yvktaeXOfYJbLrHzphcHj4GG E/UD/6I9gF6kiqX3T/kQXAQn+FQD29wbtAVIzhu8QDwokEMYNB9iIPj06i282NITpe9qosfE V/J7vjmrihpXa/+HvJ62kBAGsSMm9lpJHbF19arw4DNE35NZwZvc+ERGxU1HybYgNkQ9jOCw 5ZrVRv8aexJ5idrBpSSe6PAya/tT8+tXiKR5ATlum//s/jYIo/FYtjcrd2Dx/3Gxt8nhtKpG 9PZBQffFLWEirjhMye/dkpLdCaU+M5oQ+wZeZItHrUtCyn1LoSb0peewTrbOm6rkIFQSFOil h47qkF6YDw4wqHGC8Ersp9HX9tTCCsALxADAOKDb8kw4zDSUVLY0nPoRPysWB0RkPas389qC jbARepXMyjOCsbhllolpzF3hdJUk24RWJcA0oK9bFVJCD6njJa66ukTIyV/AKqGwM/6+kALT DIZiYTKAtyx9axkAWYgiqGCG9O/ORTAsXYFrQ7RbTa0X+pMuSz5Nw7Nu4R85B/ON/0tOgXFe qZZg+ONTv9T/gkwgqPux8eSWBJgWhhlfPjwxv+6mekmHY5HPrJOVxjLotrVO20/izhR/yS1o 9+gs9wteysMn/pYtrDza3MdTZMJlfSpmGxJttY36x8rOY3tLFpGYPcXiaN3HZb3A8mJMOxjV gAWs1AkcL8E54qe9ZXdzNS/1IvmtjKJEw3shbuCut7eV02lXfUM96A/rKgk8tmPmSR4A/rfV WP+SxU+PnIGzGO0rMXEKo8K2VbYkpU0gUXwMqSM4nLTAm6feBK+1S3dmKneLhGUa6fBPEeqA 1579zgpZ7lSwPonATL+T11LaJF/zz5HYe8AAeQFfVJ9NL/M1KWmaeu6NOyijCySTbTUTVoua RVMUgLKsJEgX0+iYdy1C64QKn+uFgknFtT+isPrC+Z5qG2pGPAWVhbOgjYiIhMVTZdMnKUnd 3ImNLoqkjV8XxAw93fD09ecdFFBsgIQoX2JyloL9IMvLTAxdtevg1TJBE0D2A9jzjh3+Rpmb ehsc+iJNHfNQ== X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="40055392" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Egt3gICVYG9PWWnrHbDpz0D7bT5zGRqJPSXh0xKHax+f4Al0618ZZVqEySH8/R5MLgvEds1E8slTZczaSmghfeFBliL7F/ymqLY3dv40LTJyQHIZPraa6XYH3bss6uob0j7oAY3j/1weVlw00Bk3/C3ka5puwtQPNMEzp6K13Qy//upHtuKB4zb/qoKn3U0kvJ3k/3FFamEEZKa+q9RBvv96Cme80zKrhxwSbjc+jBVcO1VW7LzawMYUb6VWf/7MwqRfRpRpoTmSQMz58SJreYtq9z24a2qRpl4DsxRFwjwXpGa/+tk9awBny1Dn7eOgoJ83ewMP6CuFlazfj0I5gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gTCmGbFvBsxXZnJ6Z7hVKQ43JE3lWvZovCCAb8H7ohw=; b=HvnkHgbWMoHT5Og3I292wIFJ+Y+o51+ee8DxkDpkQzLmtMPfWxGbz7CZtBw8cP/+rfWukAqZXn/MbW6yFZmZCKvo8TtgMMz5G56YAWhaBxDOgi4OAwn+ywrxPmyJO949fSAg9lQTZDF/xvut1j9QI68PwK18jWBsVdd20TZMP9UqpjOOy0oW9kFm/vOIRuUgMr3qx39K/8pMC9VNGPLml0V+YMnxOPoA3L4Du6S2sHEHxAD+2MpJF3yR/nsCmBCnzNyXA8mBMMVDoldY8Wu03uCai5932QA4+TOWXkemxpA2uI3ACgmIiFgFOwIzwVxO5ZC/HOZbXx/C0zclomj4Sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gTCmGbFvBsxXZnJ6Z7hVKQ43JE3lWvZovCCAb8H7ohw=; b=Bv+5c8nstfmbVERiV7hSs3ny3Gy0lTZq86i1I/DVyC7C/8gSYnRi88fElOH06x4xwnJF/TBNxQ3T7oLeP/8NShZ4+Of+Lgji+d/I1OBiwahjUo8gqX8yfTN+jQgK+ta63rDSqbglHY7xDm67irseTCuvdBpLW+TvnMEvVZX5xho= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 03/21] libs/guest: introduce xc_cpu_policy_t Date: Tue, 23 Mar 2021 10:58:31 +0100 Message-ID: <20210323095849.37858-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0135.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::27) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 945ca441-a6b2-46e2-17aa-08d8ede26131 X-MS-TrafficTypeDiagnostic: DM5PR03MB2633: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1265; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uPLwdr2Q/t4o7xvjoUVEXe8kBWVcW7phbeKhwr2p//nljg6VkdDumuRE9YqELGsyJ4YLCzNMCw8HSLZjdCGBtAMabFpnBfYjcJUSPNXdoPQ7hNf5BQyX3yaGwLT46lc8w4wCAz1zRx1OqYvSK3yeIIZvhBjhikadQUUxvgxbT6yBfvpj3rS6tpqFeCWm4G2EUzgIFg4bkkJSN6xgfz+7vC24wFJZbRv0Rw0tNO8m4MzYZ6tdcNg4pl9U1MPV/eWUgCAw2sdPa/5o4/HRirX7koK/mlNl8kRECMFzRooU243icgcJUDNWAQqfChYauKz2daIBzMeQn4Tqv1gZHBNszWr90o1bNEumXbBcO8o+cBOs9roa4Qf5XgV2x10dBbQrBQpsuJAKI70SDZr17aj+hzCSEvg3V2sXhY9BUpICZTSJ+78V/pmSF9h6UmKQUB3Ya+PUWjUV2DXFn/+7JopIbw/gC1E/eIwZImF6aqiCYSleYJH9Gz6p2N6AG2N0qHgtRQSExOv2Ajv9Kp1a6Zo8XDTF7+30EdXCvwJ2gt0zEHqUBxZhzrznNlxqPATAJAb6GH3Fv+/+XbEwbE3Ef7QYVhRCV6CaO7OMAWB8boMOCFsXaubtuonZR4AxVa1+a1e6DnpSUhfzh48I5PasDFEwdcTG7/IpV1uTzCRTgQqfBc4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(6486002)(6916009)(36756003)(6496006)(2906002)(8676002)(66476007)(5660300002)(186003)(66556008)(66946007)(8936002)(86362001)(4326008)(54906003)(1076003)(16526019)(316002)(2616005)(38100700001)(956004)(6666004)(478600001)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ajAzbnVqdzdDUlRLbGEyRk4xSlE3SStOenQ4bzAwK2gxUUl3T2huODNQREFs?= =?utf-8?B?Nis1MDRRWFduZ0ZJRVlVSVIrQnpFeFhYUWlCdGh0UDJkTkRJQmE5Z1J1RTdh?= =?utf-8?B?eHJNTEZQRjJzLzUwY2NReU56aGtVOU1xVTZQbEpUVHliZ0hyTTF3L05ERVBH?= =?utf-8?B?QUtScXR1YVIzWG5LVXI2N0dpSHFoMXBiOTBIK1YxWTFTa3FBeTV5T0gvZTJV?= =?utf-8?B?WDdadlRyMHVZcC9BLytLc24yTGxmM1pvdzg3L3Y3NFlGNU13Nk9KTzNJSmM3?= =?utf-8?B?cksvcjVrdkRnZE50NVVGNncyQmlVTnJiUnpGaGZsV1Bxb2NrVWxVbkNDMy9U?= =?utf-8?B?V3g5aTFqYWZETFB6blRHOGd2M0MxM1F2ZnhING5ESWlyaW5Ia2J6bWZqNTc0?= =?utf-8?B?blRWL2JlZmh0cGtubnU2Y0poNVEzdTJCbXVaR3JQMEY0M3VTelBrLzRidmxK?= =?utf-8?B?YnpYdWgzOEJDU0htSDdzdmdCWHU1TG82ZDBrSzFaOHdNL2xrdmUwWGVwUVls?= =?utf-8?B?c2hQNVl5eXhRUXpNODFlZW5CRjQ4eHVCUG1ucElGL1k4MEhsclNkUWpIZkY2?= =?utf-8?B?dUZ6YkgwS2JndTROL0pja3k3T1NJYUc5T3lGVjMyMWJmM2d2L1VUU3djaUJi?= =?utf-8?B?dGpKeXMvWDVmOTZtTURVMnVCN0Z5bHZwcExhTzIwc3grZnN1bzVBSVBiaEtx?= =?utf-8?B?Y2hiMUtBRUhiSkptMFdBczRVcWRnNUhJOGUrbVZCRytMRmpqNE4zUVdKNVha?= =?utf-8?B?cC8rcjBKbmRxUHFNOC9Pb0RhNDYxWWdXQWkwWEtIRlRtVUw0WU95RGJyU2tO?= =?utf-8?B?SDc0WmZPdGRSTzhXcnY5a0pzWU1RajF2dDUrNktEekVxa3l5ZnVVT09mQUhn?= =?utf-8?B?cVNSbGdCdEowaE84VGpmUjdZUHp0Qy9lSU5XOXQ0Nk9pR3hXbVIyTjVMWk5I?= =?utf-8?B?S2ZkTDFQVDdSWTdFaFBGdEJLM3Z5WStpbGVMYWlhUmthZWRCbFhuQk5qVmYr?= =?utf-8?B?ZHdYNkx6OUpqVXNZdUVqTGRwUFFrWmNIYjByRmtrUVVmMXYwem85anRBOXBa?= =?utf-8?B?YnBsclhGbmZoS1BnYXdvY3JkS1hiVjJYTEhPdVlDcjRTYXJpQzRXYStLdUcz?= =?utf-8?B?Mjlha3JtSXh1Ujhtd1Q1Uy84UGNKRHErR080czViclZZMmFYZDM1c25PQVV0?= =?utf-8?B?bnA3akJ1c1c0UXVxL3ZIOE5jUjVSOXBBMHkyUXlXSEJqUUxlMDVNengvb0Yx?= =?utf-8?B?M3hSVm1VckpzOWxUdDRxWWVKc2NNSkNFNUJVRmR3QjZMcU1XdGRYdEwvZ2JR?= =?utf-8?B?aEcwVUViSyt6NzgyN1Y2SG44L1duYzBtMVE3NUMxTllEQWFkOFdZdlVDeXBr?= =?utf-8?B?THNBeVpDZFF4QUpqRExZbHJoVWxrczIvMGlVcE5ZN0puZy8relJLeHVoc1JN?= =?utf-8?B?TmNaS08vaGl2SUJ1bk5IY3lPUlEwZHJtRXp6ZFpBZHhrWUlkUy9JRXNiV2s3?= =?utf-8?B?R1NOSTBvYzJkTlpqemlTWWF4SGc0SmlrZHRtS2VtaXA2ZGthQ1RML3BvTmd1?= =?utf-8?B?T3RhQWExV1F1L0pJYXNpQU9SYW0zMEVtN00wOWMrTjVIcmt6c0srbjRVMWZL?= =?utf-8?B?bzhxZHp3cSt1YXViOElvRmdtRjZPSTljMzhlRjQwa1NpYnEzUmFEODhDeWRW?= =?utf-8?B?aGNWN0VGVU5tZEFodlJ6aDcyc3AwYmJEMGxKNHJCNzh0NUdhWTdaV0tUaGpM?= =?utf-8?Q?7bpOO8ESpIsOP1twIUA46CD1j9ighW+rqCNgV/e?= X-MS-Exchange-CrossTenant-Network-Message-Id: 945ca441-a6b2-46e2-17aa-08d8ede26131 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 09:59:42.3915 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AObCEWCVcAe0wKnJ1V30eRI7bt4rx9vgytfYHSzTIwNgZDp1cvtAewbyZQFPPhvbrLu83kv4yL7cquYowOmdPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2633 X-OriginatorOrg: citrix.com Introduce an opaque type that is used to store the CPUID and MSRs policies of a domain. Such type uses the existing cpu_policy structure to store the data, but doesn't expose the type to the users of the xenguest library. Introduce an allocation (init) and freeing function (destroy) to manage the type. Note the type is not yet used anywhere. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 6 ++++++ tools/libs/guest/xg_cpuid_x86.c | 28 ++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index e91ff92b9b1..ffb3024bfeb 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2590,6 +2590,12 @@ int xc_psr_get_domain_data(xc_interface *xch, uint32_t domid, int xc_psr_get_hw_info(xc_interface *xch, uint32_t socket, xc_psr_feat_type type, xc_psr_hw_info *hw_info); +typedef struct cpu_policy *xc_cpu_policy_t; + +/* Create and free a xc_cpu_policy object. */ +xc_cpu_policy_t xc_cpu_policy_init(void); +void xc_cpu_policy_destroy(xc_cpu_policy_t policy); + int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, uint32_t *nr_features, uint32_t *featureset); diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 9846f81e1f1..ade5281c178 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -659,3 +659,31 @@ out: return rc; } + +xc_cpu_policy_t xc_cpu_policy_init(void) +{ + xc_cpu_policy_t policy = calloc(1, sizeof(*policy)); + + if ( !policy ) + return NULL; + + policy->cpuid = calloc(1, sizeof(*policy->cpuid)); + policy->msr = calloc(1, sizeof(*policy->msr)); + if ( !policy->cpuid || !policy->msr ) + { + xc_cpu_policy_destroy(policy); + return NULL; + } + + return policy; +} + +void xc_cpu_policy_destroy(xc_cpu_policy_t policy) +{ + if ( !policy ) + return; + + free(policy->cpuid); + free(policy->msr); + free(policy); +} -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:00:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:00:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100552.191650 (Exim 4.92) (envelope-from ) id 1lOdpR-0006ta-Nb; Tue, 23 Mar 2021 10:00:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100552.191650; Tue, 23 Mar 2021 10:00:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdpR-0006s8-Im; Tue, 23 Mar 2021 10:00:01 +0000 Received: by outflank-mailman (input) for mailman id 100552; Tue, 23 Mar 2021 10:00:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdpQ-0006iw-10 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:00:00 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5283454a-2c91-43a8-b4f5-40d42cda4fee; Tue, 23 Mar 2021 09:59:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5283454a-2c91-43a8-b4f5-40d42cda4fee DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493599; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=sKTDxYJ3rj7iDKcoGoTCGrSKTjWKjCAlgiHohEHoEzI=; b=C7/phOo+BQQc99HiH15nG6eILjbcUvmWtgaV4PLtZ5KN4Uk0Yjjo9olg 7oNlvtC1pwY+uo6scR+ZbQConk6Pr+1+B6eEXEyFTp1TYIwhYazz0jY9p ROATDUSxr9c9Bck0FdRvfxRW7gkHOp/gyP7pe014DIKHsjUUf51uXzisp g=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 05RJMFpPOZsEkpnGZ4UWBWfrkNvB7rlXZK1avQKDnL2LNL8pcGWvqp33TA0n0La6yYR3KoWAaR FXmCZ4XShXC2KxuTLZOm7tqVVeQkoYAWz3tOep4RcCACLwFSD8yD+7F5pZLHQyQQffOrMEH1B8 9NN+zWkRCbjsq9mVLs/qVMUvLlyXZ6V0atOK3Xm9Ieb0BOJmB6XdXxrucsUBGuJI5znnUBAK05 zFcBS+Fc28lcpgFdxHHCDYaf7G9DUTAdq5TH81Oatd1p3bTPCbNem5Rf7+Tc17m6SCH4BMHndZ HKw= X-SBRS: 5.2 X-MesageID: 40261142 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:8NXDdaxVIRa8umfn2WASKrPxqe4kLtp033Aq2lEZdDV8Sebdv9 yynfgdyB//gCsQXnZlotybJKycWxrnmqJdybI6eZOvRhPvtmftFoFt6oP+3ybtcheTysd07o 0lSaR3DbTLYGRSpdrm4QW+DtYryMSG9qftvuvF03JxV2hRCp1IxS0RMHf+LmRdQg5aCZ0lUK eG7s1cqDa6PVgRZMK3Bn4KNtKz2+HjvpTgfBIAGlob+BCD5AnYlYLSPjq5+lMlUz1Jyao/6m StqWLEz4iqrv3T8G6760b99JJT8eGRqOdrJMvJscQNLyWptwDAXvUbZ5SnnBQY5N6i80wrlt 6kmWZRA+1W52nKdm+45TvBsjOQqQoG0HPpxV+GjXaLm6WQL1hbeqkx975xSRfX51Etu9txys twrhiknqFaEA/am2DF78XIPisa53acm2YokuIYkhVkIOwjQYJWxLZvmX99IdMrGSL3750fC+ 9+DM3Qz+Y+SyLlU1np+kZo29CiRXI1A1OvRVUDoNWc13xskGl+1FZw/r1Sol4wsLYGD7VU7e XNNapl0JlIU88tdKp4QMMMW9G+BGDhSQ/FWVjibmjPJeUiATbgupT36LI66KWBY5oT1qY/n5 zHTRdxqXMyU1iGM7zP4LR7tjT2BEmtVzXkzc9To7JjvKfnebbtOSqfDHgzjsqbpekFCMGzYY fzBLtmR9vYaUf+E4dA2APzH7NIL2MFbcETstEnH32UpMbmLZDrq/z7fP7fKKGFK0dnZkrPRl 84GBTjLsRJ6U6mHlXihgLKZn/rckvjubJ8eZKqutQ7+cwoDMlhowIVgVO26oWgMjtZqJE7e0 N4PffCmqO/rm+mwHbQ4wxSS15gJ3cQxI+lf2JBpAcMPU+xW60Eoc+jdWdb22bCARNjUcXMEk p6q05s8ay6a7ycrBpSRe6PAya/tT8+tXiKR5ATlumo/sH+YK41CZ4gRehWDgXEFxt8nC5ws2 ddYAo4RkvSfwmeypmNvdgxPqXyZtN8iACkLYp/snTEr3iRoskpWz8mRTK0aNWWhgwvXjJQoV V0/8Yk8f29sAfqDVF6rPUzMVVKZmjSJL5dFgyKaL9Zna3RdBhqQX2HgiGbjB8PanPnnn9i9V DJHGmxQ7XmE1BdsndX3uLR/FR4en60UmhwZnp52LcNXljuizJW66umd6Cz22yeZh8+2ekbKi jCeiZXCBhp3cqL2BmcnyuiGX0qyo41BPHUCK0uftjoqzWQAbzNsZtDM+5f/Z5jOtyrj/QCVv iHfRSJaBz/EOEk1mWu1wAYERgxjENht/zm2BfotjflmFE+BOffO1RgSfUwJcqG423tWvaP19 FYgLsOzJ+NG1S0TuTD76fdKwNnAFf0h0WdSukzs5Bava4ortJIbtHmeAqN8EsC5Qk0Kcf/qV gXT6t66o3QI4MHRb1mRwtpun4S0OmVJEQlsgbKEvYzUFEkgXjcJc6I6dPz2M0SK3zEgAPxPF WFmhcth8vtbm+m1bQADbg3LnkTQE8g6G569OfqTfybNCyaM8VC9kG9KHmzbft0T7WEA6wZql Jf78uTl+GaMwr+1wa4h0o3Hot+t0KmS9i1GgSCBKph9MG7I02Fhu+S2/GI5Q2HAAeTWgA/no 1KdUsZc8RFhH0DteQMo1ePY52yhFkknVtY6SxgjXj31OGdkT7mIX0= X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="40261142" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ikA4WW9FVNw8sQq9FVBmUh2iYFw9X8pd5utQylRER89bmHB7IM1Q73QOfIgqgOrueBwlcy9rzxVuD0GiL+stTP01zHWwzTF2jNK3aPabZQ0wteb+TtTEYT5OabZa8gZ6v1wNuaRJvLxsLUKZL8cDBB5EbDeKulc5EmIiREUfUzbCGt+lul3LnlNaZALQr1SNMCsWPbL0RDEZZmbPhtLp/bhVo4dadAplTCuVomw6Ad45ORump55z7kpFiXWnVcCLtj6tYGXuoIw8kVmnhM0Q2+4RwmJHSHh9ff6Z+l6cmDBuNsrqF3lad9d+8c55W44KXivR6hDs8LiE8Hm4x5W+Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XiniRgb9Usi7cOKyAntrG74P2w6ZoVZ1eSYmJ4efxZU=; b=PdEDnW8tL8CSRxxAukw/wrUPNe7sjHUYj8wARYpMVvtWW+fbfYvG6UkFcGlaHkXqTJ/4ymSusy1va8xxRrBTDjB49GYP1vPZrTPiKR9ldSjKF2nKvtczaDOtNdlBVb2ZGvtIl8K9PcFXSLQwyYCYheNjjNnfP/h3Unlil+JpSDJV1UxjYxfYF0WrZb4nCLzpZilyyoLv++YsMCeiKDzGFSPO27wIgORZ8vBACikK13WQxag7Q0AaPZNajo3RwBkbcs9XqEDRXNaucHvybVz55lj0Yqw/2FWd6C/QMP8c08FZkqsLiPKNg5ARoCORgIcpPf3f95EhZcvBlrW4E3wnKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XiniRgb9Usi7cOKyAntrG74P2w6ZoVZ1eSYmJ4efxZU=; b=RBOajU+Tjs0IsUqY2oJPzIPeEOy8aOQqNpcQXvkBUyrHpeO2jWy2zJdNTB4PSP64At1fJgyXMaqV+AcH6elYkXUvyF5kayK3vBe8XzqbtQWSThe3ctK+iQN3vulb0j8hEq9QWu+uKdHIy//VGyipWaOWpCM3BKQ39QPpu5ttsXw= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 05/21] libs/guest: introduce helper to fetch a domain cpu policy Date: Tue, 23 Mar 2021 10:58:33 +0100 Message-ID: <20210323095849.37858-6-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0124.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::16) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31fd0c1b-e2e9-4a97-4847-08d8ede26874 X-MS-TrafficTypeDiagnostic: DM5PR03MB2633: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:529; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K8GrBI1odyLIpbb0bCGG8EdkjagxIrpA1WBzJiz7XN3Y9RIFGI6HhdgnuLFtCwtvZbXzGdyvcMhvWIK1J0AdZot3HVidqqsCG5ME0sek4NAVVEibR2Sxx8KKZV619TIhr68uG7yxRhCT1DN7GnXgxWr5Tau3cxY+ZeTLWI3HsvPi6BeuL8HpcOXo+xPfskJAFfycoSyV0tQXbCjyO0GRJlT3N3YUoFs7OsjH+cWJFBBDbXDN+VdY675tiwLgAgIw8Q7ZIRLU50Tjd0EGgYUH7XaoVW+Z/wNH5bN6CjX8+gTNN88ALyxCmBFwfp9e5q6OnZue9GzVgzNKyiXMkdKaoaywv1TqkQvt/r8Yuu5xcrNXmNzkZcXl+vrR43ych4baXTD4afXsdaN4X1zunFTi4qNIkaMnyK7+0nGS/siWAeZO9goo8MFkWkJcNXo+4HR8iYCUfdtTexl8DL7DjQRH8vZ2s039m3nICcI15P93fQRyHYOWjYCVhJhah+BNcNE+058+/lD/l9jNZSw1nVphDfQx80QJ85MDIfG9SkQl+2f3M4Xcu4YZQvHeAlQMV8P/s6Ulie2lJlzFwUGyUfiBg0EjCqZ+Lsqb8mDVmpwhfNClRoykxZORAUg7vVGNPq+9wu8ercLsys/nYK1fx4Z6y0RSYdvo2jJ4bzsxfmZImv4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(6486002)(6916009)(36756003)(6496006)(2906002)(8676002)(66476007)(5660300002)(186003)(66556008)(66946007)(8936002)(86362001)(4326008)(54906003)(1076003)(16526019)(316002)(2616005)(38100700001)(956004)(6666004)(478600001)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?emwxdnRucDREWEVKYXVWdllqaU92OTUwTzIzVmZZSzBtY1QxQkp5Y3NkeVNm?= =?utf-8?B?bkN1WC9DVmNkSk1Xd285UjR4Y0E4OUNuaWlNZUljcWJ2WEpxbExXeFRSek5Z?= =?utf-8?B?UGZKYXlsL25HMnVPNHlpUlQ3a2ZHTFZIUjFGcEo4eWVOdUl6SWxNQUVWV1lI?= =?utf-8?B?N090VTdDYjJ0UXpCUWVjRFdhWDh2YmZ4bEVMZUk2ZVNOSjBMb1EvS0tHdjBS?= =?utf-8?B?RVZhWjYyS1BPTWdkSkhOR25hR1czSjFYUW5RZ3hhb2xYcFg4cmZMYjI0MzB4?= =?utf-8?B?TkVudVQ2YzA1bUM0ckdHRG53ekxHUVcvOThIR2VDVFMvV2Z3Mkh6bUJnWTU1?= =?utf-8?B?cTZjSDdXNEpzbW8xazV2UUxzV2s0bkJQck9RZU5PQ0FDRzRLaFA4UExmTTN1?= =?utf-8?B?MFlGME5VcmRsRHgyRnJ6N3gyblhCaDVFTGNtcWFQYmw3ZVAwaTR5VDFrVFlE?= =?utf-8?B?Mkh0a0dSNVJaWVI0ODZPby9aWFlPQmd4THhaTURpbFlHL3lHYytPalFvREdO?= =?utf-8?B?bE9DYnF5MkptdW9DUC9XM0FrUFQ1ZDM4bzI0WmFVRFh4ZUpoYWNUZFVFR3pa?= =?utf-8?B?a1pRU3pDTzRwTmZJN0pHblFWd3ArOVlVOHBmc0xqbTZkbk9vN0NMZ21aVzdQ?= =?utf-8?B?K2U2ZVpiMmpodG1Zb1pIYllJRmxUbEpNMVloSDNvR25LUUFZZSszK2Z3Q2dM?= =?utf-8?B?VnZ3MCtYVWlUSDJrdzlVYytXcXJRc2ZuaFQxT1BMU3Avc01BS0xVSGlnSTlG?= =?utf-8?B?dWF2d2kvTnBzT1FERHhmZ0lCendaUmUxaWpxS04xRlpzMzduM1BPcmgrTEt2?= =?utf-8?B?YUc2OXBmcVAwMmFRZUg1UitpRXlON2d4L25rWTFLclpZajhUWlRNS3U5azRp?= =?utf-8?B?WFFPQklJNFpiNmNwbENaWGFSaUllSFJkZ0RwRWdMUHgzK0FrZm81dEt6OHFP?= =?utf-8?B?anZHcGdscm5adzdCaUEyN2Q1K0NqeG9KOGpmT0FqYmFaZ2dXMk4zSklkODJ4?= =?utf-8?B?d1Mvb29hSCtlKytEY3BNNHg0Yk53blgrS2U4U1JETEVYbUVTZzdvMkFpZ3lv?= =?utf-8?B?NzJTVVBzQkdlWDY4WUI1dFBGMmc3ZCthcDN1TE9pM3ZEN1dLQ2lwTm5ZK1JH?= =?utf-8?B?V3dKUWRzMFZIOUdSWGtKNUhhK2JpMi9RaHE5SmdoTkNaQ2tCbWxGVHIweGpF?= =?utf-8?B?Q2g3UldaMDBBTFh5a0tFdFRaQ3JHU0hsQkxzV2hXNk5ZZHJuOTRTYzh6eXpQ?= =?utf-8?B?QlFGSU13c0ZGb0ZGKzNOUE5OTlFxT0xwQ3FiOFZ0cEROSmxBVjQvU1gySTJr?= =?utf-8?B?SU5IWGxXN2lDSXBoNmQzaE95Y2NSdUtwOXVCem1UVXpTcUFHeFZoczYxRmVD?= =?utf-8?B?SkllU2RyMjBuZWowVGxFWWpRU1JFenVMb00ya29LTGRNOXJpc3VXY290OFU2?= =?utf-8?B?Ni9oUmtXdWkvWEMydlhMR0Y2N0hwcGM4ZDlzQmdDMjVPeGRzR3dRQWY3T3dY?= =?utf-8?B?N3lvVFcxMG5jY1hwQ3RIdUxyMCtXTXZXejFPUnVqYzFMYWRpdjJMVmZXSU1s?= =?utf-8?B?SzZ1QjdNMHU4bVZ4V2pKWElWU0hRdllEM1lRMEVWazZGcGE0MGtGL2NpY2cv?= =?utf-8?B?UWpJUis3V3RQU3ZSaXNSQWVNTTVsbkRHenNJbm9SODBPeUJocHB5N0tEODJ2?= =?utf-8?B?d1BremZEbnhqaDhaclAzUitBRWlXMkVJSTBSQVJVZStMVndZM1llczFuZjRS?= =?utf-8?Q?jEb5oJ1WqahHoNHmjGVq+j5kV7CWC+6tWqTqMSr?= X-MS-Exchange-CrossTenant-Network-Message-Id: 31fd0c1b-e2e9-4a97-4847-08d8ede26874 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 09:59:54.5848 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o3flLIZS9a+/qHR8u2FBopZvPkjJX6OnSDjyqkq9bjb7eU3e5ND+EhFilGQkNXBbcCutF68/ItZ/Er5X4aWPTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2633 X-OriginatorOrg: citrix.com Such helper is based on the existing functions to fetch a CPUID and MSR policies, but uses the xc_cpu_policy_t type to return the data to the caller. No user of the interface introduced on the patch. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 2 ++ tools/libs/guest/xg_cpuid_x86.c | 34 +++++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index fc8e4b28781..8b8b30a2764 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2599,6 +2599,8 @@ void xc_cpu_policy_destroy(xc_cpu_policy_t policy); /* Retrieve a system policy, or get/set a domains policy. */ int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx, xc_cpu_policy_t policy); +int xc_cpu_policy_get_domain(xc_interface *xch, uint32_t domid, + xc_cpu_policy_t policy); int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 3710fb63839..75ac70996ac 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -777,3 +777,37 @@ int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx, free(msrs); return rc; } + +int xc_cpu_policy_get_domain(xc_interface *xch, uint32_t domid, + xc_cpu_policy_t policy) +{ + unsigned int nr_leaves, nr_msrs; + xen_cpuid_leaf_t *leaves = NULL; + xen_msr_entry_t *msrs = NULL; + int rc; + + rc = allocate_buffers(xch, &nr_leaves, &leaves, &nr_msrs, &msrs); + if ( rc ) + { + errno = -rc; + return -1; + } + + rc = xc_get_domain_cpu_policy(xch, domid, &nr_leaves, leaves, &nr_msrs, + msrs); + if ( rc ) + { + PERROR("Failed to obtain domain %u policy", domid); + rc = -1; + goto out; + } + + rc = deserialize_policy(xch, policy, nr_leaves, leaves, nr_msrs, msrs); + if ( rc ) + errno = -rc; + + out: + free(leaves); + free(msrs); + return rc; +} -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:00:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:00:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100551.191638 (Exim 4.92) (envelope-from ) id 1lOdpP-0006hO-7m; Tue, 23 Mar 2021 09:59:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100551.191638; Tue, 23 Mar 2021 09:59:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdpP-0006hF-4D; Tue, 23 Mar 2021 09:59:59 +0000 Received: by outflank-mailman (input) for mailman id 100551; Tue, 23 Mar 2021 09:59:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdpM-0006c2-U1 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 09:59:56 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7f4fea88-8a60-46fc-ac7d-1b6ba6b0cbd6; Tue, 23 Mar 2021 09:59:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f4fea88-8a60-46fc-ac7d-1b6ba6b0cbd6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493591; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=4ldnVDCZNMkxZxjsBX20L+XDZ7xhEL53HLTGBDuMf1k=; b=f5jEFTNI+SXMXovAZBuNbmLf/YsS5UcGeKb/jKshBjihlzy8VX7/+T83 GNQxY+xBmqOcQ1WPryn+b/pbNdePHyh8xm5TFPiE8QBY6jD0Qil4PedXZ uVY1PZf7KhghYOlYz2mnvc6+VTVg/xuoYY22zhbadSqDFrx1cjlsUOEye Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: aAoWUNYFj3lvfJBt0RGzZMLlCo+oHqM3AZczFG+Rp+nxn9QmGqugJFNoHO5bD9OvG/nQXNml8/ JN2UKRDxFeNv3KJpF880fqjrhn6XlSbV6sjiSFXIdcxXpyXE3q612ChQAdtGkMe1me6t2zuS0R uCtN+sU0KREphmk9xB14NUbePi7NU5ORGLNw3biR1Mve87jSTd4KDhaEvRhK77TB9Bpmwtd902 rSEE+RbiD5lKmXoLonAHgxTBqGrfAckwHG3bhqgzXS+UvKcO2Onj+3fPis6mb8hUaewNTyI/e6 hYI= X-SBRS: 5.2 X-MesageID: 40055398 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:P0QzEKmU6dbYfqmFYbTcnQg+ZHjpDfP+imdD5ilNYBxZY6Wkvu izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/NIyKMaVI3DYCDNvmy0IIZ+qbbz2jGIIVybysdx94 dFN5J/Btr5EERgga/BijWQPt48zLC8n5yAqvzZyx5WIz1CT4FFw0NHBh2AEktwLTM2YKYRMJ aH/MJIq36BVB0sH6eGL0IIVeTCuNHH/aiOCXI7LiUq9RWUineQ4KP6eiLy4j4lTzhNzb0+mF K18TDR26PLiZCG4y6Z7UD/xdB8mNztytxMbfb89/Q9G3HXpSuDIKhkU72GljgprO+o80ZCqq ixnz4Qe/5dxlmUUmapoQb8+wSI6kdQ11bSjWW2rFGmgcvlSCk0A8BM7LgpDCfx2g4bk/xXlI dotljp0KZ/PFf7swnWo+XsbVVMkHG5pHIz+NRj9EB3YM8lR5J66bAE8Fg9KuZnIAvKrLoJPc NJF8/m6PNfYTqhHgrkl1gq+tCqU3gpdy32O3Qqi4iQ2zhSqnhz01EV8swZhmsB75IwUfB/lp z5Dpg= X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="40055398" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f3xj0QHynsjm1a4qlzCCGJSuBXIu8dxHZb2Nn4Py0kT1ecZnS5lHBDPJjn5fn8ZNkFiZfWUX1fEe3ngDypsituZ19gkc+j/e3W0BRyZbXmEqf3/jdhua74qYpR0gzooKpQqkUrZCRaHrOd1sl2AbYXp3+avYSr85w5MBXRboTUwITTnOcEkbail+Y0cYGYoedTcIH74eAtBteeDF8V5gg1c6Pr1jb/Y2G+xLIsqHurxzaX6aq4OsAhBKkx8Geb3aNGSbrLQtuudFeoApKlkvUb4mrNAH87SN1aKmmyGrDnR+cuMRkbGnKKNjYb6hRz4vGYZhgDv2cSVTVFbueFGccA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GrIo5m2fuMUp8p1rJaMPBWTn479oDj4kTjXRWS9pdDA=; b=K4+Dd7MGjGQqKVXDjY99ipJfqA7nBTFbnFG07wptaqW4I2heKdB+OaWMA5MITdO/lX+OM5HtoKdeeL/s4ohyc25ETmolbsJpZHi+MS13sv34p1WLhr0fnFdORf+hFDEtsU2rBUNin/5FIVexIYbyz94tP5MGtpB2BRcGJzfewYEBckO6oLgyaGsMqebWffkBnshQiEeRktr+0SyhfzgNoHWloClGHFvRxcNCz4xEp1fzllxI29kTt7ForvsHeL3NN7eoc21JigDOyV4lW3etGoG0GQ6zfUiQA1n5DlzV2oBHueLdAM+o4sk60uVgo/R8cL5vHmGeuBVpUdWW+uvCPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GrIo5m2fuMUp8p1rJaMPBWTn479oDj4kTjXRWS9pdDA=; b=lPY0yt0Q+xkCpGOh2o4TRrbTLclcdnnyKjVc7tHuBpGUoYmEhYdpqW0IrFP4ORuTslVq+tpdSaY3J/f9gxhzt+f8JGlCAbn48k/7Z2WhyH7RAycfq7BCt81GfVKkh/TTIisBsu6aAOAG630ypCjvMgvOFtbJerdXfcvWDs9AYzM= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 04/21] libs/guest: introduce helper to fetch a system cpu policy Date: Tue, 23 Mar 2021 10:58:32 +0100 Message-ID: <20210323095849.37858-5-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0142.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9271642f-2c8d-49cd-cf0c-08d8ede26566 X-MS-TrafficTypeDiagnostic: DM5PR03MB2633: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:127; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Wpun/9Czamem8RV4146BZzJCpvOWa5XqCrnXdW580T+QrK0Aw0aAcsen4SDIBIFluO6q5WnfDoqXyFDiJ9GoZZh0hlM33CD0+Cd+olV+C80KUeU+Jc+nBgDX8OUumAKP++oosgc0K6N3KcF2E9PEh6Z3liHnBOwDydmY1mKOwjfgbwtP4AoOTwR4vYevzmjWSnmRKlbGKO3+/y4xpOEIU2Iml8krY2Xs3PvUwNiCJ05ShuTfut8PAv0TrjhnVWrEJF92R+Jm5BWrOl4ZIid6VISlKLApEGWHI+8uMwA4TAyvGLn0tJToVJmleJsXEYh4Yy4YE6t4KBcJyIRidx+f4VxXgagLQx/el4YNoi69RtlpXufUDP2aUC7Cp0BYLeHa4U75hz3VO+nHrrH1qFQPWLs5mxK6uRt0I5rf6BaMshQYbCf9CjIJ3Cc9F2Vq9oqIXRxrH+vC+yWyGajY0XuixkpctTaOCE7HFCVKoKE2GWeWTCHDkFDecBxT0PiIzhiVAuWN8mLIiWHzxX795zOaDnoFgoROR2JGJ3V9RsQhhEJoEJkSDJyms6ShT/W/5A/Qs2DJPRkg1GF387ZcuVP9jgAhTiayAQOVY2ynU9bLaYDuRJ15UWN7EfMR1Jk+3+PNx3FlS1nfNCLT1VCTjqUrT6s8X2Zkrev3BT6cadmQgf8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(6486002)(6916009)(36756003)(6496006)(2906002)(8676002)(66476007)(5660300002)(186003)(66556008)(66946007)(8936002)(86362001)(4326008)(54906003)(1076003)(16526019)(316002)(2616005)(38100700001)(956004)(6666004)(478600001)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?R0ZtK2tCVXBNd2Z6Z1ZBZmRBakFmb0RMWUJOWG1qZGlYb1hZWWQzWDk3ZEtJ?= =?utf-8?B?dlJYTXJ4djNQdituejhDeURoTDJmZkptRHVBZ3RsYU95OFVZNHl4QzRGRFFI?= =?utf-8?B?NisyUWdaYVdnU2Jva2hlenYvYURmTUpkQVBERWRFYUozZ0g4UWYxekxKV0RH?= =?utf-8?B?YlI2aU54TjZwSGlqWXRsUlh0NHpnZkc4WGFHdjJIOHBDbDNydE9QWThESUZN?= =?utf-8?B?SmoyTTR2QkhnSWFKK2t2NTFPT2huYi9vR0ppb0ZoNjNiL1ZPZ0o5QWhTSzh1?= =?utf-8?B?UkppMEZVMzRXWXlqZG1ZVVV4OXVwcXhnWTFyT2llSWtFWCtySDhqM1NQSnlr?= =?utf-8?B?aENUNjA3NnRHaWc2N0RjTkhZN25lbkEyN3Q3bitSVzJ1aks0c3JQcVhENEtN?= =?utf-8?B?M0o4VHBxT3VuMjI4RmFtbS9jaW9EcDNpUWl1ZkhaVlUxd2lEa0pqeEdTWi9K?= =?utf-8?B?c0dSZ3l5bS9pbWlhdDU1WVZvL09JZjA4bDFZZWx5cDFlVWV5dHFuWEZLMlV5?= =?utf-8?B?SVduTkxsWlY4aXpka0NHRC8rNy8vTEdXbXEyZG9IVXpjY0xJRGpUQTlzR2FW?= =?utf-8?B?dnVjMkdOVlkwTlNiZnRzaHJuK1dGY0srOHpLR2tIZkpweXZiOVhXcnBLZXNy?= =?utf-8?B?VkJlS1FUUEczYUthcitIanJsUVQ3dmJ5NVovc0NyazJHU1Q5TDMvTnJxT0hX?= =?utf-8?B?cFh2Ky9EQnNPdzg0cS94NEFKVWdpanF4Nml5WVV4eUdsRG5hUDAvd0p3YjUy?= =?utf-8?B?RmVVdG9XMmY3aG4rTFQ2MEZSckNFbk0xUENtSGQzNEdRWHBIREVTMlJrZFdB?= =?utf-8?B?Q09EYTR0ajBNV0pVa29VQUFUR0RGRlJqekhZYU5KTS9wM3VESmYyR01YREg5?= =?utf-8?B?am9maGRqNStzSmFxUGwvRGNTME8wbHRWbXA4cWdoRlJGb0dzZVIwWlNwVFQx?= =?utf-8?B?VGw2bkdIbG5TenpOZTROWTMzV3l3aUkzQjZiYUZtOHpyWHY0a0J2THhqcXB4?= =?utf-8?B?T1RvMnJLeC81dW85VlFqdXphMC9lNG1FSE1mUDUydlo5WGZqNVlhTDZ6d3l0?= =?utf-8?B?WkNBeEVGNmNwZFgzWkVFOHJjTVZoWEd1cVBYbnlQL0RuRXNoQXk4bytLT0Zo?= =?utf-8?B?dkkwdFBaMXhUb3o4Q2pwVGJLeXA5a0JhZngvSFZDRDg5bG1EVWxreWxoU1py?= =?utf-8?B?ZlpVZ0JMOFRqOFRqQ3ZwNnl3U0tXK3NGVDJoN3dMaHNmQlVudy9DcjhJNE9F?= =?utf-8?B?S0NDMTR1cmFqa2xSd1p2eUNDMGd4S1ZYUUJFRUpHNVp1aUtJSGo5RkoxeWho?= =?utf-8?B?T05nRzdsNFRCWm1Ja0t4czBORmkxVHVwSlJ2QktZemJlS1hneWhPV2FCaGFU?= =?utf-8?B?ZEl6SHkraFpZcFZjQnZwUk5JUnZnTlh4VS9JUi9RdlV0eVNSY1BvbEdsSGli?= =?utf-8?B?YlJQL1lETk1jUmh5dGI1Y0tTYTNsQ2xkaFlLTm1LcHZyNVdlODJBeGx6RXZm?= =?utf-8?B?czdETk5jUDFCUmduZjlhWmFPVnFaUE5vUkZBcVArWlhyTkc1anJrOWxhMjA5?= =?utf-8?B?OWp2dDFxaVZPc2pVU2VwMG90aWw0cFF0c0g4aWM5YzVVNm5XZTVsKzdyaCtZ?= =?utf-8?B?Q3JORlFDaUpOV3F6Q0V0Ykdwb29DMG1KVTlvTjBmYit4eWZZUXQ1Zmk3NUFh?= =?utf-8?B?d0R4MDl3bGIzQWpLalBKUXBUNzFxWFpsY3ZKNjl2aU84WUNlSWhvWG1FN0ZU?= =?utf-8?Q?v4I6MsGWfSoySxQSznH87YOLqRlclJTieBis9v+?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9271642f-2c8d-49cd-cf0c-08d8ede26566 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 09:59:49.3569 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g7h13i4YLjc0tvNUR5Nd1PVCJ5TFWX1RGMfxC1bl7mN9BwktRXPwtXSIy2TkhmVNm/hvAXg7QkEGwe/gvC9boA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2633 X-OriginatorOrg: citrix.com Such helper is based on the existing functions to fetch a CPUID and MSR policies, but uses the xc_cpu_policy_t type to return the data to the caller. Note some helper functions are introduced, those are split from xc_cpu_policy_get_system because they will be used by other functions also. No user of the interface introduced on the patch. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 4 ++ tools/libs/guest/xg_cpuid_x86.c | 90 +++++++++++++++++++++++++++++++++ 2 files changed, 94 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index ffb3024bfeb..fc8e4b28781 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2596,6 +2596,10 @@ typedef struct cpu_policy *xc_cpu_policy_t; xc_cpu_policy_t xc_cpu_policy_init(void); void xc_cpu_policy_destroy(xc_cpu_policy_t policy); +/* Retrieve a system policy, or get/set a domains policy. */ +int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx, + xc_cpu_policy_t policy); + int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, uint32_t *nr_features, uint32_t *featureset); diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index ade5281c178..3710fb63839 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -687,3 +687,93 @@ void xc_cpu_policy_destroy(xc_cpu_policy_t policy) free(policy->msr); free(policy); } + +static int allocate_buffers(xc_interface *xch, + unsigned int *nr_leaves, xen_cpuid_leaf_t **leaves, + unsigned int *nr_msrs, xen_msr_entry_t **msrs) +{ + int rc; + + *leaves = NULL; + *msrs = NULL; + + rc = xc_cpu_policy_get_size(xch, nr_leaves, nr_msrs); + if ( rc ) + { + PERROR("Failed to obtain policy info size"); + return -errno; + } + + *leaves = calloc(*nr_leaves, sizeof(**leaves)); + *msrs = calloc(*nr_msrs, sizeof(**msrs)); + if ( !*leaves || !*msrs ) + { + PERROR("Failed to allocate resources"); + free(*leaves); + free(*msrs); + return -ENOMEM; + } + + return 0; +} + +static int deserialize_policy(xc_interface *xch, xc_cpu_policy_t policy, + unsigned int nr_leaves, + const xen_cpuid_leaf_t *leaves, + unsigned int nr_msrs, const xen_msr_entry_t *msrs) +{ + uint32_t err_leaf = -1, err_subleaf = -1, err_msr = -1; + int rc; + + rc = x86_cpuid_copy_from_buffer(policy->cpuid, leaves, nr_leaves, + &err_leaf, &err_subleaf); + if ( rc ) + { + ERROR("Failed to deserialise CPUID (err leaf %#x, subleaf %#x) (%d = %s)", + err_leaf, err_subleaf, -rc, strerror(-rc)); + return rc; + } + + rc = x86_msr_copy_from_buffer(policy->msr, msrs, nr_msrs, &err_msr); + if ( rc ) + { + ERROR("Failed to deserialise MSR (err MSR %#x) (%d = %s)", + err_msr, -rc, strerror(-rc)); + return rc; + } + + return 0; +} + +int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx, + xc_cpu_policy_t policy) +{ + unsigned int nr_leaves, nr_msrs; + xen_cpuid_leaf_t *leaves = NULL; + xen_msr_entry_t *msrs = NULL; + int rc; + + rc = allocate_buffers(xch, &nr_leaves, &leaves, &nr_msrs, &msrs); + if ( rc ) + { + errno = -rc; + return -1; + } + + rc = xc_get_system_cpu_policy(xch, idx, &nr_leaves, leaves, &nr_msrs, msrs); + if ( rc ) + { + PERROR("Failed to obtain %u policy", idx); + rc = -1; + goto out; + } + + rc = deserialize_policy(xch, policy, nr_leaves, leaves, nr_msrs, msrs); + if ( rc ) + errno = -rc; + + out: + free(leaves); + free(msrs); + return rc; +} -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:00:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:00:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100555.191662 (Exim 4.92) (envelope-from ) id 1lOdpY-0007Zg-3k; Tue, 23 Mar 2021 10:00:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100555.191662; Tue, 23 Mar 2021 10:00:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdpX-0007ZY-Vf; Tue, 23 Mar 2021 10:00:07 +0000 Received: by outflank-mailman (input) for mailman id 100555; Tue, 23 Mar 2021 10:00:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdpW-0006c2-UG for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:00:06 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 08a15162-6565-4df7-851b-84c50e21e68f; Tue, 23 Mar 2021 09:59:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08a15162-6565-4df7-851b-84c50e21e68f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493595; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=ZVYTmperKRV9McJzyxCAMKd6T4Q9wkkfiMKYTjTYp9w=; b=dkVnjy0gR4LrRC0Xasy3u9aB4z8bf17VBfDuLCLFqlNp9uf3r87S4jQv yDqug4n8kwN9fTNE0zyBv2cWzF48yIGD+evIrtFl+NZoj8eJ9Avvs0Sgr aENs14LfY7LQSVOk2gGe6TvLf3V05zu8bFAlJW4r3FYosV1TbO2lndvbP s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: zsTGLXBLhxYbWYKXJA9GMzC2QetVFtT0b5xaIsrP9D/HyQnfLtQ6XqN3z9HZwqm3/0AQCZ6FcN 6w8f40D2C5G4ZKt9O0/BczjbtxGICu5/if5Fz+slxinUg7N028u4IS22pg3p/zTPk+Iv89dg/b DlGpVjWFgf/vliqOIXKk8Y8qha/cujY3pRbYAbuQ13dPjk6/Ye0zuQoyWQ8ZK2LOdgKlB+UXN/ Wqbkj4xuhbjkL0I6KSZsQbnWggwIg/VopWx0S3UKqyuIWDjgvO7q8DjMdku3O7FqZ2xqD39xjn 4Zw= X-SBRS: 5.2 X-MesageID: 41330285 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:L3wV46nGF5Al2XbVWrWsGRE9wuzpDfOpj2dD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLN/AZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 tdWoBEIpnLAVB+5PyW3CCRD8sgzN6b8KqhmOfZyDNXQRt3brx7hj0ZNi+wOCRNNW17LLA+E4 eR4dcCmiGpfm4ZYt/+Kn4OWeXCoNOjruObXTctARk75A6SyQ658bKSKWnk4j4ycRNqhY0j/2 /MjhDj6syY3c2T5xfA2wbonvJrsfT7zN8rPr3vtuE0LXHWhh+sdMBdXdS5zUsIicWOzHpvr9 XWuRcnOK1ImgPsV0W4uwHk1QWl8BtG0Q6a9XaijXHuodP0SVsBYqIr7+IpEWqq12MasN5xy6 5N1W6C3qAndy/opyjh+8POEyhji0vcmwtSrccok3ddXYECAYUhyrA3wUU9KuZkIAvKrKojEO VoEfjG4udXfV6wfxnizxdS6e3pcXIpEhicRE8e/uSTzjhNhXh8i3AV3coFgx47hd4AYqgBw9 6BHrVjlblIQMNTRaVhBN0ZSc/yLmDWWxrDPE+bPFyPLtBJB1v977rMpJkl7uCjf5IFiLEono 7abV9evWkuP2rzFMynxvRwg1DwaVT4eQ6o5tBV5pB/tLG5bqHsKze/RFcnlNbli+kDA/fcR+ 24NPttcr7eBFqrPbwM8xz1WpFUJ3VbetYSoMwHV1WHpd+OBZbtssDdbfbPNJvgGTspQQrEcz k+dQm2AP8FwlGgW3f+jhSUcWjqYFbD8ZV5F7Wf3+V78vlJCqR89iwuzXip7MCCLjNP9oYsel FlHb/hmqSn4U2//WPC6XRVKgNQZ3wlpInIYjdvn0snIkn0ebEMt5G0YmZJxkaKIRd5UofwHB NAoU90vYa6NYaZyyxnK9/PCBPVs1Ij4FaxC7sMkKyK4snoPrkiCIw9ZaB3HQLXUzpvmQhrr2 9HQBQeRlDWEw7vjanNtu1WOMjvM/1HxCu7K89drnzS8W+Go9s0e3cdVzmyFfKMjR0WXDpSjF 1p+6o5iL6N8AzfblcXsaAdChlheW6XCLVJAECgaJ9Pkr7mQg12UFyHnCeXkR01Z2rs+XgDn2 CJF1zmRdj7Rn5m/lxI2Kfj9115Ml+QeE99cVhWm4xwH2augAc57ca7Io6Il0eBYFoLxe8QdA zfaTwJOwV02pSczxiOgguPEn0g27QjNuHQF64YbrnWw3+hQbf4050uLrtxxtJIJdruuugEXa ajYAeTNir/EP5s9AqPpHopURME3kUMoLfN4lnC42e51nJkXqaXD1RiWr0BI9aTq0LjXO2F1Z 1ljdQz+cu8W1+BHuKu+OXyVXpkLBiWnEudC8cPgrpQtbgptLRyE4LAOAG4nE1v7VEbFoPMiE gaQK5H+7jPNY9kQtwKd0tijy8UveXKCHFujxf/DeA/d2w8lnP3P9uG5LzTtLoka3fx0zfYCB 26+y1Z8+ytZVr66ZcqT4YxK39Rck4y9TBL+/6DbZTZDGyRBqt+1Wv/Fn+2a7lGTqeZXZ0Wsx Zh+tmN28uabTDx1gyVnTx1JMt1giuaaPL3JAKHAuhT9dOmfXyKn6ux+ca2yA7NdgHTUTVQua R1MWoKbspCjTE+jIo4lgiKI5aH3X4Noh95+jFollnkx468xnzUdHs2aDHkvg== X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="41330285" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oclrcvNmzj2wuqpOxjANgH8/TsyS9/JnZkgsXm9BC4kVqI4eztHg30VoxUVnpL4EhhCwr5fKNVOQkbjfIYSHi0XdXSohU/Lcd/8ENteNs5aViutq5fL9XxV6mVqREsdmz3VxE3weFaKfNdzDHpXIzPJ3jr+JujfWEClD5paVPXb0CcSvV0DX8dpthKeQa4Scs6dgm/6wPIHNORPO7cEKRvH7H3KocnqO/JpJTjf1uCPjl/7+ZR4Miq0l9X/AosSJQMBiXIV+XwUC3nDwDUNMaSPXqgnRyc49T6h4tJDKEB6AMBKp4RCgdnCZpyxDfz8SQQrb9srkVsAV7Ac2JJkXpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VWrNMyZoDfL7l68Ms6pfloMPkzoINCdhTAU0j0iWLHk=; b=S+vux3G4QMSmkxwzwh4gQ/lXm0X+iK8XXvWEw5busNVYFXlSOBoiM7bWr8YKzofRw85id6NxtjUjrmaXbwwXoxSBLRqJPB02z18zpy4trt211JGudVHU+F8z9u3hkFLjkMgBKa+AlYGWgAtFBW3RTgFUyk6+6+d6cxMYU/0q4Kr9I4tXmFmJfHeZE61M+a84HbbI4Ep5tGCGNTaPQCf4O6GbiHquR0DyKv8X1dRrHwlItJocjwofcSXHpX7zPhkO5Jgk2iIz2UgTCtFkkG9Ewy4+huah26I7Ev0H8zgfvQ191yfKknuX6FARy5kXj5VVETxPNC//4bwOevOVjo9Ypg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VWrNMyZoDfL7l68Ms6pfloMPkzoINCdhTAU0j0iWLHk=; b=F2El6fLpy8jPpQ1e1rIl5BUZyaQgUBzt9mTPA2P+vBxMcBuBUJe4QOmHR/3CyMaD8/6zucl8IQfUUr4h/oY1pybK9tav0T0HX4eQf/C0oufufJL1rEi8AjVFUc/ny3uF+f1DhwgqwJPqKl7ccJU+oosnQrt1giJ30/fRZ+/OyN4= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu , Jan Beulich Subject: [PATCH 02/21] libs/guest: rename xc_get_cpu_policy_size to xc_cpu_policy_get_size Date: Tue, 23 Mar 2021 10:58:30 +0100 Message-ID: <20210323095849.37858-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MRXP264CA0036.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:14::24) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c01cc99-ae16-43d2-eaf1-08d8ede25dff X-MS-TrafficTypeDiagnostic: DM5PR03MB2633: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:626; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SuSm21468e2b8FGwOzyziLa7rDWRJ5tMoY8dmwYT6F7xEizIo2HDcvv/cmsor8WwZlwQIjudiww1bZ671BwWncziaB1gxVpEMXizJFsmZAdqWmsyDMG9dk9PE3gJrOZFBT9UN3u5rz57F0s7G/dFcbE1TQGA5fy4wn0scOh+d3GjJmmwUYzu+VStIW3zv6nXAH4sbuO1kqCIOses0xEcsy+558PMaEmQzjBR3q7DKZoazeq56Sq5C2d5NGZyFPWoRLD61RxoRCzU65nTtyhhxwhtxsF9TniUcc4JE7oSgcvOt+Zxdj1K+17x1ITrGMbokCkpByYz2TXmCNBQzOTPSfgWTsJFWXESspaSbqelHmjOVYXtMVRnxq6js38SnbVCbej949Zm7my5KL8KpTaLzS4XxhK4zay3bhqLKf8OCMCbh8VDIemh9uaeQBz+vYTfawDK8uIKztkLtfUxhLR861+W/CweBIA+CqVOf/x/n3LjxKfdwDBFVqdiuNXI7UKUUYVKXd6Hz63IVHGVkQTFXoJWNPpskE7l1e2Ve5zA8t+aTUfMAORWlp5qtxcDs2TqcUQXYzXJMKbPG7LOWTnMaR7NLdpp2WyKR9N3r0Dh++gPwsyBIIc87XyFh4+33+wDoovXHh0QuqrBBd8FQ9uwFxaPOA35AQoErXbDO3GEzbI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(6486002)(6916009)(36756003)(6496006)(2906002)(8676002)(66476007)(5660300002)(186003)(66556008)(66946007)(8936002)(86362001)(4326008)(54906003)(83380400001)(1076003)(16526019)(316002)(2616005)(38100700001)(956004)(6666004)(478600001)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aW9iTG1melFweUFNSDJFamNPYnltZHF1VXFWTnY3YWVFNEp4OU5oQ1RkTFps?= =?utf-8?B?RDRYQnhmL3NFM2lUNFFxWW1pcldMNDVnNzRiRkRmMW1EaE82UUgvSGZ3S3F4?= =?utf-8?B?dlBmaCtNUjVQbDNsaklLdTZUTFREc0lQUjFMMW5tUWpUNXhPaFRjUENZRjNQ?= =?utf-8?B?Y0JZMWpaTjJsVUNmM0pBYUF2clJjdGFYMkp5TVhLV3k4YWhVWFFQRVRWTzdk?= =?utf-8?B?emxldmFkZU5HanlVcE4wN091aW1PZ2QyTkdveU9aUUZESzYxUTZoWUllMDZV?= =?utf-8?B?bWRCNy9KVnJGNk1McGVOWW5DZldsRmxHdm9FVnZRRFN4UVk3NEpOdkFuUEVQ?= =?utf-8?B?WktFYTNlbUIxR210WTZXWkRqVUp3WHREU2dhaUNLT0NiZ3Q4bWRJS2x4bDdx?= =?utf-8?B?anQvaTRUeEJmQnBwWHV4cUd1ZHUrSFlIbFJLWkhxUk5UaFhzWld1MlcvNG5w?= =?utf-8?B?cnFIS0x2Ty9QZlRQTzNJaXd6RjloTTJVdzk2NC9LdVVBVnR4bVhJYnltV3VX?= =?utf-8?B?N3g0L2FZeitwY0hESG9URjE0ckhuSU02ZGtVT3QxVTFEZzhqUDVjQ0p2R0pL?= =?utf-8?B?T1JUeDVmZDJTemp0eWxza0VzMVAwdHRtNHVMUDYzSlFkQVdMUUkvZjVEWFdm?= =?utf-8?B?M0FUOWhRUldBNUJKZC9NMCtEUVJsNVFFWTVVZzQ2RUlZRWhQU2NtNi9lZTVi?= =?utf-8?B?M0MyWEVsc0FoczBWSEFpOXY0Um9iaGhMeDVXTEdObXZKdzNmdk5lQ3BEWUZP?= =?utf-8?B?RG55d0tYV3dhcmM3UUZkZkROWkpXakt4eGgvRUZ5MDlsUVRKSXZIcGVOOGE1?= =?utf-8?B?N1F5QTNrVmxvN0x5RUVRc0FwWklGdVRCYk1paGtvRWlIbFl4SnkwNXVoS0tM?= =?utf-8?B?azhxeFRrUklmODd6eTgxTyswcVdYQjMwZlM4UFlNQ1NLQURSVWphYWpYRnM1?= =?utf-8?B?amQzMjZ5NHdMQ3VSdjVaNldqd3BBMnRxTlhodEYreVpTNkpBM21NZUhBUmxC?= =?utf-8?B?ZXFFU2lYUnFIM2hxNkdZUXlqOWF4UVpKeVFrSyt1WmpKclFXbWtrVjBuQXdq?= =?utf-8?B?SWV5M0lBaU5xWDVOekpua29rUytpYi9tdXdITmU3b0RLNG1xNWZNMVBGQ3hh?= =?utf-8?B?ZFZlRTJTUGtjdUNWL0UzRnZnbkppZlRhcUNqelhHRXJVZnpIaWJPRGFUdkNG?= =?utf-8?B?c0J3VDIzV0dHdlFRUlQ4NGRtUTJKVTZzZDdJcDVleVkrVlJ2S0ZkelQ1OHhN?= =?utf-8?B?TmJQa2JRdUtSL1hNSmRMMXNIT0RLV2hkaGZUeml1eDliY001L3ZaenJRK20r?= =?utf-8?B?dkJ0NndCUmFXdndWN3hFUWZ4ak9UaUhLOFZxRXlmdmJaNFFkTFNKcDRkQnUz?= =?utf-8?B?alhyYXhjVWNtSk15d3U0cEF1QnVVZmVPUm16WTNHVUR6N05zQ2tTb0RMcXl1?= =?utf-8?B?bGM4NHpmOFNGczdyKzhGaDNkOEhNMHZRUFl5c01Zd09iR2pvQTNLRjd4eGpu?= =?utf-8?B?WndWOEV5YjlMU2JWRU9mdDFTL09WME5iTkk3YnQ5THRHYWx4ZENrcm9FOUZs?= =?utf-8?B?Y3N6VmQ3bXZ0TklwbFdBNnU0YXdRNlRxaisrQW0vSHVLM0ZRb0h2Q2UwUTEr?= =?utf-8?B?Y1Y2NS9LQkg3aWcySXVJWVJpc0xCdG5mSWxmRmdrVGkzbXhDa1VIVXd0UEdt?= =?utf-8?B?TkdpVUI4ZGlkWkZQd2l2dmJZSTZjM1ZtTXB3dXk1NVdQNnpqT3M2NzBBc2lt?= =?utf-8?Q?dPlHcIAZc7DrUT2eV/OTo93B/yncqPkIz/y/K6i?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7c01cc99-ae16-43d2-eaf1-08d8ede25dff X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 09:59:37.0391 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vgl8PCupPskFSKcEjFaWNRmUte4VK18jpetpjDr5rwt+9ky7SDkA8R8WXreH1yiBmOp0+j8aeulzbuPA8G7j6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2633 X-OriginatorOrg: citrix.com Preparatory change to introduce a new set of xc_cpu_policy_* functions that will replace the current CPUID/MSR helpers. No functional change intended. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 2 +- tools/libs/guest/xg_cpuid_x86.c | 6 +++--- tools/libs/guest/xg_sr_common_x86.c | 2 +- tools/misc/xen-cpuid.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 318920166c5..e91ff92b9b1 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2594,7 +2594,7 @@ int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, uint32_t *nr_features, uint32_t *featureset); -int xc_get_cpu_policy_size(xc_interface *xch, uint32_t *nr_leaves, +int xc_cpu_policy_get_size(xc_interface *xch, uint32_t *nr_leaves, uint32_t *nr_msrs); int xc_get_system_cpu_policy(xc_interface *xch, uint32_t index, uint32_t *nr_leaves, xen_cpuid_leaf_t *leaves, diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index aae6931a114..9846f81e1f1 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -109,7 +109,7 @@ const uint32_t *xc_get_static_cpu_featuremask( return masks[mask]; } -int xc_get_cpu_policy_size(xc_interface *xch, uint32_t *nr_leaves, +int xc_cpu_policy_get_size(xc_interface *xch, uint32_t *nr_leaves, uint32_t *nr_msrs) { struct xen_sysctl sysctl = {}; @@ -302,7 +302,7 @@ static int xc_cpuid_xend_policy( goto fail; } - rc = xc_get_cpu_policy_size(xch, &nr_leaves, &nr_msrs); + rc = xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs); if ( rc ) { PERROR("Failed to obtain policy info size"); @@ -447,7 +447,7 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, goto out; } - rc = xc_get_cpu_policy_size(xch, &nr_leaves, &nr_msrs); + rc = xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs); if ( rc ) { PERROR("Failed to obtain policy info size"); diff --git a/tools/libs/guest/xg_sr_common_x86.c b/tools/libs/guest/xg_sr_common_x86.c index 3168c5485fd..4982519e055 100644 --- a/tools/libs/guest/xg_sr_common_x86.c +++ b/tools/libs/guest/xg_sr_common_x86.c @@ -50,7 +50,7 @@ int write_x86_cpu_policy_records(struct xc_sr_context *ctx) uint32_t nr_leaves = 0, nr_msrs = 0; int rc; - if ( xc_get_cpu_policy_size(xch, &nr_leaves, &nr_msrs) < 0 ) + if ( xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs) < 0 ) { PERROR("Unable to get CPU Policy size"); return -1; diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c index 2d04162d8d8..52596c08c90 100644 --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -462,7 +462,7 @@ int main(int argc, char **argv) if ( !xch ) err(1, "xc_interface_open"); - if ( xc_get_cpu_policy_size(xch, &max_leaves, &max_msrs) ) + if ( xc_cpu_policy_get_size(xch, &max_leaves, &max_msrs) ) err(1, "xc_get_cpu_policy_size(...)"); if ( domid == -1 ) printf("Xen reports there are maximum %u leaves and %u MSRs\n", -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:00:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:00:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100558.191674 (Exim 4.92) (envelope-from ) id 1lOdpn-0007nF-D8; Tue, 23 Mar 2021 10:00:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100558.191674; Tue, 23 Mar 2021 10:00:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdpn-0007n7-8w; Tue, 23 Mar 2021 10:00:23 +0000 Received: by outflank-mailman (input) for mailman id 100558; Tue, 23 Mar 2021 10:00:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdpl-0006c2-Ue for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:00:21 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 32db4eeb-74d3-4558-b643-b0ec1e9c8a9f; Tue, 23 Mar 2021 10:00:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32db4eeb-74d3-4558-b643-b0ec1e9c8a9f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493606; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=US6kAIf+2labk2oCST9gZ6uChRGzP0iC69NC7ePJygg=; b=BJErWs9/beJOB+kvaEcC/6x8Dq+z+Dk1KS5f7KilDEOsZtzYkyOw838Y EXfLA3b9efDoUdTJXxN5YoB+7aXrPKjT0+d0iQYEMwlskIVzMHpcXNRGz ukK40NVaOS3WDp+jGsrF1z/YDJgKz46cwNwF2R/Yjgsx67v2u/9r1oVg2 E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: GVSMCNCdokr7gSpcFW22ITltZD8ODexzTt+VH+cZHrxf4xTk98NRvEB5x25qrcf/nKuvJg0+r3 DWi+bbARwa00W0oIY9khdGpDycK7xOyrPEOnS9gTeChH3NwDxSu0QiIothywpu6vz7AHuPCGGF dEuaj5zkNV0K2VBBI5IfKYlDGLLwZzc1rfBzZ2Qg/qdkpAk0XJlgsX8AxGKnjzwjg4Xde4jjjG K/Jf1OFZtdbAy8Otb5xIpMEDlSRuY7sIUtXPSTNFMwms2Hhr8AEfcelDbnYtNkPraSHou5HS5K 3Ig= X-SBRS: 5.2 X-MesageID: 39900265 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:68XtpaCBQjI8bbjlHejTtceALOonbusQ8zAX/mhLY1h8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPtfVr1zrQwxYUKJ7+tUE3duGWuJJx/9oeK+VDdMgXE3Kpm2a 9kGpIVNPTZB1J3lNu/xQG+HcopztXvytHQuc715R5WLD1CQadm8gt/F0K/Gkp5WAFJCfMCZe Khz+BAoCetfmlSU9SjChA+LqP+jvDotLajWx4JABY79BKD5AnC1JfWGwWVty1uNg9n7qwl9Q H+/DDRxqLmiP2jzw+Z6mm71eUxpPLE6v9uQPOBkdIULDKEsHfjWK1EV6eZtD445MGDgWxa9O XkmBsrM8Rt5365RAjcnTLX1wbtyzoo4XP5oGXo5kfLm9DzRz4xFqN65b5xTxrD50Is+PF63a 5btljp1aZ/MBLakCzxo+XPThFh/3DEwkYKrOh7tRJieLpbTIUUgZ0U/UtTHptFNjn98pobHO 5nC9yZzOpKcHuBBkqp81VH8ZiJZDAeDx2GSk8Ntoi+yD5Nhk10yEMe2Yg2gmoAzpQgUJNJjt 60fphApfVrdIs7fKh9DOAOTY+cEWrWWy/BN2qUPBDBGLwYPWnO77r6+q886u3vWJFg9up8pL 3xFHdj8UIicUPnDsODmLdR9ArWfWm7VTPxjs5E4Zx0vaD9WarrPSWPREtGqbrgn9wvRungH9 qjMpNfBPHuaUH0H5xS4gH4U55ObXkSOfdl+uoTaharmIbmO4fqvuvUfLL4P7z2CwspXWv5Hz 8GVDj3L8NQ81CzVhbD8VvsckKoXna60YN7EaDc8eRW4pMKLJdwvg8cjkn84NqKJz1Euqk/Z1 B/P7vjj6O+qQCNjCj1xlQsHiAYIlde4b3mXX8PjxQNKVnIfbEKvMjaZXpfx2KdJhh0T9rfFQ lWo1gfw9P0E7WggQQZT/63OGOTiHUe4E+QR5AHg6uZ+IPOYZUjFKsrX6R3CCTGHxF4ghxRtW 9GcQMIL3WvUw/GuOGAttg0DPuaX8RgiA2rSPQk0k73hAG5n4UTYVc1GxSpStWahA4yQSE8vC wKz4YvxICvt3KDC0saxN45PlpNb2r/OsMeMC21IL97tPTOV2hLPCG3rA3fsT8cPlHHzXk2uw XaXGqpUMCOOHRy/kx9+oLR0H4cTBTYQ2tALk1f9aVGUUrtnFFduNX7Ppab23eNa1cE3+EWOC zEZzxXOQ9129Wrzneu6Uq/PHE9xowZO+TXALE4Goujp0+FOcmGk7oLEORT+4sgPNfysvUTWe baYAONKijkYtlZkjC9tzIgOCNurmMjnu6t0Br57HKg1HpXO4ukHH12A7UaKcqb9W7qWrKB14 h4l8s8ua+1Pn/qYtCLjaHRYDgrEGKknUemC+Upo4tTp6Q8qf96GITaSyLB0DVfxwolRf2E5n 82UeB++vTMK4Vvd8sdd2ZQ+Ucojs2GKA8uvhbtCuEzcFkxhxbgTpu0yquNraBqDlyKpQP2N1 Xa6SFb8vvfVyaI1LIRCcsLUBBrQVl57G4n8PKJdoXWBgnvavpK+0CiNGShNLBaU6qIFNwr32 VHysDNm/XScSX22Ard52QmZq1P9nuqWsO0DkaHH/VS/9mzJFSLhe+r7aeI/UbKYCr+b15dg4 tPMVEUZIBEjDIpiYUsyCi8SqDtuCse4i5jyCAikkSow5Ss5WfQAFpPPgLYiIhHRDU7CAn3se 3VteyDkGnn6DdL2ZPfBF5dc9FHFd8XVJX2JU5VWLgtla/t+bEujCRFaAovCGB5iCmV5ZIY4Y uE X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="39900265" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gXJ1iYuw4/bok+tKQ7fDpj75KpBnWo4cbSXSA/uzhFay4Clfuk6Yy+Xaga1sfOfENCEcLJm1fCuSMwXNf9RzMWr+6zlgesRerDbRR7AlWJ0dosMdKX6xJwLfvvxSGDbIx5FbsobMiOfkFSOpVE5+Ggd/Y+IwOK2Pf8rQhwtKW25nP7YDfwu4f9L89rYd7u8bChBwjwRryxZTlZlvKboUV+G/Vmwix/h5zlugyOHLvWJkEFhyyATFFD3lO53FqahAeCBsEhIeygeb0hVckq/uxH1HfYSoSOYI5Zn3PCNlLGrX2n7E5F5rp8gNuYA2EYiy9p5jR2iP4DCS7KvdfKe0nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x96POU3Rped/M3iZclAcVyiA8U+JKnNokSoJ4Bo8H4w=; b=QxxxS9mldxbpf9U1yhZOnwLE6bEk3bWXn9cIUhc8mvrYLFrT+ZrOJzK9HX8twmgpLPPa2/moPgsPrnQBAuzmWHFJ2iqSkwqrvAf/X2Wg2y9XC++4DAl2bMDK/2vwpXNc9UekJMPDsFasX2mvNqilVRWxf48Lgoed2CdAlgM3KkrHChhQ9QVMCMSxNnw9f6NQQD/cL8jl4j347Im5IeE0oHZtGL8s/YaF41sAJ9qOf3cLSHqsZ2DQ5+QVgNefTwbANlswGdOx4w4Fweny/pYgUwedZ8USyEQe3XNmusygdOM5Cj0eUYKK60r04cS9njej5hbM2Amy7P1jkdUlU0vq2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x96POU3Rped/M3iZclAcVyiA8U+JKnNokSoJ4Bo8H4w=; b=Gjt71eSLm2Rh1h7PKyIkj3J3bWVSc+qJcvBFSa4wkS7cPVWzSkDjt5eWNAbV4ImxEsAwG7kFoOTFqCYBIf2B9qpSQBqgVmZiw4iimiYn6EWfv4Mqow9+gklK8U/jRNIcRhfT2WnGOPz+6gULCswHaGX1RSacjj+jN8oXMsg3ZZo= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 06/21] libs/guest: introduce helper to serialize a cpu policy Date: Tue, 23 Mar 2021 10:58:34 +0100 Message-ID: <20210323095849.37858-7-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0151.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d183e04-e412-4789-dd82-08d8ede26cd2 X-MS-TrafficTypeDiagnostic: DM5PR03MB2633: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9ElZibxGi0gY3rzpH2bdPuQKaMOd+JXXqyFRdbKV7brYJ/SP4ra9BnmIvvUHdrF61HfMvXJFFuieeqF4rOd+QAvzZkjPczBQrz1iwYdhTAW7RYsS08MjsYx0sHh9PfdEDJwF0R+0FRBruWhtKZTeLG38BAvApYKpVGwSWSbFU93VRYJYhyQocu5uFLI1/N91VU6CnRWJozdAaVCEazP+7PBZYuRKNFI5G0gCzsaH74ykwuRwd+QKrbJ5e/gU6dG7jT7cja7Et6vnpdmGp4bh1/pSpL0FNUeJoMqqs16P7/NsD5nEO63xjG7L31VMj54dEHucaxacq9UGQ5suhpm+ORCVqrU8JnczpGPYon+kQBaK2Y0VIWPDFaOQd6/k45sSc/yVl0hEuCIvJtwasKE9n0p2qEzTp4E5iA2O9qhAkCp9YXchFdmzEXN5dE7K1HPxG+SZSJjxL+lEVOzyPSduzxZWKBUEwAxvDNTSQUmuFgXPPjsGsBuvKasU/V2nsDyI0hx3CIQonHuoFiK0Se+ZdEB8cLXgMlRmTifGv4gE9n7ncwHC4ubCCH6Duvz3yAt2G4bvyKefM8KBl8zfKo2t0fWCG3HaOwYBe0UVIebdnGAUOKkzhv+yuNir8YAKeFNoS2yUQCogIZE29bFHVmZldR7da2TjuoCI/qWUwxa1PHQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(6486002)(6916009)(36756003)(6496006)(2906002)(8676002)(66476007)(5660300002)(186003)(66556008)(66946007)(8936002)(86362001)(4326008)(54906003)(83380400001)(1076003)(16526019)(316002)(2616005)(38100700001)(956004)(6666004)(478600001)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VmdKYTdhdWp0cU53Z0t4ejZvb21nTkNBWG5KUms3bkVXdEw1Z1dGNXRTemM3?= =?utf-8?B?ZDM3WUk3eVN4QjJ2bUJwM2xTZGZMZE5zMmlhVWRwYUgwT2FEcWNHYkJzdTZn?= =?utf-8?B?blozV20xRWV4eUVHcWx0UDB0UlQvZGQ3QWxLMDR1SEJMbXhLKzBKSWY3WElI?= =?utf-8?B?Qy91VGs5b3dtM1FTcWN5NUFQSm54Q0kzME53RG5sQ3FxUmFzSzhSbC8xeXNT?= =?utf-8?B?eVA1NVFDbzRwckN3N0NKeE9nTXdFSjdKY2dDNVpZUEt4QVg0UnQ5RVZ4WkZX?= =?utf-8?B?MXAzeEI0cHlpZWdkUEFxWG44NUcwQVhzZklrSFd2am00UXRRLzFaMERubS9r?= =?utf-8?B?eUh3akZXZU9LeXNaSTZLNjhCMFpBTWZBczJoVGNDNGI1YzJCVWNGakJyQkVi?= =?utf-8?B?Z25udGFLM21IS3ZmT2VXRjIxUU05dW5ZVjN3Um1XZmQrbDd4TGhwV05ON1lG?= =?utf-8?B?RE9DWnh3Q1BnMlFOS1g0RXg3T2pYdXVQTC9sanhDQ0pGRWQ3MkZuTGJQWGV0?= =?utf-8?B?NzZVb3YyaS9LdjRNbnJpdDgreHJxWStnQW9NU1ZtbFBXNGFDN21IRk5wMXhz?= =?utf-8?B?dk9rQ2xiZXNaU3lRWVl2QlQxeGp5cjVmdWt3UWlKd3hKRkRQdThiVU16TE5Z?= =?utf-8?B?OGFvb1Y0anZwQnh4anlSUkZGWjNYTmVJQVUvV2Q5c2dUMWpNSmxkWmwxeCta?= =?utf-8?B?SXN2RUJMV0wra0hjemNxNWt4KzJDa0hOTVkrbUlwTHBEL3V3UjBNZG1VcEZF?= =?utf-8?B?eE1qRkZhRjVJaDMzaW9JTEtvL1JYM2RYS2ppeXd1WlBRMmMxNEYray94QSs3?= =?utf-8?B?WWJCaDZtREQrS2dtVko5Mm9OcEJ2ZWNYZWFtL0t3RDB6YjIya3dZT0NteEFI?= =?utf-8?B?b2lMV3FDUE9MTXpUM3Z3czNBem1odGhzVWlBZWNRelFxZHNPYlBSdjJ3MWIx?= =?utf-8?B?SThBWThrSHg1aXpxS0Q5L2pRY0FyUU5qYkY1ZForS3hobjFmaXMvMkUrV0xy?= =?utf-8?B?Yi9GN1dVeTFOWDZtdWlHWXZ4VS9DNUVUamJpVTl3OUFmRSt5YWYyZFI5OVpN?= =?utf-8?B?WjlUWUdla1ZYamg3NXNNNzJHVjFaUXprRThIZUNMV2lwSkxVb21vL2p6bDBV?= =?utf-8?B?RFE5d3l6cWsxV3EzdmtwKytGZ3MrNW9aUFlJSkZUcmg0RXdBNGlyZ0NBV2ha?= =?utf-8?B?WlRrV3hFcEZOOGJWeGxoNXJhcjhnRjlYL04wSDNBaUIwcjVmc2FETTgxYnR5?= =?utf-8?B?aTJPY0NoNW5NWXR6TjFPNGRGaTQ3QzhEWFlROGI4UXR1ZzFkRm43Q0N5eXA3?= =?utf-8?B?WFZlaGVXYlc5VXhBOVFXbFI5RHNrOXlHQWJpNEd6VTJvUk4zNStOaXBMNVQv?= =?utf-8?B?Wmh2RjFLMnYwNWdNRDRRdEV5RDY3b3ZTd0dWMG83WWhYL1RYSmFGQzl5YXlZ?= =?utf-8?B?Ukc4Q0RDWUsxUFR6dFhEYU9ZNmc4dkRabUhpVWZ4V0N4WjJ2QllPdEhRMkli?= =?utf-8?B?ZGFLelE0QkJuQzZURDEwZTVzWTRBS3BibSt5UzRVSE5PcWxWYmpaYjNjT09y?= =?utf-8?B?UUVhRkJoWEtCQURsWGpJaHlTSGF2NDRUenN2VWN5OCt4Q3BWODlZTVVpV2dZ?= =?utf-8?B?UWxKYk5mSUZpQ2F4V21iNTRnWCtkT2hObWMzSERaRDQ0QWkrdjFjV3dobE5M?= =?utf-8?B?ZU1HRTVZNzVXNEEyN1pIamNPemxJUGlUUm56ZXBXR082SXNkdlNBWjVaSVE3?= =?utf-8?Q?FrdsEH8/npoNr7AEPK7blcZ36hPSI/btMhD/h6t?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5d183e04-e412-4789-dd82-08d8ede26cd2 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:00:01.9076 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lN9TRHtbaV08ZQ+u5C0zWpFawoQxB9E4CeaGr5Xfe66nK8L5KK7/2FySigun1/LIdJ8AU7aq/qvEhP2d87nL9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2633 X-OriginatorOrg: citrix.com Such helper allow converting a cpu policy into an array of xen_cpuid_leaf_t and xen_msr_entry_t elements, which matches the current interface of the CPUID/MSR functions. This is required in order for the user to be able to parse the CPUID/MSR data. No user of the interface introduced in this patch. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 5 +++++ tools/libs/guest/xg_cpuid_x86.c | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 8b8b30a2764..983bb027a04 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2602,6 +2602,11 @@ int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx, int xc_cpu_policy_get_domain(xc_interface *xch, uint32_t domid, xc_cpu_policy_t policy); +/* Manipulate a policy via architectural representations. */ +int xc_cpu_policy_serialise(xc_interface *xch, const xc_cpu_policy_t policy, + xen_cpuid_leaf_t *leaves, uint32_t *nr_leaves, + xen_msr_entry_t *msrs, uint32_t *nr_msrs); + int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, uint32_t *nr_features, uint32_t *featureset); diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 75ac70996ac..812ef14fbcd 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -811,3 +811,35 @@ int xc_cpu_policy_get_domain(xc_interface *xch, uint32_t domid, free(msrs); return rc; } + +int xc_cpu_policy_serialise(xc_interface *xch, const xc_cpu_policy_t p, + xen_cpuid_leaf_t *leaves, uint32_t *nr_leaves, + xen_msr_entry_t *msrs, uint32_t *nr_msrs) +{ + int rc; + + if ( leaves ) + { + rc = x86_cpuid_copy_to_buffer(p->cpuid, leaves, nr_leaves); + if ( rc ) + { + ERROR("Failed to serialize CPUID policy"); + errno = -rc; + return -1; + } + } + + if ( msrs ) + { + rc = x86_msr_copy_to_buffer(p->msr, msrs, nr_msrs); + if ( rc ) + { + ERROR("Failed to serialize MSR policy"); + errno = -rc; + return -1; + } + } + + errno = 0; + return 0; +} -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:00:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:00:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100561.191686 (Exim 4.92) (envelope-from ) id 1lOdpt-0007sU-QH; Tue, 23 Mar 2021 10:00:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100561.191686; Tue, 23 Mar 2021 10:00:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdpt-0007sM-NG; Tue, 23 Mar 2021 10:00:29 +0000 Received: by outflank-mailman (input) for mailman id 100561; Tue, 23 Mar 2021 10:00:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdps-0007re-Gl for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:00:28 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6745d016-9091-4c94-b3d1-66cb4e09a1ff; Tue, 23 Mar 2021 10:00:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6745d016-9091-4c94-b3d1-66cb4e09a1ff DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493627; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=wE73k71VkuOoBtJxmEIA4ELSt2NnSaaWq1/7synJqCI=; b=IHHDMoOogwJzBD91G1NySrTYVphVRFFxb0dPpghypB8tZe/yoN0zfyCk TijySJjSWwwsGQCB57C1gwAW29UMsP+nsoSrK6nLr1R5KEHFHHNCgsW8j AFYwyBTX6fFDFzKlllIoalXkSPHB/wZcwliI647em4GrOkQzHXA+JZv9x k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 5zM7xB52ycpn/+BdvG7uKilxZJv/2rULgdVN5jfhFnfZV4pGZMOOzVWOuWvkqu/guyt1+SDkfG 9nIeVRp26t8kPTHHtQosCcsKzSOl5IRjMRivDZKe3NZHTvlrogLu6AQboAZ67EkxVtp988VlEy jaEMgZOQr95dR2wfjy2U9dUUjEmyurVZYEDjIrQ6dJev6SrGii9A/iKWjJgrkK+cxcvnjQbXCK LLoyZxHM3HfsPtZIqj6s6mlwxbWkTY1hf09pzXPB/G6XTfo4Emw+hBr8EXrWvsYDJAPNmeIQz3 En0= X-SBRS: 5.2 X-MesageID: 39882229 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:6zQUxqiQHw/8sDbCbn5JdLCaIXBQXwh13DAbvn1ZSRFFG/Gwv9 yynfgdyB//gCsQXnZlotybJKycWxrnmKJdy4N5B9efdSPhv3alK5wn0Jv6z1TbaknD38N+9Y MlSahxD9XsEUN35PyR3CCUG8stqePpzImGnuHbpk0CcShPS4VNqzh0ERyaFEoefngiObMcGI CH7sRK4xqMEE5nDfiTPXUOU+jdq9CjrvuPDSIuPBI79BKIyQqh9b+SKXOl9y0DWDBCy6pKyx mmryXF4MyY0s2T+1vn+EL4q79Xn9bgzdUrPr3wtuElbg/CpyztSIBoW7iptC04rue1+D8R4a XxiiZlBetfwTf8eXy0vAvM1mDboUkTwk6n83C0qz/CptH0Xz0zAcYpv/MmTjLpr3AOkfs59Y Aj5RP/i7NnSSnusQ642v3zEzZtrUawqWpKq59ps1VvFbEwRZUUkZYS5ypuYfE9NRO/0q8LOs 90AvrR4f5HGGnqFUzxjy1UzNugUm9bJGb+fmEy/sic0z1hlHtk1UcvxMsGgnca9J4mIqM0n9 j5Dg== X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="39882229" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PcQrS0vFC0W4ZAmvHdzZzXIOVteHOXlVoZOl+SvqxKPIZIzkDV+/sZWAFvMCF27mCFUDiuyz2qU8iZvoZ7ER3lcMaAq+McEW98AzxjNeIjyDTcPmhVXD+Ox4oWhNEQcCvt260yMPAbG9UJcDmS03E19v3bMpE1JeNFCjxsv2Yv2aUFdhmU+RV1cth99MQ+NxZFW2ICEBQQc+cMJuvZAXtyzJGzLJyP7UDIJwl3milkk+qrAfV4DS/uie1uQPkelq2ARbBa8d9xRjbATR1X/NqB71oDwJAvFhSfcG2WuwlbKMtMZNbljVhajtc+1AkuBPgK6/O2ZuJM1ijVeZTVTwzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9t+NT91cGmv6RL2vL9wP6BGEOhhn8NymEq9ul10dNCI=; b=P10VeUCDlGPFnepMfre1po7EieR04WFVt4gLeh8X6aHnVwt6D8VFOZrGG3y5hZn+54HJfT7gSUMlb9pSyLbkjett+eM3Je+ZeIW89H/issEbXkTcEbJ21myhXewkRr74CEHYhEOcXX1gQkksagevcQFfY9czzqvbV1Ir2EdRVApVXs8MOCvy3qqAf6R0eyGWpAgohb9PnNBUt1tMby6TO4qQWOR5Zl0IG+kp9nuWOnbTG5OZ2GG15zucdrngYfSnNQOENImoTpDkQZrKR3bHcEk8b4D8FDKnUYrHsTFUuwyDGunpeS0rAfWtdwIbKm1OvtI3b6SrTeQ3Bh/C05BohQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9t+NT91cGmv6RL2vL9wP6BGEOhhn8NymEq9ul10dNCI=; b=xA3sfsLfXdVNp+SE896a72G8BTfH8mZ50Ce+0cwn2pIr1BBnnkMOxQiCfABvy/rnk3u8mAxIMlfZ6qzozqVKsvBnLOEad++88kJccjy1OOa94fimSfHgGnQSAyaQ+1gttOm6vvia2AtIl9ZhZCAdmsyOPOYv5n3yeO7va654+Yo= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 08/21] libs/guest: introduce a helper to apply a cpu policy to a domain Date: Tue, 23 Mar 2021 10:58:36 +0100 Message-ID: <20210323095849.37858-9-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR1P264CA0011.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2e::16) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8eb982bf-8782-49a5-982a-08d8ede27a20 X-MS-TrafficTypeDiagnostic: DM6PR03MB4969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2eII0boAvoI9hURjapK8ngY7ozlzy15cv9UIhroSmvCnJziaEZs3YIByCeDX/9GbUpAf2X1665EDO1+fUUMLqQ6o77LlvrntXFPKjNTQmYWQCTxhm6mRvZ0IMmrZbqE7AjM7Nx7pLoZZ0QUtu1XFBLOaLEkrJtaZpDc8YYs0hlwB9kwIsbymvGAUPItmPhnXl95zySCXwLfw7f91tLqrUTm0gGZWUtZMAjwe5vMU3DElYznUuX7CFhNjRr1C25KZ1fOdtOYJz+ZiceEHGRoOQNqFV7AfAjsv9jxlnlos1jnzZFO8z12vVjhDJK1f3zSpuo+KxKYCekafQYsCGojzDX4UKPTHThbvFfk3617gqFsSl3O9WtEVi+gWIP9tMdjZz9rVCW2NtCfmJvy5QpRM57RIvL2lcU7ve14OoVXj4+KsxbYeupSdcz8grW/9LJKxD/okqY5YuVacpgr48rN/hTcyunj+2r5O5ayp9wbfavH87LXErfnke7acqW7oiEEZuf5tk3V/9qZtZauK0svYEbLXoAIDUhUiDgdN65qRbH7jpBi3rOGUBTWwbA9il/YIhG6Yi+vOQnDbCZFdg0+iolHa2YfKuLcoWsDtmpYMptLUJ1BPb6IGi7NVg+YCWCM3DIxmrnpb76dUOY32NkebNhXC0y3qqA//H7qN/g9CElw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(54906003)(36756003)(2616005)(316002)(26005)(6486002)(956004)(16526019)(186003)(2906002)(86362001)(66556008)(6916009)(478600001)(5660300002)(8936002)(6496006)(38100700001)(6666004)(66476007)(8676002)(66946007)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Qk5PeU9FWG91UGlZN1MxQkQyVkdtOG50Rk4zY3VLVm1kSkZwT1ZKVFIzR010?= =?utf-8?B?N2psY3VLN1FnemNCM3NuNEFya2lWY2tYOW50LzV3QmFTUXRTMkhhT1Z2OWZp?= =?utf-8?B?d0ZFMVQxRFM0YTA1WjFmTmFIcERTaTBlS2p3c3M4ejdZUHErVkRxWHkxOEc4?= =?utf-8?B?a0Jobloxd3JGTE04THVmM0xJRkNxaFpleDlLQ1FyUkZ4OTJYUTBWREtaWWda?= =?utf-8?B?VzVtbEJuZDFNekF3UVJPT3czR0p1UmJFcFlwS2FqMHZ4YURjU1VRcWVFVE0w?= =?utf-8?B?eXZIL3E2QmpRY081aFd6alVNUTZwY1ZiRW5oNXJ2Unl2NDBRbW1Dd25VajJQ?= =?utf-8?B?K1lOZHRnWGV3VVZwTEVIVUlNak1hc29wWkhCVGhKR1A1eGJHc3lkVzFUY1Ax?= =?utf-8?B?dmFmTXVGVi9lOTc0S1JTVFRKYTRCL3A0a2RvSndNdmE4NjcyNnpLY283RjZO?= =?utf-8?B?aHNxYUxIeGd2SEZiVjNDanBJQTU1OVZPZXFhREV0RXlPOWNRRlBYUkQrVkI5?= =?utf-8?B?alJrKzA4MmRDNXgvYjJuYnNEQTlrZXdadWYyWU52Zk5Bb3hZQ0ZKY2d2RHNL?= =?utf-8?B?M2dBdWg4L29EVW4rLyttekVJM0FvcDU0MmFYQTZLZUFIYzh4ZXcvYUZkVE5C?= =?utf-8?B?d0oxYkdqbFVJOStaeWNNMnBMVUJ2TnVTZzdEY3FQMXdUMmpTazgyR3RKMlhq?= =?utf-8?B?QmkvNUJOeFBTaUwvUDRlRWNxQ2lIMzBBbExHVE1HQ3Z0MnAzemdwQm9sNXNH?= =?utf-8?B?bVl6ZDZaTU5GeFZkZXEza3J0MC9XQjVpM2hqRzV2QU04TjcrcExiUjQ2aWxT?= =?utf-8?B?STZCbFN4WDRFZjZGb2s2S0tkckNNNXBIM0Z6dENGOWVVOFljbFMwN2d0clNI?= =?utf-8?B?TnQxZ2R6QzdMcGhzMTlhRzBZSXdSdXora0kyWVFZQXU3MU1XR002ZDdLZytQ?= =?utf-8?B?OVFScXRJMDBhRG5xM05ybFgwTzlxN1k4Vkg2NVd6a1o5WWRIOTNDTTJxRjF2?= =?utf-8?B?TkJNNjY4Q0FkcnpRYllwNVhNSnRGeU5MUTJONnphYlBLT1BxcHVhc1RCdUQ3?= =?utf-8?B?aTAzWlVpNmgwUnRhU2pDVmdMS0piU1JTYlpVM1Z4R21CRGc5TS9ESU94NWZI?= =?utf-8?B?UWZiZXhVcjhBYnBkN055ZGhySTFTakZjdmlma0hqVm9ONlo4bkI0SDNMWXVz?= =?utf-8?B?bm9rMWUrSnlDdmFmLzVmeHN6bGZMRXppQ00vY1NPQUY5bi9idXNWalZlWk1a?= =?utf-8?B?SUZZK05Jb1E3RzR4TnRvWXZFR0U1WDNRNFIzcm5odlMrMlFCREd5cXI5ZHpE?= =?utf-8?B?RWlMN29GbDJvY3VrdEJsZkVxUGJhVkxzNndMS2NpRVVXOVBESWFJOGtBK2VL?= =?utf-8?B?YW1lQk5iOE9pcUpZdjI3NTBKdHlKQm9OZWtDeGlrOENDajN2OTZJWlFmQmIy?= =?utf-8?B?eCtTb2NRQzM4RHpXVi9hZkI4aUh5ZTdnNU9oT09KM3p6dWZnandLUXl4YURH?= =?utf-8?B?M010SFZybWxDSGZUcGc0QjF6SUhJZHRCY09PSGwzVGNOVFpZUkgrWklJNm9B?= =?utf-8?B?c3JmZUtSOVY0NkYvTnRudS9xay9sWjlkT2RPZm9NcUhMQXo5aXdFcXB5N0tN?= =?utf-8?B?djlrQUtmUFlITGZiYmg5Nm95aGNZSXFkdDIwdSsxN0UzQmc0VVd2cVIyZEd3?= =?utf-8?B?L2diM2JDMTMzZHd5dUNYU1g1aEFYM1RkUmFJVE5hNzlQSjRzZ09IZ0wvWTJr?= =?utf-8?Q?jfdctgLdQJalQn5VB+EhVzH6NmSyJGTsHDFtExE?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8eb982bf-8782-49a5-982a-08d8ede27a20 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:00:24.2284 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KG+mWYvp6GaE8EkarFpvGXNzq6lSNJG1cVhVZ47yzQ+ut10B43MqcIE7xcZvkiZt8cs5/3M0i/lmnUdDg9LlNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 X-OriginatorOrg: citrix.com Such helper is very similar to the existing xc_set_domain_cpu_policy interface, but takes an opaque xc_cpu_policy_t instead of arrays of CPUID leaves and MSRs. No callers of the interface introduced in this patch. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 2 ++ tools/libs/guest/xg_cpuid_x86.c | 40 +++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 161dafd234b..d82c99b2f0d 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2601,6 +2601,8 @@ int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx, xc_cpu_policy_t policy); int xc_cpu_policy_get_domain(xc_interface *xch, uint32_t domid, xc_cpu_policy_t policy); +int xc_cpu_policy_set_domain(xc_interface *xch, uint32_t domid, + const xc_cpu_policy_t policy); /* Manipulate a policy via architectural representations. */ int xc_cpu_policy_serialise(xc_interface *xch, const xc_cpu_policy_t policy, diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index a8133d5cd3f..48351f1c4c6 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -812,6 +812,46 @@ int xc_cpu_policy_get_domain(xc_interface *xch, uint32_t domid, return rc; } +int xc_cpu_policy_set_domain(xc_interface *xch, uint32_t domid, + const xc_cpu_policy_t policy) +{ + uint32_t err_leaf = -1, err_subleaf = -1, err_msr = -1; + unsigned int nr_leaves, nr_msrs; + xen_cpuid_leaf_t *leaves = NULL; + xen_msr_entry_t *msrs = NULL; + int rc; + + rc = allocate_buffers(xch, &nr_leaves, &leaves, &nr_msrs, &msrs); + if ( rc ) + { + errno = -rc; + return -1; + } + + rc = xc_cpu_policy_serialise(xch, policy, leaves, &nr_leaves, + msrs, &nr_msrs); + if ( rc ) + goto out; + + rc = xc_set_domain_cpu_policy(xch, domid, nr_leaves, leaves, nr_msrs, msrs, + &err_leaf, &err_subleaf, &err_msr); + if ( rc ) + { + ERROR("Failed to set domain %u policy (%d = %s)", domid, -rc, + strerror(-rc)); + if ( err_leaf != -1 ) + ERROR("CPUID leaf %u subleaf %u", err_leaf, err_subleaf); + if ( err_msr != -1 ) + ERROR("MSR index %#x\n", err_msr); + goto out; + } + + out: + free(leaves); + free(msrs); + return rc; +} + int xc_cpu_policy_serialise(xc_interface *xch, const xc_cpu_policy_t p, xen_cpuid_leaf_t *leaves, uint32_t *nr_leaves, xen_msr_entry_t *msrs, uint32_t *nr_msrs) -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:00:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:00:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100563.191698 (Exim 4.92) (envelope-from ) id 1lOdq0-0007xV-3u; Tue, 23 Mar 2021 10:00:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100563.191698; Tue, 23 Mar 2021 10:00:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdq0-0007xL-0P; Tue, 23 Mar 2021 10:00:36 +0000 Received: by outflank-mailman (input) for mailman id 100563; Tue, 23 Mar 2021 10:00:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdpy-0007wL-A9 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:00:34 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2bdd0198-a958-4140-a55c-e50105debb1b; Tue, 23 Mar 2021 10:00:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2bdd0198-a958-4140-a55c-e50105debb1b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493633; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=vpl6upBzDqDR+RHogUqp/zpQiubhyzHN4/b5D/chUUc=; b=Fcss3hUDcfiBAnLv4UZdbsd650ayINOhhvCJ1QMQwxzM0awVkkhzdH2D gyORReG+24ajaGxJ71tqWU3Re8j1eO2bk8fwDLrXNhFOxynG7bBb6Sb4K EPEehMbwPBW40c0KzG1/WgVfxQ6t1nvKX7ZZHlcox4LvcVQyLE/6xX/pR Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: IDoYHbPfk+3NUUXbcC+DDb5wuu2Qc3Zqf3OApX89jAq2oXaNjYmUe4eUXjw1ikCJ1FIpGUeaLG bCuh/w94tkTesinyQxCL6DUNuA/ul10ZL3x7Ew4ve/EWKUzz1yoWM67dmTj9+bHhpAYqxgR9UU OraKGcy173SVJckCZGdurYsy4rpz6K/jvcb5hRMbO6vUhPonlOI/ewxhO/AbsosSXpSbi8HYuD Fg+56QqJuWh9PrWCoG3sQSOWHFGuxYoov9mnIOUph0gTwBYHtmZbUEszfp5tj2XuTo3d2i2HGb kGg= X-SBRS: 5.2 X-MesageID: 40261192 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:SWP1k6GqYzC/EiTxpLqFbZTXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7Lk/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeNJwTXzcQY76 tpdsFFZeHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLD1CQYsI1XYcNi+wFEpqSA5aQacjHJ 2H6cZd4xamc3IbbsO0b0N1I9TrjdvNiZ7gfFo6FwcqgTP+8A+AxZzbN1yj3hkYWy5S2rtKyw b4uiHw+6nLiYDc9jbyzGnWhq4m+ufJ6twGP8CUj9hQFzOEsHfSWK1Ee5mv+A84u/uu7lFCqq i9nz4FM95o433cOkGZyCGdojXI6zol53/8xVLwuxKKyqaYNVFKefZpvo5XfgDU7EAtprhHod h29lmUqoZNClf4lDn9juK4Ji1CrFa+onYpjIco/htieLYZAYUhyLA3zQd+FZcNGz/C84Y3EO ViJ9G03ocpTXqqK1/epWVh29qqQzAaGQqHWFELvoiv3yFRh20R9TpV+OUv2lM7sL4tQZhN4O rJdoxuibF1V8cTKYZwHv0IT8ebAnHEKCi8f166EBDCLuUqKnjNo5n47PEe/+exYqEFy5M0hd DoTE5YnXRaQTOvNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dQWeVVEVlde6qfl3OLybZ9 +DfLZtR9PzJ2rnHohEmyfkXYNJFHUYWMoJ/vkhXVajpd/KN53KuuTXfO27HsuuLR8UHkfERl cTVjn6I8tNqmqxXGXjvRTXU3TxPmzzlKgAVZTyzqw28swgJ4dMug8ahRCS/ceQMwBPtaQwYQ 9bKLPjmaWrmHmu8Q/zniFUEysYKnwQzKTrUntMqwNPGVjza6w/t9KWfn0X+3ebOBllTYfzHB REr1p6vYK7RqbgixwKOpaCCCa3nnETrHWFQ9M3gauY//rofZs+E9IBQ6x+FQLCEjRvggZ0oG J/aAsJL3WvVQ/GuOGAttg5Fevff95zjEOAOshPs0/Ssk2auIUSXHcBZiWvVsSWmA4qYDJRij RKgugiqYvFvQzqBXo0gew+PlEJTGiMGrpJAD6IY5hulqnxdBt9SnqLgjKmmwg+E1CahHk6ty jEF2m5aPvLCl1StjRj3qHm/EhdW0+dc0hzA0oK+rFVJCDjgDJewOWLbq283y+tcVME2PgaKy yASyAVOBlSy9e+0wO1lD6OGW49/IgnOvXQAd0YAvfu80LoDLfNubANHvdS8pogCcvntfUTV/ mDPyCSNzH1BooSqnqoj0dgHBMxjnYqkfnlgkK4qEe52WMyGvrULhBNQaoBL9SV8mjjQLKp3f xC/KYIlNr1Fl+0TNiMjZzzRXpkDDj4pGatVeEmqZxOp8sJxfNONqiedQGN7W1N2RU1Edz9m0 wfSplq+bypAP4bQ+UiPwZiumcznNuBLEEXohX7L+83c1YqlWLaNbqyks31gItqJkWAoQfqUG PvixF1zrPgXyGZ06QdBL91CWNKaFIk4HAKxpLJS6TgTCGrffpE5ly0LzuUd6JcUrGMHfE1og xh69+F28+ReCyQ4nGcgRJLZoZP+X2gW8W8HUalHvNJ6cWzPRC0uZSRifTDxQvfeH+ccEQXhY pMaEwWYIBis1AZ/fIK+xn3bLf2rEIjm0ZZ+hd9mDfWq9Gb3Fs= X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="40261192" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7zdB4NqA8L41RGdLAD4B+PNrGJADxzZh/zsFBJXZKr8E44oTQhdlHvKmnLQr9adPid3Zw/IxlzJZ82zk/Oo4XYj4dE9oqpeZjAFMAhySGEukXRgtA7g8VitHGZc+usKMOi8ydju4Tnh2x8nbiEBjINMCZbIMgH80bhzHbLl9gt38SbLFmayGnrYSgKcX8NgkWOGsElyEkiOxZeGsse1rx3CVQPLm/Om29JvfFhVBPk/6lxLOqwukKMJF9OFI68UYOWFgXIFfTw7llmpMi+33kcYMECD18IPnX2pVjDOTBxEryx7fKi9cFkUOk5wmroyalinwJUSUKWcNQF882HKMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lFZSf71R5KScaIgtNwyj78uSfTAzOxhx/KlkN+/VBBc=; b=gZJCjz8wbO7uktIuvMdl5R/XfiCkl50JtJBm2YSWJFsApu4rMwgWdpmx08JY5vVmsH0BGJFMIi6Ky2T+VWFose22DZpUcteYva572apSq8Jk4no7+AXeezlCCEF7eincXvJuMaTrBdzZeUFHPOBpzx4ddy/KX9IGYfLWpfujGCUjAs1eaXs2RCTO54uIWJZ4i/baq8KGzfD6KvZ7SrY4jBPqH3n30ORsqWxCDm542uXkMihoCiVvsTtQ5HwqevaVeeNP2NxyDPow3bpbFZW/DzHdFj7pJJ5zWiC+x7BDc8ftcXZ8BQ+mjrfWIp39YLcEMSx3uxzmocdFzk5LVci22A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lFZSf71R5KScaIgtNwyj78uSfTAzOxhx/KlkN+/VBBc=; b=HU6a4GO0B4imaIJfFK54+j9ewp1POdeU5Ve6MvvEWCaDXO+yjSK142ViJcGWQ/amekhLK7ampCRienl84Cjrrv4d+HMwTnFjzY+lls3cc/ZGAMWoF8l35Kh+yiuUhpAcvBHyg5NKlijtyNekKeuvHeTQaLExwstvrjkNIiybvmE= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 09/21] libs/guest: allow fetching a specific CPUID leaf from a cpu policy Date: Tue, 23 Mar 2021 10:58:37 +0100 Message-ID: <20210323095849.37858-10-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR1P264CA0017.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2e::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3b29899e-8ca4-477c-bc45-08d8ede27d72 X-MS-TrafficTypeDiagnostic: DM6PR03MB4969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2uHAtSnK0L/ffs6sgBLd288LfeYR5YpQ/OjUzq5Obw5JqYVgYB1MsAnryox2pSXKEA7T+fZ2AH1+Qxgtmv3kfCXUOE9jLPqAHBz1vtlitqxftPmsTP85YtzoG2ESoAXuDsIX2qPFat5yET5qkiNCZGPmnFR5eWbsomsWI2bHIvdQD7UFAGNliBa3y60Wzy49f9hrkJh6Et9iuhJGv4PrGdo4QUWH4knxDScIm8W/s7BV1kVhafRAb4/pjtteGoZ/yty63COX4S/GfZJg9RL9r8/Uu6cH3mHI2Nblp3Xik7Ikcpb/BPRhvb/fiaszbks3rMDxKQ1ZzIK1j6iDeA4CtU3MlbPE6eQHZlk+tBqbxN1LCpLxVGL3MZjkAD9RZc8T+ym6rq4RzJ/h/RiEk29I2evjmHFC526oNN/PIxksHL5rsm8mPDxiq0/MognCyuL4dnTM7GO4qqmciQsJhTjENRicwIW5HZE3YGOom5czGq0g2R/R1aLYEFST63UTKK29OnUduIDBslIh4bk0zCfIF5RcU4G5DqvYKZ+8SHo+7POAZauec61lmp4ONBmvgbNw4QXrxkhXqzee23X0yKBO6rYvGUcyDiE3UsesYL+8w5v3b40beW2nivencj2CPoh4IhTFibEF9S5JF2j9RUOrp195wUintmy7RWCZyZKanEw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(54906003)(36756003)(2616005)(316002)(26005)(6486002)(956004)(16526019)(186003)(2906002)(86362001)(66556008)(6916009)(478600001)(5660300002)(8936002)(6496006)(38100700001)(6666004)(66476007)(8676002)(66946007)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VG5PK0k3aTJuaU91Z2hiOE4xWHNLd1NnTFRaOFZPbExEZk5ZMEZYTzF0SmZi?= =?utf-8?B?NmYwLy9EN3lkWEVtUmdGb1RTOXNLWVFqWFBZcjdLVzJkdVhjbXg1YzNZUnk5?= =?utf-8?B?T1Q3OXJqRHk1YldaTzVzSW5oK2M3YnZVRUZ2Zjl3VFNkc2s1Tkh5cnpuR0NR?= =?utf-8?B?OWNDa3Zpc1NFVE80Q2FrNFpHUHdCb2JYTUlmazV3dWFiNFdjYnhwMFRmSDdp?= =?utf-8?B?eDdVeXdsdlF3YXZHTW1ZWWVkVERkamxoYVZKUG44QVlKbHM2b1NtVEtOalcv?= =?utf-8?B?RDF5M1NCRDVPTTU2dUxQcnZmdkh5Y28wWnRtcWZEeFVxWlk5akpSc09GUGEz?= =?utf-8?B?cndIdTV0VkJtbW1HZ3djQWJhdXBCaGZPUGhFUjhwQUplNStacWZxWkJ1azB4?= =?utf-8?B?UDZaTVVZWGZ3YWRoQi8zYTZKSHM2MmZaUTRWak12dkUvdzdKYjR0dCtqU2pa?= =?utf-8?B?S1Y1YnBSVUt1QzlmTFR0Y2V6WGpCc1QwQlFYTmpMWmwyV3N3MTJVOXdMbEVk?= =?utf-8?B?NXFIU3FZVGlTckF3K2xkWm85eGI3ekZKQmE3VVJDeHl5bU8rbXY0N0podmFB?= =?utf-8?B?U2g1SVRuc2F5aS9sWHVGcEdYMHRweFpxSlMwcXFsWmdiZGtHamhlTEUyeVVF?= =?utf-8?B?ejJNWEFaV2JZSjgvSVZURWorVElHanAwRU1PYUVucUdzRTVCZ0RQcURPeUta?= =?utf-8?B?SkJrZS9mQUlVSXNSYm9IK05WRkdydkMxbENZUUUzM0lrVmdiNEFuOHdyb3Z4?= =?utf-8?B?YjBjckg4T09lcWV2eVdxOWFmS1VVQXAvMmdtU0JNck0rU1BFTnNmUnZCR0lw?= =?utf-8?B?U3BjL1FsczRWV1I0ZVg4OXZocWZLTWhPbEppV0VCQ2VEeS9jLy9XcU8zOTFu?= =?utf-8?B?ZmJmL2xBN0lXNWhJZ0tKSU5CakViR0NCZG1Bd3NtbVU3ZUI1RVJWWGNXRzFE?= =?utf-8?B?OWRhK3FpaGw3S2Z4UUZHekxTWUdjNDhsMXpIMnA1Z24ydkM0VXJMeGg2a0hX?= =?utf-8?B?MW5zaW54b0UrRDhyVEdCVitpZ2V4SnRWVjRMZ0dpNHQwTlBJMnlLakQrbFBX?= =?utf-8?B?SHNvNWg1ODJGT3M3bmdlbXU5R1NqNERyS3JtYmhMdXJVR3BqWmlVRmJqemJv?= =?utf-8?B?VXhhdVdXbFRIaGlNMzRKWi92R2hybFhsMTdXWGZKMWRGZ2kwcDRPMHNEbHht?= =?utf-8?B?R2JLRnlEeDhrc0tLUDYrM3lMdmhUQzFiQU95RkR3NDBWWEZXMmdHNFduL24z?= =?utf-8?B?dWRmMjAzcVRkV2FNV2RxdzFlUVk4S3IrSktNSFhadnlFVFlEZU9admlDNXpM?= =?utf-8?B?VWd2WmdETTZNOWQ4dDB3Rkt6eHlITi9NWkJFeUVhd2NoaFNNYTlFV1ZaZWI1?= =?utf-8?B?b0o5cUNreEN3ODdWU0h6Uk1YSFpYNmZBUWR0NHZRTWQ5bFRjaHVianE0RlpD?= =?utf-8?B?SWFPcDk0aEluMWZQR0lnQnFIeFZ6R2NLQzk5bzhKOFZBTEp2ZHVUcVhFMGMy?= =?utf-8?B?NGlmbXc0NFQ2V0lkRXlxUXREei9WaVU0bjNFeVRBZEx1VDdRRVZmQzFpMzV2?= =?utf-8?B?MEtsQ3ZMRnR4WEVNQlFxK3I4a0E2ZnVTSkxYUUo4dk9iczRnUDZjaVptNG1q?= =?utf-8?B?bkg2c3J0V3JoNVk4RXNxVVhKaHhZcGRDME9jUWxFa2VSTGRsNUlocjA3ek80?= =?utf-8?B?Sk5OSzNmMys0cU05ZE93N3BKS2ZETGtldUJOTCsrMEUvSUZuOEFFenliWGsv?= =?utf-8?Q?vQ2ELLR2aNWUuAf2kwIvED/0mKJPF2npn0ZOdgg?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3b29899e-8ca4-477c-bc45-08d8ede27d72 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:00:29.8009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bZwluCNIJrDE/Cc4KWa/NXWw6F5YRx73wGxQqaKzX1dQA5k0gSX6iDTHlVA06vhk2RChSJYzJz3aIxAVwg4CMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 X-OriginatorOrg: citrix.com Introduce an interface that returns a specific leaf/subleaf from a cpu policy in xen_cpuid_leaf_t format. This is useful to callers can peek data from the opaque xc_cpu_policy_t type. No caller of the interface introduced on this patch. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 3 +++ tools/libs/guest/xg_cpuid_x86.c | 42 +++++++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index d82c99b2f0d..983e4c11d93 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2608,6 +2608,9 @@ int xc_cpu_policy_set_domain(xc_interface *xch, uint32_t domid, int xc_cpu_policy_serialise(xc_interface *xch, const xc_cpu_policy_t policy, xen_cpuid_leaf_t *leaves, uint32_t *nr_leaves, xen_msr_entry_t *msrs, uint32_t *nr_msrs); +int xc_cpu_policy_get_cpuid(xc_interface *xch, const xc_cpu_policy_t policy, + uint32_t leaf, uint32_t subleaf, + xen_cpuid_leaf_t *out); int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 48351f1c4c6..a1e1bf10d5c 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -883,3 +883,45 @@ int xc_cpu_policy_serialise(xc_interface *xch, const xc_cpu_policy_t p, errno = 0; return 0; } + +int xc_cpu_policy_get_cpuid(xc_interface *xch, const xc_cpu_policy_t policy, + uint32_t leaf, uint32_t subleaf, + xen_cpuid_leaf_t *out) +{ + unsigned int nr_leaves, nr_msrs, i; + xen_cpuid_leaf_t *leaves; + int rc = xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs); + + if ( rc ) + { + PERROR("Failed to obtain policy info size"); + return -1; + } + + leaves = calloc(nr_leaves, sizeof(*leaves)); + if ( !leaves ) + { + PERROR("Failed to allocate resources"); + errno = ENOMEM; + return -1; + } + + rc = xc_cpu_policy_serialise(xch, policy, leaves, &nr_leaves, NULL, 0); + if ( rc ) + goto out; + + for ( i = 0; i < nr_leaves; i++ ) + if ( leaves[i].leaf == leaf && leaves[i].subleaf == subleaf ) + { + *out = leaves[i]; + goto out; + } + + /* Unable to find a matching leaf. */ + errno = ENOENT; + rc = -1; + + out: + free(leaves); + return rc; +} -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:01:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:01:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100567.191710 (Exim 4.92) (envelope-from ) id 1lOdqE-00086z-Ej; Tue, 23 Mar 2021 10:00:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100567.191710; Tue, 23 Mar 2021 10:00:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdqE-00086p-Ah; Tue, 23 Mar 2021 10:00:50 +0000 Received: by outflank-mailman (input) for mailman id 100567; Tue, 23 Mar 2021 10:00:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdqC-0007wL-Fk for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:00:48 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8ebd2044-365a-40d0-a972-5e54513d72ef; Tue, 23 Mar 2021 10:00:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ebd2044-365a-40d0-a972-5e54513d72ef DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493639; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=h3ITOhX7tv2nwa7YAoQOgR1WKEOc5xT9SsXwsOaKEa0=; b=O5E6RJPaLqg72uneRLpxahDg5tXw5YI8BHZfuQheRYwabR3Ug1+VScA5 veLw3BalNHyE/AFN++llu2Lyej/MROVoKaFA7lpsBQCI31J5jbqtR3Som PRxzOh84AuU6/4uZ3N+1we6tMbQhW8KovCZZeqn0Ep3jnwCnso467ehvm Y=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: DoQAdXkY97gRg0xOI82IKO2YpwLHJeSaoo5SLrVHhfW2tVadrVJsD81WdeNze+YHrTCUEAHnZV s5Ln591fNZGgaa6JQfzRVDFl2lE+1FvWF+o4Ni2pvOMVU9c96C0m1DblSxlOcQ3wZpTjwjcY4W Kq4/rBXW3cRRdRcAkMjxqA9vAf7KxMn1d6FeT/xW9e9ZHNmZZ0sc9/zVL7fOqicIZ+/BVBFB7D 4lgpUu3oCdLo6LuZLkSLeoY8U6S6xFLQVNXLIKz5gSYat7z1tiN8VehX5yc9or+trGEtqCpIHg eEE= X-SBRS: 5.2 X-MesageID: 39900342 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:gNsv8KoOWVYjYSLLCSg654EaV5v5L9V00zAX/kB9WHVpW+SFis Gjm+ka3xfoiDAXHEotg8yEJbPoex7h3LR+iLNwAZ6JWg76tGy0aLxz9IeK+UyFJwTS1M54kZ 1hfa93FcHqATFB5/rSzQGkH78br+Wv37uvgY7loUtFaSFPR+Ve4xxiCgCde3cGITVuIZYiDp KT6o5milObCBcqR/+2DHUEQOTPzuej/P7bSCULGgI97022hS6ogYSQLzGjwhwcXzlTqI1Sk1 TtrgqR3MSemsD+8DDw/Sv575NamNzuo+EzefCku4wuBRjHziqtbIRlcbWesD4yu/HH0idXrP D85y0OEu42x3TNfnykgRaF4Xie7B8er0XM5HXdoXz/rdf3TDg3YvAx+75xQ1/ixGcL+PRfuZ g7uF6xht5sIj7r2BnZ3ZzuUSpnk0KlyEBS6tI7vjhkfqY1LINKoZd3xjIyLL4wWBjUxaoAC+ dUAMTV9J9tACmnRkGchGVpzdC2N05DZyuucwwHssyR5TBcgGp0+Use3NAehXcN7vsGOuF529 g= X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="39900342" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e4T+UxrA1vFb2VU7u6rOYvVMqWlLUTSndwSRVvhrNalwAhg0502GGSU7r68hLc0fOSGjnp4k9TCVuRLaRFVw0C36IGX/5HR5X7kzhWF8xtIMlrxaLF1x863dDRWanhxxfSL76hmCDHAwBPojm0hunYTCAo08vQY0DKfTe9xSaWZFbleygycvAEJRkDFx5C3meu0EGr+c2UbQ90BoEE0Py/aHwOPePDoXfcQ/tXiHTHtjUA9FcC2tdE8cmNUMiOJvpvj8wZPb0UHaNqgBBLYC7tfWC9NAQkRpsDJ1IYrY7G93tYmWHlAW5zNqEfwQvNhs/2DVxpEn69V9QlwQ6EQJOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tLD0gqExlSO+XE2AhvF0loGaIpssKAiJtCEzPFIxt+I=; b=mM4qGr6DrUO1XCpWDLopRqflOsOmaZt++8DtePWEfDyuZZqKQI0uo0KkIYhwLgbxkSHrH6CJElH7/Z/lmJO+wdCoJqjUj0F3EMm/Afbwq1efiAPH9IbjT6wYlTTIVcwLe/1573TexNrSMiC49iFMPGoSvdIFNyVGMeo7Cg+v5xzmD3QI46/I5eroTaZ54R+duP/fE9mUc6H2o6Iy/Gl8U0oebybHkVGyM9SP9akPxKc1A0dJBCygnRIDo09LdLKjWWj6j8RkK9jxFilO07tz6FibqiTp9bMW9lQx8FbhoirXfuKFLYFcSXJNUCpFksA09uGBphkCkn82SdR4Rl5iyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tLD0gqExlSO+XE2AhvF0loGaIpssKAiJtCEzPFIxt+I=; b=K+1pIRti4OggngmJ+ZzjtYTRmuFgJCK9wVwDLB84kxre/vPJuSMhxvUNiRK+dJEK/YU4B8jBUOBvnUiHAnsq9iBcoNdFpNBeWNopVLjuTuHgx1jnqTpF+wivCcXEVTDj8LRvV1sBK2842CSbnX6ZKz2/u18GIr6wYuoszat/8Sk= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 10/21] libs/guest: allow fetching a specific MSR entry from a cpu policy Date: Tue, 23 Mar 2021 10:58:38 +0100 Message-ID: <20210323095849.37858-11-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PR3P191CA0041.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::16) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c29a07e9-d2a4-4b80-6ad7-08d8ede280ac X-MS-TrafficTypeDiagnostic: DM6PR03MB4969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a2xPCDEFULyMxzkcoZ4/YVb/APADbiHa1/YPHvfUYgYmvq4XE6+qG5L9W3NFaiAdE11e0nzaVZSKgewg0bWhSo8p+o8Vox0nr9XHYw63zqtGaDGDVevaKKyoGyqvhq9as8Jw/rdeIkiU870Sx6W44fVYILoot1yhDACe5M2xNh/FvYIG0eSFuoGsLHYtUvI9c0EVQz2fncYOV05nYRYwZDNVWAGwGgmNRYZJD0mEGYc5/YyVkaSRJkWaWm9/PUHpAg4fWGnGUtVkF9cKHYRQMdX26OFf+Twvb7MUPVPiq+seqcjyhaai6y0JDwHqPGxV90y7MPaQmUVzuHi2tCHHCJLzU7pFzoVWv4RwpGS9mUc8Eb+SxitWPiECzd0Vcyt1j4ZudTWMsgt/SAjzE8PfKs5cnlXPJ8VYxJOWO0n0gR7Bi1okg3PXY52YXqJnQiSIdIHmPE60+mfybQ/PEMuAxxZJgLpqxl5Wn+h6xA4G5d/o1dpMQH9DZH1EGYAQ3j98Sbw9wA/uKSy+ScEDyZrGjL1IBR8YX0IjYttEPiQ6QyfpBxmUZyf7M9rrC14szzF5jVpk17h5nX1SlP/ZXTbPJlj2zL47+sah26lwwDLiZahZ8lo5+Ink9sLVE4iDPdmi/SGKkCySh9hlcsFL3s9AQfdJHqNkszzg6ayyZV/LG5I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(54906003)(36756003)(2616005)(316002)(26005)(6486002)(956004)(16526019)(186003)(2906002)(86362001)(66556008)(6916009)(478600001)(5660300002)(8936002)(6496006)(38100700001)(66476007)(8676002)(66946007)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?RmU3NlJKODV3QWI5RHNjbjlqdExiT29JZVFhM2tqNGF2NnljaXczdWtDR3Ex?= =?utf-8?B?TDhTNDBKdStFaC9tMDZsK2YvdUluWE9keUpadEhvbE5UYXd6eVdYN2wrV2Vn?= =?utf-8?B?WGJrZDZxUndwQTBWNjdITDlnaHcwd0NiS3dkbFBoeG1XV3dTLzJnRlJvTzJJ?= =?utf-8?B?aGt5SlVOejhJODMra3A4TnNBTW9oeDN4RE5RdFMvdnIzZkZqbkwyQXg1QlVt?= =?utf-8?B?Ni9zbkticmMwcjUrdmx4R1RtSkdCajlDRVlWU1JGQURpQWFLQVk1T3N2V3Zx?= =?utf-8?B?OGNaQjUyY01BWFJMYmpJSkEwRThwdnI1OFNRVzJpNnc2OTBNUUhsVVNleWhO?= =?utf-8?B?Skk0WVUwSjBmN2lxSS9CWWlIS1hNNEFmYzQvR0o4eUZOVm14T2lacGdQZHoz?= =?utf-8?B?ZFFSeDQrS3ZMdzExR1F1RG9iSFI1N3ZYcUxDY1h3SGpDb24vUTVDQnV3Mm9I?= =?utf-8?B?NStBeXJRMDIyYjMzWHRoYUdDYktCK2xlT0xuYlYxeXRhUmVBRWVLa3U2L1g2?= =?utf-8?B?MVZlYmF1NlFTSXgwNm12aGhOOEN5ZVB1R01tQU56b3R2RnR5Y2k2cHp2TXJO?= =?utf-8?B?VG5CQVJRaDFlV3ExNHpla0hsbHIwbFFMc0ZUM3ZNaTJUL2hqM2tBMlRLdDlm?= =?utf-8?B?ejZYcWFMNXg0UUJRcHlYckdzU3RzVm9uajQwK1ZGVXIrNjAvRUFCcUwzSUFC?= =?utf-8?B?OHduTlFFczd5bVhCRlpsVXpaQjQrbXpHYmgzTVR2NFBLWTh5TzlMeFVHT3o1?= =?utf-8?B?NmlCT0F3YVh2U2k5bDkyZHM3UXlMU1pvNjdyVzd2OTE5RmhXZ2VaY1llTGVC?= =?utf-8?B?NnVGQWFZMGYxbThnZmg1TEVYMXZ6eGsrWWVzcjlQVzg1OGJFeS9oU2VyL1Nz?= =?utf-8?B?bGRHREs5ZlpLcjkxTVhXWFFRaTZzOFozL0VLandPSytnR0VSeGFLTzM5UXh5?= =?utf-8?B?UWR2dUVubWRHWENTNmlzSWEyTnlWOFExbk5pek9QMVM4aG9ZWU1yUFlvWUdB?= =?utf-8?B?VmRlWEV3ZmU1SzZGYzdPYWNMbUdVbkFxVTk5MzBzalRSY3pmRzdIUWRsakJG?= =?utf-8?B?L3EzRktmTlBWczR6dkE0THlLK0ZIUWV6MFQ2OFNTdzNNVlkxWExFRm90Wlp1?= =?utf-8?B?am9SMTBacDE4SDZGRHgrTDRHNVpTTjFqTlkvYlVwU3h0bkFiU0NUcmh3NU4v?= =?utf-8?B?TmlNTEEyYmhlVnVqVXdEdjg5bVFPV21RNlJKVklLT2dVRS9uTEdldUtlTFd1?= =?utf-8?B?Qnd3bnNrNytHVHhKcloyeEVDekJEbDV4dk8yTW1SYnBWSmFUVGFTcTBtbi9k?= =?utf-8?B?Z0d1MHpCWUdtQXU5NWUzT0FRODNxSW8xNUhacEFPNmJhOFZydzJMSVlSMnNz?= =?utf-8?B?ekxlaTVvczZwY1FlcUdIdVZXbGp2S3E2K3YzOEhUQnhhVzhncVZJcndDeHI0?= =?utf-8?B?NkkwbDZFWWdST3dDV2t3UVpVOEpJYVhydmhxdjVsZm91V1FWOVlVeWljeUJZ?= =?utf-8?B?U0gzd1hDVGRPeCsrR1JaM0V1Qm9GNmwvSzFjZEZNcjArL2kzRGQwNHlTOG9k?= =?utf-8?B?Z1VsWDdpWk1YVFRiamNrRGZVZ3gvZW5aUmRxek1wZGVDZGI4eTh3akNMa2xx?= =?utf-8?B?NWVKUUJXbTh3RDJHNDRETzZHQWVZdGtFYVNlOEJtZVZ4aU0wb1NhOVdXT1NT?= =?utf-8?B?aDU2UkZuZXFxU2hCaHpEdWl6d3pGY3JGR0NneDljeHhpZytrRzdLNHVUSmQx?= =?utf-8?Q?lCzoZy39D8U+RjYwgjlFqKR7j2UiBuCeqP1EAFf?= X-MS-Exchange-CrossTenant-Network-Message-Id: c29a07e9-d2a4-4b80-6ad7-08d8ede280ac X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:00:35.1981 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xUx9M0aKZRAAr2pRVow6mwnk40rczOD/MifLldya1E1OvFPpucrxQp5lYEyL8tJQn7jmMaBx+RrXEVC/3SIRKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 X-OriginatorOrg: citrix.com Introduce an interface that returns a specific MSR entry from a cpu policy in xen_msr_entry_t format. This is useful to callers can peek data from the opaque xc_cpu_policy_t type. No caller of the interface introduced on this patch. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 2 ++ tools/libs/guest/xg_cpuid_x86.c | 41 +++++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 983e4c11d93..ab34df1dc98 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2611,6 +2611,8 @@ int xc_cpu_policy_serialise(xc_interface *xch, const xc_cpu_policy_t policy, int xc_cpu_policy_get_cpuid(xc_interface *xch, const xc_cpu_policy_t policy, uint32_t leaf, uint32_t subleaf, xen_cpuid_leaf_t *out); +int xc_cpu_policy_get_msr(xc_interface *xch, const xc_cpu_policy_t policy, + uint32_t msr, xen_msr_entry_t *out); int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index a1e1bf10d5c..091aeb70c9c 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -925,3 +925,44 @@ int xc_cpu_policy_get_cpuid(xc_interface *xch, const xc_cpu_policy_t policy, free(leaves); return rc; } + +int xc_cpu_policy_get_msr(xc_interface *xch, const xc_cpu_policy_t policy, + uint32_t msr, xen_msr_entry_t *out) +{ + unsigned int nr_leaves, nr_msrs, i; + xen_msr_entry_t *msrs; + int rc = xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs); + + if ( rc ) + { + PERROR("Failed to obtain policy info size"); + return -1; + } + + msrs = calloc(nr_msrs, sizeof(*msrs)); + if ( !msrs ) + { + PERROR("Failed to allocate resources"); + errno = ENOMEM; + return -1; + } + + rc = xc_cpu_policy_serialise(xch, policy, NULL, 0, msrs, &nr_msrs); + if ( rc ) + goto out; + + for ( i = 0; i < nr_msrs; i++ ) + if ( msrs[i].idx == msr ) + { + *out = msrs[i]; + goto out; + } + + /* Unable to find a matching MSR. */ + errno = ENOENT; + rc = -1; + + out: + free(msrs); + return rc; +} -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:01:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:01:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100569.191721 (Exim 4.92) (envelope-from ) id 1lOdqR-0008FW-Tb; Tue, 23 Mar 2021 10:01:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100569.191721; Tue, 23 Mar 2021 10:01:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdqR-0008FN-QO; Tue, 23 Mar 2021 10:01:03 +0000 Received: by outflank-mailman (input) for mailman id 100569; Tue, 23 Mar 2021 10:01:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdqQ-0008Eu-VT for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:01:03 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8fdba55b-bf6a-4b6c-b003-c71aaa53e824; Tue, 23 Mar 2021 10:01:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8fdba55b-bf6a-4b6c-b003-c71aaa53e824 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493661; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=7KO7gTVsvFjrD8UnwpRq3qnvKwX9RIxUIWr7RkzivD8=; b=A62HGMb2GRBWkBvEyv/2MRk1qpB4YGPbKFwCqau7WG+ru2pBlVVvJeXS 4j3JFHsx2TG3FVBbX4qBL8xUvSW2S9+0B6qXVZW9zZHF5k45V5DBYdi6c AUDrI+JfS7QsAybxfgQPeRjv2v+5Evz24VgmY6KhSYWPwki54FNT5MUC6 s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: v8Ha3slj7l1Z9rADSGg3Cw482nNlTGw+xfgmtp2iIoRGwqqG3OKJavETxjgxQTn4JX1I8fEDo+ YpuBBBs7MmBfYu7khPStmOa4G9yFSKHHoytEgYTnZ7INKBAu5M/MwzMSAQ4hNPn+fzMQbr4biZ sVFGpGK0DmnJhwVlX7adOnBM63ndHN4eu6ch2BbgYxqLAwkUypyqrBRhLTXA/9zyRMXLvxpLLq TbLveF989wPst8h+TUEqyYgsRRslEt968TGKC7vSs9stwGsbTHeZ0xvTfzjhkjpQ3gGAMTJstu xlk= X-SBRS: 5.2 X-MesageID: 40261280 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:PfEHMqGCEqtD0lZupLqFDpTXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7L0/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeOJwTXzcQY76 tpdsFFZOHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLT1CQYsI1XYfNi+wFEpqSA5aQacjHJ 2H6cZd4xamc3IbbsO0b0N1ItTrjdvNiZ7gfFo6FwcqgTP+9w+AxZzbN1yj3hkYWy5S2rtKyw n4uiHw+6nLiYDD9jbyzGnWhq4m/efJ7vtmKIiyhtMOKjPq4zzYFbhJf7GZpjg6rKWOxT8R4a HxiiwtNchy9H/dF1vdyXCGtniCoVRemEPK8lOEnWDl5fXwWTNSMbs+uatibhDb50A81esMtp 5j4mTxjesyMTrw2A7559TOSihwkFu1rXcIgYco/gNieLpbR7lLoYMF+kRJVL8GASLh8YgiVN JjFcfG+Z9tAB6nRkGcmlMq7M2nX3w1EBvDak8euvaN2zwTuHxi1UMXyOEWg39ozuNwd7B0o8 D/doh4nrBHScEbKYhnAv0afMexAmvRBTrRLWO7Oz3cZeA6EkOIj6SyzKQ+5emsdpBN5oA1go 79XFRRsnN3U17yCPeJwIZA/nn2MSuAdAWo7vsby4lyu7X6SrauGzaEUkoSn8yppOhaLdbcX9 q1JZJKE97uJWbjAu9yrk7DcqgXDUNbfNweu949VV7LiNnMMJfWuuvSd+uWBLeFK0dnZkrPRl 84GBTjLsRJ6U6mHlXihgLKZn/rckvjubZ5EK3Q+fkv2JEAX7c89zQ9uBCc3IWmODdCuqs5cA 9VO7X8iJ62omGw4CLu43h2PAFeSmJY+q/pXX8PhQJiCTK6TZ8z//GkPUxC1nqOIRFyC+nMFh REmlhx8aWra7qKxS4jDNqjGnmAj2QaoU+LS5t0oNzC2e7VPrcDSro2Uq14EgvGUzZvnxxxlW tFYAgYAnPEGijWkqWjhpwMDOT5f91x6T3bZfJ8mDb6jwGxtMsvTnwUU3qLXdSMiQgjfTZSm2 Z86rQSmraGhDapJ1YumehQCiw9VE2nRJZ9SCiVboRdnb7mPDt9SmqHnhS2oRA+cGiCzTRbuk XRaQmvPd3bCFtUvX5Vlpvw+FRvb2OHYgZbcXZhq7BwEmzAp1d+2eKGfbCIzmOUc1cOq9ttdw 3tUH83GEdD1tq33BmalHK+Dn0g3IwpJfGYI7I5cb3fs0ndX7GgpOUjJbtz85lkPty17bNOfu KbZgOPLDT3T8kuwBeYo345OC9y7Fko+MmYrSHN3Syd5joYB/GXHXFNA5c8CPuY53L/R/mJ3I 5i5OhF9NeYAyHUUJq+1arTbzR/MRvdrm69cvEwpflvzNAPnYo2O6OebCDB235G1igvNcvYlE sRR6Jg/bDKU7UfC/A6SmZ89lotmM/nFjpRjiXGRss/d0oqlXnVIpeg5KfJs6MmBiS61UDNEG ja1y1W5PHeWSSfkZYcFqIrOGxTLGwx8m5r8u/HV4reDmyRBqt+1Wv/Fn+2a7lGTqeZXZ0Wsx Zh+tmN29atSBCQ4nGngRJLZoRU82imRsuuAAWDXc5wmubKRWiks++N+868jDD+VD2hTV8X7L c1M3AtUg== X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="40261280" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ksIQ7JeM1Hfh/GKl3D4Wu7VUEA48MYckKlPo6DM/ERI8BUhrHIPI0nHQOLOYdB6H7oigssEcA9AbKlkbzw2pTFemFHDPdglYGdR+U2+rLJm76HcokgJQLXq2m0sIIVLfB7aMLBofWvba4vV33CX0XhO9hx6g0Krji9K6aHimZbuVtB4AR8+nFz1v5WBxqA7L+y7jHR2gOonpv7igJwaMTzPcIK9IJWdb7u1r13TcEy5uRor1AOBGGAS7qgYC4Vy6HH8vt6El5jKxuVoyRnfW7pQUrngJrGliBtT3BmcV2uWDnfmacguGzFqVBJ98XBCTAAlXFwDv5pNiNDbHKyWltw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aI7Y7A0OHymM1N3AAaa+CIA8yVMw6gOJwUG3C50vFTg=; b=ho+xaKbrYGwgFkICAp6aMq4ole1Y53uMJgaxSn6R6/ahLZviov6o1Ey3wZ4gO7vQmnfjJX3JHIKqTNu20K+u1lFXRKmzG6ska0lWRlhqScsWdrCByTF05Inelc9Slp7U0sSnnwq8S4dHtIADqTu4360imm2WWa2F/AxMWrFr0rSii/JF+ONVAS79s4MT/mGl0GnDCxWgmv/7w2AKEOR0cJ+L5qKvE0kRb2K1gjKmHzXW6zX7nsm8mP9ipnxCGs7lR3ghIiTHexVUTIHUIiS3iC3xqgahS2K8ZalOJoJDFX7wrgNTXPhkfzr5rkxTxLWlfTxcHzY6R6kxJ1p1PIw9Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aI7Y7A0OHymM1N3AAaa+CIA8yVMw6gOJwUG3C50vFTg=; b=A0LRBjVX3ybEyWYylLw+NFrGBGLQrIaitPigxBh1AWyQdjKvWkJOXlz47+B6iNQ5g6+gX50Xt+rMILbHu5q4TMd90csnMocC0aIXUHSzwIPKgmBO2QGizjQchbr4Z9KyxfvaKjV1IdG5ODh52aPdaWKHWl0son55/bnkrU1qMB8= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 14/21] libs/guest: introduce helper to check cpu policy compatibility Date: Tue, 23 Mar 2021 10:58:42 +0100 Message-ID: <20210323095849.37858-15-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0094.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 445ddd65-bf74-4793-de8b-08d8ede28e03 X-MS-TrafficTypeDiagnostic: DM6PR03MB4969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2958; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IEryU2nKESj207JzbEOhiqGz23Gfct2ZWjBPAD0Fu4nJC/DAOw0ebr5RhvfoVYFGJl3IDOiloSNQMbtVxdFYbZCRHx5ys11YR4PmTXLXYe+2Ai25tgGrRpDypn4GSqxEx20ohYuSIOqqsbLoowW/VBQ1jXXHSkMEoS+U7/HZISra3QWT4GE7g+NOIPFPySCOotYoLYJfeCwBxmnk+UnyA76gsxs7hKb0J5vLb936CXMoaSTYPswrI+ylAL9hLErxXmFQ+wqDLGke0pPoMgLdKJFwV9r6P5up+hpLARh8LWOfkXCwHMbQ474Rv++5v3x6I50GJZFaoBHsNqWBzw3/1rftlsMwFKe1h8vAn5NIMPP5LXiMSNObNIhXGkPNo8hDFS3sfmy2fvRLBY7+8vRAxtWSZAURDQDKZJMwGjlichcWrPw4Ph7pncQOix6Vx4YIOj7Vd8MbVUSOelT6huhVwHpYMoPStPeJU7CdFWakDGPDYupCGvVi7ypC9NteYYvpaAKurJIDluq2U4OIZyAXu6dIe4sgIVDEWVQWXAOoXRZLNIvRHa3j8aVEphD00a0FemEIvnwUiFypORB1iZ3Vo18I3OotNErORnlbc8ZOnYulaTETK40ZPCvtJyKplwcG8ZOKQbS4MjpqvtNOBb31JA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(54906003)(36756003)(2616005)(316002)(26005)(6486002)(956004)(16526019)(186003)(2906002)(86362001)(66556008)(6916009)(478600001)(5660300002)(8936002)(6496006)(38100700001)(83380400001)(6666004)(66476007)(8676002)(66946007)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?QTJSRnR1b0pOVzdTL01iRVAva0FPb1R3K1Q1bGNneGF3ZE5sMlJHMWJTSzFR?= =?utf-8?B?TFF5MXU4QmVqY3NOOVVkcTU2cHZETmVIakZ0azVmOUY2bUhrTUxNek9YemUz?= =?utf-8?B?Q3RScVNIYkp3Vi9XdXNNeU9ESDhPRFNPbjFaSlhBL3JJTmhOSUVEUE01TWpU?= =?utf-8?B?UEkrQ0h2OXB6UVRJVzl2Zk14ek9KWjRXWml2S0V4b1hRdTl5aUhjZTU2NGo1?= =?utf-8?B?bWdsby90NzRvRHQzVVE5K2JPSHN4VFpKTUM1VVFwZVBwbjU0QlFheDlpMlp5?= =?utf-8?B?UTBtc2tRbUJZMG9ucVhxa0dObVYzenl5eWwwZjkrbmpJL2pHKzMySG1TTEt0?= =?utf-8?B?VmZTMk9zKzZadC9MNE5sZGlYWlZISUdGM2I1cmJOVmJuOGdHc09sUCthNSs1?= =?utf-8?B?dzBkU2p3Z2NBNFkvMXczaFV5WHJ1Mm0rVVpNUnlFcXphMjQ0Y2JId01RNHh2?= =?utf-8?B?Y2tRaEJJSUFWUU5NSnhXUmw3WUN0VE96bDJiLzB2S0hsVjZHTyt3a2V5NXM1?= =?utf-8?B?aWtBcytYaUEra29laEJpNFJ4bE4yVno1MFR2MW9oMElXY3hHOEl1UnJPc3Ew?= =?utf-8?B?L0YwQzRybTlVdjQ4OHhNNHpVTjFibHlnS1JTLzRWOTlHNzNVRUtxY3EwbW1w?= =?utf-8?B?UEdvMkdSNTdwcklLZ3ZJNFpPWHVjMkExSnBOUzZYL0hoL0JFaVdZWWVXem1Z?= =?utf-8?B?NnlOT2cwdDFpNFdncWJUMUNtdlZJUEdURjlZVlNCeE9UamdYRmczaTUybGkv?= =?utf-8?B?bnNqZUZ6cmNOb0x1cmdGVkh4T3NQTVRSZWVnRFdVaHRmOXlxOHh2cmdDZk9k?= =?utf-8?B?ZFBBTjBwVFNFa1BlSm0rTzJKYlg1OUgvT1lqZWYvY3JkbnFIZnlqU0Z6V1pa?= =?utf-8?B?Z1IzaXA0T1FQUjNTUTFtMzQwTWRNYVhkTUZaYk42N0wxcmJyOHJaVGRRWWU1?= =?utf-8?B?aVltckdaUGpWSmUrcWZGQUVnWDF5K24rdk9iK2FFZlpvZFBqREE3dEhGNkNE?= =?utf-8?B?bjhqZ3dCUzNIazVkMFBKVjdUSkN0Q2RPczVZQml4TGYxczJ4YUFlZGwrdmZD?= =?utf-8?B?VUFFRlBkK3BMamRqMDlsbFZoSHZkWDY5ZzBHR0g0MTZmN3dPdUlIem5XNGJJ?= =?utf-8?B?YSthQlRPWjFKS2k4UmlvRXBpUzFaOUdicEM3ZE54elY0cjJLU0h1cXFyaDJx?= =?utf-8?B?MmxkdnE1K2VvcjUxSGppeHd5NzU5VTRhaUpNVTRFaVM2TVJqNUhzcStQNHZi?= =?utf-8?B?cHlXMVlnd005Y040a1VEdVpyZlV4bmNFWkNNTTBkbUwzd3pOYlFJcy80YjJk?= =?utf-8?B?eXJueUs1VEVhakZvckFJM2c3WG1pOTNwaFp1OGFLc0hjOGp5ZjNZTmwwM2xN?= =?utf-8?B?dHFSWTVzMGRQOTErbjdUSFp4R2lhbXEyMmcvQWJZRTUzbjM3d3R3dytaMmlZ?= =?utf-8?B?TUNmVHpWbWJSRWhrUU9jRlNuckZ6K1c0eUc1c0RzVVhvRFlHVTI1aU9UUmpy?= =?utf-8?B?QjJEem5vbU1WRi95WEhycDVQaCtvbmY4dFFoWDJ0a1dBMzRqNUtGeDNlQ016?= =?utf-8?B?eVpKV1hUTXpMUXRPWVVjMFJRS09IY2VRU0Z6QnNveU94RW5qYU9URXhvdXhS?= =?utf-8?B?akNQcmdxTGc0amxHQllpRDBHbjEyMW0wNklQcEFRbVdqeEV2ZmJ6TWkwRmJX?= =?utf-8?B?SWNvRkJmZXp0Yk1RMHZyZStHMHVDSC82SE8rd09UZDNUcmlEUlpTd3lhOWxi?= =?utf-8?Q?JixO7cI7QuTRS4PKEc9W/ErPxLsUKEJRXQhg5Ko?= X-MS-Exchange-CrossTenant-Network-Message-Id: 445ddd65-bf74-4793-de8b-08d8ede28e03 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:00:57.5149 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MkCLT83fMmUG3tUHZ8eJG42fY6MbZPwGUsVsRi/rX2iiq7xtq5G2E0dJ9oEWZVzSIsGLNhjusTYg5wMw2envNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 X-OriginatorOrg: citrix.com Such helpers is just a wrapper to the existing x86_cpu_policies_are_compatible function. This requires building policy.c from libx86 on user land also. No user of the interface introduced. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 4 ++++ tools/libs/guest/Makefile | 2 +- tools/libs/guest/xg_cpuid_x86.c | 17 +++++++++++++++++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 164a287b367..165beff330f 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2619,6 +2619,10 @@ int xc_cpu_policy_update_cpuid(xc_interface *xch, xc_cpu_policy_t policy, int xc_cpu_policy_update_msrs(xc_interface *xch, xc_cpu_policy_t policy, const xen_msr_entry_t *msrs, uint32_t nr); +/* Compatibility calculations. */ +bool xc_cpu_policy_is_compatible(xc_interface *xch, const xc_cpu_policy_t p1, + const xc_cpu_policy_t p2); + int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, uint32_t *nr_features, uint32_t *featureset); diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile index 604e1695d6a..6d2a1d5bbc0 100644 --- a/tools/libs/guest/Makefile +++ b/tools/libs/guest/Makefile @@ -40,7 +40,7 @@ $(patsubst %.c,%.opic,$(ELF_SRCS-y)): CFLAGS += -Wno-pointer-sign ifeq ($(CONFIG_X86),y) # Add libx86 to the build vpath %.c ../../../xen/lib/x86 -SRCS-y += cpuid.c msr.c +SRCS-y += cpuid.c msr.c policy.c endif # new domain builder diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index f7b662f31aa..30ea02a0f31 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -1098,3 +1098,20 @@ int xc_cpu_policy_update_msrs(xc_interface *xch, xc_cpu_policy_t policy, return rc; } + +bool xc_cpu_policy_is_compatible(xc_interface *xch, const xc_cpu_policy_t p1, + const xc_cpu_policy_t p2) +{ + struct cpu_policy_errors err; + int rc = x86_cpu_policies_are_compatible(p1, p2, &err); + + if ( !rc ) + return true; + + if ( err.leaf != -1 ) + ERROR("Leaf %#x subleaf %#x is not compatible", err.leaf, err.subleaf); + if ( err.msr != -1 ) + ERROR("MSR index %#x is not compatible", err.msr); + + return false; +} -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:01:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:01:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100573.191733 (Exim 4.92) (envelope-from ) id 1lOdqd-0008Lm-6N; Tue, 23 Mar 2021 10:01:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100573.191733; Tue, 23 Mar 2021 10:01:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdqd-0008Le-2d; Tue, 23 Mar 2021 10:01:15 +0000 Received: by outflank-mailman (input) for mailman id 100573; Tue, 23 Mar 2021 10:01:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdqb-0008Eu-GH for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:01:13 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ba0ad827-ca82-4208-8b2f-546188866a20; Tue, 23 Mar 2021 10:01:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba0ad827-ca82-4208-8b2f-546188866a20 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493666; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=4lHE2jerg+jbItJ/+12Vb+5du8PMBfuwXfXIwSVEhTU=; b=Ms7dQoMLj4gSnW+pX6RZZfbzsK5c3WbHTvE03+dvu4B4XZ0FtPVNKxyu QcI68rIqByFL2sMWtJ41+8AxvEJlaQwo3Cj8omOELRhbQcuOa3D9kSLcz jnHAHXKq3vCVLMEx4E6WI2VXfLVKzvR7xlOrU+pe2pH5DCMPuqtfKSq0b Y=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: g7DxBHYwtYpWsEK6qiAP6OXHSwV0FtbUHsNBYw9n2kIZlqi8GS6hpKwlcTAhC5J1VrRRVB1i0G pCXKUGpkKJ1LxQVufXNH/2aug9GpnpFptmhWkh5DswzwhjxcmDP5Ls801+EMckIgaAVjg/6Irx T37oLgcVTNcQtd0cFw5VF7QMVuNXZ1992p4mxEBlZfWmidhgcNgHxuR+yKjXm5R5zZRFnbI5Fs yr5J5u3kPIfyn8uA31Tw7g6Gj9Sfjr+AH2OyH4sGI4Ci5X3wOlnHq2QZR8yZQR8U9Kc6VMNldV PT4= X-SBRS: 5.2 X-MesageID: 39779677 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:5+QMA647FC3TfJosLgPXwU2EI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoexzh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdxHW3tV2kZ 1te60WMrDNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2BXQotLhj0JbjqzOEtwWQVAGN4FD5 Ka/MVKvH6Nfn4QY8S9CBA+LpT+jvfMk4/rZgNDOg4/5GC1/E6VwZPZMzzd5BcRVDtT3awvmF KqryXV7riu2svLrCP0+HTU6/1t6bnc4/tFQPeBk80Ebgjr4zzYH7hJf52nkHQLrPq06FAs+e O80ysIG8ho8XveciWUjHLWqnDd+Q0j4XPj1lOU6EGLyaeSJENYerh8rLlUfRfD500rsMsU6t Mw40uju4dKFhSFpSzh5rHzJmBXv3Cpqnkvm/N7tQ05baIibtZq3Oki1XIQOpIBECXm0ZsgAe ljAerNjcwmD2+yXjT3uHJiz8erWWl2NhCaQlIassjQ6DROmmtlpnFoiPA3rzMlztYQWpNE7+ PLPuBBk6xPdNYfaeZYCP0aScW6J2TRSXv3QS2vCGWiMJtCF2PGqpbx7rlwzvqtYoY0wJw7n4 mEeE9EtEYpEnieSfGm7dluyFTgUW+9VTPixoV1/J5ioIDxQ7LtLGmqVE0uqc29uP8Sa/erGs qbCdZzObvOPGHuEYFG00nVQJ9JM0QTV8UTp5IVQFSLjsXXKpD7l+DSffrJTYCdUwoMayfaOD 8uTTLzLMJP4gSAQXnjmiXcXHvrZwje8PtLYe3n1tlW7LJIGpxHswATh1j8zNqMMyd+vqs/e1 Y7BLvml6i8tFSn5Gqg1RQsBjNtSmJupJnwWXJDogEHd2nud6wYhtmZcWdOmFyKOwF4VMGTNA JEvVx49eaWIvWrtG4fIuPiFljfo2oYpXqMQZtZsLaE/93ZdpQxCYtjfrdwGwXNHxlcgh1rt2 9HVQ8BSibkZ3DToJTgqKZRKPDUdtF6jgvuC9VTs2jjuUKVotxqemEWRAe0UcmcgR8nQh1dgl EZyd5ZvJOw3RKUbUcviuUxN1NBLECaGqhPAgi+aIJIobzzYw1rQWCWhTuVtgErdgPRhjYvr1 2kCRfRVeDAA1JbtHwd6Krs/V9uXki2fk57aBlBwMZAPFWDnkw2/f6AZ6K13WfUV0ALxfsFNi rZJREIJBl1+tyx3BmJuTqLGHk83K8yNujFALlLScCU5lqdbKmz0Y0WFf5d+5hocO30uugQSO SFZku7Kij7B+5B4X3iml8VfA1P7F8qnvPj1Ee7sCyW3HsjDeHTJ1ojbbcBON2Y53XlQfHN8J gRt6NAgcKAdkHKLviBwuXrShQGDDX5i2u/VfspppBZprhajso6I7DrFR/zkEha1xA/JvrunE wQQK5H8KnMU7UfCvA6SmZ8xB4Vj9yBI0sgjxzuDsI/dV8riWXHP9nh2cu+lZMfRmmIpA79Ij CkglVg1saAeyuIzrgBDa0sZUxQdUgn8XxnldnyPbH4OUGPd+tZ+kC9PWL4WLhBSLKdEbFVih ph+dmHk6u2cCX/sTqg8AdTE+Zr82y9R9m1Dx/JMelU88aiMVDJu5CU2qeI/X7KYAr+TV8Zi4 1DfVERacoGqgBKtvxJ7gGCDortokwklFNC5ypAjVCF4Pn+3Fvm X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="39779677" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ETCXfI8+ug8o2r3jD159Dfvxjq9eQ5HaZhNM224zFkq1yEmJhZF/asZzlR9JekKmCW8vxJTQszxiCDgzSDHVYqooEHEuTiKEYE3sZq2oww6knc3d8mq8Gq/jYkv/NoCjNpbuuZVDuAZuXEn7jhwHiVc46aXGPZQQDiKKH841FlcWwvQRlJJsh58RrUL9OgF5iEeAXlJHLzACl0ffgvLuQI/UJ/AmVoySa0yn1dklPhiV71ib9E1znyOx3wnGzyjKcNatQRBDstxrAS4LpfGHYOOTBeMwhnzNNoMlOF4YQ730n6uM8FEiE2VFQiT6RhCfRCpIlCmjHTevytX0Lhcgmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Blm/0Bd7WSGIeDuYXRMAPB5HSkKSVJuxKVDttIrYYCg=; b=klrFH4V3jYsh5HZM3rZXQQHfJovV8oh/QsSy7bXXZ2LxJx2RQlPkXJBfhsz1SRAXYHO6dKSHHn6SE2Z7qvZQ4dyP8gJGvOhPyuNob8d89/dyJZLZjsjZTXLdf0K0RDwJYRl9VbQOUsRSkxCqVvzvzKV6eUI9Uqnpy+217Sj3sKFBObAfBxpmhhNSv5x1xpFXEQUSAQBCSE9zS5nB0nPWR9zo9otqYwuyeVpdCZ/HSqjU0HXhKml9bkzrf7mxK3KxbZ29Dzrie9wEYrAIklcIm3mIkI7z5t7/x8vE4idYpTucFfTs3VIxdV3YJvVCvAPjxSL51SA8+b8ykgOvdBEmhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Blm/0Bd7WSGIeDuYXRMAPB5HSkKSVJuxKVDttIrYYCg=; b=ck3d6o4ZCj7tLxrgbrYwNUpew2URpTntyP9ahfroDKOb/DQnjSLnTv+sjy3s4f4i8WoS52JIWygoPpd987crw4Wy9qm0KrzAtGa1oQLS3lWEae1S8vWZDUXWti6pgOSualiSmDScpTu8kD24IZ1/vGsh7UpLAZBIL1svJPkmG0g= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu , Anthony PERARD Subject: [PATCH 15/21] libs/guest: obtain a compatible cpu policy from two input ones Date: Tue, 23 Mar 2021 10:58:43 +0100 Message-ID: <20210323095849.37858-16-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0109.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::25) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9c6c3518-4f3d-4d3f-f189-08d8ede2913c X-MS-TrafficTypeDiagnostic: DM6PR03MB4969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7DVBL7yOKHSTGw8bYEX6EyAgcb5SMH6bb6HORNjz7trlRfw0L/RN1ZrhXD+Z/+WqyMryYLBVFT+EkVm0+dwilsjaVgAGjhadNAfD9A0a9Fld5PwhrwaYGQFcz5uhzhlitrgPbw5JROpIF3RLSq9Kl4C5EZs17HsChN4+y60v5q0i44f2g5u6RYjJNkYobi6P8ow1U0i+5DOoR2Celn6jRRmi/ppyAFjO0cGoOIbZr5B1I9Z263kqwvlvkzBmsBCYNYjS21xpJpefn8KtlRWbawo1GySO6BBb2VrgXx2dzC9mBv6PBrOirbdKB2Z3kJo2r17p5nd0KQNI7zyALv4BwZ/z43WmxmqVehnZXGQP6VVOWtSN0vgZN1YYasly5v/IbA8aRgjg1dcjXf5tUDZp2cvJNmxEVsdI07byxs0KQfyRrO1pRNfwuBXIh1nCNAi1GLZNEbHL4T47WFnQVp/lMoqAxpcQdBTJ2OGPo8pdfb2JsIBIwqmnkuC3fvVk56l3c/YQqRBI2x7MuLg5KB0mKZqwqI+IFDEIXulM7IJ9R1lRhIB/N++kh83shNuvcKoIuc6VMi2YqHzKHhqPSdgF0M/NGiqehOws5VIDptz125bNnu7lMvK5XTL/uN+y1r+i07yrHROww5IFHQ3jbXLkZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(54906003)(36756003)(2616005)(316002)(26005)(6486002)(956004)(16526019)(186003)(2906002)(86362001)(66556008)(6916009)(478600001)(5660300002)(107886003)(8936002)(6496006)(38100700001)(83380400001)(6666004)(66476007)(8676002)(66946007)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?TEt3QzFpQ0o4dVlTUVlPM3d0dzg0NlFIWEdzNW83dFpTck4xVS81a1lKeGJF?= =?utf-8?B?aW0yUG9MdDVyWHV2UTJkTlVEQXhCeklWZkJMTGxNdmg1Y0czZC9mTFhod1lh?= =?utf-8?B?V0tObFlIelRyZkpCSERVNWU0VHNFcXo5T1k4bmNCdDZncGpWbE1aYnA2ekpW?= =?utf-8?B?MVErbzNFRm9CYWY4TXYydVRTUDdzWkRPaFNHMEl1aTdEMkgyTHBaVEhkNDJv?= =?utf-8?B?MFp5RjBNWndZR1VLUzFWbThJRTB2bjJvaHRSbDV1YTV4NzkxNzkvc2NqdTZ6?= =?utf-8?B?Y2daUlh6anF5Snc0dVphODVRKzJNL2loZ2VSUG1VMUtyRElQYjgvZFZZenRK?= =?utf-8?B?YVdnN0l2ekovcll2Z0M0bTlQeW9YWjBhdzlmSng5QVhENVFVWUwyMmhDaTFV?= =?utf-8?B?TkRFU2lwMHVPcWpXenYyOG4zam9wT29TS3pKOXA2dVVXSENKS0tCdER2TlJR?= =?utf-8?B?SWF6aUlaUWpsK1VNZk4xSlFVTHpFZno2bmxEUUY2bWxRVzJSd0pyMWpndGRV?= =?utf-8?B?ZXhnQzFCM3VzOVJtUXBLR2ZEd0tFUzE3UkI2S045T1A2WWxzYXVLait4L2FR?= =?utf-8?B?Y2VwUE8yOXN3YnB5Mm1Fb1VQa2Q4VXl6SHFGQ0Z3dU9iZW45TCtJc0lPdGtu?= =?utf-8?B?RlFVOUdzakc4akxzVkRBRGE2blNhdXdseTRmRFVsZGNVN3RXajBLS043Y2ZQ?= =?utf-8?B?TUUrNDA3UkFVWUswdlhOYkJwakpiY3NRMWxWdTgwelpycDdlRFFOTEc5Um5V?= =?utf-8?B?bUJoOWU1WGUwbWRVSkxQdHVpUXJQdjFzODVFNHJ5K2JzVlBoTzN6N2hVZWZs?= =?utf-8?B?OTJxUW12V1RJWGN2UXZTNkx0a0sxdEt0TE12K0VMSk9QaXp1bXFQZ3ZUamx4?= =?utf-8?B?c0NZNGYwUzJtZG1pbTFzMVBxRUZ5WGNQcGpXYnpGZXpJZk56MklIS2V3OS9D?= =?utf-8?B?dlR1OVBHdWFGQ0VMdTVFY0UrM1AyblllRFc2VTJPS0d1NmZLWjVVbklYSHg1?= =?utf-8?B?L1BRN21BTzFCUFh0amxVMjVGNyttS1NRWjdhbXNZRlVEeDFlbitIblozSnF2?= =?utf-8?B?UXU2Y2Z6d2tLbXFyWUNxSHo1akRzb21KY3JFR0l4YklDaFNYRWg3M1B5MURj?= =?utf-8?B?cytHU1dtbXhxbHMrc0liaWh1MU52TGdWSlNQQ3BIaEVINGRIWDBiaVhMeHE1?= =?utf-8?B?T0Nrb1d1YXNuMXI5aGtrbWdoNUE2cU9xVkorZER6MUI4OTRlSEFPK1RXNEhL?= =?utf-8?B?MHFJSFk0ZTY2NVVQQkxtWFRGZEo0QjZxdXhoMnF5YzBpaGVueHJXTFI4NjFU?= =?utf-8?B?V0hpQzJhSjY4R05UbFFmR3pVS2FyRGVGbGloWkhTd1V4WGxrcGg5azUxcXls?= =?utf-8?B?c1Z0bnJsM0k4TU8rMDU4RWJIWG1TTG5hNHV4Zk5EZnA0ZkViRnMxdENIY08z?= =?utf-8?B?S0FMWFRpQjF5emYyclJLYWZUbVRqbUx1TjFEWkVoVkVZVC9hZFlTc3UyM1hN?= =?utf-8?B?d2lNdTErMTRoM3RZUTlWa0FaSFZBcnZGZHRyZVRncXlMUEJIOTNJYnpBRVI2?= =?utf-8?B?K1pDNEhDRGFtSnhzNWI5SHB0cUpiQUFhb3QyZTZtdEY3L0hwYXRlektFdEkv?= =?utf-8?B?bVZDNndtK3JIU3ZSd05xSXNzTDNBS0VmS0g0VzBSS1ppZG55VThkeVdjTE40?= =?utf-8?B?K1NWcDIvZkkyTG1IczVmUzNFcC9FMExmeVdicnB4eDJvZ2tObk01UUpPaEtR?= =?utf-8?Q?2Zof/etTs/ixJliBRQqr+jHCFbv47wJny3rq5XW?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9c6c3518-4f3d-4d3f-f189-08d8ede2913c X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:01:02.9122 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AmBkQTDaZgYjvGrZzSZcRLwEcJRHNbMFH99lfS0ltQcX9GYSgV6GcICqwk8W0nZyu5IYAZGAHKIYnAHXV+jKww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 X-OriginatorOrg: citrix.com Introduce a helper to obtain a compatible cpu policy based on two input cpu policies. Currently this is done by and'ing all CPUID leaves and MSR entries, except for MSR_ARCH_CAPABILITIES which has the RSBA bit or'ed. The _AC macro is pulled from libxl_internal.h into xen-tools/libs.h since it's required in order to use the msr-index.h header. Note there's no need to place this helper in libx86, since the calculation of a compatible policy shouldn't be done from the hypervisor. No callers of the interface introduced. Signed-off-by: Roger Pau Monné --- tools/include/xen-tools/libs.h | 5 ++ tools/include/xenctrl.h | 4 ++ tools/libs/guest/xg_cpuid_x86.c | 115 ++++++++++++++++++++++++++++++ tools/libs/light/libxl_internal.h | 2 - 4 files changed, 124 insertions(+), 2 deletions(-) diff --git a/tools/include/xen-tools/libs.h b/tools/include/xen-tools/libs.h index a16e0c38070..b9e89f9a711 100644 --- a/tools/include/xen-tools/libs.h +++ b/tools/include/xen-tools/libs.h @@ -63,4 +63,9 @@ #define ROUNDUP(_x,_w) (((unsigned long)(_x)+(1UL<<(_w))-1) & ~((1UL<<(_w))-1)) #endif +#ifndef _AC +#define __AC(X,Y) (X##Y) +#define _AC(X,Y) __AC(X,Y) +#endif + #endif /* __XEN_TOOLS_LIBS__ */ diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 165beff330f..5f3e5e17e9d 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2622,6 +2622,10 @@ int xc_cpu_policy_update_msrs(xc_interface *xch, xc_cpu_policy_t policy, /* Compatibility calculations. */ bool xc_cpu_policy_is_compatible(xc_interface *xch, const xc_cpu_policy_t p1, const xc_cpu_policy_t p2); +int xc_cpu_policy_calc_compatible(xc_interface *xch, + const xc_cpu_policy_t p1, + const xc_cpu_policy_t p2, + xc_cpu_policy_t out); int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 30ea02a0f31..4afca3249ba 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -32,6 +32,7 @@ enum { #include }; +#include #include #include @@ -1115,3 +1116,117 @@ bool xc_cpu_policy_is_compatible(xc_interface *xch, const xc_cpu_policy_t p1, return false; } + +static uint64_t level_msr(unsigned int index, uint64_t val1, uint64_t val2) +{ + uint64_t val; + + switch( index ) + { + case MSR_ARCH_CAPABILITIES: + val = val1 & val2; + /* + * Set RSBA if present on any of the input values to notice the guest + * might run on vulnerable hardware at some point. + */ + val |= (val1 | val2) & ARCH_CAPS_RSBA; + break; + + default: + val = val1 & val2; + break; + } + + return val; +} + +int xc_cpu_policy_calc_compatible(xc_interface *xch, + const xc_cpu_policy_t p1, + const xc_cpu_policy_t p2, + xc_cpu_policy_t out) +{ + xen_cpuid_leaf_t *leaves = NULL, *p1_leaves = NULL, *p2_leaves = NULL; + xen_msr_entry_t *msrs = NULL, *p1_msrs = NULL, *p2_msrs = NULL; + unsigned int nr_leaves, nr_msrs, i, j, index; + unsigned int p1_nr_leaves, p1_nr_msrs, p2_nr_leaves, p2_nr_msrs; + int rc; + + if ( xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs) ) + { + PERROR("Failed to obtain policy info size"); + return -1; + } + + leaves = calloc(nr_leaves, sizeof(*leaves)); + p1_leaves = calloc(nr_leaves, sizeof(*p1_leaves)); + p2_leaves = calloc(nr_leaves, sizeof(*p2_leaves)); + msrs = calloc(nr_msrs, sizeof(*msrs)); + p1_msrs = calloc(nr_msrs, sizeof(*p1_msrs)); + p2_msrs = calloc(nr_msrs, sizeof(*p2_msrs)); + + p1_nr_leaves = p2_nr_leaves = nr_leaves; + p1_nr_msrs = p2_nr_msrs = nr_msrs; + + if ( !leaves || !p1_leaves || !p2_leaves || + !msrs || !p1_msrs || !p2_msrs ) + { + ERROR("Failed to allocate resources"); + errno = ENOMEM; + rc = -1; + goto out; + } + + rc = xc_cpu_policy_serialise(xch, p1, p1_leaves, &p1_nr_leaves, + p1_msrs, &p1_nr_msrs); + if ( rc ) + goto out; + rc = xc_cpu_policy_serialise(xch, p2, p2_leaves, &p2_nr_leaves, + p2_msrs, &p2_nr_msrs); + if ( rc ) + goto out; + + index = 0; + for ( i = 0; i < p1_nr_leaves; i++ ) + for ( j = 0; j < p2_nr_leaves; j++ ) + if ( p1_leaves[i].leaf == p2_leaves[j].leaf && + p1_leaves[i].subleaf == p2_leaves[j].subleaf ) + { + leaves[index].leaf = p1_leaves[i].leaf; + leaves[index].subleaf = p1_leaves[i].subleaf; + leaves[index].a = p1_leaves[i].a & p2_leaves[j].a; + leaves[index].b = p1_leaves[i].b & p2_leaves[j].b; + leaves[index].c = p1_leaves[i].c & p2_leaves[j].c; + leaves[index].d = p1_leaves[i].d & p2_leaves[j].d; + index++; + } + nr_leaves = index; + + index = 0; + for ( i = 0; i < p1_nr_msrs; i++ ) + for ( j = 0; j < p2_nr_msrs; j++ ) + if ( p1_msrs[i].idx == p2_msrs[j].idx ) + { + msrs[index].idx = p1_msrs[i].idx; + msrs[index].val = level_msr(p1_msrs[i].idx, + p1_msrs[i].val, p2_msrs[j].val); + index++; + } + nr_msrs = index; + + rc = deserialize_policy(xch, out, nr_leaves, leaves, nr_msrs, msrs); + if ( rc ) + { + errno = -rc; + rc = -1; + } + + out: + free(leaves); + free(p1_leaves); + free(p2_leaves); + free(msrs); + free(p1_msrs); + free(p2_msrs); + + return rc; +} diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index 22b1775b752..53b8939fb5a 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -126,8 +126,6 @@ #define PVSHIM_CMDLINE "pv-shim console=xen,pv" /* Size macros. */ -#define __AC(X,Y) (X##Y) -#define _AC(X,Y) __AC(X,Y) #define MB(_mb) (_AC(_mb, ULL) << 20) #define GB(_gb) (_AC(_gb, ULL) << 30) -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:01:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:01:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100574.191746 (Exim 4.92) (envelope-from ) id 1lOdqi-0008Pm-LG; Tue, 23 Mar 2021 10:01:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100574.191746; Tue, 23 Mar 2021 10:01:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdqi-0008Pe-Hb; Tue, 23 Mar 2021 10:01:20 +0000 Received: by outflank-mailman (input) for mailman id 100574; Tue, 23 Mar 2021 10:01:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdqg-0008Eu-GT for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:01:18 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 546e2cf3-4ca8-40b6-8fd8-271706176efc; Tue, 23 Mar 2021 10:01:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 546e2cf3-4ca8-40b6-8fd8-271706176efc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493672; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=/Woeth1Qo4qC19JO5EGPKMCsmplx3e3Bv1+R+5k6GM8=; b=JTDGJGWfUZRsIFHsoHBpaLZDtK2n35t1w44/bcr7aZFXAEnXU1HKrfzc yh2iMwNDtl2ouS5Z9lOEvLbVTjxtU02yw7ycZ+MiTZKv2TXMj/6eDUyi8 lGUwdb7CtiDqckKKEeN9j97r8A5tBnGIR/SvRuKwk+kOOMRtd5NkyWrbm g=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: A4PPknK72bCwVwF9v6geA7W2A7lMdgdjTAMz15nEfD9Kj1Gr6XGnJSfhtLEbNdHZdNLKeNy1n2 8Wk3a+dIhabJ8yjtw04s1FsZ4G4n20cB8xdSUjmt51ZBEdaCyl3ONnKtx9JN9MEuognNF60QE9 gOKI95DXJy2UU4lO66JVhYGd3Rwlg0PXjjtNt3sTXlRtezTkixazO/ulZBO4hz9x6bhIHIy8lu 8BYAGVoWZdcexSRa2FtUSVPGBIFTAi4A4s+9es3p2fKdbtQCE6dNtbfDFhV+yOuoygvvOD8Qz5 hTk= X-SBRS: 5.2 X-MesageID: 40261295 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:qPcfFq8VxUJWanqOmeZuk+EKdb1zdoIgy1knxilNYDRIb82VkN 2vlvwH1RnyzA0cQm0khMroAsS9aFnXnKQU3aA6O7C+UA76/Fa5NY0K1/qH/xTMOQ3bstRc26 BpbrRkBLTLZ2RSoM7m7GCDfOoI78KA9MmT69v261dIYUVUZ7p77wF/Yzzrd3FeYAVdH5I2GN 69y6N81lmdUE8aZMi6GXUJNtKrz7H2vanrfAIcAFof4BSO5AnC1JfBDxOa0h0COgk/o4sKzG 6tqW3Ez5Tmid6X4Fv212jf75NZ8eGRt+drNYi3peU+bhnpggasTox9V7OFpyBdmpDS1H8a1O Pijj1lE8Nv627AXmzdm2qT5yDQlAwAxlWn6ViEjWDtqcb0LQhKdfZptMZiXTbyr28D1esMt5 5j7iaimLd8SS7kpmDb4ePFUhl7/3DE2kYKoKoooFF0FbcFZKQ5l/14wGplVK0uMQjd844dHO xnHKjnlYxrWGLfVXzfs2V1qebcJ0gbL1ODSkgGjMSfzyJbqnB/11cZ38wShB47heoAd6U= X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="40261295" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DxSIYiAohgbBF0klDtKHYdqWnvupqP8/NIagBMTq/1K3i5VSj4ev5jxYli4LWqRrivluWM8r/bqeExtddt+SLCRYkVX+lLePKkFbZFNem/qV7btpHUvt0SWCkUoK0h1I7RWR6EBTkxAsu3zySFySKLA3SRvVnoWNC0i1VRUprBAVgN51/gGZnSMPkX4J6SEL59hQhNgtVNCpslf8lFwRK8kHhIyUCJWnwhi0cVoEydHWuoBBDMcwrNE7y232aaxGH3nt1ton7E1ox+9vn5jeP3GUhDMRPL+mqaAPFgqV4wCggGu9hFEMLiWWEpGdyAR1ZbhO2ToP+YpPVmzg09pXew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RlUBOnVeSatdTasqz2pA02ppHxyAvCsUzYnjh93s6fw=; b=cDwW2TkyvklVbV/GUeHZ5rSFJBVkXYCCLmuBNrySCGsIzgX6EFrhEQlExMVDfZg6Kef3MJ1837WC+/E6s34s6d3XRHvDfBH3SiV+KDxWwvjOcRNWhV0xlvxJW6k/Ez5Kjx9TRiM/Ao/J4MfF8Hyq2TM0M00JJ4CFyS55DmJQvmKO8DeDrAMUN09X/cymIVeYmQEaLAuTSL8FKvZ9dcnimm026j03IAK/IoJxvccVtc1GE1hQE+FFAm5jiMyTbjq1+JJFOaCWP2VP7qs8eq00T47MyHkgb4pQz7uWbHezMH5ouhLGyhuNilHtRb6c3P+0xmprfBOE2LptmjZ1Rs+4ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RlUBOnVeSatdTasqz2pA02ppHxyAvCsUzYnjh93s6fw=; b=JUow7egOyee9RYbfQ/3h7JvTbajg7tkFlWfNKwjJQdGXHf+jrEfnRD/eQPU7ECmnpQFzd1IpAQWXeUDjhY8TII0tC6/Pa2m9m5Ormxb/Lw0QkzJUO4gxsUkeF0yL3HOCWRKnxqIT+gzHDI4kobIDjtIkQ6E+1wFo0vgzEdLTVpU= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 16/21] libs/guest: make a cpu policy compatible with older Xen versions Date: Tue, 23 Mar 2021 10:58:44 +0100 Message-ID: <20210323095849.37858-17-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0121.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3351dc00-b919-4c09-fab6-08d8ede29472 X-MS-TrafficTypeDiagnostic: DM6PR03MB4969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:843; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SZn8WarrbgJ2JOZZDmVG9Htb4IGDptJa+sGghFce0AKgoVqaDG/p1PODu42BFjHwaknI7cOmYg1+tqZFkMxYWtdIct1RKf4IKyorcXRtA5cyqReJjScsUHjNZM6c5ga9oWLgpr8GT49SkRsMMT8YO8g9gl/jQM7C+AjIHToe0WHSi6F9+w43BDRk35RvMq4p37HYPYCBQ/OX47zHSnXeL3F5viV07kYiWOr0taWbQmHXgNhDXXP+cbWxMEx6FTPqWR1F81oJCI3dR4erz2zeJsbZL/aGbK6hHvvoo/EPKMTL0DEFbVeKGWQ2lTXHvnSYjoxUB1+E/mkcKn7x2EIx8NQc2fRZBTS2BodtJ4ltUmULjaLu/6Ui+1x4NeiwfidDnODCcNUwW0TLNQsI0l3OLUVJotgEVZ5I2464PxSiXhrCflLtISt0Vv31TJgobkqSB5TApmO0J+PbFCp9NZ9gfzmAru/rqyjCc4xq/18aGypVJMzStrNJjcgWmmJZeQ0kRi/mOTGn5wZLfujIoe2saa7B1aliuuApyda/FrBqC8AwDZCvo19r65SJdorJBTeJxLE/0wePYulhnA+Ydrb6vrMKZ7ylrfC3VtkiCnQ1HRu2MnYiKUKt+Wp82Kb1nP3tSEUZReYbus3OYjVbcfwbCA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(54906003)(36756003)(2616005)(316002)(26005)(6486002)(956004)(16526019)(186003)(2906002)(86362001)(66556008)(6916009)(478600001)(5660300002)(8936002)(6496006)(38100700001)(83380400001)(6666004)(66476007)(8676002)(66946007)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Q3pUeEN3Zy82bTVkR0huaWtpQUVGRTUyUTdFUmhGQXl0R3pKVDA5RnhpMU0y?= =?utf-8?B?eG14RW5qdkZpOUFoOWdoNmI5d2tmcUd0T09PZi9qZVc1MkI0YnpRUHc4Ulds?= =?utf-8?B?MGV1SDFLSDR0UFYvMUIxTmo1a0RkcXNzZW9TN3Voa2tnSVFpek40dE16RjJq?= =?utf-8?B?WDB6NzFVbDZUZnNoOXJ2bFA2NmRVczhkZXJxUlJQV0NKTzB0SWpLdExwaGs4?= =?utf-8?B?c1I1eDZJVGlJODFxTGZZazlhZFltNGhZUlVERFRtZlRBZmJ6T0xTSllzeTRS?= =?utf-8?B?WHMrVW1ibUpDeTk0NHZVNTJpQ0s4RnJiUWZtZjg5M0V4cnlPSUFsS2FuNGZk?= =?utf-8?B?SVN3VVFnMzdtcnZUV1A4ckRqM1dXdlRLaHZDZTVPYlRPS29wZ0hnaWJ4T3JV?= =?utf-8?B?TmpqdDNZY0w0Ym1IVFpxRlFKRHRPNVZuR3gvcjFwRCtUVUpXU1Z2QXF5ejdq?= =?utf-8?B?bW0vYy84RkVwVXNvclgvWnRwNlUyS3pvN3NQek4wbndjSjU0S2UxSWwrV3NU?= =?utf-8?B?bmxXYjhwTzBsWHpZWmFZdHpJSGRId1dMUStOVlFqRWY2Mk9ySUZJWjFabGYx?= =?utf-8?B?akhyTDZIYjZtOW96S0puSUc4akJydnVjcWhRRUhGSHd0Y0N0dFB6TFNuL2JM?= =?utf-8?B?YlZWUGRHenIyM0Riak5USGZ5b2lTd2IzbW9wYm9Va3UzcDlwN215cWUxOSs3?= =?utf-8?B?WlZmT1k3cTFXNURKVzZ2TXlnRTExVy8raE5qR3dLbVBjc1N0ZEM3SElYdzFh?= =?utf-8?B?LzNMZ2ZUV0xmWGlMSlhkV3lUZDVNTVh5MVlxdFZmN0svRFhyWkIvZ3RFbE15?= =?utf-8?B?bFJ1SUhxTk9XN0hTeWdzYThwOGVKS2ovdVRSUGF0SzBlVWc4VXA1TGZpbHQv?= =?utf-8?B?Q0hOOUFjMFpRdlhPQmthRFAyaERlWTB5OUdRWG0raFd3R1NBQUR2YjhWL2hJ?= =?utf-8?B?WVhMRHgrVXUxd1VTVGZaZm1FSTRRVENLbjI2S3dUbWs2cVBXYjJWUEJsMFVn?= =?utf-8?B?VE15VFh2bS8rY08zODZoYkFuOG9PcjFkS21kNUFjRVN6SExRYjUyWWR6SzF2?= =?utf-8?B?U0VQT3VtZTN1eGU0WHpwb2JYcVNLWTBVUUxnY3grdml5amZmNWlKWi8xTmNw?= =?utf-8?B?S05SSlNHWVJBUEE5ZUw1WEdTc2F4SkNyTHVsQlBTWnEyZ1ZiOXhkQVpZSEhy?= =?utf-8?B?bFR1VHI1OFR4ak1hRmgzTTJxMHBvb0QyZHVlN3RzVFpBVTJxYjNXRWd3MXFv?= =?utf-8?B?T3h0QzVHY1ZYOXBHSEJwWEZVeUhHTENtaTJsOU50NlNtQUl6eFR0SFl2QlRa?= =?utf-8?B?djVWSXNJUmlwREIwaGZlbnlDNzhseDlqUWpqbi9KQmFNV2N2b1IzbHdtdm5a?= =?utf-8?B?SmkwQWtnbW5yNUt5SGFNRWg2Y1RaN1BYV0tkMnBjN2lLUi9UbDM2aHU2NzBB?= =?utf-8?B?ek1jQTZzZjFFM2xqUDk1MUJQUjlLLy9ZczVabmV2V0gyRDFwZTQzS29kK0g5?= =?utf-8?B?UjBueHpDRG5iLyt1RzNrdUloVGc5WFZRRG9BL3E2UmtBTlg3ZUVaYXo1ZW9Q?= =?utf-8?B?cFV1QmNYVW01RWJMV0xIVW9qVUExUHNyT2NEWDdBb1NVK0ZlZkRTMFBaZTVl?= =?utf-8?B?QWR3WDJVUTlqdGlsM1J4di9FZDkrL080TkhHYytJOCtGYUZkaUJmZSsvUXpw?= =?utf-8?B?aFFMWEVxVENKVkhlNHNNS01jTlJjMy8yNmY4Q1dLckpWOTI0MHBCblZyZVdD?= =?utf-8?Q?xo0JA8U+oPyRWXNupM4s24ssdXvbv7MeIn1yK9Z?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3351dc00-b919-4c09-fab6-08d8ede29472 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:01:08.3811 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: twU6gfn5Hvho/KdLgZ8bWKV3Yw1WtuR3KSkJrnBjiHz8SKr/USrMa599tCnDlhWY4U0ywECJCZ6jB60gGVN9lA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 X-OriginatorOrg: citrix.com Older Xen versions used to expose some CPUID bits which are no longer exposed by default. In order to keep a compatible behavior with guests migrated from versions of Xen that don't encode the CPUID data on the migration stream introduce a function that sets the same bits as older Xen versions. This is pulled out from xc_cpuid_apply_policy which already has this logic present. No functional change intended. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 4 ++++ tools/libs/guest/xg_cpuid_x86.c | 39 ++++++++++++++++++++++++++++----- 2 files changed, 37 insertions(+), 6 deletions(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 5f3e5e17e9d..6f7158156fa 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2627,6 +2627,10 @@ int xc_cpu_policy_calc_compatible(xc_interface *xch, const xc_cpu_policy_t p2, xc_cpu_policy_t out); +/* Make a policy compatible with previous Xen versions. */ +int xc_cpu_policy_make_compatible(xc_interface *xch, xc_cpu_policy_t policy, + bool hvm); + int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, uint32_t *nr_features, uint32_t *featureset); diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 4afca3249ba..2abaf400a2b 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -436,6 +436,7 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, unsigned int i, nr_leaves, nr_msrs; xen_cpuid_leaf_t *leaves = NULL; struct cpuid_policy *p = NULL; + struct cpu_policy policy = { }; uint32_t err_leaf = -1, err_subleaf = -1, err_msr = -1; uint32_t host_featureset[FEATURESET_NR_ENTRIES] = {}; uint32_t len = ARRAY_SIZE(host_featureset); @@ -504,12 +505,8 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, */ if ( restore ) { - p->basic.rdrand = test_bit(X86_FEATURE_RDRAND, host_featureset); - - if ( di.hvm ) - { - p->feat.mpx = test_bit(X86_FEATURE_MPX, host_featureset); - } + policy.cpuid = p; + xc_cpu_policy_make_compatible(xch, &policy, di.hvm); } if ( featureset ) @@ -1230,3 +1227,33 @@ int xc_cpu_policy_calc_compatible(xc_interface *xch, return rc; } + +int xc_cpu_policy_make_compatible(xc_interface *xch, xc_cpu_policy_t policy, + bool hvm) +{ + xc_cpu_policy_t host; + int rc; + + host = xc_cpu_policy_init(); + if ( !host ) + { + errno = ENOMEM; + return -1; + } + + rc = xc_cpu_policy_get_system(xch, XEN_SYSCTL_cpu_policy_host, host); + if ( rc ) + { + ERROR("Failed to get host policy"); + goto out; + } + + policy->cpuid->basic.rdrand = host->cpuid->basic.rdrand; + + if ( hvm ) + policy->cpuid->feat.mpx = host->cpuid->feat.mpx; + + out: + xc_cpu_policy_destroy(host); + return rc; +} -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:01:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:01:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100576.191761 (Exim 4.92) (envelope-from ) id 1lOdqm-0008UF-Vm; Tue, 23 Mar 2021 10:01:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100576.191761; Tue, 23 Mar 2021 10:01:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdqm-0008U6-RQ; Tue, 23 Mar 2021 10:01:24 +0000 Received: by outflank-mailman (input) for mailman id 100576; Tue, 23 Mar 2021 10:01:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdql-0008Eu-Gb for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:01:23 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 873b4118-5e5b-48cb-b00d-f294f73c1ab0; Tue, 23 Mar 2021 10:01:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 873b4118-5e5b-48cb-b00d-f294f73c1ab0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493681; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=JEqqKhCzXBW6qHbrKAeTor+WoqPsh+w4N7npvMDHYaI=; b=WBhVzkLvYIs4e6tV5pO1T6TYjgcWwTFwoIy7MttHoCr7PHWHHYD2HIx9 LRSAoN64cwujgd84Y8tNeBmet+j/oUSO5Q/IOYpqodWACwKZn31kYtcCn NiGM8SjicWUfeX4gIC6A5ku/S9lcQVQAzEevHWy4yliKfTi/m5xizMeqy 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: eu3bNrFhAMzJJjkq8gmzcFblaLfGCJMJg+infIysrEEoo28BuKZzRilD1DS3JTR84AReX5cXE8 XddaAdzKt3hVz0McTECm2ZWAt5T86bQqlNSEhJyXxxX7yGcPoEmyhiWLK2QjBmznJ+2V3/N0x1 WUYy2cVxhJ0O5XVfTIxDOss15MEQTi5gRSzwQ2C/yhoyYR9n9eZ7RU+v6W2kGsUMwoZhQIgeuP BYRpxGIAvut35IbbknRVnyT/OSFShGBBMvm6fZ7yegqXzvAhMp0RQLAEdLrGo6qNQMIb2yYJOX zyU= X-SBRS: 5.2 X-MesageID: 40055712 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Bfu7766UnB44deoPnwPXwS6EI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoex3h3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdBHW3tV2kZ 1te60WMrHNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2FXQotLhj0JbTqzOEtwWQVAGN4FD5 Ka/MVKvH6Nfn4QY8S9CBA+LpX+jvfMk4/rZgNDOg4/5GC1/EmVwZPZMzzd5BcRVDtT3awvmF KlryXV7riu2svLsyP0+HTU6/1t6b7c4/9iIODJtcQPMDXrjW+TFfVccpmPpio8ru3qyHtCqq i1nz4aM85+62zccwiOyHOHsWSQs0dNmgzf4GSVnGf5pojBTC86YvAx+75xSAfT6EYrobhHoc R29l+e3qAnaS/orWDW4tjFUAxSjUykoXYuuv57tQ0hbaIuLJBWtoAR50VTDdMpGz/78pkuFK 1UANjb/+s+SyLWU1np+k1UhPC8VHU6GRmLBmAEp8yuyjBT2FR01VERysAzlmoJnahNB6Vs1q DhCOBFhbtORsgZYeZWH+EaW/a6DWTLXFblLH+SCU6PLtBHB1v977rMpJkl7uCjf5IFiLEono 7abV9evWkuP2rzFMy12oFR+BylehTyYR3djuVlo7RpsLz1Q7TmdQeZTko1rsemq/IDRuLBXf KeP49XHu/DIWPiFZ0h5Xy8Z7BibV0lFOEFsNcyXFyD5ujRLJfxi+DdePHPYJrheAxUGF/XMz 8mZnzeNc9A5kekVjvTmx7KQU7gfUT54NZVGKje9O4D9ZgVOuR3w00ooGX8wvvOBSxJs6Qwck c7CqjgiLmHqW6/+nuNyGl1JBxHDAJw7K/7W31H4S8GWnmEPooripG6QyR/zXGHLhhwQ4f9Cw hEvWl6/qqxMti33iAtC9WuN0qAlHsNrHe2T5MR85fzpfvNS9cdNNILSaZxHQLEG1heggBxsl pObwcCWwviDD/0sL6ki5YVHenbUNF5jG6QUIppgEOakX/ZidAkR3MdUTLrdcKMmw4hSwBZgU BL/7YFjKCNniuuLmUDkP01WWc8GFi/MfZjNkCodY9UkrfkdEVLQWCGiSezpjszdmDpnn9izl DJHGmxQ7XmE1BdsndX3uLW61tybHyaZF81QGt9q5dBGWPPvWtT3eeHarGo6XaYbkIPz4gmQX b4SApXBjkr68G81RaTljrHKG4vwY82OPfBSJskaLPe1xqWWfq1vJBDO8UR2plrNNrj6LBWFc 2efhKYNzP+BacC3RePqnMsJSlzrz0FnJrTqWjYxVn9+ER6J/zYZGlCbfU8Bfq36mD/XfaG0J ljl7sOzKKNG1S0TuTD8L3daj5IFwjarmG3Rdw5sJw8h9NBiJJDW73gFQbS3H5J3B8CPN75uU MXTqN8+q3AMOZUDrgvUhMc2lIokdiVRXFbyTDeM6sbfVs3iWXcMM7My73UqaA3Cknpnnq6BX Cvtwlc9ezCRS2NyPozDL8xO31fbAwZ5G559O2PM63WBwPCTZAIwHOKdlu8eqRaUq6LBPE5qQ t7+ciBm6uvTBXDsTqgywdTE+Zp6GaoQcS7HQKKF6ppyrWBSCixq5rvxtWygjfxQSa8cGICi+ R+BAotUvg= X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="40055712" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k3b7VeRfzxsoTUrd7vG+Q17Zx9YfiV9BpQ7pPbXCP4vDt8XnEsOElHohp7yEzd3fuEj7W7DRzMGV/V1cXUsXTUR7hJb7WwowBTb/XsD5+tdx+E/oDdav9hfzM/9jISpHURvregdy7G6tJDYzuypi3GOG+kZxpVUCaDgqSxm4LI6Ha1/Pt8dlODlRlQnEDkDcJ6cnIzBRBWwBVreYrHimLGJMUCD1dBFGb1EtKAeqpfk8HerLuzmT2AeoeV4dvjpMAgMrqLuq38c7gnS+aXyrkQATVe3F6PuoFfrFS3TbTb5gEiIlh1MUarVdQKmYwjavUkUL+fMiHg96rVnernYihQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mdRb+QnYrgGEQMcTps13tpcI68Xa9umSiWj/KPzruTk=; b=brRQTwPON1m8Ujab8hR8nUPJFI2C8FyGsLEw+6y203/3iRen+tx4jRApEoqjwp2Zrz9gqFcupmndqE1m2CyBTgLPOwGygL8Tjq88tCmkl27MS6YH6qNOhSxt4Fk4Q0cwtapjFuBP0UqXMsfo1CetOef9a22fZN1Wlq9OnHzLOeNjbcMwZGO5vVrLfXWijWrA46m9d/BgRvheVVUea/MUYAnlWbbn7oQp/HDCKEpIDcRcW8Lx5V+PjiCLjttIX/CeeRagJdKsDw6VhWjwcSGOSW4Fi5d4BxdS+h5zIqqk2QToZZSJaafuenq8uyk6psr9OHSQ8w8sJkcJl+RXyVgS4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mdRb+QnYrgGEQMcTps13tpcI68Xa9umSiWj/KPzruTk=; b=TEamV24AxFsN6mVgb7Ilv25t/118jfiXh7qsyQFue39tdsCatpy+BbjQ9ED5JgmNbNlly8JXYdeFKkTUvI7d2Y46u6xcsVeY6U6ARvh6NzBEyXp143kpolxe4ryobCqqp3hOITH3vQ4kaAwgVoj+AhMxhy5Y2LSkWhqCto5T4Wo= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 18/21] libs/guest: rework xc_cpuid_xend_policy Date: Tue, 23 Mar 2021 10:58:46 +0100 Message-ID: <20210323095849.37858-19-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0132.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::24) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: add2c9df-e090-4a3a-1405-08d8ede29a33 X-MS-TrafficTypeDiagnostic: DM6PR03MB4969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:64; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AR3kC9/MOD/EPz9y/NVMDmkgwehbXsWhbdGVVLSpxBILgRanA88HcA8m6p9RyuKS/1BhVYFai5HZciz6py+lVUB/n1y8b62VRcwZgFYE1EX9nU1CZdPZP70d01NRsuSTNMLtdfScyqJQNHv8dSgsH0piu/z/gZiVMN4rx0lGc5lYmbSsbLb/l9ZQ+xEtoSbsESXIZ5rrW856Pa29eAdY4M2AhxGPU91WbPOLU9C8iS0vSiIoyyfInMlfr+5FxrzLS6b6iOHCwUb+AJ55XGpwNYDIgOkIJRaPcPuzyp7I/dzo+uh6OaUpyYW4keq8va/memRRPvxdUlEDDWhLNB65PpcFyIMmCdn+G52yHvGn8k6A+eF1AbH4LzjYe7zMKXtYOy6TIBjj7z1L7y8K6ze4L9B65JG40OVF+SHcIjxza9J2nP4z5PrlNPXhkl3ww2VnD58AR8RRQrYLU37K7RZKlBxv3se14ByUXG+gg5Ij2bupOqGUNjmNYbcGrcgipeAxeyZFdArXTBNB31OxdYz1rsreNQY1ayU8kLVFZHiI6m1EVvoD98JA3p5CYXJQ6OgATyOOj1RVoT2JX0J21uXX+PBjuXscooeyqu8tb1Ph6YPChBvDRd2ruADmbzTq3iskKBIcgVGAbu9lZyAYRn42eg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(54906003)(36756003)(2616005)(316002)(26005)(6486002)(956004)(16526019)(186003)(2906002)(86362001)(66556008)(6916009)(478600001)(5660300002)(8936002)(6496006)(38100700001)(83380400001)(6666004)(66476007)(8676002)(66946007)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bXIvNGFXUEhBV2RISGZTQnFJS0JPdjk0UWg2T09Bb3pXTnpMVmxOM25zQlc5?= =?utf-8?B?OHMzT2UwMkpBR0NGZUN0WjVUY1V5bWM2OEJ0RFhVcmI3NU04SUJXRHd2QjhL?= =?utf-8?B?dmlIdFJodmhMc0lrbUl0c3NsZUtQdjhsMDNlV25wOWZ2KzdnU3Y5UFhrSUlt?= =?utf-8?B?Ym4zb2RxLzY1UEZNT0oxYk15RWU0b0M1Z0dnSnJRWEJUOFo1UWlVdTZGcGZl?= =?utf-8?B?UitVbWZFVHdTZzRaczc5WWsyMFZmeFBIdzZ6UXR3R0VwaTh3V2k0VVB3c0RR?= =?utf-8?B?Y1IwamtFaXNQcjhwVHY4M1JxZURodStvdmxVb1lJT0VZMUxTZlI1dTZ3Zk50?= =?utf-8?B?TXFrS0JORTFiQzFweGV2ZDFJODR4aENRNEI2V29ZQzZpbjF2L0lXbHlXTUVO?= =?utf-8?B?dTlwNEdhZDRkZWw2eDBDSFNkcDdnTHJtQVJDaTlEd1R2VVZEcURndGM0OVhW?= =?utf-8?B?WFUwa1dsVmwyMjd4aWc2VG9MaEE5Zm9FNjNTTnVtOG91dUt3bG1TU2lwaDBE?= =?utf-8?B?RGpsUUpDVEpxQW1IT0s2YkZkNlpwNHJyalZwSjZLZUFHVlVabzJoSU9kS3kx?= =?utf-8?B?Uk4yQUptVERwY0Nhd2VnelZHV1dQYkx4aTRWeG9vUkwzNDNtekx0bnBQeXk1?= =?utf-8?B?bjVMSlQvUEJDSkdDRUVOTjRLaWZHUzEyQ3dVd3liT2RQSnNCL3pzaUJqcGRS?= =?utf-8?B?RWFmWFhqQ0l0M245UDlLY2hqa2V4bS9EY05LQUcwUjFrQldBTGpTSUdJMTJ6?= =?utf-8?B?SGo4eGFOc1M4Rk53V0hCQS9jSXpOZTJIMGYrazJEU2RMa1dRTHE1VWQzZnc1?= =?utf-8?B?K2YrUy9tQ3VuMkN4aVdVQ1Fwbko1bStkMHA0RHhlM0ZCbm1SWTBQVmlDZHk5?= =?utf-8?B?UTFQYWI4eXl4SXMvUE9VeHgyMFVRS1FzTmZWanJvWUxRMlU5b3VhaWxsdjV2?= =?utf-8?B?S1QxVFVrK2NsQUhFVDhYOEJBWm1xVlZxT2ZmUG1KcHVFYllrQWlJUXgzQjJQ?= =?utf-8?B?TytSTkd0dnhXSEN3MG1MWm1jczBvN1N3TGpWTGJFMTdCcWJ3dCs3dER3aStH?= =?utf-8?B?Wml1dU9SU2NDQ2V5MUx4d3BBblI4bnY1WnFGWXRQbmFiUkl1K1NIak1sY2o4?= =?utf-8?B?cXdiS0hiSnBhUVhNUlZlZUdLYTNGUnpFVzZmUlN4VGlJS1JjMHZ3dW1RWXZD?= =?utf-8?B?dEdDWGZpOFhlcG9tSHpjdEJQbjJaRlNQSHdrdkc0REFmSDVzVncvQ1d6bFdW?= =?utf-8?B?SW5PZUZQaWdLRFFhTkJjdjZpNk5SbVIrVllML3hmb3dEMVlyY3NsVHlrYktq?= =?utf-8?B?NEg1RjdUTXFleTFHRjBIWlRKWklyOWlSQkJGU29KRnI0SzgvYmZUMFd6OE5T?= =?utf-8?B?OFNQUDh0WFhhUDlZRElxYlJEbVgxa3VHb0hLTWFzOFBmbU1nQ2I1NGFpMDc0?= =?utf-8?B?YXpOSXYrKzRvdmhJVDY0SnpldEVLdHFUZ3ZQVElpaWJ5TVRDYnZ1ZHh3T0J0?= =?utf-8?B?Q2NkN0RveGRqNWFYQVl6bWh1MCtTZWxiM24xU3ViUkcxUDVneTlycW43eS9J?= =?utf-8?B?WWF1eXlNbjA1UTFuRkhaM1RJYWNQVmhjVWJCUU8vRlVxQ3Q2eDlwbVlsVk9s?= =?utf-8?B?bldnc1ZFLytrMElSTkFBSDM4amZka01PdDdyYkZHKzZjSUtEZ1NsVkNZS1dv?= =?utf-8?B?NGRZTndYSjRCRGxQU1VOK2dMUlQwd09mcXFQYS9EOSt0K2NISDRPUWxtbFhk?= =?utf-8?Q?pT0yAbi+hiJqXyTAgqYHWIxrvh3+OzOhDJTpp3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: add2c9df-e090-4a3a-1405-08d8ede29a33 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:01:17.9331 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jdOA5dJOU6dijJhJu44CdG1YZI4IqWwIKBg8CFvvLnZJtFOnSvbVkVDLdiZEuouprC6gSonI2w7gxqaZ+RBoMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 X-OriginatorOrg: citrix.com Rename xc_cpuid_xend_policy to xc_cpu_policy_apply_cpuid and make it public. Modify the function internally to use the new xc_cpu_policy_* set of functions. Also don't apply the passed policy to a domain directly, and instead modify the provided xc_cpu_policy_t. The caller will be responsible of applying the modified cpu policy to the domain. Note that further patches will end up removing this function, since the parsing of a cpu policy in xend format is a layering violation, now the callers should have the necessary helpers to modify an xc_cpu_policy_t themselves. No functional change intended. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 4 + tools/libs/guest/xg_cpuid_x86.c | 200 +++++++++++++------------------- 2 files changed, 83 insertions(+), 121 deletions(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 9f94e61523e..07b8bfc08aa 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2635,6 +2635,10 @@ int xc_cpu_policy_make_compatible(xc_interface *xch, xc_cpu_policy_t policy, int xc_cpu_policy_topology(xc_interface *xch, xc_cpu_policy_t policy, bool hvm); +/* Apply an xc_xend_cpuid object to the policy. */ +int xc_cpu_policy_apply_cpuid(xc_interface *xch, xc_cpu_policy_t policy, + const struct xc_xend_cpuid *cpuid, bool hvm); + int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, uint32_t *nr_features, uint32_t *featureset); diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index d50822c0abb..ce4a4a1a436 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -258,144 +258,107 @@ static int set_domain_cpu_policy(xc_interface *xch, uint32_t domid, return ret; } -static int compare_leaves(const void *l, const void *r) -{ - const xen_cpuid_leaf_t *lhs = l; - const xen_cpuid_leaf_t *rhs = r; - - if ( lhs->leaf != rhs->leaf ) - return lhs->leaf < rhs->leaf ? -1 : 1; - - if ( lhs->subleaf != rhs->subleaf ) - return lhs->subleaf < rhs->subleaf ? -1 : 1; - - return 0; -} - -static xen_cpuid_leaf_t *find_leaf( - xen_cpuid_leaf_t *leaves, unsigned int nr_leaves, - const struct xc_xend_cpuid *xend) -{ - const xen_cpuid_leaf_t key = { xend->leaf, xend->subleaf }; - - return bsearch(&key, leaves, nr_leaves, sizeof(*leaves), compare_leaves); -} - -static int xc_cpuid_xend_policy( - xc_interface *xch, uint32_t domid, const struct xc_xend_cpuid *xend) +int xc_cpu_policy_apply_cpuid(xc_interface *xch, xc_cpu_policy_t policy, + const struct xc_xend_cpuid *cpuid, bool hvm) { int rc; - xc_dominfo_t di; - unsigned int nr_leaves, nr_msrs; - uint32_t err_leaf = -1, err_subleaf = -1, err_msr = -1; - /* - * Three full policies. The host, domain max, and domain current for the - * domain type. - */ - xen_cpuid_leaf_t *host = NULL, *max = NULL, *cur = NULL; - unsigned int nr_host, nr_max, nr_cur; + xc_cpu_policy_t host = NULL, max = NULL; - if ( xc_domain_getinfo(xch, domid, 1, &di) != 1 || - di.domid != domid ) - { - ERROR("Failed to obtain d%d info", domid); - rc = -ESRCH; - goto fail; - } - - rc = xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs); - if ( rc ) - { - PERROR("Failed to obtain policy info size"); - rc = -errno; - goto fail; - } - - rc = -ENOMEM; - if ( (host = calloc(nr_leaves, sizeof(*host))) == NULL || - (max = calloc(nr_leaves, sizeof(*max))) == NULL || - (cur = calloc(nr_leaves, sizeof(*cur))) == NULL ) - { - ERROR("Unable to allocate memory for %u CPUID leaves", nr_leaves); - goto fail; - } - - /* Get the domain's current policy. */ - nr_msrs = 0; - nr_cur = nr_leaves; - rc = get_domain_cpu_policy(xch, domid, &nr_cur, cur, &nr_msrs, NULL); - if ( rc ) + host = xc_cpu_policy_init(); + max = xc_cpu_policy_init(); + if ( !host || !max ) { - PERROR("Failed to obtain d%d current policy", domid); - rc = -errno; - goto fail; + PERROR("Failed to init policies"); + rc = -ENOMEM; + goto out; } /* Get the domain's max policy. */ - nr_msrs = 0; - nr_max = nr_leaves; - rc = get_system_cpu_policy(xch, di.hvm ? XEN_SYSCTL_cpu_policy_hvm_max + rc = xc_cpu_policy_get_system(xch, hvm ? XEN_SYSCTL_cpu_policy_hvm_max : XEN_SYSCTL_cpu_policy_pv_max, - &nr_max, max, &nr_msrs, NULL); + max); if ( rc ) { - PERROR("Failed to obtain %s max policy", di.hvm ? "hvm" : "pv"); - rc = -errno; - goto fail; + PERROR("Failed to obtain %s max policy", hvm ? "hvm" : "pv"); + goto out; } /* Get the host policy. */ - nr_msrs = 0; - nr_host = nr_leaves; - rc = get_system_cpu_policy(xch, XEN_SYSCTL_cpu_policy_host, - &nr_host, host, &nr_msrs, NULL); + rc = xc_cpu_policy_get_system(xch, XEN_SYSCTL_cpu_policy_host, host); if ( rc ) { PERROR("Failed to obtain host policy"); - rc = -errno; - goto fail; + goto out; } rc = -EINVAL; - for ( ; xend->leaf != XEN_CPUID_INPUT_UNUSED; ++xend ) + for ( ; cpuid->leaf != XEN_CPUID_INPUT_UNUSED; ++cpuid ) { - xen_cpuid_leaf_t *cur_leaf = find_leaf(cur, nr_cur, xend); - const xen_cpuid_leaf_t *max_leaf = find_leaf(max, nr_max, xend); - const xen_cpuid_leaf_t *host_leaf = find_leaf(host, nr_host, xend); + xen_cpuid_leaf_t cur_leaf; + xen_cpuid_leaf_t max_leaf; + xen_cpuid_leaf_t host_leaf; - if ( cur_leaf == NULL || max_leaf == NULL || host_leaf == NULL ) + rc = xc_cpu_policy_get_cpuid(xch, policy, cpuid->leaf, cpuid->subleaf, + &cur_leaf); + if ( rc ) + { + ERROR("Failed to get current policy leaf %#x subleaf %#x", + cpuid->leaf, cpuid->subleaf); + goto out; + } + rc = xc_cpu_policy_get_cpuid(xch, max, cpuid->leaf, cpuid->subleaf, + &max_leaf); + if ( rc ) { - ERROR("Missing leaf %#x, subleaf %#x", xend->leaf, xend->subleaf); - goto fail; + ERROR("Failed to get max policy leaf %#x subleaf %#x", + cpuid->leaf, cpuid->subleaf); + goto out; + } + rc = xc_cpu_policy_get_cpuid(xch, host, cpuid->leaf, cpuid->subleaf, + &host_leaf); + if ( rc ) + { + ERROR("Failed to get host policy leaf %#x subleaf %#x", + cpuid->leaf, cpuid->subleaf); + goto out; } - for ( unsigned int i = 0; i < ARRAY_SIZE(xend->policy); i++ ) + for ( unsigned int i = 0; i < ARRAY_SIZE(cpuid->policy); i++ ) { - uint32_t *cur_reg = &cur_leaf->a + i; - const uint32_t *max_reg = &max_leaf->a + i; - const uint32_t *host_reg = &host_leaf->a + i; + uint32_t *cur_reg = &cur_leaf.a + i; + const uint32_t *max_reg = &max_leaf.a + i; + const uint32_t *host_reg = &host_leaf.a + i; - if ( xend->policy[i] == NULL ) + if ( cpuid->policy[i] == NULL ) continue; for ( unsigned int j = 0; j < 32; j++ ) { bool val; - if ( xend->policy[i][j] == '1' ) + switch ( cpuid->policy[i][j] ) + { + case '1': val = true; - else if ( xend->policy[i][j] == '0' ) + break; + + case '0': val = false; - else if ( xend->policy[i][j] == 'x' ) + break; + + case 'x': val = test_bit(31 - j, max_reg); - else if ( xend->policy[i][j] == 'k' || - xend->policy[i][j] == 's' ) + break; + + case 'k': + case 's': val = test_bit(31 - j, host_reg); - else - { + break; + + default: ERROR("Bad character '%c' in policy[%d] string '%s'", - xend->policy[i][j], i, xend->policy[i]); - goto fail; + cpuid->policy[i][j], i, cpuid->policy[i]); + goto out; } clear_bit(31 - j, cur_reg); @@ -403,25 +366,19 @@ static int xc_cpuid_xend_policy( set_bit(31 - j, cur_reg); } } - } - /* Feed the transformed currrent policy back up to Xen. */ - rc = set_domain_cpu_policy(xch, domid, nr_cur, cur, 0, NULL, - &err_leaf, &err_subleaf, &err_msr); - if ( rc ) - { - PERROR("Failed to set d%d's policy (err leaf %#x, subleaf %#x, msr %#x)", - domid, err_leaf, err_subleaf, err_msr); - rc = -errno; - goto fail; + rc = xc_cpu_policy_update_cpuid(xch, policy, &cur_leaf, 1); + if ( rc ) + { + PERROR("Failed to set policy leaf %#x subleaf %#x", + cpuid->leaf, cpuid->subleaf); + goto out; + } } - /* Success! */ - - fail: - free(cur); - free(max); - free(host); + out: + xc_cpu_policy_destroy(max); + xc_cpu_policy_destroy(host); return rc; } @@ -429,7 +386,7 @@ static int xc_cpuid_xend_policy( int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, const uint32_t *featureset, unsigned int nr_features, bool pae, bool itsc, bool nested_virt, - const struct xc_xend_cpuid *xend) + const struct xc_xend_cpuid *cpuid) { int rc; xc_dominfo_t di; @@ -551,6 +508,10 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, if ( rc ) goto out; + rc = xc_cpu_policy_apply_cpuid(xch, &policy, cpuid, di.hvm); + if ( rc ) + goto out; + rc = x86_cpuid_copy_to_buffer(p, leaves, &nr_leaves); if ( rc ) { @@ -568,9 +529,6 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, goto out; } - if ( xend && (rc = xc_cpuid_xend_policy(xch, domid, xend)) ) - goto out; - rc = 0; out: -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:07:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:07:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100582.191773 (Exim 4.92) (envelope-from ) id 1lOdwo-0000db-QO; Tue, 23 Mar 2021 10:07:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100582.191773; Tue, 23 Mar 2021 10:07:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdwo-0000dU-NP; Tue, 23 Mar 2021 10:07:38 +0000 Received: by outflank-mailman (input) for mailman id 100582; Tue, 23 Mar 2021 10:07:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdr9-0006c2-1B for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:01:47 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cce34c28-814a-474a-b18c-56b37af096c9; Tue, 23 Mar 2021 10:01:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cce34c28-814a-474a-b18c-56b37af096c9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493697; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=elgicdoLLjyAPG6mTxXmUlhWyWbTk4KjmQet+vnO69Q=; b=DZkitnqXKuZBiIC1A9HeW2mmWTxmekPiKQcU0Ii+3ainK8Rf2ygpK0Dh bqPLZaFZpnb6i8ltZagZGa/B5yxzQ5f6QuY4B+tGbjcelmW3fZje9HoDl Ck92fAWWsbMUyArW7W/hAEnMnYyn0yA7zm4mXm8nYpOlcZvJaS29ha7Hv A=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: DK49BHw+0b9sC4ZyTccq2A1VcLd2uJ38RZw+M7GYiGZWsQJZrYU9+IQlTPLx93pQg4SHNHvmYi ZhSrtiQTEnTAaPluhln1G1WFLXrChiT9uKmInCdIsgQW2FP84COtMeVuQBE2hwPz35GlfueSfQ KHrcem9qGl83v0RKMmjKMMH8pT5RBiNY+1uWBC2j/TkeP2RALVafPd1C0x32ljqJVeet9f4GIN mZDLQz4n1rZ+G/5RWYriaBG+ubMhziy3HU4PlWoDzpHVFFuMrVYxZ0/GRh65b42DXnyIh/zh5v e34= X-SBRS: 5.2 X-MesageID: 39900444 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:oW3gKaFSjQIIjIkOpLqFbZTXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7Lk/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeNJwTXzcQY76 tpdsFFZeHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLD1CQYsI1XYcNi+wFEpqSA5aQacjHJ 2H6cZd4xamc3IbbsO0b0N1I9TrjdvNiZ7gfFo6FwcqgTP+8A+AxZzbN1yj3hkYWy5S2rtKyw b4uiHw+6nLiYDc9jbyzGnWhq4m+ufJ6twGP8CUj9hQFzOEsHfSWK1Ee5mv+A84u/uu7lFCqq i9nz4FM95o433cOkGZyCGdojXI6zol53/8xVLwuxKKyqaYNVFKefZpvo5XfgDU7EAtprhHod h29lmUqoZNClf4lDn9juK4Ji1CrFa+onYpjIco/htieLYZAYUhyLA3zQd+FZcNGz/C84Y3EO ViJ9G03ocpTXqqK1/epWVh29qqQzAaGQqHWFELvoiv3yFRh20R9TpV+OUv2lM7sL4tQZhN4O rJdoxuibF1V8cTKYZwHv0IT8ebAnHEKCi8f166EBDCLuUqKnjNo5n47PEe/+exYqEFy5M0hd DoTE5YnXRaQTOvNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dQWeVVEVlde6qfl3OLybZ9 +DfLZtR9PzJ2rnHohEmyfkXYNJFHUYWMoJ/vkhXVajpd/KN53KuuTXfO27HsuuLR8UHkfERl cTVjn6I8tNqmqxXGXjvRTXU3TxPmzzlKgAVZTyzqw28swgJ4dMug8ahRCS/ceQMwBPtaQwYQ 9bKLPjmaWrmHmu8Q/zniFUEysYKnwQzKTrUntMqwNPGVjza6w/t9KWfn0X+3ebOBllTYfzHB REr1p6vYK7RqbgixwKOpaCCCa3nnETrHWFQ9M3gauY//rofZs+E9IBQ6x+FQLCEjRvggZ0oG J/aAsJL3WvVQ/GuOGAttg5Fevff95zjEOAOshPs0/Ssk2auIUSXHcBZiWvVsSWmA4qYDJRij RKgugiqYvFvQzqBXo0gew+PlEJTGiMGrpJAD6IY5hulqnxdBt9SnqLgjKmmwg+E1CahHk6ty jEF2m5aPvLCl1StjRj3qHm/EhdW0+dc0hzA0oK+rFVJCDjgDJewOWLbq283y+tcVME2PgaKy yASyAVOBlSy9e+0wO1lD6OGW49/IgnOvXQAd0YAvfu80LoDLfNubANHvdS8pogCcvntfUTV/ mDPyCSNzH1BooSqnqoj0dgHBMxjnYqkfnlgkK4qEe52WMyGvrULhBNQaoBL9SV8mjjQLKp3f xC/KYIlNr1Fl+0TNiMjZzzRXpkDDj4pGatVeEmqZxOp8sJxfNONqiedQGN7W1N2RU1Edz9m0 wfSplq+bypAP4bQ+UiPwZiumcznNuBLEEXohX7L+83c1YqlWLaNbqyks31gItqJkWAoQfqUG PvixF1zrPgXyGZ06QdBL91CWNKaFIk4HAKxpLJS6TgTCGrffpE5ly0LzuUd6JcUrGMHfE1og xh69+F28+ReCyQ4nGcgRJLZoZP+X2gW8W8HUalHvNJ6cWzPRC0uZSRifTDxQvfeH+ccEQXhY pMaEwWYIBis1AZ/fIK+xn3bLf2rEIjm0ZZ+hd9mDfWq9Gb3Fs= X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="39900444" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AOKtNw58QdCQiPzStDBaWTYixloQZO3WhTzwSha0l2L+yqOqK7eLXwMClH/Sc8yoJrGlyOTL8skRLJlEswRFCVsX2cc+UkpHJNzGH7q+bMDspwMUCDrzkDLOHB1uoVdTPJxUPc3R7Z11D7bAaRJTzZ3ltCbmXsaVLWz/EF2WLOlu/YXLHYju71SF2LYfAsASq/6Tcdsj9uoEVspyX4HNxy0COdZeuKteDEuLN3XSO8oLLZzFgQniRPpnmFX4XYUX2CnlVtLHnE9YXZqhqxqA2DFmvudPO/kqroggalKwczInL7sffFEmNH4gHjyNP4ubfWTbekqm/IhhXBVLk16MkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/sAstwZ3FZzzgYovYIPvWV/JpZRMk/Un8JhdEN4a52A=; b=I+LsnmI+QZuBTFfTCX1N51EhE8BeG0Ap/QAf/GtoYaY3g8XKKGbJZNCccGcpvhe0I1GU1EsVYZfLMD5AOpCZOT6nAkcfQ2DZ/doWubd5bGKU/CuJJJgAfh9JIrMEaK5eWPNEOUEVUNGjnEhkHKMvRBlu3d3QP2qrRdJGvM8JMC1SE/bEVk634mag7Y8QcY+hc7ee//pTz26/I4jDmlpG/PVOed388hsBi81dTGJ1Zq4q9dHNE68aQojhB0FXT9wTGRcthDZg7k0iaL9O7VfAh0Qpbhv1aXzDQz+cVtDngWZjMNpI1oHd0P7lN+WxkKxqs8RbZ7e4xQK1s/b8xz+ffg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/sAstwZ3FZzzgYovYIPvWV/JpZRMk/Un8JhdEN4a52A=; b=Ajs2cmCZbeBkD9V2vWhH4FMyo1DhToX0513zehcMUlAFgQrhqn3Ot5UUs/BD06FbwQ7VHH4WoRdiM3OGp9QaHhv6DVmkbcX8C0qMPOieZzdWZARkzga+TrHWd+oFKQQZrt5TM4QOsCCuLuwpLXSiMQxPMORYxcH81WZctuhaMzU= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 19/21] libs/guest: apply a featureset into a cpu policy Date: Tue, 23 Mar 2021 10:58:47 +0100 Message-ID: <20210323095849.37858-20-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0126.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d14b9d14-0391-40b2-09f2-08d8ede29d6f X-MS-TrafficTypeDiagnostic: DM6PR03MB4969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RTkijCKJ1KFTtE8o9PKnBhvssfJyfO7/cpwRLa5J8yvfBPQ8YkqZ+o/2AxWZuFoIGu3KajxME3ooQj7kAcbgEXS2hxjMl3PtghpU4ExZgYYSWTauTjdYTxF5rwwgoS16pSv9Wvu9qvU6N1ltDVNnXIbspBV5AiEfWwTrVI6tWF1xq9khhK7mtUZVXwTRiCl0ObmzxS5wnxc8pmRbO7KZuG/GhHUqsV5dmxEVNCy27rBukBNA44nDJSc3B3dcJSrG2sLr/Zv5awdKZL+Zr3mMWDF+rRXWZkTHDR6Amky2FjKZP6eSoOkAfTxFNGVBqenYxuUWFdy9QNqkAIOSY4L2OUv6Xl97EIg1+cx/PPE+qaM+nKOGM6MSmEx43TuunzBmyAFVw+a9uKGD8sZjBDCe9iw9h08RBI6AoO6eGw2kxgArm1FjWJRh8WmtVES/B8pCChEOIEmnqRAOrLgpN2naIKtJYBgmV84qJwo35a8mAnT3DQySZBqyHPsNBw+6g112DO7cwrZb3ATLF757aSm5K2ZtqV5EgVtTf4OLOmif3J+IX0s296Ie7ja4w1TFf6faEwRE5bq3FHREUKToVRSFUQSZdS3c+HByjSTNJO8GDPX5EWrird9jrasJh2ocSVUVTsSqi3EgrNh7SjzXJpRtmw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(54906003)(36756003)(2616005)(316002)(26005)(6486002)(956004)(16526019)(186003)(2906002)(86362001)(66556008)(6916009)(478600001)(5660300002)(8936002)(6496006)(38100700001)(83380400001)(6666004)(66476007)(8676002)(66946007)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bEtNMytaYWY0bUdLbXUrUWZzRk4rQXFzeVNGcHFYcEtyYXBNSXY0U3pQWmU5?= =?utf-8?B?MWdLOXdwSEhjUFdFbkFxTnlUdjFFclNldmhVWUpVSStaRXdtdmQ1VjNuRjVm?= =?utf-8?B?VENSclBRUm5ZOFhtOUZFWlkzZXpOSFpHcW9LaWhxanVjZFlTQkV0bnB5RW1N?= =?utf-8?B?TDRVQ1dLbFkyV0orNVZwTmRmbHAzUy9NS3FsSVhXb2VlVXV0YlNCaEt4OEZL?= =?utf-8?B?T0ZZUkhCUzlhZ04ySzJORjVnM0VDbkJHaTJ6NFlRSzJMTWlaRTJzNnJOOHhD?= =?utf-8?B?UHVKR09Gay9mOGdZQzF6eEJCdjFudHFQOFR2THlXY1NYTThNOVYwNlQzdjJz?= =?utf-8?B?NURxRVpWWGFwV2NVeVA3ajFxZHJWZzlPTGVPS21TNWVxbUpGNXAvblRGaHhV?= =?utf-8?B?eEpJYXJYSUlUemJzNk40U3c3a3VjNFhONEpHem9hWU80R3lUSW05cFZHUWo3?= =?utf-8?B?VDRkL2NmUlJseTFCeGdLVzhoczkvZFpNWndzOFh5ZTI1YlBIMFdYSlp2SnZz?= =?utf-8?B?Tjc1V01sQzQ1RU4zN291ZHhhbkJUSjVtUkFWSlIxMTNQdVFtb2ZqWmlwSEdv?= =?utf-8?B?MnlqOEV1N0NCaDNFbnA4cjB5ZGhvWFo2RnV6V20yQ3llcmVDeHd5ZlhsSjZC?= =?utf-8?B?MkF2WTZNMDlheVRDZXprbXI5UW9YZ2tyS1QwYklNRFczSlRnUFg5OFVLaWl1?= =?utf-8?B?bElZNWhuQnp3OGJ2SnpSdGg1SjdKNmEwYkxVMTRJUW5EMjVqMURnNEhtbFhO?= =?utf-8?B?cXcyY3ZjeG5UeVNjVjNrbjBXdnpIU0Jub0pWcXY4ZXgxa2htbFJ6KzkrV1RL?= =?utf-8?B?ZWRWcGI1WWxlRDFWWmJiS0tET1FGVk1Ibnh1aUhJRzcyQXNmUVkyZlIzL1Mx?= =?utf-8?B?dVA2RmIvOFd3NmFTenFyUjZZSW91eERNdDVXRXFFTE0xMFYrdE5HMElDdldn?= =?utf-8?B?OHpYQnBvd3VKdFo0UERsc0l0Unh6bmQreUxpVVJMditKaHhrbmswekNUZitz?= =?utf-8?B?VXNoVHFVU3I0MWN0ZE5LVU43bmllQm1NR3AraGNLelJOdUVPSmc5czdwZzFG?= =?utf-8?B?eEREcDZHZG0xV2tVcmQxOEViNlV1MVpubW1LN1pzR1oxK2NSck1iWE9sc3ln?= =?utf-8?B?V21OZ0FudnFub3FydW1IT3lIeW0xdlhoMEVqQ1V6VVpyN0V3bHQ0MjJGQnE1?= =?utf-8?B?QzFNdTRZZWRvUFl2WWVjeS9oT25KbENSdjlUTVE3dmRPUVVOR0dST0FlVGZO?= =?utf-8?B?VkFtMjJ0SXQwNk8wYUJFdHpDbnFhTDlUM2YxcnhmQ2dubFV1L3Fwc0pVU1FE?= =?utf-8?B?SzE5eGg2d2pZMnhZbGlHRFZVMFVRYUpQRkpKeUlGa09zTzNtVnJpVmtIM1BF?= =?utf-8?B?bHdkSDkvSCtDWk5yKzlFSkNVWjh4SW5zUTlHOGF5d3hDUXNPbTFwbWMwNUhN?= =?utf-8?B?eTVXYnJrb1kvVExzWWg1dnhKR1BZV2pYeDcxbFUvT0hjcm9Mc004OTJSSTE2?= =?utf-8?B?V1hPUnFvNHdMcGFIMTZiQisvSVQyR1pXOGE5QWFHZmdQQmlGQ0ZZWjhONEQw?= =?utf-8?B?cGpOTUwycFo5SHdjY0NXLzZub294THYxc0drYXl2bmN0YW9kQmowNUZlOE85?= =?utf-8?B?M3VOQ1hoc3NtbWgzUUFvYWt2K0tSMTVxa1FmbDBuanpCZFZLNC9zem1ucHZ2?= =?utf-8?B?ZDNJbHFMOFNIT0x0eGdLRkRSRWZBVkZZYUdudmg0d3l5cVVxdGpRaWMxOFpW?= =?utf-8?Q?OlXTAiIgLZczEw4//k6vho3dMJGsCKRmd+TnB6q?= X-MS-Exchange-CrossTenant-Network-Message-Id: d14b9d14-0391-40b2-09f2-08d8ede29d6f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:01:23.3851 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yeDoZ/E7oFk2udtTDTughx7lpIwXtbR5DlwlcXptKtz3yBpdFrW39UgbLZt2mnjUStF1ySzMQNZVxnbgBenWGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 X-OriginatorOrg: citrix.com Pull out the code from xc_cpuid_apply_policy that applies a featureset to a cpu policy and place it on it's own standalone function that's part of the public interface. No functional change intended. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 5 ++ tools/libs/guest/xg_cpuid_x86.c | 94 ++++++++++++++++++++------------- 2 files changed, 61 insertions(+), 38 deletions(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 07b8bfc08aa..a830fac1d12 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2639,6 +2639,11 @@ int xc_cpu_policy_topology(xc_interface *xch, xc_cpu_policy_t policy, int xc_cpu_policy_apply_cpuid(xc_interface *xch, xc_cpu_policy_t policy, const struct xc_xend_cpuid *cpuid, bool hvm); +/* Apply a featureset to the policy. */ +int xc_cpu_policy_apply_featureset(xc_interface *xch, xc_cpu_policy_t policy, + const uint32_t *featureset, + unsigned int nr_features); + int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, uint32_t *nr_features, uint32_t *featureset); diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index ce4a4a1a436..96b969342fa 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -450,46 +450,14 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, if ( featureset ) { - uint32_t disabled_features[FEATURESET_NR_ENTRIES], - feat[FEATURESET_NR_ENTRIES] = {}; - static const uint32_t deep_features[] = INIT_DEEP_FEATURES; - unsigned int i, b; - - /* - * The user supplied featureset may be shorter or longer than - * FEATURESET_NR_ENTRIES. Shorter is fine, and we will zero-extend. - * Longer is fine, so long as it only padded with zeros. - */ - unsigned int user_len = min(FEATURESET_NR_ENTRIES + 0u, nr_features); - - /* Check for truncated set bits. */ - rc = -EOPNOTSUPP; - for ( i = user_len; i < nr_features; ++i ) - if ( featureset[i] != 0 ) - goto out; - - memcpy(feat, featureset, sizeof(*featureset) * user_len); - - /* Disable deep dependencies of disabled features. */ - for ( i = 0; i < ARRAY_SIZE(disabled_features); ++i ) - disabled_features[i] = ~feat[i] & deep_features[i]; - - for ( b = 0; b < sizeof(disabled_features) * CHAR_BIT; ++b ) + policy.cpuid = p; + rc = xc_cpu_policy_apply_featureset(xch, &policy, featureset, + nr_features); + if ( rc ) { - const uint32_t *dfs; - - if ( !test_bit(b, disabled_features) || - !(dfs = x86_cpuid_lookup_deep_deps(b)) ) - continue; - - for ( i = 0; i < ARRAY_SIZE(disabled_features); ++i ) - { - feat[i] &= ~dfs[i]; - disabled_features[i] &= ~dfs[i]; - } + ERROR("Failed to apply featureset to policy"); + goto out; } - - cpuid_featureset_to_policy(feat, p); } else { @@ -1230,3 +1198,53 @@ int xc_cpu_policy_topology(xc_interface *xch, xc_cpu_policy_t policy, return 0; } + +int xc_cpu_policy_apply_featureset(xc_interface *xch, xc_cpu_policy_t policy, + const uint32_t *featureset, + unsigned int nr_features) +{ + uint32_t disabled_features[FEATURESET_NR_ENTRIES], + feat[FEATURESET_NR_ENTRIES] = {}; + static const uint32_t deep_features[] = INIT_DEEP_FEATURES; + unsigned int i, b; + + /* + * The user supplied featureset may be shorter or longer than + * FEATURESET_NR_ENTRIES. Shorter is fine, and we will zero-extend. + * Longer is fine, so long as it only padded with zeros. + */ + unsigned int user_len = min(FEATURESET_NR_ENTRIES + 0u, nr_features); + + /* Check for truncated set bits. */ + for ( i = user_len; i < nr_features; ++i ) + if ( featureset[i] != 0 ) + { + errno = EOPNOTSUPP; + return -1; + } + + memcpy(feat, featureset, sizeof(*featureset) * user_len); + + /* Disable deep dependencies of disabled features. */ + for ( i = 0; i < ARRAY_SIZE(disabled_features); ++i ) + disabled_features[i] = ~feat[i] & deep_features[i]; + + for ( b = 0; b < sizeof(disabled_features) * CHAR_BIT; ++b ) + { + const uint32_t *dfs; + + if ( !test_bit(b, disabled_features) || + !(dfs = x86_cpuid_lookup_deep_deps(b)) ) + continue; + + for ( i = 0; i < ARRAY_SIZE(disabled_features); ++i ) + { + feat[i] &= ~dfs[i]; + disabled_features[i] &= ~dfs[i]; + } + } + + cpuid_featureset_to_policy(feat, policy->cpuid); + + return 0; +} -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:07:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:07:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100588.191785 (Exim 4.92) (envelope-from ) id 1lOdx0-0000lZ-4S; Tue, 23 Mar 2021 10:07:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100588.191785; Tue, 23 Mar 2021 10:07:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdx0-0000lG-02; Tue, 23 Mar 2021 10:07:50 +0000 Received: by outflank-mailman (input) for mailman id 100588; Tue, 23 Mar 2021 10:07:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdqe-0006c2-W7 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:01:17 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f8ba6ac2-16b6-45de-b559-d8438a60d5da; Tue, 23 Mar 2021 10:00:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8ba6ac2-16b6-45de-b559-d8438a60d5da DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493655; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=cqD+tWGVB4nOXoM5SIKNJg9ABIWM9BwXG5qj4qpnV7o=; b=VlTr1cehDfTXoZ+8f9lzTvecd8+Ol10yjahXRLKxQjYkKwDNZC3Cdz9D uy/88zSGDI9EVPN804pqCMI9IQqnKe21Q1t1+9Hc0P8by3155LOk0PQYF JXyJmZaHoavMg7k+3c6csTFBvAeH5bRTvDAY0cROJyNGo88wGab1lbrs2 c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: tFVhLBjgM5gWqO4sNFSwKp5Q7HZE1NaaoTm2tbjSxVMDFdERRAA3k93Eavxly1OMcUi6Plsmw9 4EyAgVuQ/M9mPS7av4kvM8LFpOuDMCQ5Tz3sB2xWfvN+mwigvIjTAaPRbnyJNX0CPEdX738l8E qS0Npd/Zb/YkoNIsVgdW9/BJ98yGLhf2hJWjufbgpaA1COyhsKVdwqmVobZss2Y19fXBHU2WJ8 Cj14H8caTNKmGMAQac8o/INumoOiMri9BB9XIdUqhkZePiJdrLZV41xAS8l7/cOxUISuGfp5je bgM= X-SBRS: 5.2 X-MesageID: 40055664 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:WKVnSq+UZ5A3TXsdg1Ruk+Gncb1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmxybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIUDD38Zn/+ Nbf6B6YeebMXFTh8z3+RT9Nt4mzsWO/qzAv5am815GZ2hRCp1IxQF/FwqdDwlSTA5JGZI2GP Onl7J6jhCnfmkaadn+O2kdU4H41pb2vb/FQTpDPR4o7wGSkSilgYSQLzG01goTOgk/pIsK3n PCl2XCiZmLk/b+8RPE0n+W0pI+oqqG9vJmJOihzvcYMS/tjAHAXvUqZ5SnsCouqO+irHYG+e O8xysIBMh453PPcmzdm3KE5yDa3Dkj8HPkw1OD6EGTxvDRfi4wCMZKmOtiEifx1ks6sNlwlI JN0m6J3qAnby/ooSXn69DEEyxtj0q/yEBS8tI7sno3a+UjQY4UibZa0FJeEZ8GEi6/wpsgCv NSAMbV4+sTWU+GbljC11MfjeCEbzAWJFOrU0ICssua33x9h3Zi1XYVw8QZgzMp6I89cZ9Z/O 7JW54Y2I1mf4szV+ZQFe0BScy4BijmWhTXKl+fJlzhCeUhN2/SrYX0pJE4/vujdpBN7JZaou WPbHpo8UoJP27+A8yH25NGtjrXRn+mYDjrwsZCo5djvLnxQ6fqLD2DRFgin9DImYRfPuTrH9 KIfL5GCf7qKmXjXaxT2RflZpVUIX4CFM0Z0+xLG26mk4buEMnHp+bbePHcKP7GCjA/QF7yBX MFQXz2LMVE5Ua7R2/gjHHqKjDQU3262ag1PLnR/uAVxoRIHJZLqBIphVOw4dzOLyZDvKwwdE 53O6jmjau/uGmz8Q/znitUEysYKnwQzKTrUntMqwNPGVjza6w/t9KWfn0XwGGKPQZlT8TdEB dWolN+/a7fFe3T+QkST/acdk6KhXoao3yHC6oGkqqY/MH/Z9cTFZA9QpF8Eg3NCj14kQtns3 14dQcBX0PTfwmezJmNvdgxPqX/f8M5qBq3KcRUwEivznm0lIUKfD8neBKAFeSQmh0jQjJIgE YZyd5kvJOw3QyABy8TosQddGdNZmOWB7wuNnXdWKxk3orEVkVVYg6x9HqnoiB2QETFs34/vF DFEESvCLb2K2sYgF53lprP2HdPVkj1RTM1VllK9bBYUUz9/lhY98ilD5DDi1e5Ykcew+0bLT HOaSYTJAQr3NysyBuJgl+5ZAkb75E1PvXqCbwpf7TIs0ndVbGghOUIGeRZ841iM82ruugXUf iHcwvQNz/gDfg1sjbl70oNKW1xqHM+l+nv1wCg5G+k3GQnCf66GiUQe5gLZ9Wd5XPjXfCGzd Fwis80p/K5NiH0ZsSdwa/aKz5FJRW7mx/Bc8g47ZRVt7k1rr19At3SVibJzmhO2FEmN9jv/X luMphT8fTEIMtibsYScyVW8h4gk8mONlIitkjzDvUldV8ggnfHN7qykvL1gKtqBlfEqBr7OF GZ/SEY5fvDUieZ3bMRCq47Iw1tGTwBwWUn+PnHe5zbCQ2see0G4UGzNWWldqRBDKeCArcdo3 9BkqK1tv7SczC93g/evTF2eP0Tt2mmRN6/GwKKF6pD9cegNVGFn6ut54qygV7MOEqGQlVdgZ cAc0oaKtlHgH0lioY81yCpUKz5ok4/iTJlkERav0+o3pLj+XvRGEFNLBbQjZpXVyRCK3Tgt7 W6zcGIkHDmpCVf0ZbNFE1MbshDFtgZQI/wNTpvI6Erzc6V1rtqhD9CbhcoB3M9jz643/oO58 bH5Mnv X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="40055664" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hSN2XjNK30WKoKDpaOaZ4ktG/uQLzwTvI7jCXmZbjIuYSogteQtby63ZrGztfSyUjRZQd448eUVCdyCH0Q1Y7tZRenitqKnllJH2+n2CU93wGIYJ3S6GyLUDJkFnjGR/941JR7FsP6k1CeNIHXkA+zTgyHQSCy9VjLsGkhzsWXBVpqCCh/Po20xC1SebLT9R3NSIOEzX8f/G/ghHy5cAjUjyvMuQMwJW715Azmq4fUZT84PnCBn01CkROZCWR2IY2oXYDp2a0KGdawTdnUcd4pryfDer6uFGhtLI1hV8sRAgL51wfV6KW+BuHxCUDkez3gbALXQv96zDpHncnB+DgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hY3Kjsh0dxbfkIPBdEUM6WIbCGm2IEEAQFQ7pR2GimY=; b=YA8mMe2Zy+0BtGxjhPMCSr3QU8o3EzRaHD2Or8eF1RwQqtj1eZq1BoBzMk21UMmNEErTH2gYHyGO0jSqjr+R0143vfbyRZoLiAaJOHlDTqy0lJc8nbaCW0DQPu5T2/oK12FNQiSfczJVpwK0XhDIQ/8ApsP9D12N6z/Se0EHp0TDMhgqc5S/b6bgDJSXYbBoq2WUf9Qn1G7oReiBokF1uXkPbNcz22bGQgwgq1Hg+BGFhShkuOwgfVhKp7j1FNhAEmO1+sFFW3eH8lcH8/fivfzJiShMtxNpQ9V7jB6a11PTVpTBP61cVXZUw6aix4tpfDNQJs/2M9x0fC4Yepyiew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hY3Kjsh0dxbfkIPBdEUM6WIbCGm2IEEAQFQ7pR2GimY=; b=JhGzIIbD4S7GRBu0C5YRTn9UXMfw/Bd+4D1p02LPK2ab9181AzkqWCdrvCIdWO5PIwfdR/b71+V9pA0Mlxr3zKIqmusmkaXftJ/TjVGRz4ADQRhAN18CH570j1vkcxPUmvEXHvsOJMp/jS1CB0je0kID7dVgG5kuNWx+JZOS0Fo= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 13/21] libs/guest: switch users of xc_set_domain_cpu_policy Date: Tue, 23 Mar 2021 10:58:41 +0100 Message-ID: <20210323095849.37858-14-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0173.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::12) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0c34239e-bbc1-4e7e-605c-08d8ede28a66 X-MS-TrafficTypeDiagnostic: DM6PR03MB4969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:361; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WXIkZ34+UgPAT83aLO2rXjwWKANlatQh1mO93kMP9s38l7/QNmrAgSx7+rIdcwYG/d8dFy3dsm9SQdHcWTjM5B7iwgDmI0imGJWrN7YkcOtitiIN925K7KE0Ue4odX86QLzXfXIhAOXAJwVLRn3cnwjRsBANat/JGVKzFuwURVdVidwqNmqk6WSjTZ9okF/+lG/HYzepavx2B+Oln8xv71HFrDmn8lwvgEJVVQgU5Jm8j67sC98W8Gqbreic6YpPHj+VQyYApVBaWvj/arGHPrvcZJLbhF0kIKdYNHvrctJgUPmUZbzvQj7jEdGMdKRBzCPCxB/WQ4/6+1VK95+d5kRFK8BU8J+ugiYJM/R067Mo/kJM0s0cqysg4HwRyQuUgmDf0iXrFZyeuWokR60tWSXiSzRVEGvKPn+2Wu9bSb8wtJHfn5x65yyhMs8SXlQhYXh99LCFU0fPhL6Dm1lhu/vM/9whxeNsR3e5yn+6ZaSr0SgYvnf0i4ufZ1qP5YAO9UERZYD0KDQV8rDZrSV1mJ5LqTifnAoF18+Wpyyffe/NAx2nyLTXkTNYoMmxD/dRpeKRUTZPxThfYBw/l0R0WJEopoPsFPAgDpjQvQHFqQge9ow3GEBKWXKY8Ei8GVBdmtnsDB46p1F4bO5dYlABZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(54906003)(36756003)(2616005)(316002)(26005)(6486002)(956004)(16526019)(186003)(2906002)(86362001)(66556008)(6916009)(478600001)(5660300002)(8936002)(6496006)(38100700001)(83380400001)(6666004)(66476007)(8676002)(66946007)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Q0gvMVp3UGhONkNoZHFxSXpKUExGR29LUEtWZDg1U0J4QVp0S0NzZnNUSHAz?= =?utf-8?B?MFNKbU5oVmlvbThVVzZ0dVlCaGdQU0Nzenc5cWQ0clZpa0gxbmZISW9iODBr?= =?utf-8?B?Y1RrQ1lpdVkvcTdvOVVYWVlWTThVZnc1eENodlNseXltVm9iLzBUYlNCS1F6?= =?utf-8?B?bWtQSWhiZkxBd0Frb056WFJMcXdkdlIrQ3c4VndDOVdHdmhyYXRpZzZxT1lN?= =?utf-8?B?VUYyWnlaNFpSRithb0N5QUU3SG9jQkFRR3JlN0dzci9WR1FoOUlyWVd0aTBs?= =?utf-8?B?RUVvaVdMN0dETWFCTGErYU9SOEM0RDk2bzVGZjVDT1RMYXVkNFdDYzFzcU9H?= =?utf-8?B?a1JvQkkrOE9KRlVKRGNySnF1eEozTTIwaDU3NlNPbTdqSG03dEtDWHVmU3BY?= =?utf-8?B?YVZpQ2RNS0RSWEhTSnRGY1h0OGM1STFYMWpkK1p5V1VIRGZ5VEpqWFllNHhV?= =?utf-8?B?MFFlQS9YNk9BNXh6RzBCdG00VHBwbk0rRU8wbjNySlNxSEJyYzFrU245U1Yr?= =?utf-8?B?YXVtMzNmUERldFFLVmxHKzI2V0xobGVpUFRZSUlsc2hVUzZZMUFiemdlK2cr?= =?utf-8?B?aUI4OXpmTU5VRmZWVUtYazYzcHBJNzcva2RGcDhCMTNXYXg1dzlPQ3AvQzNv?= =?utf-8?B?cWtDcXMyU0NIQnVnZjZIY2p5UTMwTFgwR3phTVB5V1dzaXJady9QT0Y1MW9u?= =?utf-8?B?Z1UrN3g3YXYrL2IyMy9ETlhpVFZBWkxhVTdEL0hUQ1ZCcGkwZDlJU1hpSDNY?= =?utf-8?B?eTZlb1dpcEZuM2tsTVZxdDU2dFJqU28xV29EYnNnUFlOZW1TdXNWMzlmZ0Fq?= =?utf-8?B?Tnhzc015L0VlNU5CZTNoQ01OUnFTVTZkK2FHaHpCc1AxeGRQdFpGTVNuRzNa?= =?utf-8?B?M1hlakR2UzdHcCtpSHg1cXhkQjhNVi90MzBLT1MxSWliTkwzRUJzWld5MzNM?= =?utf-8?B?SU9YRXZQU3hRTmdPaDJYeHo5S3RFNCt2aTRuTjFaa1JQVktaSUtNaThvNDNR?= =?utf-8?B?S0NlM0xNM3dObG1VZmZhZFVGdG5ySE5BZDlsTHZMMGFZVnVBdWZKZXB5bUdw?= =?utf-8?B?SWpSV1lBM0pPNWE1azRrdDlxSmRZa0MrN0ZXMWRBRXF3OThBVG0yOWNzQnU4?= =?utf-8?B?cGwzVncrVTcvR2lObW5qb1lJR2NibmNZQTdPN0R5VVJvbHgweGUwSUEySUVS?= =?utf-8?B?ZmIzaDdnckZySkF2enZIWThPVU5nWU9VNm9UREJQQU9BamVxdjhSK2FxM01H?= =?utf-8?B?bk5Vb2duQktMSWhXdzZ6a2RDRURONnBKVXE3WFJqYjZTTjUrTjhnZTdGaXZU?= =?utf-8?B?Nmt0Y0tnRWxkMGprWXFrWE9KUVNSSHJPalhBUmJONjVra3kwUjdTVjdpN3dL?= =?utf-8?B?NWdvZEloMGdwVUVDZ09ZTHd5UmptLzNTQjVMNlB6eThybHl5a1NNUFE1K1Mw?= =?utf-8?B?UGx6dGZRWms1VDBnNDZzOEtNL1prNGdMOWxmNE9DSFowbTlDdG9xY1dSZ0ZW?= =?utf-8?B?VjZVL1dqMldhaWlKZjd6QXlrMDJmb01xQjJKOGg3VHE5ZHpSZmRRcDlQcWhv?= =?utf-8?B?aFIxM3JSbzk5MHBDL3ZxWml1MUh5c1p6VjV1ekVUMGtXNlVqNnlFZWhITmZv?= =?utf-8?B?RDZuRkJpVFdCZUJ5eHdhcmNLdXdQbkdSby9abXVVWk5HcXdoOEdYNHN0RUVo?= =?utf-8?B?eDNHakVMOHlWeWk2dXcwU1BVa3Nxay82VGM5ODZMaThnZ3ozbktBZG01aDNE?= =?utf-8?Q?yKbcj30yU+96oaan6LO3eg6ud16ky1mUBuzbU0c?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0c34239e-bbc1-4e7e-605c-08d8ede28a66 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:00:51.4327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Eceh7IR/BLgBDKMpPgEw8YBp2pBZsHg47vBirqMeeaViKR/Kf7Wxk8R+Z1k9xbugLj5edwng0Lm61l+3fdFGhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 X-OriginatorOrg: citrix.com To use the new cpu policy interface xc_cpu_policy_set_domain. Note that xc_set_domain_cpu_policy is removed from the interface and the function is made static to xg_cpuid_x86.c for it's internal callers. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 5 ----- tools/libs/guest/xg_cpuid_x86.c | 22 +++++++++++----------- tools/libs/guest/xg_sr_common_x86.c | 28 +++++++++++++++++++++------- 3 files changed, 32 insertions(+), 23 deletions(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 46f5026081c..164a287b367 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2625,11 +2625,6 @@ int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, int xc_cpu_policy_get_size(xc_interface *xch, uint32_t *nr_leaves, uint32_t *nr_msrs); -int xc_set_domain_cpu_policy(xc_interface *xch, uint32_t domid, - uint32_t nr_leaves, xen_cpuid_leaf_t *leaves, - uint32_t nr_msrs, xen_msr_entry_t *msrs, - uint32_t *err_leaf_p, uint32_t *err_subleaf_p, - uint32_t *err_msr_p); uint32_t xc_get_cpu_featureset_size(void); diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 07756743e76..f7b662f31aa 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -204,11 +204,11 @@ static int get_domain_cpu_policy(xc_interface *xch, uint32_t domid, return ret; } -int xc_set_domain_cpu_policy(xc_interface *xch, uint32_t domid, - uint32_t nr_leaves, xen_cpuid_leaf_t *leaves, - uint32_t nr_msrs, xen_msr_entry_t *msrs, - uint32_t *err_leaf_p, uint32_t *err_subleaf_p, - uint32_t *err_msr_p) +static int set_domain_cpu_policy(xc_interface *xch, uint32_t domid, + uint32_t nr_leaves, xen_cpuid_leaf_t *leaves, + uint32_t nr_msrs, xen_msr_entry_t *msrs, + uint32_t *err_leaf_p, uint32_t *err_subleaf_p, + uint32_t *err_msr_p) { DECLARE_DOMCTL; DECLARE_HYPERCALL_BOUNCE(leaves, @@ -405,8 +405,8 @@ static int xc_cpuid_xend_policy( } /* Feed the transformed currrent policy back up to Xen. */ - rc = xc_set_domain_cpu_policy(xch, domid, nr_cur, cur, 0, NULL, - &err_leaf, &err_subleaf, &err_msr); + rc = set_domain_cpu_policy(xch, domid, nr_cur, cur, 0, NULL, + &err_leaf, &err_subleaf, &err_msr); if ( rc ) { PERROR("Failed to set d%d's policy (err leaf %#x, subleaf %#x, msr %#x)", @@ -638,8 +638,8 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, goto out; } - rc = xc_set_domain_cpu_policy(xch, domid, nr_leaves, leaves, 0, NULL, - &err_leaf, &err_subleaf, &err_msr); + rc = set_domain_cpu_policy(xch, domid, nr_leaves, leaves, 0, NULL, + &err_leaf, &err_subleaf, &err_msr); if ( rc ) { PERROR("Failed to set d%d's policy (err leaf %#x, subleaf %#x, msr %#x)", @@ -833,8 +833,8 @@ int xc_cpu_policy_set_domain(xc_interface *xch, uint32_t domid, if ( rc ) goto out; - rc = xc_set_domain_cpu_policy(xch, domid, nr_leaves, leaves, nr_msrs, msrs, - &err_leaf, &err_subleaf, &err_msr); + rc = set_domain_cpu_policy(xch, domid, nr_leaves, leaves, nr_msrs, msrs, + &err_leaf, &err_subleaf, &err_msr); if ( rc ) { ERROR("Failed to set domain %u policy (%d = %s)", domid, -rc, diff --git a/tools/libs/guest/xg_sr_common_x86.c b/tools/libs/guest/xg_sr_common_x86.c index 15265e7a331..02f0c3ae9ed 100644 --- a/tools/libs/guest/xg_sr_common_x86.c +++ b/tools/libs/guest/xg_sr_common_x86.c @@ -151,7 +151,10 @@ int x86_static_data_complete(struct xc_sr_context *ctx, unsigned int *missing) { xc_interface *xch = ctx->xch; uint32_t nr_leaves = 0, nr_msrs = 0; - uint32_t err_l = ~0, err_s = ~0, err_m = ~0; + xc_cpu_policy_t policy = xc_cpu_policy_init(); + + if ( !policy ) + return -1; if ( ctx->x86.restore.cpuid.ptr ) nr_leaves = ctx->x86.restore.cpuid.size / sizeof(xen_cpuid_leaf_t); @@ -163,14 +166,25 @@ int x86_static_data_complete(struct xc_sr_context *ctx, unsigned int *missing) else *missing |= XGR_SDD_MISSING_MSR; + if ( nr_leaves && + xc_cpu_policy_update_cpuid(xch, policy, + ctx->x86.restore.cpuid.ptr, nr_leaves) ) + { + PERROR("Failed to update CPUID policy"); + return -1; + } + if ( nr_msrs && + xc_cpu_policy_update_msrs(xch, policy, + ctx->x86.restore.msr.ptr, nr_msrs) ) + { + PERROR("Failed to update MSR policy"); + return -1; + } + if ( (nr_leaves || nr_msrs) && - xc_set_domain_cpu_policy(xch, ctx->domid, - nr_leaves, ctx->x86.restore.cpuid.ptr, - nr_msrs, ctx->x86.restore.msr.ptr, - &err_l, &err_s, &err_m) ) + xc_cpu_policy_set_domain(xch, ctx->domid, policy) ) { - PERROR("Failed to set CPUID policy: leaf %08x, subleaf %08x, msr %08x", - err_l, err_s, err_m); + PERROR("Failed to set CPUID policy"); return -1; } -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:07:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:07:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100589.191794 (Exim 4.92) (envelope-from ) id 1lOdx0-0000me-LH; Tue, 23 Mar 2021 10:07:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100589.191794; Tue, 23 Mar 2021 10:07:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdx0-0000mV-AW; Tue, 23 Mar 2021 10:07:50 +0000 Received: by outflank-mailman (input) for mailman id 100589; Tue, 23 Mar 2021 10:07:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdrY-0006c2-1p for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:02:12 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 62d07dfd-584d-4ade-ba26-d97a9f62589c; Tue, 23 Mar 2021 10:01:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62d07dfd-584d-4ade-ba26-d97a9f62589c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493707; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=nS2izB/wMYNzEri//vlEUg8wYiGwzGHZuOBvg6gJjNY=; b=BI23oKd9eV1jPdgoWfeblsJDN9wrpp6kiMtcvl0C7SGAGvCVv8hXEdrQ DVtBofD0nhwEBvBUfiShjbQRivoUUZn3bwvMVl1RT9amIJKHkkxN5mZ/P fy2btkjidmuKyuMOLBD7QnWieuIlA44Vw3WPa6DK611Q6KKq+ctQibzV6 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: y2Nkz9I8NkfXTlEo3pOotCr2R230RJXgRk78uP/XeJASRT9gk8K3HfyOLoPVJZxokpMe1U0nEX ekp/mOfkcHEeOrPT5xDgQjpTnOaAJx38LTTtMNippTv+4/vxPyyLjqqXv4r7wdMnR4Jq8XY5pO P5Z2sboKv/CZJCsjhYAoNddN9/O/Jhe8KO9pF9fkoAi7ePP9H0BwKh7ZoBhQClMOaFdvdxhKsg 9FoAD7G3O7Cag899sFl1AErKaIz/GaDJI9tqqXCqvasJGMX5uoB+cQJjT0ZCNaOomkFzZOMgLA fIw= X-SBRS: 5.2 X-MesageID: 40055730 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:EAyTXakB+4i8y9HlFXsw1yB9Z1/pDfOpj2dD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLN/AZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 tdWoBEIpnLAVB+5PyW3CCRD8sgzN6b8KqhmOfZyDNXQRt3brx7hj0ZNi+wOCRNNW17LLA+E4 eR4dcCmiGpfm4ZYt/+Kn4OWeXCoNOjruObXTctARk75A6SyQ658bKSKWnk4j4ycRNqhY0j/2 /MjhDj6syY3c2T5xfA2wbonvJrsfT7zN8rPr3vtuE0LXHWhh+sdMBdXdS5zUsIicWOzHpvr9 XWuRcnOK1ImgPsV0W4uwHk1QWl8BtG0Q6a9XaijXHuodP0SVsBYqIr7+IpEWqq12MasN5xy6 5N1W6C3qAndy/opyjh+8POEyhji0vcmwtSrccok3ddXYECAYUhyrA3wUU9KuZkIAvKrKojEO VoEfjG4udXfV6wfxnizxdS6e3pcXIpEhicRE8e/uSTzjhNhXh8i3AV3coFgx47hd4AYqgBw9 6BHrVjlblIQMNTRaVhBN0ZSc/yLmDWWxrDPE+bPFyPLtBJB1v977rMpJkl7uCjf5IFiLEono 7abV9evWkuP2rzFMynxvRwg1DwaVT4eQ6o5tBV5pB/tLG5bqHsKze/RFcnlNbli+kDA/fcR+ 24NPttcr7eBFqrPbwM8xz1WpFUJ3VbetYSoMwHV1WHpd+OBZbtssDdbfbPNJvgGTspQQrEcz k+dQm2AP8FwlGgW3f+jhSUcWjqYFbD8ZV5F7Wf3+V78vlJCqR89iwuzXip7MCCLjNP9oYsel FlHb/hmqSn4U2//WPC6XRVKgNQZ3wlpInIYjdvn0snIkn0ebEMt5G0YmZJxkaKIRd5UofwHB NAoU90vYa6NYaZyyxnK9/PCBPVs1Ij4FaxC7sMkKyK4snoPrkiCIw9ZaB3HQLXUzpvmQhrr2 9HQBQeRlDWEw7vjanNtu1WOMjvM/1HxCu7K89drnzS8W+Go9s0e3cdVzmyFfKMjR0WXDpSjF 1p+6o5iL6N8AzfblcXsaAdChlheW6XCLVJAECgaJ9Pkr7mQg12UFyHnCeXkR01Z2rs+XgDn2 CJF1zmRdj7Rn5m/lxI2Kfj9115Ml+QeE99cVhWm4xwH2augAc57ca7Io6Il0eBYFoLxe8QdA zfaTwJOwV02pSczxiOgguPEn0g27QjNuHQF64YbrnWw3+hQbf4050uLrtxxtJIJdruuugEXa ajYAeTNir/EP5s9AqPpHopURME3kUMoLfN4lnC42e51nJkXqaXD1RiWr0BI9aTq0LjXO2F1Z 1ljdQz+cu8W1+BHuKu+OXyVXpkLBiWnEudC8cPgrpQtbgptLRyE4LAOAG4nE1v7VEbFoPMiE gaQK5H+7jPNY9kQtwKd0tijy8UveXKCHFujxf/DeA/d2w8lnP3P9uG5LzTtLoka3fx0zfYCB 26+y1Z8+ytZVr66ZcqT4YxK39Rck4y9TBL+/6DbZTZDGyRBqt+1Wv/Fn+2a7lGTqeZXZ0Wsx Zh+tmN28uabTDx1gyVnTx1JMt1giuaaPL3JAKHAuhT9dOmfXyKn6ux+ca2yA7NdgHTUTVQua R1MWoKbspCjTE+jIo4lgiKI5aH3X4Noh95+jFollnkx468xnzUdHs2aDHkvg== X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="40055730" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ede7H1yc7gXevCIdFx3ZqT32NSvBjcHYd9c0T+FcOpa6+saO76p2yvbmsy6v4tr2/3MCIExiO6dZkse30qPUmXHqahh32Cykyy9Op0Km79ALGARnOaEbTdDBqgaUWcvxHgpzjJkFKR7+EhbkGGMRWOPi/B8euYP4q0iQ6Lqt7EAnQ32aGddc9H9CHr2VZxok8g4QPBM/4ems2zORYCVNLOE6FNUXWu1/51TCLlIbRbXQE44OCaKijJecajAZ3MGMv9IJNtUYPme5TC7Blwt7ClTsW0KSEfmUnPx0prBPf35lA5+7OJCvoXVS9dzGImqGH6BK1uGdS2TmZFw71JZ8UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0q/89uigaDgolgby8oRhEV72/0m8hoezhu+aa5CjkiI=; b=a3ZZc0sK+Y77KfJTe6OCEw3mIi8fY6fdWCgIZx3WpuN06dgaoWU6MZt72oDApRNgbVuVn9Bk/09tYWOX/pN2yKKBDJr/U0oAYE6gIBQlrvOO24DefsDD5ZRTJAHKaJblfUwCKyI3E9s2ETnp35V7hdeyo6T3z69dVUo6T7a5QuHEOOlxrscJql1jG2dn5ffajwxCrXOEiv21IXtJXU4xoAT3L31iiJhm+82jmdF8jjf1iWppgdzcpB8dbtClOXJIDUcVISG5tnhMJTVBKN5kQ4+1IVTUQ/IjCbeFNiMHBQQ2sR6X/V0xmAlkTft5uAhhmwEw5f3OH1VH3KQKTCKwTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0q/89uigaDgolgby8oRhEV72/0m8hoezhu+aa5CjkiI=; b=B0sGhjU0dy0yK5rTJbvQUWtUPuF8T62Ts8kEYK5sIM6wU9p7l9Ww6fDpurN7vMiWU/A5sdEwN3qSdg6LSk9p9l7JHbCmfAXEHJH1r2S+EzasC6l3V7It+HyiDQV+cfhW49XOnnK23Q8vrNcWg1FLR1LkiRJjOJeteTYvAUn3PwA= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu , Anthony PERARD Subject: [PATCH 20/21] libs/{light,guest}: implement xc_cpuid_apply_policy in libxl Date: Tue, 23 Mar 2021 10:58:48 +0100 Message-ID: <20210323095849.37858-21-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PR0P264CA0191.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::35) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 690eef40-92ab-4d05-0636-08d8ede2a104 X-MS-TrafficTypeDiagnostic: DM6PR03MB4969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:267; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +kQJVZLBh4jKzhRwMdk67ZsVyijt2xghim6PT/BS9GEmWaj6tTe2oZx5D286ga/BUhMf5X0I+/z7wkznY7IeIUCmQZ1wAJcyJHQ0sLyNOTNCq7lnA3lnEm5eNJCQW80c3zdQLxoTwhScSFEpyftmffu74Khk+aNOWywwFhAJy/s7utiUfMPlPm8eaJlTNmfwGnXwOrLHV1NBo5JSj/pmAg+KzAympW1ZIvHfLZLUe5coY7EJDtEQC7mEXtQ2/aNBF1q/S/7PbruXZvUqHyvyfl7UVOJnQWJhtgqPLl3tI/RgsYMD5GUO1W11UJY/FFJ5UkTjEipJKfEu6XVfGaD+5iWMBkxrSz0I7bhM+aeEI+3BNe7SrNlPvEXw6KYzmwUY9m3UrwWrMLk6FWIs0NgTrvNb0Vg3FwapvMD7QRlnj5nbhXB0LpmHAc8hB7PU7ax7Xx/98N9SBYd8X3f5Sq6c8sQ4SysZAlYqBTCnCCiWu4VGYRU0CZYIj+rSXtlc/XN6t+JyUODFUhtxfjLSujcDs2gdL52h8lkYDbOHbw8O0nA1rPGpkFfbcgiD99BzBkC/394eJxRc1RfPr0QuIwsGoGl/d6oiINMURtYQb8+rrM1RItv1CBykMRkyTPPgQ3g0/O2yfwNdJM/cePA8uYYjeQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(54906003)(36756003)(2616005)(316002)(26005)(6486002)(956004)(16526019)(186003)(2906002)(86362001)(66556008)(6916009)(478600001)(5660300002)(107886003)(8936002)(6496006)(38100700001)(83380400001)(6666004)(66476007)(8676002)(66946007)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?U0srdjVYNXM4K2pKUG5xU3FjV3VOKzg1MVlKNkV0RURTV1d2TndxRERmOHk5?= =?utf-8?B?cHkyRmlzWDRwdVp0SU1taDI0TUp4M1dEeEp1TjVORDdJdmFITDl0Yjlmditl?= =?utf-8?B?SUwyK3BUckQyT3o0RUN6R0J1cHNpaGx3YzMwNm9qdE1DK3lVakhUeG5aUi9k?= =?utf-8?B?ZGlrZ1VpV3RWRzgySXNnNHFQTC92WE4ySG45c3R1RnNwOHFPNElVU05wZmtP?= =?utf-8?B?V1AwUVFTT2YzdUFYaGhsNnY3L2s4amsyemFKRmZzZUprSXZpRVpReEFJS1FN?= =?utf-8?B?ZS9ZNkhtQU4rNWNZemd3YmJsZnVTQThzMGM4SkVtL2NYMmR2R0tCUzdYeTVG?= =?utf-8?B?SDhZcEtnZ2d0MElsalE2cWh0cnd0WFlyRUQrbFRmY1doVVRYcmc5Qi9KbEtN?= =?utf-8?B?SVllbWtIOU9teDN3bi9ESzRyK0JDZy9NUVIyVkMrVkpsdnNVL1hYUzN5cmNl?= =?utf-8?B?UHJGbXNxS3BqSnd2T0Z0QWxkaklkZGl3YW5LWXluMUpVTEFVK3ZSdHBXb2tC?= =?utf-8?B?ekp5RTFXUERTM0l3NXgrWTYrMzgvTC9La2Q0NGwyaTRIbWxtemM0alUyb2d4?= =?utf-8?B?VlZBZ1pWM1djcVpqOCsxZTdIcUFjQmpmTmtZME43S09uOGhKUm9IV3IwWUhq?= =?utf-8?B?dDl2ekxaMGZJeDZkUW9mTHF3Y3MxRGplYVZkK2I2SU55N0tzV1RPT2FxK3hO?= =?utf-8?B?Yk5PeDRXQThUUDVzVk1WYUpoTTUyQ0ZTVk0xTFNFenZKT3JkRmlOcDBHRWxv?= =?utf-8?B?TUxvRGZBTkxCZlkzR3NxQkdCaHFZOE5NUnNHUHQ2OWV0NXdyNXRLMVNKTXhK?= =?utf-8?B?Tkd6VWljZGZnZnRwa1BEMyswMnR0Z3ZwSUVic3Y2NURmUVlYUWlIU3l4bDB3?= =?utf-8?B?eThUczlqNTFLQ2hwU3ZaeWtkYk9hYmg0eWNaWkhuWm5lQXJJNENLMlRvWUl5?= =?utf-8?B?OU9PcVR5Z2p0TXJ0dGR3YUg1QmtKSjJpQTg0VXY1ZzBrcTJEQlhNL3QwOEdr?= =?utf-8?B?STg0NnJWM1QxdXVqSjJMZTlreGxTZFFlQUxMUTU2YThwdThSY1ZYUjUwY3VS?= =?utf-8?B?TFFubDRFdENYS2J0SHVDbk0rNjBxVUxKOG1yQkYxRU9pNzBreWRSMnFnVk5t?= =?utf-8?B?MWxmSzNsNXcwM0pMTXZ0TGllYml5UHpSZFhhVnZVNE1FRS9ESURsbm9pMVJV?= =?utf-8?B?U2hKZjhRbEt5dzhSaFIyQXlaWWJubS9xSi92aVkwMjVRMVcxN2NXQ0RBOU1G?= =?utf-8?B?RWl3SjhvOEZ4MWNnSkRHcXhIOCtsRlNkWnNTbnJtZ2cxUWRiSkw5Zmo1VzVm?= =?utf-8?B?N1pHUUIzTkc4clkrNzROVTJHZnZHbGt4YU81dml2WFdoUmtwQmRUTWgzMHRD?= =?utf-8?B?a3lzeDdzb3hJalpNdWhhQ1JJK2VmUHFQejk0Z0pMQUU1aDVoU3pobGlGYm5R?= =?utf-8?B?VGhEVXNBY2JSaVo2SHRMaWdJTWxjd3VEOHlPTXlFSHVlT0VpbjFNY1Z4dUwx?= =?utf-8?B?YnFXbnBoeFR3dzBmWVhKSVJ4ZVd3aWNTTll2SXVlMnVBUTNlTDdiZlgxeVl2?= =?utf-8?B?RGxUSVpXdERPUXRRcHd2b0E5UXRweVl2R2liV2x0SXU1dER1aWdES2xHQlla?= =?utf-8?B?S3V2YVVMNEZIMWdwZlpKQ0RtVmIrTUFMY1h5SVdNeHlhWW04YzJYbGhTc0Y3?= =?utf-8?B?cTQvOTJsWUhYcVlBc0s0bUs2OU9rWnFHRjVUMGIvTlpKQ3BDUmlLSW5qWkE3?= =?utf-8?Q?He5BHv7BErj/FfzrvVmgj0v68Sk9obfPYKFzgcQ?= X-MS-Exchange-CrossTenant-Network-Message-Id: 690eef40-92ab-4d05-0636-08d8ede2a104 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:01:29.3887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1iX3tVQlntxM3xh0OTc4ljD4asklIUZCEeo4c94FhstTtqE4joX7cyPLWjIc+mFIKy3wQA0EGxJnk0SXxIn9kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 X-OriginatorOrg: citrix.com With the addition of the xc_cpu_policy_* now libxl can have better control over the cpu policy, this allows removing the xc_cpuid_apply_policy function and instead coding the required bits by libxl in libxl__cpuid_legacy directly. Remove xc_cpuid_apply_policy. Signed-off-by: Roger Pau Monné --- I'm unsure why this is called libxl__cpuid_legacy, mostly because I don't seem to be able to spot a libxl__cpuid (ie: non-legacy version). Should this be renamed to libxl__cpuid? 1b3cec69bf300e012a mentions the process of switching to a new cpuid interface, but I'm not sure we need to keep libxl__cpuid_legacy, since that's an internal interface that's not exposed to libxl clients anyway. --- tools/include/xenctrl.h | 18 ----- tools/libs/guest/xg_cpuid_x86.c | 123 -------------------------------- tools/libs/light/libxl_cpuid.c | 87 ++++++++++++++++++++-- 3 files changed, 83 insertions(+), 145 deletions(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index a830fac1d12..5a576f72b4d 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1890,24 +1890,6 @@ struct xc_xend_cpuid { char *policy[4]; }; -/* - * Make adjustments to the CPUID settings for a domain. - * - * This path is used in two cases. First, for fresh boots of the domain, and - * secondly for migrate-in/restore of pre-4.14 guests (where CPUID data was - * missing from the stream). The @restore parameter distinguishes these - * cases, and the generated policy must be compatible with a 4.13. - * - * Either pass a full new @featureset (and @nr_features), or adjust individual - * features (@pae, @itsc, @nested_virt). - * - * Then (optionally) apply legacy XEND overrides (@xend) to the result. - */ -int xc_cpuid_apply_policy(xc_interface *xch, - uint32_t domid, bool restore, - const uint32_t *featureset, - unsigned int nr_features, bool pae, bool itsc, - bool nested_virt, const struct xc_xend_cpuid *xend); int xc_mca_op(xc_interface *xch, struct xen_mc *mc); int xc_mca_op_inject_v2(xc_interface *xch, unsigned int flags, xc_cpumap_t cpumap, unsigned int nr_cpus); diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 96b969342fa..dffb9923b33 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -383,129 +383,6 @@ int xc_cpu_policy_apply_cpuid(xc_interface *xch, xc_cpu_policy_t policy, return rc; } -int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, - const uint32_t *featureset, unsigned int nr_features, - bool pae, bool itsc, bool nested_virt, - const struct xc_xend_cpuid *cpuid) -{ - int rc; - xc_dominfo_t di; - unsigned int nr_leaves, nr_msrs; - xen_cpuid_leaf_t *leaves = NULL; - struct cpuid_policy *p = NULL; - struct cpu_policy policy = { }; - uint32_t err_leaf = -1, err_subleaf = -1, err_msr = -1; - - if ( xc_domain_getinfo(xch, domid, 1, &di) != 1 || - di.domid != domid ) - { - ERROR("Failed to obtain d%d info", domid); - rc = -ESRCH; - goto out; - } - - rc = xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs); - if ( rc ) - { - PERROR("Failed to obtain policy info size"); - rc = -errno; - goto out; - } - - rc = -ENOMEM; - if ( (leaves = calloc(nr_leaves, sizeof(*leaves))) == NULL || - (p = calloc(1, sizeof(*p))) == NULL ) - goto out; - - /* Get the domain's default policy. */ - nr_msrs = 0; - rc = get_system_cpu_policy(xch, di.hvm ? XEN_SYSCTL_cpu_policy_hvm_default - : XEN_SYSCTL_cpu_policy_pv_default, - &nr_leaves, leaves, &nr_msrs, NULL); - if ( rc ) - { - PERROR("Failed to obtain %s default policy", di.hvm ? "hvm" : "pv"); - rc = -errno; - goto out; - } - - rc = x86_cpuid_copy_from_buffer(p, leaves, nr_leaves, - &err_leaf, &err_subleaf); - if ( rc ) - { - ERROR("Failed to deserialise CPUID (err leaf %#x, subleaf %#x) (%d = %s)", - err_leaf, err_subleaf, -rc, strerror(-rc)); - goto out; - } - - /* - * Account for feature which have been disabled by default since Xen 4.13, - * so migrated-in VM's don't risk seeing features disappearing. - */ - if ( restore ) - { - policy.cpuid = p; - xc_cpu_policy_make_compatible(xch, &policy, di.hvm); - } - - if ( featureset ) - { - policy.cpuid = p; - rc = xc_cpu_policy_apply_featureset(xch, &policy, featureset, - nr_features); - if ( rc ) - { - ERROR("Failed to apply featureset to policy"); - goto out; - } - } - else - { - p->extd.itsc = itsc; - - if ( di.hvm ) - { - p->basic.pae = pae; - p->basic.vmx = nested_virt; - p->extd.svm = nested_virt; - } - } - - policy.cpuid = p; - rc = xc_cpu_policy_topology(xch, &policy, di.hvm); - if ( rc ) - goto out; - - rc = xc_cpu_policy_apply_cpuid(xch, &policy, cpuid, di.hvm); - if ( rc ) - goto out; - - rc = x86_cpuid_copy_to_buffer(p, leaves, &nr_leaves); - if ( rc ) - { - ERROR("Failed to serialise CPUID (%d = %s)", -rc, strerror(-rc)); - goto out; - } - - rc = set_domain_cpu_policy(xch, domid, nr_leaves, leaves, 0, NULL, - &err_leaf, &err_subleaf, &err_msr); - if ( rc ) - { - PERROR("Failed to set d%d's policy (err leaf %#x, subleaf %#x, msr %#x)", - domid, err_leaf, err_subleaf, err_msr); - rc = -errno; - goto out; - } - - rc = 0; - -out: - free(p); - free(leaves); - - return rc; -} - xc_cpu_policy_t xc_cpu_policy_init(void) { xc_cpu_policy_t policy = calloc(1, sizeof(*policy)); diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c index a7b33bbcd06..f1418382b62 100644 --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -423,6 +423,8 @@ int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore, libxl_domain_build_info *info) { GC_INIT(ctx); + xc_cpu_policy_t policy = NULL; + bool hvm = info->type == LIBXL_DOMAIN_TYPE_HVM; bool pae = true; bool itsc; int rc; @@ -436,6 +438,42 @@ int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore, */ bool nested_virt = info->nested_hvm.val > 0; + policy = xc_cpu_policy_init(); + if (!policy) { + LOGE(ERROR, "Failed to init CPU policy"); + rc = ERROR_FAIL; + goto out; + } + + rc = xc_cpu_policy_get_domain(ctx->xch, domid, policy); + if (rc) { + LOGE(ERROR, "Failed to fetch domain %u CPU policy", domid); + rc = ERROR_FAIL; + goto out; + } + + /* + * Account for feature which have been disabled by default since Xen 4.13, + * so migrated-in VM's don't risk seeing features disappearing. + */ + if (restore) { + rc = xc_cpu_policy_make_compatible(ctx->xch, policy, hvm); + if (rc) { + LOGE(ERROR, "Failed to setup compatible CPU policy for domain %u", + domid); + rc = ERROR_FAIL; + goto out; + } + } + + rc = xc_cpu_policy_topology(ctx->xch, policy, hvm); + if (rc) { + LOGE(ERROR, "Failed to setup CPU policy topology for domain %u", + domid); + rc = ERROR_FAIL; + goto out; + } + /* * For PV guests, PAE is Xen-controlled (it is the 'p' that differentiates * the xen-3.0-x86_32 and xen-3.0-x86_32p ABIs). It is mandatory as Xen @@ -446,8 +484,15 @@ int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore, * * HVM guests get a top-level choice of whether PAE is available. */ - if (info->type == LIBXL_DOMAIN_TYPE_HVM) + if (hvm) pae = libxl_defbool_val(info->u.hvm.pae); + rc = libxl_cpuid_parse_config(&info->cpuid, GCSPRINTF("pae=%d", pae)); + if (rc) { + LOG(ERROR, "Unable to set PAE CPUID flag: %d", rc); + rc = ERROR_FAIL; + goto out; + } + /* * Advertising Invariant TSC to a guest means that the TSC frequency won't @@ -463,12 +508,46 @@ int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore, */ itsc = (libxl_defbool_val(info->disable_migrate) || info->tsc_mode == LIBXL_TSC_MODE_ALWAYS_EMULATE); + rc = libxl_cpuid_parse_config(&info->cpuid, GCSPRINTF("invtsc=%d", itsc)); + if (rc) { + LOG(ERROR, "Unable to set Invariant TSC CPUID flag: %d", rc); + rc = ERROR_FAIL; + goto out; + } + + /* Set Nested virt CPUID bits for HVM. */ + if (hvm) { + rc = libxl_cpuid_parse_config(&info->cpuid, GCSPRINTF("vmx=%d", + nested_virt)); + if (rc) { + LOG(ERROR, "Unable to set VMX CPUID flag: %d", rc); + rc = ERROR_FAIL; + goto out; + } + + rc = libxl_cpuid_parse_config(&info->cpuid, GCSPRINTF("svm=%d", + nested_virt)); + if (rc) { + LOG(ERROR, "Unable to set SVM CPUID flag: %d", rc); + rc = ERROR_FAIL; + goto out; + } + } + + /* Apply the bits from info->cpuid if any. */ + rc = xc_cpu_policy_apply_cpuid(ctx->xch, policy, info->cpuid, hvm); + if (rc) { + LOGE(ERROR, "Failed to apply CPUID changes"); + rc = ERROR_FAIL; + goto out; + } - rc = xc_cpuid_apply_policy(ctx->xch, domid, restore, NULL, 0, - pae, itsc, nested_virt, info->cpuid); + rc = xc_cpu_policy_set_domain(ctx->xch, domid, policy); if (rc) - LOGE(ERROR, "Failed to apply CPUID policy"); + LOGE(ERROR, "Failed to set domain %u CPUID policy", domid); + out: + xc_cpu_policy_destroy(policy); GC_FREE; return rc; } -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:07:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:07:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100590.191800 (Exim 4.92) (envelope-from ) id 1lOdx1-0000o6-0o; Tue, 23 Mar 2021 10:07:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100590.191800; Tue, 23 Mar 2021 10:07:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdx0-0000nc-QF; Tue, 23 Mar 2021 10:07:50 +0000 Received: by outflank-mailman (input) for mailman id 100590; Tue, 23 Mar 2021 10:07:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdqZ-0006c2-W1 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:01:12 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 361e98fd-7e1a-4343-8257-b18ed40b1f10; Tue, 23 Mar 2021 10:00:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 361e98fd-7e1a-4343-8257-b18ed40b1f10 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493647; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=DR+QXS/ul67exuNBj6emUyOCRNTyaDn6XpX3sgTsimc=; b=EvJXfkXbGgPLyBOG30ah7Wdt1To9Fd+qquf5jvHOgXC0uucmptaHGy1N qIQrngbk8eHieEya9oF6WPiXim5rLkxjik6rIM/pejtRo32UlS4MSruwB J3eGiOVefIOzs57cGDs3nFXEBZoa+ExeW7rYhsmWKT5ab6kKxJJgfiG+0 o=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: +9D8T9GfCxt2Zw2O9jwG/CyqTUuuKHuMWNZ908N7eLj90uPzlfEe0RW0AWNmjxKKXhbN2wO7cc luk2MLgJ054Eo7MFKfPW55bftPxJNfDgc22zgkFF1f4bNWXy9Cy71tAWJws1XBWHTGF2tpBmRS jeLERQjWuvvghdcBw5BCt+NLJTrxrce6SKkkjRDj//jAp0JaNqLGNJSxFLL//EJVYwcMcBDsEa Asuj0Pr3291OjZPSPxDWjP/QrtaTwyRMXPrwmZFuXki3a1W9MjnCwzt+EXYZMK6t2m+K5KOkES NPA= X-SBRS: 5.2 X-MesageID: 39779652 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Sh0DAqtK4HkPV5dJOzZPj0B97skCCYcji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOjbU5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qx6Y 5JSII7MtH5CDFB5/rSyAOzH888hPyO9661jenTpk0dND1CQYsI1WZEIyycFVB7QxQDIJI/Go aV6MYvnUvZRV08aMOnCn4ZG9XSvtGjruOsXTcqJT4CrDOPgzSh9aLgH3GjtSs2fjtTzd4ZgA 34uiPj4KHLiZ6G4z/ak1Te9pFH3Obmo+EzYvCkrugwBnHShh2zZIJnMofy9gwdhO208l4lnJ 3tjn4bTqBOwkjcdG20vhfhsjOIuAoG0HPsxUSVhnHuu6XCNVUHIvBcjoFUeAax0Sodlex8y6 5C0ia4sJdaHHr77UbAzuXITB1jmw6Ip2Mjm4co/h9ieLYZAYU+kaUvuGduVLsQFiPz744qVM N0CtvH2fpQeVSGK1jEo2hG2rWXLzkONybDZnJHlt2e0jBQknw85VAf3tYjknAJ8494Y4VY5t 7DLr9jmNh1P4MrRJM4IN1Ebdq8C2TLTx6JGnmVO07bGKYOPG+IjJLr/rMv5qWPdIYTxJU/3L TNOWko+lIaSgbLM4mjzZdL+hfCTCGWRjL20PxT4JB/p/nyX7zuPSqfSE0/kseprvkFa/erGs qbCdZzObvOPGHuEYFG00nVQJ9JM0QTV8UTp5I6Vju104L2A7yvktaeXOfYJbLrHzphcHj4GG E/UD/6I9gF6kiqX3T/kQXAQn+FQD29wbtAVIzhu8QDwokEMYNB9iIPj06i282NITpe9qosfE V/J7vjmrihpXa/+HvJ62kBAGsSMm9lpJHbF19arw4DNE35NZwZvc+ERGxU1HybYgNkQ9jOCw 5ZrVRv8aexJ5idrBpSSe6PAya/tT8+tXiKR5ATlum//s/jYIo/FYtjcrd2Dx/3Gxt8nhtKpG 9PZBQffFLWEirjhMye/dkpLdCaU+M5oQ+wZeZItHrUtCyn1LoSb0peewTrbOm6rkIFQSFOil h47qkF6YDw4wqHGC8Ersp9HX9tTCCsALxADAOKDb8kw4zDSUVLY0nPoRPysWB0RkPas389qC jbARepXMyjOCsbhllolpzF3hdJUk24RWJcA0oK9bFVJCD6njJa66ukTIyV/AKqGwM/6+kALT DIZiYTKAtyx9axkAWYgiqGCG9O/ORTAsXYFrQ7RbTa0X+pMuSz5Nw7Nu4R85B/ON/0tOgXFe qZZg+ONTv9T/gkwgqPux8eSWBJgWhhlfPjwxv+6mekmHY5HPrJOVxjLotrVO20/izhR/yS1o 9+gs9wteysMn/pYtrDza3MdTZMJlfSpmGxJttY36x8rOY3tLFpGYPcXiaN3HZb3A8mJMOxjV gAWs1AkcL8E54qe9ZXdzNS/1IvmtjKJEw3shbuCut7eV02lXfUM96A/rKgk8tmPmSR4A/rfV WP+SxU+PnIGzGO0rMXEKo8K2VbYkpU0gUXwMqSM4nLTAm6feBK+1S3dmKneLhGUa6fBPEeqA 1579zgpZ7lSwPonATL+T11LaJF/zz5HYe8AAeQFfVJ9NL/M1KWmaeu6NOyijCySTbTUTVoua RVMUgLKsJEgX0+iYdy1C64QKn+uFgknFtT+isPrC+Z5qG2pGPAWVhbOgjYiIhMVTZdMnKUnd 3ImNLoqkjV8XxAw93fD09ecdFFBsgIQoX2JyloL9IMvLTAxdtevg1TJBE0D2A9jzjh3+Rpmb ehsc+iJNHfNQ== X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="39779652" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WKgRxfXU5qXLkh+zQxN10xz5TtDTH7tVQTa/Qrk6bNTZmvmSyNMUF9SGkr+66nFO25CKms52sgMG0RmBoS6LzMEV7QwIfZ2VvYPx1mMr8ofUVrncT4vWR32Y9PXTWjFRL6PJzAoJj+CTjuGF/VDaWLZLnlr4puiTuPkjhLR+nz6xGXDfT7F8zhSHNxVmGpqv9lKi0+H8wIjNA5IQ238YKEaJXEp6En34B4fXFpKUBSTpp09XxLwRMF9Jc463sRKq0Uoo3HMATjpeMlJz8ji0Isaa4MGKvSdusqfNvYT60HShE5bXvOixvGxSfO61Hf34CvLLhC9RqsANXnMmUmRsMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/3WiOg86VPd8L28F4qhC0/C6RZk1orVvsRJ5t1bdvfc=; b=nqAC3p/WoP+h5dthD9zobly7JWmH7SJYYPGzR7tjpc6dR6/YVessvhhwB3h38zHJLftDn6pgYGQm1VLStJBfZ8dpwEdUdb61vtPxPnjjv5Ugeoh/xEIf5N8prRJtT4dJ91wLaOcmnaeSoUd7t0k4EuJ7wuG0sMHFhtX7GvHx5wSPLvM3B8I7AvAiFoJmfFoKa23xAbxJM1QY028Mwmr/ycRGMoBZOVMcuqTG0yCHnuppxHdH5mzsI/Xm/TNNQhGWF30M1MVgmbDqwT/H4QklgKutqYxNJCmYwqPt84sPYlBMkvu4RfKvEI6qlcet20nTexWqrqbIi+xTsAqIEwr0wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/3WiOg86VPd8L28F4qhC0/C6RZk1orVvsRJ5t1bdvfc=; b=R/ftgb2rOGdXxIjNJZIgXA9FNI1FVF6I7mMHYnDrw2WnKfRXsg/NcYXwq4i3rNml3A0LY9FPjsLkS7FnrzniayxXFsXqOEnEJ+sSwgXUbILM8oYD9NXax13nn1sDX4wX3gcNhF08WIE+Zvd5T3hA+q5W3fr2qdriGsr6z00Iq6E= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 12/21] libs/guest: allow updating a cpu policy MSR data Date: Tue, 23 Mar 2021 10:58:40 +0100 Message-ID: <20210323095849.37858-13-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PR0P264CA0122.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1a::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62396a62-fd03-4077-3964-08d8ede286c0 X-MS-TrafficTypeDiagnostic: DM6PR03MB4969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gJ+0e3/yEvCf3OD/VV18k5lEBHDIb+D0htT6R24DSCgVTzRmfTmXtHRIhXl85JqGzlEkA/1sROUssgi4RXWDhaJ6cuR8bek8LnGGXrzPMEMg7UL5oYklXCl5WPBlXTMqXQ2mhVDGFuTb7e1s+32DCqNdvFBSEnr7/x05f8QDrTUyV8kEZ5Ic8V774c7b2ORfqk/zBt9hY5C2DScjKeGJw5wJewizxx1R+uxzS04CdZKaxyqumI2DsmSnE+kBTIVEYf8xU30yQO7+0bA47X2uqYml5059fABxlaslF1ZsaZOmnfj05r2bJB2BsUrtALngNKfZA178/2B39W4CxmOo4Mkh7lP8fxRu3YJokPG+vlqdpffORDifvOEwVZDuojwtNfHPN06zGsYaAPKY67yFWLkOtRlJgHZtDbRu2I7o7nsEQwkmtPR73Lcf12bdiwwgTIrZoqLklNK5/ub31fTmMqaTW3QvwPQFkEBERFlSYDTbBlYhH3ePZ+a2IIAOlxdFzm9HErl5FUgiE0/AyY1lboMI8697lEDupirJ5/e7/4LT3jVcg1zec3aj0as05CH5sEA769NzK4SaLFFaJmaI+s5mueLSy3FoihHtYJDZD/stXmcCOIhfo4mNcwT4KllBED/eXq+W2Mvoksj/H4K7TPFcjJ57TZ7WHAzu4HoCxaU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(54906003)(36756003)(2616005)(316002)(26005)(6486002)(956004)(16526019)(186003)(2906002)(86362001)(66556008)(6916009)(478600001)(5660300002)(8936002)(6496006)(38100700001)(83380400001)(6666004)(66476007)(8676002)(66946007)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bldURTFaclpWaHUrVTF3ZmRpaGErT0hnNXNpbWVrb0JXMlZOT3ZzMDR3WCtP?= =?utf-8?B?RHBhbWRsdCtOa1ljSko1MGdnYlZwdldWSkI0eTlXZmhTVjM4SVdxZmxxeFFp?= =?utf-8?B?b0txbFJvQkplVUYyRmV6YnFYOWRlaHhoZitGTjNMbkovV2ZuOG8rYTNkKytJ?= =?utf-8?B?UkxCU3pXZ0JXZ3Z1Y3FGRlBpL2JSdzhaWkdsdHNvQXA4cjUyemZudTNRUmxK?= =?utf-8?B?d1k1YVFRaThodlJ5T1hjSlRzUkQxUmtDa1NDYkVuRkVnMUFPWXZNVllVak5E?= =?utf-8?B?aHlIRDMyTS9QeGxTVE1TbVZucXp3MW9abkp4VGxQaUpPVmxxWFA3Qk54R3lN?= =?utf-8?B?QWdjTjgwNzlkVjYwWXdEV05vS2VKR0M2QmFJTSt6cTU5VEdnRHhpcUExaVJx?= =?utf-8?B?ZjdtTytoWHZDWXV1Z3BmcE9hS3Z0Z0llRFdyV0hOdVBOcjkwS3gxT3l6OGFT?= =?utf-8?B?eGU2czh5SGNka0M0K3NIZ2NuZUUxZWE1Mmx3dExMaWJHR2ZhUm9TUG5MUkxq?= =?utf-8?B?Snk0QzVoZ2psbEJDM0ZkREVjMFBMWTRPU1hWamdrbTJtSEFMS0JkaUp1Y1VY?= =?utf-8?B?YThwZkxQbVVkdnJQRjZNT3pUb3RrZ1ZCVDl2Tjl1QVptQ0QrSjN2NGVSdURk?= =?utf-8?B?WTFoa2lpM3NvblU3eSsvSW5kRUdINzRFNytCWkdwZWd4VkhMTVRkS1h3R0tG?= =?utf-8?B?VnpJZ09lTm1GQWZLZ0ZkVGtPc0N1TVphTFZWTkpvbDZTNDhYQW5mWU13YmZ2?= =?utf-8?B?aDNBYUYwQktNbVo5QWtwNjFDYWt4U3RFQmxQN01EWm9Jc2lNYzcySmRxdmlR?= =?utf-8?B?dlJ1L2FrcEdSM2VjUmVaSVZEREFta2Z2aUN6WmY3VXZSc3dSODZJZFNZUmtM?= =?utf-8?B?eEt1U0o4eUk2aXRnSjB4ZVAvT240eEFraHhTTWlxZWRhckdhOHNyQ3VidTRJ?= =?utf-8?B?Q1hnSmJPbzJ6NlgyY3lOOXZpZTFBVS80YzNOVklteWg5dEJTV0xmd1BwOUNH?= =?utf-8?B?bmdvcTgwcFJkWTlMVHBJbEFlMHFGMVlhZGZaaEdTTVlBeGp5ZjhjNC9nZCtM?= =?utf-8?B?Q1hQNm55TmlMYk12aUZYeHdlTm8xcUJSWmpsWFdxQmpKbHM0ODc3UG8rMG9G?= =?utf-8?B?a2RleTEySU12OEQxemlMY1NyWm1TaUlOR1dsaXFQY2U0aE13N09BeWd5T3Ro?= =?utf-8?B?dmJtZ2tTVDF5SnU0Rm9rWHdKbzZwRzJDUEd2My81d0tjTm9mT1gzYnRrSWJN?= =?utf-8?B?c2V3WXdIRFVzRG5EWGpzK3RDN0g4eWZVRmVIdFE2eHBZcExFcm9td2dVUysy?= =?utf-8?B?bHR3cDR0eW9UNS95ajZ6RGFVOHBHc296WjNnbnI5NVIzMXNvUTN5VGtkSTd2?= =?utf-8?B?d0tTRGFKQUdkVk1EOG5MWXE3TGw3cVJ0dWhuZDdiZFFUM2RsdWN3dTJSNGVI?= =?utf-8?B?ODJBSVZ4N3plcWJpL0RYenkxc1hpTDk3b1poU0hhQUg4a25rNi9JbEtTYVd4?= =?utf-8?B?M1lsTWlSdm9iVmJ2OWNHWFJpWXNIWUloby92ejVqM0VOZjJndm44aVZ1YVlE?= =?utf-8?B?c0MrbzVXWlVGMU9hTFpJMG9oVE52MmRoNXpBZjVMTVdtT3hKV3lzMi9EK3hB?= =?utf-8?B?bGc0ZjBMY1lkNkUzbFFEamp1VUx1Z2JMdG1EdkN5azRTbkVqT1REYU1nNWFJ?= =?utf-8?B?MURaeWVTRkU4YjRidFdrTFpLakRzWDZ0Mnp5T0ovd3IyeUV3N3NFSDQrQ3dW?= =?utf-8?Q?+z9hYBEyNKcbO2utk/gwbtIc2BA8bGaDnPZK6xK?= X-MS-Exchange-CrossTenant-Network-Message-Id: 62396a62-fd03-4077-3964-08d8ede286c0 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:00:45.3983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /vrQ9KfsTgcxLzCHRgoOq6tIsf1pxZDIXJTppdHgFKQI7JDZ3+BqwwaMbMC753NFfAoELZxuCYoBT+4/Lr63Bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 X-OriginatorOrg: citrix.com Introduce a helper to update the MSR policy using an array of xen_msr_entry_t entries. Note the MSRs present in the input xen_msr_entry_t array will replace any existing entries on the policy. No user of the interface introduced on this patch. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 2 + tools/libs/guest/xg_cpuid_x86.c | 65 +++++++++++++++++++++++++++++++++ 2 files changed, 67 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 2143478fe4b..46f5026081c 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2616,6 +2616,8 @@ int xc_cpu_policy_get_msr(xc_interface *xch, const xc_cpu_policy_t policy, int xc_cpu_policy_update_cpuid(xc_interface *xch, xc_cpu_policy_t policy, const xen_cpuid_leaf_t *leaves, uint32_t nr); +int xc_cpu_policy_update_msrs(xc_interface *xch, xc_cpu_policy_t policy, + const xen_msr_entry_t *msrs, uint32_t nr); int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 13c2972ccd3..07756743e76 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -1033,3 +1033,68 @@ int xc_cpu_policy_update_cpuid(xc_interface *xch, xc_cpu_policy_t policy, free(current); return rc; } + +int xc_cpu_policy_update_msrs(xc_interface *xch, xc_cpu_policy_t policy, + const xen_msr_entry_t *msrs, uint32_t nr) +{ + unsigned int err_msr = -1; + unsigned int nr_leaves, nr_msrs, i, j; + xen_msr_entry_t *current; + int rc = xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs); + + if ( rc ) + { + PERROR("Failed to obtain policy info size"); + return -1; + } + + current = calloc(nr_msrs, sizeof(*current)); + if ( !current ) + { + PERROR("Failed to allocate resources"); + errno = ENOMEM; + return -1; + } + + rc = xc_cpu_policy_serialise(xch, policy, NULL, 0, current, &nr_msrs); + if ( rc ) + goto out; + + for ( i = 0; i < nr; i++ ) + { + const xen_msr_entry_t *update = &msrs[i]; + + for ( j = 0; j < nr_msrs; j++ ) + if ( current[j].idx == update->idx ) + { + /* + * NB: cannot use an assignation because of the const vs + * non-const difference. + */ + memcpy(¤t[j], update, sizeof(*update)); + break; + } + + if ( j == nr_msrs ) + { + /* Failed to find a matching MSR, append to the end. */ + current = realloc(current, (nr_msrs + 1) * sizeof(*current)); + memcpy(¤t[nr_msrs], update, sizeof(*update)); + nr_msrs++; + } + } + + rc = x86_msr_copy_from_buffer(policy->msr, current, nr_msrs, &err_msr); + if ( rc ) + { + ERROR("Failed to deserialise MSRS (err index %#x) (%d = %s)", + err_msr, -rc, strerror(-rc)); + errno = -rc; + rc = -1; + } + + out: + free(current); + return rc; + +} -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:07:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:07:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100594.191818 (Exim 4.92) (envelope-from ) id 1lOdx2-0000r2-AA; Tue, 23 Mar 2021 10:07:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100594.191818; Tue, 23 Mar 2021 10:07:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdx1-0000qf-S7; Tue, 23 Mar 2021 10:07:51 +0000 Received: by outflank-mailman (input) for mailman id 100594; Tue, 23 Mar 2021 10:07:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdqu-0006c2-0R for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:01:32 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f16194ae-ec35-4ed3-b1a4-6f099349c7ba; Tue, 23 Mar 2021 10:01:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f16194ae-ec35-4ed3-b1a4-6f099349c7ba DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493675; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=1EygkQFfjIgzk70hWDFj486ZCtXSbCWYNcvm9mmxDMs=; b=Ozf1uIghngk8r8/WQZzbn5RV8psjuMy/Pl1KGGqBZ3yWSIxtd45EDBPo 2wZPcOpozEnsXs/+QR/df0Py6tj/Ln/eLgTwmbwTSrtYsq2J65XSPysIP wJ7rnLgkvrRzG1bt/XrH/8GM2neRigGXjOTuRaAW7ZQlKFLh18EIVKZFe A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: NQY0My0O2GTCI50doOMF5gq8KBDD3yXc98SAgRgzFcAACwc6URUBy/b9tDkemfQ5W2d+Ca+UIo 4g08jRE+YorRqj3rsgkYbw7anf9T2qXm2LqQhgRaEhK14eF5s+wWvtLDC1c0XhENjYwdzCW+eY 0hsVRlT07bLd09UmCyuBi73CIKDudwdmN6OlbnSYj3Hlflj1cwChhvrRky8Z4c6WyYP9UVmdRA YYQ8Z0ePN72+k4NByzRgCQ8Q3qf66p4Dpw1iSARIfwBJedFty5yMDRt79FcZ82vGU0cxa4KE00 PRU= X-SBRS: 5.2 X-MesageID: 41330479 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:4LTdkah422CH3SSo7lssrytgqnBQXzxw3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+csFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmup tIW5NVTOf9BV0St6rHySGlDtctx8SG+qi0heHYi0xgVx1udrsI1WdEIyywe3cGIzVuL5w/CZ aa+457vDKmY3sadYCWAXMCUujFqbTw5e/bSDQBAAMq7xTLsCOw5NfBYmKl9zo9cxcK+7ct9m DZjxf0j5/Dj9iXwgLRvlWjlqh+t8DmzrJ4damxo+w0DhmptQqyfoRmXNS5zUEIicWi8kwjnt WJgzpIBbUK11rrcmu4oQTg1mDbuV5EgRKSqi778AjeiPf0WS4gDI55jZ9ZGyGplXYIhs1206 5AwguixvxqJC7H9R6Ng+TgZlVBk0q5pmcaiugDj3BTept2Us4vkaUvuGxSC5sOByT89cQOF/ RvFtjV4LJsfUqddG2xhBgj/PWcGlAIWjuWSEkLvcKYlxBQgXBC1kMdgOgShG0J+p4RQ4RNjt 60fphApfVrdIs7fKh9DOAOTY+cEWrWWy/BN2qUPBDOCLwHE2ilke+33JwFoMWRPLAYxpo7n5 rMFHlCs3QpRk7oAcqSmLVW7xH2RnmnVziF8LAR27FJ/pnHAJb7OyyKT14j1+G6pe8EP8HdU/ GvfL1MBfvOKnbvBJZp0wXyV4I6EwhcbOQl/vIAH36eqMPCLYPn8sbBduzIGbbrGTE4HkPza0 FzHgTbFYFl1ASGS3X4iB/eVzfGYUrk5699F6Dc4qw2wIgJPYtcjxgNhT2Cl4S2AAwHlpZzUF p1IbvhnK/+j3Kx53z042JgPQcYKUpJ/rP6UTdvqRURO035NZYP0u/vNlx67T+iHFtSXsnWGA lQqxBc4qSsNaGdwigkFpaAKWKVj3waoVqQVJcCkqi/5cPoE6lITqoOaehUL0HmBhZ1kQFlpC NocwkfXHLSETvolOGYlpAOPfrecNN9mQ+vBsZRpRvkxAGhjPBqYkFecy+lUMaRjwprYzZPnF V+/5USh6e6lS+1JXEyh/k5N1NweH2aaYg2fDitVcFxoPTGaQtwRWCFiXihhxY/dnHD2m8Sim biRBfkMc3jMx54gDR1w6zq+FR7eiGhZEp2cGl9qpA4P3/BoGxP3eiCYbeT32OdZkAZ+PwUNC jIbFIpU0RT7uHy8CTQtCeJFH0gyJlrA/fUC647darPnlyqM4+FmMg9bohp1acgEOqrlOAFUe iSIVDIaBz5Dv4kwAyTqDIOPjJupHwtjPPv31nE4QGDrQsCKMuXBG4jYbcRZ+y4xSzDYd2j1Z 1il9I7veeqKAzKG5e74JCSSwQGEw/ZpG69cvohpp9Vt58jrbcbJeiobRL4kFV8mCgkJMj6lE kiUL12zbDINIhoZdETcUtijy4UveXKCEMqtwDsa9VOBm0Fvjv+P9mT5aDPpqdqKkqdpBHoMV 33yVwXw971Gw+C36UdEaQ+PCB/b1U98m1r+Kene5fLAAunM8FF81zSCA72TJZtDIyEE64XtB B0/pWhmPKWbTPx3ETohgRAS5g+hVqPcIeVGwKDGelB7ty8NxCtu8KRkbKOpQaybyC6ZUQejZ BCbmoKYK14+38fsLE= X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="41330479" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dCuQPHeg6JqoE6NklkPVLu3VK6h41XTdKg4McfqMVdrErhRctf/D0kc1b+GewHJC21Dk6hOYiYQOL+79DGncRQ3HJ8RqZSrpSrQgFONVB8rs0T00QbE534Y0ioUDGyNtrb6LRGp1gc16Z+ypxFoUaWwaDlIZYyH4frd+UWYBt9ieuVabIwCe290qLwX6JxfwxAfjnKWoN51lfcGpO+XAoNV4hxBofioHG030kXQngI9jBkShmMhNvPVIkShAr7lpAbEAuCr6lwBwe/H/TKifI+ioatiQ1Ib/Uuh/hm2ZCHgGXVmvmvS7DFa8jgg8cPZxfPBsyLaWFuPfqhuQx+MT6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3MzCUu7d0phi773fHzIkL/rm9IU1nSr6FRF/o5rScJg=; b=TVKbzCYhenaWvFpc6PdNjtAnucSibiYuNFjy7C0cwUyXeBotZFY46LguerAXPD0NUMBVgOKl88EHaJ8qtTfJQ0dWEW9mlU41wW0QuMgm4Kr+eE38zQKdRUGwR9dG+fEwn1b9ncHohKkvSLbuSEFVBl1Ksmy/e+KmuaiGXJMkfwyWg1n2ho/7pHeHQxIDhBeIySMgD5aWohywOuluRc/gCq6cODICaweG5Q6YHpGq6m4iZaUPZZ18UMtnYmQVHsvDrhFE4QOR9dPz9x58724LD/k8RPpNJ1+i24iguuySzYVhzCYLCbdl1C2RmGcae7QVa/QDRqdLFAlfSr5wFs2m6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3MzCUu7d0phi773fHzIkL/rm9IU1nSr6FRF/o5rScJg=; b=Xa9npiAV6uK6jTWtRpIqa1aONDIoaGhr4Tmap86YOfTz2m9g+SCbMzuhsQJh+idR4xkcZfZmzP/9Bm9T5snqqciDtdcLn6GWHlxlOI6KZFd7sZ5QD7S5e7ZUsuFgySHTQ77/Ahrt+SDBSM62a2smG3/Je2MBwA854zCdp3f7O7I= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 17/21] libs/guest: introduce helper set cpu topology in cpu policy Date: Tue, 23 Mar 2021 10:58:45 +0100 Message-ID: <20210323095849.37858-18-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0124.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::16) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bcdc9994-d0a8-4d2e-bed0-08d8ede296d1 X-MS-TrafficTypeDiagnostic: DM6PR03MB4969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1169; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OjpgtelieldLbBdROZTbEjfus8q7GciP81K5nh+0tGIUI2iyvhtqM67RkthUbUgxX0PG8+wiBwE4+mig5iGhdlCc3KQvH6f4X901XQhtdsPgciCOuHm6jMl059Ee5325cd6707Ci9OsAL+myvIefOQjgzrZqfeV6FCfbv4SLjOMD1rWxOYuwFXBoRExJOf1Csp02xSiUyiI7LjzSuDed4V74WUB0DVhU+5AUAi5YEefpjLz9l18RDEv+EE7lKpxeKc5mUZxOHHcYBcptr7nAoRnyDxMYsQ9dLIel/9p06qJ4JrIt+K/iup6TBmFIKmfS+C73Kn1mkYtDo7q1E4FY0jq1kS5/PUcFzlxTMJbIP6HgCkYHA3uzg9eme8ouqS8IES9ERekwkYvqqiDeG1CmRh++o681a8foKeXrljyIbS19gaMyDOTfBEEGD7siHESGT3QEdLncjgW17UNRgFjiNMPsz7wZYA4/bVSV/BmCjOcZCBdKIDkPmFsrz38P/flCGmyfP68+sN774xBtPtG+TPByTRILOLpm7cEC39KeuNqev031acuKTFFN/oF4CK57jtIoSZ3MpwTBcfV88DEDSsK++DZuw+X9oilM4v0MfAYGmd866WUCObvNZVfy9yoNZsWeufT3lEYKf75KgX9qZg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(54906003)(36756003)(2616005)(316002)(26005)(6486002)(956004)(16526019)(186003)(2906002)(86362001)(66556008)(6916009)(478600001)(5660300002)(8936002)(6496006)(38100700001)(83380400001)(6666004)(66476007)(8676002)(66946007)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?RHdYUFZWNmx3bERNVUVoSVl6YUU4QjFmVU1ZdXFWamR4WXdhdXM3L1BLM3F4?= =?utf-8?B?dW9FWXZhUGY4NXpKQ1BOdG1sdThCQXZUbkJKR0pHcDYxeXoySnUyNm1mbCtI?= =?utf-8?B?RXlkMllncEQ1T2ZCU3JyaER2TS9YSEVwSDF2YTlvSFN2bnRKZVJ2d2VHNkwx?= =?utf-8?B?Y1ZjbkFPTDFyNHozYzB1d1AvdS9kWWY0ZG11Zmh1T3I3Z1ZZblRHc0VXcHkz?= =?utf-8?B?WTZ5ZE0vUzVyVGhhOUN6TkhKV3NmbmRDSTlVOFNaK3ErckpTUkhhWU5ZR211?= =?utf-8?B?c3R5MFpLMEdNYTlWTlNtMENURkVmV2xsbk9IZlF1VzFuR0hCbDdreVJLQUE0?= =?utf-8?B?Z0xEVGFVcUhYSVQ2WWZxNW5FOW41WTdkeVRKMEt3cjVlM3U0WUYwOVQ0Tlo4?= =?utf-8?B?YWNLL0dCWEVHdm1QNXNtSW9qZ1lOM29jZkdxUmwyQzhhK2RMSjk0bjQvc2x2?= =?utf-8?B?UFhwcDVOQ0MwcGczUEF0c0ZLVGJYTCsrQVJuRXlnQ0JMYlVUbFFvYldkVnlN?= =?utf-8?B?NzU3bmdHSXlJYWdvNlhuR1J1QlhSdGpHY2NFcURabzhrZVFIMzZsNCttbXFm?= =?utf-8?B?SjBSM2RDMDBNdUV4QXJUSEpYa3Z1eWtYS1Mxd2JaYk5aRlZwaUZpekIwbzRR?= =?utf-8?B?bXBHb0R3UG01dGJ4TGJCOTBxVi96d1ZsS1E2TTFhUGdWVVcvUm5VVi9tK21X?= =?utf-8?B?L3dwMnBUUmpOK0FkNC9UUzY4dENETWtld2NQV3Ura3ZLSktKaVVSSytYUnpH?= =?utf-8?B?TFU5c3hJcDg1ZUdFSlJYMVhwL1AvM2V2MlU3enRDRzltS1k4Skh5dkV4K1BZ?= =?utf-8?B?bWhhbUdRZzV3QlNUeE5IZXFmeGVnb2xUQnVtVHE2Wjg3ejRFR0s0MXhPT25E?= =?utf-8?B?ZEp5cytWMTdpRGVPQzdCYk5NQUxhbVBrTUNSV21qWXo3VFd6QURXeEpCNytD?= =?utf-8?B?d3JFcGxSOWJZWnV0ajVwUktwdU4wbUdRRkNDNEFJMU8yUVJxSnVOa3IyUFNw?= =?utf-8?B?b05XdHBQaG5JOWRXbkIvU0lFOHBCTzdtQmZRSmp3b3U4bFNGVC9YZjlCRkRE?= =?utf-8?B?KzBUSzJuaTBaeXN4cFFtZTJjUFFxMGo1ZGNMVm1hZ2ZRYVQvSDhQUDI3MWVZ?= =?utf-8?B?QWhDeDJET2U0RFM3M0F6NGdxWmh1UFYveGhxYUFQN2hZT2ZEdVlpK1R6dnNI?= =?utf-8?B?NDM2L1FKM05sTVFiWHRjZjVrVGZrOUhzRDc4VjlNVnFuS1Urd2xmM2tUaUJS?= =?utf-8?B?RkNnSlRyOVB2b01wdy9FK2RzcXA1OURpaVVJbTVQZS9MTWhrdllIYmRsZk1Z?= =?utf-8?B?Q21rNVZUbmpYYjJZai9kUHlRNnlSeXB4cU9JeGFmUDM2d2hRc2ZCcFV3bkJs?= =?utf-8?B?WUYvWVpVcDhCZkxVWXN3Wkp3YytxbEVUV0hGVXFadHVISDc3aGlsN2F5aGs1?= =?utf-8?B?WVdPclhETVVtR3RReG96RDkvbUdPRmY2cU9EaXUwbWIwUXlwWjVRSG5XYlpn?= =?utf-8?B?UHo0aTRvTWpYTlFsS3pMcnc5WU0vVm5CVldMWnhGR0JiTmVad1ZGdzZ0SWpm?= =?utf-8?B?M1NBeVpXQjhaNGoxZm5OcnpVQlNST2lDU21ISFN6a2N6aEJPTGlYVFMwOUNF?= =?utf-8?B?d2xqaE1pdmZ5MlJWektvazlQL1paeDZ0RHV4cVk3ckdla1ZWY2dWS2VmMnZa?= =?utf-8?B?dDJ6MklLVmJYUWNoVGpWWFI2Wm9OUmFLQ0tmNlIrZURleEVpbFNubmlCcE9o?= =?utf-8?Q?Ek3SvCfBTvj2SyVnnlORYc+uVJUg7E3eaMFqOTV?= X-MS-Exchange-CrossTenant-Network-Message-Id: bcdc9994-d0a8-4d2e-bed0-08d8ede296d1 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:01:12.2650 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qr+n25OsKlMfAzUVif74wCKJoREMdwoeesqWrY+glNBwqpb+t02D+zE6kdo6mrL197HOyxSCmUj01XgzZ1DWbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 X-OriginatorOrg: citrix.com This logic is pulled out from xc_cpuid_apply_policy and placed into a separate helper. No functional change intended. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 4 + tools/libs/guest/xg_cpuid_x86.c | 181 +++++++++++++++++--------------- 2 files changed, 102 insertions(+), 83 deletions(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 6f7158156fa..9f94e61523e 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2631,6 +2631,10 @@ int xc_cpu_policy_calc_compatible(xc_interface *xch, int xc_cpu_policy_make_compatible(xc_interface *xch, xc_cpu_policy_t policy, bool hvm); +/* Setup the policy topology. */ +int xc_cpu_policy_topology(xc_interface *xch, xc_cpu_policy_t policy, + bool hvm); + int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, uint32_t *nr_features, uint32_t *featureset); diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 2abaf400a2b..d50822c0abb 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -433,13 +433,11 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, { int rc; xc_dominfo_t di; - unsigned int i, nr_leaves, nr_msrs; + unsigned int nr_leaves, nr_msrs; xen_cpuid_leaf_t *leaves = NULL; struct cpuid_policy *p = NULL; struct cpu_policy policy = { }; uint32_t err_leaf = -1, err_subleaf = -1, err_msr = -1; - uint32_t host_featureset[FEATURESET_NR_ENTRIES] = {}; - uint32_t len = ARRAY_SIZE(host_featureset); if ( xc_domain_getinfo(xch, domid, 1, &di) != 1 || di.domid != domid ) @@ -462,22 +460,6 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, (p = calloc(1, sizeof(*p))) == NULL ) goto out; - /* Get the host policy. */ - rc = xc_get_cpu_featureset(xch, XEN_SYSCTL_cpu_featureset_host, - &len, host_featureset); - if ( rc ) - { - /* Tolerate "buffer too small", as we've got the bits we need. */ - if ( errno == ENOBUFS ) - rc = 0; - else - { - PERROR("Failed to obtain host featureset"); - rc = -errno; - goto out; - } - } - /* Get the domain's default policy. */ nr_msrs = 0; rc = get_system_cpu_policy(xch, di.hvm ? XEN_SYSCTL_cpu_policy_hvm_default @@ -564,70 +546,10 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, } } - if ( !di.hvm ) - { - /* - * On hardware without CPUID Faulting, PV guests see real topology. - * As a consequence, they also need to see the host htt/cmp fields. - */ - p->basic.htt = test_bit(X86_FEATURE_HTT, host_featureset); - p->extd.cmp_legacy = test_bit(X86_FEATURE_CMP_LEGACY, host_featureset); - } - else - { - /* - * Topology for HVM guests is entirely controlled by Xen. For now, we - * hardcode APIC_ID = vcpu_id * 2 to give the illusion of no SMT. - */ - p->basic.htt = true; - p->extd.cmp_legacy = false; - - /* - * Leaf 1 EBX[23:16] is Maximum Logical Processors Per Package. - * Update to reflect vLAPIC_ID = vCPU_ID * 2, but make sure to avoid - * overflow. - */ - if ( !(p->basic.lppp & 0x80) ) - p->basic.lppp *= 2; - - switch ( p->x86_vendor ) - { - case X86_VENDOR_INTEL: - for ( i = 0; (p->cache.subleaf[i].type && - i < ARRAY_SIZE(p->cache.raw)); ++i ) - { - p->cache.subleaf[i].cores_per_package = - (p->cache.subleaf[i].cores_per_package << 1) | 1; - p->cache.subleaf[i].threads_per_cache = 0; - } - break; - - case X86_VENDOR_AMD: - case X86_VENDOR_HYGON: - /* - * Leaf 0x80000008 ECX[15:12] is ApicIdCoreSize. - * Leaf 0x80000008 ECX[7:0] is NumberOfCores (minus one). - * Update to reflect vLAPIC_ID = vCPU_ID * 2. But avoid - * - overflow, - * - going out of sync with leaf 1 EBX[23:16], - * - incrementing ApicIdCoreSize when it's zero (which changes the - * meaning of bits 7:0). - * - * UPDATE: I addition to avoiding overflow, some - * proprietary operating systems have trouble with - * apic_id_size values greater than 7. Limit the value to - * 7 for now. - */ - if ( p->extd.nc < 0x7f ) - { - if ( p->extd.apic_id_size != 0 && p->extd.apic_id_size < 0x7 ) - p->extd.apic_id_size++; - - p->extd.nc = (p->extd.nc << 1) | 1; - } - break; - } - } + policy.cpuid = p; + rc = xc_cpu_policy_topology(xch, &policy, di.hvm); + if ( rc ) + goto out; rc = x86_cpuid_copy_to_buffer(p, leaves, &nr_leaves); if ( rc ) @@ -1257,3 +1179,96 @@ int xc_cpu_policy_make_compatible(xc_interface *xch, xc_cpu_policy_t policy, xc_cpu_policy_destroy(host); return rc; } + +int xc_cpu_policy_topology(xc_interface *xch, xc_cpu_policy_t policy, + bool hvm) +{ + if ( !hvm ) + { + xc_cpu_policy_t host; + int rc; + + host = xc_cpu_policy_init(); + if ( !host ) + { + errno = ENOMEM; + return -1; + } + + rc = xc_cpu_policy_get_system(xch, XEN_SYSCTL_cpu_policy_host, host); + if ( rc ) + { + ERROR("Failed to get host policy"); + xc_cpu_policy_destroy(host); + return rc; + } + + + /* + * On hardware without CPUID Faulting, PV guests see real topology. + * As a consequence, they also need to see the host htt/cmp fields. + */ + policy->cpuid->basic.htt = host->cpuid->basic.htt; + policy->cpuid->extd.cmp_legacy = host->cpuid->extd.cmp_legacy; + } + else + { + unsigned int i; + + /* + * Topology for HVM guests is entirely controlled by Xen. For now, we + * hardcode APIC_ID = vcpu_id * 2 to give the illusion of no SMT. + */ + policy->cpuid->basic.htt = true; + policy->cpuid->extd.cmp_legacy = false; + + /* + * Leaf 1 EBX[23:16] is Maximum Logical Processors Per Package. + * Update to reflect vLAPIC_ID = vCPU_ID * 2, but make sure to avoid + * overflow. + */ + if ( !(policy->cpuid->basic.lppp & 0x80) ) + policy->cpuid->basic.lppp *= 2; + + switch ( policy->cpuid->x86_vendor ) + { + case X86_VENDOR_INTEL: + for ( i = 0; (policy->cpuid->cache.subleaf[i].type && + i < ARRAY_SIZE(policy->cpuid->cache.raw)); ++i ) + { + policy->cpuid->cache.subleaf[i].cores_per_package = + (policy->cpuid->cache.subleaf[i].cores_per_package << 1) | 1; + policy->cpuid->cache.subleaf[i].threads_per_cache = 0; + } + break; + + case X86_VENDOR_AMD: + case X86_VENDOR_HYGON: + /* + * Leaf 0x80000008 ECX[15:12] is ApicIdCoreSize. + * Leaf 0x80000008 ECX[7:0] is NumberOfCores (minus one). + * Update to reflect vLAPIC_ID = vCPU_ID * 2. But avoid + * - overflow, + * - going out of sync with leaf 1 EBX[23:16], + * - incrementing ApicIdCoreSize when it's zero (which changes the + * meaning of bits 7:0). + * + * UPDATE: I addition to avoiding overflow, some + * proprietary operating systems have trouble with + * apic_id_size values greater than 7. Limit the value to + * 7 for now. + */ + if ( policy->cpuid->extd.nc < 0x7f ) + { + if ( policy->cpuid->extd.apic_id_size != 0 && + policy->cpuid->extd.apic_id_size < 0x7 ) + policy->cpuid->extd.apic_id_size++; + + policy->cpuid->extd.nc = (policy->cpuid->extd.nc << 1) | 1; + } + break; + } + } + + return 0; +} -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:07:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:07:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100599.191833 (Exim 4.92) (envelope-from ) id 1lOdx9-00015Q-OU; Tue, 23 Mar 2021 10:07:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100599.191833; Tue, 23 Mar 2021 10:07:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdx9-00015I-HW; Tue, 23 Mar 2021 10:07:59 +0000 Received: by outflank-mailman (input) for mailman id 100599; Tue, 23 Mar 2021 10:07:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdqU-0006c2-Vx for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:01:07 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0a5c9fe9-1791-4d4f-85cc-967c23b49b1e; Tue, 23 Mar 2021 10:00:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a5c9fe9-1791-4d4f-85cc-967c23b49b1e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493644; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=qezkb5E4ymN+jRIlFBx+OAG/L1HX+dmHCgIuqcfRKoQ=; b=MXz+aJImKURbM9QBL+DAaaTQDgqjNN5Rfb3Wkrh9dkSD1gzfXqHmISPA 2e96Tr2rL37warFiuAKze3wiayqIgqwZ/Ehfrp6PGWv8IeEvLwHVGxDB+ 9BhfgLwvp7AavaaAydYK2ZUULXkd9CbkpSToeS7ACnmmPG+vKF/qiM449 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: LRHjG6HXWKVYDE9/hwVYn0xynz6x2T+jpUbtQFhyFRt+iSK5o6PJZ7S58iQEVQDCrJTTA1BDYj 7KE4NoXI/oqrilMuhHKqneXeeLXzRruCgWWUG4WV63q0uCqdCMUdstcjQOjEkT3RfiKKKOCKu0 Xixx6GdxvYNJyAnNG18PoFOae2OGTrpBmrHJD5hPiPSlplJg4tMS3CiwCv1dH0XT4fmANW4ylg 92gMtR+2Zf9dBrMMznmIYNyHdhJrSmMYDaok57u3QtXukM0RyieJl2OAfSX+XkX3cwMYz6EgXW eyI= X-SBRS: 5.2 X-MesageID: 40055568 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:j8F96K59ymp6XOSSWgPXwbeFI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoex/h3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdhHW3tV2kZ 1te60WMrfNJHBxh8ri/U2cG9Ev3NGI/MmT9J7j5l1GJDsKV4hL6QBlBgGHVmh/QwdbDZQ0fa DsnvZvjTymZHgRc4CHFmAINtKz7OHjubDHRVo9BxAh4BSTlj/A0tXHOjWRwxt2aUIr/Z4M6m 7A+jaX2oyCtLWBxgbYxyvv6f1t6b3c4/9iIODJtcQPMDXrjW+TFc5ccpmPpio8ru3qyHtCqq ipnz4aM85+62zccwiOyHPQ8jLt3zo053jpxUXwuwqFneXCWDk4B8Bd7Lg4TjLl6lEttNw58K VH03Pxjes0MTr8nT/w79WNahdylkDcmwtArccviRVkP7c2Wft0l8gy7UlVGJAPEGbR84Y8Ct RjC8na+bJ/bU6aR2qxhBgj/PWcGlAIWjuWSEkLvcKYlxJMmmpi8kcezMsD2l8d6ZMGTYVe7e isCNUlqJh+CustKY5tDuYIRsW6TkbXRwjXDW6UKVP7UIYKJmzKsJyyxLku/umldNgpwfIJ6d v8eWIdkVR3V1PlCMWI0pEO2AvKWn+BUTPkzdwb6IN+vrH6Wbr3ISyOQF0jiKKb0rQiK/yef8 z2FINdAvflI2erM51OxRfCV55bLmRbUMB9gKd6Z3u+5ubwbqH6vO3Sd/jeYJD3Fyw/Z2/5Cn wfGDz6JMBK6FG3Smb16SKhGE/FSwjax9ZdAaLa9+8cxMwmLYtXqDUYjly/+4WMMj1Nsqs/eU NkO7P5mqanpW27lFy4oVlBC154NAJ48b/gW3RFqUshKEXva4sOvN2ZZCRPxnedPwR+SMnXCQ ZboFxy9cuMXt6t7BFnL+jiHnORjnMVqn7PcowVnbeb49z5PrkiCIw9ZaB3HQLXNhB8lApwsl 1fYAscSkK3LEKqtYyVyLgvQMDWbZ1VnRqiK888kwOliWys4eUUAkY9cxHre8iNmgoqTydTnT RKgtUiqYvFoxiAbUYcoMB9Cl1Db2SRDtt9fV24TbQRoJ7EPCVeJF36wwCyulUIVESvzGkpuk ndRBfkPs3jMx5mlF4d7oLD1GlVWwymDgZNQ0E/jKk4PV6DlFxU9sDjXNvq70KYdkYCzuYBMD vMfDsVJUd0y8qq0QOO8QzyaUkOwo8vJ9rZBL8udqu74ALRFKSY0a4BBPNa55BjKZTntfIKS/ uWf0uPICr/EP5B4X3dml81fC11omIji/XmxVns63W5xmc2BZPpUSNbbqBeJ9GX9G7/QfmUlJ 1/kNIupOO1dmH8cMSPx62SbzlNLHro0BiLZvBtrZBfpqQpsrRvW5HdTDvTzXlCmAwkM92crj JtfI1rpLTafoN/dc0bfCxUulIvidSUNUMu9gj7GPU3c10hh2LSVun5q4bguP4qGAmMtQHwMV 6Q/2lG8/DJUzCK2LQaB6gzSF4mHHQU+TBn5qePZofQAAKle6Vf51K8KGa6a6IYR66fG7kcxy wKkO2gjquSbW7/1w/Rtzcgff4L/GajXM+oAAWDXeRP6Me3PFyQgq2spM6/5Q2HOAeTegAdn8 lCc0dVc8FIzj8lh4cz2jKpSqP2rlk++mEulA1PhxrowMy+/GzfHUtaKgXXjZVdQClLPhGz/L r42Pnd0G64/SNM1pbCHlpBZ91CG9AfSY7sMidlQPJgzIKA7u4omSRMYBAnEm46hnT8xopdrM iE5Mk= X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="40055568" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZivyjKQBEOwHlLooMKDAqf6CUffsvfee104m6wGtNCfkSaHOBnXm7NvueKuDLRHoHqMo6KO2nEHUMkQYt/2Y/57s08y+ng65fsgiCsFqt2PV31l6xUL387kf6PPyFexF9xunIbmFFKAL9yAo8T3DTmsw191O0bVPf9SkUB2BaIbMCavnanFnzWxZS8Iah4fIwpDBCQiKSxFuYMRI8g+PzqEn9WuY5+vGOCeJwFMt2ZXRhJM81sBA9RV+gVfaQs0JOoShT6LF8WqD6z9+2yllMhj3GV0zu0tCobVbNxEv45o6mK2N/PuV2PjCrWWL9/doUDCiS5ldO5rszj784G6k1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VUfWBdInOKZs5Um38UoLo/Lo9GJ2byqnYqx1gF9ZJ6M=; b=cGabuRCSEPAl9Cb7vL/2OQNC264wpsjMAIhDowdVM0jHXuNGO152K7Gw3w8GKNmaV0tcPk9qJHovMXgn/5G6oSma3aE7t7eYFNLrU/uJ8K2q12G3rj/YDTHCfSjFjlXm+fheAk0GvcHI15daiQzdSQr4uCPUq7k9n9TDg7vPI8drk+KL84vStfn9HTbmAEocwtdA+/iZdfr7svNXmOBAJCIpcqhbpZkKa406m2dMvIyp2jz7F7FB82jdEYDx87mMoQDZf9/W4Yw2+igZNR/j17cTdkzh5OJ1IfOaaVYUinTfD9bTUr/3m8m+UGzz57jSFyVZHDjT51NE5vlvM7cl6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VUfWBdInOKZs5Um38UoLo/Lo9GJ2byqnYqx1gF9ZJ6M=; b=IclS5tlY5MpOhs7CuC4Mu/MZ2Hjx3guV62AzITTHaZzK2brBtQhv59RKfjcIuaRmw0Ln/vccd9BgHcQyBaB8eOFAFVa0myvBPnY13OKpe/rsdgmW1HfeGQUHM7wyxiIxATp9mINhykYmE4/2+X592w8XqNRpT/oiAatTKaQMSsc= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu Subject: [PATCH 11/21] libs/guest: allow updating a cpu policy CPUID data Date: Tue, 23 Mar 2021 10:58:39 +0100 Message-ID: <20210323095849.37858-12-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0110.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::26) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6cd1d566-7a4d-44f8-6435-08d8ede283ed X-MS-TrafficTypeDiagnostic: DM6PR03MB4969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kabRokzitRcDEOrGYV4IS+JvR4i+ZKC6/p/H00wwp9o7GVXn25jax+YYMSQ+E1ZqJ+6s5fEgOyez6VGR/iQ1BSUm3qHNCqhRPEJ7K5lqjB7LITGC/CHV9vwIxp8IXdppMvRIGH0wc0L6YbGy7bM2nn4ipb4rOz34Cyk5Iy00D2uG+f5kcGPX4GVM/s+pz0xdOXhkqP6LB4mD782PPlao8oojwtEWKsK9aW81f/qvXrBLlTMSCBIgC0nZ+6Nv2Ag03feNIv/62XibjgetPSLqNUygi2cpkpMKKdt2L+AMTd6NMx7psI5pRUijn7eVjUTH8C8cU9sKIAair7qsfli2utMAo7jFUmjdwFaGOHERmSL8FifyhBFmeHgS/8ZXXMyYZRhougn1Q7/bi0RJXOApULoLqBSFGHHBMEZUEiWuGi1n0VnWfuTokCHzdv0XlOcTPJLdujCRGi6MwHg5zJLXvbCXcrwPeb9NzlkCoYXcYds+2OzPr2hawv0yqwQSGLb8MXrbtjnTaCN8JhIk1y3zbFx9bbtgVsqh3CUAutxZ77xN1kH/h0GYTjAW1PNFcG8s1Mmq4uy92GZf65bt1fftbD9V9yIXBhyNO62gWMHRMHUlKwNe5J/iziawt1MpLAuW9NFhTpig+GdTwPbrXSojhEEjFOFzzRBN+OtNrWwTKkY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(54906003)(36756003)(2616005)(316002)(26005)(6486002)(956004)(16526019)(186003)(2906002)(86362001)(66556008)(6916009)(478600001)(5660300002)(8936002)(6496006)(38100700001)(83380400001)(66476007)(8676002)(66946007)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VEhBWVhTUGVTQ0ZVL2lLVVJPaEhlMnZiQnRRbENBaDBUVTkwZFc0YlVENzVN?= =?utf-8?B?OFNxaWhjWlJtUUdqbGVqQk93aURnQy9KdGczSUMvVmNGczNrTzhuR3dLSUxY?= =?utf-8?B?RTQyczdHOWMveFRaQ1ZjZVBuZWlYRVFkQzhtWFZwRDRCR3pKQ3QxSHVEN0Zu?= =?utf-8?B?dXV3T09wYTc5ams0ZWQ1TGFxcXdkaXFhV3kzenAvYXhUNTExZlB2SHd3ejYr?= =?utf-8?B?VTdpVlgzb0haMHA4MzJ4WThjY2J0SS9sQjg4eWlCcmh6anhxTzkySzg0YWcw?= =?utf-8?B?enJaRzc3cThQaXFuT1JnL1dlZDRzRFhhUlVxVlluV2hHd0ZwS3VCL3QrNEI0?= =?utf-8?B?L1VNZWlhVjFVQXV0Z1VoekFyekRpbm10QmlydWhhWEdiWkRPalRZZitUbGlz?= =?utf-8?B?c0k5RzVBeU40UEdxTnJ5MUJHWHVNb2p6eTVJdXMrWkNCaEpFNExBSGFIM3FC?= =?utf-8?B?Um5mcld1d3k0dERJTk5ESGgzS0NaMmx2NE15Z3l5TmZsOEZDamswaFFZbjJ2?= =?utf-8?B?MVdCWEtRQXE4RHVobVByNEhDb2tFMzJuMHNWWDNlWGpTLzVqMVpBTzgrR2hv?= =?utf-8?B?R0JzTEZkcExaNFFkcEMyUCtsdTN3aEovZmVNVDR4dUhDWDV1azlKS3ovcGV0?= =?utf-8?B?YzVQRVlWWlE5d2dWb09FTzZKdEdkZFhLbXorZkZ1Q1VEV0xPNDlMZm1nMi9N?= =?utf-8?B?MG9MRUNDM0ZWWkhoNVllc21aQ3dKRzVNOVFhaHlQVkhrVVVKMEtlcGNOVGh3?= =?utf-8?B?RkI1OTVWMUp3WWQxNVhJVUR3NkNHNkxPZ0YyZ3ZRS0wrSkQyaXZreElyMTZl?= =?utf-8?B?RnFudnN3MXR5VUNtTjhwVE5RRlJjeWMzenNGNzR6TWptK3Z2SVV2S1ZGVGxO?= =?utf-8?B?LzB1RnplWG53MDU2aldQM1d4OTg4WmhHKzBibHZJTk9IaWNLNEdONkcwV0Zw?= =?utf-8?B?RlphU1cwMVVrb0xSczVYQVFEbU9adjFwL0Jkazg2OHg1SW5reGxrSmU1Ykk1?= =?utf-8?B?RU4xdk9tZ0RNRTlKZi8zTHlOZTU4T2ZOTGY1UEUzcjI1bHlremdibW4zRTdR?= =?utf-8?B?VDJrdmx4bjJ6Nk1Mdi9UUEN6dkVSME5jRjJYeHBHcnR5dzhvYVNTTUpxRjZF?= =?utf-8?B?WkNDMkhjSzdKWnU4cGRacDUyemZyQ1QwSEs5R2JRMC9rcU9RYXFtb3dDUWtm?= =?utf-8?B?U1dPRndERmhuL09oU3lKc00reDFyME1OR0ZhdlltM3JDQURyZkIvTEc2aDFl?= =?utf-8?B?czZIelA0elQyaGVtS0ZwUFdNUTdXVFEzazBvQU1SOG1kaXRwRzM0QjNIalJZ?= =?utf-8?B?ZkVHenN4Qys5bzF2bUhSNnBjMDBpS09MMnI4SFh1aE9qemM5dmtvQ0YzVlZ2?= =?utf-8?B?cUhBUEZUcmZmVFlzMGdzL2ZpaVI4US9WeWxramc3VFNXZ2dVdXU4SkhBdXhy?= =?utf-8?B?aXZyeEJmdE44WWE2MENEOWs0OFhyQ3g4T0pBYncvekpZTG0yaVhPRTVQV0NF?= =?utf-8?B?eDZydU53TEFnUU54by9aTWNDZ3dDT3JqUzkwZGxndC9haTdXVVhtY0JFeWhx?= =?utf-8?B?RTVPYW9jcm1DMmlZOVJCQno5MU8xVzdtemx2MXZnUStWTGNWVVQ1dHV6b3dC?= =?utf-8?B?K0xGejBsTFdXK3N5QTdQbmxSN1RuUWt2bHVqVms5SGpOSVZib0xEWlZ6aWI1?= =?utf-8?B?a0ticW5vQUlWalZSYjc3T1RFS2tubXlEcGZnQmx1MUZCVlQybDlGL2o1M204?= =?utf-8?Q?Jzo7DxEt6hrXK2KuQmlwNhrOxv3ty9WC0/BgmAk?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6cd1d566-7a4d-44f8-6435-08d8ede283ed X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:00:40.6730 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1Qhdy+rh58rr0VhubPn6TkOtICHB+XeOV1dHgdlYYOnDDgLXj9l9VQ31lXazB/B0OtiC/muxL1Vr/97+Mh7j3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 X-OriginatorOrg: citrix.com Introduce a helper to update the CPUID policy using an array of xen_cpuid_leaf_t entries. Note the leaves present in the input xen_cpuid_leaf_t array will replace any existing leaves on the policy. No user of the interface introduced on this patch. Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 3 ++ tools/libs/guest/xg_cpuid_x86.c | 67 +++++++++++++++++++++++++++++++++ 2 files changed, 70 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index ab34df1dc98..2143478fe4b 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2613,6 +2613,9 @@ int xc_cpu_policy_get_cpuid(xc_interface *xch, const xc_cpu_policy_t policy, xen_cpuid_leaf_t *out); int xc_cpu_policy_get_msr(xc_interface *xch, const xc_cpu_policy_t policy, uint32_t msr, xen_msr_entry_t *out); +int xc_cpu_policy_update_cpuid(xc_interface *xch, xc_cpu_policy_t policy, + const xen_cpuid_leaf_t *leaves, + uint32_t nr); int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 091aeb70c9c..13c2972ccd3 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -966,3 +966,70 @@ int xc_cpu_policy_get_msr(xc_interface *xch, const xc_cpu_policy_t policy, free(msrs); return rc; } + +int xc_cpu_policy_update_cpuid(xc_interface *xch, xc_cpu_policy_t policy, + const xen_cpuid_leaf_t *leaves, + uint32_t nr) +{ + unsigned int err_leaf = -1, err_subleaf = -1; + unsigned int nr_leaves, nr_msrs, i, j; + xen_cpuid_leaf_t *current; + int rc = xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs); + + if ( rc ) + { + PERROR("Failed to obtain policy info size"); + return -1; + } + + current = calloc(nr_leaves, sizeof(*current)); + if ( !current ) + { + PERROR("Failed to allocate resources"); + errno = ENOMEM; + return -1; + } + + rc = xc_cpu_policy_serialise(xch, policy, current, &nr_leaves, NULL, 0); + if ( rc ) + goto out; + + for ( i = 0; i < nr; i++ ) + { + const xen_cpuid_leaf_t *update = &leaves[i]; + + for ( j = 0; j < nr_leaves; j++ ) + if ( current[j].leaf == update->leaf && + current[j].subleaf == update->subleaf ) + { + /* + * NB: cannot use an assignation because of the const vs + * non-const difference. + */ + memcpy(¤t[j], update, sizeof(*update)); + break; + } + + if ( j == nr_leaves ) + { + /* Failed to find a matching leaf, append to the end. */ + current = realloc(current, (nr_leaves + 1) * sizeof(*current)); + memcpy(¤t[nr_leaves], update, sizeof(*update)); + nr_leaves++; + } + } + + rc = x86_cpuid_copy_from_buffer(policy->cpuid, current, nr_leaves, + &err_leaf, &err_subleaf); + if ( rc ) + { + ERROR("Failed to deserialise CPUID (err leaf %#x, subleaf %#x) (%d = %s)", + err_leaf, err_subleaf, -rc, strerror(-rc)); + errno = -rc; + rc = -1; + } + + out: + free(current); + return rc; +} -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:08:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:08:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100602.191842 (Exim 4.92) (envelope-from ) id 1lOdxA-00017o-Fp; Tue, 23 Mar 2021 10:08:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100602.191842; Tue, 23 Mar 2021 10:08:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdxA-00017E-8M; Tue, 23 Mar 2021 10:08:00 +0000 Received: by outflank-mailman (input) for mailman id 100602; Tue, 23 Mar 2021 10:07:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdrE-0006c2-1O for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:01:52 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ac161ce9-013a-41c1-aa72-bd6248067ef8; Tue, 23 Mar 2021 10:01:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac161ce9-013a-41c1-aa72-bd6248067ef8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493698; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=wR4wJPP74Nzgw96212p/UH6sUU/kQSlKJKqNRW2EsfA=; b=U1+QFrKBLEbOVXKND0i75v+Vw9dFdrUh1skhEfRscpLUKlqZedC7g+/8 891jFCZwsm1o/i1Cyunb6UkevkIoREiE0MNh1/ZauVZnY8myll4IWAcAn QUIWMUQSik8fyG5hWxPaHh1IxYQ6lyXEuntQSSF2q8zOs5SnUebjct2/J Q=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: flG4LL9BeCjzwH/PAnsOdAiH+zsEwC/NcqNe+MxUUtS7PT+MS76klZjdd3RabZSn+9XQvRFL/t beatTChezfKdh6lFBRKf+y9yxggifzNM7V6DOFAbRgTnyj1xTttspxrVKb54XkeYq2j/3vcW93 hCExNio+GaOI63+BDkIA2LaC4U8cy9uVkYa0gam3B0r97on3WFK7u9PNk+jxFGe0COGoEcoNMs PSwLh5z+Ud0+fbwj2w1lf0Izex3ORnCXZjQFUeQeD13zUoeo50a0bgC8mU189clk697YcRgLjA 8Pc= X-SBRS: 5.2 X-MesageID: 39900462 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Dvnxf6M223Wq0cBcT0bw55DYdL4zR+YMi2QD/3taDTRIb82VkN 2vlvwH1RnyzA0cQm0khMroAse9aFvm39pQ7ZMKNbmvGDPntmyhMZ144eLZrAHIMxbVstRQ3a IIScRDIfXtEFl3itv76gGkE9AmhOKK6rysmP229RdQZCtBApsQiDtRIACdD0FwWU16HpI/Dp WR/Y5qoDCndHQRYK2AdwY4dsLEoMDGk4+jXA4eC3ccmXWzpB6LyJq/KRiX2R8CTyhCqI1CzU HpmxH0j5/Tys2T5QTb0wbonvFrsfvnjuBOHcmdzvUSQw+c8DqAQKREd/m8sCsuoOepgWxa4+ Xkhxs7Jcx85zfwUwiO0GPQ8jLt2jov9HPuoGXw6RCIzL2bNVBKfvZpvo5XfgDU7EAtprhHod 929lmUqoZNClf4lDn9juK4Jy1CrFa+onYpjIco/hpieLYZAYUhybA3zQd+FZcNGz/C84Y3EO ViJ9G03ocmTXqqK1/epWVh29qqQzAaGQqHWFELvoiv3yFRh20R9TpW+OUv2lM7sL4tQZhN4O rJdoxuibF1V8cTKYZwHv0IT8ebAnHEKCi8fl66EBDCLuUqKnjNo5n47PEe/+exYqEFy5M0hd DoTE5YnXRaQTOsNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dQWeVVEVlde6qfl3OLyaZ9 +DfLZtR9PzJ2rnHohEmyfkXYNJFHUYWMoJ/vkhXVajpd/KN53KuuTXfO27HsupLR8UHkfERl cTVjn6I8tNqmqxXGXjvRTXU3TxPmzzlKgAVJTyzqw28swgJ4dMug8ahRCS/ceQMwBPtaQwYQ 9bKLPjmaWrmHmu8Q/zniJUEysYKnwQzKTrUntMqwNPGVjza6w/t9KWfn0X+3ebOBllTYfzHB REr1p6vYK7RqbghBwKOpaCCCa3nnETrHWFQ9M3gauY//rofZs+E9IBQ6x+FQLCEjRvggZ0oG J/aAsJL3WvVA/GuOGAttg5Fevff95zjEOAOshPs0/Ssk2auIUSXHcBZiWvVsSWmA4qYDJRij RKgukiqYvFvQzqBXo0gew+PlEJTGiMGrpJAD6IY5hulqnxdBt9SnqLgjKmmwg+E1CahXk6ty jEF2m5aPvLCl1StjRj3qHm/EhdW0+dc0hzA0oK+7FVJCDjgDJewOWLbq283y+tcVME2PgaKy yASyAVOBlSy9e+0wO1lD6OGW49/IgnOvXQAd0YAuju80LoDLfNubANHvdS8pogCcvntfUTV/ mDPyCSNzH1BooSqkWoj0dgHBMxjnYqkfnlgkK4qEe52WMyGvrULhBNQaoBL9SV8mjjQLKp3f xC/KUIlNr1Fl+0TNiMjZzzRXpkDDj4pGatVeEmqZxOp8sJxfBONqiedQGN7W1N2RU1Edz9m0 wfSplq+bypAP4aQ+UiPwZiumcznNuBLEEXohX7L+83c1YqlWLaNbqyksz1gItqJkWAoQfqUG PviBF1zrPgXyGZ06QdBL91CWNKaFIk4HAKxpLOS6TgTCGrffpE5ly0LzuUd6JcUrGMHfE1og xh69+F28+ReCyQ4nGdgRJLZoZP+X2gW8W8HUalHvNJ6cWzPRC0uZSRifTDxAvfeH+ccEQXhY pMaEwWYIBis1AZ/fMK+xn3bLf2rEIjm0ZZ+hd9mDfWq9Cb3Fs= X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="39900462" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T7p1ZmqHS78xIz6czIRY9SBPPGFS9Yx3AscabrmCKpeMk9dTVHxFDhLnYsCbLo8iBbE+XBIWpBb7zyTmHMcLXJ7cY++EwPdr9nnTkkixRzMV6jOvKaAoNu82IA9gZMV7QPdjmaimChxAfhtt5GkHxlFQ20Rv7lPJ86sp4ASqlQpugkPKt90ajWymtQnO0K2oC9RYbcMJDtqN4hhjqh1xGoGi/kU+7xNHUHL6jDdi8niNze6VdB/YusEDf3Plkmd0mboX2Odud/1xNO3wvQoAMi3wOXgZcgGIPRBVzX22w1sAHfT9kbpjl7eggSJi9JyGCMfBLW1MpmD+kHrHp5iiNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xte694DoXFSNebcQH5zfL8xkf7VzNnQAtPG37OEuSHQ=; b=CikGVkaqhUhgWc1kJVkeDpZG9wH33JihnVz7nLNDCzNWLmcZ22ViA/SvEpZcjm3elEIA/6HPOAHMjBg8KV982VNiw1mOGraXHYk83D3GOwExWy1XbjrP3NNhXoypqUROw9HeDEtZ9s9rIQsSzlYFe8davp+LCAX3Rybx5pVDBNUa6IZ1aQ7M2Nh2+5UAx0zymWfvW36gIxKlAw4JAo7QyvH2NMa0hqqxjv8PP3VWejrYBT6jCOqSEnY9actZMfHwnT4ISF3TGPhz1yM2oUYKaCvMiVlI9R5Lp4CtxTSg52Ryaj0BXeOb8UklHoAjm2qhL5VSwk1Qu1GNgl60UIvZcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xte694DoXFSNebcQH5zfL8xkf7VzNnQAtPG37OEuSHQ=; b=aCWKWomeUv14BmOPRXoOP7KAzSH88QnDbkeU//BSlteFMo1BUo77I9uD56NHRwO9grwAwEjZS8H6rFtFT3WYC2UQ6I5Asj8+6aQvyVqH7caAQKhNgK35pEmQH/aJ7RTXM9Va84+aBo3SG6NVJ6FKqf4oBXUNgE2r5L/WF/Ez/cI= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu , Anthony PERARD Subject: [PATCH 21/21] libs/guest: (re)move xc_cpu_policy_apply_cpuid Date: Tue, 23 Mar 2021 10:58:49 +0100 Message-ID: <20210323095849.37858-22-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PR3P193CA0057.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:51::32) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a9f13b24-f9fb-4d80-5a90-08d8ede2a44d X-MS-TrafficTypeDiagnostic: DM4PR03MB5997: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:312; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gx4Bfir4r/CCh3boBxIoDIBfw/9ro/qVNfbTfqEuGbaxxtOtI+WZu7uKQxHCzBAD7FOouWgCXIEOxFy2Ie1wX0ZE0j5qCqxgBLO2h58YVIsoVl+e2I/n3NwpuobPVjQamKAMrJFXY8cbRGydz/2rQEpzNpBwz8gLHA1AYrSvfzxaUWZ+OUj4J4mB5jszmpTwNYfKaQSxFtdAUxzfTj19c1OLqeHVg48U6E7n2CNtZAqk8I4jlHV+JtyEt6L+fvLfEq+kztTgIQ+f/fd5KSjbqLCYG+5IdUT8ry0oqPjD2nUyK8/iXZ+F+1wT39XP2nkdWKPx574qrZbZiJkEWWj9KIXhumTSyuPX94divZ7pk7/U8hmqpW9kAsipLoaq/vbOF0adyuOh0tmevPimkcaKqiuLAlPRPK/pIlLqOFRU8cs3lZRNeLae3kJ6STbwyDZq4npzFQo+E7BSDDe9H4x6an+7QWvP2S/VDpAVB6zgYpQsoEmVMc4yjrczl8R5+6L3PMy6KNQTVnIyU2KqYBPxPLyY6VtIFsZPrcJk9KeC5PBPdyRopc0cDftW8b+dLwuCkpAs/vBcWMfozNv7AQB+MfQS8b/1QNr7dFNGPBifJKcmteoBYWhsVED9nZBn09T3+wn8m1d+Q0dV9PZ+lf5McA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(396003)(376002)(39860400002)(366004)(8676002)(6916009)(83380400001)(86362001)(36756003)(6496006)(5660300002)(6486002)(2906002)(66476007)(66556008)(30864003)(8936002)(66946007)(316002)(2616005)(107886003)(54906003)(186003)(4326008)(6666004)(478600001)(16526019)(1076003)(38100700001)(26005)(956004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?V0lUODlydFUyMXJsRnkrN0pUL1REYVROZGFOcUVzbG5LRmxubTc1Y3ArMVcw?= =?utf-8?B?VHpDN1NDVWR1cGRUUHZldTJrcGFqVkZkRW1CdzR4S2JaeEw1bi9qVVVWZlRt?= =?utf-8?B?KzhoMStXUWVrZnhHb2JJKzVkb1VwMS9QclhOSkJwSldvNElhWUVaem1KTWlQ?= =?utf-8?B?VnlwSlIwNHl2aWhoSExTNWNqRHNnWjczeno4VXlFdkZRUTFvWllrT2dPWGwz?= =?utf-8?B?d0dvajBOaDVIcUpKUWZwOTdaS1d4Y3hEZkxWaEJJYlB2bVZUYUFDSEpJQWtN?= =?utf-8?B?M0hEY1FQdUNwazZFcklsbklwWDNEVkRGRlJ6MFJQcWExRjJmTTF5MXl6aUZC?= =?utf-8?B?NjBYMWYxK29rdTM4ZUdwN2ZPR09UTXorSHpQRlFwdzJrSmFDK25ZTEhGV0U0?= =?utf-8?B?Nmg5TkM5SlFkMHRDSzExeFRTNXZRQXhQdDZpNEpkelhCS2NickpHZ3NXQVJn?= =?utf-8?B?cnpraWF2N2tuNnV3R3NlSVdTSHZZYzVLODd5Q2l6UVF0VXhKNnZodk5HM2Zt?= =?utf-8?B?RDQrTWJhdlhNTDdDbFE5UnNkZDdudHVJWVg3MWFpVnV6WVFUODZFU1dtRWRj?= =?utf-8?B?WDYzNzdsT3dFbFdKL1JOeXVvZXlNankvMEczN0JNUzh2cUFwN2NPYUQ3QjlU?= =?utf-8?B?OUFnVTk3Z2NYajlzS0R3eE5mNWwyYWRXZmZDeTVaUlIvWllyTHpKRldhSUds?= =?utf-8?B?MzhIMmhXUnNJUjdrc05tUk1zaDFyMldjM3J6YjgvdWVGbDA2VVRrU1E3dEhz?= =?utf-8?B?cFFoVFlMSVEySlFUbUxJYVlPYzFRWkZDclp3bEoyU0k2UG0xSlU2UnhDZFZh?= =?utf-8?B?WGd1azVXbkx5d0FtbnhYblBnaDhIOU5udit4eS9kUjNmSDhxdVlSMnlBM05j?= =?utf-8?B?Z3c5Mk55Y09tdmtRZnlabTNqNGpkNm5RY2lCS0luNU1GaVB3SVpwakdlelZ6?= =?utf-8?B?Z0JrblA3ZVRpZGdNUGZZaEx2NDJoU2psdFQrUlViZ1hhS29xVVg2aVByRkZn?= =?utf-8?B?dlY2MGVYc1N5S0UvY0YrQ2wwcVR2WCtkaENnTnhPOGVXYVJSbnI2WW5XT1Fh?= =?utf-8?B?TllwUm5nQkNLYkNqVWtvVXAzaHBXZnUzNnBudGJpTUdWcWFMc0dBUE93bWxX?= =?utf-8?B?OWswYlBjMVdsZVN4NmJnN0VLcHliM0ZvUGh4RGs5M0Uwd2d6SkY0Qll2NTd2?= =?utf-8?B?eWR0ayszZ3F4MVUzMGJDenlmTjN2SlNkWFp0ckc4cnFuNW9HRFNzeWVrWHZC?= =?utf-8?B?NW44SDQ3YWJCTmlqUnF0MHF0TmEzZVdWTCtOK2h6b2Q0T1F2K29KeFZOOTdC?= =?utf-8?B?Rjlja0ZXSmdWN3RkSHBlVEh0TG5GL1VuQmNvbStFZFlNOFpLL1l3RWN6d2NL?= =?utf-8?B?YUFDeWVXcWtJVzRSdFBBTGpidWRaSHpmL1loNTEyQkVxZVc1S1JnSFNKNGM0?= =?utf-8?B?b2FsR2Q2KzBVYTFmRVVpY0FjdW9WWkFvdWhSdkY3MGZJY2RUQ0RSRUNyV2FB?= =?utf-8?B?Uy9qcFV0UHYzN210TW56UTN0T25DZVI1SHI1RHRjdXlBdEtuR25nelZMSHJF?= =?utf-8?B?Q3NCLzhJOUJhR0xJdWtyZGlRdGwrQlpjdnBHdkxHMS9VRnhXOS9IVUR1QmM5?= =?utf-8?B?MDVKTXBzUUo4dlhxQUFrVE1wNHlrVndacFdLQU56VnYxbXFEbnQvN29oS0xK?= =?utf-8?B?Mzd5NWp5bHgvaUhkVkkrU0tKeGtxU3FYeVlaZXZHcW9QK2sxRmpLSFd1TXJl?= =?utf-8?Q?/oauW8polBHHy5YWsz/FBG0AdXiTvjPv9KlhTAR?= X-MS-Exchange-CrossTenant-Network-Message-Id: a9f13b24-f9fb-4d80-5a90-08d8ede2a44d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:01:35.0936 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QwiYEJgQ0NIVWSFlNJEaaIUkZDctOeywqAu+Lls5gJub/YxzbD/WiuBRci3M5ww+aMOov30w9tS0f/+yD5IdcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5997 X-OriginatorOrg: citrix.com Move the logic from xc_cpu_policy_apply_cpuid into libxl, now that the xc_cpu_policy_* helpers allow modifying a cpu policy. Having xenguest parsing CPUID data in xend format was a layering violation, and by moving such parsing into libxl directly we can get rid of xc_xend_cpuid, as libxl will now implement it's own private type for storing CPUID information, which currently matches xc_xend_cpuid. Note the function logic is moved as-is, but requires adapting to the libxl coding style. No functional change intended. Signed-off-by: Roger Pau Monné --- tools/include/libxl.h | 4 +- tools/include/xenctrl.h | 30 ------- tools/libs/guest/xg_cpuid_x86.c | 125 --------------------------- tools/libs/light/libxl_cpuid.c | 135 +++++++++++++++++++++++++++++- tools/libs/light/libxl_internal.h | 26 ++++++ 5 files changed, 160 insertions(+), 160 deletions(-) diff --git a/tools/include/libxl.h b/tools/include/libxl.h index ae7fe27c1f2..923a931fa67 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -1376,9 +1376,9 @@ void libxl_bitmap_dispose(libxl_bitmap *map); /* * libxl_cpuid_policy is opaque in the libxl ABI. Users of both libxl and - * libxc may not make assumptions about xc_xend_cpuid. + * libxc may not make assumptions about libxl__cpuid_policy. */ -typedef struct xc_xend_cpuid libxl_cpuid_policy; +typedef struct libxl__cpuid_policy libxl_cpuid_policy; typedef libxl_cpuid_policy * libxl_cpuid_policy_list; void libxl_cpuid_dispose(libxl_cpuid_policy_list *cpuid_list); int libxl_cpuid_policy_list_length(const libxl_cpuid_policy_list *l); diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 5a576f72b4d..a57e32513d4 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1864,32 +1864,6 @@ int xc_domain_debug_control(xc_interface *xch, #if defined(__i386__) || defined(__x86_64__) -/* - * CPUID policy data, expressed in the legacy XEND format. - * - * Policy is an array of strings, 32 chars long: - * policy[0] = eax - * policy[1] = ebx - * policy[2] = ecx - * policy[3] = edx - * - * The format of the string is the following: - * '1' -> force to 1 - * '0' -> force to 0 - * 'x' -> we don't care (use default) - * 'k' -> pass through host value - * 's' -> legacy alias for 'k' - */ -struct xc_xend_cpuid { - union { - struct { - uint32_t leaf, subleaf; - }; - uint32_t input[2]; - }; - char *policy[4]; -}; - int xc_mca_op(xc_interface *xch, struct xen_mc *mc); int xc_mca_op_inject_v2(xc_interface *xch, unsigned int flags, xc_cpumap_t cpumap, unsigned int nr_cpus); @@ -2617,10 +2591,6 @@ int xc_cpu_policy_make_compatible(xc_interface *xch, xc_cpu_policy_t policy, int xc_cpu_policy_topology(xc_interface *xch, xc_cpu_policy_t policy, bool hvm); -/* Apply an xc_xend_cpuid object to the policy. */ -int xc_cpu_policy_apply_cpuid(xc_interface *xch, xc_cpu_policy_t policy, - const struct xc_xend_cpuid *cpuid, bool hvm); - /* Apply a featureset to the policy. */ int xc_cpu_policy_apply_featureset(xc_interface *xch, xc_cpu_policy_t policy, const uint32_t *featureset, diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index dffb9923b33..51b0ab66a80 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -258,131 +258,6 @@ static int set_domain_cpu_policy(xc_interface *xch, uint32_t domid, return ret; } -int xc_cpu_policy_apply_cpuid(xc_interface *xch, xc_cpu_policy_t policy, - const struct xc_xend_cpuid *cpuid, bool hvm) -{ - int rc; - xc_cpu_policy_t host = NULL, max = NULL; - - host = xc_cpu_policy_init(); - max = xc_cpu_policy_init(); - if ( !host || !max ) - { - PERROR("Failed to init policies"); - rc = -ENOMEM; - goto out; - } - - /* Get the domain's max policy. */ - rc = xc_cpu_policy_get_system(xch, hvm ? XEN_SYSCTL_cpu_policy_hvm_max - : XEN_SYSCTL_cpu_policy_pv_max, - max); - if ( rc ) - { - PERROR("Failed to obtain %s max policy", hvm ? "hvm" : "pv"); - goto out; - } - - /* Get the host policy. */ - rc = xc_cpu_policy_get_system(xch, XEN_SYSCTL_cpu_policy_host, host); - if ( rc ) - { - PERROR("Failed to obtain host policy"); - goto out; - } - - rc = -EINVAL; - for ( ; cpuid->leaf != XEN_CPUID_INPUT_UNUSED; ++cpuid ) - { - xen_cpuid_leaf_t cur_leaf; - xen_cpuid_leaf_t max_leaf; - xen_cpuid_leaf_t host_leaf; - - rc = xc_cpu_policy_get_cpuid(xch, policy, cpuid->leaf, cpuid->subleaf, - &cur_leaf); - if ( rc ) - { - ERROR("Failed to get current policy leaf %#x subleaf %#x", - cpuid->leaf, cpuid->subleaf); - goto out; - } - rc = xc_cpu_policy_get_cpuid(xch, max, cpuid->leaf, cpuid->subleaf, - &max_leaf); - if ( rc ) - { - ERROR("Failed to get max policy leaf %#x subleaf %#x", - cpuid->leaf, cpuid->subleaf); - goto out; - } - rc = xc_cpu_policy_get_cpuid(xch, host, cpuid->leaf, cpuid->subleaf, - &host_leaf); - if ( rc ) - { - ERROR("Failed to get host policy leaf %#x subleaf %#x", - cpuid->leaf, cpuid->subleaf); - goto out; - } - - for ( unsigned int i = 0; i < ARRAY_SIZE(cpuid->policy); i++ ) - { - uint32_t *cur_reg = &cur_leaf.a + i; - const uint32_t *max_reg = &max_leaf.a + i; - const uint32_t *host_reg = &host_leaf.a + i; - - if ( cpuid->policy[i] == NULL ) - continue; - - for ( unsigned int j = 0; j < 32; j++ ) - { - bool val; - - switch ( cpuid->policy[i][j] ) - { - case '1': - val = true; - break; - - case '0': - val = false; - break; - - case 'x': - val = test_bit(31 - j, max_reg); - break; - - case 'k': - case 's': - val = test_bit(31 - j, host_reg); - break; - - default: - ERROR("Bad character '%c' in policy[%d] string '%s'", - cpuid->policy[i][j], i, cpuid->policy[i]); - goto out; - } - - clear_bit(31 - j, cur_reg); - if ( val ) - set_bit(31 - j, cur_reg); - } - } - - rc = xc_cpu_policy_update_cpuid(xch, policy, &cur_leaf, 1); - if ( rc ) - { - PERROR("Failed to set policy leaf %#x subleaf %#x", - cpuid->leaf, cpuid->subleaf); - goto out; - } - } - - out: - xc_cpu_policy_destroy(max); - xc_cpu_policy_destroy(host); - - return rc; -} - xc_cpu_policy_t xc_cpu_policy_init(void) { xc_cpu_policy_t policy = calloc(1, sizeof(*policy)); diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c index f1418382b62..ffa256b62e2 100644 --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -291,7 +291,7 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_list *cpuid, const char* str) char *sep, *val, *endptr; int i; const struct cpuid_flags *flag; - struct xc_xend_cpuid *entry; + struct libxl__cpuid_policy *entry; unsigned long num; char flags[33], *resstr; @@ -369,7 +369,7 @@ int libxl_cpuid_parse_config_xend(libxl_cpuid_policy_list *cpuid, char *endptr; unsigned long value; uint32_t leaf, subleaf = XEN_CPUID_INPUT_UNUSED; - struct xc_xend_cpuid *entry; + struct libxl__cpuid_policy *entry; /* parse the leaf number */ value = strtoul(str, &endptr, 0); @@ -419,6 +419,135 @@ int libxl_cpuid_parse_config_xend(libxl_cpuid_policy_list *cpuid, return 0; } +static int apply_cpuid(libxl_ctx *ctx, xc_cpu_policy_t policy, + libxl_cpuid_policy_list cpuid, bool hvm) +{ + GC_INIT(ctx); + int rc; + xc_cpu_policy_t host = NULL, max = NULL; + + host = xc_cpu_policy_init(); + max = xc_cpu_policy_init(); + if (!host || !max) { + LOG(ERROR, "Failed to init policies"); + rc = ERROR_FAIL; + goto out; + } + + /* Get the domain's max policy. */ + rc = xc_cpu_policy_get_system(ctx->xch, hvm ? XEN_SYSCTL_cpu_policy_hvm_max + : XEN_SYSCTL_cpu_policy_pv_max, + max); + if (rc) { + LOGE(ERROR, "Failed to obtain %s max policy", hvm ? "hvm" : "pv"); + rc = ERROR_FAIL; + goto out; + } + + /* Get the host policy. */ + rc = xc_cpu_policy_get_system(ctx->xch, XEN_SYSCTL_cpu_policy_host, host); + if (rc) { + LOGE(ERROR, "Failed to obtain host policy"); + rc = ERROR_FAIL; + goto out; + } + + for (; cpuid->leaf != XEN_CPUID_INPUT_UNUSED; ++cpuid) { + xen_cpuid_leaf_t cur_leaf; + xen_cpuid_leaf_t max_leaf; + xen_cpuid_leaf_t host_leaf; + + rc = xc_cpu_policy_get_cpuid(ctx->xch, policy, cpuid->leaf, + cpuid->subleaf, &cur_leaf); + if (rc) { + LOGE(ERROR, "Failed to get current policy leaf %#x subleaf %#x", + cpuid->leaf, cpuid->subleaf); + rc = ERROR_FAIL; + goto out; + } + rc = xc_cpu_policy_get_cpuid(ctx->xch, max, cpuid->leaf, cpuid->subleaf, + &max_leaf); + if (rc) { + LOGE(ERROR, "Failed to get max policy leaf %#x subleaf %#x", + cpuid->leaf, cpuid->subleaf); + rc = ERROR_FAIL; + goto out; + } + rc = xc_cpu_policy_get_cpuid(ctx->xch, host, cpuid->leaf, + cpuid->subleaf, &host_leaf); + if (rc) { + LOGE(ERROR,"Failed to get host policy leaf %#x subleaf %#x", + cpuid->leaf, cpuid->subleaf); + rc = ERROR_FAIL; + goto out; + } + + for (unsigned int i = 0; i < ARRAY_SIZE(cpuid->policy); i++) + { + uint32_t *cur_reg = &cur_leaf.a + i; + const uint32_t *max_reg = &max_leaf.a + i; + const uint32_t *host_reg = &host_leaf.a + i; + + if (cpuid->policy[i] == NULL) + continue; + +#define test_bit(i, r) !!(*(r) & (1u << (i))) +#define set_bit(i, r) (*(r) |= (1u << (i))) +#define clear_bit(i, r) (*(r) &= ~(1u << (i))) + for (unsigned int j = 0; j < 32; j++) { + bool val; + + switch (cpuid->policy[i][j]) { + case '1': + val = true; + break; + + case '0': + val = false; + break; + + case 'x': + val = test_bit(31 - j, max_reg); + break; + + case 'k': + case 's': + val = test_bit(31 - j, host_reg); + break; + + default: + LOG(ERROR,"Bad character '%c' in policy[%d] string '%s'", + cpuid->policy[i][j], i, cpuid->policy[i]); + rc = ERROR_FAIL; + goto out; + } + + clear_bit(31 - j, cur_reg); + if (val) + set_bit(31 - j, cur_reg); + } +#undef clear_bit +#undef set_bit +#undef test_bit + } + + rc = xc_cpu_policy_update_cpuid(ctx->xch, policy, &cur_leaf, 1); + if ( rc ) + { + LOGE(ERROR,"Failed to set policy leaf %#x subleaf %#x", + cpuid->leaf, cpuid->subleaf); + rc = ERROR_FAIL; + goto out; + } + } + + out: + xc_cpu_policy_destroy(max); + xc_cpu_policy_destroy(host); + GC_FREE; + return rc; +} + int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore, libxl_domain_build_info *info) { @@ -535,7 +664,7 @@ int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore, } /* Apply the bits from info->cpuid if any. */ - rc = xc_cpu_policy_apply_cpuid(ctx->xch, policy, info->cpuid, hvm); + rc = apply_cpuid(ctx, policy, info->cpuid, hvm); if (rc) { LOGE(ERROR, "Failed to apply CPUID changes"); rc = ERROR_FAIL; diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index 53b8939fb5a..5b9a220004a 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -2050,6 +2050,32 @@ typedef yajl_gen_status (*libxl__gen_json_callback)(yajl_gen hand, void *); _hidden char *libxl__object_to_json(libxl_ctx *ctx, const char *type, libxl__gen_json_callback gen, void *p); +/* + * CPUID policy data, expressed in the internal libxl format. + * + * Policy is an array of strings, 32 chars long: + * policy[0] = eax + * policy[1] = ebx + * policy[2] = ecx + * policy[3] = edx + * + * The format of the string is the following: + * '1' -> force to 1 + * '0' -> force to 0 + * 'x' -> we don't care (use default) + * 'k' -> pass through host value + * 's' -> legacy alias for 'k' + */ +struct libxl__cpuid_policy { + union { + struct { + uint32_t leaf, subleaf; + }; + uint32_t input[2]; + }; + char *policy[4]; +}; + _hidden int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool retore, libxl_domain_build_info *info); -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:08:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:08:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100603.191850 (Exim 4.92) (envelope-from ) id 1lOdxB-00019I-6j; Tue, 23 Mar 2021 10:08:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100603.191850; Tue, 23 Mar 2021 10:08:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdxA-00018z-SY; Tue, 23 Mar 2021 10:08:00 +0000 Received: by outflank-mailman (input) for mailman id 100603; Tue, 23 Mar 2021 10:07:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOdqA-0006c2-VI for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 10:00:47 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 78e0421b-df95-4e63-96f9-dcac87299447; Tue, 23 Mar 2021 10:00:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78e0421b-df95-4e63-96f9-dcac87299447 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616493621; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=/SoEDPLw6OxZ/qntLzfu2J9mHJByb6j4475FehVwXTs=; b=FO68J3vGdBIIWHC8k+PPS44Z4N5yi3HDicoPWA+SZr/P03afMmWf29En gX3yD3qUvtO0ujU/Qtc5mK4oZhkDqoC0tntEosg0TnSr5vFdqMaLnwu/L EMLNxKU8V5qI9/mC8b5ZaEG49zx22KMFFPFcMugLeCh7yQgoEMAIpzC81 w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: znpTRrcwkN3GyJeu2IbTnAlnmzqQVx91BMnditoywYrMNVxTgHxjf/stJf0SzxMA83BzJa6GFl MrSolfFM7bPnfT89b16p3MN4VND/bo2OF0VYWttYjsg3Wh6D7HMc1VpfxTR/tEZJVP4qW0TKqi RQaNWew3hv+gIk6F36QaBtvsIvaC1OaYMPn02IXSQfPbJqu0zPZU0Rf+hHYhExwCY4S3zxc1MY RX1q8xk7IxwR7JMvdldSqbctdsCzGYuG0oey4l3PLH/x9XRYh/WlSs85XhGL37GEAFUta60Ijo 85Y= X-SBRS: 5.2 X-MesageID: 39779569 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:gdbciqlGkYzyQci6dTuz8InH9L/pDfPKj2dD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLN+AZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 hdWoBEIpnLAVB+5PyX3CCRD8sgzN6b8KqhmOfZyDNXQRt3brx7hj0YNi+wOCRNNW57LLA+E4 eR4dcCmiGpfm4ZYt/+Kn4OWeXCoNOjruOaXTctARk75A6SyQ658bKSKWnj4j4ycRNqhY0j/2 /MjhDj6syY0s2T5xfA2wbonu1rsfT7zN8rPr3otuEwChHBzjmlf55gXbrqhkFFnMiK5EwxmN fB5zcMVv4Dk0/5RW2+rRvz1wSI6l9HgBWOuDzo4wqRneXDSC8nEM0EvIpFc3LimjQdleth26 FG1X/xjeswMTr8mk3Glrz1fiAvvE+1rX0+qPUUnnxSXKAPAYUh0rA3zQd7FowNEzn9751iOO 5yDNvE7PITSl+CaWvF11MfjeCEbzAWJFOrU0ICssua33x/m2149VIRwIg6km0b/JwwZpFY74 3/Q+hVvYALavVTQbN2Be8HT8fyIHfKWwjwPGWbJkmiPL0bOlrWwqSHoYkd1aWPQtgl3ZEykJ POXBdzrmgpYX/jDsWIwdli7g3NemOgRj7go/suqaRRi/nZfv7GICeDQFchn4+LuPMEGPDWXP 61JdZ4GPnmAWzyGZtY/gH3VpVIQENuE/E9i5IeYRajs8jLIorluqjwa/DIPofgFj4iRyfeDx I4LXrODfQFynrudm7zgRDXVX+oUFf454hMHK/T+PVW7IAMM4ZLozUEkFjR3LDPFRRy9ogNOG duKrLula224UOs+3zT0mlvMh1BSmFY/avnSHEPgQMRKUv7ffIitrykCC9v9UrCAiU6Y9LdEQ ZZqVgy07mwNYasyScrDM/iFHmbgXsVrHejVIwdhaWH2MfgdvoDf9YbcZ00MT+OOw1+mA5spm sGQhQDXFXjGjTnjrjgsIYZH9jFd953gB6iJOldrX63jzTZmegfAl8gGxK+W8+ehggjAx5ZnE d4/aMkjL2cojq3MmckjOMkMFpDVXSPDNt9fXS4TbQRvoquVBB7TG+MizDfsR01d2bw32g5h2 DqL0SvCLn2K2sYnkod/rfh8VtyeGnYQll5bWpit5ZhUU7cvGxo7OONbq2v8meYZ1cY2NsBOD XdbTZ6GHIo+/mHkDqu3BqSH3QvwZsjetHHBLM4arfJxzeDLpaLmaxuJY4iwL9VcPTV9skFXu KUd1XLcHfWC+Y11xeUoXhgEi9us3Ugme7p3hqgzGXQ5g9LPdPiZHBdA5ccKJWgykKhYdCi+p Bwl8g0suu9KX+ZUK/O9YjnKxp4birOqmu3RdwyoZ9avagOpKJ+dqOrIwfg5TVi5lECN8/6m0 MVfbRj7J3AMoFpedYOeygxxCtcqP2/aG8isgn7GYYFDCoQpk6eG9OC+LzTr7UzRmWHuQvrIF GamhcttMvtbm+m1bQADbg3LnkTQE8g6G569OfHU4HLEg2le6Vi+1W9W0XNOoN1eeygGb8KqA x97MzNt+iLdzDg0ASVhABFGMt1ghCaaPL3JhmNF+5O+8G7PlrJopLC2r/OsB7HDR2ha0oZgo VZc1c3dcorsEhlsLEK X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="39779569" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GnEIJv55ftMJjvHDkYirmUykjyBXVTIy83GbsXW3ADDA4QElKrqoD1/BO0Ln2xPpvuRndC39HoE4LxgOVKBy6scus4Wxp88yAtX6p04NVi9Mf1HcdP6OKkCZOiPQSt2uqJrbKgnXML3HBnmFpcLP/dEpC/Eq/sX3LJuJ0wz6c0qmF3wAKGJMTY235UolnA7FLR9MWCmTz2flyPwTw52ypL8ITmWl+zLyF5LQp0MXeWPdBOLRj1cOf1S+YGvJax0aDpqLQJKBiZjiez0jwfAAWd11TEzUp9PQw4lES7yhCza6VJk3Nra5lUxHUFm/0cmEbVXbFyyh+30HIfhjuNo8WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hPrkBWw3F27B97CCbixdNkftOso/WmqluwfllC0ExZQ=; b=bDNf/fvkqETQgCgdpR2CpVdx0lTt4TRnkoWb+rVre02MEpfkSwV7u0ApeA0Wqcz0O9MRs3nSLfYLP3d9oSwGC9j3ZInmqGVrLG3mO4eZM+TLkDEm5Ncx/Gz6Ka58u3f4Ftt9sYfHNid9rPS0Lvr205zvnQX12W1oyr/xzrXPxmoGDBJl2bGH4UGhhtcX3Oa8JIx48QEj3e+mjGWPb17++a7TA4EInnSLRHcJ6Eay/vZvMtHp1TCuSwbUp/qikIyJB6/JtsuPj/Y5m5q9iXRfFFeRYE3N8p8NiOvGiwVKMdY4LK3owmpNzes5xbf9Pcvupc1Xxnj8g451uTHweSYFfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hPrkBWw3F27B97CCbixdNkftOso/WmqluwfllC0ExZQ=; b=AE3jEwtbQ9LymVeSmG6gOHVVQC1bkBWyM+LdjlbAopi4wpPTbqieWv4gU5BrRxU51/dRAIpGFWgxMrcugzv0frPgiv31L6W7fpSUTpNNDUsVoCziW3fTkT7VQ/RAHQt9sYoFmulOpBaeP3OzmwfU+HoyUzhnPpu/LJBYd62+QAQ= From: Roger Pau Monne To: CC: Andrew Cooper , Roger Pau Monne , Ian Jackson , Wei Liu , Jan Beulich Subject: [PATCH 07/21] tools: switch existing users of xc_get_{system,domain}_cpu_policy Date: Tue, 23 Mar 2021 10:58:35 +0100 Message-ID: <20210323095849.37858-8-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323095849.37858-1-roger.pau@citrix.com> References: <20210323095849.37858-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0155.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 261d4e70-d194-4247-a751-08d8ede27719 X-MS-TrafficTypeDiagnostic: DM6PR03MB4969: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:76; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C/W/Imvlo7O+hFU6uoGyjd+K5zuMSmYHenMQQW0YUr887rcVjFYnvEy12oNYbmp5N7uwdJkamIBsRc0j9Q9/083gE8uIS48paHJxGDPcY6Weuz0/o5EkAiaDlpVRLuvT5uDrjd1xnYy9P21XaznFoou4p+WlrkjI/WuHVFSoYgQziY5wk4skXAQZ0lDM2fBQsMi/ajs4E0b2cyKq2uJc8eU9JolKJBM2pdGYyz2ZzL3xQ7quJqUGrdFbjQT9lHDyeaxxRpbU8JrAtKaianREkNN42a8XJyq12mh5PqB+iOPq1PTiZBbqsqa9ZHIcje/UurVSLGwWIZQp59hpDw5AWfFzojOGYo6v5Um6I17ES0CQVjPIZul2uhnoaKzXrpbu8dQKTx5v0mrUWTmLgUJQmarCMc3Ji82k4yoWbYNvKWhDNbTFbA4gRI52X4KS5TBuuB9tN3jHNVGW38RGvgg3mCW0hjDHmpGj3+PnC90R3p1Z0iJlLAl/aFDYj3Nyovy4DQEOgytUqg9hEdFMGUuICl/skysS+qb+xyInz9FDgj5M6Pw13BLxM49KBrK0f9Q0Iz28IWIkt9XXyaI4BaZLw7rwhqqshyJ2rW+RaS/PPZhhN/23NtkVbwhzfGJ4IurJLJ8FZG4wbvGpM7xBnaiSDkH/HfGlOL7mhmQ9IwQuSpc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(54906003)(36756003)(2616005)(316002)(26005)(6486002)(956004)(16526019)(186003)(2906002)(86362001)(66556008)(6916009)(478600001)(5660300002)(8936002)(6496006)(38100700001)(83380400001)(6666004)(66476007)(8676002)(66946007)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?TWF2Zzh6Y0c4emtpOUhOU3V6eTl5OTQySkZTWDJHTVpGQS9vTXJpYUZWSmd3?= =?utf-8?B?OXByQS9QeEw3Qzl3dktiY29OdDdIdVR5NW91Y3RybzdLVTlXRm83RVcxV3I3?= =?utf-8?B?R0szVkFGUmtnbEZKandTeVdJbXFFUGN6UFQ1WEtsbmttbEgyTFhSSVF1a0t3?= =?utf-8?B?aWF1UWFGd3pDUTVzRVlkQVNUaVpvdzBScmgrZW5xeVBMS2NNYVFESmtHSWwy?= =?utf-8?B?VFIwanAyOU9sL2FacWVEVktwY21HSXNYT1ZnMWwxR1BLbHpGWGNKeDVOak1F?= =?utf-8?B?d2ZrK1lsdnBPNXJ3aExsSkhWY0VONlkrU1hCMFFxRUt3WFZGUlBRbFNKUTN4?= =?utf-8?B?R3Z5YVBSNmptbzE4ZUp1Q1VNTWN0L2NLbWZZTkFHQTJ4a0hRaTVuWDUvNkZE?= =?utf-8?B?L2hFWW1RQkwwdFJyR0wvNTNsVTlIOVg0bzArbGdqWTg0YlhGcUxXM2ZTcVhu?= =?utf-8?B?VUR0azdVWGxOOG1sRzJJMXdVNEcydE5OTEVXaVNrV2gwbEcxTFY4ZVZ3a0FN?= =?utf-8?B?VmFHRFJQdTZOdklhTGpvOHBFWmFPNUNPU0tJNnhJYlhjQTFod2diaTZHWS9z?= =?utf-8?B?MkQ0YTFLNnM2SEpadDJLMWNWQXpyL3N1Ti9yTHpKMmJiZm9VcEZHRUNIaFlW?= =?utf-8?B?eVovRGh4VERvZGVLWTVmMFMvcElHcnlBejM2d3RPWVJlcHdzNFpQMFB6TEJV?= =?utf-8?B?RklFYnJaeFJoOFB4RzVrQy9ESzd5QXc5K3V4emhVY04rVkRQYy90Z3grRDNH?= =?utf-8?B?MVh1NzNDOHh2LzJiVHA5MXBxcFh4Y2dWR1gzT3pZTnhtK3J5RFo5eStuTWxT?= =?utf-8?B?RHErU3huWG1WcWtuVmR2S0FLWlM5UzJXQk03cmdCV2l2UnFOV1Y4TC9zRjY1?= =?utf-8?B?TlNIWFBBMnMwNHlOMzZHRjN4Ym1rVFpCT1JvMkJQb3VyU002Wml3VjZBY3Rz?= =?utf-8?B?ZjN0UnJBQmVJVnlZUlJOWEdWbmlyN2cyT1dBdGJZN01BMTZZRVNXV1VNaEMx?= =?utf-8?B?TVpPa25qWW5XbXo3MngwU3dnTUpncjl3by9nS1VKTDg4NWJhNlJWOGJPWXBs?= =?utf-8?B?RWN5RjcwZk83UlRVREUxUE53dnNYQW5Ka3VCdEJ0cWUxUTRtbjgzN2Rvdldn?= =?utf-8?B?WVkxb3VONEppZ3oyMHBidFVQWldqeXNxTmhFWEtqQ0NSUFhKc2RhL0s1MGZq?= =?utf-8?B?Umw4M20rS2QzNm5GakRSYjk4K2d2R3NCMlgzRUlpNWJPUUdvZXpqSjdZZTRS?= =?utf-8?B?ZEpycUkxdmpTc0Nmb1A5VDZqUWc2T2pmc2VMNDhLM1JINDI5NlBqUi9sU3pj?= =?utf-8?B?MllkYUxJQ2JHdEhTU1pHZUdYdGh0VUd3ek9XdGxrR2wyZU5aMWNRN1NNbTkw?= =?utf-8?B?NjNkaUNIYlZDWi9ZWXlOaXRPTXQ5Y09VQVFRMUJlQ2hXWUlRcEdycVY1M1Mw?= =?utf-8?B?VUtvTkVhZ09GRE1MNFJIVHYzWFpFcXJoQUNSem5hS1RWV2N6TFI2eUwyYlMz?= =?utf-8?B?T3V5bzhvUGxlZGxHSEhObFRDenlkcWg3TXV3MkJNL01JZkZmWUNzdTVWWXJ2?= =?utf-8?B?Snlwa3ptOXhJYmR2Nm01ZDJZdXVLeVpXeTcyNGM3b2NkNmVsaXZLbS9wYnR4?= =?utf-8?B?Uyt1dXdLTWZzd3dKOE4vNERzaThmYTZ4NzdSRU9RVHdPRCtydEErY3hBVENx?= =?utf-8?B?RjRiTklQUWxGdUkvdkNJeklSOXEyazJYaEw2NXJTeUdZL2Y3ODdmYzZpcTBO?= =?utf-8?Q?fT+RwddS4f7CCT+Tubt0YAUPsuYMzgf3/+ktgCr?= X-MS-Exchange-CrossTenant-Network-Message-Id: 261d4e70-d194-4247-a751-08d8ede27719 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 10:00:19.0711 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SyOdeCe2URk9KUb2+1G5lIpo1UITYeKOiLysyekLfFHjxA6lFrsnTMn9nLss6hO8szI8s+ah3mRaIFcIZAih0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 X-OriginatorOrg: citrix.com With the introduction of xc_cpu_policy_get_{system,domain} and xc_cpu_policy_serialise the current users of xc_get_{system,domain}_cpu_policy can be switched to the new interface. Note that xc_get_{system,domain}_cpu_policy is removed from the public interface and the functions are made static, since there are still internal consumers in xg_cpuid_x86.c Signed-off-by: Roger Pau Monné --- tools/include/xenctrl.h | 6 ----- tools/libs/guest/xg_cpuid_x86.c | 36 ++++++++++++++--------------- tools/libs/guest/xg_sr_common_x86.c | 15 +++++++++--- tools/misc/xen-cpuid.c | 21 +++++++++++------ 4 files changed, 44 insertions(+), 34 deletions(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 983bb027a04..161dafd234b 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2613,12 +2613,6 @@ int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, int xc_cpu_policy_get_size(xc_interface *xch, uint32_t *nr_leaves, uint32_t *nr_msrs); -int xc_get_system_cpu_policy(xc_interface *xch, uint32_t index, - uint32_t *nr_leaves, xen_cpuid_leaf_t *leaves, - uint32_t *nr_msrs, xen_msr_entry_t *msrs); -int xc_get_domain_cpu_policy(xc_interface *xch, uint32_t domid, - uint32_t *nr_leaves, xen_cpuid_leaf_t *leaves, - uint32_t *nr_msrs, xen_msr_entry_t *msrs); int xc_set_domain_cpu_policy(xc_interface *xch, uint32_t domid, uint32_t nr_leaves, xen_cpuid_leaf_t *leaves, uint32_t nr_msrs, xen_msr_entry_t *msrs, diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 812ef14fbcd..a8133d5cd3f 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -128,9 +128,9 @@ int xc_cpu_policy_get_size(xc_interface *xch, uint32_t *nr_leaves, return ret; } -int xc_get_system_cpu_policy(xc_interface *xch, uint32_t index, - uint32_t *nr_leaves, xen_cpuid_leaf_t *leaves, - uint32_t *nr_msrs, xen_msr_entry_t *msrs) +static int get_system_cpu_policy(xc_interface *xch, uint32_t index, + uint32_t *nr_leaves, xen_cpuid_leaf_t *leaves, + uint32_t *nr_msrs, xen_msr_entry_t *msrs) { struct xen_sysctl sysctl = {}; DECLARE_HYPERCALL_BOUNCE(leaves, @@ -166,9 +166,9 @@ int xc_get_system_cpu_policy(xc_interface *xch, uint32_t index, return ret; } -int xc_get_domain_cpu_policy(xc_interface *xch, uint32_t domid, - uint32_t *nr_leaves, xen_cpuid_leaf_t *leaves, - uint32_t *nr_msrs, xen_msr_entry_t *msrs) +static int get_domain_cpu_policy(xc_interface *xch, uint32_t domid, + uint32_t *nr_leaves, xen_cpuid_leaf_t *leaves, + uint32_t *nr_msrs, xen_msr_entry_t *msrs) { DECLARE_DOMCTL; DECLARE_HYPERCALL_BOUNCE(leaves, @@ -322,7 +322,7 @@ static int xc_cpuid_xend_policy( /* Get the domain's current policy. */ nr_msrs = 0; nr_cur = nr_leaves; - rc = xc_get_domain_cpu_policy(xch, domid, &nr_cur, cur, &nr_msrs, NULL); + rc = get_domain_cpu_policy(xch, domid, &nr_cur, cur, &nr_msrs, NULL); if ( rc ) { PERROR("Failed to obtain d%d current policy", domid); @@ -333,9 +333,9 @@ static int xc_cpuid_xend_policy( /* Get the domain's max policy. */ nr_msrs = 0; nr_max = nr_leaves; - rc = xc_get_system_cpu_policy(xch, di.hvm ? XEN_SYSCTL_cpu_policy_hvm_max - : XEN_SYSCTL_cpu_policy_pv_max, - &nr_max, max, &nr_msrs, NULL); + rc = get_system_cpu_policy(xch, di.hvm ? XEN_SYSCTL_cpu_policy_hvm_max + : XEN_SYSCTL_cpu_policy_pv_max, + &nr_max, max, &nr_msrs, NULL); if ( rc ) { PERROR("Failed to obtain %s max policy", di.hvm ? "hvm" : "pv"); @@ -346,8 +346,8 @@ static int xc_cpuid_xend_policy( /* Get the host policy. */ nr_msrs = 0; nr_host = nr_leaves; - rc = xc_get_system_cpu_policy(xch, XEN_SYSCTL_cpu_policy_host, - &nr_host, host, &nr_msrs, NULL); + rc = get_system_cpu_policy(xch, XEN_SYSCTL_cpu_policy_host, + &nr_host, host, &nr_msrs, NULL); if ( rc ) { PERROR("Failed to obtain host policy"); @@ -478,9 +478,9 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, /* Get the domain's default policy. */ nr_msrs = 0; - rc = xc_get_system_cpu_policy(xch, di.hvm ? XEN_SYSCTL_cpu_policy_hvm_default - : XEN_SYSCTL_cpu_policy_pv_default, - &nr_leaves, leaves, &nr_msrs, NULL); + rc = get_system_cpu_policy(xch, di.hvm ? XEN_SYSCTL_cpu_policy_hvm_default + : XEN_SYSCTL_cpu_policy_pv_default, + &nr_leaves, leaves, &nr_msrs, NULL); if ( rc ) { PERROR("Failed to obtain %s default policy", di.hvm ? "hvm" : "pv"); @@ -760,7 +760,7 @@ int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx, return -1; } - rc = xc_get_system_cpu_policy(xch, idx, &nr_leaves, leaves, &nr_msrs, msrs); + rc = get_system_cpu_policy(xch, idx, &nr_leaves, leaves, &nr_msrs, msrs); if ( rc ) { PERROR("Failed to obtain %u policy", idx); @@ -793,8 +793,8 @@ int xc_cpu_policy_get_domain(xc_interface *xch, uint32_t domid, return -1; } - rc = xc_get_domain_cpu_policy(xch, domid, &nr_leaves, leaves, &nr_msrs, - msrs); + rc = get_domain_cpu_policy(xch, domid, &nr_leaves, leaves, &nr_msrs, + msrs); if ( rc ) { PERROR("Failed to obtain domain %u policy", domid); diff --git a/tools/libs/guest/xg_sr_common_x86.c b/tools/libs/guest/xg_sr_common_x86.c index 4982519e055..15265e7a331 100644 --- a/tools/libs/guest/xg_sr_common_x86.c +++ b/tools/libs/guest/xg_sr_common_x86.c @@ -48,6 +48,7 @@ int write_x86_cpu_policy_records(struct xc_sr_context *ctx) struct xc_sr_record cpuid = { .type = REC_TYPE_X86_CPUID_POLICY, }; struct xc_sr_record msrs = { .type = REC_TYPE_X86_MSR_POLICY, }; uint32_t nr_leaves = 0, nr_msrs = 0; + xc_cpu_policy_t policy = NULL; int rc; if ( xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs) < 0 ) @@ -58,20 +59,27 @@ int write_x86_cpu_policy_records(struct xc_sr_context *ctx) cpuid.data = malloc(nr_leaves * sizeof(xen_cpuid_leaf_t)); msrs.data = malloc(nr_msrs * sizeof(xen_msr_entry_t)); - if ( !cpuid.data || !msrs.data ) + policy = xc_cpu_policy_init(); + if ( !cpuid.data || !msrs.data || !policy ) { ERROR("Cannot allocate memory for CPU Policy"); rc = -1; goto out; } - if ( xc_get_domain_cpu_policy(xch, ctx->domid, &nr_leaves, cpuid.data, - &nr_msrs, msrs.data) ) + if ( xc_cpu_policy_get_domain(xch, ctx->domid, policy) ) { PERROR("Unable to get d%d CPU Policy", ctx->domid); rc = -1; goto out; } + if ( xc_cpu_policy_serialise(xch, policy, cpuid.data, &nr_leaves, + msrs.data, &nr_msrs) ) + { + PERROR("Unable to serialize d%d CPU Policy", ctx->domid); + rc = -1; + goto out; + } cpuid.length = nr_leaves * sizeof(xen_cpuid_leaf_t); if ( cpuid.length ) @@ -94,6 +102,7 @@ int write_x86_cpu_policy_records(struct xc_sr_context *ctx) out: free(cpuid.data); free(msrs.data); + xc_cpu_policy_destroy(policy); return rc; } diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c index 52596c08c90..8ac25581d68 100644 --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -458,9 +458,12 @@ int main(int argc, char **argv) uint32_t i, max_leaves, max_msrs; xc_interface *xch = xc_interface_open(0, 0, 0); + xc_cpu_policy_t policy = xc_cpu_policy_init(); if ( !xch ) err(1, "xc_interface_open"); + if ( !policy ) + err(1, "xc_cpu_policy_init"); if ( xc_cpu_policy_get_size(xch, &max_leaves, &max_msrs) ) err(1, "xc_get_cpu_policy_size(...)"); @@ -481,10 +484,11 @@ int main(int argc, char **argv) uint32_t nr_leaves = max_leaves; uint32_t nr_msrs = max_msrs; - if ( xc_get_domain_cpu_policy(xch, domid, &nr_leaves, leaves, - &nr_msrs, msrs) ) - err(1, "xc_get_domain_cpu_policy(, %d, %d,, %d,)", - domid, nr_leaves, nr_msrs); + if ( xc_cpu_policy_get_domain(xch, domid, policy) ) + err(1, "xc_cpu_policy_get_domain(, %d, )", domid); + if ( xc_cpu_policy_serialise(xch, policy, leaves, &nr_leaves, + msrs, &nr_msrs) ) + err(1, "xc_cpu_policy_serialise"); snprintf(name, sizeof(name), "Domain %d", domid); print_policy(name, leaves, nr_leaves, msrs, nr_msrs); @@ -497,8 +501,7 @@ int main(int argc, char **argv) uint32_t nr_leaves = max_leaves; uint32_t nr_msrs = max_msrs; - if ( xc_get_system_cpu_policy(xch, i, &nr_leaves, leaves, - &nr_msrs, msrs) ) + if ( xc_cpu_policy_get_system(xch, i, policy) ) { if ( errno == EOPNOTSUPP ) { @@ -507,14 +510,18 @@ int main(int argc, char **argv) continue; } - err(1, "xc_get_system_cpu_policy(, %s,,)", sys_policies[i]); + err(1, "xc_cpu_policy_get_system(, %s, )", sys_policies[i]); } + if ( xc_cpu_policy_serialise(xch, policy, leaves, &nr_leaves, + msrs, &nr_msrs) ) + err(1, "xc_cpu_policy_serialise"); print_policy(sys_policies[i], leaves, nr_leaves, msrs, nr_msrs); } } + xc_cpu_policy_destroy(policy); free(leaves); free(msrs); xc_interface_close(xch); -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 10:21:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 10:21:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100625.191869 (Exim 4.92) (envelope-from ) id 1lOeAH-0003Tw-2C; Tue, 23 Mar 2021 10:21:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100625.191869; Tue, 23 Mar 2021 10:21:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOeAG-0003Tm-Ur; Tue, 23 Mar 2021 10:21:32 +0000 Received: by outflank-mailman (input) for mailman id 100625; Tue, 23 Mar 2021 10:21:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOeAG-0003Te-D6; Tue, 23 Mar 2021 10:21:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOeAG-00040l-63; Tue, 23 Mar 2021 10:21:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOeAF-0005fH-Qy; Tue, 23 Mar 2021 10:21:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOeAF-0007uc-QT; Tue, 23 Mar 2021 10:21:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hBiOEaY3mSW1yIdhmNvz64SAH83oOYY2fbcM/YBhOLw=; b=vCMsL0GKr4dCJcGWDyfBzoaqFn J4nAcMarvCVzeY2MoFVgCTO8O9Wjhb+RS6ic9yQuf/XicTEeePlDAqKBNQDzYTVC5vY9EMnApaf8f w2MCSyZEhwhVrH5Fo2qjuSB8aNzyRt6LqOQJNT5fy0dBBEckLVfyPQiBnYI+gWujJeeY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.13-testing test] 160326: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=57a60c1f2779ce6d6ab5c2f677c4d0c66b09b08b X-Osstest-Versions-That: xen=d705cba5ae917aece3921f38df1bc0a579267d12 From: osstest service owner Date: Tue, 23 Mar 2021 10:21:31 +0000 flight 160326 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160326/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160154 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160154 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160154 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160154 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160154 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160154 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160154 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160154 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160154 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160154 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160154 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 57a60c1f2779ce6d6ab5c2f677c4d0c66b09b08b baseline version: xen d705cba5ae917aece3921f38df1bc0a579267d12 Last test of basis 160154 2021-03-20 12:41:50 Z 2 days Testing same since 160326 2021-03-22 17:06:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git d705cba5ae..57a60c1f27 57a60c1f2779ce6d6ab5c2f677c4d0c66b09b08b -> stable-4.13 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 11:29:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 11:29:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100635.191888 (Exim 4.92) (envelope-from ) id 1lOfDt-0001fD-0L; Tue, 23 Mar 2021 11:29:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100635.191888; Tue, 23 Mar 2021 11:29:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOfDs-0001f6-T1; Tue, 23 Mar 2021 11:29:20 +0000 Received: by outflank-mailman (input) for mailman id 100635; Tue, 23 Mar 2021 11:29:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOfDq-0001f1-IP for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 11:29:18 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c3c87e2d-ec61-412d-a176-35a9d68645e7; Tue, 23 Mar 2021 11:29:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3c87e2d-ec61-412d-a176-35a9d68645e7 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616498956; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=xEu885UNxUN9j/ytsYtUWP7Zn2rlbDCRHxIrln+6bdg=; b=U0AP6Hq7N06uyU3TyEckr5gM3XXAH8U7ri+w3bTtBUSkbDlQePFeNLms unPx7LQAc8aI8gJX/0okSKjIqGvnyoH1vusP2RAjzMgwBiGXDckWJRxhO QlfFhf/wuMP9Yak23ZgUXbtaNttiwgYE69Apdd6Epcb0ws36S9dZOcMW1 s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: FcKmANCDRKhTvWpykVbRCe2zOaj4T2YZDC3GwJvLY9s5tsPfpQeUh6XJ2N48IbBnAmlxdIGAO7 X1oe7/vwp7NyWXwCr79zTbmJRknU+Tz7QE99ia+hBwKSMh8+xq+BWjiF4PKiwGOZ86+gi4asxA O4DkgOsDfYjNg64tEx8H0q/abQ5JNWi2y+xNEjymTuJSHO6JAZOOoDIyIYE9ZSWM39fUBBEFzL OosO/Y7TZ6BEBvC18/o4HcoVFxCaNWxY0u5yr5stH3B7fIxW+jzm/RIJsp2AyVCvyty56r8H43 gtY= X-SBRS: 5.2 X-MesageID: 40267227 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:EcQ/i6kqvxtzx1Kfqpf1NN5Zj2TpDfN8iWdD5ilNYBxZY6Wkvu ql9c5rtyPcojAXRX0mhJS8KLCNKEmsi6JdzKswGfOZXAfgsHa1N40K1+Hf6hDpBiGWzJ856Y 5OaK57YeeRMXFbid/9+xSxFNwtqeP3iZyApeCb9Ht1SBEvVqcI1WZEIyK6NmEzewVcH5o+E/ Onl616jh6tY24eYMj+JnRtZZm1m/TxmJjrYQELCnccgWHk4F/GhoLSKBSW0gwTVDlC294ZgA 74ujb04b+irvGlygLNvlWji6h+osfryddIGaW3+74oAwjr4zzYB7hJavmuvCo+pemu7Fom+e O83ysIDoBSwFeUVl7wjDfR9yPc8BAIgkWSu2OwsD/Ciui8bA1/NOZ7v6J+VXLimj8dleA58I lum1iBv55yCx7dmSjmo+LDUQpnjCOP0AofuN9Wr1d6FbEGYLt0q4EC+U9OVKgNBzj77oc8ed Mef/301bJ1fV+CVXzfowBUsaaRd0V2OzKgZFQescqI1DU+pgEF82IogOgWnnIN7/sGOuJ5zt WBC79pkqpPU99+V9MEOM4xBfKtDGrDWBTNN3/XG03uEOU9N3rWrZmf2sR82MiaPKUSyp08gZ LAV04dim4oZ1irNsGUxp1M9Xn2MSyAdAWo9+ZzyLRnsrjhTKfmPES4OS8Tutrlqf4eD6TgKo eOEYMTCfT7JXDjHptI0mTFKu1vFUU= X-IronPort-AV: E=Sophos;i="5.81,271,1610427600"; d="scan'208";a="40267227" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XHtUgSQ3L2eCDLD8uqsXMoj5mZJJ11b9WTeFo1rpv7VZjGxPjQ9P1s1WdqVWlorEyzhHHXxW2YEPa6keoqlHZYfPjClT0RfgFWuBLPywsExQuefl9dWKqO1hlQ4XXaLen2tmBgEZ/tXwlc0iE/vkw3LUIt2S52todPpuxreJD2GAZ3QlAT3b/aX9Jx0Rk4tsMawq/8AHAX4cYxfYZRuaIjOo49lnxRX0B0qIkdQywf2+kKrZPviwmWJ02etkgs94aQad319OzS9R8D5I7shBprshAOOwsIZCTAyUPnc8L5EZGL+pWZK2mg49D5Bjpg/PTLW2WWWfkzaymq4BZYJMiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AS+XhQJ/OeI9zJkeGx8nS0NK3z03BOORSOXTHp1QKnk=; b=ZofZqpyzFeiPia7AwmtQupQGU7rUECY08b/0f2+OQe+awb0byLabJtg9B4csIUnLM+47xLdmHYHGZf/9ZmhJVpps1BWk7lPauUiJ9LmEygLPF2V162XKqtg3+R1BY68ibAPni24vZyHO7lmXmq8weNdX8FF9+LJmSEIcgNXHlx7Vkwo7PvVgMaUjun/Vb5ivW5rKV5vGAaDAOXOwL7pvsMHYMbQeyMVr+tMfU/5kMhyxQohKUvEmLvIgjIaJedRMbz7F0NnuYdWp0i2YLKGR3Mh6uTUYvrqE9v9SIPi4cwyshQXhnzcFraZvRlX/YwJOFo86aCD3NiidM9pT9UaIWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AS+XhQJ/OeI9zJkeGx8nS0NK3z03BOORSOXTHp1QKnk=; b=JRnGmCeG8xBqMGokL5fvMNLPUwNARF5ZO+KwlJ6Ozk3RRsHKnelgyee1pKUpLp2RiOU6r8Sr1cj+pzBTJmdzQ95ixhPhMq0fDUtOEXC9aQ0AO2F//Um0cz/F1iql/RM6AkSmSdZRCTdlufnvMdEh72af3uzewgF4sFJGhjjteEQ= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH] hvm/mtrr: remove unnecessary is_hvm_domain check Date: Tue, 23 Mar 2021 12:29:00 +0100 Message-ID: <20210323112900.40723-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0094.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e3d43334-5169-4e91-a3fb-08d8edeee1de X-MS-TrafficTypeDiagnostic: DM6PR03MB5339: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x6B0qNoRPpSzMfEj+2HTFCTubrge6uZZxNYRmqp4NtHWCW2MWuOjRPAkjqb0aEdEDDJypWTHusvOMga30E1HdABwsztcw0KyqOx+gcHXoqNzqLMB/eEMVpMWsuA0s6nFrlA6rHhHakDE/3YBn1vXpLD2NhCofNg4p3f3cHKHBU63XEv7cJxkeXUsx4lOjONif7q5ehmGg/bWTlUXpLEFD8KLXvQPUc+4jtr+NTbODsBM0+SB/INfyj6JoeUPfHojPYp3a+dWW8f49HaGm9Jn74KJfIQmJA5lCGtKW50iiBpbv4E5EDosqS0AJ7UKN98D4u/RXwjiFljbvTt6kz90x29wmA1EmXiR1hcP4EOk2+q2ga+ehAtRIJvLq1Z/NTMi4ovHNd+V7cvrfSl7D9JF2qdw36v3XvwzMNPfCE4HqBlr0hizdoEbM507uppKMziks5MvJBrG6fN6CeQB+X/0tNuNTJG8vGCQ2tWvMnrt5KSqLgtaEHACX4UhUuQ2Y0q+1xBTPUSzahUU/u74Q2aKJ6TgkL11AR7WlE4WMuMhVhphs5R4oP4odehOyFM4BXixlc083DC5rPNnz5oTMSPZ5Tin+NL58gQwIsLi8/qye7Mka/lsHyqbZN6sDXCEcAT5Va1tA7/O+OEwIcKcbJqU2SkvF46D2RBBj+d8hsz0o0I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(136003)(39860400002)(396003)(346002)(478600001)(38100700001)(6916009)(26005)(186003)(16526019)(1076003)(36756003)(8936002)(316002)(6496006)(8676002)(5660300002)(4744005)(2616005)(4326008)(956004)(6666004)(6486002)(66556008)(66476007)(2906002)(66946007)(83380400001)(86362001)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?di84VnVMd2MyWGc2NVJWYXRPblZCQndkWnYrQkdZVDhSOUxDZktza09QSUtS?= =?utf-8?B?aWhhV1NlcExWUitEL21wWWRZVWZQZzBTdW1XMURrQmcvR1NZWFhpMWRCRVN3?= =?utf-8?B?OEp0azFQd1JvLzNXcGFkaldPTlFaY2RWb0pVWnBpcTVRaUpGcjJNTGFuK1hR?= =?utf-8?B?VDJVeVloM1NlT0tZS2RvN2JHdTZuUGZZWmUrRmRDaklIdmVwODJ0bnlWR3hB?= =?utf-8?B?bVAzbytEUm1IWjZLcjlMc2dBWGtiZklkL3pZUE16NUo4a3VMOWVyaTNkSVlV?= =?utf-8?B?dmRsdmo4QTRjZEJxRzdXMWhUNHd6SThtdHNjbzBTWkRPMFc0M0JxcUxVTXlD?= =?utf-8?B?TElvT3QyK0lYbTJkWlZ0VSthYzV3bkM3Rk1CdzQ3Vm1DQ2g5QlhTUkYwNFRU?= =?utf-8?B?UjJPcWE5V3lqdGtESkdjTmlLVFdDSmdyMXdNV1doWG5RT2I5SGxObEtGVEJN?= =?utf-8?B?WVRhZm1MU0Nzb3FWMmhyVzVyNm5IL1hONlczUS9IeEZ4eEErUnVTNFBvaFJy?= =?utf-8?B?cDVLaEVUTEFwTUZRNzV1Rk1LRngwWnZ5ZHBCbWRMbmVZUWF4d3ZwUEIzQnk2?= =?utf-8?B?MkdGcFVBcmJaLzlNVU53SWxSU2F4bUJ4Q2grbTZXUWVaQzdDbmdxeEQzUFZq?= =?utf-8?B?YjV3c3dtNDRMcGhYTXE1SmNqc3NEU2V2bVAxZnh4c3FKa0lDRzlmM21jb0RI?= =?utf-8?B?bFJUQ1p3aGhDL01NbFYxM012SXZzUkN0azN4SSs0Vlk4d3pUaEQyS25CajFT?= =?utf-8?B?Rk83V01QVi9YWkpTZVNyZEVDd2hpRDRHanp0VDh1emVxU245VkNKOU1hdTNk?= =?utf-8?B?Tlh1N3FhNzU4L1Y0Z3RBc09HQi8zNWVITE9CQ2crVmZTeWJJU2xKV0h4Yzlp?= =?utf-8?B?ZHo0cFB3dDFMWE93S2t5Y2tma25KeWs3a3VaWFJ4SVBhaWpWdkIrOHRNaTJQ?= =?utf-8?B?TkUxRkNmL3BVTjNBZUtNNU1CTm1YcHJMd2hBT0lsMEI4bGFzdk55blY1MTBi?= =?utf-8?B?aXlNMFZ1eTN6V0VXNGVaUnYweEpHbnMxbzlRYm1OaGpzaHh6YjlUNUlDei94?= =?utf-8?B?Q2ZnYXZrOThjNXIxd3ptSUZRNlNmKzF1QVZCOG1VUU5ac0tNM0gySnNxS2Nq?= =?utf-8?B?WE1pd2d0c0hGSy9MVmw0M0FUWnU1cXN0bnU1eWkyZzM2b1M2V05FT0wzQkpq?= =?utf-8?B?OWw3VUx3YkVjY0QzdHlTVFlKTHBkVVVPaDBWd1hLUnh5ZHptTjJTWG4vK0Ev?= =?utf-8?B?bEx4T0EvcTlsWkkxYXcvaFNSM3BVcEJMdjFCQ3VTN2VVZmVPZzArTkVVb3NU?= =?utf-8?B?SVcxS0NCbk5JOFZEdTFVUEJkTTEydExCYllEaDFhbUU4TERSbThySmFYcDB2?= =?utf-8?B?cFJPejdWZk5JdFpGMC9CaDE1SmR5YWdHRTU1dDJRVjcxZ3dJZnZacUFWTnY1?= =?utf-8?B?R1dKUmkrN01LWHVhdjJwdnJSeXdYWVJHMGZaaWZpeGhkWDkxSzlYcW9hOUxr?= =?utf-8?B?TngwZ1JYVTVTMWdlQUtJMTZLSFhaSVBMR1ZCbTZ4bGJuTVdyRTdkdTYwMHBa?= =?utf-8?B?TFl0NXJCaFYxZUdZWUI5VTE0cWhHVW1xVVdWV3Y1MzAzNGFVRk90VzVTazU0?= =?utf-8?B?dUF0UUpobW9JQ2VYbFNuQXJVNmd1RU16NDE3WVo2TW1UZzVUd0YySW1IRTJy?= =?utf-8?B?WS9vbHFUWUlScm9rNnR4b240RmkvQjF1czhoQmZETEdlcW5uR2d0aW1WSHVJ?= =?utf-8?B?S2pKRDdJMis4ejdHb2M5Q0FIc2h2am55RmFzWXZMV2VPcU5FTHRWa1M0cTgx?= =?utf-8?B?QzZNaWJ1OUM5L2Nna0I2dz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: e3d43334-5169-4e91-a3fb-08d8edeee1de X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 11:29:12.1165 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8a2sFHFctOhvi0iN8RiUQ33CLJjudZ52fM4OIP4TcNPuC9rG4GHwQL9JXAfR0DIgZuh/p3rSqXhSR/LzygkdiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5339 X-OriginatorOrg: citrix.com epte_get_entry_emt will only be called for HVM domains, so the is_hvm_domain check is unnecessary. It's a remnant of PVHv1. Shouldn't result in any functional change. Signed-off-by: Roger Pau Monné --- xen/arch/x86/hvm/mtrr.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c index fb051d59c3f..82ded1635c3 100644 --- a/xen/arch/x86/hvm/mtrr.c +++ b/xen/arch/x86/hvm/mtrr.c @@ -851,10 +851,8 @@ int epte_get_entry_emt(struct domain *d, unsigned long gfn, mfn_t mfn, if ( gmtrr_mtype == -EADDRNOTAVAIL ) return -1; - gmtrr_mtype = is_hvm_domain(d) && v ? - get_mtrr_type(&v->arch.hvm.mtrr, - gfn << PAGE_SHIFT, order) : - MTRR_TYPE_WRBACK; + gmtrr_mtype = v ? get_mtrr_type(&v->arch.hvm.mtrr, gfn << PAGE_SHIFT, order) + : MTRR_TYPE_WRBACK; hmtrr_mtype = get_mtrr_type(&mtrr_state, mfn_x(mfn) << PAGE_SHIFT, order); if ( gmtrr_mtype < 0 || hmtrr_mtype < 0 ) return -1; -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 23 12:12:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 12:12:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100660.191906 (Exim 4.92) (envelope-from ) id 1lOftI-0006d6-Sy; Tue, 23 Mar 2021 12:12:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100660.191906; Tue, 23 Mar 2021 12:12:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOftI-0006cz-Pc; Tue, 23 Mar 2021 12:12:08 +0000 Received: by outflank-mailman (input) for mailman id 100660; Tue, 23 Mar 2021 12:12:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOftH-0006cu-PS for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 12:12:07 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 52c282a9-2b73-4014-a649-eb41bc3f151f; Tue, 23 Mar 2021 12:12:06 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E50D8AD38; Tue, 23 Mar 2021 12:12:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52c282a9-2b73-4014-a649-eb41bc3f151f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616501526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6sAk9L+unwYPCmq2tpocdoCNLF3iGdlVElDJ2Qr52Ws=; b=aL7a4Hg2WsJ01hrwGBZC3jLqngduKrN7NcArTVYj/sIgq0Ve5H/9OIlUROkAMPKPMIHVNC 4aul/VvvJGYdxGamV4O2BwQ0+2uqNReHZSCtuuqRBo9Wsq96PW04rSbUD3LPYZSpG10mM+ fU7mpCqn78po1wfTfOf9rWoF/EUe8Co= Subject: Re: [PATCH] hvm/mtrr: remove unnecessary is_hvm_domain check To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20210323112900.40723-1-roger.pau@citrix.com> From: Jan Beulich Message-ID: <2654c931-9947-95b4-f01d-4af6b015467e@suse.com> Date: Tue, 23 Mar 2021 13:12:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210323112900.40723-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 23.03.2021 12:29, Roger Pau Monne wrote: > epte_get_entry_emt will only be called for HVM domains, so the > is_hvm_domain check is unnecessary. It's a remnant of PVHv1. > > Shouldn't result in any functional change. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Mar 23 12:34:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 12:34:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100666.191918 (Exim 4.92) (envelope-from ) id 1lOgEp-0000GS-PY; Tue, 23 Mar 2021 12:34:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100666.191918; Tue, 23 Mar 2021 12:34:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOgEp-0000GL-MG; Tue, 23 Mar 2021 12:34:23 +0000 Received: by outflank-mailman (input) for mailman id 100666; Tue, 23 Mar 2021 12:34:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOgEo-0000GG-DL for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 12:34:22 +0000 Received: from mail-lf1-x12d.google.com (unknown [2a00:1450:4864:20::12d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 84368010-1fb5-4c2c-b23b-6b936b65f2a7; Tue, 23 Mar 2021 12:34:21 +0000 (UTC) Received: by mail-lf1-x12d.google.com with SMTP id 75so26342166lfa.2 for ; Tue, 23 Mar 2021 05:34:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84368010-1fb5-4c2c-b23b-6b936b65f2a7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bAcSmwImGHdkSenTnDxBwKVNvLOW9c5Ag/ydDowOjV4=; b=p65tc17uSiIUgVFjmJReKl6m3Nwh7jj0J99tA5H7MGqV+K4p1RL8jUAGv/Itlih6v+ SLp66V60zHGRtLO64Zk7bR2SV7G7eHam1Hn3bECl1OmGKXWnVVsmqHFf91LvU+jaSyAi tPRPt7K2Tpw2zKQhiKTqredJ1Le6UncYpRlkoxguzUOOaC/8iixeBtEQvOttvKp3OzLD Yz+8NTB1nDcA1c3gsms/twIniX/eG1SI/fo2SOWX3B2jgfp40GmQwXaq5CnhANNeKcSR J9LMwrgp4QPdj/frvr3W8FMJLoDPoN7+sbaNMP1SAI7+niMVxYrup4qxXjfBR1gFL5Xt loyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bAcSmwImGHdkSenTnDxBwKVNvLOW9c5Ag/ydDowOjV4=; b=TjLaFkY+2GmBhUaYbQND7VTmBKuFPSIzF7MqCtU/mDPEjg6q3jseUJaCWIdqrhpZ7V 8BwFjXc24NeqjGaJewRZUqAwxW7im8WFhXd5fa90nvCqO5N9DSqYMojKx46gM0G3ZGfs iIaCdZoF9DBdlCqFDxb6UUb7J1thohMumfIRBCwEJMcSQySaq4dQyqkM0EH28SL6EFgP desXUMeFA/rYcaHtXllkcicwFrT7l2GDKB6kS3wzjQJRtrue0EVCMeMBqZWhqE65TdMs 7+OZed2Z1ZEdcGvsFZTjoDPiAthyqLEPOYKuxHMgD0b9NKnfZhsCGY8EawFPHiXI8D8x PCIg== X-Gm-Message-State: AOAM531q+QEiIDZhi64D11rNtyZz0T2qBmoqRdGn6QQNR3p/QsIMH1/l DFVQLqCwm0hSV8trvqBwihrR+IWQzYLIL+cRV2s= X-Google-Smtp-Source: ABdhPJziy19QZGQpF/kdTnR7krtD4lO7eUOQ3qTWV/KfZngKO2tTXnWd96kN8ctjrd2oPUxNbCFNGycfKKTLsJvx99w= X-Received: by 2002:a05:6512:243:: with SMTP id b3mr2535336lfo.529.1616502859950; Tue, 23 Mar 2021 05:34:19 -0700 (PDT) MIME-Version: 1.0 References: <20210322133301.11308-1-jandryuk@gmail.com> <09b5e7ee-b44b-a8ab-f29d-6617b6af93a0@citrix.com> <9b071192-a443-4bdc-8dac-107bbd4a0481@suse.com> In-Reply-To: <9b071192-a443-4bdc-8dac-107bbd4a0481@suse.com> From: Jason Andryuk Date: Tue, 23 Mar 2021 08:34:08 -0400 Message-ID: Subject: Re: [PATCH] xen: Create EFI_VENDOR directory To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel Content-Type: text/plain; charset="UTF-8" On Tue, Mar 23, 2021 at 3:23 AM Jan Beulich wrote: > > On 22.03.2021 18:08, Andrew Cooper wrote: > > On 22/03/2021 15:15, Jan Beulich wrote: > >> On 22.03.2021 15:59, Andrew Cooper wrote: > >>> On 22/03/2021 14:52, Jan Beulich wrote: > >>>> On 22.03.2021 14:33, Jason Andryuk wrote: > >>>>> make install-xen fails when EFI_VENDOR is set (=fedora) with: > >>>>> install: cannot create regular file '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No such file or directory > >>>>> > >>>>> Create the EFI_VENDOR directory so xen.efi can be installed within. > >>>>> > >>>>> This removes the need for Fedora and Qubes xen.spec files to manually > >>>>> create the directory in advance. > >>>> While I'm not strictly against, I'd like to point out that it was > >>>> deliberate to not create this directory here. I also didn't expect > >>>> anyone's xen.spec to do so. Instead I'd expect the distro to create > >>>> it during OS installation. If this was a bad assumption, I'd prefer > >>>> if the commit message here could point out why such an expectation > >>>> won't hold in general. > >>> This reasoning is broken for anything other `make install DESTDIR=/` on > >>> a live system. > >>> > >>> It is incompatible with how RPM, deb, etc packages work. > >> I'm afraid I don't understand, for both of your statements. If distro > >> installation put in place the designated directory, there wouldn't be > >> any live system lacking it, and there wouldn't be any concern in the > >> packaging of any software. > >> > >> To take a perhaps too extreme example - packages typically expect e.g. > >> /usr to exist as well, don't they? > > > > No. A buildroot starts out fully empty, by design. > > > > The packaging environment (usually a chroot) invokes `make install > > DESTDIR=/path/to/staging/root` so you don't interfere with any of the > > tools inside the environment, and the resulting tar/cpio has the > > buildroot stripped out of paths. > > > > The failure being discussed here is the build within the packaging > > environment, not the metadata which forms the final package. Installing > > a deb/rpm/etc will make directories as applicable. > > Ah, I see. But then this _still_ isn't the right thing to do. In fact, > the package build and installation shouldn't put xen.efi in the EFI > partition _at all_. The build system doing so is for developers only, > so they don't need to invoke boot loader configuration every time they > rebuild and re-install. Hence the packaging build shouldn't set > EFI_VENDOR in the first place. There it instead should be a subsequent > boot loader re-configuration which picks up xen.efi from its install > location (under $(EFI_DIR)) and places it on the EFI partition. On Fedora, RPMs drop EFI binaries directly into /boot/efi/EFI/fedora/. grub, shim, fwupdate and xen are all packaged that way. It seems reasonable to have those important binaries tracked by the package manager. Does SuSE populate EFI_VENDOR from EFI_DIR when some boot loader script is called? I think Xen's population of EFI_VENDOR is sensible and fine. Plus it's *used*. I don't see why it needs to be removed. I was just trying to fix a bug. Regards, Jason From xen-devel-bounces@lists.xenproject.org Tue Mar 23 12:37:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 12:37:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100668.191929 (Exim 4.92) (envelope-from ) id 1lOgHL-0000Py-5v; Tue, 23 Mar 2021 12:36:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100668.191929; Tue, 23 Mar 2021 12:36:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOgHL-0000Pr-2p; Tue, 23 Mar 2021 12:36:59 +0000 Received: by outflank-mailman (input) for mailman id 100668; Tue, 23 Mar 2021 12:36:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOgHJ-0000Pl-2S for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 12:36:57 +0000 Received: from mail-lf1-x12d.google.com (unknown [2a00:1450:4864:20::12d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ed7ef406-b708-4c5d-9fa7-9ba7a610d106; Tue, 23 Mar 2021 12:36:56 +0000 (UTC) Received: by mail-lf1-x12d.google.com with SMTP id b4so2452504lfi.6 for ; Tue, 23 Mar 2021 05:36:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed7ef406-b708-4c5d-9fa7-9ba7a610d106 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=jjEXYV3IETTZZnE2F99X/YVsSolXNBNhR89Y7KFr44s=; b=tXmdVdIW7j1ogxeCxllmOV5WuyBQAhKztRhwrwRSZ7WUE0MfOkxX35fnAxvd11fp8T wdLvDW7sMt1tlkWvoq/vioXl1i6QF79FIu3vEb8wHNHdNCZLaSk6A8m/tw2c8IaauL/q 0JuAkHnLYCt0Nst4mLaz/BQtbLtHHTV3JQGx9nLX9vUcwEXI3bA1uN3fePADrD7UJP+e vPqLKGsbpim8NbZwN6/ndMqUt5DGSwoiB2jH/KcQoVzWJG4adAZb33eEt9KyjnTaM0yQ wzP4I1QK9+y8ckXsBL/LUjcZTNd0lbDtxSldQBy4P5czHF1lGo0wWKJGGXgMxgHAQCUQ lFqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=jjEXYV3IETTZZnE2F99X/YVsSolXNBNhR89Y7KFr44s=; b=kyqX1Y2jtAxj9Fqfao0BbDaWgF0b0/gJ5q0rLzKHUCpqZXdpEqCjt/1VM0BTHGugjv ERdLofWtdakp49+fYazK4KrW72ImfThijOoj65Yx10NWIKvDpNPZWoSvT0E+jXH/zkk0 Pr+rdH6QPiUdynsAP7fteHnNVQH99b1I1gc8NYr9rvmpa5uyf0FmDCTquGgflUgotbCM e0zmeUC3z6nXu4HrYMjsDmC2zTcdPpq1D+F7AkR9S/w+44FMObMicm9UUBMXFTU8MTPO j2U2+IU2yyLdX/9RYxjBDSXEYES6VZ/UEKiW8yGEYCImY07RqFFfE19TcV+FqWOKUNVS APCA== X-Gm-Message-State: AOAM53356wW3gjngfETk/Cl13zZHMdi826QAnvAAKJ/JlEhZZxJ1tFwr oCUS8yDqjSpellRz70QGNYG7ZdqZingMBMoJHj0= X-Google-Smtp-Source: ABdhPJyoVwfNP62aJ2wFY0rco6LaJ+jC66c0XypuSkILLC9vrfzrIl4+3Uu8tcIQmpGulN0hYrAI+urXDBT43x35kcM= X-Received: by 2002:a05:6512:3290:: with SMTP id p16mr2488453lfe.150.1616503015051; Tue, 23 Mar 2021 05:36:55 -0700 (PDT) MIME-Version: 1.0 References: <1FAD6C91-2B3A-48F0-88D7-CFCFC8B53BA9@arm.com> <2BC82A95-DFB9-4F90-8CC6-AE39405157ED@arm.com> In-Reply-To: <2BC82A95-DFB9-4F90-8CC6-AE39405157ED@arm.com> From: Jason Andryuk Date: Tue, 23 Mar 2021 08:36:43 -0400 Message-ID: Subject: Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 To: Luca Fancellu Cc: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , "xen-devel@lists.xenproject.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 22, 2021 at 3:09 PM Luca Fancellu wrote= : > > Hi Juergen, > > Yes you are right it was my mistake, as you said to remove the BUG_ON(=E2= =80=A6) this serie (https://patchwork.kernel.org/project/xen-devel/cover/20= 210306161833.4552-1-jgross@suse.com/) is needed, since I=E2=80=99m using yo= cto I=E2=80=99m able to build a preempt_rt kernel up to the 5.10.23 and for= this reason I=E2=80=99m applying that serie on top of this version, then I= =E2=80=99m removing the BUG_ON(=E2=80=A6). > > A thing that was not expected is that now the Dom0 kernel is stuck on =E2= =80=9CSetting domain 0 name, domid and JSON config=E2=80=A6=E2=80=9D step a= nd the system seems unresponsive. Seems like a deadlock issue but looking i= nto the serie we can=E2=80=99t spot anything and that serie was also tested= by others from the community. > Do you have any idea on that? I think this can happen if xenstored isn't running. Client access to xenstore blocks until xenstored becomes available. So check your init scripts ordering. Regards, Jason From xen-devel-bounces@lists.xenproject.org Tue Mar 23 12:57:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 12:57:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100672.191941 (Exim 4.92) (envelope-from ) id 1lOgb7-0002XS-V0; Tue, 23 Mar 2021 12:57:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100672.191941; Tue, 23 Mar 2021 12:57:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOgb7-0002XL-S0; Tue, 23 Mar 2021 12:57:25 +0000 Received: by outflank-mailman (input) for mailman id 100672; Tue, 23 Mar 2021 12:57:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOgb6-0002XA-V3 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 12:57:24 +0000 Received: from mail-wr1-f49.google.com (unknown [209.85.221.49]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 20df10a7-bfca-4295-9848-be040d7bec82; Tue, 23 Mar 2021 12:57:23 +0000 (UTC) Received: by mail-wr1-f49.google.com with SMTP id j7so20685010wrd.1 for ; Tue, 23 Mar 2021 05:57:23 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id s20sm2479983wmj.36.2021.03.23.05.57.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 05:57:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20df10a7-bfca-4295-9848-be040d7bec82 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=etZp46PwEAVTsIYpopwYLgqaradwBQk3LEAbkmAGV1Q=; b=bA1Px6sl3r+sIZ9TGyfr9vqk28/GQsrFqnH9aoTfgfjcAIZ27dg2HbG9WTO3eJkY+9 mBJ0VvnlS6j17qHqmnZKqM0r1lMYbbI0XcBUC9bepXUBRGURp1rTtzwv2HGbGq58ihMU peM5CvBUn0k4f/dU8pkIW2FFYa6MN0C3gswrRF1vZbiTVtSa5j0iwpyvYxjBtQrNpR9h hKywUGKVdl0vbahuIhBRj7JSWJI10Op5l1LCcM74jZI7ug2n83+PSZvGh6N8z31K7659 N5MBOSVOfuIZTr0/8Z1CGFa80S0EbmD0GU/4BoXgg5LEXOHYXOapLlRZ4095AHSG5h8x OZow== X-Gm-Message-State: AOAM531GDG7xXc7cmqiyvJu8PqGoYNMk4BRK5RqmysFL3UnNHjAOE+ko JeAwHex92jwRjf5inrTfpzs= X-Google-Smtp-Source: ABdhPJzdEfQdNPtN2Ep5XhSd1r/VeLB0n7wO216rXsVmPRudAb4UJGeRMw9SOVfYspwgp/Ro6C0IRA== X-Received: by 2002:a5d:698d:: with SMTP id g13mr3981164wru.2.1616504243238; Tue, 23 Mar 2021 05:57:23 -0700 (PDT) Date: Tue, 23 Mar 2021 12:57:21 +0000 From: Wei Liu To: Andrew Cooper Cc: Xen-devel , Ian Jackson , Wei Liu , Juergen Gross , Jan Beulich Subject: Re: [PATCH v2 for-4.14] tools: Fix pkg-config file for libxenstore Message-ID: <20210323125721.2ljuaechs4k65d3v@liuwe-devbox-debian-v2> References: <20210322162013.12639-1-andrew.cooper3@citrix.com> <20210322163847.23941-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210322163847.23941-1-andrew.cooper3@citrix.com> On Mon, Mar 22, 2021 at 04:38:47PM +0000, Andrew Cooper wrote: > There are no dependenices on evtchn, ctrl or gnttab. > > Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore") > Signed-off-by: Andrew Cooper Acked-by: Wei Liu From xen-devel-bounces@lists.xenproject.org Tue Mar 23 13:27:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 13:27:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100681.191959 (Exim 4.92) (envelope-from ) id 1lOh4V-0005kH-Fg; Tue, 23 Mar 2021 13:27:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100681.191959; Tue, 23 Mar 2021 13:27:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOh4V-0005kA-CS; Tue, 23 Mar 2021 13:27:47 +0000 Received: by outflank-mailman (input) for mailman id 100681; Tue, 23 Mar 2021 13:27:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOh4T-0005k5-SW for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 13:27:45 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5ba9e8c7-9ed8-4ddb-b064-763220cd7372; Tue, 23 Mar 2021 13:27:44 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E43F1AD80; Tue, 23 Mar 2021 13:27:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ba9e8c7-9ed8-4ddb-b064-763220cd7372 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616506064; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X65oIzopQz6eDf2StZGhkSyfEOhs7gyqxVPNHz+iQ70=; b=IBjLPjvxRVs1HEbYIMWUCRYK1PUqvKIGv9l/J3S6Nx1toY3TaCVXkw+1TtEsfLfuaNdtzx C4SjzJCwxRFdwsAEz39R4NLXhcoHgf7tcHlngt3nK1o9ktB4qr9rWM4EyY/2+9qAG8Ghud 3OT7KtLnmC4hZe6P89EYM/uh5d6f8e0= Subject: Re: [PATCH 0/4][4.15?] VT-d: mostly S3 related corrections To: "Tian, Kevin" , Ian Jackson Cc: "xen-devel@lists.xenproject.org" References: From: Jan Beulich Message-ID: <35150558-6a4a-d6bb-b51a-4e2bf37e5ae5@suse.com> Date: Tue, 23 Mar 2021 14:27:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 23.03.2021 09:12, Tian, Kevin wrote: >> From: Jan Beulich >> Sent: Thursday, March 18, 2021 6:12 PM >> >> None of these are regressions afaict, so considering how late we are >> in the 4.15 process, I can see reasons to not take any of these. All >> of them are backporting candidates though, imo. >> >> 1: correct off-by-1 in number-of-IOMMUs check >> 2: leave FECTL write to vtd_resume() >> 3: re-order register restoring in vtd_resume() >> 4: restore flush hooks when disabling qinval >> > > For the series: > > Reviewed-by: Kevin Tian Thanks Kevin. Ian - what are your thoughts here towards 4.15? Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 23 13:30:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 13:30:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100686.191972 (Exim 4.92) (envelope-from ) id 1lOh6r-0006d7-Sr; Tue, 23 Mar 2021 13:30:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100686.191972; Tue, 23 Mar 2021 13:30:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOh6r-0006d0-Po; Tue, 23 Mar 2021 13:30:13 +0000 Received: by outflank-mailman (input) for mailman id 100686; Tue, 23 Mar 2021 13:30:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOh6q-0006cr-58 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 13:30:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOh6q-00078M-3d for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 13:30:12 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOh6q-0001PF-2a for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 13:30:12 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOh6l-00025x-7p; Tue, 23 Mar 2021 13:30:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=csHzYIFs7mXGDu1/cxMuR2Np2eTyTaDSdcwLClBUnl4=; b=4J1v3kQO/OsueGrt4ATB9Oci0H +/fWx+Y6pE85zhI+468RYmALHbaD+ewH4KV1XSWdqjLMmdcieNzzw7L4tZ+i/+TU3OVxv9M9g4bI6 LxHo134z9GdWjiPCKVxsuGXGEo/RJQECzttoYeeF3vb4NUOjCnt6peITs9LydtLl609E=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24665.60767.79635.169601@mariner.uk.xensource.com> Date: Tue, 23 Mar 2021 13:30:07 +0000 To: Wei Liu Cc: Andrew Cooper , Xen-devel , Juergen Gross , Jan Beulich Subject: Re: [PATCH v2 for-4.14] tools: Fix pkg-config file for libxenstore In-Reply-To: <20210323125721.2ljuaechs4k65d3v@liuwe-devbox-debian-v2> References: <20210322162013.12639-1-andrew.cooper3@citrix.com> <20210322163847.23941-1-andrew.cooper3@citrix.com> <20210323125721.2ljuaechs4k65d3v@liuwe-devbox-debian-v2> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Wei Liu writes ("Re: [PATCH v2 for-4.14] tools: Fix pkg-config file for libxenstore"): > On Mon, Mar 22, 2021 at 04:38:47PM +0000, Andrew Cooper wrote: > > There are no dependenices on evtchn, ctrl or gnttab. > > > > Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore") > > Signed-off-by: Andrew Cooper > > Acked-by: Wei Liu Having slept on this and I am not convinced that this warrants backporting. I prefer to take a generally cautious approach to changes to packaging and the build system, as this is much less disruptive to downstreams. Ian. From xen-devel-bounces@lists.xenproject.org Tue Mar 23 13:31:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 13:31:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100688.191984 (Exim 4.92) (envelope-from ) id 1lOh84-0006js-97; Tue, 23 Mar 2021 13:31:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100688.191984; Tue, 23 Mar 2021 13:31:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOh84-0006jj-4z; Tue, 23 Mar 2021 13:31:28 +0000 Received: by outflank-mailman (input) for mailman id 100688; Tue, 23 Mar 2021 13:31:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOh83-0006jc-9M for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 13:31:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOh83-00079J-8Z for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 13:31:27 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOh83-0001S3-79 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 13:31:27 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOh80-00026f-1r; Tue, 23 Mar 2021 13:31:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=NX8sINXuOHROK+sUS3FJjWlQlzn29XUVu+eJEvGTJ/Q=; b=y9DsEQaOoHNXQqgIpfZmv0jEgT gT/o8lEUOa1bkeVaSDCS4cBJUXpC+ZNTQWtkRghHu39Thdo+VoBxmVeyfyBysrTxojGMdZ4TmzyeI 3Iw6AnGgMhujhy70S62K7OYHO2p1HgurvpsF62kpiuObexNgEkinqI1fh4ZkWX7BQgGY=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24665.60843.867312.686295@mariner.uk.xensource.com> Date: Tue, 23 Mar 2021 13:31:23 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Kevin Tian Subject: Re: [PATCH 1/4][4.15?] VT-d: correct off-by-1 in number-of-IOMMUs check In-Reply-To: <68084b4f-bcd2-59dd-bea7-781b8aa75ef7@suse.com> References: <68084b4f-bcd2-59dd-bea7-781b8aa75ef7@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH 1/4][4.15?] VT-d: correct off-by-1 in number-of-IOMMUs check"): > Otherwise, if we really run on a system with this many IOMMUs, > entering/leaving S3 would overrun iommu_state[]. Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Tue Mar 23 13:37:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 13:37:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100690.191996 (Exim 4.92) (envelope-from ) id 1lOhD7-0006vH-SF; Tue, 23 Mar 2021 13:36:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100690.191996; Tue, 23 Mar 2021 13:36:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOhD7-0006vA-Oo; Tue, 23 Mar 2021 13:36:41 +0000 Received: by outflank-mailman (input) for mailman id 100690; Tue, 23 Mar 2021 13:36:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOhD7-0006v5-6z for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 13:36:41 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 100b606e-9475-476a-b5da-fe200d211daa; Tue, 23 Mar 2021 13:36:39 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8A6C0AD38; Tue, 23 Mar 2021 13:36:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 100b606e-9475-476a-b5da-fe200d211daa X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616506598; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=60ay52gE2IV8FHfnM2KobukK+Cn7fu+GrabDxFaCsTo=; b=huVFP9DzXOGTS2pVgR111ZOgkLMMWJJHgl0DyaQRDJNp2oMX+Gnrz8jbYujHOy5Qiu4r+i OHmPg+CRjxv4nHkZZc6/LdHO6lNi/1FwFIKZkxEdfF4I0w0BW/BKMWAUZ83RDKoQOpsYtm xNcX1U4cNJ5Hf+n92JMCAM+NAQzqosY= Subject: Re: [PATCH] xen: Create EFI_VENDOR directory To: Jason Andryuk Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel References: <20210322133301.11308-1-jandryuk@gmail.com> <09b5e7ee-b44b-a8ab-f29d-6617b6af93a0@citrix.com> <9b071192-a443-4bdc-8dac-107bbd4a0481@suse.com> From: Jan Beulich Message-ID: <4b0ac6fa-cbe2-5b3c-fa61-52d743e07390@suse.com> Date: Tue, 23 Mar 2021 14:36:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 23.03.2021 13:34, Jason Andryuk wrote: > On Tue, Mar 23, 2021 at 3:23 AM Jan Beulich wrote: >> >> On 22.03.2021 18:08, Andrew Cooper wrote: >>> On 22/03/2021 15:15, Jan Beulich wrote: >>>> On 22.03.2021 15:59, Andrew Cooper wrote: >>>>> On 22/03/2021 14:52, Jan Beulich wrote: >>>>>> On 22.03.2021 14:33, Jason Andryuk wrote: >>>>>>> make install-xen fails when EFI_VENDOR is set (=fedora) with: >>>>>>> install: cannot create regular file '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No such file or directory >>>>>>> >>>>>>> Create the EFI_VENDOR directory so xen.efi can be installed within. >>>>>>> >>>>>>> This removes the need for Fedora and Qubes xen.spec files to manually >>>>>>> create the directory in advance. >>>>>> While I'm not strictly against, I'd like to point out that it was >>>>>> deliberate to not create this directory here. I also didn't expect >>>>>> anyone's xen.spec to do so. Instead I'd expect the distro to create >>>>>> it during OS installation. If this was a bad assumption, I'd prefer >>>>>> if the commit message here could point out why such an expectation >>>>>> won't hold in general. >>>>> This reasoning is broken for anything other `make install DESTDIR=/` on >>>>> a live system. >>>>> >>>>> It is incompatible with how RPM, deb, etc packages work. >>>> I'm afraid I don't understand, for both of your statements. If distro >>>> installation put in place the designated directory, there wouldn't be >>>> any live system lacking it, and there wouldn't be any concern in the >>>> packaging of any software. >>>> >>>> To take a perhaps too extreme example - packages typically expect e.g. >>>> /usr to exist as well, don't they? >>> >>> No. A buildroot starts out fully empty, by design. >>> >>> The packaging environment (usually a chroot) invokes `make install >>> DESTDIR=/path/to/staging/root` so you don't interfere with any of the >>> tools inside the environment, and the resulting tar/cpio has the >>> buildroot stripped out of paths. >>> >>> The failure being discussed here is the build within the packaging >>> environment, not the metadata which forms the final package. Installing >>> a deb/rpm/etc will make directories as applicable. >> >> Ah, I see. But then this _still_ isn't the right thing to do. In fact, >> the package build and installation shouldn't put xen.efi in the EFI >> partition _at all_. The build system doing so is for developers only, >> so they don't need to invoke boot loader configuration every time they >> rebuild and re-install. Hence the packaging build shouldn't set >> EFI_VENDOR in the first place. There it instead should be a subsequent >> boot loader re-configuration which picks up xen.efi from its install >> location (under $(EFI_DIR)) and places it on the EFI partition. > > On Fedora, RPMs drop EFI binaries directly into /boot/efi/EFI/fedora/. > grub, shim, fwupdate and xen are all packaged that way. It seems > reasonable to have those important binaries tracked by the package > manager. > > Does SuSE populate EFI_VENDOR from EFI_DIR when some boot loader > script is called? Yes. And back at the time, when I consulted our EFI person, I was left with the impression that this is the only reasonable approach. The primary reason, as said, was that the EFI partition as a whole may get rebuilt perhaps even from scratch at any point. Hence it's not reasonable to expect package-managed files to live there. (This is also expressed by us installing xen.efi into two places, which ought to be a clear indication by itself that one of them is only to ease things, not for packaging.) As indicated - if the error is confusing, let's try to address it by, perhaps, covering the case of the directory not existing also via the "partially done" message. And the message, should that also be deemed confusing, could maybe be dropped - I wouldn't be happy about it, but if e.g. it was replaced by one reporting the secondary install step was actually done, this would look acceptable. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 23 13:37:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 13:37:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100693.192008 (Exim 4.92) (envelope-from ) id 1lOhDb-00070f-8f; Tue, 23 Mar 2021 13:37:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100693.192008; Tue, 23 Mar 2021 13:37:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOhDb-00070Y-5D; Tue, 23 Mar 2021 13:37:11 +0000 Received: by outflank-mailman (input) for mailman id 100693; Tue, 23 Mar 2021 13:37:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOhDZ-00070M-MZ for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 13:37:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOhDZ-0007Fb-KY for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 13:37:09 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOhDZ-0001xy-IB for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 13:37:09 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOhDU-00027d-VK; Tue, 23 Mar 2021 13:37:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=5wg9s2wOhu6IIp6KgyIMxJ/OPzSPZgHZv+ZPEXrYQFA=; b=IfEzEUnTfzp1yz8O4jDmyXn0br FZn05loBYZEEBl68EFHTDfda63byKmJRrqWw4N254OP9rOA8+ArSF8xGam0QZToKprxtDzVgAWGG2 TKsO5TX9O85dl4QcjJ1Y128k5H1yftkslIkctmZ74wrkB4o78eOI0JqkiZH6MQ6A09l8=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24665.61184.783407.462294@mariner.uk.xensource.com> Date: Tue, 23 Mar 2021 13:37:04 +0000 To: Jan Beulich Cc: "Tian\, Kevin" , "xen-devel\@lists.xenproject.org" Subject: Re: [PATCH 0/4][4.15?] VT-d: mostly S3 related corrections In-Reply-To: <35150558-6a4a-d6bb-b51a-4e2bf37e5ae5@suse.com> References: <35150558-6a4a-d6bb-b51a-4e2bf37e5ae5@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH 0/4][4.15?] VT-d: mostly S3 related corrections"): > Thanks Kevin. Ian - what are your thoughts here towards 4.15? I looked at these four patches. In general I am not sure of the implications. There are two important sets of implications: (i) upside: what is the bug this fixes and how severe is that bug *in its actual impact on users of Xen* (ii) what possible problems might there be and how have we made sure that the patch is right ? I want look at this not from the point of view of technical details but in terms of user impact. User impact is harder to predict but it is what we actually care about. For one of the patches it seemed obvious to me that there was very little downside risk and the upside is not corrupting something (perhaps something important). For the others, all I could see, besides the general statement that these aren't regressions, there was a lot of intensive discussion in the commit messages of the specific technical details. Frankly, that all went quite over my head. I would be prepared to give a release ack for the others if I can be convinced of satisfactory answers to my questions (i) and (ii). For an idea of what kind of answer I'm looking for, see the kind of thing Roger has been putting in his 4.15-targeted patches. The more complex and to-me-impenetrable the underlying technical details the more sceptical I will be :-). I hope that makes sense. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Tue Mar 23 13:42:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 13:42:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100699.192020 (Exim 4.92) (envelope-from ) id 1lOhIK-00085a-SL; Tue, 23 Mar 2021 13:42:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100699.192020; Tue, 23 Mar 2021 13:42:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOhIK-00085T-Of; Tue, 23 Mar 2021 13:42:04 +0000 Received: by outflank-mailman (input) for mailman id 100699; Tue, 23 Mar 2021 13:42:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOhIJ-00085O-HH for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 13:42:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOhIJ-0007LZ-FP for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 13:42:03 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOhIJ-0002CZ-EY for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 13:42:03 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOhI7-00028Y-A6; Tue, 23 Mar 2021 13:41:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=NO72eAd1wZE8QUl/eBJ159N9S5LAV6H0N4zYhyOoNpQ=; b=QZ7AgGt5lXuK2lzpU83ImyTXm3 hrULImo6pFLbsZ4VuWc/OXZa9vSQtHrZ6v5z73nVpmrIHjKfhQGQmF0eX3se0sRZscRPjoPvHEg0O F8tRmrwqrl+CRWikkCVRnOyWCcEMxurRuTGIyXqJt7xOf+UjK21QU4ZrRoavyOqKEz4Y=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24665.61470.964721.635678@mariner.uk.xensource.com> Date: Tue, 23 Mar 2021 13:41:50 +0000 To: Jan Beulich Cc: Jason Andryuk , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel Subject: Re: [PATCH] xen: Create EFI_VENDOR directory In-Reply-To: <4b0ac6fa-cbe2-5b3c-fa61-52d743e07390@suse.com> References: <20210322133301.11308-1-jandryuk@gmail.com> <09b5e7ee-b44b-a8ab-f29d-6617b6af93a0@citrix.com> <9b071192-a443-4bdc-8dac-107bbd4a0481@suse.com> <4b0ac6fa-cbe2-5b3c-fa61-52d743e07390@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH] xen: Create EFI_VENDOR directory"): > On 23.03.2021 13:34, Jason Andryuk wrote: ... > > On Fedora, RPMs drop EFI binaries directly into /boot/efi/EFI/fedora/. > > grub, shim, fwupdate and xen are all packaged that way. It seems > > reasonable to have those important binaries tracked by the package > > manager. > > > > Does SuSE populate EFI_VENDOR from EFI_DIR when some boot loader > > script is called? > > Yes. And back at the time, when I consulted our EFI person, I was left > with the impression that this is the only reasonable approach. The > primary reason, as said, was that the EFI partition as a whole may get > rebuilt perhaps even from scratch at any point. Hence it's not > reasonable to expect package-managed files to live there. I agree with this analysis but it is for people like Fedora to decide how they want to build their packages. There is also the case of ad-hoc packages (eg our "make debball") which the user might reasonably choose to have dump things in the EFI system partition. Conversely, I see no downside to the mkdir. Jan, is there some actual harm in it ? If not, we should be accomodating to people's build and packaging strategies even if we don't entirely approve of them. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Tue Mar 23 14:44:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 14:44:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100707.192031 (Exim 4.92) (envelope-from ) id 1lOiG2-0005s3-GV; Tue, 23 Mar 2021 14:43:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100707.192031; Tue, 23 Mar 2021 14:43:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOiG2-0005rw-DR; Tue, 23 Mar 2021 14:43:46 +0000 Received: by outflank-mailman (input) for mailman id 100707; Tue, 23 Mar 2021 14:43:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOiG0-0005ro-7B; Tue, 23 Mar 2021 14:43:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOiFz-0008QH-TK; Tue, 23 Mar 2021 14:43:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOiFz-0002ul-Gz; Tue, 23 Mar 2021 14:43:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOiFz-00087s-GV; Tue, 23 Mar 2021 14:43:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jzdDfEn3ZWIr8IDuI43NaGxCrcUwEEPWMf4/DyLQn3g=; b=0UbObRlU5Hr6zevCHDIhgkgMwP fUGNlfsF3LRpjvQolhm3gB5k2tuD9ELfYkZw29k+ghLtCrHK2FlUmCAAWkjR6afiBntFm2NZgERtH zmidlW52Qa683TbeOFGLaxaBQUpnsQGNlMeYx9bNobl64h4w22cd5zl8ZI8A1WJtGH6I=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160328: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=c95bd5ff1660883d15ad6e0005e4c8571604f51a X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Tue, 23 Mar 2021 14:43:43 +0000 flight 160328 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160328/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu c95bd5ff1660883d15ad6e0005e4c8571604f51a baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 215 days Failing since 152659 2020-08-21 14:07:39 Z 214 days 410 attempts Testing same since 160328 2021-03-22 17:31:04 Z 0 days 1 attempts ------------------------------------------------------------ 461 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 135292 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 23 15:17:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 15:17:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100712.192047 (Exim 4.92) (envelope-from ) id 1lOin1-0000hg-6s; Tue, 23 Mar 2021 15:17:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100712.192047; Tue, 23 Mar 2021 15:17:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOin1-0000hN-2x; Tue, 23 Mar 2021 15:17:51 +0000 Received: by outflank-mailman (input) for mailman id 100712; Tue, 23 Mar 2021 15:17:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOimz-0000bK-Tu for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 15:17:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOimz-0000XK-Ol for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 15:17:49 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOimz-0000SK-Nm for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 15:17:49 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOimo-0002LD-P0; Tue, 23 Mar 2021 15:17:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID: Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=2gDvjd8OQCP+1QoDXLvhYK2Ic14i9IOyWZjYikq7pKI=; b=MM5oyfojrRL+kkTbwYfVuJEEZ6 RSuyGd2r5meHWA0Kemnl2+7Wjfy9SzaXwHeNPrrCfJRg485b6lyGMRisxZ0yASkzdrIqcmLN1puez bx2sCP57K8dbH3U+d792hPF+fdYRhIjj8j0cGLwApL7uOs5RIYBpdrS7tYSZ0pQ8sGr8=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24666.1682.595069.435575@mariner.uk.xensource.com> Date: Tue, 23 Mar 2021 15:17:38 +0000 To: committers@xenproject.org, Andrew Cooper , Juergen Gross , Wei Liu , Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Fr=E9d=E9ric?= Pierret , CC: xen-devel@lists.xenproject.org, community.manager@xenproject.org Subject: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow I think things are looking in reasonable shape. I intend to branch off the 4.15 stable branch tomorrow. I will then turn off debug on that branch. There will be a commit moratorium in force for much of the afternoon while the branching is done - commmitters please check your mail or irc. Any outstanding patches that have a release-ack but have not yet been committed should go in ASAP, and certainly by Friday. I have reviewed my list of blockers and the conversation that followed and there are just three areas that are still of concern to me: * io-apic issue on Ryzen 1800X Related Qubes issue tracking this: https://github.com/QubesOS/qubes-issues/issues/6423 Information from Jan Beulich Andrew Cooper Frdric Pierret Are we likely to get a fix in the next few days ? I think it may be time to reconcile ourselves to not fixing this, and deciding on a suitable plan B. Do we need to put something in the release notes, or SUPPORT.md, or implement a mitigation of some kind ? * Subject: Re: xenstore_lib.h and libxenstore API/ABI problems In the last mail in that thread, I wrote: | I suggest, instead, that we: | | In 4.15: | | * Retain the current soname, but: | * Delete the tdb internals from the header file and cease to export | those symbols. | * Rename the expanding_buffer and sanitise_value functions, to | properly namespace them, and move them to a private header. | | This is of course technically a breach of the ABI stability rules but | for the reasons I [give above] I don't think it will cause anyone any | trouble. I don't think I have seen any patches in this area. I'm concerned that this is getting late. I suspect we may have to punt this to xen-next. * Release notes (feature list), SUPPORT.md. This is on my plate, although George is helping with the feature list (thanks!) Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Tue Mar 23 15:27:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 15:27:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100720.192059 (Exim 4.92) (envelope-from ) id 1lOivj-0001f9-8y; Tue, 23 Mar 2021 15:26:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100720.192059; Tue, 23 Mar 2021 15:26:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOivj-0001f2-4l; Tue, 23 Mar 2021 15:26:51 +0000 Received: by outflank-mailman (input) for mailman id 100720; Tue, 23 Mar 2021 15:26:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOivh-0001ex-N0 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 15:26:49 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 995d882b-a488-4b4c-9cda-8054e4e5b5c6; Tue, 23 Mar 2021 15:26:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 995d882b-a488-4b4c-9cda-8054e4e5b5c6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616513207; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=K3jiB8Jq8Ewe0wuUKuznGRdgxgyNjqysvIbPIwPkeHo=; b=ODv8zzlmhvYukOe5R2D6bggz1/couFBjar0S3kbhjlLOn78t33EvuEYp 8XI+8X2LTGl/1UmigPLvr5G8vXIOFF/vZNG8koJB1mYvFPV1al2Sid4wS NCEY0pZCtSNxkp1abCgevrJFSjycv17KzeHo0XFU54ffLOKN4CT8UyNdi c=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: IUOLf2P+w7dqzumy+4siTHwLrFm38JVKwl4cGX/efiZz6S/s4XpUw11uBjiI4Bx1mXrJiAwwRT ohQMQGaiUNJM2BK4dRSWeF/qZ1E365sbnXWPCA3fqyaXdlCB2K7Nlj+iYoBOGBU+uoqQysvup+ 0hJE1DWy24y71gRQGPCGlOTfbIT+BrpNpD5pnlK56aOe0kZgbpt58ocjFoyi8hyMy07No6dQfv EDiFOc95Tfz7wnhgjbbUd2U5QSueCZ8jrGAQH8BH3ira8C+hTMpEFsgo4gN6R6XUJWTlVzYSXb 6R8= X-SBRS: 5.2 X-MesageID: 40294574 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:jSDoq6HcRiRG7Z7SpLqFG5HXdLJzesId70hD6mlYVQFVfsuEl8 qngfQc0lvOhCwMXWw78OrsBICrSxrnlaJdy48XILukQU3aqHKlRbsSi7fK7h/BP2nF9uBb3b p9aKQWMrfNJHVzkMqS2maFOvk6xt3vys6VrMfYi0xgVAR7L5xnhj0JaDqzNm1TaE14CYEiFJ yaj/A3wAaIXXgMdMy0Cj0kcoH41r72vanraxIHGBIrgTPm5V+VwYX3HBSC0hAVXykn+8ZGzU H/nxHk/aLmivmny3bnvFP71Yhcm9fq17J4daixo/USQw+Mti+YIL5PdpfHlzAzreGp5j8R4a bxiiZlBetfwTf8emm0pDHkxgXv1i0/gkWSt2OwsD/YjuHSAB48FspdlaJVGyGpmnYIjZVH/4 9gm0KfqpZNAhvLkE3Glqj1fiAvrGWYiz4Gs4co/gVieLpbUpB9h8gj2XkQN5E6ECfz+OkcYZ RTJfCZ3tl6WxendXzD11MfuOCEbzAIMTqtZFMNgcCR2yg+pgEE82IogPYSmXoN7/sGOuJ5zt WBNqxpkYdHRdMNYZR8A/8cQdC2Bnale2O3DF6v X-IronPort-AV: E=Sophos;i="5.81,272,1610427600"; d="scan'208";a="40294574" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NrfDkXTRTDD5b2dUY9Wb4uokYr8DNJ73CSSicbLL8tl24xGaCxYN70iDQIkyC7FzNg+dAIyAPFdmKm9md9t+i8wwoCMrtY2PhdFoifX2sqQiABNSbTBkU4wYM57K+o3gSA1D08LtkFQHK+TejWeIiuj0xGbgCw5KzAe6jmhmY4uPuA/jQgViWn49s1SeAFQmfjhGXgmuEBSc5giXU6GLgbUlZVvdJPKos/vs6QvuM7YoeULpWWMary8wlnkgh0dWsKOiaxvpqJhMeS+bcjYsseeYREyI1AOvaIT+Ev+jvE2viI0ZLG/zakfILNWzIKkFZ0W0wKAQSeSQ7/ZXLdL1/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jy3yDcKswrFvrBEobQc0Ogq4HkkDpnep69HnFYT0CiE=; b=CuB3pBPfoyw6oiWU+0w+AVXd0SJErrDVxyzUdOzngkuoxw0hAoW7PAVzmJ5zo2Pii4EWJrQNrNlXa7PyN+EcbmfnJvQ5C0KsUAE+zDVsEwYkc9UrGh6lUxc032Ml/oGZ7JUfidsZ0vNP9FUWT4BW1Xky0gjwcPBvomEBkOKxMlq9nLj87YYrcYx96tw+Zo9UKZ55WtJoNKyWCiWTomwomhr54yTBsBdzkyrJyUXFhvOHt4uHejEdohguSqGg27h88OSByB1zQVCeeG3Ly5U11OfSwIHh7wjsaRGkQL5/oPiU5hugKddimIu86LQ+VGRzZh1KfTSwCUjSQusnQArnfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jy3yDcKswrFvrBEobQc0Ogq4HkkDpnep69HnFYT0CiE=; b=Dcdjy8Scnb6DTQnnrvoJRvo6E5J7lciPRfWfmWuM71M8v5VMkudw3SUVN2TpilxxZAeuYgjQRhtA0xFlO5clscQM9Uxj1QzRnr2+QdhCSAisIcxeFxk56sMETMiM6i3FTNSIp7/0AlHcl6ggiki17O8c842UuJVuBJkwEX+hF6E= Date: Tue, 23 Mar 2021 16:26:36 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ian Jackson CC: , Andrew Cooper , Juergen Gross , Wei Liu , Jan Beulich , =?utf-8?B?RnLDqWTDqXJpYw==?= Pierret , , Subject: Re: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow Message-ID: References: <24666.1682.595069.435575@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <24666.1682.595069.435575@mariner.uk.xensource.com> X-ClientProxiedBy: PR3P191CA0056.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::31) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: df6bfdb3-9062-496b-aeb9-08d8ee10108e X-MS-TrafficTypeDiagnostic: DM6PR03MB5339: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e/l8KBoJPIednvgWtSwqATV3F7///xxEwZiXBD79xVIjK1+5g3oMO0geDQq9ieNtApXQAiYf6in5MUrp17dCGjFXmJl1MN/8UVDYr15vS/qPQsBr7VJGEf05UZpGtjgGMHPWzH8kr9Sc4FeEtbYqFi/30ppzdIiGpD65Cr6v9vniXqBH2T8Eh8oka6lijbW0zAQSF5d3Yy5gwyMheNgZ2CvVtXqtqzsGmsqW8Ru3E64poOLput08Z4D20/uSNowYke5dCtiCmeq8E7MYBDpPJH1VhvdB/MkYUgAA05f2h1095G7uYHq5zbTOU1GCtfoHQzDhYAbbk+losXco5tIcOcv7XaZipXLV4WDBV/16tve30NptwgMfcOojrCJT7rgA1UZM5FJdB7wFsjvkrUVTVdXoDYgdgGPZNgN+GKnyRJy0b/uCALWKCdSlCaTvFPf7jwnFSQgnrRrIOTPAmrYaRfCGMmKLKvDv6ZCGvfgafeQus95fL0wu6ZCoCKSxWO8FYyEUP0anYNAuSBPb5pXLRjSW8zdcDIWiqRcDY+9qXaHj6kyQBx13VaB8NaJ8x3D20wfH6luHIZE3nzOidDUiaHUKCM+nYi080BUeGSki6PgEQ2yVFRYqYQvkEbUr1qF73Aqwc+7ugyGpwqLUSNxGnHCtZoqyzHsZPfkyjyhJ4sW5lsypBjjYPdvZJWfmSIxpNDTq2z01hJMYia/AwW88dz9Zrxa0fzetYVmsrH+CxDw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(136003)(366004)(376002)(346002)(396003)(39860400002)(6916009)(26005)(478600001)(16526019)(186003)(38100700001)(85182001)(316002)(8936002)(6496006)(8676002)(5660300002)(966005)(4326008)(956004)(6666004)(6486002)(66556008)(66476007)(33716001)(2906002)(66946007)(9686003)(83380400001)(86362001)(54906003)(66574015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ajRTemtrZHFFRUl3TWE4Mm9sb1Q2VFJ6WTRKMWt0QkgzL3N2WDl5OUlHUHE5?= =?utf-8?B?cnZVWlduZU5vUDJVU2x1NGd5M1BUdlpIakwyRWZSbFRNNXJqWkl0ZFBzbnNx?= =?utf-8?B?TDB3NUMxWC93eUNhakhnZFo0L2xURVROZU1OSkViamdhWDV6RWlzQ3BKZTFN?= =?utf-8?B?V0hKcDNzMnI2ZGtWWmVRbUdEalhIN0s2SmM2b2hqUGpUcEpycEJ3RktoTlVv?= =?utf-8?B?VDBUcGlncll6T3czTW5VbHpneW16OHFVYWVaRFJHQ09rc0N1RUs3TWRDazNx?= =?utf-8?B?OTY0RFpESmtiR3Z0bm1ENGh0ek1XWExHek5qOHBHQXZLQjRtcVhhcDdTQThQ?= =?utf-8?B?Z1cxMS9LeU9sSitmYWludEtrWW9MSGFmbE1KbkpTaS9kcTBPa09LQkk4Qzcz?= =?utf-8?B?NkpMZDlNS3lzL1pkNEZIaUp5WmE5ZmlzUDNzN0FkQzBRK28yRkkxVFlySzNy?= =?utf-8?B?aU5yNk1YalJtcVB2ZU5PN29oc21kOXFXbG9nWDJGVUgrRGJsaEtqdFR2TTlt?= =?utf-8?B?Umt6MmVqUElmUVVtVldrOGMwL0NhLzhSbmMyaFdSM0VVZmxUeEprTWpiOVZ0?= =?utf-8?B?eXFVYVFIbkFyZzJINGtSVGlFanJKbUpYMDl0ZkdPaUwzNTR3eVUvV20zN3lI?= =?utf-8?B?UEdwcHY2RWphcVVNdkE4dkF5Rm02anJaNWhuWWRDeDBHQkdjVTJSNm9hamtO?= =?utf-8?B?RnhxZ1FJekVvd3BPMGZVTFdaR3hrTEJ4N0hSYUFQTElUemoveWtDS1FGc2Ju?= =?utf-8?B?NlhMNVV0U3FGS0pRN2c0ZHdoQTBrUXJhZ25La3pldkR0ZE9OUFhpOHFUMU1Q?= =?utf-8?B?WDBaZEIzMkIyY3RmbGVINy9iei81Ui9QVlIwZ3g5V1Npb2I4bGxkcXY0NVFr?= =?utf-8?B?ZEkrSTBSQ0k0YnpFaUlxdGFkNG4xcUErRTM4NkZtYUswbG9oc011US9KSGRi?= =?utf-8?B?ZW9SRFd3WTJ4VGlmQWk4RnhuTUgweFlaNDBPdTFYOUtaTGJGbEJOUWNpME8w?= =?utf-8?B?UzBWV2NLS245WmxFWFZVamhRbEpLY3BoU0FvdUQ1bXZSa3N1Z0RQZTJxQW1V?= =?utf-8?B?Mm1JTndLVEp0TDZMcWdHSFFSRHN2d1NTL0lBb2dUVEEwb3VSbzFEMWhhYmFk?= =?utf-8?B?ZEI0ZndKQXd0NitoWW95c1pnTlhob0EvQUZFT2l5RHpFK3VTZnZGbFFXSFFv?= =?utf-8?B?WGRHVlJ3RDlPQXZTT2lqd2J1RHpiM0NrRDlJSjArd1hsL2pMVUVCZkxLODh3?= =?utf-8?B?Z2NPdWVFazdPakR6TDZpWS9vRFdnczBzSm9iRnJUZzVtZXFZREZPc0hoQ2s2?= =?utf-8?B?Q2oxN2h5SW43dDBkSFZuSzNtUmduS1FvaEIzSCtkY0h0eVpqUzcxeE50OElO?= =?utf-8?B?Z2J3N0ZPajZxV2grczBHSVQ2WHI2bnNSallLbk5PZ1EwSjRrY2ZMcXI5bjYw?= =?utf-8?B?K1ZRK2hoOEYzdkZ1d0l3MCt4RDlKWTBCTlB3bzByWjVZeTRBWGZyWWxxUzZ3?= =?utf-8?B?cWg1QmE0NEdnVjRDaDhmRWJaUTBoM1R3NWtNUXl3bUtLME1XdDNIRmdBeVlK?= =?utf-8?B?Y3JCYjNDMUtzWlJrd2Y5Y250N3dXNFp0Zms4Ulptbmg2VWpWMXM2RUhXdDFQ?= =?utf-8?B?aG9sVFBSVURKdTNZTHBnOUJ1b1dlU0NnOExDSXhNNkEyTTNXZ2ZzYVRlYm9H?= =?utf-8?B?ZzkwSHdPODJRSTJjaUwwenpUVWR4SFRROWtPUVZBUWV2azhmWUR4c1pxMFpH?= =?utf-8?Q?TRAdfk6kSvWwYOSwgb9KLolkzZaA613U+tehYRT?= X-MS-Exchange-CrossTenant-Network-Message-Id: df6bfdb3-9062-496b-aeb9-08d8ee10108e X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 15:26:43.9699 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C5lf+kOWP1fcMCXWSgqKYqtJySukFr2POMkFchxDN+RuRIK9cV+pxsogDTr0jhcmfs6TdegWafNdPAHzv2f2TA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5339 X-OriginatorOrg: citrix.com On Tue, Mar 23, 2021 at 03:17:38PM +0000, Ian Jackson wrote: > I think things are looking in reasonable shape. > > I intend to branch off the 4.15 stable branch tomorrow. I will then > turn off debug on that branch. There will be a commit moratorium in > force for much of the afternoon while the branching is done - > commmitters please check your mail or irc. > > Any outstanding patches that have a release-ack but have not yet been > committed should go in ASAP, and certainly by Friday. > > I have reviewed my list of blockers and the conversation that followed > and there are just three areas that are still of concern to me: > > * io-apic issue on Ryzen 1800X > > Related Qubes issue tracking this: > https://github.com/QubesOS/qubes-issues/issues/6423 > Information from > Jan Beulich > Andrew Cooper > Frédéric Pierret > > Are we likely to get a fix in the next few days ? > > I think it may be time to reconcile ourselves to not fixing this, > and deciding on a suitable plan B. Do we need to put something in > the release notes, or SUPPORT.md, or implement a mitigation of some > kind ? > > * Subject: Re: xenstore_lib.h and libxenstore API/ABI problems > > In the last mail in that thread, I wrote: > > | I suggest, instead, that we: > | > | In 4.15: > | > | * Retain the current soname, but: > | * Delete the tdb internals from the header file and cease to export > | those symbols. > | * Rename the expanding_buffer and sanitise_value functions, to > | properly namespace them, and move them to a private header. > | > | This is of course technically a breach of the ABI stability rules but > | for the reasons I [give above] I don't think it will cause anyone any > | trouble. > > I don't think I have seen any patches in this area. I'm concerned > that this is getting late. I suspect we may have to punt this to > xen-next. > > * Release notes (feature list), SUPPORT.md. This is on my plate, > although George is helping with the feature list (thanks!) So there's also the series from Andrew to allow Solaris to boot without resorting to use the 'msr_relaxed' option: https://lore.kernel.org/xen-devel/20210316161844.1658-1-andrew.cooper3@citrix.com/ This has been R-A: https://lore.kernel.org/xen-devel/24658.7471.309734.168120@mariner.uk.xensource.com/ But AFAICT it's missing a repost with some minimal adjustments? If we don't get this in we should document on the release notes that Solaris guests will likely require 'msr_relaxed=1' option added to the configuration file in order to work. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 23 15:31:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 15:31:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100724.192070 (Exim 4.92) (envelope-from ) id 1lOj05-0002gd-Sb; Tue, 23 Mar 2021 15:31:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100724.192070; Tue, 23 Mar 2021 15:31:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOj05-0002gW-P9; Tue, 23 Mar 2021 15:31:21 +0000 Received: by outflank-mailman (input) for mailman id 100724; Tue, 23 Mar 2021 15:31:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOj04-0002gR-8I for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 15:31:20 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d2ae88f9-fb7a-4ef6-8253-df6987c91f49; Tue, 23 Mar 2021 15:31:18 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 17E84AD80; Tue, 23 Mar 2021 15:31:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2ae88f9-fb7a-4ef6-8253-df6987c91f49 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616513478; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1WA8CqcYb3xXb2VB7uZrlTmVh9WIGVIIeJ5A33NDqyA=; b=qBoYOBd6bYJEG57sLvccJp5L/V7+n4YT6s5tYXPZFWkritYDB5e27BYrNDeYn3QesrkWAZ iA4f3TqIlF48V6IOUo4JaSnLwxJ2ynbnMRzx9zvCcDemjynjCoLAwKVgMN0XRcyg1XVVrp I41WpAv2rj7XIcy1KxVeMTmEmb4buoI= Subject: Re: [PATCH] xen: Create EFI_VENDOR directory To: Ian Jackson Cc: Jason Andryuk , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel References: <20210322133301.11308-1-jandryuk@gmail.com> <09b5e7ee-b44b-a8ab-f29d-6617b6af93a0@citrix.com> <9b071192-a443-4bdc-8dac-107bbd4a0481@suse.com> <4b0ac6fa-cbe2-5b3c-fa61-52d743e07390@suse.com> <24665.61470.964721.635678@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <8099fca3-3ded-d137-a22a-95798d02cc74@suse.com> Date: Tue, 23 Mar 2021 16:31:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <24665.61470.964721.635678@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 23.03.2021 14:41, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH] xen: Create EFI_VENDOR directory"): >> On 23.03.2021 13:34, Jason Andryuk wrote: > ... >>> On Fedora, RPMs drop EFI binaries directly into /boot/efi/EFI/fedora/. >>> grub, shim, fwupdate and xen are all packaged that way. It seems >>> reasonable to have those important binaries tracked by the package >>> manager. >>> >>> Does SuSE populate EFI_VENDOR from EFI_DIR when some boot loader >>> script is called? >> >> Yes. And back at the time, when I consulted our EFI person, I was left >> with the impression that this is the only reasonable approach. The >> primary reason, as said, was that the EFI partition as a whole may get >> rebuilt perhaps even from scratch at any point. Hence it's not >> reasonable to expect package-managed files to live there. > > I agree with this analysis but it is for people like Fedora to decide > how they want to build their packages. > > There is also the case of ad-hoc packages (eg our "make debball") > which the user might reasonably choose to have dump things in the EFI > system partition. Well, it that's deemed reasonable, then perhaps yes. Albeit such ad-hoc packaging could then also involve the creation of that dir. > Conversely, I see no downside to the mkdir. Jan, is there some actual > harm in it ? If not, we should be accomodating to people's build and > packaging strategies even if we don't entirely approve of them. "Actual harm" is relative: Nothing's going to break afaict. There'll be a leftover dir from an install immediately followed by an uninstall. I consider such okay for the purpose of the install step that I did outline; I wouldn't consider it okay for a package install/uninstall. But nothing worse, I guess. So bottom line - my objection is not to be taken as a NAK. If everyone else wants the change, then so be it. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 23 15:32:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 15:32:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100726.192083 (Exim 4.92) (envelope-from ) id 1lOj0h-0002mN-64; Tue, 23 Mar 2021 15:31:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100726.192083; Tue, 23 Mar 2021 15:31:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOj0h-0002mG-2O; Tue, 23 Mar 2021 15:31:59 +0000 Received: by outflank-mailman (input) for mailman id 100726; Tue, 23 Mar 2021 15:31:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOj0g-0002m9-Ix for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 15:31:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOj0g-0000ml-EI for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 15:31:58 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOj0g-0001Ch-Cu for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 15:31:58 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOj0V-0002PL-4l; Tue, 23 Mar 2021 15:31:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=N/Hw4OYulQ/iGnxJmriBGRe+zuIhhZcLph/BpwEYHuc=; b=44lwZ4lOQPszyvaXrirMK9iAsi MhYYXxsZcWyPDt7RDu6LgUfQRv7sBjHFkH72PjDqBtSkMzxR22o/WilmcfAtwhX/kaWMIjBgwyVPL gct06cP0KuRCcbR3jY3FDp8543xhEtcB9yKVegFkLlQ9wJf5dpro4VqONP7Vqd9hll/8=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24666.2530.951003.624852@mariner.uk.xensource.com> Date: Tue, 23 Mar 2021 15:31:46 +0000 To: Andrew Cooper Cc: , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Juergen Gross , Wei Liu , Jan Beulich , , Subject: Re: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow In-Reply-To: References: <24666.1682.595069.435575@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) (dropping Frdric Pierret of Qubes, who was CC'd becausd of the Ryzen issue.) Roger Pau Monn writes ("Re: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow"): > So there's also the series from Andrew to allow Solaris to boot > without resorting to use the 'msr_relaxed' option: > > https://lore.kernel.org/xen-devel/20210316161844.1658-1-andrew.cooper3@citrix.com/ > > This has been R-A: > > https://lore.kernel.org/xen-devel/24658.7471.309734.168120@mariner.uk.xensource.com/ Thanks for pointing this out. You seem to be right. > But AFAICT it's missing a repost with some minimal adjustments? > > If we don't get this in we should document on the release notes that > Solaris guests will likely require 'msr_relaxed=1' option added to the > configuration file in order to work. Right. I still would like to see this fixed. But I think I would like to see it finished and committed ASAP. Can we manage that by the end of Thursday ? Ian. From xen-devel-bounces@lists.xenproject.org Tue Mar 23 15:39:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 15:39:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100729.192094 (Exim 4.92) (envelope-from ) id 1lOj7w-0003Bv-Vc; Tue, 23 Mar 2021 15:39:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100729.192094; Tue, 23 Mar 2021 15:39:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOj7w-0003Bo-Sc; Tue, 23 Mar 2021 15:39:28 +0000 Received: by outflank-mailman (input) for mailman id 100729; Tue, 23 Mar 2021 15:39:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOj7w-0003Bj-5J for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 15:39:28 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (unknown [40.107.1.75]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8b19534c-5cf1-479d-b067-3604f398811e; Tue, 23 Mar 2021 15:39:25 +0000 (UTC) Received: from AS8PR04CA0161.eurprd04.prod.outlook.com (2603:10a6:20b:331::16) by AM0PR08MB4211.eurprd08.prod.outlook.com (2603:10a6:208:101::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 15:39:23 +0000 Received: from AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:331:cafe::a7) by AS8PR04CA0161.outlook.office365.com (2603:10a6:20b:331::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24 via Frontend Transport; Tue, 23 Mar 2021 15:39:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT005.mail.protection.outlook.com (10.152.16.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Tue, 23 Mar 2021 15:39:22 +0000 Received: ("Tessian outbound 1b6dfb84c254:v89"); Tue, 23 Mar 2021 15:39:22 +0000 Received: from c89e4f24d179.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C10AAF13-8745-48D7-AE28-11FCAFDF8682.1; Tue, 23 Mar 2021 15:39:16 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c89e4f24d179.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 Mar 2021 15:39:16 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) by VE1PR08MB5247.eurprd08.prod.outlook.com (2603:10a6:803:10d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 15:39:14 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642]) by VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642%4]) with mapi id 15.20.3955.027; Tue, 23 Mar 2021 15:39:14 +0000 Received: from a75445.arm.com (82.8.129.65) by LO2P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.24 via Frontend Transport; Tue, 23 Mar 2021 15:39:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b19534c-5cf1-479d-b067-3604f398811e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cA+dwOzGZZMSncEvtsR8v1wR30ZJazGZNB8d4LHiXYU=; b=RVefpZ38ysph/ZjoZ/MBHZX9KzWaJOk+F0/I6Ulnwi+StZIyqlRlZP9Y+V96A+5X0y99NSyTsdahQ6O8+hYlpgpn4RbKcLTSN76yGQzApQF99HgvfpaMKbRVlOPtPi2ScxXCe6tI25Nm3xCqoCLzofYflaO9Ua7KM9ocK/udlF8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 9abf29e6e069d103 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VpSal36fpqDkeA/+IbJSiCwWTPVsdbZrpeEqwIlfaQNH+IwALzGtzXhnjko8BS3ruRBtEsQca4rS/yus9IiO49cxr5kkG+hNWizmig39wxGX4lHg3JaiMxDmIMJHCfnp/vBQzrPkauTb6qRcs4aJYGt/Opdyf9M9XZ6jGL2nfq6xALZTYQF6JVQW5N24wGR9lDTJToVX0LwXnFsLTU1bNWVQsaVMeNioBT9XNfz+wwYwq0F45f5bow/KxKdVP7B4Ku4b2oyMvLgmpHbmibq6P0cCUYfI1wjRNmkyD0Io9bWmWKAM1orBwcbqxpFBR/3+/Gxd/v/Fmn/bmgDrHw6vAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cA+dwOzGZZMSncEvtsR8v1wR30ZJazGZNB8d4LHiXYU=; b=jX+qzQxGn4M7G2M/ubQix1bDp7/7aHGY7HSnoWXD8Vy/IQ2h8QM6D4eQnji7e//at2T9Ugrz38MvB7oYfLnoVarF9NKwuJKzVMXGuPP/h/87fw2b7HIa4U7Qf9LE2wWfjWLgf+WVJB8w7LK5jMC0DWboMRkJJJGpE1aKaHPxa2Vv48Vc3d39uifOXdqpZnuvnCeab80pAKcZhMVDuklDeej2z5PP1s2vpJvhmyJk0o4pGvO7GMj0MhKFNjCrjUAP6SzfJUb1TY1nLVBfv8BIGetwHjiK7YykAki67iE5eFjvspdLU1gCKWaGVVTq7f1xkxBEcWNd5D5GBZtDJts+6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cA+dwOzGZZMSncEvtsR8v1wR30ZJazGZNB8d4LHiXYU=; b=RVefpZ38ysph/ZjoZ/MBHZX9KzWaJOk+F0/I6Ulnwi+StZIyqlRlZP9Y+V96A+5X0y99NSyTsdahQ6O8+hYlpgpn4RbKcLTSN76yGQzApQF99HgvfpaMKbRVlOPtPi2ScxXCe6tI25Nm3xCqoCLzofYflaO9Ua7KM9ocK/udlF8= Authentication-Results-Original: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 From: Luca Fancellu In-Reply-To: Date: Tue, 23 Mar 2021 15:39:07 +0000 Cc: "xen-devel@lists.xenproject.org" Content-Transfer-Encoding: quoted-printable Message-Id: <565C6475-4693-4A7C-8316-9613146300C2@arm.com> References: <1FAD6C91-2B3A-48F0-88D7-CFCFC8B53BA9@arm.com> <2BC82A95-DFB9-4F90-8CC6-AE39405157ED@arm.com> To: Jason Andryuk X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO2P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::19) To VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 5db10e64-9f4b-4c90-cfcf-08d8ee11d50c X-MS-TrafficTypeDiagnostic: VE1PR08MB5247:|AM0PR08MB4211: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kvB62FGkB4a9uagHRaWIVsrSYF/HXJeIHQE7nGICcC1lEdjV+cKc6+ji1Sy8ajDOwAeBNNZ87U9dlc1KZb78OG5Kh+2rvqyqJyKgm26jrYbwL9UUc+9H7JvAZXfVmHHZxl5IJY2/Ig2HZmrIjTsHErPsIxf0jjLXZKOtptY+/WKvdlgbottg6kUYPeUqiIEVyRWDS26/lhjzgfqo3u5IElcgtgz9HNOtGeInL3H7Y5JRJEQFlGn7AKmHIPo3FtSmpqUT1grT4h5nQXidvRE8xBXVpWWLekxAUXSTNYTGmk8q5q8Xt8bkbN0FineK82Ct3UbJh1l+j9jTNrrwJHrj0yfC9VoEdL50cHt9RKji/dKjKnFFe9aHCWiBttsGqq/ffHCznir1sBL19ZnfvasixjhNepjiPMISDeceovyR2eKr/1IKQewkrzQB5WuqsPrsDeCJPFXrYNzJ55ymKAcGNyCmY4YbsUSkZaCDUb0sNep0U9HNDTgqflAc4dtlwz1sHlcMsZ9H4TOX9uM6pDWA1MXYy+WV0p2DrU7Av7jMoLGIYQNJ3vJY0lEePuURtjOqlOX7c1JZMPL8VSK+K2CTypwfZE85YK/V/5etWyMxlHpgo/d3VkGboJfeNG5kdMuODU0KZr/GyX1+U912eOsA7zN4y29OlixyYkEeIVcVcUNrdL7jJ/+kNTkJeIF6NTAGA5+LwelzmcHCgGtzo2OA81jRg0tG9mBLxQ8QxHaXocOj1mcUFcw4daq/B1z8Nnqe2a5llKXFJlxO8HSwm/NmpQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3629.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(39850400004)(346002)(136003)(366004)(16526019)(36756003)(186003)(83380400001)(6486002)(4326008)(6916009)(316002)(6666004)(8936002)(26005)(2616005)(5660300002)(86362001)(52116002)(956004)(478600001)(66946007)(2906002)(38100700001)(33656002)(66556008)(44832011)(8676002)(7696005)(66476007)(53546011)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Y0VJMm5HOVM4dEN4YzI2dEFJVnNjaE0xa1B5NW5BbzJ2bkdQUHdTVmhwMVl5?= =?utf-8?B?RWlJU1BlZGpKK3Vhak1GZkNzQXd1TWg3b1JXUzl5ODNld1FtRFRKdG43RFRR?= =?utf-8?B?UDhBUlJnNDlvZ3VOSmtoSlo3VkpPT0NtWXVudWFnR1dJalBuZnJjYXRJUWZK?= =?utf-8?B?MzJERDUyRExvdW1FQVhIMjV1NFJYaXR5ZmxNVW16ZGxlZUZzZ0lxV0FXOTYr?= =?utf-8?B?cG94dStlc01lR2ZUSUN4Sm5WMEZ2VTRCR2t5bkhFTWh0a3VsMER1dEg2U29Y?= =?utf-8?B?bG9OUWo4SWVUTU51dGJzOVpCaXdjZDQwOVBSRUNMTXBqalh0eForenpaYzc1?= =?utf-8?B?emN0RVdGOVZybnpMYWVKZVlONXNXVHp0TitScVRWbW1vcXJETVgrUHV2a2hy?= =?utf-8?B?c3ZKNmZxc3dkb3VuUTVoNW0yWUUrWmNnNDl0SzZLdU9kNGFkZzNaZ0xFNDF6?= =?utf-8?B?M2xVOVBCTHptbjR6ZXliOTZCZENhemdoUEYrRzB1c2dYR1R3WmwvMXdyREFL?= =?utf-8?B?L0p2amNuRzlRUnpRSlViRGtSWU1rSU8wQXJ1UUd6VVJCeTR4SkgzMGlXK3Jz?= =?utf-8?B?YXR4V092UU5qaXptdmUwMjZFT0JpbmR1MlVyUUFlOEU3V1RuUFBRL0sxMXJF?= =?utf-8?B?UXJ3ZjVWazlFL09aMVRYenlRZDFta0ppTFFxQ3haZ3M5cHRjYndHeFliOEVW?= =?utf-8?B?ZFRxRmJMN3BsNVJHUkFSc2d1WWkzZWtlTlBIMlQrUGRwY0NqVWJISlljYnVr?= =?utf-8?B?cE1Xak5KVDlKc2hJalM1M3pEOEZ5VUZkWlV6NmJmUGZpc1Awc1VFNlVmeUZ4?= =?utf-8?B?aGZyM3ovLzZsNVNQYVA2eml2b0Foa2hqcll4dXhycWpwOGE2bXRzY25selJS?= =?utf-8?B?dlJrdGhFc2IzdWVEVG9zcjZWbjhMS1YvWG95aEN6aHZITW13VWYyaWFjcHBY?= =?utf-8?B?eEpOVFl1TWF6cXhKazQ4eFgwRzNUaXJRZ25RVTZlVnpqRWx5b2pQVlFtRE83?= =?utf-8?B?VFZqWGxhQUxNcTFxVS96dUVyWTltbERxNzFmNEgzZFduZWtPTFpGa3FDUnZx?= =?utf-8?B?K2t5NndJTE5TK1JMVUxUN1VWVlkyYldRMTV3ODEzUngzNjdSRDlLV3B4MnFa?= =?utf-8?B?WEVZeUZPVGtxRzduaWYxRHpWQXFqTmxNY3ZXL3BWazRtRENYVEM0TllaTUFZ?= =?utf-8?B?QWcreW1wa3pGVUFUSHlSaHNXUWdOU2RhZDNmdzJMejJ1L3ExMmkzamVvaEhy?= =?utf-8?B?R2xOTkMwQkdFbEQxNlNGNVBJaTBpNmgyTmV5UVZpRldsQ2dFV2FvRkUzbXgx?= =?utf-8?B?OUhWYTAvTVpQM1RTcnoxZ2tqUmVHQlNva2RlczJNNWI5T3RCaWpKQzh6YTd1?= =?utf-8?B?WUhSQXNkOW9JMldRdHdGbDFLVTAzMGdVM2ozVWhhMXd2MXdGM3JoczNxMVpM?= =?utf-8?B?MGJKWnJuanNEQ00raEhLV1ZuL1pwZmFUQ0xZajVXR1djSXIydFJZZ29RTy9P?= =?utf-8?B?UzhpZk9rQVZ6WTRCd2k0cUsyc1duRU5zWlhsRndrNnAwQnNyUzYvdUxHSXJy?= =?utf-8?B?ZnptWGNHcDJpZFlyc1pSalplU2dYWGpGU2diUHRNa1MyeDg1RUdvWnVmbmFp?= =?utf-8?B?L0p6V3hXKzJzSXJHVXRYVkxURUx5VDVYUlRVSmZKbHRhdmpEdS8ybVVqRitT?= =?utf-8?B?MnF4a3M4bHVQWmdIMUFHT1BpaFJxbTNta1kweGlvQ1lXOGJGemRkYTRXenFr?= =?utf-8?Q?Oqby29Yjcx5l42qajHOF62t4Ea3zcj2MHkxSvfV?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5247 Original-Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 6a72198a-cb97-4354-d298-08d8ee11cffc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O7rYP8nSaGkTBR/2+vlNyU63NsTHKcimaZ0fmd4Jf6cRXrturIXlCT5a+vkkwX5YaFTnKvnYwKJdY74Du2Xp2VdiWcBixm6f3ckM6TMeVCVxcAhjELro4Y3sKLnuixq3wZuvTQxBjn0n+yn9NjXaQ9hX7pR5lyQrgSEWgTCYM9Spd9D4v891V9DmeBV2mliHHP2KAs5Hwi5wCG5pbWJivHzQEULabjCPOWSg9HcsBGbGmQ/Lx1AOVXjQqPp+15uR9/S1vbcH6/SKmW4l3EYgFZA+xV8IiYT6aE3CbxHdOizhqdh6SHbYsI+vk23kiMKPxS6rIWce1J9w16Go+g1A3r6VyyklpidgrDHMAPyRZGwM46V+iC1gWxcGLjMaqJB9Dszk48ySSyt6umqTeE7mgzpgw4Ff1Ion5dk6DXfnMG/4BOYB1Jfvy9yyfx5A2p3YCAaHjQ7bxXFhmc4FScSy4/tZCMQihagUqMYid1UjaWrlzzxtszUOf8aIr0FtDywfJ58VXvYZ23GBCI8PQ5NsxyYms2CrsDN5oZiMwS66yu14FGyYuxb7p2XAdgKOONpcwBPnoxVNKxovZ56AefKGEzavMMTCjTNKFNy5YSIA+xn7OYdvy741jhje0+MhZcSFsLIcJt/oS+35ZrDaeukp+o4rS2M13ejctYuTGzEBzj1v7C6y/J0g+GZXopCHQS5PjWv4sckPUR3WcrNvSmxp6nzd6EciJkFwmZZpRMxymR4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(396003)(39850400004)(346002)(136003)(46966006)(36840700001)(81166007)(5660300002)(36860700001)(6486002)(82740400003)(8676002)(82310400003)(44832011)(186003)(8936002)(478600001)(33656002)(16526019)(2906002)(4326008)(70586007)(36756003)(6666004)(26005)(7696005)(6862004)(2616005)(70206006)(336012)(83380400001)(86362001)(53546011)(316002)(47076005)(956004)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 15:39:22.8612 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5db10e64-9f4b-4c90-cfcf-08d8ee11d50c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4211 Hi Jason, Thanks for your hints, unfortunately seems not an init problem because in t= he same init configuration I tried the 5.10.23 (preempt_rt) without the Jue= rgen patch but with the BUG_ON removed and it boots without problem. So see= ms that applying the serie does something (on a preempt_rt kernel) and we a= re trying to figure out what. > On 23 Mar 2021, at 12:36, Jason Andryuk wrote: >=20 > On Mon, Mar 22, 2021 at 3:09 PM Luca Fancellu wro= te: >>=20 >> Hi Juergen, >>=20 >> Yes you are right it was my mistake, as you said to remove the BUG_ON(= =E2=80=A6) this serie (https://patchwork.kernel.org/project/xen-devel/cover= /20210306161833.4552-1-jgross@suse.com/) is needed, since I=E2=80=99m using= yocto I=E2=80=99m able to build a preempt_rt kernel up to the 5.10.23 and = for this reason I=E2=80=99m applying that serie on top of this version, the= n I=E2=80=99m removing the BUG_ON(=E2=80=A6). >>=20 >> A thing that was not expected is that now the Dom0 kernel is stuck on = =E2=80=9CSetting domain 0 name, domid and JSON config=E2=80=A6=E2=80=9D ste= p and the system seems unresponsive. Seems like a deadlock issue but lookin= g into the serie we can=E2=80=99t spot anything and that serie was also tes= ted by others from the community. >> Do you have any idea on that? >=20 > I think this can happen if xenstored isn't running. Client access to > xenstore blocks until xenstored becomes available. So check your init > scripts ordering. >=20 > Regards, > Jason Cheers, Luca= From xen-devel-bounces@lists.xenproject.org Tue Mar 23 15:59:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 15:59:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100736.192107 (Exim 4.92) (envelope-from ) id 1lOjQq-0005HU-KN; Tue, 23 Mar 2021 15:59:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100736.192107; Tue, 23 Mar 2021 15:59:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOjQq-0005HN-HD; Tue, 23 Mar 2021 15:59:00 +0000 Received: by outflank-mailman (input) for mailman id 100736; Tue, 23 Mar 2021 15:58:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOjQo-0005HI-Om for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 15:58:58 +0000 Received: from GBR01-LO2-obe.outbound.protection.outlook.com (unknown [40.107.10.112]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ab564dd1-ae34-4233-bada-111d9a4ebd40; Tue, 23 Mar 2021 15:58:56 +0000 (UTC) Received: from LOYP265MB1998.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:113::8) by LO2P265MB0032.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:6a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.25; Tue, 23 Mar 2021 15:58:55 +0000 Received: from LOYP265MB1998.GBRP265.PROD.OUTLOOK.COM ([fe80::c8d3:288b:f514:37fb]) by LOYP265MB1998.GBRP265.PROD.OUTLOOK.COM ([fe80::c8d3:288b:f514:37fb%4]) with mapi id 15.20.3955.027; Tue, 23 Mar 2021 15:58:55 +0000 Received: from broadband.bt.com (2a00:23c6:751d:7701:63ab:f041:c036:824f) by LO2P265CA0334.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.24 via Frontend Transport; Tue, 23 Mar 2021 15:58:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab564dd1-ae34-4233-bada-111d9a4ebd40 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jQVlo5urUQXlqim8nlJ4yuXOAgp65C3FN7SlTHwSM+Cb7fP0l1USM0YyrUIb7E42z2aVOjNwtwAlLSt29RsG9+anjgGGyAdtAzFg3Eg91hp4mNe39xsgDrhwdOiFMGkOGzFn+bXtzwY9QbiRBh29PW//sR7XjoyM0UAifUVTYCrfr+4Y6CBuFor3KRjLWT0V5gjiY4FnGIqhquSDMqPPNxEgtBChVHqbnZd4+gAcS9wfCtHtOanGRYGeQEHsIjyvtou1OEUVjSEkaMy5CV/jLXjHp6xJWdoMtnO/C/YWeeipkeEgU645wtmoVMTBl63XN/zhlyXO6uJoYPP4Vl1tYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qXJWkQg2RucF4w7bB9+7xhnq09sNwbk0FJm2HA8euMU=; b=cvNdn8kxYbo8E5KRE4b9wWWuHZoB3pVJqrJ23UnwEb0Ku5RArCsZwNeptM7ohcO5qOVWwp+1lILoA/HeyLB943C5o1q8M2wSn8Cu9tzAvdO4TNf1Fns1gvp2s4NhAbQIpI5gTiZkEiis/RJ0fXtwVlogM1YescezG7SqN+4VLnaJf2zD1CdnxBQAws3SsVBQ36xu+qZZ9PGpHPmx+sEZyEVLtdWLu/MBEoq+SjUl7nSwnHrjiEMRnvmjPy2AJiRxL8CQ3UmGZmh7ZQkBl/IMq9F5nza7QiHC8zKHP8DUd8ivb/CvF5sxFDQ1gvMUXHX29kEaHSh5+Mmxi2p0IN65Og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=durham.ac.uk; dmarc=pass action=none header.from=durham.ac.uk; dkim=pass header.d=durham.ac.uk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=durhamuniversity.onmicrosoft.com; s=selector2-durhamuniversity-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qXJWkQg2RucF4w7bB9+7xhnq09sNwbk0FJm2HA8euMU=; b=E/n1uNc9zkn132pnObSNsDyWa2Qgn5X3CBQJHy6ncLFLtshd6GMKaAoXpzigB3iTuPb6qKlsxzhVEtmKLNo8xqhO2cH4dC3hr8L6AbJkQEmIuDpgdG+DVeCEqo8IP1U2FLaoeGKqSJsW6/Uuid26LlxJfBn4lFL1r6EspQWSyhU= Authentication-Results: xenproject.org; dkim=none (message not signed) header.d=none;xenproject.org; dmarc=none action=none header.from=durham.ac.uk; Date: Tue, 23 Mar 2021 15:58:54 +0000 (GMT) From: Michael Young To: Ian Jackson cc: Jan Beulich , Jason Andryuk , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel Subject: Re: [PATCH] xen: Create EFI_VENDOR directory In-Reply-To: <24665.61470.964721.635678@mariner.uk.xensource.com> Message-ID: References: <20210322133301.11308-1-jandryuk@gmail.com> <09b5e7ee-b44b-a8ab-f29d-6617b6af93a0@citrix.com> <9b071192-a443-4bdc-8dac-107bbd4a0481@suse.com> <4b0ac6fa-cbe2-5b3c-fa61-52d743e07390@suse.com> <24665.61470.964721.635678@mariner.uk.xensource.com> Content-Type: text/plain; charset=US-ASCII; format=flowed X-Originating-IP: [2a00:23c6:751d:7701:63ab:f041:c036:824f] X-ClientProxiedBy: LO2P265CA0334.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::34) To LOYP265MB1998.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:113::8) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 15a22189-970d-4e42-8f36-08d8ee148fa1 X-MS-TrafficTypeDiagnostic: LO2P265MB0032: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7BVWhRJy+7Vu8sc6wYVXmkg/SF7msm8b/5D2E9LmaTfWXIqu2ZPX+vLqKeqGQ4/60Y9X30tdFBeYLt/V7jD3CswEWAyNyC+OActkQmp+9G+VXUeDOrVIhTVkF1koHe23xkI8Og5Tid2il1ewH0IjVOqrCGmfywFgxSRtfLMYQcAAm0xyDqB6EEuauU/tL9TwhPF0tjLaej67HJpXmTwFnaInaLbuOkc+/5VISvRqPQnPaHl9Zjw4s5U5l+9IBSPDBJSRZOl1m3jK5Gkprb0CSjN2od06sAcxDvyICJZfHgXjCDDDBc3kKID2odUWn1VXQWOj/y2iLJ47DBVL4gDTvZPNGsyT55y1IzQtm9f8+a94fGeyXLRM1Zo4tRigFjx/YXfbCuPSGrLsOfUc5R9d0nWIqeEU454PlfDxxqPgYyGYi8oJlfko3qkx019W64Fh3ZVXGHna5moKwnI451lgydyns0BES+BDzn9Xay6JtjwZJXDJnfDn1+zwoTE7f6IwImsXkQ1wTyLLtSYxetkhYQXr483MIs072AJfkZvb9cOqxWewyC40cMHeaJTMuMznuRWvASYyobPEE3/T6b8d8pchggmaZoyKXRGDHmUPVyA/KfzL77wbGK2durLuOJvcbkUOZYN7gFfqjZQAz56bl9qIZAquvxo9Aznz5DChNrWCObmVTq6V/HKKU1pftPDw95XG46eIrD6iGouh2z5xRtf/UYphY/qVqMbeg46aD6s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LOYP265MB1998.GBRP265.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(9686003)(4326008)(6486002)(6512007)(31696002)(52116002)(66556008)(66476007)(38100700001)(6506007)(16526019)(83380400001)(86362001)(498600001)(186003)(54906003)(966005)(8676002)(5660300002)(31686004)(6916009)(53546011)(8936002)(2906002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?uws7W7CMlJ6ktpHWDD0ACyeOYswM/2R/MlbfiZ0DzcxLkz7X0xRXGEosSzy7?= =?us-ascii?Q?hifPiWMbdS9p+VDbKgC/fwfFGfd59ptV6pm2bzNjmXrf5aZT9wurbXl3E7t6?= =?us-ascii?Q?CYSk//LHXroocWo9FAH2s5V++8Z3OJrEKLnn1H6rPoghT33xkHTaMGfuMV89?= =?us-ascii?Q?BMWw0d1TI+bljuvBInISMGFU5/wVUPbSsZFWKw+tLSI/0seQtsmabrRFesGF?= =?us-ascii?Q?IrRj9NLTzuUR/inmPSeXxOXexCLN5zgPrsUFxldrLOkzJLz21GDbYe7Kc0LJ?= =?us-ascii?Q?vuooEoHzzJOnSbXLTr9GUDGrBhcsAdwNZEqeqPMLa4liZmBjoSQ/3B4pYUW0?= =?us-ascii?Q?PJtcVbthBlpuQfLEe+s6gN29AsoA2F5tOQF7yoggiRKTgJ+5XajT1e82arj5?= =?us-ascii?Q?3z2n24LafHBJqJILXCFBHuXLptdcDp1CS3t5oGw7nMiCN6aaMNNoY8S9GAyA?= =?us-ascii?Q?0F0xp0x5r8c8rjibgJLya0VrLZ0ZNq+xX6p11HV7T4R0TFo8doScZ2xXy38V?= =?us-ascii?Q?os+NR0NVerbFCEH7r1G3E6/kELMmYgIJHtx8+jRFS3mhPe/oOOdnRmMVFMyQ?= =?us-ascii?Q?kPma6HOSeGfhqbVPyjDrYXTPTZL+I45S8H/MOYJe1fUO5d8S1OF5vVBkOnee?= =?us-ascii?Q?UXQISL4ooP9+2U4EIyMf/49P35VuhPiDJ8gG9k+RVyWubKzoiLpVQ7QpwMsy?= =?us-ascii?Q?hcVi3mWLgc5T0B27fqBUJmNOnthQAGlIlA2GhkS2UyselZRnGpEWFUxE0l3Z?= =?us-ascii?Q?f2l68gQklcTWGsJGq+ZY0IRzgL/fL4NnvrusoQN2bZG37eVxk0+MWKXCV8VT?= =?us-ascii?Q?yFBjr5K+6d1DV6GXNo/BXi8xvy3ePOMTbnZs2Oxlx7psuVHdrRMLfzo19Whb?= =?us-ascii?Q?cDERddgZd9xc5PWN/wlUsQFWM7WVev3FD4V+a/S7SXy9DNClvzAeadVzpfz0?= =?us-ascii?Q?SaHlWj2YQic8hRGbfqOB7vBCE7bKdN51IUoHdu40a+gGUQKkjZd+GivLxKEr?= =?us-ascii?Q?qu5SVEYmn4bNloCNooca1fBhy+LMtSzaqFD5juc5XZNe6iBvNqMQuU4lXAHx?= =?us-ascii?Q?7lJdk5rayaAQhIj0s5+F9B7Q+UsC8kv6gvB/cPr0B9DpgeX5QABaOfrMoIVa?= =?us-ascii?Q?8HDCbsWjOmwVlnRCOBAPq55Qw8i/jfaQALz5jZnJ4B5jzMUawodDP846dPzK?= =?us-ascii?Q?UGvsgz2hKFz8zcbfmmH9IK+bKzFc8cVlsgDaZfJOkKtOGbcBDY2jf/AJ2Ju6?= =?us-ascii?Q?t9lJUAQYa3iQ5Bvwd0A5BUaj6iVObw6wNrZhwM9yBPxsrcsk258ytrpKqlLk?= =?us-ascii?Q?xI+W5ABx+n31hIIMwMe7xAgWrEjTliBa24ymZ8RPJh2jObjWtU+s1pYxAmKn?= =?us-ascii?Q?R0aDu3hK4gQtIsYYTzN72ZJ+8Bd0?= X-OriginatorOrg: durham.ac.uk X-MS-Exchange-CrossTenant-Network-Message-Id: 15a22189-970d-4e42-8f36-08d8ee148fa1 X-MS-Exchange-CrossTenant-AuthSource: LOYP265MB1998.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 15:58:55.2219 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7250d88b-4b68-4529-be44-d59a2d8a6f94 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g6exziuiMK13W77l+BPPlS4ISEtHBKt564vQkUYLgdMHaAD1Dz9TXCXxLbqDUP0qvnXDWEXVptFKNhPmkT+XgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO2P265MB0032 On Tue, 23 Mar 2021, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH] xen: Create EFI_VENDOR directory"): >> On 23.03.2021 13:34, Jason Andryuk wrote: > ... >>> On Fedora, RPMs drop EFI binaries directly into /boot/efi/EFI/fedora/. >>> grub, shim, fwupdate and xen are all packaged that way. It seems >>> reasonable to have those important binaries tracked by the package >>> manager. >>> >>> Does SuSE populate EFI_VENDOR from EFI_DIR when some boot loader >>> script is called? >> >> Yes. And back at the time, when I consulted our EFI person, I was left >> with the impression that this is the only reasonable approach. The >> primary reason, as said, was that the EFI partition as a whole may get >> rebuilt perhaps even from scratch at any point. Hence it's not >> reasonable to expect package-managed files to live there. > > I agree with this analysis but it is for people like Fedora to decide > how they want to build their packages. > > There is also the case of ad-hoc packages (eg our "make debball") > which the user might reasonably choose to have dump things in the EFI > system partition. > > Conversely, I see no downside to the mkdir. Jan, is there some actual > harm in it ? If not, we should be accomodating to people's build and > packaging strategies even if we don't entirely approve of them. There is a request in https://bugzilla.redhat.com/show_bug.cgi?id=1750733 for xen on Fedora to install the efi file elsewhere and then copy it to /boot/efi post install. I could change the current Fedora set up for Fedora 35 (which should have xen-4.15) if there is a good reason to do so. I am not sure how useful the xen.efi file in /boot/efi is anyway for the the Fedora set up as it will generally use a xen*.gz file in /boot via grub. Michael Young From xen-devel-bounces@lists.xenproject.org Tue Mar 23 16:15:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 16:15:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100741.192123 (Exim 4.92) (envelope-from ) id 1lOjgY-0007iq-1K; Tue, 23 Mar 2021 16:15:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100741.192123; Tue, 23 Mar 2021 16:15:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOjgX-0007ij-UF; Tue, 23 Mar 2021 16:15:13 +0000 Received: by outflank-mailman (input) for mailman id 100741; Tue, 23 Mar 2021 16:15:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOjgW-0007ia-4Q for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 16:15:12 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 912cd9cb-1466-41dc-8659-8e902694f50c; Tue, 23 Mar 2021 16:15:11 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8821CADAA; Tue, 23 Mar 2021 16:15:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 912cd9cb-1466-41dc-8659-8e902694f50c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616516110; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NnSchVe5Sd8n1SbhskQmhu9C+dFhNe9VTvxTj9olY6c=; b=ToXSX4tYtplZg3iZnBAGeQVF7Is3Zu6E3FBOpptOsdsour3WoxOw7wzGwGKx55h1WZ9DtD ph1WMJKfLnJBVZDu0YpKWgtduL3s8GS9q4B4kcs+JNUfnKN/o3hWWbIgdBpOFEHT2ojjaF +lCOD7oL2XNfooVj48RQlQKZKzjtDio= Subject: Re: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow To: Ian Jackson Cc: xen-devel@lists.xenproject.org, community.manager@xenproject.org, Andrew Cooper , committers@xenproject.org, Wei Liu , Juergen Gross , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= References: <24666.1682.595069.435575@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <0bfab829-3841-b2cd-96f9-874340cf75c2@suse.com> Date: Tue, 23 Mar 2021 17:15:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <24666.1682.595069.435575@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 23.03.2021 16:17, Ian Jackson wrote: > I have reviewed my list of blockers and the conversation that followed > and there are just three areas that are still of concern to me: > > * io-apic issue on Ryzen 1800X > > Related Qubes issue tracking this: > https://github.com/QubesOS/qubes-issues/issues/6423 > Information from > Jan Beulich > Andrew Cooper > Frédéric Pierret > > Are we likely to get a fix in the next few days ? Afaic - I'm still lacking certain bits of information to even think of possible solutions. > I think it may be time to reconcile ourselves to not fixing this, > and deciding on a suitable plan B. Do we need to put something in > the release notes, or SUPPORT.md, or implement a mitigation of some > kind ? One option of course is, like was just done for 4.13.3, to revert. Iirc Andrew had some thoughts towards making the new piece of code conditional upon the original issue actually hitting. Another (somewhat similar) option might be to hide the new piece of code behind a default-off command line option. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 23 16:53:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 16:53:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100746.192141 (Exim 4.92) (envelope-from ) id 1lOkHM-0003L9-0n; Tue, 23 Mar 2021 16:53:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100746.192141; Tue, 23 Mar 2021 16:53:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOkHL-0003L2-Tp; Tue, 23 Mar 2021 16:53:15 +0000 Received: by outflank-mailman (input) for mailman id 100746; Tue, 23 Mar 2021 16:53:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOkHJ-0003Kx-Ur for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 16:53:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOkHJ-0002e6-Qw for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 16:53:13 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOkHJ-0000Wd-Ox for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 16:53:13 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOkHG-0002au-IR; Tue, 23 Mar 2021 16:53:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=BvoZTo5swmqmWjAIhmdG3QAN4H7/hSNkplL5xeVp2AU=; b=wF6CSwL+zUvFEwdgcRvOARil5S egYZCskBa2WgUv5pusMn3ALoRCnzLGMxzLVponNZ4EWlZOzy41+Jj4aSnhyC0Brk0YEcV01R2Dkju TJ6CSuVI3lWylUv3RWjYXZ+R7jxl4UeLqkkxRpQz7vfqHdUKjC8a060ImOs0OeOlnDDA=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24666.7414.232768.961456@mariner.uk.xensource.com> Date: Tue, 23 Mar 2021 16:53:10 +0000 To: Jan Beulich Cc: xen-devel@lists.xenproject.org, community.manager@xenproject.org, Andrew Cooper , committers@xenproject.org, Wei Liu , Juergen Gross , =?iso-8859-1?Q?Fr=E9d=E9ric?= Pierret Subject: Re: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow In-Reply-To: <0bfab829-3841-b2cd-96f9-874340cf75c2@suse.com> References: <24666.1682.595069.435575@mariner.uk.xensource.com> <0bfab829-3841-b2cd-96f9-874340cf75c2@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow"): > On 23.03.2021 16:17, Ian Jackson wrote: > > I think it may be time to reconcile ourselves to not fixing this, > > and deciding on a suitable plan B. Do we need to put something in > > the release notes, or SUPPORT.md, or implement a mitigation of some > > kind ? > > One option of course is, like was just done for 4.13.3, to revert. > Iirc Andrew had some thoughts towards making the new piece of code > conditional upon the original issue actually hitting. I would be very happy to consider a revert it someone would give me references and explain to me the implications in words of one syllable. > Another > (somewhat similar) option might be to hide the new piece of code > behind a default-off command line option. Likewise. Sorry to be vague but I feel quite ignorant here! Ian. From xen-devel-bounces@lists.xenproject.org Tue Mar 23 17:02:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 17:02:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100749.192152 (Exim 4.92) (envelope-from ) id 1lOkQE-0004Sh-U6; Tue, 23 Mar 2021 17:02:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100749.192152; Tue, 23 Mar 2021 17:02:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOkQE-0004Sa-R6; Tue, 23 Mar 2021 17:02:26 +0000 Received: by outflank-mailman (input) for mailman id 100749; Tue, 23 Mar 2021 17:02:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOkQE-0004SU-A2 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 17:02:26 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 18478468-362f-42bb-be53-d175361308a5; Tue, 23 Mar 2021 17:02:25 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 461E7AD4A; Tue, 23 Mar 2021 17:02:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18478468-362f-42bb-be53-d175361308a5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616518944; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6WZPEt7+j7Dula8GKruSy3kfukKaToM3CKCXJX7/QoE=; b=OtIptgrT16Szsz3+mqKe9JvQh32/NiN9zW5m2Exs5RVcTXZcMwozetnT1mRrGLU/nGQAMC 4+FasF8jlHwPfTYMbaUwU1QtlY22pL/8+73NaXe7g8bLlTuJQJ9ujKn/+l+4JqKkjVuGjg 011h2vfK+BFQ9noszhII4o1fztKv4uc= Subject: Re: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow To: Ian Jackson Cc: xen-devel@lists.xenproject.org, community.manager@xenproject.org, Andrew Cooper , committers@xenproject.org, Wei Liu , Juergen Gross , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= References: <24666.1682.595069.435575@mariner.uk.xensource.com> <0bfab829-3841-b2cd-96f9-874340cf75c2@suse.com> <24666.7414.232768.961456@mariner.uk.xensource.com> From: Jan Beulich Message-ID: Date: Tue, 23 Mar 2021 18:02:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <24666.7414.232768.961456@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 23.03.2021 17:53, Ian Jackson wrote: > Jan Beulich writes ("Re: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow"): >> On 23.03.2021 16:17, Ian Jackson wrote: >>> I think it may be time to reconcile ourselves to not fixing this, >>> and deciding on a suitable plan B. Do we need to put something in >>> the release notes, or SUPPORT.md, or implement a mitigation of some >>> kind ? >> >> One option of course is, like was just done for 4.13.3, to revert. >> Iirc Andrew had some thoughts towards making the new piece of code >> conditional upon the original issue actually hitting. > > I would be very happy to consider a revert it someone would give me > references and explain to me the implications in words of one > syllable. Reference: e1de4c196a2e "x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating" Reverting would unbreak Xen on the Ryzen 1800X system where the breakage was reported for, and likely a few others. It would at the same time re-introduce Xen failing to boot on at least some Icelake (and yet newer) systems. >> Another >> (somewhat similar) option might be to hide the new piece of code >> behind a default-off command line option. > > Likewise. Well, not sure what to say here. Introducing a command line option to allow making Icelake systems boot (by use of the option) while keeping things working by default on older hardware is about as simple as an explanation here can get, I guess. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 23 17:07:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 17:07:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100752.192165 (Exim 4.92) (envelope-from ) id 1lOkUq-0004cx-GM; Tue, 23 Mar 2021 17:07:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100752.192165; Tue, 23 Mar 2021 17:07:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOkUq-0004cq-D5; Tue, 23 Mar 2021 17:07:12 +0000 Received: by outflank-mailman (input) for mailman id 100752; Tue, 23 Mar 2021 17:07:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOkUo-0004cl-NP for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 17:07:10 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:fe0d::627]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 478eaa4f-0b41-4203-9a08-d5be497a4aaa; Tue, 23 Mar 2021 17:07:07 +0000 (UTC) Received: from DU2PR04CA0279.eurprd04.prod.outlook.com (2603:10a6:10:28c::14) by AM9PR08MB6194.eurprd08.prod.outlook.com (2603:10a6:20b:2d5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.24; Tue, 23 Mar 2021 17:07:05 +0000 Received: from DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28c:cafe::16) by DU2PR04CA0279.outlook.office365.com (2603:10a6:10:28c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Tue, 23 Mar 2021 17:07:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT006.mail.protection.outlook.com (10.152.20.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Tue, 23 Mar 2021 17:07:04 +0000 Received: ("Tessian outbound f15357ab733e:v89"); Tue, 23 Mar 2021 17:07:04 +0000 Received: from 08a8de55d784.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8EBDA577-0DDF-465F-8076-872280E8DF8C.1; Tue, 23 Mar 2021 17:06:52 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 08a8de55d784.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 Mar 2021 17:06:52 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) by VE1PR08MB4688.eurprd08.prod.outlook.com (2603:10a6:802:a3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 17:06:50 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642]) by VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642%4]) with mapi id 15.20.3955.027; Tue, 23 Mar 2021 17:06:50 +0000 Received: from a75445.arm.com (82.8.129.65) by LO2P265CA0229.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.24 via Frontend Transport; Tue, 23 Mar 2021 17:06:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 478eaa4f-0b41-4203-9a08-d5be497a4aaa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2gJMI/JRdY9brm2ekNNIX6nBtQno/t7ociY5F+FOE74=; b=ybuih+Hr/Z4LsScleHoQl6A/bs6B+DaifU6oVAl+y7s/4jItk1c9pulTT0FaK3z8D3MeWjE7NRvc2KiMcbV74y4GtI/F8naPvFNvKroJjqIyOXYg+Fn53qDJyC9c5LuhUgBOJHZprHn72xX/TyX1q19GBb2nEk3RjWhmGlWWLS0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 575b515e21fe6b5e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KxT65rz1iufRP3FZMV84Yt2yR3UO/Y3V5AkI/QA+tk1CVhXlrjbcQ43XDxuhlOvl1wOYauxOe28BgJYSSrANKnT5bsvsg9h1vlNP+ZSVA2jb4oZ+bmuS2xkqixJv5oqQl8LkSoJwgrOCf5Hrw0VN2akNtDRGUN/mq5r2fAfJrlhCoQCtTbfqnLWj2lL3VenMRW3tJxeGYvmt49H5BzLrI2fWxdXXwuNzK01vmZXy4RPVMj98oYujlW9oO6TvkQz0bz9G7inweGyT3943PMdkC6QdsFhIfGPIr3r8Lf9fQDqxIDMBv4ylMDb6RZqM46F3tHXEzBDJhfAIk0pOmnG3NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2gJMI/JRdY9brm2ekNNIX6nBtQno/t7ociY5F+FOE74=; b=mj2Qw+ers3kZVjuhto9oz0lVSBsa1FtQkCuHATisObeR5ysInkMIJuUd3LVnu9q7teh7uRA48odhfnWxOfxJsDhPUGca0r8feK2ch2KMgEZ6/XOZD/FAG7uvhxgVUWO/cMhWHq4JvLN35HiKgCweeExviiQgwxnVoTsbjRVmlWq+zmxTXFYyczMHIHHomq2lM4k/7cuL1ObMEEHN3dPYus6Q2xOyElTrHSF4aC7KTjH+lvM1BsOfhnMSNbHpRvq3iOR6oObvZCxMsGWpXHvpn2cuMSqRtE6SPZG7aE06flsZYoK3Z/1gISeGeiJpdkeyICWNIvUjL+sdVpxFRvV86w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2gJMI/JRdY9brm2ekNNIX6nBtQno/t7ociY5F+FOE74=; b=ybuih+Hr/Z4LsScleHoQl6A/bs6B+DaifU6oVAl+y7s/4jItk1c9pulTT0FaK3z8D3MeWjE7NRvc2KiMcbV74y4GtI/F8naPvFNvKroJjqIyOXYg+Fn53qDJyC9c5LuhUgBOJHZprHn72xX/TyX1q19GBb2nEk3RjWhmGlWWLS0= Authentication-Results-Original: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 From: Luca Fancellu In-Reply-To: <565C6475-4693-4A7C-8316-9613146300C2@arm.com> Date: Tue, 23 Mar 2021 17:06:43 +0000 Cc: "xen-devel@lists.xenproject.org" , =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= Content-Transfer-Encoding: quoted-printable Message-Id: <2A09774F-ADDF-41B0-8E72-DC0FA0A6B1F3@arm.com> References: <1FAD6C91-2B3A-48F0-88D7-CFCFC8B53BA9@arm.com> <2BC82A95-DFB9-4F90-8CC6-AE39405157ED@arm.com> <565C6475-4693-4A7C-8316-9613146300C2@arm.com> To: Jason Andryuk X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO2P265CA0229.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::25) To VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d18b5f3a-696c-4385-a543-08d8ee1e1551 X-MS-TrafficTypeDiagnostic: VE1PR08MB4688:|AM9PR08MB6194: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9ftpG99ilUvP3GZ2WRa5Iwv5P/5RpT1Np9B88HWhNm3p5Aw1NmPTJYXWgA7oj23CljE+3Mce1IjzAJpcPzXNanpVeb2XMsXXcxNrhB2zE7sjwOtPo3RVlRBz5kaKdvrB8jPqc1rfntELFr9g34WG6+1eh8QM0Wp1DLeIsl5sDsm5Q3jj7ExWyxdxEdrQpQyXuEIq41eth4jJwvyb2IiHn/WqMiLQ2pO16WeEgYWwu8IT5NfrsSdNlFS4L6MRGCx/PvpC4frU+IX7mG83Rn3/3DVGaEYnuQ9CbtcDDCLhqBSV6JHr+ALr4zcBbah+d8Wm0Hwz0ziprj6wY1nSADRfnk8kmlFClDZjVGe+lW9cRFC4wbq8uKS2rTKB4wr1eoXQqXO1DQU2AL6/aTwe9yfUbLYr2RQviAaNxb+TYmzDuu4DgGWBp+Cnw9Fr/hJecXjkTg9bWoqfl4JuF8I9kTp6dBs69P83EeBKKyyEZqsFaUCb5/9yGmOtTz2cFFIVXGdinEytQaS7QPmjWn8311J7T+e5RoKKeEI0HBna0uxhmU6FPN1n/IrDlVdbTH8cnZdRd3UpvDl8hjnHwiPZtHC7Fb8H5SOGAueeKMZJobxFICzNBIACukJsUU+xz3g7l9yFdeCUHuJKHkgWNFhePONlPKgG/GvCbnT5rhULk2sxdLOn/bnC5/ixaigZ8EiwSvDtV+WwsJMdkWcJ/zLwpfJoNHm9DfulZcQirtH/KtreKSoUktZLuAUz4SAxWpLA6v6Guy5Ay5X/QehW90HtALNE+Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3629.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(376002)(136003)(396003)(346002)(66946007)(52116002)(66556008)(66476007)(36756003)(4326008)(8936002)(7696005)(6486002)(86362001)(478600001)(53546011)(83380400001)(8676002)(2906002)(6916009)(38100700001)(33656002)(54906003)(16526019)(5660300002)(186003)(26005)(316002)(956004)(6666004)(2616005)(44832011)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NjdwczJsaWRrUUJWb09rcE94aWpSUzg1QTQrWms5RFFIUVhKaStPNDZUSGg5?= =?utf-8?B?dTIxMFhBRThNODlmbWwyZkRPV21qdG1zbXQ3YTR1dUNOMTZja09GYUhtZVFo?= =?utf-8?B?SzdEc1NSeTg1bWxVNUtqQ0ZKMFk3MnhhTmwvK0FiTHpZUlpDUGR1NlZPZHhJ?= =?utf-8?B?Z2piamR2cnhITWVnWWlobG55WWZ1dHBZVjZGbFFXZTZEQ1hrb3dGNXpZeW1Y?= =?utf-8?B?RXBidEUyV29TUHBhWXBUdFFZc3pVdFNqbEttem9ScVNhblI4cXFHTE1qRUJB?= =?utf-8?B?U3A3V2w4NFlROU40L1NnaEdiMmxDdGgwOWljdGZEdUxQZERmVXRXRnJnWlZ6?= =?utf-8?B?SThQeFl4dFBzYldYZWJTSzFOdkpPNnlLV2JFMHNCZDBidlpCQndDQVFXQ1Bt?= =?utf-8?B?S3I0b1F0NEdEbWZ4UTcwdElPWGI0RVBWeFJabWZYMXF2ektGdEpXeGg0K3Vw?= =?utf-8?B?Qi9TeDNJbW9uRzlxaE01WGUxaUhaQjdvMjRIV3VKc3dVOVFNbHI3dU1lY3JN?= =?utf-8?B?RUYyVitnRUpGeDk1NnFnSmppaFQzN29PZG8wT0k4NElXTzBKYy9ZV0o2RG03?= =?utf-8?B?MjY1bXd6Z1ZuSllseERNQnI0RWpxYmpCSldxSDk4ZDk1VDlmQW10eWs1MnZu?= =?utf-8?B?SGlURWIyekpxOGVvS29Gc2RsZDdGdzRhbE02Sm1NeEg2anczd3B2bFBUdXNZ?= =?utf-8?B?VE4wbmRNVE1laVVWR1BYR1pCOGY1KzRxMnArcDZ4aFgreHVYWHgvOEJGZjBj?= =?utf-8?B?cHR4S1o1Tmx2Y3JRR0RBYndMSjFMcDlMZUwxd08ydkFiUzc2ZUltdlJCaGhX?= =?utf-8?B?TVZLVis1NTV1UklEYXdiUXpMRG5tWmhzbXpKM1J1U0IwTDRWWVpTZ05OZG9x?= =?utf-8?B?bEt6M1RCME1lSTgyYmpHK1NrUTVpZlZYWTh0dGxQZlVtSjRWYkNzM1lrMlo0?= =?utf-8?B?RUc4bUxxMjBxTUNUY3RaZktyRGcwTHhHckdwYkJweFQwbFJyK1lwSVZsL2Uv?= =?utf-8?B?VEoxclg1T0RzODg4a04yeEhJUVNwbTFBb0NMeStGcHV3YktGc3AyQ0xIcDM1?= =?utf-8?B?b0lhYmV4QXpTOHRNSDVKc1NVYThsYUVKVFJmd2xhbU84Wk83OUZmS3hnUzNK?= =?utf-8?B?L2haQkRqTzE0WnBlK29rTWJ4Z1ZDYVhuaDE4ZU5ETGo2V2NtMXBhZ1R3MTlN?= =?utf-8?B?eTJWWk00U0FsTjVVOE1wYk9hbEllMC9Xd2RZVnhWWmpyTWo1UnpGelNYaHZL?= =?utf-8?B?RlRITGdTNDBiODVHaDNZUE1HdXZMVGNHRXltLzg4UzNhQzFJTzlxQ3I0NHY4?= =?utf-8?B?STQxdzRhMGxjRWRrV2FTejJnYWRHdnljaEgvL1BrZXNPektzWnpnRVdlN21C?= =?utf-8?B?VlZlNnRDNHJBLzdYaFhIVHBiNC9RZnlrWE1QMHp4TC9aajdKYUhUeUJabTF3?= =?utf-8?B?OWwxeVVEWkQ1NXpQaUZWajRtSEpOZnNNOTg0bTJBbWhxQklNUnJiU1JFVWpC?= =?utf-8?B?M1NzdUhOdmFGYVJNU2tMSWxOQ1ZVb2lweXUvNkNlNEwwdXJVK1YyOC9kOGdI?= =?utf-8?B?c2sxMkdTc3NTdVZJU0dDQVFKdFFibU1KR0xYZy9PbitZQUVVRnBCMzJLYy8y?= =?utf-8?B?UzFNMS8vdHgxc1IxWVhsM2dCbldDUUh4NWhWekNFNkhPWnNxUlgwYkJuZ0Ni?= =?utf-8?B?aGhWZmlFelB1V0xmOXdIRGFPdlhSclM4dzRQZmFSVGY4dTJadFJSNHB0NWsv?= =?utf-8?Q?EIhNNBmxaXR0dI0Ce18ccF8cnyRECPynVylhXCA?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4688 Original-Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 5f0b09f1-89a3-4190-758f-08d8ee1e0c64 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fz4u/+JLG5G76iVkY3z9Qrkbnu42ilgl0MkXj2iGeS7/SfILU3f8oSpoNEs1+zwTPLNv4VRjK0viUAq7Tfmzgj04QPxau/IcCv1y3dJ1U2XwW7rEFgruD/WZysL6+oq/fqzq+dhlM42WIM2ZJiBprFh8ZJAOwsQdUVWCdd83kN9xwuwxQtdIChNLe2bpOey6kIhRd9Ep7VnFeK4cOyCPQ9Ui+4JrDitlIgkos+t154nTpgTWUT+kGyXShQ/ltVzi2fQipJQp5vJinsOnirAvDNy/23vXpxtk7ZAIZOYhuJ2AH72We1pqdyxOGX78Dm9vxkLJ/9XFbLUynG2CjLxwgvfChFSGG6Cs7zIN2dQn6JT22tpy3j9JfuMvsiC5Ep2gx3UfGmknpei0lp0w6u4nDzfYcEWuAMlZPfOssycluwz92LTS+u6tte2K7cULSFtTsGXw4j1xK45gXc2wo7iMrz0vW3+NsFkV2lxafJYLW3cudGbMBwKIXR4ma/BZRB302JBW76LjlGCZmLlk7Kgfp1BcGUqJZMh57y8YV/4DTY+xvUmD+hb1dSVfTU7e15JiSMUoyz9eAwHoFQwWxTjFtKbY0fc2t7Fe7C/qBOAjtrdKpCShPa/lVPRTZPz00eVIrKHveLqrsY+BDkP0TDw91JpdMenjANn/TzbjQychW3YnnADOpuP+wN2DxM+kKaQJmRuvjl8lncP0O1U5PMihdgHe5n3caJ0vbVi8o9Iy/y8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(136003)(39860400002)(376002)(396003)(46966006)(36840700001)(86362001)(47076005)(36860700001)(83380400001)(107886003)(81166007)(82310400003)(82740400003)(6666004)(478600001)(5660300002)(6862004)(33656002)(356005)(70586007)(70206006)(4326008)(16526019)(6486002)(36756003)(26005)(316002)(54906003)(186003)(7696005)(956004)(44832011)(2616005)(336012)(53546011)(8936002)(2906002)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 17:07:04.6947 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d18b5f3a-696c-4385-a543-08d8ee1e1551 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6194 Hi all, I have an update, changing the lock introduced by the serie from spinlock_t= to raw_spinlock_t, changing the lock/unlock function to use the raw_* vers= ion and keeping the BUG_ON(=E2=80=A6) (now we can because raw_* implementat= ion disable interrupts on preempt_rt) the kernel is booting correctly. So seems that the BUG_ON(=E2=80=A6) is needed and the unmask function shoul= d run with interrupt disabled, anyone knows why this change worked?=20 > On 23 Mar 2021, at 15:39, Luca Fancellu wrote: >=20 > Hi Jason, >=20 > Thanks for your hints, unfortunately seems not an init problem because in= the same init configuration I tried the 5.10.23 (preempt_rt) without the J= uergen patch but with the BUG_ON removed and it boots without problem. So s= eems that applying the serie does something (on a preempt_rt kernel) and we= are trying to figure out what. >=20 >=20 >> On 23 Mar 2021, at 12:36, Jason Andryuk wrote: >>=20 >> On Mon, Mar 22, 2021 at 3:09 PM Luca Fancellu wr= ote: >>>=20 >>> Hi Juergen, >>>=20 >>> Yes you are right it was my mistake, as you said to remove the BUG_ON(= =E2=80=A6) this serie (https://patchwork.kernel.org/project/xen-devel/cover= /20210306161833.4552-1-jgross@suse.com/) is needed, since I=E2=80=99m using= yocto I=E2=80=99m able to build a preempt_rt kernel up to the 5.10.23 and = for this reason I=E2=80=99m applying that serie on top of this version, the= n I=E2=80=99m removing the BUG_ON(=E2=80=A6). >>>=20 >>> A thing that was not expected is that now the Dom0 kernel is stuck on = =E2=80=9CSetting domain 0 name, domid and JSON config=E2=80=A6=E2=80=9D ste= p and the system seems unresponsive. Seems like a deadlock issue but lookin= g into the serie we can=E2=80=99t spot anything and that serie was also tes= ted by others from the community. >>> Do you have any idea on that? >>=20 >> I think this can happen if xenstored isn't running. Client access to >> xenstore blocks until xenstored becomes available. So check your init >> scripts ordering. >>=20 >> Regards, >> Jason >=20 > Cheers, > Luca Cheers, Luca= From xen-devel-bounces@lists.xenproject.org Tue Mar 23 17:16:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 17:16:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100760.192177 (Exim 4.92) (envelope-from ) id 1lOke1-0005m5-H2; Tue, 23 Mar 2021 17:16:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100760.192177; Tue, 23 Mar 2021 17:16:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOke1-0005ly-E3; Tue, 23 Mar 2021 17:16:41 +0000 Received: by outflank-mailman (input) for mailman id 100760; Tue, 23 Mar 2021 17:16:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOkdz-0005lt-IW for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 17:16:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOkdz-00032R-GN for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 17:16:39 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOkdz-0003QM-Ep for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 17:16:39 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOkdw-0002fD-AZ; Tue, 23 Mar 2021 17:16:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=bI4NZf2HAHio7uKY4yrlR7vk5oRj71r1YR8NmdUHHQw=; b=EuASxdNu70SwbUgRsaB0xACwHi 7G63xG0lagjZeNAj2Dv+Y+MTwMWp+i1bOiUkVS80EmLZd2P2+OlnmC45LpIW80g0TxRsB0JtetTCg 8gjNIQtAgy/UZ58K9Yu1OnSeVD9SwZ1T/jHHHgotN68H5yt+NRRGY41LGF+p+MSzu0FA=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24666.8820.146895.73948@mariner.uk.xensource.com> Date: Tue, 23 Mar 2021 17:16:36 +0000 To: Jan Beulich Cc: xen-devel@lists.xenproject.org, community.manager@xenproject.org, Andrew Cooper , committers@xenproject.org, Wei Liu , Juergen Gross , =?iso-8859-1?Q?Fr=E9d=E9ric?= Pierret Subject: Re: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow In-Reply-To: References: <24666.1682.595069.435575@mariner.uk.xensource.com> <0bfab829-3841-b2cd-96f9-874340cf75c2@suse.com> <24666.7414.232768.961456@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow"): > On 23.03.2021 17:53, Ian Jackson wrote: > >> One option of course is, like was just done for 4.13.3, to revert. > >> Iirc Andrew had some thoughts towards making the new piece of code > >> conditional upon the original issue actually hitting. > > > > I would be very happy to consider a revert it someone would give me > > references and explain to me the implications in words of one > > syllable. > > Reference: e1de4c196a2e "x86/timer: Fix boot on Intel systems using > ITSSPRC static PIT clock gating" > > Reverting would unbreak Xen on the Ryzen 1800X system where the > breakage was reported for, and likely a few others. It would at the > same time re-introduce Xen failing to boot on at least some Icelake > (and yet newer) systems. Thanks. That explanation and the reference makes everything clear for me. > >> Another > >> (somewhat similar) option might be to hide the new piece of code > >> behind a default-off command line option. > > > > Likewise. > > Well, not sure what to say here. Introducing a command line option > to allow making Icelake systems boot (by use of the option) while > keeping things working by default on older hardware is about as > simple as an explanation here can get, I guess. Right. The revert seems unattractive. Your suggested command line option sounds like a good workaround to me. Under the circumstances it seems like it should default to the old behaviour, as I think you are suggesting. So I am be inclined to ask if you, Jan, would prepare a patch implementing such an option. Anyone else have any opinions ? Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Tue Mar 23 17:30:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 17:30:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100763.192189 (Exim 4.92) (envelope-from ) id 1lOkrB-0007uW-MI; Tue, 23 Mar 2021 17:30:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100763.192189; Tue, 23 Mar 2021 17:30:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOkrB-0007uP-JK; Tue, 23 Mar 2021 17:30:17 +0000 Received: by outflank-mailman (input) for mailman id 100763; Tue, 23 Mar 2021 17:30:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOkrA-0007uI-86 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 17:30:16 +0000 Received: from mail-qk1-x734.google.com (unknown [2607:f8b0:4864:20::734]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 140da63a-728f-4ea6-bd66-34e4cdb7b609; Tue, 23 Mar 2021 17:30:14 +0000 (UTC) Received: by mail-qk1-x734.google.com with SMTP id y5so13622641qkl.9 for ; Tue, 23 Mar 2021 10:30:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 140da63a-728f-4ea6-bd66-34e4cdb7b609 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zededa.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ziSM+HJ4nYNyql8iGyA9YRXdNLvUCpWt7pacIO7qJes=; b=f1nZiT9HFSAxRv0NszJEPC1y5idwqCD5UT6S4IzlEDBghEMlJw7aaJ0pLU/zvkSglY uR603/WiHDPjUsTKtHzeGR5r4Vog2hWpUVCizH6NXW1+z+u9vVZjc3K4ZR9HF4i6B/J+ tkEAeEYIgtz09rY3TdDdZELXdHTB5w/+KA8ijaqafxPSv10LIYS/h7DSBes7n/X3Y7Vi rCDAiHyRlyCJvVKxNr0cB4CMqspDGzjS7IbuPcmLVjsPOMhGtxtmEdJJLnZlgDN/gvtL pWUlYQzTMjWg+UiBTP1F+t56bTLPmijb8tzFJUqn7Jp8xW15X6MVQitW767fs7BnZGyR CBLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ziSM+HJ4nYNyql8iGyA9YRXdNLvUCpWt7pacIO7qJes=; b=Km9hM6RYdU3a/4zlyaggUmHnGCC28hCiyXBhjje7rSHEnZ8TZX1FsUzkiThqAoMpZL pTaTVXUzmwnTIZq/L8/BbYebIwt2m2cr0fjIVEoni6AfNteL2tL5ycSX67xlu08hfa0U O0/wb/79ylXDsr5otnrG2qEE8hNgK/9zFSPam2cvRm/34cNQFZSvjHucM8JjAmpkEfgR vZLz7Y5UGA3Z2x5bGcYv3q8SzQYLD5a5BPWrRSARMP3AVOk5XN58edxngHb6Z4vjShwD bxfbj0/dCjFC9zqrO2IH2Z26GfTT7eOdztVeNPOwxckPPBMHhBuOAYroa/dmSZQzHLk/ NwlA== X-Gm-Message-State: AOAM532szZi+czp4RkJfIsTcyHimkdGYcKR84kQe32uApOWAgvV1Jceh /rwdrbdP1/dnjGOf4KX3J8vaAfb88kxxrYWme6YdOQ== X-Google-Smtp-Source: ABdhPJyqMyhMSLuPxWTMJl3ke4iT2aWMiQO6tW9FQsFG/0ZO7OYb60K5kxiKYsKPwo/bjp5Udx5iKVef2G3wg0UeaLs= X-Received: by 2002:a05:620a:4e6:: with SMTP id b6mr6516819qkh.157.1616520613587; Tue, 23 Mar 2021 10:30:13 -0700 (PDT) MIME-Version: 1.0 References: <20210322133301.11308-1-jandryuk@gmail.com> <09b5e7ee-b44b-a8ab-f29d-6617b6af93a0@citrix.com> <9b071192-a443-4bdc-8dac-107bbd4a0481@suse.com> <4b0ac6fa-cbe2-5b3c-fa61-52d743e07390@suse.com> In-Reply-To: <4b0ac6fa-cbe2-5b3c-fa61-52d743e07390@suse.com> From: Roman Shaposhnik Date: Tue, 23 Mar 2021 10:30:02 -0700 Message-ID: Subject: Re: [PATCH] xen: Create EFI_VENDOR directory To: Jan Beulich Cc: Jason Andryuk , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel Content-Type: multipart/alternative; boundary="000000000000f201c805be378878" --000000000000f201c805be378878 Content-Type: text/plain; charset="UTF-8" On Tue, Mar 23, 2021 at 6:36 AM Jan Beulich wrote: > On 23.03.2021 13:34, Jason Andryuk wrote: > > On Tue, Mar 23, 2021 at 3:23 AM Jan Beulich wrote: > >> > >> On 22.03.2021 18:08, Andrew Cooper wrote: > >>> On 22/03/2021 15:15, Jan Beulich wrote: > >>>> On 22.03.2021 15:59, Andrew Cooper wrote: > >>>>> On 22/03/2021 14:52, Jan Beulich wrote: > >>>>>> On 22.03.2021 14:33, Jason Andryuk wrote: > >>>>>>> make install-xen fails when EFI_VENDOR is set (=fedora) with: > >>>>>>> install: cannot create regular file > '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No > such file or directory > >>>>>>> > >>>>>>> Create the EFI_VENDOR directory so xen.efi can be installed within. > >>>>>>> > >>>>>>> This removes the need for Fedora and Qubes xen.spec files to > manually > >>>>>>> create the directory in advance. > >>>>>> While I'm not strictly against, I'd like to point out that it was > >>>>>> deliberate to not create this directory here. I also didn't expect > >>>>>> anyone's xen.spec to do so. Instead I'd expect the distro to create > >>>>>> it during OS installation. If this was a bad assumption, I'd prefer > >>>>>> if the commit message here could point out why such an expectation > >>>>>> won't hold in general. > >>>>> This reasoning is broken for anything other `make install DESTDIR=/` > on > >>>>> a live system. > >>>>> > >>>>> It is incompatible with how RPM, deb, etc packages work. > >>>> I'm afraid I don't understand, for both of your statements. If distro > >>>> installation put in place the designated directory, there wouldn't be > >>>> any live system lacking it, and there wouldn't be any concern in the > >>>> packaging of any software. > >>>> > >>>> To take a perhaps too extreme example - packages typically expect e.g. > >>>> /usr to exist as well, don't they? > >>> > >>> No. A buildroot starts out fully empty, by design. > >>> > >>> The packaging environment (usually a chroot) invokes `make install > >>> DESTDIR=/path/to/staging/root` so you don't interfere with any of the > >>> tools inside the environment, and the resulting tar/cpio has the > >>> buildroot stripped out of paths. > >>> > >>> The failure being discussed here is the build within the packaging > >>> environment, not the metadata which forms the final package. > Installing > >>> a deb/rpm/etc will make directories as applicable. > >> > >> Ah, I see. But then this _still_ isn't the right thing to do. In fact, > >> the package build and installation shouldn't put xen.efi in the EFI > >> partition _at all_. The build system doing so is for developers only, > >> so they don't need to invoke boot loader configuration every time they > >> rebuild and re-install. Hence the packaging build shouldn't set > >> EFI_VENDOR in the first place. There it instead should be a subsequent > >> boot loader re-configuration which picks up xen.efi from its install > >> location (under $(EFI_DIR)) and places it on the EFI partition. > > > > On Fedora, RPMs drop EFI binaries directly into /boot/efi/EFI/fedora/. > > grub, shim, fwupdate and xen are all packaged that way. It seems > > reasonable to have those important binaries tracked by the package > > manager. > > > > Does SuSE populate EFI_VENDOR from EFI_DIR when some boot loader > > script is called? > > Yes. And back at the time, when I consulted our EFI person, I was left > with the impression that this is the only reasonable approach. The > primary reason, as said, was that the EFI partition as a whole may get > rebuilt perhaps even from scratch at any point. Hence it's not > reasonable to expect package-managed files to live there. (This is > also expressed by us installing xen.efi into two places, which ought > to be a clear indication by itself that one of them is only to ease > things, not for packaging.) > Big +1 to the above -- in running our own distro we've come to appreciate that very point -- EFI partition is basically a cache and the source of truth is always elsewhere. Thanks, Roman. --000000000000f201c805be378878 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Mar 23, 2021 at 6:36 AM Jan Beuli= ch <jbeulich@suse.com> wrote= :
On 23.03.2021 13:34,= Jason Andryuk wrote:
> On Tue, Mar 23, 2021 at 3:23 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 22.03.2021 18:08, Andrew Cooper wrote:
>>> On 22/03/2021 15:15, Jan Beulich wrote:
>>>> On 22.03.2021 15:59, Andrew Cooper wrote:
>>>>> On 22/03/2021 14:52, Jan Beulich wrote:
>>>>>> On 22.03.2021 14:33, Jason Andryuk wrote:
>>>>>>> make install-xen fails when EFI_VENDOR is set = (=3Dfedora) with:
>>>>>>> install: cannot create regular file '/home= /user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No such = file or directory
>>>>>>>
>>>>>>> Create the EFI_VENDOR directory so xen.efi can= be installed within.
>>>>>>>
>>>>>>> This removes the need for Fedora and Qubes xen= .spec files to manually
>>>>>>> create the directory in advance.
>>>>>> While I'm not strictly against, I'd like t= o point out that it was
>>>>>> deliberate to not create this directory here. I al= so didn't expect
>>>>>> anyone's xen.spec to do so. Instead I'd ex= pect the distro to create
>>>>>> it during OS installation. If this was a bad assum= ption, I'd prefer
>>>>>> if the commit message here could point out why suc= h an expectation
>>>>>> won't hold in general.
>>>>> This reasoning is broken for anything other `make inst= all DESTDIR=3D/` on
>>>>> a live system.
>>>>>
>>>>> It is incompatible with how RPM, deb, etc packages wor= k.
>>>> I'm afraid I don't understand, for both of your st= atements. If distro
>>>> installation put in place the designated directory, there = wouldn't be
>>>> any live system lacking it, and there wouldn't be any = concern in the
>>>> packaging of any software.
>>>>
>>>> To take a perhaps too extreme example - packages typically= expect e.g.
>>>> /usr to exist as well, don't they?
>>>
>>> No.=C2=A0 A buildroot starts out fully empty, by design.
>>>
>>> The packaging environment (usually a chroot) invokes `make ins= tall
>>> DESTDIR=3D/path/to/staging/root` so you don't interfere wi= th any of the
>>> tools inside the environment, and the resulting tar/cpio has t= he
>>> buildroot stripped out of paths.
>>>
>>> The failure being discussed here is the build within the packa= ging
>>> environment, not the metadata which forms the final package.= =C2=A0 Installing
>>> a deb/rpm/etc will make directories as applicable.
>>
>> Ah, I see. But then this _still_ isn't the right thing to do. = In fact,
>> the package build and installation shouldn't put xen.efi in th= e EFI
>> partition _at all_. The build system doing so is for developers on= ly,
>> so they don't need to invoke boot loader configuration every t= ime they
>> rebuild and re-install. Hence the packaging build shouldn't se= t
>> EFI_VENDOR in the first place. There it instead should be a subseq= uent
>> boot loader re-configuration which picks up xen.efi from its insta= ll
>> location (under $(EFI_DIR)) and places it on the EFI partition. >
> On Fedora, RPMs drop EFI binaries directly into /boot/efi/EFI/fedora/.=
> grub, shim, fwupdate and xen are all packaged that way.=C2=A0 It seems=
> reasonable to have those important binaries tracked by the package
> manager.
>
> Does SuSE populate EFI_VENDOR from EFI_DIR when some boot loader
> script is called?

Yes. And back at the time, when I consulted our EFI person, I was left
with the impression that this is the only reasonable approach. The
primary reason, as said, was that the EFI partition as a whole may get
rebuilt perhaps even from scratch at any point. Hence it's not
reasonable to expect package-managed files to live there. (This is
also expressed by us installing xen.efi into two places, which ought
to be a clear indication by itself that one of them is only to ease
things, not for packaging.)

Big=C2=A0+1= to the above -- in running our own distro we've come to appreciate
that very point -- EFI partition is basically a cache and the source= of truth
is always elsewhere.

Thanks,
Roman.
--000000000000f201c805be378878-- From xen-devel-bounces@lists.xenproject.org Tue Mar 23 17:32:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 17:32:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100766.192201 (Exim 4.92) (envelope-from ) id 1lOktK-00082h-3M; Tue, 23 Mar 2021 17:32:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100766.192201; Tue, 23 Mar 2021 17:32:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOktK-00082a-0O; Tue, 23 Mar 2021 17:32:30 +0000 Received: by outflank-mailman (input) for mailman id 100766; Tue, 23 Mar 2021 17:32:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOktI-00082U-Rc for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 17:32:28 +0000 Received: from mail-qt1-x831.google.com (unknown [2607:f8b0:4864:20::831]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fff9517f-a686-4ba0-9e1e-9d2a09028b8a; Tue, 23 Mar 2021 17:32:27 +0000 (UTC) Received: by mail-qt1-x831.google.com with SMTP id x9so15515743qto.8 for ; Tue, 23 Mar 2021 10:32:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fff9517f-a686-4ba0-9e1e-9d2a09028b8a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zededa.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5ibikCj7Cfxaf3tLmSEXncsgA4OJVtmozcYWsgiEAPc=; b=ASkZrGczMiuqhgiQVnCjHlEYUTYYi4t/6al8SjzfupKMlybAM+Tv077euMkJ+ZS/yX uVdM1vrf7BCkbYr/BhBHNs68cb/pWzyPqBzFWs7wfSGvkqP+qqzOZZQP///uX5y8K2TK 9pyRu/N+QTIP+3nYjHD18tbQp5ln5fda+/ZQRYAqTVUNqOpAAgrlIN3bFUvhqpP/+IZ0 he99RjcFEeYQ0LRvtpp1B/tvZADsHDnEh6MbC4PP+L0sWfbhmTm2Zi9c7r6l3z1bLWho IvzFHIbeyMdF5MWmfaI8vZMnJb4pn9KlLX0SWREXYKmpDM6HysOYnTHyXrtuMM3uudjP kEaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5ibikCj7Cfxaf3tLmSEXncsgA4OJVtmozcYWsgiEAPc=; b=b1hh4r+e9jPipz1RukKWIjsRZx7Cg7M2N2y59kbwNTmaItB/8DVCDwWe8or6X+9hwH xY6c18bbwWm3l4tsre2MZpxmsc8Hrk8+Tz0iJw/I4MfwGPFdWF9S8ahfx5+xMISRMftN gQSOyPKZl6S/Eo8AwckJ+BYzRf3Onrp1UIwywi5M7pQu56L7RiGzmbaWvPyWoYci5q/1 A0BRDvtjknnxRciHqJW8OGHdO3//WI/ZyNx2LDhlpeZ//o5ELAr67blnifJQSKzuXQfn /2dUsR3OISH6r1i/8ifRVkYSnI6vwaeT+FdazMMXUxr3Egyk+zV7DPBPlI0wVxeRAUYD N5zg== X-Gm-Message-State: AOAM533ilXnG6/KqE6/dYG4v1DKYlm884Tzyo7lE43e3rxpUwhYKYgxY cH+SHE1dhCHsctx0iZGhddj2mISgA/dY8yO4JLU+GA== X-Google-Smtp-Source: ABdhPJy/Ydqu58YjxW6D/BIP2Anu6BE+kXpG8lK3VaRscazBfGGopfuLR3WeDI9XufokNnGpXKwnJaM/jKCWh+fxOZA= X-Received: by 2002:ac8:1093:: with SMTP id a19mr5383020qtj.365.1616520746903; Tue, 23 Mar 2021 10:32:26 -0700 (PDT) MIME-Version: 1.0 References: <20210322133301.11308-1-jandryuk@gmail.com> <09b5e7ee-b44b-a8ab-f29d-6617b6af93a0@citrix.com> <9b071192-a443-4bdc-8dac-107bbd4a0481@suse.com> <4b0ac6fa-cbe2-5b3c-fa61-52d743e07390@suse.com> <24665.61470.964721.635678@mariner.uk.xensource.com> In-Reply-To: From: Roman Shaposhnik Date: Tue, 23 Mar 2021 10:32:16 -0700 Message-ID: Subject: Re: [PATCH] xen: Create EFI_VENDOR directory To: Michael Young Cc: Ian Jackson , Jan Beulich , Jason Andryuk , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel Content-Type: multipart/alternative; boundary="000000000000e440d605be37907c" --000000000000e440d605be37907c Content-Type: text/plain; charset="UTF-8" On Tue, Mar 23, 2021 at 8:59 AM Michael Young wrote: > > > On Tue, 23 Mar 2021, Ian Jackson wrote: > > > Jan Beulich writes ("Re: [PATCH] xen: Create EFI_VENDOR directory"): > >> On 23.03.2021 13:34, Jason Andryuk wrote: > > ... > >>> On Fedora, RPMs drop EFI binaries directly into /boot/efi/EFI/fedora/. > >>> grub, shim, fwupdate and xen are all packaged that way. It seems > >>> reasonable to have those important binaries tracked by the package > >>> manager. > >>> > >>> Does SuSE populate EFI_VENDOR from EFI_DIR when some boot loader > >>> script is called? > >> > >> Yes. And back at the time, when I consulted our EFI person, I was left > >> with the impression that this is the only reasonable approach. The > >> primary reason, as said, was that the EFI partition as a whole may get > >> rebuilt perhaps even from scratch at any point. Hence it's not > >> reasonable to expect package-managed files to live there. > > > > I agree with this analysis but it is for people like Fedora to decide > > how they want to build their packages. > > > > There is also the case of ad-hoc packages (eg our "make debball") > > which the user might reasonably choose to have dump things in the EFI > > system partition. > > > > Conversely, I see no downside to the mkdir. Jan, is there some actual > > harm in it ? If not, we should be accomodating to people's build and > > packaging strategies even if we don't entirely approve of them. > > There is a request in https://bugzilla.redhat.com/show_bug.cgi?id=1750733 > for xen on Fedora to install the efi file elsewhere and then copy it to > /boot/efi post install. I could change the current Fedora set up for > Fedora 35 (which should have xen-4.15) if there is a good reason to do so. > I am not sure how useful the xen.efi file in /boot/efi is anyway for the > the Fedora set up as it will generally use a xen*.gz file in /boot via > grub. > FWIW: /boot as the source of truth and EFI partition as a cache for that is also what we've settled on in EVE distro. As a somewhat unrelated side-note: on ARM at least, with u-boot playing the role of UEFI more and more -- we can actually pick EFI payloads straight from source of truth and completely by-pass EFI partition altogether (which is fine -- it is, after all, only a cache). Thanks, Roman. --000000000000e440d605be37907c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Mar 23, 2021 at 8:59 AM Michael Y= oung <m.a.young@durham.ac.uk> wrote:


On Tue, 23 Mar 2021, Ian Jackson wrote:

> Jan Beulich writes ("Re: [PATCH] xen: Create EFI_VENDOR directory= "):
>> On 23.03.2021 13:34, Jason Andryuk wrote:
> ...
>>> On Fedora, RPMs drop EFI binaries directly into /boot/efi/EFI/= fedora/.
>>> grub, shim, fwupdate and xen are all packaged that way.=C2=A0 = It seems
>>> reasonable to have those important binaries tracked by the pac= kage
>>> manager.
>>>
>>> Does SuSE populate EFI_VENDOR from EFI_DIR when some boot load= er
>>> script is called?
>>
>> Yes. And back at the time, when I consulted our EFI person, I was = left
>> with the impression that this is the only reasonable approach. The=
>> primary reason, as said, was that the EFI partition as a whole may= get
>> rebuilt perhaps even from scratch at any point. Hence it's not=
>> reasonable to expect package-managed files to live there.
>
> I agree with this analysis but it is for people like Fedora to decide<= br> > how they want to build their packages.
>
> There is also the case of ad-hoc packages (eg our "make debball&q= uot;)
> which the user might reasonably choose to have dump things in the EFI<= br> > system partition.
>
> Conversely, I see no downside to the mkdir.=C2=A0 Jan, is there some a= ctual
> harm in it ?=C2=A0 If not, we should be accomodating to people's b= uild and
> packaging strategies even if we don't entirely approve of them.
There is a request in https://bugzilla.redhat.c= om/show_bug.cgi?id=3D1750733
for xen on Fedora to install the efi file elsewhere and then copy it to /boot/efi post install. I could change the current Fedora set up for
Fedora 35 (which should have xen-4.15) if there is a good reason to do so. =
I am not sure how useful the xen.efi file in /boot/efi is anyway for the the Fedora set up as it will generally use a xen*.gz file in /boot via
grub.

FWIW: /boot as the source of trut= h and EFI partition as a cache for that is also what we've settled on i= n EVE distro.

As a somewhat unrelated side-note: o= n ARM at least, with u-boot playing the role of UEFI more and more -- we ca= n actually pick EFI payloads straight from source of truth and completely b= y-pass EFI partition altogether (which is fine -- it is, after all, only a = cache).

Thanks,
Roman.=C2=A0
=
--000000000000e440d605be37907c-- From xen-devel-bounces@lists.xenproject.org Tue Mar 23 17:40:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 17:40:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100770.192213 (Exim 4.92) (envelope-from ) id 1lOl0i-0000ll-TQ; Tue, 23 Mar 2021 17:40:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100770.192213; Tue, 23 Mar 2021 17:40:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOl0i-0000le-Pd; Tue, 23 Mar 2021 17:40:08 +0000 Received: by outflank-mailman (input) for mailman id 100770; Tue, 23 Mar 2021 17:40:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOl0h-0000lZ-K3 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 17:40:07 +0000 Received: from mail-ot1-x333.google.com (unknown [2607:f8b0:4864:20::333]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ea385f8a-6f9b-4b14-8532-b3d071fac583; Tue, 23 Mar 2021 17:40:06 +0000 (UTC) Received: by mail-ot1-x333.google.com with SMTP id h6-20020a0568300346b02901b71a850ab4so20270126ote.6 for ; Tue, 23 Mar 2021 10:40:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea385f8a-6f9b-4b14-8532-b3d071fac583 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=6/GVoKCpWxnqFm864SDF05q7kHeQOw7BOMEGkyvvqbY=; b=de8nbgoP5df7TO9XQZIC3svnyphH122fIkpvrOWAQQUcE3Z3yKvu33wT2rsZDYj48U CkoMjBFhSbX2UmmUXrRzMWl7JYgV0U6ddLFWArgbzBPLjNJziosJeGCxu3vJrpA4msXt Utem+DDWLgjY2TaQKvzpWZsla0Gp+pEwQF4mVWIffxqpY54pATzsH1y7F/8jFC5tnb2b ObNR/CmO9myy41ZUh343v0+8/lV/Ud+gCqddo8XaHr0u6dSYY85H3WwC5AHitE73zSXa o2AL+u3ewhCrvMFZc8qPlN8d9Mxgq/7EP+tDadSofNR520LFCKxFF9y4NM7BVJBV90up HYuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6/GVoKCpWxnqFm864SDF05q7kHeQOw7BOMEGkyvvqbY=; b=WorPV+o2Cyyt/MqFCHwTt5lrlmlXJ5KKIt6OXWmv+HbuTKRg5YeUzARKK4Fyam1Mhf 7q+Z04UtVZ4b8Yqtjdk42mtIG2MKosrgXSW5++bzJgsZj/tTzZS/1oIxzrZ6fvLOC9qb m7OKf0Amit71o2fsHAyvxqXyL5uExnW/3TSPR/AyGF/V7VdT05MIwc5mAsjVaQVMMavb 31oIVyUMPfvPpAEPkWCcu15xnzBrN9bTTApD7GSXMBh3Cwq/7nCG7DBmLS5+OU620WXh 5j6JBEmf7rx6Lz+dUjrnzexwR/Y5fdBhUo4pMewif1M6/+K9bdl01rD5zaF6YI3dxDiM EYow== X-Gm-Message-State: AOAM53390Z3wQ65H/4/ZYUdkucOq0VOLPac/VIxP+SWQcqEVmowvlU45 BpZUqLa4R28q0HqKqN6SalvC0e8SgjdcJ2rPxfQ= X-Google-Smtp-Source: ABdhPJw0/XMEJ8uDz5h5tRTD95XGq8/VfUYIVmgdxxKapSWYyh4cvq55OhkJY5pjIiSNI0UJ088BUhQPu6e25SZP2EI= X-Received: by 2002:a9d:70ce:: with SMTP id w14mr5255632otj.183.1616521206117; Tue, 23 Mar 2021 10:40:06 -0700 (PDT) MIME-Version: 1.0 References: <20210316031814.10311-1-dpsmith@apertussolutions.com> <20210316031814.10311-2-dpsmith@apertussolutions.com> In-Reply-To: From: Christopher Clark Date: Tue, 23 Mar 2021 10:39:53 -0700 Message-ID: Subject: Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: "Daniel P. Smith" , xen-devel , Andrew Cooper , Stefano Stabellini , Julien Grall , Julien Grall , iwj@xenproject.org, Wei Liu , George Dunlap , Jan Beulich , Rich Persaud , Bertrand Marquis , luca.fancellu@arm.com, paul@xen.org, Adam Schwalm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 18, 2021 at 9:43 AM Roger Pau Monn=C3=A9 = wrote: > > Just took a quick look at it. > > On Mon, Mar 15, 2021 at 11:18:13PM -0400, Daniel P. Smith wrote: > > + +---------------+-----------+------------+-----------+-------------+-= --------------------+ > > + | **Xen Dom0** | **Linux** | **Late** | **Jail** | **Xen** | = **Xen Hyperlaunch** | > > + | **(Classic)** | **KVM** | **HW Dom** | **house** | **dom0less**+-= --------+-----------+ > > + | | | | | | = Static | Dynamic | > > + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D= =3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+ > > + | Hypervisor able to launch multiple VMs during host boot = | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | | | | Y | Y | = Y | Y | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | Hypervisor supports Static Partitioning = | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | | | | Y | Y | = Y | | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | Able to launch VMs dynamically after host boot = | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | Y | Y | Y* | Y | Y* | = | Y | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | Supports strong isolation between all VMs started at host boot = | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | | | | Y | Y | = Y | Y | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | Enables flexible sequencing of VM start during host boot = | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | | | | | | = Y | Y | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | Prevent all-powerful static root domain being launched at boot = | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | | | | | Y* | = Y | Y | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | Operates without a Highly-privileged management VM (eg. Dom0) = | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | | | Y* | | Y* | = Y | Y | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | Operates without a privileged toolstack VM (Control Domain) = | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | | | | | Y* | = Y | | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | Extensible VM configuration applied before launch of VMs at host bo= ot | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | | | | | | = Y | Y | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | Flexible granular assignment of permissions and functions to VMs = | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | | | | | | = Y | Y | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | Supports extensible VM measurement architecture for DRTM and attest= ation | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | | | | | | = Y | Y | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | PCI passthrough configured at host boot = | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > + | | | | | | = Y | Y | > > + +---------------+-----------+------------+-----------+-------------+-= --------+-----------+ > > I'm curious about this, I assume this is done using vPCI so that > there's no hardware domain (and user-space device model) involved for > PCI passthrough? That would be an incorrect assumption. See below for why. > I'm also not sure how you are going to handle things like SR-IOV > devices. Right now SR-IOV capability is setup and initialized by the > hardware domain, and the new virtual devices are notified to Xen once > setup is done. Do you plan to move those bits into Xen, so that it can > setup and initialize the SR-IOV capability? While you could do it with the vPCI, as you point out this will not work for SR-IOV. With hyperlaunch, these cases will require the use of a boot domain, which is for all intents and purposes, a lightweight/restricted toolstack domain. The boot domain will have to do the necessary operations to ensure that when startup is finished, PCI passthrough will be successfully setup. Note, this may have to include the boot domain unpausing the hardware domain to help complete the setup before the boot domain can exit and allow the remaining domains to come online. Both of these cases are in scope for our customer funding the work, so we will be giving these use cases extra scrutiny, though it is not like we intend to leave anything that works today unusable. thanks Christopher > > Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 23 19:09:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 19:09:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100785.192231 (Exim 4.92) (envelope-from ) id 1lOmOY-0000s7-Nk; Tue, 23 Mar 2021 19:08:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100785.192231; Tue, 23 Mar 2021 19:08:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOmOY-0000s0-KT; Tue, 23 Mar 2021 19:08:50 +0000 Received: by outflank-mailman (input) for mailman id 100785; Tue, 23 Mar 2021 19:08:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOmOX-0000rs-Br; Tue, 23 Mar 2021 19:08:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOmOX-0004z2-5R; Tue, 23 Mar 2021 19:08:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOmOW-0004As-Qc; Tue, 23 Mar 2021 19:08:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOmOW-00084Z-Q5; Tue, 23 Mar 2021 19:08:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=A7ClMuT6Neyd+xLXfW6BoWmK9wv54c6pbmhm9X+LSG8=; b=OixojxwTqvm7Dw44FqzmliyrJ8 cihrADO88vKBe72XYLG0vHrrTOVn+0A90XEsDRL+XNyvTUlHNgDa3gdiy1xBARbUIeknAz5Go8pWa pBgiTXj9rEipUpZApZH+XqvY8TAYzPk2upNUF9lHiAGqID0otnR5bB+ZR2oo0Yu3RffY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160350: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=9eb7e9e817656983ab3f8801ef3cd9ba5ab5ee1c X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 23 Mar 2021 19:08:48 +0000 flight 160350 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160350/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 9eb7e9e817656983ab3f8801ef3cd9ba5ab5ee1c baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 256 days Failing since 151818 2020-07-11 04:18:52 Z 255 days 248 attempts Testing same since 160350 2021-03-23 04:18:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 48452 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 23 19:26:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 19:26:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100791.192245 (Exim 4.92) (envelope-from ) id 1lOmfc-0002l1-8k; Tue, 23 Mar 2021 19:26:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100791.192245; Tue, 23 Mar 2021 19:26:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOmfc-0002ku-5b; Tue, 23 Mar 2021 19:26:28 +0000 Received: by outflank-mailman (input) for mailman id 100791; Tue, 23 Mar 2021 19:26:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOmfa-0002kp-3F for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 19:26:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOmfZ-0005GF-UY; Tue, 23 Mar 2021 19:26:25 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lOmfZ-0002YM-MI; Tue, 23 Mar 2021 19:26:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=YQaMh62nSe7DvVoi+4Bau/eO1tss8Tm22vjQaGMyU1E=; b=16Ok74XA9VMF3tuCW//har6l2P 8cof9opVZuhpIEIRdLjn2C4ZLQbmuiHMlL98A4y3P18ulwcEFvwpPN1cQVbEn6vli/TwmkYtPz3a9 PKmV1OTuT65kfRK59FZVMqPCgvgj2I1zllD6r6c2UdvSR5mvOtB6NzXFSQh7GcPFrutQ=; Subject: Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 To: Luca Fancellu , Jason Andryuk Cc: "xen-devel@lists.xenproject.org" , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= References: <1FAD6C91-2B3A-48F0-88D7-CFCFC8B53BA9@arm.com> <2BC82A95-DFB9-4F90-8CC6-AE39405157ED@arm.com> <565C6475-4693-4A7C-8316-9613146300C2@arm.com> <2A09774F-ADDF-41B0-8E72-DC0FA0A6B1F3@arm.com> From: Julien Grall Message-ID: Date: Tue, 23 Mar 2021 19:26:23 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <2A09774F-ADDF-41B0-8E72-DC0FA0A6B1F3@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 23/03/2021 17:06, Luca Fancellu wrote: > Hi all, Hi, Please avoid top posting when answering to a comment. This makes more difficult to follow. > I have an update, changing the lock introduced by the serie from spinlock_t to raw_spinlock_t, changing the lock/unlock function to use the raw_* version and keeping the BUG_ON(…) (now we can because raw_* implementation disable interrupts on preempt_rt) the kernel is booting correctly. > So seems that the BUG_ON(…) is needed and the unmask function should run with interrupt disabled, anyone knows why this change worked? Do you mean why no-one spotted the issue before? If so, AFAIK, on vanilla Linux, spin_lock is still just a wrapper to raw_spinlock. IOW there is no option to replace it with a RT spinlock. So if you don't apply the RT patches, you would not be able to trigger the issue. As to the fix itself, I think using raw_spinlock_t is the correct thing to do because the lock is also used in interrupt context (even with RT enabled). Would you be able to send a patch? > >> On 23 Mar 2021, at 15:39, Luca Fancellu wrote: >> >> Hi Jason, >> >> Thanks for your hints, unfortunately seems not an init problem because in the same init configuration I tried the 5.10.23 (preempt_rt) without the Juergen patch but with the BUG_ON removed and it boots without problem. So seems that applying the serie does something (on a preempt_rt kernel) and we are trying to figure out what. >> >> >>> On 23 Mar 2021, at 12:36, Jason Andryuk wrote: >>> >>> On Mon, Mar 22, 2021 at 3:09 PM Luca Fancellu wrote: >>>> >>>> Hi Juergen, >>>> >>>> Yes you are right it was my mistake, as you said to remove the BUG_ON(…) this serie (https://patchwork.kernel.org/project/xen-devel/cover/20210306161833.4552-1-jgross@suse.com/) is needed, since I’m using yocto I’m able to build a preempt_rt kernel up to the 5.10.23 and for this reason I’m applying that serie on top of this version, then I’m removing the BUG_ON(…). >>>> >>>> A thing that was not expected is that now the Dom0 kernel is stuck on “Setting domain 0 name, domid and JSON config…” step and the system seems unresponsive. Seems like a deadlock issue but looking into the serie we can’t spot anything and that serie was also tested by others from the community. The deadlock is expected. When you enable RT spinlock, the interrupts will not disabled even when you call spin_lock_irqsave(). As the lock is also used in interrupt context (e.g. with interrupt masked), this will lead to a deadlock because the lock can be held with interrupt unmasked. This is quite a common error as developpers are not yet used to test RT. I remember finding a few other instances like that when I worked on RT a couple of years ago. For future reference, I think CONFIG_PROVE_LOCKING=y could help you to detect (potential) deadlock. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 23 19:49:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 19:49:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100797.192258 (Exim 4.92) (envelope-from ) id 1lOn1X-00055c-6o; Tue, 23 Mar 2021 19:49:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100797.192258; Tue, 23 Mar 2021 19:49:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOn1X-00055V-2C; Tue, 23 Mar 2021 19:49:07 +0000 Received: by outflank-mailman (input) for mailman id 100797; Tue, 23 Mar 2021 19:49:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOn1W-00055L-7h; Tue, 23 Mar 2021 19:49:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOn1V-0005e1-VX; Tue, 23 Mar 2021 19:49:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOn1V-0005UQ-O6; Tue, 23 Mar 2021 19:49:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOn1V-0007Po-Nf; Tue, 23 Mar 2021 19:49:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=t87b+JsAbov1EX8lnvnW/MzIKOBaFzMFmNC5TTuSW8U=; b=z/AtKS8/H/nJFleX7zVgpqmI2y ach2A4WeP8UHmFIZQDUHnAX0iQ48xtPJ7quvL2FD2yEpIAtqdbhnMpR+HtXVsu3t36f/IA0IIi0dy 9DG8YNLJcTQIYLA/YMFDS28XUiDQZwnj6muuplaqKROHpKgJXa9a3ze7CBsGCG5GuJjE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160366: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b9b3082002cac68726fb303e0abd2ff0113d4657 X-Osstest-Versions-That: xen=ecdff2f5a03210119b71806c3f5571d6906dd85e From: osstest service owner Date: Tue, 23 Mar 2021 19:49:05 +0000 flight 160366 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160366/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen b9b3082002cac68726fb303e0abd2ff0113d4657 baseline version: xen ecdff2f5a03210119b71806c3f5571d6906dd85e Last test of basis 160297 2021-03-22 11:00:26 Z 1 days Testing same since 160366 2021-03-23 17:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ecdff2f5a0..b9b3082002 b9b3082002cac68726fb303e0abd2ff0113d4657 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Mar 23 20:38:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 20:38:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100805.192279 (Exim 4.92) (envelope-from ) id 1lOnmi-0001gl-2k; Tue, 23 Mar 2021 20:37:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100805.192279; Tue, 23 Mar 2021 20:37:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOnmh-0001ge-UN; Tue, 23 Mar 2021 20:37:51 +0000 Received: by outflank-mailman (input) for mailman id 100805; Tue, 23 Mar 2021 20:37:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOnmg-0001gR-U8; Tue, 23 Mar 2021 20:37:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOnmg-0006WY-HJ; Tue, 23 Mar 2021 20:37:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOnmg-00071k-4L; Tue, 23 Mar 2021 20:37:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOnmg-0003Wh-3n; Tue, 23 Mar 2021 20:37:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YSawZWiSL9qHWHtiVNvLvs8WkwfjpKdsjR+aiKx499Q=; b=bkk+EpkDGnZ5EOFbLrtR7SuWtz RcK0OcsgKAYfmXqMQlNykoSW/7qQB9U9fFDRA0oTziHwR4l/TSHV+a14/DRAOuxymMNnoQFnEso/K yfJP+lZ7/pjie3KOKvyfGGvbDS0I1WDNrVnsULTyOWlBVzFFFavuLs0thxmPWVIphS4o=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160344: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-4.12-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Tue, 23 Mar 2021 20:37:50 +0000 flight 160344 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160344/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail REGR. vs. 159418 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160170 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 35 days Failing since 160128 2021-03-18 14:36:18 Z 5 days 5 attempts Testing same since 160150 2021-03-20 04:11:48 Z 3 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 23 22:59:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 22:59:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100819.192306 (Exim 4.92) (envelope-from ) id 1lOpzN-0006x2-CH; Tue, 23 Mar 2021 22:59:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100819.192306; Tue, 23 Mar 2021 22:59:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOpzN-0006wv-9A; Tue, 23 Mar 2021 22:59:05 +0000 Received: by outflank-mailman (input) for mailman id 100819; Tue, 23 Mar 2021 22:59:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOpzM-0006wq-3y for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 22:59:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOpzL-0000Re-Qc; Tue, 23 Mar 2021 22:59:03 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lOpzL-00071P-FW; Tue, 23 Mar 2021 22:59:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:References:Cc:To:From:Subject; bh=qAPA2uDorCOhySKwhXsz4x9l7n7eyOgSsluk/bi7Zp0=; b=nkodAGU3ox4I71FKXXT5LADD9D c2ucq6S9Bo42ObzLBCWVwcGurvXGxq9Z+/41+07QNkbviiWqeq4WK1F9BmXoaF7/lDEvFdVOTLWhQ vKfoRg1JFwKRYOBx762GAk5EAGpBaNJdVl85mBy8qYQujIkEs2CkkLyGwvDYsuy/wmk0=; Subject: Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 From: Julien Grall To: Luca Fancellu , Jason Andryuk Cc: "xen-devel@lists.xenproject.org" , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= References: <1FAD6C91-2B3A-48F0-88D7-CFCFC8B53BA9@arm.com> <2BC82A95-DFB9-4F90-8CC6-AE39405157ED@arm.com> <565C6475-4693-4A7C-8316-9613146300C2@arm.com> <2A09774F-ADDF-41B0-8E72-DC0FA0A6B1F3@arm.com> Message-ID: <508ec534-418d-4f82-6f53-e99e4b8dabaa@xen.org> Date: Tue, 23 Mar 2021 22:59:01 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 23/03/2021 19:26, Julien Grall wrote: > > > On 23/03/2021 17:06, Luca Fancellu wrote: >> Hi all, > > Hi, > > Please avoid top posting when answering to a comment. This makes more > difficult to follow. > >> I have an update, changing the lock introduced by the serie from >> spinlock_t to raw_spinlock_t, changing the lock/unlock function to use >> the raw_* version and keeping the BUG_ON(…) (now we can because raw_* >> implementation disable interrupts on preempt_rt) the kernel is booting >> correctly. >> So seems that the BUG_ON(…) is needed and the unmask function should >> run with interrupt disabled, anyone knows why this change worked? > > Do you mean why no-one spotted the issue before? If so, AFAIK, on > vanilla Linux, spin_lock is still just a wrapper to raw_spinlock. IOW > there is no option to replace it with a RT spinlock. > > So if you don't apply the RT patches, you would not be able to trigger > the issue. > > As to the fix itself, I think using raw_spinlock_t is the correct thing > to do because the lock is also used in interrupt context (even with RT > enabled). > > Would you be able to send a patch? > >> >>> On 23 Mar 2021, at 15:39, Luca Fancellu wrote: >>> >>> Hi Jason, >>> >>> Thanks for your hints, unfortunately seems not an init problem >>> because in the same init configuration I tried the 5.10.23 >>> (preempt_rt) without the Juergen patch but with the BUG_ON removed >>> and it boots without problem. So seems that applying the serie does >>> something (on a preempt_rt kernel) and we are trying to figure out what. >>> >>> >>>> On 23 Mar 2021, at 12:36, Jason Andryuk wrote: >>>> >>>> On Mon, Mar 22, 2021 at 3:09 PM Luca Fancellu >>>> wrote: >>>>> >>>>> Hi Juergen, >>>>> >>>>> Yes you are right it was my mistake, as you said to remove the >>>>> BUG_ON(…) this serie >>>>> (https://patchwork.kernel.org/project/xen-devel/cover/20210306161833.4552-1-jgross@suse.com/) >>>>> is needed, since I’m using yocto I’m able to build a preempt_rt >>>>> kernel up to the 5.10.23 and for this reason I’m applying that >>>>> serie on top of this version, then I’m removing the BUG_ON(…). >>>>> >>>>> A thing that was not expected is that now the Dom0 kernel is stuck >>>>> on “Setting domain 0 name, domid and JSON config…” step and the >>>>> system seems unresponsive. Seems like a deadlock issue but looking >>>>> into the serie we can’t spot anything and that serie was also >>>>> tested by others from the community. > > The deadlock is expected. When you enable RT spinlock, the interrupts > will not disabled even when you call spin_lock_irqsave(). > > As the lock is also used in interrupt context (e.g. with interrupt > masked), this will lead to a deadlock because the lock can be held with > interrupt unmasked. > > This is quite a common error as developpers are not yet used to test RT. > I remember finding a few other instances like that when I worked on RT a > couple of years ago. > > For future reference, I think CONFIG_PROVE_LOCKING=y could help you to > detect (potential) deadlock. Actually, Linux has a config that detect misuse of spinlock. If I enable CONFIG_PROVE_RAW_LOCK_NESTING, I will get the following: [ 1.286028] ============================= [ 1.286781] [ BUG: Invalid wait context ] [ 1.287539] 5.12.0-rc4+ #222 Not tainted [ 1.288277] ----------------------------- [ 1.289033] swapper/0/0 is trying to lock: [ 1.289799] ffff8881001b8358 (&info->lock){....}-{3:3}, at: do_unmask+0x1c/0x50 [ 1.291132] other info that might help us debug this: [ 1.292066] context-{5:5} [ 1.292594] 2 locks held by swapper/0/0: [ 1.293339] #0: ffff8881001bfae8 (&desc->request_mutex){+.+.}-{4:4}, at: __setup_irq+0xb9/0x8c0 [ 1.294909] #1: ffff8881001bf930 (&irq_desc_lock_class){....}-{2:2}, at: __setup_irq+0xea/0x8c0 [ 1.296478] stack backtrace: [ 1.297062] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.12.0-rc4+ #222 [ 1.298304] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 [ 1.300326] Call Trace: [ 1.300837] dump_stack+0x7f/0xa1 [ 1.301514] __lock_acquire+0x86e/0x1e20 [ 1.302281] ? add_lock_to_list.constprop.58+0xac/0x1d0 [ 1.303270] lock_acquire+0x26d/0x400 [ 1.303987] ? do_unmask+0x1c/0x50 [ 1.304670] _raw_spin_lock_irqsave+0x48/0x60 [ 1.305525] ? do_unmask+0x1c/0x50 [ 1.306208] do_unmask+0x1c/0x50 [ 1.306863] unmask_irq.part.41+0x25/0x40 [ 1.307655] __irq_startup+0x68/0x70 [ 1.308361] irq_startup+0x59/0xf0 [ 1.309046] __setup_irq+0x7ea/0x8c0 [ 1.309750] request_threaded_irq+0xfb/0x160 [ 1.310581] ? xen_timerop_shutdown+0x10/0x10 [ 1.311434] bind_virq_to_irqhandler+0x47/0x80 [ 1.312293] xen_setup_timer+0x7f/0x190 [ 1.313045] xen_time_init+0x1bf/0x214 [ 1.313780] x86_late_time_init+0x17/0x30 [ 1.314553] start_kernel+0x851/0x90a [ 1.315276] ? default_get_nmi_reason+0x10/0x10 [ 1.316149] xen_start_kernel+0x575/0x57f [ 1.316932] startup_xen+0x3e/0x3e This is on an x86 (either PV or HVM). Interestingly on Arm, I get a different one: [ 0.112598] ============================= [ 0.112745] [ BUG: Invalid wait context ] [ 0.112953] 5.12.0-rc4+ #98 Not tainted [ 0.113156] ----------------------------- [ 0.113301] swapper/0/1 is trying to lock: [ 0.113461] ffffa10084d2f788 (evtchn_rwlock){....}-{3:3}, at: __xen_evtchn_do_upcall+0x64/0xf0 [ 0.114041] other info that might help us debug this: [ 0.114229] context-{2:2} [ 0.114351] 2 locks held by swapper/0/1: [ 0.114608] #0: ffffa10084ab1e78 (cpu_hotplug_lock){.+.+}-{0:0}, at: xen_guest_init+0x33c/0x380 [ 0.115076] #1: ffffa10084ab1c70 (cpuhp_state_mutex){+.+.}-{4:4}, at: __cpuhp_setup_state_cpuslocked+0x64/0x308 [ 0.115530] stack backtrace: [ 0.115880] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.12.0-rc4+ #98 [ 0.116371] Call trace: [ 0.116488] dump_backtrace+0x0/0x1e0 [ 0.116650] show_stack+0x2c/0x48 [ 0.116791] dump_stack+0xf0/0x138 [ 0.116933] __lock_acquire+0x5ac/0x1a38 [ 0.117085] lock_acquire+0x3cc/0x4e0 [ 0.117225] _raw_read_lock+0x80/0x188 [ 0.117370] __xen_evtchn_do_upcall+0x64/0xf0 [ 0.117536] xen_hvm_evtchn_do_upcall+0x14/0x20 [ 0.117706] xen_arm_callback+0x14/0x20 [ 0.117855] handle_percpu_devid_irq+0xc8/0x428 [ 0.118027] generic_handle_irq+0x3c/0x58 [ 0.118174] __handle_domain_irq+0x68/0xc0 [ 0.118323] gic_handle_irq+0x64/0x160 [ 0.118463] el1_irq+0xb0/0x140 [ 0.118593] _raw_spin_unlock_irqrestore+0x6c/0xe8 [ 0.118769] __irq_put_desc_unlock+0x30/0x60 [ 0.118935] enable_percpu_irq+0x94/0xf0 [ 0.119079] xen_starting_cpu+0x70/0x1b8 [ 0.119228] cpuhp_invoke_callback+0xfc/0xf20 [ 0.119395] cpuhp_issue_call+0x220/0x250 [ 0.119542] __cpuhp_setup_state_cpuslocked+0x150/0x308 [ 0.119725] __cpuhp_setup_state+0x138/0x3b0 [ 0.119891] xen_guest_init+0x33c/0x380 [ 0.120033] do_one_initcall+0x90/0x470 [ 0.120176] kernel_init_freeable+0x250/0x440 [ 0.120345] kernel_init+0x1c/0x138 [ 0.120480] ret_from_fork+0x10/0x18 I am not sure why I don't get a splat for info->lock on Arm. Anyway, I am quite confused at the second splat. It seems to suggest it would not be valid to call read_lock() while a cpu_hotplug_lock() is held. Does it ring any bell? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 23 23:45:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 23 Mar 2021 23:45:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100825.192321 (Exim 4.92) (envelope-from ) id 1lOqi7-00039z-Vj; Tue, 23 Mar 2021 23:45:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100825.192321; Tue, 23 Mar 2021 23:45:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOqi7-00039s-Sh; Tue, 23 Mar 2021 23:45:19 +0000 Received: by outflank-mailman (input) for mailman id 100825; Tue, 23 Mar 2021 23:45:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOqi7-00039n-9a for xen-devel@lists.xen.org; Tue, 23 Mar 2021 23:45:19 +0000 Received: from mail-ot1-x32c.google.com (unknown [2607:f8b0:4864:20::32c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4cdcb398-8f79-41cf-a852-0603059a46dd; Tue, 23 Mar 2021 23:45:18 +0000 (UTC) Received: by mail-ot1-x32c.google.com with SMTP id v24-20020a9d69d80000b02901b9aec33371so21280797oto.2 for ; Tue, 23 Mar 2021 16:45:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4cdcb398-8f79-41cf-a852-0603059a46dd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=30XQNYb2T9mP3JRg6lsKoXYDzFycp16JlM5yfypF0B8=; b=gY/WciJerlVATJVt9+xYAEBSdyz8/iWoO+dSYlPl1eSW9Lt6LHoI5lX+lem4iwFQG7 RvIk7ZGZHS1WoYjy8Hym4E9LdlrFGBaTqbm74dEAtkeK8TlJhEBPgzrdowvMkIXziict qi+q2/ZuNHeZHBlLW2OIYMhw2KuvXjpD2jaklEUACPsLnHrxVwwNmCVha3bhMNnsF6DM JCNyxmvZFm3mmXMqZq5LyN+5iVYNwer7RxwyBiCZFMQVx1c4hJYwlAqYKNEyeflm0zRi qMq+XpZm1s687TKmTIDiJ81PrExlZGyoG1fBq8IwDhqHOQWAJ+Zx+NtX5xs+u/Y3b9DH tCTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=30XQNYb2T9mP3JRg6lsKoXYDzFycp16JlM5yfypF0B8=; b=cPHqc17fDo9I+RyT1zMsp15y7zXsEzymi8JZvFzDKMIw46T5UteDiLLji1JcHf96QU Rpf5vCSaRn1q9mMIpkEyItijUpQIkhuzx/zkgOCo5uDQmxxYB4Xws+WY6fsvVofaUZ7N kxwyxlLgncd1iPh8raPv85YAz+vS2OuwxIUYGM2KkU09qsmxZvlTZJg5gJS3oK8ZIQQl NVI5u/DjJd4Bvy5/GCAjqJLFdJVQhuz0+m0hcIKe7Ii+39xhTM1fPRZdwtu6oq1MCCBK 5eubWnJKlLoCRXHby/dsK5+kGgTOCdaWXBc5SlyMh3DxXr6IceU9TvyYCADvg7IBW8DD s+CQ== X-Gm-Message-State: AOAM533MVewztXoaI7/3TwAOwLjTg6IG2wf5uyChqiVXI3KmwD6ZmVvP qRoGppZ7u93VkWxpeg0FE/tJquVBrymrzLpyT2c= X-Google-Smtp-Source: ABdhPJxU0pQLYI+mJL9FcgyAObkDwyEWPoRt+1tIi3/QEYjne938wfp8j9wBjZX98hJz0bOXb2D4AV3XyCjyQ6xNxtI= X-Received: by 2002:a9d:70ce:: with SMTP id w14mr665276otj.183.1616543117417; Tue, 23 Mar 2021 16:45:17 -0700 (PDT) MIME-Version: 1.0 References: <2e7213c1-e01c-9d9d-3ac1-3086eb6889e5@apertussolutions.com> In-Reply-To: From: Christopher Clark Date: Tue, 23 Mar 2021 16:45:06 -0700 Message-ID: Subject: Re: Working Group Meeting for hyperlaunch To: "Daniel P. Smith" , Xen-devel Cc: Stefano Stabellini , Julien Grall , iwj@xenproject.org, Wei Liu , George Dunlap , Jan Beulich , Rich Persaud , Bertrand Marquis , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , luca.fancellu@arm.com, Adam Schwalm , Andrew Cooper , paul@xen.org Content-Type: text/plain; charset="UTF-8" On Thu, Mar 18, 2021 at 8:33 AM Daniel P. Smith wrote: > > On 3/16/21 12:09 AM, Daniel P. Smith wrote: > > All, > > > > We have posted[1][2] the design documents for hyperlaunch and would > > invite attendance at a working group call to discuss two agenda items. > > The first item is a review of the documents and the second is a > > discussion about bringing production-ready revisions of our previous > > prototype in as patches to provide a near-term implementation of the > > design. If possible please join us this Thursday 3/18 at > > 1700CET/1600GMT/1200EDT/0900PDT. Below are the call details. > > > > [1] > > https://lists.xenproject.org/archives/html/xen-devel/2021-03/msg00939.html > > [2] > > https://lists.xenproject.org/archives/html/xen-devel/2021-03/pdfCV4LaWCrTN.pdf > > Agenda link, > https://cryptpad.fr/pad/#/2/pad/edit/+MJgJ0EkalH81-YVOlsp1bEo/ ## Minutes from the Hyperlaunch Working Group meeting, 18th March * Posted design docs: 1) main doc: has the high level design 2) device tree doc: has implementation details for launch - new version of docs much better, in-line with vision for Xen design docs - Xen tree has example of another good recent design doc - Stefano: have minor feedback on some details eg. node names Evaluating fit with work on System Device Tree; is very aligned. * Naming: "Hyperlaunch" and the related terms "Hyperlaunch Static" and "Hyperlaunch Dynamic" - No objections; proceeding with these names for now - OK to retire term 'dom0less' in favour of 'Hyperlaunch Static' since Hyperlaunch Static will do everything that dom0less does, plus more - an Appendix in the posted main design document has reasoning, rationale behind the proposed naming * Towards merging: - Andy: Xen currently in release freeze, so wait for opening for 4.16, and then follow up * Crash domain: When is it started? What defines a crash? Aim: Xen does its best to handle misconfig / faults to get system up to a usable console Andy: two separate crash cases: 1: hypervisor crash: - current Xen can reserve memory on boot, load a crash kernel, jump into it on a crash: mount root disk, dump logs, reboot - is kexec case, and also the safety case for error in the hypervisor 2: crash of a domain that Xen is starting: - can use normal Xen functionality to recover - structure in doc supports DRTM measurement of crash handling logic Stefano: there is some similar need or equivalent in Safety systems Bertrand: doc should describe what a crash is, what the functionality can do * ACTION: update doc to describe proposed crash response functionality * Terminology: 'recovery' or 'rescue' terms preferred: - First: better as "crash environment" (not "crash domain") - Second: "recovery domain"" Bertrand: safety case: reboot to most recent known working config - on server, reboot to interactive is ok - make sure domain has sufficient capacity to do both * ACTION: add definitions and descriptions to the design doc - work out where the safety use case fits - multiple domains can have control domain permission * Recommendations on approach for development - 40-odd patch series in prototype: too big for one series (!) - will work on changes to both x86 and Arm code together Stefano: sending multiple smaller series is OK: make each testable * How much common vs. arch-specific? Andy: aim for common: logic in-line with RISC-V and PowerPC ports - eg. LCM handling in common; and may require some arch-specific Christopher: prototype used PV for Hardware Domain, following code for current most-common dom0; any guidance on PV vs PVH, experience with PVH dom0? Roger: PVH dom0 used on FreeBSD; is in GitLab CI and osstest. PVH use for domU is more common. Andy: Hardware Domain and Control Domain need clearer definitions * ACTION: add definitions and descriptions for Hardware, Control, domain to the design doc Roger: - feedback on PCI points: have posted to the list * Beyond posted docs: Andy: Bareflank-style setup is relevant: can ensure Hyperlaunch work aligns and keep use case in mind eg. case where hypervisor doesn't have scheduler, offloads power mgmt Rich: seek design input for Hyperlaunch Eric: invite to next call? * ACTION: invite Bareflank developers to next call, supply pointer to Hyperlaunch design docs * Public development: Rich: ok for in-development Hyperlaunch code to be public on github? Christopher + Daniel: most likely yes; can check with project sponsor -- Christopher From xen-devel-bounces@lists.xenproject.org Wed Mar 24 00:37:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 00:37:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100831.192339 (Exim 4.92) (envelope-from ) id 1lOrVt-000080-VT; Wed, 24 Mar 2021 00:36:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100831.192339; Wed, 24 Mar 2021 00:36:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOrVt-00007t-SM; Wed, 24 Mar 2021 00:36:45 +0000 Received: by outflank-mailman (input) for mailman id 100831; Wed, 24 Mar 2021 00:36:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOrVr-00007l-Th; Wed, 24 Mar 2021 00:36:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOrVr-0002bW-Mg; Wed, 24 Mar 2021 00:36:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOrVr-0002u4-Fk; Wed, 24 Mar 2021 00:36:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOrVr-0005Du-FB; Wed, 24 Mar 2021 00:36:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=i7GGIuFxYUUNUq+dleF/y6vxIkY/UFGQCu1zgXaz2Fo=; b=bWXEGAggYH7F815uo6zXWlPs5y 3J3pNc8mjvl/rfWE9WJnEJ/lB41fBbXFEc/UGIpuPCQ65NZrnUDz3FDPQGCYXp0/Ui9y2Jfp2aDpa IkAgwAWk7SEHPcF84PkcIoYr/cdK51MiGB/niJpxcN0Qjhm/29RMcWX+UJ96OtjDAysk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160352: all pass - PUSHED X-Osstest-Versions-This: ovmf=0ecdcb6142037dd1cdd08660a2349960bcf0270a X-Osstest-Versions-That: ovmf=3d0df0f076e120c6faf3c1892fffa21b4f31ed84 From: osstest service owner Date: Wed, 24 Mar 2021 00:36:43 +0000 flight 160352 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160352/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0ecdcb6142037dd1cdd08660a2349960bcf0270a baseline version: ovmf 3d0df0f076e120c6faf3c1892fffa21b4f31ed84 Last test of basis 160249 2021-03-22 01:39:50 Z 1 days Testing same since 160352 2021-03-23 05:41:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Liu Wei jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 3d0df0f076..0ecdcb6142 0ecdcb6142037dd1cdd08660a2349960bcf0270a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Mar 24 03:20:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 03:20:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100841.192366 (Exim 4.92) (envelope-from ) id 1lOu3e-0001BY-An; Wed, 24 Mar 2021 03:19:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100841.192366; Wed, 24 Mar 2021 03:19:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOu3e-0001BR-6L; Wed, 24 Mar 2021 03:19:46 +0000 Received: by outflank-mailman (input) for mailman id 100841; Wed, 24 Mar 2021 03:19:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOu3d-0001BJ-0u; Wed, 24 Mar 2021 03:19:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOu3c-0007Uy-OR; Wed, 24 Mar 2021 03:19:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOu3c-0001Dk-Ff; Wed, 24 Mar 2021 03:19:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOu3c-00005l-F8; Wed, 24 Mar 2021 03:19:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=C0hfeQ0KwTAvI/fJF69iUzY3DkJdxRHhYB3LFRF/cb4=; b=cpum5quLhasK4BX6RBe+IVd6Ug zZ9KCugyqMqmb1UGgG6QS2WLd+dmQSo8CZsaTb3Kc+OE8zvLAbdvOS/1nvZw7nk0scCckHw+s3rRU tsfA0YxNGfxmoG5TCVyuacUfwV6OILnkURzueCdF8T9L/TPaMJSSVhqeK1ze+L1mwVYs=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160348: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ecdff2f5a03210119b71806c3f5571d6906dd85e X-Osstest-Versions-That: xen=dae3c3e8b257cd27d6b35a467a34bf79a6650340 From: osstest service owner Date: Wed, 24 Mar 2021 03:19:44 +0000 flight 160348 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160348/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 160296 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160296 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160296 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160296 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160296 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160296 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160296 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 160296 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160296 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160296 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160296 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160296 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160296 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: xen ecdff2f5a03210119b71806c3f5571d6906dd85e baseline version: xen dae3c3e8b257cd27d6b35a467a34bf79a6650340 Last test of basis 160296 2021-03-22 10:58:16 Z 1 days Testing same since 160348 2021-03-23 03:13:33 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git dae3c3e8b2..ecdff2f5a0 ecdff2f5a03210119b71806c3f5571d6906dd85e -> master From xen-devel-bounces@lists.xenproject.org Wed Mar 24 04:18:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 04:18:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100853.192391 (Exim 4.92) (envelope-from ) id 1lOuyU-0007AN-4I; Wed, 24 Mar 2021 04:18:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100853.192391; Wed, 24 Mar 2021 04:18:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOuyU-0007AG-0d; Wed, 24 Mar 2021 04:18:30 +0000 Received: by outflank-mailman (input) for mailman id 100853; Wed, 24 Mar 2021 04:18:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOuyS-0007A3-Ac; Wed, 24 Mar 2021 04:18:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOuyR-000077-TJ; Wed, 24 Mar 2021 04:18:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOuyR-0004QK-Lv; Wed, 24 Mar 2021 04:18:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOuyR-0007q3-LS; Wed, 24 Mar 2021 04:18:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=uUrvi3CX/pFCFXPGNb6AVRyXbCj/IqwknTel9QVJ0hU=; b=Wv+55slNDjbss9yeG/8uknJNT8 4BxGaCtkxJXcXc9CFvBUiqJA72hYJIQ9srXCgbslD8PneP9UVEU36azxG52ReaZjUaBY6t7XbyduP z92tBSkajQ/R28I0kFY1KjCdKuib2/L4xHSQBXoZeF6gLASjgo2dRFRVcNwO5ksGdEVM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Subject: [qemu-mainline bisection] complete test-amd64-i386-freebsd10-i386 Message-Id: From: osstest service owner Date: Wed, 24 Mar 2021 04:18:27 +0000 branch xen-unstable xenbranch xen-unstable job test-amd64-i386-freebsd10-i386 testid guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 Bug not present: cbde7be900d2a2279cbc4becb91d1ddd6a014def Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160377/ commit 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 Author: Daniel P. Berrangé Date: Mon Feb 22 12:54:55 2021 +0000 machine: remove 'query-cpus' QMP command The newer 'query-cpus-fast' command avoids side effects on the guest execution. Note that some of the field names are different in the 'query-cpus-fast' command. Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta Signed-off-by: Daniel P. Berrangé For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/test-amd64-i386-freebsd10-i386.guest-saverestore.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/test-amd64-i386-freebsd10-i386.guest-saverestore --summary-out=tmp/160377.bisection-summary --basis-template=152631 --blessings=real,real-bisect,real-retry qemu-mainline test-amd64-i386-freebsd10-i386 guest-saverestore Searching for failure / basis pass: 160328 fail [host=fiano0] / 160125 [host=albana1] 160119 [host=huxelrebe1] 160113 [host=elbling0] 160104 [host=chardonnay0] 160097 [host=albana0] 160091 [host=chardonnay1] 160088 [host=albana1] 160082 [host=albana1] 160079 [host=fiano1] 160070 [host=pinot1] 160066 ok. Failure / basis pass flights: 160328 / 160066 (tree with no url: minios) Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ca318882714080fb81fe9eb89a7b7934efc5bfae 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 c95bd5ff1660883d15ad6e0005e4c8571604f51a b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3f8d1885e48e4d72eab0688f604de62e0aea7a38 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 9dc46386d89d83c73c41c2b19be83a73957c4393 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#4751a48aeb2ab828b0a5cbdc585fd3642967cda1-ca318882714080fb81fe9eb89a7b7934efc5bfae git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c74\ 37ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#3f8d1885e48e4d72eab0688f604de62e0aea7a38-c95bd5ff1660883d15ad6e0005e4c8571604f51a git://xenbits.xen.org/osstest/seabios.git#b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee-b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee git://xenbits.xen.org/xen.git#9dc46386d89d83c73c41c2b19be83a73957c4393-dae3c3e8b257cd27d6b35a467a34bf79a6650340 Loaded 44681 nodes in revision graph Searching for test results: 160048 [] 160050 [] 160057 [] 160062 [] 160064 [] 160066 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3f8d1885e48e4d72eab0688f604de62e0aea7a38 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 9dc46386d89d83c73c41c2b19be83a73957c4393 160070 [host=pinot1] 160079 [host=fiano1] 160082 [host=albana1] 160088 [host=albana1] 160091 [host=chardonnay1] 160097 [host=albana0] 160104 [host=chardonnay0] 160113 [host=elbling0] 160119 [host=huxelrebe1] 160125 [host=albana1] 160134 fail irrelevant 160147 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2e1293cbaac75e84f541f9acfa8e26749f4c3562 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160221 blocked c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3f8d1885e48e4d72eab0688f604de62e0aea7a38 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 9dc46386d89d83c73c41c2b19be83a73957c4393 160287 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3f8d1885e48e4d72eab0688f604de62e0aea7a38 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 9dc46386d89d83c73c41c2b19be83a73957c4393 160293 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2e1293cbaac75e84f541f9acfa8e26749f4c3562 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160302 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 f2a9a6c2a86570ccbf8c5c30cbb8bf723168c459 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160310 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8a40754bca14df63c6d2ffe473b68a270dc50679 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160167 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ca318882714080fb81fe9eb89a7b7934efc5bfae 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 bdee969c0e65d4d509932b1d70e3a3b2ffbff6d5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160318 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7286d62d4e259be8cecf3dc2deea80ecc14489a5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160330 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ca318882714080fb81fe9eb89a7b7934efc5bfae 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 bdee969c0e65d4d509932b1d70e3a3b2ffbff6d5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160341 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2255564fd21059960966b47212def9069cb56077 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160345 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 5e8892db93f3fb6a7221f2d47f3c952a7e489737 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160346 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 9e7118023fda7c29016038e2292d4d14129b63da b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160347 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8b858f9998a9d59a9a7188f2c5c6ffb99eff6115 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160349 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 773b0bc2838ede154c6de9d78401b91fafa91062 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 affc55e761ea4c96b9b2de582d813787a317aeda b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160351 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 30ca7eddc486646fa19c9619fcf233ceaa65e28c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160354 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e7c6a8cf9f5c82aa152273e1c9e80d07b1b0c32c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160355 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 f2e8319d456724c3d8514d943dc4607e2f08e88a b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160356 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ee2e67da8f882fcdef2c49fcc58e9962aa695f5a b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160357 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 81cbfd5088690c53541ffd0d74851c8ab055a829 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160328 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ca318882714080fb81fe9eb89a7b7934efc5bfae 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 c95bd5ff1660883d15ad6e0005e4c8571604f51a b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160359 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 283d845c9164f57f5dba020a4783bb290493802f b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160365 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3f8d1885e48e4d72eab0688f604de62e0aea7a38 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 9dc46386d89d83c73c41c2b19be83a73957c4393 160367 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ca318882714080fb81fe9eb89a7b7934efc5bfae 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 c95bd5ff1660883d15ad6e0005e4c8571604f51a b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160368 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 445a5b4087567bf4d4ce76d394adf78d9d5c88a5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160371 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cbde7be900d2a2279cbc4becb91d1ddd6a014def b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160372 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160373 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cbde7be900d2a2279cbc4becb91d1ddd6a014def b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160374 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160375 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cbde7be900d2a2279cbc4becb91d1ddd6a014def b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160377 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 Searching for interesting versions Result found: flight 160066 (pass), for basis pass Result found: flight 160328 (fail), for basis failure Repro found: flight 160365 (pass), for basis pass Repro found: flight 160367 (fail), for basis failure 0 revisions at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cbde7be900d2a2279cbc4becb91d1ddd6a014def b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 No revisions left to test, checking graph state. Result found: flight 160371 (pass), for last pass Result found: flight 160372 (fail), for first failure Repro found: flight 160373 (pass), for last pass Repro found: flight 160374 (fail), for first failure Repro found: flight 160375 (pass), for last pass Repro found: flight 160377 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 Bug not present: cbde7be900d2a2279cbc4becb91d1ddd6a014def Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160377/ commit 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 Author: Daniel P. Berrangé Date: Mon Feb 22 12:54:55 2021 +0000 machine: remove 'query-cpus' QMP command The newer 'query-cpus-fast' command avoids side effects on the guest execution. Note that some of the field names are different in the 'query-cpus-fast' command. Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta Signed-off-by: Daniel P. Berrangé Revision graph left in /home/logs/results/bisect/qemu-mainline/test-amd64-i386-freebsd10-i386.guest-saverestore.{dot,ps,png,html,svg}. ---------------------------------------- 160377: tolerable ALL FAIL flight 160377 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/160377/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-i386-freebsd10-i386 16 guest-saverestore fail baseline untested jobs: test-amd64-i386-freebsd10-i386 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Wed Mar 24 05:12:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 05:12:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100862.192415 (Exim 4.92) (envelope-from ) id 1lOvnu-0004fm-As; Wed, 24 Mar 2021 05:11:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100862.192415; Wed, 24 Mar 2021 05:11:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOvnu-0004ff-72; Wed, 24 Mar 2021 05:11:38 +0000 Received: by outflank-mailman (input) for mailman id 100862; Wed, 24 Mar 2021 05:11:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOvnt-0004fW-Ah; Wed, 24 Mar 2021 05:11:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOvnt-0001Ok-56; Wed, 24 Mar 2021 05:11:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOvns-00065N-Rk; Wed, 24 Mar 2021 05:11:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lOvns-00045R-RC; Wed, 24 Mar 2021 05:11:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OblZLsilve8beIwCQdPIcPxUvfosSRvDLHDyJW19Yx4=; b=GYLr7dbd7Ntnk57Ek0+1Zl0hZn UkhoG6ruJ3MVGjGJ4YQZ9kxENnwKDd7m5BQY666QaoPrGbig/NwdaSLXimH6cSwn9qTsAD3/yWrIl E1TYpglRAb0Bxigj3OOiTmMt42GZkfs+T/a++zmsSzQYf5/+QHKW8hxGs8+sXqBbmLNQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160353: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-qemuu-freebsd11-amd64:guest-start/freebsd.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=84196390620ac0e5070ae36af84c137c6216a7dc X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Wed, 24 Mar 2021 05:11:36 +0000 flight 160353 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160353/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-qemuu-freebsd11-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 152332 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 84196390620ac0e5070ae36af84c137c6216a7dc baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 235 days Failing since 152366 2020-08-01 20:49:34 Z 234 days 403 attempts Testing same since 160353 2021-03-23 05:48:05 Z 0 days 1 attempts ------------------------------------------------------------ 5235 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1300892 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 24 05:14:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 05:14:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100779.192430 (Exim 4.92) (envelope-from ) id 1lOvr2-0004rX-2H; Wed, 24 Mar 2021 05:14:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100779.192430; Wed, 24 Mar 2021 05:14:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOvr1-0004rQ-TI; Wed, 24 Mar 2021 05:14:51 +0000 Received: by outflank-mailman (input) for mailman id 100779; Tue, 23 Mar 2021 17:59:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOlJW-0002Dg-A4 for xen-devel@lists.xenproject.org; Tue, 23 Mar 2021 17:59:34 +0000 Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 95661f9e-e72b-4c47-b530-4d0390675ec9; Tue, 23 Mar 2021 17:59:33 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id x16so21714640wrn.4 for ; Tue, 23 Mar 2021 10:59:33 -0700 (PDT) Received: from dev-dsk-raphning-1b-d5e87e14.eu-west-1.amazon.com (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id m9sm24630278wro.52.2021.03.23.10.59.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Mar 2021 10:59:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95661f9e-e72b-4c47-b530-4d0390675ec9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JiAIBdlJzU3WbmB8nM5G05jP8/i0kPnmw043q33S3I0=; b=qklN+aFv15AVifhtELEw7XX5bb1b0Hs7yowF5kna1iBgtL6D5pn51ExjWLv0XWCHfq 1HZlMoVMuwkcLqc7lOSYmUa2QO3vcBiUtY2sotvVTOzSGrYjbjOGm5C2zclgCN3pxrzQ a8vZamoowV1d4hEiHovuq4iwrsluqr4PTkVopE4u+4WUqkUuMUDpb8y5Y+OLTuPh51Gi XbEJff68uIEruLYnNBrkK6g92QDrhIcMP2XBE7XsQAJUXLrhGUdd/mxfOmFN8bf/JYLT TtvWyDTJRQDcQnrf4+CzpNfIUx6UmalWJbCsYacJYaa8tYDAT8/0eMOISZMZ3WtFNz4n 09nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JiAIBdlJzU3WbmB8nM5G05jP8/i0kPnmw043q33S3I0=; b=ukMXTOoz2IiBoWmn1XjjAkbJWosiYihm/g6K9ZuL3Ttx2DSWc1r+tsFe7SmHhhWTbW Ra6RehU+pdf9CLbMh+Q1YQAtXe8p0UVaOLPw7NZQT2jg6oMzW3PoIhMQty1BxkgUx1DQ w7HkNiqkZfvn+N1lkA9aog7EhN1PYR22E1jXCW+Ca2rRQfw2jlRTlbscZ8To7VywNFYa 7KmZ4dIOADK9PcVKtndyar3AQD0XHl0F1WlKJoZ5YjD+tHabVvN0oC0kr7Ak+coj14T+ kS0YGkZzLdwe8OlprLIIIIk9814jv8/TpKXWR4R40POeC0NV1VAatjdK1qB3Xe8x3p4V Nxgg== X-Gm-Message-State: AOAM530lVg9wkhjhox0Epqc8cjOq/obHPU901CViv1EmfYAT65him4TB cQnXtT1OJ2Aix0SKeJFHDnQ= X-Google-Smtp-Source: ABdhPJy0+Mr9W14qNSf16p3qsaSvY17KjJP2S4lO1TQReU1iubMygywYyJNvklXYbx5HUUEm0MawJA== X-Received: by 2002:a05:6000:1868:: with SMTP id d8mr5261962wri.301.1616522372331; Tue, 23 Mar 2021 10:59:32 -0700 (PDT) From: Raphael Ning To: Simon Horman Cc: kexec@lists.infradead.org, Raphael Ning , Julien Grall , Hongyan Xia , xen-devel@lists.xenproject.org, Raphael Ning Subject: [PATCH] kexec-xen: Use correct image type for Live Update Date: Tue, 23 Mar 2021 17:59:23 +0000 Message-Id: <20210323175923.7342-1-raphning@gmail.com> X-Mailer: git-send-email 2.23.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Raphael Ning Unlike xen_kexec_load(), xen_kexec_unload() and xen_kexec_status() fail to distinguish between normal kexec and Xen Live Update image types. Fix that by introducing a new helper function that maps internal flags to KEXEC_TYPE_*, and using it throughout kexec-xen.c. Signed-off-by: Raphael Ning --- kexec/kexec-xen.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/kexec/kexec-xen.c b/kexec/kexec-xen.c index da514d052e3d..47da3da466f0 100644 --- a/kexec/kexec-xen.c +++ b/kexec/kexec-xen.c @@ -91,6 +91,17 @@ out: return rc; } +static uint8_t xen_get_kexec_type(unsigned long kexec_flags) +{ + if (kexec_flags & KEXEC_ON_CRASH) + return KEXEC_TYPE_CRASH; + + if (kexec_flags & KEXEC_LIVE_UPDATE) + return KEXEC_TYPE_LIVE_UPDATE; + + return KEXEC_TYPE_DEFAULT; +} + #define IDENTMAP_1MiB (1024 * 1024) int xen_kexec_load(struct kexec_info *info) @@ -177,12 +188,7 @@ int xen_kexec_load(struct kexec_info *info) seg++; } - if (info->kexec_flags & KEXEC_ON_CRASH) - type = KEXEC_TYPE_CRASH; - else if (info->kexec_flags & KEXEC_LIVE_UPDATE ) - type = KEXEC_TYPE_LIVE_UPDATE; - else - type = KEXEC_TYPE_DEFAULT; + type = xen_get_kexec_type(info->kexec_flags); arch = (info->kexec_flags & KEXEC_ARCH_MASK) >> 16; #if defined(__i386__) || defined(__x86_64__) @@ -211,8 +217,7 @@ int xen_kexec_unload(uint64_t kexec_flags) if (!xch) return -1; - type = (kexec_flags & KEXEC_ON_CRASH) ? KEXEC_TYPE_CRASH - : KEXEC_TYPE_DEFAULT; + type = xen_get_kexec_type(kexec_flags); ret = xc_kexec_unload(xch, type); @@ -232,7 +237,7 @@ int xen_kexec_status(uint64_t kexec_flags) if (!xch) return -1; - type = (kexec_flags & KEXEC_ON_CRASH) ? KEXEC_TYPE_CRASH : KEXEC_TYPE_DEFAULT; + type = xen_get_kexec_type(kexec_flags); ret = xc_kexec_status(xch, type); -- 2.23.3 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 07:27:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 07:27:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100872.192442 (Exim 4.92) (envelope-from ) id 1lOxum-0000MP-Le; Wed, 24 Mar 2021 07:26:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100872.192442; Wed, 24 Mar 2021 07:26:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOxum-0000MI-Hn; Wed, 24 Mar 2021 07:26:52 +0000 Received: by outflank-mailman (input) for mailman id 100872; Wed, 24 Mar 2021 07:26:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOxul-0000Lx-7J for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 07:26:51 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 328ad0d0-3aca-4b59-88a2-de16ee31dc0a; Wed, 24 Mar 2021 07:26:48 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DE560ADAA; Wed, 24 Mar 2021 07:26:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 328ad0d0-3aca-4b59-88a2-de16ee31dc0a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616570808; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=z/9Ifp54RfTYCPwQq5UAnaQvkdnDKNsqAfdkV7iRlpU=; b=rMgOUuAS9ZW38qKdizFQmMY5B4VwE7dQtUTjHTVdgEYN3/ixvqGD7lKnd7lTEq/AAx5fQ+ 0JY/4xptCd/AHz2ePU1cwF+2C2Yk5Yyyv1tSeiCSfUJjWSj/lFp8gIZZgs/ukV1w+XHsUY kFXxwI/6ZNfJ+HTAkJS6E0kt7NDrgFM= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface Date: Wed, 24 Mar 2021 08:26:45 +0100 Message-Id: <20210324072645.10596-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are some internals in the libxenstore interface which should be removed. Move those functions into xs_lib.c and the related definitions into xs_lib.h. Remove the functions from the mapfile. Add xs_lib.o to xenstore_client as some of the internal functions are needed there. Signed-off-by: Juergen Gross --- tools/include/xenstore_lib.h | 34 --------- tools/libs/store/libxenstore.map | 8 -- tools/libs/store/xs.c | 112 +--------------------------- tools/xenstore/Makefile | 4 +- tools/xenstore/utils.h | 11 +++ tools/xenstore/xenstore_client.c | 2 + tools/xenstore/xenstored_control.c | 1 + tools/xenstore/xenstored_core.c | 2 +- tools/xenstore/xs_lib.c | 114 ++++++++++++++++++++++++++++- tools/xenstore/xs_lib.h | 50 +++++++++++++ 10 files changed, 181 insertions(+), 157 deletions(-) create mode 100644 tools/xenstore/xs_lib.h diff --git a/tools/include/xenstore_lib.h b/tools/include/xenstore_lib.h index 4c9b6d1685..a10465fa69 100644 --- a/tools/include/xenstore_lib.h +++ b/tools/include/xenstore_lib.h @@ -43,25 +43,13 @@ struct xs_permissions enum xs_perm_type perms; }; -/* Header of the node record in tdb. */ -struct xs_tdb_record_hdr { - uint64_t generation; - uint32_t num_perms; - uint32_t datalen; - uint32_t childlen; - struct xs_permissions perms[0]; -}; - /* Each 10 bits takes ~ 3 digits, plus one, plus one for nul terminator. */ #define MAX_STRLEN(x) ((sizeof(x) * CHAR_BIT + CHAR_BIT-1) / 10 * 3 + 2) /* Path for various daemon things: env vars can override. */ -const char *xs_daemon_rootdir(void); const char *xs_daemon_rundir(void); const char *xs_daemon_socket(void); const char *xs_daemon_socket_ro(void); -const char *xs_domain_dev(void); -const char *xs_daemon_tdb(void); /* Simple write function: loops for you. */ bool xs_write_all(int fd, const void *data, unsigned int len); @@ -70,26 +58,4 @@ bool xs_write_all(int fd, const void *data, unsigned int len); bool xs_strings_to_perms(struct xs_permissions *perms, unsigned int num, const char *strings); -/* Convert permissions to a string (up to len MAX_STRLEN(unsigned int)+1). */ -bool xs_perm_to_string(const struct xs_permissions *perm, - char *buffer, size_t buf_len); - -/* Given a string and a length, count how many strings (nul terms). */ -unsigned int xs_count_strings(const char *strings, unsigned int len); - -/* Sanitising (quoting) possibly-binary strings. */ -struct expanding_buffer { - char *buf; - int avail; -}; - -/* Ensure that given expanding buffer has at least min_avail characters. */ -char *expanding_buffer_ensure(struct expanding_buffer *, int min_avail); - -/* sanitise_value() may return NULL if malloc fails. */ -char *sanitise_value(struct expanding_buffer *, const char *val, unsigned len); - -/* *out_len_r on entry is ignored; out must be at least strlen(in)+1 bytes. */ -void unsanitise_value(char *out, unsigned *out_len_r, const char *in); - #endif /* XENSTORE_LIB_H */ diff --git a/tools/libs/store/libxenstore.map b/tools/libs/store/libxenstore.map index 9854305a2c..44b0217f4c 100644 --- a/tools/libs/store/libxenstore.map +++ b/tools/libs/store/libxenstore.map @@ -32,18 +32,10 @@ VERS_3.0.3 { xs_control_command; xs_debug_command; xs_suspend_evtchn_port; - xs_daemon_rootdir; xs_daemon_rundir; xs_daemon_socket; xs_daemon_socket_ro; - xs_domain_dev; - xs_daemon_tdb; xs_write_all; xs_strings_to_perms; - xs_perm_to_string; - xs_count_strings; - expanding_buffer_ensure; - sanitise_value; - unsanitise_value; local: *; /* Do not expose anything by default */ }; diff --git a/tools/libs/store/xs.c b/tools/libs/store/xs.c index c91377c27f..7a9a8b1656 100644 --- a/tools/libs/store/xs.c +++ b/tools/libs/store/xs.c @@ -34,6 +34,7 @@ #include #include #include "xenstore.h" +#include "xs_lib.h" #include "list.h" #include "utils.h" @@ -1358,117 +1359,6 @@ static void *read_thread(void *arg) } #endif -char *expanding_buffer_ensure(struct expanding_buffer *ebuf, int min_avail) -{ - int want; - char *got; - - if (ebuf->avail >= min_avail) - return ebuf->buf; - - if (min_avail >= INT_MAX/3) - return 0; - - want = ebuf->avail + min_avail + 10; - got = realloc(ebuf->buf, want); - if (!got) - return 0; - - ebuf->buf = got; - ebuf->avail = want; - return ebuf->buf; -} - -char *sanitise_value(struct expanding_buffer *ebuf, - const char *val, unsigned len) -{ - int used, remain, c; - unsigned char *ip; - -#define ADD(c) (ebuf->buf[used++] = (c)) -#define ADDF(f,c) (used += sprintf(ebuf->buf+used, (f), (c))) - - assert(len < INT_MAX/5); - - ip = (unsigned char *)val; - used = 0; - remain = len; - - if (!expanding_buffer_ensure(ebuf, remain + 1)) - return NULL; - - while (remain-- > 0) { - c= *ip++; - - if (c >= ' ' && c <= '~' && c != '\\') { - ADD(c); - continue; - } - - if (!expanding_buffer_ensure(ebuf, used + remain + 5)) - /* for "\\nnn\0" */ - return 0; - - ADD('\\'); - switch (c) { - case '\t': ADD('t'); break; - case '\n': ADD('n'); break; - case '\r': ADD('r'); break; - case '\\': ADD('\\'); break; - default: - if (c < 010) ADDF("%03o", c); - else ADDF("x%02x", c); - } - } - - ADD(0); - assert(used <= ebuf->avail); - return ebuf->buf; - -#undef ADD -#undef ADDF -} - -void unsanitise_value(char *out, unsigned *out_len_r, const char *in) -{ - const char *ip; - char *op; - unsigned c; - int n; - - for (ip = in, op = out; (c = *ip++); *op++ = c) { - if (c == '\\') { - c = *ip++; - -#define GETF(f) do { \ - n = 0; \ - sscanf(ip, f "%n", &c, &n); \ - ip += n; \ - } while (0) - - switch (c) { - case 't': c= '\t'; break; - case 'n': c= '\n'; break; - case 'r': c= '\r'; break; - case '\\': c= '\\'; break; - case 'x': GETF("%2x"); break; - case '0': case '4': - case '1': case '5': - case '2': case '6': - case '3': case '7': --ip; GETF("%3o"); break; - case 0: --ip; break; - default:; - } -#undef GETF - } - } - - *op = 0; - - if (out_len_r) - *out_len_r = op - out; -} - /* * Local variables: * mode: C diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile index ab89e22d3a..01c9ccc70f 100644 --- a/tools/xenstore/Makefile +++ b/tools/xenstore/Makefile @@ -78,8 +78,8 @@ xenstored.a: $(XENSTORED_OBJS) $(CLIENTS): xenstore ln -f xenstore $@ -xenstore: xenstore_client.o - $(CC) $< $(LDFLAGS) $(LDLIBS_libxenstore) $(LDLIBS_libxentoolcore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS) +xenstore: xenstore_client.o xs_lib.o + $(CC) $^ $(LDFLAGS) $(LDLIBS_libxenstore) $(LDLIBS_libxentoolcore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS) xenstore-control: xenstore_control.o $(CC) $< $(LDFLAGS) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxentoolcore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS) diff --git a/tools/xenstore/utils.h b/tools/xenstore/utils.h index 87713a8e5d..9d012b97c1 100644 --- a/tools/xenstore/utils.h +++ b/tools/xenstore/utils.h @@ -7,6 +7,17 @@ #include +#include "xenstore_lib.h" + +/* Header of the node record in tdb. */ +struct xs_tdb_record_hdr { + uint64_t generation; + uint32_t num_perms; + uint32_t datalen; + uint32_t childlen; + struct xs_permissions perms[0]; +}; + /* Is A == B ? */ #define streq(a,b) (strcmp((a),(b)) == 0) diff --git a/tools/xenstore/xenstore_client.c b/tools/xenstore/xenstore_client.c index 8015bfe5be..150c03769a 100644 --- a/tools/xenstore/xenstore_client.c +++ b/tools/xenstore/xenstore_client.c @@ -22,6 +22,8 @@ #include +#include "xs_lib.h" + #define PATH_SEP '/' #define MAX_PATH_LEN 256 diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index 8e470f2b20..8569c97f99 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -34,6 +34,7 @@ Interactive commands for Xen Store Daemon. #include "utils.h" #include "talloc.h" +#include "xs_lib.h" #include "xenstored_core.h" #include "xenstored_control.h" #include "xenstored_domain.h" diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 8033c1e0eb..01906d9f2a 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -46,7 +46,7 @@ #include "utils.h" #include "list.h" #include "talloc.h" -#include "xenstore_lib.h" +#include "xs_lib.h" #include "xenstored_core.h" #include "xenstored_watch.h" #include "xenstored_transaction.h" diff --git a/tools/xenstore/xs_lib.c b/tools/xenstore/xs_lib.c index 80c03acbea..10fa4c3ad0 100644 --- a/tools/xenstore/xs_lib.c +++ b/tools/xenstore/xs_lib.c @@ -16,12 +16,13 @@ License along with this library; If not, see . */ +#include #include #include #include #include #include -#include "xenstore_lib.h" +#include "xs_lib.h" /* Common routines for the Xen store daemon and client library. */ @@ -179,3 +180,114 @@ unsigned int xs_count_strings(const char *strings, unsigned int len) return num; } + +char *expanding_buffer_ensure(struct expanding_buffer *ebuf, int min_avail) +{ + int want; + char *got; + + if (ebuf->avail >= min_avail) + return ebuf->buf; + + if (min_avail >= INT_MAX/3) + return 0; + + want = ebuf->avail + min_avail + 10; + got = realloc(ebuf->buf, want); + if (!got) + return 0; + + ebuf->buf = got; + ebuf->avail = want; + return ebuf->buf; +} + +char *sanitise_value(struct expanding_buffer *ebuf, + const char *val, unsigned len) +{ + int used, remain, c; + unsigned char *ip; + +#define ADD(c) (ebuf->buf[used++] = (c)) +#define ADDF(f,c) (used += sprintf(ebuf->buf+used, (f), (c))) + + assert(len < INT_MAX/5); + + ip = (unsigned char *)val; + used = 0; + remain = len; + + if (!expanding_buffer_ensure(ebuf, remain + 1)) + return NULL; + + while (remain-- > 0) { + c= *ip++; + + if (c >= ' ' && c <= '~' && c != '\\') { + ADD(c); + continue; + } + + if (!expanding_buffer_ensure(ebuf, used + remain + 5)) + /* for "\\nnn\0" */ + return 0; + + ADD('\\'); + switch (c) { + case '\t': ADD('t'); break; + case '\n': ADD('n'); break; + case '\r': ADD('r'); break; + case '\\': ADD('\\'); break; + default: + if (c < 010) ADDF("%03o", c); + else ADDF("x%02x", c); + } + } + + ADD(0); + assert(used <= ebuf->avail); + return ebuf->buf; + +#undef ADD +#undef ADDF +} + +void unsanitise_value(char *out, unsigned *out_len_r, const char *in) +{ + const char *ip; + char *op; + unsigned c; + int n; + + for (ip = in, op = out; (c = *ip++); *op++ = c) { + if (c == '\\') { + c = *ip++; + +#define GETF(f) do { \ + n = 0; \ + sscanf(ip, f "%n", &c, &n); \ + ip += n; \ + } while (0) + + switch (c) { + case 't': c= '\t'; break; + case 'n': c= '\n'; break; + case 'r': c= '\r'; break; + case '\\': c= '\\'; break; + case 'x': GETF("%2x"); break; + case '0': case '4': + case '1': case '5': + case '2': case '6': + case '3': case '7': --ip; GETF("%3o"); break; + case 0: --ip; break; + default:; + } +#undef GETF + } + } + + *op = 0; + + if (out_len_r) + *out_len_r = op - out; +} diff --git a/tools/xenstore/xs_lib.h b/tools/xenstore/xs_lib.h new file mode 100644 index 0000000000..efa05997d6 --- /dev/null +++ b/tools/xenstore/xs_lib.h @@ -0,0 +1,50 @@ +/* + Common routines between Xen store user library and daemon. + Copyright (C) 2005 Rusty Russell IBM Corporation + + This library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with this library; If not, see . +*/ + +#ifndef XS_LIB_H +#define XS_LIB_H + +#include "xenstore_lib.h" + +const char *xs_daemon_rootdir(void); +const char *xs_domain_dev(void); +const char *xs_daemon_tdb(void); + +/* Convert permissions to a string (up to len MAX_STRLEN(unsigned int)+1). */ +bool xs_perm_to_string(const struct xs_permissions *perm, + char *buffer, size_t buf_len); + +/* Given a string and a length, count how many strings (nul terms). */ +unsigned int xs_count_strings(const char *strings, unsigned int len); + +/* Sanitising (quoting) possibly-binary strings. */ +struct expanding_buffer { + char *buf; + int avail; +}; + +/* Ensure that given expanding buffer has at least min_avail characters. */ +char *expanding_buffer_ensure(struct expanding_buffer *, int min_avail); + +/* sanitise_value() may return NULL if malloc fails. */ +char *sanitise_value(struct expanding_buffer *, const char *val, unsigned len); + +/* *out_len_r on entry is ignored; out must be at least strlen(in)+1 bytes. */ +void unsanitise_value(char *out, unsigned *out_len_r, const char *in); + +#endif /* XS_LIB_H */ -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 08:01:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 08:01:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100877.192454 (Exim 4.92) (envelope-from ) id 1lOySd-0004gp-D1; Wed, 24 Mar 2021 08:01:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100877.192454; Wed, 24 Mar 2021 08:01:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOySd-0004gi-9P; Wed, 24 Mar 2021 08:01:51 +0000 Received: by outflank-mailman (input) for mailman id 100877; Wed, 24 Mar 2021 08:01:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOySc-0004gd-3i for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 08:01:50 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cec3b426-e591-473f-9319-773b92ecfa99; Wed, 24 Mar 2021 08:01:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cec3b426-e591-473f-9319-773b92ecfa99 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616572907; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=woo7kvB2XdfPv9gyPh77WIM0OARemRU8hCk7ysAHj1s=; b=AqD2QzOtuEW+gVn3V8FGlpSJVUrycnVYuieuYlInoHK3O83ep6/K+w0S f+Wb9fSZVc0sDZ2NGkxxjhIiZXp73HYyMEPVhoPZDvDVcdIw2uS74li8G c4wRnhbnNU3J6DNHHaLlJHc/TV5r3wosuvuT4XUWiJKjXoGyS9O9n8QFO 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: KEVSbC3AjYXtqR6HsrrUyWeI+a9n7sHiYdNQMcCMcpzq5v2bK0b3xT+82tb83HtFQvummqcOkC gZm8UcLcA3ilXJef+aZce+PR6+7THaZaRrQIUdg2qfKDDxPbl2/NoCHp4oC/PLEwE6M9UJT85s f37oBAFZVlW5TMLOL2QzGeiODfPlSyD1GRLL/OawpXUiT5Txkb/V4m8C5oH1/OyQPMaO70L1YA p4Qc/yj8hPh3lAhJFwLgkxtoAhPN9LiaZ5B2xlp7UiZ5Bi1Srn0EXxCgwB/GlWRpDka+2uWVgN NAM= X-SBRS: 5.2 X-MesageID: 39996249 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:f+I7nay08y14OvMaelZ0KrPxnO4kLtp033Aq2lEZdDV8Sebdv9 yynfgdyB//gCsQXnZlotybJKycWxrnmqJdybI6eZOvRhPvtmftFoFt6oP+3ybtcheTysd07o 0lSaR3DbTLYGRSpdrm4QW+DtYryMSG9qftvuvF03JxV2hRCp1IxS0RMHf9LmRdQg5aCZ0lUL ed/NNAvTq8eXIRB/7LfEUtde7FutHNidbaehYAHREq802jijmv5b78HXGjr2ojehlIxqov9n WArhzh6syYwoqG4zL/90uW1ZRZn9P91sBObfbjtuE5Iijh4zzYBrhJdKaFuFkO0YSSwXYs1O LBuhIxe/l0gkmhAl2dhTvI903e3C0163nkoGXo8UfLhcDiXjo1B45gqOtiA2LkwnEttt19z6 5Htljx3/E8bWKi7VbAzuPFWB1wmk2/rWBKq59qs1VlXZYDc7gUlIQD/SpuYeY9NRjn44MqGv QGNrC72N9qdzqhHhTkl1gq6tmtUnMvJwyBU0gPt+eEugIm4kxR/g82wtcSkWwH8494Y55Y5/ 7cOqAtr71WSNQKBJgNSNspcI+SMCjgUBjMOGWdLRDOE7wGAWvEr9rS7K8u7O+nVZQUxPIJ6d v8eWIdkVR3V1PlCMWI0pEO2AvKWn+BUTPkzdwbz4Rlu5XnLYCbcRGreRQLqY+Nsv8fCsrUV7 KYI5RNGcLuKmPoBMJgwxD+YZ9PMnMTOfdl++oTaharmIbmO4fqvuvUfLL4P7z2CwspXWv5Hz 8tRz72CMJc7l26e3PxjRTLMkmdOHDXzNZVKuz37uITwI8COslnqQ4Ok2m04cmNNHljv8UNDQ 5DCYKitpn+iXi9/G7O4WksEAFaFFxp7LLpVG4PgQcLNkjzYIsSotn3QxEX4FK3YjtEC+/GGg 9WoFp6vYitKYaL+CwkA9W7dkWXkmUUv3DPa5sHgKWM6YPEd/oDf9gbcZ00MT+OOw1+mA5spm sGQhQDXFXjGjTnjrjgqocVCuHZf9xVmxyqPsZQlHLauSyn1IISb0peewTrfd+cgA4oSTYRrE Z26bUjjL2JnivqFXEym90iMFpHaH2eBZVPCAjtXvQSppnbPCVLCUuajz2TjB8+Pk7n7V8biG DaISqIQv3TGVZGtndE0qHlzUNsegymDjFNQ0E/lbc4OXXNu3513+POXKa13meLQnYpw+0WMl j+EHAvCzIr4+ry+A+emT6EG3lj+44nOfbFCq8/N5vJ3Gm2FYGOnaYaPvNd8Zp/LuryuusTXe /3QX7SEBrIT8cSnyCFrHcsPyd57EQ+mfTzwRv/8SyW2mU8Dfe6GiURe5grZ/Wnq07qSPaD3M 8n0ZYbve6sPn7wbdDD46fNdDJHIg7Sp2nzb+xAk+EhgYsC8J9IW7/cWn/08VsC+jMUBsL9jl kfT6R2+6qpAP4mQ+UiPwZiumM0n9GOJnYxugP4AuUCbUgg5kWrSu+h0v7tk/4TGUWPqwv7BE mH/wBc9/nDWTGf1bRyMdNGHU1mLGw94m9l5uWMasn5DxirbfhK+DOBQzWAWY4YbKiOArMLqB lmp/mOgu+MbiL9nCTdpyFyLK4L02GpR6qJcU+xMN8N19yxIlKXhKS2pOa1kTfsUDO+L30iur ctTz1YUu1zzh84jIM21SCuSqv45mId+mEung1PpxrKwYip4GDSAEdcFxbW668mBAVuDg== X-IronPort-AV: E=Sophos;i="5.81,274,1610427600"; d="scan'208";a="39996249" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Up0vJoI+99UHFGtqeIxi8r3TE2gT9ZRxDZJXHi95BaQKy2zSotxKcqdEgRbvwRGtwWSrzjTcN6qgZXVnVbgWmv6Lsze6OC0NhIY1XReO0GPuAi9/4DB1T6vjZmYQaErRMmjRwrKotoExTAL8uWAARTr86CWgq+INOLdBFZUPzlRG10+o0MoW6DBya1spexRe1oTpnRNGn4uqB8F+80kzQjQVya1XGQ4bJ/14CcXpzXhKy4vWxqEYXY70CnyteMb1PQzw5htQkG0nPZgJ2Kv3giEx81Vkt9wLIXi1vT7KPC/KsEdrbfhq4qni5IA5ulsG2rmXdgQnMWL3fgITBfeV7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zOChQOKi45cydSnmUvqH75LPIVSVtkYyJvlO+/i0S/k=; b=mFiiTqDg17FIw5qiqETnkrILuX02YTf2mVNtui6ZmqjWlo7n9NVcpikM+p79BxgA56T7jJNw034t0WoZNR3hi0fo4SWNZPpwO6xZGMf86w8RI61YWYhSto8YOdcpoedpBIPQLxVI3dAz5L1J2yzRByuzhWIpD0aLQRDKYHIfKjQqSofvG9C2Vt4cfOn+LX10H3ambupFiU14RSWRNE6uhhZpYQo7gvMYlq4MyE8cNnC3vLocHeht75Hc84tbH+fCPDqp8EQBrohifEBKV0R8O9E1SnXWvCmfT5T5NL5X0A2sS5VHLsdf/73Vs0urY57utLc7V/VMwGWZj46tb1XM7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zOChQOKi45cydSnmUvqH75LPIVSVtkYyJvlO+/i0S/k=; b=YVaXVq/5bHcNmVmEL6vEZF+QC5wxfk6WbJzMzrCSiDHP5ABtBXthSxpGV6YQR2aj2g+nO8xpBHdJhi1R1nIv/cfasTH8DxZrh0vSK5D8A2qbGG2R+8RjiYOrB96OKh5/zN+anIVIlK6VzGWjefvwr3vr8TehdFG6O/arAwU5AqY= Date: Wed, 24 Mar 2021 09:01:18 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Christopher Clark CC: "Daniel P. Smith" , xen-devel , Andrew Cooper , Stefano Stabellini , Julien Grall , Julien Grall , , Wei Liu , George Dunlap , Jan Beulich , Rich Persaud , Bertrand Marquis , , , Adam Schwalm Subject: Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document Message-ID: References: <20210316031814.10311-1-dpsmith@apertussolutions.com> <20210316031814.10311-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR1P264CA0028.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2f::15) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8f1858f7-56ef-4cbe-5e12-08d8ee9b05d3 X-MS-TrafficTypeDiagnostic: DM6PR03MB4298: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Op4FSAMUPWHckEeUomLbQxOViwC37aJ+fNbTlApVK7XJat2Y3WxTkgGx5YNqtXqJWZL2z/pdJKTmLC/kzkzxi15NnLu7Wt+8uOoaFrUH5Se9fPgFzqba2tTSXJtBjSVf28aZTUlKHsKOH+x/EKf3FWfzMRI3zudbDO4kl2Mz7LD7gItx+qaCNJ0mXxKepnKPy0vmtlJtO5UCyIw0zzAXw8w1T4gBpOVL9kLFB36tpJrhDlipQjbRxO0Vfbce0WByt1O9tWml0pFPSBC52KbuFKZdlcfJQgWAzgbMeKdYlaIwY7PfM85yzIpO3yT/gdB1XwbOmJfHbbVxUvnm9CJY8PfJJkdPNfsZyarLfdahRZHc6cuBj7MdpfkZRsk0yDt/duK21504O3HI73RRvc5CtcsvgliqNuy/3y/NTjBrqjB7uWsTCRGvQcKeqEZXJrZH10BUY2WY5uX2Zve620NsLiWcVzju6UCwTYydxlyQNH3y58OdV3UpoN5/lHWQieoyNx8cZQ/fjXSuXp5npUpTJNoRKFHOVzLaUnB9cfipbcao9vS6r4NrRfmjIQACUKL3wZ4srjVY/ZK4ioNPDeMYJK2kjZgBpFPS1wOUaKYMElBy2mI0fPpvH3u279sppd1rLd68R797ejNGSfZcV1vI70YZMmiJ+FyaQxmEuppHrF4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(39860400002)(136003)(396003)(376002)(346002)(8676002)(9686003)(38100700001)(83380400001)(6666004)(33716001)(6486002)(53546011)(4326008)(8936002)(66476007)(7416002)(186003)(26005)(85182001)(54906003)(86362001)(6496006)(16526019)(2906002)(66556008)(5660300002)(6916009)(66946007)(316002)(478600001)(956004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZDVITThFWlNpSjhHVHowaWorcGpQYk5hTVBNeVBtZHlkNmN2YTZ1dDJjTUht?= =?utf-8?B?VEtzNzlCcTI0TlFCa09zSmc5dzdnRkYvNE1pV2xiVjJiZzdVUFRJUkpMci96?= =?utf-8?B?UVZrSkZ0QVU1R2Y2RTgvekg1QkQyMVJnemhBVUZxOGphMUFzclc5WG9GZE8r?= =?utf-8?B?SXNqRlpuVytSREcrOGV6dGxYRXlidS9YTWl5cERRM3VMNGlJZGo1M1JINVVm?= =?utf-8?B?Wi9OM1BYVzRQelcvOUJUeE1aMEVDUFAvQ0pQQkZNL3pSZXY2YlBISTNjenQx?= =?utf-8?B?SDZ2eFpwQ3RrNHdESkxRSzNGcWF5aW0raEUyZ2FZV2YvM09LWHEvRGpFUXdH?= =?utf-8?B?YXFEUlBpWHFrVjZvOEw0cjZWMjUrZW9OV1pTQVJCaXVJN1NZTGJDeUo5eDQ0?= =?utf-8?B?UHFDZEUxSUIyL05BbklJU2IvWVI2WTBjNVdUdDRJMTQwZFNlYktBSVp2N21B?= =?utf-8?B?bHR4OE8yc0w4a1loeStyMW5qSWlaL2lQTnFodDBEWm8wQ3N5VXU3UDZac1RC?= =?utf-8?B?ZlZ4QWdTVm9vbmVMQStzVmF1cEhZemxrMmJFc1d6eWNkS1dpQy9Xa1N2NVV5?= =?utf-8?B?VFVBV0J1ZmRuT2FHbmNnSkliM0VQQ2FtMCt0QmtCbkY0ZTVpRkFUT0RxTURq?= =?utf-8?B?a3pMNlJkSGIyb294UTBTR2Nxdk9NTzJrQ1h1RUxwNk0yaUhNNUwveXRlZHgr?= =?utf-8?B?SHpDZy93RUt2aXNVNjIxN29VNEYyQ3VEMVdBT3pMRmFYbTNqc0NzNlZVbXBU?= =?utf-8?B?QTk0YTcwOUVWb2szeDNqU24vcEF3RktiNzczV1J0WGtiWGhrUW84ZkkzS01T?= =?utf-8?B?Uk1zU1gvR29JMHMrVXRMb3FjNmVCWXlhMGhwT2lGalA3QU1vWEZZSnUxczJj?= =?utf-8?B?aTFUV3VLTlJTS2xHVm1UYjZjMnVXR3lrMURGRG16dlVEWlNwK1A5ekJ1Wmg5?= =?utf-8?B?Q1ZTMXJONHdkaVlYZVpDZXc4WWk5V2I5UGU4Yjg5eUJmNXkrSnozQytHMEt4?= =?utf-8?B?bTZPeHFnTjJ3UUZvYjhSazl4WGdHRk1ZK3BSYkVTWlFHb3p3V2JIWVlXeWI3?= =?utf-8?B?MnpQMmZnSlFKTDI4TklmLy9CRlBQb2JYN25pQUZUUzFEN1htTXpnL0wyaXVF?= =?utf-8?B?QVFVU2J6Wjc4RW1vZkNDUUZ3RFZsU1dkMXdpMUhNNDhnNG4rRXBSdGJvTmdH?= =?utf-8?B?aTVvVy8zVGJMb2dzZUdYM082bXJPTUtlRHNnR2U1M1BuUkdlUlJYYmJmNzRt?= =?utf-8?B?alJuQytTMElmYkpNaytGOGpvMmxoZGJaZlA0bzRXazViazhiZVMvZHRXZ2hq?= =?utf-8?B?VUhkTXNRMUU3dk5Uc1F4b2w1Sk1mNUlWelhKQXZvV3BkMU1mdnMrRTl5ZVhK?= =?utf-8?B?TU5LWEpKUTIxemtMZlpXbDFiVklOdzV2RzZrY3htWXFSNVJaTis3eXFHOG56?= =?utf-8?B?Sms3R25ZVGhObDAwSWwydTBFQzRSbWF4bWk4eW1pZ3VVSE8xMjJyS0R3Zjcr?= =?utf-8?B?WHB2UFJrVU5JNUk4SjVSY0VveExQOVRPQ1F5cVBkVEdkQW5ycU1ENUxMODRv?= =?utf-8?B?WnV3TTV1R3hWVHZIL2JMTFdZV2NWVS9wbkp6WjNxd2VDWXZoSWZ5MktoSzZQ?= =?utf-8?B?bmkybldpbzdZTXEvKy9uZUxCZUFOVnR0UHhEWmg5OFQ3WGRUczJwczdaRGlU?= =?utf-8?B?YUFQVG5kdU1wWXg3ZkVBQmlQR2lsMXZkT2dRajNDaDRQZHlaN1FqOVhNeVgv?= =?utf-8?Q?R3BkcH1tuRggTdYahRy3HkHEKO9ixCYt+uNEnSt?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8f1858f7-56ef-4cbe-5e12-08d8ee9b05d3 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 08:01:26.0055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vrPOXjt897neDroCuVqNN+VHBn8CvS8z2KY+PTWvXudQ51RNPq8ojVpVY9KP1/t21Yowim6A3o0iU9q3/ClPiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4298 X-OriginatorOrg: citrix.com On Tue, Mar 23, 2021 at 10:39:53AM -0700, Christopher Clark wrote: > On Thu, Mar 18, 2021 at 9:43 AM Roger Pau Monné wrote: > > > > Just took a quick look at it. > > > > On Mon, Mar 15, 2021 at 11:18:13PM -0400, Daniel P. Smith wrote: > > > + +---------------+-----------+------------+-----------+-------------+---------------------+ > > > + | **Xen Dom0** | **Linux** | **Late** | **Jail** | **Xen** | **Xen Hyperlaunch** | > > > + | **(Classic)** | **KVM** | **HW Dom** | **house** | **dom0less**+---------+-----------+ > > > + | | | | | | Static | Dynamic | > > > + +===============+===========+============+===========+=============+=========+===========+ > > > + | Hypervisor able to launch multiple VMs during host boot | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | | | | Y | Y | Y | Y | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | Hypervisor supports Static Partitioning | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | | | | Y | Y | Y | | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | Able to launch VMs dynamically after host boot | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | Y | Y | Y* | Y | Y* | | Y | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | Supports strong isolation between all VMs started at host boot | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | | | | Y | Y | Y | Y | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | Enables flexible sequencing of VM start during host boot | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | | | | | | Y | Y | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | Prevent all-powerful static root domain being launched at boot | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | | | | | Y* | Y | Y | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | Operates without a Highly-privileged management VM (eg. Dom0) | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | | | Y* | | Y* | Y | Y | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | Operates without a privileged toolstack VM (Control Domain) | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | | | | | Y* | Y | | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | Extensible VM configuration applied before launch of VMs at host boot | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | | | | | | Y | Y | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | Flexible granular assignment of permissions and functions to VMs | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | | | | | | Y | Y | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | Supports extensible VM measurement architecture for DRTM and attestation | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | | | | | | Y | Y | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | PCI passthrough configured at host boot | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > + | | | | | | Y | Y | > > > + +---------------+-----------+------------+-----------+-------------+---------+-----------+ > > > > I'm curious about this, I assume this is done using vPCI so that > > there's no hardware domain (and user-space device model) involved for > > PCI passthrough? > > That would be an incorrect assumption. See below for why. > > > I'm also not sure how you are going to handle things like SR-IOV > > devices. Right now SR-IOV capability is setup and initialized by the > > hardware domain, and the new virtual devices are notified to Xen once > > setup is done. Do you plan to move those bits into Xen, so that it can > > setup and initialize the SR-IOV capability? > > While you could do it with the vPCI, as you point out this will not work > for SR-IOV. With hyperlaunch, these cases will require the use of a boot > domain, which is for all intents and purposes, a lightweight/restricted > toolstack domain. > > The boot domain will have to do the necessary operations to ensure that > when startup is finished, PCI passthrough will be successfully setup. > Note, this may have to include the boot domain unpausing the hardware > domain to help complete the setup before the boot domain can exit and > allow the remaining domains to come online. OK, I was expecting hyperlaunch to do all domain creation in the hypervisor. If you offload domain creation of guests with pci-passthrough devices to a control domain and/or hardware domain, I'm not sure I see the difference from normal domain creation, ie: it's no longer something specific to hyperlaunch, as I could achieve the same by using the existing xendomains init script. Also you need a way to pass the configuration from the hypervisor into a control domain that would then wait for the hardware domain to come up and afterwards launch a guest with a pci-passthorugh device. The passing of this information from the hypervisor to the control domain would need to be done in an OS agnostic way if possible. Don't get me wrong, I don't think such approach is bad, I'm just unsure whether such functionality is really part of hyperlaunch, or instead something that you can achieve outside of hyperlaunch already. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 24 10:23:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 10:23:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100893.192487 (Exim 4.92) (envelope-from ) id 1lP0ex-0001Bc-5n; Wed, 24 Mar 2021 10:22:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100893.192487; Wed, 24 Mar 2021 10:22:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP0ex-0001BV-2j; Wed, 24 Mar 2021 10:22:43 +0000 Received: by outflank-mailman (input) for mailman id 100893; Wed, 24 Mar 2021 10:22:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP0ev-0001BN-GX; Wed, 24 Mar 2021 10:22:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP0ev-00071v-7L; Wed, 24 Mar 2021 10:22:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP0eu-00069y-Vb; Wed, 24 Mar 2021 10:22:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lP0eu-0002BU-V7; Wed, 24 Mar 2021 10:22:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=unH53bQNL1ZP/5up2h8Pg/9YLjqqdf2pJlCrK2QfSvc=; b=0jqD3zRO3NrKE5zQTIE+wqyifR wmHIo8PSRJWrbAv5TfP6UM1C4lmX5uHbDvdjGFfKdV9szg31gYxARkkC8/uEdEA3PaI4yi6+hfmN5 6QVoMlC+LYt+zTzKBo+D1IsL5TMMJ0dKU/RZd0n/MxmlQ5/2yAfmBjSTnpWTNqHr4oUw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 160385: all pass - PUSHED X-Osstest-Versions-This: xen=b9b3082002cac68726fb303e0abd2ff0113d4657 X-Osstest-Versions-That: xen=1b47cc852fd130ed9ce274a0f1600a4a62949a2c From: osstest service owner Date: Wed, 24 Mar 2021 10:22:40 +0000 flight 160385 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/160385/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen b9b3082002cac68726fb303e0abd2ff0113d4657 baseline version: xen 1b47cc852fd130ed9ce274a0f1600a4a62949a2c Last test of basis 159907 2021-03-10 09:18:33 Z 14 days Failing since 160076 2021-03-14 09:18:27 Z 10 days 4 attempts Testing same since 160385 2021-03-24 09:18:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Boris Ostrovsky Christian Lindig Dario Faggioli Doug Goldstein Elliott Mitchell Ian Jackson Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Roger Pau Monne Roger Pau Monné Wei Liu jobs: coverity-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 1b47cc852f..b9b3082002 b9b3082002cac68726fb303e0abd2ff0113d4657 -> coverity-tested/smoke From xen-devel-bounces@lists.xenproject.org Wed Mar 24 10:34:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 10:34:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100901.192510 (Exim 4.92) (envelope-from ) id 1lP0qS-0002I7-C7; Wed, 24 Mar 2021 10:34:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100901.192510; Wed, 24 Mar 2021 10:34:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP0qS-0002I0-9B; Wed, 24 Mar 2021 10:34:36 +0000 Received: by outflank-mailman (input) for mailman id 100901; Wed, 24 Mar 2021 10:34:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP0qR-0002Hv-Az for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 10:34:35 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fd221857-e8aa-4367-a4fc-3e6dc49f8f3e; Wed, 24 Mar 2021 10:34:34 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8ACFBAE20; Wed, 24 Mar 2021 10:34:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd221857-e8aa-4367-a4fc-3e6dc49f8f3e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616582073; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=E3sM+MHdMWPuK3E9lJOyRxJeBHE9Ske6vJlUmMvX6Z4=; b=NDOiO9ZwJRWKTA2v1y9oajxe+KOLRr7QEDLcW3CNShvU53tA67S0Mp+7JiVmd23o3CGROY g+k12hKhmY06AcVdCIjUJsYqQGr2CBYibxh53n2Fek6W4s9NqaVanTBWAzioK9o0yVw6fd p1PcZSmGf7idItawH/oQlIKxM2G4Q/w= To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson From: Jan Beulich Subject: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally Message-ID: <8e18a2a5-bc19-615d-0c8c-cea49adcf976@suse.com> Date: Wed, 24 Mar 2021 11:34:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating") was reported to cause boot failures on certain AMD Ryzen systems. Until we can figure out what the actual issue there is, skip this new part of HPET setup by default. Introduce a "hpet" command line option to allow enabling this on hardware where it's really needed for Xen to boot successfully (i.e. where the PIT doesn't drive the timer interrupt). Since it makes little sense to introduce just "hpet=legacy-replacement", also allow for a boolean argument as well as "broadcast" to replace the separate "hpetbroadcast" option. Signed-off-by: Jan Beulich --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1274,9 +1274,26 @@ supported. See docs/misc/arm/big.LITTLE. When the hmp-unsafe option is disabled (default), CPUs that are not identical to the boot CPU will be parked and not used by Xen. +### hpet (x86) +> `= List of [ | broadcast | legacy-replacement ]` + +> Default : `true`, `no-broadcast`, 'no-legacy-replacement` + +Controls Xen's use of the system's High Precision Event Timer. The boolean +allows to turn off use altogether. + +`broadcast` forces Xen to keep using the broadcast for CPUs in deep C-states +even when an RTC interrupt got enabled. + +`legacy-replacement` is intended to be used on platforms where the timer +interrupt doesn't get raised by the legacy PIT. This then also affects +raising of the RTC interrupt. + ### hpetbroadcast (x86) > `= ` +Deprecated alternative of `hpet=broadcast`. + ### hvm_debug (x86) > `= ` --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -52,6 +52,8 @@ static unsigned int __read_mostly num_hp DEFINE_PER_CPU(struct hpet_event_channel *, cpu_bc_channel); unsigned long __initdata hpet_address; +static bool __initdata opt_hpet = true; +static bool __initdata opt_legacy_replacement; u8 __initdata hpet_blockid; u8 __initdata hpet_flags; @@ -63,6 +65,32 @@ u8 __initdata hpet_flags; static bool __initdata force_hpet_broadcast; boolean_param("hpetbroadcast", force_hpet_broadcast); +static int __init parse_hpet_param(const char *s) +{ + const char *ss; + int val, rc = 0; + + do { + ss = strchr(s, ','); + if ( !ss ) + ss = strchr(s, '\0'); + + if ( (val = parse_bool(s, ss)) >= 0 ) + opt_hpet = val; + else if ( (val = parse_boolean("broadcast", s, ss)) >= 0 ) + force_hpet_broadcast = val; + else if ( (val = parse_boolean("legacy-replacement", s, ss)) >= 0 ) + opt_legacy_replacement = val; + else + rc = -EINVAL; + + s = ss + 1; + } while ( *ss ); + + return rc; +} +custom_param("hpet", parse_hpet_param); + /* * Calculate a multiplication factor for scaled math, which is used to convert * nanoseconds based values to clock ticks: @@ -761,12 +789,9 @@ u64 __init hpet_setup(void) unsigned int hpet_id, hpet_period, hpet_cfg; unsigned int last, rem; - if ( hpet_rate ) + if ( hpet_rate || !hpet_address || !opt_hpet ) return hpet_rate; - if ( hpet_address == 0 ) - return 0; - set_fixmap_nocache(FIX_HPET_BASE, hpet_address); hpet_id = hpet_read32(HPET_ID); @@ -803,9 +828,9 @@ u64 __init hpet_setup(void) * IRQ routing is configured. * * Reconfigure the HPET into legacy mode to re-establish the timer - * interrupt. + * interrupt, if available and if so requested. */ - if ( hpet_id & HPET_ID_LEGSUP && + if ( opt_legacy_replacement && (hpet_id & HPET_ID_LEGSUP) && !((hpet_cfg = hpet_read32(HPET_CFG)) & HPET_CFG_LEGACY) ) { unsigned int c0_cfg, ticks, count; From xen-devel-bounces@lists.xenproject.org Wed Mar 24 10:38:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 10:38:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100904.192523 (Exim 4.92) (envelope-from ) id 1lP0tk-0002Y9-SA; Wed, 24 Mar 2021 10:38:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100904.192523; Wed, 24 Mar 2021 10:38:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP0tk-0002Y2-Oy; Wed, 24 Mar 2021 10:38:00 +0000 Received: by outflank-mailman (input) for mailman id 100904; Wed, 24 Mar 2021 10:38:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP0tj-0002Xx-Pr for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 10:37:59 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown [40.107.7.88]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cf3dff37-a6e8-47e3-b9d1-1878f58b7225; Wed, 24 Mar 2021 10:37:56 +0000 (UTC) Received: from AS8PR04CA0123.eurprd04.prod.outlook.com (2603:10a6:20b:127::8) by AM6PR08MB2966.eurprd08.prod.outlook.com (2603:10a6:209:4e::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Wed, 24 Mar 2021 10:37:54 +0000 Received: from AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:127:cafe::5d) by AS8PR04CA0123.outlook.office365.com (2603:10a6:20b:127::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.26 via Frontend Transport; Wed, 24 Mar 2021 10:37:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT026.mail.protection.outlook.com (10.152.16.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Wed, 24 Mar 2021 10:37:54 +0000 Received: ("Tessian outbound f15357ab733e:v89"); Wed, 24 Mar 2021 10:37:54 +0000 Received: from 3ded44272dc6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E093AD1F-6F01-494A-952A-EB6976973C25.1; Wed, 24 Mar 2021 10:37:47 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3ded44272dc6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 24 Mar 2021 10:37:47 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) by VI1PR0801MB1950.eurprd08.prod.outlook.com (2603:10a6:800:8c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Wed, 24 Mar 2021 10:37:46 +0000 Received: from VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642]) by VI1PR08MB3629.eurprd08.prod.outlook.com ([fe80::1c0d:d340:1408:f642%4]) with mapi id 15.20.3955.027; Wed, 24 Mar 2021 10:37:46 +0000 Received: from a75445.arm.com (82.8.129.65) by LO2P265CA0493.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.24 via Frontend Transport; Wed, 24 Mar 2021 10:37:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf3dff37-a6e8-47e3-b9d1-1878f58b7225 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t56DnTJw6DzNJnAsMXt2TX6uT1vbJ+Bkkvpe/sYC3KQ=; b=Uqxn4BJzWNcTNletGBNtGvz1YIy4s1vVbKAZeYhf28e/BPzmzZFyOJpmw8rUbefryMbjHXnw238pCtD/7ToZdzPB6TD4N53TmSKpgjGLowLmefaSfqhYZmKIF/8Q6ebAxuZ8HCPkZ5nGP9Tc8ax46W2fZJOX6CBfhyDR6oS5Oto= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: d4204077317d35e2 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NqHOwjYzS5rKon78kXWLG1jJwMHt21s2VVcTxSGbezfvIlJEPAaMgFdPWjnSUWXetdowbU0FLhHO44CwmPrndVeF0VuaXCxi2kau6ZxZjpK209lhv4zlUzozMk0LbEiW8zgCnctfpBpCEP/G+b9832BWE58V6Dg9oPkrifCS6D2drP/QkuutsUgdPBtn5qHT5KYj+QJA9PL8jVGTU4Z3T3qGHPPDR414wtgnGYS7PiT3zUkMOtUXJRUkOQcD3K9QGLa7YuwgoNg8XDf9WE4KSSnXH0/fjq3NwpfNQMEe77yG+KUugtoMNpZzY8j+CCSXBzq4XC5CnfJ3TQqAWBU56A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t56DnTJw6DzNJnAsMXt2TX6uT1vbJ+Bkkvpe/sYC3KQ=; b=GNGd7F/r7HJgfAaDLKec3mAf3zZxZGYjxUSHtGfSJXGElYG0P0uTUO9tgeB0RCDAvaz5iw71maLs3mI6t1vlq+zxA5AZBykOLBP0Se1/ZTTNHEOGRj65CPPpnvJpNgKPH5oxqjiY1KiEljhAUjIHJLLoFUEpg65jo7mscCXyyqEEONUzhjDbEJeRzGpb4DbgDXT8mRxa+Qw8Z5W1cXFo4Qis4qvO8JZeaZuOqI4LWxx4a/Nlt1fno6e9qdXo5RTllrAQ2tlIIOXKLT366ekgwh/iBmZb0B6ogIlN9c9AG+7FzOYzw3cy4xJfY9NHzSgdXM26yJjJHbPi00ghyheGsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t56DnTJw6DzNJnAsMXt2TX6uT1vbJ+Bkkvpe/sYC3KQ=; b=Uqxn4BJzWNcTNletGBNtGvz1YIy4s1vVbKAZeYhf28e/BPzmzZFyOJpmw8rUbefryMbjHXnw238pCtD/7ToZdzPB6TD4N53TmSKpgjGLowLmefaSfqhYZmKIF/8Q6ebAxuZ8HCPkZ5nGP9Tc8ax46W2fZJOX6CBfhyDR6oS5Oto= Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10 From: Luca Fancellu In-Reply-To: Date: Wed, 24 Mar 2021 10:37:39 +0000 Cc: Jason Andryuk , "xen-devel@lists.xenproject.org" , =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= Content-Transfer-Encoding: quoted-printable Message-Id: <94DFDBDE-184D-4332-80B5-A8327DE2EA99@arm.com> References: <1FAD6C91-2B3A-48F0-88D7-CFCFC8B53BA9@arm.com> <2BC82A95-DFB9-4F90-8CC6-AE39405157ED@arm.com> <565C6475-4693-4A7C-8316-9613146300C2@arm.com> <2A09774F-ADDF-41B0-8E72-DC0FA0A6B1F3@arm.com> To: Julien Grall X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Originating-IP: [82.8.129.65] X-ClientProxiedBy: LO2P265CA0493.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::18) To VI1PR08MB3629.eurprd08.prod.outlook.com (2603:10a6:803:7f::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 84fa74d3-a6c8-40a1-8f98-08d8eeb0e1cf X-MS-TrafficTypeDiagnostic: VI1PR0801MB1950:|AM6PR08MB2966: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: V9g1MMHeLsH39kHqadPrxLXUdWRSW8gNRAmREfscBwvq34SgQZnMCl+nL/j6erwZXOfGbRGsNe9N3jjtKv6Aj+GrZ3v93bKkvMm+P6+1U126mdDNkBfZZK4p5QePmc3I5+kwOGOzgHhXRnFTf8petxIRqoUgoP0d11HPdqnfvZHAN2bye0IIdfEh+3BOwNtE/b8mW8sT49NDwNY9jVhhTJZFqUqJtdpaITbr4JOHvp/+Lsu9CYSKTtKB4AkcQFdF9nsvvsU7CacmwKdeu4i1lcmGBu/eVM0D6iieC7y55aR138HPO+hqBoxFtxByBn8Dsf2EYuidZxQI8dECfxuNIxnCzN2v/35JxiH01+axN4udEoc8/BFuCru5bw4344Xrf8BGYz5YKRaD2XRJVfNxOTPCWyUH28SuaHBLnrjAfRoOWoCJhTJPJsBNQnX2XWekTuoevKGi06/RtMFP2EWdw2TAHh/7aPg9gAMMWMp34bVfcoQW2KZvNJuOEoWuI+rq4RqzfNbuXPlf0ju4sTHh+ocjCbfiRmmAficlVNmsBoNnv5PsuU5QduilHVZUJY5B6iian+YdoJHZ94l5qoqmL+7VqMPoPLXCoSpVJ//+Kw0wuu+kvPHE6WkGUuceBL31oKvhfbTYkf5jZuXY7GAhnJCqpP0Jk7iJjt+o/r1MKMZoKjVJOrKfQ4SiwbUz4AsCxPRK8melorMacXgHVhzl05FkOSGDe+PqudP25DqsXDtdSLBzBQF0Y/P8j1y/d6ynBY8F80RiGBK2oU7l3YNYUA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3629.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(396003)(376002)(366004)(39860400002)(86362001)(66556008)(66476007)(33656002)(2616005)(956004)(36756003)(66946007)(8936002)(8676002)(38100700001)(5660300002)(83380400001)(53546011)(6486002)(7696005)(478600001)(52116002)(2906002)(4326008)(316002)(44832011)(6916009)(16526019)(54906003)(6666004)(26005)(186003)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YitMOUJ4bzlobEpnZHFsVWxJVUgzb1A4WEZjV2NGQmNhNFBrTm5FMGM1eUJs?= =?utf-8?B?TGczUDkxZ1J3UHlKZ091RUlmMTRaN2VBdGQxMUF5UDNHSGVkVnFPeXhJMnhT?= =?utf-8?B?b1ZxRExZTytSRnhsczBiMktuY3JSM2tmbjM0ZFUvRGVOZHBmS3hjOHVrcGxX?= =?utf-8?B?U1p2bDhObGJDYmswcHdRTWRLV29pNTJTd3BENmFWajdCN3RZYjNNOHA4cjdr?= =?utf-8?B?T1JaOW8rOGF5R0c0anVMczdNVVZJNHplY1pDdFNqbVhobDIvWUdrNlJPdWRD?= =?utf-8?B?c2hNakNacnMzbjNJc2NWaGJBU09hZE1YOTBwNUw5WDN2bkFLZklQK0pYNkkv?= =?utf-8?B?OEVQWXZjN1NoVGo4NEQyOFdEZGtTdEZmU1UyQzcrNkEvWFR0QVQ3OXJlS0Y1?= =?utf-8?B?YjlWVUZEN1Rucm9TQ2ZjcWFBbWlQdmVEZnFJQlVBT1lWb2cxdVp5bGVoYVpt?= =?utf-8?B?K3REM1FDNDRqNWJiZTJ4Tkx0SEl2S0xoY0dMSSswMEFYYWVUbkpnSGVXTGto?= =?utf-8?B?dlk5dTVaaHQ2Y3NWUHY0aHRYQUx4dXNHL05iQmMzRVdjYWtYMzV2T2hUa2tG?= =?utf-8?B?UjdKOTlld01wSkxMUkJUNHJwN2NPV1ZaSU5LY3RHbW5zUURZQkR2RFZGVktH?= =?utf-8?B?T1gzZUlFOFZIUkhzd1JjaVlzWG93a1Yrek90UVRJQ3dyTi93VmpCYWZqVEJJ?= =?utf-8?B?dUJubzluRlA0d0F5V29RQmExSGtXa213emZMYWF4eGlVTHdHRCsyWm9SM2pa?= =?utf-8?B?OUFneWRyWTJBMzZzdmhvZmxjNklZOU9jR2JKQWM5WEF1UnhzRTFsVmFFUVJm?= =?utf-8?B?Nm1QRjd6QWRtdXc4am0xNzBGSHJWb1dxVWZ3L3p5ZmJ1UnJkS2NuZ0MxcW1O?= =?utf-8?B?NThaRkhxM2FkV3B2eVlpZXVZMEdkZmdkQkdOWE9pZGpmK3J3RWRnTW1GSlBl?= =?utf-8?B?V3d0WU02Z2VFelc0c1RmaTAyY1doNUwxVjNkWjRKNFdZWm8xNkUyU2RwUHFl?= =?utf-8?B?b0VCekNQb3NzRm5Id1VQVTVUaTR0N2o1RThoQmhpNlVyQTZrM3ZBeXJxb1BI?= =?utf-8?B?VVlGbzZZMWJMRS8yaTcvQjJSK3NlcUhCSlBGajJzV1pTSWQ3TTdXNEdXL1h3?= =?utf-8?B?VnI1RC9ncjdKOCtLZCt6U3ZRS1VvNS9DNnRZbXFhQmRMYzF1NG9LY213WTNr?= =?utf-8?B?Zkx5MVNxb0VTMUhjSHVvbG5na0FIL2NDWU1VcHFIanpVSzVTVGQ2Qzc2TzdB?= =?utf-8?B?WkVWcEVzU3F4Y2U2Z25YVmpNd3RmTU9KdkRTNHN0d210MGhTMnFuMHZsMUx1?= =?utf-8?B?Nm55OCt5Vjl2aUljWi9MQjVlY1VEVTNsY2ZUV0VoWlZJc3M3WDJiRUtEa2Nk?= =?utf-8?B?ZDZoRVpxRTFvdlVvdVdMVGt4S1JUa2JEWEg4SkZrT0NtcTcreXMwMnB1Z1RP?= =?utf-8?B?bUFxbzV2WWRlQ3RyNjF6a0s0ZERMVTd3TS9lRWUrV01LZDJFVnhiM2JEU1g3?= =?utf-8?B?cFE5VWN6aEZmTlBoczhzc0lKOUNsRTdtVXRZLzBkNE8vYmwrZ1NNanB3Y0JL?= =?utf-8?B?cWdNb0swa08vWWRWOEZidlVSckN1bW1aSUlIU1AyNjN5dG4rZjlHQjBIcTJk?= =?utf-8?B?VWdTUnRLS1BoL0I0elJ3OTNBWWxxb2hCUGZHSCtBSDRpQ0o0aFppaUptRzVU?= =?utf-8?B?MDJ1anlhTE1XRGJHM2dYdWZQdHBkUUJPMHZDRUdEMFQ2emNoR1FIMSs5OWwr?= =?utf-8?Q?0xCekO04svi7DBkKlTyhrktNLD9JPWaNXhKhgU9?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1950 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: fe9a5673-67cc-4335-e2e6-08d8eeb0dce5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MU8Kp9GSwXOrsfUt8dUawKIcNBRbjz8cE5DGKs8ssGX0z5rbj8V1j6jctcxfimddmBdgUy2gVo35WEh1FVyB/V7AER0R1gB1BDiZi25H7ATtjk6V4TG6hCd05a14hNdkmAtrRcE+xqLmrFE8qMCCskI3hYUZlZmXEa3uxL/FWG677FFlBf+72nmqXxWF0CDU0n++cfVG4MTyi4h3OrbL07sy57YqRqX19zK2GXCQLd/bGZsU4SCOO3int5SJ3AEkRtlr2EB3l1mUsPBfUKPB9baM/7aH9/LLDu0/64CGWZrmNNvtMzS5zxhh8m2nrTHC9kaqoXDhO5YlOGXsxBuGkbdC/Hup0iUfNXg77XoW1+lL/ccOirlOHn/cTt/Vzcjo/lywdCRyv6Juuj45Z/7vc9thb2tbJqwPLLiKFC4kulOsxepAFgqbDsvabJLub2vFmjzDwmsZQsQyVPLULGFbdIfQOmEfVOqw/mLY0Khm1jVUL5k4kMF0IiC5FoR7chwjqDsim1nPoxaKbJwS7q8IibfOALKy5wwj7lNE5bRx24nBwQ80akJHIYXJhEkHOvVuAuPyCsb2F+paIZa9btaU6MuUe8O1zD80IURjDrQVzQdUg+HDO7LBi3qzjxi7UxfYSJvjbhJsE8BHx8/cfXVOe6T9y2oF3m4K8WkIQgxbZoONVIW7P2SzqYjndV0A6KkeJ9wqpX2CXz29PeIGS4OOyYOsuTjDxIsZ3fDX0S9rHck= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(39860400002)(396003)(136003)(346002)(36840700001)(46966006)(53546011)(2906002)(6486002)(83380400001)(54906003)(478600001)(956004)(7696005)(8676002)(6862004)(8936002)(36756003)(316002)(86362001)(70206006)(82310400003)(2616005)(70586007)(107886003)(44832011)(4326008)(336012)(6666004)(81166007)(356005)(26005)(5660300002)(47076005)(16526019)(186003)(33656002)(82740400003)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 10:37:54.2436 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 84fa74d3-a6c8-40a1-8f98-08d8eeb0e1cf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB2966 > On 23 Mar 2021, at 19:26, Julien Grall wrote: >=20 >=20 >=20 > On 23/03/2021 17:06, Luca Fancellu wrote: >> Hi all, >=20 > Hi, >=20 > Please avoid top posting when answering to a comment. This makes more dif= ficult to follow. >=20 >> I have an update, changing the lock introduced by the serie from spinloc= k_t to raw_spinlock_t, changing the lock/unlock function to use the raw_* v= ersion and keeping the BUG_ON(=E2=80=A6) (now we can because raw_* implemen= tation disable interrupts on preempt_rt) the kernel is booting correctly. >> So seems that the BUG_ON(=E2=80=A6) is needed and the unmask function sh= ould run with interrupt disabled, anyone knows why this change worked? >=20 > Do you mean why no-one spotted the issue before? If so, AFAIK, on vanilla= Linux, spin_lock is still just a wrapper to raw_spinlock. IOW there is no = option to replace it with a RT spinlock. >=20 > So if you don't apply the RT patches, you would not be able to trigger th= e issue. >=20 > As to the fix itself, I think using raw_spinlock_t is the correct thing t= o do because the lock is also used in interrupt context (even with RT enabl= ed). >=20 > Would you be able to send a patch? Yes I=E2=80=99ll send a patch soon >=20 >>> On 23 Mar 2021, at 15:39, Luca Fancellu wrote: >>>=20 >>> Hi Jason, >>>=20 >>> Thanks for your hints, unfortunately seems not an init problem because = in the same init configuration I tried the 5.10.23 (preempt_rt) without the= Juergen patch but with the BUG_ON removed and it boots without problem. So= seems that applying the serie does something (on a preempt_rt kernel) and = we are trying to figure out what. >>>=20 >>>=20 >>>> On 23 Mar 2021, at 12:36, Jason Andryuk wrote: >>>>=20 >>>> On Mon, Mar 22, 2021 at 3:09 PM Luca Fancellu = wrote: >>>>>=20 >>>>> Hi Juergen, >>>>>=20 >>>>> Yes you are right it was my mistake, as you said to remove the BUG_ON= (=E2=80=A6) this serie (https://patchwork.kernel.org/project/xen-devel/cove= r/20210306161833.4552-1-jgross@suse.com/) is needed, since I=E2=80=99m usin= g yocto I=E2=80=99m able to build a preempt_rt kernel up to the 5.10.23 and= for this reason I=E2=80=99m applying that serie on top of this version, th= en I=E2=80=99m removing the BUG_ON(=E2=80=A6). >>>>>=20 >>>>> A thing that was not expected is that now the Dom0 kernel is stuck on= =E2=80=9CSetting domain 0 name, domid and JSON config=E2=80=A6=E2=80=9D st= ep and the system seems unresponsive. Seems like a deadlock issue but looki= ng into the serie we can=E2=80=99t spot anything and that serie was also te= sted by others from the community. >=20 > The deadlock is expected. When you enable RT spinlock, the interrupts wil= l not disabled even when you call spin_lock_irqsave(). >=20 > As the lock is also used in interrupt context (e.g. with interrupt masked= ), this will lead to a deadlock because the lock can be held with interrupt= unmasked. >=20 > This is quite a common error as developpers are not yet used to test RT. = I remember finding a few other instances like that when I worked on RT a co= uple of years ago. >=20 > For future reference, I think CONFIG_PROVE_LOCKING=3Dy could help you to = detect (potential) deadlock. >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 24 10:52:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 10:52:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100907.192535 (Exim 4.92) (envelope-from ) id 1lP17u-0004KH-4e; Wed, 24 Mar 2021 10:52:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100907.192535; Wed, 24 Mar 2021 10:52:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP17u-0004KA-10; Wed, 24 Mar 2021 10:52:38 +0000 Received: by outflank-mailman (input) for mailman id 100907; Wed, 24 Mar 2021 10:52:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP17t-0004K3-3l for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 10:52:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP17s-0007Vf-UM for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 10:52:36 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lP17s-00046q-0f for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 10:52:36 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lP17o-0004mV-QS; Wed, 24 Mar 2021 10:52:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=FVMmDOsLRfMMzg/p7EPsKJUqppGM919XRcNJQg0/VA0=; b=cXcDDESsVord1WaxOz31jbuDZm /RjnHawvcTqtSyVsFIxbVRGhjxsIzZ9m90OO6r3J2L8IKyO9Z5Gv2m9bKiWvWNPxNntFmIktynHmn 1E2C5nXpRMxBZTW186jBeu4vBkqXSrk69ErSJteTrO0q6XDGPLlXZ+S6LTtvPHg6Vx3k=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24667.6640.601389.478906@mariner.uk.xensource.com> Date: Wed, 24 Mar 2021 10:52:32 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Ian Jackson Subject: Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally In-Reply-To: <8e18a2a5-bc19-615d-0c8c-cea49adcf976@suse.com> References: <8e18a2a5-bc19-615d-0c8c-cea49adcf976@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally"): > Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC > static PIT clock gating") was reported to cause boot failures on certain > AMD Ryzen systems. Until we can figure out what the actual issue there > is, skip this new part of HPET setup by default. Introduce a "hpet" > command line option to allow enabling this on hardware where it's really > needed for Xen to boot successfully (i.e. where the PIT doesn't drive > the timer interrupt). > > Since it makes little sense to introduce just "hpet=legacy-replacement", > also allow for a boolean argument as well as "broadcast" to replace the > separate "hpetbroadcast" option. Release-Acked-by: Ian Jackson Thanks. I would like to ee it committed by the end of the week. I don't feel qualified to review this. I'm slightly uncomfortable with the command line rework but I think as you say there probably isn't a good more-minimal version. I would like to ask the reviewer(s) to focus on this question: if the option is not passed, does this revert the behaviour to be identical to the behaviour of Xen before e1de4c196a2e ? Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 24 11:02:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 11:02:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100915.192553 (Exim 4.92) (envelope-from ) id 1lP1H6-0005RF-8z; Wed, 24 Mar 2021 11:02:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100915.192553; Wed, 24 Mar 2021 11:02:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1H6-0005R8-60; Wed, 24 Mar 2021 11:02:08 +0000 Received: by outflank-mailman (input) for mailman id 100915; Wed, 24 Mar 2021 11:02:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1H5-0005R2-3P for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 11:02:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1H5-0007hi-10 for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 11:02:07 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lP1H4-0004rf-VI for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 11:02:06 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lP1H1-0004o9-MT; Wed, 24 Mar 2021 11:02:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=/8DsYsAKj7i1cJjt9Q3WvNLx46fhSwfWalCF1UVPgo8=; b=IsyH6ppoqRw1+gbk5rtAAEWUOz UiiJO4H54AKzjUcHrp/NQXWkayVa5fERJJnv2k2QDk1rLaBvdciRzw7Kzk4TGigTg9gTQvLKB1cXy C+vyTA9BshKfCJpSlbhJTRhG9sLrD1swQNOgzgD+qBwYmjEloZEb1eAAcU3J5OFQfcV8=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24667.7211.431280.743192@mariner.uk.xensource.com> Date: Wed, 24 Mar 2021 11:02:03 +0000 To: Juergen Gross Cc: xen-devel@lists.xenproject.org, Wei Liu Subject: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface In-Reply-To: <20210324072645.10596-1-jgross@suse.com> References: <20210324072645.10596-1-jgross@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Juergen Gross writes ("[PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface"): > There are some internals in the libxenstore interface which should be > removed. > > Move those functions into xs_lib.c and the related definitions into > xs_lib.h. Remove the functions from the mapfile. Add xs_lib.o to > xenstore_client as some of the internal functions are needed there. This seems wider in scope than I was expecting. Reviewing it again makes me think that there are more concers than I anticipated and I am now doubtful whether I want to take it in 4.15. I thought at this stage we were just going to fix the accidentally-exported symbols with improperly namespaced names. It is those for which I think that withdrawing them without an ABI soname bump, in contravention of usual library ABI stability rules, will not cause trouble in pracice. My current thoughts are that several of these really ought not to be withdrawn as they might cause actual trouble: > /* Path for various daemon things: env vars can override. */ > -const char *xs_daemon_rootdir(void); > -const char *xs_domain_dev(void); > -const char *xs_daemon_tdb(void); Someone who was writing bindings might have exposed these without knowing what they were, resulting in linkage to these symbols. > bool xs_strings_to_perms(struct xs_permissions *perms, unsigned int num, > const char *strings); > > -/* Convert permissions to a string (up to len MAX_STRLEN(unsigned int)+1). */ > -bool xs_perm_to_string(const struct xs_permissions *perm, > - char *buffer, size_t buf_len); Isn't this function potentially useful ? It seems funny to have only one of the conversion directions. > +void unsanitise_value(char *out, unsigned *out_len_r, const char *in) Is it possible to do sort this out in a more minimal way ? Eg we could change the name to namespace it properly. (I haven't looked at the code in detail and am still rather under-caffeinated so maybe I am talking nonsense here.) Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 24 11:10:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 11:10:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100918.192565 (Exim 4.92) (envelope-from ) id 1lP1Ox-0006VC-4j; Wed, 24 Mar 2021 11:10:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100918.192565; Wed, 24 Mar 2021 11:10:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1Ox-0006V5-0p; Wed, 24 Mar 2021 11:10:15 +0000 Received: by outflank-mailman (input) for mailman id 100918; Wed, 24 Mar 2021 11:10:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1Ow-0006V0-7Y for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 11:10:14 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c45c7d37-7923-43d7-ba0e-7fc78e068945; Wed, 24 Mar 2021 11:10:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 16082AD6D; Wed, 24 Mar 2021 11:10:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c45c7d37-7923-43d7-ba0e-7fc78e068945 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616584212; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L3Bpwc+9PReUkKQTaz7/0XsMzijQvrdDk/MtSMDHkyA=; b=SXo6M5ancp84uF8VoUG4nBYvb3VuvKd5ZNpIfhzgdFFQ++9dobOE0FrmRjkV6bt2oMW02y zNxsqhO53UOiU6nT//XFvAMTwgRIXQzvLKuClTRYOF3uuf0/JAStp05svWDYWNXCME6M3a Ll+fDqd5rtGKpyKIWCKGx4TkQZeMqXg= To: Ian Jackson Cc: xen-devel@lists.xenproject.org, Wei Liu References: <20210324072645.10596-1-jgross@suse.com> <24667.7211.431280.743192@mariner.uk.xensource.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface Message-ID: Date: Wed, 24 Mar 2021 12:10:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24667.7211.431280.743192@mariner.uk.xensource.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jVOrxH4gDMpRiTnC7PbveHaOLhEBiVY7t" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jVOrxH4gDMpRiTnC7PbveHaOLhEBiVY7t Content-Type: multipart/mixed; boundary="6gXv8qVU1WO0TlzbksgRO2bmzykrNGFdb"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Ian Jackson Cc: xen-devel@lists.xenproject.org, Wei Liu Message-ID: Subject: Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface References: <20210324072645.10596-1-jgross@suse.com> <24667.7211.431280.743192@mariner.uk.xensource.com> In-Reply-To: <24667.7211.431280.743192@mariner.uk.xensource.com> --6gXv8qVU1WO0TlzbksgRO2bmzykrNGFdb Content-Type: multipart/mixed; boundary="------------A046F41ED6F207FD1D99F809" Content-Language: en-US This is a multi-part message in MIME format. --------------A046F41ED6F207FD1D99F809 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 24.03.21 12:02, Ian Jackson wrote: > Juergen Gross writes ("[PATCH-for-4.15] tools/libs/store: cleanup libxe= nstore interface"): >> There are some internals in the libxenstore interface which should be >> removed. >> >> Move those functions into xs_lib.c and the related definitions into >> xs_lib.h. Remove the functions from the mapfile. Add xs_lib.o to >> xenstore_client as some of the internal functions are needed there. >=20 > This seems wider in scope than I was expecting. >=20 > Reviewing it again makes me think that there are more concers than I > anticipated and I am now doubtful whether I want to take it in 4.15. I'm fine with that. TBH I would have been surprised if you'd just take it. :-) > I thought at this stage we were just going to fix the > accidentally-exported symbols with improperly namespaced names. It is > those for which I think that withdrawing them without an ABI soname > bump, in contravention of usual library ABI stability rules, will not > cause trouble in pracice. Just removing them from the mapfile doesn't work. Either we need to keep them (maybe with "xs_" prefixed), or we need to go the way I've done in this patch. > My current thoughts are that several of these really ought not to be > withdrawn as they might cause actual trouble: >=20 >> /* Path for various daemon things: env vars can override. */ >> -const char *xs_daemon_rootdir(void); >> -const char *xs_domain_dev(void); >> -const char *xs_daemon_tdb(void); >=20 > Someone who was writing bindings might have exposed these without > knowing what they were, resulting in linkage to these symbols. This patch is removing everything not being used in the (known) Xen ecosystem (Xen, qemu, qemu-trad, mini-os). >=20 >> bool xs_strings_to_perms(struct xs_permissions *perms, unsigned int = num, >> const char *strings); >> =20 >> -/* Convert permissions to a string (up to len MAX_STRLEN(unsigned int= )+1). */ >> -bool xs_perm_to_string(const struct xs_permissions *perm, >> - char *buffer, size_t buf_len); >=20 > Isn't this function potentially useful ? It seems funny to have only > one of the conversion directions. As stated above: this patch is doing the absolute possible maximum. I'm absolutely fine to drop some of the removals. >> +void unsanitise_value(char *out, unsigned *out_len_r, const char *in)= >=20 > Is it possible to do sort this out in a more minimal way ? Eg we > could change the name to namespace it properly. (I haven't looked at > the code in detail and am still rather under-caffeinated so maybe I am > talking nonsense here.) No nonsense. This would be the really minimum option (apart from doing nothing). I can setup the patch for that and keep the rest for 4.16 (which will then probably need to bump the so version). Juergen --------------A046F41ED6F207FD1D99F809 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------A046F41ED6F207FD1D99F809-- --6gXv8qVU1WO0TlzbksgRO2bmzykrNGFdb-- --jVOrxH4gDMpRiTnC7PbveHaOLhEBiVY7t Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBbHhMFAwAAAAAACgkQsN6d1ii/Ey8l Bgf/ZFQ0BrXgxiEJ/bxQy5Z5Axta+7KpPt22ghggxSCcuBJG4/qGxD7f5lL5My+YeSy+0GAYsZSN Szzh+rL+k2xSRaE2zBX3i1CWohbBgrr/hC74mwrn8xL+UIVUn7p87Oj1L20TFw0OhQJncQVvwlqP WsHTyOfya4AAuWbdUpxqbg/Jg43cTtC/F5DiJoIFaqF2yDTy95kjaAxmh2fLkTLhiowbE/Rh+/VL Nf73Ys//oBSgUcv3b5BOw3Lyo2ZzO6M6U4P2z26KsYrrkUAKaOEEOZxDCNBgfmDcqP9JzG7TFCzp fA7U8Jx13v0h9sgGcykAhTHaSRHEeteaBXs7FtksBw== =tbY/ -----END PGP SIGNATURE----- --jVOrxH4gDMpRiTnC7PbveHaOLhEBiVY7t-- From xen-devel-bounces@lists.xenproject.org Wed Mar 24 11:30:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 11:30:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100923.192582 (Exim 4.92) (envelope-from ) id 1lP1iL-00009e-PT; Wed, 24 Mar 2021 11:30:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100923.192582; Wed, 24 Mar 2021 11:30:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1iL-00009W-Mb; Wed, 24 Mar 2021 11:30:17 +0000 Received: by outflank-mailman (input) for mailman id 100923; Wed, 24 Mar 2021 11:30:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1iK-00009R-NL for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 11:30:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1iK-00089s-Kc for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 11:30:16 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lP1iK-0006i8-Ik for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 11:30:16 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lP1iH-0004sI-5Q; Wed, 24 Mar 2021 11:30:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=pfDQjMJUz4k7QKACjLX6dU6icLBu934H/nrWL/BAeq8=; b=FFHl+HY1uEPrMurB2snnhMjIGU m2ZA7HrLQfZklyVUuUHKfyoQElsWXKcHZgOto+pHavOBrSrvNf97z/sLkC4ShKsjGTMVsDMfD4nDs 2sceugbstoe6zAtC9sPw/44blbXD9IavQ1js3nklmNBTBKvU4h6sTX81z4RPF0dDj3qc=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24667.8900.993418.152255@mariner.uk.xensource.com> Date: Wed, 24 Mar 2021 11:30:12 +0000 To: =?iso-8859-1?Q?J=FCrgen_Gro=DF?= Cc: xen-devel@lists.xenproject.org, Wei Liu Subject: Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface In-Reply-To: References: <20210324072645.10596-1-jgross@suse.com> <24667.7211.431280.743192@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jrgen Gro writes ("Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface"): > On 24.03.21 12:02, Ian Jackson wrote: > > Is it possible to do sort this out in a more minimal way ? Eg we > > could change the name to namespace it properly. (I haven't looked at > > the code in detail and am still rather under-caffeinated so maybe I am > > talking nonsense here.) > > No nonsense. This would be the really minimum option (apart from doing > nothing). > > I can setup the patch for that and keep the rest for 4.16 (which will > then probably need to bump the so version). Hmmm. Maybe it would be less disruptive to punt the whole lot for xen-next. That way we don't have a silent withdrawl in one release followed by a soname bump in the next. If you're keen to change this for 4.15, please feel free to show me what the patch looks like. But I would be inclined to postpone this. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 24 11:30:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 11:30:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100925.192594 (Exim 4.92) (envelope-from ) id 1lP1ij-0000ER-2F; Wed, 24 Mar 2021 11:30:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100925.192594; Wed, 24 Mar 2021 11:30:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1ii-0000EK-Vb; Wed, 24 Mar 2021 11:30:40 +0000 Received: by outflank-mailman (input) for mailman id 100925; Wed, 24 Mar 2021 11:30:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1ii-0000EC-13 for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 11:30:40 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 36245714-d718-4300-90cd-011627dd5428; Wed, 24 Mar 2021 11:30:38 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BCB7CAD38; Wed, 24 Mar 2021 11:30:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36245714-d718-4300-90cd-011627dd5428 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616585437; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=VyTpib7WnXRWcI3JhV+PM28m0yWeZRL8EroC8XOiql8=; b=s+SYVuBxBksYzoz5pZ6JK0T4UFbS7Jx4Eb6hDB4CKFoEz4lKg9ntMt2yFgfj249l9Q1hFM fnz0VWQBkYQlzY3m2hEPAgBkWZoqphBswFcH71J97e5CqQIs0XObnKyqvCycne9eryiCSi sXOMwJ5YTtrXyQSr6bRBKzqjyaeNzRc= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface Date: Wed, 24 Mar 2021 12:30:35 +0100 Message-Id: <20210324113035.32691-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xenstore_lib.h is in need to be tidied up a little bit: - the definition of struct xs_tdb_record_hdr shouldn't be here - some symbols are not namespaced correctly Signed-off-by: Juergen Gross --- V2: minimal variant (Ian Jackson) --- tools/include/xenstore_lib.h | 17 ++++------------- tools/libs/store/libxenstore.map | 6 +++--- tools/libs/store/xs.c | 12 ++++++------ tools/xenstore/utils.h | 11 +++++++++++ tools/xenstore/xenstore_client.c | 12 ++++++------ 5 files changed, 30 insertions(+), 28 deletions(-) diff --git a/tools/include/xenstore_lib.h b/tools/include/xenstore_lib.h index 4c9b6d1685..f74ad7024b 100644 --- a/tools/include/xenstore_lib.h +++ b/tools/include/xenstore_lib.h @@ -43,15 +43,6 @@ struct xs_permissions enum xs_perm_type perms; }; -/* Header of the node record in tdb. */ -struct xs_tdb_record_hdr { - uint64_t generation; - uint32_t num_perms; - uint32_t datalen; - uint32_t childlen; - struct xs_permissions perms[0]; -}; - /* Each 10 bits takes ~ 3 digits, plus one, plus one for nul terminator. */ #define MAX_STRLEN(x) ((sizeof(x) * CHAR_BIT + CHAR_BIT-1) / 10 * 3 + 2) @@ -78,18 +69,18 @@ bool xs_perm_to_string(const struct xs_permissions *perm, unsigned int xs_count_strings(const char *strings, unsigned int len); /* Sanitising (quoting) possibly-binary strings. */ -struct expanding_buffer { +struct xs_expanding_buffer { char *buf; int avail; }; /* Ensure that given expanding buffer has at least min_avail characters. */ -char *expanding_buffer_ensure(struct expanding_buffer *, int min_avail); +char *xs_expanding_buffer_ensure(struct xs_expanding_buffer *, int min_avail); /* sanitise_value() may return NULL if malloc fails. */ -char *sanitise_value(struct expanding_buffer *, const char *val, unsigned len); +char *xs_sanitise_value(struct xs_expanding_buffer *, const char *val, unsigned len); /* *out_len_r on entry is ignored; out must be at least strlen(in)+1 bytes. */ -void unsanitise_value(char *out, unsigned *out_len_r, const char *in); +void xs_unsanitise_value(char *out, unsigned *out_len_r, const char *in); #endif /* XENSTORE_LIB_H */ diff --git a/tools/libs/store/libxenstore.map b/tools/libs/store/libxenstore.map index 9854305a2c..fc1c213f13 100644 --- a/tools/libs/store/libxenstore.map +++ b/tools/libs/store/libxenstore.map @@ -42,8 +42,8 @@ VERS_3.0.3 { xs_strings_to_perms; xs_perm_to_string; xs_count_strings; - expanding_buffer_ensure; - sanitise_value; - unsanitise_value; + xs_expanding_buffer_ensure; + xs_sanitise_value; + xs_unsanitise_value; local: *; /* Do not expose anything by default */ }; diff --git a/tools/libs/store/xs.c b/tools/libs/store/xs.c index c91377c27f..109ea16d1e 100644 --- a/tools/libs/store/xs.c +++ b/tools/libs/store/xs.c @@ -1358,7 +1358,7 @@ static void *read_thread(void *arg) } #endif -char *expanding_buffer_ensure(struct expanding_buffer *ebuf, int min_avail) +char *xs_expanding_buffer_ensure(struct xs_expanding_buffer *ebuf, int min_avail) { int want; char *got; @@ -1379,8 +1379,8 @@ char *expanding_buffer_ensure(struct expanding_buffer *ebuf, int min_avail) return ebuf->buf; } -char *sanitise_value(struct expanding_buffer *ebuf, - const char *val, unsigned len) +char *xs_sanitise_value(struct xs_expanding_buffer *ebuf, + const char *val, unsigned len) { int used, remain, c; unsigned char *ip; @@ -1394,7 +1394,7 @@ char *sanitise_value(struct expanding_buffer *ebuf, used = 0; remain = len; - if (!expanding_buffer_ensure(ebuf, remain + 1)) + if (!xs_expanding_buffer_ensure(ebuf, remain + 1)) return NULL; while (remain-- > 0) { @@ -1405,7 +1405,7 @@ char *sanitise_value(struct expanding_buffer *ebuf, continue; } - if (!expanding_buffer_ensure(ebuf, used + remain + 5)) + if (!xs_expanding_buffer_ensure(ebuf, used + remain + 5)) /* for "\\nnn\0" */ return 0; @@ -1429,7 +1429,7 @@ char *sanitise_value(struct expanding_buffer *ebuf, #undef ADDF } -void unsanitise_value(char *out, unsigned *out_len_r, const char *in) +void xs_unsanitise_value(char *out, unsigned *out_len_r, const char *in) { const char *ip; char *op; diff --git a/tools/xenstore/utils.h b/tools/xenstore/utils.h index 87713a8e5d..9d012b97c1 100644 --- a/tools/xenstore/utils.h +++ b/tools/xenstore/utils.h @@ -7,6 +7,17 @@ #include +#include "xenstore_lib.h" + +/* Header of the node record in tdb. */ +struct xs_tdb_record_hdr { + uint64_t generation; + uint32_t num_perms; + uint32_t datalen; + uint32_t childlen; + struct xs_permissions perms[0]; +}; + /* Is A == B ? */ #define streq(a,b) (strcmp((a),(b)) == 0) diff --git a/tools/xenstore/xenstore_client.c b/tools/xenstore/xenstore_client.c index 8015bfe5be..3d9d399e91 100644 --- a/tools/xenstore/xenstore_client.c +++ b/tools/xenstore/xenstore_client.c @@ -40,7 +40,7 @@ enum mode { static char *output_buf = NULL; static int output_pos = 0; -static struct expanding_buffer ebuf; +static struct xs_expanding_buffer ebuf; static int output_size = 0; @@ -203,11 +203,11 @@ static void do_ls(struct xs_handle *h, char *path, int cur_depth, int show_perms if (max_width < (linewid + len + TAG_LEN)) { printf(" = \"%.*s\\...\"", (int)(max_width - TAG_LEN - linewid), - sanitise_value(&ebuf, val, len)); + xs_sanitise_value(&ebuf, val, len)); } else { linewid += printf(" = \"%s\"", - sanitise_value(&ebuf, val, len)); + xs_sanitise_value(&ebuf, val, len)); if (show_perms) { putchar(' '); for (linewid++; @@ -346,7 +346,7 @@ perform(enum mode mode, int optind, int argc, char **argv, struct xs_handle *xsh if (raw) output_raw(val, len); else - output("%s\n", sanitise_value(&ebuf, val, len)); + output("%s\n", xs_sanitise_value(&ebuf, val, len)); free(val); optind++; break; @@ -359,8 +359,8 @@ perform(enum mode mode, int optind, int argc, char **argv, struct xs_handle *xsh val = val_spec; len = strlen(val_spec); } else { - expanding_buffer_ensure(&ebuf, strlen(val_spec)+1); - unsanitise_value(ebuf.buf, &len, val_spec); + xs_expanding_buffer_ensure(&ebuf, strlen(val_spec)+1); + xs_unsanitise_value(ebuf.buf, &len, val_spec); val = ebuf.buf; } if (!xs_write(xsh, xth, argv[optind], val, len)) { -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 11:32:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 11:32:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100929.192607 (Exim 4.92) (envelope-from ) id 1lP1kj-0000OV-Ff; Wed, 24 Mar 2021 11:32:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100929.192607; Wed, 24 Mar 2021 11:32:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1kj-0000OO-CO; Wed, 24 Mar 2021 11:32:45 +0000 Received: by outflank-mailman (input) for mailman id 100929; Wed, 24 Mar 2021 11:32:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1kh-0000OI-NO for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 11:32:43 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2ba726a5-1290-42ca-a246-74719b2aaaa7; Wed, 24 Mar 2021 11:32:43 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4DD92AD38; Wed, 24 Mar 2021 11:32:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ba726a5-1290-42ca-a246-74719b2aaaa7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616585562; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DPp9Q5DWrtC2aDxiHJOr40tP4y1H6Oj1MqHWCDZ3Ldk=; b=iGkI5RmgiKLbuRwEa0exi2ASgRwjP4CZ+YhvZWQaKP3C/gYEBU9bHQ6xZ7DZ/p178cJgoG Mq29FUPY/ior7FhEDN5QcXLR0FB4i7XDjnbV7IXVZHxGM5A1W4c02rjJQPepWLsCy4M9KA tDuWEzXjBo8mHmR9DfS5xzCfsTk/4AI= Subject: Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface To: Ian Jackson Cc: xen-devel@lists.xenproject.org, Wei Liu References: <20210324072645.10596-1-jgross@suse.com> <24667.7211.431280.743192@mariner.uk.xensource.com> <24667.8900.993418.152255@mariner.uk.xensource.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <2ccb24a7-a927-cfe7-f102-b8ef02052522@suse.com> Date: Wed, 24 Mar 2021 12:32:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24667.8900.993418.152255@mariner.uk.xensource.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="J7MMgfD5echwzdA6ES78JWiAyCKyvqs3u" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --J7MMgfD5echwzdA6ES78JWiAyCKyvqs3u Content-Type: multipart/mixed; boundary="gjfW9Vut9XwlHaIsURM2sL7Ut1B8MV9Ag"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Ian Jackson Cc: xen-devel@lists.xenproject.org, Wei Liu Message-ID: <2ccb24a7-a927-cfe7-f102-b8ef02052522@suse.com> Subject: Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface References: <20210324072645.10596-1-jgross@suse.com> <24667.7211.431280.743192@mariner.uk.xensource.com> <24667.8900.993418.152255@mariner.uk.xensource.com> In-Reply-To: <24667.8900.993418.152255@mariner.uk.xensource.com> --gjfW9Vut9XwlHaIsURM2sL7Ut1B8MV9Ag Content-Type: multipart/mixed; boundary="------------BBE6C4F0BBA2788D920BABBE" Content-Language: en-US This is a multi-part message in MIME format. --------------BBE6C4F0BBA2788D920BABBE Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 24.03.21 12:30, Ian Jackson wrote: > J=C3=BCrgen Gro=C3=9F writes ("Re: [PATCH-for-4.15] tools/libs/store: c= leanup libxenstore interface"): >> On 24.03.21 12:02, Ian Jackson wrote: >>> Is it possible to do sort this out in a more minimal way ? Eg we >>> could change the name to namespace it properly. (I haven't looked at= >>> the code in detail and am still rather under-caffeinated so maybe I a= m >>> talking nonsense here.) >> >> No nonsense. This would be the really minimum option (apart from doing= >> nothing). >> >> I can setup the patch for that and keep the rest for 4.16 (which will >> then probably need to bump the so version). >=20 > Hmmm. Maybe it would be less disruptive to punt the whole lot for > xen-next. That way we don't have a silent withdrawl in one release > followed by a soname bump in the next. >=20 > If you're keen to change this for 4.15, please feel free to show me > what the patch looks like. But I would be inclined to postpone this. Minimal variant sent. I'm not keen to have that for 4.15, but the patch was just ready. :-) Juergen --------------BBE6C4F0BBA2788D920BABBE Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------BBE6C4F0BBA2788D920BABBE-- --gjfW9Vut9XwlHaIsURM2sL7Ut1B8MV9Ag-- --J7MMgfD5echwzdA6ES78JWiAyCKyvqs3u Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBbI1kFAwAAAAAACgkQsN6d1ii/Ey8O Hgf/RHTQWG3vjbwzG8uNNTUQIV0QO71ZGZ8Y8159WpCeawEDtOkzESISzeQiSmClrvAXVjWIo6Mr /3EweTM+RwPVqYgoZSRZvjXgDUek91Q0T+dwOH3GhdggxTkb+5L3gnAVsHf4R+5HB6W1p6ZTPdQX txe90ywhWgksQ06KqBmYMsqJoM2z5M1ToUtsltorvgtasFM2IVOH3av6R+2U8uBwJhPDddh/NnzD e4IwZykTtn/XT2dUW2BQEIozjsyUX1DcQW7hbulzTH02xZRyW3r7aroFslT6thGxrEdqx4nxPjap Js5O5E6sFxIHIzavVp2qyeQq7+UnVsKGu2EHJ+8ikQ== =8gPu -----END PGP SIGNATURE----- --J7MMgfD5echwzdA6ES78JWiAyCKyvqs3u-- From xen-devel-bounces@lists.xenproject.org Wed Mar 24 11:38:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 11:38:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100935.192619 (Exim 4.92) (envelope-from ) id 1lP1pm-0000iq-8T; Wed, 24 Mar 2021 11:37:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100935.192619; Wed, 24 Mar 2021 11:37:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1pm-0000ij-5Q; Wed, 24 Mar 2021 11:37:58 +0000 Received: by outflank-mailman (input) for mailman id 100935; Wed, 24 Mar 2021 11:37:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1pk-0000ie-Lp for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 11:37:56 +0000 Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c0606f48-fe42-4d1b-8b4d-9b0f5e9c6f1c; Wed, 24 Mar 2021 11:37:55 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id e18so24100831wrt.6 for ; Wed, 24 Mar 2021 04:37:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0606f48-fe42-4d1b-8b4d-9b0f5e9c6f1c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Kti/az/G7mGfRM42R9lRXMllvlbHuv7YlHrsDqHzcM4=; b=bUl1S8/drWjL5pFLYRDnQj6+qMS0c2FeaChoK4JNRMdBjW1kuJN3p29f4rWFh4kRar EpAwAUjIY/AbzMNLppBmxzNUDS1cMdy6pD6ibFMuyjmPlOW7EHCb86v9ZxlY/stJ/+2b LdKAqovF4SDZcl+0BFWvfW5+FyrbKVMPeCBcmce0dVryjkotCqzQsJ7LatHZfcGexh2y iqhj0U918RttkwWqozTIhuUlPs3fJMEwA8XD8GdZRg3yOMv1QIb61BKKCvOkRZrULJuW H3eUWqvZSeSI3kAS9namxtywVU1y3+kpA78vknxwVKE1Il0L1PWZ1mT3P5NEs6jTDCfR JFQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kti/az/G7mGfRM42R9lRXMllvlbHuv7YlHrsDqHzcM4=; b=G3zqzPXi5bXZbEycSS5bXuMMQ+Qe7f6CUAfKv3UjTqTDTBJP8fwszleyo8Hos9kwc1 Z9vEhwemf/a8OM3nujU4oRy8MQo+3h67PqHxabphoyqZHVCoHVFFhx7PMw8CKjjXr0cF NPw99GIPYoWaALmvm+2Ci8ZyTd5Fz0aa9WCmWFa2nDfE/m/GNbKuALhVSIiGucd9l8pa XN+KQBnZV1qjga4H2X5trcv+e8G+rOh4wJ4uQG3lCgd3G7JUEBre6Y7+ISXtuFWLRN6G L/G+H7Cd1rXkjLAjj2aS818/JYBiIOWICrsDbSIP3wlsHKvb+qsC/v7Pi6Ph3H4seDI0 qVxw== X-Gm-Message-State: AOAM531KXfPi5Jxs/Vs/sSrqYJL7WG/QW9wWri4BM0Z5saAN4Vi9h9AZ yJqXDtmMmkYMemKdT7DCprJaocSkF2vBTYraRlg= X-Google-Smtp-Source: ABdhPJwuvJq9azJS17G+zoUqtwDLTpDVSKIlk+FTyM6ZV8MKsrbaExmVHAk0qC0j9MFjhaQmT+gNEF53CsqeehOAIOY= X-Received: by 2002:adf:83c2:: with SMTP id 60mr2979735wre.386.1616585875000; Wed, 24 Mar 2021 04:37:55 -0700 (PDT) MIME-Version: 1.0 References: <8e18a2a5-bc19-615d-0c8c-cea49adcf976@suse.com> In-Reply-To: <8e18a2a5-bc19-615d-0c8c-cea49adcf976@suse.com> From: Tamas K Lengyel Date: Wed, 24 Mar 2021 07:37:18 -0400 Message-ID: Subject: Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Ian Jackson Content-Type: text/plain; charset="UTF-8" On Wed, Mar 24, 2021 at 6:34 AM Jan Beulich wrote: > > Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC > static PIT clock gating") was reported to cause boot failures on certain > AMD Ryzen systems. Until we can figure out what the actual issue there > is, skip this new part of HPET setup by default. Introduce a "hpet" > command line option to allow enabling this on hardware where it's really > needed for Xen to boot successfully (i.e. where the PIT doesn't drive > the timer interrupt). > > Since it makes little sense to introduce just "hpet=legacy-replacement", > also allow for a boolean argument as well as "broadcast" to replace the > separate "hpetbroadcast" option. While having the command line option to control it is fine what would really be the best solution is if Xen could figure out when the legacy-replacement option is necessary to begin with and enable it on its own, even if it's done as a fallback route. We'll have issues with telling users when the option is needed and when it isn't. I don't like the idea of users having to go through a route of "well, let's see if Xen boots and if you get this weird crash/reboot add this obscure boot option". It's just a bad user experience all around. Tamas From xen-devel-bounces@lists.xenproject.org Wed Mar 24 11:43:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 11:43:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100938.192631 (Exim 4.92) (envelope-from ) id 1lP1uc-0001aU-SG; Wed, 24 Mar 2021 11:42:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100938.192631; Wed, 24 Mar 2021 11:42:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1uc-0001aN-Oa; Wed, 24 Mar 2021 11:42:58 +0000 Received: by outflank-mailman (input) for mailman id 100938; Wed, 24 Mar 2021 11:42:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1ub-0001aI-Q1 for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 11:42:57 +0000 Received: from MTA-05-3.privateemail.com (unknown [68.65.122.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 53083611-c958-4e67-851d-c8374f147b20; Wed, 24 Mar 2021 11:42:57 +0000 (UTC) Received: from MTA-05.privateemail.com (localhost [127.0.0.1]) by MTA-05.privateemail.com (Postfix) with ESMTP id 2D8B86005F for ; Wed, 24 Mar 2021 07:42:56 -0400 (EDT) Received: from mail-wr1-f42.google.com (unknown [10.20.151.215]) by MTA-05.privateemail.com (Postfix) with ESMTPA id ECE9860058 for ; Wed, 24 Mar 2021 07:42:55 -0400 (EDT) Received: by mail-wr1-f42.google.com with SMTP id j7so24123965wrd.1 for ; Wed, 24 Mar 2021 04:42:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53083611-c958-4e67-851d-c8374f147b20 X-Gm-Message-State: AOAM531E3+iYvDIuUPEeApGJYgBTy/mpBSw4zJFKdXvVhrkYXCWPlNOJ LxAF5mP/3y1cI+v4c9415jaJnJmhP80RPnHtRfQ= X-Google-Smtp-Source: ABdhPJwmcjTQ2IItsyJxtG7jbpB33mUpmdoARAhY1lzctN4vFfz7XsQZ+97CkgqdBEWrsIwlf6f5DREvMFYmSebK6ys= X-Received: by 2002:adf:efc7:: with SMTP id i7mr3004236wrp.182.1616586174664; Wed, 24 Mar 2021 04:42:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tamas K Lengyel Date: Wed, 24 Mar 2021 07:42:18 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking To: Ian Jackson Cc: Xen-devel , Tamas K Lengyel , Jan Beulich , Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP > > When creating a VM fork copy the parent VM's hostp2m max_mapped_pfn value. Some > > toolstack relies on the XENMEM_maximum_gpfn value to establish the maximum > > addressable physical memory in the VM and for forks that have not yet been > > unpaused that value is not going to reflect the correct max gpfn that's > > possible to populate into the p2m. This patch fixes the issue. > > > > Signed-off-by: Tamas K Lengyel > > --- > > xen/arch/x86/mm/mem_sharing.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c > > index 00ada05c10..98b14f7b0a 100644 > > --- a/xen/arch/x86/mm/mem_sharing.c > > +++ b/xen/arch/x86/mm/mem_sharing.c > > @@ -1761,6 +1761,7 @@ static int copy_settings(struct domain *cd, struct domain *d) > > return rc; > > > > copy_tsc(cd, d); > > + p2m_get_hostp2m(cd)->max_mapped_pfn = p2m_get_hostp2m(d)->max_mapped_pfn; > > > > return rc; > > } > > -- > > 2.25.1 > > > > CC-ing Ian as 4.15 release manager. This patch is safe to include in > 4.15 as it's a minor fix in a tech preview feature that's not even > compiled by default. Patch ping just to not forget that I would like this included in the 4.15 release. Thanks, Tamas From xen-devel-bounces@lists.xenproject.org Wed Mar 24 11:43:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 11:43:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100939.192642 (Exim 4.92) (envelope-from ) id 1lP1uh-0001cI-3p; Wed, 24 Mar 2021 11:43:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100939.192642; Wed, 24 Mar 2021 11:43:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1uh-0001cA-0f; Wed, 24 Mar 2021 11:43:03 +0000 Received: by outflank-mailman (input) for mailman id 100939; Wed, 24 Mar 2021 11:43:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP1uf-0001bk-CL for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 11:43:01 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 62fdcfb8-007a-45b0-a975-3c300bf6f149; Wed, 24 Mar 2021 11:42:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62fdcfb8-007a-45b0-a975-3c300bf6f149 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616586179; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=iTj7N4pHuE2hgcgKYc+FQbdTmxFmFJV05gHlobsYi+0=; b=KnlqJkkp1b+9H6t0pJ1sUdjlRH6XZBOxvstilIf2OtXsJJ3bI6NHDMwf UKiEgSHa4Wh9XArrh3hEO14K2nzfJd4EE5EECRBsqqiuOqjMtpJIy/O3D REwvaTspB0JX01ez2fPOJH3S156P3wHOwMMUEuUYe2JAshff/C+IHN27e w=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: xm8KVo4MB8Sx3+daxYp6XgfvZ+ispejru2YQuMCnk6PvQ++HQsCnkoEJKkeurAKvgUBSgPtL9B 2i9Si85tucmSYaXXksLtYeYluKfYNtl2P9VcXro5phBYAcYgfBj4cnqdCg2wCMxwnwvuEU97Ue JA67Gz3t0oflwD6vismM7G3xG8syXOgRSHdqej8egsr2y+7ZSSYO+csDmSFnAa4UDNyjAfBgCU yoqjR6t+6XZ8hqSXYdqWeK5nOq8SJRnqpuoNGVWabw1n8ZEJRYOPllWNkVLnPZB1+HqRRIgc55 0iQ= X-SBRS: 5.2 X-MesageID: 41445545 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:FKPoRq012CbDQSChREYnmgqjBTt3eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/FIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFmtJ1/Z xLN5JzANiYNzVHpO7n/Qi1FMshytGb8KauwdzT1WtpUBsCUcBdxi1SYzzrd3Febg9AGJY/Cd 647s1IuzKvdR0sH7uGL1MCWPXOoMCOqYnvZgQICwVixA6Fiz6p77CSKWnl4j41VTRTzbA+tV XUigCR3NTfj9iX6D/5k1XS4ZNfhcf7xrJ4avCkp8AJJlzX+36VTat7XbnqhkFTnMiO7xIQnM DIs1McOa1ImgnsV0WUhTeo5AX6yjYp7BbZuCylqF/uu9bwSj5/K+cpv/MhTjLj50AtvM5x3c twtgrz3fonbmK0oA3H69fFTB1snEavyEBS9dI7tHBDTZAYLIZYsI13xjIkLL47ACn45Io7ed Meav302fA+SyL5U1nkpGV1hPSjUnMvdy32OXQqi4i+1jhbm21B1E0IxMATtWdozuNNd7B0o8 vDKahmj7dIU4s/ar98Hv4IRY+NBnXKWg+kChPfHX3XUIU8f17doZ/+57s4oMmsZZwz1ZM33L DMSklRu2Iec1/nYPf+k6Fjw1ToeiGQTD7twsZR69xSobvnXofmNiWFVRQHj9agi+93OLyaZ9 +DfLZtR9PzJ2rnHohEmyfkXYNJFHUYWMoJ/v4mRlO1pN7RIIGCjJ2bTN/jYJ7WVRo0UGL2BX UOGBLpIt9b00ytUnjkxDfLXXfAfVH+4IJQHKDW8/N78vlOCqR89iwuzXip7MCCLjNP9oYsel FlHb/hmqSn4Um6lFy4qllBC154NAJ48b/gW3RFqUshKEXva4sOvN2ZZCR31HuDLRlvctPOHG dk1hBK0JPyC6bV6TEpCtqhPG7fpWAUvmi2Q5AVnbDGwsv5ZJUiDNIDVLZqHQvGUzx58Dwa5l trWUshfAvyBznugaKqgNg/H+fEbeRxhw+tPIpzsnLQtUKVoOk1XXsFVzuSUcqa6DxeBAZ8tx lUyesykbCAkTGgJS8Um+IjKmBBb2yRHfZ7FgifXZ5VnbrqYQl0am+PiVWh+lYOU1uv039Xqn 3qLCWSd/2OJlZGoHhX3pzn905OenyHc1h9bW17toNBBX3L00wDo9OjV+6W6S+8e1ECyuYSPH X+bTweLhhH6vq32BSW8QzyXkkO99ELBKjwHb4je7bc1jeRM4WOj7gBBOIR1o1iLsrSvugCVv +/dweZICjjMf4g3xWYqx8eSW9JgUhhtcmt/hLr7GK1hiFiRdXTJUlrXLEdLZW36XP+S/OBzZ V+ipYUsIKLQxLMQ+/D7ZuSSThJbi73iyqRacoDrJhPp6I8tLdpBfDgIHP1/UAC+C97Fdv+kU MVfb9y77/AMLJ+ZsB6QVMswnMZ0PC0aHYxugP4AuUCbUggon/SMdSO+afJo9MUczu8jTq1HV mU6CtG+fjZGwOFyL4BEqo1SF4mInQU2TBH/OmYcZfXBxjvX+Zf/ECiOnv4VLNGUqCKFfExqR l9iuv40tO/Rm7d2ArKuyF8Lb8L22G7QdmqCAbJINV2ybWBSB2xq5rvxtWygjfxQSa6bEpdpb QtTz1vUu1zzh84jIM21SCuTLfQuUxNqSoG3Q1a X-IronPort-AV: E=Sophos;i="5.81,274,1610427600"; d="scan'208";a="41445545" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XUBSzl8nJ1glbG1xdkEmyJCktEUo979yBQrpaGYCHl1RK8ePhsuZigtTG0KCWp8e9QU7z7b6jgnwfCOBXJCvlq1htubZWdSqLexnpBulcycFoSQQYBSzxhwZYTVMRH+DQxLmsQTM4mfZUdCDkqQ3A9ffOk3mZqaVDtsVM7z/PJl1dhLwDbpulszVlcfc0AMYiNd540kH736k/qp6RCgZcXWKZgQq0NFQrdg4R8rAJ0RpQ7gWFDGeriubzlUWP4C8vFdG3O4Q8kZg7p6C7tmLvvahAjdg39SbK9diXmrwP+r2ZydCgW8G1PaiePUcBUKs4ZYlOsYApBYZ5O7mhHVvlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JKd9B4wxj3mHQdzJbIbkPAbgWlz5P5GDOl309bUAC5E=; b=SovTRgd1xrU+4yyjPPsSQ6g8rob/3fKl3G/Wailhxt7cZiNy7WnLhH/lWcXUVHBiTks+fxe1i4lrPAwq015bIwCzsbUXWW0GMTu0nAZYOvBFUDKzL8HLUOACR68jISV1anFm+CkvHinLRWCsl8FYYYls4HyXHscno9luUoRfXphHAcZkHoPpHwmU9O80Bhvk/NCspeqbrXTZM6kOZhWl4PZBHxDvJxft8p+rBqGUejgB5giTBurO9Lwwm1inVMvmmMTlZb9qWoCF4GEM+8PdPL/WroQi7YC7XQ+wrOfqCLhzDTggmttBD6sLkCTh4eeRl+BLUUqu2fwXzXis5VtC/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JKd9B4wxj3mHQdzJbIbkPAbgWlz5P5GDOl309bUAC5E=; b=pZrlMvPNR//cfrel2GadBhifzL1vNfSZ7YHy6psfYLMbYEdywt+sHnMDXEpP+HJzuXkHrDHdsFketlxjrX3ftVuqK/lfYUvPU75yHXxNn3V3bbyiMz6hku54Ln+eaJxoHojcbxDDAsuPp0Q491CBkJWEdw0bPzkg6rbL5z+cm2M= To: Juergen Gross , CC: Ian Jackson , Wei Liu References: <20210324113035.32691-1-jgross@suse.com> From: Andrew Cooper Subject: Re: [PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface Message-ID: <5c051a69-44fb-f878-98da-9d6773cca72d@citrix.com> Date: Wed, 24 Mar 2021 11:42:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210324113035.32691-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0073.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::6) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ae6411e2-2cac-48e6-63b6-08d8eeb9f706 X-MS-TrafficTypeDiagnostic: BN6PR03MB2417: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b4qBOuvQOLw1eVLmSUgLTvkl/0nPP2w/qVdz653Oq5wjd5QbMueVIR8vmQYkx7OXtxv3dTGNrmeRHxLOrBm5FRddTO6pDCeyr1HRIMkN1c08akRjAXCLuKt0Nmf2N6dUzm4q0Go9EkBQzxKwJ3bakcirch/1T9I4nsptqdHC8f4MHQZvguGPJzRzNsJKxUbq11HN33GBE5bOKRnlPVN9JQ0grl1bhZCmnf7k5czkQ9np0/O2sX1yrj276E3HnEkvDY6svH9XuqvcOp5QLvvAam4WSszPIjVG72QYK1801AJykgzWnfDDTIa9h1o3dolKDiV9kP8dDhZHi9zKRNbynF7KgMvKHtEZ0tARMDhP0G8VhTQwDcSSyE/LkeLP4WfAolpqVYQng2uneLlj3ed9aCQnKxI0P5uLSW17LmlLvN3578GFcAQB7v+Xid82b6dNITCfMCM+pJG1o+T1FNQgdxDFp0ZAkEQSpjr3RwC6YmMNppYBWnlsp02zYiYmXTh8aMWZePRuRgCnjPHQWyKTpRBBPuX+JhRWXhU8l0IiUv7UuAmahl+zWa20os+7oEL0qbbHXNF+mdXJpCFyVqs/e2CE19J9VWpaVstZpo61LIM7pesm8QzybKKKoKeL0ZhCzzKSU7o7Fp5FYdyzLjMtmnoNGzV7JCTcMWP1lArwhoWZE8XAWVWilkarvdCUwgqm3sAOxczC+BHNEeiVgb3kZUnij4X0MBKrZ5zW/IG7Kgs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(366004)(396003)(346002)(136003)(53546011)(38100700001)(66556008)(6486002)(86362001)(2906002)(478600001)(66476007)(956004)(31686004)(54906003)(8936002)(5660300002)(316002)(16576012)(8676002)(26005)(4326008)(31696002)(36756003)(66946007)(83380400001)(16526019)(2616005)(6666004)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MjBGZTJ4WUpYc2VjNjNzUzN6d0FzSWtobnRCNTdHWGlQSXcxcFNHL1VVTXpx?= =?utf-8?B?dmpUODkyWGdhTks0SkgzcEJVMlltRmQyTWdrT0NmN2MxempMcUJjMTk5cWRG?= =?utf-8?B?dTRwMFAxbEpDa2Npdi9LTUFIbWVpQnZ2UWtBMWQwcnptNVZ2Y2x2SnNEMnRy?= =?utf-8?B?MHFkbFBSSmF1c2Q1TEN2U1lDWUlOd1BMWklxQjJLRnZJaFRtUHI0aHMwbUZv?= =?utf-8?B?TUF0bFRDNDlra2FwTTlmcjZ1ME1STlA2alRnNHNCdjN4eTZYRW4zeVlvNW1u?= =?utf-8?B?VGpicUFCSDBjcTNXbnV2aENpTTNWSmZyOUxzTlRvemFadFVCVTJTT21OaCtJ?= =?utf-8?B?R0dXZHFkS3hwRXBMTWZsNEJ1YUUvQlNubnhjRStqMkFDbXE0bU93STU0TllY?= =?utf-8?B?ZjE4SktmeVhVMDV2QjFqTkJmU1BoT3ZBajY1eUtIbnFRR2lDL05WNDN5MlNo?= =?utf-8?B?K3F1MVF6cjdlSjVGcGhmNnJDSDV0cm1SWXh6ZXk3MnBNb0pmOUdXM2lldzNF?= =?utf-8?B?dStsR0xJa0t5K3FNN2cyOUQ0NHVmWXJmT1F6NmFFRDk2ZjdYQkl0MkQyLzJ2?= =?utf-8?B?NWpvUncyUnZsaTgrZXZyUEJkd2hucWJCNlJ3Z2ZITldoNXM2N0Q0c2dVdU90?= =?utf-8?B?aG5QMHZwNXdxYlVYdTdaYlZYMVVsbGNDRkF1bDdpQS94WHNaWTM4UGE0cldN?= =?utf-8?B?TnhZOW02ZHNBNG5jQXpuMXJaU0pJbzdvZFNwM0lydVFOeDFIem4xUHdJREhK?= =?utf-8?B?WDB3dGEzQVJBcktjalVYamJqVmRsRWRrSGUwNmoxcXVpZlVBcWNkaGd1ZFNU?= =?utf-8?B?azNuYkVOdkh2V2UyaG9oK21QeDRVckRZb01aVlpJV2l2dnlYQ0VyRHpyUDdE?= =?utf-8?B?UUxVRWV6RG5Pd01OUDhSNFlGNzFnUWtyL1pPdFRSOVlUdmN0YzYzck9wT1lU?= =?utf-8?B?dnBROEIxR0k3Q3lyeEw4a0hvNlJDdmZrcjFxRTUySGpRcVJyaG1FUlU1cU9z?= =?utf-8?B?dEF0dmM3UllHc2c0SHdtY1BlN2xwYnd2QmRIUTBRQ1FMN2JNamw0bnM3YUl2?= =?utf-8?B?N01YdGZQRytYSXo5TmZsWXp1VDdaSmJFcGdZMTgzS2tqRkUwNGp0bFlBdElB?= =?utf-8?B?OWlxa2Qwa016WHNqWlZJMEN0ZWpCNTdaeDc1TVhhZjFZYjN6OWJOa2JJdHV2?= =?utf-8?B?L0VmTEgydWZRdTlCMVdoR0RWeVFEVXAzTVdNeUNaclhJQkJKQyt3VWkyQ3FE?= =?utf-8?B?Z3gvRHVyeFROVTZDYXgxb3BnS0tXRFF1Y3F1eStJaUxNNjFKNCttcGVWcmJp?= =?utf-8?B?V01IN0RxS2RHREd3QllaWkFxdHp1K1B4S2NjYWxuL25tWFNRVVBNZ3l5cm9J?= =?utf-8?B?czJ5aWkzRWtDYk5QWTlpN0VMcDErYWM3N1NlWjFnUWRLOWVETG1TNGs1NmM2?= =?utf-8?B?WCtzQjZmWURTYnpEanljRVZjcGVTalYrL2lmMktFVFAwVXVqRGYrb3k1TExi?= =?utf-8?B?ZUMrc2VySVNjbFlJNHhEazRGWVlJUjhhSTRvQkhnNjc3OWJ0TEh1OS9yV1Az?= =?utf-8?B?SzBCNHBZbjNQVjdRNGFVVVg4MmVPTkpmTWc5MFpWZ1BqVXc0QWwzdWpFTzNO?= =?utf-8?B?TmEraEhhSmhZZFdZL08vZGg3c09XRjkrV1d2bkxpYlgrVEhORGEzVytVenFX?= =?utf-8?B?UG93ZTg1NXptdTl0WWd4TFVTUWVIYUZxMngveTNuTGNnT3czeDhwdCtJNnIv?= =?utf-8?Q?l0yUSbO7QKzNDvVjDwgXTpLy2E0WCloLeQrJFfi?= X-MS-Exchange-CrossTenant-Network-Message-Id: ae6411e2-2cac-48e6-63b6-08d8eeb9f706 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 11:42:55.5685 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F5wvqhQt49DFPjcXTBmDCfQkvjPszRt2dVdLnKpt0miNJPNBF0jwSWE20KT2Smx8J40sW6G/UcqUhBeFulJE7eESgoonWrmmAxA7ZEiuu5c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2417 X-OriginatorOrg: citrix.com On 24/03/2021 11:30, Juergen Gross wrote: > xenstore_lib.h is in need to be tidied up a little bit: > > - the definition of struct xs_tdb_record_hdr shouldn't be here > - some symbols are not namespaced correctly > > Signed-off-by: Juergen Gross > --- > V2: minimal variant (Ian Jackson) > --- > tools/include/xenstore_lib.h | 17 ++++------------- > tools/libs/store/libxenstore.map | 6 +++--- > tools/libs/store/xs.c | 12 ++++++------ > tools/xenstore/utils.h | 11 +++++++++++ > tools/xenstore/xenstore_client.c | 12 ++++++------ > 5 files changed, 30 insertions(+), 28 deletions(-) > > diff --git a/tools/include/xenstore_lib.h b/tools/include/xenstore_lib.h > index 4c9b6d1685..f74ad7024b 100644 > --- a/tools/include/xenstore_lib.h > +++ b/tools/include/xenstore_lib.h > @@ -43,15 +43,6 @@ struct xs_permissions > enum xs_perm_type perms; ^ This enum is still a ABI problem, as it has implementation defined size.=C2=A0 The containing struct is used by xs_perm_to_string(). Substituting for int is probably the easiest option, because no amount of trickery with the enum values themselves can prevent the compiler deciding to use a long or larger for the object. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Mar 24 11:49:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 11:49:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100944.192654 (Exim 4.92) (envelope-from ) id 1lP20x-00021N-Rm; Wed, 24 Mar 2021 11:49:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100944.192654; Wed, 24 Mar 2021 11:49:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP20x-00021G-Op; Wed, 24 Mar 2021 11:49:31 +0000 Received: by outflank-mailman (input) for mailman id 100944; Wed, 24 Mar 2021 11:49:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP20w-00021B-2E for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 11:49:30 +0000 Received: from mail-wr1-x42c.google.com (unknown [2a00:1450:4864:20::42c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 16c4f459-4f9a-4fce-b976-f12810c3916d; Wed, 24 Mar 2021 11:49:29 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id v4so24122463wrp.13 for ; Wed, 24 Mar 2021 04:49:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16c4f459-4f9a-4fce-b976-f12810c3916d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YXTahJMGLOD9FEDfVzNB8fy+yQssNFsetfwKdnzBFYA=; b=aEy6Z+U1vyGCKV0e164NAlfWTSgjE5XCnWz3+9J03orT/8t35AIDR7yQDrRjmMQBtb kEL34aLsyKssYe5xj60toSJjtnDHYieLKg3rODQfDDVRBf8KyKRdPZ0u+tUkkM0kCBxv D17BN65m95b1PP9nX0xucR9Y9FbXLz4Jgx/MwIXaJEyxJ2rrpcHhZNmS5pVQigD3aa0I MIQgPqAgZ6nE0Uk4cUceNAjuLLqygNJWHK7/n4f9wwOmCIFq8m771GIdTQcWdTmxkQ9D gbH3+QbPVWEE0ZCbeQAjowdglOkrQwk2ReHkndRM6YbQRYZb7liZddohr2AFUxI7/Kp7 qfXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YXTahJMGLOD9FEDfVzNB8fy+yQssNFsetfwKdnzBFYA=; b=lyJcWQzyk1nCLMYICyYx+eXj+ppy5XMgDm5Xtkzrnx4nHzT6sW4BKFel3bYi2flN0P QZm6nO89f2xKZ+/0nclQzujxG7u7G0aYpaq7yEFV4Vo5kB6KlFMktELVSneznfty1MmN Ok6vUIkFupILiAHZ+I6h1fera/PiEFDpHzyj8J7k3CLRsttBXrWuaxy70PJUQnvcqLbZ vQg04hqac9oc/8xknOC9pHZLGnke468dUSWmTc8amIKpqdQ5Ybg/JXdKnWetaU01BQaG kKbilv4IrjoEKc1SAXzFUuHM+HSr2NjqwZddjOnENCWJD+22aaYBwTqMI1LJJqwX8mmf ErVg== X-Gm-Message-State: AOAM530hj/XNZoGxuzEX6uFIlAe+2M9Ie3uYUThIUnmh8zdJ6S1q/0l8 7S2LoEwRZnxnvAydoY8E5iD8xxN65BIQ5dK2AZE= X-Google-Smtp-Source: ABdhPJz+O1KszciQBfoh3kAH783BZz2Yyxr84vRIJLCd384JALdXGznmjm5OAQcw9AiZxxLjQ5QzuehrjMmktgJJFNI= X-Received: by 2002:adf:efc7:: with SMTP id i7mr3031114wrp.182.1616586568382; Wed, 24 Mar 2021 04:49:28 -0700 (PDT) MIME-Version: 1.0 References: <24666.1682.595069.435575@mariner.uk.xensource.com> <0bfab829-3841-b2cd-96f9-874340cf75c2@suse.com> <24666.7414.232768.961456@mariner.uk.xensource.com> <24666.8820.146895.73948@mariner.uk.xensource.com> In-Reply-To: <24666.8820.146895.73948@mariner.uk.xensource.com> From: Tamas K Lengyel Date: Wed, 24 Mar 2021 07:48:51 -0400 Message-ID: Subject: Re: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow To: Ian Jackson Cc: Jan Beulich , Xen-devel , community.manager@xenproject.org, Andrew Cooper , Committers , Wei Liu , Juergen Gross , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= Content-Type: text/plain; charset="UTF-8" > The revert seems unattractive. Your suggested command line option > sounds like a good workaround to me. Under the circumstances it seems > like it should default to the old behaviour, as I think you are > suggesting. > > So I am be inclined to ask if you, Jan, would prepare a patch > implementing such an option. Anyone else have any opinions ? I've replied to Jan's patch as well. IMHO having the option but leaving things broken without the option set is a bad user experience as we don't have a way to tell the user when the option is needing to be set during install. Asking users to see if Xen crashes during boot is a bad user experience as part of the setup. There should be an automatic fallback to try enabling the legacy option if things don't work without it. Tamas From xen-devel-bounces@lists.xenproject.org Wed Mar 24 11:55:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 11:55:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100947.192667 (Exim 4.92) (envelope-from ) id 1lP26t-0002sl-I9; Wed, 24 Mar 2021 11:55:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100947.192667; Wed, 24 Mar 2021 11:55:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP26t-0002se-EU; Wed, 24 Mar 2021 11:55:39 +0000 Received: by outflank-mailman (input) for mailman id 100947; Wed, 24 Mar 2021 11:55:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP26t-0002sZ-0W for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 11:55:39 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7a521f19-259f-4848-8598-fdcd0b24db43; Wed, 24 Mar 2021 11:55:37 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EF2B5AD38; Wed, 24 Mar 2021 11:55:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a521f19-259f-4848-8598-fdcd0b24db43 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616586937; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XVCENo0/FbkKnamlZMpxMheXxCclzmuJ5I9EC54P5Dk=; b=rJMQxfvuwypdfTPzV5aYzMmS0Wrl5Of2R3s2KOfNv2I2AmtGTKSv0azO80MLFudpjraPyU As3zHx6bUX3FtJ5P6ukhB3a1eoCQ4bYp4/4tLMjSi+dcY8ZC/p1lUmQFOe/i1IIg1G5+W+ Xq8mlkwMlDqJgL9+6/7TheNkDpRSHHs= Subject: Re: [PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu References: <20210324113035.32691-1-jgross@suse.com> <5c051a69-44fb-f878-98da-9d6773cca72d@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <6634facd-7113-687a-ee0b-06aa60b8ec7f@suse.com> Date: Wed, 24 Mar 2021 12:55:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <5c051a69-44fb-f878-98da-9d6773cca72d@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ITpL1DH3ISsg9gChOV76SVsnWbZrTRuGF" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ITpL1DH3ISsg9gChOV76SVsnWbZrTRuGF Content-Type: multipart/mixed; boundary="0b31YfNyGZFnfSZOYhfVjccR9bPJycTDq"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu Message-ID: <6634facd-7113-687a-ee0b-06aa60b8ec7f@suse.com> Subject: Re: [PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface References: <20210324113035.32691-1-jgross@suse.com> <5c051a69-44fb-f878-98da-9d6773cca72d@citrix.com> In-Reply-To: <5c051a69-44fb-f878-98da-9d6773cca72d@citrix.com> --0b31YfNyGZFnfSZOYhfVjccR9bPJycTDq Content-Type: multipart/mixed; boundary="------------BB42F39CCE0919B839A6E506" Content-Language: en-US This is a multi-part message in MIME format. --------------BB42F39CCE0919B839A6E506 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 24.03.21 12:42, Andrew Cooper wrote: > On 24/03/2021 11:30, Juergen Gross wrote: >> xenstore_lib.h is in need to be tidied up a little bit: >> >> - the definition of struct xs_tdb_record_hdr shouldn't be here >> - some symbols are not namespaced correctly >> >> Signed-off-by: Juergen Gross >> --- >> V2: minimal variant (Ian Jackson) >> --- >> tools/include/xenstore_lib.h | 17 ++++------------- >> tools/libs/store/libxenstore.map | 6 +++--- >> tools/libs/store/xs.c | 12 ++++++------ >> tools/xenstore/utils.h | 11 +++++++++++ >> tools/xenstore/xenstore_client.c | 12 ++++++------ >> 5 files changed, 30 insertions(+), 28 deletions(-) >> >> diff --git a/tools/include/xenstore_lib.h b/tools/include/xenstore_lib= =2Eh >> index 4c9b6d1685..f74ad7024b 100644 >> --- a/tools/include/xenstore_lib.h >> +++ b/tools/include/xenstore_lib.h >> @@ -43,15 +43,6 @@ struct xs_permissions >> enum xs_perm_type perms; >=20 > ^ This enum is still a ABI problem, as it has implementation defined > size.=C2=A0 The containing struct is used by xs_perm_to_string(). >=20 > Substituting for int is probably the easiest option, because no amount > of trickery with the enum values themselves can prevent the compiler > deciding to use a long or larger for the object. Switching to unsigned int and replacing the enum values with #defines seems to be the way to go, as the enum values are basically bit mask values. Juergen --------------BB42F39CCE0919B839A6E506 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------BB42F39CCE0919B839A6E506-- --0b31YfNyGZFnfSZOYhfVjccR9bPJycTDq-- --ITpL1DH3ISsg9gChOV76SVsnWbZrTRuGF Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBbKLgFAwAAAAAACgkQsN6d1ii/Ey9G fAgAkyr5Q28ZPYlJxSgLjH9oicnPnWK4SPdSguT/fIfOHruS/pGp34KE95aaeywnBMeFoSsAac31 BNxcRooIo1dxGg/+OwfPRWWnOSYXwC8ksLbudOic3cPPuS986BkJVwHB6xd8ZHZMX1qgDqJMVEU0 Ec0VHls4axCT9BA3lSpbtSsWLe8Bip3QSAm08BTAZzElKmhwiz8ypof4+bKhdKzDI9Bw2cHa1qnp SsorbQ15zxFt85M0M65wWgVuT7yq4mfKDSeo2S/pDJ6sWQOtI2GUbGTUUpYQt4gmYBQpDssYqa72 8IZhACLp66q869FNWJD/OUFCKE1WD/H2mj7I0QNJTw== =snVm -----END PGP SIGNATURE----- --ITpL1DH3ISsg9gChOV76SVsnWbZrTRuGF-- From xen-devel-bounces@lists.xenproject.org Wed Mar 24 12:00:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 12:00:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100954.192678 (Exim 4.92) (envelope-from ) id 1lP2Ba-0003v1-BZ; Wed, 24 Mar 2021 12:00:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100954.192678; Wed, 24 Mar 2021 12:00:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP2Ba-0003uu-8Q; Wed, 24 Mar 2021 12:00:30 +0000 Received: by outflank-mailman (input) for mailman id 100954; Wed, 24 Mar 2021 12:00:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP2BZ-0003up-8q for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 12:00:29 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a53f500e-b021-499b-8b1c-149e9e2185c8; Wed, 24 Mar 2021 12:00:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a53f500e-b021-499b-8b1c-149e9e2185c8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616587228; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=t6wvSlpQsqxftjGsA1WHAsFYEeiVRbmY8ZzMgmoe3+g=; b=CEdbrkSYTkNZJtDncXdVDgKaW6t0CJfDG0rqhFKYJOJvDFp5re0/tj3G q5XUpNvhqeG4JqaA4h/SVVO8ac6+jrjNoQpV2C5JwGBHLbyP3CIz08Hg0 8zPiN5N3Yk2bnRdzQ1aKVxgyKkekV1yspmxM5i7oTK00Eh+hMmjNtvvBn A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: n+SrZKed3vXnwNdCl1/9buBcNVaNduqpkKdH6mFEuac9Ux0RIlatG6Pww4Nmn+nBP7Y/0aYqQO /lJGG/Dg60MjPj1ybiwx30tuFlQ3jGhP5QcoODPLNlkAAIeevt+nu1zipautI+WnW9t3C6Lobs gxZ5q6NBhEqxbzRYfdThBUWWdnF9e4DYbso0n66rdEtPYtrEmg4Mjo0M45PsA7+a+43t3vLgTM XivIPa2kWRykq5B7ddD/qhYiHp2r7AJEo4/LFBaXfvlKDSGmB8CLl5r6I8FCz8/y8ijoR8Tow5 AKY= X-SBRS: 5.2 X-MesageID: 41446609 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:ccxzvK7VidBBfIzwhAPXwbGGI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoewK+ybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIU3D38Zn/+ Nbf6B6YeeQMXFTh8z3+RT9Nt4mzsWO/qzAv5ah815EURxqZ6Z87w1wFwacFQlMSBNbAIciUL yG5sRGoDKkEE5nHPiTLH8DQuTFupnvnJXpfRYJC3ccmXizpBmv76P3FAXd4wcGX1p0sPYf2E Xmsyi83KWstPmn1gTRvlW5nvZrsfbo19crPr33tuE7MTPp4zzYA7hJe7rHhzwtpfHq1VBCqq iynz4FH+Ber0zcZXu0pxyF4Xih7B8L52X5wVGVxVvPyPaJOQ4SMMZKiYJHfhax0SNJ1rwToc c7u16xjJZcARPekCm43eHmPisEqmOOrXUviuIVhXBEOLFuFIN5loAD4FhTVK4JASOS0vFjLM BVEMre6PxKGGnqFkzxg2h1zNSgGlQ1ExuWK3JywfC97jlMkHh1i3Yf3cwU901wjK4Vdp8s3Z WjDo1Y0Jxqd6YtHOBALdZEbe2PInHRWhLGLH+fLHDqDrsONX6lke+y3JwFoM6tY5AG1500hd DoV05Zr3c7fwbUBdSJx4AjyGGXfEyNGRvq0c1Q/J5/p/nVQ6fqKzSKTBQUn9KnuOhaPsrHQO qoJZ5aasWTYVfGKMJs5UnTSpNSIX4RXIk8pss7V1WSosjCN43tsajhfOzOIaf2eAxJZkrPRl 84GBTjLsRJ6U6mHlXihgLKZn/rckvjubptDanz5YEoudgwH7wJljJQpUWy58mNJzEHmLcxZl FCLLTulb7+jXWq/FzP835iNnNmfxdoyYSld0kPiR4BMkvyf7pGkc6YY3pu0HyOIQI6YNjRFC JZulRr6YO6J5Gd3kkZeoGaG1Pfq0FWiGOBTp8alKHGz9ziYIkEApEvX7E0NQijLW0rpS9a7E N4LCMUTE7WET3jzY+/ioYPOe3Zf95gxCCmPNBTsnCakUmHv8kgSj86UleVIJKqqDdrYwARqk x68qcZjrbFsy2oM3EDjOMxN0AJTn+WDrJABAGsf55VhbjvRQF1QQ6x9GGnoiB2XlCv21QZh2 TnIyHRU+rMGEBhtndR1buv1kh1eGWbd0dZd21gsYZgCGjKh3p12eiXTKy11Gead1sEzMEFWQ u1Pwc6E0dL/ZSaxRSVkDGNGTEdypIiMvf0IZ4jf7vQs0ndY7GgpOUjJbt57ZxlPNfhvqs3Su qZYRaSNy69IfguwRapqnEsPzRUpHEonejz4gDs6HG10RcEcLmicmhOdvU+GZWx/mLkT/GH3N FFltozp/K3KXi0QMWB07vrYzlKLQ7zrWa6Q/ozk41OvbsquLYbJeidbRL4kFV8mDQ3NoPdiV 4XSqUT2sGwBqZfO+gpPwRX8VoimI7RcA8FsgnqDvQ/el9opXnBJN+N66fJr71qIkDpnnqGBX Cvtwlmu9HLUCuI2eREV+YeIWFKZFM973on1uWYbIHUABirceYG3Ff/C2SjatZmOe64MIRVii w/3valsKu8cTHi1AXZoD1hS5g+gFqPcIeXAAiWH/RP/MH/EVOQgrGy6MrbtkavdRKLL2AZj5 ZCb0oec4BqjSQjlpQ+1myXRrbsqkwo13tY7jcPrC+05qGWpEPaF1pBKwvXn9F/WiRSKGGBiY Dg/fKD3HrwpBhD1p+GMlxRcNFIE914dPm7Ew5ebewRtqWv5awhn2BqZwovFXc1jHTF5NxdtI 3Jkcn6aqnHCX3yP0gG9iMALolonjYzoWUFT8+i9o6mfwkbf9R4SccX18RxizJmql/68lsGSQ 5i3zZYjL3lPxjiJTBxBKLulYz5jFwRo7WD8URnoDFVlkm8gF+RtlDpl6+OyjUJhnyYqhUipb SWRTM3jiocqxVuxrZ5NGGRFWHrWnGIPTrMveUVEGwgDXpqzeMhyAfHJe0MkJu1ymJ/tzQ1Ai Qq2diQZy7iYCTXEce1NSygEdS+HcV7bPlQMHcSNnLeDmWxpr0gChbTPMp73hqimn0SFbGDN6 OvbgWaFoQM9sUrStrRap/bg9zP2Ahf/2wTqIy+iWXtpoMe0f+m X-IronPort-AV: E=Sophos;i="5.81,274,1610427600"; d="scan'208";a="41446609" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bp35+Ql5yaigwdEQAjoddiDMe/RBFQo1z77Ix5aCEDHJiORIfS/ryR/2L3hM7Vv17fOvR0GxEcdbS9PQ/CDXYTGHUf4z4daBP0+hMrJZMf1r3ACdDBKN7qNadWt7fHM/2+k/K+4BijnLTo5tfVjNuQpb4WEqhHqpzR/bZaHxymrvGIrHPlGlDvRGqfPb5KUP+H7NVQAP13bDOGeIzTZisrkp3nqYvek/i/YjfgRDs0KKRmdgHvL+Ke0ozqmWns5DfTpbEW3MITXwNEFCcn05zI5fAmJvbE+kLN8Y8p9dSmIEIFHngt9707GD9R6cdQTmmB+uMtB9yxSq5FZuJa+2gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LpymExJ2J58IxTRvdDuHwd6ww014fUnnbEjpZF0BPH8=; b=NoTEI9UQPeY79xnbiwbjLSJjj5BQbP2w+MN/yXHT8K2AtfEWFvU2bjFD6dPWL7HCdsac9mjSHGGvxCFK7qMCHxeInNK0zWK6JOXb6EB9eR93vxlODYUCzud7GZL8UgQ8QZ7k/wr/556xM9Pgaq0rkCSNlh6y5aSsVhAS5vI+h5EtHOmwhMsbG+/5FPZGgBTOTUDM0AnP0psAnlK5u2HsNIljjlL6fse+zf/q0odYYn+PVAN0rcumHnrnOqobsy26tCxdCuQbYr/qKHbKvbgqTacaUTXkJUZkENbufGOx8yhgEpJtKBd6rlBVzwjn3UdgLmOqNpJ86uwzyNN4PzCsqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LpymExJ2J58IxTRvdDuHwd6ww014fUnnbEjpZF0BPH8=; b=t9jdrP7pIixBx3gm+yCwujzbNTpHcKYKCuWxQqWrZ7SGr3QA0pWddVwVVVAayVBlbp+vku99B/JvPy2XD+ppMVg34wF7ZhQ5xfGmcq4neVFQtG8+X3af1cEMaVqEbuPtKSejA+WG0gYdJ8R92Tih4YtNKjokXNKgFR5cTS1sgqc= Subject: Re: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow To: Tamas K Lengyel , Ian Jackson CC: Jan Beulich , Xen-devel , , Committers , Wei Liu , Juergen Gross , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= References: <24666.1682.595069.435575@mariner.uk.xensource.com> <0bfab829-3841-b2cd-96f9-874340cf75c2@suse.com> <24666.7414.232768.961456@mariner.uk.xensource.com> <24666.8820.146895.73948@mariner.uk.xensource.com> From: Andrew Cooper Message-ID: <0e205db4-e3a8-97c3-6952-fd4c500876f3@citrix.com> Date: Wed, 24 Mar 2021 12:00:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0271.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::6) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b51697c5-4582-4b33-5e38-08d8eebc677f X-MS-TrafficTypeDiagnostic: BN7PR03MB4388: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cAvdFcBQ6CAnf4SUEjgHnL84zDhem4VWuY/H1BKuPhY8pwRqojvF1dKfYMswtEX8K31zal9B8N8NUBx6i+DHIJRqGI5gytx+9vQsQPkMV4lxn/gQ7FT3W8uK/f9I04sVf3iK4eWi+EIbxY5NBbKs5QTNNfy8gooJ5Di+2HM3hLo5bsOzTMKU+BZea6/lpfDE0+6WJaT5VeuUPe1fb92h0EKhpl9p9NYco/ptdjZ6ynoE/IJuoBjIRY35fBXnpcgLrPWsvCFarUj6X+E0qzv1qQFEKrHOMis6oMnfMEC9a6YxZXb8llK+L4/7M4aqwK4Z2pwuXXzEhqx9h5BZEYm/WEpZgvNCn/lR2vnS4jUnBSzIyhZnL2XmgaQfNIVvW0o4sPyWxb7+oLbuYqDFC0OpBFoYULfzdxtRu/mn/GP+OmjkASuLqTY5srjNefhrst9j0UnmZcVzNsWZI8P2P31vlDIfohv0G25lHGcQJ0BNI3veHCZqwJsTYF35DBYQxytpe+ELxFtoqVjAausDJlUJG8XQKOpk3RGpEbn260amWxKAkEDzYJsuJvsDNu4fXOTxzWbovabQFWFvq1rTAP4L2R4PUlSpVlvf0FFI2Ohd1dCsHoBd9tUZq/qHT95DKJqr0Odaas6peZ+LPMk9NDCbG6ith1jLDWGFnWShzwaFuO4zziFxJtOT0qbe8lBe+wN7ts7lzqZqYwN1cq/2bCX4wg6bbwYfupy8frNWMO50KMU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(366004)(376002)(136003)(346002)(86362001)(66556008)(66476007)(31686004)(66946007)(2616005)(36756003)(956004)(4744005)(8936002)(8676002)(38100700001)(5660300002)(31696002)(53546011)(6486002)(478600001)(2906002)(16526019)(316002)(4326008)(110136005)(54906003)(6666004)(16576012)(26005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YXV5clhBdjhvQ0toc3ZvVTUyZmluUXR1RmJtZG56Z1dSYVAzZ2E0L3BQVHBQ?= =?utf-8?B?SXFGVFRMeStZU2NMSVF3TGFlN2pYOVFaMGJaT1lOeDJHbmdJTlVMRzFIbTNM?= =?utf-8?B?M1FnWm1MQUd2WTlpTnZtRmFEenpnRzlFUHZqTm1RL0h5ZHgxSVdGTHd3MUI0?= =?utf-8?B?alBIaytxYW0rY1cxUFFvNkZ6c09UcjlUd3h2dE4yY2d4QmpxQktaMzc0MllX?= =?utf-8?B?SWlnRmFDTVJId2ZSRGtMV0hjTWo4cXJjYVlMNW1tTEV3VEg5cnJBbytyelNP?= =?utf-8?B?dWVVSFNKa3RReFpZeE1xdk1lTkV3ZC9ScDBWYllSSlkwdVlCcWtxS0lKNHE3?= =?utf-8?B?UzRRT094NmVHYUNWT29BSHlEV1ptNi9kOUFyMjREOEthY0loYWtIejNFWmhB?= =?utf-8?B?SDJIOGNtODhxUHd3di9Vd08ycCtwWVJpcTJTTWtzdnRwUGl4VDBmV3NENzFh?= =?utf-8?B?a3lmQzlId0xUZzMwMnNLTVZTL2U1UU82bm9XQTNlVjRqUTIyWGxDcGFadWl4?= =?utf-8?B?cEUyOHJxZEJPNXA5ZFVENFd2ZzVpUGsvSnZsd3dISVYxM0wvbkxiM0NNeDFS?= =?utf-8?B?UDhkMlZ1OU43a1VmbkVWeDM0UGJNcGNTSU5lWDhqNnJIQ1JpNDZWTXNGZGZu?= =?utf-8?B?K2lLYm50aDZ2ZXJWQWQya3gyS0xEL3dFcFpjOEN2U3NRalF4SG5HeDNGUnpm?= =?utf-8?B?ZUQ4UndBQjBXUDZLL2xJNUt1WTdlSGdmcVhTSEhVRHVlYkJQYnE0elFNYTJl?= =?utf-8?B?bDlac3hrNEdHVFZTYnU3TmU1UFlVWVJBYnluQmNsbk44b1JFSzRGcDNzWjBp?= =?utf-8?B?WEpuOXNFQ2RYUWFYSjhLMWVuMHhwekgwc2JFVStUYWRhdDdycmxnaFRROWxX?= =?utf-8?B?MUdWdFc2QWRxMlUydmRabmlIYmZLbHBKTG9VT3lFQmNwV2lueUZZSS8rcGlB?= =?utf-8?B?ZHhiS1B0bm9CYklSMXJWWmpoNHhCUUZNWXMrYzAvSW5ZUTlnY0Z5eGxtSGZh?= =?utf-8?B?U0FuNVdOdllJdCtyZkZUWVFwVXhsTGVVTjFXV0dhNGZzcFBkNWhGZ1hjWkJC?= =?utf-8?B?Mzkyd1o1eVhBVTFHNXU2b3ZycVFQMDF6ZnBkaUZYRFcyN3hZOHJSQ3NMYklq?= =?utf-8?B?L2NveUdPYjdHSk44NWlmVVYwRmZYcTg3MVJsbWI4Tmh1ZzF5Q2plRmE5UXNq?= =?utf-8?B?a2lMV25RQ1QvNWZhYXF0cmFMRDhReUFnU2FsQjMwL2wyU0xrdjRiRzJxV3RU?= =?utf-8?B?RGhFcHlUaXZOSXdEOCtlL0g5aVJsNWZidkx4SFRSekY3NE0vNlg2eE1jWVQy?= =?utf-8?B?QjVTQmptSnZGY253bEZhamZobGZtTmFhbllNTXF4QmN5ZERCNUU4SEZtbTZk?= =?utf-8?B?eXNpODNOa0Z0bHpYR2xXbEYycFlsMVFveW1VMExpaWdHT01yNUFKeEhhOE1I?= =?utf-8?B?OWw3bHU3WUltcXJWSnk4ZnNwYWZ3b21GaGNMR2Vpejk0MVo4eDZReWhYRkpC?= =?utf-8?B?RmU0Rjl6QTYraWhQVEROYUkxQzB0OFdvSGd3cnAzQy84bTBKRnVwdWhCSU8z?= =?utf-8?B?My9UOTVkUW5nL0dnaFZWdlNGeTZsVXdTZ2h2em0xYmFEVGxkZzNiNitwNVA2?= =?utf-8?B?RlViSFBIby8yVW9ma203SEdWNjVUaG1zV1VubVFBM0hZdWdnVmhYTzdVY0lU?= =?utf-8?B?ZXZGVTNmbnM3MGJCOFZxSlRxWDc2b0RtYkNLUTFQd2ZjWk8xak9nQkthcGNV?= =?utf-8?Q?m50qC3yt8aPABhkTTD/EtLW5KUJ1s6IYzerAhEZ?= X-MS-Exchange-CrossTenant-Network-Message-Id: b51697c5-4582-4b33-5e38-08d8eebc677f X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 12:00:23.1277 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gp71JAQhipi7gdzRvZLfQK++uD+pZpLAseCOaKkzJyLa2X1lOgYE/Hy5Wl1xB8QOuHYApzKo438xusftOUILYLJieHpOxZO7qLMtUmTNGQs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4388 X-OriginatorOrg: citrix.com On 24/03/2021 11:48, Tamas K Lengyel wrote: >> The revert seems unattractive. Your suggested command line option >> sounds like a good workaround to me. Under the circumstances it seems >> like it should default to the old behaviour, as I think you are >> suggesting. >> >> So I am be inclined to ask if you, Jan, would prepare a patch >> implementing such an option. Anyone else have any opinions ? > I've replied to Jan's patch as well. IMHO having the option but > leaving things broken without the option set is a bad user experience > as we don't have a way to tell the user when the option is needing to > be set during install. Asking users to see if Xen crashes during boot > is a bad user experience as part of the setup. There should be an > automatic fallback to try enabling the legacy option if things don't > work without it. I agree.  I will try to make a fix with does the right thing and doesn't require users to play blind guesswork to get their system booting. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Mar 24 12:18:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 12:18:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100959.192691 (Exim 4.92) (envelope-from ) id 1lP2Sb-0005BU-Sr; Wed, 24 Mar 2021 12:18:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100959.192691; Wed, 24 Mar 2021 12:18:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP2Sb-0005BN-Ph; Wed, 24 Mar 2021 12:18:05 +0000 Received: by outflank-mailman (input) for mailman id 100959; Wed, 24 Mar 2021 12:18:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP2Sa-0005BI-Ig for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 12:18:04 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a91f983e-8419-4691-9723-b41463147c12; Wed, 24 Mar 2021 12:18:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a91f983e-8419-4691-9723-b41463147c12 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616588283; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=MA7RNmnKUxFc7ThtAOfwvxK5EVURvJy926VFsubP/gM=; b=WXDeTVWw6eFW3nZWPQWu9bXvSFY5BdcbewSV1jJvHQY/02IW3vlhCNSL PptEWqWEapEqrh70uTDHrNw8yTO+IADf04JxF0x3f7woYs+59D3wFxQQv OC85bPWua1PowKDKn1vB66jliVAoWbcGW5eR5MfrgW+q6r5RXDOC2pTUF c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ufolKvIAkNeHf3TxRyosTpXzSPo4bFhEM8sTJ9y//1ZaVABUOc3DioOwYPthh0CHVX3MnUWsGi EFPw1zTdGiffij860eGuQwfbr3+Hm/wse+qa4mZjMnE0hnzisrYAvn9fSm8lKW+l0lbCLiEUN3 rw72APvFqxRt47KFIoTnNJy9R6Sv/DYWKXligFMls0fTWL7mS05nlOPgXL5RJc1be5JTaugLxr cFON36qovmplZvrscFakmvxSonx9lNQL77hP68JOVR+rukIVF+HU7Vt3utJ1PCsYA4dsOM+x1G cYM= X-SBRS: 5.2 X-MesageID: 40163521 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:gaYUYqwtQO9N8akB6MPZKrPx/uskLtp033Aq2lEZdDV8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPsfVr3//dOgbU5F7GkQQXgpS+UPJhvhLGSpwHINg/f0qpm1a lme7VjE9GYNzJHpOvz/QXQKbkd6fad9qTAv4nj5lNMaS0vVK169Qd+DW+gYyhLbS1LH4AwGp bZxucvnUvCRV0tYs62BmYIUoH4zrWmqLvcbQMbHBli0QGSjFqTg4LSKQSS3RsVTlp0sNUf2F XC+jaZ2oyT98uV5zWZ/G/V4pRQlrLau6Z+Lf3JsOc5AHHBjg6pYa5oRrGNuiskydvflGoCoZ 33jDoLe+h19nPNbkG5yCGdpDXI4XIVxFLJjX+enHf5rsTySFsBerR8rLMcSDT1wQ4EnrhHoc V29lPcjbV7J1f8uR64wN7yWxRjhiOP0AEfuN9WtVNze88jcrNLxLZvmn99IdM7Mw/RzpsoK+ VqBNG03octTXqqK0rUuWRi27WXLw0ONybDRkADv/qc2CRNkEZ4yFMFxNcekm1ozuNEd6V5 X-IronPort-AV: E=Sophos;i="5.81,274,1610427600"; d="scan'208";a="40163521" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T9K/LODDjejv+NyiBUiUx8CY9XhtZOFswgMUlOo1OrQhbp76R8IstBH3RuO6daSSvWfEnOsp6deYaLWC/JlPHhlgyDPSxF9RPx53ejFtFuLEF84rMVnlgi/7ra6oZU7sVsTV7zFTw5ZpbeFrBq3q0k0DykLyVAJaLrKtRTcEfFRmc1UFkaE6tqRO1QgbPtHmiAP94T+NTE/huusRgB57zyUFG+eHfEUzxXOCnU+hwND/uSaOwQDBMcjUHjwW0GvkDftD3iexrM97+Q2y7cpEjsZu4mfg8EAnAeXdNevAd/YTWbZSRp2zE2mWoqBZYR9+knb50I2hC4OTocG3ZzPnKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zw3d2v6aNIIWAAyD1yYCNSl+vqRyx1tcom5wbgbKMwU=; b=cTJNNLYdTLbwRI6yvis0g7rhXczkylh0rY9T98v1ScCqTFdvKyXE1+FHFbeMAZUIze+JcN0Rxv4mTHDn6SKT6QHykq9i0VCKiln9vuucHZ4C6vgJZl1FnTmMWz7b7Led1l69MPA3UPWD4J5QmEeermAxSiBaRuqFw2PBDupUVFaVKxdRltOwRo1hk4psqHzxRVAoQsN7OcxaweMRqiDgHFxWYhbNa+GlzILgp0mHIZJJLjubS9TLV6uxxhLOR4dUjtlJtzyR5h1kc91qdZnQxu9ftHlIXwR9hVjfQWjUkojd3VC7tyKIQfRVlLBGZkkOkTYmuv10rY6HHbo8Biph5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zw3d2v6aNIIWAAyD1yYCNSl+vqRyx1tcom5wbgbKMwU=; b=u0U2U6jbYsl3H5/x4HRNbvZ4E0LikQ44S3/9NMst9JhgwCADT7IqiyGpPNZQ+6kTay7pVGoZl/NwskdHIe2adXZshQbiP7ybr++X8vvbw3bs90Yb3DNUKxLeOCkdaIWc4lkCDU2buj1dYs/euJZit4q4GZJkl0rSJUf98nn21cw= From: Roger Pau Monne To: CC: , Roger Pau Monne Subject: [PATCH] intel/pinctrl: check capability offset is between MMIO region Date: Wed, 24 Mar 2021 13:17:44 +0100 Message-ID: <20210324121744.58324-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR1P264CA0026.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2f::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a2910dc-bf35-4ec7-6a16-08d8eebedbcf X-MS-TrafficTypeDiagnostic: DM6PR03MB4138: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NxGIMfyO5R/mAl2mCczXWgAxkZBwN8ngLFXwCmxQ2f3f4ZbBT+4bVz81FqaBi3OhseT8YIjbh37k83v3V/Xita5+ktFbfPDaKk3IggSgHH1eISwXenQU1QXZkaeMkNIqqkiSeN37rzi33MhmvJpl5qbSH08lkY63e4ek1xVTB3rNlWtn8q2y1w+Bmn5FXxJ5ts9sNbASvv7O3RHU6O+rUfmErWFRI0lmQXODzQJOgUMA6unlJeOA3L8nqZ9YLxiGGuMkKuHuDwzdENf8gK2SG6dQ5na78vUtOdeLCvzRFe6c8Pw4BPYantZcNpe2Wva2oSB1I5Ng24t5jV8ILjwqd1Icyj/DqTkBUbRDh7DGbwb7rnvrs6UAp3bp9CoqThQ8nFFbp6fCgeERWvJEZt7bQZUI25Tt5eBhBMyMRKhMaXHG4HjXzuvoAK5r03zbfSlOaa02kLUt08GsPhbQ3e6y0nx8T8Cwo8Ug9CBoMPMUmt93sD2q5zjzVh/Rz13ozd8eWWsrs20ta8Hs4t0CoJUOT4fHooZwVi/6bYPkMSiRPKqc03MmaMTudbWbv0rX6X24GezWJD/0hxOWHjv82a4t6F1J8nVtkLxU/hrMK2g08epirie+sxZEuL2xNTtPF1I2evPM0D4ojhklowGZppFjEehcKoiEKDqONCw71eV1GSA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(376002)(136003)(346002)(396003)(107886003)(1076003)(4326008)(478600001)(66556008)(66946007)(36756003)(86362001)(66476007)(6916009)(6496006)(83380400001)(38100700001)(2616005)(186003)(8676002)(6666004)(956004)(5660300002)(2906002)(6486002)(316002)(8936002)(16526019)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VlJjRVNWTmMreTF4V09mcnZ4ZzdEd3E4QVk4VHRoQkRLQWhiVGJPZEhEeWZF?= =?utf-8?B?cW05QkhDL0N1QTF0azc1cllkMzl5MnBVTTEzSDNaRXIyTFBVYUZqMnpaamV4?= =?utf-8?B?NFdNcWFvQi94SHdJRU9wZExZbzhXWWNSYkdDQW13eVJ5ZStZZDJIWGIyaXBp?= =?utf-8?B?YldvYXh3ckpSUHFsSXE1c1IzUy8rODFIWmVMd3dYb2tMWERuWjZwME5rQWFQ?= =?utf-8?B?Q2VXMUJEaVpSeE1FdWpvQzZkSHRlWERjQWhUSjVLenJ3ckR0Q09pbEtqeWNa?= =?utf-8?B?ZzhHc0ZkKzVvNU93eWQ5KzhhcHgxUmo1enIxYVNkckU5OVkvcUYzWi93WTdE?= =?utf-8?B?SlJuQmphSkNKNVNoRHNRTUVrb3o5RGkvVHUrVVU3d1hBYUhTOFhOemFmUUZk?= =?utf-8?B?OHFQQ1V3NExpR2lBU3MzYUQ3Qm5IOW85L1J2a3RKa2l0c1ZONzk0TFpPUU44?= =?utf-8?B?MnNRb0dIZFNicS82aUZjaE1uOVh1MjNiZi9hVHRETTVMdFgwTTFxblQzYWgz?= =?utf-8?B?bU9RZFpzbFdYZnVtWENhbUNLN3hvWndOTzBzcUFoRkdaOW9KMEpuR2ZoNzhS?= =?utf-8?B?OU5jNnU2MFpkUzRnU3lPRVlLK2ZYaXVsWWRIemdGYkpwVFJKaFVRc0J1ZERC?= =?utf-8?B?RFN4c2tTMzZuRHVsM0dWNHhKa1R4cmUzWjlPZDhJcEduMjF0bDFSc2xEdnE4?= =?utf-8?B?MWZqMnlrckRFUHE0RWxWUHdUaTRkOGxGbnBndWJ0bXVXVVU5YVZhczk5WFBU?= =?utf-8?B?L21Oa1hIWVBJNEdDSWt5UTVLNDJBM1hwcVFLUWZ4N21EY2RrU2h6REI5a2p4?= =?utf-8?B?T3UxZFRmaE40WGRpYkNVTnlTUlFiRzhSRHpmRmZLdm9JV1ZjTzU5RE9DbFNi?= =?utf-8?B?b05wN2pVK3lmYTdmUnB0TEZvT1JtUHY3NlpLelVkcDh0NXFXK0E2SStoNGhT?= =?utf-8?B?OWFIc0JvOWdMbE5zV3BoWHdyNmRmUWgrd205ek4zeDJtUGh6Vi96UExmZjVz?= =?utf-8?B?cnIrQjFKODY3bUdqNGJDRThVRmJ1YjhwWUVGWW5na2kvbHRoSHhEbDJheWVu?= =?utf-8?B?MW9UUktFVWVoazhPWFFZdmIzcnoxODBSeG9nMlNPWHJwZmZlUUIyY2xaaXpM?= =?utf-8?B?M1ZvMHJ0aEZQRnlFMkd5aCs3a0JrT1JyZjFQSVBJTUlHMy90WlJubnQzeUJR?= =?utf-8?B?UHYyUWNBUDlrRE1jQ240TThHZnhmaVRGUUs0MkRpQnY5Z3dyVlF6MENvLzJ4?= =?utf-8?B?MG01U2J4dWx6Wnd3VXFseEIvTXAvcTJGYlYxL0pIbUQ4SWtJNFFkRlZob3lk?= =?utf-8?B?TGZ2WmxHMS9RTk5rUkZ4bXdicXF2akRZRXM2UjVVSEdnUkVJaXJmcU9CN2ZS?= =?utf-8?B?WHRyaXFmc3BtanR6NnY0MjU5RmpuSE8wUEJGVHR4dzl2KzJBbXROVHhyVHlz?= =?utf-8?B?dGgrQjBBcmpZNzFBNDlpUmFpVzFEZ29ZUlZYemh3VEdzSDh3SXBaZlovTFY1?= =?utf-8?B?bVg5QnVRV3o2d1dSdnpKUUVXOVhzM1NybVIwN1lVa3hQS3RRb0drSjM2UkpH?= =?utf-8?B?S21QOVlRMlJ1SnlDNFJPRU9tdGtEbEJwTkdQemIwQkNuaHZUTXB1cVpibnVF?= =?utf-8?B?bDJ4YW5mSUtKQjlHQVNyck9HNDdwSVZhVmRIQlpmSW5lMXRhSTZOazdRM0xj?= =?utf-8?B?eWl6Z1ZwL1R1TE9aOUlHR1Y2ckVqZVBoM3VuWnp6VmdDbkd2VVJ4SDN4ZnFG?= =?utf-8?Q?yPsh+QQw+c/bU7vvIAmaYfWouwFyqiV8+29N8cB?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9a2910dc-bf35-4ec7-6a16-08d8eebedbcf X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 12:17:57.4245 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0aQh/YD2499ACgv6aBsVljD5zHyTAqR0oQGCqz5LDobXK4hgFplXns9FZNPl9nldsADaG//a+mI3p+XaYPUdNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4138 X-OriginatorOrg: citrix.com When parsing the capability list make sure the offset is between the MMIO region mapped in 'regs', or else the kernel hits a page fault. This fault has been seen when running as a Xen PVH dom0, which doesn't have the MMIO regions mapped into the domain physical memory map, despite having the device reported in the ACPI DSDT table. This results in reporting a capability offset of 0xffff (because the kernel is accessing unpopulated memory), and such offset is outside of the mapped region. Adding the check is harmless, and prevents buggy or broken systems from crashing the kernel if the MMIO region is not properly reported. Fixes: 91d898e51e60 ('pinctrl: intel: Convert capability list to features') Signed-off-by: Roger Pau Monné --- drivers/pinctrl/intel/pinctrl-intel.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index 8085782cd8f9..bc8b990d8021 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1481,16 +1481,22 @@ static int intel_pinctrl_probe(struct platform_device *pdev, for (i = 0; i < pctrl->ncommunities; i++) { struct intel_community *community = &pctrl->communities[i]; + struct resource *res; void __iomem *regs; + size_t size; u32 offset; u32 value; *community = pctrl->soc->communities[i]; - regs = devm_platform_ioremap_resource(pdev, community->barno); + regs = devm_platform_get_and_ioremap_resource(pdev, + community->barno, + &res); if (IS_ERR(regs)) return PTR_ERR(regs); + size = res->end - res->start; + /* Determine community features based on the revision */ value = readl(regs + REVID); if (((value & REVID_MASK) >> REVID_SHIFT) >= 0x94) { @@ -1519,6 +1525,12 @@ static int intel_pinctrl_probe(struct platform_device *pdev, break; } offset = (value & CAPLIST_NEXT_MASK) >> CAPLIST_NEXT_SHIFT; + if (offset >= size) { + dev_err(&pdev->dev, + "wrong capability offset: %#x\n", + offset); + return -ENOENT; + } } while (offset); dev_dbg(&pdev->dev, "Community%d features: %#08x\n", i, community->features); -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 12:24:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 12:24:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100964.192706 (Exim 4.92) (envelope-from ) id 1lP2Z5-00064o-L9; Wed, 24 Mar 2021 12:24:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100964.192706; Wed, 24 Mar 2021 12:24:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP2Z5-00064h-Hy; Wed, 24 Mar 2021 12:24:47 +0000 Received: by outflank-mailman (input) for mailman id 100964; Wed, 24 Mar 2021 12:24:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP2Z4-00064c-6I for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 12:24:46 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d822855a-790e-41ee-b390-dcb4685776df; Wed, 24 Mar 2021 12:24:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d822855a-790e-41ee-b390-dcb4685776df DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616588684; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=b57PkLxKVOpjTtob9DfsP00uPudmCsGUbxEqlO49iQU=; b=Fu0qGkjraQJccQEiwoalGGpAz+m3FdiQ+pPJnrgScvIGOCi877LR4PSl Vh3Dzbyfq1S+2FhX41H3lTFpVqL/8b/U0KZrFJGe1ttreaUq+NcCckU9s sX2SznwhCscpOKIVyFqmy6Ks577hDEgvDQFu0axMzYSD1F8MjyZJbfZaq 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: MzSfs2m/4tf2O3g0SroNgQPrHzgt7tt4GMB8NmFqOWy1i6xUhTobNa7tFYT7wx4WJDNQYl9hUl bSJqXOIrnlsHAWUk9XReXOWgO/R47kMt7TH7V6E3Iz2fE4krYnsv8mZ/Rb0dguipURXYK62i/Y 7IF/Bpe9a/wsvYd3BWcmY5WPPadnzgY1VgQjIh2YKN/nHaAUfPzTi1UldFKemdJ7+hCTTLMaU1 0WaaK1mW3OvQqdX3YgTJnqHKniNmjhl+nXYfbth12JoPTQsdpwMz9ah6dV8vZPK3VgURmkJ6hG +RY= X-SBRS: 5.2 X-MesageID: 40164068 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:JBBtFaNY5Xw1p8BcTyXw55DYdL4zR+YMi2QD/3taDTRIb82VkN 2vlvwH1RnyzA0cQm0khMroAsa9aFvm39pQ7ZMKNbmvGDPntmyhMZ144eLZrwHIMxbVstRQ3a IIScVDIfXtEFl3itv76gGkE9AmhOKK6rysmP229RZQZCtBApsQiztRIACdD0FwWU16HpI/Dp WR/Y5qoDCndHQRYK2AdwM4dsLEoMDGk4+jXA4eC3ccmXKzpB6LyJq/KRiX2R8CTyhCqI1NzU HpmxH0j5/T1c2T5QTb0wbonvZrsf/A7vcGO8CWkMgSLVzX+3iVTaBsQaeLsjxwgMzH0idSrP D2rx0tP9t+5hrqFwnfy3uduHiR7B8U52L/0ljduHP/oKXCNU0HIvBcjoFUeAax0TtGgPhA1s twrgeknqsSJxbBkCPh3sPPRhFnm2GlyEBS7dI7vjhxV5ATZ6RWqpFa1ERJEI0YFCa/04w/Fv JyZfusrsp+QBe/VTT0r2NvyNujUjAaGQqHeFELvoiw3yJNlH504kMEzKUk7zo93aN4b6MBy/ XPM6xumr0LZNQRd7hBCOAIRtbyInDRQDrXWVjib2jPJeUiATbgupT36LI66KWBY5oT1qY/n5 zHTRdxqXMyQUTzEseDtac7vSzlcSGYZ3DA28te7592tvnXX7zwKxCOT1gojo+OuPMaLsrHW+ uiGZ5fDvP5RFGeWbph7knbYd1/OHMeWMoatpIQQFSVuP/GLYXsq6j6fZ/oVfnQOAdhflm6Lm oIXTD1KskFxFusQGXEjB/YXG6oXkT++Jl3AZXL5uR78vlOCqR89iwuzXip7MCCLjNP9oYsel FlHb/hmqSn4U674HjP9GcsHhZGFE5a7PHBXhpx1EM3GnKxVYxGl8SUeGhU0nfCDAR4VdnqHA lWoEky37m2IZyWzSULEMmmLWqesnsWqBuxPtYhs5zGwf2gVoIzD54gVqA0Px7MDQZJlQFjr3 oGVBUJXXbFFjTlibysibsdAO23Tag4vC6bZepv7V7Pv0SVos8iAl8WRSSnX8KsjQEyfDZMnV Fq/6gDgL2PpCa3JQIE8ZUFGWwJTF7SLKNNDQyDaokRoLztdQ1qZUqhhDCRiXgICyPX3nRXol akATyfePnNDFYYh2tR1bzy9khoMk+HeVhrV3x8uYphNGjPt3ppy9WXbq6r32b5UCpH/sgtdB X+JRcCKAJnwN66kCOPkDGZDHM829EAOPfeALlLScCm5lqdbKmz0YcIEP9f8Mw7aJTAsuoXXf mefAHQBjXiEO8t0xGUoHFgGCQckghXrdrYnDneqE6/1zoDJNCXBnJMbbQSOcud4GjpXOzg6u QOsfsF+c+LdlzsYduHw5zNZzFNKhnvsXe7JttY2qx8jOYXjv9PBJHVXjvD6WFf0Dg/JMnykl kCQK4T2sG1BqZfO+gbeydU5TMS5ayyBXpulgz9Gekle14xy1fdItOS+rLNwIBfSnGplU/VOV OF9Tda8OqAdyyf1aQCA6Z1BWhNckAz5DBD++yFHregQzmCRqVm/FCgNGW6f6IYYK+ZGa8Iph I/2uq2pYasBl3F8TGVmyB6LKJI+3umRs33IDvkI580z/WKfXKWgqWr58aviizQUjXTUTVeub F4 X-IronPort-AV: E=Sophos;i="5.81,274,1610427600"; d="scan'208";a="40164068" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g/aEh7ZQUFm3Sxn/iafliyzsSfelSJhIkGCnC0Ykq7rxvm9lBB6c2PhtYBv6cUPLMpMArmScNSnMGVka1CShoK8i1vBI9bdO5Zhf7OC7tl1uwq++N17PAjsrMY5QTk0cdJyIa6hrlQQIDwx7iV9knfTcvlG4ExNiQj844OlhgPahYAbGLLWuP+Dzpg3qh9CrCgWCs9DbVlbpEZdz+0CIVLjkZbm5i+2QoSEDAJAa26ucmL+r9dfUKIt+Z2olGKaxbZBDxyg2h/M3MeIsdmR9uSITF/zO1E6r+vQKNI3c5nF+Jrhih3Nw4y98s9BewyITVsMDG/oOHohHMeLNX0En4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C3dYednsfe+JWK3g9vkdloy+BrfrO73P+Mzf/FA4yCA=; b=g5OgIQBC+8sJqBpfDpYcjs7iKkN6f9bgw8YnQH1jc7W0tFxJcufFcELaHnTAdLzn6dxWQ5khOuYgpE5toNYZoJQhPCv4i9Pu60wa/HkxtlMzCsZ2G4SOVineDlpWPW7SNHuH9z7v/ZOmERrsoZPgjBE05VfqTvYGxUJ0r7zmu0ThE7KWliofs6wfklU6L6NBmqlOmdO+cDvo9tZbbi1ESYMTnZMTpdf8dGDIyhKQeJm7ZzgnqJMeAq89A+zNDsBPUXhQVHmtscOR2cnvLLoRYyC8+niR6NNUNwbejOyZdtAXDALUOM6YFAGQFW5PTl/b5DidVy7A1MWdsd+dd8+sPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C3dYednsfe+JWK3g9vkdloy+BrfrO73P+Mzf/FA4yCA=; b=m6uyPxfk0qOkhEnL2uNOeP02PMy3Rn3+2RQlPr7sDRFUUkBZOxwOZIPyqS6Ydt5ejUnufbsTnCnyvgF78HdxSmB+yaeKUhycJ+pJZpm2UQgqW2U1ixRiVTvm3j5fzxv+ptHyDaalDl2+lmz+s2vSFMbjmvzeiQ48SsXeWNaqGPQ= From: Roger Pau Monne To: CC: Roger Pau Monne , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Jan Beulich , Subject: [PATCH v2 0/2] xen/x86: alternative fix for XSA-369 Date: Wed, 24 Mar 2021 13:24:22 +0100 Message-ID: <20210324122424.58685-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0138.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::30) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b36437e5-6ac5-4afc-c179-08d8eebfc895 X-MS-TrafficTypeDiagnostic: DM4PR03MB5965: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L89DnOE8394Z4w/7eFkHtqBT/AWJ9qjRKB43Q7R9GkelJr+Aqcf3mEW2yVDfobxHPB8/K3YWHRvBmC8q2yB2Sq88LbCaiUg5NOs978IqrdnRGZn6GUOI4gEfHB+Y1i1q9i2HQ9DYS89vTjgr+lWsZXb0fam/ZTG71bYVqigsYAMFHcpTCAmGYGyq6oJnWnhg5dzkYdzsAxMpD9Hl+0+NuF/xJQUWTVzl89S0nw0cBp0j/90Fg9uvIpc8L/6Qp2dqU4GDFbeB9xfwumgaSgFOhymotPt7kaSBrkjlHYoxigu3DGq+GJFBIWNAwX07bETfnfZbUWEQ/uG0YNSC0OzVtpxVpqaMVhkys61CYesl0t4329oqnB7yZnXKCGzsHpp8Wie9xVbwZHyQk7QkGt9I+AMdJl7Yuw50/mZZ/rQWlWhi/jc0ZwYQMd+zWwgEl0oCnk9rRTY16zQNvrpz1q4JGc+fjz1naNtP+IdrJFNmSqdhG98+A5HEW4Wb4yguMV36zySOdNQKgXq3lM4BU/9XF23hJ+1+wj8A48O32x3s+9luLxfuTIhINA6QbL9291kYwUivmxzWaDnJ48zVcrUPPiikZbAHTgCyqpU0BoFV//Cwa4tacJTkSZiORLwJaryvycLilw9la1fM0GjVGwn2gIMEXHUW6WjDEB+1krWvclA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(396003)(346002)(39860400002)(366004)(956004)(66946007)(2616005)(83380400001)(16526019)(1076003)(6486002)(8676002)(5660300002)(8936002)(478600001)(6496006)(36756003)(66556008)(2906002)(66476007)(6666004)(86362001)(38100700001)(316002)(54906003)(26005)(6916009)(4326008)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?S1YxWUliWEcvS0xKRVFqNzl2N2pjY2hiVjgxSTFwbFUrY0Qwc05CemdTY3ZX?= =?utf-8?B?RHZXekVJSHNYQ3JDTVJtSzFrQUdDWVpVNStRNWJHbnpDZnFDbzFudUVIZTRD?= =?utf-8?B?eEpGcXVXWSt1dHEyQ1dielluRXlYNUJ3K00zV2RyZVN0N2FBeEVYK0paQzlm?= =?utf-8?B?ZTRYSjhHNW9iT1k4MndXdG9NdG83RVRVa3R3U2lqdUtvK3hYRFVIMVRjYUdy?= =?utf-8?B?cXZacklQeW41TlFKeTZCSkhpNSthV1RibjNnUy9UbWlDYXlETysra2VET2JR?= =?utf-8?B?d3UwQkgwM3VUU2I0YlQ0Ymd2dFB4RWtoc3l2V2lvclVhSUNPZko5V3ZoTTJa?= =?utf-8?B?VXhUUVRzUzEzUGhaaFVjc3pvajNJZWJVaGlia2FyOWloSnFtcjJYSjF2b1ZU?= =?utf-8?B?WTNrUmJBSlhqQllkME1sZEo3VEZTUC9hN0VmSkhVSlR4dTBobVA1OGdpd24y?= =?utf-8?B?dGlQczhsVVVaUkRHajVWaGNGVTRkTlZXRHdNVHVuZjl3LythY3dxMU1WKzYv?= =?utf-8?B?YlFsdTl4TUFJSjFua2tVMnlOa2oxeUJoRjZjOUY3SGt1ZHJBQjlSemRlcWto?= =?utf-8?B?UGJTWjQ1NGMxdWRYSGtYR0tPdUk2aVA0dGF3dk9RRFlyRG15TGlOTE5BeDdR?= =?utf-8?B?Y1l4b3diM0pYNi9QZVVNTU9KU0VCaHlpOU5qU0YvRkIxUjM5NytmR1cxcjJP?= =?utf-8?B?VVZMcHp3WEdjZW9KOFJqSlU3RXlmRnlLVjRxNDJkWEJmSFhqR3lZWEg3Ry9Q?= =?utf-8?B?b0pDRE9OSmZxQlpiblczVlBBZy96alV4cUFzMkN6ZitlMG54c1hMWGdlWjR2?= =?utf-8?B?QWJMZ3h4VU1xUU43UjNNT09oUTFudEJzY2MxMmpvYk55alluNVpVa2NzUnZJ?= =?utf-8?B?Q3hIMnFwVWNTSEZhRzBSNmhpcEJUZTFOSDQ5RHRDZDduWUxHaTBaQ0hoZ2lh?= =?utf-8?B?ZGFwaytTTVpsMjVGMUxNYnRUWDc4UEtoOEF6dWJsVmJGT0xST2ZFUWpyQ2gv?= =?utf-8?B?ZS81RllzY1VURmtzZGxTakNCajZScnJUNjhqRmJyRzVhVkJyQzVwcXlpeHlx?= =?utf-8?B?dnNpdU5jSlJEVWcwUXV2aTc1bS9INWZLbnJPRjUreDRBZ0hIbG1VQ1NKZXBa?= =?utf-8?B?bHkyZjlqTmNtWGxvVUVEc0V1NkJYQUlaUmozb2hXSzJGUktITDZsTTdnY0lj?= =?utf-8?B?N1dCeGpmdDRqcUZRQTF6dDZKKy9lcHVnQVBUK0dPUEFQZUQwd3FLd1ZkTDUy?= =?utf-8?B?c2gzZ2laZkdjZk5RbGxyK0dwQm5lU25TcFVya2VRWHFRNFdmYVBVRVdwaUk1?= =?utf-8?B?MDhFbnNFL1pYWTNpNEdhdm1LSGhOTzhRWmlPUmRoQ09DaENOWjBic1FpU0tS?= =?utf-8?B?RFhMdTFPV1RvMmhJNDJINEJLRzE1Y1lMc0NqQ2xkVytST0R2dWVCKzRZNTdw?= =?utf-8?B?OGxzbk0vOE9SZ3YvV2d2NU9USlIveWFtWVBCK0JXMmZxYmNqK25nSEMwN1pU?= =?utf-8?B?NDZHcnYxNU9GMVowbzZja2JPcWtpcjNSTzhZQlA5VGFoTlZEOWQ5NWtkQ2Nr?= =?utf-8?B?cVBKeDNPMFJUZGp3NUUxZ245cGRSVGRFbUJSdzJDdUFCY0xYV0NWV1ZVWGIw?= =?utf-8?B?SXQ5M3BaekVWRVE0NFB2VTJ3WHdzcGdqaEYzSFNHWXJ2V2tYbDY5aWFuR0VH?= =?utf-8?B?UUVmSzJ2SUhFU2dtUVk4NXBITkUrVk1CVGEwVHpBdXF2TUVUUUU4OFF6aWVG?= =?utf-8?Q?8L0TqlBikVZBEStW+4d1QNsgOFygM9Vhf02W+A9?= X-MS-Exchange-CrossTenant-Network-Message-Id: b36437e5-6ac5-4afc-c179-08d8eebfc895 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 12:24:34.6547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MOcB5v5JcqYMEb4XDXiI8U8RRRJ5hv3FQQcbIJXimoTpcxotylcOPgTHkdZA3f22eApDY7Fi3jPmddmjZReRaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5965 X-OriginatorOrg: citrix.com Hello, This is a proposal for an alternative fix for XSA-369 that instead of special casing XEN_UNPOPULATED_ALLOC to size the p2m relies on making XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on the generic MEMORY_HOTPLUG option rather than XEN_BALLOON_MEMORY_HOTPLUG. I think this is safer, as we don't want to be special casing any option that pulls in generic MEMORY_HOTPLUG without XEN_BALLOON_MEMORY_HOTPLUG. Without this we would also need to at least special case ZONE_DEVICE which also relies on MEMORY_HOTPLUG, and is what pulls the generic MEMORY_HOTPLUG option even when XEN_BALLOON_MEMORY_HOTPLUG is disabled with XEN_UNPOPULATED_ALLOC. Thanks, Roger. Roger Pau Monne (2): xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on MEMORY_HOTPLUG Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" arch/x86/include/asm/xen/page.h | 12 ------------ arch/x86/xen/p2m.c | 7 ++----- arch/x86/xen/setup.c | 16 ++++++++++++++-- drivers/xen/Kconfig | 4 ++-- 4 files changed, 18 insertions(+), 21 deletions(-) -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 12:24:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 12:24:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100965.192718 (Exim 4.92) (envelope-from ) id 1lP2ZC-00067W-2Y; Wed, 24 Mar 2021 12:24:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100965.192718; Wed, 24 Mar 2021 12:24:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP2ZB-00067M-Vc; Wed, 24 Mar 2021 12:24:53 +0000 Received: by outflank-mailman (input) for mailman id 100965; Wed, 24 Mar 2021 12:24:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP2ZA-00066w-8A for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 12:24:52 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 82c4e778-5ae6-492e-868d-1bad5e9776f9; Wed, 24 Mar 2021 12:24:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82c4e778-5ae6-492e-868d-1bad5e9776f9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616588690; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=giVRHJtlc3DCWL3OaQWEKD7vShJB0d2LgQoSwJbG6k8=; b=IOEF8nMB5is5qCkfYvmbsKvbHfRT3PY69+qBHuE3EqZz6VTVNptfcctj jzc8t0t3eC7mgf/MpcwTkKIp1KHJ/XFl22LzNQEL6cp2cQa/SY2wRcz5l iRFPlF4pHiVt912BpBaTlS5VsPhNLPp7Hgt4/6cOsixiGSWqzQwE3uEpC Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: MWVqDfl5Oh2x+CTTTVlOFChm9giwfAsqHU6eOOwBY+4wQE1uvn/NH1DFD86R8B3mH4aaKG51vo 6Fi1xAFkfRMwOEisaDmMJkstzoLFVq4aHdcMDhyp9s134SrKgfyJEePuR1KxvHN9CVm8SIIFAv 0D+fmPCsmDi1L63UKh7Lm7nY0pGCeXGJ5h2iU0cJiv+MjQrzD02R1WyMx/MC+eZfdH//PJmzDw Lqu4YZLM6l/kAxHz/2YlJl9PjhQDd3Vt1juDT0i6Hj3X67Ma3Bq5WgHy6ybFlW4WBr9yE1I+Wg F8E= X-SBRS: 5.2 X-MesageID: 40164080 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:glLOwq/CR2AKh9hOauNuk+FdcL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmyybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIUHD38Zn/+ Nbf6B6YeecMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsKV4hLxW5Ce2KmO2dxQxRLAod8KY GV4dBJqyHlVXMcaMm6AXdtZZm+m/TgkpX6bRkaQyM28QXmt0LU1JfWMTi9mi0fXTRG3Ks4/Q H+/TDRy62/v5iAu3nh/kDJ6ZA+oqqC9vJiA4i2htEROnHQjG+TFf9ccpmjmBxwn+218lYtl7 D30mcdFuB+8WnYcG3wgTaF4XiY7B8U53XvyUCVjBLYyKSTLlJKaLsyuatjfhTU8EYmtt1nuZ g7pV6xjJZLEQjG2B30+tmgbWAaqmOPvXEgneQP5kYvNrc2Vbk5l/17wGplVL0EHC789bk9Fv hvAMz29J9tAC2nRkGckW91zNO2WHMvWj+AX0gZo8SQlwNbhXZj0iIjtYAit0ZF0Kh4Z4hP5u zCPKgtvLZSTvUOZaY4IOsaW8O4BkHEXBqkChPcHX3XUIU8f17doZ/+57s4oMuwfoYT8Zc0kJ PdFHtFqG8bYSvVeI2z9awO1iqIbHS2XDzrxM0bzYN+oKfASL3iNjDGYEwykvGnv+4UDqTgKr eOEaMTJ8WmAXrlGI5P0QG7cYJVM2MiXMocvct+dEmJpu7NN432ps3WePveP9PWYHQZc1K6Jk FGcCn4Jc1G4EzucGT/mgLtV3TkfVG63Z8YKtmew8EjjKw2cqFcuAkcjlq0ouuRLydZj6AwdE xiZJfukqaxo3iK7X/Fhl8ZfiZ1PwJw2vHNQnlKrQgFPwffarAYoeiSfmhUwT+hKgJgSdjVVC pSvU5+967yD5H4/1FtN/uXdkahy1cDrnODSJkR3oeZ493+R58+BpE6HIprFQvKEBRxsR1wqH hKbTIFQkO3LEKstYyVyLgvQM3Pfdh1hwmmZeROr2jEiEmarcYzAkcAUyWWSs6RiwY2Tz9yjl l8mpVvx4aoqHKKEy8Ske44OFpDZCCyDKhdBAqIXolSh4vmYRp9V2uMmDychSwiY2aCzTRguk XRaQmvPd3bCFtUvX5Vlpzn9155bU2xVUN9YHISi/w3KU32/lJIlcObbKu61GWcLmYYyuYGKT fffH85OQV13e260xaThRePHXgr3Y8VI+TYFbgvGoujnE+FGcmtr+UrDvVU9JFqOJTSqecNS/ uYYBLQAzXiCe8lsjbl0EoNCW1Rkj0Dnvzp0hG+szT98347HPbIIFNpA5scOMqR6mD4R/COlL V15OhFydeYAyHUUJqhz6qSUhtobjX0ikSyR/szqZ9Vsbkp3YEDV6XzYH/t7jV/wB46LM3Ij0 sQT6Rw3aDZNuZUDrkvUhMc2mBsqc+GI0QquDHnG+MSfVkiiHnAItOCioC43oYHMwmkrAv0NU L3yVwkw971Gw+C36UdEaQ+PCB/b1U98m1r+Iq5BsftITTvU+FI51yhNHChNJdbVaieAL0V6j J3+cuBkePSVy323mnrzHZGC5ML12asWsWpBg2QXcZO7tyhIFyJxpKQ3/Tbtka/dRKLL2IChY NEckQMbsNMzhka5bdHrRSae+jQuUIqk1xX/Dd9sEXis7LWuVvmIQ== X-IronPort-AV: E=Sophos;i="5.81,274,1610427600"; d="scan'208";a="40164080" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lmEJF6Lr/PzEU6Q/xMbVIRQoT22nwov3vHu+lrXdsc9o8f1bdvl2EtB7pgKo7aRw/2uVJaMkFkBVaDOQMDqtCiIEVCCKtKKHAYFDf0jBOoPtQRWzQRWgM/tsg8glYIIAOWEuZ0i2tfL9XQ/wXZmH/atmj99CPjlBG3RYdcBIOtGUJHwFgRxVkv2jd6QxXvfjPLcaKFaMp+gFq/v1nPjq8Bh4kq/1Gdpj22bYKw/IMAQIIUKl9QBYwl8INUmKLXC+xded95SJT7U9RW5k59xkbBSU6N+2dKD2czYluCVSy+NITmXce7vTzQ0E7iIj7k0CjIZNcNZqgi0iGtJNVuzUzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pQB1zomGHXhgskyyATY7D426hfczy2/Zc/M/21Hxsgk=; b=ZXP5QIvuHN99v6u8S72SbDpaLVQRgWKy4Ek5/0WT7tXoirJl9F3nmuNjKd09eHokHgPZpSX8Gl3naRXoz2pdoQESPPPX+/kQBiZ5gQ+/57Ah8BWFrSGxJRqv0gCfKg2wuEM404mC0sJw2HIRQQ0eX6iD3Str3CwImuxuVFEBEL5T2iK51ClksDS4GDoazd/yRvn07bMmyG+Y35USLtYyAHqIHsz+zesf6oE4pd3bYBBuhkXn15f0P5yeDjs6aqPMDY8MTyPtOPkQXQMDVBFKaJVPet3XNsYRva6JooK/Q+ABMZlsrjV4hz30MiOgoY5Yb/+EgJ2+uz1W4yZt8mpUFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pQB1zomGHXhgskyyATY7D426hfczy2/Zc/M/21Hxsgk=; b=dDJSONtAJGzYuSJhhzlaoc/hWqXwgeRu3owH6fLp3cSiYMG9l8P1BWWzkICQTPx46t/fuxaXbAn4krvloWOGI59sIi2nDiKAa22c1KJ6GraYChUFjV1Mdjh75IJDgwEQhn5OOg16jaL8RAKKxXc8OZSgv3xAKHvD/YTgseKjIF4= From: Roger Pau Monne To: CC: Roger Pau Monne , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Jan Beulich , Subject: [PATCH v2 2/2] Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" Date: Wed, 24 Mar 2021 13:24:24 +0100 Message-ID: <20210324122424.58685-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210324122424.58685-1-roger.pau@citrix.com> References: <20210324122424.58685-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0127.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::19) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 45ff27a1-9f85-417c-9673-08d8eebfcf5d X-MS-TrafficTypeDiagnostic: DM6PR03MB5338: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:422; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a8O3q5wVPgEqjakRRsL9+Ld3zERZXwkbTdWHkxRZsUCQ7bCc9bzlAzd5cDmMHVw03YzheQUkESAzp+qBj2rH7DM34Z4SgDTDjWQTCwmxhOHxtdmzLnopZc6/xyipcxNRUGGqzQt2UPsuO6HkpiiuveUz2ihbM/rccTlxOSdK710fvv9QsVnHeHtUFOy+b32iT0XJh5LWdmUZzgnTAkryd6WnC0gC2Uk1PC3LunSGm5UOuBqCSJctjbrhaTEFe5Tui36NhS6isWQKVxZUCAyEc2OJg/C7CUr/jvKvjHVYZMIegoRcJfMHVlVk7S7ZZ7lwi8qMZKaUJ8j4siAB+0gN5WoBqo7OUiJQ4ouM9GeFqbHj2mCczVFwKIbC8D9cZnv8Zqng2PoUhsIeLptEBfNmqL7X/RgGSH6xSXTaVJCkt70WRKUh3Er2UIlB9KAsTZ6vXGBrcnI56ClbA9bkXZWBm9qkfAP5f3lTHb2cZCf1ROe1UhruEu0Ru2itLtPVpqgRLyOi/L/VKajDXozzST/i3RSVKE3m2iAhM6OeTNuc9Z3VGry9AFykYay/Kn34CIG6KmnSvE7qvFlHc6ILReX0hUSgY8SbIqi8/eBZxchkwy1P0n2gCf2Q++pZgVa0i4msc/hxmpMg/d2UZXZuuNa36d1vv2oJerD6PgUp1VqHd14= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(376002)(346002)(39860400002)(366004)(2616005)(1076003)(83380400001)(8676002)(5660300002)(16526019)(6486002)(956004)(478600001)(36756003)(6496006)(66946007)(2906002)(66476007)(8936002)(66556008)(6666004)(86362001)(38100700001)(6916009)(186003)(26005)(54906003)(316002)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UXM4R2NrZzJHR285dzhNZkl3S0wxTFZERWRtUzdYVXgxamN6VXdCSXI2UklH?= =?utf-8?B?c1h1bEZkUlFCNXlac3N5d0cyeWFKNmUvcnNmZHVuNW90RDhoeVlzZ2FKdUFZ?= =?utf-8?B?MWhDUXBNcGpadGtpTjZUZHpnY21IU0NJOHkvVTF6M2N3d2VZOW4xTU93enYx?= =?utf-8?B?SGZMamc0VHRHbFc4emZnVk9HSVdvWXhhMG40Snk5UVQ0R2o3VlNCYWg1NUla?= =?utf-8?B?Tm0rc0ppd2tSNGU4Zy9nR2YvbFJOM1hPZnBXd1BlVVhXc2RqSFlTWXczWUNG?= =?utf-8?B?UlRyMDQ4K2ZYNWs3RkNmYlpUMjQvN2l5MklnRWhiU3JxRzZOTmFoU2p1Z1Bl?= =?utf-8?B?WkdKVEJXM0tSVXhSN1AxSGdGTDZJR3p0S0N4b3BUVGZNbmJjRVhvR2ZtWFB4?= =?utf-8?B?NUkxb0tHQzZzY1N6OVRFL0ljOUp5OE9CZHlIUHMxTlV3SFozWHFlclB1SVd6?= =?utf-8?B?U3JEWCtUVTI2bi9kZDZUK2VtbDQrdlFyTVQybzdNVmhBU2xCTHJOaEFqelhT?= =?utf-8?B?b0lBa2w3WHlyVlhhajdsbjg4VytWYTA0YWQ2Y1ZqcDBzUUk3S0NwYmZxRHNk?= =?utf-8?B?a0JnT25JLzZ2TkNzKzlPQ0p4RnBuR0JNSGpkcG42ZGQ3NmRVWmRXMWF0dlpD?= =?utf-8?B?UStBUUdJcUZXNkJKUmV5bHBlL3owSDNvbDF1MXNCcHZWZk9ndklvMXkwNzVn?= =?utf-8?B?ZklLdWRUU0YvMjlacnNNWnNzcUhzYzV4OEZzU3RsbkZ4N0pHR0Z3TFo4OXN4?= =?utf-8?B?U0UvTzlOaHRpMHFPM25LdDJMamQ1NWtCKzVMdERVV1JZTEJJMW91VUQwTS94?= =?utf-8?B?V0FMRXQ1S0UvN2pzZVUvai9pUGNmc0h0T3RCMmV3bUpvaFczb2pWWnFjL2VM?= =?utf-8?B?d3FlMU9KVXZpVlFCTERsNHNjSXEvdFcwU0MxbGZEWGJONnptcmphK0tWb2ti?= =?utf-8?B?dm9RbEhKUWtsUHFMSk9iSmRFWnZ3cVU3YzZ0RXcwcFM2RVRPNW1rMHp6S1Ix?= =?utf-8?B?YUREazQvMWkvTUpsOUJDSDloQWNEMUxvaHhTMHoxSStLakhoOFZPVW0xL2po?= =?utf-8?B?QTh3dWNHUUJZK212UnF3ek10SkFwRGtNRXZmUlRoQm1RQ2pVZE1UTVBJU1R2?= =?utf-8?B?V0lSWkthNG5OcTFkK05LMG9oWStrVHYzWXJkSzhXZXJobytheXNkVHNkQk1H?= =?utf-8?B?TDN0MWhzcVVqMFZpSkkwTEdzVnNTVVZ1d3k0ZUxYL1c2MEhVcElDeG8vdUlT?= =?utf-8?B?ZWNtbm9uVnM5NEh3SW9iUGVDOTlQdU8xaDl6VUFrdFpFTVBQSlR2SVg3TzlI?= =?utf-8?B?N3NlbVFyYmpGNDdjQXJ6MGFjMmkwbFN3NGpoRzAvR3ZvUVhGeVNDT3NtSUlO?= =?utf-8?B?ejR4NVQ5K2F2VXJ1UUc5dUl4NTZPMytRcjVxdTV2WTFDVWRnSUw4aE9tb3du?= =?utf-8?B?Zzd0dGFzelNpUnRaTXh1N2JnVklpekc5eCtYVm52Y2s5dWQxOU5KSll6blRQ?= =?utf-8?B?Mm1hckYxa3RyTzNpL1RVUmZ3ek5kUnZDSnhpZ0V1VTkvZGRyUlZTbTRRZ0pT?= =?utf-8?B?OWZsOWovMWJNTUcxZjFwaUY5bzR6UFpJKzc5MlVPdG40VHRjQTdpR2F2Q3M5?= =?utf-8?B?dWs0OTVkcmtEQnZuOEMzS1ZyUzFPNW5ncjRJYkpPTVZTK1pGUGhSdW04cG5U?= =?utf-8?B?akEwQ3RUMkpSQ21mU2NZNk9nY0psYWp5Q3dpcVJ5Rjg3M3JkWmhXWm9KTVRj?= =?utf-8?Q?N6DKcNiiP2EPW4hfOGDqfA52oYds5yqB+fnqNQg?= X-MS-Exchange-CrossTenant-Network-Message-Id: 45ff27a1-9f85-417c-9673-08d8eebfcf5d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 12:24:46.3343 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f5P5AHeoLbcfH/J+D+I8hYdLpSAH5u9ZHVFulgpdZii+3jzSyaltJ7+iKJOnLkntvn28zsL+r0iAlmNi5wLOIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5338 X-OriginatorOrg: citrix.com This partially reverts commit 882213990d32fd224340a4533f6318dd152be4b2. There's no need to special case XEN_UNPOPULATED_ALLOC anymore in order to correctly size the p2m. The generic memory hotplug option has already been tied together with the Xen hotplug limit, so enabling memory hotplug should already trigger a properly sized p2m on Xen PV. Note that XEN_UNPOPULATED_ALLOC depends on ZONE_DEVICE which pulls in MEMORY_HOTPLUG. Leave the check added to __set_phys_to_machine and the adjusted comment about EXTRA_MEM_RATIO. Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Jan Beulich Cc: xen-devel@lists.xenproject.org --- Changes since v1: - Expand commit message. - Do not revert code comment. --- arch/x86/include/asm/xen/page.h | 12 ------------ arch/x86/xen/p2m.c | 3 --- arch/x86/xen/setup.c | 16 ++++++++++++++-- 3 files changed, 14 insertions(+), 17 deletions(-) diff --git a/arch/x86/include/asm/xen/page.h b/arch/x86/include/asm/xen/page.h index 7068e4bb057d..1a162e559753 100644 --- a/arch/x86/include/asm/xen/page.h +++ b/arch/x86/include/asm/xen/page.h @@ -86,18 +86,6 @@ clear_foreign_p2m_mapping(struct gnttab_unmap_grant_ref *unmap_ops, } #endif -/* - * The maximum amount of extra memory compared to the base size. The - * main scaling factor is the size of struct page. At extreme ratios - * of base:extra, all the base memory can be filled with page - * structures for the extra memory, leaving no space for anything - * else. - * - * 10x seems like a reasonable balance between scaling flexibility and - * leaving a practically usable system. - */ -#define XEN_EXTRA_MEM_RATIO (10) - /* * Helper functions to write or read unsigned long values to/from * memory, when the access may fault. diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c index a33902d05e45..ac06ca32e9ef 100644 --- a/arch/x86/xen/p2m.c +++ b/arch/x86/xen/p2m.c @@ -416,9 +416,6 @@ void __init xen_vmalloc_p2m_tree(void) xen_p2m_last_pfn = xen_max_p2m_pfn; p2m_limit = (phys_addr_t)P2M_LIMIT * 1024 * 1024 * 1024 / PAGE_SIZE; - if (!p2m_limit && IS_ENABLED(CONFIG_XEN_UNPOPULATED_ALLOC)) - p2m_limit = xen_start_info->nr_pages * XEN_EXTRA_MEM_RATIO; - vm.flags = VM_ALLOC; vm.size = ALIGN(sizeof(unsigned long) * max(xen_max_p2m_pfn, p2m_limit), PMD_SIZE * PMDS_PER_MID_PAGE); diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index 1a3b75652fa4..99ef476dc702 100644 --- a/arch/x86/xen/setup.c +++ b/arch/x86/xen/setup.c @@ -59,6 +59,18 @@ static struct { } xen_remap_buf __initdata __aligned(PAGE_SIZE); static unsigned long xen_remap_mfn __initdata = INVALID_P2M_ENTRY; +/* + * The maximum amount of extra memory compared to the base size. The + * main scaling factor is the size of struct page. At extreme ratios + * of base:extra, all the base memory can be filled with page + * structures for the extra memory, leaving no space for anything + * else. + * + * 10x seems like a reasonable balance between scaling flexibility and + * leaving a practically usable system. + */ +#define EXTRA_MEM_RATIO (10) + static bool xen_512gb_limit __initdata = IS_ENABLED(CONFIG_XEN_512GB); static void __init xen_parse_512gb(void) @@ -778,13 +790,13 @@ char * __init xen_memory_setup(void) extra_pages += max_pages - max_pfn; /* - * Clamp the amount of extra memory to a XEN_EXTRA_MEM_RATIO + * Clamp the amount of extra memory to a EXTRA_MEM_RATIO * factor the base size. * * Make sure we have no memory above max_pages, as this area * isn't handled by the p2m management. */ - extra_pages = min3(XEN_EXTRA_MEM_RATIO * min(max_pfn, PFN_DOWN(MAXMEM)), + extra_pages = min3(EXTRA_MEM_RATIO * min(max_pfn, PFN_DOWN(MAXMEM)), extra_pages, max_pages - max_pfn); i = 0; addr = xen_e820_table.entries[0].addr; -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 12:25:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 12:25:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100967.192730 (Exim 4.92) (envelope-from ) id 1lP2ZP-0006ER-DE; Wed, 24 Mar 2021 12:25:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100967.192730; Wed, 24 Mar 2021 12:25:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP2ZP-0006EK-9B; Wed, 24 Mar 2021 12:25:07 +0000 Received: by outflank-mailman (input) for mailman id 100967; Wed, 24 Mar 2021 12:25:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP2ZN-0006Dk-Rb for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 12:25:05 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 803603d3-e5c7-45cd-9953-f8da25e04c05; Wed, 24 Mar 2021 12:25:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 803603d3-e5c7-45cd-9953-f8da25e04c05 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616588704; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=wp0RccVI1tCqlieLeZR40m+vQPb4oS3BJx8bkuHZwN0=; b=OPMde0qDQ22eE51UOJMqKXSPtmQfGPaAsr8J5yMZ/X4iUcTLYj8cRyWA 7ZmEq2/1fY6MWul/5/guwm6OZBKK9VF7cocvlePsLLM0lBKm5HUsFi0mv a8Mntq/1hdcLZfzutjgQxHW86TZ78hX2H2tLwB0Vt4q8v05qKMwimhgBG k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: sqVs07E0EEn59lR4dpgFyDvoW/AI21j1nNGlncoInsF8Vmnm4xrVcZ8fOcDivPXqUOxwbo5MZJ D0QQ/ss+k5hmK5x4u5m7hMVydbbdJwE4oeWwKOW8bcm0HH/fXUul2wA3ZDquClgqkS/cSixGIo qSDunZ64lDANUU9zT45I0wvLWDst78ZLKLEeFobnD7yO3amGUb4lfiVxqAB9ZrN9Ml59VKPat/ xCgkfPGd7rNl22fZiJcIbt2wJQE5vkEuJOGcOFtLLyaB9TPDl1TEh0FqYpq8749JwOyqSvI/QP Ioo= X-SBRS: 5.2 X-MesageID: 40013687 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:0dEhXq/kXkf2ZH0sauBuk+FdcL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmyybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIUHD38Zn/+ Nbf6B6YeecMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsKV4hLxW5Ce2KmO2dxQxRLAod8KY GV4dBJqyHlVXMcaMm6AXdtZZm+m/TgkpX6bRkaQyM28QXmt0LU1JfWMTi9mi0fXTRG3Ks4/Q H+/TDRy62/v5iAu3nh/kDJ6ZA+oqqC9vJiA4i2htEROnHQjG+TFf9ccpmjmBxwn+218lYtl7 D30mcdFuB+8WnYcG3wgTaF4XiY7B8U53XvyUCVjBLYyKSTLlJKaLsyuatjfhTU8EYmtt1nuZ g7pV6xjJZLEQjG2B30+tmgbWAaqmOPvXEgneQP5kYvNrc2Vbk5l/17wGplVL0EHC789bk9Fv hvAMz29J9tAC2nRkGckW91zNO2WHMvWj+AX0gZo8SQlwNbhXZj0iIjtYAit0ZF0Kh4Z4hP5u zCPKgtvLZSTvUOZaY4IOsaW8O4BkHEXBqkChPcHX3XUIU8f17doZ/+57s4oMuwfoYT8Zc0kJ PdFHtFqG8bYSvVeI2z9awO1iqIbHS2XDzrxM0bzYN+oKfASL3iNjDGYEwykvGnv+4UDqTgKr eOEaMTJ8WmAXrlGI5P0QG7cYJVM2MiXMocvct+dEmJpu7NN432ps3WePveP9PWYHQZc1K6Jk FGcCn4Jc1G4EzucGT/mgLtV3TkfVG63Z8YKtmew8EjjKw2cqFcuAkcjlq0ouuRLydZj6AwdE xiZJfukqaxo3iK7X/Fhl8ZfiZ1PwJw2vHNQnlKrQgFPwffarAYoeiSfmhUwT+hKgJgSdjVVC pSvU5+967yD5H4/1FtN/uXdkahy1cDrnODSJkR3oeZ493+R58+BpE6HIprFQvKEBRxsR1wqH hKbTIFQkO3LEKstYyVyLgvQM3Pfdh1hwmmZeROr2jEiEmarcYzAkcAUyWWSs6RiwY2Tz9yjl l8mpVvx4aoqHKKEy8Ske44OFpDZCCyDKhdBAqIXolSh4vmYRp9V2uMmDychSwiY2aCzTRguk XRaQmvPd3bCFtUvX5Vlpzn9155bU2xVUN9YHISi/w3KU32/lJIlcObbKu61GWcLmYYyuYGKT fffH85OQV13e260xaThRePHXgr3Y8VI+TYFbgvGoujnE+FGcmtr+UrDvVU9JFqOJTSqecNS/ uYYBLQAzXiCe8lsjbl0EoNCW1Rkj0Dnvzp0hG+szT98347HPbIIFNpA5scOMqR6mD4R/COlL V15OhFydeYAyHUUJqhz6qSUhtobjX0ikSyR/szqZ9Vsbkp3YEDV6XzYH/t7jV/wB46LM3Ij0 sQT6Rw3aDZNuZUDrkvUhMc2mBsqc+GI0QquDHnG+MSfVkiiHnAItOCioC43oYHMwmkrAv0NU L3yVwkw971Gw+C36UdEaQ+PCB/b1U98m1r+Iq5BsftITTvU+FI51yhNHChNJdbVaieAL0V6j J3+cuBkePSVy323mnrzHZGC5ML12asWsWpBg2QXcZO7tyhIFyJxpKQ3/Tbtka/dRKLL2IChY NEckQMbsNMzhka5bdHrRSae+jQuUIqk1xX/Dd9sEXis7LWuVvmIQ== X-IronPort-AV: E=Sophos;i="5.81,274,1610427600"; d="scan'208";a="40013687" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fdIfxwYL/lKgra8DNRwBZyo6OQ1yO0rASDgObqnqMDBlLAw0sjCG1n7PRzCvsvSKhPnTW1LbgJSz/CDo9jsrTXUruyhrUQcRJa7gP4DFgrR2g4Fu/DOSNrEJ288Q12SVaA7/z/2Pdx6yh7dk46s7fPqQYGXpfge7xkSU1SoD2Mb2PziYyEE2TRPC5To2aKs4E8GVCdSfOn/xsrbZabNQhbMqUpFvc6ud4j9PqE5gFCAPLjeCJx9Vfb/xAZxNfU9jXRIhrKFHjLIXWy8by6p6YyopillHsBZswIzZcgrYuC2HB8FVZIKJKQlQFRbFDifSffq4vmjrRvyFKULB8enuJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sdo8EeuM+xU2F1GMX+fxj8Mg5M4tPEbvnO/5QsPd9n8=; b=YFGANHNtSIEyWnTX1nOTT3mgQxuVezSMsoaPLNTZNC2pvwrSMpsJ6rFlkUE1ty+67WwpEd9a6S9aqWpEmVwSXiRMXfimG5SxmvKtELpTuBZmwdjGHrbTNdjfpzHz08vqBC0VdqLrVV4iZFI817av90ImpQeBZT8DJS0JC22jo2Ll7+b4Q0N26f/RE4OUaLCsCTI0KZs72uqmnrsXtZN30A/pabqyoavFeNT6Hzlx1/97NiejMXPKkcFaN5i52WYrj6OhZB2ez1TFpdVyPrpTFovGs2u2VpN1fxinP3lSfc7LAReHrakXOsrOfb9dqWSHTjrbNlkEk/xzkpXFQXAbAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sdo8EeuM+xU2F1GMX+fxj8Mg5M4tPEbvnO/5QsPd9n8=; b=ZR4Zy2yL8jOfVsterZDX6ZQiBpB/rdBqAGl3Qn3SudMrrQgBU09PEaz64CXpMp7QOn3WtZb3VBBmaDsaHS1mlT+PhCxU+5Mjv2oLGc3fUBkPkgkDEUEkiaV4ZYPd5NNJ+h8WPwIWlmoyPghfx6cNDr/fc3t9juRBOGwwzZcQzyM= From: Roger Pau Monne To: CC: Roger Pau Monne , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Jan Beulich , Subject: [PATCH v2 1/2] xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on MEMORY_HOTPLUG Date: Wed, 24 Mar 2021 13:24:23 +0100 Message-ID: <20210324122424.58685-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210324122424.58685-1-roger.pau@citrix.com> References: <20210324122424.58685-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0134.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::26) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 40e8dc49-e1dd-4196-1c55-08d8eebfcc38 X-MS-TrafficTypeDiagnostic: DM4PR03MB5965: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /zk0RPRwfPmSiYWmJP+BFuw2yj3aI6Kk69sYTjhLmkpTuNKnWXm5R77ww1StA2MvmP+6N0HlS1mECBVFsK3nplJlsur8yVQKK7Cvct5ZYuSzQLeAVW72nTB6tlhTL7gdENa/aoMc5k/++fE+n7YfmThIAiNCflT1AIT1IghH8kEPL1MyEWL90vf/bsu4WCHLcdfEL9yi7pGKGVDulB3NBBJkE2ky9wRMVk4PFa4bD5CaRcfVLZ2GbI4o/6CStk+kcBBiGBphNk3BJexxTBPjcUMBK2oQnQZ6FwvpdF5lW4XVLetkvcJcB+zzjVXjuqpatCwxbMitUTBChtLFIWeJZam72pWuihIl1wQM7nk6k2VUqEEnWjxaZLKapRaGVeTpTgaA7LibV2x1cEzaE0d8oWi1+Bty/yXAjrxa0Bsd10s+ZwdQC/W9xx6KP20zK/vs90gNkNh4aZGra3VFRvfYfqFwLC5YAwjGOtEiBWE11WT3Kg892yrmvS7Ljibiv+PIg/FpF9OCI5/0UMO+BIUkWUopuTbh5a9rnax6F0On4+XKk5j9KR4jxG/oubLLtgRoppVA0I+yzrhYtp+hBHmk1iBdMzUYxjqbPzKXzUuJPwGAdNgGeR3webH5QGfQ+pHCfRLFnjjp1Is+s+hFZ5TAEg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(396003)(346002)(39860400002)(366004)(956004)(66946007)(2616005)(83380400001)(16526019)(1076003)(6486002)(8676002)(5660300002)(8936002)(478600001)(6496006)(36756003)(66556008)(2906002)(66476007)(6666004)(86362001)(38100700001)(316002)(54906003)(26005)(6916009)(4326008)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?OTFqYnZSd29saHErejd1dGZpVDhVQ2RFS2dRaHNSS2hxV3hYR3h4NjJpcHdT?= =?utf-8?B?ak1aWHcrVHBGbkxQR1JpdklQMytrNytqSGEwUXE0TXhLbm9MMnFYWGNUM05Q?= =?utf-8?B?cHNOR1ppRkdjQ211UzB0N3ZJdExwT1BnQ0ZldnluKzZvZVZobEltZTl1N0hL?= =?utf-8?B?dGlncTAxNHY3aGxZUGRlOHBNQjlhSks3UnY0VGI2OHRObEJSTjFuUmJ5QW02?= =?utf-8?B?bFhJMEpDY0RTTmpDWnhxMTZ1NHg5elNNak9zekZROS9SZDkxVTZ6NDM4NGdK?= =?utf-8?B?Y055MkNsbElBa2RJZldrbnBNUy9NQzFwQUFKU2tkMEdhZGhwV0E0Yk5tdEdl?= =?utf-8?B?WUhFMHpZa3FrWGJmL3ROcTNMMnlQa0tiSHlrMDZHNHcxRHRONTdGUXJyTXR3?= =?utf-8?B?TWJDQ3I5emdDMDlIOUtRVTIxMk9zbmFUWldaWFY1ejhlTTNic3lhZXZBdjhq?= =?utf-8?B?MmxFb0NpelFpOWRQZGdKeWZ3d0E3M01HT21pcHZXRXBFQTVPY01YVlJjVHFR?= =?utf-8?B?Vm1XYTJKUHlYRXdBR0dLQ2VWc2pGUWttRTJJMDE5NTd4UVlObFRIKzd2WU1B?= =?utf-8?B?VzVRUStCYUx3VkVPUk1CdTR0UlRwQkV5SGxzOEJzbHRIU25kdlJoLzAyQWRz?= =?utf-8?B?UmwybHNKYUpQMnM5Q2lwMjg1WW15NW04UlZrTE9rUXJrVENwUUp5VytUYVhi?= =?utf-8?B?aU5DNDA3VGxZY0tiVWJEb0RwV0V1d3NtQjU3b2ZKbzdMZlZRZGl5UDQ4QnY2?= =?utf-8?B?eGQ1eThtTUVhdkZlZFJHdUM4eERwdGdFdU5IVWZWOURjaS9kVWhwOFVORDhS?= =?utf-8?B?L0Y2eHpxVXh0SUE5Wk5vQTdLYWVuZXpXN3FFMUVQOEw3SmhmRVFDUEpoNlcw?= =?utf-8?B?bU5JWTZZekI3Q1BmaEN5OHFld0lOMzFhQjVUUkNydVFwUkx6U2g4TVZET09v?= =?utf-8?B?VGRlU0ltU2x4OElFQzY2NWFrdFcyK3VHVDRFWEJ5NXFPWTBhSEhVRjBVck4r?= =?utf-8?B?djJxOE9tWmJmR2YwaS9McnVNSVBtdlNuVlE3bXpzd2c5TmxFQmtPTmRuaHZQ?= =?utf-8?B?dXd3QTI5enpzZE9BdUdEampua0psRE5SNGpKcnlkZmhlRkZKTjdOZ1BtSmt3?= =?utf-8?B?a09raCsvSjJoYWIyU2JtNjZjeTFMY0xOb2JObFFtUEQ0TmhYSXhsK1MzRkhY?= =?utf-8?B?WDRLc2ZhTzdsMlZScHBqS28yNHNMQXFrRGtrOE56MDNoc2hjTHRMVDFLazlW?= =?utf-8?B?eHRVUFZZMzJMaVhNelc2K20rNGtRSjQ2bzJQL3NkRE1lTWM1WjlNL0VLdnk2?= =?utf-8?B?L05Ic05GREtrVXZ6NE5vVTI3UmxxV1UvcUJObVNGc2dhRGhJWExYUFlWVU96?= =?utf-8?B?YjQzVEtXS3BVb0RnMmxNejBBVWFnL3lMbExSaWhvVTZjZjJVWVV1SGluNW13?= =?utf-8?B?T0c5K29Wa20xZGVNNG16b0h1emdhM1BxOUxjRVpuaWxydTA2SExqZXpucU5h?= =?utf-8?B?djJMeDRnTGJ0M3lYMXBnVTFHQTVtOHQza1BvM2R3aFJ1S0Ric2tZSHVQNERs?= =?utf-8?B?VmM2NTBINVFnOWdreHBRZDhhakJDY3dQY3A4dytHL0EvcXU0M1dwYTRiMkpa?= =?utf-8?B?T0llTC84Y1lmVE9NYkFIOW03WVRmb2JiTk9vWXZ1UUZqRFhRY2M1Tm9jZmJM?= =?utf-8?B?OWgzbTBMbFBEV1kwRUttQlJlNFlzZkYwcUY0TVpHd2JvZ3dTbE1KZHVoc3Bq?= =?utf-8?Q?ImhBQZcq4+Ld3NYd9vbyjiB5R35b7dStGF+5RHP?= X-MS-Exchange-CrossTenant-Network-Message-Id: 40e8dc49-e1dd-4196-1c55-08d8eebfcc38 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 12:24:40.7678 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GhYMFO0dwCD17xrEJ/fktUxRJIohPJCyiKRD8Wsear2FPSIGwYog/+C2ueVDTLgXTLzx2I13HSJsR0yLo4RCAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5965 X-OriginatorOrg: citrix.com The Xen memory hotplug limit should depend on the memory hotplug generic option, rather than the Xen balloon configuration. It's possible to have a kernel with generic memory hotplug enabled, but without Xen balloon enabled, at which point memory hotplug won't work correctly due to the size limitation of the p2m. Rename the option to XEN_MEMORY_HOTPLUG_LIMIT since it's no longer tied to ballooning. Fixes: 9e2369c06c8a18 ("xen: add helpers to allocate unpopulated memory") Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Jan Beulich Cc: xen-devel@lists.xenproject.org --- arch/x86/xen/p2m.c | 4 ++-- drivers/xen/Kconfig | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c index 17d80f751fcb..a33902d05e45 100644 --- a/arch/x86/xen/p2m.c +++ b/arch/x86/xen/p2m.c @@ -98,8 +98,8 @@ EXPORT_SYMBOL_GPL(xen_p2m_size); unsigned long xen_max_p2m_pfn __read_mostly; EXPORT_SYMBOL_GPL(xen_max_p2m_pfn); -#ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG_LIMIT -#define P2M_LIMIT CONFIG_XEN_BALLOON_MEMORY_HOTPLUG_LIMIT +#ifdef CONFIG_XEN_MEMORY_HOTPLUG_LIMIT +#define P2M_LIMIT CONFIG_XEN_MEMORY_HOTPLUG_LIMIT #else #define P2M_LIMIT 0 #endif diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index 41645fe6ad48..ea0efd290c37 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -50,11 +50,11 @@ config XEN_BALLOON_MEMORY_HOTPLUG SUBSYSTEM=="memory", ACTION=="add", RUN+="/bin/sh -c '[ -f /sys$devpath/state ] && echo online > /sys$devpath/state'" -config XEN_BALLOON_MEMORY_HOTPLUG_LIMIT +config XEN_MEMORY_HOTPLUG_LIMIT int "Hotplugged memory limit (in GiB) for a PV guest" default 512 depends on XEN_HAVE_PVMMU - depends on XEN_BALLOON_MEMORY_HOTPLUG + depends on MEMORY_HOTPLUG help Maxmium amount of memory (in GiB) that a PV guest can be expanded to when using memory hotplug. -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 12:32:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 12:32:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100977.192745 (Exim 4.92) (envelope-from ) id 1lP2g8-0007K3-5W; Wed, 24 Mar 2021 12:32:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100977.192745; Wed, 24 Mar 2021 12:32:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP2g8-0007Jw-2K; Wed, 24 Mar 2021 12:32:04 +0000 Received: by outflank-mailman (input) for mailman id 100977; Wed, 24 Mar 2021 12:32:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP2g5-0007Jr-Vz for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 12:32:02 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 23fcc9b2-0187-4fec-a75a-4561bb1f131c; Wed, 24 Mar 2021 12:32:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23fcc9b2-0187-4fec-a75a-4561bb1f131c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616589120; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=R4gkis194kilftpQstf9rZL9/bcNSgw//ydipzRXofk=; b=Sh00lpc788MCSytamy/RnLUPpI4lSQXVpR8dGoBHniD0DFaolCgv0qhz dSNijZBzJkPJBkZdcPKDXpDvwb4qVlLDeHSx03cTdOK9fyXn66YLOLHso hE3Xvgm04g7DxHouDlaRKhPBbMyXbAN0G/Czda8N8li894Il/k28dM+xz 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: YvE/SYBQjZkmiLZVR/s9RWc1wp0hPbnz1mMDbt7SupI7cYiHIMeRb1MFVLD7rBDO/rz1jL7fzR JFdw6HovvlLqbNLqkQQZ/oi9hvbLDEwk/BzFTN/0fJR/etdBtb3TUwfpM0j0k3OVTDOOiGFyjQ WTos7uIbE03rXG9TnoOeoep+aj90Wc69s0JBlPs24eUUYMzIOwfC1J8Pi2FFGiIG0v4MtItG2u di1ABYmmkntoPY3bCjKcXQvr1yh/Ov60NxoYkJ5ZTkE/C2FUKuhe6Yrb5JEFzc1DFO6YDIRhcH 55g= X-SBRS: 5.2 X-MesageID: 40164727 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Zt6Y4qHcc/kVw6ZYpLqFDJTXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7Lk/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeNJwTXzcQY76 tpdsFFZeHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLD1CQYsI1XYcNi+wFEpqSA5aQacjHJ 2H6cZd4xamc3IbbsO0b0N1JdTrjdvNiZ7gfFo6FwcqgTP+9g+AxZzbN1yj3hkYWy5S2rtKyw b4uiHw+6nLiYDc9jbyzGnWhq4m+ufJ7vtmKIiyhtMOKjPq4zzYGrhJf7GZpjg6rKWOxT8R4a DxiiwtNchy9H/dF1vdyXCGu3iCoUYTwkTv1EOChj/bqdH5LQhKdPZpv55TcRfS9iMbzbZB+Z 9Mtljp0qZ/PFfrmSTw4MXwTBd6lka4impKq59us1VvFaQZc7NftooZ4Qd8F4oBBjvz7MQdHP BpF9y03ocdTXqqK1Ti+kV/yt2lWXo+Wj+AX0g5o8SQlxxbhmpwwUc0zNEW901wua4Vet1h3a DpI65onLZBQos9dqRmHtoMRsOxFyjkXQ/MGHj6GyWoKIg3f1b277Ln6rQ84++nPLYSyoEppZ jHWFRE8UYvZkPVD9GU1pEjyGGDfEyNGRDWju1O7ZlwvbPxAJDxNzeYdVwom8y859oFBMn2XO uyJYJ2D/fvIXCGI/cI4yTOH71pbVUOWswcvdg2H3iUpNjQF4HsvuvHNNbfTYCdUgoMayfaOD 8uTTLzLMJP4gSAQXnjmiXcXHvrZwja9ZJ0G67KwvgLxOE2R89xmzlQrW78ytCAKDVEvKBzVl B5OqnbnqSyonTz2mrU8WNzOF54AlxO6LvtF1NGzDV6f3/cQPImgZGyaGpS1HyIKltUVMXNCj NSoFxx5OaQNJyfxScrDvq9KWKEh34vpHaHJq1s25Gr1IPAQNcVH5wmUKt+GUHgDBpugztnr2 9FdUs5XEPFLyjvjq+klZQQI+nae7BH8UKWCP8RjUiamVSXpMkpSHdeezK1S8aYjTwjQCduik Rr/7USh6eBnjiTOXIy6d5IQWFkWSCyOvZrHQ6FbIJblvTQdAZ8QXyjqBaahxswE1Cavnk6ty jEF2m5aPvLCl1StjRkya7s6kpzbXjYVVl3cGpGvYp0Ennmtn5/3fSQXLe613KcZzI5s6UgGQ CARQFXDhJlxtix2hLQpS2LEm8+wI4yesPaF7YuftjoqweQAbzNsZtDOfBa/Jxobo+z9sAKVP +SYA+TInfTDfgz1wmcu3YiP21VpRAf4IHV8SygyFL9+ng1Rcf2ChBBYZowJtmH9WjqR/qSyv xC/KQIlNr1Fl+0U8KMzKHcUiVKJRzSq1OnVu1Ak+EmgYsC8J9IW6TBWTTG1Ht7zAwzAcf9mk QZWrl66tn6S/pSVv1XXypY+1Yz/e7/VHcDg0jTAuUke0sqgGKeF9SV46DQob5HODzImCLAfX 2e+TZa5fHLQm+q0qMbEbs5JSBzZFIn4HpvuMOEeIu4MnTgS8hzuH67OGS6arlTVeysHqgRtA 9z55WwpNCsHhCIrzz4jH9cOaJB82GuXMO0DkatIIdzgqGHEGXJpLCr7s61hCrwUh2hZS0j9M p4SXA= X-IronPort-AV: E=Sophos;i="5.81,274,1610427600"; d="scan'208";a="40164727" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UgDQOaSsfd3W3qD9htEZcTaPiyPjAN+aVMqunwhtdUzIXAEc1c/F6YeLFjFWYKeFmIMr4erpDIdP/+Z4TDsvaCl1xErXkNshG9re4q6XaJdXwNWMMcI4d4oLGx9QDQRyhnEHyUqOjsTZ/1OERgr6SGEMmgmJMY++ZegwH6z3TLKFMs6G1aPCReLlnxclIKX8RcWK/wts9GSC+HHwD+F0IxpKCxgdTwZ9gurO40Kg+qbjsCW8nPgmQgQZyjI8dYyj8nB51DSLPc7RRZu+6u+3LT8yhsvfrwL7B4mp7W2Ke/vxVHWb9ABCcRbR9uY5hMlL3nWmgr5fu4B6dpjFqhaPog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=POqR+yGlRcp/InBe4dSo99f2+VyBz/rcTmCM4AxG96w=; b=GIiI9WOcFt6E9RLyXnT1fglJ3B9WzlQZUDnrxcu5XITGaMjn1fDEMUjD5ykidavFk7tpb/R9bMIJscUQ4nDpjrYWmHAbOTJ/4Rdjuri47ROG3Hb2JLB7+WhvO0R6NgyAYSh+sHkusdW97V6m3p0FBRjZGJc6tYHGK7MeMJ7YdUS35gVQ71cm/vzcLrQZQztzFRFOufQv4TMTWQabPXXMCPiYyajMkuBjVwEy8VObl55annQlGQEIruqxe1Ok2r/17M2csSxoRHrX6RpKnhyHDrTAgTP7NWXI7fGbDrJBVm9uT9YgoXFxoahYXfsYiTZqybWkEGblzBKeibtSUXq74Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=POqR+yGlRcp/InBe4dSo99f2+VyBz/rcTmCM4AxG96w=; b=mQJ+v9ZlRgcbMPOXMfz9prtuKnnR0rHEneCml8nBCrCe4O+mfRJgRqGwEYKSMUr/5Q1GM8tz1rQATuFiU58hMVhsIb0y3mjU8U131e0PFK95F4/TBT2Niw+EWAX5Ot4hv4BIGUAtn9HqwV86nae1cChJgAr3hSjQDHMfiuZpjzw= From: Roger Pau Monne To: CC: , Roger Pau Monne , Mika Westerberg , Andy Shevchenko , Linus Walleij , Subject: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region Date: Wed, 24 Mar 2021 13:31:18 +0100 Message-ID: <20210324123118.58865-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MRXP264CA0020.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:15::32) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d6d2bac-85c1-4936-e2b7-08d8eec0d031 X-MS-TrafficTypeDiagnostic: DM6PR03MB4539: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j+BTsEOI/Yk7IN6cquruSnNPhksZGXV17HknzSm0EO7b+bvjjc42Q4n/SWTwe+yl1kbI3uze+tywyOREB+ODqGAW+MGtsagVUYvpVsD/GvGwfik7lnM08fMfwLVFcZ2W+LapHqErIDfFXhekQ4bUUJ0gv4gx6N2/y4ZFcAa3OOG72UYc+xcsQvPIz0FXXqFWNJdKrSoOhrnaYxt0plFn7XN8RWdWV+XUB8prACktKIwFSdUT0eTgmm7kzvyl0ZrsgxFSEIpTnV4ZKZPzls6o4Y73pigfzEtLQj+J/sT/X1bTJWlyTjA7axSAq6hqGRw6HUF3U/zApU5MP5vpIQZbtNbkyCTo7Gs0ffTU8VnhXHFHBNxzO7A4n0EFs0YkTD9Zf+AXZgCxOVURGLvDuKp/jwRJRbChRljhtbmzQ+Aa9HIXlrLnzWE5Vvya1zGqaRXYcLOMiUYodNG0Cl+xj1Lz6hjkotZmi0M5IOmPIR5Hr1PsIdIPXYNWpxoNs3a6Cr2gO3idHkwguIV6/ol0A6wV7KV+8u8mEEm/k6Tj5hGawfixnk0vpBC+TKaetiNJcEKYrjwsUtWO9+TG1EODlSYOfFUfTnEyrZWT8qAZqEOj4tKq47NenWHJl+asi8doezpSNDFOItGiClYPkZyYHGI44bTZBP5b1snHxBZY/5qlme4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(396003)(366004)(136003)(346002)(376002)(83380400001)(6666004)(2906002)(186003)(86362001)(4326008)(5660300002)(26005)(54906003)(36756003)(38100700001)(1076003)(316002)(16526019)(8676002)(2616005)(6486002)(66476007)(6916009)(66946007)(956004)(8936002)(66556008)(478600001)(6496006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MFhWZFZIUXduOVVYTlZVcjZjcFl3cWxLSWdBQVFHcUtsTWE0bzlVbDVBVmd2?= =?utf-8?B?MUJGclZISkI4eHpKOGsvTG9lNXhCRU0xb3hTR2VJaHlNMjUwN2tzcUxTS1l1?= =?utf-8?B?VGlXMDMzUTU4d0VvZWhOSm1SdlkvRlBlQ0VibEpiaHJPUmdCdGlTZ3oxT0l0?= =?utf-8?B?Vi83KzV4QlkvaFpjRjFiWmMxTU54ajVmd0IyZUR0M01xTkh4VHJYeDVKcW9V?= =?utf-8?B?U25DcUJRWGIrRzVsMHM3bjlFeEhoUExIUzhBWHJJKzNNc1V1aFFtaHdJSDJI?= =?utf-8?B?aWxPSzQ1bGJncFExa3FRdk9tTXZQb3RuWFhQWWlsN1JGUXo2eVVJSkI3SWlx?= =?utf-8?B?bnpvU1VIbjRTWkhxZXdYRHd4OWhrSE5FQ3Bid3JIem5lenp3ZXpLVDhjU2Nx?= =?utf-8?B?S0JrRWdCNEdNWXB0b2dBWWc3U0FoYnZPaG9ZQUVJYWlnQVU2UDk1cWdtcmx0?= =?utf-8?B?YytDOVdVQ1ZYdjlVL0dCNkkyTmo0Ry81NXJHQXVxYyt0aC9xcmxhUEJYVzM5?= =?utf-8?B?Z1NISnRkWlNwNTlaS0NsU1UvRjNVMEZZa21HemwveVpoSzZYSC9PUjNCSnJ0?= =?utf-8?B?Sm04ZUZka0FGUUg2ZWpRanZkSjJ5YllKR2NHNDN0YVVuZDlTaERTOGFIdVox?= =?utf-8?B?R0pmMGlxTU5QVjB4MVQ2eVAwbDRJNkc5K2FvZllTbVdRSnVFeStFYTc5NVZC?= =?utf-8?B?U1gwSE5RMDAvQS9uY3NpLy9PU1ArekdmeGRRT0hVOU5vRGRQeTNQYytCMnlo?= =?utf-8?B?ejlzaWIvUExobzhoSXMrbDlHdzVIYXo5R0dEdDZaa2dKdjJWK2xTeEYzaWxk?= =?utf-8?B?WlJrYjNneVZUem1wcVZ2Qm9SaTJ4OTFNZEZXV3JpOFpINnpaTUNZaXM2NFNK?= =?utf-8?B?Zm05Wit6cWx0ZUxZeUdwNkJPOENBWUNMMFZVOWl0ekNiRjgzUHcvbzdoRS9Z?= =?utf-8?B?c2JOalZrOXFCVmQ4SWFSM2FmeU1TZ2taWFlzZnIvTG1ySExWMGxuVDkySHV5?= =?utf-8?B?RmN3bHB3Y1FWU0EydU1oOHRBOHlPenNidThkcUVkdUlwT0ZFWWwzV3poNlFr?= =?utf-8?B?N3hMYkRWM3B2OEEzbGRVZWpoY3VPRUFrYUpuUDB1MXZQYTRyQ0xDbHFsQmI1?= =?utf-8?B?SHRPVmIvSGtNWlJ3NDNvZGYyYzRCZUsvRGVlM1gyaHFCZlpCUVl4bit3bmpV?= =?utf-8?B?YXV0Z1Y1ZFpudWF4dUNwRHdCU0F3S2F1UmhKZlQwbDdJL2xaWjMybEpraDFz?= =?utf-8?B?Q3FpV3RwOGlidnRqRG9ITnFzNWVOWnFicmRUalRJQm1FRHJOWHpSbmFILzBU?= =?utf-8?B?NUFsdUE1akJVSE5zbk54T3BnSTB3UXB1RzJsY0xja0hUYXk5RkNvRGNnSHU3?= =?utf-8?B?N2Nkc3g5NTUrK3FUUHcrMytvbzRhZ0ZiT0lhSE1ia0hwVEkxTlpSOUtFdkZE?= =?utf-8?B?Wk1oUTBhTEUxQ0NJU1JRTjhWdFM2TS9zcXVyeUlUMjhwS091eVAzKzFUeVR2?= =?utf-8?B?dUM0WWdmbGtkenN0LzFLRjhCUzhKT1NVSTJ2Y1BXNkRLNTVycTJjMmJ5Y21y?= =?utf-8?B?Wm5FNk1wTEFwWHVJeDM1UHVYeTVtZjlHWUJmWUFqNkt3d3luS2dKQ2t6Qmlh?= =?utf-8?B?RmR5N1UrUE9HMzFxVW51WkUvZWNZRFg5UnVkd0EzbEZIZDlmNXJkSXQxZ3Bp?= =?utf-8?B?cEFCeFpnbGE2ekY2MlBGODJvaGNTcGxETURlQmpHVzBSWjBXNmJncTNpajBH?= =?utf-8?Q?dwWuqF53Nx1KqR31R509HT/VO6cxnUhWg64C58X?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0d6d2bac-85c1-4936-e2b7-08d8eec0d031 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 12:31:56.9097 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V9oFOlKY/6NeDTSIPMKZLXlX8D16tgYJIzZHHVecf9LrQBWW8SNfRGewzeZ3cvbb41RFCMB1t7YbRcy7UCZj+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4539 X-OriginatorOrg: citrix.com When parsing the capability list make sure the offset is between the MMIO region mapped in 'regs', or else the kernel hits a page fault. This fault has been seen when running as a Xen PVH dom0, which doesn't have the MMIO regions mapped into the domain physical memory map, despite having the device reported in the ACPI DSDT table. This results in reporting a capability offset of 0xffff (because the kernel is accessing unpopulated memory), and such offset is outside of the mapped region. Adding the check is harmless, and prevents buggy or broken systems from crashing the kernel if the MMIO region is not properly reported. Fixes: 91d898e51e60 ('pinctrl: intel: Convert capability list to features') Signed-off-by: Roger Pau Monné --- Cc: Mika Westerberg Cc: Andy Shevchenko Cc: Linus Walleij Cc: linux-gpio@vger.kernel.org --- Resend because I've missed adding the maintainers, sorry for the spam. --- drivers/pinctrl/intel/pinctrl-intel.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index 8085782cd8f9..bc8b990d8021 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1481,16 +1481,22 @@ static int intel_pinctrl_probe(struct platform_device *pdev, for (i = 0; i < pctrl->ncommunities; i++) { struct intel_community *community = &pctrl->communities[i]; + struct resource *res; void __iomem *regs; + size_t size; u32 offset; u32 value; *community = pctrl->soc->communities[i]; - regs = devm_platform_ioremap_resource(pdev, community->barno); + regs = devm_platform_get_and_ioremap_resource(pdev, + community->barno, + &res); if (IS_ERR(regs)) return PTR_ERR(regs); + size = res->end - res->start; + /* Determine community features based on the revision */ value = readl(regs + REVID); if (((value & REVID_MASK) >> REVID_SHIFT) >= 0x94) { @@ -1519,6 +1525,12 @@ static int intel_pinctrl_probe(struct platform_device *pdev, break; } offset = (value & CAPLIST_NEXT_MASK) >> CAPLIST_NEXT_SHIFT; + if (offset >= size) { + dev_err(&pdev->dev, + "wrong capability offset: %#x\n", + offset); + return -ENOENT; + } } while (offset); dev_dbg(&pdev->dev, "Community%d features: %#08x\n", i, community->features); -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 12:40:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 12:40:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100983.192757 (Exim 4.92) (envelope-from ) id 1lP2nh-0007fy-3V; Wed, 24 Mar 2021 12:39:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100983.192757; Wed, 24 Mar 2021 12:39:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP2nh-0007fr-0O; Wed, 24 Mar 2021 12:39:53 +0000 Received: by outflank-mailman (input) for mailman id 100983; Wed, 24 Mar 2021 12:39:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP2ng-0007fk-95 for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 12:39:52 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 184b7ed3-510b-4ceb-90fb-a53fee583e66; Wed, 24 Mar 2021 12:39:50 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E76ADAB8A; Wed, 24 Mar 2021 12:39:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 184b7ed3-510b-4ceb-90fb-a53fee583e66 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616589590; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oYu8+J3fSRjtZy4WyLNOzW1Ncx/3pJsJfPxBiYP8hzM=; b=o2mIh2EGkWEtMEQxVgzrrX2uM6MObLxCBLpLuWep51EdzSKnwfrVEl9TwH/ZqG7sS9g3zL h0zbT5m7PLaa9G7m5BiSoYlY3oc6DJ5nNkziNEoAl9iqhibExsjF+TXLkFpyIZNX0DToaI sz4S4JG6LxAO2IIOm/nHmbLxKtxrFwg= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH-for-4.15 v3] tools/libs/store: tidy up libxenstore interface Date: Wed, 24 Mar 2021 13:39:48 +0100 Message-Id: <20210324123948.7207-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xenstore_lib.h is in need to be tidied up a little bit: - the definition of struct xs_tdb_record_hdr shouldn't be here - some symbols are not namespaced correctly - the layout of a structure with an enum inside it depends on the implementation of the compiler Signed-off-by: Juergen Gross --- V2: minimal variant (Ian Jackson) V3: replace enum with unsigned int (Andrew Cooper) --- tools/include/xenstore_lib.h | 37 +++++++++++--------------------- tools/libs/store/libxenstore.map | 6 +++--- tools/libs/store/xs.c | 12 +++++------ tools/xenstore/utils.h | 11 ++++++++++ tools/xenstore/xenstore_client.c | 12 +++++------ tools/xenstore/xenstored_core.c | 16 +++++++------- tools/xenstore/xenstored_core.h | 8 +++---- tools/xenstore/xenstored_watch.c | 2 +- tools/xenstore/xs_tdb_dump.c | 2 +- 9 files changed, 52 insertions(+), 54 deletions(-) diff --git a/tools/include/xenstore_lib.h b/tools/include/xenstore_lib.h index 4c9b6d1685..fdf8752b16 100644 --- a/tools/include/xenstore_lib.h +++ b/tools/include/xenstore_lib.h @@ -26,30 +26,17 @@ #include #include -/* Bitmask of permissions. */ -enum xs_perm_type { - XS_PERM_NONE = 0, - XS_PERM_READ = 1, - XS_PERM_WRITE = 2, - /* Internal use. */ - XS_PERM_ENOENT_OK = 4, - XS_PERM_OWNER = 8, - XS_PERM_IGNORE = 16, -}; - struct xs_permissions { unsigned int id; - enum xs_perm_type perms; -}; - -/* Header of the node record in tdb. */ -struct xs_tdb_record_hdr { - uint64_t generation; - uint32_t num_perms; - uint32_t datalen; - uint32_t childlen; - struct xs_permissions perms[0]; + unsigned int perms; /* Bitmask of permissions. */ +#define XS_PERM_NONE 0x00 +#define XS_PERM_READ 0x01 +#define XS_PERM_WRITE 0x02 + /* Internal use. */ +#define XS_PERM_ENOENT_OK 0x04 +#define XS_PERM_OWNER 0x08 +#define XS_PERM_IGNORE 0x10 }; /* Each 10 bits takes ~ 3 digits, plus one, plus one for nul terminator. */ @@ -78,18 +65,18 @@ bool xs_perm_to_string(const struct xs_permissions *perm, unsigned int xs_count_strings(const char *strings, unsigned int len); /* Sanitising (quoting) possibly-binary strings. */ -struct expanding_buffer { +struct xs_expanding_buffer { char *buf; int avail; }; /* Ensure that given expanding buffer has at least min_avail characters. */ -char *expanding_buffer_ensure(struct expanding_buffer *, int min_avail); +char *xs_expanding_buffer_ensure(struct xs_expanding_buffer *, int min_avail); /* sanitise_value() may return NULL if malloc fails. */ -char *sanitise_value(struct expanding_buffer *, const char *val, unsigned len); +char *xs_sanitise_value(struct xs_expanding_buffer *, const char *val, unsigned len); /* *out_len_r on entry is ignored; out must be at least strlen(in)+1 bytes. */ -void unsanitise_value(char *out, unsigned *out_len_r, const char *in); +void xs_unsanitise_value(char *out, unsigned *out_len_r, const char *in); #endif /* XENSTORE_LIB_H */ diff --git a/tools/libs/store/libxenstore.map b/tools/libs/store/libxenstore.map index 9854305a2c..fc1c213f13 100644 --- a/tools/libs/store/libxenstore.map +++ b/tools/libs/store/libxenstore.map @@ -42,8 +42,8 @@ VERS_3.0.3 { xs_strings_to_perms; xs_perm_to_string; xs_count_strings; - expanding_buffer_ensure; - sanitise_value; - unsanitise_value; + xs_expanding_buffer_ensure; + xs_sanitise_value; + xs_unsanitise_value; local: *; /* Do not expose anything by default */ }; diff --git a/tools/libs/store/xs.c b/tools/libs/store/xs.c index c91377c27f..109ea16d1e 100644 --- a/tools/libs/store/xs.c +++ b/tools/libs/store/xs.c @@ -1358,7 +1358,7 @@ static void *read_thread(void *arg) } #endif -char *expanding_buffer_ensure(struct expanding_buffer *ebuf, int min_avail) +char *xs_expanding_buffer_ensure(struct xs_expanding_buffer *ebuf, int min_avail) { int want; char *got; @@ -1379,8 +1379,8 @@ char *expanding_buffer_ensure(struct expanding_buffer *ebuf, int min_avail) return ebuf->buf; } -char *sanitise_value(struct expanding_buffer *ebuf, - const char *val, unsigned len) +char *xs_sanitise_value(struct xs_expanding_buffer *ebuf, + const char *val, unsigned len) { int used, remain, c; unsigned char *ip; @@ -1394,7 +1394,7 @@ char *sanitise_value(struct expanding_buffer *ebuf, used = 0; remain = len; - if (!expanding_buffer_ensure(ebuf, remain + 1)) + if (!xs_expanding_buffer_ensure(ebuf, remain + 1)) return NULL; while (remain-- > 0) { @@ -1405,7 +1405,7 @@ char *sanitise_value(struct expanding_buffer *ebuf, continue; } - if (!expanding_buffer_ensure(ebuf, used + remain + 5)) + if (!xs_expanding_buffer_ensure(ebuf, used + remain + 5)) /* for "\\nnn\0" */ return 0; @@ -1429,7 +1429,7 @@ char *sanitise_value(struct expanding_buffer *ebuf, #undef ADDF } -void unsanitise_value(char *out, unsigned *out_len_r, const char *in) +void xs_unsanitise_value(char *out, unsigned *out_len_r, const char *in) { const char *ip; char *op; diff --git a/tools/xenstore/utils.h b/tools/xenstore/utils.h index 87713a8e5d..9d012b97c1 100644 --- a/tools/xenstore/utils.h +++ b/tools/xenstore/utils.h @@ -7,6 +7,17 @@ #include +#include "xenstore_lib.h" + +/* Header of the node record in tdb. */ +struct xs_tdb_record_hdr { + uint64_t generation; + uint32_t num_perms; + uint32_t datalen; + uint32_t childlen; + struct xs_permissions perms[0]; +}; + /* Is A == B ? */ #define streq(a,b) (strcmp((a),(b)) == 0) diff --git a/tools/xenstore/xenstore_client.c b/tools/xenstore/xenstore_client.c index 8015bfe5be..3d9d399e91 100644 --- a/tools/xenstore/xenstore_client.c +++ b/tools/xenstore/xenstore_client.c @@ -40,7 +40,7 @@ enum mode { static char *output_buf = NULL; static int output_pos = 0; -static struct expanding_buffer ebuf; +static struct xs_expanding_buffer ebuf; static int output_size = 0; @@ -203,11 +203,11 @@ static void do_ls(struct xs_handle *h, char *path, int cur_depth, int show_perms if (max_width < (linewid + len + TAG_LEN)) { printf(" = \"%.*s\\...\"", (int)(max_width - TAG_LEN - linewid), - sanitise_value(&ebuf, val, len)); + xs_sanitise_value(&ebuf, val, len)); } else { linewid += printf(" = \"%s\"", - sanitise_value(&ebuf, val, len)); + xs_sanitise_value(&ebuf, val, len)); if (show_perms) { putchar(' '); for (linewid++; @@ -346,7 +346,7 @@ perform(enum mode mode, int optind, int argc, char **argv, struct xs_handle *xsh if (raw) output_raw(val, len); else - output("%s\n", sanitise_value(&ebuf, val, len)); + output("%s\n", xs_sanitise_value(&ebuf, val, len)); free(val); optind++; break; @@ -359,8 +359,8 @@ perform(enum mode mode, int optind, int argc, char **argv, struct xs_handle *xsh val = val_spec; len = strlen(val_spec); } else { - expanding_buffer_ensure(&ebuf, strlen(val_spec)+1); - unsanitise_value(ebuf.buf, &len, val_spec); + xs_expanding_buffer_ensure(&ebuf, strlen(val_spec)+1); + xs_unsanitise_value(ebuf.buf, &len, val_spec); val = ebuf.buf; } if (!xs_write(xsh, xth, argv[optind], val, len)) { diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 8033c1e0eb..244220c5a3 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -542,11 +542,11 @@ static int write_node(struct connection *conn, struct node *node, return write_node_raw(conn, &key, node, no_quota_check); } -enum xs_perm_type perm_for_conn(struct connection *conn, - const struct node_perms *perms) +unsigned int perm_for_conn(struct connection *conn, + const struct node_perms *perms) { unsigned int i; - enum xs_perm_type mask = XS_PERM_READ|XS_PERM_WRITE|XS_PERM_OWNER; + unsigned int mask = XS_PERM_READ | XS_PERM_WRITE | XS_PERM_OWNER; /* Owners and tools get it all... */ if (!domain_is_unprivileged(conn) || perms->p[0].id == conn->id @@ -584,7 +584,7 @@ char *get_parent(const void *ctx, const char *node) * Temporary memory allocations are done with ctx. */ static int ask_parents(struct connection *conn, const void *ctx, - const char *name, enum xs_perm_type *perm) + const char *name, unsigned int *perm) { struct node *node; @@ -619,9 +619,9 @@ static int ask_parents(struct connection *conn, const void *ctx, */ static int errno_from_parents(struct connection *conn, const void *ctx, const char *node, int errnum, - enum xs_perm_type perm) + unsigned int perm) { - enum xs_perm_type parent_perm = XS_PERM_NONE; + unsigned int parent_perm = XS_PERM_NONE; /* We always tell them about memory failures. */ if (errnum == ENOMEM) @@ -641,7 +641,7 @@ static int errno_from_parents(struct connection *conn, const void *ctx, static struct node *get_node(struct connection *conn, const void *ctx, const char *name, - enum xs_perm_type perm) + unsigned int perm) { struct node *node; @@ -873,7 +873,7 @@ static struct node *get_node_canonicalized(struct connection *conn, const void *ctx, const char *name, char **canonical_name, - enum xs_perm_type perm) + unsigned int perm) { char *tmp_name; diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 0c9a0961b5..0b2f88dd4a 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -186,8 +186,8 @@ void send_ack(struct connection *conn, enum xsd_sockmsg_type type); char *canonicalize(struct connection *conn, const void *ctx, const char *node); /* Get access permissions. */ -enum xs_perm_type perm_for_conn(struct connection *conn, - const struct node_perms *perms); +unsigned int perm_for_conn(struct connection *conn, + const struct node_perms *perms); /* Write a node to the tdb data base. */ int write_node_raw(struct connection *conn, TDB_DATA *key, struct node *node, @@ -201,8 +201,8 @@ struct connection *new_connection(connwritefn_t *write, connreadfn_t *read); struct connection *get_connection_by_id(unsigned int conn_id); void check_store(void); void corrupt(struct connection *conn, const char *fmt, ...); -enum xs_perm_type perm_for_conn(struct connection *conn, - const struct node_perms *perms); +unsigned int perm_for_conn(struct connection *conn, + const struct node_perms *perms); /* Is this a valid node name? */ bool is_valid_nodename(const char *node); diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index db89e0141f..aca0a71bad 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -124,7 +124,7 @@ static bool watch_permitted(struct connection *conn, const void *ctx, const char *name, struct node *node, struct node_perms *perms) { - enum xs_perm_type perm; + unsigned int perm; struct node *parent; char *parent_name; diff --git a/tools/xenstore/xs_tdb_dump.c b/tools/xenstore/xs_tdb_dump.c index f74676cf1c..5d2db392b4 100644 --- a/tools/xenstore/xs_tdb_dump.c +++ b/tools/xenstore/xs_tdb_dump.c @@ -17,7 +17,7 @@ static uint32_t total_size(struct xs_tdb_record_hdr *hdr) + hdr->datalen + hdr->childlen; } -static char perm_to_char(enum xs_perm_type perm) +static char perm_to_char(unsigned int perm) { return perm == XS_PERM_READ ? 'r' : perm == XS_PERM_WRITE ? 'w' : -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 12:53:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 12:53:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100987.192769 (Exim 4.92) (envelope-from ) id 1lP313-00010O-BY; Wed, 24 Mar 2021 12:53:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100987.192769; Wed, 24 Mar 2021 12:53:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP313-00010H-8V; Wed, 24 Mar 2021 12:53:41 +0000 Received: by outflank-mailman (input) for mailman id 100987; Wed, 24 Mar 2021 12:53:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP311-00010C-JC for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 12:53:39 +0000 Received: from mail-ot1-x32a.google.com (unknown [2607:f8b0:4864:20::32a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fc768f6e-a891-44dc-a8b0-8bc946f8621a; Wed, 24 Mar 2021 12:53:38 +0000 (UTC) Received: by mail-ot1-x32a.google.com with SMTP id g8-20020a9d6c480000b02901b65ca2432cso22884377otq.3 for ; Wed, 24 Mar 2021 05:53:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc768f6e-a891-44dc-a8b0-8bc946f8621a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=UCAvShrQp1zWABFbmj6neS2t/wJyD0oqgDxv6VR+/ek=; b=rUiEClG6qW/PRRZHOsceOA4FoknTs5jQmVr9LFppHLZFEzdtwuNnBNHmFcpQjF0wr4 vUFlOfamckRqREwSxNf80C6Nfxp4HfeLZfQD7Yp6JQEmTXhZrIhMKS7H6JTiLBzXEHPc CETSwS1Xoec7L6j9TuoXIdE4Pt7hIw0V6eeLkFqUVobR/FpVqWqzZ8HmcpQreD6LfRhI zZXLFyQ1Bsr32OpRD+1E9u/sHJqHJtlV4zlZFXX4MZsayeQWR2HYsfItBOqR/t9BQ3C1 dYKVE8d2+UUqn0mEFtNH86UOg0UJrabVOmD3uRfx21Vf+jIdQC2ZPRgMwzyYScRGTEfE I4Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UCAvShrQp1zWABFbmj6neS2t/wJyD0oqgDxv6VR+/ek=; b=FzrK+1wlss60sE3q5x45PuXRUtOhoUxKq6C36LgPsroql/jf1yz2C8rpNfx5YLqNGQ LU8OfOpWo5YsAiQqLGTlalr9zybS902aVSwwPax5zb+tBy+7Tadem4sz5jshJxcMnftb 0ZmaNfF1SzIFXtgex/iNwgtD6hMnaFnZ7BeqRqrdIRPXW779GVj+Zoa3QlNP7NrO3Dwj Fk49XgAHYD+lm7mJlpH4AHMjrURcImhvSgXFkhZZ2BxHrC63c3G0eljHlUxrVhkGUylX ZTKyuy1NJJmQMnyiXZXPrHQdyxunI5zoNBX0r0gSXip5q10MzmgQ9NAr6z2kptfDDpL9 OLMg== X-Gm-Message-State: AOAM532QdhIEXm4QmkWjGZdcaEbZ+ZZz/x4pNKeDrM/GOfz7mho6S0xg RC133wwZ+X3OMOtnL4ti5CIhx8OFlqYMo7Hxt6E= X-Google-Smtp-Source: ABdhPJzGUco7BQDaj3TFpz1Q+/g0+vP+3xJxvCqgS4PKNkifnB//FnDxTf7/OOeMKBlGFpPqSj5DDs12ZUEle6zUzCE= X-Received: by 2002:a05:6830:4cd:: with SMTP id s13mr3166529otd.78.1616590417898; Wed, 24 Mar 2021 05:53:37 -0700 (PDT) MIME-Version: 1.0 References: <20210316031814.10311-1-dpsmith@apertussolutions.com> <20210316031814.10311-2-dpsmith@apertussolutions.com> In-Reply-To: From: Christopher Clark Date: Wed, 24 Mar 2021 05:53:26 -0700 Message-ID: Subject: Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: "Daniel P. Smith" , xen-devel , Andrew Cooper , Stefano Stabellini , Julien Grall , Julien Grall , iwj@xenproject.org, Wei Liu , George Dunlap , Jan Beulich , Rich Persaud , Bertrand Marquis , luca.fancellu@arm.com, paul@xen.org, Adam Schwalm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 24, 2021 at 1:01 AM Roger Pau Monn=C3=A9 = wrote: > > On Tue, Mar 23, 2021 at 10:39:53AM -0700, Christopher Clark wrote: > > On Thu, Mar 18, 2021 at 9:43 AM Roger Pau Monn=C3=A9 wrote: > > > > > > Just took a quick look at it. > > > > > > On Mon, Mar 15, 2021 at 11:18:13PM -0400, Daniel P. Smith wrote: > > > > + +---------------+-----------+------------+-----------+-----------= --+---------------------+ > > > > + | **Xen Dom0** | **Linux** | **Late** | **Jail** | **Xen** = | **Xen Hyperlaunch** | > > > > + | **(Classic)** | **KVM** | **HW Dom** | **house** | **dom0less= **+---------+-----------+ > > > > + | | | | | = | Static | Dynamic | > > > > + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D= =3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+ > > > > + | Hypervisor able to launch multiple VMs during host boot = | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | | | | Y | Y = | Y | Y | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | Hypervisor supports Static Partitioning = | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | | | | Y | Y = | Y | | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | Able to launch VMs dynamically after host boot = | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | Y | Y | Y* | Y | Y* = | | Y | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | Supports strong isolation between all VMs started at host boot = | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | | | | Y | Y = | Y | Y | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | Enables flexible sequencing of VM start during host boot = | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | | | | | = | Y | Y | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | Prevent all-powerful static root domain being launched at boot = | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | | | | | Y* = | Y | Y | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | Operates without a Highly-privileged management VM (eg. Dom0) = | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | | | Y* | | Y* = | Y | Y | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | Operates without a privileged toolstack VM (Control Domain) = | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | | | | | Y* = | Y | | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | Extensible VM configuration applied before launch of VMs at hos= t boot | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | | | | | = | Y | Y | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | Flexible granular assignment of permissions and functions to VM= s | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | | | | | = | Y | Y | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | Supports extensible VM measurement architecture for DRTM and at= testation | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | | | | | = | Y | Y | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | PCI passthrough configured at host boot = | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > + | | | | | = | Y | Y | > > > > + +---------------+-----------+------------+-----------+-----------= --+---------+-----------+ > > > > > > I'm curious about this, I assume this is done using vPCI so that > > > there's no hardware domain (and user-space device model) involved for > > > PCI passthrough? > > > > That would be an incorrect assumption. See below for why. > > > > > I'm also not sure how you are going to handle things like SR-IOV > > > devices. Right now SR-IOV capability is setup and initialized by the > > > hardware domain, and the new virtual devices are notified to Xen once > > > setup is done. Do you plan to move those bits into Xen, so that it ca= n > > > setup and initialize the SR-IOV capability? > > > > While you could do it with the vPCI, as you point out this will not wor= k > > for SR-IOV. With hyperlaunch, these cases will require the use of a boo= t > > domain, which is for all intents and purposes, a lightweight/restricted > > toolstack domain. > > > > The boot domain will have to do the necessary operations to ensure that > > when startup is finished, PCI passthrough will be successfully setup. > > Note, this may have to include the boot domain unpausing the hardware > > domain to help complete the setup before the boot domain can exit and > > allow the remaining domains to come online. > > OK, I was expecting hyperlaunch to do all domain creation in the > hypervisor. That is my expectation too. It is what we've been planning for in our work so far but we can work on explaining the steps involved in constructing the domains more clearly. > If you offload domain creation of guests with > pci-passthrough devices to a control domain and/or hardware domain, > I'm not sure I see the difference from normal domain creation, ie: > it's no longer something specific to hyperlaunch, as I could achieve > the same by using the existing xendomains init script. So that's not what we've proposed, and hopefully not what we'll need to do. Do you know if there is a need to perform work to support the assignment of PCI devices at the point of domain creation (ie. in domain_create), rather than handling it in a later step of domain configuration, prior to the domain being started? > Also you need a way to pass the configuration from the hypervisor into > a control domain that would then wait for the hardware domain to come > up and afterwards launch a guest with a pci-passthorugh device. The > passing of this information from the hypervisor to the control domain > would need to be done in an OS agnostic way if possible. Ack. We have discussed a plan for surfacing the domain configuration data from the Launch Control Module to the boot domain via either ACPI tables or a Device Tree -- this needs to be added to the design documents. Communicating the domain configuration information to the control domain too also needs consideration. Thanks for raising it. Earlier discussion notes were posted here: https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg00729.html > Don't get me wrong, I don't think such approach is bad, I'm just > unsure whether such functionality is really part of hyperlaunch, or > instead something that you can achieve outside of hyperlaunch already. I think that it will provide a new capability; will work on the docs on how to better communicate how it does so. thanks, Christopher > > Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 24 12:54:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 12:54:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100990.192781 (Exim 4.92) (envelope-from ) id 1lP31u-00017d-Lf; Wed, 24 Mar 2021 12:54:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100990.192781; Wed, 24 Mar 2021 12:54:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP31u-00017W-IE; Wed, 24 Mar 2021 12:54:34 +0000 Received: by outflank-mailman (input) for mailman id 100990; Wed, 24 Mar 2021 12:54:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP31s-00017O-N6 for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 12:54:32 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:fe06::630]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8a22205c-1459-42b1-88c7-869de70bf78b; Wed, 24 Mar 2021 12:54:30 +0000 (UTC) Received: from AM6PR10CA0097.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::38) by VI1PR0802MB2240.eurprd08.prod.outlook.com (2603:10a6:800:9d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Wed, 24 Mar 2021 12:54:28 +0000 Received: from AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::45) by AM6PR10CA0097.outlook.office365.com (2603:10a6:209:8c::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Wed, 24 Mar 2021 12:54:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT035.mail.protection.outlook.com (10.152.16.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Wed, 24 Mar 2021 12:54:27 +0000 Received: ("Tessian outbound 2220e7a8bae2:v89"); Wed, 24 Mar 2021 12:54:26 +0000 Received: from 9cee1872acd1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4ABC8996-727E-4071-9794-78F42A5EDDB6.1; Wed, 24 Mar 2021 12:54:05 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9cee1872acd1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 24 Mar 2021 12:54:05 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VE1PR08MB5662.eurprd08.prod.outlook.com (2603:10a6:800:1a9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Wed, 24 Mar 2021 12:53:55 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::5c93:6e79:8f1e:a839%6]) with mapi id 15.20.3955.027; Wed, 24 Mar 2021 12:53:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a22205c-1459-42b1-88c7-869de70bf78b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/NQcrkwC6CPrYtHLlPpCEUD/a5LH2ZnCrKQ5P7DKsNE=; b=rLlttQbQbcwjakVPmstk+A5ZQEdIv0LtbL2QlTuuOr621KcNe3xwZ63wcpbjxevTp0goDeLJHObGlT4vsxQ357jWfsxg23Bwq7hqIS2JJrL4FNkMqiJdpr/EWMxe9cJ73yUxH2Fq41zc9+yMRHJYo++mWnjXDybEqnswL8D5x0g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 02885b6c30510492 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UpJDHF3cGgEaYt0E3E9OBHYWaTNFE/FWuGOFChYZZmQ4LQ3ZJj0vBF937m4Qh0e7dGXfUHQRDeAPh566+YSkefOf898ecnapF/wvCLrWauj620SrUHNfRGUaDSrk9hQQBpDuuaNwQhvEPGmNXgLiL26xqCa6kMSZ1prBOEJYnZeQrUamzFn0niLFkqlrar3Lh5Q5MD3SawNuzsc0inGvk5D4dzf7NTnP4kcHBdpQYt4ud07iHA8vsnS5KQpq8Jvq5joHxjwz23gU4V1w4fHkzpO00lJ4NFBeCvYWxEePKMdRtBKcjve+QgPTaE5Z56RgMtG4TucQDMXOKMzd4x32Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/NQcrkwC6CPrYtHLlPpCEUD/a5LH2ZnCrKQ5P7DKsNE=; b=SAswN4RixzAK1Od/z/Zu5udtT1nxllP1zAcAwhIgaibnEs6JFa8EIklYgAINF7Uv3uH3WKuT1bHpqmR4V7Dr28tVls8aBVtvsf4xuPmTAz7jN4edhq21pjDKacOTxDFwu6h//n2W3ZmhWdEba8AYYJcTZHf2g3z2cFaGKJR5vEE4e4y5eKX5wNjvPWRKvwA9QAXYBX7g4o/CBAkltq1e4y3w0im3YhBGA4ZJUZstUt2XHEhIgifxzbqlVVxt//bqMx+C3eu2TkvU8G3RRqHB5e42BAaKPAbJJX2oN7tBAhx41bDlMuTlK2+6A02yhtAX2v8R2U4qONsWgPHLWlvsxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/NQcrkwC6CPrYtHLlPpCEUD/a5LH2ZnCrKQ5P7DKsNE=; b=rLlttQbQbcwjakVPmstk+A5ZQEdIv0LtbL2QlTuuOr621KcNe3xwZ63wcpbjxevTp0goDeLJHObGlT4vsxQ357jWfsxg23Bwq7hqIS2JJrL4FNkMqiJdpr/EWMxe9cJ73yUxH2Fq41zc9+yMRHJYo++mWnjXDybEqnswL8D5x0g= From: Bertrand Marquis To: Michal Orzel CC: Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu Subject: Re: [PATCH v8] arm: Add Kconfig entry to select CONFIG_DTB_FILE Thread-Topic: [PATCH v8] arm: Add Kconfig entry to select CONFIG_DTB_FILE Thread-Index: AQHXHvPNGm7G4VbcVEWYk4Cj6NIQRqqTG5YA Date: Wed, 24 Mar 2021 12:53:55 +0000 Message-ID: <15558681-7F3E-4311-B346-DCE63C2A644E@arm.com> References: <20210322081715.26175-1-michal.orzel@arm.com> In-Reply-To: <20210322081715.26175-1-michal.orzel@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.26.33.241] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8ce4ac2f-24b0-4b24-1404-08d8eec3f546 x-ms-traffictypediagnostic: VE1PR08MB5662:|VI1PR0802MB2240: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: EGDtzl49GFjNdYv1rrUj8tW8R72kJ0AJFzCK/oBmbDhIsKdLK4JglNDVd6W9zi3UmYg5y6oIS7+MOr26YIq+7KJOjrFd0sdLDLSV1wyLxYwjVFel4WD2QaMx+Qh5p/obHThAlt/T+FccJFBeRmzkzQ4tSXj1V9C8Ec0siGbY9mn9bYZBApC2drXaVykgdk25DNTU3GBMae2+gyRqHCxQWZza+hahMSLPs9xoLvyjvjMlqluJY75D8TsGQX8TW64PG0G+l+F6AquyKAG7AHbNca0KX2vpME7y0wsdFXVBw8zt+vb6whEod+o+JEi1JVyJ8ow2vDn6OkjbcCQAZd3I1x9irYIHyK49dbez11Z0n43nViP4OfV/I68t5RcD4NHjaHQIrlrfLmKTSGeZtOeuYaahulqpqla04zyE21lV/dT35OYXLlsI4iXdSC2KLWGHyaph9RciSifax6FltH0PPdTIGfYiDhujQ9UXb1ows+Vx7DcTuni7vHg+ZXsUIRrYghEXnR8i23v89bSk3CyITSvPX2CKUNVmcN3a2ahRHhGP8QwgWca1uywtggxpgZbCcoOFVv0S332+ywjggpB5P3t/Ca+cJzQlFqlP7gWcXeOwK6+Zc3kL8KaSCrVDRqCa+BUXJ8iUlRBHbSS4IjGmU/RGHZVNi4GX2ptq6Z5omgzmDpg+RNJ39gGrUXUJ38/X X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(366004)(346002)(396003)(39860400002)(6862004)(54906003)(66446008)(37006003)(53546011)(8936002)(8676002)(6506007)(26005)(186003)(6486002)(316002)(38100700001)(6636002)(66946007)(66556008)(66476007)(64756008)(55236004)(76116006)(5660300002)(6512007)(36756003)(33656002)(86362001)(2616005)(91956017)(83380400001)(71200400001)(478600001)(2906002)(4326008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?pAC/eWyZWFLIZG9LvRwvUym9Dcx5LtoY+YbR9LFsnXjuIVtWFVHmCr6i+J4f?= =?us-ascii?Q?b+ZwqWTr7priHFEGecZUgW8PYVCAkNLfI/tZk1U3yLqoWDoVCYq9VhyOKPQe?= =?us-ascii?Q?6MLVed6HdcNG4vcURswtVBEoM0lgpcDe717dvFz0n5UECrtrbHRGCs3svJsY?= =?us-ascii?Q?9AbbRVXVYs/K3eiMeVGjB0+Z8vSKy2G3hXpZgtMJmdFLxY1efNunb44eVJ/H?= =?us-ascii?Q?8YWUISHP2OgpvI2ItwoizfOZ90FNsD9STNRnUij36drhfxcfgJgP5IkDrWBy?= =?us-ascii?Q?+4bg7e16zOmQHqxDLWvLpqW52/bGVHHlSuwnTDJfYkXEYHyy4JtORRGk7mMB?= =?us-ascii?Q?rssEaQFGajISmpqSkl9KTS7VwUSabrUEls1QIU1p65MM0CqVCUuzuhpGpPls?= =?us-ascii?Q?dOXWplNp+ATD6Uek+7zuFng57mkWHqQV24DkwECDkTronI7QnpW4HAqAMIjA?= =?us-ascii?Q?LN2m6zTvG+UVpcwGE99dDnqho5l9UOdGj/WzsfNIinGa6QGNk0VJaGY1befw?= =?us-ascii?Q?2yu3msvVQyGxTAooyvnP7OjbH67BFQisSZNJjXm5vh3Cvq3oX2ZeKs5OChbg?= =?us-ascii?Q?lEvn27dZO0a0xFVYFkmliQ07kU6BObOTzG7n1OAzr59sXKjP2mU4PzRowxJn?= =?us-ascii?Q?cbKiZ3bMTZXPumOja4hkyinl4i3t8Cqv7/NFI4uAxMVRAwwb0Z1lnbP4eBsY?= =?us-ascii?Q?lYN9q11qEzuurtQNp1FQdGOr17U/jAA0lIGUcJQgU2Z7XUckop1rXjmXr097?= =?us-ascii?Q?6P0Q6ae0RvEePRCon6SEL1G5nOZXGBmAGtni5I9v1Gvoh864YVtEKeS2yz28?= =?us-ascii?Q?Nu2vjW1KNKYnzp/TCNX8vn+cmUIa5jXqp4CI1HSyoCecilTThvosVMVlk/Vh?= =?us-ascii?Q?0dVM8EpNWTZu+J6qklR7hav8cWeSw8UOWanOmUsqE48x9y+9FAdCdKwDs/U0?= =?us-ascii?Q?onJX5mIm4UvwA6W2j+2F8sTm4Q/ne+IdPUp61La0O/Sq/u7xXc9ERsJ83d+/?= =?us-ascii?Q?vm5LPtLWCmPZhJvtei47bIW2RJoBZb4pH12bh//Ig3x3C7AOQzD7uvxs3Qpt?= =?us-ascii?Q?5A18zCUJDu+PJrgy4TQai6eFzfLrcZ0gz9dBcKKZYlQlYYUPDCKwE76iy7QE?= =?us-ascii?Q?lzpqcnVfe7qapXVFsruq2glnreHgIx7Vtjc7U8ckFw70DVhee1nttr/IbQ98?= =?us-ascii?Q?L1UAJ2lLZKkIj24OyjbhiHkp06mkvidxiNEz2gsUeQcJJN3grzzP/JKO1BU3?= =?us-ascii?Q?XejvK2aabXnwzcZDnApGqMlbDTRHUnoT5hm/2VqYB43fF63I8rgINx2wQ1D/?= =?us-ascii?Q?pulMWCzCeLWTiOzZJ8OaASGh?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5662 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 196817d0-9e47-4c15-2fdb-08d8eec3e257 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BxYGHljjsPZnqeTp9zDkMfFbkLwuIxDhhIIY/QGfYhW82+8A9Ud9+sG8mOuNvaRyThyqAlvOugD+k30WuJi00YlkwlMbyaciNrnL+FndJXpp9dtnG+NmmgrO7sxra3dAVdnPUEuAfA7FVs2D3fsP6m0B+lQJubFcjFjsNm/ShTtA3ggAguP8OmgITu8Q2GGNRo2xK+eyxtZ6qM1KXY7eLs373yjrBKmLqSxg4OcLPoq0tCl3+05iUwLVKa5xiEEksyux0NhNmVNSH1yGAyGCPuD92cWtZARtsSEWvl0IMKdMU45DLNOmbepkBHYk+hF8Qo63VVczWI1R+a3aIiGcVFJPil7GOpL+ZKVuy6+VPs3awFPK1RW4j1CL8puuXlqY1u/wjC77sv7U+dIdyxGl3WKpAtn6NnHetZJGwyUyP4ZL6ET3O+lqAu9aG4/GmFQOs+5Ls8d71IOtUw6rHrsaw+9dcRgLi9KKR61wu65qKrnDx5ggufGI46V6thhk2ygOL0oXJM1PK3Uq/AGz06EXbCg22myQXigOJkeTBlnlTcePRUkn51cqsfuHhJTUQ0Baqs7No8J0lVo3MF+f3PcLV8qYc1p8uEJ9llb+T5rEhKRJh8DxzBf5WREii85527PXLIz5mzybSpK6rqBuO5e7wQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(39860400002)(396003)(376002)(136003)(46966006)(36840700001)(8676002)(2616005)(8936002)(70586007)(33656002)(316002)(81166007)(83380400001)(54906003)(356005)(4326008)(36860700001)(37006003)(47076005)(70206006)(6862004)(82740400003)(36756003)(5660300002)(6506007)(82310400003)(55236004)(6512007)(6636002)(186003)(26005)(336012)(53546011)(86362001)(478600001)(6486002)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 12:54:27.3405 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ce4ac2f-24b0-4b24-1404-08d8eec3f546 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2240 Hi Michal, > On 22 Mar 2021, at 08:17, Michal Orzel wrote: >=20 > Currently in order to link existing DTB into Xen image > we need to either specify option CONFIG_DTB_FILE on the > command line or manually add it into .config. > Add Kconfig entry: CONFIG_DTB_FILE > to be able to provide the path to DTB we want to embed > into Xen image. If no path provided - the dtb will not > be embedded. >=20 > Remove the line: AFLAGS-y +=3D -DCONFIG_DTB_FILE=3D\"$(CONFIG_DTB_FILE)\" > as it is not needed since Kconfig will define it in a header > with all the other config options. >=20 > Move definition of _sdtb into dtb.S to prevent defining it > if there is no reference to it or if someone protects > _sdtb with #ifdef rather than with .ifnes. If the latter, > we will get a compiler error. >=20 > Signed-off-by: Michal Orzel Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/Makefile | 5 ++--- > xen/arch/arm/arm32/head.S | 4 ++-- > xen/arch/arm/arm64/head.S | 4 ++-- > xen/arch/arm/dtb.S | 1 + > xen/arch/arm/xen.lds.S | 3 --- > xen/common/Kconfig | 10 ++++++++++ > 6 files changed, 17 insertions(+), 10 deletions(-) >=20 > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index 16e6523e2c..46e6a95fec 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -68,9 +68,8 @@ extra-y +=3D $(TARGET_SUBARCH)/head.o >=20 > #obj-bin-y +=3D ....o >=20 > -ifdef CONFIG_DTB_FILE > +ifneq ($(CONFIG_DTB_FILE),"") > obj-y +=3D dtb.o > -AFLAGS-y +=3D -DCONFIG_DTB_FILE=3D\"$(CONFIG_DTB_FILE)\" > endif >=20 > ALL_OBJS :=3D $(TARGET_SUBARCH)/head.o $(ALL_OBJS) > @@ -137,7 +136,7 @@ asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c > xen.lds: xen.lds.S > $(CPP) -P $(a_flags) -MQ $@ -o $@ $< >=20 > -dtb.o: $(CONFIG_DTB_FILE) > +dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) >=20 > .PHONY: clean > clean:: > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S > index c404fa973e..50f019ed98 100644 > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -156,10 +156,10 @@ past_zImage: > sub r10, r9, r0 /* r10 :=3D phys-offset */ >=20 > /* Using the DTB in the .dtb section? */ > -#ifdef CONFIG_DTB_FILE > +.ifnes CONFIG_DTB_FILE,"" > ldr r8, =3D_sdtb > add r8, r10 /* r8 :=3D paddr(DTB) */ > -#endif > +.endif >=20 > /* Initialize the UART if earlyprintk has been enabled. */ > #ifdef CONFIG_EARLY_PRINTK > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 5d44667bd8..f38a8dfca7 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -296,9 +296,9 @@ real_start_efi: > sub x20, x19, x0 /* x20 :=3D phys-offset */ >=20 > /* Using the DTB in the .dtb section? */ > -#ifdef CONFIG_DTB_FILE > +.ifnes CONFIG_DTB_FILE,"" > load_paddr x21, _sdtb > -#endif > +.endif >=20 > /* Initialize the UART if earlyprintk has been enabled. */ > #ifdef CONFIG_EARLY_PRINTK > diff --git a/xen/arch/arm/dtb.S b/xen/arch/arm/dtb.S > index c703aef12b..c39f3a095c 100644 > --- a/xen/arch/arm/dtb.S > +++ b/xen/arch/arm/dtb.S > @@ -1,2 +1,3 @@ > .section .dtb,#alloc > + GLOBAL(_sdtb) > .incbin CONFIG_DTB_FILE > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S > index 004b182acb..fc1d39a886 100644 > --- a/xen/arch/arm/xen.lds.S > +++ b/xen/arch/arm/xen.lds.S > @@ -220,11 +220,8 @@ SECTIONS > } :text > _end =3D . ; >=20 > -#ifdef CONFIG_DTB_FILE > /* Section for the device tree blob (if any). */ > - _sdtb =3D .; > .dtb : { *(.dtb) } :text > -#endif >=20 > /* Sections to be discarded */ > /DISCARD/ : { > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index eb953d171e..a1755cd380 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -400,6 +400,16 @@ config DOM0_MEM >=20 > Leave empty if you are not sure what to specify. >=20 > +config DTB_FILE > + string "Absolute path to device tree blob" > + depends on HAS_DEVICE_TREE > + help > + When using a bootloader that has no device tree support or when there > + is no bootloader at all, use this option to specify the absolute path > + to a device tree that will be linked directly inside Xen binary. > + > + This is an optional config. Leave empty if not needed. > + > config TRACEBUFFER > bool "Enable tracing infrastructure" if EXPERT > default y > --=20 > 2.29.0 >=20 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 12:58:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 12:58:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.100996.192793 (Exim 4.92) (envelope-from ) id 1lP35T-0001Qi-Cb; Wed, 24 Mar 2021 12:58:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100996.192793; Wed, 24 Mar 2021 12:58:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP35T-0001Qb-91; Wed, 24 Mar 2021 12:58:15 +0000 Received: by outflank-mailman (input) for mailman id 100996; Wed, 24 Mar 2021 12:58:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP35R-0001QW-T9 for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 12:58:13 +0000 Received: from mga14.intel.com (unknown [192.55.52.115]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a3a55f57-e73a-4ec3-9161-5a8ccdd78f7f; Wed, 24 Mar 2021 12:58:12 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 05:58:11 -0700 Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 05:58:09 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lP35L-00FgFX-56; Wed, 24 Mar 2021 14:58:07 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3a55f57-e73a-4ec3-9161-5a8ccdd78f7f IronPort-SDR: nj4UAACCIE/I9vKKjVAD0wYVHafyH3JJ/JdnOeYvfF97erLVRViYZNAMLGdxSi8N6LdiE4PEqz kZVWdIckQ1Qw== X-IronPort-AV: E=McAfee;i="6000,8403,9932"; a="190111874" X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="190111874" IronPort-SDR: PmJQBp3JonAqGpUiW1irNX+pcSR62Rcn/S2FPW030FJzXa/AdtmMqNrN1wdrIxFlGlMP8ZfieG Z6nhLd7LWhog== X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="442213365" Date: Wed, 24 Mar 2021 14:58:07 +0200 From: Andy Shevchenko To: Roger Pau Monne Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Mika Westerberg , Andy Shevchenko , Linus Walleij , linux-gpio@vger.kernel.org Subject: Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region Message-ID: References: <20210324123118.58865-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210324123118.58865-1-roger.pau@citrix.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Mar 24, 2021 at 01:31:18PM +0100, Roger Pau Monne wrote: > When parsing the capability list make sure the offset is between the > MMIO region mapped in 'regs', or else the kernel hits a page fault. > > This fault has been seen when running as a Xen PVH dom0, which doesn't > have the MMIO regions mapped into the domain physical memory map, > despite having the device reported in the ACPI DSDT table. This > results in reporting a capability offset of 0xffff (because the kernel > is accessing unpopulated memory), and such offset is outside of the > mapped region. > > Adding the check is harmless, and prevents buggy or broken systems > from crashing the kernel if the MMIO region is not properly reported. Thanks for the report. Looking into the code I would like rather see the explicit comparison to 0xffff or ~0 against entire register b/c it's (one of) standard way of devices to tell that something is not supported. Moreover, it seems you are bailing out and basically denying driver to load. This does look that capability is simply the first register that blows the setup. I think you have to fix something into Xen to avoid loading these drivers or check with something like pci_device_is_present() approach. > Fixes: 91d898e51e60 ('pinctrl: intel: Convert capability list to features') > Signed-off-by: Roger Pau Monn > --- > Cc: Mika Westerberg > Cc: Andy Shevchenko > Cc: Linus Walleij > Cc: linux-gpio@vger.kernel.org > --- > Resend because I've missed adding the maintainers, sorry for the spam. I have a script to make it easier: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Wed Mar 24 13:16:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 13:16:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101000.192805 (Exim 4.92) (envelope-from ) id 1lP3MZ-0003IW-UG; Wed, 24 Mar 2021 13:15:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101000.192805; Wed, 24 Mar 2021 13:15:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP3MZ-0003IP-Qx; Wed, 24 Mar 2021 13:15:55 +0000 Received: by outflank-mailman (input) for mailman id 101000; Wed, 24 Mar 2021 13:15:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP3MX-0003I1-Rw for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 13:15:54 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6eb9d870-108c-4b20-959d-4f9c5f519458; Wed, 24 Mar 2021 13:15:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6eb9d870-108c-4b20-959d-4f9c5f519458 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616591752; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=4770ruhSxyXb36e1yu5oJTwUyg0ZrMh6HfAhTq3NyUs=; b=Hue4AWwAwPjWX09o1Y3FapvHsKez+t9xExIqWnz9JhdL2C6wXwXk+k8n b3itMR3V35NFhZqmUjwuZ0WWoyXMU4xgVS/p40hsYtDmMluMzKUpmvC13 zgk3UTMcheEFYJlCkmqJnPVgIgYh8lzaQQkun4Lor0NTRFjKAtaAWMFUM c=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 5KoQtF7GxhHr/vXLbkQnxHX/UWiURovS/wrXcGBpiYxrm57uooS4plQ482RQGb6CLvp9JXAXXN 0kOWa12UlNpjLRVnCN+lVYv+OFm3+mkHuL1v1hZfZnI56G5zvGT/2+DWtD190nnqWvZJGm9gBt 659/X/DASENfocTDcuzjvLV5yjgVijWJ+yrjB2lz26PR2220dijYPy7JNAG4EV14tHHynNqLUt ZpJMFfrXrH4OPSaqcOCcnv0rsgt4ibztSyNKwFkom3AeJjcTtq0sPAijdWLUY9E/00S1DrjUBq yas= X-SBRS: 5.2 X-MesageID: 40018780 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:laoH5azBp7UNTGW5RekyKrPxV+8kLtp033Aq2lEZdDV8Sebdv9 yynfgdyB//gCsQXnZlotybJKycWxrnmqJdybI6eZOvRhPvtmftFoFt6oP+3ybtcheTysd07o 0lSaR3DbTLYGRSpczx7BCkV/Mpx9ea+K6l7N2usktFZysCUdAE0y5SDAGHHkpqAClqbKBJWq a0zMxBujamZDAzZsO0GnEKU4H41qH2vbjhZgMLAANi1RKHiimm5KW/Px+T2BofVD0n+8ZizU HulQvl6qK/98yq0xO07R6d0716uvvEjuFCCsuFl9QPJlzX5DqASYx9V9S5zUkIic617lJCqq iunz4BOIBJ52rVbiWJp3LWqnPd+RIPz1On9lOCm3vkpqXCNXIHIu5Mn5hQfBecy2dIhqAF7I tx02iUt4VaAHr79UyXjbmpazhQmkW5unYkm+II5kYvKrc2U7NNsZcZuHpcDZZoJlOh1KkcDO JsAMvAjcwmFW+yUnHDsmFjhPyqU3gjdy32JHQqh82P3zBa2E1+1ksTrfZv+UsoyZRVcegn28 30doBT0J1eRM4faqxwQM0bR9GsN2DLSRXQdEqPPFXODsg8SjHwgq+yxI9wyPCheZQOwpd3so /GSklkuWk7fF+rIdGS3adM7gvGTAyGLHbQ4/Abw6I8lqz3RbLtPyHGYkspidGcr/IWBdCefP qvJpRMAbvGIXH1EYhEmy3yMqMibEU2YYkwgJIWSliOqsXEJsnBrerAasveI7LrDHIqQWX6Dn wfXCXiJclJ40yxM0WIxyT5ajfIQAjS7JhwGK/V86w4044WLLBBtQATlBC466iwWHt/m51zWH E7DKLsk6u9q2Xz133P9X9VNh1UCVsQ5L3hVnhNtBIbKk+cS8dbh/yvPURpmFeXLB52SM3bVC RFoU5sxK6xJ5uMgSY4C9ymNWqeh2AJpG2DSoodnqHr37agRroISrIdHIBhHwTCEBJ43Sxwrn 1YVQMCTkjDUi/1hb69l5wSDuHHf9x6iAOmSPQk8U73hAG5n4UCV3EbVzmhXYqrmg4oXSNTnU A02bQYmqC8lTGmLnYfjOw0PEZXUnmeBKtLAW2+Fd5ps4GuXDs1bG+RwRSGlhk4ewPRhjovr1 2kCRfRRNbmLR52vGtC3qPj7VVuH1/tAX5YWzRdqo1yFWPPp3Bp9/SED5DDjle5Ykcew+0bLT HOaSYTJAQr3NysyBuJgl+5ZAUb74RrMerHALs5dbbPnnurNY2TjKkDW+RZ5ZB/KbnVw6I2eP PafweUKT/iYtlZqjC9tzIgOCNurmMjnu6t0Br57HKg1HpXO4uYHH12A7UaKcqb9W7qWrKB14 h4l8s8ua+1Pn/qYtCLjaHRYDgrEGKYnUemC+Upo4tTp6Q8qf96GITaSyLB0DVfxwolRf2E4n 82UeB++vTMK4Vvd8sdd2ZQ+Ucojs2GKA8uvhbtCuEzcFkxhxbgTp+0yquNraBqDlyKpQP2N1 Xa6SFb8vvfVyaI1LIRCcsLUCxrQVl57G4n8PKJdoXWBgnvavpK+0CiNGShNLBaU6qIFNwr32 FHysDNm/XScSX22Ard52QmZq1P9nuqWsO0DkaHH/VS/9mzJFSLhe+r7aeI/ULKYCr+b15dg4 tPMVEUZIBEjDIpiYUsyCi8SqDtuCse4hJjyCAikkSow5Ss5WfQAFpPPgLYiIhHRDU7CAn7se 3VteyDkGnn6DdL2ZPfBF5dc9FHFd8XVJX2JU5VWLwtla/t+bEujCRFaAovCGB5iCmV5ZIU4Y uE X-IronPort-AV: E=Sophos;i="5.81,274,1610427600"; d="scan'208";a="40018780" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oJP95pQ/M1fcqJTNsKxKtlngrL+zLsLhDc9IKIMU4PSozOt1gbUL3SN73QlSjlabtEVepgfnmJZGHlQYWT5NE+1zxiZfDXI3NPBPSSpt81RcqDLwACwQdzzZcP+P51nDkYC2mIuBSXoMNEfU4hbfSmiBVgojqswj8At/R7W2XAAdz3NwHRo3fc+k0VQvW9fZa7k2h7NdkArzgO6iIB+3zumq/ee+0KAml5HrbH77apllHL8nr5UGULGXZrz1E4pN83q8xiw/1eyczT4VldJhxj3wt9mAj7cdpKpxdOl+ewiclMUYY7RjQboStnVDXMQa05DSOtWKfjsOI2aJm3mgtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4770ruhSxyXb36e1yu5oJTwUyg0ZrMh6HfAhTq3NyUs=; b=e7JTRXk+T/RWVDhZf8rW7g2RQdx8CXzNpO65Ua/4H5Y/x4c9SO7vaMF5LucZhz2B3nLfpEIOAgyWHhRwx+Hti3wUHoVZG241+KNvFiEVe4QW7XaVosGcm3IGlyD3RdT4M301ShvXEwqglrJFbh5Qj2smkw1y2P16jTDken7tPzOFfiTF2W5hU4D+6eXsCmagofvNuMYsk+d3u+PAnZmto6rWUEuiS9s4tgGEWDid5uI872cjHcFTND6WW4rFe5fM+eLadQgnTHXpi//YdyuzsfxrIFXQx2x8VdNhYWI4hFANc5qD6qTYx8gFam05jXeHyLGvmvTsvfcJZqaDGxUdLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4770ruhSxyXb36e1yu5oJTwUyg0ZrMh6HfAhTq3NyUs=; b=bEGlOunN8uutuS19ho8XwzMsUEYOD7lX/9xlhtyCqh6OJaAhpfVEKUBCfDVOJPDlF0eaP8m4kMgDcdQjucLVSZyc4Io5smHYgEBMxRfYviHInF109EGjr8dq3XV+mW66VF9hIa9NR/BcQkRnpnKpZIzZ1MTwxtrs/ZLoX0+HMrk= From: George Dunlap To: Christopher Clark CC: Roger Pau Monne , "Daniel P. Smith" , xen-devel , Andrew Cooper , Stefano Stabellini , Julien Grall , "Julien Grall" , Ian Jackson , Wei Liu , Jan Beulich , Rich Persaud , Bertrand Marquis , "luca.fancellu@arm.com" , Paul Durrant , Adam Schwalm Subject: Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document Thread-Topic: [PATCH 1/2] docs/designs/launch: hyperlaunch design document Thread-Index: AQHXGhIm6lUem5Agw0SwTR0/wys6MqqJ94wAgAfrX4CAAPCuAIAAUZ8AgAAGPoA= Date: Wed, 24 Mar 2021 13:15:48 +0000 Message-ID: <532A93C8-81F9-4254-A9B6-B6E3462923A9@citrix.com> References: <20210316031814.10311-1-dpsmith@apertussolutions.com> <20210316031814.10311-2-dpsmith@apertussolutions.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b72eb8bb-2553-4754-f3be-08d8eec6f142 x-ms-traffictypediagnostic: PH0PR03MB5670: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pxgJHJgthgJ+jnsdL1Vsm3QjexBfvYeD3Oyq1349+4RiKRcYN9xraza8RxaFzHgerhZu5bMC+vSQlqM05JE6n2ufOBeuFFNl/Z7dgzYcgnbtS38+/iSNlY5XKnHNrrLFnqWt/EncY3rSuI4Vx6usMvgniIwyZ7TbsnpiHXPkSyWtY0Ka8u2r/0zKCtWRatBS00U0zNoC9A+eZZmJAnTlp+Ls3zXafnlpLi89ZyiymzhDsrM7NzIqX6Rhde3ZjVXRv7ERGoR9bcML6O5Ay0PwdmdZfNnO2evj0JgVTvTFhcro025hE2MdtvyFiqPPdhsIfgH4nkcxk4jvjQL06CUqfVZ9WcTaDQdBuaLRqVKxTxTybERhxijdVK16PCk5YL5OFnCX2FwdGGsH1lPxXY1vIT+rJ549unh24QVrvznaNo2qVIAiL5RoodufjkFEPgMnAtqyPBSauSQNDnK/2tsp4rtXkesNanIpEJjhj3Mox1en5ACpyuGCfy6d0wova7ja0KrIbiMRC/mMoW+MiAh0xvI9N18ba0elIJALTQpxm80cNcQxzUZ6Jm6kiY/Rh6bRMeC9H1z3aKJRFepRYcl5P+ASeRwcZA5tqf8TS0d90uzecrs9JLk73XGlqU6pKHzMJ+DTdFmQ/T5KG2fNEJuMOm/hWCgIUQIlKVaoOSj4E3pdYJt3+2Lkdzvkg9YtOAru x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(39860400002)(136003)(376002)(366004)(36756003)(33656002)(6486002)(76116006)(6512007)(478600001)(7416002)(54906003)(91956017)(6916009)(2616005)(66946007)(4744005)(66556008)(53546011)(186003)(8936002)(66476007)(2906002)(5660300002)(64756008)(316002)(8676002)(38100700001)(26005)(4326008)(86362001)(6506007)(71200400001)(66446008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?TmFrZGRuSmhXL2E3b21aWXY4WXRsMXJib1JaSmE5SDdHU294UU5ybUFldVlq?= =?utf-8?B?N2RRd2FpaGdIekJKdWd2U3c4a28rZkcrTWJialBKVURiSDB4VEhXRWg4eW5u?= =?utf-8?B?VkxRUlI5eWlKZ3MwVTkwQkVPMkpUTWZEdUlPMzJWbndXLzZVTnV6d25HODlX?= =?utf-8?B?enZhSGhaSE9qSVFXdGpJRjhWNW9DdDY0eTRqN0dLdk5mOEowbVFHZ2t4YXBt?= =?utf-8?B?SUNpU3FxL1NDVzBDSHlRTjhPOXlwaG1mdDZuSTZEY1g0R0RTS0IwYTJpSGwx?= =?utf-8?B?Q1FnMExrd0ppNzkzWXErZG51Qk02RW55TkFzTFpSbVBiOGZlb0h5TDJETk9y?= =?utf-8?B?bkoxSXNUemErYkpoT2owaXJTTTMrRzBaRkFTYkh3UlUzaGhsN0w2dURNMHpv?= =?utf-8?B?dkwvUEUxd0xXY1ZLcFN5K0JSVHdCVzJTQW9NOWU3NWVBQys0K01jWjhSakIz?= =?utf-8?B?WDdnUnMzeUkvV2REdjAxSHdWUHl0S2VzWmtwcE9FZ2hyaVJMMHJKWE50b2F3?= =?utf-8?B?TndpQ05ZOGNYaVFVbUEwZnpsSlh2TnQzdms0L0IycWRGNTJTN1IzS0tXOUtw?= =?utf-8?B?UG9LNmNQRUxFU3F3aEVnQ05zOVJiRFFkUTl0bFBPMlBQMDRXN28weUxBS0VT?= =?utf-8?B?cmdnZVRqaVdsR0puSTF2M1VGakMwRmRveEJwclBCSmRwOWZ3MEsxWFdETXp2?= =?utf-8?B?ak4ySmRwc1pzQXFkeDlPN1o4bnJqK1NoOFpsUWZ2SUZ0dGdNNndTM1NyMzZ0?= =?utf-8?B?eWhHVlVkUUQzSHA5bWNBT25RdzlwVTBxNXhnY2xrcURZRWRhbVVXd1p0dzFT?= =?utf-8?B?aGozT0MyblBpek1jVGk1aTBPSmcxOW02Rk9RRzNmZEcvREF3aDdzbWxrV3FJ?= =?utf-8?B?NmRRSUw4Sm9adnUzL3VLZitJUW1YWUY3bzhPNVdFQkFLbzRJTldsRnFjeHpP?= =?utf-8?B?emRSVVRic3lmZ1NkWU5yNDh3bjVRNWo3d3VjaTAwNGNwcjB4ZUlKb3FZQjF2?= =?utf-8?B?VURPRjlCRzJ6dERoRzlEMTIzUElKZk93b3pwK1RTWDRVdVpnRGFqRXp0STBC?= =?utf-8?B?VkdNN3h5Yk1IeGxubG0vSlcxU0xDcTltQjhMZXNxWFY4U2hmMjBCcFdoTXBL?= =?utf-8?B?VC95VjJqTjRsTSt5Ulh6Z3VCZGhCaFlQV0dRQWRTU2pvNzAvY2FhZllYeGUz?= =?utf-8?B?RDFTK3BSVkhnVDZISnZGaVpFK1o5YnVTMjJwTmVmUSt2amc0OHMvSGpJWVlo?= =?utf-8?B?WEdjMGk1c1Y4ajNiamhXZ1c1MFdvbThJZkxiTFE4MWprOXZtdTMzVVppV3RF?= =?utf-8?B?NUJTbnVmSXlVZGZHU0UrUkllQWtGQWhUOE9majgzaDk1dU8xNVhjZ1ZRZmYx?= =?utf-8?B?ZGFnTUI2VWIwNUd0YW9qTHlETnJ3RFlQOEs3aGtsSFE5VkV6YmJBMyt2YTZU?= =?utf-8?B?N2k0bUY1c3ZLOTI3NGo5WmxWdE1IOEZoai9zK1Y2OGxGVWZNUVVQMjFpRjU5?= =?utf-8?B?MlZSWFdoeHFJQmRkNXBGbWFNUHJ5d2JmVTAzZW1TR1dsVlVHdUNJUktGTklo?= =?utf-8?B?TU9jd205cjExNFE0eEV6LzM3aFNObDNsSDVkUmJZME9HMi81eEZxWlNhTzd1?= =?utf-8?B?aDlEWEhVNk1GSGtXRDlMWHhHRzBxVndWc3RuOTM3V3pKdzVQalYydGNrMjAy?= =?utf-8?B?S1doSUtXNENwbk8vWGtUZExCMHVuak52NndROVZZR2FUTzQ2d1Nxbi82bHM2?= =?utf-8?B?Z0w1SXZrMDU5Vk04cjRUZ3Z4UDNEL3F0cjZVV0UzVGJmdDk0aldaOHhpWHQ1?= =?utf-8?B?UzhBbWRzbnFabWZBTHNzdz09?= Content-Type: text/plain; charset="utf-8" Content-ID: <60525790CBF3404FA98049DE155860E6@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b72eb8bb-2553-4754-f3be-08d8eec6f142 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2021 13:15:49.0004 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bhl053wyuz1DQPcuI4rZAwRnXhZOXuMW/eFVhQnc4fl8q+bNkIIVrw+ckvPuwy3xqkdOIdzR3jNkRkJ6Q7sT6wVeeRBHlzYUFTfuoVeNnIQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5670 X-OriginatorOrg: citrix.com DQoNCj4gT24gTWFyIDI0LCAyMDIxLCBhdCAxMjo1MyBQTSwgQ2hyaXN0b3BoZXIgQ2xhcmsgPGNo cmlzdG9waGVyLncuY2xhcmtAZ21haWwuY29tPiB3cm90ZToNCj4gDQo+IERvIHlvdSBrbm93IGlm IHRoZXJlIGlzIGEgbmVlZCB0byBwZXJmb3JtIHdvcmsgdG8gc3VwcG9ydCB0aGUNCj4gYXNzaWdu bWVudCBvZiBQQ0kgZGV2aWNlcyBhdCB0aGUgcG9pbnQgb2YgZG9tYWluIGNyZWF0aW9uIChpZS4g aW4NCj4gZG9tYWluX2NyZWF0ZSksIHJhdGhlciB0aGFuIGhhbmRsaW5nIGl0IGluIGEgbGF0ZXIg c3RlcCBvZiBkb21haW4NCj4gY29uZmlndXJhdGlvbiwgcHJpb3IgdG8gdGhlIGRvbWFpbiBiZWlu ZyBzdGFydGVkPw0KDQpBSVVJLCBsaWJ4bCBhY3R1YWxseSBkb2VzIHRoZSBsYXR0ZXI6ICBUaGF0 IGlzLCBQQ0kgZGV2aWNlcyBhcmUgYWRkZWQgdG8gdGhlIGRvbWFpbiBhZnRlciB0aGUgZG9tYWlu IGFuZCBxZW11IGhhdmUgYmVlbiBzZXQgdXAsIGJ1dCBiZWZvcmUgdGhleSBoYXZlIGJlZW4gdW5w YXVzZWQuICBPbmUgYWR2YW50YWdlIG9mIHRoaXMgaXMgdGhhdCBpdOKAmXMgdGhlIHNhbWUgY29k ZXBhdGggZm9yIGFkZGluZyBQQ0kgZGV2aWNlcyBhdCBkb21haW4gY3JlYXRpb24gYXMgZm9yIGhv dHBsdWcuDQoNCiAtR2VvcmdlDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Mar 24 13:41:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 13:41:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101011.192822 (Exim 4.92) (envelope-from ) id 1lP3ke-0006Ca-3z; Wed, 24 Mar 2021 13:40:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101011.192822; Wed, 24 Mar 2021 13:40:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP3ke-0006CT-0v; Wed, 24 Mar 2021 13:40:48 +0000 Received: by outflank-mailman (input) for mailman id 101011; Wed, 24 Mar 2021 13:40:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP3kc-0006CO-HV for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 13:40:46 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 49c42590-0167-45af-b5bc-b92137048bfc; Wed, 24 Mar 2021 13:40:45 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4F05EAD80; Wed, 24 Mar 2021 13:40:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49c42590-0167-45af-b5bc-b92137048bfc X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616593244; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mmWBLwuAjQTD3R0E7Rrg/jNF+8iv7spYDJUONDz4gyc=; b=q+04gCb4ZC+NLX4ziaYzBZjGeQi+X5Mi5ioD/Su1FPsQvt+cO5P1bCq6xcM+D9TNCv2ohW gI457B2gT2HIOKo6G0iEtFLMDJL9ypcyhzDMsI6UTmk39RjiPL9LTn+TJz5cEPR7dXDBYD R0jMIoeu1JvnJIYONxgK/IUZruWKzCY= Subject: Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally To: Tamas K Lengyel Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Ian Jackson References: <8e18a2a5-bc19-615d-0c8c-cea49adcf976@suse.com> From: Jan Beulich Message-ID: <5666cd15-02c9-6aa8-c8fc-c44c826b14b2@suse.com> Date: Wed, 24 Mar 2021 14:40:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 24.03.2021 12:37, Tamas K Lengyel wrote: > On Wed, Mar 24, 2021 at 6:34 AM Jan Beulich wrote: >> >> Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC >> static PIT clock gating") was reported to cause boot failures on certain >> AMD Ryzen systems. Until we can figure out what the actual issue there >> is, skip this new part of HPET setup by default. Introduce a "hpet" >> command line option to allow enabling this on hardware where it's really >> needed for Xen to boot successfully (i.e. where the PIT doesn't drive >> the timer interrupt). >> >> Since it makes little sense to introduce just "hpet=legacy-replacement", >> also allow for a boolean argument as well as "broadcast" to replace the >> separate "hpetbroadcast" option. > > While having the command line option to control it is fine what would > really be the best solution is if Xen could figure out when the > legacy-replacement option is necessary to begin with and enable it on > its own, even if it's done as a fallback route. This was the original plan, but no patch has arrived by now. I can imagine this being due to things being easier to state than to actually carry out. Plus of course this fallback approach still isn't ideal - even better would be if we could address the actual failure. I for one lack sufficient technical data to at least try to think of possible solutions. > We'll have issues with > telling users when the option is needed and when it isn't. I don't > like the idea of users having to go through a route of "well, let's > see if Xen boots and if you get this weird crash/reboot add this > obscure boot option". It's just a bad user experience all around. I can't see how it's worse than what we've had so far, crashing during boot _without_ there being any option available. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 24 13:57:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 13:57:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101015.192835 (Exim 4.92) (envelope-from ) id 1lP40o-0007Jr-Jt; Wed, 24 Mar 2021 13:57:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101015.192835; Wed, 24 Mar 2021 13:57:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP40o-0007Jk-FF; Wed, 24 Mar 2021 13:57:30 +0000 Received: by outflank-mailman (input) for mailman id 101015; Wed, 24 Mar 2021 13:57:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP40n-0007Jf-8L for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 13:57:29 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cba7149d-3e10-4c71-bdc2-0412cb56b921; Wed, 24 Mar 2021 13:57:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cba7149d-3e10-4c71-bdc2-0412cb56b921 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616594246; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=8aRvfvxX7/DE29hSEwl7keQw2sOVYe8orExjoJVN/i4=; b=LiVFLbiZ64ZVYyfEY0fchUtKZ3PxvHUhMdSxET3sRbVUs8VFeAVyKjDx znlmM3MQ3dIGgVODnv25digfnpB0E2Bzxn44kYtvndbvVAda731LED2XR 2Mfpo+zmAfNM+PcAROV8lNBymZVpcPG8H+L5T0xPfCCS0liZVJO++nEMj I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: iiyex8+CInkTN71NpwBUt4lVyBZQhguoXbYShG1BQs6lcGpRTgVKdrLhQKP4wIf0xDUhCQmIXw DY6KCOBPlMkuSu7+RMoTGZ3gxjz3YH/VcGhku/ybftl3Ll8fHSM6Q8Ei+P3ArnBWRWgAPCXo8Z SUE8JFW+Adr+lgmlPirS5f0/tk66iLWgyx8rVvaE2wXhxcgAV59D2Z5PnvuK5zY/wsvob5H/KO LYlDqe8FHGAjB9gHpnFNiN+TZULX7VmNVvMZXcbPpcc6L5AJeIODbXZgYoQEALoAMZpGR4o0KA 5bw= X-SBRS: 5.2 X-MesageID: 40173344 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:rwngPaiirm+xZZD/TJkEXV3fpnBQX0Rw3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+csFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmup tIW5NVTOf9BV0St6rHySGlDtctx8SG+qi0heHYi0xgVx1udrsI1WdEIyywe3cGIjVuL5w/CZ aa+45rpyC4f24Wc8S8ARA+LpX+jvfMk4/rZgNDOgUu7xOAgSjtxLnxFRWZ2Rl2aUIy/Z4J92 /Znwvlopiyqv3T8G6n60b/zbRz3OHgxNxKGdCWhqEuSwnEpw60aO1aKti/lR8vpuXH0idPrP DtpFMaM913+zfteAiO0GTQ8i3B9Bpr1HP401+fhhLY0L/EbRY3EdBIi44cUjax0TtZgPhG3K hG332UuvNsZHuq9kmNhKmrJmRXv3G5rnY4nekYg2Y3a/pkVJZroZEC50QQKZ8cHUvBmfAaOd NzB8LR7us+SyLiU1nluABUsbuRd0V2NBKHTk8eg9eSwjhbkVtopnFotfA3rzMu8okwRIJD4P mBGqN0lKtWRstTVq5lAvwdKPHHRlDlcFbpCia/MF7nHKYINzbkrIP22qw84KWPdIYTxJU/tZ zdWDpjxCEPUnOrLffL8IxA8xjLTmn4dy/q0Nti659wvaC5bKb3MAWYIWpe0/eIkrE6OIn2Sv yzMJVZD7vINm31A7tE2AX4Rt17NWQeassIodw2Mmj+4/7jG8nPjKj2YfzTLL3iHXIPQWXkGE YOWzD1OYFu9UaudnjkgAXAen/kd0DllKgAUpTyzqw28swgJ4dMug8ahRCS/ceQMwBPtaQwYQ 9fLdrc4+aGjFjz2VyNw3RiOxJbAEoQyq7nSWl2qQgDNF6xVb4Cvt6YaF1DxXfvHG46c+rmVC pk43hn86O+KJKdgQo4Dci8D26ch3wP4FWHUokbga/Gwcv+YJs3AtIHVcVKZEv2Pi0wvTwvhH ZIaQcCSEOaPCjpk7+ZgJsdA/yaUcJ9jgetKct9smneqk2YmMEqShIgLn2TeP/SpTxraytfh1 V3/aNaqqGHgyyTJWw2h/l9DEdBc12NALVNDB2MYaJdnryDQnA2cU66wRihzz0jcGvj8Esfwk jsNzedd/3wDl1BgXxAyarx/FRodmKSQlJoZhlBwP9APFWDnkw2/f6AZ6K13WfUUFcEz+0HGB zuYDcZIGpVtpuK/S/QvAzHOWQtx50oMOCYMa8qdKvL3GixbKeSk7sdIvNS9JF5Fdznv+MRS9 iDcwuNID6QMZJu5yWl4lIefA96p3kvnam2hFnL7G2k0GU+BvSXClJ8XL0fK8yd6W+hZ/vg6u QPsfsF+c+LdkP2YZq67IuSSRhpABbau3S3QOElsoo8h9N7iJJDW73gFQLV33RG1igkJMj6lE kiUL12iYqxTrNHTog3QWZl5VInm9SEEVszviH3CuE4e0sxj3WzBaL+35P47Z4uCFaGvg3+JB 229DBc5e7MW0K4pPQnIpN1BWRdc04n7nt+uMuEao3LEQ2vM8VO5kCzPHP4ULhTTsG+aPgthy c/x9GDhOmMcSXknCjWoDtgO6pLt1+dfvnaOnPEJcd4t/qgOVqNhaO24Mm8yBfPIAHLFXgwtM libkwfbsNKlz84qpY4uxLCE5DKng== X-IronPort-AV: E=Sophos;i="5.81,274,1610427600"; d="scan'208";a="40173344" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ypqeb9KUTd/IbZf6gu7Q12zB9QPODEzyUwTdQKEd5pXrC2R2U5NHQwyWO+0ojM7mFpFFZUNQZWQFu5aIYaw+5R/VCpMuxv98CYm85T+3JM2WmJ8y/2ukLFb0qkCZG6p4Bbvgyiaj/i4YUP6wulsRdClR/jSP7/eMm7x9AWzxD6nRMTQJDUyWz3oytB+/+KxaetBp6vW/spcEA8W80YGPHE/WQuWbK4qLlDDHAEHfoyTZgEckZC5cRQWMawlpHU8gK6f5A6vmDvinmtTpf4FpZaKwHh8b0Pl1nQ60vXSOwqxt7ouAVrt3FitHllndmH7AsR5bjdC7jJupRUtt/jcRTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2WMi9DWalKfawkgbPzZMmmO0JisHja4ifJZM74rdk5U=; b=RJaJMndBXLvF4ZpqeXC6dxFhNTH+HwEpDuPYxEadaY2RbYWLONBzbIKJvBPULmIk/UlkrBma/4cglySSX/vbp6EcYS4SRyplaO2tMEeVCV64XRIaZ5kDbq95oIPrzDsstaMRklK6+eyQu13AHbzL1ey19XchN7Yut3YS0hYPD8E0B1mvVhfs04OsV58ITDyHD+coCCgivQsfVQb0l+fp9OiRmC6rHb6DSSwVn87TRpb851HQJfwIWhWqZKAPblRFiBxngSNiS+VSnm8Y0NV1m/tXgIYoS0nJmBBuCkPJslVRrRn8hAAdlkgXNtmGFFZn/CTJWTBoYp3e2nLFSnB1ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2WMi9DWalKfawkgbPzZMmmO0JisHja4ifJZM74rdk5U=; b=hQoDsn9YxloCOid+ZEgDztt6t2o7Wl5a+cQM6Ubk1FXuAWVYwKvAW0tuJFcosRAt5KJsqNR6qVRRNvpDNp7IUePn6kuoFnXodr5F0N2qRsPHsisRPgyVfJgSGMcf9KzJuUoKsd5gxKH6SMF6S8hkFYOkojZBvQ7h7nhLnt/nbsc= Date: Wed, 24 Mar 2021 14:55:15 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andy Shevchenko CC: , , "Mika Westerberg" , Andy Shevchenko , Linus Walleij , Subject: Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region Message-ID: References: <20210324123118.58865-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR2P264CA0088.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::28) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 46234069-c4e5-42bc-451f-08d8eecc772a X-MS-TrafficTypeDiagnostic: DS7PR03MB5608: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SZFg//SnTMxh0qkyAtK9K45HvCOqJc1TMrqkx7GDSdp3imvvZ+u86qS6xGAJz2MPK68aaFuJpB5DRekh6Et9HR/zhY5aRUwJkDJw0QIp4FX9WitsDVtWVRqUkbz8DaSXVvzvi2h5B4ifS4dvYiZxns9I/BAuDgxvM56wgNulLcTvaU6a7ortrPYfjKoek+GdYEsT9zIJCHq7Rbd/133EOstlAUaLDWJJMaB43+dyvrjdmFY7K23by5SFL9BpcOCjzvrXuSPfg0G1s1iG5KL8cF/F+HJIBH5O0qMJYRkSDyMqkYtdpWrCbvCIA2T8S+Vesz07OysEIzAbmc+7LKm5r1i0LPhBTNm7tsgsxI6x0/fr0g6q4iCL6LqpKICfxU6M+ELq8MAdLfOk1Jrb3IOlZT9OV7ae9RARUpTu0rA2wUzk9AkJQAkwcI51ZOYzI9SP2kP4Xrt7VTbAjWPTLuAM0GvV0iDd0VMchUfr68esDs4vxSLVTPrbaor7BCcUXVtq7w6mrFyiigO/4N75HxVaUw3Th9JDr5fdXajBcxWZ9UhendIt1/IZeL/A+umcU1VEpwXLgdi4FSsv7m8GTN3OLGwp6fkATXMSG1yFDuBrB7WxKcEOktLDm4gK8dFuGzzQgHWqFwEC9VaClXjyAmqmvX+kb5kmmI5ISqixeYCd9YJSx4c019q9mO1F/w8uQhKZCfO9lKPTtNp5hK+djyEj1HavERRQPs4J9iNWPiRZYawdDpvja5N7M+kVST1/Fj/7 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(346002)(136003)(39860400002)(376002)(396003)(8676002)(9686003)(478600001)(966005)(26005)(2906002)(186003)(316002)(956004)(83380400001)(16526019)(33716001)(38100700001)(54906003)(8936002)(4326008)(6496006)(66556008)(66946007)(66476007)(86362001)(5660300002)(6486002)(6666004)(6916009)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?c1Q2MGR0V09MM0hKV2tRNjB1L3BrbkVxdmNpblFqUGFCRC9BSnNUcGZ6dldn?= =?utf-8?B?aW92Tkh6ZmJGU21hVUIrc1FVU0paRjg0cW1NZm9FWklQL0pKcGVobE5CdlI3?= =?utf-8?B?dUdtOTc2RTBEMlhnSVNFdHZ5M05LV2RuZ0szWUFqaFZxQ0lqdzE0by9zOHpD?= =?utf-8?B?amxBakxtV0o2UHJjaTZtWllIWmZ2MDFZWnNKSjNGSU10cU9ObnhaWThWS0Q1?= =?utf-8?B?M0JwbXVGNFNkcm5CTkdFcEVOUTB2a0hsNk4raDFvaDN3a0ZjY0pJUkdPblh4?= =?utf-8?B?OU5ZKy8wam5MaTZha2JzRktFSGtkZUpCZjg1RG43Q1d1ZkE3OS9WS3lmK0Zu?= =?utf-8?B?SlJCQTRkdU12SndzS0tQZGZud2JQUllaRkt2T1UyTjh6NUJvU3FDTGNlcmpL?= =?utf-8?B?a1lMbWVySmorSWhSMkpMQlBiQU5Yd1VOWExxOEh0Y1l5TGErNHNnMFRsay9t?= =?utf-8?B?Qmo4aTEwMUcyem96bHY3R2RaaEdFMEwxUXVVZ3J0dnNkMFBEeGVST3VrdGVD?= =?utf-8?B?YTI5WUhmeW1zeTQ2S0NZcFNVdkNma1B5TVdFM2Q2bWFaaVBENTA3UVZ4VE00?= =?utf-8?B?bXBOZlF4dkV2NlhrNTU1alF6WkMzWXdGdXVqUTA4NjhLQ1RuOVZpZUNqVnZw?= =?utf-8?B?TkRrU2tTTURHRlJuL1hnVmNHWjVnYjVLbTFjT0dHdkxlbUl1cWhuY0FUS3p0?= =?utf-8?B?YmdhRW0yRzhJcit5WmZ3R3ROdS9DTE5nVUJ6NklrcW5mYVRhYUMxYUFBMWxp?= =?utf-8?B?alkvL3BoT3J4OGV6eDgyYUVyQkFreWFrSm1rMFFNTFM3d2Z2cWY1aThCUTJK?= =?utf-8?B?Y0JIK2k2dFNha2tFaVdTK1ZzQ3JzNjhlcFB2M3kyYkN2TkpPK1MrdmY3ODQv?= =?utf-8?B?amdFb25OREJRbkZrSmZ0RDBmWmZjU1Bza0ovcERPTjdpOVFEdll2T2dVL1JJ?= =?utf-8?B?SjJHUmdGZlhLcmZwS2lYYVN6cmtPRHVhSEZNWXB1NnRIdkxMa0tZUWVhT0xw?= =?utf-8?B?ejBaV2V4by9sdHNnWDJHOTg1L3JVZndHOFBRYjFGeHVzUzZxbUFhT1RRZ2k2?= =?utf-8?B?TlNNQWtHeWExUDBGTjVuVUxkVS9vZW1TWlRUdGhXL01MeVk0VEhjQTNvZ2tw?= =?utf-8?B?cFcweEZLNXZxWk5aRjBXcHBCUDIyNXptQXh2WGtsem1LQ2JaWGpzdUVldVNN?= =?utf-8?B?UHlaYkZ5b29wLzZ5eXN0WmpPeXIvYnhSUW11Vm52NExRQTFXTGMvcWs3aURy?= =?utf-8?B?VTdSVFd1cnhlVUJQNU5FYXJKbFRnTlVsUk9UVS8veEpwU08rMGNEbmhTcHdH?= =?utf-8?B?SlBUaGNCM3pMM0VUNm5FKzZSWEZkbUFRUDM3cXFFUlFub0ZxenRNNUZld1pN?= =?utf-8?B?Y1YxZ3pacG5nTnUvVDU4WnB3WDhqUEYzOWpjWUlSM3ViWm0weUc5eUhCSmY5?= =?utf-8?B?SktkL3ZCS1FWeW4zR3lTb01Xd3RyNlVLWDFFLzl5MlE4NjN3QUdyN0l6WWZK?= =?utf-8?B?b1ZtcmlWRFhhMmtGTVg5OXZnRGJOUUVwRXNTbGxZRUxFdjM5cWY0bU5GQW5s?= =?utf-8?B?YzQydEwxTVV1c1UraHJqYjRhMHJxTmV6a0JVN3NMc0FRZ2djZTZZNXRMcVRW?= =?utf-8?B?VUE5ZkdMVDNuUXE1Q3JwWGlFZ0c5QmVoMVBCd0JEcWkwL3k3WkkwSmpzQzlr?= =?utf-8?B?RnJFRW1HcUFmTXhyVnVrSTEwZzZ4T3BTRHVGU2lhbE9UYmphR3pwWGxxNHZl?= =?utf-8?Q?h0F+ua32OfFJG5PFh3p/UgVsVq1F6Ru5zW3rdL0?= X-MS-Exchange-CrossTenant-Network-Message-Id: 46234069-c4e5-42bc-451f-08d8eecc772a X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 13:55:21.4625 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8t34VwHlWUbuz4tD1esxb0qMjNWboxbVP5UwX5CtjncpdYWXtXvJtxp9mxWYmX/45K27ti1GPOPNQE3gSx9N1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5608 X-OriginatorOrg: citrix.com On Wed, Mar 24, 2021 at 02:58:07PM +0200, Andy Shevchenko wrote: > On Wed, Mar 24, 2021 at 01:31:18PM +0100, Roger Pau Monne wrote: > > When parsing the capability list make sure the offset is between the > > MMIO region mapped in 'regs', or else the kernel hits a page fault. > > > > This fault has been seen when running as a Xen PVH dom0, which doesn't > > have the MMIO regions mapped into the domain physical memory map, > > despite having the device reported in the ACPI DSDT table. This > > results in reporting a capability offset of 0xffff (because the kernel > > is accessing unpopulated memory), and such offset is outside of the > > mapped region. > > > > Adding the check is harmless, and prevents buggy or broken systems > > from crashing the kernel if the MMIO region is not properly reported. > > Thanks for the report. > > Looking into the code I would like rather see the explicit comparison to 0xffff > or ~0 against entire register b/c it's (one of) standard way of devices to tell > that something is not supported. That can be done also. I think what I've proposed is slightly more robust, as it will prevent a kernel page fault if somehow the offset to the next capability is below ~0, but past the end of the MMIO region. Unlikely I know, but it's not worth a kernel panic. What could be done is check whether reading REVID returns ~0 and exit at that point, if ~0 will never be a valid value returned by that register. I think that should be a separate patch however. > Moreover, it seems you are bailing out and basically denying driver to load. > This does look that capability is simply the first register that blows the setup. > I think you have to fix something into Xen to avoid loading these drivers or > check with something like pci_device_is_present() approach. Is there a backing PCI device BAR for those MMIO regions that the pinctrl driver is trying to access? AFAICT those regions are only reported in the ACPI DSDT table on the _CRS method of the object (at least on my system). Doing something like pci_device_is_present would require a register that we know will never return ~0 unless the device is not present. As said above, maybe we could use REVID to that end? > > Fixes: 91d898e51e60 ('pinctrl: intel: Convert capability list to features') > > Signed-off-by: Roger Pau Monné > > --- > > Cc: Mika Westerberg > > Cc: Andy Shevchenko > > Cc: Linus Walleij > > Cc: linux-gpio@vger.kernel.org > > --- > > Resend because I've missed adding the maintainers, sorry for the spam. > > I have a script to make it easier: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh Thanks! From xen-devel-bounces@lists.xenproject.org Wed Mar 24 14:10:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 14:10:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101022.192846 (Exim 4.92) (envelope-from ) id 1lP4Co-0000De-QF; Wed, 24 Mar 2021 14:09:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101022.192846; Wed, 24 Mar 2021 14:09:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP4Co-0000DX-NA; Wed, 24 Mar 2021 14:09:54 +0000 Received: by outflank-mailman (input) for mailman id 101022; Wed, 24 Mar 2021 14:09:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP4Cn-0000DS-Gh for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 14:09:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP4Cm-0002S0-2W; Wed, 24 Mar 2021 14:09:52 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lP4Cl-0000mz-So; Wed, 24 Mar 2021 14:09:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Vihx1o6sfVYFq29apSCGABYusFxApavcEm7NpdHdVOM=; b=yKp0BD1wKvOwQcHhH412d0Tvus rw5xgvebldDGRaeCQCtlKMIXgW5/edQ5eVIq8MJVyrH8D9p9LMqddn7COyWkKjRS8iQNdAPTVq1fK /92+ElC0rokjO+wlTMZE7KC6iBZx1t4jzq1O+4A3m2r9tVEgqIX55TQCi3EHNwuPQDBk=; Subject: Re: [PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Andrew Cooper References: <20210324113035.32691-1-jgross@suse.com> From: Julien Grall Message-ID: <043461f3-9b5e-7d29-bc52-275d663579c9@xen.org> Date: Wed, 24 Mar 2021 14:09:36 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210324113035.32691-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Juergen, On 24/03/2021 11:30, Juergen Gross wrote: > xenstore_lib.h is in need to be tidied up a little bit: > > - the definition of struct xs_tdb_record_hdr shouldn't be here > - some symbols are not namespaced correctly > > Signed-off-by: Juergen Gross > --- > V2: minimal variant (Ian Jackson) > --- > tools/include/xenstore_lib.h | 17 ++++------------- > tools/libs/store/libxenstore.map | 6 +++--- > tools/libs/store/xs.c | 12 ++++++------ > tools/xenstore/utils.h | 11 +++++++++++ > tools/xenstore/xenstore_client.c | 12 ++++++------ > 5 files changed, 30 insertions(+), 28 deletions(-) > > diff --git a/tools/include/xenstore_lib.h b/tools/include/xenstore_lib.h > index 4c9b6d1685..f74ad7024b 100644 > --- a/tools/include/xenstore_lib.h > +++ b/tools/include/xenstore_lib.h > @@ -43,15 +43,6 @@ struct xs_permissions > enum xs_perm_type perms; > }; > > -/* Header of the node record in tdb. */ > -struct xs_tdb_record_hdr { > - uint64_t generation; > - uint32_t num_perms; > - uint32_t datalen; > - uint32_t childlen; > - struct xs_permissions perms[0]; > -}; > - > /* Each 10 bits takes ~ 3 digits, plus one, plus one for nul terminator. */ > #define MAX_STRLEN(x) ((sizeof(x) * CHAR_BIT + CHAR_BIT-1) / 10 * 3 + 2) > > @@ -78,18 +69,18 @@ bool xs_perm_to_string(const struct xs_permissions *perm, > unsigned int xs_count_strings(const char *strings, unsigned int len); > > /* Sanitising (quoting) possibly-binary strings. */ > -struct expanding_buffer { > +struct xs_expanding_buffer { > char *buf; > int avail; > }; > > /* Ensure that given expanding buffer has at least min_avail characters. */ > -char *expanding_buffer_ensure(struct expanding_buffer *, int min_avail); > +char *xs_expanding_buffer_ensure(struct xs_expanding_buffer *, int min_avail); > > /* sanitise_value() may return NULL if malloc fails. */ > -char *sanitise_value(struct expanding_buffer *, const char *val, unsigned len); > +char *xs_sanitise_value(struct xs_expanding_buffer *, const char *val, unsigned len); > > /* *out_len_r on entry is ignored; out must be at least strlen(in)+1 bytes. */ > -void unsanitise_value(char *out, unsigned *out_len_r, const char *in); > +void xs_unsanitise_value(char *out, unsigned *out_len_r, const char *in); > > #endif /* XENSTORE_LIB_H */ > diff --git a/tools/libs/store/libxenstore.map b/tools/libs/store/libxenstore.map > index 9854305a2c..fc1c213f13 100644 > --- a/tools/libs/store/libxenstore.map > +++ b/tools/libs/store/libxenstore.map > @@ -42,8 +42,8 @@ VERS_3.0.3 { > xs_strings_to_perms; > xs_perm_to_string; > xs_count_strings; > - expanding_buffer_ensure; > - sanitise_value; > - unsanitise_value; > + xs_expanding_buffer_ensure; > + xs_sanitise_value; > + xs_unsanitise_value; Isn't libxenstore considered stable? If so, shouldn't we bump the version to avoid any breakage for existing app? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 24 14:18:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 14:18:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101006.192859 (Exim 4.92) (envelope-from ) id 1lP4Ko-0001Ev-LV; Wed, 24 Mar 2021 14:18:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101006.192859; Wed, 24 Mar 2021 14:18:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP4Ko-0001Eo-Ib; Wed, 24 Mar 2021 14:18:10 +0000 Received: by outflank-mailman (input) for mailman id 101006; Wed, 24 Mar 2021 13:28:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP3Z9-0004SL-EM for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 13:28:55 +0000 Received: from mail-qk1-x734.google.com (unknown [2607:f8b0:4864:20::734]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3c808549-f3bf-4382-83eb-b18b74097656; Wed, 24 Mar 2021 13:28:54 +0000 (UTC) Received: by mail-qk1-x734.google.com with SMTP id y18so17922405qky.11 for ; Wed, 24 Mar 2021 06:28:54 -0700 (PDT) Received: from Slackware.localdomain ([156.146.36.138]) by smtp.gmail.com with ESMTPSA id k138sm1620627qke.60.2021.03.24.06.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 06:28:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c808549-f3bf-4382-83eb-b18b74097656 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZA4TMh4IQBJtlxJtgRg6PC7dBsn/y/DHlKXiLg69OBw=; b=vIAeFill0cXse/9RJBHavhpguN7xSunFa2f+v2bdmqARM2G7mS5PMrrSXhVx41lH6C KEoxKR6UuHlDbKnwsl3p8z1F9EFzOiKeQiP6l1rb3/izBA9tTqaPzehpikrq0vZSDJqX 4aYH5LwedhVmaeOhOF27DD4tsZ7vIEXYAtxgGiJFJze7Yym/DsuR2d8v52g6HBlbPBSJ Q83bXj2BXfllIoypNNVaug2C5phbhumK16MeagjM7IQ1G0/qdfuzKUrqONR+ykO933p9 oUZtP2EDjgf8AIShCLpnSfIN1xoyKJiMYl4vIR+CYy9PfPkNg11J+z29APLScd3neX/j inRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZA4TMh4IQBJtlxJtgRg6PC7dBsn/y/DHlKXiLg69OBw=; b=Hdkg9AOg7EiP0HwZS2DF/j79ctybFdYSBXow4KcpzVP8P99zxqqJgY2DxV1DUicJL9 KDY4UzXApQumyrZOfu+qO3INioocHlhCwq89ILOJ5U74Y6c7wo3ShrIpAHqS6cDwOU/S KmDRh1qPuujV0oiZjFgV8IsU7jeRuy9Y4rcdVGj44E8tUSCP4avElih5iJfjDUGsXBoO /tTKEo295FaODoo8JeYswJFfooKffj2Ag5OvSu5h8OFt+UaoAmSWGt15kaIL45NvZC1n wJoD3NjbuddjYXZEyMuRTCblFZkrQjyUfEv5BZXBmplFH16CJZuswkQQ2S9gqlK5KSCb yVUA== X-Gm-Message-State: AOAM5303t7rkWMbUfYbsTuvdt3Qu8AvyYrRU2S91M45i4A8aeCwOi2Cc qqEarmjWTg8pxd95lHq7bbE= X-Google-Smtp-Source: ABdhPJy2CjjpOmQpimqajsFZOrQh+V4XiC9VHO5NNVgJMDvkS8TP9WHAV0Aahm5348sd/33RwTJrfA== X-Received: by 2002:a37:a2c2:: with SMTP id l185mr2986406qke.178.1616592534322; Wed, 24 Mar 2021 06:28:54 -0700 (PDT) From: Bhaskar Chowdhury To: sstabellini@kernel.org, linux@armlinux.org.uk, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: rdunlap@infradead.org, Bhaskar Chowdhury Subject: [PATCH] ARM: xen/mm.c: A mundane typo fix Date: Wed, 24 Mar 2021 19:00:36 +0530 Message-Id: <20210324133036.17665-1-unixbhaskar@gmail.com> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit s/acrros/across/ Signed-off-by: Bhaskar Chowdhury --- arch/arm/xen/mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c index 467fa225c3d0..be7c942c74bf 100644 --- a/arch/arm/xen/mm.c +++ b/arch/arm/xen/mm.c @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev, * - The Linux page refers to foreign memory * - The device doesn't support coherent DMA request * - * The Linux page may be spanned acrros multiple Xen page, although + * The Linux page may be spanned across multiple Xen page, although * it's not possible to have a mix of local and foreign Xen page. * Furthermore, range_straddles_page_boundary is already checking * if buffer is physically contiguous in the host RAM. -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 14:22:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 14:22:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101027.192870 (Exim 4.92) (envelope-from ) id 1lP4PO-00025T-8H; Wed, 24 Mar 2021 14:22:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101027.192870; Wed, 24 Mar 2021 14:22:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP4PO-00025M-5D; Wed, 24 Mar 2021 14:22:54 +0000 Received: by outflank-mailman (input) for mailman id 101027; Wed, 24 Mar 2021 14:22:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP4PM-00025H-Qh for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 14:22:52 +0000 Received: from mga14.intel.com (unknown [192.55.52.115]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id daeefe23-cc93-45d5-bf85-cdef9f8b79e8; Wed, 24 Mar 2021 14:22:50 +0000 (UTC) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 07:22:49 -0700 Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 07:22:47 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lP4PE-00FiD8-Q7; Wed, 24 Mar 2021 16:22:44 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: daeefe23-cc93-45d5-bf85-cdef9f8b79e8 IronPort-SDR: MTK+kCSekNPsmTluonGr3LavgbNq9QVbr2UwXn9vEQ04vV8C4gYrimlGjp8pz0VNtM1uwQI+BH GPb0q2r8eXgw== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="190129693" X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="190129693" IronPort-SDR: VwrKILIj/QZQwCX9DSJSCDYw53ud/1y/6178HuzK5RgnLGH3tp2RGzmj30o19mEzRgutOVgMQp I1vu/hV9te2A== X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="391317293" Date: Wed, 24 Mar 2021 16:22:44 +0200 From: Andy Shevchenko To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Mika Westerberg , Linus Walleij , linux-gpio@vger.kernel.org Subject: Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region Message-ID: References: <20210324123118.58865-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Mar 24, 2021 at 02:55:15PM +0100, Roger Pau Monn wrote: > On Wed, Mar 24, 2021 at 02:58:07PM +0200, Andy Shevchenko wrote: > > On Wed, Mar 24, 2021 at 01:31:18PM +0100, Roger Pau Monne wrote: ... > What could be done is check whether reading REVID returns ~0 and exit > at that point, if ~0 will never be a valid value returned by that > register. I think that should be a separate patch however. Sounds good to me. > > Moreover, it seems you are bailing out and basically denying driver to load. > > This does look that capability is simply the first register that blows the setup. > > I think you have to fix something into Xen to avoid loading these drivers or > > check with something like pci_device_is_present() approach. > > Is there a backing PCI device BAR for those MMIO regions that the > pinctrl driver is trying to access? AFAICT those regions are only > reported in the ACPI DSDT table on the _CRS method of the object (at > least on my system). Unfortunately it does not expose PCI configuration space. > Doing something like pci_device_is_present would require a register > that we know will never return ~0 unless the device is not present. As > said above, maybe we could use REVID to that end? Yes, that's good, see above. WRT capabilities, if we crash we will see the report immediately on the hardware which has such an issue. (It's quite unlikely we will ever have one, that's why I consider it's not critical) -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Wed Mar 24 14:28:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 14:28:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101030.192883 (Exim 4.92) (envelope-from ) id 1lP4UW-0002OR-SH; Wed, 24 Mar 2021 14:28:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101030.192883; Wed, 24 Mar 2021 14:28:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP4UW-0002OK-PC; Wed, 24 Mar 2021 14:28:12 +0000 Received: by outflank-mailman (input) for mailman id 101030; Wed, 24 Mar 2021 14:28:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP4UV-0002OC-DV; Wed, 24 Mar 2021 14:28:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP4UV-0002lk-6M; Wed, 24 Mar 2021 14:28:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP4UU-0000TI-RE; Wed, 24 Mar 2021 14:28:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lP4UU-0004xL-Qh; Wed, 24 Mar 2021 14:28:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mDkeszcfXB64fCCvIsxIHMZczuqnoCUpbzB8hIz5as4=; b=h+jk4NdSBve+nJBd4b5M22WkEF XqHaSjIuci0CbqDJWDekx3UtJQwb5gsYdfRcEXsgYPgoZ75HyBWTt8AYRJ4Ja9j6BQY6t7MnWszOM YiOpkQw2z4WL2mmiTrVlJMgJnTxoYxGEUWerbu6U46YExHeQvVJ9OQKiBDThvcLf2Ayg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160361: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=5ca634afcf83215a9a54ca6e66032325b5ffb5f6 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Wed, 24 Mar 2021 14:28:10 +0000 flight 160361 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160361/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 5ca634afcf83215a9a54ca6e66032325b5ffb5f6 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 216 days Failing since 152659 2020-08-21 14:07:39 Z 215 days 411 attempts Testing same since 160361 2021-03-23 14:45:44 Z 0 days 1 attempts ------------------------------------------------------------ 461 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 135572 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 24 14:33:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 14:33:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101038.192898 (Exim 4.92) (envelope-from ) id 1lP4Zq-0003H8-Mh; Wed, 24 Mar 2021 14:33:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101038.192898; Wed, 24 Mar 2021 14:33:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP4Zq-0003H1-Jh; Wed, 24 Mar 2021 14:33:42 +0000 Received: by outflank-mailman (input) for mailman id 101038; Wed, 24 Mar 2021 14:33:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP4Zp-0003Gw-M0 for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 14:33:41 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 672a35e8-a348-4e98-8b7a-962e36718b72; Wed, 24 Mar 2021 14:33:40 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id ED58DAD71; Wed, 24 Mar 2021 14:33:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 672a35e8-a348-4e98-8b7a-962e36718b72 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616596420; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e7O6wYBwRTWDHH+9K25PLF7adhliAliaratZDYHJsoE=; b=Z9JubgCgL/uCyjyt+lnI0P0x0mChc245CB8mHbDMm6DbSEEt/KjyPr0mQ5tAWgGk1R/3ki Bz22jfhDPL8FFaGLB5YMXGM2H84j8Xdl5vtECrfgbEzuWkG0jU3uzAR0wUHJ7OKx9tfVAS WRjApHQv/a7FSceqZ4GcYs/qv/jo00A= Subject: Re: [PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface To: Julien Grall , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Andrew Cooper References: <20210324113035.32691-1-jgross@suse.com> <043461f3-9b5e-7d29-bc52-275d663579c9@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <88a63fe9-e752-285d-3a3f-f00db02df980@suse.com> Date: Wed, 24 Mar 2021 15:33:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <043461f3-9b5e-7d29-bc52-275d663579c9@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dLZiR1TFE3jfV6P41ejYBDaHLjeh8d2cW" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dLZiR1TFE3jfV6P41ejYBDaHLjeh8d2cW Content-Type: multipart/mixed; boundary="0s4sHMYbdtnWM6dNywJ84eBya1rvwbwJ3"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Andrew Cooper Message-ID: <88a63fe9-e752-285d-3a3f-f00db02df980@suse.com> Subject: Re: [PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface References: <20210324113035.32691-1-jgross@suse.com> <043461f3-9b5e-7d29-bc52-275d663579c9@xen.org> In-Reply-To: <043461f3-9b5e-7d29-bc52-275d663579c9@xen.org> --0s4sHMYbdtnWM6dNywJ84eBya1rvwbwJ3 Content-Type: multipart/mixed; boundary="------------39B79158E291CA851F0A7E61" Content-Language: en-US This is a multi-part message in MIME format. --------------39B79158E291CA851F0A7E61 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 24.03.21 15:09, Julien Grall wrote: > Hi Juergen, >=20 > On 24/03/2021 11:30, Juergen Gross wrote: >> xenstore_lib.h is in need to be tidied up a little bit: >> >> - the definition of struct xs_tdb_record_hdr shouldn't be here >> - some symbols are not namespaced correctly >> >> Signed-off-by: Juergen Gross >> --- >> V2: minimal variant (Ian Jackson) >> --- >> =C2=A0 tools/include/xenstore_lib.h=C2=A0=C2=A0=C2=A0=C2=A0 | 17 ++++-= ------------ >> =C2=A0 tools/libs/store/libxenstore.map |=C2=A0 6 +++--- >> =C2=A0 tools/libs/store/xs.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 | 12 ++++++------ >> =C2=A0 tools/xenstore/utils.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 | 11 +++++++++++ >> =C2=A0 tools/xenstore/xenstore_client.c | 12 ++++++------ >> =C2=A0 5 files changed, 30 insertions(+), 28 deletions(-) >> >> diff --git a/tools/include/xenstore_lib.h b/tools/include/xenstore_lib= =2Eh >> index 4c9b6d1685..f74ad7024b 100644 >> --- a/tools/include/xenstore_lib.h >> +++ b/tools/include/xenstore_lib.h >> @@ -43,15 +43,6 @@ struct xs_permissions >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 enum xs_perm_type perms; >> =C2=A0 }; >> -/* Header of the node record in tdb. */ >> -struct xs_tdb_record_hdr { >> -=C2=A0=C2=A0=C2=A0 uint64_t generation; >> -=C2=A0=C2=A0=C2=A0 uint32_t num_perms; >> -=C2=A0=C2=A0=C2=A0 uint32_t datalen; >> -=C2=A0=C2=A0=C2=A0 uint32_t childlen; >> -=C2=A0=C2=A0=C2=A0 struct xs_permissions perms[0]; >> -}; >> - >> =C2=A0 /* Each 10 bits takes ~ 3 digits, plus one, plus one for nul=20 >> terminator. */ >> =C2=A0 #define MAX_STRLEN(x) ((sizeof(x) * CHAR_BIT + CHAR_BIT-1) / 10= * 3=20 >> + 2) >> @@ -78,18 +69,18 @@ bool xs_perm_to_string(const struct xs_permissions= =20 >> *perm, >> =C2=A0 unsigned int xs_count_strings(const char *strings, unsigned int= len); >> =C2=A0 /* Sanitising (quoting) possibly-binary strings. */ >> -struct expanding_buffer { >> +struct xs_expanding_buffer { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 char *buf; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int avail; >> =C2=A0 }; >> =C2=A0 /* Ensure that given expanding buffer has at least min_avail=20 >> characters. */ >> -char *expanding_buffer_ensure(struct expanding_buffer *, int min_avai= l); >> +char *xs_expanding_buffer_ensure(struct xs_expanding_buffer *, int=20 >> min_avail); >> =C2=A0 /* sanitise_value() may return NULL if malloc fails. */ >> -char *sanitise_value(struct expanding_buffer *, const char *val,=20 >> unsigned len); >> +char *xs_sanitise_value(struct xs_expanding_buffer *, const char=20 >> *val, unsigned len); >> =C2=A0 /* *out_len_r on entry is ignored; out must be at least strlen(= in)+1=20 >> bytes. */ >> -void unsanitise_value(char *out, unsigned *out_len_r, const char *in)= ; >> +void xs_unsanitise_value(char *out, unsigned *out_len_r, const char=20 >> *in); >> =C2=A0 #endif /* XENSTORE_LIB_H */ >> diff --git a/tools/libs/store/libxenstore.map=20 >> b/tools/libs/store/libxenstore.map >> index 9854305a2c..fc1c213f13 100644 >> --- a/tools/libs/store/libxenstore.map >> +++ b/tools/libs/store/libxenstore.map >> @@ -42,8 +42,8 @@ VERS_3.0.3 { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xs_strings_to_p= erms; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xs_perm_to_stri= ng; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xs_count_string= s; >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 expanding_buffer_ensure; >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sanitise_value; >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsanitise_value; >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xs_expanding_buffer_ensure= ; >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xs_sanitise_value; >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xs_unsanitise_value; >=20 > Isn't libxenstore considered stable? If so, shouldn't we bump the=20 > version to avoid any breakage for existing app? See https://lists.xen.org/archives/html/xen-devel/2021-03/msg01267.html Juergen --------------39B79158E291CA851F0A7E61 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------39B79158E291CA851F0A7E61-- --0s4sHMYbdtnWM6dNywJ84eBya1rvwbwJ3-- --dLZiR1TFE3jfV6P41ejYBDaHLjeh8d2cW Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBbTcMFAwAAAAAACgkQsN6d1ii/Ey+t KAgAj092oOEHz/FWoRO4HUJW0a9WRurCdKFlUPqLoCG418vEHH64ijlDBOWhvL+Z8wl9FFcyL1BQ MeuGzVvyh7tgjmPVus4r7G7bDpJXThIclacLjXS8Nrlyn/LWnPZsky+k9iLOa2t5pt01TrSQmxd9 AXTQzVb8I0q4fLKmgFb9FWRmm5O+uvUlXI9KTwHQNZrgNWz+Yqv/2Kiu9V9dlqAmYBdJIR2opbAw 03NtZxDcp2Oyg308uUoGaxeVBaR4gYUyFSsUQCu/rsV5iumP7vG39UsKf56RkvnoQaMZqbwNENWV SbP7kNuMn3D28wlvDCqEZiv7JcAI9GlhGJ5kROCMow== =P/KB -----END PGP SIGNATURE----- --dLZiR1TFE3jfV6P41ejYBDaHLjeh8d2cW-- From xen-devel-bounces@lists.xenproject.org Wed Mar 24 15:10:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 15:10:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101041.192910 (Exim 4.92) (envelope-from ) id 1lP59B-0007Ap-Et; Wed, 24 Mar 2021 15:10:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101041.192910; Wed, 24 Mar 2021 15:10:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP59B-0007Ai-BF; Wed, 24 Mar 2021 15:10:13 +0000 Received: by outflank-mailman (input) for mailman id 101041; Wed, 24 Mar 2021 15:10:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP59A-0007Ad-5C for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 15:10:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP59A-0003SH-2W for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 15:10:12 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lP59A-0004kZ-0l for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 15:10:12 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lP596-0005JM-Oe; Wed, 24 Mar 2021 15:10:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID: Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=vOKPkQ3EO4YBVmANwGHqZ4te15u5DiLPNnC+8ZaHj5g=; b=o6OaSvbMb0JGCPSg313k4KhMEl 0/IkA8lZs7XKijrhk9264SxPaXgdQh7vUQ2w48M/H0w9miq+mkuw3C/8ihe4knqmAThQXEIuBiO/5 P8V89lVAtbhDgOOAtQDcH5r6Iqofz43eiNWkzgVsnwmlyNKBXRAyIP5CLZycBQWmIs6M=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24667.22096.470958.627753@mariner.uk.xensource.com> Date: Wed, 24 Mar 2021 15:10:08 +0000 To: committers@xenproject.org CC: xen-devel@lists.xenproject.org Subject: Commit moratorium for branching X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Please do not push any commits to xen.git#staging, corresponding qemu branches, etc. I'm going to make the 4.15 branch etc. I will let you know when I'm done. Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 24 15:14:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 15:14:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101045.192925 (Exim 4.92) (envelope-from ) id 1lP5D3-0007Jf-11; Wed, 24 Mar 2021 15:14:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101045.192925; Wed, 24 Mar 2021 15:14:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5D2-0007JY-U6; Wed, 24 Mar 2021 15:14:12 +0000 Received: by outflank-mailman (input) for mailman id 101045; Wed, 24 Mar 2021 15:14:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5D1-0007JS-J1 for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 15:14:11 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 41dcb849-3dcf-4bd8-91e7-751ef47d4ca5; Wed, 24 Mar 2021 15:14:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41dcb849-3dcf-4bd8-91e7-751ef47d4ca5 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616598849; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=wG4im1BTW2ovd2UN98LBR1DeI+7tH225IUFzOgweV5g=; b=JrFrVWa9dbVU7g2XGBU+5BlroyF4AwFQritsGQ+272kB+0oU1AfmdxN0 8YUdXRxx669U8AY7cdfI+z6lSBMss6/YMseL3wS4xjfJhYjf030aRtmNU MDh0rl946sQQWGhYnus1b5uWcA8VuoTXITbNxJ7DXfzVqmqC6JMvv34by 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: WPgl8n6C1t9qqptT2KlYIcusDPet5S6aMpDU2n8dy3iid03VuoyjBToIx4kDSopOuQvyFDwxF3 1AxeTRbFgHlolX61kz1IsHfkEzbwXkoDCDbc3UbO+G3q6cnbURy0iPgfjqZoPkf1OkGMfB5CcZ ERcpJLiHGEz6LPrx9QeI7dv9PbWmTe9PcailXEMCHyZ6o0SQPFzqH16+xypp6HbPSp3qczFtRn DoWP/WcfjQhuDQuR+Uue3CWfW6elF0ZIhJ1lPsTQ+ob5hTFwRuRPlcPbVqvJQuJD8gCofZhf/s 3nM= X-SBRS: 5.2 X-MesageID: 40034394 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:yc9NWqNChxiPE8BcTxP155DYdL4zR+YMi2QD/1xtSBBTb8yTn9 2vmvNe7hPvlDMNQhgb9OyoEqPoexPh3LRy5pQcOqrnYRn+tAKTXeVfxKbB4xmlIS3x8eZByb xtGpIVNPTcBUV35PyU3CCWCNAlqePozImNpcPzi0hgVhtrbaYI1XYdNi++HldtTAdLQboVfa DshfZvnDardXQJYsnTPBBsM9TrnNHXiIngJScPGh9P0mKzpAm14733GQXw5GZ9bxpzx94ZkF TtokjCyYiI99q6zRLd0GG71eUqpPLRjuFtKebJpswcKjDHghulaoJ7S9S5zUwIidDq0nkGup 3hpAohItRS5hrqDx6IiCqo4SbM+nIP7GLv0lCRi3eLm72GeBsKT/BvqKgcVzmx0TtGgPhMlJ hl8kjcir9sSTTHpyj578igbWAQqmOE5UAMvMRWs2ZSSuIlGdlshL1axmx5OrEaEhn37Yg2ed Medv301bJtfVSWY2uxhBgX/PWcGnA6HhKxSkMfoMCi0z9PgHBjz0cDrfZv5ks9yA== X-IronPort-AV: E=Sophos;i="5.81,274,1610427600"; d="scan'208";a="40034394" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RN40r+sN9kfv344l5vSEJ6OaOYPkby1+i+EDj9/SpDEyDl3kTIx8tSeqreKf5Ho+ne0pB13I0/fnBNkgvcpvV8OkoW48rNRMh4svK1flHMavv43Z6Ce6rdyAoUC+WvAAhHpeetVcYgdsKPi88Ed1jgMwTAueAGuFfDvOIe0FXugXp347EXxHJP8odlyoc0O6aGeudaDHFC11404LjJRqPaNMudMMNJhcdXmsyVM6XrNA81chTuQqsRhl9Vp06JZeUtWLsFzp0fYwOdKasWs+mrcahtDBLi3imJ7v44uHocLnvZPC6NhIICH6dObY3EHi0AhYXzUXKkHPvEQL6lucrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XrReSzt1viFtrrmsZHR21zzYTBDhjfiA/E7QWNDYML0=; b=MA6gjzc9keGC+CQZkFTD3Ds+G4T4q0LsCSXT71w8VfltAkVU/Y+DM+saIwhSDB1ETQ6ozDHqY+JhKoziRP08wC5A1FHQPYhTdmyjpgQWmiL/kerj+N1YbtR/cvWU6yWGdNgkPSAu05b6y0g6VAmXfHvBwyO9X3GG4Xxp0CEU52b412lxnddO5/wPHNhvdRyzUCQdk0ZdWsvx8Ecah4Lez2vh5WMx22hpJ+R4yANxomJyHkxT/vUXhwlWYJab/ID58bsYcgmJTZgHjflfrdhsTGfllpW3hMqysLC09kUVjyqL8WlfYn3/OCnFsMk6feOEPmIoXCXRhHklmewAO1lfQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XrReSzt1viFtrrmsZHR21zzYTBDhjfiA/E7QWNDYML0=; b=giu/EzXcUXgOTKUAkbxGRoHbGbKetEMrQvRNDZHd4EyOPxhpIaVfAyIRXDVTyf+Md0EZXllteM/AjNogcOKu2Nbp+RYn+flTKTSg1uwqUZHkK5OomSv7BN0/eF9VNvKR2p9EfDIine1b4E7DjCa197pNFGN03YtNHf/DK630DD8= Date: Wed, 24 Mar 2021 16:13:59 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andy Shevchenko CC: , , Mika Westerberg , Linus Walleij , Subject: Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region Message-ID: References: <20210324123118.58865-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR2P264CA0174.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e662c5f-0f50-42d4-021b-08d8eed77690 X-MS-TrafficTypeDiagnostic: DS7PR03MB5590: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SnnrdxuX5UCIOgYv80Hp35pCGLqC2enbOnbTOj6l66gFin8iIn4N/v/gHxWG54aBO6hkYy69wzMt4Ro72sUwyYNknu9mPX+BWd7NJksJKW8L4jOf+uJqYEBYeuoJ26y5GuUUJ1sCTccTg6/Hn6jIpnj8qWiqL1PqKoynHBylUBbv4tNCIN/YLKdhMxI/Lff2s8K3aW7ZjqO74S/teZ4ZRhx7s4cyVutYLrm4VIDVNq+6xPtyGusb9a+ntX75DsxHpitYOChpfhKPaIN9pGD761nGQtgUJRb2L35olA6uM19PRPg52YIjg3eIdTovHP3nxRZC6QqTTjArnrTAHbKXJJbKMJhamhgCmdxKS0UpmKcmUwlqwysdZ5/lCdzaKojRQkeLe/XPYlGVUcG/Z5dM9YESYQyY55KQH2kIx5ItybCm8e35m1Nxdg9ga0TRQHEoImXSPc0aOPZdGIFr5QfsSkIcK8q8s2amZkTo+cPOLHIqwdwju/f/wYxFRCc205ea01KJR0dFtP77cd58ilFMnJcTDJJhZ4dRH48M3yI3bU5fuXj7tq9z99QCDUTfMNebkbURgGVtXoBdrc5knfqt29ACCQExzJA8N2ziWIiHRs723VKRLp/VGzSzKyQUJb0eytILX7jEkO8Zs0B8lLWVo+eJkP5LIjuCiqYA4BQhqGQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(136003)(39860400002)(376002)(366004)(346002)(396003)(8676002)(26005)(956004)(8936002)(83380400001)(85182001)(6666004)(478600001)(186003)(16526019)(6486002)(54906003)(6496006)(4326008)(66946007)(2906002)(66556008)(66476007)(33716001)(6916009)(38100700001)(9686003)(5660300002)(86362001)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?cC8yaGlzQkFOclhZMzY5YlhObDd5WnJoZ0s1VnZVdnVZdjJqaFhCdDNOOHFu?= =?utf-8?B?a3ZyWEVZV3MzbjRVSlhaUnladys1M3gvdnk1ZmZrVUdYUXZ1UWFCZ2dzL2ZT?= =?utf-8?B?NktROVpLdjF4cUx0b0pVYVRrWE9KMitVRStsc05Jc0dmUmpxNldLNHZIc3Fs?= =?utf-8?B?bjBEc1dYdDVxdWRFUXIxcXlyK0VZeXNaM2JkL3JIdDhIV0pPY3BnWlhvaVZv?= =?utf-8?B?MVE4K3R5bFd2anlYWmZLdzl4N3VOMGprcklMRUdVWmVkazc1RHdjaHczRTNs?= =?utf-8?B?T2JHdDRRREI4Ky9iR1hwS3hLMEFvVzlpcCs0QytDcWRVMFpGSEhaWkdDN1Zz?= =?utf-8?B?YVJOZ1FKZDQxVXdRcnRDZ2JXZGVpUzkvSSsxZDZRTlNxK29COER1bUpyNnls?= =?utf-8?B?ajBYcXVlQVl3MzRLdHAxM21CRnBWb0pmV2JKekpWdTlYUmZ6ZDZMOFdzQThq?= =?utf-8?B?U1lBRDIvNU5IMDlLUkxDdndtTmgveVhCdThNck1UL1k0SlFtMkdrb21TNS9Z?= =?utf-8?B?TWJFWHc4MWJoOEVnSjVxazZ4VXljNVdXdXlHRGNubENadjI4NDI0dTVraFRt?= =?utf-8?B?Z3EyVVo3QlF1eWFBNWJkSHRJak53OVlFV3laaVc3Mzdib3lJOWpsMnFjTDg3?= =?utf-8?B?QmFEUVFNS2VsYUoxZU5ybWhTdXdLMU05SDVHZzVCd3JEazVlanhTRFdUeXR2?= =?utf-8?B?bXJiV3ZVSDE4cjdTaHZMZnZvM2xDdnVwdnRCQzRmNTBCb21sQVJ4dUFacC85?= =?utf-8?B?SjFtc201VldZWitTV3dxelh6czZaRHRQd0FNa2RpclVJWS9RNXE0SXJJbzVY?= =?utf-8?B?RElsSG1vYjNZTjNQR0ppcUJicXRtbDgvMUx2WnJ6NzR1eDIzR1hsTVV6bkRy?= =?utf-8?B?dFpGVGdSOXJzQXYrb1EvcUcrRTRvM2ZzOGE5Q3ZtUGpMb2s5d2dpazNqMEd4?= =?utf-8?B?TmlVS04yWFNBUzFFeVB5U1hLMnh5OThYeis4WTA4VFV0Z1JLV09TTnl5ZkVW?= =?utf-8?B?SnVEMnFoWHVxYWttQUF4cmJoSWtzN2xZUGIvaUhycXVQQjN3cGgrb3llTzB2?= =?utf-8?B?WmtYRzNBenZuVzNmSTRQK3ltenVDbnNZTFY1SDVna21lL3Q2R0pocDR0V2t1?= =?utf-8?B?aXNubWRxYVdEZm5YUXZRY3l1aHFlNFQweDJmTHBsbFo3Ny82clhzbHNWb0VN?= =?utf-8?B?a2tKR0xOQkZBSU1KclYreXFVUlh0ZW5SSUxxd25FOWV3WEkxSmZ6MktzTDd1?= =?utf-8?B?Z25HQUs1NkpyV3FJU2psTlRtNGU5cXBHTGFucHAxdUluTXpHcWYvcVllMDRE?= =?utf-8?B?MmdMOUlXNEVxbXFKVHlkK2d2Ly9lRGhENWFsTWZkSkthYTVFc1BaaTFBZGJG?= =?utf-8?B?cWZNeXl3MGFaQXFaVkQ1T3hTS0FqSG9DbHRSL1FWQjY1RGVxbCswc0NQM2JV?= =?utf-8?B?NVdHNy9OSmJJM2d4RjN0MUhjMDhtVklXeE54WEQ3V0MrcjJLNXg2Y2pNRnV6?= =?utf-8?B?TXl1a1ZocUZaemhteVdMcnFhN1ZaSTByYU9RWHBmcHBIM1NkTEhPZzZRcWlV?= =?utf-8?B?QkxRb2pmbUpONkFGeTVlUjIzZWhEVzVjZGNWQ1BrdWN3eVRqTXNmejlYSzVT?= =?utf-8?B?eFlKaHJJV0ZKOTBlWWxaMWtRd3RzdGY0cVBWZTdob1BiMlBra1ZtTlRxY3ZB?= =?utf-8?B?Q2N6OXliaGZkYVpIbUZqczJQZkZqK0d1NkNiMTRGNDdFc0NXdDBlQktHQW1v?= =?utf-8?Q?aeONHDALkbqRBbgucE+I4ocbqhbcVFA6MCibX60?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7e662c5f-0f50-42d4-021b-08d8eed77690 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 15:14:04.9514 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LJfOFZxQ0N+3KqUI5VQh2IA/rpmg7T8i23m0Y0j5eolRcVLBc9EVuS8ec7hjqmwaHy9HvA+7RsUwKILgCpT9lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5590 X-OriginatorOrg: citrix.com On Wed, Mar 24, 2021 at 04:22:44PM +0200, Andy Shevchenko wrote: > On Wed, Mar 24, 2021 at 02:55:15PM +0100, Roger Pau Monné wrote: > > On Wed, Mar 24, 2021 at 02:58:07PM +0200, Andy Shevchenko wrote: > > > On Wed, Mar 24, 2021 at 01:31:18PM +0100, Roger Pau Monne wrote: > > > Moreover, it seems you are bailing out and basically denying driver to load. > > > This does look that capability is simply the first register that blows the setup. > > > I think you have to fix something into Xen to avoid loading these drivers or > > > check with something like pci_device_is_present() approach. > > > > Is there a backing PCI device BAR for those MMIO regions that the > > pinctrl driver is trying to access? AFAICT those regions are only > > reported in the ACPI DSDT table on the _CRS method of the object (at > > least on my system). > > Unfortunately it does not expose PCI configuration space. Are those regions supposed to be marked as reserved in the memory map, or that's left to the discretion of the hardware vendor? > > Doing something like pci_device_is_present would require a register > > that we know will never return ~0 unless the device is not present. As > > said above, maybe we could use REVID to that end? > > Yes, that's good, see above. > > WRT capabilities, if we crash we will see the report immediately on the > hardware which has such an issue. (It's quite unlikely we will ever have one, > that's why I consider it's not critical) I would rather prefer to not crash, because I think the kernel should only resort to crashing when there's no alternative, and here it's perfectly fine to just print an error message and don't load the driver. IMO I would rather boot without pinctrl than get a panic if it turns out pinctrl capabilities list is somehow corrupted. It's a long shot, but the check added in order to prevent this scenario is minimal. In any case I will send a new version with the REVID check and this current patch. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 24 15:40:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 15:40:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101049.192940 (Exim 4.92) (envelope-from ) id 1lP5cb-0001oZ-7q; Wed, 24 Mar 2021 15:40:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101049.192940; Wed, 24 Mar 2021 15:40:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5cb-0001oS-4N; Wed, 24 Mar 2021 15:40:37 +0000 Received: by outflank-mailman (input) for mailman id 101049; Wed, 24 Mar 2021 15:40:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5cZ-0001oN-Hi for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 15:40:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5cY-0003vM-7r; Wed, 24 Mar 2021 15:40:34 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lP5cX-0006wn-Vf; Wed, 24 Mar 2021 15:40:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=mjZUN8RkTSnvwH1Bvlo1YVV/OrF/o2G5mw7vhhDrAHY=; b=g0jiVGn64brKvq6S0axKUR3emX 9D+8ETzeNySJP9tF62BbOiTG8/dzyFzdOLzJluL7bum3+AfinpxJdLWVlLVQeG3zMCbNlPbRekP6v Yns1c0OYsfjnMOqpctQfGtEqvDTiqfW+sBWi9Urxx2czOgI5xT6c7rsnkixeqzm28BCY=; Subject: Re: [PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Andrew Cooper References: <20210324113035.32691-1-jgross@suse.com> <043461f3-9b5e-7d29-bc52-275d663579c9@xen.org> <88a63fe9-e752-285d-3a3f-f00db02df980@suse.com> From: Julien Grall Message-ID: <598182a3-0d62-723f-8582-3b73ec38c7f9@xen.org> Date: Wed, 24 Mar 2021 15:40:32 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <88a63fe9-e752-285d-3a3f-f00db02df980@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 24/03/2021 14:33, Jürgen Groß wrote: > On 24.03.21 15:09, Julien Grall wrote: >> Hi Juergen, >> >> On 24/03/2021 11:30, Juergen Gross wrote: >>> xenstore_lib.h is in need to be tidied up a little bit: >>> >>> - the definition of struct xs_tdb_record_hdr shouldn't be here >>> - some symbols are not namespaced correctly >>> >>> Signed-off-by: Juergen Gross >>> --- >>> V2: minimal variant (Ian Jackson) >>> --- >>>   tools/include/xenstore_lib.h     | 17 ++++------------- >>>   tools/libs/store/libxenstore.map |  6 +++--- >>>   tools/libs/store/xs.c            | 12 ++++++------ >>>   tools/xenstore/utils.h           | 11 +++++++++++ >>>   tools/xenstore/xenstore_client.c | 12 ++++++------ >>>   5 files changed, 30 insertions(+), 28 deletions(-) >>> >>> diff --git a/tools/include/xenstore_lib.h b/tools/include/xenstore_lib.h >>> index 4c9b6d1685..f74ad7024b 100644 >>> --- a/tools/include/xenstore_lib.h >>> +++ b/tools/include/xenstore_lib.h >>> @@ -43,15 +43,6 @@ struct xs_permissions >>>       enum xs_perm_type perms; >>>   }; >>> -/* Header of the node record in tdb. */ >>> -struct xs_tdb_record_hdr { >>> -    uint64_t generation; >>> -    uint32_t num_perms; >>> -    uint32_t datalen; >>> -    uint32_t childlen; >>> -    struct xs_permissions perms[0]; >>> -}; >>> - >>>   /* Each 10 bits takes ~ 3 digits, plus one, plus one for nul >>> terminator. */ >>>   #define MAX_STRLEN(x) ((sizeof(x) * CHAR_BIT + CHAR_BIT-1) / 10 * 3 >>> + 2) >>> @@ -78,18 +69,18 @@ bool xs_perm_to_string(const struct >>> xs_permissions *perm, >>>   unsigned int xs_count_strings(const char *strings, unsigned int len); >>>   /* Sanitising (quoting) possibly-binary strings. */ >>> -struct expanding_buffer { >>> +struct xs_expanding_buffer { >>>       char *buf; >>>       int avail; >>>   }; >>>   /* Ensure that given expanding buffer has at least min_avail >>> characters. */ >>> -char *expanding_buffer_ensure(struct expanding_buffer *, int >>> min_avail); >>> +char *xs_expanding_buffer_ensure(struct xs_expanding_buffer *, int >>> min_avail); >>>   /* sanitise_value() may return NULL if malloc fails. */ >>> -char *sanitise_value(struct expanding_buffer *, const char *val, >>> unsigned len); >>> +char *xs_sanitise_value(struct xs_expanding_buffer *, const char >>> *val, unsigned len); >>>   /* *out_len_r on entry is ignored; out must be at least >>> strlen(in)+1 bytes. */ >>> -void unsanitise_value(char *out, unsigned *out_len_r, const char *in); >>> +void xs_unsanitise_value(char *out, unsigned *out_len_r, const char >>> *in); >>>   #endif /* XENSTORE_LIB_H */ >>> diff --git a/tools/libs/store/libxenstore.map >>> b/tools/libs/store/libxenstore.map >>> index 9854305a2c..fc1c213f13 100644 >>> --- a/tools/libs/store/libxenstore.map >>> +++ b/tools/libs/store/libxenstore.map >>> @@ -42,8 +42,8 @@ VERS_3.0.3 { >>>           xs_strings_to_perms; >>>           xs_perm_to_string; >>>           xs_count_strings; >>> -        expanding_buffer_ensure; >>> -        sanitise_value; >>> -        unsanitise_value; >>> +        xs_expanding_buffer_ensure; >>> +        xs_sanitise_value; >>> +        xs_unsanitise_value; >> >> Isn't libxenstore considered stable? If so, shouldn't we bump the >> version to avoid any breakage for existing app? > > See https://lists.xen.org/archives/html/xen-devel/2021-03/msg01267.html Thanks! Can the content of the discusison be summarized in the commit message? This would avoid other reviewers to wonder why the change is fine. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 24 15:43:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 15:43:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101055.192952 (Exim 4.92) (envelope-from ) id 1lP5fZ-0001xU-QF; Wed, 24 Mar 2021 15:43:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101055.192952; Wed, 24 Mar 2021 15:43:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5fZ-0001xN-Mw; Wed, 24 Mar 2021 15:43:41 +0000 Received: by outflank-mailman (input) for mailman id 101055; Wed, 24 Mar 2021 15:43:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5fY-0001xH-EH for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 15:43:40 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 78e7b1b7-76f2-40fc-a8e4-bf93909a0ac3; Wed, 24 Mar 2021 15:43:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78e7b1b7-76f2-40fc-a8e4-bf93909a0ac3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616600619; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=4t8h/V5VL/2YLVJYxqD1SyLsO/NLKW39GY5oNhNfJew=; b=C1eGdwJE3CgcT8sJSlj+8Ta/m5duUCPCGeezvYrqyXARynxE9EmXqR++ D5gIC3B3FCgCDzdZhuB5cZh3K6ybNwVtJqhQp6Zfzb+Q3sPxqDlsRnoxK sWkGetM/74NRiyDgfJqhu7wPvvKmBY1K83U1hV34Z1IR0x4iqRd6xWJXf o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: jTeEk/lbNR9qEfHw84rDBy5E3ddNzhCj1EvIfD12oB1OwAfQcGHQTqXoihpnNsjmbqyjdwFAqR w6O46a73e1o3HcN3OfDkgFlx+lhpIClKOdtNhTH7I4qN96lLSZxObqMLkgIF2DuUFGrffy/xdQ bDqKK1L/MWnFCNc5OkL9QW13euWjODcBknRONke5575Pe6o1lpn1BX9mi96QBHPYzeriqS+Zzs vqbNw0IqJ5NxOqaSS+hS91S12AoC+qqL9D5zb6udkST3rDssTRFGNWMO7V1mgtjQuOrbbmzb/Q sYI= X-SBRS: 5.2 X-MesageID: 40038641 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:O+q+y6gZKQOfU4iYmmZMhp/t1XBQX31w3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+QsFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmv5 tIW5NVTOf9BV0St63HySGzGdo43Z2j+Kenme/Rwx5WPHlXQotn6Bp0DRveN0VwShVPC5ZRLu vm2uNsoT28dXMLKvmqH3VtZZmPm/TntrLDJSQHCRku9RWUgVqThILSPhCE0n4lIldy6Jg492 ytqW3Ez4Wl98q20xrNk1LUhq4m4efJ7vtmKIiyhtMOKjPq4zzYKLhJf7GZpjg6rKWOxT8R4b 7xiiwtNchy9H/dF1vdyXSC5yDa3Dkj8HPkw1OD6EGTx/DRfi4wCMZKmOtiA3jkwncgp9113e Zq2G+UpvNsfHb9tRn9/NTBWlVWkFO1qxMZ4IwupkFYOLF/VJZh6agkuG9FGpYJGyz3rKo9Fv N1Mc3a7PFKNXuHcnHwpABUsZKRd0V2Oi3DblkJu8ST3TQTtmt+1VEkyMsWmWpF3I4hSqND+/ /PPs1T5fBzZ/5TSZg4KPYKQMOxBGCIawnLKniuLVPuE7xCHH7RtZjt4vEQ6PuxcJIFiLs+8a 6xEG9whCoXQQbDGMeO1JpE/lTmW2OmRwngzclY+tx3obv5SL33MTCSSVwnnse6ys9vQPHzar KWAtZ7EvXjJWzhFcJixAvlQaRfLnEYTYkUt78AKhezi/OODrevmv3Qcf7VKraoOy0jQHnDDn wKWyW2IM1B60usS2LpmRS5YQKoRmXPubZLVITK9ekaz4YAcqdWtBIOtFi/7saXbTtYsqI3e0 N6KKj9kryyoHS3+Wqg1RQrBjNtSmJupJnwWXJDogEHd2nud6wYhtmZcWdOmGecKgRnVMPQGg 5Hr1Fx8aa6RqbgghwKOpaCCCa3nnETrHWFQ9MggaWF/97iYY59JI0hQrZNGQLCEAFVlQ5mpH xYUhINQlbSG1rV+OOYpa1RINuaVtFnxC+3PMZfqBvkxD+hjPBqYkFeYhmDfoq8hx00Sz9dm1 trmpVv/YaoqHKIMmswgOMxLVtWTn+YaYg2QzitbJlIm7ztZQF7RXqLgzvfkB0oZm/27Swp9x DcBDzRdvfRDlVHvHdElq7s7VNvb22YO1l9c3ZgrORGZC/7k2c21e+Afayo1WSNLlME3+EGKT nACAFiaz9G1pSy1BSPniyFGmhjzpIyPvbFBLBmd73IwHuiJMmJkq4BdsUktKpNJZTrsuURV/ iYdBLQJDTkC/kx0wjQv207IkBP2QwZuOKt3Aeg4Hmz3XY5D/aXKFN6R6sDK9XZ62T/Xf6H3J hwkNpdh5r7DkzhLtqdja3HZT9KLR3e5XS7SOwlsphYt6M/vrkbJeisbRLYkHVcmBkuJsb9k0 0TBLlh6LfaI4l1YogcfTla8ldBrqX8EGI79gjtRukwclEmgyWFY5eH47/UpaEuBUPErg3qIl Wb+zBc+fCAXybr789rN4sgZWBNLE4y53Rp8LncK8neCAC2e/pC+1T/M2LVSs4tdIGVXbEL6h B96JWUmuXScSzy0gXZpyF6LaJD6HzPe7LEPCucXepTt8WnMlGNiLaw6MG9jD3rWSK2An5o+7 FtZAgVdIBfkTEsg408zziqRqH2qkwjlUFC4TsPrC+f5qG2pGHBHU9HNgXFgpJZGTlLW0L48v jt4KyG3HH87TBZ1d3JFkhLF+s+b+Qtcg== X-IronPort-AV: E=Sophos;i="5.81,275,1610427600"; d="scan'208";a="40038641" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SnZtZ31uyTy8GgIBhWrpw+0uZhdA18obqrEszjxVp9xMACjwuwu4I0Qq0XiwCnNgi7x41JxF3ScEvCJrjQjkpb8Tmq2NphUaaoy8E6osLM6WiqxFbe79DY3KL4RMUPJVtbf7pF1Vt6UcUh6WG8w+/OL+xs5hQHCboSt5ci52LvdQk8I2uMyK6fW2iEbRdR0jH0es0p0lg/WkpecoPY4jZOnqlR0JSf0s5y2e7J9NFv55+3i1E5caN22bSyqtNlLJYDEmKaKpL4/YKGYI5G5jubDWpA7DRVyjMOVsJjrcWPyKZXq8tgyWkpY9beFf1VFb6+OTglSSKd7U3dBGRla+2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rli26qDOxYcb4kpE5ga12+P45RCsjyWASRzYmRxUWtc=; b=LYWlBPaUBt75BNtkqYaCpviAOCvjE+zNge2Ei6HML0RGjnOxCe78uMeDCxLDSOhV1HAJGFsbBsvz+OL5DCerZIXf4/LrNIBu3B2yscs/N3lb1sxHkLornFsrNj23chSdOkHLvKDJu008JzbWc2WXd4upxWBeC1d79sF1dtdyHTCDnNLivFx0QLt78yU/ddI0r3qqrnOLe2He7lsFY7ss50yM822l2+1copqN7FZkcwulr0bkOg9bgXTlsr4jgCmxni7AX7qXaQbUQQaLTC1t6aPpzMOqI3QdCfkUSRk+ApSDoKVzqdQU3ZKLz+yV2qO7+b88FgVL5t+AhPfnAIk1wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rli26qDOxYcb4kpE5ga12+P45RCsjyWASRzYmRxUWtc=; b=U6Ln8Jl4RB7FCTcYj5OT537APEnBExNj9J5Lzc6ByRgr8JH7bIQqNmbyPM10EKHe0vPYfu5Gvp0rOHqeATdfmBzJguLAjf8zc3HTZokglO2F1Yc4m4Yy0HaYe8WsS+y3yCLEwgyXAp5/OwO4dHHdtL8CM0YDCjnPCocxHoErNKg= From: Roger Pau Monne To: CC: , Roger Pau Monne , Mika Westerberg , Andy Shevchenko , Linus Walleij , Subject: [PATCH v2 0/2] intel/pinctrl: check some registers reads Date: Wed, 24 Mar 2021 16:43:10 +0100 Message-ID: <20210324154312.61878-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0048.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::36) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 75109aae-d4fa-42cc-ca9b-08d8eedb957f X-MS-TrafficTypeDiagnostic: DM6PR03MB4763: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FqjHesKsUuAe5wbEP/a8iH7UTAwoNpecjDpDA8MB1IDwSE1TgFQsv5Y/DIfrYlH1WUipOQ1i2y82ALcqmOEXJ6OggCzSA7EnQOPeME/iabM/PaVVcAFiNjp83QWKNlHgJp6lug4dlRGKP6YTKbZHvtbiTCAV4wGISP4yRr4JRbsyD/JP1JUnTHrSqOTWmOsh3kiWfJ3wF4ZU7FFJSsCE3O3HtfTnBD27IPeo//fZQlSM3csf3NordgewwDJtHHYT+pXaXp9t4wdXWf/wspQqNcpEByZyjjJwFcGppRkzdFxzGx0UE8nYjcgdQE0NKcQSJbWue9G6VX173JERstZ+FFVwjJEEwow4bJBQF+ijb8NcF1soXlNKCEk/pWN3Kh7nlbq0WiGQPZdIKIuJk00Z+1RpI8Ws5OHYEOLb77iB5pb6m8MY2vu/fA8NCH2kDTybj0fTA+jtZGpcGDOp3+bL/TFKIAXef3JmJjvOKciu/xGm8nqA1SGzRchy9/qZpehZrVRMHw4uUyZltx9MZfMTSsIilIWAgOAy0swEX7JaTX4NPf1ILiUX5JbrpdwPxNBjys7M66uhy+tydUiOAC4h/fELbDIEZSu/4CNgE9uR0eWgYm+SYd1gABGUFqbb/Cw53NUMBDjWsVHex3nZXV+rZc3vam5VSjlNzTgoaapDJtI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(39860400002)(136003)(396003)(956004)(478600001)(8676002)(186003)(6666004)(4326008)(86362001)(36756003)(16526019)(54906003)(26005)(4744005)(8936002)(38100700001)(6486002)(316002)(6496006)(2906002)(6916009)(66556008)(66476007)(83380400001)(66946007)(1076003)(2616005)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZFNzNWxGaWRZT2VKMkIvRHZiVU85ay91L000ckZWdS9aTkcvcmVWRUFWQnhr?= =?utf-8?B?RzE0VjZlLzVObG5laDB0eGNaa1ZkTHZaa1d3U2pNaUEvUm5PczRlTUljU1hD?= =?utf-8?B?bmh5NXJYOUxZbmtTeXN0c3Y2VjlWRy9Nd1ZOaWl2c3c1WlQ1VG90VGlCTExI?= =?utf-8?B?Z29BVXZYTC9ha01zK1dGckp5NVdPa1pvWFpyUVgrRUNQcTdNQ0lpOXkvRkVF?= =?utf-8?B?bWY3MXRncVo0dkpIY0VnOFg0TmhyV1NGemJ2VVVWOFFZQ1crWTdPTjFpNGpi?= =?utf-8?B?WmtEb0hneDZXaXYxblNieGxnUGt5V0dMRGVBNWU5dFNQT293U3FtUllYQjh5?= =?utf-8?B?VEhnQ3lDKzhsQVk2Ly9TeUtRNnJLSzZFeENxL3pnajdCNXBNakkveDZ6czBq?= =?utf-8?B?SURuaHBvSmxaQVBPL2pvdmJaajJNUWs4TTFiMXUyRm54aTJoQjJtQ3pldzlH?= =?utf-8?B?RndsazhTempLK0dhTjllRlFJUlRIcW9vM0tRSy9ET1ZnREMvbnZNaXBzWGxV?= =?utf-8?B?RTJabGhSdUdKOE0rY2UzMWdIa0hHUU43OE9hTHYyTzlJUFNCbVMwYk8rR2pJ?= =?utf-8?B?UmpBK1FXSHRnUmQxeStHZHBzRHRXc0pZdFFTeVNSUDhEYjhWWkk1QlpOU0J0?= =?utf-8?B?cnRySVBoLytxY2JCNXREM1hGMGdBYXM2ZkVFSzE0UkMvRUkrc0pkME93dDhk?= =?utf-8?B?WUkzdzYxWUV3aGlwQ1krRm5TRmwrK2x0aG5jZzRxZkZsSVBQdmpIeFhoMzVO?= =?utf-8?B?U3lJNnVHbExlaENvemRFSDJWdDdRVjZJYVE4SjVaM1hqV3hSN2pQYVpKSXRu?= =?utf-8?B?SGJpZmsvUjdaRU43eWdFYnI4eTQxaDIybCtldXJyK3Z2bmZvUVJ2YlZNMFhG?= =?utf-8?B?RERoeWkrTjBxWE4zY3N0VEdwY2p2SEJLNEJrTDYvSmJLWVhRb1JKWVVsRTNL?= =?utf-8?B?c1RpL2xEMFkvTVFZckJlWVE1Q1h4d00zT3ltc1NtTGhaOXlnL3llWVlxZ1VF?= =?utf-8?B?QTY1YUpRSjhGRkswaHF2ZE1qQW9ZdGRoZnBIZERubDBQRTdRc3kwVHNhczYw?= =?utf-8?B?OHRaMis3RjRDOW1VdDRpZGlhRjE2OW5sdTM1emU4YytaZlR4UEJiVVlybHhV?= =?utf-8?B?STFOb1IweFNTYUk3d0JhN1hnbFdLSzVxOXg3alVQeEhNNzY2VXJraUI0M2FT?= =?utf-8?B?dGo4YVFMLzZVSnNaeVU0Vy9GdC9KQlcrZHJ4dGh4VXNJYnFUbE1oT2F2MGRq?= =?utf-8?B?SUxRektSTFNVSHhCd1Z4UHkyRm8wdEU1Z3pYbzVOVGNNb2d0TGVxZEp3R0o5?= =?utf-8?B?VEdpRHRYUFJnSHhFVGdqWVFoR0N2TStFbEJWa01nZ25HOGZ4ZldKcy9ZcjNL?= =?utf-8?B?dEEzSy8xUGNDWFZHZHF6M1l0Ungrc1FlOFIwWXU5Q204YXgwTWhMWndtSFNS?= =?utf-8?B?NzlOWVIzcFEvdCtzMWlUSG4yWGN1eFZBd1p3ZTJIdVJYRGowSDd6THdDcHZX?= =?utf-8?B?SGJra2pwd1Y1eUxFL09wcEkrWXpFWnlzRVVyallmNnJCNzZCMGJBWXBuNjlY?= =?utf-8?B?QUw2MCt6VzJEbllMbGtsMnhxL0VEa1JoZjZIZDNaYU1MK0pSS0xOTDRPVXRY?= =?utf-8?B?N25DQW5hWDJIVktMWjB2dkdycENNTU41YlB3bUw2VzArY2VSdkVIeURDUHJu?= =?utf-8?B?S2JVZTdaRVFXR0p4Qit2YTdnMnIxcE1DdEdnYkRHajQ1T1BtSFdJS3pzZFNJ?= =?utf-8?Q?xWs71vojz9tCfzu4FVErbJuUPKdDQJHw3SwvLuc?= X-MS-Exchange-CrossTenant-Network-Message-Id: 75109aae-d4fa-42cc-ca9b-08d8eedb957f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 15:43:34.7160 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QyRlHSEHw19c3Odstel2gRWs3PBsvC/DiZyOJPcBHvavDQzq0QaxYIknhXk4Iu+UdnNTodjuNRS4tGh4clk0Ug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4763 X-OriginatorOrg: citrix.com Hello, The following series adds some consistency checks to the values returned by some of the MMIO registers of the Intel pinctrl device. That done to avoid a crash when running as a PVH dom0. See patch #1 for more details. Thanks, Roger. Roger Pau Monne (2): intel/pinctrl: check REVID register value for device presence intel/pinctrl: check capability offset is between MMIO region drivers/pinctrl/intel/pinctrl-intel.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 15:43:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 15:43:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101056.192964 (Exim 4.92) (envelope-from ) id 1lP5ff-0001zq-2x; Wed, 24 Mar 2021 15:43:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101056.192964; Wed, 24 Mar 2021 15:43:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5fe-0001zj-VW; Wed, 24 Mar 2021 15:43:46 +0000 Received: by outflank-mailman (input) for mailman id 101056; Wed, 24 Mar 2021 15:43:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5fe-0001zS-0y for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 15:43:46 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ea048142-bf51-44d4-9072-f04d3e3b7faa; Wed, 24 Mar 2021 15:43:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea048142-bf51-44d4-9072-f04d3e3b7faa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616600625; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=MH2vcgX1iP1YoB7u3Yc9kqwdnVDijhCvJ0ADzJxA2dU=; b=NEBLwkj4lLniVa6rWGj3c9Ty4iCSFyKRU3bnpNLIosQswtLWFTQSw2TE 963fPjEqAAlxxAMZDm9Ti2ykhb+DHajgzjoh1vSRguDgGzUNIZXZaBowU W1AiV+usEHVt1jod/VOwjkpFuRsCY1Hb25F/qKaK59vI2iT3FVzxwksOG U=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 5rhY5lB0i9CxlOCBdxMMDh3Z094c3due3mky5Yc7WrWa/NNY9LBlsl7VH+QRdHQgvvfaU1qr76 yJNDxxyNjGRLDlh8ETK9Xy/InOF7mI0GZ+WF6rPabEGsT3//uIk9S19YUh/l40Gs8Q6KcK+CpH 9xK2Ara4SVYKvGxBbk/UTGburYl5uVMmO/jbQEKwe21k/J8NmoUTcP7hsSVAjnWmTs5CAi0b/c BYej6vYJeWlj5QaaoGAPfUBZ2wXXkt9vFA2QBdyRgQ/2EYZwXGCt20+6s1buOSnYTCWFIaJ0dy Wes= X-SBRS: 5.2 X-MesageID: 40018139 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:f2hnHqskKeAC8OSM/cIRMxB57skC8YYji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOj7U5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qz6Y 5JSII7MtH5CDFB4frSyBWkEtom3dmM+L2pg+Cb9Ht2UQR2cchbjztRICzzKDwQeCBtA50lGJ 2Aovddrz27dngNKui9DH8JX+/Mzue7667OSxgAGhIh9U2ynSqlgYSKbySw8zU/d3d0wbkk+X XYiACR3MSemtyy1xO07R6r0714g93ko+EzYfCkqs9QETn0jxbtWYIJYcz5gBkQgMWCrGkni8 PNpRBIBbUB11r0cnuuqRXgnynMuQxek0PK8lOTjXv9rcGRfltTYKAt9OEpEGqt12MasN5xy6 5N1W6C3qAncC/opyjh+8POEyhji0vcmwtTrccok3ddXYECAYUhy7A3wUU9KuZlIAvKrKojEO VoEfjG4udXfV6wfxnizxhS6e3pcXIpEhicRE8e/uSTzjhNhXh8i3AV3coFgx47hd0AYqgBw9 6BHrVjlblIQMNTRaVhBN0ZSc/yLmDWWxrDPE+bPFyPLtBIB1v977rMpJkl7uCjf5IFiLEono 7abV9evWkuP2rzFMynxvRwg1PwaVT4eQ6o5tBV5pB/tLG5bqHsKze/RFcnlNbli+kDA/fcR+ 24NPttcr/eBFqrPbwM8xz1WpFUJ3VbetYSoMwHV1WHpd+OBZbtssDdbfbPNJvgGTspQQrEcz 4+dQm2AP8FwlGgW3f+jhSUcWjqYFbD8ZV5F7Wf3+V78vlICqR89iwuzXip7MCCLjNP9oYsel FlHb/hmqSn4U2//WPC6XRVKgNQZ3wlp4nIYjdvn0snIkn0ebEMt5G0YmZJxkaKIRd5UofwHB NAoU90vYa6NYaZyyxnK9/PCBPas1Ij4FaxC7sMkKyK4snoPrkiCIw9ZaB3HQLXUzpvmQhrr2 9HQBQeRlDWEw7vjanNtu1XOMjvM/1HxCu7K89drnzS8W+Go9s0e3cdVzmyFfKMjR0WXDpSjF 1p+6o5iL6N8Azfb1cXsaAdChlheW6XCLVJAECgaJ9Pkr7mQg12UFyHnCeXkR01Z2rs+XgDn2 CJF1znRdj7Rn5m/lxI2Kfj9115Ml+QeE99cVhWm4xwH2augAc47ca7Io6Il0eBYFoLxe8QdA zfaTwJOwV02pSczxiOgguPEn0g27QjNuHQF64YbrnWw3+hQbf4zJ0uLrtxxtJIJdruuugEXa ajYAeTNir/EP5s9AqPpHopURME4UUMoLfN4lnC42e51nJkXqaXD1RiWr0BI9aTq0LjXO2F1Z 1ljdQz+cu8W1+BHeKu+OXyVXpkLBiWnEudC8cPgrpQtbgptLRyE4LAOAG4n01v7VEbFoPMiE gaQK5H+7jPNY9kQtwKd0tijy4UveXKCHFujxf/DeA/d2w8lnP3P9uG5LzTtLoka3fx0jfYCB 26+y1Z8+ytZVr56ZcqT4YxK39Rck4y9TBL+/6DbZTZDGyRBqx+1Wv/Fn+2a7lGTqeZXZ0Wsx Zh+tmN28uabTDx1gyVnTx1JMt1giqaaPL3JAKHAuhT9dOmfXyKn6ux+ca2yA7NdgHTUTVRua R1MWoKbspCjTE+jIo4lgiKI5aH3H4Noh95+jFollnkx468xnzUdHs2aTHkvg== X-IronPort-AV: E=Sophos;i="5.81,275,1610427600"; d="scan'208";a="40018139" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I9i5+MptozR2K/iNrgQlUaxg/DBa8/q1xPiPc9xKchkfU0HnBE5NjTbafp3MfQqF27W1RZQQlbDoh8wrujc1jJK7785UOped0IP0LHGgv/HEDCVCnJuYWdyRcsHm5U2w2PgfwYD0A59ocvxTVe+69WbLu3ka19YIeIVeymLkeqEA5sScinxxdwL2eMUKg1ottElO9PzQD5Wh57YdTDfuTfWue9L7oqSEmL2oKe2NwHzOFMOU47W51UfBChsdL8uFOLH0ADf6KGHSANoBYgeqlGlv3EJaiEWU68IHz4QkhMCIIApP1m0hmZ1dfXabagYExrG+W9zM70bTr4LY0JuKEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qq4b7bnXXGYqfMK4UXF62lbfQFGPIykj3uOrnpw+JOE=; b=JfJ/uPyyGwDcX/gNbMlQL0UCiW9Ss6ZEQeI8OpIDf2pxhA9sdpBiiRVFENGuZeyj1swPI+uPxv32erZ738vQH/3kABIMZ24r6HAtPePe807xm+8szQk+CpxK2lkmCTIh+OFpOKRG3ZibziRDszt+DTIlHB3ttH8eicT2VNZX/WoJ6ea++mlD0Ku41ZaI3+g0fL8c7ER51cjKjkKuxov/pg10qnC4Rb2CjafgOzAVx97giNt2c27ivhX9VzOi9ble5A0uso6cwWpZ3oEAzsxvTZMdHOcVahfGMxmqPtqEDYtmO/L5P8or8+S7DIDfrzHmOM5rE3V7UYRHpSlWJ6GMWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qq4b7bnXXGYqfMK4UXF62lbfQFGPIykj3uOrnpw+JOE=; b=nGTQXdhNcw2dt1nwIkGJ0AMbSsVii+glgYBZ1FjGoKbaosPUJE6E/zCTwM6+VnUlRC/3lXA7HaPdZNqnxmf9yMh7RBICEy/l0vYuQa0jad/3BsdW2Xq9urLaHaTFOveU1+/UkHT3kurKGPnuEG2Cxf4UrH4+8TWRtDYWIyGSYG0= From: Roger Pau Monne To: CC: , Roger Pau Monne , Andy Shevchenko , Mika Westerberg , Linus Walleij , Subject: [PATCH v2 1/2] intel/pinctrl: check REVID register value for device presence Date: Wed, 24 Mar 2021 16:43:11 +0100 Message-ID: <20210324154312.61878-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210324154312.61878-1-roger.pau@citrix.com> References: <20210324154312.61878-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0113.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::29) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a7215346-c06c-428e-e61a-08d8eedb98f2 X-MS-TrafficTypeDiagnostic: DM6PR03MB4763: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jcuy9OdhwcZdLmVGDwo+XChUNxH5yBEo+r/tJTkh+m6JpYBuAahywapAZOsL2l8pvgTCAJsS611ZYVTPaNKZjrem6e8AazHBOYtd/+wcTpFvQIQJTnU1Vj9qBmOWDadYWkINKmUbhL/4SxUOFMKsAC4KsH2eiCPQwF8Dq7o5ENgOAT1ms9pQm2PeR+ISht7j7UO+KMAiMv2a28CgR9UN+txUA9XxHakNJb39/sWqMyWy9avts6fcQ+zax4eqJzLpUWpdYeQMRrqVLTxwPVirzQG8SIzULH7/kfFPZEXcRMZ8DJtCfc5lDizOAKPTI/1Iagr+mZkLM/8f8vX4m/aSZiWkYxNzxsJUUIdutBjI4iupKw1lq7c83mfGLUEikTIgrSxEtRJUxcx8DO44kXsD695akoPz0n5qUhk03et/Q81ev/Lyq/yMXxOtvH5DvQmuxinp5lBId7r3OaxjlwCJL9rpJsmp0Og8ZiwrETdRpjqi0qvDnZp0qO0JfuiqPHP46lN2QIlWBM15muNkhAhHt7I6cQAPpjcE77ef2OoraXcHfBklMUVjijkyhxFMGyhg0bezITb3oHlv6BUt11fR36caeYsqvBYItRhPXjMXNO9kQyGDv/5ay81qiRSs05mis8TFlAuXgKZlvZNpgZlQlS4rCLva8Yt4oQHg+7sIyv4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(39860400002)(136003)(396003)(956004)(478600001)(8676002)(186003)(6666004)(4326008)(86362001)(36756003)(16526019)(54906003)(26005)(8936002)(38100700001)(6486002)(316002)(6496006)(2906002)(6916009)(66556008)(66476007)(83380400001)(66946007)(1076003)(2616005)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VXE0VnBHSjVtalBObUsyMlc4TXY2VkFWTW5QRXJDSytkd09aallRbGFzSFZI?= =?utf-8?B?dUFUODZ0Q0Q5QUZMOWZRK3ZPeHdMUHNUZmxiczZwY2ZCQ3lyOGd5bS9kTVZ0?= =?utf-8?B?b0I2K2FmeS9OaElRUVBLMzF4Zks4ajRwTFlzNWF3VXFMOU9NN0doWDg1TnZp?= =?utf-8?B?dW51cTZ0dGFmNnZ6Q201dDVibHdNUG9zOFUxQUlUazZGL3MwQ051cDBEaFc0?= =?utf-8?B?aVR1bmZwWEpKckx3NkszcENIQm8xY0JOV2J5d2RkUUhBS09JL2c1RzBFMUR0?= =?utf-8?B?UDcxd1hFZXI3VXNVZUFweU56ejZvdTEyVndTNjA0QjZ0OTkyazVtb2UwbFlR?= =?utf-8?B?b0hvSEtzelhvd1FyY0RPWU9yRXNUb3JranlsWjBrOG40Vm5zRW9rQ2l5N2R4?= =?utf-8?B?MXhNY2pzVHE2ZEJBakNHQzZQWWwza1RGTXk3R1orOHBqK1A3WG9vZGJHdW5M?= =?utf-8?B?anN6a0NRbGtHQm0zV2pLbXRkK1hWMi9Rcmxhb1JSUHZYWXgvc2NXeHgrV2lK?= =?utf-8?B?NVBva2M2VklwTU1Mb3lORzM2MVFvdTRkd2xuRytjdHd2aWdQTnFnNjR4NDkw?= =?utf-8?B?aGx2QzR6aVlJcEpWdHZWTFpjOTMvU1l4anBJWmZYYTU0TmJXcmh2N1JNTGYy?= =?utf-8?B?Ti8rT0ZuYVlJMHZMWTR5RUd4elIyNUQ3QUdqeGdOVzBzNVJONUxxZTB6ODl4?= =?utf-8?B?NXVNd0JNZjl5L2VlK2pzUkhHSXc0VkFEb1JuTCtCRXlTM0NRMHBDOVdRYzRE?= =?utf-8?B?Zng0QmFjdDlwdmZ1TEdEZWpxMVdqSTVLcDJoNFRvRzlIYkQ5SldKZktHKzcz?= =?utf-8?B?MUlVRldWQTFjK24zVE5DNUV6bFh4MU0yV1EvcUlkQjNFWHRpdVQrUGJPUFNl?= =?utf-8?B?UmVITmdTYmY4Tks5WW05My9LMVpDWktoVURlV0hIS0doWVJiQVNUeGtUSmtJ?= =?utf-8?B?RmhtMC9UK1NUSkM2cHdrZm5saldwUHhMMkM5UVE3QXVYVVdpMHBicjE3R08z?= =?utf-8?B?MEt4cXJCbW5oK2tnR1JDbjAyT0p1WjJoRWtBL0c3TEZZcXlZdi9sK1ovYXhS?= =?utf-8?B?R014bXBjSUk0OTg0TGVaWENNTUNmMitpNHdaK2duN2Nid1IvdlptWC9UdW9L?= =?utf-8?B?eVE0ZG5xSDdRZEtsTWRvNVdxWWgxL0V4SjVaMFRHbWhyci9tU0daamQ1TXJw?= =?utf-8?B?UzlDZjBtQkFEa2RrSGNxTjNEL3VPN3RNWmJ4MUtIZVA0MXlxZ0FnendsbFBp?= =?utf-8?B?cmYwQWJ4M1BiSlNZZlM2eEJjcnI1YyszZTNaYXd1MUpLT0NhbFdGMSsxTkhX?= =?utf-8?B?Zmx1bHVNVTlzci9WL3NseWxOb2k0WFNpVU5Eb2NmM2llZnFPV2JPVmZyRW1F?= =?utf-8?B?cjdRZWlCNTc1T3lIM2tIL2hTcWwveThwdlo0RTdjYmIyOVdRWVhKV09SZlJQ?= =?utf-8?B?WUZBSmdtWjlqdXRVZmNHOWdMaWhYQTd4TkhEN3QwbnBNV3NTdGdXQlRFRDVN?= =?utf-8?B?NUx2ZEhmd1pYd29oaENXOEliZmVaSVVvRE9SNGNUeUdNcGhXK2oxN2tOVEly?= =?utf-8?B?MXVwenorWTNoaHJiYTkyWGVMVmFZckxMa09PTHZYTDZvZ2lVNzBnWE9jdHY4?= =?utf-8?B?TkJ3WEJaMGxFLzlEMHM5VkcvVW0zeFhnTnF5azdGOG9jZzNnaTB2bkJTMUZO?= =?utf-8?B?V0FKRDl2RVdNYXlVbElGanIvcURGZHByM3hrcXpCQ2pCYWxEOTNkaXc1Q3BG?= =?utf-8?Q?6EedMSy/aWDFAPWhWMKHf4u71x6m2xFGXTfQnaj?= X-MS-Exchange-CrossTenant-Network-Message-Id: a7215346-c06c-428e-e61a-08d8eedb98f2 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 15:43:40.4946 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pVQw++uW6v06IKC/sH1qabWoQxoIlJO2l5zUWRrZBHZy6eqiK+e0qgxoiYm7rV7cxdxJHhr8vEBvedz8QdZAoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4763 X-OriginatorOrg: citrix.com Use the value read from the REVID register in order to check for the presence of the device. A read of all ones is treated as if the device is not present, and hence probing is ended. This fixes an issue when running as a Xen PVH dom0, where the ACPI DSDT table is provided unmodified to dom0 and hence contains the pinctrl devices, but the MMIO region(s) containing the device registers might not be mapped in the guest physical memory map if such region(s) are not exposed on a PCI device BAR or marked as reserved in the host memory map. Suggested-by: Andy Shevchenko Signed-off-by: Roger Pau Monné --- Changes since v1: - New in this version. --- Cc: Mika Westerberg Cc: Andy Shevchenko Cc: Linus Walleij Cc: linux-gpio@vger.kernel.org --- drivers/pinctrl/intel/pinctrl-intel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index 8085782cd8f9..59d13342caf6 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1493,6 +1493,8 @@ static int intel_pinctrl_probe(struct platform_device *pdev, /* Determine community features based on the revision */ value = readl(regs + REVID); + if (value == ~0u) + return -ENODATA; if (((value & REVID_MASK) >> REVID_SHIFT) >= 0x94) { community->features |= PINCTRL_FEATURE_DEBOUNCE; community->features |= PINCTRL_FEATURE_1K_PD; -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 15:43:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 15:43:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101057.192975 (Exim 4.92) (envelope-from ) id 1lP5fm-00024U-BS; Wed, 24 Mar 2021 15:43:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101057.192975; Wed, 24 Mar 2021 15:43:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5fm-00024M-8M; Wed, 24 Mar 2021 15:43:54 +0000 Received: by outflank-mailman (input) for mailman id 101057; Wed, 24 Mar 2021 15:43:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5fk-00023b-Mr for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 15:43:52 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 501eaa9a-5033-41ec-8788-e2d5a48f3217; Wed, 24 Mar 2021 15:43:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 501eaa9a-5033-41ec-8788-e2d5a48f3217 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616600631; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=3SSMjXLR2Pw8e0lwOcBT/8UcWH1S4+UdZqxdNTeo0c4=; b=NH6R8iEOmWeruMVSATL8byarCe7Aaup3RXSuhmTKxD2l6EcPznqHHXXU wzvaiv2KedXxt3fgeJ3mofKW3juDiNjTo90Pj3oqLuPuCrRNhHKq6r4Qi x+m9dFcuMAQRmeu9YYWMGtnM51pY56cjwV76YUyuHepnan9Ssj7A3j1Bc 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: T2L+nUH0GVj4TT8m8wtOGnV8vZLqkRcN/TSm4y4PfQ4ZjqVvdavR16HW6mBzsmafsLUnyiA+ow 64bEwZ1Rl+2jnhaJiCY7djrDk8ysavXvq95v5CsLZi4LHZ/S6HUST+l7mjZY5pnzfLML2P982j hmNerLpJNyl8SCOyjVTmP2au3eYza3fBfdmGcMMAdZwaCL4jLpWCKDGcBBhxqywG64hnHpVI2R NWx3mEN4m26GvGWUNAoArM04uBGVeDlw/9QAesvImrfAbXyBsiIQr+pSn9mzhjVaMMxVcZ4m02 we8= X-SBRS: 5.2 X-MesageID: 40188095 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:XDgRN6zPgOrBtE6uKU/KKrPx/uskLtp033Aq2lEZdDV8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPsfVr3//dOgbU5F7GkQQXgpS+UPJhvhLGSpwHINg/f0qpm1a lme7VjE9GYNzJHpOvz/QXQKbkd6fad9qTAv4nj5lNMaS0vVK169Qd+DW+gYyhLbS1LH4AwGp bZxucvnUvCRV0tYs62BmYIUoH4zrWmqLvcbQMbHBli0QGSjFqTg4LSKQSS3RsVTlp0sNUf2F XC+jaZ2oyT98uV5zWZ/G/V4pRQlrLau6Z+Lf3JsOc5AHHBjg6pYa5oRrGNuiskydvflGoCoZ 33jDoLe+h19nPNbkG5yCGdpDXI4XIVxFLJjX+enHf5rsTySFsBerR8rLMcSDT1wQ4EnrhHoc V29lPcjbV7J1f8uR64wN7yWxRjhiOP0AEfuN9WtVNze88jcrNLxLZvmn99IdM7Mw/RzpsoK+ VqBNG03octTXqqK0rUuWRi27WXLw0ONybDRkADv/qc2CRNkEZ4yFMFxNcekm1ozuNEd6V5 X-IronPort-AV: E=Sophos;i="5.81,275,1610427600"; d="scan'208";a="40188095" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JvftgZFiTf8F2z9JvoYNbVzO8LCL3AFYEok7Yb23FH8KbpczKO76MYtBVQFpVlJSOkYC5Q/Z2ofeCYVj27QW53CrfmD7vz/QzB5IawQxyKA9RiY089Iz1eOsjougRKbnOQssRRmYqheOT4olJyobIUxpa8FiV+0vqLp48QK2LrNxbrAoE7TTDAVo26WKRcloogBoqwnalGH8lh+jvqtq4CaKAEMIlU939bXVbhVKoERPL3I1oO42VXlxdIt0lePiILI5/9xRfaZWiC6a7AeCmZwk924gbx5kxThRNlJt0K3fMtU9SJ42LyZ/e87nMNyUK7OZxO33dYggOnYgQ/XKSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ub0sbUt19Z455MEMout2SS1YkpeYLQCcmLvqKsToEuA=; b=MyDkuMZLSkGhDK06hHHTWn5cz3gGZ4b95y5N6B2Cwn1Cml1KmIfp5pe5oavF+gJ+J+j1QKE3ovtWnzugAHJPaGFajM5ljibwZ0Bu2KZDtoLRFuhvmE8yxnRKcv4fGetehFNe3Lbi33HpdRRHTp+y8gncVcQcfK39oo/56sMRBgQwhUUCJUWq+jGad180dgOcmy22qlfXk8mhmbkZXtNAZo6M8O1DmMBWa0HwM56RkVQgryynbknmZ/AAXVzPjD6QRhBojgvxLxGw/FQQx+9gMwssMLZ6TAFPOUsVMYeuJVkk7sfmOi/6x13z4kbAQTV217puHNGiPGIyyDfNB6KmLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ub0sbUt19Z455MEMout2SS1YkpeYLQCcmLvqKsToEuA=; b=XpNVOtT44B455bjm1RoXko+cMLriNYY2UYyTc2L8fAmNH7IGhou7hBEOqor8U+xtE3wYjH5He5DvswcBt6DQOJrpu9Qo9UM9PW8uxYfDeMuR3xbEY9H4/Mak0CHmuB2JoPHBQQg1gT/o2YvXIUwrItYC8Z1XUHJgLuqZxwnIAdA= From: Roger Pau Monne To: CC: , Roger Pau Monne , Mika Westerberg , Andy Shevchenko , Linus Walleij , Subject: [PATCH v2 2/2] intel/pinctrl: check capability offset is between MMIO region Date: Wed, 24 Mar 2021 16:43:12 +0100 Message-ID: <20210324154312.61878-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210324154312.61878-1-roger.pau@citrix.com> References: <20210324154312.61878-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR1P264CA0030.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2f::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2a898119-3a44-4b47-231b-08d8eedb9bca X-MS-TrafficTypeDiagnostic: DM4PR03MB6062: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:240; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iUSZn4Z/mitWANUDBIi1vmCnml/K7B9YOrGUHjxHbd6+EhtYZH4qAS2lKP1aHQpgNdjySrCCjexep0+3uISBq0M6YJUQ5mjM5H/e4L4DJvXxQLLotrNNNL5/rWcEqZZuNf0vBrrJ9KbWI1AqHx7EFgQVOmxI1yy9MPg0KTd4HIGdrnHH5CUfPjCMR5jTERUTqUu8D5O41E3TFpekY4bL/F3S8xwls6EyGaCwb/EIpdus/vX/2IDHfYc/LOqypLbY/vQVXNYzwHS1DOI4gnyCIqiWzIT2c0z8ctUftt1Q/hoDOSU5uJcPRsbdsHcTRNmxjt2rQZyLYMIW1dsMxjor5IdhEHQypRdS4R1Z0+01o8LXTebWDlB+78alkI2FIJXSpNhmz0mmCbGC1+bcAdMcYJKKe8V8tkjMHyYLiZp8gRIb5XgC6APu1nRWov6PWPxcvWg0SSZyf1o7xBT8pg/HBVQBeMGcgiFBXoLUohRVyeXcVybF9FJl4eyF29vPb/UkDdlOIAng3kpZQ4+TQzkbYGqZu70D5aArPOVpr9DqiVmTkfWCIiOnM5O55fLGJwSryiy4QaRJgRhynT/S+U29tA//ktGDal/9Fkxs427AjULUU6ejlFf9UmDkxfifLcZjnO7PRBiP9cjyLYka90PgeDcixXBuvvDREbOk3AqZAV4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(39860400002)(136003)(346002)(376002)(54906003)(6916009)(478600001)(956004)(16526019)(186003)(26005)(83380400001)(86362001)(2616005)(1076003)(4326008)(38100700001)(2906002)(36756003)(316002)(5660300002)(8936002)(66556008)(8676002)(66476007)(6496006)(6666004)(66946007)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZEN2SDNwR29EV0ZaVXFTZFptMVRTRnBrYWd1a0U1d3ZDV0xJaGw3MklEL0Jn?= =?utf-8?B?L1F1Y0lVa1BRQW8wK3VxUzVHRkFwNDBjSmg0NFpTd1ZocndNVHJZSC8xQjh1?= =?utf-8?B?WTQ1cDU1SU80SUVTdlVVOVBNNGtDYWdlRTUrU1M2UEVFZUpSVW5BMC95RE5Q?= =?utf-8?B?QVhxejVjQXJYNk16V0lqZ2VtSzJIRk9RclVrajZVenY1ejMxVmNLd1VnWDVS?= =?utf-8?B?TGYrdzFvNTZTbFl4Z0QxcXdQYjdwanBRQi9ZQzJyc0loY2loZ3paQXlmaTZB?= =?utf-8?B?azVFd2dzaURVdTNENmI2b1Z0V1J0ZG4xa0JieXd1SzdpamxRL3doUDFFN21W?= =?utf-8?B?ZE5sUmpiZlVIQkI2TUFQQjJ3U2JmMmhGdktmTDlTRktoZnZJLzJiZjgxYnJS?= =?utf-8?B?d2VheXdjYTV5eG5SdzZUbDFjSlRPYk45RjB1cWltemJxYWpqUHNLTTRXTWQ4?= =?utf-8?B?bjNBYnh1cmtNdHlLWldwSWJBU0N1ME41cnBHcVZpY0o1U1ArVnJMK3FNR3Q1?= =?utf-8?B?VUl1b1dkUXFTSWp0SStKM3ZmR0NDRnVKbzRycE4wQVFzbUw3QWFhVTNKeDNp?= =?utf-8?B?MjFmS21KaWhjSWRhN09pejl4V0RvbkhpUTRQVzIwRURwT25uWE11OTZZYk5M?= =?utf-8?B?MnFRenlWMVhhdlhHTkZKbXo2Y0ttU3VnclZEU2syN3duTDQvNjF2YWZ6cVpv?= =?utf-8?B?Z2YzM2xFQ0R1NjNSZU55eFhOY2t3aW5BRngxNjBtdGRsSUR0UlVuQlJKKytq?= =?utf-8?B?VEhNYllPTGs2RHA5a2pCYUlpVWF1OHRkVERRMndzeW9hUjhQM0J1ZDBEU1Jy?= =?utf-8?B?OXdKVkRVbWxoZTlQRzM5Y3JaUG9UQmU3M0l3YTI2a20reGExNGxNM0Ivem5G?= =?utf-8?B?K1pwZjlSaFlNM2M5N2x1d2NrNHM2dHcxbGJqUjVFOC91cmJKV2N1RUluK0Qx?= =?utf-8?B?OVJMUWpSanpLaStWVVhzVzA1MlY1NURJOHpoZnlhaHRtbWgrVzh3S1RpU1Q0?= =?utf-8?B?TDRaUVlyT0xtampLUVJkZzFxdnNkQm1DMC9NUCtkajZnNklrSEQ2WkN1UERU?= =?utf-8?B?Z2JMck55eVN0dEhHbFZxQVlPUFpwWkdTTTNVbktEOWRWWGM1akNGc3RiTm9w?= =?utf-8?B?cUFXcmxCMnlHYWYrN2NWL004QTM1cHZiUHdhQmJKZlVCTGUwVkhZa0hPT051?= =?utf-8?B?MWd3NkFoMnQ2ajRCaFJ4dXlBZGFQMHdESEdWa2FrNUcrTDRidTdTZURPSVBK?= =?utf-8?B?OFZrUXFDOVpYOFhhMERKOVRxdWJqNHU5MHowS2tFK0dVcXZpWThDeGxQTDkv?= =?utf-8?B?YVdtMjh5NzRMdXR1UWpYbTN3YmhhL1czb2VOdU1QbkdJQ0wzSW1ES0QrWXZ1?= =?utf-8?B?MndyMDFNbWRDcXYrZk1Tak82YkhBMjNFUHU4WU1lUXRWaDhHOGlFSHRoeFpC?= =?utf-8?B?ZHN5WTR3dkpPbVZPQXR0aVh2T0hPLzhrZDE2UzBjMU94QzZuVWhkY083amlD?= =?utf-8?B?UlpJNnlkYWx6dlY1RGRWZE9UekVXWlcveGtMYVNDY2FjU0prWFpEVjh6V1o5?= =?utf-8?B?UUdFSGVMWEQrcHhCWkpjZGc2OXZ6eGcyYXlVWXRpKzd6U0ZIRVFMZGNOTVhG?= =?utf-8?B?eWJiZmMzTFRwSENRc1I4aEZHV0haNThxVzVKL3ZHdDdlT1dITUYwUmdYUXNj?= =?utf-8?B?dTcrWFlzNGc0bTNRdTV5c3g3dUV3R2VJbEJRcFViZE96bm9YTWZYQ1RSR1Az?= =?utf-8?Q?Rw9X3YAKXcFsKf25ax3E0z2qTdUm4jjFIEUvnYo?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2a898119-3a44-4b47-231b-08d8eedb9bca X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 15:43:45.3771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wZG1u4rKV0LIawGl3is2QIotERP5/BRvYVqhwhxiS1snYI20Y6IfoSAmgvN9cb6zhruhzZZzSz/xonNArgbHKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6062 X-OriginatorOrg: citrix.com When parsing the capability list make sure the offset is between the MMIO region mapped in 'regs', or else the kernel hits a page fault. Adding the check is harmless, and prevents buggy or broken systems from crashing the kernel if the capability linked list is somehow broken. Fixes: 91d898e51e60 ('pinctrl: intel: Convert capability list to features') Signed-off-by: Roger Pau Monné --- Changes since v1: - Adjust commit message. --- Cc: Mika Westerberg Cc: Andy Shevchenko Cc: Linus Walleij Cc: linux-gpio@vger.kernel.org --- drivers/pinctrl/intel/pinctrl-intel.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index 59d13342caf6..d45a6994b2a3 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1481,16 +1481,22 @@ static int intel_pinctrl_probe(struct platform_device *pdev, for (i = 0; i < pctrl->ncommunities; i++) { struct intel_community *community = &pctrl->communities[i]; + struct resource *res; void __iomem *regs; + size_t size; u32 offset; u32 value; *community = pctrl->soc->communities[i]; - regs = devm_platform_ioremap_resource(pdev, community->barno); + regs = devm_platform_get_and_ioremap_resource(pdev, + community->barno, + &res); if (IS_ERR(regs)) return PTR_ERR(regs); + size = res->end - res->start; + /* Determine community features based on the revision */ value = readl(regs + REVID); if (value == ~0u) @@ -1521,6 +1527,12 @@ static int intel_pinctrl_probe(struct platform_device *pdev, break; } offset = (value & CAPLIST_NEXT_MASK) >> CAPLIST_NEXT_SHIFT; + if (offset >= size) { + dev_err(&pdev->dev, + "wrong capability offset: %#x\n", + offset); + return -ENOENT; + } } while (offset); dev_dbg(&pdev->dev, "Community%d features: %#08x\n", i, community->features); -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 15:59:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 15:59:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101067.192988 (Exim 4.92) (envelope-from ) id 1lP5uz-0003U8-Rp; Wed, 24 Mar 2021 15:59:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101067.192988; Wed, 24 Mar 2021 15:59:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5uz-0003U1-Og; Wed, 24 Mar 2021 15:59:37 +0000 Received: by outflank-mailman (input) for mailman id 101067; Wed, 24 Mar 2021 15:59:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5uz-0003Tt-DE; Wed, 24 Mar 2021 15:59:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5uz-0004Gt-0l; Wed, 24 Mar 2021 15:59:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5uy-0006HM-PU; Wed, 24 Mar 2021 15:59:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lP5uy-0002Re-P0; Wed, 24 Mar 2021 15:59:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=78WK+Lck8wSh8292djwo9oA7E9meFF8K+a0J1VYPk6c=; b=N93t5V8w7qSOeSkHizRGWI7XC6 qRN6b/r4Xv7PcBqFuOdnmDrD8XsK9ek214ei2lkupK+EW5U0qRT5vW9AdM17+Qy+A6l2tMiw6iGhs eNXd1lHmLr4FR/s7dKGmDApcdXX/Oj+w8rn8kyTMRzrCO1zZQFvYOaOq05HukONWxDe0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160379: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=96e99e49483de4fb293ce26691cbce19110fb3a9 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 24 Mar 2021 15:59:36 +0000 flight 160379 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160379/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 96e99e49483de4fb293ce26691cbce19110fb3a9 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 257 days Failing since 151818 2020-07-11 04:18:52 Z 256 days 249 attempts Testing same since 160379 2021-03-24 04:18:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 48818 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 24 16:29:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 16:29:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101072.193003 (Exim 4.92) (envelope-from ) id 1lP6N9-0006yU-Ui; Wed, 24 Mar 2021 16:28:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101072.193003; Wed, 24 Mar 2021 16:28:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6N9-0006yN-RW; Wed, 24 Mar 2021 16:28:43 +0000 Received: by outflank-mailman (input) for mailman id 101072; Wed, 24 Mar 2021 16:28:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6N7-0006yE-Te for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:28:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6N7-0005Gr-RP for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:28:41 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lP6N7-0001lv-QZ for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:28:41 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1lP6N6-0005Ub-4r; Wed, 24 Mar 2021 16:28:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=g2CGi3AJQnTLTaMdIFMGJ/off184UKmv2NDKJ5aFPew=; b=hFZmW8xlGsTbysewovdNoqZJQb sh8JnF3ZfMjHORVT23H16UPodto83JWBxKCTlMa3Yw0DyTVZA4mrARSpjtvgtVrZFDG0+YXYGS8ya MkIqfa93bO++zk1edJBqRW7CvwYWZFzT95jMXPYag328/p0woK2oROS/ZAccv2qqrJFw=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: iwj@xenproject.org Subject: [PATCH 2/2] Branching: Rerun autoconf to put version right Date: Wed, 24 Mar 2021 16:28:31 +0000 Message-Id: <20210324162831.7587-2-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210324162831.7587-1-iwj@xenproject.org> References: <20210324162831.7587-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Ian Jackson --- configure | 18 +++++++++--------- docs/configure | 18 +++++++++--------- stubdom/configure | 18 +++++++++--------- tools/configure | 18 +++++++++--------- 4 files changed, 36 insertions(+), 36 deletions(-) diff --git a/configure b/configure index a2789ae480..62f6c2d47a 100755 --- a/configure +++ b/configure @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for Xen Hypervisor 4.15. +# Generated by GNU Autoconf 2.69 for Xen Hypervisor 4.16. # # Report bugs to . # @@ -579,8 +579,8 @@ MAKEFLAGS= # Identity of this package. PACKAGE_NAME='Xen Hypervisor' PACKAGE_TARNAME='xen' -PACKAGE_VERSION='4.15' -PACKAGE_STRING='Xen Hypervisor 4.15' +PACKAGE_VERSION='4.16' +PACKAGE_STRING='Xen Hypervisor 4.16' PACKAGE_BUGREPORT='xen-devel@lists.xen.org' PACKAGE_URL='https://www.xen.org/' @@ -1236,7 +1236,7 @@ if test "$ac_init_help" = "long"; then # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures Xen Hypervisor 4.15 to adapt to many kinds of systems. +\`configure' configures Xen Hypervisor 4.16 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1302,7 +1302,7 @@ fi if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of Xen Hypervisor 4.15:";; + short | recursive ) echo "Configuration of Xen Hypervisor 4.16:";; esac cat <<\_ACEOF @@ -1403,7 +1403,7 @@ fi test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -Xen Hypervisor configure 4.15 +Xen Hypervisor configure 4.16 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -1420,7 +1420,7 @@ cat >config.log <<_ACEOF This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by Xen Hypervisor $as_me 4.15, which was +It was created by Xen Hypervisor $as_me 4.16, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -2868,7 +2868,7 @@ cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1 # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by Xen Hypervisor $as_me 4.15, which was +This file was extended by Xen Hypervisor $as_me 4.16, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -2922,7 +2922,7 @@ _ACEOF cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -Xen Hypervisor config.status 4.15 +Xen Hypervisor config.status 4.16 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff --git a/docs/configure b/docs/configure index e9c040cb84..569bd4c2ff 100755 --- a/docs/configure +++ b/docs/configure @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for Xen Hypervisor Documentation 4.15. +# Generated by GNU Autoconf 2.69 for Xen Hypervisor Documentation 4.16. # # Report bugs to . # @@ -579,8 +579,8 @@ MAKEFLAGS= # Identity of this package. PACKAGE_NAME='Xen Hypervisor Documentation' PACKAGE_TARNAME='xen' -PACKAGE_VERSION='4.15' -PACKAGE_STRING='Xen Hypervisor Documentation 4.15' +PACKAGE_VERSION='4.16' +PACKAGE_STRING='Xen Hypervisor Documentation 4.16' PACKAGE_BUGREPORT='xen-devel@lists.xen.org' PACKAGE_URL='https://www.xen.org/' @@ -1224,7 +1224,7 @@ if test "$ac_init_help" = "long"; then # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures Xen Hypervisor Documentation 4.15 to adapt to many kinds of systems. +\`configure' configures Xen Hypervisor Documentation 4.16 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1286,7 +1286,7 @@ fi if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of Xen Hypervisor Documentation 4.15:";; + short | recursive ) echo "Configuration of Xen Hypervisor Documentation 4.16:";; esac cat <<\_ACEOF @@ -1387,7 +1387,7 @@ fi test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -Xen Hypervisor Documentation configure 4.15 +Xen Hypervisor Documentation configure 4.16 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -1404,7 +1404,7 @@ cat >config.log <<_ACEOF This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by Xen Hypervisor Documentation $as_me 4.15, which was +It was created by Xen Hypervisor Documentation $as_me 4.16, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -2821,7 +2821,7 @@ cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1 # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by Xen Hypervisor Documentation $as_me 4.15, which was +This file was extended by Xen Hypervisor Documentation $as_me 4.16, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -2875,7 +2875,7 @@ _ACEOF cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -Xen Hypervisor Documentation config.status 4.15 +Xen Hypervisor Documentation config.status 4.16 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff --git a/stubdom/configure b/stubdom/configure index 6068f58d12..aa48df986d 100755 --- a/stubdom/configure +++ b/stubdom/configure @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for Xen Hypervisor Stub Domains 4.15. +# Generated by GNU Autoconf 2.69 for Xen Hypervisor Stub Domains 4.16. # # Report bugs to . # @@ -579,8 +579,8 @@ MAKEFLAGS= # Identity of this package. PACKAGE_NAME='Xen Hypervisor Stub Domains' PACKAGE_TARNAME='xen' -PACKAGE_VERSION='4.15' -PACKAGE_STRING='Xen Hypervisor Stub Domains 4.15' +PACKAGE_VERSION='4.16' +PACKAGE_STRING='Xen Hypervisor Stub Domains 4.16' PACKAGE_BUGREPORT='xen-devel@lists.xen.org' PACKAGE_URL='https://www.xen.org/' @@ -1265,7 +1265,7 @@ if test "$ac_init_help" = "long"; then # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures Xen Hypervisor Stub Domains 4.15 to adapt to many kinds of systems. +\`configure' configures Xen Hypervisor Stub Domains 4.16 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1331,7 +1331,7 @@ fi if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of Xen Hypervisor Stub Domains 4.15:";; + short | recursive ) echo "Configuration of Xen Hypervisor Stub Domains 4.16:";; esac cat <<\_ACEOF @@ -1444,7 +1444,7 @@ fi test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -Xen Hypervisor Stub Domains configure 4.15 +Xen Hypervisor Stub Domains configure 4.16 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -1499,7 +1499,7 @@ cat >config.log <<_ACEOF This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by Xen Hypervisor Stub Domains $as_me 4.15, which was +It was created by Xen Hypervisor Stub Domains $as_me 4.16, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -4295,7 +4295,7 @@ cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1 # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by Xen Hypervisor Stub Domains $as_me 4.15, which was +This file was extended by Xen Hypervisor Stub Domains $as_me 4.16, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -4349,7 +4349,7 @@ _ACEOF cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -Xen Hypervisor Stub Domains config.status 4.15 +Xen Hypervisor Stub Domains config.status 4.16 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff --git a/tools/configure b/tools/configure index bb5acf9d43..99d08a4d81 100755 --- a/tools/configure +++ b/tools/configure @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for Xen Hypervisor Tools 4.15. +# Generated by GNU Autoconf 2.69 for Xen Hypervisor Tools 4.16. # # Report bugs to . # @@ -580,8 +580,8 @@ MAKEFLAGS= # Identity of this package. PACKAGE_NAME='Xen Hypervisor Tools' PACKAGE_TARNAME='xen' -PACKAGE_VERSION='4.15' -PACKAGE_STRING='Xen Hypervisor Tools 4.15' +PACKAGE_VERSION='4.16' +PACKAGE_STRING='Xen Hypervisor Tools 4.16' PACKAGE_BUGREPORT='xen-devel@lists.xen.org' PACKAGE_URL='https://www.xen.org/' @@ -1417,7 +1417,7 @@ if test "$ac_init_help" = "long"; then # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures Xen Hypervisor Tools 4.15 to adapt to many kinds of systems. +\`configure' configures Xen Hypervisor Tools 4.16 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1483,7 +1483,7 @@ fi if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of Xen Hypervisor Tools 4.15:";; + short | recursive ) echo "Configuration of Xen Hypervisor Tools 4.16:";; esac cat <<\_ACEOF @@ -1693,7 +1693,7 @@ fi test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -Xen Hypervisor Tools configure 4.15 +Xen Hypervisor Tools configure 4.16 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -2108,7 +2108,7 @@ cat >config.log <<_ACEOF This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by Xen Hypervisor Tools $as_me 4.15, which was +It was created by Xen Hypervisor Tools $as_me 4.16, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -10752,7 +10752,7 @@ cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1 # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by Xen Hypervisor Tools $as_me 4.15, which was +This file was extended by Xen Hypervisor Tools $as_me 4.16, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -10815,7 +10815,7 @@ _ACEOF cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -Xen Hypervisor Tools config.status 4.15 +Xen Hypervisor Tools config.status 4.16 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 16:29:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 16:29:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101073.193009 (Exim 4.92) (envelope-from ) id 1lP6NA-0006yv-8r; Wed, 24 Mar 2021 16:28:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101073.193009; Wed, 24 Mar 2021 16:28:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6NA-0006yh-3i; Wed, 24 Mar 2021 16:28:44 +0000 Received: by outflank-mailman (input) for mailman id 101073; Wed, 24 Mar 2021 16:28:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6N7-0006yD-TO for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:28:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6N7-0005Gp-Qp for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:28:41 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lP6N7-0001ls-Ok for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:28:41 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1lP6N5-0005Ub-TI; Wed, 24 Mar 2021 16:28:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From; bh=CAKFSKwsySbvmSwBuqmOj4VNvCksUSzlZIh0/BV+8Us=; b=MsAWSK0PWaZtg+lCIkNajI9ijw Er4BV6NS5WhzYbK0aUPHkisVfDXlOWR9jr+K37O1vEsw18YFxP923l+hjzAem2523nsFKISZGNN0c hw9JgvB0EGWgLV8T6ScAVP8oM7HmB9K2Z5AMERqe/m3d7PPbG6dP/OA1KwDqHFU6+/Ro=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: iwj@xenproject.org Subject: [PATCH 1/2] Branching: Update version files etc. for newly unstable Date: Wed, 24 Mar 2021 16:28:30 +0000 Message-Id: <20210324162831.7587-1-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Ian Jackson --- CHANGELOG.md | 2 ++ Config.mk | 4 ++-- README | 16 ++++++++-------- SUPPORT.md | 2 +- xen/Makefile | 4 ++-- 5 files changed, 15 insertions(+), 13 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c407f6bb2f..f76fadf8c7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ Notable changes to Xen will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) +## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD + ## [4.15.0 UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.15.0) - TBD ## Added / support upgraded diff --git a/Config.mk b/Config.mk index a56a971028..9a174c77f3 100644 --- a/Config.mk +++ b/Config.mk @@ -244,7 +244,7 @@ QEMU_TRADITIONAL_URL ?= git://xenbits.xen.org/qemu-xen-traditional.git SEABIOS_UPSTREAM_URL ?= git://xenbits.xen.org/seabios.git MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git endif -OVMF_UPSTREAM_REVISION ?= a3741780fe3535e19e02efa869a7cac481891129 +OVMF_UPSTREAM_REVISION ?= master QEMU_UPSTREAM_REVISION ?= 7ea428895af2840d85c524f0bd11a38aac308308 MINIOS_UPSTREAM_REVISION ?= 051b87bb9c19609976fb038f386920e1ce5454c5 @@ -253,7 +253,7 @@ SEABIOS_UPSTREAM_REVISION ?= rel-1.14.0 ETHERBOOT_NICS ?= rtl8139 8086100e -QEMU_TRADITIONAL_REVISION ?= xen-4.15.0-rc1 +QEMU_TRADITIONAL_REVISION ?= 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 # Wed Jul 15 10:01:40 2020 +0100 # qemu-trad: remove Xen path dependencies diff --git a/README b/README index aa8b4fe126..fad96672af 100644 --- a/README +++ b/README @@ -1,11 +1,11 @@ -################################# - _ _ _ ____ -| || | / | ___| _ __ ___ -| || |_ | |___ \ _____| '__/ __| -|__ _|| |___) |_____| | | (__ - |_|(_)_|____/ |_| \___| - -################################# +############################################################ +__ __ _ _ _ +\ \/ /___ _ __ _ _ _ __ ___| |_ __ _| |__ | | ___ + \ // _ \ '_ \ _____| | | | '_ \/ __| __/ _` | '_ \| |/ _ \ + / \ __/ | | |_____| |_| | | | \__ \ || (_| | |_) | | __/ +/_/\_\___|_| |_| \__,_|_| |_|___/\__\__,_|_.__/|_|\___| + +############################################################ https://www.xen.org/ diff --git a/SUPPORT.md b/SUPPORT.md index a1efd8fcfd..3ef072681b 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -9,7 +9,7 @@ for the definitions of the support status levels etc. # Release Support - Xen-Version: 4.15-rc + Xen-Version: unstable Initial-Release: n/a Supported-Until: TBD Security-Support-Until: Unreleased - not yet security-supported diff --git a/xen/Makefile b/xen/Makefile index 0b97e459e2..ab7d86d226 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -1,8 +1,8 @@ # This is the correct place to edit the build version. # All other places this is stored (eg. compile.h) should be autogenerated. export XEN_VERSION = 4 -export XEN_SUBVERSION = 15 -export XEN_EXTRAVERSION ?= .0-rc$(XEN_VENDORVERSION) +export XEN_SUBVERSION = 16 +export XEN_EXTRAVERSION ?= -unstable-rc$(XEN_VENDORVERSION) export XEN_FULLVERSION = $(XEN_VERSION).$(XEN_SUBVERSION)$(XEN_EXTRAVERSION) -include xen-version -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 16:31:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 16:31:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101081.193027 (Exim 4.92) (envelope-from ) id 1lP6QH-0007vy-Sg; Wed, 24 Mar 2021 16:31:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101081.193027; Wed, 24 Mar 2021 16:31:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6QH-0007vr-Or; Wed, 24 Mar 2021 16:31:57 +0000 Received: by outflank-mailman (input) for mailman id 101081; Wed, 24 Mar 2021 16:31:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6QG-0007vh-BQ for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:31:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6QG-0005JU-9C for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:31:56 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lP6QG-000269-8A for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:31:56 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1lP6QE-0005VL-Cw; Wed, 24 Mar 2021 16:31:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From; bh=mM6fnuEo91Z+Ubd7EcaZ9peygj9tYiki9UBKDCKhOS8=; b=ag/WTBPznIowMxwIG0m1ax7zZQ GDtX9zPlNVeqKpZicrt5zfBsNChax2xJyIONPH/n4zHjZcGU+5Lr7cSvet3J5QFL8t3Os0kmfJuJs ZWw657K/GDCOtWXmTBPyu5WqzJrAp0LHoR6AkgegujG2mJBf93K/T3iW40NcGIu4FaG8=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: iwj@xenproject.org Subject: [PATCH for-4.15 1/2] 4.15: Turn off debug on the stable branch Date: Wed, 24 Mar 2021 16:31:44 +0000 Message-Id: <20210324163145.9217-1-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Ian Jackson --- tools/Rules.mk | 2 +- xen/Kconfig.debug | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/Rules.mk b/tools/Rules.mk index 2907ed2d39..444e5bacdd 100644 --- a/tools/Rules.mk +++ b/tools/Rules.mk @@ -20,7 +20,7 @@ CFLAGS_xeninclude = -I$(XEN_INCLUDE) XENSTORE_XENSTORED ?= y # A debug build of tools? -debug ?= y +debug ?= n debug_symbols ?= $(debug) XEN_GOCODE_URL = golang.xenproject.org diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index fad3050d4f..4419030235 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -3,7 +3,7 @@ menu "Debugging Options" config DEBUG bool "Developer Checks" - default y + default n ---help--- If you say Y here this will enable developer checks such as asserts and extra printks. This option is intended for development purposes -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 16:31:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 16:31:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101082.193034 (Exim 4.92) (envelope-from ) id 1lP6QI-0007wp-85; Wed, 24 Mar 2021 16:31:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101082.193034; Wed, 24 Mar 2021 16:31:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6QI-0007wI-0W; Wed, 24 Mar 2021 16:31:58 +0000 Received: by outflank-mailman (input) for mailman id 101082; Wed, 24 Mar 2021 16:31:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6QG-0007vm-OV for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:31:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6QG-0005JX-Nh for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:31:56 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lP6QG-00026L-Lu for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:31:56 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1lP6QE-0005VL-RD; Wed, 24 Mar 2021 16:31:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=I7a/KqTgUlS2a+YtME8Q5NSlV/CLAv/DaCI9qim66Vg=; b=IykuV8s2rBp5kGMy+ltQdt4qkT 3pPcXGBrMcZocLRlGB9dsbb+g0Dmnfd69wA3pJEJGDu6KKvEj9AeCTjwTQqX4xrVGL6anzRQej/ax zoevX7HaTm2bxAMKP5tkVWhOZTovyHutnn07OaZ4tNOEQcQXIcahgwtvzmWZo+XfOoUk=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: iwj@xenproject.org Subject: [PATCH for-4.15 2/2] CHANGELOG: Correct sub-section headings Date: Wed, 24 Mar 2021 16:31:45 +0000 Message-Id: <20210324163145.9217-2-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210324163145.9217-1-iwj@xenproject.org> References: <20210324163145.9217-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Ian Jackson --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c407f6bb2f..07f240b6ab 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,12 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ## [4.15.0 UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.15.0) - TBD -## Added / support upgraded +### Added / support upgraded - ARM IOREQ servers (device emulation etc.) (Tech Preview) - Renesas IPMMU-VMSA (Supported, not security supported; was Tech Preview) - ARM SMMUv3 (Tech Preview) -## Removed / support downgraded +### Removed / support downgraded - qemu-xen-traditional as host process device model, now "No security support, not recommended". (Use as stub domain device model is still -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 16:41:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 16:41:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101091.193067 (Exim 4.92) (envelope-from ) id 1lP6Za-0000lx-7X; Wed, 24 Mar 2021 16:41:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101091.193067; Wed, 24 Mar 2021 16:41:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6Za-0000lq-4X; Wed, 24 Mar 2021 16:41:34 +0000 Received: by outflank-mailman (input) for mailman id 101091; Wed, 24 Mar 2021 16:41:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6ZZ-0000ll-6w for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:41:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6ZZ-0005UD-1N for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:41:33 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lP6ZY-0003Q8-Vu for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:41:32 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lP6ZV-0005Wy-PK; Wed, 24 Mar 2021 16:41:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:CC:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=0ePatYhDjtMPoz0LupiynKhfC6gPUUIWv3q+GbEVQ/4=; b=4W8xQINqxlvzFMySVkefIAwmEW mfVoGbkFGKYc2QffkKG6HJRWD5ScgSCZ143NKnPDgv3Pby1CZ/0lMspXSnLEsUVexxVrzYyUCL6em 8KSHQeC3v2/TnnKXGj3W5D7aJts08GVpNXs5mqwCYlDX58bBcg/vAD7DITcyR09YaB64=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24667.27577.412129.252658@mariner.uk.xensource.com> Date: Wed, 24 Mar 2021 16:41:29 +0000 To: committers@xenproject.org, CC: xen-devel@lists.xenproject.org Subject: Xen 4.15 branched; commit moratorium lifted In-Reply-To: <24636.50438.204769.9038@mariner.uk.xensource.com> References: <24636.50438.204769.9038@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) I have just branched Xen 4.15. Patches targeted for Xen 4.15, with appropriate release-ack and maintainer acks, should be pushed to the branch staging-4.15. Patches targeting xen-next should be pushed to simply staging. Please do not commit anything to the new staging which would cause it to diverge from 4.15 in a troublesome way. Specifically, please avoid: * Anything textually intrusive - code motion, variable renaming, refactoring, etc. These would make back- and forward-porting fixes more complicated. * Any change X which would make it less reasonable to use the results of tests of "staging" including some other changes "Y" to justify the goodness of the same changes Y on "staging-4.15". This is relevant since the staging-4.15 branch now runs with debug off and we are expecting fixes to go to both trees in parallel at the moment. * Anything that needs intensive review by people working on the remaining outstanding issues for Xen 4.15. Maintainers, please continue to prioritise any 4.15 work that is on your plate. This regime will continue until 4.15.0 is actually released. Hopefully fairly soon; there are only few outstanding issues. For bugfixes targeting 4.15, you may develop them against staging first, or you may develop them against staging-4.15 first. In any case we probably won't want to release 4.15 without them having been applied to trunk. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Wed Mar 24 16:44:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 16:44:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101094.193079 (Exim 4.92) (envelope-from ) id 1lP6cF-0000tW-ME; Wed, 24 Mar 2021 16:44:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101094.193079; Wed, 24 Mar 2021 16:44:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6cF-0000tP-J0; Wed, 24 Mar 2021 16:44:19 +0000 Received: by outflank-mailman (input) for mailman id 101094; Wed, 24 Mar 2021 16:44:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6cE-0000tK-9B for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:44:18 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fe3c2d2f-ee37-440e-86e5-56f21fca31a0; Wed, 24 Mar 2021 16:44:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe3c2d2f-ee37-440e-86e5-56f21fca31a0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616604256; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4C4OgRiFuuJLkcoqPkh43cejHpfFvgEUCcVuNhnuUcc=; b=d1oW4l0nFL8HDeBlmxNAQS0Qc1WUHTCUNqSXCx7ZMyci2TAGHmFE9NY9 1iy/DWWMZ/C/8y9lc5iNId3iZ4fMcXmGUuZeKimuRKB7bB1wTs8NeYiUh 4FH/JynxlgMwyuhg/nIRQHLQygOdjbmlB8U7jqmCsYJihaYnxGnjHMNFy o=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 72Mkk4St9jViuPz78rtfz6TM6I6eKt8KZIl013QVGgP17ydrzEiXnXlOO1elZxsa3fVpHUuW5m Glp0Qq6VD6AIaA01m6yuvxal37EghsvW1MJFV0rPpux3q9Lvu7b3Po5i7j64tBJoJoBwfHzYcV abLpBBtLWF/m+fqPI3YRdqijHwJ3vvaN5/snWjyEkv22O+JpUMfgoSqh6QeuBarq1uxrdXi1G4 4CLg3mixfNrWXqO8bQnzpb9sdtcSz2PL5ukh7K7huzfgCIclNNjaivo9c88p9HbLxgaDmBeFGf saw= X-SBRS: 5.1 X-MesageID: 41481705 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:4WA9Q6x8Fj8kelO1QWKZKrPwqb1zdoIgy1knxilNYDZ+G/b3q+ mFmvMH2RjozAsLUHY7ltyafIWGS3XQ9Zl6iLNhW4uKdg/gpWeuMcVe/ZLvqgeQYxHW2+ZB2c 5bE5RWJ8b3CTFB4frSwA79KNo4xcnCzabAv5a6815IbSVHL55t9B14DAHzKDwQeCBjCYAiHJ SRouprzgDQGkg/VciwCnkbU+WrnbSi//iKXTc8CxEq8wWIhz+zgYSKdySw5RsCTyhJhY4r7G mtqX2B2oyYr/q5xhXAvlWz071qnrLapedrNYipgsgRJi6EsHfLWLhc X-IronPort-AV: E=Sophos;i="5.81,275,1610427600"; d="scan'208";a="41481705" From: George Dunlap To: CC: George Dunlap , George Dunlap , Ian Jackson , "Paul Durrant" Subject: [PATCH 2/6] CHANGELOG.md: Add named PCI devices Date: Wed, 24 Mar 2021 16:44:03 +0000 Message-ID: <20210324164407.302062-2-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210324164407.302062-1-george.dunlap@citrix.com> References: <20210324164407.302062-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- CC: Ian Jackson CC: Paul Durrant --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f03e85bd7..8c89212f14 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Renesas IPMMU-VMSA (Supported, not security supported; was Tech Preview) - ARM SMMUv3 (Tech Preview) - Intel Processor Trace support (Tech Preview) + - Named PCI devices for xl/libxl ## Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 16:44:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 16:44:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101095.193091 (Exim 4.92) (envelope-from ) id 1lP6cL-0000wL-0C; Wed, 24 Mar 2021 16:44:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101095.193091; Wed, 24 Mar 2021 16:44:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6cK-0000vu-Rt; Wed, 24 Mar 2021 16:44:24 +0000 Received: by outflank-mailman (input) for mailman id 101095; Wed, 24 Mar 2021 16:44:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6cJ-0000tK-7J for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:44:23 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cd8a576e-bffc-4142-a06d-66bd92ffbff7; Wed, 24 Mar 2021 16:44:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd8a576e-bffc-4142-a06d-66bd92ffbff7 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616604257; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HNnD1ifZG7hjYa3HYfpM+QU5Aly2XM1Az6oLBD+L1c0=; b=CsvjfrACZe9xeZIi3Qw98JRd3RENe2tit/3Thgm4zPeIw/ql+CK39B4V WxxSVP4EKD7ti4eiADrAWsiFAjm5Vo8SGCrCGnqMwH2n8PYP7Dgzvy1us yY3eL7VuOsm9eXmZRaVLWjCZ0FSJ+S9IZVM9LGOiOUvqRyAwUydAOSenh Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: PPq1jVeQZFpMdVmFuc7zLN3wW/CXZT5AZen1WyoSNpU5+e7os/bA52KC77bUyhTQA3vyLhXdPq mkfj/EAH3k3mlHogb30/L3mFAqPIK7B20XX9g24sv+wa1n3D1oNBK0Oln9dA/z/W4svjbtf8Z0 kxm8SQrLRB1Cn3y/4GkkF7S38w3mZaNXiGJIZdRejhmcViHjJXNTUTJjwNVA7/5aTNOYmso9qC SFAIud8qEGhluQUs4azgJxDmMjxiWcgjZ8DJvTltnJ29QxTXK2W+uQlCXazDeFh7o3l8fGqIxW yEU= X-SBRS: 5.1 X-MesageID: 40025049 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:P50lxqFyTAMRJKMXpLqEb8eALOonbusQ8zAX/mpaICY1TuWzkc eykPMHkSLugDEKV3063fyGMq+MQXTTnKQFmLU5F7GkQQXgpS+UPJhvhLGSuAHINiXi+odmpM RdWodkDtmYNzdHpOb8pDK1CtMxhOSAmZrY4dv261dIYUVUZ7p77wF/YzzrdHFeYAVdH5I2GN 69y6N81lidUE8aZMi6GXUJNtKrz7ag+f7bSCULCBI95A6FgSnA0s+cLzGi0goDSDQK+L8+8A H+4nTEz5++uPK2wAK07Q/uxqlR8eGO9vJzQOiFis0YMVzX+2OVWLg= X-IronPort-AV: E=Sophos;i="5.81,275,1610427600"; d="scan'208";a="40025049" From: George Dunlap To: CC: George Dunlap , Jan Beulich , Ian Jackson Subject: [PATCH 3/6] CHANGELOG.md: Add dom0 zstd compression support Date: Wed, 24 Mar 2021 16:44:04 +0000 Message-ID: <20210324164407.302062-3-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210324164407.302062-1-george.dunlap@citrix.com> References: <20210324164407.302062-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- CC: Jan Beulich CC: Ian Jackson --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8c89212f14..354f213e81 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - ARM SMMUv3 (Tech Preview) - Intel Processor Trace support (Tech Preview) - Named PCI devices for xl/libxl + - Support for zstd-compressed dom0 kernels ## Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 16:44:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 16:44:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101096.193103 (Exim 4.92) (envelope-from ) id 1lP6cQ-00010z-8M; Wed, 24 Mar 2021 16:44:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101096.193103; Wed, 24 Mar 2021 16:44:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6cQ-00010r-56; Wed, 24 Mar 2021 16:44:30 +0000 Received: by outflank-mailman (input) for mailman id 101096; Wed, 24 Mar 2021 16:44:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6cO-0000tK-7Q for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:44:28 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ff0ec8d3-c315-48f2-b880-cb1ff001fada; Wed, 24 Mar 2021 16:44:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff0ec8d3-c315-48f2-b880-cb1ff001fada DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616604257; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uuDn92Xa+RMV3fXLuJmjz/2MKOAAr3rYq4Eg3slmcAY=; b=Vkbs2XGbPu7Xgb2BEQlfHwuB57/MVVFYZS+UsG07zjF+l9QNzN8tK/pJ xIE/BHwMWfPi9tPNm4H9B5DVV0QIVt1LedJ17sEQG4vvbU3kPYgnNJe0r 2eZwGAplXhGQHLj5646BPuy4R23Eee63+KNBQAZR6ie/ibnWDZdml2Vv6 0=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: GqzawePQgz9PxUPeDgr0q7W6iezpgERIlM0U+8SgFB+Pl5NpKSuJX+5p4Df6UxO1eA3QiW21Sr +0VmG7SkTEkIk1UWAsF+MKzVQZCBFXkurOgZJ0HfOvshlJPD9gnJQnX1mEyn4E2+4afbmOx4pt QCBqo9MfOKP7aw93nVPK/K2rZ4EJxtl0pxXiBM9VfjZwMjTaoY0W8XUqttMasu12r70If0FcpT b2o7FRqX7hNUe8+ATgowTqJCHP1vWJxb9y/kDYqxxxZeCgbIUmunABs0WuxBbzsPy2uyvJMjOR n3k= X-SBRS: 5.1 X-MesageID: 40194788 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:IVe/u62d1JlqnJ1QMPCwrAqjBWByeYIsi2QD101hICF9WtCEls yogfQQ3QL1jjFUY307hdWcIsC7LE/035Qd2+ksFJ2lWxTrv3btEZF64eLZslndMgDd1soY76 dvdKBiFMb9ZGIRse/W6BS1euxO/PCp66at7N2x815IbSVHL55t9B14DAHzKDwSeCBjCYAiHJ SRouprzgDQGkg/VciwCnkbU+WrnbSi+K7OWhIaGwUhrDCHkDLA0tXHOiKF1RQTWS4n+8ZBzU H5lWXCh5mLgrWA5TL3k0TS6JlXn9WJ8Ko/OOW8zvI7Bx+ppgKhZIFKU6CPsjYvsIiUmSoXue iJmTgMFYBe7G7QY3GUrHLWqnbd+Qdr0VDO4xu5hmbuusPwTj5SMbs+uatpNiH3xmBlmfMU6t Mt40up86B5IDmFoQHGo//PbB1unlrcmwtYrccjy0ZxfKFbVKVctuUkjSVoOaZFJg3WwqY9Ht JjCcnNjcwmC2+yXjTism5jzMfEZAVLIj62BkwLusmi2zNLhnxOz0wB2MwFnnsbnahNM6V52w == X-IronPort-AV: E=Sophos;i="5.81,275,1610427600"; d="scan'208";a="40194788" From: George Dunlap To: CC: George Dunlap , Wei Liu , "Andrew Cooper" , Stefano Stabellini , Doug Goldstein Subject: [PATCH 6/6] CHANGELOG.md: Add entries for CI loop Date: Wed, 24 Mar 2021 16:44:07 +0000 Message-ID: <20210324164407.302062-6-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210324164407.302062-1-george.dunlap@citrix.com> References: <20210324164407.302062-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- CC: Wei Liu CC: Andrew Cooper CC: Stefano Stabellini CC: Doug Goldstein --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index df6c638152..15a22d6bde 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Library improvements from NetBSD ports upstreamed - x86_emulate: Support AVX-VNNI instructions - x86_emulate: Expanded testing for several instruction classes + - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 + - CI loop: Add dom0less aarch64 smoke test ## Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 16:44:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 16:44:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101097.193115 (Exim 4.92) (envelope-from ) id 1lP6cU-00015J-Ie; Wed, 24 Mar 2021 16:44:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101097.193115; Wed, 24 Mar 2021 16:44:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6cU-00015B-Eb; Wed, 24 Mar 2021 16:44:34 +0000 Received: by outflank-mailman (input) for mailman id 101097; Wed, 24 Mar 2021 16:44:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6cT-0000tK-7X for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:44:33 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 33457c72-4f36-4705-88af-f154b97b3ef3; Wed, 24 Mar 2021 16:44:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33457c72-4f36-4705-88af-f154b97b3ef3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616604257; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=htk9xO6z3G+FcDv3EiIjr9djRWyj7OaRbk3W8bSI+ZQ=; b=IOut/3q+VNHlW7rg/Go7uX2rk5yrB/9nxJkgJBPxT52S3EjTF8inJfF5 rcPLarSXK46JR0sXwdyFrkQGGTD39/9W4eI2PL2CYhwV6qWOnCv26csDp JZAbYNAEoRddFxD/199otYvEFPHLUMXMDHxc6nquRX01I+aqJYxAbXsVW Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: FiAo8yIHN16AxecqiGjYKuUqRVeMwc6QEKsqQoMN7FoHa7AeIXfqOZnCS0OJzQkgdJcIr7bsgY Z/dtu0c7UcH+nOG+cdRiC/ss1OkiLPQQOufZrHAyOoFExSb8GcV7tSfV7vkCAU+2gvXDxu58gW 1urOfWxNVCSjq7dqrhuzrIweCOE1ITv2LrA/9h9zaQz9pzboR73za3Vq0PXd0athQJ/ECVW2jd 0avcUgNn93KAOvwZoEtW932npaSk3K61BugKEPRpHdXVARIR7MSoKVXWGPtWB6TrOIsSM7781q LIA= X-SBRS: 5.1 X-MesageID: 40402379 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:nylJxK17XkDlVqKfNhgjngqjBWByeYIsi2QD101hICF9WtCEls yogfQQ3QL1jjFUY307hdWcIsC7LE/035Qd2+ksFJ2lWxTrv3btEZF64eLZslndMgDd1soY76 dvdKBiFMb9ZGIRse/W6BS1euxO/PCp66at7N2x815IbSVHL55t9B14DAHzKDwSeCBjCYAiHJ SRouprzgDQGkg/VciwCnkbU+WrnbSi+K7OWhIaGwUhrDCHkDLA0tXHOiKF1RQTWS4n+8ZBzU H5lWXCh5mLgrWA5TL3k0TS6JlXn9WJ8Ko/OOW8zvI7Bx+ppgKhZIFKU6CPsjYvsIiUmSoXue iJmTgMFYBe7G7QY3GUrHLWqnbd+Qdr0VDO4xu5hmbuusPwTj5SMbs+uatpNiH3xmBlmfMU6t Mt40up86B5IDmFoQHGo//PbB1unlrcmwtYrccjy0ZxfKFbVKVctuUkjSVoOaZFJg3WwqY9Ht JjCcnNjcwmC2+yXjTism5jzMfEZAVLIj62BkwLusmi2zNLhnxOz0wB2MwFnnsbnahNM6V52w == X-IronPort-AV: E=Sophos;i="5.81,275,1610427600"; d="scan'208";a="40402379" From: George Dunlap To: CC: George Dunlap , Andrew Cooper , Ian Jackson , "Tamas K Lengyel" Subject: [PATCH 1/6] Intel Processor Trace Support: Add CHANGELOG.md and SUPPORT.md entries Date: Wed, 24 Mar 2021 16:44:02 +0000 Message-ID: <20210324164407.302062-1-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- CC: Andrew Cooper CC: Ian Jackson CC: Tamas K Lengyel --- CHANGELOG.md | 1 + SUPPORT.md | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c407f6bb2f..7f03e85bd7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - ARM IOREQ servers (device emulation etc.) (Tech Preview) - Renesas IPMMU-VMSA (Supported, not security supported; was Tech Preview) - ARM SMMUv3 (Tech Preview) + - Intel Processor Trace support (Tech Preview) ## Removed / support downgraded diff --git a/SUPPORT.md b/SUPPORT.md index a1efd8fcfd..966ddf89c8 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -247,6 +247,13 @@ Export hypervisor coverage data suitable for analysis by gcov or lcov. Status: Supported, Not security supported +### Processor trace support + +Support for using Intel Processor Trace technology to trace guests +from dom0. + + Status: Tech Preview + ## Memory Management ### Dynamic memory control -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 16:44:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 16:44:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101101.193130 (Exim 4.92) (envelope-from ) id 1lP6cZ-0001AZ-Ua; Wed, 24 Mar 2021 16:44:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101101.193130; Wed, 24 Mar 2021 16:44:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6cZ-0001AP-R7; Wed, 24 Mar 2021 16:44:39 +0000 Received: by outflank-mailman (input) for mailman id 101101; Wed, 24 Mar 2021 16:44:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6cY-0000tK-7k for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:44:38 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1b212ca8-7197-43ec-9b5e-2948383f5ef5; Wed, 24 Mar 2021 16:44:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b212ca8-7197-43ec-9b5e-2948383f5ef5 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616604258; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=l99nOtKLPrGEf6ULF3EGXRUV0bzZIKdFxjmIfooqryA=; b=C2ohTtvLxj0+gsUs/hx9KRG0eYSfOpv3xsH/Qy0YbilATxW/JXdo9JlU vSqUdbsebKAqq9brguNyvMfKtfluEO1N5QeqrLIscjvxNAddz/EN60QZK IZ5WdOtkfQTN8PIhulRXwUCnf7v8BOXiXDUZle53OGkBAwZ40uOCGdklP 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: htnATXmK+cQQ45y8DtyjhJ++/whaqkceXpfRc/s9pw0ijx8f/IjMGTFJ7f9LXQgE0C48bOuSCd ZQCKnw4d5tSJo98LE9XpQy9qKNJBAqPofXRYpb3AQ6/FS8dCSFeda5N2e6dEdG8qQ8JECXIXhq iHelVKk51aTP3MOoAntpx4bCUZeS/syX6q7FA+zR9wSv9ZZqN3tlEue2F+NR1+0wHaZ8fF2fez nxKCMT7NovKjFP0aLj3iRhitCQiSpIOmiVxNWg9fEOfeaBa1eL7+GU12DzxRXk+9c1SwzxdQEp AW4= X-SBRS: 5.1 X-MesageID: 41481707 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:WPpXT6PkOfU6O8BcTkajsMiAIKoaSvp033AA/SlKKCB9WMqeis yogbAnzhfykjkcQzUNntqHNamGTxrnhOdIyKMWOqqvWxSjhXuwIOhZnPDf6hDpBiGWzJ8/6Y 5OaK57YeeeMXFbioLA7BC8A5IcxrC8gcSVrMP/61socg1wcaFn6G5Ce2CmO2l7XhNPC5Z8NL f03LskmxOadX4abtu2CxA+NoCpzbCmqLvcbRELHBIh4gWV5AnYj4LSKBSEwgwYFwpG3LZKyx m8ryXC+q6hv/unoyW960bv6f1t9ufJ+59mDMyIhtN9EESItjqV X-IronPort-AV: E=Sophos;i="5.81,275,1610427600"; d="scan'208";a="41481707" From: George Dunlap To: CC: George Dunlap , Jan Beulich , Ian Jackson Subject: [PATCH 5/6] CHANGELOG.md: Add entries for emulation Date: Wed, 24 Mar 2021 16:44:06 +0000 Message-ID: <20210324164407.302062-5-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210324164407.302062-1-george.dunlap@citrix.com> References: <20210324164407.302062-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- CC: Jan Beulich CC: Ian Jackson --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3f4eed1d98..df6c638152 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Named PCI devices for xl/libxl - Support for zstd-compressed dom0 kernels - Library improvements from NetBSD ports upstreamed + - x86_emulate: Support AVX-VNNI instructions + - x86_emulate: Expanded testing for several instruction classes ## Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 16:44:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 16:44:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101102.193142 (Exim 4.92) (envelope-from ) id 1lP6ce-0001FS-DZ; Wed, 24 Mar 2021 16:44:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101102.193142; Wed, 24 Mar 2021 16:44:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6ce-0001FH-9d; Wed, 24 Mar 2021 16:44:44 +0000 Received: by outflank-mailman (input) for mailman id 101102; Wed, 24 Mar 2021 16:44:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6cd-0000tK-7s for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:44:43 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b8b9bb53-14d3-40e0-83b8-30db28edc8ce; Wed, 24 Mar 2021 16:44:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8b9bb53-14d3-40e0-83b8-30db28edc8ce DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616604258; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HQKmSZbFHLlD6mdZiLQiH7gZyoPJGO1tQ6hBSalifes=; b=JYvq87y0d5GDUooPKQFVPF4nuEMcWG2nkt6sIuAODNwoVH5DBwIYxNCC TstAI/RyWJJBrE+CaIxh5vUoIRbbWB219DkZnmLJb1wxVdBLnB4HH9jTC HYSUi6WqYXTiHxSqUfpSebOVJ6/8m4a2KoXdCGuacSJgne03GrKYF4cOP I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 4V+mfC6D+jk8A++6gCRyvS18VOqoP2x3MSvf7pV64XG0VgHsHwf3L5pXzg7eMSOrgnBO/xNZN9 RtfYt5g/Vj2EVCqXbSFu13CQ3h1wH9lFAEoQRCR9nt2fLMTx6Am3p4xls2Qn4V+kwvOVwwe8LK PK2oZJXmukBALL8NFz8kqrb8ZkrpLDYwQStkEsjKRSnWzWknajaW6dzHnkXfj9CeenxankQmJ3 EhzS6pH3la+wULjkaj9U+rvJWo2nVIkfs8UrN1rSqSduEE3vPrachOoggznooesFhA8d/C2Q/a CMk= X-SBRS: 5.1 X-MesageID: 40025050 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:dqKNcatkDk0MV/m0rT+KzPX47skD8dV00zAX/kB9WHVpW+az/v rOoN0w0xjohDENHEw6kdebN6WaBV/a/5h54Y4eVI3SJTXOkm2uMY1k8M/e0yTtcheOjdJ1+K 98f8FFeb7NJHdgi8KS2maFOvYmhOKK6aW5wdrZpk0dKT1CT4FFw0NHBh2AEktwLTM2Y6YRMJ aH/MJIq36BVB0sH6aGL0IIVeTCuNHH/aiOCXVtanIawTKDgj+y5LnxHwLw5GZ4bxp1zao/6m +AqgTl58yYwomG4yXB3Gze5Yk+orvc4+ZEbfbjtuElbhHligOlf+1aKti/gAw= X-IronPort-AV: E=Sophos;i="5.81,275,1610427600"; d="scan'208";a="40025050" From: George Dunlap To: CC: George Dunlap , Manuel Bouyer , Ian Jackson , Roger Pau Monne Subject: [PATCH 4/6] CHANGELOG.md: NetBSD lib/gnttab support Date: Wed, 24 Mar 2021 16:44:05 +0000 Message-ID: <20210324164407.302062-4-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210324164407.302062-1-george.dunlap@citrix.com> References: <20210324164407.302062-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- CC: Manuel Bouyer CC: Ian Jackson CC: Roger Pau Monne --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 354f213e81..3f4eed1d98 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Intel Processor Trace support (Tech Preview) - Named PCI devices for xl/libxl - Support for zstd-compressed dom0 kernels + - Library improvements from NetBSD ports upstreamed ## Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 16:46:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 16:46:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101116.193154 (Exim 4.92) (envelope-from ) id 1lP6ed-0001aX-Sb; Wed, 24 Mar 2021 16:46:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101116.193154; Wed, 24 Mar 2021 16:46:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6ed-0001aQ-P5; Wed, 24 Mar 2021 16:46:47 +0000 Received: by outflank-mailman (input) for mailman id 101116; Wed, 24 Mar 2021 16:46:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6ec-0001aH-P2 for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:46:46 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 512a7c8b-93e9-4154-b2ae-7457b7f58386; Wed, 24 Mar 2021 16:46:45 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E79A6AC6E; Wed, 24 Mar 2021 16:46:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 512a7c8b-93e9-4154-b2ae-7457b7f58386 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616604405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n6i7nu6V14z8iUlVi3BFmtjFBYOeo7NXXXlzghwJc78=; b=nl2fgFJXkuePR0fUg4oajDgAg/ihJLs7AqlqVAi3qzHBha6h4XHIY2LNZLo0/ZTeCkTEwp mGL975Z+IqbL5aHZmnaHOeuta7AVoAxtyYFnY9Hfg8Y2AixzPprsh9WEUrfJjqXck6W62K 8vsvJH1eiI6DezFGniv4Web9LwmqnsA= Subject: Re: [PATCH 1/2] Branching: Update version files etc. for newly unstable To: Ian Jackson References: <20210324162831.7587-1-iwj@xenproject.org> Cc: xen-devel@lists.xenproject.org From: Jan Beulich Message-ID: <0c938aa8-a954-55f5-7d21-37f2c10ea136@suse.com> Date: Wed, 24 Mar 2021 17:46:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210324162831.7587-1-iwj@xenproject.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 24.03.2021 17:28, Ian Jackson wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -1,8 +1,8 @@ > # This is the correct place to edit the build version. > # All other places this is stored (eg. compile.h) should be autogenerated. > export XEN_VERSION = 4 > -export XEN_SUBVERSION = 15 > -export XEN_EXTRAVERSION ?= .0-rc$(XEN_VENDORVERSION) > +export XEN_SUBVERSION = 16 > +export XEN_EXTRAVERSION ?= -unstable-rc$(XEN_VENDORVERSION) I suppose you didn't mean to leave "-rc" in there? Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 24 16:56:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 16:56:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101120.193169 (Exim 4.92) (envelope-from ) id 1lP6o7-0002gt-Qf; Wed, 24 Mar 2021 16:56:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101120.193169; Wed, 24 Mar 2021 16:56:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6o7-0002gm-NN; Wed, 24 Mar 2021 16:56:35 +0000 Received: by outflank-mailman (input) for mailman id 101120; Wed, 24 Mar 2021 16:56:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6o6-0002gh-CO for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:56:34 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 80ba966c-384f-4e93-82da-48e6014adf8f; Wed, 24 Mar 2021 16:56:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80ba966c-384f-4e93-82da-48e6014adf8f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616604993; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=f0zDlUB07BELHZiqmOHgD17Re/pPjdjty+q0GQc01Hk=; b=ECIpvPcbL4XfxRRV4CxUVGUY88LKd0mvtJF0cNZb9oXOqIPLke7G3IS+ GOTqF/zNfar0m+BvmbxMOq3u8WKDfqy/K+atXsYOnuM+ud/Im2P3waE8x c604jf+JMrpHud5x7QmpQsbZYrJHDy5Ml0BDUJ+8O5Jo62ftyf5xxZ4Cm 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Yutt9LcTB7wAQMjoslpKkb3EF4rqlGhddL0aHgEDu8rIQwUrfsvQ7Qg39dNaxXctOq3jLj867o PssZyU9AUfKbeWDEJ1H6OxpBn6gVPE4RDIPBwKeRhWJX29BzbH1F635h4SNYn314+yeSA+IDbu iUtEEsrQ3o+DeNInO9EOcLPj3SqtFz5zCEfbLHdAkc8g3AR/6uOzdmh53igZtn9Z1Y1m9duL/V k2qiluAA+05E2M2aVdm5MoOxv/hNGllhPWdS315SuV0AkqxG09wxoPhZgF36GoMgyf6tSPBuey OC8= X-SBRS: 5.2 X-MesageID: 39918200 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:C6em9KH+IUwrWGvXpLqFR5TXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7L0/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeOJwTXzcQY76 tpdsFFZOHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLT1CQYsI1XYfNi+wFEpqSA5aQb8wE5 SB7sRKzgDQB0g/RMK9G3UDQqz/vNXNjp3relorABQg5QmIg1qTmcHHOjKf2QoTVC4K/Kc6/Q H+4nDEz4iAk9X+8B/T0GfP849b8eGB9vJvDNGB4/JlUQnEpR2vYO1aKsS/lRAz5Nqi8VM71O TLyi1QQvhbz1P0UiWLrQD22w/muQxemUPK7VODm3PsrYjYaVsBerJ8rLlUeBfY9EYs1esUuM kgshP7xvgneS/opyjz68PFUBtnjCOP0BwfuNUekmBFVs8mYKJRxLZvj399KosKHy7x9ekcYY xTJfzbjcwmFW+yU2rUpS1GztCqQx0Ib227a3lHkMmU3z9KpWt+3ksVyecO901whK4Vet1q4f /JPb9vk6wLZsgKbbhlDONEesevDHfRKCi8fl66EBDCLuUqKnjNo5n47PEc4/yrQoUByN8XlI 7aWF1VmGYucyvVeIyz9awO1iqIbHS2XDzrxM0bzYN+oKfASL3iNjDGYEwykuO7ys9vQPHzar KWAtZ7EvXjJWzhFcJixAvlQaRfLnEYTYk8pss7YVSTucjGQ7ea9dDzQbL2Hv7AADwkUmTwDj 8oRz7oPvhN6UitRzvWmx7Ud3TxelHu3J55HaTAltJjjLQlB8lpiEw4mF657saEJXlpqaotZn ZzJ7vhj+eaqACNjCH1xlQsHiAYIlde4b3mXX8PjxQNKVnIfbEKvMjaXWhT2XCANyJuVs++Kn 8Ym31HvYaMa7CAzyErDNyqdkiAiWEImX6MR5AA3oqO+NniYZF9Kpo9QqR+GUHqGnVO6EZXgV YGTDVBal7UFzvoh6ngpocTHvvje951hxruB9VVp3LZvUC1vtouWXMfYj6rXaes8EMTbgsRom c0374UgbKGlzrqA3A4mv4EPFpFb3nSPKhLFz2fZIJfmqnifSZ5SWviv03CtzgDPk7Rs2kCjG 3oKiOZPdXGGEBUtHxj3qH2y19sbWmGc0Vsand1jJ1lGQ39ywNO+N7OQpD2/3qaa1MEzO1YCj 3DbDcICi5Fxty81neu6Xu/PERj4q9rEv3WDbwlfb2W52ikL5eQk7oaW9VO+ox+CdzouugXcO 6WdgOPNgnkA+cx1wH9nAd8BABE7F0f1d/40hzs62a1mEMlCf3JOVJ8WvU1Jcqf42WMfYfB7L xJyfYO+c2+PWX6ZoTYleX5bztfJgjSpmDzZecyspxQtb8zsrw2P5Sza0q/6Fh3mDEFaOHznw ciZY4+xpbrEIpmZdYTdCJU5UBBrqXEEGIb9ijNRtYjdlQshULBN9yH47D0uaMia3fx0zfYCB 26yWlh5P/LUCuI6K4CB48xKWpQblIg6H4KxpLKS6TgTCGrffpE5ly0LzuUd6JcUrGMHdwr31 pHyuDNu++cbCzj3g/M+RN9P6JV6m6iBee/GhiFF+IN09u0Pz238+SXyf/2qDf8Uj2gbUsEwa VDaEwLd8xGzgAYs7df6Fn4doXH5mQ/k1Vf5jl7llninqieiV2rbH1uAEn+mZVZXT5aL36Sq9 /KmNLoj0jA3A== X-IronPort-AV: E=Sophos;i="5.81,275,1610427600"; d="scan'208";a="39918200" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kl7yrmtN1TQWmQcCg/D0LlQeOrolAiaczI+7LcqKnEM4M+exUbv+uCL73qgYlqm7VPlc4ob36B5tm5OtL3/BbNz8v6T9IWqAWiHav0YHgsayiFr+0HHXP8JAGMm8rb8GRqxGqhpFUHj2rqb+1jyh0do90wBl0Fw6g1gZJ5uIv2PbHHQ9FsdX/NCsIw+11jxOgqNKbNOzyC4JlCZLSSPFzWmpkExtwTQ3v+sUJiqoPbeigpimEXi+3nIjCkwwHNoq6MXW0ahAHf6zOwuxH7CxfmbzVY1d5XUY4bY8LQVSH7KouyVBzZWYUD6pjiODtNEI5mkrWkc1uj6Rzplfah5ScA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9jZzgQh+z562pkuD6somkr/WUuyuhExMTOPLQPrQ6gQ=; b=LkdsXVNRXTcmafv3lUCA5J53PXkbjSdNxpFcnceP5R2tEUhDOuTd84K/lWWIjqEq7GsugVgsLDaghx0uqQE/bOLoMBC/s72OTT4Wk0RMWihHV2POX8J0jY1ZmqJlekebZRWBCInV1/aO1h9mdlvMcwIKabsoA5zW20YNwuDgI8TG1D8Kc8p16iHER6qfpKL++1F4SXZQe20+xH+UJ+IRAxqeY1sUCMQWDf3NpE9Cu761kZ1UsricHyP57oCfbkY/jL1ktcb3RceTtiszc3PBTAzzj+7CbzmjFI3tdsHtNPn5pq0U4N82LQEWU8lrhfc7ipRXXmJ8jkiBiPDiEE2rNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9jZzgQh+z562pkuD6somkr/WUuyuhExMTOPLQPrQ6gQ=; b=valu5rn5QmzgjTvvc+zzLaeb6pu97v/HB11+/3rOguBgu8m+DabFsxY/y2tPsw4jO9iGdWWb1Ps6VwumWoVJkaAxXwHaoJ3Og8261SR7mGxxaKIemdNn2yebKI0E1Y2UITPjgo2E45o5QpvcO6PAFIMlNySoW5R2XEVNIPcKwNE= Subject: Re: [PATCH 3/6] CHANGELOG.md: Add dom0 zstd compression support To: George Dunlap , CC: Jan Beulich , Ian Jackson References: <20210324164407.302062-1-george.dunlap@citrix.com> <20210324164407.302062-3-george.dunlap@citrix.com> From: Andrew Cooper Message-ID: <1b2710e7-6491-2000-c4b3-e29e8ab5ffd2@citrix.com> Date: Wed, 24 Mar 2021 16:56:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210324164407.302062-3-george.dunlap@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0216.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::23) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d56197c-719d-4161-53a0-08d8eee5c485 X-MS-TrafficTypeDiagnostic: BN7PR03MB4387: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5z9Mw4jBgN7Nvo2oCLH6dFZsAZIbHPiDqpDh8O8kJqHSW+dE7F1/NI/RdJCQAA0vDfKQMCt43IyxaUPiK4iC/vEAjz0Pp7IizBEoXIjmzfg4C5W60B4mlr7xC4yFMnDzICFh9IdqxsfC8Ju7Pi7j0ux3xKSk4WTJyLrQ+64KZ1HAydZ3pcs7WO8AJki/b2HyfgQzK29QFk9Y5yUWCqar7ZLAoUwOTZUIW4Sjxxfv7B7BTxb18gQArdpKSOm8mL7r3xQsJBumbzqMt4aK/CG3JvKebCOO1T6tvZXo8oTQgBqpSOIh4anIJ2RWGn7WsyVrXsgEcUCm+cbG2W9bEQDNLY2KsUs5bsWY0wW0ldkisAeV5PUj76WrHBSToXo9hDX4WGWSUQlykrU/dcu6OgmZSOp4jN1hBVSIPv/8ymBSUSSMVN/alJKpR4lcOz433Q3EYY5NiLvNxT+Pz5xrXqTNeFiUU8Fe15HY6qEMNmMhYhKydkMFuEDqVNbg8wDW31j3tmaODTS66hQO2q0LO9qD3y8PSv8ewj/eOk6+tfo1jh8hG4ZT4FvoSsLJXSYZ3IQ15YdORtbRLVIrH4CRVvSpHbx8mA3aSU6iEQsV1Fevy3esRCapmLDysI9AZ4XP7sRaPftbclHavhSXrl5+EjzFElPQBbye3C2X8iJyVJ26MFhFz20kYCBz1SNMRZqePOf1zHB5JssjKtK2X/sMVM3wFEJlL/vNKhsmllOGMLjqgEpdFeVouyo9dtC98y1EmfulEXwyFDApRA9YXfVhjL758H1a9jouE2vftHIn19yozhP6CpA7rdF5EYW23WvuC8IrDM4eGWX9WnAwqIXAlH5Z+rwallM61/RKXVX5JSVDSTKM86fyL02jMEqaGd6CQrjy X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(346002)(136003)(396003)(39860400002)(956004)(53546011)(2616005)(66556008)(66476007)(66946007)(86362001)(31686004)(38100700001)(6666004)(36756003)(4326008)(31696002)(8676002)(5660300002)(2906002)(107886003)(4744005)(8936002)(316002)(16576012)(478600001)(6486002)(186003)(26005)(16526019)(54906003)(59356011)(207903002)(219803003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eFVSTlgwckZlVVFTdUZYV0pVY25JK1dudUU5QUZjTnBreU94SENabGgzZno4?= =?utf-8?B?T2lCSURRMU1NdzlYSTI4TFJFV29Ob1Rmc2pjbnREOTFpQ0dHNFdJUkR5eEhO?= =?utf-8?B?MU9xVGVzNjJqZGJhY0pEaVpwZVppaDJOUHVWTkpsbzdKRUZBenNPR0VQR0dk?= =?utf-8?B?aC9kRmNJWWhwbVhXVWN1OXFweFVMaHZhZjl1aVlsUEVrUzhBaFd2QkdQdHAw?= =?utf-8?B?dGVlOUpabTUwSmVET2ZYUTFpenY5NEpSbzJReW5EeDRLOGtuS3RIUjBRUCs5?= =?utf-8?B?WjcyMmN5V1VyUE9hVmJPOUJRcnRxZFZjRDh5TTdXZ0wzVXdCQzRiUXN0ejdI?= =?utf-8?B?RXZJSm5ma1NjOStRTXdqTVVHZ0JLMkxmcm1rK2RRNjQ5cGxFc1RKU3JyOTlJ?= =?utf-8?B?R0x2R1o2RVBHdjdoUmM1TFZXdGI1dzNMMG5EM015a2xJOHYrQ0JHRW5uYWZj?= =?utf-8?B?NmdxWG5YemM2SGlLeXBxSjlIdU9uWXBHYURrOUJyS0V0bVRxcWd4NXNieU93?= =?utf-8?B?Zi9DbVcyMFJKWktNQWlkWk5TQ1hUcEFUZnRZQndUdVEzNGszU0F1ck55b2Jl?= =?utf-8?B?SngvMDhzV2pQMG5ibXhiTW56UmhtTk5JOTdmdUY5ZHc0d2I1NTVqOVdHZWFo?= =?utf-8?B?VVY3RURTdWZDeEdDemFvUit0dGp1eGhxUGpsMDBUcGFFNnNJdWJtbkNaY1Uz?= =?utf-8?B?R2ZEVkdoQ3ZNUExwV0pnT1pLaXZ1SVcrYnh4eVU1K2t1clBpaEdqYzZZRmJY?= =?utf-8?B?MWtOdzUrV1RHZEdTb3RXQ0JHMVUyR2REQy83NlV5Rk40eXFJNStRcWorVTM4?= =?utf-8?B?R0xJcnZWdVFrMCtmTzhSODVxSWlQT3RvcU9GRFhDVmJJNUhRUFNqa1N5ZElU?= =?utf-8?B?ekY3TVZ3TktMQWwxWmhPbXVOS3ZDMUVXM2Vady9McUVhL0pRemV5WjdaL3o2?= =?utf-8?B?YlNjQ2NsM2pYUjFadGlIZ2ZOTU9YbDczd2RMd3NGWlVFamlscVhMdFhyYmhR?= =?utf-8?B?dUxUQWtHZDhhaE8rL1VPZ09peWtUZ2twd1VLNVlYZ1VXcmUxeFptUDdRMVpx?= =?utf-8?B?UkhHS1FnSEZtVlZKQlhZejlKSHZNM2IzTGlabW43Q2tNZE1TcGF1VmNpSkZq?= =?utf-8?B?b2dIWExEYkNYVkZCQlJjcEtNc284Sm1ZcmlsWFN0RFI4YS9nNHRJWklncFRV?= =?utf-8?B?aE0wVEVNay9IM1lDb29mOGg4aG11UTVnZ3IvRHFIeU51aXlDUzdNeE9ycm9C?= =?utf-8?B?SVh1STRpVE9OWDhQTldzb3BLd2JnOTdEVFpJazhSVmRuR2dLOGdLWE1YaEpX?= =?utf-8?B?SHRYQ0QrNW54dGc3dzdDREZRUjdtamdIQ2M5YWdtSG1oek9TczRLdDU3MWE5?= =?utf-8?B?b0wwYktqUGpoNmpzdWFlWlR0WHpGdjVTSHY4b0dwWGNZc0oxZWp6RzFaMjdx?= =?utf-8?B?VXVCbHQ5ZDJXWmlhbmljSFducnNqYWprTDdHdno4bFlaRFlOeitTVWJDbjhs?= =?utf-8?B?NXkyYlBaUTkzcU5lMVVRdUtIRERsWWRHQUpaeDBCdWVKU0grajRaeXlndHNx?= =?utf-8?B?QnI2UTlOekpkbVg5M21SMGJqRTNuQXYxei84TWFyb2VKVkNPYzlOTlVBZDYy?= =?utf-8?B?Kzkrb1dISkMyVXJBd0FLWmF5a0ZPNWJtZTZlOElSdW02cFZnemNuUWREV0ti?= =?utf-8?B?SVZJdjdROTBGZnZTejloc3JtVXBkc2M2TG9GZElqWUpJa0hmYWtGTDVlUVNr?= =?utf-8?Q?VgF1BowQeerfxu1VLL8kG8u08HM2BhwAFbyUHJb?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5d56197c-719d-4161-53a0-08d8eee5c485 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 16:56:28.7916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +g0c5IgCZY8PpNULJU6YCE0iEmBsM+Zgq/AlJ4wg+8RhmSoJup+sFmJexQle4VVJP2oAR7gAm9mwKF5IXJpxHnwgZe8FGRI9FSUMkCgptQs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4387 X-OriginatorOrg: citrix.com On 24/03/2021 16:44, George Dunlap wrote: > Signed-off-by: George Dunlap > --- > CC: Jan Beulich > CC: Ian Jackson > --- > CHANGELOG.md | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 8c89212f14..354f213e81 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - ARM SMMUv3 (Tech Preview) > - Intel Processor Trace support (Tech Preview) > - Named PCI devices for xl/libxl > + - Support for zstd-compressed dom0 kernels All kernels, I think? The support for domU went in separately to support for dom0, but both are present now. Talking of, I don't recall a patch to the README package list or to the CI containers, so I bet domU support is untested right now... ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Mar 24 16:57:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 16:57:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101123.193180 (Exim 4.92) (envelope-from ) id 1lP6os-0002mO-46; Wed, 24 Mar 2021 16:57:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101123.193180; Wed, 24 Mar 2021 16:57:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6os-0002mH-16; Wed, 24 Mar 2021 16:57:22 +0000 Received: by outflank-mailman (input) for mailman id 101123; Wed, 24 Mar 2021 16:57:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6oq-0002mC-Jg for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 16:57:20 +0000 Received: from mga12.intel.com (unknown [192.55.52.136]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4406143f-128b-430e-bab2-55b5dc8b9dc3; Wed, 24 Mar 2021 16:57:17 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 09:57:16 -0700 Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 09:57:15 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lP6oi-00FkMQ-KG; Wed, 24 Mar 2021 18:57:12 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4406143f-128b-430e-bab2-55b5dc8b9dc3 IronPort-SDR: OdRKHOYoz3d3rDGX1Fim9ZfMg9EeG5Dz6Xi6VBfsoRSWoLn3ZshDD30h1UikM7mJIqOzowEbrE 9UnKITulCQtg== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="170093428" X-IronPort-AV: E=Sophos;i="5.81,275,1610438400"; d="scan'208";a="170093428" IronPort-SDR: QKHVSokjMFkLoV94H026lGKVi1Fl0S26xj/UiQdOE2PzfOoA4B0gBo9rxridMTsB28m0wXFHZm i4mYWeorV4kw== X-IronPort-AV: E=Sophos;i="5.81,275,1610438400"; d="scan'208";a="442319110" Date: Wed, 24 Mar 2021 18:57:12 +0200 From: Andy Shevchenko To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Mika Westerberg , Linus Walleij , linux-gpio@vger.kernel.org Subject: Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region Message-ID: References: <20210324123118.58865-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Mar 24, 2021 at 04:13:59PM +0100, Roger Pau Monn wrote: > On Wed, Mar 24, 2021 at 04:22:44PM +0200, Andy Shevchenko wrote: > > On Wed, Mar 24, 2021 at 02:55:15PM +0100, Roger Pau Monn wrote: > > > On Wed, Mar 24, 2021 at 02:58:07PM +0200, Andy Shevchenko wrote: > > > > On Wed, Mar 24, 2021 at 01:31:18PM +0100, Roger Pau Monne wrote: > > > > Moreover, it seems you are bailing out and basically denying driver to load. > > > > This does look that capability is simply the first register that blows the setup. > > > > I think you have to fix something into Xen to avoid loading these drivers or > > > > check with something like pci_device_is_present() approach. > > > > > > Is there a backing PCI device BAR for those MMIO regions that the > > > pinctrl driver is trying to access? AFAICT those regions are only > > > reported in the ACPI DSDT table on the _CRS method of the object (at > > > least on my system). > > > > Unfortunately it does not expose PCI configuration space. > > Are those regions supposed to be marked as reserved in the memory map, > or that's left to the discretion of the hardware vendor? I didn't get. The OS doesn't see them and an internal backbone simply drops any IO access to that region. > > > Doing something like pci_device_is_present would require a register > > > that we know will never return ~0 unless the device is not present. As > > > said above, maybe we could use REVID to that end? > > > > Yes, that's good, see above. > > > > WRT capabilities, if we crash we will see the report immediately on the > > hardware which has such an issue. (It's quite unlikely we will ever have one, > > that's why I consider it's not critical) > > I would rather prefer to not crash, because I think the kernel should > only resort to crashing when there's no alternative, and here it's > perfectly fine to just print an error message and don't load the > driver. Are we speaking about real hardware that has an issue? I eagerly want to know what is that beast. > IMO I would rather boot without pinctrl than get a panic if > it turns out pinctrl capabilities list is somehow corrupted. Again, do you have a hardware that does this? > It's a > long shot, but the check added in order to prevent this scenario is > minimal. > In any case I will send a new version with the REVID check and this > current patch. Okay, let's continue there, but I'm pessimistic about accepting this patch. -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Wed Mar 24 17:01:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 17:01:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101126.193193 (Exim 4.92) (envelope-from ) id 1lP6sq-0003qZ-Ll; Wed, 24 Mar 2021 17:01:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101126.193193; Wed, 24 Mar 2021 17:01:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6sq-0003qS-IB; Wed, 24 Mar 2021 17:01:28 +0000 Received: by outflank-mailman (input) for mailman id 101126; Wed, 24 Mar 2021 17:01:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6sp-0003qN-AL for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 17:01:27 +0000 Received: from mga07.intel.com (unknown [134.134.136.100]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3e150299-78f0-4e67-9cc8-4fc86a8b106a; Wed, 24 Mar 2021 17:01:25 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 10:01:23 -0700 Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 10:01:21 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lP6sg-00FkPI-Q7; Wed, 24 Mar 2021 19:01:18 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e150299-78f0-4e67-9cc8-4fc86a8b106a IronPort-SDR: Oqvc8fhRgYZUdULYs2l02oN6aa6f9Q4yV3/sTgCy3TfEcTkN8uCWcSxAdK/82gFErvro2dldGO ZEVrj9oGXKAA== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="254740612" X-IronPort-AV: E=Sophos;i="5.81,275,1610438400"; d="scan'208";a="254740612" IronPort-SDR: XQJvaVJDJLanABcFoLCrP6nuFfR3RkzdfB4eAQ2LOIAMNxO8Su8pduY5YDmdjv1hRKJXndE44j dJugPKiNHHjA== X-IronPort-AV: E=Sophos;i="5.81,275,1610438400"; d="scan'208";a="442320806" Date: Wed, 24 Mar 2021 19:01:18 +0200 From: Andy Shevchenko To: Roger Pau Monne Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Andy Shevchenko , Mika Westerberg , Linus Walleij , linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 1/2] intel/pinctrl: check REVID register value for device presence Message-ID: References: <20210324154312.61878-1-roger.pau@citrix.com> <20210324154312.61878-2-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210324154312.61878-2-roger.pau@citrix.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Mar 24, 2021 at 04:43:11PM +0100, Roger Pau Monne wrote: Thanks for a fix! My comments below. > Use the value read from the REVID register in order to check for the > presence of the device. A read of all ones is treated as if the device > is not present, and hence probing is ended. > > This fixes an issue when running as a Xen PVH dom0, where the ACPI > DSDT table is provided unmodified to dom0 and hence contains the > pinctrl devices, but the MMIO region(s) containing the device > registers might not be mapped in the guest physical memory map if such > region(s) are not exposed on a PCI device BAR or marked as reserved in > the host memory map. Any particular point that we can use in the Fixes tag? ... > Suggested-by: Andy Shevchenko Hmm... was it that address I have used? In any case I think my @linux.intel.com is better. ... > /* Determine community features based on the revision */ > value = readl(regs + REVID); > + if (value == ~0u) > + return -ENODATA; I think -ENODEV is more appropriate here. Also comment above should be adjusted to explain this check. -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Wed Mar 24 17:02:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 17:02:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101129.193205 (Exim 4.92) (envelope-from ) id 1lP6u4-0003x2-0K; Wed, 24 Mar 2021 17:02:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101129.193205; Wed, 24 Mar 2021 17:02:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6u3-0003wv-TC; Wed, 24 Mar 2021 17:02:43 +0000 Received: by outflank-mailman (input) for mailman id 101129; Wed, 24 Mar 2021 17:02:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP6u2-0003wq-0T for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 17:02:42 +0000 Received: from mga09.intel.com (unknown [134.134.136.24]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c99ac4a5-1887-4f0e-84c8-ea83b25122e9; Wed, 24 Mar 2021 17:02:39 +0000 (UTC) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 10:02:32 -0700 Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 10:02:30 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lP6tn-00FkQL-KI; Wed, 24 Mar 2021 19:02:27 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c99ac4a5-1887-4f0e-84c8-ea83b25122e9 IronPort-SDR: PdsMzB4mzZncKeUjL/hyT203UC1JlvtCuiPaZdgfMP//zhWY6bESmiZ2WWBWgI0Sxmm9QGxUi0 HooHjqKM+vrg== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="190842121" X-IronPort-AV: E=Sophos;i="5.81,275,1610438400"; d="scan'208";a="190842121" IronPort-SDR: rJzS+iHtOGfIZpvOLfsXL6NzmraXGkrb1W962iko8Ym8KaXs9zZRzUjBo7mY3wfQULMhr9JHAe OPIWchmumWTg== X-IronPort-AV: E=Sophos;i="5.81,275,1610438400"; d="scan'208";a="525308568" Date: Wed, 24 Mar 2021 19:02:27 +0200 From: Andy Shevchenko To: Roger Pau Monne Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Mika Westerberg , Andy Shevchenko , Linus Walleij , linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 2/2] intel/pinctrl: check capability offset is between MMIO region Message-ID: References: <20210324154312.61878-1-roger.pau@citrix.com> <20210324154312.61878-3-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210324154312.61878-3-roger.pau@citrix.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Mar 24, 2021 at 04:43:12PM +0100, Roger Pau Monne wrote: > When parsing the capability list make sure the offset is between the > MMIO region mapped in 'regs', or else the kernel hits a page fault. > > Adding the check is harmless, and prevents buggy or broken systems > from crashing the kernel if the capability linked list is somehow > broken. I don't think we need a dead code in the kernel. If you have a hardware to show this issue, I eagerly want to know this! -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Wed Mar 24 17:11:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 17:11:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101135.193217 (Exim 4.92) (envelope-from ) id 1lP720-00053C-V3; Wed, 24 Mar 2021 17:10:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101135.193217; Wed, 24 Mar 2021 17:10:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP720-000535-Rm; Wed, 24 Mar 2021 17:10:56 +0000 Received: by outflank-mailman (input) for mailman id 101135; Wed, 24 Mar 2021 17:10:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP720-000530-BD for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 17:10:56 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 454b9ed6-1c1e-4cec-a6d6-6c599d51e135; Wed, 24 Mar 2021 17:10:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 454b9ed6-1c1e-4cec-a6d6-6c599d51e135 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616605854; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=w44HnX+G1THL+iAa42D2itHwpThflFk7bbehM9bSjPc=; b=eIEm1hubGIOS6jlaisiUMEIKlUi0EdW7tswGmZEi+PtXobvbVTrDC4sq S5h9JxYHNysflGFCFhEL4e8oWnjBXjbw4MPiHK511hK10dyslqpJiUDuI Gjz0Tye0zF1zq+MlAi2D9GbdE/ZOQkJOb8GVYHgvkoZHGfmTuM0wL/aaZ w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: E+JpRmQFokoCPQesJCpCq8gYaJeyyOcHTkheDJHMlphPcaq/oT2hafI0/wCQ09NFMzPFE2kbZ9 uhfVaWaTKZdYgeNvTV6zLivOAKUWRvipMtKU4iU6HvKCxsQZSDBrdA1icKPJyfpHIK/rTuRTFx ZFLqMuD24Vz3EF336rrO6xCpAdnzQJf3GSCnMk9PshTwIGDtbwCk6m4t6fQtHwUfbuUXlLxYaC Z6Em+/WCGqdLH/UnHnzBjRwBK88TJYzScd56JSDDJJCJ+DJ2+ljv6poXoq6ibtketlketaF4Pa TDA= X-SBRS: 5.2 X-MesageID: 40048640 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:dpvOF6t6EKdjuanuYzG34dOg7skCC4cji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOj7U5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qz6Y 5JSII7MtH5CDFB4frSyAOzH888hPyO9661jenTpk0dMT1CQYsI1XYcNi+wFEpqSA5aQboVfa Dsp/ZvjTymZHgRc4CfDn4KQ+DMq7Tw5e3bSDQBAAMq7xTLsCih76T0HwPd8hAVVT5OxrlKyx mEryXS4KK/v/anjiLNzmO71eUZpPLN6PtmQPaNhM8cNyn2hm+TBbhJdrWesFkO0ZmSwXkwlt 2kmWZDA+1S7DfrcnixsV/R3WDboUsTwlvD7XPdvnf5u8z+Q1sBeol8rKZUaAHQ5UZlnPwU6t Mx40uju5BaDQzNkU3GjrCiPXwL5ymJiEEvnuIJg3tUXZF2Us4qkaUl8F5IC5BFJSrm6ekcYb RTJfvB7/Vbe07yVQG/gkBTwcehVnl2PhCKTllqgL3t7xFqnWt0x0Zd+coHnn1ozuNad7B44Y 3/Q8FVvYALavVTQbN2Be8HT8fyIHfKWwjwPGWbJkmiPL0bOlrWwqSHookd1aWPQtgl3ZEykJ POXBdzrmgpYX/jDsWIwdli7g3NemOgRj7go/suoqRRi/nZfv7GICeDQFchn4+LuPMEGPDWXP 61JdZwD+L8K3DtXaJExRf3VZUXCXR2arxQhv8LH3a15u7bIIzjseLWNNzJIqD2LDoiUmTjRn QZWjz+I9hB81CrVnf0jAO5YQKqRmXPubZLVITK9ekaz4YAcqdWtBIOtFi/7saXbT1O25ZGJX dWEffCqOeWtGO29WHH4yFCIRxGFHtY573mTjdPrQ8OOEXkbKYbt7ykCDhv9UrCAiU6Y9LdEQ ZZqVgy07mwNYasyScrDM/iNHmbgXsVrHeDVIwdhaWH+MfgdvoDf9EbcZ00MT+OOw1+mA5spm sGQhQDXFXjGjTnjrjgkIYZH/jFd953gB6iJMldrX63jzTGmegfAl8gGxK+W8+ehggjAwdOjl pq6qkFnf6rgjC0M1Yyh+w+LXxBYGmaG6h9EQyAfYlY84qbIj1YfCOvv3i6gwt2Unf2/08S71 aRUxG8SLXuOB5hnVx2lozt60h5c22BeVkYUAEKjaRNUULcunhy1ueXYLGUyGX5UCpf/sgULC zFbTwOIgln2tCw01qPlCyfEGg9r69eTdD1HfAtdare1WiqL5DNnaYaH+VM9JIgL9z2tPQXON jvNzO9PXf9A+Mt1xf9nAdUBABk7H0lm+jvwhvr8Syx22M+G+PbJD1dNvsmCsDZ62jvXPCT1p plydozoOurK230LtqL07veYTIGKhTdpweNPqwVgIERuaI5r71oGZbHFTPOyXFcxR07aN7ui1 l2etUz3JnRfot0O8ACcSNQ+VQk0NyJMUswqwTzRuszZ0skgXPXN86AioC45oYHEwmEvk/9KF Of+ypS87PeUyyP2aUTBqgwLW5VAXJMo0hK7aeHbcndGQ+qf+ZM8B6mKXe7aqZaU7XAFrMKrB p2iuv46dO/Zm79wkTXsjR6KK4VrDriTsO2HQ6WGelHt9a9Ik+Bh6O24Mi1yDf7IAHLH3gwlM lAbwgXaM8GlzwpyIsw2SK2Qrbsok0kn0BFiAsX3mLFy8yj+iPDAUpCMQfFmZ1YUjlYL2iQga 3+gJ2l/WW45CIAxILKG0hRdMxfAtQcToD4KCF1NMgb1YTYiJYHk2BEexchD2k1lTD70adnxN 6CqYfvZ9E= X-IronPort-AV: E=Sophos;i="5.81,275,1610427600"; d="scan'208";a="40048640" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JcDUiCA72z6n4G2lldtDXQPDkF1cC3IT8o2DKEPITud0lYRtrhIPut5EOrU5VPUfz7IjOF3povm4M1LqNFJSoAMPe9N6dUkv3f5nmWJsYD7x5q4Lr0eVKd/mPxbrMTa6sn6Y7jKgNq/ZGmWgVLZAm39yfiYsn1YAJRpdmbkKGotfXV++UqYZJfXK3E+KxHPpbqVSaxfDh3o9BuNjfxvbRKWpAHw02JIgQ1GsUEZVmJRTl5GFzvmN0GMQWhKzU5wFmG1i2QGgAjVqPmjhhCN1cy2jXWPQp3ZeDlnyvSi0uftkPyCBDTe1tN7lrpY4ABX57uLdG1t0aEMjKCXEGkCIUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w44HnX+G1THL+iAa42D2itHwpThflFk7bbehM9bSjPc=; b=mXAd/qm8+gZwGLAfueqtv7CUeqhFC8tR0E+Rg+XEN37ACgP7UyWaTs5V+YUKF1WiHwPsWldnuIMMZpdHfid+3kKjac0byiLN3Z7esvuMg72S0yq6yPQgdFsFTg4US9qOksJcvEN2wcZlANjp6mqx9OaOWSldQT3X7ffiLpzVyFTi76Fo0aONoekaNiePrBBCzZCoLrhjrW2fSNLxIgsEvvPgjK2w+LIAnbdrBbzw5wsNuT8OoY2okM+kH5k+NyY5iU1GM3fmX9ERm63BSxhFijEySkaCLdTIBWJC/Hjdmyh9xPtluji5eGAVrhRADbjkSqMLAWnJGqfqEuT36GhyGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w44HnX+G1THL+iAa42D2itHwpThflFk7bbehM9bSjPc=; b=WdAgn7KnDQmT1WNRORTr024ozhevDWkq+py4ed+uQMlcgrvcRiPJEjGfpAmoXvFVDhh2cQkdsiHZUklv8Enl3I+lojPGBY0nrKKeSjndR+IRQwrHNl13WGOPOjUhFCvrAK5XmfWeqhimR+6nIveMp5N0Y4hlxegs1OzV2Iu3f7E= From: George Dunlap To: Andrew Cooper CC: xen-devel , Jan Beulich , Ian Jackson Subject: Re: [PATCH 3/6] CHANGELOG.md: Add dom0 zstd compression support Thread-Topic: [PATCH 3/6] CHANGELOG.md: Add dom0 zstd compression support Thread-Index: AQHXIMzuHmhvVTmYrUinzd81rw5tAaqTW6OAgAAD8AA= Date: Wed, 24 Mar 2021 17:10:29 +0000 Message-ID: References: <20210324164407.302062-1-george.dunlap@citrix.com> <20210324164407.302062-3-george.dunlap@citrix.com> <1b2710e7-6491-2000-c4b3-e29e8ab5ffd2@citrix.com> In-Reply-To: <1b2710e7-6491-2000-c4b3-e29e8ab5ffd2@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d18d8700-4277-426d-4fd5-08d8eee7b9fd x-ms-traffictypediagnostic: PH0PR03MB5944: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gM2Xwn/ctGXt8DyjtMl09Rjsa0+klgfXErAhz0/Jj/ErPWEgpiogMp+qbfgSHhr4j/HTf5ZqxQ1Doa/HIQdFghlPpubm/wdfA0h09UGSApUFORC8HLfpyzJIDP9pzQBsdRqvomoQJG/7uLnnIs677Yx5g5Dr2DHaNostRuXNZ/WhL2zG3Pc/OrHrsiS/3OGgkiYwaiKaRURvXdOfartVNNtR0H9IfgZ+njwxeneyd1Fh9NtVou8lvPWJGfVEdKZvkucP1seMBtDtrCOAqGcf/MSpFmjLzAvIzABHAgGGScC7GygLxu0Bkf4EyPh47pVpF3PryCR37YpCZ8ueYxgdAtZ3Zpe/yhLyfBTVmtKbXAX5Is2/Pa1kkJchsL+EWX6SokX+wM0q7rX5SN7rhcLNXWQILJ1Wnn4RYR4FjmH14BBjEbuH4goZNhnGZbNfqy8ggBNJJTZuRrvfCY6lhpz19jv0wRJ4+96b9rfsDY9WzewA6Q74vxIykCiUbgbrR5nPCFGX9zbWHGK3+vSq/LmSORZqsrJ7i1tf2hHOqqbI9WoYjOn7b+mD8+TBVVgyRpX0h46fq8rCelkfkAOFUv7tfLRkoXxTRXWTQ0M7Ekgy3Jos/IpNu6ySSTIVLb9oZZqHYzv07le8RTCUq5yS4kfJReYJlQmlW8A995yfxZDLvGfD4AOVn/q0e/OhPadH1SQBkKflvVW3XXS4MCXHtc9KfnnkBtcx4INBAONUsxZedjCjbPXhXtvDmpbvzU83Vj3LN33AEHQldgmo/Hn2dDUt5KGU1DjjedrD2Y/zk3vA2/WXTkvbp2o8JKjgO7cU4/VP x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(39860400002)(376002)(136003)(396003)(64756008)(26005)(316002)(478600001)(6636002)(66556008)(91956017)(5660300002)(186003)(8936002)(2616005)(66476007)(76116006)(6512007)(2906002)(66446008)(66946007)(107886003)(86362001)(6862004)(33656002)(4326008)(6506007)(6486002)(36756003)(71200400001)(8676002)(38100700001)(54906003)(37006003)(53546011)(207903002)(219803003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?ejZOQ3cwZDZHdm1YWDVPY0sxOUIvZzNJQi9qRmgyUmRaV0t4ZldTRHhsS1NM?= =?utf-8?B?U0FMSkI3S0VWWUJZVjVCbytLVzVRTnpmdksvUzJ0VFdNWHFNcG0yYURLQ2sr?= =?utf-8?B?c2tuS0NjVjBmaFErMWNCWFdSK25EYnNYelFnUDVoM2V0UHZxQS9sS1NtWExI?= =?utf-8?B?Vkd3aVpScG94WGV5R2djSzFqeFkwRytBeURuZUpjL0F2Q21xcWRnd0VFWGdO?= =?utf-8?B?b25FZW9oTE9mT0c0U3RPY296dVRJVysvaEU0ZjRuVWtkRVNDaUl2NlE3Um9J?= =?utf-8?B?MTZOTjRiako0Wmt0emJjQUNjN3JMQlR0eGl3RUxmSGNnUkRNMzVmd2JySGpx?= =?utf-8?B?QlhaaUlOM3BpQWFqeGwyVXlHWlNFYWh4SlBNNTBVT1lpSVJqclN2dWgzbngz?= =?utf-8?B?MlNsM1Y4TVhlRXh4S2dpNGpQdWM5RGlvd2JUZkFtbWJsN3AwcXNXV2tEM0pD?= =?utf-8?B?dGJkRzBiQ2ViZW1GYU9BZnBXeEZmdzZnVjE5K0dWUytCYXh0a2UwUHdLRHdU?= =?utf-8?B?eStGc2lvQ1lEUDFNL2VZUDU3Uy9mcVhpZEFLOVdkN0d0akpIeXB6T0FQWkxl?= =?utf-8?B?Z0JaeDduc2RndWlHNlpKUElEeVZKTC9jeHZjSUdiZUpEeVljTHNnTVMxbUIx?= =?utf-8?B?czNnYk9hekxmcE1ZN2diSUNaSFlPbHJwdWxCS1dqeUNNcEYrS3hoNmVKdkhU?= =?utf-8?B?NHV0TzVzZFFiZVBHbmRvUWlOcGRPVzJmcEVnZi8xbXN4N09hRDJ0Ky9iUkhm?= =?utf-8?B?N05xUUxWKzNhUVlBQjgzd2xmcVp0RjRJdDdtSU5YZmtzVERmb0l4dkh6UEw5?= =?utf-8?B?WTFPZVJ2cWdtcGhaRXRibkt6cExSdDJPK2VuNmNKaXRWYWMxSUxLT0lPVmF1?= =?utf-8?B?WU4vTGUwbGxSaHV1WFo0aGxUU1MvY0k0UmtLSXNoR00zcURBcG9zS2lqOUtO?= =?utf-8?B?YjVZd2tBVG01SG5HTFd2bXZ2N3hJbFQ2ZDdUSkdDckhqTEcxaFNVVm01cHA5?= =?utf-8?B?cGQyTFM2Mk0vRjlUTWlWbHY2RlVUT0N5ek5sb3RNRWU5aWV5YVVZRnk1R2lP?= =?utf-8?B?NXlkQmVBK1l3L0c3VFloZyswV0c5R2lxS0ZuSnVoQS8rT1dQYnc0ZmRNUUlu?= =?utf-8?B?YXVobFRVVk5XYjlyaXg3R1FFaElDL3FtcHM0V3ZHZ1N3bGlXT1h1UDVlZys4?= =?utf-8?B?RDJyR3hmdGs1SFFudnkwVGZtMkw2NkoyaVc4dEZrMmJzd2tSTHNlUktaUERF?= =?utf-8?B?UHFVNEIzRW1VTmRpcnAyT09qVkd1TVZzQ1orTW82Y1JBYzNNbnhKSlp6TkV3?= =?utf-8?B?ZExEblBWZ2ZqdVIyaS80a3kyMEF4eXRTTzNocmhURHpCV09saHJmRnBSNEhF?= =?utf-8?B?cHlFSkpqTzRxc0M0WHgweDZuSVR5blVQWFEvTktPVmdGbVBEUnB6RCs5M1RN?= =?utf-8?B?Rmg3ZEhPdG5hWWpIcGh4MW8vaDh1NFFnQjJPazFNc253Qm9QOXFFL2ZQQzZI?= =?utf-8?B?SFU5ZUk3a1YybHI3TzNoYnc2Z08rK25VbEE3NkVyRWdwSENlSFFaK2ZtMDVx?= =?utf-8?B?YSsvdFlQZmd6RFFLU2RiRmxmVXhVckFGUEJpTnhiVHNaa2dKc2ZMWVBUNUJV?= =?utf-8?B?Q1VVTWxaL0lURDFaS1FRb1lwR2RzNlBEKzUyTitub3hHcjZ1aWRJUUlHekFl?= =?utf-8?B?RFZqZVkvVVBWME1mOWhoVGFiU3lrN2FvdzVPMzhFTHcxSS9SVjREaWdqUm41?= =?utf-8?B?bi9SbC9LTTMwZjVROGZ0Q3ZpSTlyV2hWcnJkSnJOSlVlalZlTXExd0VTMmN5?= =?utf-8?B?OVRpNENiRXViUEtmeFZuUT09?= Content-Type: text/plain; charset="utf-8" Content-ID: <33CF0556AFF7614B9399FB7A4E4C7FE8@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d18d8700-4277-426d-4fd5-08d8eee7b9fd X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2021 17:10:29.6763 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: z5iGuFTt633EQ10ayYfNpCXK+8k6QPh5sPyFpF4+3wSZRBXv4qfrBx36AC0C6W40Cc8USRStOpNbXLYLoAg0u3wH9Rvoqa+DdQZ9RnxcjcU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5944 X-OriginatorOrg: citrix.com DQoNCj4gT24gTWFyIDI0LCAyMDIxLCBhdCA0OjU2IFBNLCBBbmRyZXcgQ29vcGVyIDxBbmRyZXcu Q29vcGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IE9uIDI0LzAzLzIwMjEgMTY6NDQsIEdl b3JnZSBEdW5sYXAgd3JvdGU6DQo+PiBTaWduZWQtb2ZmLWJ5OiBHZW9yZ2UgRHVubGFwIDxnZW9y Z2UuZHVubGFwQGNpdHJpeC5jb20+DQo+PiAtLS0NCj4+IENDOiBKYW4gQmV1bGljaCA8amJldWxp Y2hAc3VzZS5jb20+DQo+PiBDQzogSWFuIEphY2tzb24gPGlhbi5qYWNrc29uQGNpdHJpeC5jb20+ DQo+PiAtLS0NCj4+IENIQU5HRUxPRy5tZCB8IDEgKw0KPj4gMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspDQo+PiANCj4+IGRpZmYgLS1naXQgYS9DSEFOR0VMT0cubWQgYi9DSEFOR0VMT0cu bWQNCj4+IGluZGV4IDhjODkyMTJmMTQuLjM1NGYyMTNlODEgMTAwNjQ0DQo+PiAtLS0gYS9DSEFO R0VMT0cubWQNCj4+ICsrKyBiL0NIQU5HRUxPRy5tZA0KPj4gQEAgLTEyLDYgKzEyLDcgQEAgVGhl IGZvcm1hdCBpcyBiYXNlZCBvbiBbS2VlcCBhIENoYW5nZWxvZ10oaHR0cHM6Ly9rZWVwYWNoYW5n ZWxvZy5jb20vZW4vMS4wLjAvKQ0KPj4gIC0gQVJNIFNNTVV2MyAoVGVjaCBQcmV2aWV3KQ0KPj4g IC0gSW50ZWwgUHJvY2Vzc29yIFRyYWNlIHN1cHBvcnQgKFRlY2ggUHJldmlldykNCj4+ICAtIE5h bWVkIFBDSSBkZXZpY2VzIGZvciB4bC9saWJ4bA0KPj4gKyAtIFN1cHBvcnQgZm9yIHpzdGQtY29t cHJlc3NlZCBkb20wIGtlcm5lbHMNCj4gDQo+IEFsbCBrZXJuZWxzLCBJIHRoaW5rPw0KPiANCj4g VGhlIHN1cHBvcnQgZm9yIGRvbVUgd2VudCBpbiBzZXBhcmF0ZWx5IHRvIHN1cHBvcnQgZm9yIGRv bTAsIGJ1dCBib3RoDQo+IGFyZSBwcmVzZW50IG5vdy4NCg0KT2gsIGdvb2QuICBJIG9ubHkgaGFw cGVuZWQgdG8gc2VlIHRoZSBjb21taXQgdGhhdCBpbnRyb2R1Y2VkIGRvbTAgc3VwcG9ydC4NCg0K PiBUYWxraW5nIG9mLCBJIGRvbid0IHJlY2FsbCBhIHBhdGNoIHRvIHRoZSBSRUFETUUgcGFja2Fn ZSBsaXN0IG9yIHRvIHRoZQ0KPiBDSSBjb250YWluZXJzLCBzbyBJIGJldCBkb21VIHN1cHBvcnQg aXMgdW50ZXN0ZWQgcmlnaHQgbm934oCmDQoNCklmIHlvdSBjb3VsZCBzZW5kIGEgcGF0Y2gsIG9y IHByb2Qgc29tZW9uZSB0byBkbyBpdCwgdGhhdCB3b3VsZCBiZSBoZWxwZnVsLg0KDQogLUdlb3Jn ZQ0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Mar 24 17:26:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 17:26:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101139.193229 (Exim 4.92) (envelope-from ) id 1lP7H2-0006Bl-Aq; Wed, 24 Mar 2021 17:26:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101139.193229; Wed, 24 Mar 2021 17:26:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP7H2-0006Be-78; Wed, 24 Mar 2021 17:26:28 +0000 Received: by outflank-mailman (input) for mailman id 101139; Wed, 24 Mar 2021 17:26:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP7H1-0006BZ-2O for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 17:26:27 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9056c7fb-668a-4af9-a3fa-ed7c6ec7ad55; Wed, 24 Mar 2021 17:26:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9056c7fb-668a-4af9-a3fa-ed7c6ec7ad55 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616606786; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=dPLHjrsIcdVSICRqBVB8jslK5tUec3Pu0TVa6q4+SJs=; b=gXxx460c52GaU+649573Ty+xF9DOQ+AHg6fXqf1YhftUNTRqbNRVb6XU 7qM0w5UDOJH5Kx/g5OfZ7CQzT86IIFxFP72oqmRZMi6Uy502lYWm7bBZw 19ZKujkROty2RLjsLKKzjrd3tdmfadHqX7nQ/hGkB+Ul+ihX7qQr/ESHk E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: fCpAEyZgOB4i1AjeKnOHs3t945P3Hp22YadJSqZPoAw6U/ikHIDBHKmkf0MyHaqYchHU9Kauqk 90ccKBHgzdsgYwGmTY/hDwdKeeLQgk3yX0oO9VoaR9PcYnQKettwBuuh1xmc5ikRuyUGnRtZ8t Iv5b2r5X/+91+DptHAv750gNzYFrlPjhxum5GklOfLQBmv6ouhOVmn+y8crzzF9kUFVPneSDnO ChIV+xB1eV2SM5B8QHVYRbxroeuwqRx1bEeheaghqgojYyzDMH5h41gFvtm1Bc5/ENlFY2Hqk/ OVM= X-SBRS: 5.1 X-MesageID: 40050011 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:TM5ZpKNBWpIUl8BcTiWjsMiAIKoaSvp033AA/SlKJyB9WMqeis yogbAnzhfykjkcQzUNntqHNamGTxrnhPpIyKMWOqqvWxSjhXuwIOhZnO3f6hDpBiGWzI5g/I h6dawWMrHNJHxbqeq/3wWiCdYnx7C8gcWVrMPT1W1kQw0vS4wI1XYbNi+hHkd7RBZLCPMCff L2jKd6jgGtZGgNaYCDDmQFNtKzwOHjro7sYhINGncciTWmsDXA0tHHOind+h8fVj9VqI1Sk1 T4rw== X-IronPort-AV: E=Sophos;i="5.81,275,1610427600"; d="scan'208";a="40050011" From: George Dunlap To: CC: George Dunlap , Ian Jackson , Jan Beulich , Roger Pau Monne Subject: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code Date: Wed, 24 Mar 2021 17:26:08 +0000 Message-ID: <20210324172608.302316-1-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- Missed one from my list when creating the other series CC: Ian Jackson CC: Jan Beulich CC: Roger Pau Monne --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 15a22d6bde..49832ae017 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - x86_emulate: Expanded testing for several instruction classes - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 - CI loop: Add dom0less aarch64 smoke test + - Factored out HVM-specific shadow code, allowing PV shim to be slimmer ## Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 18:56:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 18:56:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101142.193241 (Exim 4.92) (envelope-from ) id 1lP8fL-0006nf-9u; Wed, 24 Mar 2021 18:55:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101142.193241; Wed, 24 Mar 2021 18:55:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP8fL-0006nY-6q; Wed, 24 Mar 2021 18:55:39 +0000 Received: by outflank-mailman (input) for mailman id 101142; Wed, 24 Mar 2021 18:55:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP8fK-0006nT-1p for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 18:55:38 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 40a2ba72-499d-430a-809a-a48a64d838a6; Wed, 24 Mar 2021 18:55:37 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id B5E8861A0A; Wed, 24 Mar 2021 18:55:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 40a2ba72-499d-430a-809a-a48a64d838a6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616612136; bh=39W/A/1MQN2qtx5XidDcwhzMqYmkDys9KGwGNqwlSLM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=dyOVzEDFOTG/8Rmm24H7HWnMKg7Hnvl/oPc0YO55xsLglGs7Rxm0pCXMlg8wXW5Mp Rl9SayRFv2Qu9u4paCNpJ8nQUV1zJwH55TtFyLY6gsulID3avz1k07SXQVrJakHrm3 qw9XT/YrtqBxeOpp9oGiZF5Ap4IH20w5U19fGmgt80j1jJu8/fWXekPNGLpSMEkz/g ePo77yCta25T3uMGNVfaKnSQnPrC9DaEQkmJFSY67X9d8DajUvUWMCI4/06PhzeWYy 85GFOYI+4Z5YlzqyYq7UoIni/Ni7khuzS6N0s3Cjccrs/fCCnFzpZ0AnDky3VpqCUp Z0nLWSBBHU86w== Date: Wed, 24 Mar 2021 11:55:34 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Bhaskar Chowdhury cc: sstabellini@kernel.org, linux@armlinux.org.uk, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, rdunlap@infradead.org, jgross@suse.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH] ARM: xen/mm.c: A mundane typo fix In-Reply-To: <20210324133036.17665-1-unixbhaskar@gmail.com> Message-ID: References: <20210324133036.17665-1-unixbhaskar@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote: > s/acrros/across/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Stefano Stabellini > --- > arch/arm/xen/mm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c > index 467fa225c3d0..be7c942c74bf 100644 > --- a/arch/arm/xen/mm.c > +++ b/arch/arm/xen/mm.c > @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev, > * - The Linux page refers to foreign memory > * - The device doesn't support coherent DMA request > * > - * The Linux page may be spanned acrros multiple Xen page, although > + * The Linux page may be spanned across multiple Xen page, although > * it's not possible to have a mix of local and foreign Xen page. > * Furthermore, range_straddles_page_boundary is already checking > * if buffer is physically contiguous in the host RAM. > -- > 2.30.1 > From xen-devel-bounces@lists.xenproject.org Wed Mar 24 18:57:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 18:57:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101145.193253 (Exim 4.92) (envelope-from ) id 1lP8go-0006u4-Lv; Wed, 24 Mar 2021 18:57:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101145.193253; Wed, 24 Mar 2021 18:57:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP8go-0006tx-IS; Wed, 24 Mar 2021 18:57:10 +0000 Received: by outflank-mailman (input) for mailman id 101145; Wed, 24 Mar 2021 18:57:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP8go-0006ts-8D for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 18:57:10 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ea92b105-a5eb-4a6e-9cc2-a7c26d8714b6; Wed, 24 Mar 2021 18:57:09 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id CBC5561A0A; Wed, 24 Mar 2021 18:57:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea92b105-a5eb-4a6e-9cc2-a7c26d8714b6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616612229; bh=oxi7KhqA+5LwKJUqAnw0YhZzT2kqbxuT0l6F33/JQOQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=LbzqYW1i/G0ckG0lbcouUeQotXxzs10BH2rNtp+n/fO61uJAXoEe5huO+mcHIzwGu Mjb9CVs1vCOXzXF0tPhFMlpElGqLYW3eMqv/BvqZPy0/FSYKWn5UX+IDMe8Iv+wiCC ejPGjLGQmze7iySUbcKD/C7yK3wAlLZt/WW0ygaskrzyXlr32L7Sk4KL1JDj7a1d1h Za513CcyKSKomZCa+7nmQ0gzz83hrgIRPJe66TQAAo0V5JbYX4LQKxQ2gibT4vtgD0 AR6Y32ks4/qm+p/oV+j1aXSsS6VXWm/86GAiEeXT4xrOSf87CtxRzDGcjt+xhAylu3 mGoPaMIKCFykg== Date: Wed, 24 Mar 2021 11:57:08 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: George Dunlap cc: xen-devel@lists.xenproject.org, Wei Liu , Andrew Cooper , Stefano Stabellini , Doug Goldstein Subject: Re: [PATCH 6/6] CHANGELOG.md: Add entries for CI loop In-Reply-To: <20210324164407.302062-6-george.dunlap@citrix.com> Message-ID: References: <20210324164407.302062-1-george.dunlap@citrix.com> <20210324164407.302062-6-george.dunlap@citrix.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 24 Mar 2021, George Dunlap wrote: > Signed-off-by: George Dunlap > --- > CC: Wei Liu > CC: Andrew Cooper > CC: Stefano Stabellini > CC: Doug Goldstein > --- > CHANGELOG.md | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index df6c638152..15a22d6bde 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -16,6 +16,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - Library improvements from NetBSD ports upstreamed > - x86_emulate: Support AVX-VNNI instructions > - x86_emulate: Expanded testing for several instruction classes > + - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 > + - CI loop: Add dom0less aarch64 smoke test We also have a full Dom0+DomU test on ARM using xl to create the guest, see automation/scripts/qemu-alpine-arm64.sh From xen-devel-bounces@lists.xenproject.org Wed Mar 24 18:59:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 18:59:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101148.193265 (Exim 4.92) (envelope-from ) id 1lP8j7-0007E3-39; Wed, 24 Mar 2021 18:59:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101148.193265; Wed, 24 Mar 2021 18:59:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP8j6-0007Dw-Vm; Wed, 24 Mar 2021 18:59:32 +0000 Received: by outflank-mailman (input) for mailman id 101148; Wed, 24 Mar 2021 18:59:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP8j5-0007Dq-RY for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 18:59:32 +0000 Received: from desiato.infradead.org (unknown [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8627bbaa-d657-4441-852b-724eb93c4860; Wed, 24 Mar 2021 18:59:28 +0000 (UTC) Received: from [2601:1c0:6280:3f0::3ba4] by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lP8iv-0005bz-W7; Wed, 24 Mar 2021 18:59:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8627bbaa-d657-4441-852b-724eb93c4860 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject: Sender:Reply-To:Content-ID:Content-Description; bh=S5c08tH94DbYnQq7ubCip4+4vB1dGbmIUGgd0vL4esY=; b=oqZZIo5N0eBy6O8OrtRF/DBDva Dumskv2fuiudyaQYnfIUyXCfX3m6uEo7wgpTan3zTZG5PO8boMSelZzFH9ZY7Ai7Nc7rQ/Yh+KJiL 8EseYgIWFqIMKKzmtjI0BKV21t5t+cudxABVee1F0hZ6RPPxum8MhOZiD8pP35Svz7BWeaLlhoGqP f/1qJ8MS2RtDwjDl/7Qbex8WQawEwDwAXPtxhoZ0ze7yqIFVsEBC/VNOuwViKs3WlJL75mWD6NfIY cb7jkAwpwBBArKJW4gpvh9C0joyVTKTZp+yBwu5VNcgvqDpEQ9mJQP92lyCJVp8V1QRZQBbGH9xjf d1vGh48Q==; Subject: Re: [PATCH] ARM: xen/mm.c: A mundane typo fix To: Stefano Stabellini , Bhaskar Chowdhury Cc: linux@armlinux.org.uk, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jgross@suse.com, boris.ostrovsky@oracle.com References: <20210324133036.17665-1-unixbhaskar@gmail.com> From: Randy Dunlap Message-ID: <5e1b573a-6dc7-7f28-28ae-c509e6782fbf@infradead.org> Date: Wed, 24 Mar 2021 11:59:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/24/21 11:55 AM, Stefano Stabellini wrote: > On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote: >> s/acrros/across/ >> >> Signed-off-by: Bhaskar Chowdhury > > Reviewed-by: Stefano Stabellini > > Hi, It seems to me like some of those "page" should be "pages". >> --- >> arch/arm/xen/mm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c >> index 467fa225c3d0..be7c942c74bf 100644 >> --- a/arch/arm/xen/mm.c >> +++ b/arch/arm/xen/mm.c >> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev, >> * - The Linux page refers to foreign memory >> * - The device doesn't support coherent DMA request >> * >> - * The Linux page may be spanned acrros multiple Xen page, although>> + * The Linux page may be spanned across multiple Xen page, although pages, >> * it's not possible to have a mix of local and foreign Xen page. pages. >> * Furthermore, range_straddles_page_boundary is already checking >> * if buffer is physically contiguous in the host RAM. >> -- -- ~Randy From xen-devel-bounces@lists.xenproject.org Wed Mar 24 19:10:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 19:10:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101153.193277 (Exim 4.92) (envelope-from ) id 1lP8to-0000cY-4m; Wed, 24 Mar 2021 19:10:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101153.193277; Wed, 24 Mar 2021 19:10:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP8to-0000cR-0Y; Wed, 24 Mar 2021 19:10:36 +0000 Received: by outflank-mailman (input) for mailman id 101153; Wed, 24 Mar 2021 19:10:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP8tm-0000cM-R6 for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 19:10:34 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ff786bb9-3224-49e8-9c50-a7378defb61b; Wed, 24 Mar 2021 19:10:34 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 5AA8F61A02; Wed, 24 Mar 2021 19:10:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff786bb9-3224-49e8-9c50-a7378defb61b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616613033; bh=UONJN0cilkIBDoBEFZiaM2uw0/0sCmD3z6DW/Qhnu40=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=okW+RlTRrjTB4Vw7gTb8u5J0y4W53BVg4M5enk0Fi6wko5qwz2gA3OMcjCHU75K20 p8KzdoZXdEWbj5QQ0WGrmuZsbRuPXPn7AEnb82F0RMfKVSzHD1uDp4nh1WlV0xsX6n tVKRpYU2M8iCxuF5Chc7aGKVRbVqFAkcZgNQT3YfaYyUX6DyyGOdV3FwwSsj4yG4UJ LV4vBqlvxHzzOtoxXPEgR22Bg25sutubSdXgNHgwhat4Q8siIYAjbmLzcE8RKwGK95 YRgUHu3fe0VgqaDo3y78GhiqsDjeBGHRexJcDH5RbrBZoZDkg3aq5T3LMpGwJ3GyAM sPEwz+ZK2seMA== Date: Wed, 24 Mar 2021 12:10:31 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Christopher Clark cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , "Daniel P. Smith" , xen-devel , Andrew Cooper , Stefano Stabellini , Julien Grall , Julien Grall , iwj@xenproject.org, Wei Liu , George Dunlap , Jan Beulich , Rich Persaud , Bertrand Marquis , luca.fancellu@arm.com, paul@xen.org, Adam Schwalm Subject: Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document In-Reply-To: Message-ID: References: <20210316031814.10311-1-dpsmith@apertussolutions.com> <20210316031814.10311-2-dpsmith@apertussolutions.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 24 Mar 2021, Christopher Clark wrote: > > > > I'm also not sure how you are going to handle things like SR-IOV > > > > devices. Right now SR-IOV capability is setup and initialized by the > > > > hardware domain, and the new virtual devices are notified to Xen once > > > > setup is done. Do you plan to move those bits into Xen, so that it can > > > > setup and initialize the SR-IOV capability? > > > > > > While you could do it with the vPCI, as you point out this will not work > > > for SR-IOV. With hyperlaunch, these cases will require the use of a boot > > > domain, which is for all intents and purposes, a lightweight/restricted > > > toolstack domain. > > > > > > The boot domain will have to do the necessary operations to ensure that > > > when startup is finished, PCI passthrough will be successfully setup. > > > Note, this may have to include the boot domain unpausing the hardware > > > domain to help complete the setup before the boot domain can exit and > > > allow the remaining domains to come online. > > > > OK, I was expecting hyperlaunch to do all domain creation in the > > hypervisor. > > That is my expectation too. It is what we've been planning for in our > work so far but we can work on explaining the steps involved in > constructing the domains more clearly. > > > If you offload domain creation of guests with > > pci-passthrough devices to a control domain and/or hardware domain, > > I'm not sure I see the difference from normal domain creation, ie: > > it's no longer something specific to hyperlaunch, as I could achieve > > the same by using the existing xendomains init script. > > So that's not what we've proposed, and hopefully not what we'll need to do. > > Do you know if there is a need to perform work to support the > assignment of PCI devices at the point of domain creation (ie. in > domain_create), rather than handling it in a later step of domain > configuration, prior to the domain being started? Let's leave SR-IOV aside for a moment that can be a bit strange (if I recall correctly sometimes VFs can only appear after the PF driver has been loaded). Just for my understanding, for regular PCI passthrough, why is it important that the device assignment is done later by the control domain, instead of straight away at domain creation by Xen? I am fine either way but I meant to ask if it is just to make the implementation easier or if there is some kind of policy involved. From xen-devel-bounces@lists.xenproject.org Wed Mar 24 19:11:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 19:11:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101159.193289 (Exim 4.92) (envelope-from ) id 1lP8un-0000ju-Iw; Wed, 24 Mar 2021 19:11:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101159.193289; Wed, 24 Mar 2021 19:11:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP8un-0000jl-Ex; Wed, 24 Mar 2021 19:11:37 +0000 Received: by outflank-mailman (input) for mailman id 101159; Wed, 24 Mar 2021 19:11:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP8ul-0000jf-Ka for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 19:11:35 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a34c8095-e3f6-4e24-9462-ec5297360779; Wed, 24 Mar 2021 19:11:35 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D565361A17; Wed, 24 Mar 2021 19:11:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a34c8095-e3f6-4e24-9462-ec5297360779 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616613094; bh=dgMYdzjGstqyJTgn4iNkiVn6WwtSS/vzrce0N9MVCIA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=s+1KonQi/HxRdY9BH380c5qSw+4yfBNi00WS9WVl7W7UiS7MOoOTSs8RGFPY1u+1L CX+JKmVGywbw/xrL21gfKU5DxdEA1TBXH8XEs/1GixAIegYlu4zjKerqesGyCkqv08 7L+hbVE8fh2M0bqqKPStJLIvUjyGVRl1rXVvDL4g6mChkVMZjjd/6GqLd9UZR9om+v T7pcMgDj4BZq32cBvO202aLGa4UXzHstcauJdcX0t2BHQv5dtUf3giZpsszunKbwDS 9KO9UMlhfjhI/0boT2b5qzgdFOXibilxQXnAGYuWcO/e5SE/oUEeiZOucOXqGO+YmP hcFq52bXLQ8qg== Date: Wed, 24 Mar 2021 12:11:33 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Randy Dunlap cc: Stefano Stabellini , Bhaskar Chowdhury , linux@armlinux.org.uk, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jgross@suse.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH] ARM: xen/mm.c: A mundane typo fix In-Reply-To: <5e1b573a-6dc7-7f28-28ae-c509e6782fbf@infradead.org> Message-ID: References: <20210324133036.17665-1-unixbhaskar@gmail.com> <5e1b573a-6dc7-7f28-28ae-c509e6782fbf@infradead.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 24 Mar 2021, Randy Dunlap wrote: > On 3/24/21 11:55 AM, Stefano Stabellini wrote: > > On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote: > >> s/acrros/across/ > >> > >> Signed-off-by: Bhaskar Chowdhury > > > > Reviewed-by: Stefano Stabellini > > > > > > Hi, > It seems to me like some of those "page" should be "pages". Yes, good point actually > >> --- > >> arch/arm/xen/mm.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c > >> index 467fa225c3d0..be7c942c74bf 100644 > >> --- a/arch/arm/xen/mm.c > >> +++ b/arch/arm/xen/mm.c > >> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev, > >> * - The Linux page refers to foreign memory > >> * - The device doesn't support coherent DMA request > >> * > >> - * The Linux page may be spanned acrros multiple Xen page, although>> + * The Linux page may be spanned across multiple Xen page, although > > pages, > > >> * it's not possible to have a mix of local and foreign Xen page. > > pages. yes to both > >> * Furthermore, range_straddles_page_boundary is already checking > >> * if buffer is physically contiguous in the host RAM. > >> -- > > > -- > ~Randy > From xen-devel-bounces@lists.xenproject.org Wed Mar 24 19:54:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 19:54:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101163.193301 (Exim 4.92) (envelope-from ) id 1lP9Zd-0004o3-OX; Wed, 24 Mar 2021 19:53:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101163.193301; Wed, 24 Mar 2021 19:53:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP9Zd-0004nw-LK; Wed, 24 Mar 2021 19:53:49 +0000 Received: by outflank-mailman (input) for mailman id 101163; Wed, 24 Mar 2021 19:53:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP9Zc-0004no-Ar; Wed, 24 Mar 2021 19:53:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP9Zb-0000JQ-St; Wed, 24 Mar 2021 19:53:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP9Zb-0007xn-HJ; Wed, 24 Mar 2021 19:53:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lP9Zb-0001jp-GU; Wed, 24 Mar 2021 19:53:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7iFmuMlMv8DxesMxZsaPCFacb6wTCATPx2ya+FC59uU=; b=lqXXN6j0CbeLKvvzBhKFvEMTP3 gpK0ZrMW4rNjZRyfPKKnB3JW5D8ia1dY3pWfaQ54rr05Jtba+r553Cc2iCeLt39zrRTwJJgylXNN1 /AlbivlhQrCTGlSINC05O2tcPUlNm5UfXdjNiMJgOayzsj/o0wAFAF47sQ10ium/ZCtk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160397: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=64d07691755e9aa6d3453ef3bb9109fde2b8da1e X-Osstest-Versions-That: xen=b9b3082002cac68726fb303e0abd2ff0113d4657 From: osstest service owner Date: Wed, 24 Mar 2021 19:53:47 +0000 flight 160397 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160397/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 64d07691755e9aa6d3453ef3bb9109fde2b8da1e baseline version: xen b9b3082002cac68726fb303e0abd2ff0113d4657 Last test of basis 160366 2021-03-23 17:00:25 Z 1 days Testing same since 160397 2021-03-24 17:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ian Jackson jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b9b3082002..64d0769175 64d07691755e9aa6d3453ef3bb9109fde2b8da1e -> smoke From xen-devel-bounces@lists.xenproject.org Wed Mar 24 20:38:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 20:38:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101168.193316 (Exim 4.92) (envelope-from ) id 1lPAGd-0000hB-AY; Wed, 24 Mar 2021 20:38:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101168.193316; Wed, 24 Mar 2021 20:38:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPAGd-0000h4-6n; Wed, 24 Mar 2021 20:38:15 +0000 Received: by outflank-mailman (input) for mailman id 101168; Wed, 24 Mar 2021 20:38:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPAGb-0000gz-S5 for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 20:38:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPAGX-00017W-6x; Wed, 24 Mar 2021 20:38:09 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lPAGW-00009Z-VU; Wed, 24 Mar 2021 20:38:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=iOQbi+7HkgRyqLD7KeRJZ4WNsKFuSK99LmJBPhgZOL8=; b=Su0aCPpUJ9sdYZE/QP+nTTxDwV P6eQpELtjhoBFAmPHqpslGckbab3ZYQ8TVVPnn3GPquFSdXlUfyIoPw1Q/U9WQi2Fpb2yqc2ykn+J U+6wgypam8JwRLMsty0e+bGw+MaHEzlq/pDSnj2Gn1hfBD8oNVPQr98nqLjRpw57kFX0=; Subject: Re: [PATCH v8] arm: Add Kconfig entry to select CONFIG_DTB_FILE To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , bertrand.marquis@arm.com References: <20210322081715.26175-1-michal.orzel@arm.com> From: Julien Grall Message-ID: <7fde269c-688f-60ae-df14-6919efb50539@xen.org> Date: Wed, 24 Mar 2021 20:38:06 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210322081715.26175-1-michal.orzel@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Michal, On 22/03/2021 08:17, Michal Orzel wrote: > Currently in order to link existing DTB into Xen image > we need to either specify option CONFIG_DTB_FILE on the > command line or manually add it into .config. > Add Kconfig entry: CONFIG_DTB_FILE > to be able to provide the path to DTB we want to embed > into Xen image. If no path provided - the dtb will not > be embedded. > > Remove the line: AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" > as it is not needed since Kconfig will define it in a header > with all the other config options. > > Move definition of _sdtb into dtb.S to prevent defining it > if there is no reference to it or if someone protects > _sdtb with #ifdef rather than with .ifnes. If the latter, > we will get a compiler error. > > Signed-off-by: Michal Orzel Reviewed-by: Julien Grall I have committed to my for-next/4.16 branch for now. This will soon reached staging. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 24 20:48:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 20:48:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101171.193327 (Exim 4.92) (envelope-from ) id 1lPAQk-0001mO-6G; Wed, 24 Mar 2021 20:48:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101171.193327; Wed, 24 Mar 2021 20:48:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPAQk-0001mH-3M; Wed, 24 Mar 2021 20:48:42 +0000 Received: by outflank-mailman (input) for mailman id 101171; Wed, 24 Mar 2021 20:48:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPAQj-0001mC-AA for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 20:48:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPAQi-0001Hb-A9; Wed, 24 Mar 2021 20:48:40 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lPAQi-0000gL-0m; Wed, 24 Mar 2021 20:48:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=WrkBGQkxZKd22Wj1sqgzEgBF+RB9abiUeilPohZU1bU=; b=dwlKDNXQm3ezPr9ZCt09m6pZ36 WktTC5oNRRRC+klS/l8gPWCupwJ1US6U0gLg8Y5xjaaFExOUsXQqD1WZjgyXv1vJo9mAnc/y74nOL +CwSAceM8i+p0bDJ8pqCxgYYdqEMEK4/qByrTwrn1Ih1qnYdGp/GSW+eVuVsmrNqTB0w=; Subject: Re: [PATCH v2 0/5] xen/arm: smmuv1: Fix stream match conflict issue To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk References: From: Julien Grall Message-ID: <2e1af560-5657-32cf-ad6f-c94086e2309b@xen.org> Date: Wed, 24 Mar 2021 20:48:38 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Rahul, On 22/03/2021 16:11, Rahul Singh wrote: > This patch is the work to fix the stream match conflict issue when two devices > have the same stream-id. > > Approach taken is to merge the below commit from Linux driver to fix the > issue. > > 1. "iommu/arm-smmu: Handle stream IDs more dynamically" > commit 21174240e4f4439bb8ed6c116cdbdc03eba2126e > 2. "iommu/arm-smmu: Consolidate stream map entry state" > commit 1f3d5ca43019bff1105838712d55be087d93c0da > 3. "iommu/arm-smmu: Keep track of S2CR state" > commit 8e8b203eabd8b9e96d02d6339e4abce3e5a7ea4b > 4. "iommu/arm-smmu: Add a stream map entry iterator" > commit d3097e39302083d58922a3d1032d7d59a63d263d > 5. "iommu/arm-smmu: Intelligent SMR allocation" > commit 588888a7399db352d2b1a41c9d5b3bf0fd482390 > > Changes since v2: > - Updated commit message to show the original author of the patch. > - Added Acked-by: Stefano Stabellini > - Addded Reviewed-by: Bertrand Marquis > > Rahul Singh (5): > xen/arm: smmuv1: Handle stream IDs more dynamically > xen/arm: smmuv1: Consolidate stream map entry state > xen/arm: smmuv1: Keep track of S2CR state > xen/arm: smmuv1: Add a stream map entry iterator > xen/arm: smmuv1: Intelligent SMR allocation I went through the commit messages and they look good to me: Acked-by: Julien Grall I have committed the series to my for-next/4.16 branch. They will be merged soon in staging. Cheers, > > xen/drivers/passthrough/arm/smmu.c | 423 ++++++++++++++++++----------- > 1 file changed, 262 insertions(+), 161 deletions(-) > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 24 20:57:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 20:57:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101175.193350 (Exim 4.92) (envelope-from ) id 1lPAYq-0002hL-JA; Wed, 24 Mar 2021 20:57:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101175.193350; Wed, 24 Mar 2021 20:57:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPAYq-0002h7-EH; Wed, 24 Mar 2021 20:57:04 +0000 Received: by outflank-mailman (input) for mailman id 101175; Wed, 24 Mar 2021 20:57:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPAYp-0002gG-I0 for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 20:57:03 +0000 Received: from aserp2130.oracle.com (unknown [141.146.126.79]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2ee38f51-d74e-4dc8-97ad-ab2c9523a4e5; Wed, 24 Mar 2021 20:57:02 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12OKtFjN165719; Wed, 24 Mar 2021 20:57:01 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 37d6jbmcea-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Mar 2021 20:57:00 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12OKuEf1188520; Wed, 24 Mar 2021 20:57:00 GMT Received: from nam02-cy1-obe.outbound.protection.outlook.com (mail-cys01nam02lp2050.outbound.protection.outlook.com [104.47.37.50]) by userp3020.oracle.com with ESMTP id 37dtttuf5h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Mar 2021 20:56:59 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BY5PR10MB4018.namprd10.prod.outlook.com (2603:10b6:a03:1b1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Wed, 24 Mar 2021 20:56:57 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.025; Wed, 24 Mar 2021 20:56:57 +0000 Received: from bostrovs-us.us.oracle.com (209.17.40.43) by CH0PR04CA0043.namprd04.prod.outlook.com (2603:10b6:610:77::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Wed, 24 Mar 2021 20:56:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ee38f51-d74e-4dc8-97ad-ab2c9523a4e5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=corp-2020-01-29; bh=mCJL1UVF0uGsPx6r2QxWvx1KIL6nSvrVsNJD9J0kgL4=; b=smhqu2ltVF7JEJ3o1X7jNbYIEzWYuZIWPt4DOprHDhDwSuLz9Y+JVrjYzhTgJR7K7uVP KPNbsaqvm28EXmZKJgWBc19UBD9FE0sx4gQgZ7T8yzHx5cv9HD0l0WNHZkqR76fwUPDP fCSAxn8OxPaL7NriwcVu4S6Mw1HY2VEvnxHa8+iu1vUlvI8AklQlvuLsy0XmFk9JiLrV 0W7Zh1UqEn+XxGJxjMKfFzzpxPN250CI6LFfwRuGurCD64N4oao3uyNiH2LiPkdkNbN4 U5IgoqS19WVflA6joTo2f50jjFXn24eZB31cscyLlxmpd5d+ow6y0uPykRVF6gHrb6OV uQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n3zVHzcaJg/uWzhuuTpWZBDmQiI7sBm/b1ZdHKHVnZImTXIpcA6IDR63GN0Lh4vHGyhRDuXgvabvxoQZZU+gq4STdhBmXbwj9tmp/h/K99rWh+H7ReMK/2CdGGDxXltNIsk1TSV6yoWCtPwAYtbbsM4U8sM4fvLFQnm56jTC1T7KHfw9aM/wpJ76I+ADu+Y4F+TwZlql6mpf/Dc1SdkoYwZeTo7MKokckbGn5/FPURYrgdzgm7Oi60rAYDwWCVnb4lXF7IH20PDXeVH8PWpu5f3LSEzT3ehrV/RNrYfKpTxuTWiHlxUEbPkh6Q2k93JJki84e9sFET9V0R232wA4Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mCJL1UVF0uGsPx6r2QxWvx1KIL6nSvrVsNJD9J0kgL4=; b=coZPl+Hub/krc56SHRvnaHawYf49m5LLTkPADhT9P+PZRAKyxzgGvPgfmGZQE63Isk0triH7Nz361S3+H5AD5tAR8VsY11gb6cdc7L0M9uOhww/RzXwcHBhd2a8IsYpZtalgSrTlwsvxEFSFNANcOgAef6L2UUKMNMKR5U5Lfv0CosUbgwAqeYw6dGTp/UGh9N37ozZ7dFz5rxMNigCqCyp3unno714Bkynp8tXFbof9EntnmaDSyPlJSgWpTmB+gEVpS8ZI0JskY9JscK6/587CLKtVkVfi73hZX8sOqdSVo5GjgN2lRqf3tx5SVYERueRtOKEJbTOu/j90eksphg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mCJL1UVF0uGsPx6r2QxWvx1KIL6nSvrVsNJD9J0kgL4=; b=zZmQIBOjCKqUuJoFqh4C6JPa6KUzCO4z8piu6h0//2lObGDCjDA7m0wEECBgNNz4P8Ta6a4xeEwEp0DDLOoi1sqyBqL84yXm4mDdyMJzDDGQ7q4lcNYfOECABOE6ZxBtFPKGk34la48SYgoNpLOJ7/2HjlAgfIm1TG6YyDYZq+4= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; From: Boris Ostrovsky To: xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, boris.ostrovsky@oracle.com Subject: [PATCH] x86/vpt: Replace per-guest pt_migrate lock with per pt lock Date: Wed, 24 Mar 2021 16:56:35 -0400 Message-Id: <1616619395-32438-2-git-send-email-boris.ostrovsky@oracle.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1616619395-32438-1-git-send-email-boris.ostrovsky@oracle.com> References: <1616619395-32438-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain X-Originating-IP: [209.17.40.43] X-ClientProxiedBy: CH0PR04CA0043.namprd04.prod.outlook.com (2603:10b6:610:77::18) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a43b28c8-a191-47aa-1ca2-08d8ef075c8c X-MS-TrafficTypeDiagnostic: BY5PR10MB4018: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:534; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xNMRXYKa5NB8kGh10vOSKUnBZyfeIbBaz6c6x5MEsZVgsWATchqehoXG5UL4KMHwXHF55iF5rxVWNpb7xsQfXU6UX4X4X3eY7T1YID1y3iMT1VenxwqiJ5iwSL60nAcXBCMItiJuVjqKfAhYKd0ASGzwetCkh6nRFJiKt9ldcIwqaQRMeOvVs4gsbTEdjTTLtg3WVKFYdWzDt4HcedVKGShw1YxrUWcIXweijvrSvPVChcph2bFmUvRuknlzm2O+6C3QLxJPaLL8FJzrmWTrB4CnZeEXraZngPAeuKaAwr6hVAcGdiS2D1BZMfP2Z6tVFtI5aetUy3WPL2IMxjs7wXDnE9e3Pqut5my8EbTp+d0or6chtA0p+d6f2uDWAMhMIkyBo19GULThw0nXxdB5kr3bR1iS0L2fSFWuGD4zkBmJznLrb6LjZsOBwucECy0kQEccmVr+X1nPkdvuTzZHo9Dz6SJs+aoPJLP5N27JbsVD5QA9bLighALCMQ8l6uI9+2xzIuWHHwAQ9LQ/WCrBxptQYExYJdhJTKhJztskTf0b4BCbsKqu+UNtbyV7Hn3grJDQPwU95D/aIgYy3bIZACXhZjUw0HTI2WY3Z3a6IolndcPLJ0Stp5Wjvi6A61t+X9DYkKazx7QsWhbSg38CaM6DlS+KhoY7JBlC+uCr4Pw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(396003)(39860400002)(366004)(346002)(66556008)(66476007)(66946007)(107886003)(186003)(44832011)(6486002)(6666004)(2906002)(7696005)(52116002)(38100700001)(316002)(30864003)(36756003)(26005)(5660300002)(6916009)(4326008)(2616005)(956004)(8676002)(8936002)(86362001)(83380400001)(478600001)(16526019);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?9TBLtfejEozpk2669SkoTesYmFx09Xcbycs9AVxaZ8J/sDz56OzoPCdYOloJ?= =?us-ascii?Q?drtiOPdt+v24p4zoxwNqN4bLuZzR2BALER6l0GvFvI13rdQSmba+Qubqev7H?= =?us-ascii?Q?j3TLCtGOjxGvkkcDJQlyeY9fW1c3uVhh8+GVhRaynAHaQ/J3hrmxImzkZQya?= =?us-ascii?Q?U9mraghpMTnQONi+q08oBY1BfpfA1cH/cIFYoEk/gQ5+fpsh+UEx962GLGdo?= =?us-ascii?Q?eXo07naQgaid3YTecFo08ZlrT8SpbU6fEF3SxMtY7pn453vvKad0kvGLAkc/?= =?us-ascii?Q?od7MQi6fpt10aAoEwla3L/IOqVyR2WNiU9kQHLq/Kn+IA3GV4Q4exhg2+OOY?= =?us-ascii?Q?tT0bxwd4jEIv5ylY/O3OqbvHw1vQ7gTnm57EewIj1OM+v4jk6Wph028lvn7a?= =?us-ascii?Q?BwkMkVdo9WjQ0fon2qacnjLjKmtbfpaKymxP5wOu3aSSe3Oq/cVNuLOo1MZf?= =?us-ascii?Q?zGC4V0Y2351UDVOH7j3UcPetFOJA6+vU/AE13gGQXNB31qDYQ5QRRkEdIam+?= =?us-ascii?Q?rLHcNfj6cIrCj71bbIpomBfZT8hEFdeD3fvr4cGfH0unL/BnDb7yE2rl4f7a?= =?us-ascii?Q?UdCykzD4uah0w76sE9aDx+LK7Y37HRNAtqen9pwOnfS8FPAR9c/guQANARhb?= =?us-ascii?Q?AemjxhoOIlukM5ZAQxVZ8/pJdrevDbFIkzXx1qjZydiWvr69Lvugzxxuo5LL?= =?us-ascii?Q?mzlfw38ZCaW24l3oQrjK3fWgm+aQ2fk+kAv+fG/W3W+O1+mcyuU0pj/Fo0TV?= =?us-ascii?Q?jZZ31DwwvTtud9hTOVGLaA/vAC3XVfmYsFz5yreNiJJFIrPfk2zH6RxrAhkk?= =?us-ascii?Q?lWIif9dZSFgCk9MuARjlIUdI79fKJI5K4ignLTYVsajxv+nHq41b/mdDaOFu?= =?us-ascii?Q?OnKgrZ/tJkQv8FM/pYRiSGbTN3IJd/b6rmXYL+nG8Ym8EMy5o4+Ly3h4nC8E?= =?us-ascii?Q?+WMuVkwSBCcnC0hBHpQcupKveAX0lf7AD5367dQWLXgZazkOaPbeLCdJQ66s?= =?us-ascii?Q?cxYaW0mt5X1uT9fjjPx72MfPepQwk8bZcg8M1HEgN6eiwJNpNVGDaIgoDHvE?= =?us-ascii?Q?LubKuk6qmnhcj8/LVE8q7nCS16i3IUcat34GqUb4SICyx0tgyegS5GwJLOSX?= =?us-ascii?Q?ydDKXwbfShyR8otnJk+W9skls+tS+7cSyV5Rv1PQCfwMMNg6KZ7xJCqvDySR?= =?us-ascii?Q?pPJM8xx4stQkL5ybdbUsXwZCbhRoET7V3mc3LH6SCV44r8SRRWtU5A8q9H8X?= =?us-ascii?Q?OjwKHEr6qrqBR+O9gHQx/gSg29d7ltojq2Udrfok60jLngUbmjkLYxmN4b2c?= =?us-ascii?Q?z4xcJZeqPyMgil3xDaU2yhwp?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a43b28c8-a191-47aa-1ca2-08d8ef075c8c X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 20:56:57.4937 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TDUgPVCYhBZkFBx2twUlfQEVN+bRZmkCqiQmr7WJmrw9wGFM7nO7GuTXziW3/CIhAk8osdMkI4IMVf84PWeLta5WZa3Yxt1BZ3OsqofSzvI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4018 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9933 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103240152 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9933 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 adultscore=0 impostorscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103240152 Commit 8e76aef72820 ("x86/vpt: fix race when migrating timers between vCPUs") addressed XSA-336 by introducing a per-domain rwlock that was intended to protect periodic timer during VCPU migration. Since such migration is an infrequent event no performance impact was expected. Unfortunately this turned out not to be the case: on a fairly large guest (92 VCPUs) we've observed as much as 40% TPCC performance regression with some guest kernels. Further investigation pointed to pt_migrate read lock taken in pt_update_irq() as the largest contributor to this regression. With large number of VCPUs and large number of VMEXITs (from where pt_update_irq() is always called) the update of an atomic in read_lock() is thought to be the main cause. Stephen Brennan examined the locking pattern and suggested using a per-timer lock instead. This lock will need to be held whenever there is a chance that pt->vcpu field may change (thus avoiding XSA-336 condition). Suggested-by: Stephen Brennan Signed-off-by: Boris Ostrovsky --- xen/arch/x86/emul-i8254.c | 2 + xen/arch/x86/hvm/hpet.c | 1 + xen/arch/x86/hvm/hvm.c | 2 - xen/arch/x86/hvm/rtc.c | 1 + xen/arch/x86/hvm/vlapic.c | 1 + xen/arch/x86/hvm/vpt.c | 122 +++++++++++++++++++++++------------------- xen/include/asm-x86/hvm/vpt.h | 9 +--- 7 files changed, 74 insertions(+), 64 deletions(-) diff --git a/xen/arch/x86/emul-i8254.c b/xen/arch/x86/emul-i8254.c index 73be4188ad41..d83e727ff35e 100644 --- a/xen/arch/x86/emul-i8254.c +++ b/xen/arch/x86/emul-i8254.c @@ -478,6 +478,8 @@ void pit_init(struct domain *d, unsigned long cpu_khz) if ( !has_vpit(d) ) return; + spin_lock_init(&pit->pt0.lock); + spin_lock_init(&pit->lock); if ( is_hvm_domain(d) ) diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c index ca94e8b4538c..c7f45412164e 100644 --- a/xen/arch/x86/hvm/hpet.c +++ b/xen/arch/x86/hvm/hpet.c @@ -734,6 +734,7 @@ static void hpet_set(HPETState *h) h->hpet.timers[i].cmp = ~0ULL; h->hpet.comparator64[i] = ~0ULL; h->pt[i].source = PTSRC_isa; + spin_lock_init(&h->pt[i].lock); } } diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index e7bcffebc490..b60549a12a33 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -658,8 +658,6 @@ int hvm_domain_initialise(struct domain *d) /* need link to containing domain */ d->arch.hvm.pl_time->domain = d; - rwlock_init(&d->arch.hvm.pl_time->pt_migrate); - /* Set the default IO Bitmap. */ if ( is_hardware_domain(d) ) { diff --git a/xen/arch/x86/hvm/rtc.c b/xen/arch/x86/hvm/rtc.c index 3150f5f1479b..6289d972bb67 100644 --- a/xen/arch/x86/hvm/rtc.c +++ b/xen/arch/x86/hvm/rtc.c @@ -842,6 +842,7 @@ void rtc_init(struct domain *d) } spin_lock_init(&s->lock); + spin_lock_init(&s->pt.lock); init_timer(&s->update_timer, rtc_update_timer, s, smp_processor_id()); init_timer(&s->update_timer2, rtc_update_timer2, s, smp_processor_id()); diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index 5e21fb4937d9..8413e41a7a80 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -1626,6 +1626,7 @@ int vlapic_init(struct vcpu *v) vlapic_reset(vlapic); spin_lock_init(&vlapic->esr_lock); + spin_lock_init(&vlapic->pt.lock); tasklet_init(&vlapic->init_sipi.tasklet, vlapic_init_sipi_action, v); diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index 4c2afe2e9154..36d4699a5de6 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -153,32 +153,16 @@ static int pt_irq_masked(struct periodic_time *pt) return 1; } -static void pt_vcpu_lock(struct vcpu *v) -{ - read_lock(&v->domain->arch.hvm.pl_time->pt_migrate); - spin_lock(&v->arch.hvm.tm_lock); -} - -static void pt_vcpu_unlock(struct vcpu *v) -{ - spin_unlock(&v->arch.hvm.tm_lock); - read_unlock(&v->domain->arch.hvm.pl_time->pt_migrate); -} - static void pt_lock(struct periodic_time *pt) { - /* - * We cannot use pt_vcpu_lock here, because we need to acquire the - * per-domain lock first and then (re-)fetch the value of pt->vcpu, or - * else we might be using a stale value of pt->vcpu. - */ - read_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); + spin_lock(&pt->lock); spin_lock(&pt->vcpu->arch.hvm.tm_lock); } static void pt_unlock(struct periodic_time *pt) { - pt_vcpu_unlock(pt->vcpu); + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); + spin_unlock(&pt->lock); } static void pt_process_missed_ticks(struct periodic_time *pt) @@ -228,7 +212,7 @@ void pt_save_timer(struct vcpu *v) if ( v->pause_flags & VPF_blocked ) return; - pt_vcpu_lock(v); + spin_lock(&v->arch.hvm.tm_lock); list_for_each_entry ( pt, head, list ) if ( !pt->do_not_freeze ) @@ -236,7 +220,7 @@ void pt_save_timer(struct vcpu *v) pt_freeze_time(v); - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); } void pt_restore_timer(struct vcpu *v) @@ -244,7 +228,7 @@ void pt_restore_timer(struct vcpu *v) struct list_head *head = &v->arch.hvm.tm_list; struct periodic_time *pt; - pt_vcpu_lock(v); + spin_lock(&v->arch.hvm.tm_lock); list_for_each_entry ( pt, head, list ) { @@ -257,7 +241,7 @@ void pt_restore_timer(struct vcpu *v) pt_thaw_time(v); - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); } static void pt_timer_fn(void *data) @@ -318,7 +302,7 @@ int pt_update_irq(struct vcpu *v) int irq, pt_vector = -1; bool level; - pt_vcpu_lock(v); + spin_lock(&v->arch.hvm.tm_lock); earliest_pt = NULL; max_lag = -1ULL; @@ -348,7 +332,7 @@ int pt_update_irq(struct vcpu *v) if ( earliest_pt == NULL ) { - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); return -1; } @@ -356,7 +340,7 @@ int pt_update_irq(struct vcpu *v) irq = earliest_pt->irq; level = earliest_pt->level; - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); switch ( earliest_pt->source ) { @@ -403,7 +387,7 @@ int pt_update_irq(struct vcpu *v) time_cb *cb = NULL; void *cb_priv = NULL; - pt_vcpu_lock(v); + spin_lock(&v->arch.hvm.tm_lock); /* Make sure the timer is still on the list. */ list_for_each_entry ( pt, &v->arch.hvm.tm_list, list ) if ( pt == earliest_pt ) @@ -413,7 +397,7 @@ int pt_update_irq(struct vcpu *v) cb_priv = pt->priv; break; } - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); if ( cb != NULL ) cb(v, cb_priv); @@ -450,12 +434,12 @@ void pt_intr_post(struct vcpu *v, struct hvm_intack intack) if ( intack.source == hvm_intsrc_vector ) return; - pt_vcpu_lock(v); + spin_lock(&v->arch.hvm.tm_lock); pt = is_pt_irq(v, intack); if ( pt == NULL ) { - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); return; } @@ -464,7 +448,7 @@ void pt_intr_post(struct vcpu *v, struct hvm_intack intack) cb = pt->cb; cb_priv = pt->priv; - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); if ( cb != NULL ) cb(v, cb_priv); @@ -475,12 +459,34 @@ void pt_migrate(struct vcpu *v) struct list_head *head = &v->arch.hvm.tm_list; struct periodic_time *pt; - pt_vcpu_lock(v); + spin_lock(&v->arch.hvm.tm_lock); list_for_each_entry ( pt, head, list ) migrate_timer(&pt->timer, v->processor); - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); +} + +static void __destroy_periodic_time(struct periodic_time *pt, bool locked) +{ + /* Was this structure previously initialised by create_periodic_time()? */ + if ( pt->vcpu == NULL ) + return; + + if (!locked) + pt_lock(pt); + if ( pt->on_list ) + list_del(&pt->list); + pt->on_list = 0; + pt->pending_intr_nr = 0; + if (!locked) + pt_unlock(pt); + + /* + * pt_timer_fn() can run until this kill_timer() returns. We must do this + * outside pt_lock() otherwise we can deadlock with pt_timer_fn(). + */ + kill_timer(&pt->timer); } void create_periodic_time( @@ -497,9 +503,16 @@ void create_periodic_time( return; } - destroy_periodic_time(pt); + spin_lock(&pt->lock); - write_lock(&v->domain->arch.hvm.pl_time->pt_migrate); + if ( pt->vcpu ) + { + spin_lock(&pt->vcpu->arch.hvm.tm_lock); + + __destroy_periodic_time(pt, true); + + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); + } pt->pending_intr_nr = 0; pt->do_not_freeze = 0; @@ -543,33 +556,22 @@ void create_periodic_time( pt->cb = cb; pt->priv = data; + spin_lock(&pt->vcpu->arch.hvm.tm_lock); + pt->on_list = 1; list_add(&pt->list, &v->arch.hvm.tm_list); + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); + init_timer(&pt->timer, pt_timer_fn, pt, v->processor); set_timer(&pt->timer, pt->scheduled); - write_unlock(&v->domain->arch.hvm.pl_time->pt_migrate); + spin_unlock(&pt->lock); } void destroy_periodic_time(struct periodic_time *pt) { - /* Was this structure previously initialised by create_periodic_time()? */ - if ( pt->vcpu == NULL ) - return; - - pt_lock(pt); - if ( pt->on_list ) - list_del(&pt->list); - pt->on_list = 0; - pt->pending_intr_nr = 0; - pt_unlock(pt); - - /* - * pt_timer_fn() can run until this kill_timer() returns. We must do this - * outside pt_lock() otherwise we can deadlock with pt_timer_fn(). - */ - kill_timer(&pt->timer); + __destroy_periodic_time(pt, false); } static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) @@ -579,15 +581,25 @@ static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) if ( pt->vcpu == NULL ) return; - write_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); + spin_lock(&pt->lock); + spin_lock(&pt->vcpu->arch.hvm.tm_lock); + + if ( pt->on_list ) + list_del(&pt->list); + + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); + pt->vcpu = v; + + spin_lock(&pt->vcpu->arch.hvm.tm_lock); if ( pt->on_list ) { - list_del(&pt->list); list_add(&pt->list, &v->arch.hvm.tm_list); migrate_timer(&pt->timer, v->processor); } - write_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); + + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); + spin_unlock(&pt->lock); } void pt_adjust_global_vcpu_target(struct vcpu *v) diff --git a/xen/include/asm-x86/hvm/vpt.h b/xen/include/asm-x86/hvm/vpt.h index 39d26cbda496..b0f4af25828b 100644 --- a/xen/include/asm-x86/hvm/vpt.h +++ b/xen/include/asm-x86/hvm/vpt.h @@ -49,6 +49,8 @@ struct periodic_time { u64 last_plt_gtime; /* platform time when last IRQ is injected */ struct timer timer; /* ac_timer */ time_cb *cb; + spinlock_t lock; /* protects vcpu field during PT migration. */ + /* Needs to be taken before VCPU's tm_lock. */ void *priv; /* point back to platform time source */ }; @@ -128,13 +130,6 @@ struct pl_time { /* platform time */ struct RTCState vrtc; struct HPETState vhpet; struct PMTState vpmt; - /* - * rwlock to prevent periodic_time vCPU migration. Take the lock in read - * mode in order to prevent the vcpu field of periodic_time from changing. - * Lock must be taken in write mode when changes to the vcpu field are - * performed, as it allows exclusive access to all the timers of a domain. - */ - rwlock_t pt_migrate; /* guest_time = Xen sys time + stime_offset */ int64_t stime_offset; /* Ensures monotonicity in appropriate timer modes. */ -- 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 20:57:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 20:57:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101174.193340 (Exim 4.92) (envelope-from ) id 1lPAYq-0002gS-3R; Wed, 24 Mar 2021 20:57:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101174.193340; Wed, 24 Mar 2021 20:57:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPAYp-0002gL-UP; Wed, 24 Mar 2021 20:57:03 +0000 Received: by outflank-mailman (input) for mailman id 101174; Wed, 24 Mar 2021 20:57:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPAYo-0002gB-Jv for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 20:57:02 +0000 Received: from aserp2130.oracle.com (unknown [141.146.126.79]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dd7bca63-ba68-4bdc-a097-202187aa8bf8; Wed, 24 Mar 2021 20:57:01 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12OKsKtH165154; Wed, 24 Mar 2021 20:56:58 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 37d6jbmce6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Mar 2021 20:56:58 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12OKtE9I076964; Wed, 24 Mar 2021 20:56:58 GMT Received: from nam02-cy1-obe.outbound.protection.outlook.com (mail-cys01nam02lp2054.outbound.protection.outlook.com [104.47.37.54]) by aserp3030.oracle.com with ESMTP id 37dtmrawg0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Mar 2021 20:56:57 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BY5PR10MB4018.namprd10.prod.outlook.com (2603:10b6:a03:1b1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Wed, 24 Mar 2021 20:56:56 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.025; Wed, 24 Mar 2021 20:56:55 +0000 Received: from bostrovs-us.us.oracle.com (209.17.40.43) by CH0PR04CA0043.namprd04.prod.outlook.com (2603:10b6:610:77::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Wed, 24 Mar 2021 20:56:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd7bca63-ba68-4bdc-a097-202187aa8bf8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-type : mime-version; s=corp-2020-01-29; bh=cUWpybHwNWZf1njl51i+SbH5PEo8bcwx0W2qNrZVrNU=; b=Izf9Tfljs2yoZaNOx0WPvIh3iYGNamMixEe/YhyssbYClDGzbIzCZWNTgdoaGa06lVub WlRIwoY5ItbknDyv8JecG2P2rQBk+4bd/6ta2nuMaiuYMLNokDrdDSMJ8rPaHTVg4YNa LS6RoMxtdnk62h1VCUy1S0yCCjRWzLBSfP9mfCQRs0WnItKnAz/GHmq2BJrnsv7iHT4T FZgn8yr4Axd/m1V3uCJWXGjWRhvwS5qbFn5ttdRIJC4dJ2OLLo0ynItJiZ2u+dxazqIs dVixffBr9ezKwiEp5+hY2uewgbDcc4oWbaF5Vhy4aXdFvb4+AoSW1yuZGDA7vJ27sq/+ VA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QPBovbY+NjYjhKn9zOW+mxzS3IBQ7+qXvTuD1MUQ2zw0cAMY5aWaSZsDcv0BY3LOoHV2hnfzoU0y2B2pYFBXgowUrlL6FCWJ5nW5TxsNlMKsXGMYVUX6KuWlfg0QiCqiXl7CnlbwtjBXqqE6RH3821f1CdKa9dmOL8/vzB5fcM1zqyi1S2SF14yMjQVQJNOwIfOvtihl723/O8eJtTvVmfi7zwb5XsL6ILMamvr+eBS8k8iNfHXRFII9C365GZThbNMT6oMk+xt4TNAKQI1lN9DWI20NhER7JKqofheD92hpdXabRBBIdhsRVvJ9LRC+uEch/DZupHI4UniM9cq6/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cUWpybHwNWZf1njl51i+SbH5PEo8bcwx0W2qNrZVrNU=; b=gg4P8n+lWGIiF7rNOvsnGy842BhfUtVgLeRf+VWLqWYlfmFwPBieYWbADpWRDxXZEEnxP86J5M5xScEMpbI4AxADn9mEkEyv2RYa/VPFcSqLTEMevGJfOfHiX5G7QeKLa7m6tYQ/m0/Le35FjPWa1/mHT2LQeelncTk4B5LRgzZtaUIP/6lQl1IsPTt4xqBpzGX22c71xbZUbuftbJH/Jv4807oCMdDp4VLO+Zzg+C540YjHSb4+v3kwauCgbMwgsRWedB7l604XXUZALh/OOOJCTKf1JkKxmSA5tFZgeKboQazFEIqBOyokWjBRQIgZNQPrvWYTUK/yNMAVVK4h8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cUWpybHwNWZf1njl51i+SbH5PEo8bcwx0W2qNrZVrNU=; b=yviHkO0BDwad0eVu1B0CbrnbGyR22CnTsJwEo4T2asct1abMD1CM+CYoagOn9Ks5VT1seNa8VxXA7StMcPYtCK1hxFY5wPR/iEzatXJrM/ogRTSvQ5k/2XgV/FyFvS7Fm3oUA/ZWMfrEKShcJfBAfDHdnXOpb02FwyZGzJUmhS8= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; From: Boris Ostrovsky To: xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, boris.ostrovsky@oracle.com Subject: [PATCH] Performance regression due to XSA-336 Date: Wed, 24 Mar 2021 16:56:34 -0400 Message-Id: <1616619395-32438-1-git-send-email-boris.ostrovsky@oracle.com> X-Mailer: git-send-email 1.8.3.1 Content-Type: text/plain X-Originating-IP: [209.17.40.43] X-ClientProxiedBy: CH0PR04CA0043.namprd04.prod.outlook.com (2603:10b6:610:77::18) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 972403ac-5fee-46f2-f22e-08d8ef075bc4 X-MS-TrafficTypeDiagnostic: BY5PR10MB4018: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7P9cj4tKcrGrUdUYdCmv4vW1aS9TQw7lO90/nKo01Ol0asRfevXmYJhjOYIU6jNI1f6ohPOAXjYhm2Y2n4zE8PosD2MC/6rtZPWzpT4PvHiho+O1t30bEoV6ge1/YnIF5C8ew6Xa5KGPivdiP56jHIEexZj+UiRm1NyraJx/yOmOjrIEBQrdpIoHVl0NpXmC6Wnb1j3BGBncAnL5ijAs2kcNAwjRVffqIaXRbCXxLJ3nboElYWDK4Ddt3bxPjVdq3gO8EMpMbK7IFablTlhRPHN/BqACAKg3/7vXbflYaEyYqt3yQ8KU3tLl/8T7hAYDk1esBjT/EpvcvLNszVG3SVtArUaKp2lU9LeGl2ysay3ZyjKAM4V8arvXF1gOH8TivL8rr0e9PRMal6HRhRcSFa+rw3Nkfi2tVKU5ItYoP9+rYqbgukDmOqZzNuBjSPmOMDX1MQ0c7YOG8AyW7AHZPKxximq2fu0wCFkIgCVBlOIt9mbFutr007FlqiYQRH64r+R7PbjEK+iABw6CzO1N1ayow8GXmR179AxY2aADz7na4Ltmnytq8p8hpFmwBgaXlE1OxjQ1YujRDN1AbmSbro7NfVTWjqnn8LkHOYatP2O1uCBKfKTPi4ZFoF0SDwCN5nPJqMnNM8C7YOXVwwaYXQjWbroytRi3E6kcvWmYme4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(396003)(39860400002)(366004)(346002)(66556008)(66476007)(66946007)(107886003)(186003)(44832011)(6486002)(6666004)(2906002)(7696005)(52116002)(38100700001)(316002)(36756003)(26005)(5660300002)(6916009)(4326008)(2616005)(956004)(8676002)(8936002)(86362001)(83380400001)(478600001)(16526019);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?TpC90TFvqzOpRYENGZcOmzEcx8OEm89L5+b8BLphVPGd+etpmntVk/xa1CVW?= =?us-ascii?Q?G+rwhpQdbpaIfIqor7iRl0XKj1nppcySwXhdHZzuWcQXWckvgQZoidHPhZvm?= =?us-ascii?Q?3Ftz/F8HAEAekV6b9bSPzsBUT0vZk2qiAEJ97NDJSibNIfwsCWI/vG0308zc?= =?us-ascii?Q?jtbSINDULskNTFNksrZDgo4JTX4ISqEXxbhmbBGVCOkmuN9rIvjXbMWd5UlX?= =?us-ascii?Q?Mpbr3BPtvewBF8ZJSve30gFPMxKrgiwgg03a9b9Pz9nnHqpkpcgcha6ttmgw?= =?us-ascii?Q?m/Es3qyKtEiAfn4lnbz5Og0Cgz0DCKfbXF3NASEjm/74+T9sC7K4idFR/dyo?= =?us-ascii?Q?MZ1dCc+WbPh6LTu/cdpW+mkdFMryHQlLK9+Eb9SHucFY8xikJXVffNSYfkEs?= =?us-ascii?Q?ZQSXnjHcpfUU265rpY6w8aUHQ0dl0PVg4ZgPjWhgVi3ekjoKodJ08dx4WN0X?= =?us-ascii?Q?o6U3lAZafODPHQ7TA4zn54o1wDrDysAGgyR8eD4Wp+Qo8t4l9yXr20XuoxhT?= =?us-ascii?Q?hsJXh02/oj7Zm51nptjpxd5XzZK2ddrYfELPruWIyJSr5Dev2pRQn15ywXzQ?= =?us-ascii?Q?fTsEbmt2TKTDrqkwolh1qRR/btK+It/4LmpvdT8Uoi+9tnH6OGyB5rk+NQ8B?= =?us-ascii?Q?Fy5MBDO3n8tW+3yZ5Sb22vWayVJPD1LB73lKiy+D7faMFzalMm/AhNO+3eYD?= =?us-ascii?Q?EbZ9uWJ8v6neIHNP/uuM5BKByACilDIOSQK7fRGHIZD+HarBMTJmwJr+ygHu?= =?us-ascii?Q?cTXusES3hgnfssQ97VLPOjsFQg69ck8XZd2JcBRtxlzqFjYUb8hodFddovsh?= =?us-ascii?Q?8o5+ESTfmml3MEDe254xesL6GkaYXrEtN4/swFwLxWxLnCucqo36/paOCsRu?= =?us-ascii?Q?HhXzQoqt/nH4aGWiqeUksMrNOTX75heqmUoZYGPZe9oT2NmcwDxsnrCk7a3r?= =?us-ascii?Q?sNGwVpf8auBjmLBSSkjbX5bJ8UUW0iI0ocqlgkhGu+elHUmmS4M2Eo8+dEj5?= =?us-ascii?Q?vaH7uBT1O+sWib8WrFioEgoFkLuju9pKOin/SglfgiGNN7y6kfUw12Xxiv2F?= =?us-ascii?Q?otwUinu/VAbmdejhwa0ofAUM5Fgy/vwQIXU92SaqtIC0xbpT8jDe++1ysh1F?= =?us-ascii?Q?i47ipSf8kVn3PJ2QD3ZnDbLRbRmD2aTYGK7GGyIAZsf84upg5TRPV+BHt9DS?= =?us-ascii?Q?QWtM/VygICpcdW8sovVtk5Mlqx8dLuwXckaue0TZYF90K5PyLa5hxFNCbkvy?= =?us-ascii?Q?oOLZ7XBmWBuK69RJuSAdEmgesSC7rs1u3T7hU/OCTK/d+okr++zVAiCQlEtE?= =?us-ascii?Q?zt92vJkYuSj6K61BPv8PyKTk?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 972403ac-5fee-46f2-f22e-08d8ef075bc4 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 20:56:55.8857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZKIwcNcZQQFMwwmKb7Q7iab9yV5vaR/OOPNXr4UVyMLdb9MRc+6yh6sYc3xmjcK9XIiZqFSYs/8dgFXB15aMumqiUGIvNElA05i7ZAG6P8w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4018 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9933 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103240152 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9933 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1011 priorityscore=1501 spamscore=0 adultscore=0 impostorscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103240152 While running performance tests with recent XSAs backports to our product we've discovered significant regression in TPCC performance. With a particular guest kernel the numbers dropped by as much as 40%. We've narrowed that down to XSA-336 patch, specifically to the pt_migrate rwlock, and even more specifically to this lock being taken in pt_update_irq(). We have quite a large guest (92 VCPUs) doing lots of VMEXITs and the theory is that lock's cnts atomic is starting to cause lots of coherence traffic. As a quick test of this replacing pt_vcpu_lock() in pt_update_irq() with just spin_lock(&v->arch.hvm_vcpu.tm_lock) gets us almost all performance back. Stephen Brennan came up with new locking algorithm, I just coded it up. A couple of notes: * We have only observed the problem and tested this patch for performance on a fairly old Xen version. However, vpt code is almost identical and I expect upstream to suffer from the same issue. * Stephen provided the following (slightly edited by me) writeup explaining the locking algorithm. I would like to include it somewhere but not sure what the right place would be. Commit message perhaps? Currently, every periodic_time is protected by locking the vcpu it is on. You can think of the per-vCPU lock (tm_lock) as protecting the fields of every periodic_time which is attached to that vCPU, as well as the list itself, and so it must be held when read or written, or when an object is added or removed to/from the list. It seems that there are three types of access to the peridic_time objects: 1. Functions which read (maybe write) all periodic_time instances attached to a particular vCPU. These are functions which use pt_vcpu_lock() after the commit, such as pt_restore_timer(), pt_save_timer(), etc. 2. Functions which want to modify a particular periodic_time object. These guys lock whichever vCPU the periodic_time is attached to, but since the vCPU could be modified without holding any lock, they are vulnerable to the bug. Functions in this group use pt_lock(), such as pt_timer_fn() or destroy_periodic_time(). 3. Functions which not only want to modify the periodic_time, but also would like to modify the =vcpu= fields. These are create_periodic_time() or pt_adjust_vcpu(). They create the locking imbalance bug for group 2, but we can't simply hold 2 vcpu locks due to the deadlock risk. My proposed option is to add a per-periodic_time spinlock, which protects only the periodic_time.vcpu field. Whenever reading the vcpu field of a periodic_time struct, you must first take that lock. The critical sections of group 1 (your "fast path" functions) would look like this: 1. lock vcpu 2. do whatever you want with pts currently on the vcpu. It is safe to read or write fields of pt, because the vcpu lock protects those fields. You simply cannot write pt->vcpu, because somebody holding the pt lock may already be spinning waiting for your vcpu lock. 3. unlock vcpu Note that there is no additional locking in this fast path. For group 2 functions (which are attempting to lock an individual periodic_time), the critical section would look like this: 1. lock pt lock (stabilizing the vcpu field) 2. lock vcpu 3. feel free to modify any field of the periodic_time 4. unlock vcpu (due to the mutual exclusion of the pt lock, we know that we are unlocking the correct vcpu -- we have not been migrated) 5. unlock pt For functions in group 3, the critical section would be: 1. lock pt (stabilizing the vcpu field) 2. lock current vcpu 3. remove from vcpu list 4. unlock vcpu. At this point, you're guaranteed that the vcpu functions (callers of pt_vcpu_lock()) are not accessing your pt. 5. assign pt->vcpu (we still have mutual exclusion against group 2 functions) 6. lock destination vcpu 7. add to vcpu list 8. unlock destination vcpu 9. unlock pt If functions from group 2 and 3 are less frequent, then you won't see too much added lock overhead in this situation! Plus, even if group 2 and 3 are somewhat common, the performance overhead of an uncontented fine-grained lock is muuch smaller than the overhead of a heavily contended coarse-grained lock, like the per-domain rw lock. Boris Ostrovsky (1): x86/vpt: Replace per-guest pt_migrate lock with per pt lock xen/arch/x86/emul-i8254.c | 2 + xen/arch/x86/hvm/hpet.c | 1 + xen/arch/x86/hvm/hvm.c | 2 - xen/arch/x86/hvm/rtc.c | 1 + xen/arch/x86/hvm/vlapic.c | 1 + xen/arch/x86/hvm/vpt.c | 122 +++++++++++++++++++++++------------------- xen/include/asm-x86/hvm/vpt.h | 9 +--- 7 files changed, 74 insertions(+), 64 deletions(-) -- 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 21:05:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 21:05:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101188.193370 (Exim 4.92) (envelope-from ) id 1lPAh2-0003vQ-Q4; Wed, 24 Mar 2021 21:05:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101188.193370; Wed, 24 Mar 2021 21:05:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPAh2-0003vA-Jg; Wed, 24 Mar 2021 21:05:32 +0000 Received: by outflank-mailman (input) for mailman id 101188; Wed, 24 Mar 2021 21:05:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPAh1-0003ua-OH for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 21:05:31 +0000 Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9be501b1-c198-4c1a-a5cd-fc9011a2206f; Wed, 24 Mar 2021 21:05:30 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12OL0j7I187125; Wed, 24 Mar 2021 21:05:28 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 37d8frc9p1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Mar 2021 21:05:27 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12OL0Xn2150299; Wed, 24 Mar 2021 21:05:27 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2169.outbound.protection.outlook.com [104.47.55.169]) by aserp3020.oracle.com with ESMTP id 37dty136n0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Mar 2021 21:05:26 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BYAPR10MB2840.namprd10.prod.outlook.com (2603:10b6:a03:86::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.24; Wed, 24 Mar 2021 21:05:24 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.025; Wed, 24 Mar 2021 21:05:24 +0000 Received: from bostrovs-us.us.oracle.com (209.17.40.43) by CH0PR03CA0142.namprd03.prod.outlook.com (2603:10b6:610:cf::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24 via Frontend Transport; Wed, 24 Mar 2021 21:05:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9be501b1-c198-4c1a-a5cd-fc9011a2206f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-type : mime-version; s=corp-2020-01-29; bh=rEhjasuVODHOAL7eJj8WuAaWQFsGT8zWCYIKpPNMGOw=; b=etzaccYZRe/0ikvXEDrvYN6seyZ8qPBaY61+R5RdAFJsfYDq7yC3s0vdQqkrE6w+yRqV YZj2f8LqjUwDqmEevVTHVXpbNlXvlo/d8z1uG9kGbCo2PD+7KYEjQfGdOPVPsbpbWDiu nLf0cbcNasZikKs1Gv8AKCs94qNT832GBjc5TvQkCr9uSEl0IgPuJtuWbdhjUDauTf6T gRjIP86ZY10r3TKDseciIwzgh6AV4BkiAkHKkB9XQ3oT5OdSTWZg289ZjNoGq/2Md0bD 97Cj/quvaitgWcIcw0re6R/aFA/LugrFYjjGTQi8qmiVtgh/NSf5KqAJFIdDb+53Z+kb xQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UJKN6UoHbO8Xr0mvC06kWf9NZU/HQrHqyYYqAoOeXUF5SzejgpLdGM6WwpenxI9bEryj6qULn35BR/TnCVI+Zd8N58OFmbfokRpNxro24Y5lg8tOSBz7WiWFmN03ZPFZppSCCKGwOQiQdmib276S0W5E46Q6CcXCzpW5lbOK61OM1gOQ6dIw8mpsNsJJ5pjkyKz7GDzP1grpgEunAlYuP5m0tUHdmGCXRgwshhg7c2CCV6+oqyKnB1HYyssIh1G4Tltil5FrhLFVN/AGeRRgLl60evWHv8bSznwIbfISoJUXPVj1foFoFEhqUMx/c5nxAIjisgnyDCHxXlJhpRFSSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rEhjasuVODHOAL7eJj8WuAaWQFsGT8zWCYIKpPNMGOw=; b=DQQHOY03lVQxl3DrOyNk+E6z5WOiodF6d99xlhnTFsmbQxJCGeL9q4szG3LKqYeK0uoxofmVFt9i6WBnXnUSXkOAl+9Urk/MJeZLLmfOMt7CoWjNWDHZYTFy6JoUOW8yj0wcK+4egJkv5jCn7p+j5M+w/Wgtn4i7VZDBieN4jGzlZdu+SFrl+FVB2Yfz+zvQtIPcddI6adNlQYmNpttkztdcMk5/7jFI6EwuTIgXk1cUwQmLLbra85tZ/NQ6odzjQlCt2GT8lINHhSsMUYo9AyCt2KeYNM1o+cYsHcB8/uAutOn48MbaN9D3Kkhh4FAlkxRaqmMFes6EtDiHxg6PPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rEhjasuVODHOAL7eJj8WuAaWQFsGT8zWCYIKpPNMGOw=; b=X/0humPjyaCMnkEP2QB9JT8lU+QcmDwMp4+SD/73zVcWft8qKxZEP1iqeq9WF42+RKf4XSFSjWwydmr6Z9e9LRzCRVvwdn8PhNHb9AYrwAHRGxSBHN6NRYcEIO8koDwhlaodQn1gpKXGLWlCGPgakoDifQKXRJ7QcWud9eXakBk= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; From: Boris Ostrovsky To: xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, boris.ostrovsky@oracle.com, stephen.s.brennan@oracle.com Subject: [PATCH RESEND] Performance regression due to XSA-336 Date: Wed, 24 Mar 2021 17:05:04 -0400 Message-Id: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> X-Mailer: git-send-email 1.8.3.1 Content-Type: text/plain X-Originating-IP: [209.17.40.43] X-ClientProxiedBy: CH0PR03CA0142.namprd03.prod.outlook.com (2603:10b6:610:cf::27) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 72a841c2-02bb-464d-be2a-08d8ef088b38 X-MS-TrafficTypeDiagnostic: BYAPR10MB2840: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UTIL58DB2AMKiMarFc5qXq3Nu5q2AQ1SxjnI120VxV+0qGW772m2JnLHk50KPLbJzd3hqoXJ6Oo2j1BEXh51nx5k5aeooJp2U8yAPsZYdA3bPkzw+59W/nZNRBpZarPz1WT6hySmHO2Szuz8PJ3wN4japvEXoI/4dWGCJy9bCkQOxS9X8UxntvGDU7A8C1ULDzCmt1vah7h2BIf4ZebtUy6oMaoALJZ9E1LGigLNv5g5S5zm5ir3TYnGP21dg+IDUbW7vtdVOaPdc3GeiugqCu4uHEbMcwY4/XolQKV3HooR7523n+osroe+YmTqvzmAs1gJuTfTAA8tILppFnE0v4iNngQXuzDidHxjcRKqizfUdMm/NzK7+iLe2BqBYR5Yb1Ip2qNMTQOgEjYGFzZjpcA3afj+CysWioW7x7YF/SUfuWojxAW2WZ1h0+z69zy3MLiE+bdU9yiSWJb83UjXTKqUg02HQsU63InEjtvUoE7Z127T+nfK853LOenq/UTrsmEIkE6Y3MIXXEaBlQNrCNNw6Cnkx7xPyTtNV81HKT851WvwD+Khmfy+PpVDMveiNg34cxO9BpC1bOv2uEycbkBo5+GUceN7K4umVotNTLx8/OjNXDx/icMd7siN/29YBWXRJ8OED2MHcfvlukbxQHE6eWLPL3pv13gvQIDbidI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(366004)(396003)(136003)(346002)(39860400002)(36756003)(26005)(107886003)(8676002)(66476007)(44832011)(316002)(186003)(38100700001)(8936002)(2616005)(66556008)(66946007)(4326008)(956004)(16526019)(6916009)(83380400001)(52116002)(7696005)(478600001)(5660300002)(6666004)(86362001)(6486002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?4YHm9dqPiASyEAP+bKbW2ARgRi4mBRo7hEyIKFtDbGkGqYc1kuKhm8pD5RKV?= =?us-ascii?Q?h3NK/FfV7u+hv0vIdLTMKY4tTwB/UQbI41FmbEbqlXKkwNodeH7W974ID2KZ?= =?us-ascii?Q?cV77apdgWabY0S8DHvuKT30K7Tia/787bJvHwzYO82nJAT22F8bXn8XV9/Ro?= =?us-ascii?Q?CPOPOLYR3FEtzriO13Xkkt62gV/+LLnUOWeS5uX8bnzjYRh83jW91+aSWbLD?= =?us-ascii?Q?mROfRXCwYIBENJwtMv95YT9DNfpChAZNOAU+ecYOXVhkxHT+JlfCwCf9EvBR?= =?us-ascii?Q?OomSp7D6a5HWiH7HaPonG6k3xxPD2c6uJXFR6C4srf5PI4LsS9y/iEcwMbW3?= =?us-ascii?Q?O6kS48/MbKHwJjSTh5nrHEbkOL5S1VYPiASuBKl7BFuDHRCLTi/P70mgH9MO?= =?us-ascii?Q?4Xd5F5yxsOq73nWumaSvdfo5Bd+GzL+3L9od+38XZZrjrMZteB6ySjO1hImG?= =?us-ascii?Q?XlN/Ka3QTfUGaXdyCjVAx35hbyBvOBaHYvtnXUQ8X2TknmBLFe3eWfvu9XIE?= =?us-ascii?Q?6u9VFZL/MY80RIowQXNw45w+P0JIexjH/+pZ0Xcd55M3pwdx/wgwVMIUQ5/L?= =?us-ascii?Q?o3y5luY2dix86o07xT6RgP4XgILbcWbLiN/jgh8tiBe44ZY+IPUO5e7vpgYa?= =?us-ascii?Q?U3GX+e4ePnD22osEy+1x5kyf12WWmiDYECJaDPIJeNYgszcbHq2nVTl7lO16?= =?us-ascii?Q?3STue+cX/GZMYy3T6/sCc+TTw7jwCTqO63I8h9upfQJFg2aePMV2G3jG3w81?= =?us-ascii?Q?SJ8enIpMeFe4vCEzkgBPhcFZi7Lk/zXvzf+hDfU7Q1yjoNDfdZcw/gMEGhqr?= =?us-ascii?Q?2AYLnkFtbs4c0NHWI05I7NEvbYtFbT+0RZ4rTHTmM7/BwrBr2ahKW6AY0hUU?= =?us-ascii?Q?pKuzNUUUmwKNQRwAr3xpCJ3Ssimkc7VwlAgl5f/wtsp1SeMiTlLrz5XVpnVZ?= =?us-ascii?Q?Ve63Gr224Jwus0/BVKYcSzL4+ZuFm9bao7MOMbeoHAHgmTVQQGyfDtbsw4Iv?= =?us-ascii?Q?GkyApSDpiiENKEjn5WnHjiVWQx6em94QRUKBwIwmE5QfkPsS/S2P331HAhS3?= =?us-ascii?Q?eas1WCWPFDg9ptz28+XTwqmjfaGLDsa8dxVUJFHf2wxOJ7sUFdxjaoKhS0tG?= =?us-ascii?Q?gT258fT2WzBo3Dhwjdj5418gYQz+IWJRvLabXJdKB06RUBs4npyv0ufdcVim?= =?us-ascii?Q?F1Ir0zBR/5H8vNv5uvzpP8jIkW6C+46VymcpeoQ4qBhNu/VEmjfjBAmuX7h+?= =?us-ascii?Q?FXBkAGC/ZIkmvIkMVaA3BFKUtiypN+5J4Ro4QIOB5YYDZ+vzJfOU6JO2Y22+?= =?us-ascii?Q?z5c3Juxnlw8jfSEkrIQUejrP?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72a841c2-02bb-464d-be2a-08d8ef088b38 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 21:05:24.9022 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iM21/D7eF/f3NrdaD3fB5ZgIv0As3dhxNDH5+cHn2shrDf0ISwv6/sM27Ax7RQOmWcnGp+NQJf9VEhp5+3DlUzTqw2r7q/Ha+sH3n6NqKYE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2840 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9933 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103240153 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9933 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 spamscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103240153 (Re-sending with Stephen added) While running performance tests with recent XSAs backports to our product we've discovered significant regression in TPCC performance. With a particular guest kernel the numbers dropped by as much as 40%. We've narrowed that down to XSA-336 patch, specifically to the pt_migrate rwlock, and even more specifically to this lock being taken in pt_update_irq(). We have quite a large guest (92 VCPUs) doing lots of VMEXITs and the theory is that lock's cnts atomic is starting to cause lots of coherence traffic. As a quick test of this replacing pt_vcpu_lock() in pt_update_irq() with just spin_lock(&v->arch.hvm_vcpu.tm_lock) gets us almost all performance back. Stephen Brennan came up with new locking algorithm, I just coded it up. A couple of notes: * We have only observed the problem and tested this patch for performance on a fairly old Xen version. However, vpt code is almost identical and I expect upstream to suffer from the same issue. * Stephen provided the following (slightly edited by me) writeup explaining the locking algorithm. I would like to include it somewhere but not sure what the right place would be. Commit message perhaps? Currently, every periodic_time is protected by locking the vcpu it is on. You can think of the per-vCPU lock (tm_lock) as protecting the fields of every periodic_time which is attached to that vCPU, as well as the list itself, and so it must be held when read or written, or when an object is added or removed to/from the list. It seems that there are three types of access to the peridic_time objects: 1. Functions which read (maybe write) all periodic_time instances attached to a particular vCPU. These are functions which use pt_vcpu_lock() after the commit, such as pt_restore_timer(), pt_save_timer(), etc. 2. Functions which want to modify a particular periodic_time object. These guys lock whichever vCPU the periodic_time is attached to, but since the vCPU could be modified without holding any lock, they are vulnerable to the bug. Functions in this group use pt_lock(), such as pt_timer_fn() or destroy_periodic_time(). 3. Functions which not only want to modify the periodic_time, but also would like to modify the =vcpu= fields. These are create_periodic_time() or pt_adjust_vcpu(). They create the locking imbalance bug for group 2, but we can't simply hold 2 vcpu locks due to the deadlock risk. My proposed option is to add a per-periodic_time spinlock, which protects only the periodic_time.vcpu field. Whenever reading the vcpu field of a periodic_time struct, you must first take that lock. The critical sections of group 1 (your "fast path" functions) would look like this: 1. lock vcpu 2. do whatever you want with pts currently on the vcpu. It is safe to read or write fields of pt, because the vcpu lock protects those fields. You simply cannot write pt->vcpu, because somebody holding the pt lock may already be spinning waiting for your vcpu lock. 3. unlock vcpu Note that there is no additional locking in this fast path. For group 2 functions (which are attempting to lock an individual periodic_time), the critical section would look like this: 1. lock pt lock (stabilizing the vcpu field) 2. lock vcpu 3. feel free to modify any field of the periodic_time 4. unlock vcpu (due to the mutual exclusion of the pt lock, we know that we are unlocking the correct vcpu -- we have not been migrated) 5. unlock pt For functions in group 3, the critical section would be: 1. lock pt (stabilizing the vcpu field) 2. lock current vcpu 3. remove from vcpu list 4. unlock vcpu. At this point, you're guaranteed that the vcpu functions (callers of pt_vcpu_lock()) are not accessing your pt. 5. assign pt->vcpu (we still have mutual exclusion against group 2 functions) 6. lock destination vcpu 7. add to vcpu list 8. unlock destination vcpu 9. unlock pt If functions from group 2 and 3 are less frequent, then you won't see too much added lock overhead in this situation! Plus, even if group 2 and 3 are somewhat common, the performance overhead of an uncontented fine-grained lock is muuch smaller than the overhead of a heavily contended coarse-grained lock, like the per-domain rw lock. Boris Ostrovsky (1): x86/vpt: Replace per-guest pt_migrate lock with per pt lock xen/arch/x86/emul-i8254.c | 2 + xen/arch/x86/hvm/hpet.c | 1 + xen/arch/x86/hvm/hvm.c | 2 - xen/arch/x86/hvm/rtc.c | 1 + xen/arch/x86/hvm/vlapic.c | 1 + xen/arch/x86/hvm/vpt.c | 122 +++++++++++++++++++++++------------------- xen/include/asm-x86/hvm/vpt.h | 9 +--- 7 files changed, 74 insertions(+), 64 deletions(-) -- 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 21:05:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 21:05:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101187.193364 (Exim 4.92) (envelope-from ) id 1lPAh2-0003uq-Eq; Wed, 24 Mar 2021 21:05:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101187.193364; Wed, 24 Mar 2021 21:05:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPAh2-0003uj-B2; Wed, 24 Mar 2021 21:05:32 +0000 Received: by outflank-mailman (input) for mailman id 101187; Wed, 24 Mar 2021 21:05:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPAh1-0003uZ-JO for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 21:05:31 +0000 Received: from aserp2120.oracle.com (unknown [141.146.126.78]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c92a9e70-2a49-4fd8-b3f6-ad0e0cb5fe08; Wed, 24 Mar 2021 21:05:30 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12OKxt9E103461; Wed, 24 Mar 2021 21:05:28 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 37d90mm8yb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Mar 2021 21:05:28 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12OL0Xn3150299; Wed, 24 Mar 2021 21:05:27 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2169.outbound.protection.outlook.com [104.47.55.169]) by aserp3020.oracle.com with ESMTP id 37dty136n0-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Mar 2021 21:05:27 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BYAPR10MB2840.namprd10.prod.outlook.com (2603:10b6:a03:86::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.24; Wed, 24 Mar 2021 21:05:26 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.025; Wed, 24 Mar 2021 21:05:26 +0000 Received: from bostrovs-us.us.oracle.com (209.17.40.43) by CH0PR03CA0142.namprd03.prod.outlook.com (2603:10b6:610:cf::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24 via Frontend Transport; Wed, 24 Mar 2021 21:05:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c92a9e70-2a49-4fd8-b3f6-ad0e0cb5fe08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=corp-2020-01-29; bh=mCJL1UVF0uGsPx6r2QxWvx1KIL6nSvrVsNJD9J0kgL4=; b=OIjQYUNIvaPLCrikIyVFJPUceL5rib1tBdSiytluybyi9BXc30DxSf4rxzA09u2w2R8j 8PzO+L+D2ZWeairLV3+QU/RR7tKojjHYpobn3NIb71fdXgYKG6vpxGoOg6yPJJyNXgn0 F/0zG0tMDrLk62aFgSRo2NLirt6Mr11TiWOlcDMfTKMY0D6RUbRsJHIhoYyzYyweWgqu qFU3kZnNbDcATJmsVb3dNrce0NUjXE4RcKD9rbdfHQoev0KC5XktJ/HfCMIJKqn62yuV AuJw6PGcGGFiXDgmr9GdiebCa0WAC/6BcTlAvTG68E5hI/ggaFYerNqlUqQyPgPWuC0U 3Q== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PUoOj4EOavOZADcFbzUFvcT51hwN5nYiiXxX4XeEhMIZ7MleGyrhuYnHmqSkJdvNAopHE7ux5VaoZjckiSzIrsAZWnxLOJjKd5JgroFKlgnBWEMLapIOjn6c52I4T+zJ0wNm5TeXrn74jg9AGo7RQ49KBh8wrWLaOFMGJdpi3fqZmYnfbc+MCWArTAVSRihBNakx6a5swZPumEql5Eu/KIsz0GVhR5yEGLoXsPgddyBddpQx02Ilj6ANJuaOfzeWakyyg9T7z4CQ/X/gduIsroBY6ff8O6D7IxrmACLWFhrS5HjOfHBmXofRrjxk/n3+GWmmAYxHKUCS3pLLYXvxWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mCJL1UVF0uGsPx6r2QxWvx1KIL6nSvrVsNJD9J0kgL4=; b=WS8Ag0fwHbmfQk4hkNiwlFdSJen6FoKlWqLEtTZSvtQIG64qkDOgYCTbpbLmN9Xk+PicobDz0NpXT3vGxroYo8mlrmvbHYLFIR9AbdsHfoel7FuuuGC8mFVfVbJj3amiLkAfbh/W2llkorrCxhrrgyCZpSIM0tZhSsgihWRZ60g7r59qnGK0mAidaKwnSfvM1bo4nELCKYQsKGIG54y3lfHj0jlEDImb7SlZP8x/ZGXfZzPl7AnKoXyIdhv8c6tGdC/vbRzIsb1M3ZizBOeU3WcszG59SOiBIu3WwJeqfRie53OTiKApWJ7QFICV5xpcusI93KNh/eb8U/jOvQ4TAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mCJL1UVF0uGsPx6r2QxWvx1KIL6nSvrVsNJD9J0kgL4=; b=qTgvj3qNd/3l6kIRt+UkeEhoPjlMSbUqEdfYdSaYZ1ChGxb86PN3UJEbI/BqSySNYjyTx3xgNCwTKtAGH68mHjG80OOp+KquCwiij5tQKDzNnNJZrn68Xr3SWLqqGxsvyeWL1apN635jvusovoxwYdCJVmwD2uTJRQcR5IUnpkM= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; From: Boris Ostrovsky To: xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, boris.ostrovsky@oracle.com, stephen.s.brennan@oracle.com Subject: [PATCH RESEND] x86/vpt: Replace per-guest pt_migrate lock with per pt lock Date: Wed, 24 Mar 2021 17:05:05 -0400 Message-Id: <1616619905-640-2-git-send-email-boris.ostrovsky@oracle.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> References: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain X-Originating-IP: [209.17.40.43] X-ClientProxiedBy: CH0PR03CA0142.namprd03.prod.outlook.com (2603:10b6:610:cf::27) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: be7f7965-bc39-416e-0051-08d8ef088be4 X-MS-TrafficTypeDiagnostic: BYAPR10MB2840: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:534; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gF7hY3hPhPTO8AopiIWlG2STahSupVrLwTnQXhqRIuGr3IbJ3lAsETH0Uj6NVDdmRQbu6W5saiTv759BVfsYZzBHOCa91gtNeMIrb1PPuFTxtsK1oirMBDSavIEk6wc6fTcWvN+eFGZHd0OeFwc1kTxvv6X9UMKuMkicIBWcQ1W6LaXwFd9Kvzmk51b8DmWDZ+kTh5KVGd4oj7YzO/eEyTl6Qobhm2uzpf3TUA5DtUH46URAwBajLCr+iK/FtuFNYcBDzTck1ct8w3ES9LCHj/YsaVsA+grXI1xJeEkXanyya7hrWkqN+Xh96k+iDAZIGNEy3BbXy5XH09Nzf34LcWFZ/B7Qk1yMHVN32vGUEB8NZrAwOJaoFYKajo2n8CdrSm/z2k9uQ7ftbX8ULfE/e6qbrsIHu0NlODaz0ZdKEPk8giwB1Zi69il3mkk2JiDndaL0oq/LrqdDl1b2kvUw36BY4r2pW/l3fZuuWXcsMLh/9yWENtDws8n0/DoT++Lla7djdKUnceAQg/yMkAzY5W/8HygW0Gc0F597SkkmhZuw6qdlTT7UW/j6PBqW8WCAeRHN2qm8UbUVHfqVfJIQxPk3RTcc7p4TxaCL5AUjH0jQ49mfUGmonh55bKI3OXnepRlGRhuaed6j2q1c3dtgkdqgEb/iMyZphf42z7fWzVI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(366004)(396003)(136003)(346002)(39860400002)(36756003)(26005)(107886003)(8676002)(66476007)(44832011)(316002)(186003)(38100700001)(8936002)(2616005)(66556008)(66946007)(4326008)(956004)(16526019)(6916009)(83380400001)(52116002)(7696005)(478600001)(5660300002)(30864003)(6666004)(86362001)(6486002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?/36/80BSE0/vHCJd9wdUCBWEjnc4B2hufUcIj08bvgOFdauySqpF5YTaJJbD?= =?us-ascii?Q?izjAErZtZ7W0zgkKgOWpOkJQ+HKA4W++6A18OzEz6h9f9mdxGYTAzYMueyGn?= =?us-ascii?Q?Gf24yiL+APBX0gABd4Fv/RtjCYzF6HUYQ2xXTsxwlunzDxUhKti2NX1q84aa?= =?us-ascii?Q?jdbgPRZGlrkPH1BQDVkwLTZQ9nVyBKaKLFczxjeh2MadLHIPpkDJoeAS8qqx?= =?us-ascii?Q?UEAYHgDB7C456ThVydOdfjHwfbM1NyzqNKcbtz1jt69lL+fshyxo4Hds1f+M?= =?us-ascii?Q?w+FTgb/J5Gp66Y7LZSEiVpDLb1oiL06xxhxHayn2aKTBXrc9XRYhey8JXy08?= =?us-ascii?Q?o/E5MTwAxvgMz3VTs6KjlP3ZLHLhK7BWAe9j7TU9uIL8m32XCjcR9ygWORvv?= =?us-ascii?Q?QL/M0fex0ZChF9k9JADaqhjIZo+ZPMkRneh5L3z+aCku0wfX8Mv7kYDH0dqv?= =?us-ascii?Q?0rFU7W/uOyRhUDqwYgj+4lbY7WzqGymzZxgLiAz+CVK5Yrwb312PHAx50ly+?= =?us-ascii?Q?MP9IJljZ9Ue/oNwcBqTp3opVGa+zlznPA/xKwBtPO9is2U7thYvVcBZWLpoA?= =?us-ascii?Q?7m8F1MRcjbajIPG2ZnozfcxQmgqCeF2J5KUOU4zIx64xW7PMeaglMXP5hcmX?= =?us-ascii?Q?yG5jMFEYR5lY/NdQkKaY4EnSi59H8UxQDbRd6N4zDT6Seo/0av6CVtzm8o0I?= =?us-ascii?Q?kF2MoGDnNAZzuLoc6+3BqoSsrBSDb5kh4Bok0US8Y45qtRWfuB1fMzLc6YPh?= =?us-ascii?Q?IyaakxIi8fQyE6AB509Auk0ZPWZ9XHfFt0uMtasHRjaMxMLBUTToXZE8W8Lc?= =?us-ascii?Q?/yUBIGUGjVJqgj8CAT2M9b/DuvFEffcaDeO+x1J76qoUa8uKFu5A7tACMHeI?= =?us-ascii?Q?tAFqZG6vsjaPFoSMXCHr4s5Lejl7/Z9WQaZAwG827rbWcgWggbhmiWYITN3U?= =?us-ascii?Q?0b777jJTVMVLWpCkADx0RGpa5UXe22+tOYrGviCsE0LBiBgDBDU5Un9M+Gi5?= =?us-ascii?Q?c3///HyMRHZoTdB5y8E0jsItYHpLS3pOVQo3Vj+yu4w/aKZc8LauWUZ65hmz?= =?us-ascii?Q?RwuJe6m1SVFEl5n+Iek1sM0j8yECZFO05UnbcFJQxto7yr6+MJiCh9D1An9r?= =?us-ascii?Q?z4Be98Bt/X+aspcmUhNPQTS3S5Z6fOGA/bctb/u9VcEJhSXNc1aYPcLsd/3Q?= =?us-ascii?Q?23allj36uQ/6G3F3BHxcd3iWoY2APBmAcvJP6V3PoxN/gybmxZOIxO182G2N?= =?us-ascii?Q?u/TPslYzBTTrqOl1xJ9AOq2eDHwWUJ9TResnjFPrs9QGwFx+rwIvgyJ9ZoSf?= =?us-ascii?Q?JuPFui/DT3zf7k0sqk6OfW+G?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: be7f7965-bc39-416e-0051-08d8ef088be4 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 21:05:25.9906 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k6VrotNMXlwkhZil5lCpS/Cg+CZ9VUMZ2oI4BEGRn0sPP6fIjqm+9drvySKoCq/FzsGjdaDXh44fUR5vPilEVT6qF4J0/I5oW1RCVvKiJr0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2840 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9933 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103240153 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9933 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 clxscore=1015 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103240153 Commit 8e76aef72820 ("x86/vpt: fix race when migrating timers between vCPUs") addressed XSA-336 by introducing a per-domain rwlock that was intended to protect periodic timer during VCPU migration. Since such migration is an infrequent event no performance impact was expected. Unfortunately this turned out not to be the case: on a fairly large guest (92 VCPUs) we've observed as much as 40% TPCC performance regression with some guest kernels. Further investigation pointed to pt_migrate read lock taken in pt_update_irq() as the largest contributor to this regression. With large number of VCPUs and large number of VMEXITs (from where pt_update_irq() is always called) the update of an atomic in read_lock() is thought to be the main cause. Stephen Brennan examined the locking pattern and suggested using a per-timer lock instead. This lock will need to be held whenever there is a chance that pt->vcpu field may change (thus avoiding XSA-336 condition). Suggested-by: Stephen Brennan Signed-off-by: Boris Ostrovsky --- xen/arch/x86/emul-i8254.c | 2 + xen/arch/x86/hvm/hpet.c | 1 + xen/arch/x86/hvm/hvm.c | 2 - xen/arch/x86/hvm/rtc.c | 1 + xen/arch/x86/hvm/vlapic.c | 1 + xen/arch/x86/hvm/vpt.c | 122 +++++++++++++++++++++++------------------- xen/include/asm-x86/hvm/vpt.h | 9 +--- 7 files changed, 74 insertions(+), 64 deletions(-) diff --git a/xen/arch/x86/emul-i8254.c b/xen/arch/x86/emul-i8254.c index 73be4188ad41..d83e727ff35e 100644 --- a/xen/arch/x86/emul-i8254.c +++ b/xen/arch/x86/emul-i8254.c @@ -478,6 +478,8 @@ void pit_init(struct domain *d, unsigned long cpu_khz) if ( !has_vpit(d) ) return; + spin_lock_init(&pit->pt0.lock); + spin_lock_init(&pit->lock); if ( is_hvm_domain(d) ) diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c index ca94e8b4538c..c7f45412164e 100644 --- a/xen/arch/x86/hvm/hpet.c +++ b/xen/arch/x86/hvm/hpet.c @@ -734,6 +734,7 @@ static void hpet_set(HPETState *h) h->hpet.timers[i].cmp = ~0ULL; h->hpet.comparator64[i] = ~0ULL; h->pt[i].source = PTSRC_isa; + spin_lock_init(&h->pt[i].lock); } } diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index e7bcffebc490..b60549a12a33 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -658,8 +658,6 @@ int hvm_domain_initialise(struct domain *d) /* need link to containing domain */ d->arch.hvm.pl_time->domain = d; - rwlock_init(&d->arch.hvm.pl_time->pt_migrate); - /* Set the default IO Bitmap. */ if ( is_hardware_domain(d) ) { diff --git a/xen/arch/x86/hvm/rtc.c b/xen/arch/x86/hvm/rtc.c index 3150f5f1479b..6289d972bb67 100644 --- a/xen/arch/x86/hvm/rtc.c +++ b/xen/arch/x86/hvm/rtc.c @@ -842,6 +842,7 @@ void rtc_init(struct domain *d) } spin_lock_init(&s->lock); + spin_lock_init(&s->pt.lock); init_timer(&s->update_timer, rtc_update_timer, s, smp_processor_id()); init_timer(&s->update_timer2, rtc_update_timer2, s, smp_processor_id()); diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index 5e21fb4937d9..8413e41a7a80 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -1626,6 +1626,7 @@ int vlapic_init(struct vcpu *v) vlapic_reset(vlapic); spin_lock_init(&vlapic->esr_lock); + spin_lock_init(&vlapic->pt.lock); tasklet_init(&vlapic->init_sipi.tasklet, vlapic_init_sipi_action, v); diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index 4c2afe2e9154..36d4699a5de6 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -153,32 +153,16 @@ static int pt_irq_masked(struct periodic_time *pt) return 1; } -static void pt_vcpu_lock(struct vcpu *v) -{ - read_lock(&v->domain->arch.hvm.pl_time->pt_migrate); - spin_lock(&v->arch.hvm.tm_lock); -} - -static void pt_vcpu_unlock(struct vcpu *v) -{ - spin_unlock(&v->arch.hvm.tm_lock); - read_unlock(&v->domain->arch.hvm.pl_time->pt_migrate); -} - static void pt_lock(struct periodic_time *pt) { - /* - * We cannot use pt_vcpu_lock here, because we need to acquire the - * per-domain lock first and then (re-)fetch the value of pt->vcpu, or - * else we might be using a stale value of pt->vcpu. - */ - read_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); + spin_lock(&pt->lock); spin_lock(&pt->vcpu->arch.hvm.tm_lock); } static void pt_unlock(struct periodic_time *pt) { - pt_vcpu_unlock(pt->vcpu); + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); + spin_unlock(&pt->lock); } static void pt_process_missed_ticks(struct periodic_time *pt) @@ -228,7 +212,7 @@ void pt_save_timer(struct vcpu *v) if ( v->pause_flags & VPF_blocked ) return; - pt_vcpu_lock(v); + spin_lock(&v->arch.hvm.tm_lock); list_for_each_entry ( pt, head, list ) if ( !pt->do_not_freeze ) @@ -236,7 +220,7 @@ void pt_save_timer(struct vcpu *v) pt_freeze_time(v); - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); } void pt_restore_timer(struct vcpu *v) @@ -244,7 +228,7 @@ void pt_restore_timer(struct vcpu *v) struct list_head *head = &v->arch.hvm.tm_list; struct periodic_time *pt; - pt_vcpu_lock(v); + spin_lock(&v->arch.hvm.tm_lock); list_for_each_entry ( pt, head, list ) { @@ -257,7 +241,7 @@ void pt_restore_timer(struct vcpu *v) pt_thaw_time(v); - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); } static void pt_timer_fn(void *data) @@ -318,7 +302,7 @@ int pt_update_irq(struct vcpu *v) int irq, pt_vector = -1; bool level; - pt_vcpu_lock(v); + spin_lock(&v->arch.hvm.tm_lock); earliest_pt = NULL; max_lag = -1ULL; @@ -348,7 +332,7 @@ int pt_update_irq(struct vcpu *v) if ( earliest_pt == NULL ) { - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); return -1; } @@ -356,7 +340,7 @@ int pt_update_irq(struct vcpu *v) irq = earliest_pt->irq; level = earliest_pt->level; - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); switch ( earliest_pt->source ) { @@ -403,7 +387,7 @@ int pt_update_irq(struct vcpu *v) time_cb *cb = NULL; void *cb_priv = NULL; - pt_vcpu_lock(v); + spin_lock(&v->arch.hvm.tm_lock); /* Make sure the timer is still on the list. */ list_for_each_entry ( pt, &v->arch.hvm.tm_list, list ) if ( pt == earliest_pt ) @@ -413,7 +397,7 @@ int pt_update_irq(struct vcpu *v) cb_priv = pt->priv; break; } - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); if ( cb != NULL ) cb(v, cb_priv); @@ -450,12 +434,12 @@ void pt_intr_post(struct vcpu *v, struct hvm_intack intack) if ( intack.source == hvm_intsrc_vector ) return; - pt_vcpu_lock(v); + spin_lock(&v->arch.hvm.tm_lock); pt = is_pt_irq(v, intack); if ( pt == NULL ) { - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); return; } @@ -464,7 +448,7 @@ void pt_intr_post(struct vcpu *v, struct hvm_intack intack) cb = pt->cb; cb_priv = pt->priv; - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); if ( cb != NULL ) cb(v, cb_priv); @@ -475,12 +459,34 @@ void pt_migrate(struct vcpu *v) struct list_head *head = &v->arch.hvm.tm_list; struct periodic_time *pt; - pt_vcpu_lock(v); + spin_lock(&v->arch.hvm.tm_lock); list_for_each_entry ( pt, head, list ) migrate_timer(&pt->timer, v->processor); - pt_vcpu_unlock(v); + spin_unlock(&v->arch.hvm.tm_lock); +} + +static void __destroy_periodic_time(struct periodic_time *pt, bool locked) +{ + /* Was this structure previously initialised by create_periodic_time()? */ + if ( pt->vcpu == NULL ) + return; + + if (!locked) + pt_lock(pt); + if ( pt->on_list ) + list_del(&pt->list); + pt->on_list = 0; + pt->pending_intr_nr = 0; + if (!locked) + pt_unlock(pt); + + /* + * pt_timer_fn() can run until this kill_timer() returns. We must do this + * outside pt_lock() otherwise we can deadlock with pt_timer_fn(). + */ + kill_timer(&pt->timer); } void create_periodic_time( @@ -497,9 +503,16 @@ void create_periodic_time( return; } - destroy_periodic_time(pt); + spin_lock(&pt->lock); - write_lock(&v->domain->arch.hvm.pl_time->pt_migrate); + if ( pt->vcpu ) + { + spin_lock(&pt->vcpu->arch.hvm.tm_lock); + + __destroy_periodic_time(pt, true); + + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); + } pt->pending_intr_nr = 0; pt->do_not_freeze = 0; @@ -543,33 +556,22 @@ void create_periodic_time( pt->cb = cb; pt->priv = data; + spin_lock(&pt->vcpu->arch.hvm.tm_lock); + pt->on_list = 1; list_add(&pt->list, &v->arch.hvm.tm_list); + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); + init_timer(&pt->timer, pt_timer_fn, pt, v->processor); set_timer(&pt->timer, pt->scheduled); - write_unlock(&v->domain->arch.hvm.pl_time->pt_migrate); + spin_unlock(&pt->lock); } void destroy_periodic_time(struct periodic_time *pt) { - /* Was this structure previously initialised by create_periodic_time()? */ - if ( pt->vcpu == NULL ) - return; - - pt_lock(pt); - if ( pt->on_list ) - list_del(&pt->list); - pt->on_list = 0; - pt->pending_intr_nr = 0; - pt_unlock(pt); - - /* - * pt_timer_fn() can run until this kill_timer() returns. We must do this - * outside pt_lock() otherwise we can deadlock with pt_timer_fn(). - */ - kill_timer(&pt->timer); + __destroy_periodic_time(pt, false); } static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) @@ -579,15 +581,25 @@ static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) if ( pt->vcpu == NULL ) return; - write_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); + spin_lock(&pt->lock); + spin_lock(&pt->vcpu->arch.hvm.tm_lock); + + if ( pt->on_list ) + list_del(&pt->list); + + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); + pt->vcpu = v; + + spin_lock(&pt->vcpu->arch.hvm.tm_lock); if ( pt->on_list ) { - list_del(&pt->list); list_add(&pt->list, &v->arch.hvm.tm_list); migrate_timer(&pt->timer, v->processor); } - write_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); + + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); + spin_unlock(&pt->lock); } void pt_adjust_global_vcpu_target(struct vcpu *v) diff --git a/xen/include/asm-x86/hvm/vpt.h b/xen/include/asm-x86/hvm/vpt.h index 39d26cbda496..b0f4af25828b 100644 --- a/xen/include/asm-x86/hvm/vpt.h +++ b/xen/include/asm-x86/hvm/vpt.h @@ -49,6 +49,8 @@ struct periodic_time { u64 last_plt_gtime; /* platform time when last IRQ is injected */ struct timer timer; /* ac_timer */ time_cb *cb; + spinlock_t lock; /* protects vcpu field during PT migration. */ + /* Needs to be taken before VCPU's tm_lock. */ void *priv; /* point back to platform time source */ }; @@ -128,13 +130,6 @@ struct pl_time { /* platform time */ struct RTCState vrtc; struct HPETState vhpet; struct PMTState vpmt; - /* - * rwlock to prevent periodic_time vCPU migration. Take the lock in read - * mode in order to prevent the vcpu field of periodic_time from changing. - * Lock must be taken in write mode when changes to the vcpu field are - * performed, as it allows exclusive access to all the timers of a domain. - */ - rwlock_t pt_migrate; /* guest_time = Xen sys time + stime_offset */ int64_t stime_offset; /* Ensures monotonicity in appropriate timer modes. */ -- 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 22:26:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 22:26:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101200.193387 (Exim 4.92) (envelope-from ) id 1lPBx9-0003aj-J6; Wed, 24 Mar 2021 22:26:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101200.193387; Wed, 24 Mar 2021 22:26:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPBx9-0003ac-G9; Wed, 24 Mar 2021 22:26:15 +0000 Received: by outflank-mailman (input) for mailman id 101200; Wed, 24 Mar 2021 22:26:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPBx7-0003aU-HM; Wed, 24 Mar 2021 22:26:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPBx7-0002uj-8Z; Wed, 24 Mar 2021 22:26:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPBx6-0000NS-WD; Wed, 24 Mar 2021 22:26:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPBx6-0007Ec-U7; Wed, 24 Mar 2021 22:26:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wrtSqFksbsJBknfjywmX+ZC21zb/foT/YKUji2MNS6k=; b=CiDIyJXuHKbTY0C6tS7xcZjwWC TLdZ7nNgQk5jDtzn/WrX8sfXKfdsbNSC/9UACg/SxV4v2dD7ap5WdbWmiqvokJuQQwq+YXbJDMxFh iIWUWYfGQHrNaGf39h/yMJrRZUK2Q3IKmHeIwPb6ZbIxtN1bUhMB+R1mEO73xUNFm4h8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160370: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:heisenbug xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Wed, 24 Mar 2021 22:26:12 +0000 flight 160370 xen-4.12-testing real [real] flight 160398 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160370/ http://logs.test-lab.xenproject.org/osstest/logs/160398/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail in 160344 REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 160344 pass in 160370 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 160344 pass in 160370 test-amd64-amd64-xl-qcow2 18 guest-saverestore.2 fail pass in 160344 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 36 days Failing since 160128 2021-03-18 14:36:18 Z 6 days 6 attempts Testing same since 160150 2021-03-20 04:11:48 Z 4 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 24 23:05:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 23:05:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101211.193409 (Exim 4.92) (envelope-from ) id 1lPCZL-0007h1-0I; Wed, 24 Mar 2021 23:05:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101211.193409; Wed, 24 Mar 2021 23:05:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPCZK-0007gu-Sf; Wed, 24 Mar 2021 23:05:42 +0000 Received: by outflank-mailman (input) for mailman id 101211; Wed, 24 Mar 2021 23:05:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPCZJ-0007gp-GU for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 23:05:41 +0000 Received: from mail-qt1-x82c.google.com (unknown [2607:f8b0:4864:20::82c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ee4404f4-84b5-47ef-bcc3-8101b4c863fa; Wed, 24 Mar 2021 23:05:40 +0000 (UTC) Received: by mail-qt1-x82c.google.com with SMTP id x9so360612qto.8 for ; Wed, 24 Mar 2021 16:05:40 -0700 (PDT) Received: from Slackware.localdomain ([156.146.55.193]) by smtp.gmail.com with ESMTPSA id i14sm2469165qtq.81.2021.03.24.16.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 16:05:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee4404f4-84b5-47ef-bcc3-8101b4c863fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=v9ZgYPAV5pW+3XJfUObq1OKDOd+yO9AzIKh8BGAyxbg=; b=KzoKhamrTRrMxphlj7fx+9rr9/duDd3NAJV74WetzwLcxfGF3aWdxrJqDlaEjdcZv8 OGjEIzp0SQ865SEX0+Pa960oUbKrZhLJS9+WSRLofUM6rCn1r/S23A57nfMMSG5QPxA4 U28uMnTQ2xZTkb6DXHm6vPi9TGRanq/4ebhS99MxtVGCNVjyWMAIPnkdwte29XDHKVG5 9gjU1dRChcSTbYXnpVmiSW+2mfVIgVsd6OxyD1BRKGAu8eaWq7HAwnaafzrlFYt7VZmn hF/QbXeIx8C8LB4w00jJrnhj3NhbTSGpNLbhUa8dylq7TsE8u5Eq6ylnrNfEtXJKMS3j g/UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=v9ZgYPAV5pW+3XJfUObq1OKDOd+yO9AzIKh8BGAyxbg=; b=YyiMpMAywjwzFyMxTosA8J3A7EX0OUyghEussVp54OJxxOaZDd2EZzyIdVHHjQBkUv ThMhPBDQ8xa5j5NNwYY0y6S9psEUUgLPDU4O6Ida89pfqYRkUtWlZ0bo6VTFkH6NeW04 zduHeEaMyv05KbXbEuidJLPuBEd4U8s/ysZU018XsmhbfMCgWenL1hXFWHj12hzkCV6c oVAneAoVMw1h+qYmKHKQX9xS4g6nmNgfwVCBNkidJ7niFQz3VxpwoBL/3Ou6kGofyo1M RwCzPM2MXgidaXFN7foHQ0CSyoD2qdl1Baql19nuFBbmv/E0MN4A9HlKOhD2bStW+dio 8Gpg== X-Gm-Message-State: AOAM5311OWTS9dTZSGTa9zGT0AeOn+lZ08nF4OM+cUsbw5OOKCbUrFXs aEGszANht8CrjqHsN+88lX4= X-Google-Smtp-Source: ABdhPJz2BebuSA40Vdzk5htYesmp/PuEjJIxloaJ2qKs7iFRMQWVilb2ccB524lYZyZ9FyJ9LxGEQg== X-Received: by 2002:ac8:777c:: with SMTP id h28mr5133646qtu.63.1616627140346; Wed, 24 Mar 2021 16:05:40 -0700 (PDT) From: Bhaskar Chowdhury To: sstabellini@kernel.org, linux@armlinux.org.uk, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: rdunlap@infradead.org, Bhaskar Chowdhury Subject: [PATCH V2] ARM: xen/mm.c: A mundane typo fix Date: Thu, 25 Mar 2021 10:05:26 +0530 Message-Id: <20210325043526.16289-1-unixbhaskar@gmail.com> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit s/acrros/across/ Plus some words need prural version...so did it.(page->pages) Signed-off-by: Bhaskar Chowdhury --- Changes from V1: Randy's findings incorporated. arch/arm/xen/mm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c index 467fa225c3d0..8596dd32dcd5 100644 --- a/arch/arm/xen/mm.c +++ b/arch/arm/xen/mm.c @@ -105,8 +105,8 @@ bool xen_arch_need_swiotlb(struct device *dev, * - The Linux page refers to foreign memory * - The device doesn't support coherent DMA request * - * The Linux page may be spanned acrros multiple Xen page, although - * it's not possible to have a mix of local and foreign Xen page. + * The Linux page may be spanned across multiple Xen pages, although + * it's not possible to have a mix of local and foreign Xen pages. * Furthermore, range_straddles_page_boundary is already checking * if buffer is physically contiguous in the host RAM. * -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 24 23:07:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 23:07:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101215.193421 (Exim 4.92) (envelope-from ) id 1lPCaw-0007nw-BE; Wed, 24 Mar 2021 23:07:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101215.193421; Wed, 24 Mar 2021 23:07:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPCaw-0007np-7d; Wed, 24 Mar 2021 23:07:22 +0000 Received: by outflank-mailman (input) for mailman id 101215; Wed, 24 Mar 2021 23:07:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPCau-0007nk-Ib for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 23:07:20 +0000 Received: from mail-qk1-x729.google.com (unknown [2607:f8b0:4864:20::729]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2efdf1de-2b15-471e-af28-c7949d341672; Wed, 24 Mar 2021 23:07:19 +0000 (UTC) Received: by mail-qk1-x729.google.com with SMTP id y18so17424qky.11 for ; Wed, 24 Mar 2021 16:07:19 -0700 (PDT) Received: from Slackware ([156.146.55.193]) by smtp.gmail.com with ESMTPSA id m13sm2793041qkm.103.2021.03.24.16.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 16:07:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2efdf1de-2b15-471e-af28-c7949d341672 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=unU9mIXis029RymGHdH7V1zjjWKUJpo7L/5r2jBdOHw=; b=Aw54LjN39oNkovcR3V4TfpdwnEylMj/oVtzW/NXQdaYCxg3Z1Ec6YWTJf/U+L1LIjf 35ZXylU6/XHmVtfM6knNs2/JPE81nifQvV5LbfJPqpX/txjlJFIpkoNMXSvXNR45JeN4 scwViwmTM2ZaZcE4fK8t6bREcUD+COLNZBIQkktPUelFaQ64yTnrwNX3B7V0pGztfYQY UHxVmGhKa4Vcmg8LjpzVCWi5T78/dOtGgBzxKDzrdcJHyIjkuM24Fcc8qbKHGFlWy6Qo p3HTj2YIogqMHlwBlzT5cTsiAG43mqH3xFT3Ei4RnVgk6mk9UtlMkWge4kpsPogcioxs IXiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=unU9mIXis029RymGHdH7V1zjjWKUJpo7L/5r2jBdOHw=; b=KiY/HP2VnjxerkZwPysWLZlW+0vJTqQ5Hs7+6fBiQVGwoMIV+67bbcWu90iAX+GuMJ lhjM58mGlIIOebaDPDUioxsyFAAUoODkgBM4ADhTXALxdOj661jvNpluJ+pFQO/Aj4sF 5Um71Qda/+wsqDm8aFyLODx0s9Lv3WixDanO/K7bBrvUbu3tb1xHLrQKNIm70/9xURCC +R2rvlSsFdnaUlM7ZUQC1vKh9lCmzq61OvHbgObSR8LbGWtXy4wsdaIjv5gB+vIq/Ox8 RCxo4TIaA3IbjWldDssx6ksYraaMUHIG4N6WLZBEbgcJZPxH2Gc7nkUGFRFaD1Olgo/G IdDw== X-Gm-Message-State: AOAM531aU1YX3mnH9E5JtcVaaz7oPGcd4jhskeW0ZFEwLZXLSdyzP2h8 9aPvQOMV80kQgBFqd0qHmnE= X-Google-Smtp-Source: ABdhPJy0XDX6xf+AUtITEYmLy/Evqhue1H4jw/H6OCKGGRWyxuZQkdH3VsEtvbV9hUJzchPL3P/mIA== X-Received: by 2002:a37:2749:: with SMTP id n70mr5477245qkn.105.1616627239714; Wed, 24 Mar 2021 16:07:19 -0700 (PDT) Date: Thu, 25 Mar 2021 10:07:08 +0530 From: Bhaskar Chowdhury To: Randy Dunlap Cc: Stefano Stabellini , linux@armlinux.org.uk, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jgross@suse.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH] ARM: xen/mm.c: A mundane typo fix Message-ID: Mail-Followup-To: Bhaskar Chowdhury , Randy Dunlap , Stefano Stabellini , linux@armlinux.org.uk, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jgross@suse.com, boris.ostrovsky@oracle.com References: <20210324133036.17665-1-unixbhaskar@gmail.com> <5e1b573a-6dc7-7f28-28ae-c509e6782fbf@infradead.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TCrfE9v/6+6uxuTN" Content-Disposition: inline In-Reply-To: <5e1b573a-6dc7-7f28-28ae-c509e6782fbf@infradead.org> --TCrfE9v/6+6uxuTN Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On 11:59 Wed 24 Mar 2021, Randy Dunlap wrote: >On 3/24/21 11:55 AM, Stefano Stabellini wrote: >> On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote: >>> s/acrros/across/ >>> >>> Signed-off-by: Bhaskar Chowdhury >> >> Reviewed-by: Stefano Stabellini >> >> > >Hi, >It seems to me like some of those "page" should be "pages". > >>> --- >>> arch/arm/xen/mm.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c >>> index 467fa225c3d0..be7c942c74bf 100644 >>> --- a/arch/arm/xen/mm.c >>> +++ b/arch/arm/xen/mm.c >>> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev, >>> * - The Linux page refers to foreign memory >>> * - The device doesn't support coherent DMA request >>> * >>> - * The Linux page may be spanned acrros multiple Xen page, although>> + * The Linux page may be spanned across multiple Xen page, although > > pages, > >>> * it's not possible to have a mix of local and foreign Xen page. > > pages. > >>> * Furthermore, range_straddles_page_boundary is already checking >>> * if buffer is physically contiguous in the host RAM. >>> -- > Thank you....I have sent a V2 now. > > >~Randy > --TCrfE9v/6+6uxuTN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEnwF+nWawchZUPOuwsjqdtxFLKRUFAmBcE20ACgkQsjqdtxFL KRUvIggA0Bu+io2ijz60vfhZz7xZNVSid1OoUl1Om/MMq2kve/J9NbkNzt7dGSaO Nb8vdiEZT77497MkjBJ8U/pxck9POJdv7RJ4S5s949pPcbuP6PsGhlzk35nN7NqM vZ42o9L0cEtLrIrAxWtl3Rscy6x7W90BHhDMhix174CXg5S8ciQ+MCPdo3EyBwuN crlJJJZ6VbQiaxOkjGnxyRobSz+WpFCJa/XPioII8xf3p854qdgbVE0GLRaC5f9y koN0TLULWOVyX8tm1LOkP8ACv6wIQehPlFCkxRLk8C67CUdmQdx+Mz/u6hQK54K2 WjwbqPHASv5QkWa+p9PHbF+GjV7yqg== =PKSI -----END PGP SIGNATURE----- --TCrfE9v/6+6uxuTN-- From xen-devel-bounces@lists.xenproject.org Wed Mar 24 23:10:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 23:10:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101221.193433 (Exim 4.92) (envelope-from ) id 1lPCdc-0000PG-Pb; Wed, 24 Mar 2021 23:10:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101221.193433; Wed, 24 Mar 2021 23:10:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPCdc-0000P9-MA; Wed, 24 Mar 2021 23:10:08 +0000 Received: by outflank-mailman (input) for mailman id 101221; Wed, 24 Mar 2021 23:10:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPCda-0000L6-SD for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 23:10:07 +0000 Received: from userp2120.oracle.com (unknown [156.151.31.85]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fb2f6a94-c328-4ed2-a7eb-1251200842c7; Wed, 24 Mar 2021 23:10:06 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12ONA2xb038970; Wed, 24 Mar 2021 23:10:02 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 37d9pn4g4u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Mar 2021 23:10:02 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12ON4tsp155571; Wed, 24 Mar 2021 23:09:57 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2174.outbound.protection.outlook.com [104.47.56.174]) by userp3030.oracle.com with ESMTP id 37du00fc8h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Mar 2021 23:09:57 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BYAPR10MB2632.namprd10.prod.outlook.com (2603:10b6:a02:b2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.23; Wed, 24 Mar 2021 23:09:55 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.025; Wed, 24 Mar 2021 23:09:55 +0000 Received: from [10.74.100.232] (138.3.201.40) by BYAPR08CA0053.namprd08.prod.outlook.com (2603:10b6:a03:117::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Wed, 24 Mar 2021 23:09:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb2f6a94-c328-4ed2-a7eb-1251200842c7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=Io2lAihE3mQOuQ7rki9suM4viVm/JFb91YPnIilRCI8=; b=Py5k8o6l/pgPCAR7DEx9bYMqNKJOuzBB1gOZ3ig9hdVpySreWYt/U5TGwpZ5H190seEM JO2n8iivHCmv5b+Vbkk2Z17KP5lopNMJMK/pK4rTah9UqBZbKeTfQ221sQCMERa6mgJL 7sH0Z+S0AY6PUJE1qGOTq4ujfcMyv610Co0OvMtOrOJh4dqzk6TqeaOsUDgKNwkwlDzv NYOxFBRLfRz8Peg0jhZ4pymWUnBtzS9vP318eiqgEwtFeXYuS0F8R8QXetmbrObxE598 +aNf2MroNep2X7w3HtX70bk2WHesjj01dLKe/d2SCFTq1ZR3nABni5tYG6XPPsH7DXDe Jw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BcTG725W8jhbRDeKi+s7n2vqKNSEmb1l3VYfTnaKMr9BksxkE9jxabsdo9tfLeFUYrsqGDIGE8YXnRT44jcL8/xJvF9RNWKGMbcEkQ7Vpe8oXGm33oz4xrVee3f/SLJZWPjPCs8UNCWNkF2h8KmMhFaGjh/lZvleI/91xgEBFspvL2JOYQa4e3gwNew60jIhrrjcWsLfmDwanOYdHH/y2iA4L8qt/8xdOhjz4g28AH+Hk7hI0RbMsnpUmMvuJPlJz80D2hLv2FYZZIrh60AZWNEBv1cuvlQsv0J9vrWR0+FW+YfoDQ0ZVC94lHX3TennUIaRMyt24KLvXkANjbIEog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Io2lAihE3mQOuQ7rki9suM4viVm/JFb91YPnIilRCI8=; b=JRLDFR2UguDD5VfbX/PBw4YtNpt3x/EUyByI3GNGVJQGiwlOCVIUfBsvoAWntb1XvreE+1wlAaIwfAM/5gYEBod4COFJ45AiUbGTdCuggqZbS8OsrJ09AUy2KKAIk2DJ535FAvFBGoLKwTUnDzY+Zd7tfBjKgIO3DhDwNvqGhrEpHea6OMAZxJusxYOVfRoV8hR1mR+5b2I3N5v2fXuRwwxO3Q81Fwj77XVZWFcOkbB66ykzNg5NUNYmgZx+/ufixRDVgH9pxJzVv+W8+arD5nW61kG4HBs5uyWAKYAuCUyGsTFEf+SWdQbt/WJ+r6h/Qo8qOgAaKQW1se9/kBPlKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Io2lAihE3mQOuQ7rki9suM4viVm/JFb91YPnIilRCI8=; b=Ha9MghV2NBbBh9wQGSI4JQ9+HHEoIppGIzHImk0iThVRoG6FG7PScBDbBVnx+tidiaRC7nYDmljIKn8/6GRkvz3GCa0SBxX/vZLOGmH7DcUghggDg207AzkG6jrQXUtyTwSyxHaRubwJ48YxO9iUpsQzIeThkTuC6TA06Sqqw8M= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH v2 0/2] xen/x86: alternative fix for XSA-369 To: Roger Pau Monne , linux-kernel@vger.kernel.org Cc: Juergen Gross , Stefano Stabellini , Jan Beulich , xen-devel@lists.xenproject.org References: <20210324122424.58685-1-roger.pau@citrix.com> From: Boris Ostrovsky Message-ID: <6b70700e-667b-03a7-8f5e-937d5c45c79d@oracle.com> Date: Wed, 24 Mar 2021 19:09:51 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210324122424.58685-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [138.3.201.40] X-ClientProxiedBy: BYAPR08CA0053.namprd08.prod.outlook.com (2603:10b6:a03:117::30) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ba059265-bd32-4aec-fb63-08d8ef19efd2 X-MS-TrafficTypeDiagnostic: BYAPR10MB2632: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ckQb0z20JdOZYGvomBOSsv1UDlYotxz6NLc7tQKpsJQ+P1MrejO8LFokvU+39nELzUV0jz0lUR+Fot4sL/CbN2WteKe9Ldo5H8yOywoyxyTk2lMIMfSGByJavwiwZSm5DkiKo3vEbLl8AGCzeL05UgFwPOZ7O5mddF+lwRmRGEdzzAbd59N5Syoe7PAZc/m0ZkzP7q1Vuke9MUkVAEnFvpghSkmGy0N5VNy3VqfXMULTlK71Cbp7smJjXuUKVYNjyUQ+uS0dQcKiamTm2pP4AeEH1tEj9euiDBnUUhg4ql99twELCkDeKBEGbqJNMZfH40LNaPzE9BBzrpTXGZfzJWM5uwRmqnyyPcZwmxIBrdYASSob6CthaqpKlzPTUHGc5HuAisQuAJsMfo8W9rk2mVjP86gGTE0wSw7uaOVbIwvp198Pyui9bG6q+vGGMMFTwOvWGSE6sLt0bX4AG8jzMuwLqXsT63OEydylbXoZIRig+byucEVyw5XEPcfpWfqrycxFQBNWh/WL/l0ZfrQmm2ZRqDA1CaAkDHFjUIiQOpbDymBPW9LzSlXZ9xh1On6EhFfA3XyxUlmBh5PR6mCsDlqQp2+ZcnneD9HdFOmhHZhNviTFFGUojwQptvFHUPkAGvh82BLoIuaeWMIjhoG+2OG6LHFpweQDiR52LkPoXPKyblyF00B3qw4Xt+QMwC0V6rqPC0ZOZlI9yyhRGDgAgk1HtIlllh5ayHGheS0dXf0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(376002)(346002)(39860400002)(136003)(366004)(2616005)(956004)(8936002)(44832011)(478600001)(8676002)(38100700001)(5660300002)(2906002)(53546011)(54906003)(16576012)(16526019)(86362001)(36756003)(66556008)(31686004)(316002)(4326008)(6486002)(83380400001)(31696002)(186003)(26005)(66946007)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Lys2RGZSZFFuUTdNQ21uL255Z3hVeDk0eVZlM3IyNVBCaDBNcDJKMC8rUGlW?= =?utf-8?B?SVJhTkJ0bjJRMkRKUng1bS95ZGV1UkllUHhGTlI1akc5SGd6RVNnYlpVZFFO?= =?utf-8?B?MkIrTGZkSHBWRlpRUlFINE51RGlWL1FZT3hBQThQSUhsZkswT0UwQVZvMTNR?= =?utf-8?B?dFdUUlhvQ21kekFiTk9MZm1lcVc2SFZ2RXdkaTNQaXJyQjczdnVibXczZFRs?= =?utf-8?B?Z3NLNSt5dHQ3QkZPdGJjd0FydEFZRjI1UDF1VCtHT2pldGN3SW9aR1Y5cys2?= =?utf-8?B?VTlpOStUalNaM3ppL0d3dS9SYnBIdHZEeDcwa3JFME5KclpVbzZpZTFvTVAr?= =?utf-8?B?eFdJQTlBdWpOWmF0cXE1Tm5UUjA3SElxb3pUb21QcE92K2tjdzBxS25VNHpv?= =?utf-8?B?Qm4vUTVxdmFHL1pXVEovVWorbFJZZmlmRlF2MXl1RFhxZ0dkR2ZZUGZKUFpa?= =?utf-8?B?MEpaRHVOMVpkcTlaVWY1VXpyT21sU0pXdDZWZWFaUTMvYTVsSGEwWHVPdFJP?= =?utf-8?B?L1phWkRnRmZhQ09GTFBObWJqRURoK1UvRlZ6c3VQTHd0ZFFHbkdVWjRudk1r?= =?utf-8?B?RmFBNzNQMW9kRzB0NlRCaUJZeUtTZUduZ0RZNmdhdEtiVUFxZTRUa1FJOWZt?= =?utf-8?B?UUp2R3d0aElzbncwZUV4cWVlNVdUemFGbVlKUnUxVWhLaWh6U3puQzZPZFln?= =?utf-8?B?UFJOVDJadG12b0pzSTJ4ZGpGNmhKTXAzVDFRV2ZhRmNxZTZpZnkwZ2xNU2Y5?= =?utf-8?B?N2kwMFFWblBSNmRGZDQvbzdKSzFqSWQwODJkUGN2K3o2RVdWUzV2cVpxNkpv?= =?utf-8?B?aTFGOUhwRHpmaVFlbmpVUzFXRVAydUkwNUhWVDYzS25IZk5EalAzNFRkbmVX?= =?utf-8?B?NFFXZC9veXcrcnR1WE1SU0xWQkI0MXp2cHBzNDcxNCtNcTErbnBFWm0zZFhK?= =?utf-8?B?WW5XNnBGYnBLY045M010Wk1nbkJubzVrOHR2T0NxMnVHK0RSdTdyOHV2czJH?= =?utf-8?B?aEN5QkE4a2d0RDg2UEFvcXQ0L1VXV1Y0K2xKeGtMZzk3eU1VY24xVU1zTGRS?= =?utf-8?B?U0J5RG0yTHNuUWdXT3AxQUQvL3puc2dreW5LWkFLaDBpRE9ITExCdjV4ZDVZ?= =?utf-8?B?UGJ3dzBkRkkvZE4zNkdCSjZtaGx5b0llZkpWT1V1bzhMN011cmRQb1cySVRN?= =?utf-8?B?dytrMmRmWFd6ZFZGU2haUEd0b1VoWmVFQmJtWTFWSDFlZU84dVN6bU9lMCs1?= =?utf-8?B?WXh0Q3BwRnViQlRXRmFKS1RyMnRVZ2p2bVBtWWRteXg2RkpDUGlGMDJTN1JG?= =?utf-8?B?bUxxNmtUakczbUFBTEljYVNUZTd1VkIvOThST2dpZWIwaDhub0czQzE4ZUU2?= =?utf-8?B?WHpMREpHUHVrNDJMUjloT2lHUVNiZjJTZWFnR01wVUVpRGw5anhFeTg2cTIw?= =?utf-8?B?aHVRVTd6T0V0elpuYSs1NW5UeWdNM2Y3MDRUMWRQcjFqZDg4dnV1ZmlnZS90?= =?utf-8?B?aEpPc1piOTExSkIwYThDWXNnei9uWEN5TFhBd1k5ZExqN2xRWnA5WTlaSUpL?= =?utf-8?B?ejFPZ002ajB1WEhLWUg3N0Y2cjA5WmxZOXgwUi8ySmhkRC9xbGpzZExGL0th?= =?utf-8?B?cWhBN3Q5OVo0T0ZHUGJoZEFkUm9SNzZHNmZxZzAwNlFXZ0UweldiT3g5RVk1?= =?utf-8?B?SXA3NTc4T3F5eVBoNU5GK1hjbitkdFJaa0dycEpHLzdoQmVYY2U4NVc3Tm5J?= =?utf-8?Q?vq5BG4J4X7F3IZ+gCCzy9bbprgJT1BM+LG8NvfF?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba059265-bd32-4aec-fb63-08d8ef19efd2 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 23:09:55.1036 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +bdPrtrKXm83xqWLSEvJxX57gmUUNJd+NYprHYbVupfqGXA44wpZ5J2NiLNpnCdhKpztHM/guuY9ZlsniF18ep+qWpYomUlHRdlFDt9fYd4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2632 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9933 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103240166 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9933 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0 bulkscore=0 spamscore=0 adultscore=0 clxscore=1015 malwarescore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103240167 On 3/24/21 8:24 AM, Roger Pau Monne wrote: > Hello, > > This is a proposal for an alternative fix for XSA-369 that instead of > special casing XEN_UNPOPULATED_ALLOC to size the p2m relies on making > XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on the generic MEMORY_HOTPLUG > option rather than XEN_BALLOON_MEMORY_HOTPLUG. > > I think this is safer, as we don't want to be special casing any option > that pulls in generic MEMORY_HOTPLUG without XEN_BALLOON_MEMORY_HOTPLUG. > Without this we would also need to at least special case ZONE_DEVICE > which also relies on MEMORY_HOTPLUG, and is what pulls the generic > MEMORY_HOTPLUG option even when XEN_BALLOON_MEMORY_HOTPLUG is disabled > with XEN_UNPOPULATED_ALLOC. > > Thanks, Roger. > > Roger Pau Monne (2): > xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on > MEMORY_HOTPLUG > Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" > > arch/x86/include/asm/xen/page.h | 12 ------------ > arch/x86/xen/p2m.c | 7 ++----- > arch/x86/xen/setup.c | 16 ++++++++++++++-- > drivers/xen/Kconfig | 4 ++-- > 4 files changed, 18 insertions(+), 21 deletions(-) Reviewed-by: Boris Ostrovsky From xen-devel-bounces@lists.xenproject.org Wed Mar 24 23:49:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 23:49:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101226.193445 (Exim 4.92) (envelope-from ) id 1lPDEr-0003iY-SM; Wed, 24 Mar 2021 23:48:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101226.193445; Wed, 24 Mar 2021 23:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPDEr-0003iR-PG; Wed, 24 Mar 2021 23:48:37 +0000 Received: by outflank-mailman (input) for mailman id 101226; Wed, 24 Mar 2021 23:48:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPDEp-0003iM-3M for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 23:48:36 +0000 Received: from desiato.infradead.org (unknown [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bc634cdb-2ec8-40e4-aaa5-02f1cf06dca3; Wed, 24 Mar 2021 23:48:31 +0000 (UTC) Received: from [2601:1c0:6280:3f0::3ba4] by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lPDEj-000Md7-39; Wed, 24 Mar 2021 23:48:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc634cdb-2ec8-40e4-aaa5-02f1cf06dca3 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=ZJXD/N6Limea4VVe7VOWBTx+vFdyKJO0h1A/Bqz0JPM=; b=YimCoJfEn9q9hWPDvfqNN8z3bL iyx/rtx7cG5GX+PQYb2Pyz5Kz8VBNSabBZWA4CtG636S1rQjxXDSzGZrP0Yr1Rcu/nOT2PE4irH97 a6AaQ5MC8GzgWSaz7e2z4+xMfFr1YVySh8luGRENKsNpQfXwqO2VduXUu6HHINxFrVhoSMKJVghQF WyZ4lABxpwV0jhG/viOVsa9MuarnHHtWAaqUa89dvCWKLM6Yr7V7Fvywo+KMTwh3ECXMkHOhLQ6FW 64yUTRfuNjtza7DC9jC50/aUdZ1MuoPcx7pAzKiXxRJalDfMkZXxfBd5s7Y0/wkrThCBIlts2A34E czfQ991g==; Subject: Re: [PATCH V2] ARM: xen/mm.c: A mundane typo fix To: Bhaskar Chowdhury , sstabellini@kernel.org, linux@armlinux.org.uk, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210325043526.16289-1-unixbhaskar@gmail.com> From: Randy Dunlap Message-ID: Date: Wed, 24 Mar 2021 16:48:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210325043526.16289-1-unixbhaskar@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/24/21 9:35 PM, Bhaskar Chowdhury wrote: > s/acrros/across/ > > Plus some words need prural version...so did it.(page->pages) > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > Changes from V1: > Randy's findings incorporated. > > arch/arm/xen/mm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c > index 467fa225c3d0..8596dd32dcd5 100644 > --- a/arch/arm/xen/mm.c > +++ b/arch/arm/xen/mm.c > @@ -105,8 +105,8 @@ bool xen_arch_need_swiotlb(struct device *dev, > * - The Linux page refers to foreign memory > * - The device doesn't support coherent DMA request > * > - * The Linux page may be spanned acrros multiple Xen page, although > - * it's not possible to have a mix of local and foreign Xen page. > + * The Linux page may be spanned across multiple Xen pages, although > + * it's not possible to have a mix of local and foreign Xen pages. > * Furthermore, range_straddles_page_boundary is already checking > * if buffer is physically contiguous in the host RAM. > * > -- -- ~Randy From xen-devel-bounces@lists.xenproject.org Wed Mar 24 23:57:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 24 Mar 2021 23:57:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101229.193457 (Exim 4.92) (envelope-from ) id 1lPDNX-0004cf-PQ; Wed, 24 Mar 2021 23:57:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101229.193457; Wed, 24 Mar 2021 23:57:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPDNX-0004cY-LV; Wed, 24 Mar 2021 23:57:35 +0000 Received: by outflank-mailman (input) for mailman id 101229; Wed, 24 Mar 2021 23:57:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPDNW-0004cQ-4r; Wed, 24 Mar 2021 23:57:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPDNV-0004OC-VZ; Wed, 24 Mar 2021 23:57:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPDNV-0005Du-MS; Wed, 24 Mar 2021 23:57:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPDNV-0002Ev-Lr; Wed, 24 Mar 2021 23:57:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Gh1yizNZ6lXneq1ZPvR1zTSoBRCQyz6j/3aCv0xkLIg=; b=5g0LdMpAumcnRCWRAA01XBbNog t1HFuUjULUCTycsPcRURi8AozzxrCw+22g5zHRSPIaPp/NCa1nTqG3sG4xqyEQz4y0BuTSmHAl0Wn Ylnjx3ouQWws+5bTP6bTV+lV4AC1QCTGP8jN6yIU3Fa+dTD1tb9nW0lGlJIzKIK/GhCc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing baseline test] 160394: tolerable FAIL X-Osstest-Failures: xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ecdff2f5a03210119b71806c3f5571d6906dd85e X-Osstest-Versions-That: xen=ecdff2f5a03210119b71806c3f5571d6906dd85e From: osstest service owner Date: Wed, 24 Mar 2021 23:57:33 +0000 "Old" tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. flight 160394 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160394/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail baseline untested test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail baseline untested test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail baseline untested test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail baseline untested test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail baseline untested test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail baseline untested test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail baseline untested test-armhf-armhf-libvirt 16 saverestore-support-check fail baseline untested test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail baseline untested test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail baseline untested test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail baseline untested test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail baseline untested test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen ecdff2f5a03210119b71806c3f5571d6906dd85e baseline version: xen ecdff2f5a03210119b71806c3f5571d6906dd85e Last test of basis 160394 2021-03-24 16:35:42 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Mar 25 03:53:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 03:53:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101244.193484 (Exim 4.92) (envelope-from ) id 1lPH34-00067a-7V; Thu, 25 Mar 2021 03:52:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101244.193484; Thu, 25 Mar 2021 03:52:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPH34-00067S-17; Thu, 25 Mar 2021 03:52:42 +0000 Received: by outflank-mailman (input) for mailman id 101244; Thu, 25 Mar 2021 03:52:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPH32-00067K-Ga; Thu, 25 Mar 2021 03:52:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPH32-0002Oa-AA; Thu, 25 Mar 2021 03:52:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPH31-0000fF-UD; Thu, 25 Mar 2021 03:52:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPH31-0001BE-RA; Thu, 25 Mar 2021 03:52:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vaPtgfHku8zlp6biWDbw1DtY37ADgn18cX8gwRL62zo=; b=g6Y3rf7Hfzh2SS7McdwUYXkPKi HYXxYujBp5RapE2CvXnOzIU3V4iR8JIoeDP9vF76d04K3U7DC8Y9C20rCXA/GtwOBEzz7Fz/0xd+8 Bx7QEw0uvlNbkkB+VlJl9KrbWP8P2qmE+RDpnbYwDP+98U3K1fx0L0hsM7G5PllYIs9Y=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160376: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b9b3082002cac68726fb303e0abd2ff0113d4657 X-Osstest-Versions-That: xen=ecdff2f5a03210119b71806c3f5571d6906dd85e From: osstest service owner Date: Thu, 25 Mar 2021 03:52:39 +0000 flight 160376 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160376/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160348 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160348 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160348 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160348 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160348 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160348 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 160348 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160348 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160348 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160348 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160348 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160348 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: xen b9b3082002cac68726fb303e0abd2ff0113d4657 baseline version: xen ecdff2f5a03210119b71806c3f5571d6906dd85e Last test of basis 160348 2021-03-23 03:13:33 Z 2 days Testing same since 160376 2021-03-24 03:21:51 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ecdff2f5a0..b9b3082002 b9b3082002cac68726fb303e0abd2ff0113d4657 -> master From xen-devel-bounces@lists.xenproject.org Thu Mar 25 06:23:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 06:23:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101256.193521 (Exim 4.92) (envelope-from ) id 1lPJOG-0004vG-9r; Thu, 25 Mar 2021 06:22:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101256.193521; Thu, 25 Mar 2021 06:22:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPJOG-0004v9-6V; Thu, 25 Mar 2021 06:22:44 +0000 Received: by outflank-mailman (input) for mailman id 101256; Thu, 25 Mar 2021 06:21:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPJMe-0004tn-R6 for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 06:21:04 +0000 Received: from mail-m17637.qiye.163.com (unknown [59.111.176.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 88feda81-6889-46e5-86dc-7e4def9d2976; Thu, 25 Mar 2021 06:20:57 +0000 (UTC) Received: from wanjb-virtual-machine.localdomain (unknown [36.152.145.182]) by mail-m17637.qiye.163.com (Hmail) with ESMTPA id 5360C980378; Thu, 25 Mar 2021 14:20:41 +0800 (CST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88feda81-6889-46e5-86dc-7e4def9d2976 From: Wan Jiabing To: Oleksandr Andrushchenko , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: kael_w@yeah.net, Wan Jiabing Subject: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice Date: Thu, 25 Mar 2021 14:19:01 +0800 Message-Id: <20210325061901.851273-1-wanjiabing@vivo.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZTR4fTE1IQkofTk8fVkpNSk1NTkhJT0pOTk1VEwETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKS0hKTFVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PhA6Hgw6LD8OGj4eLUMtGTIL HTQaFBxVSlVKTUpNTU5ISU9JT0tMVTMWGhIXVQwaFRESGhkSFRw7DRINFFUYFBZFWVdZEgtZQVlI TVVKTklVSk9OVUpDSVlXWQgBWUFKTE1INwY+ X-HM-Tid: 0a78680acc88d992kuws5360c980378 struct xen_drm_front_drm_info has been declared. Remove the duplicate. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/xen/xen_drm_front_conn.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/xen/xen_drm_front_conn.h b/drivers/gpu/drm/xen/xen_drm_front_conn.h index 3adacba9a23b..e5f4314899ee 100644 --- a/drivers/gpu/drm/xen/xen_drm_front_conn.h +++ b/drivers/gpu/drm/xen/xen_drm_front_conn.h @@ -16,7 +16,6 @@ struct drm_connector; struct xen_drm_front_drm_info; -struct xen_drm_front_drm_info; int xen_drm_front_conn_init(struct xen_drm_front_drm_info *drm_info, struct drm_connector *connector); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Mar 25 06:53:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 06:53:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101260.193533 (Exim 4.92) (envelope-from ) id 1lPJro-00080N-KT; Thu, 25 Mar 2021 06:53:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101260.193533; Thu, 25 Mar 2021 06:53:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPJro-00080G-H5; Thu, 25 Mar 2021 06:53:16 +0000 Received: by outflank-mailman (input) for mailman id 101260; Thu, 25 Mar 2021 06:53:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPJrm-00080B-6s for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 06:53:14 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d3296b4f-8222-4b08-80c6-9d35bb353428; Thu, 25 Mar 2021 06:53:12 +0000 (UTC) Received: from pps.filterd (m0174681.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12P6j4bK029653; Thu, 25 Mar 2021 06:53:09 GMT Received: from eur04-he1-obe.outbound.protection.outlook.com (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) by mx0b-0039f301.pphosted.com with ESMTP id 37gmer05nu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Mar 2021 06:53:09 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17) by AM9PR03MB6785.eurprd03.prod.outlook.com (2603:10a6:20b:2d4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Thu, 25 Mar 2021 06:53:04 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::3541:4069:60ca:de3d]) by AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::3541:4069:60ca:de3d%7]) with mapi id 15.20.3977.025; Thu, 25 Mar 2021 06:53:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3296b4f-8222-4b08-80c6-9d35bb353428 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZUif+lGE7MgVxmFq5paAgMrulLL6LFi7HHb1rtgVe7PatN6XK6QXXLBR7wa6efOW/rm86qDj4cvqEWTTpQ3awuhMbo6ebP8bPKpNMGNkwbZg3ObUnqmQ+dPBNtfUNYUg1Dqi3TkOKpvi7qQKVr38CuIKazMEFC5bNz4mgvj3F8MSHDsz+5/jNkRot1Z7yg3MigeulTtylKOvaybI27UDqWbTpW2EYZ9fNWMr3EEKmuz0pyDFw1wWZYS4Six1pJ4qdyWpx0VaroEZTtP5OJKmZYuygPajYrWTT+wmhC5cFjWqqTAo89bL3Br03xQl4Dt/+4m998gNDMEWrzfcFp+IEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HKtV3r8l/vkioNUg8/tCnsC1YcYskCNNnCuhba3PDrs=; b=mUxC6AXEMzmZCABS28nmMCW9oZ4if9md1T0zBYlZ6pBCVv5XCnrcFs8+huUFfc7BdM+6L4vlUv+yetBhOFbepNjLDMq2BlZC/7kTyHsS93wK47QoRYOgj1u6n7XCX86qRuRSuKrRKq1o18HrTe0DX7J8WwxTC4AHX/jDFd0z0VuM6d/O/sazjkkfSm3R3St9coOyUjp1SHz6bFkTVRE3ETE54bzGHqcgsv69e636MRjGi+6DgiP8VtsyYh8qOOvEPSWOO3tPaq/IPV2JXRcPwoBD3Gdk/C07OIFDzSEyOpIT6ZaFoSNhsClYNNXUj99MUEyn57Q5A3Cptw1pqSNYuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HKtV3r8l/vkioNUg8/tCnsC1YcYskCNNnCuhba3PDrs=; b=ZOSiWLxesUaJIk5Ah7+bfDHDvvuug3DnsyeeLkjlwKPo4d5cTPxTU2IbLY5mRehLlmRERsb0iHBqhAhDpVCutnUgxs+IvGefDk33fJmREq8/3PFux44YbnUw0KlU34sv5Bp6t4kvSYVemXTJclSQ3yOYYJfmo4LS7i+nYLY3Q7u8qIsejdAYPFR0qbeeA9bRRjcQwIPHwAGYSW1JC2tzoV2dWba9FfpG6yIZkY5A6Era7x5GwWZ4HAMl48fFRcxeKEbAJN7IrUt8t7QqsWOj90+clrfkEvrYg9fuRmaUKGFll+LzUK2dm2u3WWZmN6anLHNQfTBtamLK05spyXufJw== From: Oleksandr Andrushchenko To: Wan Jiabing , David Airlie , Daniel Vetter , "dri-devel@lists.freedesktop.org" , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" CC: "kael_w@yeah.net" Subject: Re: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice Thread-Topic: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice Thread-Index: AQHXIT8BvTrvCJoLoEahz8MTVepQQaqURIKA Date: Thu, 25 Mar 2021 06:53:03 +0000 Message-ID: References: <20210325061901.851273-1-wanjiabing@vivo.com> In-Reply-To: <20210325061901.851273-1-wanjiabing@vivo.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: vivo.com; dkim=none (message not signed) header.d=none;vivo.com; dmarc=none action=none header.from=epam.com; x-originating-ip: [185.199.97.5] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4e1491cf-acd7-41ed-aeec-08d8ef5aa376 x-ms-traffictypediagnostic: AM9PR03MB6785: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rxgiAIa8CzarkQnaymFlUFntY77b4em+ARktF7Y8gOICF8Kzp31dR2OeMNjm2BMCfncHlL/syZLH48uKpOyhd3DFpL09HF1iCu/q9FglQMCBtCSuc0D0QLjYlk71aOOXGzZbjQVeA8kjHIm8/nPm1f16z1HZQdX4n5QMKskAcHBFQs8zVf0ZtRbnQmZsccY11Ww9E/aixJWHa4bPPveJu8CO+sVcmXFglVIVbVNFTgvJtZWHKHZ6jWWAFZNQ27Ew5HuPDCihNn6nbx58CPxTMcKfCfoWESHODG6Lv2VNL1oQGaIBT6mVaTzn9KPp/9mtyPr95x5sUd6N99rL89j3fsyQDxJDoNt0yqFywtPw1mi+aQlaL/k4Ga1KTIaYDPZcR3AOE3/cqiKthuJEjWAIgL5sBNirHwzCI9nEiOu+o5hTV+VSbdjQept5odTwOHA83QFM08n244J9mSCLjmeoCFH03IkzzJlQn8voPxqqwTy+drBQtdNST4T0BRQ/omqnQ6AoDlNTd6vo0LZGM/4UwmWnheohdqFLullTf6b8LugLLGaHCGkD2cQMU82OEqCdRYTHjFiqrl1snZC+uVBcfz0vKpxmgen2uledBXZdxPbg5Y9f7Hkj7jLcW3UFJ2iSkAXbwvJBOJT3gJYg9KQoXW4dExSColinaoEX02EPFRAhcl0hrVvbxaET7X5r9t9G x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(346002)(39840400004)(396003)(76116006)(36756003)(31686004)(8676002)(4744005)(86362001)(83380400001)(8936002)(5660300002)(2906002)(110136005)(66946007)(316002)(53546011)(6506007)(71200400001)(6512007)(478600001)(66556008)(66446008)(64756008)(66476007)(4326008)(38100700001)(6486002)(2616005)(31696002)(186003)(26005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?N3ovZTJPQjRlUVQ0bTZ2RFN1TG1vOFJiK2g0aUl0YjY4enJyTDdwRkhtcmYw?= =?utf-8?B?S0wrR3RwSFZ2QSt0by9NMW5tVTJXS1JkWkZHRXN2bTVUU1habTVTcFY1c0JJ?= =?utf-8?B?WEIzejJvSzJrdHlNT04rNGNUSERwNXh5WXgwbGNwREgxQzBmUzNSbWR2RTdJ?= =?utf-8?B?QUZHemV2U1ZGSmZEK3pBNU5jYWZ6Wi9QTm9XMytLTG5FYnR2RDZiUm43SDk3?= =?utf-8?B?eFlTY0xXZHhJaDFIOUp4ekhXaS82VmVMcXAwQWRGakhHbDdkTE9JaTVpbDN4?= =?utf-8?B?SDNhb1ZrNmh1VHdXT0tqNWNyREF6WGFnRW5IY2FJa0N0dVYwNElKT3krOFBw?= =?utf-8?B?V0J6Zjh0L1VIMzFNcVMvSnh3WjFmZmp0VGU4ZGgzWnNrOG04UndPZlM0VWhk?= =?utf-8?B?TURhVlVHTnR0K1ZIYnVnaTlrV2wzcXpGcFdiYVlNSHQxWEZJRjkxcDN2ajRW?= =?utf-8?B?NFlDUDVuUldJNExoanlWMG02T09mdE5lQ1huclhGQUpUYzRvQWNiWjFiSHQ5?= =?utf-8?B?SzVkSG9OeWdIM2pqaEZza2c3MnBUcHFEQi9lV0RPNG1ISGdGRzRpQmoxY1do?= =?utf-8?B?b2hsUmE1K3Fxam5wUUwxbGZPMGhZMHp5Y1VOWWVOQlliTnQ1S3FuYmpqWW4x?= =?utf-8?B?MGM3TG5OTGsvSUkzcTBkTjlIbnBEZDAzelpobWdkKzg2WXBuY1Y3bisvNnlp?= =?utf-8?B?RHFEU3ZJdHhOa0xwaGp5TlNTMDVzUi81N1VSdnV1MGdCeGhpUEVsRk03OHRR?= =?utf-8?B?STA0QUVlZnNVYmtFTUxJRzRrcFE4RlhSUWE2bFMyR2JPNEdQQ29SS3FlVkpH?= =?utf-8?B?aG0za09RSEIrdEYxajR5R3J0NmJRL1JIZnRzM3J0ODUvaHNBb2NlSUdpQ245?= =?utf-8?B?QWVzeE9NUXhodHdEZ25kWis3RXlwTWppenJ2YmxNUFZPMjlKV1JaK2cxdjVH?= =?utf-8?B?QnNMSGxZQzBXakZHYThSazZqVEEyTjE1UHVYbHFwYlorTnY2UGdyaURJbXQ0?= =?utf-8?B?UVlZLzI5bjlTV01PTDBXd2lqUjRZV3FZVDU5MUQrU1kxdzhQN3FrUHRjTFJ3?= =?utf-8?B?b08rTHNENXBhMlUvTHp1dEgycEo0YWxUZkVid2dyZnBuTFFlVjhWUkNsello?= =?utf-8?B?MWNDM0Y2UVFiNUlNcUxLbVVSRTNZaE9yS2ttcCtsR1EwejJZODNIVlRlODZx?= =?utf-8?B?a1c4TUkrUHVpQk15elRxNjFkTERxbmlSeTVwQ1JiVXMzRnZHdGRuc1d3dmlx?= =?utf-8?B?K25POVpPYURaenJQTk1sNllpMUxiWW5LMmhHR1ZqRlpiVUpEd08rWHFZQzBM?= =?utf-8?B?NUYzQmp6R2NrOHhITVI5VVFLWS95dnE3WmNhRFQ2NEIxVEJIMUExVC9HK3g4?= =?utf-8?B?dzRtKytvcERXeEFGeWNobFYzVGZPS245WG1adlpVZmt5NEdyekVTOHpjZnl3?= =?utf-8?B?TWFaM0RhU2loeDRLdmpDYjFhbXowU05ZTW1zUWlhUE5WYmhRWjhtL3ZPK1BV?= =?utf-8?B?RXhpR1hqclcyMHN2OHZxdXVUKzdNbVlaU0o2ZGNDYjhXbGNmQzVFZU5NRWI4?= =?utf-8?B?TzB4UnZic1VYWTFDOHlqWkdaTUxJR2hKUFpvbTEzbGNvWklieTJHTXdUbFJr?= =?utf-8?B?RXZDV285VlpZMFVSb3ByM2hIOHFPMXhWTlVNS204VVgzaFhuSU4wVEtBTFBY?= =?utf-8?B?bkU1cDA3VDdZREFRbHkvcmJGL2tnQU11NTdIbVF0L1FoWTZJRkpKMVlvWjRl?= =?utf-8?Q?HsCdN+t559vlkWvtUknB2GGq4SsH9Wr/vZ2h+CX?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <0A11FD010DBC874AB7B080924E43FBE2@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e1491cf-acd7-41ed-aeec-08d8ef5aa376 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2021 06:53:03.9981 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w+Vg/W/ZFHChemTy7WttszN9OWivgR+VuQcGRoOnHeR8SkbRqKFItHbAFYrUJHlCS++oZCbs97HRjMJJcTj0l/wwf0SqxuNT/3aUATR1iNhHsRrfYZyEwg4MiHkqeLOA X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6785 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=956 adultscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 suspectscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103250049 SGksDQoNCk9uIDMvMjUvMjEgODoxOSBBTSwgV2FuIEppYWJpbmcgd3JvdGU6DQo+IHN0cnVjdCB4 ZW5fZHJtX2Zyb250X2RybV9pbmZvIGhhcyBiZWVuIGRlY2xhcmVkLg0KPiBSZW1vdmUgdGhlIGR1 cGxpY2F0ZS4NCj4NCj4gU2lnbmVkLW9mZi1ieTogV2FuIEppYWJpbmcgPHdhbmppYWJpbmdAdml2 by5jb20+DQoNClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLA0KDQpSZXZpZXdlZC1ieTogT2xla3Nh bmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KDQpX aWxsIGFwcGx5IHRvIGRybS1taXNjLW5leHQtZml4ZXMNCg0KVGhhbmsgeW91LA0KDQpPbGVrc2Fu ZHINCg0KPiAtLS0NCj4gICBkcml2ZXJzL2dwdS9kcm0veGVuL3hlbl9kcm1fZnJvbnRfY29ubi5o IHwgMSAtDQo+ICAgMSBmaWxlIGNoYW5nZWQsIDEgZGVsZXRpb24oLSkNCj4NCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS94ZW4veGVuX2RybV9mcm9udF9jb25uLmggYi9kcml2ZXJzL2dw dS9kcm0veGVuL3hlbl9kcm1fZnJvbnRfY29ubi5oDQo+IGluZGV4IDNhZGFjYmE5YTIzYi4uZTVm NDMxNDg5OWVlIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0veGVuL3hlbl9kcm1fZnJv bnRfY29ubi5oDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS94ZW4veGVuX2RybV9mcm9udF9jb25u LmgNCj4gQEAgLTE2LDcgKzE2LDYgQEANCj4gICBzdHJ1Y3QgZHJtX2Nvbm5lY3RvcjsNCj4gICBz dHJ1Y3QgeGVuX2RybV9mcm9udF9kcm1faW5mbzsNCj4gICANCj4gLXN0cnVjdCB4ZW5fZHJtX2Zy b250X2RybV9pbmZvOw0KPiAgIA0KPiAgIGludCB4ZW5fZHJtX2Zyb250X2Nvbm5faW5pdChzdHJ1 Y3QgeGVuX2RybV9mcm9udF9kcm1faW5mbyAqZHJtX2luZm8sDQo+ICAgCQkJICAgIHN0cnVjdCBk cm1fY29ubmVjdG9yICpjb25uZWN0b3IpOw== From xen-devel-bounces@lists.xenproject.org Thu Mar 25 06:53:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 06:53:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101266.193545 (Exim 4.92) (envelope-from ) id 1lPJsP-00086Q-2U; Thu, 25 Mar 2021 06:53:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101266.193545; Thu, 25 Mar 2021 06:53:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPJsO-00086J-V1; Thu, 25 Mar 2021 06:53:52 +0000 Received: by outflank-mailman (input) for mailman id 101266; Thu, 25 Mar 2021 06:53:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPJsO-00086C-1Q for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 06:53:52 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9a6affc3-0871-4474-8693-7129f88bb562; Thu, 25 Mar 2021 06:53:50 +0000 (UTC) Received: from pps.filterd (m0174681.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12P6j63W029988; Thu, 25 Mar 2021 06:53:49 GMT Received: from eur05-db8-obe.outbound.protection.outlook.com (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by mx0b-0039f301.pphosted.com with ESMTP id 37gmer05qj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Mar 2021 06:53:48 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17) by AM0PR0302MB3283.eurprd03.prod.outlook.com (2603:10a6:208:12::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Thu, 25 Mar 2021 06:53:47 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::3541:4069:60ca:de3d]) by AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::3541:4069:60ca:de3d%7]) with mapi id 15.20.3977.025; Thu, 25 Mar 2021 06:53:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a6affc3-0871-4474-8693-7129f88bb562 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oFhhLCKUd+0HydW+yYX4rltHbaXPcYpGnwakRQC3gH5ryXAivi1kr/OVvYDmkFmlWigXPGmBvIexk3CZOI7DSPmz0RLE8+rEo9yRcdcm+dYBAiQdw6BL2U5z1SwpQseSIAGV4QtuzzlWfaWTtWnH6HJ/KXdnc/+OxdbcaWuJQRDwRyTX02CQR0cO+IoTvXd87IclO8LbBUj7HCM7Wb62qZiM28/Sb9xfCrvGsZFffIGldYu47GDBCxfZWKSueUkJCNiXGsDYH6W32srjxbO0kMyBr2rLismgk6lu0B+V1N3slVkco80Dcb91cngAt+hZVZ+AMXgTDwQKkLbblka0Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YBODP1W7j6ZcILAQc0m1CiDNrOSChCd9P+aXQPHAeeE=; b=eJJllhkPnJSqr+bTMKv7Ndh0QRPNqIoAFDfQoZJpZBK+RbX7yRBDIAiUEp6oRZrpwoyIKYJMnkdSmK5DqlVAyov/qiv3O3YT7rnKjHKT/s8aGIxdp0c9amBH2fyIcUPwv2vemn8n9bGTu+bUvRSSSIDAtINzl0aMbfEVJsfQNPNIg3IcZhHiAsYd/i1RT2c/qjLpRh2RD9VkiUlmqWiQSEdFDawJz35pwXd3gu5XBuzpIbKbZbBa06RIZ41oAx9cmgLs9GScmsDy/5detmWRExcAsGkqve2u2ClvCMGOtok7WzaOdIZEjk9zJXDWav9ZIXOSzINgdSvmLm8CYGoo7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YBODP1W7j6ZcILAQc0m1CiDNrOSChCd9P+aXQPHAeeE=; b=ypZQ6SY22FvxcysjRg+Zl65o4EP8YvItnf3KuxMSWh5KKFsP3gl7unkXdeW5p+EE4A6XBYOL00mLcqFbFrqNDu1O8cLW5W6XL/m8DdDdPBbVzxmhOTGYy2duQ6iAX9y+toS+vjGjlNgTsF4xv8Yckl4bifaNUOUSY/FqVJNoofHJFzwoWAc7nqJRpwe7iHzhS+9cCMtjXw72GPHoX34fVXYblKS5xgGJHgYBUs/5paTuLcFpKuMcrTdFHzg+A6gYPQ7KapxdDRfXzvTGii/pOcCBwciacwIAk0iE2QOXZvCPYwQ7ledlJWKxZZzO2I3N/O7rp5MKA1bmOdwqZDWItQ== From: Oleksandr Andrushchenko To: Lv Yunlong , "airlied@linux.ie" , "daniel@ffwll.ch" CC: "dri-devel@lists.freedesktop.org" , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] gpu/xen: Fix a use after free in xen_drm_drv_init Thread-Topic: [PATCH] gpu/xen: Fix a use after free in xen_drm_drv_init Thread-Index: AQHXH4ZwjUja6WTelkeHEbGl7WGsSaqUSCcA Date: Thu, 25 Mar 2021 06:53:46 +0000 Message-ID: <08cde91e-6276-3d59-b784-803327800896@epam.com> References: <20210323014656.10068-1-lyl2019@mail.ustc.edu.cn> In-Reply-To: <20210323014656.10068-1-lyl2019@mail.ustc.edu.cn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mail.ustc.edu.cn; dkim=none (message not signed) header.d=none;mail.ustc.edu.cn; dmarc=none action=none header.from=epam.com; x-originating-ip: [185.199.97.5] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6a1f3477-368b-4a25-8140-08d8ef5abd21 x-ms-traffictypediagnostic: AM0PR0302MB3283: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mq0dlE0JR7G6n9lR6BXiSMJ89YeD+eLWZty+d0uXcjwBMO72+6g0AlopRFxKt62k+BS8xGkM+lkypWvAysZXgnRS/fnQ4YmYqsYWvH0OBY0hBzaoxiC+N8Jb0fgmOhleR2KzRm6XZIA8QtB2QQRyRONCGQKsMCwBEBdaaGhSLmR5Nj/761kguGXPWntw9ouHdHFqHbiCz4SApDHAUoKRNDJ8AB4xXau63Sv2GXOCSsZAG18UCYEHyDMXoaTpgwONLOKvmT0/PfH2c0mE1s8BRG1l0XBINIY2fR65epHJI8SfJnAuG+1RoOhxnc7ohyfaLpCp3s0dofkiJL05hA7tLoengNzbIxxkqiVZ+h4Efk4l0NkuTEly9hSpktFjxETDPnB1F4G4gwHUYESNdB9cOo6m9LDfcP3EZ0hFn7NNIDQR5FQQQkHt9YDM+OQvIpm2w4LeJV9WFBAXRUQ/EJ0Xqdo7xM4GYyHKiuNHBhA92172e/rjTWLroq84tEtPhEguSsuKw/GjiZn9vD9kj9fowwo04/3qH5WZzNe6rwYVVsS6E8+jSdjFjcUrBrBNdSw6OCxG94s5ookHbSO9oXMsvi3vhVxQJTwUVGJr87dwH1KS1FZT9rbBN6Bux4HbPL8jW6W76TewjVld44acizQ7YsXF/3YZ7xIeOSYxtyv47fRrItOxmwz3FDuvtG4n7CGB x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39840400004)(346002)(136003)(396003)(376002)(366004)(36756003)(66946007)(54906003)(5660300002)(2616005)(110136005)(66556008)(478600001)(26005)(186003)(66446008)(6486002)(316002)(6506007)(66476007)(53546011)(64756008)(76116006)(2906002)(31686004)(4326008)(86362001)(6512007)(8936002)(38100700001)(71200400001)(8676002)(83380400001)(31696002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?V3JhL3Y3Z2hBbTZKUkROWTZDVnUzT1BDNk5LQ1NPZWhGUHJMTE8xM244OHVs?= =?utf-8?B?amkwbkJmZFBHc09zak5zbzFEUTE5V1N4UFhaNitBanRrN1JLd2YxVHJHbU10?= =?utf-8?B?aVhlbzVSSkpRTkdxdlhaTnZMNldtTVkySkE0cUVPL1V0L3kwVVNCcHgzblNS?= =?utf-8?B?aUpvcWR5ekFxSXRXZUtYVjVMVklmOWlGd2dZOWhkMTJlMFNZYlNQaDhMTXpG?= =?utf-8?B?eUJmZGRHcmNZV0hycVR5c0xmYlBybHJRU0hGWmZOeVFpN0xiQzV5endPblpL?= =?utf-8?B?RjYwakRleDhSTGZReTJUSmZlSWNrZUYwcExTeXEzNllraUU5Vzd6b3EwejRt?= =?utf-8?B?cThwd09XditmV3o4ZFJQRW9ZNGxLOTJWVzBUL2E3Z2k3aHAzRVNYMTY3K3ZV?= =?utf-8?B?NVhhOWIxT2VTRzA5dXBnT1pLc0ZJYlNhSE1DTDdPVmhWOStJbWhqcVo0S1Jv?= =?utf-8?B?RlEyTVN6VmxZc1NIVzcrQ0FOOGprUlRXTU04RWF1TjRaNE1yaWlTSE9hWkRX?= =?utf-8?B?NklMNTNnWHByUEFJeU9HTTRQKzNkaWovNWVDSmowcXR2YXBQTUJsRldBSitn?= =?utf-8?B?T1pucGl5WVIydXBXOHd4dVA3YVBWOU9EbGlDSUErQTluZ0QvTlA0K0ZXTmJh?= =?utf-8?B?ZnZUZHYrbUpsdWVXUHg1V01MMk9XV3lHaGJGMmR1K3VQSG00K0sxYmNZRnlC?= =?utf-8?B?WGd4TmVIN3VCbjByQ3NuMEh4aFY2WWxqNUVMZ0J3c0hMNUJwV3pFUHU3bjlK?= =?utf-8?B?c3o5NjhzcjFRYy9mTjdVSHdscHRNT0Q5dmtlSGh5SlZ6aExxK3AxVDFrK2FD?= =?utf-8?B?UnZ0SEJMc2ZvYXZCc3RoblV4cFVkTG1QTFcxdjZZbXlXWnF3TExiUElKMkpV?= =?utf-8?B?ZDJXV2hlaEFHQkpFV0w3ZCtrcmw3dzk2bEpZR2lRZ1hKY25WVU9jOE1sYzNX?= =?utf-8?B?U1I4MHRFWDBIL1lxS0VKc0Y3cXBHSnVQTm1NLzdlalJJR1l6T3lkNlQ3eU9O?= =?utf-8?B?cVJkVEh4M0Mya3NzdGVoZ1R4NlFjRVRQNFdoQStvVVJ1am1USXQ1UXQzR0JH?= =?utf-8?B?Y3NscGUwTjVOanF0Y2JIUzZyNzJSYXczMkZuNHlQeTllMGJycDh4Q0NQKzBl?= =?utf-8?B?WnFuQm1PYktHMll3blIyeXpFY2srd0xQeU13L1p5UXVuZ2VZWUcvb1FFMnow?= =?utf-8?B?L09QV2lSY1FIb05Hcll4QlV4SFpSQzhqSSthUmVBaUlGcjdUckFTcjdvcWdN?= =?utf-8?B?dzdUUFhlNEo0RWxOTGlqRXBhVzhxb1ZwdmxJam5GYVExb2VSSHgzQ00xL0Rr?= =?utf-8?B?d3M4K2lZd3NEaWN5anJPOGJ0SHVFdk5ENnNyZ0NJWnNTamx5V3VwRzhxRjJN?= =?utf-8?B?YUp3Zi84NHQvWGxIWGUzNkt2OVAyeDBnWmk0Ni81UWc5cE9yU2FyellxdEcv?= =?utf-8?B?TjJoeGVpQTRFdXZiV3VzaWhmSENRQXNlSE5od3VvSzg4dU1DRmw0cmtZRURZ?= =?utf-8?B?SlZ6d0tMWjF0VEFCVUdrVUlyMGVsOUtneVJTZkttYWIyMGtxRVg1cWlxTG1G?= =?utf-8?B?azV5M3ZFY3BEVmpIK2dIZWlaNzBha3graGJQajlyWnAvZUFDYktSaG9pSTh2?= =?utf-8?B?d0l6enlleFIzYXFxaWJBZGVOQVA5Vm9ldzJNaUNiWjRjWGVjMCtIbnc3R3cy?= =?utf-8?B?Yk9XbHE0RU9IR1h2dmdmM0pJSGFDd2YwQ2h0ZXVlUXQ3RkJ1WW92NVJVdEF4?= =?utf-8?Q?6NniNmstmlOfUCIKomVDF9hxHrHHFJCiyTpIkSs?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <813B40AC18E2B149A47E4F7F1C59F91E@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a1f3477-368b-4a25-8140-08d8ef5abd21 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2021 06:53:46.7649 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tdHhnweOHhnw7sGQ2ybFAwFvjOHSmg0q2kUxWWQyc4QMHmSEvXWfqJPEW3Yv3ZYPmn9krO9f1Y+gG2deaMuimAP4sp5Led1B93jQ2e7pkY1M6s3G+BbDrjttSF+AETnv X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0302MB3283 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=883 adultscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 suspectscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103250049 SGksDQoNCmdvb2QgY2F0Y2gNCg0KT24gMy8yMy8yMSAzOjQ2IEFNLCBMdiBZdW5sb25nIHdyb3Rl Og0KPiBJbiBmdW5jdGlvbiBkaXNwbGJhY2tfY2hhbmdlZCwgaGFzIHRoZSBjYWxsIGNoYWluDQo+ IGRpc3BsYmFja19jb25uZWN0KGZyb250X2luZm8pLT54ZW5fZHJtX2Rydl9pbml0KGZyb250X2lu Zm8pLg0KPiBXZSBjYW4gc2VlIHRoYXQgZHJtX2luZm8gaXMgYXNzaWduZWQgdG8gZnJvbnRfaW5m by0+ZHJtX2luZm8NCj4gYW5kIGRybV9pbmZvIGlzIGZyZWVkIGluIGZhaWwgYnJhbmNoIGluIHhl bl9kcm1fZHJ2X2luaXQoKS4NCj4NCj4gTGF0ZXIgZGlzcGxiYWNrX2Rpc2Nvbm5lY3QoZnJvbnRf aW5mbykgaXMgY2FsbGVkIGFuZCBpdCBjYWxscw0KPiB4ZW5fZHJtX2Rydl9maW5pKGZyb250X2lu Zm8pIGNhdXNlIGEgdXNlIGFmdGVyIGZyZWUgYnkNCj4gZHJtX2luZm8gPSBmcm9udF9pbmZvLT5k cm1faW5mbyBzdGF0ZW1lbnQuDQo+DQo+IE15IHBhdGNoIGhhcyBkb25lIHR3byB0aGluZ3MuIEZp cnN0IGZpeGVzIHRoZSBmYWlsIGxhYmVsIHdoaWNoDQo+IGRybV9pbmZvID0ga3phbGxvYygpIGZh aWxlZCBhbmQgc3RpbGwgZnJlZSB0aGUgZHJtX2luZm8uDQo+IFNlY29uZCBzZXRzIGZyb250X2lu Zm8tPmRybV9pbmZvIHRvIE5VTEwgdG8gYXZvaWQgdWFmLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBM diBZdW5sb25nIDxseWwyMDE5QG1haWwudXN0Yy5lZHUuY24+DQoNClRoYW5rIHlvdSBmb3IgdGhl IHBhdGNoLA0KDQpSZXZpZXdlZC1ieTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5k cl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KDQpXaWxsIGFwcGx5IHRvIGRybS1taXNjLW5leHQt Zml4ZXMNCg0KVGhhbmsgeW91LA0KDQpPbGVrc2FuZHINCg0KPiAtLS0NCj4gICBkcml2ZXJzL2dw dS9kcm0veGVuL3hlbl9kcm1fZnJvbnQuYyB8IDYgKysrKy0tDQo+ICAgMSBmaWxlIGNoYW5nZWQs IDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4NCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS94ZW4veGVuX2RybV9mcm9udC5jIGIvZHJpdmVycy9ncHUvZHJtL3hlbi94ZW5f ZHJtX2Zyb250LmMNCj4gaW5kZXggMzBkOWFkZjMxYzg0Li45ZjE0ZDk5Yzc2M2MgMTAwNjQ0DQo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS94ZW4veGVuX2RybV9mcm9udC5jDQo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS94ZW4veGVuX2RybV9mcm9udC5jDQo+IEBAIC01MjEsNyArNTIxLDcgQEAgc3Rh dGljIGludCB4ZW5fZHJtX2Rydl9pbml0KHN0cnVjdCB4ZW5fZHJtX2Zyb250X2luZm8gKmZyb250 X2luZm8pDQo+ICAgCWRybV9kZXYgPSBkcm1fZGV2X2FsbG9jKCZ4ZW5fZHJtX2RyaXZlciwgZGV2 KTsNCj4gICAJaWYgKElTX0VSUihkcm1fZGV2KSkgew0KPiAgIAkJcmV0ID0gUFRSX0VSUihkcm1f ZGV2KTsNCj4gLQkJZ290byBmYWlsOw0KPiArCQlnb3RvIGZhaWxfZGV2Ow0KPiAgIAl9DQo+ICAg DQo+ICAgCWRybV9pbmZvLT5kcm1fZGV2ID0gZHJtX2RldjsNCj4gQEAgLTU1MSw4ICs1NTEsMTAg QEAgc3RhdGljIGludCB4ZW5fZHJtX2Rydl9pbml0KHN0cnVjdCB4ZW5fZHJtX2Zyb250X2luZm8g KmZyb250X2luZm8pDQo+ICAgCWRybV9rbXNfaGVscGVyX3BvbGxfZmluaShkcm1fZGV2KTsNCj4g ICAJZHJtX21vZGVfY29uZmlnX2NsZWFudXAoZHJtX2Rldik7DQo+ICAgCWRybV9kZXZfcHV0KGRy bV9kZXYpOw0KPiAtZmFpbDoNCj4gK2ZhaWxfZGV2Og0KPiAgIAlrZnJlZShkcm1faW5mbyk7DQo+ ICsJZnJvbnRfaW5mby0+ZHJtX2luZm8gPSBOVUxMOw0KPiArZmFpbDoNCj4gICAJcmV0dXJuIHJl dDsNCj4gICB9DQo+ICAg From xen-devel-bounces@lists.xenproject.org Thu Mar 25 07:08:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 07:08:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101270.193557 (Exim 4.92) (envelope-from ) id 1lPK6M-00015V-D1; Thu, 25 Mar 2021 07:08:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101270.193557; Thu, 25 Mar 2021 07:08:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPK6M-00015O-8R; Thu, 25 Mar 2021 07:08:18 +0000 Received: by outflank-mailman (input) for mailman id 101270; Thu, 25 Mar 2021 07:08:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPK6K-00015J-O5 for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 07:08:16 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6857fe41-3b7d-47bf-9ecc-6a851b137786; Thu, 25 Mar 2021 07:08:15 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9CD96AA55; Thu, 25 Mar 2021 07:08:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6857fe41-3b7d-47bf-9ecc-6a851b137786 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616656094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vgZHR1EBcLhZNXGcPKJoWbDmcpDE8wHbJ8Vo9rYETcA=; b=mS9WUcJ6CpiFivruTNKxUvapyp/UjJRIlCpfdDigqx9pKXiAkFTaw9ZN8fF9cgMatzpi6I HHwnGof82lXPa/M+vV2jnY7BFQ8pD1G3QVHiZpsMIKJBzXE1mfMwqRj3YFCdTF9h6BGlW8 NhMEAsKhVeXmMPOPT4WeSgQVv2VI48o= Subject: Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code To: George Dunlap Cc: Ian Jackson , Roger Pau Monne , xen-devel@lists.xenproject.org References: <20210324172608.302316-1-george.dunlap@citrix.com> From: Jan Beulich Message-ID: Date: Thu, 25 Mar 2021 08:08:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210324172608.302316-1-george.dunlap@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 24.03.2021 18:26, George Dunlap wrote: > Signed-off-by: George Dunlap > --- > Missed one from my list when creating the other series > > CC: Ian Jackson > CC: Jan Beulich > CC: Roger Pau Monne > --- > CHANGELOG.md | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 15a22d6bde..49832ae017 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - x86_emulate: Expanded testing for several instruction classes > - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 > - CI loop: Add dom0less aarch64 smoke test > + - Factored out HVM-specific shadow code, allowing PV shim to be slimmer But shadow code doesn't get included by default in shim-exclusive builds (and others are unlikely to disable HVM). Also, just to mention it - some of the patches in the direction of !HVM builds getting smaller are still pending. They've been acked (for the most part at least), but couldn't be posted in time (sitting behind the PV guest accessors changes, which were waiting for a decision security-wise). Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 25 07:51:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 07:51:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101274.193572 (Exim 4.92) (envelope-from ) id 1lPKll-0005t2-MJ; Thu, 25 Mar 2021 07:51:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101274.193572; Thu, 25 Mar 2021 07:51:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPKll-0005sv-JN; Thu, 25 Mar 2021 07:51:05 +0000 Received: by outflank-mailman (input) for mailman id 101274; Thu, 25 Mar 2021 07:51:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPKlj-0005sq-Ik for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 07:51:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d09c0c32-380b-44a5-baaa-0671901446f7; Thu, 25 Mar 2021 07:51:02 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0222EAC16; Thu, 25 Mar 2021 07:51:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d09c0c32-380b-44a5-baaa-0671901446f7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616658662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J3ccTgEi4762s9akChpgpLLqdglpoV9FLFLxDEtzaTY=; b=lfIbGZwLkVJX/qtLmJIXhDfflrVQZ47j7adwSa/OgM32Y5I3k0eZ11Z4lB+jlGELlvI5t/ yT6vn9D+pE809fx5NHJLLy46jnvthOh+w/R4nIPyxGl72APCRpG3ZqcP0F9+mVa1QczA2X VUIFLkrm1XntloPbSz7oAMNJfye2n9c= Subject: Re: [PATCH][4.15] Performance regression due to XSA-336 To: Boris Ostrovsky , Ian Jackson Cc: andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com, xen-devel@lists.xenproject.org References: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> From: Jan Beulich Message-ID: Date: Thu, 25 Mar 2021 08:51:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 24.03.2021 22:05, Boris Ostrovsky wrote: > > (Re-sending with Stephen added) > > > While running performance tests with recent XSAs backports to our product we've > discovered significant regression in TPCC performance. With a particular guest > kernel the numbers dropped by as much as 40%. While the change is more intrusive than one would like at this point, an up-to-40% regression imo makes this at least a change to be considered for 4.15. I will admit though that before next week I won't get around to look at this in any more detail than just having read through this cover letter. But perhaps someone else might find time earlier. > We've narrowed that down to XSA-336 patch, specifically to the pt_migrate rwlock, > and even more specifically to this lock being taken in pt_update_irq(). > > We have quite a large guest (92 VCPUs) doing lots of VMEXITs and the theory is > that lock's cnts atomic is starting to cause lots of coherence traffic. As a > quick test of this replacing pt_vcpu_lock() in pt_update_irq() with just > spin_lock(&v->arch.hvm_vcpu.tm_lock) gets us almost all performance back. > > Stephen Brennan came up with new locking algorithm, I just coded it up. > > A couple of notes: > > * We have only observed the problem and tested this patch for performance on > a fairly old Xen version. However, vpt code is almost identical and I expect > upstream to suffer from the same issue. > > * Stephen provided the following (slightly edited by me) writeup explaining the > locking algorithm. I would like to include it somewhere but not sure what the > right place would be. Commit message perhaps? If nowhere else, then definitely in the commit message. But perhaps it could (also) sit in some form right ahead of pt_lock() / pt_unlock()? Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 25 07:53:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 07:53:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101278.193587 (Exim 4.92) (envelope-from ) id 1lPKoQ-00061L-5E; Thu, 25 Mar 2021 07:53:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101278.193587; Thu, 25 Mar 2021 07:53:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPKoQ-00061E-1x; Thu, 25 Mar 2021 07:53:50 +0000 Received: by outflank-mailman (input) for mailman id 101278; Thu, 25 Mar 2021 07:53:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPKoP-000619-Br for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 07:53:49 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d51ecd83-67c1-4630-83ae-28d9c5075afe; Thu, 25 Mar 2021 07:53:48 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D03A5ACBF; Thu, 25 Mar 2021 07:53:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d51ecd83-67c1-4630-83ae-28d9c5075afe X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616658827; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wC00qsoMd0Vpe0LEgrn1pSDhjhoVGrMCuJHCsjhvysg=; b=Lw1LPfFbH5ni7z+VDpZ+wAtBiFfF29WOnR9wnosqYhciI9C9QfeJI17KnznOGA6zCH9Dmo n7xc7cMVdmT7PtscDuF9cRW8ZmvjlxNycctaPoPKulCxf5cZA2DU7cbH0enRmyaLpAt2v4 FRKbUaXOLug/l2EQHSPCuTF7lDPvyVo= Subject: Re: [PATCH 1/6] Intel Processor Trace Support: Add CHANGELOG.md and SUPPORT.md entries To: George Dunlap Cc: Andrew Cooper , Ian Jackson , Tamas K Lengyel , xen-devel@lists.xenproject.org References: <20210324164407.302062-1-george.dunlap@citrix.com> From: Jan Beulich Message-ID: <1fe59844-d512-805d-fefe-8522cccd59ca@suse.com> Date: Thu, 25 Mar 2021 08:53:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210324164407.302062-1-george.dunlap@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 24.03.2021 17:44, George Dunlap wrote: > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -247,6 +247,13 @@ Export hypervisor coverage data suitable for analysis by gcov or lcov. > > Status: Supported, Not security supported > > +### Processor trace support > + > +Support for using Intel Processor Trace technology to trace guests > +from dom0. > + > + Status: Tech Preview While it may not strictly be needed here, perhaps for consistency with other entries Status, x86: Tech Preview ? This minor aspect aside, Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 25 07:57:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 07:57:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101281.193599 (Exim 4.92) (envelope-from ) id 1lPKrn-0006BR-Ku; Thu, 25 Mar 2021 07:57:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101281.193599; Thu, 25 Mar 2021 07:57:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPKrn-0006BK-Hx; Thu, 25 Mar 2021 07:57:19 +0000 Received: by outflank-mailman (input) for mailman id 101281; Thu, 25 Mar 2021 07:57:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPKrm-0006BF-7m for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 07:57:18 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8f82e1fd-1770-468c-9d59-019af01bddee; Thu, 25 Mar 2021 07:57:17 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8E0ACAA55; Thu, 25 Mar 2021 07:57:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f82e1fd-1770-468c-9d59-019af01bddee X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616659036; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qqvuab5upILA1d/7jqjZKuvgtOPJL2VBrpR9GKTWEIY=; b=V/bmPFZjpoAgzD5m+0B3S+7b11pNpjfTiUFfFKJUfpPAKyZ6Et5sY/FtVR6a+vTq8Py7Yz mIsSSMtUj31KJVj33hx0kPJ3YMfBVLv8sqgHTScfQQY0wgWKqnobe1lh1PRgs+C9rH08S8 cwKjTLu6dK9WE3fXlTRzz+LR4feBIzM= Subject: Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation To: George Dunlap Cc: Ian Jackson , xen-devel@lists.xenproject.org References: <20210324164407.302062-1-george.dunlap@citrix.com> <20210324164407.302062-5-george.dunlap@citrix.com> From: Jan Beulich Message-ID: <33f78891-c894-b41a-a1a3-82aac1f57b8d@suse.com> Date: Thu, 25 Mar 2021 08:57:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210324164407.302062-5-george.dunlap@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 24.03.2021 17:44, George Dunlap wrote: > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - Named PCI devices for xl/libxl > - Support for zstd-compressed dom0 kernels > - Library improvements from NetBSD ports upstreamed > + - x86_emulate: Support AVX-VNNI instructions > + - x86_emulate: Expanded testing for several instruction classes TBH both seem too minor to me to be mentioned here. If I was to pick just one, I'd keep the former and drop the latter. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 25 08:07:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 08:07:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101287.193611 (Exim 4.92) (envelope-from ) id 1lPL1O-0007pH-SZ; Thu, 25 Mar 2021 08:07:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101287.193611; Thu, 25 Mar 2021 08:07:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPL1O-0007pA-OX; Thu, 25 Mar 2021 08:07:14 +0000 Received: by outflank-mailman (input) for mailman id 101287; Thu, 25 Mar 2021 08:07:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPL1M-0007p5-Tl for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 08:07:12 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9cb0106b-2e42-48f2-be2b-26a8878af4d2; Thu, 25 Mar 2021 08:07:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 33231AA55; Thu, 25 Mar 2021 08:07:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cb0106b-2e42-48f2-be2b-26a8878af4d2 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616659631; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7PHw/ZB/kcPNh6PaDs7Hs8y5n3CUjfPt512+DzawP/A=; b=HZllZWmDQ53qe9RXUbkmgChqthOlEucpN/cVVrecv5UIMRU+VbeJ9WCND+epP58dEd5amP Q6ShK7QfPLZ5x0kV0T9fOiB3fZdp3kGT3O38GZjmYVZ/ba+OFxJ35F3wsLeHDL3wD3+7E6 +AvCMIwbHemL/I5BmOb2BgX9D7NaC5I= Subject: Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document To: Stefano Stabellini , Christopher Clark Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "Daniel P. Smith" , xen-devel , Andrew Cooper , Stefano Stabellini , Julien Grall , Julien Grall , iwj@xenproject.org, Wei Liu , George Dunlap , Rich Persaud , Bertrand Marquis , luca.fancellu@arm.com, paul@xen.org, Adam Schwalm References: <20210316031814.10311-1-dpsmith@apertussolutions.com> <20210316031814.10311-2-dpsmith@apertussolutions.com> From: Jan Beulich Message-ID: <95447252-c50e-9521-4c0d-b5297b22367d@suse.com> Date: Thu, 25 Mar 2021 09:07:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 24.03.2021 20:10, Stefano Stabellini wrote: > On Wed, 24 Mar 2021, Christopher Clark wrote: >>>>> I'm also not sure how you are going to handle things like SR-IOV >>>>> devices. Right now SR-IOV capability is setup and initialized by the >>>>> hardware domain, and the new virtual devices are notified to Xen once >>>>> setup is done. Do you plan to move those bits into Xen, so that it can >>>>> setup and initialize the SR-IOV capability? >>>> >>>> While you could do it with the vPCI, as you point out this will not work >>>> for SR-IOV. With hyperlaunch, these cases will require the use of a boot >>>> domain, which is for all intents and purposes, a lightweight/restricted >>>> toolstack domain. >>>> >>>> The boot domain will have to do the necessary operations to ensure that >>>> when startup is finished, PCI passthrough will be successfully setup. >>>> Note, this may have to include the boot domain unpausing the hardware >>>> domain to help complete the setup before the boot domain can exit and >>>> allow the remaining domains to come online. >>> >>> OK, I was expecting hyperlaunch to do all domain creation in the >>> hypervisor. >> >> That is my expectation too. It is what we've been planning for in our >> work so far but we can work on explaining the steps involved in >> constructing the domains more clearly. >> >>> If you offload domain creation of guests with >>> pci-passthrough devices to a control domain and/or hardware domain, >>> I'm not sure I see the difference from normal domain creation, ie: >>> it's no longer something specific to hyperlaunch, as I could achieve >>> the same by using the existing xendomains init script. >> >> So that's not what we've proposed, and hopefully not what we'll need to do. >> >> Do you know if there is a need to perform work to support the >> assignment of PCI devices at the point of domain creation (ie. in >> domain_create), rather than handling it in a later step of domain >> configuration, prior to the domain being started? > > Let's leave SR-IOV aside for a moment that can be a bit strange (if I > recall correctly sometimes VFs can only appear after the PF driver has > been loaded). Yes, and iirc beyond that the number of VFs can (in Linux at least) also be controlled (read: changed) when the driver is already loaded, via sysfs. I think such flexibility is desirable, as a device's resources may get partitioned differently depending on the number of VFs, and hence the number of VFs may affect individual VFs' (and maybe also the PF's) performance. Otoh if the system as a whole gets statically partitioned, one-time setup of VFs will of course do. I don't think though that SR-IOV can be left aside - whatever is to be done here needs to take it into consideration from the very beginning. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 25 08:18:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 08:18:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101294.193623 (Exim 4.92) (envelope-from ) id 1lPLBv-0000iP-VU; Thu, 25 Mar 2021 08:18:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101294.193623; Thu, 25 Mar 2021 08:18:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLBv-0000iI-SN; Thu, 25 Mar 2021 08:18:07 +0000 Received: by outflank-mailman (input) for mailman id 101294; Thu, 25 Mar 2021 08:18:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLBu-0000iA-5R; Thu, 25 Mar 2021 08:18:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLBu-0007mq-03; Thu, 25 Mar 2021 08:18:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLBt-0005uw-LX; Thu, 25 Mar 2021 08:18:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPLBt-0005VY-L6; Thu, 25 Mar 2021 08:18:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=itQJHUO5z61DXzod2Aj7yNYjjoxB7iyY2R1Gu35NFAM=; b=KH31yU4IN3zf4cgsPyNjAbY6l1 6lwe2T237nQrxQwNsMB9sPVP+35jnv4vtHGnnjK7lQ+rBMShmCj9lDXBzad1EmTP1skMekttFDeuE sTm3dLhgHGozbs5smnWdTI5U6alueX5eT/80KBneXkqUyNPP+BDGWb+gDpZZ0meUYdoM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160381: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7acac4b3196caee5e21fb5ea53f8bc124e6a16fc X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Thu, 25 Mar 2021 08:18:05 +0000 flight 160381 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160381/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 7acac4b3196caee5e21fb5ea53f8bc124e6a16fc baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 236 days Failing since 152366 2020-08-01 20:49:34 Z 235 days 404 attempts Testing same since 160381 2021-03-24 05:15:26 Z 1 days 1 attempts ------------------------------------------------------------ 5235 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1300956 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 25 08:32:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 08:32:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101299.193638 (Exim 4.92) (envelope-from ) id 1lPLPm-0002ZI-9e; Thu, 25 Mar 2021 08:32:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101299.193638; Thu, 25 Mar 2021 08:32:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLPm-0002ZB-6F; Thu, 25 Mar 2021 08:32:26 +0000 Received: by outflank-mailman (input) for mailman id 101299; Thu, 25 Mar 2021 08:32:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLPl-0002Z5-6G for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 08:32:25 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6fd358e3-5ca9-4315-affb-dd81a36b8067; Thu, 25 Mar 2021 08:32:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6fd358e3-5ca9-4315-affb-dd81a36b8067 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616661143; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=amYIsVw8zmnTOdkTjgkE+QwgHVtqS0153MlLRgZ7coo=; b=LvoCq74A+l2CT0TnQqurs72bkfVvCo0SekPuRkAJwtJL/cnDrWl/9Kf8 tVneArAkf5L+FPdUb4T3EaiNmfYmpK2oHu3M+j70/paFWc37XU7TJnhWF SEWxRUH6+zeW3OxlWzH+3fFU5lGjN7ZZKGHwW4BTba/h0wca1Ky30JqiS o=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Se3jxdsuBFJvUfpgD8poyzt/hmPeUsmlnf7ZJ1lbjmVnxI+yFMP9ePxaUgaP1perNkjxtf6MNR 399AF+IEHPJl7VV3GuCIPq1OhDJS8xi9AXNEuH/Mej2l2GrB6eRbYAj5NL756DkniY0ygMRWUF YmKB8uHgsprV2DtEXXAkNJc2FpNwZM/URXmQ0q/vAbYRyfeDOq0pNu/Qnw+xvj8LuPElqnG3lk NB85KfbZTSeIbKVQluWEgkozH3V8I91Hr/4CS1FZTWJM9hYxrc52UaFEpUu5sjpGpC0d1M+19G cRI= X-SBRS: 5.2 X-MesageID: 41539134 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Leg8s6iAu+xlEWA36I3XrWjtenBQX2pw3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+YsFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmuZ tIW5NVTOf9BV0St6vHySGlDtctx8SG+qi0heHYi0xgVx1udrsI1WZEIyywe3cGIzVuL5w/CZ aa+45rpyC4f24Wc8S8ARA+LpL+jvfMk4/rZgNDOgUu7xOAgSjtxLnxFRWZ2Rl2aUIz/Z4J92 /Znwvlopiyqv3T8G6m60b/zbRz3OHgxNxKGdCWhqEuRAnEpw60aO1aKt+/lR8vpuXH0idOrP DtpFMaM913+zfteAiO0GfQ8i3B9Bpr1HP401+fhhLY0LzEbRY3EdBIi44cUjax0TtYgPhG3K hG332UuvNsZHuq9kSNhKm7azhQmkW5unYkm+II5kYvKbc2U7NNsZcZuHpcDZZoJlOK1KkcDO JsAMvAjcwmF2+yUnaxhBgK/PWcGl43HhuAX3EYvN2U3zV8jBlCvjUl7f1asXEa+J0nTZ5Yo8 zCL6RzjblLCvQbdKRnGY46MIeKI12IZSiJHHOZIFzhGq1CE3XRq6Tv6LFwwO2xYpQHwLY7hZ ypaiIWiUcCP2bVTeGe1pxC9R7ABE+nWy72981Y759l/pXhWbvCK0S4ORATuvrlh89aLtzQWv 61Np4TKeTkN3HSFYFA2BC7c4VOKEMZTNYetr8AKhOzi/OODrevmv3Qcf7VKraoOy0jQHnDDn wKWyW2C95H6mytR3/kkDncU37gYSXEjNBNOZmf29JW5JkGN4VKvARQo0++/Nu3JTpLtbFzXE YWGsKjroqL4U2NuUrY5WRgPRRQSmxP5q/7bn9MrQgWd2f9cbMJvcSjaXlftUH3YiNXfofzKk pytl538aW4I9i73iY5Ee+qNWqckj81qG+VSYwf3omO/93sdJ99LptOYt0+KSz7UzhO3Sp6om ZKbwEJAmXFECn1tKmjhJsIQMfFd9d9hw+vCdVOqW3WsHidoc1HfApZYxeeFeqsxSo+TTtdgV N8t4UFhqCbpDqpIWwjxNgjPEZ0c2SRCrJeBAGjbIFZ84qbPz1YfCOvv3i3mhszcm3l+wE3in b6JSOZQ/3NH2FQo2tVyKrs7VNyeFiMZk4YUAEIjaRNUUD9/lpj2+6CYaS+l1GcbVYP2ckxGj DIazl6GHIk+/mHkDqu3BqSH3QvwZsjetHHBLM4arfJxzeGM4uTj5wLGPdS4bdoPN3jqfUwTO qaYgOZRQmITd8B6kiwnDIIKSN0oH4rnbfUwxXj9nG/x2N6LvzIIlhqLotrVe203izBfbKv35 p4h95u4rf1HWX1d9KcyabYKxREMQjepGaqT+cu7bBY1JhCwIdbLt3+a3/v0noC4TAVaOHTv2 kaSL5g4L/ANpR0FvZiMx5xzx4MrpC3MEAvsgbKGecwclEmsm/DM7qyks/1gItqJnfEmRD5Nl ae+RBM5vvpXyOM0rgBFqI7SF4mH3QU2TBH/OmYcZfXBxjvX+Zf/ECiOnvVSs4WdIG1XZERpA 19+deGgqu+cDf5whnZuX9eLrhV+2iqBeO0DwTkI58Ez/WKfXCNiLCt+si9kXPeTia6cV0Rgc l9TnMrB/4zwwUKvckQySi9Sqv+v0IjnR9/2Fhc5yHQ87njxnzaE0FAORDembNMU1BoQyG1sf g= X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="41539134" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E+Ux7iS4js5oV/DVd+2HsjcLgB5SezvBf+OmVXhWTtcpmd6y0UChBZ7oV4OjUgb14I6fxFsM4dk2jqoE4T/bkiEa5RidUWlshss8OcaE42GHRDseNL31ySfe6z4XI37+Y/ZFpgE+30LXcTF0549tpQs2+eseELKxGyBueiB78U+DT23ydnvDDq7T/rdosNcqCmHnKQFc0iDSGPrTLf4pw9leboBSYMxwvpVus0U3k/OWv4BHl6XTLJXd4kpx0ixqjhJ8k5hBEx6Fv6QBIpMwFOv/1K3n7lr88/rufhsQV6yNSMXtMfSTMAret1rxFgmNTwB5aZD+99Jy9vJ3dBipwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xqIKGjeSyaprxH/bwphBFRAhYHRxwXZoMYk8NKmpd7M=; b=nZjsnxlHv5t/dZtrTujTC3/hSJdJtwS5bgqaLQdFfWawKcxeyuRbqXxDw0PwX5Fzmebu9NWzG0yogg2/grsmZZPmJSslFdlBPJjGyWoDTJsjBeiMwWRa4mAeLzr4/UQjvzJMGQ4s9lGB3JGMCuo2ACr7mFKQppmRDmIjzOiWZ+zJc/Sbpr3dmaYxR00gaW8BHWdF4+XOgnNqYjDSSEAE+tWTQ7PNBTepLhZ74BJClmHDviC6DiEPfJ0bJqhzDv/9B1Ge/G6LYWZl8y9Pw3WMcB17IEk4cg3/vba9H2Kr1vXehfaPFWa7Kflwurb90zwKiB8UswSR0nJZR2qh+dRvuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xqIKGjeSyaprxH/bwphBFRAhYHRxwXZoMYk8NKmpd7M=; b=ScjVsqoyt1lAEipbD0EYkY6s8ExlLgT4Srz3h0Ux8BiI64tP2eduq0uIm4wy9xARGu1eKGC+yeEmmUcbMVGteJjDabgFoScgvkRIImY63G6wP0KxfTK/vJWjn7on6gvOQxBLr/SYQ9XVLSYjGkC4ed3bwp6CyQnZO3FE3WE1LtE= Date: Thu, 25 Mar 2021 09:32:13 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Christopher Clark CC: "Daniel P. Smith" , xen-devel , Andrew Cooper , Stefano Stabellini , Julien Grall , Julien Grall , , Wei Liu , George Dunlap , Jan Beulich , Rich Persaud , Bertrand Marquis , , , Adam Schwalm Subject: Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document Message-ID: References: <20210316031814.10311-1-dpsmith@apertussolutions.com> <20210316031814.10311-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AS8PR04CA0011.eurprd04.prod.outlook.com (2603:10a6:20b:310::16) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf7ff887-ee0f-45b5-9e2f-08d8ef688181 X-MS-TrafficTypeDiagnostic: DS7PR03MB5591: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aoeVhFqZNqJdEy+6UL2QZx7B+dGE/Y1sebDlUSsl8k6K/iIaXtBNkbatBkFjKGsEMXYRiid2iZFLOVGTgw7HJ1B9sE3D7QIDkIMIi5GOoD/XBmBITVTRePpr8qrWmlyOsw0LcsWjerpyVKR8LgJ+L2OtBUJUKNriq/+797no+NsiloffQ71BMqH0nbwoKujy+FvUMQgnuepKqdbcfHpagpBTC6gq+nxqEWowtGvZ2aIPRlJpmvwxy1+Qw8RMZJlprusxjKwRKWq7xBTJRi+JRe10QXAz7FhdnW9xHGtMwZoRnTtIyF+VUXJFIe0PQvQ6dr9kHuxCALwY0SaGds6ViWvHoh6Pj0zuQdMgO8+51C2HiZJxeB0ZQW1OuATfYPmllho+aiN5bMp+FydCw1k9gq3dgdPnUXcSF5pDmlFge1RjGKvKKEhLHs/+9p2oc5lNEG2wJsmPjnJq3cC72XMMYJALzdNQinyc4VyVgYop5fuvGQZ3iGRis8RJrjLRfQnFn0MbkhKqzRvFDJxvfKwglWnT18fxP8h+F+He+dAuZ/GgisjqhAdDl8Dl9g2YZlFUABLMCnDyYLDO2rVqa06onxDBBk9rPuxOvrNtHm1zOruS9exzB5aS5SgSFGXDoGqxa6vg2/1SdodNkq45VWCVKOeVy5cb81K2sKYOGV7m8wA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(346002)(376002)(396003)(39860400002)(136003)(8676002)(86362001)(316002)(54906003)(9686003)(38100700001)(85182001)(478600001)(7416002)(956004)(4326008)(66946007)(16526019)(2906002)(6496006)(6486002)(33716001)(186003)(53546011)(5660300002)(6666004)(8936002)(66476007)(66556008)(6916009)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eGlIVVkyQi9JMUxjR0NQbWcxbFBKUzlTSVN0VDEwSWYydGdlVEQvWGdldHpW?= =?utf-8?B?VFZNVHlRWUtqUmgzbXF2YVcybVdrTFNnb1NVS1p5RHMyWnBQQWx2NjJIbjAw?= =?utf-8?B?UTlBbmN6MmdRVjZmTHFndE9nQjdLVVRJNVkrbVRWd0lrcGRaVXdyc0hFUnZT?= =?utf-8?B?djZFL3YybEp6NGRZS2d3amtJci84VHNCcXRhNTJUNU5pUjFRa0lCdnpsbnd3?= =?utf-8?B?bWJ4cHlIWlljdEwyN3p4aTJrMDdlQUpQaUt5TThtd1BWMVdSL3VFTU9HbDJ0?= =?utf-8?B?VnYwZlpIU3FqNVJTeTVpUW9rRnJ3UXR3SURaU2ZTcGZkRnplMmsvSW5TK3Zv?= =?utf-8?B?bjMxVUQ2ei9Mc012ZXM5Nmg0RWpKSkVsMlhQZ3picFlnMEJHMDhpRERYRWt0?= =?utf-8?B?OG94bWhjV3QzUU5yUFRWNG01UnBhbXoxOXVFUGdPZ294YjNlU0pla0ZUZ2ZU?= =?utf-8?B?eUNwQnVJVFFEQWlSMW1WMk16MlFMSkdUci9mYVo0TjZsVncwd1ZrUVQ0VlM4?= =?utf-8?B?Q1ZqZFBUeWlSa1dCKzNpQ3RrRURuSG51cVJZM2NzeWtKQ0ZrTmpDNGFJQ0kr?= =?utf-8?B?T1ZMZzBIcTJFZ0I1bm80MDEwTHJ0NEJhTmxVVWFtZ3FtdTV3RDcyVkdKOS9k?= =?utf-8?B?RzJIbktDQlRlLzVKdm50d0ZadjRyamVBZ0pBb2JZMWJ5dmNxNkZ0cjlvRUFr?= =?utf-8?B?QnUrdUk5TTIzQjZSUmdZYzJPby9teVZyYUJscE1HeEdOMXBsWURmQ3lzZ2ht?= =?utf-8?B?UUlTSTBWM0xEZlY5bVlxZjc5cnVGOE9uT0p6MndnZ1VJUXcrMys4dHNoVkxx?= =?utf-8?B?OExWWFlqNkVJcDhET0p5clB1SVZSa1NzbDJLUytzdjZ1QkdaeXdRTUdHQjVV?= =?utf-8?B?cS9BSU5yMk9DRVpGYTFVTWFyY3JVSW9EeUdIMFhvOVJNQ0IySDFMb3Q4NVBo?= =?utf-8?B?S0pKRTVUSmxGcUFJVGxOWUhXMG9aeWMzNUJUS0lsVnlXdDBza0g0R3p1cE10?= =?utf-8?B?QnVjOGRXdlFBaWlhblRrb3MxNHZML2MwelpraEtkWHRBc2tnTXRwSXFSUlVO?= =?utf-8?B?QzNUMUhZMktiS0wyT0FnSmhpWEZBYzA2TjV4SUNJYlJKNGE1ZEV4dENueDA4?= =?utf-8?B?V3RIUnVFVmZaMnJpZlVIYzNDaTZMeUM0TGlvR2h6dzhCTzJuUm1oc1U0bnIz?= =?utf-8?B?M0svTkNIMmJCVVhjaDNrQktwRkE0NHFVRG5nRnZGQXdkWVVpMkx2d0RlM1NV?= =?utf-8?B?VFM2THdLQnlhU2xLenRYVk05VzlzaWI5T0cybDY3K3p5Rk5VaEEzeDg3Ynht?= =?utf-8?B?amU1UDFtUkUyb0pEZWVVajR2RkpqdzMzVldxdEM3Tk9XQ2hJdjJjOVBSSE9V?= =?utf-8?B?SGtCa291VXM3cEJtQkw0Z2VYWE56UFRBUFNQOGd2enBCeGQxN1lGamhkcVVI?= =?utf-8?B?c2dzNVpsaGRkS0wrUFBJMlU3V0tneTBFS2tCVW9hUC9yZVR4QnYvZEVCMUhX?= =?utf-8?B?TFZMbEpNREhEbC9ReGxsK2FPbkZlODVSN2dkZkMyY2szNW84VitvdlFNWVpX?= =?utf-8?B?TXhlc3VLNHBETEwyd2dab1UrcWt2ZW5tNkJpbXJ4elZneG9oendlRlQ3dGha?= =?utf-8?B?N3hRS3Y1dXRreXJuSHBhajVNQnl6RFA3cmpFN2gxRDhoVnlkdmVZN3NUWlVt?= =?utf-8?B?NzVpMUhkYytLb3lWNENjcjI5WVU3enl5Z3dHcEhGN25MdVVFYVRJeEtkMzdt?= =?utf-8?Q?JINbOf/vJxxrARlFAS68a+ikIC+/hpnwXjNSQuH?= X-MS-Exchange-CrossTenant-Network-Message-Id: bf7ff887-ee0f-45b5-9e2f-08d8ef688181 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 08:32:20.2194 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rWGGoudidyfH3reY5uD0Jw1dw6QIhI59kjdHOUL4doaSTuPCkbGBdhUcnhbD2ZdUzOrd5kC4Zl047eDpk0LhWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5591 X-OriginatorOrg: citrix.com On Wed, Mar 24, 2021 at 05:53:26AM -0700, Christopher Clark wrote: > On Wed, Mar 24, 2021 at 1:01 AM Roger Pau Monné wrote: > > > > On Tue, Mar 23, 2021 at 10:39:53AM -0700, Christopher Clark wrote: > > > On Thu, Mar 18, 2021 at 9:43 AM Roger Pau Monné wrote: > > If you offload domain creation of guests with > > pci-passthrough devices to a control domain and/or hardware domain, > > I'm not sure I see the difference from normal domain creation, ie: > > it's no longer something specific to hyperlaunch, as I could achieve > > the same by using the existing xendomains init script. > > So that's not what we've proposed, and hopefully not what we'll need to do. > > Do you know if there is a need to perform work to support the > assignment of PCI devices at the point of domain creation (ie. in > domain_create), rather than handling it in a later step of domain > configuration, prior to the domain being started? So while I think you could indeed create a domain from the hypervisor in a paused state and attach the pci devices later from a control/hardware domain, I don't see much benefit in doing it. If you need to end up waiting for a control/hardware domain to attach the devices and unpause you might as well do the whole domain creation from such control/hardware domain. Is this split done because the control/hardware domain would have a very strict set of permissions only allowing attachment of pci devices but not domain creation? I think the permissions required by a control/hardware domain to attach a pci device to another guests would end up being fairly similar to the ones required to just create a domain from scratch, because a pci attachment requires modifications to the p2m. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 25 08:36:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 08:36:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101306.193650 (Exim 4.92) (envelope-from ) id 1lPLTo-0002kg-VG; Thu, 25 Mar 2021 08:36:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101306.193650; Thu, 25 Mar 2021 08:36:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLTo-0002kZ-RJ; Thu, 25 Mar 2021 08:36:36 +0000 Received: by outflank-mailman (input) for mailman id 101306; Thu, 25 Mar 2021 08:36:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLTn-0002kU-5y for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 08:36:35 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a824bf70-059c-4884-9558-b6011f272324; Thu, 25 Mar 2021 08:36:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a824bf70-059c-4884-9558-b6011f272324 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616661393; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=mdoXYDJ2mJ3pNru57UQOH75LghTbsmOgIOYvHa5JOHw=; b=Zhis16u0tEU8DoVRvEO2YSe/d3mWEtOS6n1fmvSAM5hoVpbnahAOXkz2 J0dN0mpb3PgZz7QmGn4KXc1o0J3yJE00RWU34oDigIgsNxKJHniqcajGT zKbkV0hhSPpss0Wy2RBAHLn+RQHr/kbxNDo7GCjGwBAl+5+hXPuaX5dso E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Ga8gCpdqVFu0kc3d7yOxmFoujri0o1YOBS+igN1JkW+SzieYHroDYfQM1Jm60YLwcrIRP/PKwr UsB4RYAGwirVHBRgcxU4IQ2I2o+w5yDcqOOiO7ANbK/bnnD8LFfPf1Kj4hS6Ymr3wDArGoLlYl yLFrZgnoQ8y0b62X+VWI8DS3wDglrtIa5L7yxxTdmW9d7pOPZ+L4IRO7VhcmVrXpaWuVBlIOEF Jn2DohDdBG7brZPRmpj4tvPMFb3VueflQUNZkm/LEbkeqvmC+N3YOJMvPwe2i+oH/9BvKMplL2 qTw= X-SBRS: 5.2 X-MesageID: 39975718 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:hrX8EahmynDPD6CRTHvdbBueNXBQXw5y3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+QsFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmv5 tIW5NVTOf9BV0St63HySGzGdo43Z2j+Kenme/Rwx5WPHRXQol98gZ0DRuaGEVqRA9AQaE0Do aY+9ACgSGhd3QRZsHTPAhyY8HoodrXmJX6JSMXHhJP0nj2sRqEyp7fVyKZ0BAXTi9Vzd4ZnV TtvgTl6syYwoCG4zDG0Wu71eUtpPLAzZ95CNWImowpLFzX+3SVTaBAf5HHgzwvuuGo7z8R4Z zxijMtJd565X+UXkzdm2qc5yDa3Dwj62DvxDaj6BONz72bNVBKc7s7uatjfhHU61UtsZVH6Y 0j5QKknqFaAh/akCP268KgbWAYqmOOrWc/iulWtnRDUOIlGfhshLYC90BYGopoJlOH1KkbEf JjBMyZxPFafULyVQGmgkBTwcehVnl2IxGeQkJqgL3r7xFqmhlCvjYl7f1aslE43I8hUJlO+/ nJP4BljqtHQMN+V9M6OM4xBeenAGnEQRbBK0OVO0nqGZsGNXXEtoLt7K9wwO2xYpQHwKIonp 7MSklVuAcJCifTIPzL8IxA9xjMRGmnfTD10cFY+rByp737Q9PQQEu+YWFrv9qrpv0eBsHBe/ KrI5JQHtrqMGfoE5Yh5XyYZ7BibVUOWsgcutI2QGuUpNPaD4X2uuvQYJ/oVd7QOAdhdWXlDn QZWj/vYO1G80CwQ3f9xCPcQnX3ZyXEjM9NOZmf0O4JxIcXMIpQ9iATlFSi/8mObQZPq6osYQ 9DJ679jrmnqWTexxeJ00xZfj5mSmpF6rTpVH1H4ScXLkL5dqsCsd2DeWZUmECKPAN7Utm+Km 9ijmUy3ZjyA42bxCgkBd7iGHmdlWEvqHWDSIpZsrGf5O/+E6lIXKoOaehUL0HmBhZ1kQFlpC NocwkfXHLSETvolOGMkIEUPufCbNNx6T3bcvJ8mDb6jwGxtMsvTnwUU3qFSsiMmzsjQDJSmx lf6KkarL2cmSu+CGc2jegiWWc8PVi/MfZjNkCodY9UkrfkdEVbVmGRnwGXjBk1Zy7L+iwp9z 3cBBzRXcuOLktWu3he3Kqv2khzbH+hc0V5bW0/loFhC2LcuDJW3fWQbqS+l0udA2FynN01AX XgW38/Mwluz9e42Fq+gzCZD0grwZ0oI6j6F7Qsc7ba31u3M42WnaQ6H/tZlawVa+zGg6sua6 ayagWVJDT3B6cCwAqOvEsoPyFytT0DivPn2Brs6UCkwWU+CubOLFlaS7YSJMy36W/iS/yU0J J2rctdh5rhDkzBLvq9jY3HZT9KLR3e5VS7SOwlsrh4l6M/vrkbJeiVbRL4kFV8mDkuJsb9k0 0TBJlh6LfaI4l1Yog5YCRC5Gckk9yJMWomugH7GfUFYFkolnPXVun5p8udlZMfRmm64CfgM1 iW9CNQu8rfVyyYzLgAFuYbOmJNcnUx73xk4cKPf4DdEx+RavpC5UO3PxaGAeZgYZnAPY9Vjx 5hp/mUguecdkPDqXTtlAo+BpgL1WmpQcm/Wl3RXcFJ9sG3IlSKjO+B5tWpgDL+VDu8bAA5iO R+BActR/UGrgNnqoI50iK/EPOq5m0klkZT+jFhmBrG3JO87GLSAEFBNkn4j9FuRiZIW0L41f jtwKy97jDBxxRrnbPED1xde9lSHcN4dPmBEw5ebewRtqWv5awhn2BqZwovFXc1jFnGrrhb9I b8/PXZQOv5D3j0fXoH5D5eH4Zx2ggms3tJfcT7zZWzZGwsZ7Q1Ksp6woBdizRyrFfvq3Uach V2rwQtkqXANEbuMXg5Na/gm8/RmxgXpK+L7jRV1TRts2LirFGXoF7umcmp/1Iysm3Gtwdi7Z ynewFZulcViidXhYhgOGGKS2jiXDesN0721rIhPTlYDn011/83gBerFdhEqrmOi0x+rTo6BS AsxaqMDWi3c0TPKfTgaDSxUNilCt97ZPhcfmIFMn6tLRzB3pA9VAjBdttt3gil801+RpSmK+ ejekaQHZMN9KsfN+jwWIaYn97JzRUc+HcIrY734Eb13s5C/IeePEp7t9l4bq1ifgGt9y182s GIXQ3OM5MMiRul41DJ+GBdPpsO3w8RwUMGvi8eFyOjGsOrSiha1XY74o6sQDdd1N2IRtlUu3 rQuFKtuHHZMwaPLUmnMod9qU4B5ULGW4LVv1+zZrr3OVRT4ZiXYO6EqRY= X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="39975718" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TbImrjRSoP8MCaukz8AwKZAu4/fhFIPXDDNeNNAM16QCVnh5EBj0mIFMStm2ku0b9KzZBSCU9nBLIc6z5pi7u1rUZBH6RROmXSAv4jiHuFiPeAe1ZvTqF9Fht1nDUh3hoQ1c1IN9VCcan69mb6eTi6VhgVXuIgbehiKnOhLsW0662yND9P1f4iSFhl/u+VIWyJt1+RIHZ5xlq/uX1FOYol+aBz/mUtfQ0xPK4tr04b1Zy8GWznveVmVuZu5L2FqtbjInUEv7478V6QeC9QjXBAl+kWcPw6muRX/naH/NRBQwmtquyWZ0O75GbQeL7628p0EDgbTcK/Ftf5scbRi+oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rMseXzzuh3LwxBLdIsHCmwcEHix6OfFdjI2TJF3OQXk=; b=H54Z+OH98NDj6Qprh088ECvPt4RQmTYeU6FK1ufyjAGOFt2gVhfiOrRa1nER2Tma0zMJ8i07TX6WDwHAxtE9DclF7T+33Ddh4BIgVVdZ7z6UqzCvc2q8Fwk37bXo4p0/FBCT7cGVEPBfmtVXbPa2oKzuo9ceXwjDWiSGtobpv/stKod1hpVVY4YZGbSry7M2BOf2HpuorrG0LK5edGUKMOoj6qRoATmFat7EH4I06E8HPGa9DRw1/aAmnFIx2OcuvPYTLYYfGjtHF4iHKgdUkjtBHq3SnaR2DPL/J1Fmki9V95rfDR3OPiZbw7Y589eucLYWOs5IhSwLMR1jjC76gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rMseXzzuh3LwxBLdIsHCmwcEHix6OfFdjI2TJF3OQXk=; b=GSsxHi5sJuWji9o1ZAT2PLZpdK1GN9T4sveirTUYl2MZtAY4COwpXV3KVQatK1JySQQq0rYazg63BDKtbPL4IMNo7XzlPEK4sKRlWQGJHlp+jtz5tc7gbXFq8Z3Xv2viVYYedAQXFzxHibWEA+DynywAiYUSFbD2lrs6H/VcG7Y= Date: Thu, 25 Mar 2021 09:36:26 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andy Shevchenko CC: , , Andy Shevchenko , Mika Westerberg , Linus Walleij , Subject: Re: [PATCH v2 1/2] intel/pinctrl: check REVID register value for device presence Message-ID: References: <20210324154312.61878-1-roger.pau@citrix.com> <20210324154312.61878-2-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: PR2PR09CA0022.eurprd09.prod.outlook.com (2603:10a6:101:16::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 764ea53d-1f10-4480-52d7-08d8ef691735 X-MS-TrafficTypeDiagnostic: DM6PR03MB5289: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LEs86qzT0bGUrr1+giCxSZ47A9jm6YIxcalE11CjybEr+a7LwkWO5/rhgb1gmERbI2fKJUpEcURoVaLKjxVReQznKSUxy0jmIkWl2E3LGtmoXcuMJQQtSQTxX7i++bqeLgODIMBl0EuSq8BRQ84k6P2mBu9SyautJE1LRmRZMbGBDSBzEPX+Qg0lBon1aCcAqOpVfA1l9YrUyhIdqGLCkGYBuV1R9LJ/11tzBjIkcXvjTg18KvyO4bzs/o+WfICr/EX4qxt+8qAt1ysUuUlnwpVBWjLj7OpKLswS0li3E2UngQ5d1z+tXEplh771jy0SictKoS156rfnTUyA1g06quEiKZvbwJMutpn2q8ADOrDlOLTDmUO5wCpSX6Ja3vpklCpf54JILFvYKH+JjL+Y9BiEyhd8te1J4AxzRwZQPXLlybY9rFXvd2plxKMy6DN6YwSNFJqWKbSL7P4MLT8Qfz1iLQ2dfCpFJwbDFQr4QJuAlDFWAxFIFGRI2WOPsq2N0LyjIDpWlBAzEMGbaNxQl7Ec+Lc9Gez/ExU4TAdpBR6D0C2tk5N+fEHxe2/xKbcF+ktFPcX5sntNInwfLETNq4hXBm16UeCcktkYrWK3S6hcKwnUljB0z8k8eDHqtA1vT273Hc+cKWx5dNlBr9m3dnlAOWLDWyVm2QpkJ/TJoRY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(136003)(346002)(366004)(376002)(396003)(39860400002)(6666004)(66476007)(16526019)(6486002)(66556008)(5660300002)(2906002)(26005)(66946007)(9686003)(33716001)(186003)(956004)(4326008)(38100700001)(316002)(86362001)(8676002)(6916009)(8936002)(478600001)(85182001)(6496006)(54906003)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UVl5WmZRS3JaOHpsV3NCVjgyQktGOW8xSFFxUHo1T2l4WFhGd2tocWpINXlZ?= =?utf-8?B?MmFLc0lWaFk0V2grRXkvMzJyL0dlU3dDY2tGMGpNN0gwRy9JaGNicFNFL0ZG?= =?utf-8?B?RVpWNjFQck1UeUhWcmdzVjdlNkRjMzF0Q3ptWVE5NFlVelh2MjdmRFhTajBU?= =?utf-8?B?Mld2Uzc1Tjh6ZEd5T0NmUUMzMElKeDRXSXVzVkdDN1VodnMrbkc0YkFudVdH?= =?utf-8?B?TWUxM0dBZmlXOGtheUhicjZXT1VKMlhITzVtODEwRHduUmxIV3ZFdlNzSzFj?= =?utf-8?B?YUNMNlZVWFF5Y0JMODUzR2l1NUZIYTI2L3NrK01LcnRSL043Nk1EWHlVTWpB?= =?utf-8?B?bTFHTGFzVnJRN0JBSWxwYlRNcUZtdlBxQWRqNU1VcUJFemg4dXFTbTRXRnZD?= =?utf-8?B?MjFVanIyNnJsZXhzMWwwS3VBYmU3WU5kZHFhcnY0M1ZMUmNoc0kwbkdjRzFs?= =?utf-8?B?QU9udVVxYnNQaE9kaHUxZXlad0F1aGhzM1lLL0xFNGFtQlY4VjhHSVFCTEJV?= =?utf-8?B?Q1liSnZwTDFQNW02NkoxTFFIS3VzY3JFTEdCN0ZXVXpod0k3am5Wc2dnNGU2?= =?utf-8?B?OUNBcllVV3BZUHEzMnZxMTRYekZ6czF3ZExxSEl3bEU3U0FrWDRQVHI4QVE0?= =?utf-8?B?OWM0TGZQeDc5SUR4MGdpdzVEUTFZT05neHB0K2ttbzJmZjg1S3V0bUx3bkFE?= =?utf-8?B?T0ZBNVVpc0tuTUpybnNLQWtJUmM2VFdHWTVVUkpJZFhhMWZGY1RDaURZS3BQ?= =?utf-8?B?UlBrbWh5ZmkrWlZ3VWptWGZzeE1GcUg2c3BMT2dSVE95QmVQdytHZHNpRUcx?= =?utf-8?B?S2JsUXpWU0E4L2d4M3NFV3kyL1hwZk5WYkdLdHlobUtoZmhhUDJHR0dkTEVx?= =?utf-8?B?dU9wRG1tRWswbW1zQ1JmUGJBNHREeG5adjFxM1JIR3hPbHRDK0VBQnRzVWJI?= =?utf-8?B?Y1pHc0NFdko2a1dxS0pmamo5L0RVUlhSZkw0UUJiYWU2UVc2WWxRQ2dHRkNk?= =?utf-8?B?akNNLzdhclN0dFlyNjNCK2Ric04rN0FyMktzaGtWQUo4UVlSUWRDNHJLL1J3?= =?utf-8?B?N1c0aytQV0NMb1dReHFOeTNOTldKeWdsWDAvQUFSV2kwdElwTG5QZlVDTUNT?= =?utf-8?B?dGVjM0dPOGo5TkNTVkJ6U2k3N1FsM2drSXNybmRZRllXSEU0RFE5UVRlSmht?= =?utf-8?B?bHpXTjQvSU5GREQzOFdrMU5NMUlPWEgrVDIveUMyODhZZTl6ZzBML3BJbGVV?= =?utf-8?B?bWlJM0IwaS9GZHBjN1V2YUJ2ekxGcmV6MXhINXh5RC82bjZPbWlEQTVseC92?= =?utf-8?B?dndDdzVNbjQ1TCsyNVNjVSt4WGhhNWs0TndqU0hSL0RXOWhnZEdrOW40QzVm?= =?utf-8?B?RHJ5YzdvMmg5M00wT0hGdGw2Y2ZsYnNCNGw1YUFzdFlrbnN2MXBEazFHRTFU?= =?utf-8?B?QVU2WTNCK0dMUmpvN1MrOEFPdUtjenJiUEVOYm1hYWRrdFlpMXl5K1lyQW1C?= =?utf-8?B?NHpoekR2aWFRVjRDdzdaWVZqTm9SRjk1Q01PMzd6ZWVXQTRVUHd5eUVwUG96?= =?utf-8?B?cTBPeUZPRUV0aVBoSWxnenpnWkdxUWpKYU5nNFk1clVMd3podVQreHhFMFRx?= =?utf-8?B?VDZ4QUhuNmR5N2FNRGxZRnJyYzVZdnlOTGxCZVVaem80ZklBOTJvMFY4TFJ1?= =?utf-8?B?QTJqZWR3NWl6VHl5QWg4czFGdUlKNldDTXF5WWMwTnVWWFVMazJZaWV4N0Nw?= =?utf-8?B?OWljNnA0bkpudndWMlB4UHlqcnEyQ1VQTWd2cWU5K3hrSEVQMWlCeG1PZVhQ?= =?utf-8?B?YTQ5b2g1Qzg1YWNNMys0Zz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 764ea53d-1f10-4480-52d7-08d8ef691735 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 08:36:31.4702 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D1xGzKBtzBSnZh4hZq+JYH3FrQj3AcrWawS7MrW+DGdyM9LeH2ybekHzoO0OkpT6N8YTOvvDzubpKEh3n0a62g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5289 X-OriginatorOrg: citrix.com On Wed, Mar 24, 2021 at 07:01:18PM +0200, Andy Shevchenko wrote: > On Wed, Mar 24, 2021 at 04:43:11PM +0100, Roger Pau Monne wrote: > > Thanks for a fix! My comments below. > > > Use the value read from the REVID register in order to check for the > > presence of the device. A read of all ones is treated as if the device > > is not present, and hence probing is ended. > > > > This fixes an issue when running as a Xen PVH dom0, where the ACPI > > DSDT table is provided unmodified to dom0 and hence contains the > > pinctrl devices, but the MMIO region(s) containing the device > > registers might not be mapped in the guest physical memory map if such > > region(s) are not exposed on a PCI device BAR or marked as reserved in > > the host memory map. > > Any particular point that we can use in the Fixes tag? Hm, I haven't seen those issues up until 91d898e51e60 ('pinctrl: intel: Convert capability list to features'), but the device wasn't working properly for sure, as the registers where not accessible, it just didn't lead to a kernel crash. > ... > > > Suggested-by: Andy Shevchenko > > Hmm... was it that address I have used? In any case I think my @linux.intel.com > is better. I just used the same as the one that's on the MAINTAINERS file, because I already had that n my Cc list. I can change to the @intel one if that's your preference. > ... > > > /* Determine community features based on the revision */ > > value = readl(regs + REVID); > > + if (value == ~0u) > > + return -ENODATA; > > I think -ENODEV is more appropriate here. > Also comment above should be adjusted to explain this check. Right, will change and send v3. Thanks. From xen-devel-bounces@lists.xenproject.org Thu Mar 25 08:43:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 08:43:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101309.193662 (Exim 4.92) (envelope-from ) id 1lPLam-0003o8-NL; Thu, 25 Mar 2021 08:43:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101309.193662; Thu, 25 Mar 2021 08:43:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLam-0003o1-Jb; Thu, 25 Mar 2021 08:43:48 +0000 Received: by outflank-mailman (input) for mailman id 101309; Thu, 25 Mar 2021 08:43:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLak-0003nw-FA for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 08:43:46 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (unknown [40.107.0.48]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5eedced8-7bbe-46b4-8184-c846110e2055; Thu, 25 Mar 2021 08:43:44 +0000 (UTC) Received: from DB6PR0801CA0049.eurprd08.prod.outlook.com (2603:10a6:4:2b::17) by AM5PR0801MB1666.eurprd08.prod.outlook.com (2603:10a6:203:3a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Thu, 25 Mar 2021 08:43:42 +0000 Received: from DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:2b:cafe::56) by DB6PR0801CA0049.outlook.office365.com (2603:10a6:4:2b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.28 via Frontend Transport; Thu, 25 Mar 2021 08:43:42 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT020.mail.protection.outlook.com (10.152.20.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Thu, 25 Mar 2021 08:43:42 +0000 Received: ("Tessian outbound 2220e7a8bae2:v89"); Thu, 25 Mar 2021 08:43:42 +0000 Received: from ca65afb11c34.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 17B2DF11-8F4B-4C80-B011-DA3F9CD5A97C.1; Thu, 25 Mar 2021 08:43:31 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ca65afb11c34.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 25 Mar 2021 08:43:31 +0000 Received: from DB7PR08MB3500.eurprd08.prod.outlook.com (2603:10a6:10:49::10) by DB7PR08MB3468.eurprd08.prod.outlook.com (2603:10a6:10:4a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.26; Thu, 25 Mar 2021 08:43:29 +0000 Received: from DB7PR08MB3500.eurprd08.prod.outlook.com ([fe80::5959:35df:3647:b78d]) by DB7PR08MB3500.eurprd08.prod.outlook.com ([fe80::5959:35df:3647:b78d%7]) with mapi id 15.20.3955.025; Thu, 25 Mar 2021 08:43:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5eedced8-7bbe-46b4-8184-c846110e2055 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JnNEsdtLlbYz3k5WD97YhSr/o82rgDf5spMg8YQLciU=; b=9Go/Y02Tp0L72U+OHZ82QQATCvdhH4LFmCRFYOuv7gxPrxiPs0o6QbsUcqDnZBLsUi1sFhb7153v0tTsWv58vXmeWs2k6y+hnwYgdn0Fytx9YV8OJGXG7q9smEEKUu25ARvdI6SRIWlwuHIcITTajwsZQ3N4idLWxJX4bme4m5g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 1abb25f604239ff9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KoPjHbdGvDt80dD86zO+/QGLseLKG8DmxO89U5rvFDYSZDWTZlzoUifTxXLWbfPCZUFlVJvuTI9xdXn0Z5YRJ73jOZ5UBEX6/Md2X3l9dLGYWUT5QIgp+3QXqe/u+RJ5IYuCwnHKttQthd06IQlz81H7a/nbA4L9bTjudwIz8+A0ploZVBEi4A+SsrkHqOwXNDCAlVfASJ2TLvmpHCFxGg223OXPt0rWW6d9OrZ8up1ltWPwP8dBM5mhs6N8niLZu6dKpLRau8ESPRbgqYnpPEiCz2qD5VZwpFk4U4AbC2svAB/lEvNpL1sWD4qQ/aZcswc0ro6jP5MplVoktIkYyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JnNEsdtLlbYz3k5WD97YhSr/o82rgDf5spMg8YQLciU=; b=bHM8gtqy8VwwWzx/J80Y+oIivTJ/QTmodoGJE4YR7SND7+VycMWOI/tItX65X1IbDLuFPWF+X409r1Vrxt/TsCLL0866YJF6sHJTHB714EW3PihLQcPB1oEaJtbyx6i3kiXLvNj3J/Vh/69pP1HG6ghhm+GUKvbo0iE1MknOiL7sHYkzxNS4UXoHyXOG7BV9tCu5OSfT9/cMTke5e7E9A6ygnzACtXszquIAvFguFItkqYLzXdnclxkcwP45qpc4LGwwsARIqu2gM8Sk1WJoFFh3jAyXwExm+8g6yTWG+IBUW4eAZeFGy13OGDxxA1icIz/rSxFW/52erJE971HCPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JnNEsdtLlbYz3k5WD97YhSr/o82rgDf5spMg8YQLciU=; b=9Go/Y02Tp0L72U+OHZ82QQATCvdhH4LFmCRFYOuv7gxPrxiPs0o6QbsUcqDnZBLsUi1sFhb7153v0tTsWv58vXmeWs2k6y+hnwYgdn0Fytx9YV8OJGXG7q9smEEKUu25ARvdI6SRIWlwuHIcITTajwsZQ3N4idLWxJX4bme4m5g= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v2 0/5] xen/arm: smmuv1: Fix stream match conflict issue Thread-Topic: [PATCH v2 0/5] xen/arm: smmuv1: Fix stream match conflict issue Thread-Index: AQHXHzYZIkvPmBX7B0S2bJuXA88YyqqTn7UAgADHuQA= Date: Thu, 25 Mar 2021 08:43:29 +0000 Message-ID: References: <2e1af560-5657-32cf-ad6f-c94086e2309b@xen.org> In-Reply-To: <2e1af560-5657-32cf-ad6f-c94086e2309b@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [80.1.41.211] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 360d917f-67cb-464b-aa1e-08d8ef6a1826 x-ms-traffictypediagnostic: DB7PR08MB3468:|AM5PR0801MB1666: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:2201;OLM:2201; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tZ7MMs6AQYP48YUQ3se4cRoFLGFIIihxEpKsiAXquaDtS4E2xnYohrzxnlP1BRoz3EY2+8b/dAGPnefROaLrbZdvlHqpJbJ6ba1N90LGmV1XxMQ/O/6FB6bY/bOiqXNDOYaqHUWS0qzYNBCghrsiXhF/MV8aCdq1VRbYOhMldYNaNkzgGa7vZvhSPLYSciaIpgTJXfbsBISPYXynVx+S+8lEU//sg2L7f3oFpE13Vl3lMZsIenLqYBNIxgps/LHkAhIxjw0xrcLI8ZzL9KqXL9pnYYG6D7UvufCOm8+xu3GnbRzDzOw2ozvJv5WIejvUkbL04nv++/kT4Ki9nrjnvi7tN8sNAQBn2DGboOPGAPUk/y1F+2HzQQv9T/qIwLHsY8gkDNUDkyex51dHq4kuQDlw7pltYIjgv0zwfkN55LBYpUZ2o6MRvX8RwYk9BAa3r/oLDTNHR9v82pmSCJjcuKbTdTXtBNxwg2C5fsPbjMg+qpBYwxGfIEDv201x1u+awHISjj/Rp5dFBaypdqAA4/au0p/Z+S21toShTTNcaAhvYjccu0tsVGhxtkmrsJZL+KHkMKh5rdprokfHUCuBkdfDZq3gmXEjvpLrUCTgibimZjX742sZI8vYHLlSl8WVicMsuYzMWjdo6whgx5WXjEfSf2H6YMsIA6VUNyAy/9bM5JquUC/OYCPyOPavou3D X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3500.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(39860400002)(366004)(396003)(376002)(66476007)(186003)(6506007)(66446008)(26005)(64756008)(8676002)(66556008)(38100700001)(6916009)(91956017)(478600001)(66946007)(33656002)(76116006)(83380400001)(53546011)(6512007)(36756003)(54906003)(2906002)(86362001)(71200400001)(6486002)(2616005)(8936002)(5660300002)(4326008)(316002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?QRJXC6SqkDpQ6gFz48u87xXN1h/5ts385f7QFITV2vpMg1mpraFr/6hcpBAW?= =?us-ascii?Q?z9F2mShJEFyIzarFT9NRDbcb0nGX/VUWT15WkB5jEAl/5FuCkM+oc5VY35bk?= =?us-ascii?Q?zmWpzdmHwpTXC5Mk5cpW2hUbkltDKphAdmxlWnhpPYtod4hscMwnkxrw+rUL?= =?us-ascii?Q?iemTE86cq9SBt2T1CunUjHt+fMb0agN6mWMrWJXBIRQbv91FcKZqsWB5F5IB?= =?us-ascii?Q?jYtNJh6KCut5RWwsf4zDsEh92sUmooxKJEWpxyocL30TOCD1d/FFYfF/OpBa?= =?us-ascii?Q?pUTnp5bI3fl5tyGegxclCd/+BqoPaqFgjA3t/8Mra79haX3DtGdWzqmoCHev?= =?us-ascii?Q?qquBPbQUrlqKrfFeRs0MfBI0qui9gZCXGakAf2nMC0aIeCRmmMxhcbQJy5CS?= =?us-ascii?Q?pV4G2WGQsooL0DiflAoNe8lVbJyCtOHcjxInmB7UDG7Haf8k8o+HdLYPqQID?= =?us-ascii?Q?FnS3m7vxoJoFbZFePlF0uvSTUmdZpc+y7ZMFmQWoExSSYJzdyx8sun2AWi3S?= =?us-ascii?Q?eiCsgsRFK7qkxhB3UhfuSw/RaPADyPACrcKtWCby0D36/rI9pe8HcV3wDLpY?= =?us-ascii?Q?md4zZf8sJl736vrIDS6mXbcGVhx+O6aUI0siCbpsvLzxDga3jvaIIpp53dp5?= =?us-ascii?Q?CldHW01Ez+hRlMRvaXhq6WQLtB3nj/ZZZ8yi5ITIJgK1jdUslGFH6YA4+irV?= =?us-ascii?Q?lfqOQcoqyf5+nKZZuOOif71a8IDbMi6bfZJJnoV+MIy8/RRJzWmgCFX7glYh?= =?us-ascii?Q?e/rOS1wEpp+xTaSmQc4QKtoIKbWaJYEq9H56PlOpTFJVDcuXHF6F7/I2W2OH?= =?us-ascii?Q?rBwFgYdvTeHTaXoKhwaDoXI6IMy2ftu5W0y+PifrCu194LX17PQMt4Vz/sww?= =?us-ascii?Q?cye8UQfR24vKi5QUH69GB5eamAmmk1TRUckzf95Sq8TqIxp/bk6wnuxmYlA5?= =?us-ascii?Q?cY3YpGPWYeq5Eg+RngVhGvyqmYMIzv0bmJn9HwfSpR+QYproGwRaUAuyrS/k?= =?us-ascii?Q?CAwGe/R9h4j7sc5dvyE0VNQvsKxWsGf1i2IiDxCSuRQ7DyWuaBw4W9SsCX2S?= =?us-ascii?Q?LsA34pWuUNvQcV9c1qZLEP7a5GezFMUWoKUQAMYB/d7E3ebxkgz65zqNwRWh?= =?us-ascii?Q?EOEi6nqrlMphlND4LshDYV3JG6hQ7/w+THAsSpDn/oQoAVJEykpfUQIe0yGP?= =?us-ascii?Q?QcYuj1MUkJKeaxL9hz3J34K5+hxbLqlPGcqCcdwRuP+zG7hT8Uzk/hLZ9/zm?= =?us-ascii?Q?/+S1t5/mt5QN1Dr/QzHZUhj/6ThAr1wwlx8161b87CWCQS1ASU+wMSPykYN5?= =?us-ascii?Q?6nSJzQDlLyxC/IUinA9Ybx46?= Content-Type: text/plain; charset="us-ascii" Content-ID: <78022B0150B37D4B858941DEE5FBC459@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3468 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 8b2de174-7ca5-4bb5-d6db-08d8ef6a108a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O1aFrZEDrL5ThaO8p0uKdcT51XgqTrJot5dgur0jREmIW503uMMjA8rAqYDghny76EbGt8+VMahj1kMuALVGB2ol9uhfx50Hk0iHZGtHFdBbc9AgQjT5AdKv5Akst/hoK+pDN/ieMaQkqcQS4Z9Co/3aybU3LtpwA/oDXabSpEltwPPWsRJ21o56xOL8luAdCGklWTraYF1DpmUUjEEV/AlTLOKhz4F1XhfALrS6Ur/Ia8qR4MWJXlym1ySMBSXcem00eSc48WuZ5agTeTng7t3wAfkKpjJeCACMsmeZSLo/zRUoe9XzyRkFr7eb5im4Y82V1eFcqMDtO3l8co63lFzSe5n0rrAXbSUICGlqazNI7A6UUVFxIXWCX3hwSMnTDhF67FiiowVMzC1gQ2qTz+Iq2SaRficolABhXC3SvMIKXlcz1IskYsnsgh6Ihbsw+oaDWJ7juxkwDGwjBOE2mmmshXYHqvTeMUTS5gBsbh3oV1XIojLghxEhxQNe0+ZXUxrjD1U/+quGkpNVfx7iwVc2P3R83LFYHIaa4iNkvWusUadcCotfjaMasV12DcCkPjszFGNNpIhbDGLtpdJyFpwJNlL5riCVyvusy7HwtuNqo4MXszLG9kGUeNkGQxwphgMy9HkjMbn3UapH2l+Ka/vZmOZSDW/JFrNIv7OLv40= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(396003)(136003)(376002)(346002)(46966006)(36840700001)(6486002)(86362001)(53546011)(6862004)(82310400003)(82740400003)(36756003)(81166007)(478600001)(83380400001)(336012)(4326008)(36860700001)(8936002)(2906002)(47076005)(6506007)(54906003)(6512007)(8676002)(26005)(107886003)(70586007)(33656002)(356005)(70206006)(2616005)(316002)(5660300002)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 08:43:42.3624 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 360d917f-67cb-464b-aa1e-08d8ef6a1826 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1666 Hi Julien, > On 24 Mar 2021, at 8:48 pm, Julien Grall wrote: >=20 > Hi Rahul, >=20 > On 22/03/2021 16:11, Rahul Singh wrote: >> This patch is the work to fix the stream match conflict issue when two d= evices >> have the same stream-id. >> Approach taken is to merge the below commit from Linux driver to fix the >> issue. >> 1. "iommu/arm-smmu: Handle stream IDs more dynamically" >> commit 21174240e4f4439bb8ed6c116cdbdc03eba2126e >> 2. "iommu/arm-smmu: Consolidate stream map entry state" >> commit 1f3d5ca43019bff1105838712d55be087d93c0da >> 3. "iommu/arm-smmu: Keep track of S2CR state" >> commit 8e8b203eabd8b9e96d02d6339e4abce3e5a7ea4b >> 4. "iommu/arm-smmu: Add a stream map entry iterator" >> commit d3097e39302083d58922a3d1032d7d59a63d263d >> 5. "iommu/arm-smmu: Intelligent SMR allocation" >> commit 588888a7399db352d2b1a41c9d5b3bf0fd482390 >> Changes since v2: >> - Updated commit message to show the original author of the patch. >> - Added Acked-by: Stefano Stabellini >> - Addded Reviewed-by: Bertrand Marquis >> Rahul Singh (5): >> xen/arm: smmuv1: Handle stream IDs more dynamically >> xen/arm: smmuv1: Consolidate stream map entry state >> xen/arm: smmuv1: Keep track of S2CR state >> xen/arm: smmuv1: Add a stream map entry iterator >> xen/arm: smmuv1: Intelligent SMR allocation >=20 > I went through the commit messages and they look good to me: >=20 > Acked-by: Julien Grall >=20 > I have committed the series to my for-next/4.16 branch. They will be merg= ed soon in staging. Thanks. Regards, Rahul >=20 > Cheers, >=20 >> xen/drivers/passthrough/arm/smmu.c | 423 ++++++++++++++++++----------- >> 1 file changed, 262 insertions(+), 161 deletions(-) >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Mar 25 08:47:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 08:47:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101312.193674 (Exim 4.92) (envelope-from ) id 1lPLds-0003xm-6R; Thu, 25 Mar 2021 08:47:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101312.193674; Thu, 25 Mar 2021 08:47:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLds-0003xf-3B; Thu, 25 Mar 2021 08:47:00 +0000 Received: by outflank-mailman (input) for mailman id 101312; Thu, 25 Mar 2021 08:46:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLdp-0003xa-UR for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 08:46:57 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0859fe8a-a0c8-4a3f-912f-89d50e3554ad; Thu, 25 Mar 2021 08:46:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0859fe8a-a0c8-4a3f-912f-89d50e3554ad DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616662015; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=yVaihSFmEKkBrt/xp2nkaRY8swI2njLN4ZHUuUyec2E=; b=ApapTdMP1vVNp25E5QYbZEYMAfm648CU8LkxrJQ5FogIl2f+Cv1M9Ee7 lM8lpZd9xTq847zXO1PKVDvNCJGlbu1veQUetzES6zYty4e+ycQEJuMQ4 U3FXmhv1Ptwpbeqo2ur2MgEJMT18VUvBHbBIr2fqgh0Io1cGW+63AylQ/ s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: B0DCIHX4wm/iYDzV/HeLei4AD0v3qrW068QO0jSjNH8BL+PFxCFbBT1R68pJW6s/tJu6gQYziL CMmU7lqjEm1BNzEGlBYheDFKNdiwTsdXJEKIkeHSpbgMUt3MKzJm6woRUlBIWD0e3fAvISXrl6 iO/XKgHYv5VcqB0zlB6gUeXu3NXwgT30cmXvVBdTTYk56P/uB/eLOMVKueo2elSrolg+esut26 kG+x6EkNoeI0/gm49hveJt3WBTpS3XRh4m9DpIJPe0FkUre5caaZpJd5oca0sLeLbWvRuQRC8h sCg= X-SBRS: 5.2 X-MesageID: 40102134 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:nTa9GK87CfnSfeyz1Rhuk+FGcL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmzybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIULD38Zn/+ Nbf6B6YeedMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsLV4hLxW5Ce2CmO2dxQxRLAod8OZ qH/8xcpyehf3N/VLXHOlAuWe/fq9rX0K/8aRkdCBI9rCWIhzWk6Ln1eiLoois2eTVJ3Lsk7C z5gxX0j5/Tyc2T5z398yvo75pQkMb80dcrPq2xo+UcNzmEsHfMWK1PQLuH1QpFxN2HyFFvq9 XUpgdlAsIb0QKvQkiQgT/Anzbtyywv7XiK8y7qvVLGrdbiTDw3T+pt7LgpCifx0EYrsNFi3K 8j5Qvw3PA7fHCw/lWJ2/HyWx5njUayq3Y5+NRj9EB3aocCdKRX6bUW4UI9KuZxIAvB9IslHO NyZfusncp+TFXyVQG/gkBfhPaoXng1Ay6cRFkDtsG/w1Ft7QFE5npd68oFknga8pUhD7FC+u TfK6xt0IpDV8kMcMtGdas8aPryLlaIbQPHMWqUL1iiPKYbO0jVo5qyxLku/umldLEB0ZNaou WPbHpo8UoJP27+A8yH25NGtjrXRn+mYDjrwsZCo7Bkp7zVXtPQQG2+YWFrt/Hlj+QUA8XdVf r2EolRGeXfIWznHpsM9xHiWqNVNWIVXKQuy5cGcmPLhviOBpzht+TdfvqWDqHqCywYVmT2BW ZGcyP0IOlG80C3Sl71iBXcQBrWCw7C1KM1NJKf0/kYyYALOIEJmBMSk06F6saCLiAHkqFeRj o6HJrX1oeA4UWm92fB6GtkfjBHCFxO3bnmW3RW4SsDM0b+d6c/q8ySEFoimEevF1tadYf7AQ Rfr1N49eacNJqL3x0vDNqhLya8g2YMommJC7MRgLeK68ugWp5QNOdpZIVBUSHwUzBlkwdjr2 lOLCUeQFXEKz/ogaK5yLoOBO/ecNF4qByxIdFdrE/esUn0n7BtelIrGxqVFeKHiwcnQDRZwn dr9bUEvbaGkTGzbVckjP8AK11KYmSPCLdgBACIDb8k3YzDSUVVdyOnlDaagxY8di7P+18Jjm LsFyGSZMrGG0FQoHxez6bs/m5lb2n1RTMDVllK9alGUUjWsHd61uGGIpC+1GaccXMu6OAQOj OtW0pYHipeg/SMkDKFkjeLEnsrgqg0NuvGFbI5bvX4wXW2MrCFkqkAAt5Z9JtoL8rVr+cOSO 6TEjXlag/QOqcM4UiyqXkkMiUv9yVhvvPsxRH/7G+3mFQ4GuHfJVx6R7cdZ/GQhlKUMMqg4d Fct5YSu+D1D0DaLvih4ovTZyRYKhzSrXWtJttY4ax8jOYXjv9LA5LfUTH0z3lJ0xU1EdfsmC olMdBGyYGEHrUqQtcbdC1Y9Gc4jdijLEMktQrtH+81FGtd+UPzDpes47DSr6AoDVDEjAzsOU OH+yk1xYaOYwKzkZobAbk3O2JYdQwV72lj5vqLc8n1BB+xf+9OuHq8PXnVSs4RdIG1XZERpA 19+deGgqu+cDf5whnZuX9DGZ11mlzXCP+aMUarAu5H89uzJFSKjO+L2aeI/UnKYAr+TV8Zi4 1DfVEXdeJZhFAZ/dQK7hQ= X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40102134" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bca2mcanGMyjtolbW8lqvr8hpakZjxlfxJ2qmNrXruNEsXkI/n5suJ5RNVfKLxpah9ewiezl9pKn0wLTvZXse9nu4ucqUfAn5H1Ie9qh/vc3AwFWXAUuJg20g3lk6GGVUx4lzvm2gFp9G5CPYOWYER57FVu+cA5po/JBilVXDXgk/SHwgs5K26BdiZhssluV4Jr8NGHzZ3zOKREwHg/aout/ZIKP4pyH5b5JIKzMLN5qWHOQPChi1YIBYOCgCR350Tl3U/Bx/5gjL+CIjZRLo9qQ0NSTAPKmjLznHkOCjNVDPodCHliCbFloD7ieVqiJd5vsjc0A4A4e398PXhDXVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1pH94whoYKNlTpf6SIE/WeL/oLwmFP7iUQ7oN3PBZKI=; b=SNIgD8WZdxzuP4v8DoNDSgIOat9T7gq64VfeBlauPjDbRm2d/TJYs3/pJ/kXiOXq4EsXSmfGmMomxsolNUkHX9bob0HHfGKxXRYjowYxGGoqOap4ImPNjCBi2PWDupuL5EAhgo2mYTtv9gmoDsI5ywUENQzwyyXwQULCU5V1XBkr8soCn+36AitesX13wBzvQqU8hDKgPNvRX7iWGvxOvPnbhPkKfT30ak5gY1mWobqiQDfl7GN5XOyGvnsWq4WRnPFBQmzIhFtCYaKJHlH5v7MKPeDNUuNCj4G2f00VtQr4rxmTLagDNv4QjJeoIT7T6lL81INk8gatzyWSLn2U7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1pH94whoYKNlTpf6SIE/WeL/oLwmFP7iUQ7oN3PBZKI=; b=XPJLPJJP5fAruTVqXdB9x1jGSS38YntXBzsSH1ccGJLqNEd8qINnUISdotB1STHzX11F7eOhSVvQIqMSOwmCkeHAJrZJSe/dupXejaSWiu7XjNzwQXNmG74CtdNeSIFEaycGoAc7QNJUgJvZAS4REXp3ozN5wguGF9Rwae8Hp4k= Date: Thu, 25 Mar 2021 09:46:46 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andy Shevchenko CC: , , "Mika Westerberg" , Linus Walleij , Subject: Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region Message-ID: References: <20210324123118.58865-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR2P264CA0095.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::35) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d5db2cb2-4f26-4c63-8015-08d8ef6a88ee X-MS-TrafficTypeDiagnostic: DS7PR03MB5445: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EmP9yoJf4qkPCdtsMyFTmQk24KY7KTMKg35EVyMfVidAwKrOdp9CLkhNTaaiZ2qF/8qyoUlkXClYI9k5I9W7GUmYku3Zamim4yQ4bcb7NbHZ/lZ236eiAPwA6EfbZ9fqpm7GZxhPuEdBiCX+b9HWZ8P2VL/sh+JDegUTb26PK/hJXIvACQ7z6TvQgKIHFIYsLSATZJMMM1KHHeD4qDkZxCN42Sc1omQcJD2XS8Uq+edLJhFfs91JQtYRWpws1JoyuO7iU34HswRvEN9h5phpMm3JVAEDVAZIYRja1b0P+q72SsxVdV+VlU5gaXR0Pfb4w31YuwIsiSr2QV2jDJr+w+vB38eiVi6ixN7xlgrwTxNNYuWqatoXOulTDrFPPVZVbh/KiLjEpG7vfyoTOhPZnYNeePRWAfXW11E7N3d3hIjcbWkouf/x4TOGWu587H7m/49AnccssNlrqub7VtKj9Eh/er8XNoLwI4lrBKiNO7etfwzHIu+4rFlTHqYPU63HJNSXdCPVgUPxHADnn3pafjdp34Lpi+TVVftAZw9B+2hBuZcsIycDQyMARxxgFE722HIUkxAIJ2uESZZpLCKBycT/x5IMM+f3SI8feWkFOpS9zUfy8O9BTQwSrUyS1bh4z/UoxdPILYcHP5ZfccJVjN/k/JU6iDmDkehq4G6/sB4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(136003)(396003)(376002)(366004)(346002)(39860400002)(6496006)(66946007)(85182001)(16526019)(26005)(4326008)(186003)(33716001)(38100700001)(2906002)(6486002)(8936002)(66556008)(66476007)(316002)(6666004)(5660300002)(86362001)(8676002)(83380400001)(9686003)(6916009)(54906003)(478600001)(956004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aUJ1UGR1d1ZIM3hDSmhtTDdpWVpTaWR1U001VEVTVnRGQXpiUlJOZVc5SzRV?= =?utf-8?B?ZC9LYXVnaEpPeTFtc0U5eit2c05EOXc4TklNQjlRdUlDTVVpb25ZK2xNYVBk?= =?utf-8?B?Y1g0dGpPK0ZiNVNUbUp6YmVYd3VkTjhCdndoRTAvcmFzaTV3cml3MEkvZDNB?= =?utf-8?B?eW5tOTNEV21RTWQ3a0xzSHF0TVRtOWZEdmdwNjZWNHFsNDgxTXNWaFZVb3o1?= =?utf-8?B?NW5nanZETWRIWXYxMHUrSjNNU1VrWTZpVWN3T0daaVFaMGljMm11ZTRTcXFO?= =?utf-8?B?QjBvUUFydWJYcDJ6T011WXYrdWY1Y0FUV1M5ZzY0TXhQek9scjlBWE9hak1s?= =?utf-8?B?Z2RkNnFzOExiWnRwcEQ1U3cvOEtRd3E5U0RGWHlkcHB6QUpiaVY0MWQrb0xp?= =?utf-8?B?bHdaMmszM04rdEd6Z0NPU254MU83V1A5SHVPdHNQd00zM3Z5VndSVnorV1Qy?= =?utf-8?B?dy9kR0hJcEMwcEVTQm1hT3NGSklwSzVHTUVTRHcxWmV2RUZyNDZGbm9ZdC80?= =?utf-8?B?ZXVMNm5FMGUrdDFTOEEya052OXlja2RrUmxmMnVqYjFaR1VGbkIyeHpKanhV?= =?utf-8?B?L0daa25GMWpOWU5kQ2Z2YnFCVkNzL3pNT0VvTHBqRUp0RDhidEw3Y1NTeWI3?= =?utf-8?B?MnBTYmphRG1nNndOaTl6WHp3M2I5S2UrSUdtTU55VGVBN3E2aXRnbGdESXBq?= =?utf-8?B?QlFramZEblhtalpma3F3U3JQUHFMOTNiSm15UXdGSDREWVo5NGdlMHZvNDNH?= =?utf-8?B?S0tPZjRyTlcyZjZ5bmYwdzRydHZYaXBUcWJIbHhZU0VUVUM1S1dzdWhGWWdh?= =?utf-8?B?QmNkVTZ2Q3AxV3hCMStubWpwT3F1blQvRUZRNTlobTk1RmtYSjNSNG03anpC?= =?utf-8?B?RnNIZ2JYSTBkV1l4ZDdJK2t6ODYwdVNIUjJSQ3JJaE01Q2s1Q0REQ2hSb0k1?= =?utf-8?B?OHpNRU9zQUdua1FFZkJML3ZwaDh2TndRZkVvQVFnWFNhVmcwb3dSaHBrcngx?= =?utf-8?B?S1NhYS9TSXBJRnkvMFM1RnI2N0FQMVpxY0lXOHdFanBnWStqOXljVElrWWo2?= =?utf-8?B?dHRHRlYyNDVBUXlZT09VSEpEM3FmY0lIYURLMHBnaUdpMkl0ejdkbEhWSWpX?= =?utf-8?B?QU13NjNRUHoxb0FiVHkyYnZ5NGVnSEpnYlhIOFB6V0RHSDYzK2ZGYnZBZ1Iy?= =?utf-8?B?NTM4Wk00ZVdXT1dhZTEzcVVtZXZMenFwNkxRS1Q2NjVWQ0dxQmtTMXBHODhx?= =?utf-8?B?KzZnbE02MGMwc05WQ3NWa3pLbFluTmN6N3BVeURaaVdKVWlGRUhQTkNNQm5E?= =?utf-8?B?aEI1YzB2RmlvSkVXV0NUN2NVeUJCWmN1WVhOY0tXZkdzQWVWdC9VSG51NHZs?= =?utf-8?B?QUVXMFdPQU9hTlQ0RnRscHRCUjZsYVVNTFFqZGthaDBXbHdkbWlsbVVrcm5U?= =?utf-8?B?OWVWRjdEU3Baa3l0eHNOeTVnSHhQdDdYdkhiL2N2MzFlUDY4STl4RGsvRlhq?= =?utf-8?B?Uy9vQnd5SUh3OGRlQXdVbEc0VncxR0M0OVZVRkJGSnEvNm5sTU9GaXZpZ3Ix?= =?utf-8?B?OS9kN043WHBqWnFWa0dSUnplcTZxd1hvOTBSTlJCNTlJNW5DVTZnN3RoMkx2?= =?utf-8?B?S2xOWVN5aU9lblRnMFVCVEY3dlJ6S0oxU3RLMlRBdG1vYlBxUDZMam9LU1dG?= =?utf-8?B?Mlp2eVFCMEtBNlFoZUxDN0N1Wng4Rm9SdmN5K29neUU4VGl0V1ZjM0RpeVoy?= =?utf-8?B?THRaMmUyUWhQUnlFUmtvWSsyc0pTUVdRanVTV1I0TGVlSHpXeWFLeDB2ZllV?= =?utf-8?B?Rk5TOU9GeW9FcDlLT21LQT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: d5db2cb2-4f26-4c63-8015-08d8ef6a88ee X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 08:46:51.7740 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KqEslvq9wy190VfcF8f39BROYygq1F0IVXTkcLcZcYVYjDJA8TSEu2kDGRyC6nB8F19FljOqOgUabTFAAJ0reQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5445 X-OriginatorOrg: citrix.com On Wed, Mar 24, 2021 at 06:57:12PM +0200, Andy Shevchenko wrote: > On Wed, Mar 24, 2021 at 04:13:59PM +0100, Roger Pau Monné wrote: > > On Wed, Mar 24, 2021 at 04:22:44PM +0200, Andy Shevchenko wrote: > > > On Wed, Mar 24, 2021 at 02:55:15PM +0100, Roger Pau Monné wrote: > > > > On Wed, Mar 24, 2021 at 02:58:07PM +0200, Andy Shevchenko wrote: > > > > > On Wed, Mar 24, 2021 at 01:31:18PM +0100, Roger Pau Monne wrote: > > > > > Moreover, it seems you are bailing out and basically denying driver to load. > > > > > This does look that capability is simply the first register that blows the setup. > > > > > I think you have to fix something into Xen to avoid loading these drivers or > > > > > check with something like pci_device_is_present() approach. > > > > > > > > Is there a backing PCI device BAR for those MMIO regions that the > > > > pinctrl driver is trying to access? AFAICT those regions are only > > > > reported in the ACPI DSDT table on the _CRS method of the object (at > > > > least on my system). > > > > > > Unfortunately it does not expose PCI configuration space. > > > > Are those regions supposed to be marked as reserved in the memory map, > > or that's left to the discretion of the hardware vendor? > > I didn't get. The OS doesn't see them and an internal backbone simply drops any > IO access to that region. I'm not sure I understand the above reply. My question was whether the MMIO regions used by the pinctrl device (as fetched from the ACPI DSDT table) are supposed belong to regions marked as RESERVED in the firmware memory map (ie: either the e820 or the EFI one). > > > > Doing something like pci_device_is_present would require a register > > > > that we know will never return ~0 unless the device is not present. As > > > > said above, maybe we could use REVID to that end? > > > > > > Yes, that's good, see above. > > > > > > WRT capabilities, if we crash we will see the report immediately on the > > > hardware which has such an issue. (It's quite unlikely we will ever have one, > > > that's why I consider it's not critical) > > > > I would rather prefer to not crash, because I think the kernel should > > only resort to crashing when there's no alternative, and here it's > > perfectly fine to just print an error message and don't load the > > driver. > > Are we speaking about real hardware that has an issue? I eagerly want to know > what is that beast. OK, I'm not going to resend this anymore. I'm happy with just getting the first patch in. I think you trust the hardware more that I would do, and I also think the check added here is very minimal an unintrusive and serves as a way to sanitize the data fetched from the hardware in order to prevent a kernel page fault if such data turns out to be wrong. Taking a reactive approach of requiring a broken piece of hardware to exist in order to sanitize a fetched value seems too risky. I could add a WARN_ON or similar if you want some kind of splat that's very noticeable when this goes wrong but that doesn't end up in a fatal kernel page fault. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 25 09:05:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 09:05:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101320.193701 (Exim 4.92) (envelope-from ) id 1lPLvU-00069J-6J; Thu, 25 Mar 2021 09:05:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101320.193701; Thu, 25 Mar 2021 09:05:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLvU-00069A-2e; Thu, 25 Mar 2021 09:05:12 +0000 Received: by outflank-mailman (input) for mailman id 101320; Thu, 25 Mar 2021 09:05:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLvT-000691-5u for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 09:05:11 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 34607c0c-4d3f-43b1-b7fe-73069ee272ce; Thu, 25 Mar 2021 09:05:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34607c0c-4d3f-43b1-b7fe-73069ee272ce DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616663108; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=dMD99dj36c5TTh9lHrhGCe5pFdWHoZJ8rJcPuK0wv9o=; b=Sa7HT8jpry8Hiw4kfR52hJXTgcmLxC94G6iD0A6T/aaTuViYqNkTbvDu B9rRtTfJ14JkvRGJAtGl8FMliTUXoRJyjIr0AqpqumF/1gJ5XgEz0FLw8 2QrICCMluZO5YhR5ackCmcrEYmmKMj3rS3J4TlTbx5Yemcd8uIZJmXVr+ s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: CTbfdcf/fACsiVi7YDd6doIee/5wwl0vAi1DdLV8in0J1TnYAphpAaEWqxxrqGMwR88WtwmVAH obigVlrdHMszCxRBdmGAYTN241ttM829lMHu/7YUpwCqPOJJW7d+qesBnTYXlSLcJdxxBdsLLv TiRtQqRzPi80aEVklQpjKCFMUYWpeOOfAlZL0Wnf2l4uX4K2FgEccWvNdJbzlA6ADEmJT8FqUT G2eluaza0KFDyIx3/Fq1v3yyveiWacK94yPquRpvvXws6rp4HROVf/iiFu67FLmuJlxVgdAm7d 0Wo= X-SBRS: 5.2 X-MesageID: 40103150 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:3X2oX6u3AigWZOmb8wbyEh4A7skCDYcji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOjrU5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qw6Y 5JSII7MtH5CDFB4PrSyAOzH888hPyO9661jenTpk0dMD1CQYsI1XYdNi+wFEpqSA5aQboVfa DsqPZvjTymZHgRc4CfDn4KQ+DMq7Tw5e7bSDQBAAMq7xTLsCih76T0HwPd8hAVVT5OxrlKyx mFryXS4KK/v/anjiLNzmO71eUYpPLN6PtmQPaNhM8cNyn2hm+TCrhJdrWesFkO0ZiSwXkwlt 2kmWZCA+1S7DfrcnixsV/R3WDboUwTwlvD7XPdvnf5u8z+Q1sBeop8rKZUaAHQ5UZlnPwU6t My40uju5BaDQzNkU3GjrCiPXALqmOOrXUviuIVhXBEOLFuE4N5loAD4FhTVK4JASOS0vF8LM BVEMre6PxKGGnqC0zxg2h1zNSgGlQ1ExuWK3Jy3PC97jlMkHh1i3Yf3cwU901wk64Vdp8s3Z WnDo1Y0JV1CuMGZ6N0A+kMBeGtDHbWfB7KOGWOZXz6CaAuIRv22t3KyYRwwNvvVI0DzZM0lp iEekhfr3QOd0XnDtDL9IFX8yrKXH62UV3Wu4Njzqk8noe5aKvgMCWFRlxrudCnue8jDsrSXO v2H55KHfn5Ly/LFZxS1wPzH7leQENuFfE9i5IeYRajs8jLIorluqjwa/DIPofgFj4iRyfxGX 0GUD/vJNhR70yiV3Pi6SKhHE/FSwjax9ZdAaLa9+8cxMwmLYtXqDUYjly/+4WKJFR5w+oLVX o7BImivrKwpGGw82qNxX5uIABhAkFc56ilV3tLoAQNIl7laLprgaTHRUlimF+8YjNvRcLfFw BS435t/7isEpCWzSc+T9S9MmybiHMXrGmQT4gVn7CC4cuNQOJ9Mr8WHIhKUSnbHR18nghn7E 1ZbhUfe0PZHjTyzbm+gIcMH+HZfdlkiAKtKcpZwEiv7Xm0lIUKfD82TjSuWcmYjUISXDJSnE R26LJaqqGHgyyTJWw2h/kYPFVAZH+MOq9PCB2Iaexv6+vWUTA1aV3PpDSBzzkvZ2Lh9iwp9x PcBBzRXcuOP31wlTRz1L3w/FZ9a2OHFngAFExSgMlaDmTJunF6zOmRQLG8ulHhN2cqyv0BMT 3DfDsZKh5vwdfyzxKOhDOeDxwdt+UTF/2YA7I5f77J3HSxbIWOiKEdBvdRuI1oLdb0r4YwIK +iUh7QKDv5Du8zsjbl10oNKW1xqHM+l+nv1wCg5G+k3GQnCf66GiUse5gLZ9Wd5XPjXfCGzd Fwis80p/K5NiH0ZsSdwa/aKz5FJRW7mx/9c8g47ZRVt7k1rr19At3SVibJzmhO2FEmN9jv/X luNphT8fTEIMtibsYScyVW8h4gk8mONlIitkjzDvUldV8ggnfHN7qykvb1gKtqBlfEqBr7OF GZ/SEY5fvDUieZ3bMRCq47Iw1tGQABwWUn+PnHe5zbCQ2see0G4UGzNWWldqRBDKeCArcdo3 9Bkqa1tv7SczC93g/evTF2eP0Tt2mmRN6/GwKKF6pD9cegNVGFn6ut54qygV7MOE6GQlVdgZ cAc0oaKtlHgH0lioY81yCpUKz5ok4/iTJlkHhav0+o3pLj+XvRGEFNLBbQjZpXVyRCK3Tgt7 W2zcGIkHDmpCVf0ZbNFE1MbshDFtgZQI/wNTpvI6ErzcqV1rtqhD9CbhcoB3M9jz643/oO58 bL5Mnv X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40103150" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GJYJ+pfv4S5RhEonyIOjqhLfsoOSsBGYWwyvSkC6I0VsWdUiFel7Iorr+dEPXSivZyowfngjv60yqIwfTydxK1KaUh9tt6GsTMIMLBFEYOAafuyuhbYqTuHc5p4EVhs6OLSy8a4ivuNW3U4Cvel1YAi2SYUtEqkeSAKB4yiW0IMP91/HwNyt1A6eoFwQX1gfAHNKPo0Td7iJY+nMsPHTOTlviS0RHiU6dV6r2GMAVo+Iv9kXyv5VzoTwYITPQr/3rjzVbtxRJBBRQDVu524XCcGe9+euG5KRDpMeIZSdKJOM1GAqsKjr2v5EHWfVpbeFvhhdy6PPafyPhVubJzIm1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PGJ2MHLAuNbs5BP8/NYIRG+tPK/zZRcQEYN5KT3udDs=; b=Bh6/KbBx9gV8oO3BKrsAoqXN9Ap3wgWER3VeeNVsbbi0/uJQYKuh0IHwSOGQxN7yp3OG9s7HFamtG5ISQEOolw8JCFrHRgpl2U7VVuj5Gqw82CFIyzJ4hxTIDVnGimwGO7igAXA6suEZan8NRy+Ny9h2KmbSlcOvAlIZo6nVwWHIMqWYx2bpUT9ecz5P77nPD4gfVfhEg4ZEauQsgXJJvzOVejqa0BzjlzDo3XVvc2YKG4sYutiZVR1u1KShgg4VwWkDmWQmIcBL5vlWZFNm3+BJbuegG9Jvq/jICkMiwQqhDFkTWWBkWvaBV2HuV6mjvPQfIAFzfnOiWMxc9O3VQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PGJ2MHLAuNbs5BP8/NYIRG+tPK/zZRcQEYN5KT3udDs=; b=lHpUOlInbfxhehMIiGMpv8aXVaBDXK6NbqDvrrWah2fgDHVjT2ayBp5B+QddcTJMmliRAIext/5o6pEM+mBsdzM1fDsJx1wY2pJf4sKp5D1RmfFBMf2SKizrt4taHb3UO2lqZxEEsFJxhE35z9sf0EwHGkSzKwDAl7sbFnxkims= From: George Dunlap To: Jan Beulich CC: Andrew Cooper , Ian Jackson , Tamas K Lengyel , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 1/6] Intel Processor Trace Support: Add CHANGELOG.md and SUPPORT.md entries Thread-Topic: [PATCH 1/6] Intel Processor Trace Support: Add CHANGELOG.md and SUPPORT.md entries Thread-Index: AQHXIMzvmFyPoyKUIUaoJhxXt5+/SqqUVl6AgAAT7IA= Date: Thu, 25 Mar 2021 09:05:05 +0000 Message-ID: <0B436FE6-2C3C-40B9-A19D-275C3F46530B@citrix.com> References: <20210324164407.302062-1-george.dunlap@citrix.com> <1fe59844-d512-805d-fefe-8522cccd59ca@suse.com> In-Reply-To: <1fe59844-d512-805d-fefe-8522cccd59ca@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 38fa6b1a-4e17-4598-0b7d-08d8ef6d1542 x-ms-traffictypediagnostic: PH0PR03MB5879: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LbY2xOlva0iDjUmZxhMlaBSNjCUSrywoyBCn1FEarzk+bMzzVxwgQK4iSheRnND/OFwL+BA59wenTDh9qIxWrs44k3AMZ90yY7ARxi0HL/h0rUe8RdWMm80/JCfVT5Af+nXu9fQsV2Q750BbaqSYo5lZAF5ZG4ADd7RfOSyOlYghTMRqtYgTpq5Y6iPcvWsq9eeqSTM5bzFhWNKXuDNZZyD+BP70sG8rEnMbDxhRg+0tf6zubipL6ZPC3dOoMyUSRi4pPI/Pi3Wv8wVV9jjo0960PGDO7HKJnosCPV9s+6d0TmnVIP3C4Tc6u9HwbX+HxW3u6BnQrON5Q5dgRqUJqxIdoikfomXck8P4YWq2T9Ks/6P4vChh/bDT+2dYzjEYkiPCEQwRw8yKRwuioNVBj/Isw0cUY2WPo0fMtBaE3vQDH1BF1MheTaM8jWkBL41UoMKrMTH1A2Y5lDCTg+IXI8TZgBw3qgQmt8KWAu32dM1x6k0F0GsFgLvEB1ModR3q3f3BfRnHnR6AQMn04xgX4KmX+KdFqXkDrk5krfOosgopP+AKSkGbxVM1Nz57yMSgcR3VaacjotvqjvDQ+k0jJ35sBKNCbyl9rz24+wAWK2k7DjMhtm3B6H1SeTyvR42oJK+3pNjR7o4wyPJMsoUZrBJlVpCZ8tdCW0LBDWqi1vUlPgcde9ORDvNZ97G7eZd67T+sKmHqqG+CxlcENToBpoy1UDJJ9LeSmj9B1pfe/Z+TuRF5kPJX9feSg+MS35WD x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(346002)(396003)(136003)(366004)(4326008)(91956017)(6916009)(83380400001)(6506007)(6512007)(66446008)(5660300002)(33656002)(53546011)(86362001)(38100700001)(478600001)(76116006)(66476007)(66556008)(64756008)(66946007)(8936002)(8676002)(71200400001)(4744005)(26005)(2616005)(2906002)(316002)(186003)(54906003)(36756003)(6486002)(219803003)(207903002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?OEG2tPq0N/dqHVmSJNaNkda3JZ7BGZba6rYJRTwbL2KQSG2EtptF8EPUI7J+?= =?us-ascii?Q?j3SdQ7E24oVbJxg22NP8cph/2BGQgmK4XcKVe5P09eq/xgH3lDfnHgBdp4Pg?= =?us-ascii?Q?C2dZxPT/aLoCQEvcIcBDrJmLVgkVGTGdGjmgL463y2H75zj6hqDpkIRbMbVs?= =?us-ascii?Q?pxFKDTiZOtc03E5uDbIZuirRQSvUtT9QMlX0jyQEDZYV7ORhniIR9jU9mTnb?= =?us-ascii?Q?x9dE1A83qsHwQlNU0VdCcSaKe17GlHvYJzw8RMSTPsghAtFcCkDIwxIJVK1t?= =?us-ascii?Q?nk+L512Zzep1+g1dZAKkJHHZehsJwfF+39TWLhRwEcdt85eZE3+TdQB/uNml?= =?us-ascii?Q?5a0p0DkiXNNsf2oz54Qg0TAZvzdE/67MGgQUSAYWp1pqqb/ZBTp0VAwZxrpR?= =?us-ascii?Q?fgv46Ykfj7/1sWfqhc6C53dgLhcJnnmxZVJ3cUmQPPNGZjdirunslwVADU0B?= =?us-ascii?Q?MnpmjF+Ishn3Yorg0Z0jXl4zslyiDPSstxCcnOdqdbi4bpZkFdbpZ6YnPdEl?= =?us-ascii?Q?sVlkWU2ehJvs0QQYZuM+jTWnD2S4uka00nCzvfRzrpknVNjfRoOhqnQ1MG3f?= =?us-ascii?Q?MvyYvGGmaa4ydoCLAPRF/Fi4W2h3YtcVetP5qj401EIOde+osKlcT4aZsnx4?= =?us-ascii?Q?u3pn8W9EhqlwuQH5rFFefu30xPhkyGPqRBTkivPIwpYNXlv6+Mh+xPyrz3F5?= =?us-ascii?Q?gCKBPx8yCeYOgKcqjyQNSVNdbuKryX1sVDSRHtzTPhX9dpEXSeyMRXLWRWpB?= =?us-ascii?Q?ZeIX3quRZkphAKsNcfU1rGRphrt2jjMp+lBZBfK9A1W868wuKDaV7pLmteDV?= =?us-ascii?Q?UuAHNMZzdHdr6yuEy3473Yenv7VyOqTa58x/VlUZ88NPdN1XkTwif/DQ1C1m?= =?us-ascii?Q?8nXRp1owYBpO40rsZh+GzeP77OdA8sT1HLRttCNOjGJ/0gq42RivzrADP+aL?= =?us-ascii?Q?kIIlGEl3hc1fM1VQ/l3IYCG2XTE61JEGjwG7xg/jKnsbiNdOdmRalF2YX7s+?= =?us-ascii?Q?guaBfIMUkU++uj4KboDm4NdnylIijBvxdCL3cvA6IHD8991+eFaqkJ4mIEkY?= =?us-ascii?Q?K4IZmwhJ0ARvW8C1i7a55vDR21OdHIxWB/fWJohRDMZxcik/HyTNolHl8U2d?= =?us-ascii?Q?P03YLqdsG88AIfjdE7OkMPMb+e79WXwk3zLo65YI6EtaVHRhg46cTQQWnRgU?= =?us-ascii?Q?T2tZjA/zrOU6+dpaSp/164ucQxmdVbDVfAiMgFvHfZQi/TPwK3SU4qFJWb5L?= =?us-ascii?Q?irm1bl7/0fb+boiLTGtTPn9BiuUUuTIQbqnS9jR+ul7SX9jSUnndLHgS1Gf/?= =?us-ascii?Q?6FNc5UvOVlC6aUnxg4h5YS+ihev5O/YJGMPS8rdnD8YglQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <20F39B63AC951C4E91FA34B1197EFE59@namprd03.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38fa6b1a-4e17-4598-0b7d-08d8ef6d1542 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2021 09:05:05.8366 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bKFZsssQ6S7MsnuH7uiVtL9zLT2tZxt9zkBql4oOA0S9xI234GYMTmdqP14a7puE6mKU57sk5DIH8G2QnEzNh+VXRBcfWU2vqoobJfav9g8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5879 X-OriginatorOrg: citrix.com > On Mar 25, 2021, at 7:53 AM, Jan Beulich wrote: >=20 > On 24.03.2021 17:44, George Dunlap wrote: >> --- a/SUPPORT.md >> +++ b/SUPPORT.md >> @@ -247,6 +247,13 @@ Export hypervisor coverage data suitable for analys= is by gcov or lcov. >>=20 >> Status: Supported, Not security supported >>=20 >> +### Processor trace support >> + >> +Support for using Intel Processor Trace technology to trace guests >> +from dom0. >> + >> + Status: Tech Preview >=20 > While it may not strictly be needed here, perhaps for consistency with > other entries >=20 > Status, x86: Tech Preview Yes, that sounds good. -George From xen-devel-bounces@lists.xenproject.org Thu Mar 25 09:05:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 09:05:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101319.193688 (Exim 4.92) (envelope-from ) id 1lPLvL-00067G-Tw; Thu, 25 Mar 2021 09:05:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101319.193688; Thu, 25 Mar 2021 09:05:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLvL-000679-QA; Thu, 25 Mar 2021 09:05:03 +0000 Received: by outflank-mailman (input) for mailman id 101319; Thu, 25 Mar 2021 09:05:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPLvK-000674-U7 for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 09:05:02 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ab5551d2-da80-4b4c-a539-c0009867a0db; Thu, 25 Mar 2021 09:05:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab5551d2-da80-4b4c-a539-c0009867a0db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616663101; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=BxILtFVAFYqFLUO+ZUtbAacCYZULn4s7jJwSLI0/ogE=; b=RgOi99IEQS7Y0RIFjw7HDaDTzWOJ079CNyenm3L5CVGwIV0qW9y3yCF+ nMcA6nOG3TRV9LycESzP8KNMwZNhM7qQv5AT7hBg/GVazzvfHEm70H3pW 7gp+VTK5jdZfP8O1KY7Kz+W4YPNLvezpumZ14E4zHcyabr4do/A7tOho7 s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: o1KAk7uCs/AqqLdqZNUONwRp8MYvm7L09n/fY87w5TZ7q2X6bIJvGs5OUudU5zfRjVEMWncu7f y9piKaQK3F9dIIZtFD2Hq9dn7WVf4pRynUdMfFTEMoHtdycI23rAHkGyyLswPcekBRTW42sEW7 NHblFRRUTTZNVkTa1dDgoN5Wnq2fxcmuyqevRHuXw2eV6sEXbk47fSqx/wfvKAa1L5o3AqOepI C3uDyee8+WLj7YrnDP1nzI99HQrw14OZ7TH3YVMmkc4u+Oo78xjBDb8C2lP7+JSc27Avx6zw/a Zjo= X-SBRS: 5.2 X-MesageID: 41540844 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Eb0XH6B5oFN3IQ7lHejRtceALOonbusQ8zAX/mhLY1h8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPvfVr1zrQwxYUKJ7+tUE3duGWuJJx/9oeK+VLdMgXE3Kpm2a 9kGpITNPTZB1J3lNu/xQG+HcopztXvytHVuc715R5WPGVXQotn6Bp0DRveMmAefngGObMSEp 2A6s1b4x+pfnoKZsq2b0N1INTrjdvNiZ7gfFo6HBYh8gaDlneF77T9Hhie0H4lInNy6J0l9n XIlBG827W7v5iAu1Hh/kLwz7ATotvuzdNfGNeB4/J1FhzAghulDb4RI4GqkysypIiUmTQXuf nK5ywtJsFir07WF1vF3CfF/ynF/HIQ52T5yVme6EGT4vDRYD4hEcJOicZ4X3LimjEdlepx2q 5KwG6V3qA/ZXir8USNhOTgbB1kmlG5pnAvi4co/gZieLATdaNLqsgn9F5Vea1wQR7S0pwtE+ VlEajnlZFrWG6adHzQsy1Ox9GhTx0Ib267a3UCocCc3nxqmml4xSIjtaoit0oHnahNLqVs1q DhCOBFhbtORsgZYeZWH+EaW/a6DWTLXFblLH+SCU6PLtBEB1v977rMpJkl7uCjf5IFiLEono 7abV9evWkuP2rzFMy12oFR+BylehT5YR3djuVlo7RpsLz1Q7TmdQeZTko1rsemq/IDRurWRu i0I5ATJ/P4N2PhFcJo0mTFKt1vAEhbdPdQlscwWlqIrM6OAJbtrPbnfPHaI6eoHi0jXm/5H3 sfTDn+LMhN9SmQKznFqSmUf0moVl30/Jp2HqSf1fMU0pIxOopFtRVQiVnR3LDTFRRy9ogNOG duKrLula224UOs+3zT0mlvMh1BSkJc4LDqVWJWtRYHWnmEKYoripG6QyR/zXGHLhhwQ4f9Cw hEvWl6/qqxMtiX3iAtC9WuN2qAlHsNrHeWT5MR85fzovvNS9cdNNILSaZxHQLEG1heggBxsl pObwcCWwvCDD/0kL6ki5YVHenbcNF5jG6QUJVpgEOakX/ZidAkR3MdUTLrbNWehhw2QSFIwn dr9bUEvbaGkTGzCGc2jegiKmdQYGCPDL8uNnXeWKxk3pTQPCB5VyOjmCGTgRBbQBuVy2wiwk jaaRCyVd6OKFxHoXxc2rvt6zpPBxSgVnM1TGt7v417HXnBoVBp34awF/aO+mOMd1oPxfwcOj nZYT0UZhhj3cyzyQT9okfwKVw2gpopJeDTF7IlbvXa3W6sMpSBkeUcE+ZT54sNDqGjjsYbFe aWewqYN1rDepMU8h3QonYuIy9vrnY41fvuxR3+9WC9tURPS8b6MRBjR7sBJcub4HWhT/GU0I 9hhdZwueerKG3+ZpqHzq7QBgQzZy/7sCqzT+syr4pTsr93vLxvH4PDWT+NzWpZxnwFXY7JvV JbRL4+7KHKO4dpccBXcyVF/kAxnNDKKEcwqAT5DuI3YFlFtQ6VA/qZp77T7bY/CEyIowX9fU OS9CBQ5P/JVSqO37xyMdN6HU1GLEwnrHhy9uKLcIPdTBiwf+ZY5VygLzuzdqReRKXtI8Rnkj 9qp9WT2+mZeCrz1FqO4X91IqdS/32mRs33CgSWAuJM+8G7P1PJgqbC2r/GsB7nDT+gL0Ifjs lZcEZVaMJJgDwrlpc23Si/UbafmDNsr3JOpTV80kfw0Y2n6nrBFU5IMQfFkoxbNAMjR0SgnI DA66yEz3zz7zhOxInbGEpRdt9IHcIMToKfFVYYFeEA+Liy/6QuhSxfYBAhS24k4QqNrd9b4Q == X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="41540844" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I0TdoZaFhwf3qAVBSch5O/1IacmNFUqcwKU4t6FMYNXlWmtOiuK6ICqsT+7iTH5ZhNy9lJm9OKCskCfH8GcMSoEw682c1wFDZV9pglpWiS8As8ftYZurvlVYJv99FCGRwcUDlHY0dNWhSrLK4ECS2VMiemEUuTPdhM7xU8gtM1RwLWVWWjS0J2sINOltrjlEioRSZY8QE+SDA1SvXtf6K+wMzyb9GwHWadl6AXKE24WMRpKP2Fj2G0JNiUrTpPSDkp5uOLlOOJB/NB9elS6U7p8T35Civ5KRi9Izgc4vG7VM+JkmFGJ92YhhPmzrOchdh7NBsBRo7cc0ncGXEfKA4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BxILtFVAFYqFLUO+ZUtbAacCYZULn4s7jJwSLI0/ogE=; b=BTZNBQefvXOZqzYIBXE2kOxEWczoK5bND1lRrHjUfxlcAOgNETFfO4UGNgT/KzEoKBR1i1+T1agin8CiYm6SrjnzyAzQnG5ZxLbpvRUrJ4kZxjwXjV2BQCe4nEZ9iE2UuGGyYrHsCtOaYCi32ztxj6UiF2tP3gS63f79uzq4zUPudwIR1Oeq0McGpUlFp5kjS0l9etmlAzFI+9g8OIzhu7gxGi2nwTQKksVK3p8jPEGmgYLUmjncynHOnCUUeaO5mqYeXtc5jlenxvh7t6SpBdvqBt+Ux93FCTrjLcYlNOLOV2hpFPXLSdpz+Uc9G3OggnqnJAlDn+GzrfbAL9kRWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BxILtFVAFYqFLUO+ZUtbAacCYZULn4s7jJwSLI0/ogE=; b=wugTdDnFe3RNrF2IuQqLer9orKpzk2HCcR36MkaKlzjpgB9KPPbzxYqq9PhKaJ+vZq7AeRuq8TWFFlh3nfa7Qtv6O+drd/slYHTps/Il384+C+Yav3FH+sHPvShXZv57ag3rQS3wv/eLfS7YmKnMnVfu0pIYvj+mdhaBb8C3grs= From: George Dunlap To: Jan Beulich CC: Ian Jackson , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation Thread-Topic: [PATCH 5/6] CHANGELOG.md: Add entries for emulation Thread-Index: AQHXIMzvj/osZBndl0iN655u2tDs9qqUV1aAgAAS04A= Date: Thu, 25 Mar 2021 09:04:37 +0000 Message-ID: <0A187740-DB6E-486C-8B10-5207CE6A5D72@citrix.com> References: <20210324164407.302062-1-george.dunlap@citrix.com> <20210324164407.302062-5-george.dunlap@citrix.com> <33f78891-c894-b41a-a1a3-82aac1f57b8d@suse.com> In-Reply-To: <33f78891-c894-b41a-a1a3-82aac1f57b8d@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c27f9fa1-2d52-4b35-bc74-08d8ef6d0476 x-ms-traffictypediagnostic: PH0PR03MB5879: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +3S5loMCf0yyJIEkGN+jwKx3H6vtRqPtJZERT/nVudYOQ3cKVMO1RUlYo6RdIQsnNA7hYJbQ0R1/+ojQG8FG4LuOjTvjZwA8HDCbLCu5RXv44jLdyIdx0iSh9tv9AGsOxRQY+P7Cguf6KDMG+T2R9uYnapGstrA0CZZzj1IgfXA2cKChFYYccaQ0OOD+7zFIF8KZXtv5V5ndTUiQNgEoKBHePuyUpVBlcGBZ/4nSBN+WNSzk3U+pfqPpgE812Ui9UZb1ZRjQe8/0JTFOAQX/5iuvY+PuCdZtpt+83aZiHLcsTb3xmRdBZuu4/n7mpy+4Af/8PAunFqFigrHAZZx80TMz9URfOFvtPl+Oolf3nZOzydhPHd1Khi8vRuGwfadKqfSfpAsTpYiKXYy3ixkEBhWRi1ZifbPIOtsySt1zdw5DMZBAU8JGfyxKHU/5mYwGepZ2sOEC+jSYXTStvi6AUcU6B/bu5f/l+vB8vJGmZJRxYCZst90RFx0KjKVpMQtOuONEtaQPoQl/oxdfMkD+rbSHgFX3U1ror5jXP0ZXD0PJfyDjT2iC9Gur0uh+EX1EMXTAheVz0wZBH5ojkawkkI1Z0YhZoaFLVFCH5YQvTg8lHhzEfJAgvlR4JuEHc3ShVKZkghduGcPjzcBYAIFFDLsEuHK4M3tn0yC1FWk9pywwgr7xLF61Jg1eXDaQdtqZ1qkGODIZK5WIbtI9ulWek/a+EMjt2dwhE4inrkR6+ym2v+vxhpTTjy+OZpY1lmN44tJ2UHtAHQQOcPzDndzgd3HDGvtSJ6nvYyt3CYvU6DmRwbmmPmoIPicrzky4IxaT x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(346002)(396003)(136003)(366004)(4326008)(91956017)(6916009)(6506007)(6512007)(66446008)(5660300002)(33656002)(53546011)(86362001)(38100700001)(478600001)(76116006)(66476007)(66556008)(64756008)(66946007)(8936002)(8676002)(71200400001)(26005)(2616005)(2906002)(316002)(186003)(54906003)(36756003)(6486002)(219803003)(207903002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?b1Ayc3ZhR3hVTTVab3JjcEZXL3k2djdXZGt6REo4UzhkRXE4eG1zVXV4QWpZ?= =?utf-8?B?UTFFOVNuVnlHWXY2VzM5WDlmbDgvSFpkRVFteE83ejl0ajZ5QnF1Q1dEZzly?= =?utf-8?B?c25EVGFhYVhzTGdnRkRRLyt0anF4ekNTUWFoVXBYNWo0dS85L0FzTmwwQytW?= =?utf-8?B?TUMySHRYZVB2aUZhL0JnK2g2YzMzb2xaellEaVRQd1l0Y1VueGlCVW9wYjVw?= =?utf-8?B?M0ZIamtOTmZxemwrbjFNQjBTZURLRVRzVzRVSitCQjNNTHo4RGx5NE5CZnkz?= =?utf-8?B?TkM1VmRnYXpMV00yU1RUdnhBNGw4eGNJYldVWEdaSndBNUs3M2dFSXhSWUdZ?= =?utf-8?B?NDhBUTVZZm9TS3kvUVFNVzJ4VUdCQUxHMHY1NHFzbktYVWV0dDJEcUdRK0M1?= =?utf-8?B?ZmNWcmhaWndLeHJuYVdBOWxNeEJEdFpQamgyaDdmM29zL3lwVU5yV29GWFZH?= =?utf-8?B?NkxlcStEYzlybDk5WHNmRkIyZGtYSDU4SjF5c2RjSGpiRmpVRGdHdlpBMmhG?= =?utf-8?B?WHkrOHBlUGpvL2E5emR2YmhaaUtueEVBcURUZ3pJWGVUS3RGL0QxUjRQZHYz?= =?utf-8?B?S21vOVBkQmZjTXdicXlEcWE4TnBsSW95aytBYnVzRkg2RUZ0TVNsL2MwUXhF?= =?utf-8?B?VHVoc1YzZ2RNd3FmczRlK2lHYTNkMFptcUtjZzd5eFFueDBublBOMWVvRUxX?= =?utf-8?B?UWZrQUx2QlhvMlpMZDZZakNyVkROS3JpbUpQN2pDaFBGZWF4TFRlMW5VUkhE?= =?utf-8?B?R0NWTTc5a2d0MmExSnhiRXdlOXBvR2hzdVVXM0lxMTVZWUw1SzB3UkdrK052?= =?utf-8?B?ajUwaTFpc0pYTWdhd25qQlplcEpMQmZxUlhqZC80UGV1V2RweHZtNitQWjF2?= =?utf-8?B?RU1qc05QK1NJa0Vac2c2SjArWTJ6OVZ2UTByUWJ0RnZ3RkJ3ZXpRL285Q0cy?= =?utf-8?B?c1E3R0RmRVVoa0R2c2xxV1N6QmFyblJNelVXRndWN2dxTWtPWEFBck1VRlFj?= =?utf-8?B?Y2FsYVV6Sm1Ma1EyMkhabkx4M25vaWppSEM1TUZkNldXN2RoRFFhZW1QSytD?= =?utf-8?B?elhicWxwdkNHajVGMFU5Ymx5VlNKTVlhNEpaRko3V1BzdVVOcWN3NDcyQzZ0?= =?utf-8?B?d0ljU20rWWJPeWdSM3hvMTRLZ1NhSGkxczRJREJyc2FJRXZDY0dIRXRCNE0x?= =?utf-8?B?VnlMUFJLbFJpNzNpcmJIQ3RJKyszcjMvai9DODg2V3IyYkdTNmYxaFlic0Jh?= =?utf-8?B?V1hpL21oV2dPazN0bW16cFcxeWp4N24zY0thQkN4QnI1T21aUVU1SElCTCtu?= =?utf-8?B?WVZlVGlqeVRMOHhYdlpKVm1la2JYZUtKS2dJVGVPR1VjVWFrdW9hTm1yMUtk?= =?utf-8?B?MHBBYVFOS2xIZmxOU05hQzNUVzFMb2NRWENycFpydGFPSkQvUW1UNDdYVm9s?= =?utf-8?B?YXJkVWZRZm52dWFYc2pFbUJwSFVoWVNUYzRhZWFrWk9wOFl4NThtbEZjbGF2?= =?utf-8?B?ajRabE93cTkxKzJpeXR3YWk4amoyc1pSd1YrT3hZYUc2bUtRS3pKb2RTVDFD?= =?utf-8?B?SFI2RWpBMUhjMEI2VEliL3lRTHh4djlCUWhscXhMZWRXNjZpUStrK0Jacmhs?= =?utf-8?B?Zlg3RDQ3UnhjN2hrWklVM1pCWUkwOW90U1dOa21jdG5lQmd5YWVGTWx2Rk5O?= =?utf-8?B?aU9vTkJJcmNBQUhwd2s1T3ArVCtyeDRYNFEwZjExejF6L09MMWRQazRQdE9B?= =?utf-8?B?UmxjL2pNeU5qZnkrbkRyNDhyREY0QnIvSjBtSUgvbzZJckxLVFRXT1RDb0Yw?= =?utf-8?B?RzVPcFowaUhhd0hmZkxZUT09?= Content-Type: text/plain; charset="utf-8" Content-ID: <63652B1B5CA08D40BC387F0A52B438BF@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c27f9fa1-2d52-4b35-bc74-08d8ef6d0476 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2021 09:04:37.7333 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tV5HSbTzL6qCP2nDpN1Iecln9mZ4RKJj+Viyl+D20eqBjJ6Xol72A9ZxKpW05einaDGAFGZX/MNkLDwTqKfZDGuRd9GKvBAwhsh2KaR5cs4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5879 X-OriginatorOrg: citrix.com DQoNCj4gT24gTWFyIDI1LCAyMDIxLCBhdCA3OjU3IEFNLCBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMjQuMDMuMjAyMSAxNzo0NCwgR2VvcmdlIER1bmxh cCB3cm90ZToNCj4+IC0tLSBhL0NIQU5HRUxPRy5tZA0KPj4gKysrIGIvQ0hBTkdFTE9HLm1kDQo+ PiBAQCAtMTQsNiArMTQsOCBAQCBUaGUgZm9ybWF0IGlzIGJhc2VkIG9uIFtLZWVwIGEgQ2hhbmdl bG9nXShodHRwczovL2tlZXBhY2hhbmdlbG9nLmNvbS9lbi8xLjAuMC8pDQo+PiAgLSBOYW1lZCBQ Q0kgZGV2aWNlcyBmb3IgeGwvbGlieGwNCj4+ICAtIFN1cHBvcnQgZm9yIHpzdGQtY29tcHJlc3Nl ZCBkb20wIGtlcm5lbHMNCj4+ICAtIExpYnJhcnkgaW1wcm92ZW1lbnRzIGZyb20gTmV0QlNEIHBv cnRzIHVwc3RyZWFtZWQNCj4+ICsgLSB4ODZfZW11bGF0ZTogU3VwcG9ydCBBVlgtVk5OSSBpbnN0 cnVjdGlvbnMNCj4+ICsgLSB4ODZfZW11bGF0ZTogRXhwYW5kZWQgdGVzdGluZyBmb3Igc2V2ZXJh bCBpbnN0cnVjdGlvbiBjbGFzc2VzDQo+IA0KPiBUQkggYm90aCBzZWVtIHRvbyBtaW5vciB0byBt ZSB0byBiZSBtZW50aW9uZWQgaGVyZS4gSWYgSSB3YXMgdG8gcGljaw0KPiBqdXN0IG9uZSwgSSdk IGtlZXAgdGhlIGZvcm1lciBhbmQgZHJvcCB0aGUgbGF0dGVyLg0KDQpJdOKAmXMgYWx3YXlzIHF1 aXRlIGRpZmZpY3VsdCBpbiB0aGVzZSByZWxlYXNlcyB0byBoZWxwIGV4cHJlc3MgdG8gcGVvcGxl IGV4YWN0bHkgd2hhdOKAmXMgaGFwcGVuZWQuICBXZeKAmXZlIGdvdCBvdmVyIDEwMDAgY2hhbmdl c2V0cyDigJQgd2hhdCBoYXZlIHdlIGJlZW4gZG9pbmc/ICBJZiBteSBzdGFyIGNoYXJ0IGlzIGNv cnJlY3QsIHRoZSBsYXR0ZXIgcmVwcmVzZW50cyBuZWFybHkgMTcwMCBleHRyYSBsaW5lcyBvZiBj b2RlcyBpbiB0b29scy90ZXN0cy94ODZfZW11bGF0b3IvcHJlZGljYXRlcy5jLiAgSXTigJlzIGFj dHVhbGx5IGEgcmVhc29uYWJsZSBjaHVuayBvZiBjb2RlIGNodXJuLCB3aGljaCBJIHRoaW5rIGlz IHdvcnRoIGhpZ2hsaWdodGluZy4NCg0KUmUgdGhlIGZvcm1lciwgSSB0aGluayBsZXR0aW5nIHNv bWVvbmUga25vdyB0aGF0IGEgbmV3IGluc3RydWN0aW9uIGlzIGVtdWxhdGVkIGlzIHdvcnRod2hp bGUuDQoNCklhbiBpcyB0aGUgbWFpbnRhaW5lciwgc28gdWx0aW1hdGVseSBJIHRoaW5rIGl04oCZ cyBoaXMgY2FsbD8NCg0KIC1HZW9yZ2U= From xen-devel-bounces@lists.xenproject.org Thu Mar 25 09:10:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 09:10:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101326.193716 (Exim 4.92) (envelope-from ) id 1lPM0N-0007Hg-Pl; Thu, 25 Mar 2021 09:10:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101326.193716; Thu, 25 Mar 2021 09:10:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPM0N-0007HZ-M6; Thu, 25 Mar 2021 09:10:15 +0000 Received: by outflank-mailman (input) for mailman id 101326; Thu, 25 Mar 2021 09:10:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPM0M-0007HT-8z for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 09:10:14 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f8bdc2fd-143a-4f60-8c05-a235989d0000; Thu, 25 Mar 2021 09:10:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8bdc2fd-143a-4f60-8c05-a235989d0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616663412; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=HOZWbGlbhxxJD2vJ/uM6///3+z46T6ShUqQYtOIdLCo=; b=cX0ZrGJjs1/wjnd87m0nGz93IIsYhVXFH96wfSk6eGuOlFgWypixsSwi sYeiIUpPDSe2p05HwR+4Ei7+rG+Q1zjU9ZPQGkRkKJxgDqjJt2UWEfZAk tAbf1k8WaOxOalontnaOkhkaRtD+DEpVH2JYltKNQaUtfJxUAbGRiXAms 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: a4Bbf+NW+K3TdNfwnL2cl4X0OvFXi/Txre31iiSGluz/dVlKiTubdrTZ6RAm/fM4wzIDtjD+WA zK2kgLDbg79GXPcawDBgRAotXUCIlV2KaUmPXqn3RfHimrZSYved7P2jo1Rgc6eTOzdHiajfkC YWSgRqcF+YUMnkrH3+lwACK1vNRoFeIe+EBkX/DhgEHN3Ka78Aqz2Grblw1U+rlApiGM3bNKtz IgSvvxn1inGRG9jURV8ttjR3LisxTQs5q/hV+1OWnHzpc/hfr26qJ3ntCgIpwBM9wXbNycKQoC EoE= X-SBRS: 5.2 X-MesageID: 39977580 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:9Xg9j6v3ZFUnxs8yh7OWpIAB7skCkoYji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOjrU5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qw6Y 5JSII7MtH5CDFB4PrSyBWkEtom3dmM+L2pg+Cb9Ht2UQR2cchbjjtRICzzKDwTeCBtA50lGJ 2Aovddrz27dngNKui9DH8JX+/Mzue77q7OSxgAGhIh9U2ynSqlgYSKaCSw8zU/d3d0wbkk+X XYiACR3Muemtyy1xO07R600714g93ko+EzZvCkrugwBnHShh2zZIJnMofywgwdhO208l4lnJ 3tjn4bTr1OwkjcdG20vhfhsjOIuF1Fiw6AuC+lqEDuvNDjQ3YCA9dB7LgpDSfx0VYqv913zc twrgWknqdQZCmw+RjV1pzjUhFnkVeMunwykeIfpGw3a/pjVJZh6aMY509bC5EGAWbT750mCv BnCIXm6O9Rak7yVQGSgkBfhPiXGlgjFBaPRUYP/uSTzjhthXh8i28V3tYWkHss/I80IqM0qt jsA+BNrvVjX8UWZaVyCKMqWs2sEFHARhrKLSa7PUnnPLtvAQOCl7fHpJEOoM26cp0By5U/3L 7bVklDiGI0c0XyTeWTwZxw9AzXSmnVZ0Wj9uhuo7xC/pHsTrviNiOODHo0ldG7nvkZCsrHH9 mpPpZ7BOLiMHvOFY5F0xaWYegTFVAuFOku/vorUVOHpczGbqfwsPbATfrVLL3xVRYoM1mPQU crbXzWHoFt/0qrUnj3jFz6QHX2YHHy+pp2Dez/9+gXw44dC51UvmEu+BaEz/DODQcHnr09fU N4Lr+iuLi8v3OK8WHB6HgsHRZBEEBP4vHFX2lRrQEHd2P4GIxz9+m3SCR35j+qNxV/R8TZHE p0vFJs45+6KJSW2GQFENKoMmWTilMJv3KUR5IgmqmOjP2VO68QP9IDYuhcBA/LHxt6lUJBs2 FYcjIJQUfZC3fTk6m/tYcVA+vebtF4pw+uLadv2DfinHTZgftqamoQXjaoX8LSpQo1XTJbim d89LIljKOalSyiLnY+h+oEIERBAV7ncY5uPUCgXsF5i7rrcAZ/QSOxiTuWhwoaV0Dq+08R71 aRZBG8SLXuOB5wq3pY2qHl/BdIbW2bZVt3cW0/m5Z6D376tnF61vKraqK/33CKUEYLxvgQPV j+EH8vCzIr4+ry+A+emT6EG3lj+44nOfbFCq8/N57UwXGgJeSz5NU7Ns4R2KwgEt/gsuUGC7 3CPyCUKS71EOMv1Ui+oG0/NCx9tXkjlrfJ1XTenRqF9U96JcCXBlJsA4w/CZW7yUPPQv6Typ V3jd4vp4KLQxPMQ+/D7ZuSViJJLxPYnHW/QO4po61FpK5ajsoBI7DrFR/zkExd1BowLM3IhF oTbaRy7rfGIJJudaUpCldk12tssNyOKUcx2zaGetMWTBUIj3XBOcmO7KeNgb0zAleZrA+YAy jWzwRtu9PEVTCEz7gUFuYZJnlXclE17DBH8PmZf4PdTCWseOcrxivwDlaNNJtcQrOCA7Mes1 JT5MyJhfaec27A4z/r1AELVZ5mwiKAWsO9AAWFBO5O/ZibAD2389aXyf/2qiz2Rzu9Y1kfnq tfeyUrH4N+tgU= X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="39977580" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5HS7lg12ay8wSsRtufc2sjiW4UeF2Id344NhnhJGvFea0MCy2u88xNVUmGc1YWF28UUX8NgCJhcNDmlZIXN+rBc4E8dTb8YesxH2pqpmL+hIdeVGqIq/0I78EBtK5SJ2sC16jeuNOmbpYnW1f84lEFgv1dIhTUiNs1XpdYFe3gAMxIIZVbybxIKhBS1qplRHRWgO52Boa06iepE3XXBj2GcGp85iHIDidfXQ3mTe281S2VhHIv+K1Uc5lgYXsU4MAYZr6LP0ImOMHgamrUGpt+nIQJvrru8hzjCuohpyDZnJ2Z9qsjOA5YZ8+agEftenRCb5VF/E3ehzcPn1Sj09Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gy90LQX86leF6ZR1WNAfhPrItTPQigLCB93lZMNhTss=; b=CAVRFwMPNbhlJB4fb9GQE/TbbFQ7+GoKOEMhJcT4qQHdMayEtby/Wvtqril7AE3NW7Eh1FsWxAThH2T6ctKPLYcK+NGnLLWcVvVuE5nDcvwQcG3xOsq7RdxUavGVdbP23n10YRdUaQjmjGvOiKwQzSEQncF34Yk6uFnVH2kx68YvX+IMtsvG2Wi76qalB7xLumwc8goPo577PiosEnOSAPHjHr1dOstLHeY2beMf2jsS3F95EaoB0RxoB8cWQidZPpo4PZs/O/cUPBAxpnXCqz629AtPjMQISMvL4L9sKmGntHAZ4Inp0LIAV+8aM/UtD39WMMZ41ZMisizYAVU+Ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gy90LQX86leF6ZR1WNAfhPrItTPQigLCB93lZMNhTss=; b=l1isVPP1kvlJw1X3B+dWLNUa2s7l5w/XMwF6WHq7IRoWAX0ikHP7bGPkx9GEJmrtPNcH3vP0PK3lxdRz9L8FXCghkqlbJEHoYGg/YRjKvSDSwrFVXxQE4w8MpaNfav3qmViyzL4oti6YJ4RBZ3fSQwpTtddxKTTjOdXsmbxlhsA= From: Roger Pau Monne To: CC: , Roger Pau Monne , Andy Shevchenko , Mika Westerberg , Andy Shevchenko , Linus Walleij , Subject: [PATCH v3] intel/pinctrl: check REVID register value for device presence Date: Thu, 25 Mar 2021 10:09:47 +0100 Message-ID: <20210325090947.73729-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM5PR0602CA0002.eurprd06.prod.outlook.com (2603:10a6:203:a3::12) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eff91029-e274-4655-2e18-08d8ef6dcaaa X-MS-TrafficTypeDiagnostic: DM6PR03MB4297: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2043; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L/aJcySS3t4xmVWgLa6twOE0P8YDoC+ZtndqT2izb5H+GMSt3wG191rQQeGJM6rYg+qhgQsTDMkCU7ywq9mICWOar8wWBTgurYbfIH84j+m6Q2d1I0NJSdJGW5IO9HWr/RDcPsFDq8WGXVT4QYjbE2xhObrE83AW5oroo6ZlRbeBFzEXSw19KEm2a1RHIqQP6HLixSLAq6ZBp1P5Q3C40wH2iB0TGcfcULAnI1wY6057MpVUk4+IX30x1Dm79l8F+lWDa4g69J5MnYgiwvpthKr2ZSnVKK93eHPYnixu2Begubp++GMkN2/1PIZw9AbP0/3U+xbtdOTtl4lNIg8J8rwSP6Rqv+6it2Q7ovTcO9D3n6o3+hoCPDAhr9uk5cnA6Gvdm0D8r2aQRuIar4XBrcogNeS+VCG+9XuOLVPd0lFGozeHAv+2Bt/W4zm5pHx5p0wbEaZWIOveUpYe8H5lMp9d0VMpTCzAP+vXsBWPyvay8c1szflrQGW/O4aoGIxAEzhUJDuO9oitE1PPq4aAjIoAcOFJiSV174YIUsU+TrQyDPp33uJSrHaRTigdX71lljgCO3sFgzs2PjvDeO9RpRmHa+fQjCwpGVH4B7HcdFQLXhWSyX9Uq3mDx3evbtzaeO8CkvYNyoZ8JLRo51B3I0pyASP69sOJKpqS4Hn+2Vw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(366004)(396003)(376002)(39860400002)(38100700001)(2906002)(86362001)(956004)(2616005)(83380400001)(5660300002)(6496006)(6916009)(8936002)(54906003)(66946007)(4326008)(8676002)(1076003)(16526019)(66476007)(26005)(6666004)(36756003)(66556008)(6486002)(186003)(478600001)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Sm1xUk9ydWVla1J0SzFvTUNoQkVqVjR2VzA5TS9TNUltQzlhdmhLNmk2dHdO?= =?utf-8?B?WGNtakNKdkJoaEVMYlZ6azAyWGFUbzVBbUZjV2Q5NTV2bjh4NUdWcHR0WnVN?= =?utf-8?B?UTUvQUJOckVvT0ZVWE00ODloaU81QjJXTFBObm5EU1pEQ0hsUEdJZUV5eTFM?= =?utf-8?B?L1F3MjJqTjZKT3MyMXJkVEFSV2kySGtlbTBmbmhPQTlqR0E2MS9aaUgvRkRG?= =?utf-8?B?NjQxQ2dWZEtpMDZ6R2huQTUwU1hqWm1xeVlpN2Yzc01EWGJ3eEhWbzlLR2Z3?= =?utf-8?B?WllrTlFRelkrRzhKSEliWXhxTzI3aWY0aUNMOC9RSkUwa3R0SHVIOEtOc0xM?= =?utf-8?B?R21SR1E4UkxuRVY5WmpmNnFJanNYcTM4ZWF5SmtldzgxYU94OWtkQWIwRU4r?= =?utf-8?B?dU1jNGEwajRkU0d5ZSs0MmJjTFVwMlFCNWJaanpqQUtrN0xxQWEyUHZLMXdz?= =?utf-8?B?VmVWOGQxQlpDWkx6OEFMektlRDRwM2xXbzBWVzRPMWZ2dWpxSnlDOGNtcytu?= =?utf-8?B?dVY3OURoYXFaU3lrZ1UvcFVKUkl2Y1IrSHdYbU5saWROWTU4dUdRdlNFKy9G?= =?utf-8?B?cERtWVFqNTVvU3B1NzZ3NVRSSTcySXQ0ZThKOG1SSExFeXAyWUxzS2lRTFZD?= =?utf-8?B?ZHRqMGdTVHhsL2JwenB2NGZTUjE3NUM1SEd4VmtjMm5yYWdDTUc5WFlFcEtU?= =?utf-8?B?d0pmS3FVVU93NXN0T3J2ZTZQZ0RUbDVCKzQyUEVjOU5hTnVpaTRISnhMQVFh?= =?utf-8?B?V1Vva0RESUEvcGMzV1hweVFDck5DcTRQdEJ5VXNpbDRzdnRMQmU4UFV5bHEy?= =?utf-8?B?TEh1R0JXNHh3elM5UzlnV2ljNVl5TnhjUkZxTDJyTUpreElaVFVhOGZqZFlm?= =?utf-8?B?Nkc4cEFkdEdkMXdTVUcvT1A3eDF2ZEh5SXFydjJGR2d0M21rRkFkZ3hwbHV3?= =?utf-8?B?cUFrSXlJdTg5NWc4VnN2b2hJbWlQaEtoVHg3RFRGUXZLaFBPVG4vMDB6RjFi?= =?utf-8?B?UFRwUVFZU3ZLRENSU3E1SS95Tk1taU1KT1dZMkdZOXpabzE4YVZydkx4RjNU?= =?utf-8?B?SzJZdjhxS1YzZkJGNTFHT3NwdVNGS3RpV05yRDV1amZpYlNqSituRlBBQytn?= =?utf-8?B?VEpJTTRxY0dXcnRWVzhEYjFkQ2kwVm52aG4vY1Fabjk3NDBPdHVnTllWd1Az?= =?utf-8?B?YVlyMmw5dUZMeCtDSURlaSs4VnRQNHpHak11OXNMc3dTaVVxQnBvbDJBVGtt?= =?utf-8?B?MzdQaGlBb0RXMHM1SnN1NFQxTjZ6eUEyelk4dExqWVUvSktmbWRCMTVOU3U5?= =?utf-8?B?dnBKa24vRThHbzcwVGdlcTdyNHZDaHh5OVBLU3lBL2h4dUJoWFlGa2NhQk1N?= =?utf-8?B?dnlJRWM0SUNHNHFybU9sd24xNE81c1ZLeEhrLzNrQ3lJSzZYR01wR1RMZ3lv?= =?utf-8?B?S3BWc2FLNTJjcVBkK0VvTm1PUXVrQi94S0swbE1ZTVNEaVd1QzlHZWU1M2xY?= =?utf-8?B?YU5lL3BTbm1KYkdJOEZvaUFoMjJBdzVtRGx3YWgvcVB1ODFKVC9xNit5aGQz?= =?utf-8?B?ZDE3L0d0ZEJLMUlLeFVadnU4cFAwY2c4VmF4Z1Fxa0hISFZlR0xmanY1S2lH?= =?utf-8?B?WGFyK29ST2VNS2E2UXdOWkdYeXVXRmRQZmpIdHE1aFpxVXVzNmlSaXozWFZo?= =?utf-8?B?MVJ5ZGl0ME5Ea3FyYVpGWWx3dXY4Mkh1MDI4ZTFRN0hxWUppZFVldEl3NDJu?= =?utf-8?B?cmhLQUlFTi82SWJkM0kzZFRpTFJzcWUweDlZVWtCNlpsSi9uY0RreGc0Ry9H?= =?utf-8?B?cUNobGkydnFYYmp3MWpuUT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: eff91029-e274-4655-2e18-08d8ef6dcaaa X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 09:10:10.5709 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q89aanN0sOehyGtZPebfcdQeJWXZXZ+AH00/BIkCLhD/QBhSo+p9TTslDJzDvnY5ebPa8YlqfkksakS8nGPMyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4297 X-OriginatorOrg: citrix.com Use the value read from the REVID register in order to check for the presence of the device. A read of all ones is treated as if the device is not present, and hence probing is ended. This fixes an issue when running as a Xen PVH dom0, where the ACPI DSDT table is provided unmodified to dom0 and hence contains the pinctrl devices, but the MMIO region(s) containing the device registers might not be mapped in the guest physical memory map if such region(s) are not exposed on a PCI device BAR or marked as reserved in the host memory map. 91d898e51e60 ('pinctrl: intel: Convert capability list to features') Suggested-by: Andy Shevchenko Signed-off-by: Roger Pau Monné --- Changes since v2: - Return ENODEV. - Adjust code comment. Changes since v1: - New in this version. --- Cc: Mika Westerberg Cc: Andy Shevchenko Cc: Linus Walleij Cc: linux-gpio@vger.kernel.org --- drivers/pinctrl/intel/pinctrl-intel.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index 8085782cd8f9..9fc5bba514ea 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1491,8 +1491,13 @@ static int intel_pinctrl_probe(struct platform_device *pdev, if (IS_ERR(regs)) return PTR_ERR(regs); - /* Determine community features based on the revision */ + /* + * Determine community features based on the revision. + * A value of all ones means the device is not present. + */ value = readl(regs + REVID); + if (value == ~0u) + return -ENODEV; if (((value & REVID_MASK) >> REVID_SHIFT) >= 0x94) { community->features |= PINCTRL_FEATURE_DEBOUNCE; community->features |= PINCTRL_FEATURE_1K_PD; -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Thu Mar 25 09:13:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 09:13:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101332.193728 (Exim 4.92) (envelope-from ) id 1lPM3R-0007Qm-DJ; Thu, 25 Mar 2021 09:13:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101332.193728; Thu, 25 Mar 2021 09:13:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPM3R-0007Qf-9o; Thu, 25 Mar 2021 09:13:25 +0000 Received: by outflank-mailman (input) for mailman id 101332; Thu, 25 Mar 2021 09:13:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPM3Q-0007Qa-6K for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 09:13:24 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2c9ea82d-93a1-44bb-90ad-99af614c461a; Thu, 25 Mar 2021 09:13:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c9ea82d-93a1-44bb-90ad-99af614c461a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616663603; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=3QGBIwDxSIudNwac8EMQLqvFIk1qfsmsE3bo1R2Lodc=; b=ev0DhdGMAqstcww83sGtOVFPUHqSAed91SSSFIPgg61d386LxxCCWWFH icTFYTccqxtCbvT6s7mqfwOUFDgjPwoP9es2UE4r301BRbRtdu07IQzJR vGqxOtuNqXpCe4ldignxcFLw6PF1biinCp59q2g9drz2MSDYsbh+f9CDw U=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: vSFjSaYp5itjCOs7bOeFdiMfEdh99xpA4Oq9aYE0hPlK8IoE+piZf72tLqOVcz8OG2my3YmfAm ARn+pjbb4RiqSiZx+IBhPPa9twT3RqTPHoxOiI5ScDnYdP9XIC4EmyLqxKIYs/0nuGFmFIxoiz rjL4cgNAQOdRpsy1DuLQTyKzYoWyuEAHf9EedZhK+KPyfaGdj5tCgV4dvX67eElDaWJUUtP/s8 0m0gRn3geqYjmrg0b1YhZbQZe0pMK1pd9rfI6ia6aH3Pchle2Hw5RC56zJF2OGcxtaHDPa+QpB PQc= X-SBRS: 5.2 X-MesageID: 40083900 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:ChcYpaGFI0zJX9DEpLqFWJTXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7Lk/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeNJwTXzcQY76 tpdsFFZeHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLD1CQYsI1XYfNi+wFEpqSA5aQbc4Do Ob/MpbpzymEE5nFPiTLH8DQuTFupn3j5rgexELHFoK7wOJgDOu5tfBYmWl9z0ZVC5CxqpnzH jdn2XCl96emtyY6juZ7W/c6JxKhMDso+EsOOWggtUYQw+c6DqAS59mX9S5zVUIicGprG0nid zd5yonVv4Dl0/5WkGQjV/T1xL70DAogkWSuWOwpXf4u8T2SHYbJqN69PtkWyDU4UYho91wuZ gjtwny1+s1fGH9tR/w6NTSWxZhmlDcmwtbrccpg2FCSoxbUbdNrOUkjTJoOa0dFyH34p1PKp gJMOjg4p9tADenRkGclGxuzNuwZ280DxeLT2MT0/blrQR+rTRXyVAVy9cYmWpF3JUhS4Nc7+ CBCahwkqpSJ/VmIZ5VNaMke4+aG2bNSRXDPCa7JknmLrgOPzbop4Ts6Ls4yem2cPUzvdQPsa WEdGkdmX85ekroB8HL9oZM6ArxTGK0Wimo4t1C5rBi04eMBIbDAGmmchQDgsGgq/IQDonwQP CoIq9bBPflMC/HBZtJ5QvjQJNfQENuEfE9i5IeYRajs8jLIorluqjwa/DIPofgFj4iRyfRGX 0GcD/vJNhRz0yiV3Pi6SKhGU/FSwjax9ZdAaLa9+8cxMwmLYtXqDUYjly/+4WqJFR5w+kLVX o7BImivrKwpGGw82qNxX5uIABhAkFc56ild3tLoAQNIn7laLprgaTaRUlimF+8YjNvRcLfFw BS435t/7isEpCWzSc+T/WqL3ydlHlWgH6RVZ8Tlumi6K7eC90FJ6djfJY0ORTAFhRzlwovgn xEchU4SkjWES6rr76kgpwSDOT2bMJ9nw+vHM5RpRvkxAahjPBqYkFecy+lUMaRjwprbSFTnE dN/6gWh6fFpSyiMlIlgOMzMERFbUOeBL4uNnXDWKxk3pTQPC1gR2aDgjKXzzU+YHDj+Ukpim v9FiGMYv3QDl1BundX77by/DpPBxagVnM1Tko/nZx2FGzAtHo26+ONa6ap+0a6a1cJwIgmQX r4SApXBjkr68G81RaTljrHKG4vwY82OPfBSJ45davI53+rIIqUtK0PEvNO5qx5PNT2vuJja5 PYRyalaBfDT8850Q2coXgofBRuoH4/iPXyxVnL6nO70HNXO4ulHH1WA5UgZ/eS4GjvS6zWjN FXjdcpsfCxNWu0QNic0q3TZyNCLBSWgWPedZBdlblk+YYJ8J10FN3ndBGN8ldt9hA3Nt31m0 MTW74T2sGIBqZfO+gpPxtE9V8onumVJEQlsgbKEvYzFGtd+kPzDpes2f70srIhDU2KmRvoNX Se+yNb+e3ZXyHr789sN4sAZUBXYlM78nJs4aercJDREhyjc4h4jRCHG074VL9WU66eH7oM6j 58/tGThueSMw71whrZszc+AqVA9Q+cMI6PKTPJPe5D6NqhP1uQxoOs/c6olT/yDQKBVH5wv/ wNSWUgKuJZijcji4Ur0i+9DozPy3hV7Gd20HVAjV7i2o+v/WHBO1pJWDep26lrYQ== X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40083900" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ScYLY6NOV0sMmIZLRC32IDZwfwqBA35Ci4wSFo9QCYnzIGRSN20ZYM/wtn2ZoLJD3FieCbPisfFrUP6OldfYPYcLdsFgbsueZTL+T6KeQ+wc0pAMx4LYcc+7gFjddsUNk+MwjYrAl7mBoFCU4KQL1ytEFq0bZL6gu+9DoCCEDGqQJr25ggU8k/QcW5/XvLYHi4d28TrwgdRyUHJRoK7YJkbU/gvW2dN8wMiPMwxkWmB6xaiibh1ZWZclp3wJrZm/VABHile4RfwiDY9mUXokT+JH2CWof3+xcBW5ugiu0ZC5zY24rC+2EDW5EToJh+S5lt7opyffd1f+CdummW5igg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3QGBIwDxSIudNwac8EMQLqvFIk1qfsmsE3bo1R2Lodc=; b=BxMpvHKSQAepTclV3JjyW5OIsiuGjl1znWhxZj4PZnnnmiM32wTpd14hQ7UoMLK5tgaqMqu+0Hwx9e1tw1fqxJt7l+NeQMR+Z2lR84wyB1cGZet1oCYoB4yFYz7F9bFPDOJHhI7ReLoAFsgrvy+JHjgN9uD2mjnGwsXB6Zb4JVvUQFO9p0GGdBQtejrEpTRSKljoDy+w8ZvS80sB1duwmadcOqpO/q6DIsiPCKh7zoweirwrYTFTFcLJDEYNrs+OUKEN8asOQPyQQQBdk2N9/HzLapfI0HxqLWLUi+2vjFG0QYgljyW1LeNwTHpA+kp4GEgkeILBuoXGN970Jmbu1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3QGBIwDxSIudNwac8EMQLqvFIk1qfsmsE3bo1R2Lodc=; b=fgYGz6mP+Wcf/Ak1Y6wli34FCa6McHp3OEyz/DP5hZn8AqVZ4Mt61K2LkqQNrp+sX7BaMVmt+iyt5A/vh0AEaZshxr4MewuIw72JKrteFTZ7625oPaD2YLZYDvbZ8sv9v9iqSv45+4oR4NnNiEUmKvOSxnA7cXLUqh9JqJNTo3A= Date: Thu, 25 Mar 2021 10:13:11 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: George Dunlap CC: , Manuel Bouyer , Ian Jackson Subject: Re: [PATCH 4/6] CHANGELOG.md: NetBSD lib/gnttab support Message-ID: References: <20210324164407.302062-1-george.dunlap@citrix.com> <20210324164407.302062-4-george.dunlap@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210324164407.302062-4-george.dunlap@citrix.com> X-ClientProxiedBy: MR2P264CA0076.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::16) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 47566690-ba5e-4a50-fee2-08d8ef6e3ae1 X-MS-TrafficTypeDiagnostic: DM6PR03MB3945: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1060; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BkkkMykju/+ZuRLg4uHsuxr69ZEX1R7aTtRkCfViBGD7MPaVLDSyq+7GElU4/33hE8fkss34F6g8pPVfWL1sfVUU2gqXakD/y34DNBYfUOeBrjSEE7uBFiDHImsEdkNDwhygiA2K9i8bC7iPim921QtgEc0s4k6TPiRJJhvyO1qmaeY5sLsb8eWGKbIW4+glhufXofhpRBqGnsQRM5h3uLYto/p0WKFP11oDzJHOBCsB/HgRAk0ufXNeShG2a8mqf4F6L7QbbHh51SMk8W+4FxPXD8mPyftPA9j/z7h20Y1AyGZm80LqsMNSq6oYiWrYZib7Xj79ofsQuxuC+7w5sOescBTZut9INICKNiUcsIbMCqrtjXrn19JH6Sy0G618kfGjHPXr+rfRNOoTtVJqF0gtC1D9RmXjk9so0qW+1qz5+iDqcERYbZSPdL1SUXBLuNtJVoM2MELqll7utlzEsLHJHJyRmyrWovPEA68wcslWmElhGC4dGczQo/3fwDTJUyMIHZXIGGC9TxLjQIcuh+EVMpsjCOupNbZS3DVDhix0AvY1wqGRqmoeur2eUbZyDVbC/1o8V1YCVN0bS7kZbcjjK1mPKYIe0C4QpXVLhziiHQ++uVAtIlTZuhviFyJypW1p3L3o/4RatQUJMAC6ACX0ddr1uNU/y+8k9tv9JuXJnDo5Xrc5w4hjJ4AwI8B0UGNgYMacpJgzChbCc/OiJBmiMwKlHPQcj3/q6IwNYO5jX6WPmu41miYaAhB099Rn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(376002)(366004)(346002)(136003)(39860400002)(396003)(8676002)(107886003)(66946007)(6862004)(66476007)(66556008)(85182001)(558084003)(6666004)(86362001)(8936002)(4326008)(9686003)(5660300002)(6496006)(2906002)(26005)(316002)(956004)(478600001)(6636002)(16526019)(6486002)(54906003)(38100700001)(186003)(33716001)(59356011)(219803003)(207903002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NXl1ZmlPYkZmYW1RUjh4TUhzTFhBa3FSdVVjRDJEUXR2QzdUcms2ZkZWS1pU?= =?utf-8?B?TllnK0RxR09RbWVpaEVUWWxMZWhacWx0YXZuTXZZWUhrU3h5MVN2RWsvVENy?= =?utf-8?B?V2tpaU9QUG1uazJETDBSS0dvbWxIUHBLUkFEbW80Q3hIWDh0c1RPNzBZUnd5?= =?utf-8?B?TFcxV0FvbnBTZ1VRRkZINStnNzlRTFZOYlVSTTRjWDBqRnRnRExTNjhZY1Za?= =?utf-8?B?L2JMV0xrdm9heVJ1dmczb0R2MUQ4dTJDUytzbVhGNGx6a1d3bTFCNTFxeEJ0?= =?utf-8?B?L2ZzcGRkSTRNMnF2MnVxWjM3QlBUcVQ4OThCNllEQlBWbTVWRXh2TlhWVzhm?= =?utf-8?B?NXlrci9vVkF0dEtvelFEOU42WkRNTFRYSEdVeHpRdnJRZlBwWXphQ0Q3cno0?= =?utf-8?B?VzJVekk3dEVtRncyeXdtOTVXMGZxNlRQTVk2dTJ3Y0NvRTh6MTlNdmFxRU5s?= =?utf-8?B?K1hCcG5iQUtjM1BXa1JySndoK1psNkpuWDFrbVp2Y0RwN1FzNFQ5alZLeURO?= =?utf-8?B?NzB4VDRieEJuOUdMSml6RG5jRkdhYnFDSWZHbnVFL0J5MFU3c1VkNk13dGk0?= =?utf-8?B?YU5Bb0lURW9ibTYwazRnTG81aW1NaGUyUHRraThlUnNXQjVNN01SaDRQNDFN?= =?utf-8?B?THQxNDBiT201Q3FFL1dZaHhFdVQ0T0hXM0diTStFb29vZzgzTkNnbnpQN2pN?= =?utf-8?B?RitGMVpXSXp3Tk84eUwwWEFQc3h3bk5JaCthOEpnTWZnc21HQnhVVVliUERm?= =?utf-8?B?dk1GdDVQYjIyTjdZQUx0SitIcS8wNExWdW8yVmpTbDd2bGNDSExOUGtCMkdG?= =?utf-8?B?bGdYT0J0cms2ZFJ2SHp5L3NLQ0NGNUU5VkJMY01ycThSVjRvU1F6UEtiNU56?= =?utf-8?B?TXhOTExtNzB6dlZzSzFaeUtwYUJkanVCTVBpejBhclNZMFlueW1DMEVPZ01H?= =?utf-8?B?eHVGLzZDK2FLT1JmTlpQSGs5dXUxTkthS0ptcWYrSVdObWVJNU03ejVCTDRv?= =?utf-8?B?QTgvRnByb2FuRzFSK3o5ODQ1S0FKb0NwZ0V6R044UzhOQ05DZWYxODNRc210?= =?utf-8?B?UzJ1elFpUnc5ZUNablFxTk12cVRWalQxNlg0K2VqRnN4d2xnM0diZ09wM1Ja?= =?utf-8?B?SFVha1JyT1BYUGJ2VGVLOXJtU3VmTE9YbXhmWFJ6aUlHa2NVcWhKUTBOUUZn?= =?utf-8?B?dUpveTFWclI3OHVHUnJaWGRBQ3c2eE02N1lKTmo1VDI5OTUzMVE3dkREMzFj?= =?utf-8?B?YVkyM3V4R1E3SUdWNTRHK0N2MXhyRU5HOWVlbVFsbGxScmFadElyL3B3QUU2?= =?utf-8?B?WGVXMXZOVjJjaHJLakZlQ3lRdmNyY05xaGlmZUkvODhZZ3lic3RTUXN2OWk5?= =?utf-8?B?QlF1QU1lanJ6enNtTUdzYnVGVGIyNVgzUFBpanRPQWpnSlkzZDYzU21kNXpD?= =?utf-8?B?WkVjc0NRcUxmMWRlL1oxOGRHVGhRcE9pOXVRUTc4SkszczVvaFBEZXpaTDFU?= =?utf-8?B?YlBjRVNKWEtVNHk2VnVabWIwUkxldkN1TlZPdUpZS0pBUUQraW1yRTQ0WHBN?= =?utf-8?B?Ym1hTW1aZ2dPTUQ5K3BEcTEvQlYzVFJnZzcyVnkwcE9PYXNjaXJkZW9uUUlE?= =?utf-8?B?SnNuRXNJWUNZUnlGUm9JcGNpeHBJVWF5a1FjeHZLTlByNWNYUEVRcUdFU2V1?= =?utf-8?B?TkovQ0RrNGRveFhlTmQzQmYyOW53VEpDWG5RK0tNdVFFbVcwOEZhd0hHQTdr?= =?utf-8?B?czZncHBVQks3UVZjR2hKVDFzeFpwenkyNkhhRHA4bjdsYUlKbVVHVlRNeUVo?= =?utf-8?B?aGM0SHJ2ZDJHQXBXRzBLUT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 47566690-ba5e-4a50-fee2-08d8ef6e3ae1 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 09:13:18.7380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kNyvUGm7wwONoXGjHjtZWYrgxHhnI5hDsMx2imodGLCjnr4epdLn2kA96o27KS6N5xoVAS2CwXF2WdWTSYjwIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3945 X-OriginatorOrg: citrix.com On Wed, Mar 24, 2021 at 04:44:05PM +0000, George Dunlap wrote: > Signed-off-by: George Dunlap LGTM, maybe Manuel has something else to add. Reviewed-by: Roger Pau Monné Thanks. From xen-devel-bounces@lists.xenproject.org Thu Mar 25 09:14:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 09:14:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101335.193739 (Exim 4.92) (envelope-from ) id 1lPM4b-0007Yu-Nc; Thu, 25 Mar 2021 09:14:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101335.193739; Thu, 25 Mar 2021 09:14:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPM4b-0007Yn-KR; Thu, 25 Mar 2021 09:14:37 +0000 Received: by outflank-mailman (input) for mailman id 101335; Thu, 25 Mar 2021 09:14:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPM4a-0007Ye-DZ for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 09:14:36 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 02a5984d-1d48-488a-be75-3f6b3c6ad62c; Thu, 25 Mar 2021 09:14:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02a5984d-1d48-488a-be75-3f6b3c6ad62c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616663675; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=rLIKBBioLf7x5SjjYKKD5IbVaMLdlqwToPEyKUGm9tY=; b=UGKV7qN9mtF93uM9+87g8slrx3AYvdJFsRB69eLsYh7n4obFKyC+Snr5 TjVk2MsCMAE9kzTPRGsMMzQzl/PCFDDSeRm5GCI0UZef2aRsS370cg6Up VzkeSzMTEuvSAUyoZPMQUauoii3iZXEv/8UiA/aSfsZATxKrwKRYw8uK3 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Id0aexlHtZMM0+xLgthiWCuyppnPAtZvBwRrJp09tMcdoJIFHGVtvjTFadSbE9VYS2FTowi4pf spbTxOb4hXmzZUkYhKdVpsfXVYS7NGrsEvAwY2hC/YUZza2zWDkjPauk8i8jyfYliaLkBPyefD ublEf5aawBjFnyl5bKlMKJ/8WS42skC9gD4aJU2kXZQRgQgrwCAgmuGA1HGNUuiU6W7Hq7V97D iwYvromvgunZEx09cs04oHirvkxBWgdi0/Co1YbIc4adfhwUNWTW0PpiD3u7yE2kASKlewOPH0 aRo= X-SBRS: 5.2 X-MesageID: 40103647 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:+BS3Ma/JX2a6RVUcLkpuk+Gjcb1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmyybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIUHD38Zn/+ Nbf6B6YeecMXFTh8z3+RT9Nt4mzsWO/qzAv5ai815GZ2hRGsRdxi1+DRuWFVAzZCQuP+t2KL O34M1bqz28PVEeacqmDncINtKz2+HjvpTgfBIAGlob8wGIlzyl8/rXFBKf0xcYXVp0sPYf2E LClBH04bjmjuGjxnbnpiDuxrl1uP+k8NtMA8SQltMYQw+Dti+EbJlsMofyxQwdj/qo7D8R4b rxijcme/9+8nbAOlyyyCGdoTXI9BYLxzvcxUSDgX3lyPaJBA4SL8Zan4pWfl/4xiMbzalB+Z lG1W6YqJZbZCmo9E+Whrj1fipnmUaurX0pnfR7tQ0lbaIkZKJMtotaxUtJEf47bXjHwbo6G+ pjBty03oczTXqmbmvUtmQq4NugUmVbJGbhfmE+u9eY2zUToXZhz0Fw/r15ol488vsGOvt5zt WBFp4tuKBFT8cQY644LvwGW9GLBmvERg+JGH6OIHz8fZt3eE7lmtrS2vEY9euqcJsHwN8Zg5 LaSm5VsmY0ZgbHFdCO5ptW6RrAKV/NHwjF+4V73dxUq7f8TL3kPWmoU1Y1ifatpP0ZH4n9V+ usPolVR9vuN3HnF4oM/wCWYegWFVAuFOku/vorUVOHpczGbqfwsPbATfrVLL3xVTk+XGfyBW YCQSjzKM1M4lvDYA6+vDHhH1fWPmDv95N5F6bXu8IJzpIWC4FKug8JzVS1j/v7bwFqg+gTRg 9TMbnnmqS0qS2d5mDT9VhkPRJbEwJQ6LXkWHVauB8SPyrPAO8+kuTaXVoX8GqMJxd5Qc+TOh VYvU5L9aW+KIHVwzsjBdKhOmeTlGASu3qOUpcZlsS4lIPYU6J9KqxjdL16FA3NGRAwsx1tsn 1/ZAgNQVKaCinjkry/jJsfBPjWct51hAvDG78NlVvv8WGn4e0/THoSWDCjFfONiQE1XjxOmx la6KkEmoeNnj6pNEoyiOk1K0d3dWySGb5KZT71P7l8q/TOQkVQRX3PrSGGgxszE1CaiHk6ty jEF2moXt3lRnBaoWtV16729kgcTBTiQ2tALlZgsYN8EmzavG1UyuHjXNvv70KYdkYCzuYBMD vMfDsVJUd0y8qq0QOO8QzyZUkO19EgOPfQA68kdKyW0nSxKJeQnaVDBPNM+o15Xeqe/9MjQK aacw+RICiQMZJZ5yWF4nIkMjJzsn8qjLfh3wDk9nGx2BcEcLHvCUUjQ7EQONeH6Wf4A/6OzZ VilNow+e+9KH/4ZNLDyabZaVd4W1nuiH/zS+EjspZPu60u8LN1ApnASDPNkGhdww9WFraDqG oOBKBgpLzRMI5meMIfPypf41oyjdyKaE8mqBb/DOMydUwk5kWrc++h8v7Ns/4iE0eBrAz/NR 2E/ypR8+zMUiGD2bQZYphAaVh+eQw58jBv7emCf4rfBEG2bOlF5kO9KWL4f7lHSqSJcI9g2S pS8pWNhauQeCX50gyL4mc+LaJK7mq9QcS9RAiLAvVF9tSmOVKKxqumifTD+QvfWH++cQAfg4 YAaEkbKsJEgTMmhJcs0iezRrfsy3hV2md28HVijBr1xoOi4G3HBklIPg3Sn4VOUVBoQwq1pN WA9fLdyW/07zdE04TSDUtcftlBHN4LU4j8Rh0eXfQ4rfqv5KoggiNKfRcoASo9kVnGrpBb4Y s= X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40103647" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gpVE1/2GThA4i8YIqzK56AiYweBoL5x6f0E3Sal3UZ58EAKjjaq8dpd7qreVnMuzUjhMp7Z9jlhauor3pQkHwPVgMynCw12zjjrRMw0C0FwMjFw/GXj7cs66raDNoMPCe/wXM2047gPvrU/5YJCF8HWAMtbi2y3NZqvyhzTZ0lSYQ6ukPRIm0aht8p9r10c33BSwtvDKGgR2P9HVYCDCt5IT3piLFq0lQnKmPNdJhKWVKrdchYp0mMomafojQ3ZBTSRtdB2rk7V/GRHyyqMECVMf36e+z3w3DJyBPwo2Wn14VqF9CmXSuZNel9oxoieKp8PuUtxEp/kINIeuKQim1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rLIKBBioLf7x5SjjYKKD5IbVaMLdlqwToPEyKUGm9tY=; b=KeXNvpKWYESHQMQjF7+mr1CR6j2GhJWdRBTmJE94Jq6lAmA9EtOKWEJmg249fxTSKReI3IGj/5o20yRFSOxKhHYjQLJ2j1MJhoB2GIaOms8Mn2zVX81jg6H2TpD/BxZSAlc4Cfwa72z+pVaShJ+3aeZkTjGuFVw0UpNxpdG37bR635KkAiso6h6zGqwvq9ZG6eiqgGaQ2VI0E/YFqQrW85M5w5p2Nzu5QV1+H50HZANtAFiAr2UAgiwtZThcFSy3qiLnNMPBTTbxDuiA+UljpULGwuT/NLxjswFcL5KoIUNxTLWi+dODO6dxPcKiy+jZWatt8IA3/R5yw3ACHLHxNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rLIKBBioLf7x5SjjYKKD5IbVaMLdlqwToPEyKUGm9tY=; b=GpstlmSkkds65oaU8hM8vQFX29/ygl9uOeGNTLelvgLnTu7CI21bpOyJcdCmppez2MOf8Pu2odPszOO1bxrw1WRcYTAcKEQMp5O2ochtkKubpzfw9Sg4teBz6EK9gYS/ajKa0HEi3NBPY2vj8+eTrr78s2zaDLAKp6TT03lB7wE= From: George Dunlap To: Roger Pau Monne CC: Christopher Clark , "Daniel P. Smith" , xen-devel , Andrew Cooper , Stefano Stabellini , Julien Grall , "Julien Grall" , Ian Jackson , Wei Liu , Jan Beulich , Rich Persaud , Bertrand Marquis , "luca.fancellu@arm.com" , "paul@xen.org" , Adam Schwalm Subject: Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document Thread-Topic: [PATCH 1/2] docs/designs/launch: hyperlaunch design document Thread-Index: AQHXGhIm6lUem5Agw0SwTR0/wys6MqqJ94wAgAfrX4CAAPCuAIAAUZ8AgAFJWYCAAAvQAA== Date: Thu, 25 Mar 2021 09:14:31 +0000 Message-ID: References: <20210316031814.10311-1-dpsmith@apertussolutions.com> <20210316031814.10311-2-dpsmith@apertussolutions.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fec5ee5e-5712-4d65-fdbc-08d8ef6e665e x-ms-traffictypediagnostic: PH0PR03MB5800: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: o/kMpV0ea1iopjP1y4tp8yDUWHGv7p8g2zH/5O/sU7g4e4ka9tLJr5NO0J+5i6qYk6IZZ2RQv51ytDZbSLcFvWHJBb31xGfhMVI1T6svEL/3oriPh5RcbBRPT1YpuOXJxjRSbnXFsLC5RHmfQl7Qh7QzNKypDpLQcnHFXqdKaDKApieFmvbCjNzhUEE1ddSe5VPxZeFtrQO3r7bjkiLAY31mFbaGsZ1amgK8CHFhvwqlyQgS4k7V0WV1JkGBqNKyYlskSF9GTpB03diZIn0hgktd6iWKA69uEIbvs0weKaZGH/AplGxfJlE80RanaAZ5QrR9Qwju5FwSedm6UMvMMaJjKs0vs1eY8Mge1Na+vrR/aA+pLwOlo99Q9RkAHp8Rh4haXXCXnUiNKH4iRsQv2OQIk7RcJHzpHmGV3ojFZYlxjLF2wUTp3MXWwe3YQrHAP/K+FXklhKspMIBb5n44ijia9L9fQN+IO1qV8mxWyACIRVAhINUTLZeAhAXSd5wz266qoX9LigTRUllfCdM2Wyk4n6SBgMf3/w/xGM3I57ZN1cOeu8YpY63mJJktOf5NWqL1h8/JDHNJlalMVuKIjC70YSSvB7MqXloWQBXqBqJoGHJGMhaNnrdWxcBddbLyWHpYxjGGJw7nnqwOt5eXYHBfcccR18EcQROpGq4gcSfoxNXj0TxU6ulqWPWWel0E x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(396003)(346002)(39860400002)(376002)(6636002)(36756003)(38100700001)(316002)(91956017)(66946007)(66476007)(33656002)(76116006)(86362001)(66446008)(66556008)(64756008)(5660300002)(6486002)(6512007)(54906003)(2616005)(37006003)(2906002)(6862004)(4326008)(8676002)(6506007)(71200400001)(7416002)(53546011)(186003)(8936002)(26005)(478600001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?YjZ6N2VMdzdZbGhKaHkzOU02cEdZbTdnTnJIbjlkMHVIUFg3dzJyaHJTcnNp?= =?utf-8?B?T1lJTEFRclBoMWRMbGZzNmI4akxvay9NL3BZaVNIZGlkUmwxR0JrU214Nlpr?= =?utf-8?B?K2RjTFdKc05rVEM5emxTZXprWVRZTVlsaVZwQnJhQTE3elVzbkNCK0sxYTF4?= =?utf-8?B?UExZbFVMc3FLbC9CNXBwMnhuTlpvU25xbStxa1c0a292c1VDQ1NDc2lDNjBo?= =?utf-8?B?a1FHNm9VSS80MElOZ0NZUERQaXpuTjhSd1Q3bXRxQjZPM0d5UFdoSTJEd25t?= =?utf-8?B?V1FydmprakxDVXA0ZTV4M1M4TE02YWxxVGdPVUJraERzSzN2VnR6SWNaL1NN?= =?utf-8?B?eVlWVkFoTzhCMDNqNUVtdmdWVUttSXNnQzhYQmNOWkwvNWxGTEJLdUtQUkEz?= =?utf-8?B?Y2hmVWpTdDFneThmQm5lOFdKM2hBaHlscUg2Y1R6ejRiNnI1ajJPNlFjbTlC?= =?utf-8?B?Qi8zK3dFVU9Ob010NTJrU2NQc1Y5YStsdGZqUVdIUVpyZ0FDWGp6S2dXNWJU?= =?utf-8?B?QVlUcVdKYStGT0ZTaXMvTXd6MW5NakdORzBPYWZUdCtVTGgwVXBCSG8xM1NP?= =?utf-8?B?OUgyeFVia3FWZGZvYjIxdTR0eWNpN3VjeHlMREwvbVdWTkxHeElLU203eGFs?= =?utf-8?B?WVgwdHUzZVR2NVByUy81U0t3T0tXT2cyRllFMVpxdmNMSC8zcVBxTGYrT2ov?= =?utf-8?B?bWVockl4VnRtVVM2NXAxVGg3TmFhWms4TkF3UzJsK1pYZitQbGRlVjk2WEFp?= =?utf-8?B?MllGSFYzbkVLeTljSXF6MzFvaGpLYXl5K2lxNFdpdUNJOEY3RGdrUHZLQWpx?= =?utf-8?B?UjVmaUczVDArUGNLSnJZUzY0ek54NVlqSGRacmxjWUVKMFF1OS9MRTJCUXhk?= =?utf-8?B?ZGhtc09CbXl6dWFlamplTERucW5IeURHVG5QMzJsSmt1LzNzYTBTOUVXWXFt?= =?utf-8?B?cjZOY1J5bXZObjBzWHhYS040QjViUVNVdDNDQVg3MERkL3h0NklYQ0FFNGly?= =?utf-8?B?YjhoUnoyZmxzMnJOVXI0OUt0K3phMVphRk1HVUpMaDhDejlmT2ppdWlQMThN?= =?utf-8?B?bzRnQTRLNDNIbEtYWWE4aEljaEZTV0N1UjJ5OWhaN1o4M3Qyb0oxRkJ0UnN5?= =?utf-8?B?UUFLUC9IejZwVVdxZnF1QTRCWVlVMWRadGp4MFA4MzhSRHFoMXpVU3RZaFow?= =?utf-8?B?NW53dW5zR25Fc3ZqcVlZZzZaclljT2lQbVF4NjRDTVkyZC9TZEEyQnFaNEd4?= =?utf-8?B?Y0RYSjdJbEZpaVlGcUUzaE1LN3J3dVVzcXJQMjA5RVhuaVdMN05nM3FEZDBj?= =?utf-8?B?SEhQdjBwcGtjd1VCR25LaWEyekUvK2ZHOGFhZDExRW1TYmt2VC9iUk5xcndR?= =?utf-8?B?NWxRSmQ4ZVpzajQvd0ZOTWFnYnNqQkdQM2hpMVJvbjhCekxYalRZSysvSmpE?= =?utf-8?B?MXplcUtzNXJ4UWxDZ08ra0lIYm9ZME4yblBQakRWQi9ic0hzZVpsMDJlcTNP?= =?utf-8?B?K1VFL1BSSW9DenIwSVU0dFF6cHR0QVBYUjNmWnF5REMrNzBKTXdZR0hBSjRX?= =?utf-8?B?TmNWdWYrQlNzTHBlZTVRZEdDUCtReUtnNk4wQlVQMWVEb2NpdC9WSXp1T01a?= =?utf-8?B?UUxIbjVRUVg2MGhpMklaSG1Gcld2M2JBRTRSb3drQ0hNZENITWcvNzlJcXBs?= =?utf-8?B?REFVSlpRSkZjZUN4VXZVNHBHQTI4WmgxNlVYVzFlNHhOUmxRSWdCUmZMT0JT?= =?utf-8?B?b0lYdm54YnJERGxJMG5PQ2dDajZTYWtWbm1PQ2lPWE1iMXRwcFEyNEZuYWZ2?= =?utf-8?B?c0IrOFFBVTZqM3hzT2w5QT09?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fec5ee5e-5712-4d65-fdbc-08d8ef6e665e X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2021 09:14:31.4384 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RF8Cz/5l0E5GilduqoSr6eS30b93srWoye5U6VPt5tQNH630EEiROgASA0yOwer8wnybTnaQ+Zc4620LUtwmOFOyhoBtUVq9sxVNYRaaO8g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5800 X-OriginatorOrg: citrix.com DQoNCj4gT24gTWFyIDI1LCAyMDIxLCBhdCA4OjMyIEFNLCBSb2dlciBQYXUgTW9ubmUgPHJvZ2Vy LnBhdUBjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IE9uIFdlZCwgTWFyIDI0LCAyMDIxIGF0IDA1 OjUzOjI2QU0gLTA3MDAsIENocmlzdG9waGVyIENsYXJrIHdyb3RlOg0KPj4gT24gV2VkLCBNYXIg MjQsIDIwMjEgYXQgMTowMSBBTSBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNv bT4gd3JvdGU6DQo+Pj4gDQo+Pj4gT24gVHVlLCBNYXIgMjMsIDIwMjEgYXQgMTA6Mzk6NTNBTSAt MDcwMCwgQ2hyaXN0b3BoZXIgQ2xhcmsgd3JvdGU6DQo+Pj4+IE9uIFRodSwgTWFyIDE4LCAyMDIx IGF0IDk6NDMgQU0gUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdyb3Rl Og0KPj4+IElmIHlvdSBvZmZsb2FkIGRvbWFpbiBjcmVhdGlvbiBvZiBndWVzdHMgd2l0aA0KPj4+ IHBjaS1wYXNzdGhyb3VnaCBkZXZpY2VzIHRvIGEgY29udHJvbCBkb21haW4gYW5kL29yIGhhcmR3 YXJlIGRvbWFpbiwNCj4+PiBJJ20gbm90IHN1cmUgSSBzZWUgdGhlIGRpZmZlcmVuY2UgZnJvbSBu b3JtYWwgZG9tYWluIGNyZWF0aW9uLCBpZToNCj4+PiBpdCdzIG5vIGxvbmdlciBzb21ldGhpbmcg c3BlY2lmaWMgdG8gaHlwZXJsYXVuY2gsIGFzIEkgY291bGQgYWNoaWV2ZQ0KPj4+IHRoZSBzYW1l IGJ5IHVzaW5nIHRoZSBleGlzdGluZyB4ZW5kb21haW5zIGluaXQgc2NyaXB0Lg0KPj4gDQo+PiBT byB0aGF0J3Mgbm90IHdoYXQgd2UndmUgcHJvcG9zZWQsIGFuZCBob3BlZnVsbHkgbm90IHdoYXQg d2UnbGwgbmVlZCB0byBkby4NCj4+IA0KPj4gRG8geW91IGtub3cgaWYgdGhlcmUgaXMgYSBuZWVk IHRvIHBlcmZvcm0gd29yayB0byBzdXBwb3J0IHRoZQ0KPj4gYXNzaWdubWVudCBvZiBQQ0kgZGV2 aWNlcyBhdCB0aGUgcG9pbnQgb2YgZG9tYWluIGNyZWF0aW9uIChpZS4gaW4NCj4+IGRvbWFpbl9j cmVhdGUpLCByYXRoZXIgdGhhbiBoYW5kbGluZyBpdCBpbiBhIGxhdGVyIHN0ZXAgb2YgZG9tYWlu DQo+PiBjb25maWd1cmF0aW9uLCBwcmlvciB0byB0aGUgZG9tYWluIGJlaW5nIHN0YXJ0ZWQ/DQo+ IA0KPiBTbyB3aGlsZSBJIHRoaW5rIHlvdSBjb3VsZCBpbmRlZWQgY3JlYXRlIGEgZG9tYWluIGZy b20gdGhlIGh5cGVydmlzb3INCj4gaW4gYSBwYXVzZWQgc3RhdGUgYW5kIGF0dGFjaCB0aGUgcGNp IGRldmljZXMgbGF0ZXIgZnJvbSBhDQo+IGNvbnRyb2wvaGFyZHdhcmUgZG9tYWluLCBJIGRvbid0 IHNlZSBtdWNoIGJlbmVmaXQgaW4gZG9pbmcgaXQuIElmIHlvdQ0KPiBuZWVkIHRvIGVuZCB1cCB3 YWl0aW5nIGZvciBhIGNvbnRyb2wvaGFyZHdhcmUgZG9tYWluIHRvIGF0dGFjaCB0aGUNCj4gZGV2 aWNlcyBhbmQgdW5wYXVzZSB5b3UgbWlnaHQgYXMgd2VsbCBkbyB0aGUgd2hvbGUgZG9tYWluIGNy ZWF0aW9uDQo+IGZyb20gc3VjaCBjb250cm9sL2hhcmR3YXJlIGRvbWFpbi4NCg0KTXkgdW5kZXJz dGFuZGluZyB3YXMgdGhhdCBvbmUgb2YgdGhlIHByaW1hcnkgYWR2YW50YWdlcyBvZiBkb21CIHdh cyB0aGF0IHlvdSBjb3VsZCBjb21waWxlIGFuZCBydW4gYXJiaXRyYXJ5IGNvZGUgaW4gd2hhdGV2 ZXIgbGFuZ3VhZ2UgeW91IHdhbnRlZCB0bywgdXNpbmcgYWxyZWFkeSBrbm93biB0b29scy4gIElm ICphbGwqIHdlIHdhbnQgdG8gZG8gaXMgdG8gYXNzaWduIHNvbWUgcHJlLWRlZmluZWQgc3BlY2lm aWMgQkRGcyB0byBzcGVjaWZpYyBkb21haW5zLCB0aGVuIHN1cmUsIHdlIGNvdWxkIGFkZCB0aGF0 IGNhcGFiaWxpdHkgdG8gWGVuLiAgQnV0IHN1cHBvc2UgeW91IHdhbnRlZCB0byBoYXZlIHRoZSBm bGV4aWJpbGl0eSB0byBoYW5kbGUgY2hhbmdlcyBpbiBoYXJkd2FyZSBhdCBib290IHRpbWU/ICDi gJxTY2FuIHRocm91Z2ggdGhlIFBDSSBidXMgYW5kIGFzc2lnbiBhbnl0aGluZyB0aGF0IGxvb2tz IGxpa2UgYSBuZXR3b3JrIGNhcmQgdG8gZG9tTmV0LCBhbmQgYW55dGhpbmcgdGhhdCBsb29rcyBs aWtlIGEgVVNCIGNvbnRyb2xsZXIgdG8gZG9tVVNC4oCdIGlzIHNvbWV0aGluZyB5b3UgY291bGQg ZWFzaWx5IGRvIGluIGRvbUIsIGJ1dCB3b3VsZCBiZSB3YXkgdG9vIGNvbXBsaWNhdGVkIHRvIGFk ZCB0byBYZW4uDQoNCiAtR2VvcmdlDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Mar 25 09:16:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 09:16:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101338.193752 (Exim 4.92) (envelope-from ) id 1lPM6k-0007h8-57; Thu, 25 Mar 2021 09:16:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101338.193752; Thu, 25 Mar 2021 09:16:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPM6k-0007h1-1u; Thu, 25 Mar 2021 09:16:50 +0000 Received: by outflank-mailman (input) for mailman id 101338; Thu, 25 Mar 2021 09:16:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPM6i-0007gw-NQ for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 09:16:49 +0000 Received: from mail-oi1-x233.google.com (unknown [2607:f8b0:4864:20::233]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d63cdfe5-05d0-4860-acd6-30860c1277a9; Thu, 25 Mar 2021 09:16:47 +0000 (UTC) Received: by mail-oi1-x233.google.com with SMTP id x207so1463195oif.1 for ; Thu, 25 Mar 2021 02:16:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d63cdfe5-05d0-4860-acd6-30860c1277a9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WXOKWywYABw9gNC/Cfe6LcUrbMnuPsaMy+ZmXW6+jwk=; b=VS0a8U0oOPLleG0c1Q1cJZCd6WJNc/wWetmbvouXkWTxkiwqSGZAbHnfyNDbPbXQAz jIQtk4leA6dx9wSun9/f0ZbtMH3ncHZ5EQJ3dw552SkTe6WXmaEoJWQR6G+eIsfOx4TS Qj00SO7qND7yhQto43yY/IJkGAudEz33CQXuQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WXOKWywYABw9gNC/Cfe6LcUrbMnuPsaMy+ZmXW6+jwk=; b=kPbIc9OrRrx2ooDKKnoqD9n8ISZAZkcsK9aApwkXrpCg2ZZO/v8VyFjZOaQFssaK7r 724piCefpoTAOis8KCvmNAB6qo8Md6hfkeDDmRljVHyY7uROxLJHScnn4T/iJ1JsTGHP V7sLaa14AClrO+a1axqck9ohcAqsU673JxKU4PybRrmoop95wgYUaH9j6gSgPGkmJ/J3 WX5x66Vz5N0Eebiv8vFlMGWd25Ds9E0Df8l2thdPfwOIX50vJ8Yne4SGOgB0XoSKSv2O Df1H9tMQoKhyEChYzjtvRLdUOM21jtW6gswwT4Bye+AV6pe0Rq9NebgQ+kdmBwZxgSWY girA== X-Gm-Message-State: AOAM5319ht0xWH+arSEaqZtq58GFyxyBBCLWJQ9U1yEX7qvZMe1Iw3ce BC+7XsPo8i3iEbGGZTKi2ZrQ2WwM0J4tz2v3vrS5Sw== X-Google-Smtp-Source: ABdhPJytsJjbKqMJCBkhVZVEz6znKYYwTbAL/6ddw6ajhG9nL40C06B20SHXzBy9ZL4KSWKD22wiqaFfQ7AsZO8Z0Es= X-Received: by 2002:aca:4188:: with SMTP id o130mr5286825oia.101.1616663806913; Thu, 25 Mar 2021 02:16:46 -0700 (PDT) MIME-Version: 1.0 References: <20210325061901.851273-1-wanjiabing@vivo.com> In-Reply-To: From: Daniel Vetter Date: Thu, 25 Mar 2021 10:16:35 +0100 Message-ID: Subject: Re: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice To: Oleksandr Andrushchenko , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: Wan Jiabing , David Airlie , "dri-devel@lists.freedesktop.org" , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , "kael_w@yeah.net" Content-Type: text/plain; charset="UTF-8" On Thu, Mar 25, 2021 at 7:53 AM Oleksandr Andrushchenko wrote: > > Hi, > > On 3/25/21 8:19 AM, Wan Jiabing wrote: > > struct xen_drm_front_drm_info has been declared. > > Remove the duplicate. > > > > Signed-off-by: Wan Jiabing > > Thank you for the patch, > > Reviewed-by: Oleksandr Andrushchenko > > Will apply to drm-misc-next-fixes drm-misc-next-fixes is the wrong tree, bugfixes outside of the merge window belong into drm-misc-fixes. Please consult https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.html#where-do-i-apply-my-patch We need to hard-reset drm-misc-next-fixes back, please re-apply the patches (both of them) to drm-misc-fixes. Also adding drm-misc maintainers. -Daniel > > Thank you, > > Oleksandr > > > --- > > drivers/gpu/drm/xen/xen_drm_front_conn.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/xen/xen_drm_front_conn.h b/drivers/gpu/drm/xen/xen_drm_front_conn.h > > index 3adacba9a23b..e5f4314899ee 100644 > > --- a/drivers/gpu/drm/xen/xen_drm_front_conn.h > > +++ b/drivers/gpu/drm/xen/xen_drm_front_conn.h > > @@ -16,7 +16,6 @@ > > struct drm_connector; > > struct xen_drm_front_drm_info; > > > > -struct xen_drm_front_drm_info; > > > > int xen_drm_front_conn_init(struct xen_drm_front_drm_info *drm_info, > > struct drm_connector *connector); -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From xen-devel-bounces@lists.xenproject.org Thu Mar 25 09:19:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 09:19:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101345.193764 (Exim 4.92) (envelope-from ) id 1lPM8v-00081f-LU; Thu, 25 Mar 2021 09:19:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101345.193764; Thu, 25 Mar 2021 09:19:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPM8v-00081Y-IN; Thu, 25 Mar 2021 09:19:05 +0000 Received: by outflank-mailman (input) for mailman id 101345; Thu, 25 Mar 2021 09:19:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPM8u-00081T-1h for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 09:19:04 +0000 Received: from mail-ot1-x32c.google.com (unknown [2607:f8b0:4864:20::32c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 87f3a48a-baa9-490b-98d6-41d575b13615; Thu, 25 Mar 2021 09:19:02 +0000 (UTC) Received: by mail-ot1-x32c.google.com with SMTP id k14-20020a9d7dce0000b02901b866632f29so1322298otn.1 for ; Thu, 25 Mar 2021 02:19:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87f3a48a-baa9-490b-98d6-41d575b13615 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s8gaLzfKO51sv2EAdyYwOBAav4JswI+vzWWUFTJdNYY=; b=ZkxfOIKsj2q9i0xgCpJIWPTGgfJnpexFD69S2YCMtm7qz9+Vz3iFYeeL/zq8cW43eJ ZxJ0JznpvlRjP0MCLr3dVA6OrS5dUJtNyIVuvegpRL22m1fimwU5A2IkRinyZfD/MOg9 pdBoeBEUs7bsM2BitRB3evCfcTP2TuuWcIMoc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s8gaLzfKO51sv2EAdyYwOBAav4JswI+vzWWUFTJdNYY=; b=qyPYfSrPT/TtVrV3O5a+Xc/amrIWVR3rerZnrRO8ZGeW0zUVT+SZL+RBLstnMjdkDm GlHrVwQyZ00tz1KcVhN4PF7vPr67pefWBrmZLsNNYdRiMr882eSM5GFvStRIebKklKcb yAoGxU7t6pTdOAVR+2d1LJndPq/IT6yRB8G9f12J9bem/pRSnF2/VbVUFAap5YmzB1Lg /0AvIEEvNBfQsqwtDVc7Zna7epeJQrHuDckpkIAaLv7vwirJpY2h3vsbCcrkfnTFsZNn xElZMskdrYhkC6JtWNvqnp/UJkd9WbMNjyRMW4reDqRJkAPG5LIpIlNsmr0BknQke0N/ NJWw== X-Gm-Message-State: AOAM532ieHjNwwncZsiLFIPK5/1GxpVKhohVtO4dML1W6meJeDAlv7wT YT48Q5WLNNvlz7pnaQacoRtIFKcQUzrKUj9hTrcLgw== X-Google-Smtp-Source: ABdhPJwuRBoHhQ1X/QBIV1XedaouhUZsXyPMY5vgD/AZosvW57FTBULFoCWN1cliFURZtu4WwmxByGgjBHWXJVPUY/M= X-Received: by 2002:a9d:845:: with SMTP id 63mr4608787oty.303.1616663942428; Thu, 25 Mar 2021 02:19:02 -0700 (PDT) MIME-Version: 1.0 References: <20210325061901.851273-1-wanjiabing@vivo.com> In-Reply-To: From: Daniel Vetter Date: Thu, 25 Mar 2021 10:18:51 +0100 Message-ID: Subject: Re: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice To: Oleksandr Andrushchenko , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: Wan Jiabing , David Airlie , "dri-devel@lists.freedesktop.org" , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , "kael_w@yeah.net" Content-Type: text/plain; charset="UTF-8" On Thu, Mar 25, 2021 at 10:16 AM Daniel Vetter wrote: > > On Thu, Mar 25, 2021 at 7:53 AM Oleksandr Andrushchenko > wrote: > > > > Hi, > > > > On 3/25/21 8:19 AM, Wan Jiabing wrote: > > > struct xen_drm_front_drm_info has been declared. > > > Remove the duplicate. > > > > > > Signed-off-by: Wan Jiabing > > > > Thank you for the patch, > > > > Reviewed-by: Oleksandr Andrushchenko > > > > Will apply to drm-misc-next-fixes > > drm-misc-next-fixes is the wrong tree, bugfixes outside of the merge > window belong into drm-misc-fixes. Please consult > > https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.html#where-do-i-apply-my-patch > > We need to hard-reset drm-misc-next-fixes back, please re-apply the > patches (both of them) to drm-misc-fixes. Also adding drm-misc > maintainers. Also simple cleanup like this should be pushed to drm-misc-next, not any of the -fixes branches. -Daniel > -Daniel > > > > > Thank you, > > > > Oleksandr > > > > > --- > > > drivers/gpu/drm/xen/xen_drm_front_conn.h | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/xen/xen_drm_front_conn.h b/drivers/gpu/drm/xen/xen_drm_front_conn.h > > > index 3adacba9a23b..e5f4314899ee 100644 > > > --- a/drivers/gpu/drm/xen/xen_drm_front_conn.h > > > +++ b/drivers/gpu/drm/xen/xen_drm_front_conn.h > > > @@ -16,7 +16,6 @@ > > > struct drm_connector; > > > struct xen_drm_front_drm_info; > > > > > > -struct xen_drm_front_drm_info; > > > > > > int xen_drm_front_conn_init(struct xen_drm_front_drm_info *drm_info, > > > struct drm_connector *connector); > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From xen-devel-bounces@lists.xenproject.org Thu Mar 25 09:28:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 09:28:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101348.193776 (Exim 4.92) (envelope-from ) id 1lPMIF-0000jr-J9; Thu, 25 Mar 2021 09:28:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101348.193776; Thu, 25 Mar 2021 09:28:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPMIF-0000jj-Fq; Thu, 25 Mar 2021 09:28:43 +0000 Received: by outflank-mailman (input) for mailman id 101348; Thu, 25 Mar 2021 09:28:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPMID-0000je-EW for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 09:28:41 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3f3bd140-c810-4168-ab2d-83fd8b1c7e1f; Thu, 25 Mar 2021 09:28:40 +0000 (UTC) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12P9NQEx018346; Thu, 25 Mar 2021 09:28:35 GMT Received: from eur01-he1-obe.outbound.protection.outlook.com (mail-he1eur01lp2055.outbound.protection.outlook.com [104.47.0.55]) by mx0b-0039f301.pphosted.com with ESMTP id 37gquh00e9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Mar 2021 09:28:35 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17) by AM0PR03MB6242.eurprd03.prod.outlook.com (2603:10a6:20b:15c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.26; Thu, 25 Mar 2021 09:28:30 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::3541:4069:60ca:de3d]) by AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::3541:4069:60ca:de3d%7]) with mapi id 15.20.3977.025; Thu, 25 Mar 2021 09:28:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f3bd140-c810-4168-ab2d-83fd8b1c7e1f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UaRcxmFgj/cXrRnW8/NXrsWF+Zv5JBwy/LwCT4HMwdDsuHVmI7/E+oYpQVTnfwzRuVgpLuxwzZZc0B5vCQtLozXN38/AVvqcmBGbd7ezFcTo7zCLI085D3zS4FKTbUrytN023L1zSTrg/r14a05EtwGxEEXF+7mUbLeeBOdFA5rwFSCTPqCjWQFokc7EPN591pUbcwVDGOMrHrHqI8syBTsoR8asR0dK9lHgbHHzRWXmmjnz+Kq3Lqbu/5nPwfXQOPPnx0ah+Raa96M9KF2QeHxvKZU5hKf7CUeL79OjECOu6eiZKNqNPPyZk7XvOVqCDoDG+Fia665Us3lsaiUfNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IYoz0eaZeMRr/a30xcAnxfAG7E9hg9U1TCQQ+Vp8ZLs=; b=TCvgBRD21o1awWFfbRbcR34YRiOf451OQe04B5rlRKwUUvFutka6IHBXqIHXayuFCUqGR6LWjQk0k/d7tBnRLivFm4jiRr+ePeZ3Gyczve5BkbES4ZSp2FlTQFWZXP82nw6L2xWt6ph65zdGZnV1Hj/fRF3UNR8T1RvgjPN1Pz7b3VGF0ZwVvudPWqizCurZvMYE7AnJU/jDTXHO0SULAIZtAJL4tE7if3Ip5390WqED4GifjWD2oxTI7BiDU1sZF3KoO6Ehx+bpqma6YFtsbN4SJHMbKbYHgHwCQ98VudLL2P+re+AZeM8VjF+Xwve7o3rwhPzsxYVHXa2I6voy3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IYoz0eaZeMRr/a30xcAnxfAG7E9hg9U1TCQQ+Vp8ZLs=; b=IbBwQ578eIEfvNcFNsG14wrg+NQrXh4lcGKmjuhGJNHKzyA+Bybe76Qo+BotO6R07FBKMO/s9pTuaV329lQPknf3Os0/J3S50/GgcOzcrf/p2FOGRj7pA57KEM2z5kTC+9uutt5EJ2v8O4YhnMU67Na7XuZr4DD6tnNUcKYx57ztXzO8ZRG2k6gpSDFl3RLqDJORdyducO/wSDKTS7hZdzKZuPLfJV/14maPM2AuAaesgh0LMf6w0ijaQG7EH7G6Lx4502qM4KRcHA9J/m13DyqB5rYes/AcHeiWaUvh4b//DDABL+G0+wGuobniG0JIRQNjQXyhXRzy8BlaeLVTxA== From: Oleksandr Andrushchenko To: Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann CC: Wan Jiabing , David Airlie , "dri-devel@lists.freedesktop.org" , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , "kael_w@yeah.net" Subject: Re: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice Thread-Topic: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice Thread-Index: AQHXIT8BvTrvCJoLoEahz8MTVepQQaqURIKAgAAoGoCAAANUgA== Date: Thu, 25 Mar 2021 09:28:29 +0000 Message-ID: <4f1747c4-6578-4962-f51d-6d3827d0034d@epam.com> References: <20210325061901.851273-1-wanjiabing@vivo.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: ffwll.ch; dkim=none (message not signed) header.d=none;ffwll.ch; dmarc=none action=none header.from=epam.com; x-originating-ip: [185.199.97.5] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b2863edb-7a33-45ec-e46a-08d8ef705a31 x-ms-traffictypediagnostic: AM0PR03MB6242: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MRU+qsgURxdNHl1ibgUaqwdbS1DLJ6axIEaqTlgpBt7Q7fNRUUfitz4MIlLXLd7UL9Iu4+UIitrbV6Y+LVbRzAvMFvv0ekplVxeunDnMQst6MJYZXh347UBwmVQbnWpR6epsEQpEmjZ5rkz9NjoZn+UpGGu5VhjHdEaEUjS1Rxngfzi0aprklW2eCzs0LQyL408icMni9WukImqm6KMJgmsbXnQvlGGJXoW3GZ0Yl6ROnkhhiALskkMyviPNWI6i8u59fJF9B9arHT+ewA5Pv5hSX5S8CfZtZU//iV1A2zrWsw/zps5P3Fvn+KdJzVR7Xf9pKoiVQ/OqsdVn5VBTNsDe38CiPS+TRfDP/p6Ouzq+bIK1caHC8qo07aBdqFOvSu46WiLwCDx7pvoWSrUFELegtpW3eJK8YGjtkSbL4a9WI0xv5NxK710obgw0dUW5P1E+Kn1U7uqvhym5EBlVEK8q11WmlGz5cs9lnHKMxgOA34Pj8tPGA7MddMg89l1GgWyLyFLORW5NFH08FzDhcBjQchi1wZIf80CkrrTPTFkaGDSykWoFlqxvyVeYgAtrfmyPdp0ZwqsqZAVaWkcS4uouvL5Zfn91uKq5PBsnCbIy5kRkamjXYZ82uYIhB73Q8cEb2v2y1rSM5arjDDBoT02FHS94tNgq8EZ6F4fY9tic3c4eQxgLLJh8XHyyWMdC+Adst6+72CNEDI4aTLXu7wmrLnyZXiMG78n9ObPXURo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(136003)(39860400002)(366004)(396003)(2616005)(6486002)(966005)(8676002)(316002)(6506007)(8936002)(4326008)(31686004)(36756003)(71200400001)(478600001)(53546011)(38100700001)(64756008)(83380400001)(66476007)(66446008)(66556008)(31696002)(76116006)(66946007)(5660300002)(6512007)(26005)(7416002)(110136005)(186003)(86362001)(2906002)(54906003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?YXJWb2JsanFHMUMyelJ6OWJaVm5UTy90VUpVU0Q4N0hJb1JBL0tDeTBYZW5Y?= =?utf-8?B?NDl2VW1iMG9xMEdzV0JKRUszWG1jSjc4ck0yTmdRVlhJY2w4N2svMjJMeDRy?= =?utf-8?B?R2V0QjR4QXB0b00ybUFTczZURWpGRG5aOEtMb09YY0xoSzVhN2Vpd0JiU3hr?= =?utf-8?B?a3hEQWRwbzl2ZGltaS9MSGhvWFNsei9YMFNoME0yVnFxYWF3K2hkTU5saGx1?= =?utf-8?B?bDBycUlmSDdYQVBpUDd6dU14MWlacjdQcmplWGQyd3pOSHlXU251QVMyTnF0?= =?utf-8?B?T09Ha0FwUmpXTkd6Vmlmb0QvNDQwcU80anBIVkRrNDdodU1CUUQ1RTcrOFJ3?= =?utf-8?B?SVVVUUwyNlExYW50ak9QZFRFa0Y5OUYxR2o5azJVbmRGYnp5b0s2TkZUNkFI?= =?utf-8?B?a1o2ZWNxWDVNcjJIcGxEU2ZHdWUrc0UxbHBIeEtoUXJpQlhib2hwRWwyWXZS?= =?utf-8?B?d0VGdnNhWWhHb3NIVHk3Y2d1MEt2NkZlYVNGVXV1dXlDN2NxVUc1dCtXTExB?= =?utf-8?B?OExPMHl0eGkrSE5NWENWMWVUdnJuUVk0aGVFL0hoa0d0cHhtOGJzalEvK2xw?= =?utf-8?B?ZEovSSs2STdjNmgvV3FSeVVIazhSVWdHWVN3UDlwaTdFVHdjTFJ0R0h5aGxE?= =?utf-8?B?a2VFSFRPaFI2OFBnV21pL3hCV1hDRW80emtFc2JuNHhLc2pJNG9MZUdJMjFX?= =?utf-8?B?blppOUJqWkJUQml5Zk0yeVo3THh6VTlIck1sZWVMWWZGUVdDZXhmZmtjcTVo?= =?utf-8?B?d0pZbVEzeFYvbFVHcmxqbUY4UzJSVkQrcDhlTktqOHAvUWNWQzZUWTZDV09U?= =?utf-8?B?dm5FVFlCdmdLaENQcjhsNDYvM3Jwb0JQcjk2eHpFRWZQV1pHUVY2NlNscXVX?= =?utf-8?B?Z0pkc3BRQXBZU1UvRlFWQ3BsbFlPWnhHRStlOWJxMFhpUTBYZnkzYzBVWDdu?= =?utf-8?B?WHVxTDU4THNjYVZIWEtVcUhiZStiWHN2bW94YUpGclBPcUh3bVRMVWphdkl3?= =?utf-8?B?WWR6aG5yZE1ZekRRbGZOSUpJajlrV2MxUUtwUFVXREtNK1FmZXdDNUJ4czdJ?= =?utf-8?B?Wk9BN0o5VzRLa1NlOFJOVFRhN0V4TVpub2ZrZnVraWhLRCtqc20wdnBHbndW?= =?utf-8?B?bnQ0a3ZFRlhsSEJncHEwZlExOFBuRk9jSDFoTi9XUlRwWHplMUEvS3RFTWtT?= =?utf-8?B?aXpPSXVvQ0tkSXFnb1V5Y0p4ZmptQkVvZE1xRld5VW9FWkxadDBnL0kxQmtY?= =?utf-8?B?b3NlN2NzVEFIS0hjQ1R4eU5OVTZUNEY4MS96bjlYQzRWQVZCdm1KTy9yeUQ2?= =?utf-8?B?L2JNWGp6elBpSitoRDZzZkpaZkJkUHpNTzNYWVd3b1c1dWtjNWErc0VKRGlr?= =?utf-8?B?MFhtekZNb2ZFWGlpV2lObjJNa2szL1ZCY2l0RnlOd2w1U0c3WUwwTy9YMWx6?= =?utf-8?B?eDFjNHMrUDlPSXpwQjB1SFpOSU1CQzFYL1NBWmg4Y0JvVmkrVGZsNUdrR1lt?= =?utf-8?B?amd4c2hFc29uQ1F5TituUEZ0L2NjYXM2cHNtWVY3RjUzTzVUZzRXRzhWdWR6?= =?utf-8?B?MHVYMTdCYW1TZDhFTDZaWEtHR2syUHNOTkhyQ2tJanFNSmNzY0xZT1kwd2p2?= =?utf-8?B?WjFROFRzOUNDY1dlaXhZelA2cCtya01jUnVHMlQrUTZyNEw5VmZJUzlxMXdt?= =?utf-8?B?dFhBSmx5di9xbmVtVndaaGFTa1E3T05FNG56bXMrZzR6Q1BsUmdNY3hhM1BP?= =?utf-8?Q?1Mht6ITVpj5kPEjWZYUvkUANjhE/NtsAUeUunhr?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <2FDE5AD638AED24DB25128A5783265F1@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2863edb-7a33-45ec-e46a-08d8ef705a31 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2021 09:28:30.0305 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tCK8YxA7kzzlFmCmaMkm/kubi0FqItAPaE7cy+NzP4Id8thpLKXYIBRm+xHvRQgbowxGQrAJ3e6ebAsUeOwLbL+skdAvJRStxyo5YQyUKCh2ek335yrNkK2UfVL0+Yoh X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB6242 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 clxscore=1011 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 mlxscore=0 spamscore=0 mlxlogscore=986 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103250071 SGksIERhbmllbCENCg0KT24gMy8yNS8yMSAxMToxNiBBTSwgRGFuaWVsIFZldHRlciB3cm90ZToN Cj4gT24gVGh1LCBNYXIgMjUsIDIwMjEgYXQgNzo1MyBBTSBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r bw0KPiA8T2xla3NhbmRyX0FuZHJ1c2hjaGVua29AZXBhbS5jb20+IHdyb3RlOg0KPj4gSGksDQo+ Pg0KPj4gT24gMy8yNS8yMSA4OjE5IEFNLCBXYW4gSmlhYmluZyB3cm90ZToNCj4+PiBzdHJ1Y3Qg eGVuX2RybV9mcm9udF9kcm1faW5mbyBoYXMgYmVlbiBkZWNsYXJlZC4NCj4+PiBSZW1vdmUgdGhl IGR1cGxpY2F0ZS4NCj4+Pg0KPj4+IFNpZ25lZC1vZmYtYnk6IFdhbiBKaWFiaW5nIDx3YW5qaWFi aW5nQHZpdm8uY29tPg0KPj4gVGhhbmsgeW91IGZvciB0aGUgcGF0Y2gsDQo+Pg0KPj4gUmV2aWV3 ZWQtYnk6IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0Bl cGFtLmNvbT4NCj4+DQo+PiBXaWxsIGFwcGx5IHRvIGRybS1taXNjLW5leHQtZml4ZXMNCj4gZHJt LW1pc2MtbmV4dC1maXhlcyBpcyB0aGUgd3JvbmcgdHJlZSwgYnVnZml4ZXMgb3V0c2lkZSBvZiB0 aGUgbWVyZ2UNCj4gd2luZG93IGJlbG9uZyBpbnRvIGRybS1taXNjLWZpeGVzLiBQbGVhc2UgY29u c3VsdA0KPg0KPiBodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly9kcm0ucGFnZXMu ZnJlZWRlc2t0b3Aub3JnL21haW50YWluZXItdG9vbHMvY29tbWl0dGVyLWRybS1taXNjLmh0bWwq d2hlcmUtZG8taS1hcHBseS1teS1wYXRjaF9fO0l3ISFHRl8yOWRiY1FJVUJQQSFuZktOWHJCLXlI cWF4ZUg2bkMzbUV3MjhIRkZJMXA1ZmM1Q1pLRUZlb1FQV1hFaFpDcHZNcXZXOEV0RmZUcXRIUGlO Z3BZNFMtZyQgW2RybVsuXXBhZ2VzWy5dZnJlZWRlc2t0b3BbLl1vcmddDQo+DQo+IFdlIG5lZWQg dG8gaGFyZC1yZXNldCBkcm0tbWlzYy1uZXh0LWZpeGVzIGJhY2ssIHBsZWFzZSByZS1hcHBseSB0 aGUNCj4gcGF0Y2hlcyAoYm90aCBvZiB0aGVtKSB0byBkcm0tbWlzYy1maXhlcy4gQWxzbyBhZGRp bmcgZHJtLW1pc2MNCj4gbWFpbnRhaW5lcnMuDQpTb3JyeSBmb3Igc2NyZXdpbmcgdGhpbmdzIHVw LCB3aWxsIHJlLWFwcGx5IGJvdGggcGF0Y2hlcyB0byBkcm0tbWlzYy1maXhlcw0KPiAtRGFuaWVs DQo+DQo+PiBUaGFuayB5b3UsDQo+Pg0KPj4gT2xla3NhbmRyDQo+Pg0KPj4+IC0tLQ0KPj4+ICAg IGRyaXZlcnMvZ3B1L2RybS94ZW4veGVuX2RybV9mcm9udF9jb25uLmggfCAxIC0NCj4+PiAgICAx IGZpbGUgY2hhbmdlZCwgMSBkZWxldGlvbigtKQ0KPj4+DQo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS94ZW4veGVuX2RybV9mcm9udF9jb25uLmggYi9kcml2ZXJzL2dwdS9kcm0veGVu L3hlbl9kcm1fZnJvbnRfY29ubi5oDQo+Pj4gaW5kZXggM2FkYWNiYTlhMjNiLi5lNWY0MzE0ODk5 ZWUgMTAwNjQ0DQo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3hlbi94ZW5fZHJtX2Zyb250X2Nv bm4uaA0KPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS94ZW4veGVuX2RybV9mcm9udF9jb25uLmgN Cj4+PiBAQCAtMTYsNyArMTYsNiBAQA0KPj4+ICAgIHN0cnVjdCBkcm1fY29ubmVjdG9yOw0KPj4+ ICAgIHN0cnVjdCB4ZW5fZHJtX2Zyb250X2RybV9pbmZvOw0KPj4+DQo+Pj4gLXN0cnVjdCB4ZW5f ZHJtX2Zyb250X2RybV9pbmZvOw0KPj4+DQo+Pj4gICAgaW50IHhlbl9kcm1fZnJvbnRfY29ubl9p bml0KHN0cnVjdCB4ZW5fZHJtX2Zyb250X2RybV9pbmZvICpkcm1faW5mbywNCj4+PiAgICAgICAg ICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKTsNCj4N Cj4= From xen-devel-bounces@lists.xenproject.org Thu Mar 25 09:28:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 09:28:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101349.193788 (Exim 4.92) (envelope-from ) id 1lPMII-0000l8-RS; Thu, 25 Mar 2021 09:28:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101349.193788; Thu, 25 Mar 2021 09:28:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPMII-0000l0-OC; Thu, 25 Mar 2021 09:28:46 +0000 Received: by outflank-mailman (input) for mailman id 101349; Thu, 25 Mar 2021 09:28:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPMII-0000je-7c for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 09:28:46 +0000 Received: from chassiron.antioche.eu.org (unknown [2001:41d0:fe9d:1101::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 595761af-4e95-4cc0-8c96-0a784fdb6d17; Thu, 25 Mar 2021 09:28:41 +0000 (UTC) Received: from rochebonne.antioche.eu.org (rochebonne [10.0.0.1]) by chassiron.antioche.eu.org (8.15.2/8.15.2) with ESMTP id 12P9SWEX000942; Thu, 25 Mar 2021 10:28:32 +0100 (MET) Received: by rochebonne.antioche.eu.org (Postfix, from userid 1210) id 0389927E3; Thu, 25 Mar 2021 10:28:32 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 595761af-4e95-4cc0-8c96-0a784fdb6d17 Date: Thu, 25 Mar 2021 10:28:31 +0100 From: Manuel Bouyer To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: George Dunlap , xen-devel@lists.xenproject.org, Ian Jackson Subject: Re: [PATCH 4/6] CHANGELOG.md: NetBSD lib/gnttab support Message-ID: References: <20210324164407.302062-1-george.dunlap@citrix.com> <20210324164407.302062-4-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (chassiron.antioche.eu.org [151.127.5.145]); Thu, 25 Mar 2021 10:28:32 +0100 (MET) On Thu, Mar 25, 2021 at 10:13:11AM +0100, Roger Pau Monn wrote: > On Wed, Mar 24, 2021 at 04:44:05PM +0000, George Dunlap wrote: > > Signed-off-by: George Dunlap > > LGTM, maybe Manuel has something else to add. no, it's OK for me too -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference -- From xen-devel-bounces@lists.xenproject.org Thu Mar 25 09:38:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 09:38:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101354.193800 (Exim 4.92) (envelope-from ) id 1lPMRK-0001z1-Q1; Thu, 25 Mar 2021 09:38:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101354.193800; Thu, 25 Mar 2021 09:38:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPMRK-0001yu-MY; Thu, 25 Mar 2021 09:38:06 +0000 Received: by outflank-mailman (input) for mailman id 101354; Thu, 25 Mar 2021 09:38:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPMRI-0001yp-Vg for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 09:38:05 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ea890625-9993-4787-962b-eda054820ece; Thu, 25 Mar 2021 09:38:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea890625-9993-4787-962b-eda054820ece DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616665082; h=subject:to:references:from:message-id:date:in-reply-to: content-transfer-encoding:mime-version; bh=klRwwvaU4ed9LSX3x/sDurJfniZrtF+mckI2Ix2cBoo=; b=EDkOo+cnXutpgtzsrgLl/4jsWoRFIkNiHzhdh0y9x0gPBWV5Y0AOewZ1 r7EVMJnzxCmHsYbLo0iM9QOT/JKXy3tCPTYCrlT7eQ9VNrYbAd1IywzBU jwtSb7kglbD3XTdPnXv3CM/bmDBBsAl1bKLlFkFnG6oyiQupnT/cmwEkw Q=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: +B2WYDj8ONp6sU2d2uoX4dzhMYd59EnqZ4rXC4br6jVzdinxzBmAFIIsVnTekYN5rbPnJKekZM aaFLj3udsNEhQ4Eo6NPA6OM/eoCQMwYyVIYoJeaM0HeaVD76xbP4W4PbzTsSThOlignzTCE+wR JgqpLUgJRDuIIACsouWcSqbDnSlVFO+0sSjeYx2S/ArHqAJyOpJlHPwitRU13Vx2PbNlxPKuzY WP6uPiFW3kRHzpAvsiX51ExpmrHX10X5wR5amTxSL+tTOxXv7mIn1EBZqXgqs96IRGMEfR4jW4 iZI= X-SBRS: 5.2 X-MesageID: 40085357 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:6E/966PtQlrhrMBcTxv155DYdL4zR+YMi2QD/1xtSBBTb8yTn9 2vmvNe7hPvlDMNQhgb9OyoEq+GXH/a6NpJ8ZAcVI3SOTXOlUmJCMVZ7YXkyyD9ACGWzIRg/I ppbqQWMrLNJHdgi8KS2meFOvIB5PXCz6yyn+fZyB5WPGNXQoVt9R1wBAreMmAefml7LKE0Hp ad+cZLzgDIERgqR/+2G2UfWKz7r8DL/aiMXTc9GxUl5AOS5AnYi4LSLh7w5HYjegIK+5gO2y zvkwv15qKs2svLsCP05ivowLl93PfkwttHLsSQhsYSMSWEsHfUWK1RH4eskRpwjOaz6Es7sN SkmWZdA+1Dr0n/U0vwgRzx1xLu2DwjgkWStmOwsD/YjuHSABcZYvAx4b5xQ1/ixGcL+OxY6u Zt2VmUspJGZCmw5BjV1pzzeDxB0navrWFKq591s1VvFbEwRZV2toIl8EZcAP47bVnHwbFiKu VoAc3GjcwmF2+yXjTctmlr9tSmQm4+KBeAWlQDocyYyVFt7QlE83c= X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40085357" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mx9FBVvJ6AgCdGqZ1xrVCHfD/0J1VjzfvUgm+/RhNuLPbtzq+9NKgn1p5lUg9SRnGenZ/8ET9SAG2w7UaogaFWbPmu2UTLlMC8pEau0KvkrHfwxneW3r9ki5wf0sq58zFjOk3moEOcWHrscO1SvINhVfCYD2Rtp3Tsw6tbmi8dSfS7nkthjHq6D/iWmainEcP0YYXS6n4WQUR6nI5gIpCydGdYHP7Ur0If7Y0b8nsu57aL44qqTmZhdD/L1vU5HliOuFOq8yIw79XXd9lahiwuo58jZowJJQtxjZx0jthoXC/i/YKfeFcEdk6KtRYNEKcFUYGPUnYDozWMQOq7IpKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2w/a6QIOvJdqHc/an9cDyck3WaAGeZtdwdvZrCvYneI=; b=Gev5jvarq8zPC9UJR//g+bTPRiImKgadARWe4stzNezYH3crrpP4re4x0XV7qh6VR9pIeLNk2ILL2yYto+khwDfzmD+ErCYa5jLbDjH0oGRQ7Q2IGZensW62wEUxeorFPCIC840RIkoJ2IFsJptZSerr1teunirCtJqASVu2xkK0JalffJURRNNgkH1UAAivWNN+lEGwIkTW9vnIKx07kdT7+t4hoK12dORgYUQL8ssMDNcYD51gYNfxWI9xx8g3AoxA4mtVPFQ6vD7ZB39ZWOXq3ZV3+GmxoYck1C+66Lcpceru94ZAFEwP1VtJ2rB4H5gOPP629LtH4eA8rCs2hA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2w/a6QIOvJdqHc/an9cDyck3WaAGeZtdwdvZrCvYneI=; b=cZJVf/DiliJwDOiApOHe2o9PrI0sqqOhro39qpvdddS1/GiRxazFnsb0+0GdHfWkzZsb9obK5TF1lFEs3YX50hBr2/u3hyn2Gvz4N39zSCv3+rumPZPgf1are2+7DpOaFq5vB9l5WvYyAAwQ8csLHcPGx57izb+XYVd9FKNt8P8= Subject: Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation To: References: <20210324164407.302062-1-george.dunlap@citrix.com> <20210324164407.302062-5-george.dunlap@citrix.com> <33f78891-c894-b41a-a1a3-82aac1f57b8d@suse.com> <0A187740-DB6E-486C-8B10-5207CE6A5D72@citrix.com> From: Andrew Cooper Message-ID: <7407cac8-c55d-0372-123b-39c9949e6ca5@citrix.com> Date: Thu, 25 Mar 2021 09:37:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <0A187740-DB6E-486C-8B10-5207CE6A5D72@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0496.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::15) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 34230015-e584-4cad-a67b-08d8ef71acbf X-MS-TrafficTypeDiagnostic: BN7PR03MB3732: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qoxmkc397On6QRqWY9eBLcvRGkaWOvEqO4Y1s0NOF/DxrfGSRpbifBX76DfPimLGtu1YTqZfv1wsfLURj7ur9z05M/jftXlcs/GFQjazJrGecQAMc5bjoiA5Wf82tKej8phb2wqEGOesDUbUl05Vgwd1AebZPD6J773xM8O8fDXYWR1r0Boyk29Kpdm3ENQmu1TiXF8479RdH11KjWHPFy71GYpCzTrWMS2KOxBe587oQ9VNb/KObJbEbUOcO55Ktba8dxtfaKArevI+dPiwr6xep+nLYEe9Y14nfPDDKTPDZGbnbeTRFS5+snIKJf7ngzovyW81eZBkqx8TML5RUOdx7vR2LrvEBrj7dEmi7/n/wWVCSPtbqL+fpecRLyt7pYYAr6dXMgXGFVoYwJWCtELCsfTRvVSkyBo/AiE0b0E9TbiGrlFgP0+a+XKL6CVNFTetJ6kRqVH47CvTCM2IOIrGOPe0RdMPz/Rzd4oP7Qh1yKDXWspMJYIveKY991RNIn75eGEbNvLvsHIAYzRrDcwf0HtNOInImg6CIIKAvHfeCM3H5dNaF3reCUItWgabaV91RI3pqdvZpjHlqKqZhRiYH42TaYDsadet885eIqJZSd9DQkC8hRgDBusGEqBkfo0OD3Xql0/yKle0C6SHTTPN+MPhlD4g75rUT8GPIezt1l8ijIxHh6c11oX31FtjEj23sckPQ3h8lg6gJ0FaocBIIm5J4Ydqz/UIKpmzTytYelH4Rq5HzfT5DHsT8dqXgR/bPnjybd8wEns2wM3bnfZ1ecOOapBzAxT4g34VEb2ntNDDcQ7lfHPQxGtG8hZlYjIuJKg6/bN6BWQGdigAhHmwaR+EX6r/NC3m7tz48feeiAJf3TWDxWkvp3urFWAU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(39860400002)(396003)(136003)(346002)(6916009)(66946007)(316002)(31686004)(478600001)(16526019)(8936002)(6666004)(8676002)(956004)(186003)(5660300002)(16576012)(66476007)(86362001)(2906002)(36756003)(38100700001)(66556008)(31696002)(6486002)(53546011)(26005)(2616005)(59356011)(219803003)(207903002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?K2lpYVhhRmhMRjNXWkliZEE5elJYRlM3RXdwVjBsdE1YTFhoeXlHVnFtYzZF?= =?utf-8?B?WWJkSSsvdWhiQXdFdTFncFlpd04wR2x0dnB1SzByTkhmQWFnS28zZkRNZTVL?= =?utf-8?B?bWFaU25NNG1yVlAzK1pvdXphVFdaWmRnQzF2aHMzR1NUUWdZdzdhZFMyRS9H?= =?utf-8?B?aU9mbGQrVi9xcHExTFpmeEpKVU53NVFFZDZNcWV5NlVsVjFhZVJsZ0ZMdkhR?= =?utf-8?B?bEJIaXpEa2xyNWVtMUkrR3BTVGJBcWNId0ZtS1djS25lclNrSE9CSXZ4WFd6?= =?utf-8?B?NDJnV0JGUGZvYmhtNnZaM1daK3NoaFkwNytib3JPOVUxUHY1TFA1TE9UNTVE?= =?utf-8?B?eHdFUHRJbFVwbFY5bGRGclRSOFN6MElIUFdvUTA2alVidm9ieEtyWVNEZGRl?= =?utf-8?B?Y1R4TUxqeWhzbWl5L0doVjVRT2d3ZVdmc016MEgwaGJ4VWdXR2tWdW1namhE?= =?utf-8?B?dnduMjV0dXZsemhZVlh1enVveCtpNVdpamNxaFBnRFVsdStYSi9BaEdVOURS?= =?utf-8?B?by9FUVhmdWMzNWlWYnl3bG5KTWloZWlFVldZQi82aHdxeGZuTkZHY3ZCNFB3?= =?utf-8?B?bmVOOVFEV3BRQnFaWndYU2dDQjlHQWwyQmYwOTlYOUs0Z1p3VTYvVFgrbTQx?= =?utf-8?B?RWJ1REdPaXlXYjB4Tk1nak04ZXZhYndHN25aSm12Z2Y2MGcvSlpzc2ZQM3Fw?= =?utf-8?B?QTAzYytpOFowREE2M0ozV2JEd1kzSHZaYnBFNDNrOUxoMXhTbzdXdm8vaGNl?= =?utf-8?B?M1VWL3RITExwSVhQSkREYlB6TnZ5eUJnMjVJWUhETzE2N2YzdytuYWIrYU93?= =?utf-8?B?cXIwRGw4NXFjSFZxVDBCM3RQcU5pVklseUhSQ1haZzNkeEIzck9kc1dVYWVq?= =?utf-8?B?QWd4blVEMEMvQ1ZPRHhhaW9TNXJsWC9CTWl2aFcxaG9sQXJEQ0h4eGRza01u?= =?utf-8?B?a0gwZmt2aGx1U2NZZVR1Q0k0eS9uQTY0SzJ0RXIxSEhTcitkNS9rMWx4NFNm?= =?utf-8?B?dnFTcDNPNUZVcnQvVUwzMVM3Rmt0cWxnWHRIT1Vndmx6V0NvWTNmR1YxdmpU?= =?utf-8?B?N1dxTi9rOEYyRFVEMndNQUJRRS9jRTFQdDZKNXJSOXRFSDRiN3NFMDVIT1o4?= =?utf-8?B?bFFVQ1BHR2I5NUhlY2dXMXp6c01uaWgyVVpWV0NCdTh3YnpEZGZiQmNHdDBS?= =?utf-8?B?MGlhUjRxN2tMVjNUdmN3ZjlKV1JtaDJPUDRCejhhMFBobVFHOUJqZi9TSk9a?= =?utf-8?B?cExJUFBsU0oyclhYZ1hwdG5QQkhWcFEyK1d3UVlRWnU5VFFLeG12OXYxL2VT?= =?utf-8?B?VmpReEwrN00zZGpGeGEwWDlqeFE0ZW1rVlovYjBYbnEzV1Q5ZTMzNGNxaFZG?= =?utf-8?B?OW9nQmRsaHp2aDBlZnFDckU3ekZyd2VnRFRzajJPZFhiUjNPSkg3SzU1QVB0?= =?utf-8?B?dmVMbkk2TGV0NmthbUd1OUZ5WWJldDFicUsrTUJBNDhkTitEMVZVRWN4MGE3?= =?utf-8?B?clU4YW1CSTJJRURrWkM5bUlDRzB0RXlSYzUvc1J1SWduRlBsUVRtUC9CRlBZ?= =?utf-8?B?K3pMeExCMVFqWkZ6aEtWRlUyUkVHR0xDd0tsY3F3NnRpcW92U2dHRGhBTTI1?= =?utf-8?B?SDQ5TGMyZFJ6OVc4cVlUbEpwWllEMW1mRG1IK1c4Vm1UZzQzSXpRbEVJOGwr?= =?utf-8?B?bXZGakpaZkN0cmdmSFZyQXVoM0w2Rng5ZDJPM2tFdThtbUMvZ1NUUXpUV2t5?= =?utf-8?Q?tVT7uHlHsSwYOhwo+2tQRem0DAOw2RyS0oDuOyT?= X-MS-Exchange-CrossTenant-Network-Message-Id: 34230015-e584-4cad-a67b-08d8ef71acbf X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 09:37:58.3488 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QYfBv4f/qrn4z7EzmeKCJutSb+NNlPmxPMjBiyqYA6pKm+FPca2PBYE1xMmBW4ugZ3BJ1kzlNhRqBeZdBHJnZQg5teqfEHmpo8jQPKeNtqk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3732 X-OriginatorOrg: citrix.com On 25/03/2021 09:04, George Dunlap wrote: > >> On Mar 25, 2021, at 7:57 AM, Jan Beulich wrote: >> >> On 24.03.2021 17:44, George Dunlap wrote: >>> --- a/CHANGELOG.md >>> +++ b/CHANGELOG.md >>> @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>> - Named PCI devices for xl/libxl >>> - Support for zstd-compressed dom0 kernels >>> - Library improvements from NetBSD ports upstreamed >>> + - x86_emulate: Support AVX-VNNI instructions >>> + - x86_emulate: Expanded testing for several instruction classes >> TBH both seem too minor to me to be mentioned here. If I was to pick >> just one, I'd keep the former and drop the latter. > It’s always quite difficult in these releases to help express to people exactly what’s happened. We’ve got over 1000 changesets — what have we been doing? If my star chart is correct, the latter represents nearly 1700 extra lines of codes in tools/tests/x86_emulator/predicates.c. It’s actually a reasonable chunk of code churn, which I think is worth highlighting. I agree with Jan.  New concrete instruction groups are useful for an end user to read.  "We refactored some internal of a test harness" isn't, especially when it would most likely be repeated every release. I'd drop the latter line and just keep the former. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Mar 25 09:49:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 09:49:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101360.193812 (Exim 4.92) (envelope-from ) id 1lPMcY-00039E-W0; Thu, 25 Mar 2021 09:49:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101360.193812; Thu, 25 Mar 2021 09:49:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPMcY-000397-SB; Thu, 25 Mar 2021 09:49:42 +0000 Received: by outflank-mailman (input) for mailman id 101360; Thu, 25 Mar 2021 09:49:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPMcX-000392-Qd for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 09:49:41 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 159c0f6c-d9d7-4dcf-97e9-950913a5dc13; Thu, 25 Mar 2021 09:49:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 159c0f6c-d9d7-4dcf-97e9-950913a5dc13 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616665780; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Gx0RCVEUcnJ+/FXcGeKeYLnxoH0ZkeP+olypIJovcc0=; b=fsYlo4vlsfwgJs9PFluKPxuo9R8lWtOkrZ0QfShZ/74SjhBblatqFkyY TxoUfhHQFOGc8/E8x+y3RXY3hlQ1VZTxoE/uwoQhurHxbCYG7xuFwOj/r fiWhmUaACfK0YQ73VzZ3Xpt8smpB4x0k/U02VfZc18FMiq0JZWY+iAy9J U=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: qoWB19Xjk1ZGwS9CvNmCo0m4zm+TCLqJeBCjZ3/TBGfRRRWJL83lT0rrwlzQnNtmpFadGO2nN4 eFmQOrE6/ZKwwrW8AFtG+ru9bp55NShppxtoSW8JKxK3OWuzDUP+Pa4o7cDKfT0Sv538rFNIdl O7vlhNFCxpurUg1SBqLyShX81/Dr/4HZh1G632DKDIZTM7kOLvkHYwLAWGOr8+x7iianxXG2Ug kNdZMZLjcNueb4q8kKzMNnmrM4puIaE7fDAtZw+wEE7S0BPPQBAtpYIc0+sOda+6Cwocg0uZ5G k7A= X-SBRS: 5.2 X-MesageID: 40105804 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:WcrUnKpDCcNQrVcYMSvBqzAaV5uZKtV00zAX/kB9WHVpW+SivY SHgOkb2RjoiDwYRXEnnpS6NLOdRG7HnKQa3aA4Bp3neAX9omOnIMVZ7YXkyyD9ACGWzIFg/I 9aWexFBNX0ZGIXse/T/BS4H9E8wNOO7aCvgqPkw21wSBxxApsB0y5SIG+gYytLbSNBAoc0E4 fZy8pcvjy7eWkWaMPTPAh5Y8HoodrXmJX6JSMcDxk85wWUyR+u4rj2Ex+Xty1uLw9n67Ek7G TDjkjF9ryu2svLsCP0+k3yy9BtmNXnwsZeH8DksKkoAxjllwrAXvUFZ5SspzYwydvfjGoCsN 6JmBs4OtQ21nW5RBDLnTLI+y3NlAkj8GXjz1jwuwqRneXcSCghA8RMwaJ1GyGpk3YIh9133K JV02/xjfM+Znms7UeNham8azhQmkW5unYkm+II5kYvKrc2U7NNsZcZuHpcDZZoJlOL1KkcDO JsAMvAjcwmCG+yUnaxhBgJ/PWcGl43HhuAX3EYvN2U3zV8jBlCvjol7f1asXEa+J0nTZ5Yo8 zCL6RzjblLCvQbdKRnGY46MISKI12IZSiJHHOZIFzhGq1CE3XRq6Tv6LFwwO2xYpQHwLY7hZ ypaiIXiUcCP2bVTeGe1pxC9R7ABE+nWy72981Y759l/pXhWbvCK0S4ORMTuvrlh89aLtzQWv 61Np4TKeTkN3HSFYFA2BC7c4VOKEMZTNYetr8AKhKzi/OODrevmv3Qcf7VKraoOy0jQHnDDn wKWyW2C95H6mytR3/kkDncU37gYSXEjNdNOZmf29JW5JkGN4VKvARQo0++/Nu3JTpLtbFzXE YWGsKiroqL4U2NuUrY5WRgPRRQSmxP5q/7bn9MrQgWd2f9cbMJvcSjaXlftUH3YSNXfofzKk pytl538aW4I9i73iY5Ee+qNWqckj81qG+VSYwf3omO/93sdJ99LptOYt0xKSz7UzhO3Sp6om ZKbwEJAmXFECn1tKmjhJsIQMfFd9d9hw+vCdVOqW3WsHidoc1HfApYYxeeFeqsxSo+TTtdgV N8t4UFhqCbpDqpIWwjxNgjPEZ0c2SRCrJeBAGjbIFZ84qbPj1YfCOvv3i3mhszcm3l+wE3in b6JSOZQ/3NH2FQo2tVyKrs7VNyeFiMZk4YUAEJjaRNUUD9/lpj2+6CYaS+l1GcbVYP2ckxGj DIazl6GHIl+/mHkDqu3BqSH3QvwZsjetHHBLM4arfJxzeGM4uTj5wLGPdS4bdoPN3jqfUwTO qaYgOZRQmIUt8B6kiwnDIIKSN0oH4rnbfUwxXj9nG/x2N6LvzIIlhqLotrau203izBfbKv35 p4h95u4rf1HWX1d9KcyabYKxREMQjepGaqT+cu7bBY1JhCw4dbLt3+a3/v0noC4TAVaOHTv2 kaSL5g4L/ANpR0FvZiMB5xzx4MrpC3MEAvsgbKGecwclEmsm/DM7qyks71gItqJnfEmRD5Nl ae+RBM5vvpXyOM0rgBFqI7SF4mHnQU2TBH/OmYcZfXBxjvX+Zf/ECiOnvVSs4RdIG1XZERpA 19+deGgqu+cDf5whnZuX9eLrhV+2iqBeO0DwTkI58Fz/WKfXCNiLCt+si9kXPeTia6cV0Rgc l9TnMrB/4zwgUKvckQySi9Sqv+v0IjnR9/2Fhc5yDQ87njxnzaE0FAORDembNMU1BoQyC1sf g= X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40105804" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zu68J0jwYedoeuIOrkAtp2K2vV0/JpPDkIftoAYFLAUIB59UftuDWbn+E7O1QiHeQUo2KzaPnMs+k14zs20itYX+q0sRU2uLDrMBFrJrnaAzb0QaKHg0F7l0CLweeC1QLWZH4aUbvnWo7OsIZbdPglXlABCQQR19R0tUdlrYe4z0F7CxV1+hE3OtyT8JC1Dg+J3vcd/z+YhCVf2Pf29DvzlOdu38D9dSv13381pWJT9/bD6AbnWxkwk/0OcVieFy3EuCujY/IyXIlcsa1Z7uZG1g4tR05FREecmz2yX8hon0I1DJRQZOPwW72rDnmXWgwYF8VUeabGspCALXcjcs0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+3kA/450iOyCr4RtK0VYR6nt+tQPGFcC+lro44Bw32c=; b=fbdDCe3pMbpWsVUGawOkBkwVstL6mLjPIsqoh5f3vwAgB8toHfX4Zti4CmR0Jo/8u/7AQKHiDKX6OXB9BeaEiZg5NSVgqKVrjIVGrDKOvpo7XW9bNtDsVIvUoNFGcgFiZBGJLobGYyogTaMGKPKn5ZEP1Xl6jrVIvammktIGWVl5E1vtr3y1cObO8rUQa4HpiUDSveJJHHN+AHxXrm6kMOZ+OyJNA61XP13l7ybzgQNkbzWjOAWRjvO1AChInmq07/kH99+vGF8iEX6ZWVfLG4xWhuSZK9v8e3DTuDZ0AFeIlZFTf3PZQ4uDJRp/u3gopSjh69ww7P723bSBFQjAOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+3kA/450iOyCr4RtK0VYR6nt+tQPGFcC+lro44Bw32c=; b=soclTTLnuvxWc5rb0ZOWEhrXsRLsRrf8fVYgsObXllrVztfaB4A1efBwPmUqsDDOySFw7g9szTVTsH/0JFPjN+4go5B/GJOyFcgglth6HrY03GsPvJf3p4qEUiPqLtHZ3wlqpmyPL9nOb8i98mUh/QYmOepi2V+g77hi/CbRDv8= Date: Thu, 25 Mar 2021 10:49:28 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: George Dunlap CC: Christopher Clark , "Daniel P. Smith" , xen-devel , Andrew Cooper , Stefano Stabellini , Julien Grall , "Julien Grall" , Ian Jackson , Wei Liu , Jan Beulich , Rich Persaud , Bertrand Marquis , "luca.fancellu@arm.com" , "paul@xen.org" , Adam Schwalm Subject: Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document Message-ID: References: <20210316031814.10311-1-dpsmith@apertussolutions.com> <20210316031814.10311-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR2P264CA0104.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::20) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 32373b85-07c2-406a-ce03-08d8ef734bca X-MS-TrafficTypeDiagnostic: DM5PR03MB2971: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uV2QODmjC5JUrVPJIQZZuU/G2coURaity6RasY4WxmVXoTmHmz8FPJt1g5DwqkMO/zdcExlj6oeRusfts246vq60H2AHgtJt2Iqy4a1mk440DyTyrXxnPIAjhNazM5of954ybDewlhWjRCPHzYYzoaNRWy2FwNRxHkepE61lWjYwmtDOU8GlmIwHUwkPslyp4y4smQpuv/ee48A917zLnSNcPxsM0KwlEgTDOKHE58TAAVdKOX9PwR6tVlvoKFvMepXI3kXSAPJ0ZNrIaqUXhSu8q5lB/5LMShfQGSsNSdOgeG4+WorEprZvOuYAUwTTkAfAHZsWmj+ZUxjmlcyUireftzTSUzZq5mtlJjf+p93MG3/afymliFku+OiHdUXsv805bByKRXakoiHwKwt3cAkR6SvcJbDcdRgaV22KySiBMGRUPfRIPOmpmCWOj4/ExIHCa9EnUGIbhDPHHnysjFHRR9WAUQANhbBRPkTEIsEnCOhN03mjMQRFBe0U87tEc/x9XaDSdlSUeNA0HjtHMOsTGKN/bqsAdBTym/ZrJju46edde+rxOjPHOidltBhEiwOowxmDigdW5le3JKKDAw5Ai35cWkc4d/6E3k/17H4inPL16PhlTpBm+f8KeGL+0husWwGWgGrluo6g+yCrT3cP/YsTZhEpwq+Wq0Qcbbo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(346002)(376002)(136003)(396003)(39860400002)(66476007)(86362001)(66946007)(6666004)(478600001)(6636002)(316002)(6486002)(85182001)(7416002)(16526019)(8676002)(186003)(54906003)(66556008)(26005)(53546011)(6496006)(33716001)(6862004)(8936002)(38100700001)(83380400001)(4326008)(9686003)(2906002)(5660300002)(956004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NG5Fc0VNMlFPNldwVEJ5d3ltVUR2NXpnaWRrVDk3bkdoa0tubm1ZaHRXcThB?= =?utf-8?B?Nm96aFNpSkRSWkg5WFhQKzg2c3UrTTZweThRTzNaVW1qRW5hZThleUNITGFk?= =?utf-8?B?SmZEZ1E0bHdBWWhHM1kzaDZpVFhtNllRbFVFaGt0Rkt5KzhjL0FINk54M29y?= =?utf-8?B?Vmt0OG1acm1xUkJDTmgvK29Gd3ZHY1Vncnd3cjFGby9tOFRnczhWRGt4alhC?= =?utf-8?B?S090aVBUTHpKQVQvbDhWT3JkZGgxbTNNbnlJQVlVQjhxQnh3UmticFJKQ291?= =?utf-8?B?OUo5UHcyV0tQRTVBQ05YZWhFL3VUYmJLTi9hd2lzNlhwSm1pNlZuS1VvaU9v?= =?utf-8?B?RFRpcEg5aTAxYWtQYnZ1cTJRdzJiTVZLL092OFN1SVBWanRqN3orU1p6bzNX?= =?utf-8?B?OFRHbXBldWROSHV2UWpubmhoK2xCallvSnNmeW5SQlIwQk94ei9SRkh1aTFl?= =?utf-8?B?cVQ4MFJMcStTYWtjS0d6aVRuRkhsRTBtdkswZmpjOGtKZXFHTUhkSTJmbXVH?= =?utf-8?B?bHR4bEFNUmJZNkQ4ck00QnVhUnBUL1RLSUhka1RKVjVRcll3NHRFakllOEFS?= =?utf-8?B?WitrcFd3bG1LVnZzN1NaeHU3M0tJWnpzMFQyNVlHZDg3T29raU52QXJGL1V4?= =?utf-8?B?TVh6cUZsY0VMYjFiQURDN3ZCTWJRTWs0N0tCZzVHWERaZ3RwT2JlLy9pbUFt?= =?utf-8?B?RSswMkM4WTQ2MFRiN2p1ajd4NUJzM0pieitQRGRlL3BHWS9xUmNMN1dmaldE?= =?utf-8?B?QlFydk42R2srSHc0elMxVVRWSi9ZaHNLemFmUHJhSzRlSmdydWRtR3FTajZh?= =?utf-8?B?Mkdkb2pRQmcxZE9xOGVJeWxGM0ZlNk9XN3dpdmQxV2p4MmUxRGRPRGJsTTU3?= =?utf-8?B?WEEzNzg1SEcxRDJhQ2haczNqRE5YZ201ZDY0amtIdU5SVzFHei9lN2VlU3JM?= =?utf-8?B?SkNHdzd6eTFVeWMvakVYZ0xzWExUMG15NzNXc2NwSEh3cG4vWHh4UGVBOWxa?= =?utf-8?B?dkljRHd0MkNxSzNNcCt3WHVyTGJTOXNaYWJIZzE2NWpsdXNOOU5Xa3hxOFJ3?= =?utf-8?B?Z05tOE5sOGRPdmlSc3R6Z0hDZUt2Tks2emJqN0w4eDhPVkVOSEt5Q1ovckxX?= =?utf-8?B?ajV5aGNsWHZrZUtMeTZwY2dMd1ZYa0JKWlREQllwU0dGVVl0UUNVZnRybFdn?= =?utf-8?B?Y0VDSUtsblQ5em9Lc1VCdTZxRklycTRiemltSTJ3enh1ZExqMG9vRkpRK2NQ?= =?utf-8?B?L1NmVFFMRHhTU3BxSCs4TDZBc0dJbmg2NENGaCtjMGpMbU1udGN0aVdIbTNE?= =?utf-8?B?S1JPYWlTNHhzQmFWMDU3T2d1MDYzd21nVE5yRE5tMXZvMWV0djI4NmRMckc3?= =?utf-8?B?cUxPMFdGOU0yTkd2cllubHR0a01rclp4MDZ0eU5pTlR3MStIZW5reXlqWUp2?= =?utf-8?B?Ym1ZVFpaVlVpZ3E2Y0w0ZFRtZ1R5dTdLM2VRZkZRdWt1N0NqM3NhaGpYcVpZ?= =?utf-8?B?bG9PUFFPK0Voam5xZVplb1QvRENDSlhSQXZLUG56Y3BNcHZ5TzF2c0hObll6?= =?utf-8?B?QW02ZTNRemlkZ3JIZllpWGpTcndZMVEzN3o4ZUU3RGViVWJKTmduekd4QTBx?= =?utf-8?B?OEtsc0dycFpUQ3BVK2dzWk1zcHN4djlRQ3lQQ244REJMdVNhMjlNQXphQVpQ?= =?utf-8?B?Q1pLemNUNVdQM1M5SEFKODFQeUVNRlZ4dTFzYndST3lzS3FWOWs2bXVCdzdh?= =?utf-8?B?enVINGozY2doR09Ccmp6clVqRHlHSFpWMGllM1JxZHlYN2phbHNHVXJhaWRY?= =?utf-8?B?THVwNWdGeG1kU0phd0dyZz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 32373b85-07c2-406a-ce03-08d8ef734bca X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 09:49:34.7692 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tV0maesAhntkPX9MGWfyDjj70OtA41Pl7rFnYHS2582mq6vHIA/fYGj8IK8aIzXlH4JUYoEq6msuHsOuhIHsvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2971 X-OriginatorOrg: citrix.com On Thu, Mar 25, 2021 at 10:14:31AM +0100, George Dunlap wrote: > > > > On Mar 25, 2021, at 8:32 AM, Roger Pau Monne wrote: > > > > On Wed, Mar 24, 2021 at 05:53:26AM -0700, Christopher Clark wrote: > >> On Wed, Mar 24, 2021 at 1:01 AM Roger Pau Monné wrote: > >>> > >>> On Tue, Mar 23, 2021 at 10:39:53AM -0700, Christopher Clark wrote: > >>>> On Thu, Mar 18, 2021 at 9:43 AM Roger Pau Monné wrote: > >>> If you offload domain creation of guests with > >>> pci-passthrough devices to a control domain and/or hardware domain, > >>> I'm not sure I see the difference from normal domain creation, ie: > >>> it's no longer something specific to hyperlaunch, as I could achieve > >>> the same by using the existing xendomains init script. > >> > >> So that's not what we've proposed, and hopefully not what we'll need to do. > >> > >> Do you know if there is a need to perform work to support the > >> assignment of PCI devices at the point of domain creation (ie. in > >> domain_create), rather than handling it in a later step of domain > >> configuration, prior to the domain being started? > > > > So while I think you could indeed create a domain from the hypervisor > > in a paused state and attach the pci devices later from a > > control/hardware domain, I don't see much benefit in doing it. If you > > need to end up waiting for a control/hardware domain to attach the > > devices and unpause you might as well do the whole domain creation > > from such control/hardware domain. > > My understanding was that one of the primary advantages of domB was > that you could compile and run arbitrary code in whatever language > you wanted to, using already known tools. If *all* we want to do is > to assign some pre-defined specific BDFs to specific domains, then > sure, we could add that capability to Xen. Well, it's not so easy because we require QEMU or pciback ATM on x86 in order to do pci passthrough to guests, so assigning BDFs to specific domains from the hypervisor would need to be done using vPCI (which is not yet ready for unprivileged guest usage) and only support HVM kind of guests strictly. Doing passthrough to PV guests directly from the hypervisor is impossible AFAICT without putting pciback inside of the hypervisor. > But suppose you wanted > to have the flexibility to handle changes in hardware at boot time? > “Scan through the PCI bus and assign anything that looks like a > network card to domNet, and anything that looks like a USB > controller to domUSB” is something you could easily do in domB, but > would be way too complicated to add to Xen. Right, but then you might as well create the domain from domB instead of doing it in the hypervisor? I'm not arguing about not using domB, I just don't see the benefit of creating a paused domain from the hypervisor that then requires the intervention of a further domain (domB) in order to finish creation. Won't it be simpler to just create the domain and attach the pci devices from domB? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 25 10:45:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 10:45:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101365.193830 (Exim 4.92) (envelope-from ) id 1lPNTl-0000hW-2l; Thu, 25 Mar 2021 10:44:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101365.193830; Thu, 25 Mar 2021 10:44:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPNTk-0000hP-Ut; Thu, 25 Mar 2021 10:44:40 +0000 Received: by outflank-mailman (input) for mailman id 101365; Thu, 25 Mar 2021 10:44:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPNTk-0000hH-FN; Thu, 25 Mar 2021 10:44:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPNTk-0001sm-5z; Thu, 25 Mar 2021 10:44:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPNTj-0003al-TH; Thu, 25 Mar 2021 10:44:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPNTj-0007HK-Sm; Thu, 25 Mar 2021 10:44:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nFEf2RmnF/oQ7oIH6iO9u0HO+LzCgEpjdhNHw1OAMrI=; b=z69/a7lUxZ+9Up8xH2RvfyVFNo bLJwnZPT3RF+wiRdkCsvirSkooFIbDy2xrZ/G+8ZtrAcqvuCYnwr4hcD4UwNxSmsqKnYu/dXPB22W jHJLImKlhjcLIpQxuK10147+03o+1UmICO0kXV3Ba1FpAcFcAWVt22gemnINJAzb3nt0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 160387: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b90344f7d6000deba0709d75225f30cbf79ec2f0 X-Osstest-Versions-That: linux=a65e788634437d7cdaf402930acdf210000f3957 From: osstest service owner Date: Thu, 25 Mar 2021 10:44:39 +0000 flight 160387 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/160387/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160152 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160152 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160152 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160152 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160152 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160152 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160152 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160152 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160152 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160152 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160152 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux b90344f7d6000deba0709d75225f30cbf79ec2f0 baseline version: linux a65e788634437d7cdaf402930acdf210000f3957 Last test of basis 160152 2021-03-20 10:11:17 Z 5 days Testing same since 160387 2021-03-24 10:40:15 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alan Stern Alex Williamson Alexander Lobakin Alexander Shiyan Ard Biesheuvel Aurelien Aptel Badhri Jagan Sridharan Bjorn Andersson Christoph Hellwig Chuck Lever Colin Ian King Dan Carpenter Daniel Kobras David Howells David S. Miller David Sterba Dinghao Liu Fabrice Gasnier Filipe Manana Florian Fainelli Gaja Sophie Peters Gerald Schaefer Greg Kroah-Hartman Guenter Roeck Heiko Carstens Hui Wang Hulk Robot Jason Gunthorpe Jason Self Jim Lin Joe Korty Johan Hovold Jon Hunter Jonathan Albrieux Jonathan Cameron Kan Liang Kefeng Wang Klaus Jensen Linux Kernel Functional Testing Lv Yunlong Macpaul Lin Mark Brown Martin K. Petersen Masahiro Yamada Michael Ellerman Michael Walle Nathan Chancellor Nick Desaulniers Nicolin Chen Oleg Nesterov Palmer Dabbelt Pan Xiuli Pavel Skripkin Peter Zijlstra (Intel) Pierre-Louis Bossart Rafael J. Wysocki Russell King Sagi Grimberg Sameer Pujar Sasha Levin Sebastian Andrzej Siewior Shengjiu Wang Shijie Luo Shuah Khan Steve French Takashi Iwai Takashi Sakamoto Theodore Ts'o Thomas Gleixner Timo Rothenpieler Trond Myklebust Tyrel Datwyler Vincent Whitchurch Vitaly Kuznetsov Wilfried Wessner William Breathitt Gray Xiaoliang Yu Ye Xiang zhangyi (F) jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git a65e78863443..b90344f7d600 b90344f7d6000deba0709d75225f30cbf79ec2f0 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Thu Mar 25 11:13:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 11:13:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101374.193844 (Exim 4.92) (envelope-from ) id 1lPNv5-0003rR-Bj; Thu, 25 Mar 2021 11:12:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101374.193844; Thu, 25 Mar 2021 11:12:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPNv5-0003rK-8U; Thu, 25 Mar 2021 11:12:55 +0000 Received: by outflank-mailman (input) for mailman id 101374; Thu, 25 Mar 2021 11:12:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPNv3-0003rF-7P for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 11:12:53 +0000 Received: from mo6-p00-ob.smtp.rzone.de (unknown [2a01:238:400:100::8]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5bc5925a-58cc-4269-a3c2-1b03395ed618; Thu, 25 Mar 2021 11:12:51 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.22.0 SBL|AUTH) with ESMTPSA id 204541x2PBCW50T (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 25 Mar 2021 12:12:32 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5bc5925a-58cc-4269-a3c2-1b03395ed618 ARC-Seal: i=1; a=rsa-sha256; t=1616670753; cv=none; d=strato.com; s=strato-dkim-0002; b=JcWZ8Vl/Y739zpvIuEeh6F6rtvsYzFNPDhA1PZTV380+4Jc4Z8o+zQ1/NFhQGlZcxy WnH9WjJO9BERmhLzcuv28ybkXa2C4JCwRz4uQ6M618PPwpYqF0hh472337stu5sjNhwa YECnOl9IZ1n+jpCLFR0pD6Qv7dz9F85ghtgPLtaDHJPML2SuAMbIh5R5+c1p8wwGZcWD ozd7L4uHgSBLByW5hsWnqsAq2tgz5AnYeH9Y915OusZShBD9+l7jSEAF97JHYiY8/Mqy EBcKInxYF+199hzCGMehT8wR60Tv5NrMLD584l2rk0Sv0OTtOXni6fbSIZy20KkYsngA cCLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1616670753; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=BHLafyRjRvEA3puYQ80EOvJ1Vi/2uXDQaBXaQ3IFZJA=; b=pgA2u+tTUV4ad5xzkGDZ8z3CYeu8WwjTEJox4eYNtk0ZDYuoHBLq89hJ1oH4hc3tsa rsiyRnL4kPP8K/6WO2fAn57vzs6qDJj0I/TUKwCL96rRtw42Tn4gVK6p29S4prB1zo9i JIafA/+Rq2X9rGpkp6hI8f6mtE4prisvYBLmHUfFuy6x0B8w6KUGpYiWgHVDSe5QpHOr eLsipMPz/VBmNi2b36u1qMHt6qDgXnJYKhlTUt9F6TQ4gw86GvaBSwTUW7GiLq8RkJAu t8cF3xPdUL4wwB9s2Hj/LWkpJOzr6+sH0ucLiM/KW9fMlGCYTEeK3X8j0JxbzuFQMA6c E4pw== ARC-Authentication-Results: i=1; strato.com; dkim=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1616670753; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=BHLafyRjRvEA3puYQ80EOvJ1Vi/2uXDQaBXaQ3IFZJA=; b=AV8Y9/W7xPLUqF42tea0B+oHK77nz9jfGDsHHm6uE1BmEDdwks8bZvphyzv/SRzxxa 3N4GOaiVPhjkudPRhNLwX8FQlfs+nH2m4eb/bU908+i5XLojLmEwO7xIAvAXg46FgnYz I/y2s5Bx4k8dCjyk1HGn2A/UMlIpSZ2d4b/NEgdCniIMpIBHeAOou7oTcHI2i1/pVCRJ tlCLK6ufg1JbcFDtoXC1Vbt4XoFMhniIrcSH6MQdZmbnHTJoBemN4OiJKMU7p1lgmBXN Knp7ZkOtXVD3cAdx1tTzC4iqVSm+vahN3bgAmF7yK6oYcrnXanrCTBfRLH9t2jE8oJLC meew== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDXdoX8l8pYAcz5OTW+n4/A==" X-RZG-CLASS-ID: mo00 Date: Thu, 25 Mar 2021 12:12:19 +0100 From: Olaf Hering To: John Snow Cc: xen-devel@lists.xenproject.org, qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefano Stabellini , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs Message-ID: <20210325121219.7b5daf76.olaf@aepfle.de> In-Reply-To: <4441d32f-bd52-9408-cabc-146b59f0e4dc@redhat.com> References: <20210317070046.17860-1-olaf@aepfle.de> <4441d32f-bd52-9408-cabc-146b59f0e4dc@redhat.com> X-Mailer: Claws Mail 2021.03.05 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/sOLp+_RWfRI_U2rhB9e8ruU"; protocol="application/pgp-signature" --Sig_/sOLp+_RWfRI_U2rhB9e8ruU Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Mon, 22 Mar 2021 18:09:17 -0400 schrieb John Snow : > My understanding is that XEN has some extra disks that it unplugs when=20 > it later figures out it doesn't need them. How exactly this works is=20 > something I've not looked into too closely. It has no extra disks, why would it? I assume each virtualization variant has some sort of unplug if it has to s= upport guests that lack PV/virtio/enlightened/whatever drivers. In case of HVM, the configured block or network devices can be either acces= sed via emulated PCI or via the PV drivers. Since the BIOS, the bootloader = and potentially the operating system kernel typically lack PV drivers, they= will find the devices only via the PCI bus. In case they happen to have PV= drivers in addition to PCI drivers, both drivers will find and offer the s= ame resource via different paths. In case of a block device, ata_piix.ko wi= ll show it via "/dev/sda" and xen-blkfront.ko will show it via "/dev/xvda".= This is obviously bad, at least in the read-write case. The pvops kernel triggers the unplug of the emulated PCI hardware early, pr= ior any other PCI initialization. As a result the PCI drivers will not find= their hardware anymore. In case of ata_piix, only the non-CDROM storage wi= ll be removed in qmeu, because there is no PV-CDROM driver. The PV support in old xenlinux based kernels is only available as modules. = As a result the unplug will happen after PCI was initialized, but it must h= appen before any PCI device drivers are loaded. > So if these IDE devices have been "unplugged" already, we avoid=20 > resetting them here. What about this reset causes the bug you describe=20 > in the commit message? >=20 > Does this reset now happen earlier/later as compared to what it did=20 > prior to ee358e91 ? Prior this commit, piix_ide_reset was only called when the entire emulated = machine was reset. Like: never. With this commit, piix_ide_reset will be called from pci_piix3_xen_ide_unpl= ug. For some reason it confuses the emulated USB hardware. Why it does conf= used it, no idea. I wonder what the purpose of the qdev_reset_all() call really is. It is 10 = years old. It might be stale. Olaf --Sig_/sOLp+_RWfRI_U2rhB9e8ruU Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmBccBUACgkQ86SN7mm1 DoBpfRAApO8ObWyfk/aH+aRPfNasALKYjlGgNR8CNaz0Tkxqx2fFggdGZZQwfsp2 dsbOmCw6W9hBQSZZ2naOknqO9BLfjiJr+DHgnxCqfmxd+udmtl9j2qd+nFFRJRik GFz5ecM3zi4c/ZOU/+pk1kmYTiHeART4JcjrAuPd9mCF8btk5JP7FJ5LuikVAosU FDzM4gp1h6hA+6avJv7gwhb+Is0UFuDrAgugjHiHbpwX3jSjAh+YyrpCOUEvQe99 s0v8Sp831x/x3ulc+z/jhb3ZcvAZY42iFBsy0YwRmi3UMTQlWA16WJjfHj0x6VUd WhZcmtpeVFLlPgTE/Ioc9lx2CA4WFkT10jub+l8A03uPNw0ADC7KzgEz1JspwwK9 8a9JVaJNmtzE3eqXRnyguCYCtFI76vT31NeQxZLDfvUCpaLoKKO2l65+x6GS6X9i CsvH5M/DacZjstogrdx7KOczNrh/uW3zxbX3PSFj66KT6uO+mmTPyYYeNrzkavLp 8rzIZ0WV/AsapimTOUvQ2MDCmraqPyUsJ6GVdhA+UpTJatRsjdfVT7MjpL2kzWZ6 qAH3K85PXE1Tdyx977sQvMOYtvW0HB5/Av8TfY3uk2FHHfbMK/JtL5hoXIc97OVo F+6HwgHEQEkueZUtNlAJh7ED6h7GvZWpewd0eQ255vxEXejjVd8= =14YY -----END PGP SIGNATURE----- --Sig_/sOLp+_RWfRI_U2rhB9e8ruU-- From xen-devel-bounces@lists.xenproject.org Thu Mar 25 11:13:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 11:13:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101376.193857 (Exim 4.92) (envelope-from ) id 1lPNvO-0003vg-KP; Thu, 25 Mar 2021 11:13:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101376.193857; Thu, 25 Mar 2021 11:13:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPNvO-0003vZ-HF; Thu, 25 Mar 2021 11:13:14 +0000 Received: by outflank-mailman (input) for mailman id 101376; Thu, 25 Mar 2021 11:13:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPNvM-0003vL-OL for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 11:13:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPNvL-0002Mn-CZ; Thu, 25 Mar 2021 11:13:11 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPNvL-0002fE-0C; Thu, 25 Mar 2021 11:13:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=aOQI9Mr0Yo2TD1tNatsazTuCAXLpcS3ebRcXECoMhhw=; b=QG5KoAnmaAdnEe3OVNDsQPEB4g rEKBuSu/My5VuL6dh8yDf5xTv0L4Ghp0dyk4nvUHuKPHWWIOY5NW3Ud0L5m9hCp1/e4tVVtYaGG5b 3O0X/YuM25ucfX993UFIV9PvD3MUmohDmRuxwdlZkZRqC1QS9wd9z0Y9TKpm9CthZo8I=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , raphning@gmail.com, edvin.torok@citrix.com, jgross@suse.com Subject: [PATCH for-4.15?] docs/design: Update xenstore-migration.md Date: Thu, 25 Mar 2021 11:12:55 +0000 Message-Id: <20210325111255.16330-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall It is not very clear the shared page adddress is not contained in the connection record. Additionally, it is misleading to say the grant will always point to the share paged as a domain is free to revoke the permission. The restore code would need to make sure it doesn't fail/crash if this is happening. The sentence is now replaced with a paragraph explaining why the GFN is not preserved and that the grant is not guarantee to exist during restore. Take the opportunity to replace "code" with "node" when description the permission. Reported-by: Raphael Ning Signed-off-by: Julien Grall --- Cc: raphning@gmail.com Cc: edvin.torok@citrix.com Cc: jgross@suse.com Ian, would you still consider documentation update for 4.15? --- docs/designs/xenstore-migration.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md index 1a5b94b31da8..5f1155273ec3 100644 --- a/docs/designs/xenstore-migration.md +++ b/docs/designs/xenstore-migration.md @@ -216,8 +216,10 @@ For `shared ring` connections it is as follows: | | by xenstored to communicate with `domid` | | | | -Since the ABI guarantees that entry 1 in `domid`'s grant table will always -contain the GFN of the shared page. +The GFN of the shared page is not preserved because the ABI reserves +entry 1 in `domid`'s grant table to point to the xenstore shared page. +Note there is no guarantee the page will still be valid at the time of +the restore because a domain can revoke the permission. For `socket` connections it is as follows: @@ -398,7 +400,7 @@ A node permission specifier has the following format: | | | | `domid` | The domain-id to which the permission relates | -Note that perm1 defines the domain owning the code. See [4] for more +Note that perm1 defines the domain owning the node. See [4] for more explanation of node permissions. * * * -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Mar 25 11:43:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 11:43:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101382.193874 (Exim 4.92) (envelope-from ) id 1lPOO8-0007Ac-15; Thu, 25 Mar 2021 11:42:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101382.193874; Thu, 25 Mar 2021 11:42:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPOO7-0007AV-UP; Thu, 25 Mar 2021 11:42:55 +0000 Received: by outflank-mailman (input) for mailman id 101382; Thu, 25 Mar 2021 11:42:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPOO6-0007AQ-6M for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 11:42:54 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPOO4-0002q2-M4; Thu, 25 Mar 2021 11:42:52 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPOO4-0004ON-9g; Thu, 25 Mar 2021 11:42:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=z+vsNgBK9l3wShAjdTSgrGCHBKpK3MehG+GnO8o0ivQ=; b=VH97DEXvG39dtg/08DSDIWwqaN TDg2wdbTEJq+F2YPGeCMjlhno6xwIB3PQuOLXKLsq0jVZFXJHc1KRZFtVmwocAHwKWRPNf78n1H2W 2YPBgcYgJmeqOX6j5C7n4Ak2BeUyilKWMPQXCeqO0Ya5Sv2nKvqKYQFOjwn1pfVkIgw8=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Ian Jackson , Wei Liu , Juergen Gross Subject: [PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API Date: Thu, 25 Mar 2021 11:42:43 +0000 Message-Id: <20210325114243.12284-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall The last use of the compat foreign API was dropped in commit 38eeb3864de4 "tools/xenstored: Drop mapping of the ring via foreign map". Therefore, we don't need to define XC_WANT_COMPAT_MAP_FOREIGN_API. Signed-off-by: Julien Grall --- tools/xenstore/xenstored_core.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 0c9a0961b57e..1cdbc3dcb5f7 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -19,7 +19,6 @@ #ifndef _XENSTORED_CORE_H #define _XENSTORED_CORE_H -#define XC_WANT_COMPAT_MAP_FOREIGN_API #include #include -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Mar 25 11:51:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 11:51:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101385.193887 (Exim 4.92) (envelope-from ) id 1lPOWg-0008IL-U5; Thu, 25 Mar 2021 11:51:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101385.193887; Thu, 25 Mar 2021 11:51:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPOWg-0008IE-Qs; Thu, 25 Mar 2021 11:51:46 +0000 Received: by outflank-mailman (input) for mailman id 101385; Thu, 25 Mar 2021 11:51:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPOWf-0008I9-M4 for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 11:51:45 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id eeed5c23-8e83-4b75-9b45-d28c5be4e68a; Thu, 25 Mar 2021 11:51:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eeed5c23-8e83-4b75-9b45-d28c5be4e68a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616673103; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Dm2TcGv2m/gbJjDD3Q2nBprHkqtL/XlshLyHAE4lLNA=; b=R3p9Qu8PStEx3DVc8VjkLVWgi/wvmgQX7kdcOszVwh7vACLdtc1KPKVo +f+jaj5KlVTAc+HtIh0g4lGJMIQTJeKXU+3tNEKpZSvOFV49iiWIoHy5F DYUMnYlHNVNNEZo/fbCH8HoQfQu7vpo58P7prFiVPcmHwwKmmnclvHOMS 8=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 3aPfJmzcR5u4Ud5V+v06M8KtaJMIuqoJPzQOaJEwZgZINDvQG8rSPpA5mPf6DlUXw9g1Yi0zyn 8rb8UFTG9sc2F1fPnolmTKYtjPGdfHgmlFCH73EkItWW1K5SxsD93CKNWP37YqdNteGMQp1fmB pS6eqDa2jL1fBdiUlqJNzGEtrMBNgOAl/dbr8oX7etl13RAhLcEGzwOUxcsoEbd/i78WT30ytk Unk8zGMYBjXQjRbCgVYPCSrNdxIGR8Op3R+kxuMDTaVJSy/ysWlB8qecQ4VM4AFh1CevmhD7jd 26M= X-SBRS: 5.2 X-MesageID: 41552710 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:YcJVXq2TAnLz/iMq5mnBmAqjBSF3eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/BIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFmdJ1/Z xLN5JzANiYNzRHpO7n/Qi1FMshytGb8KauwdzT1WtpUBsCUcFdxi1SYzzrdHFebg9AGJY/Cd 6w5tBfoSChZHQQaa2AdwQ4dsLEoMDGk4+jXA4eC3ccmXOzpB6LyJq/KRiX2R8CTyhCqI1CzU HpmxH0j5/T1s2T5QTb0wbonvBrsfvnjuBOHcmdzvUSQw+c9jqAQKREd/m8sCsuoOepgWxa4O Xkhxs7Jcx85zfwUwiO0GPQ8jLt2jov9HPuoGXw6RCIzL2bNVBKefZpvo5XfgDU7EAtprhHod l29lmUqoZNClf4lDn9juK4Ji1CrFa+onYpjIco/gVieLYZAYUhyrA3zQd+FZcNGz/C84Y3EO ViJ9G03ocpTXqqK1/epWVh29qqQzAaGQqHWFELvoiv3yFRh20R9TpV+OUv2lM7sL4tQZhN4O rJdoxuibF1V8cTKYZwHv0IT8ebAnHEKCi8f166EBDCLuUqKnjNo5n47PEe/+exYqEFy5M0hd DoTE5YnXRaQTOvNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dQWeVVEVlde6qfl3OLybZ9 +DfLZtR9PzJ2rnHohEmyfkXYNJFHUYWMoJ/vkhXVajpd/KN53KuuTXfO27HsuuLR8UHkfERl cTVjn6I8tNqmqxXGXjvRTXU3TxPmzzlKgAVZTyzqw28swgJ4dMug8ahRCS/ceQMwBPtaQwYQ 9bKLPjmaWrmHmu8Q/zniFUEysYKnwQzKTrUntMqwNPGVjza6w/t9KWfn0X+3ebOBllTYfzHB REr1p6vYK7RqbgixwKOpaCCCa3nnETrHWFQ9M3gauY//rofZs+E9IBQ6x+FQLCEjRvggZ0oG J/aAsJL3WvVQ/GuOGAttg5Fevff95zjEOAOshPs0/Ssk2auIUSXHcBZiWvVsSWmA4qYDJRij RKgugiqYvFvQzqBXo0gew+PlEJTGiMGrpJAD6IY5hulqnxdBt9SnqLgjKmmwg+E1CahHk6ty jEF2m5aPvLCl1StjRj3qHm/EhdW0+dc0hzA0oK+rFVJCDjgDJewOWLbq283y+tcVME2PgaKy yASyAVOBlSy9e+0wO1lD6OGW49/IgnOvXQAd0YAvfu80LoDLfNubANHvdS8pogCcvntfUTV/ mDPyCSNzH1BooSqnqoj0dgHBMxjnYqkfnlgkK4qEe52WMyGvrULhBNQaoBL9SV8mjjQLKp3f xC/KYIlNr1Fl+0TNiMjZzzRXpkDDj4pGatVeEmqZxOp8sJxfNONqiedQGN7W1N2RU1Edz9m0 wfSplq+bypAP4bQ+UiPwZiumcznNuBLEEXohX7L+83c1YqlWLaNbqyks31gItqJk2Kvw3rP1 aDtwVb4vfeRiOGvIRqQZ4YECBzaEIm7m5l8/7HX4rMCB+yf+UG2FahKHeyfPt8T6eCcI9g4y pS0pWtn+WNcTD/1x2VlTxnIrhW+2LiePiMOmu3aKd12u3/H0+NjKus6NOyizmyaQLTUTVmua R1MWoKbspCjTE+ipYQySbacN2vnn4Y X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="41552710" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SynJ7qsm00XBz/zFzHZhB5Dz8yC+MxlsCybMfrgHXinMHynDwvdf2shQ7cMT2OsMKE6OBRbz3hjQe0JUbuiZIr/AeNr7MzayjiG+KA5yeyFyIA2OSwimKfZiFxvXjsnP8xr+Jb11WgYlM9Onntrp/s60nX238xAF74RJglAvzOo9GOO0Q3mzXpcilSw3qI7ZpXNls3quwOlbn7IJ4PRp4IcR0Wi4gv0TwpKIPAP+6spTt25fd1P0exTH737XVXx6b1+g7DPGk85ZAEJrr5RjUANLoc8iKbuWMQNM1fS8J9hOx9dEZVvTW9Na4f6Exl6S4+yrRoPypTOs9eNz8oTd+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vfh8iklu78et7J8VloVPeU+e7QaHw19wXC9LMVyyrxs=; b=MAqtkdbsz3FPQUTy31BsnCkFru8+W7MuXi14jtJ4iv/Q71M1XUqyk8min7NP8bnfvUsPpHU048m9WqcIJaME1sXgTMv6e1XolhkefoEBuvKmN9jzHf2JEG5D1ZgbLzt112P7eDTJdBPluzMjAYStTTatxNW/QOKsPJmjD9/+cn/Ly14UFegzv77YJrTEbau7X6BOPL+K6RjpxjqXAOT/4+zH79788vOx3ynxYkZ2Dz7BgunbhQVr2ynnIjvuw930goPf6XGNUf1L8b3pAJQjMaWWKU6fLEJXQfHxB9CbUIpMT65XTEinQ8/0doJM9ezpkWXJ1KGumZMkU/IgS9ArdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vfh8iklu78et7J8VloVPeU+e7QaHw19wXC9LMVyyrxs=; b=xYXf/dhDRhX+Z8b+LViooe9RQsOtdpebDzlsB2hKO3C7adk6FgoMNIZAyNKVYVD6SZQDQXxixYFXUIznQDQcyfVDwRu5rCwRDpdVv9yhF92+35/Fsju2Qb6L9CGS5ZXGq/DaJUa2A0FQhq39Igcwt9hYkwlj1Jo0UUw9pZR2a+Q= Date: Thu, 25 Mar 2021 12:51:32 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Boris Ostrovsky CC: , , , , Subject: Re: [PATCH RESEND] Performance regression due to XSA-336 Message-ID: References: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> X-ClientProxiedBy: MR2P264CA0058.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:31::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7175a280-aae8-4784-87e3-08d8ef845990 X-MS-TrafficTypeDiagnostic: DM6PR03MB3579: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BA1gD7iLjrcZN1JCQLP8rgLtP4kHsBY8PQrSVSjEXrqk9Qx4goiAMERTFplYhwIUvzb4fKAPAyE9tWKcKP1ELp43YzOMxPXxuiyxYt75cxKx7z1blJZEuJGbFI0CqB6X55Nzcqi+sVfL3Runk5jyO8rLe0TCNZQUh3YEu4tSZjCovbz3Kmqpy3JKYvsaSGFPZ9PwWtdwS1/p51hix5TVdeUEI52jZUB+7vFqpcuCGcjFAKTu065OmhFQquxAXJ8ZvFra5QVmmk8O6btlbeza7/OSKhw039c2gT9Jrhy1yyNctcTctr3eDhyLWvNyY9NzE/6k4aDcMYBA6gujz+UYCboOlfXCQ9yDZ/pSlzR3t4YvfAJol8Y2NBcvEhxoVy0k+L11gCpEWOG50wZokOe4go7HMrGrwar/nJJz80ggEtiKmi+180E8eH15lKc9rZgqZSaFdHcfRud5pi/aTw3/LT9GSqtRkl/Te4KALvZn1Xf2TZ47See3b3ndc1G6qhb4wEgHYHGceu2ubcU3R/1JhhMG/08vCF8NX3At1xujbLZ75KOaOq2ipKwi+Uh76sUTrRmda2hsB+WyYu9Plb1lfi6qJVoo5AnBPy4pWkEQkoUMyJx3yTztvsWOPNaGGFv55Ch10/RyaPRDOBrHdgOPTf+POLIIyGDA+qHNgK5EEO52IXJt4uhvHNtvtn39S196XjL2D4FxDRHVJSDn6UvBdeGQ8LkW4X0ue6uv/uwkdsjNjvGeVf2/QnGecuIZ8q6n X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(396003)(346002)(39860400002)(366004)(136003)(376002)(8676002)(6666004)(6486002)(2906002)(26005)(316002)(186003)(9686003)(8936002)(5660300002)(16526019)(956004)(85182001)(4326008)(66946007)(66556008)(66476007)(966005)(6496006)(478600001)(38100700001)(6916009)(33716001)(83380400001)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NDlQMzFiSXY2TG1mUEhRU3FmbTJ4M3pUa2VBMkxVQzIxb1JTa1pqOGk0SlBj?= =?utf-8?B?L0M5NmljekNDQS9xUzU4RmtDcFFGOXpLSWRGTTVCaHd4dE45SmoxOVM4ajJv?= =?utf-8?B?ck9nV3M4dDRiK3JscXRrYkFyRlhHd3JWTEJEQzRQRXhMeUxYOWFhbnR1WTFh?= =?utf-8?B?R1Y3c1dhVXFoTEpBM0hnbG5EbE82SlI3aXYwQThMVytGUDAzV0ZrbWZpcGRm?= =?utf-8?B?dUhBTGw4R1JjQlBEYW9kK1UzSGhoSDQxeEpxUFdqNThENDkzQ3hxMkZDVmtT?= =?utf-8?B?RjVRcTlOVEpFUWRZZ2RIaHo0TjMwWHZDY1pBdjVUVFlCdFlDNkZOMDNyaG0z?= =?utf-8?B?M2JkekRrZHp2S01mcnBXV1NjRHowcEtFMXhISklHeWdodjE1c3h6YVY3c3FZ?= =?utf-8?B?amRuYzF6TGNybDEwS0NGaUVrdlBDNEM4d29TSjhJcWd5cVNNU0RJa0ZHRGx6?= =?utf-8?B?SlM1TkhKdDJDSXVUSHJROU90eTA3S1JHS2xGQ1Njd1lzVGFWMUdLdXB1dzZp?= =?utf-8?B?TEplY2tmaXhVQnZRNlMyc0ova2RZZldMemo0QW1uMlUvNTVFN1ZzSStmNEdV?= =?utf-8?B?RndGZTB0RGtOV1JPQjhmMVlrRWh5TmxNZTEzVStkOCtGeXQyTllPRmhCTFhr?= =?utf-8?B?cjdLWS9jb1UyZlZKZEFxQ0llVVFUU3ZPQUFSUG0zdzBldEpzUVczMFVaOTBP?= =?utf-8?B?TFJMNWlQbnNKY0pXL3B0Vk11d29sVUdEUzNiNXo1Q2J6SWpreDJsR3RTRFFT?= =?utf-8?B?VFBSY1l4ekFHaExSVlNZTU4wYnRoa1RPM3UyYkhINHo2b0Z1NFFzV2x0SmIw?= =?utf-8?B?SFhVT1RRb1lUYjlLWW4reUczOTNHNmh6UzZNTmNReDBzUDVzczVNSW1LRlkz?= =?utf-8?B?dWt5K0dONmhpZVVaOC90RWk5bjUyNGJiL1Q5d0VmYzIxblpCK1FNc3ZyczBu?= =?utf-8?B?NGp3UnZndG8wMmJxc0Z0eXJPWEY4MERCNmZPNitUN08yQXV5SmhnSUZBVjgz?= =?utf-8?B?TUZzMFNJVTNRc1VWWk8yQ2paTTBNMmxySEVHdnVuaHF1M0RTMmVkU3YwZWFP?= =?utf-8?B?N1NFTjlpNVpmL01FeHJCYzB2TFltZTlvbGJqMHY5bVZBaVZWaTRnMC9BaUp3?= =?utf-8?B?cGRkYXphdUR5RGpSSEJ4VXMwNlovWUMvZGR6MFY3RFdxbzdsTnhYZ25qKzFt?= =?utf-8?B?UEluclNiKzgySGZLdy9KZlV6VTJFdFArK3QwVWdnNGNibkNuK3hjZkM3NVNZ?= =?utf-8?B?YVFKdmp1Q1kvdmZWdSs2b1VOcy8zenFzcTczcGsvank1eTV6S1YvVjdQa1VN?= =?utf-8?B?ak5BVUNhZi94L1R2aW5FVHRpZGJueVdBOTBPOVZJdXZKbjEzK2x1bk9RMmhW?= =?utf-8?B?bENkdmRVc2VyblhhcmRFSHlmRnBrUm0wejZFT2Zvc2o4RVgvMTdBRHRNanIx?= =?utf-8?B?M3pXSXIzSmNlcHpBVkZwaG05UmVKbXJCblVlZXpzVHFlcHZ2QTIzSFF5OEE4?= =?utf-8?B?K3d1TlZQbmt0Y2hPQ3JLUFhuckZoWmhTNmdaaUpuR0ZXRGtuTWtHMVRuODEr?= =?utf-8?B?ZWRNNDkzL2pZYkdZQTB6c2xqQWtETW5kMkoxZTVnZ0JuVklseUFSTFVNcWR3?= =?utf-8?B?b1NET0ZPNmcyTUMwdVJidGxTUlE3NjJLMnY0V3RpWS81M3FtT3ZPSTNRMjFU?= =?utf-8?B?QzFLbUF2YUd1L09iZ2JCRUtZSWViNWF2bmdXY01IVzVXNy9YSmRZNFM3c3c2?= =?utf-8?B?clpSUlU0UVdRM0lEVlAzeklrWE9odTdrUVl6TEhwQ2ttU2M4MlhNeXZ3aFNk?= =?utf-8?B?ZU1kZjB2YkZndFBoVFcrZz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7175a280-aae8-4784-87e3-08d8ef845990 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 11:51:39.1545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ycoKEk6r82fp3d6BMox6lDwLGshW1rHeW7TyoweB+tkGmDIabmwzt0wxQMxgQ7LISU81/3gVuNu9iwD/ULKXLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3579 X-OriginatorOrg: citrix.com On Wed, Mar 24, 2021 at 05:05:04PM -0400, Boris Ostrovsky wrote: > > (Re-sending with Stephen added) > > > While running performance tests with recent XSAs backports to our product we've > discovered significant regression in TPCC performance. With a particular guest > kernel the numbers dropped by as much as 40%. > > We've narrowed that down to XSA-336 patch, specifically to the pt_migrate rwlock, > and even more specifically to this lock being taken in pt_update_irq(). > > We have quite a large guest (92 VCPUs) doing lots of VMEXITs and the theory is > that lock's cnts atomic is starting to cause lots of coherence traffic. As a > quick test of this replacing pt_vcpu_lock() in pt_update_irq() with just > spin_lock(&v->arch.hvm_vcpu.tm_lock) gets us almost all performance back. Right, we where kind of worried about this when doing the original fix, but no one reported such performance regressions, I guess Oracle is likely the only one running such big VMs. I have a pending patch series to remove all this vpt logic from the vm entry path, as it's not working properly except for very simple scenarios: https://lore.kernel.org/xen-devel/20200930104108.35969-1-roger.pau@citrix.com/ I hope I will find time to post a new version of the series soon-ish. > Stephen Brennan came up with new locking algorithm, I just coded it up. > > A couple of notes: > > * We have only observed the problem and tested this patch for performance on > a fairly old Xen version. However, vpt code is almost identical and I expect > upstream to suffer from the same issue. > > * Stephen provided the following (slightly edited by me) writeup explaining the > locking algorithm. I would like to include it somewhere but not sure what the > right place would be. Commit message perhaps? > > > Currently, every periodic_time is protected by locking the vcpu it is on. You > can think of the per-vCPU lock (tm_lock) as protecting the fields of every > periodic_time which is attached to that vCPU, as well as the list itself, and so > it must be held when read or written, or when an object is added or removed > to/from the list. > > It seems that there are three types of access to the peridic_time objects: > > 1. Functions which read (maybe write) all periodic_time instances attached to a > particular vCPU. These are functions which use pt_vcpu_lock() after the > commit, such as pt_restore_timer(), pt_save_timer(), etc. > 2. Functions which want to modify a particular periodic_time object. These guys > lock whichever vCPU the periodic_time is attached to, but since the vCPU > could be modified without holding any lock, they are vulnerable to the bug. > Functions in this group use pt_lock(), such as pt_timer_fn() or > destroy_periodic_time(). > 3. Functions which not only want to modify the periodic_time, but also would > like to modify the =vcpu= fields. These are create_periodic_time() or > pt_adjust_vcpu(). They create the locking imbalance bug for group 2, but we > can't simply hold 2 vcpu locks due to the deadlock risk. > > My proposed option is to add a per-periodic_time spinlock, which protects only > the periodic_time.vcpu field. I wonder whether we really need a per-periodic_time spinlock, it seems like functions using access type 1 are the only ones that suffer from the contention caused by the global rwlock, so maybe we could adapt this proposal to still use a per-domain lock, seeing that type 1 access are likely safe by just holding the vcpu lock. Not that using a per-periodic_time spinlock is wrong, but it's likely too fine grained (and adds more memory usage) as type 2 and 3 accesses shouldn't be common anyway. Let me make some comments on the patch itself. > Whenever reading the vcpu field of a periodic_time > struct, you must first take that lock. The critical sections of group 1 (your > "fast path" functions) would look like this: > > 1. lock vcpu > 2. do whatever you want with pts currently on the vcpu. It is safe to read or write > fields of pt, because the vcpu lock protects those fields. You simply cannot > write pt->vcpu, because somebody holding the pt lock may already be spinning > waiting for your vcpu lock. > 3. unlock vcpu > > > Note that there is no additional locking in this fast path. For group 2 > functions (which are attempting to lock an individual periodic_time), the > critical section would look like this: > > 1. lock pt lock (stabilizing the vcpu field) > 2. lock vcpu > 3. feel free to modify any field of the periodic_time > 4. unlock vcpu (due to the mutual exclusion of the pt lock, we know that we are > unlocking the correct vcpu -- we have not been migrated) > 5. unlock pt > > For functions in group 3, the critical section would be: > > 1. lock pt (stabilizing the vcpu field) > 2. lock current vcpu > 3. remove from vcpu list > 4. unlock vcpu. At this point, you're guaranteed that the vcpu functions > (callers of pt_vcpu_lock()) are not accessing your pt. > 5. assign pt->vcpu (we still have mutual exclusion against group 2 functions) > 6. lock destination vcpu > 7. add to vcpu list > 8. unlock destination vcpu > 9. unlock pt > > If functions from group 2 and 3 are less frequent, then you won't see too much > added lock overhead in this situation! Plus, even if group 2 and 3 are somewhat > common, the performance overhead of an uncontented fine-grained lock is muuch > smaller than the overhead of a heavily contended coarse-grained lock, like the > per-domain rw lock. Thanks, that's a very good description of the different locking accesses by vpt. The original fix already aimed to make this difference by introducing the pt_vcpu_{un}lock and pt_{un}nlock helpers. This all stems from a very bad design decision of making vpts tied to a vCPU, which is a broken assumption. Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 25 12:07:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 12:07:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101392.193901 (Exim 4.92) (envelope-from ) id 1lPOlL-00016L-Ib; Thu, 25 Mar 2021 12:06:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101392.193901; Thu, 25 Mar 2021 12:06:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPOlL-00016C-AX; Thu, 25 Mar 2021 12:06:55 +0000 Received: by outflank-mailman (input) for mailman id 101392; Thu, 25 Mar 2021 12:06:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPOlJ-000167-Rb for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 12:06:53 +0000 Received: from mga04.intel.com (unknown [192.55.52.120]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3ebd607b-5abd-4338-93b1-fd2f7fb09ebf; Thu, 25 Mar 2021 12:06:51 +0000 (UTC) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 05:06:49 -0700 Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 05:06:46 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lPOl9-00G2C7-Nk; Thu, 25 Mar 2021 14:06:43 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ebd607b-5abd-4338-93b1-fd2f7fb09ebf IronPort-SDR: g3InKXdDzu9WXIUYj8FVOJ9A2WAZqsOO2P4Yd6+1/lMb5f6kK4W3jGQ6KsSgWSJJZ4c366zd/I Gvg0N8awAXBQ== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="188616643" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="188616643" IronPort-SDR: nXQRT8F2j/iOtbKgmkvi3bw9pPw6+AvGS9dShY8ox4/rl8Xhc1dwyVW2A5twvUdrvugohHK+tI GYJ6k1bpX1lw== X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="436437388" Date: Thu, 25 Mar 2021 14:06:43 +0200 From: Andy Shevchenko To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Mika Westerberg , Linus Walleij , linux-gpio@vger.kernel.org Subject: Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region Message-ID: References: <20210324123118.58865-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Mar 25, 2021 at 09:46:46AM +0100, Roger Pau Monn wrote: > On Wed, Mar 24, 2021 at 06:57:12PM +0200, Andy Shevchenko wrote: > > On Wed, Mar 24, 2021 at 04:13:59PM +0100, Roger Pau Monn wrote: > > > On Wed, Mar 24, 2021 at 04:22:44PM +0200, Andy Shevchenko wrote: > > > > On Wed, Mar 24, 2021 at 02:55:15PM +0100, Roger Pau Monn wrote: > > > > > On Wed, Mar 24, 2021 at 02:58:07PM +0200, Andy Shevchenko wrote: ... > > > > Unfortunately it does not expose PCI configuration space. > > > > > > Are those regions supposed to be marked as reserved in the memory map, > > > or that's left to the discretion of the hardware vendor? > > > > I didn't get. The OS doesn't see them and an internal backbone simply drops any > > IO access to that region. > > I'm not sure I understand the above reply. My question was whether the > MMIO regions used by the pinctrl device (as fetched from the ACPI DSDT > table) are supposed belong to regions marked as RESERVED in the > firmware memory map (ie: either the e820 or the EFI one). I don't actually know. I guess it should be done in order to have ACPI device a possibility to claim the resource. > > > > > Doing something like pci_device_is_present would require a register > > > > > that we know will never return ~0 unless the device is not present. As > > > > > said above, maybe we could use REVID to that end? > > > > > > > > Yes, that's good, see above. > > > > > > > > WRT capabilities, if we crash we will see the report immediately on the > > > > hardware which has such an issue. (It's quite unlikely we will ever have one, > > > > that's why I consider it's not critical) > > > > > > I would rather prefer to not crash, because I think the kernel should > > > only resort to crashing when there's no alternative, and here it's > > > perfectly fine to just print an error message and don't load the > > > driver. > > > > Are we speaking about real hardware that has an issue? I eagerly want to know > > what is that beast. > > OK, I'm not going to resend this anymore. I'm happy with just getting > the first patch in. > > I think you trust the hardware more that I would do, and I also think > the check added here is very minimal an unintrusive and serves as a > way to sanitize the data fetched from the hardware in order to prevent > a kernel page fault if such data turns out to be wrong. > > Taking a reactive approach of requiring a broken piece of hardware to > exist in order to sanitize a fetched value seems too risky. I could > add a WARN_ON or similar if you want some kind of splat that's very > noticeable when this goes wrong but that doesn't end up in a fatal > kernel page fault. You found the issue anyway as long as you had a crash, so current code already proved that it does it work perfectly. Since I know what hardware this driver is for, I can assure you, that it will be quite unlikely to have wrong data in the capability register. The data sheet is crystal clear about the register's contents: on real hardware it must be present and be set to a sane value. -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Thu Mar 25 12:54:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 12:54:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101397.193915 (Exim 4.92) (envelope-from ) id 1lPPVG-0006Eu-2c; Thu, 25 Mar 2021 12:54:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101397.193915; Thu, 25 Mar 2021 12:54:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPPVF-0006En-Vc; Thu, 25 Mar 2021 12:54:21 +0000 Received: by outflank-mailman (input) for mailman id 101397; Thu, 25 Mar 2021 12:54:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPPVE-0006Ei-Go for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 12:54:20 +0000 Received: from mga14.intel.com (unknown [192.55.52.115]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c2f43d85-f7e7-4dbb-b10c-226d515bfa82; Thu, 25 Mar 2021 12:54:18 +0000 (UTC) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 05:54:17 -0700 Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 05:54:15 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lPPV6-00G2tJ-5t; Thu, 25 Mar 2021 14:54:12 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2f43d85-f7e7-4dbb-b10c-226d515bfa82 IronPort-SDR: F6xLx7ZqZpaAZks9DkKtLFReIOihLGBkmmOg25fNsKlltnlnczOHPIGVTL7POn+unSOElbpPgO qN8T76Sy0VlA== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="190344924" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="190344924" IronPort-SDR: 0UZcZSDDN+4EZ6NdZE6wdeQVxlVSZPThBvSUsY1Z0jpTq41Ef7NW/naabCdg2U6qVoUzWm2rBJ jJr85sXM+nUA== X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="375057264" Date: Thu, 25 Mar 2021 14:54:12 +0200 From: Andy Shevchenko To: Roger Pau Monne Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Mika Westerberg , Andy Shevchenko , Linus Walleij , linux-gpio@vger.kernel.org Subject: Re: [PATCH v3] intel/pinctrl: check REVID register value for device presence Message-ID: References: <20210325090947.73729-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210325090947.73729-1-roger.pau@citrix.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Mar 25, 2021 at 10:09:47AM +0100, Roger Pau Monne wrote: > Use the value read from the REVID register in order to check for the > presence of the device. A read of all ones is treated as if the device > is not present, and hence probing is ended. > > This fixes an issue when running as a Xen PVH dom0, where the ACPI > DSDT table is provided unmodified to dom0 and hence contains the > pinctrl devices, but the MMIO region(s) containing the device > registers might not be mapped in the guest physical memory map if such > region(s) are not exposed on a PCI device BAR or marked as reserved in > the host memory map. Applied for fixes, thanks! > 91d898e51e60 ('pinctrl: intel: Convert capability list to features') > Suggested-by: Andy Shevchenko > Signed-off-by: Roger Pau Monn > --- > Changes since v2: > - Return ENODEV. > - Adjust code comment. > > Changes since v1: > - New in this version. > --- > Cc: Mika Westerberg > Cc: Andy Shevchenko > Cc: Linus Walleij > Cc: linux-gpio@vger.kernel.org > --- > drivers/pinctrl/intel/pinctrl-intel.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c > index 8085782cd8f9..9fc5bba514ea 100644 > --- a/drivers/pinctrl/intel/pinctrl-intel.c > +++ b/drivers/pinctrl/intel/pinctrl-intel.c > @@ -1491,8 +1491,13 @@ static int intel_pinctrl_probe(struct platform_device *pdev, > if (IS_ERR(regs)) > return PTR_ERR(regs); > > - /* Determine community features based on the revision */ > + /* > + * Determine community features based on the revision. > + * A value of all ones means the device is not present. > + */ > value = readl(regs + REVID); > + if (value == ~0u) > + return -ENODEV; > if (((value & REVID_MASK) >> REVID_SHIFT) >= 0x94) { > community->features |= PINCTRL_FEATURE_DEBOUNCE; > community->features |= PINCTRL_FEATURE_1K_PD; > -- > 2.30.1 > -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Thu Mar 25 13:59:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 13:59:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101403.193933 (Exim 4.92) (envelope-from ) id 1lPQVV-0004Ix-I9; Thu, 25 Mar 2021 13:58:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101403.193933; Thu, 25 Mar 2021 13:58:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPQVV-0004Iq-F6; Thu, 25 Mar 2021 13:58:41 +0000 Received: by outflank-mailman (input) for mailman id 101403; Thu, 25 Mar 2021 13:58:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPQVU-0004Il-6x for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 13:58:40 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 18012a9c-991e-4cb0-b381-69f7b1718aeb; Thu, 25 Mar 2021 13:58:39 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1B49AADE3; Thu, 25 Mar 2021 13:58:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18012a9c-991e-4cb0-b381-69f7b1718aeb X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616680718; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eggkPcvzta0vcv8Trqr0tdVmX8SRvY7bcYSHQqXS+IM=; b=l6akMgklHLMjvaPEiP2Mtbj80oBYPRa58dqpEaUwgproSqh0WSV7yovHPn7z6n29VPlkQ3 MYUEN9mSRAyEqPf+Ot5UwK1GWDaHfKgR4DEHcrGgLl9Hqqp+mdH4qCSI3ZMLcv4m6HbZCR 2vnvjxigUzu35EWKSHp/C0geJSk2iug= Subject: Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation To: Andrew Cooper , George Dunlap References: <20210324164407.302062-1-george.dunlap@citrix.com> <20210324164407.302062-5-george.dunlap@citrix.com> <33f78891-c894-b41a-a1a3-82aac1f57b8d@suse.com> <0A187740-DB6E-486C-8B10-5207CE6A5D72@citrix.com> <7407cac8-c55d-0372-123b-39c9949e6ca5@citrix.com> Cc: xen-devel@lists.xenproject.org From: Jan Beulich Message-ID: Date: Thu, 25 Mar 2021 14:58:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <7407cac8-c55d-0372-123b-39c9949e6ca5@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 25.03.2021 10:37, Andrew Cooper wrote: > On 25/03/2021 09:04, George Dunlap wrote: >>> On Mar 25, 2021, at 7:57 AM, Jan Beulich wrote: >>> On 24.03.2021 17:44, George Dunlap wrote: >>>> --- a/CHANGELOG.md >>>> +++ b/CHANGELOG.md >>>> @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>>> - Named PCI devices for xl/libxl >>>> - Support for zstd-compressed dom0 kernels >>>> - Library improvements from NetBSD ports upstreamed >>>> + - x86_emulate: Support AVX-VNNI instructions >>>> + - x86_emulate: Expanded testing for several instruction classes >>> TBH both seem too minor to me to be mentioned here. If I was to pick >>> just one, I'd keep the former and drop the latter. >> It’s always quite difficult in these releases to help express to people exactly what’s happened. We’ve got over 1000 changesets — what have we been doing? If my star chart is correct, the latter represents nearly 1700 extra lines of codes in tools/tests/x86_emulator/predicates.c. It’s actually a reasonable chunk of code churn, which I think is worth highlighting. > > I agree with Jan.  New concrete instruction groups are useful for an end > user to read.  "We refactored some internal of a test harness" isn't, > especially when it would most likely be repeated every release. > > I'd drop the latter line and just keep the former. And then perhaps also not focus on the emulator, but merely on the fact that guests now can use that ISA extension (for which the emulator change is a [the only] prereq)? Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 25 14:29:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 14:29:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101408.193953 (Exim 4.92) (envelope-from ) id 1lPQzW-0007dU-5q; Thu, 25 Mar 2021 14:29:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101408.193953; Thu, 25 Mar 2021 14:29:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPQzW-0007dN-1k; Thu, 25 Mar 2021 14:29:42 +0000 Received: by outflank-mailman (input) for mailman id 101408; Thu, 25 Mar 2021 14:29:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPQzT-0007dI-Sp for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 14:29:40 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f3d8fb3d-0e3b-4dc8-a225-fbcfa01ea3c7; Thu, 25 Mar 2021 14:29:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3d8fb3d-0e3b-4dc8-a225-fbcfa01ea3c7 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616682578; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=cLFWo8v+9XmjouhJ0WzdR82KwgECDTWixOVz/Dd37vg=; b=SBOubSvPcAxTQ92pLHSI0qziS/jLHDyrhaPF560iWX+GvVJrQ+zlmKKL 9lWgwzdQGGCSwj0kZMXD8bUDZitJJzdf5cWfaQpcBdmhG/iB2wii1cPNY 0YcUC28W9AikeRaEnNVR2CLhPW5/cSmWoKUIIUBijxxeF665DmX5bjam7 E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: vCA057jv1l5U4u9s0Wue45GWoSQ2i4pHkUVVsPNtvUQQeYmvxW2KfDGO40OMLttlnTe0VDbwI5 H64PoPJLJnFrxxangIvr1nVfV+PF2Pk84gn3Dm/Cf/gcQbfo1A62RWouZOru3TwnNk7lcrKvHi W9qLvmWFveUBjwvOgXm+nJrDBFrUvdjEILBtWXT9BF42NwTkR8sBEbbPDcMbsptCleZn2/EobT H/nYsMqC8X4QmIrZv9hjy32F/AUWAHkODtQJ0awPNIBd+N+RovhUlJR2APrhDyTH3kHJRUSl5+ hw4= X-SBRS: 5.2 X-MesageID: 40007088 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:OFJC2qmPocpqnoq8cWgosZTuJw3pDfP2imdD5ilNYBxZY6Wkvu izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/NIyKMWOqqvWxSjhXuwIOhZnO7f6hDDOwm7zO5S0q 98b7NzYeebMXFWhdv3iTPWL/8O29+CmZrHuc7771NACT5ncLth6QARMHf4LmRTSBNdDZQ0UL qwj/AmmxOadX4abtu2CxA+NoCum/TxmI/7ehlDPhY76WC15g+A0qLwEBSTw34lIlBy6IolmF KlryXJop+Nntv+4R/a2m/V4f1t6aHc4+oGPuOgoIw4Lj3tjyyheYhuXaaT1QpF3d2H2RIRv/ Tn5zsmIsRv+1PdF1vF3SfF6k3b/xsFr1/k1FOCjnPoraXCNU0HIvsEv611WF/9ySMbzbVB+Z MO5U21nd5rKCmFuyLH693BR3hR5zKJiEtnq8E/pThiS4cEAYUhyrA3zQduP7orOjn104wjGP kGNrCm2N9mNWmXaH3UpQBUsbqRd0V2Gh+HR34LsdCO3w5Xm2hkz1AZyNZ3pAZ4yK4A X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40007088" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xm2DjEOtrF59Y5Y6/42VHaEzsmTTPZBr4lZmo9HupDmVfp+ooxcZfa7yWshlFgXomuTxj07wpvKYxYcT+7gJRB+ez0QN0Xe3OI18SOXldsBeXkxepf9VOeQkUxd0nGZ3eJApogBtS3Fd9RJDSv6n76BmA0YEeJV+sHwGMW01FffdZLup2BHHsC0gKDIcaI3eAA2W+0LxzIkyZbelLk4Tdt3Xg74eoE6MohvnYciKNPr7W19s4mFFJgxEfE8yxFu+hdmJF6lsqiuhYu5UeTWj6sZNxvqCmKG/tluixfa30GFNqpmWSYHxz7bdBrKnbn4gL9biWyHakTfHVcNK2ZMmmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cLFWo8v+9XmjouhJ0WzdR82KwgECDTWixOVz/Dd37vg=; b=cqtvyHNd/DYYmoUE2S2mysBzrEkE6Rm0tYTMFRhaC94xgYVqJAD7ENWKus8iI2fngdmPcS+quSkU0HNYUu6GB9oVi7rGKKj43lMB1S6zvY3t5Mc2eR5+GqkNLk9GYUvC2i95E5i7soNXXjqFsq+/c/yT1EpT4qDzJSmh1n7uMuQaX6PdkFOGVzCAUvH9aZ/rQJNseKMndheNaNZoKC8WTQEfi4C7vvJfrLHY4wV+gU9kH2yokvy15JIA8EahcFSAN5IhbjYfF89rz8F/eFK/h0oQqjshOVWIXrNcyxqhyLPa9T9jF88WSckTmQjI3dCiB+aO7xNX1AIVWPCRO3Qd7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cLFWo8v+9XmjouhJ0WzdR82KwgECDTWixOVz/Dd37vg=; b=uHHzNglrIEXIxhqhuV2DT/ea0SvLa1QZXeXH6lIu3Co98duvnituxX7UfEfQMouKDaEgvGCDMZmbN7UCrQZ7be3q5XPdSeVHpPoga0fOAVoE/QCpurJptGlNSO9MNNvlMZPAz6WYjJldYY05YP+W+jBdM4e4SxdiQDnLIxn0CPc= Subject: Re: [PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API To: Julien Grall , CC: Julien Grall , Ian Jackson , Wei Liu , Juergen Gross References: <20210325114243.12284-1-julien@xen.org> From: Andrew Cooper Message-ID: <7c3123e2-9dd3-b808-80c5-a13c5f1cc51a@citrix.com> Date: Thu, 25 Mar 2021 14:29:29 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210325114243.12284-1-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0320.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::20) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 63f259ce-12d5-4aa6-42b5-08d8ef9a6959 X-MS-TrafficTypeDiagnostic: BN6PR03MB2580: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:663; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +gy+47gVdT+gxq+fO9YENU+gdI5+tAzeEshEmjuwDcZBv7/BTSWiWdMZU3jSak1r/FO3IKng53Ux7VBZ5HQd6q5AxdTsYXryETMDveIn1FtSRMkesNCA9hcItftvDpTM1nm+UEdHQgBAQdg8CPuy/6uRU2ivLuvC9DtVh/73qt+VoWGsZ7F2FfX6efkjIRxmAoF9bSPdDdpNGDZWBk+cXXIZHcQFc+jI4dD7SjTGCPYlgX4NgAxhcI8ToaH0RbHpOQDhQh8AO5m6E58i+TzblN+8Ijj275pmPuRkx4mNLiKJMB0XGyE0fr81OWzn+U+0+1WtRGyEs5Ke/D+YQFecY6rXqfrzv/+kuZY30dZPlrksSPlvOfB0RDdWxLcO0MR0XurMmSW9jwAQjH9tRHYhZpBaLSosYKkKjY57gkLtF03pZxmj+7N7YldICTTho9j5QpjpEI5dWei3cohMlC0l2k0nl6kZhQYoMI8eyEX6gbHJobHpiSXR06ZC6tPG8LxHQkxoZuXRTUE+j9YmZcA1EgDWSuwBOqZjVXCc2otn/wSy4SnQ02CedqKALMmAthfnHy+7HqkSut+43Liprhzkyjz/dm0pOK0StJlTOTCGya0dN0biyh0HysKNTK+aZ6BHUBku9xrsqbCnMeUK1oyfyR7DMJs/6k8z9GLUd/d8CB3qKq/qrUMqDJT9LibQDO/Aeqq5ltq83FSzWHuD7Zpn/JZV48B+Krzw6/UiKUQp4xw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(31686004)(5660300002)(38100700001)(2906002)(4744005)(53546011)(956004)(6486002)(2616005)(316002)(478600001)(16576012)(8936002)(8676002)(66556008)(86362001)(31696002)(4326008)(26005)(16526019)(36756003)(54906003)(66946007)(66476007)(6666004)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WWVrOEY5SjVQRmtQMlEycUMzN09BRjdGY3ZMN3N0RnBqTnBrNnkxSlArRzNn?= =?utf-8?B?eVh3NEZKZXRGQU85MWdZQTh3cUgrcEZaRlNQK0lwbkhQZS9WVEJReXd6OWhQ?= =?utf-8?B?N2FvQUNFNngrY0RRVjdBaUhZWHZZekxjYzlkNmF5NWl6UGZiLzZpTFYybHRz?= =?utf-8?B?U3dFUGJHZm9RUWQ0QStCSDR4Q21iWGxhclpONExmVjRCanlUYlZQcjByV3k5?= =?utf-8?B?OWZXYzBwSXVEV1hhY252QkRiOUlmYmxqOEtUN2xYYk4xNFduc1l4VWVDU2Rw?= =?utf-8?B?VWswN09SdnE4dWhWN01KMkFwTDhvWTJtN1hXbFMyUzNZbEh0b1Z1VVRuQjZN?= =?utf-8?B?NXdVWkhxYVVRWmRuaURWV2tmQ0pKL2xGbkM1OElua0JWV0ZHd29iMlBZd3VY?= =?utf-8?B?VWFjcW9XVGo0K3ZkZFNRRzlIUFBVTDFrMFljUE1NQlhzZ3pjZzJkSFpYS0NN?= =?utf-8?B?d0pBaFNKZ1VwcUlPKzR1VVNEUkVtSVYxRDVNQmJ5dVZ1RHNPQk9CUjVRY0tm?= =?utf-8?B?WU1ZeXZiSjd6cHFKdlZtbkRhZlJmK2Myenlsc3AzOUFxdU84S05VN0FZZThK?= =?utf-8?B?VDVmYWpQRTdCWkIvdDNBdWprYkQ4WUdzTVVVL1NpWVFsYng3bG0wSWlDZHRG?= =?utf-8?B?Z0dhWXhzWjRXL0U5VU1wSUlCOW9Rcm1YYTcweXNzbWRnYTQ0Ylc2Nk80ekJW?= =?utf-8?B?dkh6MjV6Q3FGc2FUdVh2Z0RCdS9pVVBoRWpDYTNwUlMvSjBGcmR6UmUza0xE?= =?utf-8?B?UDE4YVJPV3ZQT3hMMmpZdkFzd2tsU0pwSUZ3b3BpSzd6UkcwK1FUczg1Qm1S?= =?utf-8?B?ZTJhWWFWQnRPNlFKeHNhdFNTcmdnTExJMFZBUm1DRGZZak45SW9sdWFmRTNP?= =?utf-8?B?dGsyV3lHL0IrT2V4NTZ4WVRiSlRCNk5jNVVvQXdtcCs2b0FtcGoxVUpuRjVG?= =?utf-8?B?a21iaWJveG9TcTRiMko1cGZpNGlWKzl3NURjOGZRUm04Z2p6QmJVT1FGdGhC?= =?utf-8?B?MDh2K0dKK2lkSml5R0dhdllRakNPa2VxMkcveDVrL0sxNE1yeE4reU9kdHd2?= =?utf-8?B?YjFma2VkZU44eEJwRUFxR3RxVFRLeTU3RjdlTzJUcktPUUhzSFN4S0VTbDlX?= =?utf-8?B?R3JvQmxmaHIvMVExSFdqSUprdnFmNURXRjMrc1BvQjJPVnc1Mmw3Y3hBVnJU?= =?utf-8?B?R2xmN255NjlXS2dMSFk3ckJRNmRhVjFrTnNITXg0WmJuT0prZm8zZ3dCSFlK?= =?utf-8?B?a3E5MVo4SWVTWEhqK2plU1I4dlp3cTlFNndFVjN0THQvdXRYYlJCKzdKL3ZQ?= =?utf-8?B?Mkh2a3QrWFRBc004ZUFOa1pjNjVQNy9RdVlmWHR5bHM2dFJvN2lSdW5IWlpW?= =?utf-8?B?b3BZZ2pnZVdZdnd5ejI5OEt0cFpManEvUTRtRDZHRjNlN0N3a2NBRmpUVjVp?= =?utf-8?B?ZGswZVRiL2RSbXlxbWNCRFphdm5TM084dlNwQjFsMVg5Vnkwc2VYcERNZHoy?= =?utf-8?B?blRxQlpXSzRiczRtS3FETDQwOWRnUU4rb1pVKzBlQzlGb0dhUitwNVhzTnRX?= =?utf-8?B?RVR0blNKeFpNNnp3cDhCbFlrMUsxeFVlaGkrZHZyUXVHOFhweDhOdG0xOWFH?= =?utf-8?B?S1lnVDJtMVRHUW82TkEwMHEwQ1pIUWd1NWhkZjNoTE0zemZhaXBTdlR0aEwv?= =?utf-8?B?NlhuYUNkaExNZkhDcGZJVmdvYUU2VjdVcmZwcllFVG1OaWtDRkVKMThnUnk2?= =?utf-8?Q?lFfQx01tpTLIjpuR27VPbjwuYGqnljthp6Hldqp?= X-MS-Exchange-CrossTenant-Network-Message-Id: 63f259ce-12d5-4aa6-42b5-08d8ef9a6959 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 14:29:34.7033 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rObLEV21j5fdqzzlj2keE8mEcl/gvVJLjYHQ4aHQYZSeaet3fGjx7dVk/JEa234opqPVybMQ4+Vo1VCBIcGpvkGNToH0hG7F0gMcQCL/lqU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2580 X-OriginatorOrg: citrix.com On 25/03/2021 11:42, Julien Grall wrote: > From: Julien Grall > > The last use of the compat foreign API was dropped in commit > 38eeb3864de4 "tools/xenstored: Drop mapping of the ring via foreign > map". > > Therefore, we don't need to define XC_WANT_COMPAT_MAP_FOREIGN_API. > > Signed-off-by: Julien Grall Oops sorry. Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Thu Mar 25 14:49:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 14:49:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101413.193971 (Exim 4.92) (envelope-from ) id 1lPRIB-0001KZ-UF; Thu, 25 Mar 2021 14:48:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101413.193971; Thu, 25 Mar 2021 14:48:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPRIB-0001KS-QN; Thu, 25 Mar 2021 14:48:59 +0000 Received: by outflank-mailman (input) for mailman id 101413; Thu, 25 Mar 2021 14:48:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPRIA-0001KN-9n for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 14:48:58 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0b1bc409-80ce-4281-8ed1-f916497b74dc; Thu, 25 Mar 2021 14:48:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b1bc409-80ce-4281-8ed1-f916497b74dc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616683735; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=DmPO0IYbysDQk+7I/l/pbj2KdotOoj/wQgdLy2IY/o4=; b=iZaNr2CqnIqO29wZk3BgS4GVHMOatjIqWL7qJvFweXnbYEmCCEDzZBMw UWzJCYtmTjg58OUkC+jLDO6uYdddYvHQvQTSxve/31MeM5XQEyIv5NQan Zfm+AUZlkN90DczOZjWwqOVJyVnCj1hHz1rp361j2YZcskTkqr73GO/6n k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: pU4dL8Svev6B7U5xwFY3F6IGluYJb9n3gO5DRtFVVUzNsNbDKP+3ZFtDU94lzFYYCUtNDtJ/BG 8kERGLwegQslzRrKvDvOcGPiTGg2Qm8wE8Urrj0ffekzvFzLfMZhL9709EHMH/z2hk7jHRIgwv 5c9HFOE8tXPmcBtra1ZTUomCIDS1hfAa1b1xXf8GQx0cfXU0qFQMlzy6Jdk7uNdPjh6/jI0pjt 8+HEfQIXdr0QenI+w8cyKErrg0YQ1nHHExZvix0IGSdNO+IquAHdoVDVF1NS/U5zhLj4CYjrHc kVQ= X-SBRS: 5.2 X-MesageID: 40134913 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:6HKZT6p6/7mtZ6COSFF0wVoaV5u4KtV00zAX/kB9WHVpW+SivY SHgOkb2RjoiDwYRXEnnpS6NLOdRG7HnKQa3aA4Bp3neAX9omOnIMVZ7YXkyyD9ACGWzIFg/I 9aWexFBNX0ZGIXse/T/BS4H9E8wNOO7aCvgqPkw21wSBxxApsB0y5SIG+gYytLbSNBAoc0E4 fZy8pcvjy7eWkWaMPTPAh5Y8HoodrXmJX6JSMXHhJP0nj1sRqEyp7fVyKZ0BAXTi9Vzd4ZkF TtvgTl6syYwpSG4zDG0Wu71eUzpPLAzZ95CNWImowpLFzX+3qVTaBAf5HHgzwvuuGo7z8R4a nxijMtJd565X+UXkzdm2qU5yDa3Dwj62DvxDaj6BOJy6GJJ0NZerh8rLlUfRfD500rsMsU6t Mx40uju4dKFhSFpSzh5rHzJmBXv3Cpqnkvm/N7tQ0nbaIibtZq3Osi1XIQOpIBECXm0ZsgAe ljAerNjcwmD2+yXjT3uHJiz8erWWl2NhCaQlIassjQ6DROmmtlpnFoiPA3rzMlztYQWpNE7+ PLPuBBk6xPdNYfaeZYCP0aScW6J2TRSXv3QS2vCGWiMJtCF2PGqpbx7rlwzvqtYoY0wJw7n4 mEeE9EtEYpEnieSfGm7dluyFTgUW+9VTPixoV1/J5ioIDxQ7LtLGmqVE0uqc29uP8Sa/erGs qbCdZzObvOPGHuEYFG00nVQJ9JM0QTV8UTp5IVQFSLjsXXKpD7l+DSffrJTYCdUwoMayfaOD 8uTTLzLMJP4gSAQXnjmiXcXHvrZwje8PtLYe3n1tlW7LJIGpxHswATh1j8zNqMMyd+vqs/e1 Y7BLvml6i8tFSn5Gqg1RQsBjNtSmJupJnwWXJDogEHd2nud6wYhtmZcWdOmFyKOwF4VMGTNA JEvVx49eaWIvWrtG4fIuPiFljfo2oYpXqMQZtZsLaE/93ZdpQxCYtjfrdwGwXNHxlcgh1rt2 9HVQ8BSibkZ3DToJTgqKZRKPDUdtF6jgvuC9VTs2jjuUKVotxqemEWRAe0UcmcgR8nQh1dgl EZyd5ZvJOw3RKUbUcviuUxN1NBLECaGqhPAgi+aIJIobzzYw1rQWCWhTuVtgErdgPRhjYvr1 2kCRfRVeDAA1JbtHwd6Krs/V9uXki2fk57aBlBwMZAPFWDnkw2/f6AZ6K13WfUV0ALxfsFNi rZJREIJBl1+tyx3BmJuTqLGHk83K8yNujFALlLScCU5lqdbKmz0Y0WFf5d+5hocO30uugQSO SFZku7Kij7B+5B4X3iml8VfA1P7F8qnvPj1Ee7sCyW3HsjDeHTJ1ojbbcBON2Y53XlQfHN8J gRt6NAgcKAdkHKLviBwuXrShQGDDX5i2u/VfspppBZprhajso6I7DrFR/zkEha1xA/JvrunE wQQK5H8KnMU7UfCvA6SmZ8xB4Vj9yBI0sgjxzuDsI/dV8riWXHP9nh2cu+lZMfRmmArhD3I1 +R7ml0+OrERTKK0dcheugNCFUTTEg383J5+uyeM6XWFQWxbulGuH63KGW0frMYaK+LH9wr31 tHyuDNu++cbCzj3g/M+RN9P6JV6m6iBfqIPzjkI58Az/WKfXKWgqWr58avjDD4DRuDAn5o+r FtRAg3dcRMij4rkYst9DO9I5aH+34Yrw== X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40134913" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E5Od/h1SDp1KtDqywZc+BWYDMVXh/JOP8Ply4EmSH+P32APZNww8iTc4OV8dkQbWHahbBjjEE5UJ8MiNdGnmRqbvxw+Kgrp3Qr3rTHoHE7FCv73rkIUbHU58cOYKAssQW7611c6ELIkpvuNHEY8xNbYc6rf16yJKg66Iplq6kmUm/Ci80ywTAA3q8FYeQPlb5Um4khCARdATIQaGTWhqFTqPBM1YTia2kWB6xkZfC2ldaSZBgI8FrTfgK17zS3WpwyDK5duNMVJnsypNk8NWuf9GzeikQCOCH/yjCmDqdPBczGhtGvi9qbJNZt3zd/lGC17Fgp2pqjznhznaNr85uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mm2+92UHlWb6cKFDUH66BEx+levN4UIjBRdIjEAod1Y=; b=LagvkRff2n+tTyeHfB1OcGF1q/gwMhGUjsqK/3w5Hpx70H9w4iloPlar/srtmmq01e5Xzeqeyyfkva4vvb6VnvK1b5sFEuV9D/RFQ/aLEy5L9g1h28eypEIyzKGbbXyeIm+ntEZFzFXeXa7PAchXgzXzET7/VOB/AOghWcyz1SFA0FqKN/uLJfM1xsP7jW0dJ7VWA+g8g9NN+2Jzne+dc3H/I7cLl/kG4JU969rtf1G61OzDMv5lopXEYA/GKcyuVMSzaJ0OY1pcU+w1dsvhrN48nbWbhXN7isUNXmLAWbXXodAjZq1nQbZuLwdaex9mSxFxOve0u0iJwL1PoFfWZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mm2+92UHlWb6cKFDUH66BEx+levN4UIjBRdIjEAod1Y=; b=XOMC04QwS1P9gKy7nKSE4xT4/ek7Ms/hZYI+Ug6MV7Q2pEOjIFKOJT/Sdhi8To0OfOkgHwXHuHa0I702KqEJ1wXiUQWeS3q5YQ8ZhKrR4ui2XPQiIxO9O515R5aSP/dF91pWd62BeAg76EPVaAQ2wFcFFafpI1K5BxEn0rj5BjM= Date: Thu, 25 Mar 2021 15:48:43 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Boris Ostrovsky CC: , , , , Subject: Re: [PATCH RESEND] x86/vpt: Replace per-guest pt_migrate lock with per pt lock Message-ID: References: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> <1616619905-640-2-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1616619905-640-2-git-send-email-boris.ostrovsky@oracle.com> X-ClientProxiedBy: MRXP264CA0038.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:14::26) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f40fd728-7593-4a1c-d7e7-08d8ef9d1aa7 X-MS-TrafficTypeDiagnostic: DS7PR03MB5542: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YCLU/r9EopfyQ46+vZHxkEuGCzXaYp1b8/RKrNO6C8tfeRY+h2KADVgy/TZRXHHFHDFnDNHMm5lwP4jmsKjJn00AtWH17eNTD8b/5lzcBuCl3QjEpneLl5Wl2DVSZSRJ9ljZSgxw+uiVVfuqSTGEMU6hc3SC5V/U9S/1zMTLykHSTM2XGl0jjv6PBz4GWexWVrNg9gHOCYtrUOlhslxZPnfTGqHc21amII59UogSUWIFaITrwqnmjksC9mxdIr2cvGsVvU4VLsHvmbU52/3QH2ZmnEivSG68A5iy2gT5Vmbll6iPLHhgzqiPh+0WHYqYihL+7OLd2t7F8t5dHyp/zDA7Jq8xWFCU8Wsb99sZjV+VwtUXdvlVZlfzdwFaaQkhk+y0GvFhc6ovXyzUBcjhV8b+DMacOmQnQmxChVdw9mbf23302o7QuZcOXbqZ9BWmJrDqFmu6r1j0XylW6TvxnrZW1RV+XJ1SJR3Af04OzLN9SYjkp0bjB3QXCcXvHv/eNpfj5+G+wf3H1BXfcEcN0aQ3Jb1TgBBwCkf9gsAOSeBukD26mQowz/SLmrk4MjLN5e5ekJAycdKj2JYqTmTBUepbsdKH3b/Cnc1lkZX6Twpu8BPuQ3GIQVzSXX96j8RmS7M2pIjhutDr3BIql61inr4SMHdquWIGjbbW5v0Pbn8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(376002)(396003)(346002)(39860400002)(136003)(366004)(6916009)(478600001)(186003)(16526019)(316002)(4326008)(26005)(83380400001)(956004)(9686003)(86362001)(33716001)(85182001)(6486002)(38100700001)(30864003)(8936002)(66556008)(66476007)(6496006)(2906002)(8676002)(6666004)(66946007)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bHBvRm56TytvNGxjVU1MbjZONnBIbWd6SUs1N0xnOFFrMURWMEp6NGo1Vm0x?= =?utf-8?B?Z2V5R2FIYmtvUTZzVEt4TjAzRERBVWZ4UUkwUFNHZjZ1UW43TXBLTDlqRmlH?= =?utf-8?B?bWZNWlVlNjAwenBxTHJvT1c1RWloVjVIQ3JndTZWV3JIamNDTFp6bEhyalhs?= =?utf-8?B?S1d3UmlVZXpNWnhlREVRMlFIenpDWm9adU1RWWVWa3ZTL3B4VW5nYWFYWkw5?= =?utf-8?B?OC82Ni91d1cxdkF6cDdWVkN1akZKbU9ZblFzeUM4K3BqamVHbWcvOTRtTE5x?= =?utf-8?B?eld3KzYyZjZNakM2QmpIRnJydUtGUkpEbmRxb0JSUllzSWwrMTl5cTNZeGNT?= =?utf-8?B?ZUpPa2N4ZUZsS0RwekVLWjlLNFh3R3BTSTVDc3MyMytLTmVTaE5YbG9SYk95?= =?utf-8?B?OWFkNk5VbEYvbTdxd3V5R1FSR040RFpKNFM4L2ovb1IrN0dwd21SYzZkOUpT?= =?utf-8?B?RitzQlArZTNVTFhucXVOZWg5YXpnRWcvSlV6VlV1Y0c5cTJLdGczb1JNaEpw?= =?utf-8?B?L2lSNzRidXVJV2dwOU96THdJT1ZHVzR3K1FIdldWUFcybXBqbXFBZDRtM2dz?= =?utf-8?B?TXZkcWw3UWxTZDljeXR1ZFZWZ0hYNVNrL3p6cUJGVkRGRlQxeEtSSTJVcFFh?= =?utf-8?B?SWRDcDk2blY4a2pMN2l0Q3UyZGtEQ3F2eVArRFRTSWZYNWNNWDZOVVR0dmJi?= =?utf-8?B?a2M5b3hBNUFYeWNZbGdldVlDK0N6eDBtc2NBZUF2QklwQXQwTFlla2dlRzRs?= =?utf-8?B?TEVVeEtQenR1OGdTUkdjN1cxeWVQOTAzamxBWHovREpVTHpibnlvN2VIRzRL?= =?utf-8?B?VTdmVDhkdTQ2UmVBS1VvR0RPSi9ZQmhrd3NheUd3VDYrbVZMajZqTEwwZG1R?= =?utf-8?B?TXQ4aUM0MEYxVThFZFlUMzEzOXlxSlBMUWtCYzNQb2VvV0JsRWlTZStHdWNW?= =?utf-8?B?VmtWM0tyVkJvei9UYzlhKzdvcWFvQW5NNExXN293WGloemVQYlZKdmwzbmZW?= =?utf-8?B?T2M0RlBoNnhPZ3RjcjRkUGJnY29rS1NrRXVseDVzcFQ0MjBBbDBtOVBuOTNt?= =?utf-8?B?MGNKTVZidVl2bnJ4ZE5ZSktkZER0RFdSRlluVlJVR3Bqc1hPM1hYb2o2WGRs?= =?utf-8?B?SWF3aCs3dXlwTHlJNVpMazMwbFl6RS9sQWFNczh2SnMzNXdaVFdSMEtwMUtH?= =?utf-8?B?VlJDbXlEY2lKVDVIbXFqRHZsbS9rMlFnaExCRTJGTGI0RW9va3pYUUF6anNS?= =?utf-8?B?SmtJRUNSbXhYbndqYVlWSlgvSWtCZy8zcWJiS0xEUEM4clZ3S1UzVzNtcmY3?= =?utf-8?B?QjVaWUJCYlBlY0xaQ29DVy92LzFpbkRLb0FwcFUzNElpbWUyeU1yUk12YTdX?= =?utf-8?B?dzZTa1c1bE8rWlMxeEtZaDArR2Y1eFZLblY5WE5rbGwzdWQxNU92Vmp1ZDRt?= =?utf-8?B?RWZEL0ozV2ZWV3RKMlEraXFDNlY2aDBnWFJzQ05BOXhzcFFwSVhsazBMVDVr?= =?utf-8?B?OEhKaGpTN2g2WEZhdEcrSEpZSE9NdHlQY3lmWi9oZFBDQXNMd090aE9IR0ww?= =?utf-8?B?cUc2a3lER2NLc3FEdkUrb3dDbzhyWm9kOW0xalBSZmdIaklqTnovTjNtanRF?= =?utf-8?B?MUw2NDcxRUFnYWs4WjRTOHE1QWVBbS9MVTEzRGY4Nm5OU003WHVjQkQ1WHh1?= =?utf-8?B?R2VDMk1VTDgxSFc2ancwMVBTUXhGejRmQmY3bytJOXVsZkl1R1RKWUE3WU5a?= =?utf-8?B?K2tJOWxQSCtaZ3U3NmVYd0JVTk5zOVJqYnRYMWJMWE83TjgxVGpkVTA4RlUy?= =?utf-8?B?dEtNcEdndS9PVDlQN3MwZz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: f40fd728-7593-4a1c-d7e7-08d8ef9d1aa7 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 14:48:51.0798 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Neg4smowrsBK+sdmHRQClxractcy4A5ziPaBTcbgYSGdD6t+YcK49Zajd8xwum6NZRk11YMTsKrl6zw0RwxewQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5542 X-OriginatorOrg: citrix.com On Wed, Mar 24, 2021 at 05:05:05PM -0400, Boris Ostrovsky wrote: > Commit 8e76aef72820 ("x86/vpt: fix race when migrating timers between > vCPUs") addressed XSA-336 by introducing a per-domain rwlock that was > intended to protect periodic timer during VCPU migration. Since such > migration is an infrequent event no performance impact was expected. > > Unfortunately this turned out not to be the case: on a fairly large > guest (92 VCPUs) we've observed as much as 40% TPCC performance regression > with some guest kernels. Further investigation pointed to pt_migrate > read lock taken in pt_update_irq() as the largest contributor to this > regression. With large number of VCPUs and large number of VMEXITs > (from where pt_update_irq() is always called) the update of an atomic in > read_lock() is thought to be the main cause. Right, seems like a very plausible analysis. Since I suspect most (if not all?) of the performance regression is from the read_lock in pt_update_irq I think we can remove that without doing such a big change to the current locking logic, and instead merging part of the logic that you detail in the cover letter without moving to a per-timer lock. > Stephen Brennan examined the locking pattern and suggested using a > per-timer lock instead. This lock will need to be held whenever there is > a chance that pt->vcpu field may change (thus avoiding XSA-336 > condition). > > Suggested-by: Stephen Brennan > Signed-off-by: Boris Ostrovsky So while I think this is indeed a working solution, I'm not convinced we require a per-timer lock, I think we can find some middle ground using both a per-domain rwlock and the more fine grained per-vcpu lock. Basically for type 1 accesses (pt_vcpu_{un}lock) I think we can safely drop the read_{un}lock call, and remove the performance bottleneck while slightly adjusting the functions that modify the per-vcpu timer lists to take the per-vcpu locks when doing so. I've tried to convey that in the comments below, while also pointing out some suitable places where comments can be added based on the text from your cover letter. Overall this should result in a smaller patch that will be both easier to review and argue in terms of inclusion into 4.15. > --- > xen/arch/x86/emul-i8254.c | 2 + > xen/arch/x86/hvm/hpet.c | 1 + > xen/arch/x86/hvm/hvm.c | 2 - > xen/arch/x86/hvm/rtc.c | 1 + > xen/arch/x86/hvm/vlapic.c | 1 + > xen/arch/x86/hvm/vpt.c | 122 +++++++++++++++++++++++------------------- > xen/include/asm-x86/hvm/vpt.h | 9 +--- > 7 files changed, 74 insertions(+), 64 deletions(-) > > diff --git a/xen/arch/x86/emul-i8254.c b/xen/arch/x86/emul-i8254.c > index 73be4188ad41..d83e727ff35e 100644 > --- a/xen/arch/x86/emul-i8254.c > +++ b/xen/arch/x86/emul-i8254.c > @@ -478,6 +478,8 @@ void pit_init(struct domain *d, unsigned long cpu_khz) > if ( !has_vpit(d) ) > return; > > + spin_lock_init(&pit->pt0.lock); > + > spin_lock_init(&pit->lock); > > if ( is_hvm_domain(d) ) > diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c > index ca94e8b4538c..c7f45412164e 100644 > --- a/xen/arch/x86/hvm/hpet.c > +++ b/xen/arch/x86/hvm/hpet.c > @@ -734,6 +734,7 @@ static void hpet_set(HPETState *h) > h->hpet.timers[i].cmp = ~0ULL; > h->hpet.comparator64[i] = ~0ULL; > h->pt[i].source = PTSRC_isa; > + spin_lock_init(&h->pt[i].lock); > } > } > > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index e7bcffebc490..b60549a12a33 100644 > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -658,8 +658,6 @@ int hvm_domain_initialise(struct domain *d) > /* need link to containing domain */ > d->arch.hvm.pl_time->domain = d; > > - rwlock_init(&d->arch.hvm.pl_time->pt_migrate); > - > /* Set the default IO Bitmap. */ > if ( is_hardware_domain(d) ) > { > diff --git a/xen/arch/x86/hvm/rtc.c b/xen/arch/x86/hvm/rtc.c > index 3150f5f1479b..6289d972bb67 100644 > --- a/xen/arch/x86/hvm/rtc.c > +++ b/xen/arch/x86/hvm/rtc.c > @@ -842,6 +842,7 @@ void rtc_init(struct domain *d) > } > > spin_lock_init(&s->lock); > + spin_lock_init(&s->pt.lock); > > init_timer(&s->update_timer, rtc_update_timer, s, smp_processor_id()); > init_timer(&s->update_timer2, rtc_update_timer2, s, smp_processor_id()); > diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c > index 5e21fb4937d9..8413e41a7a80 100644 > --- a/xen/arch/x86/hvm/vlapic.c > +++ b/xen/arch/x86/hvm/vlapic.c > @@ -1626,6 +1626,7 @@ int vlapic_init(struct vcpu *v) > vlapic_reset(vlapic); > > spin_lock_init(&vlapic->esr_lock); > + spin_lock_init(&vlapic->pt.lock); > > tasklet_init(&vlapic->init_sipi.tasklet, vlapic_init_sipi_action, v); > > diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c > index 4c2afe2e9154..36d4699a5de6 100644 > --- a/xen/arch/x86/hvm/vpt.c > +++ b/xen/arch/x86/hvm/vpt.c > @@ -153,32 +153,16 @@ static int pt_irq_masked(struct periodic_time *pt) > return 1; > } > > -static void pt_vcpu_lock(struct vcpu *v) > -{ > - read_lock(&v->domain->arch.hvm.pl_time->pt_migrate); > - spin_lock(&v->arch.hvm.tm_lock); > -} > - > -static void pt_vcpu_unlock(struct vcpu *v) > -{ > - spin_unlock(&v->arch.hvm.tm_lock); > - read_unlock(&v->domain->arch.hvm.pl_time->pt_migrate); > -} I would keep those functions, and just remove the read_{un}lock call from them. The places where pt_vcpu_{un}lock is used matches the type 1 accesses listed on your cover letter, so I would add as a prefix to the functions: /* * Functions which read (maybe write) all periodic_time instances * attached to a particular vCPU use this locking helper. * * Such users are explicitly forbidden from changing the value of the * pt->vcpu field, because another thread holding the pt_migrate lock * may already be spinning waiting for your vcpu lock. */ > - > static void pt_lock(struct periodic_time *pt) > { > - /* > - * We cannot use pt_vcpu_lock here, because we need to acquire the > - * per-domain lock first and then (re-)fetch the value of pt->vcpu, or > - * else we might be using a stale value of pt->vcpu. > - */ > - read_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); > + spin_lock(&pt->lock); > spin_lock(&pt->vcpu->arch.hvm.tm_lock); > } > > static void pt_unlock(struct periodic_time *pt) > { > - pt_vcpu_unlock(pt->vcpu); > + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); > + spin_unlock(&pt->lock); > } I would leave the rwlock on this pair of functions, and add the following comment as a prefix: /* * Functions which want to modify a particular periodic_time object. * These users lock whichever vCPU the periodic_time is attached to, * but since the vCPU could be modified without holding any lock, they * need to take an additional lock that protects against pt->vcpu * changing. */ > > static void pt_process_missed_ticks(struct periodic_time *pt) > @@ -228,7 +212,7 @@ void pt_save_timer(struct vcpu *v) > if ( v->pause_flags & VPF_blocked ) > return; > > - pt_vcpu_lock(v); > + spin_lock(&v->arch.hvm.tm_lock); > > list_for_each_entry ( pt, head, list ) > if ( !pt->do_not_freeze ) > @@ -236,7 +220,7 @@ void pt_save_timer(struct vcpu *v) > > pt_freeze_time(v); > > - pt_vcpu_unlock(v); > + spin_unlock(&v->arch.hvm.tm_lock); > } > > void pt_restore_timer(struct vcpu *v) > @@ -244,7 +228,7 @@ void pt_restore_timer(struct vcpu *v) > struct list_head *head = &v->arch.hvm.tm_list; > struct periodic_time *pt; > > - pt_vcpu_lock(v); > + spin_lock(&v->arch.hvm.tm_lock); > > list_for_each_entry ( pt, head, list ) > { > @@ -257,7 +241,7 @@ void pt_restore_timer(struct vcpu *v) > > pt_thaw_time(v); > > - pt_vcpu_unlock(v); > + spin_unlock(&v->arch.hvm.tm_lock); > } > > static void pt_timer_fn(void *data) > @@ -318,7 +302,7 @@ int pt_update_irq(struct vcpu *v) > int irq, pt_vector = -1; > bool level; > > - pt_vcpu_lock(v); > + spin_lock(&v->arch.hvm.tm_lock); > > earliest_pt = NULL; > max_lag = -1ULL; > @@ -348,7 +332,7 @@ int pt_update_irq(struct vcpu *v) > > if ( earliest_pt == NULL ) > { > - pt_vcpu_unlock(v); > + spin_unlock(&v->arch.hvm.tm_lock); > return -1; > } > > @@ -356,7 +340,7 @@ int pt_update_irq(struct vcpu *v) > irq = earliest_pt->irq; > level = earliest_pt->level; > > - pt_vcpu_unlock(v); > + spin_unlock(&v->arch.hvm.tm_lock); > > switch ( earliest_pt->source ) > { > @@ -403,7 +387,7 @@ int pt_update_irq(struct vcpu *v) > time_cb *cb = NULL; > void *cb_priv = NULL; > > - pt_vcpu_lock(v); > + spin_lock(&v->arch.hvm.tm_lock); > /* Make sure the timer is still on the list. */ > list_for_each_entry ( pt, &v->arch.hvm.tm_list, list ) > if ( pt == earliest_pt ) > @@ -413,7 +397,7 @@ int pt_update_irq(struct vcpu *v) > cb_priv = pt->priv; > break; > } > - pt_vcpu_unlock(v); > + spin_unlock(&v->arch.hvm.tm_lock); > > if ( cb != NULL ) > cb(v, cb_priv); > @@ -450,12 +434,12 @@ void pt_intr_post(struct vcpu *v, struct hvm_intack intack) > if ( intack.source == hvm_intsrc_vector ) > return; > > - pt_vcpu_lock(v); > + spin_lock(&v->arch.hvm.tm_lock); > > pt = is_pt_irq(v, intack); > if ( pt == NULL ) > { > - pt_vcpu_unlock(v); > + spin_unlock(&v->arch.hvm.tm_lock); > return; > } > > @@ -464,7 +448,7 @@ void pt_intr_post(struct vcpu *v, struct hvm_intack intack) > cb = pt->cb; > cb_priv = pt->priv; > > - pt_vcpu_unlock(v); > + spin_unlock(&v->arch.hvm.tm_lock); > > if ( cb != NULL ) > cb(v, cb_priv); > @@ -475,12 +459,34 @@ void pt_migrate(struct vcpu *v) > struct list_head *head = &v->arch.hvm.tm_list; > struct periodic_time *pt; > > - pt_vcpu_lock(v); > + spin_lock(&v->arch.hvm.tm_lock); > > list_for_each_entry ( pt, head, list ) > migrate_timer(&pt->timer, v->processor); > > - pt_vcpu_unlock(v); > + spin_unlock(&v->arch.hvm.tm_lock); > +} > + > +static void __destroy_periodic_time(struct periodic_time *pt, bool locked) > +{ > + /* Was this structure previously initialised by create_periodic_time()? */ > + if ( pt->vcpu == NULL ) > + return; > + > + if (!locked) Coding style: missing spaces. > + pt_lock(pt); > + if ( pt->on_list ) > + list_del(&pt->list); > + pt->on_list = 0; Please use false here, since this is a boolean field now. > + pt->pending_intr_nr = 0; > + if (!locked) > + pt_unlock(pt); > + > + /* > + * pt_timer_fn() can run until this kill_timer() returns. We must do this > + * outside pt_lock() otherwise we can deadlock with pt_timer_fn(). > + */ > + kill_timer(&pt->timer); > } > > void create_periodic_time( > @@ -497,9 +503,16 @@ void create_periodic_time( > return; > } > > - destroy_periodic_time(pt); Why not keep the call to destroy_periodic_time here? > + spin_lock(&pt->lock); > > - write_lock(&v->domain->arch.hvm.pl_time->pt_migrate); And the write lock here together with the pair of locks that you add around the addition to the vCPU list. Those would better use pt_vcpu_{un}lock if you agree to keep those helpers. > + if ( pt->vcpu ) > + { > + spin_lock(&pt->vcpu->arch.hvm.tm_lock); > + > + __destroy_periodic_time(pt, true); > + > + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); > + } > > pt->pending_intr_nr = 0; > pt->do_not_freeze = 0; > @@ -543,33 +556,22 @@ void create_periodic_time( > pt->cb = cb; > pt->priv = data; > > + spin_lock(&pt->vcpu->arch.hvm.tm_lock); > + > pt->on_list = 1; > list_add(&pt->list, &v->arch.hvm.tm_list); > > + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); > + > init_timer(&pt->timer, pt_timer_fn, pt, v->processor); > set_timer(&pt->timer, pt->scheduled); > > - write_unlock(&v->domain->arch.hvm.pl_time->pt_migrate); > + spin_unlock(&pt->lock); > } > > void destroy_periodic_time(struct periodic_time *pt) > { > - /* Was this structure previously initialised by create_periodic_time()? */ > - if ( pt->vcpu == NULL ) > - return; > - > - pt_lock(pt); > - if ( pt->on_list ) > - list_del(&pt->list); > - pt->on_list = 0; > - pt->pending_intr_nr = 0; > - pt_unlock(pt); > - > - /* > - * pt_timer_fn() can run until this kill_timer() returns. We must do this > - * outside pt_lock() otherwise we can deadlock with pt_timer_fn(). > - */ > - kill_timer(&pt->timer); > + __destroy_periodic_time(pt, false); I'm not convinced you need the __destroy_periodic_time helper, I'm not sure I see which benefit it has over the previous approach. You end up reading pt->vcpu without holding any lock in the destroy case, just like before. > } > > static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) > @@ -579,15 +581,25 @@ static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) > if ( pt->vcpu == NULL ) > return; > > - write_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); As suggested above, I think you could leave the usage of the pt_migrate lock together with your addition of the per-vcpu vpt locking. As this is the most obvious function that changes the vcpu field I would add: /* * Functions which want to modify the vcpu field of the vpt need to * hold the global lock (pt_migrate) in write mode together with the * per-vcpu locks of the lists being modified. Note that two vcpu * locks cannot be hold at the same time to avoid a deadlock. */ Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Mar 25 15:07:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 15:07:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101419.193983 (Exim 4.92) (envelope-from ) id 1lPRZq-0003Ip-KM; Thu, 25 Mar 2021 15:07:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101419.193983; Thu, 25 Mar 2021 15:07:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPRZq-0003Ii-GP; Thu, 25 Mar 2021 15:07:14 +0000 Received: by outflank-mailman (input) for mailman id 101419; Thu, 25 Mar 2021 15:07:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPRZp-0003IN-1Z for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 15:07:13 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 11f84eb4-e3bf-4ebe-9f7b-a8e7b1b50e52; Thu, 25 Mar 2021 15:07:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11f84eb4-e3bf-4ebe-9f7b-a8e7b1b50e52 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616684831; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=sf4Auicmds1fUQbk3KFvdJd2F/zuUn0aFuSvA8OcGwg=; b=WrvaWAI+ASju1AymthaDgNn9LyvyqBtHVVlSbfG1jXkZ827QQ3kqMMyq Uyq+dYtN7+8G356Mn0LGsx+mhmbG08DO4c//UGQ+KbIzo4AQ46J98Kefl EVWcnbpaBQkZ3tja754DzEJu4DoyZ93MbEU+8dbccz3l7OUx5HCX0ZSPD M=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: sEZW6+nMsb9zTCl4Zq46vMkCce9XQ4lh7sakvMhk1/8I2HiJeA7q92L7VJhflcP1Uu4znQcjh9 6LlAuX5NRKv1bS7EwcEHYV4RPUgqpqtJagZ/47jWbki4pyXXSP9G0dQaCirMxyd039DdntwHgr APtl/dChnemoVjqi9bkSJjq3v1RBz4DopzNlo30VjMAliWWB9wdG22ATNMBVQgOfMmtxSnpIkk LKqA+iomKOejc39gVtlEbwjfvw5JuDT1QEncRFDZcjeTo6ciwTb2pjieCPnbkgAKmHn06rXy3d Zr0= X-SBRS: 5.1 X-MesageID: 40286511 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:hpklwKp6+avSTkTGTVlFxYIaV5uiKtV00zAX/kB9WHVpW+SivY SHgOkb2RjoiDwYRXEnnpS6NLOdRG7HnKQZ3aA4Bp3neAX9omOnIMVZ7YXkyyD9ACGWzIRg/I 9aWexFBNX0ZGIQse/T6gO1Cstl5dGB/ryhi+u29QYXcShBQchbnmREIyycFVB7QxQDIJI/Go aV6MYvnUvbRV08aMOnCn4ZG9XSvtGjruOtXTcqJT4CrDOPgzSh9aLgH3Gjsis2fjtTzd4ZgA /4uiPj4KHLiZCG4z/ak1Te9pFH3Obmo+EzfPCkrugwBnHShh2zZIJnMofy8QwdhO208l4lnJ 3tjn4bTqJOwkjcdG20vhfhsjOIuFlB11bYxVCVmnflq8DiLQhKcvZpv55TcRfS9iMbzbNB+Z 9LxG6Qut52Ch7NjU3Glrz1fixqjUa9rD4el/cShRVkIO4jQYJWxLZ+wGplVLM7WA7q4oEuF+ djSOvG4uxNTF+cZ3fF+kFy3d2FRB0Ib1i7a3lHnvbQ/yldnXh/wUdd7tcYhG08+JU0TIQBz/ jYM55viKpFQqYtHOxALdZEZfHyJn3GQBrKPm7XC0/gDrs7N3XErIOyx7kp+uewetgtwIEpkJ rMFHNU3FRCOn7GOImr5tlm4xrNSGKyUXDG0cdF/aV0vbX6Wf7lKiuGRFcyk9axovkWD8HBMs zDe65+MrvGFy/DCIxJ1wrxV915Mn8FSvAYvd49RhaPr6vwW8/Xn92eVMyWCKvmED4iVG+6KG AERiLPKMJJ6V3uXnf5hRPWSm78Y0CXx+M0LIHqu8wojKQdPIxFtQYYzX6j4NuQFDFEuqsqOE 1kIL3mlau/rXKs/XnB6nhoPhY1NDcU3JzQF1dx4SMaOUL9drgO//+Ff3pJ4XeBLhhjC9/NHB VHvFRx86KvJ5mWzSQvYujXdl6yvj82njanXp0ckqqM6YPZYZs+FI8hQ7E0Px7MDQZJlQFjr3 pjZAcISlTELC7njbyogfUvdabiXug5pD3uAMZP7VrDqE2XpKgUNwYmdg/rdfTSvCEDaH5/gE Zr/6oWnbya8AzfVVcXsaAfK11DaGOeHbRcKh+KDb8k1ozDcB1sTGuMmDyRgwwyfG2v7EkJmm n9N0SvCI72K0sYtXZC3qnw9lRoMm2bYkJrc3h/9ZZwDGLcpx9IoKa2T7v212uacV0ZxO4BdD nDfDsJOwtrrurHoyK9iXKHFX88wI8pMfGYBLM/c6vL0nfoLIGTj6kJE7tV+5liXeqexNMjQK aaewWPKin/BP5s0wuJpmw9MC0xsWI6i5rTqW/YxXn92GR6DevZIVxgSb1eK9aA73L8T/LN1J lil9o6sea5L22ZUK/P9YjHKzpYbh/Dq2+/SO8l7YpZuq8/r7N/FZjWWzmg7gAy4DwuaMPv0E 8OSqVy577MfpJ1d8sJYiRD4x4nks+MIEZDiH28PsYuOVU2y3nVMNOC7+CW9f4hAkidqBDxPl fa+StH5PvBVzaC07lfC69YGxUnVGEsrHB5uOWFfMnMDQ/vcedJ9l+zKGW8f79QU7LtI8Rkkj 9qp9WT2/aKfC/50h3KtTR1IqhS43+qKPnCcT6kCKpN6ZimIlyCjauh/d6rgDr2QTW9bV4EhY ctTz1iUu1Tzj84jIM21SCuSqv45kI9+mEunw1aqg== X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40286511" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH] xen: Drop "-rc" suffix from XEN_EXTRAVERSION Date: Thu, 25 Mar 2021 15:07:02 +0000 Message-ID: <20210325150702.7582-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Fixes: a04509d34d ("Branching: Update version files etc. for newly unstable") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk --- xen/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/Makefile b/xen/Makefile index ab7d86d226..9f3be7766d 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -2,7 +2,7 @@ # All other places this is stored (eg. compile.h) should be autogenerated. export XEN_VERSION = 4 export XEN_SUBVERSION = 16 -export XEN_EXTRAVERSION ?= -unstable-rc$(XEN_VENDORVERSION) +export XEN_EXTRAVERSION ?= -unstable$(XEN_VENDORVERSION) export XEN_FULLVERSION = $(XEN_VERSION).$(XEN_SUBVERSION)$(XEN_EXTRAVERSION) -include xen-version -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Mar 25 15:22:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 15:22:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101422.193995 (Exim 4.92) (envelope-from ) id 1lPRoa-0005OS-Uj; Thu, 25 Mar 2021 15:22:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101422.193995; Thu, 25 Mar 2021 15:22:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPRoa-0005OL-Qz; Thu, 25 Mar 2021 15:22:28 +0000 Received: by outflank-mailman (input) for mailman id 101422; Thu, 25 Mar 2021 15:22:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPRoZ-0005OG-8O for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 15:22:27 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a2127d2f-42e6-49b6-8731-0585d3409ff9; Thu, 25 Mar 2021 15:22:26 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C43FF61A17; Thu, 25 Mar 2021 15:22:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2127d2f-42e6-49b6-8731-0585d3409ff9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616685746; bh=gI+ya7eVajNSjdsRxoTQswbctEeD7muAW0SsciqCFJw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=BjDbHAnf+ZH6ofUCPJ9exF0jNcwKBBBHrHIQAPvF5kdPgoXNKHzjj7wrTfu3L+wP9 RILZe3PiWcCap8Nx2I+0ogCf+E7C/cwTNMmBhbfGqFU6Z0He3KEJw02uyzZhtuhZs+ AED9Ik1gEedkxmoXnDM9ketYwyumb3VSit0LDwQHgR0nWvQW5vS5PfsBGYcRb95iuG Q5oOgcAXWmSEk+kdKw3vbZQzS/dR5VA/FGW/BwcUQ/o9GYALBRJ+gVU+YRyKjj78ay k8zuhwDAPTmLWMUnShljMBiOLmaogVXiXrENdu/Rljmahm9uGbKD+4E3PyrFg50YB7 M2jfsmbkbU5lQ== Date: Thu, 25 Mar 2021 08:22:25 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Randy Dunlap cc: Bhaskar Chowdhury , sstabellini@kernel.org, linux@armlinux.org.uk, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] ARM: xen/mm.c: A mundane typo fix In-Reply-To: Message-ID: References: <20210325043526.16289-1-unixbhaskar@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 24 Mar 2021, Randy Dunlap wrote: > On 3/24/21 9:35 PM, Bhaskar Chowdhury wrote: > > s/acrros/across/ > > > > Plus some words need prural version...so did it.(page->pages) > > > > Signed-off-by: Bhaskar Chowdhury > > Acked-by: Randy Dunlap Acked-by: Stefano Stabellini > > --- > > Changes from V1: > > Randy's findings incorporated. > > > > arch/arm/xen/mm.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c > > index 467fa225c3d0..8596dd32dcd5 100644 > > --- a/arch/arm/xen/mm.c > > +++ b/arch/arm/xen/mm.c > > @@ -105,8 +105,8 @@ bool xen_arch_need_swiotlb(struct device *dev, > > * - The Linux page refers to foreign memory > > * - The device doesn't support coherent DMA request > > * > > - * The Linux page may be spanned acrros multiple Xen page, although > > - * it's not possible to have a mix of local and foreign Xen page. > > + * The Linux page may be spanned across multiple Xen pages, although > > + * it's not possible to have a mix of local and foreign Xen pages. > > * Furthermore, range_straddles_page_boundary is already checking > > * if buffer is physically contiguous in the host RAM. > > * > > -- > > > -- > ~Randy > From xen-devel-bounces@lists.xenproject.org Thu Mar 25 15:47:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 15:47:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101426.194019 (Exim 4.92) (envelope-from ) id 1lPSCi-0007br-8E; Thu, 25 Mar 2021 15:47:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101426.194019; Thu, 25 Mar 2021 15:47:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSCi-0007bk-3u; Thu, 25 Mar 2021 15:47:24 +0000 Received: by outflank-mailman (input) for mailman id 101426; Thu, 25 Mar 2021 15:47:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSCh-0007aB-EY for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 15:47:23 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0f01ce82-395d-4c0c-b564-e9449c74787a; Thu, 25 Mar 2021 15:47:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f01ce82-395d-4c0c-b564-e9449c74787a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616687238; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xZUbtLTyjEiWLCPVXEVqDePxTYjpX+u+jaOjtO0ZwNg=; b=JXcA5npw74Vu6bR7Ltw9eUhKvrAlRB1uPqXAFiIS0TvuNJNaBJyjXhF+ Hlq2QEIFihNKLiIn/XHsm/9EjYNhXqSWyJFa9kbIQCLvmFKcSqFyNhMUt aoFdU46XR2TAfn6Lcm5ZFvJbu6SFKYF5A0C+KXb+Dur2V8ftSBPuVpKxl 0=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: IcvdpgyyrRTXsiLpQoyq6OFaz/8d3yf1xwcNo+1p+jGBvX++9yZmBTtS5kZgcWvACXwy1QMau3 WF8HmNI/9KJsnM6OuCsZfcShU2ZoPWRwwBGNLUnun+ZUg9KtL7HMRFSMBFnXw9v0OG0ALNOGyH QQ19lWEVpSIWsYr4LjEnT1bMFajujR0FLfNJRQmQRcGv/oRcNXbssT+cPUgev9fZFhd+a9s6Zo CMXB1fSo0WBG10yqpjrBD+InOU1KzzHinNftq3UHV2vgKxkvF++sjE7lgXfu/UZvN6GvtGnime q8g= X-SBRS: 5.1 X-MesageID: 41582315 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:YCvtcqv/71iBbXIAzhfKG0fJ7skCpIMji2hD6mlwRA09T+Wxi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmwybde6+AqXYuKdg/gpWeuMcVe/ZLvqgeQfxHW28x88e Nbc6Z4AMDtFlQSt6zHySSxDtpI+ra62Y+yg+O29RlQZCVLT40l0AtjEAacFSRNNWx7LL40Do CV6MYChxfIQwV1Uu2BCnMIX/fOqrTw/fqLXTc8CwM68w7LtDu06dfBeCSw5AsUUD9E3N4ZgA r4ujH+j5/Dj9iLjiXy+kWWxJRQldvnxLJ4dbGxo/lQEBrAoEKFYIxgXpeLoTw6pvq+gWxa7O XkklMbEOlYr1/XY2GpsTvhsjOQrwoG2jvZ5nKzxVvlvMDjSzoxB6N69PxkWyqc0WUMlpVY8s twrgWknqsSNzzstmDBwuKNcBdQmk+9sRMZ4JUupk0aa6QyQvtst4AFlXkldqsoLWbBx60MNv JhN83Y7OY+SyLhU1np+lNix9GhRR0Ib267a3lHvsSU1g5fl2xiw30Zw9QCnmwB+IhVceg929 j5 X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="41582315" From: Anthony PERARD To: CC: , Jordan Justen , Anthony PERARD , "Ard Biesheuvel" , Laszlo Ersek , Julien Grall Subject: [PATCH v2 1/7] OvmfPkg/XenResetVector: Silent a warning from nasm Date: Thu, 25 Mar 2021 15:47:07 +0000 Message-ID: <20210325154713.670104-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210325154713.670104-1-anthony.perard@citrix.com> References: <20210325154713.670104-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain VG8gYXZvaWQgbmFzbSBnZW5lcmF0aW5nIGEgd2FybmluZywgcmVwbGFjZSB0aGUgbWFjcm8gYnkg dGhlIHZhbHVlCmV4cGVjdGVkIHRvIGJlIHN0b3JlZCBpbiBlYXguCiAgSWEzMi9YZW5QVkhNYWlu LmFzbTo3Njogd2FybmluZzogZHdvcmQgZGF0YSBleGNlZWRzIGJvdW5kcwoKUmVwb3J0ZWQtYnk6 IExhc3psbyBFcnNlayA8bGVyc2VrQHJlZGhhdC5jb20+ClNpZ25lZC1vZmYtYnk6IEFudGhvbnkg UEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogTGFzemxvIEVy c2VrIDxsZXJzZWtAcmVkaGF0LmNvbT4KLS0tCiBPdm1mUGtnL1hlblJlc2V0VmVjdG9yL0lhMzIv WGVuUFZITWFpbi5hc20gfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEg ZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Pdm1mUGtnL1hlblJlc2V0VmVjdG9yL0lhMzIvWGVu UFZITWFpbi5hc20gYi9Pdm1mUGtnL1hlblJlc2V0VmVjdG9yL0lhMzIvWGVuUFZITWFpbi5hc20K aW5kZXggMmRmMGYxMmUxOGNiLi5jNzYxZTlkMzA3MjkgMTAwNjQ0Ci0tLSBhL092bWZQa2cvWGVu UmVzZXRWZWN0b3IvSWEzMi9YZW5QVkhNYWluLmFzbQorKysgYi9Pdm1mUGtnL1hlblJlc2V0VmVj dG9yL0lhMzIvWGVuUFZITWFpbi5hc20KQEAgLTczLDcgKzczLDcgQEAgeGVuUFZITWFpbjoKICAg ICA7DQogICAgIDsgcGFyYW1ldGVyIGZvciBGbGF0MzJTZWFyY2hGb3JCZnZCYXNlDQogICAgIDsN Ci0gICAgbW92ICAgICBlYXgsIEFERFJfT0YoZm91ckdpZ2FieXRlcykNCisgICAgbW92ICAgICBl YXgsIDAgICA7IEFERFJfT0YoZm91ckdpZ2FieXRlcykNCiAgICAgYWRkICAgICBlYXgsIGVkeCA7 IGFkZCBkZWx0YQ0KIA0KICAgICA7DQotLSAKQW50aG9ueSBQRVJBUkQKCg== From xen-devel-bounces@lists.xenproject.org Thu Mar 25 15:47:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 15:47:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101425.194006 (Exim 4.92) (envelope-from ) id 1lPSCd-0007aN-Uw; Thu, 25 Mar 2021 15:47:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101425.194006; Thu, 25 Mar 2021 15:47:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSCd-0007aG-S1; Thu, 25 Mar 2021 15:47:19 +0000 Received: by outflank-mailman (input) for mailman id 101425; Thu, 25 Mar 2021 15:47:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSCc-0007aB-Ju for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 15:47:18 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 28c78a1b-8fb9-4bb3-a167-1f88c639be33; Thu, 25 Mar 2021 15:47:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28c78a1b-8fb9-4bb3-a167-1f88c639be33 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616687237; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=zjDQm8C2btssLSA5VzcJPGVFPSZQrQ+OsqFsC9KrHAU=; b=M34o7XxUsgDwcGjns66U3xFHDT3wEmgPrVqW0kLAQm2EkZij9OhhWwZo JQbwca0mrseFpX/yWlda0GJSi7jp2pBrS5jEQ0yJUJ6X+DU38tf4ryZnR LLoHkuMAtXZEnShId8bWNtFLUP4+aEWEmODGfM1kUEL0V1avFWnY2eN43 E=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: m9kwWVaTUPQXLK5ZTN7aA0HzRPI8YdcseIcaupBkhUhFMCXjmSuCACfJUSeoiFnUmUoShpEV+I RspZ39zX4fFENHmaUKsQyM7ZzUgRYMosk0wYOAbCPEG3hlSzv49uRbcXd6r5lPINN4bKrbDNNP amIMaqxwlD9YMJA4quAyzm/Bg6iXvvrPsWMP8UJuJKdl34mn5AgRg1i6JkbMnHWfwv3WnUfv9T 2ZPtEkqTLoXJProwwSrWzKZKL+FlUjtkkcYV70TIDT/bVK8/fBm3v9RUh7LFX6ZhXydQxbyzjc 5D0= X-SBRS: 5.1 X-MesageID: 41582313 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:zKgW76HelyBMwSM7pLqFOpHXdLJzesId70hD6mlYVQFVfsuEl8 qngfQc0lvOhCwMXWw78OrsBICrSxrnlaJdy48XILukQU3aqHKlRbsSibfK7h/BP2nF9uBb3b p9aKQWMrfNJHVzkMqS2maFOvk6xt3vys6VrMP/61socg1wcaFn6G5Ce2OmO2l7XhNPC5Z8NL f03LslmxOadX4abtu2CxA+NoCum/TxmI/7ehlDPhY76WC15g+A0qLwEBSTw34lIlFy6IolmF KlryXJop+Nntv+4R/a2m/V4f1t6abc4+oGPuOgoIw4Lj3tjyyheYhuXaaT1QpF3N2H2RIRv/ Tn5zsmIsRv+1PdF1vF3ifF6k3b/xsFr1/k1FOCjnPoraXCNUwHIvsEv611WF/9ySMbzbZB+Z MO5U21nd5rKCmFuyLH693BR3hR5zGJiEtnq8E/pThiS4cEAYUhy7A3zQduP7orOjn104wjGP kGNrCn2N9mNWmXaH3UpQBUsaWRd0V2Gh+HR34LsdCO3w5Xm2hkz1AZyNZ3pAZ5yK4A X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="41582313" From: Anthony PERARD To: CC: , Jordan Justen , Anthony PERARD , "Ard Biesheuvel" , Laszlo Ersek , Julien Grall Subject: [PATCH v2 0/7] OvmfXen: Set PcdFSBClock at runtime Date: Thu, 25 Mar 2021 15:47:06 +0000 Message-ID: <20210325154713.670104-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 UGF0Y2ggc2VyaWVzIGF2YWlsYWJsZSBpbiB0aGlzIGdpdCBicmFuY2g6CmdpdDovL3hlbmJpdHMu eGVuLm9yZy9wZW9wbGUvYXBlcmFyZC9vdm1mLmdpdCBici5hcGljLXRpbWVyLWZyZXEtdjIKCkNo YW5nZXMgaW4gdjI6Ci0gbWFpbiBjaGFuZ2UgaXMgdG8gYWxsb3cgbWFwcGluZyBvZiBYZW4gcGFn ZXMgb3V0c2lkZSBvZiB0aGUgUkFNCiAgc2VlIHBhdGNoOiAiT3ZtZlBrZy9YZW5QbGF0Zm9ybVBl aTogTWFwIGV4dHJhIHBoeXNpY2FsIGFkZHJlc3MiCi0gdGhhdCBuZXcgZnVuY3Rpb24gYWxsb3dz IHRvIG1hcCB0aGUgWGVuIHNoYXJlZCBpbmZvIHBhZ2UgKHdoZXJlIHdlIGNhbiBmaW5kCiAgaW5m b3JtYXRpb24gYWJvdXQgdHNjIGZyZXF1ZW5jeSkgYXQgdGhlIGhpZ2hlc3QgcGh5c2ljYWwgYWRk cmVzcyBhbGxvd2VkLgoKSGksCgpPdm1mWGVuIHVzZXMgdGhlIEFQSUMgdGltZXIsIGJ1dCB3aXRo IGFuIGhhcmQtY29kZWQgZnJlcXVlbmN5IHRoYXQgbWF5IGNoYW5nZQphcyBwb2ludGVkIG91dCBo ZXJlOgogIGh0dHBzOi8vZWRrMi5ncm91cHMuaW8vZy9kZXZlbC9tZXNzYWdlLzQ1MTg1CiAgPDIw MTkwODA4MTM0NDIzLnlicWczcWtwdzV1Y2Z6azRAQWlyLWRlLVJvZ2VyPgoKVGhpcyBzZXJpZXMg Y2hhbmdlcyB0aGF0IHNvIHRoZSBmcmVxdWVuY3kgaXMgY2FsY3VsYXRlZCBhdCBydW50aW1lLgoK UmVmOiBodHRwczovL2J1Z3ppbGxhLnRpYW5vY29yZS5vcmcvc2hvd19idWcuY2dpP2lkPTI0OTAK ClRoZXJlIGlzIGFsc28gb25lIGNsZWFudXAgcGF0Y2ggdGhhdCBoYXMgbm90aGluZyB0byBkbyB3 aXRoIHRoZSByZXN0LgoKQ2hlZXJzLAoKQW50aG9ueSBQRVJBUkQgKDcpOgogIE92bWZQa2cvWGVu UmVzZXRWZWN0b3I6IFNpbGVudCBhIHdhcm5pbmcgZnJvbSBuYXNtCiAgTWRlUGtnOiBBbGxvdyBQ Y2RGU0JDbG9jayB0byBieSBEeW5hbWljCiAgT3ZtZlBrZy9JbmR1c3RyeVN0YW5kYXJkL1hlbjog QXBwbHkgRURLMiBjb2Rpbmcgc3R5bGUgdG8KICAgIFhFTl9WQ1BVX1RJTUVfSU5GTwogIE92bWZQ a2cvSW5kdXN0cnlTdGFuZGFyZDogSW50cm9kdWNlIFBhZ2VUYWJsZS5oCiAgT3ZtZlBrZy9YZW5Q bGF0Zm9ybVBlaTogTWFwIGV4dHJhIHBoeXNpY2FsIGFkZHJlc3MKICBPdm1mUGtnL1hlblBsYXRm b3JtUGVpOiBDYWxpYnJhdGUgQVBJQyB0aW1lciBmcmVxdWVuY3kKICBPdm1mUGtnL092bWZYZW46 IFNldCBQY2RGU0JDbG9jawoKIE1kZVBrZy9NZGVQa2cuZGVjICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICAgOCArLQogT3ZtZlBrZy9Pdm1mWGVuLmRzYyAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwgICA0ICstCiBPdm1mUGtnL1hlblBsYXRmb3JtUGVpL1hlblBsYXRmb3JtUGVpLmlu ZiAgICAgfCAgIDQgKwogLi4uL0luZHVzdHJ5U3RhbmRhcmQvUGFnZVRhYmxlLmh9ICAgICAgICAg ICAgIHwgMTE3ICstLS0tLS0tCiBPdm1mUGtnL0luY2x1ZGUvSW5kdXN0cnlTdGFuZGFyZC9YZW4v eGVuLmggICAgfCAgMTcgKy0KIC4uLi9CYXNlTWVtRW5jcnlwdFNldkxpYi9YNjQvVmlydHVhbE1l bW9yeS5oICB8IDE0MyArLS0tLS0tLS0tCiBPdm1mUGtnL1hlblBsYXRmb3JtUGVpL1BsYXRmb3Jt LmggICAgICAgICAgICAgfCAgMTAgKwogT3ZtZlBrZy9YZW5QbGF0Zm9ybVBlaS9QbGF0Zm9ybS5j ICAgICAgICAgICAgIHwgICAxICsKIE92bWZQa2cvWGVuUGxhdGZvcm1QZWkvWGVuLmMgICAgICAg ICAgICAgICAgICB8IDI1MiArKysrKysrKysrKysrKysrKysKIE92bWZQa2cvWGVuUmVzZXRWZWN0 b3IvSWEzMi9YZW5QVkhNYWluLmFzbSAgICB8ICAgMiArLQogMTAgZmlsZXMgY2hhbmdlZCwgMjg3 IGluc2VydGlvbnMoKyksIDI3MSBkZWxldGlvbnMoLSkKIGNvcHkgT3ZtZlBrZy97TGlicmFyeS9C YXNlTWVtRW5jcnlwdFNldkxpYi9YNjQvVmlydHVhbE1lbW9yeS5oID0+IEluY2x1ZGUvSW5kdXN0 cnlTdGFuZGFyZC9QYWdlVGFibGUuaH0gKDYwJSkKCi0tIApBbnRob255IFBFUkFSRAoK From xen-devel-bounces@lists.xenproject.org Thu Mar 25 15:47:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 15:47:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101427.194031 (Exim 4.92) (envelope-from ) id 1lPSCk-0007dv-G8; Thu, 25 Mar 2021 15:47:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101427.194031; Thu, 25 Mar 2021 15:47:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSCk-0007dn-Cl; Thu, 25 Mar 2021 15:47:26 +0000 Received: by outflank-mailman (input) for mailman id 101427; Thu, 25 Mar 2021 15:47:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSCj-0007dH-K3 for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 15:47:25 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5850518b-21a4-48ea-ac33-292defb6a290; Thu, 25 Mar 2021 15:47:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5850518b-21a4-48ea-ac33-292defb6a290 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616687243; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=I//vo6EgzA3O+WoYlIFVbKZ2b81Yv/4CkT2XwcMrI60=; b=L1MMtRQeiFubPs/I466R01ebf7a+0OtucwAahmQMZ9aFEqkZ8Mmjq2rA q4yOvWZlBVsT1nbgOdwdEtsQUN4y+OZ7AmdY3tQUkEfrhYVRWEptKkdTx YsFCmoNscHesxdCd3yTVuzIMwEDWAKoV9kjQqx9vk6ZSh7ZKxe4YKsTT0 0=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 8n4o21A1w7Gw1F32Yv5EbTlRvA1wkW8yP5FrruX1mtYYgOFaEg/bJenlmRH1tEonYmw04duqZH hwxX0DKXwxjmhlfYFm4p4R2wK1qewnWUBnYC8T8+Q7JDQRTw/6Uh3U6Z3QZ4ipAZi3qcGhZ1Vd 9Dsy/7QSz89ROY21v9odGm2ploXI2ZPC+cksdk3KJZOJFCDAqQnLcrnefiBN/VYS63MDNjLODm T3YdIYiWbE2vB09TetUantvil1ah5sQZBHrlkTlPpncFyOcI9T/FlFO3syPeI2fjfOGu0W41TI CM8= X-SBRS: 5.1 X-MesageID: 40292481 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:wbhaca7eJnP4ga4TvQPXwRqBI+orLtY04lQ7vn1ZYQBJc8Ceis CllOka0xixszoKRHQ8g7m7VZWoa3m0z/5IyKMWOqqvWxSjhXuwIOhZnO/f6hDDOwm7zO5S0q 98b7NzYeebMXFWhdv3iTPWL/8O29+CmZrHuc7771NACT5ncLth6QARMHf/LmRTSBNdDZQ0UL qwj/A3xAaIQngcYsSlCnRtZYGqy+Hjr576fQUAQycu9Qjmt1iVwYTnGBuV1Ap2aUIs/Z4e9w H+8jDR1+GYnNyQjjTd0GLS6Jo+oqqd9vJzQPaip+JQBjHligODbJlsVbuYrFkO0Z2SwWdvqv bgiVMNONly9mPwcwiO0GTQ8jil6hkCwTvDzkKVmnTqq8CRfkNFN+Nxwbh3XzGczmhIhqAa7I t7m1i3mrASMDb72AP63NTMXwECrDvOnVMS1dQ9olYabZETc9Zq3Ooi1XIQKrgsNgTg5rsqFe F/Zfusnsp+QBehY3fVsnIH+q3UYl0DWhOPQk01sseIyTRhnHdg00sCxMAE901wjK4Adw== X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40292481" From: Anthony PERARD To: CC: , Jordan Justen , Anthony PERARD , "Ard Biesheuvel" , Laszlo Ersek , Julien Grall , Tom Lendacky , Brijesh Singh Subject: [PATCH v2 4/7] OvmfPkg/IndustryStandard: Introduce PageTable.h Date: Thu, 25 Mar 2021 15:47:10 +0000 Message-ID: <20210325154713.670104-5-anthony.perard@citrix.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210325154713.670104-1-anthony.perard@citrix.com> References: <20210325154713.670104-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain V2UgYXJlIGdvaW5nIHRvIHVzZSB0aGUgcGFnZSB0YWJsZSBzdHJ1Y3R1cmUgaW4geWV0IGFub3Ro ZXIgcGxhY2UsCmNvbGxlY3QgdGhlIHR5cGVzIGFuZCBtYWNybyB0aGF0IGNhbiBiZSB1c2VkIGZy b20gYW5vdGhlciBtb2R1bGUKcmF0aGVyIHRoYXQgbWFraW5nIHlldCBhbm90aGVyIGNvcHkuCgpS ZWY6IGh0dHBzOi8vYnVnemlsbGEudGlhbm9jb3JlLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ5MApT aWduZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4K LS0tCkNDOiBUb20gTGVuZGFja3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPgpDQzogQnJpamVz aCBTaW5naCA8YnJpamVzaC5zaW5naEBhbWQuY29tPgotLS0KCk5vdGVzOgogICAgdjI6CiAgICAt IG5ldyBwYXRjaAoKIC4uLi9JbmR1c3RyeVN0YW5kYXJkL1BhZ2VUYWJsZS5ofSAgICAgICAgICAg ICB8IDExNyArLS0tLS0tLS0tLS0tLQogLi4uL0Jhc2VNZW1FbmNyeXB0U2V2TGliL1g2NC9WaXJ0 dWFsTWVtb3J5LmggIHwgMTQzICstLS0tLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA1 IGluc2VydGlvbnMoKyksIDI1NSBkZWxldGlvbnMoLSkKIGNvcHkgT3ZtZlBrZy97TGlicmFyeS9C YXNlTWVtRW5jcnlwdFNldkxpYi9YNjQvVmlydHVhbE1lbW9yeS5oID0+IEluY2x1ZGUvSW5kdXN0 cnlTdGFuZGFyZC9QYWdlVGFibGUuaH0gKDYwJSkKCmRpZmYgLS1naXQgYS9Pdm1mUGtnL0xpYnJh cnkvQmFzZU1lbUVuY3J5cHRTZXZMaWIvWDY0L1ZpcnR1YWxNZW1vcnkuaCBiL092bWZQa2cvSW5j bHVkZS9JbmR1c3RyeVN0YW5kYXJkL1BhZ2VUYWJsZS5oCnNpbWlsYXJpdHkgaW5kZXggNjAlCmNv cHkgZnJvbSBPdm1mUGtnL0xpYnJhcnkvQmFzZU1lbUVuY3J5cHRTZXZMaWIvWDY0L1ZpcnR1YWxN ZW1vcnkuaApjb3B5IHRvIE92bWZQa2cvSW5jbHVkZS9JbmR1c3RyeVN0YW5kYXJkL1BhZ2VUYWJs ZS5oCmluZGV4IDk5NmY5NGYwN2ViYi4uZTNkYTRlOGNmMjFjIDEwMDY0NAotLS0gYS9Pdm1mUGtn L0xpYnJhcnkvQmFzZU1lbUVuY3J5cHRTZXZMaWIvWDY0L1ZpcnR1YWxNZW1vcnkuaAorKysgYi9P dm1mUGtnL0luY2x1ZGUvSW5kdXN0cnlTdGFuZGFyZC9QYWdlVGFibGUuaApAQCAtMSw2ICsxLDYg QEAKIC8qKiBAZmlsZQ0KIA0KLSAgVmlydHVhbCBNZW1vcnkgTWFuYWdlbWVudCBTZXJ2aWNlcyB0 byBzZXQgb3IgY2xlYXIgdGhlIG1lbW9yeSBlbmNyeXB0aW9uIGJpdA0KKyAgeDg2XzY0IFBhZ2Ug VGFibGVzIHN0cnVjdHVyZXMNCiANCiAgIENvcHlyaWdodCAoYykgMjAwNiAtIDIwMTYsIEludGVs IENvcnBvcmF0aW9uLiBBbGwgcmlnaHRzIHJlc2VydmVkLjxCUj4NCiAgIENvcHlyaWdodCAoYykg MjAxNyAtIDIwMjAsIEFNRCBJbmNvcnBvcmF0ZWQuIEFsbCByaWdodHMgcmVzZXJ2ZWQuPEJSPg0K QEAgLTExLDE3ICsxMSwxMCBAQAogDQogKiovDQogDQotI2lmbmRlZiBfX1ZJUlRVQUxfTUVNT1JZ X18NCi0jZGVmaW5lIF9fVklSVFVBTF9NRU1PUllfXw0KKyNpZm5kZWYgX19QQUdFX1RBQkxFX0hf Xw0KKyNkZWZpbmUgX19QQUdFX1RBQkxFX0hfXw0KIA0KLSNpbmNsdWRlIDxMaWJyYXJ5L0Jhc2VM aWIuaD4NCi0jaW5jbHVkZSA8TGlicmFyeS9CYXNlTWVtb3J5TGliLmg+DQotI2luY2x1ZGUgPExp YnJhcnkvQ2FjaGVNYWludGVuYW5jZUxpYi5oPg0KLSNpbmNsdWRlIDxMaWJyYXJ5L0RlYnVnTGli Lmg+DQotI2luY2x1ZGUgPExpYnJhcnkvTWVtb3J5QWxsb2NhdGlvbkxpYi5oPg0KLSNpbmNsdWRl IDxVZWZpLmg+DQotDQotI2RlZmluZSBTWVNfQ09ERTY0X1NFTCAweDM4DQorI2luY2x1ZGUgPEJh c2UuaD4NCiANCiAjcHJhZ21hIHBhY2soMSkNCiANCkBAIC0xNjUsMTA2ICsxNTgsNCBAQCB0eXBl ZGVmIHVuaW9uIHsKICNkZWZpbmUgUFRFX09GRlNFVCh4KSAgICAgICAgICAgICAgICggKHggPj4g MTIpICYgUEFHRVRBQkxFX0VOVFJZX01BU0spDQogI2RlZmluZSBQQUdJTkdfMUdfQUREUkVTU19N QVNLXzY0ICAgMHgwMDBGRkZGRkMwMDAwMDAwdWxsDQogDQotI2RlZmluZSBQQUdFX1RBQkxFX1BP T0xfQUxJR05NRU5UICAgQkFTRV8yTUINCi0jZGVmaW5lIFBBR0VfVEFCTEVfUE9PTF9VTklUX1NJ WkUgICBTSVpFXzJNQg0KLSNkZWZpbmUgUEFHRV9UQUJMRV9QT09MX1VOSVRfUEFHRVMgIFwNCi0g IEVGSV9TSVpFX1RPX1BBR0VTIChQQUdFX1RBQkxFX1BPT0xfVU5JVF9TSVpFKQ0KLSNkZWZpbmUg UEFHRV9UQUJMRV9QT09MX0FMSUdOX01BU0sgIFwNCi0gICh+KEVGSV9QSFlTSUNBTF9BRERSRVNT KShQQUdFX1RBQkxFX1BPT0xfQUxJR05NRU5UIC0gMSkpDQotDQotdHlwZWRlZiBzdHJ1Y3Qgew0K LSAgVk9JRCAgICAgICAgICAgICpOZXh0UG9vbDsNCi0gIFVJTlROICAgICAgICAgICBPZmZzZXQ7 DQotICBVSU5UTiAgICAgICAgICAgRnJlZVBhZ2VzOw0KLX0gUEFHRV9UQUJMRV9QT09MOw0KLQ0K LS8qKg0KLSAgUmV0dXJuIHRoZSBwYWdldGFibGUgbWVtb3J5IGVuY3J5cHRpb24gbWFzay4NCi0N Ci0gIEByZXR1cm4gIFRoZSBwYWdldGFibGUgbWVtb3J5IGVuY3J5cHRpb24gbWFzay4NCi0NCi0q Ki8NCi1VSU5UNjQNCi1FRklBUEkNCi1JbnRlcm5hbEdldE1lbUVuY3J5cHRpb25BZGRyZXNzTWFz ayAoDQotICBWT0lEDQotICApOw0KLQ0KLS8qKg0KLSAgVGhpcyBmdW5jdGlvbiBjbGVhcnMgbWVt b3J5IGVuY3J5cHRpb24gYml0IGZvciB0aGUgbWVtb3J5IHJlZ2lvbiBzcGVjaWZpZWQgYnkNCi0g IFBoeXNpY2FsQWRkcmVzcyBhbmQgTGVuZ3RoIGZyb20gdGhlIGN1cnJlbnQgcGFnZSB0YWJsZSBj b250ZXh0Lg0KLQ0KLSAgQHBhcmFtW2luXSAgQ3IzQmFzZUFkZHJlc3MgICAgICAgICAgQ3IzIEJh c2UgQWRkcmVzcyAoaWYgemVybyB0aGVuIHVzZQ0KLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY3VycmVudCBDUjMpDQotICBAcGFyYW1baW5dICBQaHlzaWNhbEFkZHJlc3Mg ICAgICAgICBUaGUgcGh5c2ljYWwgYWRkcmVzcyB0aGF0IGlzIHRoZSBzdGFydA0KLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYWRkcmVzcyBvZiBhIG1lbW9yeSByZWdpb24u DQotICBAcGFyYW1baW5dICBMZW5ndGggICAgICAgICAgICAgICAgICBUaGUgbGVuZ3RoIG9mIG1l bW9yeSByZWdpb24NCi0gIEBwYXJhbVtpbl0gIEZsdXNoICAgICAgICAgICAgICAgICAgIEZsdXNo IHRoZSBjYWNoZXMgYmVmb3JlIGFwcGx5aW5nIHRoZQ0KLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZW5jcnlwdGlvbiBtYXNrDQotDQotICBAcmV0dmFsIFJFVFVSTl9TVUND RVNTICAgICAgICAgICAgICBUaGUgYXR0cmlidXRlcyB3ZXJlIGNsZWFyZWQgZm9yIHRoZQ0KLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWVtb3J5IHJlZ2lvbi4NCi0gIEBy ZXR2YWwgUkVUVVJOX0lOVkFMSURfUEFSQU1FVEVSICAgIE51bWJlciBvZiBwYWdlcyBpcyB6ZXJv Lg0KLSAgQHJldHZhbCBSRVRVUk5fVU5TVVBQT1JURUQgICAgICAgICAgQ2xlYXJpbmcgdGhlIG1l bW9yeSBlbmN5cnB0aW9uIGF0dHJpYnV0ZQ0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgaXMgbm90IHN1cHBvcnRlZA0KLSoqLw0KLVJFVFVSTl9TVEFUVVMNCi1FRklBUEkN Ci1JbnRlcm5hbE1lbUVuY3J5cHRTZXZTZXRNZW1vcnlEZWNyeXB0ZWQgKA0KLSAgSU4gIFBIWVNJ Q0FMX0FERFJFU1MgICAgICAgIENyM0Jhc2VBZGRyZXNzLA0KLSAgSU4gIFBIWVNJQ0FMX0FERFJF U1MgICAgICAgIFBoeXNpY2FsQWRkcmVzcywNCi0gIElOICBVSU5UTiAgICAgICAgICAgICAgICAg ICBMZW5ndGgsDQotICBJTiAgQk9PTEVBTiAgICAgICAgICAgICAgICAgRmx1c2gNCi0gICk7DQot DQotLyoqDQotICBUaGlzIGZ1bmN0aW9uIHNldHMgbWVtb3J5IGVuY3J5cHRpb24gYml0IGZvciB0 aGUgbWVtb3J5IHJlZ2lvbiBzcGVjaWZpZWQgYnkNCi0gIFBoeXNpY2FsQWRkcmVzcyBhbmQgTGVu Z3RoIGZyb20gdGhlIGN1cnJlbnQgcGFnZSB0YWJsZSBjb250ZXh0Lg0KLQ0KLSAgQHBhcmFtW2lu XSAgQ3IzQmFzZUFkZHJlc3MgICAgICAgICAgQ3IzIEJhc2UgQWRkcmVzcyAoaWYgemVybyB0aGVu IHVzZQ0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY3VycmVudCBDUjMp DQotICBAcGFyYW1baW5dICBQaHlzaWNhbEFkZHJlc3MgICAgICAgICBUaGUgcGh5c2ljYWwgYWRk cmVzcyB0aGF0IGlzIHRoZSBzdGFydA0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgYWRkcmVzcyBvZiBhIG1lbW9yeSByZWdpb24uDQotICBAcGFyYW1baW5dICBMZW5ndGgg ICAgICAgICAgICAgICAgICBUaGUgbGVuZ3RoIG9mIG1lbW9yeSByZWdpb24NCi0gIEBwYXJhbVtp bl0gIEZsdXNoICAgICAgICAgICAgICAgICAgIEZsdXNoIHRoZSBjYWNoZXMgYmVmb3JlIGFwcGx5 aW5nIHRoZQ0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZW5jcnlwdGlv biBtYXNrDQotDQotICBAcmV0dmFsIFJFVFVSTl9TVUNDRVNTICAgICAgICAgICAgICBUaGUgYXR0 cmlidXRlcyB3ZXJlIHNldCBmb3IgdGhlIG1lbW9yeQ0KLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcmVnaW9uLg0KLSAgQHJldHZhbCBSRVRVUk5fSU5WQUxJRF9QQVJBTUVU RVIgICAgTnVtYmVyIG9mIHBhZ2VzIGlzIHplcm8uDQotICBAcmV0dmFsIFJFVFVSTl9VTlNVUFBP UlRFRCAgICAgICAgICBTZXR0aW5nIHRoZSBtZW1vcnkgZW5jeXJwdGlvbiBhdHRyaWJ1dGUNCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlzIG5vdCBzdXBwb3J0ZWQNCi0q Ki8NCi1SRVRVUk5fU1RBVFVTDQotRUZJQVBJDQotSW50ZXJuYWxNZW1FbmNyeXB0U2V2U2V0TWVt b3J5RW5jcnlwdGVkICgNCi0gIElOICBQSFlTSUNBTF9BRERSRVNTICAgICAgICBDcjNCYXNlQWRk cmVzcywNCi0gIElOICBQSFlTSUNBTF9BRERSRVNTICAgICAgICBQaHlzaWNhbEFkZHJlc3MsDQot ICBJTiAgVUlOVE4gICAgICAgICAgICAgICAgICAgTGVuZ3RoLA0KLSAgSU4gIEJPT0xFQU4gICAg ICAgICAgICAgICAgIEZsdXNoDQotICApOw0KLQ0KLS8qKg0KLSAgUmV0dXJucyB0aGUgZW5jcnlw dGlvbiBzdGF0ZSBvZiB0aGUgc3BlY2lmaWVkIHZpcnR1YWwgYWRkcmVzcyByYW5nZS4NCi0NCi0g IEBwYXJhbVtpbl0gIENyM0Jhc2VBZGRyZXNzICAgICAgICAgIENyMyBCYXNlIEFkZHJlc3MgKGlm IHplcm8gdGhlbiB1c2UNCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGN1 cnJlbnQgQ1IzKQ0KLSAgQHBhcmFtW2luXSAgQmFzZUFkZHJlc3MgICAgICAgICAgICAgQmFzZSBh ZGRyZXNzIHRvIGNoZWNrDQotICBAcGFyYW1baW5dICBMZW5ndGggICAgICAgICAgICAgICAgICBM ZW5ndGggb2YgdmlydHVhbCBhZGRyZXNzIHJhbmdlDQotDQotICBAcmV0dmFsIE1lbUVuY3J5cHRT ZXZBZGRyZXNzUmFuZ2VVbmVuY3J5cHRlZCAgQWRkcmVzcyByYW5nZSBpcyBtYXBwZWQNCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bmVuY3J5cHRlZA0K LSAgQHJldHZhbCBNZW1FbmNyeXB0U2V2QWRkcmVzc1JhbmdlRW5jcnlwdGVkICAgIEFkZHJlc3Mg cmFuZ2UgaXMgbWFwcGVkDQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZW5jcnlwdGVkDQotICBAcmV0dmFsIE1lbUVuY3J5cHRTZXZBZGRyZXNzUmFuZ2VN aXhlZCAgICAgICAgQWRkcmVzcyByYW5nZSBpcyBtYXBwZWQgbWl4ZWQNCi0gIEByZXR2YWwgTWVt RW5jcnlwdFNldkFkZHJlc3NSYW5nZUVycm9yICAgICAgICBBZGRyZXNzIHJhbmdlIGlzIG5vdCBt YXBwZWQNCi0qKi8NCi1NRU1fRU5DUllQVF9TRVZfQUREUkVTU19SQU5HRV9TVEFURQ0KLUVGSUFQ SQ0KLUludGVybmFsTWVtRW5jcnlwdFNldkdldEFkZHJlc3NSYW5nZVN0YXRlICgNCi0gIElOIFBI WVNJQ0FMX0FERFJFU1MgICAgICAgICBDcjNCYXNlQWRkcmVzcywNCi0gIElOIFBIWVNJQ0FMX0FE RFJFU1MgICAgICAgICBCYXNlQWRkcmVzcywNCi0gIElOIFVJTlROICAgICAgICAgICAgICAgICAg ICBMZW5ndGgNCi0gICk7DQotDQogI2VuZGlmDQpkaWZmIC0tZ2l0IGEvT3ZtZlBrZy9MaWJyYXJ5 L0Jhc2VNZW1FbmNyeXB0U2V2TGliL1g2NC9WaXJ0dWFsTWVtb3J5LmggYi9Pdm1mUGtnL0xpYnJh cnkvQmFzZU1lbUVuY3J5cHRTZXZMaWIvWDY0L1ZpcnR1YWxNZW1vcnkuaAppbmRleCA5OTZmOTRm MDdlYmIuLmI2MjFkODExY2E2ZiAxMDA2NDQKLS0tIGEvT3ZtZlBrZy9MaWJyYXJ5L0Jhc2VNZW1F bmNyeXB0U2V2TGliL1g2NC9WaXJ0dWFsTWVtb3J5LmgKKysrIGIvT3ZtZlBrZy9MaWJyYXJ5L0Jh c2VNZW1FbmNyeXB0U2V2TGliL1g2NC9WaXJ0dWFsTWVtb3J5LmgKQEAgLTIwLDE1MSArMjAsMTAg QEAKICNpbmNsdWRlIDxMaWJyYXJ5L0RlYnVnTGliLmg+DQogI2luY2x1ZGUgPExpYnJhcnkvTWVt b3J5QWxsb2NhdGlvbkxpYi5oPg0KICNpbmNsdWRlIDxVZWZpLmg+DQorI2luY2x1ZGUgPEluZHVz dHJ5U3RhbmRhcmQvUGFnZVRhYmxlLmg+DQogDQogI2RlZmluZSBTWVNfQ09ERTY0X1NFTCAweDM4 DQogDQotI3ByYWdtYSBwYWNrKDEpDQotDQotLy8NCi0vLyBQYWdlLU1hcCBMZXZlbC00IE9mZnNl dCAoUE1MNCkgYW5kDQotLy8gUGFnZS1EaXJlY3RvcnktUG9pbnRlciBPZmZzZXQgKFBEUEUpIGVu dHJpZXMgNEsgJiAyTUINCi0vLw0KLQ0KLXR5cGVkZWYgdW5pb24gew0KLSAgc3RydWN0IHsNCi0g ICAgVUlOVDY0ICBQcmVzZW50OjE7ICAgICAgICAgICAgICAgIC8vIDAgPSBOb3QgcHJlc2VudCBp biBtZW1vcnksDQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvLyAgIDEg PSBQcmVzZW50IGluIG1lbW9yeQ0KLSAgICBVSU5UNjQgIFJlYWRXcml0ZToxOyAgICAgICAgICAg ICAgLy8gMCA9IFJlYWQtT25seSwgMT0gUmVhZC9Xcml0ZQ0KLSAgICBVSU5UNjQgIFVzZXJTdXBl cnZpc29yOjE7ICAgICAgICAgLy8gMCA9IFN1cGVydmlzb3IsIDE9VXNlcg0KLSAgICBVSU5UNjQg IFdyaXRlVGhyb3VnaDoxOyAgICAgICAgICAgLy8gMCA9IFdyaXRlLUJhY2sgY2FjaGluZywNCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8vICAgMSA9IFdyaXRlLVRocm91 Z2ggY2FjaGluZw0KLSAgICBVSU5UNjQgIENhY2hlRGlzYWJsZWQ6MTsgICAgICAgICAgLy8gMCA9 IENhY2hlZCwgMT1Ob24tQ2FjaGVkDQotICAgIFVJTlQ2NCAgQWNjZXNzZWQ6MTsgICAgICAgICAg ICAgICAvLyAwID0gTm90IGFjY2Vzc2VkLA0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgLy8gICAxID0gQWNjZXNzZWQgKHNldCBieSBDUFUpDQotICAgIFVJTlQ2NCAgUmVz ZXJ2ZWQ6MTsgICAgICAgICAgICAgICAvLyBSZXNlcnZlZA0KLSAgICBVSU5UNjQgIE11c3RCZVpl cm86MjsgICAgICAgICAgICAgLy8gTXVzdCBCZSBaZXJvDQotICAgIFVJTlQ2NCAgQXZhaWxhYmxl OjM7ICAgICAgICAgICAgICAvLyBBdmFpbGFibGUgZm9yIHVzZSBieSBzeXN0ZW0gc29mdHdhcmUN Ci0gICAgVUlOVDY0ICBQYWdlVGFibGVCYXNlQWRkcmVzczo0MDsgIC8vIFBhZ2UgVGFibGUgQmFz ZSBBZGRyZXNzDQotICAgIFVJTlQ2NCAgQXZhYmlsYWJsZUhpZ2g6MTE7ICAgICAgICAvLyBBdmFp bGFibGUgZm9yIHVzZSBieSBzeXN0ZW0gc29mdHdhcmUNCi0gICAgVUlOVDY0ICBOeDoxOyAgICAg ICAgICAgICAgICAgICAgIC8vIE5vIEV4ZWN1dGUgYml0DQotICB9IEJpdHM7DQotICBVSU5UNjQg ICAgVWludDY0Ow0KLX0gUEFHRV9NQVBfQU5EX0RJUkVDVE9SWV9QT0lOVEVSOw0KLQ0KLS8vDQot Ly8gUGFnZSBUYWJsZSBFbnRyeSA0S0INCi0vLw0KLXR5cGVkZWYgdW5pb24gew0KLSAgc3RydWN0 IHsNCi0gICAgVUlOVDY0ICBQcmVzZW50OjE7ICAgICAgICAgICAgICAgIC8vIDAgPSBOb3QgcHJl c2VudCBpbiBtZW1vcnksDQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAv LyAgIDEgPSBQcmVzZW50IGluIG1lbW9yeQ0KLSAgICBVSU5UNjQgIFJlYWRXcml0ZToxOyAgICAg ICAgICAgICAgLy8gMCA9IFJlYWQtT25seSwgMT0gUmVhZC9Xcml0ZQ0KLSAgICBVSU5UNjQgIFVz ZXJTdXBlcnZpc29yOjE7ICAgICAgICAgLy8gMCA9IFN1cGVydmlzb3IsIDE9VXNlcg0KLSAgICBV SU5UNjQgIFdyaXRlVGhyb3VnaDoxOyAgICAgICAgICAgLy8gMCA9IFdyaXRlLUJhY2sgY2FjaGlu ZywNCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8vICAgMSA9IFdyaXRl LVRocm91Z2ggY2FjaGluZw0KLSAgICBVSU5UNjQgIENhY2hlRGlzYWJsZWQ6MTsgICAgICAgICAg Ly8gMCA9IENhY2hlZCwgMT1Ob24tQ2FjaGVkDQotICAgIFVJTlQ2NCAgQWNjZXNzZWQ6MTsgICAg ICAgICAgICAgICAvLyAwID0gTm90IGFjY2Vzc2VkLA0KLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgLy8gICAxID0gQWNjZXNzZWQgKHNldCBieSBDUFUpDQotICAgIFVJTlQ2 NCAgRGlydHk6MTsgICAgICAgICAgICAgICAgICAvLyAwID0gTm90IERpcnR5LCAxID0gd3JpdHRl biBieQ0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gICBwcm9jZXNz b3Igb24gYWNjZXNzIHRvIHBhZ2UNCi0gICAgVUlOVDY0ICBQQVQ6MTsgICAgICAgICAgICAgICAg ICAgIC8vDQotICAgIFVJTlQ2NCAgR2xvYmFsOjE7ICAgICAgICAgICAgICAgICAvLyAwID0gTm90 IGdsb2JhbCBwYWdlLCAxID0gZ2xvYmFsIHBhZ2UNCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIC8vICAgVExCIG5vdCBjbGVhcmVkIG9uIENSMyB3cml0ZQ0KLSAgICBVSU5U NjQgIEF2YWlsYWJsZTozOyAgICAgICAgICAgICAgLy8gQXZhaWxhYmxlIGZvciB1c2UgYnkgc3lz dGVtIHNvZnR3YXJlDQotICAgIFVJTlQ2NCAgUGFnZVRhYmxlQmFzZUFkZHJlc3M6NDA7ICAvLyBQ YWdlIFRhYmxlIEJhc2UgQWRkcmVzcw0KLSAgICBVSU5UNjQgIEF2YWJpbGFibGVIaWdoOjExOyAg ICAgICAgLy8gQXZhaWxhYmxlIGZvciB1c2UgYnkgc3lzdGVtIHNvZnR3YXJlDQotICAgIFVJTlQ2 NCAgTng6MTsgICAgICAgICAgICAgICAgICAgICAvLyAwID0gRXhlY3V0ZSBDb2RlLA0KLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gICAxID0gTm8gQ29kZSBFeGVjdXRp b24NCi0gIH0gQml0czsNCi0gIFVJTlQ2NCAgICBVaW50NjQ7DQotfSBQQUdFX1RBQkxFXzRLX0VO VFJZOw0KLQ0KLS8vDQotLy8gUGFnZSBUYWJsZSBFbnRyeSAyTUINCi0vLw0KLXR5cGVkZWYgdW5p b24gew0KLSAgc3RydWN0IHsNCi0gICAgVUlOVDY0ICBQcmVzZW50OjE7ICAgICAgICAgICAgICAg IC8vIDAgPSBOb3QgcHJlc2VudCBpbiBtZW1vcnksDQotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAvLyAgIDEgPSBQcmVzZW50IGluIG1lbW9yeQ0KLSAgICBVSU5UNjQgIFJl YWRXcml0ZToxOyAgICAgICAgICAgICAgLy8gMCA9IFJlYWQtT25seSwgMT0gUmVhZC9Xcml0ZQ0K LSAgICBVSU5UNjQgIFVzZXJTdXBlcnZpc29yOjE7ICAgICAgICAgLy8gMCA9IFN1cGVydmlzb3Is IDE9VXNlcg0KLSAgICBVSU5UNjQgIFdyaXRlVGhyb3VnaDoxOyAgICAgICAgICAgLy8gMCA9IFdy aXRlLUJhY2sgY2FjaGluZywNCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IC8vICAgMT1Xcml0ZS1UaHJvdWdoIGNhY2hpbmcNCi0gICAgVUlOVDY0ICBDYWNoZURpc2FibGVk OjE7ICAgICAgICAgIC8vIDAgPSBDYWNoZWQsIDE9Tm9uLUNhY2hlZA0KLSAgICBVSU5UNjQgIEFj Y2Vzc2VkOjE7ICAgICAgICAgICAgICAgLy8gMCA9IE5vdCBhY2Nlc3NlZCwNCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8vICAgMSA9IEFjY2Vzc2VkIChzZXQgYnkgQ1BV KQ0KLSAgICBVSU5UNjQgIERpcnR5OjE7ICAgICAgICAgICAgICAgICAgLy8gMCA9IE5vdCBEaXJ0 eSwgMSA9IHdyaXR0ZW4gYnkNCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IC8vICAgcHJvY2Vzc29yIG9uIGFjY2VzcyB0byBwYWdlDQotICAgIFVJTlQ2NCAgTXVzdEJlMTox OyAgICAgICAgICAgICAgICAvLyBNdXN0IGJlIDENCi0gICAgVUlOVDY0ICBHbG9iYWw6MTsgICAg ICAgICAgICAgICAgIC8vIDAgPSBOb3QgZ2xvYmFsIHBhZ2UsIDEgPSBnbG9iYWwgcGFnZQ0KLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gICBUTEIgbm90IGNsZWFyZWQg b24gQ1IzIHdyaXRlDQotICAgIFVJTlQ2NCAgQXZhaWxhYmxlOjM7ICAgICAgICAgICAgICAvLyBB dmFpbGFibGUgZm9yIHVzZSBieSBzeXN0ZW0gc29mdHdhcmUNCi0gICAgVUlOVDY0ICBQQVQ6MTsg ICAgICAgICAgICAgICAgICAgIC8vDQotICAgIFVJTlQ2NCAgTXVzdEJlWmVybzo4OyAgICAgICAg ICAgICAvLyBNdXN0IGJlIHplcm87DQotICAgIFVJTlQ2NCAgUGFnZVRhYmxlQmFzZUFkZHJlc3M6 MzE7ICAvLyBQYWdlIFRhYmxlIEJhc2UgQWRkcmVzcw0KLSAgICBVSU5UNjQgIEF2YWJpbGFibGVI aWdoOjExOyAgICAgICAgLy8gQXZhaWxhYmxlIGZvciB1c2UgYnkgc3lzdGVtIHNvZnR3YXJlDQot ICAgIFVJTlQ2NCAgTng6MTsgICAgICAgICAgICAgICAgICAgICAvLyAwID0gRXhlY3V0ZSBDb2Rl LA0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gICAxID0gTm8gQ29k ZSBFeGVjdXRpb24NCi0gIH0gQml0czsNCi0gIFVJTlQ2NCAgICBVaW50NjQ7DQotfSBQQUdFX1RB QkxFX0VOVFJZOw0KLQ0KLS8vDQotLy8gUGFnZSBUYWJsZSBFbnRyeSAxR0INCi0vLw0KLXR5cGVk ZWYgdW5pb24gew0KLSAgc3RydWN0IHsNCi0gICAgVUlOVDY0ICBQcmVzZW50OjE7ICAgICAgICAg ICAgICAgIC8vIDAgPSBOb3QgcHJlc2VudCBpbiBtZW1vcnksDQotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAvLyAgIDEgPSBQcmVzZW50IGluIG1lbW9yeQ0KLSAgICBVSU5U NjQgIFJlYWRXcml0ZToxOyAgICAgICAgICAgICAgLy8gMCA9IFJlYWQtT25seSwgMT0gUmVhZC9X cml0ZQ0KLSAgICBVSU5UNjQgIFVzZXJTdXBlcnZpc29yOjE7ICAgICAgICAgLy8gMCA9IFN1cGVy dmlzb3IsIDE9VXNlcg0KLSAgICBVSU5UNjQgIFdyaXRlVGhyb3VnaDoxOyAgICAgICAgICAgLy8g MCA9IFdyaXRlLUJhY2sgY2FjaGluZywNCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIC8vICAgMSA9IFdyaXRlLVRocm91Z2ggY2FjaGluZw0KLSAgICBVSU5UNjQgIENhY2hl RGlzYWJsZWQ6MTsgICAgICAgICAgLy8gMCA9IENhY2hlZCwgMT1Ob24tQ2FjaGVkDQotICAgIFVJ TlQ2NCAgQWNjZXNzZWQ6MTsgICAgICAgICAgICAgICAvLyAwID0gTm90IGFjY2Vzc2VkLA0KLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gICAxID0gQWNjZXNzZWQgKHNl dCBieSBDUFUpDQotICAgIFVJTlQ2NCAgRGlydHk6MTsgICAgICAgICAgICAgICAgICAvLyAwID0g Tm90IERpcnR5LCAxID0gd3JpdHRlbiBieQ0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgLy8gICBwcm9jZXNzb3Igb24gYWNjZXNzIHRvIHBhZ2UNCi0gICAgVUlOVDY0ICBN dXN0QmUxOjE7ICAgICAgICAgICAgICAgIC8vIE11c3QgYmUgMQ0KLSAgICBVSU5UNjQgIEdsb2Jh bDoxOyAgICAgICAgICAgICAgICAgLy8gMCA9IE5vdCBnbG9iYWwgcGFnZSwgMSA9IGdsb2JhbCBw YWdlDQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvLyAgIFRMQiBub3Qg Y2xlYXJlZCBvbiBDUjMgd3JpdGUNCi0gICAgVUlOVDY0ICBBdmFpbGFibGU6MzsgICAgICAgICAg ICAgIC8vIEF2YWlsYWJsZSBmb3IgdXNlIGJ5IHN5c3RlbSBzb2Z0d2FyZQ0KLSAgICBVSU5UNjQg IFBBVDoxOyAgICAgICAgICAgICAgICAgICAgLy8NCi0gICAgVUlOVDY0ICBNdXN0QmVaZXJvOjE3 OyAgICAgICAgICAgIC8vIE11c3QgYmUgemVybzsNCi0gICAgVUlOVDY0ICBQYWdlVGFibGVCYXNl QWRkcmVzczoyMjsgIC8vIFBhZ2UgVGFibGUgQmFzZSBBZGRyZXNzDQotICAgIFVJTlQ2NCAgQXZh YmlsYWJsZUhpZ2g6MTE7ICAgICAgICAvLyBBdmFpbGFibGUgZm9yIHVzZSBieSBzeXN0ZW0gc29m dHdhcmUNCi0gICAgVUlOVDY0ICBOeDoxOyAgICAgICAgICAgICAgICAgICAgIC8vIDAgPSBFeGVj dXRlIENvZGUsDQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvLyAgIDEg PSBObyBDb2RlIEV4ZWN1dGlvbg0KLSAgfSBCaXRzOw0KLSAgVUlOVDY0ICAgIFVpbnQ2NDsNCi19 IFBBR0VfVEFCTEVfMUdfRU5UUlk7DQotDQotI3ByYWdtYSBwYWNrKCkNCi0NCi0jZGVmaW5lIElB MzJfUEdfUCAgICAgICAgICAgICAgICAgICBCSVQwDQotI2RlZmluZSBJQTMyX1BHX1JXICAgICAg ICAgICAgICAgICAgQklUMQ0KLSNkZWZpbmUgSUEzMl9QR19QUyAgICAgICAgICAgICAgICAgIEJJ VDcNCi0NCi0jZGVmaW5lIFBBR0lOR19QQUVfSU5ERVhfTUFTSyAgICAgICAweDFGRg0KLQ0KLSNk ZWZpbmUgUEFHSU5HXzRLX0FERFJFU1NfTUFTS182NCAgIDB4MDAwRkZGRkZGRkZGRjAwMHVsbA0K LSNkZWZpbmUgUEFHSU5HXzJNX0FERFJFU1NfTUFTS182NCAgIDB4MDAwRkZGRkZGRkUwMDAwMHVs bA0KLSNkZWZpbmUgUEFHSU5HXzFHX0FERFJFU1NfTUFTS182NCAgIDB4MDAwRkZGRkZDMDAwMDAw MHVsbA0KLQ0KLSNkZWZpbmUgUEFHSU5HX0wxX0FERFJFU1NfU0hJRlQgICAgIDEyDQotI2RlZmlu ZSBQQUdJTkdfTDJfQUREUkVTU19TSElGVCAgICAgMjENCi0jZGVmaW5lIFBBR0lOR19MM19BRERS RVNTX1NISUZUICAgICAzMA0KLSNkZWZpbmUgUEFHSU5HX0w0X0FERFJFU1NfU0hJRlQgICAgIDM5 DQotDQotI2RlZmluZSBQQUdJTkdfUE1MNEVfTlVNQkVSICAgICAgICAgNA0KLQ0KLSNkZWZpbmUg UEFHRVRBQkxFX0VOVFJZX01BU0sgICAgICAgICgoMVVMIDw8IDkpIC0gMSkNCi0jZGVmaW5lIFBN TDRfT0ZGU0VUKHgpICAgICAgICAgICAgICAoICh4ID4+IDM5KSAmIFBBR0VUQUJMRV9FTlRSWV9N QVNLKQ0KLSNkZWZpbmUgUERQX09GRlNFVCh4KSAgICAgICAgICAgICAgICggKHggPj4gMzApICYg UEFHRVRBQkxFX0VOVFJZX01BU0spDQotI2RlZmluZSBQREVfT0ZGU0VUKHgpICAgICAgICAgICAg ICAgKCAoeCA+PiAyMSkgJiBQQUdFVEFCTEVfRU5UUllfTUFTSykNCi0jZGVmaW5lIFBURV9PRkZT RVQoeCkgICAgICAgICAgICAgICAoICh4ID4+IDEyKSAmIFBBR0VUQUJMRV9FTlRSWV9NQVNLKQ0K LSNkZWZpbmUgUEFHSU5HXzFHX0FERFJFU1NfTUFTS182NCAgIDB4MDAwRkZGRkZDMDAwMDAwMHVs bA0KLQ0KICNkZWZpbmUgUEFHRV9UQUJMRV9QT09MX0FMSUdOTUVOVCAgIEJBU0VfMk1CDQogI2Rl ZmluZSBQQUdFX1RBQkxFX1BPT0xfVU5JVF9TSVpFICAgU0laRV8yTUINCiAjZGVmaW5lIFBBR0Vf VEFCTEVfUE9PTF9VTklUX1BBR0VTICBcDQotLSAKQW50aG9ueSBQRVJBUkQKCg== From xen-devel-bounces@lists.xenproject.org Thu Mar 25 15:47:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 15:47:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101428.194043 (Exim 4.92) (envelope-from ) id 1lPSCo-0007hH-2b; Thu, 25 Mar 2021 15:47:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101428.194043; Thu, 25 Mar 2021 15:47:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSCn-0007h7-U0; Thu, 25 Mar 2021 15:47:29 +0000 Received: by outflank-mailman (input) for mailman id 101428; Thu, 25 Mar 2021 15:47:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSCm-0007aB-F1 for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 15:47:28 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 952d8419-3a87-420f-82d7-35cd8feac7d2; Thu, 25 Mar 2021 15:47:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 952d8419-3a87-420f-82d7-35cd8feac7d2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616687240; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KVilLDDb67bS7C+WpFITR7DzrixuVw3sneqjw7mFbUQ=; b=hHegj+/wCU7rlOgycuQKumcHc1FBmKM8FdVR0HzZ+D8EL12PjLIhCQwI x7imJ8J3kYObUWySw41Rt5KQ2FtGXl7hzWDjJUAxv+DcYKMMe0qt7ZFVi Vuhrwmlge9ZRruDfr2wvTnf6fJlbt8Cz5M0I2oGxu1cfNJB2hIwUXTRBy s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: PKVjxGMoTsEq7h+zCQ56+IbED4T8sU/BznOzg72cOtaZG25T1U0OniYjTD/jvKFGMfSGNUyydj EQGmXKRT/2i3SIbgJo0TQvsDArCYOP16PTo55EHg58RjcqgaOJeUkDl/W609llUfgIC9/rL5uV 4chN67h3f16cAxw17YPIQ7UxC2vcEODSKmcshxXGguAtV2Ly0/BodNAbo0FazrsJMEvuZs5Whe 3QIYaVqdpADs7Sp8ylsphILyfXIiXCXF6grh4mWQdcCmFHdoj5eLUdlgKCllxPMomNkmn+ZUs4 rMg= X-SBRS: 5.1 X-MesageID: 40500441 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:bY24YKP5zDb3qcBcTxP155DYdL4zR+YMi2QD/1xtSBBTb8yTn9 2vmvNe7hPvlDMNQhgb9OyoEqPoexPh3LRy5pQcOqrnYRn+tAKTXeVfxKbB4xmlIS3x8eZByb xtGpIVNPTcBUV35PyU3CCWCNAlqePozImNpcPzi0hgVhtrbaYI1XYdNi++HldtTAdLQboVfa DshfZvnDardXQJYsnTPBBsM9TrnNHXiIngJScPGh9P0mKzpAm14733GQXw5GZ9bxpzx94ZkF TtokjCyYiI99q6zRLd0GG71eUqpPLRjuFtKebJpswcKjDHghulaoJ7S9S5zUwIidDq0nkGup 3hpAohItRS5hrqDx6IiCqo4SbM+nIP7GLv0lCRi3eLm72GeBsKT/BvqKgcVzmx0TtGgPhMlJ hl8kjcir9sSTTHpyj578igbWAQqmOE5UAMvMRWs2ZSSuIlGdlshL1axmx5OrEaEhn37Yg2ed Medv301bJtfVSWY2uxhBgX/PWcGnA6HhKxSkMfoMCi0z9PgHBjz0cDrfZv5ks9yA== X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40500441" From: Anthony PERARD To: CC: , Jordan Justen , Anthony PERARD , "Ard Biesheuvel" , Laszlo Ersek , Julien Grall , Liming Gao , Bob Feng , Michael D Kinney , Zhiguang Liu Subject: [PATCH v2 2/7] MdePkg: Allow PcdFSBClock to by Dynamic Date: Thu, 25 Mar 2021 15:47:08 +0000 Message-ID: <20210325154713.670104-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210325154713.670104-1-anthony.perard@citrix.com> References: <20210325154713.670104-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain V2UgYXJlIGdvaW5nIHRvIHdhbnQgdG8gY2hhbmdlIHRoZSB2YWx1ZSBvZiBQY2RGU0JDbG9jayBh dCBydW4gdGltZSBpbgpPdm1mWGVuLCBzbyBtb3ZlIGl0IHRvIHRoZSBQY2RzRHluYW1pYyBzZWN0 aW9uLgoKUmVmOiBodHRwczovL2J1Z3ppbGxhLnRpYW5vY29yZS5vcmcvc2hvd19idWcuY2dpP2lk PTI0OTAKU2lnbmVkLW9mZi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJp eC5jb20+ClJldmlld2VkLWJ5OiBMYXN6bG8gRXJzZWsgPGxlcnNla0ByZWRoYXQuY29tPgpSZXZp ZXdlZC1ieTogTGltaW5nIEdhbyA8bGltaW5nLmdhb0BpbnRlbC5jb20+Ci0tLQpDQzogQm9iIEZl bmcgPGJvYi5jLmZlbmdAaW50ZWwuY29tPgpDQzogTWljaGFlbCBEIEtpbm5leSA8bWljaGFlbC5k Lmtpbm5leUBpbnRlbC5jb20+CkNDOiBaaGlndWFuZyBMaXUgPHpoaWd1YW5nLmxpdUBpbnRlbC5j b20+Ci0tLQogTWRlUGtnL01kZVBrZy5kZWMgfCA4ICsrKystLS0tCiAxIGZpbGUgY2hhbmdlZCwg NCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL01kZVBrZy9NZGVQ a2cuZGVjIGIvTWRlUGtnL01kZVBrZy5kZWMKaW5kZXggMWQyNjM3YWNjMjJhLi5mMGQzYjkxZmM2 MzUgMTAwNjQ0Ci0tLSBhL01kZVBrZy9NZGVQa2cuZGVjCisrKyBiL01kZVBrZy9NZGVQa2cuZGVj CkBAIC0yMjU3LDEwICsyMjU3LDYgQEAgW1BjZHNGaXhlZEF0QnVpbGQsUGNkc1BhdGNoYWJsZUlu TW9kdWxlXQogICAjIEBWYWxpZExpc3QgIDB4ODAwMDAwMDEgfCA4LCAxNiwgMzINCiAgIGdFZmlN ZGVQa2dUb2tlblNwYWNlR3VpZC5QY2RQb3J0ODBEYXRhV2lkdGh8OHxVSU5UOHwweDAwMDAwMDJk DQogDQotICAjIyBUaGlzIHZhbHVlIGlzIHVzZWQgdG8gY29uZmlndXJlIFg4NiBQcm9jZXNzb3Ig RlNCIGNsb2NrLg0KLSAgIyBAUHJvbXB0IEZTQiBDbG9jay4NCi0gIGdFZmlNZGVQa2dUb2tlblNw YWNlR3VpZC5QY2RGU0JDbG9ja3wyMDAwMDAwMDB8VUlOVDMyfDB4MDAwMDAwMGMNCi0NCiAgICMj IFRoZSBtYXhpbXVtIHByaW50YWJsZSBudW1iZXIgb2YgY2hhcmFjdGVycy4gVWVmTGliIGZ1bmN0 aW9uczogQXNjaWlQcmludCgpLCBBc2NpaUVycm9yUHJpbnQoKSwNCiAgICMgIFByaW50WFkoKSwg QXNjaWlQcmludFhZKCksIFByaW50KCksIEVycm9yUHJpbnQoKSBiYXNlIG9uIHRoaXMgUENEIHZh bHVlIHRvIHByaW50IGNoYXJhY3RlcnMuDQogICAjIEBQcm9tcHQgTWF4aW11bSBQcmludGFibGUg TnVtYmVyIG9mIENoYXJhY3RlcnMuDQpAQCAtMjM2NCw1ICsyMzYwLDkgQEAgW1BjZHNGaXhlZEF0 QnVpbGQsIFBjZHNQYXRjaGFibGVJbk1vZHVsZSwgUGNkc0R5bmFtaWMsIFBjZHNEeW5hbWljRXhd CiAgICMgQFByb21wdCBCb290IFRpbWVvdXQgKHMpDQogICBnRWZpTWRlUGtnVG9rZW5TcGFjZUd1 aWQuUGNkUGxhdGZvcm1Cb290VGltZU91dHwweGZmZmZ8VUlOVDE2fDB4MDAwMDAwMmMNCiANCisg ICMjIFRoaXMgdmFsdWUgaXMgdXNlZCB0byBjb25maWd1cmUgWDg2IFByb2Nlc3NvciBGU0IgY2xv Y2suDQorICAjIEBQcm9tcHQgRlNCIENsb2NrLg0KKyAgZ0VmaU1kZVBrZ1Rva2VuU3BhY2VHdWlk LlBjZEZTQkNsb2NrfDIwMDAwMDAwMHxVSU5UMzJ8MHgwMDAwMDAwYw0KKw0KIFtVc2VyRXh0ZW5z aW9ucy5UaWFub0NvcmUuIkV4dHJhRmlsZXMiXQ0KICAgTWRlUGtnRXh0cmEudW5pDQotLSAKQW50 aG9ueSBQRVJBUkQKCg== From xen-devel-bounces@lists.xenproject.org Thu Mar 25 15:47:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 15:47:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101429.194055 (Exim 4.92) (envelope-from ) id 1lPSCp-0007jR-DI; Thu, 25 Mar 2021 15:47:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101429.194055; Thu, 25 Mar 2021 15:47:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSCp-0007jI-98; Thu, 25 Mar 2021 15:47:31 +0000 Received: by outflank-mailman (input) for mailman id 101429; Thu, 25 Mar 2021 15:47:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSCo-0007dH-GF for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 15:47:30 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 57f45469-8c1e-4477-a1fa-29e94f4b75ff; Thu, 25 Mar 2021 15:47:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57f45469-8c1e-4477-a1fa-29e94f4b75ff DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616687246; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kR85HuAEtSi2+1CX5gncd/zpXFCfU6BegJnoHsZGfX8=; b=eOSoFdl1aBmnE5Nky8HC7DBCduwtIYICvtqcU9c56VJ+zxkb4a4pdY+/ GJE1wsdATHGqgn6Jy+VL6kqa0qwA2JZxpGVxdb3s0Nhj2763wLjb15gFo df96mchgerVt1PnrIoGLpmC2tzMTj80P5Xb2GO04JIc8psW1TTSHfNMKa c=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 28IfOMmo3K9HzOIx7zzQWMVhHTAoCEwTANEpGlFfWKhQ6rbPKk/G2BJVdKIaHmdx9hwPaMSRcN gymDz0SgkjjK66OC9UiZTTSf0wOZeRKlZzAC5NMQcq6PRH+zESX+PJaAlrHbc0tmDuFv9ytCgh Htx/w/K8JUjz/fNT2tknJP9uktCZzne6/6c0e5WAzBGM8GkepoGe0agXheb4pMXY3skFKF8Syx YuMRBeSmVbpu/y8SpC6XP5If4/4p5+f0kST46au63LPAw27amEwbGuw3tDTHXKXwoTNmJxV3Ca yh4= X-SBRS: 5.1 X-MesageID: 40017829 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:IrV++qkQ1+HvqiziyZRnzoZoFHvpDfOijWdD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLN+AZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 hdWoBEIpnLAVB+5PyX3CCRGdwt2cTC1aiui/vXwXsFd3AYV4hJ8xp5BgGHEkd/WQlBAt4DGI CB49dczgDLRV0+ctm7Cn4ZX+LKut3Mk9bcbQQbAgM8rC+UjT2p77b+eiLoqSs2eRkn+8ZZzU HulQvl6qK/99SyzRHB32Hehq4m6ufJ4N1FGcCKl4wpOizh4zzYJrhJdp+jmHQOoO+p4Es3i9 WkmXYdFul69n+5RBDLnTLDwA/luQxek0PK6Vjdunf7pNy8eTRSMbswuat8Uj/0r3Utp8t91q Uj5RPdi7NyAQnblCrwo/jkPisa6HacmnYpne4Ng3E3a+J3A9Iw3O9vmDIzYfFwZR7S04wsHO lwAMyZ3s94GGnqCkzxhWVhzMehWX4+BH69Mzk/k/aI2Dtblm0R9TpP+OUjn2wN/J94a55I6/ WsCNUVqJhyT9QbZa84OeEZQcHfMB2xfTvwNgupUC/aPZBCEXTBp6Po5vEQ6PuxcJIF7LZaou WHbHpo8UQ1dk7SF8u2x5tA/grWTGjVZ0Wq9uhuo7Reg5XgWaHqOjGfRF0Ln9G7q/sSa/erAs qbCdZ4BeTuInDpHpsM9wriW4NKIX1ba8ENvM0nMmj+/v7jG8nEsPfWf+3UI6eoOTE4WnnnCn 9GZzTrIt5cqnytR2TlmgXcVhrWCwzC1KM1NJKf0/kYyYALOIEJmhQJiFi/+8GAISBDtKtzR0 dlPLb7iMqA1AuL1FeNy18sFgtWD05T7rmleWhNvxU2P0T9dqtGk8mDeEhJtUH3cyNXfofzKk pytl538aW4I9i73iY5Ee+qNWqckj86uG+KdZEBgaeOjP2VKK8QP9IDYuhcBA/LHxt6lUJBs2 FYcjIJQUfZC3fAkqOgoJsIBPzOVtV1jQuxSPQk/U73hAG5n4UCV3EbVzmhXYq8mgA1XQdZgV V37us+jdO76GaSAFp6pN59HExHaWyRDr4DJh+Cfp9olrfifxw1amuWmzqAiVUWdnDx/0sfwk ztRBfkKM3jMx54gDR1w6zq+FR7eiG2ZERrcE13toV7CCDhoXZ80eiCY4KpyGuPYl4+wuUQWQ u1Pwc6E0dL/ZSaxRSVkDGNGTEN3ZM1JNHQC7wlbvX0wXOiKIqBkIkaAuRV94p5ON3SvugCVv +0fQiTIDnkC+Qm+xX9nAd3BABE7F0f1d/40hzs62a1mEQyBvffO3xKbbAWKdP01Rmqe9+4lL FCyf4lt+q5NWv8LuOcwabMdjhZN1f4umitVdwlrphSoIM/vLZ+BIPgTDPNzX1LtS9OaLaiqG ouBIBApJzRMI5meMIfPx9D9l0yjdKVMQ8AqQrtGNIzelkrkl7WN96E+KDztKEuG1SMqWLLSA Gi2hwY282AfiOYkZYGFqo7IA1tGT0BwUUn2NnHUYLeCA+nLb4euHW7N2Kwa79bRuyuH64Koh Nz/tGPmKu2ekPDqUjtlAo+BpgL1WmpQcm/Wl3RXcFJ9sG3IlSKjO+B5tWpgDL+VDu8bAA5iM l9blMLB/4z0QUKvckS6GyObYDZ5mgiiEBT5Dl7kEWF4PnT3E7rWWVHOxbemJNYQH16NWWJl9 3M9YGjpS7AyQkA/ZnID0FLeN5SX/AWU4jsNi9rbewdpqSh8aZqoiNNZn4VfjMBoQG4++Ntxr Gi3vrOH8XkFHfzIFoEvRpIHJR9kCBuiWZOdYyZ9pKyYgIeE4czcroCz7ETtDJisV7o6VIAKz 1rqwwzz4nIamXdAE4UL9mioaLGxDwZrrOF8VtguTF5nU6mkkiVvxzImNuvp2Aoo2C1lH4olY ytAB0rgChYsQZ7x7dGKXTlax+yfVq1dGrtyq0mIHtkDn1q8dwFyCHOJa8Rm/mFvkJZhAV+Oz M3xb6zEGbZVHGpLPK1FzyxCNGpaeQCSsp5Cy47NHixOw3DmpMsCijQcNMk7RmlgHEIbJL+EJ +OUUalF58K87UXO6vwB7GfntvVkjdU7GsTqYWTsw2voNt6qceAYgJsu9M0dKZkfg+s4Sdjy9 OWGQbCJZIe7i3Zp3HogB4oZ+M+0kAQ2w0XtC0QECSnC5evXUlnvicB0IKsSysCy8qNIOwl+1 vpsBqkoj3RMgvRLUynH7sK6Hgt/BzaQI3bs0OhEoCBeyx66bWpC+OhiSH+1wXGvN2PgznVqw N13QpnNFwI4hbQWM5UFmzfwE8bOQd9Dx9gkAKt3awG/3ts7HVUOQA5VY0E5yXmCRfVEi3iin DRPFJLhvc6b1M= X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40017829" From: Anthony PERARD To: CC: , Jordan Justen , Anthony PERARD , "Ard Biesheuvel" , Laszlo Ersek , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 6/7] OvmfPkg/XenPlatformPei: Calibrate APIC timer frequency Date: Thu, 25 Mar 2021 15:47:12 +0000 Message-ID: <20210325154713.670104-7-anthony.perard@citrix.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210325154713.670104-1-anthony.perard@citrix.com> References: <20210325154713.670104-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 Q2FsY3VsYXRlIHRoZSBmcmVxdWVuY3kgb2YgdGhlIEFQSUMgdGltZXIgdGhhdCBYZW4gcHJvdmlk ZXMuCgpFdmVuIHRob3VnaCB0aGUgZnJlcXVlbmN5IGlzIGN1cnJlbnRseSBoYXJkLWNvZGVkLCBp dCBpc24ndCBwYXJ0IG9mCnRoZSBwdWJsaWMgQUJJIHRoYXQgWGVuIHByb3ZpZGVzIGFuZCB0aHVz IG1heSBjaGFuZ2UgYXQgYW55IHRpbWUuIE9WTUYKbmVlZHMgdG8gZGV0ZXJtaW5lIHRoZSBmcmVx dWVuY3kgYnkgYW4gb3RoZXIgbWVhbi4KCkZvcnR1bmF0ZWx5LCBYZW4gcHJvdmlkZXMgYSB3YXkg dG8gZGV0ZXJtaW5lcyB0aGUgZnJlcXVlbmN5IG9mIHRoZQpUU0MsIHNvIHdlIGNhbiB1c2UgVFND IHRvIGNhbGlicmF0ZSB0aGUgZnJlcXVlbmN5IG9mIHRoZSBBUElDIHRpbWVyLgpUaGF0IGluZm9y bWF0aW9uIGlzIGZvdW5kIGluIHRoZSBzaGFyZWRfaW5mbyBwYWdlIHdoaWNoIHdlIG1hcCBhbmQK dW5tYXAgb25jZSBkb25lIChYZW5CdXNEeGUgaXMgZ29pbmcgdG8gbWFwIHRoZSBwYWdlIHNvbWV3 aGVyZSBlbHNlKS4KClRoZSBzaGFyZWRfaW5mbyBwYWdlIGlzIG1hcCBhdCB0aGUgaGlnaGVzdCBw aHlzaWNhbCBhZGRyZXNzIGFsbG93ZWQgYXMKaXQgZG9lc24ndCBuZWVkIHRvIGJlIGluIHRoZSBS QU0sIHRodXMgdGhlcmUncyBhIGNhbGwgdG8gdXBkYXRlIHRoZQpwYWdlIHRhYmxlLgoKVGhlIGNh bGN1bGF0ZWQgZnJlcXVlbmN5IGlzIG9ubHkgbG9nZ2VkIGluIHRoaXMgcGF0Y2gsIGl0IHdpbGwg YmUgdXNlZAppbiBhIGZvbGxvd2luZyBwYXRjaC4KClJlZjogaHR0cHM6Ly9idWd6aWxsYS50aWFu b2NvcmUub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDkwClNpZ25lZC1vZmYtYnk6IEFudGhvbnkgUEVS QVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgotLS0KQ0M6IFJvZ2VyIFBhdSBNb25uw6kg PHJvZ2VyLnBhdUBjaXRyaXguY29tPgotLS0KCk5vdGVzOgogICAgdjI6CiAgICAtIGZpeCBDYW1l bENhc2VzCiAgICAtIFVzZSBVNjQgbXVsdGlwbGljYXRpb24gYW5kIGRpdmlzaW9uIGhlbHBlcnMK ICAgIC0gZG9uJ3QgcmVhZCBUc2NTaGlmdCBmcm9tIHRoZSBTaGFyZWRJbmZvIHBhZ2UgYWdhaW4K ICAgIC0gY2hhbmdlIHRoZSBsb2NhdGlvbiBvZiB0aGUgc2hhcmVkIGluZm8gcGFnZSB0byBiZSBv dXRzaWRlIG9mIHRoZSByYW0KICAgIC0gY2hlY2sgZm9yIG92ZXJmbG93IGluIFhlbkRlbGF5CiAg ICAtIGNoZWNrIGZvciBvdmVyZmxvdyB3aGVuIGNhbGN1bGF0aW5nIHRoZSBjYWxjdWxhdGluZyBB UElDIGZyZXF1ZW5jeQoKIE92bWZQa2cvWGVuUGxhdGZvcm1QZWkvWGVuUGxhdGZvcm1QZWkuaW5m IHwgICAyICsKIE92bWZQa2cvWGVuUGxhdGZvcm1QZWkvUGxhdGZvcm0uaCAgICAgICAgIHwgICA1 ICsKIE92bWZQa2cvWGVuUGxhdGZvcm1QZWkvUGxhdGZvcm0uYyAgICAgICAgIHwgICAxICsKIE92 bWZQa2cvWGVuUGxhdGZvcm1QZWkvWGVuLmMgICAgICAgICAgICAgIHwgMTc3ICsrKysrKysrKysr KysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgMTg1IGluc2VydGlvbnMoKykKCmRpZmYgLS1n aXQgYS9Pdm1mUGtnL1hlblBsYXRmb3JtUGVpL1hlblBsYXRmb3JtUGVpLmluZiBiL092bWZQa2cv WGVuUGxhdGZvcm1QZWkvWGVuUGxhdGZvcm1QZWkuaW5mCmluZGV4IDg3OTBkOTA3ZDNlYy4uNTcz MmQyMTg4ODcxIDEwMDY0NAotLS0gYS9Pdm1mUGtnL1hlblBsYXRmb3JtUGVpL1hlblBsYXRmb3Jt UGVpLmluZgorKysgYi9Pdm1mUGtnL1hlblBsYXRmb3JtUGVpL1hlblBsYXRmb3JtUGVpLmluZgpA QCAtNTIsNiArNTIsNyBAQCBbTGlicmFyeUNsYXNzZXNdCiAgIERlYnVnTGliDQogICBIb2JMaWIN CiAgIElvTGliDQorICBMb2NhbEFwaWNMaWINCiAgIFBjaUxpYg0KICAgUmVzb3VyY2VQdWJsaWNh dGlvbkxpYg0KICAgUGVpU2VydmljZXNMaWINCkBAIC01OSw2ICs2MCw3IEBAIFtMaWJyYXJ5Q2xh c3Nlc10KICAgTXRyckxpYg0KICAgTWVtRW5jcnlwdFNldkxpYg0KICAgUGNkTGliDQorICBTYWZl SW50TGliDQogICBYZW5IeXBlcmNhbGxMaWINCiANCiBbUGNkXQ0KZGlmZiAtLWdpdCBhL092bWZQ a2cvWGVuUGxhdGZvcm1QZWkvUGxhdGZvcm0uaCBiL092bWZQa2cvWGVuUGxhdGZvcm1QZWkvUGxh dGZvcm0uaAppbmRleCBlNzBjYTU4MDc4ZWIuLjc3ZDg4ZmMxNTlkNyAxMDA2NDQKLS0tIGEvT3Zt ZlBrZy9YZW5QbGF0Zm9ybVBlaS9QbGF0Zm9ybS5oCisrKyBiL092bWZQa2cvWGVuUGxhdGZvcm1Q ZWkvUGxhdGZvcm0uaApAQCAtMTMyLDYgKzEzMiwxMSBAQCBQaHlzaWNhbEFkZHJlc3NJZGVudGl0 eU1hcHBpbmcgKAogICBJTiBFRklfUEhZU0lDQUxfQUREUkVTUyBBZGRyZXNzVG9NYXANCiAgICk7 DQogDQorVk9JRA0KK0NhbGlicmF0ZUxhcGljVGltZXIgKA0KKyAgVk9JRA0KKyAgKTsNCisNCiBl eHRlcm4gRUZJX0JPT1RfTU9ERSBtQm9vdE1vZGU7DQogDQogZXh0ZXJuIFVJTlQ4IG1QaHlzTWVt QWRkcmVzc1dpZHRoOw0KZGlmZiAtLWdpdCBhL092bWZQa2cvWGVuUGxhdGZvcm1QZWkvUGxhdGZv cm0uYyBiL092bWZQa2cvWGVuUGxhdGZvcm1QZWkvUGxhdGZvcm0uYwppbmRleCA3MTdmZDBhYjFh NDUuLmU5NTExZWI0MGM2MiAxMDA2NDQKLS0tIGEvT3ZtZlBrZy9YZW5QbGF0Zm9ybVBlaS9QbGF0 Zm9ybS5jCisrKyBiL092bWZQa2cvWGVuUGxhdGZvcm1QZWkvUGxhdGZvcm0uYwpAQCAtNDQ4LDYg KzQ0OCw3IEBAIEluaXRpYWxpemVYZW5QbGF0Zm9ybSAoCiAgIEluaXRpYWxpemVSYW1SZWdpb25z ICgpOw0KIA0KICAgSW5pdGlhbGl6ZVhlbiAoKTsNCisgIENhbGlicmF0ZUxhcGljVGltZXIgKCk7 DQogDQogICBpZiAobUJvb3RNb2RlICE9IEJPT1RfT05fUzNfUkVTVU1FKSB7DQogICAgIFJlc2Vy dmVFbXVWYXJpYWJsZU52U3RvcmUgKCk7DQpkaWZmIC0tZ2l0IGEvT3ZtZlBrZy9YZW5QbGF0Zm9y bVBlaS9YZW4uYyBiL092bWZQa2cvWGVuUGxhdGZvcm1QZWkvWGVuLmMKaW5kZXggYjJhN2QxYzIx ZGFjLi43NTI0YWFhMTFhMjkgMTAwNjQ0Ci0tLSBhL092bWZQa2cvWGVuUGxhdGZvcm1QZWkvWGVu LmMKKysrIGIvT3ZtZlBrZy9YZW5QbGF0Zm9ybVBlaS9YZW4uYwpAQCAtMjEsOCArMjEsMTAgQEAK ICNpbmNsdWRlIDxMaWJyYXJ5L0NwdUxpYi5oPg0KICNpbmNsdWRlIDxMaWJyYXJ5L0RlYnVnTGli Lmg+DQogI2luY2x1ZGUgPExpYnJhcnkvSG9iTGliLmg+DQorI2luY2x1ZGUgPExpYnJhcnkvTG9j YWxBcGljTGliLmg+DQogI2luY2x1ZGUgPExpYnJhcnkvTWVtb3J5QWxsb2NhdGlvbkxpYi5oPg0K ICNpbmNsdWRlIDxMaWJyYXJ5L1BjZExpYi5oPg0KKyNpbmNsdWRlIDxMaWJyYXJ5L1NhZmVJbnRM aWIuaD4NCiAjaW5jbHVkZSA8R3VpZC9YZW5JbmZvLmg+DQogI2luY2x1ZGUgPEluZHVzdHJ5U3Rh bmRhcmQvRTgyMC5oPg0KICNpbmNsdWRlIDxMaWJyYXJ5L1Jlc291cmNlUHVibGljYXRpb25MaWIu aD4NCkBAIC00NTcsMyArNDU5LDE3OCBAQCBQaHlzaWNhbEFkZHJlc3NJZGVudGl0eU1hcHBpbmcg KAogDQogICByZXR1cm4gRUZJX1NVQ0NFU1M7DQogfQ0KKw0KK1NUQVRJQw0KK0VGSV9TVEFUVVMN CitNYXBTaGFyZWRJbmZvUGFnZSAoDQorICBJTiBWT0lEICpQYWdlUHRyDQorICApDQorew0KKyAg eGVuX2FkZF90b19waHlzbWFwX3QgIFBhcmFtZXRlcnM7DQorICBJTlROICAgICAgICAgICAgICAg ICAgUmV0dXJuQ29kZTsNCisNCisgIFBhcmFtZXRlcnMuZG9taWQgPSBET01JRF9TRUxGOw0KKyAg UGFyYW1ldGVycy5zcGFjZSA9IFhFTk1BUFNQQUNFX3NoYXJlZF9pbmZvOw0KKyAgUGFyYW1ldGVy cy5pZHggPSAwOw0KKyAgUGFyYW1ldGVycy5ncGZuID0gKFVJTlROKVBhZ2VQdHIgPj4gRUZJX1BB R0VfU0hJRlQ7DQorICBSZXR1cm5Db2RlID0gWGVuSHlwZXJjYWxsTWVtb3J5T3AgKFhFTk1FTV9h ZGRfdG9fcGh5c21hcCwgJlBhcmFtZXRlcnMpOw0KKyAgaWYgKFJldHVybkNvZGUgIT0gMCkgew0K KyAgICByZXR1cm4gRUZJX05PX01BUFBJTkc7DQorICB9DQorICByZXR1cm4gRUZJX1NVQ0NFU1M7 DQorfQ0KKw0KK1NUQVRJQw0KK1ZPSUQNCitVbm1hcFhlblBhZ2UgKA0KKyAgSU4gVk9JRCAqUGFn ZVB0cg0KKyAgKQ0KK3sNCisgIHhlbl9yZW1vdmVfZnJvbV9waHlzbWFwX3QgUGFyYW1ldGVyczsN CisgIElOVE4gICAgICAgICAgICAgICAgICAgICAgUmV0dXJuQ29kZTsNCisNCisgIFBhcmFtZXRl cnMuZG9taWQgPSBET01JRF9TRUxGOw0KKyAgUGFyYW1ldGVycy5ncGZuID0gKFVJTlROKVBhZ2VQ dHIgPj4gRUZJX1BBR0VfU0hJRlQ7DQorICBSZXR1cm5Db2RlID0gWGVuSHlwZXJjYWxsTWVtb3J5 T3AgKFhFTk1FTV9yZW1vdmVfZnJvbV9waHlzbWFwLCAmUGFyYW1ldGVycyk7DQorICBBU1NFUlQg KFJldHVybkNvZGUgPT0gMCk7DQorfQ0KKw0KKw0KK1NUQVRJQw0KK1VJTlQ2NA0KK0dldENwdUZy ZXEgKA0KKyAgSU4gWEVOX1ZDUFVfVElNRV9JTkZPICpWY3B1VGltZQ0KKyAgKQ0KK3sNCisgIFVJ TlQzMiBWZXJzaW9uOw0KKyAgVUlOVDMyIFRzY1RvU3lzdGVtTXVsdGlwbGllcjsNCisgIElOVDgg ICBUc2NTaGlmdDsNCisgIFVJTlQ2NCBDcHVGcmVxOw0KKw0KKyAgZG8gew0KKyAgICBWZXJzaW9u ID0gVmNwdVRpbWUtPlZlcnNpb247DQorICAgIE1lbW9yeUZlbmNlICgpOw0KKyAgICBUc2NUb1N5 c3RlbU11bHRpcGxpZXIgPSBWY3B1VGltZS0+VHNjVG9TeXN0ZW1NdWx0aXBsaWVyOw0KKyAgICBU c2NTaGlmdCA9IFZjcHVUaW1lLT5Uc2NTaGlmdDsNCisgICAgTWVtb3J5RmVuY2UgKCk7DQorICB9 IHdoaWxlICgoKFZlcnNpb24gJiAxKSAhPSAwKSAmJiAoVmVyc2lvbiAhPSBWY3B1VGltZS0+VmVy c2lvbikpOw0KKw0KKyAgQ3B1RnJlcSA9IERpdlU2NHgzMiAoTFNoaWZ0VTY0ICgxMDAwMDAwMDAw VUxMLCAzMiksIFRzY1RvU3lzdGVtTXVsdGlwbGllcik7DQorICBpZiAoVHNjU2hpZnQgPj0gMCkg ew0KKyAgICAgIENwdUZyZXEgPSBSU2hpZnRVNjQgKENwdUZyZXEsIFRzY1NoaWZ0KTsNCisgIH0g ZWxzZSB7DQorICAgICAgQ3B1RnJlcSA9IExTaGlmdFU2NCAoQ3B1RnJlcSwgLVRzY1NoaWZ0KTsN CisgIH0NCisgIHJldHVybiBDcHVGcmVxOw0KK30NCisNCitTVEFUSUMNCitWT0lEDQorWGVuRGVs YXkgKA0KKyAgSU4gWEVOX1ZDUFVfVElNRV9JTkZPICpWY3B1VGltZUluZm8sDQorICBJTiBVSU5U NjQgICAgICAgICAgICAgRGVsYXlOcw0KKyAgKQ0KK3sNCisgIFVJTlQ2NCAgICAgICAgVGljazsN CisgIFVJTlQ2NCAgICAgICAgQ3B1RnJlcTsNCisgIFVJTlQ2NCAgICAgICAgRGVsYXk7DQorICBV SU5UNjQgICAgICAgIERlbGF5VGljazsNCisgIFVJTlQ2NCAgICAgICAgTmV3VGljazsNCisgIFJF VFVSTl9TVEFUVVMgU3RhdHVzOw0KKw0KKyAgVGljayA9IEFzbVJlYWRUc2MgKCk7DQorDQorICBD cHVGcmVxID0gR2V0Q3B1RnJlcSAoVmNwdVRpbWVJbmZvKTsNCisgIFN0YXR1cyA9IFNhZmVVaW50 NjRNdWx0IChEZWxheU5zLCBDcHVGcmVxLCAmRGVsYXkpOw0KKyAgQVNTRVJUX0VGSV9FUlJPUiAo U3RhdHVzKTsNCisgIGlmIChFRklfRVJST1IgKFN0YXR1cykpIHsNCisgICAgREVCVUcgKChERUJV R19FUlJPUiwNCisgICAgICAgICJYZW5EZWxheSAoJWxkIG5zKTogZGVsYXkgdG9vIGJpZyBpbiBy ZWxhdGlvbiB0byBDUFUgZnJlcSAlbGQgSHpcbiIsDQorICAgICAgICBEZWxheU5zLCBDcHVGcmVx KSk7DQorICAgIENwdURlYWRMb29wICgpOw0KKyAgfQ0KKw0KKyAgRGVsYXlUaWNrID0gRGl2VTY0 eDMyIChEZWxheSwgMTAwMDAwMDAwMFVMKTsNCisNCisgIE5ld1RpY2sgPSBUaWNrICsgRGVsYXlU aWNrOw0KKw0KKyAgLy8NCisgIC8vIENoZWNrIGZvciBvdmVyZmxvdw0KKyAgLy8NCisgIGlmIChO ZXdUaWNrIDwgVGljaykgew0KKyAgICAvLw0KKyAgICAvLyBPdmVyZmxvdywgd2FpdCBmb3IgVFND IHRvIGFsc28gb3ZlcmZsb3cNCisgICAgLy8NCisgICAgd2hpbGUgKEFzbVJlYWRUc2MgKCkgPj0g VGljaykgew0KKyAgICAgIENwdVBhdXNlICgpOw0KKyAgICB9DQorICB9DQorDQorICB3aGlsZSAo QXNtUmVhZFRzYyAoKSA8PSBOZXdUaWNrKSB7DQorICAgIENwdVBhdXNlICgpOw0KKyAgfQ0KK30N CisNCisNCisvKioNCisgIENhbGN1bGF0ZSB0aGUgZnJlcXVlbmN5IG9mIHRoZSBMb2NhbCBBcGlj IFRpbWVyDQorKiovDQorVk9JRA0KK0NhbGlicmF0ZUxhcGljVGltZXIgKA0KKyAgVk9JRA0KKyAg KQ0KK3sNCisgIFhFTl9TSEFSRURfSU5GTyAgICAgICAqU2hhcmVkSW5mbzsNCisgIFhFTl9WQ1BV X1RJTUVfSU5GTyAgICAqVmNwdVRpbWVJbmZvOw0KKyAgVUlOVDMyICAgICAgICAgICAgICAgIFRp bWVyVGljaywgVGltZXJUaWNrMiwgRGlmZlRpbWVyOw0KKyAgVUlOVDY0ICAgICAgICAgICAgICAg IFRzY1RpY2ssIFRzY1RpY2syOw0KKyAgVUlOVDY0ICAgICAgICAgICAgICAgIEZyZXE7DQorICBV SU5UNjQgICAgICAgICAgICAgICAgRGl2aWRlbmQ7DQorICBFRklfU1RBVFVTICAgICAgICAgICAg U3RhdHVzOw0KKw0KKw0KKyAgU2hhcmVkSW5mbyA9IChWT0lEKikoKDFVTEwgPDwgbVBoeXNNZW1B ZGRyZXNzV2lkdGgpIC0gRUZJX1BBR0VfU0laRSk7DQorICBTdGF0dXMgPSBQaHlzaWNhbEFkZHJl c3NJZGVudGl0eU1hcHBpbmcgKChFRklfUEhZU0lDQUxfQUREUkVTUylTaGFyZWRJbmZvKTsNCisg IEFTU0VSVF9FRklfRVJST1IgKFN0YXR1cyk7DQorICBpZiAoRUZJX0VSUk9SIChTdGF0dXMpKSB7 DQorICAgIERFQlVHICgoREVCVUdfRVJST1IsDQorICAgICAgICAiRmFpbGVkIHRvIGFkZCBwYWdl IHRhYmxlIGVudHJ5IGZvciBYZW4gc2hhcmVkIGluZm8gcGFnZTogJXJcbiIsDQorICAgICAgICBT dGF0dXMpKTsNCisgICAgcmV0dXJuOw0KKyAgfQ0KKw0KKyAgU3RhdHVzID0gTWFwU2hhcmVkSW5m b1BhZ2UgKFNoYXJlZEluZm8pOw0KKyAgQVNTRVJUX0VGSV9FUlJPUiAoU3RhdHVzKTsNCisgIGlm IChFRklfRVJST1IgKFN0YXR1cykpIHsNCisgICAgREVCVUcgKChERUJVR19FUlJPUiwgIkZhaWxl ZCB0byBtYXAgWGVuJ3Mgc2hhcmVkIGluZm8gcGFnZTogJXJcbiIsDQorICAgICAgICBTdGF0dXMp KTsNCisgICAgcmV0dXJuOw0KKyAgfQ0KKw0KKyAgVmNwdVRpbWVJbmZvID0gJlNoYXJlZEluZm8t PlZjcHVJbmZvWzBdLlRpbWU7DQorDQorICBJbml0aWFsaXplQXBpY1RpbWVyICgxLCBNQVhfVUlO VDMyLCBUUlVFLCAwKTsNCisgIERpc2FibGVBcGljVGltZXJJbnRlcnJ1cHQgKCk7DQorDQorICBU aW1lclRpY2sgPSBHZXRBcGljVGltZXJDdXJyZW50Q291bnQgKCk7DQorICBUc2NUaWNrID0gQXNt UmVhZFRzYyAoKTsNCisgIFhlbkRlbGF5IChWY3B1VGltZUluZm8sIDEwMDAwMDBVTEwpOw0KKyAg VGltZXJUaWNrMiA9IEdldEFwaWNUaW1lckN1cnJlbnRDb3VudCAoKTsNCisgIFRzY1RpY2syID0g QXNtUmVhZFRzYyAoKTsNCisNCisNCisgIERpZmZUaW1lciA9IFRpbWVyVGljayAtIFRpbWVyVGlj azI7DQorICBTdGF0dXMgPSBTYWZlVWludDY0TXVsdCAoR2V0Q3B1RnJlcSAoVmNwdVRpbWVJbmZv KSwgRGlmZlRpbWVyLCAmRGl2aWRlbmQpOw0KKyAgQVNTRVJUX0VGSV9FUlJPUiAoU3RhdHVzKTsN CisgIGlmIChFRklfRVJST1IgKFN0YXR1cykpIHsNCisgICAgREVCVUcgKChERUJVR19FUlJPUiwg Im92ZXJmbG93IHdoaWxlIGNhbGN1bGF0aW5nIEFQSUMgZnJlcXVlbmN5XG4iKSk7DQorICAgIERF QlVHICgoREVCVUdfRVJST1IsICJDUFUgZnJlcTogJWxkIEh6OyBBUElDIHRpbWVyIHRpY2sgY291 bnQgZm9yIDEgbXM6ICVkXG4iLA0KKyAgICAgICAgR2V0Q3B1RnJlcSAoVmNwdVRpbWVJbmZvKSwg RGlmZlRpbWVyKSk7DQorICAgIENwdURlYWRMb29wICgpOw0KKyAgfQ0KKw0KKyAgRnJlcSA9IERp dlU2NHg2NFJlbWFpbmRlciAoRGl2aWRlbmQsIFRzY1RpY2syIC0gVHNjVGljaywgTlVMTCk7DQor ICBERUJVRyAoKERFQlVHX0lORk8sICJBUElDIEZyZXEgJSA4bHUgSHpcbiIsIEZyZXEpKTsNCisN CisgIFVubWFwWGVuUGFnZSAoU2hhcmVkSW5mbyk7DQorfQ0KLS0gCkFudGhvbnkgUEVSQVJECgo= From xen-devel-bounces@lists.xenproject.org Thu Mar 25 15:47:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 15:47:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101430.194066 (Exim 4.92) (envelope-from ) id 1lPSCs-0007nK-NP; Thu, 25 Mar 2021 15:47:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101430.194066; Thu, 25 Mar 2021 15:47:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSCs-0007nA-JT; Thu, 25 Mar 2021 15:47:34 +0000 Received: by outflank-mailman (input) for mailman id 101430; Thu, 25 Mar 2021 15:47:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSCr-0007aB-F3 for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 15:47:33 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 91115468-f32f-492c-94d9-9f0247d5b79e; Thu, 25 Mar 2021 15:47:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91115468-f32f-492c-94d9-9f0247d5b79e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616687241; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4G0liXTRoDoxxIpwz1j4AW2gX9FwMKi9LjHo2rv5814=; b=UFmXr3e+um0gQHcr6EYuUUR3wJ/DwqqAIX7cUKtC/i4WriTFs6eMSA5D VBuTfzcP4mv5bASl/rewfgwzTUgsljlaEgM9YibipzxOmTBLvwOykEdxV thJQRGFlKSSSgP0G/fW4NgEPmX4CCjtusJxsQ3uHBcYGLyyfESxoCYYFZ U=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: d5zVYAoBaPH2rc92zSFHnUOB+hyEuPfKp1nE0rWC6EKm1OIMuGPyJsJZyqI1QpTcbxsGN+idti 1hIfE8DfuOh3zPTFz4dXZ03ImCfsKDfxOSRLCvqtDV4EAv+ICVgXsnoqM8gALRXMMc9fAJa7po 5j1cDUWWU2F8z5a3kODXlAv2G/yYic+Dvv2KrrVl4z25JUUML4YGpNIJ7HeRt+TjmADGxXa8uw SZhvxAsp+B9kdKZuOTT6eP+29qqOyfJ+6/LLcnq1YG6S3LEf4GSE9grPaWKgRQcNcxPk3Pe4vE vBc= X-SBRS: 5.1 X-MesageID: 40500442 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:tWIFRqDV8spf94blHeh+sceALOonbusQ8zAX/mhsVB1YddGZnc iynPIdkST5kioVRWtIo729EYOLKEm9ybde544NMbC+GDT3oWfAFvAH0aLO4R3FXxf/+OlUyL t6f8FFYuHYIFBmga/BjzWQPM0nxLC8npyAocf74zNTQRpxa6dmhj0JbzqzNkFtXgFJCd4YOf Onl6l6jgGtc3gWcci3b0NtN4T+jubGiY78Zlo+DwMngTPksRqT9LX4HxKEty1uMQ9n/LFKyw n4uj283IqPmbWRyhjQ12jchq4m5efJ+594K+GnzuQQIjXooA60aIpmQK3qhkFInMifrGwEvf OJjxA8P9liy365RBDLnTLdnzPO/Rxry3j+xUSWiXHuyPaJOg4SOo56qq9yNj76gnBQ2+1U4e Zw8E+y86dzN1fmmh/w4tDZPisa7XackD4ZvsM4y0BEXZB2Us42kaUvuHl7Pb0nByzA5IUuAI BVfbvhzccTS1+cYnzD11MfueCEbzA2FheCdEAIptaY5ThQhGx41EsV3qUk7w89yK4= X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40500442" From: Anthony PERARD To: CC: , Jordan Justen , Anthony PERARD , "Ard Biesheuvel" , Laszlo Ersek , Julien Grall Subject: [PATCH v2 3/7] OvmfPkg/IndustryStandard/Xen: Apply EDK2 coding style to XEN_VCPU_TIME_INFO Date: Thu, 25 Mar 2021 15:47:09 +0000 Message-ID: <20210325154713.670104-4-anthony.perard@citrix.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210325154713.670104-1-anthony.perard@citrix.com> References: <20210325154713.670104-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain V2UgYXJlIGdvaW5nIHRvIHVzZSBuZXcgZmllbGRzIGZyb20gdGhlIFhlbiBoZWFkZXJzLiBBcHBs eSB0aGUgRURLMgpjb2Rpbmcgc3R5bGUgc28gdGhhdCB0aGUgY29kZSB0aGF0IGlzIGdvaW5nIHRv IHVzZSBpdCBkb2Vzbid0IGxvb2sgb3V0Cm9mIHBsYWNlLgoKUmVmOiBodHRwczovL2J1Z3ppbGxh LnRpYW5vY29yZS5vcmcvc2hvd19idWcuY2dpP2lkPTI0OTAKU2lnbmVkLW9mZi1ieTogQW50aG9u eSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBMYXN6bG8g RXJzZWsgPGxlcnNla0ByZWRoYXQuY29tPgotLS0KCk5vdGVzOgogICAgdjI6CiAgICAtIGZpeCBj YXNlIG9mIFRzYyogZmllbGQKCiBPdm1mUGtnL0luY2x1ZGUvSW5kdXN0cnlTdGFuZGFyZC9YZW4v eGVuLmggfCAxNyArKysrKysrKystLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9u cygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Pdm1mUGtnL0luY2x1ZGUvSW5kdXN0 cnlTdGFuZGFyZC9YZW4veGVuLmggYi9Pdm1mUGtnL0luY2x1ZGUvSW5kdXN0cnlTdGFuZGFyZC9Y ZW4veGVuLmgKaW5kZXggZTU1ZDkzMjYzMjg1Li43OWE0ZTIxMmU3YzIgMTAwNjQ0Ci0tLSBhL092 bWZQa2cvSW5jbHVkZS9JbmR1c3RyeVN0YW5kYXJkL1hlbi94ZW4uaAorKysgYi9Pdm1mUGtnL0lu Y2x1ZGUvSW5kdXN0cnlTdGFuZGFyZC9YZW4veGVuLmgKQEAgLTE4MywxMCArMTgzLDEwIEBAIHN0 cnVjdCB2Y3B1X3RpbWVfaW5mbyB7CiAgICAgICogVGhlIGNvcnJlY3Qgd2F5IHRvIGludGVyYWN0 IHdpdGggdGhlIHZlcnNpb24gbnVtYmVyIGlzIHNpbWlsYXIgdG8NCiAgICAgICogTGludXgncyBz ZXFsb2NrOiBzZWUgdGhlIGltcGxlbWVudGF0aW9ucyBvZiByZWFkX3NlcWJlZ2luL3JlYWRfc2Vx cmV0cnkuDQogICAgICAqLw0KLSAgICBVSU5UMzIgdmVyc2lvbjsNCisgICAgVUlOVDMyIFZlcnNp b247DQogICAgIFVJTlQzMiBwYWQwOw0KLSAgICBVSU5UNjQgdHNjX3RpbWVzdGFtcDsgICAvKiBU U0MgYXQgbGFzdCB1cGRhdGUgb2YgdGltZSB2YWxzLiAgKi8NCi0gICAgVUlOVDY0IHN5c3RlbV90 aW1lOyAgICAgLyogVGltZSwgaW4gbmFub3NlY3MsIHNpbmNlIGJvb3QuICAgICovDQorICAgIFVJ TlQ2NCBUc2NUaW1lc3RhbXA7ICAgLyogVFNDIGF0IGxhc3QgdXBkYXRlIG9mIHRpbWUgdmFscy4g ICovDQorICAgIFVJTlQ2NCBTeXN0ZW1UaW1lOyAgICAgLyogVGltZSwgaW4gbmFub3NlY3MsIHNp bmNlIGJvb3QuICAgICovDQogICAgIC8qDQogICAgICAqIEN1cnJlbnQgc3lzdGVtIHRpbWU6DQog ICAgICAqICAgc3lzdGVtX3RpbWUgKw0KQEAgLTE5NCwxMSArMTk0LDExIEBAIHN0cnVjdCB2Y3B1 X3RpbWVfaW5mbyB7CiAgICAgICogQ1BVIGZyZXF1ZW5jeSAoSHopOg0KICAgICAgKiAgICgoMTBe OSA8PCAzMikgLyB0c2NfdG9fc3lzdGVtX211bCkgPj4gdHNjX3NoaWZ0DQogICAgICAqLw0KLSAg ICBVSU5UMzIgdHNjX3RvX3N5c3RlbV9tdWw7DQotICAgIElOVDggICB0c2Nfc2hpZnQ7DQorICAg IFVJTlQzMiBUc2NUb1N5c3RlbU11bHRpcGxpZXI7DQorICAgIElOVDggICBUc2NTaGlmdDsNCiAg ICAgSU5UOCAgIHBhZDFbM107DQogfTsgLyogMzIgYnl0ZXMgKi8NCi10eXBlZGVmIHN0cnVjdCB2 Y3B1X3RpbWVfaW5mbyB2Y3B1X3RpbWVfaW5mb190Ow0KK3R5cGVkZWYgc3RydWN0IHZjcHVfdGlt ZV9pbmZvIFhFTl9WQ1BVX1RJTUVfSU5GTzsNCiANCiBzdHJ1Y3QgdmNwdV9pbmZvIHsNCiAgICAg LyoNCkBAIC0yMzQsNyArMjM0LDcgQEAgc3RydWN0IHZjcHVfaW5mbyB7CiAjZW5kaWYgLyogWEVO X0hBVkVfUFZfVVBDQUxMX01BU0sgKi8NCiAgICAgeGVuX3Vsb25nX3QgZXZ0Y2huX3BlbmRpbmdf c2VsOw0KICAgICBzdHJ1Y3QgYXJjaF92Y3B1X2luZm8gYXJjaDsNCi0gICAgc3RydWN0IHZjcHVf dGltZV9pbmZvIHRpbWU7DQorICAgIHN0cnVjdCB2Y3B1X3RpbWVfaW5mbyBUaW1lOw0KIH07IC8q IDY0IGJ5dGVzICh4ODYpICovDQogI2lmbmRlZiBfX1hFTl9fDQogdHlwZWRlZiBzdHJ1Y3QgdmNw dV9pbmZvIHZjcHVfaW5mb190Ow0KQEAgLTI1MCw3ICsyNTAsNyBAQCB0eXBlZGVmIHN0cnVjdCB2 Y3B1X2luZm8gdmNwdV9pbmZvX3Q7CiAgKiBvZiB0aGlzIHN0cnVjdHVyZSByZW1haW5pbmcgY29u c3RhbnQuDQogICovDQogc3RydWN0IHNoYXJlZF9pbmZvIHsNCi0gICAgc3RydWN0IHZjcHVfaW5m byB2Y3B1X2luZm9bWEVOX0xFR0FDWV9NQVhfVkNQVVNdOw0KKyAgICBzdHJ1Y3QgdmNwdV9pbmZv IFZjcHVJbmZvW1hFTl9MRUdBQ1lfTUFYX1ZDUFVTXTsNCiANCiAgICAgLyoNCiAgICAgICogQSBk b21haW4gY2FuIGNyZWF0ZSAiZXZlbnQgY2hhbm5lbHMiIG9uIHdoaWNoIGl0IGNhbiBzZW5kIGFu ZCByZWNlaXZlDQpAQCAtMjk5LDYgKzI5OSw3IEBAIHN0cnVjdCBzaGFyZWRfaW5mbyB7CiB9Ow0K ICNpZm5kZWYgX19YRU5fXw0KIHR5cGVkZWYgc3RydWN0IHNoYXJlZF9pbmZvIHNoYXJlZF9pbmZv X3Q7DQordHlwZWRlZiBzdHJ1Y3Qgc2hhcmVkX2luZm8gWEVOX1NIQVJFRF9JTkZPOw0KICNlbmRp Zg0KIA0KIC8qIFR1cm4gYSBwbGFpbiBudW1iZXIgaW50byBhIEMgVUlOVE4gY29uc3RhbnQuICov DQotLSAKQW50aG9ueSBQRVJBUkQKCg== From xen-devel-bounces@lists.xenproject.org Thu Mar 25 15:47:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 15:47:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101431.194079 (Exim 4.92) (envelope-from ) id 1lPSCy-0007ut-3d; Thu, 25 Mar 2021 15:47:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101431.194079; Thu, 25 Mar 2021 15:47:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSCx-0007uk-W9; Thu, 25 Mar 2021 15:47:39 +0000 Received: by outflank-mailman (input) for mailman id 101431; Thu, 25 Mar 2021 15:47:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSCw-0007aB-FD for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 15:47:38 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 90e61a9d-c67b-48fb-ad67-314c0884c5f5; Thu, 25 Mar 2021 15:47:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90e61a9d-c67b-48fb-ad67-314c0884c5f5 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616687244; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HuIUXo43JiGC6QHvcYLXvEgyMc8GCHFyAMB5JBDUT0U=; b=FRuRpojdVj5iOvEoW+dxlyMCODHl+a/a1WUbr1aAAH08GFtesLTcoDLI 9/7rpVxsfRY/woWScGy3TK+SjfeIZbgWNlxC0tqtABY/wE00Q+NQuHn5J BqyAXrjAA7LhdZp06Djq4BKb72sRNVix3icQAKYhQTi6jLwTWjsKJa6hV A=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: d14wjqQx1UXoMjRctiLYpxhGJHIvK94eQ5c4s89qozIWZQl4KaUHiA3YgwQSaIndFMJzBguBbN 9IzeDXGfoziG3zgZkF8T7Z6jXwxSvbHuNZteB7SBz0bD8wp9azfKqst/LXRuXFKCWHazbYvwIG qsNe2/fjTVOhnELAYg5oT5DoD8p+zOILaJwG0Ne31W+M1HtibMhGIOxAVUyFtTx/JHpWDlkIF7 l3KUNFv5kNfZcFlNLtp5ZdLzN0xKEWDtkQohQm5UC9xNsp4tNbvdtuh+M/XOoc+0RzNGiHjBo4 92E= X-SBRS: 5.1 X-MesageID: 40144197 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:z3JXcq0XqT5hO2K8TIRbEQqjBZFyeYIsi2QD101hICF9WsaTm9 my2NES0hHpgDgcMUtQ4uyoEoPoewK+ybde544NMbC+GCzvv2W1JI9vhLGSuQHIMSv46+JbyO NcY7FzYeeAfGRSoOTbxE2DE9gmyMSa66zAv4zj5lpkUA0CUdAG0y5XEQCee3cWeCBnAt4DGI OY9o57oVObCAwqR+ShAH49WfPf4+fnr/vdCyIuIz4CxE2wgSiz6Lj8eiLoris2dz9U278t/S zkvmXCl8Oemsq2wBPdyGPfhq4+8LaMpbV+LfeBhcQPJjLnhhzAXvUZZ5S4sC0ou+bq0V42kb D30mQdFv5u4HDcdHzdm2qO5yDc0S0j43Kn6ViUjWqLm72ceBsGCtFMjY8cTx3B60BIhqAY7I t32Qui16Z/PFflpmDd78KNfwx2nkC0yEBS7NI7vjh6a88iT5N/6aYY51hYFZ8cGjmS0vFaLM B+SMvb4O9fdkPyVQGmgkB/hNq2XnoyGR+aQk8N/syNugIm40xE8w== X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40144197" From: Anthony PERARD To: CC: , Jordan Justen , Anthony PERARD , "Ard Biesheuvel" , Laszlo Ersek , Julien Grall Subject: [PATCH v2 5/7] OvmfPkg/XenPlatformPei: Map extra physical address Date: Thu, 25 Mar 2021 15:47:11 +0000 Message-ID: <20210325154713.670104-6-anthony.perard@citrix.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210325154713.670104-1-anthony.perard@citrix.com> References: <20210325154713.670104-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain U29tZSBpbmZvcm1hdGlvbiBhdmFpbGFibGUgaW4gYSBYZW4gZ3Vlc3QgY2FuIGJlIG1hcHBlZCBh bnl3aGVyZSBpbgp0aGUgcGh5c2ljYWwgYWRkcmVzcyBzcGFjZSBhbmQgdGhleSBkb24ndCBuZWVk IHRvIGJlIGJhY2tlZCBieSBSQU0uCkZvciBleGFtcGxlLCB0aGUgc2hhcmVkIGluZm8gcGFnZS4K CldoaWxlIGl0J3MgZWFzaWVyIHRvIHB1dCB0aG9zZSBwYWdlcyBhbnl3aGVyZSwgaXQgaXMgYmV0 dGVyIHRvIGF2b2lkCm1hcHBpbmcgaXQgd2hlcmUgdGhlIFJBTSBpcy4gSXQgbWlnaHQgc3BsaXQg YSBuaWNlIDFHIGd1ZXN0IHBhZ2UgdGFibGUKaW50byA0ayBwYWdlcyBhbmQgdGh1cyByZWR1Y2lu ZyBwZXJmb3JtYW5jZSBvZiB0aGUgZ3Vlc3Qgd2hlbiBpdAphY2Nlc3MgaXRzIG1lbW9yeS4gQWxz byBtYXBwaW5nIGEgcGFnZSBsaWtlIHRoZSBzaGFyZWQgaW5mbyBwYWdlIGFuZAp0aGVuIHVubWFw cGluZyBpdCBvciBtYXBwaW5nIGl0IHNvbWV3aGVyZSBlbHNlIHdvdWxkIGxpdmUgYSBob2xlIGlu CnRoZSBSQU0gdGhhdCB0aGUgZ3Vlc3Qgd291bGQgcHJvcGFibHkgbm90IGJlZW4gYWJsZSB0byB1 c2UgYW55bW9yZS4KClNvIHRoZSBwYXRjaCBpbnRyb2R1Y2UgYSBuZXcgZnVuY3Rpb24gd2hpY2gg Y2FuIGJlIHVzZWQgdG8gMToxCm1hcHBpbmcgb2YgZ3Vlc3QgcGh5c2ljYWwgbWVtb3J5IGFib3Zl IDRHIGR1cmluZyB0aGUgUEVJIHBoYXNlIHNvIHdlCmNhbiBtYXAgdGhlIFhlbiBzaGFyZWQgcGFn ZXMgb3V0c2lkZSBvZiBtZW1vcnkgdGhhdCBjYW4gYmUgdXNlZCBieQpndWVzdCwgYW5kIGFzIGhp Z2ggYXMgcG9zc2libGUuCgpTaWduZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5w ZXJhcmRAY2l0cml4LmNvbT4KLS0tCgpOb3RlczoKICAgIHYyOgogICAgLSBuZXcgcGF0Y2gKCiBP dm1mUGtnL1hlblBsYXRmb3JtUGVpL1hlblBsYXRmb3JtUGVpLmluZiB8ICAxICsKIE92bWZQa2cv WGVuUGxhdGZvcm1QZWkvUGxhdGZvcm0uaCAgICAgICAgIHwgIDUgKysKIE92bWZQa2cvWGVuUGxh dGZvcm1QZWkvWGVuLmMgICAgICAgICAgICAgIHwgNzEgKysrKysrKysrKysrKysrKysrKysrKysK IDMgZmlsZXMgY2hhbmdlZCwgNzcgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL092bWZQa2cv WGVuUGxhdGZvcm1QZWkvWGVuUGxhdGZvcm1QZWkuaW5mIGIvT3ZtZlBrZy9YZW5QbGF0Zm9ybVBl aS9YZW5QbGF0Zm9ybVBlaS5pbmYKaW5kZXggMGVmNzdkYjkyYzAzLi44NzkwZDkwN2QzZWMgMTAw NjQ0Ci0tLSBhL092bWZQa2cvWGVuUGxhdGZvcm1QZWkvWGVuUGxhdGZvcm1QZWkuaW5mCisrKyBi L092bWZQa2cvWGVuUGxhdGZvcm1QZWkvWGVuUGxhdGZvcm1QZWkuaW5mCkBAIC02Niw2ICs2Niw3 IEBAIFtQY2RdCiAgIGdVZWZpT3ZtZlBrZ1Rva2VuU3BhY2VHdWlkLlBjZE92bWZQZWlNZW1GdlNp emUNCiAgIGdVZWZpT3ZtZlBrZ1Rva2VuU3BhY2VHdWlkLlBjZE92bWZEeGVNZW1GdkJhc2UNCiAg IGdVZWZpT3ZtZlBrZ1Rva2VuU3BhY2VHdWlkLlBjZE92bWZEeGVNZW1GdlNpemUNCisgIGdVZWZp T3ZtZlBrZ1Rva2VuU3BhY2VHdWlkLlBjZE92bWZTZWNQYWdlVGFibGVzQmFzZQ0KICAgZ1VlZmlP dm1mUGtnVG9rZW5TcGFjZUd1aWQuUGNkT3ZtZkxvY2tCb3hTdG9yYWdlQmFzZQ0KICAgZ1VlZmlP dm1mUGtnVG9rZW5TcGFjZUd1aWQuUGNkT3ZtZkxvY2tCb3hTdG9yYWdlU2l6ZQ0KICAgZ1VlZmlP dm1mUGtnVG9rZW5TcGFjZUd1aWQuUGNkT3ZtZkhvc3RCcmlkZ2VQY2lEZXZJZA0KZGlmZiAtLWdp dCBhL092bWZQa2cvWGVuUGxhdGZvcm1QZWkvUGxhdGZvcm0uaCBiL092bWZQa2cvWGVuUGxhdGZv cm1QZWkvUGxhdGZvcm0uaAppbmRleCA3NjYxZjRhOGRlMGEuLmU3MGNhNTgwNzhlYiAxMDA2NDQK LS0tIGEvT3ZtZlBrZy9YZW5QbGF0Zm9ybVBlaS9QbGF0Zm9ybS5oCisrKyBiL092bWZQa2cvWGVu UGxhdGZvcm1QZWkvUGxhdGZvcm0uaApAQCAtMTI3LDYgKzEyNywxMSBAQCBYZW5HZXRFODIwTWFw ICgKICAgVUlOVDMyICpDb3VudA0KICAgKTsNCiANCitFRklfU1RBVFVTDQorUGh5c2ljYWxBZGRy ZXNzSWRlbnRpdHlNYXBwaW5nICgNCisgIElOIEVGSV9QSFlTSUNBTF9BRERSRVNTIEFkZHJlc3NU b01hcA0KKyAgKTsNCisNCiBleHRlcm4gRUZJX0JPT1RfTU9ERSBtQm9vdE1vZGU7DQogDQogZXh0 ZXJuIFVJTlQ4IG1QaHlzTWVtQWRkcmVzc1dpZHRoOw0KZGlmZiAtLWdpdCBhL092bWZQa2cvWGVu UGxhdGZvcm1QZWkvWGVuLmMgYi9Pdm1mUGtnL1hlblBsYXRmb3JtUGVpL1hlbi5jCmluZGV4IGM0 MWZlY2RjNDg2ZS4uYjJhN2QxYzIxZGFjIDEwMDY0NAotLS0gYS9Pdm1mUGtnL1hlblBsYXRmb3Jt UGVpL1hlbi5jCisrKyBiL092bWZQa2cvWGVuUGxhdGZvcm1QZWkvWGVuLmMKQEAgLTE3LDYgKzE3 LDggQEAKIC8vDQogLy8gVGhlIExpYnJhcnkgY2xhc3NlcyB0aGlzIG1vZHVsZSBjb25zdW1lcw0K IC8vDQorI2luY2x1ZGUgPExpYnJhcnkvQmFzZU1lbW9yeUxpYi5oPg0KKyNpbmNsdWRlIDxMaWJy YXJ5L0NwdUxpYi5oPg0KICNpbmNsdWRlIDxMaWJyYXJ5L0RlYnVnTGliLmg+DQogI2luY2x1ZGUg PExpYnJhcnkvSG9iTGliLmg+DQogI2luY2x1ZGUgPExpYnJhcnkvTWVtb3J5QWxsb2NhdGlvbkxp Yi5oPg0KQEAgLTI1LDYgKzI3LDcgQEAKICNpbmNsdWRlIDxJbmR1c3RyeVN0YW5kYXJkL0U4MjAu aD4NCiAjaW5jbHVkZSA8TGlicmFyeS9SZXNvdXJjZVB1YmxpY2F0aW9uTGliLmg+DQogI2luY2x1 ZGUgPExpYnJhcnkvTXRyckxpYi5oPg0KKyNpbmNsdWRlIDxJbmR1c3RyeVN0YW5kYXJkL1BhZ2VU YWJsZS5oPg0KICNpbmNsdWRlIDxJbmR1c3RyeVN0YW5kYXJkL1hlbi9hcmNoLXg4Ni9odm0vc3Rh cnRfaW5mby5oPg0KICNpbmNsdWRlIDxMaWJyYXJ5L1hlbkh5cGVyY2FsbExpYi5oPg0KICNpbmNs dWRlIDxJbmR1c3RyeVN0YW5kYXJkL1hlbi9tZW1vcnkuaD4NCkBAIC0zODYsMyArMzg5LDcxIEBA IEluaXRpYWxpemVYZW4gKAogDQogICByZXR1cm4gRUZJX1NVQ0NFU1M7DQogfQ0KKw0KK0VGSV9T VEFUVVMNCitQaHlzaWNhbEFkZHJlc3NJZGVudGl0eU1hcHBpbmcgKA0KKyAgSU4gRUZJX1BIWVNJ Q0FMX0FERFJFU1MgICBBZGRyZXNzVG9NYXANCisgICkNCit7DQorICBJTlROICAgICAgICAgICAg ICAgICAgICAgICAgICAgIEluZGV4Ow0KKyAgUEFHRV9NQVBfQU5EX0RJUkVDVE9SWV9QT0lOVEVS ICAqTDQsICpMMzsNCisgIFBBR0VfVEFCTEVfRU5UUlkgICAgICAgICAgICAgICAgKlBhZ2VUYWJs ZTsNCisNCisgIERFQlVHICgoREVCVUdfSU5GTywgIk1hcHBpbmcgMToxIG9mIGFkZHJlc3MgMHgl bHhcbiIsIChVSU5UNjQpQWRkcmVzc1RvTWFwKSk7DQorDQorICAvLyBMNCAvIFRvcCBsZXZlbCBQ YWdlIERpcmVjdG9yeSBQb2ludGVycw0KKw0KKyAgTDQgPSAoVk9JRCopKFVJTlROKVBjZEdldDMy IChQY2RPdm1mU2VjUGFnZVRhYmxlc0Jhc2UpOw0KKyAgSW5kZXggPSBQTUw0X09GRlNFVCAoQWRk cmVzc1RvTWFwKTsNCisNCisgIGlmICghTDRbSW5kZXhdLkJpdHMuUHJlc2VudCkgew0KKyAgICBM MyA9IEFsbG9jYXRlUGFnZXMgKDEpOw0KKyAgICBpZiAoTDMgPT0gTlVMTCkgew0KKyAgICAgIHJl dHVybiBFRklfT1VUX09GX1JFU09VUkNFUzsNCisgICAgfQ0KKw0KKyAgICBaZXJvTWVtIChMMywg RUZJX1BBR0VfU0laRSk7DQorDQorICAgIEw0W0luZGV4XS5CaXRzLlJlYWRXcml0ZSA9IDE7DQor ICAgIEw0W0luZGV4XS5CaXRzLkFjY2Vzc2VkID0gMTsNCisgICAgTDRbSW5kZXhdLkJpdHMuUGFn ZVRhYmxlQmFzZUFkZHJlc3MgPSAoRUZJX1BIWVNJQ0FMX0FERFJFU1MpTDMgPj4gMTI7DQorICAg IEw0W0luZGV4XS5CaXRzLlByZXNlbnQgPSAxOw0KKyAgfQ0KKw0KKyAgLy8gTDMgLyBOZXh0IGxl dmVsIFBhZ2UgRGlyZWN0b3J5IFBvaW50ZXJzDQorDQorICBMMyA9IChWT0lEKikoRUZJX1BIWVNJ Q0FMX0FERFJFU1MpKEw0W0luZGV4XS5CaXRzLlBhZ2VUYWJsZUJhc2VBZGRyZXNzIDw8IDEyKTsN CisgIEluZGV4ID0gUERQX09GRlNFVCAoQWRkcmVzc1RvTWFwKTsNCisNCisgIGlmICghTDNbSW5k ZXhdLkJpdHMuUHJlc2VudCkgew0KKyAgICBQYWdlVGFibGUgPSBBbGxvY2F0ZVBhZ2VzICgxKTsN CisgICAgaWYgKFBhZ2VUYWJsZSA9PSBOVUxMKSB7DQorICAgICAgcmV0dXJuIEVGSV9PVVRfT0Zf UkVTT1VSQ0VTOw0KKyAgICB9DQorDQorICAgIFplcm9NZW0gKFBhZ2VUYWJsZSwgRUZJX1BBR0Vf U0laRSk7DQorDQorICAgIEwzW0luZGV4XS5CaXRzLlJlYWRXcml0ZSA9IDE7DQorICAgIEwzW0lu ZGV4XS5CaXRzLkFjY2Vzc2VkID0gMTsNCisgICAgTDNbSW5kZXhdLkJpdHMuUGFnZVRhYmxlQmFz ZUFkZHJlc3MgPSAoRUZJX1BIWVNJQ0FMX0FERFJFU1MpUGFnZVRhYmxlID4+IDEyOw0KKyAgICBM M1tJbmRleF0uQml0cy5QcmVzZW50ID0gMTsNCisgIH0NCisNCisgIC8vIEwyIC8gUGFnZSBUYWJs ZSBFbnRyaWVzDQorDQorICBQYWdlVGFibGUgPSAoVk9JRCopKEVGSV9QSFlTSUNBTF9BRERSRVNT KShMM1tJbmRleF0uQml0cy5QYWdlVGFibGVCYXNlQWRkcmVzcyA8PCAxMik7DQorICBJbmRleCA9 IFBERV9PRkZTRVQgKEFkZHJlc3NUb01hcCk7DQorDQorICBpZiAoIVBhZ2VUYWJsZVtJbmRleF0u Qml0cy5QcmVzZW50KSB7DQorICAgIFBhZ2VUYWJsZVtJbmRleF0uQml0cy5SZWFkV3JpdGUgPSAx Ow0KKyAgICBQYWdlVGFibGVbSW5kZXhdLkJpdHMuQWNjZXNzZWQgPSAxOw0KKyAgICBQYWdlVGFi bGVbSW5kZXhdLkJpdHMuRGlydHkgPSAxOw0KKyAgICBQYWdlVGFibGVbSW5kZXhdLkJpdHMuTXVz dEJlMSA9IDE7DQorICAgIFBhZ2VUYWJsZVtJbmRleF0uQml0cy5QYWdlVGFibGVCYXNlQWRkcmVz cyA9IEFkZHJlc3NUb01hcCA+PiAyMTsNCisgICAgUGFnZVRhYmxlW0luZGV4XS5CaXRzLlByZXNl bnQgPSAxOw0KKyAgfQ0KKw0KKyAgQ3B1Rmx1c2hUbGIgKCk7DQorDQorICByZXR1cm4gRUZJX1NV Q0NFU1M7DQorfQ0KLS0gCkFudGhvbnkgUEVSQVJECgo= From xen-devel-bounces@lists.xenproject.org Thu Mar 25 15:47:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 15:47:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101435.194091 (Exim 4.92) (envelope-from ) id 1lPSD2-000821-Om; Thu, 25 Mar 2021 15:47:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101435.194091; Thu, 25 Mar 2021 15:47:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSD2-00081q-J6; Thu, 25 Mar 2021 15:47:44 +0000 Received: by outflank-mailman (input) for mailman id 101435; Thu, 25 Mar 2021 15:47:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSD1-0007aB-FS for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 15:47:43 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 24bc23c7-a82f-4d74-a313-cf5a4ff99df6; Thu, 25 Mar 2021 15:47:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24bc23c7-a82f-4d74-a313-cf5a4ff99df6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616687247; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9NIhmInwFrEyRfF/0lSClNIrgZWInTJXzd/zYMEZRIY=; b=ZAr701+KvOpLohM4d9X2X4uGGhN85izEGHT9REjZC22LJTkMvndNqpxS djRk/LvYzNHCSP03jKb8QsrPmhTZ+WEja1EV7ytLvkQEAN1/rqb8Vn6WJ sMwb8ZJWAuPDLGS3xynYvguac2UYeEDV61Y6QYd+2ZLdz0eo0TT/9RvK3 M=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: QFQ1b6fWFHLgb+DjGLN6WF/XkBqAje0fgdLo8kJXuhuKCfvWyOq3oikI8sgAanJR2P6PbS+qPy 3D28XJzkRYLzcu9J6FEThhoIDDWo+6oK091dtrda6s5mu0ZATAr1qzD99MTmqCwp3jhvurbvs3 HYAA2NnMLNv7MnOBI6QqIXzkA/YXx1HTt6LIxi+exNDftkR796KphVIQ3dJLIw6z7U1WgEm8C0 HCOBYP4/jRSQxbKCPsWvZnnlG1f89jNHrBnPHZ8RX6W6kuJqdadUMjsfEfnXPFJ2OwWfrk3YXB mGM= X-SBRS: 5.1 X-MesageID: 40123477 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:5QOVKqEOtvtoO/FZpLqFOpHXdLJzesId70hD6mlYVQFVfsuEl8 qngfQc0lvOhCwMXWw78OrsBICrSxrnlaJdy48XILukQU3aqHKlRbsSibfK7h/BP2nF9uBb3b p9aKQWMrfNJHVzkMqS2maFOvk6xt3vys6VrMP/61socg1wcaFn6G5Ce2OmO2l7XhNPC5Z8NL f03LslmxOadX4abtu2CxA+NoCum/TxmI/7ehlDPhY76WC15g+A0qLwEBSTw34lIlFy6IolmF KlryXJop+Nntv+4R/a2m/V4f1t6abc4+oGPuOgoIw4Lj3tjyyheYhuXaaT1QpF3N2H2RIRv/ Tn5zsmIsRv+1PdF1vF3ifF6k3b/xsFr1/k1FOCjnPoraXCNUwHIvsEv611WF/9ySMbzbZB+Z MO5U21nd5rKCmFuyLH693BR3hR5zGJiEtnq8E/pThiS4cEAYUhy7A3zQduP7orOjn104wjGP kGNrCn2N9mNWmXaH3UpQBUsaWRd0V2Gh+HR34LsdCO3w5Xm2hkz1AZyNZ3pAZ5yK4A X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40123477" From: Anthony PERARD To: CC: , Jordan Justen , Anthony PERARD , "Ard Biesheuvel" , Laszlo Ersek , Julien Grall Subject: [PATCH v2 7/7] OvmfPkg/OvmfXen: Set PcdFSBClock Date: Thu, 25 Mar 2021 15:47:13 +0000 Message-ID: <20210325154713.670104-8-anthony.perard@citrix.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210325154713.670104-1-anthony.perard@citrix.com> References: <20210325154713.670104-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain VXBkYXRlIGdFZmlNZGVQa2dUb2tlblNwYWNlR3VpZC5QY2RGU0JDbG9jayBzbyBpdCBjYW4gaGF2 ZSB0aGUgY29ycmVjdAp2YWx1ZSB3aGVuIFNlY1BlaUR4ZVRpbWVyTGliQ3B1IHN0YXJ0IHRvIHVz ZSBpdCBmb3IgdGhlIEFQSUMgdGltZXIuCgpDdXJyZW50bHksIG5vdGhpbmcgYXBwZWFyIHRvIHVz ZSB0aGUgdmFsdWUgaW4gUGNkRlNCQ2xvY2sgYmVmb3JlClhlblBsYXRmb3JtUGVpIGhhZCBhIGNo YW5jZSB0byBzZXQgaXQgZXZlbiB0aG91Z2ggVGltZXJMaWIgaXMgaW5jbHVkZWQKaW4gbW9kdWxl cyBydW5uZWQgYmVmb3JlIFhlblBsYXRmb3JtUGVpLgoKWGVuUGxhdGZvcm1QZWkgZG9lc24ndCB1 c2UgYW55IG9mIHRoZSBmdW5jdGlvbnMgdGhhdCB3b3VsZCB1c2UgdGhhdAp2YWx1ZS4gTm8gb3Ro ZXIgbW9kdWxlcyBpbiB0aGUgUEVJIHBoYXNlIHNlZW1zIHRvIHVzZSB0aGUgVGltZXJMaWIKYmVm b3JlIFBjZEZTQkNsb2NrIGlzIHNldC4gVGhlcmUgYXJlIGN1cnJlbnRseSB0d28gb3RoZXIgbW9k dWxlcyBpbgp0aGUgUEVJIHBoYXNlIHRoYXQgbmVlZHMgdGhlIFRpbWVyTGliOgotIFMzUmVzdW1l MlBlaSwgYnV0IG9ubHkgYmVjYXVzZSBMb2NhbEFwaWNMaWIgbmVlZHMgaXQsIGJ1dCBub3RoaW5n IGlzCiAgdXNpbmcgdGhlIHZhbHVlIGZyb20gUGNkRlNCQ2xvY2suCi0gQ3B1TXBQZWksIGJ1dCBJ IGJlbGlldmUgaXQgb25seSBydW5zIGFmdGVyIFhlblBsYXRmb3JtUGVpCgpCZWZvcmUgdGhlIFBF SSBwaGFzZSwgdGhlcmUncyB0aGUgU0VDIHBoYXNlLCBhbmQgU2VjTWFpbiBuZWVkcwpUaW1lckxp YiBiZWNhdXNlIG9mIExvY2FsQXBpY0xpYi4gQW5kIGl0IGluaXRpYWxpc2UgdGhlIEFQSUMgdGlt ZXJzCmZvciB0aGUgZGVidWcgYWdlbnQuIEJ1dCBJIGRvbid0IHRoaW5rIGFueSBvZiB0aGUgRGVi dWdMaWIgdGhhdApPdm1mWGVuIGNvdWxkIHVzZSBhcmUgYWN0dWFsbHkgdXNpbmcgdGhlICpEZWxh eSBmdW5jdGlvbnMgaW4gVGltZXJMaWIsCmFuZCBzbyB3b3VsZCBub3QgdXNlIHRoZSB2YWx1ZSBm cm9tIFBjZEZTQkNsb2NrIHdoaWNoIHdvdWxkIGJlCnVuaW5pdGlhbGlzZWQuCgpBIHNpbXBsZSBy dW50aW1lIHRlc3Qgc2hvd2VkIHRoYXQgVGltZXJMaWIgZG9lc24ndCB1c2UgUGNkRlNCQ2xvY2sK dmFsdWUgYmVmb3JlIGl0IGlzIHNldC4KClJlZjogaHR0cHM6Ly9idWd6aWxsYS50aWFub2NvcmUu b3JnL3Nob3dfYnVnLmNnaT9pZD0yNDkwClNpZ25lZC1vZmYtYnk6IEFudGhvbnkgUEVSQVJEIDxh bnRob255LnBlcmFyZEBjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogTGFzemxvIEVyc2VrIDxsZXJz ZWtAcmVkaGF0LmNvbT4KLS0tCgpOb3RlczoKICAgIHYyOgogICAgLSBrZWVwIHRoZSBkZWZhdWx0 IHZhbHVlIG9mIFBjZEZTQkNsb2NrIGJlY2F1c2UgdGhhdCBpcyBwYXJ0IG9mIHRoZSBzeW50YXgu CgogT3ZtZlBrZy9Pdm1mWGVuLmRzYyAgICAgICAgICAgICAgICAgICAgICAgfCA0ICstLS0KIE92 bWZQa2cvWGVuUGxhdGZvcm1QZWkvWGVuUGxhdGZvcm1QZWkuaW5mIHwgMSArCiBPdm1mUGtnL1hl blBsYXRmb3JtUGVpL1hlbi5jICAgICAgICAgICAgICB8IDQgKysrKwogMyBmaWxlcyBjaGFuZ2Vk LCA2IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvT3ZtZlBrZy9P dm1mWGVuLmRzYyBiL092bWZQa2cvT3ZtZlhlbi5kc2MKaW5kZXggNTA3MDI5NDA0ZjBiLi5mYWYz OTMwYWNlMDQgMTAwNjQ0Ci0tLSBhL092bWZQa2cvT3ZtZlhlbi5kc2MKKysrIGIvT3ZtZlBrZy9P dm1mWGVuLmRzYwpAQCAtNDQyLDkgKzQ0Miw2IEBAIFtQY2RzRml4ZWRBdEJ1aWxkXQogICAjIFBv aW50IHRvIHRoZSBNZGVNb2R1bGVQa2cvQXBwbGljYXRpb24vVWlBcHAvVWlBcHAuaW5mDQogICBn RWZpTWRlTW9kdWxlUGtnVG9rZW5TcGFjZUd1aWQuUGNkQm9vdE1hbmFnZXJNZW51RmlsZXx7IDB4 MjEsIDB4YWEsIDB4MmMsIDB4NDYsIDB4MTQsIDB4NzYsIDB4MDMsIDB4NDUsIDB4ODMsIDB4NmUs IDB4OGEsIDB4YjYsIDB4ZjQsIDB4NjYsIDB4MjMsIDB4MzEgfQ0KIA0KLSAgIyMgWGVuIHZsYXBp YydzIGZyZXF1ZW5jZSBpcyAxMDAgTUh6DQotICBnRWZpTWRlUGtnVG9rZW5TcGFjZUd1aWQuUGNk RlNCQ2xvY2t8MTAwMDAwMDAwDQotDQogICAjIFdlIHBvcHVsYXRlIERYRSBJUEwgdGFibGVzIHdp dGggMUcgcGFnZXMgcHJlZmVyYWJseSBvbiBYZW4NCiAgIGdFZmlNZGVNb2R1bGVQa2dUb2tlblNw YWNlR3VpZC5QY2RVc2UxR1BhZ2VUYWJsZXxUUlVFDQogDQpAQCAtNDcxLDYgKzQ2OCw3IEBAIFtQ Y2RzRHluYW1pY0RlZmF1bHRdCiAgIGdVZWZpT3ZtZlBrZ1Rva2VuU3BhY2VHdWlkLlBjZFBjaU1t aW82NEJhc2V8MHgwDQogICBnVWVmaU92bWZQa2dUb2tlblNwYWNlR3VpZC5QY2RQY2lNbWlvNjRT aXplfDB4ODAwMDAwMDAwDQogDQorICBnRWZpTWRlUGtnVG9rZW5TcGFjZUd1aWQuUGNkRlNCQ2xv Y2t8MTAwMDAwMDAwDQogICBnRWZpTWRlUGtnVG9rZW5TcGFjZUd1aWQuUGNkUGxhdGZvcm1Cb290 VGltZU91dHwwDQogDQogICAjIFNldCB2aWRlbyByZXNvbHV0aW9uIGZvciB0ZXh0IHNldHVwLg0K ZGlmZiAtLWdpdCBhL092bWZQa2cvWGVuUGxhdGZvcm1QZWkvWGVuUGxhdGZvcm1QZWkuaW5mIGIv T3ZtZlBrZy9YZW5QbGF0Zm9ybVBlaS9YZW5QbGF0Zm9ybVBlaS5pbmYKaW5kZXggNTczMmQyMTg4 ODcxLi44N2RkNGIyNDY3OWEgMTAwNjQ0Ci0tLSBhL092bWZQa2cvWGVuUGxhdGZvcm1QZWkvWGVu UGxhdGZvcm1QZWkuaW5mCisrKyBiL092bWZQa2cvWGVuUGxhdGZvcm1QZWkvWGVuUGxhdGZvcm1Q ZWkuaW5mCkBAIC04NSw2ICs4NSw3IEBAIFtQY2RdCiAgIGdFZmlNZGVNb2R1bGVQa2dUb2tlblNw YWNlR3VpZC5QY2REeGVJcGxTd2l0Y2hUb0xvbmdNb2RlDQogICBnRWZpTWRlTW9kdWxlUGtnVG9r ZW5TcGFjZUd1aWQuUGNkVXNlMUdQYWdlVGFibGUNCiAgIGdFZmlNZGVNb2R1bGVQa2dUb2tlblNw YWNlR3VpZC5QY2RQdGVNZW1vcnlFbmNyeXB0aW9uQWRkcmVzc09yTWFzaw0KKyAgZ0VmaU1kZVBr Z1Rva2VuU3BhY2VHdWlkLlBjZEZTQkNsb2NrDQogICBnRWZpU2VjdXJpdHlQa2dUb2tlblNwYWNl R3VpZC5QY2RPcHRpb25Sb21JbWFnZVZlcmlmaWNhdGlvblBvbGljeQ0KICAgZ1VlZmlDcHVQa2dU b2tlblNwYWNlR3VpZC5QY2RDcHVMb2NhbEFwaWNCYXNlQWRkcmVzcw0KIA0KZGlmZiAtLWdpdCBh L092bWZQa2cvWGVuUGxhdGZvcm1QZWkvWGVuLmMgYi9Pdm1mUGtnL1hlblBsYXRmb3JtUGVpL1hl bi5jCmluZGV4IDc1MjRhYWExMWEyOS4uYTI5YjRlMDQwODZlIDEwMDY0NAotLS0gYS9Pdm1mUGtn L1hlblBsYXRmb3JtUGVpL1hlbi5jCisrKyBiL092bWZQa2cvWGVuUGxhdGZvcm1QZWkvWGVuLmMK QEAgLTYzMiw1ICs2MzIsOSBAQCBDYWxpYnJhdGVMYXBpY1RpbWVyICgKICAgRnJlcSA9IERpdlU2 NHg2NFJlbWFpbmRlciAoRGl2aWRlbmQsIFRzY1RpY2syIC0gVHNjVGljaywgTlVMTCk7DQogICBE RUJVRyAoKERFQlVHX0lORk8sICJBUElDIEZyZXEgJSA4bHUgSHpcbiIsIEZyZXEpKTsNCiANCisg IEFTU0VSVCAoRnJlcSA8PSBNQVhfVUlOVDMyKTsNCisgIFN0YXR1cyA9IFBjZFNldDMyUyAoUGNk RlNCQ2xvY2ssIEZyZXEpOw0KKyAgQVNTRVJUX1JFVFVSTl9FUlJPUiAoU3RhdHVzKTsNCisNCiAg IFVubWFwWGVuUGFnZSAoU2hhcmVkSW5mbyk7DQogfQ0KLS0gCkFudGhvbnkgUEVSQVJECgo= From xen-devel-bounces@lists.xenproject.org Thu Mar 25 15:48:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 15:48:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101439.194103 (Exim 4.92) (envelope-from ) id 1lPSD8-00088v-7J; Thu, 25 Mar 2021 15:47:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101439.194103; Thu, 25 Mar 2021 15:47:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSD8-00088l-2p; Thu, 25 Mar 2021 15:47:50 +0000 Received: by outflank-mailman (input) for mailman id 101439; Thu, 25 Mar 2021 15:47:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSD6-0007aB-Fj for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 15:47:48 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a6b6b779-42ee-43d8-b147-97f408e94207; Thu, 25 Mar 2021 15:47:36 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5AAFAAA55; Thu, 25 Mar 2021 15:47:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6b6b779-42ee-43d8-b147-97f408e94207 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616687255; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jfrDyWtRkvt7SP9dXjXX5Oxi8t/Y+WDKK79HHfKzu14=; b=uD7jPqTjOd2ce4VsMXSOqUSdoPINa9f0OlGaaJYvxgNm3mN9g/2TNFAiac8nNb33iinjRj O9KZtwV1Ry5zmz4+7jsSDDI381h+aZSjGZI+J+a5+saIcCM6GCHHHsh53fizkqdOIefV6y zXe/t8pJ18vtkGUgTvJXmYjQaCbR/x4= Subject: Re: [PATCH] xen: Drop "-rc" suffix from XEN_EXTRAVERSION To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Xen-devel References: <20210325150702.7582-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: Date: Thu, 25 Mar 2021 16:47:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210325150702.7582-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 25.03.2021 16:07, Andrew Cooper wrote: > Fixes: a04509d34d ("Branching: Update version files etc. for newly unstable") > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Thu Mar 25 16:21:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 16:21:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101461.194117 (Exim 4.92) (envelope-from ) id 1lPSiz-0004kX-SO; Thu, 25 Mar 2021 16:20:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101461.194117; Thu, 25 Mar 2021 16:20:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSiz-0004kQ-PP; Thu, 25 Mar 2021 16:20:45 +0000 Received: by outflank-mailman (input) for mailman id 101461; Thu, 25 Mar 2021 16:20:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPSiz-0004kL-4F for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 16:20:45 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 54d18269-edb5-4d6f-ba11-82c744430e67; Thu, 25 Mar 2021 16:20:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54d18269-edb5-4d6f-ba11-82c744430e67 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616689243; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=SRio+ouD/J/8qqd4JCo6USuG039b/y2Jr8XVxQfiXd4=; b=PGDP9liHpGRO90sTD3AkzxCfcKSckpuS3kVhDIdY0hpPt3rHtSP3EwLT RATNe5ea4dzQnfzUqdZXWWvyyfdsbUsJKDGfbVsS8JtCtJutRC+02RNIv sYHiT8FB+SUpcyYGMxD1PcNCZ+FxAuQDRkgJGPoW4AaR4BMR003zro/Uz k=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: +EndgC990oaN6A/g5OLIgePKlC3cq0Ej8hvIhB2QawnJU4eTAd2MCp1dGwm/EXuAXreXSOFQdg 8oDFWwJfD8HcBfvszliNB/s3W2SuX9EgBTRH6Tc9q5Z/8cH7TwyOzv5WYhsDgrgRiNY/6vyj3p dxh7pzX82uIODoR7ywE8j5+5Cagk4RDlLXLOgmSDi3yTyizLILSVMGWAD9ujhOWDEcAllQ2pZ3 ZmU+SEkF9JQ+1nRC7I3ZBfS+dK+AUDxyowdX+PpR8FxHfhKrBCvMCyRN8sxH/2Qs9dd60ygD8N 8+M= X-SBRS: 5.2 X-MesageID: 40021481 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:mWQexqpEr4gcFofSLTW+Hp4aV5v5L9V00zAX/kB9WHVpW+SFis Gjm+ka3xfoiDAXHEotg8yEJbPoex7h3LR+iLNwAZ6JWg76tGy0aLxz9IeK+UyFJwTS1M54kZ 1hfa93FcHqATFB5/rSzQGkH78br+Wv37uvgY7loUtFaSFPR+Ve4xxiCgCde3cGITVuIZYiDp KT6o5milObCBcqR/+2DHUEQOTPzuej/P7bSCULGgI97022hS6ogYSQLzGjwhwcXzlTqI1Sk1 TtrgqR3MSemsD+8DDw/Sv575NamNzuo+EzefCku4wuBRjHziqtbIRlcbWesD4yu/HH0idXrP D85y0OEu42x3TNfnykgRaF4Xie7B8er0XM5HXdoXz/rdf3TDg3YvAx+75xQ1/ixGcL+PRfuZ g7uF6xht5sIj7r2BnZ3ZzuUSpnk0KlyEBS6tI7vjhkfqY1LINKoZd3xjIyLL4wWBjUxaoAC+ dUAMTV9J9tACmnRkGchGVpzdC2N05DZyuucwwHssyR5TBcgGp0+Use3NAehXcN7vsGOuF529 g= X-IronPort-AV: E=Sophos;i="5.81,277,1610427600"; d="scan'208";a="40021481" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PIkeLsnwx/l44vB8fVfYSVsAh5NVUjdWNHRdymFdCgVQEPJuTZXsToom9LMmgZcetYrFxwBwGyaImCaHW4J05lPOldp5fg2Lm8azaQNLoMhplu7hc6KqFXQ4PoNW72zugppzUR/QC8he/dWr6RWHCvYy7Dqh8IPxNIyMzZN+/GigA08ZzseGvci3v0OmHP5u/HU4amuQH1CvlgCjjWoHE0KILYS4I+goDQF986Ll3l+DpOj0ns9iaNE7hK7gMHI9ZUNCUf+o3hVNfe65E1+Ropn29BAegZLEXSmAsbmu6fjWY4cAdS0FJeFXPL6HcHgImS2B97yloR9I232vEDprTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=03hxk7nGfa7YTzHZH1OqOJstaFaWx7HjGHCjOy8o4vg=; b=P3tjFr6XaUrHdGGp8BAMblI21y0ohBM/RrlYEymkHqHh21PeQPg2moDy/ebr9m3W5CbcmUcbrfMtIC1hH8G3kKwtZUVW3zfK4A9Lb20ret/N3OrwO2PMUL1QLvaqHjpxrjGmJX2kyJD90r0nq897CrAM+QfLjkNGgBt6kyyz69cYTmNskfZT9pc5PSB742fDFwpswgG/u/ssdtvunLGf1bzIoELfEb/JqpajV5fbcRuIYjml1EdIvdfKmMxColCtvlbZyOMPVmMcO8bVoZJI+QXjb9iBElYr+QRuBy/C3lRzjBWXj/avXZoxXB0dFL6BqybUDnMFVANv1Cof5SU/4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=03hxk7nGfa7YTzHZH1OqOJstaFaWx7HjGHCjOy8o4vg=; b=rwugx8XvcBRJKD7SZ830gYLxlB46z4SxUvAqq33xKldRH48QtXlh0UqZ0VhjcPCTpDqLWafv4wJBbJujWE9xH16x4B0QQFD3fachn0C3JaWFgaHYbyjdJKwdPtIiK4lA3tAbuk00unKpZJfZoMXH/9H/0UNOdztX6KYhd4rZIfY= From: Roger Pau Monne To: CC: Roger Pau Monne , Ian Jackson , Community Manager Subject: [PATCH for-4.15] changelog: note MSR access change Date: Thu, 25 Mar 2021 17:20:32 +0100 Message-ID: <20210325162032.81348-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0186.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::25) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9331bf25-2678-4611-4b19-08d8efa9ee93 X-MS-TrafficTypeDiagnostic: DM5PR03MB2489: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1468; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hPrJYDUZnzclq9s3LuzdtrcJbh09MKtaaqoyu5MbTlhgR52QO1aOPFw/FdWhiAWChM7MqRiVUpvG4qWTOyAq0lJd/my1npN7rNBdh2jw8hpXL0LYJYVvrlkCa1/s/gcHeTMZU504lQLoNVxzBiLyDQJBSCuyE7PkD+BdoRPmUiqhEnmpAYKyQkqJP9eGBf442y15JmrILsRw0SBo0xGqsNjWbQE03WA8bAmBFsikcBqhGywaBkHY9Dtluxt4RNZk13qpr03zF0alnV9edoKiID0NdoXJMCF6rXDSYGIfrH2NinHkjteeUDk8LbSe+8ZhbGlKuxhTr+/HRFBXnC1WHXJpt7vkgu9hIBtiDoNVQO1WzEc4No0HCV23phVJRG1k4UtxjSQLkkd0JehD4mQP2ldiBd6NbcBe/KAPGDZddEaxiLn1yThzMkDUvvHLf2JIP7YTGT01W3zsFvSjAOduvVfiv2AEmP73bOAAxzMoORvnoZe55kCplf4ad4xVaWO+XwWTwbmfKUhavtnC1ohxfIbAP4T0QkiWtn6CTvCwAYWT3hpt8gMGJ6m3pMF5CiezcxH+rbsggnBeHpshYFJdshE6BQfahOvD/ZXULLfhjRCwAqZ0Rkw4Wv7sxIqYIZIjKOxyVZhueadDy3ItThwNKZ62rFgo1XZUdujj9IhHNcdjrzUx9NqPLn0SY0pHiHcm1IHFJrsFmtH1Niwg4HFw1wOMB65Nnk+9DWiFapmMLzGXfBBha9kFdLbuvc0TdiovvETxOkh6hiLAHc3OM8yBy690tMARfCvR4GxGrlOPN00= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(956004)(6496006)(6666004)(6486002)(316002)(8676002)(4326008)(6916009)(8936002)(2616005)(1076003)(36756003)(478600001)(86362001)(186003)(4744005)(38100700001)(83380400001)(66476007)(66556008)(66946007)(26005)(5660300002)(2906002)(16526019)(54906003)(219803003)(207903002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YUUxRW15UllpY1pzSHNvU285R0RFY3I3WktPSjFmeVJwOWY3Z05qcW5zN2Nr?= =?utf-8?B?NU9uTjVCUXRXcG5PeWZPL3JwTE1JTFVNWk9EaGhYMG5vamhNbTFscjV5ZEwz?= =?utf-8?B?TWtDQzVUMEs1UFdWT0l4TjF6dk5uTjAzdGNMTW9yQWV0TVAvcU5tQWczcTRB?= =?utf-8?B?cy9oUFg0UGpXTW9xd3haNjZ2OHJ2S2FuazV4MHVRQ0dYRmNpV0ZRSnZsVEN0?= =?utf-8?B?N2c0NVVFWlExR3JxSFFHSHVMZm45K3VIVE9TTDZCQ3lzdnFOQnNlVkhzNFBI?= =?utf-8?B?cVlLNDYyQyt4RlZ0VHViRjBwTEJlRktna3JLWmVqbE9rMnBqVk95clE3djhC?= =?utf-8?B?NnFKUGFycEZyQ0VwWkF0QUovSUVEOUlXYXNSaDVuL3puVjJBNzZ3bmVQYlFm?= =?utf-8?B?Y3k4YnZ3eHN3OGJhaDJRUi93Q3k3dkhhQi9yK3B5V3FUWW9ZTWNTOVo0USsz?= =?utf-8?B?STNZdTN6SFdWb3dCelJ1eU9SNXU0SnNFNWJEdHlrUGlYY1BJUDQwQ29IZUJN?= =?utf-8?B?ZzNYZk9qcDkvMmQ4SjlvbUxYVWJ0RlQ1bG5wbWpQRXJ3d1NkN1dzQ0FONm1L?= =?utf-8?B?Q2VIcmtNM00va2prN04vZlFVVU92NENjdGora1A0WGFMejQ5dHZpVmh3eWdF?= =?utf-8?B?ZVplY2JvRUdWTzVodjhHTm55NEhXUUFWYSszbm1mRHowcHJGSlcwUXk5SVBv?= =?utf-8?B?TjJDRXVUZk9RdStPbVlhUE9SWi9iOGNweXFhU2lVODNwUlRRajAwbDZRL0Vj?= =?utf-8?B?SkhodFRTNDRZbVdTZUl3UEZ1dnBSdUpqRWtLYWN0alllRWNaOERjaTJmNnFZ?= =?utf-8?B?TEduVFJZOHVteDQraG84NmlMWlZDVjJHdWZ5WC9kZGlGbGRKT3V1NC9CQkJ5?= =?utf-8?B?SGVpa0Z3d2VUZWFuSnZMY1lQUmtqVGlKdVVWd3ZIVmJ2U0puMUVMN0h2Mksx?= =?utf-8?B?YjJ3dEQxUDhrZGh4TUg3ZStMOEx1a2ZTTEJuNkMxOHBzZHlVNXpyQU9RbDU4?= =?utf-8?B?bFRCb2JCT2JTNmVpcHp0NkQ5MEErenBqbWFqOVB3VDZXcXFOMmMvLzR1bjI3?= =?utf-8?B?dDUrS3dWTG10WEpKWjNkWVJSZlJlc0tFQTg0eWFmclhlVnhVSTFKZEFlMHl4?= =?utf-8?B?V3pHdFlhaUEvZWl5NVhBTlpsWGdobmJiKzgxME10VEJRN2MzKzNPVE1LWlk5?= =?utf-8?B?M2Y4QUN0RS8rRlN1YXhkd1htaXE2c211U1JvV21ZZ1dZanhFd1dRQ3NuRlNI?= =?utf-8?B?ejVOSklFSmJMSXc2emZ4M0tIZzAxdGlGdUk0VzJqSlhLSlAzY3BYeDdqY2JO?= =?utf-8?B?QlN5U1NiaU9GQVFrRnZPY3duYmNwaFRHV2hIVm4xK2xMenJYUE1EbWtsNVRm?= =?utf-8?B?eUVCWkcwTDZUbFltRzl2VnhJN3pxTzgxd2Fhd2xlbHIvbkozVzVuYkJvWmRi?= =?utf-8?B?dDFvZnRTNy9ieldPM01VempTN1lqNnB1N3IxVnJuMU5OdktVeHVDdzRHL3Zm?= =?utf-8?B?NlNSeFBjKzI2WUZ3NklKbEZpemh3K1FIKzMxUmVWTTVXcnUvb1BZQWZLUVNS?= =?utf-8?B?Tlk1aXJSYjZrOFZHWE9KWFpKOFlSVTZ2RHRSVjBPUnBoSHRqSTJrNTMrQ1Ft?= =?utf-8?B?bGZEUkl3dFR3NkltdURXOHpWbVdwUDA1TG9VQWxMa0c5VEVCV3hhOEY4Vmpv?= =?utf-8?B?TzJlM2t6dmppUmkrazJDWlYxMEc1bHZ1RG8ydVhyd0F1SXA2VTQ3ZWNPKzE5?= =?utf-8?Q?YFt5v7sx1LzUQereGnkv+j/AFLe+yjN03ZmI5Px?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9331bf25-2678-4611-4b19-08d8efa9ee93 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 16:20:40.5122 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SfTRAGLm7O5VTpTaXndFn5aIephoEWrePR08ltBgyRa6tklJqL4xM5MFffy8jUAgh10dP3tJkeuGz6RfvqyATQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2489 X-OriginatorOrg: citrix.com The change to deny all accesses to MSRs indexes not explicitly handled prevents leaking unwanted data into guests. Signed-off-by: Roger Pau Monné --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f76fadf8c73..d81608af4de 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - ARM IOREQ servers (device emulation etc.) (Tech Preview) - Renesas IPMMU-VMSA (Supported, not security supported; was Tech Preview) - ARM SMMUv3 (Tech Preview) + - Switched MSR accesses to deny by default policy. ## Removed / support downgraded -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Thu Mar 25 16:50:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 16:50:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101467.194133 (Exim 4.92) (envelope-from ) id 1lPTBG-0007IH-89; Thu, 25 Mar 2021 16:49:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101467.194133; Thu, 25 Mar 2021 16:49:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTBG-0007IA-4w; Thu, 25 Mar 2021 16:49:58 +0000 Received: by outflank-mailman (input) for mailman id 101467; Thu, 25 Mar 2021 16:49:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTBE-0007I3-Uw for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 16:49:57 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [170.10.133.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id ea3f6308-ddc0-4085-8610-082c57bf18dd; Thu, 25 Mar 2021 16:49:55 +0000 (UTC) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-114-fyl0xQUPOR66TmfKEtMqiw-1; Thu, 25 Mar 2021 12:49:53 -0400 Received: by mail-wr1-f69.google.com with SMTP id h30so2911178wrh.10 for ; Thu, 25 Mar 2021 09:49:52 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id r206sm1022782wma.46.2021.03.25.09.49.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Mar 2021 09:49:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea3f6308-ddc0-4085-8610-082c57bf18dd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616690995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=121DS0LIlLDGdmTKGTNnln43LPt7mALX/sqO8XpkWkI=; b=FrEGrn4HtlZ6fqGRcCX25oARoJ1mcm81lw1+eXbZrn8fIuSr2lP9NTfGj0gqN21SGfMhw5 PaAIuWTvIA7pJxUcjraz/qLuas4FhKFcJmGvjqo2PS0mXAg1KCrS5yklEJ/Kls5iM8KjYO ATAKX0Nco0JMSwZwgFweueBsJAwtS74= X-MC-Unique: fyl0xQUPOR66TmfKEtMqiw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=121DS0LIlLDGdmTKGTNnln43LPt7mALX/sqO8XpkWkI=; b=rn2P99zbh+eFMmKBPgT2qhE3MMH/pKD7ag9alNnxzaBkw4sH20/Nd1js8OIlq4yWak XVSwGCaXTrtJKtJaAEotqxlfS0fLOyTCIHLeVFG4GMRHp+4SR+R8eAIpDiKJfxM+8U2b lH8HpdhW09yIDEkj/TzlvjtxOFJirUGmPMc2XD9yXdZtQ5q/88prP6tK7aKfQrwGYsVN kC12KGfrWzJhMEmfu9IuF9SitqH2qvUsCN3D8Y8C5AlilSbL8krdc/ltIZ9TDnBBMs+g QZED7Roubl/fVTbqajuzYKqo54eSbRXGNG2Zh903D/+cJ55zKreBo9Go/yveQCsFskjw iVJA== X-Gm-Message-State: AOAM53142AkDpymHSC5BFVQ0WlcDDBMY1oysoe9A3m0e1PP2f3V054Ey gjFDwwrExJNHz7G3CE7NbIr9iOZKWNeSxlzvhYpUVIpvtgA9Md7O/w/J9ak0KYm5d2pjx00a5PO pPaVI9S8+HrYOMwba224SnUOviow= X-Received: by 2002:a1c:c1:: with SMTP id 184mr1069004wma.143.1616690991824; Thu, 25 Mar 2021 09:49:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPWFxtRUx2xUzR+f2PBAv/JqVK7YygaZ0ZccnI4WrsK0a6PduqDEoDgfxInGEPSSeviU9e3Q== X-Received: by 2002:a1c:c1:: with SMTP id 184mr1068978wma.143.1616690991577; Thu, 25 Mar 2021 09:49:51 -0700 (PDT) Subject: Re: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs To: Olaf Hering , John Snow Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , qemu-devel@nongnu.org, qemu-block@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20210317070046.17860-1-olaf@aepfle.de> <4441d32f-bd52-9408-cabc-146b59f0e4dc@redhat.com> <20210325121219.7b5daf76.olaf@aepfle.de> From: Paolo Bonzini Message-ID: Date: Thu, 25 Mar 2021 17:49:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210325121219.7b5daf76.olaf@aepfle.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 25/03/21 12:12, Olaf Hering wrote: > Am Mon, 22 Mar 2021 18:09:17 -0400 > schrieb John Snow : > >> My understanding is that XEN has some extra disks that it unplugs when >> it later figures out it doesn't need them. How exactly this works is >> something I've not looked into too closely. > > It has no extra disks, why would it? > > I assume each virtualization variant has some sort of unplug if it has to support guests that lack PV/virtio/enlightened/whatever drivers. No, it's Xen only and really should be legacy. Ideally one would just have devices supported at all levels from firmware to kernel. >> So if these IDE devices have been "unplugged" already, we avoid >> resetting them here. What about this reset causes the bug you describe >> in the commit message? >> >> Does this reset now happen earlier/later as compared to what it did >> prior to ee358e91 ? > > Prior this commit, piix_ide_reset was only called when the entire > emulated machine was reset. Like: never. With this commit, > piix_ide_reset will be called from pci_piix3_xen_ide_unplug. For some > reason it confuses the emulated USB hardware. Why it does confused > it, no idea. > I wonder what the purpose of the qdev_reset_all() call really is. It > is 10 years old. It might be stale. piix_ide_reset is only calling ide_bus_reset, and from there ide_reset and bmdma_reset. All of these functions do just two things: reset internal registers and ensure pending I/O is completed or canceled. The latter is indeed unnecessary; drain/flush/detach is already done before the call to qdev_reset_all. But the fact that it breaks USB is weird. That's the part that needs to be debugged, because changing IDE to unbreak USB needs an explanation even if it's the right thing to do. If you don't want to debug it, removing the qdev_reset_all call might do the job; you'll have to see what the Xen maintainers think of it. But if you don't debug the USB issue now, it will come back later almost surely. Paolo From xen-devel-bounces@lists.xenproject.org Thu Mar 25 16:52:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 16:52:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101470.194144 (Exim 4.92) (envelope-from ) id 1lPTDq-000876-Mk; Thu, 25 Mar 2021 16:52:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101470.194144; Thu, 25 Mar 2021 16:52:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTDq-00086z-JY; Thu, 25 Mar 2021 16:52:38 +0000 Received: by outflank-mailman (input) for mailman id 101470; Thu, 25 Mar 2021 16:52:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTDp-00086s-By for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 16:52:37 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0ce25a7f-0503-48d0-a256-ea3de2b1bb3e; Thu, 25 Mar 2021 16:52:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ce25a7f-0503-48d0-a256-ea3de2b1bb3e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616691154; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=VWa0Dr40EYe/oIlW+Ufg11dOPxLfxVFBM7uMznamABg=; b=X/jcsQnQBd0uOugTDuV6+BVu0TzMJJm1CVstTLzwNBemlIVTKarjND2C hX1PLrRp6xUjEgnIIHApSu4IqO3Y6ZJuuy71MDx7lVqLL8hL6IsWIX0B7 K33CtC4k4Jn20Lpslqe5zVhEwylq76Up/MHj0C+pcBr/CFf0Fqh3pl1+y 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: unb6hMK+djcLpiXwJuZqR8Izwf86YPmyAymTKklw08a4zvqpWQwB4Er3LvIXyu1Hg+h1BIhujW DIhBeH4jPnQVqmX6dNiC4hm126Lnnp6WdryJjecdwB0fZvwh/56aB3rBUBeAbWbjUY6uzGVjPQ 5dRrLlDKI6Gdplpy9woC7XgKuAvNdiiEW4VYQkIw8DwI3PMr2/7S6psB+11bd3mmOvql9HEmzB eh3yuWiBtXBavhqVevH3YXAjarDeTTpxQ3FQJ2KMV4hUxP+QTepKWFS9LIE4bbKy8v173LHKnd jAY= X-SBRS: 5.1 X-MesageID: 40150747 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:/mTlP6+kYNFILOofjL9uk+ECdb1zdoIgy1knxilNYDRIb82VkN 2vlvwH1RnyzA0cQm0khMroAsS9aFnb8oN45pRUAKe6UGDdyQ6VBaxBza+n+T3vHCXi6vVQvJ 0LT4FSAMD9ZGIUse/U+w+9euxP/PCi0ISFwdjT1G1sSwYCUdAD0y5cBhyAGkN7AClqbKBYKL Om6sBKpyWtdB0sB6zWOlA/U/XevNqOrZr6YHc9bCIP0hWEjj+j9dfBYnul9yoZOgkv/Z4StV Lrvia8zaWlvvG9xHbnphXuxqUTovTN4J9uAMSNj+IcNznjjB25Db4RJoGqjXQOj8yErHosjd nQszcsVv4Dl0/5TyWOjjbGnynmzTo05HfpxTaj8ATeiP28fh0WIY5lp+tiA3/kwntlhv5Q+u Z3+ljckJxtARbJjE3GlqD1fiAvrGWYiz4fi+IJ5kYvNrc2WftqgqE02lhaK5sEFDKS0vFdLM BeSPvR4/tbajqhHhbkl1gqxNStW0I6FQudTn4DvdSI0yNXkGoR9Tpg+PAi X-IronPort-AV: E=Sophos;i="5.81,278,1610427600"; d="scan'208";a="40150747" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Ian Jackson , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Pierret?= Subject: [PATCH for-4.15 0/2] x86/hpet: Try to unbreak Ryzen 1800X systems Date: Thu, 25 Mar 2021 16:52:22 +0000 Message-ID: <20210325165224.10306-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This is a refinement of Jan's "[PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally" to try and make Xen do the helpful thing on boot, rather than requiring a non-default command line option to boot in the first place. Andrew Cooper (1): x86/hpet: Factor hpet_enable_legacy_replacement_mode() out of hpet_setup() Jan Beulich (1): x86/hpet: Don't enable legacy replacement mode unconditionally docs/misc/xen-command-line.pandoc | 33 ++++++++ xen/arch/x86/hpet.c | 157 ++++++++++++++++++++++---------------- xen/arch/x86/io_apic.c | 26 +++++++ xen/include/asm-x86/hpet.h | 7 ++ 4 files changed, 157 insertions(+), 66 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Mar 25 16:52:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 16:52:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101471.194157 (Exim 4.92) (envelope-from ) id 1lPTDw-00089s-5Q; Thu, 25 Mar 2021 16:52:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101471.194157; Thu, 25 Mar 2021 16:52:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTDw-00089j-1P; Thu, 25 Mar 2021 16:52:44 +0000 Received: by outflank-mailman (input) for mailman id 101471; Thu, 25 Mar 2021 16:52:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTDu-00086s-8e for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 16:52:42 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e47308dd-7b06-4e4a-843d-dac0c04026ed; Thu, 25 Mar 2021 16:52:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e47308dd-7b06-4e4a-843d-dac0c04026ed DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616691155; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LF+lVlyKXExW6Io/IYUvBnZgXV3D7BVJSGsgMrjUOUs=; b=YHFLKxJKVx870MMzJ9EdWJauFtoOfUtV4BMe5sZa4y/O11Oz3qJ9ssat pLR0q8mOEuz6YcHvX8IVXIRc7l0RxitN2ztaKS4d8MwTgSQM+43/Llcwi yT8+n1jvMmE8liPTBGAWl5lKNGogLRgleDhOtkbFAQ+qzD9AqTBECa20D Y=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: bmaiUR7yfJ8R/GUMREX9NrRJ3FNleS1FK8wrw7uP7vcOwjdf38dLKs2dKsdtryATOcOR42Dtxd egzIL1EYDR/v3bbaxkTW2FT7oW5ZdN4H36o6JrRLlRCqCM8g/ldjIgk1nqpMG7fF8AFgKPnyTP tAf9vYOjlD7wdi7nfOAXbsiPxXX4uubMpbAvJXCkqlBd9381O2OA7ibyd/sPSL81D9WQ/6FzuE pKlin/tTdVp06HLPidV8DDD2LZTewcPtrvmc8c6MLxDhoNFJbvH3HHYUn1Buenqx0eBsLGcd7o Zkw= X-SBRS: 5.1 X-MesageID: 40150746 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:1/9vfaGHtPdr4ZzmpLqFMpHXdLJzesId70hD6mlYVQFVfsuEl8 qngfQc0lvOhCwMXWw78OrsBICrR3TA+ZlppbQAJLvKZniChEKEDqFHqbHjzTrpBjHk+odmv5 tIXqBiBLTLYmRSot395GCDfeoI5Pmi3OSWifzFz3FrJDsaCZ1IywtiEA6UHglXaWB9ZaYRL5 aX6spZqzfIQx1+AviTPXUZQ/PF4+TCiZOOW3U7LiQ64wqDhy7A0s+YLzGk2H4lMg9n8PMZ3k Xu1yf44aiitP/T8G6n60bjq654tfGk5t9KBMmngtUYJDP2mm+TFflccozHhh8ZiqWC70srjc ntrn4bTrhOwkKURE6Zi1/M3BTtyzkn4XOK8y7mvVLT5fbXaRh/Lugpv/M8TjLpr3AOkfs57Y dwm0WejJZTBQOoplWE2/H4EytEu2DxnWAvioco/htieLpbUpB9h6oF8nhYFZ8RdRiKk7wPIa 1VAMbQ6O0+SyL9U1np+m1mwNmbVn8uBBuxQk8bpsyP0zRN9UoJtncl+A== X-IronPort-AV: E=Sophos;i="5.81,278,1610427600"; d="scan'208";a="40150746" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Ian Jackson , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Pierret?= Subject: [PATCH 1/2] x86/hpet: Factor hpet_enable_legacy_replacement_mode() out of hpet_setup() Date: Thu, 25 Mar 2021 16:52:23 +0000 Message-ID: <20210325165224.10306-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210325165224.10306-1-andrew.cooper3@citrix.com> References: <20210325165224.10306-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit ... in preparation to introduce a second caller. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Ian Jackson CC: Marek Marczykowski-Górecki CC: Frédéric Pierret For 4.15. Pre-req for trying to unbreak AMD Ryzen 1800X systems. --- xen/arch/x86/hpet.c | 116 ++++++++++++++++++++++++--------------------- xen/include/asm-x86/hpet.h | 6 +++ 2 files changed, 68 insertions(+), 54 deletions(-) diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c index 1ff005fb4a..c73135bb15 100644 --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -754,11 +754,70 @@ int hpet_legacy_irq_tick(void) } static u32 *hpet_boot_cfg; +static u64 __initdata hpet_rate; + +bool __init hpet_enable_legacy_replacement_mode(void) +{ + unsigned int id, cfg, c0_cfg, ticks, count; + + if ( !hpet_rate || + !((id = hpet_read32(HPET_ID)) & HPET_ID_LEGSUP) || + (cfg = hpet_read32(HPET_CFG) & HPET_CFG_LEGACY) ) + return false; + + /* Stop the main counter. */ + hpet_write32(cfg & ~HPET_CFG_ENABLE, HPET_CFG); + + /* Reconfigure channel 0 to be 32bit periodic. */ + c0_cfg = hpet_read32(HPET_Tn_CFG(0)); + c0_cfg |= (HPET_TN_ENABLE | HPET_TN_PERIODIC | HPET_TN_SETVAL | + HPET_TN_32BIT); + hpet_write32(c0_cfg, HPET_Tn_CFG(0)); + + /* + * The exact period doesn't have to match a legacy PIT. All we need + * is an interrupt queued up via the IO-APIC to check routing. + * + * Use HZ as the frequency. + */ + ticks = ((SECONDS(1) / HZ) * div_sc(hpet_rate, SECONDS(1), 32)) >> 32; + + count = hpet_read32(HPET_COUNTER); + + /* + * HPET_TN_SETVAL above is atrociously documented in the spec. + * + * Periodic HPET channels have a main comparator register, and + * separate "accumulator" register. Despite being named accumulator + * in the spec, this is not an accurate description of its behaviour + * or purpose. + * + * Each time an interrupt is generated, the "accumulator" register is + * re-added to the comparator set up the new period. + * + * Normally, writes to the CMP register update both registers. + * However, under these semantics, it is impossible to set up a + * periodic timer correctly without the main HPET counter being at 0. + * + * Instead, HPET_TN_SETVAL is a self-clearing control bit which we can + * use for periodic timers to mean that the second write to CMP + * updates the accumulator only, and not the absolute comparator + * value. + * + * This lets us set a period when the main counter isn't at 0. + */ + hpet_write32(count + ticks, HPET_Tn_CMP(0)); + hpet_write32(ticks, HPET_Tn_CMP(0)); + + /* Restart the main counter, and legacy mode. */ + hpet_write32(cfg | HPET_CFG_ENABLE | HPET_CFG_LEGACY, HPET_CFG); + + return true; +} u64 __init hpet_setup(void) { - static u64 __initdata hpet_rate; - unsigned int hpet_id, hpet_period, hpet_cfg; + unsigned int hpet_id, hpet_period; unsigned int last, rem; if ( hpet_rate ) @@ -805,58 +864,7 @@ u64 __init hpet_setup(void) * Reconfigure the HPET into legacy mode to re-establish the timer * interrupt. */ - if ( hpet_id & HPET_ID_LEGSUP && - !((hpet_cfg = hpet_read32(HPET_CFG)) & HPET_CFG_LEGACY) ) - { - unsigned int c0_cfg, ticks, count; - - /* Stop the main counter. */ - hpet_write32(hpet_cfg & ~HPET_CFG_ENABLE, HPET_CFG); - - /* Reconfigure channel 0 to be 32bit periodic. */ - c0_cfg = hpet_read32(HPET_Tn_CFG(0)); - c0_cfg |= (HPET_TN_ENABLE | HPET_TN_PERIODIC | HPET_TN_SETVAL | - HPET_TN_32BIT); - hpet_write32(c0_cfg, HPET_Tn_CFG(0)); - - /* - * The exact period doesn't have to match a legacy PIT. All we need - * is an interrupt queued up via the IO-APIC to check routing. - * - * Use HZ as the frequency. - */ - ticks = ((SECONDS(1) / HZ) * div_sc(hpet_rate, SECONDS(1), 32)) >> 32; - - count = hpet_read32(HPET_COUNTER); - - /* - * HPET_TN_SETVAL above is atrociously documented in the spec. - * - * Periodic HPET channels have a main comparator register, and - * separate "accumulator" register. Despite being named accumulator - * in the spec, this is not an accurate description of its behaviour - * or purpose. - * - * Each time an interrupt is generated, the "accumulator" register is - * re-added to the comparator set up the new period. - * - * Normally, writes to the CMP register update both registers. - * However, under these semantics, it is impossible to set up a - * periodic timer correctly without the main HPET counter being at 0. - * - * Instead, HPET_TN_SETVAL is a self-clearing control bit which we can - * use for periodic timers to mean that the second write to CMP - * updates the accumulator only, and not the absolute comparator - * value. - * - * This lets us set a period when the main counter isn't at 0. - */ - hpet_write32(count + ticks, HPET_Tn_CMP(0)); - hpet_write32(ticks, HPET_Tn_CMP(0)); - - /* Restart the main counter, and legacy mode. */ - hpet_write32(hpet_cfg | HPET_CFG_ENABLE | HPET_CFG_LEGACY, HPET_CFG); - } + hpet_enable_legacy_replacement_mode(); return hpet_rate; } diff --git a/xen/include/asm-x86/hpet.h b/xen/include/asm-x86/hpet.h index fb6bf05065..50176de3d2 100644 --- a/xen/include/asm-x86/hpet.h +++ b/xen/include/asm-x86/hpet.h @@ -73,6 +73,12 @@ void hpet_disable(void); int hpet_legacy_irq_tick(void); /* + * Try to enable HPET Legacy Replacement mode. Returns a boolean indicating + * whether the HPET configuration was changed. + */ +bool hpet_enable_legacy_replacement_mode(void); + +/* * Temporarily use an HPET event counter for timer interrupt handling, * rather than using the LAPIC timer. Used for Cx state entry. */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Mar 25 16:52:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 16:52:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101472.194163 (Exim 4.92) (envelope-from ) id 1lPTDw-0008Aa-Hr; Thu, 25 Mar 2021 16:52:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101472.194163; Thu, 25 Mar 2021 16:52:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTDw-0008AG-AO; Thu, 25 Mar 2021 16:52:44 +0000 Received: by outflank-mailman (input) for mailman id 101472; Thu, 25 Mar 2021 16:52:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTDu-00089F-MZ for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 16:52:42 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c614e899-3e75-4f93-9eda-704564dac97a; Thu, 25 Mar 2021 16:52:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c614e899-3e75-4f93-9eda-704564dac97a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616691161; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UmOB2jpI/LNrB0BQxya0yK8puikk3iTXwPa1pCoadQg=; b=MtzR9I0JgDMdaQNLPvFAoJiOpc/i+Ka+uS+vI9nSq9MlDfXgWbBib68Y 3IMTWRwfW5vQzD9Oq7Ss3K/BdE8vNKFQwRmxhi0qjOIhBJR/ZcrwLzG1p IOH6pm0FasRgLtXiRYESs88tUUTDBxCEBKp9j83Zg71hNwaAzgcOtLoLD o=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: ZF5JUZj0PBnumeYqkxjXpDB5Z2DdwGuyRJDmERprCcJ4u4Ga1RzxYMvyBth5h0f0+GNast+IvF JXKM0sch9PNPhAFhVwVXcD/kH+pgBJ35h4pFyqqXgt9anXVbodmJHDl9g3RWEsPVwxf8rRKYoy 49suzN2HEGxPsq8A4P2LjHLJi/DfkM1Dzwrw8XTudMDuWE5oErW2Jgbnb1/A+8jkrGzdLjRZ/X 4q5DVrAogqBjRkmVtkyoqLYqRAumKEb/xVIwxL78doOQiV5wTHN8OymPWXmnebnkhhUURm/ILb 55c= X-SBRS: 5.1 X-MesageID: 40024416 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Iy04eK0FOg1DhiKEDkc51QqjBWByeYIsi2QD101hICF9WtCEls yogfQQ3QL1jjFUY307hdWcIsC7LE/035Qd2+ksFJ2lWxTrv3btEZF64eLZslndMgDd1soY76 dvdKBiFMb9ZGIRse/W6BS1euxO/PCp66at7N2x815IbSVHL55t9B14DAHzKDwSeCBjCYAiHJ SRouprzgDQGkg/VciwCnkbU+WrnbSi+K7OWhIaGwUhrDCHkDLA0tXHOiKF1RQTWS4n+8ZBzU H5lWXCh5mLgrWA5TL3k0TS6JlXn9WJ8Ko/OOW8zvI7Bx+ppgKhZIFKU6CPsjYvsIiUmSoXue iJmTgMFYBe7G7QY3GUrHLWqnbd+Qdr0VDO4xu5hmbuusPwTj5SMbs+uatpNiH3xmBlmfMU6t Mt40up86B5IDmFoQHGo//PbB1unlrcmwtYrccjy0ZxfKFbVKVctuUkjSVoOaZFJg3WwqY9Ht JjCcnNjcwmC2+yXjTism5jzMfEZAVLIj62BkwLusmi2zNLhnxOz0wB2MwFnnsbnahNM6V52w == X-IronPort-AV: E=Sophos;i="5.81,278,1610427600"; d="scan'208";a="40024416" From: Andrew Cooper To: Xen-devel CC: Jan Beulich , Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Ian Jackson , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Pierret?= Subject: [PATCH 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally Date: Thu, 25 Mar 2021 16:52:24 +0000 Message-ID: <20210325165224.10306-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210325165224.10306-1-andrew.cooper3@citrix.com> References: <20210325165224.10306-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Jan Beulich Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating") was reported to cause boot failures on certain AMD Ryzen systems. Refine the fix to do nothing in the default case, and only attempt to configure legacy replacement mode if IRQ0 is found to not be working. In addition, introduce a "hpet" command line option so this heuristic can be overridden. Since it makes little sense to introduce just "hpet=legacy-replacement", also allow for a boolean argument as well as "broadcast" to replace the separate "hpetbroadcast" option. Signed-off-by: Jan Beulich Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Ian Jackson CC: Marek Marczykowski-Górecki CC: Frédéric Pierret For 4.15: Attempt to unbreak AMD Ryzen 1800X systems. --- docs/misc/xen-command-line.pandoc | 33 ++++++++++++++++++++++++++++++ xen/arch/x86/hpet.c | 43 +++++++++++++++++++++++++++------------ xen/arch/x86/io_apic.c | 26 +++++++++++++++++++++++ xen/include/asm-x86/hpet.h | 1 + 4 files changed, 90 insertions(+), 13 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index a0601ff838..4d020d4ad7 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1274,9 +1274,42 @@ supported. See docs/misc/arm/big.LITTLE.txt for more information. When the hmp-unsafe option is disabled (default), CPUs that are not identical to the boot CPU will be parked and not used by Xen. +### hpet (x86) + = List of [ | broadcast= | legacy-replacement= ] + + Applicability: x86 + +Controls Xen's use of the system's High Precision Event Timer. By default, +Xen will use an HPET when available and not subject to errata. Use of the +HPET can be disabled by specifying `hpet=0`. + + * The `broadcast` boolean is disabled by default, but forces Xen to keep + using the broadcast for CPUs in deep C-states even when an RTC interrupt is + enabled. This then also affects raising of the RTC interrupt. + + * The `legacy-replacement` boolean allows for control over whether Legacy + Replacement mode is enabled. + + Legacy Replacement mode is intended for hardware which does not have an + 8025 PIT, and allows the HPET to be configured into a compatible mode. + Intel chipsets from Skylake/ApolloLake onwards can turn the PIT off for + power saving reasons, and there is no platform-agnostic mechanism for + discovering this. + + By default, Xen will not change hardware configuration, unless the PIT + appears to be absent, at which point Xen will try to enable Legacy + Replacement mode before falling back to pre-IO-APIC interrupt routing + options. + + This behaviour can be inhibited by specifying `legacy-replacement=0`. + Alternatively, this mode can be enabled unconditionally (if available) by + specifying `legacy-replacement=1`. + ### hpetbroadcast (x86) > `= ` +Deprecated alternative of `hpet=broadcast`. + ### hvm_debug (x86) > `= ` diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c index c73135bb15..270fef38c3 100644 --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -52,6 +52,8 @@ static unsigned int __read_mostly num_hpets_used; DEFINE_PER_CPU(struct hpet_event_channel *, cpu_bc_channel); unsigned long __initdata hpet_address; +int8_t __initdata opt_hpet_legacy_replacement = -1; +static bool __initdata opt_hpet = true; u8 __initdata hpet_blockid; u8 __initdata hpet_flags; @@ -63,6 +65,32 @@ u8 __initdata hpet_flags; static bool __initdata force_hpet_broadcast; boolean_param("hpetbroadcast", force_hpet_broadcast); +static int __init parse_hpet_param(const char *s) +{ + const char *ss; + int val, rc = 0; + + do { + ss = strchr(s, ','); + if ( !ss ) + ss = strchr(s, '\0'); + + if ( (val = parse_bool(s, ss)) >= 0 ) + opt_hpet = val; + else if ( (val = parse_boolean("broadcast", s, ss)) >= 0 ) + force_hpet_broadcast = val; + else if ( (val = parse_boolean("legacy-replacement", s, ss)) >= 0 ) + opt_hpet_legacy_replacement = val; + else + rc = -EINVAL; + + s = ss + 1; + } while ( *ss ); + + return rc; +} +custom_param("hpet", parse_hpet_param); + /* * Calculate a multiplication factor for scaled math, which is used to convert * nanoseconds based values to clock ticks: @@ -852,19 +880,8 @@ u64 __init hpet_setup(void) if ( (rem * 2) > hpet_period ) hpet_rate++; - /* - * Intel chipsets from Skylake/ApolloLake onwards can statically clock - * gate the 8259 PIT. This option is enabled by default in slightly later - * systems, as turning the PIT off is a prerequisite to entering the C11 - * power saving state. - * - * Xen currently depends on the legacy timer interrupt being active while - * IRQ routing is configured. - * - * Reconfigure the HPET into legacy mode to re-establish the timer - * interrupt. - */ - hpet_enable_legacy_replacement_mode(); + if ( opt_hpet_legacy_replacement > 0 ) + hpet_enable_legacy_replacement_mode(); return hpet_rate; } diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index e93265f379..f08c60d71f 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -29,6 +29,8 @@ #include #include #include + +#include #include #include #include @@ -1922,14 +1924,38 @@ static void __init check_timer(void) vector, apic1, pin1, apic2, pin2); if (pin1 != -1) { + bool hpet_changed = false; + /* * Ok, does IRQ0 through the IOAPIC work? */ unmask_IO_APIC_irq(irq_to_desc(0)); + retry_ioapic_pin: if (timer_irq_works()) { local_irq_restore(flags); return; } + + /* + * Intel chipsets from Skylake/ApolloLake onwards can statically clock + * gate the 8259 PIT. This option is enabled by default in slightly + * later systems, as turning the PIT off is a prerequisite to entering + * the C11 power saving state. + * + * Xen currently depends on the legacy timer interrupt being active + * while IRQ routing is configured. + * + * If the user hasn't made an explicit option, attempt to reconfigure + * the HPET into legacy mode to re-establish the timer interrupt. + */ + if ( opt_hpet_legacy_replacement < 0 && + !hpet_changed && hpet_enable_legacy_replacement_mode() ) + { + printk(XENLOG_ERR "..no 8254 timer found - trying HPET Legacy Replacement Mode\n"); + hpet_changed = true; + goto retry_ioapic_pin; + } + clear_IO_APIC_pin(apic1, pin1); printk(KERN_ERR "..MP-BIOS bug: 8254 timer not connected to " "IO-APIC\n"); diff --git a/xen/include/asm-x86/hpet.h b/xen/include/asm-x86/hpet.h index 50176de3d2..07bc8d6079 100644 --- a/xen/include/asm-x86/hpet.h +++ b/xen/include/asm-x86/hpet.h @@ -53,6 +53,7 @@ extern unsigned long hpet_address; extern u8 hpet_blockid; extern u8 hpet_flags; +extern int8_t opt_hpet_legacy_replacement; /* * Detect and initialise HPET hardware: return counter update frequency. -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Mar 25 16:55:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 16:55:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101482.194181 (Exim 4.92) (envelope-from ) id 1lPTGr-0008V5-1G; Thu, 25 Mar 2021 16:55:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101482.194181; Thu, 25 Mar 2021 16:55:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTGq-0008Uy-Tt; Thu, 25 Mar 2021 16:55:44 +0000 Received: by outflank-mailman (input) for mailman id 101482; Thu, 25 Mar 2021 16:55:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTGp-0008Ut-EH for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 16:55:43 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 80bb549c-78dc-4c5b-b077-53f83f90fcfb; Thu, 25 Mar 2021 16:55:42 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 85915619F3; Thu, 25 Mar 2021 16:55:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80bb549c-78dc-4c5b-b077-53f83f90fcfb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616691342; bh=gwgutn6RV26VRaTvT5mn5WIaiIxKt72qh3ujkcd4ClY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=FU/5oUV0VuFXG4cg2MexEOBRY8MWGow04hyiSa75CykI0YGzvcadrs7sxREqR3KgM /TSs495U9c8yK8V1e3PO/6ThGveRklu0ArwtmtJNIpHDGpwOd4bWRINWCkpqb/zRGJ PMC8McKZD2rPSEf73X6+LtDNm0GxFP/Xr/x9dpCNbQ7XqAXUk8d4XyUp8OTSAtMFUk 9J0zM6DcLszwJvC/Z2deKsvqBT0t8jsZRgByCwxg5swz6xIuKMvd3sKKzNLaSgmOvw BiOffSyXmmu37qeMuiMlkrKpStk738HDkPQBtuLVKADfcuBwaaBSHlJwNVNAFYOo84 hjkVbpyEahl2w== Date: Thu, 25 Mar 2021 09:55:40 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= cc: George Dunlap , Christopher Clark , "Daniel P. Smith" , xen-devel , Andrew Cooper , Stefano Stabellini , Julien Grall , Julien Grall , Ian Jackson , Wei Liu , Jan Beulich , Rich Persaud , Bertrand Marquis , "luca.fancellu@arm.com" , "paul@xen.org" , Adam Schwalm Subject: Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document In-Reply-To: Message-ID: References: <20210316031814.10311-1-dpsmith@apertussolutions.com> <20210316031814.10311-2-dpsmith@apertussolutions.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-486361768-1616690998=:439" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-486361768-1616690998=:439 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 25 Mar 2021, Roger Pau Monné wrote: > On Thu, Mar 25, 2021 at 10:14:31AM +0100, George Dunlap wrote: > > > > > > > On Mar 25, 2021, at 8:32 AM, Roger Pau Monne wrote: > > > > > > On Wed, Mar 24, 2021 at 05:53:26AM -0700, Christopher Clark wrote: > > >> On Wed, Mar 24, 2021 at 1:01 AM Roger Pau Monné wrote: > > >>> > > >>> On Tue, Mar 23, 2021 at 10:39:53AM -0700, Christopher Clark wrote: > > >>>> On Thu, Mar 18, 2021 at 9:43 AM Roger Pau Monné wrote: > > >>> If you offload domain creation of guests with > > >>> pci-passthrough devices to a control domain and/or hardware domain, > > >>> I'm not sure I see the difference from normal domain creation, ie: > > >>> it's no longer something specific to hyperlaunch, as I could achieve > > >>> the same by using the existing xendomains init script. > > >> > > >> So that's not what we've proposed, and hopefully not what we'll need to do. > > >> > > >> Do you know if there is a need to perform work to support the > > >> assignment of PCI devices at the point of domain creation (ie. in > > >> domain_create), rather than handling it in a later step of domain > > >> configuration, prior to the domain being started? > > > > > > So while I think you could indeed create a domain from the hypervisor > > > in a paused state and attach the pci devices later from a > > > control/hardware domain, I don't see much benefit in doing it. If you > > > need to end up waiting for a control/hardware domain to attach the > > > devices and unpause you might as well do the whole domain creation > > > from such control/hardware domain. > > > > My understanding was that one of the primary advantages of domB was > > that you could compile and run arbitrary code in whatever language > > you wanted to, using already known tools. If *all* we want to do is > > to assign some pre-defined specific BDFs to specific domains, then > > sure, we could add that capability to Xen. > > Well, it's not so easy because we require QEMU or pciback ATM on x86 > in order to do pci passthrough to guests, so assigning BDFs to > specific domains from the hypervisor would need to be done using vPCI > (which is not yet ready for unprivileged guest usage) and only support > HVM kind of guests strictly. > > Doing passthrough to PV guests directly from the hypervisor is > impossible AFAICT without putting pciback inside of the hypervisor. > > > But suppose you wanted > > to have the flexibility to handle changes in hardware at boot time? > > “Scan through the PCI bus and assign anything that looks like a > > network card to domNet, and anything that looks like a USB > > controller to domUSB” is something you could easily do in domB, but > > would be way too complicated to add to Xen. > > Right, but then you might as well create the domain from domB instead > of doing it in the hypervisor? > > I'm not arguing about not using domB, I just don't see the benefit of > creating a paused domain from the hypervisor that then requires the > intervention of a further domain (domB) in order to finish creation. > Won't it be simpler to just create the domain and attach the pci > devices from domB? I think that the ability of creating multiple VMs from Xen is actually a very good one to have for a few reasons. It would align x86 with ARM, it would be useful in cases where PCI passthrough is not involved, and it is a powerful tool to have in our toolbox. I see that handling PCI passthrough at domain creation time can be difficult, so I think Christopher's solution is a good compromise. FYI for dom0less/ARM we have been discussing doing device assignment at creation time, but the idea was to provide the PCI topology in device tree to Xen to help with discovery. --8323329-486361768-1616690998=:439-- From xen-devel-bounces@lists.xenproject.org Thu Mar 25 16:57:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 16:57:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101485.194192 (Exim 4.92) (envelope-from ) id 1lPTIJ-0000BP-Br; Thu, 25 Mar 2021 16:57:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101485.194192; Thu, 25 Mar 2021 16:57:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTIJ-0000BI-8W; Thu, 25 Mar 2021 16:57:15 +0000 Received: by outflank-mailman (input) for mailman id 101485; Thu, 25 Mar 2021 16:57:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTIH-0000Ar-TR; Thu, 25 Mar 2021 16:57:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTIH-00005d-N6; Thu, 25 Mar 2021 16:57:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTIH-0007Js-EY; Thu, 25 Mar 2021 16:57:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPTIH-0006Ux-E0; Thu, 25 Mar 2021 16:57:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Dxd02A8NhiYQppHVcJlka9GkPCdj8P5dKPozZCn/KHs=; b=XQ9Dy2265b0su+nbdPsPg8Hjns YhQ0Sexf9olTB4c/r7akNPphSWjL0+KS8glrhgVMYVPdrYpzCqGv+xz7cdIvOFuytWXR+UBP0EepE 1hHKbla5O8u3oWKbr+WHTnpmdffWRgt5qF3ngHHlYMhoybdzog62GvgSPhiD35KGU9Qw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160392: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=01874b15d36e3f9a3506c47941a92ccf8d8bed98 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Thu, 25 Mar 2021 16:57:13 +0000 flight 160392 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160392/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 01874b15d36e3f9a3506c47941a92ccf8d8bed98 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 217 days Failing since 152659 2020-08-21 14:07:39 Z 216 days 412 attempts Testing same since 160392 2021-03-24 14:30:10 Z 1 days 1 attempts ------------------------------------------------------------ 466 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 137552 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 25 17:01:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 17:01:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101495.194211 (Exim 4.92) (envelope-from ) id 1lPTM2-0001LB-4s; Thu, 25 Mar 2021 17:01:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101495.194211; Thu, 25 Mar 2021 17:01:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTM2-0001L4-1f; Thu, 25 Mar 2021 17:01:06 +0000 Received: by outflank-mailman (input) for mailman id 101495; Thu, 25 Mar 2021 17:01:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTM0-0001Kz-Ks for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 17:01:04 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7f147eaf-7df5-4199-a5c4-4d9d2014dff9; Thu, 25 Mar 2021 17:01:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f147eaf-7df5-4199-a5c4-4d9d2014dff9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616691663; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=of9uTjYXa2KnwTP7U3XcP7cO9GuPetoBzf4Bucsvx5E=; b=FoejQrJ/OwJUNhX0g1b5PKeIeahuVk4wwh+SPomOdQyIGB2nCQqrrsaV aYf7SN9Mvz9gKjKzb30iZBbn7wId4oyjzgSH3mS/XZJYF/lIrzDWg86fL yhBgBfXom+VkSkvnuP6f/efqSTjymbEVUcOT1uZs6vo8dN0g1BzO/72bK A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 4kLbUBEMymQvmuh5kHi2WnKYKlhl+UQQWhAXtj9X7Ee+InWBQXY9H+aAyl0z3mFhATbyb+UoPE yszODfQhcek7ThwxoftrRE2h076LJmrevhQu4MoSRTFsvJYhGwyI1kQDq8tFmjH72H6gKL77P3 oo9sXDuhTFZoFBGmn616S9MmwmNCnbyyUZiqupbLH4GJI5fUFaZBs8YYdanZel3ze5j7wqu7lu S6KU2ktq92DZASM9+6izs2BAYy3ided616F5x+1VBKX06/DYZTywzKZ8HnT7so+BoWF63CXRVV OBE= X-SBRS: 5.2 X-MesageID: 40508281 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:VmQcRarhom+7SFMXhcxCy+oaV5vYL9V00zAX/kB9WHVpW+SFis Gjm+ka3xfoiDAXHEotg8yEJbPoex7h3LR+iLNwAZ6JWg76tGy0aLxz9IeK+UyHJwTS1M54kZ 1hfa93FcHqATFB5/rSzQGkH78br+Wv37uvgY7loUtFbQYvUK146hc8NwDzKDwVeCBjJb4UUK WR/dBGoT3IQwVxUu2eCmMeV+bO4/3n/aiWAiIuPBIs5AmQgT7A0teTfySw5RsQXyhCxr0v6w H+4mnEz56uru2hzVvk33LThq48pPLa1tBBCMaQ4/JlTgnEtwDAXuVccozHhh8ZiqWF6FEmkN 7Dyi1QQPhb2jfqUUye5Tfo0wnk+j4y53Hl0k/wuwqcneXJAAgUJuAEqYVFcgbIy0dIhqAM7I t7m1i3mrASLRTckD/z79LFPisa5nackD4ZvsM4y1l8OLFuEYN5nMgk025+VKokJmbc7rsqFe F/Zfusmcp+QBehQF3y+lV0zMfEZAVKIj62BnIsl+ayyDZskHVw3yIjtbAit0ZFzp47RpVejt 60SZhApfVLRs8SW6p3GP0Md8uxEnDMWhLBKgupUC7aKJ0= X-IronPort-AV: E=Sophos;i="5.81,278,1610427600"; d="scan'208";a="40508281" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RgI5tVdC+N5xe70hD/0W3p4+19VJUM6PE5UXVHygNC2lUevSSEUeqRFNYxovYtxPdBNc4a0a9Dw0D49yFIfxzcPCxmETFt3UZJQu/Q1OOob9rw1Gym020G+hnEOgXfVxv+a9bMJ/3JlKJN4p2jzOfApUyoljOg+7bDz9u+uWUib3Pd4oUgTfcfdRL0cMoV8kM/csHFFagjjM77ic/kPvvcO25BOqXcXu5OwYqpKdvfSKG43Qo7g3gR31qAQkOJpnWmZBGRix//X6ig2hHKwWpXg/CZCOX4SlgEi5mbikYXZqPqrCoToVne0gB10PZHhtAN1bqMhwUDi08JJ/Gmd6ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ux+DkcVLmnAoFtLq5LB3V6huJv5fnM7DaMb63yfG/v0=; b=OEfpORitd/JeX21uodOQioOurV5vUdxzNHT4jLBs4v9Tbvd/WHUrm4bJE79KxprXeEjf2BDvFa2k84W2TDnQHL7nrWEwpPUk+ESGUh1PeNEjLOle9iAQzaIu4yod+Ces60PKhZOmEjANJPSSXbxXgiq6rBw4QXtErEb18aTPfTrrYkGWwceWQqfwIhfWTFBqrd7We+G73PmGtJZbe+zWOfhigfI9RiW5hZ3rLFBEBUS+QlJvlshtHH5KCd1JQS4AGvIEohLjjngakj6WU5+gEzBkX6+O0xNoed9RVjOn9ItbZHTA4kItzwKiyn/4//8WEVjx5skUakeaRa/h/ciwAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ux+DkcVLmnAoFtLq5LB3V6huJv5fnM7DaMb63yfG/v0=; b=GSMX3Ug1mQvNcrhARvlI2cU5S5RQuH7fKw5KROqLa2JS/3Ww7tWIl1zXhm3KbvOC2aD/gewmToU4S0BdgABNlagIXXUqBEMuUoTNMOeIZMOEZ3a3QX4xz2J4XcUTqZOISrf2BFfP98DgjtVJj0r38se7qTS4WvbZ959GfR5QGCA= Subject: Re: [PATCH 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally To: Xen-devel CC: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= References: <20210325165224.10306-1-andrew.cooper3@citrix.com> <20210325165224.10306-3-andrew.cooper3@citrix.com> From: Andrew Cooper Message-ID: <8e8d8fe6-afb1-eb2a-adad-912b857670fd@citrix.com> Date: Thu, 25 Mar 2021 17:00:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <20210325165224.10306-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0506.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::13) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 720e2e45-6c09-4323-f949-08d8efaf90fd X-MS-TrafficTypeDiagnostic: BN6PR03MB2515: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L6Og2lbgPlR0F8GOiIcMLRm7HI4cTyDEtYUvQs3EEEAk9fFvQvXFNaTZy2/pVxcEOr/rTWwm3XQfhOQgJhnJN477hTYXawokUvUnX/lw62uRjFPrAagoK2I8kASq46Gwq4oWDK4muq4c2fClDtYIJHEKeyqkWvHUljchZqtaV5NImnEXx4bnNF2+kRv2zm/+HAVITelgTAOsLKvvwiXLUz2EZey2C/pxClwngwVAn+2csBXrc1nIzsseLCII4KXuXEbGvlBTNM8IqF+xHL8lozL17Hsi5ILg+bUsWvsuPwRFj48nxeiMVmG42S29RXoMrnSdWEhuAP5/4fsbATq8K5XqC23AGL1/mg//N3600weQ2hTU0Q6o4Hw79tHvRccb52tolRbjTpPago/ybLl10vlVJl2KUH9cuEjNk6FDqG5UAGCuLift8bk3iHvX8B4Ltsyk5EUxt8jR2cVXKDFPX7uliaEhA5/yjHY9ecnVaB0EP9dpmAvEGNrQp4iGu9Hpm01p5xZ4HS0doxTt+DM0xK7rz/rp3qwOQCSCT7QLVQIRMo/x7OoiTQ5K+BXrkFeaoO6wOKCVtA/gMSSUhUUwwtzMz1GEp+mm7vXlDVom9pV8qtgwt7LliP6ZRcDV/9pIq504hE05JVX/7Fxim+4CqtfECmPSECERxSCycPoP8tdn2fVvi2GN8WwSXRBNCRriZifPxZWlPd8N73e8yGO14g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(136003)(376002)(346002)(366004)(66476007)(86362001)(66946007)(66556008)(2616005)(38100700001)(8676002)(8936002)(83380400001)(36756003)(31686004)(5660300002)(31696002)(956004)(4326008)(53546011)(6916009)(26005)(16576012)(478600001)(2906002)(316002)(16526019)(6486002)(54906003)(186003)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?T2p1NmUrTnpGOHAyMGVOcHhudVpVeDJzek9VRjJoZmFrcDVSaVRMQmcyYVJm?= =?utf-8?B?QXVEYlB3K2FJYnI1T3p0RkQ3UlVsbThhaXp4MkE1NzVET2FnZVJBTm55S1pM?= =?utf-8?B?bmVNODVQR0owTzFtc3RLTFlsYmNzc0tncHBPMTY0RzMyUlVtNXF5YTh1bFBW?= =?utf-8?B?NHgwZGhSV0R1c1RBZE9uZUhkYkRSZkc4aUtGaUc2T0RTeVFvcHJ6RVRBNmt1?= =?utf-8?B?VG50SlpuWndoVDFyS0I5LzV2bTFFSEhsN2dhQ2F6ekd4VlZVNzMrTGRWcjNp?= =?utf-8?B?eTVreDVsTUYwb1lJc3lDMUQwR2h0YzZtK3lhU2d1SDNwVHQyOTBuMXZNcUFq?= =?utf-8?B?bWw0Y3lmWElrdDd1NzZWMG5CZnlnOVdRb1hhZjZTTVVHdmlqRldIdk90TlRD?= =?utf-8?B?QkZsZVplNXQ0MmVwVjRZeE9ZNXRtQzMyUVoreFRDZkFiTU1rR3ZaT3hCc2t5?= =?utf-8?B?clV2N1JBK2FvZU81cFFiUjF0TklMUFUxT1d4OUpKdG5iVVdEbDdFc2FhZlNS?= =?utf-8?B?NXhVMGVDeFdBVnpVeTdzd2tzRG15dU1TVTRBbkpEV1ZJWHErVk0xekNoRGpq?= =?utf-8?B?VEp5Q1Q5TTU3V0pVYUVyNzBuN2ZnbkJWNjhYTTJDblRkRDZsTDVSamZmUisz?= =?utf-8?B?dy80NGZ2NGxrbDJFbWY1TlZMVnBvUzdNKytlcnFnTHB6SDNnOWsrVzQ3QUt6?= =?utf-8?B?akxGOW16Q1JSbnFxRCtCSzQ2cERhUHZVNnFCUUVpT3AyWmt5UVZnNmxVeW1u?= =?utf-8?B?YXJsNFhCcVptVkJ4WU9TKy8yYWUzYVVLSU8wN0J1Qy9KSHFPZjlwalhCeWhh?= =?utf-8?B?SzByTFk4MGZhS2pBYnROTnk0SFl4cUdYb05rTDhhVjlVT3kyd0RIT0RQQ3ZG?= =?utf-8?B?SU9tVFFIbVF6cC9OOW44RnhnUVdwM0VtYldhNElTQXhrNkNPUEI0NG94V0xz?= =?utf-8?B?QllxY0pVcnFIVjY1MCtPTUpZTkgzQS9UUXhCT2c0V3RrcjJkc0xEMFRTY2o0?= =?utf-8?B?L1YwUE5mb1AyZmc4NlZQdEZieVhlbVZZTy9qU3FTWEh1c2NRWHZ6UVAxZ3BI?= =?utf-8?B?VTlEOE1sK1g4dGhCMHQ4cVhkZ2NLdTNoMXlyeWZYbFNUU1VNVnJJNFhGWHlG?= =?utf-8?B?T0RCVVNzeVA4Y0xJVERpWll6UW96L1BYNDdGWkxTVjh6Y2l3a1RmcDVFbzln?= =?utf-8?B?dG5hSUMyWk1YM295K2xsRis1Qk1tOW45ZnJwMjRseXhWbHJ1eWo2OGRrK3ps?= =?utf-8?B?SlowcHlUejBVKzYxeFpQdkpvTjIwemMyTDcrZHExTUcvanVFRWNaQkpUSE9w?= =?utf-8?B?QTVCaWV2QXgyZFJxQkVRMCtYaUEwQXBYMmUyNlpQM2lFSSs0eW1uTE5tVzFH?= =?utf-8?B?VXdGMVp5dWpsMlNLLzRsN0o2OE5KMzhidjU3WEc4cTFoOWJUaWFyWVI1VSt6?= =?utf-8?B?UDNjZmYyZkxmNW1qTlRjSkg3WkJ1RStLWHBMeEhlNXdkWHhzQ1I1MnFzQ1F1?= =?utf-8?B?aHMyZkRYRmk4dC9NTXdkWkszTm1qMm1reUpwS2tUUlpYbm1ocEdlZWg2SUo0?= =?utf-8?B?T29RdnN4M3dqUTd6UmF0cXpFRTJydGhwMVA4QVlZUUh3ZElFQVZUbExnMXNz?= =?utf-8?B?WVp4Z05UTnhPbzJEKzZmbXJVMGg2VktVMU42K0VUOVNNZDdJRmpYUzNMYkN3?= =?utf-8?B?K0NTK1VETW5Zei9MelZacWdLM1Y3QmRBOGJzZjRyYVZpdjB6ZDZ6ZVVrRjkx?= =?utf-8?Q?TjSRoFDNsQeSu+No5lo4LUD8BJsJPRRDxvHgoXg?= X-MS-Exchange-CrossTenant-Network-Message-Id: 720e2e45-6c09-4323-f949-08d8efaf90fd X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 17:01:00.6812 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G1A7tNm6zlieLEUgc0KPhlUQQfm4kqLJ1mb0xDsOSVTeEju1D+Q8nmLHkV2QGZbeR2J+m7387FGvXCwpKjvLPGxvfM6XK6LG4g60uxi2/VI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2515 X-OriginatorOrg: citrix.com On 25/03/2021 16:52, Andrew Cooper wrote: > From: Jan Beulich > > Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC > static PIT clock gating") was reported to cause boot failures on certain > AMD Ryzen systems. > > Refine the fix to do nothing in the default case, and only attempt to > configure legacy replacement mode if IRQ0 is found to not be working. > > In addition, introduce a "hpet" command line option so this heuristic > can be overridden. Since it makes little sense to introduce just > "hpet=legacy-replacement", also allow for a boolean argument as well as > "broadcast" to replace the separate "hpetbroadcast" option. > > Signed-off-by: Jan Beulich > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > CC: Ian Jackson > CC: Marek Marczykowski-Górecki > CC: Frédéric Pierret > > For 4.15: Attempt to unbreak AMD Ryzen 1800X systems. Sorry - lost a hunk during a rebase (the one to cope with hpet=0).  I'll fold that in and post a v1.1 in due course. From xen-devel-bounces@lists.xenproject.org Thu Mar 25 17:22:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 17:22:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101498.194223 (Exim 4.92) (envelope-from ) id 1lPTg6-0003Xi-TN; Thu, 25 Mar 2021 17:21:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101498.194223; Thu, 25 Mar 2021 17:21:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTg6-0003Xb-Q4; Thu, 25 Mar 2021 17:21:50 +0000 Received: by outflank-mailman (input) for mailman id 101498; Thu, 25 Mar 2021 17:21:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTg5-0003XV-2I for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 17:21:49 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id af112a75-8ea3-4b1d-acf3-f547a9fbfe11; Thu, 25 Mar 2021 17:21:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af112a75-8ea3-4b1d-acf3-f547a9fbfe11 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616692907; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2FMF6636s1gd6L4x9OdWGb34bMRPcKFxHYCWNbXcEZg=; b=a0oJWyirGdR81W+NoOHdz2oWSncoaZ/IGTrsFn05R560G8Pv68S6jtO0 ai9bvfQyxI0UJXmANUy1kmspJJHkYRmbXSodF9F09h36ePRArtnC8+mDG K4LYGmYOgtLClj+bn/ulWJAEanc40paNJrnP5xG87y1Vnwmqww8+8eDGe g=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: m0+xdxxoX/hLVE7LURmN4a+75BCvTd9e4du/kfefGjjro87k4UuJk4CUhrYm6fE52kiwPmevUd EGV72VJ2MoQzi/XR++JZV0FmFt2cGpyR6AMk+k3+NEdqRqp+lRLRY0vsU08cEKCo5q2WL9RTLz VO6IQ3pYND16M8avFwLGw7+plKyFl1WLMc+sHopGDx/t5wHc5I//7CfNGZhwYlfJWwptKBpfNe qBXdli1t3x6K0pmGA7LOh9nhLjp1fot/k+sFTLanhGTH+d6GUVq6VpammCWcrUXz+kGtL07W5Y jik= X-SBRS: 5.1 X-MesageID: 40027912 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:DtIqEamkPBwbuZ+2IH5hGMDyolHpDfP+imdD5ilNYBxZY6Wkvu izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/NIyKMaVI3DYCDNvmy0IIZ+qbbz2jGIIVybysdx94 dFN5J/Btr5EERgga/BijWQPt48zLC8n5yAqvzZyx5WIz1CT4FFw0NHBh2AEktwLTM2YKYRMJ aH/MJIq36BVB0sH6eGL0IIVeTCuNHH/aiOCXI7LiUq9RWUineQ4KP6eiLy4j4lTzhNzb0+mF K18TDR26PLiZCG4y6Z7UD/xdB8mNztytxMbfb89/Q9G3HXpSuDIKhkU72GljgprO+o80ZCqq ixnz4Qe/5dxlmUUmapoQb8+wSI6kdQ11bSjWW2rFGmgcvlSCk0A8BM7LgpDCfx2g4bk/xXlI dotljp0KZ/PFf7swnWo+XsbVVMkHG5pHIz+NRj9EB3YM8lR5J66bAE8Fg9KuZnIAvKrLoJPc NJF8/m6PNfYTqhHgrkl1gq+tCqU3gpdy32O3Qqi4iQ2zhSqnhz01EV8swZhmsB75IwUfB/lp z5Dpg= X-IronPort-AV: E=Sophos;i="5.81,278,1610427600"; d="scan'208";a="40027912" From: Andrew Cooper To: Xen-devel CC: Jan Beulich , Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Ian Jackson , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Pierret?= Subject: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally Date: Thu, 25 Mar 2021 17:21:32 +0000 Message-ID: <20210325172132.14980-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210325165224.10306-3-andrew.cooper3@citrix.com> References: <20210325165224.10306-3-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Jan Beulich Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating") was reported to cause boot failures on certain AMD Ryzen systems. Refine the fix to do nothing in the default case, and only attempt to configure legacy replacement mode if IRQ0 is found to not be working. In addition, introduce a "hpet" command line option so this heuristic can be overridden. Since it makes little sense to introduce just "hpet=legacy-replacement", also allow for a boolean argument as well as "broadcast" to replace the separate "hpetbroadcast" option. Signed-off-by: Jan Beulich Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Ian Jackson CC: Marek Marczykowski-Górecki CC: Frédéric Pierret v2: * Drop missing hunk from Jan's original patch. For 4.15: Attempt to unbreak AMD Ryzen 1800X systems. --- docs/misc/xen-command-line.pandoc | 33 +++++++++++++++++++++++++++ xen/arch/x86/hpet.c | 48 +++++++++++++++++++++++++-------------- xen/arch/x86/io_apic.c | 26 +++++++++++++++++++++ xen/include/asm-x86/hpet.h | 1 + 4 files changed, 91 insertions(+), 17 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index a0601ff838..4d020d4ad7 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1274,9 +1274,42 @@ supported. See docs/misc/arm/big.LITTLE.txt for more information. When the hmp-unsafe option is disabled (default), CPUs that are not identical to the boot CPU will be parked and not used by Xen. +### hpet (x86) + = List of [ | broadcast= | legacy-replacement= ] + + Applicability: x86 + +Controls Xen's use of the system's High Precision Event Timer. By default, +Xen will use an HPET when available and not subject to errata. Use of the +HPET can be disabled by specifying `hpet=0`. + + * The `broadcast` boolean is disabled by default, but forces Xen to keep + using the broadcast for CPUs in deep C-states even when an RTC interrupt is + enabled. This then also affects raising of the RTC interrupt. + + * The `legacy-replacement` boolean allows for control over whether Legacy + Replacement mode is enabled. + + Legacy Replacement mode is intended for hardware which does not have an + 8025 PIT, and allows the HPET to be configured into a compatible mode. + Intel chipsets from Skylake/ApolloLake onwards can turn the PIT off for + power saving reasons, and there is no platform-agnostic mechanism for + discovering this. + + By default, Xen will not change hardware configuration, unless the PIT + appears to be absent, at which point Xen will try to enable Legacy + Replacement mode before falling back to pre-IO-APIC interrupt routing + options. + + This behaviour can be inhibited by specifying `legacy-replacement=0`. + Alternatively, this mode can be enabled unconditionally (if available) by + specifying `legacy-replacement=1`. + ### hpetbroadcast (x86) > `= ` +Deprecated alternative of `hpet=broadcast`. + ### hvm_debug (x86) > `= ` diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c index c73135bb15..957e053a47 100644 --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -52,6 +52,8 @@ static unsigned int __read_mostly num_hpets_used; DEFINE_PER_CPU(struct hpet_event_channel *, cpu_bc_channel); unsigned long __initdata hpet_address; +int8_t __initdata opt_hpet_legacy_replacement = -1; +static bool __initdata opt_hpet = true; u8 __initdata hpet_blockid; u8 __initdata hpet_flags; @@ -63,6 +65,32 @@ u8 __initdata hpet_flags; static bool __initdata force_hpet_broadcast; boolean_param("hpetbroadcast", force_hpet_broadcast); +static int __init parse_hpet_param(const char *s) +{ + const char *ss; + int val, rc = 0; + + do { + ss = strchr(s, ','); + if ( !ss ) + ss = strchr(s, '\0'); + + if ( (val = parse_bool(s, ss)) >= 0 ) + opt_hpet = val; + else if ( (val = parse_boolean("broadcast", s, ss)) >= 0 ) + force_hpet_broadcast = val; + else if ( (val = parse_boolean("legacy-replacement", s, ss)) >= 0 ) + opt_hpet_legacy_replacement = val; + else + rc = -EINVAL; + + s = ss + 1; + } while ( *ss ); + + return rc; +} +custom_param("hpet", parse_hpet_param); + /* * Calculate a multiplication factor for scaled math, which is used to convert * nanoseconds based values to clock ticks: @@ -820,12 +848,9 @@ u64 __init hpet_setup(void) unsigned int hpet_id, hpet_period; unsigned int last, rem; - if ( hpet_rate ) + if ( hpet_rate || !hpet_address || !opt_hpet ) return hpet_rate; - if ( hpet_address == 0 ) - return 0; - set_fixmap_nocache(FIX_HPET_BASE, hpet_address); hpet_id = hpet_read32(HPET_ID); @@ -852,19 +877,8 @@ u64 __init hpet_setup(void) if ( (rem * 2) > hpet_period ) hpet_rate++; - /* - * Intel chipsets from Skylake/ApolloLake onwards can statically clock - * gate the 8259 PIT. This option is enabled by default in slightly later - * systems, as turning the PIT off is a prerequisite to entering the C11 - * power saving state. - * - * Xen currently depends on the legacy timer interrupt being active while - * IRQ routing is configured. - * - * Reconfigure the HPET into legacy mode to re-establish the timer - * interrupt. - */ - hpet_enable_legacy_replacement_mode(); + if ( opt_hpet_legacy_replacement > 0 ) + hpet_enable_legacy_replacement_mode(); return hpet_rate; } diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index e93265f379..f08c60d71f 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -29,6 +29,8 @@ #include #include #include + +#include #include #include #include @@ -1922,14 +1924,38 @@ static void __init check_timer(void) vector, apic1, pin1, apic2, pin2); if (pin1 != -1) { + bool hpet_changed = false; + /* * Ok, does IRQ0 through the IOAPIC work? */ unmask_IO_APIC_irq(irq_to_desc(0)); + retry_ioapic_pin: if (timer_irq_works()) { local_irq_restore(flags); return; } + + /* + * Intel chipsets from Skylake/ApolloLake onwards can statically clock + * gate the 8259 PIT. This option is enabled by default in slightly + * later systems, as turning the PIT off is a prerequisite to entering + * the C11 power saving state. + * + * Xen currently depends on the legacy timer interrupt being active + * while IRQ routing is configured. + * + * If the user hasn't made an explicit option, attempt to reconfigure + * the HPET into legacy mode to re-establish the timer interrupt. + */ + if ( opt_hpet_legacy_replacement < 0 && + !hpet_changed && hpet_enable_legacy_replacement_mode() ) + { + printk(XENLOG_ERR "..no 8254 timer found - trying HPET Legacy Replacement Mode\n"); + hpet_changed = true; + goto retry_ioapic_pin; + } + clear_IO_APIC_pin(apic1, pin1); printk(KERN_ERR "..MP-BIOS bug: 8254 timer not connected to " "IO-APIC\n"); diff --git a/xen/include/asm-x86/hpet.h b/xen/include/asm-x86/hpet.h index 50176de3d2..07bc8d6079 100644 --- a/xen/include/asm-x86/hpet.h +++ b/xen/include/asm-x86/hpet.h @@ -53,6 +53,7 @@ extern unsigned long hpet_address; extern u8 hpet_blockid; extern u8 hpet_flags; +extern int8_t opt_hpet_legacy_replacement; /* * Detect and initialise HPET hardware: return counter update frequency. -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Mar 25 17:30:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 17:30:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101503.194235 (Exim 4.92) (envelope-from ) id 1lPTom-0004gI-QF; Thu, 25 Mar 2021 17:30:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101503.194235; Thu, 25 Mar 2021 17:30:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTom-0004gB-N3; Thu, 25 Mar 2021 17:30:48 +0000 Received: by outflank-mailman (input) for mailman id 101503; Thu, 25 Mar 2021 17:30:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPTol-0004g6-K3 for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 17:30:47 +0000 Received: from mail-pf1-x430.google.com (unknown [2607:f8b0:4864:20::430]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 20ca499a-88b6-40c6-b83a-1780b5a386f3; Thu, 25 Mar 2021 17:30:46 +0000 (UTC) Received: by mail-pf1-x430.google.com with SMTP id c17so2773553pfn.6 for ; Thu, 25 Mar 2021 10:30:46 -0700 (PDT) Received: from ?IPv6:2601:1c2:4f80:d230::5? ([2601:1c2:4f80:d230::5]) by smtp.gmail.com with ESMTPSA id i1sm6170632pfo.160.2021.03.25.10.30.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Mar 2021 10:30:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20ca499a-88b6-40c6-b83a-1780b5a386f3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:organization:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=JppXalVXiges66IliMlooSi5DLsqExUwrrbjlmg8Smk=; b=Ykf9PZU8qCOoeNQdUs8g+RFXb2CsI33DvImF1jxBdBTBA321eZIWK5KFtyZfTPNk0o oIeHgNIYshmaAR/zMFoWAD/7eKcuMce1u0hSm/1VcLcxtU7DejmvE8ZS1dqNXyufR+cS Z/KH9mtrnN76kBBE2Jj+fWOndH0p/rFoOYp/NsqXRWnaZWkK7peXskHpTrL+FpHVafuf 1BociYY5mrZ+eShau1xLmKQI+MmwZ3Be8LEFEHxwh9eX7nHv166tIml+aHuyv1bbQW9E aXqRF8iCzCBY6tjP16mXXWiZyP1PViP1oSnzDBjm810G/KtpKL0AbldhUuENYEhSaEyI Vo+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:organization:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=JppXalVXiges66IliMlooSi5DLsqExUwrrbjlmg8Smk=; b=s7Ie/T2eVFWRlkkLEP2W1QKsmRS3M/J/mc720nmrw7egmrfsvgWEgHHbit0bSRHxpO DtL9yasLtTdbdMmexCuV5APSG5/wPftvZVrfnqbd6HDiZQFEXK/3XQpEHFpwOGzAPEFe vGYOSPpK2ETWIDCZuy69/67dQ2vJTaLcGJQhbedwfcfCA3g/2bkPsZBX/LrM3hSwkeYn jM+K0GiL0YlE7XFZDFZrSNanG1FjmyebbrOPKRkXHTHLkn+gmpjBNd2JfEtjxIJBsfzC uioUomAAHZAig7Luyb6m5aoaFvoBrVKVCgH34KFUr32Y3cbboD+ZrCTfWyRsr06R35cW ljSw== X-Gm-Message-State: AOAM531iOUJv8tmmXxo5PfPfCjSkwjGkXUOW4e/EtKbc9IIsfNtaEuNY 4gaIwct9T7FQh78GFvaJXHU= X-Google-Smtp-Source: ABdhPJyL1DW0B18xPAwCDsarEqNjvMgRGgC7u6Po+CpTsJxiL55MNi1KNAkyrDYRXuJo1A4zlCf3/Q== X-Received: by 2002:a62:78d4:0:b029:1f1:595b:dfdf with SMTP id t203-20020a6278d40000b02901f1595bdfdfmr9224826pfc.81.1616693446081; Thu, 25 Mar 2021 10:30:46 -0700 (PDT) To: Xen-devel Cc: Andrew Cooper , Olivier Lambert , Trammell Hudson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , "Daniel P. Smith" , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Roman Shaposhnik , Christopher Clark From: Bob Eshleman Subject: Secure Boot / Lockdown WG Meeting Organization: Vates SAS Message-ID: <82cc3e8d-0deb-d3e5-b901-3c2f39abf9bf@gmail.com> Date: Thu, 25 Mar 2021 10:30:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hey all, I just wanted to send this out as a new email thread in case anyone missed the reply on the previous thread. It looks like the following date works best: Mon. March 29th, 16:00 UTC https://meet.vates.fr/xen-lockdown Feel free to let us know if the time presents a conflict. -- Bobby Eshleman SE at Vates SAS From xen-devel-bounces@lists.xenproject.org Thu Mar 25 18:06:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 18:06:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101509.194253 (Exim 4.92) (envelope-from ) id 1lPUN3-00083z-NB; Thu, 25 Mar 2021 18:06:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101509.194253; Thu, 25 Mar 2021 18:06:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPUN3-00083s-K5; Thu, 25 Mar 2021 18:06:13 +0000 Received: by outflank-mailman (input) for mailman id 101509; Thu, 25 Mar 2021 18:06:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPUN2-00083n-B3 for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 18:06:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPUN1-0001K7-5H; Thu, 25 Mar 2021 18:06:11 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPUN0-0007BL-MF; Thu, 25 Mar 2021 18:06:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=qRNFWzZA5VgpVn9HQse1rowwm85yesvKUlr0ASDLAfU=; b=jFVTTcOfMI1HxtnCk/3SII8Ysi CnHOTAjC/jTOXea+ihRTtvxpDgAzw24zZjdb0OJP0LPyGv+rPXfT+Yrg/qVttMixkDIhpR1dNt11Q 7Gazvnq9YUhGIo1uqbR/kavzxXVRIzGMr8WUd4QEqN26EhT+gb162g9m82J0gym2Emo0=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , raphning@gmail.com, jgross@suse.com, paul@xen.org Subject: [PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME Date: Thu, 25 Mar 2021 18:06:06 +0000 Message-Id: <20210325180607.13158-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall Commit 13dd372834a4 removed the documentation for XS_RESUME, however this command is still implemented (at least in C Xenstored) and used by libxl when resuming a domain. So re-instate the documentation for the XS_RESUME. Take the opportunity to update it as there is a user of the command. Fixes: 13dd372834a4 ("docs/designs: re-work the xenstore migration document...") Signed-off-by: Julien Grall --- Cc: raphning@gmail.com Cc: jgross@suse.com Cc: paul@xen.org Ian, would you still consider documentation update for 4.15? I looked at the implementation of domain_resume() in Xen, it doesn't look like we can get away with XS_RESUME because Xen will not send VIRQ_DOM_EXC on resume. --- docs/misc/xenstore.txt | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt index 148074233001..334dc8b6fdf5 100644 --- a/docs/misc/xenstore.txt +++ b/docs/misc/xenstore.txt @@ -294,6 +294,22 @@ IS_DOMAIN_INTRODUCED | T| or F| ie, if INTRODUCE for the domain has not yet been followed by domain destruction or explicit RELEASE. +RESUME | + + Arranges that @releaseDomain events will once more be + generated when the domain becomes shut down. This might have + to be used if a domain were to be shut down (generating one + @releaseDomain) and then subsequently restarted, since the + state-sensitive algorithm in xenstored will not otherwise send + further watch event notifications if the domain were to be + shut down again. + + This command will be issued in place such as resume because + Xen will "shutdown" the domain on suspend. + + xenstored prevents the use of RESUME other than by dom0. + + SET_TARGET || Notifies xenstored that domain is targeting domain . This grants domain full access to paths -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Mar 25 18:23:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 18:23:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101515.194266 (Exim 4.92) (envelope-from ) id 1lPUdd-0001oM-Ab; Thu, 25 Mar 2021 18:23:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101515.194266; Thu, 25 Mar 2021 18:23:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPUdd-0001oF-7S; Thu, 25 Mar 2021 18:23:21 +0000 Received: by outflank-mailman (input) for mailman id 101515; Thu, 25 Mar 2021 18:23:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPUdc-0001oA-2Z for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 18:23:20 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [170.10.133.124]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 723b6338-6627-45a1-9498-3eb9d2ea3e19; Thu, 25 Mar 2021 18:23:18 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-HqhYvH7cNryB9nYeNtIcww-1; Thu, 25 Mar 2021 14:23:11 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CD4638030DD; Thu, 25 Mar 2021 18:22:09 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-200.ams2.redhat.com [10.36.114.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id 53DFC1000358; Thu, 25 Mar 2021 18:22:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 723b6338-6627-45a1-9498-3eb9d2ea3e19 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616696598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jIcoE/aP9OWTquxuzaRGcRIdXcSeCOahwq33fGzKmI4=; b=JFaOU4IrTRQGEc4vcWJNkToA8ZcojViADHYruvX/sMF70sbUdfHgTvI/JjVEcBp3045ack QUOjh2drzi+HWicrgSFHGYlzVxFqSb84RUm8TpwYAu/uVjVPFUB6fsDJ9xepbiItK8mxLm KHXeIHbcjZbF6MQ7uVS2T0yCmrumoLU= X-MC-Unique: HqhYvH7cNryB9nYeNtIcww-1 Subject: Re: [PATCH v2 0/7] OvmfXen: Set PcdFSBClock at runtime To: Anthony PERARD , devel@edk2.groups.io Cc: xen-devel@lists.xenproject.org, Jordan Justen , Ard Biesheuvel , Julien Grall References: <20210325154713.670104-1-anthony.perard@citrix.com> From: Laszlo Ersek Message-ID: <21719b4f-0da5-f5f1-bafa-9d2a399bc87d@redhat.com> Date: Thu, 25 Mar 2021 19:22:07 +0100 MIME-Version: 1.0 In-Reply-To: <20210325154713.670104-1-anthony.perard@citrix.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/25/21 16:47, Anthony PERARD wrote: > Patch series available in this git branch: > git://xenbits.xen.org/people/aperard/ovmf.git br.apic-timer-freq-v2 I'll get to this sometime in April, possibly after the SEV-SNP series. That shouldn't discourage others from reviewing sooner, of course. Thanks Laszlo > > Changes in v2: > - main change is to allow mapping of Xen pages outside of the RAM > see patch: "OvmfPkg/XenPlatformPei: Map extra physical address" > - that new function allows to map the Xen shared info page (where we can find > information about tsc frequency) at the highest physical address allowed. > > Hi, > > OvmfXen uses the APIC timer, but with an hard-coded frequency that may change > as pointed out here: > https://edk2.groups.io/g/devel/message/45185 > <20190808134423.ybqg3qkpw5ucfzk4@Air-de-Roger> > > This series changes that so the frequency is calculated at runtime. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 > > There is also one cleanup patch that has nothing to do with the rest. > > Cheers, > > Anthony PERARD (7): > OvmfPkg/XenResetVector: Silent a warning from nasm > MdePkg: Allow PcdFSBClock to by Dynamic > OvmfPkg/IndustryStandard/Xen: Apply EDK2 coding style to > XEN_VCPU_TIME_INFO > OvmfPkg/IndustryStandard: Introduce PageTable.h > OvmfPkg/XenPlatformPei: Map extra physical address > OvmfPkg/XenPlatformPei: Calibrate APIC timer frequency > OvmfPkg/OvmfXen: Set PcdFSBClock > > MdePkg/MdePkg.dec | 8 +- > OvmfPkg/OvmfXen.dsc | 4 +- > OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 4 + > .../IndustryStandard/PageTable.h} | 117 +------- > OvmfPkg/Include/IndustryStandard/Xen/xen.h | 17 +- > .../BaseMemEncryptSevLib/X64/VirtualMemory.h | 143 +--------- > OvmfPkg/XenPlatformPei/Platform.h | 10 + > OvmfPkg/XenPlatformPei/Platform.c | 1 + > OvmfPkg/XenPlatformPei/Xen.c | 252 ++++++++++++++++++ > OvmfPkg/XenResetVector/Ia32/XenPVHMain.asm | 2 +- > 10 files changed, 287 insertions(+), 271 deletions(-) > copy OvmfPkg/{Library/BaseMemEncryptSevLib/X64/VirtualMemory.h => Include/IndustryStandard/PageTable.h} (60%) > From xen-devel-bounces@lists.xenproject.org Thu Mar 25 19:42:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 19:42:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101522.194284 (Exim 4.92) (envelope-from ) id 1lPVrx-0001qz-C5; Thu, 25 Mar 2021 19:42:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101522.194284; Thu, 25 Mar 2021 19:42:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPVrx-0001qs-8O; Thu, 25 Mar 2021 19:42:13 +0000 Received: by outflank-mailman (input) for mailman id 101522; Thu, 25 Mar 2021 19:42:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPVrv-0001qn-Sw for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 19:42:12 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8356ec69-dd3e-4d8d-9faa-f9b92af8e329; Thu, 25 Mar 2021 19:42:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8356ec69-dd3e-4d8d-9faa-f9b92af8e329 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616701330; h=from:to:cc:subject:date:message-id:mime-version; bh=aIIfJIAzczl8EGWOaraqkh2HmY3ZaEAZ9d3r68Bfg0s=; b=GVAa0msrC0Nklc1X/XVDfIRHu7rjKfX949tx7s5umcpVbB0qGSGBrqZI xVc/9IVd4nBM7AFmZV1Q/caaJgKYvouuRGJFLLVlyTvAYac2CH6dWDc/y qyhqOzGjD0re2lVyWnIUoFM4j5UPKEyoo1ruj8mnxJLvejQkteVGEG9RC Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: BtKYWRideZ7y8j0+kLJIxalzpUbhtB6UtuVKo4lwhoYa8/QL3qHhghQB8acMKXDqCFttmu2xk8 9fxWoaefdYyUetblSCKNItWbKRYn5XC8n3N5XwR58k9EcXqTJSMsY3Imwuk9WvxZy9F5SBgc20 7TRRlmv+iv7W2wVUXpNQRNgrTXHL8uiV0wmSFurbG6z+D63m4ACheCGOrdfldCM0qvIFmJyeNa jc2O6MFtTyyB74EH9ONJgnThqTWXxhJmmzTl/h2al8EZlLSrVU3E4OtI9rtIh/IakVy1rILbuG LXw= X-SBRS: 5.1 X-MesageID: 40523826 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:gRtLWa0atCvyDClphdXKzgqjBWByeYIsi2QD101hICF9WtCEls yogfQQ3QL1jjFUY307hdWcIsC7LE/035Qd2+ksFJ2lWxTrv3btEZF64eLZslndMgDd1soY76 dvdKBiFMb9ZGIRse/W6BS1euxO/PCp66at7N2x815IbSVHL55t9B14DAHzKDwSeCBjCYAiHJ SRouprzgDQGkg/VciwCnkbU+WrnbSi+K7OWhIaGwUhrDCHkDLA0tXHOiKF1RQTWS4n+8ZBzU H5lWXCh5mLgrWA5TL3k0TS6JlXn9WJ8Ko/OOW8zvI7Bx+ppgKhZIFKU6CPsjYvsIiUmSoXue iJmTgMFYBe7G7QY3GUrHLWqnbd+Qdr0VDO4xu5hmbuusPwTj5SMbs+uatpNiH3xmBlmfMU6t Mt40up86B5IDmFoQHGo//PbB1unlrcmwtYrccjy0ZxfKFbVKVctuUkjSVoOaZFJg3WwqY9Ht JjCcnNjcwmC2+yXjTism5jzMfEZAVLIj62BkwLusmi2zNLhnxOz0wB2MwFnnsbnahNM6V52w == X-IronPort-AV: E=Sophos;i="5.81,278,1610427600"; d="scan'208";a="40523826" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Ian Jackson , Wei Liu Subject: [PATCH] tools/libfsimage: Bump SONAME to 4.16 Date: Thu, 25 Mar 2021 19:42:01 +0000 Message-ID: <20210325194201.10998-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain Fixes: a04509d34d ("Branching: Update version files etc. for newly unstable") Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu --- tools/libfsimage/common/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libfsimage/common/Makefile b/tools/libfsimage/common/Makefile index 060f029ca9..24bc90e73e 100644 --- a/tools/libfsimage/common/Makefile +++ b/tools/libfsimage/common/Makefile @@ -1,7 +1,7 @@ XEN_ROOT = $(CURDIR)/../../.. include $(XEN_ROOT)/tools/libfsimage/Rules.mk -MAJOR = 4.15 +MAJOR = 4.16 MINOR = 0 LDFLAGS-$(CONFIG_SunOS) = -Wl,-M -Wl,mapfile-SunOS -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Mar 25 20:16:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 20:16:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101528.194298 (Exim 4.92) (envelope-from ) id 1lPWOp-0005DN-Vj; Thu, 25 Mar 2021 20:16:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101528.194298; Thu, 25 Mar 2021 20:16:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPWOp-0005DG-Sf; Thu, 25 Mar 2021 20:16:11 +0000 Received: by outflank-mailman (input) for mailman id 101528; Thu, 25 Mar 2021 20:16:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPWOo-0005D8-Fo; Thu, 25 Mar 2021 20:16:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPWOo-0003WW-5d; Thu, 25 Mar 2021 20:16:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPWOn-0007Tc-RN; Thu, 25 Mar 2021 20:16:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPWOn-0001Bm-Qw; Thu, 25 Mar 2021 20:16:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=S4bWKONK4fsengxxyIkmGrsPDsaPqPyRblTK/1ARMPs=; b=W4EMKh344k8bwicz9LyYXq0V9e aLDcmxBXf4kJZainXMhoLzLZc2vq8YKm8maB1EaG8/HIBl73qFxiq5sMoRcK+nUojrwNH5KB2uooQ Y8Jakfwm17xbOlq3laNusj/2VMbMWDz/u2JUq5ERIDsaBMJgoi//O2H6PgMor9DhVXKI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160406: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=98e22ff7493ac920c5ebab63f07cfea7313fd610 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 25 Mar 2021 20:16:09 +0000 flight 160406 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160406/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 98e22ff7493ac920c5ebab63f07cfea7313fd610 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 258 days Failing since 151818 2020-07-11 04:18:52 Z 257 days 250 attempts Testing same since 160406 2021-03-25 04:18:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 48933 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Mar 25 20:36:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 20:36:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101537.194320 (Exim 4.92) (envelope-from ) id 1lPWiH-0007RC-O3; Thu, 25 Mar 2021 20:36:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101537.194320; Thu, 25 Mar 2021 20:36:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPWiH-0007R5-L5; Thu, 25 Mar 2021 20:36:17 +0000 Received: by outflank-mailman (input) for mailman id 101537; Thu, 25 Mar 2021 20:36:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPWiG-0007Qe-7l; Thu, 25 Mar 2021 20:36:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPWiG-0003rR-1z; Thu, 25 Mar 2021 20:36:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPWiF-00006g-Qk; Thu, 25 Mar 2021 20:36:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPWiF-0008PL-QD; Thu, 25 Mar 2021 20:36:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aQD6TJGROpGiZ4FGP+gRxE8Rgrimy/S8xOHzvm0e3Bs=; b=exRz627ot8V0YpQDCsz+eCP7vt XM4Dv88c7HA6b8GF1U37+xgZ5LawfbchMOhedv70FB54+Oy/nQ4fC2Hhn0utmD2P6iu0iSQZPR1i3 S4PiBWMmSUe5rykuRSJOkINs79rJz6DRCWo+NuNsg+jSp9IkNH7c4A+7tPcX8iLgg7e4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160419: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4ca6217bef99128027a9b64c055e4967a5dabd0c X-Osstest-Versions-That: xen=64d07691755e9aa6d3453ef3bb9109fde2b8da1e From: osstest service owner Date: Thu, 25 Mar 2021 20:36:15 +0000 flight 160419 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160419/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 4ca6217bef99128027a9b64c055e4967a5dabd0c baseline version: xen 64d07691755e9aa6d3453ef3bb9109fde2b8da1e Last test of basis 160397 2021-03-24 17:00:26 Z 1 days Testing same since 160419 2021-03-25 17:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 64d0769175..4ca6217bef 4ca6217bef99128027a9b64c055e4967a5dabd0c -> smoke From xen-devel-bounces@lists.xenproject.org Thu Mar 25 20:37:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 20:37:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101541.194335 (Exim 4.92) (envelope-from ) id 1lPWjR-0007Xq-4c; Thu, 25 Mar 2021 20:37:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101541.194335; Thu, 25 Mar 2021 20:37:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPWjR-0007Xj-1H; Thu, 25 Mar 2021 20:37:29 +0000 Received: by outflank-mailman (input) for mailman id 101541; Thu, 25 Mar 2021 20:37:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPWjP-0007XZ-Ef; Thu, 25 Mar 2021 20:37:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPWjP-0003sN-BF; Thu, 25 Mar 2021 20:37:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPWjP-0000Ae-4S; Thu, 25 Mar 2021 20:37:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPWjP-0002cz-3y; Thu, 25 Mar 2021 20:37:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DIvid+FMYtdy9zsdSNEQ7FMOvllYdo3SZDYI0jObqWo=; b=IQrD5V4pJm8pJ5B8oMnJa1u/lP vvHrbcWT+z0bfsdHPK1/KICTUTXb83Tf2Dlx85nAMaAFf2/6nKkoSms7OMwVSmfL8zPaE0D0A5o9X OdIBxYMRL5QIZA3jUGl5/RREItvgj+di0ULz/ACU0vDB0eZ91GUvrd6jhnHOUvZBToX4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160399: all pass - PUSHED X-Osstest-Versions-This: ovmf=f037af6ecbc3b55042c998a59ed8df8548e64b99 X-Osstest-Versions-That: ovmf=0ecdcb6142037dd1cdd08660a2349960bcf0270a From: osstest service owner Date: Thu, 25 Mar 2021 20:37:27 +0000 flight 160399 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160399/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f037af6ecbc3b55042c998a59ed8df8548e64b99 baseline version: ovmf 0ecdcb6142037dd1cdd08660a2349960bcf0270a Last test of basis 160352 2021-03-23 05:41:31 Z 2 days Testing same since 160399 2021-03-24 22:10:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ross Burton Ross Burton jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 0ecdcb6142..f037af6ecb f037af6ecbc3b55042c998a59ed8df8548e64b99 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Mar 25 22:57:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 22:57:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101556.194356 (Exim 4.92) (envelope-from ) id 1lPYuc-0005Uy-GC; Thu, 25 Mar 2021 22:57:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101556.194356; Thu, 25 Mar 2021 22:57:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPYuc-0005Ur-D8; Thu, 25 Mar 2021 22:57:10 +0000 Received: by outflank-mailman (input) for mailman id 101556; Thu, 25 Mar 2021 22:57:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPYua-0005Um-Dj for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 22:57:08 +0000 Received: from userp2120.oracle.com (unknown [156.151.31.85]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 75e8c25c-66c1-4eaa-a019-d1772132c0b3; Thu, 25 Mar 2021 22:57:07 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12PMt9HB112748; Thu, 25 Mar 2021 22:57:04 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 37h13e8d89-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Mar 2021 22:57:04 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12PMtIRM182826; Thu, 25 Mar 2021 22:57:03 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by aserp3030.oracle.com with ESMTP id 37h140n4bs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Mar 2021 22:57:03 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BY5PR10MB4340.namprd10.prod.outlook.com (2603:10b6:a03:210::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.26; Thu, 25 Mar 2021 22:57:01 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.025; Thu, 25 Mar 2021 22:57:01 +0000 Received: from [10.74.101.239] (138.3.201.47) by CH0PR03CA0285.namprd03.prod.outlook.com (2603:10b6:610:e6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Thu, 25 Mar 2021 22:57:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75e8c25c-66c1-4eaa-a019-d1772132c0b3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : references : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=EzPllQmjJ2MAsdxWEpVbMU/4HFnw55suz1Vf+Qgmp8o=; b=ezKt0RoSUO/x38TlCk3BB8JdFdq+OaO3kCHqVan9MuApOoCGnm6/F1+0SxUxZyzcBLJK x/38tIcY5FyJ4ofobZjFVbnv/LFzytIwrPJYtauj/fG9du/rHZfNq9x0sXfJyTlwm6Di O4QvOnGx/EfNntogrzhgUEp0IwKyvW71Dp5Ce+Sy8aRHIDJe8n/n7Y8idQdgcF1KfT6M q25pb8Q1Kp9sU8TFFh28n5acasjNaQJXuR7CWrhJL8wakZfSiDV4Pv2EBlB+b5qe+lfU m/+MoSe7PmYdcAJVNdJOCU0bSOBHLLBnaLG03MVQosWpKZH+Dk5rNcFgas3ZHHtZy3qG pg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EzHFnq1mLxCO2zln+KgfJRE1oppDnK4dcGZxZqfEurOD1hCsi3vL/ntSigPTf9oH3d6LozU9hHrmM3Zz2PfyIlN4wKpoCi20KBZuACjaleFEL/2xHzLLEBU3YgKnVhxI63B0fhANYq05p9CqqRb4IJ48LZfuWU8uX86zqXVQswTQU/1rrS1L3iBXsziOPnmZH85ogMi2PQJdRIFVs8NyU0aeZphtsbPLzbJDDflfjPgiXK1bNQEym5NqNwQqqLIe2zHB/I8qKc1JoovV6OeEvU1ZUQAyi7S70cWC5lPhR/znnV1rk3ODgjvw1ywspzhd9NQsy9fy8GBlqCkffNR6xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EzPllQmjJ2MAsdxWEpVbMU/4HFnw55suz1Vf+Qgmp8o=; b=PfU6LjUia6xjBqTmRbhfg5+INxzzA77cE0WA9CzmzpRS7/T+Ouo6MqGLd9rY9rk8oUNZ9El4+Y8qwWNfLBCQ3qVGv0mbinkM7//wEk2QWgD2Kl+siK81ol4D7BiS3jZ//MATrKnGRXyKwtf3QAYgN8aVT88foG+dq+eZ9PrV4M+KdX+RJF5GCc4YQ38egzi44WEoPRR2uCDZR6UYR9U41ZQ3wXhbTkH0D9aoE1kvXMyeBUdcv6K0q2Bt9Xd4C55i6yftBPQiH7nVXqAcK+eHTT+dUG2zh9o23a+DKEDAlQOE/4YVqcrQk3tzxovQ5bfearjJuoYoHlF+EdehHui9jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EzPllQmjJ2MAsdxWEpVbMU/4HFnw55suz1Vf+Qgmp8o=; b=jHE00/XxYg8YwP9GE+qhh4BdwlOdszEs1Ye2H3vR4L2LpK6AnSTN8R7iPxHhND1FgrnPYVifocAZEMAGgJs+oyzBQp/70+ItJoYClq7+cTqW6xDKze8qWZy1glV5TPBcGNhTkApKWAZ4Iff6wh3TD7Oz52q7zlDEnvi05JygwBY= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH v2 0/2] xen/x86: alternative fix for XSA-369 From: Boris Ostrovsky To: Roger Pau Monne , linux-kernel@vger.kernel.org Cc: Juergen Gross , Stefano Stabellini , Jan Beulich , xen-devel@lists.xenproject.org References: <20210324122424.58685-1-roger.pau@citrix.com> <6b70700e-667b-03a7-8f5e-937d5c45c79d@oracle.com> Message-ID: <62cde005-9aff-39a2-0b4f-eb262b411d2e@oracle.com> Date: Thu, 25 Mar 2021 18:56:57 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <6b70700e-667b-03a7-8f5e-937d5c45c79d@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [138.3.201.47] X-ClientProxiedBy: CH0PR03CA0285.namprd03.prod.outlook.com (2603:10b6:610:e6::20) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e0eb42eb-5422-44a1-1bdb-08d8efe14d04 X-MS-TrafficTypeDiagnostic: BY5PR10MB4340: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u6wAxLNl0WNWBSZP4mR4ATFqC3SSLebgrICEjkBTu6fXU/3ChEiaQ0/yxfuH7+2B3NEb8fSdOqxIJNG26omvS36rujjzMsIfENLBT9e+CJuCnk+cQ3IkJO08W73W6pr9z7c1TYTGebZd9R9wquM6r6+L1/8IuRp6r9ZdMx0CexCckMpfxUOGHaFLSkVm5wOK/w2b3OhNJJiU6o0LU+csG/0GqQip27XDJsUx2/Zm3PyVVvANyyvKxep7knPvFOoY4Sxd4FFo49GAsk34TZH9c9djHf70LIoyd1eE/jHORXMY2yFUX/P/VawbqmVyn3/fZQ1Ijkgb7zFYmRRpyjDOsF/YCLRkLgbnw2Ub/vKh8vnOGh1pVlfWKu07Lq00CnqRDmBpDa6bTGglQKQUgQ9oSbv8geJMmqsomTelV8zr4fe8xsMpskU6cjuQ2AV2BxA4bZ/4eazTdBBttk7BmpjgJyIIGe28xi2f20sDzT0mQAams0CC0zDkdm8kKN3/iq37cZDUJTSaWCedS5mgPFgQQd7fGsaId8BV/mKc/iNoiVBWbUmNX9grHDYexvzql/ZMBBOc7NTG6mn9T3mRRWoVBFUo0wceB9qAbZEPHsCs+2XCYcLmp/aoRPWBKntw0xdmkddTiG8FHainmC5O78DOh1sx+Lc0msZZwaRt338N6qKWqgsEJtOChE7rjV3aaEOSJCFor+bUSY9haLzRs6YKlimyHl9hFuJzsgoGyGuuEF0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(396003)(346002)(366004)(376002)(5660300002)(186003)(44832011)(53546011)(38100700001)(36756003)(31686004)(26005)(31696002)(16526019)(2906002)(6486002)(956004)(4326008)(66946007)(2616005)(478600001)(66556008)(66476007)(316002)(16576012)(54906003)(8936002)(8676002)(6666004)(83380400001)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eENhRmNtWnh3Ui9udkowWVc4NE1KZ2ZGU0NWdHpIOXR6U1o5aXV0YXMxa3lQ?= =?utf-8?B?akc4bXFDNWtwM0JFeXN0MS9aSkZCbElKVWRZOFIrRUF5ZGE3WWorR3hYL1dt?= =?utf-8?B?RzlHS25FSW9qMFhnNm5wRk5IY2xZSktwMWpHN0VUZDdRS3JRRTI3UWdxQXJH?= =?utf-8?B?czU0dTNqZHJhSzJjLzdRbk90VnRuT05EeWYzNjcyK0cvTEJseTA2RUpDT3pi?= =?utf-8?B?TWMvUDI2ODc5SjNTK25PWFFxczBXNmZ2Si9nWnJ6c2QxQitYTDI3SDhlbnBM?= =?utf-8?B?WDN1Y0V6cHRUR3BlcVFIM0ViSldLRmM1a2piSVNTSEVhOUVyZUNCU3NSWkRy?= =?utf-8?B?VHVzNmtKTkE1ektkZXlsUWpPTlZTZGdzQ3pGdGZsRndTWTY4YUM3NEVuaGhj?= =?utf-8?B?RG1tTzBuT21ucVNmNmN2c21tdSs5UVRGTHZQMzkzMVdzMkJkeHhZaXd1TE9J?= =?utf-8?B?bERoZzMvSFR6OFQwS3dQMWlMSkFRZUljTDg5Y01rZjdUQXo3amFHbjNNTnBz?= =?utf-8?B?bmVYbWpTZ1FCS1JxWGN5UTRJQ2JScHJ3SWRKUmhXQk03ZDJWK1R4NTU4ZHFE?= =?utf-8?B?aVpiLzJrdmNIMEI4b2tOSVJCSjJLWXg4aVhHMzlSU25Dakl5eFQ5YjJESy92?= =?utf-8?B?ZjIzaW1ucUE2ZUxRaTVsaUtrcisvRVZ2MkJLcDFBU29QTXRTclVwRXp1WkFn?= =?utf-8?B?QTllTkZyVUU5L3RQSVBKcUZ4R0VxTG5PVVBhVmNsUWUzdGI4K3lZeC9EalB6?= =?utf-8?B?RksxaHgzWDk3bXNQUXdzMWlUbUx4SE1LWXZhTnRBTlkzbjluY1c3aU5TSUZ2?= =?utf-8?B?V1VSdmhRTlVmSThKS0huaVRPVThRMnN2OVpnOE5jRmFDMGlQSEJmUWkzTGFY?= =?utf-8?B?cWpqVElhOWpCWGZsR2NIUW5jbmVOakRycXR1Njg1SWhnZkxPd09mekJkeVZs?= =?utf-8?B?WklYYms0V2lqNzE5RXBGWGJNb2FtWjBiZitEdTB2MDIvZWtIWGRoTnJFbFBT?= =?utf-8?B?YW1ZbUQvVkoxcDl3UDhRN0RiaVN1NUp0NXhBTm1hUEJERVQvSlZ1cnRrRHdp?= =?utf-8?B?SHNVbzVhUzhocVdDMEozTEtmYzI4SW1remtoQlBxSVdkL2RiMlRqZ0RFUnUx?= =?utf-8?B?ZWZ2Z0V3R1BQMUc2eStCMDZJZy9KOVpmUWl1bXo0SDA3ZG5LK1FNQnJta0pP?= =?utf-8?B?VzlwaEl4dnB1ZUVtd1d0RFRZa005L0h5ckZvNzVjTHBUYkpIVW1EbC9tMVMz?= =?utf-8?B?SXVkMGtHMDZ4OTRmUGc4WVQ1bEJ1ZTkzbjZzN2d6Kzg0czFwNElkeS9WSHUw?= =?utf-8?B?ZWJSbDBYTEx5V1pZdEo4ejVvT05Kb0ZNd053NmJjNEFNYnVBRU9lUGtaSHRX?= =?utf-8?B?akxWVVNJSzZLQmlrWW1Dc2w2M1MvTlpyUmwveHN0Z2F2VWRZZUxlRkcrb25h?= =?utf-8?B?SnBFSUFoS2NwV240WFNQZzVBaUtNUWNaRlF6VWRxRDMwQVVEL3YxS3BTSXNn?= =?utf-8?B?NFNDeDVidDRob0N4TkdWeDNjUU9tM0MxdDJBdmFIakJhWGlLUDUweEI0QUJx?= =?utf-8?B?d2JTcTBFNHlvamwyRi9RVjcybW9vRmVYL0g2dUYweXBxVjdEalU2NXBidEZY?= =?utf-8?B?K01LbmpaRmU4VzB6bEhQQks4ZFR2dWpzL3NPRkpWM1VxNzRaMnhaQzYzU0Er?= =?utf-8?B?dUFzS2tIUXdlZGxSOVFVK0JuMys4MERHS3NZNElidWZsVUw2V2dqTkk4WnlF?= =?utf-8?Q?4iWTx0Nqm3t2zmP7FH7kDXCky34d+G9CxhHuQMo?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0eb42eb-5422-44a1-1bdb-08d8efe14d04 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 22:57:01.4588 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nZd4EPoEB+LiklUJ1kXWueADHMoUqKR6qXVdOnlmJDcTSHPFggfA5UZE8Vt3Uj/ks6ZZsR/1JoorYaCMW0ax895/ia2tTcl26DGq+BZTuaY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4340 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9934 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103250169 X-Proofpoint-ORIG-GUID: uYNVyr4eGFm5HZDWJX-UssneCXGmvXK4 X-Proofpoint-GUID: uYNVyr4eGFm5HZDWJX-UssneCXGmvXK4 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9934 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 impostorscore=0 phishscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103250169 On 3/24/21 7:09 PM, Boris Ostrovsky wrote: > On 3/24/21 8:24 AM, Roger Pau Monne wrote: >> Hello, >> >> This is a proposal for an alternative fix for XSA-369 that instead of >> special casing XEN_UNPOPULATED_ALLOC to size the p2m relies on making >> XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on the generic MEMORY_HOTPLUG >> option rather than XEN_BALLOON_MEMORY_HOTPLUG. >> >> I think this is safer, as we don't want to be special casing any option >> that pulls in generic MEMORY_HOTPLUG without XEN_BALLOON_MEMORY_HOTPLUG. >> Without this we would also need to at least special case ZONE_DEVICE >> which also relies on MEMORY_HOTPLUG, and is what pulls the generic >> MEMORY_HOTPLUG option even when XEN_BALLOON_MEMORY_HOTPLUG is disabled >> with XEN_UNPOPULATED_ALLOC. >> >> Thanks, Roger. >> >> Roger Pau Monne (2): >> xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on >> MEMORY_HOTPLUG >> Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" >> >> arch/x86/include/asm/xen/page.h | 12 ------------ >> arch/x86/xen/p2m.c | 7 ++----- >> arch/x86/xen/setup.c | 16 ++++++++++++++-- >> drivers/xen/Kconfig | 4 ++-- >> 4 files changed, 18 insertions(+), 21 deletions(-) > > Reviewed-by: Boris Ostrovsky Applied to for-linus-5.12b. -boris From xen-devel-bounces@lists.xenproject.org Thu Mar 25 23:18:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 25 Mar 2021 23:18:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101562.194374 (Exim 4.92) (envelope-from ) id 1lPZEA-0007jq-AL; Thu, 25 Mar 2021 23:17:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101562.194374; Thu, 25 Mar 2021 23:17:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPZEA-0007jj-6c; Thu, 25 Mar 2021 23:17:22 +0000 Received: by outflank-mailman (input) for mailman id 101562; Thu, 25 Mar 2021 23:17:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPZE9-0007je-CW for xen-devel@lists.xenproject.org; Thu, 25 Mar 2021 23:17:21 +0000 Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0980db8f-52fc-4139-ae98-c5dc2e07fb1b; Thu, 25 Mar 2021 23:17:19 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12PNFEo5135131; Thu, 25 Mar 2021 23:17:17 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 37h13rref6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Mar 2021 23:17:17 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12PNGIVr029107; Thu, 25 Mar 2021 23:17:16 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2177.outbound.protection.outlook.com [104.47.58.177]) by userp3020.oracle.com with ESMTP id 37h14gdwyj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Mar 2021 23:17:16 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BY5PR10MB4242.namprd10.prod.outlook.com (2603:10b6:a03:20d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Thu, 25 Mar 2021 23:17:14 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.025; Thu, 25 Mar 2021 23:17:14 +0000 Received: from [10.74.101.239] (138.3.201.47) by MN2PR01CA0038.prod.exchangelabs.com (2603:10b6:208:23f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24 via Frontend Transport; Thu, 25 Mar 2021 23:17:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0980db8f-52fc-4139-ae98-c5dc2e07fb1b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=j9wkUCORkX/lz7apVR880/LJ25oSKh6Y81+b7CDAxUo=; b=ijKMJLUy3siQasSfENAyPszm8XxXqM/xiG5oDY8gqobjROvIdNDqy8NxDtlRKmhPyJnO v8ONo+X1CZXKR7vfksqbcCiL61vpwVmaxZA5SBdpi4ayLpAw1ZicMDOc+saSXqPbq9gl MAgL1b0BtKeJyXSeSdATtTkbgZrSuyWfmvZvYqRkrG0SXPs48pa+T5/9qbKPaR9lCeqr fqo3GywXJDKPZThocFUNJDcO7N9P3QgvOtl+s5SpJc2DbWiba8wDXBffPtPMeY42JD1M t0l+iwKTsxOX4S0spEnbgPzgXQUWJc1peQ0ADmDBaLX8gdpItWsZio7QMk/8tT1zzUCo Aw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jnjiaohNTQAy3Oax0K991AdNAEvI2Qy0s0YLG0dyCyvcm6b0y22/+hc0ehqEVzckVKo7thft9TyI34j7naxjeZ2wwSZp37qRkkoiFikAQYcDBOqZv8Qj4z2LoT86imwR7wApACnlMCk6wrUv/lMSehKSv2y7Rrdgg6rK3Nrgi5Onl6FuDL8CCRxdhHIoyRZuB1H7rxNs+ypCGTwPygSNCheBm3uUDDhqCv4sZWR1afOWcM7T7baOrOfgdThCD+XqPBBcPIOYJXsEleeH7CNNjWw0MtBI4WA3jEOYpZIE0+ypCcsmSaQsnZEIgytTwthaSCpBhUlX7WoGO53npgrfrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j9wkUCORkX/lz7apVR880/LJ25oSKh6Y81+b7CDAxUo=; b=oUtBX/2MN3gSJrbkL82dsNlM0wqWV2hjeAzBYj2wzuI//PgR2plG2tiisD0HMz4qRYbEzIi2rvY5SoXIZlSTTMSLRF6N3n9Oq58r8UKiruZN+hG+wKF7NuWC3gaKbfDiyBjPHhUkQ3kS11R0SeMMLfsD2NdAQ4FIhU20cpfojwi878Ysnh5ezUw7O/SCzKWDpAcIlRxQWQnp0mDswvSGuFTm9HY4oYlTmmCu4o3gGUWufA9yo49d9Vi3BdOQU58zKfeZf17gK7NK5hC5u/TMlZOdMLf2snfrgTkkWjvujj9/KcoQ06TF4f11REzIp1XQX7hq+kmo7aw6pRM9KkBtzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j9wkUCORkX/lz7apVR880/LJ25oSKh6Y81+b7CDAxUo=; b=wOrJvFMQy4L5VkrqGQkdTdPvdCECuTNQdJ4vXu2LHSkwXvCzj9C1uWmfimScxHePSI8dFL3x9ZO0vnjqFTYKyiVxS9Zyq8lAow3aYgDkFX71+WOp7OY6SakgXjs+baMKZSCzEYMCVifAP/26RFNAU3aQLtlFiWWmCaMMp36rM74= Subject: Re: [PATCH RESEND] x86/vpt: Replace per-guest pt_migrate lock with per pt lock To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, jbeulich@suse.com, andrew.cooper3@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com References: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> <1616619905-640-2-git-send-email-boris.ostrovsky@oracle.com> From: Boris Ostrovsky Message-ID: <8b72a5c6-e105-ae8e-f0c8-12330f95fe11@oracle.com> Date: Thu, 25 Mar 2021 19:17:10 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [138.3.201.47] X-ClientProxiedBy: MN2PR01CA0038.prod.exchangelabs.com (2603:10b6:208:23f::7) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3ded7e07-3524-4d6b-130c-08d8efe42032 X-MS-TrafficTypeDiagnostic: BY5PR10MB4242: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cFC7fSBISRdTpE777I/ChNYMWA3BSYnMKRy6vpPwQLGVPffDkkyvDr1gPcswf1BA0zhNSdKmy2ZxlrmfrDK0lzvL3h8QoVZDQ0mYxEk9NnOFMMWIVZTf5oQN6r2Igsfgw0CwfaYqAGoIMEtFJsVbq3SZa4hxY+MLoXUZGieouDUESCB5it2OvCSy9Egbspa6TxY5t9qxjzYQoLNTZSh3UW6atuAM7W5nlOU6qsgYXu9ehRAndnA89Q7MT0s0LPyR16zMiCKnksw/O18BUgEkoRLPhzG/hyAUxnT1E1fmZWot51Q4f1cYhgPIbjhVqiL9hAHTBoonyTeLTzPf/xaJu8xfRV9s6TmlqMEuR75A/VWNzPJSQTPeHR7ld+JLcpvW8X8a8XifKtuBDef5hlQt/AqtgmdvLY4/AadLau2TsNM8rkgpD0qTejVPo498fRg7zAKQG0ZWFbGaqdhepzD/nbrfRjo18k+3UCol6uvdWNHTc84RkFQ05qrvKFq+RVhPXpvTXBlLQm5DKVpjDjp+AVVkd+huaFWlY5/Csw+QTuMGTnXCorYm2Wh6HeEprQ8/RMZCEplgRa9l9rd7hs9GqICZBelTt2eUcu4O7fnwcdqeVek+ODIA++Su+VQuoESj50NZLgLGZ97TIzHQpJExZN3Ms46N/hggorKg/OIo4es6tYxvZq05H6ZAHEyGkQZ/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(346002)(136003)(366004)(396003)(376002)(66946007)(36756003)(86362001)(38100700001)(31696002)(66556008)(6486002)(8936002)(4326008)(26005)(66476007)(31686004)(478600001)(44832011)(5660300002)(186003)(316002)(6916009)(2616005)(2906002)(956004)(16576012)(53546011)(8676002)(107886003)(83380400001)(16526019)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aHk2cXRaM2wyNCtYWXZuZUZOWDN3blhtRFowNDJEVHVRSm9sOEYxdENJbk9T?= =?utf-8?B?RU4zYThRQkx6ZERQWHRRRGJrTSt6QUdDWjFSUnlMZW10RkNTbVFCa2w0aGJi?= =?utf-8?B?dGl0SnViQXFhL1IyMkFLc2lLMmpTUWdPdmlGV25sOXp1U0VCTHBkUmNmeU1x?= =?utf-8?B?S05NeTBvZlNuZnJFRVJVV2VJYnpGR0NkNkJiQ240WndxZ3dWeXhPTUY5K2k5?= =?utf-8?B?c0dNeGJzRXY4dFhZTlJVczUyNy9Delh1WEFMT2pZS09OaUxtYUg5eThmRkJy?= =?utf-8?B?T2xKMGNyc2tJbk5qM1RsM1V5cjhYMXgxaVZwNkpqaW1KaGFyTzNvckF6eU5t?= =?utf-8?B?L3g3SzlaL0RvYTQ1K3lMeW02VzJ2RDd3R2YrZlNDa1RIWW1abFpLWEkrT2Jl?= =?utf-8?B?RFFXREtxUXBxRnJ4ODFNeEhDU0lJd0JVbmNZM2tFNkk5SEN6cVo3b0lYdFgw?= =?utf-8?B?ODdQVEZSQnprS3AzNHhXL1R3dS9zZ1pNYWE0ZGgrRmU0eXVJd0JHMWtLeHFh?= =?utf-8?B?cWRQQ0hiUStqblJtOU1zSk5BZjJMV2VSMTlLUDFiM085TmVBZTBRanVmN2JU?= =?utf-8?B?UEg0Z0o3WDF4OVBaYW5Wb0JET3ppWVVidjJBQUVYSnNKRFF5bmZ0T3BUK0Nr?= =?utf-8?B?eGxrMW9vVWRVTFplbzM0cm15SzFMa2Z6YUMwVHpyNDJwQzFtZHR1Q3Mybmc0?= =?utf-8?B?V0ZmSXIrT1BuT0FZK3pSU3hqZ1JEeE9aTllNUzdDSmppdkNNZ2UyTUNWZysr?= =?utf-8?B?N0JXNTZHODhpUDcwZm5Va0E2UjI5YTRUNnNLRmpYU1lvS0dEYXVjeHJUNGVn?= =?utf-8?B?U1UydTNoTHBmRVlxbnlhcCtTZXlvd0FhcHJwdzU1WWY2eHJ1a2pkQmNLNjMz?= =?utf-8?B?RmNhMExhb3dETlRLL3Rab05iZ0lUZC82RGp1eWsvdTVlcm9sVWtHMWxvVkNj?= =?utf-8?B?dXlrWFB6RDB4MysrUXFnZkVzcnVnYm40S0M1RkJpKzZNNElWa1RSdmo1ZnFP?= =?utf-8?B?dDJvRmNsSEhidUtGZTMwcHFGN3czYzVkZjd3MmFGTXk1ZHlSQjE4NzhSb250?= =?utf-8?B?OEtyM1NIN2N6VjNNdjBvdGhzV0duMWhJakNSeXc5RTcvTVhTbFJ6ZjRiUUxJ?= =?utf-8?B?ajVZYk1YdnRTMmtLMUo0VXdXVk0vdUhwYi9VT2hvRUhadndjSlZVZjhPV2hR?= =?utf-8?B?cWl4RWhhK1BPeWt2VGVkSHN2VjUwSGF3RENTOEl1VTMwT05kRHJFT051SEY5?= =?utf-8?B?OGoxdlFHOXJWMmVwZzRHS1paQnhpeTRZQWczSkFLM3JrUjFaTUx0MWVnN3lu?= =?utf-8?B?N2l4NG1xUG5XYklIaEYrZU1WdG1YQ1daeFpBd09xM3I5Y25rTGw1YlE2dlpM?= =?utf-8?B?amVqZlFlWGlXTHA2UXFjWEU1VEVGOTludmtmRlkya3lidWovZmtmUFR0d0xi?= =?utf-8?B?MzZEK1lmQ3FwUk5mNHNZdXBKM1ptYXk2aDRtL2lvV2tTeWQ4N3FFdHFqazls?= =?utf-8?B?T3Zab3dlSUIyeEJmdWp6bGxHb3pGQm1vNjAzQTdTMUp4aGpVazNrN3NsNWJi?= =?utf-8?B?a3RtK0VrU0tUODdTSmtPV1pGTWFjZzhsUWJ1YVRDYmMzU1p2V0ptSUtpVmRr?= =?utf-8?B?OVF6YUg1VHkwaUhoNmkwaHBFVi9kZ2JJVDJqeU1SeXpQRXYwdUdLdWRMVDIw?= =?utf-8?B?dzVqMHh4ZVAyTDFKdDYvZ1VDU0lzUWJoYnpBOGxGQk42d3lyRUhlbUZYV0JE?= =?utf-8?Q?nyYVAoiXrbYtDyCbAnEzXc/7csi1cjS4EDyY/3V?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ded7e07-3524-4d6b-130c-08d8efe42032 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 23:17:14.5948 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U/xAFS76KwzIW+t1E53BKsFk3uHsWlrsNSZA4nFiU07QjBapEiRvTGq3K0JWEsfmERM4bvd+6pIGcDd+lv/H6cB9Yb8tsOCMXtis7AEvuXo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4242 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9934 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0 phishscore=0 adultscore=0 mlxscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103250172 X-Proofpoint-ORIG-GUID: T5jEK2I7wM-PXse9TnqSpRlt0LQ2Eo4A X-Proofpoint-GUID: T5jEK2I7wM-PXse9TnqSpRlt0LQ2Eo4A X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9934 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 clxscore=1015 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103250172 On 3/25/21 10:48 AM, Roger Pau Monné wrote: > On Wed, Mar 24, 2021 at 05:05:05PM -0400, Boris Ostrovsky wrote: >> Commit 8e76aef72820 ("x86/vpt: fix race when migrating timers between >> vCPUs") addressed XSA-336 by introducing a per-domain rwlock that was >> intended to protect periodic timer during VCPU migration. Since such >> migration is an infrequent event no performance impact was expected. >> >> Unfortunately this turned out not to be the case: on a fairly large >> guest (92 VCPUs) we've observed as much as 40% TPCC performance regression >> with some guest kernels. Further investigation pointed to pt_migrate >> read lock taken in pt_update_irq() as the largest contributor to this >> regression. With large number of VCPUs and large number of VMEXITs >> (from where pt_update_irq() is always called) the update of an atomic in >> read_lock() is thought to be the main cause. > Right, seems like a very plausible analysis. > > Since I suspect most (if not all?) pt_restore_timer() (called from the scheduler) also contributes a couple of percent. But yes. > of the performance regression is > from the read_lock in pt_update_irq I think we can remove that without > doing such a big change to the current locking logic, and instead > merging part of the logic that you detail in the cover letter without > moving to a per-timer lock. > >> Stephen Brennan examined the locking pattern and suggested using a >> per-timer lock instead. This lock will need to be held whenever there is >> a chance that pt->vcpu field may change (thus avoiding XSA-336 >> condition). >> >> Suggested-by: Stephen Brennan >> Signed-off-by: Boris Ostrovsky > So while I think this is indeed a working solution, I'm not convinced > we require a per-timer lock, I think we can find some middle ground > using both a per-domain rwlock and the more fine grained per-vcpu > lock. > > Basically for type 1 accesses (pt_vcpu_{un}lock) I think we can safely > drop the read_{un}lock call, Yes, if that's the case then current rwlock should be fine. > and remove the performance bottleneck > while slightly adjusting the functions that modify the per-vcpu timer > lists to take the per-vcpu locks when doing so. > > I've tried to convey that in the comments below, while also pointing > out some suitable places where comments can be added based on the text > from your cover letter. > > Overall this should result in a smaller patch that will be both easier > to review and argue in terms of inclusion into 4.15. Sure. Thanks for the review/suggestions. -boris From xen-devel-bounces@lists.xenproject.org Fri Mar 26 03:07:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 03:07:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101573.194404 (Exim 4.92) (envelope-from ) id 1lPcoC-00018o-7T; Fri, 26 Mar 2021 03:06:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101573.194404; Fri, 26 Mar 2021 03:06:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPcoC-00018f-2F; Fri, 26 Mar 2021 03:06:48 +0000 Received: by outflank-mailman (input) for mailman id 101573; Fri, 26 Mar 2021 03:06:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPcoA-00018X-SW; Fri, 26 Mar 2021 03:06:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPcoA-0004KD-J2; Fri, 26 Mar 2021 03:06:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPcoA-0004ou-AO; Fri, 26 Mar 2021 03:06:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPcoA-0005VE-9p; Fri, 26 Mar 2021 03:06:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=R4J+ZEgQsDUEMnWKd5V9RueY5otFjwADCdmKrGHG9PA=; b=PHiGvgI/k6UElMagaGCS3ZAin9 WYSaY57zQXu7jCPnLQtj8pWi5TQJFQxovS93LiCbEBQkoXbB4hdMSCNygj4v82Zj4bPGAzCg6Dyj8 fw7E5ES42MHb0Xq4DmC6t3jFnn+huNDW86Cm5csZc4lLwWLw9j2X6Ym6DapVNK3aYuNQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160400: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:heisenbug xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Fri, 26 Mar 2021 03:06:46 +0000 flight 160400 xen-4.12-testing real [real] flight 160430 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160400/ http://logs.test-lab.xenproject.org/osstest/logs/160430/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail in 160344 REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 160344 pass in 160400 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 160344 pass in 160400 test-amd64-amd64-xl-qcow2 18 guest-saverestore.2 fail pass in 160344 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 37 days Failing since 160128 2021-03-18 14:36:18 Z 7 days 7 attempts Testing same since 160150 2021-03-20 04:11:48 Z 5 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Mar 26 06:19:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 06:19:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101590.194431 (Exim 4.92) (envelope-from ) id 1lPfoV-0005VU-5r; Fri, 26 Mar 2021 06:19:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101590.194431; Fri, 26 Mar 2021 06:19:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPfoV-0005VN-2k; Fri, 26 Mar 2021 06:19:19 +0000 Received: by outflank-mailman (input) for mailman id 101590; Fri, 26 Mar 2021 06:19:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPfoT-0005VF-ER; Fri, 26 Mar 2021 06:19:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPfoT-0008Hy-5P; Fri, 26 Mar 2021 06:19:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPfoS-0006BA-Rl; Fri, 26 Mar 2021 06:19:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPfoS-0001XV-RI; Fri, 26 Mar 2021 06:19:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ezmB+ZqWM06zd+z2jhpAEUn3oCeCkc43sbELEG0GLS8=; b=XPmJBjlSUQ+F2vIeqeDBr1B2jr jISvH2Z42JV88vu3o1STNrB6RcS6q+JpTquCSSh77I+afKdE4/fFiC3Nn3r158VmI62qU6AovgVm1 bpdk2gfbMi0almeJEwErUWw3qseQeyxgk2ohCnxxR+BsbxFheArWcL+kZs4u84J/7FOc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160404: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=64d07691755e9aa6d3453ef3bb9109fde2b8da1e X-Osstest-Versions-That: xen=b9b3082002cac68726fb303e0abd2ff0113d4657 From: osstest service owner Date: Fri, 26 Mar 2021 06:19:16 +0000 flight 160404 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160404/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160376 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160376 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160376 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160376 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160376 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160376 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160376 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160376 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160376 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160376 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160376 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: xen 64d07691755e9aa6d3453ef3bb9109fde2b8da1e baseline version: xen b9b3082002cac68726fb303e0abd2ff0113d4657 Last test of basis 160376 2021-03-24 03:21:51 Z 2 days Testing same since 160404 2021-03-25 03:54:53 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ian Jackson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b9b3082002..64d0769175 64d07691755e9aa6d3453ef3bb9109fde2b8da1e -> master From xen-devel-bounces@lists.xenproject.org Fri Mar 26 07:43:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 07:43:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101603.194460 (Exim 4.92) (envelope-from ) id 1lPh81-0006cs-FF; Fri, 26 Mar 2021 07:43:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101603.194460; Fri, 26 Mar 2021 07:43:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPh81-0006cl-Bs; Fri, 26 Mar 2021 07:43:33 +0000 Received: by outflank-mailman (input) for mailman id 101603; Fri, 26 Mar 2021 07:43:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPh7z-0006cg-K2 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 07:43:31 +0000 Received: from mail-wr1-x433.google.com (unknown [2a00:1450:4864:20::433]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 051dd2b8-15b7-497b-802a-17b56823802d; Fri, 26 Mar 2021 07:43:30 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id b9so4641181wrt.8 for ; Fri, 26 Mar 2021 00:43:30 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:ad9a:ab78:5748:a7ec? ([2a00:23c5:5785:9a01:ad9a:ab78:5748:a7ec]) by smtp.gmail.com with ESMTPSA id m132sm9557446wmf.45.2021.03.26.00.43.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Mar 2021 00:43:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 051dd2b8-15b7-497b-802a-17b56823802d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=a17A+5+yJKiMuJiUq2dSyBoMg4TOq3jQE/Z9xINTJ5c=; b=Z9HbSvXlUmvTMwkRBUIEfiRT3Z+BtZ9AU9gcK3+P8yf3TIWRavmPdtkX7ms8kRTQt6 EdJXAOIWuMCjB2Mt443pDKyzavdYhUvIUiUzQWtmLXLZfYL4GXxGJqJwlEOzlo5OdWiS LZSUsVqih8h97I/lc2ygcaTumxG44dOYTdSD05m4uL1XpL/TErnmlI5QovPeZBJ9sjUi qnbjGieW81X8T4pr1tr24jBCN57xGKs9pqXH1wL4w1gbc9cB5rWNzwiNum6xGKGBSW56 ZulRGDgkDrzNmRrHJl+gksHQJMxyp/Z6A4nXN4F2Icv5JilShlUwbeIPWqomhnM5v3ea F39A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:cc:references :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=a17A+5+yJKiMuJiUq2dSyBoMg4TOq3jQE/Z9xINTJ5c=; b=oaEy4qGEaVCpm3J/HqaB4oK49iLYWzKJOfvHtSlMzMeQ5QGN6AOqc4ifLVlDfv+hpY G9jP1GjEQBQXta5rvj0S15pYE/qed0GC+KbV9NkmoP7OhGgq/7TqcwRPUR42CzhNyBgS VpNhiULAKqKn2FC0CRevGx1b5HV0OQ0Zwvag2fSS74ydpoBZC9R1Z9VhPSid4BDqVKL/ SWYXI7OfQ2g1967qMQze+xxWp1pbI5APMXbV2APU80drIzCJplVWV4BvIQ374+ykCQMe SRb1FQfLBTV7VnWswITL+IutVE3OA2Zp3wHcUxu5433lcm6ftBOomcVONR/Jzq0mmddB nk3g== X-Gm-Message-State: AOAM533x1mk34oR0F6x8kkBQsVV4ZA6VLKT4XFhYKHk2BO6xzYVmkljm AJ3bIjJpzgImcLGUKdEAzSM= X-Google-Smtp-Source: ABdhPJynFxHqBTILtp3MqD9HFuI4ni+e6LRTD0zM+pdMLFUmDbKsC8epdf8vejqPYqLi6UiwUVwyVA== X-Received: by 2002:adf:f150:: with SMTP id y16mr13054929wro.414.1616744609693; Fri, 26 Mar 2021 00:43:29 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , raphning@gmail.com, jgross@suse.com References: <20210325180607.13158-1-julien@xen.org> Message-ID: Date: Fri, 26 Mar 2021 07:43:27 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210325180607.13158-1-julien@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 25/03/2021 18:06, Julien Grall wrote: > From: Julien Grall > > Commit 13dd372834a4 removed the documentation for XS_RESUME, however > this command is still implemented (at least in C Xenstored) and used by > libxl when resuming a domain. > > So re-instate the documentation for the XS_RESUME. Take the opportunity > to update it as there is a user of the command. > > Fixes: 13dd372834a4 ("docs/designs: re-work the xenstore migration document...") > Signed-off-by: Julien Grall > > --- > > Cc: raphning@gmail.com > Cc: jgross@suse.com > Cc: paul@xen.org Reviewed-by: Paul Durrant > > Ian, would you still consider documentation update for 4.15? > > I looked at the implementation of domain_resume() in Xen, it doesn't > look like we can get away with XS_RESUME because Xen will not send > VIRQ_DOM_EXC on resume. > --- > docs/misc/xenstore.txt | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt > index 148074233001..334dc8b6fdf5 100644 > --- a/docs/misc/xenstore.txt > +++ b/docs/misc/xenstore.txt > @@ -294,6 +294,22 @@ IS_DOMAIN_INTRODUCED | T| or F| > ie, if INTRODUCE for the domain has not yet been followed by > domain destruction or explicit RELEASE. > > +RESUME | > + > + Arranges that @releaseDomain events will once more be > + generated when the domain becomes shut down. This might have > + to be used if a domain were to be shut down (generating one > + @releaseDomain) and then subsequently restarted, since the > + state-sensitive algorithm in xenstored will not otherwise send > + further watch event notifications if the domain were to be > + shut down again. > + > + This command will be issued in place such as resume because > + Xen will "shutdown" the domain on suspend. > + > + xenstored prevents the use of RESUME other than by dom0. > + > + > SET_TARGET || > Notifies xenstored that domain is targeting domain > . This grants domain full access to paths > From xen-devel-bounces@lists.xenproject.org Fri Mar 26 07:44:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 07:44:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101606.194472 (Exim 4.92) (envelope-from ) id 1lPh8q-0006ho-QC; Fri, 26 Mar 2021 07:44:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101606.194472; Fri, 26 Mar 2021 07:44:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPh8q-0006hh-Mj; Fri, 26 Mar 2021 07:44:24 +0000 Received: by outflank-mailman (input) for mailman id 101606; Fri, 26 Mar 2021 07:44:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPh8p-0006hc-GF for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 07:44:23 +0000 Received: from mail-wr1-x42e.google.com (unknown [2a00:1450:4864:20::42e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c1ed4b93-0441-42aa-86f2-35a95c009967; Fri, 26 Mar 2021 07:44:22 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id x16so4669109wrn.4 for ; Fri, 26 Mar 2021 00:44:22 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:ad9a:ab78:5748:a7ec? ([2a00:23c5:5785:9a01:ad9a:ab78:5748:a7ec]) by smtp.gmail.com with ESMTPSA id s12sm9786402wmj.28.2021.03.26.00.44.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Mar 2021 00:44:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1ed4b93-0441-42aa-86f2-35a95c009967 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qV0dFBPoDRaxg5YApXW9Y4x3fUbOMMX8COOiQIXJz50=; b=tLv7jTshahKmuWpzjTLh3FxafaoG0RoPOMmbVVnDSZmeZeZ4Fv16FHjA2TQr8AMzJb KseDGW3JhBMTVE6xEIQTwsrdtYWtLslryvMYeOd9fMn/NDW9X14E2oH8ThPmR0WzgcCU 02K1+7ex/n4TgZlq3xlEdHjnqA4pcUkO3x7534xcrpEaF/OWS3Oc8k0anDjOibozbc2L R/QqY/7+IFL8udhF/B++g02UFtnICeRak8RqEmj+KATxEdTs+duP6kEplVyLI2l44LhE usuN/O2ryP7ToLmGA5rcTncoM0deqD/0QhRyDxGkL7znBaMJsmwVNAP7+UbZh/gZ9Ajd n4VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:cc:references :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=qV0dFBPoDRaxg5YApXW9Y4x3fUbOMMX8COOiQIXJz50=; b=jaYZVamSZjvqeF8R5ue//smVbUB3yWmKeE/PLTIzpRFwMB1+w8eg2IYzt2dApw09Pg 6DKUWi0sLpTOimW1IO+zDN/PozsdQ6RJxNWVNC4Tg9+NN9lgEYk7bzKjE8JMlcG7qeBw 9wRkpMc+e3G8EWncQHK2zA/5xT8TEOvBkEG3tfsZhswEAP+/3yu689KYOY4yD1g0pC4L FEd8svZIfQ4S9VuP77jJKJ/YbqOzYZZfMybGUB2eU4yvAPPCOlG2Rs8w41uFav6xBOm8 1bNGHHLHqN8RPW4RGfcjZVJBCjEEKov3yDo8b6BBQVRPqIeP51gIh3x/vTG2FQJRgfBk NlLA== X-Gm-Message-State: AOAM5310q4ZFMhOhWZPBqprfOlaGDazm+UZFGNZ0i7G98uNz7nDxDHbF 5jKTY2sr7bWr59AlyMdOpulEVl6wmB0= X-Google-Smtp-Source: ABdhPJx44DsOktcxij2f4O8eW3DAfr9jew2klNZnEYR36G1kCwj4b8ooy2niHszsL/zQdFhnV1dTJA== X-Received: by 2002:adf:9043:: with SMTP id h61mr12889486wrh.216.1616744662109; Fri, 26 Mar 2021 00:44:22 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH 2/6] CHANGELOG.md: Add named PCI devices To: George Dunlap , xen-devel@lists.xenproject.org Cc: Ian Jackson References: <20210324164407.302062-1-george.dunlap@citrix.com> <20210324164407.302062-2-george.dunlap@citrix.com> Message-ID: <925330af-1432-a1e6-d7ab-4637613338d2@xen.org> Date: Fri, 26 Mar 2021 07:44:21 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210324164407.302062-2-george.dunlap@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 24/03/2021 16:44, George Dunlap wrote: > Signed-off-by: George Dunlap > --- > CC: Ian Jackson > CC: Paul Durrant Reviewed-by: Paul Durrant > --- > CHANGELOG.md | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 7f03e85bd7..8c89212f14 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - Renesas IPMMU-VMSA (Supported, not security supported; was Tech Preview) > - ARM SMMUv3 (Tech Preview) > - Intel Processor Trace support (Tech Preview) > + - Named PCI devices for xl/libxl > > ## Removed / support downgraded > > From xen-devel-bounces@lists.xenproject.org Fri Mar 26 07:48:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 07:48:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101612.194484 (Exim 4.92) (envelope-from ) id 1lPhCj-00079V-DP; Fri, 26 Mar 2021 07:48:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101612.194484; Fri, 26 Mar 2021 07:48:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPhCj-00079O-AC; Fri, 26 Mar 2021 07:48:25 +0000 Received: by outflank-mailman (input) for mailman id 101612; Fri, 26 Mar 2021 07:48:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPhCi-000790-A1 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 07:48:24 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e30644c9-fc71-46e2-b204-b4c30cae5538; Fri, 26 Mar 2021 07:48:23 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 93DD5AD8D; Fri, 26 Mar 2021 07:48:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e30644c9-fc71-46e2-b204-b4c30cae5538 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616744902; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yAgln7FYxkX6fCwdyVACav6m4nzfQzV3nSffvMFUyik=; b=hojvaHjEmP6M7FmtZxe17saHad0MAPwBF+Ht/WWz8LMQ2YXYSYgeD0RzU0qtS1ogtZvgSN xea//YEL380a2yIu/QyZW8t7C0JHVsfTckTHHJ25RXGUsXH3/x+nfrgV4GL833cCEmQVPm 518/eCkfUponnlY1mZNiGUFY+3CXmrc= Subject: Re: [PATCH for-4.15?] docs/design: Update xenstore-migration.md To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , raphning@gmail.com, edvin.torok@citrix.com References: <20210325111255.16330-1-julien@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <680ae414-cfd2-aba5-c88b-df94b71b49b4@suse.com> Date: Fri, 26 Mar 2021 08:48:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210325111255.16330-1-julien@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CuCItKUWYSKodzkDuVepHOqyXSbSyCa3l" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CuCItKUWYSKodzkDuVepHOqyXSbSyCa3l Content-Type: multipart/mixed; boundary="bu3yIOYFDMEv6oLBhpLOIroDL50lCIncA"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , raphning@gmail.com, edvin.torok@citrix.com Message-ID: <680ae414-cfd2-aba5-c88b-df94b71b49b4@suse.com> Subject: Re: [PATCH for-4.15?] docs/design: Update xenstore-migration.md References: <20210325111255.16330-1-julien@xen.org> In-Reply-To: <20210325111255.16330-1-julien@xen.org> --bu3yIOYFDMEv6oLBhpLOIroDL50lCIncA Content-Type: multipart/mixed; boundary="------------0773380745A4F761A8A503E9" Content-Language: en-US This is a multi-part message in MIME format. --------------0773380745A4F761A8A503E9 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 25.03.21 12:12, Julien Grall wrote: > From: Julien Grall >=20 > It is not very clear the shared page adddress is not contained in the > connection record. Additionally, it is misleading to say the grant > will always point to the share paged as a domain is free to revoke the > permission. The restore code would need to make sure it doesn't > fail/crash if this is happening. >=20 > The sentence is now replaced with a paragraph explaining why the GFN is= > not preserved and that the grant is not guarantee to exist during > restore. >=20 > Take the opportunity to replace "code" with "node" when description the= > permission. >=20 > Reported-by: Raphael Ning > Signed-off-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------0773380745A4F761A8A503E9 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0773380745A4F761A8A503E9-- --bu3yIOYFDMEv6oLBhpLOIroDL50lCIncA-- --CuCItKUWYSKodzkDuVepHOqyXSbSyCa3l Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBdkcUFAwAAAAAACgkQsN6d1ii/Ey+J Tgf9Gdf1vNWjBOxvqka9FADOKVhcWsDPEKQH5wGpyNv2GSkHC4s+qq3gSVWi8Lfly2lGkSFZxMOS lpHMTz6NkhVGZV0AhRTDBYrr2wFNG4kQlr0HhGTxgv0VE4xFQre8g+L8nAcT6isF5fwce27X2v5S Q+26AEL/6n3tnkH/tdIZxDWft9uPCzRVSaKpeNc2zNP4jpk6zAwMkRf/Glk+bDT+UyrFrzMIytpq NxVoKdIhleELZ+Xt/orJGSqH7m3Q8fCkcMF/DoOWBUUguSIyxKECluqffF1qddsx2QmkrFAfTIJG q7NYFR0uNphXbrhCc8kw9OpUjWK1hi86OebnWRvznQ== =1Qk3 -----END PGP SIGNATURE----- --CuCItKUWYSKodzkDuVepHOqyXSbSyCa3l-- From xen-devel-bounces@lists.xenproject.org Fri Mar 26 07:49:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 07:49:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101615.194496 (Exim 4.92) (envelope-from ) id 1lPhDe-0007FQ-Ne; Fri, 26 Mar 2021 07:49:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101615.194496; Fri, 26 Mar 2021 07:49:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPhDe-0007FJ-Kd; Fri, 26 Mar 2021 07:49:22 +0000 Received: by outflank-mailman (input) for mailman id 101615; Fri, 26 Mar 2021 07:49:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPhDc-0007FD-MK for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 07:49:20 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ef035bb3-f850-42e3-9ddf-35eac9c72a3e; Fri, 26 Mar 2021 07:49:19 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1676BADF1; Fri, 26 Mar 2021 07:49:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef035bb3-f850-42e3-9ddf-35eac9c72a3e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616744959; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tx8pHdfaHZgJECaTkkUpSJfSjQ3fgHbIeajI5YrwFJg=; b=ajHm/zJHFkBZTZReZsyjWdb+EMnt2gCszHPn1odl36VvaGy1b0qshtwVaY6vSf0f3VeDBQ 5WwcKx864jXYb3tFbGDCx88Jx0+yuMlupOxoUpNf9bYwD3OzloJDnTkalP4L7LZLE4s/NV NIhm/Cpu6oKBm2/E7HHHXnvdJIwyAj8= Subject: Re: [PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , raphning@gmail.com, paul@xen.org References: <20210325180607.13158-1-julien@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <615b1f45-c64a-0917-ab4c-f0bb3a9b80fd@suse.com> Date: Fri, 26 Mar 2021 08:49:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210325180607.13158-1-julien@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fblZicCrADbV6gtcuU7krE5wDEmnNjhoK" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fblZicCrADbV6gtcuU7krE5wDEmnNjhoK Content-Type: multipart/mixed; boundary="qEAk6Pvvaak7LVOsnMGf5NL2V6cpocn63"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , raphning@gmail.com, paul@xen.org Message-ID: <615b1f45-c64a-0917-ab4c-f0bb3a9b80fd@suse.com> Subject: Re: [PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME References: <20210325180607.13158-1-julien@xen.org> In-Reply-To: <20210325180607.13158-1-julien@xen.org> --qEAk6Pvvaak7LVOsnMGf5NL2V6cpocn63 Content-Type: multipart/mixed; boundary="------------0CFEA9DE27D287AA55357961" Content-Language: en-US This is a multi-part message in MIME format. --------------0CFEA9DE27D287AA55357961 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 25.03.21 19:06, Julien Grall wrote: > From: Julien Grall >=20 > Commit 13dd372834a4 removed the documentation for XS_RESUME, however > this command is still implemented (at least in C Xenstored) and used by= > libxl when resuming a domain. >=20 > So re-instate the documentation for the XS_RESUME. Take the opportunity= > to update it as there is a user of the command. >=20 > Fixes: 13dd372834a4 ("docs/designs: re-work the xenstore migration docu= ment...") > Signed-off-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------0CFEA9DE27D287AA55357961 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0CFEA9DE27D287AA55357961-- --qEAk6Pvvaak7LVOsnMGf5NL2V6cpocn63-- --fblZicCrADbV6gtcuU7krE5wDEmnNjhoK Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBdkf4FAwAAAAAACgkQsN6d1ii/Ey/H 2QgAmDvRghRoFA8WEvQMpX23VVeRqmGJrDsXc5FzPGEojaiMOVE2A69JREYiJ0SZJTlgj+Plzy9h iTlhzxgUZNccrx3HQNZePqnxDNf102mqJXaWsTnz2ju0iG5Lc8a2yz6qi0flmgO8j2EmsicQXa95 AFOpoE28DWsddD7yGR3BaXDFoZtB4rbZDlMvGEVvqT+NkHwKDDnnJnjKeBhxaL3LOAaxjTPIwgtD ksK834GoNpRJB2Xq25Rqlps/jUpbVum/P7eg1YKLQs272XuO11P03Uu9YDNTs7BZRMw9dWrkZ2ZT OLulVSfN34dXRYdti+BS8oDR7iXUY/A/Zz1bFCh93Q== =5PXi -----END PGP SIGNATURE----- --fblZicCrADbV6gtcuU7krE5wDEmnNjhoK-- From xen-devel-bounces@lists.xenproject.org Fri Mar 26 07:56:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 07:56:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101625.194514 (Exim 4.92) (envelope-from ) id 1lPhKr-0008CQ-KK; Fri, 26 Mar 2021 07:56:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101625.194514; Fri, 26 Mar 2021 07:56:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPhKr-0008CJ-HS; Fri, 26 Mar 2021 07:56:49 +0000 Received: by outflank-mailman (input) for mailman id 101625; Fri, 26 Mar 2021 07:56:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPhKq-0008CE-8z for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 07:56:48 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b4b2e2e4-b093-4a79-b5ac-4e3094d618b1; Fri, 26 Mar 2021 07:56:47 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 94976ADEF; Fri, 26 Mar 2021 07:56:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4b2e2e4-b093-4a79-b5ac-4e3094d618b1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616745406; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lJPcveMA77tb9BZN4aofonkxyFlq6nWgUh62MG8UD7k=; b=Tabmm2ahAD5+nJxyVY6RoU+Zyafhwpn1dbNvqS88KDe6xRG+fvMVapk6idUFEU1Aac/zFR 9P5knCQIwQsM0YaMtQlO85DNQFM065RhFdsHXBhmNbYiTnyZzMZcEZKz5unyaToQabDOpn +2G2swK+6tusg4Bq9bsb2TxuDHVdUHU= Subject: Re: [PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Ian Jackson , Wei Liu References: <20210325114243.12284-1-julien@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <03d11251-4e1b-ba1d-8724-0867fbe6345b@suse.com> Date: Fri, 26 Mar 2021 08:56:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210325114243.12284-1-julien@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="b7pZMXpLlUbJC6EKsikwbzOvOnHsLmzHa" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --b7pZMXpLlUbJC6EKsikwbzOvOnHsLmzHa Content-Type: multipart/mixed; boundary="fMMyCkA5LRYf54OMjrZB50pqNXPBcXyyb"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Ian Jackson , Wei Liu Message-ID: <03d11251-4e1b-ba1d-8724-0867fbe6345b@suse.com> Subject: Re: [PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API References: <20210325114243.12284-1-julien@xen.org> In-Reply-To: <20210325114243.12284-1-julien@xen.org> --fMMyCkA5LRYf54OMjrZB50pqNXPBcXyyb Content-Type: multipart/mixed; boundary="------------CA65D90FBA23F3443C719D0F" Content-Language: en-US This is a multi-part message in MIME format. --------------CA65D90FBA23F3443C719D0F Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 25.03.21 12:42, Julien Grall wrote: > From: Julien Grall >=20 > The last use of the compat foreign API was dropped in commit > 38eeb3864de4 "tools/xenstored: Drop mapping of the ring via foreign > map". >=20 > Therefore, we don't need to define XC_WANT_COMPAT_MAP_FOREIGN_API. >=20 > Signed-off-by: Julien Grall Reviewed-by: Juergen Gross Juergen --------------CA65D90FBA23F3443C719D0F Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------CA65D90FBA23F3443C719D0F-- --fMMyCkA5LRYf54OMjrZB50pqNXPBcXyyb-- --b7pZMXpLlUbJC6EKsikwbzOvOnHsLmzHa Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBdk70FAwAAAAAACgkQsN6d1ii/Ey+j Zwf/RVKISzhgZzgXimfjkFV2QbHOQJCQpEl5CZkc4Daev/CJgij57cIlwjggpP2lmyQKITipGD4n DyCFnLp13d+HrR3LTPMs4AlHXOCsYGCM/n2G5eoiZXoJ9Wu7VXJJlVtFc8sAangZbF8fYz+iRfhn HE+yteqb0QFD2w89q3FopfuuKaH5OEQcVPr5eAwq5E0YsHsyk+N4EM1QPNNQS6VptWanMwnVRX6k S+nbjZUzdL0QpxlFYyflVglj5w4vu7YyZl/dl3drUk3LEgzvAOoetgVRQrugPrhFCC8c9ADQoE2L DSiaCq1LOIUzBxfzv8Kfe0nMlTKA3f+I6pddL9k0Sw== =/TpU -----END PGP SIGNATURE----- --b7pZMXpLlUbJC6EKsikwbzOvOnHsLmzHa-- From xen-devel-bounces@lists.xenproject.org Fri Mar 26 09:33:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 09:33:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101663.194554 (Exim 4.92) (envelope-from ) id 1lPiqS-0002e2-JV; Fri, 26 Mar 2021 09:33:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101663.194554; Fri, 26 Mar 2021 09:33:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPiqS-0002dv-GR; Fri, 26 Mar 2021 09:33:32 +0000 Received: by outflank-mailman (input) for mailman id 101663; Fri, 26 Mar 2021 09:33:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPiqR-0002dq-72 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 09:33:31 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 41a4854d-1a39-46e7-a704-99b5bcf62e0b; Fri, 26 Mar 2021 09:33:30 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C097DAB5F; Fri, 26 Mar 2021 09:33:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41a4854d-1a39-46e7-a704-99b5bcf62e0b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616751209; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Woz2ZP2UZ+KC+bQwDWj3oWwbtAZsCgGdFrKDorl53bg=; b=V2QPlv+bpRu6XtFgoCPTm7kQmQu2477FK9sz0Rz1nGY2rc2FgsJTryaqDFdxBi1Bb0EH8N zkuqXZVHqgEJaUTk5wyX/0yYWHdhMbJvoK85RqhUvtKpcrVMVc9LSrey+3y/F4ws1zlqPF SW5jl4OBzAFZjleQUBwhpJPE5hw11DI= Subject: Re: [PATCH for-4.15] changelog: note MSR access change To: Roger Pau Monne Cc: Ian Jackson , Community Manager , xen-devel@lists.xenproject.org References: <20210325162032.81348-1-roger.pau@citrix.com> From: Jan Beulich Message-ID: <40e44bdf-521b-f7b7-2ded-c22abc45efd8@suse.com> Date: Fri, 26 Mar 2021 10:33:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210325162032.81348-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 25.03.2021 17:20, Roger Pau Monne wrote: > The change to deny all accesses to MSRs indexes not explicitly handled > prevents leaking unwanted data into guests. > > Signed-off-by: Roger Pau Monné In case it matters: Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 26 09:51:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 09:51:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101666.194566 (Exim 4.92) (envelope-from ) id 1lPj7u-0004su-4g; Fri, 26 Mar 2021 09:51:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101666.194566; Fri, 26 Mar 2021 09:51:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPj7u-0004sn-1a; Fri, 26 Mar 2021 09:51:34 +0000 Received: by outflank-mailman (input) for mailman id 101666; Fri, 26 Mar 2021 09:51:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPj7s-0004si-Nj for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 09:51:32 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3ea8c81e-d997-46f4-9163-286d09254eee; Fri, 26 Mar 2021 09:51:31 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5AB86AB8A; Fri, 26 Mar 2021 09:51:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ea8c81e-d997-46f4-9163-286d09254eee X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616752290; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9IvZABonwQA8TGKk4D4h6Qkucq4GlpikUjv4HoZ0AQw=; b=BTnkNtgbSmIh83Ze35IxldUhB+KnwN4BdEqyd4fKAkNpgB1onmBab4Gd9EkAC2IjSHOZVC mGHEG403plBz/DLEya/8KccurTPBvKzKqa40I40UzKjqMlm8fBWbwzhKbswaYOO7K9/TTK vk5VeHGA9wtJkR2MSo0NilICHCIGTo8= Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , Xen-devel References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: Date: Fri, 26 Mar 2021 10:51:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210325172132.14980-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 25.03.2021 18:21, Andrew Cooper wrote: > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -1274,9 +1274,42 @@ supported. See docs/misc/arm/big.LITTLE.txt for more information. > When the hmp-unsafe option is disabled (default), CPUs that are not > identical to the boot CPU will be parked and not used by Xen. > > +### hpet (x86) > + = List of [ | broadcast= | legacy-replacement= ] > + > + Applicability: x86 If this is the more modern form to express this information, then the (x86) I did put on the sub-title line should imo be dropped. > +Controls Xen's use of the system's High Precision Event Timer. By default, > +Xen will use an HPET when available and not subject to errata. Use of the > +HPET can be disabled by specifying `hpet=0`. > + > + * The `broadcast` boolean is disabled by default, but forces Xen to keep > + using the broadcast for CPUs in deep C-states even when an RTC interrupt is > + enabled. This then also affects raising of the RTC interrupt. > + > + * The `legacy-replacement` boolean allows for control over whether Legacy > + Replacement mode is enabled. > + > + Legacy Replacement mode is intended for hardware which does not have an > + 8025 PIT, and allows the HPET to be configured into a compatible mode. 8254 ? > @@ -1922,14 +1924,38 @@ static void __init check_timer(void) > vector, apic1, pin1, apic2, pin2); > > if (pin1 != -1) { > + bool hpet_changed = false; > + > /* > * Ok, does IRQ0 through the IOAPIC work? > */ > unmask_IO_APIC_irq(irq_to_desc(0)); > + retry_ioapic_pin: > if (timer_irq_works()) { > local_irq_restore(flags); > return; > } > + > + /* > + * Intel chipsets from Skylake/ApolloLake onwards can statically clock > + * gate the 8259 PIT. This option is enabled by default in slightly 8254? > + * later systems, as turning the PIT off is a prerequisite to entering > + * the C11 power saving state. > + * > + * Xen currently depends on the legacy timer interrupt being active > + * while IRQ routing is configured. > + * > + * If the user hasn't made an explicit option, attempt to reconfigure s/option/choice/ or s/made/given/? > + * the HPET into legacy mode to re-establish the timer interrupt. > + */ > + if ( opt_hpet_legacy_replacement < 0 && > + !hpet_changed && hpet_enable_legacy_replacement_mode() ) > + { > + printk(XENLOG_ERR "..no 8254 timer found - trying HPET Legacy Replacement Mode\n"); > + hpet_changed = true; > + goto retry_ioapic_pin; > + } > + > clear_IO_APIC_pin(apic1, pin1); > printk(KERN_ERR "..MP-BIOS bug: 8254 timer not connected to " > "IO-APIC\n"); As mentioned on irc already, I'm somewhat concerned by doing this change first (and also not undoing it if it didn't work). An AMD Turion based laptop I was using many years ago required one of the other fallbacks to be engaged, and hence I'd expect certain other (old?) systems to be similarly affected. Sadly (for the purposes here) I don't have this laptop anymore, so wouldn't be able to verify whether the above actually breaks there. As a minor remark, I find the "goto" based approach not very nice (we've been generally saying we consider "goto" okay largely for simplification of error handling, to avoid having many [partly] redundant function exit paths), but I can see how using for() or while() or do/while() would make the code larger and require deeper indentation. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 26 09:59:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 09:59:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101672.194578 (Exim 4.92) (envelope-from ) id 1lPjFf-0005Ls-2M; Fri, 26 Mar 2021 09:59:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101672.194578; Fri, 26 Mar 2021 09:59:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPjFe-0005Ll-VV; Fri, 26 Mar 2021 09:59:34 +0000 Received: by outflank-mailman (input) for mailman id 101672; Fri, 26 Mar 2021 09:59:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPjFd-0005Lg-8e for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 09:59:33 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 29738bd0-6755-4c67-aeee-358015ab20e9; Fri, 26 Mar 2021 09:59:32 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 58033AB5F; Fri, 26 Mar 2021 09:59:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29738bd0-6755-4c67-aeee-358015ab20e9 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616752771; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EefDx3s95a3NNDv079RRGFdwcL8W8EVFMp36n+zAiKw=; b=oSn3g2UVSkWI87sEwy3eYprfIYZaGtM24r1sTzjCZQe3NEOWM71Mpko3pgL2wsvt5mtI7a +nXNd9LNtjtrnAvtk/3DnXPVgQfoxO2fI7U6PZvgUzc6tMMoizDaV6juKKMuEohmo03mw8 DwqCk8soLr7yGSAaS/QXeEq7rC9c2Hs= Subject: Re: [PATCH 1/2] x86/hpet: Factor hpet_enable_legacy_replacement_mode() out of hpet_setup() To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , Xen-devel References: <20210325165224.10306-1-andrew.cooper3@citrix.com> <20210325165224.10306-2-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <3ef41d04-cff0-5828-8373-af5f42a4f857@suse.com> Date: Fri, 26 Mar 2021 10:59:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210325165224.10306-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 25.03.2021 17:52, Andrew Cooper wrote: > ... in preparation to introduce a second caller. > > No functional change. > > Signed-off-by: Andrew Cooper Generally Reviewed-by: Jan Beulich but I think there's one small code change needed plus I have two nits (and I expect that this change wouldn't be committed without patch 2, as making the function non-static isn't warranted otherwise): > --- a/xen/arch/x86/hpet.c > +++ b/xen/arch/x86/hpet.c > @@ -754,11 +754,70 @@ int hpet_legacy_irq_tick(void) > } > > static u32 *hpet_boot_cfg; > +static u64 __initdata hpet_rate; Use uint64_t as you move this here? > +bool __init hpet_enable_legacy_replacement_mode(void) > +{ > + unsigned int id, cfg, c0_cfg, ticks, count; > + > + if ( !hpet_rate || I think you need to also honor opt_hpet here. > + !((id = hpet_read32(HPET_ID)) & HPET_ID_LEGSUP) || I don't think I see a need for the assignment and hence the local variable. Dropping it would make the code easier to read imo. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 26 10:54:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 10:54:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101680.194596 (Exim 4.92) (envelope-from ) id 1lPk66-00037c-Cm; Fri, 26 Mar 2021 10:53:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101680.194596; Fri, 26 Mar 2021 10:53:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPk66-00037V-8y; Fri, 26 Mar 2021 10:53:46 +0000 Received: by outflank-mailman (input) for mailman id 101680; Fri, 26 Mar 2021 10:53:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPk65-00037Q-4h for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 10:53:45 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 26ee71e4-b124-491c-b293-9e6e1dfe8183; Fri, 26 Mar 2021 10:53:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26ee71e4-b124-491c-b293-9e6e1dfe8183 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616756023; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=aRqIjrcKlHKIaxRqet02qxVliAwPPtnrLbdQb7iZrsw=; b=LTj6dNCvB1yQkha2wBdZ8VOzxu3rwZW2/Dqonh71vsAugzVFMwVH6nSN 5ybyt+MPnjfkH7qpcVQ405GOa8tPcCUi5tbwX9Bf53qErUfArPFFQJK3e yUoq58bKvg8+g+1hs9a3IospmUz2rkKsvYVgPzBhkSqF/CNlWAKLulMJv M=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: BPMC3QQWLI6C+luD8ogDkuzYm2uOn0YjE2alDh6A/QqYLKyyG7n+cPXF2JPedmJByDVsBKzX56 cZi5VemoUqOaWLUzgzE8YfeaY2s2O3/QGaDaAcGX7nVp3oZFge314CSmfyBL2i+CAo62gLCvBN Q7SKZHs4w566LBS6VptAQg2UzBTK+m4QNLCMJdLXFh790zrT2vbDK2WMpHrl3DhBYpYvw1djUT 8ECipVNK7LzzCQoHbwl+EZwVtfuOTrGlLf8NVIosLStnvtL9LMsuj38oHzG6pZglFLpyn2JImD wTc= X-SBRS: 5.2 X-MesageID: 41648888 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:swwzOaOGpqkLm8BcT27w55DYdL4zR+YMi2QD/3taDTRIb82VkN 2vlvwH1RnyzA0cQm0khMroAse9aFvm39pQ7ZMKNbmvGDPntmyhMZ144eLZrAHIMxbVstRQ3a IIScRDIfXtEFl3itv76gGkE9AmhOKK6rysmP229RdQZCtBApsQiDtRIACdD0FwWU1iDZ02CJ KT6qN81kSdUF4Qadm2AWRAYvPKoMfFmImjTRkNARMm7wfmt0LW1JfRFR+E0hACFw5e2LtKyx m4ryXVxIWG98u6xBjVynPJ4/1t+efJ59NfCKW3+7MoAxr2jALAXvUZZ5Sju3QPrPir+BIWlr D30modFuBSz1+UQW2vuxvq3GDboUQTwlvv00WRj3emgeGRfkNDN+N7iYhUcgTU5iMb1bkWus 87vBP6xu5qJCjNkyjn69/DWwsCrDvTnVMYnfMOlHsaaIMCadZq3P8i1XlIG5QNFj+S0vFDLM BSCqjnlZJrWG+BY2uclmdix8HEZAVIIj62BmIGusCTzgFMmmF4w0Yy1KUk7wc93aN4ZJ9e6+ veNKN00JlIU88NdKp4QNwMWM2tFwX2MFzxGVPXBW6iOLAMOnrLpZKyyLIp5NuycJhN6Jcpgp zOXH5RqGZaQTOuNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dQWeVVEHiaKb0rciK/yef8 z2FINdAvflI2erM51OxRfCV55bLmRbeNEJu+w8R0mFrqvwW87Xn92eVMyWCKvmED4iVG+6KG AERiLPKMJJ6V3udWT/hDTXRnPxam3y9Z99C8Hhjqwu4blIErcJnhkeiFy/6M3OAyZFqLYKcE x3J66isq7TnxjwwU/4q0FSfjZNBEdc57vtF1lQoxURDk/yebEf//GWeWVY2mq7NgZyJvmmVj J3lhBSw+aaPpaQzSctB5aMKWSBlUYeo3qMUtM6lrCc49zmPrc1FIwvVqA0NQijLW00pS9a7E N4LCMUTE7WET3jzY+/ioYPOe3Zf95gxCGxIcBVrnrbnV6Gpd4mQ0YaWzLGa7/TvS8eAx5vwn Fh+a4Wh7SN3Ry1L3Ekveg+OFpQLFiMDKl+FwSDboVMkrXNcAV9JF363ACyulUWQC7H5k8Sjm vuIWmxdevQClRQgHxez53n6Uh5bGmbYkJ2ZE1rqIEVLxWyhl9DlcuwIoaj2WqYbVUPhtsQNz zIehM+CAJjzdLf7m/ZpB+yUVEdgrk+NO3UC7ouN4zJ0nS2MYuSiOUtBPlP5qtoM9jor84GWe +SYBWuMTv9Eu8lsjbl/koNCW1Rkj0JgPno0Brq4CyEx3Y5G+PVO0kjaLcBId2QhlKUD8qg4d Fct5YSsuSxOGmqNYLD5qHTcjJZKhTc5USxVPolrJhIvaQ08Jt/dqOrJwfg5TVi5lEZKsyxqW Y1BIJcy5rFMpV0f8MTdzlCl2BZ3uinHQ8OiEjOHuQ6fVsRlHfVMNOC3qrQpdMUczq8jTq1HW PazjZU8PjEVRaSzLI2C6o/JmJNdUg3gU4Std+qRsn1CA+wcftE80f/GnihcKVFQKztI8Rdkj 9Kp/WJlfSQbSz2xUT5uiZ6OLtH9yKCTdmpCAyBXc5O/NrSAyXCvoKapOqyhizwUz21dgAxgp BEb1UZaoB7sQYZ5bdHmRSae+jQuUIqk1xX/DFhmBrM4+GdkRbmNHADFxbYjJVQVSRUKV6Sg6 3+gLOl6Eg= X-IronPort-AV: E=Sophos;i="5.81,280,1610427600"; d="scan'208";a="41648888" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GUjeWDBpsU7ZnEtJvLj948g93KZVZeo+wYpWX5lY63ddr2cHJV7rGmB6QmKD/pQ1zRn+HQHGBQGkFu/WFE6w0vNminyX2FPsxk6yTq+URQO9RE5NJxxiWsWFbC3Px86XrJU0YVUh1LX80DnmEX1pRTeVL20a1NyX2yys4gIdIpotEyqUiPvNXrAspiUTlM0xAE16gTYvzCgkmO2OGhH5KVCyPu7F+nvncJTgt1t8q4A7C4fQo15E/HlpcsqMn94oeHJfOOsBrEvps4oKjNKKeUhi2zolizAt0iyCQPMOSWARf4qRAOZ6MihXxiasFlHIpKfpvb5P5b45XIzsCKGrZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PkC704RI6VF980EysnwaIyUcwhxPvWjxLhllc3NFAtM=; b=aWWSk4UZ6hj6xjc1HBYPQKRIHCuZw1BYLdwAHz0+8DMzYGJkaWkXdfgkSoXsI6s+05CYJegPHDmjFKv7KicvgQQjRtphp5UTn9W5Hbsn3/SuNpCJ+oCS5JrDyT2Wd1LZY+mg1w0JO0ruX5Ul2gIOaa9vIpY6PjbKbcOSnEOSqaUMAwQsNEtxZYR1K4xsELqmdUTatIeerSGrK4g2cHcTLXL2XZ75Jg2S1oXmp0eNqRic/urSG0yBv+gK8/k7nGdiWFwGpVDuD9NQnC2VyFIUXHxij+IEXQez18AejJozoOYlCgGBQaupx//kQJh6oqCQRu2AguRYll1BxQhat7hy9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PkC704RI6VF980EysnwaIyUcwhxPvWjxLhllc3NFAtM=; b=seewK0U4mitMn4rj4o9mnFTw+sSpAd+9ngPxooSNI7Q4KcT7i7XBqLOrViP5RhfYe1gBieAWVj3UsYhH0ag0kMQyvkx+HGvegbQ8QctEPeVTXMVun8j8cGHv7g1JQlW7vcLJbZe70azNyTj6xgyhJV7m87jBslYhqnCM5JslXto= Subject: Re: [PATCH 1/2] x86/hpet: Factor hpet_enable_legacy_replacement_mode() out of hpet_setup() To: Jan Beulich CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , Xen-devel References: <20210325165224.10306-1-andrew.cooper3@citrix.com> <20210325165224.10306-2-andrew.cooper3@citrix.com> <3ef41d04-cff0-5828-8373-af5f42a4f857@suse.com> From: Andrew Cooper Message-ID: Date: Fri, 26 Mar 2021 10:53:33 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <3ef41d04-cff0-5828-8373-af5f42a4f857@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0222.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::11) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9d8a13fd-e3ea-4883-0288-08d8f0456a1e X-MS-TrafficTypeDiagnostic: BN6PR03MB3265: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KN3leXUQFGGFxH9nkoJpQmPIazIyj4m7VVnZ+Un3n7kH9bIkEnjepLUQfsHLhm4IA3JSqmXEWEgzBBUdVe4clQD0fzlYIaNI8drUaEAG7RkztdoUXzD0Eb5q258yfkbhRuJ7ZhRxQmo4o2dndwDE7rXqsWtcDBISuyvwj0VIL7SRpFxTje5Y7ZfmQATN5iVKBIUY391A6O2pb7/FSLqv76XSGVI0kNgnZ9xJRxGzwDo/L4eZZ2MnlD3Pk9nwz78jVGPOn20PQ6bZBe9AJur/excLj3PRnHttt3aSd85bYVyoLvwA2uSD9qTH36xhJ7Mqyu0m7+20lsnTLKw9YUsvXPoNIkc9pPN0OKNF4xN4s1EYr4mhCckRIY0+ju2FmfZuD/ms/wEqoIJnfMQJsQOcbtyngKhrqycf6KLeLSIu8cFbF4k5w/MWIXTx6mUH9G3EXR45XSKYJS4TLU3IE3hvpRPCFgkg56fv/eCtmb8JEEXE2nuM2LNb4aoD14R8cyuvyqW+6Ym/7NWRDMApwZKgXrUVJAFqVqOqu+NupatXGMbezJNQEv8mU+5UQ0rlFIvFFmOtio+4Yfr5m9taQUBWgEGgTpc1EjPvGgVlIr+crHo35yp8f+rD6YKa6406xfCMWR7V69Iov5u9B+m6EgIA7j6LvAjqQWQYU/dc+TtUeU4dP7rego7QGrlW/d1lJFsqTyX+OyfwB1FT/fJb7pBn3JKvjqo5PFoXLYBERBwMS7U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(346002)(366004)(396003)(376002)(53546011)(8676002)(956004)(186003)(4326008)(6666004)(31686004)(2616005)(16526019)(86362001)(26005)(36756003)(16576012)(83380400001)(316002)(6486002)(38100700001)(54906003)(66476007)(66556008)(66946007)(6916009)(478600001)(5660300002)(8936002)(2906002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dlBDSmJ2WElNZDZUYUtadUJiNFlYcG15bHlnQjI2SHR3azArSWZ1aUhaTVBa?= =?utf-8?B?MkRtOUdmYWsxRjZtN2FjaVJZS1J3VEFUZkpzSFBDVjg0YUdzZk5NNGNxQU1y?= =?utf-8?B?cEhMZERIOGk2YnE2Yzh4RUtHNlZGLy9DUDkzUHRPUEV3bnM0dUJJZ2tLK3R2?= =?utf-8?B?SmlRVktBaU15ODVSb1QxemRvMHlBVkRJT3ZFU2xlZkR1WmdHQXRCNlJCK2ly?= =?utf-8?B?VnZ4cWFVbWQ2V2lCMW5YOG9ZUG1SZnd6aHp0UUNtcENMWmlyZ1NQSU45SndP?= =?utf-8?B?ZGxqMi9wMy9QK0ZwN28zNFUzTURMcStFVi9FOEZNMllQYmh6TGdxaHVKbGNI?= =?utf-8?B?L013U3pENU1ROFlCY0V0QzRuVlNhb2FidnlRdkZFa2s2ZXNrb1R2ZzBvNXFL?= =?utf-8?B?aG1pMWdhT3ZjZmpmUnRQUStWdEpnWXN4WWNpdU1lZnlCb2FTNUo3UlZNNlFT?= =?utf-8?B?OFNlU3JuZzVBMkNTL0dhQVRDczk0UXg1Vk43cXNoMWlueGNweWFhSlBQV0lB?= =?utf-8?B?TTRIdnB1NGpUSXN4Wk1JZUJSQVRnOHJWTForTnJQZXh4RCtpVStCR2MvYmU5?= =?utf-8?B?TTBDK0ZRSFB3aDB6Znh2ZEpPSUMydUhQc2FWWjJ2ZnlvUU5Pd0FOQzFkQjVG?= =?utf-8?B?ZlFLRlk2MjR2d3M4UDZ6YWd4VjZFeVFJY0lUSnVjays3eURtSEVFZGpGS3Iw?= =?utf-8?B?bXJWZllEbUx0M1VnUWVHYi8xQTVyUXJwbm5OVmllSFI2RksvMk1DN3FMUVBw?= =?utf-8?B?Z3FWNUV5c3Rka1d3R1B4ZTdYZ1B1OWtwMjVGZkN6UEY4ZjRHd2lLTzBtM0tW?= =?utf-8?B?V1hDaE5Oc2xDeHpGK0lKcVkrdmhvUEUyMHZtcmFZQmRFNjZhcmxOZ1pJZU1N?= =?utf-8?B?bWtwR29tbDRqOGdCUE1YM3VlZ2hoUU01NjFOeW8wTHRTQkVFQng3enlScDlz?= =?utf-8?B?ZnluTW1lMGtpNUtpWVphWnJPVmxYc0dRWTR3NXhJaGd0YTUrYW84Y2I2anVB?= =?utf-8?B?ODFHMlh0TjhyZEtpRjNBMUdvcWluR3N5SjdPQ1Z0VzJkalFGS0VFVEFtK2VK?= =?utf-8?B?VTdUek9aMU9EVHNqalozamRwSFo5VFhJTWtBNG5rK1dJUHBWdFU1ZjJKc2hZ?= =?utf-8?B?MzNlbWtTS1Z0NnpHSGtYWU5UU242eHBzUkNJVk8rUzVHQXhRVEtISDBWQmR5?= =?utf-8?B?U3JQK2ZHVjl4WEdOUklrbkJsK0FxM3Z3TTNKYVJyUnVkdXpsUHE3SndSWlhn?= =?utf-8?B?VFdIcFhrQ0hSTitTbXZIcU94SkczMUVFYUovWUkxZnh6WFpNc0pNMHZhU0Ny?= =?utf-8?B?VjNBb2dHTFdWVmJ4bjV4V25ESEg4Z2JvVnJ6bTBISGlxV1ZZT3oyYXljSlo3?= =?utf-8?B?VGpMTWh5alJycU93V05qeU94dlMyUXhTMjloMThheG11U3FPR2Q5WjczYXk0?= =?utf-8?B?WkxDZVpvUERpaFVwOWEwTUxTK29MenRHUjRGUHlGQ085dTNoT2ZGYzU0RHFU?= =?utf-8?B?a0RSSDEwSm1XOGNlSU9LUlhRdGZTNWxwUG5YZFhrL0JUWHQwV2E3SXFDaU91?= =?utf-8?B?ZU5SeWVRNVNrZnNFdFByYTdreTFlMnlsZnFyaFRYSEZ1ZkVMYS84SDB6Mk9T?= =?utf-8?B?ejU2ODMvSUxndzJCWTBkbUg4QnRoemxyVkRVWFVkQUdwM1RYbzByS1JmWEJl?= =?utf-8?B?STVpVGEvRm52MWZiVWhkV3lHejVBK3dIVGFDbGQxTXVKaDUvOWVhcFpWRkxx?= =?utf-8?Q?LSyUT41TX/VgkgfvCaUWPIJCHZ6C8QD/NZq7Dh4?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9d8a13fd-e3ea-4883-0288-08d8f0456a1e X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2021 10:53:40.1073 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rG53FXsxHSnumwywhPyW3n2u5bKigkX9HY8uRU0xqj5Q7rpp5Qc1xCpIwOddFpjbEu92ZQXN4YoXQpFIP2UGaTNDn9DpolL3TaEARhFoPts= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3265 X-OriginatorOrg: citrix.com On 26/03/2021 09:59, Jan Beulich wrote: > On 25.03.2021 17:52, Andrew Cooper wrote: >> ... in preparation to introduce a second caller. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper > Generally > Reviewed-by: Jan Beulich Thanks, > but I think there's one small code change needed plus I have two > nits (and I expect that this change wouldn't be committed without > patch 2, as making the function non-static isn't warranted > otherwise): Yeah - I intend these to go in together. > >> --- a/xen/arch/x86/hpet.c >> +++ b/xen/arch/x86/hpet.c >> @@ -754,11 +754,70 @@ int hpet_legacy_irq_tick(void) >> } >> >> static u32 *hpet_boot_cfg; >> +static u64 __initdata hpet_rate; > Use uint64_t as you move this here? Ok. > >> +bool __init hpet_enable_legacy_replacement_mode(void) >> +{ >> + unsigned int id, cfg, c0_cfg, ticks, count; >> + >> + if ( !hpet_rate || > I think you need to also honor opt_hpet here. Can't (order of patches), and also no need. When opt_hpet is introduced, hpet_rate can't become nonzero without opt_hpet being set. > >> + !((id = hpet_read32(HPET_ID)) & HPET_ID_LEGSUP) || > I don't think I see a need for the assignment and hence the local > variable. Dropping it would make the code easier to read imo. Ok. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 26 10:55:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 10:55:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101683.194607 (Exim 4.92) (envelope-from ) id 1lPk7o-0003Ft-OC; Fri, 26 Mar 2021 10:55:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101683.194607; Fri, 26 Mar 2021 10:55:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPk7o-0003Fm-LI; Fri, 26 Mar 2021 10:55:32 +0000 Received: by outflank-mailman (input) for mailman id 101683; Fri, 26 Mar 2021 10:55:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPk7m-0003Ff-Rl for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 10:55:30 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9419c948-3b05-460a-ab58-31bf779fe86c; Fri, 26 Mar 2021 10:55:30 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 62543AB8A; Fri, 26 Mar 2021 10:55:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9419c948-3b05-460a-ab58-31bf779fe86c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616756129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x4ye35p8iI77ZWL2d2uBi15fDWKhM+M8p1v665Zat/I=; b=rDGJe3rsrNqUXrMmdIWQetls3jON4zPUdTBJ4C0uzYuD21ULW7F52GLIk1+84wYZT9Ysz3 6lh2BVmanig8Iw1wSdnM4ncgd3s3R6yh0le0SsP0ZxUCM+vq3hfJP+aoflJQpQ3h1TKo5W HgUyW5AdjGV0oC/Qi/zpSl+naFwaXSM= Subject: Re: [PATCH 1/2] x86/hpet: Factor hpet_enable_legacy_replacement_mode() out of hpet_setup() To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , Xen-devel References: <20210325165224.10306-1-andrew.cooper3@citrix.com> <20210325165224.10306-2-andrew.cooper3@citrix.com> <3ef41d04-cff0-5828-8373-af5f42a4f857@suse.com> From: Jan Beulich Message-ID: <3d728e77-e0ff-5b92-e3c9-cfadcdf6380c@suse.com> Date: Fri, 26 Mar 2021 11:55:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 26.03.2021 11:53, Andrew Cooper wrote: > On 26/03/2021 09:59, Jan Beulich wrote: >> On 25.03.2021 17:52, Andrew Cooper wrote: >>> +bool __init hpet_enable_legacy_replacement_mode(void) >>> +{ >>> + unsigned int id, cfg, c0_cfg, ticks, count; >>> + >>> + if ( !hpet_rate || >> I think you need to also honor opt_hpet here. > > Can't (order of patches), and also no need. > > When opt_hpet is introduced, hpet_rate can't become nonzero without > opt_hpet being set. Oh, right, sorry: I did mix up hpet_address and hpet_rate. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 26 11:05:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 11:05:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101694.194620 (Exim 4.92) (envelope-from ) id 1lPkH2-0004UB-Ml; Fri, 26 Mar 2021 11:05:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101694.194620; Fri, 26 Mar 2021 11:05:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkH2-0004U4-Jc; Fri, 26 Mar 2021 11:05:04 +0000 Received: by outflank-mailman (input) for mailman id 101694; Fri, 26 Mar 2021 11:05:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkH1-0004Tw-9s; Fri, 26 Mar 2021 11:05:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkH1-00056a-0e; Fri, 26 Mar 2021 11:05:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkH0-0001Av-PT; Fri, 26 Mar 2021 11:05:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPkH0-0001V8-Ox; Fri, 26 Mar 2021 11:05:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=FlFTZpbGnFmDEZcKyCr03Dknamfq4SVmejMBVFYqcJQ=; b=x29Hs9EFU8SVL/Fc7nIqu/B/A3 7w1lsAszgmh4WUKI710vimWkMl2URVWR/fdipU2q6l0sX0+aSqWrfMCXS/31KK+5S07lIaBL4tHi4 XE8w9yaY5A4tU3z91xOwJJP3chvT9KnaO62bbpYfvI0Db14LuNNFwpwUy+rA0B+QsL2c=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Subject: [qemu-mainline bisection] complete test-amd64-amd64-qemuu-freebsd12-amd64 Message-Id: From: osstest service owner Date: Fri, 26 Mar 2021 11:05:02 +0000 branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-qemuu-freebsd12-amd64 testid guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 Bug not present: cbde7be900d2a2279cbc4becb91d1ddd6a014def Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160441/ commit 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 Author: Daniel P. Berrangé Date: Mon Feb 22 12:54:55 2021 +0000 machine: remove 'query-cpus' QMP command The newer 'query-cpus-fast' command avoids side effects on the guest execution. Note that some of the field names are different in the 'query-cpus-fast' command. Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta Signed-off-by: Daniel P. Berrangé For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/test-amd64-amd64-qemuu-freebsd12-amd64.guest-saverestore.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/test-amd64-amd64-qemuu-freebsd12-amd64.guest-saverestore --summary-out=tmp/160441.bisection-summary --basis-template=152631 --blessings=real,real-bisect,real-retry qemu-mainline test-amd64-amd64-qemuu-freebsd12-amd64 guest-saverestore Searching for failure / basis pass: 160392 fail [host=elbling0] / 160125 [host=elbling1] 160119 [host=godello0] 160113 [host=albana1] 160104 [host=godello1] 160097 [host=chardonnay0] 160091 [host=huxelrebe1] 160088 [host=pinot1] 160082 [host=fiano0] 160079 [host=chardonnay1] 160070 [host=fiano1] 160066 [host=pinot0] 160002 [host=albana1] 159947 [host=chardonnay1] 159926 [host=chardonnay0] 159911 [host=fiano1] 159898 [host=huxelrebe1] 159888 [host=godello0] 159878 [host=fiano0] 159869 [host=fiano1] 159860 [host=godello1] 159853 [h\ ost=elbling1] 159848 [host=godello0] 159842 [host=fiano1] 159834 [host=albana0] 159828 ok. Failure / basis pass flights: 160392 / 159828 (tree with no url: minios) Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0ecdcb6142037dd1cdd08660a2349960bcf0270a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 01874b15d36e3f9a3506c47941a92ccf8d8bed98 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee ecdff2f5a03210119b71806c3f5571d6906dd85e Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ef91b07388e1c0a50c604e5350eeda98428ccea6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cb90ecf9349198558569f6c86c4c27d215406095 ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e 243036df0d55673de59c214e240b9b914d278b65 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#ef91b07388e1c0a50c604e5350eeda98428ccea6-0ecdcb6142037dd1cdd08660a2349960bcf0270a git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c74\ 37ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#cb90ecf9349198558569f6c86c4c27d215406095-01874b15d36e3f9a3506c47941a92ccf8d8bed98 git://xenbits.xen.org/osstest/seabios.git#ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e-b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee git://xenbits.xen.org/xen.git#243036df0d55673de59c214e240b9b914d278b65-ecdff2f5a03210119b71806c3f5571d6906dd85e >From git://cache:9419/git://git.qemu.org/qemu 9e2e9fe3df..63ad23fa24 master -> origin/master Loaded 30545 nodes in revision graph Searching for test results: 159828 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ef91b07388e1c0a50c604e5350eeda98428ccea6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cb90ecf9349198558569f6c86c4c27d215406095 ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e 243036df0d55673de59c214e240b9b914d278b65 159834 [host=albana0] 159842 [host=fiano1] 159848 [host=godello0] 159853 [host=elbling1] 159860 [host=godello1] 159869 [host=fiano1] 159878 [host=fiano0] 159888 [host=godello0] 159898 [host=huxelrebe1] 159911 [host=fiano1] 159926 [host=chardonnay0] 159947 [host=chardonnay1] 160002 [host=albana1] 160048 [] 160050 [] 160057 [] 160062 [] 160064 [] 160066 [host=pinot0] 160070 [host=fiano1] 160079 [host=chardonnay1] 160082 [host=fiano0] 160088 [host=pinot1] 160091 [host=huxelrebe1] 160097 [host=chardonnay0] 160104 [host=godello1] 160113 [host=albana1] 160119 [host=godello0] 160125 [host=elbling1] 160134 fail irrelevant 160147 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2e1293cbaac75e84f541f9acfa8e26749f4c3562 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160167 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ca318882714080fb81fe9eb89a7b7934efc5bfae 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 bdee969c0e65d4d509932b1d70e3a3b2ffbff6d5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160328 fail irrelevant 160378 blocked c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ef91b07388e1c0a50c604e5350eeda98428ccea6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cb90ecf9349198558569f6c86c4c27d215406095 ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e 243036df0d55673de59c214e240b9b914d278b65 160380 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ef91b07388e1c0a50c604e5350eeda98428ccea6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cb90ecf9349198558569f6c86c4c27d215406095 ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e 243036df0d55673de59c214e240b9b914d278b65 160382 fail irrelevant 160384 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 f2a9a6c2a86570ccbf8c5c30cbb8bf723168c459 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160386 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8a40754bca14df63c6d2ffe473b68a270dc50679 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160388 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7286d62d4e259be8cecf3dc2deea80ecc14489a5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160389 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 69259911f948ad2755bd1f2c999dd60ac322c890 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160390 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6e71c36557ed41017e634ae392fa80f03ced7fa1 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160361 fail irrelevant 160391 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2255564fd21059960966b47212def9069cb56077 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160393 fail irrelevant 160396 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 2e51b27fed31eb7b2a2cb4245806c8c7859207f7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 0693602a23276b076a679b1e7ed9125a444336b6 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160401 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8b858f9998a9d59a9a7188f2c5c6ffb99eff6115 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160402 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 30ca7eddc486646fa19c9619fcf233ceaa65e28c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160403 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2615a5e433aeb812c300d3a48e1a88e1303e2339 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160405 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 51204c2f188ec1e2a38f14718d38a3772f850a4b b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160407 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 773b0bc2838ede154c6de9d78401b91fafa91062 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 5e8892db93f3fb6a7221f2d47f3c952a7e489737 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160408 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8e6bc6cdc82d45f203bc9fc4342c0452214c74fe b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 14b95b3b8546db201e7efd0636ae0e215fae98f3 160409 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 757acb9a8295e8be4a37b2cfc1cd947e357fd29c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 14b95b3b8546db201e7efd0636ae0e215fae98f3 160411 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 9abda42bf2f5aa6ef403d3140fd3d7d88e8064e9 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 893103e286ac1c500d2ad113f55c41edb35e047c 160412 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6f34661b6c97a37a5efc27d31c037ddeda4547e2 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 0570d7f276dd20a3adee80ca44a5fe7daf7566cd 160413 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a557b00469bca61a058fc1db4855503cac1c3219 ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e 4e01c48886d9fbfee3bf7e481c4529a176331c78 160415 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 1941858448e76f83eb00614c4f34ac29e9a8e792 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 0570d7f276dd20a3adee80ca44a5fe7daf7566cd 160416 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 65a9d3807e9a0ffd9f9719416a07be41b6f39e94 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e4bdcc8aef6707027168ea29caed844a7da67b4d 160392 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0ecdcb6142037dd1cdd08660a2349960bcf0270a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 01874b15d36e3f9a3506c47941a92ccf8d8bed98 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee ecdff2f5a03210119b71806c3f5571d6906dd85e 160417 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 94fa95c8746c553324e8b69ea4a74af670075324 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e4341623a3b87e7eca87d42b7b88da967cd21c49 ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e 60c0444fae2148452f9ed0b7c49af1fa41f8f522 160420 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ef91b07388e1c0a50c604e5350eeda98428ccea6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cb90ecf9349198558569f6c86c4c27d215406095 ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e 243036df0d55673de59c214e240b9b914d278b65 160421 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0ecdcb6142037dd1cdd08660a2349960bcf0270a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 01874b15d36e3f9a3506c47941a92ccf8d8bed98 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee ecdff2f5a03210119b71806c3f5571d6906dd85e 160424 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 d1929069e355afb809a50a7f6b6affdea399cc8c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 368096b9c4a273be58dd897e996e3e010bcfc21b 160426 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b6d5996706ddb6082e3ea8de79849bfecf2aaa15 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160427 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160428 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ee2e67da8f882fcdef2c49fcc58e9962aa695f5a b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160429 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f9c53a69edeb94ae8c65276b885c1a7efe4f613a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 571d413b5da6bc6f1c2aaca8484717642255ddb0 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160431 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 283d845c9164f57f5dba020a4783bb290493802f b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160433 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8becb36063fb14df1e3ae4916215667e2cb65fa2 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160435 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cbde7be900d2a2279cbc4becb91d1ddd6a014def b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160437 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160438 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cbde7be900d2a2279cbc4becb91d1ddd6a014def b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160439 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160440 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cbde7be900d2a2279cbc4becb91d1ddd6a014def b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160441 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 Searching for interesting versions Result found: flight 159828 (pass), for basis pass Result found: flight 160392 (fail), for basis failure Repro found: flight 160420 (pass), for basis pass Repro found: flight 160421 (fail), for basis failure 0 revisions at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 cbde7be900d2a2279cbc4becb91d1ddd6a014def b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 No revisions left to test, checking graph state. Result found: flight 160435 (pass), for last pass Result found: flight 160437 (fail), for first failure Repro found: flight 160438 (pass), for last pass Repro found: flight 160439 (fail), for first failure Repro found: flight 160440 (pass), for last pass Repro found: flight 160441 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 Bug not present: cbde7be900d2a2279cbc4becb91d1ddd6a014def Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160441/ commit 8af54b9172ff3b9bbdbb3191ed84994d275a0d81 Author: Daniel P. Berrangé Date: Mon Feb 22 12:54:55 2021 +0000 machine: remove 'query-cpus' QMP command The newer 'query-cpus-fast' command avoids side effects on the guest execution. Note that some of the field names are different in the 'query-cpus-fast' command. Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta Signed-off-by: Daniel P. Berrangé Revision graph left in /home/logs/results/bisect/qemu-mainline/test-amd64-amd64-qemuu-freebsd12-amd64.guest-saverestore.{dot,ps,png,html,svg}. ---------------------------------------- 160441: tolerable ALL FAIL flight 160441 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/160441/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail baseline untested jobs: test-amd64-amd64-qemuu-freebsd12-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Fri Mar 26 11:14:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 11:14:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101704.194638 (Exim 4.92) (envelope-from ) id 1lPkPb-0005eS-T5; Fri, 26 Mar 2021 11:13:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101704.194638; Fri, 26 Mar 2021 11:13:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkPb-0005eL-Pz; Fri, 26 Mar 2021 11:13:55 +0000 Received: by outflank-mailman (input) for mailman id 101704; Fri, 26 Mar 2021 11:13:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkPa-0005eG-W1 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:13:55 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (unknown [40.107.13.48]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5d1f0550-bd61-474e-94f7-04ed8bea9f20; Fri, 26 Mar 2021 11:13:53 +0000 (UTC) Received: from DB6P18901CA0019.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::29) by AM8PR08MB5857.eurprd08.prod.outlook.com (2603:10a6:20b:1d2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Fri, 26 Mar 2021 11:13:51 +0000 Received: from DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:16:cafe::8f) by DB6P18901CA0019.outlook.office365.com (2603:10a6:4:16::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Fri, 26 Mar 2021 11:13:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT023.mail.protection.outlook.com (10.152.20.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Fri, 26 Mar 2021 11:13:51 +0000 Received: ("Tessian outbound 7d88ebbbfeee:v89"); Fri, 26 Mar 2021 11:13:51 +0000 Received: from c827c22ef2a0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 25ABC507-B923-497D-9986-428EEEF3259F.1; Fri, 26 Mar 2021 11:13:44 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c827c22ef2a0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 26 Mar 2021 11:13:44 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VI1PR0801MB1855.eurprd08.prod.outlook.com (2603:10a6:800:59::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Fri, 26 Mar 2021 11:13:42 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::b538:7f7:f4f3:8c0e]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::b538:7f7:f4f3:8c0e%7]) with mapi id 15.20.3977.029; Fri, 26 Mar 2021 11:13:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d1f0550-bd61-474e-94f7-04ed8bea9f20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QuCaZ7gsXzEwZppptp7blhyz5WSWnO/47QN5rSTEGV4=; b=uH5F/dXa8ZoRTSQDYWvK65/dwXExttBiedyrXvSjXgPcZafqVlQsjemsTfUC6jGCgVLW1wFpIq8ZAqJBwYicuiSy0h4c1Sf+uszHCwys52Y6L3GDR0B/J4IEud/A1/pab6sQvIaKwtoDBmjSAyY/hfqLDyTJFcu9DwQ39hFICZA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 80fcea024003efab X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OGC6zjXXKMipGr0Yi/eL3nv+61B9+6UPVpzpHwWNghOCFr6S8E/M2F0DuYi/1qybzMCNcWsL2Ci3FbwMmk/Ln6z9D4mUqKCCFC9rSUeKxZoAKLooFiteFLbUAJ1BCReZ/6EKdGQ/dEFi2L0yx8CWQpoqdOfcvcJ27WQu4+z45ZmaIqYkFgSIRCT1kov8KtH7ogft65i9AmL0Aq3g15IgOXdAFW8lq/VPZlwAKJFPRdBj8c8d4GftD1yhBAfmV1TUmn8J0LSWPiNu3KsMiY4PH2PtH7w6oUYbCYoE1ZjLfllKOxGTnyv/sOyR0aQSJ87Ulu7GlPILSa78EY9wlhLFEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QuCaZ7gsXzEwZppptp7blhyz5WSWnO/47QN5rSTEGV4=; b=C4wRT1rxMi4GQXMfXywrYk5MRunzMGn99iwWB9IOEcCrMyrcsmfrB5JOf6QgPfQqW1Vbq68nYDSsNy0koERh2Oyf4a5eicnmF98IhBelJBMVaRoqeccPbNlNNyasKmY09DbZ+6MSraTi/iyCXzBuhzm9OscknyB9iNlzQpCM+561Z6F0q9J7wJOydXJ97xr+OoRokCEsQuIDoIYrrTdmNgwTOpqNFEmP54IofIkJoTXhWB5J2SY3+4d92zfhTxc3nUIXEeYBy/Jjg+A8nzBbNeMbBD8+RH1XdoOv5OQKpVGmLCAKNULjP91GxIoXbyn3ZyDTeeFBVvQ75D0V7xTydg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QuCaZ7gsXzEwZppptp7blhyz5WSWnO/47QN5rSTEGV4=; b=uH5F/dXa8ZoRTSQDYWvK65/dwXExttBiedyrXvSjXgPcZafqVlQsjemsTfUC6jGCgVLW1wFpIq8ZAqJBwYicuiSy0h4c1Sf+uszHCwys52Y6L3GDR0B/J4IEud/A1/pab6sQvIaKwtoDBmjSAyY/hfqLDyTJFcu9DwQ39hFICZA= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Xen.org security team Subject: Re: [PATCH for-next v2 2/2] xen/arm64: Place a speculation barrier following an ret instruction Thread-Topic: [PATCH for-next v2 2/2] xen/arm64: Place a speculation barrier following an ret instruction Thread-Index: AQHXGCLUePNZXth41EOpDgjR62uDxqqISyAAgASaOICACUyKAA== Date: Fri, 26 Mar 2021 11:13:42 +0000 Message-ID: <342BA51C-80BE-4393-997E-6C5830CB57A1@arm.com> References: <20210313160611.18665-1-julien@xen.org> <20210313160611.18665-3-julien@xen.org> <50175d48-6f0b-2d96-8ea9-33f4f65f920f@xen.org> In-Reply-To: <50175d48-6f0b-2d96-8ea9-33f4f65f920f@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.26.33.241] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 97b3818b-7036-419f-dac8-08d8f0483c43 x-ms-traffictypediagnostic: VI1PR0801MB1855:|AM8PR08MB5857: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CW3pnr4TJVqJZ/DvNRwJRd/ZhfS3xJL6vmIvx2iflsbw0BHTBzbzaDqHEL9VOlnPynC5Yiz3QOv9z1F/N+SEb1aLfpoZM1TNpK7z3p9gXl81OJJJHcxZmD13s8FKcscjRGAFAc0hSO+pJ798nJhSOK1cXwsH3WI04M1mjT89v/vGkdcN51g7RcGnTwRMUbT5ycTJ25bcns+WMg7xhKMK/7MJsKPnSTR9f7kCVd3aGYhhHjMAhD0sPkfaSNzUDhsKxN/kolJT9jLBYrfVxD4kwR6EREi5Zgra/DV8Aq5boohPkI5UghVKE68HwVzaHP5bkAw5Z3ZPKwCp/2EwusR49Dp7hrLD/hgPOrEngSBxeFkSXnfXYWRkajKDJm++CoV0iA+vtxrJjmYeZAJZ99XcSovXr8CpwYaw3oErXRHTbMw0OFUx3S5h4ephyk4KV/4Be0Zmx6IdzePO2AlFRzsvZOtAfiiFi0wjeNJ1oTqFpqc6qsYx2jvB7KEeNWnoI4R/OtIIw+ysEaZVDZl/NKQ1fS7DkpWo/DzLnMjSeI6siDZtWmTqADteyABq7wqNVA7nnkhhqrZk6+VnLXQhoKrMfOPcMKjun6QP1DGS7tr7NCXuCm7mkqB9C69czOvTDtVxVyeu0XyDYvwreURsB9BGzSo+zSbfb8HJZXxayk8lubKVC825sNcbVZV3PIo5z08ckk4xzWaRxOAdrVOKeJDUto2+WalWww4QE8eJrOgb6S3hvejJl8Dmn5sveU8BX2SVOc7aPo5p/XVM5E+34IjIQw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(39860400002)(136003)(396003)(346002)(2906002)(4326008)(6486002)(8676002)(71200400001)(6916009)(38100700001)(478600001)(966005)(6512007)(86362001)(8936002)(66476007)(66556008)(64756008)(33656002)(66446008)(26005)(66946007)(91956017)(83380400001)(36756003)(5660300002)(2616005)(6506007)(53546011)(55236004)(76116006)(54906003)(186003)(316002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?RlAwVThoYllIZ2cwcWtYb3liZ3NGT0NDcUdocHJYU2pQUEYrK1dyMzZyZXoz?= =?utf-8?B?S0tlTzBjTHJ2cGhmVitWL3VtQmdRdWh0TGVpeXB1MWh3c0x4NXM4UzRvWTlU?= =?utf-8?B?blkxMEt1QUNNM0RQeGg4WUpkYUpjY2VKTFRyUUhxTGpaZS9VdjlYcmpQdHVm?= =?utf-8?B?a24zOHpRQmx3VHRMbG5yRDZreWNzWEJoWkltdlIrZjA2VzhRNnQzQmV0OG1i?= =?utf-8?B?VTJ5QWI2bXRMNksvS2VTb1A4Q1ZKbUlqQ0RPRFRqUzVrSjRCSWh0Rmx5bWpl?= =?utf-8?B?TnJ0UWw2NWZpRzNxcUFnK3ZNTXdHQ2ZNU0xtOWozODJsd0puZldCTzRaYkhS?= =?utf-8?B?ZklQWEJURnB5T1I2dDVTWjhlWUhYZTNRZE5ERnFKMU13b1BsRTNuMXEyOHhj?= =?utf-8?B?MkRUZ3F2bE5uNTJCWnFFZUdHeHZaemZLNFRuTU1mVDJWQy91YzRFUmpjUjRW?= =?utf-8?B?Q3VPV3g1SVI2VDh4aWQ2bFM2Z0RON1diajgxdjJHeHo3RlZqbFNQdTVMOHdI?= =?utf-8?B?QVd4M2I4YnVaWm9sYVlWZEhQdXNkTXdEM2FSdktNVktSQmM3eDg1TVVMeUp2?= =?utf-8?B?L1ZXZEpEeXBJUGlqVDlkQXFkR0RNYkFrSHdCd2kwVjJKSm5QYTQ2bEE0V0Zv?= =?utf-8?B?OCtKK0hOUlhlWDRwUHY1UlI0WGZBZUpjSjdPL1pTMnFtbTZGU055MmtLVEQr?= =?utf-8?B?bTJmQTYxVFlIdFZKSFYzOXRHbzZ0SzZUOWZ5WGVaVHBFT2kxbGRWZjRJYzhP?= =?utf-8?B?Q1Rac3hHS3BjcU1RVXhycmRkZlNGdCtMVmxpQ2pjbERnakxNbmovRzlUcHBq?= =?utf-8?B?azY5bno1VjAzSUQxN0RzdHI5ZjJjZW9JY241N3I1RmRqbXAyMUdNNEVkb1dD?= =?utf-8?B?RVpzUXpEeEJXQjFkbGZ5Ym4xbXZEazRZbUJrQ2prZ2VkRjExSmVCRXdmK0pM?= =?utf-8?B?UXZMMjcvRmdOQXZaNW9TNWpvcGpWZUhoSUhqeWMzZUkzbXVlbEk4N2Z0YTN1?= =?utf-8?B?V1IrNzRRa3BEVUJBREdxTTBzME83cGZmT0R1WmN1MWVhcFIvTW4venovNU5k?= =?utf-8?B?YVNEQVNFWjR6S1JwbS8vd2NQeEFuMWthbUVWSUpINHJuT2J1NUNia1VhbEg3?= =?utf-8?B?VGFwcVRoTnAzNm5RTXR1Uzd3dm43ZzJVS1lLTnV5Y2gwNTRPVGZrNlgrcFFB?= =?utf-8?B?ZEFscEV0dXVYVGVCU2RWQU1DdHA0ZmhicWRpSHI2UGhCa3RNTmVzOVJja2RH?= =?utf-8?B?SWhQU2t4ODZxcGhscXBMNGpNQjJNb2I5MVJOL3FZUWhIcnNnQlBGdEViNlVV?= =?utf-8?B?NjhuVGlmeFJ3c3A2d01TSGR2VGc0TldzOS95RHlpekxpdlpKdDF6amFHdXRH?= =?utf-8?B?WjlaVEcrNU5VOXpDTWhDdEtPZFd6MXVzQXZMaWN3dWlDMmFSbk93bk1QWG9u?= =?utf-8?B?TTR6YXVOQ0pmaTNhb2w0c1J3T3ZEa2xPbFBUM2ZvQjJhd2pNcGE5SzMyT1lT?= =?utf-8?B?L2NsUWswT0poLzhPWTdvaHpJN3JNMXVlZzdZblZ6emJvOUxnM3FKenJ5SStC?= =?utf-8?B?ejJqQ0ptQXBrR1JCTmNNZDdYczNwendmSm16WmZIcnlMZ3d3bjJzVURPRkZW?= =?utf-8?B?QXdGVVFMekVZejBGbGxWeGRuVytZTFJrN241bHJwU25oMm9uNHlGTGVhbkc2?= =?utf-8?B?ZHJOMzJvK1J1UDJtVWtMS2RLNk5kNGZiSXFOdkJKc1FWSUxiVStCVGpqTWhE?= =?utf-8?Q?ptxdmumw1rbHZSka1KO0mecOaQ6JLh9/dPCFspJ?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <10BE7326D85BD540838205914D95FFF6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1855 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 92548d86-ddf1-4325-3727-08d8f048371b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nmzl+K1iBkaZrkOfMPIMn30IilizLJtFuChK2HpMwPUYlb4FKO2fnmgNMKEJY2VKyURDu7MNJEk4dDnzGMHF16LDQgv6lhzMWzaIkfArRTxzZyPJgChwawMFllC3KHIgq7OxAR7sCSE/0xjPVkBFfPtiKRvP/2F5MDxueN5I2TSqqY9d3vUJPbqxd0F1k/3eTephbxq7WSdr0IFZPejjfaHsApf/JcooEBBN5wiBtHHlDT8BytaR7HTZd/xOX4gIlNQz6rfQTvaZsSrS36uGYoguXqoXNmJorS4EGmaMvYp5c2p4BdpgadhYTEvWNQGJ+kz3h9KjNe/N0bxaT3NETNxWWvZu1v9hbsEc0ufcIMhy0jgPzWznXDT2YSeVR3fyaKajJEUgh07bGTr4CIY8Yn3EeuQCYz3PBok54zJD+ZvCwVMEDtmfhA53DL5/7oHpjxinBAE++Vbvb3CnQvlXBLd93+6nNDi2zJ1jjFeHWrYt/GDm2U4LRBWkg8RbP1Tq2xNnecYx/cNdT5FLCM8K7KNeZUZcAB4XQMVKXft2+h9UffHelw0TgS/0LT3MRrAPfnSDfabhc1BSn91YF2XHBAX50zMxIYhOrcA8HUlvbkfuSbZAx5QPuTsT2ajjMjTk4Xr9ahehSTAsztk4ij6Aye/L0fBtIhc1DfSMsEq7MkSAWYPLfPRtztWoH/k2BdKdfkSF3SzqB2NbNvjKMskaEZ4+h/zz8V8/KH+DJnnLG2U= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(346002)(39860400002)(136003)(376002)(46966006)(36840700001)(53546011)(356005)(478600001)(8936002)(55236004)(54906003)(26005)(86362001)(966005)(6506007)(33656002)(6862004)(4326008)(316002)(8676002)(82310400003)(47076005)(70206006)(6512007)(36756003)(82740400003)(70586007)(83380400001)(5660300002)(81166007)(6486002)(2906002)(186003)(36860700001)(2616005)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2021 11:13:51.2246 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 97b3818b-7036-419f-dac8-08d8f0483c43 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5857 SGkgSnVsaWVuLA0KDQooc29ycnkgZm9yIHRoZSBkZWxheSkNCg0KPiBPbiAyMCBNYXIgMjAyMSwg YXQgMTM6MTMsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPiANCj4gKCsg U2VjdXJpdHkpDQo+IA0KPiANCj4gT24gMTcvMDMvMjAyMSAxNDo1NiwgQmVydHJhbmQgTWFycXVp cyB3cm90ZToNCj4+IEhpIEp1bGllbiwNCj4gDQo+IEhpIEJlcnRyYW5kLA0KPiANCj4+PiBPbiAx MyBNYXIgMjAyMSwgYXQgMTY6MDYsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3Rl Og0KPj4+IA0KPj4+IEZyb206IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQo+Pj4g DQo+Pj4gU29tZSBDUFVzIGNhbiBzcGVjdWxhdGUgcGFzdCBhIFJFVCBpbnN0cnVjdGlvbiBhbmQg cG90ZW50aWFsbHkgcGVyZm9ybQ0KPj4+IHNwZWN1bGF0aXZlIGFjY2Vzc2VzIHRvIG1lbW9yeSBi ZWZvcmUgcHJvY2Vzc2luZyB0aGUgcmV0dXJuLg0KPj4+IA0KPj4+IFRoZXJlIGlzIG5vIGtub3du IGdhZGdldCBhdmFpbGFibGUgYWZ0ZXIgdGhlIFJFVCBpbnN0cnVjdGlvbiB0b2RheS4NCj4+PiBI b3dldmVyIHNvbWUgb2YgdGhlIHJlZ2lzdGVycyAoc3VjaCBhcyBpbiBjaGVja19wZW5kaW5nX2d1 ZXN0X3NlcnJvcigpKQ0KPj4+IG1heSBjb250YWluIGEgdmFsdWUgcHJvdmlkZWQgYnkgdGhlIGd1 ZXN0Lg0KPj4+IA0KPj4+IEluIG9yZGVyIHRvIGhhcmRlbiB0aGUgY29kZSwgaXQgd291bGQgYmUg YmV0dGVyIHRvIGFkZCBhIHNwZWN1bGF0aW9uDQo+Pj4gYmFycmllciBhZnRlciBlYWNoIFJFVCBp bnN0cnVjdGlvbi4gVGhlIHBlcmZvcm1hbmNlIGltcGFjdCBpcyBtZWFudCB0bw0KPj4+IGJlIG5l Z2xpZ2VhYmxlIGFzIHRoZSBzcGVjdWxhdGlvbiBiYXJyaWVyIGlzIG5vdCBtZWFudCB0byBiZQ0K Pj4+IGFyY2hpdGVjdHVyYWxseSBleGVjdXRlZC4NCj4+PiANCj4+PiBSYXRoZXIgdGhhbiBtYW51 YWxseSBpbnNlcnRpbmcgYSBzcGVjdWxhdGlvbiBiYXJyaWVyLCB1c2UgYSBtYWNybw0KPj4+IHdo aWNoIG92ZXJyaWRlcyB0aGUgbW5lbW9uaWMgUkVUIGFuZCByZXBsYWNlIHdpdGggUkVUICsgU0Iu IFdlIG5lZWQgdG8NCj4+PiB1c2UgdGhlIG9wY29kZSBmb3IgUkVUIHRvIHByZXZlbnQgYW55IG1h Y3JvIHJlY3Vyc2lvbi4NCj4+PiANCj4+PiBUaGlzIHBhdGNoIGlzIG9ubHkgY292ZXJpbmcgdGhl IGFzc2VtYmx5IGNvZGUuIEMgY29kZSB3b3VsZCBuZWVkIHRvIGJlDQo+Pj4gY292ZXJlZCBzZXBh cmF0ZWx5IHVzaW5nIHRoZSBjb21waWxlciBzdXBwb3J0Lg0KPj4+IA0KPj4+IFRoaXMgaXMgcGFy dCBvZiB0aGUgd29yayB0byBtaXRpZ2F0ZSBzdHJhaWdodC1saW5lIHNwZWN1bGF0aW9uLg0KPj4+ IA0KPj4+IFNpZ25lZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQo+ PiBUaGUgbWFjcm8gc29sdXRpb24gaXMgZGVmaW5pdGVseSBhIGdyZWF0IGltcHJvdmVtZW50IGNv bXBhcmVkIHRvIHYxIGFuZCBJIGNvdWxkDQo+PiBjb25maXJtIHRoZSBwcmVzZW5jZSBvZiB0aGUg c2IgaW4gdGhlIGdlbmVyYXRlZCBjb2RlLg0KPiANCj4gVGhhbmtzIGZvciB0ZXN0aW5nISBJdCBp cyBpbmRlZWQgYSBsb3QgbmljZXIgYW5kIGxlc3MgZXJyb3ItcHJvbmUuIFdlIGNhbiB0aGFuc2sg SmFuIGZvciB0aGUgaWRlYSBhcyBoZSBvcmlnaW5hbGx5IGludHJvZHVjZWQgaXQgb24geDg2IDop Lg0KPiANCj4+IEkgYWxzbyB0aGluayB0aGF0IHRoZSBtaXRpZ2F0aW9uIG9uIGFybTMyL3Y3IHdv dWxkIGJlIG1lc3N5IHRvIGRvLg0KPiANCj4gSXQgaXMgbWVzc3kgYnV0IG5vdCBpbXBvc3NpYmxl IDopLiBTb21lIG9mIHRoZSBhc3NlbWJseSBmdW5jdGlvbiBjb3VsZCBiZSByZXdyaXR0ZW4gaW4g QyB0byB0YWtlIGFkdmFudGFnZSBvZiB0aGUgY29tcGlsZXIgbWl0aWdhdGlvbnMuDQo+IA0KPiBJ IHdlbnQgdGhyb3VnaCB0aGUgcGFwZXIgYWdhaW4gdG9kYXkuIFN0cmFpZ2h0LWxpbmUgbWl0aWdh dGlvbiBvbmx5IHJlZmVycyB0byB1bmNvbmRpdGlvbmFsIGNvbnRyb2wgZmxvdyBjaGFuZ2UgKGUu Zy4gUkVUKSBvbiBBQXJjaDY0IEFybXY4Lg0KPiANCj4gQSByZWNlbnQgc3VibWlzc2lvbiB0byBM TFZNIHNlZW1zIHRvIHN1Z2dlc3QgdGhhdCBBcm12NyBhbmQgQUFyY2gzMiBBcm12OCBpcyBhbHNv IGFmZmVjdGVkIFsyXS4NCg0KVGhhbmtzIGZvciB0aGUgcG9pbnRlciA6LSkNCg0KPiANCj4gU28g SSB0aGluayB3ZSBvbmx5IG5lZWQgdG8gY2FyZSBvZiB1bmNvbmRpdGlvbmFsIHJldHVybiBpbnN0 cnVjdGlvbiAoZS5nLiBtb3YgcGMsIGxyKS4NCj4gDQo+IEZvciBjb25kaXRpb25hbCByZXR1cm4g aW5zdHJ1Y3Rpb25zLCB0aGV5IHdvdWxkIGJlIHRyZWF0ZWQgYXMgc3BlY3RyZSB2MiB3aGljaCB3 ZSBhbHJlYWR5IG1pdGlnYXRlLg0KDQpUaGF0IHdvdWxkIGJlIGEgZ29vZCBpZGVhIGJ1dCB0aGF0 IHdvdWxkIG1lYW4gbG90cyBvZiBpbnZhc2l2ZSBjaGFuZ2VzIG9uIGFybXY3IGFuZCB0aGlzIGlz IG5vdCB0aGUgbW9zdGx5IHRlc3RlZCBhcmNoaXRlY3R1cmUgd2l0aCBYZW4uDQpBbnl3YXkgSSBh bSBoYXBweSB0byBoZWxwIHJldmlld2luZyB0aGlzIGlmIGl0IGlzIGRvbmUuDQoNCj4gDQo+PiBT aGFsbCB3ZSBtYXJrIHY3L2FhcmNoMzIgYXMgbm90IHNlY3VyaXR5IHN1cHBvcnRlZCA/DQo+IFRo aXMgd291bGQgaGF2ZSBjb25zZXF1ZW5jZSBiZXlvbmQganVzdCBzcGVjdWxhdGlvbi4gVGhlcmUg bWlnaHQgYmUgcHJvY2Vzc29yIG91dCB3aGljaCBhcmUgbm90IGFmZmVjdGVkIGJ5IHN0cmFpZ2h0 LWxpbmUgc3BlY3VsYXRpb24gYW5kIHdlIHdvdWxkIG5vdCBpc3N1ZSBhbnkgc2VjdXJpdHkgdXBk YXRlIGZvciB0aGVtLiBTbyBJIGFtIG5vdCBpbiBmYXZvciB3aXRoIHRoaXMgYXBwcm9hY2guDQo+ IA0KPiBXaGF0IHdlIGNvdWxkIGNvbnNpZGVyIGlzIG1lbnRpb25pbmcgaW4gU1VQUE9SVC5NRCB0 aGF0IHNwZWN1bGF0aW9uIGF0dGFjayB1c2luZyBTdHJhaWdodC1MaW5lIHNwZWN1bGF0aW9uIGFy ZSBub3Qgc2VjdXJpdHkgc3VwcG9ydCBvbiBBcm0gKHRoZSA2NC1iaXQgaXMgbm90IGZ1bGx5IG1p dGlnYXRlZCkuDQoNCldlaXJkIHRvIHNheSDigJxub3Qgc2VjdXJpdHkgc3VwcG9ydGVk4oCdIG1h eWJlIHNheWluZyBub3QgbWl0aWdhdGVkIGJ5IFhlbiB3b3VsZCBiZSBtb3JlIGNsZWFyLg0KDQpB bnl3YXkgSSBhZ3JlZSB3aXRoIHRoZSBwcmluY2lwbGUgdG8gZG8gdGhpcy4NCg0KQ2hlZXJzDQpC ZXJ0cmFuZA0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiBbMV0gaHR0cHM6Ly9yZXZpZXdzLmxsdm0u b3JnL0Q5MjM5NQ0KPiANCj4gLS0gDQo+IEp1bGllbiBHcmFsbA0KDQo= From xen-devel-bounces@lists.xenproject.org Fri Mar 26 11:16:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 11:16:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101707.194649 (Exim 4.92) (envelope-from ) id 1lPkSW-0005no-Bw; Fri, 26 Mar 2021 11:16:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101707.194649; Fri, 26 Mar 2021 11:16:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkSW-0005nh-8u; Fri, 26 Mar 2021 11:16:56 +0000 Received: by outflank-mailman (input) for mailman id 101707; Fri, 26 Mar 2021 11:16:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkSV-0005nb-Ar for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:16:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkSV-0005Ho-8q for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:16:55 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPkSV-0006Cl-7p for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:16:55 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPkSR-0002AF-NC; Fri, 26 Mar 2021 11:16:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=MChc4r1BC9pdhl/FiaFJWdsD3sW8Y6Qngb6ANiZLFbI=; b=a1lGTBr0xbc6dVR9c9NadUf2O0 r9GHD1O3R2Gsi5wYBNtWGuVE+gwjhAxQmeH/EmNGffecLlF6JCovknBEEfI+ahASR74OCEnbdKIY3 5mOJHJoNa1+Rsx4TFebacJmJ94c0OCno8SjfWamKJQyA0hUdGQiBkHij0vQ0IGleaLGg=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24669.49827.522424.713417@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 11:16:51 +0000 To: =?iso-8859-1?Q?J=FCrgen_Gro=DF?= Cc: xen-devel@lists.xenproject.org, Wei Liu Subject: Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface In-Reply-To: <2ccb24a7-a927-cfe7-f102-b8ef02052522@suse.com> References: <20210324072645.10596-1-jgross@suse.com> <24667.7211.431280.743192@mariner.uk.xensource.com> <24667.8900.993418.152255@mariner.uk.xensource.com> <2ccb24a7-a927-cfe7-f102-b8ef02052522@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jrgen Gro writes ("Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface"): > On 24.03.21 12:30, Ian Jackson wrote: > > If you're keen to change this for 4.15, please feel free to show me > > what the patch looks like. But I would be inclined to postpone this. > > Minimal variant sent. I'm not keen to have that for 4.15, but the patch > was just ready. :-) Thanks :-). However, looking at it I think it would be best to postpone this for xen-next and then do the full fix with soname bump. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 11:37:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 11:37:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101710.194661 (Exim 4.92) (envelope-from ) id 1lPklw-00081b-Up; Fri, 26 Mar 2021 11:37:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101710.194661; Fri, 26 Mar 2021 11:37:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPklw-00081U-RZ; Fri, 26 Mar 2021 11:37:00 +0000 Received: by outflank-mailman (input) for mailman id 101710; Fri, 26 Mar 2021 11:36:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPklv-00081O-F9 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:36:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPklu-0005ay-U4 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:36:58 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPklu-0007Pl-Rt for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:36:58 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPklp-0002Gb-TO; Fri, 26 Mar 2021 11:36:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=QIfN6CmwRgEg/5txXuQ41bQ8Q+OhF87anZVPIZJ5OrI=; b=MIp13Ut7Do5VwtsJlXBuXlMn+m eO/uiE0vRh6So9ZSutLGNDV4tPfrQJwtgoqCr1OXuEHAFCK04ZqvOn/KCX7/2Anx1dIWntW9/iTBQ lMaffBkSF+YjghSIpQF2XfV4fJ7aN02XbYFFR2rKY30j3ZmsbkwV2/EFSh8xlApYbKoA=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.51029.465080.822794@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 11:36:53 +0000 To: Tamas K Lengyel Cc: Tamas K Lengyel , Xen-devel , Jan Beulich , Andrew Cooper , George Dunlap , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu Subject: Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking In-Reply-To: References: X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Tamas K Lengyel writes ("Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking"): > On Thu, Mar 18, 2021 at 5:36 PM Tamas K Lengyel wrote: > > > > When creating a VM fork copy the parent VM's hostp2m max_mapped_pfn value. Some > > toolstack relies on the XENMEM_maximum_gpfn value to establish the maximum > > addressable physical memory in the VM and for forks that have not yet been > > unpaused that value is not going to reflect the correct max gpfn that's > > possible to populate into the p2m. This patch fixes the issue. ... > CC-ing Ian as 4.15 release manager. This patch is safe to include in > 4.15 as it's a minor fix in a tech preview feature that's not even > compiled by default. As far as I can tell this patch is lacking a maintainer review ? Release-Acked-by: Ian Jackson *Provided that it is committed today* I'm not sure how likely that is. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 11:45:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 11:45:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101713.194673 (Exim 4.92) (envelope-from ) id 1lPktc-0000ke-Nj; Fri, 26 Mar 2021 11:44:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101713.194673; Fri, 26 Mar 2021 11:44:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPktc-0000kX-Kr; Fri, 26 Mar 2021 11:44:56 +0000 Received: by outflank-mailman (input) for mailman id 101713; Fri, 26 Mar 2021 11:44:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPktb-0000kM-GK for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:44:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPktb-0005jZ-Dp for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:44:55 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPktb-0007ur-C7 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:44:55 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPktX-0002IM-Nk; Fri, 26 Mar 2021 11:44:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=+UewVNXB5X7/GBZ2eWJSW9f/mfh+r1p/FoASrAd6zhA=; b=pRl2Fou9am8kJelT+JgHDczBgw wy9hVLMYoytrJR7EpfgBRTVzbjb4SfnDVJZzCfCeOFA99546ULCpqsqrpcvQE1at1zG2h0w4JHowM P8+irytrJfhGsfxY/DUBz8sU2Hv2/v31FZ6IIR498QLh5VQA+8dz7RVre2KfgEb04jy0=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.51507.523770.695347@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 11:44:51 +0000 To: Jan Beulich Cc: xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/2] Branching: Update version files etc. for newly unstable In-Reply-To: <0c938aa8-a954-55f5-7d21-37f2c10ea136@suse.com> References: <20210324162831.7587-1-iwj@xenproject.org> <0c938aa8-a954-55f5-7d21-37f2c10ea136@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH 1/2] Branching: Update version files etc. for newly unstable"): > I suppose you didn't mean to leave "-rc" in there? You are right. I will fix it in a moment. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 11:46:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 11:46:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101716.194686 (Exim 4.92) (envelope-from ) id 1lPkv4-0000rR-4U; Fri, 26 Mar 2021 11:46:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101716.194686; Fri, 26 Mar 2021 11:46:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkv4-0000rK-0P; Fri, 26 Mar 2021 11:46:26 +0000 Received: by outflank-mailman (input) for mailman id 101716; Fri, 26 Mar 2021 11:46:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkv3-0000rB-6D for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:46:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkv3-0005kx-5R for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:46:25 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPkv3-0007yZ-3Y for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:46:25 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPkuz-0002Iq-Oy; Fri, 26 Mar 2021 11:46:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:To:Date: Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=+eKoJVTrjcn6zLaYfAUlrGlZJq79N3zzDjZu59PLv9k=; b=Tvtaco5/0LJGc0WP6EpdcBjiLo RBvEtJYQ25svo6StoBUuFEQhsj4NDMSded/mD83JlY5fnEL3jOb61jElLmz2MZLZ6nwH6YvZiXNip 807Gd0oa0JXVy/ypRU/CunGA5+mmKHNy42xOIxZaomfMQHqsVv6cqY3Zb6PIIQA76X3I=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.51597.594171.236406@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 11:46:21 +0000 To: Jan Beulich , xen-devel@lists.xenproject.org, Andrew Cooper Subject: Re: [PATCH 1/2] Branching: Update version files etc. for newly unstable In-Reply-To: <24669.51507.523770.695347@mariner.uk.xensource.com> References: <20210324162831.7587-1-iwj@xenproject.org> <0c938aa8-a954-55f5-7d21-37f2c10ea136@suse.com> <24669.51507.523770.695347@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Ian Jackson writes ("Re: [PATCH 1/2] Branching: Update version files etc. for newly unstable"): > Jan Beulich writes ("Re: [PATCH 1/2] Branching: Update version files etc. for newly unstable"): > > I suppose you didn't mean to leave "-rc" in there? > > You are right. I will fix it in a moment. Oh Andy already did so. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 11:51:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 11:51:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101722.194697 (Exim 4.92) (envelope-from ) id 1lPkzP-0001zh-QU; Fri, 26 Mar 2021 11:50:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101722.194697; Fri, 26 Mar 2021 11:50:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkzP-0001za-NR; Fri, 26 Mar 2021 11:50:55 +0000 Received: by outflank-mailman (input) for mailman id 101722; Fri, 26 Mar 2021 11:50:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkzO-0001zS-5I; Fri, 26 Mar 2021 11:50:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkzO-0005pi-0t; Fri, 26 Mar 2021 11:50:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPkzN-0003Ix-M0; Fri, 26 Mar 2021 11:50:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPkzN-0007l0-LT; Fri, 26 Mar 2021 11:50:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ja70GHiadOg8Q5ugOqjudz3EiyIPYCM5O0aDBE1/nCw=; b=Y3cvKX0b1jN3hpYT/F798zVohC ThJzIFkA9mmM8WvDrD8BP8yi06dSCtS/9FlPZArZE83ptrxYqU6trrvnvSGQ1WzOyTkZG0+Mw0SPU 7hlBxA3x4ZltLdcAgMjY3+NGCtF6nDm4oH+CIBhhP90upELUVMMii0eNys5f9YS6vpkU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160410: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e138138003eb3b3d06cc91cf2e8c5dec77e2a31e X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Fri, 26 Mar 2021 11:50:53 +0000 flight 160410 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160410/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux e138138003eb3b3d06cc91cf2e8c5dec77e2a31e baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 237 days Failing since 152366 2020-08-01 20:49:34 Z 236 days 405 attempts Testing same since 160410 2021-03-25 08:21:03 Z 1 days 1 attempts ------------------------------------------------------------ 5261 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1306095 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Mar 26 11:54:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 11:54:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101727.194713 (Exim 4.92) (envelope-from ) id 1lPl2C-00028A-BD; Fri, 26 Mar 2021 11:53:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101727.194713; Fri, 26 Mar 2021 11:53:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPl2C-000283-8B; Fri, 26 Mar 2021 11:53:48 +0000 Received: by outflank-mailman (input) for mailman id 101727; Fri, 26 Mar 2021 11:53:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPl2A-00027y-Tc for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:53:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPl2A-0005tn-Pf for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:53:46 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPl2A-0008JN-Oq for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:53:46 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPl1z-0002K3-6Q; Fri, 26 Mar 2021 11:53:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=c5aNGwLinAeVYu9H8GNs+QPI3/kTyPAs2J8h1C8Rb1E=; b=AGkave4JlrKttIvwr/y0YS5Vfr tQC8HhvN3MgxCGx7JhGroyHfNUwsyPbOYz1Kx4O/7zyptA8xLFA5G9E7SDX46V6yITneE34ayjeJ3 A+fyIIL3gLHvJC9su06j2hNMXqcomgGK+Ogp5Zloow4DtuMWePq4fo4ruw1YSjwz2BTo=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.52030.995324.426028@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 11:53:34 +0000 To: Jan Beulich Cc: Boris Ostrovsky , andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com, xen-devel@lists.xenproject.org Subject: Re: [PATCH][4.15] Performance regression due to XSA-336 In-Reply-To: References: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH][4.15] Performance regression due to XSA-336"): > While the change is more intrusive than one would like at this point, an > up-to-40% regression imo makes this at least a change to be considered > for 4.15. I will admit though that before next week I won't get around > to look at this in any more detail than just having read through this > cover letter. But perhaps someone else might find time earlier. As I understand it: This amounts to a request to consider a release ack for "x86/vpt: Replace per-guest pt_migrate lock with per pt lock". That patch fixes a regression due to XSA-336. XSA-336 affected many versions of Xen. Therefore this is not a regression between 4.14 and 4.15; rather it's a regresion from pre-XSA-336 to post-XSA-336. I looked at the patch and I am really not comfortable with that kind of change at this stage of the release. So I'm afraid the answer is no, unless I have misunderstood something. Regards, Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 11:56:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 11:56:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101733.194725 (Exim 4.92) (envelope-from ) id 1lPl4f-0002Hu-RD; Fri, 26 Mar 2021 11:56:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101733.194725; Fri, 26 Mar 2021 11:56:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPl4f-0002Hn-Me; Fri, 26 Mar 2021 11:56:21 +0000 Received: by outflank-mailman (input) for mailman id 101733; Fri, 26 Mar 2021 11:56:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPl4e-0002Hh-7C for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:56:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPl4W-0005vn-Fv; Fri, 26 Mar 2021 11:56:12 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lPl4W-00008N-AQ; Fri, 26 Mar 2021 11:56:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=unXj0uiO50G30n+3QelLpUREJQwtOcnuPyn99KqDsIs=; b=cfay5yX2LQZ8FuTbsaoOilbaSu i1T2rf8APfkbhqtMqBROD6I/ov2kXeKSx8Nl4QMk8rpQQnRUuw2KuBEJvjtNxP7lcROWIOwZtUQRi hlxK7u8rh+V6p3pSUgHy82BkniYf4wOtcsg3ReANfxD4hX4gjPqEGDYeJHMGAAwt3/Ys=; Subject: Re: [PATCH for-next v2 2/2] xen/arm64: Place a speculation barrier following an ret instruction To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , "Xen.org security team" References: <20210313160611.18665-1-julien@xen.org> <20210313160611.18665-3-julien@xen.org> <50175d48-6f0b-2d96-8ea9-33f4f65f920f@xen.org> <342BA51C-80BE-4393-997E-6C5830CB57A1@arm.com> From: Julien Grall Message-ID: <4dd05515-b65e-e690-1891-5fd24400e385@xen.org> Date: Fri, 26 Mar 2021 11:56:10 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <342BA51C-80BE-4393-997E-6C5830CB57A1@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 26/03/2021 11:13, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, >> On 20 Mar 2021, at 13:13, Julien Grall wrote: >> >> (+ Security) >> >> >> On 17/03/2021 14:56, Bertrand Marquis wrote: >>> Hi Julien, >> >> Hi Bertrand, >> >>>> On 13 Mar 2021, at 16:06, Julien Grall wrote: >>>> >>>> From: Julien Grall >>>> >>>> Some CPUs can speculate past a RET instruction and potentially perform >>>> speculative accesses to memory before processing the return. >>>> >>>> There is no known gadget available after the RET instruction today. >>>> However some of the registers (such as in check_pending_guest_serror()) >>>> may contain a value provided by the guest. >>>> >>>> In order to harden the code, it would be better to add a speculation >>>> barrier after each RET instruction. The performance impact is meant to >>>> be negligeable as the speculation barrier is not meant to be >>>> architecturally executed. >>>> >>>> Rather than manually inserting a speculation barrier, use a macro >>>> which overrides the mnemonic RET and replace with RET + SB. We need to >>>> use the opcode for RET to prevent any macro recursion. >>>> >>>> This patch is only covering the assembly code. C code would need to be >>>> covered separately using the compiler support. >>>> >>>> This is part of the work to mitigate straight-line speculation. >>>> >>>> Signed-off-by: Julien Grall >>> The macro solution is definitely a great improvement compared to v1 and I could >>> confirm the presence of the sb in the generated code. >> >> Thanks for testing! It is indeed a lot nicer and less error-prone. We can thansk Jan for the idea as he originally introduced it on x86 :). >> >>> I also think that the mitigation on arm32/v7 would be messy to do. >> >> It is messy but not impossible :). Some of the assembly function could be rewritten in C to take advantage of the compiler mitigations. >> >> I went through the paper again today. Straight-line mitigation only refers to unconditional control flow change (e.g. RET) on AArch64 Armv8. >> >> A recent submission to LLVM seems to suggest that Armv7 and AArch32 Armv8 is also affected [2]. > > Thanks for the pointer :-) > >> >> So I think we only need to care of unconditional return instruction (e.g. mov pc, lr). >> >> For conditional return instructions, they would be treated as spectre v2 which we already mitigate. > > That would be a good idea but that would mean lots of invasive changes on armv7 and It is not quite clear which change you think is invasive... The change for adding a barrier after all unconditional return instruction is pretty straight-forward. Regarding conditional return instructions, then is nothing to do for straight-line speculation. > this is not the mostly tested architecture with Xen. To me this looks very subjective, how do you define "mostly tested"? From Xen Project perspective, we run the same test suite on arm64 and arm32 multiple time daily. I couldn't say the same for some of the Arm drivers in the tree. > Anyway I am happy to help reviewing this if it is done. > >> >>> Shall we mark v7/aarch32 as not security supported ? >> This would have consequence beyond just speculation. There might be processor out which are not affected by straight-line speculation and we would not issue any security update for them. So I am not in favor with this approach. >> >> What we could consider is mentioning in SUPPORT.MD that speculation attack using Straight-Line speculation are not security support on Arm (the 64-bit is not fully mitigated). > > Weird to say “not security supported” maybe saying not mitigated by Xen would be more clear. I am open for the wording :). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Mar 26 11:58:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 11:58:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101739.194737 (Exim 4.92) (envelope-from ) id 1lPl6x-0002gf-Cw; Fri, 26 Mar 2021 11:58:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101739.194737; Fri, 26 Mar 2021 11:58:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPl6x-0002gY-9d; Fri, 26 Mar 2021 11:58:43 +0000 Received: by outflank-mailman (input) for mailman id 101739; Fri, 26 Mar 2021 11:58:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPl6v-0002gT-Td for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:58:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPl6v-0005zt-SP for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:58:41 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPl6v-0000EA-Q1 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 11:58:41 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPl6s-0002Ns-Dp; Fri, 26 Mar 2021 11:58:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=40SCwoy52KEhslfGLhSAz1yNVsyeEsgt7AvCDNi10I4=; b=xqUaljyrLa/RLlvlwR8n/Sa5oN KlVPxEEN/y1ohxv1yM6N/1PVBhV1MCy5LdAfCZQQDI/DyuYbevvLDT9dkqXYNvYMphGusIYFHnnfr Pn0HtZK0ai6z+zo/xHTbIi/bY3wHGZZ5mTK5VluOm/xxFzQZoe9XePrhFV1PairUxSBY=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.52334.265626.387095@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 11:58:38 +0000 To: Roger Pau Monne Cc: , Community Manager Subject: Re: [PATCH for-4.15] changelog: note MSR access change In-Reply-To: <20210325162032.81348-1-roger.pau@citrix.com> References: <20210325162032.81348-1-roger.pau@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Roger Pau Monne writes ("[PATCH for-4.15] changelog: note MSR access change"): > The change to deny all accesses to MSRs indexes not explicitly handled > prevents leaking unwanted data into guests. Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Fri Mar 26 12:03:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 12:03:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101748.194752 (Exim 4.92) (envelope-from ) id 1lPlBv-0003cR-7t; Fri, 26 Mar 2021 12:03:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101748.194752; Fri, 26 Mar 2021 12:03:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlBv-0003cK-4T; Fri, 26 Mar 2021 12:03:51 +0000 Received: by outflank-mailman (input) for mailman id 101748; Fri, 26 Mar 2021 12:03:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlBt-0003cF-93 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:03:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlBt-000675-70 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:03:49 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPlBt-0000fM-5H for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:03:49 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPlBp-0002Oh-N7; Fri, 26 Mar 2021 12:03:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=EjMvcT9xppmrzc6TwqrFBgO/liBMzrBGAoZU7LBBZzU=; b=sWlbBhPLdOKF8kpLcLVjVT78wW psGoklEZ64Ca1IBXUM8WxESdXqmwVyYAGvCOAO6UrCHDXADsuMlv6bShlQUtmKeRjEwtj6Pl/v1j9 +97huQvBk7XWmy/BumIdKPS2JvR450lDcnGhrAyB/7zS/1ZNYFoABqFCLE5GyOUgkmDA=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.52641.499147.88002@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 12:03:45 +0000 To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , =?iso-8859-1?Q?Fr=E9d=E9ric?= Pierret Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally In-Reply-To: <20210325172132.14980-1-andrew.cooper3@citrix.com> References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally"): > From: Jan Beulich > > Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC > static PIT clock gating") was reported to cause boot failures on certain > AMD Ryzen systems. > > Refine the fix to do nothing in the default case, and only attempt to > configure legacy replacement mode if IRQ0 is found to not be working. > > In addition, introduce a "hpet" command line option so this heuristic > can be overridden. Since it makes little sense to introduce just > "hpet=legacy-replacement", also allow for a boolean argument as well as > "broadcast" to replace the separate "hpetbroadcast" option. I'm sorry, but I think it is too late for 4.15 to do this. I prefer Jan's patch which I have alread release-acked. Can someone qualified please provide a maintainer review for this, ideally today ? Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 12:05:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 12:05:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101751.194763 (Exim 4.92) (envelope-from ) id 1lPlDG-0003kz-It; Fri, 26 Mar 2021 12:05:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101751.194763; Fri, 26 Mar 2021 12:05:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlDG-0003ks-Fw; Fri, 26 Mar 2021 12:05:14 +0000 Received: by outflank-mailman (input) for mailman id 101751; Fri, 26 Mar 2021 12:05:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlDE-0003kh-Hb for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:05:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlDE-00068I-Fu for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:05:12 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPlDE-0000jI-F5 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:05:12 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPlDB-0002PO-0X; Fri, 26 Mar 2021 12:05:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=xkq1JLZu1IBIJIyAfG0d5ftkBLcvygCWFDE2TuHqVYQ=; b=lNU47e1zF2qzz6Jfl84d07To5X WzWSsvydioGNdeR7Gp2oqI+kINUzWFWtcLNdq83ob6HgaQFNTzYmCnMpVnPm6txDywWbWfKTdlN9d mGKRVZhYjclBsJ9ZgvWrY91v+s8G2yEpw3iO6c+xaNkx28hyj39Bh9NIEhyZsevPgfPE=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.52724.843848.16707@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 12:05:08 +0000 To: Julien Grall Cc: xen-devel@lists.xenproject.org, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , raphning@gmail.com, jgross@suse.com, paul@xen.org Subject: Re: [PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME In-Reply-To: <20210325180607.13158-1-julien@xen.org> References: <20210325180607.13158-1-julien@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("[PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME"): > From: Julien Grall > > Commit 13dd372834a4 removed the documentation for XS_RESUME, however > this command is still implemented (at least in C Xenstored) and used by > libxl when resuming a domain. > > So re-instate the documentation for the XS_RESUME. Take the opportunity > to update it as there is a user of the command. This is just docs, so: Release-Acked-by: Ian Jackson Reviewed-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Fri Mar 26 12:05:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 12:05:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101752.194776 (Exim 4.92) (envelope-from ) id 1lPlDX-0003pp-Rt; Fri, 26 Mar 2021 12:05:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101752.194776; Fri, 26 Mar 2021 12:05:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlDX-0003pi-Ow; Fri, 26 Mar 2021 12:05:31 +0000 Received: by outflank-mailman (input) for mailman id 101752; Fri, 26 Mar 2021 12:05:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlDX-0003pb-5b for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:05:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlDX-00068w-4p for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:05:31 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPlDX-0000lo-47 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:05:31 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPlDT-0002Px-Qs; Fri, 26 Mar 2021 12:05:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=sxMftzVO4rhCfs0sMFoUzHUCONowjcnv5n2bpgJrDxw=; b=4KJUIuLk7lrRdRISoEfeMaaqkd AyE6c7yTjUN/rA+etdBsNTtmYGOSTCUYBJyshJJRmaf00iwSweYaFaVFZNAbUqwIVqjXGPCx2rX2J b3tkkZxJAi653LE2sUlCs8qHxSYarxrftJ1LssPbOZJA2WPnbnuLirfrW+q/EtvH2x5Q=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.52743.650789.478215@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 12:05:27 +0000 To: Andrew Cooper Cc: Xen-devel , Wei Liu Subject: Re: [PATCH] tools/libfsimage: Bump SONAME to 4.16 In-Reply-To: <20210325194201.10998-1-andrew.cooper3@citrix.com> References: <20210325194201.10998-1-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH] tools/libfsimage: Bump SONAME to 4.16"): > Fixes: a04509d34d ("Branching: Update version files etc. for newly unstable") > Signed-off-by: Andrew Cooper Release-Acked-by: Ian Jackson Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Fri Mar 26 12:06:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 12:06:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101757.194788 (Exim 4.92) (envelope-from ) id 1lPlEe-0003yR-6X; Fri, 26 Mar 2021 12:06:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101757.194788; Fri, 26 Mar 2021 12:06:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlEe-0003yK-3O; Fri, 26 Mar 2021 12:06:40 +0000 Received: by outflank-mailman (input) for mailman id 101757; Fri, 26 Mar 2021 12:06:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlEd-0003yD-Ci for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:06:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlEd-0006AD-Bu for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:06:39 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPlEd-0000pJ-BD for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:06:39 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPlEa-0002QG-09; Fri, 26 Mar 2021 12:06:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=Wz8piiJHDK2vi4SkKPPmew2L/Pp6ebgSx6gSK567z9M=; b=nfDFUL74BRj7vBzQzxXChBetMX mKXli+M+d1ozE2D7gwhcE5jXMOn0FfbAORezJp6EnRBbwmpqVp3TCTpoQJkj8xKV6H0ePzlEHIKku tp3/IeCovH5rj6XK1dBdQuGH2ZiH199MxV8Hr2SOjOgxBp6Bl2Vs7mAq9uoVI11b2o0A=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.52811.830365.356741@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 12:06:35 +0000 To: Julien Grall Cc: xen-devel@lists.xenproject.org, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , raphning@gmail.com, edvin.torok@citrix.com, jgross@suse.com Subject: Re: [PATCH for-4.15?] docs/design: Update xenstore-migration.md In-Reply-To: <20210325111255.16330-1-julien@xen.org> References: <20210325111255.16330-1-julien@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("[PATCH for-4.15?] docs/design: Update xenstore-migration.md"): > From: Julien Grall > > It is not very clear the shared page adddress is not contained in the > connection record. Additionally, it is misleading to say the grant > will always point to the share paged as a domain is free to revoke the > permission. The restore code would need to make sure it doesn't > fail/crash if this is happening. > > The sentence is now replaced with a paragraph explaining why the GFN is > not preserved and that the grant is not guarantee to exist during > restore. > > Take the opportunity to replace "code" with "node" when description the > permission. > > Reported-by: Raphael Ning > Signed-off-by: Julien Grall Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Fri Mar 26 12:15:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 12:15:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101761.194802 (Exim 4.92) (envelope-from ) id 1lPlMn-0005Cb-2a; Fri, 26 Mar 2021 12:15:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101761.194802; Fri, 26 Mar 2021 12:15:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlMm-0005CU-Vs; Fri, 26 Mar 2021 12:15:04 +0000 Received: by outflank-mailman (input) for mailman id 101761; Fri, 26 Mar 2021 12:15:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlMm-0005CP-2c for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:15:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlMh-0006Jd-Um; Fri, 26 Mar 2021 12:14:59 +0000 Received: from [54.239.6.186] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lPlMh-0001Ya-Ky; Fri, 26 Mar 2021 12:14:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=7/dDvDLr/niqO0+2gQPe1FkOyq1Z3qKc2VWN3Vh8fKc=; b=v1knQatRJgew/fK6/1s791bo4F llk9YnqRIqSKvnoy/9ayapsrLSdUBFnQbcHh5XYiCyRr2Ypn7DtWn/RpFuWWOTzxinE8d35sIlF5I BSJLTRGdvCCTTDik6+n+z6s1T0uU98z5p8Sk9r9CsAE7R+IHpFvomR/+zzY7ClkuxA14=; Subject: Re: [PATCH for-4.15?] docs/design: Update xenstore-migration.md To: Ian Jackson Cc: xen-devel@lists.xenproject.org, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , raphning@gmail.com, edvin.torok@citrix.com, jgross@suse.com References: <20210325111255.16330-1-julien@xen.org> <24669.52811.830365.356741@mariner.uk.xensource.com> From: Julien Grall Message-ID: Date: Fri, 26 Mar 2021 12:14:57 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <24669.52811.830365.356741@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Ian, On 26/03/2021 12:06, Ian Jackson wrote: > Julien Grall writes ("[PATCH for-4.15?] docs/design: Update xenstore-migration.md"): >> From: Julien Grall >> >> It is not very clear the shared page adddress is not contained in the >> connection record. Additionally, it is misleading to say the grant >> will always point to the share paged as a domain is free to revoke the >> permission. The restore code would need to make sure it doesn't >> fail/crash if this is happening. >> >> The sentence is now replaced with a paragraph explaining why the GFN is >> not preserved and that the grant is not guarantee to exist during >> restore. >> >> Take the opportunity to replace "code" with "node" when description the >> permission. >> >> Reported-by: Raphael Ning >> Signed-off-by: Julien Grall > > Release-Acked-by: Ian Jackson Thanks! I have committed the patch to staging and cherry-pick in staging-4.15. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Mar 26 12:15:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 12:15:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101764.194814 (Exim 4.92) (envelope-from ) id 1lPlNC-0005HM-BZ; Fri, 26 Mar 2021 12:15:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101764.194814; Fri, 26 Mar 2021 12:15:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlNC-0005HF-8Y; Fri, 26 Mar 2021 12:15:30 +0000 Received: by outflank-mailman (input) for mailman id 101764; Fri, 26 Mar 2021 12:15:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlNA-0005H4-AK for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:15:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlN6-0006KI-GL; Fri, 26 Mar 2021 12:15:24 +0000 Received: from [54.239.6.186] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lPlN6-0001Zo-AY; Fri, 26 Mar 2021 12:15:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=LfvwKyVj0+Cko72N9E7erksqyOZgqlmrcWrG6f29bvE=; b=PJbDpeBGbeiVKvwoVuQ0xm5NZA P3KRfci1uGD3rfkhONNtm6ufqq7vCeI8gYWZR+1lhr/nSeO6NsQAiieB2+x6ZC6gK/8xbaCizORPa OrZ4Evdvsji3Ve+3F7ZdwqZjANyCpsL5lu9tFxWJG0jeN/OaZT3i+YvMaRtloxNgTiP0=; Subject: Re: [PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME To: Ian Jackson Cc: xen-devel@lists.xenproject.org, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , raphning@gmail.com, jgross@suse.com, paul@xen.org References: <20210325180607.13158-1-julien@xen.org> <24669.52724.843848.16707@mariner.uk.xensource.com> From: Julien Grall Message-ID: <5167ebbb-aa44-6cb8-583f-2356442bf004@xen.org> Date: Fri, 26 Mar 2021 12:15:21 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <24669.52724.843848.16707@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Ian, On 26/03/2021 12:05, Ian Jackson wrote: > Julien Grall writes ("[PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME"): >> From: Julien Grall >> >> Commit 13dd372834a4 removed the documentation for XS_RESUME, however >> this command is still implemented (at least in C Xenstored) and used by >> libxl when resuming a domain. >> >> So re-instate the documentation for the XS_RESUME. Take the opportunity >> to update it as there is a user of the command. > > This is just docs, so: > > Release-Acked-by: Ian Jackson > Reviewed-by: Ian Jackson Thanks! I have committed the patch to staging and cherry-pick in staging-4.15. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Mar 26 12:15:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 12:15:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101765.194822 (Exim 4.92) (envelope-from ) id 1lPlNC-0005Hx-NK; Fri, 26 Mar 2021 12:15:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101765.194822; Fri, 26 Mar 2021 12:15:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlNC-0005Hh-HI; Fri, 26 Mar 2021 12:15:30 +0000 Received: by outflank-mailman (input) for mailman id 101765; Fri, 26 Mar 2021 12:15:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlNB-0005HA-N8 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:15:29 +0000 Received: from MTA-12-4.privateemail.com (unknown [198.54.127.107]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fffa94fa-e358-435d-8aef-551e3cddb43c; Fri, 26 Mar 2021 12:15:28 +0000 (UTC) Received: from mta-12.privateemail.com (localhost [127.0.0.1]) by mta-12.privateemail.com (Postfix) with ESMTP id A40E78005A for ; Fri, 26 Mar 2021 08:15:27 -0400 (EDT) Received: from mail-wr1-f52.google.com (unknown [10.20.151.231]) by mta-12.privateemail.com (Postfix) with ESMTPA id 6DE9E800AE for ; Fri, 26 Mar 2021 08:15:27 -0400 (EDT) Received: by mail-wr1-f52.google.com with SMTP id x7so5409159wrw.10 for ; Fri, 26 Mar 2021 05:15:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fffa94fa-e358-435d-8aef-551e3cddb43c X-Gm-Message-State: AOAM5333YLN4phqFgPJjy2bbc0CN18GXn4Kgj6zZe/V3pdDHChDboCIv WmYHdTQtrJyL7EOr35AIE0rHZ7mSgbmnMgjZDA8= X-Google-Smtp-Source: ABdhPJyeZh2OfJlthH8JqGbmtxakhh2aJ40t4HwlSLjvMtH3XQ7kbzbbuqsMaky3GrREd4dzOIv6ETrCiuKvkgbNI/0= X-Received: by 2002:a05:6000:1868:: with SMTP id d8mr14368904wri.301.1616760926206; Fri, 26 Mar 2021 05:15:26 -0700 (PDT) MIME-Version: 1.0 References: <24669.51029.465080.822794@mariner.uk.xensource.com> In-Reply-To: <24669.51029.465080.822794@mariner.uk.xensource.com> From: Tamas K Lengyel Date: Fri, 26 Mar 2021 08:14:50 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking To: Ian Jackson Cc: Tamas K Lengyel , Xen-devel , Jan Beulich , Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Mar 26, 2021 at 7:37 AM Ian Jackson wrote: > > Tamas K Lengyel writes ("Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking"): > > On Thu, Mar 18, 2021 at 5:36 PM Tamas K Lengyel wrote: > > > > > > When creating a VM fork copy the parent VM's hostp2m max_mapped_pfn value. Some > > > toolstack relies on the XENMEM_maximum_gpfn value to establish the maximum > > > addressable physical memory in the VM and for forks that have not yet been > > > unpaused that value is not going to reflect the correct max gpfn that's > > > possible to populate into the p2m. This patch fixes the issue. > ... > > CC-ing Ian as 4.15 release manager. This patch is safe to include in > > 4.15 as it's a minor fix in a tech preview feature that's not even > > compiled by default. > > As far as I can tell this patch is lacking a maintainer review ? > > Release-Acked-by: Ian Jackson > > *Provided that it is committed today* I'm not sure how likely that is. Thanks, as I'm the sole maintainer of the code AFAIU it just needs a Reviewed-by from someone in the community. Tamas From xen-devel-bounces@lists.xenproject.org Fri Mar 26 12:30:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 12:30:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101774.194856 (Exim 4.92) (envelope-from ) id 1lPlbI-0007F9-8N; Fri, 26 Mar 2021 12:30:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101774.194856; Fri, 26 Mar 2021 12:30:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlbI-0007F2-1T; Fri, 26 Mar 2021 12:30:04 +0000 Received: by outflank-mailman (input) for mailman id 101774; Fri, 26 Mar 2021 12:30:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlbG-00075t-QV for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:30:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlbG-0006Zs-L9 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:30:02 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPlbG-0002mr-Hw for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:30:02 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPlbB-0002U7-BL; Fri, 26 Mar 2021 12:29:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:CC:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=kuqU7UGFtqlF21kRS5Le7NiFuiCjs3/tyZNP8WZKr8M=; b=gTLZKUSjx5lZFpM0Cz+Px4nJu/ L4meU61Gr/bkcxJnr21SayVXmBDYEzotlEkfYv3zuEoRTLssflazezO7JhwHim4T6ZBa0UoISpMvJ 2u7Ep8TmvVjc87RkaVa2pILYD9D86CwNvcVKEhkmI7pQWNK4OH+ZSCCprjwgGg/BKhIk=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.54213.173154.400771@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 12:29:57 +0000 To: Roger Pau =?iso-8859-1?Q?Monn=E9?= CC: Andrew Cooper , Xen-devel , Jan Beulich , Wei Liu , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , =?iso-8859-1?Q?Fr=E9d=E9ric?= Pierret Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally In-Reply-To: <24669.52641.499147.88002@mariner.uk.xensource.com> References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <24669.52641.499147.88002@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) I wrote: > I'm sorry, but I think it is too late for 4.15 to do this. I prefer > Jan's patch which I have alread release-acked. > > Can someone qualified please provide a maintainer review for this, > ideally today ? I asked Andrew on IRC: 12:08 andyhhp__: Are you prepared to maintainer-ack Jan's more-minimal hpet workaround approach ? 12:16 Diziet: honestly, no. I don't consider that acceptable behaviour, and it is a fairly big "f you" (this was literally feedback I got in private) to the downstreams who've spent years trying to get us to fix this bug, and have now backported the first version. 12:16 I'm looking into the feedback on my series 12:17 one way or another, the moment we enter the fallback path for interrupt routing, something is very broken on the system 12:19 so the tradeoff is an unspecified bug on one ancient laptop which can't be tested now, vs 5 years of Atom CPUs, 2 years of latop CPUs, and the forthcoming Server line of Intel CPUs 12:19 or whatever other compromise we can work on I'm sorry that this bug is going to continue to be not properly fixed. As I understand it the practical impact is that users of those affected systems (the newer ones you mention) will have to add a command-line option. That is, unfortunately, the downside of time-based releases. If we had been having this conversation two weeks ago I would have very likely had a different answer. I consider the current situation in xen.git#staging-4.15 a blocker for the release and I want to get the code finalised. I hope that Monday's RC will be the last RC and that after that there will be only docs changes. That would mean committing a workaround today. Roger, would you be able to give me a maintainer review of Jan's [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally ? Andrew, I don't think you have, so far, Nak'd Jan's patch. If you feel it warrants your Nak please provide it ASAP. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 12:31:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 12:31:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101780.194867 (Exim 4.92) (envelope-from ) id 1lPlca-0007od-JI; Fri, 26 Mar 2021 12:31:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101780.194867; Fri, 26 Mar 2021 12:31:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlca-0007oW-G1; Fri, 26 Mar 2021 12:31:24 +0000 Received: by outflank-mailman (input) for mailman id 101780; Fri, 26 Mar 2021 12:31:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlcY-0007oR-Gq for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:31:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPlcY-0006at-FU for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:31:22 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPlcY-0002tA-EW for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 12:31:22 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPlcT-0002VQ-Dm; Fri, 26 Mar 2021 12:31:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=L0Ix2geYvQVDiYJ7wWkZqepheNuSxsiYklmbGncft6w=; b=uaSwuCY7NqsDDcF3zwfXdMAM6G WOTwvuDTFTRkYt6fr+ObZIB5ZShHkvf1Wgf4eUocA+ayXifIwIKRyCvR9N/Be/e7cObsB/u06WtIp 69Jr9EInE+Zb7mFdRxX2F3abQsPxYLITJaGf+6zIQWTFw31tKYYFJNPsFUpE60AGxTxk=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.54293.249916.792148@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 12:31:17 +0000 To: Tamas K Lengyel Cc: Tamas K Lengyel , Xen-devel , Jan Beulich , Andrew Cooper , George Dunlap , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu Subject: Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking In-Reply-To: References: <24669.51029.465080.822794@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Tamas K Lengyel writes ("Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking"): > On Fri, Mar 26, 2021 at 7:37 AM Ian Jackson wrote: > > Release-Acked-by: Ian Jackson > > > > *Provided that it is committed today* I'm not sure how likely that is. > > Thanks, as I'm the sole maintainer of the code AFAIU it just needs a > Reviewed-by from someone in the community. I don't feel qualified myself, unfortunately. But your argument in favour of having this in 4.15 seems very strong to me so I definitely hope someone is able to do the review. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 13:05:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 13:05:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101784.194879 (Exim 4.92) (envelope-from ) id 1lPm8l-0002us-5V; Fri, 26 Mar 2021 13:04:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101784.194879; Fri, 26 Mar 2021 13:04:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPm8l-0002ul-2b; Fri, 26 Mar 2021 13:04:39 +0000 Received: by outflank-mailman (input) for mailman id 101784; Fri, 26 Mar 2021 13:04:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPm8j-0002ug-Cl for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:04:37 +0000 Received: from mail-wr1-x42d.google.com (unknown [2a00:1450:4864:20::42d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9562b249-3f54-4c5e-ac60-5e67ac6dc2fb; Fri, 26 Mar 2021 13:04:36 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id e18so5583359wrt.6 for ; Fri, 26 Mar 2021 06:04:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9562b249-3f54-4c5e-ac60-5e67ac6dc2fb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m2UYKX1/6zIOYAC/KKX0/ymawhTpBnOIv7CFkEyzlSs=; b=mUgplqPkaKnxTdy+5bVbhxtwFpI2yllZmXNBDMXneawgbOOevyOsmtkJQ0afiJPwpa r1gFvIi/zCnz5dMtoegJ6imdKk+KbK9m8S/AKFbICLYPqEJc7ZkpPuBwmSPKl+wLsgja /5P09PgsBYWbeTeEHjK+6QybBwIpwkJXdbF+ohHMxYsn9QT0Kwt8NspA1WJQbiKgeqiR JPSCHnfamjXUCu5S4PdFm9sLvCXBOAI6eQWMvgc5QkavM7tozvV/jeZkoa8/HFnvau3M kr+aJ/OgazC2hECGKGhDEe/mQ8En4e47T8GzwuI/ke3rTGX9XsqHzUbWowg/Gz9dGj3r pKxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m2UYKX1/6zIOYAC/KKX0/ymawhTpBnOIv7CFkEyzlSs=; b=YMquWsgvt2wzUhozCPSkrhktmdNME8NS+r4dbkM//k6C5cJK/bR9fgJEwZeUv8ZIrW kJiKFtadC1EzPTwOeXZMpQQFV1buu2K+QgpWdocs+miuWGCynncDkr+Gbswmbz9UeeUi FiuK1BqGNwruFI5x6zqNxyLuY8QhTg5Yf0H3mcQIM7kYKM0o2lzG/+9Sdv7ugU9O2wOL lhF2J/suHl4xku9KzlRcm6WEuAPEagJ6BTJWpSBMTz0EylCQGjfvFJjKNCGfMVwrXC/J nQ3bnjxhU6vKg05PcJ3S+Tb9W8t3vK00HmO/qZMmE/buTswnkksUUx3wpaHEnuMjhCTD F7ug== X-Gm-Message-State: AOAM531u5oDZHfHWektbrUo1HGoQLAHldz61WF4jAwZRPqOR23OJHzCO +Hzn21qQ2cPulqycrFPUPQEy7vfynkznpIKuhfM3atWUUHA= X-Google-Smtp-Source: ABdhPJwiPTI5KGtfazkuvGAbZ/9IvwFCYq5OC14Lvik92Rp1JDazoRkeeM+GvVblBdcqvIm43p0IxB6dD39u6tCUyXw= X-Received: by 2002:a5d:4bcb:: with SMTP id l11mr11477696wrt.390.1616763875399; Fri, 26 Mar 2021 06:04:35 -0700 (PDT) MIME-Version: 1.0 References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <24669.52641.499147.88002@mariner.uk.xensource.com> <24669.54213.173154.400771@mariner.uk.xensource.com> In-Reply-To: <24669.54213.173154.400771@mariner.uk.xensource.com> From: Tamas K Lengyel Date: Fri, 26 Mar 2021 09:03:59 -0400 Message-ID: Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally To: Ian Jackson Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Andrew Cooper , Xen-devel , Jan Beulich , Wei Liu , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= Content-Type: text/plain; charset="UTF-8" On Fri, Mar 26, 2021 at 8:30 AM Ian Jackson wrote: > > I wrote: > > I'm sorry, but I think it is too late for 4.15 to do this. I prefer > > Jan's patch which I have alread release-acked. > > > > Can someone qualified please provide a maintainer review for this, > > ideally today ? > > I asked Andrew on IRC: > > 12:08 andyhhp__: Are you prepared to maintainer-ack Jan's > more-minimal hpet workaround approach ? > 12:16 Diziet: honestly, no. I don't consider that > acceptable behaviour, and it is a fairly big "f you" > (this was literally feedback I got in private) to > the downstreams who've spent years trying to get us > to fix this bug, and have now backported the first > version. > 12:16 I'm looking into the feedback on my series > 12:17 one way or another, the moment we enter the fallback > path for interrupt routing, something is very broken > on the system > 12:19 so the tradeoff is an unspecified bug on one ancient > laptop which can't be tested now, vs 5 years of Atom > CPUs, 2 years of latop CPUs, and the forthcoming > Server line of Intel CPUs > 12:19 or whatever other compromise we can work on > > I'm sorry that this bug is going to continue to be not properly fixed. > As I understand it the practical impact is that users of those > affected systems (the newer ones you mention) will have to add a > command-line option. That is, unfortunately, the downside of > time-based releases. If we had been having this conversation two > weeks ago I would have very likely had a different answer. The problem from my perspective is that the end-users have no way to determine when that boot option is needing to be set. Having an installation step of "check if things explode when you reboot" is just plain bad. Many times you don't even have access to a remote serial console to check why Xen didn't boot. So that's not a realistic route that can be taken. If Jan's patch is applied then the only thing I'll be able to do is make all installations always-enable this option even on systems that would have booted fine otherwise without it. It is unclear if that has any downsides of its own and could very well just kick the can down the road and lead to other issues. Tamas From xen-devel-bounces@lists.xenproject.org Fri Mar 26 13:07:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 13:07:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101787.194891 (Exim 4.92) (envelope-from ) id 1lPmBc-00032e-KZ; Fri, 26 Mar 2021 13:07:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101787.194891; Fri, 26 Mar 2021 13:07:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmBc-00032X-HQ; Fri, 26 Mar 2021 13:07:36 +0000 Received: by outflank-mailman (input) for mailman id 101787; Fri, 26 Mar 2021 13:07:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmBb-00032R-58 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:07:35 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown [40.107.6.85]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1cb5965a-2d3a-4813-9744-f358194c4ec7; Fri, 26 Mar 2021 13:07:32 +0000 (UTC) Received: from DU2PR04CA0021.eurprd04.prod.outlook.com (2603:10a6:10:3b::26) by AM9PR08MB6851.eurprd08.prod.outlook.com (2603:10a6:20b:305::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Fri, 26 Mar 2021 13:07:30 +0000 Received: from DB5EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3b:cafe::e7) by DU2PR04CA0021.outlook.office365.com (2603:10a6:10:3b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.26 via Frontend Transport; Fri, 26 Mar 2021 13:07:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT041.mail.protection.outlook.com (10.152.21.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Fri, 26 Mar 2021 13:07:29 +0000 Received: ("Tessian outbound 31ead7df1201:v89"); Fri, 26 Mar 2021 13:07:29 +0000 Received: from d693723aa2d8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7D54F43C-79F3-4F55-A7C6-8376C887D34B.1; Fri, 26 Mar 2021 13:07:12 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d693723aa2d8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 26 Mar 2021 13:07:12 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) by VE1PR08MB4814.eurprd08.prod.outlook.com (2603:10a6:802:ad::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Fri, 26 Mar 2021 13:07:11 +0000 Received: from VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::b538:7f7:f4f3:8c0e]) by VE1PR08MB5696.eurprd08.prod.outlook.com ([fe80::b538:7f7:f4f3:8c0e%7]) with mapi id 15.20.3977.029; Fri, 26 Mar 2021 13:07:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cb5965a-2d3a-4813-9744-f358194c4ec7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yuEPvYi5Wn+X7zF7YvqqlOAiF/t9G0fQJ+M/+xlpEAI=; b=4xf9vHeCnRZU0ctaSHzVffH/k0fdRWtRfAc8Y/HTUTMgLl1RM+Jl/4OIfZbUQI+UuwPR4/AOlAsthB04gJqqVej3xD6jpvTyGL0GHZnOQndbGCd3btHUP2jl7Mu0d0QeeSJTFFEUMBJCsQACpl7s3MaXjMdAl/N4Rw3R1YPyjZU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 590aed3a4b8d8d0e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IWjZG99rA1VED2ShZPIvSM4zE+g2qNxlzTOnB/YVGXiDYsvWO1lQ7miE4NRMYJYdev0uNhfFUZ/qZCIw9sePMIETZb+CtFXegjpLMEBnCBHbqYZpf7tviJT1VWJF/iQDDed9b+/0ItcjppqlPHOJ08f/DgtqDV1VPviwJvXc2gS3zeqLj9KUBlPbrymyULJyvaROwOQYysJfugKAcCAP7FV5CCEz1R7gp1I6Rq/Uf4yyLtUHlJL/JIZXTdhG0xbQU1I266RMmtILDpycD948T9BTfTEv61Wp1MBuneJC9NBvVrClWuDpsxG2nMH49na2KpbgAY4FF0H+Q4Vpms+mug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yuEPvYi5Wn+X7zF7YvqqlOAiF/t9G0fQJ+M/+xlpEAI=; b=id8rwZBddi+y8lo7kmHvawSV23G9sJp8CuuPq9C/cmmuRh306I00RZt+79a77r58Mnzsa2juyGCM1V0cf6N81yviilKkeScAKACXEkj2bWvjvISpn2+DCFakmz0C9GatXTnl0gMZTkINF2G53rFYa6PO1CfNp7RbSeLHE2Z6TCqM04BdMowWgzpUVkJYhCnc6lqIEIDF338gMGCoOq9pf0h4oqjiF0r9cxyPZrc31ieVx+zlXnPTIdyNLlykwf7XZ5aJO1gqbkfkFNZceI4yLV+m3lj0nZOSfae+FpXq2+jKdgsKrw5c3wIctgGdMCk1cgyHIMyC04oVIeY500IW/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yuEPvYi5Wn+X7zF7YvqqlOAiF/t9G0fQJ+M/+xlpEAI=; b=4xf9vHeCnRZU0ctaSHzVffH/k0fdRWtRfAc8Y/HTUTMgLl1RM+Jl/4OIfZbUQI+UuwPR4/AOlAsthB04gJqqVej3xD6jpvTyGL0GHZnOQndbGCd3btHUP2jl7Mu0d0QeeSJTFFEUMBJCsQACpl7s3MaXjMdAl/N4Rw3R1YPyjZU= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Xen.org security team Subject: Re: [PATCH for-next v2 2/2] xen/arm64: Place a speculation barrier following an ret instruction Thread-Topic: [PATCH for-next v2 2/2] xen/arm64: Place a speculation barrier following an ret instruction Thread-Index: AQHXGCLUePNZXth41EOpDgjR62uDxqqISyAAgASaOICACUyKAIAAC94AgAAT1gA= Date: Fri, 26 Mar 2021 13:07:11 +0000 Message-ID: <05231AC7-484B-48A6-8A5B-119DFB705DF0@arm.com> References: <20210313160611.18665-1-julien@xen.org> <20210313160611.18665-3-julien@xen.org> <50175d48-6f0b-2d96-8ea9-33f4f65f920f@xen.org> <342BA51C-80BE-4393-997E-6C5830CB57A1@arm.com> <4dd05515-b65e-e690-1891-5fd24400e385@xen.org> In-Reply-To: <4dd05515-b65e-e690-1891-5fd24400e385@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.99.251] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f4330770-40ea-4bb0-d539-08d8f0581c8c x-ms-traffictypediagnostic: VE1PR08MB4814:|AM9PR08MB6851: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 5Drzv8BW74uO2XzOZBDdAE3baesmVfxFqH5KkfwKKjzn3ioPkc+HgZsQvbywpnU3CoTjiqhkzuCcc6/AzY6Pfgm8WYmxfy8rDCvbK2z3IdTHhBDmGAZAJurrw2Dz597rzE/+pa9aCX6rpCjqe68JtncjyI+wiZKle3dY5pyOmJmiuOA40tx7+SVfdrHOo5XU4tZYq7D21HmV6ItikkJ0gTesQbvOyxq5pDEu/GzL7OwHu5H7lcvn2FcbB85e2xDV8+lCC1+8vnzLPJ7ldJI5mNDVSDc32RLmMfUFIgm7xsicf0VFPf9KKdSHwrO82C+dbJo2yT0qY5h1g4K27NACE4BGdYQQcRuUHM3I3ZtjQknR0KW4ZkGwqXwecKvdpBsNKKwvnoaYShhk6MyBbG+yORVIcquAJo1OfDR5mQV22NxER2z+kQY2BN61Gw813QmMFVXFklibz3FbHa5cxrHSeql60QICgcheXl1YkBC6EeyA9hanYI2qDV+Ls6XEVycadwFZAm8p8Ez9q9q8U1zJRyuhI9g49ZD2S19vy4Z+LxRfXhdvq5txugSIFv7YfWdh4qDl3YGC49+hEsfqUi2c6Y5aAv8dsABJrrtPAI14AxIJf8UA9svJaodHSLwH0nv93D4iJwbkRx2vNKBSN0Dyg47y4Ez1IUgfzHFbnt6T90/p1aEKHcndSfRE3pXn1g17 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(396003)(366004)(39860400002)(346002)(6506007)(186003)(53546011)(66946007)(8936002)(6512007)(91956017)(5660300002)(76116006)(2906002)(66446008)(83380400001)(64756008)(66556008)(316002)(66476007)(2616005)(26005)(54906003)(8676002)(86362001)(38100700001)(6916009)(478600001)(4326008)(71200400001)(36756003)(6486002)(33656002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?K3d4Z0lHRHVYU3lOeTVkaUlMN3ZLY0YwWUdFZk0vUUtjZ1UzV2tLLzA4c0xJ?= =?utf-8?B?aW1BUWVGb3dRcVVNdGU1TTlvamo2d2hjcEhkNEV6TjhNcUJWemszelZ6ckl1?= =?utf-8?B?S3JvZmljZndMTlBzV3lxbFBKeHRNVXljZ1VzS0FreGVBaW9wUFlMNURicHA0?= =?utf-8?B?UEhoWDdXSHRYbGNzTnRLcCtuUEl5UkJWYVViRWVYU1RFMFc5bGdnNmNkVTd4?= =?utf-8?B?RlZqNG1Nb0RMWkZrL1BKMEY2eGlRWUg5eWE0TllseFY3U0gyOXpkYldiY1or?= =?utf-8?B?NmVVVzQraFN6U1JIVVlxRWxCVEREUmc5VTdYQmZLQzJVZXQ3TmZMdjZlaVQw?= =?utf-8?B?ajh1WFRCTGZMZUpYWk9ndC90WVBYMTMxT2l0NXRlNC9WUlpTc21YcUwwVHI2?= =?utf-8?B?VWJzY01pVXYrVWUzOTdoUDE0U3pFS2RpVmJBMkVJa0VYcWJ2NjJhOGFEdHBm?= =?utf-8?B?YlBpZ2ozZVZSUE9BeDVRcC9KMUFaYWlFdkVOUWFwY050MUF3enV2Um8xbllr?= =?utf-8?B?NWU0Qi85UmdDTlVZZXdVRFhqL1crZStUUktaY25WODNpZmU3eWFIdUN6cy94?= =?utf-8?B?Znd2UHl0ZGJwM1lpWHBoeVoxNWlTamU4MkRxMnBYc1ZPSUVyZ09VYzd6enhp?= =?utf-8?B?WExWY21qckE0Vk1VVi9IMzNkUzAwelpiVDRrUk1LSWNBcVN4cWNZdUIrRnQ0?= =?utf-8?B?b1JtQTlFU1krOUY1NHkrK3U0NzFVSERYcTF6OXNiY3hNNWphR01KUnN0UWs0?= =?utf-8?B?R05zdVNJeFhURFpYZGxNL3FmMXRsV0U3cDVCclQrd1hVVlVGTXJkWWdvK0F1?= =?utf-8?B?aG5wL21OZi9ucW9VUzQrZy8vMFhMc2htMjRLbVNDNG1MTzZGdlhFZU4ySHVK?= =?utf-8?B?TWJuSUVaQlRDbHpMdlB6eERUaGlicDU5b2ppUlpDVlRNSXJQSlk3WWlHNTc0?= =?utf-8?B?MFF0Uk45VEQxWEtMTThRWlljaSszN29Md2V5RkwyNXJ3K0VLZWZzNDk4Vy85?= =?utf-8?B?Szh4S24vZVl0NjVtSGpqNVpuc3RmbXMrVkxYTWJjNzZjYVBXc0hQTy9rTHNj?= =?utf-8?B?d0tEbmQ5cFpkeTA1TWhneSs4ZjVNb01UaWZGRnBFTnNCVFZoQko1RnB2Nk0w?= =?utf-8?B?b3BiSkE4Lzc3eEprUWZrbnl2bUpMOWZvUXpreldUc0NCRFV4WFhsNHY4S1Nj?= =?utf-8?B?VzdNMTRpWTducEhGdllNeFNQNlV0NVpMTnNhcUxkSGNEYWZRSUdOTXptdWhu?= =?utf-8?B?TDR4bDlkTmpvTU1JNGpEZzVQMWJ0MHdVYmlHcHF4M3FuUXBvNkFkMVdJTFVP?= =?utf-8?B?S1E2OXdaRGllTTUyaTY3MzI2aisxY0IzTmkrVTdESmVnZUhESkQ0MmtXNytK?= =?utf-8?B?RG5jRm1QdExSWklmSHc4RjBGS0FJTmR0TUtzbEJvV0U2VFhkVjlkVnRGUnlp?= =?utf-8?B?Nnl2Ly9jOWZiQjdycTdaZjdDbVpFVlJYU21wVzQ3ZHRzdS9hTWRRSUlZaHdD?= =?utf-8?B?VEd4VmlVaVFpc3pCNnRhZkZTeWgrUXhLeFhpY0duL0NoNSsrMEJpSm9UcDAr?= =?utf-8?B?RE85RG5KLy8zQkNCM01vaGo2anEzTG9vbDNLUjhmc1MraThBazI1am1SeE0x?= =?utf-8?B?SnoxVURwTXBocURPU00wa3Nla0VwWWRCTHlzY0FoQkpXTm9HeFQyWk9kZXB3?= =?utf-8?B?Mi9HcldiY2EzdnNWQmRLNUx0Y1VnSktNWm1oRmM2dGtBb3NUVUU5aTRjdzU1?= =?utf-8?B?QlNtYlFIaS9tQlhRK3VkM3R2c1pVWGk4bUpJbVZKaWNFdDI0ZXNZNWZ4dVQr?= =?utf-8?B?anA4ZG1idmMxSWl0ZXdvUT09?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <9E4CDAFA8C021C41BBC4435D1443E766@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4814 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 3de1776a-6583-4507-1009-08d8f0581169 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RBNPnFhKmSImGatawZsEuWtodMAEYb5riEJC87h5HEepnyZZGfI4yYCxtiTSoQWEfToXCAey3tjetA6S0tqYqwi/1o3IsuoB4M/b3yYrfPZnekF92PWK6j2x6wO5IvipZ0WorxCgaVD+HNLcmNPcVIVe6bv8fnycAuGQcVUKQXxdKM6iWqomEBkTRwKw6HP4xILVip0DckNGzq161qlVFCUal2xA+NLHEM9oIgS9jvHe9hrpmUJMqp3h+J3dKzypR3scyGCr4Er3qm3qEY1rB10RN6TpnUeEixMj//F9eQSM2Xays/Po9/BP+BM0HkXHYkyMLtX7w34a8PhnBz+xsRO0wfHt/yg8UPbS5YSdeF4PexTNGyly/c/gX6IdJSx85wZ41mu3XWGWtLtVwnrUEoBzIcIHrxvc2o7izVzY2N53Zhe9p4iRqtOWEyBOJf/NIdXX2/TufydxOG1XXTqMspOKun9eVn3T3dm/HSgr+uF4lESBC4LFP5EjWK2918QP0q993RUqYG93+JvaWheEyCBqvkstSOg03KZNie+JNk0VnxX8J7+YpZOrqpf+GgdYT5OVg4/3gT+sglVZlZabj3lMKuQ0p4Ef7G0rAgJffuEwyDrKSyaAZgHaeRZ82GmWwGvsbT4Ti1BsCzTWA8lTjbOh39poh1LixKE46X3DJE4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(376002)(39860400002)(346002)(396003)(36840700001)(46966006)(86362001)(36860700001)(81166007)(83380400001)(356005)(6486002)(186003)(54906003)(47076005)(8676002)(26005)(316002)(36756003)(8936002)(2906002)(82740400003)(6506007)(53546011)(82310400003)(5660300002)(33656002)(70206006)(70586007)(6512007)(4326008)(6862004)(2616005)(336012)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2021 13:07:29.9635 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f4330770-40ea-4bb0-d539-08d8f0581c8c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6851 SGksDQoNCj4gT24gMjYgTWFyIDIwMjEsIGF0IDExOjU2LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4 ZW4ub3JnPiB3cm90ZToNCj4gDQo+IA0KPiANCj4gT24gMjYvMDMvMjAyMSAxMToxMywgQmVydHJh bmQgTWFycXVpcyB3cm90ZToNCj4+IEhpIEp1bGllbiwNCj4gDQo+IEhpIEJlcnRyYW5kLA0KPiAN Cj4+PiBPbiAyMCBNYXIgMjAyMSwgYXQgMTM6MTMsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5v cmc+IHdyb3RlOg0KPj4+IA0KPj4+ICgrIFNlY3VyaXR5KQ0KPj4+IA0KPj4+IA0KPj4+IE9uIDE3 LzAzLzIwMjEgMTQ6NTYsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+IEhpIEp1bGllbiwN Cj4+PiANCj4+PiBIaSBCZXJ0cmFuZCwNCj4+PiANCj4+Pj4+IE9uIDEzIE1hciAyMDIxLCBhdCAx NjowNiwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4+PiANCj4+Pj4+ IEZyb206IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQo+Pj4+PiANCj4+Pj4+IFNv bWUgQ1BVcyBjYW4gc3BlY3VsYXRlIHBhc3QgYSBSRVQgaW5zdHJ1Y3Rpb24gYW5kIHBvdGVudGlh bGx5IHBlcmZvcm0NCj4+Pj4+IHNwZWN1bGF0aXZlIGFjY2Vzc2VzIHRvIG1lbW9yeSBiZWZvcmUg cHJvY2Vzc2luZyB0aGUgcmV0dXJuLg0KPj4+Pj4gDQo+Pj4+PiBUaGVyZSBpcyBubyBrbm93biBn YWRnZXQgYXZhaWxhYmxlIGFmdGVyIHRoZSBSRVQgaW5zdHJ1Y3Rpb24gdG9kYXkuDQo+Pj4+PiBI b3dldmVyIHNvbWUgb2YgdGhlIHJlZ2lzdGVycyAoc3VjaCBhcyBpbiBjaGVja19wZW5kaW5nX2d1 ZXN0X3NlcnJvcigpKQ0KPj4+Pj4gbWF5IGNvbnRhaW4gYSB2YWx1ZSBwcm92aWRlZCBieSB0aGUg Z3Vlc3QuDQo+Pj4+PiANCj4+Pj4+IEluIG9yZGVyIHRvIGhhcmRlbiB0aGUgY29kZSwgaXQgd291 bGQgYmUgYmV0dGVyIHRvIGFkZCBhIHNwZWN1bGF0aW9uDQo+Pj4+PiBiYXJyaWVyIGFmdGVyIGVh Y2ggUkVUIGluc3RydWN0aW9uLiBUaGUgcGVyZm9ybWFuY2UgaW1wYWN0IGlzIG1lYW50IHRvDQo+ Pj4+PiBiZSBuZWdsaWdlYWJsZSBhcyB0aGUgc3BlY3VsYXRpb24gYmFycmllciBpcyBub3QgbWVh bnQgdG8gYmUNCj4+Pj4+IGFyY2hpdGVjdHVyYWxseSBleGVjdXRlZC4NCj4+Pj4+IA0KPj4+Pj4g UmF0aGVyIHRoYW4gbWFudWFsbHkgaW5zZXJ0aW5nIGEgc3BlY3VsYXRpb24gYmFycmllciwgdXNl IGEgbWFjcm8NCj4+Pj4+IHdoaWNoIG92ZXJyaWRlcyB0aGUgbW5lbW9uaWMgUkVUIGFuZCByZXBs YWNlIHdpdGggUkVUICsgU0IuIFdlIG5lZWQgdG8NCj4+Pj4+IHVzZSB0aGUgb3Bjb2RlIGZvciBS RVQgdG8gcHJldmVudCBhbnkgbWFjcm8gcmVjdXJzaW9uLg0KPj4+Pj4gDQo+Pj4+PiBUaGlzIHBh dGNoIGlzIG9ubHkgY292ZXJpbmcgdGhlIGFzc2VtYmx5IGNvZGUuIEMgY29kZSB3b3VsZCBuZWVk IHRvIGJlDQo+Pj4+PiBjb3ZlcmVkIHNlcGFyYXRlbHkgdXNpbmcgdGhlIGNvbXBpbGVyIHN1cHBv cnQuDQo+Pj4+PiANCj4+Pj4+IFRoaXMgaXMgcGFydCBvZiB0aGUgd29yayB0byBtaXRpZ2F0ZSBz dHJhaWdodC1saW5lIHNwZWN1bGF0aW9uLg0KPj4+Pj4gDQo+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBK dWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KPj4+PiBUaGUgbWFjcm8gc29sdXRpb24g aXMgZGVmaW5pdGVseSBhIGdyZWF0IGltcHJvdmVtZW50IGNvbXBhcmVkIHRvIHYxIGFuZCBJIGNv dWxkDQo+Pj4+IGNvbmZpcm0gdGhlIHByZXNlbmNlIG9mIHRoZSBzYiBpbiB0aGUgZ2VuZXJhdGVk IGNvZGUuDQo+Pj4gDQo+Pj4gVGhhbmtzIGZvciB0ZXN0aW5nISBJdCBpcyBpbmRlZWQgYSBsb3Qg bmljZXIgYW5kIGxlc3MgZXJyb3ItcHJvbmUuIFdlIGNhbiB0aGFuc2sgSmFuIGZvciB0aGUgaWRl YSBhcyBoZSBvcmlnaW5hbGx5IGludHJvZHVjZWQgaXQgb24geDg2IDopLg0KPj4+IA0KPj4+PiBJ IGFsc28gdGhpbmsgdGhhdCB0aGUgbWl0aWdhdGlvbiBvbiBhcm0zMi92NyB3b3VsZCBiZSBtZXNz eSB0byBkby4NCj4+PiANCj4+PiBJdCBpcyBtZXNzeSBidXQgbm90IGltcG9zc2libGUgOikuIFNv bWUgb2YgdGhlIGFzc2VtYmx5IGZ1bmN0aW9uIGNvdWxkIGJlIHJld3JpdHRlbiBpbiBDIHRvIHRh a2UgYWR2YW50YWdlIG9mIHRoZSBjb21waWxlciBtaXRpZ2F0aW9ucy4NCj4+PiANCj4+PiBJIHdl bnQgdGhyb3VnaCB0aGUgcGFwZXIgYWdhaW4gdG9kYXkuIFN0cmFpZ2h0LWxpbmUgbWl0aWdhdGlv biBvbmx5IHJlZmVycyB0byB1bmNvbmRpdGlvbmFsIGNvbnRyb2wgZmxvdyBjaGFuZ2UgKGUuZy4g UkVUKSBvbiBBQXJjaDY0IEFybXY4Lg0KPj4+IA0KPj4+IEEgcmVjZW50IHN1Ym1pc3Npb24gdG8g TExWTSBzZWVtcyB0byBzdWdnZXN0IHRoYXQgQXJtdjcgYW5kIEFBcmNoMzIgQXJtdjggaXMgYWxz byBhZmZlY3RlZCBbMl0uDQo+PiBUaGFua3MgZm9yIHRoZSBwb2ludGVyIDotKQ0KPj4+IA0KPj4+ IFNvIEkgdGhpbmsgd2Ugb25seSBuZWVkIHRvIGNhcmUgb2YgdW5jb25kaXRpb25hbCByZXR1cm4g aW5zdHJ1Y3Rpb24gKGUuZy4gbW92IHBjLCBscikuDQo+Pj4gDQo+Pj4gRm9yIGNvbmRpdGlvbmFs IHJldHVybiBpbnN0cnVjdGlvbnMsIHRoZXkgd291bGQgYmUgdHJlYXRlZCBhcyBzcGVjdHJlIHYy IHdoaWNoIHdlIGFscmVhZHkgbWl0aWdhdGUuDQo+PiBUaGF0IHdvdWxkIGJlIGEgZ29vZCBpZGVh IGJ1dCB0aGF0IHdvdWxkIG1lYW4gbG90cyBvZiBpbnZhc2l2ZSBjaGFuZ2VzIG9uIGFybXY3IGFu ZA0KPiBJdCBpcyBub3QgcXVpdGUgY2xlYXIgd2hpY2ggY2hhbmdlIHlvdSB0aGluayBpcyBpbnZh c2l2ZS4uLiBUaGUgY2hhbmdlIGZvciBhZGRpbmcgYSBiYXJyaWVyIGFmdGVyIGFsbCB1bmNvbmRp dGlvbmFsIHJldHVybiBpbnN0cnVjdGlvbiBpcyBwcmV0dHkgc3RyYWlnaHQtZm9yd2FyZC4NCj4g DQo+IFJlZ2FyZGluZyBjb25kaXRpb25hbCByZXR1cm4gaW5zdHJ1Y3Rpb25zLCB0aGVuIGlzIG5v dGhpbmcgdG8gZG8gZm9yIHN0cmFpZ2h0LWxpbmUgc3BlY3VsYXRpb24uDQo+IA0KPj4gdGhpcyBp cyBub3QgdGhlIG1vc3RseSB0ZXN0ZWQgYXJjaGl0ZWN0dXJlIHdpdGggWGVuLg0KPiBUbyBtZSB0 aGlzIGxvb2tzIHZlcnkgc3ViamVjdGl2ZSwgaG93IGRvIHlvdSBkZWZpbmUgIm1vc3RseSB0ZXN0 ZWQiPw0KPiANCj4gRnJvbSBYZW4gUHJvamVjdCBwZXJzcGVjdGl2ZSwgd2UgcnVuIHRoZSBzYW1l IHRlc3Qgc3VpdGUgb24gYXJtNjQgYW5kIGFybTMyIG11bHRpcGxlIHRpbWUgZGFpbHkuIEkgY291 bGRuJ3Qgc2F5IHRoZSBzYW1lIGZvciBzb21lIG9mIHRoZSBBcm0gZHJpdmVycyBpbiB0aGUgdHJl ZS4NCg0KQWxsIHRvZ2V0aGVyIGkganVzdCB3YW50IHRvIHNheSB0aGF0IEkgaGF2ZSBubyB0ZXN0 aW5nIGNhcGFjaXRpZXMgZm9yIGFybTMyIChpbiBoYXJkd2FyZSBhbmQgcGVyc29ucykgYW5kIHRo ZSDigJx1c2VyIGJhc2XigJ0gZm9yIGl0IG1pZ2h0IG5vdCBiZSBodWdlIChidXQgSSBtaWdodCBi ZSB3cm9uZyBoZXJlKS4NCg0KSWYgeW91IHRoaW5rIHRoYXQgdGhlcmUgaXMgZW5vdWdoIHRlc3Rp bmcgZm9yIGl0IGF2YWlsYWJsZSBvciBvdGhlciBtaWdodCBiZSBhYmxlIHRvIHRlc3QgaXQgdGhl biBubyBwcm9ibGVtIGZvciBtZSwgSSB3aWxsIGhlbHAgb24gdGhlIHJldmlldyBzaWRlLg0KDQpD aGVlcnMNCkJlcnRyYW5kDQoNCj4gDQo+PiBBbnl3YXkgSSBhbSBoYXBweSB0byBoZWxwIHJldmll d2luZyB0aGlzIGlmIGl0IGlzIGRvbmUuDQo+Pj4gDQo+Pj4+IFNoYWxsIHdlIG1hcmsgdjcvYWFy Y2gzMiBhcyBub3Qgc2VjdXJpdHkgc3VwcG9ydGVkID8NCj4+PiBUaGlzIHdvdWxkIGhhdmUgY29u c2VxdWVuY2UgYmV5b25kIGp1c3Qgc3BlY3VsYXRpb24uIFRoZXJlIG1pZ2h0IGJlIHByb2Nlc3Nv ciBvdXQgd2hpY2ggYXJlIG5vdCBhZmZlY3RlZCBieSBzdHJhaWdodC1saW5lIHNwZWN1bGF0aW9u IGFuZCB3ZSB3b3VsZCBub3QgaXNzdWUgYW55IHNlY3VyaXR5IHVwZGF0ZSBmb3IgdGhlbS4gU28g SSBhbSBub3QgaW4gZmF2b3Igd2l0aCB0aGlzIGFwcHJvYWNoLg0KPj4+IA0KPj4+IFdoYXQgd2Ug Y291bGQgY29uc2lkZXIgaXMgbWVudGlvbmluZyBpbiBTVVBQT1JULk1EIHRoYXQgc3BlY3VsYXRp b24gYXR0YWNrIHVzaW5nIFN0cmFpZ2h0LUxpbmUgc3BlY3VsYXRpb24gYXJlIG5vdCBzZWN1cml0 eSBzdXBwb3J0IG9uIEFybSAodGhlIDY0LWJpdCBpcyBub3QgZnVsbHkgbWl0aWdhdGVkKS4NCj4+ IFdlaXJkIHRvIHNheSDigJxub3Qgc2VjdXJpdHkgc3VwcG9ydGVk4oCdIG1heWJlIHNheWluZyBu b3QgbWl0aWdhdGVkIGJ5IFhlbiB3b3VsZCBiZSBtb3JlIGNsZWFyLg0KPiANCj4gSSBhbSBvcGVu IGZvciB0aGUgd29yZGluZyA6KS4NCj4gDQo+IENoZWVycywNCj4gDQo+IC0tIA0KPiBKdWxpZW4g R3JhbGwNCj4gDQoNCg== From xen-devel-bounces@lists.xenproject.org Fri Mar 26 13:15:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 13:15:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101790.194903 (Exim 4.92) (envelope-from ) id 1lPmJa-0004Fm-GN; Fri, 26 Mar 2021 13:15:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101790.194903; Fri, 26 Mar 2021 13:15:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmJa-0004Ff-D2; Fri, 26 Mar 2021 13:15:50 +0000 Received: by outflank-mailman (input) for mailman id 101790; Fri, 26 Mar 2021 13:15:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmJZ-0004Fa-B6 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:15:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmJZ-0007LF-8e for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:15:49 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPmJZ-0006c5-7Y for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:15:49 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPmJS-0002bm-IZ; Fri, 26 Mar 2021 13:15:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=20g2J7MwDZnikxbnbSJAC9FAWMPrL7UpYoJbVngFzQg=; b=ZwSRf2qRU+uOCuD+t6FYvbzT3V VhYUZ2//afWUfHRlld0krKavxkxBldPIZezWdtCbcPFUW7veB4ybRZJ05K/mBj0r1GGCbssxggTWs lA2Xwk0f3AmxX+Q2xa+p3hwGaZu5+6pgSqF1lG6SsIDP5nqFdgCHTRtW7D5josnFDK2E=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.56958.383583.53595@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 13:15:42 +0000 To: Tamas K Lengyel Cc: Roger Pau =?iso-8859-1?Q?Monn=E9?= , Andrew Cooper , Xen-devel , Jan Beulich , Wei Liu , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , =?iso-8859-1?Q?Fr=E9d=E9ric?= Pierret Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally In-Reply-To: References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <24669.52641.499147.88002@mariner.uk.xensource.com> <24669.54213.173154.400771@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Tamas K Lengyel writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally"): > The problem from my perspective is that the end-users have no way to > determine when that boot option is needing to be set. Having an > installation step of "check if things explode when you reboot" is just > plain bad. Many times you don't even have access to a remote serial > console to check why Xen didn't boot. So that's not a realistic route > that can be taken. If Jan's patch is applied then the only thing I'll > be able to do is make all installations always-enable this option even > on systems that would have booted fine otherwise without it. It is > unclear if that has any downsides of its own and could very well just > kick the can down the road and lead to other issues. Thanks for the clear explanation. I think our options are: 1. What is currently in xen.git#staging-4.15: some different set of machines do not work (reliably? at all?), constituting a regression on older hardware. 2. Jan's patch, with the consequences you describe. Constituing a continued failure to properly support the newer hardware. 3. Andy's patches which are not finished yet and are therefore high risk. Ie, delay the release. Please let me know if you think this characterisation of the situation is inaccurate or misleading. This is not a good set of options. Of them, I still think I would choose (2). But I would love it if someone were to come up with a better suggestion (perhaps a variant on one of the above). Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 13:22:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 13:22:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101797.194914 (Exim 4.92) (envelope-from ) id 1lPmQA-0005Q9-Au; Fri, 26 Mar 2021 13:22:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101797.194914; Fri, 26 Mar 2021 13:22:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmQA-0005Q2-7v; Fri, 26 Mar 2021 13:22:38 +0000 Received: by outflank-mailman (input) for mailman id 101797; Fri, 26 Mar 2021 13:22:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmQ9-0005Pv-0E for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:22:37 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id efcfec63-6af8-4d0b-b469-acc1d26e8cf6; Fri, 26 Mar 2021 13:22:35 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 00065ADD7; Fri, 26 Mar 2021 13:22:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efcfec63-6af8-4d0b-b469-acc1d26e8cf6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616764955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5xTRBoX5Eec5DHd69ZJfPbue1Pa6T+i8850yVhierx0=; b=oVL9MqHHbSf/WPKFGT4yqE535Dr2LmNo+EXVlcQkqgSzxwdUNBaUi/1STJ1lMrjgbInRop d4gy9uiL4wihXrNhUvigCNV3GmFNu8IM5DDXZFzOytPJy141hcqBcvy6skoHmxqoLBEQtG JIfNReg4CWLn9vkXglZV1X4bagko4mE= Subject: Re: [PATCH][4.15] Performance regression due to XSA-336 To: Ian Jackson Cc: Boris Ostrovsky , andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com, xen-devel@lists.xenproject.org References: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> <24669.52030.995324.426028@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <0f14edcd-5ac7-0403-bccb-a97bf27bf392@suse.com> Date: Fri, 26 Mar 2021 14:22:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <24669.52030.995324.426028@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 26.03.2021 12:53, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH][4.15] Performance regression due to XSA-336"): >> While the change is more intrusive than one would like at this point, an >> up-to-40% regression imo makes this at least a change to be considered >> for 4.15. I will admit though that before next week I won't get around >> to look at this in any more detail than just having read through this >> cover letter. But perhaps someone else might find time earlier. > > As I understand it: > > This amounts to a request to consider a release ack for "x86/vpt: > Replace per-guest pt_migrate lock with per pt lock". Or, as already suggested by Roger, perhaps something simpler. First of all I wanted you to be aware. > That patch fixes a regression due to XSA-336. XSA-336 affected many > versions of Xen. Therefore this is not a regression between 4.14 and > 4.15; rather it's a regresion from pre-XSA-336 to post-XSA-336. > > I looked at the patch and I am really not comfortable with that kind > of change at this stage of the release. > > So I'm afraid the answer is no, unless I have misunderstood something. Understood. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 26 13:26:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 13:26:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101800.194926 (Exim 4.92) (envelope-from ) id 1lPmTS-0005Zj-QN; Fri, 26 Mar 2021 13:26:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101800.194926; Fri, 26 Mar 2021 13:26:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmTS-0005Zc-NU; Fri, 26 Mar 2021 13:26:02 +0000 Received: by outflank-mailman (input) for mailman id 101800; Fri, 26 Mar 2021 13:26:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmTQ-0005ZT-U3 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:26:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmTQ-0007Vm-QU for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:26:00 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPmTQ-0007S7-PZ for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:26:00 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPmTE-0002e6-Sb; Fri, 26 Mar 2021 13:25:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=ZNCwX/5eqAaSOqbirF/Tz8VKnGwDM0yJfoPB2++kuhA=; b=D6Qm/QQXs1AaQYp/gkrjoN0usT b2w00jPoH2OLYZ38sy1XxlBgPFP0cdotcOcu2M0Xjr3BwgRWJ8yeVB1E/1yM9osmNGMSCFjBVGur5 +M7i/6K4y7jz4YYAxX22MbJDn4SJoSDCi+9J+AGMlOQ2Ra/ZdA7nA/LsEW4dwEu7Wamk=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.57564.651716.509953@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 13:25:48 +0000 To: Jan Beulich Cc: Boris Ostrovsky , andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com, xen-devel@lists.xenproject.org Subject: Re: [PATCH][4.15] Performance regression due to XSA-336 In-Reply-To: <0f14edcd-5ac7-0403-bccb-a97bf27bf392@suse.com> References: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> <24669.52030.995324.426028@mariner.uk.xensource.com> <0f14edcd-5ac7-0403-bccb-a97bf27bf392@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH][4.15] Performance regression due to XSA-336"): > On 26.03.2021 12:53, Ian Jackson wrote: > > This amounts to a request to consider a release ack for "x86/vpt: > > Replace per-guest pt_migrate lock with per pt lock". > > Or, as already suggested by Roger, perhaps something simpler. First of > all I wanted you to be aware. Thank you, yes. That is very helpful. > > That patch fixes a regression due to XSA-336. XSA-336 affected many > > versions of Xen. Therefore this is not a regression between 4.14 and > > 4.15; rather it's a regresion from pre-XSA-336 to post-XSA-336. > > > > I looked at the patch and I am really not comfortable with that kind > > of change at this stage of the release. > > > > So I'm afraid the answer is no, unless I have misunderstood something. > > Understood. I might consider "something simpler" but the bar is very high by now and it seems unlikely to make the cut. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 13:30:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 13:30:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101805.194942 (Exim 4.92) (envelope-from ) id 1lPmXa-0006iZ-Cf; Fri, 26 Mar 2021 13:30:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101805.194942; Fri, 26 Mar 2021 13:30:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmXa-0006iS-9W; Fri, 26 Mar 2021 13:30:18 +0000 Received: by outflank-mailman (input) for mailman id 101805; Fri, 26 Mar 2021 13:30:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmXZ-0006iN-2b for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:30:17 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 273889a5-b042-458c-80a1-6e63964ca43f; Fri, 26 Mar 2021 13:30:16 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 52C42AB8A; Fri, 26 Mar 2021 13:30:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 273889a5-b042-458c-80a1-6e63964ca43f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616765415; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kYAGONEfrXOTEzejsd+iopZPq0beT5W/vMevZDvgwvE=; b=K6a31O6ITTv7AtGVyFJyrQGuRAD4kqOl7zWK61o8yzWghrQiJO6YYEmxf+yLyWlCG3sIjG mHeQd41UdWprkNIxPJieGfmY74Bh80/9X1fOnMg6K2uSOT1SY21S157pB0zhfD+3/rQXsD L4hh5pIxeikZb+xgMZOgMkcJHuC316A= Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally To: Ian Jackson Cc: Andrew Cooper , Xen-devel , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <24669.52641.499147.88002@mariner.uk.xensource.com> <24669.54213.173154.400771@mariner.uk.xensource.com> From: Jan Beulich Message-ID: Date: Fri, 26 Mar 2021 14:30:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <24669.54213.173154.400771@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 26.03.2021 13:29, Ian Jackson wrote: > I wrote: >> I'm sorry, but I think it is too late for 4.15 to do this. I prefer >> Jan's patch which I have alread release-acked. >> >> Can someone qualified please provide a maintainer review for this, >> ideally today ? > > I asked Andrew on IRC: > > 12:08 andyhhp__: Are you prepared to maintainer-ack Jan's > more-minimal hpet workaround approach ? > 12:16 Diziet: honestly, no. I don't consider that > acceptable behaviour, and it is a fairly big "f you" > (this was literally feedback I got in private) to > the downstreams who've spent years trying to get us > to fix this bug, and have now backported the first > version. > 12:16 I'm looking into the feedback on my series > 12:17 one way or another, the moment we enter the fallback > path for interrupt routing, something is very broken > on the system > 12:19 so the tradeoff is an unspecified bug on one ancient > laptop which can't be tested now, vs 5 years of Atom > CPUs, 2 years of latop CPUs, and the forthcoming > Server line of Intel CPUs > 12:19 or whatever other compromise we can work on > > I'm sorry that this bug is going to continue to be not properly fixed. Actually I had another thought here in the morning, but then didn't write it down: While Andrew's approach indeed would (hopefully) improve user experience, it'll reduce the incentive of actually fixing the issue. Normally I might not be that concerned, but seeing how long it took to even arrive at a workaround, I'm afraid now I am concerned. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 26 13:32:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 13:32:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101808.194953 (Exim 4.92) (envelope-from ) id 1lPmZW-0006pm-PF; Fri, 26 Mar 2021 13:32:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101808.194953; Fri, 26 Mar 2021 13:32:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmZW-0006pf-MH; Fri, 26 Mar 2021 13:32:18 +0000 Received: by outflank-mailman (input) for mailman id 101808; Fri, 26 Mar 2021 13:32:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmZV-0006pa-UY for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:32:17 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7f830677-4a15-4b24-976f-a69c4126cdc8; Fri, 26 Mar 2021 13:32:16 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 166F9AB8A; Fri, 26 Mar 2021 13:32:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f830677-4a15-4b24-976f-a69c4126cdc8 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616765536; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nIxbWxTsUYfQxuH91g1XjA854G7xJRDLBl5wUqUhFfc=; b=V9ezvvhQi3VVOXyrivFNSEz8OnsEJsXmpqRZf1GlfP9a/O8KSCpyCwIN07iD2B59RO1ZJB 4nWFYe0Y5VO3IWTf3JMY8CuFwsrM7kheDGAM3x9ge/cSXt83YAJc+4wfljiny4i7CAWEqA czHkSh66ZgpwB0MJuFh2D8oKP97j3Fk= Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally To: Tamas K Lengyel Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , Xen-devel , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , Ian Jackson References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <24669.52641.499147.88002@mariner.uk.xensource.com> <24669.54213.173154.400771@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <6077715e-8ea6-7dc6-c226-ccfad2b8f3ba@suse.com> Date: Fri, 26 Mar 2021 14:31:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 26.03.2021 14:03, Tamas K Lengyel wrote: > On Fri, Mar 26, 2021 at 8:30 AM Ian Jackson wrote: >> >> I wrote: >>> I'm sorry, but I think it is too late for 4.15 to do this. I prefer >>> Jan's patch which I have alread release-acked. >>> >>> Can someone qualified please provide a maintainer review for this, >>> ideally today ? >> >> I asked Andrew on IRC: >> >> 12:08 andyhhp__: Are you prepared to maintainer-ack Jan's >> more-minimal hpet workaround approach ? >> 12:16 Diziet: honestly, no. I don't consider that >> acceptable behaviour, and it is a fairly big "f you" >> (this was literally feedback I got in private) to >> the downstreams who've spent years trying to get us >> to fix this bug, and have now backported the first >> version. >> 12:16 I'm looking into the feedback on my series >> 12:17 one way or another, the moment we enter the fallback >> path for interrupt routing, something is very broken >> on the system >> 12:19 so the tradeoff is an unspecified bug on one ancient >> laptop which can't be tested now, vs 5 years of Atom >> CPUs, 2 years of latop CPUs, and the forthcoming >> Server line of Intel CPUs >> 12:19 or whatever other compromise we can work on >> >> I'm sorry that this bug is going to continue to be not properly fixed. >> As I understand it the practical impact is that users of those >> affected systems (the newer ones you mention) will have to add a >> command-line option. That is, unfortunately, the downside of >> time-based releases. If we had been having this conversation two >> weeks ago I would have very likely had a different answer. > > The problem from my perspective is that the end-users have no way to > determine when that boot option is needing to be set. Having an > installation step of "check if things explode when you reboot" is just > plain bad. Many times you don't even have access to a remote serial > console to check why Xen didn't boot. I guess I don't see the serial console aspect here: This sort of boot issue can be seen on the normal screen as well. It occurs neither too early nor too late to be visible. We could amend the output by a hint towards this option. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 26 13:39:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 13:39:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101814.194968 (Exim 4.92) (envelope-from ) id 1lPmgL-0007LN-Ik; Fri, 26 Mar 2021 13:39:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101814.194968; Fri, 26 Mar 2021 13:39:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmgL-0007LG-Ft; Fri, 26 Mar 2021 13:39:21 +0000 Received: by outflank-mailman (input) for mailman id 101814; Fri, 26 Mar 2021 13:39:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmgJ-0007L9-JQ for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:39:19 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e0a66730-7d1a-4491-9e7d-496f160e9dd1; Fri, 26 Mar 2021 13:39:18 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A66E2AB8A; Fri, 26 Mar 2021 13:39:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0a66730-7d1a-4491-9e7d-496f160e9dd1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616765957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pCPWJcbclaFj04/M+Oba/L/qqLt0wmssGdbyv9KnPQM=; b=nJCEIAWeWxzRj484pWXdzZcU+8se59RN8CsQ63aViDlUAnCYYxfXckIqscIvZA7tY67MDS Mw2EzAqyZUxVmVCEkyiGlMXGJGVfh5yCMrF1ukqpCOcW1APcd9iBXgj2h8VQXY/OMHaoYC ebcq79IKQuWia1fZukBqv/T3I0brEbY= Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally To: Ian Jackson Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , Xen-devel , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , Tamas K Lengyel References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <24669.52641.499147.88002@mariner.uk.xensource.com> <24669.54213.173154.400771@mariner.uk.xensource.com> <24669.56958.383583.53595@mariner.uk.xensource.com> From: Jan Beulich Message-ID: Date: Fri, 26 Mar 2021 14:37:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <24669.56958.383583.53595@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 26.03.2021 14:15, Ian Jackson wrote: > Tamas K Lengyel writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally"): >> The problem from my perspective is that the end-users have no way to >> determine when that boot option is needing to be set. Having an >> installation step of "check if things explode when you reboot" is just >> plain bad. Many times you don't even have access to a remote serial >> console to check why Xen didn't boot. So that's not a realistic route >> that can be taken. If Jan's patch is applied then the only thing I'll >> be able to do is make all installations always-enable this option even >> on systems that would have booted fine otherwise without it. It is >> unclear if that has any downsides of its own and could very well just >> kick the can down the road and lead to other issues. > > Thanks for the clear explanation. > > I think our options are: > > 1. What is currently in xen.git#staging-4.15: some different set of > machines do not work (reliably? at all?), constituting a > regression on older hardware. > > 2. Jan's patch, with the consequences you describe. Constituing a > continued failure to properly support the newer hardware. > > 3. Andy's patches which are not finished yet and are therefore high > risk. Ie, delay the release. > > Please let me know if you think this characterisation of the situation > is inaccurate or misleading. > > This is not a good set of options. > > Of them, I still think I would choose (2). But I would love it if > someone were to come up with a better suggestion (perhaps a variant on > one of the above). TBH delaying the release for this specific problem should be seriously considered imo. In principle I'm in favor of (3) of the above, if there weren't the downsides I did mention in prior mails. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 26 13:39:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 13:39:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101815.194980 (Exim 4.92) (envelope-from ) id 1lPmgS-0007P1-Qi; Fri, 26 Mar 2021 13:39:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101815.194980; Fri, 26 Mar 2021 13:39:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmgS-0007Ou-Na; Fri, 26 Mar 2021 13:39:28 +0000 Received: by outflank-mailman (input) for mailman id 101815; Fri, 26 Mar 2021 13:39:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmgR-0007OZ-Br for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:39:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmgR-0007lC-B4 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:39:27 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPmgR-00004x-9p for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:39:27 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPmgJ-0002gl-4G; Fri, 26 Mar 2021 13:39:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=G2vhk5BPoGY6U2w0yPmDSJWDv4UAOPYYX1cWmYU6xs4=; b=NQt10yOJHy4tcyDQZVWh5F+4OV fyLam+N4lZmIhi5SXsDA7OquqMw14fAWwVtNcEbHcETO9URqP3tFJHEeZIzCVi+Z5utv9aiPAwAYI l+kwt6KB5F48oo3FAZiT59Xl9HuDBVeDWP5hh7xcNQWnWjLZ9DMeQ5w9q2zs2qqjSliE=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.58374.923784.665582@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 13:39:18 +0000 To: Jan Beulich Cc: Tamas K Lengyel , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Andrew Cooper , Xen-devel , Wei Liu , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , =?iso-8859-1?Q?Fr=E9d=E9ric?= Pierret Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally In-Reply-To: <6077715e-8ea6-7dc6-c226-ccfad2b8f3ba@suse.com> References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <24669.52641.499147.88002@mariner.uk.xensource.com> <24669.54213.173154.400771@mariner.uk.xensource.com> <6077715e-8ea6-7dc6-c226-ccfad2b8f3ba@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally"): > I guess I don't see the serial console aspect here: This sort of > boot issue can be seen on the normal screen as well. It occurs > neither too early nor too late to be visible. We could amend the > output by a hint towards this option. Changes to message strings would be fine even if done next week. It looks like I am going to have to do the code review of this change myself, if I want it today ? This is far from ideal as I am no expert in this area. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 13:44:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 13:44:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101820.194993 (Exim 4.92) (envelope-from ) id 1lPmky-0008KY-FA; Fri, 26 Mar 2021 13:44:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101820.194993; Fri, 26 Mar 2021 13:44:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmky-0008KR-Ar; Fri, 26 Mar 2021 13:44:08 +0000 Received: by outflank-mailman (input) for mailman id 101820; Fri, 26 Mar 2021 13:44:07 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmkx-0008KM-C5 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:44:07 +0000 Received: from wout1-smtp.messagingengine.com (unknown [64.147.123.24]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ba1c1410-b1b7-4c51-8698-7a786a3c853e; Fri, 26 Mar 2021 13:44:06 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 630191CD6; Fri, 26 Mar 2021 09:44:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 26 Mar 2021 09:44:05 -0400 Received: from mail-itl (ip5b434f04.dynamic.kabel-deutschland.de [91.67.79.4]) by mail.messagingengine.com (Postfix) with ESMTPA id 8675724005A; Fri, 26 Mar 2021 09:44:02 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba1c1410-b1b7-4c51-8698-7a786a3c853e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=9/IjJe iYxx3t/DAoDZmmzyOMFZL7HIJttlB53JUX5eE=; b=QF2pp9LTl9jgqSwVNW6/s0 zUx/JcgCunTaOcGZUQ8cqo3R4eGFfQPlHqkeIAkHYntt6+Wpic6nuN9V08LIyHy6 UcVIiNajTPwlJl8sAu1cwmT1YHywRoapM897MZWeUQ3qIYIOldzdl5qq3Al/U6Ea Hk8RHLNbKu4vCDXIJe31HrOkatsTwDcDnfkJ06lSK/FWZqVb9P8stduFjoTJHag9 8fUBbLdnepRtoIipSfGebD6ubgGtoC4Yb4U8n2FC/H7GY5mplnicY61Fmy+SoRgv I0SbRezFUaWRGkQguvAmu3TVDXGtjWe0el6aW5s/H/4c/bEf9UiIP1qCB95ESbRw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehvddgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucfkpheple durdeijedrjeelrdegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg homh X-ME-Proxy: Date: Fri, 26 Mar 2021 14:43:58 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Ian Jackson , Andrew Cooper , Xen-devel , Wei Liu , =?utf-8?B?RnLDqWTDqXJpYw==?= Pierret , Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally Message-ID: References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <24669.52641.499147.88002@mariner.uk.xensource.com> <24669.54213.173154.400771@mariner.uk.xensource.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HGjM90Qvvu8CYKe4" Content-Disposition: inline In-Reply-To: --HGjM90Qvvu8CYKe4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 26, 2021 at 02:30:09PM +0100, Jan Beulich wrote: > On 26.03.2021 13:29, Ian Jackson wrote: > > I wrote: > >> I'm sorry, but I think it is too late for 4.15 to do this. I prefer > >> Jan's patch which I have alread release-acked. > >> > >> Can someone qualified please provide a maintainer review for this, > >> ideally today ? > >=20 > > I asked Andrew on IRC: > >=20 > > 12:08 andyhhp__: Are you prepared to maintainer-ack Jan's > > more-minimal hpet workaround approach ? > > 12:16 Diziet: honestly, no. I don't consider that > > acceptable behaviour, and it is a fairly big "f you" > > (this was literally feedback I got in private) to > > the downstreams who've spent years trying to get us > > to fix this bug, and have now backported the first > > version. > > 12:16 I'm looking into the feedback on my series > > 12:17 one way or another, the moment we enter the fallback > > path for interrupt routing, something is very broken > > on the system > > 12:19 so the tradeoff is an unspecified bug on one ancient > > laptop which can't be tested now, vs 5 years of Atom > > CPUs, 2 years of latop CPUs, and the forthcoming > > Server line of Intel CPUs > > 12:19 or whatever other compromise we can work on > >=20 > > I'm sorry that this bug is going to continue to be not properly fixed. >=20 > Actually I had another thought here in the morning, but then didn't > write it down: While Andrew's approach indeed would (hopefully) > improve user experience, it'll reduce the incentive of actually > fixing the issue. Normally I might not be that concerned, but seeing > how long it took to even arrive at a workaround, I'm afraid now I am > concerned. I assume "the issue" you meant "Xen using legacy stuff that stops being supported by the hardware", right? Yes it is an issue. But for most users of Xen, having it broken more likely will results in "lets switch to something that works" (perhaps not after the first such case, but this is definitely not the first one) instead of "lets spend some hours on debugging this very low level issue". And to be honest, this is more and more appealing option, even though all the deficiencies of KVM... --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --HGjM90Qvvu8CYKe4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmBd5R8ACgkQ24/THMrX 1yxsPQf8Cf0d+0ZK0PNOYF/Lhl4ZSBvJYARVJYAAxWLmah75hSgU1L0ULKAjuxAX sClqzLBOyzZHwJvDBS73jJqKbRDV60svpkpyTmScHsTstvAsr3C/UotnEijONy8x RaXvN/EnAfezvdspSXnnupgDKiTBEebFyHoxuqH4brTColq0b+NZXJd3EcGgKcno NqTD2H9Cx19Px2FO4/PFobCBLUxWMg1wCL+zB/reYDEV04EmE/xWf7y7bkJ6B2Rs H08scvYdjr7008bSIxZAnZBFsnutxXxUrQNEIWE0fKUK1WGMg4m89QvPioseRvWN 07DnExH45WXVCroaMMhOaz7hC2of7A== =RXRN -----END PGP SIGNATURE----- --HGjM90Qvvu8CYKe4-- From xen-devel-bounces@lists.xenproject.org Fri Mar 26 13:46:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 13:46:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101826.195004 (Exim 4.92) (envelope-from ) id 1lPmn4-0008Un-W2; Fri, 26 Mar 2021 13:46:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101826.195004; Fri, 26 Mar 2021 13:46:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmn4-0008Uf-Su; Fri, 26 Mar 2021 13:46:18 +0000 Received: by outflank-mailman (input) for mailman id 101826; Fri, 26 Mar 2021 13:46:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmn3-0008UU-Eo for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:46:17 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id aa138d34-f176-48a5-80cc-c0c311781557; Fri, 26 Mar 2021 13:46:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa138d34-f176-48a5-80cc-c0c311781557 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616766375; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=eBESrAlQIvnE3PocElkQU9g4GiG+/jBNOAhR9ADzN6c=; b=J5Ie4nl8FMr7h/gFpGDWGShOEa3m8jTmcW0cx4UgOr+TpE8k4UPNhlLD mVI5B8LE/9q7IljZ6WFuq7mdYflWNz7ruzInqKLLNxd4llcaBkbvKPgnz VDz6+ad4CwCxfrB+CvjS5+iCDjbNQPMoS69H4bmIBBZgIlbqO5byqlcYm Q=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: hM6SmnbWYwSO+lsH/i9e6pQRDCyjwtqObVGJ+THLtcdqR/HkltPp+gjYBAC0vUYzj9EwmQCF7R 9Fw0d20vijTMqb7BrHx/gljXtHAdrWQNA2Z8CXjJ4SYh8FDGjRByNg88WOljFnnzslugeAOK+o vMF2NaWNHaH9lEPBruDinFHte4DNkxoYly7zHeT3QL9riGo6zKukwALSKHyWMcraz1pSjqVtDL vFgc20EAav89NrSfWC1TQe7qC+sGRYTPXxfQKeW+qPn/NoQaolkxFvhZRRTXXOjNob55PX0WMi 4+c= X-SBRS: 4.0 X-MesageID: 41660996 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:O/JmtavBU9L2N74XfUIJIvjO7skCpIMji2hD6mlwRA09T+Wxi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmwybde6+AqXYuKdg/gpWeuMcVe/ZLvqgeQfxHW28x88e Nbc6Z4AMDtFlQSt6zHySSxDtpI+ra62Y+yg+O29RlQZCVLT40l0AtjEAacFSRNNWx7LL40Do CV6MYChxfIQwV1Uu2BCnMIX/fOqrTw/fqLXTc8CwM68w7LtDu06dfBeCSw5AsUUD9E3N4ZgA r4ujH+j5/Dj9iLjiXy+kWWxJRQldvnxLJ4dbGxo/lQEBrAoEKFYIxgXpeLoTw6pvq+gWxa7O XkklMbEOlYr1/XY2GpsTvhsjOQrwoG2jvZ5nKzxVvlvMDjSzoxB6N69PxkWyqc0WUMlpVY8s twrgWknqsSNzzstmDBwuKNcBdQmk+9sRMZ4JUupk0aa6QyQvtst4AFlXkldqsoLWbBx60MNv JhN83Y7OY+SyLhU1np+lNix9GhRR0Ib267a3lHvsSU1g5fl2xiw30Zw9QCnmwB+IhVceg929 j5 X-IronPort-AV: E=Sophos;i="5.81,280,1610427600"; d="scan'208";a="41660996" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Ian Jackson , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Doug Goldstein Subject: [PATCH for-4.15 0/2] CI adjustments Date: Fri, 26 Mar 2021 13:45:56 +0000 Message-ID: <20210326134558.7751-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Adjustements to CI infrastructure for changes in build dependencies. Andrew Cooper (2): tools: Drop gettext as a build dependency CI: Add zstd/etc libraries to build environments .cirrus.yml | 2 +- .travis.yml | 1 - README | 1 - automation/build/alpine/3.12-arm64v8.dockerfile | 1 - automation/build/alpine/3.12.dockerfile | 3 +- automation/build/centos/7.2.dockerfile | 1 + automation/build/centos/7.dockerfile | 1 + automation/build/debian/jessie-i386.dockerfile | 1 + automation/build/debian/jessie.dockerfile | 1 + automation/build/debian/stretch-i386.dockerfile | 1 + automation/build/debian/stretch.dockerfile | 1 + .../build/debian/unstable-arm64v8.dockerfile | 1 + automation/build/debian/unstable-i386.dockerfile | 1 + automation/build/debian/unstable.dockerfile | 1 + automation/build/fedora/29.dockerfile | 1 + automation/build/suse/opensuse-leap.dockerfile | 1 + .../build/suse/opensuse-tumbleweed.dockerfile | 1 + automation/build/ubuntu/bionic.dockerfile | 1 + automation/build/ubuntu/focal.dockerfile | 3 +- automation/build/ubuntu/trusty.dockerfile | 1 + automation/build/ubuntu/xenial.dockerfile | 1 + .../tests-artifacts/alpine/3.12-arm64v8.dockerfile | 1 + tools/configure | 49 ---------------------- tools/configure.ac | 2 - 24 files changed, 21 insertions(+), 57 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Mar 26 13:46:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 13:46:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101827.195012 (Exim 4.92) (envelope-from ) id 1lPmn5-0008VK-B6; Fri, 26 Mar 2021 13:46:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101827.195012; Fri, 26 Mar 2021 13:46:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmn5-0008V4-4C; Fri, 26 Mar 2021 13:46:19 +0000 Received: by outflank-mailman (input) for mailman id 101827; Fri, 26 Mar 2021 13:46:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmn3-0008UZ-PM for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:46:17 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a5fc831d-1c0b-4342-9a7f-7425274862da; Fri, 26 Mar 2021 13:46:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5fc831d-1c0b-4342-9a7f-7425274862da DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616766376; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=750BMnBsidY80ANFlQktnM1w+1rQ3ybeQkufZpAghn4=; b=TZMvWj0O1E3YwZuCFVwagHwZjSRZD4AIYmTIZkQpHIXx6e1p2g8D/Mhn zTZhJzOrLBXuwFibzu9S+wMCe94XU2UsvDGQcsPVQD4E4qRe4geAovYSk c3tuBd3bJlWFlpXYawN/Fn6MqAvCuYB+0Xpz/b0YjAiM6afHDniGue8hm U=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 9HTa7ZgJV2gwEqSwH9fNVeNx5YLj7AaT3A0h+5xI/FI8nNtqz5xbPWGUNn4Dpr78MvEaJjm6KS HiU6Ib+oa3mAw5yed0TWIiqWzSvFwQ6dHq4cS1F9+n4K5rNS0SC+lzCl3W8IC4TYBGV9WHV0kb i8y1fdVHP6yi86wAaBlnPQs5SRw+ZK/dIGElo7pPZIVNomaLFFzEuUD0gc5XXwCJXd9T4dykNU sNiucjK9a/bDjLEFh01u4G4CcbNmKtTbOC7BrfiN7hBx75mtI7u3uds8Rn+ujGJlwPcqfOs0oM RLw= X-SBRS: 4.0 X-MesageID: 41661002 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:rw327q3F47EXEdsJmsCrfAqjBWByeYIsi2QD101hICF9WtCEls yogfQQ3QL1jjFUY307hdWcIsC7LE/035Qd2+ksFJ2lWxTrv3btEZF64eLZslndMgDd1soY76 dvdKBiFMb9ZGIRse/W6BS1euxO/PCp66at7N2x815IbSVHL55t9B14DAHzKDwSeCBjCYAiHJ SRouprzgDQGkg/VciwCnkbU+WrnbSi+K7OWhIaGwUhrDCHkDLA0tXHOiKF1RQTWS4n+8ZBzU H5lWXCh5mLgrWA5TL3k0TS6JlXn9WJ8Ko/OOW8zvI7Bx+ppgKhZIFKU6CPsjYvsIiUmSoXue iJmTgMFYBe7G7QY3GUrHLWqnbd+Qdr0VDO4xu5hmbuusPwTj5SMbs+uatpNiH3xmBlmfMU6t Mt40up86B5IDmFoQHGo//PbB1unlrcmwtYrccjy0ZxfKFbVKVctuUkjSVoOaZFJg3WwqY9Ht JjCcnNjcwmC2+yXjTism5jzMfEZAVLIj62BkwLusmi2zNLhnxOz0wB2MwFnnsbnahNM6V52w == X-IronPort-AV: E=Sophos;i="5.81,280,1610427600"; d="scan'208";a="41661002" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Ian Jackson , Wei Liu , Doug Goldstein Subject: [PATCH 2/2] CI: Add zstd/etc libraries to build environments Date: Fri, 26 Mar 2021 13:45:58 +0000 Message-ID: <20210326134558.7751-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210326134558.7751-1-andrew.cooper3@citrix.com> References: <20210326134558.7751-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain zstd compression support is new in 4.15, but isn't currently tested anywhere in CI. bzip2/zlib was missing in some cases, so add those as well. Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Doug Goldstein For 4.15. Add build time testing for a currently untested feature. This should have been part of the series which included 8169f82049efb but I don't think it really qualifies for a Fixes: tag. RFC for two reasons. First, this needs extending to other containers when I've finished chasing package names, and the CI runs haven't completed yet. --- .cirrus.yml | 2 +- automation/build/alpine/3.12.dockerfile | 2 ++ automation/build/ubuntu/focal.dockerfile | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index fdb1c9c94d..05e72b92db 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -4,7 +4,7 @@ freebsd_template: &FREEBSD_TEMPLATE APPEND_LIB: /usr/local/lib APPEND_INCLUDES: /usr/local/include - install_script: pkg install -y seabios gmake + install_script: pkg install -y seabios gmake zlib bzip2 zstd pkgconf python libiconv bison perl5 yajl lzo2 pixman argp-standalone libxml2 glib git diff --git a/automation/build/alpine/3.12.dockerfile b/automation/build/alpine/3.12.dockerfile index 8631d221db..8d61f3860b 100644 --- a/automation/build/alpine/3.12.dockerfile +++ b/automation/build/alpine/3.12.dockerfile @@ -38,6 +38,8 @@ RUN \ apk add xz-dev && \ apk add yajl-dev && \ apk add zlib-dev && \ + apk add bzip2-dev && \ + apk add zstd-dev && \ \ # qemu build deps apk add bison && \ diff --git a/automation/build/ubuntu/focal.dockerfile b/automation/build/ubuntu/focal.dockerfile index 6c4565745b..0558519a97 100644 --- a/automation/build/ubuntu/focal.dockerfile +++ b/automation/build/ubuntu/focal.dockerfile @@ -30,6 +30,8 @@ RUN apt-get update && \ bin86 \ bcc \ liblzma-dev \ + libzstd-dev \ + libbz2-dev \ # libc6-dev-i386 for Xen < 4.15 libc6-dev-i386 \ libnl-3-dev \ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Mar 26 13:46:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 13:46:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101828.195029 (Exim 4.92) (envelope-from ) id 1lPmnA-00007w-FB; Fri, 26 Mar 2021 13:46:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101828.195029; Fri, 26 Mar 2021 13:46:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmnA-00007p-C7; Fri, 26 Mar 2021 13:46:24 +0000 Received: by outflank-mailman (input) for mailman id 101828; Fri, 26 Mar 2021 13:46:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmn8-0008UZ-No for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:46:22 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c8284796-d387-47d0-b70e-f8555ff22a35; Fri, 26 Mar 2021 13:46:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8284796-d387-47d0-b70e-f8555ff22a35 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616766377; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5Om/4bT9oHNke97XURkVAntc90WqkaYpRePK16Ft6AU=; b=bXCA7vMp7VSeBvqxOK9n/aY3b3aiGuDvY1kpJBv2rLRVlc3xvO4m+Iht YgCyJWz/kl2z7YC8E69qDAxTW/1gg+rgn9Od5+cPOEnP+pU32k8cohNGY U55gKsegAtZJa8Na4n6ssSef6hh/yPrA4Vg5aFc4Pngo4cGQKhZri2VHO 0=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: EbHClvXuJLYR3qeVXLH/U6L88lysVWI9IYjc507tBYIqBPqrR1mWGzqrRApddQHFQFRI+mZu0p dowk+I1Iqnmn5ONi64CYG5CWyo0J4dU3kTxfI+PdoUkzjS54xiVzVX8WxshrM+ohqyRPobcgKt qcCQJm1H7sc8UyifPIJbBeHff5t2vZn5/F3lCdNJ6KjtYB4abr1Q/JyCVqHdxQFTwoxKUz3uMG XmZ7ZwqzcFP0t55XMy3Z9mHKrIZqeISWxlHtrGe0g4e4fI3i5dKUQv+/fRZI5vFVzTLGyAkMDP lg8= X-SBRS: 4.0 X-MesageID: 40222025 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:rohZg6gW6cHI7a1BYz2Y8yWD1XBQXwh13DAbvn1ZSRFFG/Gwv9 yynfgdyB//gCsQXnZlotybJKycWxrnmKJdy4N5B9efdSPhv3alK5wn0Jv6z1TbaknD38N+9Y MlSahxD9XsEUN35PyR3CCUG8stqePpzImGnuHbpk0CcShPS4VNqzh0ERyaFEoefngiObMcGI CH7sRK4xqMEE5nDfiTPXUOU+jdq9CjrvuPDSIuPBI79BKIyQqh9b+SKXOl9y0DWDBCy6pKyx mmryXF4MyY0s2T+1vn+EL4q79Xn9bgzdUrPr3wtuElbg/CpyztSIBoW7iptC04rue1+D8R4a XxiiZlBetfwTf8eXy0vAvM1mDboUkTwk6n83C0qz/CptH0Xz0zAcYpv/MmTjLpr3AOkfs59Y Aj5RP/i7NnSSnusQ642v3zEzZtrUawqWpKq59ps1VvFbEwRZUUkZYS5ypuYfE9NRO/0q8LOs 90AvrR4f5HGGnqFUzxjy1UzNugUm9bJGb+fmEy/sic0z1hlHtk1UcvxMsGgnca9J4mIqM0n9 j5Dg== X-IronPort-AV: E=Sophos;i="5.81,280,1610427600"; d="scan'208";a="40222025" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Ian Jackson , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Doug Goldstein Subject: [PATCH 1/2] tools: Drop gettext as a build dependency Date: Fri, 26 Mar 2021 13:45:57 +0000 Message-ID: <20210326134558.7751-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210326134558.7751-1-andrew.cooper3@citrix.com> References: <20210326134558.7751-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit It has not been a dependency since at least 4.13. Remove its mandatory check from ./configure. Annotate the dependency in the CI dockerfiles which are used for 4.14 or older. Drop the dependency from Alpine and Ubuntu Focal which are new containers in 4.15, as well as dropping from CirrusCI and TravisCI. Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Roger Pau Monné CC: Doug Goldstein CI Proofs of correctness. https://cirrus-ci.com/build/5554642114314240 https://www.travis-ci.org/github/andyhhp/xen/builds/764514317 (x86 builds only. ARM are permenantly broken now.) https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/277055305 (using test Alpine and Focal containers rebuild without gettext). For 4.15. This is long overdue, and simplifies everyones life building 4.15. If this doesn't go into 4.15, then we can't shrink the alpine/focal containers. --- .cirrus.yml | 2 +- .travis.yml | 1 - README | 1 - automation/build/alpine/3.12-arm64v8.dockerfile | 1 - automation/build/alpine/3.12.dockerfile | 1 - automation/build/centos/7.2.dockerfile | 1 + automation/build/centos/7.dockerfile | 1 + automation/build/debian/jessie-i386.dockerfile | 1 + automation/build/debian/jessie.dockerfile | 1 + automation/build/debian/stretch-i386.dockerfile | 1 + automation/build/debian/stretch.dockerfile | 1 + .../build/debian/unstable-arm64v8.dockerfile | 1 + automation/build/debian/unstable-i386.dockerfile | 1 + automation/build/debian/unstable.dockerfile | 1 + automation/build/fedora/29.dockerfile | 1 + automation/build/suse/opensuse-leap.dockerfile | 1 + .../build/suse/opensuse-tumbleweed.dockerfile | 1 + automation/build/ubuntu/bionic.dockerfile | 1 + automation/build/ubuntu/focal.dockerfile | 1 - automation/build/ubuntu/trusty.dockerfile | 1 + automation/build/ubuntu/xenial.dockerfile | 1 + .../tests-artifacts/alpine/3.12-arm64v8.dockerfile | 1 + tools/configure | 49 ---------------------- tools/configure.ac | 2 - 24 files changed, 17 insertions(+), 57 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 0efff6fa98..fdb1c9c94d 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -4,7 +4,7 @@ freebsd_template: &FREEBSD_TEMPLATE APPEND_LIB: /usr/local/lib APPEND_INCLUDES: /usr/local/include - install_script: pkg install -y seabios gettext-tools gmake + install_script: pkg install -y seabios gmake pkgconf python libiconv bison perl5 yajl lzo2 pixman argp-standalone libxml2 glib git diff --git a/.travis.yml b/.travis.yml index 2362475f7a..f3cd15b79f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -54,7 +54,6 @@ addons: - pkg-config - flex - bison - - gettext - acpica-tools - bin86 - bcc diff --git a/README b/README index fad96672af..562b808080 100644 --- a/README +++ b/README @@ -63,7 +63,6 @@ provided by your OS distributor: * bridge-utils package (/sbin/brctl) * iproute package (/sbin/ip) * GNU bison and GNU flex - * GNU gettext * ACPI ASL compiler (iasl) In addition to the above there are a number of optional build diff --git a/automation/build/alpine/3.12-arm64v8.dockerfile b/automation/build/alpine/3.12-arm64v8.dockerfile index d6cdf5b200..01f0eedad4 100644 --- a/automation/build/alpine/3.12-arm64v8.dockerfile +++ b/automation/build/alpine/3.12-arm64v8.dockerfile @@ -22,7 +22,6 @@ RUN \ apk add dev86 && \ apk add dtc-dev && \ apk add gcc && \ - apk add gettext && \ apk add git && \ apk add iasl && \ apk add libaio-dev && \ diff --git a/automation/build/alpine/3.12.dockerfile b/automation/build/alpine/3.12.dockerfile index 94557e239b..8631d221db 100644 --- a/automation/build/alpine/3.12.dockerfile +++ b/automation/build/alpine/3.12.dockerfile @@ -23,7 +23,6 @@ RUN \ apk add gcc && \ apk add g++ && \ apk add clang && \ - apk add gettext && \ apk add git && \ apk add iasl && \ apk add libaio-dev && \ diff --git a/automation/build/centos/7.2.dockerfile b/automation/build/centos/7.2.dockerfile index af672a0be1..4baa097e31 100644 --- a/automation/build/centos/7.2.dockerfile +++ b/automation/build/centos/7.2.dockerfile @@ -26,6 +26,7 @@ RUN rpm --rebuilddb && \ python-devel \ libuuid-devel \ pkgconfig \ + # gettext for Xen < 4.13 gettext \ flex \ bison \ diff --git a/automation/build/centos/7.dockerfile b/automation/build/centos/7.dockerfile index 5f83c97d0c..e688a4cece 100644 --- a/automation/build/centos/7.dockerfile +++ b/automation/build/centos/7.dockerfile @@ -24,6 +24,7 @@ RUN yum -y install \ python-devel \ libuuid-devel \ pkgconfig \ + # gettext for Xen < 4.13 gettext \ flex \ bison \ diff --git a/automation/build/debian/jessie-i386.dockerfile b/automation/build/debian/jessie-i386.dockerfile index 66a6abb381..3f86d91f63 100644 --- a/automation/build/debian/jessie-i386.dockerfile +++ b/automation/build/debian/jessie-i386.dockerfile @@ -28,6 +28,7 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ + # gettext for Xen < 4.13 gettext \ acpica-tools \ bin86 \ diff --git a/automation/build/debian/jessie.dockerfile b/automation/build/debian/jessie.dockerfile index 808d6272e4..2f19adcad3 100644 --- a/automation/build/debian/jessie.dockerfile +++ b/automation/build/debian/jessie.dockerfile @@ -26,6 +26,7 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ + # gettext for Xen < 4.13 gettext \ acpica-tools \ bin86 \ diff --git a/automation/build/debian/stretch-i386.dockerfile b/automation/build/debian/stretch-i386.dockerfile index 7b6f8eff69..c7840d33ab 100644 --- a/automation/build/debian/stretch-i386.dockerfile +++ b/automation/build/debian/stretch-i386.dockerfile @@ -29,6 +29,7 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ + # gettext for Xen < 4.13 gettext \ acpica-tools \ bin86 \ diff --git a/automation/build/debian/stretch.dockerfile b/automation/build/debian/stretch.dockerfile index e3bace1f87..e2ee14e201 100644 --- a/automation/build/debian/stretch.dockerfile +++ b/automation/build/debian/stretch.dockerfile @@ -27,6 +27,7 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ + # gettext for Xen < 4.13 gettext \ acpica-tools \ bin86 \ diff --git a/automation/build/debian/unstable-arm64v8.dockerfile b/automation/build/debian/unstable-arm64v8.dockerfile index 8455d67b72..4409f596e1 100644 --- a/automation/build/debian/unstable-arm64v8.dockerfile +++ b/automation/build/debian/unstable-arm64v8.dockerfile @@ -27,6 +27,7 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ + # gettext for Xen < 4.13 gettext \ acpica-tools \ libfdt-dev \ diff --git a/automation/build/debian/unstable-i386.dockerfile b/automation/build/debian/unstable-i386.dockerfile index 86ff3585df..06ffb97384 100644 --- a/automation/build/debian/unstable-i386.dockerfile +++ b/automation/build/debian/unstable-i386.dockerfile @@ -29,6 +29,7 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ + # gettext for Xen < 4.13 gettext \ acpica-tools \ bin86 \ diff --git a/automation/build/debian/unstable.dockerfile b/automation/build/debian/unstable.dockerfile index 9a10ee08d6..bd61cd12c2 100644 --- a/automation/build/debian/unstable.dockerfile +++ b/automation/build/debian/unstable.dockerfile @@ -27,6 +27,7 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ + # gettext for Xen < 4.13 gettext \ acpica-tools \ bin86 \ diff --git a/automation/build/fedora/29.dockerfile b/automation/build/fedora/29.dockerfile index 5482952523..027b93ceaf 100644 --- a/automation/build/fedora/29.dockerfile +++ b/automation/build/fedora/29.dockerfile @@ -17,6 +17,7 @@ RUN dnf -y install \ python3-devel \ libuuid-devel \ pkgconfig \ + # gettext for Xen < 4.13 gettext \ flex \ bison \ diff --git a/automation/build/suse/opensuse-leap.dockerfile b/automation/build/suse/opensuse-leap.dockerfile index 685dd5d7fd..573fbd8ae4 100644 --- a/automation/build/suse/opensuse-leap.dockerfile +++ b/automation/build/suse/opensuse-leap.dockerfile @@ -22,6 +22,7 @@ RUN zypper install -y --no-recommends \ flex \ gcc \ gcc-c++ \ + # gettext-tools for Xen < 4.13 gettext-tools \ git \ glib2-devel \ diff --git a/automation/build/suse/opensuse-tumbleweed.dockerfile b/automation/build/suse/opensuse-tumbleweed.dockerfile index 061173e751..8ff7b9b5ce 100644 --- a/automation/build/suse/opensuse-tumbleweed.dockerfile +++ b/automation/build/suse/opensuse-tumbleweed.dockerfile @@ -22,6 +22,7 @@ RUN zypper install -y --no-recommends \ flex \ gcc \ gcc-c++ \ + # gettext-tools for Xen < 4.13 gettext-tools \ git \ glib2-devel \ diff --git a/automation/build/ubuntu/bionic.dockerfile b/automation/build/ubuntu/bionic.dockerfile index 408063698c..406a97494c 100644 --- a/automation/build/ubuntu/bionic.dockerfile +++ b/automation/build/ubuntu/bionic.dockerfile @@ -27,6 +27,7 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ + # gettext for Xen < 4.13 gettext \ acpica-tools \ bin86 \ diff --git a/automation/build/ubuntu/focal.dockerfile b/automation/build/ubuntu/focal.dockerfile index 90b4001a6a..6c4565745b 100644 --- a/automation/build/ubuntu/focal.dockerfile +++ b/automation/build/ubuntu/focal.dockerfile @@ -26,7 +26,6 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ - gettext \ acpica-tools \ bin86 \ bcc \ diff --git a/automation/build/ubuntu/trusty.dockerfile b/automation/build/ubuntu/trusty.dockerfile index fd377d948f..b4b2f85e73 100644 --- a/automation/build/ubuntu/trusty.dockerfile +++ b/automation/build/ubuntu/trusty.dockerfile @@ -27,6 +27,7 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ + # gettext for Xen < 4.13 gettext \ acpica-tools \ bin86 \ diff --git a/automation/build/ubuntu/xenial.dockerfile b/automation/build/ubuntu/xenial.dockerfile index 57a71eb8c6..82171d856d 100644 --- a/automation/build/ubuntu/xenial.dockerfile +++ b/automation/build/ubuntu/xenial.dockerfile @@ -27,6 +27,7 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ + # gettext for Xen < 4.13 gettext \ acpica-tools \ bin86 \ diff --git a/automation/tests-artifacts/alpine/3.12-arm64v8.dockerfile b/automation/tests-artifacts/alpine/3.12-arm64v8.dockerfile index 9457009452..7eb1f22940 100644 --- a/automation/tests-artifacts/alpine/3.12-arm64v8.dockerfile +++ b/automation/tests-artifacts/alpine/3.12-arm64v8.dockerfile @@ -19,6 +19,7 @@ RUN \ apk add dbus && \ apk add bash && \ apk add python2 && \ + # gettext for Xen < 4.13 apk add gettext && \ apk add zlib && \ apk add ncurses && \ diff --git a/tools/configure b/tools/configure index 99d08a4d81..33814b24b3 100755 --- a/tools/configure +++ b/tools/configure @@ -689,7 +689,6 @@ INSTALL_PROGRAM SET_MAKE AWK IASL -XGETTEXT FLEX BISON PERL @@ -847,7 +846,6 @@ PYTHON PERL BISON FLEX -XGETTEXT AS86 LD86 BCC @@ -1597,7 +1595,6 @@ Some influential environment variables: PERL Path to Perl parser BISON Path to Bison parser generator FLEX Path to Flex lexical analyser generator - XGETTEXT Path to xgetttext tool AS86 Path to as86 tool LD86 Path to ld86 tool BCC Path to bcc tool @@ -4738,7 +4735,6 @@ LDFLAGS="$PREPEND_LDFLAGS $LDFLAGS $APPEND_LDFLAGS" - # Checks for programs. ac_ext=c ac_cpp='$CPP $CPPFLAGS' @@ -7846,51 +7842,6 @@ fi if ! $rump; then -# Extract the first word of "xgettext", so it can be a program name with args. -set dummy xgettext; ac_word=$2 -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 -$as_echo_n "checking for $ac_word... " >&6; } -if ${ac_cv_path_XGETTEXT+:} false; then : - $as_echo_n "(cached) " >&6 -else - case $XGETTEXT in - [\\/]* | ?:[\\/]*) - ac_cv_path_XGETTEXT="$XGETTEXT" # Let the user override the test with a path. - ;; - *) - as_save_IFS=$IFS; IFS=$PATH_SEPARATOR -for as_dir in $PATH -do - IFS=$as_save_IFS - test -z "$as_dir" && as_dir=. - for ac_exec_ext in '' $ac_executable_extensions; do - if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then - ac_cv_path_XGETTEXT="$as_dir/$ac_word$ac_exec_ext" - $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5 - break 2 - fi -done - done -IFS=$as_save_IFS - - test -z "$ac_cv_path_XGETTEXT" && ac_cv_path_XGETTEXT="no" - ;; -esac -fi -XGETTEXT=$ac_cv_path_XGETTEXT -if test -n "$XGETTEXT"; then - { $as_echo "$as_me:${as_lineno-$LINENO}: result: $XGETTEXT" >&5 -$as_echo "$XGETTEXT" >&6; } -else - { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 -$as_echo "no" >&6; } -fi - - -if test x"${XGETTEXT}" = x"no" -then - as_fn_error $? "Unable to find xgettext, please install xgettext" "$LINENO" 5 -fi case "$host_cpu" in i[3456]86|x86_64|aarch64) # Extract the first word of "iasl", so it can be a program name with args. diff --git a/tools/configure.ac b/tools/configure.ac index 636e7077be..6414fcbb44 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -298,7 +298,6 @@ AC_ARG_VAR([PYTHON], [Path to the Python parser]) AC_ARG_VAR([PERL], [Path to Perl parser]) AC_ARG_VAR([BISON], [Path to Bison parser generator]) AC_ARG_VAR([FLEX], [Path to Flex lexical analyser generator]) -AC_ARG_VAR([XGETTEXT], [Path to xgetttext tool]) AC_ARG_VAR([AS86], [Path to as86 tool]) AC_ARG_VAR([LD86], [Path to ld86 tool]) AC_ARG_VAR([BCC], [Path to bcc tool]) @@ -381,7 +380,6 @@ AS_IF([test "$cross_compiling" != yes], [ if ! $rump; then -AX_PATH_PROG_OR_FAIL([XGETTEXT], [xgettext]) dnl as86, ld86, bcc and iasl are only required when the host system is x86*. dnl "host" here means the platform on which the hypervisor and tools is dnl going to run, not the platform on which we are building (known as -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Mar 26 13:51:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 13:51:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101837.195040 (Exim 4.92) (envelope-from ) id 1lPmro-0001SE-2d; Fri, 26 Mar 2021 13:51:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101837.195040; Fri, 26 Mar 2021 13:51:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmrn-0001S7-Vp; Fri, 26 Mar 2021 13:51:11 +0000 Received: by outflank-mailman (input) for mailman id 101837; Fri, 26 Mar 2021 13:51:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmrm-0001S2-PF for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 13:51:10 +0000 Received: from sender4-of-o53.zoho.com (unknown [136.143.188.53]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id de396abe-a277-4c66-8e06-ce80e09f5c1e; Fri, 26 Mar 2021 13:51:09 +0000 (UTC) Received: from [10.137.0.21] (92.188.110.153 [92.188.110.153]) by mx.zohomail.com with SMTPS id 1616766661875659.6343008552868; Fri, 26 Mar 2021 06:51:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de396abe-a277-4c66-8e06-ce80e09f5c1e ARC-Seal: i=1; a=rsa-sha256; t=1616766664; cv=none; d=zohomail.com; s=zohoarc; b=UdHTAZ0UgXkvGCUiUyuFfIETpcgy//DTcvM5MnJC4f4m81ocpugqWgLSgDppspRZcnC1be+j9nO+gHEWMxJeRvMGXlUurniRxpei3oUlcHj/VXeu/p4y01vDB/EfOTOd3lC4RTcBmTbk/ZCa+Tuj/EjZGUedzzAk+5MXeyWgoJk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616766664; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=7A6f+DxGKA3HdcXnWePE17ILeHLrWnaFVON/gkQQzh0=; b=Q40eIlU84Nau8K6ZsP2jlB3H7rVIAurP0q6nMVVjke0beCXe0pgOAm+LD7xvu+BROaxLl+/Mq94g8VlRL0jhUtE37Mvsw13TPT5eoQ6HxUfsuM+ImsOnTf0wnwVTDI/p4KXYBqd99DI+0IddeW2pbOKuaUz9OtSzK3gwhTJAPtg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=qubes-os.org; spf=pass smtp.mailfrom=frederic.pierret@qubes-os.org; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1616766664; s=s; d=qubes-os.org; i=frederic.pierret@qubes-os.org; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type; bh=7A6f+DxGKA3HdcXnWePE17ILeHLrWnaFVON/gkQQzh0=; b=IkvnlTaBkhtbg3LMl7lv+TIbe3eqKR8JK3lhRffAtalaDJdu80yLWcbUcoYYSP15 gMPUfZEWFstCkuPx83yS8AFkwlF/YkY5yXCm8SLthhcWGR4Itp31JstEk2riTLsVGkO G0zq9/9Gx5Y6mDswUkA+dRvOv3jMT64VJtHmAeS4= Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally To: Andrew Cooper , Xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> From: =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= Message-ID: Date: Fri, 26 Mar 2021 14:50:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210325172132.14980-1-andrew.cooper3@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CpeHFbyDZALDuakzqjMf5J0aw9CVkvBG8" X-Zoho-Virus-Status: 1 X-ZohoMailClient: External This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CpeHFbyDZALDuakzqjMf5J0aw9CVkvBG8 Content-Type: multipart/mixed; boundary="AcoBcncXtEYGzsjjebvs4QQfNZd84yJuu"; protected-headers="v1" From: =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= To: Andrew Cooper , Xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Message-ID: Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> In-Reply-To: <20210325172132.14980-1-andrew.cooper3@citrix.com> --AcoBcncXtEYGzsjjebvs4QQfNZd84yJuu Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi, I confirm your patch makes my Ryzen 7 1800X platform working again! To do= uble check that I've not messed up with xen.gz on my /boot, adding hpet=3D= legacy-replacement makes my computer reboot as the original issue. I hope this will hit stable release! Thank you for that! Best, Fr=C3=A9d=C3=A9ric Le 3/25/21 =C3=A0 6:21 PM, Andrew Cooper a =C3=A9crit=C2=A0: > From: Jan Beulich >=20 > Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPR= C > static PIT clock gating") was reported to cause boot failures on certai= n > AMD Ryzen systems. >=20 > Refine the fix to do nothing in the default case, and only attempt to > configure legacy replacement mode if IRQ0 is found to not be working. >=20 > In addition, introduce a "hpet" command line option so this heuristic > can be overridden. Since it makes little sense to introduce just > "hpet=3Dlegacy-replacement", also allow for a boolean argument as well = as > "broadcast" to replace the separate "hpetbroadcast" option. >=20 > Signed-off-by: Jan Beulich > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monn=C3=A9 > CC: Wei Liu > CC: Ian Jackson > CC: Marek Marczykowski-G=C3=B3recki > CC: Fr=C3=A9d=C3=A9ric Pierret >=20 > v2: > * Drop missing hunk from Jan's original patch. >=20 > For 4.15: Attempt to unbreak AMD Ryzen 1800X systems. > --- > docs/misc/xen-command-line.pandoc | 33 +++++++++++++++++++++++++++ > xen/arch/x86/hpet.c | 48 +++++++++++++++++++++++++-----= --------- > xen/arch/x86/io_apic.c | 26 +++++++++++++++++++++ > xen/include/asm-x86/hpet.h | 1 + > 4 files changed, 91 insertions(+), 17 deletions(-) >=20 > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-= line.pandoc > index a0601ff838..4d020d4ad7 100644 > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -1274,9 +1274,42 @@ supported. See docs/misc/arm/big.LITTLE.txt for = more information. > When the hmp-unsafe option is disabled (default), CPUs that are not > identical to the boot CPU will be parked and not used by Xen. > =20 > +### hpet (x86) > + =3D List of [ | broadcast=3D | legacy-replacement=3D<= bool> ] > + > + Applicability: x86 > + > +Controls Xen's use of the system's High Precision Event Timer. By def= ault, > +Xen will use an HPET when available and not subject to errata. Use of= the > +HPET can be disabled by specifying `hpet=3D0`. > + > + * The `broadcast` boolean is disabled by default, but forces Xen to k= eep > + using the broadcast for CPUs in deep C-states even when an RTC inte= rrupt is > + enabled. This then also affects raising of the RTC interrupt. > + > + * The `legacy-replacement` boolean allows for control over whether Le= gacy > + Replacement mode is enabled. > + > + Legacy Replacement mode is intended for hardware which does not hav= e an > + 8025 PIT, and allows the HPET to be configured into a compatible mo= de. > + Intel chipsets from Skylake/ApolloLake onwards can turn the PIT off= for > + power saving reasons, and there is no platform-agnostic mechanism f= or > + discovering this. > + > + By default, Xen will not change hardware configuration, unless the = PIT > + appears to be absent, at which point Xen will try to enable Legacy > + Replacement mode before falling back to pre-IO-APIC interrupt routi= ng > + options. > + > + This behaviour can be inhibited by specifying `legacy-replacement=3D= 0`. > + Alternatively, this mode can be enabled unconditionally (if availab= le) by > + specifying `legacy-replacement=3D1`. > + > ### hpetbroadcast (x86) > > `=3D ` > =20 > +Deprecated alternative of `hpet=3Dbroadcast`. > + > ### hvm_debug (x86) > > `=3D ` > =20 > diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c > index c73135bb15..957e053a47 100644 > --- a/xen/arch/x86/hpet.c > +++ b/xen/arch/x86/hpet.c > @@ -52,6 +52,8 @@ static unsigned int __read_mostly num_hpets_used; > DEFINE_PER_CPU(struct hpet_event_channel *, cpu_bc_channel); > =20 > unsigned long __initdata hpet_address; > +int8_t __initdata opt_hpet_legacy_replacement =3D -1; > +static bool __initdata opt_hpet =3D true; > u8 __initdata hpet_blockid; > u8 __initdata hpet_flags; > =20 > @@ -63,6 +65,32 @@ u8 __initdata hpet_flags; > static bool __initdata force_hpet_broadcast; > boolean_param("hpetbroadcast", force_hpet_broadcast); > =20 > +static int __init parse_hpet_param(const char *s) > +{ > + const char *ss; > + int val, rc =3D 0; > + > + do { > + ss =3D strchr(s, ','); > + if ( !ss ) > + ss =3D strchr(s, '\0'); > + > + if ( (val =3D parse_bool(s, ss)) >=3D 0 ) > + opt_hpet =3D val; > + else if ( (val =3D parse_boolean("broadcast", s, ss)) >=3D 0 )= > + force_hpet_broadcast =3D val; > + else if ( (val =3D parse_boolean("legacy-replacement", s, ss))= >=3D 0 ) > + opt_hpet_legacy_replacement =3D val; > + else > + rc =3D -EINVAL; > + > + s =3D ss + 1; > + } while ( *ss ); > + > + return rc; > +} > +custom_param("hpet", parse_hpet_param); > + > /* > * Calculate a multiplication factor for scaled math, which is used t= o convert > * nanoseconds based values to clock ticks: > @@ -820,12 +848,9 @@ u64 __init hpet_setup(void) > unsigned int hpet_id, hpet_period; > unsigned int last, rem; > =20 > - if ( hpet_rate ) > + if ( hpet_rate || !hpet_address || !opt_hpet ) > return hpet_rate; > =20 > - if ( hpet_address =3D=3D 0 ) > - return 0; > - > set_fixmap_nocache(FIX_HPET_BASE, hpet_address); > =20 > hpet_id =3D hpet_read32(HPET_ID); > @@ -852,19 +877,8 @@ u64 __init hpet_setup(void) > if ( (rem * 2) > hpet_period ) > hpet_rate++; > =20 > - /* > - * Intel chipsets from Skylake/ApolloLake onwards can statically c= lock > - * gate the 8259 PIT. This option is enabled by default in slight= ly later > - * systems, as turning the PIT off is a prerequisite to entering t= he C11 > - * power saving state. > - * > - * Xen currently depends on the legacy timer interrupt being activ= e while > - * IRQ routing is configured. > - * > - * Reconfigure the HPET into legacy mode to re-establish the timer= > - * interrupt. > - */ > - hpet_enable_legacy_replacement_mode(); > + if ( opt_hpet_legacy_replacement > 0 ) > + hpet_enable_legacy_replacement_mode(); > =20 > return hpet_rate; > } > diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c > index e93265f379..f08c60d71f 100644 > --- a/xen/arch/x86/io_apic.c > +++ b/xen/arch/x86/io_apic.c > @@ -29,6 +29,8 @@ > #include > #include > #include > + > +#include > #include > #include > #include > @@ -1922,14 +1924,38 @@ static void __init check_timer(void) > vector, apic1, pin1, apic2, pin2); > =20 > if (pin1 !=3D -1) { > + bool hpet_changed =3D false; > + > /* > * Ok, does IRQ0 through the IOAPIC work? > */ > unmask_IO_APIC_irq(irq_to_desc(0)); > + retry_ioapic_pin: > if (timer_irq_works()) { > local_irq_restore(flags); > return; > } > + > + /* > + * Intel chipsets from Skylake/ApolloLake onwards can statical= ly clock > + * gate the 8259 PIT. This option is enabled by default in sl= ightly > + * later systems, as turning the PIT off is a prerequisite to = entering > + * the C11 power saving state. > + * > + * Xen currently depends on the legacy timer interrupt being a= ctive > + * while IRQ routing is configured. > + * > + * If the user hasn't made an explicit option, attempt to reco= nfigure > + * the HPET into legacy mode to re-establish the timer interru= pt. > + */ > + if ( opt_hpet_legacy_replacement < 0 && > + !hpet_changed && hpet_enable_legacy_replacement_mode() ) > + { > + printk(XENLOG_ERR "..no 8254 timer found - trying HPET Leg= acy Replacement Mode\n"); > + hpet_changed =3D true; > + goto retry_ioapic_pin; > + } > + > clear_IO_APIC_pin(apic1, pin1); > printk(KERN_ERR "..MP-BIOS bug: 8254 timer not connected to "= > "IO-APIC\n"); > diff --git a/xen/include/asm-x86/hpet.h b/xen/include/asm-x86/hpet.h > index 50176de3d2..07bc8d6079 100644 > --- a/xen/include/asm-x86/hpet.h > +++ b/xen/include/asm-x86/hpet.h > @@ -53,6 +53,7 @@ > extern unsigned long hpet_address; > extern u8 hpet_blockid; > extern u8 hpet_flags; > +extern int8_t opt_hpet_legacy_replacement; > =20 > /* > * Detect and initialise HPET hardware: return counter update frequen= cy. >=20 --AcoBcncXtEYGzsjjebvs4QQfNZd84yJuu-- --CpeHFbyDZALDuakzqjMf5J0aw9CVkvBG8 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEn6ZLkvlecGvyjiymSEAQtc3FduIFAmBd9NAACgkQSEAQtc3F duIVjw/8D0+aZ39Y7iuWzlPayk73WuEFRzXkNSPxxzCjj6DPG4xFiHvrY+WtJ0Nt 7arlLFkSml2IQIkTgf4L9CQrtphFdfS3AJ5QoNlrAFQUaTkWrTBfUv3tg03bh8Ao RuoCOOuCi2TQJUPjP1av5P/ETaiF3YVesT51NQjP8Fco9KWqss+Nc6BcgzvwX+cj Kz9nVMZGVvKxPMM/Ypc64xCVpDpJetmeC8F0UGGFaCP3ARGIs2O3RrMtPSPHH6nv KXhRln62r06s6WSfTgqLDLn+9y5A85qlsdAaO5A9RhUrwXENL12G2gkSp+S43lQE 19IPRn9nfLjUJUi2W39CH6NcL4YbgqySEjJ7hj8gjmB2tUMbV0fxMZ145ugbaxWE e6jUWmvCreiKwKqNctRz+jmLROXsYpjTQfjPJC+4aCKS6IfRtLvkcwMtDo4oq9Po C/bgdAUGPBJxfxZyZwp7Qn107HTe+6BUP6J8bQuPOv/SJu7dAbGsw221kcCB4SoI fgFpgEYXbMGIGl863ROsf1IFRmrdccfUV1dLLVTzGArYwI2iQUshuR5sQ0FLMU36 /dLbB85VKvI0OwkwoV2fuQwuxMqprPomVfo0j7HSFgFDjRCln5ooAUstw9BmOMfz 4XwnGn8UTsnQiPWm9yXyP0RbtDTMyhKhepzmOI9Y/+cPKfL+Uy4= =2qOX -----END PGP SIGNATURE----- --CpeHFbyDZALDuakzqjMf5J0aw9CVkvBG8-- From xen-devel-bounces@lists.xenproject.org Fri Mar 26 14:02:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 14:02:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101843.195053 (Exim 4.92) (envelope-from ) id 1lPn2t-0002rc-9E; Fri, 26 Mar 2021 14:02:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101843.195053; Fri, 26 Mar 2021 14:02:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPn2t-0002rV-6C; Fri, 26 Mar 2021 14:02:39 +0000 Received: by outflank-mailman (input) for mailman id 101843; Fri, 26 Mar 2021 14:02:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPn2s-0002rQ-EZ for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:02:38 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 30e4fb7c-4bf5-425f-95c7-f4d1272e32ef; Fri, 26 Mar 2021 14:02:37 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2D7F6AC6A; Fri, 26 Mar 2021 14:02:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30e4fb7c-4bf5-425f-95c7-f4d1272e32ef X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616767356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J6CTX9kVf2wzcBi/c7IGV/cdbIcuVu/9B07tfs5pNXg=; b=pPqCwvIEt2ghLGRRLVozVBVAiHCRBAdYUgJXIrrxr5M79GjxxXnxSvLAALOUqeA6pIzQSC qFUVz0c73LclFQ6k9vtOyms8sS80bsAkxlRo5jIbwmjtuJW6izpeyxLK3WW3lyOsleG0g+ Fr4Hr0X3SbxA5ToRqEfKlfnN+JMFW6w= Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Ian Jackson , Andrew Cooper , Xen-devel , Wei Liu , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <24669.52641.499147.88002@mariner.uk.xensource.com> <24669.54213.173154.400771@mariner.uk.xensource.com> From: Jan Beulich Message-ID: Date: Fri, 26 Mar 2021 15:02:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 26.03.2021 14:43, Marek Marczykowski-Górecki wrote: > On Fri, Mar 26, 2021 at 02:30:09PM +0100, Jan Beulich wrote: >> On 26.03.2021 13:29, Ian Jackson wrote: >>> I wrote: >>>> I'm sorry, but I think it is too late for 4.15 to do this. I prefer >>>> Jan's patch which I have alread release-acked. >>>> >>>> Can someone qualified please provide a maintainer review for this, >>>> ideally today ? >>> >>> I asked Andrew on IRC: >>> >>> 12:08 andyhhp__: Are you prepared to maintainer-ack Jan's >>> more-minimal hpet workaround approach ? >>> 12:16 Diziet: honestly, no. I don't consider that >>> acceptable behaviour, and it is a fairly big "f you" >>> (this was literally feedback I got in private) to >>> the downstreams who've spent years trying to get us >>> to fix this bug, and have now backported the first >>> version. >>> 12:16 I'm looking into the feedback on my series >>> 12:17 one way or another, the moment we enter the fallback >>> path for interrupt routing, something is very broken >>> on the system >>> 12:19 so the tradeoff is an unspecified bug on one ancient >>> laptop which can't be tested now, vs 5 years of Atom >>> CPUs, 2 years of latop CPUs, and the forthcoming >>> Server line of Intel CPUs >>> 12:19 or whatever other compromise we can work on >>> >>> I'm sorry that this bug is going to continue to be not properly fixed. >> >> Actually I had another thought here in the morning, but then didn't >> write it down: While Andrew's approach indeed would (hopefully) >> improve user experience, it'll reduce the incentive of actually >> fixing the issue. Normally I might not be that concerned, but seeing >> how long it took to even arrive at a workaround, I'm afraid now I am >> concerned. > > I assume "the issue" you meant "Xen using legacy stuff that stops being > supported by the hardware", right? Yes it is an issue. But for most > users of Xen, having it broken more likely will results in "lets switch > to something that works" (perhaps not after the first such case, but > this is definitely not the first one) instead of "lets spend some hours > on debugging this very low level issue". Like sadly is the case in so many areas nowadays, this to me suggests that you value short term benefits over things working correctly long term. Yes, it is important to be attractive to users. But this would better not be at the price of keeping in place workarounds for overly long periods of time, possible even forever. Such is likely to bite us (perhaps by way of biting some of our users) down the road. To be honest, I find it very strange that the original report over a month ago was never followed up by the necessary technical detail. Andrew did tell me that outside of the report on the mailing list he did explicitly ask for such. (I can't rule out that meanwhile he was given the info, but really all of this would better be on xen-devel.) > And to be honest, this is more and more appealing option, even though > all the deficiencies of KVM... Well, feel free to throw more engineering resources into Xen's (upstream) maintenance. There being a much larger community of engineers around KVM is perhaps the main reason here. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 26 14:07:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 14:07:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101846.195064 (Exim 4.92) (envelope-from ) id 1lPn7O-00032T-Rh; Fri, 26 Mar 2021 14:07:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101846.195064; Fri, 26 Mar 2021 14:07:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPn7O-00032M-Oa; Fri, 26 Mar 2021 14:07:18 +0000 Received: by outflank-mailman (input) for mailman id 101846; Fri, 26 Mar 2021 14:07:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPn7N-00032H-PF for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:07:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPn7N-0008JC-Ml for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:07:17 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPn7N-0002O0-Ll for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:07:17 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPn7F-0002l6-Dy; Fri, 26 Mar 2021 14:07:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:CC:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=mbdj9qMK5fAVTq8jbTpx8PlkEojetXFvmPFUtkRUyhs=; b=kIUEhUJ1Ej+WRI+LvHIzzJ1IeD ygupU7Sa2aVZx1O51xwNwYqpJw13+aVGdzbWmmdY5Xyc3SzRhbNLoHgK4q20ozlIdtawwdx4dNgOR vIfJCBYnQy7pGlncIMphw7NMzHbW7h752jjsykh5j8saIK/AnUKT5hkHY3297Zqhv4kk=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.60045.100353.660483@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 14:07:09 +0000 To: committers@xenproject.org CC: Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Andrew Cooper , Xen-devel , Wei Liu , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , =?iso-8859-1?Q?Fr=E9d=E9ric?= Pierret , Tamas K Lengyel Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally In-Reply-To: References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <24669.52641.499147.88002@mariner.uk.xensource.com> <24669.54213.173154.400771@mariner.uk.xensource.com> <24669.56958.383583.53595@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally"): > TBH delaying the release for this specific problem should be seriously > considered imo. In principle I'm in favor of (3) of the above, if there > weren't the downsides I did mention in prior mails. Thanks for putting forward your opinion. I am always happy to hear what people say and this input is very valuable. However: I am not inclined to delay the release over this. Delaying the release might be appropriate if this problem was unforeseen and recently discovered, late in the freeze. But it was not. That there was a significant regression caused by e1de4c196a2e x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating was already known at least by the 24th of February[1]. Since then, that change has been at risk of being reverted if it went unfixed. Unfortunately the the first cut of patches to try fix this something like properly were only posted yesterday. It is up to everyone who wants something to make it into the release, to make sure that the code is ready in time. That includes sorting out any regressions it introduces. In the case of e1de4c196a2e that has not occurred. It doesn't seem to me that we will have sufficient confidence in the more comphrenesive fix, for it to go into staging-4.15 today. I think the appropriate course, therefore, is the conditional (based on commaned line) revert proposed by Jan. Sorry, Ian. [1] https://lists.xenproject.org/archives/html/xen-devel/2021-02/msg01533.html From xen-devel-bounces@lists.xenproject.org Fri Mar 26 14:11:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 14:11:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101852.195077 (Exim 4.92) (envelope-from ) id 1lPnAw-0004CR-B3; Fri, 26 Mar 2021 14:10:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101852.195077; Fri, 26 Mar 2021 14:10:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnAw-0004CK-7s; Fri, 26 Mar 2021 14:10:58 +0000 Received: by outflank-mailman (input) for mailman id 101852; Fri, 26 Mar 2021 14:10:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnAu-0004CF-8w for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:10:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnAt-0008NT-QY for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:10:55 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPnAt-0002cE-PO for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:10:55 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPnAq-0002mQ-9a; Fri, 26 Mar 2021 14:10:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=1R3ySF5CbH94c9fx9B2ycerhqIEhh+lWWSAV80xKuts=; b=NBz4z4Lc2Uf4Uhbza+c3fKmS1a ftI5mPbD+RS83XcUacgGo1dnsrPkJUQre16sv7q4lFbHH5+WzhyWAOAq/hJxmzZ8IkDYFMH+WGBlg pG8cWszo46C12OND/eKgxshc1jgkSKc6ixSVAj/z3WdWus1YhfiFZMSGH/67SkMSXBV0=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.60267.962692.954979@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 14:10:51 +0000 To: Andrew Cooper Cc: Xen-devel , Wei Liu , Doug Goldstein Subject: Re: [PATCH 2/2] CI: Add zstd/etc libraries to build environments In-Reply-To: <20210326134558.7751-3-andrew.cooper3@citrix.com> References: <20210326134558.7751-1-andrew.cooper3@citrix.com> <20210326134558.7751-3-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH 2/2] CI: Add zstd/etc libraries to build environments"): > zstd compression support is new in 4.15, but isn't currently tested anywhere > in CI. > > bzip2/zlib was missing in some cases, so add those as well. Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Fri Mar 26 14:11:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 14:11:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101855.195089 (Exim 4.92) (envelope-from ) id 1lPnBs-0004IJ-MG; Fri, 26 Mar 2021 14:11:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101855.195089; Fri, 26 Mar 2021 14:11:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnBs-0004IC-II; Fri, 26 Mar 2021 14:11:56 +0000 Received: by outflank-mailman (input) for mailman id 101855; Fri, 26 Mar 2021 14:11:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnBr-0004I6-GU for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:11:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnBr-0008OI-FT for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:11:55 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPnBr-0002rM-Eh for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:11:55 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPnBo-0002ml-3Z; Fri, 26 Mar 2021 14:11:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=NDs9LJv5miCPxP4WTPqCudxbmlJR2d4Or+PC4BHlkfs=; b=anymUpxzj8e/3j8wltoR5UXGzi CPqgreDFfxsX1FT5BbLi0VZ3d0RKUphwO5eGJiaK3iPs6iaEsCf7krCTFiMXOxw9kd2e2PCUiZzoM pvwsg+JLGrSyWEWfIDcyJU7h+jwuWyk6Oniq7qk8HgAxQSvJ1E1edsFwsuWR7Dvm8XKg=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.60327.951693.886187@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 14:11:51 +0000 To: Andrew Cooper Cc: Xen-devel , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Doug Goldstein Subject: Re: [PATCH 1/2] tools: Drop gettext as a build dependency In-Reply-To: <20210326134558.7751-2-andrew.cooper3@citrix.com> References: <20210326134558.7751-1-andrew.cooper3@citrix.com> <20210326134558.7751-2-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH 1/2] tools: Drop gettext as a build dependency"): > It has not been a dependency since at least 4.13. Remove its mandatory check > from ./configure. > > Annotate the dependency in the CI dockerfiles which are used for 4.14 or > older. Drop the dependency from Alpine and Ubuntu Focal which are new > containers in 4.15, as well as dropping from CirrusCI and TravisCI. Thank you but I'm afraid I think that this is not an important bugfix for 4.15. So I am withholding my release ack for this patch. Feel free to explain to me why this is the wrong decision. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 14:16:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 14:16:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101858.195101 (Exim 4.92) (envelope-from ) id 1lPnG1-0004TT-7u; Fri, 26 Mar 2021 14:16:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101858.195101; Fri, 26 Mar 2021 14:16:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnG1-0004TM-3I; Fri, 26 Mar 2021 14:16:13 +0000 Received: by outflank-mailman (input) for mailman id 101858; Fri, 26 Mar 2021 14:16:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnFz-0004TH-PP for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:16:11 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:7e8a::618]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 35b15f68-447b-4754-b68b-20a472b2789e; Fri, 26 Mar 2021 14:16:10 +0000 (UTC) Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM6PR12MB3082.namprd12.prod.outlook.com (2603:10b6:5:11b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Fri, 26 Mar 2021 14:16:07 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::c9b6:a9ce:b253:db70]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::c9b6:a9ce:b253:db70%6]) with mapi id 15.20.3955.027; Fri, 26 Mar 2021 14:16:07 +0000 Received: from office-linux.texastahm.com (67.79.209.213) by SN6PR04CA0098.namprd04.prod.outlook.com (2603:10b6:805:f2::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24 via Frontend Transport; Fri, 26 Mar 2021 14:16:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35b15f68-447b-4754-b68b-20a472b2789e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZC9otA5g2mDB20qGi7QNQ8MxvsQq/m/gf+a1qnyhnxjxHdd4Yh/uBChVjoJrlFjfvmnYLpb/RPCaPYDLZ70YbawU4mOKuLbXSWbwdr7rH8yYsHx2zB86JpFwHf1KQ0azf5XCq2meK/4nKcaAl40S/Cu2NgCBm6aM+iyNMshmsf3Fd6RFlJMmM9Tb1gr0tJsAtaXBEfd+yUNwLSKoOj88EmbS+74x2jC5yN+2rxPXTSmdZPv3d/xbgbUuGPcDaBfAqFe2W+4vE5YMt4KYcv5W20PqX+Yx9avUGP2+QXcVOh1V8ghXRnAPZTDowUhRFpmeLYG9rHGoXetl6mdC2KiLsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rX89sLHWd/73HhmUvv2w153fQonSprl22X6LtZB8ubA=; b=fop+SaP3cURItncBk7fRc5ivSR6SKg9QV7QKWX8fH/D1VbwDYmpxeHtGtK+i5G7C/3vav1NayjfupWGakFFi7dPzsLFIJ0hV6pc39lsx7Qx3WrDYNhfDtMyq3jton2Am9QS0W6gcmmQzirvYr3Fmb/QsJWO1ndlAkGPVSD7eR1b5gMRK83iqaDM06h5+87G363b5b1KcCQtKDkFvCnBBoVsnt6wWymtTV9yg+7gnPYxlJ0BP5xI3ukeJs3SI2qDXQBe51ZJbzdYHg71eHbuBI+RLElqyp4VQ1bwc5K23OjI4NXLv+j5VjXui/liS29y18cgFoPKApKdkwpxwARzqtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rX89sLHWd/73HhmUvv2w153fQonSprl22X6LtZB8ubA=; b=RIkGXXklqz8VKTh7nb044vK7WyGAEZQH+l/AKqp+0rU8YNJjfCigVwF4FxyVmoX+OJ5lO1vK3Vyiv3+OH1C8GOI+1L4dzoIcuAxrTF+H9FwpmpWZEM6CsAIHZKSzJz8Vvgniys3qT3u/ahAGRheHYEAknHubZFZgstH9qzXJ3Do= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH v2 4/7] OvmfPkg/IndustryStandard: Introduce PageTable.h To: Anthony PERARD , devel@edk2.groups.io Cc: xen-devel@lists.xenproject.org, Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Julien Grall , Brijesh Singh References: <20210325154713.670104-1-anthony.perard@citrix.com> <20210325154713.670104-5-anthony.perard@citrix.com> From: Tom Lendacky Message-ID: <90eb3caa-2116-e665-7dde-3fc7198409f2@amd.com> Date: Fri, 26 Mar 2021 09:16:04 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <20210325154713.670104-5-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [67.79.209.213] X-ClientProxiedBy: SN6PR04CA0098.namprd04.prod.outlook.com (2603:10b6:805:f2::39) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 3fbc1895-1a6a-4516-4ab4-08d8f061b25b X-MS-TrafficTypeDiagnostic: DM6PR12MB3082: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: St3U24wg0P/0i+5LyvSJwo0gD0FYHy31jX/c5phowPHquF/4YsCd5dTU5ZkLVv0GoSwkiM3UcADWQ00na63vdD9yz1qNT+h3zNx3KXct8Mo5fSKT/J9vvGNXN2bcXAqeH17G27IseyQSyJf8XE6CHryacj5HQ/DCSxepKOPDuey9UjdKXtI+66tGlENY9nWRzrc9p/SZhWOtvjl1g2qlS59sdwIk6W56WkCytvMnbYfTjUtEsesDqN6+Yq7JGKSvqRCDrefA3/hIj3Va7Z7WLCuVmhXo1SHaxEtodmoz9kdbS7R/efv+pTweYhzehwn0AXK6IrGZRmOtzrE6EGAYvTshOocvcFM8gApqfXeEqetdkar9HEppzcIc7hLG48lIwI/6BawzpqB1EOrfoqarYD8/+sUKQfZRVGbMRwNs692u5TmakHRsbBUGXTKs0N8mKF7Mieko6m56+W6LtqcUzFfGvl7wDYlQeZeOZYVLVYuDZPGw1wtQEpy0hs+I2fcWSefRuXV8Lwi8jQ7G0nmVnqMtg07FLA2JFeiqFJY5Cj2pP7v6ZxRf3yHmZfIODwynl7o5GV1UGLUHYfhjmTGq0E7o+lv6LPBnYRF5IWKLwne0EWbLRxGhLGjV4UzUeK8dB6zxrI9IBKy1hyxkBA+ZcsOnSaMxyBhqmeCCnkYgsY0AnmNHiwMGfmOYAe0y/1LPv1ktE5GUvvKpSDnEjgU8OeMqkIrjPNcEvsC6l/mK6WiooGWiHtOsCLXxeGBM3adb4mbrHzUJZw6iv7bvPDwQt7jphj2rKaymAJLtqo9u7d53Ke1I04GCeKecAYtK9Wn4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(366004)(376002)(39860400002)(396003)(86362001)(8676002)(956004)(6486002)(8936002)(31686004)(2616005)(2906002)(54906003)(6512007)(16526019)(38100700001)(53546011)(31696002)(6506007)(5660300002)(83380400001)(19627235002)(26005)(4326008)(66556008)(478600001)(316002)(66946007)(186003)(36756003)(66476007)(966005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Ujg4Y1JsajZ2TW9pZ1BuWm51NUlQblpVR0k1R3JjcFpxRy9BMjBPdFV3YWZH?= =?utf-8?B?SWEvL0JQUC8xRU5tcjlLVmtLbU1vU1FVWENPQ1N1SStDTTBCV3pBNEVGU0xr?= =?utf-8?B?T21RaHJucEUzRlM1bzNveEh1dTNYZHZ1ZFF0U1BVYUlORzVnc215eXBpNGw1?= =?utf-8?B?Z1BmQk8rL0kxYjhxVmlWZjlqRWtnT0tQTjZYMkJZOEl0aXRSV2lKVjh5NEFD?= =?utf-8?B?SDNLS0tlRU05bURmN25lTHRZc2pQZlpydmVNUWRnZ2N3VnBUbU9raEZtMHdS?= =?utf-8?B?QU9YVDhCZzJsK0l0VWNUc0FCbm9xZk8ySVoya3Nub3lKdTVCS213d29RN0Ry?= =?utf-8?B?WjBTdkF2ZFYzbWJ2cHd2RUxQNjcvL2xkWTNSbUlubmFzSGpDNEwxMjZTSEgr?= =?utf-8?B?RXo0cjZGT1ZvWXB4K3JlREpHS1VyYVZtamt2QncxOWtxcTlGYS9SclI4ZUU5?= =?utf-8?B?VE9MQnlQSE5HVnd0VEZUZXpkd0U2RzFkVU9oTUx3RE0yRlM1SDZrNldEMXBN?= =?utf-8?B?a1BxT0Z1aVp6QWVUTkJ1dDkwWUcxcXNXY3FScGhELy9MSzh2bkxpa2xsNG9j?= =?utf-8?B?aWRaNTVPT0g4ZGQyVmVMU2V0emlTMDNQa0tsaHFsZWNZellCZm5UbVREbXh5?= =?utf-8?B?Q1VjYTM5NlRoQ2IxN25PSVBpbktPRkcrSEtjM2J5QVNYNzlFQVc2cVVTU1Nr?= =?utf-8?B?dW9DQnlpY2RNTXdVK2EwMHhHY3lmU0ZiU1lWcGRhV1IvSFdwQWpCVnZvRDNX?= =?utf-8?B?UnU5cElpZjhGRW5US1dvc0dyZlVuRFB0TlZMQ2h3a05qcnRXeVgrUkhsUDhZ?= =?utf-8?B?MU10K1VjNTI1SXcrWXUwNEVNczdJczlURDhXN3VrWklrMjRPVE5Gb2s3WE9C?= =?utf-8?B?Uy94Tk1jc2tVbjVyYng4c0VBUnBzY2lXM0FvUXpMWjR6MlRUWlllOFA1WDQz?= =?utf-8?B?MndET25FMitNTDhYVXQ1ckFqZS95Y2tTWFRmOC91ZnVPWndJQTVSYjRFYWxx?= =?utf-8?B?ZzZpZzZBbWpLQk1iUUNielJWMFBmdFJzZTJpS09qai9keWdEZTdaRUlySitQ?= =?utf-8?B?MHZ6WWM3UVB2VjZwcCtNUUc5Ymg4UmhjZnpDN0FPbXY5VHhTNDlWL241dytI?= =?utf-8?B?b1hMNmp0UlJvRXI2dXYwY2g3VC9NUWlXMW02Q2hsMnpTTGFOSGNwT1FCRlpB?= =?utf-8?B?MW9LY1duMkpJdEwxYysvQUIwbnZGcU5NcU9wOXJvNmE0Y0t2ZVJJdExWUHov?= =?utf-8?B?MExQbmNjK0NxbkMxazRHRDZDNmUxbUlvVE9TbEdXemVvYW5DdjViS2hKUVNu?= =?utf-8?B?MkRNWXN4T3BaTzVpY29PRGVhTWZ6QUZxaGhQb0Ewa1BKY3MzV21GL3Nybkw1?= =?utf-8?B?QnBUbXhaSGFxdWY3OWs0Y0paa3pEK0pnalRsaTZsZHFDVVQvWmtyM1pvVE02?= =?utf-8?B?T004RVdWeC91SHRZakdQdHY0SjRaeFRrNGlsN3AvRmFvOHVNQUQ5R1pydVRm?= =?utf-8?B?dFBEdmJ6clQ1VWlXWlBHSWtLbU42UkMyMGZwRkZxY1dGVzlReWh5NC9xTjJj?= =?utf-8?B?QzgyaXhXdmRiWXBBTGxyTWE3RHphSUlOWE90ZzhPMDIxdi9IdUUrelV5VFZr?= =?utf-8?B?ZVNYTzBnVVhMVXNmZDJmYzdsclZQUDB2aE9keVVSUncxRlVCc2tHTzhoQnNL?= =?utf-8?B?ODQ1MFU0bDI1a3pyaXoyeTZabklOTlIzVW0xVHBWZFlvV2Z4QkdROWdXcGth?= =?utf-8?Q?RE3/Oz228LSM4dOiDhsklmxpsVrp2yXCFTbpn67?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fbc1895-1a6a-4516-4ab4-08d8f061b25b X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2021 14:16:06.9515 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3RfZUBYh35QtejxXijajR9mslXpCyNJ/EGHeo9NvMKhlCb0ibmhKBhkkzOQ3MouRHwWyb7aNBg1Z/OtYWok6Lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3082 On 3/25/21 10:47 AM, Anthony PERARD wrote: > We are going to use the page table structure in yet another place, > collect the types and macro that can be used from another module > rather that making yet another copy. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 > Signed-off-by: Anthony PERARD This begs the question of whether there should be only one version of this header file, now. There are still copies in other places, but maybe that can be a future cleanup? I'll leave that decision to Laszlo. With one minor comment below, otherwise: Acked-by: Tom Lendacky > --- > CC: Tom Lendacky > CC: Brijesh Singh > --- > > Notes: > v2: > - new patch > > .../IndustryStandard/PageTable.h} | 117 +------------- > .../BaseMemEncryptSevLib/X64/VirtualMemory.h | 143 +----------------- > 2 files changed, 5 insertions(+), 255 deletions(-) > copy OvmfPkg/{Library/BaseMemEncryptSevLib/X64/VirtualMemory.h => Include/IndustryStandard/PageTable.h} (60%) > ... > diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h > index 996f94f07ebb..b621d811ca6f 100644 > --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h > +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h > @@ -20,151 +20,10 @@ > #include > #include > #include > +#include Typically, these are preferred to be in sorted order. Thanks, Tom > > #define SYS_CODE64_SEL 0x38 > From xen-devel-bounces@lists.xenproject.org Fri Mar 26 14:24:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 14:24:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101861.195113 (Exim 4.92) (envelope-from ) id 1lPnNL-0005dw-0Q; Fri, 26 Mar 2021 14:23:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101861.195113; Fri, 26 Mar 2021 14:23:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnNK-0005dp-Tj; Fri, 26 Mar 2021 14:23:46 +0000 Received: by outflank-mailman (input) for mailman id 101861; Fri, 26 Mar 2021 14:23:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnNJ-0005dk-H7 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:23:45 +0000 Received: from wout1-smtp.messagingengine.com (unknown [64.147.123.24]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2db2a846-a461-44cf-a28c-8edefa33ab27; Fri, 26 Mar 2021 14:23:44 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id C791C1DDF; Fri, 26 Mar 2021 10:23:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 26 Mar 2021 10:23:43 -0400 Received: from mail-itl (ip5b434f04.dynamic.kabel-deutschland.de [91.67.79.4]) by mail.messagingengine.com (Postfix) with ESMTPA id D2D821080069; Fri, 26 Mar 2021 10:23:40 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2db2a846-a461-44cf-a28c-8edefa33ab27 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=B+PWZz GIGZMcZCasGPOutLgZCgy2i6mExlUGj4BuK6U=; b=M8KdocXrmy7tizpAKdTdLV TZFFsZrJz6znzg/mU/UXEpddX8r4DLlWXuA4/8nop8rQfXvtbaxq0qVIHZDa3eJV F/uD0X2sOevZ0rqlGI6zKmX8n3UrOo4aesTUV5m4noJ7altpHmfUJN5OzQe6VB6w yp26G+SfLR+Xx/KIzd1DRGSYcD5DbIFDiYt3WXbK6O556rTdyrst9wA3T8M0IhLR uHJSSVCXeB819dN+SEZZ/aJ00Qadv3C1daz7lbktQEvRE2jaPDbHk1s7+k6lhK7i EFJRCGGqWdRxv83mC7b52eYrYhyMwYY8MS6NPzHnyu3YsOUnL24uH4UOEywCpbow == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehvddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucfkpheple durdeijedrjeelrdegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg homh X-ME-Proxy: Date: Fri, 26 Mar 2021 15:23:37 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Ian Jackson Cc: Tamas K Lengyel , Roger Pau =?utf-8?B?TW9ubsOp?= , Andrew Cooper , Xen-devel , Jan Beulich , Wei Liu , =?utf-8?B?RnLDqWTDqXJpYw==?= Pierret Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally Message-ID: References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <24669.52641.499147.88002@mariner.uk.xensource.com> <24669.54213.173154.400771@mariner.uk.xensource.com> <24669.56958.383583.53595@mariner.uk.xensource.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pTHhN0EPPVJ3qMme" Content-Disposition: inline In-Reply-To: <24669.56958.383583.53595@mariner.uk.xensource.com> --pTHhN0EPPVJ3qMme Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 26, 2021 at 01:15:42PM +0000, Ian Jackson wrote: > Tamas K Lengyel writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable lega= cy replacement mode unconditionally"): > > The problem from my perspective is that the end-users have no way to > > determine when that boot option is needing to be set. Having an > > installation step of "check if things explode when you reboot" is just > > plain bad. Many times you don't even have access to a remote serial > > console to check why Xen didn't boot. So that's not a realistic route > > that can be taken. If Jan's patch is applied then the only thing I'll > > be able to do is make all installations always-enable this option even > > on systems that would have booted fine otherwise without it. It is > > unclear if that has any downsides of its own and could very well just > > kick the can down the road and lead to other issues. >=20 > Thanks for the clear explanation. >=20 > I think our options are: >=20 > 1. What is currently in xen.git#staging-4.15: some different set of > machines do not work (reliably? at all?), constituting a > regression on older hardware. >=20 > 2. Jan's patch, with the consequences you describe. Constituing a > continued failure to properly support the newer hardware. >=20 > 3. Andy's patches which are not finished yet and are therefore high > risk. Ie, delay the release. I do have several confirmations that the "x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating" patch indeed unbreaks several Intel systems. And only one report about it causing a regression on some AMD (although I may miss some others on the list). Reverting to the previous default behavior I would also call a regression. I have tested Andy's patches on several machines and I can confirm they fixed the issue - both keep the original issue fixed and fixes the regression. I see also Fr=C3=A9d=C3=A9ric (who originally reported the regression) also confirms it fixes it for him. > Please let me know if you think this characterisation of the situation > is inaccurate or misleading. Both versions (with "x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating" and without it) got significant testing and results are as you summarize - each of those variants alone is broken on some subset of hardware. What Andrew's patches do is to combine both versions into one, to choose the right behavior depending on the hardware. Specifically, apply the workaround in place of direct panic. This isn't some completely new behavior. I think it is reasonably safe to have it included in the release, even at such late time. > This is not a good set of options. >=20 > Of them, I still think I would choose (2). But I would love it if > someone were to come up with a better suggestion (perhaps a variant on > one of the above). --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --pTHhN0EPPVJ3qMme Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEyBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmBd7mkACgkQ24/THMrX 1yzZXwf1HJXU3Z2L2lG2TCKfBbh0y5hH/Ehy8X7iyma+zE7OZylcSnuKju55xKCm pR8YMdzLWBj1r1QozBfNcpnOis/uQq+egF+VdrHL6ukyNyJw/gNX3WbrOwhwDuD3 2NZBz3RyfrxGwyzuOdxAev9+j13Q6Q4sd8hZ+0Lqp8beKXsKBt5L9jBL4Ye5a++U i6Y1qg3k4MBvXjxhBFN9iAQr3RtNY4dIz0e1chbyp0b4j91yHacErAwjpuwdnQkR jU3OlFoctMfWrJ4W8H1A360YFec1oIHJCJEGpDWy9GC+Ymduv6Unqf7jUYkiFSV6 Ds0cyVSgmQTMsAQnvKVSIqcMdexf =Xc10 -----END PGP SIGNATURE----- --pTHhN0EPPVJ3qMme-- From xen-devel-bounces@lists.xenproject.org Fri Mar 26 14:25:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 14:25:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101867.195124 (Exim 4.92) (envelope-from ) id 1lPnOf-0005n4-EE; Fri, 26 Mar 2021 14:25:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101867.195124; Fri, 26 Mar 2021 14:25:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnOf-0005mx-BA; Fri, 26 Mar 2021 14:25:09 +0000 Received: by outflank-mailman (input) for mailman id 101867; Fri, 26 Mar 2021 14:25:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnOe-0005ms-33 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:25:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnOd-0000Bk-W4 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:25:07 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPnOd-00040X-VD for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:25:07 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPnOY-0002rX-S7; Fri, 26 Mar 2021 14:25:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=s3NOeMHYURNegzXa1jHT5ftjd4FkSGaEmcw1yCvvYYE=; b=ssYqb8k/g62GXzx7yZFUUBgotO c9Vi9zELSXiVKVuiG8UVhpkT1vZFPUiwipgeXKKutk8ED6nuegrSDbtjdLRGS+ohHbK9m12O1/Okk 9S6+ftH4svRv9qAfq4A2aEBJwvn27rVNE0urZT0/dE3YDPVmktS2lMWYRduJiwRAxOas=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.61118.533307.438087@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 14:25:02 +0000 To: Andrew Cooper , Jan Beulich Cc: Xen-devel , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Boris Ostrovsky Subject: Re: [PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351 [and 1 more messages] Newsgroups: chiark.mail.xen.devel In-Reply-To: <20210316161844.1658-1-andrew.cooper3@citrix.com>, <24658.7471.309734.168120@mariner.uk.xensource.com> References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> <24658.1583.601613.903527@mariner.uk.xensource.com> <4b1c13ee-f121-3379-6fb3-c0d4dbb76e48@citrix.com> <24658.5692.932979.892439@mariner.uk.xensource.com> <24658.7471.309734.168120@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351"): > This is slightly complicated. Patches 1 and 2 rearrange the code to look and > behave more like 4.14, and patch 3 fixes a Solaris (and turbostat) bug in a > manner which can be backported to all security trees. As far as I can tell this series needs a respin ? I have been through the thread and AFAICT the only comments were on the commit message for patch 2. Patchex 1 and 3 already have a release-ack. Patch 2 does not have any mind of maintainer review. I would like this series to go in today. Jan, since Andrew doesn't seem to have been able to do that respin yet, would you be able to rewrite the commit message of message 2 taking into account the two comments from you an from Roger ? I think that is all that's needed for these three to go into tree. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 14:30:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 14:30:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101871.195137 (Exim 4.92) (envelope-from ) id 1lPnTv-0006xY-1i; Fri, 26 Mar 2021 14:30:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101871.195137; Fri, 26 Mar 2021 14:30:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnTu-0006xR-Uu; Fri, 26 Mar 2021 14:30:34 +0000 Received: by outflank-mailman (input) for mailman id 101871; Fri, 26 Mar 2021 14:30:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnTu-0006xM-HU for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:30:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnTu-0000Hu-DA for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:30:34 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPnTu-0004TC-Bq for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:30:34 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPnTp-0002so-95; Fri, 26 Mar 2021 14:30:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:CC:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=ju68MeNhVPpzW1mJ35m09CFVF6R0B4c7DKG5MCZmKKA=; b=SZzKngsjwXY4sdDS5Taoh+9g4V JoDFUD99qyBM+22NaobuGxJpVW1cUazu6W8+nfELZNQhpZcYJ+knaxk/4ZZfBjVlSX/mD1UqQ/4hM 6UgniAoOrqcZ8GX42KKWbU+B9CBEXgA5hHyqbMR+zqhMa6AZEs+uzNZofm7vqaaoUI8g=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.61445.44470.436950@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 14:30:29 +0000 To: Jan Beulich , Andrew Cooper CC: Xen-devel , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Boris Ostrovsky Subject: Re: [PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351 [and 1 more messages] Newsgroups: chiark.mail.xen.devel In-Reply-To: <24669.61118.533307.438087@mariner.uk.xensource.com> References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> <24658.1583.601613.903527@mariner.uk.xensource.com> <4b1c13ee-f121-3379-6fb3-c0d4dbb76e48@citrix.com> <24658.5692.932979.892439@mariner.uk.xensource.com> <24658.7471.309734.168120@mariner.uk.xensource.com> <24669.61118.533307.438087@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Ian Jackson writes ("Re: [PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351 [and 1 more messages]"): > Andrew Cooper writes ("[PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351"): > > This is slightly complicated. Patches 1 and 2 rearrange the code to look and > > behave more like 4.14, and patch 3 fixes a Solaris (and turbostat) bug in a > > manner which can be backported to all security trees. > > As far as I can tell this series needs a respin ? > > I have been through the thread and AFAICT the only comments were on > the commit message for patch 2. Patchex 1 and 3 already have a > release-ack. Patch 2 does not have any mind of maintainer review. Err, this is wrong. It is [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd, wr}msr()" which has comments on the commit message from Jan: So would you mind adjusting the description accordingly? [...] "In hindsight, this was a poor move [..,] and Roger: I think it might be worth adding that guest access to those MSRs will now always trigger a #GP [...] I could easily fold in Jan's comments but it would be better for someone more familiar with the code do handle Roger's since Roger doesn't provide a precise wording. These two [PATCH 2/3] x86/msr: Forward port XSA-351 changes from 4.14 [PATCH 3/3] x86/msr: Fix Solaris and turbostat following XSA-351 have reviews from Roger. > I would like this series to go in today. > > Jan, since Andrew doesn't seem to have been able to do that respin > yet, would you be able to rewrite the commit message of message 2 > taking into account the two comments from you an from Roger ? > > I think that is all that's needed for these three to go into tree. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 14:34:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 14:34:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101876.195149 (Exim 4.92) (envelope-from ) id 1lPnY1-00077l-SA; Fri, 26 Mar 2021 14:34:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101876.195149; Fri, 26 Mar 2021 14:34:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnY1-00077e-Nq; Fri, 26 Mar 2021 14:34:49 +0000 Received: by outflank-mailman (input) for mailman id 101876; Fri, 26 Mar 2021 14:34:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnY0-00077Z-S7 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:34:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnY0-0000N9-RM for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:34:48 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPnY0-0004uk-Qa for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 14:34:48 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPnXx-0002u4-Ei; Fri, 26 Mar 2021 14:34:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID: Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=QqJI5eBJti3okSfZ0BENAHRAGswSef7Wxc78tuAYsm4=; b=obHJitTIRbdXJ/JGE8c0hQsQcd okIZCDar9AfqcraDesFPrgy+w6+6zCNb7kBZQi2HEi9v0TlcMC9kpnRD3p4TEOasxuZGbuRUVw6O6 fpzGOCbN9VPSAN7jvU8mnv2S1fbb1Yfdtgdk8loNcf7MkUXjVuOR2oUCCJY6IRz12J+w=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.61701.287453.961124@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 14:34:45 +0000 To: committers@xenproject.org CC: xen-devel@lists.xenproject.org Subject: [ANNOUNCE] Xen 4.15 release update X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) I think all outstanding blockers have been addressed (although, not necessarily in an ideal way), or will be today. Please commit *all code changes* with a release ack *by the end of today*. I intend to cut a final RC on Monday (29th of March). I hope to release very soon after Easter (late in the week of the 5th of April). The tree will continue to be open until the middle of next week for docs and tests updates. Apart from that code changes will not get release acks unless they are low risk *and* fix serious bugs. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 15:03:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 15:03:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101885.195167 (Exim 4.92) (envelope-from ) id 1lPnzG-00028v-1C; Fri, 26 Mar 2021 15:02:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101885.195167; Fri, 26 Mar 2021 15:02:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnzF-00028o-UJ; Fri, 26 Mar 2021 15:02:57 +0000 Received: by outflank-mailman (input) for mailman id 101885; Fri, 26 Mar 2021 15:02:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPnzE-00028j-Cf for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 15:02:56 +0000 Received: from mail-wr1-x42c.google.com (unknown [2a00:1450:4864:20::42c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2669dcae-f1c4-4ca0-b37c-5c60924001da; Fri, 26 Mar 2021 15:02:55 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id v4so5917651wrp.13 for ; Fri, 26 Mar 2021 08:02:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2669dcae-f1c4-4ca0-b37c-5c60924001da DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9EYukUCk06xcb646EbCae7no7wfvl6VLDADq1vmXI0o=; b=UCfji/lf2+3c4rSZzxazPjWPC898HA8GGZwCJCzL6OG3pDG6eNirjxr/TLKHz3ihP+ SGEQbHdFtCcRthNqtZLbcbUn3sRrvAm/wRBJ3NFyE5sj5T1TmJYk4Xn+RCtdhp90hjpU C1HKq8ygyHs94tMVj19jm02EwJzgEwKhYAuW/X5hUur2cvsxXby7xjiLUxhSrbhnytP7 ghgN3Tflnoz3+DaZGzZ/y79sNWWQhcqFZGu1jkBJ+bgu7ODNMJZDjvrH2xVlZDd30xR5 nU+uESq4K1qXYYqy0FGndVjZT+E1+LQrTy7nNxUVcRaKoRBIlrsWLGVWOwk7xMOdWopJ 7A/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9EYukUCk06xcb646EbCae7no7wfvl6VLDADq1vmXI0o=; b=cQHgAn8296wSm8Zdofvhyl7PKB+j8hhhd7KZYpeCL1J7fHGxTSofp6jEDCc87aKdXb sqhWzPrSkRg5vtbrYCrzwJePbo17mmSzwD1ChtXnPpPuqGPsa8+68+u3yDAxIE8kJgZ8 PviEHO0x4WAOpcxpAIcbzzfgEyGbxy4RzCVS88ltiwd/efYKTTOH7/P4Eq98yDRyE6xd vFWlLanl2sxq+nZAe8iHHck+3JM4hnyQu7t/pPLZ3obyEa3PJN/hmoJxEo7EFoPrCG6A BIlBrevDCWYBqLqIbW7tIQO1BW7P5RunIqD018sl6jldqrQiwaaFUEPSL5PJDbMb3ONj cvNQ== X-Gm-Message-State: AOAM533FxGnh5nF3ufFdu2N03m9CyuCfbcn45JRzf6+t+H70pQDXVsvy WXWZeJlAP37sjUYdqyxZc9E6SDoaYxq/1IC4esY= X-Google-Smtp-Source: ABdhPJzyl8yBvQgG0/9UIcl5dGLmnaDWMPcygHi/+H4XVougHZg/YSgITwlPMoIK+9iH0sRHaGYzdsizzjg8D055+lE= X-Received: by 2002:adf:efc7:: with SMTP id i7mr14774994wrp.182.1616770974401; Fri, 26 Mar 2021 08:02:54 -0700 (PDT) MIME-Version: 1.0 References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <24669.52641.499147.88002@mariner.uk.xensource.com> <24669.54213.173154.400771@mariner.uk.xensource.com> <24669.56958.383583.53595@mariner.uk.xensource.com> In-Reply-To: From: Tamas K Lengyel Date: Fri, 26 Mar 2021 11:02:18 -0400 Message-ID: Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: Ian Jackson , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Andrew Cooper , Xen-devel , Jan Beulich , Wei Liu , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Mar 26, 2021 at 10:23 AM Marek Marczykowski-G=C3=B3recki wrote: > > On Fri, Mar 26, 2021 at 01:15:42PM +0000, Ian Jackson wrote: > > Tamas K Lengyel writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable le= gacy replacement mode unconditionally"): > > > The problem from my perspective is that the end-users have no way to > > > determine when that boot option is needing to be set. Having an > > > installation step of "check if things explode when you reboot" is jus= t > > > plain bad. Many times you don't even have access to a remote serial > > > console to check why Xen didn't boot. So that's not a realistic route > > > that can be taken. If Jan's patch is applied then the only thing I'll > > > be able to do is make all installations always-enable this option eve= n > > > on systems that would have booted fine otherwise without it. It is > > > unclear if that has any downsides of its own and could very well just > > > kick the can down the road and lead to other issues. > > > > Thanks for the clear explanation. > > > > I think our options are: > > > > 1. What is currently in xen.git#staging-4.15: some different set of > > machines do not work (reliably? at all?), constituting a > > regression on older hardware. > > > > 2. Jan's patch, with the consequences you describe. Constituing a > > continued failure to properly support the newer hardware. > > > > 3. Andy's patches which are not finished yet and are therefore high > > risk. Ie, delay the release. > > I do have several confirmations that the "x86/timer: Fix boot on Intel > systems using ITSSPRC static PIT clock gating" patch indeed unbreaks > several Intel systems. And only one report about it causing a regression > on some AMD (although I may miss some others on the list). > Reverting to the previous default behavior I would also call a > regression. > > I have tested Andy's patches on several machines and I can confirm they > fixed the issue - both keep the original issue fixed and fixes the > regression. > I see also Fr=C3=A9d=C3=A9ric (who originally reported the regression) al= so > confirms it fixes it for him. > > > Please let me know if you think this characterisation of the situation > > is inaccurate or misleading. > > Both versions (with "x86/timer: Fix boot on Intel systems using ITSSPRC > static PIT clock gating" and without it) got significant testing and > results are as you summarize - each of those variants alone is broken on > some subset of hardware. What Andrew's patches do is to combine both > versions into one, to choose the right behavior depending on the > hardware. Specifically, apply the workaround in place of direct panic. > This isn't some completely new behavior. I think it is reasonably safe > to have it included in the release, even at such late time. My preference would also be going with route 3, if possible in 4.15 from the start. If that can't happen without significant delay to the release then it should be the first patch to be included for 4.15.1. Thanks, Tamas From xen-devel-bounces@lists.xenproject.org Fri Mar 26 15:04:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 15:04:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101888.195179 (Exim 4.92) (envelope-from ) id 1lPo0o-0002HD-CL; Fri, 26 Mar 2021 15:04:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101888.195179; Fri, 26 Mar 2021 15:04:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPo0o-0002H6-9F; Fri, 26 Mar 2021 15:04:34 +0000 Received: by outflank-mailman (input) for mailman id 101888; Fri, 26 Mar 2021 15:04:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPo0m-0002Gy-A4 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 15:04:32 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 234b433f-7c5c-4260-bb5b-1ef1b52de579; Fri, 26 Mar 2021 15:04:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 234b433f-7c5c-4260-bb5b-1ef1b52de579 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616771071; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=POZK0SEB8+3+pl+ZTLR6JNgeKpAxwiaBERHnA7valOk=; b=Yz7IYf8zfgCl4IfLCnuzK9Tlku8PXIBCxIILXhJBuAdn80h930feUR11 iVqZeRAIhh7YcFYCFTkfwdjGexR9e7NxcxcIk8aga3vBeeG+cg2CP9ijm AM2giz8vpEMys/zXyoN8aknvlL0VFAONmRfkrr8TzaYugAXOZHrolCVgM I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: iHIIWWgkd1Hjdb4FE2sQJEaWGliFqc2Yq/uhh8oP/o2E2UKpAgeBLUZAZC/AdUz95i0nGZQ5MZ /eJ87Y0+oN7GvOTKpI4kR4Ts1SlKT7d7BjhQ31jA+wiMlbzteCnVIjheSTWTZ+7poiBs3naK2o BTvHqyYsSnvGX1H/wSn2zkgORZKRC7PsViIzSGCaaEMG6JuJjb8I5RyKyAaTmhz+jOtnOtUvEh IOEdtuarcdnoDiIPfiVzptVFhskQzWr42oL6eodqllMdGjJwdYoRGE51y+VYEv2oPcYCEe99dR WJM= X-SBRS: 5.2 X-MesageID: 40377433 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:2Mrp0K4MJj+xanJBjwPXwSeFI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoexLh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdRHW3tV2kZ 1te60WMrLNJHBxh8ri/U2cG9Ev3NGI/MmT9Jrj5l1qShxnbLwlyg9/BBqSHEEefng7ObMSEp 2A6s1b4wexYHh/VLX2OlApV/XOzue77a7OTgUBA3ccmWuzpBOurIX3Ch2JmioZOgk/u4sK1U jgv0jH6r64s/e9oyWsmFP7y5hNgtPuxp9iKaW3+7AoAw7hgAqpe4htMofq1FpZzIHfi2oCq9 XCrwwtOM5+8RrqDxqIiCDgxhX613IW42LioGXyvVLYvcf7SDgmYvAx4b5xTxrD50Is+PF63a 5btljp0aZ/MBLakCzxo+XPThFh/3DExkYKrOh7tQ07baIuLJtq6aAP9kJcF5kNWAjg7po8Le VoBMbAoN5LbFKzdRnizydS6e3pek52MgaNQ0AEtMDQ+SNRhmpFw0wRw9Fatmsc9ag6V4JP64 3/Q+VVvYALavVTQbN2Be8HT8fyIHfKWwjwPGWbJkmiM60bJXTXqdrS7K8u7O+nPLwEpaFC2K jpYRd9jyofakjuAcqB0Nlg6RbWWliwWjzr14VQ/J58trrgRKf6MCGKRVw0+vHQ4ck3M4n+Yb KeKZhWC/jsIS/FAoBSxTDzXJFUND0fXaQuy5MGcmPLhviOBpzht+TdfvqWDqHqCywYVmT2BW ZGWDDyIc5H/126Q3OQummUZ1rdPmjEub5gGqnT+OYejKIXMJdXjwQTgVOloseRKTNDtaQydF BkIKzul766oWXexxeK00xZfj5mSmpF6rTpVH1H4SUQNVnvTLoFs9KDPXxJ0GCfPR95RcPOGA tZr1B6kJjHaKC49GQHMZaKI2iah3wcqDa2VJ8agLSE/tqgUIg/FIwaVKt4EhjrGxR5lR1xkn pKbBYJSybkZ3XToJTgqKZRJenEM/FgnQ+gIKdv2A3inHTZgftqe1w2cHqFV9WNjQMnWjxO72 cBjZM3sf6ngjagKWw2neIiFkZDAV7nWY5uPUCOYYNJl/TwdAttVmeWlVWh+kAOU1uv/UAVmm GkNyGfZerKH0oYl3BX3rz2mWkEKFm1TgZ7b3ZnvMlmGW7boXZvwau1ZrGuyXGaYlxq+JBBDB j1JTEWJB9ig8q63gKPmCuTUX8hwZIjNPG1NsV9T5jjnnmpLpGE0bsLFeNO/It0cNr0ovYXON jvITO9HXfzDuU01kiOqnw4IylouD0okenj3RXk6GSitURPXcb6ERBtQrcGLpWH42L5XPaUwN Fjgdg0pOu9NXiZUK/c9YjnKzRHLA/f5XS7Rf0yqY1F+bg/s7Z+BPDgIGP1/XlawRQzK9r1nk sCQKJ9pKvMIJNrYtZ6QVMpwnM50NuIN0clqQrwH6s3ekwslWbSO5eT76PPsqdHODzLmCLgfV 2e+TZa5fHLQm+K0qMbEbs5JQ1tGQEBwWUn+OOJbIvLDgq2M+lF4VqhK3e4NLtQUrKMF7lVrh F05biz7qeqXju93ADbpj1gJK1St26hXMOpGQqJXfdS7MbSAyX5voK6pMqoyDvnQzqybEoVwY VDaEwLd8xGzj0vlpc+3CS+QrH+y3hV2Wd28HVijBrgy4Km6GDUEQVdPQrVjo5fUDNTPnKL5P 61h9SwxTD4+nxIyJPDHEBfcpVSANAWVJHwNDorJs4KvrKklpBfzxhrcVMrFSo7hz/81e89gu v81/XWRuH4CXDnfVgG4iVIA4Zoniot7WFMGvLOn66Vc0ESDKoPBfB6+4Vd1DRuoVL350cHbx psuhczv7u9WWDPLjB5D+z2gYDygBIEv6CM5F1luWVIljqc+SKhkkmwm9zwpmE9oGLcpBJ2sK mRRDM+hyBCqw5sqJYRR0alQCrrWnOKMFT+0asuNzlkEAkUupUWsCY= X-IronPort-AV: E=Sophos;i="5.81,280,1610427600"; d="scan'208";a="40377433" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lYdhipyOeDdCZbsbLfuMM8wdS+69ehSznJEoHU669nBcFOTBcbTe37RPac9t6The+3YppEnAsScKH0KSw2NotfLA88kXjKyA+OyciqJw/P61AvX3UE0pTBTRCi58k02jhX7Np3U+XD8ZVeunie2zkADPetdP48GWdMK6J9+HRNKwjU9ls29qRM0MEym8Qku+hl3jeXlc0/PnmPmTnQW9lOhXPkaHUvTG1B6B9/grYzbl0r99oUl3uF9Yt3JcW+DQqLVvtR8TiIafO8Ay1ZgY+hjSZZ5jyA9m5/KjGI4vXdfUz9YoSUahnEpXUkPbF3JbFQeX+ejpq0tMHLf1j2ne4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=POZK0SEB8+3+pl+ZTLR6JNgeKpAxwiaBERHnA7valOk=; b=gAFXZ9XcxnLk3PS3OlIUU/ev/lm9IwwCLKMph2b/rzJyGT09Dqvfa36h6ypq6JoQ3Svwn6UGIf/DDr4KCo9tTcsB+ldrU1VgbOs5k/Q3W130Ldp4IOo+nwFucOBOsbR89VIZqaSSLLxxPAuP4xKLw/D+wqVbch7VhzWgXFssWYQV+80qJIcOq8PMyHr1KO9rWw2H6WP5lz2FCM18GpyAxoZkOWbMiIJ48aAmStVor1MqW3890vAY6RKDZK708PZhNnmWLcwFPbnEDXnu6y/nu+2SmRfJFjkGa/KT/Q9DaEPu9IPL08VBeAXAM/PRLoyOlK3IcwqdiFv/6fDveS8wDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=POZK0SEB8+3+pl+ZTLR6JNgeKpAxwiaBERHnA7valOk=; b=XNqed11FzFdY6eRQSldYfZnsnKuriVU29Z8LTkEBr+hF80y5U4fTXf61dOvbMLRPQe3tJOgb3krCrxwJXKzTQwvZTxwBYvs4tAlh33w4qb7AZgB6/n4GkpN6kTCVEKPuOvXQVR8+MZQr99KiIfwh6Ijb7nhe+fDE6ahT5RroxG4= Subject: Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking To: Tamas K Lengyel , CC: Tamas K Lengyel , Jan Beulich , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: From: Andrew Cooper Message-ID: <4785d809-956e-07d1-0d5a-ee5ccb54e097@citrix.com> Date: Fri, 26 Mar 2021 15:04:21 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0106.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::22) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5decbac3-419b-4ed3-3ddd-08d8f0687308 X-MS-TrafficTypeDiagnostic: BN7PR03MB3617: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yafINrfZktGbnqHUZSa9DO9lZPp016Fvqp+H5pAJnfMYCJ0RkzDm/3MZCPHr//XWdxZ1cE4Pk36wi3Iu8GiKRBdGRNuFHItH/45cPdHhpmra1eOV2Z5qlGuq+tyITVaGkWVhognaEGVwyZiEExLewdRbRJjL3cWEyf/nitFBDxxEfO2pyb3cvcluuajyTQBymXUWq+QcbGnpXYhxZFXAcBtlOGF+aTnIb5qhLkvsLZX9dunznsC8iIjq43pqRX/nYKNjUG7HtXFPiXxb0oeGagJC2zvOpeX98WgVUlV/8bz6H8EXRpWGc6tSWYyIh9e/Snrl+4BW7f65oMQXC3pW52HXPMz61GaSjtKDjA1Gha4MfoWB2fMaQR7EVkCQCRCYUPatcXOL7/FbXwE8mA0CrnUyxztceh2wRtWt0AzjF+zS9BPSU5XfobcqSFokPTiD3SmNb61m9C/5Cu/eMazxU/7CSse3kuSZNl+esVpkZOpY+SwdZlH+5reUUnR5gE2GFpdkQksgD6pa2YJ4hZCIi4jvrm7TXCust95ySPKdSe7PhMjnP69bwxH68xbXhfsTGx6zSgPTeyqzSMrIFlRsZv5H/QSSIBJbkrjk8LnXHYRLtrKhzKDzX2sUl1tEoTsd3HKmXBwkxQuiKGj7uUBnyuwxE6oATX4yGn0SJb8ZRCFZvQdA2/F+7ROLg5GdDFpF8FQ1s++xtzxwhZRzoP96fw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(396003)(376002)(366004)(39860400002)(8676002)(38100700001)(36756003)(31686004)(53546011)(26005)(316002)(8936002)(478600001)(66476007)(66946007)(5660300002)(2906002)(2616005)(54906003)(6666004)(16576012)(6486002)(4744005)(16526019)(186003)(4326008)(86362001)(66556008)(31696002)(956004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eXozc0EwV0c5VGNBNENRNHdlazZEbzFkSGxYc0Vab2NrNWN1OTByUkliMTJE?= =?utf-8?B?RENnZ001WjNOQUsrTUtkNys1eGEwa0t2UXRtKzBJeUppUGgzeHpHOS8rZjZ6?= =?utf-8?B?b0NkUGxvT1M5RzZ6dmQrVEQ3eThDUzkydmlwdUNCYlBhU2ZuSHl4U1FRRStj?= =?utf-8?B?UkZqOGNlRnJ1RStYWHBtWHJvUDc1TDBsVHBsY2ErLy9SNG5OQzFNVHUvMW0v?= =?utf-8?B?QTAxamN5VzRtMUhNeEZTajdHVTBRSUdXYVNHNHNWU3pBSlBNWjFjNmdZOGN1?= =?utf-8?B?a0VtTCsyVmV5M1YzR3NTbmxaV2t3S2dqUEhyblVwN0pQSjNiZGJuVWRGMHFJ?= =?utf-8?B?cE5DVCtlYkxLRnJ0eGFyUVRvK2M5MU8rL2V5V25ENVJXaDNKWnpCd1ZpY2pE?= =?utf-8?B?VUJzK1J2d3h1enp2K01ZOVIvOTJVYkpxTkZUWjd5R1lnYmp2K2JQWkp2alNm?= =?utf-8?B?OFQ5ZHdNVVkxMnEwQlR1R3dHM3ZUQUEzbE9QY2RYWWNKTmVVTmM4NVU5NFJy?= =?utf-8?B?K3FnOHZpOU5ZNHNaQUVsT0J3Z0RDYmM3NHYwQmFTb2k3ZGd3cGdqeVg2aFdl?= =?utf-8?B?YVI0OC9ycC9CSWFhNVl5bUkvMDFlVHBYREM1dFpVUE5YOVNrSWN6NnllbTNY?= =?utf-8?B?bzNDc0toRzh0bFZVRm5XUzU2UGs2QlFpNVV3dEJWTFVKL1VNZXp3TXUxSXhK?= =?utf-8?B?akoyT2RsQTBvY1JDMXo5enhBZjhrUkNXdFlyc2dNeXB1VlNOQXlKaG9pajlk?= =?utf-8?B?Sjd1aFZXeVNwWnVKTHJ1L3NxUmNseFQyY3czSmhhaWlYcWs4dmNISkM0Rjhm?= =?utf-8?B?b1d1MkR6eHUvQWpmQ0liZ1hRbGNNbmtScFdnZVF1OWdubXJaNEVEbzZkeTdp?= =?utf-8?B?Qm15WUlmWmFwSDlaaEtkaURMR1R1OWJVVHN6NzRpeFZUYnVCSC9idGpOcGlv?= =?utf-8?B?ajROSnhnbG5NK1p5VGMrVHJIQlVtT2ZQc25pdzNkcE93MnltVEl2SjNDZElS?= =?utf-8?B?b3FOT3NURk04RXg2SkNNRzVvWG9xbzNWMlp0U25xa3diNkpuN1ZIa1NEVU9N?= =?utf-8?B?cW1BaHIzdW5wcTdJUlF5WFYxdndSY2J6TXZSNjZ1cGVDd21IUDVQNWwrenEr?= =?utf-8?B?WDhvMEsycmVFSzNGU0MxeG9OSndQSnQ3QWxTcnBhajRYQS9nQnNNbVpHTTlQ?= =?utf-8?B?S3hvWUdJRXk2a2RUTW54blQrdWd0UzA0TWJDU29BZitrdzJTWmtsWUwxOTRU?= =?utf-8?B?ay8yM3M4cHdwdXlMc3Nsa2pSWlM3U3ZFZlpaUVFkaXdycFZ0UndQQVc1cm1X?= =?utf-8?B?L0xtUUY3ZStLc2dWNVRFSDB4bFZjOU0yWWg4aEo2UWRZMzBxZTl3Y0o3c1pQ?= =?utf-8?B?bDBoWTI4eXBEczNPZUZyWTNqcE5FT21MckxZNVJhenFHdEpmMGJMRGlwbXRi?= =?utf-8?B?SGxDTlY0bDhTSDZPKzJpVEk1cXF3UTJWNDVCUTFjbnlraUVaSTdCZmlxNWk3?= =?utf-8?B?a3AxRXN0WGZQVlRlWUo3MzFITzEzelowc2E5UjJZajFnVnpYMGc4VlJialYr?= =?utf-8?B?VCtWZGxtb0srLy8ycUl5YW1HNmx2NStpNFZVcWx1ZnhRbWkrOXhENGhEMW8r?= =?utf-8?B?elR1cmRScHRNY1lKSExnOFUvN1VVZDdhejNlcjFSWHpDS245ZGl4ejVYMXJu?= =?utf-8?B?enNYRlB6RGJJem5mMHk5RVRnVVkwZlYvUzVsUmlHZ2NEaml2Q3l2amdoV1RU?= =?utf-8?Q?1e86NJhpcAkDKQMRMuxfIFw1RaIHp86mUbGMfOL?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5decbac3-419b-4ed3-3ddd-08d8f0687308 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2021 15:04:27.2958 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: olvionpR29HyjIh3aKmOyBmNs8JZABCwMsKAok8G2+51b6RcpNkdOy7ckPQV5hhHE3Q9a5+WaiiHt34wx5ZSrCFf+QKAVdO6fVC+vn/AWZA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3617 X-OriginatorOrg: citrix.com On 18/03/2021 21:36, Tamas K Lengyel wrote: > When creating a VM fork copy the parent VM's hostp2m max_mapped_pfn value. Some > toolstack relies on the XENMEM_maximum_gpfn value to establish the maximum > addressable physical memory in the VM and for forks that have not yet been > unpaused that value is not going to reflect the correct max gpfn that's > possible to populate into the p2m. This patch fixes the issue. > > Signed-off-by: Tamas K Lengyel Reviewed-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Fri Mar 26 15:08:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 15:08:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101897.195191 (Exim 4.92) (envelope-from ) id 1lPo4p-0002kh-3F; Fri, 26 Mar 2021 15:08:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101897.195191; Fri, 26 Mar 2021 15:08:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPo4o-0002ka-Vh; Fri, 26 Mar 2021 15:08:42 +0000 Received: by outflank-mailman (input) for mailman id 101897; Fri, 26 Mar 2021 15:08:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPo4n-0002kV-HS for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 15:08:41 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id efc78848-211b-49c9-ae4c-c99aae012304; Fri, 26 Mar 2021 15:08:40 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CAE40ADFB; Fri, 26 Mar 2021 15:08:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efc78848-211b-49c9-ae4c-c99aae012304 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616771319; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bxwBoGm/HtY2XjH6TUAwMmPqJZhSB5i77uC61meo8AE=; b=GmBfnL4hwNGpnb7yMgLiLDucVuLqnIV+72oVJLz8hcMkr4WwvoJ5Szkm1179gbw2b1s9E2 IuOfbuWr+0yM91qurByFdkxzl7UiabdSrgpwghsNVx8bLHZK0SltX+QMioUPdhEYAJL200 V/9qgB53KFNz6gdq/ah1G+YzDwhnz3g= Subject: [PATCH for-4.15 v1.1 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" To: Ian Jackson , Xen-devel Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Boris Ostrovsky , Andrew Cooper References: <20210316161844.1658-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: Date: Fri, 26 Mar 2021 16:08:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210316161844.1658-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit From: Andrew Cooper In hindsight, this was a poor move. Some of these MSRs require probing for, cause unhelpful spew into xl dmesg, or cause spew from unit tests explicitly checking behaviour. This restores behaviour close to that of Xen 4.14, meaning in particular that for all of the MSRs getting re-added explicitly a #GP fault will get raised irrespective of the new "msr_relaxed" setting. Signed-off-by: Andrew Cooper Signed-off-by: Jan Beulich Reviewed-by: Jan Beulich Release-Acked-by: Ian Jackson --- v1.1: Fold in suggested description adjustments. --- For 4.15. Restoring behaviour closer to 4.14, and prereq for a bugfix needing backporting. --- xen/arch/x86/msr.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 0ebcb04259..c3a988bd11 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -175,6 +175,30 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) switch ( msr ) { + /* Write-only */ + case MSR_AMD_PATCHLOADER: + case MSR_IA32_UCODE_WRITE: + case MSR_PRED_CMD: + case MSR_FLUSH_CMD: + + /* Not offered to guests. */ + case MSR_TEST_CTRL: + case MSR_CORE_CAPABILITIES: + case MSR_TSX_FORCE_ABORT: + case MSR_TSX_CTRL: + case MSR_MCU_OPT_CTRL: + case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): + case MSR_U_CET: + case MSR_S_CET: + case MSR_PL0_SSP ... MSR_INTERRUPT_SSP_TABLE: + case MSR_AMD64_LWP_CFG: + case MSR_AMD64_LWP_CBADDR: + case MSR_PPIN_CTL: + case MSR_PPIN: + case MSR_AMD_PPIN_CTL: + case MSR_AMD_PPIN: + goto gp_fault; + case MSR_IA32_FEATURE_CONTROL: /* * Architecturally, availability of this MSR is enumerated by the @@ -382,6 +406,30 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) { uint64_t rsvd; + /* Read-only */ + case MSR_IA32_PLATFORM_ID: + case MSR_CORE_CAPABILITIES: + case MSR_INTEL_CORE_THREAD_COUNT: + case MSR_INTEL_PLATFORM_INFO: + case MSR_ARCH_CAPABILITIES: + + /* Not offered to guests. */ + case MSR_TEST_CTRL: + case MSR_TSX_FORCE_ABORT: + case MSR_TSX_CTRL: + case MSR_MCU_OPT_CTRL: + case MSR_RTIT_OUTPUT_BASE ... MSR_RTIT_ADDR_B(7): + case MSR_U_CET: + case MSR_S_CET: + case MSR_PL0_SSP ... MSR_INTERRUPT_SSP_TABLE: + case MSR_AMD64_LWP_CFG: + case MSR_AMD64_LWP_CBADDR: + case MSR_PPIN_CTL: + case MSR_PPIN: + case MSR_AMD_PPIN_CTL: + case MSR_AMD_PPIN: + goto gp_fault; + case MSR_AMD_PATCHLEVEL: BUILD_BUG_ON(MSR_IA32_UCODE_REV != MSR_AMD_PATCHLEVEL); /* From xen-devel-bounces@lists.xenproject.org Fri Mar 26 15:14:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 15:14:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101900.195203 (Exim 4.92) (envelope-from ) id 1lPo9w-0003cH-O6; Fri, 26 Mar 2021 15:14:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101900.195203; Fri, 26 Mar 2021 15:14:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPo9w-0003cA-KD; Fri, 26 Mar 2021 15:14:00 +0000 Received: by outflank-mailman (input) for mailman id 101900; Fri, 26 Mar 2021 15:13:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPo9v-0003c5-Jn for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 15:13:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPo9v-00011c-Fv for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 15:13:59 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPo9v-0007l5-Dp for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 15:13:59 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPo9r-000314-Vw; Fri, 26 Mar 2021 15:13:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=mfXmjG6WhD53JA7nEtCeld2rk+rBamrcvPIh3FyzIJA=; b=FtAkZ2RvoOSx7yRhp6njht/3KI u69BPnGelnlQ4hoynznbpgCC3IIX024/GZdbrc/Hq7shzwLClKZ9ZsobCQjtpcvtBhqtPbBVQ4wty wkRSB5L+PZ8LmXx2G9ET9KRqdgudIhCq2a4dRl54tZ69JPjT6Tri+gOmfMQY+SzgQasI=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24669.64051.783683.771246@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 15:13:55 +0000 To: Jan Beulich Cc: Xen-devel , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Boris Ostrovsky , Andrew Cooper Subject: Re: [PATCH for-4.15 v1.1 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" In-Reply-To: References: <20210316161844.1658-1-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH for-4.15 v1.1 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()""): > From: Andrew Cooper > > In hindsight, this was a poor move. Some of these MSRs require probing for, > cause unhelpful spew into xl dmesg, or cause spew from unit tests explicitly > checking behaviour. > > This restores behaviour close to that of Xen 4.14, meaning in particular > that for all of the MSRs getting re-added explicitly a #GP fault will get > raised irrespective of the new "msr_relaxed" setting. > > Signed-off-by: Andrew Cooper > Signed-off-by: Jan Beulich > Reviewed-by: Jan Beulich > Release-Acked-by: Ian Jackson > --- > v1.1: Fold in suggested description adjustments. > --- > For 4.15. Restoring behaviour closer to 4.14, and prereq for a bugfix needing > backporting. Thank you, and thanks for the helpful irc discussion. Acked-by: Ian Jackson I will commit this shortly. For the record, we concluded on irc that we weren't sure that 2/ and 3/ of this series were right, so we are not going to include them in 4.15, pending further consideration/investigation. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 15:20:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 15:20:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101904.195215 (Exim 4.92) (envelope-from ) id 1lPoGS-0004r6-ED; Fri, 26 Mar 2021 15:20:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101904.195215; Fri, 26 Mar 2021 15:20:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPoGS-0004qz-BD; Fri, 26 Mar 2021 15:20:44 +0000 Received: by outflank-mailman (input) for mailman id 101904; Fri, 26 Mar 2021 15:20:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPoGR-0004qu-BD for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 15:20:43 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fe2e66c8-3235-4c5b-b6b7-dd79748c642c; Fri, 26 Mar 2021 15:20:42 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D2305AC6A; Fri, 26 Mar 2021 15:20:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe2e66c8-3235-4c5b-b6b7-dd79748c642c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616772041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NrmGcC2ZP4daaG+xsdVC0fXaJPEx+1DgPs02v8goGVk=; b=oYHzOIoZx/tDcWlR8XF59Mu1DXAWuKbd3PrNwGqf5RsX+jeA76c6bWgafJsnjYDQdY3ufP +iYWV/UJtcW4rQSGsiQr/EBX5jsXb02cEE5BTcMqSqNa3M580tXot57+nxt8dIqaJREsko jynVEWOae0sYyUgkvTmRfnM9H5WXNGk= From: Juergen Gross To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com Subject: [GIT PULL] xen: branch for v5.12-rc5 Date: Fri, 26 Mar 2021 16:20:41 +0100 Message-Id: <20210326152041.25735-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.12b-rc5-tag xen: branch for v5.12-rc5 It contains a small series with a more elegant fix of a problem which was originally fixed in rc2. Thanks. Juergen arch/x86/include/asm/xen/page.h | 12 ------------ arch/x86/xen/p2m.c | 7 ++----- arch/x86/xen/setup.c | 16 ++++++++++++++-- drivers/xen/Kconfig | 4 ++-- 4 files changed, 18 insertions(+), 21 deletions(-) Roger Pau Monne (2): xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on MEMORY_HOTPLUG Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" From xen-devel-bounces@lists.xenproject.org Fri Mar 26 15:22:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 15:22:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101909.195235 (Exim 4.92) (envelope-from ) id 1lPoHz-0004zW-Sn; Fri, 26 Mar 2021 15:22:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101909.195235; Fri, 26 Mar 2021 15:22:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPoHz-0004zP-P3; Fri, 26 Mar 2021 15:22:19 +0000 Received: by outflank-mailman (input) for mailman id 101909; Fri, 26 Mar 2021 15:22:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPoHy-0004z1-EX; Fri, 26 Mar 2021 15:22:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPoHy-0001BK-AD; Fri, 26 Mar 2021 15:22:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPoHx-0006Fr-Vp; Fri, 26 Mar 2021 15:22:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPoHx-00049S-V1; Fri, 26 Mar 2021 15:22:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DN1Wfzl6uzfRw2mRWxrcQAaBCD6Bdi/mayLyH32fA20=; b=ptjoe7tIL8bK10CnLC22+LSH/X rJ7Rv76YBlVN2ajMpiTDvndbm1huREYm7TDEjIioZFz+Ub3nSyUnKl7utxymQrq9c+G7o3bdhWlME PjzAAOYJbStEjkApqPHNF161WAb7UqS+JohYrgXYvzgCNQERaVGSer7TTehOGQzJVFdM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160418: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=9e2e9fe3df9f539f8b6941ceb96d25355fdae47e X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Fri, 26 Mar 2021 15:22:17 +0000 flight 160418 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160418/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 9e2e9fe3df9f539f8b6941ceb96d25355fdae47e baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 218 days Failing since 152659 2020-08-21 14:07:39 Z 217 days 413 attempts Testing same since 160418 2021-03-25 16:59:03 Z 0 days 1 attempts ------------------------------------------------------------ 466 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 138022 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Mar 26 15:28:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 15:28:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101921.195262 (Exim 4.92) (envelope-from ) id 1lPoNV-0005Sv-1W; Fri, 26 Mar 2021 15:28:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101921.195262; Fri, 26 Mar 2021 15:28:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPoNU-0005So-Tr; Fri, 26 Mar 2021 15:28:00 +0000 Received: by outflank-mailman (input) for mailman id 101921; Fri, 26 Mar 2021 15:27:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPoNT-0005Sj-NF for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 15:27:59 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e64e8e1c-eba7-476b-b6fc-5cbe8767deb4; Fri, 26 Mar 2021 15:27:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e64e8e1c-eba7-476b-b6fc-5cbe8767deb4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616772478; h=subject:to:references:from:message-id:date:in-reply-to: content-transfer-encoding:mime-version; bh=ewnmhvDM0TM5SXoUyR7l/ilRiMA62iJdak9FiCVkuQA=; b=Tyfm3G4LajLiLAUIxzXFAVOnCp52HWnCfg9ftNYd95GSKwUPRYaK/wLI 352uvqJhOt9oIeTBF9GT1dmxOnftApw2pJ1iU2CmPXqCucPcxc6a2aUcB TKdhj6g5zyFfKQ1k/bCIgO+uUFyf0Fv6kr/qv/h9UAJb1Svf7eHyhDA7P 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: xovhcyLK/NMoVKvDpZJ1x+1FcSWz38lbZIcRpdl541zPSSc1WON7zjHkylzIZuEKIFzrr909P4 MTGDeveOGimTj02ucwOMs8IygHxm46bIP/IhI6k71dli4otDWEY6KkcBrLTIXZ3Fy+NBompiOo TN7I3EVOFLFlnw10LJAwVIodXmVq96CIbuabFjZQ6nbOIoVxY5uRN3oje4el2Bf61OqyYKgi9C 57WPazUv2jYYqQ4S4amNS76ZyTTb68Ea86n+nHR75YngVSQvajNYa3CnlpEeJdE/b/E3ipW/Nz T+E= X-SBRS: 5.2 X-MesageID: 40211189 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:vcf8taipoXgQpduTnpIj095z5HBQX0tw3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+YsFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmuZ tIW5NVTOf9BV0St6vHySGlDtctx8SG+qi0heHYi0xgVx1udrsI1WZEIyycFVB7QxQDIJI/Go aV6MYvnUvdRV08aMOnCn4ZG9XZr9rQm578JTIADRgr6A6B5AnYlYLSOR6ewxsYTndz0a4vmF K16TDRy4eCl7WAyhHa33LO9Jg+orXc4/ZKGcDksLltFhzCkQCtDb4RPIGqnDdwm+237UZvrd +kmWZaA+1Wy1f8Ol64ugHs3Q6I6kdf11bHxUWDiXXu5ezVLQhKbfZpvo5SfhvH50dIhrgVu8 gqrgHpxaZ/Nh/OkD/w4NLFTXhR5y6JiEEvjPIJiDhnWZYeAYUh3LA3xl9fE5sLAUvBmeIaOd RpZfusgcp+TUmXdDTwsGVp3bWXLwwONybDaE0DtsuJ6iNRjXB0wmAJrfZv4EsoxdYTTYJJ6P /DNbktvLZSTtUOZaY4P+sZR9CrY1a9DC7kASa3GxDKBasHM3XCp9re56g03vijfNgtwIEpkJ rMfVtEvQcJCg7TIPzL+KcO3gHGQW27Uzio4NpZ/YJFtrr1Q6euGTGfSXg1+vHQ4sk3M4n+Yb KeKZhWC/jsIS/FAoBSxTDzXJFUND03TNAVgNAmQFiDy/i7ZLHCh6j+SrL+NbDtGTErVifUGX 0YRgX+I81G8wSFQXn9rB/NW278W0D28J5qeZKqvNQ7+cwoDMlhowIVgVO26oWgMjtZqJE7e0 N4PffGn8qA1CuL1FeNy18sFgtWD05T7rmleWhNvxU2P0T9dqtGn92efGtVzUaWPxMXdbKSLC dv43BMvY6nJZ2Zwi4vT/i9NHiBsncVrHWWC7ARh7OE/sWgXp8jFJ4pVOhQGGzwZlNIsDcvjF 0GRB4PR0fZGD+ro76iloYoCObWcMQ5phyqL85SoXf2rl6duskre3seU1eVII6qqDdrYwARqk x68qcZjrbFsy2oM3EDjOMxN0AJVH6aG4tcDAOOZJxdn5fifA0YdxbPuRWqzzUIPkb6/UQbgW LsaQmZY+vCDFZmtndE6ary619vemKBf0V/V2BiveRGZBf7k0c29dXOSru40mOXZFdH+O0bPT 3fSRY5Iw9lxbmMpVaosQfHMU9j6oQlP+TbArhmTqra3Wm1LpaU0YscGeVPwZpjPNfyk+MCXO 6FYTWJJDfgB+5B4X3Tml8VfA1P7F8qnvPj1Ee7sCyW3HsjDeHTJ1ojbbcBON2Y53XlQfHN8J gRt6NAgcKAdkHKLviBwuXrShQGDDX5i2u/VfspppBZprhajso7I7DrFR/zkEha1xA/JvrunE wQQK5H8KnMU7UfCvA6SmZ8xB4Vj9yBI0sgjxzuDsI/dV8riWXHP9nh2cu+lZMfRmmArhD3I1 +R7ml0+OrERTKK0dcheukNCFUTTEg383J5+uyeM6XWFQWxbulGuH63KGW0frMYaK+LH9wr31 xHyuDNu++cbCzj3g/M+RN9P6JV6m6iBfqIPzjkI58/z/WKfXKWgqWr58avjDD4DRuDAn5o+r FtRAg3dcRMij4rkYst9DO9I5aH5H4Yrw== X-IronPort-AV: E=Sophos;i="5.81,280,1610427600"; d="scan'208";a="40211189" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aNiUm/1oD+n0HdWzEjcJ3KLANbSbVf7d0ql/1eYkHr206Dz1DHRj7oRimItGB2GVO44jgVz8k2RhEAlY2AO2vXSaZQERB1HkaWeZP9wrJ06TTR6TafI8lk3wThL5/aV4xD+gYtrjytJWz7R/G5v0xVY4YTj1lstBU+PkhCg8mKKQnUEetjYQm+XuLJpQkB6+sdlGQbLYfmWl/IwVfD5lRqGdPOv4RMjc2xUv4MfJ1OBBPq+Bl+su4g0HZHNISJkHfCGm0xhPf6PXX6Cfm+UR8QisREBkI7KeqHN/zCd5c/Jtgo3Y0+/dB307Vl0Ls38jK2uiJF9r9qkOKc0WEASHSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Tf1Vq2Gf57OlG0dMq+RGZP6gLPG7kR1gClMVEZ2XDg=; b=gu35CACfvyw2RVYoQUT2KycgNa/0XW/1m5zbWgBArHTrfele23sgwOwZ6EmI5aDFCtfCjEOX4jXnvLOxB0awVg15JAm0tSZMrkMOHr/GaRocm2cG3MG4TkHpL+Hpak+MtyIwfe5rgs6hCLEuN/G7ereZLru0NjaGtnq2irsr9pb58in2ss22Fy/Zp/IFU1ifGiBP0Ytf8G+7rTl1SPCUOo3ZP8RSVw3XNHxteqPSvtnG5ze9HQWXSRFRWD+S0ltTSAN86C5SBZKH80YO3b9YrhSNwQqAl/BYxpgvNGz5+xMUJlUjUfJ7dWWf/6CUdNN8AH8u/EmIVBRJHgyUPxpBtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Tf1Vq2Gf57OlG0dMq+RGZP6gLPG7kR1gClMVEZ2XDg=; b=NQY1hjX9qLCBklzRORcHHMoTyRKhqa6oqUkuSJTMSKuk+Z4GhGCUcWTu2fqMIw/3Y5jQHT7f+VJNRll0izLr0EBHW7XOIFoq9is55aKkWThWOaVtlhBf7RKgxLJmoMuBpt5+/gV7tn7PVVDwRh2PsyDRMkWjJsjed7V1moJbsDg= Subject: Re: [PATCH 1/2] tools: Drop gettext as a build dependency To: References: <20210326134558.7751-1-andrew.cooper3@citrix.com> <20210326134558.7751-2-andrew.cooper3@citrix.com> <24669.60327.951693.886187@mariner.uk.xensource.com> From: Andrew Cooper Message-ID: <7a907fdc-bc8a-7088-8331-e4c1b87c4701@citrix.com> Date: Fri, 26 Mar 2021 15:27:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <24669.60327.951693.886187@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LNXP265CA0054.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::18) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: deb552c3-a12f-4b28-b112-08d8f06bb876 X-MS-TrafficTypeDiagnostic: BN7PR03MB3875: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DgYpqVDjlkhvk3BgMXtjMQt0zpS5X4KEm1nLEx0WCbbH2D/uRSsCk8hHFtHmqDSM+BJadbv4Eg+GYzqFeA96dGnM2Yz/aQVgwoLYWg9ILcK/AGrSOLfYsDvGHBRL8UUeM81Uzlh/yxQ0+wjRwwlVrcWuIgrjtQJcaFWv1UvQDsgCtaWZIQJi0THZtHMMpbK1yOqxQwuETChRYcxBaOYzTplHtU9w05DR9UFoM63Hx9ZoITEsVHKmFQOYQiV5jNRSjsSSTOZMazkOUFMsaaOvP1F0Y+w3uNzIAuNJWRcdlSfSE0c/DGdk6l7CP3Ao4I7opcHd0zOwzK7UmNT6ej8g+tAn+AUtShEF//CbENMhV3jlMUgFxHld33IVZYyqxS7lWBQ1OKN/iBvwlro861ih1RJ99/HHtZKRlLIMF5OQSJZdQwKwguzb4UvJNeU5YIP2T+oSPtcHgH2O5A1td+U22BzLdvNM1Fu9kUh6uekFIe/5BxGNl7Rk2St428HTPr32u0SNWhyB39GOPTF0UW8vAULyyqyonHALgYkZctg0mQS9T8nZrvY+i8WWBlgGQRHlrFn2RxACBOy7kWWAV14sHwwc1S/MZO65iNzIKkB3AxiZw1cpgU+g1kHwt1yqphdE54L5Wm4JhkNvLjFNs1EqLBK3pFi687CBAI/h1SPbYiYY1KdJQIE/XcXdRlyI1YwRrTNRuh4Y6tfrDOOZwctHH57llIYO5j8zgnKAi25mJxY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(396003)(376002)(366004)(136003)(31696002)(6916009)(36756003)(16576012)(38100700001)(478600001)(8676002)(86362001)(316002)(8936002)(53546011)(16526019)(31686004)(66946007)(186003)(6486002)(26005)(2616005)(5660300002)(2906002)(66556008)(956004)(66476007)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UHRKcm5Ub0R6eFoxZWtvREpGUk5makVkUGhjVVBVb1FkZDR0cHBWL2tnMzYv?= =?utf-8?B?aG90RzhUaStZVmpDdU1zZzRETTRCMWpFcldDSXRtaTV6VzNHMitJeS9OaVg2?= =?utf-8?B?c1VBcGh2SDZPbjlwQStERHgwOEM2dlN6L0ZCN0VEYS92YVppVUI4VjI4dTN6?= =?utf-8?B?aS9SUUdmSTdOR29uWWVHclJNS2p2MHdiUWxVRHljb21uZENDNk1XUVMvUTVp?= =?utf-8?B?dXZ0WjZZVDZBZmVsSGhXNUpWVGoyRm1SS1AyTzgyTkxCQnhSVExMcEo1bDJJ?= =?utf-8?B?YXNOaUtWUlBJSEpKWkQ3NFl3dnoyajl5WTdDOTZ0UmV1THA1Mlc4cWNhSXc0?= =?utf-8?B?enB2SjZTMDRPYnEvNi8wd0lsWTg0VEdHNDhodUcvRkFDcTZ6THVzNmZFSUl1?= =?utf-8?B?elR6c1F0WkgrYnEzendjbWJVSHhSL1hnRHJ4OVBmTFVwTEpYVHFSMmtDNEth?= =?utf-8?B?S0d4aHNwUTJJZWtXMHU2bjdzLzVGNkNsU3NHRGNBR3d4bHhlL3IrajVYaUFK?= =?utf-8?B?aEptK1lwTjBRd290bXFzS2o4anJwY05FZENzMktIYm5CbHJLQ0JFSzJIem9m?= =?utf-8?B?em9FWVBsM1hUYmdOakRNZXNaSlBsTWo2eGF5NE1LQ0dCdDZsb0U2Wnh1c3Vq?= =?utf-8?B?dm53d1V4OGorb1pnaW93OWNFYnJHMDExZThhM01zb0tiQUF4WkprS3gxMFlT?= =?utf-8?B?dnFKRmNnL1I2NXBqUjQxVzF6QWRJZFNsMHdtQ1pBdllFMmFxUVZacFBTOWts?= =?utf-8?B?SzhjMEZOWlp4cXU4cmxGS281T1RSd2pIb3JmS2R0MHFCMTBHVHViS2llRzY4?= =?utf-8?B?N0VFRG01TXp5ZE1uMVJWSzFVT2hJTWlEZXI1STFiamRSQVFZS0tlOTBuNU9P?= =?utf-8?B?M3lXZkVIVzBabWQ5dG5ESHVNc3k2V05wUElaQ2R4UVUzakJHTk5SdXA3aUpH?= =?utf-8?B?YUlVcHN2a0lGKzVLY2MxVUpWZFpaOVl1UDI2QnhhUmtObG0rUGU2UnYzaS9k?= =?utf-8?B?dlpMVmhuR21LclgwbmxvWllmdVZGVVJwaGg4N1BETG5taFg1ZThLTVdJcTh4?= =?utf-8?B?bEg2TjNOT0h4c3FTK1FSMWVxc05mMlJ1ZlM0RDlUdm5tVVdpeUNRanprZGhZ?= =?utf-8?B?ZndySjNmNWdLZDZWcElSR2VNaFc2Z1l2UGJna2NDdmxUTHV1S00zR0VmbVB2?= =?utf-8?B?a3FWZnN4QmFCSHREcGtpeTBBL24yMHB6Wit1cThvUmZJaHdvYTFqSmwySjVM?= =?utf-8?B?ZDM0ZlBwUGVqbmIxV0F0SHNiNnFNRzlTdksvWm94TERuU0dIVWpsS1dBMkYz?= =?utf-8?B?MHVZVzFETkYxS2w5SzJxZlpZTWhOZlV6NGRVMGE0SGRhOWFqRzdYa2Izcjd0?= =?utf-8?B?QkdJdmg3UXRnMVB1L3kxNWRKcmwreExqcUxJeWF0dnJNOFZLMCtYNmFQcXBN?= =?utf-8?B?N3JyT3dJK0lYaDI1YkUvc2NXYmhzNnZMNTNDWFBkYW4zdFE5RWEvZ00yWWU4?= =?utf-8?B?MThPbzVwdTA1UGl0VWUvU0J1d3paUE5tTEhiQmY3L2tLS2FBYjNOZThkcjA1?= =?utf-8?B?ek5IWXlQaXY5TEZzclhyVmVJaVR0aVdEOGk2cmlDL2NIV1hteGN1ZFhPVVkr?= =?utf-8?B?VDZZQ09GNE81R2RxVEZVTFo2clkvQlRDbWNRRDZkN0hRdy9JZGZZWmM2YXFR?= =?utf-8?B?ZVZZY0RaV3AxSm5jUkFaTkpNNDlGZlVTNzB1am1Ec0xwTGhFNk1EYWtyYTNj?= =?utf-8?Q?nMIPR562Il+Xz7cTaWg7bCKfhOipd+XcpdjKZxL?= X-MS-Exchange-CrossTenant-Network-Message-Id: deb552c3-a12f-4b28-b112-08d8f06bb876 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2021 15:27:52.1827 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9T3ZGV9eHPmyCRB32swDwpTtRFYGBxR1WBo4DPat/lBtSwwWIglNMKUfq0BlS3c/TvfujyJLIcUeT6Sa9ZYkxM4+UueALad1SSPY/vrqKo0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3875 X-OriginatorOrg: citrix.com On 26/03/2021 14:11, Ian Jackson wrote: > Andrew Cooper writes ("[PATCH 1/2] tools: Drop gettext as a build dependency"): >> It has not been a dependency since at least 4.13. Remove its mandatory check >> from ./configure. >> >> Annotate the dependency in the CI dockerfiles which are used for 4.14 or >> older. Drop the dependency from Alpine and Ubuntu Focal which are new >> containers in 4.15, as well as dropping from CirrusCI and TravisCI. > Thank you but I'm afraid I think that this is not an important bugfix > for 4.15. So I am withholding my release ack for this patch. > > Feel free to explain to me why this is the wrong decision. The bug is configure rejecting a correct build environment. The reason why this is important for 4.15 was discussed.  Shrinking the Alpine and Focal containers (several MB in both cases) makes a material impact on Gitlab CI efficiency, and therefore the turnaround time for answers, but cannot be done if 4.15 gets out of the door with the erroneous check still in place. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 26 15:40:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 15:40:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101928.195286 (Exim 4.92) (envelope-from ) id 1lPoZh-0007c8-9F; Fri, 26 Mar 2021 15:40:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101928.195286; Fri, 26 Mar 2021 15:40:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPoZh-0007c1-6H; Fri, 26 Mar 2021 15:40:37 +0000 Received: by outflank-mailman (input) for mailman id 101928; Fri, 26 Mar 2021 15:40:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPoZf-0007bt-Gg; Fri, 26 Mar 2021 15:40:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPoZf-0001V3-A0; Fri, 26 Mar 2021 15:40:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPoZf-0006vT-3l; Fri, 26 Mar 2021 15:40:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPoZf-0006Dq-3L; Fri, 26 Mar 2021 15:40:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LveA4JdTxgBCM40GocwMUQQCWNQ+yknfhwLOkqI/BKs=; b=Ktwm/vozynVsn3/9NEs2Cb4UYd lj5Kn+/DEIKLO3BwOkRDxkNVqiIq1BjU3VoAHQqnvOqrAlQIMZc38MOhYyJarZoJVOedVxph4Wn6O sznsy3JZR13iyZKtnaISpgmiYpJnr26JWFL0tYJmJNCmDwcJe59it5OJxNaj7VUEq6bI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160445: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=03bee3fd475cb755572dd21214daecf9a77a6bb4 X-Osstest-Versions-That: xen=4ca6217bef99128027a9b64c055e4967a5dabd0c From: osstest service owner Date: Fri, 26 Mar 2021 15:40:35 +0000 flight 160445 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160445/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 03bee3fd475cb755572dd21214daecf9a77a6bb4 baseline version: xen 4ca6217bef99128027a9b64c055e4967a5dabd0c Last test of basis 160419 2021-03-25 17:00:25 Z 0 days Testing same since 160445 2021-03-26 13:01:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4ca6217bef..03bee3fd47 03bee3fd475cb755572dd21214daecf9a77a6bb4 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Mar 26 16:32:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 16:32:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101946.195307 (Exim 4.92) (envelope-from ) id 1lPpNt-0005XM-9n; Fri, 26 Mar 2021 16:32:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101946.195307; Fri, 26 Mar 2021 16:32:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpNt-0005XF-64; Fri, 26 Mar 2021 16:32:29 +0000 Received: by outflank-mailman (input) for mailman id 101946; Fri, 26 Mar 2021 16:32:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpNr-0005XA-3s for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 16:32:27 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1273c169-e0b8-4637-827f-b7da6849c3cb; Fri, 26 Mar 2021 16:32:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1273c169-e0b8-4637-827f-b7da6849c3cb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616776345; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=kqL/TsxVamHcnO3BuDj+gChPGY9LWz88MMzz3zb/CCo=; b=KMEUgi0kyg7G9pQRtNBlyn3BztclOFLj6oanMqlg0cxYjw0a1kR2XPsb zG55Qh702cmeDRVHmxvjPWKwMtZ1Mhtra7BTZP1cgICVEFcNuSzy1tOcS f23MnVF2dAKFv+he8JQ9bZi5xXGNcQ4zC7MvIozhycxPniS8AKsfn53zY 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: wFp4xSbeXsrtIx1WXBtPCmVmXMp1GKhxQXYs7qD90+JutwOi2LBCMNokYxTo4rE/nTmaZSO8qk YQbB1e+6idmw4nCIxu9Ygmrvie7ZUOI3yCF2dFP3uy0BHJVpAEO53H328Wg/wNyXpJ14AA+NfL k4OUOFKGcti7hdrtGn34XeVCnOOFJ7Pt9MNgUDQltiiaiVLzbvrRTbQs+t+mitk+SamqmINQB+ dSeyPeBIHBZTiDafV02BCiAbfhq7EZ+izPfOMI2ivy5aqcN/ElBIS5oIfBgX5bl+4uGH+e8WJd 3Qw= X-SBRS: 5.2 X-MesageID: 40109039 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:HNd9Vq6u5F1gf0XeeQPXwWWEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoexzh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdxHW3tV2kZ 1te60WMrDNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2BXQotLhj0JbzqzOEtwWQVAGN4dHJ 2T+sJIq1ObCAsqR+68AWQIWPWGmsbCk4jobQVDKxks7gSPij3A0s+HLzGz2BACXzRThYoz6G StqX2F2oyPkdGejiXd2Wja8ohMlLLapOdrKcSQhqEuW03RoymyYoAJYczkgBkUp6WV5E8ugJ 3wpX4bTr5OwlfwWk3wnhf3wQnn118Vmgzf4HuVm2Hqr8C8ZB9SMbs5uatjfhHU61UtsbhHuc ohtQLp1OsjMTr6kCvw/NTOXR1x/3DExUYKquIPk2dZFbIXdb45l/1uwGpuDJwCECjmgbpXdt VGMce03oc1TXqndXzD+kFgzNuwN05DZSuucwwpv8yY1CVuh3Zpz0cU79x3pAZwyLsND7ZD/O jKKaJuifVnSdIXd7t0AKM7TdKwEXGle2OCDEuiZXDcUI0XMXPErJD6pJ0z+eGRYZQNiL8/go 7IXl90vXM7EnieR/Gm7dluyFTgUW+9VTPixoV1/J5ioIDxQ7LtLGmqVE0uu9HImYRdPuTrH9 KIfL5GCf7qKmXjXaxT2RflZpVUIX4CFOUIp9cAXU6UqM6jEPyrisXrNNLoYJb9GzctXW3yRl EZWiLoGclG5ke3HlDihhz8XG7sZ1zf8Zp8HLOyxZlX9KE9cql39iQFg1Ww4c+GbRdYtLYtQU d4KLT71oO3zFPGuVrg3iFMAF5wH0xV6LLvXzdhvgkRKX75dr4FppG6cWBW132XGw9nQ6rtYU lijmUy3ZjyA42bxCgkBd7iGHmdlWEvqHWDSIpZvaGf+8H/eNcdAow9UKJ8USXHfiYF2DpCmS NmUkspV0XfHjThheGOl5oPHtzScNF6nUOMOs5bqXXWsG2GvsExTn4nXzqjOPTnwzoGdn5xvB lc4qUfiL2PlXKEMm0kmtk1N1VKdSCqGr5cNR+EY49Vg7jvXwl1QQ6x9HqnoiB2XlCv21QZh2 TnIyHRXf3QGFJStkpV1bvQ/Epuen+QeF9xbX5GoZRwfF62yEpb4KuuXO6ewmGRYlwNzqUmPD bJbSA7Dyluy9q0vSTl0gqqJDED/NEDL+bdBLMsf/XvwXurMpSPjrxDNeRT5oxZONfntfIrXe qTdxSOFi7xD/ok1mWu1y8YERgxjENhveLj2RXj4mT94WU2BuDKJk96A54cONOR4gHfNr+1+a Q8qehwm+S+Mm/8MIHbjY7WaiNOMRPVryqdSfoypZVdoKI1s/9SEvDgIEz1/UAC+C97CsH+0H 46auBcxpvqP4d0Zcwcey5D5DMS5Z+yBXpuljazO/M0eFEmsmTSMNyI6YfZsLZHODz0mCLAfX 2ktxBH9/jLXyG/xacXJqI5L2NRclU94h1ZjZW/XryVLAWhbOdY+lWmdle7bb9GUaCAcI9g4y pS0pWtn+WNcTD/1x2VlTxnIrhW+2LiZc+pGgqDFapp9NO9UG78zpeC0YqWjD3tTyG8ZFldrY pZdVYIZsAGswIctuQMo2CPY52yhFkknVtY6SxmkVCo+rHO2hakIWh2dSvDgptXWjFPNGOvls qty5nB6EjA X-IronPort-AV: E=Sophos;i="5.81,281,1610427600"; d="scan'208";a="40109039" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KZVWHQzPKxTAHqlt8TSzLP0LV90VxK/cs7GLT/ywT0+Yu92HjyNpPD8c73pu+RdPV/SIavC9Ukv6IrRUAMc4N/D7kPXgfOYToWkzZxVys3ttN84SViInaZ+pemRJnH2j8DIs91pzrisNFfQqmyyNz9seX5o4ICfFNHwG84Tjr6dZlvdyRQjzXHm3LXzcjnap0i+ptgaio+SWk6Cg/7icJ/gGvFv4m+nVUQoFXD6lZ+daBiwl9q4XHEgyt//4xaz0c11DH9z1mRE3q0LBKt8ytymeWqEHCl2NCOyxf8mHq2JWq4XhHVH7Ft5WOM7exZ3LAdO3Sm8Iz5wdJrC6xqfR0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oQ5U4tMoaLd8RQTZdpC454/U83DhRqVaTFixRadeaXU=; b=PFbBXNkChywHTCawLSMCunDa5XQJr5N1rdQqgv1UJM9nSZvg+os3A2ArvDlOMEkLCwR8qRgm94oAbN5vKMFCo3WxqphCgCUb5osujaX18Gr942k0YWJhOZZ/EuS4GRUaSfmbYr8JMikwI/RwsB/c6cjq4ldzX+rSNVSgeSOg5cGDRFle9zJrQjaAOHKoQ5KdK8xh8HIyNXOdT6KBSej6MRXsTrzWHvJfYmt0OZmaj3v/Uo1yHqrJVnKbhDEZkQrdsJuRFQTCxFjMb+pOrWyirySdqLTynpLBz6X+5/FrlMhzj/CWaAewH70r+1AYRKFlb+3wMYo2yZM7tlZFAvG3NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oQ5U4tMoaLd8RQTZdpC454/U83DhRqVaTFixRadeaXU=; b=j8EdXOvfZL2dUbAG7ATfOB4+6OuPAJ+df9nx9QApiJYEzeUvZKXQ1wVNZRrfL+acNu7DoT+jlrbQmO3XDXf6dHedF0gDVKlG6xuWJVN78VLwTbTvwjLaoBjEtfzkc1lP9R3b+3D3Nznago86P7NnBDQH8Klpu7cozpWmLh+GBRU= To: Jan Beulich CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , Xen-devel References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> From: Andrew Cooper Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally Message-ID: <19ed3f8f-1dcd-dfde-ffb3-67da569b15c4@citrix.com> Date: Fri, 26 Mar 2021 16:32:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0466.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::21) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f8ac62ad-ae98-4ac6-5db8-08d8f074bade X-MS-TrafficTypeDiagnostic: BN3PR03MB2275: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cJlu8lQ/lMJw3BE5XxiKLvznyxEHKqZTtOHwdaT1eklZkyffpDRO1GeQkYcv0+ib62R7WongFOkRqcNohhI68PrDxXR1WBY/OuTBBQPzkWel0T7BYsuade+QYxwlgRkaId2LPmvNVXFTPJSIAPP/TpYjsAwkB2RsdYS4KFeZAXb/SqGXb4Rdwv2Pf4YbYqqpecamSzsKcbq5sCe3Mk9zux17omzmu6YN26yRxqUi1BhfzFzrQdS4Yx4+1Yg1aSzMBRixHoKOnMiR6CpsW7201RVWFlvWPptOQ6P7XnjxbMN0RXV3pL3iO5i0XPbaWgP22Q7oxUaKMawCrwXo2n1trKDFtfXejcuRneNI4Rwi9yjDsJTjwPbdLUUd5Ie786r5HpYhERNn5ds4uFmcYQxTdZjYk8A5sAEqXqF6EH3GknSBd/t4PxXKYXd1LuRFiV6J1unw8jxqlHul0Rg0Kd9slzwiWt90D2F6qGnqFLNcU4hjR2aVtUdSFV7mCifuJkUo2RiH9YghzjpWwOWGa5BDAeD+ccHTnk31FZP+Jw7bmC2xk/kuhkjonZ6458cBOtarpyT5+dnjZ4V6NqbeSjScctDfJXgj9VqjqbciQpgFFGhqwX8+yUMC1JBZNIksZg+fzuMyTO+p1nmfYmQq8FMU4qoJZ+iCt3k8+J9lJz54Q7DdKxxljrMrIJ8n4gz2fFZaxySYDaSYYvSEpzoT5D0y/1bClyekC6zZj4/IczjOUEA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66556008)(8936002)(83380400001)(66946007)(66476007)(8676002)(6486002)(16576012)(86362001)(54906003)(6666004)(53546011)(4326008)(498600001)(5660300002)(36756003)(2616005)(38100700001)(31696002)(31686004)(6916009)(186003)(956004)(16526019)(2906002)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MlpsZWJ6NHRzV0ovYjlnNk13OGw4UkNFeFhoV3dlcjV1TEZxQzI1SW8vSkhz?= =?utf-8?B?d0pMV0hHMnYvWWc3Y0VQWDFWeXhzWEd1ZVliemRrbnAyT3dMOUVNTTBOeC9H?= =?utf-8?B?MERVQkFITm1DL29hcmtJSHUyVThEVUM3a3VCRFRTcVplT2tybkNxWDJRditQ?= =?utf-8?B?dXArbUVScnlCWXAvN2J3NEQ2ZDdOMUc2SXdWaXRuSVZpeTFPSVpzSVFmc3kv?= =?utf-8?B?NFdmOEJnU2lQOURkRUhScDlubHQyK1FxQjZTanMwT3JxMS8zRVVReU9yNm1B?= =?utf-8?B?cUsydTFTRHB3eUNnQ2psOXBDYlo4NVhFRHlCWG5jNStiYS9DNmZlVFdpb2tE?= =?utf-8?B?WXM5SUhORm10eTNsRmc3Z0RUOU1jejRIOXVQRjRHWi9hNEFkK2M2YzE0OVF2?= =?utf-8?B?Y3dYZUFZeXh3WURlWGNFZzYvQzJUbFcxeFZoN1FKL2h4d2NWd3JWbWtCdzFO?= =?utf-8?B?M29QT0pKaGdlRWwydjBPSTUxdnFSSlBRWmhTUmNuODhjQm5RZzliUHBWWHk5?= =?utf-8?B?VjYwWUpFb0VhdVd2eFdXL0xZMzk0WWJtY2Uwa1RyVWZyemNrejg1TWtmbnc2?= =?utf-8?B?b0pPV1R0K2NRZXZzWXY5WXptTDUzUytNVTUvcXJHS21DUERrMktGVGkxTWsv?= =?utf-8?B?T3ArZDFVeVVtQTVrYnhCcHc0L3g4eXNLVnBuU2NwVi9RTUgyMzdVVFRuckNw?= =?utf-8?B?STVTRnM3cTlFUndpNUV3cGNkWkM0alNBSjhPTWRpb2Y2ekNVL25PNGxVNlJD?= =?utf-8?B?UjI5ZW1ZTDR0ZFBUc0ROY2QreGdSY21UU0pCS0x1VzVPOGN1dDBSVVVXMkRx?= =?utf-8?B?WUNSUS9pMkpLa0hWMzRmRENYb2RpWlpUNktqYmRUOVoyWTRhUlZjSVFZT1hF?= =?utf-8?B?UUJ5QzFhVlJESC9KakU0WjVrQnBSZFhRRWRoUDBOMUlKaW1MTzJSSkZHT0dx?= =?utf-8?B?TjNjcmdiRFNiSEhNVXM1K1pUNThSWVBXbTQrcFFXU3dFS3hYV1dOUjFoMktH?= =?utf-8?B?ZllRRlJrQlBLQmxKSzQvdUk1Szd1Q2F2a3E4Y1dXNW1PMEg3WENDdTdRZElB?= =?utf-8?B?Y0JXZ3I3NjZrNmxmTm1DUUVjcm5FbnJSZEhLU3laM0FLcUgxeU1MMVVmdXNu?= =?utf-8?B?YXpSYUpNbkJkZGkvUE1yM0dmR2ppRHloUjN2cGFFc2kvb1VmWE1KUExzM1VL?= =?utf-8?B?dlg4T2FGdUZTU25lQ0dzWkU1eTdHaHBzVGM0elRCencvcDFJdy9BT2VYaTI4?= =?utf-8?B?b3EyOW0wcUlYYnBUc3FYeG1XMkd3TWkzUklOVnNPOEorWUN0aVNPYmVPcUJm?= =?utf-8?B?TkhFWHFQcjRIL1p3blgyd0JzVWQxSUhuY1oxSUlLUHBmbkUzQjZYQ1hoRllV?= =?utf-8?B?a2gvWldOMlk2L25JdFBhUy9RUmgrNnVVWVRzeDJZek5lR0toR04vK1dkODdT?= =?utf-8?B?SmNhZDlDZ0hkV3JpZmJlTnVLdTl0c1JHTmtaaVA2MERCYVdlYk9ZT1M2Z29D?= =?utf-8?B?ZmFaeVlNNzFxT1Y4TDBHaVhJcXBvWjYrUFJNclBGUnRCdVlNWDB3cFkzcHZa?= =?utf-8?B?TTFndmtHU25URFlDMFBaL2xHWEZlRGpyMVNZTkxRRnZkMkFZS2pGVnRRVThF?= =?utf-8?B?dEdTRUFDc0RST1E4SW14Q2N0VjkxUFluazF1bDhucUNRN0kzVkxFSHV4ZGh1?= =?utf-8?B?dzJLQzBHYnZIMk84Nk9EbjBsc0lhTWVwYkhJanpMM24rQWpCK1JRSlNCWWpP?= =?utf-8?Q?DxPvy6m7SnPCMX7uhJEKX3R7X9uQA8so63crLKA?= X-MS-Exchange-CrossTenant-Network-Message-Id: f8ac62ad-ae98-4ac6-5db8-08d8f074bade X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2021 16:32:21.6931 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AbUFouyy44iwcSALBS0v/STYyWrWip4V1Lz+sEvn6mLsVInUL8nCDGlIiT/cy53FFSnWsAhOisd0Ho3o2WYx0Fo83A3LO/V/hoPaPrl25I8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2275 X-OriginatorOrg: citrix.com On 26/03/2021 09:51, Jan Beulich wrote: > On 25.03.2021 18:21, Andrew Cooper wrote: >> --- a/docs/misc/xen-command-line.pandoc >> +++ b/docs/misc/xen-command-line.pandoc >> @@ -1274,9 +1274,42 @@ supported. See docs/misc/arm/big.LITTLE.txt for m= ore information. >> When the hmp-unsafe option is disabled (default), CPUs that are not >> identical to the boot CPU will be parked and not used by Xen. >> =20 >> +### hpet (x86) >> + =3D List of [ | broadcast=3D | legacy-replacement=3D ] >> + >> + Applicability: x86 > If this is the more modern form to express this information, then the > (x86) I did put on the sub-title line should imo be dropped. Oops yes. > >> +Controls Xen's use of the system's High Precision Event Timer. By defa= ult, >> +Xen will use an HPET when available and not subject to errata. Use of = the >> +HPET can be disabled by specifying `hpet=3D0`. >> + >> + * The `broadcast` boolean is disabled by default, but forces Xen to ke= ep >> + using the broadcast for CPUs in deep C-states even when an RTC inter= rupt is >> + enabled. This then also affects raising of the RTC interrupt. >> + >> + * The `legacy-replacement` boolean allows for control over whether Leg= acy >> + Replacement mode is enabled. >> + >> + Legacy Replacement mode is intended for hardware which does not have= an >> + 8025 PIT, and allows the HPET to be configured into a compatible mod= e. > 8254 ? I did spot and fix that... > >> @@ -1922,14 +1924,38 @@ static void __init check_timer(void) >> vector, apic1, pin1, apic2, pin2); >> =20 >> if (pin1 !=3D -1) { >> + bool hpet_changed =3D false; >> + >> /* >> * Ok, does IRQ0 through the IOAPIC work? >> */ >> unmask_IO_APIC_irq(irq_to_desc(0)); >> + retry_ioapic_pin: >> if (timer_irq_works()) { >> local_irq_restore(flags); >> return; >> } >> + >> + /* >> + * Intel chipsets from Skylake/ApolloLake onwards can staticall= y clock >> + * gate the 8259 PIT. This option is enabled by default in sli= ghtly > 8254? but failed to spot this one.=C2=A0 (It was an error from the original patch).=C2=A0 Fixed. > >> + * later systems, as turning the PIT off is a prerequisite to e= ntering >> + * the C11 power saving state. >> + * >> + * Xen currently depends on the legacy timer interrupt being ac= tive >> + * while IRQ routing is configured. >> + * >> + * If the user hasn't made an explicit option, attempt to recon= figure > s/option/choice/ or s/made/given/? > >> + * the HPET into legacy mode to re-establish the timer interrup= t. >> + */ >> + if ( opt_hpet_legacy_replacement < 0 && >> + !hpet_changed && hpet_enable_legacy_replacement_mode() ) >> + { >> + printk(XENLOG_ERR "..no 8254 timer found - trying HPET Lega= cy Replacement Mode\n"); >> + hpet_changed =3D true; >> + goto retry_ioapic_pin; >> + } >> + >> clear_IO_APIC_pin(apic1, pin1); >> printk(KERN_ERR "..MP-BIOS bug: 8254 timer not connected to " >> "IO-APIC\n"); > As mentioned on irc already, I'm somewhat concerned by doing this change > first (and also not undoing it if it didn't work). An AMD Turion based > laptop I was using many years ago required one of the other fallbacks to > be engaged, and hence I'd expect certain other (old?) systems to be > similarly affected. Sadly (for the purposes here) I don't have this > laptop anymore, so wouldn't be able to verify whether the above actually > breaks there. Turion is K8, so very obsolete these days.=C2=A0 If it doesn't have an IO-APIC, its even less likely to have an HPET. Even if it does have an HPET, there isn't anything to suggest that legacy replacement mode is broken. Would you prefer me to undo the change?=C2=A0 Its not easy - we have the bo= ot time config stashed, but if it was periodic before, the accumulator is broken because we can never read that value back out. > As a minor remark, I find the "goto" based approach not very nice (we've > been generally saying we consider "goto" okay largely for simplification > of error handling, to avoid having many [partly] redundant function exit > paths), but I can see how using for() or while() or do/while() would > make the code larger and require deeper indentation. Actually there is rather less to repeat than I was expecting.=C2=A0 I think it is reasonable to take out the goto. I don't think we want to multiply this with all fallback modes.=C2=A0 The issue we're fixing here (new systems don't have a PIT) is orthogonal to the rest of the fallback chain here which is looking for PIC/APIC problems. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 26 16:43:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 16:43:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101955.195318 (Exim 4.92) (envelope-from ) id 1lPpYe-0006nd-DC; Fri, 26 Mar 2021 16:43:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101955.195318; Fri, 26 Mar 2021 16:43:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpYe-0006nW-AB; Fri, 26 Mar 2021 16:43:36 +0000 Received: by outflank-mailman (input) for mailman id 101955; Fri, 26 Mar 2021 16:43:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpYd-0006nR-A1 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 16:43:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpYd-00033V-55 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 16:43:35 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPpYd-0007Ow-3v for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 16:43:35 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPpYZ-0003Ey-MN; Fri, 26 Mar 2021 16:43:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=y+Unkinlcfob9Uis45yPN2CsWa6fStajlF6LYeaBUfU=; b=ak4NTxpbDWUeMlnkOpTADP5meu Gy518QkbJkwAvxgIcMp/8w4KKnZcyMwoISeKaYpn6g6rqozreQ37PxXYLedEys6TThW5/O/STxBBa zv92eqG528BsPMoQBN3bKtiWfQKFwQ33cwEb2uKxIhFwcQBaPpHgOm7Gsu6l1rHeMJMo=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24670.3891.328817.908772@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 16:43:31 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally In-Reply-To: <8e18a2a5-bc19-615d-0c8c-cea49adcf976@suse.com> References: <8e18a2a5-bc19-615d-0c8c-cea49adcf976@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally"): > Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC > static PIT clock gating") was reported to cause boot failures on certain > AMD Ryzen systems. Until we can figure out what the actual issue there > is, skip this new part of HPET setup by default. Introduce a "hpet" > command line option to allow enabling this on hardware where it's really > needed for Xen to boot successfully (i.e. where the PIT doesn't drive > the timer interrupt). > > Since it makes little sense to introduce just "hpet=legacy-replacement", > also allow for a boolean argument as well as "broadcast" to replace the > separate "hpetbroadcast" option. Reviewed-by: Ian Jackson I have to say that this - if ( hpet_rate ) + if ( hpet_rate || !hpet_address || !opt_hpet ) return hpet_rate; - if ( hpet_address == 0 ) - return 0; - is to my mind quite an obscure coding style. Do we really want to return a nozero hpet_rate even if !opt_hpet ? I would have said + + if ( hpet_address == 0 || !opt_hpet ) + return 0; if ( hpet_rate ) if ( hpet_rate ) return hpet_rate; - if ( hpet_address == 0 ) - return 0; - But Andy's version of expresses it the same way so fine, if that's the way you like to do things, and hpet_opt is new in this patch so I don't consider it a crisis if it doesn't work right. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 16:49:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 16:49:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101959.195331 (Exim 4.92) (envelope-from ) id 1lPpdm-0007HI-2W; Fri, 26 Mar 2021 16:48:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101959.195331; Fri, 26 Mar 2021 16:48:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpdl-0007HB-Uh; Fri, 26 Mar 2021 16:48:53 +0000 Received: by outflank-mailman (input) for mailman id 101959; Fri, 26 Mar 2021 16:48:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpdk-0007H6-6F for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 16:48:52 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 231cfd64-918f-418a-bc98-d899df1f28c6; Fri, 26 Mar 2021 16:48:51 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6814FADE3; Fri, 26 Mar 2021 16:48:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 231cfd64-918f-418a-bc98-d899df1f28c6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616777330; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JmlvPn47hJx4TuJ845ZxapNklJNDAeBnURgObrJQFy8=; b=mn2miW0zn/HalnLNjeF1YZl3hddRtWJpwOL8ksgtCEtAz8v8N6NHegsEgV+NcRSi0LuG0H 4KM3yNMdllBemTllV1B3Bcx1DQJgZ334eVxgRjt43TVb0WRiqrXdr+SyiRZCOYDCSx6H5f X/9tUigjMyg0FyhNz7zUp9EazudesZQ= Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , Xen-devel References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <19ed3f8f-1dcd-dfde-ffb3-67da569b15c4@citrix.com> From: Jan Beulich Message-ID: <36510d2b-a5d0-d5a7-ceb7-c92c7b5e6e2a@suse.com> Date: Fri, 26 Mar 2021 17:48:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <19ed3f8f-1dcd-dfde-ffb3-67da569b15c4@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 26.03.2021 17:32, Andrew Cooper wrote: > On 26/03/2021 09:51, Jan Beulich wrote: >> On 25.03.2021 18:21, Andrew Cooper wrote: >>> @@ -1922,14 +1924,38 @@ static void __init check_timer(void) >>> vector, apic1, pin1, apic2, pin2); >>> >>> if (pin1 != -1) { >>> + bool hpet_changed = false; >>> + >>> /* >>> * Ok, does IRQ0 through the IOAPIC work? >>> */ >>> unmask_IO_APIC_irq(irq_to_desc(0)); >>> + retry_ioapic_pin: >>> if (timer_irq_works()) { >>> local_irq_restore(flags); >>> return; >>> } >>> + >>> + /* >>> + * Intel chipsets from Skylake/ApolloLake onwards can statically clock >>> + * gate the 8259 PIT. This option is enabled by default in slightly >>> + * later systems, as turning the PIT off is a prerequisite to entering >>> + * the C11 power saving state. >>> + * >>> + * Xen currently depends on the legacy timer interrupt being active >>> + * while IRQ routing is configured. >>> + * >>> + * If the user hasn't made an explicit option, attempt to reconfigure >>> + * the HPET into legacy mode to re-establish the timer interrupt. >>> + */ >>> + if ( opt_hpet_legacy_replacement < 0 && >>> + !hpet_changed && hpet_enable_legacy_replacement_mode() ) >>> + { >>> + printk(XENLOG_ERR "..no 8254 timer found - trying HPET Legacy Replacement Mode\n"); >>> + hpet_changed = true; >>> + goto retry_ioapic_pin; >>> + } >>> + >>> clear_IO_APIC_pin(apic1, pin1); >>> printk(KERN_ERR "..MP-BIOS bug: 8254 timer not connected to " >>> "IO-APIC\n"); >> As mentioned on irc already, I'm somewhat concerned by doing this change >> first (and also not undoing it if it didn't work). An AMD Turion based >> laptop I was using many years ago required one of the other fallbacks to >> be engaged, and hence I'd expect certain other (old?) systems to be >> similarly affected. Sadly (for the purposes here) I don't have this >> laptop anymore, so wouldn't be able to verify whether the above actually >> breaks there. > > Turion is K8, so very obsolete these days.  If it doesn't have an > IO-APIC, its even less likely to have an HPET. It did have an IO-APIC, but required one of the virtual-wire modes to be enabled iirc. > Even if it does have an HPET, there isn't anything to suggest that > legacy replacement mode is broken. With one firmware flaw there is about as much chance for another one as there is for HPET to be working, I'd say. Iirc (very vaguely) it did have a HPET, but no ACPI table entry for it, so we wouldn't have used it. > Would you prefer me to undo the change?  Its not easy - we have the boot > time config stashed, but if it was periodic before, the accumulator is > broken because we can never read that value back out. I didn't think the accumulator change would matter. I did think though not having been in legacy replacement mode before might be better to also not be in after, if its enabling didn't help anyway. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 26 16:52:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 16:52:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101962.195343 (Exim 4.92) (envelope-from ) id 1lPpgu-00087P-Jj; Fri, 26 Mar 2021 16:52:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101962.195343; Fri, 26 Mar 2021 16:52:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpgu-00087I-Fq; Fri, 26 Mar 2021 16:52:08 +0000 Received: by outflank-mailman (input) for mailman id 101962; Fri, 26 Mar 2021 16:52:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpgt-00087C-Dz for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 16:52:07 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3479b7de-f86a-4c81-b1fe-f63e9be29b74; Fri, 26 Mar 2021 16:52:06 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D7FBFAD8D; Fri, 26 Mar 2021 16:52:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3479b7de-f86a-4c81-b1fe-f63e9be29b74 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616777526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y3NjgERvAkuP3YIKE/7W6VirGEjHonaYPLVNK4bQq9E=; b=QlAh2ZER4uw1oAOA0FkYqKRIxXgN1muMkMc48eaxj7Hb0hHfXLHS4yap3ePW5WxYaz9iGw wGCy6X3u7WbW36V9CdoYNW+WjurzWhI817T9qS7lUmK1/czAXDOeH/e5SfPDiVNd9FBsq4 KtrDmb3lPjB6yV0wT4ta94jTSlupWj0= Subject: Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally To: Ian Jackson Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <8e18a2a5-bc19-615d-0c8c-cea49adcf976@suse.com> <24670.3891.328817.908772@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <10de7758-fadd-3a04-d0d9-8ec3074ea149@suse.com> Date: Fri, 26 Mar 2021 17:52:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <24670.3891.328817.908772@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 26.03.2021 17:43, Ian Jackson wrote: > Jan Beulich writes ("[PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally"): >> Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC >> static PIT clock gating") was reported to cause boot failures on certain >> AMD Ryzen systems. Until we can figure out what the actual issue there >> is, skip this new part of HPET setup by default. Introduce a "hpet" >> command line option to allow enabling this on hardware where it's really >> needed for Xen to boot successfully (i.e. where the PIT doesn't drive >> the timer interrupt). >> >> Since it makes little sense to introduce just "hpet=legacy-replacement", >> also allow for a boolean argument as well as "broadcast" to replace the >> separate "hpetbroadcast" option. > > Reviewed-by: Ian Jackson Thanks, but with Andrew's pending objection I don't feel like committing it. > I have to say that this > > - if ( hpet_rate ) > + if ( hpet_rate || !hpet_address || !opt_hpet ) > return hpet_rate; > > - if ( hpet_address == 0 ) > - return 0; > - > > is to my mind quite an obscure coding style. > > Do we really want to return a nozero hpet_rate even if !opt_hpet ? We won't: hpet_rate will be set to non-zero only further down in the function. Jan From xen-devel-bounces@lists.xenproject.org Fri Mar 26 16:54:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 16:54:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101965.195355 (Exim 4.92) (envelope-from ) id 1lPpj1-0008Ei-1N; Fri, 26 Mar 2021 16:54:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101965.195355; Fri, 26 Mar 2021 16:54:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpj0-0008Eb-UI; Fri, 26 Mar 2021 16:54:18 +0000 Received: by outflank-mailman (input) for mailman id 101965; Fri, 26 Mar 2021 16:54:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpj0-0008EW-9e for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 16:54:18 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5a82b306-f257-4039-baa2-4c13fa723aee; Fri, 26 Mar 2021 16:54:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a82b306-f257-4039-baa2-4c13fa723aee DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616777656; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=8V1frlHzzkycMXgCP01vXInUX3cSxkbUvRQFSIuKzAk=; b=JVC9i1V3kPPwYcREQPMrRwPFk8bW4UtrdEmfEjIpM0fs6T7FZGnbZkL6 AJz7okWHHx0wIcun2pmA2j+NEdjAS9r10Zr+tzDKtR3ss6x1G2vzlNXLN PFZaMS8uFNVJtbNTOBLA42DQfsk4didzhrDsqN8NYet9xAxcgxWsztKTd k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: L43dheEaLnqrwktK5rHaqU+iD1O1IgU8K1hCI7eTH6614rs6A4qVgrWeFN3bt9Oy/IbHYPFyYP ZuvvtmipQZNGFeliha49kws3NHrDFFsONEKAEW7WsOyNgMpkASoD2j4hasp08iNN3QH9Cuby5g 39xWAHsOPXEU5b/JcpxQC1sJDUwpFm6taT0sikJWeeR3I7j7Ndx6oZLzIA/8kwTbRqES1EoYxT va9nzLkKTa2XJsZ91B5VTYRMT+dwi494cav0ldtcL+6ev2geNB73oax0lidnLv7a6Lzat60XWb acw= X-SBRS: 5.2 X-MesageID: 40239500 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:8BWd7amh/IABgyHUzGMsZywHrN3pDfODj2dD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLN+AZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 hdWoBEIpnLAVB+5PyX3CCRD8sgzN6b8KqhmOfZyDNXQRt3brx7hj0YNi+wOCRNNW57LLA+E4 eR4dcCgjKmd2geYMjTPAh6Y8HoodrXmJX6JSMcDxk85wWUyR+u4rj2Ex+Xty1uLA9n67Ek7G TDjkjF9ryu2svLtiP0+k3yy9BtmNXnwsZeH8DksKkoAxjllwrAXvUbZ5SspzYwydvfkWoCsN 6JmBs4OtQ21nW5RBDJnTLI+y3NlAkj8GXjz1jwuwqQneXcSCghA8RMwaJ1GyGpk3YIh9133K JV02/xjfM+Znms7UeNham9azhQmkW5unYkm+II5kYvN7c2U7NNsZcZuHpcDZZoJlOI1KkcDO JsAMvAjcwmFG+yUnaxhBgK/PWRRHgpWj+JTk8e0/blqQR+rTRSyksVw9EnhXEQ9J4xYIks3Z W1Do1Y0J5JVcMYdqR7GaMoRta2EHXERVb2PHuVOkmPLtBIB1v977rMpJkl7uCjf5IFiLM0hZ T6SVtd8Uo/YVjnB8Gi1IBCmyq9AVmVbHDI8IVz9pJ5srrzSP7AKiuYUm0jlMOmvrE2HtDbc+ zbAuMVP9bTaU/VXapZ1Qz3XJdfbVMEVtcOh9o9U1WS5urWN4zRsPDBevq7HsuvLR8UHkfERl cTVjn6I8tNqmqxXGXjvRTXU3TxPmPl+5ZdF7Xb4vgzxIABOpYkiHlQtX2JouWwbRFSuK0/e0 VzZJn9lLmgmGWw9WHUq0VlUyAtSXp90fHFaTdntAUKO0T7ffIooNOEY11f23OBO1taR8PSGw hPmkRv9cuMXtqt7BFnL+jiHnORjnMVqn7PZYwbgLe/6cDsfY59KZo6RqprF0HuGwZukQhn7E dPATV0BnP3J3fLs+GInZYUDObQe51XmwGwO/NZrnrZqAG7vsEgRnwSWha0Ss6JiQMSRz5Z72 cBtpM3sf6lo3KCOGE/iOM3PBlnc2KMGo9LCwyDecFpgLzxQRpxSm2LnDSerBk2dgPRhhwvr1 2kCRfRVeDAA1JbtHwd9qrx6lt7el+QeF9KZmlgvZdwEnnHvXhPwfaGD5DDple5Wx8n+KUwIT vFaTwdLkdVy9e72AW8tRyCGX8lr69ec9D1PfAGSfX+y3mtIIqHmeU6BPdS5o9iL82rmPQMS/ ijdwicKy7YB+sl1xeOnGssPDB5pRAf4KvV8SygyFL98G80APLULlgjeqoSJMuE6XP4A9mPy5 d0gLsOzKONG1S0TuTD767ZbzROcEyO5UG3SvwlspBSs+YZsqBpE5zSTDvP0zVm0XwFXbHJvX JbZJ4+xrbLfrJLVYg1XQly+1IyjtSBLEcxqGXNc6UDVGBoq0WeBs+D5rrDlKEmDUKArjbhIF X3yVwrw971Gw+4kYMAA60+IW5qeFExxXRr8uSFbZDRAmyRBqh+1Wv/Fn+2a7lGTqeZXZ0Wsx Zh+tmN9tXnOxbQ6UT1vTFhJLhJ/HviacSuABiUEeoN19ChI1yDju+L58G05Q2HBgeTWgA9hY dfc1YXYdkGoj4+jJcv2iz3c5fJmCse4hBjyAAisEXs1Iig6HraGk8DETSxuOQmYRBjdl6Sjc rE9uCE0m/a+zYt4+iZKHtt X-IronPort-AV: E=Sophos;i="5.81,281,1610427600"; d="scan'208";a="40239500" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BZak5iYt2rOgO9wWAYtxzGyDkIfDNZ3bjHUR/mk82WDostawMnTcPii4zZIJHAgG97MmMMNI4salqVWwZX1HWI80UpqhajIBPBMYDJdjmRzQMES+zxPGJ6v1SNIcTp0ncKSUsySv2nEm513qoIA2Qjf9jszUCZkwRyizVNwCF5Xwl6X6JERegOnsAMp7kbS+osHrJRGHCfFqC29R3DgFOE22uFDUpKbaeorW6GnqZvGy4rTurrhwT9wG3R0g99pW3BaMN2b5nQwokIcWI+fTOtQBvsSCAQ65QTQF4YUlLDHjF77Vvu+B2Drj8wJf0XD8UMY1aySGm9+q10D6j77HfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VHIoGsfWwIgGaEP5O372bN7pg6+tTs0nJuFQXbDMSu8=; b=lH8gJCA8avoxxpB33uELaAD+vfyvCIZIs6KfCbHR+fg3HdMV3KYUQd7va82Qsc64ySCPbAThLccatRxidYKV/edYI5XZTCdY6KgyNfd0/tX3jRkkFpIcxirvTnEVpLnEU+qtXJTJEDgrdGITDG8Mgwr4mA6BjT/8XbR1t92I6UU91jRO1/ucycYuCtd8IGbWZuLoFBwaMvlrMlsSg2iS6pp1oiyIEVLkJhCKMdp8h/Q3iOJ7vuBkvSOrfjTMgJYaHG1NH86psCX39vmq9stbxtFbKK/UOtV1+EbtaSxEqh1Qo8ixwYZe0aeYaLSh9uGoUpL96b4DpgI133o7mit5oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VHIoGsfWwIgGaEP5O372bN7pg6+tTs0nJuFQXbDMSu8=; b=OevcdBXYGEmRA1ZoSyb84x55HM2u6yl1NsIzQzmvOALCuARBRpDxK312jB7kIWhpiU3QA6becUaa/tZfbhsrFOvByxjLD3kWz/ta5xOn7+7sr6nojD5hMOzuPVl1GDsdtmV9NOCvZSI20jZc3FOOf3YupUnaVrQQEHuNtMWGz50= Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally To: Jan Beulich CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , Xen-devel References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <19ed3f8f-1dcd-dfde-ffb3-67da569b15c4@citrix.com> <36510d2b-a5d0-d5a7-ceb7-c92c7b5e6e2a@suse.com> From: Andrew Cooper Message-ID: <8d7b290f-ede6-3180-7bae-5451a5f8800e@citrix.com> Date: Fri, 26 Mar 2021 16:53:27 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <36510d2b-a5d0-d5a7-ceb7-c92c7b5e6e2a@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0348.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::11) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9513053a-7f51-4807-e6a3-08d8f077b0ec X-MS-TrafficTypeDiagnostic: BN6PR03MB2515: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LCu+sYl25eG1/kaKVWnCyuXUt4XoUTZGyDVIvHn3msFyqBVVbPDGyZg9i5KJIrRinBTUD/HbJTqyOGElj4hLwM8eJx/DZRgEdgRHWgfB6ehMiOeFhq1glvzR5yDJw6uJtVCEtaNB+sv37Oj6Dogr4jtR33qDPVr8Yw3Sh7ZgPj36Ayb1l9ztDNSC2X9QKIEnbrrrJVbMyiwzs3IUSK6IgGmRINe0LA+3H7mQ2taHtP4CWGoY9FKD4q83bSiO7FtIINCVrQL/roLlv2uOgIwZfB3cf3kMWCwyx8eoVEnqvHkbklS3M6rIcHbeQyhIaL94nPFlFxfR+zXxWDuM1NxtDh30P6X/RcxZxSWSQHD3yRsrPBwDGWiRZDp+km6emUjA+Yo+GN3xxyBmfw34FEEhPuhixxpIzB8I5TTfTPH69DGYMS9P4Uqa/VNhf8qcITfE7sWKn3lPCvinBypa74GBW6viad/F98cQeTPxiQ+Kow19uaNCecsQjfgQOhiChWaPwIub9BpwAIoWLo18hJMKQUxIH8kClDzHw4VVh+WB2T3rKQm709f8ZMvAOnxiMep6RUTLUq6M+sLkg89+krNe/Je6saS1dEMxpbpcbVbD02JoJZLgqMpbPLnzh+6E9eE1P93ofZhQBCZJwpxENn3Q+Z0GG1+46bm1SXFk3T9iYRcGDw8sJRTgoXLbEnFbgCa18Ss/hR+SMuUjbWNLTg9Ew5ad5W1zrqZDv6FuYLckZHU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(136003)(39840400004)(376002)(396003)(478600001)(31686004)(16576012)(26005)(316002)(186003)(54906003)(6486002)(6666004)(53546011)(6916009)(4326008)(2906002)(16526019)(38100700001)(66946007)(2616005)(86362001)(66476007)(66556008)(5660300002)(31696002)(956004)(83380400001)(8676002)(36756003)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bGpCS2Y0dndBN3QwNDZYczFUWWdDZUZqVXNPbEtZVnA3MCszRzBNYkxYRDZa?= =?utf-8?B?cVowMDlNM0UyRURHUEx6aElpeUdQcGxNMUpNb09sZGttdVRDK3lLNkpHMVli?= =?utf-8?B?emdHT3F1MCtxd1J4MWxaalczaDVWWlNpQkNYaDYzSUo2Z0F4d1V0T2pVZHNS?= =?utf-8?B?bmJmbUtXNU1xQmk2cGFIZGFLZVRFcy9BV2hyYlUycmtES0xIYm4yRStlTGRT?= =?utf-8?B?ajVoRHNjeGpHT2U0NC9OV2taWDhTMnNwTWdzSUd3cjI3TWVpUUNOTlZHcHpU?= =?utf-8?B?UndOeFZTMVFkQjNHa0RQTUNTWlZCcEluYWRBWnQyemQzQ2toZlZYWE5QUVhK?= =?utf-8?B?WHNBVU1hZFA2aElUbjdpdFF4QXJvTkh3YXdSRlFEMGo5QkozamRiU3djc3dC?= =?utf-8?B?L3UyM3VBUFlWR2VyRFR0NUo2a3ZkY2VEUXRsNDZMUU5JMXU3Q05WRlp6TEtm?= =?utf-8?B?ZFY3VlppTzlTM3RMVzRSYXlYYkNhZXlkSVV3YVVKWnhYNnA1aEFraW1XODdl?= =?utf-8?B?bUJrbVE3a2VRczNYNHdIVGhIRittbWNIUFNNT1R0WFE5M2c3MXhDVVFBaFVC?= =?utf-8?B?WkpGVnhuRENLcWx5ZUhIL0FPZHhTL2dXLzd5cnJMMFdiN05YKzBvYmkyT2lP?= =?utf-8?B?TmVrSVZGMDRQNXphTDlrZUltSm1JWkNzOGF6ZklpS2dkMTF3bnJpbTJpd2Zn?= =?utf-8?B?b0FjVGhxYkduUEFQSXFqQVkwN3NNeUVBbWNvRm9YeTNGN2gvYlRsQ2dxamlL?= =?utf-8?B?ZjE2Y3UrOVVhaEZpOHZzRGxZemphbTBEL21zZGxwL0s3S0t2MXRDbW9NODVR?= =?utf-8?B?NFM2R1hIWExIeHlvOVRxcGRCRnhpMnlYV0ZLSFUvck5hbDlaTWJRa20yemJ3?= =?utf-8?B?SzJWdzlxSS9jd20wTVhJUnNFS3ZWNld5ZDRaaG4wejRybVhrSmhrZ2pXNnlm?= =?utf-8?B?S2VKODRQaFp6K3Y4dzBPaGV0ald1T3pQOHBZU1RycWRUNitmRWIrSTBaMzRw?= =?utf-8?B?VEY3UjV0Sm5BMm54ay9jR3JDeTJLNWZwbE1uM2JsWmJzRCt0c0ZzNDc5MUg2?= =?utf-8?B?dGFtbFpGcGpRMlZ3SW1TOVlnSGlXMnV5UUR1aHFIMXp5MkgxbkYzcmpqQmVI?= =?utf-8?B?eFRJcW5DRmlVOHVpNnRqcXdMMktYeDNibEV4cGhRdzhabE1OeldEV1N3UGJU?= =?utf-8?B?d2Z2dU1vdlIvdmUxbm9EY3k0VVYwNjgxT3RWWUZrcXoxMkp3ZnlaRFFMK2lk?= =?utf-8?B?U1VyVis5Szdkd1RHYUxpeENPemZlNmxNcFo1cVgyRmZ1dHVLRU9JckJtelpn?= =?utf-8?B?cmdVTTZ6RlZOM2QrczZ6YVFSYzBkNVJnM2tsdjRtRHA4VUJxT3BBeWNDQ3NL?= =?utf-8?B?dGFaeXhkOE43Tml6czRUSzRwYkRPMC9nS0dERVRrKzk5V3AvSndydlcvS2xi?= =?utf-8?B?a3ZpR1hSUHViYlpUelZDbXpOV2ZBT0lEUk40RTN6T29HbG05RlZSQmxGaUtY?= =?utf-8?B?L3dmcXJuelo1UWM2ZHplcWd3RWwrSkw3cTBrQmpVR2hVWWNVQ3BOUVlwanU5?= =?utf-8?B?NHhhY29wRUliL0tERkpmbW9qdG5hQkJnM2ZwU0hqNzhEZW53QnA5YmtUaEFV?= =?utf-8?B?a0RqNlJub1dxcEdwbmhLMjNMbGJJd0NRRkp2cUVuWU1nbGNzTG90S3MrVkU1?= =?utf-8?B?dG1SWWNoWWFia09YREg0ZTFLZml6ZUliVDFvN2tteTJ5TG9ISDlSUVFwb1JJ?= =?utf-8?Q?tmZP8g+UQ1xMj7GyZBxdmqBWK8TWn+ZMZfqwdM8?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9513053a-7f51-4807-e6a3-08d8f077b0ec X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2021 16:53:33.4914 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k6jW0t7YS2NrIAjAHHvtvDV34Y0AbvYKQfHzfkZCeF0JQFAp5JbXsWk7W7T5XW/cExZpL1W6GcLHeFAUjzNKqzwp7lBzGG7pPlrM0TnMrTQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2515 X-OriginatorOrg: citrix.com On 26/03/2021 16:48, Jan Beulich wrote: > On 26.03.2021 17:32, Andrew Cooper wrote: >> On 26/03/2021 09:51, Jan Beulich wrote: >>> On 25.03.2021 18:21, Andrew Cooper wrote: >>>> @@ -1922,14 +1924,38 @@ static void __init check_timer(void) >>>> vector, apic1, pin1, apic2, pin2); >>>> >>>> if (pin1 != -1) { >>>> + bool hpet_changed = false; >>>> + >>>> /* >>>> * Ok, does IRQ0 through the IOAPIC work? >>>> */ >>>> unmask_IO_APIC_irq(irq_to_desc(0)); >>>> + retry_ioapic_pin: >>>> if (timer_irq_works()) { >>>> local_irq_restore(flags); >>>> return; >>>> } >>>> + >>>> + /* >>>> + * Intel chipsets from Skylake/ApolloLake onwards can statically clock >>>> + * gate the 8259 PIT. This option is enabled by default in slightly >>>> + * later systems, as turning the PIT off is a prerequisite to entering >>>> + * the C11 power saving state. >>>> + * >>>> + * Xen currently depends on the legacy timer interrupt being active >>>> + * while IRQ routing is configured. >>>> + * >>>> + * If the user hasn't made an explicit option, attempt to reconfigure >>>> + * the HPET into legacy mode to re-establish the timer interrupt. >>>> + */ >>>> + if ( opt_hpet_legacy_replacement < 0 && >>>> + !hpet_changed && hpet_enable_legacy_replacement_mode() ) >>>> + { >>>> + printk(XENLOG_ERR "..no 8254 timer found - trying HPET Legacy Replacement Mode\n"); >>>> + hpet_changed = true; >>>> + goto retry_ioapic_pin; >>>> + } >>>> + >>>> clear_IO_APIC_pin(apic1, pin1); >>>> printk(KERN_ERR "..MP-BIOS bug: 8254 timer not connected to " >>>> "IO-APIC\n"); >>> As mentioned on irc already, I'm somewhat concerned by doing this change >>> first (and also not undoing it if it didn't work). An AMD Turion based >>> laptop I was using many years ago required one of the other fallbacks to >>> be engaged, and hence I'd expect certain other (old?) systems to be >>> similarly affected. Sadly (for the purposes here) I don't have this >>> laptop anymore, so wouldn't be able to verify whether the above actually >>> breaks there. >> Turion is K8, so very obsolete these days.  If it doesn't have an >> IO-APIC, its even less likely to have an HPET. > It did have an IO-APIC, but required one of the virtual-wire modes to > be enabled iirc. > >> Even if it does have an HPET, there isn't anything to suggest that >> legacy replacement mode is broken. > With one firmware flaw there is about as much chance for another one > as there is for HPET to be working, I'd say. Iirc (very vaguely) it > did have a HPET, but no ACPI table entry for it, so we wouldn't have > used it. > >> Would you prefer me to undo the change?  Its not easy - we have the boot >> time config stashed, but if it was periodic before, the accumulator is >> broken because we can never read that value back out. > I didn't think the accumulator change would matter. I did think though > not having been in legacy replacement mode before might be better to > also not be in after, if its enabling didn't help anyway. The accumulator matters if chan0 was configured as periodic previously. Then again, this is broken anyway generally (e.g. the S3 path), so I suppose we're not making it any worse here. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Mar 26 16:54:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 16:54:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101968.195367 (Exim 4.92) (envelope-from ) id 1lPpjW-0008Lm-Ae; Fri, 26 Mar 2021 16:54:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101968.195367; Fri, 26 Mar 2021 16:54:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpjW-0008Lf-7T; Fri, 26 Mar 2021 16:54:50 +0000 Received: by outflank-mailman (input) for mailman id 101968; Fri, 26 Mar 2021 16:54:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpjV-0008LZ-EY for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 16:54:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpjV-0003FC-Ax for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 16:54:49 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPpjV-0002yu-A6 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 16:54:49 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPpjR-0003J2-RT; Fri, 26 Mar 2021 16:54:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=pbqEGjcPljbsFIpuqq2xM2/elg1pjolDjB1DZ+EWjEI=; b=G8Qa+Uz1uFjVmmCMo2mLpZw79i 5rvYhdyn6nTVw2qJSONK1p9Qr/MLWjUpgVXkOuXgNSN7qxKnyY83Swwzh/bimPcIl8/S4fSvUM+u7 ABiOLvjuzruAFURI2nCMxsuSRz2CAZwEcZXUEByYwL3tW4Bu/9sPMDbCQOC/FCUCZRSM=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24670.4565.669973.152753@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 16:54:45 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally In-Reply-To: <10de7758-fadd-3a04-d0d9-8ec3074ea149@suse.com> References: <8e18a2a5-bc19-615d-0c8c-cea49adcf976@suse.com> <24670.3891.328817.908772@mariner.uk.xensource.com> <10de7758-fadd-3a04-d0d9-8ec3074ea149@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally"): > Thanks, but with Andrew's pending objection I don't feel like > committing it. I understand. > > I have to say that this > > > > - if ( hpet_rate ) > > + if ( hpet_rate || !hpet_address || !opt_hpet ) > > return hpet_rate; > > > > - if ( hpet_address == 0 ) > > - return 0; > > - > > > > is to my mind quite an obscure coding style. > > > > Do we really want to return a nozero hpet_rate even if !opt_hpet ? > > We won't: hpet_rate will be set to non-zero only further down in > the function. Oh, I see. Right. Thanks for the quick reply. Ian. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 17:00:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 17:00:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101975.195379 (Exim 4.92) (envelope-from ) id 1lPpop-0001Ab-5F; Fri, 26 Mar 2021 17:00:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101975.195379; Fri, 26 Mar 2021 17:00:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpop-0001AU-25; Fri, 26 Mar 2021 17:00:19 +0000 Received: by outflank-mailman (input) for mailman id 101975; Fri, 26 Mar 2021 17:00:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPpon-0001AP-Ih for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 17:00:17 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dd69a0ff-dd08-4df5-a31b-df06eca2871d; Fri, 26 Mar 2021 17:00:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd69a0ff-dd08-4df5-a31b-df06eca2871d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616778016; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=MWcAlWdFFN8K8jMCJnyDLu5RATWGrnt/HvG6DsLgAm8=; b=NWeqzGK6rjHAaT2drp03q1ZEq1sLypQeQCvct688G3L4FHUJ+zPZr4uS i628EV1Vw14N97JnPyzoW6reLTe9SXgEXDA7muGVg38ht/agp0R5Gm/TB KzQ+S9tnGMWSNdaIkqwgF46onKfeS9L/R0LOsKLHmUYkvxvA3r9zxadWL o=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 4LRYDLqQ//qE0GI79ZuUGU18YRmV70hadh+FsIzQsGZPSLMENlDm/4yVnLc73ZXwazY3JUUMog zScwnEnrVSH8Y9N9jYhsZ0dm1MiykwkIqStQbKZL9bYJTOcm1g/pwwsi8O9SLrnF0SKS/eCZOZ We11Bu/WYQpYmQYSQKTvYanUdxUAkYs4yuoOxZ33uWc5eh2t8G4O3hX9TRPPe9GspY1fiCNdZW irzkHJp95/PF22rAbbQaWGx92gi8/XYzzjC0sVSj8BCDQKa4NrXiqmTJTq8XlKgG4por1f6box cEw= X-SBRS: 5.2 X-MesageID: 40596237 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:W2y4bawSNgayzs/uyfDJKrPx3+skLtp033Aq2lEZdDV8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPsfVr3//dOgbU5F7GkQQXgpS+UPJhvhLGSpQHINg/f0qpm1a lme7VjE9GYNzJHpOvz/QXQKbkd6fad9qTAv4nj5ldrCTpncqRxqzp+YzzrcHFeYCljKd4HGI GH5sxBzgDQHkg/SsigHHEKU6ziirTw5fHbSCULDRIm9wWC5AnAgNLHOiOV0RsEXzREza1Kyx mhryXD6ri+qPb+8xfA1gbohKh+osfryddIGaW3+6woAwjr4zzIWK1RH4eskRpwi+Gp5VYsnr D30mgdFvU20Vz9VCWYpRPs3iPpzToh7WTzoGXo/0fLkIjCax8RT+ZHmIJFYjvVgnBQze1U4e Zw8E+y87pREB/akyz267HzJmFXv3vxm1UOu6o3rRVkIPIjQY4Ul6Mz1gdpNa1FOyTA5IUuAI BVfbzhzccTS3y2RTTkpGV1qebcJkgbL1O9bWUpnNea6DRSlGAR9Tpl+OUv2k0N858wUPB/lp /5G5UtkLlPS/kfZr5mCNEARtOqCnfMTQikChPpHWja X-IronPort-AV: E=Sophos;i="5.81,281,1610427600"; d="scan'208";a="40596237" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jK+OE2+H/0PP1nRE1lAjp4H2OXkYZLjLdXXpDQlGiKpl0QTKjGiSR9+OpILvU4yFP0Xopilrmx7Il0TGUiWFDm1MhaT80m2NJBechwl9R8byoNfmKvwsuX3F0dwIm+tE40gDlOQpiZxANyprBIRPkfSYpS/Px8BmOizc57e7TctxWwbuSPEEN3/8fKRpF120quFXV/tooDcI4K9PGm7PXw04CDBvMHYQnlYG2O+wKtU1UG5IOp7t+IOraJYT/eOfF/bqb4npkhYQxONtjadGp2+zm8j9iufBgjovbzu/W6iD/upiisYqOkIKCLIcciLg0azZ0PtbfvbkUNbkgOst1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VRmK3fvpBpmXjBaVeNBv5m1IhjGrK7YKyDWY5lkGwbk=; b=jbS02a/R/RtBRI9bEVvL8pFzKjen/gxJKnZfsXqXUt7m+ex1wi7tgr0RoybJ3p6zvJ3utQVa4i4Z2jrCrTlfKuyvDd3rNrCTyhljH7HuWdnNyrvbWXk4DV/sp0K1IGWdyxU/Qtp/iJgQdPrKw2BhTHx0+qtBJw5yymc5bP6LIJJlU5pAhNJvHaOFwvArophwUGPoXxvxtzwh22uQdwEcjyZhunEJbNKEzSErFmtcTK3+479yXELNpUqr2AoSKtLEsz3xbC0oOFZzhJ0gD/219ZLb+fNnaBj1kd+cBbuF5x9k6d6oVap/zMusVraB/d7LKBjR3DHnc/+gK9aB6XMqiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VRmK3fvpBpmXjBaVeNBv5m1IhjGrK7YKyDWY5lkGwbk=; b=I2K3aGymw+3l6R1sPS/qU5EEU3155FPlKay1UYHcYIduwNn3FPuZ/qlGBuq7LTPZEmhxRRIaz6uGGr1401IEvvNuyOTBeHziWftrcHv63qYv9lBwdp3Is4w4Q4Kk1FudkC3ECGMTLEbem6yndnpPfklz4nYR0ohPT7aeUeoP9bE= Date: Fri, 26 Mar 2021 18:00:05 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson Subject: Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally Message-ID: References: <8e18a2a5-bc19-615d-0c8c-cea49adcf976@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8e18a2a5-bc19-615d-0c8c-cea49adcf976@suse.com> X-ClientProxiedBy: MR2P264CA0179.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b1eaec0-9c22-4c32-85d6-08d8f0789dd0 X-MS-TrafficTypeDiagnostic: DM6PR03MB5356: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lKVDudruG8hdNYtdkmuktzLlWkidY4Kx/hhzYVXFAl+16hBiGWRJXgmwgy1Y9BgdHIbkr+RP0CtCe/5wY4UjGySv3Yt0tQeSgvNzs9VbqK/mbzuVBPlp9cT9JMRw5XCpZaYDH5yPq9ec62Vdn8uWanacRcYwoN97wlqmx3QkxXTUm5vbqU/wp7Q9D+mHtUplIfMcvg1kKfbbMplDC6RUPBKhzi69dpxTeCu/UCMkIjrVIie+mZA3Qkhy+20JE5rkIN9Ny8r7hIN9D+pryF+xWj4ciqYcL/JjhtofEDTVlYTyGs+ETl/LTIeSRzahVpeSrQcXd5DP22RbyjZjvV+znF/vugY/1GDlFcdBTnbvM7EvVlN2pOk14aqFk1XsunjBPuRx1W+RUUqzcblO9b5EpA4ZGiUesxvfvbfdRDHucV5W+JYv5EfKp6DTOOemBVFZL771Sc6EfHQJ6SsE+BKcbkvI+q9HmJ6chnYWp23VNlBkXR/th7/Velyo4OK1vXXxmxaKfKfeERmuc6p2OSawKuLGjmU1G9vLl1xJeRgpQRqJoWbUKgNE2AJpkSvTugbRB6PZZaE5HKB7MDq5EOasgL1R9LmDHV/7GD1n8txt2jbRWPfBf6q9RicCB5yizgh+tOdvoeR6tb8Rekj+Cm3X8A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(136003)(396003)(366004)(346002)(39860400002)(376002)(6486002)(956004)(66946007)(33716001)(66556008)(66476007)(86362001)(6496006)(16526019)(83380400001)(186003)(4326008)(6666004)(85182001)(26005)(54906003)(9686003)(38100700001)(5660300002)(2906002)(316002)(478600001)(8936002)(8676002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MzYyelVDZk1seUFsVDB2UEZYM1N3RStQRkdJdy9za3ZmWGUzMUtkTjZ6dnRO?= =?utf-8?B?bExSaFJ1WkhLNlBVMnU3K1d0Q21xaWpXbWdQa2ovNEJpVHFqRW83N2NxaWU2?= =?utf-8?B?a0RmSDJjd0dJdU14WVZESThHdzdrMy9LTGc1RDJIODA5VUozNlFMb1RTV2d1?= =?utf-8?B?VzRMeVNMSlluNlUwZEc0dFdsZFE2Z0k1SjNRVHpCVDlQMDY0RTgxbVJQaGxk?= =?utf-8?B?LzhlWVNSUVhZcWd3VkpHZWRvdE05Qk5BRjdGbGFna1grMUQzYnkxMnd6dk9z?= =?utf-8?B?Nm9lK1E1am5qTXhseDBvSWN2R0Z0UDZVeU5FaU5WMEtMQ1lxUjRrSHhzbUoy?= =?utf-8?B?d2x5NkhEc3BzVnpQZVVaSzZjd3E1L0c2STI4bng1ZVBSRzdrOFRoU1BOd1Nr?= =?utf-8?B?YzAxTHNoM0xoWHFLSDFmaW9UdEg0TGU0YitDcFMvN0gwSGoxbjV4SFBtNC95?= =?utf-8?B?MDhyUTlMSmV3MXlscGZob0h3Nm5JdCs1MUVLalV1ZTFJZDcwbE9pVWhad2dR?= =?utf-8?B?am5kaytGV1N3d25xNWxoSi9BMFV5VlJrUnRMcnFHQlJHTlRla2VsYUV2V2dm?= =?utf-8?B?ejFQS2ZNMzBqSnBqdlZGZExIMElhelZvRG9JdmVNcWZxUjlIR24xbjNmZkJN?= =?utf-8?B?T1lNQWFQYlprODBza3hFQkthdGRycDdwdXQwSWRlamxDV25mWVNIbGU1QmpS?= =?utf-8?B?S3JSTTJobS82V3ppY3dNUXpZM3BqcFAxVitJUzFEb2ZUdFV4YkhmMjJQcHll?= =?utf-8?B?QVlNeW1hRTNpOUFQM2tJSkg5bHRxcDZJR1pNRHREUFhxZXZDYUpwSHNHT050?= =?utf-8?B?UlBDYzBrWnZhNVdWam1xQi9hdUZMVGJGNjhtVVBuWFFrTUpkZWtVZHFLdWNV?= =?utf-8?B?OXQ1STcvMzBSdDRJS2JRRmJiUlgxc1ByV0xOYVkzWmpDcUR0aEVHTExaSHlX?= =?utf-8?B?V1ZnWWI1cWhCQ1BLRGRBczFZUUYwV2V3bkxCRGpESUZPM2tqUWVDMURXZkhl?= =?utf-8?B?NEhyQ0d1ZXAxRHo5WHdqdlRmS0tWbGsxQWpIbGl0MDVKbis4RlAvcDlDUW1C?= =?utf-8?B?OWIvbk1QbWZyK3lMWVp5TmJMZEdWeHM2dHZWa0R5ZVpIVnZVTGdkSGJZMDhv?= =?utf-8?B?T0JwSS9MTjN4cFltREFWb09jRDI4cjlVMGpUMjl2bURVcGNZOFdiSncxVEhr?= =?utf-8?B?d2FFaGxxQmVhWThQVzl2NytzRFlSWHZQaFJRUUZ4SnM3dytPdHlFNVcydTgz?= =?utf-8?B?V28wbEQwUWQ4MG4zanJNR1NQSXJRd0V2eWRhRGV1L1ZTSlVCRVJ1OElKRUFH?= =?utf-8?B?eWtBRWJZcU5PQy9HTk43MGovR0loVVIrTWM3V2J6d0ZldDJza0d6Rkc0QzdW?= =?utf-8?B?bm5KLzNQclhWbEZmT2VSUm1PTWt0MU9RQWVjRzVqNGsxNk1vQlB4T0puL1Zs?= =?utf-8?B?YkxqMHYwNjVwTVNUdERGZFhCS282Sk1kdmlFMU5JdjJGQTkwb3BDR3p4dUVl?= =?utf-8?B?QkJ5OFd4TDk0eE1OVjNwRHVERGlnU2ZyVFNPdmJZN25QWVJUckZTQW9MOFY2?= =?utf-8?B?UTVZNXF1Wk9oVXE2VTYxdHIxeXpEbkVjc2FwRy8yaGROLzFvTkdHZjRJTnY3?= =?utf-8?B?RFBqalErSXJWY1dUYkxvUnZ5Ky9CYWN5MEtkbS9HRnNLVVZUOHlaVzZLdXRO?= =?utf-8?B?L0FXM2liRmkzWHF4b2NxNzlZaUF4aWhMdGxSSUY5RS82QnZCQ2ExbGVPSW82?= =?utf-8?Q?iVDYcPCqC68jbOWWnwewBogBSGSgVsav7suQGx/?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2b1eaec0-9c22-4c32-85d6-08d8f0789dd0 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2021 17:00:10.9954 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nwDJpm8GuCeuNozkjjQUjZs2BojDnh2gCTY8DSbp1Wq7u3if2oMbvrcQcdg0AQyzLYNY2hZjcqsK+USlusrBrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5356 X-OriginatorOrg: citrix.com On Wed, Mar 24, 2021 at 11:34:32AM +0100, Jan Beulich wrote: > Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC > static PIT clock gating") was reported to cause boot failures on certain > AMD Ryzen systems. Until we can figure out what the actual issue there > is, skip this new part of HPET setup by default. Introduce a "hpet" > command line option to allow enabling this on hardware where it's really > needed for Xen to boot successfully (i.e. where the PIT doesn't drive > the timer interrupt). > > Since it makes little sense to introduce just "hpet=legacy-replacement", > also allow for a boolean argument as well as "broadcast" to replace the > separate "hpetbroadcast" option. > > Signed-off-by: Jan Beulich I think the commit does what it saying on the commit message, hence: Reviewed-by: Roger Pau Monné I would like to avoid such RB being seen as me deciding on which option is best release wise. Haven't followed the other discussion closely as I'm on PTO today, but maybe it's an issue worth thinking over during the weekend? > > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -1274,9 +1274,26 @@ supported. See docs/misc/arm/big.LITTLE. > When the hmp-unsafe option is disabled (default), CPUs that are not > identical to the boot CPU will be parked and not used by Xen. > > +### hpet (x86) > +> `= List of [ | broadcast | legacy-replacement ]` > + > +> Default : `true`, `no-broadcast`, 'no-legacy-replacement` > + > +Controls Xen's use of the system's High Precision Event Timer. The boolean > +allows to turn off use altogether. > + > +`broadcast` forces Xen to keep using the broadcast for CPUs in deep C-states > +even when an RTC interrupt got enabled. > + > +`legacy-replacement` is intended to be used on platforms where the timer > +interrupt doesn't get raised by the legacy PIT. This then also affects > +raising of the RTC interrupt. I think Andrew rework of the change moved the x86 tag to a field on the description instead of being in the title of the option and arranged the options to be in list format, we might want to use that instead, but can be adjusted later I guess since that would be a documentation change. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 17:14:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 17:14:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101980.195394 (Exim 4.92) (envelope-from ) id 1lPq2D-0002S3-Dn; Fri, 26 Mar 2021 17:14:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101980.195394; Fri, 26 Mar 2021 17:14:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPq2D-0002Rw-Ab; Fri, 26 Mar 2021 17:14:09 +0000 Received: by outflank-mailman (input) for mailman id 101980; Fri, 26 Mar 2021 17:14:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPq2B-0002Rr-Kw for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 17:14:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPq2B-0003b3-K9 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 17:14:07 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lPq2B-0005Z8-J9 for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 17:14:07 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lPq24-0003Lw-PL; Fri, 26 Mar 2021 17:14:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID: Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=FQ3n/idf9678ZfMo7cb8o1lIQwR61G2ESmgMNQoGgE0=; b=U/46LEto1QaLeC6IutKJS5pTl3 9dKB6FrUH4gfpyEn2oJuNC9zmjBPzHqRtnkwkitND8nVoqTdXUm1GDveYaUq7ueaQ8tCbwPwCZ/nW 6r3gOwmqI2UllyGY2LWUAg/xrWXKi9gOJBUDDYzYKaNXZM+TovallZaqO3uTGkLUY2b4=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24670.5720.581893.435175@mariner.uk.xensource.com> Date: Fri, 26 Mar 2021 17:14:00 +0000 To: committers@xenproject.org, community.manager@xenproject.org CC: Andrew Cooper , Xen-devel , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , =?iso-8859-1?Q?Fr=E9d=E9ric?= Pierret Subject: x86/hpet: Don't enable legacy replacement mode unconditionally X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Ian Jackson writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally"): > Andrew Cooper writes ("[PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally"): > > In addition, introduce a "hpet" command line option so this heuristic > > can be overridden. Since it makes little sense to introduce just > > "hpet=legacy-replacement", also allow for a boolean argument as well as > > "broadcast" to replace the separate "hpetbroadcast" option. > > I'm sorry, but I think it is too late for 4.15 to do this. I prefer > Jan's patch which I have alread release-acked. I think I have been perhaps insufficient clear. Following discussions earlier in the week, I made that fairly definitive statement this morning. There has been various discussion but I restated my postion at 14:07 UTC today: | I think the appropriate course, therefore, is the conditional (based | on commaned line) revert proposed by Jan. So to be 100% clear, this currently-still-being developed series is Release-Nacked-by: Ian Jackson I have reviewed the more minimal patch provided by Jan. I am satisfied that it is correct. I have reviewed the checkin policy in MAINTAINERS. Jan is a maintainer of this code, but a second approval is also required. Roger has provided a review and in any case I think my approval may also be sufficient (either due R-B implying a REST A-B, or due to it being a R-B by "anyone of suitable stature in the community"). The policy says that: Sufficient time must have been given for anyone to respond There must be no "open" objections. I think under the circumstances that these have been met. At 12:59 UTC today I wrote: | Andrew, I don't think you have, so far, Nak'd Jan's patch. If you | feel it warrants your Nak please provide it ASAP. Andrew has not, in response to that specific invitation, nacked Jan's patch. Roger wrote: > I would like to avoid such RB being seen as me deciding on which > option is best release wise. Indeed. Thank you for being clear, Roger. I think that this decision falls to me as Release Manaager. I have considered the question, taken input, and decided to take the more minimal change. Therefore I have just now pushed the more minimal command-line based conditional disablement (to both staging and staging-4.15). I would like to see the more comprehensive and better fixes in xen-next, but ideally to be committed there only after 4.15 is released, in case we need to rework this area again as part of the release. This is not necessarily the end of the conversation. If the Committers feel that my decision as Release Manager is wrong, I think it is open to the Committers to overrule me, via a vote. Ian. current Xen Project Release Manager From xen-devel-bounces@lists.xenproject.org Fri Mar 26 18:04:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 18:04:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.101994.195422 (Exim 4.92) (envelope-from ) id 1lPqoE-0008OI-EE; Fri, 26 Mar 2021 18:03:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 101994.195422; Fri, 26 Mar 2021 18:03:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPqoE-0008OB-8f; Fri, 26 Mar 2021 18:03:46 +0000 Received: by outflank-mailman (input) for mailman id 101994; Fri, 26 Mar 2021 18:03:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPqoD-0008O6-FI for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 18:03:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPqoC-0004TC-6Y; Fri, 26 Mar 2021 18:03:44 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lPqoB-0000qd-UM; Fri, 26 Mar 2021 18:03:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Vn5K8+827u0j2tL/5w3PXoqi0Zay3eOA6Y3FQXE9aRY=; b=bQygGXYFmHzTRVI0A2j+rP4ojN qNnrMGbeJwpX6/K7saK47RDejSof4oLZdW1X03/AN2mzSnEA+K1aASs3rsFLkELvfJhAHy0L1iptl wecc66xtoAM14jCX4KKt3H1mwkxHPms5ao8FZ/NyyrrbBtb8EEzZhYjI+IsKwTXK4hU4=; Subject: Re: [PATCH-for-4.15 v3] tools/libs/store: tidy up libxenstore interface To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu References: <20210324123948.7207-1-jgross@suse.com> From: Julien Grall Message-ID: Date: Fri, 26 Mar 2021 18:03:42 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210324123948.7207-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Juergen, On 24/03/2021 12:39, Juergen Gross wrote: > xenstore_lib.h is in need to be tidied up a little bit: > > - the definition of struct xs_tdb_record_hdr shouldn't be here > - some symbols are not namespaced correctly > - the layout of a structure with an enum inside it depends on the > implementation of the compiler TBH, they seem that each of them should be in their own patch. I am fine with one patch but I think you should at least outline the solution in the commit message. This will be easier to relate with the rest of the code (you are solving 3 issues at once). > > Signed-off-by: Juergen Gross > Sorry I didn't realize, you already sent a v3. So I will repeat my comment here. I think you want to summarize the discussion [1] in the commit message so it is clear that 1) You are breaking the ABI (although it is technically broken as we use enum) 2) Why this is fine to do it. Cheers, [1] https://lists.xen.org/archives/html/xen-devel/2021-03/msg01267.html -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Mar 26 18:48:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 18:48:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102050.195475 (Exim 4.92) (envelope-from ) id 1lPrVV-0005UY-He; Fri, 26 Mar 2021 18:48:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102050.195475; Fri, 26 Mar 2021 18:48:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPrVV-0005UR-E2; Fri, 26 Mar 2021 18:48:29 +0000 Received: by outflank-mailman (input) for mailman id 102050; Fri, 26 Mar 2021 18:48:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPrVU-0005UH-Ka for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 18:48:28 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4eb19bad-2cfc-464d-81e9-48dab581ed33; Fri, 26 Mar 2021 18:48:28 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPS id 32EC961A32; Fri, 26 Mar 2021 18:48:27 +0000 (UTC) Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id 1900160952; Fri, 26 Mar 2021 18:48:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4eb19bad-2cfc-464d-81e9-48dab581ed33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616784507; bh=o3vDg6yqgyA1Twdd5bXDGYIg+8P1k+tonUCRFj0cgFs=; h=Subject:From:In-Reply-To:References:Date:To:Cc:From; b=ldSeRY2niZjtW89vymy5Rpzk4LwHllb9JP4S2W9PL/2/DjEykeE0wCQywnnMBlL5v l6zr5zLFrI7b8RqhijSPVJEcJYihTkX6q+rJzRhCnvJiEcs0v6iYd0MAPf+2PlIPQg U8niqtpxT4AmLFOnlrpKeM7g/Q1cpsqEj0u3swNgYKSGF0/qIe3OhVvTXEAsk22pYg 4GK3Qb9Qbz3OEf+n+yEyj4aG7jnFqilGLLTLvCcuKfOVBhrr1KMA5IL0fndvv+k4fr IONsi/rVn+1LPEV5t3Pux3QLGpGQwbo9xTJZ+xkUQdiqMFCnIhAbOoBWqB2jh+TjU2 W0QJoozBIkYJQ== Subject: Re: [GIT PULL] xen: branch for v5.12-rc5 From: pr-tracker-bot@kernel.org In-Reply-To: <20210326152041.25735-1-jgross@suse.com> References: <20210326152041.25735-1-jgross@suse.com> X-PR-Tracked-List-Id: Xen developer discussion X-PR-Tracked-Message-Id: <20210326152041.25735-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.12b-rc5-tag X-PR-Tracked-Commit-Id: af44a387e743ab7aa39d3fb5e29c0a973cf91bdc X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: 6c20f6df61ee7b8b562143504cf3e89ae802de87 Message-Id: <161678450709.8437.15896961548334222943.pr-tracker-bot@kernel.org> Date: Fri, 26 Mar 2021 18:48:27 +0000 To: Juergen Gross Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com The pull request you sent on Fri, 26 Mar 2021 16:20:41 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.12b-rc5-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6c20f6df61ee7b8b562143504cf3e89ae802de87 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Fri Mar 26 19:00:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 19:00:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102054.195486 (Exim 4.92) (envelope-from ) id 1lPrgn-0007U8-Kh; Fri, 26 Mar 2021 19:00:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102054.195486; Fri, 26 Mar 2021 19:00:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPrgn-0007U1-HJ; Fri, 26 Mar 2021 19:00:09 +0000 Received: by outflank-mailman (input) for mailman id 102054; Fri, 26 Mar 2021 19:00:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPrgm-0007Tw-FV for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 19:00:08 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e4c953b9-4c86-4244-bba2-ab26e70c6e1c; Fri, 26 Mar 2021 19:00:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4c953b9-4c86-4244-bba2-ab26e70c6e1c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616785207; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=RuAY2Vs5ZjEISl1t3cvbNmdLRZYlT8iClHaM05R9taE=; b=Mr+99u1sMBreGD3NPS2qLDjBzCJ5vXyhBm9irxiqUff7rhBaeM1gajb0 lknKTC1m6iaHJnbnTjC/10zhVhtLwqdapp8gGx7rJBs0Ms1NnehaZBNpy LgP+CrAfYFkQm9otC1pl+evUUfY7au0SEsGhsR/G5wvCJUeWdzIGOd076 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 4Y5bV4P3cKKYYi2cldRTTypvf/9TQlJoXbD/ZMzQ0jJ7vtYEJTe6G4MqtCwhRazNZN99SuQKOp 3wLWSdVJtXmRC6aM0nll4qdkisY/0hRtvuStWtGQFn1gw1e8h9EiLtsJhyDlcPtEkWfD5nnW/n 8IFalb/5APvKag+8zyJhjayIcDnaVgu+iypbuzyaT6EvQlyuX2BQTn6Hj8O9wT9543ItutPuYO EzFU/Z2CeMCOTYWwZPkKJ6JTtwwY/ixRv7LnqTUXMx4K3aFbv+uAuOOwovGIH+7g8yC15j6W87 ldw= X-SBRS: 4.0 X-MesageID: 40395915 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Nqfjkq0EGOkwNQYY4u/6iwqjBUFyeYIsi2QD101hICF9WtCEls yogfQQ3QL1jjFUY307hdWcIsC7LE/035Qd2+ksFJ2lWxTrv3btEZF64eLZslvdMgDd1soY76 dvdKBiFMb9ZGIRse/W6BS1euxO/PCp66at7N2x815MSkVQZ7hk/0NFDG+gYy9LbS1nIbZ8K5 aG/MpAoFObCBMqR+C2HGMMUeSGh/CjruOEXTc8CxQq6BaDgFqTgdaXLzGi0hgTSD9Jy7s5mF K19jDR3am/r+q9jibVym671f9rseH8wdhODtHksLlwFhzQjG+TBbhJavm5kx0e5Mqu71srl9 ekmWZeA+1Dr0n/U0vwjR/k2wzL2Csj5Xn42Taj8AXeiP28fh0WIY5sgp9Ybwv45iMbzaBB+Z MO5U21nd52Cg7Nhyv07dSgbWAbqmOE5UAMvMRWql43a/pmVJZh6bYx0WkQLbI7WAX904wjGP kGNrCg2N9mNWm0QlqcgnNi27WXLwwONybDeGcukOqP3QNbmXhopnFouPA3rzM7+JUxR4Is3Z W+Do1Y0LVHTsohZalgHus2QcyuFmzXQR7XWVjiW2jaKA== X-IronPort-AV: E=Sophos;i="5.81,281,1610427600"; d="scan'208";a="40395915" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Ian Jackson , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Pierret?= Subject: [PATCH for-4.15 v2 0/3] x86/hpet: Try to unbreak Ryzen 1800X systems Date: Fri, 26 Mar 2021 18:59:44 +0000 Message-ID: <20210326185947.23243-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This is a refinement of Jan's "[PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally" to try and make Xen do the helpful thing on boot, rather than requiring a non-default command line option to boot in the first place. Andrew Cooper (2): x86/hpet: Factor hpet_enable_legacy_replacement_mode() out of hpet_setup() x86/hpet: Restore old configuration if Legacy Replacement mode doesn't help Jan Beulich (1): x86/hpet: Don't enable legacy replacement mode unconditionally docs/misc/xen-command-line.pandoc | 33 +++++++ xen/arch/x86/hpet.c | 187 ++++++++++++++++++++++++-------------- xen/arch/x86/io_apic.c | 31 +++++++ xen/include/asm-x86/hpet.h | 13 +++ 4 files changed, 194 insertions(+), 70 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Mar 26 19:00:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 19:00:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102055.195499 (Exim 4.92) (envelope-from ) id 1lPrgp-0007VO-Sp; Fri, 26 Mar 2021 19:00:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102055.195499; Fri, 26 Mar 2021 19:00:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPrgp-0007VF-Pk; Fri, 26 Mar 2021 19:00:11 +0000 Received: by outflank-mailman (input) for mailman id 102055; Fri, 26 Mar 2021 19:00:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPrgo-0007Ut-NB for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 19:00:10 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 36518861-707e-490e-81d4-4a6817d0faed; Fri, 26 Mar 2021 19:00:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36518861-707e-490e-81d4-4a6817d0faed DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616785208; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=hoKdN8csoqaelamoWrWzTqNBSKLs0axyRHUC7J8rEEM=; b=gx1r9eI73xNbKuUiua2I/lygw/wRiyTVDbC+8peT8iR7g3rzW4LAQYMm CUBVwtkvakv0/XhDtupEEExCVj+6UpV1s6+0jAeQ6eobtALPIYtPfmkLD D2xuxWWNllX6/vgbVasPvR6VQvf/ZOxGc6NpvQrErMZw9RLMQVJY5L0EH c=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: zsK55gemVstwCTyRH4LtBkpgWq9VD3bgys0Wg2m345eRf9KH+ZOWQsUCzxvlpCQPx6z3eNtMRS u7T24eJQzpBkY42Covx4PExdpw+9NwYbNoO3rWzSrUz2fLYS34+n3g+RP1buqJZ2qv6JwcZFV+ OGmCxPiGC2QaT/ExROJqUGkf/3X2ot9zS1Tmx16i7HVpZnoZ6Jk/s+QcsQuUbrINkchvV0OiF9 2Y4CC/qWPy8FFXWPLGlPUDj0y2NavoMscCXumMKBsxmFQ+BMSmGmjfTyZZvyHXxa9XsbhybYdw nhA= X-SBRS: 4.0 X-MesageID: 40605106 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:m83dP606WrBnf0xHY/R78gqjBal2eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/FIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFmtJ1/Z xLN5JzANiYNzVHpO7x6gWgDpIEyN6I7KiniY7lvg1QZCthApsQtTtRIACdD0FwWU1iDZ02CJ KT6qN81kedUF4Qadm2AWRAYvjbq7Tw5d7bSDMlJzpi0gmBiju09KX3eiL34j4yWy5CqI1Sl1 TtvBf+4syYwpKG4z/ak1Te9pFH3Obmo+Ezf/CkrugwBnHShh2zZIJnMofy8wwdhO208l4lnJ 3tjn4bTr1OwkjcdG20vhfhsjOIuF1Fih/f4GSVjnf5rcvySChSMbs4uatibhDb50A81esMtZ 5j4mODu5JbSTPGkSjtjuK4MC1Cq0uurXIu1dMUlnxUOLFuDIN5kIp3xjI2LL4wWAbBrKw3Gu hnC8/RoNxMd0mBUnzftm5zhPSxQ3UaBH69Mwk/k/3Q9wITsGFyzkMeysBatGwH7ogBR55N4P mBGrh0lYtJUtQdYctGdac8aPryLlaIbQPHMWqUL1iiProAIWjxp5n+56hww+22ZpoSzt8XlI 7aWF1V8U4+EnieSvGm7dluyFTgUW+9VTPixoV1/J5ioIDxQ7LtLGmNU1Yrn8y8o+gOA8HSVv qpUagmRsPLHC/LI8Jkzgf+U55dJT01S8sOoOs2XFqIv4bKJ+TRx6jmWceWAICoPScvW2v5DH dGdiP0Pt984keiXWK9hBDQXnjqa1Hu5J4YKtmcw8EjjKw2cqFcuAkcjlq0ouuRLydZj6AwdE xiZLX9kq26omGy9X3S73pgPwdcCko92sSjb1p64Ssxd2/ke7cKvNuSPUpI2mGcGxN5R8TKVB JEq09v4qKxJZyIzSUkA9aqW1jqyUc7lTavddMxi6eD7cDqdtcEFZ4gQrV2DhiOPQdygxxWpG BKbxIkSkfTGij1s7isiIUZCYjkBoBBqTbuBfQRiHrE8W2AuMkkRxIgLkKTeP/SpTxreh15qR la9bQFjL+JhDC1QFFP/9gQARlrc2SYALVPEQKfQp5b84qbNj1YfCO0vBjfpzYYPlHH2WU3qg XaXHGpUMCOPWN4/l5i9JrStHNYH1/tIn5YWzREiKk4NEL9hx9IoLS2T5v27FK0Lns5hsAsGw rkTFIpU1xT7uHy6yew3BK5OzEH6/wVT7TgJbw+brDe3W6sIoWUlacAW+RZ5ophKcqGiJ50bc uFfROJIC7/YtlZrzC9tzIrPjJ5p2Ijlu6t0Br57HKg1Hp6GvbKJk96LotraO20/izhR/yS1o 9+gs9wteysMn/pYtru89CfUxdTbhfSq3WxVecmtNRdur8zrqJ6G93eXSHT3H9KmBU4I8Gcrj JXfI1rpLTAMJRoZcocZmZQ+Ucojs2GKA8zqRPta9VOCG0FnjveJZeE8rDIob0gDgmIoxbxI0 CW92lY8+3eVyWO2LYGA8sLUC5rQVl57G4n8PKJdoXWBgnvbe1F8VagOnK2cbNWSsG+aMMthw c/58vNk/6cdiL+1gyVoCByJbhW9X27Bcy1GwCBFIdzgpGHEEXJhrHv5sG9jD36E2TmL0sZgJ BIbkwWYIBIjCI4gIg+zyi1Tej2ryse4ihjyCAikkSo3I6spHrfFwVBNwbSh51NRzldMnSSl6 3+gJ+l/WW45CIAwIXJEUdbY8pHFNcRRJXmNisGE7lhgJe4u640xjlZaBggD2QgmCnw0uNv07 C+wujTUYTZeAXVEENE/yVECI5yljEqrm8Fc9HW1+PNXjkq X-IronPort-AV: E=Sophos;i="5.81,281,1610427600"; d="scan'208";a="40605106" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Ian Jackson , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Pierret?= Subject: [PATCH v2 3/3] x86/hpet: Restore old configuration if Legacy Replacement mode doesn't help Date: Fri, 26 Mar 2021 18:59:47 +0000 Message-ID: <20210326185947.23243-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210326185947.23243-1-andrew.cooper3@citrix.com> References: <20210326185947.23243-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit If Legacy Replacement mode doesn't help in check_timer(), restore the old configuration before falling back to other workarounds. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Ian Jackson CC: Marek Marczykowski-Górecki CC: Frédéric Pierret v2: * New. For 4.15: Attempt to unbreak AMD Ryzen 1800X systems. I'm tempted to fold this into the previous patch, but its presented here in isolation for ease of review. Tested by repositioning the timer_irq_works() calls on a system with a working PIT. (XEN) ENABLING IO-APIC IRQs (XEN) -> Using old ACK method (XEN) ..TIMER: vector=0xF0 apic1=0 pin1=2 apic2=0 pin2=0 (XEN) ..no 8254 timer found - trying HPET Legacy Replacement Mode (XEN) ..no HPET timer found - reverting Legacy Replacement Mode (XEN) TSC deadline timer enabled --- xen/arch/x86/hpet.c | 27 ++++++++++++++++++++++++++- xen/arch/x86/io_apic.c | 4 ++++ xen/include/asm-x86/hpet.h | 6 ++++++ 3 files changed, 36 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c index bfa75f135a..afe104dc93 100644 --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -783,6 +783,9 @@ int hpet_legacy_irq_tick(void) static u32 *hpet_boot_cfg; static uint64_t __initdata hpet_rate; +static __initdata struct { + uint32_t cmp, cfg; +} pre_legacy_c0; bool __init hpet_enable_legacy_replacement_mode(void) { @@ -796,8 +799,11 @@ bool __init hpet_enable_legacy_replacement_mode(void) /* Stop the main counter. */ hpet_write32(cfg & ~HPET_CFG_ENABLE, HPET_CFG); + /* Stash channel 0's old CFG/CMP incase we need to undo. */ + pre_legacy_c0.cfg = c0_cfg = hpet_read32(HPET_Tn_CFG(0)); + pre_legacy_c0.cmp = hpet_read32(HPET_Tn_CMP(0)); + /* Reconfigure channel 0 to be 32bit periodic. */ - c0_cfg = hpet_read32(HPET_Tn_CFG(0)); c0_cfg |= (HPET_TN_ENABLE | HPET_TN_PERIODIC | HPET_TN_SETVAL | HPET_TN_32BIT); hpet_write32(c0_cfg, HPET_Tn_CFG(0)); @@ -843,6 +849,25 @@ bool __init hpet_enable_legacy_replacement_mode(void) return true; } +void __init hpet_disable_legacy_replacement_mode(void) +{ + unsigned int cfg = hpet_read32(HPET_CFG); + + ASSERT(hpet_rate); + + cfg &= ~(HPET_CFG_LEGACY | HPET_CFG_ENABLE); + + /* Stop the main counter and disable legacy mode. */ + hpet_write32(cfg, HPET_CFG); + + /* Restore pre-Legacy Replacement Mode settings. */ + hpet_write32(pre_legacy_c0.cfg, HPET_Tn_CFG(0)); + hpet_write32(pre_legacy_c0.cmp, HPET_Tn_CMP(0)); + + /* Restart the main counter. */ + hpet_write32(cfg | HPET_CFG_ENABLE, HPET_CFG); +} + u64 __init hpet_setup(void) { unsigned int hpet_id, hpet_period; diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index 3f131a81fb..58b26d962c 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -1955,6 +1955,10 @@ static void __init check_timer(void) local_irq_restore(flags); return; } + + /* Legacy Replacement mode hasn't helped. Undo it. */ + printk(XENLOG_ERR "..no HPET timer found - reverting Legacy Replacement Mode\n"); + hpet_disable_legacy_replacement_mode(); } clear_IO_APIC_pin(apic1, pin1); diff --git a/xen/include/asm-x86/hpet.h b/xen/include/asm-x86/hpet.h index 07bc8d6079..8f9725a95e 100644 --- a/xen/include/asm-x86/hpet.h +++ b/xen/include/asm-x86/hpet.h @@ -80,6 +80,12 @@ int hpet_legacy_irq_tick(void); bool hpet_enable_legacy_replacement_mode(void); /* + * Undo the effects of hpet_disable_legacy_replacement_mode(). Must not be + * called unless enable() returned true. + */ +void hpet_disable_legacy_replacement_mode(void); + +/* * Temporarily use an HPET event counter for timer interrupt handling, * rather than using the LAPIC timer. Used for Cx state entry. */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Mar 26 19:00:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 19:00:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102056.195511 (Exim 4.92) (envelope-from ) id 1lPrgv-0007ZY-Ad; Fri, 26 Mar 2021 19:00:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102056.195511; Fri, 26 Mar 2021 19:00:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPrgv-0007ZM-7K; Fri, 26 Mar 2021 19:00:17 +0000 Received: by outflank-mailman (input) for mailman id 102056; Fri, 26 Mar 2021 19:00:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPrgt-0007YF-Dl for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 19:00:15 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 921b78e8-fa6d-4e3d-b97b-20b3fe291f33; Fri, 26 Mar 2021 19:00:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 921b78e8-fa6d-4e3d-b97b-20b3fe291f33 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616785214; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Owj/a0DofXQQ1pbrqHaoX4QZh8e96kJPF3mOvOw79JI=; b=dg2HOhy4dwC0tN4caOKSHYpERJEpLPzx41zc7pSGGrsjguP/q3+X9d8J Ic5loMKRwuWZ/JS6lClpGWe6EmnQ8JuYJEAqFHjj8XW9ZVh4m/tsJTDY5 dhkSrxOk4P7liK+7fooezSeDtrGWgqBpzrYFBPUnm/pUgiuORsIyNmSFE 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: iUTJQ4F+iFWnnIvdcpZl+54dk/M1KanUpRnRglrSjSC1p6miXqPe5wm4dYwxZNJqdCJ1554XmY 1ugTvLbKpAUFXax6CUsXSq7D7UseF5dkqKv7OQ40jqdPDazoO8ACduyvkfmkibfyzOD1GpaCYb 47uQtuBqUkxvgFQlgwZiRdtOdYZiO1OJoqLAQ+tGf+B0kgOBx6PhnwznToxmpzOyfCraZXXyxu SySCEUqpqHDkjgVYg3vE9jjRGBOO7OVshs1VyJWMu47PkzNYoeKTuPgQ64o8cbx5eGpGn4hMFy iCU= X-SBRS: 4.0 X-MesageID: 40605116 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:0hFm9qqWi6uyRAbsXIigvGMaV5uTKtV00zAX/kB9WHVpW+SivY SHgOkb2RjoiDwYRXEnnpS6NLOdRG7HnKQa3aA4Bp3neAX9omOnIMVZ7YXkyyD9ACGWzIFg/I 9aWexFBNX0ZGIXse/T6gO1Cstl5dGB/ryhi+u29QYRcShBbaZ84wBlTiOSFUNrTAdLbKBJaK a0zMxBujamZDArft22b0N1E9Triv/qsNbdYRAADwM68wXmt1KVwZPzDhTw5GZmbxph2rEnmF K18TDRxqLmiP2jzw+Z6mm71eUtpPLE6v9uQPOBkdIULDKEsHfmWK1EV6eZtD445MGDgWxa6O XkmBsrM8Rt5365RAjcynGBu3iC7B8U53Dv0lOei3f4yPaJPw4SMMZdmZlfNiLQ9ktIhqAk7I tww2mbu5BLZCmw+BjV2tnSWxlm0mqyrHYy+NRj6UB3bIoEZLdd6bEY5UNeea1wex7S1YZPKp gKMOjsoNJtNX+KZXHQuWdihPa2WG4oIxuASk8e/uSIzjl/hhlCvgUl7f1auk1F2IM2SpFC6e iBGL9vjqtyQsgfar84LPsdQPGwFnfGTXv3QSOvCGWiMJtCF2PGqpbx7rlwzvqtYoY0wJw7n4 mEd19Eq2goeQbLBdeV1JNGtjDBKV/NHQjF+4V73dxUq7f8TL3kPWmoU1Y1ifatpP0ZH4nVQP C2NJVKA+LyLGfnFIpTtjeOGaV6GD07aok4q9w7U1WBrobgMYvxrNHWd/7VOf7sHF8fKybCK0 pGeAK2CNRL70itVHO9qgPWQWnRdkv2+o81FKDb+uMU2ZUcL4EkiHlQtX2JouWwbRFSuK0/e0 VzZJn9lLmgmGWw9WHUq2NzOhRcCU5R6K76U2xDoBILN0+cS8dBh/yvPURpmFeXLB52SM3bVC RFoU5sxK6xJ5uMgTw5B8m/KWKchXsLrHeMR5MR85fzovvNS9cdNNILSaZxHQLEG1hJgg5ssn 5EcxJBbFTYDCnShaKsi4E0COnTe8JnuhqiJddZpBvkxAOhjPBqYkFefja1FeaLnA4lRlNv9y JM2p5apIDFpBGCBi8Uhv8iPFhFdWKNaYg2cjitVcFzgbDkeAZ5UGGQoyeV4itDIlbC/1kOh2 DnMC2fcezKBF0YoXxDzqP26jpPBxSgVlM1ZXZgvYJnE2Pa/n51zO+Qf6K2l3Ccc10Y34gmQX r4SCpXJgNl3Nas0hGJ3D6ECHU9350rV9atRYgLYvXW2nm3LpePmrxDF/hI/Ix9PNSrtuMQS+ qQd0uUKzz/YtlZkzC9tzIgOCNurmMjnu6t0Br57HKg1Hp6GOHMOj1dNsUmCsDZ63KhS+eD0Z 1/g95wteysMn/pYtrDza3MdTZMJh7avGbedZBjlblE+aYp8LdjFZjSVjXFkGtK2xgzN8/4nk ITSqYT2sG2BqZ/O8gJPy5J9Fsgk9qCaFYxugvtG+kkYBUjiWTYM97h2cuElZM/Rkma4A3+Nl mU/3cDo7PLXy6f2aUbDKx1K2JMc0Q44Glj+uTHd4C4MnTZS8hTuF6hdnm6e/tBTaLAH7MapB Nz+cuJkO+abDCQ4nGmgRJrZqZVt3+6SsazCh+WEeFG89amKU2B65Hak/KbnXPyU3+ncEwWio 1OaFwIYslCgjckipcr0iLacN2Dnms1111E4T9mkVbx2o+ppGfDdHs2QTHkvg== X-IronPort-AV: E=Sophos;i="5.81,281,1610427600"; d="scan'208";a="40605116" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Ian Jackson , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Pierret?= Subject: [PATCH v2 1/3] x86/hpet: Factor hpet_enable_legacy_replacement_mode() out of hpet_setup() Date: Fri, 26 Mar 2021 18:59:45 +0000 Message-ID: <20210326185947.23243-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210326185947.23243-1-andrew.cooper3@citrix.com> References: <20210326185947.23243-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit ... in preparation to introduce a second caller. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Ian Jackson CC: Marek Marczykowski-Górecki CC: Frédéric Pierret For 4.15. Pre-req for trying to unbreak AMD Ryzen 1800X systems. v2: * s/u64/uint64_t/ * Drop id local variable --- xen/arch/x86/hpet.c | 116 ++++++++++++++++++++++++--------------------- xen/include/asm-x86/hpet.h | 6 +++ 2 files changed, 68 insertions(+), 54 deletions(-) diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c index 1ff005fb4a..c1d04f184f 100644 --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -754,11 +754,70 @@ int hpet_legacy_irq_tick(void) } static u32 *hpet_boot_cfg; +static uint64_t __initdata hpet_rate; + +bool __init hpet_enable_legacy_replacement_mode(void) +{ + unsigned int cfg, c0_cfg, ticks, count; + + if ( !hpet_rate || + !(hpet_read32(HPET_ID) & HPET_ID_LEGSUP) || + ((cfg = hpet_read32(HPET_CFG)) & HPET_CFG_LEGACY) ) + return false; + + /* Stop the main counter. */ + hpet_write32(cfg & ~HPET_CFG_ENABLE, HPET_CFG); + + /* Reconfigure channel 0 to be 32bit periodic. */ + c0_cfg = hpet_read32(HPET_Tn_CFG(0)); + c0_cfg |= (HPET_TN_ENABLE | HPET_TN_PERIODIC | HPET_TN_SETVAL | + HPET_TN_32BIT); + hpet_write32(c0_cfg, HPET_Tn_CFG(0)); + + /* + * The exact period doesn't have to match a legacy PIT. All we need + * is an interrupt queued up via the IO-APIC to check routing. + * + * Use HZ as the frequency. + */ + ticks = ((SECONDS(1) / HZ) * div_sc(hpet_rate, SECONDS(1), 32)) >> 32; + + count = hpet_read32(HPET_COUNTER); + + /* + * HPET_TN_SETVAL above is atrociously documented in the spec. + * + * Periodic HPET channels have a main comparator register, and + * separate "accumulator" register. Despite being named accumulator + * in the spec, this is not an accurate description of its behaviour + * or purpose. + * + * Each time an interrupt is generated, the "accumulator" register is + * re-added to the comparator set up the new period. + * + * Normally, writes to the CMP register update both registers. + * However, under these semantics, it is impossible to set up a + * periodic timer correctly without the main HPET counter being at 0. + * + * Instead, HPET_TN_SETVAL is a self-clearing control bit which we can + * use for periodic timers to mean that the second write to CMP + * updates the accumulator only, and not the absolute comparator + * value. + * + * This lets us set a period when the main counter isn't at 0. + */ + hpet_write32(count + ticks, HPET_Tn_CMP(0)); + hpet_write32(ticks, HPET_Tn_CMP(0)); + + /* Restart the main counter, and legacy mode. */ + hpet_write32(cfg | HPET_CFG_ENABLE | HPET_CFG_LEGACY, HPET_CFG); + + return true; +} u64 __init hpet_setup(void) { - static u64 __initdata hpet_rate; - unsigned int hpet_id, hpet_period, hpet_cfg; + unsigned int hpet_id, hpet_period; unsigned int last, rem; if ( hpet_rate ) @@ -805,58 +864,7 @@ u64 __init hpet_setup(void) * Reconfigure the HPET into legacy mode to re-establish the timer * interrupt. */ - if ( hpet_id & HPET_ID_LEGSUP && - !((hpet_cfg = hpet_read32(HPET_CFG)) & HPET_CFG_LEGACY) ) - { - unsigned int c0_cfg, ticks, count; - - /* Stop the main counter. */ - hpet_write32(hpet_cfg & ~HPET_CFG_ENABLE, HPET_CFG); - - /* Reconfigure channel 0 to be 32bit periodic. */ - c0_cfg = hpet_read32(HPET_Tn_CFG(0)); - c0_cfg |= (HPET_TN_ENABLE | HPET_TN_PERIODIC | HPET_TN_SETVAL | - HPET_TN_32BIT); - hpet_write32(c0_cfg, HPET_Tn_CFG(0)); - - /* - * The exact period doesn't have to match a legacy PIT. All we need - * is an interrupt queued up via the IO-APIC to check routing. - * - * Use HZ as the frequency. - */ - ticks = ((SECONDS(1) / HZ) * div_sc(hpet_rate, SECONDS(1), 32)) >> 32; - - count = hpet_read32(HPET_COUNTER); - - /* - * HPET_TN_SETVAL above is atrociously documented in the spec. - * - * Periodic HPET channels have a main comparator register, and - * separate "accumulator" register. Despite being named accumulator - * in the spec, this is not an accurate description of its behaviour - * or purpose. - * - * Each time an interrupt is generated, the "accumulator" register is - * re-added to the comparator set up the new period. - * - * Normally, writes to the CMP register update both registers. - * However, under these semantics, it is impossible to set up a - * periodic timer correctly without the main HPET counter being at 0. - * - * Instead, HPET_TN_SETVAL is a self-clearing control bit which we can - * use for periodic timers to mean that the second write to CMP - * updates the accumulator only, and not the absolute comparator - * value. - * - * This lets us set a period when the main counter isn't at 0. - */ - hpet_write32(count + ticks, HPET_Tn_CMP(0)); - hpet_write32(ticks, HPET_Tn_CMP(0)); - - /* Restart the main counter, and legacy mode. */ - hpet_write32(hpet_cfg | HPET_CFG_ENABLE | HPET_CFG_LEGACY, HPET_CFG); - } + hpet_enable_legacy_replacement_mode(); return hpet_rate; } diff --git a/xen/include/asm-x86/hpet.h b/xen/include/asm-x86/hpet.h index fb6bf05065..50176de3d2 100644 --- a/xen/include/asm-x86/hpet.h +++ b/xen/include/asm-x86/hpet.h @@ -73,6 +73,12 @@ void hpet_disable(void); int hpet_legacy_irq_tick(void); /* + * Try to enable HPET Legacy Replacement mode. Returns a boolean indicating + * whether the HPET configuration was changed. + */ +bool hpet_enable_legacy_replacement_mode(void); + +/* * Temporarily use an HPET event counter for timer interrupt handling, * rather than using the LAPIC timer. Used for Cx state entry. */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Mar 26 19:00:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 19:00:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102057.195518 (Exim 4.92) (envelope-from ) id 1lPrgv-0007aT-QQ; Fri, 26 Mar 2021 19:00:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102057.195518; Fri, 26 Mar 2021 19:00:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPrgv-0007aC-JR; Fri, 26 Mar 2021 19:00:17 +0000 Received: by outflank-mailman (input) for mailman id 102057; Fri, 26 Mar 2021 19:00:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPrgt-0007Ut-FD for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 19:00:15 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id edcdd280-ad82-411d-99ca-a5063ee47bef; Fri, 26 Mar 2021 19:00:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: edcdd280-ad82-411d-99ca-a5063ee47bef DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616785212; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pijmjnEufbImw81FhWbQec2beyZXgtBlQJQHB0Itw7E=; b=cUfm3dTQLCK7Ki/P5z68NDZxziXY/cto28/gLqs5+agNY5KDtycCYPiV 9iA9OSPLltIpbqtWe0Kvd1eEE5q2oC7torGfSFUf67eXE3oWERuZdO6wu b+MGf41H+z8XtlKGNfjeSkpxtxaaVUq97ZfJHRumjCKCpIBD/x8AxAfG8 g=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: znjSmlvOe8c1BcBVKXTS8nqurRRZ9FyXKDFF9VBpV/8TYKpGQMXM94k1moU9xUUImDXT86RAd3 afYVdG0L8cHK3Z066JpBRqeqy3rsRxoc3xId80Y5oLqxE4ONvnfExGRfDLMZkYgHvYhRyXfSfV 54KrbBkuWQd54/PjwSk0VFYRzQl//KXYgXW0TcA6DgAti5XUUOnpPYTs3zKZLcskCHbS6hrKYR tvK+PCyMpf64RM0wVZWAhHI6FlRB96jfz0UEw8cxhWuAbZtHWm/zI7ClImQqm5/mmY9q3DKC4s JmY= X-SBRS: 4.0 X-MesageID: 40605113 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:sR1ph6t38leYn8dlD/9y/ylP7skCzoYji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOj7U5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qz6Y 5JSII7MtH5CDFB4frSyAOzH888hPyO9661jenTpk0dMD1CQadm8gt/F0K/Gkp5WAFJCfMCZe ahz+BAoCetfmlSU9SjChA+LqT+jvDotLajWx4JABY79BKD5AnI1JfWGwWVty1uKg9n7qwl9Q H+4m7Ez4Wl98q20xrNk1LUhq4m4ufJ7vtmKIiyhtMOKjPq4zzYK7hJf7GZpjg6rKWOxT8R4a HxiiwtNchy9H/dF1vdyXCGtmmQswoG0HPsxUSVhnHuu6XCNUkHIvFMmJ5DdV/h41cg1esMiZ 5j5X6TtJZcEHr77UDAzuXITB1jmw6VpncvgIco/hpieLYec7NYoMgj+lpUGv47bUXHwb0ged Meaf301bJzSxe3fnrZtm5gzJiHRXIoBCqLRUAEp4i8zyVWtGoR9TpX+OUv2lM7sL4tQZhN4O rJdo5ykqtVc8MQZaVhQM8cXMqMDHDXSx6kChPSHX3XUIU8f17doZ/+57s4oMuwfoYT8Zc0kJ PdFHRVqHA1YECrLcGVxpVE/lTsTQyGLHTQ4/Abw6I8lqz3RbLtPyHGYkspidGcr/IWBdCeVO 20PJ5QHv//PWrjEYtExGTFKttvAEhbdPdQlscwWlqIrM6OAJbtrPbnfPHaI6eoETtMYBK7Pl IzGBzIYOlQ5EGiXXH1xDLLXWn2R0D59ZVsVKzT/+0ZzpkRJpRB2zJlzWiR14WuE3lvo6Y2dE xxLPfMiaWgv1S7+m7O8iFuIRpSDkFc5b36SHNUrQoWM0f5GIxz+Om3SCR35j+qNxV/R8TZHE p0vFJs45+6KJSW2GQ/Ed69K3mbiHESvXqOSJ8ZlsS4lIDYU6J9KqxjdL16FA3NGRAwpB1jr3 1bbhQYAmXFECn1tKmjhJsIJe3WetVmmj23KcpMpX+3jzTbmegfAl8gGx+nS4q+nBsnTTs8vC wPz4YvxJ673QuJBUR6quIiK1FIYHmQG9t9fXq4TbQRvKvqdgF2RXqNnhqAhXgICzLX3k0Pm2 3sKjCVc/nXAlxb/mtVyLru7UkcTBTtQ2tgLn99qoFzDmLApzJ61vKKfLO61y+LZkIF2fx1Ck CPXRICZgdvzcuwzhibhXKLEmgn3IwnOoXmff0eWqCW3nOmM4uTk64aW/dS4ZZ+Ldjr9usGS/ iWdQPQLDT2DYoSqkSoj2dgPCl/s38/l/z0nBXj8WijxXY6RePIP04OfcBuH/iMq2z/A/qY2p Rwitw4+eO2L2Xqc9aDjaXadSRKJB/fqXO/JttY46x8rOY3rv9+DpPbWTzH2DVc0BIyINz9mU keTK54iYqxTLNHbogXYWZU71ApnNOAIA83qQTwGPY5ZkxogHnBPd+FioC45IYHEwmEvk/3Nl ae+SEGoKuAUCuHyLIAC6U/ZW5Rc1Mx7Xx+/OWEM43cYT/aBd1r7R6/KDu6drQYVa2OXbMXpR x+68uTn+CWezHjsTqgygdTM+ZL6SK/Xci2AAiQAuZG/NyxJESUjsKRkb2OpSayTSH+dl8Rio JEf1EBd8hPijEti4sszyi5I5aH134Ngh9Z+jFollnkx4ig7iPaBCh9QH3kvqk= X-IronPort-AV: E=Sophos;i="5.81,281,1610427600"; d="scan'208";a="40605113" From: Andrew Cooper To: Xen-devel CC: Jan Beulich , Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Ian Jackson , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Pierret?= Subject: [PATCH v2 2/3] x86/hpet: Don't enable legacy replacement mode unconditionally Date: Fri, 26 Mar 2021 18:59:46 +0000 Message-ID: <20210326185947.23243-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210326185947.23243-1-andrew.cooper3@citrix.com> References: <20210326185947.23243-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Jan Beulich Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating") was reported to cause boot failures on certain AMD Ryzen systems. Refine the fix to do nothing in the default case, and only attempt to configure legacy replacement mode if IRQ0 is found to not be working. In addition, introduce a "hpet" command line option so this heuristic can be overridden. Since it makes little sense to introduce just "hpet=legacy-replacement", also allow for a boolean argument as well as "broadcast" to replace the separate "hpetbroadcast" option. Signed-off-by: Jan Beulich Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Ian Jackson CC: Marek Marczykowski-Górecki CC: Frédéric Pierret v2: * Reinstate missing hunk from Jan's original patch. * Fix up "8254 PIT". * Drop "goto retry". For 4.15: Attempt to unbreak AMD Ryzen 1800X systems. --- docs/misc/xen-command-line.pandoc | 33 +++++++++++++++++++++++++++ xen/arch/x86/hpet.c | 48 +++++++++++++++++++++++++-------------- xen/arch/x86/io_apic.c | 27 ++++++++++++++++++++++ xen/include/asm-x86/hpet.h | 1 + 4 files changed, 92 insertions(+), 17 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index a0601ff838..a4bd3f12c5 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1274,9 +1274,42 @@ supported. See docs/misc/arm/big.LITTLE.txt for more information. When the hmp-unsafe option is disabled (default), CPUs that are not identical to the boot CPU will be parked and not used by Xen. +### hpet + = List of [ | broadcast= | legacy-replacement= ] + + Applicability: x86 + +Controls Xen's use of the system's High Precision Event Timer. By default, +Xen will use an HPET when available and not subject to errata. Use of the +HPET can be disabled by specifying `hpet=0`. + + * The `broadcast` boolean is disabled by default, but forces Xen to keep + using the broadcast for CPUs in deep C-states even when an RTC interrupt is + enabled. This then also affects raising of the RTC interrupt. + + * The `legacy-replacement` boolean allows for control over whether Legacy + Replacement mode is enabled. + + Legacy Replacement mode is intended for hardware which does not have an + 8254 PIT, and allows the HPET to be configured into a compatible mode. + Intel chipsets from Skylake/ApolloLake onwards can turn the PIT off for + power saving reasons, and there is no platform-agnostic mechanism for + discovering this. + + By default, Xen will not change hardware configuration, unless the PIT + appears to be absent, at which point Xen will try to enable Legacy + Replacement mode before falling back to pre-IO-APIC interrupt routing + options. + + This behaviour can be inhibited by specifying `legacy-replacement=0`. + Alternatively, this mode can be enabled unconditionally (if available) by + specifying `legacy-replacement=1`. + ### hpetbroadcast (x86) > `= ` +Deprecated alternative of `hpet=broadcast`. + ### hvm_debug (x86) > `= ` diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c index c1d04f184f..bfa75f135a 100644 --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -52,6 +52,8 @@ static unsigned int __read_mostly num_hpets_used; DEFINE_PER_CPU(struct hpet_event_channel *, cpu_bc_channel); unsigned long __initdata hpet_address; +int8_t __initdata opt_hpet_legacy_replacement = -1; +static bool __initdata opt_hpet = true; u8 __initdata hpet_blockid; u8 __initdata hpet_flags; @@ -63,6 +65,32 @@ u8 __initdata hpet_flags; static bool __initdata force_hpet_broadcast; boolean_param("hpetbroadcast", force_hpet_broadcast); +static int __init parse_hpet_param(const char *s) +{ + const char *ss; + int val, rc = 0; + + do { + ss = strchr(s, ','); + if ( !ss ) + ss = strchr(s, '\0'); + + if ( (val = parse_bool(s, ss)) >= 0 ) + opt_hpet = val; + else if ( (val = parse_boolean("broadcast", s, ss)) >= 0 ) + force_hpet_broadcast = val; + else if ( (val = parse_boolean("legacy-replacement", s, ss)) >= 0 ) + opt_hpet_legacy_replacement = val; + else + rc = -EINVAL; + + s = ss + 1; + } while ( *ss ); + + return rc; +} +custom_param("hpet", parse_hpet_param); + /* * Calculate a multiplication factor for scaled math, which is used to convert * nanoseconds based values to clock ticks: @@ -820,12 +848,9 @@ u64 __init hpet_setup(void) unsigned int hpet_id, hpet_period; unsigned int last, rem; - if ( hpet_rate ) + if ( hpet_rate || !hpet_address || !opt_hpet ) return hpet_rate; - if ( hpet_address == 0 ) - return 0; - set_fixmap_nocache(FIX_HPET_BASE, hpet_address); hpet_id = hpet_read32(HPET_ID); @@ -852,19 +877,8 @@ u64 __init hpet_setup(void) if ( (rem * 2) > hpet_period ) hpet_rate++; - /* - * Intel chipsets from Skylake/ApolloLake onwards can statically clock - * gate the 8259 PIT. This option is enabled by default in slightly later - * systems, as turning the PIT off is a prerequisite to entering the C11 - * power saving state. - * - * Xen currently depends on the legacy timer interrupt being active while - * IRQ routing is configured. - * - * Reconfigure the HPET into legacy mode to re-establish the timer - * interrupt. - */ - hpet_enable_legacy_replacement_mode(); + if ( opt_hpet_legacy_replacement > 0 ) + hpet_enable_legacy_replacement_mode(); return hpet_rate; } diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index e93265f379..3f131a81fb 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -29,6 +29,8 @@ #include #include #include + +#include #include #include #include @@ -1930,6 +1932,31 @@ static void __init check_timer(void) local_irq_restore(flags); return; } + + /* + * Intel chipsets from Skylake/ApolloLake onwards can statically clock + * gate the 8254 PIT. This option is enabled by default in slightly + * later systems, as turning the PIT off is a prerequisite to entering + * the C11 power saving state. + * + * Xen currently depends on the legacy timer interrupt being active + * while IRQ routing is configured. + * + * If the user hasn't made an explicit choice, attempt to reconfigure + * the HPET into legacy mode to re-establish the timer interrupt. + */ + if ( opt_hpet_legacy_replacement < 0 && + hpet_enable_legacy_replacement_mode() ) + { + printk(XENLOG_ERR "..no 8254 timer found - trying HPET Legacy Replacement Mode\n"); + + if ( timer_irq_works() ) + { + local_irq_restore(flags); + return; + } + } + clear_IO_APIC_pin(apic1, pin1); printk(KERN_ERR "..MP-BIOS bug: 8254 timer not connected to " "IO-APIC\n"); diff --git a/xen/include/asm-x86/hpet.h b/xen/include/asm-x86/hpet.h index 50176de3d2..07bc8d6079 100644 --- a/xen/include/asm-x86/hpet.h +++ b/xen/include/asm-x86/hpet.h @@ -53,6 +53,7 @@ extern unsigned long hpet_address; extern u8 hpet_blockid; extern u8 hpet_flags; +extern int8_t opt_hpet_legacy_replacement; /* * Detect and initialise HPET hardware: return counter update frequency. -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Mar 26 19:03:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 19:03:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102069.195534 (Exim 4.92) (envelope-from ) id 1lPrjY-0007x0-9n; Fri, 26 Mar 2021 19:03:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102069.195534; Fri, 26 Mar 2021 19:03:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPrjY-0007wt-6m; Fri, 26 Mar 2021 19:03:00 +0000 Received: by outflank-mailman (input) for mailman id 102069; Fri, 26 Mar 2021 19:02:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPrjW-0007we-Le; Fri, 26 Mar 2021 19:02:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPrjW-0005RU-Ga; Fri, 26 Mar 2021 19:02:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPrjW-00007X-7r; Fri, 26 Mar 2021 19:02:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPrjW-0006bB-7O; Fri, 26 Mar 2021 19:02:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HGdLmK1OwEnv6FRJgJJ/3MIk/HqkPArghyH53TvTFy4=; b=p063q+/gBPckCwUq+LOFT5O6C/ bbId13huPPb0g5Xa7IN061aw355IrSL3NCi3OFZLJCXZJegVQJeL9FsT5GEnfT+ZRizL20MyQXSas F42YRINWV1S0Xqq/4F4lF+abUQ+Lk8epjtTcTm/6lQmuADwJNgOwOsq6ewDzq2V9+ReE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160449: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=8bfceeed789e4394a9c45403a19f29909f2b2641 X-Osstest-Versions-That: xen=03bee3fd475cb755572dd21214daecf9a77a6bb4 From: osstest service owner Date: Fri, 26 Mar 2021 19:02:58 +0000 flight 160449 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160449/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 8bfceeed789e4394a9c45403a19f29909f2b2641 baseline version: xen 03bee3fd475cb755572dd21214daecf9a77a6bb4 Last test of basis 160445 2021-03-26 13:01:30 Z 0 days Testing same since 160449 2021-03-26 16:01:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Ian Jackson Jan Beulich Roger Pau Monné Tamas K Lengyel jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 03bee3fd47..8bfceeed78 8bfceeed789e4394a9c45403a19f29909f2b2641 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Mar 26 20:07:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 20:07:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102081.195556 (Exim 4.92) (envelope-from ) id 1lPsjW-0006dY-5K; Fri, 26 Mar 2021 20:07:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102081.195556; Fri, 26 Mar 2021 20:07:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPsjW-0006dR-2I; Fri, 26 Mar 2021 20:07:02 +0000 Received: by outflank-mailman (input) for mailman id 102081; Fri, 26 Mar 2021 20:07:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPsjU-0006dJ-9J; Fri, 26 Mar 2021 20:07:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPsjT-0006VM-T4; Fri, 26 Mar 2021 20:06:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPsjT-0002QY-Jy; Fri, 26 Mar 2021 20:06:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPsjT-0006Og-JU; Fri, 26 Mar 2021 20:06:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ArYiD03ei2ZXi6HuPVg/xdFuymM1SuAcGwbScvvvyY8=; b=wUjQjZ8pnZKg5m74GYDvQ6d4qw Dk/cu0fTdq9ULRwKGxpwPO/gOfne4yWomI/agWKe+GsmjYJs5czoJOHmsodeoG2zMm7XKCnwyKmI2 fSkpvMoBtC+OKNZEUHYzMg72TWgeUtAD545yvC5qjBo2hsY12jHNd9J/3n7zht5/CZuQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 160422: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0f93d79a97121c55d3f3e26304d437ddb38de6a7 X-Osstest-Versions-That: xen=ecdff2f5a03210119b71806c3f5571d6906dd85e From: osstest service owner Date: Fri, 26 Mar 2021 20:06:59 +0000 flight 160422 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160422/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160394 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160394 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160394 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160394 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160394 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160394 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160394 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160394 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160394 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160394 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160394 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 0f93d79a97121c55d3f3e26304d437ddb38de6a7 baseline version: xen ecdff2f5a03210119b71806c3f5571d6906dd85e Last test of basis 160394 2021-03-24 16:35:42 Z 2 days Testing same since 160422 2021-03-25 20:07:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ian Jackson Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ecdff2f5a0..0f93d79a97 0f93d79a97121c55d3f3e26304d437ddb38de6a7 -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Fri Mar 26 20:44:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 20:44:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102095.195582 (Exim 4.92) (envelope-from ) id 1lPtJX-0002v3-He; Fri, 26 Mar 2021 20:44:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102095.195582; Fri, 26 Mar 2021 20:44:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPtJX-0002uw-ER; Fri, 26 Mar 2021 20:44:15 +0000 Received: by outflank-mailman (input) for mailman id 102095; Fri, 26 Mar 2021 20:44:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPtJV-0002uo-H8; Fri, 26 Mar 2021 20:44:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPtJV-000783-6x; Fri, 26 Mar 2021 20:44:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPtJU-0004Vk-SV; Fri, 26 Mar 2021 20:44:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPtJU-0001Ab-S2; Fri, 26 Mar 2021 20:44:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SBjg0ix50jWx3oBVg/9S6HD1BtXuuKOSUvizKPRRhbU=; b=jkbiDdlCkfu7R+N2Z6Jhm5nesG GuRusT8xlkxluV648h3w5KFX34nf9QVnDzEKeo7lZPBgM7s5BJMCtPqy1qX9HyyF+3IFSx7B2SDCG BcZPKSJ5sJZW/PNuwSNS3mmU1QtS2A68IyaaMdSjRYnAC7MBtchbDzv3Tidh33LIhb+0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-upstream-4.15-testing baseline test] 160423: tolerable FAIL X-Osstest-Failures: qemu-upstream-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-upstream-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-upstream-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-upstream-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-upstream-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-upstream-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=7ea428895af2840d85c524f0bd11a38aac308308 X-Osstest-Versions-That: qemuu=7ea428895af2840d85c524f0bd11a38aac308308 From: osstest service owner Date: Fri, 26 Mar 2021 20:44:12 +0000 "Old" tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. flight 160423 qemu-upstream-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160423/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail baseline untested test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail baseline untested test-armhf-armhf-libvirt 16 saverestore-support-check fail baseline untested test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail baseline untested test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail baseline untested test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail baseline untested test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail baseline untested test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 7ea428895af2840d85c524f0bd11a38aac308308 baseline version: qemuu 7ea428895af2840d85c524f0bd11a38aac308308 Last test of basis 160423 2021-03-25 20:09:46 Z 1 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri Mar 26 20:45:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 20:45:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102099.195598 (Exim 4.92) (envelope-from ) id 1lPtKi-00033C-Vn; Fri, 26 Mar 2021 20:45:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102099.195598; Fri, 26 Mar 2021 20:45:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPtKi-000335-SI; Fri, 26 Mar 2021 20:45:28 +0000 Received: by outflank-mailman (input) for mailman id 102099; Fri, 26 Mar 2021 20:45:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPtKh-00032v-TO; Fri, 26 Mar 2021 20:45:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPtKh-00078v-Mc; Fri, 26 Mar 2021 20:45:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPtKh-0004Y6-HJ; Fri, 26 Mar 2021 20:45:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPtKh-0001bJ-Gp; Fri, 26 Mar 2021 20:45:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zUf/s7hw98lJcudYgSremf9CWuN6cvT/TT6eM6FsiYQ=; b=O7F2l0H6MjtPHhf8lxzVYVv+80 EAnxiQPKtQ1M/FDCXyZxTukgFrPg7UwreTAay/e/yCiEYvPAeFfgi90j1j0/S0+dVqDC3/cwWAxTm MiKpscaDAT3Vkz0P1fHOgJdAEH4qaAFjAvIq0Uie6UA15dFFM7PCg+489RcqFivOkVI0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160434: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=ae1201fab46dfeae20a34927e4fdfdff75c07b84 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 26 Mar 2021 20:45:27 +0000 flight 160434 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160434/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt ae1201fab46dfeae20a34927e4fdfdff75c07b84 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 259 days Failing since 151818 2020-07-11 04:18:52 Z 258 days 251 attempts Testing same since 160434 2021-03-26 04:19:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 49003 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Mar 26 20:55:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 20:55:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102110.195612 (Exim 4.92) (envelope-from ) id 1lPtUQ-0004MQ-5f; Fri, 26 Mar 2021 20:55:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102110.195612; Fri, 26 Mar 2021 20:55:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPtUQ-0004MJ-2W; Fri, 26 Mar 2021 20:55:30 +0000 Received: by outflank-mailman (input) for mailman id 102110; Fri, 26 Mar 2021 20:55:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPtUP-0004MB-6b; Fri, 26 Mar 2021 20:55:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPtUO-0007It-Vg; Fri, 26 Mar 2021 20:55:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPtUO-0004yO-OT; Fri, 26 Mar 2021 20:55:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPtUO-0000F8-O0; Fri, 26 Mar 2021 20:55:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=f9hsVe7aM5vS9vEjLY2X9ZJaCNEzdvvIiFPooifqwqY=; b=TbdJ+XvnxSDhdPNIMpGb3QHbj+ 0zArsSra8mpirmoIT/mIgBgZ6sV43yfSBpYJtNkqX1mM80qN+U5qCK9bVI/Y1nISwqziCk+Jz2/Wv PTkbcnYzneL/JvNxeiiaQYHhzlijf/uGyuLf9OyFPWQgNb7utEnxqxWQwQJ0QgXGej5M=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160425: all pass - PUSHED X-Osstest-Versions-This: ovmf=4bf2a5b045ebf8b5e90d9210ad5190699bddb592 X-Osstest-Versions-That: ovmf=f037af6ecbc3b55042c998a59ed8df8548e64b99 From: osstest service owner Date: Fri, 26 Mar 2021 20:55:28 +0000 flight 160425 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160425/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4bf2a5b045ebf8b5e90d9210ad5190699bddb592 baseline version: ovmf f037af6ecbc3b55042c998a59ed8df8548e64b99 Last test of basis 160399 2021-03-24 22:10:54 Z 1 days Testing same since 160425 2021-03-25 20:38:30 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ankur Arora Laszlo Ersek Liming Gao Ni, Ray Ray Ni jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git f037af6ecb..4bf2a5b045 4bf2a5b045ebf8b5e90d9210ad5190699bddb592 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Mar 26 22:30:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 26 Mar 2021 22:30:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102120.195634 (Exim 4.92) (envelope-from ) id 1lPuxe-0006sU-5n; Fri, 26 Mar 2021 22:29:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102120.195634; Fri, 26 Mar 2021 22:29:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPuxe-0006sN-2b; Fri, 26 Mar 2021 22:29:46 +0000 Received: by outflank-mailman (input) for mailman id 102120; Fri, 26 Mar 2021 22:29:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPuxd-0006sF-2M; Fri, 26 Mar 2021 22:29:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPuxc-0000QG-RJ; Fri, 26 Mar 2021 22:29:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPuxc-0000NV-K1; Fri, 26 Mar 2021 22:29:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lPuxc-0006C6-JR; Fri, 26 Mar 2021 22:29:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RhP7kRq6hcKyHvTQuzv+1u7/cg1/k8a4SUJ2mJ174nA=; b=y6OXaAigfcXUVm3ksS/I8vd4y8 JQEi19OKQUTRmT15SsVS9C12eWxDiF/oHaTc83XiyfleNR1U4GzJYaqea+sLK/ULHxAGu5aKScH0D Wnb4RPXHyEizuYrIi5gUz2E2mMwB8SyN/a/sN55amYbALBoBkQ9jOZc9o30yEGd1tnyI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160454: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e680cc48b7184d3489873d6776f84ba1fc238ced X-Osstest-Versions-That: xen=8bfceeed789e4394a9c45403a19f29909f2b2641 From: osstest service owner Date: Fri, 26 Mar 2021 22:29:44 +0000 flight 160454 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160454/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e680cc48b7184d3489873d6776f84ba1fc238ced baseline version: xen 8bfceeed789e4394a9c45403a19f29909f2b2641 Last test of basis 160449 2021-03-26 16:01:55 Z 0 days Testing same since 160454 2021-03-26 20:00:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 8bfceeed78..e680cc48b7 e680cc48b7184d3489873d6776f84ba1fc238ced -> smoke From xen-devel-bounces@lists.xenproject.org Sat Mar 27 01:52:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 27 Mar 2021 01:52:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102133.195667 (Exim 4.92) (envelope-from ) id 1lPy6w-00082a-WE; Sat, 27 Mar 2021 01:51:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102133.195667; Sat, 27 Mar 2021 01:51:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPy6w-00082Q-NT; Sat, 27 Mar 2021 01:51:34 +0000 Received: by outflank-mailman (input) for mailman id 102133; Sat, 27 Mar 2021 01:51:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPy6u-00082L-Jt for xen-devel@lists.xenproject.org; Sat, 27 Mar 2021 01:51:32 +0000 Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a2e761f3-19bd-40e2-853f-b2836982b48a; Sat, 27 Mar 2021 01:51:31 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12R1o8Jn070414; Sat, 27 Mar 2021 01:51:28 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 37h13ruq0n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 27 Mar 2021 01:51:28 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12R1oM0u092347; Sat, 27 Mar 2021 01:51:27 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2047.outbound.protection.outlook.com [104.47.56.47]) by userp3020.oracle.com with ESMTP id 37h14hvtrn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 27 Mar 2021 01:51:27 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BYAPR10MB2470.namprd10.prod.outlook.com (2603:10b6:a02:ae::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Sat, 27 Mar 2021 01:51:25 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.025; Sat, 27 Mar 2021 01:51:25 +0000 Received: from bostrovs-us.us.oracle.com (209.17.40.37) by SJ0PR13CA0228.namprd13.prod.outlook.com (2603:10b6:a03:2c1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.16 via Frontend Transport; Sat, 27 Mar 2021 01:51:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2e761f3-19bd-40e2-853f-b2836982b48a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=+j7ZPwO82JAZbbAqWXdxwkE793Vt87O8eQKF+FoLSks=; b=HmqSIvU4u6oFQWeBiQ7vn46tlrNU7lSkLMH1B0ywrI0VuAjnHYZtN4cuCsEJphU7z7iQ xKft1nla8Ir3BcLLoGphR12i8wtWUF03F1dWgFi6POGlxHc+ui/1m5hwD8MVoqQM8/n9 GmI9KKeAUwaZnzUPxeP38eTOe7MbJf0VQizfzFehb/Y8oPNsJhfWUI2buKz7ER7PT3Uc V+B/Hy2O9AUuIk8nsjYLlMw5OkQCCCFKpS6JIk6jU0DKi2c7Mdp2EoBScnd2N5DHlSJB nYL4JfXEwqQ2XASJ23ZcT1wfM2Q7SLVU99vOqAOhEhwSgLRA6JlKTXLLdShzUwtrgQpj qA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m3gffv7s2/20/xUbNoVx9ItFC78RJ0/C1nkwNZ72i11gsZlLAsFpj3tHy4tce5whoJK9qykZb4G1CEdVNoUU/n70GRQc+/tdaadZ6sjB2r5MVQ29x6Rj71s6IgjFwec5HIvm3SQ68GsQWaEnrEEEF3EaaeQGoc0TdjuNc2Rhda7ht4NjgCjiH/N5vOO1IGklgRGyms4KUY18a12zt7Tj1LJKV2jjEUU7bywt1YIhlOwjHzw2VjWpBm0RuVTYlhDarZZ30kRRKO6HikNU8LHUWVQuIy2qlzCk/BaTNPqVU5n+TJXJ8E6ise0MgofgHJgePcbqHgSk0M3cly+nqJrFZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+j7ZPwO82JAZbbAqWXdxwkE793Vt87O8eQKF+FoLSks=; b=RAYBbbtFxQdnGZ8gCvYzldIQ/EMFdgI9MXnTODAi3s6Ov286FNTpfAzbhkujGkaOHyxJLZEqNTuC+Y6bM/6Lzfn4kMPZvwjd0UNX4zMaVH3BNgtRoQjNeAeWVbTPUntahddNUK90O1sNBetMeRG2h+9pcZ3k3rSEd5Ti/hRKlM8QR4vetQu+5g02gBSxQnPfFUiEZmyEQWEbxpDIQ/TSr0kq5QEG392H/Dfnrx78bKIamF/RaDzCVoqu3XHwOv3ZXHM5OXyGQeN0oXPWAC+QT0opgiAVa3fy6VgUnKu87rc/cCDcbvy8KUgauWSOxEyGX55xJ976d3YhojrYyr1pWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+j7ZPwO82JAZbbAqWXdxwkE793Vt87O8eQKF+FoLSks=; b=ln/7UHXxwA1KD+PQcGsGWziMeOTpEtPzJos7bkLSur230S4qWI9lltwT3qhXH1lrmPcrwOgTDlnsp3X6mUPSNLalkxAszizaAWTZ499AOa946QE7SQxfJLWYXSLjrId+2U/l/Up6RUQ+AjJnuB0aD53+7SCLH8YF0dc8MrDBigs= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; From: Boris Ostrovsky To: xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, boris.ostrovsky@oracle.com, stephen.s.brennan@oracle.com, iwj@xenproject.org Subject: [PATCH v2] x86/vpt: Do not take pt_migrate rwlock in some cases Date: Fri, 26 Mar 2021 21:51:06 -0400 Message-Id: <1616809866-30837-1-git-send-email-boris.ostrovsky@oracle.com> X-Mailer: git-send-email 1.8.3.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [209.17.40.37] X-ClientProxiedBy: SJ0PR13CA0228.namprd13.prod.outlook.com (2603:10b6:a03:2c1::23) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: df004bcc-70f0-48f9-a367-08d8f0c2d46c X-MS-TrafficTypeDiagnostic: BYAPR10MB2470: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hi1g0M6YenUqq3GYqH5xLuoEwabiJnyQyIZiz/ZVg8ncBlirzYjgflehP+3Vw1SSvaT11afUklFW6KfAGuYy68M4j88B0RGGGj8lX08pMGDzPQfh6OyTkem5o2oDfY4JXAUnh640O4BhMa5tBcwaAPZ6XZdDorKcmgpbPa68ojP6FCIRbpPItNZaxkaLfgjUrPRrMEv4RccCkZYjXOMyJM/5te/Zyao9etRxqjOXlTevwb9jJz+gu0pVc0bOhz1Q212qp6LcxBFzc729CQMKVHU9B9Qq13BJaV2imYome9DZE6GNZeNTl8VYE1EbgqR3/K2NVC2wWnoI9+swOp/qR6+22cKeeAWQ4MdkuWnuShlt+ItSnFNuKHPjn3jYfhmDnxFKJapMK1dF6y7KQKy6I7SxJnZhFs92tfHaB9/NnQiTOxtFwd6cP+BNPDxjFvb4z2GZxt9isLyyyYQNsV84GW/JTC5FDGvOF+DQMKQkx+B3PlFSFNS6/BJ1sLp8XqOmaI0sDXkHeWqxrgnqcAV0XBe2T4jVeXgl7ZVivmJI2BupxNyMPk4OfmHRuk0PVAyit3V2kyDgZONeHe9yMrRfig== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(39860400002)(346002)(366004)(396003)(38100700001)(4326008)(83380400001)(86362001)(36756003)(44832011)(2906002)(6486002)(66946007)(2616005)(6666004)(26005)(186003)(5660300002)(316002)(16526019)(52116002)(66556008)(7696005)(478600001)(8676002)(6916009)(66476007)(8936002)(956004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MVFkNENUY1JueGI1UmhWTHFpeTNpaXl6UXFwNHVzRTJxN1hmeU4vL0grbFRs?= =?utf-8?B?UHFOVDZhVmhVbnowZytiZVRzNkZvS0I0OUkvMW1uRlV5Y1NTM1ZLNUh4N0Vp?= =?utf-8?B?WTZxYTk3bjJ3aHNRbWk1YXI4ci8rZ3B2ODMxQXE0blh4eG1HUFdDOERRRlRk?= =?utf-8?B?QTJWQTMyTGlmcFVmQU43dzZBZHdYY0o0WFdMTXJtUmViSEZvek4zMzNvcUY3?= =?utf-8?B?TDUwNmJybFdUcndOQVdyZ2xobjRxZDJwWjBOQnphV2YxRVlUNmlHSnl5RjMz?= =?utf-8?B?SzFsc21raTFzaGEwdExIL0pqOG9jeGRYUm41aG5lT3BRMTd4ZkVyTGVtRE5k?= =?utf-8?B?MVZNc080NUZxMU5FS1ZObEtRTmQ3aEVNeDNlZkNjWmdDRmQzdXR2RXA3VVBR?= =?utf-8?B?dXJwM3I2SjQ0anVnUjV3SUJLMFlndXpUZEhIUG1ybFhYVzZCV2tWajBUQzRz?= =?utf-8?B?aU9kRFYxOFhoSXR1M1R0dzVSQ0JEMDNJVkhuaGhudEc2ZXhVTkU3SDRyVDli?= =?utf-8?B?eHhleVJ0bk5MQjR4N28zWTVpTjB6NnNWZk9aOXRWdURLTFVJM09EblZRSURI?= =?utf-8?B?eUxTNGJaSzBBNWdKa0xJdG1XNmc1UFNndmtwYm4wK0poYnZHSEprYWp3ejU0?= =?utf-8?B?QUNheThoZDkxTHJsWUUzekltYW8ybHoxSnFyWUZTNnhlMmxvMTNOMnNWc2Fz?= =?utf-8?B?RnRjR0F6a2xFNUJQSkNNZlN2R0UvWE9ncFh4dVo2eDRVb3BJVCtiYjFianhn?= =?utf-8?B?ak9NV1ZkUWVtdzNlZWFnS0RxbTdxNDh4eTFINEVzTkpkdWRrUGVPQ2VJdzNP?= =?utf-8?B?Z1UvRVF1VDNpOERDRnJhZ1h3eG1LaVozdkxJTCtGQ3FBZkRkTVg1dXNudHVG?= =?utf-8?B?NGtMb2tiZU4zMEZvQ1FBaG8vdkpCMlM1OFFkcndkb1NESzVjNlZ5ZndFSlpn?= =?utf-8?B?S0VEL2xHMWhJdU1GMDlCSVpKSlJiZHZYVklKSVdFY1MrZkxRTWh1QVRtdTVD?= =?utf-8?B?ZzRpRDVEOE9tRm91QWNZc2JrUkJQejAwdEl0WjYvSkZJVS9kQkJaSk1HQjZt?= =?utf-8?B?bFFGVzRiOGxEcGR5aUp6T09FbWlJUXFlM1A2dlZndUROTGdsdkJSY1dmdHB1?= =?utf-8?B?bE1aSk5WT0dGUTJtSHBOM3JBTEZWNFFBSVkxbmVIRG9NU3pXV05ZaHYvVjVR?= =?utf-8?B?a0JnU1lCRHJtdE5IUzNVNkZwaDd5TlZUU0hKR2ltTGRaSWF5ME5qcnVVV0FU?= =?utf-8?B?TXA0RDVKWVlZOE1FUTBocE1id2lYbStRYUhZeTVVU3pRMmxoTkx2N1FBR2tN?= =?utf-8?B?cEJEKzRRZFk3RDNTUlJCRjRHMC9haGpneHNWTnN2a2ZMaE9UWERTTGNVcVM4?= =?utf-8?B?a3laakdiSTd4NEtLVnZXQVNPQnUwNjZydGRmRDJNaTgwWHJSRzlDanZacmZu?= =?utf-8?B?ZXRJNzN4ZXFzWUVrRi9HWTJYNmRuNWFoMGlCcm5CSzRoWlZOSjYwVzVadEhq?= =?utf-8?B?dGdtWDV4RGhkTUYyWmp0c1doQUs4VVZ1YUNSYU56S2hnWUhIVUlKdWRTa0Fw?= =?utf-8?B?THNXckVZcXVSSjJPRzk1MDJybmFmUjJ5K0lTalhNcUwvR3VoWE1qSWVSUDZh?= =?utf-8?B?WGs3aTNxTjBsSTR6a1YzVk9MRUZFMUJHNW51dU9OdnE3ZHZ6VktUckx4c2xF?= =?utf-8?B?S3FYSTdIK1UzbHpiUURFRCtvNnJFc1l6NUFrcEVYWVIwcjdIZmFIb3AxV2Mw?= =?utf-8?Q?DAb4elIZrhXQZnt4wfkgyAD30IAufPdRMrlJni2?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: df004bcc-70f0-48f9-a367-08d8f0c2d46c X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2021 01:51:25.2185 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D7vOjcAxvu2OUL7qQ2qevK5ciRiQhgrjXx6H5xxoWabpwW0bHVgcQbnvwLo8VmNpcb13bCqZvnZl1O/aBMq79YWc6nBzkFbALhKYUEJU+cQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2470 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9935 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0 phishscore=0 adultscore=0 mlxscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103270012 X-Proofpoint-ORIG-GUID: pvBoUtRQNmagLdNqBhn5B0MIFIuXqhRu X-Proofpoint-GUID: pvBoUtRQNmagLdNqBhn5B0MIFIuXqhRu X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9935 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 clxscore=1015 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103270012 Commit 8e76aef72820 ("x86/vpt: fix race when migrating timers between vCPUs") addressed XSA-336 by introducing a per-domain rwlock that was intended to protect periodic timer during VCPU migration. Since such migration is an infrequent event no performance impact was expected. Unfortunately this turned out not to be the case: on a fairly large guest (92 VCPUs) we've observed as much as 40% TPCC performance regression with some guest kernels. Further investigation pointed to pt_migrate read lock taken in pt_update_irq() as the largest contributor to this regression. With large number of VCPUs and large number of VMEXITs (from where pt_update_irq() is always called) the update of an atomic in read_lock() is thought to be the main cause. Stephen Brennan analyzed locking pattern and classified lock users as follows: 1. Functions which read (maybe write) all periodic_time instances attached to a particular vCPU. These are functions which use pt_vcpu_lock() after the commit, such as pt_restore_timer(), pt_save_timer(), etc. 2. Functions which want to modify a particular periodic_time object. These guys lock whichever vCPU the periodic_time is attached to, but since the vCPU could be modified without holding any lock, they are vulnerable to the bug. Functions in this group use pt_lock(), such as pt_timer_fn() or destroy_periodic_time(). 3. Functions which not only want to modify the periodic_time, but also would like to modify the =vcpu= fields. These are create_periodic_time() or pt_adjust_vcpu(). They create the locking imbalance bug for group 2, but we can't simply hold 2 vcpu locks due to the deadlock risk. Roger Monné then pointed out that group 1 functions don't really need to hold the pt_migrate rwlock and that group 3 should be hardened by holding appropriate vcpu's tm_lock when adding or deleting a timer from its list. Suggested-by: Stephen Brennan Suggested-by: Roger Pau Monne Signed-off-by: Boris Ostrovsky --- v2: Drop per-periodic_time spinlock and keep pt_migrate rwlock (and thus change patch subject) xen/arch/x86/hvm/vpt.c | 40 +++++++++++++++++++++++++++++++--------- xen/include/asm-x86/hvm/vpt.h | 8 ++++---- 2 files changed, 35 insertions(+), 13 deletions(-) diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index 4c2afe2e9154..893641f20e1c 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -153,32 +153,43 @@ static int pt_irq_masked(struct periodic_time *pt) return 1; } +/* + * Functions which read (maybe write) all periodic_time instances + * attached to a particular vCPU use these locking helpers. + * + * Such users are explicitly forbidden from changing the value of the + * pt->vcpu field, because another thread holding the pt_migrate lock + * may already be spinning waiting for your vcpu lock. + */ static void pt_vcpu_lock(struct vcpu *v) { - read_lock(&v->domain->arch.hvm.pl_time->pt_migrate); spin_lock(&v->arch.hvm.tm_lock); } static void pt_vcpu_unlock(struct vcpu *v) { spin_unlock(&v->arch.hvm.tm_lock); - read_unlock(&v->domain->arch.hvm.pl_time->pt_migrate); } +/* + * Functions which want to modify a particular periodic_time object + * use these locking helpers. + * + * These users lock whichever vCPU the periodic_time is attached to, + * but since the vCPU could be modified without holding any lock, they + * need to take an additional lock that protects against pt->vcpu + * changing. + */ static void pt_lock(struct periodic_time *pt) { - /* - * We cannot use pt_vcpu_lock here, because we need to acquire the - * per-domain lock first and then (re-)fetch the value of pt->vcpu, or - * else we might be using a stale value of pt->vcpu. - */ read_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); spin_lock(&pt->vcpu->arch.hvm.tm_lock); } static void pt_unlock(struct periodic_time *pt) { - pt_vcpu_unlock(pt->vcpu); + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); + read_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); } static void pt_process_missed_ticks(struct periodic_time *pt) @@ -543,8 +554,10 @@ void create_periodic_time( pt->cb = cb; pt->priv = data; + pt_vcpu_lock(pt->vcpu); pt->on_list = 1; list_add(&pt->list, &v->arch.hvm.tm_list); + pt_vcpu_unlock(pt->vcpu); init_timer(&pt->timer, pt_timer_fn, pt, v->processor); set_timer(&pt->timer, pt->scheduled); @@ -580,13 +593,22 @@ static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) return; write_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); + + pt_vcpu_lock(pt->vcpu); + if ( pt->on_list ) + list_del(&pt->list); + pt_vcpu_unlock(pt->vcpu); + pt->vcpu = v; + + pt_vcpu_lock(pt->vcpu); if ( pt->on_list ) { - list_del(&pt->list); list_add(&pt->list, &v->arch.hvm.tm_list); migrate_timer(&pt->timer, v->processor); } + pt_vcpu_unlock(pt->vcpu); + write_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); } diff --git a/xen/include/asm-x86/hvm/vpt.h b/xen/include/asm-x86/hvm/vpt.h index 39d26cbda496..f3c2a439630a 100644 --- a/xen/include/asm-x86/hvm/vpt.h +++ b/xen/include/asm-x86/hvm/vpt.h @@ -129,10 +129,10 @@ struct pl_time { /* platform time */ struct HPETState vhpet; struct PMTState vpmt; /* - * rwlock to prevent periodic_time vCPU migration. Take the lock in read - * mode in order to prevent the vcpu field of periodic_time from changing. - * Lock must be taken in write mode when changes to the vcpu field are - * performed, as it allows exclusive access to all the timers of a domain. + * Functions which want to modify the vcpu field of the vpt need to + * hold the global lock (pt_migrate) in write mode together with the + * per-vcpu locks of the lists being modified. Note that two vcpu + * locks cannot be held at the same time to avoid a deadlock. */ rwlock_t pt_migrate; /* guest_time = Xen sys time + stime_offset */ -- 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Sat Mar 27 04:37:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 27 Mar 2021 04:37:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102141.195691 (Exim 4.92) (envelope-from ) id 1lQ0hM-00020T-3N; Sat, 27 Mar 2021 04:37:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102141.195691; Sat, 27 Mar 2021 04:37:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ0hM-00020M-0F; Sat, 27 Mar 2021 04:37:20 +0000 Received: by outflank-mailman (input) for mailman id 102141; Sat, 27 Mar 2021 04:37:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ0hK-00020E-4B; Sat, 27 Mar 2021 04:37:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ0hJ-0000YM-Mw; Sat, 27 Mar 2021 04:37:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ0hJ-0002BC-D5; Sat, 27 Mar 2021 04:37:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQ0hJ-0007zh-CZ; Sat, 27 Mar 2021 04:37:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PT7CowZ4wvyTDpkVZUsBBCsH6+wgxjEWVSJuTmbpeUY=; b=iN7RgsLRq+v8bUvTSnj0pgUf/Q CKWv7YIQ7cGRywzcqCFaSxPUlSrlvGgCV0OlyGTEnznRmIY03uDUXdWszZVNo978bRpTAxPbARa0/ nk84E9k6vXZHZ3vgkV8JKK++Js1Mt51FnnGlL91g925ZcnzOgQUurDs50j/1ixe+khp8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160432: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:heisenbug xen-4.12-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.12-testing:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:heisenbug xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Sat, 27 Mar 2021 04:37:17 +0000 flight 160432 xen-4.12-testing real [real] flight 160463 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160432/ http://logs.test-lab.xenproject.org/osstest/logs/160463/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 18 guest-saverestore.2 fail in 160400 pass in 160432 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160400 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail pass in 160400 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 38 days Failing since 160128 2021-03-18 14:36:18 Z 8 days 8 attempts Testing same since 160150 2021-03-20 04:11:48 Z 7 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 27 05:56:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 27 Mar 2021 05:56:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102093.195718 (Exim 4.92) (envelope-from ) id 1lQ1vO-00030K-KQ; Sat, 27 Mar 2021 05:55:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102093.195718; Sat, 27 Mar 2021 05:55:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ1vO-000307-E7; Sat, 27 Mar 2021 05:55:54 +0000 Received: by outflank-mailman (input) for mailman id 102093; Fri, 26 Mar 2021 20:42:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPtHn-0002tc-Ab for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 20:42:27 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (unknown [40.107.5.68]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1b02475f-1ffa-4f49-a48e-0a70368f85a8; Fri, 26 Mar 2021 20:42:24 +0000 (UTC) Received: from AM4PR05MB3331.eurprd05.prod.outlook.com (2603:10a6:205:c::27) by AM0PR05MB4194.eurprd05.prod.outlook.com (2603:10a6:208:57::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Fri, 26 Mar 2021 20:42:21 +0000 Received: from AM4PR05MB3331.eurprd05.prod.outlook.com ([fe80::59bd:9a92:960:5ef3]) by AM4PR05MB3331.eurprd05.prod.outlook.com ([fe80::59bd:9a92:960:5ef3%5]) with mapi id 15.20.3955.024; Fri, 26 Mar 2021 20:42:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b02475f-1ffa-4f49-a48e-0a70368f85a8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JLvR5QF9RJVvUNUU7kkVJMpYMYnIjSXMbmxTqtvH7AojNQLn6Zm1kKNOWGqy793d9EtCx+52W2rDU2hauJhw2AkRJYjTxrJBjfQC23wF074cdOHmz3TV92am6w3/R7TaxB0bTIfkqKyWR313Qd10iKcjAf0xIKdOtyRCoPv7dQX7Ug2Jw70iBlCaPQzGlg2FwFPdRWx2FqnbI2UQ7ANNDdT948JwdxOm6Z11ePwq67KiMB3ch71qPqMMxRILbDrzAvRS/VmSrczzxHgqpBUPBz0fZ4NWsVwfUWtsRAItd20UbJel1CB+NABQlWqCSh/ygbK5Ar+gcsxDBVyKqIgqZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xr9/se05Dia+TZu3JXE+OY8rtBbSU1/VV2K41EnpdK0=; b=X05EvS0qxgDDOBQoE4cdq29yZ6AukXl3b42Z8ThEuH5dTzo1jJJldJsKZ4/BLsFL67KEE0eep9FgdHYbHO3wpCvmD3evbpyj/OLQT6LhvwlQd97mdHp+rieqMcUKd07fYlDqdKW6RcTcKzbxgSGlx4GUZcdFK8PB8MZnd7uNyon+UZiQclySr8X85PVtb6K7W6stCs4ah9CbY6Ez44DWJTHXbFGQU7dOW7hEMdxk0F/wZMxCAEk06GOvGNRs0uSgRtAQ97Mn/rSu9zABvmgOfdlcLhzxGFtxT+sn2+AurHZWiZqHe+qgqOU+0llaGFFL/R09cWmaQO5yQIVB0N/Tgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=studenti.unirc.it; dmarc=pass action=none header.from=studenti.unirc.it; dkim=pass header.d=studenti.unirc.it; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=studentiunirc.onmicrosoft.com; s=selector2-studentiunirc-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xr9/se05Dia+TZu3JXE+OY8rtBbSU1/VV2K41EnpdK0=; b=bKBsxBGJkxlpYeUZltSYXApyOBQWeeDg11CpQUmqr82mBj6pMla1IoqdyeLKdyna5DORTNxiCMeiPkKkk6NYfm1N4+/l3m+OkNIpxuWT0ZqdLlGzU5Rl6Pz6ST8PcRrtBmBQCNxL7hC0uKD4m22966QbVua94KJhytgRHvQj1PY= From: Enza Cannizzo To: "xen-devel@lists.xenproject.org" Subject: info Thread-Topic: info Thread-Index: AQHXIoAqtleliyZb+EKQ53q+Ka7KYg== Date: Fri, 26 Mar 2021 20:42:20 +0000 Message-ID: Accept-Language: it-IT, en-US Content-Language: it-IT X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=studenti.unirc.it; x-originating-ip: [93.147.237.9] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: be10a498-8f47-462d-af1b-08d8f097a75b x-ms-traffictypediagnostic: AM0PR05MB4194: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9LqH/Qck78l+tHBqoybHr7qjhGBmq+pqdXqvKTkunWvWSG52V2pa3tlC/LOWcZLUPpSrX7PVI+8AKt9K6WpaYqBBr6pQW9QM1gnQiH2Ipn/f9rh4q9BAaSm0e5iv2/KMWpknUO61r6pRMdgONFjUr+VvtpzxBv3FJ4EM7fg5yI/m53dtJZYgTSmFbDfdmVj152KY01/Y+hNujQbbuIm6UbKcWQQxhIcD5dbGUrP+mlbb5LTYMk9DYpJm05VNceEUZ89aqQOcreU0gyaAcEsUh6q0IVpqQ4N5Z9jI/xp2oyalP63ITMjz/Dr1iBPWDbrTnwImt9VOZXzKF0w//eilpISbHPMUsOgX3JdDduiMJVzOd8oxbenigA71uBny9tbAz3jLIWOw/w9XBNCh5Uiu9Bauooamh9oEtJPtBi2tU0cL4481ACew2mTGVkGDOIkos+cRUa4cqc1m0ZDL3pmnVPpnjex5Zt9sKqV1gUxfzJX0rmyRWRsKUpOHRW47Pjap2njmEih5M7csI/yFVs3lrvBI19cSsyY9LA2gx9snzpMbGMEELc6H+6ev8YGdq6fTZuIaCR45J/XXa64Jt9EKLpFtBqv+b9kCB/JeGXD5h4j2J414ghhwiPPq4sRSHplKP1ETADlleZcsIOAzeZVXlPGePIaKK2cqMOmbCueE4rTWaxCZX96TUu7A5fseEJXD x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM4PR05MB3331.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(39830400003)(396003)(136003)(366004)(376002)(346002)(4744005)(76116006)(478600001)(186003)(64756008)(91956017)(66946007)(9686003)(66446008)(66556008)(71200400001)(66476007)(55016002)(86362001)(7116003)(3480700007)(52536014)(6916009)(6506007)(38100700001)(19627405001)(316002)(2906002)(786003)(8676002)(7696005)(26005)(8936002)(33656002)(5660300002)(220243001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?qtqyrWqNNy3Bp+6xHvayo2RtvuHGLuM0BX9D8IcCNVHCYr5LE1gF8+3qYR?= =?iso-8859-1?Q?Bkmxg6DG+9pcMwvRQadZRd4F0jQPlN+PUTnJUbfcy0M5ugT+pU3y5E2tRi?= =?iso-8859-1?Q?jhcVO1+MJ5uTzJQChuim2Pm/eT6OsqPpE3ibo/+hj+pPKXUUcupsUpuHiz?= =?iso-8859-1?Q?Y7ClXDS2J9Q2PF50SaSGJBbedNBeWpW69CjotqrEwKfMws3iiKAUw1R3CA?= =?iso-8859-1?Q?UzUUafoN17a8BP4+28szhshw2LP7+gvV3pfT/4SP+LpfQ7YWCcqj6xD8mq?= =?iso-8859-1?Q?SctW2LhLQXjpWDho9o6W27JAUT2eqDz8MKk20vutnuVdcKnQqegGLx9HgO?= =?iso-8859-1?Q?noIi5ycs+y7AH6dyuY2WPomgCMC4Rr1NNwPRFQz8yvOJq5CE86T5b7XsG1?= =?iso-8859-1?Q?uJ2YMl+gTBfM8nIhxIR4TSgJyTnQ+rqa41LB1DVezAS+XTaNLI/qmQ3U01?= =?iso-8859-1?Q?bjyeNEG4jfAgEebsgikFrMgU64dviu3jPZ19CsBj/KIJwWlEYe3wndulmr?= =?iso-8859-1?Q?OQr2rbWkIOtP5jPIOmFae041jwR+qeJ3ns4Hr28FY8O/0T6D1dS6C+Ygsl?= =?iso-8859-1?Q?b9O7rBzio/HFrcBw4kooalYWUkJIFbtU5szEkeszmyNOEVBHBt0GGzioup?= =?iso-8859-1?Q?fokgAdT6RLCPvq/ClU5QCpU/k9vas2/nB104JvY/VS/LEHy22DuGXTfelM?= =?iso-8859-1?Q?mWSZ+dwEPc18Lgj3b/uiRXWJ+DkBzmwsLET3av3/jA4xwCB3tOzeQCrquv?= =?iso-8859-1?Q?VyU090tWw0JNKZC94s9R0plImE/HgSirg/75uYGPCpxzEnuDyICPGM+z67?= =?iso-8859-1?Q?jtWfRC6gVRIDDY1i4IXQ5e18kRIThjXcRtBob5rcwgnpT2Uz1hIMHf2X4V?= =?iso-8859-1?Q?Rr0qv2VvdZMRTqjirFcuzG4btHNokko3fhyLYwNi8sVUo7T00K4oGHor9N?= =?iso-8859-1?Q?qMq5pqZFPJxLGkCNtDCP4V9DI25+iQwDzMlqyKFBp/iOy6jVKd1kh6RebY?= =?iso-8859-1?Q?mqyWlIbg8lmdhhUYErjQ9DVTjs6WNk9AphwWakCQrRyYpj3rgZM73mJm1B?= =?iso-8859-1?Q?f4px+QKDtF9kksolurldM4Fp2wucyEaFOqJ1YD6h8bPDBIUXaS3kvDsodH?= =?iso-8859-1?Q?Bx4NzVAxKsM1TRGWxAfRmL+LGdGSN5X0+F4Y59oO9ktOLatupaXfzj+hNb?= =?iso-8859-1?Q?ielrQzEWv+otUeLCWCyQWHFsOgQ1ebzMhlvDaLAy3A2tVdyaIyBaVDp5H4?= =?iso-8859-1?Q?eXlZzVdu3VmaSTaXRSWd1mj3VcDkCGocpNmmSpnZpUaaqlXqyKB8BANQPr?= =?iso-8859-1?Q?jlPB8r1+tqjA4EcW4FVs3KJTjMcLb7xbnS6DtBP5c7KLoFg=3D?= x-ms-exchange-transport-forked: True Content-Type: multipart/alternative; boundary="_000_AM4PR05MB33312D885F3CEA0B4DD82DB3AC619AM4PR05MB3331eurp_" MIME-Version: 1.0 X-OriginatorOrg: studenti.unirc.it X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM4PR05MB3331.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be10a498-8f47-462d-af1b-08d8f097a75b X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2021 20:42:20.9787 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 81907402-e440-42c1-8197-5e0d0609e005 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q1ZEpVCzX87bMpgIsBq//DgV5pyZGAfBEE6wgyes7PuxvbjkFbzqgA1MCu1TfyritSTh13ZUP3Hj2EsP0UEsFcJpmMyiX4mJzguHmwFXMhI0eaF5Hs05+Qtnd6p7+SJA X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4194 --_000_AM4PR05MB33312D885F3CEA0B4DD82DB3AC619AM4PR05MB3331eurp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi, I'm using xen project v 4.13.0 and I have to cross compile it for arm 6= 4. I tried the complete compiling process with success but when I try to cr= oss compile it returns errors in the tools compiling process. I also tried to cross compile only the hypervisor and it's ok: > ./configure > make dist-xen XEN_TARGET_ARCH=3Darm64 CROSS_COMPILE=3D /path/ but with make dist XEN_TARGET_ARCH=3Darm64 CROSS_COMPILE=3D /path/ it returns errors related to libraries in tools module. So I would like to = ask if there is something I just do wrong or it's not possible to cross com= pile the whole xen project. I'm sorry I'm at the beginning with xen cross c= ompile. Thank you anyway. --_000_AM4PR05MB33312D885F3CEA0B4DD82DB3AC619AM4PR05MB3331eurp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
Hi, I'm using xen project v 4.13.0 and I have to cross = compile it for arm 64. I tried the complete compiling process with success = but when I try to cross compile it returns errors in the tools compiling process.
I also tried to cross compile only the hypervisor and it's ok:
> ./configure
> make dist-xen XEN_TARGET_ARCH=3Darm64 CROSS_COMPILE=3D /path/

but with make dist XEN_TARGET_ARCH=3Darm64 CROSS_COMPILE=3D /path/
it returns errors related to libraries in tools module. So I would like to = ask if there is something I just do wrong or it's not possible to cross com= pile the whole xen project. I'm sorry I'm at the beginning with xen cross c= ompile.
Thank you anyway.
--_000_AM4PR05MB33312D885F3CEA0B4DD82DB3AC619AM4PR05MB3331eurp_-- From xen-devel-bounces@lists.xenproject.org Sat Mar 27 05:56:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 27 Mar 2021 05:56:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102012.195711 (Exim 4.92) (envelope-from ) id 1lQ1vO-0002zs-9S; Sat, 27 Mar 2021 05:55:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102012.195711; Sat, 27 Mar 2021 05:55:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ1vO-0002zl-6U; Sat, 27 Mar 2021 05:55:54 +0000 Received: by outflank-mailman (input) for mailman id 102012; Fri, 26 Mar 2021 18:14:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lPqyz-0001PT-DB for xen-devel@lists.xenproject.org; Fri, 26 Mar 2021 18:14:53 +0000 Received: from mail-ed1-x530.google.com (unknown [2a00:1450:4864:20::530]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 79f21421-deeb-4e81-8d58-2bdcee3a6bad; Fri, 26 Mar 2021 18:14:52 +0000 (UTC) Received: by mail-ed1-x530.google.com with SMTP id z1so7334178edb.8 for ; Fri, 26 Mar 2021 11:14:52 -0700 (PDT) Received: from LEGION ([111.119.187.49]) by smtp.gmail.com with ESMTPSA id gj26sm4087570ejb.67.2021.03.26.11.14.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 11:14:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79f21421-deeb-4e81-8d58-2bdcee3a6bad DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=7OwN9sCDoll1kfeOV96JvARjVXcCMVl5pE1420CYpOw=; b=grFMxIfnyiOWnB9RplEKcznwJgBk59Dlw9m/Qd10lgjvSNTNyzIknJNEsP1Iwd8yNr HRPlwIIiJtJjlO56hyU+aj25+jJzjSuEL6e8XvtMnonsZO+DF3p2//gSHa0AgfmAKhSK lUvmNgqIUyOGCWYRIocMdwhD4n8gQlW56XzgqdVjVKtK362IkPsTOi6dKFyDylOD1njO FWZFFFKwXsoV+F6LURvZ9bXSfQhbbFRI3ivclSqPkze8Gu3nrm0G29dikRKZoDblCDNH mmcPUn1iQxeZmfWhELA4i+As9kT/iYgE+Dlk3135pa+uE/d6S+bfjxf9Ej1F62aWDSBg Swlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=7OwN9sCDoll1kfeOV96JvARjVXcCMVl5pE1420CYpOw=; b=MxaArpvejsu8wIYFNdEFWBFy0EWDzUrQBFbck1ojQpovy8vNTXLAg25gC6bhcbqo3D k+ITrmvwRuUqNEbWAfvg5p9a9uyUHL1WKzGtcu8j70XoKHTSuPJuCUlGw4fu9kvnpLnG t5dfqhae49iriMb6X6bLRi2z/Bu5tqcpJj0kc7r0LFCKrLoXGupeo2SQKcA00nTYKFx1 x/nFmBnCZbu50tjpTdWgjHFeorru+e6M5q883BgYmYKA13jUkWJD6U5MFXXs5VDfO6pR /wBL4O9Kxd+QFTswDslk+vXEIp0nZaX7wY+GPywHMIiJyGcvdGwTIMhBqQCz4EipGhHV wnbw== X-Gm-Message-State: AOAM5325Im8eZhjgKm8xvr3lX7QO+wKAtTNVmcJjMJIPS1+lccYrmzDB /467q7AFe/dKTLNIRu5M8xo= X-Google-Smtp-Source: ABdhPJxuA8CArC7vp83Y/bQZyxiB/zWeAqtySapkwLOjb+muwylYkJwlFNtddIpQu548xwd6Df9rEw== X-Received: by 2002:a05:6402:1545:: with SMTP id p5mr16503433edx.155.1616782491559; Fri, 26 Mar 2021 11:14:51 -0700 (PDT) Date: Fri, 26 Mar 2021 23:14:42 +0500 From: Muhammad Usama Anjum To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "moderated list:XEN HYPERVISOR INTERFACE" , open list , kernel-janitors@vger.kernel.org, colin.king@canonical.com, dan.carpenter@oracle.com Cc: musamaanjum@gmail.com Subject: [PATCH] xen/pciback: Fix incorrect type warnings Message-ID: <20210326181442.GA1735905@LEGION> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Correct enum pci_channel_io_normal should be used instead of putting integer value 1. Fix following smatch warnings: drivers/xen/xen-pciback/pci_stub.c:805:40: warning: incorrect type in argument 2 (different base types) drivers/xen/xen-pciback/pci_stub.c:805:40: expected restricted pci_channel_state_t [usertype] state drivers/xen/xen-pciback/pci_stub.c:805:40: got int drivers/xen/xen-pciback/pci_stub.c:862:40: warning: incorrect type in argument 2 (different base types) drivers/xen/xen-pciback/pci_stub.c:862:40: expected restricted pci_channel_state_t [usertype] state drivers/xen/xen-pciback/pci_stub.c:862:40: got int drivers/xen/xen-pciback/pci_stub.c:973:31: warning: incorrect type in argument 2 (different base types) drivers/xen/xen-pciback/pci_stub.c:973:31: expected restricted pci_channel_state_t [usertype] state drivers/xen/xen-pciback/pci_stub.c:973:31: got int Signed-off-by: Muhammad Usama Anjum --- drivers/xen/xen-pciback/pci_stub.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c index cb904ac83006..f8e4faa96ad6 100644 --- a/drivers/xen/xen-pciback/pci_stub.c +++ b/drivers/xen/xen-pciback/pci_stub.c @@ -802,7 +802,7 @@ static pci_ers_result_t xen_pcibk_slot_reset(struct pci_dev *dev) "guest with no AER driver should have been killed\n"); goto end; } - result = common_process(psdev, 1, XEN_PCI_OP_aer_slotreset, result); + result = common_process(psdev, pci_channel_io_normal, XEN_PCI_OP_aer_slotreset, result); if (result == PCI_ERS_RESULT_NONE || result == PCI_ERS_RESULT_DISCONNECT) { @@ -859,7 +859,7 @@ static pci_ers_result_t xen_pcibk_mmio_enabled(struct pci_dev *dev) "guest with no AER driver should have been killed\n"); goto end; } - result = common_process(psdev, 1, XEN_PCI_OP_aer_mmio, result); + result = common_process(psdev, pci_channel_io_normal, XEN_PCI_OP_aer_mmio, result); if (result == PCI_ERS_RESULT_NONE || result == PCI_ERS_RESULT_DISCONNECT) { @@ -970,7 +970,7 @@ static void xen_pcibk_error_resume(struct pci_dev *dev) kill_domain_by_device(psdev); goto end; } - common_process(psdev, 1, XEN_PCI_OP_aer_resume, + common_process(psdev, pci_channel_io_normal, XEN_PCI_OP_aer_resume, PCI_ERS_RESULT_RECOVERED); end: if (psdev) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Mar 27 10:34:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 27 Mar 2021 10:34:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102196.195758 (Exim 4.92) (envelope-from ) id 1lQ6GU-0001MD-RW; Sat, 27 Mar 2021 10:33:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102196.195758; Sat, 27 Mar 2021 10:33:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ6GU-0001M6-NZ; Sat, 27 Mar 2021 10:33:58 +0000 Received: by outflank-mailman (input) for mailman id 102196; Sat, 27 Mar 2021 10:33:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ6GT-0001Ly-1D; Sat, 27 Mar 2021 10:33:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ6GS-0007O6-Op; Sat, 27 Mar 2021 10:33:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ6GS-0002Jx-DW; Sat, 27 Mar 2021 10:33:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQ6GS-00044y-Cz; Sat, 27 Mar 2021 10:33:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0hbqci4VtEnZqhXNAZng+GHFmFehs851lO1wPDhnoGY=; b=KgHk+qIujdjf5kJAsVnB0d8qDT ptNZT8qHEMdhDBkk5LsMsa1x+dQgacahsJ7bu2nyn2WFLmjWwQAZkkPXS3Wpw2o/goeWtOMlyMRk5 tTyIjesaNuKm1dKlDzmVuZXF2lwbHMvETARq4vBgvOQK/6woteKM8YrDk5Uk/JHS1mqU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160436: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-vhd:guest-saverestore.2:fail:heisenbug xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4ca6217bef99128027a9b64c055e4967a5dabd0c X-Osstest-Versions-That: xen=64d07691755e9aa6d3453ef3bb9109fde2b8da1e From: osstest service owner Date: Sat, 27 Mar 2021 10:33:56 +0000 flight 160436 xen-unstable real [real] flight 160469 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160436/ http://logs.test-lab.xenproject.org/osstest/logs/160469/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 17 guest-saverestore.2 fail pass in 160469-retest test-amd64-amd64-examine 4 memdisk-try-append fail pass in 160469-retest test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160469-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160404 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160404 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160404 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160404 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160404 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160404 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160404 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160404 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160404 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160404 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160404 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 4ca6217bef99128027a9b64c055e4967a5dabd0c baseline version: xen 64d07691755e9aa6d3453ef3bb9109fde2b8da1e Last test of basis 160404 2021-03-25 03:54:53 Z 2 days Testing same since 160436 2021-03-26 06:23:07 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 64d0769175..4ca6217bef 4ca6217bef99128027a9b64c055e4967a5dabd0c -> master From xen-devel-bounces@lists.xenproject.org Sat Mar 27 12:08:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 27 Mar 2021 12:08:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102216.195779 (Exim 4.92) (envelope-from ) id 1lQ7j7-0003AQ-3L; Sat, 27 Mar 2021 12:07:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102216.195779; Sat, 27 Mar 2021 12:07:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ7j6-0003AJ-W2; Sat, 27 Mar 2021 12:07:36 +0000 Received: by outflank-mailman (input) for mailman id 102216; Sat, 27 Mar 2021 12:07:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ7j5-0003AB-QA; Sat, 27 Mar 2021 12:07:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ7j5-0000SI-JI; Sat, 27 Mar 2021 12:07:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ7j5-0004xe-8K; Sat, 27 Mar 2021 12:07:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQ7j5-00026B-7n; Sat, 27 Mar 2021 12:07:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tkrZRpGkNkUmbGhrXpd9r0cdVBTEYb+H+7LewySQOCE=; b=ykb4mYJqbR9yFSciFJfvImnr9r yZR1wIPqbOskpDnFGBi0G04aIaY3G4YIllGZ1tGYODbsKNUVcL897mzQafSEAM7PFcwaEkcGqZ5jE bUO0xXR9MtV2PGwg09BfGMfhpyq/CxIgnLD90Lyq+6cp1nv9ARd6vTsjlgbFbnxmL9jU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160443: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=db24726bfefa68c606947a86132591568a06bfb4 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sat, 27 Mar 2021 12:07:35 +0000 flight 160443 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160443/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux db24726bfefa68c606947a86132591568a06bfb4 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 238 days Failing since 152366 2020-08-01 20:49:34 Z 237 days 406 attempts Testing same since 160443 2021-03-26 11:53:29 Z 1 days 1 attempts ------------------------------------------------------------ 5263 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1307480 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 27 13:37:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 27 Mar 2021 13:37:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102229.195799 (Exim 4.92) (envelope-from ) id 1lQ97U-0004tt-NI; Sat, 27 Mar 2021 13:36:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102229.195799; Sat, 27 Mar 2021 13:36:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ97U-0004tm-KL; Sat, 27 Mar 2021 13:36:52 +0000 Received: by outflank-mailman (input) for mailman id 102229; Sat, 27 Mar 2021 13:36:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ97S-0004td-Hm; Sat, 27 Mar 2021 13:36:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ97S-0001rL-80; Sat, 27 Mar 2021 13:36:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQ97R-0001hU-Ut; Sat, 27 Mar 2021 13:36:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQ97R-00081K-UQ; Sat, 27 Mar 2021 13:36:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TaYgwakk8w1XZkkyeAiwUXVMCsta4tOg43QO7bmTTYQ=; b=kisbC6JtAX8rtgQBmGXEUitS+T +dXTsuaSioj/CtNtgm2xntAkuTUNN6PU/KgOJqVv9B8zc02LfL/OspUjM3PbqemclqJGJbUnNSyt+ DdkIVImpGoIldKhh2nKDC4Eald8zqGdLClNRlex+dVNcf0NDBRkg94WVvWOfIs98w0No=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160464: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=bb966c28e72db650246e28a18038fc4240c59bac X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 27 Mar 2021 13:36:49 +0000 flight 160464 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160464/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt bb966c28e72db650246e28a18038fc4240c59bac baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 260 days Failing since 151818 2020-07-11 04:18:52 Z 259 days 252 attempts Testing same since 160464 2021-03-27 04:18:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 49159 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 27 15:40:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 27 Mar 2021 15:40:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102253.195826 (Exim 4.92) (envelope-from ) id 1lQB2K-0002Bv-56; Sat, 27 Mar 2021 15:39:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102253.195826; Sat, 27 Mar 2021 15:39:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQB2K-0002Bo-1j; Sat, 27 Mar 2021 15:39:40 +0000 Received: by outflank-mailman (input) for mailman id 102253; Sat, 27 Mar 2021 15:39:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQB2I-0002Bg-G4; Sat, 27 Mar 2021 15:39:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQB2I-0003ur-8r; Sat, 27 Mar 2021 15:39:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQB2H-0007vP-Ts; Sat, 27 Mar 2021 15:39:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQB2H-0003xf-TP; Sat, 27 Mar 2021 15:39:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CMlzGgAQiDbyyWvAwuCmiJX6+aj56lcSSnAh54t9fs4=; b=0L7x3veyNVaYldy9VwMHWiJ8bI NFYN86zN3jfsGZjNk/XOQrJC579HjeyVKEfXnzkC/fb7iuK1HlOukxcAgNid6eMi0AoE83nM1OgKG xoihqLSSZ0Og6LvKS6At1CnDFnHqqUo1Dx3y6C5tieGzZRrY10O+j7vREkIgoH/DMD5I=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160448: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=63ad23fa240bb7cdbf6d0440c5670cc7935032b0 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sat, 27 Mar 2021 15:39:37 +0000 flight 160448 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160448/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 63ad23fa240bb7cdbf6d0440c5670cc7935032b0 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 219 days Failing since 152659 2020-08-21 14:07:39 Z 218 days 414 attempts Testing same since 160448 2021-03-26 15:25:09 Z 1 days 1 attempts ------------------------------------------------------------ 466 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 138104 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Mar 27 19:50:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 27 Mar 2021 19:50:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102278.195853 (Exim 4.92) (envelope-from ) id 1lQEwt-0005vh-Du; Sat, 27 Mar 2021 19:50:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102278.195853; Sat, 27 Mar 2021 19:50:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQEwt-0005va-As; Sat, 27 Mar 2021 19:50:19 +0000 Received: by outflank-mailman (input) for mailman id 102278; Sat, 27 Mar 2021 19:50:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQEwr-0005vS-RH; Sat, 27 Mar 2021 19:50:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQEwr-0000CY-NJ; Sat, 27 Mar 2021 19:50:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQEwr-0004k5-By; Sat, 27 Mar 2021 19:50:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQEwr-0004cU-BW; Sat, 27 Mar 2021 19:50:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mk+HFt76kt32O3KQPxwy5gu33pidnTiHFuOcKbRHcKY=; b=u5eysJ8gOmVrCHFeXlWA2lu4yb TaUGN7hDj/piB6NSDjV93GJbpkPP3g3sO+vmv2hviFYgwopUvAShfqrIHkDL5nPLH9ZUO8cjeWxbq A1LZJ7KdfrTKBmFesDmpgC8NygwnNKVfPpjJL9Ht5pQfrBfMJWhl40IOfbyd4ek3E+3I=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160456: all pass - PUSHED X-Osstest-Versions-This: ovmf=b33cf5bfcb4c941370739dfbbe1532ff508fd29d X-Osstest-Versions-That: ovmf=4bf2a5b045ebf8b5e90d9210ad5190699bddb592 From: osstest service owner Date: Sat, 27 Mar 2021 19:50:17 +0000 flight 160456 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160456/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b33cf5bfcb4c941370739dfbbe1532ff508fd29d baseline version: ovmf 4bf2a5b045ebf8b5e90d9210ad5190699bddb592 Last test of basis 160425 2021-03-25 20:38:30 Z 1 days Testing same since 160456 2021-03-26 20:57:11 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 4bf2a5b045..b33cf5bfcb b33cf5bfcb4c941370739dfbbe1532ff508fd29d -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Mar 27 21:06:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 27 Mar 2021 21:06:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102288.195875 (Exim 4.92) (envelope-from ) id 1lQG8c-0005UH-7Q; Sat, 27 Mar 2021 21:06:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102288.195875; Sat, 27 Mar 2021 21:06:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQG8c-0005U7-37; Sat, 27 Mar 2021 21:06:30 +0000 Received: by outflank-mailman (input) for mailman id 102288; Sat, 27 Mar 2021 21:06:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQG8a-0005Tz-MU; Sat, 27 Mar 2021 21:06:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQG8a-0001WY-EK; Sat, 27 Mar 2021 21:06:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQG8a-0008E6-3z; Sat, 27 Mar 2021 21:06:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQG8a-0002Rr-3U; Sat, 27 Mar 2021 21:06:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=J4YqreKnsBTiDnx4zfd7eaMUl3Dbt9dirVBMNBISW6o=; b=eHMQc9Q7so/qXAKM4JK1BMPs3W 3/42TggftvHrCyPXq5vDyloAyjpUvLV9gyKYW884Uwo0icLLple4NH5I1cHblQOPcGDmfeCO/gn6E 49tSIJ8iNA0RXPNGdi2y6XE/YEc/SofhDjpBy/BmFgU1TPQyN4/YYr3UQloTusiiilA4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 160455: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=7fa14f3f525b4a2d660794424fd787cfdf9c904b X-Osstest-Versions-That: xen=0f93d79a97121c55d3f3e26304d437ddb38de6a7 From: osstest service owner Date: Sat, 27 Mar 2021 21:06:28 +0000 flight 160455 xen-4.15-testing real [real] flight 160480 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160455/ http://logs.test-lab.xenproject.org/osstest/logs/160480/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160480-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160422 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160422 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160422 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160422 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160422 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160422 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160422 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160422 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160422 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160422 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160422 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 7fa14f3f525b4a2d660794424fd787cfdf9c904b baseline version: xen 0f93d79a97121c55d3f3e26304d437ddb38de6a7 Last test of basis 160422 2021-03-25 20:07:38 Z 2 days Testing same since 160455 2021-03-26 20:09:16 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Ian Jackson Jan Beulich Julien Grall Roger Pau Monné Tamas K Lengyel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 0f93d79a97..7fa14f3f52 7fa14f3f525b4a2d660794424fd787cfdf9c904b -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Sun Mar 28 02:23:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 28 Mar 2021 02:23:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102314.195938 (Exim 4.92) (envelope-from ) id 1lQL4q-0001vV-P4; Sun, 28 Mar 2021 02:22:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102314.195938; Sun, 28 Mar 2021 02:22:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQL4q-0001vM-JJ; Sun, 28 Mar 2021 02:22:56 +0000 Received: by outflank-mailman (input) for mailman id 102314; Sun, 28 Mar 2021 02:22:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQL4p-0001vE-00; Sun, 28 Mar 2021 02:22:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQL4o-0000nF-L0; Sun, 28 Mar 2021 02:22:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQL4o-00088a-B2; Sun, 28 Mar 2021 02:22:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQL4o-0007zZ-AU; Sun, 28 Mar 2021 02:22:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=f+aCVwYzQLSvD3MhP+7GALjTEH7O0gXIatNVonHcbuc=; b=ANhosRZeWNLOzFgObY0jWuf5xP w1mN0fvZoDmt2yvVSNFsqIsXS6FuNm37VG6tTfepOJLbPR+Da86IbsLlbvlJDOW7IRMcpEGs5eHPF H6COVsd/nyctN0wIUEmx7AWxZJODzS7xwicqoMtEn/LHzf6cyeO5vnMFS4VKyvgO7WpE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160465: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Sun, 28 Mar 2021 02:22:54 +0000 flight 160465 xen-4.12-testing real [real] flight 160485 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160465/ http://logs.test-lab.xenproject.org/osstest/logs/160485/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail REGR. vs. 159418 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 39 days Failing since 160128 2021-03-18 14:36:18 Z 9 days 9 attempts Testing same since 160150 2021-03-20 04:11:48 Z 7 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 28 06:35:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 28 Mar 2021 06:35:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102338.196003 (Exim 4.92) (envelope-from ) id 1lQP13-0008Qw-9t; Sun, 28 Mar 2021 06:35:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102338.196003; Sun, 28 Mar 2021 06:35:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQP13-0008Qp-6r; Sun, 28 Mar 2021 06:35:17 +0000 Received: by outflank-mailman (input) for mailman id 102338; Sun, 28 Mar 2021 06:35:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQP11-0008Qh-Mr; Sun, 28 Mar 2021 06:35:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQP11-0000FF-Gr; Sun, 28 Mar 2021 06:35:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQP11-0003zI-8s; Sun, 28 Mar 2021 06:35:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQP11-0002SX-8D; Sun, 28 Mar 2021 06:35:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5sJ9t/3Qt90VpB/j7M8MgEioKq08KArGgUPtQJ42YoI=; b=WOTWMks+MYR3b2YjI+a6dHvYwa 0TYdlLcpjOGJxo3oMcNeEya/mUvKCQrKWJRcxlIeCfaOIcUZfkV+ON8fpwzaTN9FWGCB+cJ+Cs2U1 s+X6Eq736Kp4sDTQonVW8+R/Ha5VWx5reTNdtzsyS+aQ9je+LFEvDUoTKWHx40tr/1R4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160471: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e680cc48b7184d3489873d6776f84ba1fc238ced X-Osstest-Versions-That: xen=4ca6217bef99128027a9b64c055e4967a5dabd0c From: osstest service owner Date: Sun, 28 Mar 2021 06:35:15 +0000 flight 160471 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160471/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160436 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160436 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160436 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160436 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160436 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160436 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160436 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160436 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160436 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160436 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160436 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen e680cc48b7184d3489873d6776f84ba1fc238ced baseline version: xen 4ca6217bef99128027a9b64c055e4967a5dabd0c Last test of basis 160436 2021-03-26 06:23:07 Z 2 days Testing same since 160471 2021-03-27 10:36:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Ian Jackson Jan Beulich Julien Grall Roger Pau Monné Tamas K Lengyel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4ca6217bef..e680cc48b7 e680cc48b7184d3489873d6776f84ba1fc238ced -> master From xen-devel-bounces@lists.xenproject.org Sun Mar 28 08:41:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 28 Mar 2021 08:41:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102354.196024 (Exim 4.92) (envelope-from ) id 1lQQyJ-0006En-O6; Sun, 28 Mar 2021 08:40:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102354.196024; Sun, 28 Mar 2021 08:40:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQQyJ-0006Ee-HE; Sun, 28 Mar 2021 08:40:35 +0000 Received: by outflank-mailman (input) for mailman id 102354; Sun, 28 Mar 2021 08:40:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQQyJ-0006EW-0w; Sun, 28 Mar 2021 08:40:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQQyI-0002nz-L5; Sun, 28 Mar 2021 08:40:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQQyI-0007oT-DC; Sun, 28 Mar 2021 08:40:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQQyI-0008FN-Cj; Sun, 28 Mar 2021 08:40:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=UaQSi4+Ka98vN2jR0HTmVdMLHJOoQwlUnabs1qeYMgM=; b=cVr0q4Akm2DTg25egd+DdNjmEy ciGqmHG6mxKs98wmJgqHr/UgKzHq/AX08ezAAGnWDqDr/N+fiQwus45mj9BU66k0b2o9IP62utZk1 HsWFWvzq0rXB9wksliyXFLio9hJ15W2HWalYh+fhCFTZqdpFsi1MPp8AedaAzD06LKOo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Subject: [qemu-mainline bisection] complete test-amd64-amd64-libvirt-xsm Message-Id: From: osstest service owner Date: Sun, 28 Mar 2021 08:40:34 +0000 branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-libvirt-xsm testid guest-start Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8d17adf34f501ded65a106572740760f0a75577c Bug not present: e67d8e2928200e24ecb47c7be3ea8270077f2996 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160493/ commit 8d17adf34f501ded65a106572740760f0a75577c Author: Daniel P. Berrangé Date: Mon Feb 22 11:16:32 2021 +0000 block: remove support for using "file" driver with block/char devices The 'host_device' and 'host_cdrom' drivers must be used instead. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/test-amd64-amd64-libvirt-xsm.guest-start.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/test-amd64-amd64-libvirt-xsm.guest-start --summary-out=tmp/160493.bisection-summary --basis-template=152631 --blessings=real,real-bisect,real-retry qemu-mainline test-amd64-amd64-libvirt-xsm guest-start Searching for failure / basis pass: 160448 fail [host=chardonnay0] / 160125 [host=fiano0] 160119 [host=albana0] 160113 [host=chardonnay1] 160104 [host=albana1] 160097 [host=godello0] 160091 [host=fiano1] 160082 [host=pinot1] 160079 [host=huxelrebe1] 160070 [host=elbling0] 160066 [host=godello0] 160002 [host=fiano0] 159947 [host=godello1] 159926 [host=albana1] 159911 [host=huxelrebe1] 159898 ok. Failure / basis pass flights: 160448 / 159898 (tree with no url: minios) Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f037af6ecbc3b55042c998a59ed8df8548e64b99 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 63ad23fa240bb7cdbf6d0440c5670cc7935032b0 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 64d07691755e9aa6d3453ef3bb9109fde2b8da1e Basis pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b2ae1009d7cca2701e17eae55ae2d44fd22c942a ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e 60c0444fae2148452f9ed0b7c49af1fa41f8f522 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/libvirt.git#2c846fa6bcc11929c9fb857a22430fb9945654ad-2c846fa6bcc11929c9fb857a22430fb9945654ad https://gitlab.com/keycodemap/keycodemapdb.git#27acf0ef828bf719b2053ba398b195829413dbdd-27acf0ef828bf719b2053ba398b195829413dbdd git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0\ dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507-f037af6ecbc3b55042c998a59ed8df8548e64b99 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#b2ae1009d7cca2701e17eae55ae2d44fd22c942a-63ad23fa240bb7cdbf6d0440c5670cc7935032b0 git://xenbits.xen.org/osstest/seabios.git#ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e-b0d61ec\ ef66eb05bd7a4eb7ada88ec5dab06dfee git://xenbits.xen.org/xen.git#60c0444fae2148452f9ed0b7c49af1fa41f8f522-64d07691755e9aa6d3453ef3bb9109fde2b8da1e Loaded 30449 nodes in revision graph Searching for test results: 159898 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b2ae1009d7cca2701e17eae55ae2d44fd22c942a ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e 60c0444fae2148452f9ed0b7c49af1fa41f8f522 159911 [host=huxelrebe1] 159926 [host=albana1] 159947 [host=godello1] 160002 [host=fiano0] 160048 [] 160050 [] 160057 [] 160062 [] 160064 [] 160066 [host=godello0] 160070 [host=elbling0] 160079 [host=huxelrebe1] 160082 [host=pinot1] 160088 [] 160091 [host=fiano1] 160097 [host=godello0] 160104 [host=albana1] 160113 [host=chardonnay1] 160119 [host=albana0] 160125 [host=fiano0] 160134 fail irrelevant 160147 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2e1293cbaac75e84f541f9acfa8e26749f4c3562 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160167 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ca318882714080fb81fe9eb89a7b7934efc5bfae 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 bdee969c0e65d4d509932b1d70e3a3b2ffbff6d5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160328 fail irrelevant 160361 fail irrelevant 160392 fail irrelevant 160442 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b2ae1009d7cca2701e17eae55ae2d44fd22c942a ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e 60c0444fae2148452f9ed0b7c49af1fa41f8f522 160444 fail irrelevant 160446 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 f2a9a6c2a86570ccbf8c5c30cbb8bf723168c459 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160418 fail irrelevant 160447 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8a40754bca14df63c6d2ffe473b68a270dc50679 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160450 fail irrelevant 160451 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7286d62d4e259be8cecf3dc2deea80ecc14489a5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160452 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 69259911f948ad2755bd1f2c999dd60ac322c890 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160453 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6e71c36557ed41017e634ae392fa80f03ced7fa1 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160457 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2255564fd21059960966b47212def9069cb56077 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160458 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 2e51b27fed31eb7b2a2cb4245806c8c7859207f7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 0693602a23276b076a679b1e7ed9125a444336b6 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160459 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8b858f9998a9d59a9a7188f2c5c6ffb99eff6115 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160460 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 30ca7eddc486646fa19c9619fcf233ceaa65e28c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160461 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2615a5e433aeb812c300d3a48e1a88e1303e2339 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160462 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 51204c2f188ec1e2a38f14718d38a3772f850a4b b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160466 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 773b0bc2838ede154c6de9d78401b91fafa91062 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 5e8892db93f3fb6a7221f2d47f3c952a7e489737 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160467 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8e6bc6cdc82d45f203bc9fc4342c0452214c74fe b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 14b95b3b8546db201e7efd0636ae0e215fae98f3 160468 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 757acb9a8295e8be4a37b2cfc1cd947e357fd29c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 14b95b3b8546db201e7efd0636ae0e215fae98f3 160470 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6f34661b6c97a37a5efc27d31c037ddeda4547e2 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 0570d7f276dd20a3adee80ca44a5fe7daf7566cd 160472 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 08f3a96b33e7eef39b651af9edb5e6de8ff13371 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 14b95b3b8546db201e7efd0636ae0e215fae98f3 160474 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f3bdfc41866edf7c256e689deb9d091a950c8fca 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160475 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 24e13a4dc1eb1630eceffc7ab334145d902e763d b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160448 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f037af6ecbc3b55042c998a59ed8df8548e64b99 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 63ad23fa240bb7cdbf6d0440c5670cc7935032b0 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 64d07691755e9aa6d3453ef3bb9109fde2b8da1e 160476 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b12498fc575f2ad30f09fe78badc7fef526e2d76 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160478 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b2ae1009d7cca2701e17eae55ae2d44fd22c942a ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e 60c0444fae2148452f9ed0b7c49af1fa41f8f522 160479 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f037af6ecbc3b55042c998a59ed8df8548e64b99 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 63ad23fa240bb7cdbf6d0440c5670cc7935032b0 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 64d07691755e9aa6d3453ef3bb9109fde2b8da1e 160481 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160482 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 81cbfd5088690c53541ffd0d74851c8ab055a829 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160483 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160484 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160486 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160488 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160489 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160491 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160493 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 Searching for interesting versions Result found: flight 159898 (pass), for basis pass Result found: flight 160448 (fail), for basis failure Repro found: flight 160478 (pass), for basis pass Repro found: flight 160479 (fail), for basis failure 0 revisions at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 No revisions left to test, checking graph state. Result found: flight 160484 (pass), for last pass Result found: flight 160486 (fail), for first failure Repro found: flight 160488 (pass), for last pass Repro found: flight 160489 (fail), for first failure Repro found: flight 160491 (pass), for last pass Repro found: flight 160493 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8d17adf34f501ded65a106572740760f0a75577c Bug not present: e67d8e2928200e24ecb47c7be3ea8270077f2996 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160493/ commit 8d17adf34f501ded65a106572740760f0a75577c Author: Daniel P. Berrangé Date: Mon Feb 22 11:16:32 2021 +0000 block: remove support for using "file" driver with block/char devices The 'host_device' and 'host_cdrom' drivers must be used instead. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé Revision graph left in /home/logs/results/bisect/qemu-mainline/test-amd64-amd64-libvirt-xsm.guest-start.{dot,ps,png,html,svg}. ---------------------------------------- 160493: tolerable FAIL flight 160493 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/160493/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-amd64-libvirt-xsm 14 guest-start fail baseline untested jobs: build-amd64-libvirt pass test-amd64-amd64-libvirt-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Sun Mar 28 09:25:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 28 Mar 2021 09:25:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102362.196042 (Exim 4.92) (envelope-from ) id 1lQRfd-0002mT-5j; Sun, 28 Mar 2021 09:25:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102362.196042; Sun, 28 Mar 2021 09:25:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQRfd-0002mM-2o; Sun, 28 Mar 2021 09:25:21 +0000 Received: by outflank-mailman (input) for mailman id 102362; Sun, 28 Mar 2021 09:25:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQRfc-0002mE-3C; Sun, 28 Mar 2021 09:25:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQRfb-0003XE-TT; Sun, 28 Mar 2021 09:25:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQRfb-0001Nl-Ia; Sun, 28 Mar 2021 09:25:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQRfb-0003wb-I5; Sun, 28 Mar 2021 09:25:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qAS21kXKROdMWQhIAE99aZjOwl1Bx896tgDdd8QPmnk=; b=aeFEguk90lq93rTzoEa0TjRKHb rxTKuMffvetSs09i/yZqWz2VeE4vOBfYETP1S8+gpImwnIOwchwCxNHaTIpe3d+nAuMvO0PPGFqfe T3YZmbBhvuw3a9tT7PrxyrUd4mG+khytXiQw/8XsvdCY/BIoF5UQo2fRs72a/6Qj/sG8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160473: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0f4498cef9f5cd18d7c6639a2a902ec1edc5be4e X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sun, 28 Mar 2021 09:25:19 +0000 flight 160473 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160473/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 0f4498cef9f5cd18d7c6639a2a902ec1edc5be4e baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 239 days Failing since 152366 2020-08-01 20:49:34 Z 238 days 407 attempts Testing same since 160473 2021-03-27 12:12:42 Z 0 days 1 attempts ------------------------------------------------------------ 5267 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1309537 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 28 09:49:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 28 Mar 2021 09:49:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102373.196063 (Exim 4.92) (envelope-from ) id 1lQS2h-00059y-Ah; Sun, 28 Mar 2021 09:49:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102373.196063; Sun, 28 Mar 2021 09:49:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQS2h-00059r-7m; Sun, 28 Mar 2021 09:49:11 +0000 Received: by outflank-mailman (input) for mailman id 102373; Sun, 28 Mar 2021 09:49:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQS2f-00059j-6r; Sun, 28 Mar 2021 09:49:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQS2e-0003uh-TL; Sun, 28 Mar 2021 09:49:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQS2e-0003C7-KD; Sun, 28 Mar 2021 09:49:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQS2e-00077Z-Jf; Sun, 28 Mar 2021 09:49:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vKkU5mXyuOc+SfEBE+uDK+Usx5E46C7Ty6lAFRyWESw=; b=rpMBX2t7ve59Uxl0M4/s9W8YBK ISr3qs53NNc6asz8PvmIN5ZUzxkiiaNNrzlKGscfM+9Cli/vnAaW3f4StuFpgj9a+JQPEcLlyJZde USIQd/AbWV3wLzCvadY9td0vQvKoteFZbmUluwRfh5T0lqJAsi7i5baAl2chXNyQJ9w8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 160495: all pass - PUSHED X-Osstest-Versions-This: xen=e680cc48b7184d3489873d6776f84ba1fc238ced X-Osstest-Versions-That: xen=b9b3082002cac68726fb303e0abd2ff0113d4657 From: osstest service owner Date: Sun, 28 Mar 2021 09:49:08 +0000 flight 160495 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/160495/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen e680cc48b7184d3489873d6776f84ba1fc238ced baseline version: xen b9b3082002cac68726fb303e0abd2ff0113d4657 Last test of basis 160385 2021-03-24 09:18:28 Z 4 days Testing same since 160495 2021-03-28 09:19:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Ian Jackson Jan Beulich Julien Grall Roger Pau Monné Tamas K Lengyel jobs: coverity-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b9b3082002..e680cc48b7 e680cc48b7184d3489873d6776f84ba1fc238ced -> coverity-tested/smoke From xen-devel-bounces@lists.xenproject.org Sun Mar 28 10:15:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 28 Mar 2021 10:15:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102379.196077 (Exim 4.92) (envelope-from ) id 1lQSRz-0000C1-GE; Sun, 28 Mar 2021 10:15:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102379.196077; Sun, 28 Mar 2021 10:15:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQSRz-0000Bu-DC; Sun, 28 Mar 2021 10:15:19 +0000 Received: by outflank-mailman (input) for mailman id 102379; Sun, 28 Mar 2021 10:15:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQSRx-0000Bm-Pl; Sun, 28 Mar 2021 10:15:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQSRx-0004PW-IX; Sun, 28 Mar 2021 10:15:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQSRx-0004OB-8o; Sun, 28 Mar 2021 10:15:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQSRx-0005Wi-8K; Sun, 28 Mar 2021 10:15:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OaesoWEsEAsQXm33p+ihqVQyWH+HK4zankOTUsFiNgk=; b=Mw932P8GH24F97TEsHdKY06WlP RFXL/nF7BEXTveiU5jsS5MY/ggbNrLt0e7RohlptcS40Ad+6T8yzXGx2aAqxxswRcfQul6N8IyqVT JcC7fabwypSC6YTcMmfJAv4Mq4DDKF56GWBX5p//WeBO5FNW/X8LuqHxOzz/gYiPzWc8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160490: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=bb966c28e72db650246e28a18038fc4240c59bac X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 28 Mar 2021 10:15:17 +0000 flight 160490 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160490/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt bb966c28e72db650246e28a18038fc4240c59bac baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 261 days Failing since 151818 2020-07-11 04:18:52 Z 260 days 253 attempts Testing same since 160464 2021-03-27 04:18:46 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 49159 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 28 13:14:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 28 Mar 2021 13:14:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102419.196110 (Exim 4.92) (envelope-from ) id 1lQVEs-0003Vz-K0; Sun, 28 Mar 2021 13:13:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102419.196110; Sun, 28 Mar 2021 13:13:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQVEs-0003Vs-H4; Sun, 28 Mar 2021 13:13:58 +0000 Received: by outflank-mailman (input) for mailman id 102419; Sun, 28 Mar 2021 13:13:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQVEq-0003Vk-G2; Sun, 28 Mar 2021 13:13:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQVEq-0007KY-2h; Sun, 28 Mar 2021 13:13:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQVEp-0005JA-O0; Sun, 28 Mar 2021 13:13:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQVEp-0003IF-NW; Sun, 28 Mar 2021 13:13:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dkEDZOJVghaNWOWkv4HZ0f0lC+iYPnGYkg/6tyPKTCo=; b=l+mCzDtOAh1Ge4/6kQh47u5ZCI AljkVA5nmusj5CaWDG4mvoR/6nL2mim1JJMrjH+USPTh528XY+aRRA0/71Ih0e9RAJ6SSndokpIo8 1NRsb/Evf7U/YImRm0CYPVed29jU84wP2x5ifKOxv/3NZ0Y3VK4Nlz0BQvqwH1P+8TaA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160477: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-arm64-arm64-xl-xsm:xen-boot:fail:regression qemu-mainline:test-arm64-arm64-xl-seattle:guest-stop:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-amd64-xl-rtds:guest-saverestore:fail:allowable qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=7b9a3c9f94bcac23c534bc9f42a9e914b433b299 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Sun, 28 Mar 2021 13:13:55 +0000 flight 160477 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160477/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 152631 test-arm64-arm64-xl-seattle 17 guest-stop fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 17 guest-saverestore fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 220 days Failing since 152659 2020-08-21 14:07:39 Z 218 days 415 attempts Testing same since 160477 2021-03-27 15:41:46 Z 0 days 1 attempts ------------------------------------------------------------ 466 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 138319 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 28 19:24:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 28 Mar 2021 19:24:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102689.196162 (Exim 4.92) (envelope-from ) id 1lQb17-00018O-8v; Sun, 28 Mar 2021 19:24:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102689.196162; Sun, 28 Mar 2021 19:24:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQb17-00018H-4v; Sun, 28 Mar 2021 19:24:09 +0000 Received: by outflank-mailman (input) for mailman id 102689; Sun, 28 Mar 2021 19:24:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQb15-000189-Fi; Sun, 28 Mar 2021 19:24:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQb15-0005SD-56; Sun, 28 Mar 2021 19:24:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQb14-0008Ss-S8; Sun, 28 Mar 2021 19:24:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQb14-0002Kz-Rd; Sun, 28 Mar 2021 19:24:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=j7LEM/mMAHCfmWDDpd5DnemATx1xcOpm63RmbPxVfEk=; b=nWEHRKl1exGKS3UEeiryGOl+lT RIggUM4wUDYapFlPCVHxiDZEP4qUtV+HnHGlpDKBqWKIyq6Djip/gt382BJAgbMjWLsGHqHb33mQd yPx5WhH5Q8nvfUYrpgk/IbXMKqj759u8PkUaJXE0RpfeQMb51xSoulMGU3BhiLvb+0I4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160487: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Sun, 28 Mar 2021 19:24:06 +0000 flight 160487 xen-4.12-testing real [real] flight 160507 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160487/ http://logs.test-lab.xenproject.org/osstest/logs/160507/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail REGR. vs. 159418 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 40 days Failing since 160128 2021-03-18 14:36:18 Z 10 days 10 attempts Testing same since 160150 2021-03-20 04:11:48 Z 8 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Mar 28 20:46:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 28 Mar 2021 20:46:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102703.196183 (Exim 4.92) (envelope-from ) id 1lQcIa-0000zf-GC; Sun, 28 Mar 2021 20:46:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102703.196183; Sun, 28 Mar 2021 20:46:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQcIa-0000zY-Cm; Sun, 28 Mar 2021 20:46:16 +0000 Received: by outflank-mailman (input) for mailman id 102703; Sun, 28 Mar 2021 20:46:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQcIY-0000zT-BB for xen-devel@lists.xenproject.org; Sun, 28 Mar 2021 20:46:14 +0000 Received: from smtp-fw-2101.amazon.com (unknown [72.21.196.25]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6bd2621a-dc34-4db7-9edc-9803a02ee16b; Sun, 28 Mar 2021 20:46:13 +0000 (UTC) Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2b-c7131dcf.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP; 28 Mar 2021 20:46:04 +0000 Received: from EX13D12EUA002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2b-c7131dcf.us-west-2.amazon.com (Postfix) with ESMTPS id EBB91A245B; Sun, 28 Mar 2021 20:46:03 +0000 (UTC) Received: from 147dda3ee008.ant.amazon.com (10.43.164.198) by EX13D12EUA002.ant.amazon.com (10.43.165.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 28 Mar 2021 20:46:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bd2621a-dc34-4db7-9edc-9803a02ee16b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1616964373; x=1648500373; h=to:cc:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding:subject; bh=BFoR87Zga8SDLRAr8FqLozZHk1+9WOoIeUVoGrO4GqY=; b=AixelBfk0fStrqVo06Ep3P48jNRY9pxTNeOTf6KLwzGU0xbOlm6tKmf9 0otcOgHRGHTYj0/lk91ExBk9/5sVKeWA8AMN9XW5AjL3W4Eh9bg0ofqw6 /YjwczdibvSMS7UFrryERZrQ0+rmj09nJCZG4UV99ez23rcVJIZZwIMsy s=; X-IronPort-AV: E=Sophos;i="5.81,285,1610409600"; d="scan'208";a="98513050" Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring To: Leon Romanovsky , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= CC: Andrew Lunn , , , , , , References: <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> From: "Hsu, Chiahao" Message-ID: Date: Sun, 28 Mar 2021 22:46:01 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.43.164.198] X-ClientProxiedBy: EX13D10EUA002.ant.amazon.com (10.43.165.64) To EX13D12EUA002.ant.amazon.com (10.43.165.103) Leon Romanovsky 於 2021/3/22 08:13 寫道: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > On Mon, Mar 22, 2021 at 08:01:17AM +0100, Jürgen Groß wrote: >> On 22.03.21 07:48, Leon Romanovsky wrote: >>> On Mon, Mar 22, 2021 at 06:58:34AM +0100, Jürgen Groß wrote: >>>> On 22.03.21 06:39, Leon Romanovsky wrote: >>>>> On Sun, Mar 21, 2021 at 06:54:52PM +0100, Hsu, Chiahao wrote: >>>>> <...> >>>>> >>>>>>>> Typically there should be one VM running netback on each host, >>>>>>>> and having control over what interfaces or features it exposes is also >>>>>>>> important for stability. >>>>>>>> How about we create a 'feature flags' modparam, each bits is specified for >>>>>>>> different new features? >>>>>>> At the end, it will be more granular module parameter that user still >>>>>>> will need to guess. >>>>>> I believe users always need to know any parameter or any tool's flag before >>>>>> they use it. >>>>>> For example, before user try to set/clear this ctrl_ring_enabled, they >>>>>> should already have basic knowledge about this feature, >>>>>> or else they shouldn't use it (the default value is same as before), and >>>>>> that's also why we use the 'ctrl_ring_enabled' as parameter name. >>>>> It solves only forward migration flow. Move from machine A with no >>>>> option X to machine B with option X. It doesn't work for backward >>>>> flow. Move from machine B to A back will probably break. >>>>> >>>>> In your flow, you want that users will set all module parameters for >>>>> every upgrade and keep those parameters differently per-version. >>>> I think the flag should be a per guest config item. Adding this item to >>>> the backend Xenstore nodes for netback to consume it should be rather >>>> easy. >>>> >>>> Yes, this would need a change in Xen tools, too, but it is the most >>>> flexible way to handle it. And in case of migration the information >>>> would be just migrated to the new host with the guest's config data. >>> Yes, it will overcome global nature of module parameters, but how does >>> it solve backward compatibility concern? >> When creating a guest on A the (unknown) feature will not be set to >> any value in the guest's config data. A migration stream not having any >> value for that feature on B should set it to "false". >> >> When creating a guest on B it will either have the feature value set >> explicitly in the guest config (either true or false), or it will get >> the server's default (this value should be configurable in a global >> config file, default for that global value would be "true"). >> >> So with the guest created on B with feature specified as "false" (either >> for this guest only, or per global config), it will be migratable to >> machine A without problem. Migrating it back to B would work the same >> way as above. Trying to migrate a guest with feature set to "true" to >> B would not work, but this would be the host admin's fault due to not >> configuring the guest correctly. so the expected changes would be 1. remove feature-ctrl-ring & feature-dynamic-multicast-control from netback_probe( ) 2. consume the backend Xenstore nodes in connect( ) to see if Xen tools set nodes(true/false) or not(unknown) Thanks. Andy > As long as all new features are disabled by default, it will be ok. > > Thanks > >> >> Juergen > > > > From xen-devel-bounces@lists.xenproject.org Sun Mar 28 23:07:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 28 Mar 2021 23:07:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102718.196207 (Exim 4.92) (envelope-from ) id 1lQeUg-0006o1-Lu; Sun, 28 Mar 2021 23:06:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102718.196207; Sun, 28 Mar 2021 23:06:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQeUg-0006nu-I3; Sun, 28 Mar 2021 23:06:54 +0000 Received: by outflank-mailman (input) for mailman id 102718; Sun, 28 Mar 2021 23:06:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQeUe-0006nm-JE; Sun, 28 Mar 2021 23:06:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQeUe-0000rm-Bi; Sun, 28 Mar 2021 23:06:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQeUe-0002Jp-05; Sun, 28 Mar 2021 23:06:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQeUd-0004ho-VP; Sun, 28 Mar 2021 23:06:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EemY/LZA4Q+fehlrMhO5F9EBf0jIR0yi5kEJeXsShzA=; b=yiFQ01K1Koyo6tk5IBVuT/Hs9F rafRnW+0KSrfyFh8t7Wch7gAyCij622sEeUSGX8snutFX8018BvTGPHVkp+KjKcuGcP8x9Cai0d40 8Int2hwPmrcQ4OGnTiyI8sh63MCMVHI/8ng5+wsTspbCle6ykILx57hN6cDJ6Q8qPvBI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160492: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e680cc48b7184d3489873d6776f84ba1fc238ced X-Osstest-Versions-That: xen=e680cc48b7184d3489873d6776f84ba1fc238ced From: osstest service owner Date: Sun, 28 Mar 2021 23:06:51 +0000 flight 160492 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160492/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 160471 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160471 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160471 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160471 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160471 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160471 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160471 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160471 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160471 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160471 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160471 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160471 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160471 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen e680cc48b7184d3489873d6776f84ba1fc238ced baseline version: xen e680cc48b7184d3489873d6776f84ba1fc238ced Last test of basis 160492 2021-03-28 06:38:17 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Mar 29 01:26:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 01:26:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102734.196234 (Exim 4.92) (envelope-from ) id 1lQger-00020p-1R; Mon, 29 Mar 2021 01:25:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102734.196234; Mon, 29 Mar 2021 01:25:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQgeq-00020i-TZ; Mon, 29 Mar 2021 01:25:32 +0000 Received: by outflank-mailman (input) for mailman id 102734; Mon, 29 Mar 2021 01:25:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQgep-00020a-UL; Mon, 29 Mar 2021 01:25:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQgep-0000pf-L0; Mon, 29 Mar 2021 01:25:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQgep-0007YC-A7; Mon, 29 Mar 2021 01:25:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQgep-0002zS-9b; Mon, 29 Mar 2021 01:25:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+HZcKxwWnb5+6ZiGDsELyDkqPriT5QMqFEflFocHrIc=; b=Hepf4YRfsCi0o9XAiYRY9coPwv YTvKf80tVH7NP6wYnLgOucyYZbWro0ap11BmmdCvjooCDXbE1BEHCM+mMPM7qtxbiBfJxJa/M6lYp XfezGHz/ep+heEaWONYiGg8Vk5LW06e0qzMUqtVBsv6M0LPCGZlQmGv8cHtIeozWlR2s=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160496: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-localmigrate/x10:fail:heisenbug linux-linus:test-armhf-armhf-xl:xen-boot:fail:heisenbug linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0f4498cef9f5cd18d7c6639a2a902ec1edc5be4e X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 29 Mar 2021 01:25:31 +0000 flight 160496 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160496/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail in 160473 REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-i386-pvgrub 19 guest-localmigrate/x10 fail pass in 160473 test-armhf-armhf-xl 8 xen-boot fail pass in 160473 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 15 migrate-support-check fail in 160473 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 160473 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 0f4498cef9f5cd18d7c6639a2a902ec1edc5be4e baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 240 days Failing since 152366 2020-08-01 20:49:34 Z 239 days 408 attempts Testing same since 160473 2021-03-27 12:12:42 Z 1 days 2 attempts ------------------------------------------------------------ 5267 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1309537 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 29 05:04:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 05:04:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102798.196302 (Exim 4.92) (envelope-from ) id 1lQk4K-0000nv-UL; Mon, 29 Mar 2021 05:04:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102798.196302; Mon, 29 Mar 2021 05:04:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQk4K-0000no-Qm; Mon, 29 Mar 2021 05:04:04 +0000 Received: by outflank-mailman (input) for mailman id 102798; Mon, 29 Mar 2021 05:04:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQk4J-0000nj-8e for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 05:04:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c4eef140-809e-41a2-9c27-97f3453e68a0; Mon, 29 Mar 2021 05:03:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DEB60B217; Mon, 29 Mar 2021 05:03:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4eef140-809e-41a2-9c27-97f3453e68a0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616994239; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OltM0c4NXhUr2NOE/Q3F89i4bVBoS57i1Rx2yFWgD3E=; b=l3ScvgM94a17eS01J97dDdNVpwJv+oLPilJxq4/4kHTe5Vj2LFASIyuatiCGT81Hx1CZKe p9AMuEOoCKCQymfUXO9GFOcewOfdpgGdB21Au0Qz4RVzoVIdNDX4aY78bIcBqzl3HBwHUQ jbdXiojjjyg6YjABSuKn1e9f9U39qyk= Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring To: "Hsu, Chiahao" , Leon Romanovsky Cc: Andrew Lunn , netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org References: <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> From: Juergen Gross Message-ID: <3136e73f-d661-6f16-a3ce-1ee814dbedff@suse.com> Date: Mon, 29 Mar 2021 07:03:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d2cqQLGfyAhEyqvbowhYCZOslEBwEsrxb" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --d2cqQLGfyAhEyqvbowhYCZOslEBwEsrxb Content-Type: multipart/mixed; boundary="zX1ZuB5ENFZ9KeOGwPeJS5oD3rTOd9Oi5"; protected-headers="v1" From: Juergen Gross To: "Hsu, Chiahao" , Leon Romanovsky Cc: Andrew Lunn , netdev@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org, xen-devel@lists.xenproject.org Message-ID: <3136e73f-d661-6f16-a3ce-1ee814dbedff@suse.com> Subject: Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring References: <64f5c7a8-cc09-3a7f-b33b-a64d373aed60@amazon.com> <12f643b5-7a35-d960-9b1f-22853aea4b4c@amazon.com> In-Reply-To: --zX1ZuB5ENFZ9KeOGwPeJS5oD3rTOd9Oi5 Content-Type: multipart/mixed; boundary="------------5ACF9DB2D547D252A89E4091" Content-Language: en-US This is a multi-part message in MIME format. --------------5ACF9DB2D547D252A89E4091 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 28.03.21 22:46, Hsu, Chiahao wrote: >=20 >=20 > Leon Romanovsky =E6=96=BC 2021/3/22 08:13 =E5=AF=AB=E9=81=93: >> CAUTION: This email originated from outside of the organization. Do=20 >> not click links or open attachments unless you can confirm the sender = >> and know the content is safe. >> >> >> >> On Mon, Mar 22, 2021 at 08:01:17AM +0100, J=C3=BCrgen Gro=C3=9F wrote:= >>> On 22.03.21 07:48, Leon Romanovsky wrote: >>>> On Mon, Mar 22, 2021 at 06:58:34AM +0100, J=C3=BCrgen Gro=C3=9F wrot= e: >>>>> On 22.03.21 06:39, Leon Romanovsky wrote: >>>>>> On Sun, Mar 21, 2021 at 06:54:52PM +0100, Hsu, Chiahao wrote: >>>>>> <...> >>>>>> >>>>>>>>> Typically there should be one VM running netback on each host, >>>>>>>>> and having control over what interfaces or features it exposes = >>>>>>>>> is also >>>>>>>>> important for stability. >>>>>>>>> How about we create a 'feature flags' modparam, each bits is=20 >>>>>>>>> specified for >>>>>>>>> different new features? >>>>>>>> At the end, it will be more granular module parameter that user = >>>>>>>> still >>>>>>>> will need to guess. >>>>>>> I believe users always need to know any parameter or any tool's=20 >>>>>>> flag before >>>>>>> they use it. >>>>>>> For example, before user try to set/clear this ctrl_ring_enabled,= =20 >>>>>>> they >>>>>>> should already have basic knowledge about this feature, >>>>>>> or else they shouldn't use it (the default value is same as=20 >>>>>>> before), and >>>>>>> that's also why we use the 'ctrl_ring_enabled' as parameter name.= >>>>>> It solves only forward migration flow. Move from machine A with no= >>>>>> option X to machine B with option X. It doesn't work for backward >>>>>> flow. Move from machine B to A back will probably break. >>>>>> >>>>>> In your flow, you want that users will set all module parameters f= or >>>>>> every upgrade and keep those parameters differently per-version. >>>>> I think the flag should be a per guest config item. Adding this=20 >>>>> item to >>>>> the backend Xenstore nodes for netback to consume it should be rath= er >>>>> easy. >>>>> >>>>> Yes, this would need a change in Xen tools, too, but it is the most= >>>>> flexible way to handle it. And in case of migration the information= >>>>> would be just migrated to the new host with the guest's config data= =2E >>>> Yes, it will overcome global nature of module parameters, but how do= es >>>> it solve backward compatibility concern? >>> When creating a guest on A the (unknown) feature will not be set to >>> any value in the guest's config data. A migration stream not having a= ny >>> value for that feature on B should set it to "false". >>> >>> When creating a guest on B it will either have the feature value set >>> explicitly in the guest config (either true or false), or it will get= >>> the server's default (this value should be configurable in a global >>> config file, default for that global value would be "true"). >>> >>> So with the guest created on B with feature specified as "false" (eit= her >>> for this guest only, or per global config), it will be migratable to >>> machine A without problem. Migrating it back to B would work the same= >>> way as above. Trying to migrate a guest with feature set to "true" to= >>> B would not work, but this would be the host admin's fault due to not= >>> configuring the guest correctly. > so the expected changes would be >=20 > 1. remove feature-ctrl-ring & feature-dynamic-multicast-control from=20 > netback_probe( ) > 2. consume the backend Xenstore nodes in connect( ) to see if Xen tools= =20 > set nodes(true/false) or not(unknown) Yes. I think this is the way to go. Juergen --------------5ACF9DB2D547D252A89E4091 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------5ACF9DB2D547D252A89E4091-- --zX1ZuB5ENFZ9KeOGwPeJS5oD3rTOd9Oi5-- --d2cqQLGfyAhEyqvbowhYCZOslEBwEsrxb Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBhX70FAwAAAAAACgkQsN6d1ii/Ey+F NAgAhc4zOKnH04x7bmFB9qTw3ahmPPpFLvJinPhSmAJkcKVMcGBsbrt5e1l+65maDM/2jYRW8SEi o6SxKfwHYdsnUeSTjGBeA/OLRIackdyJxhK7w2QRkkaQEltTBNqnIgTeNV5IfevezouxfXHrkOrZ rNHD7nnpaIBuv+ADe+sZLblfOCfsg19dv5MLR8t/QL1Npu+WPwQfobGhoUiT/lQHWINs2xah9uD6 PpJrFucDpBxNOauiGFv62LIAocRRC/XnzJtcpqs+S1Nhc5OrlSrCrSwyCug0EoqFr2irnYB+cnLD wL8A7XCs9AvMQ1cLhRj5JiNwpcnQvIIrkcL3eDGNbQ== =JLqB -----END PGP SIGNATURE----- --d2cqQLGfyAhEyqvbowhYCZOslEBwEsrxb-- From xen-devel-bounces@lists.xenproject.org Mon Mar 29 05:51:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 05:51:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102804.196321 (Exim 4.92) (envelope-from ) id 1lQkni-0005jT-Eg; Mon, 29 Mar 2021 05:50:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102804.196321; Mon, 29 Mar 2021 05:50:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQkni-0005jM-B1; Mon, 29 Mar 2021 05:50:58 +0000 Received: by outflank-mailman (input) for mailman id 102804; Mon, 29 Mar 2021 05:50:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQkng-0005jE-3b; Mon, 29 Mar 2021 05:50:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQknf-0006Xe-Rm; Mon, 29 Mar 2021 05:50:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQknf-0003kd-GN; Mon, 29 Mar 2021 05:50:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQknf-0002zi-Ft; Mon, 29 Mar 2021 05:50:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4IFGSEzj8QsGKgGpwnrHonqpW5pbOSSmCnBuuaswe28=; b=kSq1XW8JyMEEF/RknDYcDoZr2l dvHX7VDnfbLgHbcbTkd5F5rOM4nmuP/KqCjgAA4fyOI0pcmYPRgZa4VuJxuY66b//ILHb58lgYHJV JoVzCHKYMiYzZr+WANVaETJ6k03+PWSeoLSsfmiJvXgMERxCrvDfM/0w8sldqxXYc+lM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160501: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate:fail:allowable qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=7b9a3c9f94bcac23c534bc9f42a9e914b433b299 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Mon, 29 Mar 2021 05:50:55 +0000 flight 160501 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160501/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 18 guest-localmigrate fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 220 days Failing since 152659 2020-08-21 14:07:39 Z 219 days 416 attempts Testing same since 160477 2021-03-27 15:41:46 Z 1 days 2 attempts ------------------------------------------------------------ 466 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 138319 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 29 07:01:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 07:01:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102819.196342 (Exim 4.92) (envelope-from ) id 1lQltx-0004qh-Mn; Mon, 29 Mar 2021 07:01:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102819.196342; Mon, 29 Mar 2021 07:01:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQltx-0004qa-JQ; Mon, 29 Mar 2021 07:01:29 +0000 Received: by outflank-mailman (input) for mailman id 102819; Mon, 29 Mar 2021 07:01:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQltw-0004qS-VI; Mon, 29 Mar 2021 07:01:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQltw-0007oc-PL; Mon, 29 Mar 2021 07:01:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQltw-0008GW-F1; Mon, 29 Mar 2021 07:01:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQltw-00074W-EW; Mon, 29 Mar 2021 07:01:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=j9/ig51A4x43VhMxhxBLcbf5Ygis223GXLEOKUJc2VQ=; b=VoxoO+2lQZYj5uBoL8twV3PDVf HXgx5cvLVWhOuGrbPKk7LJekxNoWkGm7SyX918Is0c3vp693AEW2s34fx07MTBaR80+z02KjikjtM +TaGiXmCRav3FnZJ9IRt4IDBtbUfzOqaK7yU8E/jFSSlXSP8+RlMiD1ccICmu7W80jE0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160519: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=bb966c28e72db650246e28a18038fc4240c59bac X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 29 Mar 2021 07:01:28 +0000 flight 160519 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160519/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt bb966c28e72db650246e28a18038fc4240c59bac baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 262 days Failing since 151818 2020-07-11 04:18:52 Z 261 days 254 attempts Testing same since 160464 2021-03-27 04:18:46 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 49159 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 29 07:24:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 07:24:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102830.196357 (Exim 4.92) (envelope-from ) id 1lQmFu-0006yy-Jh; Mon, 29 Mar 2021 07:24:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102830.196357; Mon, 29 Mar 2021 07:24:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQmFu-0006yr-Gc; Mon, 29 Mar 2021 07:24:10 +0000 Received: by outflank-mailman (input) for mailman id 102830; Mon, 29 Mar 2021 07:24:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQmFt-0006ym-1R for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 07:24:09 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3e35a431-abc2-45db-a7be-aa4923a6f39c; Mon, 29 Mar 2021 07:24:07 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D351FB331; Mon, 29 Mar 2021 07:24:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e35a431-abc2-45db-a7be-aa4923a6f39c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617002647; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fW7kfOE/p2R8a+wpdjmOIjK4yzLS0Wgi3hjUq2YWuoI=; b=P8Vbr4RcnlDtTKqfjkwruCJ5xSvi7yDGmcD2O0EZkvfllddiwWWoNemf/rJagJZSxeqxuW jJL3mw4OMxvxMkadNazMAhi0qIA+VFCdoAJti992UZkks4A54O+2ON0r9rsHeKRj16l19R 5Cga6xu/WZPnKmpfCBH6tln18lPBxUg= Subject: Re: [PATCH] xen/pciback: Fix incorrect type warnings To: Muhammad Usama Anjum , Boris Ostrovsky , Stefano Stabellini , "moderated list:XEN HYPERVISOR INTERFACE" , open list , kernel-janitors@vger.kernel.org, colin.king@canonical.com, dan.carpenter@oracle.com References: <20210326181442.GA1735905@LEGION> From: Juergen Gross Message-ID: Date: Mon, 29 Mar 2021 09:24:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210326181442.GA1735905@LEGION> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zDwD3vRcZHWEDpgn1mD1x7LjBqmgFkwmR" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --zDwD3vRcZHWEDpgn1mD1x7LjBqmgFkwmR Content-Type: multipart/mixed; boundary="RCllf4ZADu7Gy7ashMgetdyJxPJ4bWqZo"; protected-headers="v1" From: Juergen Gross To: Muhammad Usama Anjum , Boris Ostrovsky , Stefano Stabellini , "moderated list:XEN HYPERVISOR INTERFACE" , open list , kernel-janitors@vger.kernel.org, colin.king@canonical.com, dan.carpenter@oracle.com Message-ID: Subject: Re: [PATCH] xen/pciback: Fix incorrect type warnings References: <20210326181442.GA1735905@LEGION> In-Reply-To: <20210326181442.GA1735905@LEGION> --RCllf4ZADu7Gy7ashMgetdyJxPJ4bWqZo Content-Type: multipart/mixed; boundary="------------130E490ED841A55D5DFA7DD7" Content-Language: en-US This is a multi-part message in MIME format. --------------130E490ED841A55D5DFA7DD7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 26.03.21 19:14, Muhammad Usama Anjum wrote: > Correct enum pci_channel_io_normal should be used instead of putting > integer value 1. >=20 > Fix following smatch warnings: > drivers/xen/xen-pciback/pci_stub.c:805:40: warning: incorrect type in a= rgument 2 (different base types) > drivers/xen/xen-pciback/pci_stub.c:805:40: expected restricted pci_c= hannel_state_t [usertype] state > drivers/xen/xen-pciback/pci_stub.c:805:40: got int > drivers/xen/xen-pciback/pci_stub.c:862:40: warning: incorrect type in a= rgument 2 (different base types) > drivers/xen/xen-pciback/pci_stub.c:862:40: expected restricted pci_c= hannel_state_t [usertype] state > drivers/xen/xen-pciback/pci_stub.c:862:40: got int > drivers/xen/xen-pciback/pci_stub.c:973:31: warning: incorrect type in a= rgument 2 (different base types) > drivers/xen/xen-pciback/pci_stub.c:973:31: expected restricted pci_c= hannel_state_t [usertype] state > drivers/xen/xen-pciback/pci_stub.c:973:31: got int >=20 > Signed-off-by: Muhammad Usama Anjum Reviewed-by: Juergen Gross Juergen --------------130E490ED841A55D5DFA7DD7 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------130E490ED841A55D5DFA7DD7-- --RCllf4ZADu7Gy7ashMgetdyJxPJ4bWqZo-- --zDwD3vRcZHWEDpgn1mD1x7LjBqmgFkwmR Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBhgJUFAwAAAAAACgkQsN6d1ii/Ey/w Mwf8DoQ9GdcZMfTUu3dq5cdV/Wuo16UhK1ovEcanG1TikziyQipetP6A1LtuJtvchJfphXSktXJy RFKdJiDuv6PlXZUyngs3PIJTChHqT2Xx+NOfKUGDFXQ6cwOYlM96Ug1+yd15gD/pBFWXPj8yeDwk Ak7JeAMVI8p7oUO5qs6ophSm4BFLQGV43Xa8nLd0Nk6kbkGse1JZiRjk52f3K+wupi0EXBXem/vW IOskkV0SeY+s0vYMHh1lwng9a6aqUWnAlANRF9FuyJNZTrhtguOVFMX5hxsoOekTLJW5pIN9LDXm sZeqMQWtYoKoTsFfSXkCD4fGEF9EOhWZYRQn60s2Aw== =/lIM -----END PGP SIGNATURE----- --zDwD3vRcZHWEDpgn1mD1x7LjBqmgFkwmR-- From xen-devel-bounces@lists.xenproject.org Mon Mar 29 08:59:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 08:59:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102875.196393 (Exim 4.92) (envelope-from ) id 1lQnjQ-000050-7x; Mon, 29 Mar 2021 08:58:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102875.196393; Mon, 29 Mar 2021 08:58:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQnjQ-00004s-4p; Mon, 29 Mar 2021 08:58:44 +0000 Received: by outflank-mailman (input) for mailman id 102875; Mon, 29 Mar 2021 08:58:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQnjO-0008WS-6U for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 08:58:42 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 27cd28c9-f4e0-4054-89b8-522608847dba; Mon, 29 Mar 2021 08:58:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27cd28c9-f4e0-4054-89b8-522608847dba DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617008319; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=wsXgnSI58+Jr8+zatGJvthlCgFZTqM69N434gsIH27A=; b=Gwfk/IJvNtQx17K/VrOD7RS9Dg3TxWyKISr6IW6tfdbk9uHAOmNw1CxL bkCMHM5/5iRPqxERhKtrFaOVQJ8oHWX8mzpSTTRqgWdefnhTfKwCWdV5z 3StNYMAAF2ELr3s/YOYpS9JRklWKsvgVFHHfrBf4XvWn/8W7iq9UHeItd k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: d1FBGBhSmVtBDE8S69N0PyiTd9+lj7bv2JG9Vb00l5wclpbXLvnY3z3CmDZ1CuQ8qqRp6J3Rdu TmMw0bpcL5tzfbG0WvdO44wkNWc691Bvma6kXI/bZ9a8rkvAQqteSNN4KCBbzBukGsPDb4S5Vz tv0sYS6UtJVLpz2F/OXuDGBbvO+3/og088Ixqf3/QLOZJVh9iodlBWeqnjtGRKbN8J+MMGvQdF ZAV004Q2Y4TQQTayCvcEZyb0PCPJRlukIQmYUNt5Zgqt+X/Uy4q5erU/XA0DvJintvtxAnstyN dsg= X-SBRS: 5.2 X-MesageID: 40333732 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:AyvhsapDvTKWMwz2C8wlNhAaV5u4KtV00zAX/kB9WHVpW+SivY SHgOkb2RjoiDwYRXEnnpS6NLOdRG7HnKQa3aA4Bp3neAX9omOnIMVZ7YXkyyD9ACGWzIFg/I 9aWexFBNX0ZGIXse/T/BS4H9E8wNOO7aCvgqPkw21wSBxxApsB0y5SIG+gYytLbSNBAoc0E4 fZy8pcvjy7eWkWaMPTPAh5Y8HoodrXmJX6JSMXHhJP0nj1sRqEyp7fVyKZ0BAXTi9Vzd4ZkF TtvgTl6syYwpSG4zDG0Wu71eUzpPLAzZ95CNWImowpLFzX+3qVTaBAf5HHgzwvuuGo7z8R4a nxijMtJd565X+UXkzdm2qU5yDa3Dwj62DvxDaj6BOJy6GJJ0NZerh8rLlUfRfD500rsMsU6t Mx40uju4dKFhSFpSzh5rHzJmBXv3Cpqnkvm/N7tQ0nbaIibtZq3Osi1XIQOpIBECXm0ZsgAe ljAerNjcwmD2+yXjT3uHJiz8erWWl2NhCaQlIassjQ6DROmmtlpnFoiPA3rzMlztYQWpNE7+ PLPuBBk6xPdNYfaeZYCP0aScW6J2TRSXv3QS2vCGWiMJtCF2PGqpbx7rlwzvqtYoY0wJw7n4 mEeE9EtEYpEnieSfGm7dluyFTgUW+9VTPixoV1/J5ioIDxQ7LtLGmqVE0uqc29uP8Sa/erGs qbCdZzObvOPGHuEYFG00nVQJ9JM0QTV8UTp5IVQFSLjsXXKpD7l+DSffrJTYCdUwoMayfaOD 8uTTLzLMJP4gSAQXnjmiXcXHvrZwje8PtLYe3n1tlW7LJIGpxHswATh1j8zNqMMyd+vqs/e1 Y7BLvml6i8tFSn5Gqg1RQsBjNtSmJupJnwWXJDogEHd2nud6wYhtmZcWdOmFyKOwF4VMGTNA JEvVx49eaWIvWrtG4fIuPiFljfo2oYpXqMQZtZsLaE/93ZdpQxCYtjfrdwGwXNHxlcgh1rt2 9HVQ8BSibkZ3DToJTgqKZRKPDUdtF6jgvuC9VTs2jjuUKVotxqemEWRAe0UcmcgR8nQh1dgl EZyd5ZvJOw3RKUbUcviuUxN1NBLECaGqhPAgi+aIJIobzzYw1rQWCWhTuVtgErdgPRhjYvr1 2kCRfRVeDAA1JbtHwd6Krs/V9uXki2fk57aBlBwMZAPFWDnkw2/f6AZ6K13WfUV0ALxfsFNi rZJREIJBl1+tyx3BmJuTqLGHk83K8yNujFALlLScCU5lqdbKmz0Y0WFf5d+5hocO30uugQSO SFZku7Kij7B+5B4X3iml8VfA1P7F8qnvPj1Ee7sCyW3HsjDeHTJ1ojbbcBON2Y53XlQfHN8J gRt6NAgcKAdkHKLviBwuXrShQGDDX5i2u/VfspppBZprhajso6I7DrFR/zkEha1xA/JvrunE wQQK5H8KnMU7UfCvA6SmZ8xB4Vj9yBI0sgjxzuDsI/dV8riWXHP9nh2cu+lZMfRmmArhD3I1 +R7ml0+OrERTKK0dcheugNCFUTTEg383J5+uyeM6XWFQWxbulGuH63KGW0frMYaK+LH9wr31 tHyuDNu++cbCzj3g/M+RN9P6JV6m6iBfqIPzjkI58Az/WKfXKWgqWr58avjDD4DRuDAn5o+r FtRAg3dcRMij4rkYst9DO9I5aH+34Yrw== X-IronPort-AV: E=Sophos;i="5.81,287,1610427600"; d="scan'208";a="40333732" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jr1IiaYB/0C5mPcXKxS0c0PxeuZW5K12xvrtNnIJvUqSyyGu8Dmn3U7yA3K5S5gK7fMwvWm4FHXkRQLpA1AgTWDzvuFCicXD6I/3d6kSSe0hABRRncMEDHqN8gG8rFUiwR3aNqDn/rwQ2LnGPcOy7aKN+r8bqoQ+831IRLSPohgSCP9eC6dArUpS5eG/yKYeqQk+Zdw2trxHtreLWizhdDmvVKWXGjtVNXbXyzo6FFNcJ5DLtgstgQ6hNzt+dufpzh3EVrmEnpWHuhkNn7SZlOTTN4S16bSl+HJw3ZhC48e/zRPflghdj952Qg2uPh+L3XiW16/VDL6bnSRvktn6cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EoP1zbXW3g1yFyqXA/ypxVDGHqulLi4fVxs0+Y1QHXE=; b=T6emeoIB7y6TWAt+H7WjDy6xMeKOzxy2xOLMrz/1JaH9q0Ayg3XyeASFCpKH+oJGS+MyHdIvejY6IWW9x7FQjpuGeG0zhpqoYD5YNiEZo9tIwa6QbMi6H0ffSMg6OAxLYx80dU8izPyPcndHSAAnDtYpZ4vRtbtBHI1eE29T5D28E7RKVjkYsw2as6q00q2bcEVtitgVaZhaWOyKR5aViQMuzXkQR2ybSO7HLeKSwSRWBnrR/p8BhFZwBqBbD7IfYhRUc+Dhz+LjAvqDsxT5w8DIPJqBFRcEthmBO8UzFKShNOYm6tsJmAskFOnYsxihN9xuK/P0iA2apYbwzYbRlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EoP1zbXW3g1yFyqXA/ypxVDGHqulLi4fVxs0+Y1QHXE=; b=J0pwovIubAUvE1OQeIwaR4Yi6tSrKNVgWYSRoZlYGmKSjMAeYSYot5KsYM9cSM4f839W99yQI9sq3Z0e5mtn51KlIBlf38YxHMuFKyi9YBMxrPgz5M4Bs1t8xiF14JPf5R6sbispSrzW6xJF/vfxp1exxzZHaURPGUO8ZaX6mpo= Date: Mon, 29 Mar 2021 10:58:30 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper , Ian Jackson CC: Jan Beulich , Xen-devel , Wei Liu , Boris Ostrovsky Subject: Re: [PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351 [and 1 more messages] Message-ID: References: <20210316161844.1658-1-andrew.cooper3@citrix.com> <20210316161844.1658-2-andrew.cooper3@citrix.com> <24658.1583.601613.903527@mariner.uk.xensource.com> <4b1c13ee-f121-3379-6fb3-c0d4dbb76e48@citrix.com> <24658.5692.932979.892439@mariner.uk.xensource.com> <24658.7471.309734.168120@mariner.uk.xensource.com> <24669.61118.533307.438087@mariner.uk.xensource.com> <24669.61445.44470.436950@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <24669.61445.44470.436950@mariner.uk.xensource.com> X-ClientProxiedBy: PR3P191CA0044.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::19) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 653d4cc3-4b19-4377-566b-08d8f290d64d X-MS-TrafficTypeDiagnostic: DM4PR03MB5968: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2pANGZOTSBhWno6d6no+Aq2Ei3NlCP+UuvedLfY+FMPAbfjh+QpN4D7zTKpukIdT8971pTrtcIzwB91jzYPRCEeBwQfocNRg+CE+JHlBgp1GmaX98Soppe37q1gLLKg2Dm3AbCMriBou6HNRubBtHJAy7/xEaj/lblOFKOK/hEzTFyDRg+7gJhzGhBERx8FCDPxiNRNYSMTfUwIRSx1HIi5FoeGtQVNNOf8HrdwrWkjMqu4SDrbcWvw8U3I0sqLOfuU9YkAM7b2H/XjcW4K2c9zqxvsAv+gM4jwH25P4z/c+4Nlp5BdYvyqnLnNIesHYWI0W2PtdVw4giAKALgSM+tVs9BVr8zpD0SpuMLpVrUDuvVJCZpkEWUHgHB0bcy8smpbcnKrs39ZGVIa6a6jvCcmQQ9FI/KgC7Sd45fNS4iudoj14PUv1ifsFUkUufW8sQl86AIEZx57IazIS/9SkQ5eR+nS6KY3s05LBiB2JraeysRbisZiHoKBMYey1D4axE92J4e3uz6o6pA+COx+ZY5CHSUexuC7oyw9AJ8RuKWRmaKCOzmAsFAKZmQ0EALNQrOoPTUvRjmoG8/oouyGhgEmTP1sIPLtZhf680Vf5IucqKCt7su37MSKxxcnauU1ms3kciG2X9swpMz2mfSNLoA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(376002)(39850400004)(366004)(346002)(396003)(136003)(956004)(110136005)(33716001)(9686003)(26005)(6496006)(5660300002)(16526019)(316002)(8936002)(186003)(66476007)(86362001)(8676002)(4744005)(6666004)(85182001)(54906003)(478600001)(2906002)(66556008)(66946007)(6486002)(4326008)(38100700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?V0h4RnVkVDVZY1BDdkFJeGVJS3IwZW54eVVLekxneHFnTm05NkJoZ0RQRzRJ?= =?utf-8?B?ZFZZL0VMblBqdFpCQmJlM3BvdDJDMzV2NWY1dzU1MXpsZ2wzV2JnZmxMK3Np?= =?utf-8?B?bzlUbVV6bHIrcEVDeFk0MlR1MHNDVk16bU1MbExqaXRZdXZFQTh4R2Vad0RI?= =?utf-8?B?RjkrTUF4TWZWUVVmOVQ2elJDdkRUemkyeHdpdzB1WktidTJRYXBGaHFKcm1G?= =?utf-8?B?dEw1Znh6bk1uQnVIc3lLbThTd0ZOQlpiWkZsM2NXbXZWVDRKQ1ZzWlNjZUJz?= =?utf-8?B?YmlqOGtOdXJFWnRWSmV1dllBMDZER2ZTMnN4TGpxOGsvY2wzeUFQZVAwc01D?= =?utf-8?B?WFk4YkJ3UVJ4UmJLNWp4YWpXblJlMktvYkZWTDl2N1d4cGlvSmV6bTltZUhV?= =?utf-8?B?cFpRek4vbGNpcStEdGw4VTNzTk0yMWhvWkZielR5VWlFVTY5MzVKcDJ4MFM5?= =?utf-8?B?SUw3WkNlUWR6aEkrVG8wcURoTkd6K1U0SU1ENWRpWEZSL29xRWZURjY3ZlBY?= =?utf-8?B?dzA1S2t4dnppR1lJNkMyN3FtL0cvYXpqY0RYSnd0TXMxSXJ2cFFXcGQ0UkdX?= =?utf-8?B?eGdZMlB5ZFF3MmNLNDF0Uno0NWUzMEZOT24yUml3YmlZWG9HRUhJT0V6SlNE?= =?utf-8?B?Myt4dkhNZnNKSlpwYTVUb1JwSUVDQnJwbmp6QW42NlJ3enNZejNFWi9xb0Rv?= =?utf-8?B?dkZKQTBKb3Q5UG5XWno0Ym10eDhMY3U2TDBKSWNSRS9OWENOZndaVzE5WnFL?= =?utf-8?B?dlFtV3lUTExNWHFPTGdxTTFQWm5jS0owOSs5cS9wWUZuV3YvYzQzQnJhNmoz?= =?utf-8?B?bys2Y3ZqSElWNTY0aldCZkxxYXVRRGc0UEU3a2ZYbnNyc2JXVHpwTnJyMDg2?= =?utf-8?B?ejF2VGxVZkZMa2ZTUkNKQ2hPZFN5SHNjbUJpbkpwSEhINkZwMUY1ODI2djRC?= =?utf-8?B?LzAwYkdWVVAzZlM1RElFVDdUQllzOFN0NG1oYUZ4QW11bW9RM1YxbFZ3cVZV?= =?utf-8?B?S29yUGVOejVDVnRQVDY4REFvWHhhVndidHlCbXl6Zk1WSHUzVmEvU0c2cm1l?= =?utf-8?B?TTI1UW0xTXdjUzZCZEgydDNTWjVqQTQ3MGE4T2VQa2p5eUFTcDVHQXNnb0RQ?= =?utf-8?B?RGV6cWpVUnNnazZycHRrZ2VXUjZZakhYMFMyVlM3T3hVRVQvVmNIYk9rVDJy?= =?utf-8?B?U0NsOWd0SWZlK01oZ3pOVTYvaTgxSVZ2ZEd4OHVScGpIeDZtVjhKL1VsMkxN?= =?utf-8?B?ZURmVjlDbUtUUUdGY3RNaHJ1ejVuSkZDK3ZjdDB3U0VxMWZEaXczcXFPV1Ar?= =?utf-8?B?czBmaCs3N2pjZlVPN2JOczZZVDlsU0xUYzJYUndsK3hwVHFpRzhZU0t6bHFn?= =?utf-8?B?Z0hPUktPNmpKVGI5RXcyeXhhTzI1eUt5aWkxdXdGLy93NXBpa2NvazNLVXpa?= =?utf-8?B?aUhiNWRuR1o2UEdyQWN5ZERqdnR6VVc1SmZDZGxSdmlKNWdhU2xydXkxQ3c4?= =?utf-8?B?cDRibjJvUCtVV25IWDlKZkdmOEszMlBNMW12WVBKeWhERkUvZUxweGM0QXZj?= =?utf-8?B?VEhMMnJkNWx6ZXliSGpTRE04WkhnNUtLQ29sUTZZZXVhWWsvZS94aHJ3QXlN?= =?utf-8?B?OWxIdm96TzRFbUtJLzJQaDl5R2NPVVluY2RaaERWVkt5QVNocWFqblhFVUM1?= =?utf-8?B?bk52N3BsYXpWUk1tU2J4RXFBM29wS1RyeWNtT1QyMlFnUUVxSURsOGdTNjky?= =?utf-8?Q?RL8gZ2SkacSR3wXoU7Odk5ryqZZriDsb36ySEZv?= X-MS-Exchange-CrossTenant-Network-Message-Id: 653d4cc3-4b19-4377-566b-08d8f290d64d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 08:58:35.9969 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F/JKblGBTdqDgCoF4SyR0yqkCgZ5i9jGuPUmKLcnBZUauOXu3qcHJWh9SRuclmI6zTG2QD/KPe45vxhzXU3N/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5968 X-OriginatorOrg: citrix.com On Fri, Mar 26, 2021 at 02:30:29PM +0000, Ian Jackson wrote: > These two > > [PATCH 2/3] x86/msr: Forward port XSA-351 changes from 4.14 > [PATCH 3/3] x86/msr: Fix Solaris and turbostat following XSA-351 > > have reviews from Roger. >From what I read on IRC patch 3 could cause issues with some Linux versions? I'm afraid it's not clear to me from the IRC conversation what's the issue exactly, so for the sake of not going over this again in the future, can we please have the issue with patch 3 mentioned in a reply to the patch itself? Or else it seems weird that a patch with a RB and a RAB didn't go in for no apparent reason. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 29 09:01:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 09:01:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102883.196404 (Exim 4.92) (envelope-from ) id 1lQnmC-0001Aq-QW; Mon, 29 Mar 2021 09:01:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102883.196404; Mon, 29 Mar 2021 09:01:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQnmC-0001Aj-Na; Mon, 29 Mar 2021 09:01:36 +0000 Received: by outflank-mailman (input) for mailman id 102883; Mon, 29 Mar 2021 09:01:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQnmA-0001Ad-Pc for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 09:01:34 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 084c7072-deb9-4095-9910-e0b8256b32a7; Mon, 29 Mar 2021 09:01:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 084c7072-deb9-4095-9910-e0b8256b32a7 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617008493; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=wbzUBgXsEjFdjmWmTDeSZwTEg9clsyyaZNpIn7Qj4v0=; b=QDShcupNpN4AveeqSdEJXbdoYKHMiTtOUt+oUen0wCLChMFrXiRWpOxv TCPfJSJ6CwhLX2zBxu/uxVRzEea1h0XGj4nYq6cdMDzcBSKNZ+SUpb9oe Ryk5XmCxo/llxXc+DikBX6wQzM3LERQjTrNc31M9YzdMZCFdu7c4r5I2c E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ndjtH/ZWSSQO3NMQ4+FQ0lqbUI3dXcw5UicABgI44iX4y1ttZSPs3MX41ivBLI5u3+Mw0getOG CX5Uxy76PSrhcVBKe1D5rV01s2WCNkXeoVJ7+D7Lib09pIm5eRHqGtIjqLZhcZtlpgPTVYIxiM yBnaKGnFqeuT38b520bik8c9R2MS14EuiWcTklZr3BzBqfcB0i496l4oM0K8ukU5z+Qae5qyty KakhJFCfLlQBHmk5cjVtFV0lUwnJ/ChF+WExpgJyMkGdUs+PN1REkuL/Q1/C3FaxGFNKiipt8I ySw= X-SBRS: 5.2 X-MesageID: 40204121 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:izayrqps0FX6uCZi3F+YmwgaV5v5L9V00zAX/kB9WHVpW+SFis Gjm+ka3xfoiDAXHEotg8yEJbPoex7h3LR+iLNwAZ6JWg76tGy0aLxz9IeK+UyFJwTS1M54kZ 1hfa93FcHqATFB5/rSzQGkH78br+Wv37uvgY7loUtFaSFPR+Ve4xxiCgCde3cGITVuIZYiDp KT6o5milObCBcqR/+2DHUEQOTPzuej/P7bSCULGgI97022hS6ogYSQLzGjwhwcXzlTqI1Sk1 TtrgqR3MSemsD+8DDw/Sv575NamNzuo+EzefCku4wuBRjHziqtbIRlcbWesD4yu/HH0idXrP D85y0OEu42x3TNfnykgRaF4Xie7B8er0XM5HXdoXz/rdf3TDg3YvAx+75xQ1/ixGcL+PRfuZ g7uF6xht5sIj7r2BnZ3ZzuUSpnk0KlyEBS6tI7vjhkfqY1LINKoZd3xjIyLL4wWBjUxaoAC+ dUAMTV9J9tACmnRkGchGVpzdC2N05DZyuucwwHssyR5TBcgGp0+Use3NAehXcN7vsGOuF529 g= X-IronPort-AV: E=Sophos;i="5.81,287,1610427600"; d="scan'208";a="40204121" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZVhQmvV44D8YvG1B97sSUywpFUSTb+VPgJBmOdtrYi3BxeZvsCL+pq66tCEgEqHUdWanf01SDuuaJ3l7torZPyFVdPq5QaLRCxycMMG+/xdB5QZL4LvxrpFRqt1wRQUDNoim9AgO/cuAo5F8qiekwR+56LVrk4SIRLHRVI6WMM56WfOFUqQSNJhcuGu8RSG9VU3frxbGY4t8XA/0lgu28CtkLVhfqrJf6y29uweGgbaMoIeSeDDtOQjUEaeiIiOwhAbNrEut2WIaKHFI4NkKPn7QElLIh90EhhKq39ha0aSHS5sxn0Ojtd6Tde8D7P678qOFMVLpauSlvg02qLxIIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/LBs/fBUQ874++qGKqA4NMkmnhzGgxwPpt8ehgvSyBc=; b=NumwCI+5hoytvVsuWTgWmx5xLzb9yUm1Pluk141ufEfIH8lfRKU3BD8O8hsbzx7xEncf1vctqD05ircldUilVxSX1/OBixjd/sPkTxYPX2m53jKVUoQn9qL6YgbuezXD4mxJ5Qg8+JTN03+zyXwYfdeCrlO2BdjsipIKnH/KwZEHNHVIrc1OY1YltI26bAiZxYJsTh3YhzTlqHUgLQ/N83ZrCpAZ6oB+ecxscieHbcpwz25jZtFojYwtjxssZbtJQWJhCzCBpnqf/Un3LVK6UI6mdovjxfFeRRtuG80OcFenAdpVCfsdrL+OVD13KIWPLm/rHHUsBtCeXULM6sEh/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/LBs/fBUQ874++qGKqA4NMkmnhzGgxwPpt8ehgvSyBc=; b=We/+C9SUDYQbE8ju+60GYNCT7U0zkx/litkp6y+u7zUsPJPnRrP/xRnQNHufwzjSRuiCCb24dPN556b5P1nmUEYlxhN4+vhb7v3Fdtlt7QJmCPv/iZCwpVfD5WtUvVKqeE4aSzigsZM9PDNkG/Yu7/7U+Bu1QLwt7WtHaDX9XeA= Date: Mon, 29 Mar 2021 11:01:23 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Xen-devel , Ian Jackson , Wei Liu , Doug Goldstein Subject: Re: [PATCH 1/2] tools: Drop gettext as a build dependency Message-ID: References: <20210326134558.7751-1-andrew.cooper3@citrix.com> <20210326134558.7751-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210326134558.7751-2-andrew.cooper3@citrix.com> X-ClientProxiedBy: MR1P264CA0009.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2e::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d1156b57-19f1-4117-1074-08d8f2913db4 X-MS-TrafficTypeDiagnostic: DM4PR03MB5968: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1091; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rwlNn/+z/xz9OBul71ourmuf8MqQuO1gedCPZUPRm5hX2qrCPS2rV1u+OuZt8ohd5UvaMfmk3uIn47wn5GaA99m0+6HzNxN9B+Tud4s36hwGPxF+BteRInwQbvTnWuvlRxkCJDoAe2qAD64Wuvk0G/LSZ2tPyf7epLFipUb5f/3cCw9hjQcU+ENT7pNEn6hAm8GRN2NNtnWHW0Hr2lisb395Fsi2pGsuDX1+0uo0vGxf/fe7cGNyJIqV7gqmiH3bBvNeAllCUIolCmwI1xqBv4qhiNQ2qNJv8GZFcZJ5IiRYAGn3e1/9HAC99VaRc+BO81LGd8r5/E5ajD2eeNSb5m2Nh0vICz6mA/QTR2To1Rl6arqpm/H97WnJ2RRf7mnjUDbKa1KB4C2/dzLbQL0AoLGFvg6AXXwipeChd0dbnkcF4YqXC58G0QKiPeTKdEn8rxCmceHsJAjdSdDY+qDEgUbLVeHKNIvmy7kB8cZ35eyH4UPP+7fnzt6Yu9upZy7ckSgFDV+fZRTYih5n4YyLh2NezqHtd3JPVaUkIeB+oQLjsnb/kEEFvKFFGL6qyqOBhqjhMlMj5vf19qy378tM10sjuqjnGJY6a2HZ+iWsGJp07Bb5lnRAgN6qR51zE5Lfi7o5iLLIHTxOZyWNaCnHb1vJ0ycrooD3vZDymfpywA4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(376002)(366004)(346002)(39860400002)(396003)(136003)(956004)(33716001)(9686003)(26005)(6496006)(5660300002)(16526019)(316002)(8936002)(6862004)(186003)(66476007)(86362001)(8676002)(4744005)(6666004)(85182001)(54906003)(6636002)(478600001)(2906002)(66556008)(66946007)(6486002)(4326008)(83380400001)(38100700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?M1dqVEdjc2U2R2xCc3hZSE1nSUgzVGZYUVYrQ0ROU2Z5ZXF0UmVhYWJSVUxi?= =?utf-8?B?SndISW0wRFRHQTFBY1dzMVArTFRFRHE0YXUxdzA0YldPTHhuWXZOMExwSHJB?= =?utf-8?B?OUJjdW1OUVdSUDVUZUdlY3U2Q3d4V3NKemZuTExUcWNoa05qWEZVeTBoQU9W?= =?utf-8?B?SENLV0VjRnBHakN6TDVxVjVRY0ZpM3FFTEdmdk9wL293TzgwZ2psbVJYUTlT?= =?utf-8?B?RjFjYU5kazVpZTl0blcxVXM5VUhaREo0Vzlnc2pxZVpJSWRCZkl4c1hhVW9F?= =?utf-8?B?VHlTaHhCSEcyMkxVSGhzYytZdEJFR3pCVkovSERkS1Azd01BN1NlQzJ2UGNK?= =?utf-8?B?V213UG1yUFA3akpuakNPdTlyS3dLZVFrMnk1NE9DSThDVU5HaENyU0pGaDB4?= =?utf-8?B?RlFSUStEQWxHUGJGOWFZK29ON3hmbkh3RkwzQ3IvazliWG83Ti9kMGtwRkZE?= =?utf-8?B?NlhkWlZMNytIekUwV0dFSk9rSVUyUldmdktmMkJwVXRUVWk0T2Y4enVyVjZH?= =?utf-8?B?OFA0UzR5SG8zdGFCVXNHSmswQnM1dTNnWEN1ZEZKWk5oc3hGNitBZnNJQTdn?= =?utf-8?B?cW1JOEdOanJQUHhmR24wYW54bGszT3l3TkVlYTQ3U0ptRjA0WEFlVi9Pd1g0?= =?utf-8?B?cWo5dytCcjBVWkdPbUQ5Q2cwTXdmVTVZczU1ck9MWG9xYzdEMm53cnk2Q2NI?= =?utf-8?B?TXYwaWFNSkF3NitUdk9MWE5sbG9nMENTbTR5aFBKR1Z1Vk9sY0gyQmxldFV1?= =?utf-8?B?MXJBUi8xN0FUS2NTVHhVc3Nhc3pHUDRGVHpKTnY3SDlxQ2pzSk5UYkV3UU4x?= =?utf-8?B?MVZpTXhaYmZsNkIrNDZDK3R1RHVnTHhLZUkxL2tmOVpXbE4vUFVPcVVPR3Jx?= =?utf-8?B?MjRMaDQzU1JJcUZUU0VIeWw0NGtFVm1SMG5Rblg2OE1QZFJ5UFZjQ0RJb240?= =?utf-8?B?SlVzU3ZubkVwRlRxaG95TXg0VW5FSjRrbCtjL3NPcXowZ1ZCWXhZSlR2YVJp?= =?utf-8?B?WmhyWEcycEJnZkViMFRQWEJFdk1RclZOMnduTnh3Y3hNemJ1WTNGdVJDMXM0?= =?utf-8?B?ZXlhanpaWmJPaEdTWU11MElReHFqdGdydndzalMzVGo1anhicEdQSmdXWWM3?= =?utf-8?B?QVR0ZWU0NkhMWWZJSm5iYXFzZlRHVXdtZ3dTQjl4VlBIQjlqc3dDR3Zvd05O?= =?utf-8?B?cEZOci9tZXY0cEd0V0tHOFNiSkZGc2daUy9zN3N4K0NsNlRnNEFBQldiQTBS?= =?utf-8?B?VUdpRFY0b1M1RmMwYm8xUXZGTWlnSWx3RGZaQjhscjFXenA5NXVIZW9leVlG?= =?utf-8?B?aVBBT0g1bmJYa2xlRmp2VnFNUEhkek5oNG9paFVmQ0xqcldnaTV3VFJNNy84?= =?utf-8?B?N1AxOEFCQktoOHJGRmQyQzJWODVFN1lUVE8vb1RnWFJyTzREQXRzbjJuKzdj?= =?utf-8?B?S1ArMzVGSG1UOTA2K0hTNWw3TXdIRmtud1cvMVhZL3Jhd2RhQ0o5bWNKVER5?= =?utf-8?B?WldXeE04ejZYa29hL2lkN21OZFBXSVhQem1YZFo1Q1krSFdxTWFCbE03VWZt?= =?utf-8?B?azNIZ3RpZXdPNkc4Q05BaTBxQ3Q1UHpxVFVqVHc5c2s2OVMrZGZ5ZVQ4ZTIr?= =?utf-8?B?cFFWY0g2U3JkcmVzSW15bjFFTzJ4RXh3TVBXeTZpcGplTTBvbXBFanpBaFk5?= =?utf-8?B?eDJmdXl5cWdWZnYvZjJyL3FqNkk5bkJ1STZpbUxRM1hWOGJGWHdTQzdVbnRS?= =?utf-8?Q?ZLbYQ/qMFQp8rOI/+JeSTh0Veq2l8kU35k9yxMf?= X-MS-Exchange-CrossTenant-Network-Message-Id: d1156b57-19f1-4117-1074-08d8f2913db4 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 09:01:29.3500 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9sEbBlEWxJXA6MhIYnMv7X6+Dg/b9huQ7fy91j0qQoPfcPU4IZkd4aux+qfKwN7wYuFjdJarBwOYcHbQKr5l3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5968 X-OriginatorOrg: citrix.com On Fri, Mar 26, 2021 at 01:45:57PM +0000, Andrew Cooper wrote: > It has not been a dependency since at least 4.13. Remove its mandatory check > from ./configure. > > Annotate the dependency in the CI dockerfiles which are used for 4.14 or > older. Drop the dependency from Alpine and Ubuntu Focal which are new > containers in 4.15, as well as dropping from CirrusCI and TravisCI. > > Signed-off-by: Andrew Cooper Acked-by: Roger Pau Monné I think it's worth mentioning in the commit message the component that required xgettext in the past. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 29 09:23:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 09:23:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102896.196423 (Exim 4.92) (envelope-from ) id 1lQo76-0003NK-Mo; Mon, 29 Mar 2021 09:23:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102896.196423; Mon, 29 Mar 2021 09:23:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQo76-0003ND-JW; Mon, 29 Mar 2021 09:23:12 +0000 Received: by outflank-mailman (input) for mailman id 102896; Mon, 29 Mar 2021 09:23:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQo75-0003N8-Jd for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 09:23:11 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 19ae104a-046d-4999-80d7-5804b1253dbb; Mon, 29 Mar 2021 09:23:10 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C19E5B3C6; Mon, 29 Mar 2021 09:23:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19ae104a-046d-4999-80d7-5804b1253dbb X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617009789; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VcBuQRcfoLaKj/rPC16xUMpz+pqVC9dTsmVWLgRfSjs=; b=RHfeSWAQvj09PGdgSBGuFA9Yi59wQK5jj9tFRpM0TpiBPIT4TQnT6eETo2xcJ1uLyrI6yN ZCMiUEGjQdDa76/M/o0UMC5HT5Ix16QgxdthnD6XiQV873QtBtH5qGhrhgRgrCDFlVd9oS nH8HYhA6k1atv8ppgPWpRrI47yYCc0s= Subject: Re: [PATCH v2 3/3] x86/hpet: Restore old configuration if Legacy Replacement mode doesn't help To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , Xen-devel References: <20210326185947.23243-1-andrew.cooper3@citrix.com> <20210326185947.23243-4-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <9916882e-c31b-4943-13b5-702380325ae1@suse.com> Date: Mon, 29 Mar 2021 11:23:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210326185947.23243-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 26.03.2021 19:59, Andrew Cooper wrote: > If Legacy Replacement mode doesn't help in check_timer(), restore the old > configuration before falling back to other workarounds. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > CC: Ian Jackson > CC: Marek Marczykowski-Górecki > CC: Frédéric Pierret > > v2: > * New. > > For 4.15: Attempt to unbreak AMD Ryzen 1800X systems. > > I'm tempted to fold this into the previous patch, but its presented here in > isolation for ease of review. Both combined Reviewed-by: Jan Beulich (i.e. I think they strictly should be folded). Just as a (further) consideration: While I continue to think that undoing immediately is what we want, I wonder whether every further fallback attempt wouldn't want to also be accompanied by trying if it _combined_ with legacy replacement mode actually helps if alone it didn't. Perhaps we want to cross that bridge only if we get a respective report ... Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 29 09:57:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 09:57:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102904.196434 (Exim 4.92) (envelope-from ) id 1lQodo-0006Wq-9R; Mon, 29 Mar 2021 09:57:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102904.196434; Mon, 29 Mar 2021 09:57:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQodo-0006Wj-6D; Mon, 29 Mar 2021 09:57:00 +0000 Received: by outflank-mailman (input) for mailman id 102904; Mon, 29 Mar 2021 09:56:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQodm-0006We-TQ for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 09:56:58 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 71d49137-e3ee-413f-a418-ffc3d32b1a08; Mon, 29 Mar 2021 09:56:57 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1CD8DB458; Mon, 29 Mar 2021 09:56:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71d49137-e3ee-413f-a418-ffc3d32b1a08 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617011816; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4VR1iVy6u40PBqoLa2t7L3HKx1ALmz/o0fg2m/ck6hA=; b=rMiR1K9INUEPbsUxHknwcnK1ISmeVkHc6wP3DXT25m2mtTHP2T7HSxJMROjR1VfHmGnK59 38vIIQYHLCMs2VTyd86kb5e/JSAgszHhApt/98IIiqLrWGfq/3+TH8EcH5Ff4hJJ5h+CLc DApiCNtu+T47WV4wVqrDjZJXkRf2nKE= Subject: Re: [PATCH v2] x86/vpt: Do not take pt_migrate rwlock in some cases To: Boris Ostrovsky , roger.pau@citrix.com Cc: andrew.cooper3@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com, iwj@xenproject.org, xen-devel@lists.xenproject.org References: <1616809866-30837-1-git-send-email-boris.ostrovsky@oracle.com> From: Jan Beulich Message-ID: <82868938-bf57-25c2-38f6-1ec8e9c92362@suse.com> Date: Mon, 29 Mar 2021 11:56:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <1616809866-30837-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 27.03.2021 02:51, Boris Ostrovsky wrote: > Commit 8e76aef72820 ("x86/vpt: fix race when migrating timers between > vCPUs") addressed XSA-336 by introducing a per-domain rwlock that was > intended to protect periodic timer during VCPU migration. Since such > migration is an infrequent event no performance impact was expected. > > Unfortunately this turned out not to be the case: on a fairly large > guest (92 VCPUs) we've observed as much as 40% TPCC performance > regression with some guest kernels. Further investigation pointed to > pt_migrate read lock taken in pt_update_irq() as the largest contributor > to this regression. With large number of VCPUs and large number of VMEXITs > (from where pt_update_irq() is always called) the update of an atomic in > read_lock() is thought to be the main cause. > > Stephen Brennan analyzed locking pattern and classified lock users as > follows: > > 1. Functions which read (maybe write) all periodic_time instances > attached to a particular vCPU. These are functions which use pt_vcpu_lock() > after the commit, such as pt_restore_timer(), pt_save_timer(), etc. > 2. Functions which want to modify a particular periodic_time object. > These guys lock whichever vCPU the periodic_time is attached to, but > since the vCPU could be modified without holding any lock, they are > vulnerable to the bug. Functions in this group use pt_lock(), such as > pt_timer_fn() or destroy_periodic_time(). > 3. Functions which not only want to modify the periodic_time, but also > would like to modify the =vcpu= fields. These are create_periodic_time() > or pt_adjust_vcpu(). They create the locking imbalance bug for group 2, > but we can't simply hold 2 vcpu locks due to the deadlock risk. > > Roger Monné then pointed out that group 1 functions don't really need > to hold the pt_migrate rwlock and that group 3 should be hardened by > holding appropriate vcpu's tm_lock when adding or deleting a timer > from its list. I'm struggling some with the latter aspect: Is this to mean there is something wrong right now? Or does "harden" really mean "just to be on the safe side" here? In the latter case I'm not really certain we should add such extra locking, in particular if any of this might be on a frequently executed code path. Leaving respective comments there instead might be an option. > @@ -543,8 +554,10 @@ void create_periodic_time( > pt->cb = cb; > pt->priv = data; > > + pt_vcpu_lock(pt->vcpu); > pt->on_list = 1; > list_add(&pt->list, &v->arch.hvm.tm_list); > + pt_vcpu_unlock(pt->vcpu); I think it would be better (not just code generation wise) to use v here. > @@ -580,13 +593,22 @@ static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) > return; > > write_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); > + > + pt_vcpu_lock(pt->vcpu); > + if ( pt->on_list ) > + list_del(&pt->list); > + pt_vcpu_unlock(pt->vcpu); While these two obviously can't use v, ... > pt->vcpu = v; > + > + pt_vcpu_lock(pt->vcpu); > if ( pt->on_list ) > { > - list_del(&pt->list); > list_add(&pt->list, &v->arch.hvm.tm_list); > migrate_timer(&pt->timer, v->processor); > } > + pt_vcpu_unlock(pt->vcpu); ... these two again could (and imo should), and ... > write_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); ... really this and its counterpart better would do so, too (albeit perhaps in a separate patch). While I see that pt_adjust_global_vcpu_target() (the only caller of pt_adjust_vcpu()) already avoids calling here when the vcpu there doesn't really change, I also think that with all this extra locking the function now would better short-circuit the case of pt->vcpu == v upon entry (or more precisely once the write lock was acquired). > --- a/xen/include/asm-x86/hvm/vpt.h > +++ b/xen/include/asm-x86/hvm/vpt.h > @@ -129,10 +129,10 @@ struct pl_time { /* platform time */ > struct HPETState vhpet; > struct PMTState vpmt; > /* > - * rwlock to prevent periodic_time vCPU migration. Take the lock in read > - * mode in order to prevent the vcpu field of periodic_time from changing. > - * Lock must be taken in write mode when changes to the vcpu field are > - * performed, as it allows exclusive access to all the timers of a domain. > + * Functions which want to modify the vcpu field of the vpt need to > + * hold the global lock (pt_migrate) in write mode together with the > + * per-vcpu locks of the lists being modified. Note that two vcpu > + * locks cannot be held at the same time to avoid a deadlock. > */ > rwlock_t pt_migrate; It looks to me as if some information got lost here, most notably the scope of the write lock and (somewhat related) what holding the lock in read mode protects against. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 29 10:31:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 10:31:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102933.196471 (Exim 4.92) (envelope-from ) id 1lQpBE-0002SP-IZ; Mon, 29 Mar 2021 10:31:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102933.196471; Mon, 29 Mar 2021 10:31:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQpBE-0002SI-FN; Mon, 29 Mar 2021 10:31:32 +0000 Received: by outflank-mailman (input) for mailman id 102933; Mon, 29 Mar 2021 10:31:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQpBC-0002S7-1X for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 10:31:30 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 31a5af57-5739-4827-b8a4-0da5774e7aaa; Mon, 29 Mar 2021 10:31:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31a5af57-5739-4827-b8a4-0da5774e7aaa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617013887; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=2nb+IktYmurXxKAkwpddUG9ewSLY5+OvI6LU6HUoWNk=; b=ijNAS3fpY1e1Wms1YTaOuDdgfDkEMMQFJyg0hCt8UxgFVnnTA6FhpiAe cWEep8iO063avJhNphH7gAb0BMRG+3NghoG2tWK5AOA8uAQxkhMKxbNk4 t9vZsncOGGDADje5NJxJSJMb0WfLaylkpK70UGvUroz+CWHAjgs7QkxYN o=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 1divU9kWANyTkM6K86xItzMAjAqMPveCtVC4eXF9+Zkv78y77VpbFEj4M2425VmHiodALCPIOE gG2Z1hAbJ8Qgurzoco0qCnOpkTuVShMw3cOUe+QQFVO3HWms8cVNQsSjxKgSYgbvKfT/yiqwMG G/f7YStsqAgzcGP8vTEjvlQKN9kUPy3059d01GBzhyaMjwLXj8AK/pyiAf7vRAUo9Fcc+9gxWu 1u75McpLvoOsweOkFxuvNN3dqihsf98q9WItGs9/K9Q2myHrrORluiUO4G92TGr0+ISO1c5XzI U2s= X-SBRS: 5.2 X-MesageID: 41777567 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:KD7aNKmX275P2XZz7mk7XFNDDDzpDfOej2dD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLN+AZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 hdWoBEIpnLAVB+5PyX3CCRD8sgzN6b8KqhmOfZyDNXQRt3brx7hj0YNi+wOCRNNW97LLA+E4 eR4dcCijq7YHIMbtm6AH5tZZm/m/TgkpX6bRkaQyM94A6Vgj+yrJL8GR6U3hAROgk/vYsK22 7DjgD/++Gfo+i2oyWsrVP7wrZ3vJ/aytVFDNGRkcR9EFTRoyuheYgJYczmgBkbu+eqgWxa9O XkgxBlBMhr7mOUQ2fdm2qT5yDF8BIDr0Dv0kWZh3yLm72LeBsfB9BajYxUNjv1gnBQxO1U66 5A02KHu5c/N3qp906Rlru4NWAeqmOOrXUviuIVhXBEOLFuE4N5loAD4FhTVK4JASOS0vFWLM BVEMre6PxKGGnqFkzxg28H+q3KYl0DWj2CQkQEp/WP1SlXkH1T3yIjtb0it0ZF25QnR5Ze4e PYdoxuibFVV8cTKZlwHeEbXKKMeyPwaCOJFFjXDUXsFakBNX6Ig5nr4I8t7OXvXJAT1pM9lL nITVswjx99R2veTem1mLFb+BHER2uwGR73zNtF2pR/srrgAJL2LCyqUjkV4oidisRaJveed+ e4OZpQDfOmB3DpA5x10wr3XIQXAWUCUfcSps0wVzu104L2A7yvktaeXOfYJbLrHzphcHj4GG E/UD/6I9gFwVusXlP+nRjNS1LgckHy5vtLYe3n1tlW7LJIGpxHswATh1j8zNqMMyd+vqs/e1 Y7AL6PqNL+mUCGuULzq0l5MBtUCUhYpJ/6VWlRmAMMO0ToNZIKu9CVf3FuzGKKTyUPCP/+IU p6nRBa6Ki3J5ufyWQJENS8KF+XiHMVuTasQ4oDnLaAoePoYIkxAJpjeKEZL3SLKzVF3SJR7E tTYg4NQUHSUhn0j7++sZASDObDM/9mgAmqJsZQgWnFtVqVoPwuQndzZU/tbeenxSIVAxZEjF x49KESxJCanyy0FGc5iOMkdGFXZH+vG7JABgSdbIBykrTmETsAC1uitHi/sVUea2Dq/0Idii jEITePcf/GOFZbp0tVy73n6l9ya2WbcX9hc3wSi/wOKU32/lJIlcObbKu61GWcLmEPxewQKx npSzofKAEG/aH86Del3BK5UVk2zJQnOeLQSIk5e7bIw3W3NcmjjqcdBcJZ+55jKfHjuuIGSv ikZgeQNT/0YtlZgjC9lzIAAm1ZuXMkmfTn1FnZ92C+xmc4GueXD1J8Rb0XSuvsplTMdrKt6t Fegt00t+frbTm0Rd6C1K3NbzlMbjnUunW7Suk0qZZS+YI+3YEDaKXzYH/t7jVg2h57EeLf0G U5a45/6KraOoBuc9cJEhgptWYBpZCqFg8TrgfyAuUCZlkjgH/QAsOR79Pz2M4SK3zEgDG1BE KW/CJc9crURiev1bYVDKQrPGRdAXJMnkhKzaend4fKDh+tePwG1F2mMmWleLs1ctnJJZwg6j J76cqPhemZam7R3x3RpyJyJuZr/3y8Sc2/RCKKFuggya33BX28xo+r6tW0ljH5VH+SbFkZn5 RMcQgoVft44wNSxLEf42yVUaz4okUsjltY73VGrzfWq/abyVaeO1pHPw3fiohRRh9JPBGz/J z4zdQ= X-IronPort-AV: E=Sophos;i="5.81,287,1610427600"; d="scan'208";a="41777567" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S8c8wA9tuzMpPUH3vUK7Oli0BmooeTUtPN8M7nykxT1iK4XtRsJ3dLkedaFzs1lx0vJeVFcH8XcRYBXDk+OUW9qi8GlbW5Up/OdaPNy5BlN0Rlq0/t5qc/peAzzzVefq4Pgs5wft2SVsV/gvUNdq3WVBqoCRA4nSBbbtnwBW7tzTmZfItZ6zzMqI0vxjbDIhZjInEgIXzf43TRhdAYZ50yBCc0N2bnygZ8PKz0pRDogC6UkHAC/pxxxOIZS9DDVQLp7HrqW/D/eCf3z76oqFNAFW6L0Z2jdYC2XmPDuzUClE7HWwL+Mu40Y5vZEAgtSHFyheStF/npNH9FEQVm+NnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MGJeBm3UaA8G4RqQ+ge9B57rYVXALhNtPu9waKz7J74=; b=ByTLiDczHFvF7AIuCTJqmPGlyezABMQ97D/Vw1j/NGBT+dGFikC/z6GWjVcKtN3na/fvZ9olonDAh9BJE6h5WqcFIo/e4uB/A3CtC1JBrWubxLtW5T4g5gLn8IBo1Wr2xtNnZJSaH0lx+W9TmbwvjzL/rfSF4Kaza9LV6dxAJuw3PBzcct9entel6jdxPvvP3gHhbBUmeDZ8bfR1WF7rNYFheRCEtJfHK8UN216m5pAOmDqNw/7ENkNs/38SIL57WEnOy6tb3yTpkTGHeIUti7NyNhYyXb9flnXQxQcoPaKAeU6PMXCBzbsOFUVPz+xEZT2wTf5tz3OhkNRYb2d0Yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MGJeBm3UaA8G4RqQ+ge9B57rYVXALhNtPu9waKz7J74=; b=S62tCxLDqRWNZRQxXSxii6A7HxEWWmjJ7M1qw/zl9lpNM/FetjmaFCoLvpblTz5QlDEJYYie6itnRR9hE4com3oel35fZVnhikBk/H/Ys4i0x1xOg+kXvo/opCHYAkAIPqUFn9Hlaiosi/4JQztK3uLyrWezL2vqyO6Xje4JMPk= Date: Mon, 29 Mar 2021 12:31:17 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Boris Ostrovsky CC: , , , , , Subject: Re: [PATCH v2] x86/vpt: Do not take pt_migrate rwlock in some cases Message-ID: References: <1616809866-30837-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1616809866-30837-1-git-send-email-boris.ostrovsky@oracle.com> X-ClientProxiedBy: MRXP264CA0027.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:14::15) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 176038c5-a60f-47ac-9c0a-08d8f29dcd6a X-MS-TrafficTypeDiagnostic: DM6PR03MB4841: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: myH8/DrX/ho9kdcycXcqVrrPi35LgHLdCFyiwLKKnRUD4DDOCI5C9jFLel0n0iO+pndp96pb7KcUqAJhO3fM865DrkIokwBDhEEwFWEw+WGymprUFYhosw5UmT4/v2wKoLsZQTPK5sDi77uGFHx5if19I4Tkda4rwzrOc9ovIoA4dc1MOXQ2TKqWZ984KsYgSIN9LJEfmKOclx0Ots42vTfqrVhUTeMRjFc4ybWCcIwnH0UnrZvF0Yn+Zz9WXusfQlEmJC2DlIiFkqZ/cjmLEPctTeopeSkTrdaN+EkJdtJsnc53HYeXHfIKTd7MobPVP73MBTQyfh8d2Br56dMhXYugAworOZhWCRXuNDm3M85//+qVhsIQgBXiKWPAEUmX9E48RRfff6XwkrwCPF8LtTLvgWnWVSDiOCFTgiT1DiVrVSEsmi50iQ+q/B4WHJ8LfKKYrxyKkhaTb/3MKAK8DCf4DvK0Nudi08p5mvX7sCFDwECD7gYLxMhoKUSn0qDxrKgOVrUxQBckmjrQTBe2zb+w0aVeSNuTcT3YcuvM47+RcwnTRTs6kpxIdxI315Nw3H7bqSNFUg8/TJuWeETCrwGBBaSePJCb7ufxUJMaSKwvVtRTC3GtU4edTQNRQv4LVZeFiVfYOX+/mGEP47i3F3RdcvRec6DWFfMOpN4El2Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(396003)(366004)(39860400002)(136003)(346002)(376002)(4326008)(66946007)(66556008)(956004)(66476007)(478600001)(26005)(83380400001)(9686003)(86362001)(8676002)(6916009)(6666004)(316002)(8936002)(6496006)(38100700001)(85182001)(5660300002)(6486002)(16526019)(186003)(2906002)(33716001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MTJzcnh4dlVTd0dHdDc4K0x3QkI2RWE1ZVdDeVRDeWkwbm1Jb3JOelNVS2hQ?= =?utf-8?B?bGFhcXdqTi9DdGIycW9DaVpNdXVjbDJhYlltOExCOStTOWlEM0NuMlR0eDRD?= =?utf-8?B?QVYxdXRqMks0ci9mdU5VaFRmSmM2NzlVM3RickZXQ3JFajBldDE3Q3dNbEtR?= =?utf-8?B?eTY1R2JvTC9MVlVUOFJPUmZHQVJSZEtsTG94ajg4WXhEZHlETnFFTzgvZ3Ar?= =?utf-8?B?WGRIN2JNMWVwdHRGQUVqMng4eTIzc1dsV2lTeFp5OFE0N1hPNTlvSWlBNmdJ?= =?utf-8?B?aWVIZndXSWo1aXRITHBFbEFQNEhnUlZWTTZVQ25aRFlCZFk5M3JKT3h2a1Rr?= =?utf-8?B?dEQ0UFJHalJsUHE4TFRxMjVYOXVBVkcyTWhNUXJtVU1FS2toUmRNVFllaDNE?= =?utf-8?B?VjI2NzFtRUNXb3ptN3l4TnBtZ09aKy9JdGU5bFRqL1pTR1pwSC90YTNYRDhq?= =?utf-8?B?K1N1dkRKeUE5bk5WeitUWnIreGExZVlmaUxFSitPYW1nd0QxMXBndCtyNjl1?= =?utf-8?B?Zzh2ZzkzK0hCT211OFl1SUFTRGUvdDM2cHVYK0VoNXpRdXBQOHhLZjNtSXF3?= =?utf-8?B?K3c5d056YzhEbHoxY08zUGRaQ3Zock1aN2lPU0VJVDI2cEJNVGFSTVZRSUVk?= =?utf-8?B?ZWtHeGh4S2pGVVdIMVR0MnlUSVU2WHMzd0k0WEhxV1p4MjZ0bUgrb3lubW82?= =?utf-8?B?UmxHQk92SEgxSjYwcU1LQVp1L1FmNy9QR25ZbklDYXlOWktud3VTQ3Mwd1dr?= =?utf-8?B?cnBKRjV0SUJSQXFBbHNsL2ZUb3QwcXNNQTI0dXA3Z1dkeEx3RDR3UkIzTFpv?= =?utf-8?B?MWhKUDNxZHlxL1lEMUtIZkdYL2JWOXdUNm40ajlJcmY5VVpkVjlRcHpnYlcv?= =?utf-8?B?Smx4Y05IK3VSOW42MkRBUFpQZ1pPSDMxb1lKZU1KN2JjUGN4RTJjMk9ZUHdS?= =?utf-8?B?dEtkWUN1WHphMm9XSmZ3aFQ2ZElJVmF3S1p1dEdpUFlISlpRK1ZNekR3Q3RD?= =?utf-8?B?U2grbmxYV0JlMkVveU4yc2pBdlBBQ3JiSCtsODBwMFVXdWIwTVBxSUVtMHh1?= =?utf-8?B?VFhuYlR4NWVlK1cxbVU5ZHNkSUJEOTNBRFdSejNJS1JyY3M0WGljbmt5MExr?= =?utf-8?B?alhIbTcyWXJ6aE9NQjhMNy9sWTRLaXI0VG5LTlgwYzR1UEdSaDhwMjg4NDRS?= =?utf-8?B?T1Y0ZENZYi9wMUVSaG9hNWozaUpYN3ZGbE5lM3pSZlNIZzZGNHFUR0RrQy9S?= =?utf-8?B?UmNSM2VOd1pNbmNmemxJdlVsM01RaUtXOXM3d0dKU29vZ0oxVFYwQjVGaVNv?= =?utf-8?B?bWRTZ1NTRnRScnA5dDdCVUpKamFyRy90Y3dlWklPS0JkV1c4b2Y4VUR0Y2pu?= =?utf-8?B?WG9VMlluL2xwdUhFMElhdy9XSEJYN2txUWFRc3pSQWhodlV4dHQ2bndiZmVV?= =?utf-8?B?SjJUUW4wRUdLeGFHL04xWDVqNG82VHVKMmNVZWEzdXJZOHRPem55V0wwdllM?= =?utf-8?B?cVdYMjBTb29ZYjE4ZXk3bnFTd1JicE4vWTh3T2VORVVKN2ZKZWM1MGJIOXo1?= =?utf-8?B?ZytqMGNxdjVrVnlqejU0QmZkSm5CNGgzSlBYVjIyZXpoQVY4a1FMZjllMmQy?= =?utf-8?B?Y0dhZ2FOMXhpWGRQek13V2VSMFZocVZ6ZnFodGljdmVTc0RoNEYzL3NXOWUr?= =?utf-8?B?TlVzL09tVGs2czRLOUMvY05LZ0M2NUNKYlZGK1pVbTk2cG1MeHdBTVI2MEY0?= =?utf-8?Q?gKQv4cP6zYecqGeLj2FR3IRS+/Ix/uMLopPfToy?= X-MS-Exchange-CrossTenant-Network-Message-Id: 176038c5-a60f-47ac-9c0a-08d8f29dcd6a X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 10:31:24.4701 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2E/aEzcKOG7y3vcnyOJckRSTci/FL9TJiDrCZAG5LkuCYjHXF7V7skEoHu5ZHzwbBiROcIsSvVTysdVz1kblDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4841 X-OriginatorOrg: citrix.com On Fri, Mar 26, 2021 at 09:51:06PM -0400, Boris Ostrovsky wrote: > Commit 8e76aef72820 ("x86/vpt: fix race when migrating timers between > vCPUs") addressed XSA-336 by introducing a per-domain rwlock that was > intended to protect periodic timer during VCPU migration. Since such > migration is an infrequent event no performance impact was expected. > > Unfortunately this turned out not to be the case: on a fairly large > guest (92 VCPUs) we've observed as much as 40% TPCC performance > regression with some guest kernels. Further investigation pointed to > pt_migrate read lock taken in pt_update_irq() as the largest contributor > to this regression. With large number of VCPUs and large number of VMEXITs > (from where pt_update_irq() is always called) the update of an atomic in > read_lock() is thought to be the main cause. > > Stephen Brennan analyzed locking pattern and classified lock users as > follows: > > 1. Functions which read (maybe write) all periodic_time instances > attached to a particular vCPU. These are functions which use pt_vcpu_lock() > after the commit, such as pt_restore_timer(), pt_save_timer(), etc. > 2. Functions which want to modify a particular periodic_time object. > These guys lock whichever vCPU the periodic_time is attached to, but > since the vCPU could be modified without holding any lock, they are > vulnerable to the bug. Functions in this group use pt_lock(), such as > pt_timer_fn() or destroy_periodic_time(). > 3. Functions which not only want to modify the periodic_time, but also > would like to modify the =vcpu= fields. These are create_periodic_time() > or pt_adjust_vcpu(). They create the locking imbalance bug for group 2, > but we can't simply hold 2 vcpu locks due to the deadlock risk. > > Roger Monné then pointed out that group 1 functions don't really need Roger alone is fine, or else it would have to be Roger Pau (Monné is my second surname). > to hold the pt_migrate rwlock and that group 3 should be hardened by > holding appropriate vcpu's tm_lock when adding or deleting a timer > from its list. > > Suggested-by: Stephen Brennan > Suggested-by: Roger Pau Monne > Signed-off-by: Boris Ostrovsky Reviewed-by: Roger Pau Monné Some nits below. > --- > v2: Drop per-periodic_time spinlock and keep pt_migrate rwlock (and thus > change patch subject) > > xen/arch/x86/hvm/vpt.c | 40 +++++++++++++++++++++++++++++++--------- > xen/include/asm-x86/hvm/vpt.h | 8 ++++---- > 2 files changed, 35 insertions(+), 13 deletions(-) > > diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c > index 4c2afe2e9154..893641f20e1c 100644 > --- a/xen/arch/x86/hvm/vpt.c > +++ b/xen/arch/x86/hvm/vpt.c > @@ -153,32 +153,43 @@ static int pt_irq_masked(struct periodic_time *pt) > return 1; > } > > +/* > + * Functions which read (maybe write) all periodic_time instances > + * attached to a particular vCPU use these locking helpers. I would replace 'these' with pt_vcpu_{un}lock, to make it clearer. > + * > + * Such users are explicitly forbidden from changing the value of the > + * pt->vcpu field, because another thread holding the pt_migrate lock > + * may already be spinning waiting for your vcpu lock. > + */ > static void pt_vcpu_lock(struct vcpu *v) > { > - read_lock(&v->domain->arch.hvm.pl_time->pt_migrate); > spin_lock(&v->arch.hvm.tm_lock); > } > > static void pt_vcpu_unlock(struct vcpu *v) > { > spin_unlock(&v->arch.hvm.tm_lock); > - read_unlock(&v->domain->arch.hvm.pl_time->pt_migrate); > } > > +/* > + * Functions which want to modify a particular periodic_time object > + * use these locking helpers. Same here, I would use pt_{un}lock instead of 'these' to make it clearer. > + * > + * These users lock whichever vCPU the periodic_time is attached to, > + * but since the vCPU could be modified without holding any lock, they > + * need to take an additional lock that protects against pt->vcpu > + * changing. > + */ > static void pt_lock(struct periodic_time *pt) > { > - /* > - * We cannot use pt_vcpu_lock here, because we need to acquire the > - * per-domain lock first and then (re-)fetch the value of pt->vcpu, or > - * else we might be using a stale value of pt->vcpu. > - */ > read_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); > spin_lock(&pt->vcpu->arch.hvm.tm_lock); > } > > static void pt_unlock(struct periodic_time *pt) > { > - pt_vcpu_unlock(pt->vcpu); > + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); > + read_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); > } > > static void pt_process_missed_ticks(struct periodic_time *pt) > @@ -543,8 +554,10 @@ void create_periodic_time( > pt->cb = cb; > pt->priv = data; > > + pt_vcpu_lock(pt->vcpu); > pt->on_list = 1; > list_add(&pt->list, &v->arch.hvm.tm_list); > + pt_vcpu_unlock(pt->vcpu); > > init_timer(&pt->timer, pt_timer_fn, pt, v->processor); > set_timer(&pt->timer, pt->scheduled); > @@ -580,13 +593,22 @@ static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) > return; > > write_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); > + > + pt_vcpu_lock(pt->vcpu); > + if ( pt->on_list ) > + list_del(&pt->list); > + pt_vcpu_unlock(pt->vcpu); > + > pt->vcpu = v; > + > + pt_vcpu_lock(pt->vcpu); > if ( pt->on_list ) > { > - list_del(&pt->list); > list_add(&pt->list, &v->arch.hvm.tm_list); > migrate_timer(&pt->timer, v->processor); > } > + pt_vcpu_unlock(pt->vcpu); > + > write_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); > } > > diff --git a/xen/include/asm-x86/hvm/vpt.h b/xen/include/asm-x86/hvm/vpt.h > index 39d26cbda496..f3c2a439630a 100644 > --- a/xen/include/asm-x86/hvm/vpt.h > +++ b/xen/include/asm-x86/hvm/vpt.h > @@ -129,10 +129,10 @@ struct pl_time { /* platform time */ > struct HPETState vhpet; > struct PMTState vpmt; > /* > - * rwlock to prevent periodic_time vCPU migration. Take the lock in read > - * mode in order to prevent the vcpu field of periodic_time from changing. > - * Lock must be taken in write mode when changes to the vcpu field are > - * performed, as it allows exclusive access to all the timers of a domain. > + * Functions which want to modify the vcpu field of the vpt need to > + * hold the global lock (pt_migrate) in write mode together with the > + * per-vcpu locks of the lists being modified. Note that two vcpu > + * locks cannot be held at the same time to avoid a deadlock. I would maybe word this as: /* * Functions which want to modify the vcpu field of the vpt need * to hold the global lock (pt_migrate) in write mode together * with the per-vcpu locks of the lists being modified. Functions * that want to lock a periodic_timer that's possibly on a * different vCPU list need to take the lock in read mode first in * order to prevent the vcpu filed of periodic_timer from * changing. * * Note that two vcpu locks cannot be held at the same time to * avoid a deadlock. */ Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 29 10:40:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 10:40:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102940.196483 (Exim 4.92) (envelope-from ) id 1lQpKB-0003NY-MK; Mon, 29 Mar 2021 10:40:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102940.196483; Mon, 29 Mar 2021 10:40:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQpKB-0003NR-IQ; Mon, 29 Mar 2021 10:40:47 +0000 Received: by outflank-mailman (input) for mailman id 102940; Mon, 29 Mar 2021 10:40:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQpKA-0003NM-0v for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 10:40:46 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e36b40d4-cf0d-4ecb-835c-2654cae3f597; Mon, 29 Mar 2021 10:40:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e36b40d4-cf0d-4ecb-835c-2654cae3f597 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617014444; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=AUZd3BJ8D6mLn+HTz69TFxrw/AUmwVhAK8hcARUsSjI=; b=DqZPOUMyv+a3HEnINGFJDrILKR+dreAyPG3KeltPNH9thtp3p032xTkr Dhr7d4prmEaDgV2dFmYAJ/VcQ8Sytv3XRiVGdGghQQinzxK6rLVSzy2oR bbv8zCy7nQdHdAif6F0b4LW0u/7+PyGMD/UOgWCL56RoALj0XBzrmtSrl M=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: egdK8+M02Aw8VBF9VclIbYsU2RpLYs4pJjsqL6RrKAbx4X9SkoUXKbenkdMSabNOhzdfzb0R1D ohSzavheA89vzlZjixHIQRpyajf89cpLtBI9q3/TCIoaYAgxeZbSQMN5ZVMpL4bKnZAX49bedE w4naB0etm9tpFguqb7TWIsFYyv34iquDj9lc5Boa2UgQ2pvFJVBrbrHXx5W4cRvQ1AP9SADMJX RsOKhaK1MBANF+wmUeUma9LMZHL69MTfgJD9hjnr7kFqWMke22vevPefIcZ60ewBPLasLm1Dtw ceY= X-SBRS: 5.2 X-MesageID: 40485471 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:4KhEEK6O2g/hosweogPXwXiEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoexzh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdxHW3tV2kZ 1te60WMrDNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2BXQotLhj0JbTqzOEtwWQVAGN4VFI CE4NBGujqnfh0sH76GL1MCWPXOoMCOqYnvZgQICwVixA6Fiz6p77CSKWnk4j41VTRTzbA+tV XUigCR3NTZj9iX6D/5k1XS4ZNfhcf7xrJ4avCkp8AJJlzX+2SVTat7XbnqhkFRnMiO7xIQnM DIs1McOa1Img/sV0WUhTeo5AX6yjYp7BbZuC+lqF/uu9bwSj5/K+cpv/MhTjLj50AtvM5x3c twtgrz3fonbmKzoA3H69fFTB1snEavyEBS6dI7tHBDTZAYLIZYsI13xjIlLL47ACn45Io7ed Meav302fA+SyL/U1np+kNrwNCqQ00pGAaHTkUoqqWuokZrtUE84E0CyMMFmHAcsLo7Vplf/u zBdp9ljbdUU6YtHO5ALdZEZfHyJn3GQBrKPm7XCVP7FJsfM3aIj5Ls+r066MyjZZRg9up8pL 3xFHdj8UIicUPnDsODmLdR9ArWfWm7VTPxjulD+plQoNTHNfrWGBzGbGprv9qrov0ZDMGece 20IohqD/jqKnarMZpV3jf5R4JZJRAlIYwok+d+f2jLjtPAK4XsuOCeWu3UPqDRHTEtXX66LW AEWBT1OcVc/mGmUnL1m3HqKjHQU3262ag1PLnR/uAVxoRIHJZLqBIphVOw4dzOCTAqiN1yQG JOZJfc1o+rr2i/+mjFq09zPABGM0pT6LL8F1dDpQoANVLIYa8O0u/vPVx67T+iHFtSXsnWGA lQqxBc4qSsNaGdwigkFpaBPn+FiWAQ4FaHVY0VlKHGxcqNQOJ3Mr8WHIhKUSnbHR18nghn7E 1ZbhUfe0PZHjTyzYO/jJIVA+nbX8JmgBiiJPNVrX63jzTemegfAl8gGxK+W8+ehggjAxBOgE dqzqMZiL2c3Qq0JXAHm+Q+Ol1UYGGxCLZLZT71I7l8q/TOQkVdXG2KjTuVh1UWdnDx/0sfvG DnMBaZYOrGGFZbp3Be3Jv76V8cTBTvQ2tALlRB9aFtH2XPvXh+ldWGYae+yEO9QFoPyON1Ck CPXRIiZidVg/yn3h+cnziPUUg8zpI1J+rHEfAIaLfIwE6gL4WOiIALF/JZ54xeKdjrq+MHON jvPTO9HXfdMacEygaVrnEqNG1Is3Eii+rvwwCgw26i3nIzaMCiVmhOdvU+GZW74GflTfrTj8 k8otIxoOeqMmL+LvSB0rraajZfKhXV5U66JttY3ax8jOYXjv9UGZKebB7jkFdg9z86JN3vlE wfTL9giYqxcrNHTog3QWZh4lEtlN6zN0MlvQz9P/8mcTgW/grmFuLMx4CNlKEmDUKArjbhIF Wz8yVS+PHeQiuIvIRqfJ4YECBzaEIm7m5l8/7HX4rMCB+yf+UrxivxDlaNNJtcQrOCA7Mes1 JT5MyJhfaec27d1BrLtTV2ZoJI/GDPe7L+PCu8XcpJ+ce9I1KCn++D59Oyli7+TX+DUHsj7L c1PHA4X4BkkTktjIo+zyi0ROjWmyse4iRjyAAisEXs1Iig6HrcBmdcP2Ti88xrYQU= X-IronPort-AV: E=Sophos;i="5.81,287,1610427600"; d="scan'208";a="40485471" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FFHvRo3uANxE642aE8GEE7n0RL9gyzT05Jk332AowN8PUOiyD6dWym/wrZiqeQjxQxTIqGtMsZVXusaMNHwI7HFLN0EvwEb2nraJTHO3OUKkQh5gZcyf2v89M22wNpXh2g14RFW3S90WxpJcl2x8Ta8k/ZpxJ3A0h/GeNHj0gSIYNhLbVtMOqWS4WQASK3zAsj+Lfd0HRDQchbuT6tP6E+ytJquwV5ih1DRut9woAXSsK/UvlCoeWOnV9wZRwG+hxeXvcElVOcytlVYIxyQIS7DPVtdB3P/7IH5QrFL2axxblvsVyXaFhnfNLFZSKw/kvtU4DJlOcto2hDTDbjs1VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4uq1zSz2PA08osRpyXxWzQ3BZyN1WJhZGJ1zPNuzRHE=; b=EaQ5FjUAKufS21jaRPvAAgKOZXZ6tWb9bgkwRty2OwdJrID2v7wLWovNMG+CuvgY2IrD4yhInmJNgWrWsFBvIdAEi6uXD4fYqjjLhk1ihcdiiqe3Nv7iC8egjNVbjtcfpobiiD2VHkVpdPBrN1g6vJXQPWnb4D+KheIGfAUjq1RMuQoDx9VcAZfOKd3peFvfDe5x2LVyZVElj6P5CcxYHcjx29UbIrjBgo4WSB1QCtDTtlxj91I7f7BqMUSGf33b2Ylo3z2cyDJMDRpIVFUyVcsOTJCZyeU9tK+oC+SU1+IXPvgQy9d52D0KiVBqwsR+ic90HsgnJuLdFbKzNJnbzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4uq1zSz2PA08osRpyXxWzQ3BZyN1WJhZGJ1zPNuzRHE=; b=f/ckZAUuCDxcclspcaC/epEvR+8W+m3rO58O906jTpUCsT4Yi0U+O4e9fk9e+5YR0lYWo4C7i3bQyOBDZ7Qa+AdssSfg8WhTAfzLEe/ocloFEXOpSuA2Iup3a6c+pgNHXAP+VJa7tLi1hCCF0sX2x/10/vb1FaLXhvEjDuAGN44= Date: Mon, 29 Mar 2021 12:40:34 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Boris Ostrovsky , , , , , Subject: Re: [PATCH v2] x86/vpt: Do not take pt_migrate rwlock in some cases Message-ID: References: <1616809866-30837-1-git-send-email-boris.ostrovsky@oracle.com> <82868938-bf57-25c2-38f6-1ec8e9c92362@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <82868938-bf57-25c2-38f6-1ec8e9c92362@suse.com> X-ClientProxiedBy: MRXP264CA0036.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:14::24) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4dc1cddb-834b-4c73-a2b9-08d8f29f18c4 X-MS-TrafficTypeDiagnostic: DM5PR03MB3066: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ycd78HmlFtZmyB5Z+aAEZ1ckMO7y/pjrkn9z/wzwZxNc+InntcFHwqNnrsZeFNwIRpJPp8sqGw90F7BmIjxt/rxjB8S1dT5AgZNGcYCqA2K40lMLL3BJj+lmGTgve1wegqrj2pSnHNy8awS7hG7wO+sn/ATQ5IEVDa1t+qdmNqSveD2rQ8vfV5XFf2SauC5pxXqhaOj2qJeoxy+VBtH5/X0APpx+C8Vob/Ol4utH0QlQY2JptFBh2PEM58bb/UPEUj8SY7hsmRMtDLxJ80OP/07rm7NgZfhmFfthCJ2EIl71AAPnOr+JH4ktM/S9LGnjGQSaCYlyCCsbllp7dCtLDrRucEHsqIkm6z5Oed0d5vG4q9mmkm3kj944tubxZqLysmXWNe2GVX+918qk1La6z9C5p0K0zAIVEGlQRhfF0Y5uQEdceXFtS6+2U+n2IVfYuHZayjBs0RWEjQ/XjIyHf3FPZ2kNWhKT0TAw2YzlaEo5xK5El5brZA45RGdci6URF77dA7/Frc1ZjbNsId7iIbZ7FD9Hhtf1nlqbLuCWul3UEWLOMt12XxXJwlpcy+A0eWPMBecZEcQyj4Sjo4KOqDnNtB1s+uxkskRKDJaAHIUyyhtNA93NTGFBkUHUiA7EiRdhL6HQP/UQBK1zXoW7cwsO47YBj9Hqd+/XUwiQnyY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(396003)(376002)(366004)(346002)(39860400002)(136003)(9686003)(66476007)(66946007)(6486002)(66556008)(6666004)(16526019)(6496006)(8936002)(26005)(956004)(38100700001)(8676002)(186003)(86362001)(33716001)(53546011)(478600001)(4326008)(316002)(83380400001)(85182001)(6916009)(5660300002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YlRzeWpkaEJoakRrTXJiK3JFMStUK3VMQWNMNy9laWJnL1J4UzhOVXIwbU5F?= =?utf-8?B?RGd2ZWxMWDBkZGV5TVQwK2ZJM0FGUjFoeDE2UVhBSnB6eWNERTRBRyt5dXln?= =?utf-8?B?a2RuVVZJc0pvTG4zQ083Vlh2R0dNQUpCa3N3TkNyTUtWUTRUMUtIeFhOQkFs?= =?utf-8?B?d2MySitmWWhrbTdiNTVzV0xjT1RzSDJQR3VWL0RZZjhsYnZxckVTaENmS3ll?= =?utf-8?B?R0VEcjZ5ZFM1eklPNkJJaXJrV0U2SHNwS2dFZVJ4REEwR1BDbGEyYldGNmdh?= =?utf-8?B?bjFzNkwrQ1N2TDEwbUMzQVhCR0lXclBSaVBkOHA1aU02SWJoK096VTF6NGh3?= =?utf-8?B?SUdkZUgyQTlzQzdsWU5QNzFnK2hKaFU1N1VlYjJ6Sm83V1ZIRUlMQkRFcEd3?= =?utf-8?B?MWZxUDNYTHBFZ2w0dUZMeTdjRGE0ZUZ6d2ZFTEY0aWxwNGVzdGtwa0hwRjhS?= =?utf-8?B?RXdpYys0MThMekVhZEd6VEVYblUxZTJGd1ZYZUhwZ0FieGl4eTFWQnEwQ2Yz?= =?utf-8?B?Q1ZINVI2dXAyNXFSSmNPZ3VvdW9QUkxJNjQ0S1pHSjVqRkdwbzFQcE93eDQr?= =?utf-8?B?by9wSS95a2s2cG1zOHhqbi91UjcveVVuQ2RkT3dXWjhKaGM4TkloVFJHSnEv?= =?utf-8?B?T0dnQ2hLVGQ5UldWUzhGSXFZNnZiL1Z3cjJrS3VDYkdzdVpUQldSZnpMQ1Zk?= =?utf-8?B?YXZhZFJ1V1FyQ3BPdGdQWm1zbzNXbE9velZ6ZEZCOHFDV1ExZTdTMXhJa1l1?= =?utf-8?B?ZUFRVWV2MCtidllhNzVDclpSVUVUczhON0tFcUlXaTUxckV6YnNFZmhKS1Vv?= =?utf-8?B?ekp1bjZmSzJVeG84c3oxNkczWUdTOVBSU3pBTWF2YkJXOWd1eEk5UE1nQUh4?= =?utf-8?B?RlNKSTN5T1ZYdzBsanYzbnZBWFVqcHNKYU85Tk5KQ1RYbkY5ZW9VazJ3VXQ0?= =?utf-8?B?RGtnSlBoODUwQ01CN05TVEtseEdrZVlJNXBmQ0FvMmNiMkdnOGF4SW1lVHhm?= =?utf-8?B?dzZlRFJoTmUwYXA2Ylcva09NaDgvWWg1emJQdFBqUUl1djdLUU95TS9UUGRz?= =?utf-8?B?MkFsRWg0TG54VVdEaXlBZURDaDdiS0pZczROSUJlbTJnWkpPOC9LYnlSZ1pT?= =?utf-8?B?R3loajdoY2lyb0lsUERCd2czQmk0WDNqNmJObzBZQnY4ZFZNaEs0S0dxdFp1?= =?utf-8?B?SlFaZm93cjV3bSt5ZlhHTVF4dU1YYzlrTUNHYTRsTHJTb1lrazJPbXV2bjM4?= =?utf-8?B?aHJLYWk3MkpUYzF5RGFDMWtlWXBybFkyTXR4WklzYVF2MDltTXNZK2w2cmkv?= =?utf-8?B?UngxWnZ3a3ZaY20vaERnVTduMDlwWWdsQURIRW1ya1VRZ2t0U0ZYamQ4SXJD?= =?utf-8?B?QjhZQzBocEZiUU9CT0IvVXpCa25MczlxT25DMW1QR2FvbHdDcWsyNWI3Mktl?= =?utf-8?B?OGZwY0xTbXEvc3RYMWtJKzQ3VWQ2YnVTeWtxb0dTNWxuTllpb3YwNVNDdHBM?= =?utf-8?B?d1N0N2xxVXBWVnpmZGFhekJDUUNLRndBaHNWaWRwRVJRQ01CYmE2TS85OXhX?= =?utf-8?B?K1ZFOFg3dGFOTTlUZE9iaEl5WVF2VUwya1NUVEx4WXFiVmRyVHZ4cWo0eEpo?= =?utf-8?B?cmhXWFBqQUs2NXhLSmJxazQrS2pNVFdJdStyRFVlUWtkUEp5RDVScTljb21v?= =?utf-8?B?emdvUmFQc212TnZlY0FMYVN4OHYxS1hycEZDcm1jbjBBRlFDWTUyWnlvRTVD?= =?utf-8?Q?saENjqZ89x4KuTJNtBMrPMOfaGrdjH4BIZtbuAT?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4dc1cddb-834b-4c73-a2b9-08d8f29f18c4 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 10:40:40.4227 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fKmm/NxewBIKYg4c6kCqx8sbRj2rwtudiLY+51/QfYeMeWYtc16PSus1U9d4ewSw3XXShZf1qgVohMoH43lwjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3066 X-OriginatorOrg: citrix.com On Mon, Mar 29, 2021 at 11:56:56AM +0200, Jan Beulich wrote: > On 27.03.2021 02:51, Boris Ostrovsky wrote: > > Commit 8e76aef72820 ("x86/vpt: fix race when migrating timers between > > vCPUs") addressed XSA-336 by introducing a per-domain rwlock that was > > intended to protect periodic timer during VCPU migration. Since such > > migration is an infrequent event no performance impact was expected. > > > > Unfortunately this turned out not to be the case: on a fairly large > > guest (92 VCPUs) we've observed as much as 40% TPCC performance > > regression with some guest kernels. Further investigation pointed to > > pt_migrate read lock taken in pt_update_irq() as the largest contributor > > to this regression. With large number of VCPUs and large number of VMEXITs > > (from where pt_update_irq() is always called) the update of an atomic in > > read_lock() is thought to be the main cause. > > > > Stephen Brennan analyzed locking pattern and classified lock users as > > follows: > > > > 1. Functions which read (maybe write) all periodic_time instances > > attached to a particular vCPU. These are functions which use pt_vcpu_lock() > > after the commit, such as pt_restore_timer(), pt_save_timer(), etc. > > 2. Functions which want to modify a particular periodic_time object. > > These guys lock whichever vCPU the periodic_time is attached to, but > > since the vCPU could be modified without holding any lock, they are > > vulnerable to the bug. Functions in this group use pt_lock(), such as > > pt_timer_fn() or destroy_periodic_time(). > > 3. Functions which not only want to modify the periodic_time, but also > > would like to modify the =vcpu= fields. These are create_periodic_time() > > or pt_adjust_vcpu(). They create the locking imbalance bug for group 2, > > but we can't simply hold 2 vcpu locks due to the deadlock risk. > > > > Roger Monné then pointed out that group 1 functions don't really need > > to hold the pt_migrate rwlock and that group 3 should be hardened by > > holding appropriate vcpu's tm_lock when adding or deleting a timer > > from its list. > > I'm struggling some with the latter aspect: Is this to mean there is > something wrong right now? There's nothing wrong right now AFAICT , because per-vcpu users (ie: type 1) also hold the rw lock in read mode when iterating over the per-vcpu list. > Or does "harden" really mean "just to be > on the safe side" here? If the per-domain rw lock is no longer read-locked by type 1 users then type 2 and type 3 users need to make sure the per-vcpu lock is taken before adding or removing items from the per-vcpu lists, or else a type 1 user could see list corruption as a result of modifications done by type 2 or 3 without holding the per-vcpu lock. This again makes the locking logic more complicated than it was, so I will try to get back with my vpt improvements so we can get rid of all this at least on unstable. Hopefully the comments are clear enough to follow the logic. Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 29 11:01:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 11:01:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102946.196498 (Exim 4.92) (envelope-from ) id 1lQpdx-0005j6-E4; Mon, 29 Mar 2021 11:01:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102946.196498; Mon, 29 Mar 2021 11:01:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQpdx-0005iz-AZ; Mon, 29 Mar 2021 11:01:13 +0000 Received: by outflank-mailman (input) for mailman id 102946; Mon, 29 Mar 2021 11:01:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQpdv-0005iu-LF for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 11:01:11 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d7ccd0c8-9dde-487e-a9c3-1795f570ca67; Mon, 29 Mar 2021 11:01:10 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 835B3B455; Mon, 29 Mar 2021 11:01:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7ccd0c8-9dde-487e-a9c3-1795f570ca67 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617015669; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qu+knVKLRo8NmHQQZRUKQt88FpEey49BphhElhAeyw0=; b=fjqznH0U0Zh5oEGd4QqM0ePlYxTSLkjZ1WnEA7k7Y9yG+nbHzAmq3pRzSKWN//EXuBDOeK FZqeuWVEB+s8rhWkqUMTb2LRW7pNLx7rAq4azkVK3sqM0h9FUNJfrVSWe9pMTztFoJkyT/ 6TygiebLLhzBaV9SfUDyjCUteLXB31Q= Subject: Re: [PATCH v2] x86/vpt: Do not take pt_migrate rwlock in some cases To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Boris Ostrovsky Cc: andrew.cooper3@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com, iwj@xenproject.org, xen-devel@lists.xenproject.org References: <1616809866-30837-1-git-send-email-boris.ostrovsky@oracle.com> <82868938-bf57-25c2-38f6-1ec8e9c92362@suse.com> From: Jan Beulich Message-ID: <154f34e1-85c0-6e7c-da9e-2c7889d4473f@suse.com> Date: Mon, 29 Mar 2021 13:01:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 29.03.2021 12:40, Roger Pau Monné wrote: > On Mon, Mar 29, 2021 at 11:56:56AM +0200, Jan Beulich wrote: >> On 27.03.2021 02:51, Boris Ostrovsky wrote: >>> Commit 8e76aef72820 ("x86/vpt: fix race when migrating timers between >>> vCPUs") addressed XSA-336 by introducing a per-domain rwlock that was >>> intended to protect periodic timer during VCPU migration. Since such >>> migration is an infrequent event no performance impact was expected. >>> >>> Unfortunately this turned out not to be the case: on a fairly large >>> guest (92 VCPUs) we've observed as much as 40% TPCC performance >>> regression with some guest kernels. Further investigation pointed to >>> pt_migrate read lock taken in pt_update_irq() as the largest contributor >>> to this regression. With large number of VCPUs and large number of VMEXITs >>> (from where pt_update_irq() is always called) the update of an atomic in >>> read_lock() is thought to be the main cause. >>> >>> Stephen Brennan analyzed locking pattern and classified lock users as >>> follows: >>> >>> 1. Functions which read (maybe write) all periodic_time instances >>> attached to a particular vCPU. These are functions which use pt_vcpu_lock() >>> after the commit, such as pt_restore_timer(), pt_save_timer(), etc. >>> 2. Functions which want to modify a particular periodic_time object. >>> These guys lock whichever vCPU the periodic_time is attached to, but >>> since the vCPU could be modified without holding any lock, they are >>> vulnerable to the bug. Functions in this group use pt_lock(), such as >>> pt_timer_fn() or destroy_periodic_time(). >>> 3. Functions which not only want to modify the periodic_time, but also >>> would like to modify the =vcpu= fields. These are create_periodic_time() >>> or pt_adjust_vcpu(). They create the locking imbalance bug for group 2, >>> but we can't simply hold 2 vcpu locks due to the deadlock risk. >>> >>> Roger Monné then pointed out that group 1 functions don't really need >>> to hold the pt_migrate rwlock and that group 3 should be hardened by >>> holding appropriate vcpu's tm_lock when adding or deleting a timer >>> from its list. >> >> I'm struggling some with the latter aspect: Is this to mean there is >> something wrong right now? > > There's nothing wrong right now AFAICT , because per-vcpu users (ie: > type 1) also hold the rw lock in read mode when iterating over the > per-vcpu list. > >> Or does "harden" really mean "just to be >> on the safe side" here? > > If the per-domain rw lock is no longer read-locked by type 1 users > then type 2 and type 3 users need to make sure the per-vcpu lock is > taken before adding or removing items from the per-vcpu lists, or else > a type 1 user could see list corruption as a result of modifications > done by type 2 or 3 without holding the per-vcpu lock. Ah, right. Boris, may I then ask to avoid the somewhat ambiguous word "harden" here then, and instead make clear that the new locking is in fact "balancing" removal of locks elsewhere? Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 29 11:11:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 11:11:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102953.196513 (Exim 4.92) (envelope-from ) id 1lQpo6-0006qj-FO; Mon, 29 Mar 2021 11:11:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102953.196513; Mon, 29 Mar 2021 11:11:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQpo6-0006qc-CA; Mon, 29 Mar 2021 11:11:42 +0000 Received: by outflank-mailman (input) for mailman id 102953; Mon, 29 Mar 2021 11:11:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQpo4-0006qE-Hk for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 11:11:40 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1d28439f-c7fa-419a-9a30-3e25f47a9dbd; Mon, 29 Mar 2021 11:11:34 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7CD39B454; Mon, 29 Mar 2021 11:11:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d28439f-c7fa-419a-9a30-3e25f47a9dbd X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617016293; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=g0ufvfcK6pCGF1gqf8ZNOjSLsB+r2xUS5n9A5y63ipE=; b=n/8H+mwFqBqFI12fvV6EBU8j/4JAOua5hlEAjCUIBd0C3LfdZnkpQ/ouMmvoLi1YUE6HcE 2ZgLsQlobhFvQSEnfsNYqX1/juAceTZME6pqoTuv25AG/QTRN44iNFEuYhf2fdAAcCzb5W nbok2nrGUaIIa8UeQbfpts7Yus4rTpI= From: Jan Beulich Subject: Xen 4.13.3 released To: xen-announce@lists.xenproject.org Cc: "xen-devel@lists.xenproject.org" Message-ID: <47e12a5f-173c-81ff-97be-d854c9d57527@suse.com> Date: Mon, 29 Mar 2021 13:11:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit All, I am pleased to announce the release of Xen 4.13.3. This is available immediately from its git repository http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.13 (tag RELEASE-4.13.3) or from the XenProject download page https://xenproject.org/downloads/xen-project-archives/xen-project-4-13-series/xen-project-4-13-3/ (where a list of changes can also be found). We recommend all users of the 4.13 stable series to update to this latest point release. Regards, Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 29 11:19:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 11:19:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102957.196524 (Exim 4.92) (envelope-from ) id 1lQpv3-00071n-4G; Mon, 29 Mar 2021 11:18:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102957.196524; Mon, 29 Mar 2021 11:18:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQpv3-00071g-1F; Mon, 29 Mar 2021 11:18:53 +0000 Received: by outflank-mailman (input) for mailman id 102957; Mon, 29 Mar 2021 11:18:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQpv1-00071b-Pe for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 11:18:51 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5a837f9e-3658-4da8-ac3b-8a8c2ce4c52e; Mon, 29 Mar 2021 11:18:51 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 43D3EB457; Mon, 29 Mar 2021 11:18:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a837f9e-3658-4da8-ac3b-8a8c2ce4c52e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617016730; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aUYrzmbWRoapn0e4WTautW36RFz6N2tJyLtjAT6FsLY=; b=mUkNftuGQXaGWKIrd/XcuU1IvUGqKMYq7BKzKaYOmolKhWztUKU2KLEEnegtp0DdHyZftb h70XjCoX80qWqeYruaQigZ4b2Jxpgi6e+SIrSpY1xxAL4OV1UHdEHnvxalMIYDuEI6n3iP yz19EeH90LgxpMN+st2SHE/0NTs745s= From: Jan Beulich Subject: preparations for 4.14.2 To: "xen-devel@lists.xenproject.org" Cc: George Dunlap , Stefano Stabellini , Ian Jackson , Wei Liu , Anthony Perard , Julien Grall Message-ID: <38e7fa74-8e2a-2411-90ce-8485677d6fca@suse.com> Date: Mon, 29 Mar 2021 13:18:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit All, in a little over two weeks time the release is due. Please point out backports you find missing from the respective staging branches, but which you consider relevant. One that I have queued already is b9b3082002ca VT-d: correct off-by-1 in number-of-IOMMUs check Like for 4.13.3, f6f787de9896 ("x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating") may need reverting. Unless by that time we have at least a final workaround for the follow-on issue it has caused (which now looks to be at least not unlikely anymore). Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 29 11:40:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 11:40:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102963.196537 (Exim 4.92) (envelope-from ) id 1lQqFs-0001SY-Th; Mon, 29 Mar 2021 11:40:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102963.196537; Mon, 29 Mar 2021 11:40:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQqFs-0001SR-Q7; Mon, 29 Mar 2021 11:40:24 +0000 Received: by outflank-mailman (input) for mailman id 102963; Mon, 29 Mar 2021 11:40:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQqFr-0001SM-Uo for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 11:40:24 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ce0707cf-ec34-4b07-a0f3-217e4b734653; Mon, 29 Mar 2021 11:40:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce0707cf-ec34-4b07-a0f3-217e4b734653 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617018022; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=5Zi09haqp5DcxvhE/zCjuqmg4Y7tuPjN1RMdHV6x8es=; b=DDYmaXay2DGZ1dj3JAsos2KeFQoHll5mHGu/LgkqckuDmOheFdV/tUNd w/3KR0YsSyCLQmKSSgoSCfm0q1P/axsq2VQNamOsTMohCnMlFy08Gg1Lh au3+BV4KOShGYUcHBn4NQTm7snaxb8EG+ZixfRUZYgcoIszaNp5bZgl6X A=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: GL00tQ5A5eOdvQM+9hcGOm/5vsYNEkF9xK1FWWrVNNKca+MiUDKLVCoOLReePgXvQ9+FnxKIcC uq7BQnJ/xDkJQaD1LPrbOaJ/jwb8iPh7pUaN2+FThDPnGwVMjfBi4cXsY/r9zW9OR4rONkKlPA ZEj0VGm363j5whLyc/gyPueJXbN6LGuwTp/JGvZZe9jV+THoe45WBIlS2jbHg2/VidsqBgs9NB 7ajq/KQAQWjGE+ng5Glh64SvU3nmpaPiwi2W+XdGGfKys0nQqj9qV59MK3+xygsJoL5EkMviPf u0c= X-SBRS: 5.2 X-MesageID: 40319036 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:BddH26ulcJPZSExQBJNHV2Nb7skCxoYji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOjrU5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qw6Y 5JSII7MtH5CDFB4PrSyBWkEtom3dmM+L2pg+Cb9Ht2UQR2cchbjjtRICzzKDwQeCBtA50lGJ 2AoudGvSOnY3QLbsK9b0N1JdTrjdvNiZ7gfFo6HBYh8gaDlneF77T9Hhie0H4lIk5y6J0l9n XIlBG827W7v5iAu2Th/kLwz7ATotvuzdNfGNeB4/J6FhzAghulDb4ROYGqkysypIiUmTMXuf nK5ywtJsFir07WF1vF3SfF/ynF/HIQ52T5yVme6EGT0fDRYD4hEcJOicZ4X3LimjMdlepx2q 5KwG6V3qA/ZXir/FWflqr1fipnmUaurX0pnfR7tQ0mbaIkZKJMtotaxUtJEf47bVPHwbo6G+ pjBty03ocxTXqmaRnizw1S6e3pdHEyEhCae1MFq8yY3hNH9UoJsXcw9YgxmGwN+4k6TIQBz+ PYMr5wnLULdcMOa7lhbd1xDfefOyjoe1bhIWiSKVPoGOUuPG/MkYf+5PEQ6PuxcJIF4ZMukP 36IRxlnF93X3irJdyF3ZVN/ByIan66Ry7RxsZX4IU8kqHgRZLwWBfzCGwGoo+FmbEyE8fbU/ G8NNZ9GPn4N1bjHo5PwknXR4RSE38DS8cY0+xLGm6mk4buEMnHp+bbePHcKP7GCjA/QF7yBX MFQXzdP8NFwke3WmLpoRTYVn/3E3aPv65YIez/xaw+2YINPopDvkw+klKi/PyGLjVEr+gXcS JFUfbau5L+gVPz0XfD7m1vNBYYJF1S+q/cX3RDohJPF0v1dL0EquiOYGw65grCGjZPC+ftVC JPrVV+/qy6a7aKwzo5Nt6hOmWGy1weuWyNVJVZvqGY/8/qdtcZA/8dKeJMPDSOMyYwtRdhqW 9FZgNBbFTYDCnShaKsi4FRIvreedl6iAKCOtVVtnrbiEWZqagUNzgmdg/rdfTSrRclRjJSiF E02bQYmqC8lTGmLnZ6vP41K2RWaGOcAKtPCSOMYIk8oMGtRChACUOxwRCKgRA6fWTns2EfnH boIyGvdfbXOVZFoXxD3qH28FR7S3WFcytLGwNHmLw4MV6Dlmd40OeNaKb26WeXZ1cY6sw2MT 3OY1IpU0hT7uHy8CTQtCeJFH0gyJlrA/fUC647darPnlm3LpeTqK0AF/hI3ZpsOdz0qNUXWe aHdwL9FkK/N8oZnyiu4lo1Mih9r3cp1c7y0Br+9W6iwToRB+HRLFkOfcBsH/isq0zfA9CG35 VygYhr4a+eMmDtZsWHzq+SRThZMR/XqXO3SeZtiZ08h9NHiJJDW73gFR3P3zV7+T97CuHevk YXWr5677DMIZUHRb1bRwtpun4S0O2SJ04quDHsCuAwfVsRn2bWVun5lobgmP4KOAm9vwP+Nl mUzj1F89rEVyWF06QGC6hYGxUgVGEMrFBj9viFbYveFUGDcPxC5kOzNhaGAfVgYZnAPbUbtR Bh5d6U28eRairjwQjV+R92OLhH/WriYcS8Bmu3aKN12u3/HVSHma2x5sGvyB/xVDugckwdwb R/SnZ4VLULthASyKst0iazTaTrokUq13tmiAsX6WLF68yB+2fUHUZPLAvDpI5ZNAMja0S1sQ == X-IronPort-AV: E=Sophos;i="5.81,287,1610427600"; d="scan'208";a="40319036" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GJ8AYPaNHQ6PvR6w9EDs6XyLQ2UoiqEEHKK/86oxbvxwItYbQxLRsmCy6ul4KmHFBhuFSnpgD/oFPMWSvvizkR/lC6q+XO+CNVX+qJFbXvuoZQEwcge0FlcDPwRycU3VdaKfvLlBaSXeSJObGIsZbfFdtnC9Qjgjo/QFcp5xxYQxNcxR+VmCFH20nqJmaCBgCnubikpqxgFBsR08H603fUhMufZVY3G04UokzXVFZl/XduJ5h7C4w58EMOqfv/LFgJVdJ+s/1yU3Vseu9kkzzlC7UbLcKybjWPKO2rfWOxI3eVRLK99R4efvTZM+TWDRUIiDtZqs5gbuu5+aAt7iBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0gLKGKti2R4HmzLf/MvxctvsNUBdPdGoIqclvp8+Wps=; b=EE+oP+bVDYbwniTXZIE1EMnxIKu82ZRQQ8nzIB0du7lQRa0/qFC0p4cXzuKGB26LlEgVkt+Ggm1zJ0CWyEP6hfZZKmvxMnBzYFm2TTWR76TFUNilKF2lSYz/XSA3lga3KeRoWSGiIsSP5O0YirikR+V531oAa4rwGGUxFMvL3FmMBQkRYoPPyxoavsk1qAP8wFpyB4By0uomLK22gobvgW4oWoGyvxCXfcG/bjTGNOi/Uj+5SDuRNdJMYk6mjbr4cseztenXU+Bh0ZuK5ywSZMQKvVuctDMOMYIskkRPh57+DOkjV/mCVdPc5srnnBQaez3cMOzn2j1GxmB3O5DaKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0gLKGKti2R4HmzLf/MvxctvsNUBdPdGoIqclvp8+Wps=; b=MhccAGQArwwT8ijaSiqFkVEUdKzIMLJUkQx8cp+91PYpI4vGohUDGo0nFNmS/Gg7TFazHvKVyyf5A577tQ93C+tkqoHqWapRsbbPpz5sKgc69L8AvTX29f13YJLrzZB+bLgF62JioH+Lg8aQoA5vtWBANkYREIRR/6CWSqUdaoY= Date: Mon, 29 Mar 2021 13:40:10 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Xen-devel , Jan Beulich , Wei Liu , Ian Jackson , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , =?utf-8?B?RnLDqWTDqXJpYw==?= Pierret Subject: Re: [PATCH v2 2/3] x86/hpet: Don't enable legacy replacement mode unconditionally Message-ID: References: <20210326185947.23243-1-andrew.cooper3@citrix.com> <20210326185947.23243-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210326185947.23243-3-andrew.cooper3@citrix.com> X-ClientProxiedBy: MR2P264CA0038.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::26) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ace51d5d-c7ab-4d7b-7b89-08d8f2a76c3d X-MS-TrafficTypeDiagnostic: DM6PR03MB3948: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XS6LknUqa0GjtMms8KblswUwt7vZNQWEa/EPOVr3K5ZZ1PyRAbWLJyg365vy6glmy2CPRqEWHyZbAvnrWChksu8KplpakILaUF+smYXN7US3rt25JcqQXUnTMEgvV3nAtCyJv8o0zoAliZ/mYmUKjO18DhVFf4n0ifbIdkag8gPw0eFYRGpqRGWX3ecHzp7Pli9KgrLPbegpAcYNS8WF2Sjnx0FkH2yyXMIi/QYVG0jXOwyMh1H0gx9z2TRp0GLLLt5MNmwv+ecdcTPJV6G6HPWvbjj+mptVcrhTqvXrmB6xobmUedq0PSh883uyq8vIanb9TeyL7XVY7P6UtMsYCEYkRrMTmiqq4l1W+9PpoK2Qc/Lxm2UbKSqdwS2HQi61tt7Ap86sUo+nQZRX6aTnQbL3GpuZhsMNGxJxZXo1J5B+89G+bMGHolmsYlKqP2MfMxZ+swcrUxwDq3HMrx/a6CoW5xbTyGvokIx0rSUxwFiujG3PhezUf2ALYGqDnqyBLDohCbjzvTBdzPb6yChyT3Tt637tPLLvOZwuWoSOo7FMWX5FpHtQyXJI+vZMXZ5CPnRreX+Fjd0FS09vf3hRGBy7uvfFUf7nmYf2FNVSvCC8Ni/MyWAXrIc4LMMun8IUwSSImblMU4IBRplVd2C1kje6pjL985+JrtFU5wyOICY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(39860400002)(346002)(396003)(366004)(136003)(376002)(66946007)(66556008)(66476007)(6636002)(26005)(38100700001)(8936002)(6496006)(2906002)(83380400001)(8676002)(316002)(33716001)(85182001)(186003)(6486002)(66574015)(86362001)(6666004)(478600001)(4326008)(956004)(5660300002)(6862004)(9686003)(16526019)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VGxhbURleHVmYXU4MVEwZWtXeDNEN1JkOHUyeUtzTkQyaWo5eGNhZzNMbWNH?= =?utf-8?B?NUdrQkVaSzU4bGFxT3p2dmlaT2pIUk9BbnZEdmtwM1BTajRhSExUWHI4ODBk?= =?utf-8?B?akVQci9Bd3lyOEUzT0Z5M2NBYUJ2TFdzcDA3eW1SajVESEJabDN2VG83VEtt?= =?utf-8?B?ZHVVbVphOVcweUNXV1BKbmJOUE0wNEV6ZThDRDZIdDlKelA4L3pHbUVmc2xK?= =?utf-8?B?Y1B6R3NNWldpeTl5YTRpc0tqc2syY0xONFRjUTBoUndYcFVnR1o0ZWJpNnJD?= =?utf-8?B?b2JlSlBrTWhEUW4xcW8xcnRtNDV3SnpBMFBuL1BON2VNYjNuVURza3c1MTN5?= =?utf-8?B?M202dk9XdGdFMDlwZ1lwaktuSEpadDJ1VW90VFpqUHdTeW1aenJwUTV3cTdC?= =?utf-8?B?VXFEN2dpcGpWRmV3djE5cFRpdmdGRTBnQm00TnZWbC9mU1Y0Z3FoVXNNZGtV?= =?utf-8?B?SVpjL2wvUEtkZDBhN2ROOGU1bUVWUUhYbTdEYnF1K3o3b1FBeitMSTVVMDAy?= =?utf-8?B?TEZoVXEwVit6aktuUW9wK0I3YXN1cEM2U3I3SmZhcWFoaGlwL0NlQm9EYnRX?= =?utf-8?B?dmRlZy9VZ2ZacDNLbU00WE9FM3dnNExEV25ZdU91M3pJbzJDejBrOFhMRTJD?= =?utf-8?B?UW95T0QwME4xR1ZLeVQwdUxWUnVHbnNyMmhKOU9RQzRvbHVxSGtVU1hWc2I3?= =?utf-8?B?SmEzRk9EZzMvY2ljTExlbktWS0JpNmwvejlVMXpEcTFZMkdSalN6TkJkSG10?= =?utf-8?B?WlkzZHNPbzJOTUJGRFVVRlFlMXdZWnhNY2dRd3ArWFBBWGlCdHB3d25jVnd2?= =?utf-8?B?OEllTHhMV0dDOU15SW1CdjNDcjVQZnAvSGU0QnVVOEpjS2d1SHdETk5iRzFP?= =?utf-8?B?b1piV3JNZGFvejVkRGliM0hkdVpCdjE5VGNtc0d2UWlyU2hLT01odEN4d0Ji?= =?utf-8?B?UUJjVDFJUVQrbjZ0UmNDMGU0T2FQT2JiZVcwODhHbkdYYUV1VENQaWFVSHh3?= =?utf-8?B?YmFLNHBhOWhzRSs4MmhjV2g1K2Y5cy9vbndTM25XT2dhZ21WdHB1VllVL1J4?= =?utf-8?B?ek1EYWhxUkhEdEw3U001dTBBdndidy9kZHRDSWJ3djdBV0NlQkRyQ0p3V3dl?= =?utf-8?B?MHduaktHYUdVNS9Idm1sNm9YMUpLVy9LK09XbEQrT2F5UEJNM2V5bnR0SGMy?= =?utf-8?B?M2NrQjZSWXV2b3hnUnV6TFJMSXp0cEx1SkZFMmdkdE5kN2pJOUZsc2JPYUlt?= =?utf-8?B?RkxGZmJYTkluUWdtN0xsT1lXcTk0K0xWZU5Nb3EwM1lGRXlCNC9VWGREQ0Vx?= =?utf-8?B?WFR4T0xneFZvODhYM2h2YlNaMmVQbGJ3US9DK29XenNkRy9GdVp3TGoweStE?= =?utf-8?B?bHAydmlTMGdHWUVsVExCU0g1cVE4MHFWL2VpRFZvYm0xb3BUV2c4aVRqZW1W?= =?utf-8?B?UnRteGRNOGthc1NYMVNBZ1hiR0xyNVJ1bUo3L2YyVmJxNVRETzNWcUxUd2dq?= =?utf-8?B?ek1qdVlVUmhNRFJ2WldtcDBBLzhJNzZiQUJXa05nekp1WlZOWFVSVGU3cFR0?= =?utf-8?B?b1E1NEJkWHNuZDFqMGcxdlBWSVNoWTRIMHVHRDROTWQ1czBNOGFxaFlTWnpP?= =?utf-8?B?SFFDeWhsQ3F0aUtGcG1lWTFITnNMWnpHNnNOVTdmdklRNXg4UElML2svQmU0?= =?utf-8?B?VGNsem9oY0U0RmZlVVpPWHhscGZNdEV5QVZpUGZiNmtaTzNLWjZlT1BLbWd5?= =?utf-8?Q?cawOHqH9PpHKGdHKcSyiBCN65w9vzwjNViGpSdg?= X-MS-Exchange-CrossTenant-Network-Message-Id: ace51d5d-c7ab-4d7b-7b89-08d8f2a76c3d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 11:40:16.4046 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R7ajAumnFxUvwiEqgpRvkZSe5JzBzOIaigUyj9WsDuJsYgwBNjn9kb51Yg7pze8TR9TIStSrHWCf1zd4R+5x3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3948 X-OriginatorOrg: citrix.com On Fri, Mar 26, 2021 at 06:59:46PM +0000, Andrew Cooper wrote: > From: Jan Beulich > > Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC > static PIT clock gating") was reported to cause boot failures on certain > AMD Ryzen systems. > > Refine the fix to do nothing in the default case, and only attempt to > configure legacy replacement mode if IRQ0 is found to not be working. > > In addition, introduce a "hpet" command line option so this heuristic > can be overridden. Since it makes little sense to introduce just > "hpet=legacy-replacement", also allow for a boolean argument as well as > "broadcast" to replace the separate "hpetbroadcast" option. > > Signed-off-by: Jan Beulich > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > CC: Ian Jackson > CC: Marek Marczykowski-Górecki > CC: Frédéric Pierret > > v2: > * Reinstate missing hunk from Jan's original patch. > * Fix up "8254 PIT". > * Drop "goto retry". > > For 4.15: Attempt to unbreak AMD Ryzen 1800X systems. > --- > docs/misc/xen-command-line.pandoc | 33 +++++++++++++++++++++++++++ > xen/arch/x86/hpet.c | 48 +++++++++++++++++++++++++-------------- > xen/arch/x86/io_apic.c | 27 ++++++++++++++++++++++ > xen/include/asm-x86/hpet.h | 1 + > 4 files changed, 92 insertions(+), 17 deletions(-) > > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc > index a0601ff838..a4bd3f12c5 100644 > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -1274,9 +1274,42 @@ supported. See docs/misc/arm/big.LITTLE.txt for more information. > When the hmp-unsafe option is disabled (default), CPUs that are not > identical to the boot CPU will be parked and not used by Xen. > > +### hpet > + = List of [ | broadcast= | legacy-replacement= ] > + > + Applicability: x86 > + > +Controls Xen's use of the system's High Precision Event Timer. By default, > +Xen will use an HPET when available and not subject to errata. Use of the > +HPET can be disabled by specifying `hpet=0`. > + > + * The `broadcast` boolean is disabled by default, but forces Xen to keep > + using the broadcast for CPUs in deep C-states even when an RTC interrupt is > + enabled. This then also affects raising of the RTC interrupt. > + > + * The `legacy-replacement` boolean allows for control over whether Legacy > + Replacement mode is enabled. > + > + Legacy Replacement mode is intended for hardware which does not have an > + 8254 PIT, and allows the HPET to be configured into a compatible mode. > + Intel chipsets from Skylake/ApolloLake onwards can turn the PIT off for > + power saving reasons, and there is no platform-agnostic mechanism for > + discovering this. > + > + By default, Xen will not change hardware configuration, unless the PIT > + appears to be absent, at which point Xen will try to enable Legacy > + Replacement mode before falling back to pre-IO-APIC interrupt routing > + options. > + > + This behaviour can be inhibited by specifying `legacy-replacement=0`. > + Alternatively, this mode can be enabled unconditionally (if available) by > + specifying `legacy-replacement=1`. > + > ### hpetbroadcast (x86) > > `= ` > > +Deprecated alternative of `hpet=broadcast`. > + > ### hvm_debug (x86) > > `= ` > > diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c > index c1d04f184f..bfa75f135a 100644 > --- a/xen/arch/x86/hpet.c > +++ b/xen/arch/x86/hpet.c > @@ -52,6 +52,8 @@ static unsigned int __read_mostly num_hpets_used; > DEFINE_PER_CPU(struct hpet_event_channel *, cpu_bc_channel); > > unsigned long __initdata hpet_address; > +int8_t __initdata opt_hpet_legacy_replacement = -1; > +static bool __initdata opt_hpet = true; > u8 __initdata hpet_blockid; > u8 __initdata hpet_flags; > > @@ -63,6 +65,32 @@ u8 __initdata hpet_flags; > static bool __initdata force_hpet_broadcast; > boolean_param("hpetbroadcast", force_hpet_broadcast); > > +static int __init parse_hpet_param(const char *s) > +{ > + const char *ss; > + int val, rc = 0; > + > + do { > + ss = strchr(s, ','); > + if ( !ss ) > + ss = strchr(s, '\0'); > + > + if ( (val = parse_bool(s, ss)) >= 0 ) > + opt_hpet = val; > + else if ( (val = parse_boolean("broadcast", s, ss)) >= 0 ) > + force_hpet_broadcast = val; > + else if ( (val = parse_boolean("legacy-replacement", s, ss)) >= 0 ) > + opt_hpet_legacy_replacement = val; > + else > + rc = -EINVAL; > + > + s = ss + 1; > + } while ( *ss ); > + > + return rc; > +} > +custom_param("hpet", parse_hpet_param); > + > /* > * Calculate a multiplication factor for scaled math, which is used to convert > * nanoseconds based values to clock ticks: > @@ -820,12 +848,9 @@ u64 __init hpet_setup(void) > unsigned int hpet_id, hpet_period; > unsigned int last, rem; > > - if ( hpet_rate ) > + if ( hpet_rate || !hpet_address || !opt_hpet ) > return hpet_rate; > > - if ( hpet_address == 0 ) > - return 0; > - > set_fixmap_nocache(FIX_HPET_BASE, hpet_address); > > hpet_id = hpet_read32(HPET_ID); > @@ -852,19 +877,8 @@ u64 __init hpet_setup(void) > if ( (rem * 2) > hpet_period ) > hpet_rate++; > > - /* > - * Intel chipsets from Skylake/ApolloLake onwards can statically clock > - * gate the 8259 PIT. This option is enabled by default in slightly later > - * systems, as turning the PIT off is a prerequisite to entering the C11 > - * power saving state. > - * > - * Xen currently depends on the legacy timer interrupt being active while > - * IRQ routing is configured. > - * > - * Reconfigure the HPET into legacy mode to re-establish the timer > - * interrupt. > - */ > - hpet_enable_legacy_replacement_mode(); > + if ( opt_hpet_legacy_replacement > 0 ) > + hpet_enable_legacy_replacement_mode(); > > return hpet_rate; > } > diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c > index e93265f379..3f131a81fb 100644 > --- a/xen/arch/x86/io_apic.c > +++ b/xen/arch/x86/io_apic.c > @@ -29,6 +29,8 @@ > #include > #include > #include > + > +#include > #include > #include > #include > @@ -1930,6 +1932,31 @@ static void __init check_timer(void) > local_irq_restore(flags); > return; > } > + > + /* > + * Intel chipsets from Skylake/ApolloLake onwards can statically clock > + * gate the 8254 PIT. This option is enabled by default in slightly > + * later systems, as turning the PIT off is a prerequisite to entering > + * the C11 power saving state. > + * > + * Xen currently depends on the legacy timer interrupt being active > + * while IRQ routing is configured. > + * > + * If the user hasn't made an explicit choice, attempt to reconfigure > + * the HPET into legacy mode to re-establish the timer interrupt. > + */ > + if ( opt_hpet_legacy_replacement < 0 && > + hpet_enable_legacy_replacement_mode() ) > + { > + printk(XENLOG_ERR "..no 8254 timer found - trying HPET Legacy Replacement Mode\n"); > + > + if ( timer_irq_works() ) > + { > + local_irq_restore(flags); Is there any point in undoing the legacy replacement here, as I understand it it's only required for the routing check? Should we also prevent any attempts from using the PIT as a timecounter in x86/time.c as a result of having the HPET in legacy replacement mode? AFAICT init_pit will already assert whether the PIT counters work, so maybe there's no need for adding an extra check on whether legacy replacement is enabled. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 29 11:58:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 11:58:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102972.196549 (Exim 4.92) (envelope-from ) id 1lQqXM-0002sW-Id; Mon, 29 Mar 2021 11:58:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102972.196549; Mon, 29 Mar 2021 11:58:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQqXM-0002sP-FP; Mon, 29 Mar 2021 11:58:28 +0000 Received: by outflank-mailman (input) for mailman id 102972; Mon, 29 Mar 2021 11:58:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQqXL-0002sH-A7; Mon, 29 Mar 2021 11:58:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQqXL-0004ji-1g; Mon, 29 Mar 2021 11:58:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQqXK-0004Va-Jq; Mon, 29 Mar 2021 11:58:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQqXK-0002Is-JM; Mon, 29 Mar 2021 11:58:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9scCcSnzbYsAqlsI1e/cH6hacjjQr77DNVetge3Y3kQ=; b=MMoEskWTU4V41el8w32AGejBG4 24gFEv6BY4DBdHYaaNJxs49NDX9ceSFLkpOszwW+W57uHga6skA69x5fYKWzF20LtRPyJX67F16w/ m4+1BM7iCdlyhNO2XDC1wtpJwmhu/4gnbv9OmrrJbg2wBv+v/wAQT/7CsT1DUYxyvYGk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160510: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:heisenbug xen-4.12-testing:test-armhf-armhf-xl-multivcpu:xen-boot:fail:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Mon, 29 Mar 2021 11:58:26 +0000 flight 160510 xen-4.12-testing real [real] flight 160528 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160510/ http://logs.test-lab.xenproject.org/osstest/logs/160528/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail in 160487 REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 18 guest-saverestore.2 fail pass in 160487 test-armhf-armhf-xl-multivcpu 8 xen-boot fail pass in 160487 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 160487 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 160487 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 160487 never pass test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 40 days Failing since 160128 2021-03-18 14:36:18 Z 10 days 11 attempts Testing same since 160150 2021-03-20 04:11:48 Z 9 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 29 12:38:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 12:38:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102992.196570 (Exim 4.92) (envelope-from ) id 1lQr9b-00077b-4q; Mon, 29 Mar 2021 12:37:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102992.196570; Mon, 29 Mar 2021 12:37:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQr9b-00077U-0k; Mon, 29 Mar 2021 12:37:59 +0000 Received: by outflank-mailman (input) for mailman id 102992; Mon, 29 Mar 2021 12:37:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQr9a-00077P-0o for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 12:37:58 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 33d6a0f6-b104-40fd-b0a2-31b77d91a112; Mon, 29 Mar 2021 12:37:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33d6a0f6-b104-40fd-b0a2-31b77d91a112 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617021475; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=4idDrxBKZSHFRDZEbM6XCcepBAu9MgzmPXsNV02RIiM=; b=ghGZs93Y2s/Bzs2e7socpEu4hzjVMNW8Gl3Ykl46oPNHQj4CmPaYkNZw weOfVuzNBqi++Vaz2LIxqn0u2HaQ4Qaq98xq94aOzvnXx+ObsIx0Ncstl 5ijxoMYRmkoSEBu/UFD35L95SnkhMOMtQSTg7z6lD8pDR3ajyZ4r+3j3Z w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ZgAQoO9VXWa+Y2aK+SijLq16rkMLFHV7D0IVYS+jDK7TqEs0A3ZWBdDdIEZQkRobj0WxxDiNQp eO3ioKbCIq/DNOoQUQU98A7oTRHX5b+TDAlFJ5/fkw1Qz3/rMrg4vp/rs/5sTSz3TQQb5UkLmn iaHXn4rUVXTNRkqsiy9wCSM9EbNVDyqT1W6Y1Ch0BlikgJ+WHUNbxWVRMdAbZRjtsR8LMAEUEb k9v1/GdjYxscuOgwH7uSaeeBrWwMYOjq3pu1Qsz7haB8ALDHAT2FtCMxA/N5iHP20BvtSkCzXy dMQ= X-SBRS: 5.2 X-MesageID: 40216756 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:aBijpKi54jFIEcnLoPTMeVSqKHBQX2pw3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+YsFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmuZ tIW5NVTOf9BV0St6vHySGlDtctx8SG+qi0heHYi0xgVx1udrsI1WZEIyywe3cGIzVuL5w/CZ aa+45rpyC4f24Wc8S8ARA+LpL+jvfMk4/rZgNDOgUu7xOAgSjtxLnxFRWZ2Rl2aUIz/Z4J92 /Znwvlopiyqv3T8G6m60b/zbRz3OHgxNxKGdCWhqEuRAnEpw60aO1aKt+/lR8vpuXH0idOrP DtpFMaM913+zfteAiO0GfQ8i3B9Bpr1HP401+fhhLY0LzEbRY3EdBIi44cUjax0TtYgPhG3K hG332UuvNsZHuq9kSNhKm7azhQmkW5unYkm+II5kYvKbc2U7NNsZcZuHpcDZZoJlOK1KkcDO JsAMvAjcwmF2+yUnaxhBgK/PWcGl43HhuAX3EYvN2U3zV8jBlCvjUl7f1asXEa+J0nTZ5Yo8 zCL6RzjblLCvQbdKRnGY46MIeKI12IZSiJHHOZIFzhGq1CE3XRq6Tv6LFwwO2xYpQHwLY7hZ ypaiIWiUcCP2bVTeGe1pxC9R7ABE+nWy72981Y759l/pXhWbvCK0S4ORATuvrlh89aLtzQWv 61Np4TKeTkN3HSFYFA2BC7c4VOKEMZTNYetr8AKhOzi/OODrevmv3Qcf7VKraoOy0jQHnDDn wKWyW2C95H6mytR3/kkDncU37gYSXEjNBNOZmf29JW5JkGN4VKvARQo0++/Nu3JTpLtbFzXE YWGsKjroqL4U2NuUrY5WRgPRRQSmxP5q/7bn9MrQgWd2f9cbMJvcSjaXlftUH3YiNXfofzKk pytl538aW4I9i73iY5Ee+qNWqckj81qG+VSYwf3omO/93sdJ99LptOYt0+KSz7UzhO3Sp6om ZKbwEJAmXFECn1tKmjhJsIQMfFd9d9hw+vCdVOqW3WsHidoc1HfApZYxeeFeqsxSo+TTtdgV N8t4UFhqCbpDqpIWwjxNgjPEZ0c2SRCrJeBAGjbIFZ84qbPz1YfCOvv3i3mhszcm3l+wE3in b6JSOZQ/3NH2FQo2tVyKrs7VNyeFiMZk4YUAEIjaRNUUD9/lpj2+6CYaS+l1GcbVYP2ckxGj DIazl6GHIk+/mHkDqu3BqSH3QvwZsjetHHBLM4arfJxzeGM4uTj5wLGPdS4bdoPN3jqfUwTO qaYgOZRQmITd8B6kiwnDIIKSN0oH4rnbfUwxXj9nG/x2N6LvzIIlhqLotrVe203izBfbKv35 p4h95u4rf1HWX1d9KcyabYKxREMQjepGaqT+cu7bBY1JhCwIdbLt3+a3/v0noC4TAVaOHTv2 kaSL5g4L/ANpR0FvZiMx5xzx4MrpC3MEAvsgbKGecwclEmsm/DM7qyks/1gItqJnfEmRD5Nl ae+RBM5vvpXyOM0rgBFqI7SF4mH3QU2TBH/OmYcZfXBxjvX+Zf/ECiOnvVSs4WdIG1XZERpA 19+deGgqu+cDf5whnZuX9eLrhV+2iqBeO0DwTkI58Ez/WKfXCNiLCt+si9kXPeTia6cV0Rgc l9TnMrB/4zwwUKvckQySi9Sqv+v0IjnR9/2Fhc5yHQ87njxnzaE0FAORDembNMU1BoQyG1sf g= X-IronPort-AV: E=Sophos;i="5.81,287,1610427600"; d="scan'208";a="40216756" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zz264yQMqD9j129/wufzTz3FYmi8f4HFoZbf+XjruJXwp2h9GvkearAgoWTIxFuQaO17Qdx8UcjG0ZBpfH0R4hktBKTopkaFDjoeqqGZWBjWvmXf5B1mxmMXRgW+NrWtKVHxSMhD/1VdHFmFseeHCxVgw19SmYLXzCcYx0VEeIleGU84F9ipdubwQsU3qMW8x8X4o9bdwA3O3ZP2RbUCs+oy1Ody72F/jNsNNSqtwO3ATophbIvWuVYqqpwzM19Exa80eiD2dvrNm/Dn0akhmgiT5p/6cqXD/DVn1FaSQtmxcZNXzHqTVGvCftwiAicGKtX7jI1m0D9TVx/QqQq1nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eyBV7zHMzFJCj8rDmDB0bcHX/O+15gumP0+JefsQLyc=; b=V63A7fNP7n6KIEcGiWjwdMhtWivK80v0exD3I/Ao7I6sKBVOIl1FRNn9y5zGnSvi+xpl3H1+EaPwXCgEbmUA5zeb1AuX+1UMaKdReogPvgx1Ush0evBYr1jbs86M8RIeBoP4WI5d3yHGJ1aN/WRcvJFZs+iu6zbmSMFQG/Y+sWmMUzn0eRsE5pSbUzNbP+a8papJ9J/YcTAyhBMn1ya9QADIyvXgD1SrWICAHWe2bAkAHlxBkQ/b68WGEwVZdhYC6Wnl6G539aeO6ST0EsFz1yU2nSbagyyFWPxc0l9xMjhyo8nG4mbmIvMueSk5lQVvgwm5CAEoFpw7TwHFZLm1Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eyBV7zHMzFJCj8rDmDB0bcHX/O+15gumP0+JefsQLyc=; b=CQ5W1q+EgWk2fWNy84uet9VXH4aViC8gSpoe5D94g6PoAlZRiY60Dq2GGrFYuGpKpmas7gDzqAtSndDGY3/j04KClyD2KIYzQUD02Y8gPopHO6BuCi6HeWMrbeq9AQJJ8yUQK8rXt+1arBlGjrP/hzpE9IawggmzmXYC2G2vWUg= Date: Mon, 29 Mar 2021 14:37:46 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Xen-devel , Jan Beulich , Wei Liu , Ian Jackson , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , =?utf-8?B?RnLDqWTDqXJpYw==?= Pierret Subject: Re: [PATCH v2 3/3] x86/hpet: Restore old configuration if Legacy Replacement mode doesn't help Message-ID: References: <20210326185947.23243-1-andrew.cooper3@citrix.com> <20210326185947.23243-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210326185947.23243-4-andrew.cooper3@citrix.com> X-ClientProxiedBy: MR2P264CA0167.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::30) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f95a6879-eb1d-41a6-5cd2-08d8f2af781a X-MS-TrafficTypeDiagnostic: DM6PR03MB5323: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E97ZlP7/20aKiEVKQbVBlTSCLjtY6SQqLkseox+xVr9N4prORr3eyk6VSe6CTlPvyzLioPxE/FDaGZ/CWex4wsZ6DEQbqa4USEl1KQ+P3l/3tAUnFMRJG4jEdsjqDDZgajIZVXiGVii2KgX5vyElUDTPWvQppuDV/M8LjNO9nf21S19yWJvqG+SOkxlvtWTLHP/th+/U3lU7MFPBTzJRbRWRyacFPgU7BdW7OCaDVLHvVTVpGbQdX3CxwPHEQuHYZryKGYlrxbHQD8mAKkOblbI0BN8lHf/4IeWjU02w84U9AYz04VH6r1eRJmJEFKLjpBuw1ZROnkBVlve6NzGG+ikDza+tw8xKcO423GMSaGWqbJ9jX/3nlmjV4ykwu9ybAU4z/fG3h7DMaoxdkU0pb02WxYN8uQNUjlw8WJ4UvVIj4rGpgRCoyoScgGxy899aDO7C1DzhoGuFEzc9xRB2ZqND8VXNjwo8TjY8lLc+V6n73JuDxBnN7TmyCyRNHIlukCutPbtJIuLodD2lw7KdpcYk2iSa8vJL2lff2srmcHGTQeSvuYoqSJ3r/ky2zWWV9FCzKoclM3JtEbgyNf5c72ynZUwrEKEwwJb+8TLcr7N4hXiWtsCdrpFyANXoFZw3ww1d9gmCbvTopIgn1Uq8LIhMX75ou+x2k7nksd0IRzY48atDwCn5OiAFtq12H3RN X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(376002)(396003)(346002)(39860400002)(136003)(366004)(83380400001)(6636002)(54906003)(4326008)(316002)(956004)(2906002)(8676002)(6496006)(6862004)(66476007)(9686003)(66556008)(6666004)(8936002)(66946007)(6486002)(16526019)(186003)(26005)(5660300002)(86362001)(38100700001)(33716001)(478600001)(85182001)(66574015)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?b054NW5zejY1S0VCVld4alBuanI1NzVvMXo2enFPSUl1YWJNL1psNU50WXR2?= =?utf-8?B?THhvWkdKNzR5NXJSVUhkVi94MGFKcTRvM2g4eUdmU2E0NE9DOWRRY0ZTeHNF?= =?utf-8?B?WDlFRS9jTVI4L1J5TFlWTVFPNytNQkpBTDJzb3pZakJIVEo4SGRYVGJWbExZ?= =?utf-8?B?ajB2emNrNmlhRkxDbFo5MnJ6ZUtaMzhJd0NmZmdPWkFnbVc2TGlpdElwZnBO?= =?utf-8?B?dzhBVjlhdEIva2pJa1VLYzExQ01XN243N1Rlc0xpYWdYaWNlUGhZdG5kcHBL?= =?utf-8?B?NFBteGYwdFdOQjdwTURUbUZhdGhsWG04WWxpanBRdzdXTnlmQitCOS83aTV4?= =?utf-8?B?Um8wUzk0RGc0dkNZNmJBanlZYWxsYzFKcE1FVmJYcEtUZUtiSTNEcExJaWRa?= =?utf-8?B?QjIrWGhQVm40enpab3pHRUdNNnVNMzBQYXVlTVBUdEhOTFhVRXdEaGh1WUcx?= =?utf-8?B?cmt3UFRKWGxPQ09NdnUyUDhsOERyWFM5L3JmeElhbXJ5Z1dhUG5IMjcvMVIy?= =?utf-8?B?d1pyVm1hWG1Iejh0Q3YrS1BNOGQ0OHZHeDlwMTVRKzkxV3Z0cllKVXJ5YUlC?= =?utf-8?B?eWgwMW4zUkluRVVhbWUvOU5GdDFpbXlXNkZNQlI2OXgwaW5OYVpDczFua2NX?= =?utf-8?B?RDdGMytjd3l6YnJyaE4vRFI2ekNUSW5TOFN2c0FNeE5oWUczQlpRc1Y0Q2x4?= =?utf-8?B?MFN3OCszSGQ1TDlFdCtqQUtMNElBcXl0N2daZ2N1T01HQW9kYUJMY1JiSjVW?= =?utf-8?B?UW1wbjIzbzZSK2pFMXkyaUx3REF6L2s3YnF2MGFDYWhuS1ZmT1N6S09LemlK?= =?utf-8?B?K3Bmd0VwM3dobjEyWFdnL2VaSURsbEtFRFFkalJpVWlyN0hPdklkOE1Vd0di?= =?utf-8?B?VmpWcklnVHM4WTlhWjNwcnlHWmtmay82aWhqL1FQdmNwWFZSQXltVExXTFl3?= =?utf-8?B?Qzl1aG13cGxRdHRKeVJQZmoydXJFWFIvd3hScmxsdEppSCtaY1pocEdOUDlZ?= =?utf-8?B?ZVRHYnpIYVl0ZTU1d01aTnBabGVtRXVQL2NtL0Q4NXNqQWFNZnBoY3VIR0g1?= =?utf-8?B?MkNUcVZLYTBaL0R1bzJQM3VuaHdReGQwS3E2M3RvRmgrcHZUcjBySnIrRFdS?= =?utf-8?B?eURpM1NIOGQ5Q3VFeEI4eVU5WVRZVDZzNmQyS0YwSytUUXI2Ny9HMThhaDRj?= =?utf-8?B?bUVQaEpEdEJGczB4cHc1UzFZTTk1N2J4d3hLdStiOFdxSS9vUWZidWtOZjl1?= =?utf-8?B?Mnh5QWp5bW8yWVNoVVNucWN4WVVtbUdNMWNqVVhkaWZqSVJxVndkSm5jUjBt?= =?utf-8?B?L0IraXBZamI1WE1xYnBMU0RWSExDVmF5V2tZNGxOQkoxQ0YxWmw0a3FRUEV0?= =?utf-8?B?MFVCVzhYdFFsLzBaNVhQellPa3dFclRLZURnNGMvRVZMZFZqd1hZTTdwWEhJ?= =?utf-8?B?bWRFRURRWXB6MUdCY21pc3VYa09LYW5ram9iK1dmTTJlNjRzejM0VGgyRHJx?= =?utf-8?B?R3lDeXIzeFltM1Boa2thcWs2K0c1Sy9TRFg3MDFqdzhlNm5VdDBTUTQyakJh?= =?utf-8?B?cU1GMUowb2U1UVdaUkI3d3ZZU3p4UWI2R3pkZGYvYXZFK0gvVnI4eUNQdzZF?= =?utf-8?B?V0VjbWk3MGdKMUgrL2JmdzN2YVRQMGpmOEFCSytqQWIrMHhMMmZLNFM1SGVH?= =?utf-8?B?YlVvZDJPSEpJM2pCTms1TFBma2NxQjVvQXNzd0Q1Vy91b1VVbU9oam5NUWs5?= =?utf-8?Q?51GHLcmNSQNOU6GT8Hd+r+b3S7XiWG9e5yTqHZ6?= X-MS-Exchange-CrossTenant-Network-Message-Id: f95a6879-eb1d-41a6-5cd2-08d8f2af781a X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 12:37:52.5707 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c2s+iZFHr4SPIrH8urFBeJra7EglEkVQFcb/HbGcPI7BRI0iIijdquWGnlAtkQTDrk2qHwrH67CNkRcPlo4c+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5323 X-OriginatorOrg: citrix.com On Fri, Mar 26, 2021 at 06:59:47PM +0000, Andrew Cooper wrote: > If Legacy Replacement mode doesn't help in check_timer(), restore the old > configuration before falling back to other workarounds. Oh, I guess this answers my question from the previous patch. > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > CC: Ian Jackson > CC: Marek Marczykowski-Górecki > CC: Frédéric Pierret > > v2: > * New. > > For 4.15: Attempt to unbreak AMD Ryzen 1800X systems. Is this really the fix for AMD 1800X? I assumed not setting the HPET into legacy replacement mode unconditionally was the fix for those systems? > > I'm tempted to fold this into the previous patch, but its presented here in > isolation for ease of review. > > Tested by repositioning the timer_irq_works() calls on a system with a working > PIT. > > (XEN) ENABLING IO-APIC IRQs > (XEN) -> Using old ACK method > (XEN) ..TIMER: vector=0xF0 apic1=0 pin1=2 apic2=0 pin2=0 > (XEN) ..no 8254 timer found - trying HPET Legacy Replacement Mode > (XEN) ..no HPET timer found - reverting Legacy Replacement Mode > (XEN) TSC deadline timer enabled > --- > xen/arch/x86/hpet.c | 27 ++++++++++++++++++++++++++- > xen/arch/x86/io_apic.c | 4 ++++ > xen/include/asm-x86/hpet.h | 6 ++++++ > 3 files changed, 36 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c > index bfa75f135a..afe104dc93 100644 > --- a/xen/arch/x86/hpet.c > +++ b/xen/arch/x86/hpet.c > @@ -783,6 +783,9 @@ int hpet_legacy_irq_tick(void) > > static u32 *hpet_boot_cfg; > static uint64_t __initdata hpet_rate; > +static __initdata struct { > + uint32_t cmp, cfg; > +} pre_legacy_c0; > > bool __init hpet_enable_legacy_replacement_mode(void) > { > @@ -796,8 +799,11 @@ bool __init hpet_enable_legacy_replacement_mode(void) > /* Stop the main counter. */ > hpet_write32(cfg & ~HPET_CFG_ENABLE, HPET_CFG); > > + /* Stash channel 0's old CFG/CMP incase we need to undo. */ > + pre_legacy_c0.cfg = c0_cfg = hpet_read32(HPET_Tn_CFG(0)); > + pre_legacy_c0.cmp = hpet_read32(HPET_Tn_CMP(0)); > + > /* Reconfigure channel 0 to be 32bit periodic. */ > - c0_cfg = hpet_read32(HPET_Tn_CFG(0)); > c0_cfg |= (HPET_TN_ENABLE | HPET_TN_PERIODIC | HPET_TN_SETVAL | > HPET_TN_32BIT); > hpet_write32(c0_cfg, HPET_Tn_CFG(0)); > @@ -843,6 +849,25 @@ bool __init hpet_enable_legacy_replacement_mode(void) > return true; > } > > +void __init hpet_disable_legacy_replacement_mode(void) > +{ > + unsigned int cfg = hpet_read32(HPET_CFG); > + > + ASSERT(hpet_rate); > + > + cfg &= ~(HPET_CFG_LEGACY | HPET_CFG_ENABLE); > + > + /* Stop the main counter and disable legacy mode. */ > + hpet_write32(cfg, HPET_CFG); > + > + /* Restore pre-Legacy Replacement Mode settings. */ > + hpet_write32(pre_legacy_c0.cfg, HPET_Tn_CFG(0)); > + hpet_write32(pre_legacy_c0.cmp, HPET_Tn_CMP(0)); > + > + /* Restart the main counter. */ > + hpet_write32(cfg | HPET_CFG_ENABLE, HPET_CFG); > +} > + > u64 __init hpet_setup(void) > { > unsigned int hpet_id, hpet_period; > diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c > index 3f131a81fb..58b26d962c 100644 > --- a/xen/arch/x86/io_apic.c > +++ b/xen/arch/x86/io_apic.c > @@ -1955,6 +1955,10 @@ static void __init check_timer(void) > local_irq_restore(flags); > return; > } > + > + /* Legacy Replacement mode hasn't helped. Undo it. */ > + printk(XENLOG_ERR "..no HPET timer found - reverting Legacy Replacement Mode\n"); > + hpet_disable_legacy_replacement_mode(); I think you could also get away just calling hpet_disable and hpet_resume? (bypassing the system_reset_counter check) Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 29 13:13:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 13:13:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.102997.196582 (Exim 4.92) (envelope-from ) id 1lQri2-0002mP-TV; Mon, 29 Mar 2021 13:13:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102997.196582; Mon, 29 Mar 2021 13:13:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQri2-0002mI-PU; Mon, 29 Mar 2021 13:13:34 +0000 Received: by outflank-mailman (input) for mailman id 102997; Mon, 29 Mar 2021 13:13:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQri0-0002mA-Ti; Mon, 29 Mar 2021 13:13:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQri0-0005xV-Ko; Mon, 29 Mar 2021 13:13:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQri0-000186-Bp; Mon, 29 Mar 2021 13:13:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQri0-0004ZJ-BJ; Mon, 29 Mar 2021 13:13:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=DYKkIKQk0AKPNOFy7InfX63g0sxdyH+Brhidpa4NXvc=; b=TAOZXaSnDESu0vmFOOUsiL4Hlp vwffIvZ/veXWcFjZoVtGAxwivPj7B93oiDjj4WNFCX5WMZNsnTGVe7VkKefUbMBTSeSa9/UEAjyz8 KP86XiuSjdZDv404c5xC5qM0BfmUbSM0JT7RB5l5Ecdv93gvtG6zFp7fbZnl+/2yvLyY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Subject: [qemu-mainline bisection] complete test-amd64-amd64-libvirt Message-Id: From: osstest service owner Date: Mon, 29 Mar 2021 13:13:32 +0000 branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-libvirt testid guest-start Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8d17adf34f501ded65a106572740760f0a75577c Bug not present: e67d8e2928200e24ecb47c7be3ea8270077f2996 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160530/ commit 8d17adf34f501ded65a106572740760f0a75577c Author: Daniel P. Berrangé Date: Mon Feb 22 11:16:32 2021 +0000 block: remove support for using "file" driver with block/char devices The 'host_device' and 'host_cdrom' drivers must be used instead. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/test-amd64-amd64-libvirt.guest-start.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/test-amd64-amd64-libvirt.guest-start --summary-out=tmp/160530.bisection-summary --basis-template=152631 --blessings=real,real-bisect,real-retry qemu-mainline test-amd64-amd64-libvirt guest-start Searching for failure / basis pass: 160501 fail [host=godello0] / 160125 [host=albana1] 160119 [host=albana0] 160113 [host=fiano0] 160104 [host=huxelrebe1] 160097 ok. Failure / basis pass flights: 160501 / 160097 (tree with no url: minios) Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced Basis pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2615a5e433aeb812c300d3a48e1a88e1303e2339 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/libvirt.git#2c846fa6bcc11929c9fb857a22430fb9945654ad-2c846fa6bcc11929c9fb857a22430fb9945654ad https://gitlab.com/keycodemap/keycodemapdb.git#27acf0ef828bf719b2053ba398b195829413dbdd-27acf0ef828bf719b2053ba398b195829413dbdd git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0\ dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#4751a48aeb2ab828b0a5cbdc585fd3642967cda1-b33cf5bfcb4c941370739dfbbe1532ff508fd29d git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#2615a5e433aeb812c300d3a48e1a88e1303e2339-7b9a3c9f94bcac23c534bc9f42a9e914b433b299 git://xenbits.xen.org/osstest/seabios.git#b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee-b0d61ec\ ef66eb05bd7a4eb7ada88ec5dab06dfee git://xenbits.xen.org/xen.git#b4011741e6b39a8fd0ed5aded96c16c45ead5888-e680cc48b7184d3489873d6776f84ba1fc238ced >From git://cache:9419/git://git.qemu.org/qemu ec2e6e016d..5b1ddcbd0c staging -> origin/staging Loaded 25156 nodes in revision graph Searching for test results: 160091 [host=godello1] 160097 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2615a5e433aeb812c300d3a48e1a88e1303e2339 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160104 [host=huxelrebe1] 160113 [host=fiano0] 160119 [host=albana0] 160125 [host=albana1] 160134 fail irrelevant 160147 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2e1293cbaac75e84f541f9acfa8e26749f4c3562 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160167 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ca318882714080fb81fe9eb89a7b7934efc5bfae 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 bdee969c0e65d4d509932b1d70e3a3b2ffbff6d5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160328 fail irrelevant 160361 fail irrelevant 160392 fail irrelevant 160418 fail irrelevant 160448 fail irrelevant 160477 fail irrelevant 160494 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2615a5e433aeb812c300d3a48e1a88e1303e2339 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160497 fail irrelevant 160498 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 f2a9a6c2a86570ccbf8c5c30cbb8bf723168c459 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160499 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8a40754bca14df63c6d2ffe473b68a270dc50679 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160500 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 1db136a29ce8594b693938ab8e788d8bcef54770 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160502 fail irrelevant 160503 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 24e13a4dc1eb1630eceffc7ab334145d902e763d b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160504 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2255564fd21059960966b47212def9069cb56077 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160505 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 773b0bc2838ede154c6de9d78401b91fafa91062 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 5e8892db93f3fb6a7221f2d47f3c952a7e489737 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160515 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 81cbfd5088690c53541ffd0d74851c8ab055a829 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160506 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8b858f9998a9d59a9a7188f2c5c6ffb99eff6115 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160508 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 30ca7eddc486646fa19c9619fcf233ceaa65e28c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160509 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 2e51b27fed31eb7b2a2cb4245806c8c7859207f7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 38c4101deba795214b5b4d6ce2826fd050ce1a9d b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160511 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 773b0bc2838ede154c6de9d78401b91fafa91062 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 56b89f455894e4628ad7994fe5dd348145d1a9c5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160512 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6e71c36557ed41017e634ae392fa80f03ced7fa1 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160513 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 146f720c55637410062041f68dc908645cd18aaa b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160514 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160518 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160520 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160501 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160521 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160523 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2615a5e433aeb812c300d3a48e1a88e1303e2339 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160524 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160525 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160526 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160527 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160530 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 Searching for interesting versions Result found: flight 160097 (pass), for basis pass Result found: flight 160501 (fail), for basis failure (at ancestor ~6) Repro found: flight 160523 (pass), for basis pass Repro found: flight 160524 (fail), for basis failure 0 revisions at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 No revisions left to test, checking graph state. Result found: flight 160520 (pass), for last pass Result found: flight 160521 (fail), for first failure Repro found: flight 160525 (pass), for last pass Repro found: flight 160526 (fail), for first failure Repro found: flight 160527 (pass), for last pass Repro found: flight 160530 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8d17adf34f501ded65a106572740760f0a75577c Bug not present: e67d8e2928200e24ecb47c7be3ea8270077f2996 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160530/ commit 8d17adf34f501ded65a106572740760f0a75577c Author: Daniel P. Berrangé Date: Mon Feb 22 11:16:32 2021 +0000 block: remove support for using "file" driver with block/char devices The 'host_device' and 'host_cdrom' drivers must be used instead. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé Revision graph left in /home/logs/results/bisect/qemu-mainline/test-amd64-amd64-libvirt.guest-start.{dot,ps,png,html,svg}. ---------------------------------------- 160530: tolerable FAIL flight 160530 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/160530/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-amd64-libvirt 14 guest-start fail baseline untested jobs: build-amd64-libvirt pass test-amd64-amd64-libvirt fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Mon Mar 29 13:30:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 13:30:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103007.196599 (Exim 4.92) (envelope-from ) id 1lQryK-0004in-Hv; Mon, 29 Mar 2021 13:30:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103007.196599; Mon, 29 Mar 2021 13:30:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQryK-0004ig-Ev; Mon, 29 Mar 2021 13:30:24 +0000 Received: by outflank-mailman (input) for mailman id 103007; Mon, 29 Mar 2021 13:30:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQryJ-0004ia-8N for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 13:30:23 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 78514f58-c487-4737-bc10-bbdd444ae5b4; Mon, 29 Mar 2021 13:30:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78514f58-c487-4737-bc10-bbdd444ae5b4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617024621; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=BneQqjWA+L829Hm2sWZKRRmYubGcDsANn3Y2Su4QpEg=; b=KxDECH06uFyjvxF+3NEmEc8WmOsOYFbwL4DCieMBvS9laawzRZVylewJ ltEa5+TQJqcIS1EK6AGQilsZD5su5wsGKZtTZZVPAn0aY5kc+6Ge42Btw 0dDzUVdqNDcjiYCQWsD2DpgrVQP9sKIX8Y5veWGswTmOdrUmZCRYxWURy s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: raY8cfnV2KhPcZrh3unUkptJZFf5LTGRLEiAxrp21oz+daX8ejF0lvYfiyAP7i/xSmSHW3ImjW dDLPXabpdoVGwBbIjLJzIJBtNPr4vdH1PxMKkSVg9F7AI+kE/AYLQjUzD7mz2FsWZO98sAuc78 pMoLqNHGxGK/sPfUo15Rl39/ofEs5DDYygvxEe5gVjJC0FgX2FX9PrchNvjJ3EzGORiUJeObA5 WdWjpsfkWWhvezS8bBwOEUmYFOEICYYhNhcrFL1V0ZhQrc9TQvnuEUnPlbE3e+SzEAJDe9V+Gf KR4= X-SBRS: 5.2 X-MesageID: 41790294 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:YDPsFqAnuZwNrJflHeg9tMeALOonbusQ8zAX/mhLY1h8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPufVr1zrQwxYUKJ7+tUE3duGWuJJx/9oeK+VHdMgXE3Kpm2a 9kGpISNPTZEUV6gcHm4AOxDtYnx529/Lq1gPrFpk0NcShBQchbnmBEIyycFVB7QxQDKJoiDZ yH5tdGoT3IQwVsUu2QAH4ZU+/f4+DajZ6OW298OzcLyimryQmp5rnzDgSC0n4lPQ9n7L8+/Q H+4m7Ez4q5tfXT8G6460by6NBslMLl2p9/AqW3+7UoAxHNrirtW4h7Qb2Fu1kO0ZCSwXInis PFrRtlH+kb0QKpQkiPrRHg2xbt3V8VgheIoz/o4gqRneXDSD03EMZHj45CGyGpk3YIh91gzL lNm1uQqps/N2K/oA3G+9PKWxt2/3DEx0YKrOh7tQ06baIuLJVVrYAZ4XpPFoYBEC/Q+OkcYZ ZTJfCZy/BMfVyAaXfF+kFp3dy3R3w2WiyLW04Yp6WuonVrtUE863Fd6N0Un38G+p54Y55Y59 7cOqAtsL1VVMcZYY90Ge9pe7r6NkX9BTb3dE6CK1XuE68Kf1jXrYTs3bkz7Oa2PLQV0Zobgv 36IRJlnF93X3irJdyF3ZVN/ByIan66Ry7RxsZX4IU8kqHgRYDsLTaIRDkV4oWdisRaJveed+ e4OZpQDfOmB3DpA5x10wr3XIQXBmIZVOETp9YnS3ODqs/GMeTRx6/mWceWAICoPScvW2v5DH dGdiP0Pt984keiXWK9oBW5YQKuRmXPubZLVITK9ekaz4YAcqdWtBIOtFi/7saXbRlLsqk8el pCMKrq+5nL4FWezCLt1SFEKxBdBkFa7PHLSHVRvzIHNEvybPIlt8iAf3tRmF+KPAV2Qc+TMA M3nSU5xYuHa7irgQwyAdOuNWyXy1EJomiRcpsakqqfoeH/ep05CZ4icLdrFRrCEiF0nQoCkh YCVCY0AmvkUh/+g6Ssi5IZQMvFccNnvQutKclI7U7EuV6kvsEpTHsDVzuIWcqa6DxeAwZ8tx lUyesykbCAkTGgJS8ajP4jOFNBUmiRHYlLFR+IfolSh7DtdjxhVGviv03rtzgDPk7Rs2kCjG 3oKiOZPcvGBVdQoVh0+Kfn+lEcTBTUQ2tALlRB9aFtH2XPvXh+ldKRbq2oym2Ldx8p2ecGKg zIZjMUPyJjz926zwSuhT6HDHkqr69eedD1PfAGSfX+y3mtIIqHmeU6BPdS5o9iL82rnekRU+ 6TEjXlWw/QOqcM4UiyqXkkMiUv9yVhvvPsxRH/7G+3mFQ4GuHfJVx6R7cdZ/GQhlKUMsqg4d Fct5YSu+D1D0DaLvih4ovTZyRYKhzSrXWtJttY4Kx8jOYXjv9LA5LfUTH0z3lJ0xU1EdfsmC olMdZGyYGEHrUqQtcbdC1Y9Gc4jdijLEMktQrtH+81FGtd+0PzDpes47DSr6AoDVDEjAzsOU OH+yk1xYaPYwKzkZobAbk3O2JYdQwV72lj5vqLc8n1BB+xf+9OuHq8PXnVSs4WdIG1XZERpA 19+deGgqu+cDf5whnZuX9DGZ11mlzXN/+aMUarAu5H89uzJFSKjO+L2aeI/UvKYAr+TV8Zi4 1DfVEXdeJZhFAZ/csK7hQ= X-IronPort-AV: E=Sophos;i="5.81,287,1610427600"; d="scan'208";a="41790294" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZtZDf133Hsy34eHpyVqspzpo11gmm6XVqZehMy62PvivBZPvUficUurSoC2meM0Z2XrweCJ4RNt275cd6mNa+ABTN28iLQijtMW1NsPjLmIZPnMTpaKwFhgLF8uy5SceMaBuR7tHiPJdlqrnz5zEIDhM2SaL1Y+kUR7TxqsCRExPUaywI9ckHjLfU7ZdTIN4dI08frC1OWvazXM8Y4EV2vk5JKWeLcE/GmHKu1RQ4xSoF+MQc6UXRJOknoZ4GyR+SUJMH07Sngzn+9jKeM1E/wnRKqqhnuDDlUmwYAxUaGr5rFpbt5wrNPuhpYr+gdz7B95KtbwV6ePo7e8HOjYaYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y8wPWxshNdlqgKNpGnz2SunT3zjIl81yeO8oPT7gk0g=; b=Cizc3s73R6Zrg3PGN98/lYPLStW3XCVmbiZG800Aq3IM102LNBm0m3uiwIr6Jt372OEecFimCdF6E/Yh3KSJFxSPSGwMiAEdaVWUodyd3QmxQdiuQPhgDg4CXR7Rpy60htt9+eR+ES+XVrxpZpmwNPhDZgFr2eFE72H/dNrwLALNf28l+P37U77qZSEpe+n+TeWW6+y1PLFUCAKj4Lkl3peq9PKsXmvcYZ1RXJZ3v0aJOcmei5Ik8XV3WsA86Ht4w+U0KC1w5xYVxAdTV02AojiryrPFq/uq4F52rLsK8kW0ObexOGaBl6tC8by344uHoF/nYkMbCB6bPgxiA1YT6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y8wPWxshNdlqgKNpGnz2SunT3zjIl81yeO8oPT7gk0g=; b=CNdrdFsvMXb4DYRg2KbdU0CNEA+374E13wkvtYj1btteyTu6q/Pss4ek1EHUA0Rj/np1z+XtfkuVuDRs7l3sh01g3FYlOwDUwFO84WEKKQop7ou1/cxgolAluk1fNGFVeqc2zi68GAadq7VqDYrJtf0/y7T6GUxSlGwngeNRP1s= Date: Mon, 29 Mar 2021 15:30:10 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ian Jackson CC: Tamas K Lengyel , Andrew Cooper , Xen-devel , Jan Beulich , Wei Liu , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , =?utf-8?B?RnLDqWTDqXJpYw==?= Pierret Subject: Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally Message-ID: References: <20210325165224.10306-3-andrew.cooper3@citrix.com> <20210325172132.14980-1-andrew.cooper3@citrix.com> <24669.52641.499147.88002@mariner.uk.xensource.com> <24669.54213.173154.400771@mariner.uk.xensource.com> <24669.56958.383583.53595@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <24669.56958.383583.53595@mariner.uk.xensource.com> X-ClientProxiedBy: MR1P264CA0035.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2f::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8ab242ee-8976-4923-57d1-08d8f2b6cab2 X-MS-TrafficTypeDiagnostic: DM6PR03MB4059: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jlJMdoGFFLsbaOlR9kAVDGGy8zd5+xc6U9hehR1E0i6tG/QPobXekC6xoZrEZYmC/BUtM3piQZMNoKmbbQMb2wm9L/KxFrTBInSkGLBabpUOSRFVJtz6HVZldof9w63jQJ2XWUzc09QdjBiecMdn6c1Zqp8Q3OSsr5hg//jnygPOZRfItJVodNPcQmc+qXjjwQmCaC+iJRP/YVGQCbxFwLRt3KNJrXxby9F2I6O5Otx+vUUiEd7ysbcDifskrAGmTOgWZ05tNkbw/oX//AZjBhuziu/Ovf149MJcbhiKer0QLvza7in58EWXa0OYq3NyfOfUu0VCpiZPN1ZKx8FoQ4wZmHH3M5PELE4WLT9KXZH65jIUFqc4UScJ3yE7c5Lqn0Lo37LUWzkYMTizEIKw/Ve9xG5xIqME54q8h3uRKKrX+FL/Xk8Y5rEsZ5YEPxwyGMbZtIto7HeJcx5BwSHzD8LolYTCBsgXmJsuJkcXzAXi/2xLEjCjQD6ScN/i7aqrbayXnKNNPbr6An4vN8jVJJfkfdqWubPqr87COTLhIWvO3sJew8NweF3uHvE/DCkYHh/X7fr5ibmKbt/6LoRB106nKMC4XiUtS65DxAy1Q6Ii7scwen70dySwLqeSoy/tNgTinaWgwvd5JExsELBoz70eIILJxuwlWC1M3t3pGkY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(396003)(136003)(376002)(366004)(39860400002)(346002)(316002)(26005)(6496006)(83380400001)(8936002)(956004)(33716001)(38100700001)(6916009)(86362001)(186003)(6486002)(54906003)(4326008)(9686003)(66946007)(8676002)(6666004)(85182001)(2906002)(478600001)(16526019)(5660300002)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dGVjYTdTQU44eW1BQzFpRFBFWDBob3dXWEcySStPeXFmc2gyOHZITVpVVTBj?= =?utf-8?B?alROWTAzSEE5YVZFeUg1TEcxc3J1Wlp4U3BSQ3Y3a3F6NHBqNy9KL1dueVht?= =?utf-8?B?TCtEVWJKOEZRQWd0bCsrRUo2bVB3cHhqQzBzZklMOVR1Z0pLZC80QWNFZmdl?= =?utf-8?B?bk1YVE1JSzlOUEtlZHpwY0pFQXhqbFBVMm0rWmp5bkU0aThXQ21ySXRsajdl?= =?utf-8?B?UktGWFdmZXkxVGMvVTZVSzN0MmJhV2x4amo1VHVVNUNLb1BneExZOTBrSkJF?= =?utf-8?B?dzVLWFBPU1I2ZUUzdmxCR1BMMGJPM29ydXNtSTJNSUhsMS9PMHJzWDFmNTJY?= =?utf-8?B?T09paHRkKzhxYk5uSmNRK3pYZmh5REpOZ3BoMzZIVjBOZnc5ZVJCZ2FVcEZR?= =?utf-8?B?ZEJwblFEQTcydVdwT3J3L2xXSzhiV05aYksreElobmlEUEluZzFMUHJjdlBF?= =?utf-8?B?L2wwc2R5emdHNm1yMmF0bHhHNm1FTTRWZHlYZ1pMVGk3VDBwTERSTVhIVmF0?= =?utf-8?B?Q3EyOGp1aksvMU1CdkdqelVReGw1eVN5MTFNU1ExOVNlck0wWmlRK3ZpV3Zu?= =?utf-8?B?VWRna2pRMklCUXE4eXBRckNhZmhYQ0xld2V6RWVvRlo2YTIvcXhRaHh1S3dH?= =?utf-8?B?N3k5MTJCd3NZeFVyYmJWMHRDeVRJRUQ2c2orNU9INFdnV0J1cEJaOCtvbWs4?= =?utf-8?B?OEJ0MTQ0N0FLcHk1Z1ptbEszeTMxclBZRUZiWm51SzFSZGFCMzRLcmJwNlJE?= =?utf-8?B?bnRLUmVEbmRkaGdVNHV1cEl0Z2J5bm9oRjlGOGluSlB5K01Vc3hCWTZxbE9S?= =?utf-8?B?UHJ0VCtzUzk0dVJHM1lUTHhLQlVCM3p6aFhSaGJXcDhNbXB3d1kxNEFmZmhV?= =?utf-8?B?RUhhc0I1d0pMcTQ1Wit6MVNLSmJTQkV1QmwwNkRNMHB6b0dIeE5NcHI1aG4y?= =?utf-8?B?NVZTRHlNSFUxZDR0eW9FMnNWOWhySGxGMG03ZEpwbE5qTzRRMEJMQUZqamgy?= =?utf-8?B?czRPeGd1RkUwZitqV3prSUNUS2RGOTJHREpxOS9SeElLWVNCTkRFdjV3bk1Q?= =?utf-8?B?TGNXWUwwWEU4VDkvS09RVVBjTHAxWWxRa014aG1zR3IyT3VUT2VEZ0FKTHpi?= =?utf-8?B?dm9HVGtNZTcveXJhQmQzSHpEaFBweUVja1cxVmgycFJOcjhrTmhzZmRqNUI3?= =?utf-8?B?anJNRVNBNmp0Lzc5UUE0WFUrY3RpZDlYdFYxRlYveFNMOXFTc3dNbHdkQzVo?= =?utf-8?B?OU9QTnFNZ1lPbUZCcDdLV2lWMFI1NUN5cDN5UmhFTGkzaWVPcWNFTHgydWc3?= =?utf-8?B?elRkWU1MNkFweEdkbThQWEJTRDZrWDR2OC9KeVBMZlJlc2tRZVZMR2IyaHpV?= =?utf-8?B?QWZYVURzK2NrMnVMRDR3aEhvVTU0M1ZvT2gvaUcvS0pwS2pDNnkxanF2NG1V?= =?utf-8?B?SWg2bkRFeStXSmVPdGU3VGNXRUZpYWkrQnd5MTk2dkJNcEZMTnZpdGRKUGJQ?= =?utf-8?B?OEV5dUZPL0NsejFhalhxenk3MXBiaE9LVUF6T3R6ZkFaYUVDeE5zWm1lVmpZ?= =?utf-8?B?UjlSZEJ4MVdZNEFjWWFTNWxzUXpUQUNBbk04RnNvU0NLcXg4b2dtWjdDdVBO?= =?utf-8?B?MUdaSnhrRE90TElPdndJZUdsb0xPVVVMWGdkMEU4VEJodUpzYjRqYTBxV3lM?= =?utf-8?B?M1N2TmhqQVV1QW1Da2J1Q1czdThIcXg0aGhhaTlHZHM0NUtRbkloVlBadTFP?= =?utf-8?Q?l22ZtGVHWEUVfOCA9EGT383PFTdH1YSEXbDTAgt?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8ab242ee-8976-4923-57d1-08d8f2b6cab2 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 13:30:17.3153 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SX5EQXzZA011iDsY9peeBgONdOGcQoTOP/GuozCD2QUvKdr1Qpo1FBS/QEjzjAFAOM5LD6XyO50fsFpRT6QUvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4059 X-OriginatorOrg: citrix.com On Fri, Mar 26, 2021 at 01:15:42PM +0000, Ian Jackson wrote: > Tamas K Lengyel writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally"): > > The problem from my perspective is that the end-users have no way to > > determine when that boot option is needing to be set. Having an > > installation step of "check if things explode when you reboot" is just > > plain bad. Many times you don't even have access to a remote serial > > console to check why Xen didn't boot. So that's not a realistic route > > that can be taken. If Jan's patch is applied then the only thing I'll > > be able to do is make all installations always-enable this option even > > on systems that would have booted fine otherwise without it. It is > > unclear if that has any downsides of its own and could very well just > > kick the can down the road and lead to other issues. > > Thanks for the clear explanation. > > I think our options are: > > 1. What is currently in xen.git#staging-4.15: some different set of > machines do not work (reliably? at all?), constituting a > regression on older hardware. > > 2. Jan's patch, with the consequences you describe. Constituing a > continued failure to properly support the newer hardware. > > 3. Andy's patches which are not finished yet and are therefore high > risk. Ie, delay the release. > > Please let me know if you think this characterisation of the situation > is inaccurate or misleading. > > This is not a good set of options. > > Of them, I still think I would choose (2). But I would love it if > someone were to come up with a better suggestion (perhaps a variant on > one of the above). As the FreeBSD Xen packager I would consider simply adding Andrew's patches to the port under my own risk, and maybe do the same with the vpt performance fix, but that one is riskier as an issue there could lead to XSA-336 being re-introduced, so I need to carefully consider. I've cherry picked patches before to fix other issues before they hit the stable branches. I'm still trying to go over all emails, but if 2. is the chosen route could we describe in the release notes those issues and maybe provide hashes for the alternative patches provided they are in unstable by the time of the release? That way packagers will get an option to cherry pick those fixes at their own risk. It's not the best model, as we are just pushing a decisions towards consumers which might not have good judgment about the effect of those issues and the risk of the fixes, but seeing how much controversy this has caused it's likely an option to be considered so that we are not seen as hiding such patches from downstreams. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Mar 29 13:42:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 13:42:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103010.196612 (Exim 4.92) (envelope-from ) id 1lQs9k-00062s-NP; Mon, 29 Mar 2021 13:42:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103010.196612; Mon, 29 Mar 2021 13:42:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQs9k-00062l-K0; Mon, 29 Mar 2021 13:42:12 +0000 Received: by outflank-mailman (input) for mailman id 103010; Mon, 29 Mar 2021 13:42:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQs9j-00062d-C5; Mon, 29 Mar 2021 13:42:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQs9j-0006OF-2I; Mon, 29 Mar 2021 13:42:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQs9i-0002bW-Na; Mon, 29 Mar 2021 13:42:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQs9i-0003C6-N3; Mon, 29 Mar 2021 13:42:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DPsENyDRR6WCGNO+ZbHe6oDSu0jOPeVJqyM0OPZfwv4=; b=ai8TujGFVZiFJqQu1HRYDnlEXx 215kuqVEFFCFINXRLh6pheLP5vQGhNUqBxqlTFNi/4fZADl9a11srBKRkCGIpP60iCb5KgX+vwrPc xu0m4a0HjF7nTOPwyEgv/UTcG+qCC5kvIdMZjaCx/WxLE0oeaDkTs0B0JyGH/DddsoNo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160516: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a5e13c6df0e41702d2b2c77c8ad41677ebb065b3 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 29 Mar 2021 13:42:10 +0000 flight 160516 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160516/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux a5e13c6df0e41702d2b2c77c8ad41677ebb065b3 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 240 days Failing since 152366 2020-08-01 20:49:34 Z 239 days 409 attempts Testing same since 160516 2021-03-29 01:40:59 Z 0 days 1 attempts ------------------------------------------------------------ 5271 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1311071 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 29 14:10:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 14:10:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103022.196627 (Exim 4.92) (envelope-from ) id 1lQsb1-0000eY-2p; Mon, 29 Mar 2021 14:10:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103022.196627; Mon, 29 Mar 2021 14:10:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQsb0-0000eR-WE; Mon, 29 Mar 2021 14:10:23 +0000 Received: by outflank-mailman (input) for mailman id 103022; Mon, 29 Mar 2021 14:10:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQsaz-0000eE-Mr for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 14:10:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQsaz-0006wq-Lb for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 14:10:21 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lQsaz-0004gQ-Kb for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 14:10:21 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lQsaw-0001lF-Cc; Mon, 29 Mar 2021 15:10:18 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID: Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=KlRdUK1U4mJ2FB4CumiP+oB77O33dsxlKoyL1MmCPyU=; b=w2fvo70gOvj3xi9NvC3SpUdXNT VXlw6x7pL9u+UTxULaj9ckb92g+/ya2dUWplq1fw4W+k3houWVM3U/vltlsAkjpR//mCgcH3EvUqW sme5pkKMzq58kl+/LHHyhxV7JJEKrEOqD/WelKq1ux9ecGeFo4HGFH0K1vJh6MlQoriM=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24673.57290.133130.448247@mariner.uk.xensource.com> Date: Mon, 29 Mar 2021 15:10:18 +0100 To: xen-announce@lists.xenproject.org CC: xen-devel@lists.xenproject.org, xen-users@lists.xenproject.org Subject: Xen 4.15 RC5 Xen 4.15 RC5 is now available. It is available from git: git clone https://xenbits.xenproject.org/git-http/xen.git -b 4.15.0-rc5 For your convenience a tarball is available: https://downloads.xenproject.org/release/xen/4.15.0-rc5/xen-4.15.0-rc5.tar.gz https://downloads.xenproject.org/release/xen/4.15.0-rc5/xen-4.15.0-rc5.tar.gz.sig Please send bug reports and test reports to xen-devel@lists.xenproject.org. When sending bug reports, please CC relevant maintainers and me (iwj@xenproject.org). I am hoping that this will be the last RC. Please send any reports of serious bugs (or brown paper bag mistakes) quickly, or we may have to release without the fix. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 29 14:26:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 14:26:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103080.196684 (Exim 4.92) (envelope-from ) id 1lQspy-0002l7-FH; Mon, 29 Mar 2021 14:25:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103080.196684; Mon, 29 Mar 2021 14:25:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQspy-0002l0-BX; Mon, 29 Mar 2021 14:25:50 +0000 Received: by outflank-mailman (input) for mailman id 103080; Mon, 29 Mar 2021 14:25:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQspx-0002kv-VO for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 14:25:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQspx-0007CA-PS for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 14:25:49 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lQspx-0006Ep-Mb for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 14:25:49 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lQspw-0001p6-0u; Mon, 29 Mar 2021 15:25:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID: Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=9BVlQBdyZQvwpnoRwhoH8X+hdsqLUU8UjiSXIrHXop4=; b=4d3LwbZmkTYFqyhG2xLtiQakLQ 5dbijP6HiV/FqvDMvGhlr33x9unDVM7REQvBOkY6PIJAgPPbI7WQaDkXkisgDtF5Nrf307VRGOK9q XyQleEcteJ6Ge9gyiU/SvIYzb3X7P+gzjz4U19N4ahQeB6y8zxis7OiRoDazreOrp2mI=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24673.58219.875762.61434@mariner.uk.xensource.com> Date: Mon, 29 Mar 2021 15:25:47 +0100 To: xen-devel@lists.xenproject.org CC: committers@xenproject.org, security@xenproject.org, community.manager@xenproject.org Subject: [PATCH for-4.15] SUPPORT.md: Specify support lifetime etc. for Xen 4.15 X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) I am currently hoping to be able to release on the 8th of April. In that case, I propose the attached policy patch for SUPPORT.md. Ian. From: Ian Jackson Date: Mon, 29 Mar 2021 15:23:42 +0100 Subject: [PATCH] SUPPORT.md: Specify support lifetime etc. for Xen 4.15 CC: committers@xenproject.org CC: security@xenproject.org CC: community.manager@xenproject.org Signed-off-by: Ian Jackson --- SUPPORT.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/SUPPORT.md b/SUPPORT.md index a1efd8fcfd..a2efc146c6 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -9,10 +9,10 @@ for the definitions of the support status levels etc. # Release Support - Xen-Version: 4.15-rc - Initial-Release: n/a - Supported-Until: TBD - Security-Support-Until: Unreleased - not yet security-supported + Xen-Version: 4.15 + Initial-Release: 2021-04-08 + Supported-Until: 2022-10-08 + Security-Support-Until: 2024-04-08 Release Notes : RN -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 29 14:28:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 14:28:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103083.196696 (Exim 4.92) (envelope-from ) id 1lQssn-0002sp-T1; Mon, 29 Mar 2021 14:28:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103083.196696; Mon, 29 Mar 2021 14:28:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQssn-0002si-QA; Mon, 29 Mar 2021 14:28:45 +0000 Received: by outflank-mailman (input) for mailman id 103083; Mon, 29 Mar 2021 14:28:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQssn-0002sd-5W for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 14:28:45 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1d80282e-2cb1-4a45-bf04-99e6c39139f3; Mon, 29 Mar 2021 14:28:43 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6B365B12E; Mon, 29 Mar 2021 14:28:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d80282e-2cb1-4a45-bf04-99e6c39139f3 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617028122; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EMNJ6vkDZaoX2QWSoLnMWeq3PjhEM7b/xbkUeKtx1D8=; b=CQKZBJH46Q91eFCjs6seAq6I3J1pxVLUcMUNvzu4CQMTGE36tnTiVFvm4yUiG4bhVWOyz3 QAB399soPWOIj/OGtp6HE7xgzJPh+kkzd+F0meR95PRx6Alzpp6CUV0Hf+oJpqEdBm4a6P dBMT07BfGH0A/kSSWokkubsdjR83q4g= Subject: Re: [PATCH for-4.15] SUPPORT.md: Specify support lifetime etc. for Xen 4.15 To: Ian Jackson , xen-devel@lists.xenproject.org Cc: committers@xenproject.org, security@xenproject.org, community.manager@xenproject.org References: <24673.58219.875762.61434@mariner.uk.xensource.com> From: Juergen Gross Message-ID: <8feca2c2-e262-4202-f186-1edd22fe2a6f@suse.com> Date: Mon, 29 Mar 2021 16:28:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24673.58219.875762.61434@mariner.uk.xensource.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rFavNWq9wqO3Ct7vgDgQClaY2tp2qTCwM" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rFavNWq9wqO3Ct7vgDgQClaY2tp2qTCwM Content-Type: multipart/mixed; boundary="cpwHIGoFhuGfXRSpiA528EOmsz7PLwLel"; protected-headers="v1" From: Juergen Gross To: Ian Jackson , xen-devel@lists.xenproject.org Cc: committers@xenproject.org, security@xenproject.org, community.manager@xenproject.org Message-ID: <8feca2c2-e262-4202-f186-1edd22fe2a6f@suse.com> Subject: Re: [PATCH for-4.15] SUPPORT.md: Specify support lifetime etc. for Xen 4.15 References: <24673.58219.875762.61434@mariner.uk.xensource.com> In-Reply-To: <24673.58219.875762.61434@mariner.uk.xensource.com> --cpwHIGoFhuGfXRSpiA528EOmsz7PLwLel Content-Type: multipart/mixed; boundary="------------8F22F4B9A483E3B0036A30F1" Content-Language: en-US This is a multi-part message in MIME format. --------------8F22F4B9A483E3B0036A30F1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 29.03.21 16:25, Ian Jackson wrote: > I am currently hoping to be able to release on the 8th of April. In > that case, I propose the attached policy patch for SUPPORT.md. >=20 > Ian. >=20 > From: Ian Jackson > Date: Mon, 29 Mar 2021 15:23:42 +0100 > Subject: [PATCH] SUPPORT.md: Specify support lifetime etc. for Xen 4.15= >=20 > CC: committers@xenproject.org > CC: security@xenproject.org > CC: community.manager@xenproject.org > Signed-off-by: Ian Jackson > --- > SUPPORT.md | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/SUPPORT.md b/SUPPORT.md > index a1efd8fcfd..a2efc146c6 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -9,10 +9,10 @@ for the definitions of the support status levels etc.= > =20 > # Release Support > =20 > - Xen-Version: 4.15-rc > - Initial-Release: n/a > - Supported-Until: TBD > - Security-Support-Until: Unreleased - not yet security-supported > + Xen-Version: 4.15 > + Initial-Release: 2021-04-08 > + Supported-Until: 2022-10-08 > + Security-Support-Until: 2024-04-08 > =20 > Release Notes > : RN You might as well adapt the link for the Release Notes, too. Juergen --------------8F22F4B9A483E3B0036A30F1 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------8F22F4B9A483E3B0036A30F1-- --cpwHIGoFhuGfXRSpiA528EOmsz7PLwLel-- --rFavNWq9wqO3Ct7vgDgQClaY2tp2qTCwM Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBh5BkFAwAAAAAACgkQsN6d1ii/Ey9s kAgAj/QSTm/Tn0qHXAXKRth8sN9RpyxMW7JbjkH3P/IShKu/csADsoub7G+ap8TAhbzj3E7ndAkv EFIpa3PhzH7HJ8+BCeIbfeEOoHWfkfy1QJpx8eoM1cCD4PxF4In/H73A2hJeXIDsStTwghSmzYl+ 9dHXV8xuiwpemtHdUMOn+CWXOCX23gCIh1q5K5PefzP3jtIR31OXfF023pWMmOnmgvjT6Syie0JD Xb/Cz31vWfk55EAwnWL1QhUrecEqAy0C3/cwuHx7SdhG7N8GoHcLZ7xQgzZOjmOCcJjIWinvF/3Q iivK0ZJN+vZa7OlwMgFD0U6PJay1o051b878Rn93jw== =pQqU -----END PGP SIGNATURE----- --rFavNWq9wqO3Ct7vgDgQClaY2tp2qTCwM-- From xen-devel-bounces@lists.xenproject.org Mon Mar 29 15:05:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 15:05:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103099.196718 (Exim 4.92) (envelope-from ) id 1lQtRn-00076q-TX; Mon, 29 Mar 2021 15:04:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103099.196718; Mon, 29 Mar 2021 15:04:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQtRn-00076j-QB; Mon, 29 Mar 2021 15:04:55 +0000 Received: by outflank-mailman (input) for mailman id 103099; Mon, 29 Mar 2021 15:04:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQtRm-00076e-0Z for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 15:04:54 +0000 Received: from userp2120.oracle.com (unknown [156.151.31.85]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b0480eb2-98f9-40b0-8926-832e9d5b023d; Mon, 29 Mar 2021 15:04:52 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12TF0pBb075245; Mon, 29 Mar 2021 15:04:51 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 37hwbnbugs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Mar 2021 15:04:50 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12TEtOL6124581; Mon, 29 Mar 2021 15:04:50 GMT Received: from nam04-bn3-obe.outbound.protection.outlook.com (mail-bn3nam04lp2053.outbound.protection.outlook.com [104.47.46.53]) by userp3030.oracle.com with ESMTP id 37jemvu3pc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Mar 2021 15:04:50 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BYAPR10MB3128.namprd10.prod.outlook.com (2603:10b6:a03:14e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.33; Mon, 29 Mar 2021 15:04:43 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.033; Mon, 29 Mar 2021 15:04:43 +0000 Received: from [10.74.96.207] (138.3.201.15) by BYAPR02CA0055.namprd02.prod.outlook.com (2603:10b6:a03:54::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Mon, 29 Mar 2021 15:04:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0480eb2-98f9-40b0-8926-832e9d5b023d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=YcjmxpoYNxxuOCKR2CDKfVORzpyWwUflamuix4CeWVU=; b=NK17fJXq+5lfJLXglSwFSM0M6GE2yzKBQSnUvr0lWC/4S4GEon+ShbjNHrQGVPDidpqW xN3a4JqEe9enxwACaHFX3+8fDyjQI9Q8qy05kVJnwe2eeJWA3i6NsDbazKvUxK1gRkA1 UkBiX9eUoACXgdyJb058cekUZri4REbpAUKJpzSNGTCOENiEsw14ch4a/Q5tVgfY4SOq Ko4wJJ0cx7uP1QM9JQx8BxVojNqbqE/WmnKXphaiJj/gAc4qmn9tp4axGe9XPyEF34LJ ByfjBBEFmhU0skCRuLNpVNLdYSrHsx5nw416fwybnQi/g/o5/Wh8C9asECMB3fpMZzpA xw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=odsUTMPBaHNkkha8p0cBUpDJK2uDHxEwSjeeK+f2K9WoeNutvPuBaozaZ1QfhOKph3SL2AlXFR+E4H91ffFYVT4Sj8fM/4PAmmvyI63ZI7A5dkG9NP6YQrjbxHit41BcctxrTCF7zobATKNUA9TBWIf/7Cm6UaLry7+UvkBacsYQftkBLQGzRJ0605YpGR0O2+FDhlkzC3LsRF/HiOTXwH91RIiBbextyiytmez9tJMXoYT7068m7tGT3ZdHi5TbFvOTVtQ31ej97MPqwuDwp/t+5DSk15nj62PjTPOobRtUaX39dK1AZbOZcZudDgnjkY/fSh2uVPpT8E+BUJdRGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YcjmxpoYNxxuOCKR2CDKfVORzpyWwUflamuix4CeWVU=; b=OykIHJAy/tbzN2mzwxeGnrp4ft4RfUiNwOdZVgtKaVBnDT/IGjwJ0peCdviHFw3s/nhkP8FpEMi+aaWve5JjLIHlRY19Om4iCMFBjWKe7iYundEvaTMxVktq+zhqdE3NT2qg/sMHz1jYTOVk4JvmJ4BwLwp4k22AbIdzHk4pt8SYBmhms1MnBM9B0HyWmhgLAbK7JQgp3xIFRsbp1qGkEg6bOb+6+iZyMCxpyWs5VdizflpOiCKBCdxxomXNLBVIn62TJfcDqk1EfyqAAyzyiyoCqJLCcUj3+JX10OdCwNujFvVScZJNR+aJeyXYW9wjvyYq0cy2aPKl0Crtdbn8qQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YcjmxpoYNxxuOCKR2CDKfVORzpyWwUflamuix4CeWVU=; b=sLlYvOaaH7b6AvB5XT6AOxiPywOG5JoAso3XhtmsLsqlU9XAOwlt2ud8EBtaHLCNziHjKPTKCFo3SUsOI3T48jnuBDWTtP2vh5RJjOv9GdwZIs0MXsDI4PcO8WRJQSn5L8B4nO/rSnk3cMYo78lWfoIi1yzAVfzK/ZWo/DCndNc= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH v2] x86/vpt: Do not take pt_migrate rwlock in some cases To: Jan Beulich , roger.pau@citrix.com Cc: andrew.cooper3@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com, iwj@xenproject.org, xen-devel@lists.xenproject.org References: <1616809866-30837-1-git-send-email-boris.ostrovsky@oracle.com> <82868938-bf57-25c2-38f6-1ec8e9c92362@suse.com> From: Boris Ostrovsky Message-ID: Date: Mon, 29 Mar 2021 11:04:37 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 In-Reply-To: <82868938-bf57-25c2-38f6-1ec8e9c92362@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [138.3.201.15] X-ClientProxiedBy: BYAPR02CA0055.namprd02.prod.outlook.com (2603:10b6:a03:54::32) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3fede070-a58b-4d7d-df7d-08d8f2c3fbc5 X-MS-TrafficTypeDiagnostic: BYAPR10MB3128: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xw+0aWfu9WOxkwcZCAcPnh43qAGdQeEuJBGtDF/CR7wJA5tbPSwN3IYKVBygUyLUHqPZ6x+ZuKOyUutwBZ5JGOEnZVA2uCM5xDCbMXbP9DYs+85+bcs3y8ogGakWb4aKD6R7Ig4f5xNokzORD1qzvrRGZyNgmNSxlSdQdq12mIE1Gl9ZGHT4JZIwhtJu3mb85EWgMTUNvEMjTjbFnooJij9hQpcLYV9U6MgaS6M5gH75rJOgS9GBLnTIPzACAPy/rCACJGlcJtOcbM2MjRw2Qtv7l40eUp/D51caDC4McWOXPpNUFEqT9yeau/DynT/Xs7ZVAkfRUybGcEybQJ8KBFVmbT6xE3pbHFxHsLiNCe4S5u3b2I1OKAcP/KM1LDZBtcLvkn4QrUXjGGoTyiYDOfeHrO1mR5qqnHnwsUZ0fRs0uyDMUv7+tTdI1ftIap2ZYCrdEpRdtbwyTtIQ/x2sEYVVGAg25kceJOllH3a/MAZgo4l0aGrAFU8bl548M5XQsuOD9y8r+R81ueXd2Sw/Bl8wWE1AxRWdLo+T61P3/3eYk/l0ttq/XjDWj2pYk9SliggN5pyDujqisZW6VjiLcLHspxpFT9MGNjEVDu4SJ1Yt8Hn0T9qWHRjjUmqPBt4JORVtDrnOAQmCOp73Zeg58X6OtiBadQvzI2FoFH0HTa9qn58ThW8B2oV33GIu3GtIr+0bla7fQax8kh1boC2iQAORPzLmsedFovHvWyNmrwQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(136003)(376002)(346002)(366004)(16576012)(16526019)(83380400001)(5660300002)(316002)(8676002)(2906002)(8936002)(4326008)(2616005)(26005)(44832011)(31686004)(956004)(36756003)(6666004)(53546011)(186003)(31696002)(66476007)(66946007)(6486002)(478600001)(66556008)(38100700001)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VFlxbkQzQThBMWhua3hDeHM0WHBjdXNrVkw4M0VDbHRCWG1RU0NxRDRzRnBU?= =?utf-8?B?MjdIeDBHdDBpeWw3OGtrc2ZCcEpHRHV1Qmd2Z0pyQVRaNGUyQXgrVW1nc2RI?= =?utf-8?B?cUtPaEtvNnJNU2RlK1AzYk5RNTFFR2s4dGY3SzAxWkkrYUdDb2ptb00wdGRv?= =?utf-8?B?YkVBTi85SHd3TWs4MTFlU1dHWGhWenF4RGNBcEk4Q3FLVlFENUVnZ1dQVjVE?= =?utf-8?B?VnhBdEtsbVpZWHRQamU0N2RXbjFMZkhEenkvVk1GYUUwSzl5UmNiaTh6S3Z5?= =?utf-8?B?M3dsSjRJQVU0WjN0T01ZMVBsZnlHRkprM01zdXVqQy83QTc3anc2WjZkVVhq?= =?utf-8?B?MmRmd2gvTmlqNzZ1VnR6UTdjeHpvQUZHeVl5R0YxaDhQTGhPRnd0TEpzRklo?= =?utf-8?B?SWpVcGh4dlNjSzhRZUkySE1HdExjYVNkTzlsaXhqS1JpKzhGWlAwUFAvaDFK?= =?utf-8?B?OTByZGd5VnVoNURiVTZHRzhFVHVhZkJJSkkwQ3VEOHpSM05XM2IvUnhGVnhk?= =?utf-8?B?Nnc0R294OEhOQVQyQWo4OWp5SDlodVhCd0p3dGZ0T1VPT29kaDFwYXN2UCs3?= =?utf-8?B?dStxMHp0bmRaTW81VXhJK2U2ckpXcUNrQXlpYk9JWlE0bGQvS1lMNGtTSHFT?= =?utf-8?B?bXRjdHhCWFNtQ01uWGhSVWFQclFpbGI4cEZETVBKV3FYNEVBY3F4R0k3bVlv?= =?utf-8?B?SUlYZmpvc0UzTHgrd3dqY3k4Q0hXa25zNUU5aDVUeVdVdnR4NUcyeXlhS05k?= =?utf-8?B?SndLWXFYQk5QcXUwdEtaMGFMK0R0eHNyeWxCNWxtSGZ1WDg3b2U3c3JEa1M4?= =?utf-8?B?VHZzSEtFNFVkTk9mQnJCdlEyV0NaOTRybmFPVkJUY3l3ZFZJZUlVYXJHN0dw?= =?utf-8?B?MFB3RzU3b1J5Z0VSbGk1MjlrZ0Zyc2NySTJ0eEJCNmxUWlBIa0xjMkxhOU0r?= =?utf-8?B?aTRvNjVweVNLS0h6VklEU1BqNEtCR3d0UnQyRStuMzRabCs1QzBZaHhZODBm?= =?utf-8?B?MitIYTNZVEpYSHp0QW5nUGVCYURSNGFuWXpSSDl6NU9qc0Q1NEU3QVl1ZkRN?= =?utf-8?B?OE8xZkg4T2RHOVZoUGZKWlFkbHNmcE4vMjFtTFlDcWI4cGV0TFZ5OEZZM25P?= =?utf-8?B?NUpSRnExT2Q0N3ArbG1yMEI5RjQvRHk1eERPeXVIK3Q4Znk5VjJZTWYyQ2k3?= =?utf-8?B?NXBiWnJQclpGZ0RIVnVoODE0aG5qU21qcGU0R3Faams5TGZPU1BvbWhSUWx0?= =?utf-8?B?SGJraExDNWdoY05WR3RmR24yM05hYXFSMURyb21KYktuY3pqdUtNaUVuOW5j?= =?utf-8?B?ZU9zL1NyV0Z5ZmY1VnFuVTYwZUc0QWtPcnZTVzJrOEFvVWwrWmV1V0Q0VlR3?= =?utf-8?B?blp4WDJtYXA0dC8xbVkvOW9QZDJXbVNTQUk1MDV0RlRmTjhDa3VtUzY1SFJL?= =?utf-8?B?dWdxZjhJM2xzRTV2ZnFoQWZ3ZUplS2p6aE1JZFF5UUY5T1VJbVo3RnNFTzh5?= =?utf-8?B?Q0FWSDRGemZrdWY2LzMvNW54VEZVWVd6NXR1Y1Ric3FhU2c0SjZxMUF2aWxq?= =?utf-8?B?UTVJYlJvMS80em1QU0FxN3YrdDgwVHVWREozelM1VFRjWGlSb3liSXgveWV4?= =?utf-8?B?T1UvMHMrZGx4UUxGRWwzajV5VkNQb05vbWk3bXU0My9JVmVHbytZNzd6K1hP?= =?utf-8?B?amt3L1FGMTU3L1AvblFseWtUek8yQm5uSEpNekJzYmNEL3BRdHZjV0N4aWNw?= =?utf-8?Q?VWIQNEehi7Z53UGrE80uCrHX1UXlProsg8xbbre?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fede070-a58b-4d7d-df7d-08d8f2c3fbc5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 15:04:43.1337 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HrLLC8wxYVamVOyfvTyKjgx6VBkS0jBWJFbUZv88AqFdMcWr7k20GzoYqyHf2BtXx2cvQLa1DkCgy2EjW8qpebnzWeF8ANcB/xmBz/YhrE4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3128 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9938 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 spamscore=0 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103290114 X-Proofpoint-GUID: vaOPPgaUptwYWqduW-DjzntWyzNmuYFD X-Proofpoint-ORIG-GUID: vaOPPgaUptwYWqduW-DjzntWyzNmuYFD X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9938 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 clxscore=1015 phishscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 spamscore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103290114 On 3/29/21 5:56 AM, Jan Beulich wrote: > On 27.03.2021 02:51, Boris Ostrovsky wrote: > >> @@ -543,8 +554,10 @@ void create_periodic_time( >> pt->cb = cb; >> pt->priv = data; >> >> + pt_vcpu_lock(pt->vcpu); >> pt->on_list = 1; >> list_add(&pt->list, &v->arch.hvm.tm_list); >> + pt_vcpu_unlock(pt->vcpu); > I think it would be better (not just code generation wise) to use v > here. > >> @@ -580,13 +593,22 @@ static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) >> return; >> >> write_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); >> + >> + pt_vcpu_lock(pt->vcpu); >> + if ( pt->on_list ) >> + list_del(&pt->list); >> + pt_vcpu_unlock(pt->vcpu); > While these two obviously can't use v, ... > >> pt->vcpu = v; >> + >> + pt_vcpu_lock(pt->vcpu); >> if ( pt->on_list ) >> { >> - list_del(&pt->list); >> list_add(&pt->list, &v->arch.hvm.tm_list); >> migrate_timer(&pt->timer, v->processor); >> } >> + pt_vcpu_unlock(pt->vcpu); > ... these two again could (and imo should), and ... > >> write_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); > ... really this and its counterpart better would do so, too (albeit > perhaps in a separate patch). Are you suggesting to replace pt->vcpu with v here? They are different at lock and unlock points (although they obviously point to the same domain). > > While I see that pt_adjust_global_vcpu_target() (the only caller of > pt_adjust_vcpu()) already avoids calling here when the vcpu there > doesn't really change, I also think that with all this extra locking > the function now would better short-circuit the case of > pt->vcpu == v upon entry (or more precisely once the write lock was > acquired). Sure. I'll add this (and address comment changes from you and Roger). -boris From xen-devel-bounces@lists.xenproject.org Mon Mar 29 15:21:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 15:21:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103103.196731 (Exim 4.92) (envelope-from ) id 1lQthR-0000ko-8W; Mon, 29 Mar 2021 15:21:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103103.196731; Mon, 29 Mar 2021 15:21:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQthR-0000kh-4o; Mon, 29 Mar 2021 15:21:05 +0000 Received: by outflank-mailman (input) for mailman id 103103; Mon, 29 Mar 2021 15:21:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQthP-0000kc-Ly for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 15:21:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 97acd249-0fb7-46b8-9aa2-f3523e0a8ec1; Mon, 29 Mar 2021 15:21:02 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1A678AFFA; Mon, 29 Mar 2021 15:21:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97acd249-0fb7-46b8-9aa2-f3523e0a8ec1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617031262; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eP0p5MJOJG96G3XTTMmo1I6MJVX4Kifn8MnIPa1xTlw=; b=kbH1xqsQqS12s4CxCnK9QQEGm02xAoLXfmAL/ZXe1Ovqry8cDyMgQQ11BqZbZgLB+Zil7I yWzhZZOwiaxc1WqxUBXx2S400p8DvvBc0s81oYrkcWOGEeJqK1f5qojx1Tv/LZvZU5dhwF fhAyeK1TvusJWG2TRDGFO2iEvpZgFw4= Subject: Re: [PATCH v2] x86/vpt: Do not take pt_migrate rwlock in some cases To: Boris Ostrovsky Cc: andrew.cooper3@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com, iwj@xenproject.org, xen-devel@lists.xenproject.org, roger.pau@citrix.com References: <1616809866-30837-1-git-send-email-boris.ostrovsky@oracle.com> <82868938-bf57-25c2-38f6-1ec8e9c92362@suse.com> From: Jan Beulich Message-ID: Date: Mon, 29 Mar 2021 17:21:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 29.03.2021 17:04, Boris Ostrovsky wrote: > On 3/29/21 5:56 AM, Jan Beulich wrote: >> On 27.03.2021 02:51, Boris Ostrovsky wrote: >>> @@ -580,13 +593,22 @@ static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) >>> return; >>> >>> write_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); >>> + >>> + pt_vcpu_lock(pt->vcpu); >>> + if ( pt->on_list ) >>> + list_del(&pt->list); >>> + pt_vcpu_unlock(pt->vcpu); >> While these two obviously can't use v, ... >> >>> pt->vcpu = v; >>> + >>> + pt_vcpu_lock(pt->vcpu); >>> if ( pt->on_list ) >>> { >>> - list_del(&pt->list); >>> list_add(&pt->list, &v->arch.hvm.tm_list); >>> migrate_timer(&pt->timer, v->processor); >>> } >>> + pt_vcpu_unlock(pt->vcpu); >> ... these two again could (and imo should), and ... >> >>> write_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); >> ... really this and its counterpart better would do so, too (albeit >> perhaps in a separate patch). > > > Are you suggesting to replace pt->vcpu with v here? Yes. > They are different at lock and unlock points (although they obviously point to the same domain). Indeed, but all we care about is - as you say - the domain. Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 29 15:31:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 15:31:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103110.196742 (Exim 4.92) (envelope-from ) id 1lQtrk-0001to-D6; Mon, 29 Mar 2021 15:31:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103110.196742; Mon, 29 Mar 2021 15:31:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQtrk-0001th-A4; Mon, 29 Mar 2021 15:31:44 +0000 Received: by outflank-mailman (input) for mailman id 103110; Mon, 29 Mar 2021 15:31:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQtri-0001tc-VY for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 15:31:43 +0000 Received: from aserp2120.oracle.com (unknown [141.146.126.78]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 318c105d-9020-4ee6-835c-cad2d3b044e8; Mon, 29 Mar 2021 15:31:42 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12TFECxH024427; Mon, 29 Mar 2021 15:31:38 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 37hvnm3yb3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Mar 2021 15:31:37 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12TFFYmM193140; Mon, 29 Mar 2021 15:31:37 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2174.outbound.protection.outlook.com [104.47.55.174]) by aserp3030.oracle.com with ESMTP id 37je9nhcvu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Mar 2021 15:31:37 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by SJ0PR10MB4621.namprd10.prod.outlook.com (2603:10b6:a03:2d1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Mon, 29 Mar 2021 15:31:35 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.033; Mon, 29 Mar 2021 15:31:35 +0000 Received: from [10.74.96.207] (138.3.201.15) by MWHPR20CA0033.namprd20.prod.outlook.com (2603:10b6:300:ed::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24 via Frontend Transport; Mon, 29 Mar 2021 15:31:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 318c105d-9020-4ee6-835c-cad2d3b044e8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=vktUX/LWramEoiCqY3+yz9Yv08/2+qVPBy8xEj2nPZY=; b=zqtMdqHKGVpm3M7EmDbwhkOJ2K4e6HvGouVeZUyWL9iZ8A1i5cWqZknwHpX3PaC6cw8z AVWgC2SD0zqVhHqx2YuvAwC/qj1qs1p8/IzM5R5aaXMU1wPCIuUpqgP9WUYObLR0GgvE ZVYVBF3TqH8ZClGleeZUfFwERgNAG1pl5O8f4iCvMZw5f8yLpglHjxtaegwkxEHNJmnx JI3u3tJpVHP0qo+5QBsOzK3ZbpU3I9oRdnDrnjV8PhBSxn8hOrtEr8ZhEVULMHdncCmn 3Vn/eawM8ewWs24W2fQvRepoXAJuG9wG6uN2H+Qr9M2jbbWefFdwjN35QFJt99a9cATb Vw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wl2fuSxT08N6ouZ75BIswmbGqYaM3CMNXgArTolj+774EOOLT/lvxwNDVMcy7lNoFb3l7GKSM5fcuoVGng75+IThvZX/JIHLMYGlYliBPTN0xsuCITbt3cS0OQooRO9/zegjTvB/Md1FxNXrJ8lFvo2Kv3zOe/sgjSOPLyNH3Z9n7O7dd6kmbZjmBylUKZ3nnkdMW11tvhxX47uygvUOGCv8O8eJVJUCuFVya5SOlfGxAY1C05yztX7JUdLyp8R+6XMYvbw/OG+pI7BtswckN5KZL3FmXCbVwJkSwk4vRkEPt+zOU353ssnaOzQhn328lSGFQGNJ0c1P0jFdgkUvvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vktUX/LWramEoiCqY3+yz9Yv08/2+qVPBy8xEj2nPZY=; b=erbmwNUI6n2JbjgBUL67iZz49vRRar/nKi89VcTHB8AhIdV6xtCtacFtR9ANRItBuqERPUAU8Y4ESx0tatZbk8OimrtLNfvZ5da0wZxb5Gy3k2eEjlwoCUFacDcQxYHA6EuthJVQlV3migqSAx8Of0+Au0adQAXlbw056MjUtYDatfK14VDpmVKNIqfWEmG8wn4r2i/cxNlX3OUmL9TYGc9ulhizDUYBBQ6oYBzgPED5lMG15MdaC8Xhv1s5vwTar0nmBJyRga+DQVz/gnHkHo5zmzMmPx6IKORR3oSWwgldPiSj5jlbkIup4y0qQwArmxbkIg1YPByCI2iifR3foA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vktUX/LWramEoiCqY3+yz9Yv08/2+qVPBy8xEj2nPZY=; b=Cf5zHZ7Ho22yc8FuS0XqVtxD2IemwTc5ypsBXHYyxxrZySDzIF2QxODktfBdjPrn6HvnvIX2A1xgLz6ARxjYRflaPabaxMxvO1ZSkqmKz+yOwaOh0R7vZzkYmPKbSOeHELjkoAd0HyP/V1wkltgz+6KCR6MzUmKeiJd3leADCX4= Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH v2] x86/vpt: Do not take pt_migrate rwlock in some cases To: Jan Beulich Cc: andrew.cooper3@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com, iwj@xenproject.org, xen-devel@lists.xenproject.org, roger.pau@citrix.com References: <1616809866-30837-1-git-send-email-boris.ostrovsky@oracle.com> <82868938-bf57-25c2-38f6-1ec8e9c92362@suse.com> From: Boris Ostrovsky Message-ID: <318ca597-c7fe-ceeb-df12-2802b2cc74fb@oracle.com> Date: Mon, 29 Mar 2021 11:31:28 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [138.3.201.15] X-ClientProxiedBy: MWHPR20CA0033.namprd20.prod.outlook.com (2603:10b6:300:ed::19) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dd7ff284-0b29-4f0d-5109-08d8f2c7bca0 X-MS-TrafficTypeDiagnostic: SJ0PR10MB4621: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c8f5x2qplcpiksOAs760QXPuGYOgdtyusnFTyBDI6q8+ZNGyZc+DqqjJC0fM4VY83jTWMFUQ9cCEf7kUzOVwOwlx2m4caWTb66zFmO7URTfDaT8d1GNaaIZ43o0LqJ9gE7TOfor+rizHW5bmRRkx0fS7//mjEcsKKxKvPmaqp4ttJy1dUT4GK9aPQqdh/qtCR0N0dSkyLNvyvcnpfBLAIaxw5uFGIygy3BI61nxGUKqxs+kzFEa1/2fnEjVHMZBbt2Rx2WpO/sVGrFCvTwTxZAJF8+c/EBmk4UqQvJ7drmXg/stEIVtxRsnYe60XGXAeCIPtYHZoTC9wAeqzKaQoabQIWM45rODxU2q7a4H/ZEh80N2ijrtRqOlXd7e3jIswq+8heelaZtFwuNz5OhCRohIWhylUdVEdPvJJ2tyt94zSP4+Dt+1EcZ6eo1yR6bGLd1SomC36glefe0jHKju+ldE7xQaI9kWSQZjSaGGZIGFx73wZGw0Zh4tVrTXKU/v0jzoST+RDQ5k7fXinZLaTlCFxj42Vtkfpk2FK861A0jvs4siZ4zuxwrcH2BQ2l/sx1iY7+oWZBeP77tu/Mb1VSjCkb7H4ic5IzrGsxtz8iu4HflNoKwZMc1J51zcmYHIJZVKWYWdDjbLkzbkSxy/Ol5o+1ZL9AodzKuFf4jreI/ZIvWemEio9Z5bWFQ89JqaB7PXXm7V/WIhX3yFqXxvg6g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(136003)(366004)(39860400002)(396003)(478600001)(6486002)(83380400001)(66946007)(956004)(8676002)(186003)(2616005)(66476007)(44832011)(31686004)(6666004)(26005)(16526019)(6916009)(38100700001)(316002)(66556008)(2906002)(86362001)(5660300002)(53546011)(8936002)(4326008)(36756003)(31696002)(16576012)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?OEU4amRrNDEzaWEyVkkzbkVnL0xJL0pFUDJLNzN2RGZSak13UkI4TWNxdnJ4?= =?utf-8?B?dDE3bEdKNXlkY2ZqamNxdU9JbmdzSW1jdVM4OUVuV1ZCamF3eWs4dTk0bnU5?= =?utf-8?B?dnZWQXU0NkdKNlpjM0p0eUw4UEhZT3ZUQVYwWmVDSGZpWkhNZEtMSERDOS8w?= =?utf-8?B?cDEvZVprNEdmRVNxblJ5N04yYi9PN2t2NXVPSXF0U3hlZnpXUmhLVTJ6c2d5?= =?utf-8?B?TkNnN1NiMDNjeEIyZTNtZVRHNlBOVTgzSEdRVktxcHExRHBuN0J4M3BwbkZJ?= =?utf-8?B?c0xJZFcyajFYd3lqaFRPYzl6S1RrTkg1ZHZ6ZDM2Zk1QT1NVbG92QmgweUFK?= =?utf-8?B?QUl0UFFwQmQ3MGkzNjJqcVRHd3lzR0ZLKzhJWEFyU2EwcStQbXB0UHZZSXAv?= =?utf-8?B?WDB5U1cvQzI0d01ObkFmWVZNcVA3MlA2YVl4KzFmM2p0cE52OUN5Y0FTL3lW?= =?utf-8?B?czZxMVU0VVRHUUVGVG9HRmZFMmZxYWhjR2JmSSs4ZytydTZFNm5VeDBMOElo?= =?utf-8?B?YkNBdUJHUU9jbTZiQjc4UEhRK3lnckxxM3JyckFVMkVLenVock01cExpQ3Rx?= =?utf-8?B?V0VMQ2gzdVhjUWx0Ny92RWJTOThKREdjRC9FSTdEK012bG5BNFZYVzM3Z20w?= =?utf-8?B?Uktubm9qdktCZjNlY2FYazlHaG04bk4ydzB2ZE9EbGQ1Z1hEeXVKRW40VmZ1?= =?utf-8?B?U2VtbTJBdmhoSWlCRUhvL1lGRkZoU1djcmRLeXlpdTlEcXJOSlpkVkdFck5O?= =?utf-8?B?OStsVytJSUhBZTA1ODVpYkN5NDF2U3RzOUN0RFl4ZisybmNJbGllRk9HNkgv?= =?utf-8?B?dlQ2MzlkRC9VRHhQQWpiRmxnaWV2RVgwVVVKYnNVd0FoOTR2S1p1VnFPeDJy?= =?utf-8?B?N1hkQ3NaL3E5QXFqak85QXNyVVhabndRU0FMZVNHaE5WWFNXM2ZyVk95T1JD?= =?utf-8?B?TDh0MFo0dEh2TFJ2RG5FY2NQcVNWamh0NEFzUlNEaWtKd0ZmWXFUR3VoK1hS?= =?utf-8?B?aS8weEE1bmdUbUtGL1l3Wk9CdEpZWDRFVUJ0VzZDcTZrTnZ6c0pRc1JZd0pB?= =?utf-8?B?eXZRSEltajBVRGZyM2JQaU1XclRVT2NlNFBpSnZJMFRnUm9TR3lXcGhZaTRZ?= =?utf-8?B?b2ZWeWxLcjNXTGlpQTJaVlg1NlpwdXJSYU4yM2lDNW5YYkNaeHRsbUswT3M3?= =?utf-8?B?WlIwTHdzL2FhVVBKYW1NYVNXS1VxbG1vb051NnpYTWxvTXZxdDdvckNyMXVq?= =?utf-8?B?bGJ4NVFRbEpXUlhrcTAwMlRvWlFod0Ivb0pIbnA4TmNLT0lsVUNLOXRwemov?= =?utf-8?B?bXp6WkZhRkpWdkNyMWZLUXdwUUlsVjBPK1BvdHpEQmpEYVRxK3RNZVlPZUJs?= =?utf-8?B?YjQ4U0NqcG5WMU9xdk55OUl6bGQxTU03ZG5QajNneTgxTERwYlFmT1VYOGJI?= =?utf-8?B?VlpRMC9zelhpOHlCZzgzZ3d5djllUjNYZ0hTd2FlL0RLVzYvQ0pXejlMNnoy?= =?utf-8?B?M3oyV2xkK3lTQkdndGNZMTJ3SFFQRlpLaXNGekMrSjFzb05wVnBuMFBKcEVJ?= =?utf-8?B?YW9aZVpqT2VRNFhaSEV2OUJCL2ZxTXBXb2pCbnNGdkFWc2tOTUlVNERlOWZS?= =?utf-8?B?aW9tRWxHSlA5RlNhQnhXUW9yc01BUk9XTmdiczIrejVUQVF4YmJGYUJGUGVN?= =?utf-8?B?eWgxSkY4TlN6T1kySUhtY3VUeXBGTEdEUFZzQ294Rm5uazZLVm9lWXhwWG10?= =?utf-8?Q?7oltK66OnHXz9ZrA74r85wOLvboxDw0Wskqc+Ui?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd7ff284-0b29-4f0d-5109-08d8f2c7bca0 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 15:31:35.6568 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jAazlFvmoFE8dJ1+HWbKS/1mbDAADU4JpCr93gsdg7/s+o7S6kwGABTYyZTsUD1qlbLWWfP8c2nAVwzlD3rRmw3okgco0Syl45H78uoPmRk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4621 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9938 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 adultscore=0 suspectscore=0 bulkscore=0 mlxlogscore=849 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103290115 X-Proofpoint-GUID: 8sxjkmzh6VnHcIEAjg7v2dUPyH21E70b X-Proofpoint-ORIG-GUID: 8sxjkmzh6VnHcIEAjg7v2dUPyH21E70b X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9938 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 mlxlogscore=999 clxscore=1015 priorityscore=1501 phishscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103290115 On 3/29/21 11:21 AM, Jan Beulich wrote: > On 29.03.2021 17:04, Boris Ostrovsky wrote: >> On 3/29/21 5:56 AM, Jan Beulich wrote: >>> On 27.03.2021 02:51, Boris Ostrovsky wrote: >>>> @@ -580,13 +593,22 @@ static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) >>>> return; >>>> >>>> write_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); >>>> + >>>> + pt_vcpu_lock(pt->vcpu); >>>> + if ( pt->on_list ) >>>> + list_del(&pt->list); >>>> + pt_vcpu_unlock(pt->vcpu); >>> While these two obviously can't use v, ... >>> >>>> pt->vcpu = v; >>>> + >>>> + pt_vcpu_lock(pt->vcpu); >>>> if ( pt->on_list ) >>>> { >>>> - list_del(&pt->list); >>>> list_add(&pt->list, &v->arch.hvm.tm_list); >>>> migrate_timer(&pt->timer, v->processor); >>>> } >>>> + pt_vcpu_unlock(pt->vcpu); >>> ... these two again could (and imo should), and ... >>> >>>> write_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); >>> ... really this and its counterpart better would do so, too (albeit >>> perhaps in a separate patch). >> >> Are you suggesting to replace pt->vcpu with v here? > Yes. > >> They are different at lock and unlock points (although they obviously point to the same domain). > Indeed, but all we care about is - as you say - the domain. Hmm.. I think then it's better to stash domain (or, better, pl_time) into a local variable. Otherwise starting with different pointers in lock and unlock paths (even though they eventually lead to the same lock) makes me a bit uncomfortable. Secondly, do you want this and the check for pt->vcpu == v in pt_adjust_vcpu() be done in two separate patches or can they go into a single one? -boris From xen-devel-bounces@lists.xenproject.org Mon Mar 29 16:07:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 16:07:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103122.196755 (Exim 4.92) (envelope-from ) id 1lQuPw-0005eQ-2S; Mon, 29 Mar 2021 16:07:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103122.196755; Mon, 29 Mar 2021 16:07:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuPv-0005eJ-VM; Mon, 29 Mar 2021 16:07:03 +0000 Received: by outflank-mailman (input) for mailman id 103122; Mon, 29 Mar 2021 16:07:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuPu-0005eE-NE for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 16:07:02 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id df5ceeaa-035d-42a2-b0ae-766131cb02bb; Mon, 29 Mar 2021 16:07:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df5ceeaa-035d-42a2-b0ae-766131cb02bb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617034021; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=s3CR131yJiWWFWbUKZDOwdpvolB7189ggeoOD2BlBJM=; b=PCgQyVgXJsS/qSt4VOMuteVHOqtnypIn4QbBRq1MC7zi0uKjHy/3vksh gtw1ZMLkI77QjGnh7zQzNsDqly0Rd68ecTCc2DpXA31pdE2w2LBNrnDR5 zL3ySr02+VY+UrDu0n5J98VeQoGJjsLwQ4MEbhthBoP9dU1OQ1NAAbyzI g=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: dyp3wg/cEurzrVO85mPa8MlEgHzSILpDRTdlI1dPCCzrhYsrWFFLksWfRwseN78q5gIRWXd/gN JKAaPmk0GG+ORfcRiTTBgFmvGX20eoV881ViWOZVgNvpjviePkTP6arVChEiqnr/PxWKyv3oOL IJpxN5s9N/Xg9DDpEeCat4GF8ar3+83f9GxXqda+KMxa4lnd/EfWx8SgEOMkWZ9nQCsHyX++o/ u1zUNGFMCYMUlNTIyivmjfPncuUMrvoF9o+7+lG+R0I/0ZuOhBdoFBPl5yoLtjg+Q9vqPijyun m68= X-SBRS: 5.2 X-MesageID: 40346185 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:p85Ez68UMZM9kzRMjSpuk+FfcL1zdoIgy1knxilNYDReeMCAio SKlPMUyRf7hF8qKRUdsPqHP7SNRm6Z0JZz75UYM7vKZniAhEKDKoZ+4Yz+hwDxAiGWzJ8b6Y 5Me7VzYeeAb2RSot395GCDfOoI5Pmi3OSWifzFz3FrJDsaLZ1IywtiEA6UHglXaWB9dP8EPa GR7MZGuDasEE5/Bq/QaxU4dtLerN7Gno+OW387LiMn8wWHgHeJ77P3AnGjr3Qjeg5P2rsr/C z5lRX47MyY082T9xm07QHuxqUTvOGk69NYQOSQl8AeK1zX+2CVTbUkf4fHgRcYj6WE7k0wnN zFvhE6Vv4Dkk/5dnq+5RPwxgjt1ysv4Xf+yVmexWDuu9D9WShSMbsLuatQaRGc70Y7ptlz3O ZQ32yfv4dKFh+oplW02/HBTBsvjEa9pBMZ4KcupnRCTIoTb6JQp4QD/EVTVIwNBj7+9ZpPKp gVMOjQ5vZTNUmbYXfQo3V1zLWXLz4ONwbDSk0GqsaR2yJNnH94xUMExMoZ901wjK4VWt1K4f /JPb9vk6wLRsgKbbhlDONEWsevDHfRKCi8RF66MBDiFKsdPWjKpIOy6LIp5PuycJhg9upBpL 3RFFdZv3U1YUTgFImH24BK6AnERCG4US72ws9To5h/tbuUfsufDQSTDFQvmdCnufMRH4nSXO uyIotfB7v7NnT1cLw5rjHWSt1XMz0TQccVstE0VxaHpd/KMJTjsqjefOzILLTgHD44UgrEcw w+dSm2IN8F4lGgW3f+jhSUUWjqYFbj8ZV5F7Wf9/QPyYAWX7c8/zQ9mBC8/IWGODdCuqs5cA 91O7X8iL62omGw4CLB83hpIBxAFUxYiY+QH09itEsPKQf5YLwDs9KQdSRZx32cPAJySMvQDU pRvFJy9aWrL4GBxCwrBt69W1jqzkc7tTaPVdMRi6eD7cDqdtczFZA9QrF8Eg3NClh0lG9R2S d+QR5BQlWaGiLliK2jgpBRDvrYbcNgjACiJtMRrXresE6btNw+X3dzZU/sbeeHxQI1AzZEjF x49KESxLCanyy0NGc5iOMkdFpBdXqQG7ADCAiefo1blvTqdWhLPCi3rC3fjwt2dnvh9k0UiG CkJzaTY+vXDl1UvW0d1L3r/lNyfmCUZFlxdXh+rI14GQ39yzhO+P7OYrD233qaa1MEzO1YOi rCeyEOLgRnwM3yyASYgy+YFXItxownO+vUCLhLScCQ5lq9bImT0a0WFf5d+5hocMrjteIGSu qTcQ6YJjGQMZJb5yWF4nI+fCVkongtlv3lnAD/5G+jxXglHL7ZO1J9XawWJNma8mnpT/uFy4 9ikNowpOe8W1+BL+Ku2OXSdXpOOxnTqWm5Q6U0sphSp7s1r6Y2EJ/BUzfEvUs3qikWPYPxjg cZT6t66ryaZdMqcMwWZi5D/l0m0N6IN1AmtwTqAuk4OVEh5kWrQO+h8v7Ns/4oBEbEuQ77fV +Y+CdZ9+3eXySC2aUBYphAUVh+eQw58jB64OiGd4fMEw2keOFI4UqiPhaGAcNgYbnAHa9Vsw 1z7N6JlfKGbib02Ajfuj1gP6JFmlzXP/+aEUaLAu5H89uzJFSKjO+r+aeI/UrKYCr+bV8Zi4 1DfVEXdcJZhFAZ/ckK+zn3V6zrvlhgl1dC6Txui1aoh9HO2hahIX17 X-IronPort-AV: E=Sophos;i="5.81,288,1610427600"; d="scan'208";a="40346185" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ce+zLn62myLLICCMQ5aEIQHpze92N5WKO2k7RJTDp+VKUp7FGXhIQesYpfBOeckBaXH/zFx19pVGwU66V8QpM1a7yY485OnBpI5+OrDpekoUUvF/5bX0seGrc+UccNfvIXgq0VUG9lZRQyYKj2rNaDIckSpsmGQsSGUPSrE+VeYnNq/5Nj0lwLaZPaSuAj9SEjhJB2YrGGpm+cejwn9ukJ1ouDO4FatGnTlXNriDDfSdBfBebcLqKAEXI6uuKUz/Pxog4LEfnGxNrk0Qvyd95TkJZgjv5o5Xujj7tx+Qe9+kLYCWH+FO6wEP5AJDoVjEkGWRvYz3cfkD+G5e7aYc5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s3CR131yJiWWFWbUKZDOwdpvolB7189ggeoOD2BlBJM=; b=dVFR1yBAqfm273gSh3TFWOSGrgQtXzYiZe3ICmWykJej/BjY7qruBwS6vylw37yiLT6T//naxGUKjBk7irsK4YrfnEB4etRktkOmZgRVWMHHvGK8aw8Km0g+NXFTo9s+maNc7aSmJlDHSO82RfePCS2Ae6XQgR9bCoARqzlDrZ+FpQMNGUIkVfLSSsymdk+9vnqYpHchDSCx6R9bTXlegw5Kyzo0FXNVL31K/Vfln2WGjDT1jGyOhfwsX81bk4rel9Dy2K35oHX/88XL7Zw94poTTE1KPFEo6IOFqufAvve4dve4r0cwkpBsIDXJPmbtHOi9ZIcyyJCJr2RtlYcNUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s3CR131yJiWWFWbUKZDOwdpvolB7189ggeoOD2BlBJM=; b=h5+81Sufv3jzWIaajfdI7Y5zmQHMmh6OJUmETUvFBrITJ5Wbj2+8sAXsNXrlCsIr4sqofw0+GOSzdGzHQr7bsIJaME5FHlOBPhTCgV56AQTPKE2XjeSXLEKX3X5SzgswPkcbuZnX0IvsjF+MWdlD4O9dxZNRuL//7B/F/Qjr8Ws= From: George Dunlap To: Jan Beulich CC: Andrew Cooper , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation Thread-Topic: [PATCH 5/6] CHANGELOG.md: Add entries for emulation Thread-Index: AQHXIMzvj/osZBndl0iN655u2tDs9qqUV1aAgAAS04CAAFJTyoAGVX0A Date: Mon, 29 Mar 2021 16:06:57 +0000 Message-ID: References: <20210324164407.302062-1-george.dunlap@citrix.com> <20210324164407.302062-5-george.dunlap@citrix.com> <33f78891-c894-b41a-a1a3-82aac1f57b8d@suse.com> <0A187740-DB6E-486C-8B10-5207CE6A5D72@citrix.com> <7407cac8-c55d-0372-123b-39c9949e6ca5@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af3a5303-f940-4343-8c84-08d8f2ccadda x-ms-traffictypediagnostic: PH0PR03MB5703: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UvLlWkQuQDS2C0a1FsaIkuwKjmbkzpAnyEhIYlZdPKqyyyhdCPcMHm2LIiEF/b2scXZPrO1OB+NjXaiBtl+b0OPmpQsjP0Sl4seRYUUaDGga4N0dVgOuEyYC/9EmknLETeqFMiuzyUGrhc/zLsbS0aDf/0WONL0KzQGdC9Mxxc68P16NoQyiOW9vYP54iZDSPMFN2pgdHx4bsf9UqhOoAVcuT9KDooGOcdmhU/MnWpzxyrzup4GPmmuXzGiP+Ia25bkVjX33xYOOOQKuEeS1uoI57O8NZl8mAlwOpYWfUXT/qYGf5dm7CKJpq3XgUBzuGsjjivw6+mionHdn/FFTY2X/KpVLukNBpF+X28EIx6xF6kU45lRls0nYDb+j+jK38FCMmvo1x4xOfDNrpmBQ0ILFCZNlcB9LELgOqnrOEEYpQ+ufEic5TwemO4yvDKDebyfKsL07SNIRhzqTtKsDKchtMWhngJ27bYW45inFLFgKLl/FISTCurxAb9yYQnxZpIvHp4QdtB8518LiUYIT4wbh+4bym+SBJX60qrrULT/DYmsz0V6CH3YXgmW/C+k4gc1eGxUfJj5P7hB2smrj4T7nF8wVNGKkCmWhXrjX9reDAB3ZZVyI5uHMFn4eD+QD3J8YCnKlIEOKZfUCyn4afMdPGPP1QBfKNkfJTYv3k8Kf4eDkYE5VVFCGmT9+cgNODFm/9k0D3nvEFsHyxjYOmXmCAhwJbK+W1ZWNDDjk4bOD/a8g8ooDjD64YfEWUFDKZ/QLIlfobS6Lqinmr8jyC0I0PakU0yyp1zNJz2eeeXMvpYNto7L6//WIHpt8wS+A x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(396003)(366004)(346002)(39860400002)(26005)(478600001)(8936002)(86362001)(6506007)(53546011)(36756003)(6916009)(91956017)(186003)(66556008)(66446008)(76116006)(33656002)(2906002)(66476007)(66946007)(64756008)(71200400001)(5660300002)(54906003)(38100700001)(4326008)(6486002)(6512007)(316002)(8676002)(2616005)(219803003)(207903002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?Z3JobTFMakF1Q2hXMHNqMmtrSkdjU2tGWUpWVnFhRlVzbDI0RzZXZ2x3dWh4?= =?utf-8?B?a09qdnMwdDEweGk0R0JVVURSamdIUmcwWDdpeHhPVTRoSU9ia2g0dXFNUUZj?= =?utf-8?B?UmU0WVJvbnFqa3AzUjU3WGkvaTEzWmFPSk1XNnFMUThQa1p1TzdXQU9oVWow?= =?utf-8?B?NzJ2dkwzOG9rN1YxMkNsQlBOVHkxcW9TcVMwNkFsNEZFWWEycFpLeUN5ZDdS?= =?utf-8?B?WFR2SThIbkdJRlJySnBXd2pCaFZHbjZrcGE5OWFtUlNiRVJLSnFKRlVVL2tw?= =?utf-8?B?VUJ0dnpWcTVJZVFNOG5PbXpkQXExa2ZqYVNqQ3hycmd6d0JYTVliem42Rk1o?= =?utf-8?B?VThPeGh4ZEdIQUxsU0s0azA2RkhRbTlmalBLVU52djJJbzV0L2lMZHRnSStv?= =?utf-8?B?V3JlMjZUd0JQWUpacDhyTGNxS3dPMEJzd3lMbHN5eUpzQUhkZUprMmNIWExV?= =?utf-8?B?TWdlS0VaemFoK0JUR01EUElaOHNBd2l1ZFAzQW5QV0ZtT3FxNk9MdDdMbkgw?= =?utf-8?B?RmFSQUdJeVBYVGRWM3lQRXlub0JiaUdlcHFqdlFlNjRFWUxzUVFCekJFbmdQ?= =?utf-8?B?ZWFyWXpYR2JDWmJ5MFpQK21MWDhnOGFYbUJBbFdXUzVQdVB6MkFJY29lRngr?= =?utf-8?B?ZWZxa2J5ZmZWNzF0aHFuUmh4dGM0Rk44emhXQ0lPUXduZUxvc3JIYnI3dkw1?= =?utf-8?B?UEp6R1lCa2hmQnQ2bEdoRFBpSUlpdS96OGU4WG1vZXUyKzRnNlZYNEtzYnc5?= =?utf-8?B?Zm56TGlibmJTbjk2UURJVUlVOHJwN2hIMWRUYWZWcjJHTTN4RjlUWm00UFZw?= =?utf-8?B?SkpsVWhQd3duNGJ0YTJPYW13aElja0pjZ0xoQlhiVUFwUXZUQWNZSnR3QzI4?= =?utf-8?B?bEJQaCsrdmNYNnMvYUM0WStldjdWZURnZ1pIMG9Mc2ZBbUMxNFE1Q0xndXlq?= =?utf-8?B?WmRjaVJxZ2FWd3JLbGhsVE0yUTU5SDhnL3lSbHBaWWR2a2xKTCtkS1ZTVjZ3?= =?utf-8?B?S0xlVjRPd3d3ZEhwY0RWRTMrVEJsWjlrb2NqZWRMOWJOQzUxWU1zcFNPOE5z?= =?utf-8?B?ZU5SM2hDQnhOcStaMHNiMHNDQm9YVjdkSENhM2FheWQ1ZGN5RlhtRjVhK2Ri?= =?utf-8?B?a2NFbWVzYW4yM0pSNXBNVWVkckFEMzlMN0tTcUZPOElWWEJoKy84Z0lXUWlK?= =?utf-8?B?anplOXM5Q1VaZVQ3aENGMWxRZ0xGUFRBU0lqRGhhV29lbFErczkxWThVSjl4?= =?utf-8?B?TndSaUw0K2dhN1luUVRtRndwWFcvWVhRYWVrNmpXZllZOXlyRzJCcis1TU16?= =?utf-8?B?R3M3QVJjblMrT2RVd1ZvVlNyRmlDOXE3cjc2Z3o0UHczVitLeHVCcjF5QmRy?= =?utf-8?B?c3IxY2t1OHJyYVp4ZEt1VUthYW0wMUNBZzBvN1pLTExqRjZyQkphWVRXb2R1?= =?utf-8?B?Si8zaUhlQXlHMStteVBjalJVYzFnbkhGcTdmb0k5QXhmZnBXQmsxMWVFWU9v?= =?utf-8?B?Z0JacnF0eGRHcTdybTAzVVRSMzFkaXhFRGN2Sy9tMk1Wck5xaGo4WVl1aXUr?= =?utf-8?B?R2Y0NFBRbGI1YmVJeDdMMDR5ZThpVEVnaDVEdlAzMGJDTWQ0RGdGR3FyVTk1?= =?utf-8?B?MEdjZGRvZ2RVT3R2OHJjZW8wejRYK3piRTlaaTlpbGJxc1R2d1FMQk1VRTVM?= =?utf-8?B?MFFhbk5UM1V5Tzd1TlZuOG5md2luNWUyT3hQRTY4aktqdUFIS002TXU1czRu?= =?utf-8?B?TEx5SUxCWnJiS1lTSGhTMWdEYzBxdXU5TWNhWDdPNzVoL3RzMWVRcExhcGth?= =?utf-8?B?SThYRE5lNDVxTUpSL1N2Zz09?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af3a5303-f940-4343-8c84-08d8f2ccadda X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2021 16:06:57.5433 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tTa0OSjnJOUXhB96asbtf/7moZBlIIksv27XHiUu5YwJ8PI5Ciy504ug3RMQ4AV2+kObdxVPoXorG1DeI2qVrSt4N6rNC0I11vu+fu3HQZk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5703 X-OriginatorOrg: citrix.com DQoNCj4gT24gTWFyIDI1LCAyMDIxLCBhdCAxOjU4IFBNLCBKYW4gQmV1bGljaCA8SkJldWxpY2hA c3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMjUuMDMuMjAyMSAxMDozNywgQW5kcmV3IENvb3Bl ciB3cm90ZToNCj4+IE9uIDI1LzAzLzIwMjEgMDk6MDQsIEdlb3JnZSBEdW5sYXAgd3JvdGU6DQo+ Pj4+IE9uIE1hciAyNSwgMjAyMSwgYXQgNzo1NyBBTSwgSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1 c2UuY29tPiB3cm90ZToNCj4+Pj4gT24gMjQuMDMuMjAyMSAxNzo0NCwgR2VvcmdlIER1bmxhcCB3 cm90ZToNCj4+Pj4+IC0tLSBhL0NIQU5HRUxPRy5tZA0KPj4+Pj4gKysrIGIvQ0hBTkdFTE9HLm1k DQo+Pj4+PiBAQCAtMTQsNiArMTQsOCBAQCBUaGUgZm9ybWF0IGlzIGJhc2VkIG9uIFtLZWVwIGEg Q2hhbmdlbG9nXShodHRwczovL2tlZXBhY2hhbmdlbG9nLmNvbS9lbi8xLjAuMC8pDQo+Pj4+PiAt IE5hbWVkIFBDSSBkZXZpY2VzIGZvciB4bC9saWJ4bA0KPj4+Pj4gLSBTdXBwb3J0IGZvciB6c3Rk LWNvbXByZXNzZWQgZG9tMCBrZXJuZWxzDQo+Pj4+PiAtIExpYnJhcnkgaW1wcm92ZW1lbnRzIGZy b20gTmV0QlNEIHBvcnRzIHVwc3RyZWFtZWQNCj4+Pj4+ICsgLSB4ODZfZW11bGF0ZTogU3VwcG9y dCBBVlgtVk5OSSBpbnN0cnVjdGlvbnMNCj4+Pj4+ICsgLSB4ODZfZW11bGF0ZTogRXhwYW5kZWQg dGVzdGluZyBmb3Igc2V2ZXJhbCBpbnN0cnVjdGlvbiBjbGFzc2VzDQo+Pj4+IFRCSCBib3RoIHNl ZW0gdG9vIG1pbm9yIHRvIG1lIHRvIGJlIG1lbnRpb25lZCBoZXJlLiBJZiBJIHdhcyB0byBwaWNr DQo+Pj4+IGp1c3Qgb25lLCBJJ2Qga2VlcCB0aGUgZm9ybWVyIGFuZCBkcm9wIHRoZSBsYXR0ZXIu DQo+Pj4gSXTigJlzIGFsd2F5cyBxdWl0ZSBkaWZmaWN1bHQgaW4gdGhlc2UgcmVsZWFzZXMgdG8g aGVscCBleHByZXNzIHRvIHBlb3BsZSBleGFjdGx5IHdoYXTigJlzIGhhcHBlbmVkLiAgV2XigJl2 ZSBnb3Qgb3ZlciAxMDAwIGNoYW5nZXNldHMg4oCUIHdoYXQgaGF2ZSB3ZSBiZWVuIGRvaW5nPyAg SWYgbXkgc3RhciBjaGFydCBpcyBjb3JyZWN0LCB0aGUgbGF0dGVyIHJlcHJlc2VudHMgbmVhcmx5 IDE3MDAgZXh0cmEgbGluZXMgb2YgY29kZXMgaW4gdG9vbHMvdGVzdHMveDg2X2VtdWxhdG9yL3By ZWRpY2F0ZXMuYy4gIEl04oCZcyBhY3R1YWxseSBhIHJlYXNvbmFibGUgY2h1bmsgb2YgY29kZSBj aHVybiwgd2hpY2ggSSB0aGluayBpcyB3b3J0aCBoaWdobGlnaHRpbmcuDQo+PiANCj4+IEkgYWdy ZWUgd2l0aCBKYW4uICBOZXcgY29uY3JldGUgaW5zdHJ1Y3Rpb24gZ3JvdXBzIGFyZSB1c2VmdWwg Zm9yIGFuIGVuZA0KPj4gdXNlciB0byByZWFkLiAgIldlIHJlZmFjdG9yZWQgc29tZSBpbnRlcm5h bCBvZiBhIHRlc3QgaGFybmVzcyIgaXNuJ3QsDQo+PiBlc3BlY2lhbGx5IHdoZW4gaXQgd291bGQg bW9zdCBsaWtlbHkgYmUgcmVwZWF0ZWQgZXZlcnkgcmVsZWFzZS4NCj4+IA0KPj4gSSdkIGRyb3Ag dGhlIGxhdHRlciBsaW5lIGFuZCBqdXN0IGtlZXAgdGhlIGZvcm1lci4NCj4gDQo+IEFuZCB0aGVu IHBlcmhhcHMgYWxzbyBub3QgZm9jdXMgb24gdGhlIGVtdWxhdG9yLCBidXQgbWVyZWx5IG9uIHRo ZQ0KPiBmYWN0IHRoYXQgZ3Vlc3RzIG5vdyBjYW4gdXNlIHRoYXQgSVNBIGV4dGVuc2lvbiAoZm9y IHdoaWNoIHRoZQ0KPiBlbXVsYXRvciBjaGFuZ2UgaXMgYSBbdGhlIG9ubHldIHByZXJlcSk/DQoN CldvdWxkIHlvdSBtaW5kIGdpdmluZyBhIGNvbmNyZXRlIHN1Z2dlc3Rpb24/DQoNClRoYW5rcywN CiAtR2Vvcmdl From xen-devel-bounces@lists.xenproject.org Mon Mar 29 16:12:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 16:12:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103125.196767 (Exim 4.92) (envelope-from ) id 1lQuVN-0006iE-Ne; Mon, 29 Mar 2021 16:12:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103125.196767; Mon, 29 Mar 2021 16:12:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuVN-0006i7-KU; Mon, 29 Mar 2021 16:12:41 +0000 Received: by outflank-mailman (input) for mailman id 103125; Mon, 29 Mar 2021 16:12:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuVM-0006i2-3m for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 16:12:40 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e7142a48-95c0-44bd-8759-051e37ae6e09; Mon, 29 Mar 2021 16:12:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7142a48-95c0-44bd-8759-051e37ae6e09 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617034359; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=coNzvORoqGn9hwB4y6YvhJ8eq94OcLQZfb+UQ3GcuL0=; b=NlZLDBxRzACn+5Uf/DBeGlUb5qxmZvX9qNWglKyn+wjcMO84zMM8KT8S X201iQs/PjN4HCfcbtutnkaKgBlF6BEZPNDWQCUXpo+3Kznf/LVBfoxBJ upui0KsUkPyrVWektxo6UT9ox5raN/pmtvlITJaifB6xxq0YP2x3c0/4O k=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: a8xsoUYfnZdf+cfrQl4T9/wnXb4JPttpwATSdMYDEcljV3Ic9Dqmga0jmV6sol4gnjG9wydyg/ DUt8zTqT+s8lb1m33IZ0NkLcbjKTP3SQwKbMsgbBx3R+CKjBQuc50NwoYSbw24iHYHFokP3zH4 zaHfv1xk5Lg9p1Ad/f3hb1SAaGYyQgKdKbafBXCwEezmVD9Gl+1snXJYc5rqfgIgTZ5OEKGg5A 9lqA6sbDi0k6EPl5r08g0FlB4nzIHQ3Hab5M01qOvIRlwOZwVHK8YPqngoMbERsVHL1y7vYgRH AcI= X-SBRS: 5.2 X-MesageID: 41809436 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:iu5znK2x5ThIEUSV7StSlQqjBc92eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/BIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFmdJ1/Z xLN5JzANiYNzRHpO7x6gWgDpIEyN6I7KiniY7lvgtQZCtBApsQiztRIACdD0FwWU1nKPMCZd uhz+BAoCetfmlSS8y9CGUMUeSrnay1qLvNZxkaCxk7rDSUhTSz57LgVzSe1BESUzRAqI1SsV TtuQr/+6mlrrWH2gbRvlWjoah+tfnA7p94BMKKgtUIMTmEsGeVTaloRrHqhkFMnMiB81Av+e O8wSsIH8M20H/Je3HwnB2F4Xic7B8Ly1vPjWCVmmHip8uRfkN4N+NkiZhCehXUr2oM1esMq5 5j5G6Su5pJAR6opk2UjLKkN2AIqmOOrXUviuIVhXBEOLFuEoN5loAD4FhTVK4JASOS0vF7LM BVEMre6PxKGGnqCEzxg2h1zNSgGlQ1ExuWK3Jyw/C97jlMkHh1i3Yf3cwU901wkq4Vdp8s3Z WgDo1Y0JV1CuMGZ6N0A+kMBeGtDHbWfB7KOGWOZXz6CaAuIRv22tzKyYRwwNvvVI0DzZM0lp iEekhfr3QOd0XnDtDL9IFX8yrKXH62UV3Wu4Rjzqk8noe5aKvgMCWFRlxrudCnue8jDsrSXO v2H55KHfn5Ly/LFZxS1wPzH7leQENuFPE9i5IeYRajs8jLIorluqjwa/DIPofgFj4iRyfxGX 0GUD/vJNhR70yiV3Pi6SKhHU/FSwjax9ZdAaLa9+8cxMwmLYtXqDUYjly/+4WKJFR5w/ULVX o7BImivrKwpGGw82qNxX5uIABhAkFc56ilV3tLoAQNIl7laLprgaTGRUlimF+8YjNvRcLfFw BS435t/7isEpCWzSc+T9S9MmybiHMXrGmQT4gVn7CC4cuNQOJ+Mr8WHIhKUSnbHR18nghn7E 1ZbhUfe0PZHjTyzbm+gIcMH+HZfdlkiAKtKcpZwEiv7nm0lIUKfD82TjSuWcmYjUISXDJSnE R26LJaqqGHgyyTJWw2h/kYPFVAZH+MOq9PCB2Iaexv6+rWUTA1aV3PpDSBzzkvZ2Lh9iwp9x LcBBzRXcuOP31wlTRz1L3w/FZ9a2OHFngAG0xSgMlaDmTJunF6zOmRQLG8ulHhNmcqyv0BMT 3DfDsZKh5vwdfyzxKOhDOeDxwdt+YTF/2YA7I5f77J3HSxbIWOiKEdBvdRuI1oLdb0r4YwIK 6iUh7QKDv5Du8zsjbl1koNKW1xqHM+l+nv1wCg5G+k3GQnCf66GiUte5gLZ9Wd5XPjXfCGzd Fwis80p/K5NiH0ZsSdwa/aKz5FJRW7mx/6c8g47ZRVt7k1rr19At3SVibJzmhO2FEmN9jv/X luCZhT8fTEIMtibsYScyVW8h4gk8mONlIitkjzDvUldV8ggnfHN7qykvX1gKtqBlfEqBr7OF GZ/SEY5fvDUieZ3bMRCq47Iw1tGQMBwWUn+PnHe5zbCQ2see0G4UGzNWWldqRBDKeCArcdo3 9Bkqe1tv7SczC93g/evTF2eP0Tt2mmRN6/GwKKF6pD9cegNVGFn6ut54qygV7MOE+GQlVdgZ cAc0oaKtlHgH0lioY81yCpUKz5ok4/iTJlkHlav0+o3pLj+XvRGEFNLBbQjZpXVyRCK3Tgt7 WxzcGIkHDmpCVf0ZbNFE1MbshDFtgZQI/wNTpvI6ErzcmV1rtqhD9CbhcoB3M9jz643/oO58 bK5Mnv X-IronPort-AV: E=Sophos;i="5.81,288,1610427600"; d="scan'208";a="41809436" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=csvkRLWttUbw0P14gg7vq/ujg3tXtfSZt2V4SWmX8QlaAqYLSEBOO44UD0tXtGd+2cODrlKwHrVoZZApOjrdUs73uCPupc1rF4FVxmyk32mOnE+bG8Vl6yzUslZlg23uw7yj6NLngf5SfQo8GTi4dqISZse75oF/MpaH81Jk+wDv17MFyuBQSfZL4B4IB9/YqeLmYHFLNG69Am/Rt4sdhJqiseD4yUhCwqYDNapxK5Hc5xbA8lC+jDTar5uDa/pluoruQi9gjUZ4lon3Ue1aAubg9ircOSkSG0XK/W1CVh/Mcs7dx+YCtztsgZykK2wXKk3ZRS7LP0abk/9ADZICBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eBAMyQM4ILBRtbIPngkJISqa3U7nUEjmKwKcrPSlr7Y=; b=ZzIC9uRbusIg0hJtfvMYE8Il+pumZZo/nCTeMG+HS10qCXBi0b0lS34WIhLraW3bKywfiTLX9p0i/NgCxeqQqYAtkqqJREneGII3uJE9rx01CxiW+qIwbEdmulmg0Dl4bvB7UCnBId2x4Bxqcnppv/P8Z2/8xllBeHUbEDheqSSjs5aTX2rixDTTDa/0VdkqQIdyuioHTkIMf9EMqwiGekk3/1OB3YpUGz/kaup8uJvuYonbGBB+9HJ1zd4kE8aj8n9sW/PbwLnQJHStHZuniP7HN+8waqzb8LnPpmbPRYsmtHVZUmunuZg2km0NXU2b+IfSB3atarZmnxE12T+RmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eBAMyQM4ILBRtbIPngkJISqa3U7nUEjmKwKcrPSlr7Y=; b=M5jqz0+u6/+2q/YboDflPGJCSr+khyA39E6Tpn8lgzbyAL2kz+q8p7zdx99enEAVWNB02NBWUkG0DSAT1DnKRhAjoqsS5c9ytIi/NnsJul3wgZ/B7YQqbnFpP1+9DKNq3wTrPQs/2RKYg3n+rgFT8Dqhq/tHrdsQvSAwgZLSHA4= From: George Dunlap To: Jan Beulich CC: Ian Jackson , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code Thread-Topic: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code Thread-Index: AQHXINLTS489UfL61EKD4pjlwXnfbqqUSZCAgAbMCwA= Date: Mon, 29 Mar 2021 16:12:34 +0000 Message-ID: References: <20210324172608.302316-1-george.dunlap@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4a2d5849-19b2-4268-8369-08d8f2cd76dc x-ms-traffictypediagnostic: PH0PR03MB5751: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y8MyxVFEPMP8tBcuPWNZeJ+0ukXbS/sG6ypr0koP+F/niFrTZrdySswXhLjLdzvJyYn8FC7dyh45a18oT0nOMHHruceq8WgU1RB3Gb8eawAj9zc4lgq//CHmYEYQIHXTx49cukAM0p7dFtc6/yY0VEvA0hwzIcQi+ZBI9nGBy3WzlcPWqSOlt4XzvIn2ja1E0sPXyVLA/XKpGn2wNxl097+hokmGb9/u6/R5yOvIvijcmQ0wLRPKpuX44+ztZ0zMW/94VQ/k7m6BbLWYt+Q8+V0l3a5dgMhI0g46sEQV7GOp9GkroKFF7UMMn7wENfk7XxXFJw6p3pYVHb5NgqCijg8lcSrUO7tLqT39Q/IP/5GHzVwussIYgkZFA8QH8C4ZgMFzuSqwcnusNsiQH5Q1QK+YSNbDyXdH6fHSKiEEHnpWJ02yDLpFzIGB646pKI0M2PnY/HFyXx1Fp6G48pDp5L+AKU60QciSwxzUX/g4dykM01Q7qLqhQ1+kWRlzcWLQbLi6UNTmquijiRPuAuJO5OSxkeNCyNfVsc5LVBZlPPyuEQAd8c6DHjWFB87lT8Fqm9BTS0SBhHVFprZNanBJ7b8uOQ4N5jrHKtcyBTnmolLx424LTIbo5C/D23CyWQs2R30IWJPCUF1MSHBCAjszsj+jqgYs3g+LsH5ig5S/j0KbDbwBtZwY/yjvOvCU/oQiNTx48lHKJzmJIH7RWXAacJ44rnHA8LArfQD3mxzU1+JqbWnb5J+7bwRxBpBxVJo84XuJWPzydrgIRkJ7kuI9u1RLVNN86y6RN9FGzzDBQEZe+vixW4JIGjU3D5CQmqeB x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(366004)(136003)(376002)(396003)(71200400001)(4326008)(26005)(6486002)(2906002)(54906003)(53546011)(478600001)(33656002)(4744005)(6916009)(36756003)(38100700001)(316002)(8936002)(6512007)(5660300002)(8676002)(66556008)(66446008)(66946007)(91956017)(2616005)(186003)(66476007)(64756008)(76116006)(86362001)(6506007)(207903002)(219803003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?BZQo2ZSnSdvekv69k/PVydtNEd/n3cRnOXAyRk8y9Kko3Xn9EPonHozsENcD?= =?us-ascii?Q?rxiFMIbIFoTZDHXes6Ry1+kIEuToiJpd/s7QPggbxIr+gEAxfCf7/WV8LKIq?= =?us-ascii?Q?9Ltji/Ed0IiE87l6qbehRzQQ4e+tK3Ihn3aqmhMM1fC/tJ1XeJAbgelMQSZr?= =?us-ascii?Q?sXRvvTPIplMn3mKUgtvMXKlUR7ki9aALsIaQEekjh1ughFVNYlMyYe8eV6Pp?= =?us-ascii?Q?xZj3OSBcsW0uLs+Fk41rzwoefq0WSSiCp05K+gPge3eHWiRkZ0PVLk8fOB0f?= =?us-ascii?Q?YjBdDfgJa75EXwFlGoavE3IyItM7Q85ynZKYMKcks9o7AcoZR+ELVunh9+rx?= =?us-ascii?Q?vTm6MUoXrbf0XA6e7k1SQ/8JiZICpqz75SZHf6VUJx+psManqeAwIjqsjWHk?= =?us-ascii?Q?xzYAKK6Md6bP/mzyF/guaiuAnwo2PFxHx9BZJ6hd7M/TTneok5qX8/qr7nct?= =?us-ascii?Q?qj7F4PnrdtHvNZYRYOHOiuUEAHgiLBcDXX7LgrGEZ4zEgWlBYNK09HKp3Q71?= =?us-ascii?Q?aBETFy0z7RISPPNgd9+TGCn8RGxdnA9K3+u+YIKUaQfi8F/iAgHn4+wxCFiy?= =?us-ascii?Q?OWHu+EVe7Qem2pk/d/XLJsB8v1aI4iN/++n0Il5zqY7vB9xZhl1Mgb9LfnQx?= =?us-ascii?Q?09Jmkt0T1heIICjJC6cBLJLwtSvBSjg3RL9yPGUI5Ryrx2HIVMumOa6UHJBK?= =?us-ascii?Q?bY27CNtuQ3MhebR25XE9FFcccsKrfMW13PwQpzHOngpBcnDwiUSZgJ2qn+ru?= =?us-ascii?Q?dE6/9jyAuf3uCpOQ7rBu8e2sqUNfWQOt5O76/xJ7aQ5WzUNA8xBqlTAbz/4d?= =?us-ascii?Q?HdOhrfqWSaBtBOB8jaFSuB9JujxbJ67T1Ya7dH5L/A7ftNcA9m3HjFitCtpG?= =?us-ascii?Q?N5SmUcAr4GQT/QZv6EL7XcYbpOIHvN7eH6pPUdVFUMbKCkyUDzmep+lhXYNG?= =?us-ascii?Q?irxL2gMf11Vc3efMFsK8paVFJKM3YzdfTC1RInycQdsUYRC3NUw0odhKQSjt?= =?us-ascii?Q?3D3v2p4dDcUhLzqdgnim5hVqt2cX9AuQtNlLkQKkLAva1qEpJn+mu5YQXddM?= =?us-ascii?Q?0tKZHq3of9c4nRp0oT9NATSBIjkHYJz289hjuYND9eUg/g9w12PUD024dquL?= =?us-ascii?Q?AwMZHLiT+Ru8mdiAr7xbbdBzhMpVkKM1r+I9ZRE26z+idznmdSnoZ4T58YtU?= =?us-ascii?Q?wTba57aDminrJMi0rZ+yygIjvRo0vaoSMljhxEg+tgELQO0X+kgf0AZ9v6BF?= =?us-ascii?Q?SvBORIQuh4eFZieFjCCAUpxHE0XDE8tS3RuIuxgUk+UA6iGAT6WPl4IRyy6h?= =?us-ascii?Q?g/m7DkDd04iHOvxgGk63gjLujdtesPrA7A3fycj/4WWUXw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <4C72B132AE96A8419AFB7EDB5186102D@namprd03.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a2d5849-19b2-4268-8369-08d8f2cd76dc X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2021 16:12:34.7911 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SxxvEmFeKMFDNTsC+9rdWTLQj9XZ5/O11sCrvhGZ0trAGHBrciqad5AXAGeMPrT7a/3218vnZDO1cI005GqLOrNkLEN/h5iygeScfm88WMQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5751 X-OriginatorOrg: citrix.com > On Mar 25, 2021, at 7:08 AM, Jan Beulich wrote: >=20 > On 24.03.2021 18:26, George Dunlap wrote: >> Signed-off-by: George Dunlap >> --- >> Missed one from my list when creating the other series >>=20 >> CC: Ian Jackson >> CC: Jan Beulich >> CC: Roger Pau Monne >> --- >> CHANGELOG.md | 1 + >> 1 file changed, 1 insertion(+) >>=20 >> diff --git a/CHANGELOG.md b/CHANGELOG.md >> index 15a22d6bde..49832ae017 100644 >> --- a/CHANGELOG.md >> +++ b/CHANGELOG.md >> @@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keep= achangelog.com/en/1.0.0/) >> - x86_emulate: Expanded testing for several instruction classes >> - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 >> - CI loop: Add dom0less aarch64 smoke test >> + - Factored out HVM-specific shadow code, allowing PV shim to be slimme= r >=20 > But shadow code doesn't get included by default in shim-exclusive > builds (and others are unlikely to disable HVM). Can you propose some better text please? -George From xen-devel-bounces@lists.xenproject.org Mon Mar 29 16:15:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 16:15:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103131.196779 (Exim 4.92) (envelope-from ) id 1lQuXv-0006sB-BZ; Mon, 29 Mar 2021 16:15:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103131.196779; Mon, 29 Mar 2021 16:15:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuXv-0006s4-81; Mon, 29 Mar 2021 16:15:19 +0000 Received: by outflank-mailman (input) for mailman id 103131; Mon, 29 Mar 2021 16:15:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuXu-0006rz-0c for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 16:15:18 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7ba0f9e8-f5e0-4e76-865d-a21c2abcdcfa; Mon, 29 Mar 2021 16:15:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ba0f9e8-f5e0-4e76-865d-a21c2abcdcfa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617034516; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=H/etSajIvVyS1+Qxid3LfzwQ29MP/LQNDTOK0oSc3bk=; b=AYzEdSust4twO1JuEMT5IiYRY0eaA/odgwGipBzAIqfBarfuPqy6N/m4 3ddf3EzP5RbIelnDVL6/m/XkYpyuLDVAZsmZUcoyUXalqR92/zVpb3ZKd 3GlX4PK7YVDGTLEnNjvDrxcUsl92SC9TChXt7r0hAPRY3CmCet6bPpcWA A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: K0nMMO/Bfjp4Bf06twPple1uGIET5rFB22LalhadRLPgqNetCJs5vU+/G6c30dCZRe8CgbGqnG IzxwlBvWHyKoW5xFGjFVkGq3wdttrHhMsSILiay7nrMVqTA9/jnRMJtudIorU96Cl2qJoQ4nyh 72A9ufA7PniY26bOCg1vpAZr4VenqLCsx4+7Dpu1OMnzt3GxPZO3J1N6UPx7F0XaHDC3Olpocd VN/h/jKUkGnTmWJ6OrTJt4H/IUye05YbnMfCXBGlTvoZAD7f7rxA3lEg88fgYH+oGWW1J1K1uN F/s= X-SBRS: 5.1 X-MesageID: 40515557 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:IbpqjKixhk/a3daqMzfMAFHWfXBQXl8ji2hD6mlwRA09T+Wzva mV8sgz/xnylToXRTUcgtiGIqaNWjfx8pRy7IkXM96ZLW/bkUGvK5xv6pan/i34F0TFh5Zg/I ppbqQWMr3NJHdgi8KS2mWFOvYmhOKK6aW5wdrZpk0dKD1CT4FFw0NHBh2AEktwLTM2YqYRMJ aH/MJIq36BVB0sH6eGL0IIVeTCuNHH/aiOCXVtaiIP0wWAgSil77T3CXGjr3MjeghC3Ks49i z9mxH5j5/Tys2T8APW1GPY8v1t+efJ990rPqOxo/lQDj3tjwqyDb4ROYG/gA== X-IronPort-AV: E=Sophos;i="5.81,288,1610427600"; d="scan'208";a="40515557" From: George Dunlap To: CC: George Dunlap , Jan Beulich , Ian Jackson , Andrew Cooper Subject: [PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support Date: Mon, 29 Mar 2021 17:14:53 +0100 Message-ID: <20210329161457.345360-3-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210329161457.345360-1-george.dunlap@citrix.com> References: <20210329161457.345360-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- v2: - domU support also added CC: Jan Beulich CC: Ian Jackson CC: Andrew Cooper --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8c89212f14..538eae611c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - ARM SMMUv3 (Tech Preview) - Intel Processor Trace support (Tech Preview) - Named PCI devices for xl/libxl + - Support for zstd-compressed dom0 and domU kernels ## Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 29 16:15:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 16:15:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103132.196791 (Exim 4.92) (envelope-from ) id 1lQuY1-0006ux-JO; Mon, 29 Mar 2021 16:15:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103132.196791; Mon, 29 Mar 2021 16:15:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuY1-0006up-G2; Mon, 29 Mar 2021 16:15:25 +0000 Received: by outflank-mailman (input) for mailman id 103132; Mon, 29 Mar 2021 16:15:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuY0-0006uY-K6 for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 16:15:24 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 75101d4c-f12a-46ba-bd6a-1e2f4f100ae3; Mon, 29 Mar 2021 16:15:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75101d4c-f12a-46ba-bd6a-1e2f4f100ae3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617034523; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=4Kmj6iy4PIotKGTyDexDXi398U4mGAHli8fvkm6ZyDw=; b=crWJqpb/GTWlLlHAua0bog8yA5eDTthVhSjtQcpWrsCHY+XyRN3pHYzy 7xWPe5lQTbByCyiP1lfe1c8kTf325Ct15Wpgm7N1IO25Cyxlo7JoyumbT /8CfULwLtBy0aJk9xN817PnQCdDpeU6B4PDqO6dzRy5kfOdaHUxFttr95 k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: B6X4D/X+yoUmNQD3kIEUN8V2lCaLAIhNq/P69Ib1Y0W5xZMR2zVozqclKlXP8OUuq03IyMJeKf K8UZdZpOSyM6S03neVjE4kvrdOFNQngeF/sri4FNAAgCe46dG8IKu2bgXEYd4C4smscIhXnWy3 dCc4l5saIi3ehq/ZmJAjW84276/SV+RYs2LW6pQV5/6jT+xoSPiwhf1mqlMTWyMDYRvydi+ZZt RX64YvfRl5lbP6Y5y+IogDOPHt80ptUWC3JnttpS1H+1XpERRGKEru36vtDlp54wCwX+L2CJTQ 99k= X-SBRS: 5.1 X-MesageID: 40346954 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:qi6weK+SlyXb9W/94xluk+A+I+orLtY04lQ7vn1ZYzY9SK2lvu qpm+kW0gKxtS0YX2sulcvFFK6LR37d8pAd2/h3AZ6JWg76tGy0aLxz9IeK+UyYJwTS/vNQvJ 0QEJRWJ8b3CTFB4vrSxCmdP5IezMKc8Kau7N2uq0tFaQ1xcalv40NYJ2+gYy9LbTJLD5Y4C5 aQj/Avz1HLFBgqR/+2G2UfWKz7r8DL/aiWByIuPQIt6wWFkFqTiILSLh7w5HkjegIK5b8j9G Tf+jaJg5mejw== X-IronPort-AV: E=Sophos;i="5.81,288,1610427600"; d="scan'208";a="40346954" From: George Dunlap To: CC: George Dunlap , Jan Beulich , Ian Jackson , Andrew Cooper , Tamas K Lengyel Subject: [PATCH v2 for-4.15 1/7] Intel Processor Trace Support: Add CHANGELOG.md and SUPPORT.md entries Date: Mon, 29 Mar 2021 17:14:51 +0100 Message-ID: <20210329161457.345360-1-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap Acked-by: Jan Beulich Release-acked-by: Ian Jackson --- v2: - Added "x86" specifier CC: Andrew Cooper CC: Ian Jackson CC: Tamas K Lengyel --- CHANGELOG.md | 1 + SUPPORT.md | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c407f6bb2f..7f03e85bd7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - ARM IOREQ servers (device emulation etc.) (Tech Preview) - Renesas IPMMU-VMSA (Supported, not security supported; was Tech Preview) - ARM SMMUv3 (Tech Preview) + - Intel Processor Trace support (Tech Preview) ## Removed / support downgraded diff --git a/SUPPORT.md b/SUPPORT.md index a1efd8fcfd..cd0c09e6a4 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -247,6 +247,13 @@ Export hypervisor coverage data suitable for analysis by gcov or lcov. Status: Supported, Not security supported +### Processor trace support + +Support for using Intel Processor Trace technology to trace guests +from dom0. + + Status, x86: Tech Preview + ## Memory Management ### Dynamic memory control -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 29 16:15:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 16:15:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103133.196803 (Exim 4.92) (envelope-from ) id 1lQuY5-0006yN-TM; Mon, 29 Mar 2021 16:15:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103133.196803; Mon, 29 Mar 2021 16:15:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuY5-0006yE-PQ; Mon, 29 Mar 2021 16:15:29 +0000 Received: by outflank-mailman (input) for mailman id 103133; Mon, 29 Mar 2021 16:15:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuY4-0006xD-2G for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 16:15:28 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id beda1008-b54a-4e52-ab33-62ecc65ad82e; Mon, 29 Mar 2021 16:15:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: beda1008-b54a-4e52-ab33-62ecc65ad82e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617034522; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rsbB80Z+MtoLXJPWt4c9ZDuGpXTAkeQclsLqPn5oUbg=; b=hSjL2kpdM6Y6rkv2K6TDFLxYhukF8sieWUumeLzpiyEdKCbjlMEFZNUn s4Gl4gAemfSQg1taBUziyvQkFX5roLQUeTFai9jmeYSj5+K7cu0UF1ZdZ NcOsKD6SciPrP3RIoiraOZ7LT2sZaRF4bw/WDU/C44/sNmNVg6EXohanF U=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: pRdPk4hgWNsjmiYdNVRciXVpDAMtJmv3q+U9SXhPdkw4YHQy0GdsZjHWVH8OGJS86I/IF0cSXn axivYIixGh10afwfeR0QqTPJLfMU5hdNbcoqDWEatWXfjAFz63tvNkhnWTAdBunRky27xev0uR Q3B81K7rm16W1nNzPwIcIZzgr4r9XoXY0ACTxUBRxIqYk2Ly4ETk3tqSrim1GZF5HPplMu+9MD 8qRmbDk5axIZeDYTRdeBLPL/VXaFkmYoCtV/2hCx8XxhjsI/WZTa3qJldRfitZF06ua3GvmIzK sv8= X-SBRS: 5.1 X-MesageID: 40346953 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:bPJn4qmJaMXKazBxZ6v47cZ6cfTpDfKp3DAbvn1ZSRFFG/Gwve rGppom/DXzjyscX2xlpMuJP7OOTWiZ2Zl+54QQOrnKZniehEKDKoZ+4Yz+hwDxAiGWzJ866Y 5Me7VzYeeRMXFUlsD/iTPVL/8Bx529/LmslaPiyR5WPGRXQoVByys8NQqBCE1xQ2B9dP0EPb 6R/NBOqTblWVl/VLXZOlA/U+LOp8LGmfvdCHZsbXMawTKDgj+y5LnxHwLw5GZ7bxp1zao/6m +AqgTl58yYwomG4yXB3Gze5Yk+orrc4+ZEbfbituElbhHligOlf+1aKt+/gAw= X-IronPort-AV: E=Sophos;i="5.81,288,1610427600"; d="scan'208";a="40346953" From: George Dunlap To: CC: George Dunlap , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Ian Jackson , Manuel Bouyer Subject: [PATCH v2 for-4.15 4/7] CHANGELOG.md: NetBSD lib/gnttab support Date: Mon, 29 Mar 2021 17:14:54 +0100 Message-ID: <20210329161457.345360-4-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210329161457.345360-1-george.dunlap@citrix.com> References: <20210329161457.345360-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Signed-off-by: George Dunlap Reviewed-by: Roger Pau Monné Release-acked-by: Ian Jackson --- CC: Manuel Bouyer CC: Ian Jackson CC: Roger Pau Monne --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 538eae611c..fdad864a1f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Intel Processor Trace support (Tech Preview) - Named PCI devices for xl/libxl - Support for zstd-compressed dom0 and domU kernels + - Library improvements from NetBSD ports upstreamed ## Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 29 16:15:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 16:15:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103134.196815 (Exim 4.92) (envelope-from ) id 1lQuY7-00070O-5l; Mon, 29 Mar 2021 16:15:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103134.196815; Mon, 29 Mar 2021 16:15:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuY7-00070F-20; Mon, 29 Mar 2021 16:15:31 +0000 Received: by outflank-mailman (input) for mailman id 103134; Mon, 29 Mar 2021 16:15:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuY5-0006uY-Iz for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 16:15:29 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a0ae0d7e-5222-43a9-a6fe-7e54a74c23aa; Mon, 29 Mar 2021 16:15:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0ae0d7e-5222-43a9-a6fe-7e54a74c23aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617034524; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UkUUulHMRPz+2vhwcXSUEDdxzbFbFoOEDJ/HsF0pmbI=; b=H9/TTat0p7KXEwt1KnV9eXyNijkDjbS90CXXosXnxrZBY2H1ivwM1gFB h8gU1Qr8/6Uh0VnQUMpVxzi9TJLYhkseqoAWU+CFY53jAVpFZDnFUS7e2 2uYAT4QnW29zWfrINgI7hX63fQ/NGd1fMg22UcvM/7aS61aho3LjrQC4M 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: RCuso1508rjag8Sfa0R/YfsDRcyYaVzzEL8G7wQKI3CPtglISDoqnBmoDmV4vncbKqIO+Hu43C IdZqvBj6DOOBnMbcII521Ai8eXqEGvUzFDjq26/uIz2AB5IjxCKl5R7P9+vZy5oNEXnFNbFlJw dvhgwh228dwOZw4sDVRCG9ulB1ZJxzczX3xvI9pJYtcJYrwYtofVHC1jvfzAlq/W9ooYsQbe4T onhpEeKr+4hikcAu9XlwdWEKdtNV3vvb8ciEsYpDQvzxCaeCFu1dqFcSHv/Z8rto2b7e1/oKqz qT8= X-SBRS: 5.1 X-MesageID: 40346971 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:6ZkYza3v6xI49RhYD3+aIwqjBDUkLtp033Aq2lEZdDV+WKWj9v yGtvIdyBPylXItQ3kmg9+NI+2tRnnb+J5z7+AqTM6fdSPhv3alK5wn0Jv6z1TbalbD38NUyK sISdkcNPTeFl5/5PyU3CCZFJIazMCD4OSUg47lvhNQZCVLT40l0AtjEAacFSRNNW97LL40Do CV6MYChxfIQwV0Uu2BCnMIX/fOqrTw/fqMC3NrOzcd5AaDlj+u4rLheiLouSs2aD9T3awktV HMjg2R3NTaj9iA1hTe22XPhq43pPLdzLJ4avCku4wwIjXohh3AXvUFZ4G/ X-IronPort-AV: E=Sophos;i="5.81,288,1610427600"; d="scan'208";a="40346971" From: George Dunlap To: CC: George Dunlap , Ian Jackson , Jan Beulich , Roger Pau Monne Subject: [PATCH v2 for-4.15 7/7] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code Date: Mon, 29 Mar 2021 17:14:57 +0100 Message-ID: <20210329161457.345360-7-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210329161457.345360-1-george.dunlap@citrix.com> References: <20210329161457.345360-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- v2: - Add into the series CC: Ian Jackson CC: Jan Beulich CC: Roger Pau Monne --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c4696e41a1..9912ea5a8d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 - CI loop: Add qemu-based dom0 / domU test for ARM - CI loop: Add dom0less aarch64 smoke test + - Factored out HVM-specific shadow code, allowing PV shim to be slimmer ## Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 29 16:15:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 16:15:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103136.196827 (Exim 4.92) (envelope-from ) id 1lQuYB-00074y-HK; Mon, 29 Mar 2021 16:15:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103136.196827; Mon, 29 Mar 2021 16:15:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuYB-00074p-Cp; Mon, 29 Mar 2021 16:15:35 +0000 Received: by outflank-mailman (input) for mailman id 103136; Mon, 29 Mar 2021 16:15:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuYA-0006uY-JI for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 16:15:34 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 51a755fe-00a8-403f-a597-ecb03f9a6d87; Mon, 29 Mar 2021 16:15:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51a755fe-00a8-403f-a597-ecb03f9a6d87 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617034524; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=U5H4Sx5uIBD2IcgPM9vZXVBYk16q1MzBJS9boc0kKR4=; b=CeCUNFs8zjex1nCCFoSM6XaOP2Ub1EnpQw0DOO3QxtCTgqUCsvpshnup 10vXRc/1FktaT+p+6HKldroIhSE2Rmy2ytwT/qcXzRICyLMgkg1lFxXnt HtYqxp7WboT8oRuas7tnDOY8TuiI3MNxiLmPk1i92EUjupL7YFNO4n4Zc M=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: M1I+J4Ehm8jfBaO9mXd0MGDAAC712Gc5f5adrMvLGeDMo2BnexG+jxz18nwZ8SmLh3763/9yrW QAH3vFGBy7qtV7ToZSzC2kFa0wRfIFOTIC0o5xj3PrbgoJ9k+lR35u2rm8Ti7uxgEqHU9WjThG FOpAHIr885rKaLwdUZuvEvUhMHiveUeOcuHXEpZ2rPK71SGxItmFskXoHa8J6pawvb8o9rN9NR koZ+SCbdhqcPQR16LhLo5TnlanjHZEcYwfmtK/9xGPzymDmKdUp3u1oDH31+5mNzFjhY3jgLiQ RdM= X-SBRS: 5.1 X-MesageID: 41809679 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:PSxA363qlDyAyQkK69SmiQqjBDckLtp033Aq2lEZdDV+WKWj+f yGtvIdyBPylXItQ3kmg9+NI+2tRnnb+J5z7+AqTNGfdSPhv3alK5wn0Jv6z1TbalXD38NUyK sISchDIfLqC1wSt6rHySm+V+0t2dyWtJ2v7N2uqktFaSFPR+Ve4xxiCgCde3cGIzVuIZYiDp KT6o5milObCBcqR/+2DHUEQOTPzuej/PmNDCIuPBIp5BKDijml8tfBYnyl9ywTTi9VxvMa+X XF+jaJn5mLie2xyRPXygbojqh+pd2J8LR+Lf3JrsAULzn24zzYBrhcZw== X-IronPort-AV: E=Sophos;i="5.81,288,1610427600"; d="scan'208";a="41809679" From: George Dunlap To: CC: George Dunlap , Paul Durrant , "Ian Jackson" Subject: [PATCH v2 for-4.15 2/7] CHANGELOG.md: Add named PCI devices Date: Mon, 29 Mar 2021 17:14:52 +0100 Message-ID: <20210329161457.345360-2-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210329161457.345360-1-george.dunlap@citrix.com> References: <20210329161457.345360-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap Reviewed-by: Paul Durrant Release-acked-by: Ian Jackson --- CC: Ian Jackson CC: Paul Durrant --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f03e85bd7..8c89212f14 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Renesas IPMMU-VMSA (Supported, not security supported; was Tech Preview) - ARM SMMUv3 (Tech Preview) - Intel Processor Trace support (Tech Preview) + - Named PCI devices for xl/libxl ## Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 29 16:15:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 16:15:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103137.196839 (Exim 4.92) (envelope-from ) id 1lQuYG-0007BH-R9; Mon, 29 Mar 2021 16:15:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103137.196839; Mon, 29 Mar 2021 16:15:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuYG-0007B5-N4; Mon, 29 Mar 2021 16:15:40 +0000 Received: by outflank-mailman (input) for mailman id 103137; Mon, 29 Mar 2021 16:15:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuYF-0006uY-JM for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 16:15:39 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f436a48c-e889-44cb-a018-0a580cb45e05; Mon, 29 Mar 2021 16:15:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f436a48c-e889-44cb-a018-0a580cb45e05 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617034525; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=c8Acnbxa1/yeuV9OWwGU3B027d8moILUgTfc1XUj1e4=; b=PiiU9pTNNPdesQvrBAusZWMbuoRfGsB1efOe+4QmukO2fpUoQaa9QbBg rl+ZONq9xahcagIcwT7VZz/reyt9+sXRWmuGbaAcT95uCh6fv6akoPTcx KA8nq5V3nRE4m51XIpUV/0ebuiuxuCLAkqhNx+IXqeCxXhMEMh46RGHJS w=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: LcZaO3GFR9GBSvb5lK9PQ0TuL/7h/fK8SFLTgKqz8WhjDBybJO+lPpA0IwBvcw2ftxJ9WcgZw2 hlmMfNKEp37TzqXg8I9N2rpQkB96sVqq+9HWkFbOzWgC/UHaGq9WIPDkTS//mBwXewfVQz7iBl IB9V+lgxrTQ7b1FMkVDvIgeua5QX/8W4OBx94eR+Uw0/bhH3oj8BTS0sPelX/VMo1HeU7va1am wdDN184pURlkMB2QqONjAFV98tbZKozrqzWUAcuegzFA2njeLDAW1U/TEj4E9ea7bJycQgzSqp 2ZU= X-SBRS: 5.1 X-MesageID: 41809680 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:La6nDKDmZw08/EzlHekr55DYdL4zR+YMi2QD/WoZc31oW+afkN 2jm+le6AT9jywfVGpltdeLPqSBRn20z+8N3aA6O7C+UA76/Fa5NY0K1/qY/xTMEzDzn9Qttp tIXLN5DLTLYmRSrcG/2wWgFsZl/d/vytHNuc7771NACT5ncLth6QARMHf8LmRTSBNdDZQ0UL qwj/A3xQaIQngcYsSlCnRtZYGqzLen+K7OWhIICwUq7wODl1qTmdnHOiOVwwsEVHd3yaoimF K16zDR3LmpsP2w13bnt1P70pI+orXc4+oGIMSNj8QPQw+c7zqVWA== X-IronPort-AV: E=Sophos;i="5.81,288,1610427600"; d="scan'208";a="41809680" From: George Dunlap To: CC: George Dunlap , Jan Beulich , Ian Jackson Subject: [PATCH v2 for-4.15 5/7] CHANGELOG.md: Add entries for emulation Date: Mon, 29 Mar 2021 17:14:55 +0100 Message-ID: <20210329161457.345360-5-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210329161457.345360-1-george.dunlap@citrix.com> References: <20210329161457.345360-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- CC: Jan Beulich CC: Ian Jackson --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index fdad864a1f..62174c8c74 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Named PCI devices for xl/libxl - Support for zstd-compressed dom0 and domU kernels - Library improvements from NetBSD ports upstreamed + - x86_emulate: Support AVX-VNNI instructions + - x86_emulate: Expanded testing for several instruction classes ## Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 29 16:15:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 16:15:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103141.196851 (Exim 4.92) (envelope-from ) id 1lQuYM-0007Hr-7g; Mon, 29 Mar 2021 16:15:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103141.196851; Mon, 29 Mar 2021 16:15:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuYM-0007Hf-3W; Mon, 29 Mar 2021 16:15:46 +0000 Received: by outflank-mailman (input) for mailman id 103141; Mon, 29 Mar 2021 16:15:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuYK-0006uY-JU for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 16:15:44 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f153767d-3410-4497-95d6-e0bfc44d0914; Mon, 29 Mar 2021 16:15:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f153767d-3410-4497-95d6-e0bfc44d0914 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617034542; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+84Kakahzof4rIC4av0/vbXyWMh2pRvsKxC2oPYPtNk=; b=AS23B2+FXem/cjJkXFYx50oiX/C/dC/W4PNVmc5xWqODoieQo64YaEqS 6vQ+BEJz/NB8IAhbI83GITfliwJGtmysSGDbj3PqehcEjFfBo828u7kJD pj59DiVwqLlPcToCgfxf1fzT0y3lRZq2Bs8IPyIR44Wy/mIVa/X/yTYJG 0=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: FnDIGPTOVfsSgZeVSP+7ly89GXbTHF8tWkB+xBfZvFsFQ0GhM0kWm++k3CP67YQnogK4IjUIPx qCOQslRkzrHu5TbSAw/M7cqcfnkjllswAdMQCLyutL4lrq7na5DHkgF4S2DsjpPrOvOgpm3b39 O/f/zor4GmnkSQL6x4z6q3oA8I+oUTMk5tJzOK/7RqL/dQtqSjrrLDQg3RUA+PyJuXTMcv8s09 YoY+91QXFOZh2eJ32iYqli9c9Mle306hBQeATRDf6pFPxqPLwC6dP4jjpd13dTK8bAY+CnLVIS /hQ= X-SBRS: 5.1 X-MesageID: 40725689 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:1jB+9KtkNzZ3F8YFNE3ek7hb7skD8dV00zAX/kB9WHVpW+az/v rOoN0w0xjohDENHEw6kdebN6WaBV/a/5h54Y4eVI3SJTXOkm2uMY1k8M/e0yTtcheOjdJ1+K 98f8FFeb7NJHdgi8KS2maFOvYmhOKK6aW5wdrZpk0dKT1CT4FFw0NHBh2AEktwLTM2Y6YRMJ aH/MJIq36BVB0sH6aGL0IIVeTCuNHH/aiOCXVtanIawTKDgj+y5LnxHwLw5GZ4bxp1zao/6m +AqgTl58yYwomG4yXB3Gze5Yk+orvc4+ZEbfbjtuElbhHligOlf+1aKti/gAw= X-IronPort-AV: E=Sophos;i="5.81,288,1610427600"; d="scan'208";a="40725689" From: George Dunlap To: CC: George Dunlap , Wei Liu , "Andrew Cooper" , Stefano Stabellini , Doug Goldstein Subject: [PATCH v2 for-4.15 6/7] CHANGELOG.md: Add entries for CI loop Date: Mon, 29 Mar 2021 17:14:56 +0100 Message-ID: <20210329161457.345360-6-george.dunlap@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210329161457.345360-1-george.dunlap@citrix.com> References: <20210329161457.345360-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: George Dunlap --- v2: - Add dom0 / domU testing for ARM on alpine Linux as well CC: Wei Liu CC: Andrew Cooper CC: Stefano Stabellini CC: Doug Goldstein --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 62174c8c74..c4696e41a1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Library improvements from NetBSD ports upstreamed - x86_emulate: Support AVX-VNNI instructions - x86_emulate: Expanded testing for several instruction classes + - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 + - CI loop: Add qemu-based dom0 / domU test for ARM + - CI loop: Add dom0less aarch64 smoke test ## Removed / support downgraded -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Mar 29 16:22:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 16:22:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103154.196866 (Exim 4.92) (envelope-from ) id 1lQuf1-0000Ab-44; Mon, 29 Mar 2021 16:22:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103154.196866; Mon, 29 Mar 2021 16:22:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuf1-0000AU-0V; Mon, 29 Mar 2021 16:22:39 +0000 Received: by outflank-mailman (input) for mailman id 103154; Mon, 29 Mar 2021 16:22:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQuf0-0000AP-4T for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 16:22:38 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9302bad1-5ce2-45ca-8a75-ffae236020f7; Mon, 29 Mar 2021 16:22:37 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 65BE5AEB3; Mon, 29 Mar 2021 16:22:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9302bad1-5ce2-45ca-8a75-ffae236020f7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617034956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uLZl020j4NGo26Jwem8GG1prv3kdpHdnDhxzLq170bY=; b=dSc8n4GDHLEE4OwHRJPrlD9U/ClP83dJsfA5AQCs9ELK7Frmyk4DUF7OXcOEgBtKwuOicc g36n/yeEoXbECLuZFQkhZ7A+hpAYBR+F2fMir3TsZNI+qR6kXodqD/3hTwACTFVOask7AK yDzZnTdxmCnjMufUjNBOaGCPccZJl6s= Subject: Re: [PATCH v2] x86/vpt: Do not take pt_migrate rwlock in some cases To: Boris Ostrovsky Cc: andrew.cooper3@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com, iwj@xenproject.org, xen-devel@lists.xenproject.org, roger.pau@citrix.com References: <1616809866-30837-1-git-send-email-boris.ostrovsky@oracle.com> <82868938-bf57-25c2-38f6-1ec8e9c92362@suse.com> <318ca597-c7fe-ceeb-df12-2802b2cc74fb@oracle.com> From: Jan Beulich Message-ID: <52db82ef-5e9d-ed0c-df87-2aef3bbf1657@suse.com> Date: Mon, 29 Mar 2021 18:22:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <318ca597-c7fe-ceeb-df12-2802b2cc74fb@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 29.03.2021 17:31, Boris Ostrovsky wrote: > > On 3/29/21 11:21 AM, Jan Beulich wrote: >> On 29.03.2021 17:04, Boris Ostrovsky wrote: >>> On 3/29/21 5:56 AM, Jan Beulich wrote: >>>> On 27.03.2021 02:51, Boris Ostrovsky wrote: >>>>> @@ -580,13 +593,22 @@ static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) >>>>> return; >>>>> >>>>> write_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); >>>>> + >>>>> + pt_vcpu_lock(pt->vcpu); >>>>> + if ( pt->on_list ) >>>>> + list_del(&pt->list); >>>>> + pt_vcpu_unlock(pt->vcpu); >>>> While these two obviously can't use v, ... >>>> >>>>> pt->vcpu = v; >>>>> + >>>>> + pt_vcpu_lock(pt->vcpu); >>>>> if ( pt->on_list ) >>>>> { >>>>> - list_del(&pt->list); >>>>> list_add(&pt->list, &v->arch.hvm.tm_list); >>>>> migrate_timer(&pt->timer, v->processor); >>>>> } >>>>> + pt_vcpu_unlock(pt->vcpu); >>>> ... these two again could (and imo should), and ... >>>> >>>>> write_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); >>>> ... really this and its counterpart better would do so, too (albeit >>>> perhaps in a separate patch). >>> >>> Are you suggesting to replace pt->vcpu with v here? >> Yes. >> >>> They are different at lock and unlock points (although they obviously point to the same domain). >> Indeed, but all we care about is - as you say - the domain. > > > Hmm.. I think then it's better to stash domain (or, better, pl_time) into a local variable. Otherwise starting with different pointers in lock and unlock paths (even though they eventually lead to the same lock) makes me a bit uncomfortable. > > > Secondly, do you want this and the check for pt->vcpu == v in pt_adjust_vcpu() be done in two separate patches or can they go into a single one? This one should be right in your base patch. What I think may better be in a separate one is the adjustment to write_lock() / write_unlock(). Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 29 16:23:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 16:23:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103160.196878 (Exim 4.92) (envelope-from ) id 1lQufm-0000HQ-GU; Mon, 29 Mar 2021 16:23:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103160.196878; Mon, 29 Mar 2021 16:23:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQufm-0000HJ-DW; Mon, 29 Mar 2021 16:23:26 +0000 Received: by outflank-mailman (input) for mailman id 103160; Mon, 29 Mar 2021 16:23:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQufl-0000HB-Pn for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 16:23:25 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e78dafc2-1c7d-4337-b163-6b11f6dc4188; Mon, 29 Mar 2021 16:23:25 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6001EAFC1; Mon, 29 Mar 2021 16:23:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e78dafc2-1c7d-4337-b163-6b11f6dc4188 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617035004; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MHfMOSSABEXyWDNhveuRdZyJpT9NE+ZmQyutBw5Vut8=; b=BJHEclaIzKJf5icxelU+t3zsIOcKtLk/KalKcaskzDx2jfF0FmvWNyFYXxebm1Yw0ShIBT Z8om2wZTTHPoBQLzYgWO5g/8kkV5/5cy+yjuzWi6/kLVR2PGYeC6VeUYhuuHdNyCKBh5rk h4oEbLiI+0MM9X8H3qETUDw1XGrlaQs= Subject: Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code To: George Dunlap Cc: Ian Jackson , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <20210324172608.302316-1-george.dunlap@citrix.com> From: Jan Beulich Message-ID: <23461afc-c0e0-eb33-9ed3-52f050b6aef0@suse.com> Date: Mon, 29 Mar 2021 18:23:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 29.03.2021 18:12, George Dunlap wrote: >> On Mar 25, 2021, at 7:08 AM, Jan Beulich wrote: >> On 24.03.2021 18:26, George Dunlap wrote: >>> Signed-off-by: George Dunlap >>> --- >>> Missed one from my list when creating the other series >>> >>> CC: Ian Jackson >>> CC: Jan Beulich >>> CC: Roger Pau Monne >>> --- >>> CHANGELOG.md | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/CHANGELOG.md b/CHANGELOG.md >>> index 15a22d6bde..49832ae017 100644 >>> --- a/CHANGELOG.md >>> +++ b/CHANGELOG.md >>> @@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>> - x86_emulate: Expanded testing for several instruction classes >>> - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 >>> - CI loop: Add dom0less aarch64 smoke test >>> + - Factored out HVM-specific shadow code, allowing PV shim to be slimmer >> >> But shadow code doesn't get included by default in shim-exclusive >> builds (and others are unlikely to disable HVM). > > Can you propose some better text please? Does this need mentioning here in the first place? Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 29 16:24:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 16:24:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103163.196890 (Exim 4.92) (envelope-from ) id 1lQugR-0000O7-Ql; Mon, 29 Mar 2021 16:24:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103163.196890; Mon, 29 Mar 2021 16:24:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQugR-0000O0-Ms; Mon, 29 Mar 2021 16:24:07 +0000 Received: by outflank-mailman (input) for mailman id 103163; Mon, 29 Mar 2021 16:24:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQugQ-0000Nr-Cn for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 16:24:06 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id de8aa2ce-0cb8-412b-adfd-f36fbae6f849; Mon, 29 Mar 2021 16:24:05 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DF7ECAF4E; Mon, 29 Mar 2021 16:24:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de8aa2ce-0cb8-412b-adfd-f36fbae6f849 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617035045; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nXa7aZhL7k4mbwPdIZACHQpcq75Boe+S6lB0fvSUzm8=; b=JQMgBA/G2J6zgBl6moTvsL6NJXB6lHfwcrCq15HBaTcnBLdumQU980dvkgUSQlP9YfnsLN lLaQUHfAX+Q47cKBamPWHtqHNQbKxqJ8VipGmRSu6M1gCJ21tDcwI8cTZNXWt+cP26hIOi /27BzBych2xqk/kHRkiJObMgODbfhY4= Subject: Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation To: George Dunlap Cc: Andrew Cooper , "xen-devel@lists.xenproject.org" References: <20210324164407.302062-1-george.dunlap@citrix.com> <20210324164407.302062-5-george.dunlap@citrix.com> <33f78891-c894-b41a-a1a3-82aac1f57b8d@suse.com> <0A187740-DB6E-486C-8B10-5207CE6A5D72@citrix.com> <7407cac8-c55d-0372-123b-39c9949e6ca5@citrix.com> From: Jan Beulich Message-ID: <5b0258db-e362-0085-43e4-78a9b9a88da6@suse.com> Date: Mon, 29 Mar 2021 18:24:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 29.03.2021 18:06, George Dunlap wrote: > > >> On Mar 25, 2021, at 1:58 PM, Jan Beulich wrote: >> >> On 25.03.2021 10:37, Andrew Cooper wrote: >>> On 25/03/2021 09:04, George Dunlap wrote: >>>>> On Mar 25, 2021, at 7:57 AM, Jan Beulich wrote: >>>>> On 24.03.2021 17:44, George Dunlap wrote: >>>>>> --- a/CHANGELOG.md >>>>>> +++ b/CHANGELOG.md >>>>>> @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>>>>> - Named PCI devices for xl/libxl >>>>>> - Support for zstd-compressed dom0 kernels >>>>>> - Library improvements from NetBSD ports upstreamed >>>>>> + - x86_emulate: Support AVX-VNNI instructions >>>>>> + - x86_emulate: Expanded testing for several instruction classes >>>>> TBH both seem too minor to me to be mentioned here. If I was to pick >>>>> just one, I'd keep the former and drop the latter. >>>> It’s always quite difficult in these releases to help express to people exactly what’s happened. We’ve got over 1000 changesets — what have we been doing? If my star chart is correct, the latter represents nearly 1700 extra lines of codes in tools/tests/x86_emulator/predicates.c. It’s actually a reasonable chunk of code churn, which I think is worth highlighting. >>> >>> I agree with Jan. New concrete instruction groups are useful for an end >>> user to read. "We refactored some internal of a test harness" isn't, >>> especially when it would most likely be repeated every release. >>> >>> I'd drop the latter line and just keep the former. >> >> And then perhaps also not focus on the emulator, but merely on the >> fact that guests now can use that ISA extension (for which the >> emulator change is a [the only] prereq)? > > Would you mind giving a concrete suggestion? x86: Allow domains to use AVX-VNNI instructions Jan From xen-devel-bounces@lists.xenproject.org Mon Mar 29 17:02:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 17:02:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103199.196913 (Exim 4.92) (envelope-from ) id 1lQvGx-0004h2-Rw; Mon, 29 Mar 2021 17:01:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103199.196913; Mon, 29 Mar 2021 17:01:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQvGx-0004gv-O2; Mon, 29 Mar 2021 17:01:51 +0000 Received: by outflank-mailman (input) for mailman id 103199; Mon, 29 Mar 2021 17:01:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQvGw-0004gq-IQ for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 17:01:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQvGw-0001tM-Fu for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 17:01:50 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lQvGw-0005pb-DZ for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 17:01:50 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lQvGt-0002H8-1j; Mon, 29 Mar 2021 18:01:47 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=OVeCx8d/V1Biykhz6y226kqByFODYfqiEyLhC5ivNvY=; b=KxZ2b7Ng+DevD0iEQLDjJWYCMn 6fTBsHrmO0cgmXyvz/y1RchvX/Qqnjn5KFQxkNFONh8+R0uoeMRgncEWG7pcO6x1G1UskwFUNowrm ExKq6PSN+mmyk0aJP0LC9z97KUFvP44bn30/ik+iDmRRhzsAJrfmHu2KbRsYJKz7YX5U=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24674.2042.737729.423760@mariner.uk.xensource.com> Date: Mon, 29 Mar 2021 18:01:46 +0100 To: George Dunlap Cc: , Jan Beulich , Andrew Cooper Subject: Re: [PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support In-Reply-To: <20210329161457.345360-3-george.dunlap@citrix.com> References: <20210329161457.345360-1-george.dunlap@citrix.com> <20210329161457.345360-3-george.dunlap@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) George Dunlap writes ("[PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support"): > Signed-off-by: George Dunlap Release-Acked-by: Ian Jackson From xen-devel-bounces@lists.xenproject.org Mon Mar 29 17:05:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 17:05:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103203.196925 (Exim 4.92) (envelope-from ) id 1lQvKR-0004qg-9Q; Mon, 29 Mar 2021 17:05:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103203.196925; Mon, 29 Mar 2021 17:05:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQvKR-0004qZ-5T; Mon, 29 Mar 2021 17:05:27 +0000 Received: by outflank-mailman (input) for mailman id 103203; Mon, 29 Mar 2021 17:05:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQvKQ-0004qT-0N for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 17:05:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQvKP-0001xb-Un for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 17:05:25 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lQvKP-000689-TC for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 17:05:25 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lQvKL-0002Hx-8x; Mon, 29 Mar 2021 18:05:21 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:CC:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=GgG3+Ks6Vmz+LcEfKplO16OsuXqMnsANClzwh3J1DM4=; b=CtoqbgRaayWRSZo0vCors6kY9l rqzRqDhTkXILz9zk9G93KASJ078jPLISI8Hn7Wmd+F0F9+GyxmN5m5b3bZ/rRSuo/Pmjkyw9Mrwa7 FYF82dTVHwPe5ZgOQb9aZcknTLzb0GF5SRVQits5a1XPC7CCFI1Hdhri1jggGVAMtzWI=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24674.2257.82806.365406@mariner.uk.xensource.com> Date: Mon, 29 Mar 2021 18:05:21 +0100 To: committers@xenproject.org CC: George Dunlap , , Jan Beulich , Andrew Cooper Subject: Re: [PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support In-Reply-To: <24674.2042.737729.423760@mariner.uk.xensource.com> References: <20210329161457.345360-1-george.dunlap@citrix.com> <20210329161457.345360-3-george.dunlap@citrix.com> <24674.2042.737729.423760@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Ian Jackson writes ("Re: [PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support"): > George Dunlap writes ("[PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support"): > > Signed-off-by: George Dunlap > > Release-Acked-by: Ian Jackson Actually, better idea: I hereby give a blanket release ack for anything in CHANGELOG.md that is committed by the end of Wednesday. Whatever isn't ready by then I will look properly at. I expect us to commit final docs updates early on Tuesday the 6th. So in practice I think that means that any input from people who are away for Easter needs to be finalised before the Easter weekend so that George and I can get it properly into the tree. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Mon Mar 29 17:16:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 17:16:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103207.196936 (Exim 4.92) (envelope-from ) id 1lQvV6-0005yM-Ae; Mon, 29 Mar 2021 17:16:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103207.196936; Mon, 29 Mar 2021 17:16:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQvV6-0005yF-7Z; Mon, 29 Mar 2021 17:16:28 +0000 Received: by outflank-mailman (input) for mailman id 103207; Mon, 29 Mar 2021 17:16:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQvV5-0005yA-Fs for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 17:16:27 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5df2846e-d37d-40f1-8b07-b437444c0d3e; Mon, 29 Mar 2021 17:16:26 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6DF36AFE2; Mon, 29 Mar 2021 17:16:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5df2846e-d37d-40f1-8b07-b437444c0d3e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617038185; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ai6DzfaiyobueiWo4GUDCJOAvIrc4jVq3SJuy2jSUjI=; b=sbX7CQ1iitRUNztdxI/RSPQZt/6sG1kDbslFZstq++iDmmfrr+C1pDLlaclv0NTYIJE+4K WJErHiRwzCrQP/6VdwZrHW0AgVGAoN3QjAkVmzYmBGJALTibqaHUX1Jtmxvai7M8kSAxEY k7NkjNSzFCt7/7+JDvLvge+IyLWjUMQ= Message-ID: <970850cb5839e06dca089229029850cc67eae260.camel@suse.com> Subject: Re: [ANNOUNCE] Xen 4.15 release update - still in feature freeze From: Dario Faggioli To: Ian Jackson , committers@xenproject.org, xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?ISO-8859-1?Q?Fr=E9d=E9ric?= Pierret , George Dunlap Date: Mon, 29 Mar 2021 19:16:24 +0200 In-Reply-To: References: <24655.20609.834996.744652@mariner.uk.xensource.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-A9rtXkDLvTo5CitN2QWV" User-Agent: Evolution 3.38.4 (by Flathub.org) MIME-Version: 1.0 --=-A9rtXkDLvTo5CitN2QWV Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2021-03-18 at 19:11 +0100, Dario Faggioli wrote: > On Mon, 2021-03-15 at 12:18 +0000, Ian Jackson wrote: >=20 > > =20 > > =C2=A0 https://bugzilla.opensuse.org/show_bug.cgi?id=3D1179246 > >=20 > So, this is mostly about the third issue, the one described in the > openSUSE bug, which was however also reported here, by different > people. >=20 > As I've just wrote there (on the bug), I've been working on trying to > reproduce the problem on a variety of different machines. Seems AMD > seemed to be the most impacted, I've lately focused on hardware from > such vendor. >=20 FWIW, as a further update, there are now new info/logs here: https://bugzilla.opensuse.org/show_bug.cgi?id=3D1179246 which I'm analyzing. And I should be able to have direct access to a box where the issue can reproduced. Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-A9rtXkDLvTo5CitN2QWV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmBiC2gACgkQFkJ4iaW4 c+4K5RAAwZviGTD38d9qj1kijO6ZeQXGOMPi89cj+P9ZLq73CpJ80B7N+LfTVc66 NODK6jI1rqu5xW1981HEdEEmNx7Xfn9mI9AXwg2q9+eS3L4c7c3La5Yyj6/u7xcb G+xKWbPC6adHr+W5kxd5CHV8ORn9/nl4/IFtRky/fi/hLRpbn09ld/A6KoMGmpgv aKWaWOKP5VpkOtpRvS4qKP04ciXGVmmzYoQ1ugi8alISv4tYtB/ez7F2orn5/WfF V8xLZnVCaHYIE7+CEly7ZiM1jQ+KSzq+Jge9uWtJNo6vTZUgXD2hbbw3CxP9z6r9 ruI4CQIVWdDVa7jSOQqkmqbaHdfdZbTQqOmOvvpAgaGV3aCBHm17xAOOGDvEqVO7 DO6c4Cfpwg1QIdZWzOPbuHohgLS7AS7+I7RfB02TnHNG+Lansb7XfVnqoawXVa/t IH+YOT7HQdU1Jp4LGZ1OUx8Cj3HrNzvJnBwyAHuPj5V3QP40cf/w61FJ78/bXq+N SkJgM92Rns16Bovab0kp9JTjmBuwGcWbpZojN5UpejpD4oVFLtPqWK3kgpxwkpV/ kNgZUeucfLN7CXHcOR4ZIRNievqA++NgZ5X1KX3G9XUDQXQgaFNaJkpnIdYyFU0Q fY3jnA+pqmdIotypiOC+J2k/4hrTu8nGgfFXRHQBizuOdmnnREE= =CV/+ -----END PGP SIGNATURE----- --=-A9rtXkDLvTo5CitN2QWV-- From xen-devel-bounces@lists.xenproject.org Mon Mar 29 17:27:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 17:27:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103211.196949 (Exim 4.92) (envelope-from ) id 1lQvfM-0007Cb-Ac; Mon, 29 Mar 2021 17:27:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103211.196949; Mon, 29 Mar 2021 17:27:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQvfM-0007CU-6v; Mon, 29 Mar 2021 17:27:04 +0000 Received: by outflank-mailman (input) for mailman id 103211; Mon, 29 Mar 2021 17:27:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQvfK-0007CP-Td for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 17:27:03 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 54b08051-8b87-40f5-a8da-fe6591cba76a; Mon, 29 Mar 2021 17:27:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54b08051-8b87-40f5-a8da-fe6591cba76a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617038821; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=GvLuvzrCqFz8ikOr9+NaVdINDkt9OQKXKrDm4hATpnU=; b=b0hDyFkvraIy6jbzrqmzTFUU/AAeDbhWdeM83q6jIc0sDhZNUAmXJbvb ry/17Bh0/+cNeT48nQKgwg6OjNN92+543RrZMQ1+nPSs0Zovm7TidxAGz pdGeulpLzmbJDzDM4X+wp6oLyc7tqib1e4qJc3Ij3NxW3xty9v7pnNj7A w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 7c3cC6cEsLt1Jm1l8jywSJPcLSTxQStdqkjW6XCC/xFjLn0bd/Ic5n9BxavQsdhg0C2L+CuRsU QMmf5rZdBIEZkQv5nWdTKvyEAqsjayWq1Kd7rpXHXKQDcThelV7yb2z95ejwyxvi9vi69zdtKn NcmPcAYb7cLUrLRuJGcRNpFEftPC8i0ns89mBgbdkvU3e//PMkLu5xDTAy/G+atl+HCLBxJTZQ OBSBeN1EPRKpmrdsay0GzNgHetxaoxxM3Zd+YzxRR5s6dEJjpng5IJe3u9TXXNEuvK7umYO3i2 uvw= X-SBRS: 5.2 X-MesageID: 40353357 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:I4Zba69Gj6VTKk18Y2puk+EKdb1zdoIgy1knxilNYDRIb82VkN 2vlvwH1RnyzA0cQm0khMroAsS9aFnXnKQU3aA6O7C+UA76/Fa5NY0K1/qH/xTMOQ3bstRc26 BpbrRkBLTLZ2RSoM7m7GCDfOoI78KA9MmT69v261dIYUVUZ7p77wF/Yzzrd3FeYAVdH5I2GN 69y6N81lmdUE8aZMi6GXUJNtKrz7H2vanrfAIcAFof4BSO5AnC1JfBDxOa0h0COgk/o4sKzG 6tqW3Ez5Tmid6X4Fv212jf75NZ8eGRt+drNYi3peU+bhnpggasTox9V7OFpyBdmpDS1H8a1O Pijj1lE8Nv627AXmzdm2qT5yDQlAwAxlWn6ViEjWDtqcb0LQhKdfZptMZiXTbyr28D1esMt5 5j7iaimLd8SS7kpmDb4ePFUhl7/3DE2kYKoKoooFF0FbcFZKQ5l/14wGplVK0uMQjd844dHO xnHKjnlYxrWGLfVXzfs2V1qebcJ0gbL1ODSkgGjMSfzyJbqnB/11cZ38wShB47heoAd6U= X-IronPort-AV: E=Sophos;i="5.81,288,1610427600"; d="scan'208";a="40353357" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GC5TN5RyWh0EdKtnAkdAmohEwPTT447jznpOHCRpBLjb9xaxrgpCp8DAV9N7LYcS/Z0Nn0Vzb2/Wes1XK2+2lSMP5D5JSWbFdqCi4pmdOwLH0AAAU5HP8yTuwLwv39gJDA2NezqkO2DZB6GvRhjowUVdg6CSb8StJx8bg4YvwihMD+IfORXVuUakH6BSySBp8AXx431iKOtyWGLQeKv9Q/JuQfQkOwYjz+92Ag6pUwpr3Om6ry1D1qhvzCWJaiHuF28E17U7Nqs9jdfvJuBcfXfWvNEjg2tE6RQSDNXE6Mgm3YprrUousnEgIqk0+WHDxX+24Yk+fPZZhdeChus46g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kaI4ifJcGWIHAzTW+OAFbcQycLKrEC6x66SMaOzAg4o=; b=HJzuBCn+bfwLNQ31TxLAIx0I33SncYYLPCMbE7B/G+cn7zgJJlJmYe0FjqIwxZrJfXz6ajINjez4vaKunGeZZ8+qI+QiTXsMcOvRKx35RFMHzY/Qt5lcRxSv2i4XpiO/WMfWsMeRitgS5Qr5QVV3jw+sirmxICx2vFcTJOQDq4m4g13Go1mHW27wM5AKU2cHJoRgs9eQhGUBoHBPeUzV0SFZzeCoQ1uWsYz07RocKcbuwXO2f0ojdyZk8jRqr0q1R6zU6rC7zz68DstuGj//FxLk0o7Qc1mYPJYDk8TGVKbL43kDZABN/oeB57OzNZN2TjlkbAwww+y/uYmowr5QhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kaI4ifJcGWIHAzTW+OAFbcQycLKrEC6x66SMaOzAg4o=; b=hmducad3rh9W6kpkknzMLx+r9ZH9mAi7ugx4m2hw9t6+KT1PnZrPT6iRWHXZM4+zHkkoFw6UkF7YhafyDvNOy2LqgNIHQBVw4+gmbP1TkiU6oOpadGPg1LRAZkdjZPgWvsMinjidHNXEQ7zae+VwhLwYIAhXjmb8p+Bc2eN2dRk= Subject: Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code To: Jan Beulich , George Dunlap CC: Ian Jackson , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <20210324172608.302316-1-george.dunlap@citrix.com> <23461afc-c0e0-eb33-9ed3-52f050b6aef0@suse.com> From: Andrew Cooper Message-ID: <27ecde00-f0aa-b701-6928-5480ed805064@citrix.com> Date: Mon, 29 Mar 2021 18:26:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <23461afc-c0e0-eb33-9ed3-52f050b6aef0@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LNXP123CA0006.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::18) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e777b45-cc9b-45df-e209-08d8f2d7da90 X-MS-TrafficTypeDiagnostic: BN3PR03MB2129: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D8gJ99OeKf9Zk67EXOOFKJ7vFZMpOxi5PlWlJNLezdoXUZtCdmyjvlTGZcwPhplP520CiFPJXN7Fv9uuLPlamwHLSOAhoq32USVZJG/poHmdUIddI4OYBpI199kkrmGsEiIGueY9ECDtcsYd25620YRcg3kzGC9yqFfmA1pwWwEZslLqqrskqKzTSQm8n3XCRVKGyMSyvYPXEctDJEXkt46yZElbLP/brEZBiRoZ+QQUQGlp66h+LxJMqn49WKErJskIYd6GupEoPoVpLRua4F3vpeZYXM89lw3j3FL6Ge7culdL8slWDDs7hmdLFtp4NbGdMIpKSdX/AFnj0d2Z2hKIAuXDRsSPiZniaX8zfTKZtaY9y8P61Z8z9X8WdjbJCDsCTBe3EF10IzdSZatXUl45uteAt5ZSyoBPc/SiJKdii5ctOJ2hZpZMewnvz+Y8P3yhRrxnJ2OOSS1X1ssGsJaf0cniGeBUYXTNs3daR65+G3CJME147R6XR8gV+w4H3SDtWU1u1rj19rOBBaRO+A5Suw4sMjp3FuOrBZycD5sSjm01ajk6PQ0g8n5a8FFEC6+JkKCWNY5CaKki8t+AhFV2T60cMrxlqMrFNLHEp20o8B51ljmt1AcAmpp8x0iTQ300H/JrbxwtKTsNeRGgZDl01ncStU0RbvKNx93f5AIowOUKA8DR36njhJvAfyj7CTeY9v653n7v2hadFH7EbgYZpGGXUzpxxqup6M7wy6K0fWgGsJtlsHiSsnLgPJ6fhwoc4JMYA0H/zLptF37LCxMQCbhlSpjsgjrIAZIDXnLpl7vcFmKpmdhZ00wli9qaLjUdTDe9bQU5p5yB1aFJYtEnrYRdGXFsXsHGj2PjKoc3rXeMK7+93alm2ruvjFk/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(136003)(39860400002)(376002)(346002)(2906002)(26005)(53546011)(4326008)(6666004)(186003)(2616005)(36756003)(956004)(8676002)(16576012)(31696002)(6486002)(316002)(86362001)(16526019)(8936002)(110136005)(478600001)(54906003)(66946007)(66556008)(31686004)(6636002)(38100700001)(66476007)(5660300002)(59356011)(219803003)(207903002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?RHF3Zlc4ZWZLRGZzZVRZWjJNUjZya0l2aU8wd3RtVXZVL05CMFRzbjlJZjk1?= =?utf-8?B?MDZrMldBVStKeHR2TGtNMWJIOGl1OFlvT1ZvcHBEWWRoYllTSVlkdEFqVzBE?= =?utf-8?B?Q3BSQVcwTGdINHRDRnltcnhuL3NieVp2L0N3Z0gyRVBSdWxDV2JjbC9JZ2Jp?= =?utf-8?B?UFU3UmZIcUQ3a0tYSE8rY1RQWmowTmw4VG9TdEhXRFkwS2g2YnpFUzVaZE83?= =?utf-8?B?Y1dldjlDcjYwZ1p5Z3c5dHFOV2N2bGdpVm9DQnhGTTdndWdkZFhJZWlmZlFF?= =?utf-8?B?WFZPYzVqcWY3MFZGOThqL09ZdWlkWnJJRG9MWXNvUXhMdjJ6QXluZ2pPZW1u?= =?utf-8?B?TVJza2FIUEJ4c2pSVlRyaUJXV2tCcGhQMDVDNWVmckprMnd4Nk96cW15ak84?= =?utf-8?B?cENRdmErL3VFcHY5RmRFbTFOMXRlSUcrd3J1eUNpOG9YSzJzcnI5OW93ajRM?= =?utf-8?B?TzZVaWNxWGxHdzloSCtJYkR3Tlo0SGFwNEdSckVRQXRpd3V4QkNac3ovQ3JG?= =?utf-8?B?S0hZYXJ0T2g0Wk5YZHpQREthbWgyTnVvbDBTdkFFN0k1YWRnR0xnOURodmlv?= =?utf-8?B?aWczcUdqaEN4NHVyK2c1bWJQTmQrbnVIamwxbFBZaHh0YW9sQnRaV3Y2aVZr?= =?utf-8?B?RERkd3orek1HVmdkREJsL0Y2ajVzVUhUb0dvSEFOK0xiRWlZaWsyRkE2blV0?= =?utf-8?B?bHBDemtFN1BNUGZuTkgrT3pQamgrdHNib1plMkJVRXYvNjZqWWhhKzdhdzcv?= =?utf-8?B?Y25pWERpbUVvMUxsQ2JVYzcxRzhYOWJUbTdJNzRMMWdWcksxSFZtamN4K2Jt?= =?utf-8?B?QjFnR01jbDNvOVV1ZG8rdlloQVJvV2t2Smo4RTdUQ1NhVGtULytxaFlZMHJX?= =?utf-8?B?T01rSFBiQjllSjljc1NHQ3NwaGZuTG5SeVFGWUtKR3JDQ1hxODRCUW1IaTFt?= =?utf-8?B?emh4NjMzTVZFVm9Nc1BsTzZWZ2JxdWZmTWJleW9xaVMzRVhLNXM0VmpuNFFr?= =?utf-8?B?QlFzS1Y1WjlobWk0WUQ3SENUT0hoMDNWYjUyaGFoQThJbUpqSlZVdWV4N1hn?= =?utf-8?B?V1JoQ1lhSTFmbHdibHlEcXMxNVJQeGdicXdEMG4yOU5TTDhqVzR4dHVwNTJM?= =?utf-8?B?TWVtVUE5SUpnUWtNSkNpdDFKOTVzUGZsd2xaV3JzaWZHQ28xL3pWdlNJcXpM?= =?utf-8?B?STlkdHhYQTNzUHRmWVIwdXUxNUt5N0duQmttSlVyL2h1aHJYR001dlZIYVpu?= =?utf-8?B?VDVYNnpxSDhYMVQrWk4zckdsQWNCK21USkpQQ2ErUFVGVVpxakxyZEhUSVlj?= =?utf-8?B?UDhMYnhRVkhxdSt6bXB4bmlTbTllTjROek9vajR1MTdpSU1ybmlJc0JPS1dS?= =?utf-8?B?VHNIVE5yTDB4enNrbnJhZEZVWXRFSEpIbDlsYVBsOTBVejBEWHQweXp6V2J3?= =?utf-8?B?K2hrWGVQYU11WWZkVCtCM2dpazNuRWRkYTdlTFZaZmtmWTMvV2NsMHdkam5V?= =?utf-8?B?STlVWW9uWnJMTGExdTZac3VTN3V5V1l2MG85WXBWck84bWMwTzZOVzNUaHlN?= =?utf-8?B?UFJCMkZ4VzRxN0w2bDBjZzltYUh2cFFIYlNadkllM29kUmRWV0l6bU9mSkdO?= =?utf-8?B?eXlEK24yeEs4eExIUGRRNUMrSUErUWtwdW5jUXA3SWJGZlNuZGtkcHVvWVY1?= =?utf-8?B?bGNkMzZjemwvejh1YkpDZmU4cjhZTXRyczhoWkFlMXYxbDNrMkVzendFZVdN?= =?utf-8?Q?OUAhIBmF74juOcGlyjPgaTBBSfAQtwM9/6QJs3p?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6e777b45-cc9b-45df-e209-08d8f2d7da90 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 17:26:57.4762 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iUpCdcc46yT3wjuwmr9uIvvMly1wTcMPIhoOJzfhxas9Cib3HJdbuUkKSFWdGt28L8KLAf0CBoK2sc3/Hv116d0mvrizGuoPGp57ov2a2D0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2129 X-OriginatorOrg: citrix.com On 29/03/2021 17:23, Jan Beulich wrote: > On 29.03.2021 18:12, George Dunlap wrote: >>> On Mar 25, 2021, at 7:08 AM, Jan Beulich wrote: >>> On 24.03.2021 18:26, George Dunlap wrote: >>>> Signed-off-by: George Dunlap >>>> --- >>>> Missed one from my list when creating the other series >>>> >>>> CC: Ian Jackson >>>> CC: Jan Beulich >>>> CC: Roger Pau Monne >>>> --- >>>> CHANGELOG.md | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/CHANGELOG.md b/CHANGELOG.md >>>> index 15a22d6bde..49832ae017 100644 >>>> --- a/CHANGELOG.md >>>> +++ b/CHANGELOG.md >>>> @@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>>> - x86_emulate: Expanded testing for several instruction classes >>>> - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 >>>> - CI loop: Add dom0less aarch64 smoke test >>>> + - Factored out HVM-specific shadow code, allowing PV shim to be slimmer >>> But shadow code doesn't get included by default in shim-exclusive >>> builds (and others are unlikely to disable HVM). >> Can you propose some better text please? > Does this need mentioning here in the first place? I would recommend not. We've been doing incremental improvements for the shim for several releases now, and in this case, we're literally talking a few kb of code.  As we already align to 2M boundaries for superpage reasons, there almost certainly isn't actually a reduction in runtime size. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Mar 29 18:40:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 18:40:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103221.196971 (Exim 4.92) (envelope-from ) id 1lQwnt-0006H1-Pz; Mon, 29 Mar 2021 18:39:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103221.196971; Mon, 29 Mar 2021 18:39:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQwnt-0006Gu-N3; Mon, 29 Mar 2021 18:39:57 +0000 Received: by outflank-mailman (input) for mailman id 103221; Mon, 29 Mar 2021 17:44:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQvwB-00012R-Bn for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 17:44:27 +0000 Received: from aserp2130.oracle.com (unknown [141.146.126.79]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 766603ff-70fb-4de9-9459-cb31296f9047; Mon, 29 Mar 2021 17:44:26 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12THexoj038154; Mon, 29 Mar 2021 17:44:24 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 37ht7bch1j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Mar 2021 17:44:23 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12THfPYi152457; Mon, 29 Mar 2021 17:44:23 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173]) by userp3030.oracle.com with ESMTP id 37jemw1t5f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Mar 2021 17:44:22 +0000 Received: from BYAPR10MB2823.namprd10.prod.outlook.com (2603:10b6:a03:87::15) by BY5PR10MB3908.namprd10.prod.outlook.com (2603:10b6:a03:1b0::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.33; Mon, 29 Mar 2021 17:44:20 +0000 Received: from BYAPR10MB2823.namprd10.prod.outlook.com ([fe80::e83b:92af:c9d7:2fe9]) by BYAPR10MB2823.namprd10.prod.outlook.com ([fe80::e83b:92af:c9d7:2fe9%7]) with mapi id 15.20.3977.033; Mon, 29 Mar 2021 17:44:20 +0000 Received: from localhost (2606:b400:8301:1041::12) by MWHPR01CA0046.prod.exchangelabs.com (2603:10b6:300:101::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24 via Frontend Transport; Mon, 29 Mar 2021 17:44:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 766603ff-70fb-4de9-9459-cb31296f9047 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=PtXV0/bToqyou5eFX7zCGcIeiZT1aBWAi2oubKwRKUw=; b=GUQNx6el+xelnBEIMQ6B5IoKnXXEXl4RrNNrDRo/LR4RDjiZ1021vLYnODNvINR8jqfh bgSZEfK+92gczYNqGl39rE38UUchci/1Y0PF+uP0Fbjz3r4x3+XvKaxIe/powI+k1nTV CZbewIhjvZfbh87wt3j1Ifm7cAwpvLBuboTOUR/xpDkdCZXagLzPXbQMJQ/Tt77jMOnN ahSZ/duz9R5XaubRrzrFrK7lSXdeCyw0Jf6U/irNiF1JZ7ZMDXhNtjn16aEw7q2vcgWK 3IbAGtDHzG6TRV6HhuSCYAinGo0Qtvvbo1HhjMl5Xh2zK8u1T19tNzkGKHZdgMHUTe2X wQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ET2cpyscQnbGrM8euLPXDev2xhsqLIGBei891D5b8Wlfud88L34bjDgWiAuy3LkiB0qUY188ORA0PbdIbJQ8yBwysQHfzexpANDIsZNT8idXqlqsLJcw5G1YviI2GgeqONkbJGQ0hGheO09sVapawrgPBKpA+n0U/EujgRik9ofMqOvi8lhV4r5dO33D90+lIn4pWO4wGzMR4+fPZutC+zc6icL8ixOAZsEsjPwZp4xq0uCE0g7r2ifmzn1lKz6vOZDpZJQI3lsKFLRkGlnCVZdYX9+gyreoI8peYJmaYEJa9zjI62+DgZdjrWFJn9Yu+apPm+m+K3ioug9AWXQ6Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PtXV0/bToqyou5eFX7zCGcIeiZT1aBWAi2oubKwRKUw=; b=HRa0oT7KZ4u1JBqVnkqVOQxoAyZkIHO66PJ/1GLaED24RgEmx1A1hjy2+v6WeL8kkX12dL0aNjwqOJdOOy7p3FYhP2rx7JKsdlFn6i08wCxUQRkmGHkgLK7ayMOdyG4Zq7IwKbwRUPTSCcnx62OhDuwtjIf4MaUTxskXkuKGYQfGOK8j1RCq67t33a4gvITmQxxqtBgP5grs2W26H58GxPJiApMfxVMQ40f10iOrytb9lFnZJYwdE//h3mhxa6BqgGZIyiY/PAs+/ecVOuiTYgiKLudgpIkEHP8eNW7mZar6+XVhN6A5gnZtvW2CtpmaW/BtJgRQVgKE874/YqPOnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PtXV0/bToqyou5eFX7zCGcIeiZT1aBWAi2oubKwRKUw=; b=Ey7BPQn4EF7U2fnNPmN0QP1kO1ZPijxJBeG0sPmPy+J5ijKP+IYMz7aAmFFf4gzb4QbuOZCnHahYyXg6/jmVunn68eMfNj/CQhMWYvt6NyLOwVXJ1EW310xrfy1wwOzUe56Y40EZYdGqKieYTq2moqy+i7UVsZJuO0sASJsN5q8= From: Stephen Brennan To: Boris Ostrovsky , xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, boris.ostrovsky@oracle.com, iwj@xenproject.org Subject: Re: [PATCH v2] x86/vpt: Do not take pt_migrate rwlock in some cases In-Reply-To: <1616809866-30837-1-git-send-email-boris.ostrovsky@oracle.com> References: <1616809866-30837-1-git-send-email-boris.ostrovsky@oracle.com> Date: Mon, 29 Mar 2021 10:44:17 -0700 Message-ID: <87h7ktetxq.fsf@stepbren-lnx.us.oracle.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [2606:b400:8301:1041::12] X-ClientProxiedBy: MWHPR01CA0046.prod.exchangelabs.com (2603:10b6:300:101::32) To BYAPR10MB2823.namprd10.prod.outlook.com (2603:10b6:a03:87::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 93595c72-5d6b-4486-cdfe-08d8f2da4882 X-MS-TrafficTypeDiagnostic: BY5PR10MB3908: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IpWjTxm4RnIhy6PoNvUZ25mg5aIFOacEaKs3aZyBcWdxlRiHCWt4qmyZ/m9SV5kes7KeSSNmZU33gaxpo4z9oaFBiBAJcSndG2VTUQRHWvsnd+zr6ZMWozYBy45w27E7N2Kj+e41m435q3LyHi9oa8pJ/RMWAelWPuCNx/XKS4imo0DKN5tqo15i/ToZebTlyfvocjzMVgScbb9sncijjyI4zlEz6VYpYEWpDBh9B6JuMxbNYKa7vzl/cviAlgGrFQobkDhGGT3Cpl/zQ7UvaR9QjmRlTKLJ1tms8Zm/VNiW/CmOVmfxdi1Ueik2jTqhRwthPGcdD8DNtHmylCUHwSnD+DDYcmfHqDwRxpFkWrnB3NALxLa+Djsfne8CIJldvdbf+xGb9FNWw+y93IqLR9ajl6p7Q/hCEkKCcRMq+woHElWBKJ9hpBUXFb0Z+zmn4HH+ir3EBi1GAWwsCm/P4sErrldrbZd+UfdzkCgR+xfngYnwzvPOFMcq3KdvZTK+ymOmdlSlZZTLQF+uRVmdkaQzcUqf2sI5AgiRSwvQzW4MZMoZrRT0hKRYUfFZkmEtReuudjhePne6iQR7aesXOEt70CtT6HqcJAE6Oq/29gmCz/e9Gp+M4fHKvv0nbNWKIDulpCILHawkunt6XH0YZg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2823.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(346002)(396003)(366004)(39860400002)(86362001)(6486002)(4326008)(6666004)(38100700001)(6496006)(66556008)(66946007)(66476007)(316002)(8676002)(8936002)(5660300002)(83380400001)(16526019)(478600001)(52116002)(186003)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZGZNem14N2I0QUtaMDd0L2JUQVhpbUU2RlFhR25STlhhSGFuS3hpeVpEelNC?= =?utf-8?B?QTlvLzFpL1Zjc3R6N1FBVk42Y1ovb2NVcU5ZRnFydlQ2ZHplK3ovVzVuSm91?= =?utf-8?B?ajhnN3c3WVoxTkVhWk10Z0QrRFZPZU1SbTlHWHJKLy96dXR5d2tKL2F2MllY?= =?utf-8?B?YmkwUDVGUE4zNTViWFg5TFlsbDlHL3VHNWI4VXhabGJrMlgrWmlaQVhkVGh4?= =?utf-8?B?OU9HcGxrRE9uWVNuUGs3QS9ucUswVXhzejd0eStLbEFaYVRlV2x5SWlhazRh?= =?utf-8?B?NGtoQmRkYUdZSW1MYUMrc0pJYjcyWEJ3UkNSMHFkaXBaRXI1SzBGTXZ3OC9D?= =?utf-8?B?ZVRUbU5ScDBSREVJaVVFRmtaWXhuQnRMOTdPdVlhaVN0Z3lrKyttQ0FSbHZ0?= =?utf-8?B?L3Bta3lqMXQ1ZzB3SGtPUTdOR3g0YVNsTCtiM1ZJMCtKMlE4VlRaMEtMclBJ?= =?utf-8?B?blVYN2FPUkZhbWFnMWpoSWhIUStlTE1kR0l6L0x3OXI4S0RMeXcycUFwMDN1?= =?utf-8?B?aHBJd3ZaVnZyYUpVbXdlQ2dXTVpkSFNFdHZDM1RUenpwcHZzWVNqR0hHbExH?= =?utf-8?B?bXNrSzFzMksyT1Nidklmeis4bi9zUWJvQlFHLzkwb2kyMVhyUTVhSGptMXAx?= =?utf-8?B?SWtJenltS3JmMDRmS25rYU9oTTA0K1NWVHphYTNoYzJjTlV5WXA2M0NrN0tC?= =?utf-8?B?WDN4NkNDLy9YNHpHT2I5Ry9vQXl3dksrN3J6ZGZJbXlMZ2w2dE56MXVaRVJ1?= =?utf-8?B?ME9VTlhLWFFLdlJheHh2MHFjMVcxYlNIQ3EwdXlBQ2JFL2ZYMmZ3c1VEc0N4?= =?utf-8?B?RUxFMWd5U0U5MGxzeEZMdWVlRHJnWmMvanlQdUtta05NRmE0bFRxeFRqSHJK?= =?utf-8?B?M1VLV2o0L1NuMy9pci93Y0NPdFpIWTN6ZTdvN3NzZVpObWpUcXRnQXp6TDY2?= =?utf-8?B?bndJc2wzTjUyOW96cS9DUkVCN2UvaXljaUN4TkNYN1dER3hObzBGRDlZVTZN?= =?utf-8?B?QkRsQ3V3OHZLbkd6SDMvREhlekNmdFdTVm84T0ExVFh6eVpxbitiNWNzOWdZ?= =?utf-8?B?ZFordmVKT0luZ0NWTDJKNGNJK2FVN1EwRzNFcGdHYkxUMmxtYVFNakxZNGxG?= =?utf-8?B?ZFliMG0vSTZwM202UFJwY09oL24rK3UrYVhNYTlqUkpEdDkrK3R4QlEwMU5Q?= =?utf-8?B?dXMwaDZvOCtyM2NnRVVxcGdmQ1hlazQ4cVQ4ZGIwQTJQbXA1Umg3elA5R3ky?= =?utf-8?B?QXN3Z25jeE94eElrdEhjazRqZXRxRmY0dFA1V1VFS2hOSjRkWHNLQW14VFc2?= =?utf-8?B?TmZnQUhxQUF1TFZGQkxFektiS3I3Y1UxcFlBNEJFeEt4eWRuWHFmbzZvOTlh?= =?utf-8?B?QlZGRmJ5bVg0Uk0veVcxYmxuQ3lBbm9DQUZ4ZnQ2YnJVWEVYSDlvWnBOMWY5?= =?utf-8?B?S29CNmRMNkd0djZBSElBTjZ3SjlPVVRaYVVyMlN1aHZxektDWG1yMkgzbVY1?= =?utf-8?B?QVdteUNmaE9hR2g2dHN5elQ0ZmdPV0lEMENBVVdVM2EyeFdjZTh0KzNONjkx?= =?utf-8?B?d29GZWpjaEZiSWJwcmlRRHUzVmlPSUZNNGdXaUo3UG54eisvRllNVGwwb3Nt?= =?utf-8?B?d3NScTA0UWN3ZDJOUTA0TVE0dWZNQ1pQOVhqek9ueDNZMHRFckdGWFNONEJQ?= =?utf-8?B?eXd2dzN3ZktNUXBqaVJkRDBqcG5VWDlNVWFlS1NUR0pPN09iTEhrQUlJY2ZU?= =?utf-8?B?cGVBTi95ZkxTZDNub3pNOGxJMk0wY1FVY0t6WDd0ZmVWbzFyRFFDbWp0QzN1?= =?utf-8?B?Vm1UdGpXbGR3TkZIeGJjQT09?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93595c72-5d6b-4486-cdfe-08d8f2da4882 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2823.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 17:44:20.7588 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rHrFudbDevfpiQCK4Lb3pSrDbQGZGcTxISHFI9dbzkF9n/h0DKtYx6MxyJmu/aJEP8XVuw7sUCZrPwHL+JqAkvsFYNK2cQNrKzHCo9CtLmA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3908 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9938 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 spamscore=0 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103290131 X-Proofpoint-GUID: JRQ1n_MvO_GFhI9td4bfIVyYDri2FVuS X-Proofpoint-ORIG-GUID: JRQ1n_MvO_GFhI9td4bfIVyYDri2FVuS X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9938 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 spamscore=0 clxscore=1011 mlxscore=0 bulkscore=0 priorityscore=1501 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103290131 Boris Ostrovsky writes: > Commit 8e76aef72820 ("x86/vpt: fix race when migrating timers between > vCPUs") addressed XSA-336 by introducing a per-domain rwlock that was > intended to protect periodic timer during VCPU migration. Since such > migration is an infrequent event no performance impact was expected. > > Unfortunately this turned out not to be the case: on a fairly large > guest (92 VCPUs) we've observed as much as 40% TPCC performance > regression with some guest kernels. Further investigation pointed to > pt_migrate read lock taken in pt_update_irq() as the largest contributor > to this regression. With large number of VCPUs and large number of VMEXIT= s > (from where pt_update_irq() is always called) the update of an atomic in > read_lock() is thought to be the main cause. > > Stephen Brennan analyzed locking pattern and classified lock users as > follows: > > 1. Functions which read (maybe write) all periodic_time instances > attached to a particular vCPU. These are functions which use pt_vcpu_lock= () > after the commit, such as pt_restore_timer(), pt_save_timer(), etc. I think "the commit" is now a bit ambiguous, it was intended to refer to 8e76aef72820, the fix for XSA-336. Maybe it would be easier to simply drop the phrase "after the commit" since we're discussing the state of the code prior to this patch. > 2. Functions which want to modify a particular periodic_time object. > These guys lock whichever vCPU the periodic_time is attached to, but > since the vCPU could be modified without holding any lock, they are > vulnerable to the bug. Functions in this group use pt_lock(), such as s/the bug/XSA-336/ may make more sense in this context? Just to distinguish from the performance issue. Code changes look good. Reviewed-by: Stephen Brennan > pt_timer_fn() or destroy_periodic_time(). > 3. Functions which not only want to modify the periodic_time, but also > would like to modify the =3Dvcpu=3D fields. These are create_periodic_tim= e() > or pt_adjust_vcpu(). They create the locking imbalance bug for group 2, > but we can't simply hold 2 vcpu locks due to the deadlock risk. > > Roger Monn=C3=A9 then pointed out that group 1 functions don't really nee= d > to hold the pt_migrate rwlock and that group 3 should be hardened by > holding appropriate vcpu's tm_lock when adding or deleting a timer > from its list. > > Suggested-by: Stephen Brennan > Suggested-by: Roger Pau Monne > Signed-off-by: Boris Ostrovsky > --- > v2: Drop per-periodic_time spinlock and keep pt_migrate rwlock (and thus > change patch subject) > > xen/arch/x86/hvm/vpt.c | 40 +++++++++++++++++++++++++++++++------= --- > xen/include/asm-x86/hvm/vpt.h | 8 ++++---- > 2 files changed, 35 insertions(+), 13 deletions(-) > > diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c > index 4c2afe2e9154..893641f20e1c 100644 > --- a/xen/arch/x86/hvm/vpt.c > +++ b/xen/arch/x86/hvm/vpt.c > @@ -153,32 +153,43 @@ static int pt_irq_masked(struct periodic_time *pt) > return 1; > } > =20 > +/* > + * Functions which read (maybe write) all periodic_time instances > + * attached to a particular vCPU use these locking helpers. > + * > + * Such users are explicitly forbidden from changing the value of the > + * pt->vcpu field, because another thread holding the pt_migrate lock > + * may already be spinning waiting for your vcpu lock. > + */ > static void pt_vcpu_lock(struct vcpu *v) > { > - read_lock(&v->domain->arch.hvm.pl_time->pt_migrate); > spin_lock(&v->arch.hvm.tm_lock); > } > =20 > static void pt_vcpu_unlock(struct vcpu *v) > { > spin_unlock(&v->arch.hvm.tm_lock); > - read_unlock(&v->domain->arch.hvm.pl_time->pt_migrate); > } > =20 > +/* > + * Functions which want to modify a particular periodic_time object > + * use these locking helpers. > + * > + * These users lock whichever vCPU the periodic_time is attached to, > + * but since the vCPU could be modified without holding any lock, they > + * need to take an additional lock that protects against pt->vcpu > + * changing. > + */ > static void pt_lock(struct periodic_time *pt) > { > - /* > - * We cannot use pt_vcpu_lock here, because we need to acquire the > - * per-domain lock first and then (re-)fetch the value of pt->vcpu, = or > - * else we might be using a stale value of pt->vcpu. > - */ > read_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); > spin_lock(&pt->vcpu->arch.hvm.tm_lock); > } > =20 > static void pt_unlock(struct periodic_time *pt) > { > - pt_vcpu_unlock(pt->vcpu); > + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); > + read_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); > } > =20 > static void pt_process_missed_ticks(struct periodic_time *pt) > @@ -543,8 +554,10 @@ void create_periodic_time( > pt->cb =3D cb; > pt->priv =3D data; > =20 > + pt_vcpu_lock(pt->vcpu); > pt->on_list =3D 1; > list_add(&pt->list, &v->arch.hvm.tm_list); > + pt_vcpu_unlock(pt->vcpu); > =20 > init_timer(&pt->timer, pt_timer_fn, pt, v->processor); > set_timer(&pt->timer, pt->scheduled); > @@ -580,13 +593,22 @@ static void pt_adjust_vcpu(struct periodic_time *pt= , struct vcpu *v) > return; > =20 > write_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); > + > + pt_vcpu_lock(pt->vcpu); > + if ( pt->on_list ) > + list_del(&pt->list); > + pt_vcpu_unlock(pt->vcpu); > + > pt->vcpu =3D v; > + > + pt_vcpu_lock(pt->vcpu); > if ( pt->on_list ) > { > - list_del(&pt->list); > list_add(&pt->list, &v->arch.hvm.tm_list); > migrate_timer(&pt->timer, v->processor); > } > + pt_vcpu_unlock(pt->vcpu); > + > write_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); > } > =20 > diff --git a/xen/include/asm-x86/hvm/vpt.h b/xen/include/asm-x86/hvm/vpt.= h > index 39d26cbda496..f3c2a439630a 100644 > --- a/xen/include/asm-x86/hvm/vpt.h > +++ b/xen/include/asm-x86/hvm/vpt.h > @@ -129,10 +129,10 @@ struct pl_time { /* platform time */ > struct HPETState vhpet; > struct PMTState vpmt; > /* > - * rwlock to prevent periodic_time vCPU migration. Take the lock in = read > - * mode in order to prevent the vcpu field of periodic_time from cha= nging. > - * Lock must be taken in write mode when changes to the vcpu field a= re > - * performed, as it allows exclusive access to all the timers of a d= omain. > + * Functions which want to modify the vcpu field of the vpt need to > + * hold the global lock (pt_migrate) in write mode together with the > + * per-vcpu locks of the lists being modified. Note that two vcpu > + * locks cannot be held at the same time to avoid a deadlock. > */ > rwlock_t pt_migrate; > /* guest_time =3D Xen sys time + stime_offset */ > --=20 > 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 29 18:55:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 18:55:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103230.196983 (Exim 4.92) (envelope-from ) id 1lQx2R-0008Lo-7w; Mon, 29 Mar 2021 18:54:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103230.196983; Mon, 29 Mar 2021 18:54:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQx2R-0008Lh-4F; Mon, 29 Mar 2021 18:54:59 +0000 Received: by outflank-mailman (input) for mailman id 103230; Mon, 29 Mar 2021 18:54:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQx2P-0008Lc-27 for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 18:54:57 +0000 Received: from mail-ed1-x535.google.com (unknown [2a00:1450:4864:20::535]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8694785c-ea39-4eca-8079-7fd693ad22a3; Mon, 29 Mar 2021 18:54:56 +0000 (UTC) Received: by mail-ed1-x535.google.com with SMTP id h13so15375871eds.5 for ; Mon, 29 Mar 2021 11:54:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8694785c-ea39-4eca-8079-7fd693ad22a3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3QKxrTMNgufUy9T4qTbt2zx0FBa7195d7HDDgcLICbw=; b=KpR/zy6oCESXlkpAVgQEe2TeR8mT9Jbd1LxyWLrJjPbzvhUz5lilCG3f6QaGH37au2 pWvimOFUofEE4aw4WiiERVZmG75TIaejo+YAf8mxRe5mp2nIUfmIy+scUrKxzv8gq+IN HQwoht5bWbSlW8t6tLiOW6rEVkJoK2l2GWmm01eKb5RK0Dqgmb11AaNjO3D2YyIVz1pr gE85H1qaNAjO3j/+dKPHtO0qWJ+wZAjYvJYDYkAZBsWwQJa9l6g0B+klIHm6K0DfMnO7 AfVGG6LcZC053AYOq8+e0C1mBXePLk4bckMM/81UHl9hiBMj0/z7k0V5iWwfqAmAGYqR DXvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3QKxrTMNgufUy9T4qTbt2zx0FBa7195d7HDDgcLICbw=; b=QWsXEn2Yt5MMPwkVELbNTwxUY5IrKUi6ufXSmT8wVqmpIG37Hj18mwk4jIMZOLZY7B xsx3kfooy5UN53WA81pKKORN7g/z/x7KXnZboCUd3Df3/kFcCNV6Epu2uZyk7a+KXdt9 92ZkVh1IG/FfOQCXVNBvMpsDOSUL0WTWOcYDzIE6PnZ7fowwRM8AaYCgsdSZ/VS0NAK+ pGu75GJvKqMKjKHJL7hd57nEpJfD2SAk6Bzn5XpfrZ/TY+e2X5+cg8KExxVUhHH1Y7Mh eqr8K+IDJ3PBLeWWnlm56HfrqSVSh7j8kihg1E+XHeKqyqtG7ihv/dGFXgSOSk0e3QpL 8PNQ== X-Gm-Message-State: AOAM533oduaBdVRmuhAYQONH9Z3THaDe22MxdJbrT+dYNviBm+/LVHEs PWfGJh/mMTdMjHmwSiO57b4feJkRSPeHKnQjXXo= X-Google-Smtp-Source: ABdhPJwkDf2RWVJxIf6uJnWokW+UeBvmt8CNhrEjZskCl3cp1XG8jvXAqMGwITz+/jUXLaHVYJr4jL3KvX4aSRuQBLA= X-Received: by 2002:aa7:d503:: with SMTP id y3mr29501858edq.142.1617044095402; Mon, 29 Mar 2021 11:54:55 -0700 (PDT) MIME-Version: 1.0 References: <20210329161457.345360-1-george.dunlap@citrix.com> <20210329161457.345360-3-george.dunlap@citrix.com> In-Reply-To: <20210329161457.345360-3-george.dunlap@citrix.com> From: Julien Grall Date: Mon, 29 Mar 2021 19:54:44 +0100 Message-ID: Subject: Re: [PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support To: George Dunlap Cc: xen-devel , Jan Beulich , Ian Jackson , Andrew Cooper Content-Type: text/plain; charset="UTF-8" Hi George, On Mon, 29 Mar 2021 at 17:15, George Dunlap wrote: > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 8c89212f14..538eae611c 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - ARM SMMUv3 (Tech Preview) > - Intel Processor Trace support (Tech Preview) > - Named PCI devices for xl/libxl > + - Support for zstd-compressed dom0 and domU kernels Looking at the log, the feature looks x86 only (at least the dom0 part). Cheers, From xen-devel-bounces@lists.xenproject.org Mon Mar 29 19:02:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 19:02:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103233.196994 (Exim 4.92) (envelope-from ) id 1lQx9L-0000yA-Vy; Mon, 29 Mar 2021 19:02:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103233.196994; Mon, 29 Mar 2021 19:02:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQx9L-0000y3-Sr; Mon, 29 Mar 2021 19:02:07 +0000 Received: by outflank-mailman (input) for mailman id 103233; Mon, 29 Mar 2021 19:02:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQx9K-0000xu-S7; Mon, 29 Mar 2021 19:02:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQx9K-000416-JM; Mon, 29 Mar 2021 19:02:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQx9K-0008Vy-86; Mon, 29 Mar 2021 19:02:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQx9K-0004BT-7T; Mon, 29 Mar 2021 19:02:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Qcjda9Qu3zc5V6aT0ktprI9HT9XmM/rFEElTo90Fi8k=; b=tV2Cz762kZgVpt8BoxAifWJeN5 y6ANyNwQIvZSgm/4EocDyKWyKupWKx9ntEvfCq/auFOBsuVnQHNB6bRRVhLF6s7Ldg7aitUqpNdUV zRD1wssMoidhf11o//yzBDw3m/JL7UVsZf0tUfFWLP7PE5l3dS/Pqqc0NXSSZFR3doNo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160517: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e680cc48b7184d3489873d6776f84ba1fc238ced X-Osstest-Versions-That: xen=e680cc48b7184d3489873d6776f84ba1fc238ced From: osstest service owner Date: Mon, 29 Mar 2021 19:02:06 +0000 flight 160517 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160517/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 160492 pass in 160517 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 160492 pass in 160517 test-amd64-i386-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 160492 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160492 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160492 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160492 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160492 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160492 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160492 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160492 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160492 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160492 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160492 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160492 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen e680cc48b7184d3489873d6776f84ba1fc238ced baseline version: xen e680cc48b7184d3489873d6776f84ba1fc238ced Last test of basis 160517 2021-03-29 01:52:19 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Mar 29 19:18:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 19:18:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103248.197010 (Exim 4.92) (envelope-from ) id 1lQxPA-0002Fg-Gc; Mon, 29 Mar 2021 19:18:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103248.197010; Mon, 29 Mar 2021 19:18:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQxPA-0002FZ-DR; Mon, 29 Mar 2021 19:18:28 +0000 Received: by outflank-mailman (input) for mailman id 103248; Mon, 29 Mar 2021 19:18:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQxP9-0002FR-6e; Mon, 29 Mar 2021 19:18:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQxP8-0004Hq-Td; Mon, 29 Mar 2021 19:18:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQxP8-0000gO-MT; Mon, 29 Mar 2021 19:18:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lQxP8-0000tH-Jb; Mon, 29 Mar 2021 19:18:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PBQ/CdOUh90lqhu7e7A6POPhC8mIUhDwMVntX9qK96c=; b=HiO8N0CVvL5c3dwyvsISfko89R thhT/421B2mD6qd+pi8jray+WUPqh7Z0cUY6KThM97cwMzrfX211SiStB9gBZqhysKBCEkPxOBDDq q5zdcjsCqa0nZBbVo7dsndXoxvMpMZE0MYk+WBX9HB6TJGEXZD/Ljo3CQyQQulf4AK60=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160535: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=cead8c0d17462f3a1150b5657d3f4eaa88faf1cb X-Osstest-Versions-That: xen=e680cc48b7184d3489873d6776f84ba1fc238ced From: osstest service owner Date: Mon, 29 Mar 2021 19:18:26 +0000 flight 160535 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160535/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen cead8c0d17462f3a1150b5657d3f4eaa88faf1cb baseline version: xen e680cc48b7184d3489873d6776f84ba1fc238ced Last test of basis 160454 2021-03-26 20:00:28 Z 2 days Testing same since 160535 2021-03-29 17:01:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e680cc48b7..cead8c0d17 cead8c0d17462f3a1150b5657d3f4eaa88faf1cb -> smoke From xen-devel-bounces@lists.xenproject.org Mon Mar 29 19:42:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 19:42:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103254.197025 (Exim 4.92) (envelope-from ) id 1lQxlu-0005Kg-Ee; Mon, 29 Mar 2021 19:41:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103254.197025; Mon, 29 Mar 2021 19:41:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQxlu-0005KZ-A1; Mon, 29 Mar 2021 19:41:58 +0000 Received: by outflank-mailman (input) for mailman id 103254; Mon, 29 Mar 2021 19:41:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQxls-0005KU-VK for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 19:41:57 +0000 Received: from mail-ej1-x630.google.com (unknown [2a00:1450:4864:20::630]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c7439ef1-727f-4efa-823c-78dac536d8aa; Mon, 29 Mar 2021 19:41:56 +0000 (UTC) Received: by mail-ej1-x630.google.com with SMTP id hq27so21237890ejc.9 for ; Mon, 29 Mar 2021 12:41:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7439ef1-727f-4efa-823c-78dac536d8aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LNwciN1+aKLrfAajIeX8oyDJ4fRN7O1tEYVPKp96JTU=; b=JebqtA6n0mG+MR0mx55xMpdLlg48O7eh2STrYuDILb8Z8OYveDo/4LmB43bLCzO746 +5/8i7PfhJo8y66NoIqsdQZYLdwGUSERrZ30x+L7fQzHBE1L7X2B6VqjevHtDkF+WwAE NlUanZih8N+tOmHLPhFJ71R79cQ+pNY55VLwZRh6f1cz/Fp8hXEWQwSewCUMua8/YBIq fRgEyO5ps9QegstpWuKrQV8VBPJoecHBGlpVbLRoEe88VhOYxGZC3yDS1MkIkz9P+k2/ gGbQMAb2FasCkHgUoiuELj3+KYq9WoXylS60kRrgABmWX+WRCwrI+YAb9HpqxWlptQBq y5CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LNwciN1+aKLrfAajIeX8oyDJ4fRN7O1tEYVPKp96JTU=; b=mxc0r5ePaPt04Yp88I7C+wVsb++eA7ZzNAUMZQngkfjr2x9sqnJCNDrRh8Req0KQ0x wRujIKp+pa4R0rs/0hjMQhjMXV6KVh7rnevmFBTwbdayvb4SxnQ+CwLN66sJN3Nb738O TJTcT024/NznB0O1sfdGJw72oFoiyWh8CVxqyToqWKoMAUVap5Q/t6m1C7ErogD0p1yB Ut3PQCFQsY2AuT6Lq3yl8SwX1arcOE0rQ/S7z4dnc0jQe83777tx/TwMkfcQ8EG3Z1c6 C80DVJlps/DE2AoDI0618iVw+/Lk+9K9CC92t6JA385jYZsQ9AoU7moXwrlLQlfH52K7 QEjw== X-Gm-Message-State: AOAM531uoRxdtotdWGjkU3mDlW6W59wNl5P2q89FCXlyEFe2Pt2cJQom u3k5seP0W2a11gtZQfg5MyJudAf/9Et5uP8fjxsPoA== X-Google-Smtp-Source: ABdhPJxWJO2Uv9tI4iJCeNNkMldIGTiuNbrnyUesdunReGr7gRstV/EjgM3FksR6BGNwGI2LBvxiKhPDhEOH/IHjt9U= X-Received: by 2002:a17:906:c301:: with SMTP id s1mr29332463ejz.382.1617046915270; Mon, 29 Mar 2021 12:41:55 -0700 (PDT) MIME-Version: 1.0 References: <889B1827-1FEB-4AC0-9002-278337D19ED5@citrix.com> In-Reply-To: From: Peter Maydell Date: Mon, 29 Mar 2021 19:41:24 +0000 Message-ID: Subject: Re: An error due to installation that require binutils package To: John Simpson Cc: QEMU Developers , "open list:X86" , "gcc-help@gcc.gnu.org" , Community Manager , George Dunlap Content-Type: text/plain; charset="UTF-8" On Mon, 29 Mar 2021 at 20:20, John Simpson wrote: > > Hello, > > Kindly ask you to have a look at this bug. > Thank you for your replies. >> > On Sun, Mar 28, 2021 at 12:55:23PM +0300, John Simpson via Binutils wrote: >> > > BUILD pc-bios/optionrom/kvmvapic.img >> > > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) This is a known issue when trying to compile with newer binutils, fixed in QEMU commit bbd2d5a8120771, which will be in 5.2.1 and 6.0. thanks -- PMM From xen-devel-bounces@lists.xenproject.org Mon Mar 29 21:15:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 21:15:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103266.197056 (Exim 4.92) (envelope-from ) id 1lQzEN-0006Qe-UA; Mon, 29 Mar 2021 21:15:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103266.197056; Mon, 29 Mar 2021 21:15:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQzEN-0006QV-KK; Mon, 29 Mar 2021 21:15:27 +0000 Received: by outflank-mailman (input) for mailman id 103266; Mon, 29 Mar 2021 21:15:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQzEM-0006Pz-Ep for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 21:15:26 +0000 Received: from aserp2130.oracle.com (unknown [141.146.126.79]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 52edc7c8-c85b-45d3-ad43-76f9ab5ebb0b; Mon, 29 Mar 2021 21:15:25 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12TL8u09028614; Mon, 29 Mar 2021 21:15:23 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 37ht7bd4gm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Mar 2021 21:15:23 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12TLAkVo131526; Mon, 29 Mar 2021 21:15:22 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173]) by aserp3020.oracle.com with ESMTP id 37jekxp8rn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Mar 2021 21:15:22 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by SJ0PR10MB4416.namprd10.prod.outlook.com (2603:10b6:a03:2ae::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Mon, 29 Mar 2021 21:15:18 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.033; Mon, 29 Mar 2021 21:15:17 +0000 Received: from bostrovs-us.us.oracle.com (209.17.40.37) by MW4PR04CA0095.namprd04.prod.outlook.com (2603:10b6:303:83::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.32 via Frontend Transport; Mon, 29 Mar 2021 21:15:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52edc7c8-c85b-45d3-ad43-76f9ab5ebb0b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=g3s/RCDGEyaC3QTwLUFnQb6XJRasTN8+0afNbC6QMlw=; b=NVJxLNnGB77N0yexChq0RsBgXUSbhYqB5mBCvsX2EZddh1ySMdlX9NoAydmtzHhpY/j2 Ck0gkdSAUL552tJbrbMhQFG6vC+twGyPzq8PSft8Aha5NYLgAp82I2gZ3jcVnlPYY+YY BJn1Z48sjnmQtJh5H5TuCkCjgCrQpoE+8d9TX2zyETVMwhNON0FbNW6C5iJo2EjllGzV jEVgVyR9OawIFzRW7M2wMJZGYxHTWOMl1kSdw7jYBxhZfkFJpFoiSCDgqgM4FOIuRmqr vR2OSWtEYJ0vSysh+MNfAUW3IhbxowCRx8q3+hh9Zq3raglH+dUr+JRDnmlRsUIIfoPh ng== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WpH9daAzIyM1kOKFsvOJPb7DVkBg311L0Z4U7Yz3EthzRqyQw79hL8ihyr+WJq6gJCNTISToI6jPIsD3d1ASvxoBE8vnPMT0KWhrEKH8zmd+5ZS12DcaeSNCdkOLSYgBZzMVQ6n1GDyawkWlLvxsYRJIKZrayL9jJBzneqvq60pHjZTj0Gl/QcTq4LtUVjDv5URmolhLPFnbHDSSVniuU+TfEGstX2NG5eYYYqPi4Spt9k1rzQcbRHm/qdVPxAPgRbhMtEgOaMHkReSIwNAm0B+GDK1Kk1mODKvJkwAt0hEViV9d8K3G11pF5GwwA/jL1WpQRx/rgTp5M1j2NsElWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g3s/RCDGEyaC3QTwLUFnQb6XJRasTN8+0afNbC6QMlw=; b=gU4ST/B5e4QQYTJD7vtz0Qq8x612XcXMv63aXFpMn1aKuunBpVNZV32YnWFNmYSgf+pvHhF1s5bQ7X+XYCW6ggLs1+Kp09rOZ6i15uBOA2xQVQsLa5nkr4AY4EPz/ilMpMOj/X9gzg/cZ+OUF5REI4sLeLU3G9jn1OrxrXgyxHlbUCyYmRbjkIobc/sWJx1uR0AaS8kGNvd1PwYsVLVn1pXRZr4w3GG0KT1xxWSj184P5Wi+pKnlRuvsut4QuESm64tTbN1zBEvUJCsQJM4+ZPtPjWQrmW3SF4Lm/xI2a/FpRl5gRIbvkCKJePfPzuD5QOO8k1m3xgfXGjxbTU7pUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g3s/RCDGEyaC3QTwLUFnQb6XJRasTN8+0afNbC6QMlw=; b=hEYpmcFeRdvenpVVcAEHkUZMzrb9oQ1FA5SbbCa2OgbJYvZYT2TqdDtjWAYy9tA74JU6qaMpCq72o8D3Ko0jQIlZ1hk7LsFTbU9LhxMw2GV+qxqw2WjEKmQ8OuuJH+f/rk2b1isJnfX7895favJpFNlZ/dnISG0TU7NBX+tDE5A= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; From: Boris Ostrovsky To: xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, boris.ostrovsky@oracle.com, stephen.s.brennan@oracle.com, iwj@xenproject.org Subject: [PATCH for-4.15 v3 1/2] x86/vpt: Do not take pt_migrate rwlock in some cases Date: Mon, 29 Mar 2021 17:15:01 -0400 Message-Id: <1617052502-14181-2-git-send-email-boris.ostrovsky@oracle.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1617052502-14181-1-git-send-email-boris.ostrovsky@oracle.com> References: <1617052502-14181-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [209.17.40.37] X-ClientProxiedBy: MW4PR04CA0095.namprd04.prod.outlook.com (2603:10b6:303:83::10) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d03350d-8e52-40b6-f8d7-08d8f2f7c0bd X-MS-TrafficTypeDiagnostic: SJ0PR10MB4416: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gporBrCHo6zVJfZCTQfeAba5Klga78LAmzmN5W0LLP1pfRyWIaBy/+7FVeZcdIA9emHoLNnQXqYXV25HRAU7dyNtkaWSm4EAggxCpM+od4E6phtzvqf2ErzyMRXTkx+PGjUStkbkPq6tO6UPFJ5uPFAmuF0CMo8SQTCBxvM8haMlLWxI3JlSf28MerxAa9wrYEjHDLcwrd6cqxNxf0ZI+BWjPoo61MoRDSLHC+OQ5JRXlQnuhvNBQr99m/2o4bmP6RDyz8GMxQZej5BOjo7uA8fkebvV/3j273JcZFjynlasqtBVD53zkZ/NqgnIcGYIN+OzYNR7xe+kZQhANcIToW4hRjUMY86Ll0ts4J0RWhnb5IwrzBcjiRGoNYMHV1tEdMkfB1FuBv9RcGhss7ECVEfF6P/unK7DQvTsfaFiXkijssuLHdYpUrXoyPhBzFKqmVXgeIOpjwTd+/1tfiYfp03kCZ3MsJuQeS/iSANRNC8Kgjufiz9GFVbO1Lx0usNXDUw5bKWuEzLxdEHw3safvBh5kmtT79WAfUQMpDCjEE5zrVUFGK7ZenNPS4JstiDKAtlNlD5lRE6kd4rbHeXWeDyb+s34TeHw78EBOTQCfVFyJ83IbKsveO9D87U/0d6BQ4Hr3jn9HbE9o2t7cyOUMfETqWB1dCHtCibXBcfaNNY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39860400002)(346002)(396003)(376002)(366004)(316002)(5660300002)(36756003)(6916009)(8936002)(6666004)(83380400001)(2906002)(16526019)(186003)(44832011)(2616005)(38100700001)(4326008)(66946007)(478600001)(6486002)(7696005)(52116002)(8676002)(956004)(26005)(66556008)(66476007)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Rkx4WTRpRUEyYUFud3JRcWZzcHYwb0hxQXZnbnZwMXRLZXdVc2RNYXBIZ0tS?= =?utf-8?B?eDFJUENuWldIZHZ3OGUzWmZOUGhWMUJZUjdtVmpPeDhJVkRnYkc4cUNzVU9x?= =?utf-8?B?N0JkazJCajIxWlBmdVBoNXlJOGt6ZXhnM1p0anlXTzIvT3Z0YVNCVlFmU1Fa?= =?utf-8?B?WElBTHNJRk5YQ2R0TkNEQzlQY2psRFRzc3BkZ2xicUFCU0pWRWN4Slg4OENO?= =?utf-8?B?YnMzMmJRdFVTa05qMENHZ1BVT1ljUGdrYTlrTkpTUE5BZ3hzL0dmS0hiT2hj?= =?utf-8?B?cmpjdHhUcGU5eXl4VVkycjUwRlE0MkoyLzBWcWIvRVh4WDdoS25BUENUcmh2?= =?utf-8?B?Q0VGSllOU01pSFVJQmNXRmpGV0FMSCsyUW0rRDhIeElRTlVMakJpajRnMm1s?= =?utf-8?B?ZFpteEoxRnNmY3pyd2NLci9TUGtkOEczZldZTDVaamY5UlFvMVBpNDQzclp6?= =?utf-8?B?YWJkMkN5bFB1emp6ZjlUUTk1T3NFbjlSK3dJTGtVY0x6Z2ZqREdTWk1UZGFy?= =?utf-8?B?MkpQQWFRQTBlWXBMKzVzS0R4TzdHUkVzOGFFWWhoZjJ1Rkh5emJlQlU4cnky?= =?utf-8?B?cmduTHVCYy9HSzFCcTFiVWtxZ1NXTmRRN0F3VHR6UkRnNnlmRVZJZzNBY0x6?= =?utf-8?B?Nm5uek9tc3o1cXA1WEFkUGt2blI3Y2M3L1pLd09tTDZHL1NOMXJGVmRMRjMx?= =?utf-8?B?L0ZnbTlnR1pvR2lXcVhCSUJSdmI1THkwUHJDLzh4SUNiUHMrd1FOV3VEZVZO?= =?utf-8?B?d3BTYmEvSXJaZ0lhUlNpdWNHZmhQbmlVWE4zOStVMU9kL0dPM0JnYXpEUHpr?= =?utf-8?B?QlhYd2lrU0xCY3hHVVVBQ1BXUjd1WnVpL3RCUnZDdkVyODNwQXdOL3pQTndY?= =?utf-8?B?NThNNUVnRmtNa204VSs1VEc1RnZGRUJNWnRNeVdBWFV0RWgzVFJsMUNjblho?= =?utf-8?B?VitmUzk1bzVCdGxJanRHcFF6bEdTS0krUDRsbjRMTGNUcjlhckF4OFRiNHRx?= =?utf-8?B?QjJwL3k4cWMwd3cxVkcyL3lBd0lhNXVnaGlQMVRNL2RBTm1PNFhyQWdqYUdT?= =?utf-8?B?Z200dnBibm54R1ZDcDRheHI1YXJ5QllhVkcwQlJZeVBJNkpvQm56YTlGRU5S?= =?utf-8?B?UWdCcXN5clltOXN3RXBPVk0wZWtWV2orczdodU1vRmFmNEVXeER3cEdZWGdW?= =?utf-8?B?ZFFxT0VpbnpyQzdmdEtTZnhqbG1xcHQwb2dlTFpVaDlKaXFnSWlxZ2RMcDJh?= =?utf-8?B?aWRDUi9PRVVLaHRmVGxRLyt6bXdMUVB0Tk53ZzFUVXVqQ2d4UFlKZ0lZa0dR?= =?utf-8?B?MCtaYkU3cjNySm9EaGljbjA4SFBseHAyZjR3aDBaVjRYWEQwNUtBREFlS05E?= =?utf-8?B?SHVXQTZCTzF1bFN3eCtldExScEVDZHJHdnpOUWR3NUVteCt5WmhFL1BCSmFJ?= =?utf-8?B?VlhWNHg1cU8zWmgyb0xkamE1MVVYdTBTK0xYbU9DMTcxVHJLUGtMSmZoTHVC?= =?utf-8?B?YXdzWC9ndkVHOXVJNjZLSXhsSCtmYmMwUmdsR3Bpb0UrejVmKzhDNXp2dldR?= =?utf-8?B?OUZjUjRiSnhRdXVkRnh1ZEhtbXFSL2djSmp1Sk43UDQrMFJKNEI5R0Q4NHFq?= =?utf-8?B?SnRqWWkzY2d4b3Q1TjUxa0VkMUJDWUFJVm53dTZtUXdLdGdZVEwzdjV0UHB6?= =?utf-8?B?dXQ4S0Izb3BsOTI4aWRMWmFRK1NZY2tLRHBTSExoR1RmZkZHTUhjRkp5Vita?= =?utf-8?Q?J1lIO1Eij+9WwyDJi0w+Ocqoe+P08PaFuHYmUa6?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d03350d-8e52-40b6-f8d7-08d8f2f7c0bd X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 21:15:17.8633 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8+cnL/DSWQN7cfSsaYgJYzc5DpGERbRe37lYEbxUcFhE76qvy606s425YEGMUUvFgWj5+N+UQrJnv/mPXH+LrZrq9q+7JwDVqfYlTG542n0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4416 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9938 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103290157 X-Proofpoint-GUID: lUVoQD8gmjRWIznPSEdIL9OorTfsgQJO X-Proofpoint-ORIG-GUID: lUVoQD8gmjRWIznPSEdIL9OorTfsgQJO X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9938 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 spamscore=0 clxscore=1015 mlxscore=0 bulkscore=0 priorityscore=1501 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103290157 Commit 8e76aef72820 ("x86/vpt: fix race when migrating timers between vCPUs") addressed XSA-336 by introducing a per-domain rwlock that was intended to protect periodic timer during VCPU migration. Since such migration is an infrequent event no performance impact was expected. Unfortunately this turned out not to be the case: on a fairly large guest (92 VCPUs) we've observed as much as 40% TPCC performance regression with some guest kernels. Further investigation pointed to pt_migrate read lock taken in pt_update_irq() as the largest contributor to this regression. With large number of VCPUs and large number of VMEXITs (from where pt_update_irq() is always called) the update of an atomic in read_lock() is thought to be the main cause. Stephen Brennan analyzed locking pattern and classified lock users as follows: 1. Functions which read (maybe write) all periodic_time instances attached to a particular vCPU. These are functions which use pt_vcpu_lock() such as pt_restore_timer(), pt_save_timer(), etc. 2. Functions which want to modify a particular periodic_time object. These functions lock whichever vCPU the periodic_time is attached to, but since the vCPU could be modified without holding any lock, they are vulnerable to XSA-336. Functions in this group use pt_lock(), such as pt_timer_fn() or destroy_periodic_time(). 3. Functions which not only want to modify the periodic_time, but also would like to modify the =vcpu= fields. These are create_periodic_time() or pt_adjust_vcpu(). They create XSA-336 conditions for group 2, but we can't simply hold 2 vcpu locks due to the deadlock risk. Roger then pointed out that group 1 functions don't really need to hold the pt_migrate rwlock and that instead groups 2 and 3 should hold per-vcpu lock whenever they modify per-vcpu timer lists. Suggested-by: Stephen Brennan Suggested-by: Roger Pau Monné Signed-off-by: Boris Ostrovsky Reviewed-by: Roger Pau Monné Reviewed-by: Stephen Brennan --- v3: * Updated comments as proposed by Roger * Updated commit message (Roger, Stephen) * Added pt->vcpu==v test in pt_adjust_vcpu() (Jan) * Use v instead of pt->vcpu as argument to locking helpers in create_periodic_time() and pt_adjust_vcpu() (Jan) xen/arch/x86/hvm/vpt.c | 44 ++++++++++++++++++++++++++++++++++--------- xen/include/asm-x86/hvm/vpt.h | 18 ++++++++++++------ 2 files changed, 47 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index 4c2afe2e9154..560fab9cfc60 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -153,32 +153,43 @@ static int pt_irq_masked(struct periodic_time *pt) return 1; } +/* + * Functions which read (maybe write) all periodic_time instances + * attached to a particular vCPU use pt_vcpu_{un}lock locking helpers. + * + * Such users are explicitly forbidden from changing the value of the + * pt->vcpu field, because another thread holding the pt_migrate lock + * may already be spinning waiting for your vcpu lock. + */ static void pt_vcpu_lock(struct vcpu *v) { - read_lock(&v->domain->arch.hvm.pl_time->pt_migrate); spin_lock(&v->arch.hvm.tm_lock); } static void pt_vcpu_unlock(struct vcpu *v) { spin_unlock(&v->arch.hvm.tm_lock); - read_unlock(&v->domain->arch.hvm.pl_time->pt_migrate); } +/* + * Functions which want to modify a particular periodic_time object + * use pt_{un}lock locking helpers. + * + * These users lock whichever vCPU the periodic_time is attached to, + * but since the vCPU could be modified without holding any lock, they + * need to take an additional lock that protects against pt->vcpu + * changing. + */ static void pt_lock(struct periodic_time *pt) { - /* - * We cannot use pt_vcpu_lock here, because we need to acquire the - * per-domain lock first and then (re-)fetch the value of pt->vcpu, or - * else we might be using a stale value of pt->vcpu. - */ read_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); spin_lock(&pt->vcpu->arch.hvm.tm_lock); } static void pt_unlock(struct periodic_time *pt) { - pt_vcpu_unlock(pt->vcpu); + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); + read_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); } static void pt_process_missed_ticks(struct periodic_time *pt) @@ -543,8 +554,10 @@ void create_periodic_time( pt->cb = cb; pt->priv = data; + pt_vcpu_lock(v); pt->on_list = 1; list_add(&pt->list, &v->arch.hvm.tm_list); + pt_vcpu_unlock(v); init_timer(&pt->timer, pt_timer_fn, pt, v->processor); set_timer(&pt->timer, pt->scheduled); @@ -580,13 +593,26 @@ static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) return; write_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); + + if ( pt->vcpu == v ) + goto out; + + pt_vcpu_lock(pt->vcpu); + if ( pt->on_list ) + list_del(&pt->list); + pt_vcpu_unlock(pt->vcpu); + pt->vcpu = v; + + pt_vcpu_lock(v); if ( pt->on_list ) { - list_del(&pt->list); list_add(&pt->list, &v->arch.hvm.tm_list); migrate_timer(&pt->timer, v->processor); } + pt_vcpu_unlock(v); + + out: write_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); } diff --git a/xen/include/asm-x86/hvm/vpt.h b/xen/include/asm-x86/hvm/vpt.h index 39d26cbda496..74c0cedd11cc 100644 --- a/xen/include/asm-x86/hvm/vpt.h +++ b/xen/include/asm-x86/hvm/vpt.h @@ -128,12 +128,18 @@ struct pl_time { /* platform time */ struct RTCState vrtc; struct HPETState vhpet; struct PMTState vpmt; - /* - * rwlock to prevent periodic_time vCPU migration. Take the lock in read - * mode in order to prevent the vcpu field of periodic_time from changing. - * Lock must be taken in write mode when changes to the vcpu field are - * performed, as it allows exclusive access to all the timers of a domain. - */ + /* + * Functions which want to modify the vcpu field of the vpt need + * to hold the global lock (pt_migrate) in write mode together + * with the per-vcpu locks of the lists being modified. Functions + * that want to lock a periodic_timer that's possibly on a + * different vCPU list need to take the lock in read mode first in + * order to prevent the vcpu field of periodic_timer from + * changing. + * + * Note that two vcpu locks cannot be held at the same time to + * avoid a deadlock. + */ rwlock_t pt_migrate; /* guest_time = Xen sys time + stime_offset */ int64_t stime_offset; -- 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 29 21:15:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 21:15:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103267.197070 (Exim 4.92) (envelope-from ) id 1lQzER-0006Ss-7f; Mon, 29 Mar 2021 21:15:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103267.197070; Mon, 29 Mar 2021 21:15:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQzER-0006Sl-4N; Mon, 29 Mar 2021 21:15:31 +0000 Received: by outflank-mailman (input) for mailman id 103267; Mon, 29 Mar 2021 21:15:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQzEP-0006Pu-Qw for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 21:15:29 +0000 Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2dc537ff-a2cb-40c2-bc38-571311742598; Mon, 29 Mar 2021 21:15:26 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12TL93X2149008; Mon, 29 Mar 2021 21:15:24 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 37hv4r50rj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Mar 2021 21:15:24 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12TLAkVp131526; Mon, 29 Mar 2021 21:15:23 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173]) by aserp3020.oracle.com with ESMTP id 37jekxp8rn-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Mar 2021 21:15:23 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by SJ0PR10MB4416.namprd10.prod.outlook.com (2603:10b6:a03:2ae::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Mon, 29 Mar 2021 21:15:21 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.033; Mon, 29 Mar 2021 21:15:21 +0000 Received: from bostrovs-us.us.oracle.com (209.17.40.37) by MW4PR04CA0095.namprd04.prod.outlook.com (2603:10b6:303:83::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.32 via Frontend Transport; Mon, 29 Mar 2021 21:15:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2dc537ff-a2cb-40c2-bc38-571311742598 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=corp-2020-01-29; bh=ivlZR+JN8fPCmMqrrPDqj0Vqn0pzdwEdR9x+/IBM4g8=; b=Mcplh4EucM48vC0OsjgpeD4PFj9MXegkqwJi06KJBzzCd89XvueDhIHcKi57ao+kK95m 1wbFcXN95PmyxChRnmRrwMV5f73jjQRl+/POICviirEeyKJp/KqbmcvqIdH8XuND9K6F kRqkszJwsnrRowPNRY952j46dX/wZlfK17zuwl46WJOYlXnF4CIqAUpDDMSC8X7OuJBE gtwpwhtfge1YeL7f6B3PVyAjGG309FW1MSam8jpeLpmQy8TBfC7ip7yYHoNkYsG1DeNd KtsVCR941BQyx0CibfUNkJqFYrulat+QjrT9tOvoo0YgXG//FzM16ceCX1riGGVraz6e lw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W1AZhgISStcdkDVTC/CvbFIMZBumE7/TPl5bzOY5Hni9boGkLxnlbru+UHMT+NJYQeXUNYlQ/5Rhf/HgMlH38wgkSyBD+g0rsWVAMXo7BAW+6yfzHchoQQQYF31UcjLVLfspkyXNyduv6pk2JQZ6/pKTCxx0wqG7A9Ux04OSksLOF9rxPPH+7/oHdroXFhW673ZSOo1PbKJL8u1KqBJAc8YRwGqlhiL02fJCByEDH8q93IXx62lV8Hxu9hziay35r+3Lg7m1sOPBQFUD+rhaaqZon1NEXJZ8QtTpxv7+tlZp9rHCyapAIL1SF93iB+Zl106xyS5HzUYlJBYSBKeIgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ivlZR+JN8fPCmMqrrPDqj0Vqn0pzdwEdR9x+/IBM4g8=; b=Ge9NzWdV1aavrOFdGJNHeim2UkPqMgyJiKyHwr2ikQJTrNgwtkERNF0ZzywBn/QdSLWJHpwf5kob1+1FZED2+965Kq8L21B4SnnvO6Pg5+jHiauJK2/jHU5MqxQAZ2qX5lM8oiQdUmDH2HTgq2a1LKJgOQMzCII0UYAlmAATIWeoyXuKijWi3q/UmWGLq5Vjm9T8YA3EiaGdd2RBL1l5RR0wSNIhjt3b7mCHXXO37JQyjDFcBcIJ1v2uYJWJvW/Gjfp0NAW2T4oPVvuyRZWNDF+vv7Tg5vvmT28zbTAGJzvKSLsx/rz+LyOZe+v38sZqZdZ7C6lVD0ZWBJfwv8J1pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ivlZR+JN8fPCmMqrrPDqj0Vqn0pzdwEdR9x+/IBM4g8=; b=UAqplVG4vs/2Bfh6x5OVNZFKhX/NtOwmXqsFCfgzqG9eJtCgzKOsIs+JCR/UlJnxwiYwWg5i31+bp9NTCaVTJjv/UuyHscxHSiIKzJ2+d6Km5FKYQd7aNgUAb4oNEFhHQEt91SYWV/j9ctLwcRznXNFloCgV/VY4KvVeg5Hbdmw= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; From: Boris Ostrovsky To: xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, boris.ostrovsky@oracle.com, stephen.s.brennan@oracle.com, iwj@xenproject.org Subject: [PATCH v3 2/2] x86/vpt: Simplify locking argument to write_{un}lock Date: Mon, 29 Mar 2021 17:15:02 -0400 Message-Id: <1617052502-14181-3-git-send-email-boris.ostrovsky@oracle.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1617052502-14181-1-git-send-email-boris.ostrovsky@oracle.com> References: <1617052502-14181-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain X-Originating-IP: [209.17.40.37] X-ClientProxiedBy: MW4PR04CA0095.namprd04.prod.outlook.com (2603:10b6:303:83::10) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3efc8d69-a83c-4a4e-220b-08d8f2f7c197 X-MS-TrafficTypeDiagnostic: SJ0PR10MB4416: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:660; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HoAxWbBhralypUVp0Q2lLTso8gmfV2PwqXnwuqhMcsIdi4ZAWHSuKRgRn0qT2C9YVmuPxd7Y+TC31iZLd6XC7mfpmdQXFhCVhzEKGv/xEwpwNycGG3fhODL8EkrAOoXIgPVldBm25iCMt6Ns0OznvTd0dl08sOu8+ILCaYFM4tHXInHUMvxR7/KsiqwM1OIJnIufvVwl8a5DaB+YqYLGpicsFc+b5vhygRcHvxV52vDueRDE9w/9vODjttxUbHwso4Hv3UeX3fvdKt8UGOR8RvaXYkrPb+uWbzgM8G+TBZILmqZVAdh7uM8BVLW2pK97RsXOBXDT20lASKul0LNnY6aOEbKmJfg33AC0CuWJTCTj7/T2YJX5/BKcpPz10mk6K+vQLznrNWGf4H12u1LOUXrwXbJipLnUnk25TCdymbAYb+XbfWGj9GKvw+N/fFO5ile13alrzNKBzsQOdSXc0vhOKbVaxQLaTGk6rtZxsaslh9wEdBLSoyZYhqik2QqBCiiB7w3reZv9fu/y9XjTKxBEo77AvA2PjWMdgLXiOvgOgETkBnkDiDo357jZM1ueofZmY0ucNue3NmLM/7iUcz0UPRlceOMUr0tSe+CL8Q7MZr8Ut/a/3ySfsiog9NMgwQt2WOHNV9JFZfqRCT6hocqFhYmq9C7bKxtNTuxpd+c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39860400002)(346002)(396003)(376002)(366004)(316002)(5660300002)(36756003)(6916009)(8936002)(6666004)(83380400001)(2906002)(16526019)(186003)(44832011)(2616005)(38100700001)(4326008)(66946007)(478600001)(6486002)(7696005)(52116002)(8676002)(956004)(26005)(66556008)(66476007)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?Sqp14K9dw7ucqx6U5olNAAwJqCMAfz8fn3IIgCi508WhSvO7Wmg4Fgs7DBs8?= =?us-ascii?Q?ixSQRCYufpgCL2Z7G+44plxUiRsYFcyPsGrfRJxtvZWofyExs9Gj5XNhRfKO?= =?us-ascii?Q?YwokiikkLD7C4gmzFSSh4bqDIUviOFZITaRQlbphuXVwEiwJD/jzOH0hdgzx?= =?us-ascii?Q?+GYwSVlOR1iuoyA1BEijsneTYR+sOR/szYcWJxBL/ZcnqcqOF/9LiVH8cMl/?= =?us-ascii?Q?0kgWIoACFeTZTyyh4Yts5sTlWYjXmM1ZaKyQeV03O7JWk/8KzAqVab7VqTaQ?= =?us-ascii?Q?iwyH8Q+3/IAPszyPs29qrAQzIU1bsRh+rqsmpNO1ztQ4YKH2vvhgIQcnjIDw?= =?us-ascii?Q?a3jkD5yGbAlmQYn19plFBO1XJ14yHZYqoDFsb+hjdq8axaNEuIABitt91UeA?= =?us-ascii?Q?x+BDm5ynhPlTliu/tU3vuv+ycCziFmleSkXSn/s1iv0O8vA/Pv34DDXf5q0v?= =?us-ascii?Q?Z8VrIESgclcrUHYIo68y6vJJn6h1H1zi+IYsD3m1jQPnlLhH1Dx5oEnm+rpx?= =?us-ascii?Q?qY2WLk0CIqju+vp2Qc+5ayln/9BcEZyzyh2ojALDWYKxH/WOyRlLCci4HUnD?= =?us-ascii?Q?+YYV2QXE8hzbt6nIpfpxWE4fU9zGgv2oQ+OGu0xOyj8HTDBrVYSTxFdoWdHc?= =?us-ascii?Q?AposiEB6ewPReBH7uy/qqibNStzhOn5qFVcFL4pEliyrxNHJ0+FZzytgPawi?= =?us-ascii?Q?UwNOGyEYqTW3WHqETEuGfMBgtXYlMFso5Q5dlw8YfuLCdOQWge8uzH/N/dwj?= =?us-ascii?Q?2fBeqi9uUZjIvJ8mdDjXDI39Y9egvwhxLBWhaSzGkddNLYceGHfKVVsUJONz?= =?us-ascii?Q?dhBMnfeRyq6FaTH4FIMGwbKfDRxs7FSPFvVoEFvja0b+4lXgdPNMxMQQ1/dc?= =?us-ascii?Q?KoClsII+BM+j5i2Wni64EIPk3sFDNOkDfmRoslMHdm1FPZlLpgh/bIbYznJ5?= =?us-ascii?Q?/Fske0FIOwCniMwoB7QTkd2rD7Q0rTHlNHQCdPic9kt1ICk238mjAYUl7Ur2?= =?us-ascii?Q?oJe7Z9aVqsKXjIr9BHlv6GqV6Ud1/sbvm4kp08cFIrntWmF8/FLTFbi2l07A?= =?us-ascii?Q?wvYvZ1LRjTlE0e/tn7G/DgnpKlMx+5m/hS0itzjx8nS7+FwP6ZBRTEY2zcJf?= =?us-ascii?Q?SdtqWdZn//CDKLcRegpisrpJfLhg6WcREDm8iK5KgghnKlJ8LozXs435MWJK?= =?us-ascii?Q?tz00rO+WCuiI3p7BfmDNKdgFGVrIsRT2TiBWOe//1ajgtOn2bAxcqWv9qHwN?= =?us-ascii?Q?ITwd9Yl+SUWUg/VafplpVh7dvYxVVjm9LUmPvYfBybquhstOse6a7mLF6ET7?= =?us-ascii?Q?Joa6GZopZqzLdxYqD+F/znjJ?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3efc8d69-a83c-4a4e-220b-08d8f2f7c197 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 21:15:21.4083 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qnAGnk0bX+EqJhK+xquExG5pN/jgDkheVdIGhWLLdwyyXiEq7GOVZzVWZJ5L6AhqcuyuBqbbZHPl7oVlhWZ1cTQt1Ecf16xBU/FaM2L5+DI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4416 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9938 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 mlxlogscore=967 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103290157 X-Proofpoint-ORIG-GUID: 68bcp-Nj3eF4dIsN6f4BCHRNfPQQ7gzI X-Proofpoint-GUID: 68bcp-Nj3eF4dIsN6f4BCHRNfPQQ7gzI X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9938 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 phishscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 suspectscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103290157 Make both create_periodic_time() and pt_adjust_vcpu() call write_{un}lock with similar arguments. Requested-by: Jan Beulich Signed-off-by: Boris Ostrovsky --- New patch. I ended up doing what Jan asked --- create_periodic_time() is also using different start pointers in lock() and unlock(). xen/arch/x86/hvm/vpt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index 560fab9cfc60..4cc0a0848bd7 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -592,7 +592,7 @@ static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) if ( pt->vcpu == NULL ) return; - write_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); + write_lock(&v->domain->arch.hvm.pl_time->pt_migrate); if ( pt->vcpu == v ) goto out; @@ -613,7 +613,7 @@ static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) pt_vcpu_unlock(v); out: - write_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); + write_unlock(&v->domain->arch.hvm.pl_time->pt_migrate); } void pt_adjust_global_vcpu_target(struct vcpu *v) -- 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 29 21:15:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 21:15:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103265.197046 (Exim 4.92) (envelope-from ) id 1lQzEN-0006QB-Fo; Mon, 29 Mar 2021 21:15:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103265.197046; Mon, 29 Mar 2021 21:15:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQzEN-0006Q4-Bk; Mon, 29 Mar 2021 21:15:27 +0000 Received: by outflank-mailman (input) for mailman id 103265; Mon, 29 Mar 2021 21:15:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQzEL-0006Pu-2o for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 21:15:25 +0000 Received: from userp2120.oracle.com (unknown [156.151.31.85]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8ef4b350-952f-446f-ab28-0c01000a58c3; Mon, 29 Mar 2021 21:15:24 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12TLFLIP160028; Mon, 29 Mar 2021 21:15:21 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 37hwbncynw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Mar 2021 21:15:21 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12TLAX9R170068; Mon, 29 Mar 2021 21:15:20 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2177.outbound.protection.outlook.com [104.47.56.177]) by userp3020.oracle.com with ESMTP id 37jefr9f6q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Mar 2021 21:15:20 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by SJ0PR10MB4416.namprd10.prod.outlook.com (2603:10b6:a03:2ae::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Mon, 29 Mar 2021 21:15:16 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.033; Mon, 29 Mar 2021 21:15:16 +0000 Received: from bostrovs-us.us.oracle.com (209.17.40.37) by MW4PR04CA0095.namprd04.prod.outlook.com (2603:10b6:303:83::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.32 via Frontend Transport; Mon, 29 Mar 2021 21:15:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ef4b350-952f-446f-ab28-0c01000a58c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=O+Eb95b8wJMI2NvNP5U2nCrXRJneKPvPebbBCQxucnY=; b=vl86/rWqRJH+PlUrcp0KaHhvkY97xflh1t+fTgptI9PwiMyyuLpiSvR9Z+kHPAAqOr8C T3/0KaDv0cSvt6C9MH+ekUniVGEyK10E1lmq1FcY6j7TS7cCSQiRVN9tJ1xcKE+5wqmK +3VEBZg1DRnbeAiO2FyPcQsCYsz07fl+cnJviqsd45evDxtPD0So/DpgTEjm1h444UAA X7rq5BrB677ovMjHh8ZdzVtkxkObHvccXZ0SXCFf5sjoaOX/iRjhE1zQBQFzYps4xDFq yaMWMX4SY0E0RFIar0auaezf/9HgpRdcuAn91B3vAE4PhWZETwR2mL7M752Bi6QlfbFX ng== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qxcu8ksJWCKhC/nMbcH1Kfcf/ahx2gO6n9zCel24IFcDgQIB7U/IyETFAjeQCbYDmah5VRWQXC/iC8X47OQXkKaIAl58KKcEg3/RkLMkom3dZQauu1yGXQtVdXxiYxPZ4AcPs9Dci3ncW9Nj2sCBkmwQ/n6NPU44H1Z0z2DLgcMx+cA4s1kRWVreR6m04eZKb0Q30Iy0SISJGPmI++DmqfLfampTxQcxPVhr/I1CnSHJgMg+pHmzbtxc+RRTqfD96pwm3FY1K1z4Xfz2QAwNQVYRsYMYSDUO4grPZ0qwHlyDJZdNPW+7/aE2Gc+wsf/WignJafyJ8bS/C/E+BaX2fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O+Eb95b8wJMI2NvNP5U2nCrXRJneKPvPebbBCQxucnY=; b=YHk9U7OCL+3JUYzhz1q08udMpnmfdulQHVJOKZ3GqaonXoxaC691V2uYEdNY82lAWYTFTyTNMZ4SFKI1rpDHP/5bKt1dlyrfxdsmtTY9sUDCplcmXXkTfSnIYJfuax5eknQiVbssvyB/zcJjle+XtmoP7Wiet7ktdUeeT6gj7+8+eEd7cAYK9r1XbCQdRCrbDhGZm0zGPVXy5q5+od5RqbjL11K2Nx0Tkgfx+Ye3OUKrjr3EvEt9xINqs6j2qVMk7+PgRl3neD2wpciN2vvEtZKzrZKoMum4J/1IFWY5q20WoOlW0ZYilfQJeTuJ+Y43UBWHqLhSCcy218TTChcftw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O+Eb95b8wJMI2NvNP5U2nCrXRJneKPvPebbBCQxucnY=; b=GqsQEdBnJhMAmTfAQ/aozzUAzjh6EfFKOsiSev75P4kyG6BXDQLUNcynNTQ9L2reSEylDqtIWYaruHBijwWOMSI2rLJNMKsHN5z2aDSjq74sLe5drTPeVDNcM01R3WdD3ZTv52/6BSSVfGzTdt/20jIui/SuET1fvCSrCBmqPe4= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com; From: Boris Ostrovsky To: xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, boris.ostrovsky@oracle.com, stephen.s.brennan@oracle.com, iwj@xenproject.org Subject: [PATCH v3 0/2] Performance regression due to XSA-336 Date: Mon, 29 Mar 2021 17:15:00 -0400 Message-Id: <1617052502-14181-1-git-send-email-boris.ostrovsky@oracle.com> X-Mailer: git-send-email 1.8.3.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [209.17.40.37] X-ClientProxiedBy: MW4PR04CA0095.namprd04.prod.outlook.com (2603:10b6:303:83::10) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb6a28a8-851d-4f50-6c5a-08d8f2f7bf9f X-MS-TrafficTypeDiagnostic: SJ0PR10MB4416: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RFDr5jwo80Z+zuXci4GIttyZEmHE89ETC/CwfihEi4R+99SO1ReKpPJ1HrCM5YD+HHl+ObGWm1x52aoDZyhPBDJvRYnwIk1fLyqoePRLpz2DXxpZ6kzcGKfzQZ9a1vP6PeYgQre7jxU1GZdRctBxM/1hAonNtUYOXKozFj/0zs9Va9kmSZpMGUjDWZrg3ND0ebIpLdQeFTOgj0z1SASdKATqEW2RfwHMhazHNYX7Lk/jTx78mANCZGNwR5Mc0R7m0TyXwt0x026HTQ/0/EQM6D6bjZTWMDuYy43wORsGBogSyVUljBENADcP/kx7k7rmC6Q8Crc90A1htbuVSqPxm1xPlRMx60OZOo+w3Pa7m38VK0uLeqKWuxGwvl3UOgilY1Jxo824OAcg5Cx0ozxE2fowThkqMEecVSx+lz/Vg7fohbFlHMDMDAHGXfRDOVBplpgKbYDypXhBZR1h/bthjyIoinS+0/hnWLILqPbuPRqdfl1j7dowSMLTF6eCNalYcLbcd5L4ojYit23WG8+sAE0Q9fiSaHhDRTDhFhOj7d6FLwr0P4vb0vMWlICvEc2kEE0Jsl5S1mQCGX0qaY5LDUnEvezmUVs2CBShQfMK8BACZbFkGsNkk9oUVfeY00tG2evmgQEyia55H9/V7lCf4rB92o9C3ONEi2eXMvaEO2Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39860400002)(346002)(396003)(376002)(366004)(316002)(5660300002)(36756003)(6916009)(8936002)(6666004)(83380400001)(2906002)(16526019)(186003)(44832011)(2616005)(38100700001)(4326008)(66946007)(478600001)(6486002)(7696005)(52116002)(8676002)(956004)(26005)(66556008)(4744005)(66476007)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UXhYbkU2c3EzVnc1TVJ2TENvcUxndG9HYzQzRno0SklJUnBiWEkxWWtBcEFr?= =?utf-8?B?eGdrZHQ3U2Fmb2pFYnFFU1h0QWtCdHFiMnF3cUJMRVdjZ2lCajltTlJET1NV?= =?utf-8?B?bHhiRmZuaFFmT1QyNUFlVEZnUzdDZFFrd1YxZHlLZ1F1elRxZzZZZjIyWmds?= =?utf-8?B?SVJtTk0rNlk2VmxBTmUvbmZ2c0pLd0s5R0NETGxGbVV4M1IrY2ZtNWExSmlO?= =?utf-8?B?YlEwa1Z5c1VFMWdzQ3p0T2Z0MzNnQUVjbzdMZGZIMThQSWdtVjJ6TmJESmV4?= =?utf-8?B?bVVpZXZUUmlNSDhpMVZHSm04OTJFZ3Q4MXhHZWpxaEk1emF6eEp0T2U5ZFRD?= =?utf-8?B?cm1UOG1nV2Q3RHJ3UEVBRWlKTGlMWjlJa3pnZy9lSXgzZnRITnRtaldDb3d6?= =?utf-8?B?VHZuVFhwOVNUODNEMkswaDRENUY2MGRsOVhDbVlhQkJXeTg3ekVDZXpKREFO?= =?utf-8?B?ZmRqTDJ2V1dnSnJVQVljUVU3Rk9oRWdINTV4a1dzbHVzN1Yva3hzaDJUeEg2?= =?utf-8?B?RTRqUXB6QTdJRHZ0ZzhTYTRJY1Q5MVpSc3FNNjBERUplMHhVR0tKUEtrUFJP?= =?utf-8?B?a05tbWt2L01KNHR6UzhKQ2hCVEpJZkdKOTJaMVY2OW5GSThhMmlSZVUxNXVn?= =?utf-8?B?a0Y5QWlVSG9RNWpSZnBGNzdWc2JtNmhSaVpDWjB5bGJqV2hwcEd2ekhJSXpx?= =?utf-8?B?OFBvK1NOWEdNa2VkZ1ovOTFzVmlGYzNQU0V0KzNjakdyaVlPUllUOWJZV3V4?= =?utf-8?B?aTNUOTBGNjFyTVR4aTZDRWsrQytWc2w5Y2lmZllqNG5QUTZiZFRmWm5BbDZV?= =?utf-8?B?UkQ5cHVvcXppa0cydzhKa2RrTDBUZGgyUHgyeTBFWXA5RVoycFl4VVpCcS9U?= =?utf-8?B?RmdXRmxET1JjODAyV0ZuL0IvL3RzZkpYa0hkekEzaTdDZ2pSZG1mZXkwSXJr?= =?utf-8?B?WElRdkZ5N0ZySkg0UGZYMnJsbUFreDExd0tiVGtCUHIvU3dwbWs4czVRdkhZ?= =?utf-8?B?bkVKS0FqcWtDcjdTcUZKZXdBS09jcTNyKzZOQUdKQ29DZHcvaXZJVk5lYy9H?= =?utf-8?B?MkxIaWlibHFyNytUaERCMVQ2RFE1ZTRDb01vZEljeWIwMGQ4cEkrT3R5Q2hY?= =?utf-8?B?ZnZ1WFZxcTVUU2JybmFjS0gwMUk5L1pzMmFGelRKSXZwMVAyUTBkemJKMVBs?= =?utf-8?B?U2ZUdis4YzlmZHY2SVhBVmtFSDZhT1Rtb2taNzltV1BMcDEzSWwyekxONWFv?= =?utf-8?B?dHlTVmJ5ZHVacTZUK0YvRUpXa0orTDNnL0ZBZ0ZTWHNaRWcxZVdqVmlmV01O?= =?utf-8?B?SUx5OW93YXNqd3o0cEZtTGlwZFZzWnArYjBaZEpCUmM4RTdicHF5aVJwV2pH?= =?utf-8?B?NHhlTkpycnovRDBoUlBiNmNPZHBwRzVhTG1wb0cxTDNmeDN0alcvUlh2N3V5?= =?utf-8?B?dmhuNEx5ZUlyNVdEYzhpYzczZjdER2djWmVWM1ppSko5ci9GMm9MTUZIQkVI?= =?utf-8?B?OE83a3hYS0VtWG1VWGJaMWhBMDEycWZWcFJRWEI5UnU5VmdjSG5rL2hwb2dD?= =?utf-8?B?OHNFQUh2WWd1T1Y0U1lwZEQwM1NWdmhiQkNyMVNYbzVjY0EzS3lUbXdsYVQ3?= =?utf-8?B?UElRTUZOT0hFVWJwWjJiV0ozYnA0cFJWQjhrc1BIUzc1QUltbUNHZkdmb1B4?= =?utf-8?B?b0VValBTM0Qxd3ZkWjR0Z0MzK0tzdjlPcEpWKy9pdWg5KzRiVXdMbkpvOXRm?= =?utf-8?Q?H/Xh2PitLYvFvfeE+/b7+WJC0eZdoKdIrpf/FdP?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb6a28a8-851d-4f50-6c5a-08d8f2f7bf9f X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 21:15:16.1983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EXs8N4PWVga2ZUEpzz48aIJwm0Fa24fxlo8m3LqK8HahuE0koSkrdkVI+Ui4SZHW6LnyEHQy43hMfeh+KXc/hT3gQ0JEvOHeYMNVN/qTXVk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4416 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9938 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=651 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103290157 X-Proofpoint-GUID: SstBIfmmOUER55_kewQwhQ4XBovKK0e- X-Proofpoint-ORIG-GUID: SstBIfmmOUER55_kewQwhQ4XBovKK0e- X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9938 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 clxscore=1015 phishscore=0 mlxscore=0 malwarescore=0 mlxlogscore=844 suspectscore=0 spamscore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103290157 The first patch addresses performance regression introduced by XSA-336 fixes. This patch could be considered as a candidate for inclusion in 4.15. The second patch is a minor cleanup and can safely wait until after 4.15. Boris Ostrovsky (2): x86/vpt: Do not take pt_migrate rwlock in some cases x86/vpt: Simplify locking argument to write_{un}lock xen/arch/x86/hvm/vpt.c | 48 +++++++++++++++++++++++++++++++++---------- xen/include/asm-x86/hvm/vpt.h | 18 ++++++++++------ 2 files changed, 49 insertions(+), 17 deletions(-) -- 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Mon Mar 29 22:25:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 22:25:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103279.197088 (Exim 4.92) (envelope-from ) id 1lR0JH-0005hv-CD; Mon, 29 Mar 2021 22:24:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103279.197088; Mon, 29 Mar 2021 22:24:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR0JH-0005ho-99; Mon, 29 Mar 2021 22:24:35 +0000 Received: by outflank-mailman (input) for mailman id 103279; Mon, 29 Mar 2021 22:24:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR0JF-0005hf-UW; Mon, 29 Mar 2021 22:24:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR0JF-0007Kq-OK; Mon, 29 Mar 2021 22:24:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR0JF-0001J9-CN; Mon, 29 Mar 2021 22:24:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lR0JF-0003mY-Bt; Mon, 29 Mar 2021 22:24:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JkV2lEzVleKi6EIAkLbCLHa2qf9Y/pcQD4mjtPgZ6YE=; b=6HvVH9AhJO/XAzw0dvHu9j6rPi 8uNwHhv/65/KqYZwutmPi8MN8uBQxLtvOluEjuYCcGGFGFZQ2QHgNCCwsUDHzrTRwihu41qz6UbWr 1eKXptRJigNZ8iy2+F3gCGr8iqHQCQYrBT2uZNn3P58b6JjsosuPGmS/jY01c7xsOQgo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160522: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=7b9a3c9f94bcac23c534bc9f42a9e914b433b299 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Mon, 29 Mar 2021 22:24:33 +0000 flight 160522 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160522/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 221 days Failing since 152659 2020-08-21 14:07:39 Z 220 days 417 attempts Testing same since 160477 2021-03-27 15:41:46 Z 2 days 3 attempts ------------------------------------------------------------ 466 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 138319 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Mar 29 23:39:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 29 Mar 2021 23:39:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103294.197110 (Exim 4.92) (envelope-from ) id 1lR1T2-0004Z2-1Y; Mon, 29 Mar 2021 23:38:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103294.197110; Mon, 29 Mar 2021 23:38:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR1T1-0004Yv-UW; Mon, 29 Mar 2021 23:38:43 +0000 Received: by outflank-mailman (input) for mailman id 103294; Mon, 29 Mar 2021 23:38:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR1Sz-0004Yq-PC for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 23:38:41 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7c7fc1f9-7cc0-4528-86db-531da5b3f4d6; Mon, 29 Mar 2021 23:38:40 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D07ED61996; Mon, 29 Mar 2021 23:38:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c7fc1f9-7cc0-4528-86db-531da5b3f4d6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617061120; bh=GUJL3LcaAUI/LVc1NF3tsYKfXtlSCAFsCnKpHMQuLF8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=mUVeeqoe2c6fWc5BqecyDhn8iIFBZ2CrVnzYG+mlozI3xOW5fKbRM33NpxEazFIB6 cOiTzenGMy6gt8VwF9HW+Ir43ipdGKA0M8SXB7wyF2AX9GFgU5cNTsuNncfox86wls PEG3BG++7eeiHDoOiXrNOf/E6n1FxUlu4FhlC8GG0Sl90HSCp25syhkUTkKEe+2Icz mtNaC8TOC5SDaQExIHlIAMwtFrh0vjBYMvNZOVEKN4CPOwvB0vyPVQAGYnKLQb5xLr 91DSsNjj5gieWVe0jXgHC1XLxMp6mKcVjfyz0l3U4pEOoxpNMvg257FFY2VVPbfK8F SdEfqFeTkdhKg== Date: Mon, 29 Mar 2021 16:38:39 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: George Dunlap cc: xen-devel@lists.xenproject.org, Wei Liu , Andrew Cooper , Stefano Stabellini , Doug Goldstein Subject: Re: [PATCH v2 for-4.15 6/7] CHANGELOG.md: Add entries for CI loop In-Reply-To: <20210329161457.345360-6-george.dunlap@citrix.com> Message-ID: References: <20210329161457.345360-1-george.dunlap@citrix.com> <20210329161457.345360-6-george.dunlap@citrix.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 29 Mar 2021, George Dunlap wrote: > Signed-off-by: George Dunlap Acked-by: Stefano Stabellini > --- > v2: > - Add dom0 / domU testing for ARM on alpine Linux as well > > CC: Wei Liu > CC: Andrew Cooper > CC: Stefano Stabellini > CC: Doug Goldstein > --- > CHANGELOG.md | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 62174c8c74..c4696e41a1 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -16,6 +16,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - Library improvements from NetBSD ports upstreamed > - x86_emulate: Support AVX-VNNI instructions > - x86_emulate: Expanded testing for several instruction classes > + - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 > + - CI loop: Add qemu-based dom0 / domU test for ARM > + - CI loop: Add dom0less aarch64 smoke test > > ## Removed / support downgraded > > -- > 2.30.2 > From xen-devel-bounces@lists.xenproject.org Tue Mar 30 05:06:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 05:06:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103228.197152 (Exim 4.92) (envelope-from ) id 1lR6Zi-0003GY-Fg; Tue, 30 Mar 2021 05:05:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103228.197152; Tue, 30 Mar 2021 05:05:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR6Zi-0003GR-Bf; Tue, 30 Mar 2021 05:05:58 +0000 Received: by outflank-mailman (input) for mailman id 103228; Mon, 29 Mar 2021 18:47:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQwur-0007LR-SB for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 18:47:09 +0000 Received: from mail-oo1-xc32.google.com (unknown [2607:f8b0:4864:20::c32]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6a5256b5-a160-4ef5-bd29-0fd555bcfb87; Mon, 29 Mar 2021 18:47:08 +0000 (UTC) Received: by mail-oo1-xc32.google.com with SMTP id q127-20020a4a33850000b02901b646aa81b1so3198110ooq.8 for ; Mon, 29 Mar 2021 11:47:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a5256b5-a160-4ef5-bd29-0fd555bcfb87 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3ocqKDylW1ZNXFNbmp0rk66cJmvs5eErDPFuhhnmcwI=; b=d0zq4ywnBUnaGqRda3SNcvgHibeebslUVJ0IXRSZtdUhAZtqMEOFdxdh5uHeEYB5QF 7V7lTgKpwzldEGrw8jwo/l6n97P5vnlM90qmalKVPegrRmMwcujiz5jfTnnSu4es6JE+ iYkdzk8evVYnfRHGMwcsK6Vv5PGK/Mhswpg6KjrlroXe++Ur92lQxd5Os7rINLUAGKof x4LPCoxQPCaBHnLukcraN1B80oYXwGZZ37PvuH3XaB4IKOh2Ncv6I9wQu7Ojhkzf3o5E AiR6ayD+0ccc44rekBSE/aMgTEonQ+0TPSZ2Uc1vMdF3S//kWRQZc2m4s+nqSaBZ73E+ owXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3ocqKDylW1ZNXFNbmp0rk66cJmvs5eErDPFuhhnmcwI=; b=lxqZPzj+G12MdO3hJbEEqExVN3FEfFDStMg+Ye5M5GWvQ1rrnIEKRMV2dj1Ux4cgm5 n5qrUiSI0DGVMgFrTV9dDqsrZPqSsvllwsLw4JI3Y9JS5Daya77HUB5/PVjkmzFQontk xNIs26wq4ruXEsWj4gtco5dZ8o4X5AkU09Pzn/idVe5/+FArHPLUgypUVlaYH8d2WFFn gdkwcwN+bwKAVliKlBZ0Jd6Ouer8HGvhLBgEmPPr61dGhwfevJek6Ug4Ds1hOoz4uA/W sN1b/UsoZ0HWHlPwhNiHc02aH4yKDCEkDJqgKX6GGxVHWjppYgeGDlgP//9vurVPKeRa l2rA== X-Gm-Message-State: AOAM531ECBRk8cgdLJXIwjM9OlPTMwuYfGMhQ011LzlZ9Q+RSYMGXa17 6H5NHfxW1tHSDOp9FzP1ejkDaLR6CGGTxXL3r78= X-Google-Smtp-Source: ABdhPJziZOZlCS036I60U840Y6K8xRc/0qc99dnwwLVNHc236c3g3mm8yMLA/v69hZSK7YW+SA+lq4g26hMOlugHpsM= X-Received: by 2002:a4a:1ac3:: with SMTP id 186mr4176430oof.8.1617043627657; Mon, 29 Mar 2021 11:47:07 -0700 (PDT) MIME-Version: 1.0 References: <889B1827-1FEB-4AC0-9002-278337D19ED5@citrix.com> In-Reply-To: <889B1827-1FEB-4AC0-9002-278337D19ED5@citrix.com> From: John Simpson Date: Mon, 29 Mar 2021 21:46:49 +0300 Message-ID: Subject: Re: An error due to installation that require binutils package To: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Cc: "gcc-help@gcc.gnu.org" , Community Manager , George Dunlap Content-Type: multipart/alternative; boundary="000000000000034cd405beb14f97" --000000000000034cd405beb14f97 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, Kindly ask you to have a look at this bug. Thank you for your replies. On Mon, Mar 29, 2021 at 7:07 PM George Dunlap wrote: > John, > > Thanks for your report. Can you post your bug report > xen-devel@lists.xenproject.org ? > > The bug is in the compilation of QEMU, which is an external project; so > it=E2=80=99s possible that we=E2=80=99ll end up having to raise this with= that community as > well. > > Thanks, > -George Dunlap > > > On Mar 28, 2021, at 2:26 PM, John Simpson wrote: > > > > Hello, > > > > Just forwarding this message to you. Can you give some thoughs about > this? Thanks a lot. > > > > > > ---------- Forwarded message --------- > > From: Alan Modra > > Date: Sun, Mar 28, 2021 at 2:21 PM > > Subject: Re: An error due to installation that require binutils package= . > > To: John Simpson > > Cc: > > > > > > On Sun, Mar 28, 2021 at 12:55:23PM +0300, John Simpson via Binutils > wrote: > > > BUILD pc-bios/optionrom/kvmvapic.img > > > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > > > > -no-pie is a gcc option. Neither -no-pie nor --no-pie is a valid ld > > option. The fault lies with whatever passed -no-pie to ld. > > > > -- > > Alan Modra > > Australia Development Lab, IBM > > > > > > > > ---------- Forwarded message --------- > > From: Andreas Schwab > > Date: Sun, Mar 28, 2021 at 2:17 PM > > Subject: Re: An error due to installation that require binutils package= . > > To: John Simpson via Binutils > > Cc: John Simpson > > > > > > Please report that to the xen project. ld -no-pie doesn't have a usefu= l > > meaning. It used to mean the same as ld -n -o-pie, which sets "-pie" a= s > > the output file name. > > > > Andreas. > > > > -- > > Andreas Schwab, schwab@linux-m68k.org > > GPG Key fingerprint =3D 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA A= EC1 > > "And now for something completely different." > > > > > > > > ---------- Forwarded message --------- > > From: John Simpson > > Date: Sun, Mar 28, 2021 at 12:55 PM > > Subject: An error due to installation that require binutils package. > > To: > > > > > > Hello, > > > > Recently I got a following error due to installation xen on > 5.11.6-1-MANJARO kernel: > > > > GEN target/riscv/trace.c > > GEN target/s390x/trace.c > > GEN target/sparc/trace.c > > GEN util/trace.c > > GEN config-all-devices.mak > > make[1]: Entering directory > '/home/username/xen/src/xen-4.14.1/tools/qemu-xen/slirp' > > make[1]: Nothing to be done for 'all'. > > make[1]: Leaving directory > '/home/username/xen/src/xen-4.14.1/tools/qemu-xen/slirp' > > BUILD pc-bios/optionrom/multiboot.img > > BUILD pc-bios/optionrom/linuxboot.img > > BUILD pc-bios/optionrom/linuxboot_dma.img > > BUILD pc-bios/optionrom/kvmvapic.img > > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > > make[1]: *** [Makefile:53: multiboot.img] Error 1 > > make[1]: *** Waiting for unfinished jobs.... > > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > > make[1]: *** [Makefile:53: linuxboot_dma.img] Error 1 > > BUILD pc-bios/optionrom/pvh.img > > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > > make[1]: *** [Makefile:53: linuxboot.img] Error 1 > > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > > make[1]: *** [Makefile:53: kvmvapic.img] Error 1 > > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > > make[1]: *** [Makefile:50: pvh.img] Error 1 > > make: *** [Makefile:581: pc-bios/optionrom/all] Error 2 > > make: Leaving directory > '/home/username/xen/src/xen-4.14.1/tools/qemu-xen-build' > > make[3]: *** [Makefile:218: subdir-all-qemu-xen-dir] Error 2 > > make[3]: Leaving directory '/home/username/xen/src/xen-4.14.1/tools' > > make[2]: *** > [/home/username/xen/src/xen-4.14.1/tools/../tools/Rules.mk:235: > subdirs-install] Error 2 > > make[2]: Leaving directory '/home/username/xen/src/xen-4.14.1/tools' > > make[1]: *** [Makefile:72: install] Error 2 > > make[1]: Leaving directory '/home/username/xen/src/xen-4.14.1/tools' > > make: *** [Makefile:134: install-tools] Error 2 > > =3D=3D> ERROR: A failure occurred in build(). > > Aborting... > > > > Currently I have fresh binutils 2.36.1-2 and it seems to me that the > issue is related to this part of code: > > > > https://github.com/bminor/binutils-gdb/blob/master/ld/lexsup.c#L451 > > > > It seems to me that this could impact far more users than just me. > > > > --000000000000034cd405beb14f97 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

Kind= ly ask you to have a look at this bug.
Thank you for your re= plies.

On Mon, Mar 29, 2021 at 7:07 PM George Dunlap <George.Dunlap@citrix.com> wrote= :
John,

Thanks for your report.=C2=A0 Can you post your bug report xen-devel@lists.xenproj= ect.org ?

The bug is in the compilation of QEMU, which is an external project; so it= =E2=80=99s possible that we=E2=80=99ll end up having to raise this with tha= t community as well.

Thanks,
=C2=A0-George Dunlap

> On Mar 28, 2021, at 2:26 PM, John Simpson <ttr9droid@gmail.com> wrote:
>
> Hello,
>
> Just forwarding this message to you. Can you give some thoughs about t= his? Thanks a lot.
>
>
> ---------- Forwarded message ---------
> From: Alan Modra <amodra@gmail.com>
> Date: Sun, Mar 28, 2021 at 2:21 PM
> Subject: Re: An error due to installation that require binutils packag= e.
> To: John Simpson <ttr9droid@gmail.com>
> Cc: <b= inutils@sourceware.org>
>
>
> On Sun, Mar 28, 2021 at 12:55:23PM +0300, John Simpson via Binutils wr= ote:
> >=C2=A0 =C2=A0BUILD=C2=A0 =C2=A0pc-bios/optionrom/kvmvapic.img
> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie= ?)
>
> -no-pie is a gcc option.=C2=A0 Neither -no-pie nor --no-pie is a valid= ld
> option.=C2=A0 The fault lies with whatever passed -no-pie to ld.
>
> --
> Alan Modra
> Australia Development Lab, IBM
>
>
>
> ---------- Forwarded message ---------
> From: Andreas Schwab <schwab@linux-m68k.org>
> Date: Sun, Mar 28, 2021 at 2:17 PM
> Subject: Re: An error due to installation that require binutils packag= e.
> To: John Simpson via Binutils <binutils@sourceware.org>
> Cc: John Simpson <ttr9droid@gmail.com>
>
>
> Please report that to the xen project.=C2=A0 ld -no-pie doesn't ha= ve a useful
> meaning.=C2=A0 It used to mean the same as ld -n -o-pie, which sets &q= uot;-pie" as
> the output file name.
>
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint =3D 7578 EB47 D4E5 4D69 2510=C2=A0 2552 DF73 E780 = A9DA AEC1
> "And now for something completely different."
>
>
>
> ---------- Forwarded message ---------
> From: John Simpson <ttr9droid@gmail.com>
> Date: Sun, Mar 28, 2021 at 12:55 PM
> Subject: An error due to installation that require binutils package. > To: <b= inutils@sourceware.org>
>
>
> Hello,
>
> Recently I got a following error due to installation xen on 5.11.6-1-M= ANJARO kernel:
>
>=C2=A0 =C2=A0GEN=C2=A0 =C2=A0 =C2=A0target/riscv/trace.c
>=C2=A0 =C2=A0GEN=C2=A0 =C2=A0 =C2=A0target/s390x/trace.c
>=C2=A0 =C2=A0GEN=C2=A0 =C2=A0 =C2=A0target/sparc/trace.c
>=C2=A0 =C2=A0GEN=C2=A0 =C2=A0 =C2=A0util/trace.c
>=C2=A0 =C2=A0GEN=C2=A0 =C2=A0 =C2=A0config-all-devices.mak
> make[1]: Entering directory '/home/username/xen/src/xen-4.14.1/too= ls/qemu-xen/slirp'
> make[1]: Nothing to be done for 'all'.
> make[1]: Leaving directory '/home/username/xen/src/xen-4.14.1/tool= s/qemu-xen/slirp'
>=C2=A0 =C2=A0BUILD=C2=A0 =C2=A0pc-bios/optionrom/multiboot.img
>=C2=A0 =C2=A0BUILD=C2=A0 =C2=A0pc-bios/optionrom/linuxboot.img
>=C2=A0 =C2=A0BUILD=C2=A0 =C2=A0pc-bios/optionrom/linuxboot_dma.img
>=C2=A0 =C2=A0BUILD=C2=A0 =C2=A0pc-bios/optionrom/kvmvapic.img
> ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > make[1]: *** [Makefile:53: multiboot.img] Error 1
> make[1]: *** Waiting for unfinished jobs....
> ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > make[1]: *** [Makefile:53: linuxboot_dma.img] Error 1
>=C2=A0 =C2=A0BUILD=C2=A0 =C2=A0pc-bios/optionrom/pvh.img
> ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > make[1]: *** [Makefile:53: linuxboot.img] Error 1
> ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > make[1]: *** [Makefile:53: kvmvapic.img] Error 1
> ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > make[1]: *** [Makefile:50: pvh.img] Error 1
> make: *** [Makefile:581: pc-bios/optionrom/all] Error 2
> make: Leaving directory '/home/username/xen/src/xen-4.14.1/tools/q= emu-xen-build'
> make[3]: *** [Makefile:218: subdir-all-qemu-xen-dir] Error 2
> make[3]: Leaving directory '/home/username/xen/src/xen-4.14.1/tool= s'
> make[2]: *** [/home/username/xen/src/xen-4.14.1/tools/../tools/Rules.m= k:235: subdirs-install] Error 2
> make[2]: Leaving directory '/home/username/xen/src/xen-4.14.1/tool= s'
> make[1]: *** [Makefile:72: install] Error 2
> make[1]: Leaving directory '/home/username/xen/src/xen-4.14.1/tool= s'
> make: *** [Makefile:134: install-tools] Error 2
> =3D=3D> ERROR: A failure occurred in build().
>=C2=A0 =C2=A0 =C2=A0Aborting...
>
> Currently I have fresh binutils 2.36.1-2 and it seems to me that the i= ssue is related to this part of code:
>
> https://github.com/bminor/bi= nutils-gdb/blob/master/ld/lexsup.c#L451
>
> It seems to me that this could impact far more users than just me.
>

--000000000000034cd405beb14f97-- From xen-devel-bounces@lists.xenproject.org Tue Mar 30 05:30:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 05:30:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103321.197164 (Exim 4.92) (envelope-from ) id 1lR6wu-0005UN-GM; Tue, 30 Mar 2021 05:29:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103321.197164; Tue, 30 Mar 2021 05:29:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR6wu-0005UG-Aq; Tue, 30 Mar 2021 05:29:56 +0000 Received: by outflank-mailman (input) for mailman id 103321; Tue, 30 Mar 2021 05:29:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR6ws-0005U0-Lx; Tue, 30 Mar 2021 05:29:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR6ws-0004Km-C0; Tue, 30 Mar 2021 05:29:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR6ws-0005pS-2b; Tue, 30 Mar 2021 05:29:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lR6ws-0006iy-26; Tue, 30 Mar 2021 05:29:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tuZX6TfAo8/Rvw+bSa3+gTPvgu825R8735IYIpyMcek=; b=BrlP/2I2E7jhaO8COpEeKx3v9T XgpbT0cZrmj03go36rSE1Flr0lr6oGSaNzRfRG4Z9p8CN8R1HoaDyn6Wp5c8AWycuRVLSVhDyCOV0 01OqcpV+6C3rbx6cDXAQ0oDZZHE9ysbYWB1SbjwPGMw1/rmq708tyuEoX31vwWjz5/X4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160529: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Tue, 30 Mar 2021 05:29:54 +0000 flight 160529 xen-4.12-testing real [real] flight 160547 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160529/ http://logs.test-lab.xenproject.org/osstest/logs/160547/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail REGR. vs. 159418 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 41 days Failing since 160128 2021-03-18 14:36:18 Z 11 days 12 attempts Testing same since 160150 2021-03-20 04:11:48 Z 10 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 30 06:25:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 06:25:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103332.197182 (Exim 4.92) (envelope-from ) id 1lR7o2-0003I4-Rd; Tue, 30 Mar 2021 06:24:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103332.197182; Tue, 30 Mar 2021 06:24:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR7o2-0003Hx-OV; Tue, 30 Mar 2021 06:24:50 +0000 Received: by outflank-mailman (input) for mailman id 103332; Tue, 30 Mar 2021 06:24:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR7o1-0003Hp-TZ; Tue, 30 Mar 2021 06:24:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR7o1-0005HP-NR; Tue, 30 Mar 2021 06:24:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR7o1-0000FB-Bz; Tue, 30 Mar 2021 06:24:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lR7o1-0007P2-BT; Tue, 30 Mar 2021 06:24:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HfMBmBtmUImcKlPOX/57TK62xxwTTRs0+bYJzfUTFWg=; b=Jamw/68Oo1bySgTh4yjwiOP6/m FoH+I5TP6gpoBDSSWPPT9v60HWRwCV3AQ57LRcPRNjysRX3QBntIDY/SLHcIXkbY0aUlvXTOyZqhQ yFkYci6iL9exkkexJ3psY5dRxoY34n6HTSqVKjyq8JagVhU7rIdJqFSC4hN6kFbJmebg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160546: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=dfbe4f4c9bbfaf01bb865c617674420199b1f1b5 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 30 Mar 2021 06:24:49 +0000 flight 160546 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160546/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt dfbe4f4c9bbfaf01bb865c617674420199b1f1b5 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 263 days Failing since 151818 2020-07-11 04:18:52 Z 262 days 255 attempts Testing same since 160546 2021-03-30 04:19:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 49276 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 30 06:52:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 06:52:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103339.197200 (Exim 4.92) (envelope-from ) id 1lR8EA-0006PW-4T; Tue, 30 Mar 2021 06:51:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103339.197200; Tue, 30 Mar 2021 06:51:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR8EA-0006PP-1A; Tue, 30 Mar 2021 06:51:50 +0000 Received: by outflank-mailman (input) for mailman id 103339; Tue, 30 Mar 2021 06:51:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR8E8-0006J4-Iw; Tue, 30 Mar 2021 06:51:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR8E8-0005hU-C0; Tue, 30 Mar 2021 06:51:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR8E8-0001fI-0N; Tue, 30 Mar 2021 06:51:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lR8E7-0003ZH-WC; Tue, 30 Mar 2021 06:51:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=I3pDwnxCJdrI/fZ74om7Eg9QoTFqG4m2DoZ3IoQ9SVM=; b=sQTw1Tc2QXz5jQBEzgyKcpXnCU H8yW3NK4IOtUv/NXFwXSE8Uw2oe5RSXj+TYVakSSJpnPwUJoCGCMwYEAbKWUFa3SsUK7A3+pi/rxH JESrI5z3Er+Nk5dWK6QjaNy7iV33V1ehPUr07CNwLvSaMGKKoUyy3/IMY50uYiB1X6FY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160532: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a5e13c6df0e41702d2b2c77c8ad41677ebb065b3 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Tue, 30 Mar 2021 06:51:47 +0000 flight 160532 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160532/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-examine 4 memdisk-try-append fail in 160516 pass in 160532 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 160516 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux a5e13c6df0e41702d2b2c77c8ad41677ebb065b3 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 241 days Failing since 152366 2020-08-01 20:49:34 Z 240 days 410 attempts Testing same since 160516 2021-03-29 01:40:59 Z 1 days 2 attempts ------------------------------------------------------------ 5271 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1311071 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 30 07:37:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 07:37:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103348.197214 (Exim 4.92) (envelope-from ) id 1lR8vi-0002Jp-LF; Tue, 30 Mar 2021 07:36:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103348.197214; Tue, 30 Mar 2021 07:36:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR8vi-0002Ji-Hz; Tue, 30 Mar 2021 07:36:50 +0000 Received: by outflank-mailman (input) for mailman id 103348; Tue, 30 Mar 2021 07:36:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lR8vg-0002Jd-Kj for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 07:36:48 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cab94b86-5019-4269-bc46-c910418c3c95; Tue, 30 Mar 2021 07:36:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cab94b86-5019-4269-bc46-c910418c3c95 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617089807; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Mg3f2tInI3XQfEfu0YLCafyhfelZUjhIiyxCrmiLubw=; b=IGcBjVXZTA1Ci1dBipSY6IhvUPjCqseK1tefh6uE+dv0nL3057v/NW4W A77uR8mdk5Ctl0AYe+quk7Ha5xkRsGGxt66HagdAG2Ozdmjx7ahaRIFvW ugWdCDGj2zG/pzhU0mHiznFcIsXKugNzGeOtFFUZBkcrzLFnnqpR3lles M=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: WxKklPlqZSGexaY34wYBVWt73qHxfuy8l4nrmipXy1TNpGz6ZSIhgwTIjQYyh8ZeszBzSORGpw cVhuoe2pkVHXXLhe5XXsFojXmkF6ibak0YI2YkH2L5P0Uw7EBHPwQ9Xt44REiPhbEFvhHRDOXn SGShtJGty3oy2jd54ltCT2b/ni6OK9n5g5Gf3Sj8ufqhaxJWlGTkHGFzibIvB40Elw6/GAzD/6 Beb1fR0JupHMc9CDk0vOtUVO+DJ20IIuKj3ESc6CnxYxvyBEFppDWt/RgQzjZUep/2h+f6TMkf Bco= X-SBRS: 5.2 X-MesageID: 40424356 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:rGgBWa6747ApFaST3APXwXiEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoexzh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdxHW3tV2kZ 1te60WMrDNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2BXQotLhj0JbTqzOEtwWQVAGN4VFI CE4NBGujqnfh0sH76GL1MCWPXOoMCOqYnvZgQICwVixA6Fiz6p77CSKWnk4j41VTRTzbA+tV XUigCR3NTZj9iX6D/5k1XS4ZNfhcf7xrJ4avCkp8AJJlzX+2SVTat7XbnqhkFRnMiO7xIQnM DIs1McOa1Img/sV0WUhTeo5AX6yjYp7BbZuC+lqF/uu9bwSj5/K+cpv/MhTjLj50AtvM5x3c twtgrz3fonbmKzoA3H69fFTB1snEavyEBS6dI7tHBDTZAYLIZYsI13xjIlLL47ACn45Io7ed Meav302fA+SyL/U1np+kNrwNCqQ00pGAaHTkUoqqWuokZrtUE84E0CyMMFmHAcsLo7Vplf/u zBdp9ljbdUU6YtHO5ALdZEZfHyJn3GQBrKPm7XCVP7FJsfM3aIj5Ls+r066MyjZZRg9up8pL 3xFHdj8UIicUPnDsODmLdR9ArWfWm7VTPxjulD+plQoNTHNfrWGBzGbGprv9qrov0ZDMGece 20IohqD/jqKnarMZpV3jf5R4JZJRAlIYwok+d+f2jLjtPAK4XsuOCeWu3UPqDRHTEtXX66LW AEWBT1OcVc/mGmUnL1m3HqKjHQU3262ag1PLnR/uAVxoRIHJZLqBIphVOw4dzOCTAqiN1yQG JOZJfc1o+rr2i/+mjFq09zPABGM0pT6LL8F1dDpQoANVLIYa8O0u/vPVx67T+iHFtSXsnWGA lQqxBc4qSsNaGdwigkFpaBPn+FiWAQ4FaHVY0VlKHGxcqNQOJ3Mr8WHIhKUSnbHR18nghn7E 1ZbhUfe0PZHjTyzYO/jJIVA+nbX8JmgBiiJPNVrX63jzTemegfAl8gGxK+W8+ehggjAxBOgE dqzqMZiL2c3Qq0JXAHm+Q+Ol1UYGGxCLZLZT71I7l8q/TOQkVdXG2KjTuVh1UWdnDx/0sfvG DnMBaZYOrGGFZbp3Be3Jv76V8cTBTvQ2tALlRB9aFtH2XPvXh+ldWGYae+yEO9QFoPyON1Ck CPXRIiZidVg/yn3h+cnziPUUg8zpI1J+rHEfAIaLfIwE6gL4WOiIALF/JZ54xeKdjrq+MHON jvPTO9HXfdMacEygaVrnEqNG1Is3Eii+rvwwCgw26i3nIzaMCiVmhOdvU+GZW74GflTfrTj8 k8otIxoOeqMmL+LvSB0rraajZfKhXV5U66JttY3ax8jOYXjv9UGZKebB7jkFdg9z86JN3vlE wfTL9giYqxcrNHTog3QWZh4lEtlN6zN0MlvQz9P/8mcTgW/grmFuLMx4CNlKEmDUKArjbhIF Wz8yVS+PHeQiuIvIRqfJ4YECBzaEIm7m5l8/7HX4rMCB+yf+UrxivxDlaNNJtcQrOCA7Mes1 JT5MyJhfaec27d1BrLtTV2ZoJI/GDPe7L+PCu8XcpJ+ce9I1KCn++D59Oyli7+TX+DUHsj7L c1PHA4X4BkkTktjIo+zyi0ROjWmyse4iRjyAAisEXs1Iig6HrcBmdcP2Ti88xrYQU= X-IronPort-AV: E=Sophos;i="5.81,290,1610427600"; d="scan'208";a="40424356" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cZt756R/PvSgMhSjqcFoX8psWt/GEaACfYWPyvfl68NRM2ucA8lMZIdCizRLlTEirWr3Veu3yiIa90Rqzcz2Oy+dS9AAGpiaIQBPO8f/p8/4xUtdRZrg5hUymiFKtUQE1xSG4z3hUpjeLPTd5QYzwZd8gpP/ONf0W/zqJ8wQFpmP3nXDEA8q32c+ME7pQF0rAAHTmFjTxnXa+En56y2ZmZGI0cLHBx2TI3kNPvYzO0hHScsu+mxFoWRoecU3UCdG0eMdca2lY6X+N43O2zaxGj149IHs8bp8XFbDtFfEzsfIkqtK4nLouSN1h/k2l5FNYniqqI5aY0//b2EiX897rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=525GPiB0IPOPfB0ATOYfQQh19wiwQ8jGEvUEH8Nje6g=; b=e2Z4I0ziZHVhDlJ1roE8JCBgMkixzhPUacUfOzhKWyrnJr3+KAR2gcgZLG5jdSMnhX3fm18BFb9UrD7/bn+buNZN8VQlujLMv75b0zoFvVEUGmx3yKaw4mG5k8XgTznU7bDItBcJAdsgrB2TlvLW+JFtpIABkFXS2L96wMBAW8yz7g70Wm7khUnYRPDB3uyyhAF5RXhG3n8FWFhWSzO9Q9rnjtlHzInNcndtigbBRsMHadyUxD4HFRXehqiVCWiut7LLgi6XKNpPs/qUe9L3A8pSqkdvR9Y6evi7kjOszfxlKuvVwJ3NwwEn6oyHqA69dgoVPkn3LkZRktzVEza7rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=525GPiB0IPOPfB0ATOYfQQh19wiwQ8jGEvUEH8Nje6g=; b=ZhnaWfj4f+XXYnQ3BBu34M2IVhVf0wF1U3fPsZF7d+PN9LoU/nn4vNd8liPLeEjV6+SJXioYWRc02Jlnlul1dgUhhGGhN4cfRRhJVFUrVxZo5xz5Dfcvh4Oyl5Isxa2Ou9yBVJHjb/85RIc9/qKWPl0WoFSZB1XrWiX5+o5qSAI= Date: Tue, 30 Mar 2021 09:36:15 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Boris Ostrovsky CC: , , , , , Subject: Re: [PATCH v3 2/2] x86/vpt: Simplify locking argument to write_{un}lock Message-ID: References: <1617052502-14181-1-git-send-email-boris.ostrovsky@oracle.com> <1617052502-14181-3-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1617052502-14181-3-git-send-email-boris.ostrovsky@oracle.com> X-ClientProxiedBy: PR3P189CA0052.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::27) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d0115518-29b5-41c4-f057-08d8f34e82fc X-MS-TrafficTypeDiagnostic: DM6PR03MB4140: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PRH2XRv30afaTpP8lgfvjebNtsAeYV68NMVGYwQWzjuiA2RSH9vKdmvk1QRzsos2X7Sy10pKfFPhJ/5nY1UUInffSTkyyRb3IKSbSS9tdfI2+kq6I+Ue7KyM4uVMSzUzONClAuZt+SVXTPToBYP68JuwduWmmgx1XZnyUuAe2ZCHucXe5X13pR11pkpWYghcC70sbc+0dNmPcUkZOAdL+0utx3oqazxNJ0Cq/ym21qol5HrhLr2zTLrXyj+V1xlarVpKCatq+CXC9fFIoPsKghs28nuUeRjTLZ0y4EhAgKkCqAnvQwhR9hM4SbKsy7rPXFtZIggZYFmpulcdqEvqWVTZFxDb2sy3VHR3D5bX/D3P/59GFKZdpwHUTNoQ4bPlJ1XcjTZAxVzhKwX8xxKd8+lv7Os2OP0ntr4C9mtKErUS8MouzwcGz9ywYst22rrLEDN4D9Bllf7wQTxl2yPydYdk+PSnppv4ntlwSB74AAmypSK9XxV6qeigJ6Fa26JwY6kYnz8Zf/0r8E3/CMKg7kNppuYv/us6a6cjqEruOa8Wq8RLLZpFQhXblv+JKh0qJ7BdPVBh12YQjq2hYt7udb8iU8VGR++GYyN8UZPXyXx/knb99w2ZayOmQm5RH6bSSROsgB2RokrShYD5XpIo/6ICyQpWSqwrwkjT1rr7Xm8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(136003)(376002)(346002)(366004)(396003)(39860400002)(6666004)(5660300002)(85182001)(956004)(6496006)(4744005)(26005)(33716001)(2906002)(478600001)(38100700001)(186003)(4326008)(16526019)(66476007)(66946007)(83380400001)(86362001)(8936002)(8676002)(6486002)(6916009)(66556008)(316002)(9686003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bUZiT2t6R2Y3dkxyZFR6bnp4SDFPYXFzd2h4V1hzRHlvbCt5ZEZFSFdwOU9r?= =?utf-8?B?bm0wZmdyQVVac3ZuWG1zbG81aEJMYlJHeTF6OUozOU9QZENhYlBIOW1pRmVh?= =?utf-8?B?VnpUNTFJV3FGMm1meXBVWXhRYU5aa21iamhNOVJ4ZTVHc3ZjL3NTTFpwancr?= =?utf-8?B?dG96cW1OenpncE5GN3h3c0FsdXpJd2YxRWNwWVVZVEl1UVdnNnMrNVFxenUw?= =?utf-8?B?a2NPcWJ5YU9LeHV1VFMwSjVCamgvYmYzeEM2N21jeGpWK0c2VDVtWGo5YXkz?= =?utf-8?B?dTZQSHlEYy9NQUx4eVRJWngwTmVWa3VSMTB1Nk9XSVhDY005R3RaZnhaM2V4?= =?utf-8?B?enNyZXBWOVdyV0dNU2tsZFM5dkdsMExJbmxsOUxUSnRsZlNEa3owcmZJdnp3?= =?utf-8?B?VCt0MWJmdE9DL3ZXZ1dzazcyVnFOMGVSNGhoYTZCVFc0clFwVDlGYitGeHpj?= =?utf-8?B?WmQ3OWZjdmdjNHprMzRITzgwNVc1Uy9BNGdXeWNPMk1LazhDZGdqK2NibFZC?= =?utf-8?B?UEViZWlTdlR0U1h6d2xEVVY0RE5XRUppNzJMeTgvOFA1YXVwSXFKdVRRN2Fa?= =?utf-8?B?VEQ4b2tmZWtrclgvRjZnaGFZYjRiTVI5Y1Z3QnZLRWVIR2dmNC9kdkhuVEU1?= =?utf-8?B?N2U0b3R6RDFvMVZmbkc4cFgyOXFqRjA2N3VmT2FkVy9NMWFwdWZTbHJjWWow?= =?utf-8?B?dHltcU44WVQ2REs2RG9kNG5YZFlaQkFnZnl5Y2dTL1lBZnRzTUhPYXUvMG9M?= =?utf-8?B?OVZjWjZDMDd3b2lhOG1VUXJLNUxvd2o0RG9wRXlVcFUySWtoMUFNNTNqVVBZ?= =?utf-8?B?S0N5K0F1RGtWV09TOVA0UG9yUk5pNGxyTUxDRXhodGtrSDdZbEJYbW9BdEU4?= =?utf-8?B?cVBLb3lGYks2c29qRkcwY1dmV3YreEJDa09Ed1kwTlI4ZUhVSFR6R3BVc1hG?= =?utf-8?B?aGlWQkEzUVdiYWRGKzBkeDQraHdVQjc3azUvT1hKdzhQS2xQQ1dPU0tzb0xF?= =?utf-8?B?VU9admxXb0pIU3RNZ1BsUjJseUVuRXprelZEdXF2aWJvbHJoTXV0cUpvM094?= =?utf-8?B?cEkvZGE1NmdmWlpIbWpab3MzUFpaNllLcVRwK0k0ak5lS2pxZTlSNmQwZmc0?= =?utf-8?B?Y3VpSjJVVnNOUExHa0Y4d1VaSmQ0WFc4OEs2djB5R0dDSjN4cURXVlFnQXht?= =?utf-8?B?VHZ5bU5BazhFaVBwUk5ZelRiR21ROXBiRVpNOXVOSFV5eXRSRUhPL0tEaTEz?= =?utf-8?B?Yk1YWGVBcUNMY0FjUGs1YWpIZ3dldEhMZW9RbjY2YUUrdDY5Z2sxT01PT0Rs?= =?utf-8?B?UG1GYTE3cnZFRVVyYUxBZUZvYzhPdTE1OENabVoxZTJDcms2SGF1Y1J6QXR4?= =?utf-8?B?Z1BRQ2ozTnFtZnRoaUZGL3NPeVZWdnpNOFllYmRYSWFQZFV0YkhaeE9hc0Ji?= =?utf-8?B?VlduRnRDSlF6WlJNZ0hyV0xhL3B0UjBHUVlaQndSSGF4U0lOL1B4d0s0clZl?= =?utf-8?B?TzFKa1c1cTM5UWZiUHBBc28zaGZJNitzYzFkV1k5UVduN1UrWWNtNnFsbm0z?= =?utf-8?B?U09vZEpkNEtBSWpEU3VHekg2Zy9NcmlqSFBPT2EyUHQ1TjQwY2VhRzFTOTFo?= =?utf-8?B?Qlh1d3lSRXc0cDFiUU1tTzdMT1NBTDVuczB5aDhUSUo0NVd5N0syeWgrN3JR?= =?utf-8?B?RThXMjN6Y211Qzk1UWlVS2ZuWlBvSlZiTlpJQWVmbmgxZTRGeVAyanBDQ0tN?= =?utf-8?Q?5vJ/YOz21PTeSj8Iry/A18hPiYmdFir1c5RZlGY?= X-MS-Exchange-CrossTenant-Network-Message-Id: d0115518-29b5-41c4-f057-08d8f34e82fc X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2021 07:36:20.4793 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E7/ZMGTGK5F1WxdioqW9SdbcvQH/HM71EQFMiFvy2MS5bxl2CQ7OO3VFSVuOncU8dUgnHB1O0KnL7Brtsj6dkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4140 X-OriginatorOrg: citrix.com On Mon, Mar 29, 2021 at 05:15:02PM -0400, Boris Ostrovsky wrote: > Make both create_periodic_time() and pt_adjust_vcpu() call > write_{un}lock with similar arguments. > Might be worth adding that this is not a functional change? > Requested-by: Jan Beulich > Signed-off-by: Boris Ostrovsky Either way: Reviewed-by: Roger Pau Monné > --- > New patch. > > I ended up doing what Jan asked --- create_periodic_time() is also using different > start pointers in lock() and unlock(). Hm, I'm not sure I'm following, create_periodic_time uses 'v' in both write_{un}lock calls, which doesn't change across the function. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 30 09:57:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 09:57:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103369.197237 (Exim 4.92) (envelope-from ) id 1lRB6y-0000KX-0s; Tue, 30 Mar 2021 09:56:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103369.197237; Tue, 30 Mar 2021 09:56:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRB6x-0000KQ-U1; Tue, 30 Mar 2021 09:56:35 +0000 Received: by outflank-mailman (input) for mailman id 103369; Tue, 30 Mar 2021 09:56:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRB6x-0000KL-5Z for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 09:56:35 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3690e601-9868-46e5-beae-7c83b0c77012; Tue, 30 Mar 2021 09:56:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3690e601-9868-46e5-beae-7c83b0c77012 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617098193; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=hnTQfbeHg9DlXTMhtf1bN2bhCY5ExhlaxHfBfwMaJH8=; b=UObq7MP6exa9v0Ht66sWqO7tjmEy10tHqO0MJbg27rnJGQJnQMt31GmF 2heGXnGa2VTBEcwuq4gRP3F9+aya7gEibWzg083RFm3OyT1c3Q9uFnhe3 jgPqRoRH2IvRbLOv1F0CYpz30SDTRXSjuVg5z4oML1OtGFzBq35Evi8fA E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 1tif6AZsf7cOzvaQR71sxL7vL8h5TXylpMPdhdLyZ+kPNsVOoOXeXW57R1PU3FKfvfmMP4Not0 +O2GmwGPyWRQ16ktGzbXgZWb/ZSyKum4kPuff745XpVr9Bfhv+v/wdn6/Hvp3eHKIULyN0JDBF AQlsdGc495NrIss/uF+q7WsGnjOAGvrgDl+AZNDd6xKE/eIR03ZvURGzuOZGVXZqm3jEoelUWI 7FZZwAETbs5ShIvZ8uty4nJMIoCOw7Pe4+bSEaUtcpEIjx9GsDvPcAzbrtevqbytW7/y5Vzrog WEw= X-SBRS: 5.2 X-MesageID: 40433689 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Pv4vIqliAN3VsUDVBHj0/E83GpfpDfP+imdD5ilNYBxZY6Wkvu izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/NIyKMaVI3DYCDNvmy0IIZ+qbbz2jGIIVybysdx94 dFN5J/Btr5EERgga/BijWQPt48zLC8n5yAqvzZyx5WIz1CT4FFw0NHBh2AEktwLTM2YKYRMJ aH/MJIq36BVB0sH6eGL0IIVeTCuNHH/aiOCXI7LiUq9RWUineQ4KP6eiLy4j4lTzhNzb0+mF K18TDR26PLiZCG4y6Z7UD/xdB8mNztytxMbfb89/Q9G3HXpSuDIKhkU72GljgprO+o80ZCqq ixnz4Qe/5dxlmUUmapoQb8+wSI6kdQ11bSjWW2rFGmgcvlSCk0A8BM7LgpDCfx2g4bk/xXlI dotljp0KZ/PFf7swnWo+XsbVVMkHG5pHIz+NRj9EB3YM8lR5J66bAE8Fg9KuZnIAvKrLoJPc NJF8/m6PNfYTqhHgrkl1gq+tCqU3gpdy32O3Qqi4iQ2zhSqnhz01EV8swZhmsB75IwUfB/lp z5Dpg= X-IronPort-AV: E=Sophos;i="5.81,290,1610427600"; d="scan'208";a="40433689" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l7Dz6Z9lfEUh2BvhZaWnrmSC0fi8nCs9gqZEocgaSS4/Iy4zGVzYQ6X+Khe2aGIYT0mK1qLklnO52HciukytRgADgPFpQPCfQvc+lvFOzbUyqxjKCtpNHMM7dZ69TjLj6vWXMueT1BJKcObV8NwqLTwm+a1LPaq5VkLO93n7QuSjB3FAuAW0fqCaAcOmgKTGfBWmnuj0BmBqFgRlfpCC+Imio5vFvI72WQfaZSi/VwTyZavk35gPVH7deIj1GzxAvmhGdB9hMJxCCiXVER84+l2J5WpZXCU5BQ/spc14wTnYTdVAFhvqwbt6dAh5K3m8oTUrCT5bDjuLkfjpYsbhbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hnTQfbeHg9DlXTMhtf1bN2bhCY5ExhlaxHfBfwMaJH8=; b=NgVohyLJJarnyMKWvdqsSXPt4A6kUlLPwHbo/XG63ES873rYOzT8XD+ChWiCbPcbRop7ft83SNZiKseX2bifY4hy1xseSTgwv/bL94h0B+jVdi+KZhcP2zgJ+zTIdvIYYBSYHwjY96w2CPkzvIs/7/Wj0tEqc1tysTRrp0PeNdnbZl8Oai+t17hxebsbRD/+nF4NAmgYihRx+myM4DYr5nSBY6fS0ajPAq7k0o4ff8bun/g9gF4T8FtSrQqSeNsAQb0IZztwf8yZXSq8lps/v+GhMRBZfT6L8Bi7nOCkpmOPYcSj015XDGU4Bmn6YmWWq1OvmroUJOhIJ0+vi/YRnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hnTQfbeHg9DlXTMhtf1bN2bhCY5ExhlaxHfBfwMaJH8=; b=kbuNy1QiQPHPdQEGf0imf7Fv5Um8594Gu6J3+gAmYLbLu2yXSXVOhRYctQTmaRHByR+fhju3T/j6+JAuwEhai3tUZFsBr97ic7Zv2QVBFwBnvSZZZX7llzVD4p45KUzjulsCJ3PL5LfzOGI71UBWcZjz55N4mocDunRtPBT99fg= From: George Dunlap To: Andrew Cooper CC: Jan Beulich , Ian Jackson , Roger Pau Monne , "xen-devel@lists.xenproject.org" , Paul Durrant Subject: Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code Thread-Topic: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code Thread-Index: AQHXINLTS489UfL61EKD4pjlwXnfbqqUSZCAgAbMCwCAABhsgIAAEbyAgAEUfwA= Date: Tue, 30 Mar 2021 09:56:29 +0000 Message-ID: <2A1FCD39-D0C0-468D-A977-2FBF7126FDE6@citrix.com> References: <20210324172608.302316-1-george.dunlap@citrix.com> <23461afc-c0e0-eb33-9ed3-52f050b6aef0@suse.com> <27ecde00-f0aa-b701-6928-5480ed805064@citrix.com> In-Reply-To: <27ecde00-f0aa-b701-6928-5480ed805064@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b0d61fc6-0862-4c8a-5e58-08d8f362170c x-ms-traffictypediagnostic: PH0PR03MB5733: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8BNjb+aEUJcd3fcrlq4VIPYawCa0q/ycYG8XboLb31H6kzmA+eEzg+LqGYCGFsTKt4C9LcGtO07OIObvS0RGDDw6VdYIoIvBclz2w23IuuNLCWVvmUDo3/0yQveE7Xz0lxKfjqsgbhxrBxw64/5InsbfBN2nKDWulXP96ADw2j5H5c0qajqgzPz5ixCEIZ9ewH0Eoy+QmybXavk4jFZCef0M0MxfN12rs6ngHQh56Z4/HJuyh+NZuCAjvpoGwn2mz+qWPfWvjdAxAWR/DuGryQpx4retqRkocOY2EfSsCPve7iq9t6xiHEnC5768iex10Qe9AUV0RGZTa7alMFpFuvYtzk3ARDRmoPo2gUZ4fd9PQ3xyixAad1yxhoDO6JbsUG/X+bhc8OEUgp8dz9YHJoMRT8QibtUb6g6RRXL+rxMR0twJ2P/hu5Xm+OwuZolQw3PbA35eVdbLYIsVHgw/ZnL06H89xh/S13pYTxo34cR+JFpLYSCF1obo93WQU9O7lRhiIi+AmzaSa37YApZIYbxLIz4Ruqcz4ELuresoglGOUXmOGT8NvwBJnFf4CcXp7bHAWokBXWK9wsq9i091Sb1AviR7PUAJKNwKfATOppACdsDaJHDQsjGhzH8rL61kxLyJs+sw3BBQq79I/T1w9uAo4JSC4xQ3V4dPr50bn+THbrZnRBFUM41yNT0r/fF/ltWfWJzbQEXwJRHhec+Qf6AgPoOIt0O+k2Uh2m5fgf/B0bStHP8hGs6VDbyI6DJ/k6A0T4kOF3pQpd7KBnec62JkJhg/90G2DNg+mM28Qp13Djc6qgkPbidh2zv0F8G9 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(396003)(136003)(346002)(376002)(86362001)(38100700001)(2906002)(71200400001)(2616005)(64756008)(91956017)(6862004)(66446008)(33656002)(966005)(4326008)(37006003)(66556008)(8676002)(66476007)(107886003)(6486002)(6512007)(53546011)(6636002)(6506007)(26005)(316002)(5660300002)(66946007)(186003)(76116006)(8936002)(36756003)(54906003)(478600001)(207903002)(219803003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?bDd3b3FEVENZSzY1WjJLU0h3VVlVbE83YjNjQ0RoRHRNUXZNcjBGMGNCdVJ6?= =?utf-8?B?b2lZYng5RmFNRWVhaVVUTVVMTDV3YVI3SGVZZzlicGVGVlpPK2xVbkNFOXhz?= =?utf-8?B?N1Q0WngvMktLYkdZRTdJdkFXbk9KWHlXWE9OVDFpbS8vcFNndzVJMURzMFFV?= =?utf-8?B?V2RlV1ZSUkNoSWozOWF4SkdNSHJVZkFRVEdUQkdqV0QzVURiYmtCcVpjRHdk?= =?utf-8?B?YkxuMWQyOTFObTlZUTZhWVlCVXpocXM1RlhBelFVQ1NBYTFjeThmV2ZpRjhn?= =?utf-8?B?Q3huVFFXZGlqaG91aDg1akh0S2VWazcwMnB5akJOYjhXR1k2VkZOVXk0Q3RH?= =?utf-8?B?bi83SU9HSHhBejJtdGluWlhreEsyREsrR2UzR3hTY3Flc1JyNVZjT0crSnVs?= =?utf-8?B?bVliL21kRTJjbUh1UFBjcnB6dU1OQjRDZURObTk2NFBUVWRJc1VPNTYvY3Va?= =?utf-8?B?ZUJzdHZMcnhkY3RMZzVrY3dhLzBEZVlvM0FwcFlDdWFCWHJhY3NCcGZMbEpt?= =?utf-8?B?MDc2eFRTOUEzOEtSaFZJbVROdmZGdFZqZ29BWU1RQVJacjFTNXNaRk8zMDRE?= =?utf-8?B?aVFla01KZVNsSmd6SjUxV1YrcVZCQ1VlZVlFNVQyWEx6TVpyazJaZmVSTE9Q?= =?utf-8?B?VnZPem9oNVl4NDkvWDVFckhGcXhoWUtSbEFQZ1VxNHVvQlNENkNxbVRsSEx4?= =?utf-8?B?aXo0MS9qeHBSOHJYNDFGWmdRUEY0ZkhmbnRwc09adG5zYngxa29VcUdKejNp?= =?utf-8?B?c29PdTM4bVVDUnNEZTJsQzN4RTd0MU80WUZ1SEg0Z2orWmRlcGRFMnQ1bUIv?= =?utf-8?B?UUQrMFNHZ0JLK25OYTdWM2ZvYzV4RWlNQ2VzUzhTUlVjMXlsS2dKOVIvUUdE?= =?utf-8?B?MlNCWUFNMlNOQjB6SjdmODdscTh1bDFLd1U4eTBKQml0Tlo3Tk9GVnJLeEwv?= =?utf-8?B?NzNnMWtmYStmSlFMb3Vpa0lXVXR4ZUw4N3Nxa1ZVaG9QZTNzUGp1UUsyYVZr?= =?utf-8?B?aUFzdG9Ycm5BY2VpdmRVbVR4UGVyQlREdjZFbmJGVjM2TTBjbmdNbE42LytK?= =?utf-8?B?L0taMDZIc0tjMnZ4MFJ0Y3ljZEZ0QTQrc1dxWSs4cDg2cTZsWkMxZlorcU5U?= =?utf-8?B?VGhoWG1HVUFiM0JLeHJ2cndxcXBjd05Sbi9Hcjd3b0Q0MjR3cUZEMGNLS0Uy?= =?utf-8?B?UUJiZG5MYmkzd1podlJNZUtINTZwZGw0QlAwaHZFWDBhUEY5VlFxZSttMDV5?= =?utf-8?B?bGMxek5jWlVmNnU5aHRGL2NsZGt1bXZzajNQZ2UyejNsSmN1ODJpeTdPL1pS?= =?utf-8?B?NlNta3VxNWJjSlFlUjlLRDRUVDU4WUlDUDIrSlRSLzRSNXBYVVMrYm1RNTN0?= =?utf-8?B?MjB2UGZHOXJ2WU80Q1ZyeFEzd0FONEVvN2NiRng5bk5iQTF5VjJLbzd2ZStH?= =?utf-8?B?M2hkZWl0OFZwbUkzYjUwZGp6eTA1aVR6M0RuZ2JiMEdvZzNvTlRzYlNJVXlm?= =?utf-8?B?QmE5aSttWVlVQlkzSStralVZZEgySzY4T09sc09KcG9qcDZVWGhjdGVLejdX?= =?utf-8?B?cHZ4aGpXQWdPdHNLR054ZCtjbmgyYmxUS0o5NXFzcndIdjJFbGJKTnNLbDhW?= =?utf-8?B?Ny9KSzE5UUNiQXF4dkExQlZHRS9zbHJpdU5MYmI3UWk0ajdzRU1qRjgvYzYx?= =?utf-8?B?alZUejZ3MUYwS3VNdDRpL1paR1NMMFZDaU9QSGlrZzdkM1ovd2lraElvZm93?= =?utf-8?B?RXYvM00zL2lEd3o0K2NBb25DUVlvRDJIbG55dlVjWTJIbFNic3Q0TDk5cSth?= =?utf-8?B?RVpXUmkxWnlYK0d1MVFJdz09?= Content-Type: text/plain; charset="utf-8" Content-ID: <671ABE92467790449B0BA7B18E2DAABD@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0d61fc6-0862-4c8a-5e58-08d8f362170c X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2021 09:56:29.1388 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5PpmvtG7+QIG3PLwzZveYE7gl0AO4X0xAugbeiK5NMfiQoVhugyGX9rK9njBOkZiSzZw4o9MQ4wRNY9yj1H4E57kVVZA7I0qSUC1xpwuWT8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5733 X-OriginatorOrg: citrix.com DQoNCj4gT24gTWFyIDI5LCAyMDIxLCBhdCA2OjI2IFBNLCBBbmRyZXcgQ29vcGVyIDxhbmRyZXcu Y29vcGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IE9uIDI5LzAzLzIwMjEgMTc6MjMsIEph biBCZXVsaWNoIHdyb3RlOg0KPj4gT24gMjkuMDMuMjAyMSAxODoxMiwgR2VvcmdlIER1bmxhcCB3 cm90ZToNCj4+Pj4gT24gTWFyIDI1LCAyMDIxLCBhdCA3OjA4IEFNLCBKYW4gQmV1bGljaCA8SkJl dWxpY2hAc3VzZS5jb20+IHdyb3RlOg0KPj4+PiBPbiAyNC4wMy4yMDIxIDE4OjI2LCBHZW9yZ2Ug RHVubGFwIHdyb3RlOg0KPj4+Pj4gU2lnbmVkLW9mZi1ieTogR2VvcmdlIER1bmxhcCA8Z2Vvcmdl LmR1bmxhcEBjaXRyaXguY29tPg0KPj4+Pj4gLS0tDQo+Pj4+PiBNaXNzZWQgb25lIGZyb20gbXkg bGlzdCB3aGVuIGNyZWF0aW5nIHRoZSBvdGhlciBzZXJpZXMNCj4+Pj4+IA0KPj4+Pj4gQ0M6IElh biBKYWNrc29uIDxpYW4uamFja3NvbkBjaXRyaXguY29tPg0KPj4+Pj4gQ0M6IEphbiBCZXVsaWNo IDxqYmV1bGljaEBzdXNlLmNvbT4NCj4+Pj4+IENDOiBSb2dlciBQYXUgTW9ubmUgPHJvZ2VyLnBh dUBjaXRyaXguY29tPg0KPj4+Pj4gLS0tDQo+Pj4+PiBDSEFOR0VMT0cubWQgfCAxICsNCj4+Pj4+ IDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQ0KPj4+Pj4gDQo+Pj4+PiBkaWZmIC0tZ2l0 IGEvQ0hBTkdFTE9HLm1kIGIvQ0hBTkdFTE9HLm1kDQo+Pj4+PiBpbmRleCAxNWEyMmQ2YmRlLi40 OTgzMmFlMDE3IDEwMDY0NA0KPj4+Pj4gLS0tIGEvQ0hBTkdFTE9HLm1kDQo+Pj4+PiArKysgYi9D SEFOR0VMT0cubWQNCj4+Pj4+IEBAIC0xOCw2ICsxOCw3IEBAIFRoZSBmb3JtYXQgaXMgYmFzZWQg b24gW0tlZXAgYSBDaGFuZ2Vsb2ddKGh0dHBzOi8va2VlcGFjaGFuZ2Vsb2cuY29tL2VuLzEuMC4w LykNCj4+Pj4+IC0geDg2X2VtdWxhdGU6IEV4cGFuZGVkIHRlc3RpbmcgZm9yIHNldmVyYWwgaW5z dHJ1Y3Rpb24gY2xhc3Nlcw0KPj4+Pj4gLSBDSSBsb29wOiBBZGQgQWxwaW5lIExpbnV4LCBVYnVu dHUgRm9jYWwgdGFyZ2V0czsgZHJvcCBDZW50T1MgNg0KPj4+Pj4gLSBDSSBsb29wOiBBZGQgZG9t MGxlc3MgYWFyY2g2NCBzbW9rZSB0ZXN0DQo+Pj4+PiArIC0gRmFjdG9yZWQgb3V0IEhWTS1zcGVj aWZpYyBzaGFkb3cgY29kZSwgYWxsb3dpbmcgUFYgc2hpbSB0byBiZSBzbGltbWVyDQo+Pj4+IEJ1 dCBzaGFkb3cgY29kZSBkb2Vzbid0IGdldCBpbmNsdWRlZCBieSBkZWZhdWx0IGluIHNoaW0tZXhj bHVzaXZlDQo+Pj4+IGJ1aWxkcyAoYW5kIG90aGVycyBhcmUgdW5saWtlbHkgdG8gZGlzYWJsZSBI Vk0pLg0KPj4+IENhbiB5b3UgcHJvcG9zZSBzb21lIGJldHRlciB0ZXh0IHBsZWFzZT8NCj4+IERv ZXMgdGhpcyBuZWVkIG1lbnRpb25pbmcgaGVyZSBpbiB0aGUgZmlyc3QgcGxhY2U/DQo+IA0KPiBJ IHdvdWxkIHJlY29tbWVuZCBub3QuDQo+IA0KPiBXZSd2ZSBiZWVuIGRvaW5nIGluY3JlbWVudGFs IGltcHJvdmVtZW50cyBmb3IgdGhlIHNoaW0gZm9yIHNldmVyYWwNCj4gcmVsZWFzZXMgbm93LCBh bmQgaW4gdGhpcyBjYXNlLCB3ZSdyZSBsaXRlcmFsbHkgdGFsa2luZyBhIGZldyBrYiBvZg0KPiBj b2RlLiAgQXMgd2UgYWxyZWFkeSBhbGlnbiB0byAyTSBib3VuZGFyaWVzIGZvciBzdXBlcnBhZ2Ug cmVhc29ucywgdGhlcmUNCj4gYWxtb3N0IGNlcnRhaW5seSBpc24ndCBhY3R1YWxseSBhIHJlZHVj dGlvbiBpbiBydW50aW1lIHNpemUuDQoNCkkgZG9u4oCZdCB1bmRlcnN0YW5kIHdoeSB0aGUgdHdv IG9mIHlvdSBhcmUgZG93bnBsYXlpbmcgeW91ciB3b3JrIHNvIG11Y2guICBZZXMsIHRoZXNlIGFy ZSBhbGwgb25seSBpbmNyZW1lbnRhbCBpbXByb3ZlbWVudHM7IGJ1dCB0aGV5IGFyZSBpbXByb3Zl bWVudHM7IGFuZCB0aGUgY3VtdWxhdGl2ZSBlZmZlY3Qgb2YgbG9hZHMgb2YgaW5jcmVtZW50YWwg aW1wcm92ZW1lbnRzIGNhbiBiZSBzaWduaWZpY2FudC4gIENvbW11bmljYXRpbmcgdG8gcGVvcGxl IGp1c3Qgd2hhdCB0aGUgbmF0dXJlIG9mIGFsbCB0aGVzZSBpbmNyZW1lbnRhbCBpbXByb3ZlbWVu dHMgYXJlIGlzIGltcG9ydGFudC4NCg0KSSBtZWFuLCBsb29rIGF0IHRoZSByZWxlYXNlIG5vdGVz IGZvciBHbyAxLjE1IFsxXS4gIEl0IGluY2x1ZGVzIHRoaW5ncyBsaWtlIHRoaXM6DQoNCiJKU0Vz Y2FwZSBub3cgY29uc2lzdGVudGx5IHVzZXMgVW5pY29kZSBlc2NhcGVzIChcdTAwWFgpLCB3aGlj aCBhcmUgY29tcGF0aWJsZSB3aXRoIEpTT04uIg0KDQoiZ28gdGVzdCAtdiBub3cgZ3JvdXBzIG91 dHB1dCBieSB0ZXN0IG5hbWUsIHJhdGhlciB0aGFuIHByaW50aW5nIHRoZSB0ZXN0IG5hbWUgb24g ZWFjaCBsaW5lLiINCg0KVGhvc2Ugc291bmQgZmFyIG1vcmUgdHJpdmlhbCB0aGFuIOKAnEV2ZW4g bW9yZSBzaGFkb3cgY29kZSBoYXMgYmVlbiBtb3ZlZCB0byBhbiBIVk0tc3BlY2lmaWMgZmlsZeKA nS4NCg0KSWYgdGhlIGFwcHJvYWNoIGlzIGdvaW5nIHRvIGJlIOKAnFNVUEVSIElNUE9SVEFOVCBT UEVDSUFMIFNUVUZGIE9OTFkiLCBJ4oCZZCByZWNvbW1lbmQgcmVtb3ZpbmcgQ0hBTkdFTE9HLm1k LiAgSGF2aW5nIGFuIG9mZmljaWFsIGxpc3QgdGhhdCBzYXlzLCDigJxXZWxsLCByZWFsbHksIHdl IG9ubHkgZGlkIDIgdGhpbmdzIHRoaXMgcmVsZWFzZeKAnSBpcyBnb2luZyB0byBiZSBhY3RpdmVs eSBoYXJtZnVsLiAgDQoNCiAtR2VvcmdlDQoNClsxXSBodHRwczovL2dvbGFuZy5vcmcvZG9jL2dv MS4xNQ== From xen-devel-bounces@lists.xenproject.org Tue Mar 30 10:09:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 10:09:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103375.197252 (Exim 4.92) (envelope-from ) id 1lRBJ1-0001YC-7H; Tue, 30 Mar 2021 10:09:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103375.197252; Tue, 30 Mar 2021 10:09:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRBJ1-0001Y5-46; Tue, 30 Mar 2021 10:09:03 +0000 Received: by outflank-mailman (input) for mailman id 103375; Tue, 30 Mar 2021 10:09:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRBIz-0001Y0-SB for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 10:09:01 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1074bbb0-2247-4615-850b-4941c15a4417; Tue, 30 Mar 2021 10:09:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1074bbb0-2247-4615-850b-4941c15a4417 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617098940; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=4CXlE14MKJ2QvzQjAo7O0NyZS581vcAdqqMkffONxUY=; b=bZttLKvvHkrQ5jP5BaxlcZfgJfcbWISY7hPTKhUcs05O6mpSOxXMorBD 3gGOZxWzIhvT9M6y14H0Km1RyTswpLn09I0U2Xtkzv4mtdw9geq0H3vdu SZ5wCcqnvLyAkvbprlfrvIi3Ot8mPjnPHJxmcuBLqajZ1QSb2cgD0hPF1 Q=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: OaDHeD8ztMphzvzZADdE/mRc+asV1pZlsgWKTLBSiKqfcAv8XJheLy744F19MvI6V6paB+crPa D3vdZ387T2L5hu9WVRK/ka0MGTlbe2az6Gu1V60nRi2lgWwu22C4WyeJcqumtOZsNW0jbxLbF7 p/4iRKhKBRZqLZvG8SLm77lvvTAtOMSFlNH17DFnFH836Vkks0O7SJr4fnFT5bOpPD6sBxaC7O /vv1pu17oP6h6D5lwZ1pe9AjaxTeWqjuAmj0poYzH3K5aM8eMfQiAPE/5b3TGhdDLg2foQWo9f vCY= X-SBRS: 5.2 X-MesageID: 40410050 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:aCnrWqwxtEM1RJ1jnEDzKrPx/uskLtp033Aq2lEZdDV8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPsfVr3//dOgbU5F7GkQQXgpS+UPJhvhLGSpwHINg/f0qpm1a lme7VjE9GYNzJHpOvz/QXQKbkd6fad9qTAv4nj5lNMaS0vVK169Qd+DW+gYyhLbS1LH4AwGp bZxucvnUvCRV0tYs62BmYIUoH4zrWmqLvcbQMbHBli0QGSjFqTg4LSKQSS3RsVTlp0sNUf2F XC+jaZ2oyT98uV5zWZ/G/V4pRQlrLau6Z+Lf3JsOc5AHHBjg6pYa5oRrGNuiskydvflGoCoZ 33jDoLe+h19nPNbkG5yCGdpDXI4XIVxFLJjX+enHf5rsTySFsBerR8rLMcSDT1wQ4EnrhHoc V29lPcjbV7J1f8uR64wN7yWxRjhiOP0AEfuN9WtVNze88jcrNLxLZvmn99IdM7Mw/RzpsoK+ VqBNG03octTXqqK0rUuWRi27WXLw0ONybDRkADv/qc2CRNkEZ4yFMFxNcekm1ozuNEd6V5 X-IronPort-AV: E=Sophos;i="5.81,290,1610427600"; d="scan'208";a="40410050" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GxYFGoCNGI8tWT7C0k951IvFIe2RGqc1gKbNn5c8Uzn8hrRuG8fqiybKoGEo8cIK2nV+2UkLCDfvoeVFlki58JbBWcc+emQincq3F1SRhWpphTxHaWSbl36aQjmi7Kuhi/1KYy5XtQqUptCbDmhqHsh0uzBtJE3aNHxwXMJJ3IMyUV1n0XsbNX4l5AbBiYBEHS0nRUg3OFud7wyY5BZyhTrOBR7KLGEOuLaYeoxv1E4puwqRkT1BARQNgnKxe5eCPKw0pAcY9Jf/HdTaOW8YbAAg6bBQ8hc0A1WPnmZ+A5oZuHaFCMYLMQAgPIHNMDY31pqZx5lJg8qb7ZDdyCPj4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6ByKdTw6aBg7DVZqFftQOx0//c47+Vpp9hugxvmHL/E=; b=mWfJEaXWwd2xygdSl8cnuNILEHRuMi43sq0PNu2ymxsqzvowrBD2BlHUoGeqRcdAgzkCuTA3nfVfIDmlc5p9ObzzD/gFuA+gLKJcQzfq4/HG9X4+9Hdj/VfQsmRVQPUVBbtqoD7OwxFBQMQeruubmaXyU5SbZQhWyMAr4rmq3AMTfvsmelZnpCzUDkeUjNnFcnXaFBhotGsxdfJkJFEChVOJaNAvIlpEZVJ4xo1v489RlaPlRmWjceqy7h4h8xXbjrCTL5a2ffEIwhbrJxWNjizOVQZ0IvKOKj7Wr3oI4G4NHroQFuI2aX16JecF97gP+3vdfNs8jqHqWcFZz3xh/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6ByKdTw6aBg7DVZqFftQOx0//c47+Vpp9hugxvmHL/E=; b=HCwEOUjU0FbHtcQE+7gcOZS8C/V1+Hc2OXCPQG3H1ucVHV0s770uV902Lyc6d6wKbWjpGi0FL5/saWqq8UFRClGH4LPP24E+LQNLW704Myd/1sV4T21mFnZBQXcpfw6AWlPfoi/L3LtXzt65js/ouLl5o1lDErw9riIkAnv0KYA= From: George Dunlap To: Julien Grall CC: xen-devel , Jan Beulich , Ian Jackson , Andrew Cooper Subject: Re: [PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support Thread-Topic: [PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support Thread-Index: AQHXJLa1tVPlJJfTcUCinve5Y2vCr6qbUIkAgAD/aYA= Date: Tue, 30 Mar 2021 10:08:54 +0000 Message-ID: <87E259CB-2BB4-4BAE-9916-BE46584E0EF4@citrix.com> References: <20210329161457.345360-1-george.dunlap@citrix.com> <20210329161457.345360-3-george.dunlap@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 12729f76-bc9b-4383-ea37-08d8f363d33d x-ms-traffictypediagnostic: PH0PR03MB5782: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NQhbc0IAnCYeP//1c7m58Ho6ODVLwvcHRuJmxP5SjThA2+S7gGTyI6qcCRuti0L2d78qm/8qNRtmk/nJJ+fkpiSJjBSdr4j0GeRLR5P4HYWP6gbApEL9XzeEaRyeWXuEO0GN/AlRUevQp5GlMpIsoD71YhrqEm6z00cOrHfrIr+kkGePWXrt3XpdulB/Fe1L6FGnb/B6Fjq+cxY9FUNdVh3TI5Ln1Nf4ratlhghGOThrlSFl7kUk6jqbuiiHz1GwDVX1XPFInGNxQ/XM3iKZMjboXr8rhNvYtvlFjZbLx3io0vBga9WngvwOHJaRLta4zc5dga0TuId/9PkkTp7MOyxV9VV9T9DsdqBCgmVQ8zmTqmqkWIaRWRcLRlTowzCsgFDaJW0necAB+5fCw8PchmAk2xn8AgOgRWw4N6BuWnw6IYc2HdzDu6gJTImYUBOfSqH2cAA120lsh8ZYPouW58xUD49P+9tg/NGLHktQIMwj5E7cblk87bkAiR08cLe/9Sdg5NCnKwMYakHxaMH9yDVsVNUo1RobABYJaeRt/HmEwNX3w6iORcOxtdACbP9FhWTbkGcZBuG42m5H+j/6WhLIOaNyEDnADPPSSQ2Bf0KHCMuCT2An3CR8QRqaxzzhNshQnf86aBpal59HO0TfK5RNlE55C4L5RCt3XMJHDeKkeYknAT2VkpRe9cipleulQyPxaCDHnarwSZy043ds9U2ZxSMWyj2+5k6aNxuAxmtvhSs/eCR91KESPF4UHQrhkld6Kan1mOjzLFcoC0NQj2MiGmngDBvgEr0jKo+ek1HUh8xN5C8ja8llm5tzlngB x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(136003)(366004)(39860400002)(396003)(186003)(5660300002)(26005)(91956017)(66946007)(316002)(478600001)(36756003)(64756008)(66446008)(8936002)(76116006)(86362001)(38100700001)(2906002)(2616005)(4326008)(71200400001)(6486002)(53546011)(6506007)(33656002)(4744005)(8676002)(6512007)(54906003)(66556008)(66476007)(6916009)(107886003)(219803003)(207903002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: dd5iIPBcUhqKAL3Sk/srCj07T493Aunz5bOLKiARfpGxgt6r9R85iSCJ2zPOWPKnwG+aKsqGXAcwLqq2Z0Z97uTf6dlrM6t/JnmCSfXxbv2GcHc7n/Pf0WcfjlxkogshT2Gu+C7oCiuEv4HzMe/qf/nlF0MueQfSyMRsBcN2LNPyl+ISFB+af3JaqNJ1nqrJu+McShf6WmZEtsW2TZ7rT7T/5Nc5ZpuwK6tGs6OOWcXoo3RUzCXyl0ypxOQuA7KYOBKYA7vRvQjteVQH23/YqFAR5sTuB5jx8gvsLlVYEWc7Y2L9pkBAQWuI3QZBlHythLCC7OlX6fJiHgmoqxxH23eje85o6Li7MSarmfFq1Uf921XdGp135vBmTFw3Swobx54dJBiBVWllX5x8If4f1uCIsaI1ENurCTXtJCluTHiFs3CkJ0wIih6rnWUQQlKHaUKbj+tMhdjXYIc1RXVPaeVVJcHbnKTV+Krn8jkzWwiXuHbjz2KRsIFYYIu1uQquPVVvZxeCZyyrAOKGExTGwOZvWLuLFcskKjcihPPn19Zx9XOIvJh7UEaXRQrrwIXRZyGssGGpfm3iMprYB89JjqbMDdlt0zT4a3FsgzoMI1EFaCBR4FR/rhXSJzMsF+i+lhD3Wn71asJ3PqJNvwwkqu7dYt8Mjpd5SRsPo6vx14/qOkd8VcYA/nd3o/MuRID6BmEO+h4GeHLdtcJeVxSJA1+N8FJu/xo9vc593CKO4njGrmc8iz7H9x+IQUCxKquY Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12729f76-bc9b-4383-ea37-08d8f363d33d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2021 10:08:54.2943 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HAhSqRW6AdovLjx1/EJR/SFk47PcW5PaJraao0vLNb/j7hKzuQh14gVPMATUpHFzsM0m+k9J6563xdGCq0WG3VComCi93jtXdrboW9Sp8kY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5782 X-OriginatorOrg: citrix.com > On Mar 29, 2021, at 7:54 PM, Julien Grall wr= ote: >=20 > Hi George, >=20 > On Mon, 29 Mar 2021 at 17:15, George Dunlap wr= ote: >> diff --git a/CHANGELOG.md b/CHANGELOG.md >> index 8c89212f14..538eae611c 100644 >> --- a/CHANGELOG.md >> +++ b/CHANGELOG.md >> @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keep= achangelog.com/en/1.0.0/) >> - ARM SMMUv3 (Tech Preview) >> - Intel Processor Trace support (Tech Preview) >> - Named PCI devices for xl/libxl >> + - Support for zstd-compressed dom0 and domU kernels >=20 > Looking at the log, the feature looks x86 only (at least the dom0 part). Oh, interesting. So what about the following? - Support for zstd-compressed dom0 (x86) and domU kernels -George= From xen-devel-bounces@lists.xenproject.org Tue Mar 30 10:14:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 10:14:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103383.197263 (Exim 4.92) (envelope-from ) id 1lRBNu-0002cq-0b; Tue, 30 Mar 2021 10:14:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103383.197263; Tue, 30 Mar 2021 10:14:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRBNt-0002cj-Tv; Tue, 30 Mar 2021 10:14:05 +0000 Received: by outflank-mailman (input) for mailman id 103383; Tue, 30 Mar 2021 10:14:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRBNs-0002ce-FH for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 10:14:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRBNs-0001mG-8w; Tue, 30 Mar 2021 10:14:04 +0000 Received: from [54.239.6.177] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRBNs-0006Nk-2V; Tue, 30 Mar 2021 10:14:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=wGOvvFS7oL2RTpJn6wu6DZnoKHUTw6iywo9DO8TrGp4=; b=WS8jHiAvs788KDiickJKtfi2MP VXsOTmFSlpHIAqHMx+Kae5Z9Mtjg8TH73N3IlNi7xN6gNIiiHqXDtsEAP6gdfXz3FyTMv4xdLkUlS BAnYepbx3B5lQeXMhN2lctm9fYRCAGawtmoQ8HqnXmT+Wr3MsWLk4u9dToneWzJVKQJI=; Subject: Re: [PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support To: George Dunlap , Julien Grall Cc: xen-devel , Jan Beulich , Ian Jackson , Andrew Cooper References: <20210329161457.345360-1-george.dunlap@citrix.com> <20210329161457.345360-3-george.dunlap@citrix.com> <87E259CB-2BB4-4BAE-9916-BE46584E0EF4@citrix.com> From: Julien Grall Message-ID: Date: Tue, 30 Mar 2021 11:14:02 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87E259CB-2BB4-4BAE-9916-BE46584E0EF4@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 30/03/2021 11:08, George Dunlap wrote: > > >> On Mar 29, 2021, at 7:54 PM, Julien Grall wrote: >> >> Hi George, >> >> On Mon, 29 Mar 2021 at 17:15, George Dunlap wrote: >>> diff --git a/CHANGELOG.md b/CHANGELOG.md >>> index 8c89212f14..538eae611c 100644 >>> --- a/CHANGELOG.md >>> +++ b/CHANGELOG.md >>> @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>> - ARM SMMUv3 (Tech Preview) >>> - Intel Processor Trace support (Tech Preview) >>> - Named PCI devices for xl/libxl >>> + - Support for zstd-compressed dom0 and domU kernels >> >> Looking at the log, the feature looks x86 only (at least the dom0 part). > > Oh, interesting. So what about the following? > > - Support for zstd-compressed dom0 (x86) and domU kernels Sounds fine to me. Note that I haven't tried zstd-compressed for domu Kernel on Arm. Maybe the author (Jan) can confirm whether this was plumbed in common libxc code? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 30 10:17:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 10:17:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103388.197279 (Exim 4.92) (envelope-from ) id 1lRBRM-0002nD-I0; Tue, 30 Mar 2021 10:17:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103388.197279; Tue, 30 Mar 2021 10:17:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRBRM-0002n6-Er; Tue, 30 Mar 2021 10:17:40 +0000 Received: by outflank-mailman (input) for mailman id 103388; Tue, 30 Mar 2021 10:17:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRBRK-0002n1-SZ for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 10:17:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRBRK-0001oj-Rl for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 10:17:38 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lRBRK-0006Xj-Qh for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 10:17:38 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lRBRH-0004Lp-9w; Tue, 30 Mar 2021 11:17:35 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=kGFjmhwv28S5BmdLGRUB64O4XneaUjd/SKx70mFBhks=; b=klmQjcuAaauvH65JLXUf80ovQA 8VJbRDJIgOzBlzgM/TB1P6jm5G07RdZMGRAUtig8lwSoln2AWivKi86uLVBXbpL5CqwlhIqdTvKRf Y1yoCdXlAzoWdvte0IH0y1/YFSZu7R9Y5r6nCxJe8/QbAbSMjMXmnnsPyzY0lVZ4YEWk=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24674.64189.466454.374@mariner.uk.xensource.com> Date: Tue, 30 Mar 2021 11:17:33 +0100 To: Boris Ostrovsky Cc: xen-devel@lists.xenproject.org, jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com Subject: Re: [PATCH v3 0/2] Performance regression due to XSA-336 In-Reply-To: <1617052502-14181-1-git-send-email-boris.ostrovsky@oracle.com> References: <1617052502-14181-1-git-send-email-boris.ostrovsky@oracle.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Boris Ostrovsky writes ("[PATCH v3 0/2] Performance regression due to XSA-336"): > The first patch addresses performance regression introduced by XSA-336 fixes. > This patch could be considered as a candidate for inclusion in 4.15. Thank you, but I think this is too late for 4.15. Regards, Ian. From xen-devel-bounces@lists.xenproject.org Tue Mar 30 10:45:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 10:45:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103399.197291 (Exim 4.92) (envelope-from ) id 1lRBrl-0005vJ-Js; Tue, 30 Mar 2021 10:44:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103399.197291; Tue, 30 Mar 2021 10:44:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRBrl-0005vC-GX; Tue, 30 Mar 2021 10:44:57 +0000 Received: by outflank-mailman (input) for mailman id 103399; Tue, 30 Mar 2021 10:44:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRBrj-0005v1-Cv for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 10:44:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 061cf2be-bc8f-4366-9fc3-9cbb0e867365; Tue, 30 Mar 2021 10:44:54 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BC92CB1F3; Tue, 30 Mar 2021 10:44:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 061cf2be-bc8f-4366-9fc3-9cbb0e867365 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617101093; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=whe1fhuYPh1182KWoH3Jlw1XXEYHKqBKA0RX2F3r50c=; b=RQVU/OPNFikvZpd59w5tYWI0oFI7JtRCub2Kga1xfgdXJKTGLbhbt/zQz9C3peSmv9tHrk iT5krivo9RjY92Kt3PwJz3K1vT47w7XeuISmYmyNc2/e830ZNZqT3/OAI6Kp0F28P8zdKQ QIQmDvkmCCC8EqLTpNxyYtiX2srXi1k= Subject: Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code To: George Dunlap Cc: Ian Jackson , Roger Pau Monne , "xen-devel@lists.xenproject.org" , Paul Durrant , Andrew Cooper References: <20210324172608.302316-1-george.dunlap@citrix.com> <23461afc-c0e0-eb33-9ed3-52f050b6aef0@suse.com> <27ecde00-f0aa-b701-6928-5480ed805064@citrix.com> <2A1FCD39-D0C0-468D-A977-2FBF7126FDE6@citrix.com> From: Jan Beulich Message-ID: <2d7ce867-091a-f18f-f0c7-5e71da15a2ba@suse.com> Date: Tue, 30 Mar 2021 12:44:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <2A1FCD39-D0C0-468D-A977-2FBF7126FDE6@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 30.03.2021 11:56, George Dunlap wrote: > > >> On Mar 29, 2021, at 6:26 PM, Andrew Cooper wrote: >> >> On 29/03/2021 17:23, Jan Beulich wrote: >>> On 29.03.2021 18:12, George Dunlap wrote: >>>>> On Mar 25, 2021, at 7:08 AM, Jan Beulich wrote: >>>>> On 24.03.2021 18:26, George Dunlap wrote: >>>>>> Signed-off-by: George Dunlap >>>>>> --- >>>>>> Missed one from my list when creating the other series >>>>>> >>>>>> CC: Ian Jackson >>>>>> CC: Jan Beulich >>>>>> CC: Roger Pau Monne >>>>>> --- >>>>>> CHANGELOG.md | 1 + >>>>>> 1 file changed, 1 insertion(+) >>>>>> >>>>>> diff --git a/CHANGELOG.md b/CHANGELOG.md >>>>>> index 15a22d6bde..49832ae017 100644 >>>>>> --- a/CHANGELOG.md >>>>>> +++ b/CHANGELOG.md >>>>>> @@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>>>>> - x86_emulate: Expanded testing for several instruction classes >>>>>> - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 >>>>>> - CI loop: Add dom0less aarch64 smoke test >>>>>> + - Factored out HVM-specific shadow code, allowing PV shim to be slimmer >>>>> But shadow code doesn't get included by default in shim-exclusive >>>>> builds (and others are unlikely to disable HVM). >>>> Can you propose some better text please? >>> Does this need mentioning here in the first place? >> >> I would recommend not. >> >> We've been doing incremental improvements for the shim for several >> releases now, and in this case, we're literally talking a few kb of >> code. As we already align to 2M boundaries for superpage reasons, there >> almost certainly isn't actually a reduction in runtime size. > > I don’t understand why the two of you are downplaying your work so much. Yes, these are all only incremental improvements; but they are improvements; and the cumulative effect of loads of incremental improvements can be significant. Communicating to people just what the nature of all these incremental improvements are is important. > > I mean, look at the release notes for Go 1.15 [1]. It includes things like this: > > "JSEscape now consistently uses Unicode escapes (\u00XX), which are compatible with JSON." > > "go test -v now groups output by test name, rather than printing the test name on each line." > > Those sound far more trivial than “Even more shadow code has been moved to an HVM-specific file”. > > If the approach is going to be “SUPER IMPORTANT SPECIAL STUFF ONLY", I’d recommend removing CHANGELOG.md. Having an official list that says, “Well, really, we only did 2 things this release” is going to be actively harmful. I don't think it needs to be "super important" only, but it ought to be at least user visible / user recognizable imo. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 30 10:56:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 10:56:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103402.197303 (Exim 4.92) (envelope-from ) id 1lRC30-000736-OK; Tue, 30 Mar 2021 10:56:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103402.197303; Tue, 30 Mar 2021 10:56:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRC30-00072z-KK; Tue, 30 Mar 2021 10:56:34 +0000 Received: by outflank-mailman (input) for mailman id 103402; Tue, 30 Mar 2021 10:56:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRC2z-00072u-VX for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 10:56:34 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id eb895427-854f-4026-ada9-e70496317459; Tue, 30 Mar 2021 10:56:33 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 60747B270; Tue, 30 Mar 2021 10:56:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb895427-854f-4026-ada9-e70496317459 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617101792; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mzh4AUS2vZ+qPPfhiYoXdNt2AuTRm1PP69Kf/uH5ll4=; b=fkTb009PyvjW0A7KUA/obWkpdn+Ux80/T9SfVAxH+kZ50suOAH7xfIDH+9I4riqgP5GKuc jXu2MGCB4pNrosdaFgLHox4PGhOnAtj1NTFV9mL+LFWqxsU/Hn97CWAtPPnxQIRA7uG/Tb WJQECx0mW1mTtiy+3QIjlmQ+A3mcOEQ= Subject: Re: [PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support To: Julien Grall , Julien Grall Cc: xen-devel , Ian Jackson , Andrew Cooper , George Dunlap References: <20210329161457.345360-1-george.dunlap@citrix.com> <20210329161457.345360-3-george.dunlap@citrix.com> <87E259CB-2BB4-4BAE-9916-BE46584E0EF4@citrix.com> From: Jan Beulich Message-ID: <672c88ac-8373-6629-4d2f-0d1e86c103cd@suse.com> Date: Tue, 30 Mar 2021 12:56:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 30.03.2021 12:14, Julien Grall wrote: > > > On 30/03/2021 11:08, George Dunlap wrote: >> >> >>> On Mar 29, 2021, at 7:54 PM, Julien Grall wrote: >>> >>> Hi George, >>> >>> On Mon, 29 Mar 2021 at 17:15, George Dunlap wrote: >>>> diff --git a/CHANGELOG.md b/CHANGELOG.md >>>> index 8c89212f14..538eae611c 100644 >>>> --- a/CHANGELOG.md >>>> +++ b/CHANGELOG.md >>>> @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>>> - ARM SMMUv3 (Tech Preview) >>>> - Intel Processor Trace support (Tech Preview) >>>> - Named PCI devices for xl/libxl >>>> + - Support for zstd-compressed dom0 and domU kernels >>> >>> Looking at the log, the feature looks x86 only (at least the dom0 part). >> >> Oh, interesting. So what about the following? >> >> - Support for zstd-compressed dom0 (x86) and domU kernels > > Sounds fine to me. Note that I haven't tried zstd-compressed for domu > Kernel on Arm. > > Maybe the author (Jan) can confirm whether this was plumbed in common > libxc code? Well, I've followed the model used for other compression methods. I have no idea what this means or does not mean for Arm; in fact so far I was under the impression that like in the hypervisor decompression support was an x86-only feature, but from what you say I conclude I have been wrong with this. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 30 10:57:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 10:57:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103405.197314 (Exim 4.92) (envelope-from ) id 1lRC3V-00077o-1R; Tue, 30 Mar 2021 10:57:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103405.197314; Tue, 30 Mar 2021 10:57:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRC3U-00077h-UC; Tue, 30 Mar 2021 10:57:04 +0000 Received: by outflank-mailman (input) for mailman id 103405; Tue, 30 Mar 2021 10:57:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRC3U-00077K-7q for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 10:57:04 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c17fc19f-5d4e-4129-8a80-42b8e58aa92b; Tue, 30 Mar 2021 10:56:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 14F14B256; Tue, 30 Mar 2021 10:56:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c17fc19f-5d4e-4129-8a80-42b8e58aa92b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617101819; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fPs7C6K+03OGpQOFqswfldKu2ngL3N2nb6b2KWezE9s=; b=oKgrWNGrB2XEJ2xBiiTPJTdHzaC9nCkZX+LrbYHYdb+cM+1Ak7A+f8H9uaf/xzWXnBciGO 085F2UOkWkewX+dD90D42PNmzy+5PNBt/FsD5gT6EBkYIlX4PAvIwGpUc4XlCCTcSHJZs/ 21N76RHcQZE3QkTp4GPuQZCoGM7AYp8= Subject: Re: [PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support To: George Dunlap Cc: xen-devel , Ian Jackson , Andrew Cooper , Julien Grall References: <20210329161457.345360-1-george.dunlap@citrix.com> <20210329161457.345360-3-george.dunlap@citrix.com> <87E259CB-2BB4-4BAE-9916-BE46584E0EF4@citrix.com> From: Jan Beulich Message-ID: <3fdba65d-3d23-f331-c04d-d70ed82f1df8@suse.com> Date: Tue, 30 Mar 2021 12:56:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <87E259CB-2BB4-4BAE-9916-BE46584E0EF4@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 30.03.2021 12:08, George Dunlap wrote: >> On Mar 29, 2021, at 7:54 PM, Julien Grall wrote: >> On Mon, 29 Mar 2021 at 17:15, George Dunlap wrote: >>> diff --git a/CHANGELOG.md b/CHANGELOG.md >>> index 8c89212f14..538eae611c 100644 >>> --- a/CHANGELOG.md >>> +++ b/CHANGELOG.md >>> @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>> - ARM SMMUv3 (Tech Preview) >>> - Intel Processor Trace support (Tech Preview) >>> - Named PCI devices for xl/libxl >>> + - Support for zstd-compressed dom0 and domU kernels >> >> Looking at the log, the feature looks x86 only (at least the dom0 part). > > Oh, interesting. So what about the following? > > - Support for zstd-compressed dom0 (x86) and domU kernels Then: Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 30 12:02:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 12:02:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103433.197354 (Exim 4.92) (envelope-from ) id 1lRD4I-0006Dj-Tg; Tue, 30 Mar 2021 12:01:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103433.197354; Tue, 30 Mar 2021 12:01:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRD4I-0006Dc-QK; Tue, 30 Mar 2021 12:01:58 +0000 Received: by outflank-mailman (input) for mailman id 103433; Tue, 30 Mar 2021 12:01:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRD4H-0006BX-Db for xen-devel@lists.xen.org; Tue, 30 Mar 2021 12:01:57 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 792c86ef-4c9b-43b5-8be2-c91b175898c9; Tue, 30 Mar 2021 12:01:50 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRD3z-0003Uf-Uy; Tue, 30 Mar 2021 12:01:39 +0000 Received: from iwj by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRD3z-0005Dv-Rd; Tue, 30 Mar 2021 12:01:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 792c86ef-4c9b-43b5-8be2-c91b175898c9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=NHPFu1XAUVlJbUfeISmXiuipVxaCU0mvsytRR5Xe7gc=; b=L9zjRtVYmmNayLh/y6MP7JX8ER I3AgjlvIFboC04oIQZxXoJCdQ6p9v41/TZqHZCwuH6RVenbOFaBtQ/Hk5ff3aFmmrBVM6C8AZzcms tAfIKTsKy8k/ZNv6aaLM1our1QttBgIeiQHanCx/DuDVXDuGGnwVpYwiAei6HHu3cC24=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 371 v3 (CVE-2021-28688) - Linux: blkback driver may leak persistent grants Message-Id: Date: Tue, 30 Mar 2021 12:01:39 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2021-28688 / XSA-371 version 3 Linux: blkback driver may leak persistent grants UPDATES IN VERSION 3 ==================== Public release. ISSUE DESCRIPTION ================= The fix for XSA-365 includes initialization of pointers such that subsequent cleanup code wouldn't use uninitialized or stale values. This initialization went too far and may under certain conditions also overwrite pointers which are in need of cleaning up. The lack of cleanup would result in leaking persistent grants. The leak in turn would prevent fully cleaning up after a respective guest has died, leaving around zombie domains. IMPACT ====== A malicious or buggy frontend driver may be able to cause resource leaks from the corresponding backend driver. This can result in a host-wide Denial of Sevice (DoS). VULNERABLE SYSTEMS ================== All Linux versions having the fix for XSA-365 applied are vulnerable. XSA-365 was classified to affect versions back to at least 3.11. MITIGATION ========== Reconfiguring guests to use alternative (e.g. qemu-based) backends may avoid the vulnerability. Avoiding the use of persistent grants will also avoid the vulnerability. This can be achieved by passing the "feature_persistent=0" module option to the xen-blkback driver. CREDITS ======= This issue was discovered by Nicolai Stange of SUSE. RESOLUTION ========== Applying the attached patch resolves this issue. xsa371-linux.patch Linux 5.12-rc, 5.11.1 onwards, 5.10.18 onwards Linux 5.10.0 - 5.10.17, 5.11.0 Linux 4.4 - 5.9 Linux 3.11 - 4.3 $ sha256sum xsa371* 1b2472253aa82385b3eff280fa4adf52742f06813fc093f5f86cd4a3021f736c xsa371-linux.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. HOWEVER, deployment of the mitigations described above is NOT permitted during the embargo on public-facing systems with untrusted guest users and administrators. This is because such configuration changes may be recognizable by the affected guests. AND: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmBjBWYMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZbkQIAKjv5DaESSOUA8DzOk4LmBZQHIMtTsN2wF2Q0/6g 3hJ3HoGzQwul00eUem+sbAqrEKJAEGLrcWpAGlcp8jW5i+44dyHE4o4vDmUOLx/x eJGMKwhv2Xe7Us15Fh4ioOBtmO6/AH60Scbid3aZ6zlJiUEPwpotzD9Jm/nR+B/E /KRsXZ+dTIZpeke9vVXbml/nrq/xwvpAZrEGeXBg1FDUHNsGWEeqPFq2ZfygVw22 x5loXeb8cqIETuA3EJQ1fx0Ioqnh3Q85TtNTCTpZrKcrTqJX+lZTlrEn4iAaMvp1 Bp/Mu9dkFrIJaid0iwdJKk2STsROh5ZCXCOyFOo5LFvFoKE= =DlVS -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa371-linux.patch" Content-Disposition: attachment; filename="xsa371-linux.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ZW4tYmxrYmFjazogZG9uJ3QgbGVhayBwZXJzaXN0ZW50IGdyYW50cyBm cm9tIHhlbl9ibGtia19tYXAoKQoKVGhlIGZpeCBmb3IgWFNBLTM2NSB6YXBw ZWQgdG9vIG1hbnkgb2YgdGhlIC0+cGVyc2lzdGVudF9nbnRbXSBlbnRyaWVz LgpPbmVzIHN1Y2Nlc3NmdWxseSBvYnRhaW5lZCBzaG91bGQgbm90IGJlIG92 ZXJ3cml0dGVuLCBidXQgaW5zdGVhZCBsZWZ0CmZvciB4ZW5fYmxrYmtfdW5t YXBfcHJlcGFyZSgpIHRvIHBpY2sgdXAgYW5kIHB1dC4KClRoaXMgaXMgWFNB LTM3MS4KClJlcG9ydGVkLWJ5OiBOaWNvbGFpIFN0YW5nZSA8bnN0YW5nZUBz dXNlLmRlPgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+CkNjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnClJldmlld2Vk LWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJldmlld2Vk LWJ5OiBXZWkgTGl1IDx3bEB4ZW4ub3JnPgoKLS0tIGEvZHJpdmVycy9ibG9j ay94ZW4tYmxrYmFjay9ibGtiYWNrLmMKKysrIGIvZHJpdmVycy9ibG9jay94 ZW4tYmxrYmFjay9ibGtiYWNrLmMKQEAgLTg5MSw3ICs4OTEsNyBAQCBuZXh0 Ogogb3V0OgogCWZvciAoaSA9IGxhc3RfbWFwOyBpIDwgbnVtOyBpKyspIHsK IAkJLyogRG9uJ3QgemFwIGN1cnJlbnQgYmF0Y2gncyB2YWxpZCBwZXJzaXN0 ZW50IGdyYW50cy4gKi8KLQkJaWYoaSA+PSBsYXN0X21hcCArIHNlZ3NfdG9f bWFwKQorCQlpZihpID49IG1hcF91bnRpbCkKIAkJCXBhZ2VzW2ldLT5wZXJz aXN0ZW50X2dudCA9IE5VTEw7CiAJCXBhZ2VzW2ldLT5oYW5kbGUgPSBCTEtC QUNLX0lOVkFMSURfSEFORExFOwogCX0K --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Mar 30 12:03:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 12:03:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103458.197380 (Exim 4.92) (envelope-from ) id 1lRD5y-0006dT-KY; Tue, 30 Mar 2021 12:03:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103458.197380; Tue, 30 Mar 2021 12:03:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRD5y-0006dL-HC; Tue, 30 Mar 2021 12:03:42 +0000 Received: by outflank-mailman (input) for mailman id 103458; Tue, 30 Mar 2021 12:03:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRD5y-0006cZ-0V for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 12:03:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 353b5c5d-d6ee-4f57-ba03-8ae5fba53517; Tue, 30 Mar 2021 12:03:38 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CF7EFB2E7; Tue, 30 Mar 2021 12:03:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 353b5c5d-d6ee-4f57-ba03-8ae5fba53517 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617105817; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=RgYXG8R4K7D3UYQ2peCbRMFBTS3NparOU1uQzH1eEOI=; b=ns/hsvRw67g4WN7NB4Qvd0CALMQ4QpTQHVNRooYdY+fHsNNOiiUfaBMJnAz8vF9Ybmma+1 AeI29Mw0/1zf+nR8xZ1UENKzb2CiWlMqAE3XxNoTBgrbjFCKjwQP48GdWGT7y3gz4w4esz 2psMmjkMokKaqDya48A9LeZjxtRS01E= From: Juergen Gross To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com Subject: [GIT PULL] xen: branch for v5.12-rc6 Date: Tue, 30 Mar 2021 14:03:37 +0200 Message-Id: <20210330120337.4404-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.12b-rc6-tag xen: branch for v5.12-rc6 It contains one Xen related security fix (XSA-371). Thanks. Juergen drivers/block/xen-blkback/blkback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Jan Beulich (1): xen-blkback: don't leak persistent grants from xen_blkbk_map() From xen-devel-bounces@lists.xenproject.org Tue Mar 30 12:22:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 12:22:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103491.197396 (Exim 4.92) (envelope-from ) id 1lRDO9-0000aI-9m; Tue, 30 Mar 2021 12:22:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103491.197396; Tue, 30 Mar 2021 12:22:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRDO9-0000aB-5b; Tue, 30 Mar 2021 12:22:29 +0000 Received: by outflank-mailman (input) for mailman id 103491; Tue, 30 Mar 2021 12:22:27 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRDO7-0000a5-Su for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 12:22:27 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 28b27e74-65d5-41cf-9fce-7c21755e646a; Tue, 30 Mar 2021 12:22:26 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B6E44B2EE; Tue, 30 Mar 2021 12:22:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28b27e74-65d5-41cf-9fce-7c21755e646a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617106945; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=li4m7mODyLbprHpdbk3kHygACurZtoEb8msRDSDta9Y=; b=geGUb3wiTWZBE/D52h5X7cFkxUBV2W2gLRHzSkAGHXRvxuaDQg50amYpcA4ggeZJuKM+oY EMecWRIMWwFe25e81sEkiJVI3lczTmE8omyWF7Yg+197SRzU7dAr9dcbBkP1iWqn7j/GJ8 SqeefXqc78dEGaKIoAWVuP6O4qajIcY= Subject: Re: [PATCH 0/4][4.15?] VT-d: mostly S3 related corrections To: Ian Jackson Cc: "Tian, Kevin" , "xen-devel@lists.xenproject.org" References: <35150558-6a4a-d6bb-b51a-4e2bf37e5ae5@suse.com> <24665.61184.783407.462294@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <09dd3b00-100e-276c-837c-e66eabac4c68@suse.com> Date: Tue, 30 Mar 2021 14:22:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <24665.61184.783407.462294@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 23.03.2021 14:37, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH 0/4][4.15?] VT-d: mostly S3 related corrections"): >> Thanks Kevin. Ian - what are your thoughts here towards 4.15? > > I looked at these four patches. > > In general I am not sure of the implications. There are two important > sets of implications: (i) upside: what is the bug this fixes and how > severe is that bug *in its actual impact on users of Xen* (ii) what > possible problems might there be and how have we made sure that the > patch is right ? > > I want look at this not from the point of view of technical details > but in terms of user impact. User impact is harder to predict but it > is what we actually care about. > > For one of the patches it seemed obvious to me that there was very > little downside risk and the upside is not corrupting something > (perhaps something important). > > For the others, all I could see, besides the general statement that > these aren't regressions, there was a lot of intensive discussion in > the commit messages of the specific technical details. Frankly, that > all went quite over my head. > > I would be prepared to give a release ack for the others if I can be > convinced of satisfactory answers to my questions (i) and (ii). For > an idea of what kind of answer I'm looking for, see the kind of thing > Roger has been putting in his 4.15-targeted patches. The more complex > and to-me-impenetrable the underlying technical details the more > sceptical I will be :-). > > I hope that makes sense. Of course it does, and I'm sorry that I get to replying only now. Since I didn't think I could make points towards these patches being important enough to take at this point, I didn't see a point in making this a high priority. Nevertheless, to address your requests: (i) Very hard to tell. Patch 4 at least very likely is no more than a "just in case" fix. The other two patches address issues where after resume IOMMU faults may not work correctly anymore or where, if there were any faults to be delivered while resuming, those may not get delivered / handled correctly ("unpredictable behavior" is probably the best description I could come up with). Users (admins) therefore may not become aware of there being issues on their system / with one or more of the guests. (ii) I've tested that things still work on a system where S3 halfway works. Beyond that I'm afraid it really was staring at the code that both made me notice the issues and makes me believe things at least aren't worse with the patches in place. I'm intending to commit these to staging now, but not to 4.15-staging. I'll queue them for backporting, though, as indicated previously. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 30 12:47:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 12:47:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103504.197439 (Exim 4.92) (envelope-from ) id 1lRDlr-0002xB-Lv; Tue, 30 Mar 2021 12:46:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103504.197439; Tue, 30 Mar 2021 12:46:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRDlr-0002x4-J0; Tue, 30 Mar 2021 12:46:59 +0000 Received: by outflank-mailman (input) for mailman id 103504; Tue, 30 Mar 2021 12:46:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRDlp-0002wz-FT for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 12:46:57 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id c2a63d30-10c8-456b-84e7-87a5861093eb; Tue, 30 Mar 2021 12:46:54 +0000 (UTC) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-247-RS2dCQRoNFK1nBPBv0HgtA-1; Tue, 30 Mar 2021 08:46:51 -0400 Received: by mail-wr1-f70.google.com with SMTP id 75so10284660wrl.3 for ; Tue, 30 Mar 2021 05:46:51 -0700 (PDT) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id h14sm42512910wrq.45.2021.03.30.05.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Mar 2021 05:46:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2a63d30-10c8-456b-84e7-87a5861093eb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617108414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9w+72Aj7tixZ62yUVO/4XVYc4FIACD1jnUr/XYw2nFs=; b=ahWnKn4PaStZMg+UIYpQYLRTQqYt0jEG1QcyouoLp66BddT5h0qW9OHQfbdMmf6+URP59U TosgGLTOdCVPT6gsOH+YmImk1w/tWZvF/JVlV0ZtyBJMfmzlBn3BVQgtjUC3ZVibuiEsei SfrPzb3dR7MsyFsxdfTUJzFiq2zfB+Y= X-MC-Unique: RS2dCQRoNFK1nBPBv0HgtA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9w+72Aj7tixZ62yUVO/4XVYc4FIACD1jnUr/XYw2nFs=; b=g7kxmoPTZDcYBbGse4FWAX0nR799OkX9UQGlzeaL5b8IwRCrmTauWwrCLoqVVGfyAJ Re5CV7xJvB1BTwKEhQPRquWu4nD4+NXM4BjcTN0wesC3tk5+LduOQkta/iEmvNc9dnOB aHzlTAW1SlQRKWfgPflUyJpSnyZ7G+pzW4X7s4WzopsVbdzrDlayU0zOpSYTaA0gbYAZ 03NNMpnv9MfTh1CMGHUw2/8s7O7SyvCfPR4UptkUA+ysvxjUkxSCiPegtMqQSTzwthS3 1NtrLzh34eT0crQcMtAAzveUuBF0Qr/8/PSimoY4JIxrODhxWmCJu2uxE2s+9gfqZK2G JMaQ== X-Gm-Message-State: AOAM530CfT/pALlgo4RrfkTmbjfANYVj8bsHQNiJMEKsQ+W0OmPK9jCk VTjPKmz/lME4yFrH8/6/8g9FhbOTgx43xthBRPqGIMRPm49s5ZJeyTzmQTVaZKjJqFAu/QFx8Do MEe//wzSGCG7VGVcIJukzaKliUOg= X-Received: by 2002:a1c:bb89:: with SMTP id l131mr4030589wmf.47.1617108409891; Tue, 30 Mar 2021 05:46:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwoSfXbZE9GRn6JXQxrGnbEqKBbh3vEcivUtlrm5T41kSRh1O0Ms6q4FbVIBxfw7LXgE1xGw== X-Received: by 2002:a1c:bb89:: with SMTP id l131mr4030564wmf.47.1617108409656; Tue, 30 Mar 2021 05:46:49 -0700 (PDT) Date: Tue, 30 Mar 2021 14:46:46 +0200 From: Stefano Garzarella To: John Simpson Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, "gcc-help@gcc.gnu.org" , Community Manager , George Dunlap Subject: Re: An error due to installation that require binutils package Message-ID: <20210330124646.jl4re5srmbzhkipm@steredhat> References: <889B1827-1FEB-4AC0-9002-278337D19ED5@citrix.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi John, On Mon, Mar 29, 2021 at 09:46:49PM +0300, John Simpson wrote: >Hello, > >Kindly ask you to have a look at this bug. >Thank you for your replies. It's already fixed in QEMU upstream and the fix will be released with the 6.0 version next month (the rc0 is already available): https://gitlab.com/qemu-project/qemu/-/commit/bbd2d5a8120771ec59b86a80a1f51884e0a26e53 I guess xen-4.14.1 is using an older version, so if you want you can backport that patch in your version, the change should be simple. Thanks, Stefano > >On Mon, Mar 29, 2021 at 7:07 PM George Dunlap >wrote: > >> John, >> >> Thanks for your report. Can you post your bug report >> xen-devel@lists.xenproject.org ? >> >> The bug is in the compilation of QEMU, which is an external project; so >> it’s possible that we’ll end up having to raise this with that community as >> well. >> >> Thanks, >> -George Dunlap >> >> > On Mar 28, 2021, at 2:26 PM, John Simpson wrote: >> > >> > Hello, >> > >> > Just forwarding this message to you. Can you give some thoughs about >> this? Thanks a lot. >> > >> > >> > ---------- Forwarded message --------- >> > From: Alan Modra >> > Date: Sun, Mar 28, 2021 at 2:21 PM >> > Subject: Re: An error due to installation that require binutils package. >> > To: John Simpson >> > Cc: >> > >> > >> > On Sun, Mar 28, 2021 at 12:55:23PM +0300, John Simpson via Binutils >> wrote: >> > > BUILD pc-bios/optionrom/kvmvapic.img >> > > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) >> > >> > -no-pie is a gcc option. Neither -no-pie nor --no-pie is a valid ld >> > option. The fault lies with whatever passed -no-pie to ld. >> > >> > -- >> > Alan Modra >> > Australia Development Lab, IBM >> > >> > >> > >> > ---------- Forwarded message --------- >> > From: Andreas Schwab >> > Date: Sun, Mar 28, 2021 at 2:17 PM >> > Subject: Re: An error due to installation that require binutils >> > package. >> > To: John Simpson via Binutils >> > Cc: John Simpson >> > >> > >> > Please report that to the xen project. ld -no-pie doesn't have a useful >> > meaning. It used to mean the same as ld -n -o-pie, which sets "-pie" as >> > the output file name. >> > >> > Andreas. >> > >> > -- >> > Andreas Schwab, schwab@linux-m68k.org >> > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 >> > "And now for something completely different." >> > >> > >> > >> > ---------- Forwarded message --------- >> > From: John Simpson >> > Date: Sun, Mar 28, 2021 at 12:55 PM >> > Subject: An error due to installation that require binutils package. >> > To: >> > >> > >> > Hello, >> > >> > Recently I got a following error due to installation xen on >> 5.11.6-1-MANJARO kernel: >> > >> > GEN target/riscv/trace.c >> > GEN target/s390x/trace.c >> > GEN target/sparc/trace.c >> > GEN util/trace.c >> > GEN config-all-devices.mak >> > make[1]: Entering directory >> '/home/username/xen/src/xen-4.14.1/tools/qemu-xen/slirp' >> > make[1]: Nothing to be done for 'all'. >> > make[1]: Leaving directory >> '/home/username/xen/src/xen-4.14.1/tools/qemu-xen/slirp' >> > BUILD pc-bios/optionrom/multiboot.img >> > BUILD pc-bios/optionrom/linuxboot.img >> > BUILD pc-bios/optionrom/linuxboot_dma.img >> > BUILD pc-bios/optionrom/kvmvapic.img >> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) >> > make[1]: *** [Makefile:53: multiboot.img] Error 1 >> > make[1]: *** Waiting for unfinished jobs.... >> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) >> > make[1]: *** [Makefile:53: linuxboot_dma.img] Error 1 >> > BUILD pc-bios/optionrom/pvh.img >> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) >> > make[1]: *** [Makefile:53: linuxboot.img] Error 1 >> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) >> > make[1]: *** [Makefile:53: kvmvapic.img] Error 1 >> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) >> > make[1]: *** [Makefile:50: pvh.img] Error 1 >> > make: *** [Makefile:581: pc-bios/optionrom/all] Error 2 >> > make: Leaving directory >> '/home/username/xen/src/xen-4.14.1/tools/qemu-xen-build' >> > make[3]: *** [Makefile:218: subdir-all-qemu-xen-dir] Error 2 >> > make[3]: Leaving directory '/home/username/xen/src/xen-4.14.1/tools' >> > make[2]: *** >> [/home/username/xen/src/xen-4.14.1/tools/../tools/Rules.mk:235: >> subdirs-install] Error 2 >> > make[2]: Leaving directory '/home/username/xen/src/xen-4.14.1/tools' >> > make[1]: *** [Makefile:72: install] Error 2 >> > make[1]: Leaving directory '/home/username/xen/src/xen-4.14.1/tools' >> > make: *** [Makefile:134: install-tools] Error 2 >> > ==> ERROR: A failure occurred in build(). >> > Aborting... >> > >> > Currently I have fresh binutils 2.36.1-2 and it seems to me that the >> issue is related to this part of code: >> > >> > https://github.com/bminor/binutils-gdb/blob/master/ld/lexsup.c#L451 >> > >> > It seems to me that this could impact far more users than just me. >> > >> >> From xen-devel-bounces@lists.xenproject.org Tue Mar 30 12:49:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 12:49:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103507.197452 (Exim 4.92) (envelope-from ) id 1lRDoB-00034o-3e; Tue, 30 Mar 2021 12:49:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103507.197452; Tue, 30 Mar 2021 12:49:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRDoB-00034h-0Q; Tue, 30 Mar 2021 12:49:23 +0000 Received: by outflank-mailman (input) for mailman id 103507; Tue, 30 Mar 2021 12:49:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRDo9-00034c-QI for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 12:49:21 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4f635b6f-2d9e-4ce3-9974-9981d3869f9f; Tue, 30 Mar 2021 12:49:20 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D729BB2F9; Tue, 30 Mar 2021 12:49:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f635b6f-2d9e-4ce3-9974-9981d3869f9f X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617108559; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vyznaQ3QGmreUcfxQcp07v6tmW3UNYHcz1Q8K9QbyTw=; b=asVPTISKzTpqkkT5CtYO8WVfu5T7TLXKB2jJZgLhYfbFlr1ocMACuruRpBvn7wCE9kRS3K hs4fQotfGDLloDMNGmIeDpfbSsL3YuDs0GDzfClp/Ku4gfifhriL2dEa9//ManHqqT5RLL QiHTk7bVQ0le98Npny2maSVfRvUMXWI= Subject: Re: [PATCH v3 2/2] x86/vpt: Simplify locking argument to write_{un}lock To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Boris Ostrovsky Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com, iwj@xenproject.org References: <1617052502-14181-1-git-send-email-boris.ostrovsky@oracle.com> <1617052502-14181-3-git-send-email-boris.ostrovsky@oracle.com> From: Jan Beulich Message-ID: <7a2e901c-b14c-8969-3b9a-41874dd2a7c4@suse.com> Date: Tue, 30 Mar 2021 14:49:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 30.03.2021 09:36, Roger Pau Monné wrote: > On Mon, Mar 29, 2021 at 05:15:02PM -0400, Boris Ostrovsky wrote: >> Make both create_periodic_time() and pt_adjust_vcpu() call >> write_{un}lock with similar arguments. This makes it sound like you adjust both functions, but really you bring the latter in line with the former. Would you mind me adjusting the wording along these lines while (and when) committing? > Might be worth adding that this is not a functional change? > >> Requested-by: Jan Beulich >> Signed-off-by: Boris Ostrovsky > > Either way: > > Reviewed-by: Roger Pau Monné > >> --- >> New patch. >> >> I ended up doing what Jan asked --- create_periodic_time() is also using different >> start pointers in lock() and unlock(). > > Hm, I'm not sure I'm following, create_periodic_time uses 'v' in both > write_{un}lock calls, which doesn't change across the function. I guess Boris merely meant to express that there's already precedent? Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 30 13:01:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 13:01:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103512.197467 (Exim 4.92) (envelope-from ) id 1lRDzs-0005By-82; Tue, 30 Mar 2021 13:01:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103512.197467; Tue, 30 Mar 2021 13:01:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRDzs-0005Br-4y; Tue, 30 Mar 2021 13:01:28 +0000 Received: by outflank-mailman (input) for mailman id 103512; Tue, 30 Mar 2021 13:01:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRDzr-0005Bj-5J; Tue, 30 Mar 2021 13:01:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRDzq-0004W5-Uk; Tue, 30 Mar 2021 13:01:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRDzq-0003Ox-JP; Tue, 30 Mar 2021 13:01:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRDzq-0000QW-Iu; Tue, 30 Mar 2021 13:01:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oYplO13LGf2/U/ETGkVKIr+c7IVEYY+8C3uvjEaxX44=; b=Fbb7b4n4biCV2AZ+9eGXBxYBFg u9vI/HOhz5HPrPmGkt8DXEBgPiRSSjKQqSIwqbgu/OwlGfqwo5St2paSJtEVLpNkSPnIvF8JIx9X+ mPGFwsWrxwqu/bfS8r71+/0NhSnvVPOCQLPMMHkdlWke13bmNYxA5hsrTOyPu22/7uIk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160537: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=cead8c0d17462f3a1150b5657d3f4eaa88faf1cb X-Osstest-Versions-That: xen=e680cc48b7184d3489873d6776f84ba1fc238ced From: osstest service owner Date: Tue, 30 Mar 2021 13:01:26 +0000 flight 160537 xen-unstable real [real] flight 160555 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160537/ http://logs.test-lab.xenproject.org/osstest/logs/160555/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 18 guest-localmigrate/x10 fail pass in 160555-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 160492 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160517 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160517 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160517 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160517 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160517 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160517 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160517 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160517 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160517 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160517 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160517 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass version targeted for testing: xen cead8c0d17462f3a1150b5657d3f4eaa88faf1cb baseline version: xen e680cc48b7184d3489873d6776f84ba1fc238ced Last test of basis 160517 2021-03-29 01:52:19 Z 1 days Testing same since 160537 2021-03-29 19:38:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e680cc48b7..cead8c0d17 cead8c0d17462f3a1150b5657d3f4eaa88faf1cb -> master From xen-devel-bounces@lists.xenproject.org Tue Mar 30 13:22:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 13:22:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103524.197486 (Exim 4.92) (envelope-from ) id 1lREJM-0007Nx-3k; Tue, 30 Mar 2021 13:21:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103524.197486; Tue, 30 Mar 2021 13:21:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lREJM-0007Nj-0P; Tue, 30 Mar 2021 13:21:36 +0000 Received: by outflank-mailman (input) for mailman id 103524; Tue, 30 Mar 2021 13:21:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lREJK-0007Ne-RG for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 13:21:34 +0000 Received: from mail-wr1-x42f.google.com (unknown [2a00:1450:4864:20::42f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f3e6cdcb-ef36-404a-8a31-a9076f44e8b6; Tue, 30 Mar 2021 13:21:33 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id j7so16262858wrd.1 for ; Tue, 30 Mar 2021 06:21:33 -0700 (PDT) Received: from dell ([91.110.221.217]) by smtp.gmail.com with ESMTPSA id m9sm34291744wro.52.2021.03.30.06.21.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Mar 2021 06:21:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3e6cdcb-ef36-404a-8a31-a9076f44e8b6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=LkSzsuk6OkyHhMGQ1Io4HJGGD7LNCqzmJHjPWX4H0o8=; b=F1neuwXtz2jRrEO3s517BZAonUG9yq+a+buAzWhClqrFM43jqzvc07jkCvWF5txvUi sfjwuWoIzE8Eh3kFlUXyoC4iNUL1aycY1lpLUUKk/gmhbRnfpMzA1ckl86/YANQQPxE+ r+cBg8JayJKdSSSGOOL7O5GAgbJB07wqKLKA0AIV28CWFa/mDLsZghznGf27CxSLaapP UgvecC8skd71MO6Q6iQaxkGe3pvMEFaxMQSibQiuX3k2XqvNG1eoqDqkbjI4Cfw6SOQp FK4OvJmZlREKEbpUWJm/NFpskLZrRUPGLT+uQSlz2sOpYBDH8nhUVsAVTcAYrtqOuhJa E9IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LkSzsuk6OkyHhMGQ1Io4HJGGD7LNCqzmJHjPWX4H0o8=; b=AOiESaY96EJ8CbeKaAyB4lSXK1RGwbOCY2pB4MDvB3t4HPZE74gI3xLp8N/CHpdwMo qaiQFY+hy1MzoKF9lBPY4LZ5bpsqOHqfztoKcZ2m1DFhPM41X4/x5+OS85nlXruiKj82 m5MlbeA/DkHIIEXbVkx9EibUkrQ4Fz4lkd9rcG7EOllZQre8DkkGWZVbQgFDELiMWMu0 jkcf/RVOH9z4NuPaMW/UcMfEPzZyMSH1vf5c3ekLuvqTraIHCp1Naq3huTLWyCKBgnQN BRZOrV4hb8I0biX7Y8eBULe8fTl2oBW4LFDqsSXmYK1UN35fx5G+WYaA2J8Ll3flTW6L cW4Q== X-Gm-Message-State: AOAM530zcjuqQKEnca5rDaNDrM4NU4dZsw6+p2dVORuv7ThMwJ/DQfje +4mV97Ab9G90RWv7D/Ecen3E6A== X-Google-Smtp-Source: ABdhPJz9oD6yg4b32zNBbtgJAbD0h97AdahA/HWCNM/n6pjsO2hXvdH3WUU3ljzj3XmMUS4sQ/OGZA== X-Received: by 2002:a5d:6a11:: with SMTP id m17mr35100628wru.361.1617110492938; Tue, 30 Mar 2021 06:21:32 -0700 (PDT) Date: Tue, 30 Mar 2021 14:21:30 +0100 From: Lee Jones To: linux-kernel@vger.kernel.org, Boris Ostrovsky , drbd-dev@lists.linbit.com, Jens Axboe , Joshua Morris , Juergen Gross , Konrad Rzeszutek Wilk , Lars Ellenberg , linux-block@vger.kernel.org, Philip Kelleher , Philipp Reisner , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH 00/11] Rid W=1 warnings from Block Message-ID: <20210330132130.GK2916463@dell> References: <20210312105530.2219008-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210312105530.2219008-1-lee.jones@linaro.org> On Fri, 12 Mar 2021, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (11): > block: rsxx: core: Remove superfluous const qualifier > block: drbd: drbd_interval: Demote some kernel-doc abuses and fix > another header > block: mtip32xx: mtip32xx: Mark debugging variable 'start' as > __maybe_unused > block: drbd: drbd_state: Fix some function documentation issues > block: drbd: drbd_receiver: Demote non-conformant kernel-doc headers > block: drbd: drbd_main: Remove duplicate field initialisation > block: drbd: drbd_nl: Make conversion to 'enum drbd_ret_code' explicit > block: drbd: drbd_main: Fix a bunch of function documentation > discrepancies > block: drbd: drbd_receiver: Demote less than half complete kernel-doc > header > block: xen-blkfront: Demote kernel-doc abuses > block: drbd: drbd_nl: Demote half-complete kernel-doc headers Would you like me to resubmit these? > drivers/block/drbd/drbd_interval.c | 8 +++++--- > drivers/block/drbd/drbd_main.c | 30 +++++++++++++++--------------- > drivers/block/drbd/drbd_nl.c | 17 ++++++++++------- > drivers/block/drbd/drbd_receiver.c | 26 ++++++++++++-------------- > drivers/block/drbd/drbd_state.c | 7 ++++--- > drivers/block/mtip32xx/mtip32xx.c | 2 +- > drivers/block/rsxx/core.c | 2 +- > drivers/block/xen-blkfront.c | 6 +++--- > 8 files changed, 51 insertions(+), 47 deletions(-) > > Cc: Boris Ostrovsky > Cc: drbd-dev@lists.linbit.com > Cc: Jens Axboe > Cc: Joshua Morris > Cc: Juergen Gross > Cc: Konrad Rzeszutek Wilk > Cc: Lars Ellenberg > Cc: linux-block@vger.kernel.org > Cc: Philip Kelleher > Cc: Philipp Reisner > Cc: "Roger Pau Monné" > Cc: Stefano Stabellini > Cc: xen-devel@lists.xenproject.org -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From xen-devel-bounces@lists.xenproject.org Tue Mar 30 14:22:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 14:22:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103548.197508 (Exim 4.92) (envelope-from ) id 1lRFG2-0005Jw-Gv; Tue, 30 Mar 2021 14:22:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103548.197508; Tue, 30 Mar 2021 14:22:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRFG2-0005Jp-Dx; Tue, 30 Mar 2021 14:22:14 +0000 Received: by outflank-mailman (input) for mailman id 103548; Tue, 30 Mar 2021 14:22:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRFG0-0005Jk-Mv for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 14:22:12 +0000 Received: from userp2130.oracle.com (unknown [156.151.31.86]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c2613fa1-64e4-4c20-ba47-67d24bcd6576; Tue, 30 Mar 2021 14:22:11 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12UEJ6jG136038; Tue, 30 Mar 2021 14:22:09 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 37hv4r7e3g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Mar 2021 14:22:09 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12UEKo4v114781; Tue, 30 Mar 2021 14:22:08 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2109.outbound.protection.outlook.com [104.47.58.109]) by aserp3020.oracle.com with ESMTP id 37jekym2wd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Mar 2021 14:22:08 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BYAPR10MB3365.namprd10.prod.outlook.com (2603:10b6:a03:15a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Tue, 30 Mar 2021 14:22:06 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.033; Tue, 30 Mar 2021 14:22:06 +0000 Received: from [10.74.96.157] (138.3.201.29) by SA0PR11CA0183.namprd11.prod.outlook.com (2603:10b6:806:1bc::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Tue, 30 Mar 2021 14:22:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2613fa1-64e4-4c20-ba47-67d24bcd6576 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=hnP7IGQbW/1jxTwXpPFxZmKyHXY7XTWQhBlCiFkNxEg=; b=GKZ0sGdHnmA80OOGcMacXXcBS56StwQF0praPj+m0YFPMDJCGznbM4ZZ2qAAX3Grmj0o 0OiB0rVMn+3j4c6HvYYMIXBZLcl7dOPrmhu8gLnnD519yasBuoZb7aBHvSfNOrSJ2fet foq7ZtpI/P5U1gQvu6PmFlLrtvjwgkSOYBIgkdppNKPTIxSSu2mosKDvxLST4mlUqOcJ P4wGzc+/9+5170OmQYJfequUaSHt96ZioW1Tbs+Cr23ozkTg8W8iT62rlwTTV2tnt1xz 6eWLx8tL8SXaB5ZoxlKs+nyheeZ/mrro6Edp956/AM+Bq8s+fbkAns3io0tG29BIE5eP Ug== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WdE4GKtw9Cv360rKb4Z8mm7ATo/lhxjmx8O5kVYM53SIl5wOKeahgJ+66ax/DsjBRD85QcYVGtGRfqXLU1MFqfeHYz5fQQCd0S9fCBCQuHIAg6BRj5jdEKXFJq10mGwyMT/Zuwu+Rjp4eaieUKTMWxr7faIXvOr/Ix9q0i5VHa6fNfK688193EXlhiQpkVobr93mgmPnYeo4xqMTxabcWm+fxAWwMe2dfDbb+amksQ5eDiTGTcgWO2ocxiICxGX75nJfcFQL3JnCTwOv91hjtrMLZHeqQNJTjPLZuhRwg4Z0pF/mRsjKvM8FEh4fCSR6Z4zjIY/MsAT3sk0sOQAsXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hnP7IGQbW/1jxTwXpPFxZmKyHXY7XTWQhBlCiFkNxEg=; b=BRbgerVCX0WL93it/97Rp5JLBIKhUuTLnXBi0nrPShdZGNH82Kq66XXBZTxISKloaoKc4yaoV2qcoaVfMSO0nFOzK0ELKlBE5FZMS71+7mNIsPSagZDD8pLztyX2y7gVKKoNkWpecwN6hZziG+YTf49RYSvUPhOMGMDRloGujh4jC+LScH7fbFiM3bQW7W8+nwaOAncrz5OhV+DgsW+09P329a8raU6p0z9gXUA9JlowXDYzTD7xYGKyA3W5Mph26PI1/QfdCpu0xd0QOlGi9C5urzd7rO/4pVtb8CCw9k/m+RRQat/BlH5AEVSSmM7WyjlJf4bkQN3c4w168RaPYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hnP7IGQbW/1jxTwXpPFxZmKyHXY7XTWQhBlCiFkNxEg=; b=JGwk1X0aYuBBtvcOxk2MzqNcQnLmPamH+IN5Tes3zVGcddrEvCxxteSOKd0/7vcsCE2M7N9UWblku9d9vvvyCaRbzNXVjpbzBJbzKZXJKIYk/diJocZP6/vN6/29URBTD86thFlUXEFSqd0Qskc9AF2t5fss8JpmgRXYHLnynLw= Authentication-Results: xenproject.org; dkim=none (message not signed) header.d=none;xenproject.org; dmarc=none action=none header.from=oracle.com; Subject: Re: [PATCH v3 2/2] x86/vpt: Simplify locking argument to write_{un}lock To: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com, iwj@xenproject.org References: <1617052502-14181-1-git-send-email-boris.ostrovsky@oracle.com> <1617052502-14181-3-git-send-email-boris.ostrovsky@oracle.com> <7a2e901c-b14c-8969-3b9a-41874dd2a7c4@suse.com> From: Boris Ostrovsky Message-ID: <2604ea82-c41a-7927-a43d-452170f17a1e@oracle.com> Date: Tue, 30 Mar 2021 10:22:01 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 In-Reply-To: <7a2e901c-b14c-8969-3b9a-41874dd2a7c4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [138.3.201.29] X-ClientProxiedBy: SA0PR11CA0183.namprd11.prod.outlook.com (2603:10b6:806:1bc::8) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: af343cdc-3e38-4742-779f-08d8f3873253 X-MS-TrafficTypeDiagnostic: BYAPR10MB3365: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tdLEfWjHcb13ei8dpOZZ3XZ6kVQYf3wuVkcaumUTgAY38V+GMALKRU1puhmGsQPDyl88hlSdI7H+Gu3k/6QTgeAxDiOr7NxJwkWbvz0t4oXgMR/6ln6yS2Ol3QH7SzjHnG1VisYyWIdM+hq0/fowlTfU/cPO2dpJSTWMF+1XCCJcnXv1XcOmnYs/JE7FS2oRjGQz/7IFqD2yn6mELjt5ch6Onb4Oe18m2DSTAmX4Mm9LeB8ij5oqKN4FwTqe4ADmLQpWihlH7RVtH5vWyEzf7fjEcUPLdXZlDyFrvybr7YmVmSGaAWr1sOK34yoIinOnyMUQeUe3bX7FFVrHJKnQEJgVKJJzLnJAVg4LfWweB3DakLkSfnlptohgDRZGuXRmrwFgeSeEFg2bTfcb/AJtGOOAcqV32jZWh5Tj2kWj8Ss710yLedTgylNeN84aaEMh6Urf6e0z7eHmGCcdkg3KHOH0Yz/5PHe/l2phm+B24VwQF83D733N0b3TVnOu2GwNHedbpCHVNPPQRcP52XyBhm8HllQBl8T5oPTVm0uBoE4EqOhLuo8O7hPSJNiCuZLeGyJUej15fOO7QG9enut2yjEmrQsBy997tmyBMX9mVx0cU8oPMw533ptbPanfGVHVBYS0fR5JCpbVZi3Xy9g1O48/TNxo7ogSbY4OhTHJAd9TfEfoQXXAHCnWDFadZApqWUE8JYPQhaSNtYMHlMyBlV9EkdARU4Mg0ERluxNSQTw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(136003)(346002)(39850400004)(366004)(376002)(36756003)(53546011)(8936002)(5660300002)(66946007)(110136005)(956004)(2616005)(66556008)(86362001)(38100700001)(186003)(31686004)(83380400001)(478600001)(6486002)(16526019)(66476007)(316002)(16576012)(6666004)(4326008)(26005)(2906002)(8676002)(44832011)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?TkxGdTVldlpscHlHUlNlRDhZa2M0SVRyclJCNnkyc0NQZW5Ub2RkQVVoWFNV?= =?utf-8?B?QmVQQ1NkZysyd0dmaW5kZUowOXJVeGt3cTJuaEpIcmJvRHN6cGhLSktCaE1p?= =?utf-8?B?V2FuNHlnU0crRDhuU2F0YmVldzNpZFZrQi9ldEp1cFB2dTJSSUx2OTdiK0pO?= =?utf-8?B?K1lITm1FZ1FIUklybm10MVNpQWIwM1VaT3ZqOGRSbzRCbnNXUmxPYmcvRkpB?= =?utf-8?B?RXhlcHNwVWE2b1lRQitmTWxPbTJVQnRHZUhpSVpyL2JRZEozY1kvdHcwYnJE?= =?utf-8?B?bWtIZ2wrOUZhVFRHaER4eVQ2cjZ1ckhQbUt3RjA2ME80eFZKVEJNeFJCRnNh?= =?utf-8?B?WklyZ3hlZUU0VHBueFNubGJtUjgwN1BnUVcyYldqejZhaVJtQkxBOWQwSjd1?= =?utf-8?B?NUMrYWM2SlVMODZLTndWcHQvTHVKZTB1RXl0dEg1MGxxdkhmY1krdG8yMnpt?= =?utf-8?B?d2h0Nm5VVDI0ZXFvb1FJVUN6WmpVQVFQdTBJSE5JNVV2RC80YmhFSzdrM2li?= =?utf-8?B?Q2N0SytMNHZ2UXR6ZHlWcU92OW9PVVgzOU1YRTVtME10OHA3OUs3Zy9mVGp3?= =?utf-8?B?cmZvQlVHaS9zY0pXZEFiRlM4djBDUWFzNUM5NkNVRDIzM2VjMCtnVDlKT2xj?= =?utf-8?B?R3pqa2p1L1JqMnJLbmVkSDlwK1pXdVFzYTdQaTZJb01Bc0xCR25PZlhNdjBq?= =?utf-8?B?T1BlWDk0TmNpajU1RDNvcUdCZU9ONXgzbGZ2OEg1czBqTXBXbnlNUVZEbEto?= =?utf-8?B?bmdIZW1oSnZUSm5sREQvSlc0YkRJbHhIWE5Eb29CdUFiWTZmRmxjVVVEYTJM?= =?utf-8?B?Z3JWUUdJTHVYQTNXSXNmTnRVajJybE1jbDd0amsyS09hUExucWQwcDZMb2NF?= =?utf-8?B?STRTczdDMUNObURmUGVnYWtUNEI0ODR6RG1EUTBONlZZcXdlWlRYVkxpY3RR?= =?utf-8?B?YVZHc1ozbEhpRmpnSUNTL0RoQnBRRGlVWjYvWHFmNHVTN3BoQ0ZrVXAvdHBk?= =?utf-8?B?a2JHenRoN1BESXZpQTU1L2JiVGFBcjlDd1NuTW1vU3U3N0dQME1lMnlxR00x?= =?utf-8?B?T3psL0JWakQvYkpEK3pFNXhxOXFCOS8yYUdQcEM1NVpGMnNmS1FOdFFMTHhv?= =?utf-8?B?QkFKTWVQY1Y0U0NKZUhkR1ZHM050N051ajIyR3pZUVkzY2lkei9PS2VXb2lR?= =?utf-8?B?ZDJhSUFod3NGRFNRWU83M2hna2docERwR2FCeXgvTnBoVUp4L1NiMlloVHBo?= =?utf-8?B?Q25aVlhYa0xQWTQ1QnRjM3dwdzdpdzM2V0R0NGloaGFDVkx3bnp4LzVNYUFt?= =?utf-8?B?VW90WkpCNW5NalRNTFFHWmxkUUtXSjlHZldML0F5Vk8wYUMreVB0YXBUNjVt?= =?utf-8?B?bmJIbzZnSE01LzVDUHFxOEoreFozNk1kclI3b29RMS9lM2dXdEppTUNhNGo4?= =?utf-8?B?U1Z0bCtxbWRNTHZjTHlucE9OUVNpR1pOaFdZbjFkaG1FdERHRlRxTG1JK3c5?= =?utf-8?B?QWlDOHBPaDR1QkRnaENwOWd1K0ZqZ2EwNEI3bTNNTVMvSSt3dUM0OHoxejdn?= =?utf-8?B?dVNRQ2Y1UEVtb2dxdkQybWRkb2xTUi95RGpidEpTVFdxOHZ3aVdSWk1hRGd1?= =?utf-8?B?MjNyTWhkaHVzc3RwOHdKU2U0S29HcUFKTnBpL1psU2lremkrYXA4L0t6QVpC?= =?utf-8?B?WXpqMytwenNlYmdkNXZaQUUwNzh5NFFGL1lpay9qT21TMU1QQnBXb093YkhQ?= =?utf-8?Q?qZizQrePJjHnIohfSOfEdHJhmlRTk6+lQx4yfAh?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: af343cdc-3e38-4742-779f-08d8f3873253 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2021 14:22:06.4829 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FRvMYHGE3peZRDm7CK8i7kAbhnoHZMZIb3ISeRLVJ4qUjuz9kmzqzYIQIFohdZAfsds3XevzbmjRGErtNs8VJ936jCMjiHkEiR3iWMdJAKo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3365 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9939 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103300105 X-Proofpoint-ORIG-GUID: dYf6NIq4Ymavq3-idlZJpTLteICTFA6t X-Proofpoint-GUID: dYf6NIq4Ymavq3-idlZJpTLteICTFA6t X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9939 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 phishscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 suspectscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103300105 On 3/30/21 8:49 AM, Jan Beulich wrote: > On 30.03.2021 09:36, Roger Pau Monné wrote: >> On Mon, Mar 29, 2021 at 05:15:02PM -0400, Boris Ostrovsky wrote: >>> Make both create_periodic_time() and pt_adjust_vcpu() call >>> write_{un}lock with similar arguments. > This makes it sound like you adjust both functions, but really > you bring the latter in line with the former. Would you mind me > adjusting the wording along these lines while (and when) > committing? Yes, please. > >> Might be worth adding that this is not a functional change? >> >>> Requested-by: Jan Beulich >>> Signed-off-by: Boris Ostrovsky >> Either way: >> >> Reviewed-by: Roger Pau Monné >> >>> --- >>> New patch. >>> >>> I ended up doing what Jan asked --- create_periodic_time() is also using different >>> start pointers in lock() and unlock(). >> Hm, I'm not sure I'm following, create_periodic_time uses 'v' in both >> write_{un}lock calls, which doesn't change across the function. > I guess Boris merely meant to express that there's already precedent? Yes, that's what I wanted to say. But clearly not what I actually said. -boris From xen-devel-bounces@lists.xenproject.org Tue Mar 30 14:31:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 14:31:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103554.197521 (Exim 4.92) (envelope-from ) id 1lRFOw-0006RA-Ev; Tue, 30 Mar 2021 14:31:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103554.197521; Tue, 30 Mar 2021 14:31:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRFOw-0006R3-BC; Tue, 30 Mar 2021 14:31:26 +0000 Received: by outflank-mailman (input) for mailman id 103554; Tue, 30 Mar 2021 14:31:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRFOu-0006Qw-Be for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 14:31:24 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f3d5c056-aaa4-4211-a677-65f5fcd2a8a9; Tue, 30 Mar 2021 14:31:23 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 98A17B30E; Tue, 30 Mar 2021 14:31:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3d5c056-aaa4-4211-a677-65f5fcd2a8a9 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617114682; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ljuuwqZq7fHjy/HZCYWcM8ceacV28zSia7RS3f7Phv8=; b=rvebCMpO/dl/+oO6Hhvu9taIOvI8TMDs22PSbLy+dauzoPGcOJOjARHxyOTQJIXHo1DS7A xvAPHsc039CaYB4XJbSYj9s5Sz1QJLiY1bZ7IbYV7o9rN9tPReMUZompGxwHkl6gyqnZ5h wk3q/f4FiCiDV4cT7YwbTm3bTGZpAgs= Subject: Re: [PATCH 0/2] Introducing hyperlaunch capability design (formerly: DomB mode of dom0less) To: "Daniel P. Smith" Cc: christopher.w.clark@gmail.com, andrew.cooper3@citrix.com, stefano.stabellini@xilinx.com, jgrall@amazon.com, Julien.grall.oss@gmail.com, iwj@xenproject.org, wl@xen.org, george.dunlap@citrix.com, persaur@gmail.com, Bertrand.Marquis@arm.com, roger.pau@citrix.com, luca.fancellu@arm.com, paul@xen.org, adam.schwalm@starlab.io, xen-devel@lists.xenproject.org References: <20210316031814.10311-1-dpsmith@apertussolutions.com> <6314f50f-b4fc-e472-4c9a-3591e168d2c3@apertussolutions.com> From: Jan Beulich Message-ID: Date: Tue, 30 Mar 2021 16:31:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <6314f50f-b4fc-e472-4c9a-3591e168d2c3@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 16.03.2021 04:56, Daniel P. Smith wrote: > To assist in reading, please find attached rendered copies of the design > docs. It should be noted that due to poor rendering by pandoc, we forced > the tables to stay as ASCII tables in the patches whereas the attached > docs have the tables rendered properly by rst2pdf. In section 3.6 I found "As a result, on x86 the hyperlaunch capability does not rely on nor preclude any specific BIOS boot protocol, i.e legacy BIOS boot or UEFI boot. The only requirement is that the boot loader supports the Multiboot2 (MB2) protocol." I'm afraid the two sentences contradict one another, as UEFI on its own doesn't provide MB2 functionality. It is my understanding that you don't require this anyway - what you need is a way to load modules beyond just Dom0 kernel and an initrd. I'm also struggling to see how you mean to associate the (MB2) modules passed to Xen with the individual functions. I.e. I don't see how it will be ensure that the embedded mb-index is in sync with the order or modules actually supplied. As to modules - iirc there are placement restrictions by at least some boot loaders (below 4Gb). If that's correct, do you have any thoughts towards dealing with the limited space available to hold these modules? I've seem systems with lots of memory, but with as little as just 1Gb below the 4Gb boundary. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 30 15:20:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 15:20:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103563.197539 (Exim 4.92) (envelope-from ) id 1lRGAh-00032K-Bz; Tue, 30 Mar 2021 15:20:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103563.197539; Tue, 30 Mar 2021 15:20:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGAh-00032D-8l; Tue, 30 Mar 2021 15:20:47 +0000 Received: by outflank-mailman (input) for mailman id 103563; Tue, 30 Mar 2021 15:20:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGAf-000325-MY; Tue, 30 Mar 2021 15:20:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGAf-0006tj-Be; Tue, 30 Mar 2021 15:20:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGAe-0002BC-W8; Tue, 30 Mar 2021 15:20:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRGAe-0005AD-Vg; Tue, 30 Mar 2021 15:20:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YsvL4+mj50N4LeZW3ZLxOr/er5WTyIBxu62lnkUoxjg=; b=5HkPdVlnzNxBsafVr65/kNGWOt C1c7AbMOK24IwWXhvmHcGfdHuVtI5pB+CHD504Ysg9BccBd7bRdG6YrG5pJTMaSkZEHI3XTOydhf0 b2gDbORYsgoWdtH+2yyxNsiUSc7/ylCQN6hdjVSSt/cQrFzgBofhEkIfMXtHaG/PW0mo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160541: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=ec2e6e016d24bd429792d08cf607e4c5350dcdaa X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Tue, 30 Mar 2021 15:20:44 +0000 flight 160541 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160541/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu ec2e6e016d24bd429792d08cf607e4c5350dcdaa baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 222 days Failing since 152659 2020-08-21 14:07:39 Z 221 days 418 attempts Testing same since 160541 2021-03-29 22:44:20 Z 0 days 1 attempts ------------------------------------------------------------ 468 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 138381 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 30 15:21:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 15:21:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103568.197554 (Exim 4.92) (envelope-from ) id 1lRGAz-0003Jy-U7; Tue, 30 Mar 2021 15:21:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103568.197554; Tue, 30 Mar 2021 15:21:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGAz-0003Jq-QJ; Tue, 30 Mar 2021 15:21:05 +0000 Received: by outflank-mailman (input) for mailman id 103568; Tue, 30 Mar 2021 15:21:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGAx-0003BT-TM for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 15:21:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7d8b7aba-23d3-43d0-bf25-f3e86880361e; Tue, 30 Mar 2021 15:21:02 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 45424B090; Tue, 30 Mar 2021 15:21:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d8b7aba-23d3-43d0-bf25-f3e86880361e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617117661; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZK9XnRQ2r2TuoLAwRNNkf3RMjShk6frjeRoB81m4JcQ=; b=OFbhKwaWaAs4k/2Q7C0b7PvakySvXUNCrCe5GVPIZVlBwBJk5q1aLrC9907SCcPN10ISaZ GjNZsLuVJtKNhB1a6i8d86dKmXhunL2d2vOMGYsCZQ4wqfr81GJdq3R2RlW0j8jMgXwhuk SCsAQusGYrfz3wY+6067dxyvwm8sT6Y= Subject: Re: [PATCH 01/21] libxl: don't ignore the return value from xc_cpuid_apply_policy To: Roger Pau Monne Cc: Andrew Cooper , Ian Jackson , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-2-roger.pau@citrix.com> From: Jan Beulich Message-ID: <3a8eb714-563f-02b7-3098-6479789d7e8b@suse.com> Date: Tue, 30 Mar 2021 17:21:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210323095849.37858-2-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 23.03.2021 10:58, Roger Pau Monne wrote: > Also change libxl__cpuid_legacy to propagate the error from > xc_cpuid_apply_policy into callers. > > Signed-off-by: Roger Pau Monné This looks to do what it means to do and also none of the present callers of the functions modified here ignore the return values, so Reviewed-by: Jan Beulich I wonder however how to ensure similar problems won't get re-introduced down the road. In the hypervisor I'd recommend adding __must_check everywhere, but I have no idea what the tool stack policy is in this regard. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 30 15:35:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 15:35:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103600.197584 (Exim 4.92) (envelope-from ) id 1lRGOS-0004nA-Gh; Tue, 30 Mar 2021 15:35:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103600.197584; Tue, 30 Mar 2021 15:35:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGOS-0004n3-DS; Tue, 30 Mar 2021 15:35:00 +0000 Received: by outflank-mailman (input) for mailman id 103600; Tue, 30 Mar 2021 15:34:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGOR-0004my-HB for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 15:34:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGOR-00079Q-Bs; Tue, 30 Mar 2021 15:34:59 +0000 Received: from [54.239.6.177] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRGOR-0000qJ-4g; Tue, 30 Mar 2021 15:34:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=ENy+w1fUJSGrmxhLkjF6WQR4E5cG0tivYMMh+onII4Q=; b=zq5wQIxdBGKBPWqwIdZNy1obkX v22NJ2j4X+sGz2AbU22MEqmA+b9bV07uROmbBr3W2/0lPqVA5qrXWljEwlzq7intTXJ0b2tMThvo8 EJP0rzvj8gdEumY1DP6mhoffKuM3rxybU7l+0CS63Wei/XcjuCjxK4QTodHhmgI03VoQ=; Subject: Re: [PATCH v2 for-4.15 3/7] CHANGELOG.md: Add dom0/domU zstd compression support To: Jan Beulich , Julien Grall Cc: xen-devel , Ian Jackson , Andrew Cooper , George Dunlap References: <20210329161457.345360-1-george.dunlap@citrix.com> <20210329161457.345360-3-george.dunlap@citrix.com> <87E259CB-2BB4-4BAE-9916-BE46584E0EF4@citrix.com> <672c88ac-8373-6629-4d2f-0d1e86c103cd@suse.com> From: Julien Grall Message-ID: <92f0b44a-84de-457c-ba04-896644382905@xen.org> Date: Tue, 30 Mar 2021 16:34:57 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <672c88ac-8373-6629-4d2f-0d1e86c103cd@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 30/03/2021 11:56, Jan Beulich wrote: > On 30.03.2021 12:14, Julien Grall wrote: >> >> >> On 30/03/2021 11:08, George Dunlap wrote: >>> >>> >>>> On Mar 29, 2021, at 7:54 PM, Julien Grall wrote: >>>> >>>> Hi George, >>>> >>>> On Mon, 29 Mar 2021 at 17:15, George Dunlap wrote: >>>>> diff --git a/CHANGELOG.md b/CHANGELOG.md >>>>> index 8c89212f14..538eae611c 100644 >>>>> --- a/CHANGELOG.md >>>>> +++ b/CHANGELOG.md >>>>> @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>>>> - ARM SMMUv3 (Tech Preview) >>>>> - Intel Processor Trace support (Tech Preview) >>>>> - Named PCI devices for xl/libxl >>>>> + - Support for zstd-compressed dom0 and domU kernels >>>> >>>> Looking at the log, the feature looks x86 only (at least the dom0 part). >>> >>> Oh, interesting. So what about the following? >>> >>> - Support for zstd-compressed dom0 (x86) and domU kernels >> >> Sounds fine to me. Note that I haven't tried zstd-compressed for domu >> Kernel on Arm. >> >> Maybe the author (Jan) can confirm whether this was plumbed in common >> libxc code? > > Well, I've followed the model used for other compression methods. I have > no idea what this means or does not mean for Arm; in fact so far I was > under the impression that like in the hypervisor decompression support > was an x86-only feature, but from what you say I conclude I have been > wrong with this. We support gzip for dom0. For guests, I am not entirely sure what the state as I tend to uncompressed kernel every time. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 30 15:35:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 15:35:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103602.197596 (Exim 4.92) (envelope-from ) id 1lRGOw-0004rY-Qn; Tue, 30 Mar 2021 15:35:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103602.197596; Tue, 30 Mar 2021 15:35:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGOw-0004rR-Mi; Tue, 30 Mar 2021 15:35:30 +0000 Received: by outflank-mailman (input) for mailman id 103602; Tue, 30 Mar 2021 15:35:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGOu-0004rG-RA for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 15:35:28 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 70576b5a-b9cb-4ff8-a586-6789dd8ba031; Tue, 30 Mar 2021 15:35:27 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 70D5DB329; Tue, 30 Mar 2021 15:35:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70576b5a-b9cb-4ff8-a586-6789dd8ba031 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617118526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eusa7b7NQGkJAejeA4HgrTPPbzeMN+HzITjEZXFV8Ug=; b=rNCMnPYKGyDfz22u0VvxnlVWgieFv+3fTftB+TitZPzcBzlyJC0CySqQsstRqbaIUsIJqE qjugo6OfGzXx1eQwack6tKB8lzJ/VUlK0qlkNr56WIC+LT8NS1QDmmPSlhPmgpS/9/FKmy g8iI7kZWm4L+FUksRhHc7WKCHwbIHlc= Subject: Re: [PATCH 04/21] libs/guest: introduce helper to fetch a system cpu policy To: Roger Pau Monne Cc: Andrew Cooper , Ian Jackson , Wei Liu , xen-devel@lists.xenproject.org References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-5-roger.pau@citrix.com> From: Jan Beulich Message-ID: <6d30e100-3321-a8bd-26bf-38d78d522637@suse.com> Date: Tue, 30 Mar 2021 17:35:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210323095849.37858-5-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 23.03.2021 10:58, Roger Pau Monne wrote: > Such helper is based on the existing functions to fetch a CPUID and > MSR policies, but uses the xc_cpu_policy_t type to return the data to > the caller. > > Note some helper functions are introduced, those are split from > xc_cpu_policy_get_system because they will be used by other functions > also. > > No user of the interface introduced on the patch. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich with just one minor remark below: > --- a/tools/include/xenctrl.h > +++ b/tools/include/xenctrl.h > @@ -2596,6 +2596,10 @@ typedef struct cpu_policy *xc_cpu_policy_t; > xc_cpu_policy_t xc_cpu_policy_init(void); > void xc_cpu_policy_destroy(xc_cpu_policy_t policy); > > +/* Retrieve a system policy, or get/set a domains policy. */ > +int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx, > + xc_cpu_policy_t policy); > + > int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); > int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, > uint32_t *nr_features, uint32_t *featureset); > diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c > index ade5281c178..3710fb63839 100644 > --- a/tools/libs/guest/xg_cpuid_x86.c > +++ b/tools/libs/guest/xg_cpuid_x86.c > @@ -687,3 +687,93 @@ void xc_cpu_policy_destroy(xc_cpu_policy_t policy) > free(policy->msr); > free(policy); > } > + > +static int allocate_buffers(xc_interface *xch, > + unsigned int *nr_leaves, xen_cpuid_leaf_t **leaves, > + unsigned int *nr_msrs, xen_msr_entry_t **msrs) > +{ > + int rc; > + > + *leaves = NULL; > + *msrs = NULL; > + > + rc = xc_cpu_policy_get_size(xch, nr_leaves, nr_msrs); > + if ( rc ) > + { > + PERROR("Failed to obtain policy info size"); > + return -errno; > + } > + > + *leaves = calloc(*nr_leaves, sizeof(**leaves)); > + *msrs = calloc(*nr_msrs, sizeof(**msrs)); > + if ( !*leaves || !*msrs ) > + { > + PERROR("Failed to allocate resources"); > + free(*leaves); > + free(*msrs); > + return -ENOMEM; > + } > + > + return 0; > +} > + > +static int deserialize_policy(xc_interface *xch, xc_cpu_policy_t policy, > + unsigned int nr_leaves, > + const xen_cpuid_leaf_t *leaves, > + unsigned int nr_msrs, const xen_msr_entry_t *msrs) > +{ > + uint32_t err_leaf = -1, err_subleaf = -1, err_msr = -1; > + int rc; > + > + rc = x86_cpuid_copy_from_buffer(policy->cpuid, leaves, nr_leaves, > + &err_leaf, &err_subleaf); > + if ( rc ) > + { > + ERROR("Failed to deserialise CPUID (err leaf %#x, subleaf %#x) (%d = %s)", > + err_leaf, err_subleaf, -rc, strerror(-rc)); > + return rc; > + } > + > + rc = x86_msr_copy_from_buffer(policy->msr, msrs, nr_msrs, &err_msr); > + if ( rc ) > + { > + ERROR("Failed to deserialise MSR (err MSR %#x) (%d = %s)", > + err_msr, -rc, strerror(-rc)); > + return rc; > + } > + > + return 0; > +} > + > +int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx, > + xc_cpu_policy_t policy) > +{ > + unsigned int nr_leaves, nr_msrs; > + xen_cpuid_leaf_t *leaves = NULL; > + xen_msr_entry_t *msrs = NULL; > + int rc; > + > + rc = allocate_buffers(xch, &nr_leaves, &leaves, &nr_msrs, &msrs); > + if ( rc ) > + { > + errno = -rc; > + return -1; > + } > + > + rc = xc_get_system_cpu_policy(xch, idx, &nr_leaves, leaves, &nr_msrs, msrs); > + if ( rc ) > + { > + PERROR("Failed to obtain %u policy", idx); > + rc = -1; > + goto out; > + } > + > + rc = deserialize_policy(xch, policy, nr_leaves, leaves, nr_msrs, msrs); > + if ( rc ) > + errno = -rc; Perhaps also set rc to -1 here for consistency? Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 30 15:37:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 15:37:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103606.197608 (Exim 4.92) (envelope-from ) id 1lRGQV-00050j-5k; Tue, 30 Mar 2021 15:37:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103606.197608; Tue, 30 Mar 2021 15:37:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGQV-00050c-1w; Tue, 30 Mar 2021 15:37:07 +0000 Received: by outflank-mailman (input) for mailman id 103606; Tue, 30 Mar 2021 15:37:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGQT-00050U-3H for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 15:37:05 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 45e71df3-201f-4986-ae9e-db6bcb50e0ce; Tue, 30 Mar 2021 15:37:04 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4FF91AFF9; Tue, 30 Mar 2021 15:37:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45e71df3-201f-4986-ae9e-db6bcb50e0ce X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617118623; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=emOCP43U5HD3LXM1xmMO0uasduBk5tfij7cy9KsNKUA=; b=CAJmUc0xWPmBVNqEUyC9EtU3524mpwsEPdaFWFSU0r8AJtqvGJKRMQyCksWegQg4Lzd9+T 2ow0ydq3pq4UbqKAUB7aK71obG3AGl9H3QEtRmqCoQn7F4qVqbdPX3D5HSBA3S8P8WoIPH QMTDqAFhnmeuTEGB1D49/fqyO8NmS/c= Subject: Re: [PATCH 05/21] libs/guest: introduce helper to fetch a domain cpu policy To: Roger Pau Monne Cc: Andrew Cooper , Ian Jackson , Wei Liu , xen-devel@lists.xenproject.org References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-6-roger.pau@citrix.com> From: Jan Beulich Message-ID: <87d48996-6b8b-d801-c43b-30b919244fcb@suse.com> Date: Tue, 30 Mar 2021 17:37:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210323095849.37858-6-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 23.03.2021 10:58, Roger Pau Monne wrote: > Such helper is based on the existing functions to fetch a CPUID and > MSR policies, but uses the xc_cpu_policy_t type to return the data to > the caller. > > No user of the interface introduced on the patch. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich with again a minor remark (plus of course the same that I made for patch 4): > --- a/tools/include/xenctrl.h > +++ b/tools/include/xenctrl.h > @@ -2599,6 +2599,8 @@ void xc_cpu_policy_destroy(xc_cpu_policy_t policy); > /* Retrieve a system policy, or get/set a domains policy. */ > int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx, > xc_cpu_policy_t policy); > +int xc_cpu_policy_get_domain(xc_interface *xch, uint32_t domid, > + xc_cpu_policy_t policy); Generally I'd expect domid_t to be used for domain IDs. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 30 15:39:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 15:39:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103610.197620 (Exim 4.92) (envelope-from ) id 1lRGST-00058i-Hc; Tue, 30 Mar 2021 15:39:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103610.197620; Tue, 30 Mar 2021 15:39:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGST-00058b-ES; Tue, 30 Mar 2021 15:39:09 +0000 Received: by outflank-mailman (input) for mailman id 103610; Tue, 30 Mar 2021 15:39:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGSS-00058W-4b for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 15:39:08 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d480fce4-c8b6-4945-b9e5-4351e0b8ef59; Tue, 30 Mar 2021 15:39:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d480fce4-c8b6-4945-b9e5-4351e0b8ef59 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617118746; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=i4MWx8RKyI2m57Qe4Jvz7OTy7zS3azzQ25k3aG7RPmg=; b=bn3ABwUP7X9coLrk+j8nICiZEVIreuoW0JqoGKCoNe6ButScufH4W2Ku 82+2eSUKPJudWZO5t61DvLRL1gK+arBfTGP+SW5dzUXOvNd+iOM9/vqQo Za8oaBQE53WpFbAIvWpF6BS26XRjpsS3K8QQry6fhUevpa9bdXa/hT6Qq 4=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Kr2+qOSarzQqro3lZndSfU5X6T9R5zdXEGEqxWGGNGSh1YzVq21PzVrb4coxJzcIdfrzq6rnON p3Iwt9LcJjG1nxJGkqJ+/4jtSNj5ZzwejzQUpMqc3ggsc6OrbP41s2XopaZZ74lO3lv01l7Xbl 43TdU1zMIdKco47ybelcyqMrBHd53TKlV3LE6JuuFYPyKTWrvHYk1iMxghUNIkdHkAwExc0E5s Sa/IFa5zGrkSPMuYoKRi332OEGSWgj7dhgerrDnfWNQp1p514XkV1kh3ObnOld4tpZrSSqqHjy W/Q= X-SBRS: 5.2 X-MesageID: 40446671 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:RQUTFaNU9iezusBcTkSjsMiAIKoaSvp033ACy112DSZIeciZit 2jkZ0gpHvJoRwWX2wtns3FHaGGT2/V+5Id2+gsFJ2lWxTrv3btEZF64eLZrAHINiXi+odmuZ tIXLN5DLTLZ2RSrcG/2wWgFsZl/d/vytHKuc7771NACT5ncLth6QARMG2mO2l7XhNPC5Z8NL f03Kp6jgGtc3gWcci3b0NtN9TrnNHFmInrZhQLHXccmWuzpAm14733GQXw5GZ6bxpzx94ZnF Ttokjc3OGOovu7whjT2yv2445NkNXsjvtYQOuAkaEuRAnRtg== X-IronPort-AV: E=Sophos;i="5.81,291,1610427600"; d="scan'208";a="40446671" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aHAnxPtO0J+orWj+R4E/2tJfdLS/NdoDq+zg7CmHKLWJj49y744MlMWRmrzup+d6haCWNSnv/Ly5kMXFQIxsW+4s7Fs+rVCFIFyAnDW5iCu1/uaEDZOdDKv7/ZAdAnEpLIACiqKZcRgygWNFob4c974MnD31XOcvYAeUWqCM3j3qUrEJQyY2HSlqOPF/XrwsyIuSnWTyyd4TMSTSaDteGzZbSKReEERqEhavIg0gcXGL2S8kXCh4S1aU1PaH70dtbhOL5z4rwJkv/P1qcP77ODD33wfjL0O1PQQjV/q15c+nZTohRrIRMULYJU5v79r078rItW3J5X8h1qbmVMoBJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i4MWx8RKyI2m57Qe4Jvz7OTy7zS3azzQ25k3aG7RPmg=; b=EskyG8fLui5vnXhbcWxlPda9+Vteg/c9Q4LtTKrWrP2aEYmioIIqWOBq3CZt1q53GLAqOINp7APB8UkEoE2CzfV7s9MlUffpr4RLY9FT7Nzj64gLPdNHRj8PhN2ER8YeF86zzqBy14d86qwh+08b2Mx6CgATJwHk9/HRd/eU7M9rTMAOH5XteAjaLtweAo/fcYJ9HTPcrqwxWkY7eAJ6/yEWg3anwjXaVYHXrvEqkl9XS5r7ECnV164TnBrqN7L18K/FvpFE1QsnFSFgY5tgA1WTkmJvSVZUv/TV4HY5oe5RDvTy4ANDR30lYalC080nIVRLk6mbxLgGbufANQ6BiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i4MWx8RKyI2m57Qe4Jvz7OTy7zS3azzQ25k3aG7RPmg=; b=mt8oEsJ8s1OjN2lp1VdvBtSspoPgexNgCrvAdBzyzoiZYKtK6vGGlCqcdzNzPp1SNiwxo1Gc85ptdw0TfBRDwshMeGvGKLb+Sm+OlW1IiGqcdmNJcdHJIprMIE3CHcMwqUeK4qvrKOKTyaYG17yP8n8PKt+I4nPf/036xrJjdpg= To: Roger Pau Monne , CC: Ian Jackson , Wei Liu , Anthony PERARD References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-2-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 01/21] libxl: don't ignore the return value from xc_cpuid_apply_policy Message-ID: <62a770d0-7c78-7c57-4de3-280bb999b28f@citrix.com> Date: Tue, 30 Mar 2021 16:38:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210323095849.37858-2-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0264.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::36) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 97de602b-1e3c-4ae3-9154-08d8f391f1c1 X-MS-TrafficTypeDiagnostic: BN6PR03MB2418: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bVC/qBkNQBzuz4BXgIVZmvNe+QrqbVUHH9871mb6XsRqHBuj4BCSfBREsu/YFWUEfdpbCPCtd9/jdvZY2252Cn2n6PCnJ8MpjgcQVVALYFJIXJhju3ioFW2qk3Cxt/w6OXHQazX5KxzAUywwB01M758xwy0mLY8h+IMSU098bWNcYcLD/Rbbiq/pH8Xv03l+HxpTYD5n0YmwvAdOHoBb8mLJl9tHT+jtbhP7PXpphh4WQEF0Bu6p//Y5KaJoxRBJYa9k5NSRlWSp0UV8hQcZ6llYd4QsOHVHyfWje8kc3u7pSZN0dBZCk44Ru8Yu+fIW3/S4s0LQOAK3616G68XbESkRWmszsXQ+MUyspGb99O3hbewPmksk35uY/JO5NKqK6fVMK4CAXzB/aeWWC+jiZxgnWrCJFZOSvqOF7dKy3P/LWX2yJjy9XoaK4h5PwNAnm3oFUy7PfI0sk05fKfChAB8S41FqYAL+lCKuuEnedH7CQm/G8t3YTosDghsgPZGiKyE80WDcVhyL/TvwOibiP/O5DE+NCwGPBLy6K8HaMAZt2kRivdpPS1iamSfMDPMuPlcqRjuMyDuy1GP+HJAG4kQgeB0Zc6N089nmqf9R64idH8XIx8po2yG0U7vpYm7jdewU2YyTkQINAIxI5rB8C4DIe+AGBd6M4eT+E43YC8soNjMb04fQw5HHt0yHstTa16IBiLtVM44+wipJxSP7Ng== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39860400002)(376002)(396003)(136003)(366004)(36756003)(31686004)(8936002)(53546011)(16526019)(186003)(26005)(4744005)(31696002)(478600001)(6486002)(83380400001)(6666004)(66946007)(2616005)(66476007)(66556008)(8676002)(5660300002)(54906003)(86362001)(16576012)(316002)(4326008)(2906002)(38100700001)(956004)(107886003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eUVieGc5UHhYT04yZUxnZ1hRTmRONUdlNXJHOUt4ODk4azB4UFpSRWpNRzdF?= =?utf-8?B?aithbDVxRGEvMkpVSkk4TEszVnNsYlIwUUVtQ2RRQ3E5L21ub2d2SEUzRlVI?= =?utf-8?B?d0pGL09UeURTSnJ0aUxtSGdNanFCUjB6ZitMeUVGM2w5SnBqcURvM25UcXJh?= =?utf-8?B?ekx3N2pCd1E1akpxQ1hVMHMyR2g5WVE3OXh6MjdDclRmaEN0ckhzQnV4MXlq?= =?utf-8?B?TzdaVzhrSk9rb3ZzNlZubUVhaTJLZkZxK2F3K2ZZUVVYYkdOaWpFMzRCN3Bx?= =?utf-8?B?VjR0bCtvVDhuOVl4dFgwWURjZWJ1NnNoQ2x5dkJkWWRoRUY5MDJORUhXcE01?= =?utf-8?B?VXdvTW1tUjJXNGxDbVRVQ3hLWW9TaVMvK3pMUzIyNDl0RzNYM3ZaUEE0Mjl4?= =?utf-8?B?Myt3UVE0QlBVeGZxN21BTWV1WVFXMlpidTlwSC9nKzBQMFZ2cDVBbUlrTzRD?= =?utf-8?B?NFFiWG9XcXNlUEw0MVlFUUVPMU1zeE01d200UEl6WW93eTNxM091bDRNNUJD?= =?utf-8?B?c2x2dTc2K3JBeDNxNUczRnpDb3QzWFIrNFBsU2t6YTFlQW03RUozK1RSS3hP?= =?utf-8?B?Wk5uNFNtZ09LaFY2NlN6QVRpSWNQa2tvN1NkdnZZdXVLV3BFUUExb2NyRTZM?= =?utf-8?B?VjZOalZ3MzloYWFvZTZZbW9Ra0M1aGtkeXNjeGs0b0tSMTBONktvVjUyRE4x?= =?utf-8?B?dldRaDhyMmVKcnBubnAxMThQMWU0dmJyZUVJNTdNTlN0UTlScU1OVmRHU1hN?= =?utf-8?B?bXNDMFZKckh5dEFGRUkxRzBzWnAreVFRbkFPTmZQa2M0SjVYTUM2QzNmYi9Z?= =?utf-8?B?WEt6MVpvYm9jcXpWOStTbWFsY0ZzVGF6aTBOUUpmYlRyQjBWWjUvTDBLazQ3?= =?utf-8?B?cWIyNHlrVlFNY2Z5R1FoYzNNZlVFVm85WE1kU1hFZVFPbDNQbEZpY1BSVjhU?= =?utf-8?B?dS9DalFiNkRlRjltVXd0ZkdrUEM3V2ZvQkxGaHhkMXZzYzN0Nm9TdmVuOTZI?= =?utf-8?B?R0pOcUc3bWR5S1JuT2hqREhqZ1NvRGZGdS9DVFN0bjRKb3VuVWhCMGhQS2F2?= =?utf-8?B?S0JENTREQ1pvT21GNWNJdDJoeWVSbWdZcnh5R3Y1WUNEQ0ROa1dYVTFzcTk0?= =?utf-8?B?YW1FSUwxRVc5K2Frc0xZM29iRFpTakJDbDRYRHVxWEgrc0cwT0FISWpCUmJ4?= =?utf-8?B?WStCb3NqZ2d0a2JyckhaejRCeVlOTG9rWFp5R2k5c3BrT3dQeUNvSVpDOE5W?= =?utf-8?B?dE1VT3dndFBMeC9INDlyRlU1azhTei8zcTFlZmhsS0V5ZUhTY3NsQTB1NEM4?= =?utf-8?B?bDBvN2JoeXcrcFM2ZTgwWUNqR2Z4R1Nwa2FtNGxpZTNZUWs1WFdhOUVuK1FY?= =?utf-8?B?YlVSVkxwSS85L2ZDbUpLbVVjSEVoRmozRy9laHVQM29QQUtCOGN4M3hmZU5t?= =?utf-8?B?UmtubXBWV1RvVTkwUHRxQndOeGllaWhibTQxM0R3VDhkcUQwUlhEbjdwa3VP?= =?utf-8?B?Z1g1WWRaNGlPMy8yYkxOWmx2WVpLNWJRamw5OGs0OXFyNFNqZ1R4eHpNTEVZ?= =?utf-8?B?Y1Npa2I0TmxEejRRL3dtQjhTSHg3RVI1c3p3bmhNQk5GdnZlajlCRklNSW1R?= =?utf-8?B?MHZEYUdocEtad0VrVklLRmVrNVFsVCtCb1VSSWdnWWY4SHhjWWxDUUZpYktV?= =?utf-8?B?dFVKM1ZnaFFQZENiSHVuL3JLdGZIYlVzYldTd2k1R0VsUzBvaDFERXhCdG1N?= =?utf-8?Q?29PP+mwByh1Lvq3UjpSMEqDuhGc5V9bCej1I8xX?= X-MS-Exchange-CrossTenant-Network-Message-Id: 97de602b-1e3c-4ae3-9154-08d8f391f1c1 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2021 15:39:02.6926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xrDGvQp5fEKhOanEn4fnjxzwo4BJ8pjck/yTAv1ZJIqXQL0QuSn3YXf7AFz4XkKi9RNi+mHt/cqADwTFgutmLvGUDoEmq2QJOzcjfqdXW5A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2418 X-OriginatorOrg: citrix.com On 23/03/2021 09:58, Roger Pau Monne wrote: > Also change libxl__cpuid_legacy to propagate the error from > xc_cpuid_apply_policy into callers. > > Signed-off-by: Roger Pau Monn=C3=A9 This path has never previously had error checking. The set-cpu-policy hypercall, in principle, returns a triple of (leaf, subleaf, msr) to try and help the caller fractionally more than just getting EINVAL, but doesn't actually fail yet for interesting reasons. My plan was only to wire up the error handling with the new interface, which requires plumbing the extra failure information through into suitable locations, and ideally also looking up the offending values to render into error messages. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Mar 30 15:56:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 15:56:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103614.197631 (Exim 4.92) (envelope-from ) id 1lRGjP-0007H1-23; Tue, 30 Mar 2021 15:56:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103614.197631; Tue, 30 Mar 2021 15:56:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGjO-0007Gu-VP; Tue, 30 Mar 2021 15:56:38 +0000 Received: by outflank-mailman (input) for mailman id 103614; Tue, 30 Mar 2021 15:56:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGjO-0007Gp-2F for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 15:56:38 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8d378593-0767-4354-8e15-27fe93c95349; Tue, 30 Mar 2021 15:56:37 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 60A34AE58; Tue, 30 Mar 2021 15:56:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d378593-0767-4354-8e15-27fe93c95349 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617119796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0hybCrCzhnpWgNJOsJo3bbeBNZ6i4nJGi00JXnUFG3Y=; b=GE0clHnc1DpM7HAtz/O4ljo7QWOWAucq4VVdtnZEXXX7owUVX0TgHH0V9SteldkJIDktRY T+HmK199rszx9xGufN9Nvm09Tdb8ysdaA2WIT2BaONTgfeWSnqkLTrT/RZ/npIkI+lyjxc xyOnXtgiiPXgdfRkIb96RGTBYio1CEo= Subject: Re: [PATCH 11/21] libs/guest: allow updating a cpu policy CPUID data To: Roger Pau Monne Cc: Andrew Cooper , Ian Jackson , Wei Liu , xen-devel@lists.xenproject.org References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-12-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Tue, 30 Mar 2021 17:56:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210323095849.37858-12-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 23.03.2021 10:58, Roger Pau Monne wrote: > --- a/tools/libs/guest/xg_cpuid_x86.c > +++ b/tools/libs/guest/xg_cpuid_x86.c > @@ -966,3 +966,70 @@ int xc_cpu_policy_get_msr(xc_interface *xch, const xc_cpu_policy_t policy, > free(msrs); > return rc; > } > + > +int xc_cpu_policy_update_cpuid(xc_interface *xch, xc_cpu_policy_t policy, > + const xen_cpuid_leaf_t *leaves, > + uint32_t nr) > +{ > + unsigned int err_leaf = -1, err_subleaf = -1; > + unsigned int nr_leaves, nr_msrs, i, j; > + xen_cpuid_leaf_t *current; > + int rc = xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs); > + > + if ( rc ) > + { > + PERROR("Failed to obtain policy info size"); > + return -1; > + } > + > + current = calloc(nr_leaves, sizeof(*current)); > + if ( !current ) > + { > + PERROR("Failed to allocate resources"); > + errno = ENOMEM; > + return -1; > + } > + > + rc = xc_cpu_policy_serialise(xch, policy, current, &nr_leaves, NULL, 0); > + if ( rc ) > + goto out; > + > + for ( i = 0; i < nr; i++ ) > + { > + const xen_cpuid_leaf_t *update = &leaves[i]; > + > + for ( j = 0; j < nr_leaves; j++ ) > + if ( current[j].leaf == update->leaf && > + current[j].subleaf == update->subleaf ) > + { > + /* > + * NB: cannot use an assignation because of the const vs > + * non-const difference. > + */ > + memcpy(¤t[j], update, sizeof(*update)); I'm having trouble understanding the comment. In current[j] = *update; the lvalue is xen_cpuid_leaf_t and the rvalue is const xen_cpuid_leaf_t. That the usual (and permitted) arrangement afaics. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 30 16:01:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 16:01:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103627.197647 (Exim 4.92) (envelope-from ) id 1lRGoQ-0000Ve-SV; Tue, 30 Mar 2021 16:01:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103627.197647; Tue, 30 Mar 2021 16:01:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGoQ-0000VX-NU; Tue, 30 Mar 2021 16:01:50 +0000 Received: by outflank-mailman (input) for mailman id 103627; Tue, 30 Mar 2021 16:01:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGoP-0000VQ-Aq for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 16:01:49 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b0f0eb29-f1e8-436f-9d1c-72c4b3ff099c; Tue, 30 Mar 2021 16:01:48 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPS id BBA3A60241; Tue, 30 Mar 2021 16:01:47 +0000 (UTC) Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id A561C609B5; Tue, 30 Mar 2021 16:01:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0f0eb29-f1e8-436f-9d1c-72c4b3ff099c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617120107; bh=cidM7CHT6cFz1eFkeyxoQwsO3HgPGtDYuG1vU+RyH2g=; h=Subject:From:In-Reply-To:References:Date:To:Cc:From; b=Pu+S4VhO9/5fNqvxZCOzQ8B3uUUeWvl6T9HMpaH3qcyz7cQS0yv3MCQY0CbZJo0Bw 9/eqvmb83JnHtc8nome7qp/CJo0KTaYZJOC07fvT1bW/d/zc/xyOENXCX1vesOtq4r JVnMAzDcjjrnZhdDrYSnxvSzHC2auvPKu2tHXy/FnHzTXT0bd+UnBJT6ZCTvReX4rz LJ1T/LT0dknAd8iEiXSZ6h4N3snB9XCr0dcAg+cJGDntiWotgatU5GYe36UNqQZe8g Qe0pWmfwJASOIx+PA6C+xmNJAnyOEtDCc/W9zR/N7MYCl3queDv/cIer+dNH6wJbZn menxPBVDhQBzw== Subject: Re: [GIT PULL] xen: branch for v5.12-rc6 From: pr-tracker-bot@kernel.org In-Reply-To: <20210330120337.4404-1-jgross@suse.com> References: <20210330120337.4404-1-jgross@suse.com> X-PR-Tracked-List-Id: X-PR-Tracked-Message-Id: <20210330120337.4404-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.12b-rc6-tag X-PR-Tracked-Commit-Id: a846738f8c3788d846ed1f587270d2f2e3d32432 X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: a080642d2f831cc34b68663c0db1c447d3807421 Message-Id: <161712010761.23792.17653647991255711385.pr-tracker-bot@kernel.org> Date: Tue, 30 Mar 2021 16:01:47 +0000 To: Juergen Gross Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com The pull request you sent on Tue, 30 Mar 2021 14:03:37 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.12b-rc6-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a080642d2f831cc34b68663c0db1c447d3807421 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Tue Mar 30 16:02:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 16:02:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103630.197658 (Exim 4.92) (envelope-from ) id 1lRGpP-0000d4-53; Tue, 30 Mar 2021 16:02:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103630.197658; Tue, 30 Mar 2021 16:02:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGpP-0000cx-1o; Tue, 30 Mar 2021 16:02:51 +0000 Received: by outflank-mailman (input) for mailman id 103630; Tue, 30 Mar 2021 16:02:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGpN-0000co-8N for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 16:02:49 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6f893969-d87f-428a-9b57-08252bfe948c; Tue, 30 Mar 2021 16:02:46 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B9725AE58; Tue, 30 Mar 2021 16:02:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f893969-d87f-428a-9b57-08252bfe948c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617120165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=biXeeW4QG/QmGWSileBXMFFHvXOGPsruR/cTGFy1Le4=; b=t6qP1Ayetncyn4h7av2yhnl4xkyHR0DqoWKhdF8Nc+Wnamv3BIokDsZyg/nzP1S5M1mUrL ayrEs5aWT8Tk5YK4eZEzuQ65P/rxN0v0Vf9vd3Vlc4RS28u6H0rsPE7v4c9LykNH1+A6Vl 0lZZUuwJTYYxeIp86YemlUUHerp4hbI= Subject: Re: [PATCH 14/21] libs/guest: introduce helper to check cpu policy compatibility To: Roger Pau Monne Cc: Andrew Cooper , Ian Jackson , Wei Liu , xen-devel@lists.xenproject.org References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-15-roger.pau@citrix.com> From: Jan Beulich Message-ID: <8f7a2f44-c006-0f94-8f44-b6b3ee3e9d1f@suse.com> Date: Tue, 30 Mar 2021 18:02:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210323095849.37858-15-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 23.03.2021 10:58, Roger Pau Monne wrote: > --- a/tools/libs/guest/xg_cpuid_x86.c > +++ b/tools/libs/guest/xg_cpuid_x86.c > @@ -1098,3 +1098,20 @@ int xc_cpu_policy_update_msrs(xc_interface *xch, xc_cpu_policy_t policy, > return rc; > > } > + > +bool xc_cpu_policy_is_compatible(xc_interface *xch, const xc_cpu_policy_t p1, > + const xc_cpu_policy_t p2) > +{ > + struct cpu_policy_errors err; Don't you need an initializer here for ... > + int rc = x86_cpu_policies_are_compatible(p1, p2, &err); > + > + if ( !rc ) > + return true; > + > + if ( err.leaf != -1 ) > + ERROR("Leaf %#x subleaf %#x is not compatible", err.leaf, err.subleaf); > + if ( err.msr != -1 ) > + ERROR("MSR index %#x is not compatible", err.msr); ... these checks to have a chance of actually triggering? (I'm also not certain -1 is a good indicator, but I guess we have been using it elsewhere as well.) Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 30 16:21:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 16:21:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103634.197674 (Exim 4.92) (envelope-from ) id 1lRH7M-0002mK-OS; Tue, 30 Mar 2021 16:21:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103634.197674; Tue, 30 Mar 2021 16:21:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRH7M-0002mD-Kz; Tue, 30 Mar 2021 16:21:24 +0000 Received: by outflank-mailman (input) for mailman id 103634; Tue, 30 Mar 2021 16:21:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRH7L-0002m5-QO; Tue, 30 Mar 2021 16:21:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRH7L-00005n-LF; Tue, 30 Mar 2021 16:21:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRH7L-0005xw-6K; Tue, 30 Mar 2021 16:21:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRH7L-00049u-5p; Tue, 30 Mar 2021 16:21:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NJ4CQrrvJGug/2lWzLAL85wA9F76Op1hIaDalPvhOls=; b=qLojt0dLZHOXphLe8gumWB5p9p ryp7ONkhQMOmtnjhBTwDm8rYXaYseotbnmt53e1yfkckxzKD7YyJ1/Eu8f3Z2DlRFBnHQ8F/k3djQ MMQNiFvBjUQWWsk+apLTB19+Gs0OuMkahxUsJ6iA6k62ICwm8/so1N0noh5Gx2K7r7TU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160558: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9c39dba2b179c0f4c42c98e97ea0878119718530 X-Osstest-Versions-That: xen=cead8c0d17462f3a1150b5657d3f4eaa88faf1cb From: osstest service owner Date: Tue, 30 Mar 2021 16:21:23 +0000 flight 160558 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160558/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9c39dba2b179c0f4c42c98e97ea0878119718530 baseline version: xen cead8c0d17462f3a1150b5657d3f4eaa88faf1cb Last test of basis 160535 2021-03-29 17:01:29 Z 0 days Testing same since 160558 2021-03-30 13:02:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Marek Marczykowski-Górecki Roger Pau Monné Wei Liu jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git cead8c0d17..9c39dba2b1 9c39dba2b179c0f4c42c98e97ea0878119718530 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Mar 30 18:29:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 18:29:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103650.197694 (Exim 4.92) (envelope-from ) id 1lRJ6r-0006xm-Uo; Tue, 30 Mar 2021 18:29:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103650.197694; Tue, 30 Mar 2021 18:29:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRJ6r-0006xf-Rm; Tue, 30 Mar 2021 18:29:01 +0000 Received: by outflank-mailman (input) for mailman id 103650; Tue, 30 Mar 2021 18:28:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRJ6p-0006xa-Mv for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 18:28:59 +0000 Received: from mail-qv1-xf32.google.com (unknown [2607:f8b0:4864:20::f32]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bf1fcd9c-9de4-4f6e-814b-cb76e67bc9fa; Tue, 30 Mar 2021 18:28:58 +0000 (UTC) Received: by mail-qv1-xf32.google.com with SMTP id x27so8661459qvd.2 for ; Tue, 30 Mar 2021 11:28:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf1fcd9c-9de4-4f6e-814b-cb76e67bc9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zededa.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=lGfHpDwA5adg4O1hCUW5AZ5ID+ShkkhzHGarXjuElwU=; b=dGo84S8bHxvj0OeaCD2okzWM3u9dhUpNXxN+XP8yGj//tn+IJjrRAgRRjUvoqrSHxi h/CU34psLfzRDLnPN+n1g6HdX13MKrZKS+lof6P6g+Jf6elwwYZYtryRgACfwafmQ1hw Hsr0GRH/f1k9zUOqFknTiNW89aBsUhOWGx6B25CsH7lbWlveSX0NnigXrdwYcm33So61 exWYHNUnFjQyPwC1omGBSqMVn/dI/5NOr+pXDwesrJplfmK1ddR/vbe3gn2EzTmOawaH zatebMytGrUwqNi3NYaz73mpWQwRJj8qULhITvC4pMXmSxLF7yuWulZkhO4avafDNvSK g1ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=lGfHpDwA5adg4O1hCUW5AZ5ID+ShkkhzHGarXjuElwU=; b=fdY+ljPX5HMkNR97Hp867XD/3RjkCHvYTaP5gXmAse6Tq02bljR16lLT0S66zVNtaP ZlgHY9QOE3iORWW9AY4OuHLNkxEBTOTcLXbtKglVjWBDharTUgOtihOGaxWhY5LGCJFm ORE6F2DkLbCw3+QYBIE2LRfNIEjgNg7Bhe3kQgBmVbPtxHDhuTMjFaZoQsb403f6tJP8 ZoZjlcZ7W2cJTtmGTJZXdPE1g1kqAghgT+j3xu/r59INE6SZM93UNzstYK2xnitJU5kv NUWVNwfytPBySSXcRxbdrLZFOiyOODL7fX0O3y1lxjQ50rKskiZbZ6PD6q/RrmZSN9YE 33GQ== X-Gm-Message-State: AOAM530Tuon7KtyHAGbKEW8iobXL8qPXItUUQEBUbtw7icXJ0C1PV0AJ Gt/sRWORCrGvzfLyqPSJDTPRrHgc37FH7QMVrndTRrBnUuyW8K9A X-Google-Smtp-Source: ABdhPJxqoySOLWxKbvthlCvsjfDMQqJ27e0UnI78mcfZDJN2LS8noQ6wI/20QqcM8JsOVY+hRpmizPgGKpP8NtdhdRU= X-Received: by 2002:a0c:9ad7:: with SMTP id k23mr31617571qvf.52.1617128938005; Tue, 30 Mar 2021 11:28:58 -0700 (PDT) MIME-Version: 1.0 From: Roman Shaposhnik Date: Tue, 30 Mar 2021 11:28:49 -0700 Message-ID: Subject: multiboot2 and module2 boot issues via GRUB2 To: Xen-devel Content-Type: multipart/alternative; boundary="000000000000e7fd2405bec52bb0" --000000000000e7fd2405bec52bb0 Content-Type: text/plain; charset="UTF-8" Hi! seems like I've run into an issue with multiboot2 and module2 commands that I can't quite explain. Since it may be something super simply and silly -- I wanted to reach out here before I do a GRUB/Xen/LK source deepdive. So here's the deal: whenever I boot straight up Linux kernel I can do the following sequence of commands: linux /kernel initrd foo.cpio.gz bar.cpio.gz and have linux kernel effectively stack content of bar.cpio.gz on top of foo.cpio.gz and present a unified initramfs that way. I'm trying to replicate it with Xen, but: multiboot2 /boot/xen.gz module2 /kernel module2 foo.cpio.gz module2 bar.cpio.gz only seems to be picking up foo.cpio.gz Has anyone run into this issue before? Thanks, Roman. --000000000000e7fd2405bec52bb0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

seems like I&#= 39;ve run into an issue with multiboot2=C2=A0and module2
commands= that I can't quite explain. Since it may be something
super = simply and silly -- I wanted to reach out here before I do
a GRUB= /Xen/LK source deepdive.

So here's the deal: w= henever I boot straight up Linux kernel
I can do the following se= quence of commands:
=C2=A0 =C2=A0linux /kernel
=C2=A0 = =C2=A0initrd foo.cpio.gz bar.cpio.gz
and have linux kernel effect= ively stack content of bar.cpio.gz
on top of foo.cpio.gz and pres= ent a unified initramfs that way.

I'm trying t= o replicate it with Xen, but:
=C2=A0 =C2=A0 =C2=A0multiboot2 /boo= t/xen.gz
=C2=A0 =C2=A0 =C2=A0module2 /kernel
=C2=A0= =C2=A0 =C2=A0module2 foo.cpio.gz
=C2=A0 =C2=A0 =C2=A0module2 bar= .cpio.gz
only seems to be picking up foo.cpio.gz

Has anyone run into this=C2=A0issue before?

Thanks,
Roman.
--000000000000e7fd2405bec52bb0-- From xen-devel-bounces@lists.xenproject.org Tue Mar 30 19:08:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 19:08:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103659.197707 (Exim 4.92) (envelope-from ) id 1lRJiy-0002jw-34; Tue, 30 Mar 2021 19:08:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103659.197707; Tue, 30 Mar 2021 19:08:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRJiy-0002jp-02; Tue, 30 Mar 2021 19:08:24 +0000 Received: by outflank-mailman (input) for mailman id 103659; Tue, 30 Mar 2021 19:08:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRJiw-0002jk-8W for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 19:08:22 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c89f95df-dbd7-4f60-894f-765cc08f87e4; Tue, 30 Mar 2021 19:08:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c89f95df-dbd7-4f60-894f-765cc08f87e4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617131300; h=to:references:from:subject:message-id:date:in-reply-to: content-transfer-encoding:mime-version; bh=9VD8Ex+jjCHS1bOeQS6HAdC2uGW47/bL6H+BbZGc01g=; b=WGT5Or+mDpznT6k/vK/EV2gRL6Mjm1rg+iUGmr5Rj/hPU3Ezy8Klk2qQ uuED6q5FwJZ9Or3KU2TMTVhkARuOJY+1RoZM6Om5NgCt1P3pfauEtJGvn P1zqhRIBEUcd+V0fSm2yr79r4+zdiZRhFYYYTONhAiDX0hlj6sBB+dFCk k=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 4PosuCBROH/TQ6vUGGFTMt5KIJDw5ldNHfJQ4hZB5MHltDraIquN7gnyLS4q6SO7ZGSOOxwpcW AYBUhPYkUKRzsHfL8HG9K0OaJmTWDdi/tS1zmh+ABfkvLo4fJUxUL5UFUpzmv5HdjeOqf279wM ItpKdmRZRrZflmkiUNTz2mGL5fIG2IbQpBama/R0YXxCsZ8oYgFXHCeQ+pQA4Q5rj/MevaYo9l c0zkMKvHAYyWHwHal/Sgafomp3WTr3TuRTbHHHxtjywFmXky4OkXFMzv0LAl8tp/RBj4gNY1y/ K6Y= X-SBRS: 5.2 X-MesageID: 40845127 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:lETBSK8WwodC7MzRPWpuk+FJcL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmyybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIUHD38Zn/+ Nbf6B6YeecMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsKV4hL6QBlBgGHVmh/QwdbDZQ0fa DsmvZvjTymZHgRc4CHHXEDRefOvJnmk5jhbB4ACXccmXSzpBmv76P3FAXd4wcGX1p0sM0f2E Xmsyi83KWstPmn1gTRvlW80716kMbso+EzffCkpdMSLlzX+2KVTaRnH4aPpTUk5NyogWxa6+ XkhzcFE4BN52jKfmezyCGdqzXI9Do18XftxRu5rBLY0KrEbQk3AcZAmo5VGyGxgyFL3KAeod B29lmUuJZNARTLkD6V3amsazhQmlepun1nqOYPjhVkIPojQYVMpo8S9l49KuZmIAvG7ukcYY tTJf3H6O0TWV2XaG2xhBgW/PWcGl43HhuAX3EYvN2U3zV8jBlCvjUl7f1asXEa+J0nTZ5Yo8 zCL6RzjblLCvQbdKRnGY46MIaKI12IZSiJHHOZIFzhGq1CE3XRq6Tv6LFwwO2xYpQHwLY7hZ ypaiIViUcCP2bVTeGe1pxC9R7ABE+nWy72981Y759l/pXhWbvCK0S4ORETuvrlh89aLtzQWv 61Np4TKeTkN3HSFYFA2BC7c4VOKEMZTNYetr8AKhyzi/OODrevmv3Qcf7VKraoOy0jQHnDDn wKWyW2C95H6mytR3/kkDncU37gYSXEjNFNOZmf29JW5JkGN4VKvARQo0++/Nu3JTpLtbFzXE YWGsKkroqL4U2NuUrY5WRgPRRQSmxP5q/7bn9MrQgWd2f9cbMJvcSjaXlftUH3YyNXfofzKk pytl538aW4I9i73iY5Ee+qNWqckj81qG+VSYwf3omO/93sdJ99LptOYt0/KSz7UzhO3Sp6om ZKbwEJAmXFECn1tKmjhJsIQMfFd9d9hw+vCdVOqW3WsHidoc1HfApaYxeeFeqsxSo+TTtdgV N8t4UFhqCbpDqpIWwjxNgjPEZ0c2SRCrJeBAGjbIFZ84qbPD1YfCOvv3i3mhszcm3l+wE3in b6JSOZQ/3NH2FQo2tVyKrs7VNyeFiMZk4YUAEIjaRNUUD9/lpj2+6CYaS+l1GcbVYP2ckxGj DIazl6GHIn+/mHkDqu3BqSH3QvwZsjetHHBLM4arfJxzeGM4uTj5wLGPdS4bdoPN3jqfUwTO qaYgOZRQmITN8B6kiwnDICNyZ1onV/zq+t9x3h8WSi3HkwRdDVO09rQrkHI9eaq0joLsz4pK lRvJYQh6+XNG60V/utjYfwRBRHIgnIoWG3Q/ozwKok9J4ahf9WJd3jTTDM1Ht7xx0wI8f/qV MGTM1AkcX8E74qW/ZXRjlQ8VUonumeNUcHsgT5BeklYFEm5kWrSO+h0v7tqbA1BFeGqxa1EV 6D8zdF9/OtZVrJ6ZcqT4YxK39Rck4y9TBL+/6DbZTZDEGPe/tY9FS3dl+7f7k1ctnOJZwg6j J76cqPhemZam7R3x3RpyJyJuZ2yFmcKPnCdj6kKKpv6Ny1OVOFn6us7oqStV7MOESGQnVdo5 ZEe0wWZtlEkR84guQMo26PdpA= X-IronPort-AV: E=Sophos;i="5.81,291,1610427600"; d="scan'208";a="40845127" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nyoNqieBytD2H2J3JisUHocXLkpis7ZVcK9OUk5ObDXa/lNBffnDTK8PhFFd7+5jRkIC38CDZREn9v3ruIL43uYQOaar0G+ABHzoMcN+mf70hzuSQVMxVO4hdcdFXWYmhwrA8bBY/VaZ8J0yr6N6Rq/LAsX4fVQXXVq3FP0E2cnSrvgOpz7HWIEjTApv2HXsNHk1mcLGGUgrzoYT3kB0WuFzzUrq9DhRcpv57oggJ1MpMK0JJAAOzEpiFZWBESwaz3Dhb2Zh4eAKyXB51E33wpoHr/FqVudEQuoIVzkTKWWZ3dK+nuiROMr09s0tk5DTZ/FpBIxEjC7WlNN2I1Jqmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9VD8Ex+jjCHS1bOeQS6HAdC2uGW47/bL6H+BbZGc01g=; b=W+cOWjAP/RzlCJb/BNhNaPgsqZgkaP2quHOlaje31hOmH9WNGhpKE35ZxUttsHHonN6PuOvknRFXNgafjwBQxixZtinJRjATUEIMfThyCKHedOuk8UH63TpelZOE2G1sC15s7TXX67MOvJJHRNCyOG562izAQzvrLI+tODQF2cSaNNxovA+LRE5GRepzQCbvkwEJv2aLeb2+X87QJEoed3UEkIJdLZLsZbGpjjQCz+L5zecNHLd4UZRRmU7lndjb0bqS97gW4PnaDSpduOfQsL3muDHcpH4hJbRJvg7fxfs9ve1h1KfWDwqeVH7mq3McbhVEr0I0tNkPyAdSL9v3tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9VD8Ex+jjCHS1bOeQS6HAdC2uGW47/bL6H+BbZGc01g=; b=nk3lpC4Ivu4Nu/V5iyO/5e0AM2kc7Xpe0/myeejGpN/HCnhv5kkZXQSGS8Sc8PJqQNh1esManarWulO2ZVfijoCSWone4EwsvNQgtoSJoEq3K4SqPOUDYbYYOhBz0+3LQVVN7StYOUQzPcGzLJevYHToG6JXXUxNZ/+kRH6XtJo= To: Roman Shaposhnik , Xen-devel , References: From: Andrew Cooper Subject: Re: multiboot2 and module2 boot issues via GRUB2 Message-ID: <23baec07-a3ae-949a-a1fb-09100efd53e5@citrix.com> Date: Tue, 30 Mar 2021 20:08:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0481.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::18) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 908e81c5-d58a-4e5f-267f-08d8f3af2d52 X-MS-TrafficTypeDiagnostic: BN6PR03MB2516: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tjPNhBFYmHjBbKKdAaBE9F8xLOvegH7UtMNDQDms5oU6pcFVYKyMEW1rCC3fJLUYZ48MnxBhkhsyNikgz54O11f0gI2Ev/KH9gpdifndXuClIZ4k7UXYv81Ur4s/2z6LxU1051wHR3Wr+Ukck7TGPdC2NQb7Lx6jt6kwBo9blgx/CmqV/O9hgUHwfJUIWuSWDAT0atLtLCOaUFf3NWjomdSJSx76fZZ8UH+95tHUq8qd88LuL1pYVvDs8+r4/Y6WQZMn+MnUR/KZLz2XsWL49dbQ1c3LcIwj59Nb2sDmjc6nQYyf3CU9z16X5oFeCYphS8tJNGLYDEl6MlGNw+tyYNdKfhK/+6mZK8wvBtgeNxKFpVJ4ON7uuQYTQF04Cvm48CPVDvrtA5lg6iISk7PREzabgbzZ1L3DlD0SjvoyWLSpLYPXrzRmmDOWw2j8zlUdXmI+qJgvfz0WgN0XG4wllDAa1pzZtjYM+yVZdQlC9qEPugcf0p/Jgbt7OMVCo+VU+2y8h1NT+xAIhZvW/Jv16ktisiLVs7RAodczfQmQEleSA9AXACrf313oAZmq14XaV/JTfC40D2duQvsVVxcUXM7LdLdQmevaWk1JUJVrxGgWFnPzUgwCEewJRZZJCtHfJoggdr4eyZUVuMLkl/EhJvyaL8mokoldQAUCG4wLjZaxx8bWb+2yvhyDAV1di8Td1jE13W8p/d/00Y8UAn6w1+NjUqbAtGMLRGxvzrr14A8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(396003)(376002)(39850400004)(346002)(31686004)(5660300002)(38100700001)(16526019)(2616005)(16576012)(36756003)(26005)(186003)(956004)(478600001)(8936002)(6666004)(6486002)(66946007)(31696002)(2906002)(53546011)(66556008)(316002)(8676002)(110136005)(66476007)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?c0IwbFdJNVhNbllEUGxNZDF5Mk1oSjJkTHFKZDd3bGVvNkpkOTFuek04OWx2?= =?utf-8?B?dUpPVTk3UmZVaVdIZksvNEVqaWY0TXBPUVNXNll0MkRCOVkydmVHa1cvNkhz?= =?utf-8?B?UVA5b0RFRzhCazljZHlFNHlTWjZEdnl6TU9BU1pCdWFKYStHaURIWnNsZkVP?= =?utf-8?B?d2pVcUloRXdUbVk3NHZmdENYN2FScklINUFxS3JPYlB4cDB1QUJiaGpYM3Y5?= =?utf-8?B?RlRnb3V6LzJ4Ym5LKzhZemIwOE9FLytWYTFwWG01eUZvVVFzMWErbitENk1H?= =?utf-8?B?cVFrYktmNGlnVmRBU1pVTCtObXkraWkxU1lSVnJXVU1OakZ6eitLckxsK0NB?= =?utf-8?B?bnJtMWJiRWVwTjlTa2Z6Wm5xUmNEMmdLVnJjRjlyK0VBMGRseGZaMFZzR1hI?= =?utf-8?B?dEsxZTVJMU5obGt6N05Cc2xXVVJDVjduSzVqeWZWVkFVUHBJeis4bkhHb0RE?= =?utf-8?B?TWNwS1BTeXZaSjdwbFJxWHVvWG9kRldocE5zUGxFc1U1ajNzQWxkV2dIbGFn?= =?utf-8?B?REhKRTZqS1R2NkZKMXpGTmxUNW1YMk9LcEw3UHIyK3BjbEY3ZmtmV2hWWjFk?= =?utf-8?B?UEl4WUxDeS9jakRhYWRzYjluWDE0Qyt6cDRRVnF1ZmMwQmZ1ZTExL0s3WExu?= =?utf-8?B?cHpVRlFJRmNacHlLWHZjclE3U3E0QUJPMml6eTlKOTZEeHRhY21OV09Melpx?= =?utf-8?B?ZXl0UitvMmJBamVlL3ZsTTBXTnErZys0TzRhRnE4SGtpdDhTdEU4ZnlSMG55?= =?utf-8?B?NmpuVVFkYTczcFRWeWxiTlVEN2N2ZWdzRXRyOFRPRndwVkZ5RmtaTHkrTmdm?= =?utf-8?B?RFdlVW9CKzZKbjJRM3hpZURaMzloZDd5UDEvdzBLTWRvMldway9KMkxWVmNz?= =?utf-8?B?bTYvWWdhUEVZRVlXSjhSUWFTNXdVdjRmVHZ0MVJmemhTNXkzY2hmS095TGs1?= =?utf-8?B?S2VyZ1d3QkVTaHBOZ1JwQks1SUdDM0JtejA0bTJyRzZvdndBaUFJV3kzMnhN?= =?utf-8?B?cVZJSzNBbElxdFlsS2oxSDhPTVZUT1lHT1dISEJpMHNjTTBvLzNaSHlGUHI3?= =?utf-8?B?clRLeGs1SFAxU240SHp3TE01bVExRFkvZHFUZE1XOWRhRHV2NVJOTnlUYWNV?= =?utf-8?B?UnZKRHBFNzBJdUtLdnZrbnQvS3QrYTh4YnVLRC93MWpWcnhEcldOdGxCaUY3?= =?utf-8?B?eXd5dmdyWmt4R1JVL0RQL291SzFoMEVzaGFYNEhxdnJRSmExS2trZTlmNE9o?= =?utf-8?B?ZlcvRzFvKytvWWdxUG1KNkVLUjRPczdaQjVIR0dEUW5jREpmVVRIakNuVnpx?= =?utf-8?B?NFhmMWY2UGZaYkZrblBQSTV4N1ZrTFczd3hXTXRNMTh4NFM2VC9ob2ZyZFF3?= =?utf-8?B?K0F1ZUhISHJjcytpc0NpWWxpVnlYaTRlVTNjWXdOd2JZSmg0elorYjd6UWR1?= =?utf-8?B?ZEN3MEcrdUtjNERZbENHZkVYa0VrVWpzSThKaEZGbVU2bVAxQzYwTVZsMStI?= =?utf-8?B?VURaQlNRWmxaVHFVWHRaaURybGdKUTBvMDFNQnN6N014MG93M3BrVy8wTmI5?= =?utf-8?B?c0pMekM0cmR1dStEcWxva21uRzNodWdvMnhLMWpZZE9MYVNWMTV2blU2Nmdl?= =?utf-8?B?b1ppdUVTZ293MVBYY3RmWTdDZ2xqS1NuRGM3RnRZRlVCd3d5SThESVExNW9k?= =?utf-8?B?QnR4djB1UStlNjllOXc1WWhMRUpteWt5T1JGcnMzMm1uMmNnejlYR3ZGREJw?= =?utf-8?Q?2lFCorjaA7RMw1rGSq9LsrUNIjbTZucuW9cHQwU?= X-MS-Exchange-CrossTenant-Network-Message-Id: 908e81c5-d58a-4e5f-267f-08d8f3af2d52 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2021 19:08:18.1098 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sMrqGZSGY7WTZ7svm1jZw/4BB72PVt3rcZUVDwInOdSbYNOYlEkDm1iAl4ifWIyQeZOXsnhEejfmSCX1gaef50eWGk4HABg4KHOGVyI87zg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2516 X-OriginatorOrg: citrix.com On 30/03/2021 19:28, Roman Shaposhnik wrote: > Hi! > > seems like I've run into an issue with multiboot2=C2=A0and module2 > commands that I can't quite explain. Since it may be something > super simply and silly -- I wanted to reach out here before I do > a GRUB/Xen/LK source deepdive. > > So here's the deal: whenever I boot straight up Linux kernel > I can do the following sequence of commands: > =C2=A0 =C2=A0linux /kernel > =C2=A0 =C2=A0initrd foo.cpio.gz bar.cpio.gz > and have linux kernel effectively stack content of bar.cpio.gz > on top of foo.cpio.gz and present a unified initramfs that way. > > I'm trying to replicate it with Xen, but: > =C2=A0 =C2=A0 =C2=A0multiboot2 /boot/xen.gz > =C2=A0 =C2=A0 =C2=A0module2 /kernel > =C2=A0 =C2=A0 =C2=A0module2 foo.cpio.gz > =C2=A0 =C2=A0 =C2=A0module2 bar.cpio.gz > only seems to be picking up foo.cpio.gz > > Has anyone run into this=C2=A0issue before? I can explain why that happens.=C2=A0 Not sure if it counts as a feature, b= ug or mis-expectation, but CC'ing grub-devel for their input. The initrd command is presumably concatenating those two files together in memory, and presenting Linux a single initrd pointer. For the module2 example, you're putting 3 distinct files in memory, and giving Xen a list 3 modules. Xen is capable of taking various things via modules, such as an XSM/Flask policy, or microcode, so has logic to identify these if present and separate them from "other stuff".=C2=A0 However, there is a hardcoded expectation that the first module is the dom0 kernel, and the next unrecognised module, if present, is *the* initrd. I expect that Xen isn't handing bar.cpio.gz on to dom0, but I'm not sure whether passing two distinct initrd-like-things to Linux is even possible. What you presumably want is some `initrd` side effect in Grub so you can write `module2 foo.cpio.gz bar.cpio.gz` and have it concatenate things together in memory and present one MB2 module, but I suspect that exact syntax might be ambiguous with command line handling.=C2=A0 I have no idea whether such a command currently exists. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Mar 30 19:35:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 19:35:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103669.197725 (Exim 4.92) (envelope-from ) id 1lRK9O-0006QQ-ED; Tue, 30 Mar 2021 19:35:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103669.197725; Tue, 30 Mar 2021 19:35:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRK9O-0006QJ-B7; Tue, 30 Mar 2021 19:35:42 +0000 Received: by outflank-mailman (input) for mailman id 103669; Tue, 30 Mar 2021 19:35:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRK9N-0006QE-4K for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 19:35:41 +0000 Received: from mailhost.m5p.com (unknown [74.104.188.4]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 65148cdc-d458-4413-9359-6ae120513760; Tue, 30 Mar 2021 19:35:39 +0000 (UTC) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 12UJZTJV017133 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 30 Mar 2021 15:35:34 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 12UJZSEL017132; Tue, 30 Mar 2021 12:35:28 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65148cdc-d458-4413-9359-6ae120513760 Date: Tue, 30 Mar 2021 12:35:28 -0700 From: Elliott Mitchell To: Roman Shaposhnik Cc: Xen-devel Subject: Re: multiboot2 and module2 boot issues via GRUB2 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com On Tue, Mar 30, 2021 at 11:28:49AM -0700, Roman Shaposhnik wrote: > seems like I've run into an issue with multiboot2 and module2 > commands that I can't quite explain. Since it may be something > super simply and silly -- I wanted to reach out here before I do > a GRUB/Xen/LK source deepdive. > > So here's the deal: whenever I boot straight up Linux kernel > I can do the following sequence of commands: > linux /kernel > initrd foo.cpio.gz bar.cpio.gz > and have linux kernel effectively stack content of bar.cpio.gz > on top of foo.cpio.gz and present a unified initramfs that way. > > I'm trying to replicate it with Xen, but: > multiboot2 /boot/xen.gz > module2 /kernel > module2 foo.cpio.gz > module2 bar.cpio.gz > only seems to be picking up foo.cpio.gz > > Has anyone run into this issue before? Not I, but I asked questions elsewhere before I fought this battle. You should get a more recent version of GRUB. More recent versions of GRUB (2.04) on ARM have the "xen_hypervisor" boot mode. With this boot mode the kernel and initrd get passed via xen_module command. Apparently newer GRUB versions have better boot methods for Xen, so updating would be a Good Idea, if that is viable for you. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Tue Mar 30 19:49:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 19:49:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103672.197737 (Exim 4.92) (envelope-from ) id 1lRKM6-0007a6-Jf; Tue, 30 Mar 2021 19:48:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103672.197737; Tue, 30 Mar 2021 19:48:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRKM6-0007Zz-GY; Tue, 30 Mar 2021 19:48:50 +0000 Received: by outflank-mailman (input) for mailman id 103672; Tue, 30 Mar 2021 19:48:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRKM5-0007Zr-3O; Tue, 30 Mar 2021 19:48:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRKM4-0003f7-Pw; Tue, 30 Mar 2021 19:48:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRKM4-00089S-H7; Tue, 30 Mar 2021 19:48:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRKM4-0001As-Gb; Tue, 30 Mar 2021 19:48:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8CSg0P2JnXe2Y9RClgq4gBqYd5vHEIc/BxFGgcGk3Ms=; b=qHB+tca2Pbo+QWNAZ7P9bpIvbc 4vQt/icpFrnCYUFbDd3eUy0Q6FMaNbq4FVI8NP45YBsJHDVvzuMFqFZoQ9dMDV4RPSevqS4lRpo7w Rln7J2bcgtqMy+fBFfwgWr5O/ZkfmcFopDUNPzIuvwqpRQkxjive8k/G/Hc5WR31VYW0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 160565: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=90629587e16e2efdb61da77f25c25fba3c4a5fd7 X-Osstest-Versions-That: xen=9c39dba2b179c0f4c42c98e97ea0878119718530 From: osstest service owner Date: Tue, 30 Mar 2021 19:48:48 +0000 flight 160565 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160565/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 90629587e16e2efdb61da77f25c25fba3c4a5fd7 baseline version: xen 9c39dba2b179c0f4c42c98e97ea0878119718530 Last test of basis 160558 2021-03-30 13:02:39 Z 0 days Testing same since 160565 2021-03-30 17:00:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9c39dba2b1..90629587e1 90629587e16e2efdb61da77f25c25fba3c4a5fd7 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Mar 30 20:04:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 30 Mar 2021 20:04:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103679.197751 (Exim 4.92) (envelope-from ) id 1lRKat-0001MD-TS; Tue, 30 Mar 2021 20:04:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103679.197751; Tue, 30 Mar 2021 20:04:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRKat-0001M6-QR; Tue, 30 Mar 2021 20:04:07 +0000 Received: by outflank-mailman (input) for mailman id 103679; Tue, 30 Mar 2021 20:04:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRKas-0001Ly-Gv; Tue, 30 Mar 2021 20:04:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRKas-00040L-9o; Tue, 30 Mar 2021 20:04:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRKar-0000qk-Ui; Tue, 30 Mar 2021 20:04:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRKar-0002m9-UA; Tue, 30 Mar 2021 20:04:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yeqzltcBnZMifegTJ1W/OjRREcAynJbNyKfG9U4zx1c=; b=f1gnarPllagrVIoBh36/5Rqw0x hSSwv4dmpcWvkMJilY8Fv1qsyZKbGqf3BTZMDWCklCw4MAUq0Ws6RuOAdrH3oZ8Y2d7r26G1WKrHA QDzB2nwdzcIiakWXEuQaTZEidr8RL+pIKXB0onvcWUlAdspVS+aUXUvb7bgjemx1kajM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160549: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Tue, 30 Mar 2021 20:04:05 +0000 flight 160549 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160549/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 160529 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 42 days Failing since 160128 2021-03-18 14:36:18 Z 12 days 13 attempts Testing same since 160150 2021-03-20 04:11:48 Z 10 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 31 00:29:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 00:29:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103696.197791 (Exim 4.92) (envelope-from ) id 1lROjH-0003QO-Ic; Wed, 31 Mar 2021 00:29:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103696.197791; Wed, 31 Mar 2021 00:29:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lROjH-0003QH-F3; Wed, 31 Mar 2021 00:29:03 +0000 Received: by outflank-mailman (input) for mailman id 103696; Wed, 31 Mar 2021 00:29:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lROjG-0003Q9-87; Wed, 31 Mar 2021 00:29:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lROjG-0000Ub-2U; Wed, 31 Mar 2021 00:29:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lROjF-000425-Mj; Wed, 31 Mar 2021 00:29:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lROjF-0007lM-MC; Wed, 31 Mar 2021 00:29:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tT1BVZM49Yt7Kfor7eVYHDjWxAQPCFUQnP+jX7Uw/p4=; b=dUz+rjc0xOxsDXOupJSPxnQl2q FnDm6Qca4UIAC7EP1y8yDyxuag5hcFIBWhgnnQR1U3ODjWp+xi0Jv8GhMCLWHivzVD7jeteNMllbM kST/p3jEkV59qA7ajfenqfe/nOPU0qsNGlN6tozzbGqkWpJfRvxwMturgJru6XyNuPfc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160551: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-localmigrate/x10:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1e43c377a79f9189fea8f2711b399d4e8b4e609b X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Wed, 31 Mar 2021 00:29:01 +0000 flight 160551 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160551/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 19 guest-localmigrate/x10 fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 1e43c377a79f9189fea8f2711b399d4e8b4e609b baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 242 days Failing since 152366 2020-08-01 20:49:34 Z 241 days 411 attempts Testing same since 160551 2021-03-30 06:54:56 Z 0 days 1 attempts ------------------------------------------------------------ 5271 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1311126 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 31 04:24:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 04:24:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103708.197818 (Exim 4.92) (envelope-from ) id 1lRSPC-0008Hv-1V; Wed, 31 Mar 2021 04:24:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103708.197818; Wed, 31 Mar 2021 04:24:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRSPB-0008Ho-Tc; Wed, 31 Mar 2021 04:24:33 +0000 Received: by outflank-mailman (input) for mailman id 103708; Wed, 31 Mar 2021 04:24:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRSPA-0008Hg-IU; Wed, 31 Mar 2021 04:24:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRSPA-0001qb-8s; Wed, 31 Mar 2021 04:24:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRSP9-0008Is-VV; Wed, 31 Mar 2021 04:24:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRSP9-0001AL-Ur; Wed, 31 Mar 2021 04:24:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YR1ds5a616HF6GQXMwZZhFBazs1J4Ve7XGIiVzR7anM=; b=31eeYAqeZ6trNShNbp4LRjucQC mupDbdWE63K0mgstlaqbHJKO+C7tTG5/KRCuLIZi7WiAVU73YCRq4Rloj2dFVf8aa9lIr0vrnVFez Zp4V0nVGwqApAjLHMgEuxywqxgn2D4VafQq9c+iMCdHTXf4unM7IRrxKN48QBPFYAcAI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 160557: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4e85f8a712cddf2ceeaac50a26b239fbbcb7091f X-Osstest-Versions-That: linux=b90344f7d6000deba0709d75225f30cbf79ec2f0 From: osstest service owner Date: Wed, 31 Mar 2021 04:24:31 +0000 flight 160557 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/160557/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160387 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160387 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160387 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160387 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160387 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160387 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160387 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160387 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160387 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160387 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160387 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 4e85f8a712cddf2ceeaac50a26b239fbbcb7091f baseline version: linux b90344f7d6000deba0709d75225f30cbf79ec2f0 Last test of basis 160387 2021-03-24 10:40:15 Z 6 days Testing same since 160557 2021-03-30 12:41:35 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Erhard F." Adrian Hunter Alex Deucher Alexander Ovechkin Alexei Starovoitov Anatoly Pugachev Andrew Morton Andrey Konovalov Andrii Nakryiko Andy Shevchenko Angelo Dureghello Anna Schumaker Arnaldo Carvalho de Melo Aurelien Aptel Aya Levin Bart Van Assche Benjamin Herrenschmidt Borislav Petkov Chris Chiu Christian König Christoph Hellwig Claudiu Beznea Corentin Labbe Daniel Borkmann Daniel Wagner Daniel Wheeler David Jeffery David S. Miller Denis Efremov Dinghao Liu Dmitry Baryshkov Dmitry Monakhov Dvora Fuxbrumer Dylan Hung Eric Dumazet Eryk Brol Fabio Estevam Feng Tang Florian Fainelli Florian Westphal Frank Sorenson Geetha sowjanya Georgi Valkov Greg Kroah-Hartman Greg Ungerer Grygorii Strashko Guenter Roeck Hangbin Liu Hannes Reinecke Hans de Goede Hariprasad Kelam Hayes Wang Heiko Thiery Herbert Xu Horia Geantă Hulk Robot Ingo Molnar Isaku Yamahata J. Bruce Fields Jakub Kicinski Jan Beulich Jan Kara Jason Gunthorpe Jason Self Jean-Philippe Brucker Jens Axboe JeongHyeon Lee Jia-Ju Bai Jimmy Assarsson Joel Stanley Johan Hovold Johannes Berg Jon Hunter Juergen Gross Kumar Kartikeya Dwivedi Li Yang Linus Torvalds Linux Kernel Functional Testing Louis Peens Lukasz Luba Lv Yunlong Maciej Fijalkowski Manish Rangankar Maor Dickman Marc Kleine-Budde Marc Zyngier Mark Brown Mark Pearson Mark Tomlinson Markus Theil Martin K. Petersen Martin Willi Mian Yousaf Kaukab Michael Braun Michael Ellerman Mike Kravetz Mike Snitzer Mikulas Patocka Mimi Zohar Muhammad Husaini Zulkifli Nathan Chancellor Nick Desaulniers Nicolas Ferre Nirmoy Das Oded Gabbay Pablo Neira Ayuso Paul Cercueil Paulo Alcantara (SUSE) Paulo Alcantara Pavel Tatashin Peter Oberparleiter Peter Zijlstra (Intel) Peter Zijlstra Philipp Leskovitz Phillip Lougher Potnuri Bharat Teja Rafael J. Wysocki Richard Cochran Rob Clark Rob Gardner Roman Gushchin Saeed Mahameed Sascha Hauer Sasha Levin Sasha Neftin satya priya Sean Nyekjaer Sergei Trofimovich Shawn Guo Shuah Khan Simon Horman Stephane Grosjean Steve French Sudeep Holla Sung Lee Sunil Kovvuri Goutham Takashi Iwai Theodore Ts'o Thomas Gleixner Timo Rothenpieler Toke Høiland-Jørgensen Tomer Tayar Tong Zhang Tony Brelinski Tony Lindgren Tony Nguyen Torin Cooper-Bennun Toshiaki Makita Uwe Kleine-König Viresh Kumar Vitaly Lifshits Wei Wang Will Deacon William Tu Yang Li Yonghong Song jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git b90344f7d600..4e85f8a712cd 4e85f8a712cddf2ceeaac50a26b239fbbcb7091f -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Wed Mar 31 04:42:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 04:42:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103713.197833 (Exim 4.92) (envelope-from ) id 1lRSgd-00025V-KU; Wed, 31 Mar 2021 04:42:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103713.197833; Wed, 31 Mar 2021 04:42:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRSgd-00025O-Gg; Wed, 31 Mar 2021 04:42:35 +0000 Received: by outflank-mailman (input) for mailman id 103713; Wed, 31 Mar 2021 04:42:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRSgb-00025G-8l; Wed, 31 Mar 2021 04:42:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRSga-00026o-VW; Wed, 31 Mar 2021 04:42:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRSga-0000u2-Mw; Wed, 31 Mar 2021 04:42:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRSga-0004RM-MQ; Wed, 31 Mar 2021 04:42:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=Cpp0YOEH3fn8DKLU5gst8Fop6lZmVX8kvaicu8i5L9Q=; b=se7L/qG6KXL0Ml484V4tF8Ibum ootSC+6eD4zC+9BRQBLLYODMhuSiH1nnzl3Bq4I3cGPHOWMvr0vVvHssVsENjjGtTxQcn4g1aPUtU MuEOHgvGmQrI0dWTIcCXw02IwpL6Lf9G6ERLzYu7FkTWZkCagajkWoutQWChDVRtHPRU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Subject: [qemu-mainline bisection] complete test-amd64-i386-libvirt Message-Id: From: osstest service owner Date: Wed, 31 Mar 2021 04:42:32 +0000 branch xen-unstable xenbranch xen-unstable job test-amd64-i386-libvirt testid guest-start Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8d17adf34f501ded65a106572740760f0a75577c Bug not present: e67d8e2928200e24ecb47c7be3ea8270077f2996 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160575/ commit 8d17adf34f501ded65a106572740760f0a75577c Author: Daniel P. Berrangé Date: Mon Feb 22 11:16:32 2021 +0000 block: remove support for using "file" driver with block/char devices The 'host_device' and 'host_cdrom' drivers must be used instead. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/test-amd64-i386-libvirt.guest-start.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/test-amd64-i386-libvirt.guest-start --summary-out=tmp/160575.bisection-summary --basis-template=152631 --blessings=real,real-bisect,real-retry qemu-mainline test-amd64-i386-libvirt guest-start Searching for failure / basis pass: 160541 fail [host=huxelrebe1] / 160125 [host=elbling0] 160119 [host=pinot1] 160113 [host=chardonnay1] 160104 [host=albana1] 160097 [host=fiano1] 160091 [host=chardonnay0] 160088 ok. Failure / basis pass flights: 160541 / 160088 (tree with no url: minios) Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ec2e6e016d24bd429792d08cf607e4c5350dcdaa b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced Basis pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6157b0e19721aadb4c7fdcfe57b2924af6144b14 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 14b95b3b8546db201e7efd0636ae0e215fae98f3 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/libvirt.git#2c846fa6bcc11929c9fb857a22430fb9945654ad-2c846fa6bcc11929c9fb857a22430fb9945654ad https://gitlab.com/keycodemap/keycodemapdb.git#27acf0ef828bf719b2053ba398b195829413dbdd-27acf0ef828bf719b2053ba398b195829413dbdd git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0\ dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#4751a48aeb2ab828b0a5cbdc585fd3642967cda1-b33cf5bfcb4c941370739dfbbe1532ff508fd29d git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#6157b0e19721aadb4c7fdcfe57b2924af6144b14-ec2e6e016d24bd429792d08cf607e4c5350dcdaa git://xenbits.xen.org/osstest/seabios.git#b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee-b0d61ec\ ef66eb05bd7a4eb7ada88ec5dab06dfee git://xenbits.xen.org/xen.git#14b95b3b8546db201e7efd0636ae0e215fae98f3-e680cc48b7184d3489873d6776f84ba1fc238ced Loaded 25168 nodes in revision graph Searching for test results: 160082 [host=albana0] 160088 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6157b0e19721aadb4c7fdcfe57b2924af6144b14 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 14b95b3b8546db201e7efd0636ae0e215fae98f3 160091 [host=chardonnay0] 160097 [host=fiano1] 160104 [host=albana1] 160113 [host=chardonnay1] 160119 [host=pinot1] 160125 [host=elbling0] 160134 fail irrelevant 160147 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2e1293cbaac75e84f541f9acfa8e26749f4c3562 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160167 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ca318882714080fb81fe9eb89a7b7934efc5bfae 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 bdee969c0e65d4d509932b1d70e3a3b2ffbff6d5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160328 fail irrelevant 160361 fail irrelevant 160392 fail irrelevant 160418 fail irrelevant 160448 fail irrelevant 160477 fail irrelevant 160501 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160531 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6157b0e19721aadb4c7fdcfe57b2924af6144b14 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 14b95b3b8546db201e7efd0636ae0e215fae98f3 160533 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160534 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 f2a9a6c2a86570ccbf8c5c30cbb8bf723168c459 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160536 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8a40754bca14df63c6d2ffe473b68a270dc50679 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160538 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7286d62d4e259be8cecf3dc2deea80ecc14489a5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160522 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7b9a3c9f94bcac23c534bc9f42a9e914b433b299 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160539 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 2255564fd21059960966b47212def9069cb56077 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160540 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6e71c36557ed41017e634ae392fa80f03ced7fa1 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160542 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 fc4a62f65cbd2d5d2c247ed4fbf64a05e6485859 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160543 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8b858f9998a9d59a9a7188f2c5c6ffb99eff6115 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160544 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 30ca7eddc486646fa19c9619fcf233ceaa65e28c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160572 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160545 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 283d845c9164f57f5dba020a4783bb290493802f b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160548 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a752dd07466c4f0bda5c14d001b096e778a44ad5 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee b4011741e6b39a8fd0ed5aded96c16c45ead5888 160550 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 db492ebb91059b818d5b5ea5975d227e5c3c9bcc b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160552 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 313d86c956d4599054a9dcd524668f67797d317a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 56b89f455894e4628ad7994fe5dd348145d1a9c5 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160554 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 eb07bfb09ef5483ad58ed0eba713f32fb0c909f9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 4083904bc9fe5da580f7ca397b1e828fbc322732 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160556 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 146f720c55637410062041f68dc908645cd18aaa b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160561 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ad1324e044240ae9fcf67e4c215481b7a35591b9 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160541 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ec2e6e016d24bd429792d08cf607e4c5350dcdaa b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160562 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 516990f4df4f7bf9f86d38af71ead7175df15c19 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160564 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4751a48aeb2ab828b0a5cbdc585fd3642967cda1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6157b0e19721aadb4c7fdcfe57b2924af6144b14 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 14b95b3b8546db201e7efd0636ae0e215fae98f3 160566 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b33cf5bfcb4c941370739dfbbe1532ff508fd29d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ec2e6e016d24bd429792d08cf607e4c5350dcdaa b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee e680cc48b7184d3489873d6776f84ba1fc238ced 160567 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee dae3c3e8b257cd27d6b35a467a34bf79a6650340 160569 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160570 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160571 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160574 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 160575 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 8d17adf34f501ded65a106572740760f0a75577c b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 Searching for interesting versions Result found: flight 160088 (pass), for basis pass Result found: flight 160541 (fail), for basis failure Repro found: flight 160564 (pass), for basis pass Repro found: flight 160566 (fail), for basis failure 0 revisions at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9fd7e88c23f6fb056d25fbc3f8e2e7c1a53859d1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 e67d8e2928200e24ecb47c7be3ea8270077f2996 b0d61ecef66eb05bd7a4eb7ada88ec5dab06dfee 21657ad4f01a634beac570c64c0691e51b9cf366 No revisions left to test, checking graph state. Result found: flight 160569 (pass), for last pass Result found: flight 160570 (fail), for first failure Repro found: flight 160571 (pass), for last pass Repro found: flight 160572 (fail), for first failure Repro found: flight 160574 (pass), for last pass Repro found: flight 160575 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 8d17adf34f501ded65a106572740760f0a75577c Bug not present: e67d8e2928200e24ecb47c7be3ea8270077f2996 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/160575/ commit 8d17adf34f501ded65a106572740760f0a75577c Author: Daniel P. Berrangé Date: Mon Feb 22 11:16:32 2021 +0000 block: remove support for using "file" driver with block/char devices The 'host_device' and 'host_cdrom' drivers must be used instead. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé Revision graph left in /home/logs/results/bisect/qemu-mainline/test-amd64-i386-libvirt.guest-start.{dot,ps,png,html,svg}. ---------------------------------------- 160575: tolerable FAIL flight 160575 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/160575/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-i386-libvirt 14 guest-start fail baseline untested jobs: build-i386-libvirt pass test-amd64-i386-libvirt fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Wed Mar 31 05:20:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 05:20:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103720.197851 (Exim 4.92) (envelope-from ) id 1lRTGm-0005bZ-OI; Wed, 31 Mar 2021 05:19:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103720.197851; Wed, 31 Mar 2021 05:19:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRTGm-0005bS-LA; Wed, 31 Mar 2021 05:19:56 +0000 Received: by outflank-mailman (input) for mailman id 103720; Wed, 31 Mar 2021 05:19:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRTGl-0005bE-4s; Wed, 31 Mar 2021 05:19:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRTGk-00032f-QG; Wed, 31 Mar 2021 05:19:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRTGk-0002U5-IF; Wed, 31 Mar 2021 05:19:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRTGk-0001aU-Hi; Wed, 31 Mar 2021 05:19:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Gk3w/KXvSzB65QdvsDiNlHL0gOQ/Q9WK4+YN5qj4YAI=; b=v2uHhqcJFtND7lhRxFLMyFACzP nPx6/RYdf2QssBC3/hKs1fRHl+aPcYP2ykhJUl50NUNZtBcTOgPXfC2T2v36dn8VIzqME61aTkUug IURPu8aLtDZm7ZrAc5yyx2puYO+ubJuM3RHT29lSjIdqj45nNQGNBWmbyStfwxCew0fY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160560: all pass - PUSHED X-Osstest-Versions-This: ovmf=98ff7e3c6373d3e0590f953459b6234ab12edce6 X-Osstest-Versions-That: ovmf=b33cf5bfcb4c941370739dfbbe1532ff508fd29d From: osstest service owner Date: Wed, 31 Mar 2021 05:19:54 +0000 flight 160560 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160560/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 98ff7e3c6373d3e0590f953459b6234ab12edce6 baseline version: ovmf b33cf5bfcb4c941370739dfbbe1532ff508fd29d Last test of basis 160456 2021-03-26 20:57:11 Z 4 days Testing same since 160560 2021-03-30 13:10:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Dandan Bi jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b33cf5bfcb..98ff7e3c63 98ff7e3c6373d3e0590f953459b6234ab12edce6 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Mar 31 07:54:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 07:54:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103769.197889 (Exim 4.92) (envelope-from ) id 1lRVg9-0005VB-1x; Wed, 31 Mar 2021 07:54:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103769.197889; Wed, 31 Mar 2021 07:54:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRVg8-0005V4-VG; Wed, 31 Mar 2021 07:54:16 +0000 Received: by outflank-mailman (input) for mailman id 103769; Wed, 31 Mar 2021 07:54:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRVg7-0005Uw-Dn; Wed, 31 Mar 2021 07:54:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRVg7-0005YW-6V; Wed, 31 Mar 2021 07:54:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRVg6-0001F4-T8; Wed, 31 Mar 2021 07:54:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRVg6-0002Dq-Se; Wed, 31 Mar 2021 07:54:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+JObIRraXdieLuQH4glzX9tRSV7QOg7HxvnM2RU/LsE=; b=g1e6ztm/8x5WTvtVFJrw+RipPL z3cveEetypmwqDl3dHEho2iTzZxQ5pWJ/CwHMOFy+uifubVRs+l8tSLNzGGgpA7Q10Bt8NRLDxmOb UhibxUsER8lSolIgwI8mwfDVuvcnE9GS6FbfQmvxsveu07XUAbaosQ+6MLEx3hQT7P/A=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 160576: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=a3c8355f8b5eeb2c588da04d4dfb7c3686a7dc13 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 31 Mar 2021 07:54:14 +0000 flight 160576 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160576/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt a3c8355f8b5eeb2c588da04d4dfb7c3686a7dc13 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 264 days Failing since 151818 2020-07-11 04:18:52 Z 263 days 256 attempts Testing same since 160576 2021-03-31 04:18:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Dmytro Linkin Eiichi Tsukata Erik Skultety Fabian Affolter Fabian Freyer Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jianan Gao Jim Fehlig Jin Yan Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Liao Pingfang Lin Ma Lin Ma Lin Ma Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Gaiser Stefan Bader Stefan Berger Stefan Berger Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Wang Xin WangJian Weblate Yalei Li <274268859@qq.com> Yalei Li Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zheng Chuan zhenwei pi Zhenyu Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 49332 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 31 08:37:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 08:37:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103801.197929 (Exim 4.92) (envelope-from ) id 1lRWMF-0001hI-9Y; Wed, 31 Mar 2021 08:37:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103801.197929; Wed, 31 Mar 2021 08:37:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRWMF-0001hB-6D; Wed, 31 Mar 2021 08:37:47 +0000 Received: by outflank-mailman (input) for mailman id 103801; Wed, 31 Mar 2021 08:37:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRWME-0001gk-4p; Wed, 31 Mar 2021 08:37:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRWMD-0006m6-UZ; Wed, 31 Mar 2021 08:37:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRWMD-00031R-No; Wed, 31 Mar 2021 08:37:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRWMD-0004JS-NK; Wed, 31 Mar 2021 08:37:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sz4YnBkSKfDAEe76UD7YVX8lwvQU/FqC71h46rMadiM=; b=Eh5sU+twzxN8hO4Vn1P1pKewVy VWywK4eLfGgIZGr+ii2soq3Ufy/EaTD+mRg1z8Bu5uo71F86MBB6y5yGFLsG0mCRY/8NRwi7QLg3a BjVyWzsdKOSFIrVuOCydHYAn/HGjz5/4p49+LozOTu+7qtMiCkv3PCpWy6VjXy1WZjGk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160559: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=cead8c0d17462f3a1150b5657d3f4eaa88faf1cb X-Osstest-Versions-That: xen=cead8c0d17462f3a1150b5657d3f4eaa88faf1cb From: osstest service owner Date: Wed, 31 Mar 2021 08:37:45 +0000 flight 160559 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160559/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160537 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160537 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160537 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160537 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160537 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160537 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160537 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160537 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160537 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160537 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160537 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass version targeted for testing: xen cead8c0d17462f3a1150b5657d3f4eaa88faf1cb baseline version: xen cead8c0d17462f3a1150b5657d3f4eaa88faf1cb Last test of basis 160559 2021-03-30 13:03:24 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed Mar 31 09:15:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 09:15:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103810.197944 (Exim 4.92) (envelope-from ) id 1lRWwa-0005Hj-GK; Wed, 31 Mar 2021 09:15:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103810.197944; Wed, 31 Mar 2021 09:15:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRWwa-0005Hc-D9; Wed, 31 Mar 2021 09:15:20 +0000 Received: by outflank-mailman (input) for mailman id 103810; Wed, 31 Mar 2021 09:15:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRWwY-0005HX-Th for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 09:15:19 +0000 Received: from mail-ot1-x330.google.com (unknown [2607:f8b0:4864:20::330]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c3fe011b-ac8a-4212-abf3-cbd89e61a5f5; Wed, 31 Mar 2021 09:15:17 +0000 (UTC) Received: by mail-ot1-x330.google.com with SMTP id v24-20020a9d69d80000b02901b9aec33371so18307066oto.2 for ; Wed, 31 Mar 2021 02:15:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3fe011b-ac8a-4212-abf3-cbd89e61a5f5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/D26C0u1s6hM6ll6DeVeqaC5slFPgJC29V0eguhwf6Q=; b=X8AJko9TQdt+yqB27GkzbogdMQS7aWcw4tzT4YNPnsGBRraiNx7YcgyfwXrsbjSsS2 aq89P9GVoC3QdBr03AUV7LjZ4fL2YOj4Ufss6nmB6QuAKNJ07rXqP4pw67ukRTksBql6 yLN7hN9SNoacb20Igbu4gh3jOaY/9oZXLd9fbCJ4ezq6oym/AT7dNgjH2xji2cY/AV/3 XcvclhDDklYmRK6O1VfZTn4eLgPxKhHBQQpSVB6dZJ53aR3h6j2GMJoscnhWQIwCHayy 8NmGbQBvL+lJTaxsk+qNOOhs9Ao1x+QxcVS9DTp9yOmDLIAzKCyqNhMUWP50+bNT8bDl dJbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/D26C0u1s6hM6ll6DeVeqaC5slFPgJC29V0eguhwf6Q=; b=hdCKlmLstv0DGPOuPdQbFZaS74aghlF/urHCpv6t6tsxz9TGNwCqkvg7KukFWy2YNG g7DqoGwGRLNbG3nnHGuHN0gsm7dyVVqps4CA8kaGh5hoFAw6aD5ST1Dh+9TbEj9yhT4H gPc0XO0GzUZDW/vFipVKbMmhjpZgDLsHeZq5sp2zh4tr/Vwlg4MlRzg8C9Ei3SYUfE2t p7pLhlMBOzwspa8eFjVlBIKC1K3p/zJT0fDMKQCTd6JUTXa7KccwqwyKM1SXbc517scZ rrSRDHXmbldo3Mr4wNu3gZalHNB7m2ha56mF7lq3GFuygAugEhKlvXaG1v6csioJFQ8Q r1SQ== X-Gm-Message-State: AOAM533SCbh8/hoQMuoAwF6CC0nwV/4bPTg32w5UF/xfNu5piNN5SCfl iA6Fj3KXWRXRZuU0Jyer8XMzK/sfpSyE+BiuocSvVHW72u3ApA== X-Google-Smtp-Source: ABdhPJwRzC/Tv3wYBv+SgCUp3ZVp++Hjsy0S14Y82RvYoWHXxkgV9D2EhcLrSt9gfwz1dORvngmOg3d/iI1oX43utr4= X-Received: by 2002:a9d:748a:: with SMTP id t10mr2006571otk.198.1617182116908; Wed, 31 Mar 2021 02:15:16 -0700 (PDT) MIME-Version: 1.0 References: <889B1827-1FEB-4AC0-9002-278337D19ED5@citrix.com> <20210330124646.jl4re5srmbzhkipm@steredhat> In-Reply-To: <20210330124646.jl4re5srmbzhkipm@steredhat> From: John Simpson Date: Wed, 31 Mar 2021 05:15:05 -0400 Message-ID: Subject: Re: An error due to installation that require binutils package To: Stefano Garzarella Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, "gcc-help@gcc.gnu.org" , Community Manager , George Dunlap Content-Type: multipart/alternative; boundary="0000000000009d8fc205bed18d13" --0000000000009d8fc205bed18d13 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Got you Stefano, Appreciate for your reply. On Tue, Mar 30, 2021 at 8:46 AM Stefano Garzarella wrote: > Hi John, > > On Mon, Mar 29, 2021 at 09:46:49PM +0300, John Simpson wrote: > >Hello, > > > >Kindly ask you to have a look at this bug. > >Thank you for your replies. > > It's already fixed in QEMU upstream and the fix will be released with > the 6.0 version next month (the rc0 is already available): > > https://gitlab.com/qemu-project/qemu/-/commit/bbd2d5a8120771ec59b86a80a1f= 51884e0a26e53 > > I guess xen-4.14.1 is using an older version, so if you want you can > backport that patch in your version, the change should be simple. > > Thanks, > Stefano > > > > >On Mon, Mar 29, 2021 at 7:07 PM George Dunlap > >wrote: > > > >> John, > >> > >> Thanks for your report. Can you post your bug report > >> xen-devel@lists.xenproject.org ? > >> > >> The bug is in the compilation of QEMU, which is an external project; s= o > >> it=E2=80=99s possible that we=E2=80=99ll end up having to raise this w= ith that > community as > >> well. > >> > >> Thanks, > >> -George Dunlap > >> > >> > On Mar 28, 2021, at 2:26 PM, John Simpson > wrote: > >> > > >> > Hello, > >> > > >> > Just forwarding this message to you. Can you give some thoughs about > >> this? Thanks a lot. > >> > > >> > > >> > ---------- Forwarded message --------- > >> > From: Alan Modra > >> > Date: Sun, Mar 28, 2021 at 2:21 PM > >> > Subject: Re: An error due to installation that require binutils > package. > >> > To: John Simpson > >> > Cc: > >> > > >> > > >> > On Sun, Mar 28, 2021 at 12:55:23PM +0300, John Simpson via Binutils > >> wrote: > >> > > BUILD pc-bios/optionrom/kvmvapic.img > >> > > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie = ?) > >> > > >> > -no-pie is a gcc option. Neither -no-pie nor --no-pie is a valid ld > >> > option. The fault lies with whatever passed -no-pie to ld. > >> > > >> > -- > >> > Alan Modra > >> > Australia Development Lab, IBM > >> > > >> > > >> > > >> > ---------- Forwarded message --------- > >> > From: Andreas Schwab > >> > Date: Sun, Mar 28, 2021 at 2:17 PM > >> > Subject: Re: An error due to installation that require binutils > >> > package. > >> > To: John Simpson via Binutils > >> > Cc: John Simpson > >> > > >> > > >> > Please report that to the xen project. ld -no-pie doesn't have a > useful > >> > meaning. It used to mean the same as ld -n -o-pie, which sets "-pie= " > as > >> > the output file name. > >> > > >> > Andreas. > >> > > >> > -- > >> > Andreas Schwab, schwab@linux-m68k.org > >> > GPG Key fingerprint =3D 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9D= A > AEC1 > >> > "And now for something completely different." > >> > > >> > > >> > > >> > ---------- Forwarded message --------- > >> > From: John Simpson > >> > Date: Sun, Mar 28, 2021 at 12:55 PM > >> > Subject: An error due to installation that require binutils package. > >> > To: > >> > > >> > > >> > Hello, > >> > > >> > Recently I got a following error due to installation xen on > >> 5.11.6-1-MANJARO kernel: > >> > > >> > GEN target/riscv/trace.c > >> > GEN target/s390x/trace.c > >> > GEN target/sparc/trace.c > >> > GEN util/trace.c > >> > GEN config-all-devices.mak > >> > make[1]: Entering directory > >> '/home/username/xen/src/xen-4.14.1/tools/qemu-xen/slirp' > >> > make[1]: Nothing to be done for 'all'. > >> > make[1]: Leaving directory > >> '/home/username/xen/src/xen-4.14.1/tools/qemu-xen/slirp' > >> > BUILD pc-bios/optionrom/multiboot.img > >> > BUILD pc-bios/optionrom/linuxboot.img > >> > BUILD pc-bios/optionrom/linuxboot_dma.img > >> > BUILD pc-bios/optionrom/kvmvapic.img > >> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > >> > make[1]: *** [Makefile:53: multiboot.img] Error 1 > >> > make[1]: *** Waiting for unfinished jobs.... > >> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > >> > make[1]: *** [Makefile:53: linuxboot_dma.img] Error 1 > >> > BUILD pc-bios/optionrom/pvh.img > >> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > >> > make[1]: *** [Makefile:53: linuxboot.img] Error 1 > >> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > >> > make[1]: *** [Makefile:53: kvmvapic.img] Error 1 > >> > ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?) > >> > make[1]: *** [Makefile:50: pvh.img] Error 1 > >> > make: *** [Makefile:581: pc-bios/optionrom/all] Error 2 > >> > make: Leaving directory > >> '/home/username/xen/src/xen-4.14.1/tools/qemu-xen-build' > >> > make[3]: *** [Makefile:218: subdir-all-qemu-xen-dir] Error 2 > >> > make[3]: Leaving directory '/home/username/xen/src/xen-4.14.1/tools' > >> > make[2]: *** > >> [/home/username/xen/src/xen-4.14.1/tools/../tools/Rules.mk:235: > >> subdirs-install] Error 2 > >> > make[2]: Leaving directory '/home/username/xen/src/xen-4.14.1/tools' > >> > make[1]: *** [Makefile:72: install] Error 2 > >> > make[1]: Leaving directory '/home/username/xen/src/xen-4.14.1/tools' > >> > make: *** [Makefile:134: install-tools] Error 2 > >> > =3D=3D> ERROR: A failure occurred in build(). > >> > Aborting... > >> > > >> > Currently I have fresh binutils 2.36.1-2 and it seems to me that the > >> issue is related to this part of code: > >> > > >> > https://github.com/bminor/binutils-gdb/blob/master/ld/lexsup.c#L451 > >> > > >> > It seems to me that this could impact far more users than just me. > >> > > >> > >> > > --0000000000009d8fc205bed18d13 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Got you Stefano,

Appreciate = for your reply.

On Tue, Mar 30, 2021 at 8:46 AM Stefano Garzarella <= ;sgarzare@redhat.com> wrote:<= br>
Hi John,

On Mon, Mar 29, 2021 at 09:46:49PM +0300, John Simpson wrote:
>Hello,
>
>Kindly ask you to have a look at this bug.
>Thank you for your replies.

It's already fixed in QEMU upstream and the fix will be released with <= br> the 6.0 version next month (the rc0 is already available):
https://gitlab= .com/qemu-project/qemu/-/commit/bbd2d5a8120771ec59b86a80a1f51884e0a26e53

I guess xen-4.14.1 is using an older version, so if you want you can
backport that patch in your version, the change should be simple.

Thanks,
Stefano

>
>On Mon, Mar 29, 2021 at 7:07 PM George Dunlap <George.Dunlap@citrix.com> >wrote:
>
>> John,
>>
>> Thanks for your report.=C2=A0 Can you post your bug report
>> xen-devel@lists.xenproject.org ?
>>
>> The bug is in the compilation of QEMU, which is an external projec= t; so
>> it=E2=80=99s possible that we=E2=80=99ll end up having to raise th= is with that community as
>> well.
>>
>> Thanks,
>>=C2=A0 -George Dunlap
>>
>> > On Mar 28, 2021, at 2:26 PM, John Simpson <ttr9droid@gmail.com> wrote= :
>> >
>> > Hello,
>> >
>> > Just forwarding this message to you. Can you give some though= s about
>> this? Thanks a lot.
>> >
>> >
>> > ---------- Forwarded message ---------
>> > From: Alan Modra <amodra@gmail.com>
>> > Date: Sun, Mar 28, 2021 at 2:21 PM
>> > Subject: Re: An error due to installation that require binuti= ls package.
>> > To: John Simpson <ttr9droid@gmail.com>
>> > Cc: <binutils@sourceware.org>
>> >
>> >
>> > On Sun, Mar 28, 2021 at 12:55:23PM +0300, John Simpson via Bi= nutils
>> wrote:
>> > >=C2=A0 =C2=A0BUILD=C2=A0 =C2=A0pc-bios/optionrom/kvmvapic= .img
>> > > ld: Error: unable to disambiguate: -no-pie (did you mean= --no-pie ?)
>> >
>> > -no-pie is a gcc option.=C2=A0 Neither -no-pie nor --no-pie i= s a valid ld
>> > option.=C2=A0 The fault lies with whatever passed -no-pie to = ld.
>> >
>> > --
>> > Alan Modra
>> > Australia Development Lab, IBM
>> >
>> >
>> >
>> > ---------- Forwarded message ---------
>> > From: Andreas Schwab <schwab@linux-m68k.org>
>> > Date: Sun, Mar 28, 2021 at 2:17 PM
>> > Subject: Re: An error due to installation that require binuti= ls
>> > package.
>> > To: John Simpson via Binutils <binutils@sourceware.org>
>> > Cc: John Simpson <ttr9droid@gmail.com>
>> >
>> >
>> > Please report that to the xen project.=C2=A0 ld -no-pie doesn= 't have a useful
>> > meaning.=C2=A0 It used to mean the same as ld -n -o-pie, whic= h sets "-pie" as
>> > the output file name.
>> >
>> > Andreas.
>> >
>> > --
>> > Andreas Schwab, schwab@linux-m68k.org
>> > GPG Key fingerprint =3D 7578 EB47 D4E5 4D69 2510=C2=A0 2552 D= F73 E780 A9DA AEC1
>> > "And now for something completely different."
>> >
>> >
>> >
>> > ---------- Forwarded message ---------
>> > From: John Simpson <ttr9droid@gmail.com>
>> > Date: Sun, Mar 28, 2021 at 12:55 PM
>> > Subject: An error due to installation that require binutils p= ackage.
>> > To: <binutils@sourceware.org>
>> >
>> >
>> > Hello,
>> >
>> > Recently I got a following error due to installation xen on >> 5.11.6-1-MANJARO kernel:
>> >
>> >=C2=A0 =C2=A0GEN=C2=A0 =C2=A0 =C2=A0target/riscv/trace.c
>> >=C2=A0 =C2=A0GEN=C2=A0 =C2=A0 =C2=A0target/s390x/trace.c
>> >=C2=A0 =C2=A0GEN=C2=A0 =C2=A0 =C2=A0target/sparc/trace.c
>> >=C2=A0 =C2=A0GEN=C2=A0 =C2=A0 =C2=A0util/trace.c
>> >=C2=A0 =C2=A0GEN=C2=A0 =C2=A0 =C2=A0config-all-devices.mak
>> > make[1]: Entering directory
>> '/home/username/xen/src/xen-4.14.1/tools/qemu-xen/slirp' >> > make[1]: Nothing to be done for 'all'.
>> > make[1]: Leaving directory
>> '/home/username/xen/src/xen-4.14.1/tools/qemu-xen/slirp' >> >=C2=A0 =C2=A0BUILD=C2=A0 =C2=A0pc-bios/optionrom/multiboot.img=
>> >=C2=A0 =C2=A0BUILD=C2=A0 =C2=A0pc-bios/optionrom/linuxboot.img=
>> >=C2=A0 =C2=A0BUILD=C2=A0 =C2=A0pc-bios/optionrom/linuxboot_dma= .img
>> >=C2=A0 =C2=A0BUILD=C2=A0 =C2=A0pc-bios/optionrom/kvmvapic.img<= br> >> > ld: Error: unable to disambiguate: -no-pie (did you mean --no= -pie ?)
>> > make[1]: *** [Makefile:53: multiboot.img] Error 1
>> > make[1]: *** Waiting for unfinished jobs....
>> > ld: Error: unable to disambiguate: -no-pie (did you mean --no= -pie ?)
>> > make[1]: *** [Makefile:53: linuxboot_dma.img] Error 1
>> >=C2=A0 =C2=A0BUILD=C2=A0 =C2=A0pc-bios/optionrom/pvh.img
>> > ld: Error: unable to disambiguate: -no-pie (did you mean --no= -pie ?)
>> > make[1]: *** [Makefile:53: linuxboot.img] Error 1
>> > ld: Error: unable to disambiguate: -no-pie (did you mean --no= -pie ?)
>> > make[1]: *** [Makefile:53: kvmvapic.img] Error 1
>> > ld: Error: unable to disambiguate: -no-pie (did you mean --no= -pie ?)
>> > make[1]: *** [Makefile:50: pvh.img] Error 1
>> > make: *** [Makefile:581: pc-bios/optionrom/all] Error 2
>> > make: Leaving directory
>> '/home/username/xen/src/xen-4.14.1/tools/qemu-xen-build' >> > make[3]: *** [Makefile:218: subdir-all-qemu-xen-dir] Error 2<= br> >> > make[3]: Leaving directory '/home/username/xen/src/xen-4.= 14.1/tools'
>> > make[2]: ***
>> [/home/username/xen/src/xen-4.14.1/tools/../tools/Rules.mk:235: >> subdirs-install] Error 2
>> > make[2]: Leaving directory '/home/username/xen/src/xen-4.= 14.1/tools'
>> > make[1]: *** [Makefile:72: install] Error 2
>> > make[1]: Leaving directory '/home/username/xen/src/xen-4.= 14.1/tools'
>> > make: *** [Makefile:134: install-tools] Error 2
>> > =3D=3D> ERROR: A failure occurred in build().
>> >=C2=A0 =C2=A0 =C2=A0Aborting...
>> >
>> > Currently I have fresh binutils 2.36.1-2 and it seems to me t= hat the
>> issue is related to this part of code:
>> >
>> > https://github.com/= bminor/binutils-gdb/blob/master/ld/lexsup.c#L451
>> >
>> > It seems to me that this could impact far more users than jus= t me.
>> >
>>
>>

--0000000000009d8fc205bed18d13-- From xen-devel-bounces@lists.xenproject.org Wed Mar 31 09:44:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 09:44:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103808.197955 (Exim 4.92) (envelope-from ) id 1lRXOM-0008CR-ID; Wed, 31 Mar 2021 09:44:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103808.197955; Wed, 31 Mar 2021 09:44:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRXOM-0008CK-F5; Wed, 31 Mar 2021 09:44:02 +0000 Received: by outflank-mailman (input) for mailman id 103808; Wed, 31 Mar 2021 09:06:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRWoF-0004Ps-0G for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 09:06:43 +0000 Received: from mail-wr1-x42a.google.com (unknown [2a00:1450:4864:20::42a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1094f86e-64c0-4ce6-a7a3-79a59d337d09; Wed, 31 Mar 2021 09:06:41 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id e18so18867806wrt.6 for ; Wed, 31 Mar 2021 02:06:41 -0700 (PDT) Received: from KJerrY-TPad (82-132-235-44.dab.02.net. [82.132.235.44]) by smtp.gmail.com with ESMTPSA id c11sm3311273wrm.67.2021.03.31.02.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Mar 2021 02:06:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1094f86e-64c0-4ce6-a7a3-79a59d337d09 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:subject:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=IOUJe2tihTzla+erqhwVJsivSTtTbZipunSRUJNldxg=; b=YriR/wzYVk5Uma+KgBfwE+20pLxMrlbzZK9kN9BmaxNM2W77u1lK2zTl5lNwpGoQuZ /vkXlg3uduy7V9mKHvn+tsQ4JHlub39EG2dOaZM3pBWvRWzs5bGapFjTXqBavfq7KQOY aYF5GggxCqMoujwAhduKPjLWzqaJ/7PIhf50dMAUzQqGcbBMtQB96c93kJg6z4+G9k6m ptjNaF7E9SihDWDk9CZ692tx63jmNyyhPQTpBrHzG9t6aK3AVmEJdQ4QwpyfwTpVtfM2 Upk8wewd9H1aNcYz70t3VWFoA9EInG53EQz1nT3fGYMqHeU6wqGCaAPfQcERF+TPo9// fIsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:subject:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=IOUJe2tihTzla+erqhwVJsivSTtTbZipunSRUJNldxg=; b=ouFzwSnt24EGOB5q14bs9Ppo+MAkwboQjZRXF2RBvNg4hzibzFMf6Uq/esPsXEE+W4 ZbtjsXMkGq2h+u1rtYzhSbJtMJyZqZ5/b9imbyUini+E1ZW6yKaquhWjSyxpdZgfBZD+ wQ5bi462hg3eyv7cabA2XaDO9HYTL4UHd3N7qKXNUD4O2nQp5Wl93XC+wMrjN6WoVPo0 L+0Tydvp86fxXZ0V7rUiubAPYh+Q1BZkE1XUQtytf9nReXvjPLFnZeNGAm3SJLCNKZZy uvMoEqcEzjY1q04FTqF6xpp/Ks8ONnnV/lIzsoMh8geRVXIU3IRiwFOma8BsKDI/On43 4oZQ== X-Gm-Message-State: AOAM530MCnlMI7pUuP7NAO3Zq5eI45r+Y38v3NyDV99Nu1WSZJLl7D++ ZGG6ulcbXB1ak/6uoyq7ddQ= X-Google-Smtp-Source: ABdhPJx5YV2bllswP9Y5HDR1gd78JxAq/tXgJVrMlFlfswTcU+ohp7EIfHZnR2PamFVgNaPqHvPRqg== X-Received: by 2002:adf:e8c9:: with SMTP id k9mr2405325wrn.315.1617181600635; Wed, 31 Mar 2021 02:06:40 -0700 (PDT) From: Hongyan Xia X-Google-Original-From: Hongyan Xia Message-ID: Subject: Re: [PATCH RESEND] Performance regression due to XSA-336 To: Boris Ostrovsky , xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com Date: Wed, 31 Mar 2021 10:06:31 +0100 In-Reply-To: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> References: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Thank you for the patch. We observed similar issues. However, would you mind sharing more details on the test setup? We tested the hypervisor after injecting XSA-336. There were regressions in some benchmarks but far from being enough to raise a serious alarm. In particular, we benchmarked CPU, disk I/O, network and timer performance on VMs with 64 and even 128 vCPUs and the noticeable regression was a 60% drop in the ACPI PM timer when all vCPUs are actively accessing the timer. We did not see concerns in real-world benchmarks so I am curious how the -40% was seen. Is it possible that the guest itself was using ACPI timer as the clocksource? That could explain a lot. It might also be useful to know what OS that was and other specs around the -40%. Thank you, Hongyan On Wed, 2021-03-24 at 17:05 -0400, Boris Ostrovsky wrote: > (Re-sending with Stephen added) > > > While running performance tests with recent XSAs backports to our > product we've > discovered significant regression in TPCC performance. With a > particular guest > kernel the numbers dropped by as much as 40%. > > We've narrowed that down to XSA-336 patch, specifically to the > pt_migrate rwlock, > and even more specifically to this lock being taken in > pt_update_irq(). > > We have quite a large guest (92 VCPUs) doing lots of VMEXITs and the > theory is > that lock's cnts atomic is starting to cause lots of coherence > traffic. As a > quick test of this replacing pt_vcpu_lock() in pt_update_irq() with > just > spin_lock(&v->arch.hvm_vcpu.tm_lock) gets us almost all performance > back. > > Stephen Brennan came up with new locking algorithm, I just coded it > up. > > A couple of notes: > > * We have only observed the problem and tested this patch for > performance on > a fairly old Xen version. However, vpt code is almost identical and > I expect > upstream to suffer from the same issue. > > * Stephen provided the following (slightly edited by me) writeup > explaining the > locking algorithm. I would like to include it somewhere but not > sure what the > right place would be. Commit message perhaps? > > > Currently, every periodic_time is protected by locking the vcpu it is > on. You > can think of the per-vCPU lock (tm_lock) as protecting the fields of > every > periodic_time which is attached to that vCPU, as well as the list > itself, and so > it must be held when read or written, or when an object is added or > removed > to/from the list. > > It seems that there are three types of access to the peridic_time > objects: > > 1. Functions which read (maybe write) all periodic_time instances > attached to a > particular vCPU. These are functions which use pt_vcpu_lock() > after the > commit, such as pt_restore_timer(), pt_save_timer(), etc. > 2. Functions which want to modify a particular periodic_time object. > These guys > lock whichever vCPU the periodic_time is attached to, but since > the vCPU > could be modified without holding any lock, they are vulnerable to > the bug. > Functions in this group use pt_lock(), such as pt_timer_fn() or > destroy_periodic_time(). > 3. Functions which not only want to modify the periodic_time, but > also would > like to modify the =vcpu= fields. These are create_periodic_time() > or > pt_adjust_vcpu(). They create the locking imbalance bug for group > 2, but we > can't simply hold 2 vcpu locks due to the deadlock risk. > > My proposed option is to add a per-periodic_time spinlock, which > protects only > the periodic_time.vcpu field. Whenever reading the vcpu field of a > periodic_time > struct, you must first take that lock. The critical sections of group > 1 (your > "fast path" functions) would look like this: > > 1. lock vcpu > 2. do whatever you want with pts currently on the vcpu. It is safe to > read or write > fields of pt, because the vcpu lock protects those fields. You > simply cannot > write pt->vcpu, because somebody holding the pt lock may already > be spinning > waiting for your vcpu lock. > 3. unlock vcpu > > > Note that there is no additional locking in this fast path. For group > 2 > functions (which are attempting to lock an individual periodic_time), > the > critical section would look like this: > > 1. lock pt lock (stabilizing the vcpu field) > 2. lock vcpu > 3. feel free to modify any field of the periodic_time > 4. unlock vcpu (due to the mutual exclusion of the pt lock, we know > that we are > unlocking the correct vcpu -- we have not been migrated) > 5. unlock pt > > For functions in group 3, the critical section would be: > > 1. lock pt (stabilizing the vcpu field) > 2. lock current vcpu > 3. remove from vcpu list > 4. unlock vcpu. At this point, you're guaranteed that the vcpu > functions > (callers of pt_vcpu_lock()) are not accessing your pt. > 5. assign pt->vcpu (we still have mutual exclusion against group 2 > functions) > 6. lock destination vcpu > 7. add to vcpu list > 8. unlock destination vcpu > 9. unlock pt > > If functions from group 2 and 3 are less frequent, then you won't see > too much > added lock overhead in this situation! Plus, even if group 2 and 3 > are somewhat > common, the performance overhead of an uncontented fine-grained lock > is muuch > smaller than the overhead of a heavily contended coarse-grained lock, > like the > per-domain rw lock. > > > Boris Ostrovsky (1): > x86/vpt: Replace per-guest pt_migrate lock with per pt lock > > xen/arch/x86/emul-i8254.c | 2 + > xen/arch/x86/hvm/hpet.c | 1 + > xen/arch/x86/hvm/hvm.c | 2 - > xen/arch/x86/hvm/rtc.c | 1 + > xen/arch/x86/hvm/vlapic.c | 1 + > xen/arch/x86/hvm/vpt.c | 122 +++++++++++++++++++++++--------- > ---------- > xen/include/asm-x86/hvm/vpt.h | 9 +--- > 7 files changed, 74 insertions(+), 64 deletions(-) > From xen-devel-bounces@lists.xenproject.org Wed Mar 31 09:54:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 09:54:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103815.197967 (Exim 4.92) (envelope-from ) id 1lRXYA-0000jS-IC; Wed, 31 Mar 2021 09:54:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103815.197967; Wed, 31 Mar 2021 09:54:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRXYA-0000jL-FF; Wed, 31 Mar 2021 09:54:10 +0000 Received: by outflank-mailman (input) for mailman id 103815; Wed, 31 Mar 2021 09:54:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRXY9-0000jG-15 for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 09:54:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRXY8-000836-Pt; Wed, 31 Mar 2021 09:54:08 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=freeip.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRXY7-0003Rg-6S; Wed, 31 Mar 2021 09:54:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Mime-Version:Content-Type: References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID; bh=IOUJe2tihTzla+erqhwVJsivSTtTbZipunSRUJNldxg=; b=xqBd6Phf53khymVT9bBW9mqPpg Q7xnmUNtiOmSWdc2/ZhmvS8FhE1jmkHyiS1hgGpn489LUaFVWuN21PP4Ej+6y0xOFFHRGhqFfuxCt +0gTxoywdW186zPAjmHRkbP6NBmP2V11sgmn2TZQdkO/G+fTWSHVNubgAV0ZEmIMsk/8=; Message-ID: Subject: Re: [PATCH RESEND] Performance regression due to XSA-336 From: Hongyan Xia To: Boris Ostrovsky , xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com Date: Wed, 31 Mar 2021 10:53:49 +0100 In-Reply-To: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> References: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Thank you for the patch. We observed similar issues. However, would you mind sharing more details on the test setup? We tested the hypervisor after injecting XSA-336. There were regressions in some benchmarks but far from being enough to raise a serious alarm. In particular, we benchmarked CPU, disk I/O, network and timer performance on VMs with 64 and even 128 vCPUs and the noticeable regression was a 60% drop in the ACPI PM timer when all vCPUs are actively accessing the timer. We did not see concerns in real-world benchmarks so I am curious how the -40% was seen. Is it possible that the guest itself was using ACPI timer as the clocksource? That could explain a lot. It might also be useful to know what OS that was and other specs around the -40%. Thank you, Hongyan On Wed, 2021-03-24 at 17:05 -0400, Boris Ostrovsky wrote: > (Re-sending with Stephen added) > > > While running performance tests with recent XSAs backports to our > product we've > discovered significant regression in TPCC performance. With a > particular guest > kernel the numbers dropped by as much as 40%. > > We've narrowed that down to XSA-336 patch, specifically to the > pt_migrate rwlock, > and even more specifically to this lock being taken in > pt_update_irq(). > > We have quite a large guest (92 VCPUs) doing lots of VMEXITs and the > theory is > that lock's cnts atomic is starting to cause lots of coherence > traffic. As a > quick test of this replacing pt_vcpu_lock() in pt_update_irq() with > just > spin_lock(&v->arch.hvm_vcpu.tm_lock) gets us almost all performance > back. > > Stephen Brennan came up with new locking algorithm, I just coded it > up. > > A couple of notes: > > * We have only observed the problem and tested this patch for > performance on > a fairly old Xen version. However, vpt code is almost identical and > I expect > upstream to suffer from the same issue. > > * Stephen provided the following (slightly edited by me) writeup > explaining the > locking algorithm. I would like to include it somewhere but not > sure what the > right place would be. Commit message perhaps? > > > Currently, every periodic_time is protected by locking the vcpu it is > on. You > can think of the per-vCPU lock (tm_lock) as protecting the fields of > every > periodic_time which is attached to that vCPU, as well as the list > itself, and so > it must be held when read or written, or when an object is added or > removed > to/from the list. > > It seems that there are three types of access to the peridic_time > objects: > > 1. Functions which read (maybe write) all periodic_time instances > attached to a > particular vCPU. These are functions which use pt_vcpu_lock() > after the > commit, such as pt_restore_timer(), pt_save_timer(), etc. > 2. Functions which want to modify a particular periodic_time object. > These guys > lock whichever vCPU the periodic_time is attached to, but since > the vCPU > could be modified without holding any lock, they are vulnerable to > the bug. > Functions in this group use pt_lock(), such as pt_timer_fn() or > destroy_periodic_time(). > 3. Functions which not only want to modify the periodic_time, but > also would > like to modify the =vcpu= fields. These are create_periodic_time() > or > pt_adjust_vcpu(). They create the locking imbalance bug for group > 2, but we > can't simply hold 2 vcpu locks due to the deadlock risk. > > My proposed option is to add a per-periodic_time spinlock, which > protects only > the periodic_time.vcpu field. Whenever reading the vcpu field of a > periodic_time > struct, you must first take that lock. The critical sections of group > 1 (your > "fast path" functions) would look like this: > > 1. lock vcpu > 2. do whatever you want with pts currently on the vcpu. It is safe to > read or write > fields of pt, because the vcpu lock protects those fields. You > simply cannot > write pt->vcpu, because somebody holding the pt lock may already > be spinning > waiting for your vcpu lock. > 3. unlock vcpu > > > Note that there is no additional locking in this fast path. For group > 2 > functions (which are attempting to lock an individual periodic_time), > the > critical section would look like this: > > 1. lock pt lock (stabilizing the vcpu field) > 2. lock vcpu > 3. feel free to modify any field of the periodic_time > 4. unlock vcpu (due to the mutual exclusion of the pt lock, we know > that we are > unlocking the correct vcpu -- we have not been migrated) > 5. unlock pt > > For functions in group 3, the critical section would be: > > 1. lock pt (stabilizing the vcpu field) > 2. lock current vcpu > 3. remove from vcpu list > 4. unlock vcpu. At this point, you're guaranteed that the vcpu > functions > (callers of pt_vcpu_lock()) are not accessing your pt. > 5. assign pt->vcpu (we still have mutual exclusion against group 2 > functions) > 6. lock destination vcpu > 7. add to vcpu list > 8. unlock destination vcpu > 9. unlock pt > > If functions from group 2 and 3 are less frequent, then you won't see > too much > added lock overhead in this situation! Plus, even if group 2 and 3 > are somewhat > common, the performance overhead of an uncontented fine-grained lock > is muuch > smaller than the overhead of a heavily contended coarse-grained lock, > like the > per-domain rw lock. > > > Boris Ostrovsky (1): > x86/vpt: Replace per-guest pt_migrate lock with per pt lock > > xen/arch/x86/emul-i8254.c | 2 + > xen/arch/x86/hvm/hpet.c | 1 + > xen/arch/x86/hvm/hvm.c | 2 - > xen/arch/x86/hvm/rtc.c | 1 + > xen/arch/x86/hvm/vlapic.c | 1 + > xen/arch/x86/hvm/vpt.c | 122 +++++++++++++++++++++++--------- > ---------- > xen/include/asm-x86/hvm/vpt.h | 9 +--- > 7 files changed, 74 insertions(+), 64 deletions(-) > From xen-devel-bounces@lists.xenproject.org Wed Mar 31 10:04:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 10:04:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103821.197980 (Exim 4.92) (envelope-from ) id 1lRXhk-0001nd-Kn; Wed, 31 Mar 2021 10:04:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103821.197980; Wed, 31 Mar 2021 10:04:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRXhk-0001nW-HH; Wed, 31 Mar 2021 10:04:04 +0000 Received: by outflank-mailman (input) for mailman id 103821; Wed, 31 Mar 2021 10:04:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRXhi-0001nR-Mu for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 10:04:02 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 146fda41-ddc4-43e3-862d-8b7d8cc7a013; Wed, 31 Mar 2021 10:04:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 146fda41-ddc4-43e3-862d-8b7d8cc7a013 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617185041; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=s3Iudod1Yov6Fu0koWZ8vq7cE3y7ENAg8o8CGRUxzEA=; b=M3ULQ8M3I6nd7K0DnQ12UrcjZ3jACAc5fihTPf7qzXT0Gb/Ta8WZ4s84 7d5PGOk6ypyjyFTWx0J+r2NAU4OfLTKGlrGMIFgHV92C/UaRSbNl+oEgX 1LAR5QeXM1Ai6nUCbNRqQLgF09IuLm1mFPxa6XSzYM+eANEqNjgO+0f7l 0=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: xAjDQw0Kh3wJ1Z77ni6oRFB4oqgT523frFpxMEfjhdYoHgo04zkzOdWDXoOx/a4DS62q1aGajd ReNXIaQHn6evHM1zxip2wrimloSRiBKXxcCdQhlilRqze919kpF84zL2zUOeeZTXAK7h6pkeHI W+laR36DobEtO91km+BHyPj+ft8FGiHdLcYYBfJiP8vcORLcPcO84xDwpE1PKrtC1TLdqtFhO8 mjdIqWn5u52KPpAyHBCfeon6w2NyFtZck3sdUvNObtAbKgTxSDhNrLlZSmaKiCWz/3ntREvzRu tto= X-SBRS: 5.2 X-MesageID: 41992517 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Slwpbqs+cpgoYgxNjveNgbLQ7skCrIMji2hD6mlwRA09T+Wxi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmwybde544NMbC+GDT3oWfAFvAG0aLO4R3FXxf/+OlUyL t6f8FFYuHYIFBmga/BjzWQPM0nxLC8npyAocf74zNTQRpxa6dmhj0JaDqzNkFtXgFJCd4YOf OnhvZvnDardXQJYsnTPBBsM9TrnNHXiIngJScPGh9P0mKzpAm14733GQXw5GZ8bxpzx94ZkF TtokjCyYiI99q6zRLd0GG71eUtpPLRjuFtKebJpswcKjDHghulaoJ7S9S5zU0IidDq0nkGup 3hpAohItRS5hrqDx2IiCqo4SbM+nIP7GLv0lCRi3eLm72HeBsKT/BvqKgcVzmx0TtFgPhMlJ hl8kjcir9sSTTHpyj578igbWATqmOE5UAMvMRWs2ZSSuIlGdhshL1axmx5OrEaEhn37Yg2ed Med/301bJtfVSWY2uxhBgI/PWcGnA6HhKxSkMfoMCi0z9PgHBjz0cDrfZv50s9yA== X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="41992517" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TUbY+cVPqVKx9UW8CtbW2z+iZ1fhaVf++A+/gFlG+qvXHXcZZpcC3Gum3NKLkIy3m2xjmK2MRdJqzlYUk43tQ66dZPJxPgKQ6wyYt2d7eHQZkW33yUSG9Qr8IVBLfORJf9c2RAdDsP6xC3A5s+5k2D/mM1Gcur6QuvX2RcVrrKN07Yl5WLn1+YrPG2+SpB3KMpFUH1+bnQmBA12YAWBHssLsSBQK+n7fPIZG8/xMOjUh50VRyccXc/89y5i8bu+U5ZEN/NFXkFiqDBjvZF4KWFtdBc7d+zme2ssN6WGDjCxHZWBiczURLgRZP4qMdNDqY1OFjkb4AQGOXP0utHCJaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s3Iudod1Yov6Fu0koWZ8vq7cE3y7ENAg8o8CGRUxzEA=; b=PZm31+PR+HWDec9JL4vzrzhPnODl6r22OX9XnCDrBAho+fE3EwHq72r8k4MMG8+ScZnI1khaak25rjNhY8Iq655XZx5gQGntVL3vjeQGfwIYqxHI0s52iLB/RIG/d9sH3G8hoCCucZkh8nUAyGfsfUQWW9097+XxpgoLiA/68qZAPieS4Ym/JhC2ZE80Rp1bkRc8L7QBbTEgtolbrwyVv7lQAZ7hwZiUciOm5lMG7aM+6HOmr4rUKWzCuy404BpuJK/IarTUtRgYUCk+HSe5tkLR+YrTPNt3JHqFfjN6f4Bvms9xiJ2Km+GMRXis99f0CFo9L+0raSeDCtExaaWb6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s3Iudod1Yov6Fu0koWZ8vq7cE3y7ENAg8o8CGRUxzEA=; b=Ytj0A/gYqb/gGEkn8nYtCDX5ifvjdqFcjNkHtrEYAzGXzKGwxMZWPXGYV+Duk693noN8GxWUFWn74WmOuHlc/Lq3JGlAUbKnwxyjdv5g19dC9dkWVtD/gYfDDk/PlRutVhPXl83x5uQU55u7Ivb/Ja5YqdzHDKT1P3Bnp9tNfVs= From: George Dunlap To: Stefano Garzarella CC: John Simpson , xen-devel , Anthony Perard , "qemu-devel@nongnu.org" Subject: Re: An error due to installation that require binutils package Thread-Topic: An error due to installation that require binutils package Thread-Index: AQHXI9X14mfwFU+FmkCbmbb49fg6DaqaymQAgACFsICAAS28AIABZNOA Date: Wed, 31 Mar 2021 10:03:55 +0000 Message-ID: <2BBB0D5A-87FA-49A7-AA75-08CB20078D49@citrix.com> References: <889B1827-1FEB-4AC0-9002-278337D19ED5@citrix.com> <20210330124646.jl4re5srmbzhkipm@steredhat> In-Reply-To: <20210330124646.jl4re5srmbzhkipm@steredhat> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2cd4a1b6-d456-46a1-0705-08d8f42c4b56 x-ms-traffictypediagnostic: PH0PR03MB5701: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g58+KGVfE5BSbh5JjZOSThokSCN0sh1CunP698BmuAmDkIwr3VFphc69/arK9h6qGWAoPlz/8IaiFsWjxYUrdnTJvlh3IQAs/ttnOv/BIZbxyvvhauFs24p/FS5yWgoj3VytmYuJXOQovhCxvggJ4/6A1ABpiAujH05ZqKViE2yLbSjCdztyPs+rCcFDVWIYMLueMVBXoTmNGv1/Dbap8/hxgT9OrYNr/iWCGKdH2z9WF7N6qQ0y4LywbBHiAFSvelJoE+MLzH+Do22q4FyX1CKVvClk9br2szljsNwh5G5fQ3U48UFh7BRTBoag7K8jEwpALl7rRP/LZa8H6npeT/iGWbYf6xsxkFRKt5CPCTTxHTkaVKKTTjcQ6GmcY9YxePe/+tUdl5Sq7hPWz6Ibfi5W1CpvyRwKXn7ltLydfjB0f2GFUCoRJgbx1bNCXxi2AL/wp4rcgcoxV1FIeX5f49Lh4lfeYNQhRPZA1L0RA3pgYtZF/7Zc/Kg9ZMjmUDZL8XeqVqhni7RjeAN3NlmLOwbSjMlCv2VB/MC2lVC7UuLw1p4sHXJfPUnTB1vFl1Fbzd86J2cgat48FwEm9m8g3JHRZQCOX/dpyUvneZTrHFYf4sDLpN6WlI+Xj+0nwRQVjaVg1sDXrdx1Ee4XcltbAB0axuegFXaoSe4dcSb2fimdaX7wMtSWnzwJeUWyiUQIExbzvgsd+F9dsZBc5Qqfdu0bwG+CIPze3RiuqThgXwkAvlcZ4C4BkxGJcS9YdrHKL8oXjYhZ/e5XrOMwfKsafA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(39860400002)(136003)(346002)(396003)(76116006)(66946007)(91956017)(66446008)(66476007)(64756008)(66556008)(54906003)(86362001)(8676002)(316002)(8936002)(478600001)(6486002)(6916009)(6506007)(186003)(2906002)(5660300002)(966005)(33656002)(38100700001)(4744005)(6512007)(4326008)(36756003)(26005)(53546011)(2616005)(71200400001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?Y3dOb3BkU1k5ejZBTDVvcXVRVTlTdkh1OVo3RC9pcVJqVm83aVNxTmFtMDdp?= =?utf-8?B?MklpZVFLVVp4VGFSMEZPd0crNWZnSEVsbWlFVmcvc3hGVzJwYkhUTGdIV1dV?= =?utf-8?B?Y1pJYkhoT3JSbXBDaTJzZHpRUnh6bjAzUnJTT0psNlJlRENQVmZmZitTWE93?= =?utf-8?B?QTNFeDdCSFh2MXJuMjlYR3ErVXhaU1lORTV2dkNUbElJRE9BczZqVkluT0JS?= =?utf-8?B?R0R4b0xLUmhCb1k1RDBpOEpKS1ZJWW1LWFZYMlJVWXdkQURHbDFhcEpFOWR0?= =?utf-8?B?WUR5cnhnQ0xrWUJaSmVLRjl1TnByN2JWS3ZPNEV5V3JuM3V4dFZCRDBEQnFz?= =?utf-8?B?SjRsb1RpdUJuRXlqVGVaOFJIR2tHZERURHJZRUc4THF5S25jVmt5bjMrTEJN?= =?utf-8?B?czBpaHJpSVRINUV6ZDRHK1JXN2tqMEFXcVdaWjZNbTFCU2pKQmw5YnZ2Rkhu?= =?utf-8?B?QWlzOHkzdHRGSEMzWVNvRjhpclJaM2N6VjhXemd6VmxjTDRZS2hvZUxQZVRM?= =?utf-8?B?VjlSMkNBT1RWNG9XV3JKZS9yYjJUMjBxdk5uWTkydlltUUQxL1oxT01LZUdC?= =?utf-8?B?dStFZXBQVDhKOGVsNUZGS1kycm9ydENrOGFRR2hqaiszQ3hnQXhJT29RNTBu?= =?utf-8?B?eld2N2JQbi9qdm14OW1ZdndyUmVnUUNjNWRGeGJjejVuQjFYOG1xU1hJU1dV?= =?utf-8?B?Z3RBaGZxMUVlUm5LVkNhU04ySzVPOVVzVCtnOXB0bWg1bVJ5NUpZMmVhZHBR?= =?utf-8?B?M3RpNG1nMnNXVlVsaVNpYUdBRHdWQVllQmdqdlU1dlVhL053alphcyt3QVVP?= =?utf-8?B?NXJEaUlLWVJHVHpmMFd6ekI3czhsVHROMEZTZ1hBb09VbU9pVkZIZktaVmVS?= =?utf-8?B?SmJZeHRiYWthVkkrSHlNampJN3VNMmkwbWRwVmRiY2ltSTkrQ0FPbGVyUnBC?= =?utf-8?B?Qm1ZZzYwK3NvaVJiWkhiVEp0NmFxTDRhMDhsL0JVOFpReDlCTWp5YU5paDZu?= =?utf-8?B?QzZrT0VnWEllalRlTS8yMmR4VnpLWjdjMEN1aFV4R0EzeVhMaG9LYlBRZnl5?= =?utf-8?B?MmRYNEFaSFY1MGo1WFc3Q01PNVlqbDU5bHlmUTNFMHJGMzNwWFpTVzArMUc2?= =?utf-8?B?dXFjZlBGRVFlbWQ4V2hkMFdXb0ZWSFAzWTdvaWdIaSt2WHdSeE85TE5jUzVJ?= =?utf-8?B?ZFJmV0h1WitLYXRUV1poWmsvSytFZEw5cDhDSmQvVGhyRTJjTzhvOFdNU3lL?= =?utf-8?B?MFhLWUZRM1dVZGVqbXNjN29IMnNBaERFRm50a2k3M2s0blNNd1lBeFJrRDNM?= =?utf-8?B?WEN1RXV6RFA5cXJtdTd6dVRkc2paN0dleldPWFdTZUdoNWhxSUdKZC9Tdmtu?= =?utf-8?B?cWkrTFBJUDUwdHZFS1ZYYlpLSnBPNGZvaGVjakx4WUVtVUR4Y1VMdm1Cd2hX?= =?utf-8?B?U1pnSFg3eStFd2JlZVlCckVpazlaMWVzNEkvc2EzZkU0KzFxY2xwaE9UeE0y?= =?utf-8?B?RlpqWkY2S2ovM3dJL1BrVk1wQUNLSUpRUFhBeXhCQ0RIeGdFdUJQZGQ5aisy?= =?utf-8?B?UWVSZUFjTzlNTExjanc4NWJ6amszaE85N1ZYUGZrbjZhMUJIR2l2N1l5ZHkv?= =?utf-8?B?UXNONklpLy9pbkpYU3RiVVloL0xPQW4rM3c2RU1TUHdyUjlJM3FZMDg4dk9C?= =?utf-8?B?dE55WmczSDBnWTV2YXBkRlMxUEM2ak82bVBCWmp6aGZPWWkzZ3R6REZOVnpL?= =?utf-8?B?eVUxRFBTd0w4U0FST2s1SUo4dlVHTS9idWRab0xFRE4rUkJNZ2NrcTlzZUhL?= =?utf-8?B?ZUM1aGxXNDk1Y05zaGFMUT09?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2cd4a1b6-d456-46a1-0705-08d8f42c4b56 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2021 10:03:55.0671 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MzihS9mK0YNAoT+MaOTg5y+4OzXG65eAtvNjfvezG+0qe+fyxZLVxmeyG9Isz1iBhAoqo1vhjcq5RbaRmvasMsR2nkOiGX9RPeQjY7QAzP8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5701 X-OriginatorOrg: citrix.com W0Ryb3BwaW5nIHNvbWUgaXJyZWxldmFudCBjY+KAmXNdDQoNCj4gT24gTWFyIDMwLCAyMDIxLCBh dCAxOjQ2IFBNLCBTdGVmYW5vIEdhcnphcmVsbGEgPHNnYXJ6YXJlQHJlZGhhdC5jb20+IHdyb3Rl Og0KPiANCj4gSGkgSm9obiwNCj4gDQo+IE9uIE1vbiwgTWFyIDI5LCAyMDIxIGF0IDA5OjQ2OjQ5 UE0gKzAzMDAsIEpvaG4gU2ltcHNvbiB3cm90ZToNCj4+IEhlbGxvLA0KPj4gDQo+PiBLaW5kbHkg YXNrIHlvdSB0byBoYXZlIGEgbG9vayBhdCB0aGlzIGJ1Zy4NCj4+IFRoYW5rIHlvdSBmb3IgeW91 ciByZXBsaWVzLg0KPiANCj4gSXQncyBhbHJlYWR5IGZpeGVkIGluIFFFTVUgdXBzdHJlYW0gYW5k IHRoZSBmaXggd2lsbCBiZSByZWxlYXNlZCB3aXRoIHRoZSA2LjAgdmVyc2lvbiBuZXh0IG1vbnRo ICh0aGUgcmMwIGlzIGFscmVhZHkgYXZhaWxhYmxlKToNCj4gaHR0cHM6Ly9naXRsYWIuY29tL3Fl bXUtcHJvamVjdC9xZW11Ly0vY29tbWl0L2JiZDJkNWE4MTIwNzcxZWM1OWI4NmE4MGExZjUxODg0 ZTBhMjZlNTMNCj4gDQo+IEkgZ3Vlc3MgeGVuLTQuMTQuMSBpcyB1c2luZyBhbiBvbGRlciB2ZXJz aW9uLCBzbyBpZiB5b3Ugd2FudCB5b3UgY2FuIGJhY2twb3J0IHRoYXQgcGF0Y2ggaW4geW91ciB2 ZXJzaW9uLCB0aGUgY2hhbmdlIHNob3VsZCBiZSBzaW1wbGUuDQoNCkFudGhvbnksDQoNCklzIHRo aXMgdGhlIGtpbmQgb2YgdGhpbmcgd2UgY291bGQgLyBzaG91bGQgY2hlcnJ5LXBpY2sgb250byBv dXIgcWVtdS11cHN0cmVhbSBicmFuY2hlcyAoYm90aCA0LjE0IGFuZCA0LjE1KT8NCg0KIC1HZW9y Z2UNCg0K From xen-devel-bounces@lists.xenproject.org Wed Mar 31 10:24:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 10:24:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103825.197992 (Exim 4.92) (envelope-from ) id 1lRY1L-0003ZF-BN; Wed, 31 Mar 2021 10:24:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103825.197992; Wed, 31 Mar 2021 10:24:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRY1L-0003Z8-7x; Wed, 31 Mar 2021 10:24:19 +0000 Received: by outflank-mailman (input) for mailman id 103825; Wed, 31 Mar 2021 10:24:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRY1J-0003Z0-UE; Wed, 31 Mar 2021 10:24:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRY1J-0000BN-ND; Wed, 31 Mar 2021 10:24:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRY1J-0001Kt-Fs; Wed, 31 Mar 2021 10:24:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRY1J-0006tl-FC; Wed, 31 Mar 2021 10:24:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9i9emVrm3EpzXVXK2sU3ooCTUKwUuNjWQUGfLJ41bg4=; b=tDaZ7s3ckOIZtl1Jdgo9JyLZqP XI3bbgvn62d/WvGxbfvUuKGwzYNg+binyAQUtVIpFkRsFEYiYtrVuWP6IlT647nz+zCH5O6e9c4FK RB5Uan6IDW7/0Ge/xOo22UnCgHGj16ITs6gu1yV0iWXeD7LV2fFbFsMRtin0FaATMyBw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 160582: all pass - PUSHED X-Osstest-Versions-This: xen=90629587e16e2efdb61da77f25c25fba3c4a5fd7 X-Osstest-Versions-That: xen=e680cc48b7184d3489873d6776f84ba1fc238ced From: osstest service owner Date: Wed, 31 Mar 2021 10:24:17 +0000 flight 160582 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/160582/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 90629587e16e2efdb61da77f25c25fba3c4a5fd7 baseline version: xen e680cc48b7184d3489873d6776f84ba1fc238ced Last test of basis 160495 2021-03-28 09:19:58 Z 3 days Testing same since 160582 2021-03-31 09:18:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Marek Marczykowski-Górecki Roger Pau Monné Wei Liu jobs: coverity-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e680cc48b7..90629587e1 90629587e16e2efdb61da77f25c25fba3c4a5fd7 -> coverity-tested/smoke From xen-devel-bounces@lists.xenproject.org Wed Mar 31 10:35:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 10:35:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103829.198007 (Exim 4.92) (envelope-from ) id 1lRYCN-0004Xm-9P; Wed, 31 Mar 2021 10:35:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103829.198007; Wed, 31 Mar 2021 10:35:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYCN-0004Xf-6J; Wed, 31 Mar 2021 10:35:43 +0000 Received: by outflank-mailman (input) for mailman id 103829; Wed, 31 Mar 2021 10:35:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYCL-0004XZ-BR for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 10:35:41 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8b5e75a1-b357-4113-91e5-f4aa7e3306d6; Wed, 31 Mar 2021 10:35:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b5e75a1-b357-4113-91e5-f4aa7e3306d6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617186940; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=lXblGJuTWXkI6+BzR09qzE74qpS68r0DGSrFHambnJc=; b=aIfBtvwGeD1Req2y3jjdAcDSw4w5hDRZELcot/K8SYKYz0NWg+S9b4uj Ocdm0x/qMPBuZnMtHmFIC/apxyAAMVnc0kwEoI06xOp2C3kmtZGS9Uxvf MvLRBk0MXto+gJUM6Lm0PgW6liOEKWgbfTp806vZ/Mhes7xUucyF6KoYl A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: NbvWk5CaU+ZTzThIwBlND9TovZdaEiHDNfJRP/OM6osZi0ynmbZ2YjvQk7L6MqhQx9MNWtvTlw pxoagTdwNdtnzNeGVeJ8VCC0DT4o5KmG8BxirZDAsIzrFSfoyt5MY82YPlpmM3COdWXoL+t+5Y 3si7uh/8DeOp7ykzsAfEE9QKvxQG3YfJcoOtVDeppbMyEJhBWaklVYdPsKwKtIjq93xNrBpcqw oe0zk30p6SAq5J3fccjFf5EEd4mR1jTtINkpsmqk2pkHDl+iBd6JU1GeO+/ykhsuDNDmy+IZZR u7E= X-SBRS: 5.2 X-MesageID: 40415641 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:NtJ0oaFWq0EWyM6TpLqFMpHXdLJzesId70hD6mlYVQFVfsuEl8 qngfQc0lvOhCwMXWw78OrsBICrR3TA+ZlppbQAJLvKZniChEKEDqFHqbHjzTrpBjHk+odmv5 tIXqBiBLTLYmRSot395GCDfeoI5Pmi3OSWifzFz3FrJDsaCZ1IywtiEA6UHglXaWB9ZaYRL5 aX6spZqzfIQx1+AviTPXUZQ/PF4+TCiZOOW3U7LiQ64wqDhy7A0s+YLzGk2H4lMg9n8PMZ3k Xu1yf44aiitP/T8G6n60bjq654tfGk5t9KBMmngtUYJDP2mm+TFflccozHhh8ZiqWC70srjc ntrn4bTrhOwkKURE6Zi1/M3BTtyzkn4XOK8y7mvVLT5fbXaRh/Lugpv/M8TjLpr3AOkfs57Y dwm0WejJZTBQOoplWE2/H4EytEu2DxnWAvioco/htieLpbUpB9h6oF8nhYFZ8RdRiKk7wPIa 1VAMbQ6O0+SyL9U1np+m1mwNmbVn8uBBuxQk8bpsyP0zRN9UoJtncl+A== X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40415641" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S3xwStePB3EOcI+Ob3u5/H0pd7o2fee7nqKiC/XU8syvXuK6dD5brIPPly3f2++n9p+J9bCA+X0YzeI50QE8IFzT1/93n+bL3CrwqMG/KRkyAgdChP76dNyJZ6il8QCgwXB4Kk4JaPcL1XZquurQ5KU6GpmYdfx61qTN+wvohFxuGxeGPJO5v2kS1Uc1yDBQ2LJ1ik865sZXx5FAMpJEVNy0DMo1pa7UjS7i24M06eHLNrGm8pTXgtArRVLmVH0v8ZdLEw3+/wOA+lF4Ml9UuWVJBlovCkRAcqJHcr1dCw5wuTScRj56G5GPlGFQLVhC66dNAV4GE/J68Tcbc1SwQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k5uDutd4OrUzZF9dpiK3BecJLbNCTSNgtYFMzSQYNMk=; b=fn1w84bu9urHhZPeRT/7Z+OhoB7kUz4AEXF/MCr3B+S7QUglCo8Md8xMEmlzbfNS6lytwhdMsHqTXIaz/z88LD9W4sIXB0MXvAMy2/9WDVJ3n0W7MXcD7WCYieN0X3mKXoSnKKioM7XCt/eP0OnPW/xh8YEMY+/7BstvAA4XCQoczUU65qymuitoG74wknN0Tccp8nSdgb4/h+aLHplHHAySBMUDnCEOMYljMQAy9o30FBPyLD1qE0UAb1Y2487TksBH4dwuClX8WLvOoOFU9wFFPMTytNG/A76EI5A5kpEbv6hj9ZJlkbbkYBcGteHVld8NHt0PO7P1Nadet3Csow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k5uDutd4OrUzZF9dpiK3BecJLbNCTSNgtYFMzSQYNMk=; b=YgSqCHGhCtI5g4I67Y83LyA47HV8r/FvwQAMB36KCemNwN3qHaXj9YIbjQqKLOQ3pQYLjmjCrHe0wMDXTQvUFfYl9miN3GL9B+cG3fE/hkbUv4StLTozDeOprEDZ3leHlir8GUqOPE8QfzH2z33NNaVVSo3TJG2ad3p/w+WFSUI= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , Paul Durrant , Jun Nakajima , Kevin Tian Subject: [PATCH v3 00/11] x86/intr: introduce EOI callbacks and fix vPT Date: Wed, 31 Mar 2021 12:32:52 +0200 Message-ID: <20210331103303.79705-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0089.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::29) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 524e110e-4121-407f-dd59-08d8f430b83f X-MS-TrafficTypeDiagnostic: DM5PR03MB2777: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wjwNH9xCrrZJnCYbGU3HPWlLBn/HzHGLXPY2sqmoVzo1D32w+CE+GeAY7w84HNNmZg3cW1IJmlKKlhAQXgeXNyNP9YyztfpS8I5QtFDhub+pSZG1KgrXE89pv55SL8ZTssnlPi/QHIhC36ckUyuG/6zFQfhHDtIo8uE1XQBJsuFoX29IUMIHZCfW3arqs9VWaPSSqZxdumIMBi1vMurrr/8FemdbQDs5lB2DQk3kB1a6GQQUbw4eoBK/8qPFziSCB5Wv7dttk65MtOEqdIQ6lEwI5fyNKXIKsJVDbFIYZoRKWMVMbVcjXxBcppytJVRsbuDMwdJwlYGfCsMOD3dN7sfIgmDkIsyO6ZkOss961R6tAioyGoqXI5DSAI2EpDVMf1UKdTeDJT+S3zq6UtUlrRFWku4dRWQ9m+IeJOLijo18AbNOJG7XVxB12kgm4EVAXoAfJkwbAaF1QUhSPmzCGExJLLmb+m3W2JP98vYIgqDSAcckUdihjb7QXiPsBV6FWmr+cp3MTw3wmMC5z+mEPBvcWxcS5iGdiYWfYXUddSAyC4Pz3hMeXns8fbqe2eG3v+8EsQ7rZkAKFKNCLFn0Ly31lw+xaqfP6DTs3YYKLgLm1tY8i008kwO8V9nlJ/fHxMHsCgxE7HOLDmymCMOhaA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(346002)(366004)(39860400002)(376002)(5660300002)(186003)(66476007)(16526019)(26005)(6486002)(8676002)(36756003)(86362001)(83380400001)(38100700001)(8936002)(956004)(54906003)(1076003)(6916009)(2906002)(4326008)(316002)(2616005)(66946007)(6666004)(66556008)(478600001)(6496006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VVBNZUJQSVJWQU5mTFlaNmoxblMzS2Q4ano0K3JsSVc0MllBaHBZOFdiaFRm?= =?utf-8?B?V3R4NkVVeTQzZ2FuVXRUbjNQcE1FOTBaL2ZQNnFaZDc4ZnI0Y2l0eUphYkVk?= =?utf-8?B?VjZIVFRYTEROOE5tSXcvTGo3NjJSL3lQbVFWZ2lCczJHc2o5WnRaRm1FRDZM?= =?utf-8?B?MWVRUDJsazNDdEdhNXRMbWI2MGM5R3BaUEhsTjJQcHpkQTNPaEhDNWcwaTc2?= =?utf-8?B?MEZvOXNnbGRQc0VpaE1vQ21Qd0h1NkRpWitLbHlkUnpra0E1WExleFBVT2s0?= =?utf-8?B?eXNyb0VNcUJtVGgwaFdWWmU2RTYzTEhlWjgrenVvZFRNVFdmYmxXbzlocWF2?= =?utf-8?B?NExtVjZIb1AyNElzN1FORTg4MEdPRkt4T2FYTDl4YlZ2SG5Ba3BMSlk2UktU?= =?utf-8?B?RUZDWXhmWUUzSHdiMFJ3dEFvWUdweDZ0ZEJsYTEyeTdwR3p0SVAvVjZOUjF3?= =?utf-8?B?bVFQa1FpTUxkNXlCbjFSVHZOTldDTnhXd241emE3NGMvYTRYS0Y4ZUJZNER2?= =?utf-8?B?Nk02dWlDTHFNdFpaRmIxenM0elc4SVhRM2FoMDJXdXh4WmFxL0N5RkRaR1ZO?= =?utf-8?B?YU5jTlJxV1ZoWDk0aHlMLzFzbUFzaFg3aXlkYjhkdFNEL2RUY1Z2a0FmNUhP?= =?utf-8?B?YklyU0dyRE14bUtCemNEMGQvRWtEMzF3TWJhYTU2Q0xYdlR5bmZyRXVSNFE4?= =?utf-8?B?Y1VCOXJUSGduNHdYVm12cGxNQ21hWCszQ1NkelNmR2lHRUlGNzcxUHRlNWRl?= =?utf-8?B?dEx0QlZwZWJ4RGZOaTkzUFRENWE5MkVWM3d2bHQ4a3ErckxqVWhzSzA1c242?= =?utf-8?B?NW50UmhKOWxsdzhJVzJ2T3Nsa3R2S2pOYzhHZTJDSmVHN2dqWDEzMDBpeUN1?= =?utf-8?B?UUtEWVlScFNXdW1nUXJHOWZKUy9US04zSWtVaEw3V1NUZDNicEcrVmhnU3J0?= =?utf-8?B?RkVMb3JiYTBUaXhwMnZHaXZqMm9iYjVQTWpVRkprMFBGbGZnM1cwMzFVSElY?= =?utf-8?B?K0NDbWswRmx4MnJmZjUwMHQ5YXJNaXZaTkh2SnEydEsyV2NWTll2aEZCcWFm?= =?utf-8?B?Qml1bGdPc2kzblFCeXJpelhWdkN4U2JxYUV5VXRDT2JGTUtVSVBHUTNORHJO?= =?utf-8?B?WmFQYzRXeFArM1pIdnlaalRVdlorUGlBUFV1SDFLYUsyWGVuUXVCU2lFaU43?= =?utf-8?B?OFFUd0JzMXM2WnVBODFRSUNsaFhCck1zcG1wWUZ5THdxcENrUGhIS2FvYTQ2?= =?utf-8?B?WjlGU2FMTUY0REN5aXlIRHAxcU5kU3BkR0JxTVJ5UnBvQ2J5SEtmUlpPcjJY?= =?utf-8?B?NllRZmN3cExYT1FzRS9HV0xva1R0Y1lzSklZQXlucExoL2tjdm9iTGVuVDNV?= =?utf-8?B?N2djRjJXdHc4c1hLRy9yVmRXMWhhUHg3L3hwOSt1SDRBK1hyaHR4aW93MEZl?= =?utf-8?B?WFQxL01iVENWR20rYWkza1VFZGZWZEtEQi9pcnFGZklacGlSZVcvcGkwOGRL?= =?utf-8?B?eWhrQndZRjY0WXhJWVBtY0JYdEttT0F3R1BkV2k5VFZrN05Xb0ZBUHFxNjNH?= =?utf-8?B?QXArUmQvWUVwU1ZLcU1pWmYwd2NuKzVUWHB2RDBYR1BHemlTRFE2VmJxT1li?= =?utf-8?B?cy9LUlQvVXJyVkdNanMvQkNTMGpjK2JpNzkyNGtEc2M5QTIvSWlEZTRwRFk4?= =?utf-8?B?ZmJla1V4ZWlrUmlZZ21YajdOV0tRTDJLY3VTYXFsM1JPYVova3VWRmZvU0cr?= =?utf-8?Q?d2vituBZ/oMRPz/lpHrPpOiJmymYRq42rtUM9h5?= X-MS-Exchange-CrossTenant-Network-Message-Id: 524e110e-4121-407f-dd59-08d8f430b83f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 10:35:36.0860 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +xrAnvZDTI2EZqncl1vLzRgVfjnMzRpnJGaHRD6M+qrpGOJlyaiqVbq+zOI8Ok3freC/CwE3XdYanXdSCX045g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2777 X-OriginatorOrg: citrix.com Hello, The following series introduces EOI callbacks and switches a number of subsystems to use them. The first one is vmsi and dpci, which are quite straight forward to switch since they used to open code hooks in the EOI handlers. Finally HVM virtual timers are also switched to a different model where EOI callbacks are used instead of checking at every return to guest whether a timer interrupt is being injected. Note that such change also fixes a bug in virtual periodic timers that prevented injecting to a vCPU different than the one where the timer is assigned (and that would currently match the i8259 target). Those changes are paired together so that practical applications of having EOI callbacks can be seen in action. Note that further cleanup can be done, but I think the series is already big enough and provides a clear benefit. A couple of notes from the testing performed: - PVH dom0. - Windows guest, limited to 2% capacity to test delay for missed ticks mode - time is consistent in the guest. - Windows guest migration. - PCI passthrough to a guest. Thanks, Roger. Roger Pau Monne (11): x86/hvm: drop vcpu parameter from vlapic EOI callbacks x86/hvm: drop domain parameter from vioapic/vpic EOI callbacks x86/vlapic: introduce an EOI callback mechanism x86/vmsi: use the newly introduced EOI callbacks x86/vioapic: switch to use the EOI callback mechanism x86/hvm: allowing registering EOI callbacks for GSIs x86/dpci: move code x86/dpci: switch to use a GSI EOI callback x86/vpt: switch interrupt injection model x86/vpt: remove vPT timers per-vCPU lists x86/vpt: introduce a per-vPT lock xen/arch/x86/domain.c | 4 +- xen/arch/x86/emul-i8254.c | 1 + xen/arch/x86/hvm/hpet.c | 8 +- xen/arch/x86/hvm/hvm.c | 23 +- xen/arch/x86/hvm/irq.c | 63 ++++ xen/arch/x86/hvm/rtc.c | 1 + xen/arch/x86/hvm/svm/intr.c | 3 - xen/arch/x86/hvm/vioapic.c | 149 ++++++---- xen/arch/x86/hvm/vlapic.c | 74 ++++- xen/arch/x86/hvm/vmsi.c | 35 ++- xen/arch/x86/hvm/vmx/intr.c | 59 ---- xen/arch/x86/hvm/vpic.c | 9 +- xen/arch/x86/hvm/vpt.c | 476 +++++++++--------------------- xen/drivers/passthrough/x86/hvm.c | 219 ++++++++------ xen/include/asm-x86/hvm/io.h | 3 +- xen/include/asm-x86/hvm/irq.h | 21 ++ xen/include/asm-x86/hvm/vcpu.h | 4 - xen/include/asm-x86/hvm/vioapic.h | 2 +- xen/include/asm-x86/hvm/vlapic.h | 18 +- xen/include/asm-x86/hvm/vpt.h | 26 +- 20 files changed, 601 insertions(+), 597 deletions(-) -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 31 10:35:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 10:35:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103830.198019 (Exim 4.92) (envelope-from ) id 1lRYCT-0004aB-J0; Wed, 31 Mar 2021 10:35:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103830.198019; Wed, 31 Mar 2021 10:35:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYCT-0004a4-FC; Wed, 31 Mar 2021 10:35:49 +0000 Received: by outflank-mailman (input) for mailman id 103830; Wed, 31 Mar 2021 10:35:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYCS-0004Zp-Fk for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 10:35:48 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2418dee0-b4d0-4766-a8d0-54044651bb31; Wed, 31 Mar 2021 10:35:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2418dee0-b4d0-4766-a8d0-54044651bb31 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617186946; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=pf+3mEgT/PwOonbrF+sYgx8kqAd51PG7gUiL4p8/xD4=; b=ZLOLXRnifKA7JPdELVN2dF38absTHnxAzzELNl8eMzbG7k84LZPxM37r t4tWzJpaG2tNR1qOt8JSyf3ZOO8u04RdFZ6uWE2tJFUoSHmMDUWK+AWpb cUmbGlkevg1nJ+UGtW0tot9Pbt3xH0zwVlHNTIWKaU9B6Y856XyC+mcuj U=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: FoHfbWWLulHxf0Oq02Rw5muDVV+bOEFRDshmpU6vAEFD9RPgUsW3okBrFLBCxJd2a+RAxD/SjN BciA09C4zjPkgLML03ZlmDTs/3puAx2bgexSiwzYh7gLVZ8J5S/9fQQEWNqE2l9GzK0xBX6tnq Qd5H/JFA6YwRm401DQcp43YB+4wBGP8UkF0/S3hTj2x2CO3l3PzLzq1R5cPEmcNt2IBO2KiBps A8KIw5yW6hat/nfl2NFa2JwWIngtTXxQHgAVh81ZgMmkY19OiQvQVzugSAfYlby91mOwjsMVuM Dkc= X-SBRS: 5.2 X-MesageID: 40917024 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:NUQrAKkXsmP9nFPxnJ80pOPqYIrpDfOpj2dD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLN/AZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 tdWoBEIpnLAVB+5PyW3CCRD8sgzN6b8KqhmOfZyDNXQRt3brx7hj0ZNi+wOCRNNW17LLA+E4 eR4dcCmiGpfm4ZYt/+Kn4OWeXCoNOjruObXTctARk75A6SyQ658bKSKWnk4j4ycRNqhY0j/2 /MjhDj6syY3c2T5xfA2wbonvJrsfT7zN8rPr3vtuE0LXHWhh+sdMBdXdS5zUsIicWOzHpvr9 XWuRcnOK1ImgPsV0W4uwHk1QWl8BtG0Q6a9XaijXHuodP0SVsBYqIr7+IpEWqq12MasN5xy6 5N1W6C3qAndy/opyjh+8POEyhji0vcmwtSrccok3ddXYECAYUhyrA3wUU9KuZkIAvKrKojEO VoEfjG4udXfV6wfxnizxdS6e3pcXIpEhicRE8e/uSTzjhNhXh8i3AV3coFgx47hd4AYqgBw9 6BHrVjlblIQMNTRaVhBN0ZSc/yLmDWWxrDPE+bPFyPLtBJB1v977rMpJkl7uCjf5IFiLEono 7abV9evWkuP2rzFMynxvRwg1DwaVT4eQ6o5tBV5pB/tLG5bqHsKze/RFcnlNbli+kDA/fcR+ 24NPttcr7eBFqrPbwM8xz1WpFUJ3VbetYSoMwHV1WHpd+OBZbtssDdbfbPNJvgGTspQQrEcz k+dQm2AP8FwlGgW3f+jhSUcWjqYFbD8ZV5F7Wf3+V78vlJCqR89iwuzXip7MCCLjNP9oYsel FlHb/hmqSn4U2//WPC6XRVKgNQZ3wlpInIYjdvn0snIkn0ebEMt5G0YmZJxkaKIRd5UofwHB NAoU90vYa6NYaZyyxnK9/PCBPVs1Ij4FaxC7sMkKyK4snoPrkiCIw9ZaB3HQLXUzpvmQhrr2 9HQBQeRlDWEw7vjanNtu1WOMjvM/1HxCu7K89drnzS8W+Go9s0e3cdVzmyFfKMjR0WXDpSjF 1p+6o5iL6N8AzfblcXsaAdChlheW6XCLVJAECgaJ9Pkr7mQg12UFyHnCeXkR01Z2rs+XgDn2 CJF1zmRdj7Rn5m/lxI2Kfj9115Ml+QeE99cVhWm4xwH2augAc57ca7Io6Il0eBYFoLxe8QdA zfaTwJOwV02pSczxiOgguPEn0g27QjNuHQF64YbrnWw3+hQbf4050uLrtxxtJIJdruuugEXa ajYAeTNir/EP5s9AqPpHopURME3kUMoLfN4lnC42e51nJkXqaXD1RiWr0BI9aTq0LjXO2F1Z 1ljdQz+cu8W1+BHuKu+OXyVXpkLBiWnEudC8cPgrpQtbgptLRyE4LAOAG4nE1v7VEbFoPMiE gaQK5H+7jPNY9kQtwKd0tijy8UveXKCHFujxf/DeA/d2w8lnP3P9uG5LzTtLoka3fx0zfYCB 26+y1Z8+ytZVr66ZcqT4YxK39Rck4y9TBL+/6DbZTZDGyRBqt+1Wv/Fn+2a7lGTqeZXZ0Wsx Zh+tmN28uabTDx1gyVnTx1JMt1giuaaPL3JAKHAuhT9dOmfXyKn6ux+ca2yA7NdgHTUTVQua R1MWoKbspCjTE+jIo4lgiKI5aH3X4Noh95+jFollnkx468xnzUdHs2aDHkvg== X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40917024" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e0WYdTfPrUqQQgvjF2Y0GCWlRNAggH+rn1cDBTk1aiyq2ZNNLQr5qN4hXHFGu1rQAPGEKy8ek5kVMKRI6yjrX7GkRPloJ0cOxMBScQVl0cVjqUrC+xbOz9tRZcxwp49EaHnLzrXp51szi9pgHvq+FksG0FIbXMo69qlUF0LZEr185awBxmFy/yUX+iUIE2YmMsUOlR7I3Krlym+9eg92HeELkXpQ/W+ZyfJbUZEiikjDqe6rybHK8GyUPQj8NJhzGGkf/5mtmyph6KUIjhlMDYK8CAoaEc0zTZr/kOFbNRpGZ3vwF6y/y7EqYW7Ghr5f4pA9GH+cO/0RsqjQ+3Vg+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1YChfSP81aZL13zYGZ4iZHk38+vOOoVLtwqftK78jk0=; b=cEsz4QVvY7FbTFGKmBRO3P+UpYszub5lM0FRXIJu4AFWRtLNeKrQCxOfhcX0r7E4bTpsVXCpST2KWYdu9fgHcIC1NfAMVuvh7SnV9sFrhiTsJHlU5ioStsc6tmxsrjR0XMP2xB96fwHdJYR1MjJLi8Jbt4mtAvfWCUE9+SxG4uZKUIVanvTYWbFuUK/WzJN+VnS1st+yUx3XDnkCraQYak36pn2mq7bRvWDuf2uFqg2/4f5YpaJx07Wad9gZyL3Br1Q7AHjsa/y2kucFW3Li9n3CzJMabA8u1sG2mUtn5utgW7auh4T1FqgkqZqpWwfSuNfvGz8h9CactiYTvasGkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1YChfSP81aZL13zYGZ4iZHk38+vOOoVLtwqftK78jk0=; b=Zz2EHG63xBds9faORxvM9t/E3L6RGWPR+JbAOegEcOos+DkpeTD7W/1Dvxwb0wXZkAAtIPhRsBwSX+T72n39ECzE1azpWCgoqddWjLaCPGWW7t1Na1tQ2cGFIeZps+7LsT0RupMnJC4r4gztPQ5cNORmYGQ3/dT4qXoI7WrYLdk= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , Paul Durrant , Paul Durrant Subject: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks Date: Wed, 31 Mar 2021 12:32:53 +0200 Message-ID: <20210331103303.79705-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210331103303.79705-1-roger.pau@citrix.com> References: <20210331103303.79705-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0062.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:31::26) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f474ce6b-e0e3-49c4-11af-08d8f430bb93 X-MS-TrafficTypeDiagnostic: DM5PR03MB2777: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mrIrlP88Q5KVKbY5AqredBbO1GPLqqAipp+QLGZnqOEx0rRoW83PZsUT50OdyLISod9eyRxY0jnLkSMotzFt8j+Hb9kFMqLHupRyJVOk5FlRLfN1VJAIyZzq53Lr5OKGm5Iko3vVBUKfg/VnZcrLkQlr7sex6qEl+Zw2si0bO9mu48B2B06/cLTkszvBQBQD1x7mHFjyGZK9RqC9BnTV72Rw/CHHlLNY7AQGfhRQMOH0dRfsYUwqkxLctDNzwhRfW8tXcVafVtvL2hlGK9YNoGyNumrtjPWnq8mQgB4134qazIQXst82NmkyDmG600QCeAQ7jKHolnBymlHMVzoeYCQ7K/ilSjo8feOKXhWFtpL+OX96DmsvtGqkEcw+gNPRdVjuWLG54OMz+MSBr9JbSAv5zygoqJ8qhBU2vh9jKMIn6e5oz5NzGbJZUGV4jla21wohq6n5vSiFfrMtCWYcveXdh2bkSvAi538ef6fNRQ+cadh4rad4u0IEdswYIYGE/34zQj+1N3Qa8LHxuB/4GRS7iC1rdSNBKFbcW8yX7Q9le/ppF/Ezm8vYIVh3Cg0tCfMoKt5p+ucmwezc3RUQR+3DwLKnU094FXU8mwSXUekYirJjpDbfgFENYyPnfVRMqVmYOyGvnAOSqxH7DLOyeaOTqp+jnaJYgTyuJFvcrEY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(346002)(366004)(39860400002)(376002)(5660300002)(186003)(66476007)(16526019)(26005)(6486002)(8676002)(36756003)(86362001)(83380400001)(38100700001)(8936002)(956004)(54906003)(1076003)(6916009)(2906002)(4326008)(316002)(2616005)(66946007)(6666004)(66556008)(478600001)(6496006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NVp0eERwQUt6VHFUdnA4QXFaNUI1Z0hHTXNMQkxrdXErakZoU3FFM3AzNWtD?= =?utf-8?B?cFlHYWVmRWRYRTZKOTA5bDNnVGpZMW90V2hyMUpzRzVGcUFLdktZaFhoR1Ay?= =?utf-8?B?QkFUc05HeERnY3NranlYT0hPbmFqVnpVcFZhbk5hNG1TY1lkWjdjQ0wya1Ev?= =?utf-8?B?K05QVUl4SFRCQmh4eVAxQlFPNlJNU2FRMXhyaVBuK0Q5bXNNbGNKbnFXY3l0?= =?utf-8?B?OU5XQmpJcUhUVlppd3lEMWsxN3Z4ZC9Lc0dENVVYRGl0OVFEQTRoOVlnN2d5?= =?utf-8?B?d3FvdXBrOG9EN244N1d3TEplTDM5cnNTbldwUW0rZGc1WmlFVEtLNlpTZnRP?= =?utf-8?B?MWd4ZXhKa1NMNWZOYjJsR3d3TnFSdlNzVWlKMkJrNG4vVlVka3d0ZE9Obk9P?= =?utf-8?B?Zk4xMXlkaE93bWhnOUJ6YWpCYnV6c0luT1RPUTV1d0NzUDR6ZGFTRzlrR29C?= =?utf-8?B?QTY2R0FKZWovR2NkZVhPV0tHTlAyUWJkZ2ZpZ1h6S2U2UmRMMEtHNitKR2h6?= =?utf-8?B?YU5xbUhSVjNBT3R2YlN4VU1LTWMrWmQ3NS80V29PZEY0cXJaWHBBT2pjRytS?= =?utf-8?B?WTVlWURLREpYLzczNnZjamJGTmdmUW5YYXQwUnd2aUwvcnFBV1JnaU85WWt6?= =?utf-8?B?d3IrTTR4QmlmekFMTVptRzNCcGNMcVBOUkpBaDdlcmR5WlhNMU5SZi9yczI1?= =?utf-8?B?UDBqZ2UxeDdYR3VNY3ovbGVodHRXL3dYUGtZVnZ1RVZoUkUxQnJSYldnWVJR?= =?utf-8?B?N3ZRQ012SFRIVm92dkFPSlZ3N0hOd0xqYi8yNnNjMmJNTWV5dCtocHQ4QzYx?= =?utf-8?B?Z1djWVNWQmF0UldubncyQkZQR0ZrSG9qTzdGV243R2ZpN096MFozeU5RNnA4?= =?utf-8?B?WlZmUnVaRGhoTnB6Qmt3djBaUFlRTWh2d3p3OVo4NnJ2aHNDNFk0MnFMV3lp?= =?utf-8?B?ZGM5M1pLRm54QlV3b3lCZXFmWTdnbHhyWWJyZkN4T2hHdmQ1YjQySVZyeHdH?= =?utf-8?B?cmxVUWRDTGFQMjI0bmtBei9XL1Z3ejd4WVkvOXFxZ3FEMlduU2RxNWhwQWcz?= =?utf-8?B?RmN4YVFLZnRJK2NpNDZueEVFTUp1aGFPTGdkMVBQN1did3d5dmY3dEd3VFlJ?= =?utf-8?B?MnAwUXk0dTFVSkRacElGU1lWTklsNlpIVERZL1g0SWUxb25LSjFEQi9pK1or?= =?utf-8?B?Z09UaWRYQnNzTmJiMjZ4NGthZlkzaEs3UW1xQ0MyRTBhM0VWbmFNMlVnckw0?= =?utf-8?B?OXh5QlZ3djBiakZRWHdwaUUvRnFoSWx4UlFycGo5Y0QydVlOTExQQXcva3pw?= =?utf-8?B?N2dsU3Z0ZXhpUW1MYmxiNzVmMk55QnlyNEpZZVl3Q21lNEtPRTUxT1daU3Bw?= =?utf-8?B?eGVaQmlMV2xVYTc4aVBEd0RkVk1PUUJUOU5hSnhIdGhibU13ejFLejZIbEpP?= =?utf-8?B?MnVvWmRjQWRKRGZGN29JMk0rR01GbWZLUzZ3MHk4S2xTT3ptZkV1cUF4TVF6?= =?utf-8?B?bzdMamhYTUFpdlpGSTFKaEE2QjN2dmRyUG42MkZlVVdrcHRZZmpsVTlobHJ3?= =?utf-8?B?bEd2UUFNTmZVVEhNbmc0bmsxdDBqbkJnNWRjU09xNmdSWTZWbTlEZ0UzVlht?= =?utf-8?B?ZkF2TVJxUkxKQnV1bkNmTUF3MTlBditkaFJDaitmTlV3VjNSbUJIbTJWZEFP?= =?utf-8?B?OTNqcFoyaC95ZE1teGZtVzhFNXhPUWM5Y3h5d0EvTFVkOUpnK3B1MnF0Zndm?= =?utf-8?Q?jiSWpvIVgTQYR5GfADQCnVoYWs+oOLdW8pwIUxQ?= X-MS-Exchange-CrossTenant-Network-Message-Id: f474ce6b-e0e3-49c4-11af-08d8f430bb93 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 10:35:41.6346 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2zJ+zYDOc4asnog8KPOMPIQFXVf6jIQ7JGLKEWexA1JRIPpVGTDMxAAjHMMqzl/jbBRtAifxzNbNtVsXshkfQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2777 X-OriginatorOrg: citrix.com EOIs are always executed in guest vCPU context, so there's no reason to pass a vCPU parameter around as can be fetched from current. While there make the vector parameter of both callbacks unsigned int. No functional change intended. Suggested-by: Paul Durrant Signed-off-by: Roger Pau Monné Reviewed-by: Paul Durrant --- Changes since v1: - New in this version. --- xen/arch/x86/hvm/vioapic.c | 5 +++-- xen/arch/x86/hvm/vlapic.c | 7 ++----- xen/drivers/passthrough/x86/hvm.c | 4 +++- xen/include/asm-x86/hvm/io.h | 2 +- xen/include/asm-x86/hvm/vioapic.h | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c index 87370dd4172..91e5f892787 100644 --- a/xen/arch/x86/hvm/vioapic.c +++ b/xen/arch/x86/hvm/vioapic.c @@ -372,7 +372,7 @@ static int vioapic_write( #if VIOAPIC_VERSION_ID >= 0x20 case VIOAPIC_REG_EOI: - vioapic_update_EOI(v->domain, val); + vioapic_update_EOI(val); break; #endif @@ -514,8 +514,9 @@ void vioapic_irq_positive_edge(struct domain *d, unsigned int irq) } } -void vioapic_update_EOI(struct domain *d, u8 vector) +void vioapic_update_EOI(unsigned int vector) { + struct domain *d = current->domain; struct hvm_irq *hvm_irq = hvm_domain_irq(d); union vioapic_redir_entry *ent; unsigned int i; diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index 5e21fb4937d..98e4ba67d79 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -459,13 +459,10 @@ void vlapic_EOI_set(struct vlapic *vlapic) void vlapic_handle_EOI(struct vlapic *vlapic, u8 vector) { - struct vcpu *v = vlapic_vcpu(vlapic); - struct domain *d = v->domain; - if ( vlapic_test_vector(vector, &vlapic->regs->data[APIC_TMR]) ) - vioapic_update_EOI(d, vector); + vioapic_update_EOI(vector); - hvm_dpci_msi_eoi(d, vector); + hvm_dpci_msi_eoi(vector); } static bool_t is_multicast_dest(struct vlapic *vlapic, unsigned int short_hand, diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c index 351daafdc9b..2f6c81b1e2c 100644 --- a/xen/drivers/passthrough/x86/hvm.c +++ b/xen/drivers/passthrough/x86/hvm.c @@ -796,8 +796,10 @@ static int _hvm_dpci_msi_eoi(struct domain *d, return 0; } -void hvm_dpci_msi_eoi(struct domain *d, int vector) +void hvm_dpci_msi_eoi(unsigned int vector) { + struct domain *d = current->domain; + if ( !is_iommu_enabled(d) || (!hvm_domain_irq(d)->dpci && !is_hardware_domain(d)) ) return; diff --git a/xen/include/asm-x86/hvm/io.h b/xen/include/asm-x86/hvm/io.h index 54e0161b492..8b8392ec59e 100644 --- a/xen/include/asm-x86/hvm/io.h +++ b/xen/include/asm-x86/hvm/io.h @@ -142,7 +142,7 @@ struct hvm_hw_stdvga { void stdvga_init(struct domain *d); void stdvga_deinit(struct domain *d); -extern void hvm_dpci_msi_eoi(struct domain *d, int vector); +extern void hvm_dpci_msi_eoi(unsigned int vector); /* Decode a PCI port IO access into a bus/slot/func/reg. */ unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr, diff --git a/xen/include/asm-x86/hvm/vioapic.h b/xen/include/asm-x86/hvm/vioapic.h index 36b64d20d60..882548c13b7 100644 --- a/xen/include/asm-x86/hvm/vioapic.h +++ b/xen/include/asm-x86/hvm/vioapic.h @@ -63,7 +63,7 @@ int vioapic_init(struct domain *d); void vioapic_deinit(struct domain *d); void vioapic_reset(struct domain *d); void vioapic_irq_positive_edge(struct domain *d, unsigned int irq); -void vioapic_update_EOI(struct domain *d, u8 vector); +void vioapic_update_EOI(unsigned int vector); int vioapic_get_mask(const struct domain *d, unsigned int gsi); int vioapic_get_vector(const struct domain *d, unsigned int gsi); -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 31 10:35:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 10:35:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103831.198031 (Exim 4.92) (envelope-from ) id 1lRYCZ-0004dy-36; Wed, 31 Mar 2021 10:35:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103831.198031; Wed, 31 Mar 2021 10:35:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYCY-0004dp-Vc; Wed, 31 Mar 2021 10:35:54 +0000 Received: by outflank-mailman (input) for mailman id 103831; Wed, 31 Mar 2021 10:35:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYCX-0004Zp-DH for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 10:35:53 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d6b4c8f5-1a2a-4f3e-a398-b4d6f00ac697; Wed, 31 Mar 2021 10:35:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6b4c8f5-1a2a-4f3e-a398-b4d6f00ac697 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617186951; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=NV3KE9n/uXtSsphUpkD9HAmF5sKVQHJPIYSdLPj7tUc=; b=HiT10VfVApaBoPDjbJgswzgS4ajtN0BqccUSp+TcKjx84K3/aOrzKnfk +RrHOTvP/Udj9uxe9zQJIwyHMBfxVE+8KAuH4Jawisv29hycznS4d8RrS mKDZRWLOQMAJSRRjSzEVImKUfNDzGyiQdW43/F/sJ67bKvPeHeeUdRuLO k=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: E0fE6gZR48Kl3l+ZKlFokDeQ/Dhy6Y6ECTvVb+aIMVahthzYLj57uzzfAod+RjFdelFVAjz4cY uRY3GxG4Y5+DHPG0JWIl3HFagWS6Eo34HPM3daCQdKcjjq6OR6MPOSLVuEx2xx/XMRwU6P1VLl o2h/vM7EkILwbXgFEeqWD6RlZ965cZgOGoW6Uda5O3aYkNKKP3+jALSfyvIOdXvNNL94TO/SNX n+dyzV3tgKAl4HgWwWhj7xQyzjRoTxenXx5EqujU0jcE25Uby3CvqyW2r0+vAK6k77DW15ZMCK m0E= X-SBRS: 5.2 X-MesageID: 40415650 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:x0km/66VqbDf3ZJ5BAPXwRKBI+orLtY04lQ7vn1ZYQBJc8Ceis CllOka0xixszoKRHQ8g7m7VZWoa3Xa6JJz/M0tLa6vNTOW3VeAAaNDyc/ZwzPmEzDj7eI178 1dWoV3FdGYNzdHpOng5g3QKbgd6f2m1IztuuvE1XdqSmhRGsNdxiN0EBySHEEzZCQuP/oEPa GR7MZGuDasEE5/BqiGL0IIQvTZoJnznI/mCCRsOzcc9AKMgTm0gYSKcCSw4xF2aVJy6IZny0 fpuUjT5qKvs/a0oyWsrVP73tBtt/bKjvdGDMyIoMAJJjvrkRbAXvUdZ5Sy+AobjcvqxFE2kM TdgxpIBbUO11rhOlubjDGo+w783C0g43XvoGXo/kfLkIjCax8RT+9i7LgpFifx2g4bk/xXlJ 9v5Sa/saFaCBvR9R6Nn+TgZlVRuWef5UY5nfV7tQ05baIuLIV/gKY4501vHJIJDEvBmfsaOd grNs3a6fpMGGnqCUzxjy1qyNyoaHw5Ag2LdEgEotCUyDhbhhlCvjIl+PA= X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40415650" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=blXoAwoYh/Az5AzBRXyKenEOFnoKKEVMUzSYfdj9vmdLFoPYoH6Qv932DqgB01I7nOripYKYVZKk2rQPkjDmxiYwBF8otMvFEaSK6F9IFwxmdxtk1w9f/Scte4LYIdP+bo+4PKB6ZM8jtmivABJJpyNTsC7Z44N1t8/mz1LA2SCYT5Omsa3mxBtdjS6nXHUxYI+X4O64oRNjMGXWVDDENMKfuwWKne5XV97Welc3XYGw2pg7tNVckttQKbeKy2O246AbqCQeaL28+IHLhEWgatsjvXQie+PSoPaEJvdLaYkZQGrkaFsFpyuFWBdfRqHFTD1ayP0qXC+PYaOymRd63Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VFsVREZZe9qZvUSg1UZfGO+DXUpYL2DZXPRk+PVsbKI=; b=VWCTeBrqvsgaaTFFTIn/mo0cJOOmrPBrGYm+6WHOUE+YckzKwdtzPVRYG0/aaAgf7XKQJzrcbj2kFrbyK9FEMoccjwxmCrHLt/hjtypOuLJwqhy/4sEJUegGIAlI2SB1slXgkaYrR1Cz5igLVHHbiWJMWNJ62zNrkbdOv3m3e5cKANFB3s8MxHFLSCQj8ayObIjGZF9Sk5YaEb2puOb8/dxv8wC24b9QAbWi/32Zsvdk1ds04A7aJts3DJwcILPCDU+4yfQDwYk2d9OMvYR9w7AqwjZBlMtPEDZfzfNqphMeaJKewwGzqTvfV0fQkyLlleJ4wmJNuMW87H6UT5yS6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VFsVREZZe9qZvUSg1UZfGO+DXUpYL2DZXPRk+PVsbKI=; b=rb/qDlgeB1JlyyPf+W07TzbWKlf/LU4mPPfafr41+f1XhBYiRL2O0STpJW4WfEZWGpq4MrQMAiPDXx6RkXOM/QjrBGQEUILSNzXSHTVvzdrs2ipg5Xz6ait9Uw1ycyexw20tKgJdDgXmjDYmXiT8/EfvzgQIBmBr/PZ6cBdVd5M= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , Paul Durrant Subject: [PATCH v3 02/11] x86/hvm: drop domain parameter from vioapic/vpic EOI callbacks Date: Wed, 31 Mar 2021 12:32:54 +0200 Message-ID: <20210331103303.79705-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210331103303.79705-1-roger.pau@citrix.com> References: <20210331103303.79705-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0050.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:31::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c2aa7e7b-5f5e-4d8e-407f-08d8f430bea5 X-MS-TrafficTypeDiagnostic: DM5PR03MB2777: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JzeYeKuF1xe5SUZvnjAKCGfLVRy/4rtcuqjVdtk0HZrXqxzfOS9C+LSJr3x/9ZSt9NhkZGMOfEv40Fgh9PeAbEilqJGbh0lp8Qmwj57SM/9ngs3j0AWSQQAXO8BB+HzDyP5CtcqPB7cmAf/1rspWAdMHjHoPZtTb4556JzpEzaDwHCefmecXcdERhuByVfcDRe5Ons1VfQmHMQ2rrmkBJMyQMkLGBfgZsGDm6LtXxkeG6+10Id1OJMCjTx7LHv+vC+CVc6Ds4mrndrE5Dce6NzhSMlavzyeaoLB+fxszV66nS5uEmxrZH9AfsSk6akXdF+R4G2X7YOtqywUpntYwytNmDcWK2O/wlqqotkGBKAkeS/uPKKuZ2Z+P14tDSLEOhGFij2xo9fFH/oMbV96ZMyAto7fhg4RLfmOojPAWQkxJzej1oUWWO+TwFSn8hyAluRBhs+8fT6L80jfvsQoeJa+OOe75e7xwNdyixefM847Uw8Wd1ALUS8H8hZwYNg0uD831Y0aLQkesgKlxhxoEoPDUuHtOlCBMTD9JYhnyQoNn3lFHjfkQp1nqsQ53XUjs0ldsJrmiKIvXux8LrWvwd7A6XZRVZ0PhMM8RcJ+6PPVjGasGV4cBZgHoffhsfMHb2PyBlzeF4MSQj9/aUFO+0A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(346002)(366004)(39860400002)(376002)(5660300002)(186003)(66476007)(16526019)(26005)(6486002)(8676002)(36756003)(86362001)(83380400001)(38100700001)(8936002)(956004)(54906003)(1076003)(6916009)(2906002)(4326008)(316002)(2616005)(66946007)(6666004)(66556008)(478600001)(6496006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dWx5NWxqRy9HYTdQeU5vdlhTTXhlemZrQ0dUbmh5ZEIzTG9yaTBDYmIxSklp?= =?utf-8?B?anZudTJnbzNRam9lTERHMTdLbnMxWHBOejhLRE5TMkdvbWpldVlHYmRNUDRN?= =?utf-8?B?Vm45Zi9MYnBNQ0N1ZkcrMDB1TVd1VzNJeFZKTDlZMjZTWkJ6ZXFUTzFXK085?= =?utf-8?B?YU1oSlY4RkRtYkNyaE1vY0pXam5BWXNUakZVZUlmNDJpbGxDZDlmK0lFWm9l?= =?utf-8?B?ckI4cUtrWitaMU1RSVdJT0hVcjFUanBveEZUOG1yQzFoMTVDTElTdkhhY3ps?= =?utf-8?B?N0ZzU3VuQlJ3b0lYd2I5elI1L3Mvb1VHTTNKQnpCeUYwYkxDZnZRSzc2ZDkr?= =?utf-8?B?QjNTSTJJamZQMC9Zc2FtbytTMSsyREsrSXozTVhXSXg5Mjl4NUZaaGV2OCtq?= =?utf-8?B?M1NyZDNnbVIwb1NJQy9aN2lYU3hDcWJDMGhUOFFPNnBiK0FvbHJEdW1hZzRt?= =?utf-8?B?USs3S1BDNUFEMXMvM2Z5dFdMNHhEOTFMK1AyRmdiWEpOWkR6eDRTeGFIWXFS?= =?utf-8?B?c3RQMk1VVGdqbWR1U2xCVnc5TDNXOFYvNUhOeVh6ZmZmZnczYnNsZlhRT0g5?= =?utf-8?B?NzhGOFBLNkM1bExubGR6cmx4b0ZyUDI3S0NQZHF3a3BwWVZZSEhCaitBeXVr?= =?utf-8?B?SThVSC9OWmsvSm1RMy9BcWd5REFSUnJaeGxjdG0zQXQ4YmYwa1B4cHB4bUJq?= =?utf-8?B?SmhpOGJQTy93aWkrcVJYY2padUZNL2ozQkQrL0lsTVlYNGNScHRYd1ZzVTVM?= =?utf-8?B?RUEwWlN1bjR2WnpSVGNZUktxcWhaRGpvMmFIT3JsUU9JdjBUOXB2Ky9oa1d2?= =?utf-8?B?VTNRUWZFWEVFME16NzJHYi83MHhHbjB6UTdFL2dQbFRLY3pwMGlOSVloeVJp?= =?utf-8?B?ZGdDNWFjc3RjMm1PTllGVkJFMkE5UWlORUcxaFMzVmhPY2NZSHFrTkFXMUtp?= =?utf-8?B?czRvVlR5WExrNEY4SFIyU282dGxjVTRYeEsxcUdmUkVnZk9uNHgvMCsycGY1?= =?utf-8?B?cmY0dVVBdS84aFYvZGJEcXhuT0JLam5rQld3ZU9tajM3cWUrbFVpMUxxa0hC?= =?utf-8?B?OStxVHMvZGUreStzSDBzMjFFcDB1YTUvejRlTjdBTVpReUxzZ25nMURsZGJw?= =?utf-8?B?Z3R5aGNObEd5SlBtOHlMc2J2bCtITFkyZi9XS0ZTZmhUaXQ4M3M5cjZyTVNF?= =?utf-8?B?SjV2RUZSb3JjTkJ1RFFGWC9aYzNLSFI4WE1LTkY0L01tWi9samc1ZXNCTUNt?= =?utf-8?B?eG4yS2ljczVHLzZyTjBsNmwyOHcvUUk5VkMxUDFYZjVjY2xWdE13dHprVTAz?= =?utf-8?B?VVF3UWZqOGF1aVJoZmFoajdZNWUvK2kzbjNMdmg1SHBxcWwvSzM4VldSREVT?= =?utf-8?B?czFQMHJXUHk4YkQ1ek1HMFhKRXVyMFJXYXBOTnVjRXNmMjYrSUFaamNYbS9U?= =?utf-8?B?eFJzS3VQb3VTWHUrM3JjYWpwMkhGMm5hRHMwR3dDWTVXWlBERWxkc2drTkJ2?= =?utf-8?B?MStaVHZ1UjdIY3AxVVp4ZzZnN201bnJ2QlQwTWlmaDhZMlZNcnQ4OXY0MDVY?= =?utf-8?B?c1ZXcU1ISmhCMVN3Zy9QZ2FwMWRBWUJkQ1pPVzFIdFZVVmQyN2NHWk8vRHd6?= =?utf-8?B?TnRDZ2RFempzVC8zUDNNTFprcS9kVyt2SU14UTRGamJLeHFHZm8rSXFDYkVK?= =?utf-8?B?THJWWmg0bkxJNTNqZmtKRGh2ZkxvS1dyMFc2bXhZQmF4bGVrdE1NRzhkTXJR?= =?utf-8?Q?NJGxKa+RgdwieJXEQrEBhpTgEMXaPHcGS1o3IHO?= X-MS-Exchange-CrossTenant-Network-Message-Id: c2aa7e7b-5f5e-4d8e-407f-08d8f430bea5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 10:35:46.9015 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nb25nqCrGbm9AFGTWtwpohMLth2F2FDioSTNaJq9OP/+XmmSmjP9KMDigNXvgYtuYXhUBqv2iRp3u0BhabsL/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2777 X-OriginatorOrg: citrix.com EOIs are always executed in guest vCPU context, so there's no reason to pass a domain parameter around as can be fetched from current->domain. No functional change intended. Signed-off-by: Roger Pau Monné Reviewed-by: Paul Durrant --- Changes since v1: - New in this version. --- xen/arch/x86/hvm/vioapic.c | 4 ++-- xen/arch/x86/hvm/vpic.c | 6 ++---- xen/drivers/passthrough/x86/hvm.c | 3 ++- xen/include/asm-x86/hvm/io.h | 2 +- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c index 91e5f892787..dcc2de76489 100644 --- a/xen/arch/x86/hvm/vioapic.c +++ b/xen/arch/x86/hvm/vioapic.c @@ -284,7 +284,7 @@ static void vioapic_write_redirent( */ ASSERT(prev_level); ASSERT(!top_word); - hvm_dpci_eoi(d, gsi); + hvm_dpci_eoi(gsi); } if ( is_hardware_domain(d) && unmasked ) @@ -541,7 +541,7 @@ void vioapic_update_EOI(unsigned int vector) if ( is_iommu_enabled(d) ) { spin_unlock(&d->arch.hvm.irq_lock); - hvm_dpci_eoi(d, vioapic->base_gsi + pin); + hvm_dpci_eoi(vioapic->base_gsi + pin); spin_lock(&d->arch.hvm.irq_lock); } diff --git a/xen/arch/x86/hvm/vpic.c b/xen/arch/x86/hvm/vpic.c index f465b7f9979..a69aecad912 100644 --- a/xen/arch/x86/hvm/vpic.c +++ b/xen/arch/x86/hvm/vpic.c @@ -235,8 +235,7 @@ static void vpic_ioport_write( unsigned int pin = __scanbit(pending, 8); ASSERT(pin < 8); - hvm_dpci_eoi(current->domain, - hvm_isa_irq_to_gsi((addr >> 7) ? (pin | 8) : pin)); + hvm_dpci_eoi(hvm_isa_irq_to_gsi((addr >> 7) ? (pin | 8) : pin)); __clear_bit(pin, &pending); } return; @@ -285,8 +284,7 @@ static void vpic_ioport_write( /* Release lock and EOI the physical interrupt (if any). */ vpic_update_int_output(vpic); vpic_unlock(vpic); - hvm_dpci_eoi(current->domain, - hvm_isa_irq_to_gsi((addr >> 7) ? (pin | 8) : pin)); + hvm_dpci_eoi(hvm_isa_irq_to_gsi((addr >> 7) ? (pin | 8) : pin)); return; /* bail immediately */ case 6: /* Set Priority */ vpic->priority_add = (val + 1) & 7; diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c index 2f6c81b1e2c..a9256e7ef51 100644 --- a/xen/drivers/passthrough/x86/hvm.c +++ b/xen/drivers/passthrough/x86/hvm.c @@ -911,8 +911,9 @@ static void hvm_gsi_eoi(struct domain *d, unsigned int gsi) hvm_pirq_eoi(pirq); } -void hvm_dpci_eoi(struct domain *d, unsigned int guest_gsi) +void hvm_dpci_eoi(unsigned int guest_gsi) { + struct domain *d = current->domain; const struct hvm_irq_dpci *hvm_irq_dpci; const struct hvm_girq_dpci_mapping *girq; diff --git a/xen/include/asm-x86/hvm/io.h b/xen/include/asm-x86/hvm/io.h index 8b8392ec59e..4f294232fb7 100644 --- a/xen/include/asm-x86/hvm/io.h +++ b/xen/include/asm-x86/hvm/io.h @@ -101,7 +101,7 @@ bool handle_mmio_with_translation(unsigned long gla, unsigned long gpfn, struct npfec); bool handle_pio(uint16_t port, unsigned int size, int dir); void hvm_interrupt_post(struct vcpu *v, int vector, int type); -void hvm_dpci_eoi(struct domain *d, unsigned int guest_irq); +void hvm_dpci_eoi(unsigned int guest_irq); void msix_write_completion(struct vcpu *); #ifdef CONFIG_HVM -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 31 10:35:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 10:35:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103833.198043 (Exim 4.92) (envelope-from ) id 1lRYCd-0004hg-C9; Wed, 31 Mar 2021 10:35:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103833.198043; Wed, 31 Mar 2021 10:35:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYCd-0004hW-7v; Wed, 31 Mar 2021 10:35:59 +0000 Received: by outflank-mailman (input) for mailman id 103833; Wed, 31 Mar 2021 10:35:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYCb-0004gV-L0 for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 10:35:57 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 44e71fb5-fe1a-4cb7-891e-c4233cdb117e; Wed, 31 Mar 2021 10:35:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44e71fb5-fe1a-4cb7-891e-c4233cdb117e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617186956; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=uZL29ugOlkoo4WkuuUBU+vjfeGVoGnql4+FwdjwuYkw=; b=cMcaf7jlRyPTxy9fC5T1nSuWXaaUmgmAjUEacUNGOoi6qVx+8IH286RE KP/8vA6RJi+nBppWs2t6QwnkruGZIYcuSlRfTJeyBMZ3F44CvfCOOZkjH a4MwZ0YM2XGK3mCQ87Vg7Te6B8MRaOk3yS8gcFDORedE6QxOIw22bXxEd M=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: /uvVyBv5xVnGakZuFeRVMy4mY9cyezBPFJig4mB6tRWhyGbcU7vPA5DcqVjPIa4nSnJPdW0lSY gCPlH/uacWa2Gk1Rkz+mW0Y8rJ4zxosMUqY1fmgKLhywQAPm9CLUAwAZlT32y9wG2/UcVyg7zX SE/COgEiplotmXfkQHK8D9Sk0FAZUM+Ch5Jo1RrIQu9aqAcflIV1m8bqp6qtpUbgZ3IlkYMEd5 3FbUfV0iU0K862wjTWrMLtpROdrsLy3lDg5O+ZdusFa9DbUbWFjZf3trfo/Kx81ZSuH1IkFfIk VbY= X-SBRS: 5.2 X-MesageID: 41994558 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:B5fhqqtFUXAdGj05Gn3cyYaB7skCrIMji2hD6mlwRA09T+Wxi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmwybde544NMbC+GDT3oWfAFvAG0aLO4R3FXxf/+OlUyL t6f8FFYuHYIFBmga/BjzWQPM0nxLC8npyAocf74zNTQRpxa6dmhj0JaDqzNkFtXgFJCd4YOf OnhvZvnDardXQJYsnTPBBsM9TrnNHXiIngJScPGh9P0mKzpAm14733GQXw5GZ8bxpzx94ZkF TtokjCyYiI99q6zRLd0GG71eUtpPLRjuFtKebJpswcKjDHghulaoJ7S9S5zU0IidDq0nkGup 3hpAohItRS5hrqDx2IiCqo4SbM+nIP7GLv0lCRi3eLm72HeBsKT/BvqKgcVzmx0TtFgPhMlJ hl8kjcir9sSTTHpyj578igbWATqmOE5UAMvMRWs2ZSSuIlGdhshL1axmx5OrEaEhn37Yg2ed Med/301bJtfVSWY2uxhBgI/PWcGnA6HhKxSkMfoMCi0z9PgHBjz0cDrfZv50s9yA== X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="41994558" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lhQY8Q/l2c+6iIvW71SMpYAVrLVHsqARZo9cog2+8XzZhmUbyv0ZETFZy1lrUswKxoovVEbOIhbPxVeGXgCgNOTiIXcqt9a2kyTu55852tJ9TmNlTjsTfu228ZK5FfY0pPVO2QCmELgxDnyrX79LTwBJNYG9fTkTZQYn1mdBPKa1LHPbJWnda+YqRbSdllg0QE5yhx3rk1qmgB615NTr/RPb4cwsPLAn4eDdQlX73k2igQuvuLWZ3liqvLNbBLkcwNNYNKsIPhzslOK9knthU7MYlVIdCJur7Jp8Dcz4Ov+HOJFPFh1zML1dqd1ntsKLU63Nl3H4zHq+GWy6ubp3xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uZNy/L5pNGQXMad8B2V5JHLEH+vnc9PVuVRiLVFoWBc=; b=gAJ2rBDFAFszOJyQBarAM2F89ax9WwK3ixGwi4oM38jCWbvzOoB43NiSQXrryQ0TQkkeKtXI3KobNzi6Y7KoCSNc5hIPj72HNEGB+5F3dhQW7CDj/EIoAhZm6uPmU1RKt0GA//lBMmDqV8CM6T5WbqjiuVeHZ3tOqFsgKSa4EXVSFpQ+wFhk0IC7CtR9/NQ4RuYfn730C2q5VtfDqJS6+NsAR+9EDlPd0WIzwL6dhicCfSaa4DwEQdNZSCDO2t/uL6ODZ2mncAZWlLFSnvHmg953otOpvMQeBs/q/hbBryHw/x0oOpHbHOLIRfd0jYgFMmBIMhPB3YmK6uXyRSUURQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uZNy/L5pNGQXMad8B2V5JHLEH+vnc9PVuVRiLVFoWBc=; b=FpVkjNC/CUc/BLLNsCdcUqyK64HwCy/rUvncXKF+5SF4ChspWMqN0NqM8DYNTd1paPGjbKynepgtd52wFNFx/Lyn1uRi6U+bgQa8T3Etozw8jXQt09Xgug4PnuzLkqtmZcI8WWXsEO+deOyh+LgmJMlmMWk/WQNfGK83ECEC0o8= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v3 03/11] x86/vlapic: introduce an EOI callback mechanism Date: Wed, 31 Mar 2021 12:32:55 +0200 Message-ID: <20210331103303.79705-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210331103303.79705-1-roger.pau@citrix.com> References: <20210331103303.79705-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0152.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::15) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 849cd698-cfa6-4f51-9f0c-08d8f430c258 X-MS-TrafficTypeDiagnostic: DM4PR03MB5968: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:506; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 978tVbIdC4b7xVB7qTjvrvvOkPJqj1euY03Fn+Y3BPKz73P4rRIBvxmu379v1eJuNtfUg2PLMd7kl3kXmES9+umdE2xIgWXFUloHXoydg+z4fKWUmrrbTnRVZv1yvusFt9FAj4ouZGz/y/luXOEyafVruUDQgRtwEJxFRjrmqOdK+tgLpPK4YSyYixeCTgte6vWTkbM9FI//esy4PeNdHJeFKkAzs92UpPbSZ/vczwGcSY/EgVTiyl4B8K6ERrGewib1Y/9kwl1d3oYEUsn7igc3PjUOx1wekVq1FB0q28v0lZ3iXP57kDN6NZQE52KVaMv4m8PiQoLcZv26RFQ1xoDeMoqvoqRSmhWd8zzWTOGGvuwjcNps8ZYB4PUPlpL9Eu6918M9buKzR1EQuM5bUvq8PbYVS+PrAV8OkrBUsan+BJTAlaTisrd+61UFRsIEmUhrMVALZNClveNfrxKwry1rdsKIz1pJ3WMe2p3fGPXA9QROrFbHTxs0+BtZQK+nMEcy6Mv6h6na2CdOyXY09+U5aQwAhXstRo91KDnEGWbzisno8SzrRLQMdGe+amcX88H9mAB5hUbAXJpiYk6ezizPKNTznEYDV8M/6n26EyuUTC5ex1guQEUGan1ZR/wi27ebaAidDUw0RuDlDOQwfkjbCWuceFb5W4hqdiBIIzY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(26005)(2906002)(6486002)(8676002)(1076003)(36756003)(38100700001)(8936002)(83380400001)(16526019)(86362001)(186003)(6916009)(6496006)(66556008)(66946007)(478600001)(66476007)(5660300002)(316002)(4326008)(2616005)(956004)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MVcyOUV0by9hQmpScEp5VTFVT1hpcytDeUdJQWpVRDhuMXBoREl3UE9oSVox?= =?utf-8?B?T0tUTjRVQVluYkV3T0lQZ3hXN3hPR2l5K1JteGljd3R1WXJPRktIcm03L2VL?= =?utf-8?B?OEhjOGtaRUlURktmSDJXaE8rTkM3K0J5bFZ0TGdTZ3QrSjBlUG1ualUxZVZ4?= =?utf-8?B?TFk4aTNlZWRrWDhXTGM4dWNRY1ZqR3I4UUV0elB4WERicGZoTTFCemZjUk9T?= =?utf-8?B?bVo0Z2RGMmdDYWpuK1hnNGt1dXgvTjhQejBSQmpGeDJQWjVUa0NsVTRpSTRp?= =?utf-8?B?b3hvSWl3SkdRcGZ1TytBaTVadkNLSjkzSjZvNUNEMkxIVElqRk9Ma01yZU5j?= =?utf-8?B?T3lxRENuZHY3dGo3QWZoOWo1bTNIcmppMnJkRkxGbjRkbHN0MGhpSjNrV2t2?= =?utf-8?B?TTRIYTQwVjhRZU50UGgrN2ZPZmZwZlJMcTNwdXRrdGZwNmJyTmNGQmU0RlNl?= =?utf-8?B?NWVTUC83bkpPV2JXRkh1UWpFSmYrcVptbGJzVTVxUExvTnpWTHNzakZTd056?= =?utf-8?B?MmdOZXBNazVFT084TnB2TUxvMERRYStGbk5Pd0xaeXcxSDB6MmllQ3IvRDNm?= =?utf-8?B?c1Zra3VvNTllbk5XbjRlUkVVREdPcnVrREQxOHlWUHVaUlczK05hbFhlUURo?= =?utf-8?B?ZzdCVStNOFVFVlJjUlRZdEJ2Zjg1VzFXVHNXaS9pNGZFc3RtRHRXcmNzK0wr?= =?utf-8?B?ZDlEeHRIaXl2K1pzYkN6TG5MclBmZGRxd1FIb2gvZll6RDlDMVV1MC91TWhh?= =?utf-8?B?WU5NUEV6YXc5NmM0YW5ja3VYSmRNUTM4Nk9SQ0dwV040aU5IUEV0YVBSYVNL?= =?utf-8?B?NGl0TVpZV0ZUZitBVXJtbnRBK2M1d0VmYjJid24xMENiZHdBMHl4aTZ6c0Fn?= =?utf-8?B?V2FvalVLSG45eXZrV0ZSWFp1aVRBbDhLYnRKS05xajdtcThYcDZvVnE4TjB6?= =?utf-8?B?MnczZGVZRGEzZXZBNER2UVdhODIwVkY5aGJzZlVUc3dIWXB6NVBGQ0o5OXdM?= =?utf-8?B?eEZzY25QU3FBMEZYRXRNRUJzajFWbXJHQVNDaGdNWlJsNUI3UUVPQWR5OG93?= =?utf-8?B?OCt6dFhhNjFCN1A4aXZiMkphOCtTbVpmajFvZmFsbmxDVlRiWXNqNXpBRjVG?= =?utf-8?B?WS9FMTE4SHhHN2J0NGJlU3N6T2lYL3dsRXNqb3NUb25uNlhkT0lNRWFqK0lD?= =?utf-8?B?WjZtYkgzVE80SXhkaXpERWd2U3dSaUdZbWdrbkJ2V21aYUk5ZDByaGdhVlJ6?= =?utf-8?B?ZU1tcGV1d1JCMUhsU1pIT09haG94OHdmcENqWUFLa0g5ZFNrWGRTUUNFaFJX?= =?utf-8?B?M0I3dHpaWHpSM2lnNGJUZldVSEpUVk5yNGxGY0lIcUtrWElldDVFeW5iNDJM?= =?utf-8?B?SjNsWno4M3RBVXoyRzZkd0NOQUo0ZFczcmY5N1NvR2ZTRVNpSDNsMmpDeG4z?= =?utf-8?B?bmpkWHNRbVQxQXFPcmNSakQvUnRjT3BIWTdWTTFNd3U2cnd6QXVhOHpnSzN2?= =?utf-8?B?M09XUENoRHZtSnhLWHFwdExIblpwZ1Awb0haREVUZmFVaWI1dlM2MFBRNG9k?= =?utf-8?B?WmxUMzdPRmRQL0NKSFF3NUdTaDJ6aElTbkJzU0UwbUttL3dmR2RJUm1Xbnpw?= =?utf-8?B?Nkk3TmNzTlZzYjJXbzYrc2NrRTArWklkTDczU2hhSWdSM1p2c1B5ajNJczJP?= =?utf-8?B?SHFJWldsQjVzRTQ2Z21pZWtDUEExQU45ZU1KWVVVU2NYU210L0xhMXRFdUlT?= =?utf-8?Q?u3JkV+0DkvmBg71tbBnkQecPLFUX+P7S1jB213x?= X-MS-Exchange-CrossTenant-Network-Message-Id: 849cd698-cfa6-4f51-9f0c-08d8f430c258 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 10:35:53.0006 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Uk7sJxrigTALmRmpuIWDkmH+7wdVt+PT3ExT0sWxHlJOrqFVHvkSft46g9fK+2jhBxH7VImo50T1kwTlgc9S1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5968 X-OriginatorOrg: citrix.com Add a new vlapic_set_irq_callback helper in order to inject a vector and set a callback to be executed when the guest performs the end of interrupt acknowledgment. Such functionality will be used to migrate the current ad hoc handling done in vlapic_handle_EOI for the vectors that require some logic to be executed when the end of interrupt is performed. The setter of the callback will be in charge for setting the callback again on resume. That is the reason why vlapic_set_callback is not a static function. No current users are migrated to use this new functionality yet, so no functional change expected as a result. Signed-off-by: Roger Pau Monné --- Changes since v2: - Fix commit message typo. - Expand commit message. - Also print a warning if the callback data is overridden. - Properly free memory in case of error in vlapic_init. Changes since v1: - Make vlapic_set_irq an inline function on the header. - Clear the callback hook in vlapic_handle_EOI. - Introduce a helper to set the callback without injecting a vector. - Remove unneeded parentheses. - Reduce callback table by 16. - Use %pv to print domain/vcpu ID. --- xen/arch/x86/hvm/vlapic.c | 64 +++++++++++++++++++++++++++++++- xen/include/asm-x86/hvm/vlapic.h | 18 ++++++++- 2 files changed, 79 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index 98e4ba67d79..851a1f5bd6c 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -144,7 +144,35 @@ bool vlapic_test_irq(const struct vlapic *vlapic, uint8_t vec) return vlapic_test_vector(vec, &vlapic->regs->data[APIC_IRR]); } -void vlapic_set_irq(struct vlapic *vlapic, uint8_t vec, uint8_t trig) +void vlapic_set_callback(struct vlapic *vlapic, unsigned int vec, + vlapic_eoi_callback_t *callback, void *data) +{ + unsigned long flags; + unsigned int index = vec - 16; + + if ( !callback || vec < 16 || vec >= X86_NR_VECTORS ) + { + ASSERT_UNREACHABLE(); + return; + } + + spin_lock_irqsave(&vlapic->callback_lock, flags); + if ( vlapic->callbacks[index].callback && + (vlapic->callbacks[index].callback != callback || + vlapic->callbacks[index].data != data) ) + printk(XENLOG_G_WARNING + "%pv overriding vector %#x callback %ps (%p) data %p " + "with %ps (%p) data %p\n", + vlapic_vcpu(vlapic), vec, vlapic->callbacks[index].callback, + vlapic->callbacks[index].callback, vlapic->callbacks[index].data, + callback, callback, data); + vlapic->callbacks[index].callback = callback; + vlapic->callbacks[index].data = data; + spin_unlock_irqrestore(&vlapic->callback_lock, flags); +} + +void vlapic_set_irq_callback(struct vlapic *vlapic, uint8_t vec, uint8_t trig, + vlapic_eoi_callback_t *callback, void *data) { struct vcpu *target = vlapic_vcpu(vlapic); @@ -159,8 +187,12 @@ void vlapic_set_irq(struct vlapic *vlapic, uint8_t vec, uint8_t trig) else vlapic_clear_vector(vec, &vlapic->regs->data[APIC_TMR]); + if ( callback ) + vlapic_set_callback(vlapic, vec, callback, data); + if ( hvm_funcs.update_eoi_exit_bitmap ) - alternative_vcall(hvm_funcs.update_eoi_exit_bitmap, target, vec, trig); + alternative_vcall(hvm_funcs.update_eoi_exit_bitmap, target, vec, + trig || callback); if ( hvm_funcs.deliver_posted_intr ) alternative_vcall(hvm_funcs.deliver_posted_intr, target, vec); @@ -459,10 +491,24 @@ void vlapic_EOI_set(struct vlapic *vlapic) void vlapic_handle_EOI(struct vlapic *vlapic, u8 vector) { + vlapic_eoi_callback_t *callback; + void *data; + unsigned long flags; + unsigned int index = vector - 16; + if ( vlapic_test_vector(vector, &vlapic->regs->data[APIC_TMR]) ) vioapic_update_EOI(vector); hvm_dpci_msi_eoi(vector); + + spin_lock_irqsave(&vlapic->callback_lock, flags); + callback = vlapic->callbacks[index].callback; + vlapic->callbacks[index].callback = NULL; + data = vlapic->callbacks[index].data; + spin_unlock_irqrestore(&vlapic->callback_lock, flags); + + if ( callback ) + callback(vector, data); } static bool_t is_multicast_dest(struct vlapic *vlapic, unsigned int short_hand, @@ -1620,9 +1666,22 @@ int vlapic_init(struct vcpu *v) clear_page(vlapic->regs); + vlapic->callbacks = xmalloc_array(typeof(*vlapic->callbacks), + X86_NR_VECTORS - 16); + if ( !vlapic->callbacks ) + { + dprintk(XENLOG_ERR, "%pv: alloc vlapic callbacks error\n", v); + unmap_domain_page_global(vlapic->regs); + free_domheap_page(vlapic->regs_page); + return -ENOMEM; + } + memset(vlapic->callbacks, 0, + sizeof(*vlapic->callbacks) * (X86_NR_VECTORS - 16)); + vlapic_reset(vlapic); spin_lock_init(&vlapic->esr_lock); + spin_lock_init(&vlapic->callback_lock); tasklet_init(&vlapic->init_sipi.tasklet, vlapic_init_sipi_action, v); @@ -1644,6 +1703,7 @@ void vlapic_destroy(struct vcpu *v) destroy_periodic_time(&vlapic->pt); unmap_domain_page_global(vlapic->regs); free_domheap_page(vlapic->regs_page); + XFREE(vlapic->callbacks); } /* diff --git a/xen/include/asm-x86/hvm/vlapic.h b/xen/include/asm-x86/hvm/vlapic.h index 8f908928c35..c380127a719 100644 --- a/xen/include/asm-x86/hvm/vlapic.h +++ b/xen/include/asm-x86/hvm/vlapic.h @@ -73,6 +73,8 @@ #define vlapic_clear_vector(vec, bitmap) \ clear_bit(VEC_POS(vec), (uint32_t *)((bitmap) + REG_POS(vec))) +typedef void vlapic_eoi_callback_t(unsigned int vector, void *data); + struct vlapic { struct hvm_hw_lapic hw; struct hvm_hw_lapic_regs *regs; @@ -89,6 +91,11 @@ struct vlapic { uint32_t icr, dest; struct tasklet tasklet; } init_sipi; + struct { + vlapic_eoi_callback_t *callback; + void *data; + } *callbacks; + spinlock_t callback_lock; }; /* vlapic's frequence is 100 MHz */ @@ -111,7 +118,16 @@ void vlapic_reg_write(struct vcpu *v, unsigned int reg, uint32_t val); bool_t is_vlapic_lvtpc_enabled(struct vlapic *vlapic); bool vlapic_test_irq(const struct vlapic *vlapic, uint8_t vec); -void vlapic_set_irq(struct vlapic *vlapic, uint8_t vec, uint8_t trig); +void vlapic_set_callback(struct vlapic *vlapic, unsigned int vec, + vlapic_eoi_callback_t *callback, void *data); +void vlapic_set_irq_callback(struct vlapic *vlapic, uint8_t vec, uint8_t trig, + vlapic_eoi_callback_t *callback, void *data); + +static inline void vlapic_set_irq(struct vlapic *vlapic, uint8_t vec, + uint8_t trig) +{ + vlapic_set_irq_callback(vlapic, vec, trig, NULL, NULL); +} int vlapic_has_pending_irq(struct vcpu *v); int vlapic_ack_pending_irq(struct vcpu *v, int vector, bool_t force_ack); -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 31 10:36:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 10:36:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103834.198055 (Exim 4.92) (envelope-from ) id 1lRYCk-0004nm-Mr; Wed, 31 Mar 2021 10:36:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103834.198055; Wed, 31 Mar 2021 10:36:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYCk-0004nb-Io; Wed, 31 Mar 2021 10:36:06 +0000 Received: by outflank-mailman (input) for mailman id 103834; Wed, 31 Mar 2021 10:36:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYCj-0004n7-NJ for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 10:36:05 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 36f13894-7e30-4be7-b5d6-7f162e5a4861; Wed, 31 Mar 2021 10:36:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36f13894-7e30-4be7-b5d6-7f162e5a4861 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617186963; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=SAMetwL225xAPJrGDUL/huf4ma4jzM1uF1a4Ewpv1GI=; b=fmFkDtuxxqJTuYSGyA2G/qx8qYNb0C17Ek/zlQ1R1zbR+SH1LB4l96fM 4rsqCbtNV6+UXHxs/PZ7GYKw3ixesZh2+G3u/wAFFU9l/Z/CwJU06ccDa f6qLCFLEc3jLm+NKlLIml30nER4CUqGFCIPfPSW7la/VfY6OGDF2Thge3 o=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: mMzDO/UtqfEMR85hIoZGLRQ3Kir479SPvJtCWN1oKs3VaYJXFfY3VFlBJhwbr3a14m++TGZQXH 5lQxI0mZyBX2xgT0wWdpNmfCHAs7UO9ISdWCCJFj3hKYG+C5dREjkDdLznq0LkVJzujhgATXOg lUx8WgENIUiOSP5K+/LACYNfBeyBS5n0ukYeMjFby6tiLM+R+qetV1LaS5bjLh0OHmBr8dNnxU Qpa5yRVW8poVoXujUPFjW/Seh394NS/bxymJc/ZkSxKEYF3YBuknzrmpxpCxI8uBbXOwqcoomx oAY= X-SBRS: 5.2 X-MesageID: 40526842 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:yz5w+6+g3WNDQYI+MSFuk+ECdb1zdoIgy1knxilNYDRIb82VkN 2vlvwH1RnyzA0cQm0khMroAsS9aFnb8oN45pRUAKe6UGDdyQ6VBaxBza+n+T3vHCXi6vVQvJ 0LT4FSAMD9ZGIUse/U+w+9euxP/PCi0ISFwdjT1G1sSwYCUdAD0y5cBhyAGkN7AClqbKBYKL Om6sBKpyWtdB0sB6zWOlA/U/XevNqOrZr6YHc9bCIP0hWEjj+j9dfBYnul9yoZOgkv/Z4StV Lrvia8zaWlvvG9xHbnphXuxqUTovTN4J9uAMSNj+IcNznjjB25Db4RJoGqjXQOj8yErHosjd nQszcsVv4Dl0/5TyWOjjbGnynmzTo05HfpxTaj8ATeiP28fh0WIY5lp+tiA3/kwntlhv5Q+u Z3+ljckJxtARbJjE3GlqD1fiAvrGWYiz4fi+IJ5kYvNrc2WftqgqE02lhaK5sEFDKS0vFdLM BeSPvR4/tbajqhHhbkl1gqxNStW0I6FQudTn4DvdSI0yNXkGoR9Tpg+PAi X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40526842" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PYFNRO2v9PQNta0i9/xKKWtOyUexGq4WJb15ZY3awq2ZmoS68E7k0nA4eVyDjPg9tySdeeZmNhiozWB10wX5D3a4Inny4pSUNnKrNuWT+7dwlgIP5Q9Z6g4Ekj/tPpgI0S7O5eHXd+9bH61Wzgda12X4DUbbDXs7N4TkbGxzufg61CctqBNw8F4uX9ZQjlIsEcaD1zQDIDtrkOxPbLqr7eovvTZFeNW796713lza+MI2TJ/UwgcKuo8FYfZO2tquRkqDc0mcLSf8y0BokOsTlju1Rc69gVJFdD3oL20cPyOnStX0jF/xRyRhjZ3zTSK5WVIWEfporiSuTxvukH1onQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oExx38XePN+e7ZWQr4jQrYxJher8CBXgUSz66AMKv2I=; b=hsgtQ7cFnU5YYlHSP17fZ3F0+FgXNYY97fmI/k1wGINLuf1pXNO3cGzYjiIPIjN3IsgQnzO6Re/DdHnm09Q/xWK9esAlGWyr8LU0BrH0KGv4ky8m5EwN5ALHYpRNZrJ1zP/i1iOsJ/gjgA2abgONOXwkgjEqz+ezsIdIKfZybnEWbR9c4EC9rtG56Uzgv07fVRuTayZxJGjWDdefNuLJ0BJMMroiI8SpOraK8Z/a7erBxQ8EFAzNmtI6wia6sqG2JSCx9nQMLm3Pjs9wjEiYhqLIqpEuU0X5s+V+ty+9TVsjqL7B6Mxq295XGGoNP8leSIcFFgcciszWBOzvE5vOdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oExx38XePN+e7ZWQr4jQrYxJher8CBXgUSz66AMKv2I=; b=wg62XuQn993CLgDTML37U2+AifsWMQQCrPu090gBmPGLgM/uVxVrATw6Cq6Hi8xxoEFFuESe6vBIpishrZGhzZLZOuyczzN4hOA9bQH8C9TQ1eVTxvlHktI0DgUQll/pRxL0QJra/jKSBYcb+qtxLBKMxgOcwhzcQUXvTAieZrg= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , Paul Durrant Subject: [PATCH v3 04/11] x86/vmsi: use the newly introduced EOI callbacks Date: Wed, 31 Mar 2021 12:32:56 +0200 Message-ID: <20210331103303.79705-5-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210331103303.79705-1-roger.pau@citrix.com> References: <20210331103303.79705-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0126.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 42ff27b1-56fe-4a67-8066-08d8f430c62c X-MS-TrafficTypeDiagnostic: DM4PR03MB5968: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QE/xhWlPvdNviFTXrhyJYz09KJm+WG6fBc/zLhEBQwXxez6QSWlaL47RSrXUtZOxaG7xItKIcwJWSMasW5W4M25xb5yI5KgH5P3WiuyhQUVSsbvk834Ui7vEQ0rs4eP2L3VO70PSJfRxHJDdR61/bswqCvTKewVNUHwgHnDDsB58OoGYqnrVlMEyaYKp1bgftwdk9sD/UNEfnhhdnBlxeZOwXa5Vf0gz7h/YFETxVrwvaovdswxK/naoRY0RUkwqEo1NYb/uXINhUw7CrdWXD+o9n+BYt4muKnOKQAXNgHCqO5DX/nvurkUlcJMTDlFqFIPGGCCxm8Lk15i3umy0rSi6MSqZVYnFCcT7h4ugM3uXu79If/e7KXyJ63vZKBcRoFRG0TOaJNXswdfNeSZr6ekve/KpwsDJbamhj3+peQEao/tfCFxScOU9ioaPvuMemJaVSY8cUaihRZXRIyzUi81K4x0k26TBR/tcezaWi2N+iM0wxVfqsezB5huL1PoClfdTLa/E/XbISlT3elkkiY4fIuvPA9Cl428lsgZIWCG6zBOpeNKsNue+8scC3EXJWOEJjoiX//nMuawPorCcbUSU0MMbDEFQXSX8PEB8Bz+gpc7/dFRrWgU6Boz+yzbgiin/VzriFzgcPnH7AJ0BSy1uwwiGh3GlTS06nd7DOe8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(26005)(2906002)(6486002)(8676002)(1076003)(36756003)(38100700001)(8936002)(83380400001)(16526019)(86362001)(186003)(6916009)(6496006)(66556008)(66946007)(478600001)(66476007)(5660300002)(316002)(4326008)(2616005)(6666004)(956004)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZGo4VWlpLzNwa2dsaGpCaHpwbktuS1dnakFmV3cxVEgySjBMdXkvZHFtN0dN?= =?utf-8?B?Ym9ZVHNFeHUzVE4rOVVlZm15L0NIVHR6aUwwcVhRcjBnS3VSclg1bHpCVlhh?= =?utf-8?B?V1V6RFQvR3YrLy9WMDdKNW04Zks1YnovNFU4SzhJUEkrL2luTlFJaUZEQm13?= =?utf-8?B?MWxjMTBla2kxYStkenBtbGRxNWsrV1NLTGd0NDFqNnRSTmkyTkZuRTFMSnd5?= =?utf-8?B?SktMdnRaa2trY3ZGeGFYcStrRTZOakljcG92Y0lzQmRPUU0vWEJpSXFzWVJT?= =?utf-8?B?K0t0Q0FUOU9pSDNGRG9SRlpwekN6QzBPbENqQWkzNE9iMjNMd2wxTGlJdm8z?= =?utf-8?B?Q3lsRmJ4USswRmdWNURHcnFRZXJKVVUwKzBFSDVFTEtkU0krVzhmUVVJQ3B6?= =?utf-8?B?VEo2TGJOTE4vK1h5VDNBamM2c1VZRFM4QWVTMk5hNWVTeGVzM2F5VHdZemp6?= =?utf-8?B?TUZJWTVuU3VCaFlXbTR0V0d6RUhSVHlkM3E5Tmt0U0hoaEI3WkFBUXBrNDIx?= =?utf-8?B?Q0xPdGFINzR2SjVaZGpWQkJ0K09oMWtwTWdGMlRjbStkYnFRd1g0UVBqMyta?= =?utf-8?B?OXI1S1Y0aHg3S1BNNTlibUZmWVNnOVp0U1JHK01XRk5IVkpMaHlhVzU4ckg2?= =?utf-8?B?bUl4VzVVeC9UT2lVb3JmR2dQUjZPdzhWQVorVjh2d0xYWFBGWFhqR2s5QzVQ?= =?utf-8?B?WFBxWE52Y0pnOUtpNGNuZEZZQU5meUdQYVVHR08reXJaQlVSVUpLSHBxelpT?= =?utf-8?B?aXYvZmpWeVlxV3FRaXdxQ3NOQ0Vyc0JvTUNNeXNDQUkyZXZndjdybVJTb29j?= =?utf-8?B?cmhSTXVid1lrOXFMWCtXS0MvZTZyb013dzdEV0tVWkNTbVpLSnlFNkx6Vmto?= =?utf-8?B?YVYxMkJ2cmZSeXNOYXpPYXdDajJmbFhqaGRzZzM1K1h2TW1xRFZORm5HNXpC?= =?utf-8?B?b2xMLzlJaWROblRWcDlyYlNlb09KQWhzZHl1dkZUdkZWd3UxYk5vamwzbk9Y?= =?utf-8?B?YkNJT2xlYjFDbEdrOTR5cVRmOFBvUkNMQUR6Q1A0NUNFOUljb0QvK3dlVWs4?= =?utf-8?B?N016UG5yWjRTRnRuUWMxaU5uVm1hMnA1MHBDR3p2T3h0R2RLR3l5NFEzUU1i?= =?utf-8?B?bVVWRWFDUHVmeW9ySWhzTXJFME9WZW1xQlRKa2hFRW81djl3TEVUN2RJdWpz?= =?utf-8?B?L3B6Wm1xdlFKRXVFSzlxNlBPSlpnM2NzNUFkMmRCRWxTNFlRd0R6SzNiZURW?= =?utf-8?B?U0t5UEMrOHo5eUFkZ2lHeUo1UE1QWm9qTzZvR3ZTYkR2eHBkTUVzL0dNR0hn?= =?utf-8?B?WC9PQ25UaXhwZUdQUUlxSDBiYkFUb3FkZEQzRngrSXdpYzcvMjhkcEtxMlh0?= =?utf-8?B?SU5KcG5FK21LYlFNbXJsSEZUdVNybTBuU2xHL0Rrc3o5dHAvS1VVTjdIZ2dH?= =?utf-8?B?a3ZSQlhTQVR1cWp5c281M1RvNE1nbk5iK2tUNjFYSmMwdmdoMmx3bk5tWU50?= =?utf-8?B?TmpjZXZjcjArVHhLSy8rREozSkFGbjdWaDUzczhHTEVUcW1WK0I2aG4xZXgy?= =?utf-8?B?bVFETUUvbGZtNUtvWkRWdEllWXp2NGs0dzVtUzdVb1k3WFBwdmVjTk1UQVhn?= =?utf-8?B?T1NXaXFoT2pPdGdYdGtJL0lUbHFrUkhVMDVWRTBFYTRmRWhDSjljM2pnMkly?= =?utf-8?B?eWkzMHJ0U2FaOGN4UG5rWmE1dU5nMzVrU21vbi9adXJxMThpeFJUZkZkOTdR?= =?utf-8?Q?Ng0cMppcc4jevI6OhcJGHun60fxIJDAa45hcWXc?= X-MS-Exchange-CrossTenant-Network-Message-Id: 42ff27b1-56fe-4a67-8066-08d8f430c62c X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 10:35:59.4184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JHaqRcPZ7IXQIMl0WsxuGNv6e5Ct6+k4NQVuYVwumLEXRaaCJ7dK3w8+CgrvgCdOAQZrszudRRmmgvMBtTyLEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5968 X-OriginatorOrg: citrix.com Remove the unconditional call to hvm_dpci_msi_eoi in vlapic_handle_EOI and instead use the newly introduced EOI callback mechanism in order to register a callback for MSI vectors injected from passed through devices. This avoids having multiple callback functions open-coded in vlapic_handle_EOI, as there is now a generic framework for registering such callbacks. It also avoids doing an unconditional call to hvm_dpci_msi_eoi for each EOI processed by the local APIC. Note that now the callback is only registered (and thus executed) when there's an MSI interrupt originating from a PCI passthrough device being injected into the guest, so the check in hvm_dpci_msi_eoi can be removed as it's already done by hvm_dirq_assist which is the only caller of vmsi_deliver_pirq. Signed-off-by: Roger Pau Monné --- Changes since v2: - Expand commit message. - Pass the domain as the callback data. - Remove the check in hvm_dpci_msi_eoi --- xen/arch/x86/hvm/vlapic.c | 2 -- xen/arch/x86/hvm/vmsi.c | 35 ++++++++++++++++++------------- xen/drivers/passthrough/x86/hvm.c | 8 ++----- xen/include/asm-x86/hvm/io.h | 2 +- 4 files changed, 24 insertions(+), 23 deletions(-) diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index 851a1f5bd6c..10b216345a7 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -499,8 +499,6 @@ void vlapic_handle_EOI(struct vlapic *vlapic, u8 vector) if ( vlapic_test_vector(vector, &vlapic->regs->data[APIC_TMR]) ) vioapic_update_EOI(vector); - hvm_dpci_msi_eoi(vector); - spin_lock_irqsave(&vlapic->callback_lock, flags); callback = vlapic->callbacks[index].callback; vlapic->callbacks[index].callback = NULL; diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c index 13e2a190b43..3da0a2261fd 100644 --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -44,11 +44,9 @@ #include #include -static void vmsi_inj_irq( - struct vlapic *target, - uint8_t vector, - uint8_t trig_mode, - uint8_t delivery_mode) +static void vmsi_inj_irq(struct vlapic *target, uint8_t vector, + uint8_t trig_mode, uint8_t delivery_mode, + vlapic_eoi_callback_t *callback, void *data) { HVM_DBG_LOG(DBG_LEVEL_VLAPIC, "vmsi_inj_irq: vec %02x trig %d dm %d\n", vector, trig_mode, delivery_mode); @@ -57,17 +55,17 @@ static void vmsi_inj_irq( { case dest_Fixed: case dest_LowestPrio: - vlapic_set_irq(target, vector, trig_mode); + vlapic_set_irq_callback(target, vector, trig_mode, callback, data); break; default: BUG(); } } -int vmsi_deliver( - struct domain *d, int vector, - uint8_t dest, uint8_t dest_mode, - uint8_t delivery_mode, uint8_t trig_mode) +static int vmsi_deliver_callback(struct domain *d, int vector, uint8_t dest, + uint8_t dest_mode, uint8_t delivery_mode, + uint8_t trig_mode, + vlapic_eoi_callback_t *callback, void *data) { struct vlapic *target; struct vcpu *v; @@ -78,7 +76,8 @@ int vmsi_deliver( target = vlapic_lowest_prio(d, NULL, 0, dest, dest_mode); if ( target != NULL ) { - vmsi_inj_irq(target, vector, trig_mode, delivery_mode); + vmsi_inj_irq(target, vector, trig_mode, delivery_mode, callback, + data); break; } HVM_DBG_LOG(DBG_LEVEL_VLAPIC, "null MSI round robin: vector=%02x\n", @@ -89,8 +88,8 @@ int vmsi_deliver( for_each_vcpu ( d, v ) if ( vlapic_match_dest(vcpu_vlapic(v), NULL, 0, dest, dest_mode) ) - vmsi_inj_irq(vcpu_vlapic(v), vector, - trig_mode, delivery_mode); + vmsi_inj_irq(vcpu_vlapic(v), vector, trig_mode, delivery_mode, + callback, data); break; default: @@ -103,6 +102,13 @@ int vmsi_deliver( return 0; } +int vmsi_deliver(struct domain *d, int vector, uint8_t dest, uint8_t dest_mode, + uint8_t delivery_mode, uint8_t trig_mode) +{ + return vmsi_deliver_callback(d, vector, dest, dest_mode, delivery_mode, + trig_mode, NULL, NULL); +} + void vmsi_deliver_pirq(struct domain *d, const struct hvm_pirq_dpci *pirq_dpci) { uint32_t flags = pirq_dpci->gmsi.gflags; @@ -119,7 +125,8 @@ void vmsi_deliver_pirq(struct domain *d, const struct hvm_pirq_dpci *pirq_dpci) ASSERT(pirq_dpci->flags & HVM_IRQ_DPCI_GUEST_MSI); - vmsi_deliver(d, vector, dest, dest_mode, delivery_mode, trig_mode); + vmsi_deliver_callback(d, vector, dest, dest_mode, delivery_mode, trig_mode, + hvm_dpci_msi_eoi, d); } /* Return value, -1 : multi-dests, non-negative value: dest_vcpu_id */ diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c index a9256e7ef51..2331af896d4 100644 --- a/xen/drivers/passthrough/x86/hvm.c +++ b/xen/drivers/passthrough/x86/hvm.c @@ -796,13 +796,9 @@ static int _hvm_dpci_msi_eoi(struct domain *d, return 0; } -void hvm_dpci_msi_eoi(unsigned int vector) +void hvm_dpci_msi_eoi(unsigned int vector, void *data) { - struct domain *d = current->domain; - - if ( !is_iommu_enabled(d) || - (!hvm_domain_irq(d)->dpci && !is_hardware_domain(d)) ) - return; + struct domain *d = data; spin_lock(&d->event_lock); pt_pirq_iterate(d, _hvm_dpci_msi_eoi, (void *)(long)vector); diff --git a/xen/include/asm-x86/hvm/io.h b/xen/include/asm-x86/hvm/io.h index 4f294232fb7..9ac3e4f48f6 100644 --- a/xen/include/asm-x86/hvm/io.h +++ b/xen/include/asm-x86/hvm/io.h @@ -142,7 +142,7 @@ struct hvm_hw_stdvga { void stdvga_init(struct domain *d); void stdvga_deinit(struct domain *d); -extern void hvm_dpci_msi_eoi(unsigned int vector); +void hvm_dpci_msi_eoi(unsigned int vector, void *data); /* Decode a PCI port IO access into a bus/slot/func/reg. */ unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr, -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 31 10:36:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 10:36:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103841.198067 (Exim 4.92) (envelope-from ) id 1lRYCu-0004vo-8D; Wed, 31 Mar 2021 10:36:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103841.198067; Wed, 31 Mar 2021 10:36:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYCu-0004ve-3y; Wed, 31 Mar 2021 10:36:16 +0000 Received: by outflank-mailman (input) for mailman id 103841; Wed, 31 Mar 2021 10:36:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYCs-0004un-Gm for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 10:36:14 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 708e5ba8-4afb-4791-94a4-f598a6585d17; Wed, 31 Mar 2021 10:36:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 708e5ba8-4afb-4791-94a4-f598a6585d17 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617186972; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=BZyxwqwyKCBvk+CFEEPMfCfivieAaaU9nS1MxnsMyOk=; b=anUu9mHhbDqO7K2cjT5JUqp7AMREM17mju5grLFBe+qMiuELHJI4JjM/ YlLGo+Kayp+3uExbeVjSuhXLV+2uOdfPjyCxYVPDIpXsYCQ5vAt6XZm/0 4zZs8RkmbQFJbo60xO2exgi0eifEOLBxWFmMrcJxubAs2JEm33OkRp9xd I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 7sweMx5zWJWaAZNnY8I3TtLQCrhCvt5dyYhSWNsHIcX7mNhRYJVlxKxRgWU3iQD6bGTKdMw74D 7Y2rt241g3zBMKcr45pqAnzpmYPbZO/rN77CWnLE3dXrV2eo6knASSLCNHgfeJNILDYLhKban7 0B3p54OROfNl6fSKuQ89IJnwQLZvJ9BIRckSmJ+iIiM256oMZBRFDDPgEdQI3rfq1l7Stbomas ffpeuIlarle2akh6b2GihexNZ0ybHLjmaj0DfIsBLRIrQYr9wnYo4mD1ySey5FvXIRm4PhXZIa bII= X-SBRS: 5.2 X-MesageID: 40415665 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:EBtb1K3DTN0tXw2AbsaiQAqjBTd3eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/FIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFmtJ1/Z xLN5JzANiYNzVHpO7n/Qi1FMshytGb8KauwdzT1WtpUBsCUcBdxi1SYzzrdnFebg9AGJY/Cd 6g/cJBvTWtYjA6ac68C3kDUYH41qH2vbjhZgMLAANi1RmWgVqTmcPHOjW7/jNbaTNAxr8+7X PI+jaW2oyPu+y2oyWssVP7wI9RnLLau7l+LeyKzvMYMzD9zjuvDb4RIIGqmBAQjKWR5E0xkN /Kyi1QT/hbz3/KZGm6rV/M9mDboU8TwkTvw1OZnnfvyPaRLFlRa7sj9PBkWyDU5EY6sNZ33L gj5RPii7NtAQ7dhyO43tDUVnhR5zuJiEA/mu0ehWE3a/p4VJZtq+UkjSZoOaZFNif75Ic7Kf JpHcHR6d1HGGnqEUzxjy1BxsehUW80GQrDak8eutaN2zwTp3xhyVAErfZv0ksoxdYYcd1p9u 7EOqNnmPVnSdIXV7t0AKMkTdGsAmLAbBrQOAupUBvaPZBCH0iIh4/84b0z6u3vUocP1oEOlJ PIV04dnXIuemr1YPf+nKFjw1ToeiGQTD7twsZR69xSobvnXofmNiWFVRQHj9agmfMCGcfWMs zDea5+MrvGFy/DCIxJ1wrxV915Mn8FSvAYvd49RhagucTOBor2tvHKUfraKbb3eAxUGF/XMz 8mZnzeNc9A5kekVjvTmx7KQU7gfUT54NZRHcHhjq0u4blIErcJnhkeiFy/6M3OAyZFqLYKcE x3J66itqu6oGKx7FvZ9mkBAGsYMm9lpJHbF19arw4DNE35NZwZvc+ERGxU1HybYjhyUt3RCw wag1hs46q4I9ixyEkZepyaG1Pfq0FWiGOBTp8alKHGz9ziYIkEApEvX7E0Mx7KGRxzkQNDs3 xCdwcAe0/aGlrV+OaYpa1RINuaW8h3gQ+tL8IRg2nYr1+gqcYmQWZeYySjSveNgQElRyNdg3 p496N3usvGpR+fbU8ExMgoOlxFb2qaRJZLFh6Maolvlrf3Qw1oVmuRiTuGixY8R3ry+ywp9x /cBBzRXcuOLktWu3he3Kqvyl9ye2mHV29ba3xxs+RGZC/7k0c29dXOSru40mOXZFdH//oUNy vdZyAOZil0wcqs6RKTkDGeNHkvy5k0JNbBBLA7f7y74ALqFKS40YU9W9NE9pdsM97j9tIRWe WEYgmPMXfWDfgq1wH9nAdSBABE7F0f1dXm1x3u4DLmgDoRAf/OLE9nQL9eCdeG9GTgT+uJ1p I8rd9dh5rFDkzBLvq9jYfQZHp/DzmWh0icZeQhs4pVsqI/r6EbJeiSbRL4kFV8mCwjJ8L1nn 4ESKt14Lr9KpZiFvZiDh5xzx4MrpCzN0MlvQz9P/8mcXwsh3HdOcmV47Cgk8tZPmSx4C/5OV yS6ERmjo/4dhrG8b4REKQrJ2tKLGA69XR55euHHregQjmCRqVm/FCgNGW6f6IYYK+ZGa8Iph I/x92TheeYe27Z3w/X1AELb55mwiKCQcmoBhiLFvMN29umOU6Uiq/v2fWNtl7MOHKGQnVdo5 ZEe0wWZtlCjTdnrLRf6FnMdoXH5mQ/k1Vf5jl7kEXKwYbO2haDIX17 X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40415665" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nt3GhNGopzsE2YzTerzZrxwAENTHZOA2BtwDyIC13GHI8g6UneOeJXM83D/uLGATlRC0wJqHXDZWeQIWIL1fLLngqTxWGhephZNQWrcMpdLehv7NDFd+Si4kQJKuAGjN9oS1XRxULMM/nWTnt6eZ7Bgviyxpbk4rq/L8P6+5N9bNWtLpkOvoB3QFwZSoOlfF4K8CcYg6dkOAvsHsFOctDhUMakiHcjV/JYBoMO1goxCuWQl2xP1U5T1A4BhoJMrbzBuvU6lweKXy11m3I++X7s+Kb/bP7eCr4O/twSg2lyDGUQhrX4BJfQm4U3w8sQcKdg9H6wNubDRn0jQ++RBi4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YbLS6BH8MbuCXwxN5xjKUX6UwKmNt7gnMdLP8UFuW2Y=; b=G8Tgtvm72k9EzMB5hH2xb/QvQqmjaG40JxAoQtpeyq6vOjELydrqhjF07xLDLUlVkUWkTJ5uz9UNwhI6FQMGsLGj1x9JDWf6J9n2K/KSFFBZ1CVHfguM450CqmNnxasGh0RtaVwYdswZ88et0g10+D1FnELdPvjZyG3JG+SYMkeCq30vR8slfU+1eTzLrQ6rfudVNQmPy1XjBQ0/LL1trftJrFhcx/PfcQdekz+Tj3ag9xyTYPvp528s0LFeykB0N4OF3ncJNYihDaOipzuP3tzk5NhYR/g5upBO3Od1Jz/y1dmafC/moqyXu/3QYu4GM2a9x5zI9vwLSgnIZJP9yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YbLS6BH8MbuCXwxN5xjKUX6UwKmNt7gnMdLP8UFuW2Y=; b=KEKsVdkyKlVa/Q+s8RzEVvve8vqeAKcPkP8yiGIFTFT6VswAkiX2God7WCHd5S2kQOsBZJrhEnjYNP3+wsctiihkIArWAPRjFel1a9/r4JJ6jwxPOYgQbWY+PVNyu0IjbFcycghLhCa8sW6picM5IGik1ALDVqGYSc7Yi9OheJ8= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v3 05/11] x86/vioapic: switch to use the EOI callback mechanism Date: Wed, 31 Mar 2021 12:32:57 +0200 Message-ID: <20210331103303.79705-6-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210331103303.79705-1-roger.pau@citrix.com> References: <20210331103303.79705-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0163.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::26) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a8063ccd-c7ae-4def-a92f-08d8f430c94c X-MS-TrafficTypeDiagnostic: DM4PR03MB5968: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2331; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /FFoXPnFQtGk3HaQwqeNi3TMIhhfxrj3infJ+2yDmaEOrXF+plMov929zYxyWtUU423JsZL8YDUbjMtLrttS1ikOYJUSQX9CufkYu1wfD482gIdOxm+k9sGZswZ6dClfl6+Cdy78GLyLEivg3vbhSwgUd2wt4RLuMyBwxnRVuvpc1ZGDWscWrqEjyzEsuoBdBqGJbbm1tiHEJi/rXPJ6F6s2SW3IaAqAD4dvwr4LCPLqjfXrkcAlM2ez70AZubdumVqGF9AGj7CSuPyDPRovTV4hn87Dg1hrzXj/xVHQ7j/17HPyYh1kPu6tD8GtpaaCUPmTas22LqGh80NamRVxCD3l6yKqHnPSoU9xbUCyDpY7ug8TGpUiTlStIAQsATXCC0VGIBTh2cwmkhmVi9ulMOxJR/uSkIUfV/HZZ6glbqq37A2ym5iUhuaniMsnMAsAza/mGABs873wJCnAbn2xaAPqfLNshRNUQn6Tu3E60RkmNFoYwGS/i0VxboH/B1lVXbi9+nQKx8xL2VYxv/yFIGUdZJb9zTzwRCvsiakYmfKb27LYx5esXShzRIqZ4CJQSw2UUZqRU5lg3hCnQYMnd/46RCGivqS+0enOkO5Mq+pC0tVtts5uMQaVYVS3WsFWqiEu66jHoMRE5p0dIKsm4dl5qq4sqwno8NEsOFz4yx6YH5a7kGc60TQpjY9hPIeH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(26005)(2906002)(6486002)(8676002)(1076003)(36756003)(38100700001)(8936002)(83380400001)(16526019)(86362001)(186003)(6916009)(6496006)(66556008)(66946007)(478600001)(66476007)(5660300002)(316002)(4326008)(2616005)(6666004)(956004)(54906003)(309714004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?RFpHdnBDbG51MDJ6TEVrSlA3dTltbW1DeDFRdU5qUWxZZFdRMExVOVdZWER4?= =?utf-8?B?eHNCVWxEMXJnTXpKVFF4djl0MFVZYThZenl1djROSDZreGpjNmFaM21GYzlE?= =?utf-8?B?T0IzbldWK0ZxVmlPNXh0U2p6SXBhRnJ4dUo3V2l1d3ZwM3ZOaXZHMzluMGV2?= =?utf-8?B?RDk3aVcvZUo3c01kTzREdktqOWZSYTZIbFp2T3JPdGVSNXdieXlzNlhmVkZk?= =?utf-8?B?ZmFaK2xqUXZkSkVvQzlOU09QV0lsSTFJQ0haSDRKWUhWM0lyODhHRnNHUVVZ?= =?utf-8?B?RnN5eGc0TDVkSXR6aGVuTGZQdDBJcEI1T3M3Nk13NlFva1lJb3Frdml3NDg1?= =?utf-8?B?Rk9XNVNYa0VhWWdROXBwTGFTVXVCR0NXaUJtWkxGUlhjblZROHhiMzBiY0NV?= =?utf-8?B?dC8vdDhsVEN6Y0k4K3RUeUJCTzlWMmwyNTZUNE1GNi9WcEViNGpOK1FwcUFi?= =?utf-8?B?VGFYdkZwS3lZRnFnR0NPSFBhWENvbERCZjdZZzQzMjdzVmpaQmNhcnNqQkJM?= =?utf-8?B?eGl1RzBKdzN1UkYxMDZhNEdZeGJvcVJGbEp0aUZjNDVjd2dxbWFMQ0YrUWsx?= =?utf-8?B?RDFZaDd0VHIrNkRiVFhUNHVnOHJWdkZQRjIzaWg3QTQ4OGt3a01jbzkxMFNv?= =?utf-8?B?K3RSRGpsQjRDdlBMY0ljU3NVZG90VDl5RlA3dTRBdXNmQ3AveEc0Q0xXOExY?= =?utf-8?B?QTJ3a0RMN1BTOVM2YXFJRUtERVE1VjN0NHZuM1I2WnR2ZmltR09tNzdROW80?= =?utf-8?B?TWVQc1BSakx5UWQ3NGpMOTl0RGIveUp3SW5pUFpTQmtXN3IxNjBTNUlkYS9x?= =?utf-8?B?Z1Q1YllSS1d2UEVZY1Y4Q0N6N0RMR2tVRnZGZVFzOEhuenh4YjJVcU1EOXpM?= =?utf-8?B?RGt1Z0dXbG9tbms2c01CbS9Ub0R4R3NIdFdUdXBmaUVpS0RpYW9Wd3o1MzVl?= =?utf-8?B?K2hiU1NSNHJqZXVFY2QyVFVOUTkzRTMzaUNTT0dCaGYyU2JGeUhHeEp1c09t?= =?utf-8?B?R3NiQVlNMmRHNWZuNWlWQ29qWVRoR3d2TVNmQzM5QlZmZ2tuOFEvY0UrZ0ty?= =?utf-8?B?aXpYbGZpVzlyajZuZnBiR1JyYXp2RURCRkZoV2lGajhxRDRFaHROUXBqdlZl?= =?utf-8?B?eHZzMlV6UEMybUVwbC9xZ1Q5MFlTc0xXRXVjU0pyTHFXMGVqbjFSVXpPZFEz?= =?utf-8?B?NjQ1K20vTjZ4N2dYdzkxeks3U1o2bTkvRXU2OGwrYWZ3VWZxWnRld0NjQVNM?= =?utf-8?B?UWxwSGRGc3B6OGhFVTJHVUhJcUNVU0tOMk9ZNm9JaHZRV0lnMUg5a2t1QjVp?= =?utf-8?B?L2tFTWNlaCs3Yjg2c283T0d3Q0xDeTB5L3VLTWFTaUU1a0pkeWtVT2pmS0dl?= =?utf-8?B?UjZIcjU1OHZvcDJDd2lZSldPeXRWSk9pQ2YwUE0rajBRTWhkUGNLUGVSV2pt?= =?utf-8?B?ak5pb3ExYmMxcmd4SCtSeTRKKzVjMS9DODR5eVNXbDJHV3psV2hNcEVxUVVx?= =?utf-8?B?U0RUaHZFUkViSG1Oem52YkdzUlhTWDg2eEM1WlE2UWgzSUs4OURiOFArUitM?= =?utf-8?B?STcrcUJxbXVuWERyREdBVkRBVWFyYzUwNWppNlY4MjFJUjJldXQ2bk8vOEhD?= =?utf-8?B?VGFSTHd4Wms2emtmN0QzK0F2RjBqSERBYUNnekVCQ1h5cC9qbzAxVXErZlFm?= =?utf-8?B?MVEzNmpWL2x3RFllUi9UUDAyL0ZPTFZtb21ucXF6RExZK1V3aDhpRW1KS1lN?= =?utf-8?Q?fBrFuB/atB95mQZWMzdx+OtJ9SQEyWerXsdy3rZ?= X-MS-Exchange-CrossTenant-Network-Message-Id: a8063ccd-c7ae-4def-a92f-08d8f430c94c X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 10:36:04.6593 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bWaxEIV5pDDpgahkbuy9zCxae3GNfBE9cDuQjcyBJeNdzTb9Nx53g8mynf5xb8FaYUIvreKXi3l80ZddvRAKPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5968 X-OriginatorOrg: citrix.com Switch the emulated IO-APIC code to use the local APIC EOI callback mechanism. This allows to remove the last hardcoded callback from vlapic_handle_EOI. Removing the hardcoded vIO-APIC callback also allows to getting rid of setting the EOI exit bitmap based on the triggering mode, as now all users that require an EOI action use the newly introduced callback mechanism. Move and rename the vioapic_update_EOI now that it can be made static. Signed-off-by: Roger Pau Monné --- Changes since v2: - Explicitly convert the last alternative_vcall parameter to a boolean in vlapic_set_irq_callback. Changes since v1: - Remove the triggering check in the update_eoi_exit_bitmap call. - Register the vlapic callbacks when loading the vIO-APIC state. - Reduce scope of ent. --- xen/arch/x86/hvm/vioapic.c | 131 ++++++++++++++++++++++++------------- xen/arch/x86/hvm/vlapic.c | 11 ++-- 2 files changed, 92 insertions(+), 50 deletions(-) diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c index dcc2de76489..d29b6bfdb7d 100644 --- a/xen/arch/x86/hvm/vioapic.c +++ b/xen/arch/x86/hvm/vioapic.c @@ -394,6 +394,50 @@ static const struct hvm_mmio_ops vioapic_mmio_ops = { .write = vioapic_write }; +static void eoi_callback(unsigned int vector, void *data) +{ + struct domain *d = current->domain; + struct hvm_irq *hvm_irq = hvm_domain_irq(d); + unsigned int i; + + ASSERT(has_vioapic(d)); + + spin_lock(&d->arch.hvm.irq_lock); + + for ( i = 0; i < d->arch.hvm.nr_vioapics; i++ ) + { + struct hvm_vioapic *vioapic = domain_vioapic(d, i); + unsigned int pin; + + for ( pin = 0; pin < vioapic->nr_pins; pin++ ) + { + union vioapic_redir_entry *ent = &vioapic->redirtbl[pin]; + + if ( ent->fields.vector != vector ) + continue; + + ent->fields.remote_irr = 0; + + if ( is_iommu_enabled(d) ) + { + spin_unlock(&d->arch.hvm.irq_lock); + hvm_dpci_eoi(vioapic->base_gsi + pin); + spin_lock(&d->arch.hvm.irq_lock); + } + + if ( (ent->fields.trig_mode == VIOAPIC_LEVEL_TRIG) && + !ent->fields.mask && !ent->fields.remote_irr && + hvm_irq->gsi_assert_count[vioapic->base_gsi + pin] ) + { + ent->fields.remote_irr = 1; + vioapic_deliver(vioapic, pin); + } + } + } + + spin_unlock(&d->arch.hvm.irq_lock); +} + static void ioapic_inj_irq( struct hvm_vioapic *vioapic, struct vlapic *target, @@ -407,7 +451,8 @@ static void ioapic_inj_irq( ASSERT((delivery_mode == dest_Fixed) || (delivery_mode == dest_LowestPrio)); - vlapic_set_irq(target, vector, trig_mode); + vlapic_set_irq_callback(target, vector, trig_mode, + trig_mode ? eoi_callback : NULL, NULL); } static void vioapic_deliver(struct hvm_vioapic *vioapic, unsigned int pin) @@ -514,50 +559,6 @@ void vioapic_irq_positive_edge(struct domain *d, unsigned int irq) } } -void vioapic_update_EOI(unsigned int vector) -{ - struct domain *d = current->domain; - struct hvm_irq *hvm_irq = hvm_domain_irq(d); - union vioapic_redir_entry *ent; - unsigned int i; - - ASSERT(has_vioapic(d)); - - spin_lock(&d->arch.hvm.irq_lock); - - for ( i = 0; i < d->arch.hvm.nr_vioapics; i++ ) - { - struct hvm_vioapic *vioapic = domain_vioapic(d, i); - unsigned int pin; - - for ( pin = 0; pin < vioapic->nr_pins; pin++ ) - { - ent = &vioapic->redirtbl[pin]; - if ( ent->fields.vector != vector ) - continue; - - ent->fields.remote_irr = 0; - - if ( is_iommu_enabled(d) ) - { - spin_unlock(&d->arch.hvm.irq_lock); - hvm_dpci_eoi(vioapic->base_gsi + pin); - spin_lock(&d->arch.hvm.irq_lock); - } - - if ( (ent->fields.trig_mode == VIOAPIC_LEVEL_TRIG) && - !ent->fields.mask && !ent->fields.remote_irr && - hvm_irq->gsi_assert_count[vioapic->base_gsi + pin] ) - { - ent->fields.remote_irr = 1; - vioapic_deliver(vioapic, pin); - } - } - } - - spin_unlock(&d->arch.hvm.irq_lock); -} - int vioapic_get_mask(const struct domain *d, unsigned int gsi) { unsigned int pin = 0; /* See gsi_vioapic */ @@ -611,6 +612,8 @@ static int ioapic_save(struct vcpu *v, hvm_domain_context_t *h) static int ioapic_load(struct domain *d, hvm_domain_context_t *h) { struct hvm_vioapic *s; + unsigned int i; + int rc; if ( !has_vioapic(d) ) return -ENODEV; @@ -621,7 +624,43 @@ static int ioapic_load(struct domain *d, hvm_domain_context_t *h) d->arch.hvm.nr_vioapics != 1 ) return -EOPNOTSUPP; - return hvm_load_entry(IOAPIC, h, &s->domU); + rc = hvm_load_entry(IOAPIC, h, &s->domU); + if ( rc ) + return rc; + + for ( i = 0; i < ARRAY_SIZE(s->domU.redirtbl); i++ ) + { + const union vioapic_redir_entry *ent = &s->domU.redirtbl[i]; + unsigned int vector = ent->fields.vector; + unsigned int delivery_mode = ent->fields.delivery_mode; + struct vcpu *v; + + /* + * Add a callback for each possible vector injected by a redirection + * entry. + */ + if ( vector < 16 || !ent->fields.remote_irr || + (delivery_mode != dest_LowestPrio && delivery_mode != dest_Fixed) ) + continue; + + for_each_vcpu ( d, v ) + { + struct vlapic *vlapic = vcpu_vlapic(v); + + /* + * NB: if the vlapic registers were restored before the vio-apic + * ones we could test whether the vector is set in the vlapic IRR + * or ISR registers before unconditionally setting the callback. + * This is harmless as eoi_callback is capable of dealing with + * spurious callbacks. + */ + if ( vlapic_match_dest(vlapic, NULL, 0, ent->fields.dest_id, + ent->fields.dest_mode) ) + vlapic_set_callback(vlapic, vector, eoi_callback, NULL); + } + } + + return 0; } HVM_REGISTER_SAVE_RESTORE(IOAPIC, ioapic_save, ioapic_load, 1, HVMSR_PER_DOM); diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index 10b216345a7..63fa3780767 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -192,7 +192,13 @@ void vlapic_set_irq_callback(struct vlapic *vlapic, uint8_t vec, uint8_t trig, if ( hvm_funcs.update_eoi_exit_bitmap ) alternative_vcall(hvm_funcs.update_eoi_exit_bitmap, target, vec, - trig || callback); + /* + * NB: need to explicitly convert to boolean to avoid + * truncation wrongly result in false begin reported + * for example when the pointer sits on a page + * boundary. + */ + !!callback); if ( hvm_funcs.deliver_posted_intr ) alternative_vcall(hvm_funcs.deliver_posted_intr, target, vec); @@ -496,9 +502,6 @@ void vlapic_handle_EOI(struct vlapic *vlapic, u8 vector) unsigned long flags; unsigned int index = vector - 16; - if ( vlapic_test_vector(vector, &vlapic->regs->data[APIC_TMR]) ) - vioapic_update_EOI(vector); - spin_lock_irqsave(&vlapic->callback_lock, flags); callback = vlapic->callbacks[index].callback; vlapic->callbacks[index].callback = NULL; -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 31 10:36:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 10:36:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103842.198079 (Exim 4.92) (envelope-from ) id 1lRYCw-0004yi-Id; Wed, 31 Mar 2021 10:36:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103842.198079; Wed, 31 Mar 2021 10:36:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYCw-0004yV-EX; Wed, 31 Mar 2021 10:36:18 +0000 Received: by outflank-mailman (input) for mailman id 103842; Wed, 31 Mar 2021 10:36:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYCu-0004un-Jc for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 10:36:16 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0d4ff5b2-d862-48a5-b582-cb48b6cd8810; Wed, 31 Mar 2021 10:36:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d4ff5b2-d862-48a5-b582-cb48b6cd8810 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617186974; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=Y/QS2yMljZx17JZ183drY6zkAree+xKrpiH8jux6JWw=; b=frG6LJDBgyiknhOAFavKyQNVbCg4SzbvVd7Db3SMNzAsJf41s5tdWzm1 6ePPHcREa6ltcdlSd5wjWiiH1QvWVrgEVJ27BQyxwvowzvd8xH9tA6u59 c9AXv05tb+ypfSyvyY/XdbIWdBEIptOPprQdQE7PFlie/C8z6hMJ7T/UF U=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: wWmy6Mt5kFaKYZEc499ziIdusaUiSobP3sHa3PeByLPZx7RFckDtP7NUK6rsB5rR5Z01MDGYQn gDQlTMyVMP69+9Mfr0zoBq74ygorLD6xSzW/9ZbMiGDr+OkLTmpxhrj+jw/Y6uQAzeR6dZLfbT vbXmXKBCoz2bxbMvqH/DnG92SvXZZMKkaWQWL274dsQCPjy/SMC121m244ebIGsRI/qzIFamTS J59KP3hZzZy6dt3Dzgai2iiqY5aw8tFiXwRH2HdCDDnPqLzpACyPkFnfKNbh9JWH9DHkAIEcA1 B8A= X-SBRS: 5.2 X-MesageID: 40688166 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:s/AwqaMhpKSL4sBcTxv155DYdL4zR+YMi2QD/1xtSBBTb8yTn9 2vmvNe7hPvlDMNQhgb9OyoEq+GXH/a6NpJ8ZAcVI3SOTXOlUmJCMVZ7YXkyyD9ACGWzIRg/I ppbqQWMrLNJHdgi8KS2meFOvIB5PXCz6yyn+fZyB5WPGNXQoVt9R1wBAreMmAefml7LKE0Hp ad+cZLzgDIERgqR/+2G2UfWKz7r8DL/aiMXTc9GxUl5AOS5AnYi4LSLh7w5HYjegIK+5gO2y zvkwv15qKs2svLsCP05ivowLl93PfkwttHLsSQhsYSMSWEsHfUWK1RH4eskRpwjOaz6Es7sN SkmWZdA+1Dr0n/U0vwgRzx1xLu2DwjgkWStmOwsD/YjuHSABcZYvAx4b5xQ1/ixGcL+OxY6u Zt2VmUspJGZCmw5BjV1pzzeDxB0navrWFKq591s1VvFbEwRZV2toIl8EZcAP47bVnHwbFiKu VoAc3GjcwmF2+yXjTctmlr9tSmQm4+KBeAWlQDocyYyVFt7QlE83c= X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40688166" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WlGG0Y9eRKNseB7+FnHBhySa15xNxP1ETh0dmMygh9ngtLp5nSKdmj7aykCBQbMdgfQI/ziNLQdjo3ALGF2VpvGF5p1zvEivl+1XBGAGnY7UZhY/LfG6N2O5Tr3wBDNtXttN8WjW0MbcXgpPzLStP5gxYQEEJpXnVh44cZrT3lyFrr/YmHmBQxl4uCZkpDSaCvnu2rLxqkMsZSTOMKHyT2Z54b710Cf9fnKZCDUbcyOA2iDjP3pKK2D+eSzPYjn/MreAT4TnbFZSp4rXklqljHehIVClO15YjorL7ULHnxW7ppXYPOQw5kIyIz375u6bmT5lYBmiLlXV80Y8zzX63A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E6xRU0mfdtEd9NzCqYmTFj08AUSTIGMnJkukMnC1rB0=; b=h40QaFppjkYOH9/yXCkyL04aJz/Vc+a8fvLYNJxS0AROE0Y48opzIKeNE1P2pOeM7EqhUF/hsNi56KLZZB1l21RDYtQrKtVinY4drGq0u1GFOsD5wynFAeb7b4u4dWYieW63X5SNdwuPiPQBoDD7z7cPmT8aL50wDyHIhVa+4JdeDhdl3o3cJZGEE8qriLfyA7CWsrkQcdThyHXqvW67H/3rQkNqYrQOT6rqodhFvQvrryHI1OAQNAk5u5vy00kp4UZpE0r99DdXddnvr8D54OzsFtf2EmkhxSjmz7KCNSwekV7fJEMKcRBYrhIJaCF3Lz7QtQWVidzlEKaY1HsAdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E6xRU0mfdtEd9NzCqYmTFj08AUSTIGMnJkukMnC1rB0=; b=eSKxUZIS2qix+6UTgILv27HcsYKC0RwN7Zs0VMjBKp15yGVcusXYO+1fWO/kI2DNkxR47JXl9GtanWeCfPfvux7M7HE1A4Mdf3Takd3BjZ3Gto1jvw73/XKO4WF6PYINj2HovNmQm4l+IWcA/4ctSeH+J5PlJQX4HMLUM1c+oKM= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v3 06/11] x86/hvm: allowing registering EOI callbacks for GSIs Date: Wed, 31 Mar 2021 12:32:58 +0200 Message-ID: <20210331103303.79705-7-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210331103303.79705-1-roger.pau@citrix.com> References: <20210331103303.79705-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0102.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1f54b22c-0caf-468c-47da-08d8f430cd47 X-MS-TrafficTypeDiagnostic: DM4PR03MB5968: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qV69vlMrlqyZ5belblE9aRTkOBzKR54r4QshrMwQWAeb2G4R638+S7LgF3CJAacPm7363t9nwMXV+kmwsKPYUcDwYhcspGqllPHB2xnYDfnJJX45e8YDQnE3+tuoLhDZDmENUjGYitaK+IdM2K65P02P4xQgRavU5UedA6jfFgzm+s8Cp0HpgNI+HSBt2gW+80lLHe/FzZcKy/kFDdz0IaxJmlPGtbU5lqXlArMNjUTnVm/IIhzj8xXgtymgJFO3PLrle/wKe/oH07knbTlnEFmuRNdB6+++3FD7wIgcS+vgtlLNZkCsXnyTzIFoQvmr515j1t8YuRSlAMnRQxsE5IjjlyooBl9OslXkIsGz0akvPEBk7P0IWwpRK/gWWNtg0sx/n2OVJsFdPYfXbZUTlkzv3nbp/nQfxPG7nEt314rvCzBcN3GPzVFZFyB8GZnwnMf9jqbYV2XqkPGOQB91Lk3kTc2JX02FC5AVwDwgyWokymRBld7x1jOeWq4yKRDZi0e4jC9mtjEbP839NBMXqYBsxluknwOgLGAlHHQ/eHh35+iquYq3wUT8EXYVVdB4lmBex73pvS7v9wylGlqKVnOIs70NFViv2pUHSyFoDr38D9FwLbNExjyuMjLIzZ7K9EggGhDX9Cc5yudQGycwqbI8klMMtlJY9eR4E6GNC1M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(26005)(2906002)(6486002)(30864003)(8676002)(1076003)(36756003)(38100700001)(8936002)(83380400001)(16526019)(86362001)(186003)(6916009)(6496006)(66556008)(66946007)(478600001)(66476007)(5660300002)(316002)(4326008)(2616005)(6666004)(956004)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?RTZuZFlMc0RtUWdvRjBubXU3bGc5V0dkUlVVYTlaRTBURDdPZGhnYmxtb1ov?= =?utf-8?B?YlRaSENZeDFnd2VQUWJBcXFLdGpMcTBuMnBTMW9XMXRkS2xVQUdTdHh1cklC?= =?utf-8?B?UGovd0tTR25mdDZCZEJKdG5EdjYxVUI5REJGOGgxVmMzcWFQdjB1dlVveEtX?= =?utf-8?B?dHhOZzVxa2lFRGM5OFQ1T2dFWkNQQUJVTFoxYU9oRExlNy9xOXg2QmFmZC9s?= =?utf-8?B?N0tTZlZOM3VRdUt6VTR4UExSMElTWXFmRlF2c2VpVVo5QUREbVZSUVJlc0U4?= =?utf-8?B?OTZpNUJwQXVnQTZ5d2JTd3VldWJIblByZmp3OGQ2OCtHS0FsNkt4eVN4Ri8w?= =?utf-8?B?Q0hwUDJ5SnAxaXJ4SlgxVE9adTNiZHhvRzZ3dVN0dFA1WWpDa2ttWjF0dUVP?= =?utf-8?B?Qi9UL2NjUUtneE9SYkNWQ2lGSk42cHlTWS94RGkzZElZTlhhN1lJakc5T3hN?= =?utf-8?B?NWFvMDRHT0FrNnZCT1hvVytxamNFVktBbWVVUTNjMWpJRGlmYkczeHdWRmJs?= =?utf-8?B?Sm1WQ3RRaUpNcEVhc3RTMGhBZitMbEsrOEo4UnhodUpyR21lWE1CU1Q2U2ZU?= =?utf-8?B?U0V5dlBlQ2xvcFVqWEpaSFo5S1JjaVBMOC8raWNXQWVXVURoVlpxdnh5OElX?= =?utf-8?B?ekd5cis2dWlKMTNkUjYrSVVPZXVlYk9nVzRyY2Q5TkhsOTRURTg0dGRGZWg5?= =?utf-8?B?eU5XRVZRek9jQWJOd2hRYWZnQmJyY0JMUER5ajhVVURLY2l6QWtLeHZML2FY?= =?utf-8?B?ZkM1L1N2cmJMYWNxZUFHR3RGWFoyVDNwVUtEYVl3UzArdWRGYUJDeEJFU0dl?= =?utf-8?B?di9KQ1JHZEtDeTNtSkZKcFFOYlVaVFRYVUc5WVlOZ01mMkErTktaMUJFd2xm?= =?utf-8?B?WUFoejJTMytYMzhhTER5cWRxc3ozTmlIMWJMQlMyREU5R2hmbVFMN2hsSHkv?= =?utf-8?B?U1V3R0JUT05jRnUzMnBBbVBWRWd3djBqOHNaM09OQkMyVFBBRGE2d01qMmxV?= =?utf-8?B?VStTdWJ6dzNBNWFOTWU4VDZPbHQ3NERWYkV0Wk1hbElxdjlNWjd4SzQ1T1k0?= =?utf-8?B?UjlKN2NHR2VZREZEUkQ2b1hVWXYvajZodW90M3pPZlhTVHlkKzBpV2UwaVdy?= =?utf-8?B?aUVkS01HYjlyeWE4VHdVUnFqRUdBSjJTa1o1UGs4WFNycUJwaG9oZUxrb0Mw?= =?utf-8?B?WHpha3FFSlY3MkJLSmpyNE51QWs2cEp0anRMVnkrSExyRFloaTBXNmltcTlR?= =?utf-8?B?VXc5MWNialJxQi9MWWozRWJzWEE2WnJvWVBuMFFGUGthOVJPbExaZWd0RDkr?= =?utf-8?B?aFd0eUdlU2lGN3N1eXQ3Mzl1cGh5Zkd1ZEUvVTBZekExSzF2UkRMZHVlNXRl?= =?utf-8?B?VlBjRGtwTi9uaWpzeHZ3emc3MWlnMi9MLzFNWmtTb2NMMGtMTmh2MDhTRUV1?= =?utf-8?B?OHpqWHVvSlExdkw5b3Y2OHlrcytWTmNnWmlaUW4rcTg5citmZHRKMFVXdWMz?= =?utf-8?B?SytGaGd3SHJvRGNwR3pmU21VZVRYWGdLTmQrSXlFNjNrbDhiNU1HVVZ5bkJt?= =?utf-8?B?M1RxOHBLNzl3QUNYcnp3US82OFlvSXFaTnNQWlVxM1F0em9VVldzRUpSSkI4?= =?utf-8?B?dmJUQUxDYklQOE5CelZ3U2RIRWlLdENaRHluSkpGT1lkREx2UGNHb2VISTZu?= =?utf-8?B?SWRGck5vVVl0K0dPaVAxVGgwRDVhekdYUE8zUEhlbmdJK1pPQ0pLYlNIcWdm?= =?utf-8?Q?P7FstRd3Ho00txK3cYkfJMFr1zbBPN4FAl6GSf5?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1f54b22c-0caf-468c-47da-08d8f430cd47 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 10:36:11.3399 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bzdZ8MiIPU753/8ugFMbGJJ/81w6i/f97lWoooA+4q4+OFsADL4AQZp523tqyFxZOLqNkHzAuzfVWnZ9HckujA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5968 X-OriginatorOrg: citrix.com Such callbacks will be executed once a EOI is performed by the guest, regardless of whether the interrupts are injected from the vIO-APIC or the vPIC, as ISA IRQs are translated to GSIs and then the corresponding callback is executed at EOI. The vIO-APIC infrastructure for handling EOIs is build on top of the existing vlapic EOI callback functionality, while the vPIC one is handled when writing to the vPIC EOI register. Note that such callbacks need to be registered and de-registered, and that a single GSI can have multiple callbacks associated. That's because GSIs can be level triggered and shared, as that's the case with legacy PCI interrupts shared between several devices. Strictly speaking this is a non-functional change, since there are no users of this new interface introduced by this change. Signed-off-by: Roger Pau Monné --- Changes since v2: - Latch hvm_domain_irq in some functions. - Make domain parameter of hvm_gsi_has_callbacks const. - Add comment about dropping the lock around the hvm_gsi_execute_callbacks call. - Drop change to ioapic_load. Changes since v1: - New in this version. --- xen/arch/x86/hvm/hvm.c | 15 ++++++++- xen/arch/x86/hvm/irq.c | 63 +++++++++++++++++++++++++++++++++++ xen/arch/x86/hvm/vioapic.c | 29 ++++++++++++---- xen/arch/x86/hvm/vpic.c | 5 +++ xen/include/asm-x86/hvm/irq.h | 20 +++++++++++ 5 files changed, 125 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index e7bcffebc49..0279014e66e 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -608,7 +608,7 @@ static int hvm_print_line( int hvm_domain_initialise(struct domain *d) { - unsigned int nr_gsis; + unsigned int nr_gsis, i; int rc; if ( !hvm_enabled ) @@ -655,6 +655,14 @@ int hvm_domain_initialise(struct domain *d) BUILD_BUG_ON(NR_HVM_DOMU_IRQS < NR_ISAIRQS); ASSERT(hvm_domain_irq(d)->nr_gsis >= NR_ISAIRQS); + /* Initialize the EOI callback list. */ + hvm_domain_irq(d)->gsi_callbacks = xmalloc_array(struct list_head, nr_gsis); + if ( !hvm_domain_irq(d)->gsi_callbacks ) + goto fail1; + rwlock_init(&hvm_domain_irq(d)->gsi_callbacks_lock); + for ( i = 0; i < nr_gsis; i++ ) + INIT_LIST_HEAD(&hvm_domain_irq(d)->gsi_callbacks[i]); + /* need link to containing domain */ d->arch.hvm.pl_time->domain = d; @@ -714,6 +722,8 @@ int hvm_domain_initialise(struct domain *d) fail1: if ( is_hardware_domain(d) ) xfree(d->arch.hvm.io_bitmap); + if ( hvm_domain_irq(d) ) + XFREE(hvm_domain_irq(d)->gsi_callbacks); XFREE(d->arch.hvm.params); XFREE(d->arch.hvm.irq); fail0: @@ -776,6 +786,9 @@ void hvm_domain_destroy(struct domain *d) vioapic_deinit(d); XFREE(d->arch.hvm.pl_time); + + if ( hvm_domain_irq(d) ) + XFREE(hvm_domain_irq(d)->gsi_callbacks); XFREE(d->arch.hvm.irq); list_for_each_safe ( ioport_list, tmp, &d->arch.hvm.g2m_ioport_list ) diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c index 38ac5fb6c7c..b9fa8409b9e 100644 --- a/xen/arch/x86/hvm/irq.c +++ b/xen/arch/x86/hvm/irq.c @@ -595,6 +595,69 @@ int hvm_local_events_need_delivery(struct vcpu *v) return !hvm_interrupt_blocked(v, intack); } +int hvm_gsi_register_callback(struct domain *d, unsigned int gsi, + struct hvm_gsi_eoi_callback *cb) +{ + struct hvm_irq *hvm_irq = hvm_domain_irq(d); + + if ( gsi >= hvm_irq->nr_gsis ) + { + ASSERT_UNREACHABLE(); + return -EINVAL; + } + + write_lock(&hvm_irq->gsi_callbacks_lock); + list_add(&cb->list, &hvm_irq->gsi_callbacks[gsi]); + write_unlock(&hvm_irq->gsi_callbacks_lock); + + return 0; +} + +void hvm_gsi_unregister_callback(struct domain *d, unsigned int gsi, + struct hvm_gsi_eoi_callback *cb) +{ + struct hvm_irq *hvm_irq = hvm_domain_irq(d); + const struct list_head *tmp; + + if ( gsi >= hvm_irq->nr_gsis ) + { + ASSERT_UNREACHABLE(); + return; + } + + write_lock(&hvm_irq->gsi_callbacks_lock); + list_for_each ( tmp, &hvm_irq->gsi_callbacks[gsi] ) + if ( tmp == &cb->list ) + { + list_del(&cb->list); + break; + } + write_unlock(&hvm_irq->gsi_callbacks_lock); +} + +void hvm_gsi_execute_callbacks(unsigned int gsi) +{ + struct hvm_irq *hvm_irq = hvm_domain_irq(current->domain); + struct hvm_gsi_eoi_callback *cb; + + read_lock(&hvm_irq->gsi_callbacks_lock); + list_for_each_entry ( cb, &hvm_irq->gsi_callbacks[gsi], list ) + cb->callback(gsi, cb->data); + read_unlock(&hvm_irq->gsi_callbacks_lock); +} + +bool hvm_gsi_has_callbacks(const struct domain *d, unsigned int gsi) +{ + struct hvm_irq *hvm_irq = hvm_domain_irq(d); + bool has_callbacks; + + read_lock(&hvm_irq->gsi_callbacks_lock); + has_callbacks = !list_empty(&hvm_irq->gsi_callbacks[gsi]); + read_unlock(&hvm_irq->gsi_callbacks_lock); + + return has_callbacks; +} + static void irq_dump(struct domain *d) { struct hvm_irq *hvm_irq = hvm_domain_irq(d); diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c index d29b6bfdb7d..099c29466ba 100644 --- a/xen/arch/x86/hvm/vioapic.c +++ b/xen/arch/x86/hvm/vioapic.c @@ -285,6 +285,7 @@ static void vioapic_write_redirent( ASSERT(prev_level); ASSERT(!top_word); hvm_dpci_eoi(gsi); + hvm_gsi_execute_callbacks(gsi); } if ( is_hardware_domain(d) && unmasked ) @@ -412,6 +413,7 @@ static void eoi_callback(unsigned int vector, void *data) for ( pin = 0; pin < vioapic->nr_pins; pin++ ) { union vioapic_redir_entry *ent = &vioapic->redirtbl[pin]; + unsigned int gsi = vioapic->base_gsi + pin; if ( ent->fields.vector != vector ) continue; @@ -421,13 +423,25 @@ static void eoi_callback(unsigned int vector, void *data) if ( is_iommu_enabled(d) ) { spin_unlock(&d->arch.hvm.irq_lock); - hvm_dpci_eoi(vioapic->base_gsi + pin); + hvm_dpci_eoi(gsi); spin_lock(&d->arch.hvm.irq_lock); } + /* + * Callbacks don't expect to be executed with any lock held, so + * drop the lock that protects the vIO-APIC fields from changing. + * + * Note that the redirection entry itself cannot go away, so upon + * retaking the lock we only need to avoid making assumptions on + * redirection entry field values (ie: recheck the IRR field). + */ + spin_unlock(&d->arch.hvm.irq_lock); + hvm_gsi_execute_callbacks(gsi); + spin_lock(&d->arch.hvm.irq_lock); + if ( (ent->fields.trig_mode == VIOAPIC_LEVEL_TRIG) && !ent->fields.mask && !ent->fields.remote_irr && - hvm_irq->gsi_assert_count[vioapic->base_gsi + pin] ) + hvm_irq->gsi_assert_count[gsi] ) { ent->fields.remote_irr = 1; vioapic_deliver(vioapic, pin); @@ -443,7 +457,8 @@ static void ioapic_inj_irq( struct vlapic *target, uint8_t vector, uint8_t trig_mode, - uint8_t delivery_mode) + uint8_t delivery_mode, + bool callback) { HVM_DBG_LOG(DBG_LEVEL_IOAPIC, "irq %d trig %d deliv %d", vector, trig_mode, delivery_mode); @@ -452,7 +467,7 @@ static void ioapic_inj_irq( (delivery_mode == dest_LowestPrio)); vlapic_set_irq_callback(target, vector, trig_mode, - trig_mode ? eoi_callback : NULL, NULL); + callback ? eoi_callback : NULL, NULL); } static void vioapic_deliver(struct hvm_vioapic *vioapic, unsigned int pin) @@ -466,6 +481,7 @@ static void vioapic_deliver(struct hvm_vioapic *vioapic, unsigned int pin) struct vlapic *target; struct vcpu *v; unsigned int irq = vioapic->base_gsi + pin; + bool callback = trig_mode || hvm_gsi_has_callbacks(d, irq); ASSERT(spin_is_locked(&d->arch.hvm.irq_lock)); @@ -492,7 +508,8 @@ static void vioapic_deliver(struct hvm_vioapic *vioapic, unsigned int pin) target = vlapic_lowest_prio(d, NULL, 0, dest, dest_mode); if ( target != NULL ) { - ioapic_inj_irq(vioapic, target, vector, trig_mode, delivery_mode); + ioapic_inj_irq(vioapic, target, vector, trig_mode, delivery_mode, + callback); } else { @@ -507,7 +524,7 @@ static void vioapic_deliver(struct hvm_vioapic *vioapic, unsigned int pin) for_each_vcpu ( d, v ) if ( vlapic_match_dest(vcpu_vlapic(v), NULL, 0, dest, dest_mode) ) ioapic_inj_irq(vioapic, vcpu_vlapic(v), vector, trig_mode, - delivery_mode); + delivery_mode, callback); break; case dest_NMI: diff --git a/xen/arch/x86/hvm/vpic.c b/xen/arch/x86/hvm/vpic.c index a69aecad912..ca484c31b6a 100644 --- a/xen/arch/x86/hvm/vpic.c +++ b/xen/arch/x86/hvm/vpic.c @@ -235,6 +235,8 @@ static void vpic_ioport_write( unsigned int pin = __scanbit(pending, 8); ASSERT(pin < 8); + hvm_gsi_execute_callbacks( + hvm_isa_irq_to_gsi((addr >> 7) ? (pin | 8) : pin)); hvm_dpci_eoi(hvm_isa_irq_to_gsi((addr >> 7) ? (pin | 8) : pin)); __clear_bit(pin, &pending); } @@ -284,8 +286,11 @@ static void vpic_ioport_write( /* Release lock and EOI the physical interrupt (if any). */ vpic_update_int_output(vpic); vpic_unlock(vpic); + hvm_gsi_execute_callbacks( + hvm_isa_irq_to_gsi((addr >> 7) ? (pin | 8) : pin)); hvm_dpci_eoi(hvm_isa_irq_to_gsi((addr >> 7) ? (pin | 8) : pin)); return; /* bail immediately */ + case 6: /* Set Priority */ vpic->priority_add = (val + 1) & 7; break; diff --git a/xen/include/asm-x86/hvm/irq.h b/xen/include/asm-x86/hvm/irq.h index 07b1ab99cd1..0828c01dd18 100644 --- a/xen/include/asm-x86/hvm/irq.h +++ b/xen/include/asm-x86/hvm/irq.h @@ -21,6 +21,7 @@ #ifndef __ASM_X86_HVM_IRQ_H__ #define __ASM_X86_HVM_IRQ_H__ +#include #include #include @@ -79,6 +80,10 @@ struct hvm_irq { struct hvm_irq_dpci *dpci; + /* List of callbacks for GSI EOI events. Protected by irq_lock. */ + struct list_head *gsi_callbacks; + rwlock_t gsi_callbacks_lock; + /* * Number of wires asserting each GSI. * @@ -138,6 +143,13 @@ struct hvm_gmsi_info { bool posted; /* directly deliver to guest via VT-d PI? */ }; +typedef void hvm_gsi_eoi_callback_t(unsigned int gsi, void *data); +struct hvm_gsi_eoi_callback { + hvm_gsi_eoi_callback_t *callback; + void *data; + struct list_head list; +}; + struct hvm_girq_dpci_mapping { struct list_head list; uint8_t bus; @@ -225,4 +237,12 @@ void hvm_set_callback_via(struct domain *d, uint64_t via); struct pirq; bool hvm_domain_use_pirq(const struct domain *, const struct pirq *); +int hvm_gsi_register_callback(struct domain *d, unsigned int gsi, + struct hvm_gsi_eoi_callback *cb); +void hvm_gsi_unregister_callback(struct domain *d, unsigned int gsi, + struct hvm_gsi_eoi_callback *cb); +/* data is an opaque blob to pass to the callback if it has no private data. */ +void hvm_gsi_execute_callbacks(unsigned int gsi); +bool hvm_gsi_has_callbacks(const struct domain *d, unsigned int gsi); + #endif /* __ASM_X86_HVM_IRQ_H__ */ -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 31 10:36:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 10:36:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103852.198091 (Exim 4.92) (envelope-from ) id 1lRYD9-00059Q-6P; Wed, 31 Mar 2021 10:36:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103852.198091; Wed, 31 Mar 2021 10:36:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYD9-00059H-35; Wed, 31 Mar 2021 10:36:31 +0000 Received: by outflank-mailman (input) for mailman id 103852; Wed, 31 Mar 2021 10:36:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYD7-0004un-G9 for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 10:36:29 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4ebcf666-c292-4331-921a-0c4d40323d28; Wed, 31 Mar 2021 10:36:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ebcf666-c292-4331-921a-0c4d40323d28 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617186980; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=G6eLB2/DpmPMrCYF/OQauXM9+ZdnMyF85mx9b/zikNE=; b=Gk6GOavTncp8Q66d8nLbHVDTxWR8uAQaBksnFFUqhnYOpjg/6LeSQ2+6 ozCDHdc8shkOkR+oAFx5r87B49Mk/vaY6Wyw1J71xrCpssTGB67Rmrl6U Al33v4pEadg/1LT9bNgx0vaNjsDPzSnRVmixDpWJx/6fs71kO7/yUhUYr M=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: WyPNu5IIhJ6yPNAk93xEijNLhrSkvJsFi68KvRM7XH5BvO/FoNqLy88K0wesJMofLw+OwMWiv0 fqQ2j+5QKHI0J28RD1mXb2u+wvB9ho+DRvMgSbXHpqO/D3M77KEvDV+15TvAAktxIeM+9G522y x2RmiKswoH+DPdFLSW82EtWrE4xNIiFQFmPPFV8ZEK8Jf2YvwJVZvbcDgP1hHni4eyEPDO0Cx2 zuB+R6bYEKdAy46HyZwx/ZS74YR9t5W1T31VWUAHFhnTXbU19rMdAufMn1D1zryctxr+0gSBY6 Izo= X-SBRS: 5.2 X-MesageID: 40545499 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:9NCh2KrpzMv1gt5H5O1PZCoaV5vxL9V00zAX/kB9WHVpW+SFis Gjm+ka3xfoiDAXHEotg8yEJbPoex7h3LRy5pQcOqrnYRn+tAKTXeRfxKbB4xmlIS3x8eZByb xtGpIVNPTcBUV35PyU3CCWCNAlqePozImNpcPzi0hgVhtrbaYI1XYaNi++HldtTAdLQboVfa D92uN9qzCteWsaY62AbxFoY8H5q8DWj5WjWBYaBnccgzWmty+i67LxDnGjr3Qjeg5IqI1CzU H11zbXy4/mmPG9xx/a2Qbonu5rseqk8PRvLoihjsAULx/llwqnYp9wMofywQwdkaWUx3sB1P XKvhc8L+R/gkmhAl2dkF/W9CTLlBYo9nP4xleTjRLY0LPEbQN/MeVtr8Z9UHLimi4dleA56o 1n9SalkqASKhX6kCH097HzJmlXv3vxm1UOu6oulXBFOLFuD4N5nMgk025+NowPJy7+4JBPKp gUMOjsoMxbdl6XdBnizw9S6e3pWnwyGyGPSVQZtvqU1CBLnGt4w1Fw/r1noks9 X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40545499" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O6R1bRtfnaMG1VyI6gla0ZC2OzHY9+J0GJhXzmaZVnDwvyCumRpjoCwxecgK5cyRVoG5sEyakI0U/Uw3F8PLnKC6ZKToj023GioXMOeY4D68Kie9kqxSfcbfy/Wnw2wrHeSyA7umDsnWUN2fwREd17yTB+Mulyf375zHAMPuQYKRsCZrsfgY0IgwLdOWMhnn+0XIRBl6LpB2dU367l+jalr+l5c5I+32C4rMnOzb2cYWnHXXNDUtwbQ7PtJkC1qzvvrCSZzFYgwLB0EUtpCXeXDEAQt4HSeyzS3peC/miRSQRF5TkuoA+YLswwfZzsbdRuaB7GRTF7Q9E96FVyz3iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ATUqzH1qQW24zHt8gWyGrgI3bjAA4vJXVL7l6nZ/QcQ=; b=i0zitUg0x3h3G4KEIQccro8tRY/Y13rHr3eqY7E0bfTha1jkjzm68N3owC5tRz4FxGDVdOhRAs+S4CHIkvY2dKipNWHBGEFhb5yKRacmAht4O4WJgXv7enJBkGCsneHVXHtaxgZdqcPFZ7u6FhhcI9sNlkLMQcBgtYA6nmRdGO4WdAFootLvzyIcAJvCD++exqYhPd4zt3C/65ZswDHZslZh3M0OjifEK0tzfQvmQhyKQzzznudziENJa1XyPoK41PisEpjdEwBtxbM7BJHU3sBithCy21urXzNEPtBtoSA4f5dUsZnIyD68EfWs4KnOl9L6UujWkLfeJnxJ0O3v8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ATUqzH1qQW24zHt8gWyGrgI3bjAA4vJXVL7l6nZ/QcQ=; b=K8+tiS5EvbJovhv80DDTBKu1pmFYZ447Vfjgxo912QYn/dl44ugnRKOmMSuEADja8c0vY0BzoFOJhLGsK0uD41nFygR01MpPRhFMi+CpUMH3rDXPEUO+fT+y2hvxel072gnuU2j6PeiBYMttuBch1L5XSLLPBhzgna7WzQw8iAw= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Paul Durrant Subject: [PATCH v3 07/11] x86/dpci: move code Date: Wed, 31 Mar 2021 12:32:59 +0200 Message-ID: <20210331103303.79705-8-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210331103303.79705-1-roger.pau@citrix.com> References: <20210331103303.79705-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0100.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::16) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c6df4d8-d138-4cce-6bed-08d8f430d099 X-MS-TrafficTypeDiagnostic: DM4PR03MB5968: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JuB7cRfgXRCIY6UngSzwRfzM60q+bvW2x9w7sWLbpN4OpNf2ezFPfDOu5EwkK5PxFtv+NhNzpWE9V4uwkv/UbJ74DYjut67yDyLYg1Myv++YaaTdSWScMYUKLZjYM66eEBjRHF3xW+Opej9MU2N39wfpmVia1YoPKK7pvw19hfEZTe+sfCnqFhwoYQXHWzCgoOJtNJc12c0gNVD4KxctiszPDx9ekKVVRQFLbTWuksybbLeHPeWkADWApQ3S+DEBwgsTVZe3RYJKZynI9afFpwrpMQlNDkwyodRKlMdmABemtG0XsUl96KmrjDyGFrGIeilS4DEpmdnFKGCowfgxWQlRcyyXlR0qxBnuZAPRC6HzgaD7RpZwc3ZH4VV+KtWYTKnRZ9pFA+Mn2Omm40bNqRDOVp5s2l5bxn6y8DG0qtiwoYIfqBVrN3CFh4jRnoXbwvghQlusgZeHqqJJYcfHNb9S5Hz4WGA/Q1C6oqZI6zAvuPpdeh0qqWP4ye3U2mMEkDv1UJtRl/68mnuWeq8HsS2x24awsAk1rXgwUvYGxMuHYDRsZUrko2DLicHRdyyqhLI14WU+Q73iIgvRk2uROHq/DXtpnKScyuhsllhe5nExC4lb37FW93MQS08pqrHYVAuDXl3i46rnXiOLvYNd5A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(26005)(2906002)(6486002)(8676002)(1076003)(36756003)(38100700001)(8936002)(83380400001)(16526019)(86362001)(186003)(6916009)(6496006)(66556008)(66946007)(478600001)(66476007)(5660300002)(316002)(4326008)(2616005)(6666004)(956004)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?M1lQUjgrSFZXWURhZVdDYmFqMVUvQldTY0hZb3hzMTdkVTlCWGUzWkwxZlVI?= =?utf-8?B?eFAyODYxZ29RWHY1RWVPSTJEcFFGMXFyWkpQQm40WG80bVFyNVpEK2xndm9F?= =?utf-8?B?bXZUWVY2K3dGRE9OTXFhcFRXTVlGWGJCR09EV3hVdzNrM3lRQXZSeUI4WGtw?= =?utf-8?B?NG4zMW5LTmhmc2ZUOGNyanZ6dVhPb3BGVkZhbmVQbFR0dlY3enJrRnBRdWlI?= =?utf-8?B?RHFOalc3VUNOY3hpTkRKcldrcitPRTY5MWRUNEppTi9wbW9PTmQvOXZqTFZM?= =?utf-8?B?VHU4M0ZmTXdybkdCeWVDKzYvMEVmT1Z3ZkpVNER0T3ljWmQvV3p1cDhxL3RQ?= =?utf-8?B?TWRIMHc4RzdUS3JMQjRmRG5oUW5wTm4wMG43K3VBTk4xRk5ObUFnVU1WZGRm?= =?utf-8?B?S3FuWjQ3VVZuV05GSzcvT2JvNm81Y2RxRmxjSWFNcExTRnpZN1dBTG42ZXZw?= =?utf-8?B?Tks0d0xMYzNXbmp2eHNaTWppc0VNUzZrdm50RnYzQnhnRGRtOGtsUUl4S2tY?= =?utf-8?B?ZnZNTTdBOSs2NC91UVhESGQ3c2lVdGNva0k0bGNUSXlLL3dtK053ZDFKNHRu?= =?utf-8?B?clFUSXhQVVlGVVc0WXYzWnF1QURRUC9NSlNuOU1VbHl4Sm9QbG9Bekc5VG53?= =?utf-8?B?L0hSSEJQOTNXLzI3c3JDeWdMQU9HcXYwd1d2U0pYZmJkTHo2YlFpQVBRTWpZ?= =?utf-8?B?ZDNqaWVPeGNJajhNL3ZNUW1BcllOSVdaNnF2ZTBNaHF6eXhISEFDSmxXc3cy?= =?utf-8?B?d2xtcnNtcWpab3B0Zk9jWjhYaUw4UkdqR2hZWFdXbnk4QStuUjR3dVRORDE3?= =?utf-8?B?b25ZdFg3bjNpaHRVOUhYZmN0MmI1MjhpRlJTcFBlUG0zWEdPN3F0MHFKZEdu?= =?utf-8?B?QWRFSkdONzlSc09vbUJuS2svbktZMXBpOWRZT0cwSUFnTE9BZ2gzWk83Z0Ux?= =?utf-8?B?a3ptRitSMVExa1dDNGxhbGVGVloxVXhhcmd6MVBHRFV4RlVNZjVXd3BuMDE5?= =?utf-8?B?eUNwbHVEbmpqUXhhWmZoQWFNYjdxUWZFWmZDWjlkdTZKVVFtejFSZ1ltRmUv?= =?utf-8?B?cEkvWUVvK1o4aVVNQkFhVTNiTGxORUNzSEZmeGhockN2MDdZTFZwOU9QQ3pu?= =?utf-8?B?WnF0WnUxUEkwYUFVc1UzblNjOTE3VWw4VnRzNkM2RDhONFlXak9VNzA4bXZL?= =?utf-8?B?RngwMWdXTEhGZVVhekljYXE3UHg0OTFlVWN3dVo0NHgrZDF5S3JtTHY5RCsw?= =?utf-8?B?OWk4c1pqMFZjNHJISXlnQWtVQlNFbDFlYzBrbXpjbW5ocmZ4NEMwNVhLWFl4?= =?utf-8?B?QjRaN05pdkU3TnZYcHh3Skp1blpOZWpvMFE1UmptdENSTDhxQTYzYXJmNjlm?= =?utf-8?B?REdGZzl0QW1HcW5YV0lBWTh5M2dablBzVHZRN3VlUGMwSHdsOUJsSDYzUng0?= =?utf-8?B?ZGJPVWNKcmFjazJ2V1hYRnU3dWNXYnN1Rk9FdXhJdE5ldURERjJ1RzZXbC9r?= =?utf-8?B?Ymg1Y0lpV1pzbTlmTGg1YlQxckJ4YnNONGd3ellDR3lPbFB4aU1RWkZGenZ3?= =?utf-8?B?UjlTRktJQUNkUElWMHdIRGlBc2FGaFVveXBBbnZvRVNiWkFscFpHY2VKejFt?= =?utf-8?B?aUlpTExWSEttU1JDM29pbHA5R0lTNC8zSDVVRVJYMWw4V002TVgxazFGRFA2?= =?utf-8?B?WXdGL3FzSXpQMXprVXpsL0duWWwwVmFUSVRNQjFwMWJKRkpXZk5Ndnl3VWt6?= =?utf-8?Q?qjBgprGTqN95ABeiWuyqUSZoPWVRECzhAPeN0f/?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5c6df4d8-d138-4cce-6bed-08d8f430d099 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 10:36:16.9024 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k1Vef2Js+LNx3GeP55HIspzoUuNe2uflFDTbMtxBH+Pef8qaUlK8aOfyUPtqcbBem/PirJOm/QEGx4bz8th5Lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5968 X-OriginatorOrg: citrix.com This is code movement in order to simply further changes. No functional change intended. Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich --- Changes since v2: - Drop one of the leading underscores from __hvm_dpci_eoi. Changes since v1: - New in this version. --- xen/drivers/passthrough/x86/hvm.c | 164 +++++++++++++++--------------- 1 file changed, 82 insertions(+), 82 deletions(-) diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c index 2331af896d4..ecc7d66e600 100644 --- a/xen/drivers/passthrough/x86/hvm.c +++ b/xen/drivers/passthrough/x86/hvm.c @@ -205,6 +205,88 @@ static struct vcpu *vector_hashing_dest(const struct domain *d, return dest; } +static void hvm_pirq_eoi(struct pirq *pirq) +{ + struct hvm_pirq_dpci *pirq_dpci; + + if ( !pirq ) + { + ASSERT_UNREACHABLE(); + return; + } + + pirq_dpci = pirq_dpci(pirq); + + /* + * No need to get vector lock for timer + * since interrupt is still not EOIed + */ + if ( --pirq_dpci->pending || + /* When the interrupt source is MSI no Ack should be performed. */ + (pirq_dpci->flags & HVM_IRQ_DPCI_TRANSLATE) ) + return; + + pirq_guest_eoi(pirq); +} + +static void _hvm_dpci_eoi(struct domain *d, + const struct hvm_girq_dpci_mapping *girq) +{ + struct pirq *pirq = pirq_info(d, girq->machine_gsi); + + if ( !hvm_domain_use_pirq(d, pirq) ) + hvm_pci_intx_deassert(d, girq->device, girq->intx); + + hvm_pirq_eoi(pirq); +} + +static void hvm_gsi_eoi(struct domain *d, unsigned int gsi) +{ + struct pirq *pirq = pirq_info(d, gsi); + + /* Check if GSI is actually mapped. */ + if ( !pirq_dpci(pirq) ) + return; + + hvm_gsi_deassert(d, gsi); + hvm_pirq_eoi(pirq); +} + +void hvm_dpci_eoi(unsigned int guest_gsi) +{ + struct domain *d = current->domain; + const struct hvm_irq_dpci *hvm_irq_dpci; + const struct hvm_girq_dpci_mapping *girq; + + if ( !is_iommu_enabled(d) ) + return; + + if ( is_hardware_domain(d) ) + { + spin_lock(&d->event_lock); + hvm_gsi_eoi(d, guest_gsi); + goto unlock; + } + + if ( guest_gsi < NR_ISAIRQS ) + { + hvm_dpci_isairq_eoi(d, guest_gsi); + return; + } + + spin_lock(&d->event_lock); + hvm_irq_dpci = domain_get_irq_dpci(d); + + if ( !hvm_irq_dpci ) + goto unlock; + + list_for_each_entry ( girq, &hvm_irq_dpci->girq[guest_gsi], list ) + _hvm_dpci_eoi(d, girq); + +unlock: + spin_unlock(&d->event_lock); +} + int pt_irq_create_bind( struct domain *d, const struct xen_domctl_bind_pt_irq *pt_irq_bind) { @@ -860,88 +942,6 @@ static void hvm_dirq_assist(struct domain *d, struct hvm_pirq_dpci *pirq_dpci) spin_unlock(&d->event_lock); } -static void hvm_pirq_eoi(struct pirq *pirq) -{ - struct hvm_pirq_dpci *pirq_dpci; - - if ( !pirq ) - { - ASSERT_UNREACHABLE(); - return; - } - - pirq_dpci = pirq_dpci(pirq); - - /* - * No need to get vector lock for timer - * since interrupt is still not EOIed - */ - if ( --pirq_dpci->pending || - /* When the interrupt source is MSI no Ack should be performed. */ - (pirq_dpci->flags & HVM_IRQ_DPCI_TRANSLATE) ) - return; - - pirq_guest_eoi(pirq); -} - -static void __hvm_dpci_eoi(struct domain *d, - const struct hvm_girq_dpci_mapping *girq) -{ - struct pirq *pirq = pirq_info(d, girq->machine_gsi); - - if ( !hvm_domain_use_pirq(d, pirq) ) - hvm_pci_intx_deassert(d, girq->device, girq->intx); - - hvm_pirq_eoi(pirq); -} - -static void hvm_gsi_eoi(struct domain *d, unsigned int gsi) -{ - struct pirq *pirq = pirq_info(d, gsi); - - /* Check if GSI is actually mapped. */ - if ( !pirq_dpci(pirq) ) - return; - - hvm_gsi_deassert(d, gsi); - hvm_pirq_eoi(pirq); -} - -void hvm_dpci_eoi(unsigned int guest_gsi) -{ - struct domain *d = current->domain; - const struct hvm_irq_dpci *hvm_irq_dpci; - const struct hvm_girq_dpci_mapping *girq; - - if ( !is_iommu_enabled(d) ) - return; - - if ( is_hardware_domain(d) ) - { - spin_lock(&d->event_lock); - hvm_gsi_eoi(d, guest_gsi); - goto unlock; - } - - if ( guest_gsi < NR_ISAIRQS ) - { - hvm_dpci_isairq_eoi(d, guest_gsi); - return; - } - - spin_lock(&d->event_lock); - hvm_irq_dpci = domain_get_irq_dpci(d); - - if ( !hvm_irq_dpci ) - goto unlock; - - list_for_each_entry ( girq, &hvm_irq_dpci->girq[guest_gsi], list ) - __hvm_dpci_eoi(d, girq); - -unlock: - spin_unlock(&d->event_lock); -} - static int pci_clean_dpci_irq(struct domain *d, struct hvm_pirq_dpci *pirq_dpci, void *arg) { -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 31 10:36:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 10:36:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103854.198103 (Exim 4.92) (envelope-from ) id 1lRYDC-0005Cn-H1; Wed, 31 Mar 2021 10:36:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103854.198103; Wed, 31 Mar 2021 10:36:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYDC-0005Cd-DE; Wed, 31 Mar 2021 10:36:34 +0000 Received: by outflank-mailman (input) for mailman id 103854; Wed, 31 Mar 2021 10:36:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYDA-0004so-K1 for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 10:36:32 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d1731d54-c7bd-4d29-811e-326e91ca0113; Wed, 31 Mar 2021 10:36:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1731d54-c7bd-4d29-811e-326e91ca0113 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617186986; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=BsyDEsX9ceA4dUbZnZwjzJfmI6TlX31Agx0NKPinq9I=; b=QvR6CbVjD8uXFav6RYBFhxbe1NFNIpE+bg8cxdWnczJzo8Ul9OT8K6Us CI6ftpEIfBihzPhbU6znlpJwe0XKywmHCJ2EivLo0krRfNCiA1fMzy6TC VQNSGKJ61B/yZBuK9gtpzEvdjR7FX8oZyrt8FtPbygy8bfkQ8a+H2/Qs6 U=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: zYVZcCUJVGd9kP/ghbTciBOjDI/YoeMo6o9URj9xFSwvMX/sS+pty5haJzKoCz/M1NHwNxdItz 12jr8X0QScwvb6grJwJKxSB0f/dmiQqlXp0H+JHpxbOP6IF3I1C7+gvhQVxDQ7UEAlodLW69hL oE2eMlmtwPkh8ySbnf5OqBH9C1tptA/MLg918FUHkGQE7zRiaZ+hS8Gp1mnSJuFYPuJXRRupa0 2C+X8MLxlVGJcO1UcYBlz9QLl0mOL74P8VYauwNYAGFY6HfL+B3qJVOzS9L3qX1aV3JhSGXUbJ 2KQ= X-SBRS: 5.2 X-MesageID: 40415685 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:CbFAdaCwg2Ph7NblHegptMeALOonbusQ8zAX/mhLY1h8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPufVr1zrQwxYUKJ7+tUE3duGWuJJx/9oeK+VHdMgXE3Kpm2a 9kGpISNPTZEUV6gcHm4AOxDtYnx529/Lq1gPrFpk0NcShBQchbnmNEIyycFVB7QxQDOIEwE4 CS6tECiz2rf3kWacrTPAh4Y8HoodrXmJX6JSMXHhJP0njysRqEyp7fVyKZ0BAXTi9Vzd4Zn1 TtvgTl6syYwpeG4zDG0Wu71eU1pPLAzZ95CNWImowpLFzX+32VTaBAf5HHgzwvuuGo7z8R4a nxijMtJd565X+UXkzdm2qV5yDa3Dwj62DvxDaj6BOJy6yJJ0NJN+N7iY1UaRff4UY71esMqp 5j5G6Fq4FRSSrJgSWV3am4azhRikG2rXA++NRj6EB3bI12Us41kaUvuGlREJsGARvg7pEmHO REHKjnlYhrWGLfQHbDsmZ1xtuwGlw1AxedW0AH/veYyj5MgRlCvgcl7f1auk1F2IM2SpFC6e iBGqN0lItWRstTSa5mHu8OTea+F2Sle2OCDEuiZXDcUI0XMXPErJD6pJ8v4vuxRZAOxJwu3L zcTVJxrwcJCgLTIPzL+KcO3gHGQW27Uzio4NpZ/YJFtrr1Q6euGTGfSWopj9Crr5wkc4zmcs f2HKgTL+7oLGPoF4oM9Rb5QYNuJX4XV9BQlc08X36Iv8LXOqznvuHWa5/oVfjQOAdhflm6Lm oIXTD1KskFxFusQGXEjB/YXG6oWkGXx+M0LIHqu8wojKQdPIxFtQYYzX6j4NuQFDFEuqsqOG 93ILbtlLKHtXC7lFy4q1lBC154NAJ48b/gW3RFqUshKEXva4sOvN2ZZCR00GaYIAR8C+fbCh RWqVgy2a/fFe3f+QkST/acdk6KhXoao3yHC70GnLeY2MvjcpQkSrA8WKJwEg3PPwdvmRljrV pCbANsfD6dKhrezYGeyLAEDuDWcNdxxC2xJ9RPlH7ZvUKA4f00SmAjRD6oW86PiQMITz5Z72 cBtJM3sf6lo3KCOGE/iOM3PBlpZH6MCLxLNgiDeb5Zg6vmYg12UGeMiwGLkh1bQBuYy2wiwk jaaQGEc/DCBVRQ/kpV1avn63tYXGSQdUAYUAEwjaRNUUD9/lpj2+6CYaS+l1aLYlwZ2+cHLX Xuej0JOD5jwNixyT+YkDuPDm8d250rJ+DRZY5TNY376zeIEsmlhKsGF/hb8NJZL9joqPYMSv /aVAmPLj/0YtlZrTC9lzIAAm1Tp3Ylm/+zh0Ggw2i8wXIlAf3dZH5hXKoWJtmA727iA9aEua 8J+e4djK+VCCHWbNXD9IT8KxhkATnXqXStT+4ppYtP1JhC/IdbLt3+a3/wyHpD3B8CN8/6m0 MVfbRj7Nn6S/pSVv1XXxgcw0Egm9uOJnY6qwDaAucxelc2kn/QVun5lIbgmP4KCk2FqBCYAy jmzwRtu9PEVTCEz7gUFuYZJnlXclE17B1Zjam/XryVLAWhbOdY+lWmdle7bb9GUaCAXZEdtA xz7d3Nv+iZcUPDqU3tlAo+BqJF6GC8R8yuRCqKBO5T6tS/fW22vZHC2r/7sB7HDR2ha0oZgo VZdUsfKuR74wNS87Ef42yVUaz4okUsjl1Exypo/2Sdg7Sb3A== X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40415685" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ahpTBpugP3SX26HdOQ1ebgu/ly89uC4EMv9yf3/4CT0fXDk+gHAs9HR0cAO+CDAopmpjN7re47r/RXo2xdfTH/aRI/d3651sTB5616oI+VQvEuMAU+Tj+W8G/RZTer6Tky/e6vqj5/lpfspZdQ2DsF4R61b04ibTNqPSBQ70c/8SZ0MP66wcTV2qgmjSqNp+z0xGi4rClN68s6x1139oTEz6ej3U0ZytQHTJ2A/vatOTcla7ozfMnghqRJ4fpMcZEfC2h/Dk5uWjbuLIxMclcQC4OJ5BzU/PNKBlJws3R56QFymvtebWiIfaSCNLtESkGqIjIalHBhM0/J//yWWOXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wPR5XbW/RU459tEveSX6lE/a/vHm/2wN5mOhp/77/C4=; b=CN6hkp/xR+FUr6gc+OP6wghJhOuvjw0I2RZjl2ih4BfY+96hOuGCHWcAtyt64UYf3oNKqdn5v4H+keTho0tvCt1qJmfHbOdAQ9LHo98yywvzCzO9pVujh7pgfz2AxdcIunGnuOWafR9JcHqmcStAWvP+G/Q/eXemcgeWah5UyjM7op58D8iiTjuFrsH89G/qYZRy4J3X9tqLlYs77Y3k9aak9X2M9NDSGvP7RZ4/L36IKUnAMTbgYhbDZXCNwAYNhQ4ZhSdtWiYdqQfqRAuDndc4T7lqfdAr2Nsy0Azu7oStABiQXQesjQUT5sYir2lJUn55cbaKxz+ooXTBSukBkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wPR5XbW/RU459tEveSX6lE/a/vHm/2wN5mOhp/77/C4=; b=tlj5hnsks5ipoidLFez6oQE8929rdsL/ilWx2X+Rj4oLtnZK5Q33/KnhsUNpkmWra9PImJd0gHn10PARADxdfP6JsFNbBlAQjpn7xZIV3aOCWFAfMAqYdh4lexhFq8hQKWtYilOb43Ds9qc6vd1+0bMdnCiAIHsbeoE6FSRRPqo= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , Paul Durrant Subject: [PATCH v3 08/11] x86/dpci: switch to use a GSI EOI callback Date: Wed, 31 Mar 2021 12:33:00 +0200 Message-ID: <20210331103303.79705-9-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210331103303.79705-1-roger.pau@citrix.com> References: <20210331103303.79705-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0112.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::28) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0ea4d173-e4e5-4353-afb9-08d8f430d3d5 X-MS-TrafficTypeDiagnostic: DM4PR03MB5968: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3513; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dn26CJMBmePfHhfGdfwX4yw9HuWpvYropm8lJ82PrzSm+Cit7ZidCqq4Rd2vjOHf/oXknEe4wlH0CRyu5g6WoCwfVa6tVuEZt5SH0gp68nEUKWZAVa+JAtcoDaDfqvw11xsyXM6nj09poNORdYB15JHcTMkLRNvt/WkubbcDtw/WZ3zkFlHKfYWF/D8FxD2QjlIVU14Q1exUIAcmfvEAlWEr3n+AxQc6TkCdZHv5I6wMvY2rB/W5cjL9B4rd2J/WMwHWVC+IIm/7zBqCJGY12B03LjEPaaWiVxxxJo/APi9zcE9gg8Caiklqk5OdkwkciM/utrmb3700yTmovuslRs3wCsuvI2xgkE9cB/Qx+1j6eAcb+pBxvlRWYp2ylVNIoXb37DRLetGRD69pZZyaqxI/a5ocYRhjTm7vgABPvznPKoVsGNtvVm4tSBmhEsGfNbFSkmLyr/B8YQr4+np6O+FkorkITguzlUMI6LUxtGOqvRmmAjIIUYRg7OaF/1Cr8bcYHv2kYsOw0ky1DRt4Onf5e3I6pCSd//G6NgyMjM7p8vUtcfudjniVwTE9qMjHPaCbtzi6Mfr+wtaQ4Ulmy3nTKCqNrD1wn0l2Lvk5UtZHuZ7NF3zXVx7hJ/xY4PdkMn7nibRrx2g7lp5fgERTFw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(26005)(2906002)(6486002)(8676002)(1076003)(36756003)(38100700001)(8936002)(83380400001)(16526019)(86362001)(186003)(6916009)(6496006)(66556008)(66946007)(478600001)(66476007)(5660300002)(316002)(4326008)(2616005)(6666004)(956004)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?akltOVRiNTlnQk1rYUdtS0hzUERueFBrendkZTBEVFMxa3RzcnN0R0JjZDY5?= =?utf-8?B?bWZVV0dtUFBvSmVHOHdKUUp4eVpNTFVMVGZCOFdJN1JSMW14SWRwSmtJanlP?= =?utf-8?B?OC9jaEtiQ2k1N1Y5OXh6WFp3dEF2N3RPbnhtVFd2Vi93NXJRYzhQRGQva09J?= =?utf-8?B?bGxXa1lNQXlObFMxT3lkS0N3Z0swTDZ3aEhoOFlLV00wRUFDS1RWWlVQR0R5?= =?utf-8?B?MmxsRk0xMTZEM28zb0dFaGQ1cXk4VTRheGlvdUNEaHhNakJnK3djTlNpQVV5?= =?utf-8?B?V2hnU1loOEZFajRSMFNEWElQTEZoVFVLTGlTM3dJS1BWdHYyYytncXJXUmhE?= =?utf-8?B?c3NXaDlsanQ1VEthK0hBenNxeFgzdG4yT2ZPWTFvRllTNUp0SkV4U2VCd0E5?= =?utf-8?B?amVkYitnMTNnaFIxTHpxTzZyb1pjSnphaG01Q202dG00TGhERjRueHVYOU9y?= =?utf-8?B?dmRTRmFkTmNYSTRCaWxlcUdpT0VyVVJwc1A1aUh0bHM2dW1KOUhlWmZTVkx3?= =?utf-8?B?R2hWaFVXL0ZuaExZVXQ5TmZjR3c5VXN1S0tacmNUUEY4eGR0Y0JNMkE1VzVl?= =?utf-8?B?YkhUVXFaQ1ZwK0FVMUptK1F0L1FSWGVrUXBJNm56aTFFZjNsdlJJSGVWdW1t?= =?utf-8?B?aUlKb2ZjQWYwS2RrU2FXUHM1TFo3Ykt5V1J0NUlNUlA0NUZMTWxqTXhiVU0x?= =?utf-8?B?ekw2c2N3em1aOXFtaGMxdDB3OHM4ZDV1Wk5ERDM1bWttc2REZFpzM0lzTVRY?= =?utf-8?B?UE0yQTQrcy9nUnhyMGo0UEdJSUYxMFVQZ1pzMURZU2xSM0EzVHNSZ0p5Zk50?= =?utf-8?B?dzVSRzhMcHZGMVgxbldLRisyL3Z3dXEwY3lOdzBPKzdCSjNUWDV0a0JEME4w?= =?utf-8?B?R3VrZkh0MXV3Z21UeHVlSlF0SUVWbGVaL0dobS84Q21kYVowcm11OVpOL0o1?= =?utf-8?B?MmxCZTZIckVWWGRVZzFLOStFaCtBYkttdjdVQ0tSbUJPcTlsZ21waTZIRFM2?= =?utf-8?B?SmlycU15SDVSdlFzeTFkeWhVSXRDTURVS09ZOGM1RktjZlJHOWtoOUNZTGhW?= =?utf-8?B?elpRSE1CY1FTaDUwY1R4bTFEQXVjSC9Memh0OGJDUU5Yc21HL0xTZVJ0dmov?= =?utf-8?B?eWpFb3M5TEZYbFJxdnErOWFSM0VOMGp4c3paRWRUcFJLMXc4M3YvZ2QzN3lx?= =?utf-8?B?WnE1YTNJRkRyQ0xzTUhheGdwVFAvc2k4M0xqR0hxbW1tNGFSaHBDbjVEckdJ?= =?utf-8?B?WEYrd1FUd3lOR2FMVGVjTTk5M2tBQXkrZDJPbWFycEVQNGpQMXhLMFo2dUQw?= =?utf-8?B?OFI1dkx1Yi9NaXN5WmJ2Q3RBcVd4YUo1SDI1L2MxaEN1dmZWVXNJcitJMFFt?= =?utf-8?B?YUx2dVhqQk1aNGw1ZDNRRmYxc3N4UXhDUllIRU8zb2xYNDhkNk51RU9JaHlu?= =?utf-8?B?djFSM1Y0WVQ5WTMxTGd6c0pwTW1aaHNvRStlY1VCbmNIVlYvaW05WTZtTThC?= =?utf-8?B?VlhxdXRmVjJrK3FCMmFqaEUzNEY3KzNjUjZZNFhvdzFMcGlyVDk0VDJSUk5M?= =?utf-8?B?c2R0MnZzSUZOeUlSNFNqa3BmSThNR3hBSVhITktwMFFvYzF3SjU1OXZGTlhS?= =?utf-8?B?blgyeEJXemltVS9OUFlWcEVNMmhCVHozMmVNRVhqZmloOUNiRStiU01wM3cz?= =?utf-8?B?cnJFOTFXdnlpTVZIWnRrNExqRXhnUTEyM3AxdTZOTk5CZEJDcVdQVmMwb3dk?= =?utf-8?Q?P2f+aibLSH2prLDhvtStAmIRCuLTHbe5dDPW9hH?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0ea4d173-e4e5-4353-afb9-08d8f430d3d5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 10:36:22.3913 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7Ixtz/qpvq4IYbVyS+F5NiN1kFk3eP4FcyjA4yz3616xs1KscfL8Si9KmXZ+bTwwAzM3sKmkla8O4KvwGdKB1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5968 X-OriginatorOrg: citrix.com Switch the dpci GSI EOI callback hooks to use the newly introduced generic callback functionality, and remove the custom dpci calls found on the vPIC and vIO-APIC implementations. Signed-off-by: Roger Pau Monné --- Changes since v2: - Avoid leaking the allocated callback on error paths of pt_irq_create_bind. Changes since v1: - New in this version. --- xen/arch/x86/hvm/vioapic.c | 8 ----- xen/arch/x86/hvm/vpic.c | 2 -- xen/drivers/passthrough/x86/hvm.c | 54 ++++++++++++++++++++++++++++--- xen/include/asm-x86/hvm/io.h | 1 - xen/include/asm-x86/hvm/irq.h | 1 + 5 files changed, 51 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c index 099c29466ba..4cdb95ce835 100644 --- a/xen/arch/x86/hvm/vioapic.c +++ b/xen/arch/x86/hvm/vioapic.c @@ -284,7 +284,6 @@ static void vioapic_write_redirent( */ ASSERT(prev_level); ASSERT(!top_word); - hvm_dpci_eoi(gsi); hvm_gsi_execute_callbacks(gsi); } @@ -420,13 +419,6 @@ static void eoi_callback(unsigned int vector, void *data) ent->fields.remote_irr = 0; - if ( is_iommu_enabled(d) ) - { - spin_unlock(&d->arch.hvm.irq_lock); - hvm_dpci_eoi(gsi); - spin_lock(&d->arch.hvm.irq_lock); - } - /* * Callbacks don't expect to be executed with any lock held, so * drop the lock that protects the vIO-APIC fields from changing. diff --git a/xen/arch/x86/hvm/vpic.c b/xen/arch/x86/hvm/vpic.c index ca484c31b6a..e0f3f6276dc 100644 --- a/xen/arch/x86/hvm/vpic.c +++ b/xen/arch/x86/hvm/vpic.c @@ -237,7 +237,6 @@ static void vpic_ioport_write( ASSERT(pin < 8); hvm_gsi_execute_callbacks( hvm_isa_irq_to_gsi((addr >> 7) ? (pin | 8) : pin)); - hvm_dpci_eoi(hvm_isa_irq_to_gsi((addr >> 7) ? (pin | 8) : pin)); __clear_bit(pin, &pending); } return; @@ -288,7 +287,6 @@ static void vpic_ioport_write( vpic_unlock(vpic); hvm_gsi_execute_callbacks( hvm_isa_irq_to_gsi((addr >> 7) ? (pin | 8) : pin)); - hvm_dpci_eoi(hvm_isa_irq_to_gsi((addr >> 7) ? (pin | 8) : pin)); return; /* bail immediately */ case 6: /* Set Priority */ diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c index ecc7d66e600..4ae678d69b4 100644 --- a/xen/drivers/passthrough/x86/hvm.c +++ b/xen/drivers/passthrough/x86/hvm.c @@ -252,9 +252,9 @@ static void hvm_gsi_eoi(struct domain *d, unsigned int gsi) hvm_pirq_eoi(pirq); } -void hvm_dpci_eoi(unsigned int guest_gsi) +static void dpci_eoi(unsigned int guest_gsi, void *data) { - struct domain *d = current->domain; + struct domain *d = data; const struct hvm_irq_dpci *hvm_irq_dpci; const struct hvm_girq_dpci_mapping *girq; @@ -477,6 +477,7 @@ int pt_irq_create_bind( { struct dev_intx_gsi_link *digl = NULL; struct hvm_girq_dpci_mapping *girq = NULL; + struct hvm_gsi_eoi_callback *cb = NULL; unsigned int guest_gsi; /* @@ -503,11 +504,23 @@ int pt_irq_create_bind( girq->bus = digl->bus = pt_irq_bind->u.pci.bus; girq->device = digl->device = pt_irq_bind->u.pci.device; girq->intx = digl->intx = pt_irq_bind->u.pci.intx; - list_add_tail(&digl->list, &pirq_dpci->digl_list); + girq->cb.callback = dpci_eoi; + girq->cb.data = d; guest_gsi = hvm_pci_intx_gsi(digl->device, digl->intx); link = hvm_pci_intx_link(digl->device, digl->intx); + rc = hvm_gsi_register_callback(d, guest_gsi, &girq->cb); + if ( rc ) + { + spin_unlock(&d->event_lock); + xfree(girq); + xfree(digl); + return rc; + } + + list_add_tail(&digl->list, &pirq_dpci->digl_list); + hvm_irq_dpci->link_cnt[link]++; girq->machine_gsi = pirq; @@ -515,17 +528,44 @@ int pt_irq_create_bind( } else { + /* + * NB: the callback structure allocated below will never be freed + * once setup because it's used by the hardware domain and will + * never be unregistered. + */ + cb = xmalloc(struct hvm_gsi_eoi_callback); + ASSERT(is_hardware_domain(d)); + if ( !cb ) + { + spin_unlock(&d->event_lock); + return -ENOMEM; + } + /* MSI_TRANSLATE is not supported for the hardware domain. */ if ( pt_irq_bind->irq_type != PT_IRQ_TYPE_PCI || pirq >= hvm_domain_irq(d)->nr_gsis ) { spin_unlock(&d->event_lock); - + xfree(cb); return -EINVAL; } guest_gsi = pirq; + + cb->callback = dpci_eoi; + cb->data = d; + /* + * IRQ binds created for the hardware domain are never destroyed, + * so it's fine to not keep a reference to cb here. + */ + rc = hvm_gsi_register_callback(d, guest_gsi, cb); + if ( rc ) + { + spin_unlock(&d->event_lock); + xfree(cb); + return rc; + } } /* Bind the same mirq once in the same domain */ @@ -597,12 +637,17 @@ int pt_irq_create_bind( list_del(&digl->list); link = hvm_pci_intx_link(digl->device, digl->intx); hvm_irq_dpci->link_cnt[link]--; + hvm_gsi_unregister_callback(d, guest_gsi, &girq->cb); } + else + hvm_gsi_unregister_callback(d, guest_gsi, cb); + pirq_dpci->flags = 0; pirq_cleanup_check(info, d); spin_unlock(&d->event_lock); xfree(girq); xfree(digl); + xfree(cb); return rc; } } @@ -709,6 +754,7 @@ int pt_irq_destroy_bind( girq->machine_gsi == machine_gsi ) { list_del(&girq->list); + hvm_gsi_unregister_callback(d, guest_gsi, &girq->cb); xfree(girq); girq = NULL; break; diff --git a/xen/include/asm-x86/hvm/io.h b/xen/include/asm-x86/hvm/io.h index 9ac3e4f48f6..a05bdbe5555 100644 --- a/xen/include/asm-x86/hvm/io.h +++ b/xen/include/asm-x86/hvm/io.h @@ -101,7 +101,6 @@ bool handle_mmio_with_translation(unsigned long gla, unsigned long gpfn, struct npfec); bool handle_pio(uint16_t port, unsigned int size, int dir); void hvm_interrupt_post(struct vcpu *v, int vector, int type); -void hvm_dpci_eoi(unsigned int guest_irq); void msix_write_completion(struct vcpu *); #ifdef CONFIG_HVM diff --git a/xen/include/asm-x86/hvm/irq.h b/xen/include/asm-x86/hvm/irq.h index 0828c01dd18..f49c4c3b6e5 100644 --- a/xen/include/asm-x86/hvm/irq.h +++ b/xen/include/asm-x86/hvm/irq.h @@ -156,6 +156,7 @@ struct hvm_girq_dpci_mapping { uint8_t device; uint8_t intx; uint8_t machine_gsi; + struct hvm_gsi_eoi_callback cb; }; #define NR_ISAIRQS 16 -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 31 10:36:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 10:36:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103858.198115 (Exim 4.92) (envelope-from ) id 1lRYDJ-0005Ji-1z; Wed, 31 Mar 2021 10:36:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103858.198115; Wed, 31 Mar 2021 10:36:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYDI-0005Jb-Ui; Wed, 31 Mar 2021 10:36:40 +0000 Received: by outflank-mailman (input) for mailman id 103858; Wed, 31 Mar 2021 10:36:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYDH-0005Ed-JG for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 10:36:39 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 440c7728-2050-4477-a6dd-05bb39e4a66f; Wed, 31 Mar 2021 10:36:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 440c7728-2050-4477-a6dd-05bb39e4a66f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617186997; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=B3R84wGa0btRIL/3aNgrKfpGpevLyFpwyXFTHJnsMJ0=; b=SSPNJfXwG/1rMAzA3rau21NMjcro7nbt87SNDxUR9G3MaUUumcRUgA11 6q0Qo2xAbo+qxmamXchS9OpoyJYRCeK1dbJt/YK2It3EfltWaNhFBO9Lr tmrdZIT1zlvOv1PfDX4V3WE3ZUnAaZwZjR2QyBzZrKaV5+nf6lu3ZkCdG 0=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: J0+egh/HB9w0uExws+9FQpNDWGM/17eI9U5UUsZUD9o912kloBjPpsMtSfje76GBCX7Yrgk3u9 empouI3GLEc1z/GUM1CYrm0Em4q9ezUxPH78HFRkFllkEIpbH7N3kf36HLnrLHNhtKUr2Yqedn csfK+Klyqe5W25YumqNessRWB4pIcWXOTrGQrHYPjB+TW/Np4ekU3Ph0I5NGvx48JS9LK87X6S Rc85jLJu4Pz33RV5CR1Ho+vWhBUerwtH2wyrl5wmOQR2twHnhLKOumVJyhNuAa6ctNu61aoSAl XEE= X-SBRS: 5.2 X-MesageID: 40526885 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:DHm5Kq4VNS/c6S4p4APXwU2EI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoexzh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdxHW3tV2kZ 1te60WMrDNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2BXQotLhj0JbjqzOEtwWQVAGN4FD5 Ka/MVKvH6Nfn4QY8S9CBA+LpT+jvfMk4/rZgNDOg4/5GC1/E6VwZPZMzzd5BcRVDtT3awvmF KqryXV7riu2svLrCP0+HTU6/1t6bnc4/tFQPeBk80Ebgjr4zzYH7hJf52nkHQLrPq06FAs+e O80ysIG8ho8XveciWUjHLWqnDd+Q0j4XPj1lOU6EGLyaeSJENYerh8rLlUfRfD500rsMsU6t Mw40uju4dKFhSFpSzh5rHzJmBXv3Cpqnkvm/N7tQ05baIibtZq3Oki1XIQOpIBECXm0ZsgAe ljAerNjcwmD2+yXjT3uHJiz8erWWl2NhCaQlIassjQ6DROmmtlpnFoiPA3rzMlztYQWpNE7+ PLPuBBk6xPdNYfaeZYCP0aScW6J2TRSXv3QS2vCGWiMJtCF2PGqpbx7rlwzvqtYoY0wJw7n4 mEeE9EtEYpEnieSfGm7dluyFTgUW+9VTPixoV1/J5ioIDxQ7LtLGmqVE0uqc29uP8Sa/erGs qbCdZzObvOPGHuEYFG00nVQJ9JM0QTV8UTp5IVQFSLjsXXKpD7l+DSffrJTYCdUwoMayfaOD 8uTTLzLMJP4gSAQXnjmiXcXHvrZwje8PtLYe3n1tlW7LJIGpxHswATh1j8zNqMMyd+vqs/e1 Y7BLvml6i8tFSn5Gqg1RQsBjNtSmJupJnwWXJDogEHd2nud6wYhtmZcWdOmFyKOwF4VMGTNA JEvVx49eaWIvWrtG4fIuPiFljfo2oYpXqMQZtZsLaE/93ZdpQxCYtjfrdwGwXNHxlcgh1rt2 9HVQ8BSibkZ3DToJTgqKZRKPDUdtF6jgvuC9VTs2jjuUKVotxqemEWRAe0UcmcgR8nQh1dgl EZyd5ZvJOw3RKUbUcviuUxN1NBLECaGqhPAgi+aIJIobzzYw1rQWCWhTuVtgErdgPRhjYvr1 2kCRfRVeDAA1JbtHwd6Krs/V9uXki2fk57aBlBwMZAPFWDnkw2/f6AZ6K13WfUV0ALxfsFNi rZJREIJBl1+tyx3BmJuTqLGHk83K8yNujFALlLScCU5lqdbKmz0Y0WFf5d+5hocO30uugQSO SFZku7Kij7B+5B4X3iml8VfA1P7F8qnvPj1Ee7sCyW3HsjDeHTJ1ojbbcBON2Y53XlQfHN8J gRt6NAgcKAdkHKLviBwuXrShQGDDX5i2u/VfspppBZprhajso6I7DrFR/zkEha1xA/JvrunE wQQK5H8KnMU7UfCvA6SmZ8xB4Vj9yBI0sgjxzuDsI/dV8riWXHP9nh2cu+lZMfRmmIpA79Ij CkglVg1saAeyuIzrgBDa0sZUxQdUgn8XxnldnyPbH4OUGPd+tZ+kC9PWL4WLhBSLKdEbFVih ph+dmHk6u2cCX/sTqg8AdTE+Zr82y9R9m1Dx/JMelU88aiMVDJu5CU2qeI/X7KYAr+TV8Zi4 1DfVERacoGqgBKtvxJ7gGCDortokwklFNC5ypAjVCF4Pn+3Fvm X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40526885" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zzc/wNQ3ljeOR4eZhtwJUbxP/AuLct8xKDkONao4O3aXc13WRZsA0D+11QY0XVwyETlmrB9xLOJWTkEyjDyCR82d+lqkKYEjdoWfe3RgDnezp/EB2AeN4bcqboWztzBht23dWz25DxlD5huxZMvHImjkiEb1NK8zDS0LCYK/pP2hPKk6jEQv0dhi6k7BPvQxTJ9XJvMQcXbvdhQRvfSkR3noZ7XnSPz3bRYDscUJTGYcY+EuOHCTeoMv8VLsMtpmmcpehtS7CWswcaJ1L7ziJg3FBBdubHVFNb4JeNY86cQ7Wuuw6gc6EbVv6yAf8DgyowlR9orFxiQFSHAXpTnFjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OBYI1lpn/Fj2wAf8tHHymIobOKG3y0f6hpA3NmNveyE=; b=aleQpKvS2SO0DBknfMZ5EkFTOzRlnwfF4sVpIUSegYCJPNguTymaw+md6/3URuG5wrsIJI70A/b17FxkrAFgJxMJZ6o1ZQDpCQiWaReaPHr3NbLrm72EVJ4PaKkIujV8J14EKYEx78ZihJ6fl25ysukFfhH6Ac5eFGx+riTI/5kI9WVXYEqRTp3UycursdyhV50dXDATpms6FNPjJs3vg6kAHMP+dcj/TrLLBZGQ4LaQR1CSYaiRRGsbuLVX7hctI+dij5n+swGBGnfaTaBWBxKjm94Rb2ADwplkcY6KgATlLAHWTVDTVVM36m60H3hhu7rdo8Gj9ToHznQ3FNfymw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OBYI1lpn/Fj2wAf8tHHymIobOKG3y0f6hpA3NmNveyE=; b=ApRSLVEpeO1RkHrFz+izAix7NlukknuZu9a3BB/Ez1F1DNZa4GFynfHttRxfcelcnMjKDCYuBg8G00Ndm9BvNRZyXwVwIzZ4mYbJpms66cgbg+7PqcjCNeZg0Cp+mJfN/wnNu4jF9U+waTv1oXdZHVrGDGrdyOIBB3TENd6idhY= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v3 10/11] x86/vpt: remove vPT timers per-vCPU lists Date: Wed, 31 Mar 2021 12:33:02 +0200 Message-ID: <20210331103303.79705-11-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210331103303.79705-1-roger.pau@citrix.com> References: <20210331103303.79705-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0079.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::19) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aed7e27a-8a5d-4e4e-d2fd-08d8f430db10 X-MS-TrafficTypeDiagnostic: DM4PR03MB5968: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2657; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0PS4fuAgedwJDFLy+NSQUDq58ytXpZ/X9mmNtwnv86dlymuEghiUCFGgNmNGw4OUjJZ4RTa3V04BCz8U2NiyYUX4yFAqP4Rs6GkVLZAvk3yORj8wNqXhRvV+UuYaTT0x7FmpWRgqR30jivksDhLJkvM7C+iVGBWyylW4jcKDqwSvbfwU8CQlbFGp8LVQluyXNXbioGub5L1aBr9aP79R3Uoc4VuY8QrhUUkbuiiPSD1LXk7ilAUX9RjYDUTyt5VNZSZVgdIyGSdwyJTDU1wNbtQW254peqBIV3gKyVMzDiB6Aoumr6jYROKtckAG5ktasx61uvmSHYvTiohJc6l93bR6DOHXN3WEgw0DE9ZE7r5aaZnzgQs4MdCGQZZAAZ7z/9ZQq5YiP4DRU0jd9b/Nb16Cq7P17b+LhGzOrNyQmLs+7SMqttlkTkIZPMLbhT0V7ZyaJ0wO2t7aa79EjAb+k6nNXr9B4Fw4FsceRYs0Mi+MzwijsmRFssVgiRMmdlXcGK8yZlglKog3uMGw+Vr9tbjT/OP+Dnr3oWf4F2Daopi93bCz5lLMIfC0TmZrFlUdBmQ8RyenQHJpBcWO8UAjsmVJ8f7vx+GvXr2dMm5Vb20WToYvDFcyIg7SbUqUCHQURhRyxO7WodsPLUQhSujGHRtq5KIQnQ/4W4i0FyJ4eq0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(26005)(2906002)(6486002)(30864003)(8676002)(1076003)(36756003)(38100700001)(8936002)(83380400001)(16526019)(86362001)(186003)(6916009)(6496006)(66556008)(66946007)(478600001)(66476007)(5660300002)(316002)(4326008)(2616005)(6666004)(956004)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VzYvT0duUnhyWVdCQlFWT1g5SnFMVFVXeTNrMEtuSHhvemFNY3FHOU1MbFJE?= =?utf-8?B?dzlGQjRTcndRd2hhYXRFK2s5S0QvU2NPT0o2ZXZpOVAzL0p3RTRKeHpmek1J?= =?utf-8?B?emQ0NDVkT3FFenVlYmpDYlVtbGFHNlVvTmtGY21jSEhGTThnRUluSFBTTHlD?= =?utf-8?B?NzAvUlkyOEQ0SnFveUFBZkwyd3lrUXg3VTJkZzJaL1BOTEVZUnBpOXdXVURY?= =?utf-8?B?MzFzd041dHk5QnZ2WnFoVjRqZWZHSlA3a0VLaVFnYlo4bUtYQWNjTGkrb0RU?= =?utf-8?B?OW4xaXBLWGNudU56anorcXpPMGJoT25GTmtRcnlIRHpvUkQ4R3Zjd29oY2ZW?= =?utf-8?B?Y0g4amRKWkJkRmUvZEo1L2tmV052Z2RCS0hRb1V4U3c0MHdpeFMvZTJXQkND?= =?utf-8?B?NzhpWm5selUvUm5HNTVNaW1CQjcxZk5RSWdNRkNqczZCT1hMWFpIQ1Voa3l6?= =?utf-8?B?Tk9JMFcrWGYrZkl5aWllY0k3aWMvTjJ0N3ZjK0VjUXI0ZHExcWhRdGpySnJV?= =?utf-8?B?Q2J2V0xMV1k2aWcrK3lBNGxnNTNiTWNVZzJsU2U4bGNOS1VMZ3BucmJNc0JN?= =?utf-8?B?K3IrU05nZ1RwVnY0Z0tacGhwTGdkSUtnbE5oc2NnM1BQNDV6SCs0aUgrTUhQ?= =?utf-8?B?cTU1NVlLbTZNaXN6Nll5VUhHaFgycjJCclJmVStNRHNlYkowNWl6VDJzSFgx?= =?utf-8?B?SjQ0c1B0aUJlWVZyNHo3MFY0enEzM2xoV1VDejA3a3pNem9UU0cycThaMGJj?= =?utf-8?B?UDROSW1zSHlNbmdJb0pGRkJmRWlDenJNRHUxb3pTbWNBSUM2SkZnTW5TTkJB?= =?utf-8?B?R0gwd0RieXM2dG9tOVhkMDBpQjlTaVZ6bkVxdlI0dGZWRm5lakZDS1VuVTVT?= =?utf-8?B?ZHltOFpkSXgwQWFoaHl1NTYwUXlzTE45RzlKRmdXUzIxOTN2d0Vnc0Nkdjlk?= =?utf-8?B?ak9ybzcxRzlrSUtMenVJaFpCS0JRVHpETEhGUW8rQmRFT2pMMWtYSVdKZjQy?= =?utf-8?B?Z1lhejhQTTBMTFQzelFjN2s4REd1a05wdHZWZElLQlpVUDZsYkN1SEQrNys3?= =?utf-8?B?VjBvMFJCVTUyRnRpVkJ4OGlGUnUyaityYXZodnRMYWZJRzdrUEJXMXNabXFG?= =?utf-8?B?ZlpjK0F5MlJXVGg5Y2JUWWViK0t0ZWU3RlVHVUhyNXpURWlTOXhWSHpoR29w?= =?utf-8?B?cEIyZGJDL2ZITWRjTkovZytWU0R3Ly9nQk44LzdHalBpSHJ6Q2Q5a1hMY3Zj?= =?utf-8?B?Qk02VkZBYkt1V1U2VnBSbUpSeis4bjAvK2lBTnhLb2xNSDdTUXMzSGpoRUt0?= =?utf-8?B?Yjgydmp4dis4NThLRE5EZWZvUUdkL09WSCtmSTh4RXdGdkdvMmFMOCtEd3Jv?= =?utf-8?B?U1c3cjJmeWxvZDBzSnNmemRsaHlPNVEyRnl4NDFyYmQ2eVA2Z1JHS3ZJa1FM?= =?utf-8?B?Nzg5R0hySnZUd1N6enQzY3FtaWJrR0R1ZVQ0S205dDdBSkhQN2Q5bGhYTmlr?= =?utf-8?B?Qk9qam9HTWdYdHVQNTd3N0lWdURoSlYwdkZjTWhBWU5EbVlaNVFhRyt5ZkNt?= =?utf-8?B?WEdlaXJYYUN3YXJQc25lUXA2YTJKSnRxVGVsb1lxSnJsZTNsaVhGbER0TG5a?= =?utf-8?B?TWY3dk9CenlwU1gxYVhEaitqQkdqaUlodG5pSE5GUVI2VGVzTURNT0hJOUFQ?= =?utf-8?B?V01jSFJiTWwyZmxzcjE1SmRsMnQ1a1l0MVBaSloyS2NoNDJVTG95UElub3pZ?= =?utf-8?Q?YRHzQmSsUE+1XoBjzLO6P7yG90Mh2+Vi2+rcMtO?= X-MS-Exchange-CrossTenant-Network-Message-Id: aed7e27a-8a5d-4e4e-d2fd-08d8f430db10 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 10:36:34.4831 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b9TtQBuLChHUbdsPZotUwQ+IHZ++3MlAJI5FN7ZTQ+Ki6MDfd60FE8FBxTCNe4X10V++9JGzVeWMo+vXE8iMYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5968 X-OriginatorOrg: citrix.com No longer add vPT timers to lists on specific vCPUs, since there's no need anymore to check if timer interrupts have been injected on return to HVM guest. Such change allows to get rid of virtual timers vCPU migration, and also cleanup some of the virtual timers fields that are no longer required. The model is also slightly different now in that timers are not stopped when a vCPU is de-scheduled. Such timers will continue running, and when triggered the function will try to inject the corresponding interrupt to the guest (which might be different than the currently running one). Note that the timer triggering when the guest is no longer running can only happen once, as the timer callback will not reset the interrupt to fire again. Such resetting if required will be done by the EOI callback. Since virtual timers are no longer added to per-VCPU lists when active a new 'masked' field is added to the structure, to signal whether a timer has it's interrupt source currently masked. Signed-off-by: Roger Pau Monné --- Changes since v2: - Remove pt_{save/restore}_timer and instead use pt_{freeze/thaw}_time. - Remove the introduction of the 'masked' field, it's not needed. - Rework pt_active to use timer_is_active. Changes since v1: - New in this version. --- xen/arch/x86/domain.c | 4 +- xen/arch/x86/hvm/hvm.c | 4 +- xen/arch/x86/hvm/vlapic.c | 1 - xen/arch/x86/hvm/vpt.c | 174 ++++----------------------------- xen/include/asm-x86/hvm/vcpu.h | 3 +- xen/include/asm-x86/hvm/vpt.h | 12 +-- 6 files changed, 27 insertions(+), 171 deletions(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index b2127298800..a711ff2814a 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -2014,8 +2014,8 @@ void context_switch(struct vcpu *prev, struct vcpu *next) vpmu_switch_from(prev); np2m_schedule(NP2M_SCHEDLE_OUT); - if ( is_hvm_domain(prevd) && !list_empty(&prev->arch.hvm.tm_list) ) - pt_save_timer(prev); + if ( is_hvm_domain(prevd) ) + pt_freeze_time(prev); local_irq_disable(); diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 0279014e66e..3a72da67ef2 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -489,7 +489,6 @@ void hvm_set_info_guest(struct vcpu *v) void hvm_migrate_timers(struct vcpu *v) { rtc_migrate_timers(v); - pt_migrate(v); } void hvm_migrate_pirq(struct hvm_pirq_dpci *pirq_dpci, const struct vcpu *v) @@ -544,7 +543,7 @@ void hvm_do_resume(struct vcpu *v) { check_wakeup_from_wait(); - pt_restore_timer(v); + pt_thaw_time(v); if ( !vcpu_ioreq_handle_completion(v) ) return; @@ -1558,7 +1557,6 @@ int hvm_vcpu_initialise(struct vcpu *v) hvm_asid_flush_vcpu(v); spin_lock_init(&v->arch.hvm.tm_lock); - INIT_LIST_HEAD(&v->arch.hvm.tm_list); rc = hvm_vcpu_cacheattr_init(v); /* teardown: vcpu_cacheattr_destroy */ if ( rc != 0 ) diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index 63fa3780767..8091b6d8925 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -1339,7 +1339,6 @@ void vlapic_adjust_i8259_target(struct domain *d) if ( d->arch.hvm.i8259_target == v ) return; d->arch.hvm.i8259_target = v; - pt_adjust_global_vcpu_target(v); } int vlapic_has_pending_irq(struct vcpu *v) diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index f951cd95bcf..84d49c1b25c 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -126,18 +126,6 @@ static int pt_irq_masked(struct periodic_time *pt) return 1; } -static void pt_vcpu_lock(struct vcpu *v) -{ - read_lock(&v->domain->arch.hvm.pl_time->pt_migrate); - spin_lock(&v->arch.hvm.tm_lock); -} - -static void pt_vcpu_unlock(struct vcpu *v) -{ - spin_unlock(&v->arch.hvm.tm_lock); - read_unlock(&v->domain->arch.hvm.pl_time->pt_migrate); -} - static void pt_lock(struct periodic_time *pt) { /* @@ -151,7 +139,8 @@ static void pt_lock(struct periodic_time *pt) static void pt_unlock(struct periodic_time *pt) { - pt_vcpu_unlock(pt->vcpu); + spin_unlock(&pt->vcpu->arch.hvm.tm_lock); + read_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); } static void pt_process_missed_ticks(struct periodic_time *pt) @@ -166,14 +155,12 @@ static void pt_process_missed_ticks(struct periodic_time *pt) return; missed_ticks = missed_ticks / (s_time_t) pt->period + 1; - if ( mode_is(pt->vcpu->domain, no_missed_ticks_pending) ) - pt->do_not_freeze = !pt->pending_intr_nr; - else + if ( !mode_is(pt->vcpu->domain, no_missed_ticks_pending) ) pt->pending_intr_nr += missed_ticks; pt->scheduled += missed_ticks * pt->period; } -static void pt_freeze_time(struct vcpu *v) +void pt_freeze_time(struct vcpu *v) { if ( !mode_is(v->domain, delay_for_missed_ticks) ) return; @@ -181,7 +168,7 @@ static void pt_freeze_time(struct vcpu *v) v->arch.hvm.guest_time = hvm_get_guest_time(v); } -static void pt_thaw_time(struct vcpu *v) +void pt_thaw_time(struct vcpu *v) { if ( !mode_is(v->domain, delay_for_missed_ticks) ) return; @@ -193,52 +180,11 @@ static void pt_thaw_time(struct vcpu *v) v->arch.hvm.guest_time = 0; } -void pt_save_timer(struct vcpu *v) -{ - struct list_head *head = &v->arch.hvm.tm_list; - struct periodic_time *pt; - - if ( v->pause_flags & VPF_blocked ) - return; - - pt_vcpu_lock(v); - - list_for_each_entry ( pt, head, list ) - if ( !pt->do_not_freeze ) - stop_timer(&pt->timer); - - pt_freeze_time(v); - - pt_vcpu_unlock(v); -} - -void pt_restore_timer(struct vcpu *v) -{ - struct list_head *head = &v->arch.hvm.tm_list; - struct periodic_time *pt; - - pt_vcpu_lock(v); - - list_for_each_entry ( pt, head, list ) - if ( pt->pending_intr_nr == 0 ) - set_timer(&pt->timer, pt->scheduled); - - pt_thaw_time(v); - - pt_vcpu_unlock(v); -} - static void pt_irq_fired(struct vcpu *v, struct periodic_time *pt) { - pt->irq_issued = false; - if ( pt->one_shot ) { - if ( pt->on_list ) - list_del(&pt->list); - pt->on_list = false; pt->pending_intr_nr = 0; - return; } @@ -252,7 +198,11 @@ static void pt_irq_fired(struct vcpu *v, struct periodic_time *pt) pt_process_missed_ticks(pt); if ( !pt->pending_intr_nr ) + { + /* Make sure timer follows vCPU. */ + migrate_timer(&pt->timer, current->processor); set_timer(&pt->timer, pt->scheduled); + } } static void pt_timer_fn(void *data) @@ -268,21 +218,15 @@ static void pt_timer_fn(void *data) v = pt->vcpu; irq = pt->irq; - if ( inject_interrupt(pt) ) + pt->scheduled += pt->period; + + if ( !inject_interrupt(pt) ) + pt->pending_intr_nr++; + else { - pt->scheduled += pt->period; - pt->do_not_freeze = 0; cb = pt->cb; cb_priv = pt->priv; } - else - { - /* Masked. */ - if ( pt->on_list ) - list_del(&pt->list); - pt->on_list = false; - pt->pending_intr_nr++; - } pt_unlock(pt); @@ -304,22 +248,12 @@ static void eoi_callback(unsigned int unused, void *data) pt_lock(pt); pt_irq_fired(pt->vcpu, pt); - if ( pt->pending_intr_nr ) + if ( pt->pending_intr_nr && inject_interrupt(pt) ) { - if ( inject_interrupt(pt) ) - { - pt->pending_intr_nr--; - cb = pt->cb; - cb_priv = pt->priv; - v = pt->vcpu; - } - else - { - /* Masked. */ - if ( pt->on_list ) - list_del(&pt->list); - pt->on_list = false; - } + pt->pending_intr_nr--; + cb = pt->cb; + cb_priv = pt->priv; + v = pt->vcpu; } pt_unlock(pt); @@ -378,19 +312,6 @@ static bool inject_interrupt(struct periodic_time *pt) return true; } -void pt_migrate(struct vcpu *v) -{ - struct list_head *head = &v->arch.hvm.tm_list; - struct periodic_time *pt; - - pt_vcpu_lock(v); - - list_for_each_entry ( pt, head, list ) - migrate_timer(&pt->timer, v->processor); - - pt_vcpu_unlock(v); -} - void create_periodic_time( struct vcpu *v, struct periodic_time *pt, uint64_t delta, uint64_t period, uint8_t irq, time_cb *cb, void *data, bool level) @@ -410,8 +331,6 @@ void create_periodic_time( write_lock(&v->domain->arch.hvm.pl_time->pt_migrate); pt->pending_intr_nr = 0; - pt->do_not_freeze = 0; - pt->irq_issued = 0; /* Periodic timer must be at least 0.1ms. */ if ( (period < 100000) && period ) @@ -469,9 +388,6 @@ void create_periodic_time( break; } - pt->on_list = 1; - list_add(&pt->list, &v->arch.hvm.tm_list); - init_timer(&pt->timer, pt_timer_fn, pt, v->processor); set_timer(&pt->timer, pt->scheduled); @@ -487,9 +403,6 @@ void destroy_periodic_time(struct periodic_time *pt) return; pt_lock(pt); - if ( pt->on_list ) - list_del(&pt->list); - pt->on_list = 0; pt->pending_intr_nr = 0; gsi = pt->irq; @@ -511,51 +424,6 @@ void destroy_periodic_time(struct periodic_time *pt) kill_timer(&pt->timer); } -static void pt_adjust_vcpu(struct periodic_time *pt, struct vcpu *v) -{ - ASSERT(pt->source == PTSRC_isa || pt->source == PTSRC_ioapic); - - if ( pt->vcpu == NULL ) - return; - - write_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); - pt->vcpu = v; - if ( pt->on_list ) - { - list_del(&pt->list); - list_add(&pt->list, &v->arch.hvm.tm_list); - migrate_timer(&pt->timer, v->processor); - } - write_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); -} - -void pt_adjust_global_vcpu_target(struct vcpu *v) -{ - struct PITState *vpit; - struct pl_time *pl_time; - int i; - - if ( !v || !has_vpit(v->domain) ) - return; - - vpit = &v->domain->arch.vpit; - - spin_lock(&vpit->lock); - pt_adjust_vcpu(&vpit->pt0, v); - spin_unlock(&vpit->lock); - - pl_time = v->domain->arch.hvm.pl_time; - - spin_lock(&pl_time->vrtc.lock); - pt_adjust_vcpu(&pl_time->vrtc.pt, v); - spin_unlock(&pl_time->vrtc.lock); - - write_lock(&pl_time->vhpet.lock); - for ( i = 0; i < HPET_TIMER_NUM; i++ ) - pt_adjust_vcpu(&pl_time->vhpet.pt[i], v); - write_unlock(&pl_time->vhpet.lock); -} - static void pt_resume(struct periodic_time *pt) { struct vcpu *v; @@ -566,14 +434,12 @@ static void pt_resume(struct periodic_time *pt) return; pt_lock(pt); - if ( pt->pending_intr_nr && !pt->on_list && inject_interrupt(pt) ) + if ( pt->pending_intr_nr && inject_interrupt(pt) ) { pt->pending_intr_nr--; cb = pt->cb; cb_priv = pt->priv; v = pt->vcpu; - pt->on_list = 1; - list_add(&pt->list, &pt->vcpu->arch.hvm.tm_list); } pt_unlock(pt); diff --git a/xen/include/asm-x86/hvm/vcpu.h b/xen/include/asm-x86/hvm/vcpu.h index 8adf4555c2a..9a756964fb0 100644 --- a/xen/include/asm-x86/hvm/vcpu.h +++ b/xen/include/asm-x86/hvm/vcpu.h @@ -148,9 +148,8 @@ struct hvm_vcpu { s64 cache_tsc_offset; u64 guest_time; - /* Lock and list for virtual platform timers. */ + /* Lock for virtual platform timers. */ spinlock_t tm_lock; - struct list_head tm_list; bool flag_dr_dirty; bool debug_state_latch; diff --git a/xen/include/asm-x86/hvm/vpt.h b/xen/include/asm-x86/hvm/vpt.h index 9440fe4ac7d..af04efa5e01 100644 --- a/xen/include/asm-x86/hvm/vpt.h +++ b/xen/include/asm-x86/hvm/vpt.h @@ -31,11 +31,7 @@ typedef void time_cb(struct vcpu *v, void *opaque); struct periodic_time { - struct list_head list; - bool on_list; bool one_shot; - bool do_not_freeze; - bool irq_issued; bool warned_timeout_too_short; bool level; #define PTSRC_isa 1 /* ISA time source */ @@ -145,11 +141,9 @@ struct pl_time { /* platform time */ struct domain *domain; }; -void pt_save_timer(struct vcpu *v); -void pt_restore_timer(struct vcpu *v); -void pt_migrate(struct vcpu *v); +void pt_freeze_time(struct vcpu *v); +void pt_thaw_time(struct vcpu *v); -void pt_adjust_global_vcpu_target(struct vcpu *v); #define pt_global_vcpu_target(d) \ (is_hvm_domain(d) && (d)->arch.hvm.i8259_target ? \ (d)->arch.hvm.i8259_target : \ @@ -158,7 +152,7 @@ void pt_adjust_global_vcpu_target(struct vcpu *v); void pt_may_unmask_irq(struct domain *d, struct periodic_time *vlapic_pt); /* Is given periodic timer active? */ -#define pt_active(pt) ((pt)->on_list || (pt)->pending_intr_nr) +#define pt_active(pt) ((pt)->pending_intr_nr || timer_is_active(&(pt)->timer)) /* * Create/destroy a periodic (or one-shot!) timer. -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 31 10:36:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 10:36:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103861.198127 (Exim 4.92) (envelope-from ) id 1lRYDP-0005QP-Cz; Wed, 31 Mar 2021 10:36:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103861.198127; Wed, 31 Mar 2021 10:36:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYDP-0005QI-8g; Wed, 31 Mar 2021 10:36:47 +0000 Received: by outflank-mailman (input) for mailman id 103861; Wed, 31 Mar 2021 10:36:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYDN-0005P3-NK for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 10:36:45 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e8057e55-bac8-4d14-b16e-6e684cd096bf; Wed, 31 Mar 2021 10:36:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8057e55-bac8-4d14-b16e-6e684cd096bf DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617187004; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=JPCmVO9asq4INCZJr57/0dCrCiXwQMJC6md2SxhVFUA=; b=c9zNBZqcsB2+0+gVHTEXdjt7yXbQZLT9gH+Gspal3Va/LVhX+Jjv9bic musVEHh5as9n4ZqQw+FLN6pb2pFWeasX5yWFYiqDPOuhBohBtxzneX5ev x+qFb7fFSiG4NxieZEK3W40KR5ii/KwEI6+JF8H3y3+/MQcqtheIASWbh Q=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: re6kwNWVYOTXd+BZWHE3Mnn33KcpCYvPJYP3KfhJe2Z85yyiXaDDrrVO843nBt9yiU2I8yU16T hg/8H8nDDO2aP7nA3YcqucSQSDrjg30z0UO6ex91pDDXmN13GEMU67vIXTYsc3cTYBvZrxhYAc j3Sltq+WLRB2BZRAOACqOV6qdeVvfKtEQSo1m3p6KDNBZ8mYzE6k2gc+EYoUi8LYBgGT3aleMX LZ+z1W6hHa8G66a1p1OGYEQwFoODkv3BCS301vsceJbwdw0gNZLy1UDyArZN+RDFUUB2/NDHGM hSM= X-SBRS: 5.2 X-MesageID: 40415700 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:RyErbq9TtTZ4PCIjgRJuk+ECdb1zdoIgy1knxilNYDRIb82VkN 2vlvwH1RnyzA0cQm0khMroAsS9aFnb8oN45pRUAKe6UGDdyQ6VBaxBza+n+T3vHCXi6vVQvJ 0LT4FSAMD9ZGIUse/U+w+9euxP/PCi0ISFwdjT1G1sSwYCUdAD0y5cBhyAGkN7AClqbKBYKL Om6sBKpyWtdB0sB6zWOlA/U/XevNqOrZr6YHc9bCIP0hWEjj+j9dfBYnul9yoZOgkv/Z4StV Lrvia8zaWlvvG9xHbnphXuxqUTovTN4J9uAMSNj+IcNznjjB25Db4RJoGqjXQOj8yErHosjd nQszcsVv4Dl0/5TyWOjjbGnynmzTo05HfpxTaj8ATeiP28fh0WIY5lp+tiA3/kwntlhv5Q+u Z3+ljckJxtARbJjE3GlqD1fiAvrGWYiz4fi+IJ5kYvNrc2WftqgqE02lhaK5sEFDKS0vFdLM BeSPvR4/tbajqhHhbkl1gqxNStW0I6FQudTn4DvdSI0yNXkGoR9Tpg+PAi X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40415700" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FeoLPm0S04X22AEQ4NWEiE6YXTD7MgmfZVE+WmQ0XzFHcZGqRnQ+KIsOgaEmROPIo6+quiO622/eymc7Y/rgMjJrHaDNhVK8bkSogrIEAVeYP2/WzDySqfQM0NNp6EdTqqOd6h1lJ4iB/VD6flrqgvPiSZz4KAy00nSnpUGhSKtGiAOzScnt2/FrnbMbAx6ZHtybnLAzkCBU4AMADF+4pSOApop4WyS0BWlJ/KX34I+ULoqmCHG1b0LK5WhABiRuYOPv16sfXrUL6E0Fk9IqQiAxTBzWOpkcTQwUMlCLVsgNfHRAE038+Kn8XSt1fjXkR1Ne2c0po4W/kFTW69lFpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SoQnGzbvC7IXy//qY3Etmc+ztTD9ZjxducZ3X6OtCAg=; b=hNUXZrIbieTUVJKplkJ7eIGMd6FDmUtlPkGcd6tQ5Skqh5TLRXB5ri2C1nsmcxQyQr3O7SK8JUhD5i++Eq57FWlHSRu17C2VEtw3uzVenrxrJQ9UbkRlkltGpY7NLkLmynXybnc+sUPBs5wuLAUBaarPt6yUElPN9HTPleCc0AHhqa6Wm1Jp5S60Y/b5XztJfAGrf5QklCeENwKIZG39OIBJf4sL72X5cc63bNmVGoyMfNuhWM+kxRVRJK2JcVf/8Y/wyqEXQpEj16UWIs2IaU67F4VtXEWadvutdzc/XGjeU+puinwSC1Gex6USg8I2HUPYSqHOveMMSV7RuOFYSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SoQnGzbvC7IXy//qY3Etmc+ztTD9ZjxducZ3X6OtCAg=; b=Z8H4ow4GMZloXwn1ykrpTSomkhCnprm8xPFTU7dK3LgvziGoFlUSbYkLkTrNmDnjJIsDFF6NkpI3TU8gVK+KDVqN7sHK2EJ0niFmcFlJ9Bwoy8Mev0oCHQ8lnbO2mf/rOzUd2iol+zkni9WwRu1R089yqS0oF6p9dp2LJNLGqt4= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v3 11/11] x86/vpt: introduce a per-vPT lock Date: Wed, 31 Mar 2021 12:33:03 +0200 Message-ID: <20210331103303.79705-12-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210331103303.79705-1-roger.pau@citrix.com> References: <20210331103303.79705-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0077.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 38e6f590-6b03-4422-99d2-08d8f430ded4 X-MS-TrafficTypeDiagnostic: DM4PR03MB5968: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:261; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SHJCVJYXsinhDJK20ruHDKPFq2a/Tfit3eRZDPoiB0xpZUWsLX5ON9RvbIdfybicUnLsDuWg2xSz+T5QxKwxna4eXD1l/FC3TpsUvNPC+o3dmIrMpBNbSSfEVFZOxndV+BVgCgKEtQdKObmRTWaJKyVJIY8TBRX8or+bwTr66YbFhEr/cD1vCGmlzkZGgmanyGGglIgtcqsg/NIEtDNr/BO0P4MWq7G2nslgWyP22bmajqQXhvgCV5+sRMqGMY/HF7+/SibPrY5HtpNNvPLhINblexDeud2dDPWYJfEZrh7K3qfL+jEWDW1R0WUJt7AHjP/MgfU8D5UMlU9K+RYcHXFesj5szUBQVMYhY0HJVGd280JJYwHyQcg8L9UhM6tCVErd/sxKpQCad5k6WF8JGG6/PS/vLDB4tn7gdwy3OdXWJLaaThcY6/gKc4tgvQyMSSMnYO7Fe/vTFm/eO5rronv1HEc2YViREmYAiNCEyCm1gOM64sABNOL1yoGkVnrhAykwUKOPu67M4DnzSS1gcFjob3jnZr0AYC+u7tHUJD4sUMAYfhITt+faNR/A5rfz2Apjd8DZVKpKEkI7nt4t9PDpj/Qn9WJDrwgadBx4ApbPOpX7xGkZHH8SOcbazF6Q14jbeY75VPqKhOxewFGKtA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(26005)(2906002)(6486002)(8676002)(1076003)(36756003)(38100700001)(8936002)(83380400001)(16526019)(86362001)(186003)(6916009)(6496006)(66556008)(66946007)(478600001)(66476007)(5660300002)(316002)(4326008)(2616005)(6666004)(956004)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?R3RhU1BlZkdhK2I0aDlPeEpqMStwLzdIa1dnQkY5Rmh5ZUpXRXV3aHNkRFQr?= =?utf-8?B?emlMbkdrSzNkc0lseXh6QmdYWnZZVGxlMlFWV0RwakVxT1JuNXpmczdhRUkv?= =?utf-8?B?UXF1d2hoMHBFNHJSeEdiSEtxZURJL1N4ZlZQd2xiaEpOY1owdjhhUUJ4TW0r?= =?utf-8?B?YnEzMW0xdHlpT2ZSVk03c2ZpbWlYODFkQnNsREhrQUIwSHpJRGprWmRLWERx?= =?utf-8?B?OU5TV2szUjlGZDBwWWN5ZVlIZ3piN3dPQ0g3aHlQUHNId0Z3YlV2N21HWXJZ?= =?utf-8?B?TEtxOHVEMERoSWF0OWh6cksyYVI1cythdi9WNUNRbHhqRE03cWhiSFkvWWdF?= =?utf-8?B?UjUyS3FXUnNSeGVUdTlVbUN1Rmtvc1A3am9BemZHTUNIK0lLNEdqMk1GeG9R?= =?utf-8?B?dnBudFU5VWc4eXdNczRIRHZpZXBIM2lnRGFKcDU3eWVzckxiamdQRU90dUta?= =?utf-8?B?MmlMZ1g1RHFJMnNTR2tjRi9VZlROUk1HYUVkdEJ1SkYzNVNsNjR2cUdZb0pP?= =?utf-8?B?N1RCRUQzUjJXWEJWQSt6d3FqeC9saVZ5d3NWeGVhdzFoVjRhN3Y0U0ZiSm9x?= =?utf-8?B?UWFLU1RyWGIrRXNIdEtBYWE0MU9YSnh5N2cxKyt6bTQvSGloVHpjSGVhcTd1?= =?utf-8?B?cnRZeWZoOTJzbkorQlV3SGRkWXpGUEZkNDdtZTBXNHlqMERYMnE2bWkxL25J?= =?utf-8?B?TmUrRmRtWWlJOWsva1l5K2tMQnpxRHNzSGRQYk5tRVlYeEtibnJTUnJEbGNB?= =?utf-8?B?UnRmVEhmdWt2SElCSTZnbEZjNm5ueTQvNC93QlRud2pnZnBUS0JMRzVXa0hZ?= =?utf-8?B?cFdxS2x1RDkzSkQ2N0dvRHl4aGk3c1UrNWVvQk1DSTRFUUhwUFVhU1g4czVN?= =?utf-8?B?RDJzWDR4RGlqbEI1ekRHaElBK3pCOXQ0UVlyVHBlK2V3SldobU4rcm1nemda?= =?utf-8?B?MXJpNElEdnRMcHRZMWQxc1hFYzJrMmJuTzMrVmVMWUtsQXBCc09KN3k0Tkl5?= =?utf-8?B?T3NCNGp4amNqZFJJemgzelJOMW8vUWdld0hoN1o1UTBldXY5eVhnTUNHL2t3?= =?utf-8?B?c3VZc0RpcjlPeWFUdGJNUDZDQ1Z4NVhVL0ZUSzErU0xzY3dBY01FaHNPaDBu?= =?utf-8?B?NmRSbFM2TU0wMk5nYXVubjd1Wno1ZzRqN1Z3U3hycnJGNzE2dzRHV0U2VGN4?= =?utf-8?B?R3Qxd210QnZMSStZQ0p3VG5DTlh6d0p0YTR5NHRTOHhJU04vR3BrOCt6WjFL?= =?utf-8?B?MHlNS2w3dXdQaExLeklJQUhCYnBPbEQzUWRqcGZpTnhQNENpM1dGTmFIdmNm?= =?utf-8?B?Sy8xdDFoVW9SdTFKUTlXalNwaGNIbVdMZkFSUmZZenZEbG54Zm96dzd2VXRj?= =?utf-8?B?WG9NelJzbU1Tbkp5QnBnNDNudmlDbVdhZ2doSyszdUxUZzJFZjhwYllGOXYv?= =?utf-8?B?YXIvalp1aEo5V2VzN2xjWllKL0YzdERmUExSakMxSjc5aGVIcndtVlZhamxy?= =?utf-8?B?MnBzbjhXVy9YL0daV0xxZzV2eXFzVTY4czUvUzdDUTRoM3A1Z254OHJVdm5N?= =?utf-8?B?dWt3MWZoWFdBamw2Mlg3OGVRV1BsZjhmV2NRZktSK2R6TEFwU0hmdWNEUDJM?= =?utf-8?B?ZGFIMTZFZXBpYm1yQk5sOW9Ic05OOFEvWnBzZnNpNWV5YlFaaW5pWnNlNU1K?= =?utf-8?B?UHhaM25Ub1F2dUNMemZxT2VKZ2Q0UmVzNUc0ZHdMTWhtdXhpSkFrNExYUU5L?= =?utf-8?Q?80b/sCpWmUJmh9NAtRbdUVI5QMvzHuoMZCLmkcX?= X-MS-Exchange-CrossTenant-Network-Message-Id: 38e6f590-6b03-4422-99d2-08d8f430ded4 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 10:36:40.7923 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UzBoUqqnaX7cmcSwvHyMqDesYwrSL0pDPxYDUPnGM9+W02FIX7EwEI8iDYse2fB4RNeVX2AXFpyo028Fh0uI8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5968 X-OriginatorOrg: citrix.com Introduce a per virtual timer lock that replaces the existing per-vCPU and per-domain vPT locks. Since virtual timers are no longer assigned or migrated between vCPUs the locking can be simplified to a in-structure spinlock that protects all the fields. This requires introducing a helper to initialize the spinlock, and that could be used to initialize other virtual timer fields in the future. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Changes since v1: - New in his version. --- xen/arch/x86/emul-i8254.c | 1 + xen/arch/x86/hvm/hpet.c | 8 +++++- xen/arch/x86/hvm/hvm.c | 4 --- xen/arch/x86/hvm/rtc.c | 1 + xen/arch/x86/hvm/vlapic.c | 1 + xen/arch/x86/hvm/vpt.c | 48 +++++++++++++++------------------- xen/include/asm-x86/hvm/vcpu.h | 3 --- xen/include/asm-x86/hvm/vpt.h | 9 ++----- 8 files changed, 33 insertions(+), 42 deletions(-) diff --git a/xen/arch/x86/emul-i8254.c b/xen/arch/x86/emul-i8254.c index 73be4188ad4..a47138cbab7 100644 --- a/xen/arch/x86/emul-i8254.c +++ b/xen/arch/x86/emul-i8254.c @@ -484,6 +484,7 @@ void pit_init(struct domain *d, unsigned long cpu_khz) { register_portio_handler(d, PIT_BASE, 4, handle_pit_io); register_portio_handler(d, 0x61, 1, handle_speaker_io); + init_periodic_timer(&pit->pt0); } pit_reset(d); diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c index ca94e8b4538..20593c3862d 100644 --- a/xen/arch/x86/hvm/hpet.c +++ b/xen/arch/x86/hvm/hpet.c @@ -739,12 +739,18 @@ static void hpet_set(HPETState *h) void hpet_init(struct domain *d) { + HPETState *h = domain_vhpet(d); + unsigned int i; + if ( !has_vhpet(d) ) return; - hpet_set(domain_vhpet(d)); + hpet_set(h); register_mmio_handler(d, &hpet_mmio_ops); d->arch.hvm.params[HVM_PARAM_HPET_ENABLED] = 1; + + for ( i = 0; i < HPET_TIMER_NUM; i++ ) + init_periodic_timer(&h->pt[i]); } void hpet_deinit(struct domain *d) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 3a72da67ef2..1c014fc26c3 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -665,8 +665,6 @@ int hvm_domain_initialise(struct domain *d) /* need link to containing domain */ d->arch.hvm.pl_time->domain = d; - rwlock_init(&d->arch.hvm.pl_time->pt_migrate); - /* Set the default IO Bitmap. */ if ( is_hardware_domain(d) ) { @@ -1556,8 +1554,6 @@ int hvm_vcpu_initialise(struct vcpu *v) hvm_asid_flush_vcpu(v); - spin_lock_init(&v->arch.hvm.tm_lock); - rc = hvm_vcpu_cacheattr_init(v); /* teardown: vcpu_cacheattr_destroy */ if ( rc != 0 ) goto fail1; diff --git a/xen/arch/x86/hvm/rtc.c b/xen/arch/x86/hvm/rtc.c index 3150f5f1479..2d540b16acd 100644 --- a/xen/arch/x86/hvm/rtc.c +++ b/xen/arch/x86/hvm/rtc.c @@ -846,6 +846,7 @@ void rtc_init(struct domain *d) init_timer(&s->update_timer, rtc_update_timer, s, smp_processor_id()); init_timer(&s->update_timer2, rtc_update_timer2, s, smp_processor_id()); init_timer(&s->alarm_timer, rtc_alarm_cb, s, smp_processor_id()); + init_periodic_timer(&s->pt); register_portio_handler(d, RTC_PORT(0), 2, handle_rtc_io); diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index 8091b6d8925..688ff85e710 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -1651,6 +1651,7 @@ int vlapic_init(struct vcpu *v) return 0; } + init_periodic_timer(&vlapic->pt); vlapic->pt.source = PTSRC_lapic; vlapic->regs_page = alloc_domheap_page(v->domain, MEMF_no_owner); diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index 84d49c1b25c..9cb0b8a0a82 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -126,23 +126,6 @@ static int pt_irq_masked(struct periodic_time *pt) return 1; } -static void pt_lock(struct periodic_time *pt) -{ - /* - * We cannot use pt_vcpu_lock here, because we need to acquire the - * per-domain lock first and then (re-)fetch the value of pt->vcpu, or - * else we might be using a stale value of pt->vcpu. - */ - read_lock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); - spin_lock(&pt->vcpu->arch.hvm.tm_lock); -} - -static void pt_unlock(struct periodic_time *pt) -{ - spin_unlock(&pt->vcpu->arch.hvm.tm_lock); - read_unlock(&pt->vcpu->domain->arch.hvm.pl_time->pt_migrate); -} - static void pt_process_missed_ticks(struct periodic_time *pt) { s_time_t missed_ticks, now = NOW(); @@ -213,7 +196,7 @@ static void pt_timer_fn(void *data) void *cb_priv; unsigned int irq; - pt_lock(pt); + spin_lock(&pt->lock); v = pt->vcpu; irq = pt->irq; @@ -228,7 +211,7 @@ static void pt_timer_fn(void *data) cb_priv = pt->priv; } - pt_unlock(pt); + spin_unlock(&pt->lock); if ( cb ) cb(v, cb_priv); @@ -245,7 +228,7 @@ static void eoi_callback(unsigned int unused, void *data) time_cb *cb = NULL; void *cb_priv; - pt_lock(pt); + spin_lock(&pt->lock); pt_irq_fired(pt->vcpu, pt); if ( pt->pending_intr_nr && inject_interrupt(pt) ) @@ -256,7 +239,7 @@ static void eoi_callback(unsigned int unused, void *data) v = pt->vcpu; } - pt_unlock(pt); + spin_unlock(&pt->lock); if ( cb ) cb(v, cb_priv); @@ -312,6 +295,11 @@ static bool inject_interrupt(struct periodic_time *pt) return true; } +void init_periodic_timer(struct periodic_time *pt) +{ + spin_lock_init(&pt->lock); +} + void create_periodic_time( struct vcpu *v, struct periodic_time *pt, uint64_t delta, uint64_t period, uint8_t irq, time_cb *cb, void *data, bool level) @@ -328,7 +316,7 @@ void create_periodic_time( destroy_periodic_time(pt); - write_lock(&v->domain->arch.hvm.pl_time->pt_migrate); + spin_lock(&pt->lock); pt->pending_intr_nr = 0; @@ -391,18 +379,21 @@ void create_periodic_time( init_timer(&pt->timer, pt_timer_fn, pt, v->processor); set_timer(&pt->timer, pt->scheduled); - write_unlock(&v->domain->arch.hvm.pl_time->pt_migrate); + spin_unlock(&pt->lock); } void destroy_periodic_time(struct periodic_time *pt) { unsigned int gsi; + spin_lock(&pt->lock); /* Was this structure previously initialised by create_periodic_time()? */ if ( pt->vcpu == NULL ) + { + spin_unlock(&pt->lock); return; + } - pt_lock(pt); pt->pending_intr_nr = 0; gsi = pt->irq; @@ -415,7 +406,7 @@ void destroy_periodic_time(struct periodic_time *pt) hvm_gsi_unregister_callback(pt->vcpu->domain, gsi, &pt->eoi_cb); break; } - pt_unlock(pt); + spin_unlock(&pt->lock); /* * pt_timer_fn() can run until this kill_timer() returns. We must do this @@ -430,10 +421,13 @@ static void pt_resume(struct periodic_time *pt) time_cb *cb = NULL; void *cb_priv; + spin_lock(&pt->lock); if ( pt->vcpu == NULL ) + { + spin_unlock(&pt->lock); return; + } - pt_lock(pt); if ( pt->pending_intr_nr && inject_interrupt(pt) ) { pt->pending_intr_nr--; @@ -441,7 +435,7 @@ static void pt_resume(struct periodic_time *pt) cb_priv = pt->priv; v = pt->vcpu; } - pt_unlock(pt); + spin_unlock(&pt->lock); if ( cb ) cb(v, cb_priv); diff --git a/xen/include/asm-x86/hvm/vcpu.h b/xen/include/asm-x86/hvm/vcpu.h index 9a756964fb0..fe3d0e10426 100644 --- a/xen/include/asm-x86/hvm/vcpu.h +++ b/xen/include/asm-x86/hvm/vcpu.h @@ -148,9 +148,6 @@ struct hvm_vcpu { s64 cache_tsc_offset; u64 guest_time; - /* Lock for virtual platform timers. */ - spinlock_t tm_lock; - bool flag_dr_dirty; bool debug_state_latch; bool single_step; diff --git a/xen/include/asm-x86/hvm/vpt.h b/xen/include/asm-x86/hvm/vpt.h index af04efa5e01..5628cff8f7a 100644 --- a/xen/include/asm-x86/hvm/vpt.h +++ b/xen/include/asm-x86/hvm/vpt.h @@ -48,6 +48,7 @@ struct periodic_time { time_cb *cb; void *priv; /* point back to platform time source */ struct hvm_gsi_eoi_callback eoi_cb; /* EOI callback registration data */ + spinlock_t lock; }; @@ -126,13 +127,6 @@ struct pl_time { /* platform time */ struct RTCState vrtc; struct HPETState vhpet; struct PMTState vpmt; - /* - * rwlock to prevent periodic_time vCPU migration. Take the lock in read - * mode in order to prevent the vcpu field of periodic_time from changing. - * Lock must be taken in write mode when changes to the vcpu field are - * performed, as it allows exclusive access to all the timers of a domain. - */ - rwlock_t pt_migrate; /* guest_time = Xen sys time + stime_offset */ int64_t stime_offset; /* Ensures monotonicity in appropriate timer modes. */ @@ -167,6 +161,7 @@ void create_periodic_time( struct vcpu *v, struct periodic_time *pt, uint64_t delta, uint64_t period, uint8_t irq, time_cb *cb, void *data, bool level); void destroy_periodic_time(struct periodic_time *pt); +void init_periodic_timer(struct periodic_time *pt); int pv_pit_handler(int port, int data, int write); void pit_reset(struct domain *d); -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 31 10:36:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 10:36:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103864.198139 (Exim 4.92) (envelope-from ) id 1lRYDW-0005X1-07; Wed, 31 Mar 2021 10:36:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103864.198139; Wed, 31 Mar 2021 10:36:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYDV-0005Wm-RI; Wed, 31 Mar 2021 10:36:53 +0000 Received: by outflank-mailman (input) for mailman id 103864; Wed, 31 Mar 2021 10:36:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYDU-0004so-Ke for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 10:36:52 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 848fdff6-3a6a-4e73-975d-5606b01201b4; Wed, 31 Mar 2021 10:36:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 848fdff6-3a6a-4e73-975d-5606b01201b4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617186991; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=NZnmw6vdqBrw2HPwEJs9LRsvlJ7YMCZXRIR6F1TNqXQ=; b=Y6gnRn3/AlNV9F//I+VVFamzBmulVq3teDNd0llH7sQVs1oON+UxSrSp JqswhCSgB7Q7M12Xk6PDs77xH9VYFXglyaFTkUiEnH3DBa/AtyJedvRrr FlvZ0PpRcftuZgd5aJAlOSzId4dO3tK+CwV+Uff7lhxpo2jgKx5eloqJ0 c=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: GzYTQ1HxW4/iEHxlp2hC6o+GzQMoG5d0fUIe3/pRAVPJraW/n3TDyEZFC07via+8zjiwpi0wVc whzUJTXHFmdgyYsAGF6gSqIc6OBoI1TYrUzOctuhoZb58JZQfia4zBrp4zAl+Xkmzyc+sKWIB2 XZBKXgmeSu/RPHlPu15yRTo5AhE35ksYLV9w1EutHraI2rIoZN5ShsI4yEkYH7Ct2Ch53aeECO de5GAgKBkdtUgmmVdpDM4Wqij899u08/dX7BzYh8qsG4psfO6WzVx36NlhQ0BtDX0d98VFiFO/ HZs= X-SBRS: 5.2 X-MesageID: 41994610 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:5Z2CPqzAJ2ZG66JsG6yaKrPx9uskLtp033Aq2lEZdDV8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPsfVr385lp7Y4NeYqzRQWOghrMEKhOz6vHhwfhFSr36/JH2c 5bGZRWJdXsATFB4vrSzxK/F78bruWv1ICNqaPgw2x2TQdsApsQjTtRLgqACEV5SE1nKPMCdK a03cZMqzq+dXl/VK3SakUtZOTfu8bN0KvvfB9uPXUawTOThjCl4qOSKWn64j4iVVp0oIsKwC z+vCHSoo6itPy6zRG07R6o071m3OHP5/EGKMiFis0+IijhhACydO1aKsC/lQFwms6DwhIHl8 TNvgcBMq1Img/sV1DwmzTB8U3B1ysj8HDrw1PwuwqdneXJAAgUJuAEoKAxSGq812MQ+OtS/Y gO4kei871QNh/ElDSV3amxazha0nCajFBnrfQelBVkIOwjQY4Ul6Mz1mVPHqwNGSrrgbpXa9 VGPYXn6PFafUjyVQG+gkBfhNilXnEEFhybWEQ1usuMzzhMnHxipnFovfAiog== X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="41994610" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d2Ojk7gvmCog++XfKvxRBCX2dedGlbt9kTsPQ3gTWFf1BC/5PNZWST30tG9c+FqLs3xzoaHt8Cznj9Eh9ysrkEQsux89s7V9QBKIjyNlUD+bfgrtRtAF9lcY9T73JIfwm9iDKbokbqdlc1z8kht2f+ynWepRXr65GMgrcFuRXZZ+LvPZ99I7JBDkSX3GZqfk2jyl9YBqUXVJnHOXBVV0GnYLB5M4CrkS6a5WQPxDpMVbm8UvJnyCGu8T3+l68VXW+SMtrszN4F/3DI90UucpdZ1ii5iB4LNhyvAcZ5EmeKLDzkfStVL3KuyFfQJN5BsKJwx+NDfchGVmE4HcZIB2hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uvejW0nULK+NfwUACCxHzbAooqbar4wdYJPJ8qc6zcg=; b=bbT5V746CEPGMTMzqUwWJEzbuPM+hPhw6fOPzFhfuNo95GZr13T0Jgf9zMpGkcqu8oOA+nBXLCT8Jix/PeYgudYrlSUpayheIqFZMHgbSRkA9xzmT11yJdvflMzvQJhdoJwm3/TQbO11bHSttserEeCjCiq3vBRBdX/knllbiFLqMVuF+onVTo7Xz0aiB7u1DGO//fn29XJ4t3Yqcbcjzrc+tTgZhao+3/KN4EEPE0uAS+Wl25L79prXqNkbMG1iduY2VWHZGiilhR4Hmx00Y4YsPMXmKidmKk9sqw3POCQAq6cQZqLVZR6DbC2v1RtHUGKBwnjHaR7uOrnp3l9w1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uvejW0nULK+NfwUACCxHzbAooqbar4wdYJPJ8qc6zcg=; b=HB2zT/oIfOOy0/9rv2+bWWk4cy+78gf/RNXpLHcP25E6JznNdUb10UKHS2sZel6LLjke4LY41wAXaYB1l6ReT1Z6bVQcI3ib4ens53gvs4vwKEXNrAEBkpey1XWKf4va46sLZGP9ec9igIjKwhBi6GKPm52cTio1m0cPPxi3K4o= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH v3 09/11] x86/vpt: switch interrupt injection model Date: Wed, 31 Mar 2021 12:33:01 +0200 Message-ID: <20210331103303.79705-10-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210331103303.79705-1-roger.pau@citrix.com> References: <20210331103303.79705-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0074.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1fc51022-c600-476c-0387-08d8f430d76e X-MS-TrafficTypeDiagnostic: DM4PR03MB5968: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CWBMoWg50CVpYeXzJCIsg0l+OuXpEzcGG372ZehWBqSgPv1O7ABsq8iDAAFXIQplDQasHG+/3k6YMBSF5bfLr3E8k186JD9GWC5J68R7NFXaQmObx292vfV09bZj3NDGLV7WqyFO4NgbZtS2pxUtLnefJD1b9tLMl51LJx7vZ06HO7Ye9WmaoPCOg0Sf+IHKiPj530PiTQPa2XbBn5GtxcctxHnc24nvHSOvS8giAdVFlw5QxutGXAgSxNSqTQCGDocIJ2no3xlpc2O0mtPd/zUSLqclcvWBpNorR8watRgSEOsC+hu7CPUVL/iUs5K9j72GsWbIgX1eNSOZitoSnAHIprFTqST/2VwBu7oG5RqWGEu8JvCp2tblICP91h5zogNBXTMyTQJDYodjq/JPq8/jnYB8OvTud1MeZoBiLMViw2oWcd6xHcWZL1w+kZ8YQ+Ww2kYCYPZ/GozkJ7YLHZajsc3rvuhmlLK6N+osK+hGg4+8KPTNFrwOgqRKlN8h6+8YUWX7SwLrftFKUroqtwKWTWfzqT69IAFe4YT+F57ZPPY+pu3kcNlJjo1WEcS3i7sBAPNlo3coMGsfDcgT2dGkOkeB+iwC+VSuq3U+/Q06y8n4nVvSI4zBsjflojqeITHQr7Fj3iCdIxb5XGeeiDvbgaulDk/rooetDc5aHwc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(26005)(2906002)(6486002)(30864003)(8676002)(1076003)(36756003)(38100700001)(8936002)(83380400001)(16526019)(86362001)(186003)(6916009)(6496006)(66556008)(66946007)(478600001)(66476007)(5660300002)(316002)(4326008)(2616005)(6666004)(956004)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?cHpEMEh1VUpHb29HWkJrSlNWbHlvZVdZY1owaU1qajFUWVZkVVRaOXp4cERT?= =?utf-8?B?TTRqbjA3UVBrdXI5RU9PWWxrZzZtU0hNMkFVcUoxVkZ2bGpRK0Vrc05jMk1I?= =?utf-8?B?a0lyNGlnd0hRMDl2NXhsTHBJYnNDZndtR0tyMXpoa0ZRZm8zTVJKVkl4VXcr?= =?utf-8?B?UzZOZ3dhd3JoRE14UUJoMDZHS2lDbXNOZXIrZ3Q1WHFGQ0cyVlh1dnlhNm1z?= =?utf-8?B?ZkZPOFZveXN1R2U1OWdSS1lhSVlSNW16aFA1Z2FKMVRMSHUyV0dwSEJVQUlJ?= =?utf-8?B?SGtlS2dSTFlWWDlSVEJwTDYzNUhCMlNUL2h1YlZSQzhTbUp4c1hOL3lOcTFD?= =?utf-8?B?bHEzSEgwWkdQOEpxTVdWR1RDZmZQbTZ2UUx1SDJiaWVvZ3BUeGxKN2hSUzd3?= =?utf-8?B?cVdLcmxaNjRRbmgvSTlVV2hic2kxQjBja29Udyt6c3J1U3VHdVhFQkdQRXNL?= =?utf-8?B?WXhIWlh4QS9kd3VjanNjM0NQU2hRUHZYY2NPaUNMaGlrYzhNUlQrbTRpaFhY?= =?utf-8?B?QjlkZC91cXg0M2FZbzErMU02cTVINjc2aVJFYWZiTW95ZC9JbmlCSlJRcnZ2?= =?utf-8?B?SmdETk40YVMrR1luWmpVQ0FsNE5UWXFEa2liS1Q1MHpsNzJ1UkVyMVUya1VZ?= =?utf-8?B?WGg1dmRoZTV3aGpHZ0xuSUNkUFMyY04zNlZIcFdidmhGUmtmdnI4K2lYTGdM?= =?utf-8?B?QWJ3NEdtVUxjZ3ozVGpGa3JZd0dUdTY2U3NQTnBUbnJjSXp2U0ZpNTNUVFV5?= =?utf-8?B?Yy9rNG8ybWRFUDlRYzBRcElXZWpCbXNERTRWZkt2VDF3alM4UkRLVGZDWU8w?= =?utf-8?B?aHBGekxZNFhZNHR4U01yK3V2WndTMC9aVjhZNk1pMGM1OEUrcGt1L25HYVQ4?= =?utf-8?B?RjAxb0JpeEVQd2xlVTNZRUhBNlVocWZQT2tZSVZVSHpWRGw0VURNYndLcmZN?= =?utf-8?B?a1RFZFhoRDFqazhWeS9CcWoxZmdBQng5MEdONU1UY2N3T2prRkdBK0U4Kzkv?= =?utf-8?B?Mi9hTnlISzdGc3c4WWRZbHZMbmdGdFhVLzA1dmtSNXNYL1VTbnRnWWY4bFl6?= =?utf-8?B?cUtGNnFVTFN3L2VFUnBOUHcwN2djcXVMZUE1ODJ6ZXk2WGE5Ti9NMzNMQW5n?= =?utf-8?B?VFR4V2czZjRXTUcwMWthS3Q1dXZIYXMyODRlSGlsV1pxZk1xVWhhNnBFMkx5?= =?utf-8?B?M1VHMVJVVEsyc29SckNHTG5yc1NuVVBOQzhqYStvMUhqV0IwalhnUFJrRDA5?= =?utf-8?B?OTdIcll1Qy9FdDhwK21UL29kdHA3aFg4TGRxQjl0RnZ0ZmpkU0FjcEU2RXZX?= =?utf-8?B?eEhaZ3U5MXozU0pkYUlMY2ZVV3NqaGF2dktqNXhRNDMvaDRyN0oyOVhtRUpP?= =?utf-8?B?ODhZMUg5YWZobGZ4YzFldmNvWFVvV20wQmlZTWlZdE1VODFoNkZ3QldBeWQ3?= =?utf-8?B?U25zdzE0VkFpY2lKUXprekhnbTJJNUh2TldnYitocExPajRQcENEV21yYUYv?= =?utf-8?B?VHh4UVlWaDlvWkRRTjBEQVNBMFJrK3BBejFxNXFBNG1mWUlMSEJHVXMwY0Iv?= =?utf-8?B?NUsyRmZZeGg2c2t5VGRMZVQ1SWlEY1JCekdRcDhoL1Q0azREaHlYVUhXcm5t?= =?utf-8?B?eDdnWWQ5M3I1SlZ5bHkreTdTYTJiTVhTdzBXeXNqRnRLM3dFc1VsSFA3UkI1?= =?utf-8?B?WnlEdzRzaG9iaE0vUldEcTRrQlptR3A3SFFJS1BEQVVzdExhU0dpRCtSTVcz?= =?utf-8?Q?K3ZmGWP+WVjZXG9BpaNAKvp3zd4zXNIpBC0xO6T?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1fc51022-c600-476c-0387-08d8f430d76e X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 10:36:28.4815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Oq/D4JsxTXKPEZp8VZR+pp4Y3uzK1S8PJFomABCQlqW83us1hS5UlrK8jntNbYwpauZUGra09OU4prD9zD7dSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5968 X-OriginatorOrg: citrix.com Currently vPT relies on timers being assigned to a vCPU and performing checks on every return to HVM guest in order to check if an interrupt from a vPT timer assigned to the vCPU is currently being injected. This model doesn't work properly since the interrupt destination vCPU of a vPT timer can be different from the vCPU where the timer is currently assigned, in which case the timer would get stuck because it never sees the interrupt as being injected. Knowing when a vPT interrupt is injected is relevant for the guest timer modes where missed vPT interrupts are not discarded and instead are accumulated and injected when possible. This change aims to modify the logic described above, so that vPT doesn't need to check on every return to HVM guest if a vPT interrupt is being injected. In order to achieve this the vPT code is modified to make use of the new EOI callbacks, so that virtual timers can detect when a interrupt has been serviced by the guest by waiting for the EOI callback to execute. This model also simplifies some of the logic, as when executing the timer EOI callback Xen can try to inject another interrupt if the timer has interrupts pending for delivery. Note that timers are still bound to a vCPU for the time being, this relation however doesn't limit the interrupt destination anymore, and will be removed by further patches. This model has been tested with Windows 7 guests without showing any timer delay, even when the guest was limited to have very little CPU capacity and pending virtual timer interrupts accumulate. Signed-off-by: Roger Pau Monné --- Changes since v2: - Avoid and explicit != NULL check. - Use a switch in inject_interrupt to evaluate the timer mode. - Print the pt->source field on error in create_periodic_time. Changes since v1: - New in this version. --- xen/arch/x86/hvm/svm/intr.c | 3 - xen/arch/x86/hvm/vmx/intr.c | 59 ------ xen/arch/x86/hvm/vpt.c | 334 ++++++++++++++-------------------- xen/include/asm-x86/hvm/vpt.h | 5 +- 4 files changed, 143 insertions(+), 258 deletions(-) diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c index 7f815d23078..2ee2332253b 100644 --- a/xen/arch/x86/hvm/svm/intr.c +++ b/xen/arch/x86/hvm/svm/intr.c @@ -146,8 +146,6 @@ void svm_intr_assist(void) return; /* Crank the handle on interrupt state. */ - pt_update_irq(v); - do { intack = hvm_vcpu_has_pending_irq(v); if ( likely(intack.source == hvm_intsrc_none) ) @@ -219,7 +217,6 @@ void svm_intr_assist(void) { HVMTRACE_2D(INJ_VIRQ, intack.vector, /*fake=*/ 0); svm_inject_extint(v, intack.vector); - pt_intr_post(v, intack); } /* Is there another IRQ to queue up behind this one? */ diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c index 80bfbb47878..3fcc7073db2 100644 --- a/xen/arch/x86/hvm/vmx/intr.c +++ b/xen/arch/x86/hvm/vmx/intr.c @@ -203,7 +203,6 @@ static int nvmx_intr_intercept(struct vcpu *v, struct hvm_intack intack) { /* for now, duplicate the ack path in vmx_intr_assist */ hvm_vcpu_ack_pending_irq(v, intack); - pt_intr_post(v, intack); intack = hvm_vcpu_has_pending_irq(v); if ( unlikely(intack.source != hvm_intsrc_none) ) @@ -242,7 +241,6 @@ void vmx_intr_assist(void) struct vcpu *v = current; unsigned int tpr_threshold = 0; enum hvm_intblk intblk; - int pt_vector; /* Block event injection when single step with MTF. */ if ( unlikely(v->arch.hvm.single_step) ) @@ -263,8 +261,6 @@ void vmx_intr_assist(void) #endif /* Crank the handle on interrupt state. */ - pt_vector = pt_update_irq(v); - do { unsigned long intr_info; @@ -337,58 +333,6 @@ void vmx_intr_assist(void) { unsigned long status; - /* - * intack.vector is the highest priority vector. So we set eoi_exit_bitmap - * for intack.vector - give a chance to post periodic time interrupts when - * periodic time interrupts become the highest one - */ - if ( pt_vector != -1 ) - { -#ifndef NDEBUG - /* - * We assert that intack.vector is the highest priority vector for - * only an interrupt from vlapic can reach this point and the - * highest vector is chosen in hvm_vcpu_has_pending_irq(). - * But, in fact, the assertion failed sometimes. It is suspected - * that PIR is not synced to vIRR which makes pt_vector is left in - * PIR. In order to verify this suspicion, dump some information - * when the assertion fails. - */ - if ( unlikely(intack.vector < pt_vector) ) - { - const struct vlapic *vlapic; - const struct pi_desc *pi_desc; - const uint32_t *word; - unsigned int i; - - printk(XENLOG_ERR "%pv: intack: %u:%02x pt: %02x\n", - current, intack.source, intack.vector, pt_vector); - - vlapic = vcpu_vlapic(v); - if ( vlapic && vlapic->regs ) - { - word = (const void *)&vlapic->regs->data[APIC_IRR]; - printk(XENLOG_ERR "vIRR:"); - for ( i = X86_NR_VECTORS / 32; i-- ; ) - printk(" %08x", word[i*4]); - printk("\n"); - } - - pi_desc = &v->arch.hvm.vmx.pi_desc; - if ( pi_desc ) - { - word = (const void *)&pi_desc->pir; - printk(XENLOG_ERR " PIR:"); - for ( i = X86_NR_VECTORS / 32; i-- ; ) - printk(" %08x", word[i]); - printk("\n"); - } - } -#endif - ASSERT(intack.vector >= pt_vector); - vmx_set_eoi_exit_bitmap(v, intack.vector); - } - /* we need update the RVI field */ __vmread(GUEST_INTR_STATUS, &status); status &= ~VMX_GUEST_INTR_STATUS_SUBFIELD_BITMASK; @@ -397,14 +341,11 @@ void vmx_intr_assist(void) __vmwrite(GUEST_INTR_STATUS, status); vmx_sync_exit_bitmap(v); - - pt_intr_post(v, intack); } else { HVMTRACE_2D(INJ_VIRQ, intack.vector, /*fake=*/ 0); vmx_inject_extint(intack.vector, intack.source); - pt_intr_post(v, intack); } /* Is there another IRQ to queue up behind this one? */ diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index 4c2afe2e915..f951cd95bcf 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -27,6 +27,8 @@ #define mode_is(d, name) \ ((d)->arch.hvm.params[HVM_PARAM_TIMER_MODE] == HVMPTM_##name) +static bool inject_interrupt(struct periodic_time *pt); + void hvm_init_guest_time(struct domain *d) { struct pl_time *pl = d->arch.hvm.pl_time; @@ -76,35 +78,6 @@ void hvm_set_guest_time(struct vcpu *v, u64 guest_time) } } -static int pt_irq_vector(struct periodic_time *pt, enum hvm_intsrc src) -{ - struct vcpu *v = pt->vcpu; - unsigned int gsi, isa_irq; - int vector; - - if ( pt->source == PTSRC_lapic ) - return pt->irq; - - isa_irq = pt->irq; - - if ( src == hvm_intsrc_pic ) - return (v->domain->arch.hvm.vpic[isa_irq >> 3].irq_base - + (isa_irq & 7)); - - ASSERT(src == hvm_intsrc_lapic); - gsi = pt->source == PTSRC_isa ? hvm_isa_irq_to_gsi(isa_irq) : pt->irq; - vector = vioapic_get_vector(v->domain, gsi); - if ( vector < 0 ) - { - dprintk(XENLOG_WARNING, "d%u: invalid GSI (%u) for platform timer\n", - v->domain->domain_id, gsi); - domain_crash(v->domain); - return -1; - } - - return vector; -} - static int pt_irq_masked(struct periodic_time *pt) { struct vcpu *v = pt->vcpu; @@ -247,34 +220,14 @@ void pt_restore_timer(struct vcpu *v) pt_vcpu_lock(v); list_for_each_entry ( pt, head, list ) - { if ( pt->pending_intr_nr == 0 ) - { - pt_process_missed_ticks(pt); set_timer(&pt->timer, pt->scheduled); - } - } pt_thaw_time(v); pt_vcpu_unlock(v); } -static void pt_timer_fn(void *data) -{ - struct periodic_time *pt = data; - - pt_lock(pt); - - pt->pending_intr_nr++; - pt->scheduled += pt->period; - pt->do_not_freeze = 0; - - vcpu_kick(pt->vcpu); - - pt_unlock(pt); -} - static void pt_irq_fired(struct vcpu *v, struct periodic_time *pt) { pt->irq_issued = false; @@ -285,189 +238,144 @@ static void pt_irq_fired(struct vcpu *v, struct periodic_time *pt) list_del(&pt->list); pt->on_list = false; pt->pending_intr_nr = 0; + + return; } - else if ( mode_is(v->domain, one_missed_tick_pending) || - mode_is(v->domain, no_missed_ticks_pending) ) + + if ( mode_is(v->domain, one_missed_tick_pending) || + mode_is(v->domain, no_missed_ticks_pending) ) { - pt->last_plt_gtime = hvm_get_guest_time(v); pt_process_missed_ticks(pt); pt->pending_intr_nr = 0; /* 'collapse' all missed ticks */ + } + else if ( !pt->pending_intr_nr ) + pt_process_missed_ticks(pt); + + if ( !pt->pending_intr_nr ) set_timer(&pt->timer, pt->scheduled); +} + +static void pt_timer_fn(void *data) +{ + struct periodic_time *pt = data; + struct vcpu *v; + time_cb *cb = NULL; + void *cb_priv; + unsigned int irq; + + pt_lock(pt); + + v = pt->vcpu; + irq = pt->irq; + + if ( inject_interrupt(pt) ) + { + pt->scheduled += pt->period; + pt->do_not_freeze = 0; + cb = pt->cb; + cb_priv = pt->priv; } else { - pt->last_plt_gtime += pt->period; - if ( --pt->pending_intr_nr == 0 ) - { - pt_process_missed_ticks(pt); - if ( pt->pending_intr_nr == 0 ) - set_timer(&pt->timer, pt->scheduled); - } + /* Masked. */ + if ( pt->on_list ) + list_del(&pt->list); + pt->on_list = false; + pt->pending_intr_nr++; } - if ( mode_is(v->domain, delay_for_missed_ticks) && - (hvm_get_guest_time(v) < pt->last_plt_gtime) ) - hvm_set_guest_time(v, pt->last_plt_gtime); + pt_unlock(pt); + + if ( cb ) + cb(v, cb_priv); } -int pt_update_irq(struct vcpu *v) +/* + * The same callback is shared between LAPIC and PIC/IO-APIC based timers, as + * we ignore the first parameter that's different between them. + */ +static void eoi_callback(unsigned int unused, void *data) { - struct list_head *head = &v->arch.hvm.tm_list; - struct periodic_time *pt, *temp, *earliest_pt; - uint64_t max_lag; - int irq, pt_vector = -1; - bool level; + struct periodic_time *pt = data; + struct vcpu *v; + time_cb *cb = NULL; + void *cb_priv; - pt_vcpu_lock(v); + pt_lock(pt); - earliest_pt = NULL; - max_lag = -1ULL; - list_for_each_entry_safe ( pt, temp, head, list ) + pt_irq_fired(pt->vcpu, pt); + if ( pt->pending_intr_nr ) { - if ( pt->pending_intr_nr ) + if ( inject_interrupt(pt) ) + { + pt->pending_intr_nr--; + cb = pt->cb; + cb_priv = pt->priv; + v = pt->vcpu; + } + else { - /* RTC code takes care of disabling the timer itself. */ - if ( (pt->irq != RTC_IRQ || !pt->priv) && pt_irq_masked(pt) && - /* Level interrupts should be asserted even if masked. */ - !pt->level ) - { - /* suspend timer emulation */ + /* Masked. */ + if ( pt->on_list ) list_del(&pt->list); - pt->on_list = 0; - } - else - { - if ( (pt->last_plt_gtime + pt->period) < max_lag ) - { - max_lag = pt->last_plt_gtime + pt->period; - earliest_pt = pt; - } - } + pt->on_list = false; } } - if ( earliest_pt == NULL ) - { - pt_vcpu_unlock(v); - return -1; - } + pt_unlock(pt); - earliest_pt->irq_issued = 1; - irq = earliest_pt->irq; - level = earliest_pt->level; + if ( cb ) + cb(v, cb_priv); +} - pt_vcpu_unlock(v); +static bool inject_interrupt(struct periodic_time *pt) +{ + struct vcpu *v = pt->vcpu; + struct domain *d = v->domain; + unsigned int irq = pt->irq; - switch ( earliest_pt->source ) + if ( pt_irq_masked(pt) ) + return false; + + switch ( pt->source ) { case PTSRC_lapic: - /* - * If periodic timer interrupt is handled by lapic, its vector in - * IRR is returned and used to set eoi_exit_bitmap for virtual - * interrupt delivery case. Otherwise return -1 to do nothing. - */ - vlapic_set_irq(vcpu_vlapic(v), irq, 0); - pt_vector = irq; + vlapic_set_irq_callback(vcpu_vlapic(v), pt->irq, 0, eoi_callback, pt); break; case PTSRC_isa: - hvm_isa_irq_deassert(v->domain, irq); + hvm_isa_irq_deassert(d, irq); if ( platform_legacy_irq(irq) && vlapic_accept_pic_intr(v) && - v->domain->arch.hvm.vpic[irq >> 3].int_output ) - hvm_isa_irq_assert(v->domain, irq, NULL); + d->arch.hvm.vpic[irq >> 3].int_output ) + hvm_isa_irq_assert(d, irq, NULL); else - { - pt_vector = hvm_isa_irq_assert(v->domain, irq, vioapic_get_vector); - /* - * hvm_isa_irq_assert may not set the corresponding bit in vIRR - * when mask field of IOAPIC RTE is set. Check it again. - */ - if ( pt_vector < 0 || !vlapic_test_irq(vcpu_vlapic(v), pt_vector) ) - pt_vector = -1; - } + hvm_isa_irq_assert(d, irq, vioapic_get_vector); break; case PTSRC_ioapic: - pt_vector = hvm_ioapic_assert(v->domain, irq, level); - if ( pt_vector < 0 || !vlapic_test_irq(vcpu_vlapic(v), pt_vector) ) - { - pt_vector = -1; - if ( level ) - { - /* - * Level interrupts are always asserted because the pin assert - * count is incremented regardless of whether the pin is masked - * or the vector latched in IRR, so also execute the callback - * associated with the timer. - */ - time_cb *cb = NULL; - void *cb_priv = NULL; - - pt_vcpu_lock(v); - /* Make sure the timer is still on the list. */ - list_for_each_entry ( pt, &v->arch.hvm.tm_list, list ) - if ( pt == earliest_pt ) - { - pt_irq_fired(v, pt); - cb = pt->cb; - cb_priv = pt->priv; - break; - } - pt_vcpu_unlock(v); - - if ( cb != NULL ) - cb(v, cb_priv); - } - } + hvm_ioapic_assert(d, irq, pt->level); break; } - return pt_vector; -} - -static struct periodic_time *is_pt_irq( - struct vcpu *v, struct hvm_intack intack) -{ - struct list_head *head = &v->arch.hvm.tm_list; - struct periodic_time *pt; - - list_for_each_entry ( pt, head, list ) + switch ( d->arch.hvm.params[HVM_PARAM_TIMER_MODE] ) { - if ( pt->pending_intr_nr && pt->irq_issued && - (intack.vector == pt_irq_vector(pt, intack.source)) ) - return pt; - } - - return NULL; -} - -void pt_intr_post(struct vcpu *v, struct hvm_intack intack) -{ - struct periodic_time *pt; - time_cb *cb; - void *cb_priv; - - if ( intack.source == hvm_intsrc_vector ) - return; + case HVMPTM_one_missed_tick_pending: + case HVMPTM_no_missed_ticks_pending: + pt->last_plt_gtime = hvm_get_guest_time(v); + break; - pt_vcpu_lock(v); + case HVMPTM_delay_for_missed_ticks: + pt->last_plt_gtime += pt->period; + if ( hvm_get_guest_time(v) < pt->last_plt_gtime ) + hvm_set_guest_time(v, pt->last_plt_gtime); + break; - pt = is_pt_irq(v, intack); - if ( pt == NULL ) - { - pt_vcpu_unlock(v); - return; + default: + pt->last_plt_gtime += pt->period; + break; } - pt_irq_fired(v, pt); - - cb = pt->cb; - cb_priv = pt->priv; - - pt_vcpu_unlock(v); - - if ( cb != NULL ) - cb(v, cb_priv); + return true; } void pt_migrate(struct vcpu *v) @@ -543,6 +451,24 @@ void create_periodic_time( pt->cb = cb; pt->priv = data; + switch ( pt->source ) + { + int rc; + + case PTSRC_isa: + irq = hvm_isa_irq_to_gsi(irq); + /* fallthrough */ + case PTSRC_ioapic: + pt->eoi_cb.callback = eoi_callback; + pt->eoi_cb.data = pt; + rc = hvm_gsi_register_callback(v->domain, irq, &pt->eoi_cb); + if ( rc ) + gdprintk(XENLOG_WARNING, + "unable to register callback for timer GSI %u source %u: %d\n", + irq, pt->source, rc); + break; + } + pt->on_list = 1; list_add(&pt->list, &v->arch.hvm.tm_list); @@ -554,6 +480,8 @@ void create_periodic_time( void destroy_periodic_time(struct periodic_time *pt) { + unsigned int gsi; + /* Was this structure previously initialised by create_periodic_time()? */ if ( pt->vcpu == NULL ) return; @@ -563,6 +491,17 @@ void destroy_periodic_time(struct periodic_time *pt) list_del(&pt->list); pt->on_list = 0; pt->pending_intr_nr = 0; + + gsi = pt->irq; + switch ( pt->source ) + { + case PTSRC_isa: + gsi = hvm_isa_irq_to_gsi(pt->irq); + /* fallthrough */ + case PTSRC_ioapic: + hvm_gsi_unregister_callback(pt->vcpu->domain, gsi, &pt->eoi_cb); + break; + } pt_unlock(pt); /* @@ -617,20 +556,29 @@ void pt_adjust_global_vcpu_target(struct vcpu *v) write_unlock(&pl_time->vhpet.lock); } - static void pt_resume(struct periodic_time *pt) { + struct vcpu *v; + time_cb *cb = NULL; + void *cb_priv; + if ( pt->vcpu == NULL ) return; pt_lock(pt); - if ( pt->pending_intr_nr && !pt->on_list ) + if ( pt->pending_intr_nr && !pt->on_list && inject_interrupt(pt) ) { + pt->pending_intr_nr--; + cb = pt->cb; + cb_priv = pt->priv; + v = pt->vcpu; pt->on_list = 1; list_add(&pt->list, &pt->vcpu->arch.hvm.tm_list); - vcpu_kick(pt->vcpu); } pt_unlock(pt); + + if ( cb ) + cb(v, cb_priv); } void pt_may_unmask_irq(struct domain *d, struct periodic_time *vlapic_pt) diff --git a/xen/include/asm-x86/hvm/vpt.h b/xen/include/asm-x86/hvm/vpt.h index 39d26cbda49..9440fe4ac7d 100644 --- a/xen/include/asm-x86/hvm/vpt.h +++ b/xen/include/asm-x86/hvm/vpt.h @@ -23,6 +23,7 @@ #include #include #include +#include /* * Abstract layer of periodic time, one short time. @@ -50,6 +51,7 @@ struct periodic_time { struct timer timer; /* ac_timer */ time_cb *cb; void *priv; /* point back to platform time source */ + struct hvm_gsi_eoi_callback eoi_cb; /* EOI callback registration data */ }; @@ -145,9 +147,6 @@ struct pl_time { /* platform time */ void pt_save_timer(struct vcpu *v); void pt_restore_timer(struct vcpu *v); -int pt_update_irq(struct vcpu *v); -struct hvm_intack; -void pt_intr_post(struct vcpu *v, struct hvm_intack intack); void pt_migrate(struct vcpu *v); void pt_adjust_global_vcpu_target(struct vcpu *v); -- 2.30.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 31 11:01:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 11:01:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103881.198151 (Exim 4.92) (envelope-from ) id 1lRYbU-0008PS-2K; Wed, 31 Mar 2021 11:01:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103881.198151; Wed, 31 Mar 2021 11:01:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYbT-0008PL-UO; Wed, 31 Mar 2021 11:01:39 +0000 Received: by outflank-mailman (input) for mailman id 103881; Wed, 31 Mar 2021 11:01:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYbS-0008PG-Lq for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 11:01:38 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0faf9e6b-a84b-41d3-a062-93f5261adafe; Wed, 31 Mar 2021 11:01:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0faf9e6b-a84b-41d3-a062-93f5261adafe DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617188497; h=from:to:cc:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=Dtb4SWVY/ALu2efMJsjgL3lkR/P7PyQK5Gppvr6xvqk=; b=Lk4DUCvzUeW9BdO9UIJuKwpuAOo8ANVGHo5RfeUaDn9QRixPOFBo5flL zLMmVbWF0M3BbpjTk7U+Z06FSVgw8dvY+ZHpTFYxRSDEWEVfa9TF75Fzj dgBS9xw4MPKox3glTW62Qb8s+SbefDMJDKIDeMVE5c+Jnk0q/AF2acYUn c=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: fnu1kk8YrtbCA1MlrcghGbH+dJK6HxNyok4A9gsmn3vEt/Od545pQV4TX8WC0qJ66/mqpvuQa1 2hlAHR+UFwFJSwjJjEvGarhCtcFOm7ySKj3QPyVch8tTT8nqpTNO5ZF5BQJJARJgr8mXdWFygn /zPmxKgHGt+tGG9hAYZrkDMj479HoWWXCGnBfMHfnXJmkOF5z7YUgsHogYkFIoL01kfU6Dsr8n rbiUOLA6yGcRbkiKtaGsaLgsMJlDPP6qkj42Vckau+mQTksheZ2JFfwxHiCsEotQR54AnjRkS1 1sI= X-SBRS: 5.2 X-MesageID: 41996257 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:ilwXOqGVbMYrr2MwpLqEfseALOonbusQ8zAX/mp6ICYlFfCwvc aogfgdyFvIkz4XQn4tgpStP6OHTHPa+/dOjbU5F7GkQQXgpS+UPJhvhLGM/xTMOQ3bstRc26 BpbrRkBLTLZmRSoM7m7GCDfeoI78KA9MmT5Nv263t2VwllZ+VBwm5Ce2WmO2l3QAUDOpYjDp qb4aN8xwaIQngcYsSlCnRtZYGqzbD2vaj7ah0LDQNP0njtsRqU7tfBYnyl9yZbfzRTwaoztU jp+jaJgJmLgrWA5Fvx90K71eUypOfc X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="41996257" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c9ON4SsJZ9aQ1lqRGIHKqfbr6YngS6N8h32nP7Cx0MH0t8g4xIL1/00Fy5XRTJfXxVo6bC8tzApEfWb5Vdmm7BjEOFs06hZvwU5sO8WCeE4HrP1lFTsLwuinenEO5kYXN/IE9UeFeslcvt2dBYHdTIJYY7Yv4KRvA0FrcrVosC8PTvRSd4zbaEBu+TCImZQzZi/7AE/IW2Pg8PiUe/DYtCX16wwFJN4mDCTmHvzWQc0RQh5fDfv4C+e7f+FqS+C0R8U8oA/KmZDS7c6pOAjMAoL1GEppvKoAx7+1MRPGE5ZkJU2ai+9eSj3UzNKp1j00LZYW6Sr45J407OUNgZ686g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dtb4SWVY/ALu2efMJsjgL3lkR/P7PyQK5Gppvr6xvqk=; b=QHIYOrpX3lqVBqyD83WXvMmoUDhenrvvfjkwLm+UGJsvF+jTNLV3IDcI/XDWmL67llWx+owNIeT746xNH+VHckh1IIYpCTiTKroppXp3DZeUFbUXz5wDB8fG1wcLUbkhl0/QXCu4Qjh8Xo+8m6EpAOdjOcWCqiJQO/X/hwdSiXxlvNo/i4y4MwPyzJCRg6JEaKhuixm3qI9Lo2S3KySSbw8Ub2QJxc7qgPwyPMDEdskv366dMnIwAQskMJafFs9T4ONZXm9xZhOQt8rE0uWR/fevnQAdfT7g1QkrxXOm1q2i6SKJNhv0KHbafvUCDkG3MlTeq4e+JyIlVznS77abvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dtb4SWVY/ALu2efMJsjgL3lkR/P7PyQK5Gppvr6xvqk=; b=Lz4SxG9dONJV4plzcz9WSpJI7ojrT/+LppZ+aLkDApe7/LhxpsGHhMBcqTQKlqAGBD3D1peBKIj2E6Yyq5r05IqCktInnehJTi9Dm4FWQLHI9hiprwlEL0zPYvEuarr1Bag4ABsMcTIaHaSMt8P0YARB9SBSp4cHCS2mxVuPqK0= From: George Dunlap To: xen-devel CC: Tamas K Lengyel , "intel-xen@intel.com" , "daniel.kiper@oracle.com" , Roger Pau Monne , Sergey Dyasli , Christopher Clark , Rich Persaud , "Kevin Pearson" , Juergen Gross , =?utf-8?B?UGF1bCBEdXJyYW50wqA=?= , "Ji, John" , "edgar.iglesias@xilinx.com" , "robin.randhawa@arm.com" , Artem Mygaiev , "Matt Spencer" , Stewart Hildebrand , Volodymyr Babchuk , "mirela.simonovic@aggios.com" , Jarvis Roach , Jeff Kubascik , Stefano Stabellini , Julien Grall , Ian Jackson , Rian Quinn , "Daniel P. Smith" , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLRG91ZyBHb2xkc3RlaW4=?= , George Dunlap , "David Woodhouse" , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQW1pdCBTaGFo?= , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLVmFyYWQgR2F1dGFt?= , Brian Woods , Robert Townley , Bobby Eshleman , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQ29yZXkgTWlueWFyZA==?= , Olivier Lambert , "Andrew Cooper" , Wei Liu , Ash Wilding , Rahul Singh , =?utf-8?B?UGlvdHIgS3LDs2w=?= , Brendan Kerrigan , "Thierry Laurion (Insurgo)" , Oleksandr Andrushchenko , "Oleksandr Tyshchenko" , Deepthi Subject: [ANNOUNCE] Call for agenda items for 8 April Community Call @ 1500 UTC Thread-Topic: [ANNOUNCE] Call for agenda items for 8 April Community Call @ 1500 UTC Thread-Index: AQHXJh01Lcq41mTG202PuZUd4eityw== Date: Wed, 31 Mar 2021 11:01:32 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0f86529b-5ad7-4cd3-093f-08d8f4345857 x-ms-traffictypediagnostic: PH0PR03MB5927: x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +qv7LuI9Vp4TIBXzXYVBKFpiDLt86Q4jcPzBVz2u84ffh+2vSwzvJTX6bY5iO18QYPOn3DvWnqRTCgKm2PJeoWksdLO7kFaYooFeV9PMo0hotESO5UI3TtfzxjYjG/K8z1MyzWRswjs6Ozf8ytlgiq6Nv1KHZCa0Y/4yJdi3Hb8IVDWpOYPWMBr3P0L5OdR7Tpl6Y6ykBycT4ksnivR4q6Z/7hMTjQhs+veQyL0lIQ0d62UadIk0eRe4eUhYQ7VV4JbDdxbBQJqoaw9Bgv5+7KAPD23iXAytRrsGlCGbccx02/r64ilyyoaNGuOJ/Qr8O6hcy2GmX53PbX9wGTACSG+L9KcYdsExRylVS3C6xehTQcINvKDAOqmz9ZY2MpPOOqI0Om0DXSeSoc4c394u/C7Yr8lW0Nt5k/UgfH+GNtmLAU+Wd1d+pTGXw/lcaG0mqDSk4zY6iDypnerTlaqX2SEQDFiOqH+FFIglpV0fpoBQU28N3s42k18kvQF2xX+tsLppP/vXFpZlt6vuBFdVY48k+ng9GlsR2PlSaD/9ayPpDg/62/G0wcT5zyAb5Kyqcur6H9ptxvjwwWmOwZXrWkcO7C4TvMWeKa88tl2sNl4QT6kZeMGinTETv3rtiaeJ6/syRGe818G/tq5MVk7Hh7VTsBEOxHiB/VznHfGpU35d6VWRCiYozskdpY8gdpUZpu819piUyCOorrKIvY6eIh2AKwVjc9OVKyimc1RQhWx0SoiyUJfBOBlRfj97EeOK6tWvK2s6TS+i+UQxYoiP2PmC+VRRepqvBVajWJ6kzhk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(376002)(366004)(136003)(39860400002)(8936002)(26005)(83380400001)(478600001)(66556008)(8676002)(64756008)(36756003)(6486002)(966005)(66946007)(6512007)(38100700001)(4326008)(2616005)(186003)(66476007)(6506007)(86362001)(6916009)(7416002)(33656002)(54906003)(316002)(71200400001)(76116006)(2906002)(7406005)(91956017)(66446008)(5660300002)(221023002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?KzE1aTVkWEdkNnVkQzdxdTFNWHVqNzVGMjNRRTg2aHk2eUlRd3h2WWVhL0k0?= =?utf-8?B?N1hEYUlkMk5xRVF6YllNZ3BRakhFdTRmcGtFQlZ4cjZ0NWV4aDVHMGMrbloz?= =?utf-8?B?UjgwSmhjMmZyMlJjVEZ3RU9pTFhHd2EzMXg3L1N2OGcxUVNCMlZydG9uVUl3?= =?utf-8?B?V1JOQXB5T0o1dlpEdGFYa1pPUjUvdHdBSWovQVNmN0tKNjNwS2dISXhzb0h2?= =?utf-8?B?VXN3ejc4ODlPYXVhZ2NnYkFVWHh0Z1QzcFY0MnVEWHgvZFlhM0V0TEplMXRK?= =?utf-8?B?WVI4WmI5b2hTM3J3UE82SkE0cTUva3RqR0krb3E2VGxRcm1Jd2dOOGlTbThl?= =?utf-8?B?TXZpMGpURzN5aEZoY3BPTkFkTHZyVzliLzh5dmpoZFNEUXlTOFcwcVdaQVVh?= =?utf-8?B?RnVBOW5PY2NFRmNKbnNkN2NPa3A2bnVYVlZHekJGNmdOaC9hN0xRa2wyV0J6?= =?utf-8?B?b2pJUmhnSU5zNjQ5c2JXM0NkcU1jYWVZUFRYaE80cjhRRk00U2JwVGpMaFY5?= =?utf-8?B?RFhZVW5tN08rTzJTMTl4SHpCc3Q1ZkRqWUZwcGd5aUQ4clp1MHVxTlVRUkRt?= =?utf-8?B?UzVTR3cvSGRRR0xjaGl6bnJWYXZSYWVLWEwvbGp4Q2NGVkVCbWY4cjVXYjdu?= =?utf-8?B?QVhCZWJuL0dsWmV4c1pVV0xYemlScGxoZDJpOHplbFk5M0FJUExWZUgvNE5X?= =?utf-8?B?SzdhYkIvaW5aZVdYSDUvbDcrT2VreEIvbFNNUElkNmYrSWI0RUxodnM3aElZ?= =?utf-8?B?Q2p4MDNMRk4vd0FJQU9TaC9vVGgydXZLNDNHSC9FUHJhYnB2VWVEa1NLZjMv?= =?utf-8?B?bHZsRHZOVHBEay9YUXpIQnZWeGhaanJkTkduU3dNelRTbGFuaWVNck9ndmxY?= =?utf-8?B?dTFWRW5QWWp3M1Y3S213UEJjZzZrTXA0UzFNL2lOY1pDYTQvM0ZLRWZ1c08r?= =?utf-8?B?Z2JHRHVJOEJKVit3OHJKMFZKTW5GRUJQYzBVVFZkR09ad2VyUlpBUDlQUW5S?= =?utf-8?B?RkY4MW1GMTlqcmR5aHpuSTRTamNyN1R6dzBFcml4NS8xMk5CU2NIcU9DTWdr?= =?utf-8?B?RWFxSzJLbStvbXIwdURzRnhnMytXcHpDTmpVekRVTDI1ZWRoNzdFd1lkditq?= =?utf-8?B?TjcxOU4yK2hDS0plcHA0UnQvZVNKZW5Qc1VBSWkwVTJoRVZlNks2Y1JDRXg3?= =?utf-8?B?bTNMZEVNcy9jVFlYNUpEdlhXNUpid3psbjVUYVQrdUh5RnNvT05HSnRNUUEv?= =?utf-8?B?ZGlLR1VKckJFRmIyT2JCdjJDbkxubXdINWlJd3gzZVhPbU41aktOZVNnWnNq?= =?utf-8?B?ZXhNV2JKM2YrVkkxb2tBTEE0NUF4Z29OK2QxcjBIdy9EN3UyL2RkcWhKdWRt?= =?utf-8?B?ZmZoRUpid2svbFpLb0NERGxFZzUwZ0lTNGQzYzFkNEJSd2FOUGwveFVDQTZR?= =?utf-8?B?TmY3NzhHTTJIU29lbUFuTjhsQXJHVVQ5a1NkVzdaQ2hRQysvK0l1N0ZvbHJ3?= =?utf-8?B?bDlZOEY3Qkw0TktZUzF3UHdLcWhjS0ZqbFRNTUVIbWQ4WC91QXpXb2JqWDUw?= =?utf-8?B?UG9SWCtNdWl1WjJpdUtTOTBkRTh6cFhYMzZtY1hqT3J2LytlT0VMUHNobnBE?= =?utf-8?B?NXFtZGV2S0pZVDdlcGtPZkFqZHlIY1lZb3dEUmw2NjdwNHZLWG56VG5nUDZ2?= =?utf-8?B?d2RmeGJ4NENGVGtRVE91aXE2OVN1MjM2ZVhHOFFTL3g4a1plWGR1TG1zdW9h?= =?utf-8?B?ekZEQmZvU2FZdG5rQ0h6VnN2WVhGNm9ZSXJEbWVNOTltNXQrbnkzMFd1b0t5?= =?utf-8?B?MG05ZVpDTG85QmV4dUN0dz09?= Content-Type: text/plain; charset="utf-8" Content-ID: <44E976E338C80841856ED2414D692AA9@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f86529b-5ad7-4cd3-093f-08d8f4345857 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2021 11:01:32.7683 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G+C9BgCGa0raDSsXwmin/3yObBQVxkeePj1JF4qt/ddz6hxM2YiaYQOBsWBdlYKZVdz0W3N247GUc8gd8rRLY1wWQZ2DIIMsPRVBFjX8GIU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5927 X-OriginatorOrg: citrix.com SGkgYWxsLA0KDQpQTEVBU0UgTk9URSBUSEUgTU9ESUZJRUQgREFURS4NCg0KVGhlIHByb3Bvc2Vk IGFnZW5kYSBpcyBpbiBodHRwczovL2NyeXB0cGFkLmZyL3BhZC8jLzIvcGFkL2VkaXQvSzFmYjRH clVGM2xIOXpRcklrbDgrSFRoLyBhbmQgeW91IGNhbiBlZGl0IHRvIGFkZCBpdGVtcy4gIEFsdGVy bmF0aXZlbHksIHlvdSBjYW4gcmVwbHkgdG8gdGhpcyBtYWlsIGRpcmVjdGx5Lg0KDQpBZ2VuZGEg aXRlbXMgYXBwcmVjaWF0ZWQgYSBmZXcgZGF5cyBiZWZvcmUgdGhlIGNhbGw6IHBsZWFzZSBwdXQg eW91ciBuYW1lIGJlc2lkZXMgaXRlbXMgaWYgeW91IGVkaXQgdGhlIGRvY3VtZW50Lg0KDQpOb3Rl IHRoZSBmb2xsb3dpbmcgYWRtaW5pc3RyYXRpdmUgY29udmVudGlvbnMgZm9yIHRoZSBjYWxsOg0K KiBVbmxlc3MsIGFncmVlZCBpbiB0aGUgcGVydmlvdXMgbWVldGluZyBvdGhlcndpc2UsIHRoZSBj YWxsIGlzIG9uIHRoZSAxc3QgVGh1cnNkYXkgb2YgZWFjaCBtb250aCBhdCAxNjAwIEJyaXRpc2gg VGltZSAoZWl0aGVyIEdNVCBvciBCU1QpDQoqIEkgdXN1YWxseSBzZW5kIG91dCBhIG1lZXRpbmcg cmVtaW5kZXIgYSBmZXcgZGF5cyBiZWZvcmUgd2l0aCBhIHByb3Zpc2lvbmFsIGFnZW5kYQ0KDQoq IFRvIGFsbG93IHRpbWUgdG8gc3dpdGNoIGJldHdlZW4gbWVldGluZ3MsIHdlJ2xsIHBsYW4gb24g c3RhcnRpbmcgdGhlIGFnZW5kYSBhdCAxNjowNSBzaGFycC4gIEFpbSB0byBqb2luIGJ5IDE2OjAz IGlmIHBvc3NpYmxlIHRvIGFsbG9jYXRlIHRpbWUgdG8gc29ydCBvdXQgdGVjaG5pY2FsIGRpZmZp Y3VsdGllcyAmYw0KDQoqIElmIHlvdSB3YW50IHRvIGJlIENDJ2VkIHBsZWFzZSBhZGQgb3IgcmVt b3ZlIHlvdXJzZWxmIGZyb20gdGhlIHNpZ24tdXAtc2hlZXQgYXQgaHR0cHM6Ly9jcnlwdHBhZC5m ci9wYWQvIy8yL3BhZC9lZGl0L0Q5dkd6aWhQeHhBT2U2UkZQejBzUkNmKy8NCg0KQmVzdCBSZWdh cmRzDQpHZW9yZ2UNCg0KDQoNCj09IERpYWwtaW4gSW5mb3JtYXRpb24gPT0NCiMjIE1lZXRpbmcg dGltZQ0KDQoxNTowMCAtIDE2OjAwIFVUQw0KRnVydGhlciBJbnRlcm5hdGlvbmFsIG1lZXRpbmcg dGltZXM6IGh0dHBzOi8vd3d3LnRpbWVhbmRkYXRlLmNvbS93b3JsZGNsb2NrL21lZXRpbmdkZXRh aWxzLmh0bWw/eWVhcj0yMDIxJm1vbnRoPTA0JmRheT04JmhvdXI9MTUmbWluPTAmc2VjPTAmcDE9 MTIzNCZwMj0zNyZwMz0yMjQmcDQ9MTc5DQoNCg0KIyMgRGlhbCBpbiBkZXRhaWxzDQpXZWI6IGh0 dHBzOi8vbWVldC5qaXQuc2kvWGVuUHJvamVjdENvbW11bml0eUNhbGwNCg0KRGlhbC1pbiBpbmZv IGFuZCBwaW4gY2FuIGJlIGZvdW5kIGhlcmU6DQoNCmh0dHBzOi8vbWVldC5qaXQuc2kvc3RhdGlj L2RpYWxJbkluZm8uaHRtbD9yb29tPVhlblByb2plY3RDb21tdW5pdHlDYWxs From xen-devel-bounces@lists.xenproject.org Wed Mar 31 11:07:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 11:07:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103888.198163 (Exim 4.92) (envelope-from ) id 1lRYgj-0000BY-Pq; Wed, 31 Mar 2021 11:07:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103888.198163; Wed, 31 Mar 2021 11:07:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYgj-0000BR-Mi; Wed, 31 Mar 2021 11:07:05 +0000 Received: by outflank-mailman (input) for mailman id 103888; Wed, 31 Mar 2021 11:07:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYgi-0000BL-93 for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 11:07:04 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e6c11c1f-3f4e-494b-9544-89c743f64102; Wed, 31 Mar 2021 11:07:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6c11c1f-3f4e-494b-9544-89c743f64102 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617188822; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=G6OujAQ3f59/sXEsxC36Xa1ZpCpbAWMHsNApDfmmbVY=; b=Zkn5SwAxCplkS9D1C1XhTNHk6m4fxb+L/U8hE/h02vLtDg0v+YrEEnk3 DfuRvNWQ7f0nxSNuNp+kq5bdlTxkbHQ54syrsY/ziwhbhFKwATV5MXv/v 7vtGTRTjiaHEgRvF8aruquRf1gAbv9x4HjcAUOxr6JBwJL/NJWxmDzhCm g=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: EW0XM+Etjzm/mNcjJXvWx4Eo6A7QFTcimtW2+HCUyqDq3VTHRaU5QndplJZZT6Zxe/ULhIhSog wUaMKQWu14MIT++EHoq4NuVu+KaEnix1fxBUT58Umqp1gt4Lc6iiwc6A0+s0EkRh/BW5OogxUN EMpiJtnvEhNRBN0vlJhoiN/ZteQ92Ra4qERmDnUZt5Is8dz6155yihFNon363OFbKdEw8nx9a3 waM76+S+B5t5Dwn6lbCxYuUtFhtCTO2HVDHUtNPer2MDyqdYeDdXAAjKWpPySXABGq0Z81OLjg b1w= X-SBRS: 5.2 X-MesageID: 40547868 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:q/+do6xUjh+RvAm/8OqfKrPx/uskLtp033Aq2lEZdDV8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPsfVr3//dOgbU5F7GkQQXgpS+UPJhvhLGSpwHINg/f0qpm1a lme7VjE9GYNzJHpOvz/QXQKbkd6fad9qTAv4nj5lNMaS0vVK169Qd+DW+gYyhLbS1LH4AwGp bZxucvnUvCRV0tYs62BmYIUoH4zrWmqLvcbQMbHBli0QGSjFqTg4LSKQSS3RsVTlp0sNUf2F XC+jaZ2oyT98uV5zWZ/G/V4pRQlrLau6Z+Lf3JsOc5AHHBjg6pYa5oRrGNuiskydvflGoCoZ 33jDoLe+h19nPNbkG5yCGdpDXI4XIVxFLJjX+enHf5rsTySFsBerR8rLMcSDT1wQ4EnrhHoc V29lPcjbV7J1f8uR64wN7yWxRjhiOP0AEfuN9WtVNze88jcrNLxLZvmn99IdM7Mw/RzpsoK+ VqBNG03octTXqqK0rUuWRi27WXLw0ONybDRkADv/qc2CRNkEZ4yFMFxNcekm1ozuNEd6V5 X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40547868" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FNI9MUX1ji9fRtDGOfDkb5ngKZYHJ2BerSMzhRstnBFnSrIIUHTXt/9KUMTjMIvIKvpIPHd33MkOScUFYU/ku1AKnzEL3r5fl0YvXnQbfMy9cd3FG/xtpUOJbhUlw9pFwnHvCKYDBsqG/Z2Ptmu4pSa52Gm93BZk+HBb9geay+WB9TkhYGhIzgeTdcJVQNUoscWv67mms38l729NPCbDJl++oJZ2BYkJlpvzkCqJTryC9tI3rqQ+EIc816TKi5lW6G4Dzcg2G70g+WAXJw/DJzu8J9Hd8C3lKnebmnBGtqH6t1pl6jS7zX8satygE0WmCHCyqc5uAs5s6B3SmaDl1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h0ua5x8NrFRnTlHpHqLFMm0gHOAb8Ol8y96wdBm6mDk=; b=V+LuPLzjGckNXQX0BLQfKJOMVhSlK0GPC6dJLVzaxXTStcPlkaPe0hoEo7x/2ILuJ8HBNAQzv976g4Xt6UYk5uRjYIBv7krF5/JBeo5vWf1GtQFMzehP85Y/LF23zvGMO27aiY7hm6LryJL0RxmcG0DoKHuWfsyf9fIMn3wy8Qn4DwuNi9sGkQIBKNqGLIcVy//2VbIOMrrvMb7lY/lXLiKNjE1ThNhEu2VPo3F9HwS8depan8NzQxDuwzfJDzPeW70L39noHJdK5ll4uq5s2Ih6qi8Nhf8+WsU9txo7/XMPA6SWyklsxT1hj1n88sx21tI5tlWP843F4sGQmyflNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h0ua5x8NrFRnTlHpHqLFMm0gHOAb8Ol8y96wdBm6mDk=; b=efkI4j2OXcbROi0koYYhkcsEHYV7wYClNS/jaA7U0E/SDKpeZFFYpYop5Tj2VZDmj4adbiQX0bxgcLzkTpqcDg3ePEDvlE0MnBhHI3MYMPQOebRkcYR6mlyCJyYb6t4vesmRXqdXCTuibume9zigEslEQIO6QjFNRj9+0c2aiMg= Date: Wed, 31 Mar 2021 13:06:53 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , Ian Jackson , Wei Liu , Subject: Re: [PATCH 05/21] libs/guest: introduce helper to fetch a domain cpu policy Message-ID: References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-6-roger.pau@citrix.com> <87d48996-6b8b-d801-c43b-30b919244fcb@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87d48996-6b8b-d801-c43b-30b919244fcb@suse.com> X-ClientProxiedBy: PR0P264CA0070.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1d::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 37917828-680f-4bff-5910-08d8f4351a80 X-MS-TrafficTypeDiagnostic: DM5PR03MB3065: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oUUarReP1EF6xzZ6/jAommj+WpcBh7r66srVOr79ByNWfdeteZxU+I3ev5hdpaea3B6B+royUFYPr1xqMNDYjTsvRGtom5OkBC3thhmny6xfiSdGQZAFnyHuCzzcgst2s6pB192CP8PUWeblJuJCDELpUuxUPr+N1HDHH9qjVO26tVlOXG8Cu4NaqGvB8E/SbgtBqVo1jsUj+P5XEbpN5+aLU1XSO9ocI8nK93pgPk4LY8Ue4cLwEIrBbeILQxaCu5z7ip4SwquWs+C9eJZLATbZAGk8wWMhd/DVAFbxOMfJ27pjpC5+PKQFCKfkMmYdfPej932m04Ba8o6FDLBdz6qypQScx+rtO//P3r2Wb4UzgFCi065J/2eqLlx7h2yyCnPT8DUUrhjXr4hGCMEl43gd+psaFSvQjTsrhmr8zW+qyZGUIS8E9Lx7Smn91040I1yQqeX5QODn95+79TZjVenoqvfzbWDK8LOsCKC2DyJECJYry7iFW1ZUrGAZqWA4e+3OqUyrV/N+pUSqnmIxqV3f048xmK1/BFdnrkDog1AnqA77al5lPH9iaDA13vL/r+Oef/YZPrUTPrtK66mcdU8qZf43MY00fU0JCQT5HTQ5QpDzfOijU47IhCWB2dyzS+wDgU7TTASOzv/f3shSDL5T78jMyBPr7W51A9TI0kQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(136003)(396003)(376002)(366004)(346002)(39860400002)(38100700001)(6666004)(8936002)(186003)(316002)(478600001)(66946007)(33716001)(956004)(6916009)(66556008)(2906002)(85182001)(86362001)(8676002)(53546011)(16526019)(26005)(66476007)(4326008)(54906003)(6486002)(6496006)(9686003)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NDBLeVR5OW12eENxK0hQNm51dEJnUm1SVHVQUk00NjFMeSt1R1VIc3dnMTFn?= =?utf-8?B?UHQvNkI4M2kxeTNtRWhwRzlqc1g1OUZRekpLZnJYWEk1d0lWZHA3dVN1b25B?= =?utf-8?B?MUthNHFXanlkTGdkNWtVWHNxWkR2QjNHdms5SG5KRXNHaTZmNVlndXc5MjlW?= =?utf-8?B?RzBUL3BtaFF6Q05ZYnpLUURMNXMyUDZKS2lQQ0h2WnMydHJ0MFlCcnVWS1NN?= =?utf-8?B?STdEazh5Y3ZxcXJPTEo3S2VYREVSbTZCdlpWT2xNb0ZpelJaRkJtQmFjQXRF?= =?utf-8?B?WVRvak9yaldoSk01UEEvMjBIVXltT0wxT3B1aU10YXFKS1BucjdHYmdJbStt?= =?utf-8?B?NlhTWCthbmJrZGRGOHQ0SUJBaDZ1NGJzUDZQV0ZlY2NkTEd0VUVJejhBQlFk?= =?utf-8?B?WnFLUDJYVWt2SUtrc0FkZFgyYWVVQ0JTc2JaRVZkbXZqM2tWQlhjMDFZNEoy?= =?utf-8?B?UEFyRnFCUy9xU1BDNURSOG43c0pyREo4SmJFZHlGNEtjM0syVlFJVmdzRmh0?= =?utf-8?B?L29MekNNNlZjV2Ira0g2L3MvMU52R1lCbjZzdXlGLzM4dTAxSjBhLzN5ZUNL?= =?utf-8?B?VStSekNJNXYvdm1TazZKUUdQcWwvZTVjTXQ4K25QRlNoemtsaVNZNlJZdkpJ?= =?utf-8?B?bWFJN3JNMjZmaVhvSjlOaEdJcEt1Ym8rdXdVVFpRQXVwUnhENVpvVE14ZkVY?= =?utf-8?B?TVJFOWFCZGwwMlZRV0FiSmNHM29DL1h6REhrQy82b29XR09hd2psdXRIMkg2?= =?utf-8?B?cmQ5czN5enBxMXZuTlJpcGxHYkh6TlhPQzJ4LzZpM1loaXlvbjlVc0htTTFG?= =?utf-8?B?aDBiNFU0NXViNDltZUYxV01xQ2Nmd1B6V0xYaDkwTjlEcnM0YVlzVkJKTEgx?= =?utf-8?B?S1YvYnNGQTBpL3J5RlZqZXVtaVpHL0VDM1hld0tkbkk2QTBpN3BNQWVLRlF1?= =?utf-8?B?NXhnVGhIWjVEZ1I3dFF6azhqekxuMWdIbVpEMlR0bmRTWkZRRGdKQkNSdG9F?= =?utf-8?B?bURRaVRRbjZjdG1RQlJ0UEt5NnU4TGdpaUxaM0lCOHhubWRhZHRPYldqd2U2?= =?utf-8?B?SC8rdVYrWVgzTDdmdDFnMzhiL1M2RTBFRTROUDRuZGIvMUdFckk2L2Y3SWIr?= =?utf-8?B?NU0rUE1EZWtwL0tMa2dGWGdWa0dtVDdhRkJwR2ltWUQzRnNlc25tWXpBT3Vj?= =?utf-8?B?bXpRMElVemhDWDVQdkR2SnZsKzFKMmVJd3NSRDB2c3B0K2E3WGpsd0c2S2hj?= =?utf-8?B?aW5la2FLSlA5V0tmMWx0WnNrTDgrWm9ZNUtxTlR5WmY2R1g3OUhxU1ZiY2dM?= =?utf-8?B?RnpmZXF6TGpaVTcrNEF1UzZUVklGVmo1Ujh3REJtSEkrTXZ1NVdGZjQ2ZnFX?= =?utf-8?B?Rm9hSlY2MUg3dmhWeXRRc0xjQXFEbExFSit4RlRjQ1FJNWRITVF3NTIrYXJn?= =?utf-8?B?Sk4xRkxvampjVWNDNnBCVWUxMlQxRnYyTzRtV3YyM01QMG1KWXNhcE9qWDlM?= =?utf-8?B?K1htZmdITDdXSkJrM29VT1NEdVNKU3RqNlFNS1VUSkFjY1BSdW8zbjMrZVpL?= =?utf-8?B?OHhwTlpxSit1akxnTG11MXFPcnlCdVQxZ1hGRkdJMnc1eHF4Z2VKMm9ZaTJY?= =?utf-8?B?NTY3VlpzTnlXaW5wSmxYdklLRXgzN0xpMGNvRVFHRUJ5UEU3UTVTTzF6MW1o?= =?utf-8?B?N3Bad29kb0JNdFZlOTRVWWhXQVBNUWRHMGRwM2pyRHc2R3VLRWp4MC80cDJr?= =?utf-8?B?dU44ZmJTWSswelUyd1VramZleSt5TEZjWmZraE42Ry9wSU9SQUxidTVBRmIz?= =?utf-8?B?YWJLTVVueWpnOTlzazZudz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 37917828-680f-4bff-5910-08d8f4351a80 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 11:06:59.0009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PSj/IEAluTmKwB+bZ/8c3zOXFxmd/uI6Faf/HSGxX7UwPzsq1HUcgnxIJur9BprZPuQiWobcTxtMtrys5UJtPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3065 X-OriginatorOrg: citrix.com On Tue, Mar 30, 2021 at 05:37:02PM +0200, Jan Beulich wrote: > On 23.03.2021 10:58, Roger Pau Monne wrote: > > Such helper is based on the existing functions to fetch a CPUID and > > MSR policies, but uses the xc_cpu_policy_t type to return the data to > > the caller. > > > > No user of the interface introduced on the patch. > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Jan Beulich > with again a minor remark (plus of course the same that I made for > patch 4): > > > --- a/tools/include/xenctrl.h > > +++ b/tools/include/xenctrl.h > > @@ -2599,6 +2599,8 @@ void xc_cpu_policy_destroy(xc_cpu_policy_t policy); > > /* Retrieve a system policy, or get/set a domains policy. */ > > int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx, > > xc_cpu_policy_t policy); > > +int xc_cpu_policy_get_domain(xc_interface *xch, uint32_t domid, > > + xc_cpu_policy_t policy); > > Generally I'd expect domid_t to be used for domain IDs. Me too, but xenctrl.h seems to consistently use uint32_t for domain ids. I'm fine to use domid_t here, but I assumed there was a reason for using uint32_t uniformly there. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 31 11:48:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 11:48:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103891.198175 (Exim 4.92) (envelope-from ) id 1lRZKR-0003fs-1x; Wed, 31 Mar 2021 11:48:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103891.198175; Wed, 31 Mar 2021 11:48:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRZKQ-0003fl-Ur; Wed, 31 Mar 2021 11:48:06 +0000 Received: by outflank-mailman (input) for mailman id 103891; Wed, 31 Mar 2021 11:48:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRZKO-0003fe-Ub for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 11:48:04 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b03ff23f-811b-4a54-8b38-7aa34f46f21e; Wed, 31 Mar 2021 11:48:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b03ff23f-811b-4a54-8b38-7aa34f46f21e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617191283; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=Pqsiuta4tLV8He0nZdG+3XgTrjswV4232IcmQTuN9r8=; b=hP93KEMoPy+BGYs9qpbqyKa3Iqoz/PtnESHe4EJw2rmLnb5ygm/g5YmA AtMoM1qJMt6o+9h7eRNn6KvXVSW3zdnYBsyVbdCECFXVvJw5EghQ704Nw dNOfliLcoNnEEJI2DQT/P9t6M0xuyddNRAM1mDcTXP/g5nmpyTe05b4kp k=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: jyi0/gRZGkhQDYcStek7IdoT5AF1nZoUkB/U7V0BwTvt8/vc9WOsWHmFHhitQqyaDGVP2gMWGa IiHGVTElrXsOzXofi4Prh0bhHo/XDrYnVRfWOFNCQxI4zVqNbaeto36jQOBYygakBObeCXA6L5 GSBU2e32IgWyZtyARlwRaPFN/c28/9URM2ymnfGTcxDNbSwfUa5W5ndsp7qi5h5R1CtZT9H39f IihcPc/Vhz/18PgS5EejWnkXhIVdzERfpnfMMQcWw5Zh3KDl5AsX/tEcjjNr1eR2SLV+K1mHoc /pA= X-SBRS: 5.2 X-MesageID: 42000114 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:UYQHRKl0NcUoZolSH5vQByvfeZnpDfN7imdD5ilNYBxZY6Wkvu qpm+kW0gKxtSYJVBgb+eyoFaGcTRrnn6JdzpIWOd6ZMDXOmGztF4166Jun/juIIVyGysd49Y NNN5dzE8fxC18St6fHyS21CcwpztXC0I3Av4zj5kxgRw1rdK1shj0RYjqzKUF4SBJLApA0Dv Onl6x6jgGtYHEGKvm8b0NrY8H4u9bJmJj6CCRqOzcb7mC14w+A2frTDwWfmiwTSSpIxq0vtV LYihXj6r+42svLrSP05iv/1tByo/fPo+EzZ/Cku4w5Ji/vsz2PIKx8RrvqhkFQnMifrHsnit v0mDFlFNhy7n65RBDRnTLdnyTtyjQW0Fmn7VODm3Psrff0S1sBeqh8ub4= X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="42000114" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T5Fnlr/LQL9hhFwkBCXRGipvTHpIY3NQ+um/Z0GUyFQ+EE0qHyK1vIaGavPy86DWPqqUlKsoe+pHAdLKb81c7tmQcEYKJI5fPN3luiYBuFvpWkKdS4aI6AfAyIlg6T7tDhmceGSjbprcdtw0vC6uQCVcTlrnILg9cw7OnKYJ/uErIMQ8YlThojdCJjUpEh9Oxb0bkSRdvqXYSjUr8nI3LqUGm23St1MkkLoQvVR80W54Z9D4K8fvW8nShFhwQCVNlfrDliQV67QJEsJJUzyzAuxydqgZD46ABKFjS5a2SxF8NTCoQVarxSuoqV+FC26WX0esqMne4QuTxI2GTtskmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n9Xjwe1/PwRUhoOBGGwpJxFhUY4F5mFQTd6KqR2NGeA=; b=ZNcGWgHMTOneqNDMpbhwmdYo3oNiTpXjZOdt9bM4VQ6aSbbjC26M13cLe5uNQmEV4iQyvivgEm0d8roLT8DrmaMA8lvFdzrV/hlz9eWFnxoDJ2NWLtDQOoWSqBcN5FfyY2pG2JOPL/AgGYanyxWC897vgV20LpVypYWmVtqN5t99uqB/6QmrJy52lIzZNb96lc2EncLcHIVc2+e3xgHmqPfzlRX+XOfD0mwml8siqcWFVPPr2e3tO/a5+yL4WGv/yjin7W/d+fptYDv4+Y032cIDwFsmwT8zOXwAtn+xuVb5zPeBwSoezNXBhkH0JkUlzUarOPdpImHB5OEBnsd3pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n9Xjwe1/PwRUhoOBGGwpJxFhUY4F5mFQTd6KqR2NGeA=; b=gGOdlrwFoeF8aWDx0axrRZLQYWt0DfLcRsVQY7nNtzxAQZ1+7G4eZuWouQhHhBaJ3qjkGVMlYrmBYn/HXUJFs9xkKDXQDAMoCcwxctxejLfZD155LNgMoNISvajV28dkPvVvxobDqsHOy1vsZSF7CXLAfUXyqjtmnaJuvPdZDcc= To: Roger Pau Monne , CC: Jan Beulich , Wei Liu References: <20210331103303.79705-1-roger.pau@citrix.com> <20210331103303.79705-4-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH v3 03/11] x86/vlapic: introduce an EOI callback mechanism Message-ID: Date: Wed, 31 Mar 2021 12:47:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210331103303.79705-4-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0113.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::10) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aad46354-b378-40c6-2801-08d8f43ad575 X-MS-TrafficTypeDiagnostic: BN6PR03MB2868: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v1rGzl309uZRCKsPZWzrnjKkj6AXYK0TmA0paviqyzsNEnjdR3MIYFNpAP4hLMQDY6b3vH7f8GoXnLbZAoZK8FPBl4O0JXk0COJOO5avHjDLcSzsaffXVjGh8qJ+uQXS8OTWcK2oM+MLXDwvRMfuDpazD1zPvMhXT1IlLsul+FAPj6qH+GZrhjt6tmPBCGTLqxYaecQl4lg4heT7tiBGL90huA3cjM4vjV9G3e8rbtuuzx92+kQtEnKAAouun3Hx/DIr0rz/5204yuSgYpdLFod+ewMZKH4kQfeh8DsNgD9fkjkvW4LJsY3FV/ey+fvcB2dVqipTrDSAveBEG+xcVBV4fleiYvkNyJlQXl2SbHEzJF9nSdqo2yLvWEgVVYUEk1cZDP9XpvU0q0vKV8A1iwy1rJ4phdWL1AGOatnHt5ga9DEgCrZiG1wQ5DRaDwcP3qaw3oN7v7PeoVgazPx8caMqJ4muy8CadPxW4XPBhL2bPAwQusdRC6M8bPtvifjK2PGXO0t20eNlWRcr2Gq/Mb8+PfEGWlTYLwbdrmcLU2ZX23MmFymUh/nwGk4TSzpboQG0dnIRHVUaIu242NAixK6TJJmoj6ZcwPmjM+ZrxEJZUs+TDhUIDi0nZlFMb6LXBdo/TbeCwEHnp9DPbzH85bDgc2Kei9T7Hx7QUjKwIzXRj4U50UDR1zjkPd14FMWu47k7CV2yVToqh6byd6vl9A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(39860400002)(396003)(136003)(376002)(956004)(2616005)(66556008)(2906002)(66946007)(16576012)(26005)(5660300002)(4326008)(86362001)(54906003)(8676002)(8936002)(478600001)(38100700001)(4744005)(31686004)(6666004)(36756003)(186003)(53546011)(16526019)(66476007)(6486002)(31696002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?V0xLU0dqS2t2S1VNWGRyaWJ4dGhBOVgzQlhUWmVKQ2RvUEZJVlc0SldQbEZw?= =?utf-8?B?ai8va3pKZzlTcnpORnBid3FWczVQSmZQUjhhSDZ4blVvbHlEU3U0c1pGeUtV?= =?utf-8?B?Z1E0Z0d0K0lML25YbXNycmZ5MEgyRkROTmV6bWEwenBwbjRTY1JnS1NJY1VH?= =?utf-8?B?Nk9EcEY1eTk3dENxYUJOenZsOTlubTNndU94cXFPTWU2WUY0L2g5SjhmSmpa?= =?utf-8?B?ZlYyVUE5aUVIUGFHbUJucnc0ZFBwTmQ2ajJ6cEplK0hpT2NvSmdBdkIzMXF5?= =?utf-8?B?bjI4Q2h5aUJJeUtIRURhRVQreExydzAzMnV1aEd4UDZXenVFamxtMzVSV09x?= =?utf-8?B?SE5Bckd0UlVOZFBtQ292T2V5NWxkQUkzbGp1S2RuM0diV2MwZ3JqVXBORVlQ?= =?utf-8?B?dVQ1V0ZhTlZwbkNjRTBISUhlT0JzSFBPSTFEQi8yZXpoQmlBQ1dSZ2FBekZ6?= =?utf-8?B?ZkZOM0dnM1BibkhFRnNpYVlnRDJKdEFNR3pEVWZVNkNrc0FVbGQwYVpWZW5V?= =?utf-8?B?VXUvczFuRXpwOC9QbGJDZUdzdTRIMGkwTWZnSk80b3MyREU2VkpCWlpDaEc2?= =?utf-8?B?R1psa0hmQk85cFhTbFRaOW1hejFLTnQ1TGsvb2VrWUV3NHVDMEpOTi81NE9S?= =?utf-8?B?R001UzVtRmRhOFlqd3hjMm1OZC82NXl4Rm0yZnllWG9TdGdwbUdEbTZvMUJU?= =?utf-8?B?UVg4THN6Z1p5eVdGazZNSkFQTDUzMHBVY0oybWdVZEUwdXk1WkpITnB3eUxx?= =?utf-8?B?YVpMMVJEYllWOEZRSDM4eURNZ0xyVEdDWnZTakkxUXhjOFJ1MWRnQ21nQ0hC?= =?utf-8?B?R3NnR1k4WTlIY244K0l5VUdlcDVEZ1F3YmNtdXVoYkhpcEFSaVZnT09EWTNr?= =?utf-8?B?UTFKaEFPYWs3dGw0aGU0dHMwTGpTMU02Q3BtYWJLRlBOTUJ6R0EvTmxMcjJX?= =?utf-8?B?djRvV0g1SEhza3o4YjJzYUd2M1BTdmVNY2tYdFk0MWVveWN2dG1USjM4eCtK?= =?utf-8?B?Z1ovWGdzL3I1QnhMZnVndTdxd2VGem5RYUQzOGVRK3kwa0U0RTVDOVhXck9S?= =?utf-8?B?VURBYzEzdmh3K3BOcm9hSUdRZnF3ZHlEenpHZTNoUFRibXcvaTlKM0c0MWlq?= =?utf-8?B?Vi9NSnVvTzdkS2FZOTBxN2Z5eGRvczkzb2pjR0t3UnJRcE5nK3dDQmpGcEhs?= =?utf-8?B?U0ZwN2Q0SE5XczRxZXdBQ3VsL01QOUJKNVJ1ZW43YlhIeUl0ZVNKNW1CV1px?= =?utf-8?B?WDNJSTN4emp6My9LUGdKME9jZUVGN0xkVFlON0o0VzNGNG1qYlcweWtCUXVK?= =?utf-8?B?ckZEaFRHS3pGbzhrS3RkSXU5SlRER2Z4V1Ruc1lQSWFhb2VnT2ZtWFNTUVQ5?= =?utf-8?B?ak1CeHk3S0JxUlVRWGJGL05aM0M0SEg3OFBOZW1Pcmo3MCtoa0pxcU4rSEcv?= =?utf-8?B?NGJiWStyWHlja3VmOUl6U2tFVHhKVXIwQWZHUW5ycm1RWTNNMEhDQVJhNVlN?= =?utf-8?B?V0FiSXpodlREak1mUkpqUVR4dWJTSlpRekZlWnozam0vTjJZODFTcDFydnRo?= =?utf-8?B?dExwdWl3MXpyYkplL1dVY2xTUnB1RG5Ub0VwNUlOU3phU2VqcStqK1VNT2lN?= =?utf-8?B?RlhOaE5rL0swU214enprU0Y1NkhaTXU5RkpEU0l2c2pRUUtHbkM0VmYyY21U?= =?utf-8?B?R0dvTEdUNk9SeXlhbjlwdXR3Q1dlaGVDN0pWbU5nenR2ZmRjd2o3bGpyTWtG?= =?utf-8?Q?WsKG9MSRtLQ8R8dqXuOOS+PlmO6Nj0eYtiJpBYP?= X-MS-Exchange-CrossTenant-Network-Message-Id: aad46354-b378-40c6-2801-08d8f43ad575 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 11:48:00.1229 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DgtYBtB8VUuzvk2tRumu4F2epPiVLSeaTG0Yi2L//3MuXVtIYNCyncKi0E4A8rMEbSHnB6pUK1fh24vpTILA81fmwMOHfTzReFB1ZZxayL8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2868 X-OriginatorOrg: citrix.com On 31/03/2021 11:32, Roger Pau Monne wrote: > @@ -1620,9 +1666,22 @@ int vlapic_init(struct vcpu *v) > =20 > clear_page(vlapic->regs); > =20 > + vlapic->callbacks =3D xmalloc_array(typeof(*vlapic->callbacks), > + X86_NR_VECTORS - 16); > + if ( !vlapic->callbacks ) > + { > + dprintk(XENLOG_ERR, "%pv: alloc vlapic callbacks error\n", v); > + unmap_domain_page_global(vlapic->regs); > + free_domheap_page(vlapic->regs_page); > + return -ENOMEM; > + } > + memset(vlapic->callbacks, 0, > + sizeof(*vlapic->callbacks) * (X86_NR_VECTORS - 16)); xzalloc_array() instead of memset().=C2=A0 Also, we shouldn't be printing f= or -ENOMEM cases. As for the construction/teardown logic, vlapic_init()'s caller already vlapic_destory().=C2=A0 Therefore, the existing error path you've copied is buggy because it will cause a double-free if __map_domain_page_global() fails. I'll do a cleanup patch to fix the idempotency, which needs backporting too= . ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Mar 31 11:55:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 11:55:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103894.198187 (Exim 4.92) (envelope-from ) id 1lRZR8-0004bB-RJ; Wed, 31 Mar 2021 11:55:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103894.198187; Wed, 31 Mar 2021 11:55:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRZR8-0004b4-NJ; Wed, 31 Mar 2021 11:55:02 +0000 Received: by outflank-mailman (input) for mailman id 103894; Wed, 31 Mar 2021 11:55:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRZR7-0004aw-Pu; Wed, 31 Mar 2021 11:55:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRZR7-0001fX-Ic; Wed, 31 Mar 2021 11:55:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRZR7-0007pX-AM; Wed, 31 Mar 2021 11:55:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRZR7-000806-9r; Wed, 31 Mar 2021 11:55:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KMyszJIyERD4wTkPSlz8wBi1SW3vCGV1aZs4v2uZxGc=; b=fid24FTURTb8c8SlP3qfs+3jVQ cwJEBgJRn5P3+xDuNUjL6kLwQMdfk2RR6yMPdDOUECh62hIclD/GyU73lT0oggynL+PRi1Wu1TvTO xI5+ryI5Z3kwDO5hYnYv1lASh3TGrz5A6QNfgR9yL1cEqYoj2fDFY1j7VuohIIwB2bvw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 160563: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-freebsd10-i386:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-saverestore:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-saverestore:fail:regression qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-saverestore:fail:regression qemu-mainline:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:regression qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=7993b0f83fe5c3f8555e79781d5d098f99751a94 X-Osstest-Versions-That: qemuu=1d806cef0e38b5db8347a8e12f214d543204a314 From: osstest service owner Date: Wed, 31 Mar 2021 11:55:01 +0000 flight 160563 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160563/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-freebsd10-i386 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-freebsd10-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-freebsd12-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-amd64 15 guest-saverestore fail REGR. vs. 152631 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 152631 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 152631 test-amd64-i386-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-xl-qemuu-ws16-amd64 15 guest-saverestore fail REGR. vs. 152631 test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 152631 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 152631 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 7993b0f83fe5c3f8555e79781d5d098f99751a94 baseline version: qemuu 1d806cef0e38b5db8347a8e12f214d543204a314 Last test of basis 152631 2020-08-20 09:07:46 Z 223 days Failing since 152659 2020-08-21 14:07:39 Z 221 days 419 attempts Testing same since 160563 2021-03-30 15:22:45 Z 0 days 1 attempts ------------------------------------------------------------ 468 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 138445 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 31 12:41:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 12:41:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103922.198202 (Exim 4.92) (envelope-from ) id 1lRa9b-0000dw-Jz; Wed, 31 Mar 2021 12:40:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103922.198202; Wed, 31 Mar 2021 12:40:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRa9b-0000dd-FP; Wed, 31 Mar 2021 12:40:59 +0000 Received: by outflank-mailman (input) for mailman id 103922; Wed, 31 Mar 2021 12:40:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRa9Z-0000dY-RE for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 12:40:58 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2d3aa953-2de8-4275-9055-1495d6297cac; Wed, 31 Mar 2021 12:40:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d3aa953-2de8-4275-9055-1495d6297cac DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617194456; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=VI1BaDzdGEH0/h8DyWQp/5UDPEGnm+1gbpkZaCAIqXA=; b=P6mb/PtJmF3u7Js8MFCoh+3RNSxEftiSr2L2VE/uauqFknAib416n9Ek WsRnhLvwCJnPxilpr/ZiHbCyi+/DmA3eTpTEpxQVG6+zf/DF5QnK42CO2 ywa4OM1iBjC/FEBndaBbGu/uL8ql8cwinyu+GST6MM0qDTw9IEdq9kcEz Y=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Wu05XjAmR21AP2/1oGk25oWh0v8R/kcTJo3lZDqnMiRvanMp/6+5gU/uIHNpeop3fQRy8LD77P +34Zjsb0ZiqO+/trdoRjRoKcaVbOBKNuVqUNsPV4bqsSStvn+30YFZzDnBkg79Hi51MJlRCXCP Ynx37DrnKRzT7RM6vhpmURt+13iVFz7C3mqNjz1U7vnIt8dqr/qY7ZXoW35yniIR7YrjcHv1V6 WQ9p4543gPHaT3UL7SKWZZ5GsepTGLTtjr0cgXTF1wxef1oFhXBy+bRNvDsFXgfC34sKfxCszg Yq4= X-SBRS: 5.2 X-MesageID: 40427375 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:vJpWcKAyCcUC0nXlHeiusceALOonbusQ8zAX/mh6QxBNb4i8n8 ehgPwU2XbP+VEscVk9hNGNP7SBS3vA9ZhzpbIcJ6umQROOggCVBatJhLGM/xTLHSri+ulBkY JpdKZjANP9ZGIK6/rSyg++Dtom3Z274Lml7N2utEtFYAl2Z8hbnmREIymBFEkefmR7LLo/UK GR/89W4wenEE5nCviTJmICWNHEvMCOrr/cCCRtOzcCyC2jyQyl86T7FR/w5GZlbxpqza05+W bI1yzVj5/T0c2T8RPX22/N45k+orKI9vJ5CMOBkcQTIDn34zzYAbhJYaGIvzw+vYiUhmoCrd jWrx8se+R15n/BF1vUnTLR2hLt2Dtr1nn6yVXwuxreiPH+LQhXN+NxwaZiNjrQ8Q4Jocx12q Mj5RPhi7NnSTf72Bnby/eNfRdwjUawqWclioco/gRieLpbUYYUlJcY9k9YCo0NEUvBmf0aLN U= X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40427375" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CJdSmOwMrEAEeJefgfKC32UfBtTSHOAeKDI9IuNTztc5w8AFlXQ6cyRU49iijapj/pgpIaILunY9Tij3KhiMxTsmxbtBFn6dcgnZVboUc0dG1wz1ZxMkcVOwjPOXqW0crqGQdRcFgqpSuPAAPuiNH+BJoU5OLqFtSrY+cgvQkJ6ybFI+dC1SPG3r7lW/dtwi3w160pCHfd9ii3Miav4y6G9MknuwwYLxwgjl49h63sRSKaMPxYTzGh4P3nFMfsJ+Irkjd3UrBlrPuOmcZ3yWFDQS9agYVHFUi3I2HlaAk3hJ+H3PY7pxT2s7L4mvtWfWi53rqKyruoHCmQrVOs0RmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r3jKF5UtqvNsukXx9qzN4zUUHNJt1+ocQm6kZ7n3yQw=; b=HGQXPMdGe7i8yvpT471GFcqms2qxTfuGwv4DKXXHJ//cx7gwrMFBx/iprx6tuY0LN1130awHvtgS61RSNa1pJnYMH51MwlMnD6WdJ1rTf48nL5LZYUJI7GMN5REBEgdFR2bJ2RHc9kj3hQws0+mH8zVzG5bOUGKPu4G6KIIx+DiQiCouNgwXE95GL9EhEEbh9lothAODGrD9W+3Rg1Z223OYAUgQ7BZwvax3y7awvy0GCpa17DtEyseW7taPK2yP3aGjIeoif9pjZjAr78OzsIaN14eSMszdEOqiNKuZmvcfp31PJbk2VZmzdzKYk5n/0v5J144dzL7rnuMfutM0+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r3jKF5UtqvNsukXx9qzN4zUUHNJt1+ocQm6kZ7n3yQw=; b=oVHuVxmeRb7o10Xr3yDXRRddeiVItUwU8rN5aqnnhxHhCB7X+lRGUDkmQISX5P4mpb3Zh+AYlwG3yk8Di3tUsPSQuatxxjMG7ycK75ZGSf1SF7dOgPiJPZs5aq2PpfCD2VSwojPWYVmJ846+zFKG0meIojsnODoBSFJJO6Oj9DA= Date: Wed, 31 Mar 2021 14:40:46 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , Ian Jackson , Wei Liu , Subject: Re: [PATCH 14/21] libs/guest: introduce helper to check cpu policy compatibility Message-ID: References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-15-roger.pau@citrix.com> <8f7a2f44-c006-0f94-8f44-b6b3ee3e9d1f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8f7a2f44-c006-0f94-8f44-b6b3ee3e9d1f@suse.com> X-ClientProxiedBy: PR0P264CA0115.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:19::31) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5e8d62ac-7473-4134-c4a5-08d8f4423887 X-MS-TrafficTypeDiagnostic: DM6PR03MB4300: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XzqohaF1fBhU/KBzczyu0FqYrsmm3QPmNWzJ+ykavWPAcEcxuXaxrWJvNv9oshnHtxNgq+jZDmD58XMFOO85ctM8CBwwmpkFaErpIXCDgPi1aspU9C2363rFFwYlkEgDudP9CGtUNFXCXUEJkMGovjU/ZLARxeNmpoQSxnCbyRODjMUL4CO//ATLuNNXySD7Wmfvyf7D7SFAvRD9lxMQr5RuSEEGIMWtgGLuaA04zKRi9N33gRbORqpRbLvQO0OxQp6suEq0738nM2ao5MUt6XwOeYXCHxTEDw6uVHJ8NaPi1sukCgmwDWaUyclsm3xzbdI0qEfysGTS9T37zdjWpQwslcckpTuefG/gRaACYVV1nET3iq6FW+LNKCaCGjll/UK+1IiAdIwPg1NEzmpO/lqYNgR2jlIwnS6IPWwJAD9RbrEiEjm9n+G3koDCXYCK8xdp62iMHVveYhpj5AzIsh5u04UsVGaWK7+qVfjCqnnczwQbihkKTB6+/nCv9G9fB+cuX3j7RRjYWBuVdzsc8HtS2md211BKFcJYqxYTCcagMvcw5g94cIjH0yPxtjk4g9A9hI4UxIHQ3EFDwv7r0Id1N0Ww6dbF4Hh97JOQ7HVq6PlRQp/Ih/OjoPn+bnBUiE2qtQDpoBPDNY4ENooFag2d9W9tB+0X9YqcGh7R0wA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(39860400002)(396003)(376002)(366004)(346002)(136003)(53546011)(478600001)(6916009)(16526019)(66556008)(66946007)(9686003)(85182001)(66476007)(6486002)(33716001)(38100700001)(2906002)(4326008)(86362001)(5660300002)(6666004)(83380400001)(186003)(316002)(6496006)(8936002)(8676002)(54906003)(26005)(956004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Wk80V2NwazYwNDJoL1lGaXE3N096Q2xEYWhOZTFTa1lWWEFIMDJEUWg4UE5P?= =?utf-8?B?eFFvUk9ndTBUdTNHeHdVUzRMQVlBS2ZDenZKKzEwbytjQWxsWFFQY2puM3pV?= =?utf-8?B?Rk1XbURYeGV2UHprMis2Zi9IZlppVWltcVo5TkZVOE5tWEQ5OWJUYUFYVVhN?= =?utf-8?B?SkFHQitmUzBqVnlCRGc3NDNRT0NUeTNPSHNTTlhoNnhEb0JTcldwb1ppN2h6?= =?utf-8?B?MUhLVWJuT0JiY2ovNEIzM3JRMk0vV0s5Qno1clJGNzh5UVQ1enVoRTJHOVVi?= =?utf-8?B?cUppWFVxb0pLdkZ3NkxDVExYV0prOU5SVk9NczNBc0dJdUlrbE5xU3Z0bEky?= =?utf-8?B?V3BZU2tpZUJIaVJQazdtYk5uWVNnTEtPSFRiUVFiSVh0VzFDaUF1UlNyMjBS?= =?utf-8?B?eHhESVlLR0ZQSG9xTVY3aDd3YklqWktoZnBGeFg4dW5UNkRnUzBwekRKd3Fv?= =?utf-8?B?QTJ0QlphV0dyZWowZUJqOHp0Zi9BUXFHcTJmdy9DNExWejcrVE5qZ3lQc2ow?= =?utf-8?B?ZEU3QnJRanFHMEc0dDRLQ0lMaytSRTVUWEE3VDFsVDFnaVYvZ1c2cWNWTDJk?= =?utf-8?B?M2Q2YlNDSjdDSmxWTHoySitqaldDVEpTbnA5R0cwNE55UXZiSGJIeUlyTk9k?= =?utf-8?B?L0phNnRpTVFXTHlxNy91QWRZWDR5bGFJT25LZmkxeFBvb0FmZWZWakZ2MXZa?= =?utf-8?B?S0hsbll3akk3eFRnZ09ORC82a1Q0alRoLzhVMGdwK1B0dnFVUzZ5UDliYTdl?= =?utf-8?B?cW00cnhtdS96emNFb29vS0lYR3FWdGhHN1VrcVRjQ05PTVl2NHhsK2FJaFNu?= =?utf-8?B?Nk5iRzVDb3ZvcUw0Z2kzWkx2WnZEK3V3Q2JsSElUbkZRZkg4VXVsUVhRc3NG?= =?utf-8?B?UGFUMm5uN1lTN0UvZVhYdlVDSGFqdllxczN0bTdnckFobm1Uc1ZZaVA2cVVx?= =?utf-8?B?cE5XZmwrWVlQSWN2cHJYcXQ2VjVnUDFUc2FaMHJ1MTdJZDRHMUMyNllma3Mv?= =?utf-8?B?SUN6S3ZOQmdwakIvdTM3c1Z2Zmw5dThKZVpGdXF5cWw1aUx0cW83UjQwR1Z2?= =?utf-8?B?UjhDS1pKaFp1L0VIc2p6QzgzZjB1NmdiK2M0ZFhFbldvYUVFSFBQbDdIcCtL?= =?utf-8?B?dUVobC9sZnRwbHVwSkExRzJabGdjRngvUm9yYjZzM2dhdGJSVDBzeitWdDV0?= =?utf-8?B?cWFHZG9pN3ZjcTlsWW1hNkk5U3R2SUFsaWoyWmNqTi9jdzdDNXYrTXg3a3V2?= =?utf-8?B?cERuaExwZ05FbURPR2h0SXN3dWFQNzVIZlU2NWV4d3BtYWN4ZXBCdHVuN1F1?= =?utf-8?B?N0lsQ2R6K3J0RUZ2T3lFS1YvRG1OVHQwVEZ5S2xyQ2hFR1Y4bVViVFRXdHMv?= =?utf-8?B?UnhrUVMzWTF1enJuODZFV3RmZ2pwZlRzWWJ0aVZCTTFiZm5BcGpzWHQvaUpR?= =?utf-8?B?TGcvcS9ZeFBXTEdLUGNYVlJXQnh2Vjd6RHhKRXo2b1BhbG9vdHR2OGNLWHVa?= =?utf-8?B?U0FtaHRaeHJHUFQ5dk5kcWFVOVRKNnJYUTVQNmlmNjVyRHlVS3B6cjBpZERo?= =?utf-8?B?amxiWE9KNnJYYUVPYlNMcDMzd2RWdC9yZVdLdmVNREhHTXRyc2J6aFJRYzA4?= =?utf-8?B?MC83OXhGTzQ4cXpST2hYTEhHRUQ3Mkg4OGtLdlNNSGZaUktERWZ3bENFYVpX?= =?utf-8?B?UEFqQ3Fjb284OGdxZkZ3VzYyTnFqWFQyL1FVditMT1A3NXVaWThnQWVxZnJI?= =?utf-8?B?SVZMYmRwc2o1bm9lVDFWdU9ZNFFvWGt5QW55S0pNNW9mNHpTaG1qOWw3dVZX?= =?utf-8?B?VXhmTmpLN0NCTlM4cER5UT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5e8d62ac-7473-4134-c4a5-08d8f4423887 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 12:40:52.8347 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RmF+4ZbiN61boKFUPPkjZDhUsMGSBwH7vumMxqLLVsShPVpzAGU0KsAXNTZljbtbm7WyrCJBqFMsjiv955sGfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4300 X-OriginatorOrg: citrix.com On Tue, Mar 30, 2021 at 06:02:45PM +0200, Jan Beulich wrote: > On 23.03.2021 10:58, Roger Pau Monne wrote: > > --- a/tools/libs/guest/xg_cpuid_x86.c > > +++ b/tools/libs/guest/xg_cpuid_x86.c > > @@ -1098,3 +1098,20 @@ int xc_cpu_policy_update_msrs(xc_interface *xch, xc_cpu_policy_t policy, > > return rc; > > > > } > > + > > +bool xc_cpu_policy_is_compatible(xc_interface *xch, const xc_cpu_policy_t p1, > > + const xc_cpu_policy_t p2) > > +{ > > + struct cpu_policy_errors err; > > Don't you need an initializer here for ... > > > + int rc = x86_cpu_policies_are_compatible(p1, p2, &err); > > + > > + if ( !rc ) > > + return true; > > + > > + if ( err.leaf != -1 ) > > + ERROR("Leaf %#x subleaf %#x is not compatible", err.leaf, err.subleaf); > > + if ( err.msr != -1 ) > > + ERROR("MSR index %#x is not compatible", err.msr); > > ... these checks to have a chance of actually triggering? (I'm also > not certain -1 is a good indicator, but I guess we have been using it > elsewhere as well.) Well, this is strictly the error path, at which point I would expect err to be properly set by x86_cpu_policies_are_compatible. I can however initialize err for safety here. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 31 12:47:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 12:47:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103925.198213 (Exim 4.92) (envelope-from ) id 1lRaGH-0000r6-A3; Wed, 31 Mar 2021 12:47:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103925.198213; Wed, 31 Mar 2021 12:47:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRaGH-0000qz-6e; Wed, 31 Mar 2021 12:47:53 +0000 Received: by outflank-mailman (input) for mailman id 103925; Wed, 31 Mar 2021 12:47:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRaGG-0000qu-5b for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 12:47:52 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 09285ae6-d139-4523-82c6-12c37f772f85; Wed, 31 Mar 2021 12:47:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09285ae6-d139-4523-82c6-12c37f772f85 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617194870; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=YbpQLEEV61oRahyMsPxDBF89XFYXmd/uS9twCmsXoKE=; b=TSm2gkXoLD+NU1mAV0J+SwT7ROS0HALjDvT5XNMf5kSIytDcBNEOXQan h5NjxFRCLWAVHIX7Dh/lgiIbvoODTjRaeYWm3H16n6jcwo/V+Rn1zluF4 gIFz+HvtCIPg1BMR7QN5aYdIvqs261HcpVHJ0NXkcSNk2wHBU2TPrTMwr 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 9NCmvY16RvpIrz/dKQsCQRTESVSxoLjz7iev3Rj1V+1hDWm5Gz6IvRZQ+VoD6TvJpKeResixny dNrVAEYwFhhFaC6hnmmO306Fxb/4KSQRmjbpcS8eGpfXbniZ7Ykshnsp2J0H3yGVn4qkWZG2YG TlaVk1/uJFAGAUdmnZxpABuFJ8JRaZ3nZx6iR/fDtMYV9P+KUK9NQCVOIn3pb5MeiawyB9+QLl qVB9IogANntZ48IEwRX1l2X+tD+4T9+HO5jiUjAihYWpL+gPlEhZnlYNxBa0bEyKFdKkOsDbp+ B9I= X-SBRS: 5.2 X-MesageID: 40698558 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:iDbA6a8x9ZfKDLrMvupuk+FLcL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmzybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIULD38Zn/+ Nbf6B6YeedMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsLV4hLxW5Ce2CmO2dxQxRLAod8OZ qH/8xcpyehf3N/VLXHOlAuWe/fq9rX0K/3eBJuPW9c1CCirxONrIT7HR+RwwsEX1p0oIsK3G DZn2XCl8Cemt6hzBu07R620713n5/bxsJHFIiwjKEuW0nRoyKJQKgkZLGYpjAyp4iUmSYXuf 3BuQ0pMcg2y165RBDMnTLX1wPt0Ckj5hbZoDfy6xaTwr2aNUAHIvFMio5DfhzS51BIhqAG7I tx03+ErJ0SNBvcnU3Glqn1fit3nUm5q2dKq59rs1VjV+IlGdhshL1a1kZUHJAcJTn9+YAqHc J/Zfusmsp+QBe0aWvUsXJox8HpdnMvHg2eSkxHgcCN1SNK9UoJg3cw9Yg6pDMt5Zg9Q55L66 DtNblprqhHSoszYbhmDOkMbMOrAgX2MF3xGVPXBW6iOLAMOnrLpZKyyq4y/vuWdJsBy4Z3sI jdUXtD3FRCO37GOImr5tlm4xrNSGKyUXDG0cdF/aV0vbX6Wf7CLTCDclYziMGtys9vQ/Hzar KWAtZ7EvXjJWzhFcJixAvlQaRfLnEYTYk7odA+d1WSot/aC4Hju+DBGcyjZobFIHIBYCfSE3 EDVD/8KIFr9UawQEL1hxDXRjfMdyXEjNdNOZmf29JW5JkGN4VKvARQo0++/Nu3JTpLtbFzWE N/Jbjgg56qvGXexxeN00xZfj5mSmpF6rTpVH1H4SUQNVnvTLoFs9KDPUdfwWWAPR06a8/NCg ZQqxBW9MuMXtKt7BFnL+jiHnORjnMVqn7PZYwbgLe/6cDsfY59KI0nVqx3HQDiDAd0hg5ulW dGZGY/NwziPwKrrZ/goI0fBenZedU5qhysO9RopXXWsljZmdsiXUIBXzmlUdeehCEnQzY8vC w3z4YvxJ673Rq/I2o2h+o1dHlBcn6eDr59AAOZX4lMgbzwdAZsTWCFuCyCh3gICxnX3nRXol akATyfePnNDFYYgHxe36rw2H5fd2mWfStLGztHmLw4MV6Dlmd40OeNaKb27nCYbUEaxPoBdB vfZyEJHw9oz9er9RKclTqYD086zpE2MuG1NsVkT5jjnleWbKGYn6APGPFZuKt/PNf1q+kRTK axfRSWID6QMZJe5yWl4lIefA96p3kvnam2hFnL7G2k0GU+BvSXClJ8XL0fK8yd6W+hZ/vg6u QMsfsF+c+LdkP2YZq67IuSSRhpABbau3S3QOElsoo8h9N7iJJDW73gFQLV33RG1igkJMj6lE kiUL12iYqxT7NHTog3QWZl5VInm9SEEVszviH3CuE4e0sxj3WzBaL/35P47Z4uCFaGvg3+JB 229DBc5e7MW0K4pPQnIpN1BWRdc04n7nt+uMuEao3LEQ2vM8VO5kCzPHP4ULhTTsG+aPgthy c/x9GDhOmMcSXknCjWoDtgO6pLt1+dfvnaOnPEJcd4t/qgOVqNhaO24Mm8yBfPIAHLFHgwtM libkwfbsNKlz84qpY4uxLCE5DKng== X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40698558" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lWwyLFkU/oiYQB5ntuW8YkrlsE0rR/LyctL1kExYmSw8q4VybpSFNRsrwRUKDG4I91HFoxMc5XLg1MQ43pAMOoS+dnZSCnCEwdMTFtXDDOg36aJNz2kRGsFEOCnSBo0y+cX+ZVWEVz7oCx7s3Y1D8D2s7F9mxDycnZECckQGXMhWNFTTZ3jqREG8i6pKJ694wwOQ1xKDyp3ee3OAGSSlzrJvNu2RkyheLbxRSoVRYK6eJq+ygf6oTsjgp5SCoFtT23Zu/Ecs07nAncx8Uo0fT0NUVZJAFsDDDmwkao45bKzmfAdNN8gfZLraGszxrgpmtI2AW84Ijq/OKn3WL/w10g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fqe121CWTkA1QpsXwlGVx3sF9YsG+h9QMxHFoPiNb/A=; b=kgT8eq2FSEwTL+c1YOQDnIWysfLn/UF015jqF0rs4JceKBu7zLCtl7UqE8w3hMnkh+mxj+QjnS5auJYEOPgIVh0YCbgsdm8whO9U3SJUt6ET4GzstzI+GQEM94g3q2DR2B0RcuBq7XgpYKk7eqmmMhB1kXIVK7xx/j0K+ZkPV5Wm9z3BdAckNyOyIVxg2suGOYKlJMrnP4jWPN3dF64FG1G4QvUu1Mayc1EL4Q2Epcpf5PeIx+NdyFikbdVXk3Iz8gsVl7BkNH8J/ArsIeP91Jhzx3vjuK/bizBT4cGtCr0TRvXmLTldJN0V1UuASm69yPrMqiLfAwx7VOQAnv5TAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fqe121CWTkA1QpsXwlGVx3sF9YsG+h9QMxHFoPiNb/A=; b=Jk/hYFBx8B+kytwg401WWcw2M2lwpiW5IabCt29faPAM36VQdWjGgA04navpFgqMm9nF4HYbFoentlfc8BfuhtJZscIk9h2H8R1hEoLZMhQO9XZMWH2NtyxW7FWMp/Yef+kqYzp2Bg8t0aNZC04/XTj6Yt3ES0cyPRfOsJP8Cjo= Date: Wed, 31 Mar 2021 14:47:42 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , Ian Jackson , Wei Liu , Subject: Re: [PATCH 11/21] libs/guest: allow updating a cpu policy CPUID data Message-ID: References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-12-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MR2P264CA0165.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::28) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 975a2d7f-c79f-43a2-118b-08d8f4433034 X-MS-TrafficTypeDiagnostic: DM6PR03MB4764: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1775; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FKny985RdPvEOZioy9vMDVtpeTb9wSSJobkziMivDpU1ARFkQvCImW6A6Au9MR98/rlG8u+uIT/4ZpS2f58Idat/4XHjTdPdtLWd5o/HXKL8Zx24qzgn6fVpmTjkT3o5ySIw+pn9Dr41X/9r8QAabjO3wyYiUwZRc6227hWGrbrWI/CfO8q89nNMvmjcPL/yS4WgT9bFK/qzEqE53l0kH5TZ9RAc/XPX/E2iaIGuq+CV+3DtFKMunfox18yIlhizw5iakVozp/zyfQwI5QRSBG/TkdKIrLELV1mbLq1Zg4yE+a4bxGNzCUiTXEj8YxWEtpivjtWBR+xzm8q9KgNCrGg3iGp8LfMncwQqPwO6kCCsBVsk+Xr6TVVIuW/UtnolaMoz0+tij8eivZRtO4Ng5/7hkxX8Ye5LQTb8uEJTPJWTxbFG3mgOSXC8wq3joKan1JUorkEgbwfLupIxdqXgw8tpb2Ygenvu7UHCcECcd5Gvyv1s2lcwDzIhBtV7AusmrRpaG+WvEyuHhlnZ3SdfOtt+FVVwmFCPWWqTr8vuXmAfQvDiPlWK1e3WRIVBKSW4/TpXNDssfFyApQwg24+9E/CEVEOaf9w3K0UBwXszhlPLmf0Sx+SlVtAtC4wxcPN5gm0qJ1ImkCtxq2F+QwNZWqfS+X7TZ+knt5jzFlhz/jo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(136003)(39860400002)(376002)(366004)(346002)(396003)(6666004)(26005)(86362001)(54906003)(4326008)(8936002)(5660300002)(83380400001)(6486002)(8676002)(38100700001)(2906002)(478600001)(85182001)(6496006)(9686003)(316002)(16526019)(956004)(33716001)(66476007)(66556008)(186003)(66946007)(6916009)(53546011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZUtjMUlldi93RGZBZVEwKzlZNjhFVUlobHVRdTBhWThXV0N2OVNEQUtPakNC?= =?utf-8?B?T2Y2OGJYTlhoMytJZ0pwVHRkbGpSSngrQ0xOTTNSM3BzTlVsYVQ4WEI4TU4r?= =?utf-8?B?NXlGS2F0Y1ZhWm9mS3FYQVBZODNOM05iUHgxdCt5aklVMXYydDRkeFkvVCtv?= =?utf-8?B?ZnpTT0h3eDc5NENwMExiUS9lRldUazhhaENhb2ZtZzhtMmE2dUJpb3RUczdG?= =?utf-8?B?MC9WaVdQTUlZWUNnWTBxYjNuTzhQM2JKOTBBZytDSVRRTCtxakRqYVhqdTdH?= =?utf-8?B?S0hxWUdrZkd2Vk5lSmQzZDRLWmZtSXllYnhLQ292Mm9COFhGbXAzUWVsL2hw?= =?utf-8?B?Q0pkM0RaS0hidVlwcGxZaFhua2R3QVVKaWw2WFNhOXNPWnJrNE1iZWlPalEx?= =?utf-8?B?dTUxRnorL0ZOZ0tmVmk4YTV5TExhLzJiQXVsdThVbTA3NkVxaEEybklxaWJz?= =?utf-8?B?NzNiSnN1SXVyZ0lGSmdhRlVsN1NJOVJ3WS9vWU9GZlhQTS9kaDhyUEJqT2sz?= =?utf-8?B?OXBtR3did0M5VzNPSW9tN2JBaExvRVQ4NUJVZkN3VjduYmhDSnVWbW50MlBz?= =?utf-8?B?bTVYUyswU0lJQVdra1VFeEx6YXp3VUhOa3pGN3RRcWNQWXZhTjVnZjBPSmVX?= =?utf-8?B?L2dLbWRBYkFWZFkyUytGNDl5aTN5U3hUcklKTTJDbTBYVFllUVhmVTFDMlRO?= =?utf-8?B?MnFzQ29ka1Q1SFQ3dDZmTTBHd0JMUDdwdExOSzY0N1NiNVB0QjVrOGlxQnFa?= =?utf-8?B?TDE2Sm1zQmJNUU9STHZEcEl4OXZ6VkxBY0lUV2pNcjFMbFZQOVovTktkK1NP?= =?utf-8?B?OW1hZklxMjUyQmVSUWJPTkllMmRpY0RhSzREdklhNVNodklIMzJmbkRNdVpF?= =?utf-8?B?UUlNWEdpeXp4OUNucURQUy9nVi9VU0VMQ3NNUEtQSGw0YW02L0E0UC9PV1l5?= =?utf-8?B?VlJhV0l0dWJLTy9Ia0Z6Y092eWJnV2Q1R2YrMWJucGlUVGY3NlRnQlpUTzll?= =?utf-8?B?S3kvUlZyZk9YcGhnZjhsVDRXWnQwZW84b1FVSGZiT2Q0dWNPNjZHcUY0YUxl?= =?utf-8?B?UHhtTnpwRjZ2VUd2TVB6Z1JyWkwrNk0yck9iQy84V2FlbURoWDM1b3owMW8w?= =?utf-8?B?NFRCTjVDakF5RGx5bGN1Mk1ncGFVKzVaTGF1Y3lWZ2RHY1hueUEvZEswNVNW?= =?utf-8?B?RnV5c2NuQnJQRkM3YTZJS3RkejZwTHFFblNFd3NBYlVscTVLM0JTb0dDMU44?= =?utf-8?B?SVdVZmQ2NU1abGQ2M29KT1EvSzN0dm02VG1oTFZubEh6R1c3VE56WStOMC9u?= =?utf-8?B?UXR2a1ZVSkxzYmYyaDhDZHl6RFhnaE9wMURIMFJ3MXJZN0lUWDdtM2N5UDNI?= =?utf-8?B?RndIdnZkREhNMnU3L2krRm5KM2pnUDdJNytZc3Z2S1BnNkZDQVF2dE5hVTMz?= =?utf-8?B?TlpHaXpIRVlTbmNtUlMzdEdNRFNPYURwQ3pTbktzSTZHcW10K2dxRE1VTko5?= =?utf-8?B?WFJ2THQrQjlIOGdJYW9DNHRqNzNNclJaZmhPRVkwQXN3OE4yVUJCOXZ5R3F1?= =?utf-8?B?RlJjTUtWNTZ0ZzloYlFNUlNPQno4eGZiUlJRRkVPcnNIMHg2a01Eb21kTkY1?= =?utf-8?B?TzJkeUhZM3dBTkxhMkV0ZHp4QnBGT29DcHRSblF5MUVNMzlmQ3hFUTBsRTk4?= =?utf-8?B?RUpYTHgwNEQ2WUg2VkNYMXJmNUdEMVNPK3JWUno3cEpvVk1PbTRjalUrZEJt?= =?utf-8?B?NFJoSzNHUmpJS0ZRQjJUU1o0b1RVRmlkWWFhSFhhTDhZWG1PSFFad3FReTBF?= =?utf-8?B?dkY0MEtocEY5djhuNTZ1UT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 975a2d7f-c79f-43a2-118b-08d8f4433034 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 12:47:48.3810 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1G62teZJgmXp5z7nRy2OMo/B4d5KCcdpbs1vu37bh1n2IKbP8Z3O/TKHw4oJPVM18cod3iES/fLTiPr/Yn6DzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4764 X-OriginatorOrg: citrix.com On Tue, Mar 30, 2021 at 05:56:35PM +0200, Jan Beulich wrote: > On 23.03.2021 10:58, Roger Pau Monne wrote: > > --- a/tools/libs/guest/xg_cpuid_x86.c > > +++ b/tools/libs/guest/xg_cpuid_x86.c > > @@ -966,3 +966,70 @@ int xc_cpu_policy_get_msr(xc_interface *xch, const xc_cpu_policy_t policy, > > free(msrs); > > return rc; > > } > > + > > +int xc_cpu_policy_update_cpuid(xc_interface *xch, xc_cpu_policy_t policy, > > + const xen_cpuid_leaf_t *leaves, > > + uint32_t nr) > > +{ > > + unsigned int err_leaf = -1, err_subleaf = -1; > > + unsigned int nr_leaves, nr_msrs, i, j; > > + xen_cpuid_leaf_t *current; > > + int rc = xc_cpu_policy_get_size(xch, &nr_leaves, &nr_msrs); > > + > > + if ( rc ) > > + { > > + PERROR("Failed to obtain policy info size"); > > + return -1; > > + } > > + > > + current = calloc(nr_leaves, sizeof(*current)); > > + if ( !current ) > > + { > > + PERROR("Failed to allocate resources"); > > + errno = ENOMEM; > > + return -1; > > + } > > + > > + rc = xc_cpu_policy_serialise(xch, policy, current, &nr_leaves, NULL, 0); > > + if ( rc ) > > + goto out; > > + > > + for ( i = 0; i < nr; i++ ) > > + { > > + const xen_cpuid_leaf_t *update = &leaves[i]; > > + > > + for ( j = 0; j < nr_leaves; j++ ) > > + if ( current[j].leaf == update->leaf && > > + current[j].subleaf == update->subleaf ) > > + { > > + /* > > + * NB: cannot use an assignation because of the const vs > > + * non-const difference. > > + */ > > + memcpy(¤t[j], update, sizeof(*update)); > > I'm having trouble understanding the comment. In > > current[j] = *update; > > the lvalue is xen_cpuid_leaf_t and the rvalue is const xen_cpuid_leaf_t. > That the usual (and permitted) arrangement afaics. I'm sure I was doing something really stupid, and as a bonus I failed to properly parse the error message I got from the compiler. It's now fixed here and below. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 31 12:50:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 12:50:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103928.198226 (Exim 4.92) (envelope-from ) id 1lRaJ4-0001gT-PQ; Wed, 31 Mar 2021 12:50:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103928.198226; Wed, 31 Mar 2021 12:50:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRaJ4-0001gM-MF; Wed, 31 Mar 2021 12:50:46 +0000 Received: by outflank-mailman (input) for mailman id 103928; Wed, 31 Mar 2021 12:50:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRaJ2-0001gH-Vo for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 12:50:45 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b0450925-8022-4edd-a324-9b5b7669f04e; Wed, 31 Mar 2021 12:50:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0450925-8022-4edd-a324-9b5b7669f04e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617195043; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=cPH+z4L6JW4hQ8Lz4x8+qyaHSCyBB2eOY8GQLgyvDWY=; b=dQCFjSAR1i5+IUccUO0TOkDTy3waRyfmHENIIyIXwDvdCDySDntMeG/U BIONFjgRgq3ZXpjBYSvhGyzdBE4hz/mYNeXpfjSeWJwPXhQKp0aDSINfC SIO/Tk9IWPO2r2PnIBcfRJIYEIoELDvWVbWQegMjtRTNKW0OWU+p2kKgJ Y=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: AegqovlZAbSJjAzXZgMB+bE6enBPSEm33OC70BL1ljUTW56JO+il4agfVB1Y/1ZRy18LW432sU w/lbFzTsL/Ng1S6ClzT7CHAqHw8zx1w/lbN4ma5jWoAT65ENXmako3QHI5QXWrHaOLKCngLIdm Y4gqdPdBqJs33W1UM/Aa14BxZpyhxiwbxJu0vl04iMAU2dSdsbGDqtUy5laEFsM5CQUt3K7b/c NjnZuJ/VwNXnrBm7YsQiin1/DlU6hOnnlCfg3PgxC8c3RfRz1U6DJysX/A4/vs7ZRIMs2+6wxB XoA= X-SBRS: 5.2 X-MesageID: 42006579 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:hLY8J6vqJ+MbOf5TaCtV9NYx7skCaYQji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOkOssFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmpM RdWoBEIpnLAVB+5Pyb3CCRGdwt2cTC1aiui/vXwXsFd3AVV4hJ8xp5BgGHEkd/WQlBAt4DGI CB49dc4xy6eXoWacy/b0N1LdTrjdvNiZ7gfFoiDxko9AGBgVqTmc/HOjKf2QoTVC4K/Kc6/Q H+4k3Ez4iAk9X+8B/T0GfP849b8eGL9vJvDNGB4/JlUAnEpR2vYO1aKtq/lRAz5Nqi8VM71O TLyi1QQPhbz1P0UiWLrQD22w/muQxeq0PK7VODm3PsrYjYaVsBerd8rLlUeBfY9EYs1esUuM gnsQPp0usyMTr6kC7w58fFWlVRr2XcmxUfuNUegHBFXYwVZKU5l/1iwGpvHIodByW/0Yg7EY BVfYXhzcxLelCXZW2xhBgX/PWQX28+FhrDYk8Ott396UksoFlFzlAVzMFao3EY9JhVceg928 34NM1T5ddzZ/5TR6RxCNoeR4+SBnbWSRzBEE/6GyWkKIg3f1jKppLL/rMN/+ehdIYTwJZaou WFbHpo8UIVQmryFNaP14FX/h3oTH+mVTrgo/suoKRRi/nSQqHmPjaET01ru8y8o+8HCsmeYP qrPolKasWTd1fGKMJn2RbzVIJVLmRbeMoJuswjU1bLmc7TLJb28tDdbe3OPqfgHF8fKy/CK0 pGeAK2CNRL70itVHO9qATNWn/rZ0z09Y9xFq+fxOQI1I0RLOR33jQ9uBCc3IWmODdCuqs5cA 9VO7X8iJ62omGw4CLh83hpEgA1NDcH3JzQF1dx4SMaOUL9drgO//+Ff3pJ4XeBLhhjC+vLDQ 9koUht867fFe3B+QkST/acdk6KhXoao3yHC70GnLeY2MvjcpQkSrk8XqhcEhjKCgxVlQ5mpH wrUn5XembvUhfVzYm1hp0dA+/SM/Nmhh2wHMJSoXXD8WWQzPtfGEczbnqLa4q6kAwuTz1bih la6KkEmoeNnj6pNC8ZjPknNkZPLECaGqhPAgjARIg8oMG1RChACUOxwRCKgRA6fWTns28IgH b6ECGScfbXRnxHun5Z1a7u2EhudnqUen9xbnwSi/wgKU32/lJIlcObbKu61GWcLnEYxPsGDT 3DaTwOZiV0x9620xaRsCueDnUs2ogjM9HQC7wlbpvU3XSgIpCJkq8nBpZvjcdYHeGrltVOff OUegeTIj+9Me8v1gCPjlsOOSV/qhAf4LjV8SygyFL98G80APLULlgjeqoSJMuE6XP4A9yS1o 9isN4zteysE2n4Z9Kc05vLZzpbJh67mx/0PrQVgKERmZh3mKp4HpHdXzeN6WpO2w8mKtzo0G kERr5g3bzHMohzXsAbdi5D5GA1j9SXNUcn2zaGRNMWTBUItTv7N8nMy6fUobAva3fx1DfYCB 26yWl68PjEVSfYiuJfJKI0PGhMaE8zrF5l5/iPcoXMCAOsM8FPlWDKRUOVQft4cuyiFroRpB ohvI3NsO+Taibi2Aff+RF8OblD9m67QcW0RCKAXddS7MbSAyXUvoKapOqIyArRZRT+QUICno FBfVEXda14+0ofpbxy9ii5UarspE0513NY/DF8j1bos7LWuFvzLAVjMQfDhI9RUiQWGn+Ujd 7d+ezd8Hjm+jBK1d3iE0hXF+s+QOQ4f8zSLy10L9IXs6Pt160zgj5baBNrK2Inkjjy06dH2r i+nNPIW+PjDn/sUGhxtAJtN8pRniYxr3tHfNX7xZWhYh8PHupNOsAB3Olt4XtUg2m2y10XdB N2sAM0kqnLM1z8Jnx5UZTogJDrmgUVqcG5mhdTjUQVvEimhlGas0XyhOCvtRMP3jDghx4irb /YSCo6gS5fuAIiyat9MmCVWWqpRX+eKlv4wKYhJHUNMxFh98w7yB7Ya6UbnJG3yGRp6SkhCi 8r2rexCyLRTy6RGdCYFkHlKP2lRNppJ/BWMS4fKnTzMhLOkJE5VAjJd9dszQ/EoAZHOYGefq e9JBuAB5wM9rEKM6PiQ4SCld7DvzIpg006vsb+kziZh/pk4sOQOx5kvd88e6ZvPB22/C0Q6K rkYSvfe44N4C/UqGT96SNXYN8Oqj5ltHUnmQ== X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="42006579" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A/HxBBWp8gfuPKYKiZsBwe+bG+r3JHZAu4dK3szzZxn94GTLPgCzpYLS+gZbuvJzP0IQ+8tEcDWRkk59FWM7MOdoYX1MCayJZTf306LkmbwOw967KYB6NLopvIeSVVapZ50KioHm3IeIZO51a95RvZ1HFlmq0o91vqJnBaizXxOmDE5JPmS/h1BNM6THhgVMXkNllfm7mxfK6EIJBvYvMJFqXw3BX1tCrWoa9EuL279MDxLOpFhHZyTQWd+UjvoRTUVxJzz5hFdpcvy4BuDIDwinrGwbjnV6Kb5QdJFnWWEZKW1T/zNEUmAgNfozKByetAnjeonPj7mpzBwAEat0CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IEvQ/Iptiq4A6duRyyG70TCDG33jMLzwaxZ+FKl4iQQ=; b=dEqGssWwGuD7JCWTXAUR/McHR+GlDY4SnbW6qIOnRZgzmQurq2Qg5hZQRHTCYMVUX9aMcPNRGZgDSPocgjVWNRHOVux+dl2IGmPreqRXT4fKzEBPr7wAM7RogbukeLjJWaNzoEMIujpPOXIRZ9yaiIuktxL8q9d5oAyXouSYmW768JUsd1gxuyiN8dHvPdmqx34kCoGrX3Dhx1amGTtf0kV9vZmioreP3Tr8PL0iDltgFf6ezijHB2DOWH20WRk0F9w4uLok8bcaRgRtTs5RYsqk8ht43gtGjro66VTbGm3DkI2+W9LPCFIQcgFGveU9OaRfxfL9jBvYI7T8XFnfFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IEvQ/Iptiq4A6duRyyG70TCDG33jMLzwaxZ+FKl4iQQ=; b=uuslX/I+bgCI9jzbuBrGIm64+7C2vlVq8VWezbYP6Tht77BgMpsdmWFuF8br2PTg/+VsFqOcvYo/OLtSpUE8REuGupmg1OiSUPWPR96nNjzjNTdFoCXCwy+/FsnhI9tf/V//puxlxPvxc22SSsGFgVp6knwoN3qjlUVaSO7vHh4= Date: Wed, 31 Mar 2021 14:50:35 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: , Jan Beulich , Wei Liu Subject: Re: [PATCH v3 03/11] x86/vlapic: introduce an EOI callback mechanism Message-ID: References: <20210331103303.79705-1-roger.pau@citrix.com> <20210331103303.79705-4-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AM7PR04CA0028.eurprd04.prod.outlook.com (2603:10a6:20b:110::38) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cd652ce9-4484-403a-3593-08d8f4439719 X-MS-TrafficTypeDiagnostic: DM5PR03MB2553: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +n7zB+KGbSzvPMumD6cv4R8ovkrMtrVmWqb+bGbU9IdisnflHq9T5jGObdywsgfFiuJmsG2+vDeFe75vaC9oiJb6VRfj3uukGpu1jQ//++AXu9RBE2gdVxhwDNLqvgjynA6wJ3fBm5bAiM7A89jYyIWTCFvRtouARAqlGg6aqYrYZUna15M+LPOtVKA4HNDxkoDoFkc1rsMJgCxiOnAcG1aJqnnnOuGrgYemHve8xzFWZIuEpLRviUD6G45f01nJNaRrI0qfU5v6vYkQk8bpeP6jMsZKrkgJ33FS/GObCXLOAkODlLFKnGTUFW5MQopwS2C++dlbMTJ7hHARLtBD1qZTmw/oI8rgOC9EfoTitZx1PJzB0/66vjU7KZsM+iCAnEff2zZDJiHC7ITb8syZa3NEVYSpki1iyaHJk/IR7Qm/Gpyt+RIjsPqqu1ytiuw/fdxJPIVK2pjVhxbEt6Aa16jocQgo6c66j0Esv2968dwQfoO3GveNdrD9lcFjfJnYt1Nvj+tdXspVCYQ/210QRSmHOLKS8apKyGf7DZ0FU8Gb4plrCXFyEGAqvCxpWPzFIqqPi0tgdQgGc7L5uyFQ+6EHb5H3x7XzzbwCV81LXZNSJD9NS+D2JdBkE2PdcD/qImELBcBstCW7LYdjzqWbCdOsB0l1zhWZlSZlV8XWxbnVx5a2F0MajRRtkkn2NdkO X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(346002)(376002)(39860400002)(366004)(396003)(136003)(8936002)(478600001)(6636002)(2906002)(66476007)(9686003)(54906003)(186003)(66946007)(316002)(956004)(66556008)(6496006)(26005)(16526019)(8676002)(86362001)(38100700001)(6666004)(33716001)(85182001)(6486002)(53546011)(5660300002)(6862004)(4326008)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?SW1vdHR1ZDFSdWRTUGhTeld2T0g3emdXc2NQMkZ0dysrQWpicHRrdjdiV2xh?= =?utf-8?B?MEdKaUlqRFMwdkYrR1o0NHJ0YXcrWjVLcXU1WEJva1BoUlZtbkNlejh4amZm?= =?utf-8?B?RmhpTVFHTlVtM1dtbXFwdXNtV2h4ZGlZcHBpb1lnNUU2ZWxWODlSVWFPV3dB?= =?utf-8?B?Wk1SK1dzV3pHNVJnWVVheWpQeWw3a0JHZlNUNFJkZDRWOUx0QUFDRy9DcmUw?= =?utf-8?B?OTR3UGlRaTlUN2VYVFJqSW0zcHZrc3k5elJMd1UrR2QzckVWVkxzNVp2TW9r?= =?utf-8?B?WXlRY2FXWXcwSUx2RFBtZWNBc0lqWXpIekVuY3UzQk1qaFVoVHdCUTlkQkQz?= =?utf-8?B?QU9vcTE0V0prVFgvVnlhVUUxNzhObDBYT05kT3FzaGJKbU5mc0o2c3hlSGdN?= =?utf-8?B?REZNSlNIdGNqZkM1ZzFLS0EybU9rZDRncitpS21YNjRJUmhmMU9COXY4ME1w?= =?utf-8?B?SFpzM1V6RVdmNmJkQ1hiWkhDMWM2K0NicFhoSEJYc1NUNHZYNzdhN0JwV2o1?= =?utf-8?B?T2swcWl4aDZBeDlwa2xtZHlVaUs0U1VMMWQ3dVZ0QXphbmRmd29jN3d1dlEv?= =?utf-8?B?S2RuZDZweFo0R0M0U1NrZENGT1pvZlFoNFV1UHdLQjdrN3gwSDNoUnlHWU01?= =?utf-8?B?MXNGVmwxVDZUQy9CeGZDYjdWb0xFdjlDMElBVE9QVENSUnVGQmJoTjVNYmdq?= =?utf-8?B?UFlwZ2REcjRxMUt1a2dKU3psLzlLSmp3NnZSU2NtN3NVMGpCWjFHeXJqYk14?= =?utf-8?B?Qm5iSGJGV1B5WUE4d2pqdTZLd25LWTRXN3d6OWJuamVSVEZIVW5wTUVDYUdE?= =?utf-8?B?SDcyNDNobTdvNFVhUVZkbnhYTERKTjk1L3k2ZVJmNEp2bUJLYlZ6SEl6Wk9a?= =?utf-8?B?Wng5R2NDQXV2ZUdtWk5MZlZWZkpIV0paZW9YNFJta21BS1lkZG50ZHJaSzZm?= =?utf-8?B?M2Rya0krNGhROWJ5ZllwK2JKTUdGZ0dJSCs0TW5HMm53Wi8rVXhNc2FyTzVy?= =?utf-8?B?SVI5RGJKMml5OExFZmJIVnFma0ZXYW5QNlBaUWM1dGY4V3VNRzRTNXhoUzB4?= =?utf-8?B?TzJ4K2c0dXMxUkljUWR2QXkweVF6ZEVMMWlxekFFK3RDK1phOVE4U0JzT1lq?= =?utf-8?B?ckN0R2VuaXBjN3N5N2hBSkV3ckVFL053YkZaYmVENWVSeGVuRlRZVjNRd054?= =?utf-8?B?Mkx3VXJ5ZFJLWmczdUQ0S0h6dmdpNDNTMHFXQnNuVHJYcndPclZ0cGZ2Ry9w?= =?utf-8?B?UTE3aFVsSVpiMEI2MDcrY0Z2Rnc5Rk5vTldNRFRLL2ZML085RjE5Z1RHamRk?= =?utf-8?B?YmhIM3dhVFY3azNhd3FONmF0Q3d4MjRPc0dXZ3g0R2VQcFZrL20zVGdGZldn?= =?utf-8?B?YW9NbmREVSt2YkhWTER0Uk0xS0FBa2EremRPN3B4azJwNitHZWlyYXNPWXZO?= =?utf-8?B?bnE3U2VQalFLcDhqaUNWRmRBdmRrcWtVVVVqaFQ2Y2psT3lXb01YOWlFanlv?= =?utf-8?B?bkhZbUNGZU5qVHcvR1ZmRmlYT0FIdVhycUJVelBUdWxTY3NsT2E4M2xiZGY5?= =?utf-8?B?OUlZZ2lGSlRpZ29USFFtUEhaQ2V3M2NHVlJoS0RYUjNPcmJQWWovMzhsQUFV?= =?utf-8?B?Q25HY3V0YmxZVmRkTDFYMVA4SnNRa25OK3RPV1FZMVZiQThXMHA2Y1EyNjh3?= =?utf-8?B?bkE5a3VMS3hQM3Z5OUtjS2NKT0lqVkkyVVQzYS9uZGJPSGpycDVjVXVFWmxO?= =?utf-8?B?aXI4QUZRRHJDV0dYTUZTanlTaGk1SFk3cXdWRm9XUnkxOU8vLzlHbXdJVTVs?= =?utf-8?B?cjJUUUJBeWlyMVd5T1JCdz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: cd652ce9-4484-403a-3593-08d8f4439719 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 12:50:40.8659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PffKy11Veq0P4ohPFmTsOZHu7I7IypNDmHV0rAsEsWCROZm9eg+fRz3m7RBTTrqjHzqAcc3IfGKR5ZBAowptLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2553 X-OriginatorOrg: citrix.com On Wed, Mar 31, 2021 at 12:47:54PM +0100, Andrew Cooper wrote: > On 31/03/2021 11:32, Roger Pau Monne wrote: > > @@ -1620,9 +1666,22 @@ int vlapic_init(struct vcpu *v) > > > > clear_page(vlapic->regs); > > > > + vlapic->callbacks = xmalloc_array(typeof(*vlapic->callbacks), > > + X86_NR_VECTORS - 16); > > + if ( !vlapic->callbacks ) > > + { > > + dprintk(XENLOG_ERR, "%pv: alloc vlapic callbacks error\n", v); > > + unmap_domain_page_global(vlapic->regs); > > + free_domheap_page(vlapic->regs_page); > > + return -ENOMEM; > > + } > > + memset(vlapic->callbacks, 0, > > + sizeof(*vlapic->callbacks) * (X86_NR_VECTORS - 16)); > > xzalloc_array() instead of memset().  Also, we shouldn't be printing for > -ENOMEM cases. > > As for the construction/teardown logic, vlapic_init()'s caller already > vlapic_destory().  Therefore, the existing error path you've copied is > buggy because it will cause a double-free if __map_domain_page_global() > fails. Right, let me adjust that path. > I'll do a cleanup patch to fix the idempotency, which needs backporting too. Ack, I don't mind doiing one myself either. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 31 13:31:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 13:31:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103934.198238 (Exim 4.92) (envelope-from ) id 1lRawa-0005G8-5o; Wed, 31 Mar 2021 13:31:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103934.198238; Wed, 31 Mar 2021 13:31:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRawa-0005G1-2c; Wed, 31 Mar 2021 13:31:36 +0000 Received: by outflank-mailman (input) for mailman id 103934; Wed, 31 Mar 2021 13:31:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRawZ-0005Fw-CA for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 13:31:35 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3095be06-eed8-4026-91ac-995961179144; Wed, 31 Mar 2021 13:31:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3095be06-eed8-4026-91ac-995961179144 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617197494; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ot73H2SYgwn2CXG9cPZvDv1IaaQ5xrxU54n7naXPgr0=; b=P9iL5ocvp1wFzdVOPLktp9uUabmDpbl+9O3vxsd70G5RvivBnuJ6saqC iE73BFMjPZpJWmGhF6oeQ1nG18Z1PHA3YQXF2nhUx0uK4H6qNEXsoBLso X6SupsTJataOsPxtrInV+Rv35/3uCBzBEFLw8U2vg3nYcdLX7nRAstv3x 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: J4ijsB0nSleINzq/D3PSRBUORAKA4YgMG8kNvkGZoU7lW66Qk7HuuXtDccpSpufh87+EL4wuem 72qqt7rN9wZKVDJ8CtgvCjvt5fijUEoJ5+GSRXiC1X/FcVGkHHeE1vNuBY0qbWjf/I09rU0PlQ WdSy4fMAfnVjONnbqQNK1VsdXtfIwmCkvWG3rKJkWTEXbZBZNirjPO8NtYTsaVu0RV2wae/1Zp rRsRMhYqyLh1vE+vVPk0K+JhD4LJhX6zBcc5uhLA5Sj+hi5fYkKGj9XjIxVzv4cSyz05C/OR7P 3Ik= X-SBRS: 5.1 X-MesageID: 40432767 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Q9VhAakruDqz3bIrFSI6+vsCKALpDfLI3DAbvn1ZSRFFG/Gwve rGppom/DXzjyscX2xlpMuJP7OOTWiZ2Zl+54QQOrnKZniAhEKDKoZ+4Yz+hwDxAiGWzJ846Y 5Me7VzYeeRMXFUlsD/iTPVL/8F4P2qtJ+lnv3fyXAFd3AOV4hF4x1iAgiWVm1aLTM2ZqYRL5 aX6spZqzfIQx1+Ba7XOlA/U/XevNqOrZr6YHc9dngawTOThjCl4qOSKXml9yoZOgkh/Z4StU zMkwn0/cyYwpOG9iM= X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40432767" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/hvm: Fix double free from vlapic_init() early error path Date: Wed, 31 Mar 2021 14:31:25 +0100 Message-ID: <20210331133125.7072-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit vlapic_init()'s caller calls vlapic_destroy() on error. Therefore, the error path from __map_domain_page_global() failing would doubly free vlapic->regs_page. Rework vlapic_destroy() to be properly idempotent, introducing the necessary UNMAP_DOMAIN_PAGE_GLOBAL() and FREE_DOMHEAP_PAGE() wrappers. Rearrange vlapic_init() to group all trivial initialisation, and leave all cleanup to the caller, in line with our longer term plans. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/hvm/vlapic.c | 11 ++++------- xen/include/xen/domain_page.h | 5 +++++ xen/include/xen/mm.h | 6 ++++++ 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index 5e21fb4937..da030f41b5 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -1608,7 +1608,9 @@ int vlapic_init(struct vcpu *v) return 0; } + /* Trivial init. */ vlapic->pt.source = PTSRC_lapic; + spin_lock_init(&vlapic->esr_lock); vlapic->regs_page = alloc_domheap_page(v->domain, MEMF_no_owner); if ( !vlapic->regs_page ) @@ -1616,17 +1618,12 @@ int vlapic_init(struct vcpu *v) vlapic->regs = __map_domain_page_global(vlapic->regs_page); if ( vlapic->regs == NULL ) - { - free_domheap_page(vlapic->regs_page); return -ENOMEM; - } clear_page(vlapic->regs); vlapic_reset(vlapic); - spin_lock_init(&vlapic->esr_lock); - tasklet_init(&vlapic->init_sipi.tasklet, vlapic_init_sipi_action, v); if ( v->vcpu_id == 0 ) @@ -1645,8 +1642,8 @@ void vlapic_destroy(struct vcpu *v) tasklet_kill(&vlapic->init_sipi.tasklet); TRACE_0D(TRC_HVM_EMUL_LAPIC_STOP_TIMER); destroy_periodic_time(&vlapic->pt); - unmap_domain_page_global(vlapic->regs); - free_domheap_page(vlapic->regs_page); + UNMAP_DOMAIN_PAGE_GLOBAL(vlapic->regs); + FREE_DOMHEAP_PAGE(vlapic->regs_page); } /* diff --git a/xen/include/xen/domain_page.h b/xen/include/xen/domain_page.h index a182d33b67..0cb7f2aad3 100644 --- a/xen/include/xen/domain_page.h +++ b/xen/include/xen/domain_page.h @@ -77,4 +77,9 @@ static inline void unmap_domain_page_global(const void *va) {}; (p) = NULL; \ } while ( false ) +#define UNMAP_DOMAIN_PAGE_GLOBAL(p) do { \ + unmap_domain_page_global(p); \ + (p) = NULL; \ +} while ( false ) + #endif /* __XEN_DOMAIN_PAGE_H__ */ diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 667f9dac83..c274e2eac4 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -85,6 +85,12 @@ bool scrub_free_pages(void); } while ( false ) #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) +#define FREE_DOMHEAP_PAGES(p, o) do { \ + free_domheap_pages(p, o); \ + (p) = NULL; \ +} while ( false ) +#define FREE_DOMHEAP_PAGE(p) FREE_DOMHEAP_PAGES(p, 0) + /* Map machine page range in Xen virtual address space. */ int map_pages_to_xen( unsigned long virt, -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Mar 31 13:50:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 13:50:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103939.198250 (Exim 4.92) (envelope-from ) id 1lRbEd-00070e-Nf; Wed, 31 Mar 2021 13:50:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103939.198250; Wed, 31 Mar 2021 13:50:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbEd-00070X-KZ; Wed, 31 Mar 2021 13:50:15 +0000 Received: by outflank-mailman (input) for mailman id 103939; Wed, 31 Mar 2021 13:50:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbEb-00070O-HL for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 13:50:13 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7e49a467-769a-4560-aa83-6a63cde9f177; Wed, 31 Mar 2021 13:50:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e49a467-769a-4560-aa83-6a63cde9f177 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617198612; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=GBcDTyXDl6vJWzMqs1SDGZ5+h/l8kz0WByxPdxVwATk=; b=ZyMIker8qQSsFTeYpY2Lj70Emnh6SuxDPoI625HHws8le8AVzV18T2/k fCgsN2GsfLJgfNz2iWeZZeol94Vw01NbRuaA8H9B5LB4AKnjh5ZHUx7yu xLPGMkVzY2G6qfbVFlUvzSib539RGZOtPVS16x004aR7hHkIBH6Cl5j5p s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: HV0IjXBGr/d1OLwwNRvmVtYVAonN8FeR14k85zfUCxCzq21TNtMQI99ucU7jlaR9n8Y7xPv4lL BMOL0f8cKKytzYTwY0SVkRZds18X0G4xDrsWVAgyGZSGj0h8vdXlU/E8mhBNXqMu9HlPql1VZl pdRP35C/POtgZOTyx/hmZ+F8ayCh+ZybfKzsYsg9p+QSUex8Jtt4G3Q13H6rtpYBAtM5/pONia 66YHnSj8IyDZsCLb8EmcH46JlleGU3mPNw7RuJyc3d/v5W9FzlJLYBwcTUpkn4wqiD/y/ZAvf8 +i4= X-SBRS: 5.2 X-MesageID: 40937233 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:nMx2A6rV4+VADvpk0XoSEWQaV5vYL9V00zAX/kB9WHVpW+SFis Gjm+ka3xfoiDAXHEotg8yEJbPoex7h3LR+iLNwAZ6JWg76tGy0aLxz9IeK+UyHJwTS1M54kZ 1hfa93FcHqATFB5/rSzQGkH78br+Wv37uvgY7loUtFbQYvUK146hc8NwDzKDwVeCBjJb4UUK WR/dBGoT3IQwVxUu2eCmMeV+bO4/3n/aiWAiIuPBIs5AmQgT7A0teTfySw5RsQXyhCxr0v6w H+4mnEz56uru2hzVvk33LThq48pPLa1tBBCMaQ4/JlTgnEtwDAXuVccozHhh8ZiqWF6FEmkN 7Dyi1QQPhb2jfqUUye5Tfo0wnk+j4y53Hl0k/wuwqcneXJAAgUJuAEqYVFcgbIy0dIhqAM7I t7m1i3mrASLRTckD/z79LFPisa5nackD4ZvsM4y1l8OLFuEYN5nMgk025+VKokJmbc7rsqFe F/Zfusmcp+QBehQF3y+lV0zMfEZAVKIj62BnIsl+ayyDZskHVw3yIjtbAit0ZFzp47RpVejt 60SZhApfVLRs8SW6p3GP0Md8uxEnDMWhLBKgupUC7aKJ0= X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40937233" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b7UVQxYi4YlDsDZB+JsLdUBY4byFQZiqavQdqf8UTpBy446TP6FtjROUmHP0z19nWEYhqQ9MpnMVxG6NRK3/Y7pYd+2whTVjk75hTDsBvwXsmKlGXcR7ln3AgLuooy0J7u35r3UYpHFuZABeMyMRTh7BXnXZ/mlNz3eci+2F1jl7DHvuL5UnTtPTDtqWRTsUoN6a6fuhehcBfxdLkaclpkh2yVAMvRlZ9CJCYQVziZ7+z5/oWAJbJoie1lsZPXdnSPwItrEwUn8zO7f3VY01KP++1rF6fhVQwD0RKsaXZOWsT7samHR/53yyoCib6WKMFT33jhFxBxGePrXMnhEVpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FZNS2mJd/FbJHrnS83x1Zr1zbQob3rCmLpZKA1B+rEw=; b=OYzqh5l9sRs9XoIHnw+vFpJJqHXuGhl70Fd13uSx9CUuKr803Ks8ucvGqtrvEX9KkZxcf9F77qo63lJuOGB2mX9a/zOz5DwM3SM6sBcmE0neXXdVMNGVceVTChLIk1n4MxzP+gHrxp6Fyp8eqU1VO+En3wawuO+n5PrfOSAIBZjpTE0c9/tMs+C7t6x2UtFb4vYHIFLciT1csIvQkHctdVvoqis6Ms0T2d12cxC/8KJ1FkMa7J1xHkdmvqrO1F/kmqcB8nftRRkMDTxpyvMKLqHj1WO+SiN3dcC/HpuLJ8mCEbjMZphyLhDVhkO0tmtb+AtIdAX5JOVQR5jLQnhFig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FZNS2mJd/FbJHrnS83x1Zr1zbQob3rCmLpZKA1B+rEw=; b=jmVyXCsosN5BdnBdm2YPVI+Fe3KOVLgW2+9HeCyNe1a0rWatSwzPFUaUCwGDvyuj+KInWfOoABftPjlhKwDoLzsnglTjXkKiOzf0pkwDa/UT0T6H1BNiLfSdxD98OI6CT0RPfEt9Q01FEcVW5/23dREYaTKoNnoIbpOqgIKyH6E= Date: Wed, 31 Mar 2021 15:49:46 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Xen-devel , Jan Beulich , Wei Liu Subject: Re: [PATCH] x86/hvm: Fix double free from vlapic_init() early error path Message-ID: References: <20210331133125.7072-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210331133125.7072-1-andrew.cooper3@citrix.com> X-ClientProxiedBy: AM5PR0101CA0012.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::25) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1e5ec91b-6c22-4469-1372-08d8f44bdc57 X-MS-TrafficTypeDiagnostic: DM6PR03MB4844: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1002; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N5zvz9ECeOa1RgslGhDsGGi8EfT3mqdvjm6n8FMQQrzIt8QlswCmbvFX2RoFSebpLYzpPzLjdOBFBJ8fKtVNtzojUzF8nKUhITBN33gjvD0K0j+0Zlir4EoYeFJhukDeq7N078nfvmeaQqU9BCSqx7PQQnNfNAGr+UH03eB+hNYSB5QR7SWEQCX0GrPYXj4W0c+m99xqXEnjePDjoIHvH1ujMnHC4IdITbAY1vFoZ23GF4ta+eiONiUAVZmuUfkK57B58cwmRr3KI6Hio8XjDOfnIL1V/ynay/T49lHL+Ya/M0Tz/8CIFl/KvoALop19d93T0XZKtmP02o7I1zIcgP9olTuObOuFOq4Vdsmxi7eGgFMXtH4XRbaHpKVWZ/Vrf6C3S1o3HTih2tf8vijxuUDZO4aTENw7sXtMISTx9BOVL+gMpkf0sVHtfAFJuke30E3i96uv5rfe8E1qFLpxKwRa6IHMB5PIOP8QMAiqU8Mbh3Ttx1hyYk28IvXGeDN6quDvH2Nd9LNI0St7gJ+QiDHILfbxuQ10CZqgJaufO3lVz360tyAAeA+OjAJWiqZuQK511XudRNVEZIzjy+9mBN/sE0rFC9MF1ZauYji/UgCxcCngZTxcYLNBygi87pQAoaFEp9uIL5Y7rGdB603md1G2lmjZJve3RxT797QAcKlvSHBtKjFH6C3bnT8N+DjM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(346002)(396003)(376002)(136003)(39860400002)(66476007)(478600001)(66946007)(83380400001)(16526019)(186003)(956004)(6636002)(6666004)(9686003)(85182001)(316002)(54906003)(6496006)(66556008)(6486002)(4326008)(8936002)(8676002)(5660300002)(6862004)(38100700001)(2906002)(33716001)(26005)(86362001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Z1FXUk94dW1uSGMrQkh3Y3h5Umh4akYrZzNXU3A5MUNqSW04b2tjaElSc2FW?= =?utf-8?B?QXdZRXVQZnBCbUIycmpLWWhWaXdsMEdLTG5odjA2NExPOEhycFc2VzhsVUM1?= =?utf-8?B?bGdJNHVqTUxOOFB4Z2NHYnFFRXVkSGs0UFNTWXNtdFE0YThzSkZNNDJDay9W?= =?utf-8?B?eGJhSFRFWSt2M084Yk1qTSs4RGlxMnVkeWhVNnYveEY4NXpMb3lRV0FnQTNB?= =?utf-8?B?eHd3VWkvcFQrcGJsOUpPRXVCL2RjWUNkUGpvNzhkamJvaU11N1FaTEF3akhT?= =?utf-8?B?T1ZLcXFUMVpCd0MvZ1VnTll2QzBLK25Hb2t4M2duZE03Q2UzcXhQbVNGUmd1?= =?utf-8?B?aFNrR1ZSanBqNTVOdkpSdVFzVlRyK0VwOEtSOGI0bHpUMSttdWhLZ2w5aFZU?= =?utf-8?B?bXRqa2VFVGdsbWxmZDZ5YUxZMDYvRVJMU3hqNTRhMlB6TTdCcm94WnhlUlhM?= =?utf-8?B?THpBcVN0Y1hIRmZPU2ZlNUhURGVRczhIQ0FDNXhLVlJHVEVSOXVyVDRJUGpn?= =?utf-8?B?ZXg2S3lodDJZU0dldUI5YmZEcmtKenZGdWtSc0dSNE9FQXAxZU1tdzVOUDJB?= =?utf-8?B?WERhZVdrekV2RDlBNndlU013dm5iYzh4bzVHVFptL1FCcU9iL3ZaZjl0Z04v?= =?utf-8?B?c0x5VWxhVnBWelk5NnpyQXVQY1pQZGZZM3B1dTV1SzNqUHlidTArV0FWSkx4?= =?utf-8?B?eTRHZlBPcDdob1lWUlZWK2F5RzIwRGlXWUdSMm9aL1NIYTJVMWRROHJaaXVH?= =?utf-8?B?V2swZ2VkV281ZkdZQy8yYjFJL1gyNHkrM0dPYXBwQ1lqNERpaEdnNFhLU0xK?= =?utf-8?B?RlVyeStBdmpSOXc3YmxhbEdZUTdyUVNjRE1iaWlUd21xUnVObmtKakpHNk5F?= =?utf-8?B?SEhRdmlxUEJSbURuejgwb3VSaUdUYjFsb20xUXNPR29HeDFudWY0clJxeENU?= =?utf-8?B?S3F2M2VJTkNyNk5hd28vVFJta1VOODBQWG5ZWlNOTmJWaHRoRkRRUXVQOEdS?= =?utf-8?B?aU5wQlpKVFBzS3dyZm03VVhjYnJWRlJhUHJROTdPamprM1RCVkI4ODNpZnVt?= =?utf-8?B?SUppUlpMenpVQ213TlA5QWUxaS80ajVPZUcvTU40WW9md01qcjYxVXg3UGxU?= =?utf-8?B?QXZHQUlOcXQzTU1RYy9QNXpCQ0FtdWxOSjY2VjNrRU41Qk10QkZvY3V2UlZO?= =?utf-8?B?RXlGUjlpV3VYbFdtbjBFdFp1MTkwdXF5MUEzcG5abExnTTR4cVZqNVcwNXc2?= =?utf-8?B?ZE02MkFWUVZMeGZHbDkxVmV5dkxUVzU2alY3TUJ6ZjhXWEVtcVZYV2h6aUl3?= =?utf-8?B?bCtIVkt0aWtOOG1YOElVT1M3UXFSV3dqK0FGVUl1QXFPck1TZmFMbkR0U2Nq?= =?utf-8?B?Sy9zYTJKT0NSVFBia0lmbWNIRkhSNlNkZEdnWlEySHZjbGR3cnlWb1diQlB6?= =?utf-8?B?TjRkaXFJTGlOMERrdDdwZTVBemMyWTJyOXNYVGhaV0tHbGdsQmJlaWxxZEhv?= =?utf-8?B?bDd6cEdmVXREVldVZ0sweWp6MnhoZlFuSG5xdlNhQ1c1S2pMQ2xvVFM1R2Y4?= =?utf-8?B?NUJPSk5pazd1L3lmY0hYOFhDdWFYVm0zK2xiMHZLTWprSHdzV0gxSFBQZU5D?= =?utf-8?B?Ynh3L2FNVFQ2cGxhUzJJOHZ0bkM0MEh2L2g3WUpIV0dHQ01BN0hIWGhOc2Fa?= =?utf-8?B?TnpIM2dURjZtM0VPbU5lTWhBSHYrK3Vmdit5Y0NjdTA3eFkzUVQ5UGtXUmR2?= =?utf-8?B?a0N3ZzRCckRLdjBYUVhCRldweGx6Ym1pWDl1bGhLV043Z1laSlBEakFXcWtP?= =?utf-8?B?N0VSczAveGFRczg4ODZ6UT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1e5ec91b-6c22-4469-1372-08d8f44bdc57 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 13:49:53.3206 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5OB7aVNmnopsIwME5UQRkaqALe7mnhGRNipz8nk8JZM9W3SAyqUbQsm5iT2cZ6NFdk0XgBdtIA+2sraXGJysEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4844 X-OriginatorOrg: citrix.com On Wed, Mar 31, 2021 at 02:31:25PM +0100, Andrew Cooper wrote: > vlapic_init()'s caller calls vlapic_destroy() on error. Therefore, the error > path from __map_domain_page_global() failing would doubly free > vlapic->regs_page. > > Rework vlapic_destroy() to be properly idempotent, introducing the necessary > UNMAP_DOMAIN_PAGE_GLOBAL() and FREE_DOMHEAP_PAGE() wrappers. > > Rearrange vlapic_init() to group all trivial initialisation, and leave all > cleanup to the caller, in line with our longer term plans. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > --- > xen/arch/x86/hvm/vlapic.c | 11 ++++------- > xen/include/xen/domain_page.h | 5 +++++ > xen/include/xen/mm.h | 6 ++++++ > 3 files changed, 15 insertions(+), 7 deletions(-) > > diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c > index 5e21fb4937..da030f41b5 100644 > --- a/xen/arch/x86/hvm/vlapic.c > +++ b/xen/arch/x86/hvm/vlapic.c > @@ -1608,7 +1608,9 @@ int vlapic_init(struct vcpu *v) > return 0; > } > > + /* Trivial init. */ > vlapic->pt.source = PTSRC_lapic; > + spin_lock_init(&vlapic->esr_lock); > > vlapic->regs_page = alloc_domheap_page(v->domain, MEMF_no_owner); > if ( !vlapic->regs_page ) > @@ -1616,17 +1618,12 @@ int vlapic_init(struct vcpu *v) > > vlapic->regs = __map_domain_page_global(vlapic->regs_page); > if ( vlapic->regs == NULL ) > - { > - free_domheap_page(vlapic->regs_page); > return -ENOMEM; > - } > > clear_page(vlapic->regs); > > vlapic_reset(vlapic); > > - spin_lock_init(&vlapic->esr_lock); > - > tasklet_init(&vlapic->init_sipi.tasklet, vlapic_init_sipi_action, v); > > if ( v->vcpu_id == 0 ) > @@ -1645,8 +1642,8 @@ void vlapic_destroy(struct vcpu *v) > tasklet_kill(&vlapic->init_sipi.tasklet); > TRACE_0D(TRC_HVM_EMUL_LAPIC_STOP_TIMER); > destroy_periodic_time(&vlapic->pt); > - unmap_domain_page_global(vlapic->regs); > - free_domheap_page(vlapic->regs_page); > + UNMAP_DOMAIN_PAGE_GLOBAL(vlapic->regs); I think you need to check whether vlapic->regs_page is NULL here... > + FREE_DOMHEAP_PAGE(vlapic->regs_page); > } > > /* > diff --git a/xen/include/xen/domain_page.h b/xen/include/xen/domain_page.h > index a182d33b67..0cb7f2aad3 100644 > --- a/xen/include/xen/domain_page.h > +++ b/xen/include/xen/domain_page.h > @@ -77,4 +77,9 @@ static inline void unmap_domain_page_global(const void *va) {}; > (p) = NULL; \ > } while ( false ) > > +#define UNMAP_DOMAIN_PAGE_GLOBAL(p) do { \ > + unmap_domain_page_global(p); \ > + (p) = NULL; \ > +} while ( false ) > + > #endif /* __XEN_DOMAIN_PAGE_H__ */ > diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h > index 667f9dac83..c274e2eac4 100644 > --- a/xen/include/xen/mm.h > +++ b/xen/include/xen/mm.h > @@ -85,6 +85,12 @@ bool scrub_free_pages(void); > } while ( false ) > #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) > > +#define FREE_DOMHEAP_PAGES(p, o) do { \ > + free_domheap_pages(p, o); \ ...as both unmap_domain_page_global and free_domheap_pages don't support being passed a NULL pointer. Passing such NULL pointer will result in unmap_domain_page_global hitting an assert AFAICT, and free_domheap_pages will try to use page_get_owner(NULL). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 31 13:52:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 13:52:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103942.198262 (Exim 4.92) (envelope-from ) id 1lRbGl-00079y-4j; Wed, 31 Mar 2021 13:52:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103942.198262; Wed, 31 Mar 2021 13:52:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbGl-00079r-12; Wed, 31 Mar 2021 13:52:27 +0000 Received: by outflank-mailman (input) for mailman id 103942; Wed, 31 Mar 2021 13:52:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbGj-00079l-5Y for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 13:52:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbGj-0003Yp-1M for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 13:52:25 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lRbGj-0002ep-09 for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 13:52:25 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lRbGa-0007pR-QH; Wed, 31 Mar 2021 14:52:16 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=ha601ufuWA3gjkFhjVblxHpt8Fuyb01LY639RGVAdHI=; b=eSzt8KaeJ8dA/cN+bXii6QYhGq wWkLjeqJVn5kYm0MPHBMUVsWN8729+a0ccgzyyJ55B2qdDnkK5S085vqAlSwzMNhLXwKN4X//EuUH 8lTw8HjdHq2nbSlGv+OK7aNsC26dAFX5qZr1tZ7K5rQeTrme5dq3wbnstHP+3CmnfE+c=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <24676.32400.548088.26254@mariner.uk.xensource.com> Date: Wed, 31 Mar 2021 14:52:16 +0100 To: George Dunlap Cc: Andrew Cooper , Jan Beulich , Roger Pau Monne , "xen-devel\@lists.xenproject.org" , Paul Durrant Subject: Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code In-Reply-To: <2A1FCD39-D0C0-468D-A977-2FBF7126FDE6@citrix.com> References: <20210324172608.302316-1-george.dunlap@citrix.com> <23461afc-c0e0-eb33-9ed3-52f050b6aef0@suse.com> <27ecde00-f0aa-b701-6928-5480ed805064@citrix.com> <2A1FCD39-D0C0-468D-A977-2FBF7126FDE6@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) George Dunlap writes ("Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code"): > I don’t understand why the two of you are downplaying your work so much. Yes, these are all only incremental improvements; but they are improvements; and the cumulative effect of loads of incremental improvements can be significant. Communicating to people just what the nature of all these incremental improvements are is important. I agree with George here. There ae a number of reasons why behind-the-scenes work with little (intentional) user-visible impact are useful to note in the CHANGELOG.md. With my Release Manager hat on I would like to see, for example, >> + - Factored out HVM-specific shadow code, allowing PV shim to be slimmer something about htis work in the CHANGELOG.md. IDK precisely, and I don't think George does either, what a good and accurate statement is. But I guess we will go with the text above if we don't get something better. George, were there other changelog items that were subject to a a similar question ? I don't find them in my email with a quick look but I suspect I have missed one or two ? Thanks, Ian, From xen-devel-bounces@lists.xenproject.org Wed Mar 31 13:52:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 13:52:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103943.198274 (Exim 4.92) (envelope-from ) id 1lRbH2-0007E8-DN; Wed, 31 Mar 2021 13:52:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103943.198274; Wed, 31 Mar 2021 13:52:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbH2-0007Dz-9g; Wed, 31 Mar 2021 13:52:44 +0000 Received: by outflank-mailman (input) for mailman id 103943; Wed, 31 Mar 2021 13:52:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbH1-0007Dq-9A for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 13:52:43 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d24f7b25-4a52-4318-a3fc-ea577d4bd3cf; Wed, 31 Mar 2021 13:52:42 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 662F2B288; Wed, 31 Mar 2021 13:52:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d24f7b25-4a52-4318-a3fc-ea577d4bd3cf X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617198761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yKknCWV6+9pJC7xqpVlz2vjQm1QbRp0EQF62y/4fyuw=; b=JJMUgnCENn62x+WwJQ57GVFhsFzqtthfcoo3BqPj8emLHIzwLHzs0I1u+V0SIWy3BtTgH3 0+uG05wuudRUClA5x2knRiqFU7z9gaE/wunXLqxlS3KPTJg9R/IhdQjjWsirTpmH0+TCX6 jOqhbms24jzBkPk2swGenWbZRkw8/OE= Subject: Re: [PATCH] x86/hvm: Fix double free from vlapic_init() early error path To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Xen-devel , Wei Liu , Andrew Cooper References: <20210331133125.7072-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <4679a1fb-2935-1cda-acb6-429e783248d4@suse.com> Date: Wed, 31 Mar 2021 15:52:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 31.03.2021 15:49, Roger Pau Monné wrote: > On Wed, Mar 31, 2021 at 02:31:25PM +0100, Andrew Cooper wrote: >> @@ -1645,8 +1642,8 @@ void vlapic_destroy(struct vcpu *v) >> tasklet_kill(&vlapic->init_sipi.tasklet); >> TRACE_0D(TRC_HVM_EMUL_LAPIC_STOP_TIMER); >> destroy_periodic_time(&vlapic->pt); >> - unmap_domain_page_global(vlapic->regs); >> - free_domheap_page(vlapic->regs_page); >> + UNMAP_DOMAIN_PAGE_GLOBAL(vlapic->regs); > > I think you need to check whether vlapic->regs_page is NULL here... > >> + FREE_DOMHEAP_PAGE(vlapic->regs_page); >> } >> >> /* >> diff --git a/xen/include/xen/domain_page.h b/xen/include/xen/domain_page.h >> index a182d33b67..0cb7f2aad3 100644 >> --- a/xen/include/xen/domain_page.h >> +++ b/xen/include/xen/domain_page.h >> @@ -77,4 +77,9 @@ static inline void unmap_domain_page_global(const void *va) {}; >> (p) = NULL; \ >> } while ( false ) >> >> +#define UNMAP_DOMAIN_PAGE_GLOBAL(p) do { \ >> + unmap_domain_page_global(p); \ >> + (p) = NULL; \ >> +} while ( false ) >> + >> #endif /* __XEN_DOMAIN_PAGE_H__ */ >> diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h >> index 667f9dac83..c274e2eac4 100644 >> --- a/xen/include/xen/mm.h >> +++ b/xen/include/xen/mm.h >> @@ -85,6 +85,12 @@ bool scrub_free_pages(void); >> } while ( false ) >> #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) >> >> +#define FREE_DOMHEAP_PAGES(p, o) do { \ >> + free_domheap_pages(p, o); \ > > ...as both unmap_domain_page_global and free_domheap_pages don't > support being passed a NULL pointer. Except that such checking would better go into the new macros, alongside their clearing the pointers afterwards. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 31 13:54:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 13:54:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103948.198286 (Exim 4.92) (envelope-from ) id 1lRbIV-0007Nt-OU; Wed, 31 Mar 2021 13:54:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103948.198286; Wed, 31 Mar 2021 13:54:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbIV-0007Nm-LT; Wed, 31 Mar 2021 13:54:15 +0000 Received: by outflank-mailman (input) for mailman id 103948; Wed, 31 Mar 2021 13:54:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbIV-0007Nh-2A for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 13:54:15 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fdb6cf07-7cd8-4f8e-a4c3-34259fd0586d; Wed, 31 Mar 2021 13:54:14 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 72EDFB270; Wed, 31 Mar 2021 13:54:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdb6cf07-7cd8-4f8e-a4c3-34259fd0586d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617198853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N/UHw2rhp5oWwtg8Oo0kCiW/jQ/cE+RiYjb15XuDshc=; b=iWi/y77kMUsJnmSSRt8aKO/1roG9Z6LyfaN9yDAC3uwMPAowmJsp2P0GjNl4iGxhsJ+cHw KqHGyfeD2Bp4N0tWOf0QBoDWab6zv6s5nes3xAeXpga7xjHtie90rVxG0NEXa9u9ewIXH4 pNyuJRYrEgqZaW3zdvCKVHR9xR7Vrps= Subject: Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code To: Ian Jackson , George Dunlap Cc: Andrew Cooper , Roger Pau Monne , "xen-devel@lists.xenproject.org" , Paul Durrant References: <20210324172608.302316-1-george.dunlap@citrix.com> <23461afc-c0e0-eb33-9ed3-52f050b6aef0@suse.com> <27ecde00-f0aa-b701-6928-5480ed805064@citrix.com> <2A1FCD39-D0C0-468D-A977-2FBF7126FDE6@citrix.com> <24676.32400.548088.26254@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <1a87cfa9-d6c0-5da5-ea07-eae47186da9a@suse.com> Date: Wed, 31 Mar 2021 15:54:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <24676.32400.548088.26254@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 31.03.2021 15:52, Ian Jackson wrote: > George Dunlap writes ("Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code"): >> I don’t understand why the two of you are downplaying your work so much. Yes, these are all only incremental improvements; but they are improvements; and the cumulative effect of loads of incremental improvements can be significant. Communicating to people just what the nature of all these incremental improvements are is important. > > I agree with George here. > > There ae a number of reasons why behind-the-scenes work with little > (intentional) user-visible impact are useful to note in the > CHANGELOG.md. With my Release Manager hat on I would like to see, for > example, > >>> + - Factored out HVM-specific shadow code, allowing PV shim to be slimmer > > something about htis work in the CHANGELOG.md. > > IDK precisely, and I don't think George does either, what a good and > accurate statement is. But I guess we will go with the text above if > we don't get something better. At the very least the part after the comma ought to be deleted. As said in an earlier reply, at least the shim default config disables shadow code anyway, so the factoring out has no effect there. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 31 13:56:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 13:56:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103954.198297 (Exim 4.92) (envelope-from ) id 1lRbKo-0007Yi-9n; Wed, 31 Mar 2021 13:56:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103954.198297; Wed, 31 Mar 2021 13:56:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbKo-0007Yb-6d; Wed, 31 Mar 2021 13:56:38 +0000 Received: by outflank-mailman (input) for mailman id 103954; Wed, 31 Mar 2021 13:56:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbKn-0007YU-Bp for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 13:56:37 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dcb9a66b-a4d8-4326-911b-2d06714c35be; Wed, 31 Mar 2021 13:56:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dcb9a66b-a4d8-4326-911b-2d06714c35be DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617198995; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=QsiMGCjk1tUOfxzyy6Ii5flqHKDUhozwglNv6/tNNMA=; b=UY4KLntc+Eob65iKnOUQObInsVR5kbQoQ6o4dGxQcMG2vznaUfPOs9vQ 1bclsd93nfkjCbxlz9iCxTJ3pYX+/awe6doT0Zxlbzio0mUjUD2b8qvel U06X2ZStGKIcSaXbfzfpnljR0bpzh+LagP4xjPid2d7AukJEhG6+6HGSj Q=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: h9pEeLFlNb3mEf+YQ8gWz5jo2vIN9b9Zd1mhpxpf19m6DJ8DG2dHteDHZ1jn1KpExbOKLhzo6q PXBQwncgX6pGAB1y1vmwbAwecXNXoQovWIkhF6K1Y651GUcdBNil2NmLrJH6TL15qa5Lb4lIvq rkH13SnZ43mtAbfnLGxeDYK0GgVKqweHkRxe9VuWx/6Y9maOspEmdbBsj/PMAL0e2ilMykQ6b2 f75l4U1zwUnPQerVITvd1KIHgLvQy15JsMRpRdZu4hBrsMYN6tUIUOeGkoUHMX+Rs1BnAjqTrC jw4= X-SBRS: 5.2 X-MesageID: 40564465 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:cJ+SzqhhC8xLvQNYl/VEdMqhrHBQX5tx3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2/hzAZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 ddWoBEIpnLAVB+5Pya3CCRGdwt2cTC1aiui/vXwXsFd3AUV4hL6QBlBgGHVmh/QwdbDZQ0fa DsmPZvjTymZHgRc4CHFmAINtKz6eHjubDHRVo9BxAh4BSTlj/A0tTHOjWRwxt2aUI1/Z4M6m 7A+jaJgpmLk/b+8RPE0n+W0pI+oqqc9vJmJOihzvcYMS/tjAHAXvUhZ5SnsCouqO+irHYG+e O82SsIBMh453PPcmzdm3KEsGSNv1heiQ6G9XaijXTuusD/Tj4hYvAx+L5xSAfT6EYrobhHoc R29l+ZrJZeAFfhmynw9rHzJmlXv3e0unYrnKoviWVeW+IlGcZshLEYlXkld6soLWbRx4AjDe V0SOTb4u8+SyLHU1np+k1UhPC8VHU6GRmLBmIYvNaO7jRQlHdli2MF2c02hB47hdEAYqgBw9 6BHrVjlblIQMNTR7l6Hv09Tcy+DXGIaQ7QMViVPU/sGMg8SjDwgq+yxI9wyPCheZQOwpd3so /GSklkuWk7fF+rLsGSwptR8FToTH+mVTrgjuFSjqIJ/4HUdf7OC2muWVoum8yvr7E0GcvAQc u+P5pQHrvtNm3rFYFV3xDvWpVbJHUEOfdl/eoTaharmIbmO4fqvuvUfLL4P7z2CwspXWv5Hz 8CUVHIVYN9x3HufkW9rAnaWnvrdEC614l3CrLm8+8az5VIMoVNtwMSmEmo/83jE0wajoUGOG 9FZJ/3mKKyome7uUzS6X9yBxZbBkFJpLP6U31LogcOO1jucakKvsiefWw65grCGjZPC+ftVC JPrVV+/qy6a7aKwzo5Nt6hOmWGy2cIqGmSVJcakK2b7cLjcpc1Z6xWAJBZJEHuLVhYiAxqoG BMZEs4XUfZDCrpkrjgpocTHvvje951hxqLLcZYpWnEj1iVodgiSxIgLmWTeP/SpTxrZjJPwn Vt7qcUgdO76EeSAFp6pN59DXphRyC8BqlcAAGMeYNO84qbCD1YfCOtnjyVixY6Z2zw0V4d71 aRbRG8SLXzGVxatWlf0qH2tGx1bXmGO319cWp7t4oVLxWdyylO+N7OXKCp32eXZlZq+JBBDB jMfSYSLgRyx9q+yR6Sn3KYGW87w4g1V9atf4gLYvXd3GigJ5aPkrxDF/hI/Ix9PNSrqeMTV/ mDEjXlYQ/QGqcs2waPoGwiNzQxoH44kenw0BmN1hny4FcvRf7TKk9hXbcVPpWV6HXlXe+B1N F8gcguteW9dmX3Zdju89CcUxdTbhfSq3WxVecmtNRdur8zrqJ6G93DSiTTvUs3qikWPYPxjg cTUa576LfONstmeNETYTtQ+h4smM6UJEUmvwTqCoYFDB0Qpm6eO8nM76vDqLIpDEHEvgf2NF WF+yBW/vvOXUK4pPYnIrN1JX4TZFk36Xxk8u/HapbZDx+ycfpfuFW9KX2wfdZmOee4MKRVqg w/5d6Gn+WaLXWlnA/RuCZ2OaJI/SKsR9ioDAeFBO5P9Ji7ND2389+Xyd/2iC2yTz2xL1kcj8 lCc0cba8xYkDksjIEtyEGJO+XKi1Ngl0Eb+C1tk17mx5Ov72jaF1xXKAGxuOQiYRBDdnyTyd nf+eeW1H7h8CFI1JnKGkBXZMxPEbErP//KBjYrL9MRsr6u97cuhSoGYA5GNR9PtAzA X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40564465" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P0w5iSkG0+lY7QmX02UDQ0SR/DlZEbDUkxiclEPrZrGiqXod2uAZ1+bPJRkhEE2Xs3ddpDVebkmc9esUFq0JLdAmshK4lmXDR/ct0L1vdnE5wtI5glxSPfg+VtNLusVR+E+hEkRMo2yPLf9Tsx+r+Vx1vcQMp+75C1pcJElYedhS70otKKuPWeUOqri9DECxrfLu/ElqSx17sfl3k6skzeNGRiGSPc230GsUVkquE44srIg8uNtZb98ZI0e2FE941qvTNU0i2SD6RcsWqVmeZ209Y+FlEUbcASxlq+PgIqjWg6tgydGR/WfXUSIGym48aDoASJkvhBcPsziPZWzPaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3HjMmrzvK0BzFoQTQ+HyoK8vV4DZsaL0cdU3Kvbt8xI=; b=QVPevwBtlsrvVLOC0GIPBVgyzZn8zyxoCFEGe1dIaeGJ3ady+o8U46n1w+xNu2/fyV1cDu7JbmsOFa41citbPditT/T6tL2ffDy/Hd/AIiByW1S4aT6DF1KBK2aNSYw2NNzehwNRjrcjIE6quemNjpYYOGG70FcJY8/ed/C6nPKn3dW8WM7/EVMeRQ3sQf2uscbzlrguGZEmWODoxf+ww2oBppYDwzknBfJ0s7O2DEe7sg0eB3MBrtzKVnJAy7ZMTpm0XbtGs6neS/w2p+om7BPt8niAYxk3wXORX7/Lw0JcoJ1M9aastvPVbyRcKZfmFnNbFfTaDIwYqCZHS7Cm0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3HjMmrzvK0BzFoQTQ+HyoK8vV4DZsaL0cdU3Kvbt8xI=; b=tNCGRdXzosgCnmQzW/pis0x6X+wOl4HgnktUBon+UCGYRNmtm5fZlbA7oBnr0LAaFraaVSjVzs1exgqg2jfr3PshZwMxVu5/sRLkMaSjg/3pNr4xcBXIEvaFNFuIzp/Aoe6yp+Qx1WykzhOt9vkF3HjZ8VbIpf/jwcchO7HLYd8= Subject: Re: [PATCH] x86/hvm: Fix double free from vlapic_init() early error path To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Xen-devel , Jan Beulich , Wei Liu References: <20210331133125.7072-1-andrew.cooper3@citrix.com> From: Andrew Cooper Message-ID: Date: Wed, 31 Mar 2021 14:56:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0318.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::18) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 669959df-a5f4-4326-b17e-08d8f44cca55 X-MS-TrafficTypeDiagnostic: BN7PR03MB4515: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1002; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u4xuSFouuei9wamnZ0HeFEvmZY8qeiw4LWPt49mSge9EpfPC85T3X8fLd34uVaLKNcA37XZOURvmBxR4qEakv8cQpbAhfC5MJrkCdf9sDSTmdRPTAbGTn3du5Mk2qXdhhtJAJb0hQ4Em9P/Zakd02Y02g2CZhqmx2YPUpk7Qp9xCJ9BjKEdzt2gemhUP13AWx60AwLNPE7kLyEmSHi1qpOuLNfyNVa+AwT8ibZ7bV6IHtPOt2e4J3kUnNcrguCzHN+ynoCHAsIOKtxUKFVlAgU9o6Ap+PtWJ4Cm0Oq8ePIK1I9s9pET/N+U5vsa0uwDJ1kAsUiTKZnBD/qaFuGdRQ5C5miu41K5tpVHVTRZezYz8ze32He61NmHK8aW+yZT5OrU1GiKq5/VKdiS+BJum+bANfGsKm3jQZlj3L1fabMZj9wGMs4TVpO0QLWMN1pAc5wtE8BSFzoE9VrkyfCgTMxVe3XUH5Tt/FtCLp/SDyaMEPeqZLeSWDKcFTbMY9JRgLHNd219hHPlANK5GN47HTfIiPEiv60gw1Fd83KaaOj9zOZxYN2CjKJ+1OuTr73hgp1sJCv3sCFLbPE6HfmDwMysPZPdsYXfnci0uby+OM5z/5ryKyVzMEKb4Kjg+wE9aP7/4lWLK6np8nIcGehfRCiGoDs07Xh+k751Nync+wtDEsYPS2j83go3LSYxTQfWHAuN8U+0JJP9Lrcfpo7eq3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(6666004)(186003)(66476007)(26005)(2906002)(16526019)(6636002)(66946007)(54906003)(31686004)(316002)(16576012)(66556008)(4326008)(83380400001)(38100700001)(6862004)(2616005)(956004)(6486002)(53546011)(86362001)(8676002)(31696002)(5660300002)(37006003)(478600001)(36756003)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NkZYKytBcUtNNWpmd0pvUExYdmtsb1o4bW5kQlhjcklCVkVIWDUvek8vMmdI?= =?utf-8?B?b1BONWEyc21WRzlMVkxnUDFuYUY4dUROOFVnWERWM3pvSENVNEwwRC91dEZ5?= =?utf-8?B?QnoybWlTb1QwSTVFVkRlYkpZL01YMGNFd1p5cDR3azJSZmJWQWN2ZFJqVVN1?= =?utf-8?B?SXZVOHJNYmdVdi91bWczVDhFTklmOWVQRG5uVVpTRWIzcjhQSURrOXBCU0My?= =?utf-8?B?N2Q1SDNsV3Uxa3hWeWpwbXNNZnN0bVJYZ3VBQzZCRFNPTEtpQkVKVFRXMThT?= =?utf-8?B?NURtSVREMWhXWUlGQmJrZjgrWC9kUnZhL01QeHI0NVU0Q3RjbkdSSFlwaHpR?= =?utf-8?B?L09ZNjJEMWpncjFvamlFcGhFQ0E2R3l0aExpZ2hvSUdtdkdYNXRuTWRDZ21Q?= =?utf-8?B?SGYxTGU5VVl6a0oreFh6UktiUllQQ3dXcCswbHJ1NThaQzFwUTMwY3ZhWlAz?= =?utf-8?B?V2haMnRoamUxcVFaODFKdDFNbHl1YWtWN0dIYjNkR2gvQ0Z1TkJjUmhCSERC?= =?utf-8?B?Sk9ObGJrUWN6azN6QU94bTN3K0VBY2FXVnBPZThHaWVCM0JJSWE5ZEdNOFZF?= =?utf-8?B?SXRtSW9PcUY2cGZNc0ZqU1BYUEpwczBFbTRyNENmbHVmSGR5NFg3YUNHcG5P?= =?utf-8?B?aktEb3NacGtnWnZtUVVOa2RuSDloeS9OQ2FSMEIxVnFoZ1NIdEJ0L29nQjE2?= =?utf-8?B?TmlaUlpnTEpKQTgwRjRvSnRzQUhSWWNjUW0wWlNROEx3M1RWQmdnejlqVVEy?= =?utf-8?B?TEY2ZGxEb1kvOEJiOGdYTVBKOUoxTkYvMTlzazVHRmNISkxlMlZ3TWp3Rm1N?= =?utf-8?B?RnpzLzJxMFh4UWZ6N2Y4V0x6eFNuc3dEa0tpMkt4N2I5UVFvVUNReHA4Slhl?= =?utf-8?B?ejl3emZMWk5hSFh5ancreXNKQ0w1Q1ZaTDh6SVhOWUsvNTFHZFAzSFNDRGJ5?= =?utf-8?B?am4wN2NOU3dLR0J0T25hRTJvTWoraHRMdm0wT2hYTU9yL2dXd0FuRG01OENu?= =?utf-8?B?NFh2OGhCNTYvWmVUdURjUDRsV1FaK3hleFNuRVd3bk1nbTEvOEg1Qjk3TlJT?= =?utf-8?B?akE3U1ZyWllQN3laNnhYWEo1SUs2QlNqQjI1ajdJNVZzK1k0SWxzU0xTeFdp?= =?utf-8?B?MGMvRnM4WEk5QWdWYWZCRUV6V3FsaWZLSVJ2Q0hnRUo4VEhmbkxGb3ZjYWRK?= =?utf-8?B?N0MrOUFaYjAwUmJidmtRTmFDMndydGU5VG91cHE3N3d4b0NaZy9pMTJmWmx3?= =?utf-8?B?YjdOQ2E2UFYvK1haSlpDblpqbDdyTFd1MVFxRHVFZ3lvUW5jOHBHREI0bDRq?= =?utf-8?B?cFdHKzRYK292NG5kSXJkTWVHTkdpeUNDdVJPaGZXSWhEVW9ZY2g4dUFteXJy?= =?utf-8?B?YU8zeVMvd01NTEhHOHZqdk1KR2NPWUlES3ZDWFd3MitPaXRBa3NHLzFhd0RM?= =?utf-8?B?TTJtNHp0dUc3WnBKbzFqVldFRnBpTDJxREJJaXAzVGdrUnh2bGJQcGN6Tk41?= =?utf-8?B?K2Y1Q1RmeHVEMXdUaWJpOXh1bytId1YvMVNGbFEwc0NONmgrbkJqUktsczZY?= =?utf-8?B?WmhEUEk5citvbnZhSGgwUjNUTWRiWHZ4Y0d1NmlLNFA4RG50c3BBekViRG45?= =?utf-8?B?QnZRR3FVMHBLeFBML2REL1BzUWUyVEZxTmh2c3Nhcm40NEQyNCtydGZkS203?= =?utf-8?B?ZnVJbW81U054ZXlNNWQ2V2RjUWtoYjloelI4aFQ1SXZ6MnNndWZHc2kvQlFQ?= =?utf-8?Q?83Z9MbEMOkQ0CXY+GOXbLUUoBmrVg99VZJw0asI?= X-MS-Exchange-CrossTenant-Network-Message-Id: 669959df-a5f4-4326-b17e-08d8f44cca55 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 13:56:32.3799 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KBM2ipyKXlWEm1yXips7tAXw0GeHUWqFFTQT2+NXK5wwa5Ct/+11clpC05vqoV/u0VieFQ0efAFgz15KvLe8qwW6j4OcAAUFDW+oS6+x0Nc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4515 X-OriginatorOrg: citrix.com On 31/03/2021 14:49, Roger Pau Monné wrote: > On Wed, Mar 31, 2021 at 02:31:25PM +0100, Andrew Cooper wrote: >> vlapic_init()'s caller calls vlapic_destroy() on error. Therefore, the error >> path from __map_domain_page_global() failing would doubly free >> vlapic->regs_page. >> >> Rework vlapic_destroy() to be properly idempotent, introducing the necessary >> UNMAP_DOMAIN_PAGE_GLOBAL() and FREE_DOMHEAP_PAGE() wrappers. >> >> Rearrange vlapic_init() to group all trivial initialisation, and leave all >> cleanup to the caller, in line with our longer term plans. >> >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: Roger Pau Monné >> CC: Wei Liu >> --- >> xen/arch/x86/hvm/vlapic.c | 11 ++++------- >> xen/include/xen/domain_page.h | 5 +++++ >> xen/include/xen/mm.h | 6 ++++++ >> 3 files changed, 15 insertions(+), 7 deletions(-) >> >> diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c >> index 5e21fb4937..da030f41b5 100644 >> --- a/xen/arch/x86/hvm/vlapic.c >> +++ b/xen/arch/x86/hvm/vlapic.c >> @@ -1608,7 +1608,9 @@ int vlapic_init(struct vcpu *v) >> return 0; >> } >> >> + /* Trivial init. */ >> vlapic->pt.source = PTSRC_lapic; >> + spin_lock_init(&vlapic->esr_lock); >> >> vlapic->regs_page = alloc_domheap_page(v->domain, MEMF_no_owner); >> if ( !vlapic->regs_page ) >> @@ -1616,17 +1618,12 @@ int vlapic_init(struct vcpu *v) >> >> vlapic->regs = __map_domain_page_global(vlapic->regs_page); >> if ( vlapic->regs == NULL ) >> - { >> - free_domheap_page(vlapic->regs_page); >> return -ENOMEM; >> - } >> >> clear_page(vlapic->regs); >> >> vlapic_reset(vlapic); >> >> - spin_lock_init(&vlapic->esr_lock); >> - >> tasklet_init(&vlapic->init_sipi.tasklet, vlapic_init_sipi_action, v); >> >> if ( v->vcpu_id == 0 ) >> @@ -1645,8 +1642,8 @@ void vlapic_destroy(struct vcpu *v) >> tasklet_kill(&vlapic->init_sipi.tasklet); >> TRACE_0D(TRC_HVM_EMUL_LAPIC_STOP_TIMER); >> destroy_periodic_time(&vlapic->pt); >> - unmap_domain_page_global(vlapic->regs); >> - free_domheap_page(vlapic->regs_page); >> + UNMAP_DOMAIN_PAGE_GLOBAL(vlapic->regs); > I think you need to check whether vlapic->regs_page is NULL here... > >> + FREE_DOMHEAP_PAGE(vlapic->regs_page); >> } >> >> /* >> diff --git a/xen/include/xen/domain_page.h b/xen/include/xen/domain_page.h >> index a182d33b67..0cb7f2aad3 100644 >> --- a/xen/include/xen/domain_page.h >> +++ b/xen/include/xen/domain_page.h >> @@ -77,4 +77,9 @@ static inline void unmap_domain_page_global(const void *va) {}; >> (p) = NULL; \ >> } while ( false ) >> >> +#define UNMAP_DOMAIN_PAGE_GLOBAL(p) do { \ >> + unmap_domain_page_global(p); \ >> + (p) = NULL; \ >> +} while ( false ) >> + >> #endif /* __XEN_DOMAIN_PAGE_H__ */ >> diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h >> index 667f9dac83..c274e2eac4 100644 >> --- a/xen/include/xen/mm.h >> +++ b/xen/include/xen/mm.h >> @@ -85,6 +85,12 @@ bool scrub_free_pages(void); >> } while ( false ) >> #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) >> >> +#define FREE_DOMHEAP_PAGES(p, o) do { \ >> + free_domheap_pages(p, o); \ > ...as both unmap_domain_page_global and free_domheap_pages don't > support being passed a NULL pointer. > > Passing such NULL pointer will result in unmap_domain_page_global > hitting an assert AFAICT, and free_domheap_pages will try to use > page_get_owner(NULL). Urgh - very good points. Do we perhaps want to take the opportunity to make these functions tolerate NULL, to simplify all cleanup code across the hypervisor? ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Mar 31 13:58:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 13:58:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103961.198309 (Exim 4.92) (envelope-from ) id 1lRbMF-0007ga-PK; Wed, 31 Mar 2021 13:58:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103961.198309; Wed, 31 Mar 2021 13:58:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbMF-0007gT-ME; Wed, 31 Mar 2021 13:58:07 +0000 Received: by outflank-mailman (input) for mailman id 103961; Wed, 31 Mar 2021 13:58:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbMD-0007gM-Vj for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 13:58:06 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e6e90a75-fa96-45e0-ab62-4c419187b29f; Wed, 31 Mar 2021 13:58:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6e90a75-fa96-45e0-ab62-4c419187b29f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617199084; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=oaQ5d73A7ONCkvTRszCxcC2b5AN5hC+zf+t6roImfW4=; b=Z/zmQDSmYekcOfrQHQvrSdu2XKFeRw4YVDPtePR54vgveYDvsu6IYAUa m2c7mFc0Mz/1oTJx/vfE8+VWd6RZezAf9WPl67F5rx5yJsm4H/nJzU4yU A+Qqd9j/y/BkEpa6WyKYlhH9uWqp53xQjZGvz1pr6oAxn4f14LBOL7RbP Q=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: rAk9kULo2orzUaE07Zrs+3pf5j78MsNmUIcc4LAZehhPcQvZHnrND6HSogFIRUOlIUA/LScm4v r1M3ghrmo0W2sRJWPM5D4EtsaJZw5NfzAzu7maOYEGJ6KtlAkqLhC6CPFdVX8BhAXIzDITAbSI jq1TLeJqxA/z1DBSnI5/XHTycuKeZekxn6jPGBl1f74B7vcN8k5qYzsWSBg6vMvh3sNFPPyiV0 K6hiH+hjwyeALYJq4wYzYUof7UNUKKP7iA/CKhRt96FMQv4w4+VkSTt+t+kU4WXY+g3nngZosb S3s= X-SBRS: 5.2 X-MesageID: 42014455 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:P3GOkq3PyOC3KiE9Z7MXbgqjBQJ3eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/FIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFmtJ1/Z xLN5JzANiYNzVHpO7n/Qi1FMshytGb8KauwdzT1WtpUBsCUcBdxi1SYzzrdXFebg9AGJY/Cd 6w5tBfoSChZHQQaa2AdwM4dsLEoMDGk4+jXAUPAAQp5BLLoTSj7rP7FBbw5GZibxpkx7A+/W /Z1zHo/6nLiYDB9jbw9U/2q65Xltzo18dZCKW35PQ9Bz3whm+TFeZccpKYujRdmpDL1H8Ll5 32rw4kL4BP7RrqDx2IiD/M/yWl7zo08X/lzjaj8AveiOj0XigzBcYEpa8xSGqh12MasNtx0L 1G0gui3vI9Z3Ow/1WO2/HyWx5njUayq3Y5+NRj90B3aocCdKRX6bUW4UI9KuZwIAvB9IslHO NyZfusgsp+TFXyVQG8gkBfhPaoXng1Ay6cRFkDtsG/w1Ft7Q5E5npd68oFknga8pUhD7FC+u TfK6xt0IpDV8kMcMtGdas8aPryLlaIbQPHMWqUL1iiPKYbO0jVo5qyxLku/umldLEB0ZNaou WPbHpo8UoJP27+A8yH25NGtjrXRn+mYDjrwsZCo7Bkp7zVXtPQQG2+YWFrt/Hlj+QUA8XdVf r2EolRGeXfIWznHpsM9xHiWqNVNWIVXKQuy5cGcmPLhviOBpzht+TdfvqWDqHqCywYVmT2BW ZGcyP0IOlG80C3Sl71iBXcQBrWCw7C1KM1NJKf0/kYyYALOIEJmBMSk06F6saCLiAHkqFeRj o6HJrX1oeA4UWm92fB6GtkfjBHCFxO3bnmW3RW4SsDM0b+d6c/q8ySEFoimEevF1tadYf7AQ Rfr1N49eacNJqL3x0vDNqhLya8g2YMommJC7MRgLeK68ugWp5QNOdpZIVBUSHwUzBlkwdjr2 lOLCUeQFXEKz/ogaK5yLoOBO/ecNF4qByxIdFdrE/esUn0n7BtelIrGxqVFeKHiwcnQDRZwn dr9bUEvbaGkTGzbVckjP8AK11KYmSPCLdgBACIDb8k3YzDSUVVdyOnlDaagxY8di7P+18Jjm LsFyGSZMrGG0FQoHxez6bs/m5lb2n1RTMCVllK9alGUUjWsHd61uGGIpC+1GaccXMu6OAQOj OtW0pYHipeg/SMkDKFkjeLEnsrgqg0NuvGFbI5bvX4wXW2MrCFkqkAAt5Z9JtoL8rVr+cOSO 6TEjXlag/QOqcM4Ui4t3wlMC57pD0YivvuwgTi93X983glA/beSW4WMY0zEpW51SzDSPmJ2p ki0o5wkuu0L2nratmJjYvQdCVOLxvPoWiwC8EkwKokyZ4ahf9WJd38VzCN6VRsmDMZB+3wnF kFQKt67KvaU7UfN/A6SmZ8xB4RiN+LLEEXqQT4De81QEE1gxbgTqa0youNjYBqP1aIqwTxM2 SO6iFx///KWC2YyL4RYphAVlh+WQwZ6H54+vmFeJCVIAK2d/tb9F7SCA72TJZtDIyEE64XtB B0/pWhmPKWbTPx3ET1sSFgKqxDt0ahTsXaOnPAJcd4t/i7M0+LmK2k/Yqaiyr2UyKybwAgvr J+HHZgJ/hru30Fl4040i+7V6zxrAYEqjJlkE5av2+o/JOn7mfdFVxBKivDjPxtLGBuDkQ= X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="42014455" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I5W81CPDrkCkr/2k0qh6lIeVsdIfaI1m0dUAVnrA359SoDsxLv2+A1gAVcLuQ9BQJEcMQtBDDVT8KRULff7v6Kn/Zf/fC0EaY1wK053yfPIHXHJ4jS6KAyWpbsOn734Fn2YSUlOqZrxE/80jS6vTIRL59+5mBXZk9w1vU1HQji9zThaKo6NuwTPsINOh66NSle0AGpuNNu08eEczK72qU6bTxkMeW/kanO2uEp08Pt648cvATvGQ0/Sldwvpg9ZZZRdaqOAo9xpSnFpS68HH4bLPo01Nq+MjHjkA9flUjDq2X5e9k5qTbBLFJkVqtH9LRb3oqzqW5VU9QpUg5UcyAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y/P5L6W9u5PncH7s10IMUlBsuZUVrseB6TT68j/XCYE=; b=kWGBM9AypmFcMwu1VF/IVajA7pb2qI7WhNCOA5mBvmZKntF4HDGd3uMSoMX4opHKMq45GTy/HNjFfb3OQp/kVhiKV37lQr4TSlbrdLflevuleg7bvLoY7iy0bITtOxcXqu1iUOfO2fzL+QjnFVEoq9F2OGw3/xgMa9DeYUl2yctIJndOBxKIWFPckk9ZNFegd/cJsh5+VpTnikrDA6BsLHbTRhu9d7rXQZSUHFxHpCcxvwJxVWzmmSTFAbHEy+6KH1oz9gi/SbqZiAOwVqlVS0scYBUzeeqVumg1F59n27XC9HEP1lzkyyJuyWBgTNMe1ovTrciq/gD8lh7nqBIoLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y/P5L6W9u5PncH7s10IMUlBsuZUVrseB6TT68j/XCYE=; b=A5k1CLgveIo2Dt4io7Mosk7Tt5L3rNOIQH41qX2Dra5UBu0thEV9342XxrytP0U98GhFN6a+FoGyGpag0RC4iIwjqcS6C0z2CDGmElsGoOtDMD/bqQStR+uFGCDp9G7aQF2p553mYwxPURGBep9Pl9wmMZF5x98aqk4X3e2lJG0= Date: Wed, 31 Mar 2021 15:57:57 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: Xen-devel , Jan Beulich , Wei Liu Subject: Re: [PATCH] x86/hvm: Fix double free from vlapic_init() early error path Message-ID: References: <20210331133125.7072-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR1P264CA0035.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2f::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad7a76be-9a63-4f06-a713-08d8f44cff9e X-MS-TrafficTypeDiagnostic: DS7PR03MB5526: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3173; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uZf771vaj+TBkGpZlvNLxyN9RJOiCad+zuYtu2TfDQBy8SI7SIEEP2UhWQTx9JDblluFVSQptK1mY+91d9+2sk2qxl9eXtOh/fn2PhJK4lNf2sfurYnvH1zP87TYc+ZfEiIJ4lHaVmd2MnxH9JbZS6YWM1TNQoTpAN5IK77YjDyu+qmKiVd6ZoAzEFyaA8q380hJJIckL50iycHKlkyhTwlhGdetDijqbo6KVPDk+WHP+T2uts7pccQnh2w2ipQmOWJZ608KbpAJmSPduhG0NnTKm7MjaafvfGGl9k7+zNWxztcKlLzVBxIoY0ov/zh9qryaHtn27NZNLvvESAAyVJQmTnRlKfHjVb7wt9ex2gsuQwg49niUja0ljL4CgHLe51P1pMHryk5AfgPDD6dEjmNBPxmRzXuzMJc7YeQNVISXXyoYYR/lXDiuoE3SVmH9biGhFCBSIDEpLbXam/MB0xkohPoFL2rPsePDClUC2qQcgxwytbPhLkZQEOzwkOnI4Tp2tyAg68gRGvzqjP7+O6c5NAMvkCsH0rx/qsV08yKwbVhH6ssGX26/Lgy54mdEzg2UEAHxgzDYE9tFEUTtRidV6kgo/DumPen//70pZXcQkO0GE7JoG21abChwNDR62sAJvGT9rVCP0zhrveLH93IWoI6JvgQW3/qYCh4gBag= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(396003)(346002)(376002)(136003)(366004)(39860400002)(53546011)(38100700001)(6862004)(9686003)(5660300002)(956004)(85182001)(83380400001)(6666004)(33716001)(8936002)(478600001)(186003)(4326008)(6486002)(16526019)(86362001)(8676002)(316002)(26005)(6636002)(2906002)(54906003)(66946007)(66556008)(6496006)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZTZ3RVJkdjhhcS94a2tqVVFCd0ZScE5kZk5YUVA4UWZIRUFSdVJLZFlITUNp?= =?utf-8?B?UXlocGVhbXFaK2tRYjhPL0l4cFA2OHJoSVhHQmg1Z0s1bmR0dVh1L0FhYm92?= =?utf-8?B?Qm16eDVGQTU5eFJqTGwrbXNzZ0JYOGJSeFJFQVorcnFSalN0d3NtQStrNVR5?= =?utf-8?B?VzV4bWlRQ2tVdlpGcTQ2Z3RSNEFkMHVibm5CU096S2wrazQ5RzZTMUNKWXpV?= =?utf-8?B?SU5tUXcrT1lJMkU5RnhmRXRtbTdXcjhyNGlmbm5KK3Z5TWFOSkljL3Z3QVNI?= =?utf-8?B?emFvWUlEdWlabkxuRmo4S1p0VWRHc0FRU0kvMDFmUkl2bTFjL0dpRFdNR0NK?= =?utf-8?B?YTFMdVMvVFdaZVpZcHUvSUR3RVlNN0NhYURXWTBBS0RPT0ZNU0o0bG5HV1Z3?= =?utf-8?B?NXZZOUUzZkI4Tjd1MStKMTFUc29UZldCSnplRTJpbzlvTkxsNHRrOE5ieTBV?= =?utf-8?B?SjlXWEp2OTd6aUVockVoUVpRMHF4MFg3YldJUUwxQVVuU21LMzFORStUQzRD?= =?utf-8?B?bVYwc3BOQmF1bTl2ZGcyQThzVU5leHRJbDNOSUFDSG0zRHBRRm9lTUt0cFlh?= =?utf-8?B?dnZuQlRnbmJyQ1Y0dURyZmVVbVlsOU1TQWpCczhVM1l3dWJYNzNlVFBSMFFt?= =?utf-8?B?T3psQXluZE5LR3FyK2h6aEI3SDlJVmhkeFdsV3BuS2FnZUFCcUdMWGRaczRx?= =?utf-8?B?YzRHaGhVeTZCMmhCa1A1MWhHSDNCVDFBd3oxQ1dOUmROYnB4ZnJ3d2VHcVg1?= =?utf-8?B?UkYzVENIN1dLYStVWmxHeVg4dm5IS1d0RC9XWnVwR0E4YUhUY01IL1F0b3Rx?= =?utf-8?B?eE9HMTQ5N1dXa21zbzY2SHNTRWI5akdseFh3T0VSbjdBYWVJQWFWdjNwZHAz?= =?utf-8?B?c1g2WHdPVVdoWUlhejNJck5GNTRFR3gyRnViQ1Z5N2xsR20xdEtNYlpCYjJD?= =?utf-8?B?a0lrem1XV3ZJYjE1MU53cDZITU9ZTXZzVHpwNlQyMlZuc3NhT1NvOWVEQ0RU?= =?utf-8?B?ZDBLK0RSd1VoeTl6cDRBRTg3SlZNVzMvR2dsOWhlYS80dGh1NDdZUVdkRFJB?= =?utf-8?B?Q0VnV0ZEaFVMV3dYNmdyVzFOUkJKZGMxOUxxL2REMWpTcEh3eGtxVE5ETVdS?= =?utf-8?B?TXIrb3dRVVdTalJnT252NENxT1BWUFNlbHptK3FvS1pyVTY3RnFIU2kxM25v?= =?utf-8?B?Q0hnWitOcVVoVHZla0V2U01HazBNWVU4Q3F1d1NncTJiSGJFZU9HSmcyMUVQ?= =?utf-8?B?YzNhY0FwaGJoTUZHQVdsZmQ2R29lMkFVWFNXYVl5ZnZJTXA0K25uOE1oSE5R?= =?utf-8?B?MDNONko5TkRKTGlmSURabVY1RzBqQWdQRFVlVTR5NFJ2SEtKT0FkTStqaTZV?= =?utf-8?B?djcyTzNUTnYrQ3UyZmNkUzV3Sk55OFZwRGVpMVNVUVVMZFRneitERW56ZFV1?= =?utf-8?B?TGlTVkJOdkVIZzNUbGpzemYvdUNUazdtM2EyNHAyb3FKb0ZBaXZRandOeGZh?= =?utf-8?B?WUZGL2x1SkRLWDYzcTJWUHAyYVdmbmhBajVGd3ZUQ1d0eWVZTndOcmdnMnFK?= =?utf-8?B?MUZ2RUpLSDl6bGRsenlmS3c3VlA0U1h5azVDNlBnQlRuSVVvb0lHbEIyeXZN?= =?utf-8?B?V1NpaUVEZkhyUW1nT1B0QXhjU3JUY1VHSGxUQmpaYUtXZ3RiUU1EMXU3ZjFQ?= =?utf-8?B?emI1OXBxcDFEUVRNRnZRVEx0RUNlNVFBM0QwNTJtWDFiSWpkQWF1S1hLZFVF?= =?utf-8?B?VGJtTmN3SmV3TlNGSlpHZTVObVhJZE85Ym1NZlEyMk1yYWUzQTg0Q3Ftb2k3?= =?utf-8?B?WWRqejJkcFdQSUMzbERidz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: ad7a76be-9a63-4f06-a713-08d8f44cff9e X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 13:58:01.8444 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D2pFZba6AUI8jzPpNqWduIz8RXI1mmUHx9IlT02HVVQJA4I2LJuBAQuz99IxC+sXzz6oMlsoXhG2Rno/Qks93w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5526 X-OriginatorOrg: citrix.com On Wed, Mar 31, 2021 at 02:56:27PM +0100, Andrew Cooper wrote: > On 31/03/2021 14:49, Roger Pau Monné wrote: > > On Wed, Mar 31, 2021 at 02:31:25PM +0100, Andrew Cooper wrote: > >> vlapic_init()'s caller calls vlapic_destroy() on error. Therefore, the error > >> path from __map_domain_page_global() failing would doubly free > >> vlapic->regs_page. > >> > >> Rework vlapic_destroy() to be properly idempotent, introducing the necessary > >> UNMAP_DOMAIN_PAGE_GLOBAL() and FREE_DOMHEAP_PAGE() wrappers. > >> > >> Rearrange vlapic_init() to group all trivial initialisation, and leave all > >> cleanup to the caller, in line with our longer term plans. > >> > >> Signed-off-by: Andrew Cooper > >> --- > >> CC: Jan Beulich > >> CC: Roger Pau Monné > >> CC: Wei Liu > >> --- > >> xen/arch/x86/hvm/vlapic.c | 11 ++++------- > >> xen/include/xen/domain_page.h | 5 +++++ > >> xen/include/xen/mm.h | 6 ++++++ > >> 3 files changed, 15 insertions(+), 7 deletions(-) > >> > >> diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c > >> index 5e21fb4937..da030f41b5 100644 > >> --- a/xen/arch/x86/hvm/vlapic.c > >> +++ b/xen/arch/x86/hvm/vlapic.c > >> @@ -1608,7 +1608,9 @@ int vlapic_init(struct vcpu *v) > >> return 0; > >> } > >> > >> + /* Trivial init. */ > >> vlapic->pt.source = PTSRC_lapic; > >> + spin_lock_init(&vlapic->esr_lock); > >> > >> vlapic->regs_page = alloc_domheap_page(v->domain, MEMF_no_owner); > >> if ( !vlapic->regs_page ) > >> @@ -1616,17 +1618,12 @@ int vlapic_init(struct vcpu *v) > >> > >> vlapic->regs = __map_domain_page_global(vlapic->regs_page); > >> if ( vlapic->regs == NULL ) > >> - { > >> - free_domheap_page(vlapic->regs_page); > >> return -ENOMEM; > >> - } > >> > >> clear_page(vlapic->regs); > >> > >> vlapic_reset(vlapic); > >> > >> - spin_lock_init(&vlapic->esr_lock); > >> - > >> tasklet_init(&vlapic->init_sipi.tasklet, vlapic_init_sipi_action, v); > >> > >> if ( v->vcpu_id == 0 ) > >> @@ -1645,8 +1642,8 @@ void vlapic_destroy(struct vcpu *v) > >> tasklet_kill(&vlapic->init_sipi.tasklet); > >> TRACE_0D(TRC_HVM_EMUL_LAPIC_STOP_TIMER); > >> destroy_periodic_time(&vlapic->pt); > >> - unmap_domain_page_global(vlapic->regs); > >> - free_domheap_page(vlapic->regs_page); > >> + UNMAP_DOMAIN_PAGE_GLOBAL(vlapic->regs); > > I think you need to check whether vlapic->regs_page is NULL here... > > > >> + FREE_DOMHEAP_PAGE(vlapic->regs_page); > >> } > >> > >> /* > >> diff --git a/xen/include/xen/domain_page.h b/xen/include/xen/domain_page.h > >> index a182d33b67..0cb7f2aad3 100644 > >> --- a/xen/include/xen/domain_page.h > >> +++ b/xen/include/xen/domain_page.h > >> @@ -77,4 +77,9 @@ static inline void unmap_domain_page_global(const void *va) {}; > >> (p) = NULL; \ > >> } while ( false ) > >> > >> +#define UNMAP_DOMAIN_PAGE_GLOBAL(p) do { \ > >> + unmap_domain_page_global(p); \ > >> + (p) = NULL; \ > >> +} while ( false ) > >> + > >> #endif /* __XEN_DOMAIN_PAGE_H__ */ > >> diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h > >> index 667f9dac83..c274e2eac4 100644 > >> --- a/xen/include/xen/mm.h > >> +++ b/xen/include/xen/mm.h > >> @@ -85,6 +85,12 @@ bool scrub_free_pages(void); > >> } while ( false ) > >> #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) > >> > >> +#define FREE_DOMHEAP_PAGES(p, o) do { \ > >> + free_domheap_pages(p, o); \ > > ...as both unmap_domain_page_global and free_domheap_pages don't > > support being passed a NULL pointer. > > > > Passing such NULL pointer will result in unmap_domain_page_global > > hitting an assert AFAICT, and free_domheap_pages will try to use > > page_get_owner(NULL). > > Urgh - very good points. > > Do we perhaps want to take the opportunity to make these functions > tolerate NULL, to simplify all cleanup code across the hypervisor? Yes please, I prefer that rather than open coding the check in FREE_DOMHEAP_PAGES/UNMAP_DOMAIN_PAGE_GLOBAL (or the callers). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 31 14:00:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 14:00:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103968.198325 (Exim 4.92) (envelope-from ) id 1lRbOU-0000Bv-Ed; Wed, 31 Mar 2021 14:00:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103968.198325; Wed, 31 Mar 2021 14:00:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbOU-0000Bo-BS; Wed, 31 Mar 2021 14:00:26 +0000 Received: by outflank-mailman (input) for mailman id 103968; Wed, 31 Mar 2021 14:00:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbOT-0000Bj-FM for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 14:00:25 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 85e3dea7-bbce-4f3c-be65-1a420d06b33b; Wed, 31 Mar 2021 14:00:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85e3dea7-bbce-4f3c-be65-1a420d06b33b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617199224; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=XN3Z61BUcb4LwkfP+1OsHmAO3If0ZOxnUhhz51L1x08=; b=I2CBd1ku+5z2xiZLM142HF6Hm69buVjUxEddssSmc9v+41LfxY51StDG WxIaQzLTaTKH5rkawnOTlJjvWKu13frPT1DTdpBYsY+L4supP00xaxh9R 5/EDb1wuay0918AqowWevL3AR9M8nVlDByVOsAzvJp9MtmM3ICEiEcaGn k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: RFUFnkbk78ExsT18S79ZdaepB3Y3LQ8oQFjtkHrSE/j632kVbxrm+LjQupVDLqclEnuwT5uOYs BD3SA4TUbbigz92A4x9NqF5F3Kn7ZSX9x5g9JdoyBhP16tTeYqsUvm+fql5CkMSjUcExL+fo2h Xy/gZgew9dVmUhPBtIsyNTB4voEpkDZ9hDyvS4wOsIUBdNxvJ27q+qQxpq4qCG2DMI5CadoFah WXaaaHHNGaPNCRy/Gv6/TvPskE3aSjfP2ziSNE6ajGzaXS4ZiYAo6gndhFhxBxE4SkTEg8+qlX JP4= X-SBRS: 5.2 X-MesageID: 40545754 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:wWqKl6F2lX6tqU8WpLqFk5XXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7Lk/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeNJwTXzcQY76 tpdsFFZeHYJVJxgd/mpCyxFNg9yNeKmZrY+Nv25V0Fd3AOV4hL6QBlBgGHVm1aLTM2S6YRPp ya+8ZBun6EcXMYcsy0ChA+LpT+jvfMk4/rZgNDOgUu7xOAgSjtxLnxFRWZ2Rl2aUIP/Z4J92 /Znwvlopiyqv3T8G6S60b/zbRz3OHgxNxKGdCWhqEuRAnEpw60aO1aKsS/lR8vpuXH0idIrP DtpFMaM913+zfteAiO0GHQ8i3B9Bpr1HP401+fhhLY0IzEbRY3EdBIi44cUjax0TtZgPhG3K hG332UuvNsZHuq9kWc2/HyWx5njUayq3Y5+NRj9EB3aocCdKRX6bUW4UI9KuZbIAvB9IslHO NyZfusgMp+TFKAY3jV+klpzdC8N05DeCuuf0kYtsSZlwVRhXBypnFoo/A3o3FozuNed7B0o8 D/doh4nrBHScEbKYhnAv0afMexAmvRBTrRLWO7Oz3cZeI6EkOIj6SyzKQ+5emsdpBN5oA1go 79XFRRsnN3U17yCPeJwIZA/nn2MSeAdAWo7vsby4lyu7X6SrauGzaEUkoSn8yppOhaJcHHRf CpOtZzD+X4JWXjXaZFtjeOHqV6GD07aok4q9w7U1WBrobgMYvxrNHWd/7VOf7jCjAhVmTjAm YSXTT6Kclah3rbHUPQsVz0YTfAa0b/9ZV/HOzx5O4I0rUAMYVKr0wUhD2Cl4e2AAwHlpZzUF p1IbvhnK/+j3Kx53z042JgPQcYCk5U5b7nQm5bvANiCTKsTZ8z//GkPUxC1nqOIRFyC+nMFh REmlhx8aWra5qKxS4jDNqjOnmAj2QaoW+LS5t0oNzG2e7VPrcDSro2Uq14EgvGUzZvnxxxlW tFYAgYAlPEGij2kqWjhpwMDOTZf91x6T3befJ8mDb6jwGxtMsvTnwUU3qSSsaRmx8pXCcRrE Z26bUjjL2JniuPJWMzjP8jCkBFbH2aDdt9fV+4TbQRvoquWQlrCU+WmDSRingICxXX3nRXol akEAq5VrXgBEFHtnVRz6DwmWkECFm1TgZXcXB1sYp0CGLcnG18uNX7O5ab23eNa1cE3+EWOC zEZzxXOQ9129Wrzneu6Ua/PGRjyZM0MuPHCrM/N7nVx3O2MYWN0boLBvlO4f9eRZ3Tm/5OVe qefgOPRQmIet8BykiQpnw/PjNzp2RhmfT02Af95GzQ5g91PdPCZFBnTaocOdeS8iztQOuJyo xwiZYwsfGrOmv8Lt6Axqe/VU8IFjrD5Wq3Rfovs5ZaoOY7s6ZyBYDSVX/Qz25ctS9OWvvchQ cbWuB28brBMohgc4gbfD9Y5EMgkJCKIFEwugL7D+cidTgW/jPmFsLM56CNpaskA0WHqge1I1 WZ/iFH9/rOXieI19cheuoNCHUTbFJ55GVp/euEeYGVFR6jcPtb+kGmdnC6a71QRcG+aMIthw c/58vNmeCZdyD1gl+N+TR6J79D6GahT4e5BhmWFetB7ty9PhCNj8KRkbuOpSayTSH+bUISwZ BBfwgXaM9IjzE5lo050iSoUMXM0wsYukob5Ssij0Ln34it/XzSEk5HOxDIm5k+Z0ggDlGYyc DetfWC3Hvz4DJZyYDOGUdZcNZJAcURROHMXlNTANlVuqWp8aopijlCZxlrD3dUskGP499b X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40545754" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HcFr6Ha4VPJHqywRrmkxQ51sZLdPYKDUlMhj9isOR4TRQTPcPMEGN6zINNXTFOBoGMQ+k0h69KfOXKBPeOaInS2R9WYHkfv83a92JsIgASnLlvCNv0ta2VqNBS/MqJ2Hyd42oehZQ7kxL+xbepuE4MtsJXZHAr/wk41jtn9ymNGIG2+KAJ+JMHLSP2kht2vDqPbATyQ4am1Duv3mMeu4Sm4kLjCJIJhAYt5wquSornOmsvN0oT6700lJ4sLXkZUr9SOrZeHy2A+3ByKKNqjkmr4+9QdW+lO7t3w33PEgL/x3lCZswkAkxn+VGpLUfZ8vitmZsh/pbqGkaiLk2yn0Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XN3Z61BUcb4LwkfP+1OsHmAO3If0ZOxnUhhz51L1x08=; b=EXQ3ig6W5av8gWh4hs8hh7Mex1x5pCPwi+O5DOSlodMNS+iHs9HQc9vXpUxSz/o6cwNPRWv6QUBWEsrfVUILwdFvae/I90rbQOx4mE6MO6qKICHTJaNV+Ex2YhrlGkk9apv3Bf41cfMRZ/lpQY4LZohzAH8g9PiT4RcLkUexLWDA4lquE8rULWh+tSvt9Mp5Eqb0DwcVHuj1BmugHLLDsfwmkD7vr1LGQU9gx8vtMay4vEF9t5XYcC5IlNsgamZowLPbiaRHDZ286ch3yORqlo5xE6u63AqFmKX+l9O0Eb1Mua+K/mQloYFtiNMtBGgjfLCJr+dWuvGXZJpxMjdR3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XN3Z61BUcb4LwkfP+1OsHmAO3If0ZOxnUhhz51L1x08=; b=wnsLc45Leb2sfVEXkyJeLhjPLBuz2WLQL8msuGu0XS52OhgxWGTK8IplvgW9I73NhbACTdq95k9MiRzuhzF4H5mVlhrH5yu0esXZ/XpayzsMKgvFuUd4+1uIL09XPckFLNmKwGg1m+SUBnfihYpUiM5Pt16btW6Lf7A3y+dnryM= From: George Dunlap To: Jan Beulich CC: Ian Jackson , Andrew Cooper , Roger Pau Monne , "xen-devel@lists.xenproject.org" , "Paul Durrant" Subject: Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code Thread-Topic: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code Thread-Index: AQHXINLTS489UfL61EKD4pjlwXnfbqqUSZCAgAbMCwCAABhsgIAAEbyAgAEUfwCAAdQ2AIAAAIoAgAABtoA= Date: Wed, 31 Mar 2021 14:00:20 +0000 Message-ID: <1832DBFA-B215-4CEA-9C8A-F53F2A5321E9@citrix.com> References: <20210324172608.302316-1-george.dunlap@citrix.com> <23461afc-c0e0-eb33-9ed3-52f050b6aef0@suse.com> <27ecde00-f0aa-b701-6928-5480ed805064@citrix.com> <2A1FCD39-D0C0-468D-A977-2FBF7126FDE6@citrix.com> <24676.32400.548088.26254@mariner.uk.xensource.com> <1a87cfa9-d6c0-5da5-ea07-eae47186da9a@suse.com> In-Reply-To: <1a87cfa9-d6c0-5da5-ea07-eae47186da9a@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7d74b016-ab14-4093-7602-08d8f44d52bc x-ms-traffictypediagnostic: PH0PR03MB5910: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JGW6iR5LUnW9EKqR+0ZyZNl72fUjMl9H7u8//sytJN14XM0/R6mhg5I0Vt9vT50sOeujdA/dygS5xGusyqQSKbflWeNfulbc0MDePHMm8D1DX4mhxHwozMJab5N/7k+ZIcyh6jK8+RE915HxLB11+wFE67EUjMLR7kHikU5r2wktPMKhUfHWXj0qKdLsRhn1sSZD1A0BBzHYejCMjXbR7f3uuDI1JuRr16aCsGcpU7OFmDufsLbAfnbmOZr7FiTkg4EXLpmxyh/pXsvOzdAKSVuIcoiYsju6hlduFFN+3bkHqwPXKbJEeGYMqeQf11PgtXf9GQyx6jmKNAWgzzWvDD+rDuQlYBc9C5nLkNGy5nKM5cXuLhKy34IMiD+E+Aiql0oKnxpw+HmCoZlCdMNsH5i6h3MdCGEDhgccsX4SjGW/a3/D+e/+OOpbByByx6DagrKwm0+eSHPT3tcpCtlkLYCLyK3C905sBIwf0dvy3EJXTdbM9NfY4Q0RsJhswHE9bLYdgKJoZnUIzbnboWij/83UmhXnDaz/UWTt+z12xyfYY9j2M9BmQ2Q6wJemfGiLJHIlGkcvCqPvIfUg5PRrYJMDIU0QiCRn1wkmOLRT/qEvp0NIrHQng1WqGdnoSSJCe7RV6jEu5ybNYBTnAxREpURbPFOJv8muEfQDvQCpgy8KQujNWJMuz7l304LWJcpsLsEhKaBR2AodrVDltDgdTz70g1/pUa1zqCdBdrHq2mqz0mpmJdrY0sig9N7hsUdf x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(136003)(39860400002)(346002)(376002)(76116006)(186003)(8676002)(478600001)(2906002)(8936002)(91956017)(2616005)(66476007)(33656002)(4326008)(107886003)(83380400001)(6512007)(71200400001)(6916009)(66556008)(6486002)(36756003)(53546011)(38100700001)(6506007)(54906003)(316002)(86362001)(64756008)(5660300002)(66446008)(26005)(66946007)(219803003)(207903002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?a1FJVGpnKzNncDF1b2VLc3BMbjBlNHBWd3FzVGRyMHc4WWJKSmJPbis4ZHdW?= =?utf-8?B?MVdzZExROWpIVSthZ0IwU1k3d050OHdDTmxMUFFwQjVJNWZ5aEU2QjA4SDNp?= =?utf-8?B?MGtUdTNtUzIzNG1zaEVHZVR5bUE0REtpT3ZNQUZGMFlwdmZEUGE0ZnR3Y1pJ?= =?utf-8?B?c2hqek5WY3ZQYzk2dzkyNGlTRmZBUStuV0hNN3VkSzFVQklrdnBKbC9VbUV5?= =?utf-8?B?OW83YzFjUE5lSHRBS21FKzhERFdpWmRRSWJpcWUxdUllcWR5d094NXVGQVZm?= =?utf-8?B?RDdHRWpwbHpIWi9SZC9DbkZPOTh1VDhFaFVHSHYxOFJZOGhhTzg4L2d3VDB6?= =?utf-8?B?SERlYUlncFNBOG1xL2xPVE4zRGJjZDRYRGY0M2xSaThTWDREaDE5WjdjT1FJ?= =?utf-8?B?V0Q2RnRsckt3V2YxVDVKMEIwOEw2SWdMeFk5elp5SGRWeXBkWHJyWGNDa0NP?= =?utf-8?B?VXFIMUpYUytrTUU2alhFWW9EY21JWm5BT2lmblpMWlBvQVB1NkdjdklFUWMx?= =?utf-8?B?YmZSUEpTMG94MTZ4WFpTcnRDT2ZvVjZrS1UvdzdQUmtGeXdudWttV1JmZlBJ?= =?utf-8?B?em5YYWhJQmR3d244RFdUMVo3V0pFaEY5eHc4ck9kLzUyRTV5NzludkUvZGFk?= =?utf-8?B?UG9QaThFRnR4V0R2WjFrTW5pVkRUK0piaTJOUmk0SXgzNnp2VUd3TlNTWXNX?= =?utf-8?B?a21BTTUyc3JITzZ6a052NDVRTVMyeThXMkpDQzBBL1paNnRmUkFaZ0J3QUNJ?= =?utf-8?B?SE1GcTdxUjJUc1VFc0FJenRadkpYa1hGcTdJYWs3TkExM2VSdlczYnpXZ1Nx?= =?utf-8?B?bC9NcFRiNlY1c3B3d01TNDh3VDZnc1pxVVJxVGsvV1pEU0pkK1VKa1lJVnRZ?= =?utf-8?B?aUFUaG9DN1BYUFdiTklDR2pnNWxWcjRJNWhzTGFqQ08zMFhLbzZqZ2NOUzhu?= =?utf-8?B?aWYzTEpQQVlpTUhSVWFWbVoyN0ZyQitieGE5K21BN2I0VnA4NlZlR3BuQ0NB?= =?utf-8?B?QTVGTlFCNUVRZ2NwVmkxaHdXL2VrbnJrTnFOeGMxVnZqZjRWVVVjWmtNbHFQ?= =?utf-8?B?Uk9nakJoeFhMWU9PNXFjc29pc1NoNUlXZEx0UW9vdVlSSm4zNFlVWUJqKzFl?= =?utf-8?B?M0dyOUZFVzREWXc1TXk5YThKZmtOa1ZIUmxuQ2Uxb1YzajZaZUFQWGhjUGta?= =?utf-8?B?YldKdUkyM2FQUFdERElwcjQvQndjWEpIWkdrQmVhYkhLSVJlaHg0T09XZWVo?= =?utf-8?B?NXJoUkI1cElnc3BHVnpneGxGM3l0YTJvY2t0YXBhMDBrdzF2TEQyS0FUSnk3?= =?utf-8?B?UEhGTTdLNEsyT0hTQ2ZJdWdqUXJRT25KYm01VEZmbnhNUnlOcEtqUmRncUwz?= =?utf-8?B?MWJXVy90Ym5NOE1OTlBVcWpiUTdzM0VSeC9YT0RHb1k5SmRvbzBNVmliREd2?= =?utf-8?B?cTE2d2FFTlkzOGx4TkcvN2lJR1BJQmdUc29PcDZwM1FCUzZZSlBzUWMvK0g3?= =?utf-8?B?SGxRS1JIQTZ4SFA4dWdzUzBNN0ZCSEtLam1wZDhjZmY5TmFnK2xZejU5dEdI?= =?utf-8?B?K0FaRHk2ZU9HL09mck9WalJVUVhiS3JyalBId3RRODFXeDloUHF1YytQV200?= =?utf-8?B?bXBPRkhtVENEZ0xWVm5lT3ZyNGxYMnBBN1BvZFpFNFVqWnUyNU1lQnlCdXlu?= =?utf-8?B?RUhkb3dZdkdKamtRanN4SCtSKytLdlRJQlNWdmNQMDRKallnWmdkUXBrM3Nv?= =?utf-8?B?Q0hZZG1oWGdmeWxmSVVNTVBZbkp3MVVLVHFiMFhUa0drSW45Y3pXaWUwd3Nk?= =?utf-8?B?OHN6NW1rQnQrL2drdjBldz09?= Content-Type: text/plain; charset="utf-8" Content-ID: <69DCBEE1B6F7B54AA03A8EAD1669B5C7@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d74b016-ab14-4093-7602-08d8f44d52bc X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2021 14:00:20.9790 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VlAjnL6ac/H5C9CkqFl3soVcuSD5ps+K7fKS6TJGqcR/5YWo64jme32+v1+2y0ZzOC2HSbpm7MlT7y0ZUa4HmXZZP0P1WhPJVoPcbEy6jAI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5910 X-OriginatorOrg: citrix.com DQoNCj4gT24gTWFyIDMxLCAyMDIxLCBhdCAyOjU0IFBNLCBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMzEuMDMuMjAyMSAxNTo1MiwgSWFuIEphY2tzb24g d3JvdGU6DQo+PiBHZW9yZ2UgRHVubGFwIHdyaXRlcyAoIlJlOiBbUEFUQ0hdIENIQU5HRUxPRy5t ZDogTWFrZSBQViBzaGltIHNtYWxsZXIgYnkgZmFjdG9yaW5nIG91dCBIVk0tc3BlY2lmaWMgc2hh ZG93IGNvZGUiKToNCj4+PiBJIGRvbuKAmXQgdW5kZXJzdGFuZCB3aHkgdGhlIHR3byBvZiB5b3Ug YXJlIGRvd25wbGF5aW5nIHlvdXIgd29yayBzbyBtdWNoLiBZZXMsIHRoZXNlIGFyZSBhbGwgb25s eSBpbmNyZW1lbnRhbCBpbXByb3ZlbWVudHM7IGJ1dCB0aGV5IGFyZSBpbXByb3ZlbWVudHM7IGFu ZCB0aGUgY3VtdWxhdGl2ZSBlZmZlY3Qgb2YgbG9hZHMgb2YgaW5jcmVtZW50YWwgaW1wcm92ZW1l bnRzIGNhbiBiZSBzaWduaWZpY2FudC4gIENvbW11bmljYXRpbmcgdG8gcGVvcGxlIGp1c3Qgd2hh dCB0aGUgbmF0dXJlIG9mIGFsbCB0aGVzZSBpbmNyZW1lbnRhbCBpbXByb3ZlbWVudHMgYXJlIGlz IGltcG9ydGFudC4NCj4+IA0KPj4gSSBhZ3JlZSB3aXRoIEdlb3JnZSBoZXJlLg0KPj4gDQo+PiBU aGVyZSBhZSBhIG51bWJlciBvZiByZWFzb25zIHdoeSBiZWhpbmQtdGhlLXNjZW5lcyB3b3JrIHdp dGggbGl0dGxlDQo+PiAoaW50ZW50aW9uYWwpIHVzZXItdmlzaWJsZSBpbXBhY3QgYXJlIHVzZWZ1 bCB0byBub3RlIGluIHRoZQ0KPj4gQ0hBTkdFTE9HLm1kLiAgV2l0aCBteSBSZWxlYXNlIE1hbmFn ZXIgaGF0IG9uIEkgd291bGQgbGlrZSB0byBzZWUsIGZvcg0KPj4gZXhhbXBsZSwNCj4+IA0KPj4+ PiArIC0gRmFjdG9yZWQgb3V0IEhWTS1zcGVjaWZpYyBzaGFkb3cgY29kZSwgYWxsb3dpbmcgUFYg c2hpbSB0byBiZSBzbGltbWVyDQo+PiANCj4+IHNvbWV0aGluZyBhYm91dCBodGlzIHdvcmsgaW4g dGhlIENIQU5HRUxPRy5tZC4NCj4+IA0KPj4gSURLIHByZWNpc2VseSwgYW5kIEkgZG9uJ3QgdGhp bmsgR2VvcmdlIGRvZXMgZWl0aGVyLCB3aGF0IGEgZ29vZCBhbmQNCj4+IGFjY3VyYXRlIHN0YXRl bWVudCBpcy4gIEJ1dCBJIGd1ZXNzIHdlIHdpbGwgZ28gd2l0aCB0aGUgdGV4dCBhYm92ZSBpZg0K Pj4gd2UgZG9uJ3QgZ2V0IHNvbWV0aGluZyBiZXR0ZXIuDQo+IA0KPiBBdCB0aGUgdmVyeSBsZWFz dCB0aGUgcGFydCBhZnRlciB0aGUgY29tbWEgb3VnaHQgdG8gYmUgZGVsZXRlZC4gQXMNCj4gc2Fp ZCBpbiBhbiBlYXJsaWVyIHJlcGx5LCBhdCBsZWFzdCB0aGUgc2hpbSBkZWZhdWx0IGNvbmZpZyBk aXNhYmxlcw0KPiBzaGFkb3cgY29kZSBhbnl3YXksIHNvIHRoZSBmYWN0b3Jpbmcgb3V0IGhhcyBu byBlZmZlY3QgdGhlcmUuDQoNClRoYW5rcy4gIFNvIHdoZW4geW91IHdyb3RlIHRoZSBzZXJpZXMs IHdoYXQgd2FzIHlvdXIgbW90aXZhdGlvbj8gIERpZCB5b3UgaGF2ZSBhIHBhcnRpY3VsYXIgdGVj aG5pY2FsIG91dGNvbWUgaW4gbWluZD8gIE9yIGRpZCBpdCBqdXN0IGJvdGhlciB5b3UgdGhhdCB0 aGVyZSB3YXMgSFZNLW9ubHkgY29kZSBpbiBhIFBWLW9ubHkgYnVpbGQ/IDotKQ0KDQogLUdlb3Jn ZQ== From xen-devel-bounces@lists.xenproject.org Wed Mar 31 14:01:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 14:01:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103971.198337 (Exim 4.92) (envelope-from ) id 1lRbPU-0000KJ-Pr; Wed, 31 Mar 2021 14:01:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103971.198337; Wed, 31 Mar 2021 14:01:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbPU-0000KC-Mb; Wed, 31 Mar 2021 14:01:28 +0000 Received: by outflank-mailman (input) for mailman id 103971; Wed, 31 Mar 2021 14:01:27 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbPS-0000K7-UD for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 14:01:27 +0000 Received: from aserp2120.oracle.com (unknown [141.146.126.78]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0ff3aa7c-401e-4101-be35-1417a5e2d4c0; Wed, 31 Mar 2021 14:01:26 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12VDxmmm008905; Wed, 31 Mar 2021 14:01:24 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 37mabqtbe6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Mar 2021 14:01:23 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12VE0g1K085672; Wed, 31 Mar 2021 14:01:22 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2169.outbound.protection.outlook.com [104.47.56.169]) by userp3020.oracle.com with ESMTP id 37mac5h7ep-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Mar 2021 14:01:22 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) by BY5PR10MB4195.namprd10.prod.outlook.com (2603:10b6:a03:201::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Wed, 31 Mar 2021 14:01:20 +0000 Received: from BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721]) by BYAPR10MB3288.namprd10.prod.outlook.com ([fe80::f489:4e25:63e0:c721%7]) with mapi id 15.20.3977.033; Wed, 31 Mar 2021 14:01:20 +0000 Received: from [10.74.103.42] (138.3.201.42) by BN9PR03CA0715.namprd03.prod.outlook.com (2603:10b6:408:ef::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.27 via Frontend Transport; Wed, 31 Mar 2021 14:01:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ff3aa7c-401e-4101-be35-1417a5e2d4c0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=3CjV/fvMPSbaHRFMTYdWoBAjEA0EC1AQkTSb4Lqo0vQ=; b=YuiRTtFlzOFIaJhaWKvdkB8A4SYkojo16tIcGJAPp8UQhNoW8/whNDy3cri49ktmeEK9 pkiJnJx7xVouvdST5erbzJZkkAPSOtuTP4/ECjw2/00eeN/rNZMkfbdmLpxZIqT9o3AY nms85Mfnp/iGo6l+FEzrFg21Ti7DejP+2Htr5tLfzlJCuKIs9LOOE+SZcw/qkNmq3LsM Sibh9DLMp753TMOX/D2+qxklSTZc8BWNzcKK5c1DriJUdTg7B20IJm0SlHFD6vED738L +OFvMPGXt7rwYxdofOprIkXT0dKFgM1rtzl6t0jDLS8GvVQgBzVShkNPbg1utRAdwfhr Eg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S004wky02kJsqyqJtTikQmaZ7gB/ccIk3wQ9mzTJEGZZjVJSUn53ippMkGa8/Bm3BKD6H/lP8IwhaOxT2z2Sb9OWtlSny9F6bnbkli8CoS5xmOg90b6ETeX+euCW++XNfhge8QGtEgwc8uhMjHK+scK54y04pswa6GsArglYZvSq2fTqldyGmijmvsi1GKaZK3cQtOgd59NG/7t/a8xAI96a9Ueg9a5GYOdkho+VecfmvmW9s6UtLU+z01/EAUgwKlIanoos3vDpKGdIEx5T8TvTj/VJoZqJod8kH6ndjtgkQGoFNcZOqRf44/aKUy9WF7YzOIvcsiyLNKprI/Y9Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3CjV/fvMPSbaHRFMTYdWoBAjEA0EC1AQkTSb4Lqo0vQ=; b=OlaprLfd42pMacwL5VoCgfqFtL2wPTwQ4glzKB9Epma/DgTS4jiaS2Km1uxb1HCn+0ozgUz20eTmgmRCXV84GwlnmfTP6TJQOnf59l+8XO5zAxVBMS6SX0UWk88aW77ODW2iVwCPuLTDkOzvD41+3Nr28e6LjEMv3Dbnoc0S9f76r+C68/p+NFdkKYJgGJL0absaLuA52MU4XESbmAbUbPTrtFkJ+mKO+M7COChmYRMFg9/CBIWN0Tk7GubmwQUyiLYKISPkHDFftnzOHLkkYEe30KASHAgrIFQvwB4fI5nGxLfeWnMwLvrqUbolvOdhUbodlO9TX8ju3b482eB0eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3CjV/fvMPSbaHRFMTYdWoBAjEA0EC1AQkTSb4Lqo0vQ=; b=zaRtMQUXBRCZwgtkPFQDgXG5zSfQkk62qlCQWZGnYvRumHO1NkUk2d8N2uIpiDq1DZEqX8LlD43UU2TTJw5bctkYmTCHBM13bZ7MLS2ysY/N87UCPekdFwDddUjf9pj8aSaB7kqNmBuX8THMqG7fJqwOOFY26p1tqWvDUqClgzk= Subject: Re: [PATCH RESEND] Performance regression due to XSA-336 To: Hongyan Xia , xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, stephen.s.brennan@oracle.com References: <1616619905-640-1-git-send-email-boris.ostrovsky@oracle.com> From: Boris Ostrovsky Message-ID: Date: Wed, 31 Mar 2021 10:01:15 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [138.3.201.42] X-ClientProxiedBy: BN9PR03CA0715.namprd03.prod.outlook.com (2603:10b6:408:ef::30) To BYAPR10MB3288.namprd10.prod.outlook.com (2603:10b6:a03:156::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 78c61389-232b-4f45-4a2e-08d8f44d75fa X-MS-TrafficTypeDiagnostic: BY5PR10MB4195: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 91BVVTV5HykDyeHBgw/4drZvzu7uA95y5A5Z29aaWnvs0dL2ESuNhunxZzrI6UX3iW7rPtNpNcpRQhK9vVLFlWN8qRzK6p2vqTb6XeJJk4zeg7bOSqYZbaiMCMh9kiXKDzOpm+xn2KUyTCqAIYVrSZI1AGQ8SOKbMmpa1JhTYh+4zdKUTehDtV6NQFFsU0MhKM+7MN2GZtSMLijBuTCLNX+quxTFT2gVZAz70O545hVqXsWdFkDUWFITEwZGYx8/+BXYZCNu791tEqFC1IFAYEwwWiHAjA58vAfEh8M5Cghl85YDAbor5wNSd3GIJcZ0dDNKy0MGf965YglY0EYYr6fbgVktb1gMyhp48+ptZrUfXcE0AAzr+AJyoYlBNQ99mKutHhmDd2XM60uKgqmq81NOJbDeOvbq0WQhEbSs6sDpH746/HzcZ4XqYOHVWWCs4XE23ShSyaR2cSol8lGONOSwqw83/C0aWZ0TTG+2rrLRyDqxB43Qqh+OATBSwr/p8g1j9bKPINWB0XESIT/gOWDV/r8n9tEOJwxNrvDh0Q9hBILV5/lK//HVWkRoBu8HoN7cNmQlxIOIjaiy+PFKNFB4eELKkbIdZinsE3L7LUu0wEESeWpZGelWsWDLsc0VNHvWNDsNARWiqiloQqduIZ/sbsihPDrorrN0iC/vEExrEHl0mWzaK0sIkhoMQEaCuixfrphNuBmJHNoxvP7deN1eNfjS1LlmkZCFjW6ki34= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3288.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(366004)(39860400002)(396003)(136003)(478600001)(316002)(36756003)(2906002)(8676002)(186003)(31686004)(38100700001)(107886003)(53546011)(2616005)(8936002)(44832011)(66946007)(16526019)(66476007)(31696002)(956004)(6486002)(26005)(86362001)(6666004)(5660300002)(4326008)(66556008)(16576012)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?d2JocWtrRzVxSGFMbkovZTBBeDFmOTBpTkVCUmZjbVpZRGVtcjAybHM1akZv?= =?utf-8?B?ME5OYi96V2NEM2RsMit2Tk1pOVJSRWIrMjJqWG5BdW9GUjc1Sk10dC9iZ2Q3?= =?utf-8?B?cmRhSGIxdlpYb1d0TzVhNzhFdnh4Ni95TTR6RUliNFE4SDJOL3lQRTJSMFU0?= =?utf-8?B?Y2U0ZEk4RzN3WmdLRTlORDI3TDBHMGh5RGJqVjVBNHNGNDFNZEtLbmVTREpq?= =?utf-8?B?RjVrdVJWQVBTb1hzeFQzRXFUY1hKZUpJSW5Bc3ZqMG90TjJ3eXJXcGUxcHJX?= =?utf-8?B?d3FxQjlWMVl3Z2JQSE5IQ0xyL05LdjZnczZvb2J0WDIxbmZFeXlkUmNlQU0w?= =?utf-8?B?K0t6aGIrOGxlakl2dkYrYnMvZEFrczJCeFZaV054Q3dJVjlmbG5kbm9NQ3cy?= =?utf-8?B?OVhSV0xqNnZKeElJNnVPQXY3MStsT1JGZHBaQzl1cHZmU2M2QnJWbXFZTkxl?= =?utf-8?B?d1FIbEhGU0owNitwSUZlZHMwZFlEOVBpQVRLVGlLSkVlQXM3NVlXaWtDZWRI?= =?utf-8?B?VjlYY2tsbHM0citIK2taKy9mWWswWmdyOGNtRzJWRFJxakFkQ1ptWGVYaHcz?= =?utf-8?B?ZFg3dnBzYkV6eHkwT1c1R1hkTmljZjk3eS91R3dZZWMrQmpyRmZlMEcvSEhT?= =?utf-8?B?QzdJazY3OFZsVXFKZUJsdGt2TFp3T1lFZ0xpNGxlRmkwSHlpMDVGWFgvdDdv?= =?utf-8?B?bi9ncGpQK0dnN3dabFpEeE5SYnkva1l4dXJWNnpuY29XeUNLb25JcElSSmZx?= =?utf-8?B?ZHRHYjhOQmdYR0Jhb1h3L0NXVlJuQ0JTajh0UWtrdzZBdExaQ0NEQkRvcjNW?= =?utf-8?B?R3dKQ3B3L0ZkdVcrVjBoT1BKY250b1ZOdEUvc0VJL3lyM09zMHNkMXRWQjlI?= =?utf-8?B?cnlXdWVJU0lJcEY5RDVUYy9Hczk4eUFHd0R2amtpT1ZHT3RWVGtwOWtsN0p4?= =?utf-8?B?UFhYY1M4NkZKR2J3eUk0MlJmVEFzS3d1Vys3VktBVzF0V0RJRFhPYWNlazho?= =?utf-8?B?UTFZWGFvcEdlYWlmMEVLZFdCY1RBYWlsNHRWbnEwdUlHRjlOZ3lVdjZtbnVl?= =?utf-8?B?R2R5NzlobmozWGF2TlNOTFZ0VG1KNXEyWjRsZW5qOWI2cTgzM2VxQU5TdWdO?= =?utf-8?B?YXVncWNvVzQ5RExCcTNGdHU0cDJmdFcrTjNDNTFqWGtPbWNBckpucVZ2ZlVj?= =?utf-8?B?VS9wY2tPcENHU05oVWZWajNGUXJHVVZHK0hwbHNmOFdyWGgrU3B2MVhKcWZK?= =?utf-8?B?Y0gzaFp0V3ZkTGs0V2orMGNiamZPR0lPRmdSQmFwaFROQjI3K3NQLzlKWFYy?= =?utf-8?B?cWc2UUd0T2daWDdQS05BZ1pzRWNTN3ZjS3UwejhwQ2NLdDYwMmhRQ0FyUjVC?= =?utf-8?B?TlBSTFZtRlJ1YlNTSXVlRlhUd1RXTWdCTUlya0NDMlZlVTJUL2VoQkZUVFh3?= =?utf-8?B?b2xYelowRnpZSDR0U1UyY0lsNXArTHkvQnY5R21FY2R3NjByREp5K2tYaGtN?= =?utf-8?B?NnVNMFdPRW8xQzJyTzN3VnNob2dWSlZueWNMZDZXbGpCVjAzaUpsZXQrQ3ht?= =?utf-8?B?UlFtdXNMV0h4UUs1UThDYlh2emtaWmpjZEh0K016Z3NYMFRvekgzeVczanNi?= =?utf-8?B?UEErclNFbzBmUHMwQWRwNWV1TnpZWWRDTkVTdU8xSXMvcnlqNUNXUzNKT1Vv?= =?utf-8?B?Z0RpVkpLZ2VaUDcyYTNsSTQzc1JVWThuZ0krZW04bnlwbGNVYVpkcEZsaHpv?= =?utf-8?Q?6OxRwk8wgkEFHOC2FFnN/SJj5AOIBfJWjGIqOkv?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78c61389-232b-4f45-4a2e-08d8f44d75fa X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3288.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 14:01:20.2751 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Yk1cwaC40xYFTu/E/v5Dh5rhW8FHC+TZZCyo4s3QI4k1sEYmtOsint+8sn96oFhVUhJKI1KqapiRWMQL4W5lcCvCVbn5obctvWlLZTVjDX8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4195 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9940 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 mlxscore=0 suspectscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103300000 definitions=main-2103310103 X-Proofpoint-ORIG-GUID: bXlxe1fC8Px44dx9GvBCB1TGf3dkDZ-B X-Proofpoint-GUID: bXlxe1fC8Px44dx9GvBCB1TGf3dkDZ-B X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9940 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 suspectscore=0 adultscore=0 mlxscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103300000 definitions=main-2103310103 On 3/31/21 5:53 AM, Hongyan Xia wrote: > Thank you for the patch. We observed similar issues. > > However, would you mind sharing more details on the test setup? We > tested the hypervisor after injecting XSA-336. There were regressions > in some benchmarks but far from being enough to raise a serious alarm. > In particular, we benchmarked CPU, disk I/O, network and timer > performance on VMs with 64 and even 128 vCPUs and the noticeable > regression was a 60% drop in the ACPI PM timer when all vCPUs are > actively accessing the timer. We did not see concerns in real-world > benchmarks so I am curious how the -40% was seen. We tested two guest kernel versions and observed this regression only on one (older) kernel. The newer one showed almost no change so this appears to be quite sensitive to guest kernel. Unfortunately it is not easy to get access to the test rig so I wasn't able to do a more thorough investigation of kernels' behavior. This was mostly done by staring at the code, making some changes and getting in line to have the test run. > > Is it possible that the guest itself was using ACPI timer as the > clocksource? No, we never use it. > That could explain a lot. It might also be useful to know > what OS that was and other specs around the -40%. Guest OS is Oracle Linux 6 (I think we also tried OL7 with same results), the kernel is a modified 4.1. Skylake processor, few hundred GB of memory. Benchmark is TPCC. -boris > > Thank you, > Hongyan > > On Wed, 2021-03-24 at 17:05 -0400, Boris Ostrovsky wrote: >> (Re-sending with Stephen added) >> >> >> While running performance tests with recent XSAs backports to our >> product we've >> discovered significant regression in TPCC performance. With a >> particular guest >> kernel the numbers dropped by as much as 40%. >> >> We've narrowed that down to XSA-336 patch, specifically to the >> pt_migrate rwlock, >> and even more specifically to this lock being taken in >> pt_update_irq(). >> >> We have quite a large guest (92 VCPUs) doing lots of VMEXITs and the >> theory is >> that lock's cnts atomic is starting to cause lots of coherence >> traffic. As a >> quick test of this replacing pt_vcpu_lock() in pt_update_irq() with >> just >> spin_lock(&v->arch.hvm_vcpu.tm_lock) gets us almost all performance >> back. >> >> Stephen Brennan came up with new locking algorithm, I just coded it >> up. >> >> A couple of notes: >> >> * We have only observed the problem and tested this patch for >> performance on >> a fairly old Xen version. However, vpt code is almost identical and >> I expect >> upstream to suffer from the same issue. >> >> * Stephen provided the following (slightly edited by me) writeup >> explaining the >> locking algorithm. I would like to include it somewhere but not >> sure what the >> right place would be. Commit message perhaps? >> >> >> Currently, every periodic_time is protected by locking the vcpu it is >> on. You >> can think of the per-vCPU lock (tm_lock) as protecting the fields of >> every >> periodic_time which is attached to that vCPU, as well as the list >> itself, and so >> it must be held when read or written, or when an object is added or >> removed >> to/from the list. >> >> It seems that there are three types of access to the peridic_time >> objects: >> >> 1. Functions which read (maybe write) all periodic_time instances >> attached to a >> particular vCPU. These are functions which use pt_vcpu_lock() >> after the >> commit, such as pt_restore_timer(), pt_save_timer(), etc. >> 2. Functions which want to modify a particular periodic_time object. >> These guys >> lock whichever vCPU the periodic_time is attached to, but since >> the vCPU >> could be modified without holding any lock, they are vulnerable to >> the bug. >> Functions in this group use pt_lock(), such as pt_timer_fn() or >> destroy_periodic_time(). >> 3. Functions which not only want to modify the periodic_time, but >> also would >> like to modify the =vcpu= fields. These are create_periodic_time() >> or >> pt_adjust_vcpu(). They create the locking imbalance bug for group >> 2, but we >> can't simply hold 2 vcpu locks due to the deadlock risk. >> >> My proposed option is to add a per-periodic_time spinlock, which >> protects only >> the periodic_time.vcpu field. Whenever reading the vcpu field of a >> periodic_time >> struct, you must first take that lock. The critical sections of group >> 1 (your >> "fast path" functions) would look like this: >> >> 1. lock vcpu >> 2. do whatever you want with pts currently on the vcpu. It is safe to >> read or write >> fields of pt, because the vcpu lock protects those fields. You >> simply cannot >> write pt->vcpu, because somebody holding the pt lock may already >> be spinning >> waiting for your vcpu lock. >> 3. unlock vcpu >> >> >> Note that there is no additional locking in this fast path. For group >> 2 >> functions (which are attempting to lock an individual periodic_time), >> the >> critical section would look like this: >> >> 1. lock pt lock (stabilizing the vcpu field) >> 2. lock vcpu >> 3. feel free to modify any field of the periodic_time >> 4. unlock vcpu (due to the mutual exclusion of the pt lock, we know >> that we are >> unlocking the correct vcpu -- we have not been migrated) >> 5. unlock pt >> >> For functions in group 3, the critical section would be: >> >> 1. lock pt (stabilizing the vcpu field) >> 2. lock current vcpu >> 3. remove from vcpu list >> 4. unlock vcpu. At this point, you're guaranteed that the vcpu >> functions >> (callers of pt_vcpu_lock()) are not accessing your pt. >> 5. assign pt->vcpu (we still have mutual exclusion against group 2 >> functions) >> 6. lock destination vcpu >> 7. add to vcpu list >> 8. unlock destination vcpu >> 9. unlock pt >> >> If functions from group 2 and 3 are less frequent, then you won't see >> too much >> added lock overhead in this situation! Plus, even if group 2 and 3 >> are somewhat >> common, the performance overhead of an uncontented fine-grained lock >> is muuch >> smaller than the overhead of a heavily contended coarse-grained lock, >> like the >> per-domain rw lock. >> >> >> Boris Ostrovsky (1): >> x86/vpt: Replace per-guest pt_migrate lock with per pt lock >> >> xen/arch/x86/emul-i8254.c | 2 + >> xen/arch/x86/hvm/hpet.c | 1 + >> xen/arch/x86/hvm/hvm.c | 2 - >> xen/arch/x86/hvm/rtc.c | 1 + >> xen/arch/x86/hvm/vlapic.c | 1 + >> xen/arch/x86/hvm/vpt.c | 122 +++++++++++++++++++++++--------- >> ---------- >> xen/include/asm-x86/hvm/vpt.h | 9 +--- >> 7 files changed, 74 insertions(+), 64 deletions(-) >> From xen-devel-bounces@lists.xenproject.org Wed Mar 31 14:03:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 14:03:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103977.198348 (Exim 4.92) (envelope-from ) id 1lRbR5-0000T7-AM; Wed, 31 Mar 2021 14:03:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103977.198348; Wed, 31 Mar 2021 14:03:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbR5-0000T0-7B; Wed, 31 Mar 2021 14:03:07 +0000 Received: by outflank-mailman (input) for mailman id 103977; Wed, 31 Mar 2021 14:03:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbR3-0000St-JM for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 14:03:05 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 647a201c-3ea3-4352-a043-4d5398091e99; Wed, 31 Mar 2021 14:03:04 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DB6F6B270; Wed, 31 Mar 2021 14:03:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 647a201c-3ea3-4352-a043-4d5398091e99 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617199384; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m0wEriq9iFOnD68mNAtBmUmWQ3lCURXb3bswRldYuXA=; b=qJLs5/OeacrcPiBDOXO/+WgHXcGWhLXtt7DYv951+W88Y1xrSqyWGNKGby7e9cn6GFdjN3 cMIh2o6Nkc+PaOnOlWlZD+jT0il8PsvOkpY4LeAjyEyPxRU/caD1jU9gnJnuLqNvPWoHIL NfcubHBPAWHhE46X5adFHg3w5S8Zgd0= Subject: Re: [PATCH] x86/hvm: Fix double free from vlapic_init() early error path To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20210331133125.7072-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <95d8688b-2e54-ae02-09ce-45203959e08a@suse.com> Date: Wed, 31 Mar 2021 16:03:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210331133125.7072-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 31.03.2021 15:31, Andrew Cooper wrote: > vlapic_init()'s caller calls vlapic_destroy() on error. Therefore, the error > path from __map_domain_page_global() failing would doubly free > vlapic->regs_page. I'm having difficulty seeing this. What I find at present is rc = vlapic_init(v); if ( rc != 0 ) /* teardown: vlapic_destroy */ goto fail2; and then fail3: vlapic_destroy(v); fail2: Am I missing some important aspect? > Rework vlapic_destroy() to be properly idempotent, introducing the necessary > UNMAP_DOMAIN_PAGE_GLOBAL() and FREE_DOMHEAP_PAGE() wrappers. > > Rearrange vlapic_init() to group all trivial initialisation, and leave all > cleanup to the caller, in line with our longer term plans. Cleanup functions becoming idempotent is what I understand is the longer term plan. I didn't think this necessarily included leaving cleanup after failure in a function to it caller(s). At least in the general case I think it would be quite a bit better if functions cleaned up after themselves - perhaps (using the example here) by vlapic_init() calling vlapic_destroy() in such a case. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 31 14:06:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 14:06:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103980.198361 (Exim 4.92) (envelope-from ) id 1lRbUI-0000eX-Qc; Wed, 31 Mar 2021 14:06:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103980.198361; Wed, 31 Mar 2021 14:06:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbUI-0000eQ-NU; Wed, 31 Mar 2021 14:06:26 +0000 Received: by outflank-mailman (input) for mailman id 103980; Wed, 31 Mar 2021 14:06:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbUH-0000eJ-By for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 14:06:25 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8735c65c-c5da-490a-aae1-f8c2ca817dc0; Wed, 31 Mar 2021 14:06:24 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B6AB2B270; Wed, 31 Mar 2021 14:06:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8735c65c-c5da-490a-aae1-f8c2ca817dc0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617199583; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+QpEtAifekDShYETGEvojnZoC/tZl+b+wwBjFr0RoNw=; b=EDfplck+fgQJmzNPptoZqa+FshwE1arGKAe9w9nw2ALhGJWGshRdMVHEgvypjHnbqPIRib kseY/goHW+KWfF8kRwQlAd1X+ORqoOLG7YtQL+jmRAmqIGBAFIiy7Ew5AG6xgXOK7zGS2T ef28Yn4T2oz9dGQLN1jHMeQBD52nwoU= Subject: Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code To: George Dunlap Cc: Ian Jackson , Andrew Cooper , Roger Pau Monne , "xen-devel@lists.xenproject.org" , Paul Durrant References: <20210324172608.302316-1-george.dunlap@citrix.com> <23461afc-c0e0-eb33-9ed3-52f050b6aef0@suse.com> <27ecde00-f0aa-b701-6928-5480ed805064@citrix.com> <2A1FCD39-D0C0-468D-A977-2FBF7126FDE6@citrix.com> <24676.32400.548088.26254@mariner.uk.xensource.com> <1a87cfa9-d6c0-5da5-ea07-eae47186da9a@suse.com> <1832DBFA-B215-4CEA-9C8A-F53F2A5321E9@citrix.com> From: Jan Beulich Message-ID: <9b899068-e0df-3f5f-5537-b9ff81bfa279@suse.com> Date: Wed, 31 Mar 2021 16:06:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <1832DBFA-B215-4CEA-9C8A-F53F2A5321E9@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 31.03.2021 16:00, George Dunlap wrote: > > >> On Mar 31, 2021, at 2:54 PM, Jan Beulich wrote: >> >> On 31.03.2021 15:52, Ian Jackson wrote: >>> George Dunlap writes ("Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code"): >>>> I don’t understand why the two of you are downplaying your work so much. Yes, these are all only incremental improvements; but they are improvements; and the cumulative effect of loads of incremental improvements can be significant. Communicating to people just what the nature of all these incremental improvements are is important. >>> >>> I agree with George here. >>> >>> There ae a number of reasons why behind-the-scenes work with little >>> (intentional) user-visible impact are useful to note in the >>> CHANGELOG.md. With my Release Manager hat on I would like to see, for >>> example, >>> >>>>> + - Factored out HVM-specific shadow code, allowing PV shim to be slimmer >>> >>> something about htis work in the CHANGELOG.md. >>> >>> IDK precisely, and I don't think George does either, what a good and >>> accurate statement is. But I guess we will go with the text above if >>> we don't get something better. >> >> At the very least the part after the comma ought to be deleted. As >> said in an earlier reply, at least the shim default config disables >> shadow code anyway, so the factoring out has no effect there. > > Thanks. So when you wrote the series, what was your motivation? Did you have a particular technical outcome in mind? Or did it just bother you that there was HVM-only code in a PV-only build? :-) What bothers me are more the implications - it being rather hard in many cases, and in particular in shadow code, to be able to tell what paths are involved in the handling of what kind(s) of guests. This has made more time consuming investigation of (suspected) misbehavior in more than one case. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 31 14:30:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 14:30:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103983.198373 (Exim 4.92) (envelope-from ) id 1lRbrh-00039q-Sw; Wed, 31 Mar 2021 14:30:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103983.198373; Wed, 31 Mar 2021 14:30:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbrh-00039j-P1; Wed, 31 Mar 2021 14:30:37 +0000 Received: by outflank-mailman (input) for mailman id 103983; Wed, 31 Mar 2021 14:30:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbrh-00039e-1O for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 14:30:37 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0fd5cae3-7c8a-4f30-87be-a2b5bcdacce0; Wed, 31 Mar 2021 14:30:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fd5cae3-7c8a-4f30-87be-a2b5bcdacce0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617201035; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=29MeVBnAQCnCL295KsDDathRGJRlDhNRAbNep5HZn1Q=; b=fuRIrA5orwvTag9FHutZPewBdW4bsScX6ZtUHPxPHgGFWTwjh5AHZSg8 xtuyqOjAUGIA/QM/3afsXn3BlVdKS3F030m9CThqfXwLhEDG/Qxhtx41L n77toHJTDddmlccoMd/RaKMlI/aMULU5OtFMSEp/VeSzbm2a3obM8fkUY A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: opiIlWuT8OSTnTHdCWAYUl+hML+XNx1B74DF3BJoDLioUJXJI1Ib/1uBUKlpqZQRwWYtYrAB0X 1nIUtbTFRnS+froMnqRd5wY+j7RaFCqMbqWExcyQK6LlqNLe804w75tHPhZfBqrQdiK8+9a/0q MIbu6l+F/m6PRGNY0BwJzQ1+80OPqrWecdDFFkF5eTs+BQ02jwVMo3Q25e0/psphgbMb18TTfM l97EAAk3NLqOFMjj1RtRrBLu86n2gtnHlbuKQzI2fOnBy0nd3K9uZTmq5AwIvm/GgpT+wwARua Pk8= X-SBRS: 5.2 X-MesageID: 40441364 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:oN1SxqxFQA7rBlPLO/8vKrPxpe4kLtp033Aq2lEZdDV8Sebdv9 yynfgdyB//gCsQXnZlotybJKycWxrnmKJdybI6eZOvRhPvtmftFoFt6oP+3ybtcheVysd07o 0lSaR3DbTLZmRSpczx7BCkV/Mpx9ea+K6l7N2utEtFZysCUdAC0y5SDAGHHkpqACxPApQkHJ SRj/A33QaIU3IRc8i9Gz05T/HOzue73q7OTDwnI1oc6AeIhS6187KSKXSl9zoXTj8n+8ZEzU HriAr8j5/Dj9iazVvm23bX/9BqnrLau6N+LeitruRQFTn2kAavY+1aKvC/lRQ4uvum5lpvsP SkmWZHA+1J53ncfn64rHLWsmGOvgoG0HPsxUSVhnHuu6XCNUsHIvBcjoFUeAax0TtDgPhA0b lG12/cl51bAQKoplWY2/H0VgpnnkfxnHw6keR7tQ07baIibtZqzbA3zQdwKtMtDSj64IcoHK 1FF8fH/stbdluccjTwonRv6MbEZAV9Ij62Bmw5/uCF2Tlfm350i2ECwtYEo3sG/JUhD7FZ+u X/NLhynr0mdL5ZUYtNQMM6BeenAG3ERhzBdEiIJ078Ka0BM3XR77n6/asy/+PvXJAT1pM9lN DgXTpjxC8PUnOrLffL8IxA8xjLTmn4dy/q0Nti659wvaC5S6HsNSGFVVAyg8qtq/gSGaTgKr WOEaMTJ8WmAXrlGI5P0QG7cYJVM2MiXMocvct+W1/mmLOIFqTa8sjgNNrDLrvkFjgpHknlBG EYYTT1LMJcqkSiWnryhgnNS2rgE3aPuK5YIez/xaw+2YINPopDvkw+klKi/PyGLjVEr+gxZ0 txILTul6uhvmmo9WPU72FkUyAtTnp90fHFaTdntAUKO0T7ffIooNOEY11f23OBO1tiVc/MCR VeoF524KqzKJSVyUkZepaaG1Pfq0FWiGOBTp8alKHG2NzsfYkgCI06HIZrEx/QKhBzkQF2iW tKZQMeXHXDHjf2hajNtu1SOMjvM/1HxCaiO4p9tG/Wv0T0n7BTelIrGxqVFfOxrSlrbTxOnV F1+7IYm9O76EqSAFp6pv85Pl1KYHmQG5RcAm2+Fclps7j2ZQB9SnqLjzSGixc1PnHn7VkWm3 aJF1zqRdjbRlVaoXxWyaDs7Rd9cXicZVt5bjRgvZR6DnmugAc67cabIq6y2XCWcF0M36UUNy zEeyIbJmpVtqaK/Q/QnDaJDnM9wJoyeuTbEbQ4arnWnnegMpeBm61DH/ha+v9eRZnTm/5OVe KUYAmOKjzkT+svxgyOv34gfDBut2NMq4Kc5DT1qGyjmHIvC/vbJ1prA7kdPtGH9mDhA/KFyo 9wg945tfa5W1+BIeKu2OXSdXpOOxnTqWm5Q6UzpZdYsbk7ubFzE5PYOAG4o01vzVE7NoP5hU keSKN07PTdIYdpZdUVYD8c8VwzltiDRXFbwDDeE6s7ZxUqgHDaNd/SvOaNprorH0GbpAz/fV OY6DZQ+v/ZXy2Fkb4WYphAUVh+eQw58jBl+ujHaojbTAOtfOtH9EChMnC8fKRGIZL1bYk4v1 J/+ZWQg+STdyDkwwjesjtwP7JW/w+cMLKPKRPJHfQN7sezNluNiLa7+cK/jD/4Tj2gdkQT7L c1BnA4f4BEkTktjIo+zyi0ROj2uyse4iVj3Q0= X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40441364" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IZ2ZVcmzwtVdhSN2Fh6G9t5pJP2Ghl27OI/ziwciDFn5e3xtMgRz224dMsQNAyNbd4TLO22HYJ+64EraFIP1MNG8mjZ2W4OsLSv+j5eHlV/JN62lL5c3ngltL3JrSKzK1hEpwaKVpeBPC0JKmXXFm1tPgQtrxsr5nXbrslZOgLtnIkmKYLFtmaD+upI1zXEz/bIFtLqniCtVPDrSmZRNyc4FeGiNMVZ50DXf+Nyd7edvrycdfotqkuXZycBqXIwRUiJUT7ft232eJVzSDXMwU0gQH06qb5uSbucFPPwezIPFU5QSi44mifQkUnwI9lCX59I3TRHrWBY+vDnQyddtWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=29MeVBnAQCnCL295KsDDathRGJRlDhNRAbNep5HZn1Q=; b=gW6zSJWHd3Ur4iUsMzSrFEggIm6FdNKKDFJCPVN/vBvpnzAfChImSq6Xzn8cfoRU3J88idW4yrAhnxKLWZEQFmpgiKDBQ0koa84Tmp1RDNXywXdOZNSw0X/oRsxCwQOMzIiiHuF0HAvekxa5VNgmu6dvTzpj7f3t2couTP2HpSMV7W/DbEbCBI3lHCFW+1ies82XYKMLpuPX0g4uHW1T4nz8PsUhZkW2aWn9P9G6jjjuR9Lf9hiV3H7kwlJ+osCMXCqaekEO+3d7Cg9YORWU7oheMKBAsKEBUs9PL9typOo9iSCAOTlB3GTlBGDM3Ulvt0Xe7c2RvUKSq8DLCDv/kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=29MeVBnAQCnCL295KsDDathRGJRlDhNRAbNep5HZn1Q=; b=Sg15bFGOmVXDpONzHuLyQZVjGUxNd6Vo0Pr/CA0yF8Fw5aBhFHZPOxR0uC3kXpQxSNigfN4cMg0kUM/2ReTJMx+les7o8e1ACRAcId+dtupzTCnZ33AJ+x7vOhzGhKwVFpgtLqtrhUfDspd+l8E7HY3s8lA+v7+10dvhJff5Fk4= From: George Dunlap To: Jan Beulich CC: Ian Jackson , Andrew Cooper , Roger Pau Monne , "xen-devel@lists.xenproject.org" , "Paul Durrant" Subject: Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code Thread-Topic: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code Thread-Index: AQHXINLTS489UfL61EKD4pjlwXnfbqqUSZCAgAbMCwCAABhsgIAAEbyAgAEUfwCAAdQ2AIAAAIoAgAABtoCAAAGygIAABr6A Date: Wed, 31 Mar 2021 14:30:32 +0000 Message-ID: References: <20210324172608.302316-1-george.dunlap@citrix.com> <23461afc-c0e0-eb33-9ed3-52f050b6aef0@suse.com> <27ecde00-f0aa-b701-6928-5480ed805064@citrix.com> <2A1FCD39-D0C0-468D-A977-2FBF7126FDE6@citrix.com> <24676.32400.548088.26254@mariner.uk.xensource.com> <1a87cfa9-d6c0-5da5-ea07-eae47186da9a@suse.com> <1832DBFA-B215-4CEA-9C8A-F53F2A5321E9@citrix.com> <9b899068-e0df-3f5f-5537-b9ff81bfa279@suse.com> In-Reply-To: <9b899068-e0df-3f5f-5537-b9ff81bfa279@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.20.0.2.21) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 89297639-9155-43f6-3347-08d8f4518a3d x-ms-traffictypediagnostic: PH0PR03MB5720: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g5U2jDHRTaNoGp94uDxO4nWfc0fZrjHYY9glFw01OCo4D7Zjwp6a223YbTRiEo2xBfxxijrvVjtVid0dc3fdWbGPHbPhaup/B8BxGkeof5i+kiE+7itr262iT97D4igv8Fr7EWQl94JXzd6rT3S7GD74B12ZqhDG2DyLlrBaaQxoR9VfFvZLD62VgM2EyY/QFNLkpDhEZ2M/ko5f7vYjWqF+lYdKGzlReM9vDnGMunLq1yoBzuOE+PDy+ol3Gh/m75G2PaA4CplfszgzNp9tBib/LgHgKCnzGdKHYBoRdDWX8S6SDaJJaSwJ8fjK4o/wXCIXSpAM2niMdDIOE7RaUyIhbJRoeYc8sqj37LPlIHPSxn9IBs18HUdMjGWkSQ3gbhAqFGil0LR5qxYWrM/RQ9d7NKGxm4pXzp5PzhBFtqSX1f2618+mLCHflZepgj4f0ejgXXU3jHppCbbeM9Tc0VlJneYp1hGGCDswm9etnjEfDmS2xVxso7EgVSEpj/cxCcxb8cFhrUpvPSD01gC0GdoX23Xle8y6dxrENazHb+avt9l/aF9TajnjJ3XRcSglP0SAsbAJnk3u7Q/ZykWqNv0AoSm6rANM1jL3fVw+VCkARVafQkz7etmgziXu5qJ2tDYtuRiKyKTgEMxsG06P1b4ih/F7cEpqv93RAvdq6LJwYRlYzUutTe/RnuJFb4oVt8S7nWmDgRp/2Xn5syP6gPAclHzSo4eLBGxa2oViIFMp7I5k02SJkQF3dQosi6GS x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(376002)(39860400002)(136003)(396003)(5660300002)(316002)(38100700001)(83380400001)(33656002)(107886003)(53546011)(26005)(186003)(8936002)(478600001)(6486002)(6916009)(4326008)(8676002)(6506007)(66946007)(66476007)(66556008)(54906003)(71200400001)(64756008)(66446008)(86362001)(91956017)(76116006)(6512007)(2616005)(36756003)(2906002)(219803003)(207903002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?SDhZckV5L0ZyN1ZUeW96R3hoaFc3NGF3YkpsNXA0V3BzQ093amU4Uk95Q2hv?= =?utf-8?B?MTk5Zzdia2Rld0JtdjYyeXFBY09CQWRLdHdLdzFhVStzUGpFT0JyWncyd3VI?= =?utf-8?B?Sk1KeUUwcWFrUzdkaGR2RElJV0VQN1pxN0dwZEppVVgvZkN0bEFIelZDTlN6?= =?utf-8?B?dnowMHVXZDM1N0FBRE8rZExKczZLc0Q3UE9JeE4rWk1WeDlyYVdQV055NVRQ?= =?utf-8?B?WkM0ZW5ucnA1Y0kzeHFKYmJYdzFhaFMvQkx3VXZ5T1ROUE81d2EvUWc1OUN2?= =?utf-8?B?T2kyKzZ5M0trcGUycldCQWVTanhXdkZ3a2hXd3dvOW9nL0w1UGk3QlVHUkY4?= =?utf-8?B?TkV6OENkSnhFbTFsTTdNUUFKbEsxcFVOQ0RLL1JQUVArYUtrUWJJUnlmYWZh?= =?utf-8?B?VTAxM3g2SXNQTkVQRGo1S1ErNjFFUnhRTzc3eFNTczBjUXJXS0RGM0RTN2M4?= =?utf-8?B?blhJcmNtRjlXQ0FzbCtFdFRvYnlZMDV0RTliVEthdzJRMEoxeXdxOXBuMFF3?= =?utf-8?B?eFhUTkdGVHZyZmY3K3ZMaXFFS0dOZGFray9WSEp5MTFieXRvUEowd2xZQWtD?= =?utf-8?B?Nm90bFM4cWNHOXNnRjZ2aitPelZRdGVnaE1tUkFxSE5oNVFZUmxkelRjRE01?= =?utf-8?B?d0wrSFdGVFo5NUhzWmFVR0hkYU1EN3JiQ2FCWERucTJoZnZpUGhxUjkrUDdI?= =?utf-8?B?alNLeCs1anF3T1BZbUJGSzZRUDc1em5XZ09PTFVQbWY0QzQyNFlTSXhzWXpi?= =?utf-8?B?OERvdlg1eHFmTkxmSHFYTUYzQkR6d1BMazdZdEViUmk2K05XQ0l4enBudjl1?= =?utf-8?B?RWZaMERpa242VHI0czJSSFc1b2ozVGlGMCt4VEMzeDFjQ0l4aThhZ1VVSDN3?= =?utf-8?B?MW1WcktMaitib1daSmFkK3JNOUxQdkpwc201d0RnNjEyM1FhY1FKV2FId0pV?= =?utf-8?B?MHVQQUtFTjNhcS9icng5NTVDVURVWWVmL29VRjU5enlYNzkzY2M2eUdHVG5p?= =?utf-8?B?ZGFyNk5zTE5TaEtucWxpeDErdFpsQ3dGNUFFQm1ISVlURDU2NlR5cys1eUc3?= =?utf-8?B?NllJN0dNVkxnQ1pKajRpalZaNDZXY1RtdHZjY3pTT3J4NVhCR2d3ZWlFQmZK?= =?utf-8?B?Z3R4KzVBNmlidG1tWjBXOFlObEZaTm9FSC9yU2x5UFBaU09iTnNKU3FINjg4?= =?utf-8?B?OVhXUHBaT3ZmZDl2eHQ0U000WHRybk9mc1dJYmFZRm56WUVkdTFLQXNGSnR6?= =?utf-8?B?dERFYm5FSjZDN3UrNEM5eDBCNC9oNGJoa09abm8yemxsV25mbThDb1ArWGlC?= =?utf-8?B?KzlMbHNFTCsrWEZWUzVOditPR3d0eTRJMmlPVGRiQzQzMDhLRkVKTW8zYUUz?= =?utf-8?B?VG5KL2xVWXlVbHdYNnpGUEgzSlc1RC9QdGpxbGFncDY3T29KV3gyU2xqcC9M?= =?utf-8?B?VUdDTkNFc0p3WTRFZUdtUTVZZ1dpV1Q0cFRTM2JhQzBTQjZlVXVmRTRIcXRx?= =?utf-8?B?bk9BRWdweHZOdjhoYWtNNzhmVmNZTU5xRW52dHIzVExvNzVXSXNlZFhUT0Qr?= =?utf-8?B?L2wwN1BZZnJSNE9qT0FUczFqVFgvdnJibVJKV1htN01DN0YwVWFhZkV0M25i?= =?utf-8?B?NW9WNCtOZy9rcDN2Nys5ZkI5THl3TTBqWmNZak8vMXIxK2tpRXduQ2NPcGFH?= =?utf-8?B?Uzk5TjNtUUlKb3VGTDRsQW5uL0ZoNnMrZW1aUkNLK2JNUjFIWlloK01leUVS?= =?utf-8?B?dGk1QVhsZHlMbzY5am5tb2hVZlhnSE1OR0lSZHpjRUY3cVdpT0tpZFM3V0VU?= =?utf-8?B?SlJiWEs0UlBGU2l2MEVlUT09?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89297639-9155-43f6-3347-08d8f4518a3d X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2021 14:30:32.0555 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i6+x7TmecUO3xMrkx1CUhA0GyDh7PX2Dl0gR+lheHzwlg0eQ5aXNUZRX+tQcuL47nsrP7evBvzipm/epodryX9eJURLhx5hLryWj3DBtKJc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5720 X-OriginatorOrg: citrix.com DQoNCj4gT24gTWFyIDMxLCAyMDIxLCBhdCAzOjA2IFBNLCBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMzEuMDMuMjAyMSAxNjowMCwgR2VvcmdlIER1bmxh cCB3cm90ZToNCj4+IA0KPj4gDQo+Pj4gT24gTWFyIDMxLCAyMDIxLCBhdCAyOjU0IFBNLCBKYW4g QmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+IHdyb3RlOg0KPj4+IA0KPj4+IE9uIDMxLjAzLjIw MjEgMTU6NTIsIElhbiBKYWNrc29uIHdyb3RlOg0KPj4+PiBHZW9yZ2UgRHVubGFwIHdyaXRlcyAo IlJlOiBbUEFUQ0hdIENIQU5HRUxPRy5tZDogTWFrZSBQViBzaGltIHNtYWxsZXIgYnkgZmFjdG9y aW5nIG91dCBIVk0tc3BlY2lmaWMgc2hhZG93IGNvZGUiKToNCj4+Pj4+IEkgZG9u4oCZdCB1bmRl cnN0YW5kIHdoeSB0aGUgdHdvIG9mIHlvdSBhcmUgZG93bnBsYXlpbmcgeW91ciB3b3JrIHNvIG11 Y2guIFllcywgdGhlc2UgYXJlIGFsbCBvbmx5IGluY3JlbWVudGFsIGltcHJvdmVtZW50czsgYnV0 IHRoZXkgYXJlIGltcHJvdmVtZW50czsgYW5kIHRoZSBjdW11bGF0aXZlIGVmZmVjdCBvZiBsb2Fk cyBvZiBpbmNyZW1lbnRhbCBpbXByb3ZlbWVudHMgY2FuIGJlIHNpZ25pZmljYW50LiAgQ29tbXVu aWNhdGluZyB0byBwZW9wbGUganVzdCB3aGF0IHRoZSBuYXR1cmUgb2YgYWxsIHRoZXNlIGluY3Jl bWVudGFsIGltcHJvdmVtZW50cyBhcmUgaXMgaW1wb3J0YW50Lg0KPj4+PiANCj4+Pj4gSSBhZ3Jl ZSB3aXRoIEdlb3JnZSBoZXJlLg0KPj4+PiANCj4+Pj4gVGhlcmUgYWUgYSBudW1iZXIgb2YgcmVh c29ucyB3aHkgYmVoaW5kLXRoZS1zY2VuZXMgd29yayB3aXRoIGxpdHRsZQ0KPj4+PiAoaW50ZW50 aW9uYWwpIHVzZXItdmlzaWJsZSBpbXBhY3QgYXJlIHVzZWZ1bCB0byBub3RlIGluIHRoZQ0KPj4+ PiBDSEFOR0VMT0cubWQuICBXaXRoIG15IFJlbGVhc2UgTWFuYWdlciBoYXQgb24gSSB3b3VsZCBs aWtlIHRvIHNlZSwgZm9yDQo+Pj4+IGV4YW1wbGUsDQo+Pj4+IA0KPj4+Pj4+ICsgLSBGYWN0b3Jl ZCBvdXQgSFZNLXNwZWNpZmljIHNoYWRvdyBjb2RlLCBhbGxvd2luZyBQViBzaGltIHRvIGJlIHNs aW1tZXINCj4+Pj4gDQo+Pj4+IHNvbWV0aGluZyBhYm91dCBodGlzIHdvcmsgaW4gdGhlIENIQU5H RUxPRy5tZC4NCj4+Pj4gDQo+Pj4+IElESyBwcmVjaXNlbHksIGFuZCBJIGRvbid0IHRoaW5rIEdl b3JnZSBkb2VzIGVpdGhlciwgd2hhdCBhIGdvb2QgYW5kDQo+Pj4+IGFjY3VyYXRlIHN0YXRlbWVu dCBpcy4gIEJ1dCBJIGd1ZXNzIHdlIHdpbGwgZ28gd2l0aCB0aGUgdGV4dCBhYm92ZSBpZg0KPj4+ PiB3ZSBkb24ndCBnZXQgc29tZXRoaW5nIGJldHRlci4NCj4+PiANCj4+PiBBdCB0aGUgdmVyeSBs ZWFzdCB0aGUgcGFydCBhZnRlciB0aGUgY29tbWEgb3VnaHQgdG8gYmUgZGVsZXRlZC4gQXMNCj4+ PiBzYWlkIGluIGFuIGVhcmxpZXIgcmVwbHksIGF0IGxlYXN0IHRoZSBzaGltIGRlZmF1bHQgY29u ZmlnIGRpc2FibGVzDQo+Pj4gc2hhZG93IGNvZGUgYW55d2F5LCBzbyB0aGUgZmFjdG9yaW5nIG91 dCBoYXMgbm8gZWZmZWN0IHRoZXJlLg0KPj4gDQo+PiBUaGFua3MuICBTbyB3aGVuIHlvdSB3cm90 ZSB0aGUgc2VyaWVzLCB3aGF0IHdhcyB5b3VyIG1vdGl2YXRpb24/ICBEaWQgeW91IGhhdmUgYSBw YXJ0aWN1bGFyIHRlY2huaWNhbCBvdXRjb21lIGluIG1pbmQ/ICBPciBkaWQgaXQganVzdCBib3Ro ZXIgeW91IHRoYXQgdGhlcmUgd2FzIEhWTS1vbmx5IGNvZGUgaW4gYSBQVi1vbmx5IGJ1aWxkPyA6 LSkNCj4gDQo+IFdoYXQgYm90aGVycyBtZSBhcmUgbW9yZSB0aGUgaW1wbGljYXRpb25zIC0gaXQg YmVpbmcgcmF0aGVyIGhhcmQgaW4NCj4gbWFueSBjYXNlcywgYW5kIGluIHBhcnRpY3VsYXIgaW4g c2hhZG93IGNvZGUsIHRvIGJlIGFibGUgdG8gdGVsbCB3aGF0DQo+IHBhdGhzIGFyZSBpbnZvbHZl ZCBpbiB0aGUgaGFuZGxpbmcgb2Ygd2hhdCBraW5kKHMpIG9mIGd1ZXN0cy4gVGhpcw0KPiBoYXMg bWFkZSBtb3JlIHRpbWUgY29uc3VtaW5nIGludmVzdGlnYXRpb24gb2YgKHN1c3BlY3RlZCkgbWlz YmVoYXZpb3INCj4gaW4gbW9yZSB0aGFuIG9uZSBjYXNlLg0KDQpPSywgc28gaG93IGFib3V0Og0K DQotIEZhY3RvcmVkIG91dCBIVk0tc3BlY2lmaWMgc2hhZG93IGNvZGUsIGltcHJvdmluZyBjb2Rl IGNsYXJpdHkgYW5kIHJlZHVjaW5nIHRoZSBzaXplIG9mIFBWLW9ubHkgaHlwZXJ2aXNvciBidWls ZHMNCg0KIC1HZW9yZ2U= From xen-devel-bounces@lists.xenproject.org Wed Mar 31 14:53:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 14:53:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103986.198385 (Exim 4.92) (envelope-from ) id 1lRcDD-0004yz-Jy; Wed, 31 Mar 2021 14:52:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103986.198385; Wed, 31 Mar 2021 14:52:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRcDD-0004ys-H6; Wed, 31 Mar 2021 14:52:51 +0000 Received: by outflank-mailman (input) for mailman id 103986; Wed, 31 Mar 2021 14:52:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRcDC-0004yS-LN for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 14:52:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a77c29d7-50b4-40b5-90e7-52b253142f5a; Wed, 31 Mar 2021 14:52:49 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7C663B2DA; Wed, 31 Mar 2021 14:52:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a77c29d7-50b4-40b5-90e7-52b253142f5a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617202368; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A1BHKYM+Ff6UIACv3jUaSS+yjnzq03L0EVefsI+POL8=; b=nhm2dtWIkQcnURa33yUyzR/eEteza4bhhDTEddPuLIG3kx0uK4QkKXKRdoYeLqQo8u3UGq x3NVAJ49C4mE41GHEP8ANmSxks5fG4Dcxe7ADrFoH9ATkwHBWoLiThJy+I1jWPvvQNV8oD tYsB/YeDwpfB0EPCISlwRTi3djK6PWg= To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Dario Faggioli From: Jan Beulich Subject: [PATCH] fix for_each_cpu() again for NR_CPUS=1 Message-ID: <4d993e67-2bdf-9ac3-f78e-daf279642de1@suse.com> Date: Wed, 31 Mar 2021 16:52:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Unfortunately aa50f45332f1 ("xen: fix for_each_cpu when NR_CPUS=1") has caused quite a bit of fallout with gcc10, e.g. (there are at least two more similar ones, and I didn't bother trying to find them all): In file included from .../xen/include/xen/config.h:13, from : core_parking.c: In function ‘core_parking_power’: .../xen/include/asm/percpu.h:12:51: error: array subscript 1 is above array bounds of ‘long unsigned int[1]’ [-Werror=array-bounds] 12 | (*RELOC_HIDE(&per_cpu__##var, __per_cpu_offset[cpu])) .../xen/include/xen/compiler.h:141:29: note: in definition of macro ‘RELOC_HIDE’ 141 | (typeof(ptr)) (__ptr + (off)); }) | ^~~ core_parking.c:133:39: note: in expansion of macro ‘per_cpu’ 133 | core_tmp = cpumask_weight(per_cpu(cpu_core_mask, cpu)); | ^~~~~~~ In file included from .../xen/include/xen/percpu.h:4, from .../xen/include/asm/msr.h:7, from .../xen/include/asm/time.h:5, from .../xen/include/xen/time.h:76, from .../xen/include/xen/spinlock.h:4, from .../xen/include/xen/cpu.h:5, from core_parking.c:19: .../xen/include/asm/percpu.h:6:22: note: while referencing ‘__per_cpu_offset’ 6 | extern unsigned long __per_cpu_offset[NR_CPUS]; | ^~~~~~~~~~~~~~~~ One of the further errors even went as far as claiming that an array index (range) of [0, 0] was outside the bounds of a [1] array, so something fishy is pretty clearly going on there. The compiler apparently wants to be able to see that the loop isn't really a loop in order to avoid triggering such warnings, yet what exactly makes it consider the loop exit condition constant and within the [0, 1] range isn't obvious - using ((mask)->bits[0] & 1) instead of cpumask_test_cpu() for example did _not_ help. Re-instate a special form of for_each_cpu(), experimentally "proven" to avoid the diagnostics. Signed-off-by: Jan Beulich --- a/xen/include/xen/cpumask.h +++ b/xen/include/xen/cpumask.h @@ -368,10 +368,15 @@ static inline void free_cpumask_var(cpum #define FREE_CPUMASK_VAR(m) free_cpumask_var(m) #endif +#if NR_CPUS > 1 #define for_each_cpu(cpu, mask) \ for ((cpu) = cpumask_first(mask); \ (cpu) < nr_cpu_ids; \ (cpu) = cpumask_next(cpu, mask)) +#else /* NR_CPUS == 1 */ +#define for_each_cpu(cpu, mask) \ + for ((cpu) = 0; (cpu) < cpumask_test_cpu(0, mask); ++(cpu)) +#endif /* NR_CPUS */ /* * The following particular system cpumasks and operations manage From xen-devel-bounces@lists.xenproject.org Wed Mar 31 14:53:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 14:53:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103989.198397 (Exim 4.92) (envelope-from ) id 1lRcDv-000546-Tn; Wed, 31 Mar 2021 14:53:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103989.198397; Wed, 31 Mar 2021 14:53:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRcDv-00053z-QQ; Wed, 31 Mar 2021 14:53:35 +0000 Received: by outflank-mailman (input) for mailman id 103989; Wed, 31 Mar 2021 14:53:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRcDu-00053u-GB for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 14:53:34 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3d92396d-c0dc-45d2-b0fb-9a5a4e6a1300; Wed, 31 Mar 2021 14:53:33 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CC25AB30F; Wed, 31 Mar 2021 14:53:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d92396d-c0dc-45d2-b0fb-9a5a4e6a1300 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617202412; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZOu2KMufkpCGa1JEXFcSmFm9khbcT6sblcFBLElSEno=; b=CMY8JHUVVQU6ArfjPiHJMJVjvaoWtU68imR856XZDjw3QafhNNGFUSTrc9r6uXr6Xa7eoP Q9nJaY3sEU53qJFqrwCW9bJwE7OZA7fpgttv2AXIDD3JT57u/wD9MAKh0db0DGl2NGta4e hGCyRha4pJuwJnIp7zbHR22ejmVrspY= Subject: Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code To: George Dunlap Cc: Ian Jackson , Andrew Cooper , Roger Pau Monne , "xen-devel@lists.xenproject.org" , Paul Durrant References: <20210324172608.302316-1-george.dunlap@citrix.com> <23461afc-c0e0-eb33-9ed3-52f050b6aef0@suse.com> <27ecde00-f0aa-b701-6928-5480ed805064@citrix.com> <2A1FCD39-D0C0-468D-A977-2FBF7126FDE6@citrix.com> <24676.32400.548088.26254@mariner.uk.xensource.com> <1a87cfa9-d6c0-5da5-ea07-eae47186da9a@suse.com> <1832DBFA-B215-4CEA-9C8A-F53F2A5321E9@citrix.com> <9b899068-e0df-3f5f-5537-b9ff81bfa279@suse.com> From: Jan Beulich Message-ID: <90697fc8-00f4-6679-f465-997bbcb131d2@suse.com> Date: Wed, 31 Mar 2021 16:53:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 31.03.2021 16:30, George Dunlap wrote: > > >> On Mar 31, 2021, at 3:06 PM, Jan Beulich wrote: >> >> On 31.03.2021 16:00, George Dunlap wrote: >>> >>> >>>> On Mar 31, 2021, at 2:54 PM, Jan Beulich wrote: >>>> >>>> On 31.03.2021 15:52, Ian Jackson wrote: >>>>> George Dunlap writes ("Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code"): >>>>>> I don’t understand why the two of you are downplaying your work so much. Yes, these are all only incremental improvements; but they are improvements; and the cumulative effect of loads of incremental improvements can be significant. Communicating to people just what the nature of all these incremental improvements are is important. >>>>> >>>>> I agree with George here. >>>>> >>>>> There ae a number of reasons why behind-the-scenes work with little >>>>> (intentional) user-visible impact are useful to note in the >>>>> CHANGELOG.md. With my Release Manager hat on I would like to see, for >>>>> example, >>>>> >>>>>>> + - Factored out HVM-specific shadow code, allowing PV shim to be slimmer >>>>> >>>>> something about htis work in the CHANGELOG.md. >>>>> >>>>> IDK precisely, and I don't think George does either, what a good and >>>>> accurate statement is. But I guess we will go with the text above if >>>>> we don't get something better. >>>> >>>> At the very least the part after the comma ought to be deleted. As >>>> said in an earlier reply, at least the shim default config disables >>>> shadow code anyway, so the factoring out has no effect there. >>> >>> Thanks. So when you wrote the series, what was your motivation? Did you have a particular technical outcome in mind? Or did it just bother you that there was HVM-only code in a PV-only build? :-) >> >> What bothers me are more the implications - it being rather hard in >> many cases, and in particular in shadow code, to be able to tell what >> paths are involved in the handling of what kind(s) of guests. This >> has made more time consuming investigation of (suspected) misbehavior >> in more than one case. > > OK, so how about: > > - Factored out HVM-specific shadow code, improving code clarity and reducing the size of PV-only hypervisor builds This sounds okay to me. Thanks, Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 31 14:57:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 14:57:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103995.198409 (Exim 4.92) (envelope-from ) id 1lRcHt-0005Gq-JK; Wed, 31 Mar 2021 14:57:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103995.198409; Wed, 31 Mar 2021 14:57:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRcHt-0005Gj-FY; Wed, 31 Mar 2021 14:57:41 +0000 Received: by outflank-mailman (input) for mailman id 103995; Wed, 31 Mar 2021 14:57:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRcHs-0005Ge-8d for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 14:57:40 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c7ebb13c-5a96-42c5-a976-f0cac25e6e9e; Wed, 31 Mar 2021 14:57:39 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AA376B2DA; Wed, 31 Mar 2021 14:57:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7ebb13c-5a96-42c5-a976-f0cac25e6e9e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617202658; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WdqpmDEpGjbr6I3iWXbJUxj+OjAfxYAQ9ASwhftDVkI=; b=q2BwGAuloO5qHdUIA/gdPdTKmByvzQotNGgULLLjhM+OziS3ZREhZxy8xGs5Ebju1U4Sij Pw8n6mPTWC1qSdJJLv/3lLcq4YQN0ObA1JciSrBcaNL72GgOGdzpzflzU+Uf/h1zeF6KPa mrxfbc9ZDlduuDzY+IayPj8Y7AydE3I= Subject: Re: [PATCH 14/21] libs/guest: introduce helper to check cpu policy compatibility To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Ian Jackson , Wei Liu , xen-devel@lists.xenproject.org References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-15-roger.pau@citrix.com> <8f7a2f44-c006-0f94-8f44-b6b3ee3e9d1f@suse.com> From: Jan Beulich Message-ID: <958bf9f5-8481-b7fe-c29f-6eb971c6e2f1@suse.com> Date: Wed, 31 Mar 2021 16:57:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 31.03.2021 14:40, Roger Pau Monné wrote: > On Tue, Mar 30, 2021 at 06:02:45PM +0200, Jan Beulich wrote: >> On 23.03.2021 10:58, Roger Pau Monne wrote: >>> --- a/tools/libs/guest/xg_cpuid_x86.c >>> +++ b/tools/libs/guest/xg_cpuid_x86.c >>> @@ -1098,3 +1098,20 @@ int xc_cpu_policy_update_msrs(xc_interface *xch, xc_cpu_policy_t policy, >>> return rc; >>> >>> } >>> + >>> +bool xc_cpu_policy_is_compatible(xc_interface *xch, const xc_cpu_policy_t p1, >>> + const xc_cpu_policy_t p2) >>> +{ >>> + struct cpu_policy_errors err; >> >> Don't you need an initializer here for ... >> >>> + int rc = x86_cpu_policies_are_compatible(p1, p2, &err); >>> + >>> + if ( !rc ) >>> + return true; >>> + >>> + if ( err.leaf != -1 ) >>> + ERROR("Leaf %#x subleaf %#x is not compatible", err.leaf, err.subleaf); >>> + if ( err.msr != -1 ) >>> + ERROR("MSR index %#x is not compatible", err.msr); >> >> ... these checks to have a chance of actually triggering? (I'm also >> not certain -1 is a good indicator, but I guess we have been using it >> elsewhere as well.) > > Well, this is strictly the error path, at which point I would expect > err to be properly set by x86_cpu_policies_are_compatible. I can > however initialize err for safety here. Aiui in the error case one of the two, but not both fields would be set. Without initializer you'd likely find both of them != -1, though. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 31 15:24:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 15:24:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.103998.198421 (Exim 4.92) (envelope-from ) id 1lRchV-0007sB-PC; Wed, 31 Mar 2021 15:24:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103998.198421; Wed, 31 Mar 2021 15:24:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRchV-0007s4-LX; Wed, 31 Mar 2021 15:24:09 +0000 Received: by outflank-mailman (input) for mailman id 103998; Wed, 31 Mar 2021 15:24:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRchU-0007rz-IM for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 15:24:08 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f87977e7-8225-427d-83a8-f6f88007e537; Wed, 31 Mar 2021 15:24:07 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 88074B02A; Wed, 31 Mar 2021 15:24:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f87977e7-8225-427d-83a8-f6f88007e537 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617204246; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4kyThAaDQClUp3NuwHF6UpoU3ZCInu+cosD9+lU6rEE=; b=DvUvEoS/EJJPH8fh/Wl7fDBTrK6T70NBcVcJJR0i717d6os6XRKrbHeX97Yj/uYb/8+kqK HpbO2Vxqc232I1xJVU0a175MzjYrvWSLC8yBfyB285Dy/+9NB8FujhdDpOdRB05yjOczzD OWj/t2g2htpthAiV71eW7p9qWkQ+dOE= Subject: Re: [PATCH 15/21] libs/guest: obtain a compatible cpu policy from two input ones To: Roger Pau Monne Cc: Andrew Cooper , Ian Jackson , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-16-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 31 Mar 2021 17:24:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210323095849.37858-16-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 23.03.2021 10:58, Roger Pau Monne wrote: > Introduce a helper to obtain a compatible cpu policy based on two > input cpu policies. Currently this is done by and'ing all CPUID leaves > and MSR entries, except for MSR_ARCH_CAPABILITIES which has the RSBA > bit or'ed. I'm afraid this is too simplistic. It might do as an initial approximation if limited to the feature flag leaves, but you can't reasonably AND together e.g. leaf 0 output. > @@ -1115,3 +1116,117 @@ bool xc_cpu_policy_is_compatible(xc_interface *xch, const xc_cpu_policy_t p1, > > return false; > } > + > +static uint64_t level_msr(unsigned int index, uint64_t val1, uint64_t val2) > +{ > + uint64_t val; > + > + switch( index ) > + { > + case MSR_ARCH_CAPABILITIES: > + val = val1 & val2; Considering you need this even here, how about making this the initializer of the variable, allowing to drop "default:" altogether? Also, nit: Missing blank after "switch". > + index = 0; > + for ( i = 0; i < p1_nr_leaves; i++ ) > + for ( j = 0; j < p2_nr_leaves; j++ ) > + if ( p1_leaves[i].leaf == p2_leaves[j].leaf && > + p1_leaves[i].subleaf == p2_leaves[j].subleaf ) > + { > + leaves[index].leaf = p1_leaves[i].leaf; > + leaves[index].subleaf = p1_leaves[i].subleaf; > + leaves[index].a = p1_leaves[i].a & p2_leaves[j].a; > + leaves[index].b = p1_leaves[i].b & p2_leaves[j].b; > + leaves[index].c = p1_leaves[i].c & p2_leaves[j].c; > + leaves[index].d = p1_leaves[i].d & p2_leaves[j].d; > + index++; > + } > + nr_leaves = index; > + > + index = 0; > + for ( i = 0; i < p1_nr_msrs; i++ ) > + for ( j = 0; j < p2_nr_msrs; j++ ) > + if ( p1_msrs[i].idx == p2_msrs[j].idx ) > + { > + msrs[index].idx = p1_msrs[i].idx; > + msrs[index].val = level_msr(p1_msrs[i].idx, > + p1_msrs[i].val, p2_msrs[j].val); > + index++; > + } > + nr_msrs = index; Mid- to long-term I'd be afraid of this going to take too long for at least the MSRs. Can't we build on some similarity in the ordering of both arrays, to avoid the double for()s? Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 31 15:29:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 15:29:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104001.198433 (Exim 4.92) (envelope-from ) id 1lRcml-00083u-CK; Wed, 31 Mar 2021 15:29:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104001.198433; Wed, 31 Mar 2021 15:29:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRcml-00083n-8y; Wed, 31 Mar 2021 15:29:35 +0000 Received: by outflank-mailman (input) for mailman id 104001; Wed, 31 Mar 2021 15:29:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRcmk-00083i-CS for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 15:29:34 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4dca5936-7bc4-4637-aaa3-2b7513699c98; Wed, 31 Mar 2021 15:29:33 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 755C8B166; Wed, 31 Mar 2021 15:29:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4dca5936-7bc4-4637-aaa3-2b7513699c98 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617204572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EJRnYcg6ZxrYQzynrDzzuX5L0oOhuYbbyxEpDSCgNf8=; b=CSj7Pwp4BfMEgba/kbDTrAjqH2jem7+YClxgd8uVq9wdQg5s1UPrGaZL3qbQj29/DXthwm TQrQQNgcW/+96E0f8U5kAqAO+kzJlfNoJmYPstwycdfuQa63AYgeqFVrCN9IWUc4AG6QVg s6XL57tPd5RWqYnlz8XmS44JctE1Ivk= Subject: Re: [PATCH 16/21] libs/guest: make a cpu policy compatible with older Xen versions To: Roger Pau Monne Cc: Andrew Cooper , Ian Jackson , Wei Liu , xen-devel@lists.xenproject.org References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-17-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 31 Mar 2021 17:29:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210323095849.37858-17-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 23.03.2021 10:58, Roger Pau Monne wrote: > --- a/tools/libs/guest/xg_cpuid_x86.c > +++ b/tools/libs/guest/xg_cpuid_x86.c > @@ -436,6 +436,7 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, > unsigned int i, nr_leaves, nr_msrs; > xen_cpuid_leaf_t *leaves = NULL; > struct cpuid_policy *p = NULL; > + struct cpu_policy policy = { }; > uint32_t err_leaf = -1, err_subleaf = -1, err_msr = -1; > uint32_t host_featureset[FEATURESET_NR_ENTRIES] = {}; > uint32_t len = ARRAY_SIZE(host_featureset); > @@ -504,12 +505,8 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore, > */ > if ( restore ) > { > - p->basic.rdrand = test_bit(X86_FEATURE_RDRAND, host_featureset); > - > - if ( di.hvm ) > - { > - p->feat.mpx = test_bit(X86_FEATURE_MPX, host_featureset); > - } > + policy.cpuid = p; > + xc_cpu_policy_make_compatible(xch, &policy, di.hvm); > } The comment ahead of this if() wants moving to ... > @@ -1230,3 +1227,33 @@ int xc_cpu_policy_calc_compatible(xc_interface *xch, > > return rc; > } > + > +int xc_cpu_policy_make_compatible(xc_interface *xch, xc_cpu_policy_t policy, > + bool hvm) > +{ > + xc_cpu_policy_t host; > + int rc; > + > + host = xc_cpu_policy_init(); > + if ( !host ) > + { > + errno = ENOMEM; > + return -1; > + } > + > + rc = xc_cpu_policy_get_system(xch, XEN_SYSCTL_cpu_policy_host, host); > + if ( rc ) > + { > + ERROR("Failed to get host policy"); > + goto out; > + } > + > + policy->cpuid->basic.rdrand = host->cpuid->basic.rdrand; > + > + if ( hvm ) > + policy->cpuid->feat.mpx = host->cpuid->feat.mpx; ... or cloning ahead of these two. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 31 16:03:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 16:03:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104007.198451 (Exim 4.92) (envelope-from ) id 1lRdJ2-0003Xj-1Q; Wed, 31 Mar 2021 16:02:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104007.198451; Wed, 31 Mar 2021 16:02:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRdJ1-0003Xc-UY; Wed, 31 Mar 2021 16:02:55 +0000 Received: by outflank-mailman (input) for mailman id 104007; Wed, 31 Mar 2021 16:02:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRdJ0-0003XX-Jn for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 16:02:54 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 278084ea-551e-40be-a0f3-adf6d70b4ae5; Wed, 31 Mar 2021 16:02:53 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 33513B308; Wed, 31 Mar 2021 16:02:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 278084ea-551e-40be-a0f3-adf6d70b4ae5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617206572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vNXTuZMlTjXJX8GnpQtGtCjAvrIWn1Bn/qb+aaARyYA=; b=J1rt22ZtQLuwbM/rLEqNS7HmtAI7d8sx4TjkzuI34KO9CQtB/c9KZGOUsnz/LsPe2Wolt/ FRJa8Gs7xkeJhhYmZic87lMD/PfUqo57ERERmTefuoA9s8o1wHe9EzrIPTVP0aPN8zXcCg a0daBWHeBkpe7ZMPXbBftwz/tGjzxRI= Subject: Re: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , Paul Durrant , Paul Durrant , xen-devel@lists.xenproject.org References: <20210331103303.79705-1-roger.pau@citrix.com> <20210331103303.79705-2-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 31 Mar 2021 18:02:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210331103303.79705-2-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 31.03.2021 12:32, Roger Pau Monne wrote: > EOIs are always executed in guest vCPU context, so there's no reason to > pass a vCPU parameter around as can be fetched from current. > > While there make the vector parameter of both callbacks unsigned int. > > No functional change intended. > > Suggested-by: Paul Durrant > Signed-off-by: Roger Pau Monné > Reviewed-by: Paul Durrant > --- > Changes since v1: > - New in this version. I'm afraid the situation with viridian_synic_wrmsr() hasn't changed since v2, and hence my previous comment still applies. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 31 16:04:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 16:04:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104010.198463 (Exim 4.92) (envelope-from ) id 1lRdKp-0003fR-DY; Wed, 31 Mar 2021 16:04:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104010.198463; Wed, 31 Mar 2021 16:04:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRdKp-0003fK-AV; Wed, 31 Mar 2021 16:04:47 +0000 Received: by outflank-mailman (input) for mailman id 104010; Wed, 31 Mar 2021 16:04:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRdKn-0003fD-JQ for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 16:04:45 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1ee41738-7e12-4b24-a387-c50d2487d3be; Wed, 31 Mar 2021 16:04:44 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E59F0B308; Wed, 31 Mar 2021 16:04:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ee41738-7e12-4b24-a387-c50d2487d3be X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617206684; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zSkK+LeVr3rPCrrI9TRbmfQGk5hSY+T+rfFSwnszRsw=; b=E1V7wEtn4zcWfa94Z2yfNxERCZ8wZ/8T5/MhYopRuT3bNXxnmvK3HXi0enrwD5uEaFSxOR xDQHeWWCmBI+z9IptPvEcDY8QUwe0X344ExCatzWuE0E7tvMMxCQDxYtBSzngK5jKZkHBv AyOrQje8gK8KkpD3dOVGCXbWZl1uR+0= Subject: Re: [PATCH v3 02/11] x86/hvm: drop domain parameter from vioapic/vpic EOI callbacks To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: <20210331103303.79705-1-roger.pau@citrix.com> <20210331103303.79705-3-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 31 Mar 2021 18:04:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210331103303.79705-3-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 31.03.2021 12:32, Roger Pau Monne wrote: > EOIs are always executed in guest vCPU context, so there's no reason to > pass a domain parameter around as can be fetched from current->domain. > > No functional change intended. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Paul Durrant > --- > Changes since v1: > - New in this version. Just to make it explicit - possibly same thing as with patch 1, depending on how exactly the issue there gets taken care of. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 31 16:24:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 16:24:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104014.198479 (Exim 4.92) (envelope-from ) id 1lRde0-0005TZ-1X; Wed, 31 Mar 2021 16:24:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104014.198479; Wed, 31 Mar 2021 16:24:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRddz-0005TS-UO; Wed, 31 Mar 2021 16:24:35 +0000 Received: by outflank-mailman (input) for mailman id 104014; Wed, 31 Mar 2021 16:24:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRddy-0005TN-H9 for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 16:24:34 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 53f1e7d3-d8c3-4ad8-a603-ab78371106c3; Wed, 31 Mar 2021 16:24:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53f1e7d3-d8c3-4ad8-a603-ab78371106c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617207873; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=+FbbCQsWXfoVlblK3jBwLsh7vNHSwUCNmsLxIdBEOs0=; b=B4lrmOfpVJQk6yqn0IrBxPjCtH+kR4crLkBLZpZ6j+8d0xt7Kx3jUT8D sFwmpUo9lEHjP/u8W+mYUNarkLuhKHHikE5rqX/gRf6LvtcDsxu8KJVLs Lv3ft5iAUwVUTfBqL/l2+yWgP6MqtqNNqKtLmmLw7qDm04CEUWE70cWfr U=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 4ZoXZWU0qY0op7T41FSkv1zsS2vN7bDe34bboys6V7v/U4qC6b/4ISKWmNydkwaSZPvEf9fU12 ybVZrEwK9dWprz7lk7S+KJTuAYQTLLqFbYUBqFO16ukizc/h6GxX3VNd0gAzqGCLBGwsNLmWZy zFVkb7kqZ0EUtfSCz7o86jQJ0KAoHv9khuV8rUkuHZ+I6ngQIJkbOC+9nzxyvfgsmTxSFjIGFE L85b01q+ihFaRgJhdKOqzmGskq9ND0oKycank9J4II2ZbyE2fct2lLdhuIUH1HrwwIZIZSu38D MZo= X-SBRS: 5.2 X-MesageID: 40583250 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:XD+ec6+Gh5vuKsKP1ftuk+F3cL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmzybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIULD38Zn/+ Nbf6B6YeedMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsLV4hLxW5Ce2KmO2dxQxRLAod8MZ Ka6NZOqTbIQwVoUu2QAH4ZU+/f4+DRnJX9bhIcQzIh4g+CjTSngYSKbCSw9BEYTj9J3PMe4X HI+jaJmpmLntOa7lvn12HV54lLg9eJ8Lp+LeGFl8R9EESWti+Gf4JkMofy2gwdgObq01oylc mJnhFIBbUP11r0XkWY5STgwBPh1jFG0Q6R9Xa9jWH4qcL0ABIWYvAx/b5xSRfS50o+sNwU6s sitAj1xvknb2K1oA3H69fFTB1snEavyEBS9tI7tHBDTZAYLIZYsI13xjInLL47ACn45Io7ed Medf302fA+SyL+U1nkpGV1hPSjUnMvdy32OHQqi4i+1jhbm21B1E0IxMATtWdozuNMd7B0o8 vDKahmj7dIU4s/ar98Hv4IRY+NBnXKWg+kChPdHX3XUIU8f17doZ/+57s4oMmsZZwz1ZM33L DMSklRu2Iec1/nYPf+naFjw1ToeiGQTD7twsZR69xSobvnXofmNiWFVRQHj9agi+93OLyYZ9 +DfLZtR9PzJ2rnHohEmyfkXYNJFHUYWMoJ/v4mRlO1pN7RIIGCjJ2ZTN/jYJ7WVRo0UGL2BX UOGBLpIt9b00ytUnjkxDfLXXfAfVH+4IJQHKDW8/N78vlICqR89iwuzXip7MCCLjNP9oYsel FlHb/hmqSn4Um6lFy4qFlBC154NAJ48b/gW3RFqUshKEXva4sOvN2ZZCR31HuDLRlvctPOHG dk1hJK0JPyC6bV6TEpCtqhPG7fpWAUvmi2Q5AVnbDGwsv5ZJUiDNIDVLZqHQvGUzx58Dwa6F trWUshfAvyBznugaKqgNg/H+fEbeRxhw+tPIpzsnLQtUKVoOk1XXsFVzuSUcqa6DxeAgZ8tx lUyesykbCAkTGgJS8Um+IjKmBBb2yRHfZ7FgifXZ5VnbrqYQl0am+PiVWh+kgOU1uv039Xqn 3qLCWSd/2OJlZGoHhX3pzn905OenyHc1h9bW17toNBBX3L00wDpNOjV+6W6S+8e1ECyuYSPH X+bTweLhhH6vq32BSW8QzyWEkO99ELBKjwHb4je7bc1jeRM4WOj7gBBOIR1o1iLsrSvugCVv +/dweZICjjMf4g3xWYqx8eSXFJgUhhtcmt9Azu7WC+0nJ6POHbJ05+QaoHZ/6b9GrpSp+zod 1EpONwmdH1FGr/atSLk/6KKxFCLw7eum6wQaUDr4tOsac7qbt0GN36XFLzpQd69SR7CP2xsk UUBJlfyvTmHKREesQJYSJX/lYzjr20XQEWmz2zJtV7RE0nin/QAsiA7LXJo4c+G0HpnnqGBX Cvtwlmu8rfVySN1bQmG7s9DGRfZk878mlj9oq5BsTtITTvU+FI51yhNHChNJdbVaieAL0Vxy wKr+2grquydyDi3hrXsiY+CqVS83y/Scf3JA6XA+ZH/5ibPluL65Har/KbvXPSSTGhbV4fip AAXUsMbt5bgj1ntbYJ6EGJO+fKi3NgtUBf7zFhnkPs3YbjwF6zJzA2DSTpxrNMXTdSNXCUi9 /i6ubw7gWn3AR4 X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40583250" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oIT93A/N7xpC0p9RE3BnLjSUmN0o4QjwFsFTU7cB643180awax3nMZupFgbwqaoC4yaPlfomVVicICEg4t9NLh+G5lVNMjtPZM4favbPWPmGKUB0b93zy3B+OMez4Yc87McIcPuaTGtm4bHW3x/+HAUWSjCI4mjTg6Eimq8yd8ReK+wDo7+ZCA2Dg4LBXBcn61KowYChwAHYXWPb6HdXcBQu64FQbIPWR0rRUHd5tEODBDMY2s9TK1rB/jX71KOC3PngZ5QJCkADkt7fGBZMZwUzle928t8DgHOdrDhpobAMQLnlHl1lCVw1QJCwlDv8k0F/Yc81srLvMsOMYkdOBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CTuz3+j7FuRJ6D1vrBmy6H7dyKLgapmZ4kimdqWiNIQ=; b=GURflj4+3hrTSJzWGb+fXXRf1DyUrl7zeL2gAmZW3wRPW+WTeeFVFmqMjgs3QvKXuTUhPUqeGWbvDsJ8bU3FCxhCXLzORlBVtAogt103r4OL1QIGvUU6xGuMylHU1BWZ6gqSSA6JHttqSHEgTBZ7fr95Gj24EfzJP0AAgI+Vixeht04Vkn/d48oJks4z6Gyirx5QJpWuQ/HNRYhs8rpouXtdLRIdcHrIrHBuTF2m208HhDAjks3JywEI8Q4VoK9xzNgNQ1i+UyWs/nqGJyHOMkH439h1/dlw8hBdhy9A+dTRquUiTCAxdQMpc+r623IMvWTBWTOGqd8zmsfq5/NfvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CTuz3+j7FuRJ6D1vrBmy6H7dyKLgapmZ4kimdqWiNIQ=; b=pegZ3ItKGps48xF/MtfagK/m55Hc1BgGCGEo9RlsX6avIe0Db/s0HnfM64H/4RMn0fehhT4+uE9BGYUptTuHRyFV9JV/TKt6W2h8zbuwDzqYH6Teb5jN1Zmfl4VKgAhjVA7IyFWrA7LzGJpy1lcmo7/jBhZAk+q+172UsVe6lps= To: Jan Beulich , Roger Pau Monne CC: Wei Liu , Paul Durrant , Paul Durrant , References: <20210331103303.79705-1-roger.pau@citrix.com> <20210331103303.79705-2-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks Message-ID: <1bc56db3-203d-1fa8-ad5c-68d97d584600@citrix.com> Date: Wed, 31 Mar 2021 17:24:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0010.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::22) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4614ffe4-7fd0-454c-1278-08d8f46175a2 X-MS-TrafficTypeDiagnostic: BN7PR03MB3825: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ++2CQLRmesq8U7x4HOI/d33HQ8mQKIWHH2d/z8m48wThVeKy48ij0bhuFFXypTi60c5bv1rGewsaMGcJ4dYMKWt8MGEUXUJWoH0nGgHodcB3I+fEZZLQgv9lTnfKhm5/0HZF02t0BrmoUuOwkJ60Gd27dH+SZ2czoEH6BrCz8wjvXq2JeSj33PkUicTtC3DIlvEkCLDa/DtjaYszh/Kt/zX+n+vi8DxNeC77LcrlyRAupOJHl5EdP454onqyX7SmX805OEiL9aC4wBbjfzkO4QyjQLMN+AFiEn7mogEGjlUk7vuJEZSHOfx8LweDbz9xhkAW2+W77f+NzBWEOnWLNodjcBexbrppi4swWSX7NPBLsYbDsScebGKeZ64pGI4ccOzY/CQ7oXkoebcXoTWATf31LgRunxE4mfL0sf/p4qj1+j4kngi6D+Wy6EVjVcbEPgqRZ5ktNefFGXjuDL2sNbU76mM8Omljffn/L1WUXaqPVk5o+kZaSeQ3AvFkVGDNU04vJ+Hio6MLyUOt9ArFx4RFp4WdPwdSqGG+d9SaiAj8ae6/Nnv43+Esaxf3XvboyZ3ZBoxSnZyvZsG7z4wsx0J79D2WLPxNaaCNyqRDyOUJBYb0Qnv+2RzalV/5Y870VVVnKBBA72t5GH1vMibchlTnbJSPteEGijsqTDFNz/Ft1NyjcIdP/F4XkNCBjm7Vw0QS7ArzYQeetdP04WjmqFXKKpK2SS7SB7cnRO1w9IE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(396003)(376002)(366004)(39850400004)(478600001)(83380400001)(66556008)(53546011)(66946007)(956004)(186003)(8936002)(2906002)(4326008)(38100700001)(31686004)(6636002)(5660300002)(54906003)(110136005)(16576012)(8676002)(316002)(16526019)(6666004)(26005)(31696002)(6486002)(2616005)(86362001)(66476007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MHNPWDZBcVBmb1B3cFAycStZdXJodjZQdzlodkhpZ3hYRzVxTXVUcURUcXlL?= =?utf-8?B?MTF6cjM1eGVKNEpvWjErMFpSUnYwNzUvZyszS0E0QXBoa2lrNExqcVJLajhI?= =?utf-8?B?U1ZFd2UxUDJNanp2cjFkYXBHZnhVK2VpZTdpMDZTaUJYbXk4d0o1dU5UQzB2?= =?utf-8?B?SDlrcTdQbHRiS3U2ZVVkNnVrUlF3RUlnc2krYnNtRlB6eThoZjBseXl1UzU3?= =?utf-8?B?OUE0ejQ1OXpjZlAvaGprVzhmNFFtSEdRU1lxSUYwT2dxbTlzWEoveU1pOGR2?= =?utf-8?B?clhZRVJwMERRalZ6VFd6bVUrdTZrcDAveDBIK0I3NTl1ajhIQnV0WVVPT0Rq?= =?utf-8?B?dW9OaFZ5b3lUcEljSGtydW5QV29mNGtvdjFPbDNlZTlWRTFxSTBBM09yUXY0?= =?utf-8?B?bVpQejhTZUlIaWhGb3cyQ0hoZ0R2bFZzTDBzcm9nQ0JpeU02dzJCZnJWcXg3?= =?utf-8?B?M3JuMFRxZy9QZ1BiNFIwNVNHZVUvN0dQMXBQVndPUnluQVYreUVMK3lUWm83?= =?utf-8?B?T3RHd2dXZXZJZ2V6WDVVNkQ5N2t2MHZFV25LTFZvdGU1SFJEOEQ5MmFZOHRW?= =?utf-8?B?VzV0Tk0yRFgwZGFESXRtWWZDeEpRMitqNXk5MEhSQmo4aVBZMS9mc082MkE1?= =?utf-8?B?ckI2QmhUaWhZdEZGVTJnaXhyaUxmZ3h6L2tIaG1scWNLMW1ic2NCdmtOTWZ5?= =?utf-8?B?YklibFQ1b1BMM1JJS2pWemFUVFB2ZDlMa0FTazFLTlR1U3BocTNkMWYvOTR3?= =?utf-8?B?NkJKck9pVDAydG10ZzFOMUxZOHhMSnMwSFgzQVpWMWo5U3hvZms5dVcwakFq?= =?utf-8?B?cGRabjhLVzdXMkhnZGNPbzBhRzNLenBZaFJ3b20yWTBFeTFGOVJXc3EycTJ3?= =?utf-8?B?amE3aVNFN3d0QWsrY3p2Lzlzd0htRE1IZE44SkpBNUcrNElZMnFiTk1OdGI3?= =?utf-8?B?NUIveFFLUWlzSWNBeVc1VnIrdUVRVjFHc3FveUFxbmpDVkdhK3Y0empFRmlz?= =?utf-8?B?bHlBYUR5MDgzdHNpaVNOZnYzQWFrWm8rNFBUMXlUckhPSitud2xyTU1NRjRC?= =?utf-8?B?dXM3ejd3bTczYXN6dk1tTjFLQzl3c3NiaFVXMjJ6N1h0Uk5JMWNrbmlqSUJY?= =?utf-8?B?MUMvajhaTHBaMzltRUxHR3dPanFDeHM1Zlc2UG9HNlpYcDhWMjgySkw1enJp?= =?utf-8?B?d2ppT2U0eGlBc1FVR0FtMFVyeU44L202Tmg2T1RxR01pQTNqYTdVVVdJcjVS?= =?utf-8?B?MldYN2pvSE40aDZpdVg1ZENMemdaSXhzR2NnZ216NFFWNW5Wc1RsUExPWm5H?= =?utf-8?B?LzJkazVMVzJzWDE3NlZoTm9lMkxvanAydERSeDB1MEg3UlovaTF5cVFobDc2?= =?utf-8?B?MzlNbTBuYVdaOXNkRm56YUlJSk1hVWN1VUpnZWJVc3lPa2Nnd1pJMUpTbDRY?= =?utf-8?B?b1BPNGRTbjg4NWtTajl6TGl2N2k4RXJlclRLNURFOVd3WVErNnBvSTdRSDRj?= =?utf-8?B?Sm0vMTZ2aEhPTmlQa3psYXV5bmNDcEVudWJwd3RqaS9iNUFtVFhDdFpLaG1Y?= =?utf-8?B?ZVJsYUtBeHNjV0FsL09lMG5PRXBVampTajNqVzNsL1JycE5pWG0xaGJBSnZY?= =?utf-8?B?T0pFWGNwcHFsc2kxRnhVVElZdHI1L0JLTExPR2RJa0RPRFE3QlYwekpRY0l5?= =?utf-8?B?SzN3TDYva1BuVDZXb0txMVlZN2cyd0dSTlkvRmdwb2tlSDd1ZDhINnpYaUZa?= =?utf-8?Q?tUfx8rTde4h2M2S0HfnQsqaSt9K5IwsfeFGY4vr?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4614ffe4-7fd0-454c-1278-08d8f46175a2 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 16:24:29.8154 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KyP9Fh9HGk/9qBf/UHgSOcdbSeNBSZxv7XTk+jlonu096Hmbcpq81EqMxm20XOXWiah1RMUeDkJ6I2dezeLtAFkGWjvOmA+szhVXYqapZkE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3825 X-OriginatorOrg: citrix.com On 31/03/2021 17:02, Jan Beulich wrote: > On 31.03.2021 12:32, Roger Pau Monne wrote: >> EOIs are always executed in guest vCPU context, so there's no reason to >> pass a vCPU parameter around as can be fetched from current. >> >> While there make the vector parameter of both callbacks unsigned int. >> >> No functional change intended. >> >> Suggested-by: Paul Durrant >> Signed-off-by: Roger Pau Monn=C3=A9 >> Reviewed-by: Paul Durrant >> --- >> Changes since v1: >> - New in this version. > I'm afraid the situation with viridian_synic_wrmsr() hasn't changed > since v2, and hence my previous comment still applies. Only just spotted that line of reasoning. Longterm, I do want to remove all the Viridian special cases, and handle all of the state via architectural mechanisms (cpu policy for static settings, and the existing MSR records for dynamic content). A consequence of this cleanup is that guest_{rd,wr}msr() will be eventually be used to save/restore dynamic state in the migrate stream, which is why I've been engineering guest_{rd,wr}msr() to work for MSRs in "current || !scheduled" context. As such, it is important to retain a vcpu pointer because it will not be current on the save/restore hypercalls, which execute in control domain context. How much is keeping the vcpu pointer going to interfere with this series?=C2=A0 My expectation is that this patch would need reverting to continue the cleanup plans. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Mar 31 16:45:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 16:45:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104020.198490 (Exim 4.92) (envelope-from ) id 1lRdyF-0007Gz-V6; Wed, 31 Mar 2021 16:45:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104020.198490; Wed, 31 Mar 2021 16:45:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRdyF-0007Gs-Rx; Wed, 31 Mar 2021 16:45:31 +0000 Received: by outflank-mailman (input) for mailman id 104020; Wed, 31 Mar 2021 16:45:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRdyE-0007Gk-R1; Wed, 31 Mar 2021 16:45:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRdyE-0007BH-Fz; Wed, 31 Mar 2021 16:45:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRdyE-0003bz-2k; Wed, 31 Mar 2021 16:45:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRdyE-0006p0-2F; Wed, 31 Mar 2021 16:45:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2Qe/6s3aLTzVcy7UBGz6Q6zszbaVTK08N3e3hkbb4gA=; b=pEeHWfwZicHZTGmPn7Qv/Um2su JeOmUPQ//TDWRmcF3ftO+QJqNg85CbUrxSawnr7Vcs7ulLhJNZESE04kY9HQEkRq0xMhRJcdcZCsx 0HWumUeAZDDfM51xppSN0SCZIwZFq3vIrFnraIToVeHjQ14d6HLIdKS2Abyt8CgV/gFs=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.12-testing test] 160568: regressions - FAIL X-Osstest-Failures: xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:regression xen-4.12-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-saverestore.2:fail:heisenbug xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5b280a59c4dd8dad6cc8da28db981b193d10acee X-Osstest-Versions-That: xen=4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 From: osstest service owner Date: Wed, 31 Mar 2021 16:45:30 +0000 flight 160568 xen-4.12-testing real [real] flight 160621 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160568/ http://logs.test-lab.xenproject.org/osstest/logs/160621/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail in 160549 REGR. vs. 159418 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 160549 pass in 160568 test-amd64-amd64-xl-qcow2 18 guest-saverestore.2 fail pass in 160549 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 159418 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 159418 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 159418 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 159418 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 159418 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 5b280a59c4dd8dad6cc8da28db981b193d10acee baseline version: xen 4cf5929606adc2fb1ab4e2921c14ba4b8046ecd1 Last test of basis 159418 2021-02-16 15:06:11 Z 43 days Failing since 160128 2021-03-18 14:36:18 Z 13 days 14 attempts Testing same since 160150 2021-03-20 04:11:48 Z 11 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Edwin Török Igor Druzhinin Jan Beulich Julien Grall Olaf Hering Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 311 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 31 16:55:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 16:55:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104025.198506 (Exim 4.92) (envelope-from ) id 1lRe7d-0008G6-VX; Wed, 31 Mar 2021 16:55:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104025.198506; Wed, 31 Mar 2021 16:55:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRe7d-0008Fz-Rk; Wed, 31 Mar 2021 16:55:13 +0000 Received: by outflank-mailman (input) for mailman id 104025; Wed, 31 Mar 2021 16:55:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRe7c-0008Fq-A8 for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 16:55:12 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 941dd7ca-0e42-461d-9f73-260e717c1de9; Wed, 31 Mar 2021 16:55:11 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A83B1B1B7; Wed, 31 Mar 2021 16:55:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 941dd7ca-0e42-461d-9f73-260e717c1de9 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617209710; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dwXYn06xsaariBCOWNv8xq5GNcJP9Qy8s3k2lCYS7XY=; b=KFwW1tNE1NnNL8MfWroksI7JIIodcu+/jNcADswDc+a3L79J/BiFqt28esEN46x6tcED5/ uTNC8zLRijFxonJcMnqLIPkYgcUxBqNbaIj82Oif17gnUJ1tE+MLEssrMvIu88sjwOK8BL aGXvCczU1aYgLE7/Oh9GaBqQv/7c/bw= Message-ID: <800b163affc6334837006a6ef6f8e21415d874e9.camel@suse.com> Subject: Re: [PATCH] fix for_each_cpu() again for NR_CPUS=1 From: Dario Faggioli To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu Date: Wed, 31 Mar 2021 18:55:09 +0200 In-Reply-To: <4d993e67-2bdf-9ac3-f78e-daf279642de1@suse.com> References: <4d993e67-2bdf-9ac3-f78e-daf279642de1@suse.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-FQnXAOw4QSFuFtBZxbUv" User-Agent: Evolution 3.40.0 (by Flathub.org) MIME-Version: 1.0 --=-FQnXAOw4QSFuFtBZxbUv Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2021-03-31 at 16:52 +0200, Jan Beulich wrote: > Unfortunately aa50f45332f1 ("xen: fix for_each_cpu when NR_CPUS=3D1") > has > caused quite a bit of fallout with gcc10, e.g. (there are at least > two > more similar ones, and I didn't bother trying to find them all): >=20 Oh, wow... Sorry about that. I was sure I had checked (and with gcc10), but clearly I'm wrong. > [...] >=20 > Re-instate a special form of for_each_cpu(), experimentally "proven" > to > avoid the diagnostics. >=20 > Signed-off-by: Jan Beulich >=20 Reviewed-by: Dario Faggioli Thanks and Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-FQnXAOw4QSFuFtBZxbUv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmBkqW0ACgkQFkJ4iaW4 c+6sxxAAgBtep+8nzDMx2uwG47MWgbH1esYdefEipNxfYMJfpUuVABJqkFh89TnO orUg0nmIfFkPxvwFFfcy3yPh0WoLxVZZNT2t+UYmtiqXJRJEYU6E7hFg67KBpcgx o8g/DChpwU54zsiaE3II4PbYvmUwhJExzDqh7PPyIAMxjn/eZzS1MRlHbhj54HyL tXYpYikjenqQsk7lHC95MXBo4E+yFKWm7WcFeOxu25JoJV0xvofZDkl82julLoMN SdR/eEhtgT9GxoyisC3OOaXm/eNJfrEWu3zYfXTauNO8x6qUnZqfvpeWiDzjfrn9 6bNTOHAOnXyLLu7BLBcJARE4pkAxFshGSU4BfONqgExMkANMDiq3+d0hXWfYvTRy 7h6XfWhCJo1HD+JlZVSY/JveCLPp8TCwqLjG3D9bdE8QKIOUEytZHhqI7EoynxwE P9A4akah+AIF90wC/iNvVcA9feAYRq5Hmj31S72p0zESWyaO0FjuRj1pT1L/mXzN BGSYmsCMAmruQNEXFjoOsNxAmQHxzFmbJP1oJKpzaBhIRGDcav5K/KxGpJvuo9rD 1e5I0Wy5In7+zgaIdYmk6EdCxtz9+Fenoe3qt7TdNbaVBVkbuyGO7cVL91BQ8rES +2lhujFQ2KMhHi/phf+B/hBDFBhcW8WUnmVOJ+sUTz6gkpvj78o= =7O1+ -----END PGP SIGNATURE----- --=-FQnXAOw4QSFuFtBZxbUv-- From xen-devel-bounces@lists.xenproject.org Wed Mar 31 17:14:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 17:14:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104029.198521 (Exim 4.92) (envelope-from ) id 1lRePc-0001ga-KA; Wed, 31 Mar 2021 17:13:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104029.198521; Wed, 31 Mar 2021 17:13:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRePc-0001gT-GU; Wed, 31 Mar 2021 17:13:48 +0000 Received: by outflank-mailman (input) for mailman id 104029; Wed, 31 Mar 2021 17:13:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRePb-0001gL-7v; Wed, 31 Mar 2021 17:13:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRePb-0007er-0v; Wed, 31 Mar 2021 17:13:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRePa-0006yI-Qc; Wed, 31 Mar 2021 17:13:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRePa-0007Pi-Q3; Wed, 31 Mar 2021 17:13:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Qv/AMeDBqAJpVM68lvRVbAwQbqqEnmRwDjamajlQcy4=; b=UtuJd5bU8BZkxX7eQy4XXklzuF fcmH9gALJ31MxPB/ftjohJEjGCP8+JoobozX3Nk68dRcbk/9MRK5iwQNnJEwtz9RgKxSW4AobvpV5 j12aLHi32cIS0kuAdAAkMr/tZbP0MZt1XzJd+jjbCZvd0XqZpineqsmiRv0jz/gkKtlE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 160578: all pass - PUSHED X-Osstest-Versions-This: ovmf=62bad17dcae18f55cb3bdc19909543dfdf928a2b X-Osstest-Versions-That: ovmf=98ff7e3c6373d3e0590f953459b6234ab12edce6 From: osstest service owner Date: Wed, 31 Mar 2021 17:13:46 +0000 flight 160578 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160578/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 62bad17dcae18f55cb3bdc19909543dfdf928a2b baseline version: ovmf 98ff7e3c6373d3e0590f953459b6234ab12edce6 Last test of basis 160560 2021-03-30 13:10:07 Z 1 days Testing same since 160578 2021-03-31 06:11:04 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Dandan Bi jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 98ff7e3c63..62bad17dca 62bad17dcae18f55cb3bdc19909543dfdf928a2b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Mar 31 18:12:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 18:12:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104036.198541 (Exim 4.92) (envelope-from ) id 1lRfKE-0006tr-3X; Wed, 31 Mar 2021 18:12:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104036.198541; Wed, 31 Mar 2021 18:12:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRfKE-0006tk-0X; Wed, 31 Mar 2021 18:12:18 +0000 Received: by outflank-mailman (input) for mailman id 104036; Wed, 31 Mar 2021 18:12:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRfKC-0006tf-Jv for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 18:12:16 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 76e4dc11-0d39-42a6-a0ba-7000beba1a97; Wed, 31 Mar 2021 18:12:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76e4dc11-0d39-42a6-a0ba-7000beba1a97 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617214334; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=S75VCIDzg9DLy89De3wL8GHe5A3GMvEHgcvxZBLGdHw=; b=fktpfX1fsq7eGHD5D1Bcx/ek/EDMaT6k4zWsulnaU+fm/is79fjMXW4R UyU6eQ/lk/Bjk0yq2tw6gAO1I7PVo8n9ERHCaTkkniC7DvednZ3XNZxYU Pwm/Uy4pFYTAhqbWnD57JLBsCMaNcqYga80zcHfjGQK5qoAU0VBQEMlZr Y=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: s/Y7P3PHJJoRkPhPDvDvuI15fC1QmnwBE94pMPyHrMuTbM3/4oKVrySjn6Srmo8sNL5lrX97qz Wuv1adJVFsgYyFjDd8WRJxq4kNYo78ZYfuPCbfFwCZTItdY6K/rnP8ZvJ5ec3L0AMd/UkeAYw4 egaiWHh0wvTBIod76wlSy280iRIBDkO88d/7p1Sn5pGBKdTuPm/SUFFyXVyRA4OR+tuUC4QOZi qt2W9S8L+YgY8SIiPBHeXJ818DMGevHIlGZPn6gYvY2lOvGa7O1fPcVgrIQp5p5V+wTyK6H9jM 5YU= X-SBRS: 5.2 X-MesageID: 40595913 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:J5wVjalmKOtZaLBPnXZ2GoYp2PvpDfOFj2dD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLNxAZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 ldWoBEIpnLAVB+5PyU3CCRGdwt2cTC1aiui/vXwXsFd3ARV4hL6QBlBgGHVmh/QwdbDZQ0fa Dsm/ZvjTymZHgRc4CHFmAINtKz6+HjubDHRVo9BxAh4BSTlj/A0t7HOjWRwxt2aUI2/Z4M6m 7A+jaJg5mLl9Ge5lvi23TI75JQ8eGRhedrIMCXkMAaJnHNp2+TFf9ccoaPtjw0v+2jgWxC+L KnzntQXLUQ11rqYmq3rRHxsjOQtwoG1n74xVeUxVvlrMDpLQhKcvZpuINDfhPVr3cnpdF3uZ g7uV6xipw/N2KloA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJ8Cv47bWzHwbFiNN MrINDX5f5Qf1/fRWvepHNTzNulWWl2NguaQ3IFptee31Ft7TFE5npd4PZasmYL9Zo7RZUBzf /DKL5UmLZHSdJTSq5hGuEbQ4+SBnbWSRzBdEKeSG6XVJ0vCjbokdra8b817OaldNgj150pgq nMV1teqCo8YETrBcqS3IBa8xzETWmnNA6diP121txcgPnRVbDrOSqMRBQFiM27ucgSBcXdRr KyNfttcrreBFqrPbwM8xz1WpFUJ3VbetYSoMwHV1WHpd+OLoXrs+fcYevCPbaFK0dhZkrPRl 84GBTjLsRJ6U6mHlXihgLKZn/rckvjuZRqEKbb+OAXwJMXNpJFtxUUjVjR3LDJFRRy9ogNOG duKrLula224UOs+3zT0mlvMh1BSlpO7K74SHNMrw8SO0byebIO0u/vPlx67T+iHFtSXsnWGA lQqxBL4qqxNYWX3j1nIcmgKHimg3wao2+qQ58QlraY39rsfoo1A/8dKepMPDSOMyYwuA5x7E 9fdQcPRybkZ0/ToJTgqKZROcbyWJ1XhhyxLctdtHTF3H/s2v0Hdz88RD6hUcmenAA0YSFb72 cBqpM3sf6nhSulL3c5jaAeNlBBAV7nW45uPUCieJhenKztdUVLaVqywRaeix01ZwPRhh0vr2 T8MCyZfuzKCFJBunZelr3n6k9wa3/1RTMAVllnq4FnUWzJtnFvuNX7GJabwi+fbEAPzfoaNy yAaTwOIhl2z9TyzxKNni2efE9WjKkGL6jYDL45davU1W7oIIqUlbseF/s8xucsCPn+9usKW/ mYYQmbMXfxDP4owRWcojIgNDNvoHcp1fPu1xuN1hny4FcvRf7TKk9hXbcVPpWV6HXlXe+B1N Fhls0u1NHARVnZe5qD0+XafjRDIhTcrSq/SPwps4ldueY3uKFoF5fWXDPU3Bh8rVgDBdaxkF lbTLVw4bjHNIMqZcAUdi5D9lcildiELiIQw0XLK/57eUtog27QPtuP7baNtKEmBVeZohDsfV aY6C9Q8p7+Ll++/K9fD7h1J2tYaEIxsis/uOyDcpDdEwWseaVI+kGgPnq0bb9aT+yEFNwr32 RHysDNm/XScSzynB3Ut398JKlF9m68W8O8AA6WA4dzgqqHEEXJhrHv+dK5iTf8VCCyZEsZj5 BUbEB4VLUxthAyyIksljWoQqP5okg5g0JT7DFumFnqwJWn6g7gbDR7GBychI5XUzlVOmWJis qA8fHw7gWM3AR4 X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40595913" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KyvPJizSFtmCUEhLaV9gUEoY8Mag9i0s+/nzaJL2eacPbh5jSwOrDXudv+ibbk9Kz4cSRiHBY1ElDZT4hA1ycMLnNr3W4JjTRcunx6kMEVqr+TP5RtxbKfb9Lq21+eUfdYpO5WdDFuuw5eIGyQJQ71qfOlgCsSYUuK6AiMEr8f4KLC5s5PEku6h29VT9FowOPPS9kzG03XEZM2kDB6iR1g+jOSU+F73bRO7innya+sHRmrK17XpIqq7uQWOhdp73cBA8XVYEXNqTAQHEheR0EGWPX7KsUw6eswcIZNzGmbJ4ivCgNNnoUROWRMgFTDNySTKy1ubi8UPc34eT1+AotA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EqJ82BC8tToa5rQwqn4fcXS2D7dcS2uhCCHczhIgWUc=; b=f4Q21wwW+6+/gdV6piNFBLi7CJW/f5PSG2C5EYbWQRHGKAESUFRA4nQUOMnK2sJOz6f1ZKuOyw6zy/t8wCSMylsdGYStl+gZf+H0pOxfjKTJM2Ut+v8RNtrNPxT6iL5ohwROj4uu/RXY6srlao2faCdZY49fJ2vP16Ma15X0bxMDvvpvlL3wdzImk0ggLln7Mz5ke7Jq394Dh7P7R9o4HqCMiZbItzNySvxSUj89QDFR/MCiSUtPYGAss6lTj7xjq/9T0muPyWBouYVWiL5LS5fMzp/+fLHCj6LyshPd7rFZHHhJB0ZjBxAnJbV1ZWUAa1McBmvf2wlrWnsp8XwXRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EqJ82BC8tToa5rQwqn4fcXS2D7dcS2uhCCHczhIgWUc=; b=A/l2tcnUgE4LDr44Qw3RaXCx5CEAd3aN6QEHVzWsWlXOPkKd6CUSGM7QqekPbC9HYsrkoP2BNGZ6Q8rif4p8Z2mS+r1l50QuztB9JMmxcVso3PGl6bRJYiHqF6jwNB3DojqEsiMRFdagXs9Z6E7I9lpXiljdpmaayk8V+owoMso= Subject: Re: [PATCH 01/21] libxl: don't ignore the return value from xc_cpuid_apply_policy To: Roger Pau Monne , CC: Ian Jackson , Wei Liu , Anthony PERARD References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-2-roger.pau@citrix.com> From: Andrew Cooper Message-ID: <02dd3e4b-a5a1-dbdb-e887-bf0cdf1132e8@citrix.com> Date: Wed, 31 Mar 2021 19:12:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210323095849.37858-2-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0452.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::32) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0c823477-ad5b-4e7a-5c9b-08d8f470809b X-MS-TrafficTypeDiagnostic: BN9PR03MB6025: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3631; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i8xfE48n4dntbLnfKReTG4gfP/WYZQDRECyFjB5IKhyezkzvIngijIqQeY6V1WzpGSz/vIADch4vAZiOF4IlYrhAjUEGWkOsnhe2BYxtKshtwopw0pUbA3bYBPUO4zC9tlwnb7nyYDLz7KCZ/Hckqn65Fws2TnbSjkAZAajbErK3i1A01xV0rFv31yUdnyUNVwe+CyQ8Mt1ouRIZRf1RrYFLaBvmTQjd3O5PusrRGD6bV/4UNLDfyyNDUoLxm/QbJxyb1peAavBKt0oJVtrwsr9CXEM5ElQPcxMTwUAf2vck2sEFgoTArFF1kY2+u8tJbuIsduY3DUGSjZKl88+NOo7It+QyENcKo92xaM1nlscLt+/G8yMZPguJulrdqFbPt9EnXgYJeFTOWwAXVHGfyzNVeRYpuU9C0y8h2xBTm5a86oBP3e/q7ktsiJX8CmHm43JUDmgSY6QtoOTRb8MZCMj5oe7Pn78v8U/lz1xPNjv6bApWiosq2ZwScWskmLMPSH0qfIcwbnQAnf+YlqO74t1s7sa140ErVlfbjw87K+fQszH/szoBsuMr28PJiQkJK/VhMU7UkU5kt1HL3pCWHjs6JMtR0gqSFol75KQJFocOqTVVfi3y3y1i95SMOIPYMooZQgmL+PwEVFCp/HibqEGk0gZR7zEZmpqvPQO849LxAtjOumuJtlrvjS1PcI7fXvkUeaLJ5l6rD//VKiY8W8d/L7ttQJ8gOCGTt6ch90s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(396003)(136003)(39860400002)(346002)(16576012)(54906003)(53546011)(31696002)(2906002)(16526019)(478600001)(66556008)(66476007)(6486002)(4326008)(86362001)(26005)(31686004)(4744005)(5660300002)(316002)(83380400001)(38100700001)(6666004)(186003)(956004)(8676002)(8936002)(107886003)(66946007)(2616005)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dWRPckIwNUtGUEVRZVJHR1FnU05BVmlMMTNNTnZrNW5mcnFUMjdZRFBlVWkw?= =?utf-8?B?N20yZXlCRUFLREM0VStoeERuRitwK0F0ME9oSEhvN3BaMmJrR1NxelVOQ3RY?= =?utf-8?B?dG1wSFNpbTFoOUNSQjZIazlaVG1HU0l6TTRQNXdjbFZrQlJydm4veU1sNFgx?= =?utf-8?B?R0xlNHFpQWtPdENVR1VySVI1d3JhNWRTQ1BWUy9BTVp5blljbVBWenFEcmp0?= =?utf-8?B?UlJ3ejVBcUZrQlIzcWVpR2ZzNEdsTmp0VDdtUEFrOXNwb0IvNkRQZW1TdkF2?= =?utf-8?B?ZGZyVW52K1ZPcmNBRnRrZU9NYkJFaUVNMEtRNFUzb09ySkI4eTRBWmFGaFpD?= =?utf-8?B?cVRvU2U5azJJWFJSWjdkWm05cW91MW1iOXBCdzJia0hEL1BDYkhPcFJzcU1s?= =?utf-8?B?ZU9JSEVSNFlLZTgycjFLeDZTMk5pSm9yWkxMMG5keXNGK295b20vcUg1aE5m?= =?utf-8?B?WnhEeGVabUFWTjUwZDZXME1ocHpteHM5U0pTb3NONUNqcFB4RzZSd3d0TGlj?= =?utf-8?B?N3ppSlF4dXV4MlpjSjU1d3YvekxNc3BUVlJ4ajkxY01HTGtPT2Y3dnkwWVNO?= =?utf-8?B?MVg4d1dRdjFtOVEzY2g1TlRZRVhnM3ZhaTFTV3llUW5xU0VMTE1aN2M5VmZY?= =?utf-8?B?akoxOVlWZWNBTWlIajJXb0ttN3lBT0JibFZuUi9aZUlYMHNCVXFlQ3VwZmNJ?= =?utf-8?B?Z2plVnMxdnplNmFianJFbGtQY0ovcmNLZlp4ZVJtQThUNmxiY0JVOTZtSmxD?= =?utf-8?B?c0NMZGtrVnJIYk1HalJNRGYzUCtpVm5aeUcxYmFnUjkreWtMUStDRURydWZS?= =?utf-8?B?YWMySVhBbEJVQnB2bGZVa3FUSnVoSDQvVkU0OVBPTmQzZzk4NU5QWVlaQ1la?= =?utf-8?B?S2ZFTWYxbEpBZzd5UUwvZGFQODd2MVF3Y1E2eHZJUFM1QndzdmRLajBVTTVw?= =?utf-8?B?Wkt2NEZTZThtQ2lMT2d6aHRBaExFRUxsQ2xhZ2VtN3hoRlNSZlNRY3F4NmNC?= =?utf-8?B?emFOd2pmSTRCeVFOOVd0eGVmTVZIdkorbGVpbnp4eDNORUxacEdGNVZVY29R?= =?utf-8?B?YXpxWmRpYVlIOXJXTzNBcnVSeGJxSlRib2s4cTZBSzBMa3BZTzI4MkVTTXdl?= =?utf-8?B?M21sTkFQZFRoTGFIM2dTYVl6NnZGNXgrZGhXNElyVTBCWVAxWTZqRHdYWkxk?= =?utf-8?B?Z1NMU1pTWFZsY1J2LzY0VjRNSndsbkEwRmRBZEtNd2NEL253dUdVUFloaDN3?= =?utf-8?B?VlJQQzVKbUx4N3BZaTM4WE1Hd1BTMGdaeExmMFlUdFdzN0JtUk5KdnBIZjBI?= =?utf-8?B?RXZmeVozVkwxUU10MmdmM3pNQm9KdkZqemwwelFVbUFaSGFUVkZ0Nk9oa0xB?= =?utf-8?B?dENwVk4wUVJpNE1LQXBBd09od1h3QTF4dnBYSGROSlArN2ZsTDgwSHBNRFRE?= =?utf-8?B?bk5DZzhuazFDcUJNOGFHdXJ5bjV5Y1g2SHN6NUwvZ2l6TjBjVFl0SlVBTExB?= =?utf-8?B?M3U4ckpxVHBsM3hHZ091Y1BRaEhCcFl3Tk5maWFaVW9maTI1alZ0aFpFTUVO?= =?utf-8?B?UlQ3ZjVLSFRWdWsza2o1T0RnMXNlTGg5QW9kcUNqTGozZW1DWU5QOThmZisv?= =?utf-8?B?cjhhZmJoSEU4WmZuOGRqWC9JTGpkR3pWV056b1AvRWwvMkNtK2cxL25NUjR6?= =?utf-8?B?YklHMXVOV1k3UlNqOHQ5b2NCTnZkQVJybkV0a0xTT3JNUG4vdmIvZEdSbTAv?= =?utf-8?Q?S4oiu/lSjx7hYBpilBIomoA5TFTKzdSAbjbkIZJ?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0c823477-ad5b-4e7a-5c9b-08d8f470809b X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 18:12:10.7882 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SL5u7OhqS4VoSVoGPvxgqTXuj1XHDqMXi1kLgZ7U96idKXS/kcmSRHFx/coysC7fYaF7NeoohQU6bLX1tGywvHoRRjE54jGSuZqKg5x9fpk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6025 X-OriginatorOrg: citrix.com On 23/03/2021 09:58, Roger Pau Monne wrote: > @@ -462,8 +464,13 @@ void libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore, > itsc = (libxl_defbool_val(info->disable_migrate) || > info->tsc_mode == LIBXL_TSC_MODE_ALWAYS_EMULATE); > > - xc_cpuid_apply_policy(ctx->xch, domid, restore, NULL, 0, > - pae, itsc, nested_virt, info->cpuid); > + rc = xc_cpuid_apply_policy(ctx->xch, domid, restore, NULL, 0, > + pae, itsc, nested_virt, info->cpuid); > + if (rc) > + LOGE(ERROR, "Failed to apply CPUID policy"); If we are planning to take this patch, then you need to convert from xc errors (-errno) to libxl errors here, or the caller is going to receive gibberish. ~Andrew > + > + GC_FREE; > + return rc; > } From xen-devel-bounces@lists.xenproject.org Wed Mar 31 18:24:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 18:24:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104043.198557 (Exim 4.92) (envelope-from ) id 1lRfW3-0007ti-Cb; Wed, 31 Mar 2021 18:24:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104043.198557; Wed, 31 Mar 2021 18:24:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRfW3-0007tb-95; Wed, 31 Mar 2021 18:24:31 +0000 Received: by outflank-mailman (input) for mailman id 104043; Wed, 31 Mar 2021 18:24:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRfW1-0007tT-AN; Wed, 31 Mar 2021 18:24:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRfW1-0000Qv-02; Wed, 31 Mar 2021 18:24:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRfW0-00019O-NL; Wed, 31 Mar 2021 18:24:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRfW0-0004s7-Mr; Wed, 31 Mar 2021 18:24:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5IL2LaGPis+jB8D2GAq0AYL90zOa/3FSQ5ExkKTV/PU=; b=VYJChTq0LRXXwZe2ag2oFuaH/H cCuFQaQMp9asDkPoXrRh3SjPb8OzMjwHbdH++yV6RGQIpxSs9CL/XjcANJ6UxAqWw/owxhTPpBneI e9/+ZUIHINTbTDNA/4aC9+OfC1rp4V3O8i2ufNNrC09oLLNQ7uUZPWj7T/yrXkBfHPlw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 160573: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-amd64-amd64-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-i386-pvgrub:guest-stop:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-localmigrate/x10:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=5e46d1b78a03d52306f21f77a4e4a144b6d31486 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Wed, 31 Mar 2021 18:24:28 +0000 flight 160573 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160573/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-amd64-amd64-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-i386-pvgrub 20 guest-stop fail REGR. vs. 152332 test-amd64-amd64-xl-qemuu-win7-amd64 18 guest-localmigrate/x10 fail REGR. vs. 152332 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 5e46d1b78a03d52306f21f77a4e4a144b6d31486 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 242 days Failing since 152366 2020-08-01 20:49:34 Z 241 days 412 attempts Testing same since 160573 2021-03-31 00:40:51 Z 0 days 1 attempts ------------------------------------------------------------ 5275 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-amd64-pvgrub fail test-amd64-amd64-i386-pvgrub fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1311483 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 31 19:03:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 19:03:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104047.198572 (Exim 4.92) (envelope-from ) id 1lRg7t-0002ut-7P; Wed, 31 Mar 2021 19:03:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104047.198572; Wed, 31 Mar 2021 19:03:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRg7t-0002um-40; Wed, 31 Mar 2021 19:03:37 +0000 Received: by outflank-mailman (input) for mailman id 104047; Wed, 31 Mar 2021 19:03:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRg7s-0002uh-0j for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 19:03:36 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d0d6f1f8-655c-422a-b03d-8e5e21412f9d; Wed, 31 Mar 2021 19:03:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0d6f1f8-655c-422a-b03d-8e5e21412f9d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617217414; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=V9/8qUbHBO+ZdA99CkSVK+Eec1ubi0kDdOElr3KCI7k=; b=XU27g+dZhfSWnim00iHj2kD2wk3Wowp3GC64hbdY5o3WaoSOMavQAJkC 4oB/vmIOJMMzgsMSd9V8X2Vq+NrKLeaIQdTorRh6SsdaKXlJPTqQ0exj5 Sb+1e+Tjn+7MufQMKe4fDKNHfU5mnmDXOJif3eTi2g2vkaunsG7EjliFx s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: U/TDjeL2zJA8y8KG8y1PYOD8KYaQxCEWVbGp1ms7fKmqqN9iyVyCicNsbw1Wxwgd8GjuKs5qDe VX5NfNH5gtwdq7x1A/qLR5jGrBZvBIfFWpEnt6nJuRCrKFlHQhAVwh28Fn8JsZCRsjATPkkcBM a1VvbwpLY7AWGu4GLwISJk1qd+LRMbbLHCxFLPPzLBzaC4MjDPVLayjNjJUCCNoiRG1JxlBL8/ 6HJ2J+6i14R1JLFExzJmkxwQVjIbqQ+qyYXFujRjsQpQFE5yNiwulzIggOzPMNRVjM7wx/5znj Xes= X-SBRS: 5.2 X-MesageID: 40602068 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Qu+6vqik3vXv0EIIFd4ayfc34nBQXwh13DAbvn1ZSRFFG/Gwv9 yynfgdyB//gCsQXnZlotybJKycWxrnmKJdy4N5B9efdSPhv3alK5wn0Jv6z1TbaknD38N+9Y MlSahxD9XsEUN35PyR3CCUG8stqePpzImGnuHbpk0CcShPS4VNqzh0ERyaFEoefngiObMcGI CH7sRK4xqMEE5nDfiTPXUOU+jdq9CjrvuPDSIuPBI79BKIyQqh9b+SKXOl9y0DWDBCy6pKyx mmryXF4MyY0s2T+1vn+EL4q79Xn9bgzdUrPr3wtuElbg/CpyztSIBoW7iptC04rue1+D8R4a XxiiZlBetfwTf8eXy0vAvM1mDboUkTwk6n83C0qz/CptH0Xz0zAcYpv/MmTjLpr3AOkfs59Y Aj5RP/i7NnSSnusQ642v3zEzZtrUawqWpKq59ps1VvFbEwRZUUkZYS5ypuYfE9NRO/0q8LOs 90AvrR4f5HGGnqFUzxjy1UzNugUm9bJGb+fmEy/sic0z1hlHtk1UcvxMsGgnca9J4mIqM0n9 j5Dg== X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40602068" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W7rA/OhylL2GGYbbU4jjjfgVPvph+GN4z/5hS+cz6XHG3Mw5kyV3C7hfwDKjOVJIczmtXBKF3agGIIlNEdrWuyzkDHAznKrIID97Ggvs5yGZNWEwCzsvLP9S917qmb34t6pKj42M00azel9APp4j4JZJ5+8u0Rdu1F+MvzcUnNpEmY4MKePUYHlYkdiMz2D0XvUfjlbyFNiZuF8rNukwc8Lb7B0m1XrjvrabI+mTd/1VPmh5N2rFKS9mOuO7HJ1kV8KFJ/Qm2RUGXLrFFlHVOySL4f/3Xz2HUcQajPSrNroGU5vc1QE56FBjGOGnamaW12Yn+zmv72xvJMuhnLy6tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V9/8qUbHBO+ZdA99CkSVK+Eec1ubi0kDdOElr3KCI7k=; b=Cja+DgJh3Q3DU5H/dwqLbK32e3gqtbSpEsUiYOcFSnOJNWJ8BOBgYHA5cC4kLggPUZEW5/xvYiI45+Tgd0473GNLkDApX4FcfZge2y+ioEhwnUzSlPV3IXhynZj9pXGp/5+sf2j5BOTjyVhltCp+2KJAG3rSWRIpeeadtdw5MbeEu2AZKS6ldQwiXvz1aBlblcgzD1Y5QvyCEK69AGKUNdlxJ8P7aIhF3o0BMX8IPMdMGKy+53RLs4MRTm8hVqwmaxjyAqnkuFIed2FEEtHwcnnLQv6mak6+ZlqSCGrVj9g3zdD0p3iB88bk5KQolyEUOGfRsU2XBKG2FJZijTWN8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V9/8qUbHBO+ZdA99CkSVK+Eec1ubi0kDdOElr3KCI7k=; b=qUMyI3pc7Bykl3bpaucZFtQOeacON+rRloR0MtJuP2j2q5rhWwVDUbvNHwIi1oUiuGfOiLIfE1+jnYMxDOM1ZJ9ClWHiQoB1vjr08qmGRN1kiVj6EyGorKJZQ+BQTtMoDH/4RwKDxycBfjuKavDgN55Pza599VF1bnLIifeqRwI= Subject: Re: [PATCH 02/21] libs/guest: rename xc_get_cpu_policy_size to xc_cpu_policy_get_size To: Roger Pau Monne , CC: Ian Jackson , Wei Liu , Jan Beulich References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-3-roger.pau@citrix.com> From: Andrew Cooper Message-ID: Date: Wed, 31 Mar 2021 20:03:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210323095849.37858-3-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0116.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::32) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 864c98a0-9031-4558-e5a5-08d8f477ac12 X-MS-TrafficTypeDiagnostic: BN7PR03MB4516: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1013; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3LLThX1XH0kJ/ZGmpREqj0fRmYOZWWRiUPX8mifrxxy8HtIUrTFxyw8Olxm/swrixPSDhtVidr5QZVDxBF8ZULVs32js7cEFDe9klK+iTeYFACimpvtsPvKDAqnQ1PViK3dOuFt+vYgYh5FXahun1c+Q7AqqMgg4dxXUkFE7yktugpXO6uBHTcHUu8/TLcvtZA1ZcgEo2/5OdHPVCv9/XB5KKD0kpzHqexaNJo3cfESDa4Wt1+3pMcr8+WUXTT37+YuvX41m3tZFM1JuRkYJjwvVkH+6hu/zg5AacQF98lbjYVVlFAu8sH+7+B80/meg3IkwVJBwx9WqgUYS8Qo2gB2NlBw06HgndG3Av9HksOfJb9mpF252vv6lunSSR8gv78l78tckeSWCE5wuBfpeu+OYr9rmJUOkYdlKXjdhL87L4zuvBizyR2oJPJ+uT1kwo4xBEp3LZBrR3YgoqoruMa7F/Xp95Mzflawx6hFuRPrDGe+Fm80/5CWZtqhWYJR8EoHRtox58ZmMRXUXyYBYu0Ub27dT5BSVk2OtCYQN9sWnMZHujaE6QqJIxeUgWZNjUN+7sth9cCQa884uKZwT+B2F5vZykGqyFdJSshZ2az/8JQHQmspW9rws2AW2JkyRkPEXGta5UwbomxDFQD3hx/z1y/2jyOD7ptLrzp2yvXZIbXTLn55qPY+ilK4eygYOcYyr3EVbTIRX+NiQbO9KqQJOVTAfWw86MCBKYjcFZYs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(366004)(39860400002)(376002)(346002)(66946007)(956004)(66556008)(4326008)(31686004)(86362001)(31696002)(54906003)(53546011)(16576012)(6666004)(26005)(8676002)(36756003)(316002)(66476007)(4744005)(6486002)(5660300002)(16526019)(2906002)(186003)(8936002)(38100700001)(478600001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MWhPRnpGS3pzNDZOcFYrK1Zsd1F5U2l3Y2lLangxTGhFc0diaHFSVHdpdkty?= =?utf-8?B?L1BZdGVMRkV4RXE3cTQ1N3AvNHRjWjYvNng2UzRZTHM1TUFRQ011QWlZZEVj?= =?utf-8?B?dVJQMHl6T0t6MzBEbUxRc0tnbkpzc3ZVM2VrajMrZi80OTdLaEh2bkdkc3VP?= =?utf-8?B?M0N1bVFKWE9OTS96cUhqd1o5Yis1TE9kckJaOGdadHhrckRxUmFQS3FGcEZJ?= =?utf-8?B?WDBVTGJYWldnVFZ6UDU1VXdQVjZNVExpaHRQbjk0MU1ZNnErQXV6Smp0WFkx?= =?utf-8?B?RDBSQ3N5dHF6OUpMVEVqTkNIV1Z6ek5IdVk5VUFqQ1o0LytyNkh2OGRJdXZ0?= =?utf-8?B?UG1ERTVrUmF6VmV5eWpBdHI1MlkwcnhULzd1ZWxDN0JiUXNYblI5UXZCelhZ?= =?utf-8?B?eXhoVlBXWCtDY2hBb0J4ZEVZWDhrQlBvYlc0R21ZTGlaSkJ1SktFTW9qY2dE?= =?utf-8?B?MFlOMEI3ZmJoMWtpbHlxeVdSL1BielJML25nSTlsQnU4aXFCbTNhVFg1Vktu?= =?utf-8?B?cmVxSC9JNUIyc3l6ZThFRFI5SGJPNy82K2laWktibmZYbzhYbVRZRW9aT0ZV?= =?utf-8?B?ODRIMm1FZElnTkk5SUtxSVY3dXpyYnFQQk5hbENPWUcyZkd3NDZkdnlTL1Q4?= =?utf-8?B?TThaZ1pBSElTb3phWGFuR3hUQTljdTNRZ2NTUEhrM3gxQkFCUldPMnhCUnZS?= =?utf-8?B?ZEZYYjNKZVI3Z3R5aE5mYnJTakFKdEh6UCtTS0EzWkRkM3N5ZXFFUzhtUTIv?= =?utf-8?B?akpGVm1Ga2lGcEx0bVpxZ2w0bWdsc2dJMStJWmNOT1RYQnJBT2FrOTBwaldu?= =?utf-8?B?WHRrVGNYSE5VZTBBNll5R1B1cFZ0T1NWc1VZM3VkY0ZmNjNCZkZLWkNjNjFS?= =?utf-8?B?S3RLUXZNaTVGenRYcFh3NE15cGw1WVBRWnNZaHA2dlI3TXRvc0IyTVdsV0l3?= =?utf-8?B?Qnh0YnI5NlhTMmhVekNEZkNEOENYMSs5bnZvMVo0S0NjekprenNUR1c1ZTlN?= =?utf-8?B?aGlmNEVQQm0ycEJuNHFuQnlTUWE1enp5Y2V3QTVacktLSzlPRXo4UDhJQjJh?= =?utf-8?B?eW5zeTFOazBveU1uRVl3d1gzYW9nbmhzRXB3NDdjOFJ6dHo1NFhxdWRDQmgv?= =?utf-8?B?R09CMmxYUEFRUHZ0cEpyamRPQnMrUXpTRHJwNlVDcmZQeXBTa3NSdnRvcXEv?= =?utf-8?B?TzY5ay9UK1VRYm05VG5sWTZTMUtjY05qeEJPU1NCa25NVEZhWGhaL2ZicFN1?= =?utf-8?B?ZXA0WU5mSXJ6ZVlFK2Z0VGwwL3NhRVVXbkxrVmtEWjZUVzVFaHhWTWg5SVZH?= =?utf-8?B?aTE0VmhOVVNZQ1g5c3BtQlZ5d3c5VGk5eVQwVnFMUmh3RW4wNDlxdTF2Vkw3?= =?utf-8?B?cjBkdUFoU2hRRTFaOTFET0VDUFFPT1MwYXZWRm1TZGxBdnlTR2FiZUVSSW42?= =?utf-8?B?U1dET1F2VE9VbS9reXRBMEVHZG9GQ2gwaXdRUy9iY0d1aDdJSFlTcmZaU3VV?= =?utf-8?B?ZmU5S3ZlZG8wRlplUU1xQy9LdnV0Y0c5ZUhxOVBha3Q3d0RZbVNvbk8wKzhX?= =?utf-8?B?ZFZFUXR5cXNHZ2hsOHRrR04yUFhvZC9pTlhCMXZTOGpWcmVDN1FiYUZaRU9U?= =?utf-8?B?RVhKNnRSMTVLN09zUTUwemMwZlZpbC8ydzlnQ245ci9pVVc3aFZoWHZHWW5n?= =?utf-8?B?YjFVQzQrM1llazhXY1dMclBjYTEvT05sVnAwL2YxQ2E0alBubFVnK1pUcVR6?= =?utf-8?Q?VfXDd6XHYOiX3uLEhKZJJGQsvw2DvnhmKNtieaR?= X-MS-Exchange-CrossTenant-Network-Message-Id: 864c98a0-9031-4558-e5a5-08d8f477ac12 X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 19:03:30.0159 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1o6y9uJgSooMCcX8BGBHG9Ml7ujtkNvP4ttXzg3x7alLd58EDkMWP5YgZEYgBRcEhY137gmNVXNM5vRaZp6kPaqFfA2bE4uV1MpeNAIAdfs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4516 X-OriginatorOrg: citrix.com On 23/03/2021 09:58, Roger Pau Monne wrote: > Preparatory change to introduce a new set of xc_cpu_policy_* functions > that will replace the current CPUID/MSR helpers. > > No functional change intended. > > Signed-off-by: Roger Pau Monné Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Wed Mar 31 20:10:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 20:10:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104057.198590 (Exim 4.92) (envelope-from ) id 1lRhAX-0000To-IR; Wed, 31 Mar 2021 20:10:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104057.198590; Wed, 31 Mar 2021 20:10:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRhAX-0000Th-FR; Wed, 31 Mar 2021 20:10:25 +0000 Received: by outflank-mailman (input) for mailman id 104057; Wed, 31 Mar 2021 20:10:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRhAW-0000Tc-83 for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 20:10:24 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d9df1e0c-024d-4da7-aa4f-8e10a55dea1c; Wed, 31 Mar 2021 20:10:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9df1e0c-024d-4da7-aa4f-8e10a55dea1c DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1617221422; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=B6GHuyVmMhiSJNcskPiK0lbFVY0nsWzhpHNVDXd4y1w=; b=iPig2xyQTpLMlVkWaq2Zp+rimtQ5xyy/or236dy7lxmxMmqniMySe6Ij Zy0IbYes11YvVY5nnJNT+EnBjaUI0PNjbIKXiw5vrKc17xIPOqWQ/TtZp VNxjK7zikDHkh/UwV+aJQt12/hjZwYWyUfz+WYS67BOaT0awpa6ENnsbz 4=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: ZlJ77bSq1IiLsy8msoCCjKzWWs8hQwUU9oFk247V2EVEWoa1fXWh3bnptF3jUeJ4lTh/RKoinP Ux9cfPwEhJV8c8p2JMT38kL26QMEqaxD2w2qM9IKIiknaRcDsYhiVWT+AwsGvnupstpEKIjm1Z 2cOMnO5u0qMLNR4yS6su/Im0JOQE56EeGjjD4Jsh5Xd9YIhmkpmTFV3xqBYH76DjLpjhedUDmP aMmXsK64dMEbqVhdcyV+2FHrG/R9pqSKEmEuC9uDKDBi11FwNJsHcfmU0pww+VUBgtm4m+fzoS mIM= X-SBRS: 5.2 X-MesageID: 40592358 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:HXv3P6hHyfTw/MerL5dyPtqS73BQXwh13DAbvn1ZSRFFG/Gwv9 yynfgdyB//gCsQXnZlotybJKycWxrnmKJdy4N5B9efdSPhv3alK5wn0Jv6z1TbaknD38N+9Y MlSahxD9XsEUN35PyR3CCUG8stqePpzImGnuHbpk0CcShPS4VNqzh0ERyaFEoefngiObMcGI CH7sRK4xqMEE5nDfiTPXUOU+jdq9CjrvuPDSIuPBI79BKIyQqh9b+SKXOl9y0DWDBCy6pKyx mmryXF4MyY0s2T+1vn+EL4q79Xn9bgzdUrPr3wtuElbg/CpyztSIBoW7iptC04rue1+D8R4a XxiiZlBetfwTf8eXy0vAvM1mDboUkTwk6n83C0qz/CptH0Xz0zAcYpv/MmTjLpr3AOkfs59Y Aj5RP/i7NnSSnusQ642v3zEzZtrUawqWpKq59ps1VvFbEwRZUUkZYS5ypuYfE9NRO/0q8LOs 90AvrR4f5HGGnqFUzxjy1UzNugUm9bJGb+fmEy/sic0z1hlHtk1UcvxMsGgnca9J4mIqM0n9 j5Dg== X-IronPort-AV: E=Sophos;i="5.81,293,1610427600"; d="scan'208";a="40592358" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QiPb9oxl2lUR/VJgyMiBEk5Jjl7p7zYlDLVpMHe8rAVLaooIpqFlDIbssL1+C4XyKmSmXd/cQDaATVXcogSxInHv/JZTnhldDskS3khwtg8HDEyRfAnJPWC8W6NdOPw46mUh7nYq2ooHIfhMz0WxrqTRBhTNAf8zlNBZgah/VLDtaxQ3CSOlg0Ok1I0LAuj/onEYiyWPj/sqwez/27TTEiE4gf2rBY8edog3bR/YokRK5CzI8CrsEm4pTkDWFBPX+li2t/lyqa3uD1vS0E7Vgq33VLYzCaa3t6pAlGHFIbtQEoVOhub/Rfwb0btJmyyUC6++R6njiknhATpgPtkuMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=29YlNYnM2DdZ+kxuHHV6vjXlNq+Y15PLPSQmAkLDxyU=; b=bSPXZfILyXkj1zcpWDintGqsplLd6WiELjy21OYPbTfPZUSp8exKZa64XH3tZQljA5lq35o6WU/1aAfp9/gasWPBEyqPCI13HwHuDm3rhSUd0Ed5je5zUHi/fJWRyj2aNv0M13BXXUT/u74kPHjL5VixdrlKLW+PSM8XSddYr7blIAtUsfm4GIw00OmW5pClE5UJiPz35Q/vligntd+vky5GymlQqqbHo/5WV3g1FNw2pCxoSN3WJlx9u9QotJxJtq27S6QKu20f78Ry0QryxfSoLqs4z4eQ0jjk/BEnI9pt3zH033J6jPxDTzauYgEo1aMagdmVpDjVIFPoA7xc+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=29YlNYnM2DdZ+kxuHHV6vjXlNq+Y15PLPSQmAkLDxyU=; b=o5rZHibsXebY/sFx/H+jgbOr4j3rnRzuteuXYh0R6oevbhOOKm1OLfaQhnQo6PUAxQMWuD0PhEw06Inf2+t0YC5UoyZAuZ2Cl/KyWLrVhP53N2dwU7SRXr3N+XqNCgm6UJvY+wpjr2mFHjttzV0v7x1Yo1t1NfKXA9DfAvPgUbU= To: Roger Pau Monne , CC: Ian Jackson , Wei Liu References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-4-roger.pau@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 03/21] libs/guest: introduce xc_cpu_policy_t Message-ID: <7f52bd98-24fd-95ba-f8c6-05a331941b49@citrix.com> Date: Wed, 31 Mar 2021 21:10:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210323095849.37858-4-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LNXP265CA0093.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::33) To BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5a7262ed-d330-455e-dbc7-08d8f481014a X-MS-TrafficTypeDiagnostic: BN6PR03MB2514: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dvxmBcic+4PqIiUxI6TFUMo6WtfDmoYQQBPTUXSn5L3wVR7Qi9nddqRXyB/HFRSLZ2P9Vsx+WLDQoK2TqPqMJc2rjAo6+kw3QR5xHMBOZs9SoZBOQTX1pHt/S1LCogqtKaJu5JHzSbY2EBEcbpdBjU5ujvQhrCA2zBnja0CkZk9Eg9Mu5XqgrSgQtZvhYmlfYz5ApFkRljpO9iTTNHVGZD4tieMsztrc1jQ0i1YGA58QpcIq2LOT8IRj+uHMYqtCUsh7DlAXKfCWtI+XHGODkDnecU6HoNnQTbria9G84YkwAY2ZK/VBugMD9rRKeWTNKXpOZC6JnTtg/pg4MSmqTD3hev/mvgEIaWhJ7KKLojPNcoC+pDrDPnFzMM632k7zfXRzRM1+74czjz0Wz+Woov/d7krj5yiXKUff0MwfXJi1B4TolNpyteWlj7UJb715mk9FunKFPeNJ1/tOkczlpeuY+1m3+18rW9smdzkf20etJNzKAp/+K6WaPLmYzPBuYfN365d0cqXlt1Jvd9oLEqekrX6mEoV7iI9HBeqgHtDmUvTYBbTPfALQvLfFzDcPhmBhfkXPZIGXhij7fqlU1uz5ZoKtNjn8E71aOk0gvz82Bz8CvsAxLZ2N7RTLFx1XoWpPJSEjpIJBzgfCNf2v4itZJ7Tdt9FDAcf8XdeoEDM0PVTbKEigUG+bgYrZdAwEC81THlpfVW9qr6EwvifKqZkbG0+Zoeg9LiMU4ZAv20U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(16526019)(36756003)(186003)(2616005)(956004)(6486002)(31686004)(16576012)(4326008)(478600001)(66476007)(66556008)(316002)(26005)(54906003)(5660300002)(66946007)(8936002)(53546011)(86362001)(31696002)(8676002)(38100700001)(2906002)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dnllV25wSTA0bkI0ZlJSeWtuZWRLZDlqOEo2Qk1relY4Skpmem85ZkVONXZJ?= =?utf-8?B?VWpsZXZsMmtmVFlUTGRiNWVCcHRhUkM3Q3NWK3lrWXNrbytJOHdBNFIyTk41?= =?utf-8?B?Z0F2bjJ3NlFTc2RzM09yTnp2a05Eb3Nha1dla1dmSmRIb25BQk5Ud0xvRE01?= =?utf-8?B?WVJyTWlJS21INjc2L293L1RVN2dHQWlzMFhOWEJrTTE0RHp2OU5LQ1luT3F2?= =?utf-8?B?SFA2WlNDbzIxV2p5WDdlV0dLenQwbmt6dllrTTRZc0EycmozVURzTkZvUFdY?= =?utf-8?B?ZjlRSy8xdkp6b1pjRjk4cnRWZ0NNKzJQUXlmTW93ZkJTN0o3REk1Um9wbDh2?= =?utf-8?B?MmR4cTkrdmNiU0dKNUdxZEEyTXZHUEFzcnQ3dmkrQUI0NDNjVFdjWEdFdkdu?= =?utf-8?B?TDdQdDF4YVl3MVRtenlPbVlPMWc0ZnBzMmtnWDA1Smt6YWhvald6eStJUitn?= =?utf-8?B?a2ZUV2tXTTBvOUJuR1AxTUlsQTZUK1ZyK2djYllsWFQ4WVdyK1V6bVhEeXUz?= =?utf-8?B?ZWVPdXdGcTYxRndPV0hvRnJQWXdxYXZEUHhnRzVuTDlFdkthVDdRQUVoRFRY?= =?utf-8?B?SW1sNzh6MllhMm5zSlozMWRJTEFXUnNKUmFDUVp4cDYwd05uWFd2eXBINGhp?= =?utf-8?B?WERnOGNkamNmQmZqaVlubzBmNnZ5YU9tei9FM3NOSE1sUUhlVURQcXJHbU42?= =?utf-8?B?aEMrN1BxeTNzZ3hJckRLWnkwMDIxZGp6VEJWUUphT2pUZEhwZXVTNERJUDZi?= =?utf-8?B?dzcxNkNxQzc3N0xOZkpvVC9lQ1BnNk85dUZtcSszeUFiZGJWMlI3QURVVXFY?= =?utf-8?B?QUVZV3RVeEpXRWlIbnQ1b2drTlI5OHJyalFBMjRPVXZuSVppYTRFQ2REQWNI?= =?utf-8?B?N2dCMW4vVHVIa24wOTIzSVBoSmVJNy9nYURJY1VReTZJNEdyWUc0WHRPWlFN?= =?utf-8?B?S1NENmcxS3pRL2x0bWRKK0tpVktZTlE0SUxyVFVRWFl3dVBPQkxoK2xjV25v?= =?utf-8?B?Z0YxYlBBTE40Nmp1WTJlOTZwemJlRnZCazMxejVtZUhQL2FCczJDbWdndHpM?= =?utf-8?B?WHRXTUNHZ3d5bUM0YzIxZTlqRkMxNVpQYVJlWG81aXhSSkIrUG5PQlBublZl?= =?utf-8?B?N0RVUnBFc01wR1BoYlhuM0hha1UzT2hhbTRTV3Ixb0lQQzA2dkEwaCtFM2dN?= =?utf-8?B?QUw4VnYxWGRXNnVzSGxQczVPVnYwTkF3dTJmSEpuUVdLUjNHQm82akhPSEZp?= =?utf-8?B?b0VZMW5DdTZKQmRpUFBGU2d1TURhUmVqcVk3TDhjN0UxM3NTekZ3RE9TalA4?= =?utf-8?B?ckd5d1pPT0dmLzhyOWhOUDIwT2UwSkhNRER6anJGbEZLcW8vY2hZc3FzdHho?= =?utf-8?B?WHRwdlBpa2xxcHdXZFVCc2dBaDk4ZGgwcGR5WmpVOC9lVDQ5c0I2YjJHYmRD?= =?utf-8?B?QithRHVLcTBGQ1gvc2MyZG9TZDEyRlM5UWRSa3FTNGhFQUdZTXZDaHFBWXB3?= =?utf-8?B?YUNyYlEzMEVmcUQyQ3YyamwxNzhycWRveUVOaHk4U0pZUThzRjVRc3ZmVmxl?= =?utf-8?B?Z3IvaG43T2UwYTZmVGhFZ29qUUdXRTk3N25JN1BUcllVMWZqREZMZkQyQTdV?= =?utf-8?B?NmVkUmFSRU42TG9YQ3pvTTF6UDFyZG5mTmt6QWROblI3MVJaMjBzOHRQblkx?= =?utf-8?B?b2RwOC8xQ2dGajlPM3dDRzVneHhhT3g5NDZDaTZtUjNoU1MxU0ZXa1gyaXB4?= =?utf-8?Q?VL94mx2QHHBBM8my0wk2ujpZfuApDYAn6NBdSBC?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5a7262ed-d330-455e-dbc7-08d8f481014a X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2021 20:10:18.3896 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vw5nEBKeO678Y8xXmwvzV0703MLhOgghR8i3F9bwalD82qGau5gvUdypxCGGPE5zqyXJrpuenEJvaTMq7dHu6P2SjdZZq4lPZUv4yyS6+R4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2514 X-OriginatorOrg: citrix.com On 23/03/2021 09:58, Roger Pau Monne wrote: > Introduce an opaque type that is used to store the CPUID and MSRs > policies of a domain. Such type uses the existing cpu_policy structure > to store the data, but doesn't expose the type to the users of the > xenguest library. > > Introduce an allocation (init) and freeing function (destroy) to > manage the type. > > Note the type is not yet used anywhere. > > Signed-off-by: Roger Pau Monn=C3=A9 > --- > tools/include/xenctrl.h | 6 ++++++ > tools/libs/guest/xg_cpuid_x86.c | 28 ++++++++++++++++++++++++++++ > 2 files changed, 34 insertions(+) > > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h > index e91ff92b9b1..ffb3024bfeb 100644 > --- a/tools/include/xenctrl.h > +++ b/tools/include/xenctrl.h > @@ -2590,6 +2590,12 @@ int xc_psr_get_domain_data(xc_interface *xch, uint= 32_t domid, > int xc_psr_get_hw_info(xc_interface *xch, uint32_t socket, > xc_psr_feat_type type, xc_psr_hw_info *hw_info); > =20 > +typedef struct cpu_policy *xc_cpu_policy_t; > + > +/* Create and free a xc_cpu_policy object. */ > +xc_cpu_policy_t xc_cpu_policy_init(void); > +void xc_cpu_policy_destroy(xc_cpu_policy_t policy); > + > int xc_get_cpu_levelling_caps(xc_interface *xch, uint32_t *caps); > int xc_get_cpu_featureset(xc_interface *xch, uint32_t index, > uint32_t *nr_features, uint32_t *featureset); > diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_= x86.c > index 9846f81e1f1..ade5281c178 100644 > --- a/tools/libs/guest/xg_cpuid_x86.c > +++ b/tools/libs/guest/xg_cpuid_x86.c > @@ -659,3 +659,31 @@ out: > =20 > return rc; > } > + > +xc_cpu_policy_t xc_cpu_policy_init(void) > +{ > + xc_cpu_policy_t policy =3D calloc(1, sizeof(*policy)); > + > + if ( !policy ) > + return NULL; > + > + policy->cpuid =3D calloc(1, sizeof(*policy->cpuid)); > + policy->msr =3D calloc(1, sizeof(*policy->msr)); > + if ( !policy->cpuid || !policy->msr ) > + { > + xc_cpu_policy_destroy(policy); > + return NULL; > + } > + > + return policy; > +} > + > +void xc_cpu_policy_destroy(xc_cpu_policy_t policy) > +{ > + if ( !policy ) > + return; > + > + free(policy->cpuid); > + free(policy->msr); > + free(policy); > +} Looking at the series as a whole, we have a fair quantity of complexity from short-lived dynamic allocations. I suspect that the code would be rather better if we had struct xc_cpu_policy { =C2=A0=C2=A0=C2=A0 struct cpuid_policy cpuid; =C2=A0=C2=A0=C2=A0 struct msr_policy msr; =C2=A0=C2=A0=C2=A0 xen_cpuid_leaf_t leaves[CPUID_MAX_SERIALISED_LEAVES]; =C2=A0=C2=A0=C2=A0 xen_msr_entry_t msrs[MSR_MAX_SERIALISED_ENTRIES]; =C2=A0=C2=A0=C2=A0 /* Names perhaps subject to improvement */ }; and just made one memory allocation. This is userspace after all, and we're taking about <4k at the moment. All operations with Xen need to bounce through the leaves/msrs encoding (so we're using the space a minimum of twice for any logical operation at the higher level), and several userspace-only operations use them too. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Mar 31 22:29:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 22:29:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104066.198608 (Exim 4.92) (envelope-from ) id 1lRjKN-0003FL-Tq; Wed, 31 Mar 2021 22:28:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104066.198608; Wed, 31 Mar 2021 22:28:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRjKN-0003FE-QJ; Wed, 31 Mar 2021 22:28:43 +0000 Received: by outflank-mailman (input) for mailman id 104066; Wed, 31 Mar 2021 22:28:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRjKL-0003F9-SD for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 22:28:41 +0000 Received: from mail-pj1-x102d.google.com (unknown [2607:f8b0:4864:20::102d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8aaa9b7c-1d23-4f34-a974-fbc95c8cacce; Wed, 31 Mar 2021 22:28:40 +0000 (UTC) Received: by mail-pj1-x102d.google.com with SMTP id f2-20020a17090a4a82b02900c67bf8dc69so1961179pjh.1 for ; Wed, 31 Mar 2021 15:28:40 -0700 (PDT) Received: from ?IPv6:2601:1c2:4f80:d230::5? ([2601:1c2:4f80:d230::5]) by smtp.gmail.com with ESMTPSA id l19sm3232027pjt.16.2021.03.31.15.28.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 15:28:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8aaa9b7c-1d23-4f34-a974-fbc95c8cacce DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:organization:cc:to:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=+LKgt4TcyAyJ1QqoZkm1no5mFekC4wFQ3fM5jafH8a0=; b=U58w9yYSLzlKklIEDGJoFfQhtG8W8GX3HPtxmc13jv4oBLY/EmXrKF7zCqSuIFnuzl XeWbCd/VMYUr9rEwJZbaDDXucM5yFNGnRcR8wtimGjC86cGvug3daE3CbjTBvaHPhplw jkeTDN4HGK7cQJmuFvTW9fWcWSYaeJK0DihH9YD7/70JMf4P+pS46QfO0LJEevic0t7q sYNrWapw9pjtJfrquvoAbzQu3mlPR9i6BGbl90ZjC1kIL2UDgjdrGuFfoWzxYmiBRoKc lecoNgx3OITAEJSsI2lBG7BG83oA9qBr+bN6wt2NysnmWSXZvG16Cm3u3mYSYxUa4qCn e2Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:organization:cc:to:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=+LKgt4TcyAyJ1QqoZkm1no5mFekC4wFQ3fM5jafH8a0=; b=TPxB5Ps8Sn8Nf6gOKlNVBwc7LhizWErAUxFxUhR34+jvqmxreu2AeLm8sI+P3XgOPk wjLGbVPY2T4HTWFVAl91OVjSdUwEoG0iDLn9ojN79J/3ak+1zUElHaoMZmN2zylbJURG 7YcIVxEbSLR58UmP6tSJwjlJv0UODACPkbg4rR6n7lCDZWtwuuwXixT9bq5RXBYk5b63 eBP6YWDq21KvKacfcO/iJ7OAsiHwd9b3h11bBHBh9Ub70otHUv3aSs4OzvYynF+vi7uU RfS3D7aw2ezerRiZRjK0uU/9lg3+T5oghyz4jPY1Opnov7k/jKIGnV9bb+do/4WOSYsw BJVg== X-Gm-Message-State: AOAM532vheWcaUckkGRbGUna91958xocvzRM6pHGF43Oshdq6nZRjo5v HQd8na5bHC1IzYLYpLcUDvI= X-Google-Smtp-Source: ABdhPJxm+h9yiZfB/eKTiS6v4zZth0YSRJ18MPbWWwjrN6i8x2QZGe+B7ZZjTaAqe8F2xX7RnU+97w== X-Received: by 2002:a17:90a:7e03:: with SMTP id i3mr5551404pjl.234.1617229719981; Wed, 31 Mar 2021 15:28:39 -0700 (PDT) From: Bob Eshleman Subject: Xen Secure Boot and Lockdown WG Meeting Summary - Mon, March 29, 2021 Organization: Vates SAS Cc: Andrew Cooper , Christopher Clark , "Daniel P. Smith" , Jan Beulich , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , =?UTF-8?B?TWljaGHFgiDFu3lnb3dza2k=?= , Olivier Lambert , =?UTF-8?Q?Piotr_Kr=c3=b3l?= , Rich Persaud , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Roman Shaposhnik , Trammell Hudson To: Xen-devel Message-ID: <14f458d5-a806-3364-5e83-6a03c7b05e9d@gmail.com> Date: Wed, 31 Mar 2021 15:28:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit # Xen Secure Boot and Lockdown This document summarizes the Xen Secure Boot and Lockdown WG meeting that occurred on Mon, March 29, 2021. We identified a list of requirements for locking down a Xen system that (at least) requires the following: ## Verified Boot Chain Various projects are underway already to support a verified boot chain that includes Xen and dom0. 1. via the EFI loader 1. Xen already supports verification of itself, the dom0 kernel, and the dom0 initrd, via a PE32+ bundle and the EFI loader. 2. Trenchboot 3. Add PE/COFF header to mb2 Xen (patches on ML, needs revision), allowing shim + grub2. ## Linux Lockdown in Dom0 1. Needs further testing, but seems to at least nominally work with QubesOS 1. QubesOS may be benefiting from outsourcing otherwise locked down functionality to stubdoms 3. Integrity checking for initrd 1. Not an issue for bundled xen.efi ## Xen Lockdown in Dom0 1. Live patching 2. Kexec 1. Will dom0 kexec need extending?  Probably just "plumbing" to work for Xen. 3. /priv/cmd 1. Violations of SB include: 1. set_trap_table 2. mmu_update 3. ... more ... (TODO: add to this list) 4. PCI Passthrough 1. usage of unstable Xen interfaces 2. PCI BARs mapping in guest 3. Interrupt routing setup 4. See other QEMU-related issues below 5. QEMU 1. I/O permissions 2. resets may be an issue 6. Xen command line 1. What parts are safe? and unsafe? 2. Allow safe options from unmeasured source The living version of this document, to be used to coordinate future work, is found here: https://cryptpad.fr/pad/#/2/pad/edit/IrfCfGH3l1Z2oUGlbBS2kiz6/ Please feel free to add to / edit the above document! The raw meeting notes can be found here: https://cryptpad.fr/pad/#/2/pad/edit/YHfyA-IbuEa3SLe-hsKVEjRC/ -- Bobby Eshleman SE at Vates SAS From xen-devel-bounces@lists.xenproject.org Wed Mar 31 23:29:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 31 Mar 2021 23:29:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.104069.198620 (Exim 4.92) (envelope-from ) id 1lRkGb-0008Np-D0; Wed, 31 Mar 2021 23:28:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104069.198620; Wed, 31 Mar 2021 23:28:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRkGb-0008Ni-9v; Wed, 31 Mar 2021 23:28:53 +0000 Received: by outflank-mailman (input) for mailman id 104069; Wed, 31 Mar 2021 23:28:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRkGZ-0008NX-Om; Wed, 31 Mar 2021 23:28:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRkGZ-0005Pv-Fy; Wed, 31 Mar 2021 23:28:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRkGZ-0008Be-3m; Wed, 31 Mar 2021 23:28:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lRkGZ-0003AW-31; Wed, 31 Mar 2021 23:28:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oXIIq2z5DSOVCU0uBjHyi7428NluRn/U66mbo6BR10A=; b=rWIvBW3Ep99fR57R54m4OUJLD3 BDMsQhPm175jT6NSTTF2w6Cq2cBxPPySC7y8AJ+gC7pKgFGJF0oZXff2YEsyfwpEefUFzkUNVuoKV vsaHhWefNH+vpEQAxhSJkuvFJE638JA5/dTwFYVG+DlINa91JEukhXemJjqvYZ3zjMn4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 160581: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=90629587e16e2efdb61da77f25c25fba3c4a5fd7 X-Osstest-Versions-That: xen=cead8c0d17462f3a1150b5657d3f4eaa88faf1cb From: osstest service owner Date: Wed, 31 Mar 2021 23:28:51 +0000 flight 160581 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160581/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 160559 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 160559 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 160559 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 160559 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 160559 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 160559 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 160559 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 160559 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 160559 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 160559 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 160559 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass version targeted for testing: xen 90629587e16e2efdb61da77f25c25fba3c4a5fd7 baseline version: xen cead8c0d17462f3a1150b5657d3f4eaa88faf1cb Last test of basis 160559 2021-03-30 13:03:24 Z 1 days Testing same since 160581 2021-03-31 08:40:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Marek Marczykowski-Górecki Roger Pau Monné Wei Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git cead8c0d17..90629587e1 90629587e16e2efdb61da77f25c25fba3c4a5fd7 -> master